Timeline
Feb 25, 2010:
- 11:40 PM Changeset in webkit [55270] by
-
- 2 edits in trunk/WebCore
<rdar://problem/7688455> REGRESSION(r55205): Crash inside dispatchEventsOnWindowAndFocusedNode when clicking link from bookmarks view
Reviewed by Brady Eidson.
Null-check the document's page to avoid dereferencing a null page.
No regression test is added as this appears to be dependent on an interaction with Safari's bookmarks view that is
not testable from within DumpRenderTree.
- page/FocusController.cpp:
(WebCore::dispatchEventsOnWindowAndFocusedNode):
- 10:49 PM Changeset in webkit [55269] by
-
- 4 edits in trunk/WebKit/chromium
2010-02-25 Darin Fisher <darin@chromium.org>
Reviewed by David Levin.
Remove deprecated cookie methods.
https://bugs.webkit.org/show_bug.cgi?id=35420
- public/WebFrameClient.h:
- public/WebKitClient.h:
- src/ChromiumBridge.cpp: (WebCore::ChromiumBridge::setCookies): (WebCore::ChromiumBridge::cookies): (WebCore::ChromiumBridge::cookieRequestHeaderFieldValue): (WebCore::ChromiumBridge::rawCookies): (WebCore::ChromiumBridge::deleteCookie): (WebCore::ChromiumBridge::cookiesEnabled):
- 8:56 PM QtWebKitMediaElementSupport edited by
- Added information about QtMultimedia Integration (diff)
- 5:32 PM Changeset in webkit [55268] by
-
- 4 edits1 add in trunk/WebKitTools
2010-02-25 Dirk Pranke <dpranke@chromium.org>
Reviewed by Eric Seidel.
Add a 'passing' port implementation to new-run-webkit-tests that
acts as a wrapper around an existing implementation but stubs out
the actual test invocations (instead, the expected results are echoed
back to the harness). This is useful for coverage and perf testing
of the harness (especially perf testing as it essentially provides
a lower bound on how fast the harness can run).
Also added a --nostart-helper flag to new-run-webkit-tests so that
you can skip starting the layout_test_helper and actually run the
harness even if you don't have a build of that port.
Also fix a bug in the 'test' port implementation to actually
create the results directory under /tmp instead of /.
- Scripts/webkitpy/layout_tests/port/factory.py: Modified.
- Scripts/webkitpy/layout_tests/port/passing.py: Added.
- Scripts/webkitpy/layout_tests/port/test.py: Added.
- Scripts/webkitpy/layout_tests/run_webkit_tests.py: Modified.
- 5:14 PM Changeset in webkit [55267] by
-
- 2 edits in trunk/WebKitTools
2010-02-25 Eric Seidel <eric@webkit.org>
Fix typo in my last change. No review.
Rename run-chromium-webkit-tests to new-run-webkit-tests to stop confusion
https://bugs.webkit.org/show_bug.cgi?id=35408
- Scripts/new-run-webkit-tests:
- 5:06 PM Changeset in webkit [55266] by
-
- 3 edits in trunk/WebCore
2010-02-25 Oliver Hunt <oliver@apple.com>
Reviewed by Simon Fraser.
Multiple repaints on apple.com
https://bugs.webkit.org/show_bug.cgi?id=35409
apple.com was triggering the fast scaling path for background images due to
repeated repaints as more content came in. This occured due to a two problems
in the logic to detect scaling. The first is that the main context is flipped
on mac so fails the identity or translation check. We work around this by adding
an function that allows the scaling for a flipped CTM. The other problem was that
we were looking at the destination rect size instead of the destination tile size
when deciding if the size we were drawn at would cause scaling.
- platform/graphics/transforms/AffineTransform.h: (WebCore::AffineTransform::isIdentityOrTranslationOrFlipped):
- rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelScaleObserver::shouldPaintBackgroundAtLowQuality): (WebCore::RenderBoxModelObject::paintFillLayerExtended):
- 4:55 PM Changeset in webkit [55265] by
-
- 1 edit2 adds in trunk/LayoutTests
2010-02-25 Dirk Pranke <dpranke@chromium.org>
Reviewed by Eric Seidel.
Test whether or not we preserve the hash fragments for "about:blank"
URLs. (Note that currently WebKit passes this but Chromium doesn't).
- fast/loader/about-blank-hash-kept-expected.txt: Added.
- fast/loader/about-blank-hash-kept.html: Added.
- 4:49 PM Changeset in webkit [55264] by
-
- 1 edit2 moves in trunk/WebKitTools
2010-02-25 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Rename run-chromium-webkit-tests to new-run-webkit-tests to stop confusion
https://bugs.webkit.org/show_bug.cgi?id=35408
- Scripts/new-run-webkit-tests: Added.
- Scripts/run-chromium-webkit-tests: Removed.
- Scripts/webkitpy/layout_tests/run_webkit_tests.py: Renamed from WebKitTools/Scripts/webkitpy/layout_tests/run_chromium_webkit_tests.py.
- 4:43 PM Changeset in webkit [55263] by
-
- 20 edits2 adds6 deletes in trunk
Extra layout on keypress after a space (problem with rebalanceWhitespaceAt in InsertTextCommand).
https://bugs.webkit.org/show_bug.cgi?id=30946
<rdar://problem/7639184>
Reviewed by Adele Peterson.
WebCore:
Do text insertion and whitespace rebalancing around the insertion in one step so that there's only one layout.
This patch was originally made by Justin Garcia.
Test: editing/inserting/rebalance-whitespace-1.html
- editing/CompositeEditCommand.cpp:
(WebCore::CompositeEditCommand::rebalanceWhitespaceAt): No behavior changes here,
just pushed the code that determined the extent of whitespace surrounding a position
to its own helper function.
- editing/InsertTextCommand.cpp:
(WebCore::InsertTextCommand::insertTextIntoNodeAndRebalanceWhitespace): Added. Find
whitespace surrounding the insertion position, add the text to insert, rebalance that entire
string, then insert it into the document.
(WebCore::InsertTextCommand::input):
- editing/InsertTextCommand.h:
- editing/htmlediting.cpp:
(WebCore::isWhitespace): Moved from CompositeEditCommand.cpp.
(WebCore::extentOfWhitespaceForRebalancingAt): Moved code from rebalanceWhitespaceAt into this helper
function. Obtains the offset of the start and end of whitespace around a particular position.
- editing/htmlediting.h:
LayoutTests:
There are now regular spaces where nbsps were used unnecessarily before. Also,
multi-character insertions now have their whitespace rebalanced, and this is
reflected in a few tests.
- editing/execCommand/5142012-3-expected.txt:
- editing/inserting/rebalance-whitespace-1-expected.txt: Added.
- editing/inserting/rebalance-whitespace-1.html: Added.
- editing/pasteboard/5521237-expected.txt:
- platform/mac/editing/execCommand/5482023-expected.checksum:
- platform/mac/editing/execCommand/5482023-expected.png: Removed.
- platform/mac/editing/execCommand/5482023-expected.txt:
- platform/mac/editing/execCommand/remove-formatting-2-expected.checksum:
- platform/mac/editing/execCommand/remove-formatting-2-expected.png: Removed.
- platform/mac/editing/execCommand/remove-formatting-expected.checksum:
- platform/mac/editing/execCommand/remove-formatting-expected.png: Removed.
- platform/mac/editing/execCommand/remove-formatting-expected.txt:
- platform/mac/editing/inserting/editable-html-element-expected.checksum:
- platform/mac/editing/inserting/editable-html-element-expected.png: Removed.
- platform/mac/editing/inserting/editable-html-element-expected.txt:
- platform/mac/editing/pasteboard/4989774-expected.checksum:
- platform/mac/editing/pasteboard/4989774-expected.png: Removed.
- platform/mac/editing/pasteboard/4989774-expected.txt:
- platform/mac/editing/selection/4983858-expected.checksum:
- platform/mac/editing/selection/4983858-expected.png: Removed.
- platform/mac/editing/selection/4983858-expected.txt:
- 4:22 PM Changeset in webkit [55262] by
-
- 10 edits2 adds in trunk
Reviewed by Anders Carlsson.
https://bugs.webkit.org/show_bug.cgi?id=35406
<rdar://problem/6945502> Make generic array methods work with JavaArray
Test: java/array-sort.html
Made RuntimeArray inherit from JSArray, keeping the promise given in ClassInfo.
- bridge/runtime_array.cpp: (JSC::RuntimeArray::RuntimeArray): (JSC::RuntimeArray::~RuntimeArray):
- bridge/runtime_array.h: (JSC::RuntimeArray::classInfo): (JSC::RuntimeArray::getConcreteArray):
- 3:21 PM Changeset in webkit [55261] by
-
- 2 edits in trunk/WebCore
Fixed a regression introduced in r44243, which made the assertion in checkListItems()
ineffective.
Reviewed by Alexey Proskuryakov.
- dom/SelectElement.cpp:
(WebCore::SelectElementData::checkListItems): Copy the items vector before recomputing it,
then assert that the newly-computed vector is equal to the copy.
- 3:04 PM Changeset in webkit [55260] by
-
- 8 edits4 adds in trunk
2010-02-25 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
SVG's tspan is no member of SVGRenderBase, this can cause crashes on filters
https://bugs.webkit.org/show_bug.cgi?id=35354
This makes the base class RenderSVGInline of RenderSVGTSpan and RenderSVGInlineText
dependent on SVGBaseRenderer.
The SVG spec want as to use the object bounding box of the text root as the bounding box
for text-childs. So we search for the text root and use it's bounding box, stroke rect and
repaint rect for further calculations.
Test: svg/filters/filter-on-tspan.svg
- rendering/RenderSVGInline.cpp: (WebCore::RenderSVGInline::objectBoundingBox): Find the text root and give back it's bounding box. (WebCore::RenderSVGInline::strokeBoundingBox): same for stroke rect (WebCore::RenderSVGInline::repaintRectInLocalCoordinates): same for repaint rect
- rendering/RenderSVGInline.h: (WebCore::RenderSVGInline::toSVGRenderBase): RenderSVGInline is part of SVGRenderBase now.
- rendering/RenderSVGTSpan.h: (WebCore::RenderSVGTSpan::renderName): Removed bounding box code. Was just a hack for filters and maskers.
- rendering/SVGRenderSupport.cpp: (WebCore::findTextRootObject): Search for the text root.
- rendering/SVGRenderSupport.h:
- svg/graphics/SVGPaintServerGradient.cpp: moved findTextRootObject to SVGRenderSupport
2010-02-25 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
SVG's tspan is no member of SVGRenderBase, this can cause crashes on filters
https://bugs.webkit.org/show_bug.cgi?id=35354
Check if filters work for tspan according to the SVG Spec. The test shouldn't
throw an assert now and a green rect should be visible.
- platform/mac/svg/filters/filter-on-tspan-expected.checksum: Added.
- platform/mac/svg/filters/filter-on-tspan-expected.png: Added.
- platform/mac/svg/filters/filter-on-tspan-expected.txt: Added.
- svg/filters/filter-on-tspan.svg: Added.
- 3:02 PM Changeset in webkit [55259] by
-
- 4 edits4 adds in trunk
2010-02-25 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
Use-element doesn't transform clipPath
https://bugs.webkit.org/show_bug.cgi?id=35375
If the use element is a child of clipPath, any settings on x, y or transform does not
transform the clipPath it references.
The use-element just misses this transformation in toClipPath.
Test: svg/custom/use-on-clip-path-with-transformation.svg
- platform/graphics/cairo/PathCairo.cpp: Gtk port translated the path to the wrong direction. (WebCore::Path::translate):
- svg/SVGUseElement.cpp: (WebCore::SVGUseElement::toClipPath):
2010-02-25 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
Use-element doesn't transform clipPath
https://bugs.webkit.org/show_bug.cgi?id=35375
Check if the clipPath gets transformed on setting a transform or translation for use.
- platform/mac/svg/custom/use-on-clip-path-with-transformation-expected.checksum: Added.
- platform/mac/svg/custom/use-on-clip-path-with-transformation-expected.png: Added.
- platform/mac/svg/custom/use-on-clip-path-with-transformation-expected.txt: Added.
- svg/custom/use-on-clip-path-with-transformation.svg: Added.
- 2:52 PM Changeset in webkit [55258] by
-
- 2 edits in trunk/JavaScriptCore
2010-02-25 Oliver Hunt <oliver@apple.com>
Reviewed by Geoff Garen.
JSC crashes like crazy in the JSPropertyNameIterator destructor
Add back null check of m_cachedStructure. Curse last minute changes.
- runtime/JSPropertyNameIterator.cpp: (JSC::JSPropertyNameIterator::~JSPropertyNameIterator):
- 2:30 PM Changeset in webkit [55257] by
-
- 7 edits in trunk
File.type support.
https://bugs.webkit.org/show_bug.cgi?id=35361
Reviewed by Dmitry Titov.
WebCore:
Test: LayoutTests/editing/pasteboard/file-input-files-access.html
- html/File.cpp:
(WebCore::File::File):
- html/File.h:
(WebCore::File::type):
- html/File.idl:
LayoutTests:
Update the layout test to test File.type.
- editing/pasteboard/file-input-files-access-expected.txt:
- editing/pasteboard/script-tests/file-input-files-access.js:
(fileListShouldBe):
(runTest):
- 2:15 PM Changeset in webkit [55256] by
-
- 7 edits in trunk
2010-02-25 Oliver Hunt <oliver@apple.com>
Reviewed by Maciej Stachowiak.
Race condition in JSPropertyNameIterator and Structure destruction
https://bugs.webkit.org/show_bug.cgi?id=35398
JSPropertyNameIterator and Structure have a cyclic dependency that they
manage by clearing the appropriate reference in each other during their
destruction. However if the Structure is destroyed while the
JSPropertyNameIterator is dead but not yet finalized the Structures
WeakGCPtr will return null, and so prevent Structure from clearing
the m_cachedStructure pointer of the iterator. When the iterator is
then finalised the m_cachedStructure is invalid, and the attempt to
clear the structures back reference fails.
To fix this we simply make JSPropertyNameIterator keep the Structure
alive, using the weak pointer to break the ref cycle.
- runtime/JSPropertyNameIterator.cpp: (JSC::JSPropertyNameIterator::~JSPropertyNameIterator): The iterator now keeps m_cachedStructure alive itself, so no longer needs to check for it being cleared
- runtime/JSPropertyNameIterator.h: (JSC::JSPropertyNameIterator::setCachedStructure): Add an assertion to ensure correct usage (JSC::JSPropertyNameIterator::cachedStructure): Add .get()
- runtime/Structure.cpp: (JSC::Structure::~Structure): Add an assertion that our iterator isn't already dead, and remove the now unnecessary attempt to clear the ref in the iterator
- runtime/WeakGCPtr.h: (JSC::WeakGCPtr::hasDeadObject): An assert-only function to allow us to assert correct behaviour in the Structure destructor
2010-02-25 Oliver Hunt <oliver@apple.com>
Reviewed by Maciej Stachowiak.
Race condition in JSPropertyNameIterator and Structure destruction
https://bugs.webkit.org/show_bug.cgi?id=35398
Add test to ensure that this race condition doesn't occur.
- fast/js/script-tests/for-in-cached.js: (cacheClearing):
- 2:14 PM Changeset in webkit [55255] by
-
- 2 edits in trunk/WebCore
2010-02-25 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Pavel Feldman.
Javascript console should not attempt to scroll to end of console if console is not visible
- inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.prototype._scheduleScrollIntoView.scrollIntoView): (WebInspector.ConsoleView.prototype._scheduleScrollIntoView): (WebInspector.ConsoleView.prototype.addMessage):
- 1:56 PM Changeset in webkit [55254] by
-
- 2 edits2 adds in trunk/WebKit/chromium
2010-02-25 James Hawkins <jhawkins@chromium.org>
Reviewed by Darin Fisher.
[Chromium] Implement WebLabelElement.
- WebKit.gyp:
- public/WebLabelElement.h: Added.
- src/WebLabelElement.cpp: Added.
- 1:04 PM Changeset in webkit [55253] by
-
- 3 edits in trunk/WebCore
Qt and Gtk build fixes.
- GNUmakefile.am:
- WebCore.pro: Added CRuntimeObject.{c,cpp}.
- 1:00 PM Changeset in webkit [55252] by
-
- 2 edits in trunk/WebCore
Windows build fix.
- WebCore.vcproj/WebCore.vcproj: Added CRuntimeObject.{c,cpp}.
- 12:56 PM Changeset in webkit [55251] by
-
- 2 edits in trunk/LayoutTests
Tiger build fix.
- java/Makefile: I can't get $(or ...) work on Tiger, so changed to use a single condition.
- 12:23 PM Changeset in webkit [55250] by
-
- 33 edits10 adds in trunk
Reviewed by Geoffrey Garen.
https://bugs.webkit.org/show_bug.cgi?id=35394
<rdar://problem/7685262> Make passing objects between Java and plug-ins work
- WebCore.PluginHostProcess.exp: WebKit now subclasses RuntimeObject, so it needed more exports.
- bridge/runtime_object.cpp: (JSC::Bindings::callRuntimeObject): (JSC::Bindings::callRuntimeConstructor): Assert that a runtime object is passed as function.
- bridge/runtime_object.h: Moved RuntimeObject into Bindings namespace, matching other related classes.
- bridge/jni/jni_jsobject.mm: (JavaJSObject::toString): Pass rootObject to convertValueToJValue(). It's not needed when constructing a string, but this function now takes it for the sake of Object. (JavaJSObject::convertValueToJObject): Check that object class is JavaRuntimeObject, not just RuntimeObject.
- bridge/jni/jsc/JNIBridgeJSC.cpp: (JavaField::setValueToInstance): Pass rootObject to convertValueToJValue(). (JavaArray::setValueAt): Ditto.
- bridge/jni/jsc/JNIUtilityPrivate.h: convertValueToJValue() now takes a RootObject argument, because one is needed to gcProtect an object ghtat is wrapped into JSObject.
- bridge/jni/jsc/JNIUtilityPrivate.cpp: (JSC::Bindings::convertValueToJValue): Convert JavaScript objects to Java JSObject ones. This was already happening in other code paths, which we should change to use common code.
- bridge/jni/jsc/JavaInstanceJSC.cpp: (JavaInstance::newRuntimeObject): Create an appropriate RuntimeObject subclass, which is JavaRuntimeObject for Java. (JavaInstance::invokeMethod): Unwrap returned JavaObjects that contain JS objects.
- WebCore.xcodeproj/project.pbxproj:
- bindings/objc/WebScriptObject.mm: (+[WebScriptObject _convertValueToObjcValue:originRootObject:rootObject:]):
- bridge/c/CRuntimeObject.cpp: Added. (JSC::Bindings::CRuntimeObject::CRuntimeObject): (JSC::Bindings::CRuntimeObject::~CRuntimeObject): (JSC::Bindings::CRuntimeObject::getInternalCInstance):
- bridge/c/CRuntimeObject.h: Added. (JSC::Bindings::CRuntimeObject::classInfo):
- bridge/c/c_instance.cpp: (JSC::Bindings::CInstance::newRuntimeObject):
- bridge/c/c_instance.h:
- bridge/c/c_utility.cpp: (JSC::Bindings::convertValueToNPVariant):
- bridge/jni/jsc/JavaInstanceJSC.h:
- bridge/jni/jsc/JavaRuntimeObject.cpp: Added. (JSC::Bindings::): (JSC::Bindings::JavaRuntimeObject::JavaRuntimeObject): (JSC::Bindings::JavaRuntimeObject::~JavaRuntimeObject): (JSC::Bindings::JavaRuntimeObject::getInternalJavaInstance):
- bridge/jni/jsc/JavaRuntimeObject.h: Added. (JSC::Bindings::JavaRuntimeObject::classInfo):
- bridge/jsc/BridgeJSC.h:
- bridge/objc/ObjCRuntimeObject.h: Added. (JSC::Bindings::ObjCRuntimeObject::classInfo):
- bridge/objc/ObjCRuntimeObject.mm: Added. (JSC::Bindings::): (JSC::Bindings::ObjCRuntimeObject::ObjCRuntimeObject): (JSC::Bindings::ObjCRuntimeObject::~ObjCRuntimeObject): (JSC::Bindings::ObjCRuntimeObject::getInternalObjCInstance):
- bridge/objc/objc_instance.h:
- bridge/objc/objc_instance.mm: (ObjcInstance::newRuntimeObject):
- bridge/objc/objc_runtime.mm: (JSC::Bindings::callObjCFallbackObject):
- bridge/runtime_root.h: Added RuntimeObject subclasses for each instance type, and use them for type casting.
- 10:57 AM Changeset in webkit [55249] by
-
- 20 edits in trunk
2010-02-25 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Rubber-stamped by Xan Lopez.
Adopt the same string as the one that is expected by
fast/parser/fragment-parser.html for the description used by the
<isindex> element.
- platform/gtk/LocalizedStringsGtk.cpp: (WebCore::searchableIndexIntroduction):
- 10:46 AM Changeset in webkit [55248] by
-
- 12 edits in trunk
2010-02-25 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: evaluate-on-hover does not work on HTML files.
- inspector/front-end/SourceCSSTokenizer.re2js:
- inspector/front-end/SourceHTMLTokenizer.js: (WebInspector.SourceHTMLTokenizer): (WebInspector.SourceHTMLTokenizer.prototype.set line): (WebInspector.SourceHTMLTokenizer.prototype._isExpectingAttribute): (WebInspector.SourceHTMLTokenizer.prototype._isExpectingAttributeValue): (WebInspector.SourceHTMLTokenizer.prototype._setExpectingAttribute): (WebInspector.SourceHTMLTokenizer.prototype._setExpectingAttributeValue): (WebInspector.SourceHTMLTokenizer.prototype._attrValueTokenType): (WebInspector.SourceHTMLTokenizer.prototype.nextToken):
- inspector/front-end/SourceHTMLTokenizer.re2js:
- inspector/front-end/SourceJavaScriptTokenizer.js: (WebInspector.SourceJavaScriptTokenizer):
- inspector/front-end/SourceJavaScriptTokenizer.re2js:
- inspector/front-end/SourceTokenizer.js: (WebInspector.SourceTokenizer.prototype.set condition): (WebInspector.SourceTokenizer.prototype.get condition): (WebInspector.SourceTokenizer.prototype.get subTokenizer): (WebInspector.SourceTokenizer.prototype.getLexCondition): (WebInspector.SourceTokenizer.prototype.setLexCondition):
- inspector/front-end/TextEditorHighlighter.js: (WebInspector.TextEditorHighlighter): (WebInspector.TextEditorHighlighter.prototype.set mimeType): (WebInspector.TextEditorHighlighter.prototype.highlight): (WebInspector.TextEditorHighlighter.prototype._highlightInChunks): (WebInspector.TextEditorHighlighter.prototype._highlightLines): (WebInspector.TextEditorHighlighter.prototype._highlightLine):
- inspector/front-end/TextViewer.js: (WebInspector.TextViewer.prototype._paintLine):
- 10:27 AM Changeset in webkit [55247] by
-
- 5 edits in trunk/JavaScriptCore
Make the context that was passed to the ThreadFunction accessible.
https://bugs.webkit.org/show_bug.cgi?id=35379
Patch by Jochen Eisinger <jochen@chromium.org> on 2010-02-25
Reviewed by Jeremy Orlow.
When a database is opened, right now you
don't have any context from where it is opened. The problem is that
the actual calls that open a database go through the sqlite3 vfs
layer, so there's no easy way to pass this function down to to
platform/sql/chromium/SQLFileSystemChromium*.cpp
This patch will allow you to get from anywhere within webkit a pointer
to the Thread object that actually created the thread you're currently
on (in case of the database, this can be either a thread forked of
from the main thread or from a worker thread), and query the object
for context information.
- wtf/Threading.h:
- wtf/ThreadingNone.cpp:
(WTF::threadContext):
- wtf/ThreadingPthreads.cpp:
(WTF::):
(WTF::identifierByPthreadHandle):
(WTF::establishIdentifierForPthreadHandle):
(WTF::pthreadHandleForIdentifier):
(WTF::contextForIdentifier):
(WTF::createThreadInternal):
(WTF::currentThread):
(WTF::threadContext):
- wtf/ThreadingWin.cpp:
(WTF::):
(WTF::threadMap):
(WTF::storeThreadHandleByIdentifier):
(WTF::threadHandleForIdentifier):
(WTF::contextForIdentifier):
(WTF::createThreadInternal):
(WTF::threadContext):
- 10:20 AM Changeset in webkit [55246] by
-
- 5 edits in trunk/JavaScriptCore
Reverting to re-submit with better change log.
- wtf/Threading.h:
- wtf/ThreadingNone.cpp:
(WTF::isMainThread):
- wtf/ThreadingPthreads.cpp:
(WTF::identifierByPthreadHandle):
(WTF::establishIdentifierForPthreadHandle):
(WTF::pthreadHandleForIdentifier):
(WTF::createThreadInternal):
(WTF::currentThread):
- wtf/ThreadingWin.cpp:
(WTF::threadMap):
(WTF::storeThreadHandleByIdentifier):
(WTF::threadHandleForIdentifier):
(WTF::createThreadInternal):
- 10:18 AM Changeset in webkit [55245] by
-
- 3 edits in trunk/WebKit/gtk
2010-02-25 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Xan Lopez.
[Gtk] crashed when destroying
https://bugs.webkit.org/show_bug.cgi?id=31271
NULL-check the page before relaying the focus out event, since
this might happen when destroying the widget without destroying
its parent, and we currently crash.
- tests/testwebview.c: (delayed_destroy): (test_webkit_web_view_destroy): (main):
- webkit/webkitwebview.cpp: (webkit_web_view_focus_in_event):
- 10:16 AM Changeset in webkit [55244] by
-
- 2 edits in trunk/WebCore
2010-02-25 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
Simple style cleanups.
- plugins/gtk/PluginViewGtk.cpp: (WebCore::plugRemovedCallback): (WebCore::plugAddedCallback): (WebCore::PluginView::platformStart):
- 10:16 AM Changeset in webkit [55243] by
-
- 3 edits in trunk/WebKitTools
2010-02-25 Adam Barth <abarth@webkit.org>
Reviewed by David Levin.
EWS leaks memory slowly
https://bugs.webkit.org/show_bug.cgi?id=35395
The EWS bots leak memory very slowly. If you run them for about a
month, each one will take up around 1 GB of virutal memory. If you run
several of them on one machine, you'll eventually exhaust all available
memory and grind the bots to a halt.
This patch introduces a --exit-after-iteration option to the queues so
that we run them for a finite amount of time. Once they exit and
restart, they'll reclaim the leaked memory. I'm not sure how many
iterations I'll end up running them for. I'll need to sort that out
operationally, but my initial guess is around 1000.
- Scripts/webkitpy/commands/queues.py:
- Scripts/webkitpy/commands/queues_unittest.py:
- 10:13 AM Changeset in webkit [55242] by
-
- 2 edits in trunk/WebCore
2010-02-25 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Darin Adler.
Optimize decoding of Latin-1 text by exploiting the fact that most of it will
be ASCII-only data.
- platform/text/TextCodecLatin1.cpp: (WebCore::TextCodecLatin1::decode):
- 9:55 AM Changeset in webkit [55241] by
-
- 6 edits in trunk
2010-02-25 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Dimitri Glazkov.
Web Inspector: make script lines count calculation lazy.
- inspector/front-end/Script.js: (WebInspector.Script): (WebInspector.Script.prototype.get linesCount):
- inspector/front-end/ScriptsPanel.js:
- inspector/front-end/SourceView.js: (WebInspector.SourceView.prototype._addBreakpoint):
- 9:20 AM Changeset in webkit [55240] by
-
- 5 edits in trunk/WebCore
Change hardcoded gcc paths to be Solaris friendly
https://bugs.webkit.org/show_bug.cgi?id=35213
Patch by James Choi <jchoi42@pha.jhu.edu> on 2010-02-25
Reviewed by David Levin.
- bindings/scripts/CodeGeneratorObjC.pm:
- bindings/scripts/IDLParser.pm:
- css/make-css-file-arrays.pl:
- dom/make_names.pl:
- 9:13 AM Changeset in webkit [55239] by
-
- 2 edits in trunk/WebKit/chromium
2010-02-24 Darin Fisher <darin@chromium.org>
Reviewed by David Levin.
Add a missing WebString.h include.
https://bugs.webkit.org/show_bug.cgi?id=35360
This is required since some of the methods have implementations that
return a WebString.
- public/WebCookieJar.h:
- 9:04 AM Changeset in webkit [55238] by
-
- 2 edits in trunk/WebCore
2010-02-25 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
Workaround Java plugins not drawing themselves properly on first
expose by doing a late size-allocate after 'plug-added' has been
emitted on the embedding GtkSocket. It's unclear to me if this is
a bug in our side or theirs, but this should be pretty safe and
fixes the annoyance while we investigate it further.
- plugins/gtk/PluginViewGtk.cpp: (WebCore::plugAddedCallback): (WebCore::PluginView::platformStart):
- 8:05 AM Changeset in webkit [55237] by
-
- 3 edits in trunk/WebCore
Add missing include guards
Reviewed by Tor Arne Vestbø.
- loader/CrossOriginPreflightResultCache.h:
- loader/MainResourceLoader.h:
- 8:04 AM Changeset in webkit [55236] by
-
- 2 edits in trunk/WebCore
[Qt] Restrict the optimization flags for Symbian to release builds.
Reviewed by Tor Arne Vestbø.
- WebCore.pro:
- 7:06 AM Changeset in webkit [55235] by
-
- 9 edits1 add in trunk
2010-02-25 Jarkko Sakkinen <jarkko.sakkinen@tieto.com>
Reviewed by Kenneth Rohde Christiansen.
Qt WebGL support
Adds GraphicsContext3D QtWebKit implementation.
https://bugs.webkit.org/show_bug.cgi?id=35153
- WebCore.pri:
- WebCore.pro:
- platform/graphics/GraphicsContext3D.h:
- platform/graphics/qt/GraphicsContext3DQt.cpp: Added. (WebCore::GraphicsContext3DInternal::isValid): (WebCore::GraphicsContext3DInternal::GraphicsContext3DInternal): (WebCore::GraphicsContext3DInternal::~GraphicsContext3DInternal): (WebCore::GraphicsContext3DInternal::getProcAddress): (WebCore::GraphicsContext3D::create): (WebCore::GraphicsContext3D::GraphicsContext3D): (WebCore::GraphicsContext3D::~GraphicsContext3D): (WebCore::GraphicsContext3D::platformGraphicsContext3D): (WebCore::GraphicsContext3D::platformTexture): (WebCore::GraphicsContext3D::makeContextCurrent): (WebCore::GraphicsContext3D::beginPaint): (WebCore::GraphicsContext3D::endPaint): (WebCore::GraphicsContext3D::reshape): (WebCore::GraphicsContext3D::activeTexture): (WebCore::GraphicsContext3D::attachShader): (WebCore::GraphicsContext3D::bindAttribLocation): (WebCore::GraphicsContext3D::bindBuffer): (WebCore::GraphicsContext3D::bindFramebuffer): (WebCore::GraphicsContext3D::bindRenderbuffer): (WebCore::GraphicsContext3D::bindTexture): (WebCore::GraphicsContext3D::blendColor): (WebCore::GraphicsContext3D::blendEquation): (WebCore::GraphicsContext3D::blendEquationSeparate): (WebCore::GraphicsContext3D::blendFunc): (WebCore::GraphicsContext3D::blendFuncSeparate): (WebCore::GraphicsContext3D::bufferData): (WebCore::GraphicsContext3D::bufferSubData): (WebCore::GraphicsContext3D::checkFramebufferStatus): (WebCore::GraphicsContext3D::clearColor): (WebCore::GraphicsContext3D::clear): (WebCore::GraphicsContext3D::clearDepth): (WebCore::GraphicsContext3D::clearStencil): (WebCore::GraphicsContext3D::colorMask): (WebCore::GraphicsContext3D::compileShader): (WebCore::GraphicsContext3D::copyTexImage2D): (WebCore::GraphicsContext3D::copyTexSubImage2D): (WebCore::GraphicsContext3D::cullFace): (WebCore::GraphicsContext3D::depthFunc): (WebCore::GraphicsContext3D::depthMask): (WebCore::GraphicsContext3D::depthRange): (WebCore::GraphicsContext3D::detachShader): (WebCore::GraphicsContext3D::disable): (WebCore::GraphicsContext3D::disableVertexAttribArray): (WebCore::GraphicsContext3D::drawArrays): (WebCore::GraphicsContext3D::drawElements): (WebCore::GraphicsContext3D::enable): (WebCore::GraphicsContext3D::enableVertexAttribArray): (WebCore::GraphicsContext3D::finish): (WebCore::GraphicsContext3D::flush): (WebCore::GraphicsContext3D::framebufferRenderbuffer): (WebCore::GraphicsContext3D::framebufferTexture2D): (WebCore::GraphicsContext3D::frontFace): (WebCore::GraphicsContext3D::generateMipmap): (WebCore::GraphicsContext3D::getActiveAttrib): (WebCore::GraphicsContext3D::getActiveUniform): (WebCore::GraphicsContext3D::getAttribLocation): (WebCore::GraphicsContext3D::getContextAttributes): (WebCore::GraphicsContext3D::getError): (WebCore::GraphicsContext3D::getString): (WebCore::GraphicsContext3D::hint): (WebCore::GraphicsContext3D::isBuffer): (WebCore::GraphicsContext3D::isEnabled): (WebCore::GraphicsContext3D::isFramebuffer): (WebCore::GraphicsContext3D::isProgram): (WebCore::GraphicsContext3D::isRenderbuffer): (WebCore::GraphicsContext3D::isShader): (WebCore::GraphicsContext3D::isTexture): (WebCore::GraphicsContext3D::lineWidth): (WebCore::GraphicsContext3D::linkProgram): (WebCore::GraphicsContext3D::pixelStorei): (WebCore::GraphicsContext3D::polygonOffset): (WebCore::GraphicsContext3D::readPixels): (WebCore::GraphicsContext3D::releaseShaderCompiler): (WebCore::GraphicsContext3D::renderbufferStorage): (WebCore::GraphicsContext3D::sampleCoverage): (WebCore::GraphicsContext3D::scissor): (WebCore::GraphicsContext3D::shaderSource): (WebCore::GraphicsContext3D::stencilFunc): (WebCore::GraphicsContext3D::stencilFuncSeparate): (WebCore::GraphicsContext3D::stencilMask): (WebCore::GraphicsContext3D::stencilMaskSeparate): (WebCore::GraphicsContext3D::stencilOp): (WebCore::GraphicsContext3D::stencilOpSeparate): (WebCore::GraphicsContext3D::texParameterf): (WebCore::GraphicsContext3D::texParameteri): (WebCore::GraphicsContext3D::uniform1f): (WebCore::GraphicsContext3D::uniform1fv): (WebCore::GraphicsContext3D::uniform2f): (WebCore::GraphicsContext3D::uniform2fv): (WebCore::GraphicsContext3D::uniform3f): (WebCore::GraphicsContext3D::uniform3fv): (WebCore::GraphicsContext3D::uniform4f): (WebCore::GraphicsContext3D::uniform4fv): (WebCore::GraphicsContext3D::uniform1i): (WebCore::GraphicsContext3D::uniform1iv): (WebCore::GraphicsContext3D::uniform2i): (WebCore::GraphicsContext3D::uniform2iv): (WebCore::GraphicsContext3D::uniform3i): (WebCore::GraphicsContext3D::uniform3iv): (WebCore::GraphicsContext3D::uniform4i): (WebCore::GraphicsContext3D::uniform4iv): (WebCore::GraphicsContext3D::uniformMatrix2fv): (WebCore::GraphicsContext3D::uniformMatrix3fv): (WebCore::GraphicsContext3D::uniformMatrix4fv): (WebCore::GraphicsContext3D::useProgram): (WebCore::GraphicsContext3D::validateProgram): (WebCore::GraphicsContext3D::vertexAttrib1f): (WebCore::GraphicsContext3D::vertexAttrib1fv): (WebCore::GraphicsContext3D::vertexAttrib2f): (WebCore::GraphicsContext3D::vertexAttrib2fv): (WebCore::GraphicsContext3D::vertexAttrib3f): (WebCore::GraphicsContext3D::vertexAttrib3fv): (WebCore::GraphicsContext3D::vertexAttrib4f): (WebCore::GraphicsContext3D::vertexAttrib4fv): (WebCore::GraphicsContext3D::vertexAttribPointer): (WebCore::GraphicsContext3D::viewport): (WebCore::GraphicsContext3D::getBooleanv): (WebCore::GraphicsContext3D::getBufferParameteriv): (WebCore::GraphicsContext3D::getFloatv): (WebCore::GraphicsContext3D::getFramebufferAttachmentParameteriv): (WebCore::GraphicsContext3D::getIntegerv): (WebCore::GraphicsContext3D::getProgramiv): (WebCore::GraphicsContext3D::getProgramInfoLog): (WebCore::GraphicsContext3D::getRenderbufferParameteriv): (WebCore::GraphicsContext3D::getShaderiv): (WebCore::GraphicsContext3D::getShaderInfoLog): (WebCore::GraphicsContext3D::getShaderSource): (WebCore::GraphicsContext3D::getTexParameterfv): (WebCore::GraphicsContext3D::getTexParameteriv): (WebCore::GraphicsContext3D::getUniformfv): (WebCore::GraphicsContext3D::getUniformiv): (WebCore::GraphicsContext3D::getUniformLocation): (WebCore::GraphicsContext3D::getVertexAttribfv): (WebCore::GraphicsContext3D::getVertexAttribiv): (WebCore::GraphicsContext3D::getVertexAttribOffset): (WebCore::GraphicsContext3D::texImage2D): (WebCore::GraphicsContext3D::texSubImage2D): (WebCore::GraphicsContext3D::createBuffer): (WebCore::GraphicsContext3D::createFramebuffer): (WebCore::GraphicsContext3D::createProgram): (WebCore::GraphicsContext3D::createRenderbuffer): (WebCore::GraphicsContext3D::createShader): (WebCore::GraphicsContext3D::createTexture): (WebCore::GraphicsContext3D::deleteBuffer): (WebCore::GraphicsContext3D::deleteFramebuffer): (WebCore::GraphicsContext3D::deleteProgram): (WebCore::GraphicsContext3D::deleteRenderbuffer): (WebCore::GraphicsContext3D::deleteShader): (WebCore::GraphicsContext3D::deleteTexture): (WebCore::GraphicsContext3D::sizeInBytes): (WebCore::GraphicsContext3D::synthesizeGLError): (WebCore::GraphicsContext3D::getImageData):
2010-02-25 Jarkko Sakkinen <jarkko.sakkinen@tieto.com>
Reviewed by Kenneth Rohde Christiansen.
Qt WebGL support
Adds enabling and disabling of WebGL support to QWebSettings.
https://bugs.webkit.org/show_bug.cgi?id=35153
- Api/qwebsettings.cpp: (QWebSettingsPrivate::apply): (QWebSettings::QWebSettings):
- Api/qwebsettings.h:
2010-02-25 Jarkko Sakkinen <jarkko.sakkinen@tieto.com>
Reviewed by Kenneth Rohde Christiansen.
Qt WebGL support
Adds toggling of WebGL support to QtLauncher.
https://bugs.webkit.org/show_bug.cgi?id=35153
- QtLauncher/main.cpp: (LauncherWindow::toggleWebGL): (LauncherWindow::setupUI):
- 6:52 AM BuildingQtOnSymbian edited by
- (diff)
- 6:50 AM BuildingQtOnSymbian edited by
- (diff)
- 6:49 AM Changeset in webkit [55234] by
-
- 5 edits in trunk/JavaScriptCore
2010-02-25 Jochen Eisinger <jochen@chromium.org>
Reviewed by Jeremy Orlow.
Make the context that was passed to the ThreadFunction accessible.
https://bugs.webkit.org/show_bug.cgi?id=35379
- wtf/Threading.h:
- wtf/ThreadingNone.cpp: (WTF::threadContext):
- wtf/ThreadingPthreads.cpp: (WTF::): (WTF::identifierByPthreadHandle): (WTF::establishIdentifierForPthreadHandle): (WTF::pthreadHandleForIdentifier): (WTF::contextForIdentifier): (WTF::createThreadInternal): (WTF::currentThread): (WTF::threadContext):
- wtf/ThreadingWin.cpp: (WTF::): (WTF::threadMap): (WTF::storeThreadHandleByIdentifier): (WTF::threadHandleForIdentifier): (WTF::contextForIdentifier): (WTF::createThreadInternal): (WTF::threadContext):
- 6:34 AM Changeset in webkit [55233] by
-
- 4 edits2 moves in trunk/WebCore
2010-02-25 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: Swap images for activate and deactivate breakpoints.
- WebCore.gypi:
- inspector/front-end/Images/breakpointsActivateButtonGlyph.png: Renamed from WebCore/inspector/front-end/Images/deactivateBreakpointsButtonGlyph.png.
- inspector/front-end/Images/breakpointsDeactivateButtonGlyph.png: Renamed from WebCore/inspector/front-end/Images/deactivateBreakpointsDisabledButtonGlyph.png.
- inspector/front-end/WebKit.qrc:
- inspector/front-end/inspector.css:
- 6:19 AM Changeset in webkit [55232] by
-
- 2 edits in trunk/WebCore
2010-02-25 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Xan Lopez.
Go back on symlink resolution if we are loading the flash plugin,
and the path contains /netscape/, following what Chromium does.
Thanks to Evan Martin for the help on this!
- plugins/gtk/PluginPackageGtk.cpp: (WebCore::PluginPackage::load):
- 5:45 AM Changeset in webkit [55231] by
-
- 8 edits in trunk/WebCore
2010-02-23 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: Scripts panel shows blank source when stopping on a breakpoint on refresh.
- inspector/front-end/Panel.js: (WebInspector.Panel.prototype.canShowSourceLine): (WebInspector.Panel.prototype.showSourceLine):
- inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype.canShowSourceLine): (WebInspector.ResourcesPanel.prototype.showSourceLine):
- inspector/front-end/Script.js: (WebInspector.Script):
- inspector/front-end/ScriptView.js: (WebInspector.ScriptView.prototype.setupSourceFrameIfNeeded):
- inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype.show): (WebInspector.ScriptsPanel.prototype.get searchableViews): (WebInspector.ScriptsPanel.prototype.addScript): (WebInspector.ScriptsPanel.prototype._resourceLoadingFinished): (WebInspector.ScriptsPanel.prototype.addBreakpoint): (WebInspector.ScriptsPanel.prototype.removeBreakpoint): (WebInspector.ScriptsPanel.prototype.reset): (WebInspector.ScriptsPanel.prototype.canShowSourceLine): (WebInspector.ScriptsPanel.prototype.showSourceLine): (WebInspector.ScriptsPanel.prototype._scriptOrResourceForURLAndLine): (WebInspector.ScriptsPanel.prototype.showView): (WebInspector.ScriptsPanel.prototype._sourceFrameForScriptOrResource): (WebInspector.ScriptsPanel.prototype._showScriptOrResource): (WebInspector.ScriptsPanel.prototype._addScriptToFilesMenu.optionCompare): (WebInspector.ScriptsPanel.prototype._addScriptToFilesMenu):
- inspector/front-end/SourceView.js: (WebInspector.SourceView.prototype._addBreakpoint):
- inspector/front-end/inspector.js: (WebInspector.documentClick.followLink): (WebInspector.documentClick): (WebInspector._choosePanelToShowSourceLine): (WebInspector.canShowSourceLine): (WebInspector.showSourceLine):
- 5:24 AM Changeset in webkit [55230] by
-
- 10 edits3 adds in trunk
2010-02-25 Ben Murdoch <benm@google.com>
Reviewed by Kenneth Rohde Christiansen.
The target element of a Touch should be the target where that touch originated, not where it is now.
https://bugs.webkit.org/show_bug.cgi?id=34585
- fast/events/touch/basic-single-touch-events-expected.txt: Update expected target element.
- fast/events/touch/script-tests/basic-single-touch-events.js: ditto.
- fast/events/touch/script-tests/touch-target.js: Added.
- fast/events/touch/touch-target-expected.txt: Added.
- fast/events/touch/touch-target.html: Added.
2010-02-25 Ben Murdoch <benm@google.com>
Reviewed by Kenneth Rohde Christiansen.
The target element of a Touch should be the target where that touch originated, not where it is now.
https://bugs.webkit.org/show_bug.cgi?id=34585
Currently the target of a touch is set to the resulting node of the hit test where the touch currently
is. This does not match the behavior of iPhone or Android. This patch uses a hashmap on the EventHandler
to keep track of the target element when a touch is first started. This target is then used as the target
for subsequent touches with the same id. This matches observed behavior on iPhone and Android.
Tests:
fast/events/touch/touch-target.html: Added.
fast/events/touch/basic-single-touch-events.html: Updated.
- page/EventHandler.cpp: (WebCore::EventHandler::handleTouchEvent): Store the originating target element of a touch in a hashmap
so that we can reuse that target for future events caused by that touch. This matches observed behavior
on iPhone and Android.
- page/EventHandler.h: Add hashmap as a member.
- platform/PlatformTouchPoint.h: (WebCore::PlatformTouchPoint::id): Store the touch point id as unsigned.
- platform/qt/PlatformTouchPointQt.cpp: (WebCore::PlatformTouchPoint::PlatformTouchPoint): Cast platform touch id from signed to unsigned. Qt API
docs state that it will always be >= 0.
2010-02-25 Ben Murdoch <benm@google.com>
Reviewed by Kenneth Rohde Christiansen.
The target element of a Touch should be the target where that touch originated, not where it is now.
https://bugs.webkit.org/show_bug.cgi?id=34585
- DumpRenderTree/qt/EventSenderQt.cpp: (EventSender::addTouchPoint): Fix a bug where touch points were not being given unique ids.
- 4:49 AM Changeset in webkit [55229] by
-
- 2 edits in trunk/LayoutTests
2010-02-25 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
Unskip a bunch of (AFAICT) non-flakey HTTP tests that we currently
pass.
- platform/gtk/Skipped:
- 3:48 AM Changeset in webkit [55228] by
-
- 2 edits in trunk/WebCore
Add a convenient center() method to IntRect
https://bugs.webkit.org/show_bug.cgi?id=35346
Reviewed by Simon Fraser.
Patch by Antonio Gomes <tonikitoo@webkit.org>
As it is a convenience method, and implemention is
based on FloatRect's one, patch does not provide a
layout test.
- platform/graphics/IntRect.h:
(WebCore::IntRect::center):
- 3:24 AM Changeset in webkit [55227] by
-
- 11 edits1 add in trunk/WebCore
2010-02-25 Andrey Kosyakov <caseq@chromium.org>
Reviewed by Pavel Feldman.
Fake workers implementation that simulates workers using iframe and timer,
needed to support workers debugging. Also, a facility to inject scripts into
inspected page upon load.
https://bugs.webkit.org/show_bug.cgi?id=35148
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- inspector/InspectorBackend.cpp: (WebCore::InspectorBackend::addScriptToEvaluateOnLoad): (WebCore::InspectorBackend::removeAllScriptsToEvaluateOnLoad):
- inspector/InspectorBackend.h:
- inspector/InspectorBackend.idl:
- inspector/InspectorController.cpp: (WebCore::InspectorController::didCommitLoad): (WebCore::InspectorController::addScriptToEvaluateOnLoad): (WebCore::InspectorController::removeAllScriptsToEvaluateOnLoad):
- inspector/InspectorController.h:
- inspector/front-end/InjectedFakeWorker.js: Added. (InjectedFakeWorker.Worker): (InjectedFakeWorker.FakeWorker): (InjectedFakeWorker.FakeWorker.prototype.postMessage): (InjectedFakeWorker.FakeWorker.prototype.terminate): (InjectedFakeWorker.FakeWorker.prototype._onmessageWrapper): (InjectedFakeWorker.FakeWorker.prototype._dispatchMessage): (InjectedFakeWorker.FakeWorker.prototype._handleException): (InjectedFakeWorker.FakeWorker.prototype._buildWorker): (InjectedFakeWorker.FakeWorker.prototype._setupWorkerContext.handler): (InjectedFakeWorker.FakeWorker.prototype._setupWorkerContext): (InjectedFakeWorker.FakeWorker.prototype._importScripts): (InjectedFakeWorker.FakeWorker.prototype._loadScript): (InjectedFakeWorker.URL): (InjectedFakeWorker.URL.prototype.urlRegEx.split): (InjectedFakeWorker.URL.prototype.mockLocation): (InjectedFakeWorker.URL.prototype.completeWith): (InjectedFakeWorker.URL.prototype.sameOrigin): (InjectedFakeWorker.DOMCoreException.formatError): (InjectedFakeWorker.DOMCoreException): (InjectedFakeWorker.noop):
- inspector/front-end/InspectorBackendStub.js: (.WebInspector.InspectorBackendStub.prototype.setInjectedScriptSource): (.WebInspector.InspectorBackendStub.prototype.addScriptToEvaluateOnLoad): (.WebInspector.InspectorBackendStub.prototype.removeAllScriptsToEvaluateOnLoad):
- inspector/front-end/WebKit.qrc:
- inspector/front-end/inspector.html:
- 2:04 AM BuildingQtOnWindows edited by
- (diff)
Feb 24, 2010:
- 11:30 PM Changeset in webkit [55226] by
-
- 5 edits in trunk
2010-02-24 Sam Kerner <skerner@chromium.org>
Reviewed by Darin Fisher.
Expose WebFrame::setCanHaveScrollbars(). This allows a view
which is being resized to not need scroll bars to ensure that
they are not drawn.
Existing function setAllowsScrolling() was renamed
setCanHaveScrollbars(), to be consistant with change 37159:
http://trac.webkit.org/changeset/37159
- WebKit/chromium/public/WebFrame.h:
- WebKit/chromium/src/ChromeClientImpl.cpp:
- WebKit/chromium/src/WebFrameImpl.cpp:
- WebKit/chromium/src/WebFrameImpl.h:
- 11:14 PM Changeset in webkit [55225] by
-
- 4 edits in trunk/WebCore
2010-02-24 Nicholas Young <nicholas.young@nokia.com>
Reviewed by Eric Carlson.
Add mediaPlayerOwningDocument() to MediaPlayerClient.
https://bugs.webkit.org/show_bug.cgi?id=35374
No new tests. These are interface changes only.
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::mediaPlayerOwningDocument): Implementation for media element.
- html/HTMLMediaElement.h:
- platform/graphics/MediaPlayer.h: (WebCore::MediaPlayerClient::mediaPlayerOwningDocument): New virtual method.
- 10:56 PM Changeset in webkit [55224] by
-
- 2 edits in trunk/WebCore
2010-02-24 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
Optimized Font::normalizeSpaces() by caching the String::characters()
instead of repeatedly calling operator[]
- platform/graphics/Font.cpp: (WebCore::Font::normalizeSpaces):
- 10:32 PM Changeset in webkit [55223] by
-
- 2 edits in trunk/WebCore
2010-02-24 Jungshik Shin <jshin@chromium.org>
Reviewed by David Levin.
[Chromium] Traditional Chinese Chrome on Windows should use PMingLiu instead of Simsun for Han characters
https://bugs.webkit.org/show_bug.cgi?id=35319
No visible change in the layout test.
- platform/graphics/chromium/FontUtilsChromiumWin.cpp: (WebCore::):
- 10:28 PM Changeset in webkit [55222] by
-
- 4 edits in trunk/WebKit/gtk
2010-02-24 Krzysztof Kotlenga <pocek@users.sf.net>
Reviewed by Gustavo Noronha Silva.
[Gtk] Creation of a WebkitWebView widget is very slow
https://bugs.webkit.org/show_bug.cgi?id=30032
- WebCoreSupport/EditorClientGtk.cpp: (WebKit::EditorClient::ignoreWordInSpellDocument): Change 'langs' to 'dicts' to reflect the fact that the list just holds Enchant dictionaries now. (WebKit::EditorClient::learnWord): Ditto. (WebKit::EditorClient::checkSpellingOfString): Ditto. (WebKit::EditorClient::getGuessesForWord): Ditto.
- webkit/webkitprivate.h: Remove the now unused SpellLanguage struct.
- webkit/webkitwebsettings.cpp: Change function call to reflect new webkit_web_settings_get_enchant_dicts name. (get_enchant_broker): Add this method which returns the enchant broker singleton. (free_spell_checking_language): The list contents have changed, so change the way each element is freed. (webkit_web_settings_finalize): Change to reflect 'spell_checking_languages_list' to 'enchant_dicts' member name change. (webkit_web_settings_set_property): Use the broker singleton here instead of making a new one for each language. The Enchant dictionary is now the list payload. (webkit_web_settings_copy): More name-change updates. (webkit_web_settings_get_enchant_dicts): Ditto.
- 10:15 PM Changeset in webkit [55221] by
-
- 2 edits in trunk/WebCore
2010-02-24 Anthony Ricaud <rik@webkit.org>
Reviewed by Pavel Feldman.
Web Inspector: Reduce the timer to show the eval popover
https://bugs.webkit.org/show_bug.cgi?id=35344
- inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype._mouseMove):
- 9:40 PM Changeset in webkit [55220] by
-
- 1 edit2 adds in trunk/LayoutTests
2010-02-24 Chris Evans <cevans@chromium.org>
Reviewed by Darin Adler.
Add test for SVG that used to cause crash.
It has been fixed on trunk for a while, thanks to the <use> rewrite,
but we want to make sure we do not regress.
- svg/dom/use-transform.svg: Added.
- svg/dom/use-transform-expected.txt: Added.
- 9:24 PM Changeset in webkit [55219] by
-
- 3 edits1 add in trunk
2010-02-24 Jay Campan <jcampan@google.com>
Reviewed by David Levin.
Don't show the autofill popup when the input text is disabled or read only.
Test: manual-tests/chromium/no-autofill-on-readonly.html
- src/EditorClientImpl.cpp: (WebKit::EditorClientImpl::autofill):
- manual-tests/chromium/no-autofill-on-readonly.html: Added.
2010-02-24 Jay Campan <jcampan@google.com>
Reviewed by David Levin.
Don't show the autofill popup when the input text is disabled or read only.
- src/EditorClientImpl.cpp: (WebKit::EditorClientImpl::autofill):
- 9:07 PM Changeset in webkit [55218] by
-
- 2 edits in trunk/WebKitTools
2010-02-24 Jesus Sanchez-Palencia <jesus.palencia@openbossa.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] QtLauncher has a border when running on QGraphicsView mode
https://bugs.webkit.org/show_bug.cgi?id=35352
Fix 2-pixels frame on each border of QtLauncher when running on QGraphicsView mode.
- QtLauncher/webview.cpp: (WebViewGraphicsBased::WebViewGraphicsBased):
- 8:43 PM Changeset in webkit [55217] by
-
- 8 edits in trunk/WebCore
2010-02-24 Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed by Jeremy Orlow.
Wraps includes of SVG headers so that it's possible to
compile the V8 bindings with SVG disabled, e.g. 'enable_svg=0'.
https://bugs.webkit.org/show_bug.cgi?id=35345
No new tests.
- bindings/v8/V8DOMWrapper.cpp:
- bindings/v8/V8Proxy.cpp:
- bindings/v8/custom/V8CSSValueCustom.cpp:
- bindings/v8/custom/V8DocumentCustom.cpp:
- bindings/v8/custom/V8ElementCustom.cpp:
- bindings/v8/custom/V8EventCustom.cpp:
- bindings/v8/custom/V8SVGElementCustom.cpp:
- 8:15 PM Changeset in webkit [55216] by
-
- 3 edits in trunk/WebCore
Unreviewed build fix.
Fix gtk build.
Include JSC headers as runtime/ instead of JavaScriptCore/
- bindings/js/JSDOMWrapper.h:
- bindings/js/ScriptWrappable.h:
- 8:07 PM Changeset in webkit [55215] by
-
- 12 edits2 adds in trunk/WebCore
2010-02-24 Maciej Stachowiak <mjs@apple.com>
Reviewed by Oliver Hunt.
Cache JavaScript wrappers inline in DOM nodes
https://bugs.webkit.org/show_bug.cgi?id=35226
<rdar://problem/7664202>
7.4% speedup on Dromaeo DOM Core tests.
2.3% speedup on Hixie DOM Core tests.
This fixes the following things from the last attempt:
- Now builds in both debug and release and passes all tests
- Properly use a WeakGCPtr, not just a raw pointer, in ScriptWrappable
- Properly look in the appropriate per-document or per-world map
- Added an assert that would have caught any of the problems I found
- Handle clearing the inline cache properly in all cases
- bindings/js/JSDOMBinding.cpp: (WebCore::cacheDOMObjectWrapper): Adjust for name changes. (WebCore::forgetDOMNode): Clear wrapper pointer. (WebCore::cacheDOMNodeWrapper): Cache inline too if caching for normal world.
- bindings/js/JSDOMBinding.h: (WebCore::Document::getWrapperCache): Inlined. (WebCore::domObjectWrapperMapFor): Renamed to start with lowercase. Moved to header to inline.
- bindings/js/JSDOMWrapper.h: Added. (WebCore::DOMObject::DOMObject): Factored this out of JSDOMBinding.h to avoid include cycle. I think the class should be renamed, I picked a forward-looking header name because we already have a DOMObject.h
- bindings/js/JSNodeCustom.cpp: (WebCore::createWrapperInline): Renamed version of original createWrapper. (WebCore::createWrapper): Call createWrapperInline. Out-of-line version. (WebCore::toJSNewlyCreated): Call createWrapperInline instead of createWrapper.
- bindings/js/JSNodeCustom.h: Added. (WebCore::getCachedDOMNodeWrapper): Moved from JSDOMBinding.cpp and moved here, so it could inline everywhere without creating an include cycle. Consider inline cache. (WebCore::toJS): Moved to header to inline.
- bindings/js/ScriptWrappable.h: (WebCore::ScriptWrappable::ScriptWrappable): Implement this in the obvious way for JavaScriptCore. (Using a WeakGCPtr). (WebCore::ScriptWrappable::wrapper): (WebCore::ScriptWrappable::setWrapper): (WebCore::ScriptWrappable::clearWrapper):
- bindings/scripts/CodeGeneratorJS.pm: Include CustomHeader heaaders in the header, not just the impl file, so they can add inlining.
- dom/Node.idl: Add CustomHeader directive.
Add new files to build.
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- 7:51 PM Changeset in webkit [55214] by
-
- 3 edits in trunk/WebCore
2010-02-24 Jochen Eisinger <jochen@chromium.org>
Reviewed by Jeremy Orlow.
Expose Database object of currently active task on the database thread
https://bugs.webkit.org/show_bug.cgi?id=35341
- storage/DatabaseThread.cpp: (WebCore::DatabaseThread::DatabaseThread): (WebCore::DatabaseThread::databaseThread):
- storage/DatabaseThread.h: (WebCore::DatabaseThread::getDatabaseOfCurrentTask):
- 7:34 PM Changeset in webkit [55213] by
-
- 4 edits in trunk/WebCore
2010-02-24 Nicholas Young <nicholas.young@nokia.com>
Reviewed by Eric Carlson.
supportsMuting() should be an internal interface between MediaPlayer and MediaPlayerPrivate.
https://bugs.webkit.org/show_bug.cgi?id=35327
No new tests. Refactoring Only.
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::setMuted): Do not check supportsMuting() (WebCore::HTMLMediaElement::updateVolume): Set volume and muted
- platform/graphics/MediaPlayer.cpp: (WebCore::MediaPlayer::setVolume): Check supportsMuting() (WebCore::MediaPlayer::setMuted): Check supportsMuting()
- platform/graphics/MediaPlayer.h: Remove supportsMuting()
- 6:46 PM Changeset in webkit [55212] by
-
- 2 edits in trunk/LayoutTests
Rubber-stamped by Anders Carlsson.
Keep this test’s behavior the same after r55203.
- fast/dom/script-tests/prototype-inheritance-2.js: Explicitly set the inner document’s body
display property to “none”. Before r55203, this happened as a side effect of parsing the
<frameset> tag.
- 5:09 PM Changeset in webkit [55211] by
-
- 4 edits in trunk
Versioning.
- 5:07 PM Changeset in webkit [55210] by
-
- 5 edits1 copy in trunk/WebKitTools
2010-02-23 Dirk Pranke <dpranke@chromium.org>
Reviewed by David Levin.
When the run-chromium-webkit-tests code was landed and the code was
refactored into the 'port' package, I accidentally broke using
http_server.py or websocket_server.py as command-line scripts
(the constructors needed a port object they weren't getting). This
change fixes them so that --server start|stop actually works.
As a part of this, the two files need to be able to call port.get(),
but doing that is awkward from a file inside the package, so I moved
get() into factory.py and imported that into init.py so that
http_server.py and websocket_server.py can just import factory.
- Scripts/webkitpy/layout_tests/port/init.py:
- Scripts/webkitpy/layout_tests/port/factory.py:
- Scripts/webkitpy/layout_tests/port/http_server.py:
- Scripts/webkitpy/layout_tests/port/websocket_server.py:
- 5:06 PM Changeset in webkit [55209] by
-
- 1 copy in tags/Safari-533.1
New tag.
- 4:58 PM Changeset in webkit [55208] by
-
- 4 edits in trunk/WebKitTools
2010-02-24 Dirk Pranke <dpranke@chromium.org>
Reviewed by David Levin.
Fix the function signature for check_sys_deps on the mac port, and
fix the ordering of port_obj.check_sys_deps() and
port_obj.start_helper() (helper needs to be started before we check
the system configuration).
- Scripts/webkitpy/layout_tests/port/mac.py:
- Scripts/webkitpy/layout_tests/port/test.py:
- Scripts/webkitpy/layout_tests/run_chromium_webkit_tests.py:
- 4:24 PM Changeset in webkit [55207] by
-
- 31 edits in trunk
[Chromium API] Disambiguate allowJavaScript from didNotAllowScript
https://bugs.webkit.org/show_bug.cgi?id=35205
Patch by Adam Barth <abarth@webkit.org> on 2010-02-24
Reviewed by Darin Fisher.
WebCore:
For clients that want to show a user interface element when JavaScript
was blocked on a page, we need to disambiguate between querying the
client for whether JavaScript is enabled from actually failing to
execute some script.
This patch adds a new FrameLoaderClient callback for when WebCore would
like to execute JavaScript but fails to because JavaScript is disabled.
This patch also touches every client of canExecuteScripts so they can
indicate whether we should make this callback. I was hoping there was
a better choke point, but my first two attempts were wrong in subtle
ways. pkasting points out that this will be easy to screw up in the
future, so it's better to make all the clients be explicit.
- WebCore.PluginHostProcess.exp:
- bindings/ScriptControllerBase.cpp:
(WebCore::ScriptController::canExecuteScripts):
(WebCore::ScriptController::executeScript):
- bindings/js/JSEventListener.cpp:
(WebCore::JSEventListener::handleEvent):
- bindings/js/JSLazyEventListener.cpp:
(WebCore::JSLazyEventListener::initializeJSFunction):
- bindings/js/ScheduledAction.cpp:
(WebCore::ScheduledAction::execute):
- bindings/js/ScriptController.cpp:
(WebCore::ScriptController::bindingRootObject):
(WebCore::ScriptController::windowScriptNPObject):
(WebCore::ScriptController::jsObjectForPluginElement):
(WebCore::ScriptController::executeScriptInWorld):
- bindings/js/ScriptController.h:
(WebCore::):
- bindings/js/ScriptControllerMac.mm:
(WebCore::ScriptController::windowScriptObject):
- bindings/js/ScriptDebugServer.cpp:
(WebCore::ScriptDebugServer::setJavaScriptPaused):
- bindings/js/ScriptEventListener.cpp:
(WebCore::createAttributeEventListener):
- bindings/js/ScriptState.cpp:
(WebCore::scriptStateFromNode):
- bindings/v8/ScriptController.cpp:
(WebCore::ScriptController::windowScriptNPObject):
(WebCore::ScriptController::createScriptObjectForPluginElement):
- bindings/v8/ScriptController.h:
(WebCore::):
- bindings/v8/ScriptEventListener.cpp:
(WebCore::createAttributeEventListener):
- bindings/v8/V8Proxy.cpp:
(WebCore::V8Proxy::retrieve):
- dom/ScriptElement.cpp:
(WebCore::ScriptElementData::evaluateScript):
- dom/XMLTokenizerLibxml2.cpp:
(WebCore::XMLTokenizer::startElementNs):
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::controls):
- html/HTMLTokenizer.cpp:
(WebCore::HTMLTokenizer::parseTag):
(WebCore::HTMLTokenizer::processToken):
- inspector/InspectorController.cpp:
(WebCore::canPassNodeToJavaScript):
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::isProcessingUserGesture):
(WebCore::FrameLoader::open):
(WebCore::FrameLoader::dispatchDidClearWindowObjectsInAllWorlds):
(WebCore::FrameLoader::dispatchDidClearWindowObjectInWorld):
- loader/FrameLoaderClient.h:
(WebCore::FrameLoaderClient::didNotAllowScript):
WebKit/chromium:
Plumb didNotAllowScript through Chromium's WebKit API.
- public/WebFrameClient.h:
(WebKit::WebFrameClient::didNotAllowScript):
- src/DebuggerAgentImpl.cpp:
(WebKit::DebuggerAgentImpl::createUtilityContext):
- src/FrameLoaderClientImpl.cpp:
(WebKit::FrameLoaderClientImpl::didNotAllowScript):
- src/FrameLoaderClientImpl.h:
- src/WebFrameImpl.cpp:
(WebKit::WebFrameImpl::bindToWindowObject):
WebKit/mac:
Make these two callsites explicit about not running script immediately.
- Plugins/Hosted/NetscapePluginInstanceProxy.mm:
(WebKit::NetscapePluginInstanceProxy::getWindowNPObject):
(WebKit::NetscapePluginInstanceProxy::demarshalValueFromArray):
- 4:17 PM Changeset in webkit [55206] by
-
- 6 edits in trunk/WebCore
Add call to FrameLoaderClient::allowPlugins everywhere arePluginsEnabled is called
https://bugs.webkit.org/show_bug.cgi?id=34997
Patch by Adam Barth <abarth@webkit.org> on 2010-02-24
Reviewed by Darin Fisher.
If we want to let the FrameLoaderClient override arePluginsEnabled,
then we need to call out to the FrameLoaderClient every time we read
the setting.
We don't have testing infrustructure for these changes, which is lame.
I'm supposed to fix that in Bug 33991.
- dom/DOMImplementation.cpp:
(WebCore::DOMImplementation::createDocument):
- loader/MainResourceLoader.cpp:
(WebCore::MainResourceLoader::substituteMIMETypeFromPluginDatabase):
- loader/PluginDocument.cpp:
(WebCore::PluginTokenizer::writeRawData):
- page/Page.cpp:
(WebCore::Page::pluginData):
- plugins/MimeType.cpp:
(WebCore::MimeType::enabledPlugin):
- 3:19 PM CommitQueue edited by
- commiters.py is now in webkitpy (diff)
- 3:17 PM Changeset in webkit [55205] by
-
- 2 edits2 adds in trunk/WebCore
2010-02-24 James Robinson <jamesr@chromium.org>
Reviewed by Dmitry Titov.
Do not fire focus events while a modal dialog is up.
https://bugs.webkit.org/show_bug.cgi?id=33962
Modifies the FocusController to check the frame's page's defersLoading() flag before firing blur/focus events.
This flag is set while a modal dialog (like a window.alert or window.confirm) is up. Firing the events causes
assertion failures, since when the dialog is dismissed the PageGroupLoadDeferrer assumes that no script has run.
Manual tests only as DumpRenderTree does not support modal dialogs
- manual-tests/modal-dialog-blur-selfclose.html: Added.
- manual-tests/modal-dialog-blur.html: Added.
- page/FocusController.cpp: (WebCore::dispatchEventsOnWindowAndFocusedNode):
- 2:58 PM Changeset in webkit [55204] by
-
- 2 edits in trunk/WebKitTools
2010-02-24 James Robinson <jamesr@chromium.org>
Reviewed by Eric Seidel.
Provide default username parameter to SVN.commit_with_message().
- Scripts/webkitpy/scm.py:
- 2:48 PM Changeset in webkit [55203] by
-
- 3 edits3 adds in trunk
<rdar://problem/7018611> innerHTML applies meta/link/title tags from a detached html element
Reviewed by Anders Carlsson.
WebCore:
Test: fast/parser/fragment-parser.html
Ensure that fragment parsing has no side effects on the fragment’s owner
document.
- html/HTMLParser.cpp:
(WebCore::HTMLParser::insertNode): Don’t call
dispatchDocumentElementAvailable() for fragments.
(WebCore::HTMLParser::handleError): Don’t copy attributes to the owner
document’s <html> and <body> elements when a redundant <html> or <body>
is encountered while parsing a fragment.
(WebCore::HTMLParser::framesetCreateErrorCheck): Don’t change the owner
document’s <body> element’s style when parsing a fragment.
(WebCore::HTMLParser::createHead): Don’t attach the new <head> to the
ownder document of a fragment.
LayoutTests:
- fast/parser/fragment-parser-expected.txt: Added.
- fast/parser/fragment-parser.html: Added.
- fast/parser/script-tests/fragment-parser.js: Added.
- 2:31 PM Changeset in webkit [55202] by
-
- 2 edits in trunk/WebKitTools
squash for checkin
- 2:09 PM Changeset in webkit [55201] by
-
- 7 edits2 adds in trunk/WebCore
Need to create a CanvasSurface base class for HTMLCanvasElement.
https://bugs.webkit.org/show_bug.cgi?id=35322
Reviewed by Darin Adler.
This is an initial step in making the OffscreenCanvas object.
No new functionality so no new tests.
- GNUmakefile.am: Added CanvasSurface to the build.
- WebCore.gypi: ditto
- WebCore.pro: ditto
- WebCore.vcproj/WebCore.vcproj: ditto
- WebCore.xcodeproj/project.pbxproj: ditto
- dom/CanvasSurface.cpp: Added.
- dom/CanvasSurface.h: Added.
- html/HTMLCanvasElement.h: Made HTMLCanvasElement inherit from CanvasSurface.
- 1:58 PM Changeset in webkit [55200] by
-
- 2 edits in trunk/WebKitTools
Reviewed by Dan Bernstein.
https://bugs.webkit.org/show_bug.cgi?id=35357
Two editing tests fail after DumpRenderTree run loop changes
AppKit decided that it wanted to group all editing commands for some reason (and thus undo
reverted them all at once).
- DumpRenderTree/mac/DumpRenderTree.mm: (dump): Reverted the change that made DumpRenderTree use -[NSApplication run]. (runTest): Ditto. (-[DumpRenderTreeApplication isRunning]): Override isRunning with a function that always returns YES. This is another way to make the Java plug-in work.
- 1:52 PM Changeset in webkit [55199] by
-
- 2 edits in trunk/WebCore
Fix regression in calculating an animated image's start time.
https://bugs.webkit.org/show_bug.cgi?id=35115
Reviewed by Adam Barth.
- platform/graphics/BitmapImage.cpp:
(WebCore::BitmapImage::startAnimation):
- 1:20 PM Changeset in webkit [55198] by
-
- 6 edits in trunk
2010-02-24 Oliver Hunt <oliver@apple.com>
Reviewed by Geoffrey Garen.
[REGRESSION in r55185] EXC_BAD_ACCESS on opening inspector.
https://bugs.webkit.org/show_bug.cgi?id=35335
compileGetDirectOffset modifies the contents of the object register
when the object is not using the inline storage array. As the object
register contains our 'this' pointer we can't allow it to be clobbered.
The fix is simply to copy the register into a separate scratch register
when we're loading off an object that doesn't use inline storage.
- jit/JITPropertyAccess.cpp: (JSC::JIT::privateCompileGetByIdSelfList):
- jit/JITPropertyAccess32_64.cpp: (JSC::JIT::privateCompileGetByIdSelfList):
2010-02-24 Oliver Hunt <oliver@apple.com>
Reviewed by Geoffrey Garen.
[REGRESSION in r55185] EXC_BAD_ACCESS on opening inspector.
https://bugs.webkit.org/show_bug.cgi?id=35335
Add tests for caching getter lookup on large objects (eg. those not
using the inline storage array).
- fast/js/pic/cached-getter-setter-expected.txt:
- fast/js/pic/cached-getter-setter.html:
- 1:15 PM Changeset in webkit [55197] by
-
- 2 edits in trunk/LayoutTests
2010-02-24 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
Unskip 3 passing cookies tests.
- platform/gtk/Skipped:
- 12:51 PM Changeset in webkit [55196] by
-
- 3 edits4 adds in trunk
<rdar://problem/7682827> Text with :first-letter lingers after being removed
Reviewed by Simon Fraser.
WebCore:
Test: fast/css/first-letter-set-text.html
- rendering/RenderTextFragment.cpp:
(WebCore::RenderTextFragment::setTextInternal): Set this back as the
text node’s renderer, as removing the first letter has resets the node’s
renderer.
LayoutTests:
- fast/css/first-letter-set-text-expected.checksum: Added.
- fast/css/first-letter-set-text-expected.png: Added.
- fast/css/first-letter-set-text-expected.txt: Added.
- fast/css/first-letter-set-text.html: Added.
- 11:31 AM Changeset in webkit [55195] by
-
- 2 edits in trunk/LayoutTests
2010-02-24 Philippe Normand <pnormand@igalia.com>
Rubber-stamped by Xan Lopez.
[GTK] DRT implement execCommand()
https://bugs.webkit.org/show_bug.cgi?id=35351
Skip test that fails in GTK+.
- platform/gtk/Skipped:
- 10:15 AM Changeset in webkit [55194] by
-
- 1 edit1 add in trunk/LayoutTests
2010-02-24 Philippe Normand <pnormand@igalia.com>
Rubber-stamped by Xan Lopez.
Adding a GTK layout test result for a new test
added in r55159.
- platform/gtk/fast/repaint/repaint-during-scroll-expected.txt: Added.
- 8:20 AM Changeset in webkit [55193] by
-
- 2 edits in trunk/WebCore
2010-02-24 Ariya Hidayat <ariya.hidayat@gmail.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Faster cut-off for rectangle fill without shadow.
https://bugs.webkit.org/show_bug.cgi?id=35337
- platform/graphics/qt/GraphicsContextQt.cpp:
- 7:39 AM QtWebKitTableOfFeatures46 edited by
- (diff)
- 7:05 AM Changeset in webkit [55192] by
-
- 3 edits1 delete in trunk
[Qt] Remove QGVLauncher
Patch by Jesus Sanchez-Palencia <jesus.palencia@openbossa.org> on 2010-02-19
Reviewed by Kenneth Rohde Christiansen.
- 6:04 AM Changeset in webkit [55191] by
-
- 2 edits in trunk
2010-02-24 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
Enable SharedWorkers by default, since that's been the default for
a long time in our build-webkit configuration.
- configure.ac:
- 6:01 AM Changeset in webkit [55190] by
-
- 2 edits in trunk/WebCore
[Qt] Corrects build break of QtLauncher on Windows.
The VERSION variable was not set anymore while building in trunk.
Reviewed by nobody, build fix.
- WebCore.pro:
- 5:46 AM Changeset in webkit [55189] by
-
- 2 edits in trunk/WebCore
2010-02-24 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
Get rid of an extra call to
setNPWindowIfNeeded. updatePluginWidget already calls this for us
if needed.
- plugins/gtk/PluginViewGtk.cpp: (WebCore::PluginView::platformStart):
- 5:43 AM Changeset in webkit [55188] by
-
- 2 edits in trunk/WebKitTools
2010-02-23 Adam Roben <Adam Roben>
Make commit-log-editor find just-added ChangeLog files
Fixes <http://webkit.org/b/35294> commit-log-editor doesn't find
just-added ChangeLog files
Reviewed by Dave Levin.
- Scripts/commit-log-editor: (top level): Modified the regular expression that's used to find modified ChangeLog files to also look for just-added ChangeLog files.
- 5:21 AM Changeset in webkit [55187] by
-
- 6 edits in trunk/WebCore
2010-02-24 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: Activate/Deactivate breaks does not look consistent with rest of the toolbar.
Fix style and add the new images to the related file sets.
https://bugs.webkit.org/show_bug.cgi?id=35307
- WebCore.gypi:
- inspector/front-end/Images/deactivateBreakpointsButtonGlyph.png:
- inspector/front-end/Images/deactivateBreakpointsDisabledButtonGlyph.png:
- inspector/front-end/WebKit.qrc:
- inspector/front-end/inspector.css:
- 4:44 AM Changeset in webkit [55186] by
-
- 2 edits in trunk/WebCore
2010-02-24 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
Try to sanitize a bit the geometry management of plugins.
Stop doing contradictory things in updatePluginWidget (we were at
the same time pretending the geometry setting was delayed until
::paint and setting the geometry not once but twice) and just set
it any time the windowRect or clipRect for the plugin has changed.
This is closer to what the Mac port does, and fixes instances of
the plugins not being drawn until the window is resized or
scrolled. Other than that all manual and layout tests seems to
still work.
- plugins/gtk/PluginViewGtk.cpp: (WebCore::PluginView::updatePluginWidget): (WebCore::PluginView::setNPWindowIfNeeded):
- 4:20 AM BuildingQtOnWindows edited by
- (diff)
- 4:17 AM BuildingQtOnWindows edited by
- (diff)
- 1:02 AM Changeset in webkit [55185] by
-
- 7 edits in trunk/JavaScriptCore
2010-02-24 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
Speed up getter performance in the jit
https://bugs.webkit.org/show_bug.cgi?id=35332
Implement getter lookup caching in the interpreter.
The getter stubs are generated through basically the
same code paths as the normal get_by_id caching.
Instead of simply loading a property and returning,
we load the getter slot, and pass the getter, base value
and return address to a shared stub used for getter
dispatch.
- jit/JIT.h: (JSC::JIT::compileGetByIdProto): (JSC::JIT::compileGetByIdSelfList): (JSC::JIT::compileGetByIdProtoList): (JSC::JIT::compileGetByIdChainList): (JSC::JIT::compileGetByIdChain):
- jit/JITPropertyAccess.cpp: (JSC::JIT::privateCompileGetByIdProto): (JSC::JIT::privateCompileGetByIdSelfList): (JSC::JIT::privateCompileGetByIdProtoList): (JSC::JIT::privateCompileGetByIdChainList): (JSC::JIT::privateCompileGetByIdChain):
- jit/JITPropertyAccess32_64.cpp: (JSC::JIT::privateCompileGetByIdProto): (JSC::JIT::privateCompileGetByIdSelfList): (JSC::JIT::privateCompileGetByIdProtoList): (JSC::JIT::privateCompileGetByIdChainList): (JSC::JIT::privateCompileGetByIdChain):
- jit/JITStubs.cpp: (JSC::JITThunks::tryCacheGetByID): (JSC::DEFINE_STUB_FUNCTION):
- jit/JITStubs.h: (JSC::):
- runtime/GetterSetter.h:
- 12:51 AM Changeset in webkit [55184] by
-
- 3 edits in trunk/WebKitTools
2010-02-24 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Darin Adler.
check-webkit-style false positive for WebCore forwarding header
https://bugs.webkit.org/show_bug.cgi?id=34604
- Scripts/webkitpy/style/checker.py:
- Scripts/webkitpy/style/checker_unittest.py:
Feb 23, 2010:
- 11:40 PM Changeset in webkit [55183] by
-
- 2 edits1 add in trunk/LayoutTests
Rubber-stamped by Simon Hausmann.
[Qt] editing/execCommand/delete-image-in-anchor.html skipped
because of missing layoutTestController.execCommand()
Qt specific expected file added for editing/execCommand/insert-list-xml.xhtml
introduced in r55167, because of different font types.
- platform/qt/Skipped: editing/execCommand/delete-image-in-anchor.html skipped.
- platform/qt/editing/execCommand/insert-list-xml-expected.txt: Added.
- 11:14 PM Changeset in webkit [55182] by
-
- 3 edits in trunk/WebCore
2010-02-23 Geoff Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Simplify animation lifetime handling. Previously we manually
determined whether our base element was safe when we unregistered
our listener, now we simply ensure that the base element itself
registers and unregisters the animation listener.
- svg/animation/SVGSMILElement.cpp: (WebCore::ConditionEventListener::create): (WebCore::ConditionEventListener::disconnectAnimation): (WebCore::ConditionEventListener::ConditionEventListener): (WebCore::ConditionEventListener::operator==): (WebCore::ConditionEventListener::handleEvent): (WebCore::SVGSMILElement::eventBaseFor): (WebCore::SVGSMILElement::connectConditions): (WebCore::SVGSMILElement::disconnectConditions):
- svg/animation/SVGSMILElement.h:
- 8:27 PM Changeset in webkit [55181] by
-
- 5 edits in trunk
2010-02-23 Oliver Hunt <oliver@apple.com>
Reviewed by Maciej Stachowiak.
Web Inspector: Regression: r55027+: Inspector broken
https://bugs.webkit.org/show_bug.cgi?id=35253
op_get_by_id_getter_chain was not passing the correct this parameter.
The bug was caused by incorrect use of baseCell instead of baseValue,
baseValue contains the original object for the lookup (and hence the
correct this object), baseCell is clobbered as part of walking the
prototype chain.
- interpreter/Interpreter.cpp: (JSC::Interpreter::privateExecute):
2010-02-23 Oliver Hunt <oliver@apple.com>
Reviewed by Maciej Stachowiak.
Web Inspector: Regression: r55027+: Inspector broken
https://bugs.webkit.org/show_bug.cgi?id=35253
Add thorough testing of getter access to hit the various
possible caching scenarios.
- fast/js/pic/cached-getter-setter-expected.txt:
- fast/js/pic/cached-getter-setter.html:
- 7:43 PM Google Summer of Code 2010 edited by
- (diff)
- 6:05 PM Changeset in webkit [55180] by
-
- 3 edits in trunk/WebCore
Chromium: Use V8::TerminateExecution to actually terminate workers.
https://bugs.webkit.org/show_bug.cgi?id=35137
Reviewed by David Levin.
Test: existing fast/workers/stress-js-execution.html which is currently failing
on Mac and Linux bots for Chromium.
- bindings/v8/WorkerContextExecutionProxy.cpp:
(WebCore::WorkerContextExecutionProxy::evaluate):
- bindings/v8/WorkerScriptController.cpp:
(WebCore::WorkerScriptController::forbidExecution):
- 5:53 PM Changeset in webkit [55179] by
-
- 3 edits2 adds in trunk
REGRESSION: WebKit crashes when deleting images on blogger.com (34957)
<rdar://problem/7651935>
https://bugs.webkit.org/show_bug.cgi?id=34957
Reviewed by Simon Fraser.
WebCore:
Fixing a regression introduced with revision 53085. Anchor elements should not be considered
in editable content when calculating the position in the parent before the node.
Test: editing/execCommand/delete-image-in-anchor.html
- dom/Position.cpp:
(WebCore::Position::getInlineBoxAndOffset):
LayoutTests:
- editing/execCommand/delete-image-in-anchor-expected.txt: Added.
- editing/execCommand/delete-image-in-anchor.html: Added.
- 5:46 PM Changeset in webkit [55178] by
-
- 3 edits2 adds in trunk
2010-02-23 Tony Chang <tony@chromium.org>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=34634
Pasting a list into the middle of another list item should split the target
list item into two separate list items. This matches the behavior in other
browsers.
- editing/pasteboard/paste-list-004-expected.txt: Added.
- editing/pasteboard/paste-list-004.html: Added.
2010-02-23 Tony Chang <tony@chromium.org>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=34634
Pasting a list into the middle of another list item should split the target
list item into two separate list items. This matches the behavior in other
browsers.
Test: editing/pasteboard/paste-list-004.html
- editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::insertAsListItems):
- 5:22 PM Changeset in webkit [55177] by
-
- 7 edits7 adds4 deletes in trunk
Reviewed by Mark Rowe.
https://bugs.webkit.org/show_bug.cgi?id=22602
Enable Java in DumpRenderTree (on Mac)
LayoutTests:
- fast/dom/java-applet-calls-expected.txt: Removed.
- fast/dom/java-applet-calls.html: Removed.
- fast/dom/resources/TestApplet.class: Removed.
- fast/dom/resources/TestApplet.java: Removed. This test was added in a failing form, even though it never worked. The new tests cover everything it was meant to cover.
- java/SharedApplet.java: Added. This class will have methods for simple tests, but it's also possible to just add new source files.
- java/Makefile: Added. Compile all .java files in the directory.
- java: Added.
- java/argument-to-object-type-expected.txt: Added.
- java/argument-to-object-type.html: Added.
- java/array-return-expected.txt: Added.
- java/array-return.html: Added. Added tests for recently fixed bugs.
- platform/gtk/Skipped:
- platform/qt/Skipped:
- platform/win/Skipped: Java tests only work on Mac currently.
WebKitTools:
- DumpRenderTree/mac/DumpRenderTree.mm: (exitApplicationRunLoop): (dump): (runTest): DumpRenderTree now runs an NSApplication, not just an event loop. This way, the Java plug-in can start without freezing.
- Scripts/run-webkit-tests: Compile java sources in LayputTests/java.
- 4:56 PM Changeset in webkit [55176] by
-
- 1 edit1 add in trunk/LayoutTests
2010-02-23 Oliver Hunt <oliver@apple.com>
Add expected result
- svg/custom/animate-use-crash-expected.txt: Added.
- 4:49 PM Changeset in webkit [55175] by
-
- 1 edit1 add in trunk/LayoutTests
2010-02-23 Oliver Hunt <oliver@apple.com>
Reviewed by Maciej Stachowiak.
Add a testcase for an old bug to ensure it doesn't return.
- svg/custom/animate-use-crash.xhtml: Added.
- 3:34 PM Google Summer of Code 2010 edited by
- (diff)
- 3:01 PM Google Summer of Code 2010 created by
- GSoC 2010 page - in case we want to participate
- 2:59 PM Changeset in webkit [55174] by
-
- 3 edits in trunk
2010-02-23 James Choi <jchoi42@pha.jhu.edu>
Add Solaris definitions
https://bugs.webkit.org/show_bug.cgi?id=35214
- WebKit/chromium/src/WebViewImpl.cpp
- WebKit/chromium/src/WebFrameImpl.cpp
- 2:43 PM Changeset in webkit [55173] by
-
- 4 edits2 adds in trunk
2010-02-23 Arno Renevier <arno@renevier.net>
Reviewed by Gustavo Noronha Silva.
[Gtk]: testwebview does not work when called with absolute path
https://bugs.webkit.org/show_bug.cgi?id=34940
When testwebview is called as absolute path, chdir to executable
directory before searching resource files.
- GNUmakefile.am:
- 2:39 PM Changeset in webkit [55172] by
-
- 12 edits in trunk
Regression (r55107) - WebInspector docking is busted.
https://bugs.webkit.org/show_bug.cgi?id=35274
Reviewed by Tim Hatcher and Pavel Feldman.
WebCore:
- inspector/InspectorController.cpp:
(WebCore::InspectorController::canAttachWindow): Use the minimum height for this calculation,
not the preferred height.
(WebCore::InspectorController::attachWindow): attachWindow() shouldn't decide the policy, as it is
often called partway through the show or dock procedure after some of the initial conditions have
changed. Let the front-end itself and the InspectorClient's make the policy decision at the start
of the show/dock operation.
- inspector/InspectorFrontendHost.cpp:
(WebCore::InspectorFrontendHost::canAttachWindow):
- inspector/InspectorFrontendHost.h:
- inspector/InspectorFrontendHost.idl:
- inspector/front-end/inspector.js:
(WebInspector.toggleAttach): Before attaching, ask the front-end-host if attaching is allowed.
WebKit/mac:
- WebCoreSupport/WebInspectorClient.mm:
(-[WebInspectorWindowController showWindow:]): Swap the order of the "should attach?" check
to get the expected behavior.
WebKit/win:
- WebCoreSupport/WebInspectorClient.cpp:
(WebInspectorClient::showWindowWithoutNotifications): Swap the order of the "should attach?" check
to get the expected behavior.
LayoutTests:
- inspector/timeline-event-dispatch.html: Actually click in the right place now that the inspector isn't docked anymore.
- 2:17 PM Changeset in webkit [55171] by
-
- 3 edits in trunk/WebKit/chromium
2010-02-23 James Hawkins <jhawkins@chromium.org>
Reviewed by Darin Fisher.
[Chromium] Implement WebDocument::getElementsByTagName.
- public/WebDocument.h:
- src/WebDocument.cpp: (WebKit::WebDocument::getElementsByTagName):
- 2:03 PM Changeset in webkit [55170] by
-
- 2 edits in trunk/WebKitSite
2010-02-23 Jessie Berlin <jberlin@webkit.org>
Reviewed by Eric Seidel and Adam Roben.
Debugging WebKit on Windows should mention WebKit.sln as an alternative to running debug-safari.
https://bugs.webkit.org/show_bug.cgi?id=35098
- building/debug.html: Add instructions on how to build and run WebKit from within Visual Studio.
- 2:01 PM Changeset in webkit [55169] by
-
- 2 edits in trunk/WebCore
<http://webkit.org/b/35287> ImageSourceCG::frameIsCompleteAtIndex returns false for all frames until image has completed loading
Reviewed by Geoff Garen.
CGImageSourceGetStatusAtIndex claims that all frames of a multi-frame image are incomplete when we've not yet received the
complete data for an image that is using an incremental data source (<rdar://problem/7679174>). We work around this by
special-casing all frames except the last in an image and treating them as complete if they are present and reported as
being incomplete. We do this on the assumption that loading new data can only modify the existing last frame or append new
frames. The last frame is only treated as being complete if the image source reports it as such. This ensures that it is
truly the last frame of the image rather than just the last that we currently have data for.
- platform/graphics/cg/ImageSourceCG.cpp:
(WebCore::ImageSource::frameIsCompleteAtIndex):
- 1:31 PM Changeset in webkit [55168] by
-
- 2 edits in trunk/WebKit/gtk/po
2010-02-23 Mario Blättermann <mariobl@freenet.de>
Reviewed by Gustavo Noronha.
German translation update.
- de.po:
- 1:31 PM Changeset in webkit [55167] by
-
- 6 edits2 adds in trunk
WebCore: Crash in createContextualFragment when inserting a list in a non HTML document.
<rdar://problem/7666670>
https://bugs.webkit.org/show_bug.cgi?id=35305
Reviewed by Darin Adler.
createFragmentFromMarkup did not handle correctly the case where documentElement is
not an HTMLElement. The static cast to HTMLElement was causing createContextualFragment to
crash.
Test: editing/execCommand/insert-list-xml.xhtml
- dom/Element.cpp:
(WebCore::Element::createContextualFragment): Added.
- dom/Element.h: Added createContextualFragment virtual function.
- editing/markup.cpp:
(WebCore::createFragmentFromMarkup): Removed static cast to HTMLElement.
- html/HTMLElement.cpp:
(WebCore::HTMLElement::createContextualFragment): Modified to perform only checks
that are specific for an HTMLElement object. The rest of the logic has been moved to the
corresponding method in the Element class.
LayoutTests: Crash in createContextualFragment when inserting a list in a non HTML document.
<rdar://problem/7666670>
https://bugs.webkit.org/show_bug.cgi?id=35305
Reviewed by Darin Adler.
- editing/execCommand/insert-list-xml-expected.txt: Added.
- editing/execCommand/insert-list-xml.xhtml: Added.
- 1:25 PM Changeset in webkit [55166] by
-
- 2 edits in trunk/WebKit/gtk/po
2010-02-23 Daniel Nylander <po@danielnylander.se>
Reviewed by Gustavo Noronha.
Swedish translation update.
- sv.po:
- 1:20 PM Changeset in webkit [55165] by
-
- 1 edit1 add in trunk/WebKit/gtk/po
2010-02-23 Ankit Patel <ankit@redhat.com>
Reviewed by Gustavo Noronha.
Gujarati translation.
- gu.po: Added.
- 1:13 PM Changeset in webkit [55164] by
-
- 2 edits in trunk/WebKitTools
2010-02-23 Jesus Sanchez-Palencia <jesus.palencia@openbossa.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Need a final integration between QtLauncher and QGVLauncher
https://bugs.webkit.org/show_bug.cgi?id=35292
WebKit coding style fixes.
- QtLauncher/main.cpp: (LauncherWindow::resetZoom):
- 12:39 PM Changeset in webkit [55163] by
-
- 2 edits in trunk/WebKitTools
2010-02-23 Jesus Sanchez-Palencia <jesus.palencia@openbossa.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Need a final integration between QtLauncher and QGVLauncher
https://bugs.webkit.org/show_bug.cgi?id=35292
Add cloneWindow feature to QtLauncher, when running on QGraphicsView mode.
- QtLauncher/main.cpp: (LauncherWindow::LauncherWindow): (LauncherWindow::~LauncherWindow): (LauncherWindow::init): (LauncherWindow::cloneWindow): (LauncherWindow::setupUI):
- 12:07 PM Changeset in webkit [55162] by
-
- 2 edits in trunk/WebCore
2010-02-23 Steve Falkenburg <sfalken@apple.com>
Reviewed by Adam Roben.
WebCore should stop throwing away the CGImageSourceRef on Windows to improve GIF performance
https://bugs.webkit.org/show_bug.cgi?id=35309
- platform/graphics/cg/ImageSourceCG.cpp: (WebCore::ImageSource::clear):
- 10:15 AM Changeset in webkit [55161] by
-
- 2 edits in trunk/WebKitTools
fix check_wdiff_install
- 10:07 AM Changeset in webkit [55160] by
-
- 2 edits in trunk/JavaScriptCore
2010-02-23 Gustavo Noronha Silva <Gustavo Noronha Silva>
Rubber-stamped by Dimitri Glazkov.
Chromium build fix.
- JavaScriptCore.gyp/JavaScriptCore.gyp:
- 9:54 AM Changeset in webkit [55159] by
-
- 3 edits4 adds in trunk
WebKit/mac: <rdar://problem/7611158> Incomplete repaint of YouTube timeline thumb while scrolling
https://bugs.webkit.org/show_bug.cgi?id=34381
Reviewed by Simon Fraser.
Test: fast/repaint/repaint-during-scroll.html
NSClipView offsets any rects marked as needing display during scrolling
by the scroll offset. Compensate for this when -setNeedsDisplay: is called
during scrolling.
- WebView/WebHTMLView.mm:
(-[WebHTMLView _frameOrBoundsChanged]): Set inScrollPositionChanged to YES
around to call to FrameView::scrollPositionChanged().
(-[WebHTMLView setNeedsDisplayInRect:]): When called beneath
scrollPositionChanged(), adjust the rect by the inverse of the scroll offset.
LayoutTests: Rubber-stamped by Simon Fraser.
<rdar://problem/7611158> Incomplete repaint of YouTube timeline thumb while scrolling
https://bugs.webkit.org/show_bug.cgi?id=34381
- fast/repaint/repaint-during-scroll.html: Added.
- platform/mac/fast/repaint/repaint-during-scroll-expected.checksum: Added.
- platform/mac/fast/repaint/repaint-during-scroll-expected.png: Added.
- platform/mac/fast/repaint/repaint-during-scroll-expected.txt: Added.
- 9:52 AM Changeset in webkit [55158] by
-
- 10 edits in trunk
2010-02-23 Leandro Pereira <leandro@profusion.mobi>
Reviewed by Gustavo Noronha Silva.
Changes references of GOwnPtr to reflect their new place.
http://webkit.org/b/35084
- 9:41 AM Changeset in webkit [55157] by
-
- 9 edits5 adds in trunk
HTTP 307 after a 303 after a POST re-sends POST data from the original request.
<rdar://problem/7390251> and https://bugs.webkit.org/show_bug.cgi?id=31410
Reviewed by Alexey Proskuryakov.
WebCore:
Test: http/tests/loading/307-after-303-after-post.html
Remember the last HTTP method send out during a redirect chain for a resource handle:
- platform/network/ResourceHandle.cpp:
(WebCore::ResourceHandle::lastHTTPMethod):
- platform/network/ResourceHandle.h:
- platform/network/ResourceHandleInternal.h:
(WebCore::ResourceHandleInternal::ResourceHandleInternal):
Refer to the last HTTP method used instead of the original method:
- platform/network/cf/ResourceHandleCFNet.cpp:
(WebCore::willSendRequest):
(WebCore::ResourceHandle::willSendRequest):
- platform/network/mac/ResourceHandleMac.mm:
(WebCore::ResourceHandle::willSendRequest):
(-[WebCoreResourceHandleAsDelegate connection:willSendRequest:redirectResponse:]):
LayoutTests:
- http/tests/loading/307-after-303-after-post.html: Added.
- http/tests/loading/resources/303-to-307-target.php: Added.
- http/tests/loading/resources/307-post-output-target.php: Added.
- http/tests/loading/resources/post-to-303-target.php: Added.
- platform/gtk/Skipped:
- platform/qt/Skipped:
- 9:27 AM Changeset in webkit [55156] by
-
- 2 edits in trunk/WebCore
2010-02-23 Crystal Zhang <haizhang@rim.com>
Unreviewed build fix.
Fix build error when enable plugin proxy: 'toRenderEmbeddedObject' identifier not found.
As RenderEmbeddedObject inherits RenderPartObject and 'toRenderEmbeddedObject' belongs
to former one.
- html/HTMLMediaElement.cpp:
- 8:53 AM Changeset in webkit [55155] by
-
- 3 edits in trunk/WebCore
2010-02-23 Evan Martin <evan@chromium.org>
Reviewed by Jeremy Orlow.
[chromium] fix previous SVG-disabling patch
https://bugs.webkit.org/show_bug.cgi?id=35298
- WebCore.gypi: rename variable
- WebCore.gyp/WebCore.gyp: actually use the variable
- 8:32 AM Changeset in webkit [55154] by
-
- 2 edits in trunk/WebCore
2010-02-23 Michael Lotz <mmlr@mlotz.ch>
Reviewed by David Levin.
[Haiku] Fix conversion from BString to String
https://bugs.webkit.org/show_bug.cgi?id=35082
The previous patch to this file was broken (sorry). First of all,
the conversion from UTF8 was accidentally removed. Second, for
empty strings, we need to point the implementation at StringImpl::empty().
Covered by existing tests.
- platform/text/haiku/StringHaiku.cpp: (WebCore::String::String):
- 8:00 AM Changeset in webkit [55153] by
-
- 2 edits in trunk/WebCore
[Qt] Prevent the media backend from handling non-audio or -video mime types
Reviewed by Eric Carlson.
- platform/graphics/qt/MediaPlayerPrivateQt.cpp:
- 7:46 AM Changeset in webkit [55152] by
-
- 5 edits in trunk/WebCore
2010-02-23 Evan Martin <evan@chromium.org>
Reviewed by Jeremy Orlow.
[chromium] Allow building without SVG
https://bugs.webkit.org/show_bug.cgi?id=31522
- WebCore.gyp/WebCore.gyp, WebCore.gypi: test enable_svg flag.
- bindings/v8/custom/V8SVGDocumentCustom.cpp, bindings/v8/custom/V8SVGPathSegCustom.cpp: test ENABLE(SVG).
- 7:28 AM Changeset in webkit [55151] by
-
- 3 edits in trunk/WebKitTools
2010-02-23 Leandro Pereira <leandro@profusion.mobi>
Reviewed by NOBODY.
Fix false positives for 'delete *pointer' statements.
http://webkit.org/b/35235
- WebKitTools/Scripts/webkitpy/style/processors/cpp.py:
- 7:21 AM Changeset in webkit [55150] by
-
- 7 edits in trunk
2010-02-23 Leandro Pereira <leandro@profusion.mobi>
Reviewed by Gustavo Noronha Silva.
Fixes references to GOwnPtr and GRefPtr so the GTK+ port builds
again.
http://webkit.org/b/35084
- 6:35 AM Companies and Organizations that have contributed to WebKit edited by
- (diff)
- 6:21 AM Changeset in webkit [55149] by
-
- 2 edits4 moves1 add in trunk/JavaScriptCore
2010-02-23 Leandro Pereira <leandro@profusion.mobi>
Reviewed by Kenneth Rohde Christiansen.
Adding the EFL implementation of JavaScriptCore.
See https://bugs.webkit.org/show_bug.cgi?id=35084 for details.
- GNUmakefile.am: Updated to reflect the new location of GOwnPtr and
GRefPtr.
- wtf/efl/MainThreadEfl.cpp: Added.
- wtf/gobject/GOwnPtr.cpp: Moved from wtf/gtk.
- wtf/gobject/GOwnPtr.h: Moved from wtf/gtk.
- wtf/gobject/GRefPtr.cpp: Moved from wtf/gtk.
- wtf/gobject/GRefPtr.h: Moved from wtf/gtk.
- 6:17 AM Changeset in webkit [55148] by
-
- 2 edits in trunk/WebCore
2010-02-23 Ariya Hidayat <ariya.hidayat@gmail.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Faster cut-off for rectangle drawing without shadow.
https://bugs.webkit.org/show_bug.cgi?id=35267
- platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::drawRect):
- 6:05 AM Changeset in webkit [55147] by
-
- 7 edits in trunk
2010-02-23 Steve Block <steveblock@google.com>
Reviewed by Jeremy Orlow.
Removes redundant Settings::setGeolocationEnabled and Settings::geolocationEnabled
https://bugs.webkit.org/show_bug.cgi?id=35242
No new tests, removing dead code only.
- page/Settings.cpp:
- page/Settings.h:
2010-02-23 Steve Block <steveblock@google.com>
Reviewed by Jeremy Orlow.
Removes redundant Settings::setGeolocationEnabled and Settings::geolocationEnabled
https://bugs.webkit.org/show_bug.cgi?id=35242
This removes Chromium's WebSettings::setGeolocationEnabled
- public/WebSettings.h:
- src/WebSettingsImpl.cpp:
- src/WebSettingsImpl.h:
- 5:12 AM Changeset in webkit [55146] by
-
- 8 edits in trunk
2010-02-23 Ben Murdoch <benm@google.com>
Reviewed by Eric Seidel.
pageX/Y co-ordinates of TouchEvent should be 0,0
https://bugs.webkit.org/show_bug.cgi?id=35239
Update layout tests to reflect the WebCore changes in this bug.
- fast/events/touch/basic-multi-touch-events-expected.txt: Updated.
- fast/events/touch/basic-single-touch-events-expected.txt: Updated.
- fast/events/touch/script-tests/basic-multi-touch-events.js: (verifyTouchEvent): Add checking of TouchEvent.pageX/Y
- fast/events/touch/script-tests/basic-single-touch-events.js: (verifyTouchEvent): ditto.
2010-02-23 Ben Murdoch <benm@google.com>
Reviewed by Eric Seidel.
pageX/Y co-ordinates of TouchEvent should be 0,0
https://bugs.webkit.org/show_bug.cgi?id=35239
The co-ordinates attached to a touch event are not used for tracking touch motion, rather the co-ordinates attached to Touches within the touch event should be used. Set the co-ordinates on the event itself to 0 to avoid confusion and match observed iPhone behavior.
- page/EventHandler.cpp: (WebCore::EventHandler::handleTouchEvent): Set the pageX/Y and screenX/Y co-ordinates attached to the touch event to 0,0 to match observed behavior on the iPhone.
- page/EventHandler.h: Remove now unused members m_firstTouchScreenPos and m_firstTouchPagePos.
- 4:53 AM Changeset in webkit [55145] by
-
- 2 edits in trunk/WebCore
2010-02-23 Stephan Aßmus <superstippi@gmx.de>
Reviewed by Eric Seidel.
[Haiku] Various improvements to EventHandlerHaiku.
https://bugs.webkit.org/show_bug.cgi?id=34685
Covered by existing tests.
Fix the build by not including PlatformScrollBar.h.
- page/haiku/EventHandlerHaiku.cpp: (WebCore::isKeyboardOptionTab):
Use the correct keycode for tab keys.
(WebCore::EventHandler::focusDocumentView):
Use proper locking. In any case, Haiku doesn't append platform
widgets to WebCore widgets. But if it did, this implementation
would be correct.
(WebCore::EventHandler::passWidgetMouseDownEventToWidget):
Implemented.
(WebCore::EventHandler::eventActivatedView):
Removed notImplemented() and added note.
(WebCore::EventHandler::passMousePressEventToSubframe):
Implemented.
(WebCore::EventHandler::passMouseMoveEventToSubframe):
Implemented.
(WebCore::EventHandler::passMouseReleaseEventToSubframe):
Implemented.
(WebCore::EventHandler::accessKeyModifiers):
Added note.
- 4:43 AM Changeset in webkit [55144] by
-
- 7 edits in trunk
2010-02-23 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Eric Seidel.
[Gtk] Implement layoutTestController.numberOfPages
https://bugs.webkit.org/show_bug.cgi?id=35228
- platform/gtk/Skipped:
2010-02-23 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Eric Seidel.
[Gtk] Implement layoutTestController.numberOfPages
https://bugs.webkit.org/show_bug.cgi?id=35228
- webkit/webkitprivate.h:
- webkit/webkitwebframe.cpp: (webkit_web_frame_number_of_pages):
2010-02-23 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Eric Seidel.
[Gtk] Implement layoutTestController.numberOfPages
https://bugs.webkit.org/show_bug.cgi?id=35228
- DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::numberOfPages):
- 4:27 AM Changeset in webkit [55143] by
-
- 3 edits2 deletes in trunk
2010-02-23 Tony Chang <tony@chromium.org>
Not reviewed.
Revert r55135 because the layout test is failing on all the bots.
https://bugs.webkit.org/show_bug.cgi?id=34634
- editing/pasteboard/paste-list-004-expected.txt: Removed.
- editing/pasteboard/paste-list-004.html: Removed.
2010-02-23 Tony Chang <tony@chromium.org>
Not reviewed.
Revert r55135 because the layout test is failing on all the bots.
https://bugs.webkit.org/show_bug.cgi?id=34634
- editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::insertAsListItems):
- 4:07 AM Changeset in webkit [55142] by
-
- 7 edits2 adds in trunk/WebCore
Adds cache to store Geolocation positions between browser sessions.
https://bugs.webkit.org/show_bug.cgi?id=34084
Reviewed by Ariya Hidayat.
This is required to fully implement the Geolocation maximumAge property.
See Bug 30676.
No new tests, will add tests for maximumAge once complete.
- Android.mk: Modified. Added GeolocationPositionCache.cpp
- GNUmakefile.am: Modified. Added GeolocationPositionCache.[cpp|h]
- WebCore.gypi: Modified. Added GeolocationPositionCache.[cpp|h]
- WebCore.pro: Modified. Added GeolocationPositionCache.[cpp|h]
- WebCore.vcproj/WebCore.vcproj: Modified. Added GeolocationPositionCache.[cpp|h]
- WebCore.xcodeproj/project.pbxproj: Modified. Added GeolocationPositionCache.[cpp|h]
- page/GeolocationPositionCache.cpp: Added.
(WebCore::GeolocationPositionCache::GeolocationPositionCache):
(WebCore::GeolocationPositionCache::~GeolocationPositionCache):
(WebCore::GeolocationPositionCache::setCachedPosition):
(WebCore::GeolocationPositionCache::cachedPosition):
(WebCore::GeolocationPositionCache::setDatabasePath):
(WebCore::GeolocationPositionCache::readFromDB):
(WebCore::GeolocationPositionCache::writeToDB):
- page/GeolocationPositionCache.h: Added.
- 4:04 AM Changeset in webkit [55141] by
-
- 3 edits2 adds in trunk
2010-02-23 Yuta Kitamura <yutak@chromium.org>
Reviewed by Dan Bernstein.
Fix alignment of vertical-align: text-bottom inside an inline-block.
This patch is based on a fix provided by Takahito Hirano.
display: inline-block + vertical-align: text-bottom causes misalignment.
https://bugs.webkit.org/show_bug.cgi?id=30846
- fast/inline-block/inline-block-vertical-align-2.html: Added.
- fast/inline-block/inline-block-vertical-align-2-expected.txt: Added.
2010-02-23 Yuta Kitamura <yutak@chromium.org>
Reviewed by Dan Bernstein.
Fix alignment of vertical-align: text-bottom inside an inline-block.
This patch is based on a fix provided by Takahito Hirano.
display: inline-block + vertical-align: text-bottom causes misalignment.
https://bugs.webkit.org/show_bug.cgi?id=30846
Test: fast/inline-block/inline-block-vertical-align-2.html
- rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::verticalPosition): Fixed vpos calculation. We cannot cut corners for inline blocks, since they may have their own text metrics.
- 3:43 AM Changeset in webkit [55140] by
-
- 3 edits in trunk/WebCore
Sets default values of V8 runtime enabler flags to match behavior with JSC
https://bugs.webkit.org/show_bug.cgi?id=35095
- 3:25 AM Changeset in webkit [55139] by
-
- 2 edits in trunk/WebKit/gtk
2010-02-23 José Millán Soto <jmillan@igalia.com>
Reviewed by Xan Lopez.
[Gtk] Server message not shown on http authentication
https://bugs.webkit.org/show_bug.cgi?id=34219
- webkit/webkitsoupauthdialog.c: (show_auth_dialog): Server message is displayed, messageLabel and message variables were renamed to avoid confusion.
- 3:09 AM Changeset in webkit [55138] by
-
- 2 edits in trunk/WebCore
2010-02-23 Stephan Aßmus <superstippi@gmx.de>
Reviewed by Eric Seidel.
[Haiku] Fix various issues in keyboard event generation.
https://bugs.webkit.org/show_bug.cgi?id=34685
Covered by existing tests.
Fixed backspace keycode.
Fixed using the appropriate fields from the Haiku event for mapping
to the VK_* codes and added mapping a great deal more codes.
Added extraction of modifier key flags.
Completed implementation of disambiguateKeyDownEvent()
Implemented currentCapsLockState().
- platform/haiku/PlatformKeyboardEventHaiku.cpp: (WebCore::keyIdentifierForHaikuKeyCode): (WebCore::windowsKeyCodeForKeyEvent): (WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent): (WebCore::PlatformKeyboardEvent::disambiguateKeyDownEvent): (WebCore::PlatformKeyboardEvent::currentCapsLockState):
- 2:53 AM Changeset in webkit [55137] by
-
- 4 edits in trunk/WebKit/chromium
2010-02-23 Dmitriy Belenko <dbelenko@google.com>
Reviewed by Darin Fisher.
Chromium: Need to be able to get the bounds of selection
rectangle(s)
https://bugs.webkit.org/show_bug.cgi?id=34915
This change will enable about 30 test cases to pass in Chromium.
All of these test cases are related to selection rect boundaries.
This change will enable the test cases to retrieve the selection
rect boundary rectangle for the current selection.
- public/WebFrame.h:
- src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::selectionBoundsRect):
- src/WebFrameImpl.h:
- 2:35 AM Changeset in webkit [55136] by
-
- 20 edits in trunk
Adds Client::cancelGeolocationPermissionRequestForFrame and ChromeClient::cancelGeolocationPermissionRequestForFrame
https://bugs.webkit.org/show_bug.cgi?id=34962
These methods are required so that a Geolocation object can cancel an
asynchronous permission request. This allows the chrome client to cancel
any UI it is showing for the permission request.
- 2:19 AM Changeset in webkit [55135] by
-
- 3 edits2 adds in trunk
2010-02-23 Tony Chang <tony@chromium.org>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=34634
Pasting a list into the middle of another list item should split the target
list item into two separate list items. This matches the behavior in other
browsers.
- editing/pasteboard/paste-list-004-expected.txt: Added.
- editing/pasteboard/paste-list-004.html: Added.
2010-02-23 Tony Chang <tony@chromium.org>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=34634
Pasting a list into the middle of another list item should split the target
list item into two separate list items. This matches the behavior in other
browsers.
Test: editing/pasteboard/paste-list-004.html
- editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::insertAsListItems):
- 2:03 AM Changeset in webkit [55134] by
-
- 3 edits in trunk/WebKitTools
2010-02-23 Laszlo Gombos <Laszlo Gombos>
Reviewed by Kenneth Rohde Christiansen.
[Qt] QtLauncher should not use internal JavaScriptCore and WebCore interfaces
https://bugs.webkit.org/show_bug.cgi?id=35248
- QtLauncher/QtLauncher.pro:
- QtLauncher/utils.h:
- 1:55 AM Changeset in webkit [55133] by
-
- 2 edits in trunk/WebCore
[Qt] Correct build problems while building QtWebKit inside Qt.
https://bugs.webkit.org/show_bug.cgi?id=34975
Reviewed by Laszlo Gombos.
- WebCore.pro: Change the condition !standalone_package to !QTDIR_build
- 1:47 AM Changeset in webkit [55132] by
-
- 5 edits in trunk/WebCore
2010-02-23 Noam Rosenthal <noam.rosenthal@nokia.com>
Reviewed by Ariya Hidayat.
[Qt] Connect video with accelerated compositing
https://bugs.webkit.org/show_bug.cgi?id=35276
MediaControlPrivate and GraphicsLayer are patched together via
a shared PlatformLayer (QGraphicsItem). This patch makes sure that the
QGraphicsVideoItem from MediaControl becomes part of the scene
associsated with GraphicsLayer
Test: http://double.co.nz/video_test/test1.html with AC turned on
- platform/graphics/qt/GraphicsLayerQt.cpp: (WebCore::GraphicsLayerQtImpl::): mediaLayer member (WebCore::GraphicsLayerQtImpl::opaqueArea): video is opaque (WebCore::GraphicsLayerQtImpl::paint): don't paint video (WebCore::GraphicsLayerQtImpl::flushChanges): flush mediaLayer (WebCore::GraphicsLayerQt::setContentsToMedia): notify
- platform/graphics/qt/GraphicsLayerQt.h: reimp setContentsToMedia
- platform/graphics/qt/MediaPlayerPrivateQt.cpp: (WebCore::MediaPlayerPrivate::MediaPlayerPrivate): m_compositing (WebCore::MediaPlayerPrivate::paint): don't paint if compositing (WebCore::MediaPlayerPrivate::acceleratedRenderingStateChanged): reimp from MediaPlayerPrivateInterface to support AC (WebCore::MediaPlayerPrivate::platformLayer): ditto
- platform/graphics/qt/MediaPlayerPrivateQt.h: (WebCore::MediaPlayerPrivate::supportsAcceleratedRendering): ditto
- 1:31 AM Changeset in webkit [55131] by
-
- 3 edits in trunk/WebKitTools
2010-02-23 Daniel Bates <dbates@rim.com>
Reviewed by Eric Seidel.
Prompts a person for their SVN username if not already cached (by Subversion).
Currently, webkit-patch is unable to commit to the SVN repo. unless the
WebKit SVN username is already cached (from of a prior commit by hand)
because "svn commit" (called by webkit-patch) defaults to using the system
login name unless the username is already cached or specified on the
command line.
- Scripts/webkitpy/scm.py: Added methods SVN.has_authorization_for_realm and modified SVN.commit_with_message to call it. Added optional username parameter to method SVN.commit_with_message.
- Scripts/webkitpy/scm_unittest.py: Added unit test methods: SVNTest.test_commit_with_username, SVNTest.test_has_authorization_for_realm, and SVNTest.test_not_have_authorization_for_realm.
- 1:14 AM Changeset in webkit [55130] by
-
- 2 edits in trunk/WebCore
2010-02-23 Stephan Aßmus <superstippi@gmx.de>
Reviewed by Eric Seidel.
Fix various issues in PlatformWheelEventHaiku.
https://bugs.webkit.org/show_bug.cgi?id=34685
Covered by existing tests.
Fixed coding style violations.
Synced extracting the correct coordinates with Haiku WebKit implementation.
Added extracting modifier key flags.
- platform/haiku/PlatformWheelEventHaiku.cpp: (WebCore::PlatformWheelEvent::PlatformWheelEvent):
- 1:02 AM Changeset in webkit [55129] by
-
- 2 edits in trunk/WebKit/gtk
2010-02-23 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
Do not do unnecessary work during size_allocate.
FrameView::resize will already queue a layout, so there's no need
to force one ourselves. On top of that, the layout function
already adjusts the view size when needed, so there's no need to
do that manually either. No change in the layout tests or unit
tests after this.
- webkit/webkitwebview.cpp: (webkit_web_view_size_allocate):
- 12:58 AM Changeset in webkit [55128] by
-
- 4 edits in trunk/WebCore
2010-02-23 Laszlo Gombos <Laszlo Gombos>
Reviewed by Eric Seidel.
Build fix for PluginView
https://bugs.webkit.org/show_bug.cgi?id=35230
No new tests, build fix only.
- plugins/PluginView.cpp:
- plugins/PluginView.h:
- plugins/PluginViewNone.cpp:
- 12:42 AM Changeset in webkit [55127] by
-
- 2 edits in trunk
2010-02-23 Diego Escalante Urrelo <descalante@igalia.com>
Reviewed by Eric Seidel.
[gtk] missing libsoup-2.4 package in gir generation
https://bugs.webkit.org/show_bug.cgi?id=35199
Include libsoup-2.4 package in gobject introspection .gir generation.
- GNUmakefile.am:
- 12:26 AM Changeset in webkit [55126] by
-
- 1 edit1 add in trunk/WebCore
2010-02-23 Kwang Yul Seo <skyul@company100.net>
Reviewed by Eric Seidel.
[BREWMP] Port ScriptController::createScriptInstanceForWidget
https://bugs.webkit.org/show_bug.cgi?id=34413
- bindings/js/ScriptControllerBrew.cpp: Added. (WebCore::ScriptController::createScriptInstanceForWidget):
- 12:19 AM Changeset in webkit [55125] by
-
- 3 edits in trunk/LayoutTests
2010-02-18 Philippe Normand <pnormand@igalia.com>
Reviewed by Eric Seidel.
media/video-display-aspect-ratio.html fails
https://bugs.webkit.org/show_bug.cgi?id=34933
Original patch by Eric Carlson.
- media/content/test-par-16-9.mp4: Change the width of the video track from 426.666 to 426.
- platform/mac-leopard/Skipped: Unskip the test, it should pass now.
- 12:09 AM Changeset in webkit [55124] by
-
- 2 edits in trunk/WebCore
2010-02-23 José Millán Soto <jmillan@igalia.com>
Reviewed by Eric Seidel.
[Gtk] Webkit crashes when using orca
https://bugs.webkit.org/show_bug.cgi?id=35169
Made webkit_accessible_text_get_caret_offset check if end selection
node is null.
- accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (webkit_accessible_text_get_caret_offset):
Feb 22, 2010:
- 11:53 PM Changeset in webkit [55123] by
-
- 7 edits in trunk/WebKitTools
2010-02-22 Dirk Pranke <dpranke@chromium.org>
Reviewed by Eric Siedel.
Add more checking for missing binaries and packages to check_sys_deps()
- Scripts/webkitpy/layout_tests/port/base.py:
- Scripts/webkitpy/layout_tests/port/chromium.py:
- Scripts/webkitpy/layout_tests/port/chromium_linux.py:
- Scripts/webkitpy/layout_tests/port/chromium_mac.py:
- Scripts/webkitpy/layout_tests/port/chromium_win.py:
- Scripts/webkitpy/layout_tests/run_chromium_webkit_tests.py:
- 11:37 PM Changeset in webkit [55122] by
-
- 3 edits in trunk/WebCore
2010-02-22 Stephan Aßmus <superstippi@gmx.de>
Reviewed by Eric Seidel.
[Haiku] Implemented PopupMenu support.
https://bugs.webkit.org/show_bug.cgi?id=35078
Covered by existing tests.
The implementation is currently very simple: Added a PopupMenuHaiku
class that derives from a native BPopUpMenu. It attaches a BHandler
derivative to the BApplication (WebCore main thread) which receives
the item invokation and menu hidden events and informs the PopupMenuClient
accordingly.
- platform/PopupMenu.h:
Changed type of m_menu for Haiku.
- platform/haiku/PopupMenuHaiku.cpp: (WebCore::PopupMenuHandler::PopupMenuHandler): (WebCore::PopupMenuHandler::MessageReceived): (WebCore::PopupMenuHaiku::PopupMenuHaiku): (WebCore::PopupMenuHaiku::~PopupMenuHaiku): (WebCore::PopupMenuHaiku::show): (WebCore::PopupMenuHaiku::hide): (WebCore::PopupMenuHaiku::Hide): (WebCore::PopupMenu::PopupMenu): (WebCore::PopupMenu::~PopupMenu):
Removed bogus code.
(WebCore::PopupMenu::show):
Implemented using new PopupMenuHaiku class.
(WebCore::PopupMenu::hide):
Implemented using new PopupMenuHaiku class.
(WebCore::PopupMenu::updateFromElement):
Implemented.
(WebCore::PopupMenu::itemWritingDirectionIsNatural):
Implemented according to Gtk port.
- 10:28 PM Changeset in webkit [55121] by
-
- 3 edits in trunk/WebKitTools
2010-02-22 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by David Levin.
[Gtk] check-webkit-style: GTK style should be allowed in WebKitTools/DumpRenderTree/gtk
https://bugs.webkit.org/show_bug.cgi?id=35229
- Scripts/webkitpy/style/checker.py:
- Scripts/webkitpy/style/checker_unittest.py:
- 9:03 PM Changeset in webkit [55120] by
-
- 8 edits in trunk/JavaScriptCore
Remove auto_ptr usage in JavaScriptCore.
https://bugs.webkit.org/show_bug.cgi?id=35221
Reviewed by Darin Adler.
- parser/Nodes.h: Removed now unneeded adopt method.
- parser/Parser.cpp: Removed <memory> include as it is not required anymore.
- wtf/OwnPtr.h: Removed the constructor from auto_ptr.
- wtf/VectorTraits.h: Removed a template specialization for auto_ptr.
- wtf/unicode/Collator.h: Made userDefault return a PassOwnPtr.
- wtf/unicode/CollatorDefault.cpp:
(WTF::Collator::userDefault): Changed the method to match the next signature.
- wtf/unicode/icu/CollatorICU.cpp:
(WTF::Collator::userDefault): Ditto.
- 8:50 PM Changeset in webkit [55119] by
-
- 2 edits in trunk/WebKitTools
2010-02-22 James Robinson <jamesr@chromium.org>
Unreviewed. Adding myself to committers list.
- Scripts/webkitpy/committers.py:
- 8:29 PM Changeset in webkit [55118] by
-
- 2 edits in trunk/WebKitTools
2010-02-22 Simon Fraser <Simon Fraser>
Reviewed by Darin Adler.
Remove DRT hack that turns off hardware acceleration with older QuickTimes
https://bugs.webkit.org/show_bug.cgi?id=35275
Now that WebKit does a version check to avoid a QuickTime-related
crash (r55100), DumpRenderTree does not need to.
- DumpRenderTree/mac/DumpRenderTree.mm: (resetDefaultsToConsistentValues):
- 5:55 PM Changeset in webkit [55117] by
-
- 5 edits in trunk
2010-02-22 Huahui Wu <hwu@google.com>
Reviewed by Eric Seidel.
Add code that enables SquirrelFish Extreme (a.k.a JSCX, JSC JIT)
in Android. It's disabled by default, but is enabled when the
enveronment variable ENABLE_JSC_JIT is set to true.
https://bugs.webkit.org/show_bug.cgi?id=34855
- Android.mk:
2010-02-22 Huahui Wu <hwu@google.com>
Reviewed by Eric Seidel.
Add code that enables SquirrelFish Extreme (a.k.a JSCX, JSC JIT)
in Android. It's disabled by default, but is enabled when the
enveronment variable ENABLE_JSC_JIT is set to true.
https://bugs.webkit.org/show_bug.cgi?id=34855
- Android.mk:
- wtf/Platform.h:
- 5:29 PM Changeset in webkit [55116] by
-
- 2 edits in trunk/WebCore
2010-02-22 Stephan Aßmus <superstippi@gmx.de>
Reviewed by Eric Seidel.
Fix various issues in PlatformMouseEventHaiku.
https://bugs.webkit.org/show_bug.cgi?id=34685
Covered by existing tests.
Mapping Haiku button constants (bit field) to WebCore buttons was broken.
Extracting event time was broken (supposed to be in seconds).
Wrong coordinate was being extracted, needs to be content local.
Added extracting modifier key flags.
- platform/haiku/PlatformMouseEventHaiku.cpp: (WebCore::PlatformMouseEvent::PlatformMouseEvent):
- 5:12 PM Changeset in webkit [55115] by
-
- 3 edits in trunk/WebCore
2010-02-22 Stephan Aßmus <superstippi@gmx.de>
Reviewed by Eric Seidel.
[Haiku] Implement creating and filling platform gradients.
https://bugs.webkit.org/show_bug.cgi?id=34683
Covered by existing tests.
- platform/graphics/Gradient.h:
Typedef PlatformGradient to BGradient
- platform/graphics/haiku/GradientHaiku.cpp: (WebCore::Gradient::platformDestroy):
Delete the cached BGradient object.
(WebCore::Gradient::platformGradient):
Create a BGradient object according to the type of Gradient.
Return the cached object.
(WebCore::Gradient::fill):
use BView API to fill with the platform gradient.
- 5:01 PM Changeset in webkit [55114] by
-
- 1 edit2 adds in trunk/LayoutTests
2010-02-22 Chris Evans <cevans@chromium.org>
Reviewed by Darin Adler.
Add test for https://bugs.webkit.org/show_bug.cgi?id=32842
It has been fixed on trunk for a while, but we want to make sure we
do not regress.
- fast/text/find-layout-crash.html: Added.
- fast/text/find-layout-crash-expected.txt: Added.
- 4:55 PM Changeset in webkit [55113] by
-
- 2 edits in trunk/WebCore
2010-02-22 Stephan Aßmus <superstippi@gmx.de>
Reviewed by Eric Seidel.
Build fix for debug builds of GlyphPageTreeNode.cpp
https://bugs.webkit.org/show_bug.cgi?id=34528
Covered by existing tests.
- platform/graphics/GlyphPageTreeNode.cpp:
include <stdio.h> since printf() is used if NDEBUG is not defined.
- 4:45 PM Changeset in webkit [55112] by
-
- 6 edits in trunk/WebKit/win
WebKit on Windows should pick up system setting changes without requiring explicit API calls
https://bugs.webkit.org/show_bug.cgi?id=35269
Reviewed by Darin Adler.
- WebKit.vcproj/WebKit.def: Removed WebKitSystemParameterChanged.
- WebKit.vcproj/WebKit_debug.def: Removed WebKitSystemParameterChanged.
- WebKitGraphics.cpp: Removed WebKitSystemParameterChanged.
- WebKitGraphics.h: Removed WebKitSystemParameterChanged.
- WebView.cpp:
(systemParameterChanged): Call through to wkSystemFontSmoothingChanged for font changes.
(WebView::windowReceivedMessage): Pick up WM_SETTINGCHANGE from windowReceivedMessage.
- 4:12 PM Changeset in webkit [55111] by
-
- 2 edits in trunk/WebCore
2010-02-22 Nate Chapin <Nate Chapin>
Unreviewed, Chromium build fix.
Add special case in CodeGeneratorV8.pm for named getters for html plugin-related elements.
CodeGeneratorV8.pm was relying on HasOverridingNameGetter to hint
that a custom named getter was needed. That hint was removed in
http://trac.webkit.org/changeset/55104.
- bindings/scripts/CodeGeneratorV8.pm:
- 3:28 PM Changeset in webkit [55110] by
-
- 1 edit1 delete in trunk/LayoutTests
Rubber-stamped by Alexey Proskuryakov.
[Qt] fast/encoding/invalid-UTF-8-2.html fails
https://bugs.webkit.org/show_bug.cgi?id=35263
Qt Linux Release buildbot got the platform independent result for
fast/encoding/invalid-UTF-8-2.html instead of Qt specific one.
Qt specific expected file is removed to make buildbot green,
but it needs more investigation.
- platform/qt/fast/encoding/invalid-UTF-8-2-expected.txt: Removed.
- 3:27 PM Changeset in webkit [55109] by
-
- 21 edits in trunk
Rubber-stamped by Geoff Garen.
Rename RuntimeObjectImp to RuntimeObject.
- 3:23 PM Changeset in webkit [55108] by
-
- 3 edits3 adds in trunk
Avoid recursion when trying to get the size of a PNG; it's unnecessary
and in the worst case can lead to heap corruption.
https://bugs.webkit.org/show_bug.cgi?id=35167
Reviewed by Eric Seidel.
WebCore:
Test: fast/images/bad-png.html
- platform/image-decoders/png/PNGImageDecoder.cpp:
(WebCore::PNGImageReader::decode):
LayoutTests:
- fast/images/bad-png-expected.txt: Added.
- fast/images/bad-png.html: Added.
- fast/images/resources/bad-png.png: Added.
- 3:20 PM BuildingOnWindows edited by
- (diff)
- 3:10 PM Changeset in webkit [55107] by
-
- 8 edits in trunk
Disable WebView docking to views that are too small.
<rdar://problem/7248409> and https://bugs.webkit.org/show_bug.cgi?id=35254
Reviewed by Tim Hatcher.
WebCore:
- WebCore.base.exp:
- inspector/InspectorController.cpp:
(WebCore::InspectorController::canAttachWindow): Provide a utility for WebKits to make a showWindow()
decision based on if attachment would be allowed or not.
(WebCore::InspectorController::attachWindow): Don't attach if the view is too small to attach to.
- inspector/InspectorController.h:
WebKit/mac:
- WebCoreSupport/WebInspectorClient.mm:
(-[WebInspectorWindowController showWindow:]): No matter the preference, don't open the inspector
window attached if WebCore says it shouldn't be attached.
WebKit/win:
- WebCoreSupport/WebInspectorClient.cpp:
(WebInspectorClient::showWindowWithoutNotifications): No matter the preference, don't open the inspector
window attached if WebCore says it shouldn't be attached.
- 2:32 PM Changeset in webkit [55106] by
-
- 2 edits in trunk/WebCore
Build fix.
- WebCore.base.exp: Export Instance::newRuntimeObject, it's virtual!
- 2:25 PM Changeset in webkit [55105] by
-
- 2 edits in trunk/WebCore
Undo a small part of the previous commit.
- bridge/runtime_method.cpp: (JSC::callRuntimeMethod): Let's keep the instance local variable as RefPtr for safety.
- 2:21 PM Changeset in webkit [55104] by
-
- 12 edits in trunk/WebCore
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=35260
Eliminate apple_runtime_object
No change in functionality, so no tests.
- WebCore.base.exp: Don't export Instance::newRuntimeObject, WebKit doesn't need it.
- bindings/js/JSHTMLAppletElementCustom.cpp:
- bindings/js/JSHTMLEmbedElementCustom.cpp:
- bindings/js/JSHTMLObjectElementCustom.cpp:
- html/HTMLAppletElement.idl:
- html/HTMLEmbedElement.idl:
- html/HTMLObjectElement.idl: These objects no longer need overriding name getters, as they no longer intercept the apple_runtime_object property.
- bindings/js/JSPluginElementFunctions.cpp: (WebCore::pluginInstance): This is no longer static. It was used for callPlugin() in this file, and now it's also used elsewhere when calling plug-in methods. (WebCore::runtimeObjectGetter): Removed. This function was only used by the intercepting name getters.
- bindings/js/JSPluginElementFunctions.h: Export pluginInstance().
- bindings/objc/WebScriptObject.mm: (+[WebScriptObject _convertValueToObjcValue:originRootObject:rootObject:]):
- bridge/runtime_method.cpp: (JSC::callRuntimeMethod): Take plug-in element's instance directly, without relying on fake attribute lookup. One change resulting from this is that RuntimeObjectImp may not be created in some cases - this code only needs an instance, but the old code had to pass the instance wrapped into RuntimeObjectImp.
- 2:17 PM Changeset in webkit [55103] by
-
- 5 edits3 adds in trunk/LayoutTests
2010-02-22 Robert Hogan <robert@roberthogan.net>
Reviewed by Alexey Proskuryakov.
https://bugs.webkit.org/show_bug.cgi?id=32937
LayoutTests/fast/encoding/invalid-UTF-8.html fails on Qt.
The test was verifying two things: first, that U+FFFD is rendered by the browser, and second,
that ill-formed UTF-8 sequences are turned into U+FFFD. Some aspects of the latter are not
precisely defined by the Unicode specification, so different platforms may legitimately
have different results.
Split the test into two: one to test the rendering of invalid UTF-8 sequences, and the other
to protect against regressions in each platform's decoding behaviour.
- fast/encoding/invalid-UTF-8-2-expected.txt: Added.
- fast/encoding/invalid-UTF-8-2.html: Added.
- fast/encoding/invalid-UTF-8.html:
- platform/mac/fast/encoding/invalid-UTF-8-expected.checksum:
- platform/mac/fast/encoding/invalid-UTF-8-expected.png:
- platform/mac/fast/encoding/invalid-UTF-8-expected.txt:
- platform/qt/fast/encoding/invalid-UTF-8-2-expected.txt:
- 1:07 PM Changeset in webkit [55102] by
-
- 3 edits in trunk/LayoutTests
Bug 35186 - AX: AXFocused is not writable like it should be on nodes
https://bugs.webkit.org/show_bug.cgi?id=35186
Fixing layout test failure.
- 12:59 PM Changeset in webkit [55101] by
-
- 2 edits in trunk/WebCore
https://bugs.webkit.org/show_bug.cgi?id=35256
HTMLSelectElement::setSelectedIndexByUser() can trigger unnecessary JS when there is no change to the selected index
Reviewed by Tim Hatcher.
No new tests because this code path is not used for JS-initiated changes.
- html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::setSelectedIndexByUser):
Bail out if the to-be-selected index matches the already-selected index.
- 12:51 PM Changeset in webkit [55100] by
-
- 2 edits in trunk/WebKit/mac
2010-02-22 Simon Fraser <Simon Fraser>
Reviewed by John Sullivan.
<rdar://problem/7285392>
On Leopard, we have to disable hardware acceleration if we detect that the
installed Core Video framework has bug <rdar://problem/7228836>.
- WebView/WebView.mm: (coreVideoHas7228836Fix): (-[WebView _preferencesChangedNotification:]):
- 12:18 PM Changeset in webkit [55099] by
-
- 1 copy in releases/WebKitGTK/webkit-1.1.22
Tagging 1.1.22.
- 12:05 PM Changeset in webkit [55098] by
-
- 3 edits2 adds in trunk
Reproducible crash in WebCore::nextLinePosition on Tweeteorites.com
<rdar://problem/7615758>
https://bugs.webkit.org/show_bug.cgi?id=35060
Reviewed by Dan Bernstein.
WebCore:
Test: editing/selection/extend-byline-withfloat.html
- editing/visible_units.cpp:
(WebCore::previousLinePosition): Skip elements with zero height.
(WebCore::nextLinePosition): Skip elements with zero height.
LayoutTests:
- editing/selection/extend-byline-withfloat-expected.txt: Added.
- editing/selection/extend-byline-withfloat.html: Added.
- 12:03 PM Changeset in webkit [55097] by
-
- 2 edits in trunk/WebCore
2010-02-22 Nate Chapin <Nate Chapin>
Unreviewed, Chromium build fix.
- bindings/scripts/CodeGeneratorV8.pm: Compile break due to bad patch merge.
- 11:53 AM Changeset in webkit [55096] by
-
- 27 edits5 deletes in trunk/WebCore
2010-02-22 Nate Chapin <Nate Chapin>
Reviewed by Dimitri Glazkov.
[V8] Streamline V8 event listener code. Merge all the variants of
V8DOMWrapper::getEventListner() into a single version and generate
addEventListener() and removeEventListener() bindings for all objects
except DOMWindow.
- 11:29 AM Changeset in webkit [55095] by
-
- 3 edits2 adds in trunk
AX: AXFocused is not writable like it should be on nodes
https://bugs.webkit.org/show_bug.cgi?id=35186
Reviewed by Beth Dakin.
WebCore:
Test: platform/mac/accessibility/element-focus.html
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::canSetFocusAttribute):
LayoutTests:
- platform/mac/accessibility/element-focus-expected.txt: Added.
- platform/mac/accessibility/element-focus.html: Added.
- 11:24 AM Changeset in webkit [55094] by
-
- 2 edits in trunk/WebKit/qt
2010-02-22 Laszlo Gombos <Laszlo Gombos>
Unreviewed Symbian build fix.
[Qt] Updated the def file with new exports to enable
building DumpRenderTree.
- symbian/eabi/QtWebKitu.def:
- 11:12 AM Changeset in webkit [55093] by
-
- 5 edits in trunk/JavaScriptCore
JSStringBuilder should not CRASH if allocation fails, it should throw a JSException.
Reviewed by Oliver Hunt.
- runtime/JSGlobalObjectFunctions.cpp:
- runtime/JSStringBuilder.h:
(JSC::JSStringBuilder::JSStringBuilder):
(JSC::JSStringBuilder::append):
(JSC::JSStringBuilder::build):
- runtime/StringBuilder.h:
(JSC::StringBuilder::build):
- wtf/Vector.h:
(WTF::VectorBufferBase::tryAllocateBuffer):
(WTF::):
(WTF::VectorBuffer::tryAllocateBuffer):
(WTF::::tryExpandCapacity):
(WTF::::tryReserveCapacity):
(WTF::::tryAppend):
- 11:07 AM Changeset in webkit [55092] by
-
- 4 edits in trunk
2010-02-22 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
Bump library versioning for 1.1.22 release.
- configure.ac:
WebKit/gtk:
2010-02-22 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
Update for release.
- NEWS:
- 11:02 AM Changeset in webkit [55091] by
-
- 2 edits1 add in trunk/JavaScriptCore
2010-02-22 Kwang Yul Seo <skyul@company100.net>
Reviewed by Eric Seidel.
[BREWMP] Map FastMalloc to BREW memory allocator
https://bugs.webkit.org/show_bug.cgi?id=33570
Use MALLOC macro instead of the standard malloc function.
Although RVCT provides malloc, we can't use it in BREW
because the loader does not initialize the base address properly.
- wtf/FastMalloc.cpp:
- wtf/brew/SystemMallocBrew.h: Added. (mallocBrew): (callocBrew): (freeBrew): (reallocBrew):
- 10:48 AM Changeset in webkit [55090] by
-
- 11 edits in trunk/WebCore
2010-02-22 Simon Fraser <Simon Fraser>
Reviewed by Dan Bernstein, Darin Adler.
Remove addScrolledContentOffset/subtractScrolledContentOffset
https://bugs.webkit.org/show_bug.cgi?id=35225
Remove RenderLayer's addScrolledContentOffset() and subtractScrolledContentOffset()
methods, and instead use the existing scrolledContentOffset(), and use
IntSize and IntPoint instead of lots of x, y variables.
Added new IntPoint toPoint(const IntSize&) method as a convenience to convert a size to a point,
which is needed in a few places.
- page/EventHandler.cpp: (WebCore::EventHandler::handleDrag): Use the new toPoint() convenience.
- platform/graphics/IntPoint.h: (WebCore::toPoint): New convenience method to convert an IntSize to an IntPoint.
- rendering/LayoutState.cpp: (WebCore::LayoutState::LayoutState):
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::layoutBlock): (WebCore::RenderBlock::paintObject): (WebCore::RenderBlock::selectionGapRectsForRepaint): (WebCore::RenderBlock::nodeAtPoint): (WebCore::RenderBlock::offsetForContents):
- rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::paintFillLayerExtended):
- rendering/RenderInline.cpp: (WebCore::RenderInline::clippedOverflowRectForRepaint):
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::updateLayerPosition):
- rendering/RenderLayer.h: (WebCore::RenderLayer::size):
- rendering/RenderObject.cpp: (WebCore::RenderObject::computeRectForRepaint):
- rendering/TextControlInnerElements.cpp: (WebCore::RenderTextControlInnerBlock::positionForPoint):
- 10:36 AM Changeset in webkit [55089] by
-
- 12 edits3 copies in trunk
2009-02-22 Adam Langley <agl@google.com>
Reviewed by Darin Fisher.
fontconfig on Linux can change the render preferences on a per strike
basis (a strike a combination of face and size). Because of this, we
need to query fontconfig each time a new FontPlatformData is created
for a new size.
This patch adds support for querying this via ChromiumBridge.
- platform/chromium/ChromiumBridge.h: add getRenderStyleForStrike
- platform/graphics/chromium/FontCacheLinux.cpp: (WebCore::FontCache::createFontPlatformData):
- platform/graphics/chromium/FontCustomPlatformData.cpp: (WebCore::FontCustomPlatformData::fontPlatformData):
- platform/graphics/chromium/FontPlatformDataLinux.cpp: (WebCore::FontPlatformData::FontPlatformData): (WebCore::FontPlatformData::operator=): (WebCore::FontPlatformData::setupPaint): (WebCore::FontPlatformData::queryStyle): add code to query fontconfig via ChromiumBridge
- platform/graphics/chromium/FontPlatformDataLinux.h:
- 10:11 AM Changeset in webkit [55088] by
-
- 4 edits in trunk
Build fix for make distcheck.
- 9:25 AM Changeset in webkit [55087] by
-
- 2 edits in trunk/WebCore
2010-02-22 Laszlo Gombos <Laszlo Gombos>
Reviewed by Kenneth Rohde Christiansen.
Fix compiler warning "suggest parentheses around"
https://bugs.webkit.org/show_bug.cgi?id=35197
No new tests as there is no new functionality.
- wml/WMLVariables.cpp: (WebCore::substituteVariableReferences):
- 9:01 AM Changeset in webkit [55086] by
-
- 8 edits in trunk
WebCore
2010-02-22 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Xan Lopez.
[Soup] loses information related to message flags when converting from/to Resource{Request,Response}
https://bugs.webkit.org/show_bug.cgi?id=35093
Store message flags in WebCore objects, and set them on the
SoupMessage, when creating one from them.
No behaviour change.
- platform/network/soup/ResourceHandleSoup.cpp: (WebCore::fillResponseFromMessage):
- platform/network/soup/ResourceRequest.h: (WebCore::ResourceRequest::soupMessageFlags): (WebCore::ResourceRequest::setSoupMessageFlags):
- platform/network/soup/ResourceRequestSoup.cpp: (WebCore::ResourceRequest::toSoupMessage): (WebCore::ResourceRequest::updateFromSoupMessage):
- platform/network/soup/ResourceResponse.h: (WebCore::ResourceResponse::soupMessageFlags): (WebCore::ResourceResponse::setSoupMessageFlags):
- platform/network/soup/ResourceResponseSoup.cpp: (WebCore::ResourceResponse::toSoupMessage): (WebCore::ResourceResponse::updateFromSoupMessage):
WebKit/gtk
2010-02-22 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Xan Lopez.
[Soup] loses information related to message flags when converting from/to Resource{Request,Response}
https://bugs.webkit.org/show_bug.cgi?id=35093
Update the flags that are stored in the request, when the response
is received.
- WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::dispatchDidReceiveResponse):
- 8:40 AM Changeset in webkit [55085] by
-
- 2 edits in trunk/WebKitTools
[Qt] Build the DRT in debug on Mac OS X
Reviewed by Kenneth Rohde Christiansen.
- DumpRenderTree/qt/DumpRenderTree.pro:
- 8:17 AM Changeset in webkit [55084] by
-
- 2 edits in trunk/WebCore
2010-02-22 Steve Block <steveblock@google.com>
Reviewed by Nate Chapin.
Shared worker types used in globalObjectPrototypeIsDOMWindow are not properly guarded
https://bugs.webkit.org/show_bug.cgi?id=35238
No new tests, build fix only.
- bindings/v8/V8DOMWrapper.cpp: (WebCore::globalObjectPrototypeIsDOMWindow):
- 7:16 AM Changeset in webkit [55083] by
-
- 2 edits in trunk/JavaScriptCore
2010-02-22 Laszlo Gombos <Laszlo Gombos>
Unreviewed build fix.
[Qt] Build fix for RVCT.
Fix after r55024. The "-i" option is for perl not for the
script.
- DerivedSources.pro:
- 7:12 AM Changeset in webkit [55082] by
-
- 6 edits in trunk
2010-02-22 Laszlo Gombos <Laszlo Gombos>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Add support for layout tests on Symbian
https://bugs.webkit.org/show_bug.cgi?id=31589
- WebKit.pro:
2010-02-22 Laszlo Gombos <Laszlo Gombos>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Add support for layout tests on Symbian
https://bugs.webkit.org/show_bug.cgi?id=31589
- DumpRenderTree/qt/DumpRenderTree.pro:
- DumpRenderTree/qt/DumpRenderTreeQt.cpp:
- DumpRenderTree/qt/main.cpp: (main):
- 6:26 AM Changeset in webkit [55081] by
-
- 2 edits in trunk/WebCore
2010-02-22 Steve Block <steveblock@google.com>
Reviewed by Simon Fraser.
Simplifies calculation of the transform in RenderLayer::paintLayer
https://bugs.webkit.org/show_bug.cgi?id=35101
No new tests, optimization only.
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::paintLayer):
- 6:21 AM Changeset in webkit [55080] by
-
- 2 edits in trunk/BugsSite
2010-02-22 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
Reviewed by Maciej Stachowiak.
Don't reset the assignee back to default on component change
There's a risk of reseting a valid assignee for example when
triaging a bug. All components in WebKit have the default
assignee set to webkit-unassigned@webkit.org so this should
not cause problems for people relying on this functionality.
- template/en/custom/bug/edit.html.tmpl:
- 5:42 AM Changeset in webkit [55079] by
-
- 6 edits2 adds in trunk/WebCore
[Qt] Switching from Phonon to QtMultimedia Backend for Qt 4.7
Patch by Nicholas Young <nicholas.young@nokia.com> on 2010-02-22
Reviewed by Tor Arne Vestbø.
https://bugs.webkit.org/show_bug.cgi?id=34631
No new tests. This patch only affects multimedia backend.
- WebCore.pro: Build depends on Qt version.
- css/mediaControlsQt.css: Updated media controls.
- platform/graphics/MediaPlayer.cpp: Different backend included depending on Qt version.
- platform/graphics/qt/MediaPlayerPrivateQt.cpp: Added new QtMultimedia Backend.
(WebCore::MediaPlayerPrivate::create):
(WebCore::MediaPlayerPrivate::registerMediaEngine):
(WebCore::MediaPlayerPrivate::getSupportedTypes):
(WebCore::MediaPlayerPrivate::supportsType):
(WebCore::MediaPlayerPrivate::MediaPlayerPrivate):
(WebCore::MediaPlayerPrivate::~MediaPlayerPrivate):
(WebCore::MediaPlayerPrivate::hasVideo):
(WebCore::MediaPlayerPrivate::hasAudio):
(WebCore::MediaPlayerPrivate::load):
(WebCore::MediaPlayerPrivate::cancelLoad):
(WebCore::MediaPlayerPrivate::play):
(WebCore::MediaPlayerPrivate::pause):
(WebCore::MediaPlayerPrivate::paused):
(WebCore::MediaPlayerPrivate::seek):
(WebCore::MediaPlayerPrivate::seeking):
(WebCore::MediaPlayerPrivate::duration):
(WebCore::MediaPlayerPrivate::currentTime):
(WebCore::MediaPlayerPrivate::buffered):
(WebCore::MediaPlayerPrivate::maxTimeSeekable):
(WebCore::MediaPlayerPrivate::bytesLoaded):
(WebCore::MediaPlayerPrivate::totalBytes):
(WebCore::MediaPlayerPrivate::setRate):
(WebCore::MediaPlayerPrivate::setVolume):
(WebCore::MediaPlayerPrivate::supportsMuting):
(WebCore::MediaPlayerPrivate::setMuted):
(WebCore::MediaPlayerPrivate::networkState):
(WebCore::MediaPlayerPrivate::readyState):
(WebCore::MediaPlayerPrivate::setVisible):
(WebCore::MediaPlayerPrivate::mediaStatusChanged):
(WebCore::MediaPlayerPrivate::handleError):
(WebCore::MediaPlayerPrivate::stateChanged):
(WebCore::MediaPlayerPrivate::nativeSizeChanged):
(WebCore::MediaPlayerPrivate::queuedSeekTimeout):
(WebCore::MediaPlayerPrivate::seekTimeout):
(WebCore::MediaPlayerPrivate::positionChanged):
(WebCore::MediaPlayerPrivate::durationChanged):
(WebCore::MediaPlayerPrivate::volumeChanged):
(WebCore::MediaPlayerPrivate::mutedChanged):
(WebCore::MediaPlayerPrivate::updateStates):
(WebCore::MediaPlayerPrivate::setSize):
(WebCore::MediaPlayerPrivate::naturalSize):
(WebCore::MediaPlayerPrivate::paint):
(WebCore::MediaPlayerPrivate::repaint):
- platform/graphics/qt/MediaPlayerPrivateQt.h: Added new QtMultimedia Backend.
(WebCore::MediaPlayerPrivate::isAvailable):
(WebCore::MediaPlayerPrivate::supportsFullscreen):
- platform/qt/RenderThemeQt.cpp:
(WebCore::RenderThemeQt::mediaControlsBaselineOpacity): New method.
(WebCore::RenderThemeQt::paintMediaBackground): Background depends on baseline opacity.
(WebCore::RenderThemeQt::paintMediaMuteButton): Changed styling.
(WebCore::RenderThemeQt::paintMediaCurrentTime): Added current time display.
(WebCore::RenderThemeQt::formatMediaControlsCurrentTime): Added time formatting.
(WebCore::RenderThemeQt::formatMediaControlsRemainingTime): Added time formatting.
(WebCore::RenderThemeQt::paintMediaVolumeSliderTrack): Volume slider added.
(WebCore::RenderThemeQt::paintMediaVolumeSliderThumb): Volume slider added.
(WebCore::RenderThemeQt::paintMediaSliderTrack): Updated for QtMultimedia.
(WebCore::RenderThemeQt::paintMediaSliderThumb): Dropped an unnecessary check.
(WebCore::RenderThemeQt::adjustSliderThumbSize): Handle a missing case.
- platform/qt/RenderThemeQt.h: Reimplemented a few more methods.
- 5:02 AM Changeset in webkit [55078] by
-
- 2 edits in trunk/WebCore
2010-02-22 Alexander Pavlov <apavlov@chromium.org>
Not reviewed: mac build fix
- bindings/js/ScriptDebugServer.cpp: (WebCore::ScriptDebugServer::ScriptDebugServer):
- 4:14 AM Changeset in webkit [55077] by
-
- 15 edits2 adds in trunk
2010-02-22 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: there should be a way to "deactivate" or "skip" all breakpoints while debugging.
https://bugs.webkit.org/show_bug.cgi?id=33217
WebCore:
- English.lproj/localizedStrings.js:
- bindings/js/ScriptDebugServer.cpp: (WebCore::ScriptDebugServer::ScriptDebugServer): (WebCore::ScriptDebugServer::hasBreakpoint): (WebCore::ScriptDebugServer::setBreakpointsActivated):
- bindings/js/ScriptDebugServer.h:
- bindings/v8/ScriptDebugServer.h: (WebCore::ScriptDebugServer::setBreakpointsActivated):
- inspector/InspectorBackend.cpp: (WebCore::InspectorBackend::activateBreakpoints): (WebCore::InspectorBackend::deactivateBreakpoints):
- inspector/InspectorBackend.h:
- inspector/InspectorBackend.idl:
- inspector/front-end/Images/deactivateBreakpointsButtonGlyph.png: Added.
- inspector/front-end/Images/deactivateBreakpointsDisabledButtonGlyph.png: Added.
- inspector/front-end/InspectorBackendStub.js: (.WebInspector.InspectorBackendStub.prototype.activateBreakpoints): (.WebInspector.InspectorBackendStub.prototype.deactivateBreakpoints):
- inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel): (WebInspector.ScriptsPanel.prototype.get breakpointsActivated): (WebInspector.ScriptsPanel.prototype.addBreakpoint): (WebInspector.ScriptsPanel.prototype._stepOutClicked): (WebInspector.ScriptsPanel.prototype._toggleBreakpointsClicked):
- inspector/front-end/inspector.css:
- inspector/front-end/textViewer.css:
WebKit/chromium:
- src/js/DebuggerAgent.js: (devtools.DebuggerAgent): (devtools.DebuggerAgent.prototype.setBreakpointsActivated): (devtools.DebuggerAgent.prototype.handleBreakEvent_): (devtools.DebuggerAgent.prototype.handleExceptionEvent_):
- src/js/InspectorControllerImpl.js: (devtools.InspectorBackendImpl.prototype.activateBreakpoints): (devtools.InspectorBackendImpl.prototype.deactivateBreakpoints):
- 3:18 AM Changeset in webkit [55076] by
-
- 2 edits in trunk/WebCore
REGRESSION (r55039): Animation starts from near end when loaded over slow network
<http://webkit.org/b/35222> / <rdar://problem/7673523>
Rubber-stamped by Sam Weinig and Maciej Stachowiak.
Roll out r55039 (related to <http://webkit.org/b/35115>) as it causes animated GIFs
to skip intermediate frames when loading over a slower network.
- platform/graphics/BitmapImage.cpp:
(WebCore::BitmapImage::startAnimation):
- 2:31 AM Changeset in webkit [55075] by
-
- 12 edits1 delete in trunk/WebCore
Not reviewed, build fix.
Revert the previous change.
- 1:28 AM Changeset in webkit [55074] by
-
- 12 edits1 add in trunk/WebCore
2010-02-21 Maciej Stachowiak <mjs@apple.com>
Reviewed by Darin Adler.
Cache JavaScript wrappers inline in DOM nodes
https://bugs.webkit.org/show_bug.cgi?id=35226
<rdar://problem/7664202>
8.8% speedup on Dromaeo DOM Core tests.
3.3% speedup on Hixie DOM Core tests.
- bindings/js/JSDOMBinding.cpp: (WebCore::forgetDOMNode): Clear wrapper pointer. (WebCore::cacheDOMNodeWrapper): Cache inline too if caching for normal world.
- bindings/js/JSDOMBinding.h: (WebCore::DOMObjectWrapperMapFor):
- bindings/js/JSDocumentCustom.cpp: (WebCore::toJS): Remove unneeded argument from getCachedDOMNodeWrapper.
- bindings/js/JSNodeCustom.cpp: (WebCore::createWrapperInline): Renamed version of original createWrapper. (WebCore::createWrapper): Call createWrapperInline. Out-of-line version. (WebCore::toJSNewlyCreated): Call createWrapperInline instead of createWrapper.
- bindings/js/JSNodeCustom.h: Added. (WebCore::getCachedDOMNodeWrapper): Moved here so it can be inlined. (WebCore::toJS): Moved here so it can be inlined.
- bindings/js/ScriptWrappable.h: (WebCore::ScriptWrappable::ScriptWrappable): Implement this in the obvious way for JavaScriptCore. (WebCore::ScriptWrappable::wrapper): (WebCore::ScriptWrappable::setWrapper): (WebCore::ScriptWrappable::clearWrapper):
- bindings/scripts/CodeGeneratorJS.pm: Include CustomHeader heaaders in the header, not just the impl file, so they can add inlining.
- dom/Node.idl: Add CustomHeader directive.
Add new files to build.
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- 1:13 AM Changeset in webkit [55073] by
-
- 9 edits1 add in trunk/WebCore
2010-02-22 Pavel Feldman <pfeldman@chromium.org>
Not reviewed: windows build fix.
- 12:08 AM Changeset in webkit [55072] by
-
- 1 edit in trunk/JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def
Part 2 of Windows build fix.
Feb 21, 2010:
- 11:59 PM Changeset in webkit [55071] by
-
- 34 edits1 move2 deletes in trunk
2010-02-21 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: stop on inline breakpoints on reload.
- ScriptBreakpoint struct has been introduced and reused in InspectorController and debug server.
- JavaScriptDebugServer was moved to bindings/js and renamed to ScriptDebugServer
There were no changes to semantics, only some mechanical changes:
- addBreakpoint and updateBreakpoint were merged into setBreakpoint
- ScriptDebugServer now operates ScriptBreakpoint instances instead of BreakpointInfo.
- It no longer allocates maps and breakpoint info in heap - all done on stack.
- JavaScriptDebugListener is now ScriptDebugServer::Listener
- Listener methods no longer have ExecState (was unused).
- addListener/removeListener pair wuth no page argument removed (was unused).
- InspectorController now binds sourceID to url and maintains a map of 'sticky'
breakpoints. Whenever script is loaded and there is a sticky breakpoint url matching,
breakpoint is being 'restored' synchronously in debug server and pushed to frontend.
Front-end no longer stores map of sticky breakpoints.
- setBreakpoint/removeBreakpoint/didParseSource trio handle this logic.
- A bunch of if(USE_JSC/V8/other) forks removed.
- InspectorFrontend now operates primitive types only, got rid of USE_JSC as well.
- GNUmakefile.am:
- WebCore.base.exp:
- WebCore.gypi:
- WebCore.order:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSInjectedScriptHostCustom.cpp: (WebCore::JSInjectedScriptHost::currentCallFrame): (WebCore::JSInjectedScriptHost::isActivation):
- bindings/js/ScriptDebugServer.cpp: (WebCore::ScriptDebugServer::shared): (WebCore::ScriptDebugServer::ScriptDebugServer): (WebCore::ScriptDebugServer::~ScriptDebugServer): (WebCore::ScriptDebugServer::addListener): (WebCore::ScriptDebugServer::removeListener): (WebCore::ScriptDebugServer::pageCreated): (WebCore::ScriptDebugServer::hasListenersInterestedInPage): (WebCore::ScriptDebugServer::setBreakpoint): (WebCore::ScriptDebugServer::removeBreakpoint): (WebCore::ScriptDebugServer::hasBreakpoint): (WebCore::ScriptDebugServer::clearBreakpoints): (WebCore::ScriptDebugServer::setPauseOnExceptionsState): (WebCore::ScriptDebugServer::pauseProgram): (WebCore::ScriptDebugServer::continueProgram): (WebCore::ScriptDebugServer::stepIntoStatement): (WebCore::ScriptDebugServer::stepOverStatement): (WebCore::ScriptDebugServer::stepOutOfFunction): (WebCore::ScriptDebugServer::currentCallFrame): (WebCore::ScriptDebugServer::currentCallFrameState): (WebCore::ScriptDebugServer::dispatchDidParseSource): (WebCore::ScriptDebugServer::dispatchFailedToParseSource): (WebCore::toPage): (WebCore::ScriptDebugServer::detach): (WebCore::ScriptDebugServer::sourceParsed): (WebCore::ScriptDebugServer::dispatchFunctionToListeners): (WebCore::ScriptDebugServer::setJavaScriptPaused): (WebCore::ScriptDebugServer::pauseIfNeeded): (WebCore::ScriptDebugServer::callEvent): (WebCore::ScriptDebugServer::atStatement): (WebCore::ScriptDebugServer::returnEvent): (WebCore::ScriptDebugServer::exception): (WebCore::ScriptDebugServer::willExecuteProgram): (WebCore::ScriptDebugServer::didExecuteProgram): (WebCore::ScriptDebugServer::didReachBreakpoint): (WebCore::ScriptDebugServer::recompileAllJSFunctionsSoon): (WebCore::ScriptDebugServer::recompileAllJSFunctions): (WebCore::ScriptDebugServer::didAddListener): (WebCore::ScriptDebugServer::didRemoveListener): (WebCore::ScriptDebugServer::didRemoveLastListener):
- bindings/js/ScriptDebugServer.h: (WebCore::ScriptDebugServer::Listener::~Listener): (WebCore::ScriptDebugServer::): (WebCore::ScriptDebugServer::pauseOnExceptionsState): (WebCore::ScriptDebugServer::hasListeners): (WebCore::ScriptDebugServer::hasGlobalListeners):
- bindings/v8/ScriptDebugServer.cpp: (WebCore::ScriptDebugServer::shared):
- bindings/v8/ScriptDebugServer.h: (WebCore::ScriptDebugServer::Listener::~Listener): (WebCore::ScriptDebugServer::addListener): (WebCore::ScriptDebugServer::removeListener): (WebCore::ScriptDebugServer::setBreakpoint): (WebCore::ScriptDebugServer::removeBreakpoint): (WebCore::ScriptDebugServer::clearBreakpoints): (WebCore::ScriptDebugServer::): (WebCore::ScriptDebugServer::pauseOnExceptionsState): (WebCore::ScriptDebugServer::setPauseOnExceptionsState): (WebCore::ScriptDebugServer::pauseProgram): (WebCore::ScriptDebugServer::continueProgram): (WebCore::ScriptDebugServer::stepIntoStatement): (WebCore::ScriptDebugServer::stepOverStatement): (WebCore::ScriptDebugServer::stepOutOfFunction): (WebCore::ScriptDebugServer::recompileAllJSFunctionsSoon): (WebCore::ScriptDebugServer::recompileAllJSFunctions): (WebCore::ScriptDebugServer::currentCallFrameState): (WebCore::ScriptDebugServer::pageCreated): (WebCore::ScriptDebugServer::ScriptDebugServer): (WebCore::ScriptDebugServer::~ScriptDebugServer):
- bindings/v8/custom/V8InjectedScriptHostCustom.cpp: (WebCore::V8InjectedScriptHost::currentCallFrameCallback): (WebCore::V8InjectedScriptHost::isActivationCallback):
- inspector/InjectedScriptHost.cpp:
- inspector/InjectedScriptHost.h:
- inspector/InjectedScriptHost.idl:
- inspector/InspectorBackend.cpp: (WebCore::InspectorBackend::setBreakpoint): (WebCore::InspectorBackend::removeBreakpoint): (WebCore::InspectorBackend::pauseInDebugger): (WebCore::InspectorBackend::stepOverStatementInDebugger): (WebCore::InspectorBackend::stepIntoStatementInDebugger): (WebCore::InspectorBackend::stepOutOfFunctionInDebugger): (WebCore::InspectorBackend::pauseOnExceptionsState): (WebCore::InspectorBackend::setPauseOnExceptionsState):
- inspector/InspectorBackend.h:
- inspector/InspectorBackend.idl:
- inspector/ScriptBreakpoint.h: Added. (WebCore::InspectorBreakpoint::InspectorBreakpoint):
- inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController): (WebCore::InspectorController::setWindowVisible): (WebCore::InspectorController::scriptObjectReady): (WebCore::InspectorController::close): (WebCore::InspectorController::didCommitLoad): (WebCore::InspectorController::addProfile): (WebCore::InspectorController::startUserInitiatedProfiling): (WebCore::InspectorController::stopUserInitiatedProfiling): (WebCore::InspectorController::enableProfiler): (WebCore::InspectorController::disableProfiler): (WebCore::InspectorController::enableDebuggerFromFrontend): (WebCore::InspectorController::disableDebugger): (WebCore::InspectorController::resumeDebugger): (WebCore::InspectorController::setBreakpoint): (WebCore::InspectorController::removeBreakpoint): (WebCore::InspectorController::didParseSource): (WebCore::InspectorController::failedToParseSource): (WebCore::InspectorController::didPause):
- inspector/InspectorController.h:
- inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::parsedScriptSource): (WebCore::InspectorFrontend::restoredBreakpoint): (WebCore::InspectorFrontend::failedToParseScriptSource): (WebCore::InspectorFrontend::resumedScript):
- inspector/InspectorFrontend.h:
- inspector/JavaScriptDebugListener.h: Removed.
- inspector/JavaScriptDebugServer.cpp: Removed.
- inspector/JavaScriptDebugServer.h: Removed.
- inspector/front-end/Breakpoint.js: (WebInspector.Breakpoint.prototype.set condition):
- inspector/front-end/BreakpointsSidebarPane.js: (WebInspector.BreakpointsSidebarPane.prototype.addBreakpoint): (WebInspector.BreakpointsSidebarPane.prototype._breakpointEnableChanged):
- inspector/front-end/InspectorBackendStub.js: (.WebInspector.InspectorBackendStub.prototype.addBreakpoint):
- inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype.sourceFrameForResource):
- inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel): (WebInspector.ScriptsPanel.prototype.addScript): (WebInspector.ScriptsPanel.prototype.addBreakpoint): (WebInspector.ScriptsPanel.prototype.removeBreakpoint): (WebInspector.ScriptsPanel.prototype._showScriptOrResource):
- inspector/front-end/inspector.js: (WebInspector.restoredBreakpoint):
- page/Page.cpp: (WebCore::Page::Page):
- platform/android/TemporaryLinkStubs.cpp:
- 11:56 PM Changeset in webkit [55070] by
-
- 1 edit in trunk/JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def
Part 1 of Windows build fix.
- 10:50 PM Changeset in webkit [55069] by
-
- 7 edits in trunk
JavaScriptCore: Make UString::m_data be const, and make the UChar owned/ref-counted by CrossThreadRefCounted be const too.
Reviewed by Oliver Hunt.
- runtime/UStringImpl.cpp:
(JSC::UStringImpl::baseSharedBuffer):
(JSC::UStringImpl::~UStringImpl):
- runtime/UStringImpl.h:
(JSC::UStringImpl::create):
(JSC::UStringImpl::data):
(JSC::UStringImpl::UStringImpl):
- wtf/OwnFastMallocPtr.h:
(WTF::OwnFastMallocPtr::~OwnFastMallocPtr):
WebCore: Make the UChar owned/ref-counted by StringImpl::CrossThreadRefCounted be const.
Reviewed by Oliver Hunt.
- platform/text/StringImpl.cpp:
(WebCore::StringImpl::sharedBuffer):
- platform/text/StringImpl.h:
- 10:12 PM Changeset in webkit [55068] by
-
- 2 edits in trunk/JavaScriptCore
2010-02-21 Yuta Kitamura <yutak@chromium.org>
Reviewed by Darin Adler.
HashMapTranslatorAdapter::translate() needs to set the mapped value.
HTTPHeaderMap::add(const char*, const String&) does not work
https://bugs.webkit.org/show_bug.cgi?id=35227
- wtf/HashMap.h: (WTF::HashMapTranslatorAdapter::translate):
- 8:12 PM Changeset in webkit [55067] by
-
- 4 edits3 adds in trunk
2010-02-07 Yuzo Fujishima <yuzo@google.com>
Reviewed by Eric Seidel.
When page-break-{after,before} is set to always, force page breaks even for overflow-specified elements.
RenderBlock::inRootBlockContext() was introduced by Changeset 5611. Although it is a reasonable criteria for choosing an optional page break location, it is not for a mandatory page break as specified by http://dev.w3.org/csswg/css3-page/#forced-pg-brk. The method is removed because it is not used anywhere else.
Note: this patch makes page break work for overflow-specified elements. For tables and floated elements, more work is needed.
https://bugs.webkit.org/show_bug.cgi?id=9526
- printing/page-break-always-for-overflow-expected.txt: Added.
- printing/page-break-always-for-overflow.html: Added.
- printing/script-tests/page-break-always-for-overflow.js: Added.
2010-02-07 Yuzo Fujishima <yuzo@google.com>
Reviewed by Eric Seidel.
When page-break-{after,before} is set to always, force page breaks even for overflow-specified elements.
RenderBlock::inRootBlockContext() was introduced by Changeset 5611. Although it is a reasonable criteria for choosing an optional page break location, it is not for a mandatory page break as specified by http://dev.w3.org/csswg/css3-page/#forced-pg-brk. The method is removed because it is not used anywhere else.
Note: this patch makes page break work for overflow-specified elements. For tables and floated elements, more work is needed.
https://bugs.webkit.org/show_bug.cgi?id=9526
Test: printing/page-break-always-for-overflow.html
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::paintChildren):
- rendering/RenderBlock.h:
- 3:40 PM Changeset in webkit [55066] by
-
- 19 edits in trunk/WebCore
Remove auto_ptr usage in WebCore.
https://bugs.webkit.org/show_bug.cgi?id=35157
Reviewed by Eric Seidel.
The changes consists of:
- Changing auto_ptr arguments or return types to PassOwnPtr.
- Replacing local auto_ptr by OwnPtr.
- Removing now unneeded <memory> inclusion.
- css/CSSParser.cpp:
(WebCore::CSSParser::addProperty):
- loader/WorkerThreadableLoader.cpp:
(WebCore::WorkerThreadableLoader::MainThreadBridge::mainThreadCreateLoader):
(WebCore::workerContextDidReceiveResponse):
(WebCore::workerContextDidReceiveData):
(WebCore::WorkerThreadableLoader::MainThreadBridge::didReceiveData):
(WebCore::workerContextDidReceiveAuthenticationCancellation):
- loader/WorkerThreadableLoader.h:
- loader/icon/IconLoader.cpp:
(WebCore::IconLoader::create):
- loader/icon/IconLoader.h:
- platform/ContextMenu.cpp:
(WebCore::separatorItem):
- platform/CrossThreadCopier.h:
(WebCore::):
- platform/network/HTTPHeaderMap.cpp:
(WebCore::HTTPHeaderMap::copyData):
(WebCore::HTTPHeaderMap::adopt):
- platform/network/HTTPHeaderMap.h:
- platform/network/ResourceRequestBase.cpp:
(WebCore::ResourceRequestBase::adopt):
(WebCore::ResourceRequestBase::copyData):
- platform/network/ResourceRequestBase.h:
- platform/network/ResourceResponseBase.cpp:
(WebCore::ResourceResponseBase::adopt):
(WebCore::ResourceResponseBase::copyData):
- platform/network/ResourceResponseBase.h:
- svg/SVGDocumentExtensions.cpp:
(WebCore::SVGDocumentExtensions::removePendingResource):
- svg/SVGDocumentExtensions.h:
- svg/SVGElement.cpp:
(WebCore::SVGElement::insertedIntoDocument):
- workers/GenericWorkerTask.h:
- workers/WorkerThread.cpp:
(WebCore::WorkerThreadStartupData::create):
- 1:47 PM Changeset in webkit [55065] by
-
- 4 edits in trunk/WebCore
2010-02-21 Simon Fraser <Simon Fraser>
Reviewed by Dan Bernstein.
https://bugs.webkit.org/show_bug.cgi?id=22215
Avoid calling absoluteClippedOverflowRect() so many times
RenderLayer::updateLayerPositions() computes the clipped overflow rect
and the outline bounds for repaint, and then calls repaintAfterLayoutIfNeeded()
which can compute the same rects all over again. Avoid this by passing
these two rects into repaintAfterLayoutIfNeeded() if known. This measurably
reduces the time spent in updateLayerPositions() for some content.
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::updateLayerPositions):
- rendering/RenderObject.cpp: (WebCore::RenderObject::repaintAfterLayoutIfNeeded):
- rendering/RenderObject.h:
- 1:19 PM Changeset in webkit [55064] by
-
- 2 edits in trunk/WebKit/mac
False warnings about needing layout in
-[WebHTMLView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:]
https://bugs.webkit.org/show_bug.cgi?id=35218
Reviewed by Darin Adler.
- WebView/WebHTMLView.mm:
(-[WebHTMLView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:]):
Suppress the warning and the forced layout if the view is not being drawn
in this display operation.
- 12:20 PM Changeset in webkit [55063] by
-
- 2 edits in trunk/WebKit/mac
Reviewed by Sam Weinig.
https://bugs.webkit.org/show_bug.cgi?id=35215
<rdar://problem/7673157>
The plugInViewWithArguments: API passes a dictionary of plugin arguments. One of the parameters
is WebPlugInBaseURLKey, which is a key that represents the base URL of the document containing
the plug-in's view. Instead of sending the base URL, code in WebFrameLoaderClient::createPlugin
would incorrectly pass the source URL of the plug-in resource.
- WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::createPlugin): When building the plug-in arguments dictionary, pass the real base URL for the WebPlugInBaseURLKey key.
- 3:32 AM Changeset in webkit [55062] by
-
- 3 edits17 adds in trunk
2010-02-20 Maciej Stachowiak <mjs@apple.com>
Rubber stamped by Adam Barth.
Add sunspider-0.9.1 to the site in preparation for announcing it.
https://bugs.webkit.org/show_bug.cgi?id=35206
- perf/sunspider-0.9.1: Added.
- perf/sunspider-0.9.1/json2.js: Added.
- perf/sunspider-0.9.1/sunspider-0.9: Added.
- perf/sunspider-0.9.1/sunspider-0.9.1: Added.
- perf/sunspider-0.9.1/sunspider-0.9.1/driver.html: Added.
- perf/sunspider-0.9.1/sunspider-0.9.1/results.html: Added.
- perf/sunspider-0.9.1/sunspider-0.9.1/sunspider-test-contents.js: Added.
- perf/sunspider-0.9.1/sunspider-0.9.1/sunspider-test-prefix.js: Added.
- perf/sunspider-0.9.1/sunspider-0.9/driver.html: Added.
- perf/sunspider-0.9.1/sunspider-0.9/results.html: Added.
- perf/sunspider-0.9.1/sunspider-0.9/sunspider-test-contents.js: Added.
- perf/sunspider-0.9.1/sunspider-0.9/sunspider-test-prefix.js: Added.
- perf/sunspider-0.9.1/sunspider-analyze-results.js: Added.
- perf/sunspider-0.9.1/sunspider-compare-results.js: Added.
- perf/sunspider-0.9.1/sunspider.css: Added.
- perf/sunspider-0.9.1/sunspider.html: Added.
- perf/sunspider-0.9.1/versions.html: Added.
2010-02-20 Maciej Stachowiak <mjs@apple.com>
Reviewed by Adam Barth.
Add sunspider-0.9.1 to the site in preparation for announcing it.
https://bugs.webkit.org/show_bug.cgi?id=35206
- hosted/sunspider.css: Remove tabs, which I noticed where present while copying to the WebKitSite directory.
Feb 20, 2010:
- 10:44 PM Changeset in webkit [55061] by
-
- 13 edits in branches/safari-532-branch
<rdar://problem/7540432> Disable sandboxed iframes for branch
Reviewed by Dan Bernstein.
- Configurations/FeatureDefines.xcconfig:
WebCore:
- Configurations/FeatureDefines.xcconfig:
- WebCore.pri:
WebKit/chromium:
- features.gypi:
WebKit/mac:
- Configurations/FeatureDefines.xcconfig:
WebKitLibraries:
- win/tools/vsprops/FeatureDefines.vsprops:
WebKitTools:
- Scripts/build-webkit:
- 10:20 PM Changeset in webkit [55060] by
-
- 17 edits in branches/safari-532-branch
.: Merged from trunk:
2010-02-20 Maciej Stachowiak <mjs@apple.com>
Reviewed by David Levin.
Add an ENABLE flag for sandboxed iframes to make it possible to disable it in releases
https://bugs.webkit.org/show_bug.cgi?id=35147
- configure.ac:
JavaScriptCore: Merged from trunk:
2010-02-20 Maciej Stachowiak <mjs@apple.com>
Reviewed by David Levin.
Add an ENABLE flag for sandboxed iframes to make it possible to disable it in releases
https://bugs.webkit.org/show_bug.cgi?id=35147
- Configurations/FeatureDefines.xcconfig:
WebCore: Merged from trunk:
2010-02-20 Maciej Stachowiak <mjs@apple.com>
Reviewed by David Levin.
Add an ENABLE flag for sandboxed iframes to make it possible to disable it in releases
https://bugs.webkit.org/show_bug.cgi?id=35147
I made ENABLE(SANDBOX) only control the sandbox attribute itself;
I did not ifdef the infrastructure to make sandboxing
switchable. This is because the likely concerns about sandboxing
are not stability of the infrastructure code, but rather the fact
that the security model exposed to authors is still evolving.
- Configurations/FeatureDefines.xcconfig:
- GNUmakefile.am:
- WebCore.pri:
- html/HTMLIFrameElement.cpp:
(WebCore::HTMLIFrameElement::parseMappedAttribute):
WebKit/chromium: Merged from trunk:
2010-02-20 Maciej Stachowiak <mjs@apple.com>
Reviewed by David Levin.
Add an ENABLE flag for sandboxed iframes to make it possible to disable it in releases
https://bugs.webkit.org/show_bug.cgi?id=35147
- features.gypi:
WebKit/mac: Merged from trunk:
2010-02-20 Maciej Stachowiak <mjs@apple.com>
Reviewed by David Levin.
Add an ENABLE flag for sandboxed iframes to make it possible to disable it in releases
https://bugs.webkit.org/show_bug.cgi?id=35147
- Configurations/FeatureDefines.xcconfig:
WebKitLibraries: Merged from trunk:
2010-02-20 Maciej Stachowiak <mjs@apple.
Reviewed by David Levin.
Add an ENABLE flag for sandboxed iframes to make it possible to disable it in releases
https://bugs.webkit.org/show_bug.cgi?id=35147
- win/tools/vsprops/FeatureDefines.vsprops:
WebKitTools: Merged from trunk:
2010-02-20 Maciej Stachowiak <mjs@apple.com>
Reviewed by David Levin.
Add an ENABLE flag for sandboxed iframes to make it possible to disable it in releases
https://bugs.webkit.org/show_bug.cgi?id=35147
- Scripts/build-webkit: Handle new flag.
- 10:01 PM Changeset in webkit [55059] by
-
- 2 edits in trunk/WebCore
Reviewed by Maciej Stachowiak.
https://bugs.webkit.org/show_bug.cgi?id=35202
<rdar://problem/4856597> Calling Java method which accepts Object always passes a null argument
- bridge/jni/jsc/JNIUtilityPrivate.cpp: (JSC::Bindings::convertValueToJValue): Add cases for other JS types.
- 9:22 PM Changeset in webkit [55058] by
-
- 3 edits in trunk/WebCore
2010-02-20 Laszlo Gombos <Laszlo Gombos>
Reviewed by Darin Adler.
Fix compiler warning "suggest parentheses around"
https://bugs.webkit.org/show_bug.cgi?id=35197
No new tests as there is no new functionality.
- html/DateComponents.cpp: (WebCore::beforeGregorianStartDate):
- plugins/PluginDatabase.cpp: (WebCore::PluginDatabase::findPlugin):
- 12:44 PM Changeset in webkit [55057] by
-
- 2 edits1 move in trunk/WebKitTools
Moved simplejson into webkitpy/thirdparty directory.
Reviewed by Adam Barth.
https://bugs.webkit.org/show_bug.cgi?id=35196
- Scripts/run-chromium-webkit-tests:
- Added webkitpy/thirdparty to the script's search path.
- Scripts/webkitpy/thirdparty/simplejson: Copied from WebKitTools/simplejson.
- Copied simplejson directory.
- simplejson: Removed.
- simplejson/LICENSE.txt: Removed.
- simplejson/README.txt: Removed.
- simplejson/init.py: Removed.
- simplejson/_speedups.c: Removed.
- simplejson/decoder.py: Removed.
- simplejson/encoder.py: Removed.
- simplejson/jsonfilter.py: Removed.
- simplejson/scanner.py: Removed.
- 12:24 PM Changeset in webkit [55056] by
-
- 4 edits in trunk
2010-02-20 Noam Rosenthal <noam.rosenthal@nokia.com>
Reviewed by Laszlo Gombos.
[Qt] ENABLE_3D_RENDERING should be optional
https://bugs.webkit.org/show_bug.cgi?id=35100
- WebKit.pri: ENABLE_3D_RENDERING moved to a proper feature test
2010-02-20 Noam Rosenthal <noam.rosenthal@nokia.com>
Reviewed by Laszlo Gombos.
[Qt] ENABLE_3D_RENDERING should be optional
https://bugs.webkit.org/show_bug.cgi?id=35100
No new tests: this is a build fix.
- WebCore.pri: ENABLE_3D_RENDERING is now a proper feature test
- 11:36 AM Changeset in webkit [55055] by
-
- 6 edits1 move in trunk/WebKitTools
2010-02-20 Chris Jerdonek <Chris Jerdonek>
Reviewed by Adam Barth.
Moved BeautifulSoup to webkitpy/thirdparty directory.
- Scripts/webkitpy/BeautifulSoup.py: Removed.
- Moved to webkitpy/thirdparty.
- Scripts/webkitpy/bugzilla.py:
- Updated import statement.
- Scripts/webkitpy/bugzilla_unittest.py:
- Updated import statement.
- Scripts/webkitpy/buildbot.py:
- Updated import statement.
- Scripts/webkitpy/buildbot_unittest.py:
- Updated import statement.
- Scripts/webkitpy/statusserver.py:
- Updated import statement.
- Scripts/webkitpy/thirdparty/BeautifulSoup.py: Copied from WebKitTools/Scripts/webkitpy/BeautifulSoup.py.
- 10:22 AM Changeset in webkit [55054] by
-
- 3 edits in trunk/WebCore
Reviewed by Maciej Stachowiak.
https://bugs.webkit.org/show_bug.cgi?id=23742
Applet methods can not return arrays to JS
- bridge/jni/jsc/JNIBridgeJSC.cpp: (JavaArray::JavaArray): Don't accidentally zero out m_rootObject (that's how PassRefPtr works). Without m_rootObject, we crash quickly.
- bridge/jni/jsc/JavaInstanceJSC.cpp: (JavaInstance::invokeMethod): Do handle returned arrays. Also, added an ifdef around code that's only needed on Tiger, and removed a comment saying it can be removed when "new" plugin ships. I doubt that anyone can remember what "new" could refer to back then.
- 9:42 AM Changeset in webkit [55053] by
-
- 2 edits1 move2 adds in trunk/WebKitTools
2010-02-20 Chris Jerdonek <Chris Jerdonek>
Reviewed by Adam Barth.
Created a directory for third-party Python code, and moved
autoinstall.py into it.
- Scripts/webkitpy/init.py:
- Updated "import autoinstall" statement.
- Scripts/webkitpy/autoinstall.py: Removed.
- Moved to thirdparty/autoinstall.py.
- Scripts/webkitpy/thirdparty: Added.
- Scripts/webkitpy/thirdparty/init.py: Added.
- Scripts/webkitpy/thirdparty/autoinstall.py: Copied from WebKitTools/Scripts/webkitpy/autoinstall.py.
- 7:40 AM Changeset in webkit [55052] by
-
- 3 edits in trunk/WebCore
2010-02-20 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: re-creating view in ResourcesPanel confuses ScriptsPanel's visibleView logic.
- inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype.recreateViewForResourceIfNeeded):
- inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype.show): (WebInspector.ScriptsPanel.prototype.viewRecreated):
- 7:23 AM Changeset in webkit [55051] by
-
- 3 edits in trunk/WebCore
2010-02-20 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: need to highlight the evaluated expression used for popovers.
- inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype._mouseMove): (WebInspector.SourceFrame.prototype._hidePopup): (WebInspector.SourceFrame.prototype._mouseHover): (WebInspector.SourceFrame.prototype._showPopup.showObjectPopup): (WebInspector.SourceFrame.prototype._showPopup):
- inspector/front-end/inspector.css:
- 6:29 AM Changeset in webkit [55050] by
-
- 8 edits in trunk
Roll out 55047, since it causes regressions in layout and API tests.
- 6:29 AM Changeset in webkit [55049] by
-
- 2 edits in trunk/WebKitTools
Unreviewed, obvious fix for the python failure in our new buildbot step:
http://build.webkit.org/builders/GTK Linux 32-bit Release/builds/9075/steps/API tests/logs/err.text
- 6:13 AM Changeset in webkit [55048] by
-
- 2 edits in trunk/WebKit/gtk
2010-02-20 Gustavo Noronha Silva <Gustavo Noronha Silva>
Unreviewed. Trivial fix - unnecessary variable got added by
mistake.
- WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::dispatchDidReceiveResponse):
- 4:35 AM Changeset in webkit [55047] by
-
- 8 edits in trunk
WebCore
2010-02-19 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Xan Lopez.
[Soup] loses information related to message flags when converting from/to Resource{Request,Response}
https://bugs.webkit.org/show_bug.cgi?id=35093
Store message flags in WebCore objects, and set them on the
SoupMessage, when creating one from them.
No behaviour change.
- platform/network/soup/ResourceHandleSoup.cpp: (WebCore::fillResponseFromMessage):
- platform/network/soup/ResourceRequest.h: (WebCore::ResourceRequest::soupMessageFlags): (WebCore::ResourceRequest::setSoupMessageFlags):
- platform/network/soup/ResourceRequestSoup.cpp: (WebCore::ResourceRequest::toSoupMessage): (WebCore::ResourceRequest::updateFromSoupMessage):
- platform/network/soup/ResourceResponse.h: (WebCore::ResourceResponse::soupMessageFlags): (WebCore::ResourceResponse::setSoupMessageFlags):
- platform/network/soup/ResourceResponseSoup.cpp: (WebCore::ResourceResponse::toSoupMessage): (WebCore::ResourceResponse::updateFromSoupMessage):
WebKit/gtk
2010-02-18 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Xan Lopez.
[Soup] loses information related to message flags when converting from/to Resource{Request,Response}
https://bugs.webkit.org/show_bug.cgi?id=35093
Update the flags that are stored in the request, when the response
is received.
- WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::dispatchDidReceiveResponse):
- 4:25 AM Changeset in webkit [55046] by
-
- 3 edits in trunk/WebCore
2010-02-19 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Xan Lopez.
[Soup] loses information related to message flags when converting from/to Resource{Request,Response}
https://bugs.webkit.org/show_bug.cgi?id=35093
Refactor updating of ResourceResponse objects from soup message
objects, to avoid code duplication.
No behaviour change.
- platform/network/soup/ResourceHandleSoup.cpp: (WebCore::fillResponseFromMessage):
- platform/network/soup/ResourceResponseSoup.cpp: (WebCore::ResourceResponse::updateFromSoupMessage):
- 1:33 AM Changeset in webkit [55045] by
-
- 2 edits in trunk/WebCore
Reviewed by Maciej Stachowiak.
https://bugs.webkit.org/show_bug.cgi?id=35190
Don't use system malloc in Java bindings
- bridge/jni/jsc/JavaInstanceJSC.cpp: (JavaInstance::invokeMethod): Switched to WTF::Vector.
- 12:24 AM Changeset in webkit [55044] by
-
- 2 edits in trunk/WebCore
Reviewed by Maciej Stachowiak.
https://bugs.webkit.org/show_bug.cgi?id=9761
LiveConnect string conversion fails for java.lang.Object
Can't test Java in DRT (I wonder why).
- bridge/jni/jsc/JNIUtilityPrivate.cpp: (JSC::Bindings::convertValueToJValue): Added the necessary conversion. Also, removed CONVERT_NULL_TO_EMPTY_STRING dead code.
Feb 19, 2010:
- 7:06 PM Changeset in webkit [55043] by
-
- 17 edits in trunk
2010-02-19 Maciej Stachowiak <mjs@apple.com>
Reviewed by David Levin.
Add an ENABLE flag for sandboxed iframes to make it possible to disable it in releases
https://bugs.webkit.org/show_bug.cgi?id=35147
- Configurations/FeatureDefines.xcconfig:
2010-02-19 Maciej Stachowiak <mjs@apple.com>
Reviewed by David Levin.
Add an ENABLE flag for sandboxed iframes to make it possible to disable it in releases
https://bugs.webkit.org/show_bug.cgi?id=35147
- win/tools/vsprops/FeatureDefines.vsprops:
2010-02-19 Maciej Stachowiak <mjs@apple.com>
Reviewed by David Levin.
Add an ENABLE flag for sandboxed iframes to make it possible to disable it in releases
https://bugs.webkit.org/show_bug.cgi?id=35147
- features.gypi:
2010-02-19 Maciej Stachowiak <mjs@apple.com>
Reviewed by David Levin.
Add an ENABLE flag for sandboxed iframes to make it possible to disable it in releases
https://bugs.webkit.org/show_bug.cgi?id=35147
- Configurations/FeatureDefines.xcconfig:
2010-02-19 Maciej Stachowiak <mjs@apple.com>
Reviewed by David Levin.
Add an ENABLE flag for sandboxed iframes to make it possible to disable it in releases
https://bugs.webkit.org/show_bug.cgi?id=35147
I made ENABLE(SANDBOX) only control the sandbox attribute itself;
I did not ifdef the infrastructure to make sandboxing
switchable. This is because the likely concerns about sandboxing
are not stability of the infrastructure code, but rather the fact
that the security model exposed to authors is still evolving.
- Configurations/FeatureDefines.xcconfig:
- GNUmakefile.am:
- WebCore.pri:
- html/HTMLIFrameElement.cpp: (WebCore::HTMLIFrameElement::parseMappedAttribute):
2010-02-19 Maciej Stachowiak <mjs@apple.com>
Reviewed by David Levin.
Add an ENABLE flag for sandboxed iframes to make it possible to disable it in releases
https://bugs.webkit.org/show_bug.cgi?id=35147
- configure.ac:
2010-02-19 Maciej Stachowiak <mjs@apple.com>
Reviewed by David Levin.
Add an ENABLE flag for sandboxed iframes to make it possible to disable it in releases
https://bugs.webkit.org/show_bug.cgi?id=35147
- Scripts/build-webkit: Handle new flag.
- 6:08 PM Changeset in webkit [55042] by
-
- 3 edits in trunk/WebKitTools
2010-02-19 Leandro Pereira <leandro@profusion.mobi>
Reviewed by Shinichiro Hamaji.
[style-queue] should not complain about identifier names with underscores under WebKit/efl/ewk/
https://bugs.webkit.org/show_bug.cgi?id=35091
White list unix_hacker_style names in WebKit/efl/ewk because these
are used in the EFL API.
- Scripts/webkitpy/style/checker.py:
- Filter out readability/naming on WebKit/efl/ewk.
- 5:23 PM Changeset in webkit [55041] by
-
- 7 edits in trunk
Reviewed by Maciej Stachowiak.
https://bugs.webkit.org/show_bug.cgi?id=35132
<rdar://problem/7664353> Mouse cursor sometimes flickers over Flash content (35132)
WebCore:
- page/EventHandler.cpp: (WebCore::EventHandler::handleMouseMoveEvent): Don't set mouse pointer when above a plug-in or applet to prevent flicker.
WebKit:
- Plugins/WebNetscapePluginEventHandlerCarbon.mm: (WebNetscapePluginEventHandlerCarbon::mouseMoved): Send adjustCursor events on every mouse move. This matches Firefox, and is actually required for plug-ins to manipulate cursor wihout resorting to techniques such as fast firing timers.
- Plugins/WebNetscapePluginView.mm: (-[WebNetscapePluginView handleMouseEntered:]): Some plug-ins handle mouse cursor internally, but those that don't just need to get an arrow cursor (matching Firefox). This means that e.g. a plugin inside <A> won't get a finger mouse pointer.
- Plugins/WebHostedNetscapePluginView.mm: (-[WebNetscapePluginView handleMouseEntered:]): (-[WebNetscapePluginView handleMouseExited:]): Implement this behavior here, too. Also, out of process code didn't reset mouse pointer on mouse exit, which it needed to do.
- WebView/WebHTMLView.mm: (needsCursorRectsSupportAtPoint): (setCursor): (resetCursorRects): Make sure that the same workaround we have for Web content also applies to Netscape plug-ins, as AppKit would reset the mouse pointer to arrow if given a chance. (+[WebHTMLViewPrivate initialize]): Renamed setCursorIMP on Leopard and higher to prevent confusion - the method we override is completely different. (-[WebHTMLView hitTest:]): Added a FIXME about a likely bug.
- 4:51 PM Changeset in webkit [55040] by
-
- 2 edits in trunk/LayoutTests
2010-02-19 Eric Seidel <eric@webkit.org>
Reviewed by Dimitri Glazkov.
fast/forms/search-event-delay.html failed on Snow Leopard Debug Bot
https://bugs.webkit.org/show_bug.cgi?id=33543
- platform/mac-snowleopard/Skipped:
- This test prints times and expects 0.1s precision even on Debug bots. That can't work. Skipping the test to make the bots green until this can be made non-flakey or until we have a layout test system which allows "failure" expectations.
- 4:45 PM Changeset in webkit [55039] by
-
- 2 edits in trunk/WebCore
Fix regression in calculating an animated image's start time.
https://bugs.webkit.org/show_bug.cgi?id=35115
Reviewed by Adam Barth.
- platform/graphics/BitmapImage.cpp:
(WebCore::BitmapImage::startAnimation):
- 4:44 PM Changeset in webkit [55038] by
-
- 2 edits in trunk/LayoutTests
2010-02-19 Eric Seidel <eric@webkit.org>
Reviewed by Dimitri Glazkov.
editing/pasteboard/4641033.html timed out on Tiger Bot
https://bugs.webkit.org/show_bug.cgi?id=33310
- platform/mac-tiger/Skipped:
- 4:41 PM Changeset in webkit [55037] by
-
- 4 edits in trunk/WebKit/chromium
2010-02-19 James Hawkins <jhawkins@chromium.org>
Reviewed by Darin Fisher.
[Chromium] Call WebViewClient::didAcceptAutoFillSuggestion when the
user selects a suggestion from the AutoFill suggestions popup.
- public/WebViewClient.h: (WebKit::WebViewClient::didAcceptAutoFillSuggestion):
- src/AutoFillPopupMenuClient.cpp: (WebKit::AutoFillPopupMenuClient::valueChanged):
- src/AutoFillPopupMenuClient.h:
- 3:44 PM Changeset in webkit [55036] by
-
- 13 edits in trunk/WebCore
Reviewed by Geoffrey Garen.
https://bugs.webkit.org/show_bug.cgi?id=35178
LiveConnect code uses hand-rolled fprintf logging
Changed to use LOG, LOG_ERROR and ASSERT.
- platform/Logging.cpp: (WebCore::getChannelFromName):
- platform/Logging.h:
- platform/mac/LoggingMac.mm: (WebCore::InitializeLoggingChannelsIfNecessary):
- platform/win/LoggingWin.cpp: (WebCore::InitializeLoggingChannelsIfNecessary): TextConversion channel was (almost) unused, renamed to LiveConnect.
- platform/text/gtk/TextCodecGtk.cpp: (WebCore::TextCodecGtk::registerEncodingNames): The only use of this channel was in platform specific code, commandeered it for cross-platform needs.
- bridge/jni/JNIBridge.cpp:
- bridge/jni/JNIUtility.cpp: (JSC::Bindings::getJavaVM): (JSC::Bindings::getJNIEnv): (JSC::Bindings::getJNIField):
- bridge/jni/JNIUtility.h: (JSC::Bindings::callJNIMethodV): (JSC::Bindings::callJNIStaticMethod):
- bridge/jni/jni_jsobject.mm: (completedJavaScriptAccess): (dispatchToJavaScriptThread): (performJavaScriptAccess): (JavaJSObject::invoke): (JavaJSObject::call): (JavaJSObject::eval): (JavaJSObject::getMember): (JavaJSObject::setMember): (JavaJSObject::removeMember): (JavaJSObject::getSlot): (JavaJSObject::setSlot): (JavaJSObject::toString): (JavaJSObject::createNative):
- bridge/jni/jsc/JNIBridgeJSC.cpp: (JavaField::valueFromInstance): (JavaField::setValueToInstance):
- bridge/jni/jsc/JavaClassJSC.cpp: (JavaClass::JavaClass):
- bridge/jni/jsc/JavaInstanceJSC.cpp: (JavaInstance::invokeMethod): (JObjectWrapper::JObjectWrapper): (JObjectWrapper::~JObjectWrapper):
- 3:36 PM Changeset in webkit [55035] by
-
- 5 edits in trunk/JavaScriptCore
JSString::getIndex() calls value() to resolve the string value (is a rope)
to a UString, then passes the result to jsSingleCharacterSubstring without
checking for an exception. In case of out-of-memory the returned UString
is null(), which may result in an out-of-buounds substring being created.
This is bad.
Reviewed by Oliver Hunt.
Simple fix is to be able to get an index from a rope without resolving to
UString. This may be a useful optimization in some test cases.
The same bug exists in some other methods is JSString, these can be fixed
by changing them to call getIndex().
- runtime/JSString.cpp:
(JSC::JSString::resolveRope):
(JSC::JSString::getStringPropertyDescriptor):
- runtime/JSString.h:
(JSC::jsSingleCharacterSubstring):
(JSC::JSString::getIndex):
(JSC::jsSingleCharacterString):
(JSC::JSString::getStringPropertySlot):
- runtime/UStringImpl.cpp:
(JSC::singleCharacterSubstring):
- runtime/UStringImpl.h:
(JSC::UStringImpl::singleCharacterSubstring):
- 3:07 PM Changeset in webkit [55034] by
-
- 5 edits1 move in trunk/WebKitTools
2010-02-19 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Split out "prepare-rollout" from "rollout" and make --complete-rollout default
https://bugs.webkit.org/show_bug.cgi?id=33745
- Scripts/webkitpy/commands/download.py:
- Add a new AbstractRolloutPrepCommand to share code between PrepareRollout and Rollout
- Add PrepareRollout
- Scripts/webkitpy/commands/download_unittest.py: Test PrepareRollout, remove CompleteRollout tests.
- Scripts/webkitpy/steps/init.py: include ReopenBugAfterRollout step.
- Scripts/webkitpy/steps/completerollout.py: Removed.
- Scripts/webkitpy/steps/options.py: remove complete_rollout
- Scripts/webkitpy/steps/reopenbugafterrollout.py: Added.
- 3:06 PM Changeset in webkit [55033] by
-
- 2 edits in trunk/WebCore
2010-02-19 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
RenderSVGResourceMasker causes an Assert on Wind builds during DRT
https://bugs.webkit.org/show_bug.cgi?id=35182
We remove the Assert for now and return earlier, if the HashMap of the Masker
does not contain the RenderObject. The RenderObject is an identifiert to get
a already calculated mask.
A race condition during parsing can cause the invalidation call, before the mask
got calculated (only during DRT on Win build bots).
The real bug will be fixed with: https://bugs.webkit.org/show_bug.cgi?id=35181
- rendering/RenderSVGResourceMasker.cpp: (WebCore::RenderSVGResourceMasker::invalidateClient):
- 2:50 PM Changeset in webkit [55032] by
-
- 2 edits in trunk/WebKit/chromium
2010-02-19 James Hawkins <jhawkins@chromium.org>
Reviewed by Eric Seidel.
[Chromium] Use the m_suggestionsPopupClient pointer to refer to the
popup client, as the Autocomplete popup might not be the current
popup.
- src/WebViewImpl.cpp: (WebKit::WebViewImpl::autocompleteHandleKeyEvent): (WebKit::WebViewImpl::refreshSuggestionsPopup):
- 2:34 PM Changeset in webkit [55031] by
-
- 4 edits in trunk/WebKit/chromium
2010-02-19 James Hawkins <jhawkins@chromium.org>
Reviewed by Eric Seidel.
[Chromium] Rename EditorClientImpl::onAutofillSuggestionAccepted to
onAutocompleteSuggestionAccepted to better match the purpose of the
function.
- src/EditorClientImpl.cpp: (WebKit::EditorClientImpl::onAutocompleteSuggestionAccepted):
- src/EditorClientImpl.h:
- src/SuggestionsPopupMenuClient.cpp: (WebKit::SuggestionsPopupMenuClient::valueChanged):
- 2:10 PM Changeset in webkit [55030] by
-
- 5 edits in trunk/WebKit/mac
2010-02-19 Simon Fraser <Simon Fraser>
Reviewed by Dan Bernstein.
<rdar://problem/7535894> Page contents missing from snapshot on Newsweek.com article
Followup to avoid capturing compositing layers twice in snapshots. Add private
methods to WebView to specify whether drawing the WebView into an image will
include flattened compositing layers (the default behavior) or not.
- WebView/WebFrame.mm: (-[WebFrame _drawRect:contentsOnly:]): Consult the WebView flag to see if we want flattening.
- WebView/WebViewPrivate.h: New methods.
- WebView/WebView.mm: Ditto. (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]): (-[WebView _setIncludesFlattenedCompositingLayersWhenDrawingToBitmap:]): (-[WebView _includesFlattenedCompositingLayersWhenDrawingToBitmap]):
- WebView/WebViewData.h: New member variable.
- 1:44 PM Changeset in webkit [55029] by
-
- 11 edits in trunk
WebCore: Make Pasteboard::writeImage() safe against NULL cachedImages, and clean
up some code.
https://bugs.webkit.org/show_bug.cgi?id=35136
Reviewed by Darin Fisher.
- loader/ImageLoader.cpp:
(WebCore::ImageLoader::updateRenderer): Shorten some code.
- page/DragController.cpp:
(WebCore::getImage): Shorten some code.
- platform/chromium/PasteboardChromium.cpp:
(WebCore::Pasteboard::writeImage): NULL-check cachedImage().
- platform/gtk/PasteboardGtk.cpp:
(WebCore::Pasteboard::writeImage): NULL-check cachedImage().
- platform/mac/PasteboardMac.mm:
(WebCore::Pasteboard::writeImage): NULL-check cachedImage().
- platform/qt/PasteboardQt.cpp:
(WebCore::Pasteboard::writeImage): NULL-check cachedImage().
- platform/win/PasteboardWin.cpp:
(WebCore::Pasteboard::writeImage): NULL-check cachedImage().
WebKit/chromium: Add an isImageBlocked bool to the WebContextMenuData struct.
https://bugs.webkit.org/show_bug.cgi?id=35136
Reviewed by Darin Fisher.
This lets us properly enable/disable the "Copy Image" context menu entry
(and, in the future, maybe add a "Load Image" function).
- public/WebContextMenuData.h:
- src/ContextMenuClientImpl.cpp:
(WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems):
- 1:30 PM Changeset in webkit [55028] by
-
- 2 edits in trunk/WebCore
Rubberstamped by Noam Rosenthal, who wrote the original code.
Make mouse wheel scrolling work when using the GraphicsLayer.
- platform/graphics/qt/GraphicsLayerQt.cpp:
(WebCore::GraphicsLayerQtImpl::GraphicsLayerQtImpl):
- 1:08 PM Changeset in webkit [55027] by
-
- 7 edits1 add in trunk/JavaScriptCore
2010-02-19 Oliver Hunt <oliver@apple.com>
RS = Gavin Barraclough.
Split the 32/64 version of JITPropertyAccess into a separate file.
- GNUmakefile.am:
- JavaScriptCore.gypi:
- JavaScriptCore.pri:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- JavaScriptCore.xcodeproj/project.pbxproj:
- jit/JITPropertyAccess.cpp:
- jit/JITPropertyAccess32_64.cpp: Added. (JSC::JIT::emit_op_put_by_index): (JSC::JIT::emit_op_put_getter): (JSC::JIT::emit_op_put_setter): (JSC::JIT::emit_op_del_by_id): (JSC::JIT::emit_op_method_check): (JSC::JIT::emitSlow_op_method_check): (JSC::JIT::emit_op_get_by_val): (JSC::JIT::emitSlow_op_get_by_val): (JSC::JIT::emit_op_put_by_val): (JSC::JIT::emitSlow_op_put_by_val): (JSC::JIT::emit_op_get_by_id): (JSC::JIT::emitSlow_op_get_by_id): (JSC::JIT::emit_op_put_by_id): (JSC::JIT::emitSlow_op_put_by_id): (JSC::JIT::compileGetByIdHotPath): (JSC::JIT::compileGetByIdSlowCase): (JSC::JIT::compilePutDirectOffset): (JSC::JIT::compileGetDirectOffset): (JSC::JIT::testPrototype): (JSC::JIT::privateCompilePutByIdTransition): (JSC::JIT::patchGetByIdSelf): (JSC::JIT::patchMethodCallProto): (JSC::JIT::patchPutByIdReplace): (JSC::JIT::privateCompilePatchGetArrayLength): (JSC::JIT::privateCompileGetByIdProto): (JSC::JIT::privateCompileGetByIdSelfList): (JSC::JIT::privateCompileGetByIdProtoList): (JSC::JIT::privateCompileGetByIdChainList): (JSC::JIT::privateCompileGetByIdChain): (JSC::JIT::emit_op_get_by_pname): (JSC::JIT::emitSlow_op_get_by_pname):
- 12:30 PM Changeset in webkit [55026] by
-
- 1 edit in trunk/WebKitTools/BuildSlaveSupport/build.webkit.org-config/config.json
2010-02-19 William Siegrist <wsiegrist@apple.com>
Add GTK Linux 64-bit Release bot. Rename GTK Linux Release to GTK Linux 32-bit Release.
- 11:47 AM Changeset in webkit [55025] by
-
- 4 edits in trunk/WebKitTools
2010-02-19 Jesus Sanchez-Palencia <jesus.palencia@openbossa.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Need a final integration between QtLauncher and QGVLauncher
https://bugs.webkit.org/show_bug.cgi?id=35161
Add animated flip support to QtLauncher when running on QGraphicsView mode.
- QtLauncher/main.cpp: (LauncherWindow::initializeView): (LauncherWindow::setupUI):
- QtLauncher/webview.cpp: (WebViewGraphicsBased::WebViewGraphicsBased): (WebViewGraphicsBased::animatedFlip): (WebViewGraphicsBased::animatedYFlip):
- QtLauncher/webview.h: (WebViewGraphicsBased::setYRotation): (WebViewGraphicsBased::yRotation):
- 11:30 AM Changeset in webkit [55024] by
-
- 2 edits1 move in trunk/JavaScriptCore
2010-02-19 Patrick Gansterer <paroga@paroga.com>
Reviewed by Laszlo Gombos.
Added additional parameter to create_rvct_stubs
for setting the regularexpression prefix.
Renamed it because it now works for other platforms too.
https://bugs.webkit.org/show_bug.cgi?id=34951
- DerivedSources.pro:
- create_jit_stubs: Copied from JavaScriptCore/create_rvct_stubs.
- create_rvct_stubs: Removed.
- 11:22 AM Changeset in webkit [55023] by
-
- 2 edits in trunk/WebCore
2010-02-19 Nate Chapin <Nate Chapin>
Reviewed by Dimitri Glazkov.
[V8] Fix Worker crash regression in r54972
- bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::instantiateV8Object): Properly unwrap global objects when inside a WorkerContext.
- 11:09 AM Changeset in webkit [55022] by
-
- 3 edits in trunk/WebCore
Not reviewed. Reverts r55020 which causes crashes in Chromium LayoutTests
- 10:59 AM Changeset in webkit [55021] by
-
- 5 edits in trunk
Reviewed by Dan Bernstein.
https://bugs.webkit.org/show_bug.cgi?id=35165
plugins/set-status.html fails on Windows bot
- Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::status):
- Plugins/WebNetscapePluginView.mm: (-[WebNetscapePluginView status:]): Match Windows port behavior (and also Firefox one, in a way) - pass null status messages as empty ones to chrome.
- 9:13 AM Changeset in webkit [55020] by
-
- 3 edits in trunk/WebCore
2010-02-19 Steve Block <steveblock@google.com>
Reviewed by David Levin.
Sets default values of V8 runtime enabler flags to match behavior with JSC
https://bugs.webkit.org/show_bug.cgi?id=35095
No new tests, modifies a Chromium feature only.
- bindings/generic/RuntimeEnabledFeatures.cpp: Modified. Sets appcache and geolocation flag defaults to 'on'
- storage/Database.cpp: Modified. Sets database flag default to 'on'.
- 9:13 AM Changeset in webkit [55019] by
-
- 5 edits20 adds in trunk
[Qt] Implement textZoomIn() and textZoomOut() in DRT's EventSender, add results
for passing new tests and unskip the passing ones from the Skipped list.
https://bugs.webkit.org/show_bug.cgi?id=35159
Reviewed by Kenneth Rohde Christiansen.
WebKitTools:
- DumpRenderTree/qt/EventSenderQt.cpp:
(EventSender::textZoomIn):
(EventSender::textZoomOut):
- DumpRenderTree/qt/EventSenderQt.h:
LayoutTests:
- platform/qt/Skipped: unskip passing tests
- platform/qt/svg/custom/text-zoom-expected.txt: Added.
- platform/qt/svg/zoom: Added.
- platform/qt/svg/zoom/page: Added.
- platform/qt/svg/zoom/page/absolute-sized-document-no-scrollbars-expected.txt: Added.
- platform/qt/svg/zoom/page/absolute-sized-document-scrollbars-expected.txt: Added.
- platform/qt/svg/zoom/page/relative-sized-document-scrollbars-expected.txt: Added.
- platform/qt/svg/zoom/page/zoom-foreignObject-expected.txt: Added.
- platform/qt/svg/zoom/page/zoom-hixie-mixed-008-expected.txt: Added.
- platform/qt/svg/zoom/page/zoom-hixie-mixed-009-expected.txt: Added.
- platform/qt/svg/zoom/page/zoom-hixie-rendering-model-004-expected.txt: Added.
- platform/qt/svg/zoom/page/zoom-svg-float-border-padding-expected.txt: Added.
- platform/qt/svg/zoom/text: Added.
- platform/qt/svg/zoom/text/absolute-sized-document-no-scrollbars-expected.txt: Added.
- platform/qt/svg/zoom/text/absolute-sized-document-scrollbars-expected.txt: Added.
- platform/qt/svg/zoom/text/relative-sized-document-scrollbars-expected.txt: Added.
- platform/qt/svg/zoom/text/zoom-foreignObject-expected.txt: Added.
- platform/qt/svg/zoom/text/zoom-hixie-mixed-008-expected.txt: Added.
- platform/qt/svg/zoom/text/zoom-hixie-mixed-009-expected.txt: Added.
- platform/qt/svg/zoom/text/zoom-hixie-rendering-model-004-expected.txt: Added.
- platform/qt/svg/zoom/text/zoom-svg-float-border-padding-expected.txt: Added.
- 8:57 AM Changeset in webkit [55018] by
-
- 2 edits in trunk/WebKit/chromium
2010-02-19 Marcus Bulach <bulach@chromium.org>
Reviewed by Jeremy Orlow.
Fixes GeolocationServiceBridgeImpl::stopUpdating (it can be called multiple times).
- src/GeolocationServiceBridgeChromium.cpp: (WebKit::GeolocationServiceBridgeImpl::stopUpdating):
- 8:50 AM Changeset in webkit [55017] by
-
- 2 edits in trunk/LayoutTests
2010-02-19 Philippe Normand <pnormand@igalia.com>
Rubber-stamped by Gustavo Noronha Silva.
[GTK] fast/forms/restore-selection-after-layout.html fails on 32bits Debug build
https://bugs.webkit.org/show_bug.cgi?id=35158
- platform/gtk/Skipped: Skip failing test
- 7:16 AM Changeset in webkit [55016] by
-
- 9 edits2 adds in trunk
2010-02-19 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Pavel Feldman.
WebInspector: Elements panel: Correctly show empty elements' ending tags
for XML and HTML documents.
https://bugs.webkit.org/show_bug.cgi?id=26315
- inspector/console-dirxml-expected.txt:
- inspector/console-format-collections-expected.txt:
- inspector/console-format-expected.txt:
- inspector/elements-panel-limited-children-expected.txt:
- inspector/elements-panel-structure-expected.txt: Re-baselined due to closing tags and ellipses between opening and closing tags
- inspector/elements-panel-xhtml-structure-expected.txt: Added.
- inspector/elements-panel-xhtml-structure.xhtml: Added.
2010-02-19 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Pavel Feldman.
WebInspector: Elements panel: Correctly show empty elements' ending tags
for XML and HTML documents.
https://bugs.webkit.org/show_bug.cgi?id=26315
Test: inspector/elements-panel-xhtml-structure.xhtml
- inspector/InspectorController.cpp: (WebCore::InspectorController::populateScriptObjects):
- inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeOutline.prototype.set rootDOMNode): (WebInspector.ElementsTreeOutline.prototype.get isXMLMimeType): (WebInspector.ElementsTreeOutline.prototype._contextMenuEventFired): (WebInspector.ElementsTreeElement.prototype.onexpand): (WebInspector.ElementsTreeElement.prototype.oncollapse): (WebInspector.ElementsTreeElement.prototype.updateTitle.callback): (WebInspector.ElementsTreeElement.prototype.updateTitle): (WebInspector.ElementsTreeElement.prototype._nodeTitleInfo):
- 6:52 AM Changeset in webkit [55015] by
-
- 1 edit in trunk/LayoutTests/ChangeLog
Unreviewed Changelog typo fix.
- 6:45 AM Changeset in webkit [55014] by
-
- 2 edits in trunk/LayoutTests
Rubber-stamped by Kenneth Rohde Christiansen.
[Qt] plugins/set-status.html introduced in r5993 fails skipping it until fix.
https://bugs.webkit.org/show_bug.cgi?id=35144
- platform/qt/Skipped:
- 6:34 AM Changeset in webkit [55013] by
-
- 3 edits in trunk/WebKitTools
2010-02-19 Laszlo Gombos <Laszlo Gombos>
Reviewed by Eric Seidel.
[Qt] Clean-up the handling of HTML5 persistent data for LayoutTests
https://bugs.webkit.org/show_bug.cgi?id=35004
DumpRenderTreeQt.cpp calls QWebSettings::enablePersistentStorage which sets up
and enables all HTML5 persistent data. All the other calls for setting the
persistent path or enabling the persistent feature are redundant.
- DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::WebPage::WebPage): No need to enable AppCache again.
- DumpRenderTree/qt/main.cpp: (main): No need to setup and enable HTML5 LocalStorage again.
- 5:13 AM Changeset in webkit [55012] by
-
- 5 edits in trunk
2010-02-19 Diego Gonzalez <diego.gonzalez@openbossa.org>
Reviewed by Kenneth Rohde Christiansen.
Send the context menu event from contextClick() of EventSender
and do not show context menu in DRT.
LayoutTests:
fast/events/contextmenu-scrolled-page-with-frame.html
[Qt] DRT: Send context menu event from EventSender
https://bugs.webkit.org/show_bug.cgi?id=35131
- platform/qt/Skipped:
2010-02-19 Diego Gonzalez <diego.gonzalez@openbossa.org>
Reviewed by Kenneth Rohde Christiansen.
Send the context menu event from contextClick() of EventSender
and do not show context menu in DRT.
LayoutTests:
fast/events/contextmenu-scrolled-page-with-frame.html
[Qt] DRT: Send context menu event from EventSender
https://bugs.webkit.org/show_bug.cgi?id=35131
- DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::DumpRenderTree::DumpRenderTree):
- DumpRenderTree/qt/EventSenderQt.cpp: (EventSender::contextClick):
- 5:01 AM Changeset in webkit [55011] by
-
- 5 edits in trunk
2010-02-19 Pavel Feldman <pfeldman@chromium.org>
Not reviewed. Chromium build fix: reverting r54997 and r54998.
This is a two-sided change that should be coordinated.
- bindings/v8/custom/V8LocationCustom.cpp: (WebCore::V8Location::protocolAccessorSetter):
- platform/KURLGoogle.cpp: (WebCore::KURL::setProtocol): (WebCore::KURL::isHierarchical):
- 4:41 AM Changeset in webkit [55010] by
-
- 2 edits2 copies in trunk/LayoutTests
[Qt] editing tests fails after r54980
https://bugs.webkit.org/show_bug.cgi?id=35145
Reviewed by Kenneth Rohde Christiansen.
After r54980 two tests fail, skip them until fix.
Another two tests pass, they have same results as Win port.
- platform/qt/Skipped:
- editing/selection/extend-selection.html skipped.
- editing/selection/extend-after-mouse-selection.html skipped.
- platform/qt/editing/selection/click-in-margins-inside-editable-div-expected.txt: Copied from LayoutTests/platform/win/editing/selection/click-in-margins-inside-editable-div-expected.txt.
- platform/qt/editing/selection/click-in-padding-with-multiple-line-boxes-expected.txt: Copied from LayoutTests/platform/win/editing/selection/click-in-padding-with-multiple-line-boxes-expected.txt.
- 4:40 AM Changeset in webkit [55009] by
-
- 2 edits in trunk/WebKit/chromium
2010-02-19 Pavel Feldman <pfeldman@chromium.org>
Not reviewed. Chromium tests fix: update devtools code to match new
web inspector object proxy format.
- src/js/DebuggerAgent.js: (devtools.DebuggerAgent.prototype.formatCallFrame_): (devtools.DebuggerAgent.formatObjectProxy_):
- 4:06 AM Changeset in webkit [55008] by
-
- 2 edits in trunk/LayoutTests
2010-02-19 Philippe Normand <pnormand@igalia.com>
Rubber-stamped by Xan Lopez.
[GTK] plugins/set-status.html fails
https://bugs.webkit.org/show_bug.cgi?id=35144
- platform/gtk/Skipped: Skip failing test.
- 1:18 AM Changeset in webkit [55007] by
-
- 1 edit1 add in trunk/LayoutTests
2010-02-19 Philippe Normand <pnormand@igalia.com>
Rubber-stamped by Xan Lopez.
Adding a GTK layout test result for a new test
added in r54980.
- platform/gtk/editing/selection/extend-after-mouse-selection-expected.txt: Added.
- 1:18 AM Changeset in webkit [55006] by
-
- 1 edit1 add in trunk/LayoutTests
2010-02-19 Philippe Normand <pnormand@igalia.com>
Rubber-stamped by Xan Lopez.
Adding a GTK layout test result for a new test
added in r54982.
- platform/gtk/fast/repaint/selection-gap-overflow-scroll-2-expected.txt: Added.
- 12:30 AM Changeset in webkit [55005] by
-
- 2 edits1 add in trunk/WebCore
2010-02-17 Philippe Normand <pnormand@igalia.com>
Reviewed by Eric Seidel.
[GTK] RTP/RTSP streams playback support
https://bugs.webkit.org/show_bug.cgi?id=33662
Added live pipelines support in updateStates().
- manual-tests/video-rtsp.html: Added.
- platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivate::seek): (WebCore::MediaPlayerPrivate::updateStates):
Feb 18, 2010:
- 11:49 PM Changeset in webkit [55004] by
-
- 10 edits in branches/safari-532-branch
mark-radar-fixed
<rdar://problem/7540469> Disable ruby support for the branch
- Configurations/FeatureDefines.xcconfig:
WebCore:
- Configurations/FeatureDefines.xcconfig:
WebKit/mac:
- Configurations/FeatureDefines.xcconfig:
WebKitLibraries:
- win/tools/vsprops/FeatureDefines.vsprops:
WebKitTools:
- Scripts/build-webkit:
- 11:32 PM Changeset in webkit [55003] by
-
- 6 edits in trunk/LayoutTests
Rubber-stamped by Simon Hausmann.
[Qt] Update platform specific expected files after r54991.
- platform/qt/svg/css/circle-in-mask-with-shadow-expected.txt: updated.
- platform/qt/svg/css/mask-with-shadow-expected.txt: updated.
- platform/qt/svg/custom/empty-mask-expected.txt: updated.
- platform/qt/svg/custom/mask-with-default-value-expected.txt: updated.
- platform/qt/svg/custom/transformedMaskFails-expected.txt: updated.
- 10:23 PM Changeset in webkit [55002] by
-
- 9 edits in trunk/JavaScriptCore
2010-02-18 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
Improve interpreter getter performance
https://bugs.webkit.org/show_bug.cgi?id=35138
Improve the performance of getter dispatch by making it possible
for the interpreter to cache the GetterSetter object lookup.
To do this we simply need to make PropertySlot aware of getters
as a potentially cacheable property, and record the base and this
objects for a getter access. This allows us to use more-or-less
identical code to that used by the normal get_by_id caching, with
the dispatch being the only actual difference.
I'm holding off of implementing this in the JIT until I do some
cleanup to try and making coding in the JIT not be as horrible
as it is currently.
- bytecode/CodeBlock.cpp: (JSC::CodeBlock::dump): (JSC::CodeBlock::derefStructures): (JSC::CodeBlock::refStructures):
- bytecode/Opcode.h:
- interpreter/Interpreter.cpp: (JSC::Interpreter::resolveGlobal): (JSC::Interpreter::tryCacheGetByID): (JSC::Interpreter::privateExecute):
- jit/JIT.cpp: (JSC::JIT::privateCompileMainPass):
- jit/JITStubs.cpp: (JSC::JITThunks::tryCacheGetByID): (JSC::DEFINE_STUB_FUNCTION):
- runtime/JSObject.cpp: (JSC::JSObject::fillGetterPropertySlot):
- runtime/PropertySlot.cpp: (JSC::PropertySlot::functionGetter):
- runtime/PropertySlot.h: (JSC::PropertySlot::isGetter): (JSC::PropertySlot::isCacheable): (JSC::PropertySlot::isCacheableValue): (JSC::PropertySlot::setValueSlot): (JSC::PropertySlot::setGetterSlot): (JSC::PropertySlot::setCacheableGetterSlot): (JSC::PropertySlot::clearOffset): (JSC::PropertySlot::thisValue):
- 9:17 PM Changeset in webkit [55001] by
-
- 5 edits2 adds in trunk/WebKitTools
2010-02-18 Chris Jerdonek <Chris Jerdonek>
Reviewed by Shinichiro Hamaji.
Moved parsing-related code to a separate file. Also increased
the unit test coverage in some affected areas.
This revision contains no new functionality.
- Scripts/check-webkit-style:
- Adjusted to call check_webkit_style_parser().
- Scripts/webkitpy/style/checker.py:
- Added check_webkit_style_parser() to pass checker.py configuration settings to optparser.py.
- Moved _create_usage() and the CommandOptionValues, DefaultCommandOptionValues, ArgumentPrinter, and ArgumentParser classes to optparser.py.
- Scripts/webkitpy/style/checker_unittest.py:
- Moved the ProcessorOptionsTest, ArgumentPrinterTest, and ArgumentParserTest classes to optparser.py.
- Added the CheckWebKitStyleFunctionTest class to check the check_webkit_style_configuration() and check_webkit_style_parser() code paths.
- Scripts/webkitpy/style/optparser.py: Added.
- From checker.py, added _create_usage() and the CommandOptionValues, DefaultCommandOptionValues, ArgumentPrinter, and ArgumentParser classes.
- In the ArgumentParser constructor--
- Added all_categories as a required parameter.
- Removed the default value from the default_options parameter.
- Scripts/webkitpy/style/optparser_unittest.py: Added.
- From checker_unittest.py, added the ProcessorOptionsTest, ArgumentPrinterTest, and ArgumentParserTest classes.
- Added the CreateUsageTest class to test _create_usage().
- Scripts/webkitpy/style/unittests.py:
- Added optparser_unittest import.
- 9:14 PM Changeset in webkit [55000] by
-
- 2 edits in branches/safari-532-branch/WebKitLibraries
- Add change I missed in the last commit.
- win/tools/vsprops/FeatureDefines.vsprops:
- 9:00 PM Changeset in webkit [54999] by
-
- 14 edits3 adds in trunk
2010-02-18 Yaar Schnitman <yaar@chromium.org>
Reviewed by Darin Adler.
Normalize custom ctors for Image, Option, Audio
https://bugs.webkit.org/show_bug.cgi?id=34782
- fast/js/custom-constructors-expected.txt: Added.
- fast/js/custom-constructors.html: Added.
- fast/js/script-tests/custom-constructors.js: Added.
2010-02-18 Yaar Schnitman <yaar@chromium.org>
Reviewed by Darin Adler.
Normalize custom ctors for Image, Option, Audio
https://bugs.webkit.org/show_bug.cgi?id=34782
Test: fast/js/custom-constructors.html
- bindings/js/JSAudioConstructor.cpp: (WebCore::JSAudioConstructor::JSAudioConstructor): (WebCore::constructAudio):
- bindings/js/JSImageConstructor.cpp: (WebCore::constructImage):
- bindings/js/JSOptionConstructor.cpp: (WebCore::constructHTMLOptionElement):
- bindings/v8/custom/V8HTMLAudioElementConstructor.cpp: (WebCore::v8HTMLAudioElementConstructorCallback):
- bindings/v8/custom/V8HTMLImageElementConstructor.cpp: (WebCore::v8HTMLImageElementConstructorCallback):
- bindings/v8/custom/V8HTMLOptionElementConstructor.cpp: (WebCore::v8HTMLOptionElementConstructorCallback):
- html/HTMLAudioElement.cpp: (WebCore::HTMLAudioElement::HTMLAudioElement): (WebCore::HTMLAudioElement::createForJSConstructor):
- html/HTMLAudioElement.h:
- html/HTMLImageElement.cpp: (WebCore::HTMLImageElement::createForJSConstructor): (WebCore::HTMLImageElement::mapToEntry): (WebCore::HTMLImageElement::createRenderer): (WebCore::HTMLImageElement::attach): (WebCore::HTMLImageElement::width): (WebCore::HTMLImageElement::height): (WebCore::HTMLImageElement::naturalHeight):
- html/HTMLImageElement.h:
- html/HTMLOptionElement.cpp: (WebCore::HTMLOptionElement::HTMLOptionElement): (WebCore::HTMLOptionElement::createForJSConstructor): (WebCore::HTMLOptionElement::ownerSelectElement): (WebCore::HTMLOptionElement::nonRendererRenderStyle): (WebCore::HTMLOptionElement::disabled): (WebCore::HTMLOptionElement::insertedIntoTree):
- html/HTMLOptionElement.h:
- 8:29 PM Changeset in webkit [54998] by
-
- 2 edits in trunk/WebKit/chromium
2010-02-12 Kent Tamura <tkent@chromium.org>
Unreviewed. Fix Chromium build.
- DEPS: Bump Google URL revision to 123.
- 6:06 PM Changeset in webkit [54997] by
-
- 3 edits in trunk/WebCore
2010-02-12 Brett Wilson <brettw@chromium.org>
Reviewed by Adam Barth.
Update the Google-URL version of KURL and the V8 bindings to the new
behavior of KURL.IsStandard.
This is covered by fast/dom/Window/invalid-protocol.html
- bindings/v8/custom/V8LocationCustom.cpp: (WebCore::V8Location::protocolAccessorSetter):
- platform/KURLGoogle.cpp: (WebCore::KURL::setProtocol): (WebCore::KURL::isHierarchical):
- 5:21 PM Changeset in webkit [54996] by
-
- 2 edits in trunk/WebKitTools
Reviewed by Dan Bernstein.
https://bugs.webkit.org/show_bug.cgi?id=35134
<rdar://problem/7246280> Crash when a plugin calls NPN_SetStatus(0)
- DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: (testSetStatus): (pluginInvoke): Added a setStatus() method.
- 4:47 PM Changeset in webkit [54995] by
-
- 2 edits in trunk/WebCore
2010-02-18 Simon Fraser <Simon Fraser>
No Review.
Remove a couple of extraneous spaces that got added to the project file
by hand-ending.
- WebCore.xcodeproj/project.pbxproj:
- 4:44 PM Changeset in webkit [54994] by
-
- 8 edits in trunk
2010-02-18 Simon Fraser <Simon Fraser>
Reviewed by Dan Bernstein.
<rdar://problem/7535894> Page contents missing from snapshot on Newsweek.com article
Add logic to determine when painting via the software rendering path will give an equivalent
result to the accelerated compositing presentation. This tests for the presence of 3D transforms
via the existing RenderLayerCompositor::has3DContent() method.
- WebCore.base.exp: Export FrameView's isSoftwareRenderable(), paintBehavior() and setPaintBehavior().
- page/FrameView.h:
- page/FrameView.cpp: (WebCore::FrameView::isSoftwareRenderable): New method. (WebCore::FrameView::paintBehavior): Make this non-inline so that we can reliably export it.
- 4:37 PM Changeset in webkit [54993] by
-
- 3 edits2 adds in trunk
Reviewed by Dan Bernstein.
https://bugs.webkit.org/show_bug.cgi?id=35134
<rdar://problem/7246280> Crash when a plugin calls NPN_SetStatus(0)
Test: plugins/set-status.html
- Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::status): (WebKit::NetscapePluginInstanceProxy::loadURL): Added null checks for CFStringCreateWithCString arguments.
- 4:19 PM Changeset in webkit [54992] by
-
- 5 edits2 adds in trunk
<rdar://problem/7658811> Multiple style recalcs due to getComputedStyle() on “display: none;” element
when there are pending style sheets
Reviewed by John Sullivan.
WebCore:
Test: fast/css/getComputedStyle/pending-stylesheet.html
When querying a property of a computed style declaration for a non-rendered element,
CSSStyleSelector::styleForElement() was called, and if there were pending style sheet, it
would behave as if the lack of renderer is due to FOUC suppression, and set a flag on
the document causing it to recalculate style. On the next computed style property access,
style would be recalculated for the document, but then the flag would get set again if the
element did not have a renderer.
- dom/Document.cpp:
(WebCore::Document::styleForElementIgnoringPendingStylesheets): Added. Temporarily sets
m_ignorePendingStylesheets around the call to CSSStyleSelector::styleForElement().
- dom/Document.h:
- dom/Element.cpp:
(WebCore::Element::computedStyle): Use Document::styleForElementIgnoringPendingStylesheets().
LayoutTests:
- fast/css/getComputedStyle/pending-stylesheet-expected.txt: Added.
- fast/css/getComputedStyle/pending-stylesheet.html: Added.
- 3:12 PM Changeset in webkit [54991] by
-
- 52 edits3 adds2 deletes in trunk
2010-02-18 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
Move SVGResources to Renderers, starting with Masker
https://bugs.webkit.org/show_bug.cgi?id=35020
We have rendering specific code in WebCore/svg/graphics. The goal is to move
this code into suitable Renderers. This helps us to clean up the code and makes
maintenance easier. It also makes it possible to remove rendering specific code
from SVG*Elements into this renderers. So the Renderer contains everything that
is needed to use the resource.
RenderSVGResource will be the base class for all new resource render classes like
RenderSVGResourceMasker, RenderSVGResourceClipper and the other resources.
This patch starts moving SVGResourceMasker to RenderSVGResourceMasker.
Another benefit is the much more useful result in DRT on using masker.
- Android.mk:
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- rendering/RenderObject.cpp: (WebCore::RenderObject::toRenderSVGResource): Conversion to RenderSVGResource base class.
- rendering/RenderObject.h: (WebCore::RenderObject::isSVGResource): Check if renderer is a resource.
- rendering/RenderPath.cpp:
- rendering/RenderSVGImage.cpp: (WebCore::RenderSVGImage::destroy): Renderer gets destroyed, unregister it from it's resources.
- rendering/RenderSVGImage.h: Some code clean up according to the webkit style. (WebCore::RenderSVGImage::toSVGRenderBase): (WebCore::RenderSVGImage::renderName): (WebCore::RenderSVGImage::isSVGImage): (WebCore::RenderSVGImage::localToParentTransform): (WebCore::RenderSVGImage::strokeBoundingBox): (WebCore::RenderSVGImage::requiresLayer): (WebCore::RenderSVGImage::localTransform):
- rendering/RenderSVGInlineText.h: (WebCore::RenderSVGInlineText::objectBoundingBox): Needed for SVGRenderTreeAsText
- rendering/RenderSVGModelObject.cpp: (WebCore::RenderSVGModelObject::destroy): Renderer gets destroyed, unregister it from it's resources.
- rendering/RenderSVGModelObject.h:
- rendering/RenderSVGResource.h: Added. (WebCore::): Base class for all Resource renderers like masker, clipper and others. (WebCore::RenderSVGResource::RenderSVGResource): (WebCore::RenderSVGResource::cast): (WebCore::RenderSVGResource::toRenderSVGResource): (WebCore::RenderSVGResource::isSVGResource): (WebCore::RenderSVGResource::drawsContents): (WebCore::getRenderSVGResourceById):
- rendering/RenderSVGResourceMasker.cpp: Added. (WebCore::RenderSVGResourceMasker::RenderSVGResourceMasker): (WebCore::RenderSVGResourceMasker::~RenderSVGResourceMasker): (WebCore::RenderSVGResourceMasker::invalidateClients): Status of masker changed, remove all clients. (WebCore::RenderSVGResourceMasker::invalidateClient): Status of an object changed, remove pending client. (WebCore::RenderSVGResourceMasker::applyResource): Apply masker to object. (WebCore::RenderSVGResourceMasker::resourceBoundingBox): boundingBox of the resource, depending on the object. (WebCore::RenderSVGResourceMasker::createMaskImage): Creates the mask image, the context gets clipped with.
- rendering/RenderSVGResourceMasker.h: Added. (WebCore::MaskerData::MaskerData): (WebCore::RenderSVGResourceMasker::renderName): (WebCore::RenderSVGResourceMasker::maskUnits): Unit of mask for DRT. (WebCore::RenderSVGResourceMasker::maskContentUnits): Unit of childs from mask for DRT. (WebCore::RenderSVGResourceMasker::resourceType):
- rendering/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::destroy): Renderer gets destroyed, unregister it from it's resources.
- rendering/RenderSVGRoot.h:
- rendering/RenderSVGText.cpp: (WebCore::RenderSVGText::destroy): dito.
- rendering/RenderSVGText.h:
- rendering/RenderTreeAsText.cpp: (WebCore::write):
- rendering/SVGRenderSupport.cpp: (WebCore::SVGRenderBase::prepareToRenderSVGContent): (WebCore::SVGRenderBase::maskerBoundingBoxForRenderer): (WebCore::SVGRenderBase::deregisterFromResources): Unregister object from all it's resources after status changed.
- rendering/SVGRenderSupport.h: (WebCore::SVGRenderBase::toSVGRenderBase): (WebCore::SVGRenderBase::strokeBoundingBox): (WebCore::SVGRenderBase::markerBoundingBox):
- rendering/SVGRenderTreeAsText.cpp: Update TreeAsText to dump maskers correctly. (WebCore::operator<<): (WebCore::writeSVGResource): (WebCore::writeSVGContainer): (WebCore::writeSVGText): (WebCore::writeSVGInlineText): (WebCore::writeSVGImage): (WebCore::write): (WebCore::writeResourcesToObject):
- rendering/SVGRenderTreeAsText.h:
- svg/SVGMaskElement.cpp: Update Masker to use the new renderer. (WebCore::SVGMaskElement::svgAttributeChanged): (WebCore::SVGMaskElement::childrenChanged): (WebCore::SVGMaskElement::maskBoundingBox): (WebCore::SVGMaskElement::createRenderer):
- svg/SVGMaskElement.h:
- svg/SVGStyledElement.cpp: We need to tell the renderer to unregister object, after the status changed. (WebCore::SVGStyledElement::invalidateResources): (WebCore::SVGStyledElement::invalidateResourcesInAncestorChain):
- svg/SVGUnitTypes.h: Conversion of integer to SVGUnitType. (WebCore::toUnitType):
- svg/graphics/SVGResource.h: (WebCore::): (WebCore::SVGResource::isMarker):
- svg/graphics/SVGResourceMasker.cpp: Removed.
- svg/graphics/SVGResourceMasker.h: Removed.
2010-02-18 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
Move SVGResources to Renderers, starting with Masker
https://bugs.webkit.org/show_bug.cgi?id=35020
With the move from SVGResourceMasker to RenderSVGResourceMasker, I changed
the way DRT dumps resources. DRT is now able to dump multi-access
of resources.
Also the size of a Mask resource (depending of the object) and the access of
the resource (togeter with the resource name) is pointed out as an insertion
under the object.
- platform/mac/svg/W3C-SVG-1.1/masking-intro-01-f-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/masking-mask-01-b-expected.txt:
- platform/mac/svg/batik/masking/maskRegions-expected.txt:
- platform/mac/svg/css/circle-in-mask-with-shadow-expected.txt:
- platform/mac/svg/css/mask-with-shadow-expected.txt:
- platform/mac/svg/custom/empty-mask-expected.txt:
- platform/mac/svg/custom/grayscale-gradient-mask-expected.txt:
- platform/mac/svg/custom/js-late-mask-and-object-creation-expected.txt:
- platform/mac/svg/custom/js-late-mask-creation-expected.txt:
- platform/mac/svg/custom/mask-changes-expected.txt:
- platform/mac/svg/custom/mask-child-changes-expected.txt:
- platform/mac/svg/custom/mask-excessive-malloc-expected.txt:
- platform/mac/svg/custom/mask-inside-defs-expected.txt:
- platform/mac/svg/custom/mask-invalidation-expected.txt:
- platform/mac/svg/custom/mask-on-multiple-objects-expected.txt:
- platform/mac/svg/custom/mask-with-all-units-expected.txt:
- platform/mac/svg/custom/mask-with-default-value-expected.txt:
- platform/mac/svg/custom/resource-invalidate-on-target-update-expected.txt:
- platform/mac/svg/custom/visibility-override-mask-expected.txt:
- platform/mac/svg/filters/filter-clip-expected.txt:
- svg/custom/transformedMaskFails-expected.txt:
- 2:51 PM Changeset in webkit [54990] by
-
- 2 edits in trunk/WebCore
Allow creating/dropping virtual tables when the module is FTS2.
Reviewed by Dimitri Glazkov.
https://bugs.webkit.org/show_bug.cgi?id=34867
- storage/DatabaseAuthorizer.cpp:
(WebCore::DatabaseAuthorizer::createVTable):
(WebCore::DatabaseAuthorizer::dropVTable):
- 2:40 PM Changeset in webkit [54989] by
-
- 2 edits in trunk/WebCore
Not reviewed, Chromium build fix.
r54963 had a typo in the WebCore.gypi change.
https://bugs.webkit.org/show_bug.cgi?id=35003
- WebCore.gypi:
- 2:15 PM Changeset in webkit [54988] by
-
- 2 edits in trunk/JavaScriptCore
Fixed a portion of:
<rdar://problem/7165917> | https://bugs.webkit.org/show_bug.cgi?id=28676
Safari 4 does not release memory back to the operating system fast enough (28676)
Reviewed by Oliver Hunt.
This patch fixes a surprisingly common edge case in which the page heap
would have only one free span, but that span would be larger than the
minimum free size, so we would decide not to free it, even though it
could be as large as 100MB or more!
SunSpider reports no change on Mac or Windows.
- wtf/FastMalloc.cpp:
(WTF::TCMalloc_PageHeap::scavenge): Call shouldContinueScavenging() instead
of doing the math ourselves. Don't keep a local value for pagesDecommitted
because that lets free_committed_pages_ be wrong temporarily. Instead,
update free_committed_pages_ as we go. ASSERT that we aren't releasing
a span that has already been released, because we think this is impossible.
Finally, don't be afraid to release all free memory in the page heap when
scavenging. We only scavenge after 5 seconds of the application's working
set not growing, and we keep both thread caches and a central cache on
top of the page heap, so the extra free pages in the page heap were just
overkill.
- 2:08 PM Changeset in webkit [54987] by
-
- 2 edits in trunk/WebCore
2010-02-18 Vangelis Kokkevis <vangelis@chromium.org>
Reviewed by Simon Fraser.
Changing forward declaration of TimingFunction in GraphicsLayer.h from
class to struct to match its actual definition in TimingFunction.h
- platform/graphics/GraphicsLayer.h:
Change forward declaration from: class TimingFunction to:
struct TimingFunction
- 1:50 PM Changeset in webkit [54986] by
-
- 4 edits in trunk
2010-02-18 Noam Rosenthal <noam.rosenthal@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Minor improvement to hybrid QPixmap
https://bugs.webkit.org/show_bug.cgi?id=34507
Instead of having toHTMLImageElement which creates a new element,
assignToHTMLImageElement would set an existing HTML <img/> element to
contain the native QPixmap/QImge.
Also made some style fixes.
Additions to existing tests: see WebKit/qt/tests
- bridge/qt/qt_pixmapruntime.cpp: (JSC::Bindings::QtPixmapWidthField::valueFromInstance): style (JSC::Bindings::QtPixmapHeightField::valueFromInstance): style (JSC::Bindings::QtPixmapAssignToElementMethod::name): assignTo (JSC::Bindings::QtPixmapAssignToElementMethod::invoke): new function (JSC::Bindings::QtPixmapAssignToElementMethod::numParameters): 1 (JSC::Bindings::QtPixmapToDataUrlMethod::invoke): style (JSC::Bindings::QtPixmapToStringMethod::invoke): style (JSC::Bindings::QtPixmapInstance::invokeMethod): style (JSC::Bindings::QtPixmapClass::methodsNamed): new func, removed old (JSC::Bindings::QtPixmapInstance::getPropertyNames): ditto (JSC::Bindings::QtPixmapInstance::defaultValue): style (JSC::Bindings::QtPixmapInstance::valueOf): style (JSC::Bindings::QtPixmapInstance::toPixmap): style (JSC::Bindings::QtPixmapInstance::variantFromObject): style
2010-02-18 Noam Rosenthal <noam.rosenthal@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Minor improvement to hybrid QPixmap
https://bugs.webkit.org/show_bug.cgi?id=34507
- tests/hybridPixmap/test.html: use assignToHTMLImageElement on an existing element instead of toHTMLImageElement which creates a new one
- 1:15 PM Changeset in webkit [54985] by
-
- 2 edits in trunk/LayoutTests
2010-02-18 Gustavo Noronha Silva <Gustavo Noronha Silva>
[Qt][GTK] fast/xmlhttprequest/xmlhttprequest-nonexistent-file.html fails (DRT sideeffect)
https://bugs.webkit.org/show_bug.cgi?id=35086
Skip both new tests that fail. It may be a DRT problem, and the
file path that is reported in the error message also seems to
require tweaking.
- platform/gtk/Skipped:
- 1:07 PM Changeset in webkit [54984] by
-
- 2 edits in trunk/WebCore
Not reviewed, bustage fix.
An extraneous line in r54839 broke GIF animation.
- platform/image-decoders/gif/GIFImageReader.cpp:
(GIFImageReader::read):
- 1:03 PM Changeset in webkit [54983] by
-
- 2 edits in trunk/LayoutTests
2010-02-18 Gustavo Noronha Silva <Gustavo Noronha Silva>
[GTK] Fails fast/multicol/client-rects.html
https://bugs.webkit.org/show_bug.cgi?id=35127
Skip test that fails in GTK+ - trying to get bot green again.
- platform/gtk/Skipped:
- 12:55 PM Changeset in webkit [54982] by
-
- 3 edits1 copy3 adds in trunk
<rdar://problem/7650652> REGRESSION: Selection painting issue in bug review textbox
https://bugs.webkit.org/show_bug.cgi?id=34946
Reviewed by Simon Fraser.
WebCore:
Test: fast/repaint/selection-gap-overflow-scroll-2.html
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::paintSelection): localToContainerQuad() adjusts for
overflow scroll, but RenderLayer::addBlockSelectionGapsBounds() takes
non-scrolled coordinates, so account for that.
LayoutTests:
- fast/repaint/selection-gap-overflow-scroll-2.html: Copied from LayoutTests/fast/repaint/selection-gap-overflow-scroll.html.
- platform/mac/fast/repaint/selection-gap-overflow-scroll-2-expected.checksum: Added.
- platform/mac/fast/repaint/selection-gap-overflow-scroll-2-expected.png: Added.
- platform/mac/fast/repaint/selection-gap-overflow-scroll-2-expected.txt: Added.
- 12:52 PM Changeset in webkit [54981] by
-
- 10 edits in trunk
WebCore: Change the V8 and JSC SQLStatementErrorCallback to interpret
'undefined' return values as 'true', as required by the spec.
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=35048
- bindings/js/JSCustomSQLStatementErrorCallback.cpp:
(WebCore::JSCustomSQLStatementErrorCallback::handleEvent):
- bindings/v8/custom/V8CustomSQLStatementErrorCallback.cpp:
(WebCore::V8CustomSQLStatementErrorCallback::handleEvent):
- bindings/v8/custom/V8CustomVoidCallback.cpp:
(WebCore::invokeCallbackHelper):
(WebCore::invokeCallback):
(WebCore::invokeCallbackTreatUndefinedAsTrue):
- bindings/v8/custom/V8CustomVoidCallback.h:
LayoutTests: 'undefined' return values from statement error callbacks are not
treated as 'true'. Fix the tests that did not use this
assumption.
Reviewed by NOBODY Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=35048
- storage/database-lock-after-reload.html:
- storage/private-browsing-readonly.html:
- storage/statement-error-callback.html:
- storage/statement-error-callback-expected.txt:
- 11:38 AM Changeset in webkit [54980] by
-
- 12 edits4 adds in trunk
2010-02-17 Ojan Vafai <ojan@chromium.org>
Reviewed by Adam Barth.
keyboard selection sometimes moves the wrong end of the selection for Win/Linux
https://bugs.webkit.org/show_bug.cgi?id=35066
The changes to js-test-selection-shared.js are just to make the selection editing tests
easier to debug in the future.
The mac results for extend-after-mouse-selection.html contain a "FAIL" line. This is
a case where WebKit doesn't match TextEdit.
- editing/editing.js: (execMoveSelectionForwardByLineBoundaryCommand): (moveSelectionForwardByLineBoundaryCommand): (execExtendSelectionForwardByLineBoundaryCommand): (extendSelectionForwardByLineBoundaryCommand): (execExtendSelectionBackwardByLineBoundaryCommand): (extendSelectionBackwardByLineBoundaryCommand): (execMoveSelectionBackwardByLineBoundaryCommand): (moveSelectionBackwardByLineBoundaryCommand):
- editing/selection/extend-after-mouse-selection.html: Added.
- editing/selection/move-begin-end-expected.txt:
- editing/selection/move-begin-end.html:
- editing/selection/resources/js-test-selection-shared.js: (objectAsString): (assertSelectionAt):
- platform/mac/editing/selection/click-in-margins-inside-editable-div-expected.txt:
- platform/mac/editing/selection/click-in-padding-with-multiple-line-boxes-expected.txt:
- platform/mac/editing/selection/extend-after-mouse-selection-expected.txt: Added.
- platform/win/editing/selection/click-in-margins-inside-editable-div-expected.txt:
- platform/win/editing/selection/click-in-padding-with-multiple-line-boxes-expected.txt:
- platform/win/editing/selection/extend-after-mouse-selection-expected.txt: Added.
- platform/win/editing/selection/extend-selection-expected.txt: Added.
2010-02-17 Ojan Vafai <ojan@chromium.org>
Reviewed by Adam Barth.
keyboard selection sometimes moves the wrong end of the selection for Win/Linux
https://bugs.webkit.org/show_bug.cgi?id=35066
On Windows/Linux keyboard based selections should always move the same
end of the seleciton. On Mac, lineboundary and documentboundary changes
move different ends of the selection depending on which direction your
extending.
Test: editing/selection/extend-after-mouse-selection.html
- editing/SelectionController.cpp: (WebCore::SelectionController::positionForPlatform): (WebCore::SelectionController::startForPlatform): (WebCore::SelectionController::endForPlatform): (WebCore::SelectionController::modifyExtendingRight): (WebCore::SelectionController::modifyExtendingForward): (WebCore::SelectionController::modifyMovingForward): (WebCore::SelectionController::modifyExtendingBackward): (WebCore::SelectionController::modifyMovingBackward):
- editing/SelectionController.h:
- 11:36 AM Changeset in webkit [54979] by
-
- 3 edits in trunk/WebCore
Add "with" to the list of keywords to syntax highlight.
Reviewed by Pavel Feldman.
- inspector/front-end/SourceJavaScriptTokenizer.js:
(WebInspector.SourceJavaScriptTokenizer): Add "width" to _keywords.
- inspector/front-end/SourceJavaScriptTokenizer.re2js:
(WebInspector.SourceJavaScriptTokenizer): Ditto.
- 11:35 AM Changeset in webkit [54978] by
-
- 7 edits in trunk/WebCore
Rework PNG-in-ICO decoding to copy the decoded framebuffer into the ICO
decoder, making the logic less crazy and more like the other decoders.
https://bugs.webkit.org/show_bug.cgi?id=28751
Reviewed by Adam Barth.
- platform/image-decoders/ImageDecoder.cpp:
(WebCore::RGBA32Buffer::operator=):
- platform/image-decoders/ImageDecoder.h:
(WebCore::RGBA32Buffer::RGBA32Buffer):
- platform/image-decoders/ico/ICOImageDecoder.cpp:
(WebCore::ICOImageDecoder::frameBufferAtIndex):
(WebCore::ICOImageDecoder::decodeAtIndex):
- platform/image-decoders/ico/ICOImageDecoder.h:
- platform/image-decoders/qt/RGBA32BufferQt.cpp:
(WebCore::RGBA32Buffer::operator=):
- platform/image-decoders/skia/ImageDecoderSkia.cpp:
(WebCore::RGBA32Buffer::operator=):
- 11:19 AM CommitQueue edited by
- (diff)
- 11:19 AM CommitQueue edited by
- (diff)
- 11:14 AM CommitQueue edited by
- (diff)
- 11:13 AM CommitQueue edited by
- (diff)
- 11:11 AM CommitQueue edited by
- (diff)
- 11:10 AM CommitQueue edited by
- (diff)
- 11:08 AM Changeset in webkit [54977] by
-
- 3 edits in trunk/LayoutTests
2010-02-18 Nate Chapin <Nate Chapin>
Unreviewed, build fix.
Provide good expected results for fast/dom/Window/window-event-override-no-crash.html.
- 11:05 AM Changeset in webkit [54976] by
-
- 1 edit in trunk/WebKitLibraries/win/lib/WebKitSystemInterface_debug.lib
Windows build fix.
- 10:59 AM Changeset in webkit [54975] by
-
- 2 edits in trunk/LayoutTests
2010-02-18 Gustavo Noronha Silva <Gustavo Noronha Silva>
[GTK][Qt] Fails glyph reordering test fast/text/glyph-reordering.html
https://bugs.webkit.org/show_bug.cgi?id=34918
Unskipping that now passes, after r54912.
- platform/gtk/Skipped:
- 10:53 AM Changeset in webkit [54974] by
-
- 4 edits in trunk/WebCore
2010-02-18 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: multiple popovers on screen at the same time.
- inspector/front-end/Popover.js: (WebInspector.Popover.prototype.show): (WebInspector.Popover.prototype.hide):
- inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype._showPopup):
- 10:45 AM Changeset in webkit [54973] by
-
- 6 edits in trunk/WebCore
2010-02-18 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: Expand Object.proto properly.
- inspector/front-end/EventListenersSidebarPane.js:
- inspector/front-end/InjectedScript.js: (injectedScriptConstructor):
- inspector/front-end/ObjectProxy.js: (WebInspector.ObjectProxy):
- inspector/front-end/PropertiesSidebarPane.js: (WebInspector.PropertiesSidebarPane.prototype.update.callback):
- inspector/front-end/inspector.js: (WebInspector.log.logMessage): (WebInspector.log):
- 10:40 AM Changeset in webkit [54972] by
-
- 4 edits in trunk/WebCore
2010-02-18 Nate Chapin <Nate Chapin>
Reviewed by Adam Barth.
[V8] Merge the DOMWindow and WorkerContext object wrapping code paths,
and use a faster method of disambiguating between the types of contexts.
- bindings/scripts/CodeGeneratorV8.pm: Remove logic determining whether we need to
handle the WorkerContext case.
- bindings/v8/V8DOMWrapper.cpp: (WebCore::globalObjectPrototypeIsDOMWindow): (WebCore::V8DOMWrapper::instantiateV8Object): Merge instantiateV8Object paths.
- bindings/v8/V8DOMWrapper.h:
- 10:25 AM Changeset in webkit [54971] by
-
- 3 edits in trunk/WebCore
2010-02-18 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
Remove some duplication between PluginView and Widget methods, and
move the setSelfVisible calls to the parent class.
- platform/gtk/WidgetGtk.cpp: (WebCore::Widget::show): (WebCore::Widget::hide):
- plugins/gtk/PluginViewGtk.cpp: (WebCore::PluginView::setFocus): (WebCore::PluginView::show): (WebCore::PluginView::hide):
- 9:51 AM Changeset in webkit [54970] by
-
- 3 edits in trunk/WebCore
2010-02-18 Simon Fraser <Simon Fraser>
Reviewed by Darin Adler.
<rdar://problem/7655195> Switch Leopard back to using CGShading to avoid CGGradient leaks
Define USE_CG_SHADING on for Tiger and Leopard, and use it to toggle the methods
used for Core Graphics gradient drawing.
- platform/graphics/Gradient.h:
- platform/graphics/cg/GradientCG.cpp: (WebCore::Gradient::platformDestroy): (WebCore::Gradient::paint):
- 9:36 AM Changeset in webkit [54969] by
-
- 2 edits in trunk/WebCore
2010-02-18 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: on-hover evaluation renders nodes and arrays as strings.
- inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype._showPopup.showObjectPopup):
- 9:32 AM Changeset in webkit [54968] by
-
- 2 edits in trunk/WebKit/chromium
2010-02-18 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Don't truncate long lines when evaluating expressions on a breakpoint.
- src/js/DebuggerAgent.js:
- 9:31 AM Changeset in webkit [54967] by
-
- 1 edit1 add in trunk/WebKit/gtk/po
2010-02-18 A S Alam <amanpreet.alam@gmail.com>
Punjabi translation.
- pa.po: Added.
- 9:13 AM Changeset in webkit [54966] by
-
- 13 edits2 adds in trunk
Particularly constructed WebFrames can try to access a null HistoryItem
<rdar://problem/7638892> and https://bugs.webkit.org/show_bug.cgi?id=35063
Reviewed by Sam Weinig.
WebCore:
Test: fast/loader/api-test-new-window-data-load-base-url.html
- loader/HistoryController.cpp:
(WebCore::HistoryController::updateBackForwardListForFragmentScroll): We have a known case where a fragment scroll
might take place with a null m_currentItem. updateBackForwardListClippedAtTarget() will either move m_currentItem
to m_previousItem then create a new m_currentItem... or it will do nothing. So we either have both an m_currentItem
and m_previousItem, or we have neither. In the case where we have no m_previousItem, return early.
WebKitTools:
Add the specific ability to test this API pattern.
For now only on Mac, perhaps on the main Windows port later, probably not relevant for other ports.
- DumpRenderTree/LayoutTestController.cpp:
(apiTestNewWindowDataLoadBaseURLCallback):
(LayoutTestController::staticFunctions):
- DumpRenderTree/LayoutTestController.h:
- DumpRenderTree/mac/LayoutTestControllerMac.mm:
(-[APITestDelegate initWithCompletionCondition:]):
(-[APITestDelegate webView:didFailLoadWithError:forFrame:]):
(-[APITestDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
(-[APITestDelegate webView:didFinishLoadForFrame:]):
(LayoutTestController::apiTestNewWindowDataLoadBaseURL): Create a WebView, do a loadData: in its
mainFrame, and synchronously wait for main load completion.
- DumpRenderTree/win/LayoutTestControllerWin.cpp:
(LayoutTestController::apiTestNewWindowDataLoadBaseURL):
- DumpRenderTree/wx/LayoutTestControllerWx.cpp:
(LayoutTestController::apiTestNewWindowDataLoadBaseURL):
- DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
(LayoutTestController::apiTestNewWindowDataLoadBaseURL):
LayoutTests:
- fast/loader/api-test-new-window-data-load-base-url-expected.txt: Added.
- fast/loader/api-test-new-window-data-load-base-url.html: Added.
- platform/gtk/Skipped:
- platform/qt/Skipped:
- platform/win/Skipped:
- 9:08 AM Changeset in webkit [54965] by
-
- 1 edit2 adds in trunk/LayoutTests
2010-02-18 Nate Chapin <Nate Chapin>
Reviewed by Eric Seidel.
Actually submitting test for https://bugs.webkit.org/show_bug.cgi?id=34899 this time.
- fast/dom/Window/window-event-override-no-crash-expected.txt: Added.
- fast/dom/Window/window-event-override-no-crash.html: Added.
- 9:04 AM Changeset in webkit [54964] by
-
- 5 edits in trunk
2010-02-18 Nate Chapin <Nate Chapin>
Reviewed by Eric Seidel.
[V8] Correctly handle the case where the event field on the
global object is a v8::Object, but not a DOM wrapper.
Test: fast/dom/Window/window-event-override-no-crash.html
- bindings/v8/ScriptController.cpp: (WebCore::ScriptController::processingUserGesture):
- bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::isValidDOMObject): (WebCore::V8DOMWrapper::isWrapperOfType):
- bindings/v8/V8DOMWrapper.h:
- 8:56 AM Changeset in webkit [54963] by
-
- 2 edits in trunk/WebCore
2010-02-18 Pavel Feldman <pfeldman@chromium.org>
Not reviewed, Qt build fix.
- inspector/front-end/WebKit.qrc:
- 8:12 AM Changeset in webkit [54962] by
-
- 11 edits13 adds1 delete in trunk/WebCore
2010-02-18 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: Implement evaluate-on-hover for scripts panel.
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- inspector/front-end/Images/gearButtonGlyph.png: Added.
- inspector/front-end/Images/popoverArrows.png: Added.
- inspector/front-end/Images/popoverBackground.png: Added.
- inspector/front-end/Images/thumbActiveHoriz.png: Added.
- inspector/front-end/Images/thumbActiveVert.png: Added.
- inspector/front-end/Images/thumbHoriz.png: Added.
- inspector/front-end/Images/thumbHoverHoriz.png: Added.
- inspector/front-end/Images/thumbHoverVert.png: Added.
- inspector/front-end/Images/thumbVert.png: Added.
- inspector/front-end/Images/trackHoriz.png: Added.
- inspector/front-end/Images/trackVert.png: Added.
- inspector/front-end/Popup.js: (WebInspector.Popup): (WebInspector.Popup.prototype.show): (WebInspector.Popup.prototype.hide): (WebInspector.Popup.prototype._positionElement):
- inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype._createViewerIfNeeded): (WebInspector.SourceFrame.prototype._scroll): (WebInspector.SourceFrame.prototype._mouseDown): (WebInspector.SourceFrame.prototype._mouseUp): (WebInspector.SourceFrame.prototype._mouseMove): (WebInspector.SourceFrame.prototype._mouseOut): (WebInspector.SourceFrame.prototype._resetHoverTimer): (WebInspector.SourceFrame.prototype._hidePopup): (WebInspector.SourceFrame.prototype._mouseHover): (WebInspector.SourceFrame.prototype._showPopup.showTextPopup): (WebInspector.SourceFrame.prototype._showPopup.showObjectPopup): (WebInspector.SourceFrame.prototype._showPopup.evaluateCallback): (WebInspector.SourceFrame.prototype._showPopup): (WebInspector.HoverPropertiesSection): (WebInspector.HoverPropertiesSection.prototype.update):
- inspector/front-end/TextEditorHighlighter.js: (WebInspector.TextEditorHighlighter): (WebInspector.TextEditorHighlighter.prototype._lex):
- inspector/front-end/TextViewer.js: (WebInspector.TextViewer.prototype._paintLine):
- inspector/front-end/WebKit.qrc:
- inspector/front-end/inspector.css:
- inspector/front-end/inspector.html:
- inspector/front-end/inspectorSyntaxHighlight.css:
- inspector/front-end/popover.css: Added.
- 8:03 AM Changeset in webkit [54961] by
-
- 2 edits in trunk/LayoutTests
Rubber-stamped by Kenneth Rohde Christiansen.
[Qt] Skip the following tests because of missing eventSender.textZoomIn():
svg/zoom/text/absolute-sized-document-no-scrollbars.svg
svg/zoom/text/absolute-sized-document-scrollbars.svg
svg/zoom/text/relative-sized-document-scrollbars.svg
svg/zoom/text/zoom-foreignObject.svg
svg/zoom/text/zoom-hixie-mixed-008.xml
svg/zoom/text/zoom-hixie-mixed-009.xml
svg/zoom/text/zoom-hixie-rendering-model-004.xhtml
svg/zoom/text/zoom-svg-float-border-padding.xml
- platform/qt/Skipped:
- 7:55 AM UsingGitWithWebKit edited by
- (diff)
- 7:54 AM UsingGitWithWebKit edited by
- (diff)
- 7:51 AM Changeset in webkit [54960] by
-
- 4 edits in trunk
Teach resolve-ChangeLogs to act as a merge-driver for Git
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=28721
To enable automatic merging of ChangeLog files, use the following command:
git config merge.changelog.driver "resolve-ChangeLogs --merge-driver %O %A %B"
The driver always works in "downstream" merge mode, meaning
it will always put the user's changelog entries on top.
- Scripts/resolve-ChangeLogs:
- .gitattributes: Add instruction to use merge-driver for ChangeLogs
- 6:27 AM Changeset in webkit [54959] by
-
- 4 edits in trunk/WebKit/gtk
2010-02-18 Diego Escalante Urrelo <descalante@igalia.com>
Reviewed by Gustavo Noronha Silva.
[GTK] WebKitDownload documentation is incomplete
https://bugs.webkit.org/show_bug.cgi?id=35018
Concretely the error signal was undocumented. Also two relevant enums
were not included.
- docs/webkitgtk-sections.txt:
- docs/webkitgtk.types:
- webkit/webkitdownload.cpp: (webkit_download_class_init):
- 6:22 AM Changeset in webkit [54958] by
-
- 2 edits in trunk/WebCore
2010-02-18 Ben Murdoch <benm@google.com>
Reviewed by Jeremy Orlow.
[v8] Complete upstreaming of V8 Touch Event bindings
https://bugs.webkit.org/show_bug.cgi?id=35094
No new tests required.
- bindings/v8/V8Index.cpp: Add generated touch event headers.
- 6:12 AM Changeset in webkit [54957] by
-
- 3 edits in trunk/WebCore
2010-02-18 Steve Block <steveblock@google.com>
Reviewed by Jeremy Orlow.
Updates Android V8 build to use DerivedSourcesAllInOne.cpp
https://bugs.webkit.org/show_bug.cgi?id=35083
No new tests, build fix only.
- Android.derived.v8bindings.mk:
- Android.v8bindings.mk:
- 5:32 AM Changeset in webkit [54956] by
-
- 2 edits1 add in trunk/WebKitTools
2009-12-05 Gustavo Noronha Silva <Gustavo Noronha Silva>
Reviewed by Eric Seidel.
Enable running of GTK+ API tests.
- BuildSlaveSupport/build.webkit.org-config/master.cfg:
- Scripts/run-gtk-tests: Added.
- 5:27 AM Changeset in webkit [54955] by
-
- 4 edits in trunk
2010-02-18 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Xan Lopez.
fast/frames/iframe-reparenting.html crashing on GTK Debug bots
https://bugs.webkit.org/show_bug.cgi?id=35081
Check that the client is alive after every call to it, since any
of them could cause the load to be cancelled, and the client to go
away.
This is much better than protecting a specific subclass of
ResourceHandleClient (ResourceLoader), which makes us fail when
any other client is used.
Test: fast/frames/iframe-reparenting.html
- platform/network/soup/ResourceHandleSoup.cpp: (WebCore::parseDataUrl):
- 4:00 AM Changeset in webkit [54954] by
-
- 2 edits in trunk/LayoutTests
[Qt] fast/xmlhttprequest/xmlhttprequest-nonexistent-file.html fails (DRT sideeffect)
https://bugs.webkit.org/show_bug.cgi?id=35086
fast/xmlhttprequest/xmlhttprequest-no-file-access.html cause
this fail indirectly, but both of them pass in separated DRT.
- platform/qt/Skipped: fast/xmlhttprequest/xmlhttprequest-no-file-access.html
skipped until fix to make buildbot happy.
- 3:46 AM Changeset in webkit [54953] by
-
- 1 edit1 add in trunk/LayoutTests
2010-02-18 Philippe Normand <pnormand@igalia.com>
Not reviewed, adding a GTK layout test result for a new test
added in r54926.
- platform/gtk/fast/css/first-letter-first-line-hover-expected.txt: Added.
- 3:37 AM Changeset in webkit [54952] by
-
- 2 edits in trunk/LayoutTests
2010-02-18 Philippe Normand <pnormand@igalia.com>
Rubber-stamped by Xan Lopez.
plugins/iframe-shims.html crashing on GTK Debug bots
https://bugs.webkit.org/show_bug.cgi?id=35085
- platform/gtk/Skipped: Skip crashing tests.
- 2:29 AM Changeset in webkit [54951] by
-
- 2 edits in trunk/LayoutTests
2010-02-18 Philippe Normand <pnormand@igalia.com>
Rubber-stamped by Xan Lopez.
fast/frames/iframe-reparenting.html crashing on GTK Debug bots
https://bugs.webkit.org/show_bug.cgi?id=35081
- platform/gtk/Skipped: Skip crashing test.
- 2:21 AM Changeset in webkit [54950] by
-
- 9 edits in trunk/WebCore
[v8] [Android] V8 bindings for touch events are missing.
https://bugs.webkit.org/show_bug.cgi?id=33795
Reviewed by Nate Chapin.
No new tests as this just enables touch events in V8. Existing touch tests suffice.
- WebCore.gypi: Add Touch idl files.
- bindings/scripts/CodeGeneratorV8.pm: Add TouchList to typeCanFailConversion map.
- bindings/v8/DOMObjectsInclude.h: Add touch headers.
- bindings/v8/DerivedSourcesAllInOne.cpp: Add touch generated bindings.
- bindings/v8/V8Index.h: Add touch DOM object types.
- bindings/v8/custom/V8EventCustom.cpp: Add conversion of event to touch event.
- Android.derived.jscbindings.mk: Add the touch derived sources to the makefile.
- Android.derived.v8bindings.mk: Add the touch derived sources to the makefile.
- 2:07 AM Changeset in webkit [54949] by
-
- 2 edits in trunk/LayoutTests
2010-02-18 Philippe Normand <pnormand@igalia.com>
Rubber-stamped by Xan Lopez.
fast/css/font-face-opentype.html crashing on GTK bots
https://bugs.webkit.org/show_bug.cgi?id=35080
- platform/gtk/Skipped: Skip crashing test.
- 1:27 AM Changeset in webkit [54948] by
-
- 3 edits in trunk/WebKit/chromium
2010-02-18 Jay Campan <jcampan@google.com>
Reviewed by Adam Barth.
Exposing the title in WebDocument.
- public/WebDocument.h:
- src/WebDocument.cpp: (WebKit::WebDocument::title):
- 1:17 AM Changeset in webkit [54947] by
-
- 2 edits in trunk/WebKitTools
2010-02-18 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Adam Barth.
debug-safari doesn't pass --debug option to gdb-safari on MacOSX
https://bugs.webkit.org/show_bug.cgi?id=34411
- Scripts/webkitdirs.pm:
- 1:10 AM Changeset in webkit [54946] by
-
- 2 edits in trunk/WebCore
2010-02-18 William Chan <willchan@chromium.org>
Reviewed by Adam Barth.
https://bugs.webkit.org/show_bug.cgi?id=35071
Disable loader limiting of requests per host for the chromium port.
No tests because we're only changing a constant.
- platform/network/chromium/ResourceRequest.cpp: (WebCore::initializeMaximumHTTPConnectionCountPerHost):
- 12:54 AM Changeset in webkit [54945] by
-
- 4 edits in trunk/WebKitTools
2010-02-18 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
run-chromium-webkit-tests --platform=mac-leopard needs to run build-dumprendertree
https://bugs.webkit.org/show_bug.cgi?id=35053
- Scripts/webkitpy/layout_tests/port/base.py: Add script_path() function for finding scripts.
- Scripts/webkitpy/layout_tests/port/chromium.py: Remove unused argument.
- Scripts/webkitpy/layout_tests/port/mac.py:
- Make sure that calling webkit-build-directory works even if Scripts/ is not in the user's path.
- Call build-dumprendertree (and make sure it succeeds) before running the tests.
- 12:38 AM Changeset in webkit [54944] by
-
- 1 edit3 adds in trunk/LayoutTests
2010-02-18 Chris Evans <cevans@chromium.org>
Reviewed by Adam Barth.
Add the promised test for the unique file:// origins support.
See https://bugs.webkit.org/show_bug.cgi?id=34778 for more details.
- fast/xmlhttprequest/xmlhttprequest-no-file-access.html: Added.
- fast/xmlhttprequest/resources/xmlhttprequest-no-file-access-real.html: Added.
- fast/xmlhttprequest/xmlhttprequest-no-file-access-expected.txt: Added.
- 12:36 AM Changeset in webkit [54943] by
-
- 9 edits in trunk
WebKit on Windows needs a mechanism to listen for WM_SETTINGCHANGED messages
https://bugs.webkit.org/show_bug.cgi?id=35076
Reviewed by Dan Bernstein.
WebKit/win:
- WebKit.vcproj/WebKit.def: Added WebKitSystemParameterChanged.
- WebKit.vcproj/WebKit_debug.def: Added WebKitSystemParameterChanged.
- WebKitGraphics.cpp:
(WebKitSystemParameterChanged): Call through to wkSystemFontSmoothingChanged for font smoothing changes.
- WebKitGraphics.h: Added WebKitSystemParameterChanged.
WebKitLibraries:
- win/include/WebKitSystemInterface/WebKitSystemInterface.h:
- win/lib/WebKitSystemInterface.lib: Updated to add wkSystemFontSmoothingChanged.
- win/lib/WebKitSystemInterface_debug.lib: Updated to add wkSystemFontSmoothingChanged.
- 12:17 AM Changeset in webkit [54942] by
-
- 6 edits in trunk/WebKitTools
2010-02-16 Chris Jerdonek <Chris Jerdonek>
Reviewed by Shinichiro Hamaji.
Refactored check-webkit-style's ProcessorOptions class into two
classes. This revision contains no new functionality.
Divided the ProcessorOptions class into a CommandOptionValues
class (the result of parsing the command-line options) and
a StyleCheckerConfiguration class (which configures the main
StyleChecker).
- Scripts/check-webkit-style:
- Updated main() to convert the parsed command option values to a StyleCheckConfiguration instance prior to constructing a StyleChecker.
- Scripts/webkitpy/style/checker.py:
- Added check_webkit_style_configuration() to convert a CommandOptionValues instance into a StyleCheckerConfiguration instance.
- Renamed the ProcessorOptions class to CommandOptionValues.
- In the CommandOptionValues class--
- Replaced the filter_configuration attribute with the simpler filter_rules attribute.
- Removed the max_reports_per_error attribute.
- Moved the is_reportable() method to the new StyleCheckerConfiguration class.
- Removed the base_filter_rules attribute from the DefaultCommandOptionValues class.
- In the ArgumentParser class--
- Added base_filter_rules to the constructor.
- Changed the parse() method to return a CommandOptionValues instance instead of a ProcessorOptions instance.
- Created a StyleCheckerConfiguration class.
- Added the data attributes max_reports_per_category, stderr_write, and verbosity.
- Added is_reportable() (moved from the ProcessorOptions class) and write_style_error() (moved from the DefaultStyleErrorHandler class).
- In the StyleChecker class--
- Replaced the ProcessorOptions options attribute with the StyleCheckerConfiguration _configuration attribute.
- Removed the _stderr_write attribute.
- Scripts/webkitpy/style/checker_unittest.py:
- Updated the existing unit test classes as necessary.
- Added a StyleCheckerConfigurationTest class.
- Scripts/webkitpy/style/error_handlers.py:
- Updated the DefaultStyleErrorHandler class to accept a StyleCheckerConfiguration instance instead of a ProcessorOptions instance and an stderr_write method.
- Scripts/webkitpy/style/error_handlers_unittest.py:
- Updated the unit test classes as necessary.
- Scripts/webkitpy/style/filter.py:
- Addressed the FIXME in the FilterConfiguration class to change the user_rules attribute to _user_rules (since it is now accessed only internally).
- Scripts/webkitpy/style/filter_unittest.py:
- Updated to reflect the change from user_rules to _user_rules.
- 12:17 AM Changeset in webkit [54941] by
-
- 2 edits1 add in trunk/LayoutTests
2010-02-18 Tony Chang <tony@chromium.org>
Not reviewed, adding a QT layout test result for a new test
added in r54932.
- platform/qt/editing/pasteboard/page-zoom-expected.txt: Copied from LayoutTests/platform/gtk/editing/pasteboard/page-zoom-expected.txt.
- 12:06 AM Changeset in webkit [54940] by
-
- 8 edits in trunk/WebCore
2010-02-18 Xan Lopez <xlopez@igalia.com>
Reviewed by Eric Seidel.
[Linux] Webkit incompatible with Java plugins
https://bugs.webkit.org/show_bug.cgi?id=24912
The NP Version supported by WebKit is at the moment hardcoded in
PluginPackage.cpp (to 24), but not all backends actually implement
the methods needed to claim this. Introduce a new method to be
implemented by each backend where the maximum supported version
can be specified, and set the GTK+ port NPVersion to 19. This
fixes an instantaneous crasher in the Sun Java NPAPI plugin.
- plugins/PluginPackage.cpp: (WebCore::PluginPackage::initializeBrowserFuncs):
- plugins/PluginPackage.h:
- plugins/gtk/PluginPackageGtk.cpp: (WebCore::PluginPackage::NPVersion):
- plugins/mac/PluginPackageMac.cpp: (WebCore::PluginPackage::NPVersion):
- plugins/qt/PluginPackageQt.cpp: (WebCore::PluginPackage::NPVersion):
- plugins/symbian/PluginPackageSymbian.cpp: (WebCore::PluginPackage::NPVersion):
- plugins/win/PluginPackageWin.cpp: (WebCore::PluginPackage::NPVersion):
- 12:04 AM Changeset in webkit [54939] by
-
- 2 edits in trunk/LayoutTests
[Qt] editing/pasteboard/page-zoom.html fails
https://bugs.webkit.org/show_bug.cgi?id=35077
- platform/qt/Skipped: editing/pasteboard/page-zoom.html skipped until fix.
Feb 17, 2010:
- 11:55 PM Changeset in webkit [54938] by
-
- 34 edits7 adds in trunk
When a live iframe element is moved between pages, it still depends on the old page.
https://bugs.webkit.org/show_bug.cgi?id=34382
Reviewed by David Levin, Darin Fisher, Simon Hausmann.
WebCore:
Test: fast/frames/iframe-reparenting-new-page.html
- html/HTMLFrameElementBase.cpp:
(WebCore::HTMLFrameElementBase::setName):
Move the code setting the frame name into a separate function.
(WebCore::HTMLFrameElementBase::setNameAndOpenURL):
(WebCore::HTMLFrameElementBase::updateOnReparenting):
Called on the frame that was just re-parented and inserted into another Document.
Simply invoke Frame::transferChildFrameToNewDocument(...);
(WebCore::HTMLFrameElementBase::insertedIntoDocument):
- html/HTMLFrameElementBase.h:
- html/HTMLFrameOwnerElement.h:
(WebCore::HTMLFrameOwnerElement::setName):
Make this a virtual function, to be able to reach it via Frame::m_ownerElement.
- loader/EmptyClients.h:
(WebCore::EmptyFrameLoaderClient::adoptFrame):
- loader/FrameLoaderClient.h:
Add a new method, didTransferChildFrameToNewDocument().
It compliments createFrame() in that a frame which was re-parented
in DOM and potentially changes Page, should notify the WebKit
implementation about potential ownership change.
Many embedders assume that Page owns all the Frames, or at least
all Frames are destroyed before 'their' Page is destroyed. Obviously, if Frame
can be transferred to another Page, the embedders should be notified.
- page/Frame.cpp:
(WebCore::Frame::transferChildFrameToNewDocument):
Added, makes actual adjustments for Frame - resets the Page,
updates the frame tree and frame name, calls to FrameLoaderClient
to update external objects and recurses into children.
Can only be used on child frames.
- page/Frame.h:
WebKit/chromium:
- src/FrameLoaderClientImpl.cpp:
(WebKit::FrameLoaderClientImpl::detachedFromParent3):
(WebKit::FrameLoaderClientImpl::didTransferChildFrameToNewDocument):
Since Chromium's WebFrameClient is destroyed once a window is closed,
if Frame moves between Pages, the client of corresponding WebFrame
should be replaced as well.
- src/FrameLoaderClientImpl.h:
- src/WebFrameImpl.h:
(WebKit::WebFrameImpl::setClient):
WebKit/gtk:
- WebCoreSupport/FrameLoaderClientGtk.cpp:
(WebKit::FrameLoaderClient::didTransferChildFrameToNewDocument):
Added empty implementation of a new virtual method.
- WebCoreSupport/FrameLoaderClientGtk.h:
WebKit/haiku:
- WebCoreSupport/FrameLoaderClientHaiku.cpp:
(WebCore::FrameLoaderClientHaiku::didTransferChildFrameToNewDocument):
Added empty implementation of a new virtual method.
- WebCoreSupport/FrameLoaderClientHaiku.h:
WebKit/mac:
- WebCoreSupport/WebFrameLoaderClient.h:
- WebCoreSupport/WebFrameLoaderClient.mm:
Added empty implementation of a new virtual method.
(WebFrameLoaderClient::didTransferChildFrameToNewDocument):
WebKit/qt:
- Api/qwebframe_p.h:
(QWebFramePrivate::setPage): Added.
- WebCoreSupport/FrameLoaderClientQt.cpp:
(WebCore::FrameLoaderClientQt::didTransferChildFrameToNewDocument):
The QWebFrame caches a QWebPage which should be replaced when Frame is re-parented.
Also, the QWebFrame is a child (in QT terms) of QWebPage - so update that relationship as well.
Emit a signal that QWebFrame moved to a different QWebPage.
- WebCoreSupport/FrameLoaderClientQt.h:
WebKit/win:
- WebCoreSupport/WebFrameLoaderClient.cpp:
(WebFrameLoaderClient::didTransferChildFrameToNewDocument):
Added empty implementation of a new virtual method.
- WebCoreSupport/WebFrameLoaderClient.h:
WebKit/wx:
- WebKitSupport/FrameLoaderClientWx.cpp:
(WebCore::FrameLoaderClientWx::didTransferChildFrameToNewDocument):
Added empty implementation of a new virtual method.
- WebKitSupport/FrameLoaderClientWx.h:
LayoutTests:
- fast/frames/iframe-reparenting-new-page-expected.txt: Added.
- fast/frames/iframe-reparenting-new-page.html: Added.
- fast/frames/resources/iframe-reparenting-new-page-1.html: Added.
- fast/frames/resources/iframe-reparenting-new-page-2.html: Added.
- fast/frames/resources/iframe-reparenting-new-page-iframe.html: Added.
- fast/frames/script-tests/TEMPLATE.html: Copied from LayoutTests/fast/canvas/script-tests/TEMPLATE.html.
- fast/frames/script-tests/iframe-reparenting-new-page.js: Added.
- 11:49 PM Changeset in webkit [54937] by
-
- 2 edits in trunk/LayoutTests
[Qt] DRT: Get total number of pages to be printed
https://bugs.webkit.org/show_bug.cgi?id=34955
Fix landed in r54902, so we can unskip the test.
- platform/qt/Skipped: printing/numberOfPages.html unskipped.
- 11:41 PM Changeset in webkit [54936] by
-
- 2 edits in trunk/LayoutTests
[Qt] Fails glyph reordering test fast/text/glyph-reordering.html
https://bugs.webkit.org/show_bug.cgi?id=34918
Fix landed in r54912, so we can unskip the test.
- platform/qt/Skipped: fast/text/glyph-reordering.html unskipped.
- 11:30 PM Changeset in webkit [54935] by
-
- 1 edit1 add in trunk/LayoutTests
2010-02-17 Tony Chang <tony@chromium.org>
Not reviewed, adding a GTK+ layout test result for a new test
added in r54932.
- platform/gtk/editing/pasteboard/page-zoom-expected.txt: Added.
- 11:29 PM Changeset in webkit [54934] by
-
- 8 edits in trunk/WebKitTools
Refactored check-webkit-style's ProcessorOptions class into two
classes. This revision contains no new functionality.
Reviewed by Shinichiro Hamaji.
https://bugs.webkit.org/show_bug.cgi?id=34674
Divided the ProcessorOptions class into a CommandOptionValues
class (the result of parsing the command-line options) and
a StyleCheckerConfiguration class (which configures the main
StyleChecker).
- Scripts/check-webkit-style:
- Updated main() to convert the parsed command option values to a StyleCheckConfiguration instance prior to constructing a StyleChecker.
- Scripts/webkitpy/style/checker.py:
- Added check_webkit_style_configuration() to convert a CommandOptionValues instance into a StyleCheckerConfiguration instance.
- Renamed the ProcessorOptions class to CommandOptionValues.
- In the CommandOptionValues class--
- Replaced the filter_configuration attribute with the simpler filter_rules attribute.
- Removed the max_reports_per_error attribute.
- Moved the is_reportable() method to the new StyleCheckerConfiguration class.
- Removed the base_filter_rules attribute from the DefaultCommandOptionValues class.
- In the ArgumentParser class--
- Added base_filter_rules to the constructor.
- Changed the parse() method to return a CommandOptionValues instance instead of a ProcessorOptions instance.
- Created a StyleCheckerConfiguration class.
- Added the data attributes max_reports_per_category, stderr_write, and verbosity.
- Added is_reportable() (moved from the ProcessorOptions class) and write_style_error() (moved from the DefaultStyleErrorHandler class).
- In the StyleChecker class--
- Replaced the ProcessorOptions options attribute with the StyleCheckerConfiguration _configuration attribute.
- Removed the _stderr_write attribute.
- Scripts/webkitpy/style/checker_unittest.py:
- Updated the existing unit test classes as necessary.
- Added a StyleCheckerConfigurationTest class.
- Scripts/webkitpy/style/error_handlers.py:
- Updated the DefaultStyleErrorHandler class to accept a StyleCheckerConfiguration instance instead of a ProcessorOptions instance and an stderr_write method.
- Scripts/webkitpy/style/error_handlers_unittest.py:
- Updated the unit test classes as necessary.
- Scripts/webkitpy/style/filter.py:
- Addressed the FIXME in the FilterConfiguration class to change the user_rules attribute to _user_rules (since it is now accessed only internally).
- Scripts/webkitpy/style/filter_unittest.py:
- Updated to reflect the change from user_rules to _user_rules.
- 11:12 PM Changeset in webkit [54933] by
-
- 10 edits in trunk
2010-02-17 Tony Chang <tony@chromium.org>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=26937
No longer allow span styles to surround block elements like
divs when pasting (see paste-text-012 and 5065605 which had divs in
spans). This also causes a few cases of empty spans to be removed
(see 19089 and 5245519).
- editing/execCommand/19089-expected.txt:
- editing/pasteboard/5245519-expected.txt:
- editing/pasteboard/5245519.html:
- platform/mac/editing/pasteboard/5065605-expected.txt:
- platform/mac/editing/pasteboard/paste-text-011-expected.txt:
- platform/mac/editing/pasteboard/paste-text-012-expected.txt:
2010-02-17 Tony Chang <tony@chromium.org>
Reviewed by Eric Seidel.
Copying and pasting into a contenteditable area can create <div>s surrounded by <span>s
https://bugs.webkit.org/show_bug.cgi?id=26937
This happens because of a span added when we copy that is used to
preserve styles. To avoid this, when we paste, make sure to apply
the styles to the span's children and then remove the style span.
This change is covered by existing layout tests.
- editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::handleStyleSpans): (WebCore::ReplaceSelectionCommand::copyStyleToChildren):
- editing/ReplaceSelectionCommand.h:
- 10:44 PM Changeset in webkit [54932] by
-
- 3 edits2 adds in trunk
2010-02-17 Tony Chang <tony@chromium.org>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=34914
When pasting absolute font sizes into a content editable area with
page zoom, adjust the font sizes to be the same after page zoom is
applied.
- editing/pasteboard/page-zoom-expected.txt: Added.
- editing/pasteboard/page-zoom.html: Added.
2010-02-17 Tony Chang <tony@chromium.org>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=34914
When pasting absolute font sizes into a content editable area with
page zoom, adjust the font sizes to be the same after page zoom is
applied.
Test: editing/pasteboard/page-zoom.html
- editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::negateStyleRulesThatAffectAppearance):
- 10:28 PM Changeset in webkit [54931] by
-
- 3 edits2 adds in trunk
2010-02-17 Tony Chang <tony@chromium.org>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=34737
Test to verify that pasting styled list items works
the same as pasting unstyle list items.
- editing/pasteboard/paste-list-003-expected.txt: Added.
- editing/pasteboard/paste-list-003.html: Added.
2010-02-17 Tony Chang <tony@chromium.org>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=34737
Copying styled list items then pasting into a list
should work the same as copying unstyle list items:
it shouldn't indent an extra level, but styles should
be copied.
Small cleanups to insertAsListItems to make variable names
more descriptive.
Test: editing/pasteboard/paste-list-003.html
- editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::doApply): (WebCore::ReplaceSelectionCommand::insertAsListItems):
- 10:12 PM Changeset in webkit [54930] by
-
- 2 edits1 add in trunk/WebCore
2010-02-17 Kwang Yul Seo <skyul@company100.net>
Reviewed by Eric Seidel.
[BREWMP] Port PlatformKeyboardEvent
https://bugs.webkit.org/show_bug.cgi?id=34794
Retrieve the type, key code, text and modifiers from BREW's keyboard event.
- platform/PlatformKeyboardEvent.h:
- platform/brew/PlatformKeyboardEventBrew.cpp: Added. (WebCore::keyIdentifierForBrewKeyCode): (WebCore::windowsKeyCodeForKeyEvent): (WebCore::singleCharacterString): (WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent): (WebCore::PlatformKeyboardEvent::disambiguateKeyDownEvent): (WebCore::PlatformKeyboardEvent::currentCapsLockState):
- 9:55 PM Changeset in webkit [54929] by
-
- 3 edits3 adds in trunk
2010-02-17 Hayato Ito <hayato@chromium.org>
Reviewed by Eric Seidel.
Support CSS page-break-inside with a value of 'avoid'.
- printing/page-break-inside-expected.txt: Added.
- printing/page-break-inside.html: Added.
- printing/script-tests/page-break-inside.js: Added. (createParagraph): (pageNumber):
2010-02-17 Hayato Ito <hayato@chromium.org>
Reviewed by Eric Seidel.
Support CSS page-break-inside with a value of 'avoid'.
Test: printing/page-break-inside.html
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::paintChildren):
- 9:38 PM Changeset in webkit [54928] by
-
- 4 edits in trunk/WebKit/chromium
2010-02-17 Evan Martin <evan@chromium.org>
Reviewed by Eric Seidel.
[chromium] expose cache-bypass flag in reload() API
https://bugs.webkit.org/show_bug.cgi?id=34969
This flag is used to force a reload to ignore caches.
(Aka "shift-reload".)
- public/WebFrame.h:
- src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::reload):
- src/WebFrameImpl.h:
- 9:32 PM Changeset in webkit [54927] by
-
- 10 edits3 adds in trunk
2010-02-17 Fumitoshi Ukai <ukai@chromium.org>
Reviewed by Alexey Proskuryakov.
WebSocket bufferedAmount should not be 0 when send after close.
https://bugs.webkit.org/show_bug.cgi?id=34633
- websocket/tests/bufferedAmount-after-close-expected.txt: Added.
- websocket/tests/bufferedAmount-after-close.html: Added.
- websocket/tests/script-tests/bufferedAmount-after-close.js: Added.
2010-02-17 Fumitoshi Ukai <ukai@chromium.org>
Reviewed by Alexey Proskuryakov.
WebSocket bufferedAmount should not be 0 when send after close.
https://bugs.webkit.org/show_bug.cgi?id=34633
Fixed bug in webkit r54694. check m_client after it calls user
callback, because user callback may call close(), which would
call onclose event handler.
Test: websocket/tests/bufferedAmount-after-close.html
- websockets/ThreadableWebSocketChannelClientWrapper.h: (WebCore::ThreadableWebSocketChannelClientWrapper::didClose):
- websockets/WebSocket.cpp: (WebCore::WebSocket::WebSocket): (WebCore::WebSocket::send): (WebCore::WebSocket::close): (WebCore::WebSocket::bufferedAmount): (WebCore::WebSocket::didConnect): (WebCore::WebSocket::didClose):
- websockets/WebSocket.h:
- websockets/WebSocketChannel.cpp: (WebCore::WebSocketChannel::WebSocketChannel): (WebCore::WebSocketChannel::send): (WebCore::WebSocketChannel::bufferedAmount): (WebCore::WebSocketChannel::didClose): (WebCore::WebSocketChannel::didReceiveData):
- websockets/WebSocketChannel.h:
- websockets/WebSocketChannelClient.h: (WebCore::WebSocketChannelClient::didClose):
- websockets/WorkerThreadableWebSocketChannel.cpp: (WebCore::workerContextDidClose): (WebCore::WorkerThreadableWebSocketChannel::Peer::didClose):
- websockets/WorkerThreadableWebSocketChannel.h:
- 9:14 PM Changeset in webkit [54926] by
-
- 6 edits4 adds in trunk
2010-02-17 Yuzo Fujishima <yuzo@google.com>
Reviewed by Eric Seidel.
In diffing render styles, consider all pseudo style changes.
Without this patch, only :before and :after are considered. This is the cause of the following bug.
https://bugs.webkit.org/show_bug.cgi?id=32187
- fast/css/first-letter-first-line-hover.html: Added.
- platform/mac/fast/css/first-letter-first-line-hover-expected.checksum: Added.
- platform/mac/fast/css/first-letter-first-line-hover-expected.png: Added.
- platform/mac/fast/css/first-letter-first-line-hover-expected.txt: Added.
2010-02-17 Yuzo Fujishima <yuzo@google.com>
Reviewed by Eric Seidel.
In diffing render styles, consider all pseudo style changes.
Without this patch, only :before and :after are considered. This is the cause of the following bug.
https://bugs.webkit.org/show_bug.cgi?id=32187
Test: fast/css/first-letter-first-line-hover.html
- dom/Node.cpp: (WebCore::Node::diff):
- rendering/style/RenderStyle.cpp: (WebCore::RenderStyle::hasAnyPublicPseudoStyles):
- rendering/style/RenderStyle.h:
- rendering/style/RenderStyleConstants.h: (WebCore::):
- 9:07 PM Changeset in webkit [54925] by
-
- 3 edits in trunk/JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=35070
Addition of 2 strings of length 231 may result in a string of length 0.
Reviewed by Oliver Hunt.
Check for overflow when creating a new JSString as a result of an addition
or concatenation, throw an out of memory exception.
- runtime/JSString.h:
(JSC::):
- runtime/Operations.h:
(JSC::jsString):
- 8:55 PM Changeset in webkit [54924] by
-
- 1 edit2 adds in trunk/WebCore
2010-02-17 Kwang Yul Seo <skyul@company100.net>
Reviewed by Eric Seidel.
[BREWMP] Add WebCore::prefetchDNS
https://bugs.webkit.org/show_bug.cgi?id=34873
DNS prefetching is not implemented because the maximum number
of UDP sockets is quite small in most BREW devices.
- platform/network/brew/DNSBrew.cpp: Added. (WebCore::prefetchDNS):
- 8:36 PM Changeset in webkit [54923] by
-
- 35 edits in trunk
2010-02-17 Kent Tamura <tkent@chromium.org>
Reviewed by Eric Seidel.
Introduces new Icon loading interface in order to support
asynchronous loading.
https://bugs.webkit.org/show_bug.cgi?id=32054
It's hard for Chromium port to load an icon inside
Icon::createIconForFiles() because of sanbox and multi-process
architecture. So this change adds a method to request an icon to
Chrome class, and makes FileChooser receives an Icon instance
asynchronously. Synchronous loading also works with the new interface.
Because all ports don't have implementations of Chrome::iconForFiles()
yet, FileChooser tries to load an Icon synchronously with
Icon::createIconForFiles(), then tries to load an Icon asynchronously
with Chrome::iconForFiles() if Icon::createIconForFiles() returns 0.
The existing Icon::createIconForFiles() implementations should be
moved to Chrome::iconForFiles(). We're going to remove
Icon::createIconForFiles().
- loader/EmptyClients.h: (WebCore::EmptyChromeClient::iconForFiles): Add an empty implementation.
- page/Chrome.cpp: (WebCore::Chrome::iconForFiles): Delegate to ChromeClient::iconForFiles().
- page/Chrome.h:
- page/ChromeClient.h: (WebCore::ChromeClient::iconForFiles): Add a declaration as a pure virtual method.
- platform/FileChooser.cpp: (WebCore::FileChooser::FileChooser): Use loadIcon(). (WebCore::FileChooser::chooseFiles): ditto. (WebCore::FileChooser::loadIcon): Added. (WebCore::FileChooser::iconLoaded): Added.
- platform/FileChooser.h: Add two methods to FileChooserClient; repaint() and iconForFiles().
- platform/graphics/Icon.h: Add a FIXME comment.
- platform/graphics/gtk/IconGtk.cpp: ditto.
- platform/graphics/mac/IconMac.mm: ditto.
- platform/graphics/qt/IconQt.cpp: ditto.
- platform/graphics/win/IconWin.cpp: ditto.
- rendering/RenderFileUploadControl.cpp: (WebCore::RenderFileUploadControl::iconForFiles): Delegate to Chrome::iconForFiles(). (WebCore::RenderFileUploadControl::click): Use chrome(). (WebCore::RenderFileUploadControl::chrome):
- rendering/RenderFileUploadControl.h: (WebCore::RenderFileUploadControl::repaint):
2010-02-17 Kent Tamura <tkent@chromium.org>
Reviewed by Eric Seidel.
Introduces new Icon loading interface in order to support
asynchronous loading.
https://bugs.webkit.org/show_bug.cgi?id=32054
Add an empty implementation of ChromeClient::iconForFiles().
- src/ChromeClientImpl.cpp: (WebKit::ChromeClientImpl::iconForFiles):
- src/ChromeClientImpl.h:
2010-02-17 Kent Tamura <tkent@chromium.org>
Reviewed by Eric Seidel.
Introduces new Icon loading interface in order to support
asynchronous loading.
https://bugs.webkit.org/show_bug.cgi?id=32054
Add an empty implementation of ChromeClient::iconForFiles().
- WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::iconForFiles):
- WebCoreSupport/ChromeClientGtk.h:
2010-02-17 Kent Tamura <tkent@chromium.org>
Reviewed by Eric Seidel.
Introduces new Icon loading interface in order to support
asynchronous loading.
https://bugs.webkit.org/show_bug.cgi?id=32054
Add an empty implementation of ChromeClient::iconForFiles().
- WebCoreSupport/ChromeClientHaiku.cpp: (WebCore::ChromeClientHaiku::iconForFiles):
- WebCoreSupport/ChromeClientHaiku.h:
2010-02-17 Kent Tamura <tkent@chromium.org>
Reviewed by Eric Seidel.
Introduces new Icon loading interface in order to support
asynchronous loading.
https://bugs.webkit.org/show_bug.cgi?id=32054
Add an empty implementation of ChromeClient::iconForFiles().
- WebCoreSupport/WebChromeClient.h:
- WebCoreSupport/WebChromeClient.mm: (WebChromeClient::iconForFiles):
2010-02-17 Kent Tamura <tkent@chromium.org>
Reviewed by Eric Seidel.
Introduces new Icon loading interface in order to support
asynchronous loading.
https://bugs.webkit.org/show_bug.cgi?id=32054
Add an empty implementation of ChromeClient::iconForFiles().
- WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::iconForFiles):
- WebCoreSupport/ChromeClientQt.h:
2010-02-17 Kent Tamura <tkent@chromium.org>
Reviewed by Eric Seidel.
Introduces new Icon loading interface in order to support
asynchronous loading.
https://bugs.webkit.org/show_bug.cgi?id=32054
Add an empty implementation of ChromeClient::iconForFiles().
- WebCoreSupport/WebChromeClient.cpp: (WebChromeClient::iconForFiles):
- WebCoreSupport/WebChromeClient.h:
2010-02-17 Kent Tamura <tkent@chromium.org>
Reviewed by Eric Seidel.
Introduces new Icon loading interface in order to support
asynchronous loading.
https://bugs.webkit.org/show_bug.cgi?id=32054
Add an empty implementation of ChromeClient::iconForFiles().
- WebKitSupport/ChromeClientWx.cpp: (WebCore::ChromeClientWx::iconForFiles):
- WebKitSupport/ChromeClientWx.h:
- 8:19 PM Changeset in webkit [54922] by
-
- 2 edits in trunk/WebKit/win
2010-02-17 Shinichiro Hamaji <hamaji@chromium.org>
Unreviewed. Touch WebKit.idl to fix the build.
[Win] Implement test functions for printing
https://bugs.webkit.org/show_bug.cgi?id=34570
- Interfaces/WebKit.idl:
- 6:42 PM Changeset in webkit [54921] by
-
- 8 edits in trunk
2010-02-17 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Eric Seidel.
[Win] Implement layoutTestController.pageNumberForElementById
https://bugs.webkit.org/show_bug.cgi?id=34570
- platform/win/Skipped:
2010-02-17 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Eric Seidel.
[Win] Implement test functions for printing
https://bugs.webkit.org/show_bug.cgi?id=34570
- Interfaces/IWebFramePrivate.idl:
- WebFrame.cpp: (WebFrame::pageNumberForElementById): (WebFrame::numberOfPages):
- WebFrame.h:
2010-02-17 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Eric Seidel.
[Win] Implement test functions for printing
https://bugs.webkit.org/show_bug.cgi?id=34570
- DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::pageNumberForElementById): (LayoutTestController::numberOfPages):
- 6:19 PM Changeset in webkit [54920] by
-
- 2 edits in trunk/WebKitTools
2010-02-17 Fumitoshi Ukai <ukai@chromium.org>
Reviewed by Eric Seidel.
websocket/tests/cookies/httponly-cookie.pl fails every time under run-chromium-webkit-tests
https://bugs.webkit.org/show_bug.cgi?id=35001
- Scripts/webkitpy/layout_tests/port/websocket_server.py: add -x flag to run pywebsocket.
- 6:19 PM Changeset in webkit [54919] by
-
- 2 edits in trunk/WebCore
Bug 35065: Delay between page loading and animated GIF playing
<http://webkit.org/b/35065> / <rdar://problem/7109548>
Reviewed by Darin Adler.
BitmapImage::startAnimation was adding the current frame duration to the desired start time
of the frame for every time it was called. If the function then bailed out due to not having
sufficient data to render the frame, this would lead to the desired start time of the frame
being pushed out multiple times. On an animated GIF that took mulitple seconds to load this
could happen many times for a single frame, resulting in the start time of the second frame
of the animation being pushed out by as much as five seconds.
- platform/graphics/BitmapImage.cpp:
(WebCore::BitmapImage::startAnimation): Change the order of the code slightly so that the
desired start time is only updated after determining that we have sufficient data to handle
the next frame.
- 6:13 PM Changeset in webkit [54918] by
-
- 3 edits in trunk/WebKitTools
2010-02-17 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Eric Seidel.
check-webkit-style: Misses variables that contain underscores.
https://bugs.webkit.org/show_bug.cgi?id=33724
- Check identifiers whose types are unsigned.
- Check bitfields properly.
- Scripts/webkitpy/style/processors/cpp.py:
- Scripts/webkitpy/style/processors/cpp_unittest.py:
- 6:00 PM Changeset in webkit [54917] by
-
- 4 edits in trunk/WebKitTools
2010-02-17 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Eric Seidel.
check-webkit-style should report the number of files checked
https://bugs.webkit.org/show_bug.cgi?id=34971
- Scripts/check-webkit-style:
- Scripts/webkitpy/style/checker.py:
- Scripts/webkitpy/style/checker_unittest.py:
- 5:35 PM Changeset in webkit [54916] by
-
- 2 edits in trunk/WebCore
2010-02-17 Stephan Aßmus <superstippi@gmx.de>
Reviewed by Eric Seidel.
Implemented homeDirectoryPath() and listDirectory() on the Haiku platform.
https://bugs.webkit.org/show_bug.cgi?id=34687
Covered by existing tests.
- platform/haiku/FileSystemHaiku.cpp: (WebCore::homeDirectoryPath): Implemented (WebCore::listDirectory): Implemented
- 5:19 PM Changeset in webkit [54915] by
-
- 1 edit1 add in trunk/WebCore
2010-02-17 Kwang Yul Seo <skyul@company100.net>
Reviewed by Eric Seidel.
[BREWMP] Port userIdleTime
https://bugs.webkit.org/show_bug.cgi?id=34259
Return an arbitrarily high userIdleTime so that releasing pages from the page
cache isn't postponed.
- platform/brew/SystemTimeBrew.cpp: Added. (WebCore::userIdleTime):
- 4:51 PM Changeset in webkit [54914] by
-
- 1 edit in trunk/LayoutTests/platform/win/Skipped
Actually land the changes to the Skipped list
- 4:50 PM Changeset in webkit [54913] by
-
- 1 edit in trunk/LayoutTests/ChangeLog
Rubber-stamped by Dan Bernstein.
Unskip glyph-reordering, because now it passes on Windows.
- platform/win/Skipped:
- 4:28 PM Changeset in webkit [54912] by
-
- 3 edits in trunk/LayoutTests
[GTK][Qt] Fails glyph reordering test fast/text/glyph-reordering.html
https://bugs.webkit.org/show_bug.cgi?id=34918
Reviewed by Eric Seidel.
Made the test less dependent on the complex text implementation.
- fast/text/glyph-reordering-expected.txt:
- fast/text/glyph-reordering.html:
- 3:10 PM Changeset in webkit [54911] by
-
- 51 edits2 copies3 deletes in trunk
2010-02-17 Dirk Schulze <krit@webkit.org>
Rolling out r54909. Breaks SL and Win.
- 2:29 PM Changeset in webkit [54910] by
-
- 3 edits2 adds in trunk
WebCore: Fix Chromium's bindings for Database.transaction(): a 'null'
callback should be treated as no callback.
Reviewed by Dimitri Glazkov.
Test: storage/null-callbacks.html
https://bugs.webkit.org/show_bug.cgi?id=35047
- bindings/v8/custom/V8DatabaseCustom.cpp:
(WebCore::createTransaction):
LayoutTests: Add a test that verifies that null transaction callbacks are
accepted and treated as no callbacks.
Reviewed by Dimitri Glazkov.
https://bugs.webkit.org/show_bug.cgi?id=35047
- storage/null-callbacks-expected.txt: Added.
- storage/null-callbacks.html: Added.
- 2:12 PM Changeset in webkit [54909] by
-
- 52 edits3 adds2 deletes in trunk
2010-02-17 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
Move SVGResources to Renderers, starting with Masker
https://bugs.webkit.org/show_bug.cgi?id=35020
We have rendering specific code in WebCore/svg/graphics. The goal is to move
this code into suitable Renderers. This helps us to clean up the code and makes
maintenance easier. It also makes it possible to remove rendering specific code
from SVG*Elements into this renderers. So the Renderer contains everything that
is needed to use the resource.
RenderSVGResource will be the base class for all new resource render classes like
RenderSVGResourceMasker, RenderSVGResourceClipper and the other resources.
This patch starts moving SVGResourceMasker to RenderSVGResourceMasker.
Another benefit is the much more useful result in DRT on using masker.
- Android.mk:
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- rendering/RenderObject.cpp: (WebCore::RenderObject::toRenderSVGResource): Conversion to RenderSVGResource base class.
- rendering/RenderObject.h: (WebCore::RenderObject::isSVGResource): Check if renderer is a resource.
- rendering/RenderPath.cpp:
- rendering/RenderSVGImage.cpp: (WebCore::RenderSVGImage::destroy): Renderer gets destroyed, unregister it from it's resources.
- rendering/RenderSVGImage.h: Some code clean up according to the webkit style. (WebCore::RenderSVGImage::toSVGRenderBase): (WebCore::RenderSVGImage::renderName): (WebCore::RenderSVGImage::isSVGImage): (WebCore::RenderSVGImage::localToParentTransform): (WebCore::RenderSVGImage::strokeBoundingBox): (WebCore::RenderSVGImage::requiresLayer): (WebCore::RenderSVGImage::localTransform):
- rendering/RenderSVGInlineText.h: (WebCore::RenderSVGInlineText::objectBoundingBox): Needed for SVGRenderTreeAsText
- rendering/RenderSVGModelObject.cpp: (WebCore::RenderSVGModelObject::destroy): Renderer gets destroyed, unregister it from it's resources.
- rendering/RenderSVGModelObject.h:
- rendering/RenderSVGResource.h: Added. (WebCore::): Base class for all Resource renderers like masker, clipper and others. (WebCore::RenderSVGResource::RenderSVGResource): (WebCore::RenderSVGResource::cast): (WebCore::RenderSVGResource::toRenderSVGResource): (WebCore::RenderSVGResource::isSVGResource): (WebCore::RenderSVGResource::drawsContents): (WebCore::getRenderSVGResourceById):
- rendering/RenderSVGResourceMasker.cpp: Added. (WebCore::RenderSVGResourceMasker::RenderSVGResourceMasker): (WebCore::RenderSVGResourceMasker::~RenderSVGResourceMasker): (WebCore::RenderSVGResourceMasker::invalidateClients): Status of masker changed, remove all clients. (WebCore::RenderSVGResourceMasker::invalidateClient): Status of an object changed, remove pending client. (WebCore::RenderSVGResourceMasker::applyResource): Apply masker to object. (WebCore::RenderSVGResourceMasker::resourceBoundingBox): boundingBox of the resource, depending on the object. (WebCore::RenderSVGResourceMasker::createMaskImage): Creates the mask image, the context gets clipped with.
- rendering/RenderSVGResourceMasker.h: Added. (WebCore::MaskerData::MaskerData): (WebCore::RenderSVGResourceMasker::renderName): (WebCore::RenderSVGResourceMasker::maskUnits): Unit of mask for DRT. (WebCore::RenderSVGResourceMasker::maskContentUnits): Unit of childs from mask for DRT. (WebCore::RenderSVGResourceMasker::resourceType):
- rendering/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::destroy): Renderer gets destroyed, unregister it from it's resources.
- rendering/RenderSVGRoot.h:
- rendering/RenderSVGText.cpp: (WebCore::RenderSVGText::destroy): dito.
- rendering/RenderSVGText.h:
- rendering/RenderTreeAsText.cpp: (WebCore::write):
- rendering/SVGRenderSupport.cpp: (WebCore::SVGRenderBase::prepareToRenderSVGContent): (WebCore::SVGRenderBase::maskerBoundingBoxForRenderer): (WebCore::SVGRenderBase::deregisterFromResources): Unregister object from all it's resources after status changed.
- rendering/SVGRenderSupport.h: (WebCore::SVGRenderBase::toSVGRenderBase): (WebCore::SVGRenderBase::strokeBoundingBox): (WebCore::SVGRenderBase::markerBoundingBox):
- rendering/SVGRenderTreeAsText.cpp: Update TreeAsText to dump maskers correctly. (WebCore::operator<<): (WebCore::writeSVGResource): (WebCore::writeSVGContainer): (WebCore::writeSVGText): (WebCore::writeSVGInlineText): (WebCore::writeSVGImage): (WebCore::write): (WebCore::writeResourcesToObject):
- rendering/SVGRenderTreeAsText.h:
- svg/SVGMaskElement.cpp: Update Masker to use the new renderer. (WebCore::SVGMaskElement::svgAttributeChanged): (WebCore::SVGMaskElement::childrenChanged): (WebCore::SVGMaskElement::maskBoundingBox): (WebCore::SVGMaskElement::createRenderer):
- svg/SVGMaskElement.h:
- svg/SVGStyledElement.cpp: We need to tell the renderer to unregister object, after the status changed. (WebCore::SVGStyledElement::invalidateResources): (WebCore::SVGStyledElement::invalidateResourcesInAncestorChain):
- svg/SVGUnitTypes.h: Conversion of integer to SVGUnitType. (WebCore::toUnitType):
- svg/graphics/SVGResource.h: (WebCore::): (WebCore::SVGResource::isMarker):
- svg/graphics/SVGResourceMasker.cpp: Removed.
- svg/graphics/SVGResourceMasker.h: Removed.
2010-02-17 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
Move SVGResources to Renderers, starting with Masker
https://bugs.webkit.org/show_bug.cgi?id=35020
With the move from SVGResourceMasker to RenderSVGResourceMasker, I changed
the way DRT dumps resources. DRT is now able to dump multi-access
of resources.
Also the size of a Mask resource (depending of the object) and the access of
the resource (togeter with the resource name) is pointed out as an insertion
under the object.
- platform/mac/svg/W3C-SVG-1.1/masking-intro-01-f-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/masking-mask-01-b-expected.txt:
- platform/mac/svg/batik/masking/maskRegions-expected.txt:
- platform/mac/svg/css/circle-in-mask-with-shadow-expected.txt:
- platform/mac/svg/css/mask-with-shadow-expected.txt:
- platform/mac/svg/custom/empty-mask-expected.txt:
- platform/mac/svg/custom/grayscale-gradient-mask-expected.txt:
- platform/mac/svg/custom/js-late-mask-and-object-creation-expected.txt:
- platform/mac/svg/custom/js-late-mask-creation-expected.txt:
- platform/mac/svg/custom/mask-changes-expected.txt:
- platform/mac/svg/custom/mask-child-changes-expected.txt:
- platform/mac/svg/custom/mask-excessive-malloc-expected.txt:
- platform/mac/svg/custom/mask-inside-defs-expected.txt:
- platform/mac/svg/custom/mask-invalidation-expected.txt:
- platform/mac/svg/custom/mask-on-multiple-objects-expected.txt:
- platform/mac/svg/custom/mask-with-all-units-expected.txt:
- platform/mac/svg/custom/mask-with-default-value-expected.txt:
- platform/mac/svg/custom/resource-invalidate-on-target-update-expected.txt:
- platform/mac/svg/custom/visibility-override-mask-expected.txt:
- platform/mac/svg/filters/filter-clip-expected.txt:
- svg/custom/transformedMaskFails-expected.txt:
- 1:45 PM Changeset in webkit [54908] by
-
- 9 edits in trunk/WebKit/mac
Add a way for WebView and its dependancies to be selectively included
in WebKitStatistics leak tracking. By default WebView is not included and
you need to subclass WebView and implement +isIncludedInWebKitStatistics
to be included.
rdar://problem/7567677&7572900
https://webkit.org/b/35045
Reviewed by Adam Roben.
- WebView/WebDataSource.mm:
(-[WebDataSource _initWithDocumentLoader:]): Increment WebDataSourceCount if the WebFrame is included in statistics.
(-[WebDataSource dealloc]): Only --WebDataSourceCount if _private->includedInWebKitStatistics is YES.
(-[WebDataSource finalize]): Ditto.
- WebView/WebFrame.mm:
(-[WebFrame _isIncludedInWebKitStatistics]): Return _private->includedInWebKitStatistics.
(-[WebFrame _initWithWebFrameView:webView:]): Increment WebFrameCount if the WebView's class is included in statistics.
(-[WebFrame dealloc]): Only --WebFrameCount if _private->includedInWebKitStatistics is YES.
(-[WebFrame finalize]): Ditto.
- WebView/WebFrameInternal.h:
- WebView/WebFrameView.mm:
(-[WebFrameView _setWebFrame:]): Increment WebFrameViewCount if the WebFrame is included in statistics.
(-[WebFrameView initWithFrame:]): Move ++WebFrameViewCount from here since we don't
know what WebFrame we belong to yet.
(-[WebFrameView dealloc]): Only --WebFrameViewCount if _private->includedInWebKitStatistics is YES.
(-[WebFrameView finalize]): Ditto.
- WebView/WebHTMLRepresentation.mm:
(-[WebHTMLRepresentation init]): Move ++WebHTMLRepresentationCount from here since we don't
know what WebFrame we belong to yet.
(-[WebHTMLRepresentation dealloc]): Only --WebHTMLRepresentationCount if _private->includedInWebKitStatistics is YES.
(-[WebHTMLRepresentation finalize]): Ditto.
(-[WebHTMLRepresentation setDataSource:]): Increment WebHTMLRepresentationCount if the WebFrame of the dataSource is
included in statistics.
- WebView/WebView.mm:
(-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
(-[WebView dealloc]):
(+[WebView shouldIncludeInWebKitStatistics]): Return NO, so any WebView wont be included.
Subclasses that care can return YES to be included.
- WebView/WebViewInternal.h:
- 1:05 PM Changeset in webkit [54907] by
-
- 9 edits6 adds in trunk
2010-02-17 Kenneth Russell <kbr@google.com>
Reviewed by Oliver Hunt.
Refactor texImage2D and texSubImage2D taking Image to use common code
https://bugs.webkit.org/show_bug.cgi?id=34458
Merged the Safari and Chromium code which extracts the data from
Image objects into common entry points on GraphicsContext3D. This
immediately fixes the following three problems:
- Chromium not implementing texSubImage2D taking Image.
- Safari not obeying the flipY parameter to texImage2D or texSubImage2D taking Image.
- Safari not obeying the premultipyAlpha parameter to texImage2D or texSubImage2D taking Image.
Added new test verifying the behavior of texImage2D and
texSubImage2D and the flipY parameter. The premultiplyAlpha
parameter can not be tested yet as the implementation is not yet
spec compliant. This will be fixed in a follow-on bug.
Ran all WebGL demos in demo repository on Safari and Chromium;
textures are now the right way up in both browsers, and
transparent textures in Particles demo now look correct in Safari.
- fast/canvas/webgl/resources/red-green.png: Added.
- fast/canvas/webgl/tex-image-and-sub-image-2d-with-image-expected.txt: Added.
- fast/canvas/webgl/tex-image-and-sub-image-2d-with-image.html: Added.
2010-02-17 Kenneth Russell <kbr@google.com>
Reviewed by Oliver Hunt.
Refactor texImage2D and texSubImage2D taking Image to use common code
https://bugs.webkit.org/show_bug.cgi?id=34458
Merged the Safari and Chromium code which extracts the data from
Image objects into common entry points on GraphicsContext3D. This
immediately fixes the following three problems:
- Chromium not implementing texSubImage2D taking Image.
- Safari not obeying the flipY parameter to texImage2D or texSubImage2D taking Image.
- Safari not obeying the premultipyAlpha parameter to texImage2D or texSubImage2D taking Image.
Added new test verifying the behavior of texImage2D and
texSubImage2D and the flipY parameter. The premultiplyAlpha
parameter can not be tested yet as the implementation is not yet
spec compliant. This will be fixed in a follow-on bug.
Ran all WebGL demos in demo repository on Safari and Chromium;
textures are now the right way up in both browsers, and
transparent textures in Particles demo now look correct in Safari.
Test: fast/canvas/webgl/tex-image-and-sub-image-2d-with-image.html
- WebCore.gyp/WebCore.gyp:
- WebCore.gypi:
- WebCore.xcodeproj/project.pbxproj:
- platform/graphics/GraphicsContext3D.cpp: Added. (WebCore::GraphicsContext3D::extractImageData): (WebCore::GraphicsContext3D::processImageData): (WebCore::GraphicsContext3D::premultiplyAlpha): (WebCore::GraphicsContext3D::unmultiplyAlpha):
- platform/graphics/GraphicsContext3D.h: (WebCore::GraphicsContext3D::):
- platform/graphics/cg/GraphicsContext3DCG.cpp: Added. (WebCore::GraphicsContext3D::getImageData):
- platform/graphics/mac/GraphicsContext3DMac.cpp: (WebCore::GraphicsContext3D::texImage2D): (WebCore::GraphicsContext3D::texSubImage2D):
- platform/graphics/skia/GraphicsContext3DSkia.cpp: Added. (WebCore::GraphicsContext3D::getImageData):
2010-02-17 Kenneth Russell <kbr@google.com>
Reviewed by Oliver Hunt.
Refactor texImage2D and texSubImage2D taking Image to use common code
https://bugs.webkit.org/show_bug.cgi?id=34458
Merged the Safari and Chromium code which extracts the data from
Image objects into common entry points on GraphicsContext3D. This
immediately fixes the following three problems:
- Chromium not implementing texSubImage2D taking Image.
- Safari not obeying the flipY parameter to texImage2D or texSubImage2D taking Image.
- Safari not obeying the premultipyAlpha parameter to texImage2D or texSubImage2D taking Image.
Added new test verifying the behavior of texImage2D and
texSubImage2D and the flipY parameter. The premultiplyAlpha
parameter can not be tested yet as the implementation is not yet
spec compliant. This will be fixed in a follow-on bug.
Ran all WebGL demos in demo repository on Safari and Chromium;
textures are now the right way up in both browsers, and
transparent textures in Particles demo now look correct in Safari.
- src/GraphicsContext3D.cpp: (WebCore::GraphicsContext3D::texImage2D): (WebCore::GraphicsContext3D::texSubImage2D):
- 12:08 PM Changeset in webkit [54906] by
-
- 4 edits in trunk
2010-02-17 Noam Rosenthal <noam.rosenthal@nokia.com>
Reviewed by Ariya Hidayat.
[Qt] GraphicsLayer: support perspective and 3D transforms
https://bugs.webkit.org/show_bug.cgi?id=34960
- WebKit.pri: added appropriate define: ENABLED_3D_RENDERING
2010-02-17 Noam Rosenthal <noam.rosenthal@nokia.com>
Reviewed by Ariya Hidayat.
[Qt] GraphicsLayer: support perspective and 3D transforms
https://bugs.webkit.org/show_bug.cgi?id=34960
New tests: http://webkit.org/blog-files/3d-transforms/perspective-by-example.html
- platform/graphics/qt/GraphicsLayerQt.cpp: (WebCore::GraphicsLayerQtImpl::updateTransform): (WebCore::GraphicsLayerQtImpl::setBaseTransform): (WebCore::GraphicsLayerQtImpl::computeTransform): (WebCore::GraphicsLayerQtImpl::flushChanges): (WebCore::TransformAnimationQt::~TransformAnimationQt):
- 11:51 AM Changeset in webkit [54905] by
-
- 2 edits in trunk/WebCore
Unreviewed, build fix.
Fix crashes due to an omitted line in r54839.
- platform/image-decoders/png/PNGImageDecoder.cpp:
(WebCore::decodingFailed):
- 11:28 AM Changeset in webkit [54904] by
-
- 4 edits in trunk
2010-02-17 Alok Priyadarshi <alokp@chromium.org>
Reviewed by Ariya Hidayat.
Bug 34900: Implement accelerated compositing for chromium.
https://bugs.webkit.org/show_bug.cgi?id=34900
Do not exclude files needed for accelerated compositing. In fact there is no need to exclude these files.
These files are already guarded with WTF_USE_ACCELERATED_COMPOSITING flag.
- WebCore.gyp/WebCore.gyp: Removed GraphicsLayer.cpp, RenderLayerBacking.cpp, and RenderLayerCompositor.cpp from excluded list.
2010-02-17 Alok Priyadarshi <alokp@chromium.org>
Reviewed by Ariya Hidayat.
Bug 34900: Implement accelerated compositing for chromium.
https://bugs.webkit.org/show_bug.cgi?id=34900
- features.gypi: Added WTF_USE_ACCELERATED_COMPOSITING flag.
- 11:08 AM Changeset in webkit [54903] by
-
- 7 edits in trunk
[chromium] Remove the obsolete chromium interface for handling DownloadURL.
https://bugs.webkit.org/show_bug.cgi?id=34982
Reviewed by Darin Fisher.
WebCore:
- platform/chromium/ChromiumDataObject.cpp:
(WebCore::ChromiumDataObject::clear):
(WebCore::ChromiumDataObject::hasData):
(WebCore::ChromiumDataObject::ChromiumDataObject):
- platform/chromium/ChromiumDataObject.h:
- platform/chromium/ClipboardChromium.cpp:
(WebCore::ClipboardChromium::setData):
WebKit/chromium:
- public/WebDragData.h:
- src/WebDragData.cpp:
- 11:06 AM Changeset in webkit [54902] by
-
- 5 edits in trunk
2010-02-17 Diego Gonzalez <diego.gonzalez@openbossa.org>
Reviewed by Ariya Hidayat.
Make possible Qt DRT to get total number of pages to be printed
LayoutTests:
printing/numberOfPages.html
[Qt] DRT: Get total number of pages to be printed
https://bugs.webkit.org/show_bug.cgi?id=34955
- Api/qwebframe.cpp: (qt_drt_numberOfPages): (qt_drt_evaluateScriptInIsolatedWorld):
2010-02-17 Diego Gonzalez <diego.gonzalez@openbossa.org>
Reviewed by Ariya Hidayat.
Make possible Qt DRT to get total number of pages to be printed
LayoutTests:
printing/numberOfPages.html
[Qt] DRT: Get total number of pages to be printed
https://bugs.webkit.org/show_bug.cgi?id=34955
- DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::numberOfPages):
- DumpRenderTree/qt/LayoutTestControllerQt.h:
- 11:02 AM Changeset in webkit [54901] by
-
- 2 edits1 add in trunk/WebCore
<rdar://problem/7645569> REGRESSION (r51324): Incorrect marker rects for blocks that span multiple columns
Reviewed by Darin Adler.
- manual-tests/match-marker-rects.html: Added.
- rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::paintTextMatchMarker): Use the text renderer rather
than its ancestor block for the local-to-absolute transformation.
(WebCore::InlineTextBox::computeRectForReplacementMarker): Ditto.
- 10:33 AM Changeset in webkit [54900] by
-
- 5 edits in trunk
WebKit/gtk:
2010-02-17 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
Rename 'enable-java' setting to 'enable-java-applet', since it
only controls whether <applet> is supported or not instead of
whether all Java content is supported or not.
- webkit/webkitwebsettings.cpp: (webkit_web_settings_class_init): (webkit_web_settings_set_property): (webkit_web_settings_get_property): (webkit_web_settings_copy):
- webkit/webkitwebview.cpp: (DNDContentsRequest::webkit_web_view_update_settings): (DNDContentsRequest::webkit_web_view_settings_notify):
WebKitTools:
2010-02-17 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
Update to use new property name.
- DumpRenderTree/gtk/DumpRenderTree.cpp: (resetDefaultsToConsistentValues):
- 9:49 AM Changeset in webkit [54899] by
-
- 2 edits in trunk/WebKitTools
2010-02-17 Julien Chaffraix <jchaffraix@webkit.org>
Reviewed by Ariya Hidayat.
Remove some warnings seen when building Qt
https://bugs.webkit.org/show_bug.cgi?id=35017
Using a machine without the needed tools to build WebKit leads to
several errors and warnings.
- Scripts/webkitdirs.pm: Refactored the code testing the command's presence into a commandExists routine. While doing so removed, stderr output as it usually does not give anything more than our message. Also added a Qt check for qmake that was missing.
- 7:47 AM Changeset in webkit [54898] by
-
- 2 edits in trunk/LayoutTests
2010-02-17 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed. Try to turn windows slaves again, by skipping two websocket tests that fail reliable.
- platform/win/Skipped:
- 7:17 AM Changeset in webkit [54897] by
-
- 2 edits in trunk/LayoutTests
Typo in test name
- 7:14 AM Changeset in webkit [54896] by
-
- 1 edit3 adds in trunk/LayoutTests
Rubber-stamped by Tor Arne Vestbø.
[Qt] Add platform specific expected files for new tests pass in fast/css.
Rendertree results compared to Mac expected files with --ignore-metrics,
pixel results compared to Mac png files.
fast/css/font-face-opentype.html introduced in r54855.
fast/css/inline-element-line-break.html introduced in r54544.
fast/css/pseudo-element-line-break.html introduced in r54544.
- platform/qt/fast/css/font-face-opentype-expected.txt: Added.
- platform/qt/fast/css/inline-element-line-break-expected.txt: Added.
- platform/qt/fast/css/pseudo-element-line-break-expected.txt: Added.
- 7:09 AM Changeset in webkit [54895] by
-
- 2 edits in trunk/LayoutTests
2010-02-17 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed. Try to turn SnowLeopard slave green again. Skipping media/video-load-networkState.html - already filed a bug last year.
- platform/mac-snowleopard/Skipped:
- 7:05 AM Changeset in webkit [54894] by
-
- 2 edits in trunk/LayoutTests
2010-02-17 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed. Try to turn Tiger slave green again. Skipping media/video-display-aspect-ratio.html - already skipped on the other mac variants & win.
- platform/mac-tiger/Skipped:
- 6:48 AM Changeset in webkit [54893] by
-
- 2 edits in trunk/LayoutTests
Skipping new test that does not pass on Qt.
- 6:30 AM Changeset in webkit [54892] by
-
- 5 edits3 adds in trunk
2010-02-17 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Xan Lopez.
Does not send an Accept header for subresources, causing some sites to break
https://bugs.webkit.org/show_bug.cgi?id=33242
Set */* as the Accept header when downloading resources
that did not set an Accept header. This behaviour is similar to
the one adopted by Chromium.
Test: http/tests/misc/image-checks-for-accept.html
- platform/network/soup/ResourceHandleSoup.cpp: (WebCore::startHttp):
- 6:24 AM Changeset in webkit [54891] by
-
- 1 edit in trunk/WebCore/ChangeLog
Fix a mistake I just committed to the change log.
Note that the last svn commit message should have read like this:
2010-02-17 Marcus Bulach <bulach@chromium.org>
Reviewed by Jeremy Orlow.
Fixes initialization order of members for GeolocationServiceChromium.
https://bugs.webkit.org/show_bug.cgi?id=35034
- platform/chromium/GeolocationServiceChromium.cpp:
- 6:20 AM Changeset in webkit [54890] by
-
- 2 edits in trunk/WebCore
2
- 6:08 AM Changeset in webkit [54889] by
-
- 2 edits in trunk/WebKitTools
2010-02-17 Xan Lopez <xlopez@igalia.com>
Rubber-stamped by Gustavo Noronha.
Disable Java by default in DRT.
- DumpRenderTree/gtk/DumpRenderTree.cpp: (resetDefaultsToConsistentValues):
- 5:46 AM Changeset in webkit [54888] by
-
- 2 edits in trunk/WebKit/gtk
2010-02-17 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
[Linux] Webkit incompatible with Java plugins
https://bugs.webkit.org/show_bug.cgi?id=24912
Implement FrameLoaderClient::createJavaAppletWidget.
- WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::createJavaAppletWidget):
- 5:46 AM Changeset in webkit [54887] by
-
- 5 edits in trunk
WebCore:
2010-02-17 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
[Linux] Webkit incompatible with Java plugins
https://bugs.webkit.org/show_bug.cgi?id=24912
Resolve symlinks before trying to load plugins as modules, since
GModule won't do it.
Based on original work by Gustavo Noronha.
- plugins/gtk/PluginPackageGtk.cpp: (WebCore::PluginPackage::load):
2010-02-17 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
[Linux] Webkit incompatible with Java plugins
https://bugs.webkit.org/show_bug.cgi?id=24912
Add support for GFile to GOwnPtr.
Based on original work by Gustavo Noronha.
- wtf/gtk/GOwnPtr.cpp: (WTF::GFile):
- wtf/gtk/GOwnPtr.h:
- 5:41 AM Changeset in webkit [54886] by
-
- 3 edits in trunk/WebKit/gtk
2010-02-17 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
[Linux] Webkit incompatible with Java plugins
https://bugs.webkit.org/show_bug.cgi?id=24912
Add a WebKitWebSetting to enable/disable the Java plugin support.
- webkit/webkitwebsettings.cpp: (webkit_web_settings_class_init): (webkit_web_settings_set_property): (webkit_web_settings_get_property): (webkit_web_settings_copy):
- webkit/webkitwebview.cpp: (webkit_web_view_update_settings): (webkit_web_view_settings_notify):
- 5:39 AM Changeset in webkit [54885] by
-
- 4 edits in trunk
2010-02-16 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by NOBODY (OOPS!).
Protect the resource loader object from disappearing during
parseDataUrl.
Tested by testdownload API test.
- platform/network/soup/ResourceHandleSoup.cpp: (WebCore::parseDataUrl):
- 5:12 AM Changeset in webkit [54884] by
-
- 2 edits in trunk/LayoutTests
Skip a number of new tests
- 4:00 AM Changeset in webkit [54883] by
-
- 12 edits3 adds in trunk
2010-02-17 Marcus Bulach <bulach@chromium.org>
Reviewed by Jeremy Orlow.
Implements GeolocationServices for Chromium.
https://bugs.webkit.org/show_bug.cgi?id=32068
This is part of implementing Geolocation framework for Chromium. Existing layout tests should pass.
- WebCore.gypi:
- page/Geolocation.h:
- platform/GeolocationService.h:
- 2:49 AM Changeset in webkit [54882] by
-
- 2 edits in trunk/WebKit/gtk
2010-02-17 Philippe Normand <pnormand@igalia.com>
Reviewed by Xan Lopez.
Missing property warning after r54873
https://bugs.webkit.org/show_bug.cgi?id=35023
Add a new WebKitWebSettings setting, 'enable-file-access-from-file-uris', set to
FALSE by default, that when enabled will assign each file:// URI
their own security domain.
- webkit/webkitwebsettings.cpp: (webkit_web_settings_class_init): (webkit_web_settings_set_property): (webkit_web_settings_get_property): (webkit_web_settings_copy):
- 2:21 AM Changeset in webkit [54881] by
-
- 4 edits in trunk/WebCore
2010-02-17 Steve Block <steveblock@google.com>
Reviewed by Ariya Hidayat.
Adds missing platform and feature guards to V8 bindings
https://bugs.webkit.org/show_bug.cgi?id=34987
No new tests, build fix only.
- bindings/v8/V8Proxy.cpp: Modified. Adds CHROMIUM guards and uses PlatformBridge in place of ChromiumBridge
- bindings/v8/V8Proxy.h: Modified. Adds CHROMIUM guards and uses PlatformBridge in place of ChromiumBridge
- bindings/v8/custom/V8DocumentCustom.cpp: Modified. Adds XPATH guards
- 2:04 AM Changeset in webkit [54880] by
-
- 7 edits in trunk/WebCore
2010-02-17 Steve Block <steveblock@google.com>
Reviewed by Ariya Hidayat.
Include WebCore's npruntime.h for Android in V8 bindings
https://bugs.webkit.org/show_bug.cgi?id=35002
Currently, the V8 bindings include bindings/npruntime.h, which is a
Chromium-specific file outside of the WebKit tree.
No new tests, build fix only.
- bindings/v8/NPV8Object.cpp:
- bindings/v8/NPV8Object.h:
- bindings/v8/V8NPObject.h:
- bindings/v8/V8NPUtils.h:
- bindings/v8/npruntime_impl.h:
- bindings/v8/npruntime_priv.h:
- 12:38 AM Changeset in webkit [54879] by
-
- 1 edit7 adds in trunk/WebKitSite
Not reviewed - demo.
Made some examples of using <details> for table descriptions.
- demos/hover-summary: Added.
- demos/hover-summary/details.css: Added.
- demos/hover-summary/details.js: Added.
(summaryClickListener):
():
(window.onload):
- demos/hover-summary/example1.html: Added.
- demos/hover-summary/example2.html: Added.
- demos/hover-summary/horizontal-triangle.png: Added.
- demos/hover-summary/vertical-triangle.png: Added.
- 12:37 AM Changeset in webkit [54878] by
-
- 13 edits in trunk
2010-02-15 Philippe Normand <pnormand@igalia.com>
Reviewed by Gustavo Noronha Silva.
[GStreamer] Should handle BUFFERING messages
https://bugs.webkit.org/show_bug.cgi?id=30004
- configure.ac: Bump gstreamer -core/-plugins-base requirements to 0.10.25 which is the minimum required version for on-disk buffering.
2010-01-07 Philippe Normand <pnormand@igalia.com>
Reviewed by Gustavo Noronha Silva.
[GStreamer] Should handle BUFFERING messages
https://bugs.webkit.org/show_bug.cgi?id=30004
Draw the buffering status in the media controls. The timebar is
now 2 pixels shorter so dragging it at same absolute position than
before produces a seek at a new position in the media, this
explains the rebaselining of the controls-drag-timebar test.
- platform/gtk/media/controls-after-reload-expected.txt:
- platform/gtk/media/controls-drag-timebar-expected.txt:
- platform/gtk/media/controls-strict-expected.txt:
- platform/gtk/media/controls-styling-expected.txt:
- platform/gtk/media/video-controls-rendering-expected.txt: Re-baselined due to 1px left/right border added in controls timeline.
2010-01-07 Philippe Normand <pnormand@igalia.com>
Reviewed by Gustavo Noronha Silva.
[GStreamer] Should handle BUFFERING messages
https://bugs.webkit.org/show_bug.cgi?id=30004
Initial support for on-disk buffering of videos. This works only
for Quicktime and flv though.
- css/mediaControlsGtk.css:
- platform/gtk/RenderThemeGtk.cpp: (WebCore::RenderThemeGtk::paintMediaSliderTrack): Draw the buffering status in the media controls.
- platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::mediaPlayerPrivateMessageCallback): Defer buffering messages handling to processBufferingStats(). (WebCore::bufferingTimeoutCallback): Closure called periodically during the on-disk buffering process. (WebCore::MediaPlayerPrivate::MediaPlayerPrivate): New instance variables and create playbin2 here instead of doing it in load(). (WebCore::MediaPlayerPrivate::~MediaPlayerPrivate): New instance variables. (WebCore::MediaPlayerPrivate::load): Simply set uri on playbin2 instead of creating the pipeline and setting uri all together. (WebCore::MediaPlayerPrivate::processBufferingStats): Start a new timeout source if the player is starting on-disk buffering. (WebCore::MediaPlayerPrivate::queryBufferingStats): Method called 200ms during on-disk buffering to update the maxTimeLoaded and few other private variables. (WebCore::MediaPlayerPrivate::maxTimeSeekable): (WebCore::MediaPlayerPrivate::maxTimeLoaded): (WebCore::MediaPlayerPrivate::bytesLoaded): Fixed implementations regarding buffering. (WebCore::MediaPlayerPrivate::totalBytes): Improved logging. (WebCore::MediaPlayerPrivate::updateStates): Start playback if it was internally paused at beginning of on-disk buffering and set ready/network states depending on the state of the on-disk buffering process. (WebCore::MediaPlayerPrivate::didEnd): Emit durationChanged. (WebCore::MediaPlayerPrivate::setAutobuffer): Edit playbin2 flags property depending on autoBuffer value. (WebCore::MediaPlayerPrivate::createGSTPlayBin): Don't set uri there, it is now done in load().
- platform/graphics/gtk/MediaPlayerPrivateGStreamer.h: New methods and instance variables.
- 12:17 AM Changeset in webkit [54877] by
-
- 1 edit in trunk/WebCore/platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp
Build fix by adding a return statement.
- 12:04 AM Changeset in webkit [54876] by
-
- 2 edits in trunk/LayoutTests
2010-02-17 Xan Lopez <xlopez@igalia.com>
Skip tests requiring new results.
- platform/gtk/Skipped:
Feb 16, 2010:
- 11:56 PM Changeset in webkit [54875] by
-
- 1 edit in trunk/WebKit/win/Interfaces/WebKit.idl
Touch WebKit.idl to fix the build
- 11:38 PM Changeset in webkit [54874] by
-
- 8 edits in trunk/WebKitTools
Some minor check-webkit-style code clean-ups. This revision
contains no new functionality.
Reviewed by Shinichiro Hamaji.
https://bugs.webkit.org/show_bug.cgi?id=34932
- Scripts/check-webkit-style:
- Replaced the call to webkit_argument_defaults() with a default parameter in the ArgumentParser constructor.
- Scripts/webkitpy/style/checker.py:
- Removed the WEBKIT prefix from the default global variables.
- Prefixed several of the global variables with an underscore to reflect that they are used internally.
- Renamed _DEFAULT_FILTER_RULES to _BASE_FILTER_RULES.
- Addressed a FIXME by changing the _PATH_RULES_SPECIFIER configuration from list-tuple pairs to list-list pairs.
- Renamed style_categories() to _all_categories().
- Renamed webkit_argument_defaults() to _check_webkit_style_defaults().
- Renamed the ArgumentDefaults class to DefaultCommandOptionValues.
- In the ArgumentParser class--
- Renamed the doc_print attribute to stderr_write.
- Other minor updates.
- Scripts/webkitpy/style/checker_unittest.py:
- Updated the import statements and unit test classes as necessary.
- Added assertions to test _PATH_RULES_SPECIFIER more fully.
- Scripts/webkitpy/style/error_handlers_unittest.py:
- Updated the unit test classes as necessary.
- Changed StyleErrorHandlerTestBase to store a list of error messages rather than just the last one.
- Scripts/webkitpy/style/filter.py:
- Altered FilterConfiguration._path_rules_from_path() to convert the path_rules list to a tuple.
- Scripts/webkitpy/style/filter_unittest.py:
- Updated the unit tests to reflect the change from tuples to lists in the _PATH_RULES_SPECIFIER configuration variable.
- 11:32 PM Changeset in webkit [54873] by
-
- 32 edits in trunk
2010-02-16 Chris Evans <cevans@chromium.org>
Reviewed by Adam Barth.
Add a new setting which gives the option of assigning every file:///
to its own unique domain.
Test: Pending in forthcoming separate change due to non-trivial
dependencies.
- dom/Document.cpp: (WebCore::Document::initSecurityContext): Place file:/// URI documents into their own unique domains if the new setting requires it.
- page/Settings.h:
- page/Settings.cpp: (WebCore::Settings::setAllowFileAccessFromFileURLs): Simple setter.
- page/SecurityOrigin.h:
- page/SecurityOrigin.cpp: (WebCore::SecurityOrigin::makeUnique): Add simple ability to force an origin to be considered unique.
- 11:12 PM Changeset in webkit [54872] by
-
- 2 edits in trunk/WebCore
2010-02-16 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: drosera/demo.js not syntax highlighted correctly.
- inspector/front-end/SourceTokenizer.js: (WebInspector.SourceTokenizer.Registry): (WebInspector.SourceTokenizer.Registry.prototype.getTokenizer):
- 10:56 PM Changeset in webkit [54871] by
-
- 3 edits in trunk/WebCore
2010-02-16 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: prefer smooth scrolling to instant highlight.
- inspector/front-end/TextViewer.js: (WebInspector.TextViewer): (WebInspector.TextViewer.prototype._scroll): (WebInspector.TextChunk): (WebInspector.TextChunk.prototype._createRow):
- inspector/front-end/textViewer.css:
- 9:57 PM Changeset in webkit [54870] by
-
- 2 edits in trunk/JavaScriptCore
Fix a handful of other leaks seen on the buildbot.
Patch by Gavin Barraclough <barraclough@apple.com> on 2010-02-16
Reviewed by Mark Rowe.
- runtime/UStringImpl.h:
(JSC::UStringOrRopeImpl::deref): Delegate through to the subclass version of deref to ensure that
the correct cleanup takes place. This function previously featured some code that attempted to
skip deletion of static UStringImpl's. Closer inspection revealed that it was in fact equivalent
to "if (false)", meaning that UStringImpl's which had their final deref performed via this function
were leaked.
- 9:26 PM Changeset in webkit [54869] by
-
- 1 edit in trunk/WebCore/platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp
Forgot a .get() because this is an OwnPtr
- 8:55 PM Changeset in webkit [54868] by
-
- 1 edit in trunk/WebCore/platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp
Try using m_qtVideoLayer instead of platformLayer() to fix the build
- 8:21 PM Changeset in webkit [54867] by
-
- 1 edit in trunk/WebCore/platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp
Build fix when Accelerated Compositing is on
- 8:06 PM Changeset in webkit [54866] by
-
- 2 edits in trunk/JavaScriptCore
Fix a handful of leaks seen on the buildbot.
Reviewed by Gavin Barraclough.
- runtime/UStringImpl.h:
(JSC::UStringOrRopeImpl::deref): Call URopeImpl::destructNonRecursive rather than delete
to ensure that the rope's fibers are also destroyed.
- 7:54 PM Changeset in webkit [54865] by
-
- 3 edits6 adds in trunk
2010-02-16 Yael Aharon <yael.aharon@nokia.com>
Reviewed by Nikolas Zimmermann.
SVG not rendered as background-image from data URI
https://bugs.webkit.org/show_bug.cgi?id=33630
- platform/mac/svg/css/background-image-svg-expected.checksum: Added.
- platform/mac/svg/css/background-image-svg-expected.png: Added.
- platform/qt/svg/css/background-image-svg-expected.checksum: Added.
- platform/qt/svg/css/background-image-svg-expected.png: Added.
- svg/css/background-image-svg.html: Added.
- svg/css/background-image-svg-expected.txt: Added.
2010-02-16 Yael Aharon <yael.aharon@nokia.com>
Reviewed by Nikolas Zimmermann.
SVG not rendered as background-image from data URI
https://bugs.webkit.org/show_bug.cgi?id=33630
When the background image is an SVG image, and it is smaller than the area
it is supposed to fill, we were using renderSubTreeToImage to draw it.
That call was not going through all the drawing phases, and so the SVG itself
would not be drawn.
Test: svg/css/background-image-svg.html
- svg/graphics/SVGImage.cpp: (WebCore::SVGImage::nativeImageForCurrentFrame):
- 7:37 PM Changeset in webkit [54864] by
-
- 3 edits in trunk/WebCore
2010-02-16 Bryan Yeung <bryeung@chromium.org>
Reviewed by Nikolas Zimmermann.
Remove the bounds on stroke width and miter for the skia platform.
https://bugs.webkit.org/show_bug.cgi?id=34954
Test: svg/custom/stroke-width-large.svg
- platform/graphics/skia/PlatformContextSkia.cpp: (PlatformContextSkia::setupPaintForStroking):
- 7:27 PM Changeset in webkit [54863] by
-
- 2 edits in trunk/LayoutTests
2010-02-16 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed. Correct typo in test name in Skipped list. Should turn SL slave green again.
- platform/mac-snowleopard/Skipped:
- 7:25 PM Changeset in webkit [54862] by
-
- 1 edit in trunk/WebCore/platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp
Add a missing semicolon
- 7:21 PM Changeset in webkit [54861] by
-
- 5 edits in trunk/WebKit/chromium
2010-02-16 James Hawkins <jhawkins@chromium.org>
Reviewed by Eric Seidel.
[Chromium] Remove calls to releaseRef when passing PassRefPtrs to base
classes. releaseRef releases the original pointer without decreasing
the reference count, and the base class constructor increases the
reference count, leading to a leak.
- src/WebDocument.cpp: (WebKit::WebDocument::WebDocument):
- src/WebElement.cpp: (WebKit::WebElement::WebElement):
- src/WebFormElement.cpp: (WebKit::WebFormElement::WebFormElement):
- src/WebInputElement.cpp: (WebKit::WebInputElement::WebInputElement):
- 7:10 PM Changeset in webkit [54860] by
-
- 3 edits in trunk/LayoutTests
2010-02-16 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed. Attempt to fix win slave. Skip same tests failing on SL, add bug references to skipped list.
- platform/mac-snowleopard/Skipped:
- platform/win/Skipped:
- 7:05 PM Changeset in webkit [54859] by
-
- 3 edits4 adds in trunk
2010-02-16 Bryan Yeung <bryeung@chromium.org>
Reviewed by Nikolas Zimmermann.
Add a new layout test for large stroke widths in SVG.
This regression tests a bug in the Skia platform where the width was
limited to 512.
- platform/mac/svg/custom/stroke-width-large-expected.checksum: Added.
- platform/mac/svg/custom/stroke-width-large-expected.png: Added.
- platform/mac/svg/custom/stroke-width-large-expected.txt: Added.
- svg/custom/stroke-width-large.svg: Added.
2010-02-16 Bryan Yeung <bryeung@chromium.org>
Reviewed by Nikolas Zimmermann.
Remove the bounds on stroke width and miter for the skia platform.
https://bugs.webkit.org/show_bug.cgi?id=34954
Test: svg/custom/stroke-width-large.svg
- platform/graphics/skia/PlatformContextSkia.cpp: (PlatformContextSkia::setupPaintForStroking):
- 6:49 PM Changeset in webkit [54858] by
-
- 3 edits8 adds in trunk
2010-02-16 MORITA Hajime <morrita@gmail.com>
Reviewed by Nikolas Zimmermann.
REGRESSION: SVG text disappaears after double click
https://bugs.webkit.org/show_bug.cgi?id=34880
- platform/mac/svg/text/selection-doubleclick-expected.checksum: Added.
- platform/mac/svg/text/selection-doubleclick-expected.png: Added.
- platform/mac/svg/text/selection-doubleclick-expected.txt: Added.
- platform/mac/svg/text/selection-tripleclick-expected.checksum: Added.
- platform/mac/svg/text/selection-tripleclick-expected.png: Added.
- platform/mac/svg/text/selection-tripleclick-expected.txt: Added.
- svg/text/selection-doubleclick.svg: Added.
- svg/text/selection-tripleclick.svg: Added.
2010-02-16 MORITA Hajime <morrita@gmail.com>
Reviewed by Nikolas Zimmermann.
REGRESSION: SVG text disappaears after double click
https://bugs.webkit.org/show_bug.cgi?id=34880
Tests: svg/text/selection-doubleclick.svg
svg/text/selection-tripleclick.svg
- rendering/SVGRootInlineBox.cpp: (WebCore::SVGRootInlineBoxPaintWalker::mayHaveSelection): Use InlineTextBox::selectionStartEnd() instead of RenderObject::selectionStartEnd() because latter may span multiple comparing startPos and endPos is irrelevant in some cases. former selectionStartEnd() is for single line and comparing startPos and endPos will make sense.
- 6:29 PM Changeset in webkit [54857] by
-
- 4 edits in trunk/WebKit/qt
2010-02-16 Ariya Hidayat <ariya.hidayat@gmail.com>
Reviewed by Simon Hausmann.
[Qt] Allow scrolling to an anchor programmatically.
https://bugs.webkit.org/show_bug.cgi?id=29856
- Api/qwebframe.cpp: (QWebFrame::scrollToAnchor): New API function.
- Api/qwebframe.h:
- tests/qwebframe/tst_qwebframe.cpp: New tests for scrollToAnchor().
- 6:25 PM Changeset in webkit [54856] by
-
- 3 edits in trunk/WebCore
Inspector should display Array lengths in the property lists.
https://bugs.webkit.org/show_bug.cgi?id=20695
Reviewed by Timothy Hatcher.
- inspector/front-end/InjectedScript.js:
(injectedScriptConstructor):
For objects of type 'array' (which includes Arrays, NodeLists, and HTMLCollections), make the length of the object available via propertyLength on the proxy object.
- inspector/front-end/ObjectPropertiesSection.js:
(WebInspector.ObjectPropertyTreeElement.prototype.update):
For properties that have propertyLength defined, append it to the displayed description.
- 6:16 PM Changeset in webkit [54855] by
-
- 3 edits5 adds in trunk
2010-02-16 Yusuke Sato <yusukes@chromium.org>
Reviewed by Dimitri Glazkov.
[Chromium] OpenType font with CFF glyphs is not handled correctly on Windows XP
https://bugs.webkit.org/show_bug.cgi?id=34735
- fast/css/font-face-opentype.html: Added.
- fast/css/resources/Ahem.otf: Added. Ahem font which has CFF glyphs, converted from Ahem.ttf by FontForge (http://fontforge.sourceforge.net/).
- platform/mac/fast/css/font-face-opentype-expected.checksum: Added.
- platform/mac/fast/css/font-face-opentype-expected.png: Added.
- platform/mac/fast/css/font-face-opentype-expected.txt: Added.
2010-02-16 Yusuke Sato <yusukes@chromium.org>
Reviewed by Dimitri Glazkov.
[Chromium] OpenType font with CFF glyphs is not handled correctly on Windows XP
https://bugs.webkit.org/show_bug.cgi?id=34735
Use 0xFFFF as invalidGlyph when fontData is a OpenType font with CFF glyphs.
Test: fast/css/font-face-opentype.html
- platform/graphics/chromium/GlyphPageTreeNodeChromiumWin.cpp: (WebCore::fillBMPGlyphs):
- 6:11 PM Changeset in webkit [54854] by
-
- 2 edits in trunk/WebKit/qt
2010-02-16 Ariya Hidayat <ariya.hidayat@gmail.com>
Reviewed by Laszlo Gombos.
Fix building with Qt < 4.6.
https://bugs.webkit.org/show_bug.cgi?id=34885
- Api/qgraphicswebview.cpp: (QGraphicsWebViewPrivate::updateResizesToContentsForPage):
- 5:51 PM Changeset in webkit [54853] by
-
- 2 edits in trunk/LayoutTests
Change quota-tracking.html to open databases only as they're
needed. Otherwise, open databases end up using more space from
this origin than the test expects.
Reviewed by Simon Fraser.
- storage/quota-tracking.html:
- 5:42 PM Changeset in webkit [54852] by
-
- 2 edits in trunk/LayoutTests
2010-02-16 Simon Fraser <Simon Fraser>
Reviewed by Nikolas Zimmermann.
Make this test more robust to slow-loading media.
- media/video-load-networkState.html:
- 5:33 PM Changeset in webkit [54851] by
-
- 2 edits in trunk/WebCore
- page/MediaCanStartListener.h: Fixed license.
- 5:26 PM Changeset in webkit [54850] by
-
- 2 edits in trunk/LayoutTests
2010-02-16 Nikolas Zimmermann <nzimmermann@rim.com>
Rubber-stamped by Simon Fraser.
Skip svg/zoom/(page|text)/zoom-coords-viewattr-01-b.svg on SnowLeopard.
svg/W3C-SVG-1.1/coords-viewattr* fail on SL and are already Skipped, seems related to entity parsing, not SVG.
- platform/mac-snowleopard/Skipped:
- 5:23 PM Changeset in webkit [54849] by
-
- 15 edits1 add in trunk
2010-02-16 Darin Adler <Darin Adler>
Reviewed by Sam Weinig.
Generalize delayed plug-in start for background tabs for use for other media
https://bugs.webkit.org/show_bug.cgi?id=34981
- WebView.cpp: (WebView::setCanStartPlugins): Change to call setCanStartMedia. In a later patch we can change the of the public function in the IDL file too, but for now this should be enough.
2010-02-16 Darin Adler <Darin Adler>
Reviewed by Sam Weinig.
Generalize delayed plug-in start for background tabs for use for other media
https://bugs.webkit.org/show_bug.cgi?id=34981
- WebView/WebHTMLView.mm: (-[WebHTMLView viewWillMoveToWindow:]): Added comment. (-[WebHTMLView viewDidMoveToWindow]): Ditto.
- WebView/WebView.mm: (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]): Call setCanStartMedia right away so that if this view is not in a window, it will not start any media. (-[WebView viewWillMoveToWindow:]): Call setCanStartMedia(false) when moving to a window of nil. (-[WebView viewDidMoveToWindow]): Call setCanStartMedia(true) when moved to a window that is non-nil.
2010-02-16 Darin Adler <Darin Adler>
Reviewed by Sam Weinig.
Generalize delayed plug-in start for background tabs for use for other media
https://bugs.webkit.org/show_bug.cgi?id=34981
Also did some simple cleanup of HTMLMediaElement to get ready to make it
a client of the same mechanism.
- WebCore.base.exp: Added Page::setCanStartMedia and resorted.
- WebCore.xcodeproj/project.pbxproj: Added MediaCanStartListener.h.
- html/HTMLAudioElement.h: Added an implementation of isVideo since that is now a pure virtual function in HTMLMediaElement. Also made tagPriority private.
- html/HTMLMediaElement.h: Made it clearer that HTMLMediaElement is an abstract base class by making its constructor protected and making the isVideo function a pure virtual function.
- page/Page.cpp: (WebCore::Page::Page): Updated for name change from m_canStartPlugins to m_canStartMedia. (WebCore::Page::addMediaCanStartListener): Renamed and added an assertion. (WebCore::Page::removeUnstartedMedia): Ditto. (WebCore::Page::setCanStartMedia): Renamed plugin to media and moved the code here from PageWin.cpp. The main change from the one in PageWin.cpp is that this function calls mediaCanStart rather than explicitly calling a combination of start and dispatchDidFailToStartPlugin on a PluginView.
- page/Page.h: Re-sorted forward class declarations. Renamed the plugin starting functions to media starting names and changed types from PluginView to MediaCanStartListener.
- page/MediaCanStartListener.h: Added.
- page/win/PageWin.cpp: Moved setCanStartPlugins to the platform-independent Page.cpp file so it can be used for more than just Windows plug-ins.
- plugins/PluginView.cpp: Sorted includes. (WebCore::PluginView::startOrAddToUnstartedList): Use addMediaCanStartListener. (WebCore::PluginView::mediaCanStart): Added. Called when the page decides that media can start. Contains the code that used to be in Page::setCanStartPlugins. (WebCore::PluginView::removeFromUnstartedListIfNecessary): Use removeMediaCanStartListener.
- plugins/PluginView.h: Adopted MediaCanStartListener.
- 4:50 PM Changeset in webkit [54848] by
-
- 3 edits4 adds in trunk
2010-02-16 Simon Fraser <Simon Fraser>
Reviewed by Dan Bernstein.
https://bugs.webkit.org/show_bug.cgi?id=34999
Compositing layers inside overflow:scroll divs are not always updated on scrolling
When RenderLayer::scrollToOffset() updates compositing layer positions, it needs
to start updating at its stacking context rather than just its compositing ancestor.
The stacking context is guaranteed to contain all descendants of the overflow
layer, including those that are not direct descendants of the overflow layer in stacking
(and therefore compositing) order.
Test: compositing/overflow/scroll-ancestor-update.html
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::scrollToOffset):
- 4:25 PM Changeset in webkit [54847] by
-
- 2 edits in trunk/WebKitLibraries
Disable warnings preventing use of anonymous structs/onions -
don't take all my fun toys away, these are useful & awesome!
Reviewed by NOBODY (Build fix).
- win/tools/vsprops/common.vsprops:
- 4:09 PM Changeset in webkit [54846] by
-
- 1 edit1 add in trunk/LayoutTests
2010-02-16 Nikolas Zimmermann <nzimmermann@rim.com>
Rubber-stamped by Dirk Schulze.
Add missing .checksum file in platform/mac/svg/zoom/page. All parts of the original patch for bug 14004 have been landed.
- platform/mac/svg/zoom/page/absolute-sized-document-no-scrollbars-expected.checksum: Added.
- 4:08 PM Changeset in webkit [54845] by
-
- 2 edits in trunk/WebCore
Allow FloatRect::center() to return fractional coordinates. It was
mistakenly converting to integers.
Reviewed by Simon Fraser.
- platform/graphics/FloatRect.h:
(WebCore::FloatRect::center):
- 4:05 PM Changeset in webkit [54844] by
-
- 1 edit74 adds in trunk/LayoutTests
2010-02-16 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by David Hyatt.
SVG units don't stay consistently sized on zoom
https://bugs.webkit.org/show_bug.cgi?id=14004
- platform/mac/svg/zoom: Added.
- platform/mac/svg/zoom/page: Added.
- platform/mac/svg/zoom/page/absolute-sized-document-no-scrollbars-expected.checksum: Added.
- platform/mac/svg/zoom/page/absolute-sized-document-no-scrollbars-expected.png: Added.
- platform/mac/svg/zoom/page/absolute-sized-document-no-scrollbars-expected.txt: Added.
- platform/mac/svg/zoom/page/absolute-sized-document-scrollbars-expected.checksum: Added.
- platform/mac/svg/zoom/page/absolute-sized-document-scrollbars-expected.png: Added.
- platform/mac/svg/zoom/page/absolute-sized-document-scrollbars-expected.txt: Added.
- platform/mac/svg/zoom/page/relative-sized-document-scrollbars-expected.checksum: Added.
- platform/mac/svg/zoom/page/relative-sized-document-scrollbars-expected.png: Added.
- platform/mac/svg/zoom/page/relative-sized-document-scrollbars-expected.txt: Added.
- platform/mac/svg/zoom/page/zoom-coords-viewattr-01-b-expected.checksum: Added.
- platform/mac/svg/zoom/page/zoom-coords-viewattr-01-b-expected.png: Added.
- platform/mac/svg/zoom/page/zoom-coords-viewattr-01-b-expected.txt: Added.
- platform/mac/svg/zoom/page/zoom-foreignObject-expected.checksum: Added.
- platform/mac/svg/zoom/page/zoom-foreignObject-expected.png: Added.
- platform/mac/svg/zoom/page/zoom-foreignObject-expected.txt: Added.
- platform/mac/svg/zoom/page/zoom-hixie-mixed-008-expected.checksum: Added.
- platform/mac/svg/zoom/page/zoom-hixie-mixed-008-expected.png: Added.
- platform/mac/svg/zoom/page/zoom-hixie-mixed-008-expected.txt: Added.
- platform/mac/svg/zoom/page/zoom-hixie-mixed-009-expected.checksum: Added.
- platform/mac/svg/zoom/page/zoom-hixie-mixed-009-expected.png: Added.
- platform/mac/svg/zoom/page/zoom-hixie-mixed-009-expected.txt: Added.
- platform/mac/svg/zoom/page/zoom-hixie-rendering-model-004-expected.checksum: Added.
- platform/mac/svg/zoom/page/zoom-hixie-rendering-model-004-expected.png: Added.
- platform/mac/svg/zoom/page/zoom-hixie-rendering-model-004-expected.txt: Added.
- platform/mac/svg/zoom/page/zoom-svg-float-border-padding-expected.checksum: Added.
- platform/mac/svg/zoom/page/zoom-svg-float-border-padding-expected.png: Added.
- platform/mac/svg/zoom/page/zoom-svg-float-border-padding-expected.txt: Added.
- platform/mac/svg/zoom/text: Added.
- platform/mac/svg/zoom/text/absolute-sized-document-no-scrollbars-expected.checksum: Added.
- platform/mac/svg/zoom/text/absolute-sized-document-no-scrollbars-expected.png: Added.
- platform/mac/svg/zoom/text/absolute-sized-document-no-scrollbars-expected.txt: Added.
- platform/mac/svg/zoom/text/absolute-sized-document-scrollbars-expected.checksum: Added.
- platform/mac/svg/zoom/text/absolute-sized-document-scrollbars-expected.png: Added.
- platform/mac/svg/zoom/text/absolute-sized-document-scrollbars-expected.txt: Added.
- platform/mac/svg/zoom/text/relative-sized-document-scrollbars-expected.checksum: Added.
- platform/mac/svg/zoom/text/relative-sized-document-scrollbars-expected.png: Added.
- platform/mac/svg/zoom/text/relative-sized-document-scrollbars-expected.txt: Added.
- platform/mac/svg/zoom/text/zoom-coords-viewattr-01-b-expected.checksum: Added.
- platform/mac/svg/zoom/text/zoom-coords-viewattr-01-b-expected.png: Added.
- platform/mac/svg/zoom/text/zoom-coords-viewattr-01-b-expected.txt: Added.
- platform/mac/svg/zoom/text/zoom-foreignObject-expected.checksum: Added.
- platform/mac/svg/zoom/text/zoom-foreignObject-expected.png: Added.
- platform/mac/svg/zoom/text/zoom-foreignObject-expected.txt: Added.
- platform/mac/svg/zoom/text/zoom-hixie-mixed-008-expected.checksum: Added.
- platform/mac/svg/zoom/text/zoom-hixie-mixed-008-expected.png: Added.
- platform/mac/svg/zoom/text/zoom-hixie-mixed-008-expected.txt: Added.
- platform/mac/svg/zoom/text/zoom-hixie-mixed-009-expected.checksum: Added.
- platform/mac/svg/zoom/text/zoom-hixie-mixed-009-expected.png: Added.
- platform/mac/svg/zoom/text/zoom-hixie-mixed-009-expected.txt: Added.
- platform/mac/svg/zoom/text/zoom-hixie-rendering-model-004-expected.checksum: Added.
- platform/mac/svg/zoom/text/zoom-hixie-rendering-model-004-expected.png: Added.
- platform/mac/svg/zoom/text/zoom-hixie-rendering-model-004-expected.txt: Added.
- platform/mac/svg/zoom/text/zoom-svg-float-border-padding-expected.checksum: Added.
- platform/mac/svg/zoom/text/zoom-svg-float-border-padding-expected.png: Added.
- platform/mac/svg/zoom/text/zoom-svg-float-border-padding-expected.txt: Added.
- svg/zoom: Added.
- svg/zoom/NOTE: Added.
- svg/zoom/page: Added.
- svg/zoom/page/absolute-sized-document-no-scrollbars.svg: Added.
- svg/zoom/page/absolute-sized-document-scrollbars.svg: Added.
- svg/zoom/page/relative-sized-document-scrollbars.svg: Added.
- svg/zoom/page/zoom-coords-viewattr-01-b.svg: Added.
- svg/zoom/page/zoom-foreignObject.svg: Added.
- svg/zoom/page/zoom-hixie-mixed-008.xml: Added.
- svg/zoom/page/zoom-hixie-mixed-009.xml: Added.
- svg/zoom/page/zoom-hixie-rendering-model-004.xhtml: Added.
- svg/zoom/page/zoom-svg-float-border-padding.xml: Added.
- svg/zoom/resources: Added.
- svg/zoom/resources/testPageZoom.js: Added.
- svg/zoom/resources/testTextZoom.js: Added.
- svg/zoom/text: Added.
- svg/zoom/text/absolute-sized-document-no-scrollbars.svg: Added.
- svg/zoom/text/absolute-sized-document-scrollbars.svg: Added.
- svg/zoom/text/relative-sized-document-scrollbars.svg: Added.
- svg/zoom/text/zoom-coords-viewattr-01-b.svg: Added.
- svg/zoom/text/zoom-foreignObject.svg: Added.
- svg/zoom/text/zoom-hixie-mixed-008.xml: Added.
- svg/zoom/text/zoom-hixie-mixed-009.xml: Added.
- svg/zoom/text/zoom-hixie-rendering-model-004.xhtml: Added.
- svg/zoom/text/zoom-svg-float-border-padding.xml: Added.
- 4:01 PM Changeset in webkit [54843] by
-
- 16 edits in trunk
https://bugs.webkit.org/show_bug.cgi?id=34964
Leaks tool reports false memory leaks due to Rope implementation.
Reviewed by Oliver Hunt.
A rope is a recursive data structure where each node in the rope holds a set of
pointers, each of which may reference either a string (in UStringImpl form) or
another rope node. A low bit in each pointer is used to distinguish between
rope & string elements, in a fashion similar to the recently-removed
PtrAndFlags class (see https://bugs.webkit.org/show_bug.cgi?id=33731 ). Again,
this causes a problem for Leaks – refactor to remove the magic pointer
mangling.
Move Rope out from JSString.h and rename to URopeImpl, to match UStringImpl.
Give UStringImpl and URopeImpl a common parent class, UStringOrRopeImpl.
Repurpose an otherwise invalid permutation to flags (static & should report
memory cost) to identify ropes.
This allows us to change the rope's fibers to interrogate the object rather
than storing a bool within the low bits of the pointer (or in some cases the
use of a common parent class removes the need to determine the type at all -
there is a common interface to ref or get the length of either ropes or strings).
- API/JSClassRef.cpp:
(OpaqueJSClass::OpaqueJSClass):
(OpaqueJSClassContextData::OpaqueJSClassContextData):
- bytecompiler/BytecodeGenerator.cpp:
(JSC::keyForCharacterSwitch):
- interpreter/Interpreter.cpp:
(JSC::Interpreter::privateExecute):
- jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
- runtime/ArrayPrototype.cpp:
(JSC::arrayProtoFuncToString):
- runtime/Identifier.cpp:
(JSC::Identifier::equal):
(JSC::Identifier::addSlowCase):
- runtime/JSString.cpp:
(JSC::JSString::resolveRope):
- runtime/JSString.h:
(JSC::):
(JSC::RopeBuilder::JSString):
(JSC::RopeBuilder::~JSString):
(JSC::RopeBuilder::appendStringInConstruct):
(JSC::RopeBuilder::appendValueInConstructAndIncrementLength):
(JSC::RopeBuilder::JSStringFinalizerStruct::JSStringFinalizerStruct):
(JSC::RopeBuilder::JSStringFinalizerStruct::):
- runtime/UString.cpp:
(JSC::UString::toStrictUInt32):
(JSC::equal):
- runtime/UString.h:
(JSC::UString::isEmpty):
(JSC::UString::size):
- runtime/UStringImpl.cpp:
(JSC::URopeImpl::derefFibersNonRecursive):
(JSC::URopeImpl::destructNonRecursive):
- runtime/UStringImpl.h:
(JSC::UStringOrRopeImpl::isRope):
(JSC::UStringOrRopeImpl::length):
(JSC::UStringOrRopeImpl::ref):
(JSC::UStringOrRopeImpl::):
(JSC::UStringOrRopeImpl::operator new):
(JSC::UStringOrRopeImpl::UStringOrRopeImpl):
(JSC::UStringImpl::adopt):
(JSC::UStringImpl::createUninitialized):
(JSC::UStringImpl::tryCreateUninitialized):
(JSC::UStringImpl::data):
(JSC::UStringImpl::cost):
(JSC::UStringImpl::deref):
(JSC::UStringImpl::UStringImpl):
(JSC::UStringImpl::):
(JSC::URopeImpl::tryCreateUninitialized):
(JSC::URopeImpl::initializeFiber):
(JSC::URopeImpl::fiberCount):
(JSC::URopeImpl::fibers):
(JSC::URopeImpl::deref):
(JSC::URopeImpl::URopeImpl):
(JSC::URopeImpl::hasOneRef):
(JSC::UStringOrRopeImpl::deref):
WebCore:
Renamed cUStringImpl::size() to UStringImpl::size()UStringImpl::length()
(matches WebCore::StringImpl).
- bridge/jni/jsc/JavaStringJSC.h:
(JSC::Bindings::JavaStringImpl::length):
- platform/text/AtomicString.cpp:
(WebCore::AtomicString::add):
(WebCore::AtomicString::find):
- 3:55 PM Changeset in webkit [54842] by
-
- 2 edits in trunk/LayoutTests
[Qt] REGRESSION(r54811) fast/canvas/drawImage-with-negative-source-destination.html fails
https://bugs.webkit.org/show_bug.cgi?id=35005
- platform/qt/Skipped:
- fast/canvas/drawImage-with-negative-source-destination.html skipped until fix.
- inspector/timeline-paint.html skipped because it is flakey.
- 3:49 PM Changeset in webkit [54841] by
-
- 2 edits in trunk/WebCore
<rdar://problem/7288853> Message about missing plugin does not specify
the type or download link for download
Reviewed by Mark Rowe.
- plugins/PluginDatabase.cpp:
(WebCore::PluginDatabase::findPlugin):
Only update the mimeType out param if we find a plug-in for the file
extension.
- 3:41 PM Changeset in webkit [54840] by
-
- 2 edits in trunk/WebCore
2010-02-16 Simon Fraser <Simon Fraser>
Build fix for Tiger.
Add #if USE(ACCELERATED_COMPOSITING) around the call to mediaPlayerRenderingModeChanged().
- platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::setUpVideoRendering):
- 3:03 PM Changeset in webkit [54839] by
-
- 2 edits in trunk/WebCore
Buildfix for r54826.
Reviewed by Eric Carlson.
HTMLMediaElement class defined by HTMLMediaElement.h in #if ENABLE(VIDEO) block,
it should be in #if ENABLE(VIDEO) block in rendering/RenderLayerBacking.cpp too.
- rendering/RenderLayerBacking.cpp: Missing #if ENABLE(VIDEO) guard added.
(WebCore::RenderLayerBacking::updateGraphicsLayerConfiguration):
- 3:02 PM Changeset in webkit [54838] by
-
- 6 edits75 deletes in trunk
Roll out the rest of r54833 as it includes more unrelated changes.
- 3:00 PM Changeset in webkit [54837] by
-
- 2 edits in trunk/WebKitTools
Let's not check garbage in to common build scripts and hose the world now eh guys?
- Scripts/webkitdirs.pm:
- 2:56 PM Changeset in webkit [54836] by
-
- 2 edits in trunk/WebCore
Unreviewed: Chromium build fix.
http://trac.webkit.org/changeset/54823 introduced an unused variable. Remove it.
- platform/image-decoders/ImageDecoder.cpp:
(WebCore::ImageDecoder::create):
- 2:53 PM Changeset in webkit [54835] by
-
- 9 edits in trunk/WebCore
Bug 34974: Leak of ScheduledAction during layout tests
<https://bugs.webkit.org/show_bug.cgi?id=34974>
Reviewed by Alexey Proskuryakov.
ScheduledAction::create was returning a raw pointer which was threaded down through to an OwnPtr in DOMTimer.
If any of the code paths in between hit an error case and returned early the raw pointer would be leaked. We
can avoid this by passing it as a PassOwnPtr. This will ensure that the ScheduledAction is cleaned up should
an error case be hit.
- bindings/js/JSDOMWindowCustom.cpp:
(WebCore::JSDOMWindow::setTimeout): Store the newly-created ScheduledAction in an OwnPtr and then hand it off
as the function argument.
(WebCore::JSDOMWindow::setInterval): Ditto.
- bindings/js/JSWorkerContextCustom.cpp:
(WebCore::JSWorkerContext::setTimeout): Ditto.
(WebCore::JSWorkerContext::setInterval): Ditto.
- bindings/js/ScheduledAction.cpp:
(WebCore::ScheduledAction::create): Return a PassOwnPtr.
- bindings/js/ScheduledAction.h:
- page/DOMTimer.cpp:
(WebCore::DOMTimer::DOMTimer): Update argument type.
(WebCore::DOMTimer::install): Ditto.
- page/DOMTimer.h:
- page/DOMWindow.cpp:
(WebCore::DOMWindow::setTimeout): Ditto.
(WebCore::DOMWindow::setInterval): Ditto.
- page/DOMWindow.h:
- 2:51 PM Changeset in webkit [54834] by
-
- 9 edits in trunk/WebCore
2010-02-16 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by David Hyatt.
SVG units don't stay consistently sized on zoom
https://bugs.webkit.org/show_bug.cgi?id=14004
Large step towards making WebKit an usable SVG viewer.
Make zooming into SVG documents work as expected, in both standalone and XHTML/SVG compound documents.
SVG applies a global scale to the document, whereas CSS zooms all individual length units (on full-page-zoom).
Scaling has to be avoided for all SVG specific CSS properties (already works) and for some selected CSS
properties shared between CSS & SVG that explicitely need a different treatment in the context of SVG.
To name a few: font-size, letter-spacing, etc. should stay invariant under zoom in SVG document fragments.
Some new rules regarding zooming:
- "Zoom text only" should never affect SVG documents, neither text nor content should zoom. This option doesn't make much sense for SVG, so it's wise to avoid side-effects and disable it. In compound documents the SVG would stay as-is and only text of surrounding XHTML content would zoom.
- "Full page zoom" is the only zoom mode affecting SVG. (Panning only works in standalone documents.)
Cover all mentioned cases above by a new set of layout tests.
Tests: svg/zoom/page/absolute-sized-document-no-scrollbars.svg
svg/zoom/page/absolute-sized-document-scrollbars.svg
svg/zoom/page/relative-sized-document-scrollbars.svg
svg/zoom/page/zoom-coords-viewattr-01-b.svg
svg/zoom/page/zoom-foreignObject.svg
svg/zoom/page/zoom-hixie-mixed-008.xml
svg/zoom/page/zoom-hixie-mixed-009.xml
svg/zoom/page/zoom-hixie-rendering-model-004.xhtml
svg/zoom/page/zoom-svg-float-border-padding.xml
svg/zoom/text/absolute-sized-document-no-scrollbars.svg
svg/zoom/text/absolute-sized-document-scrollbars.svg
svg/zoom/text/relative-sized-document-scrollbars.svg
svg/zoom/text/zoom-coords-viewattr-01-b.svg
svg/zoom/text/zoom-foreignObject.svg
svg/zoom/text/zoom-hixie-mixed-008.xml
svg/zoom/text/zoom-hixie-mixed-009.xml
svg/zoom/text/zoom-hixie-rendering-model-004.xhtml
svg/zoom/text/zoom-svg-float-border-padding.xml
- css/CSSStyleSelector.cpp: Blacklist certain properties not to be zoomed for SVG elements. (WebCore::CSSStyleSelector::styleForDocument): Don't zoom font-sizes. (WebCore::CSSStyleSelector::applyProperty): Ditto (+ letter/word-spacing). (WebCore::CSSStyleSelector::setFontSize): Ditto. (WebCore::CSSStyleSelector::getComputedSizeFromSpecifiedSize): Never apply text zoom to SVG.
- css/CSSStyleSelector.h:
- css/SVGCSSStyleSelector.cpp: -webkit-shadow + SVG was incorrectly respecting zoom factor. (WebCore::CSSStyleSelector::applySVGProperty):
- page/Frame.cpp: (WebCore::Frame::shouldApplyTextZoom): Remove SVG special cases. (WebCore::Frame::shouldApplyPageZoom): Ditto. (WebCore::Frame::setZoomFactor): Don't force setZoomsTextOnly() - SVG now uses FPZ as well.
- rendering/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::calcReplacedWidth): CSSPropertyWidth is explicitely not scaled by CSSStyleSelector, fix that for outermost <svg> elements. (WebCore::RenderSVGRoot::calcReplacedHeight): Ditto for CSSPropertyHeight. (WebCore::RenderSVGRoot::layout): Simplify & cleanup code, take advantage of new calcWidth/Height functionality, no need to scale anything here. (WebCore::RenderSVGRoot::paint): Use parentOriginToBorderBox() instead of duplicating code. (WebCore::RenderSVGRoot::calcViewport): Simplify code. (WebCore::RenderSVGRoot::localToBorderBoxTransform): Calculate viewBoxToViewTransformation() against unscaled width()/height() values.
- rendering/RenderSVGRoot.h:
- svg/SVGLength.cpp: (WebCore::SVGLength::PercentageOfViewport): Cleanup & document function.
- svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::currentScale): Return pageZoomFactor(), not just the zoomFactor() - as we want to ignore text-only zoom. (WebCore::SVGSVGElement::setCurrentScale): Pass isTextOnly=false to setZoomFactor().
- 2:46 PM Changeset in webkit [54833] by
-
- 7 edits82 adds in trunk
2010-02-16 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by David Hyatt.
SVG units don't stay consistently sized on zoom
https://bugs.webkit.org/show_bug.cgi?id=14004
- platform/mac/svg/zoom: Added.
- platform/mac/svg/zoom/page: Added.
- platform/mac/svg/zoom/page/absolute-sized-document-no-scrollbars-expected.checksum: Added.
- platform/mac/svg/zoom/page/absolute-sized-document-no-scrollbars-expected.png: Added.
- platform/mac/svg/zoom/page/absolute-sized-document-no-scrollbars-expected.txt: Added.
- platform/mac/svg/zoom/page/absolute-sized-document-scrollbars-expected.checksum: Added.
- platform/mac/svg/zoom/page/absolute-sized-document-scrollbars-expected.png: Added.
- platform/mac/svg/zoom/page/absolute-sized-document-scrollbars-expected.txt: Added.
- platform/mac/svg/zoom/page/relative-sized-document-scrollbars-expected.checksum: Added.
- platform/mac/svg/zoom/page/relative-sized-document-scrollbars-expected.png: Added.
- platform/mac/svg/zoom/page/relative-sized-document-scrollbars-expected.txt: Added.
- platform/mac/svg/zoom/page/zoom-coords-viewattr-01-b-expected.checksum: Added.
- platform/mac/svg/zoom/page/zoom-coords-viewattr-01-b-expected.png: Added.
- platform/mac/svg/zoom/page/zoom-coords-viewattr-01-b-expected.txt: Added.
- platform/mac/svg/zoom/page/zoom-foreignObject-expected.checksum: Added.
- platform/mac/svg/zoom/page/zoom-foreignObject-expected.png: Added.
- platform/mac/svg/zoom/page/zoom-foreignObject-expected.txt: Added.
- platform/mac/svg/zoom/page/zoom-hixie-mixed-008-expected.checksum: Added.
- platform/mac/svg/zoom/page/zoom-hixie-mixed-008-expected.png: Added.
- platform/mac/svg/zoom/page/zoom-hixie-mixed-008-expected.txt: Added.
- platform/mac/svg/zoom/page/zoom-hixie-mixed-009-expected.checksum: Added.
- platform/mac/svg/zoom/page/zoom-hixie-mixed-009-expected.png: Added.
- platform/mac/svg/zoom/page/zoom-hixie-mixed-009-expected.txt: Added.
- platform/mac/svg/zoom/page/zoom-hixie-rendering-model-004-expected.checksum: Added.
- platform/mac/svg/zoom/page/zoom-hixie-rendering-model-004-expected.png: Added.
- platform/mac/svg/zoom/page/zoom-hixie-rendering-model-004-expected.txt: Added.
- platform/mac/svg/zoom/page/zoom-svg-float-border-padding-expected.checksum: Added.
- platform/mac/svg/zoom/page/zoom-svg-float-border-padding-expected.png: Added.
- platform/mac/svg/zoom/page/zoom-svg-float-border-padding-expected.txt: Added.
- platform/mac/svg/zoom/text: Added.
- platform/mac/svg/zoom/text/absolute-sized-document-no-scrollbars-expected.checksum: Added.
- platform/mac/svg/zoom/text/absolute-sized-document-no-scrollbars-expected.png: Added.
- platform/mac/svg/zoom/text/absolute-sized-document-no-scrollbars-expected.txt: Added.
- platform/mac/svg/zoom/text/absolute-sized-document-scrollbars-expected.checksum: Added.
- platform/mac/svg/zoom/text/absolute-sized-document-scrollbars-expected.png: Added.
- platform/mac/svg/zoom/text/absolute-sized-document-scrollbars-expected.txt: Added.
- platform/mac/svg/zoom/text/relative-sized-document-scrollbars-expected.checksum: Added.
- platform/mac/svg/zoom/text/relative-sized-document-scrollbars-expected.png: Added.
- platform/mac/svg/zoom/text/relative-sized-document-scrollbars-expected.txt: Added.
- platform/mac/svg/zoom/text/zoom-coords-viewattr-01-b-expected.checksum: Added.
- platform/mac/svg/zoom/text/zoom-coords-viewattr-01-b-expected.png: Added.
- platform/mac/svg/zoom/text/zoom-coords-viewattr-01-b-expected.txt: Added.
- platform/mac/svg/zoom/text/zoom-foreignObject-expected.checksum: Added.
- platform/mac/svg/zoom/text/zoom-foreignObject-expected.png: Added.
- platform/mac/svg/zoom/text/zoom-foreignObject-expected.txt: Added.
- platform/mac/svg/zoom/text/zoom-hixie-mixed-008-expected.checksum: Added.
- platform/mac/svg/zoom/text/zoom-hixie-mixed-008-expected.png: Added.
- platform/mac/svg/zoom/text/zoom-hixie-mixed-008-expected.txt: Added.
- platform/mac/svg/zoom/text/zoom-hixie-mixed-009-expected.checksum: Added.
- platform/mac/svg/zoom/text/zoom-hixie-mixed-009-expected.png: Added.
- platform/mac/svg/zoom/text/zoom-hixie-mixed-009-expected.txt: Added.
- platform/mac/svg/zoom/text/zoom-hixie-rendering-model-004-expected.checksum: Added.
- platform/mac/svg/zoom/text/zoom-hixie-rendering-model-004-expected.png: Added.
- platform/mac/svg/zoom/text/zoom-hixie-rendering-model-004-expected.txt: Added.
- platform/mac/svg/zoom/text/zoom-svg-float-border-padding-expected.checksum: Added.
- platform/mac/svg/zoom/text/zoom-svg-float-border-padding-expected.png: Added.
- platform/mac/svg/zoom/text/zoom-svg-float-border-padding-expected.txt: Added.
- svg/zoom: Added.
- svg/zoom/NOTE: Added.
- svg/zoom/page: Added.
- svg/zoom/page/absolute-sized-document-no-scrollbars.svg: Added.
- svg/zoom/page/absolute-sized-document-scrollbars.svg: Added.
- svg/zoom/page/relative-sized-document-scrollbars.svg: Added.
- svg/zoom/page/zoom-coords-viewattr-01-b.svg: Added.
- svg/zoom/page/zoom-foreignObject.svg: Added.
- svg/zoom/page/zoom-hixie-mixed-008.xml: Added.
- svg/zoom/page/zoom-hixie-mixed-009.xml: Added.
- svg/zoom/page/zoom-hixie-rendering-model-004.xhtml: Added.
- svg/zoom/page/zoom-svg-float-border-padding.xml: Added.
- svg/zoom/resources: Added.
- svg/zoom/resources/testPageZoom.js: Added.
- svg/zoom/resources/testTextZoom.js: Added.
- svg/zoom/text: Added.
- svg/zoom/text/absolute-sized-document-no-scrollbars.svg: Added.
- svg/zoom/text/absolute-sized-document-scrollbars.svg: Added.
- svg/zoom/text/relative-sized-document-scrollbars.svg: Added.
- svg/zoom/text/zoom-coords-viewattr-01-b.svg: Added.
- svg/zoom/text/zoom-foreignObject.svg: Added.
- svg/zoom/text/zoom-hixie-mixed-008.xml: Added.
- svg/zoom/text/zoom-hixie-mixed-009.xml: Added.
- svg/zoom/text/zoom-hixie-rendering-model-004.xhtml: Added.
- svg/zoom/text/zoom-svg-float-border-padding.xml: Added.
- 2:44 PM Changeset in webkit [54832] by
-
- 2 edits in trunk/WebKit/mac
2010-02-16 Eric Carlson <eric.carlson@apple.com>
Reviewed by Simon Fraser.
https://bugs.webkit.org/show_bug.cgi?id=34988
WebHTMLView.mm has two -willRemoveSubview: methods
- WebView/WebHTMLView.mm: (-[WebHTMLView willRemoveSubview:]): Consolidate the two copies of this method.
- 2:30 PM Changeset in webkit [54831] by
-
- 2 edits in trunk/WebCore
Unreviewed: Chromium build fix.
https://bugs.webkit.org/show_bug.cgi?id=34998
Move include of JavaScriptProfile.h behind if (USE_JSC).
- inspector/InspectorController.cpp:
- 2:21 PM Changeset in webkit [54830] by
-
- 3 edits2 adds in trunk/WebKitTools
2010-02-16 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
re-factor Skipped list parsing code into multiple functions and unit test it
https://bugs.webkit.org/show_bug.cgi?id=34986
- Scripts/test-webkitpy: Add new unit test.
- Scripts/webkitpy/layout_tests/init.py: Copied from WebKitTools/QueueStatusServer/filters/init.py.
- Scripts/webkitpy/layout_tests/port/mac.py: Split parsing function into multiple functions for testing.
- Scripts/webkitpy/layout_tests/port/mac_unittest.py: Added.
- 2:16 PM Changeset in webkit [54829] by
-
- 9 edits in trunk
Reviewed by Geoffrey Garen and Kevin Decker.
https://bugs.webkit.org/show_bug.cgi?id=34989
<rdar://problem/7417965> Cursor disappears on scroll bars that are over plugin content
This fixes event dispatch for both Cocoa and Carbon event models (mouseEntered/mouseExited
in the former case, and adjustCursor in the latter).
- Plugins/Hosted/WebHostedNetscapePluginView.mm: (-[WebHostedNetscapePluginView handleMouseEntered:]): (-[WebHostedNetscapePluginView handleMouseExited:]):
- Plugins/WebBaseNetscapePluginView.h:
- Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView handleMouseEntered:]): (-[WebBaseNetscapePluginView handleMouseExited:]):
- Plugins/WebNetscapePluginView.h:
- Plugins/WebNetscapePluginView.mm: (-[WebNetscapePluginView handleMouseEntered:]): (-[WebNetscapePluginView handleMouseExited:]): AppKit cannot reliably dispatch events for overlapping views. We are now asking WebCore to notify plug-in views of mouse entered/exited as part of DOM event dispatch.
- WebCoreSupport/WebFrameLoaderClient.mm: (NetscapePluginWidget::handleEvent): Besides mouse moved, dispatch plugin mouse entered/exit events in HTMLPlugInElement default event handler. Other mouse events are passed down by EventHandler.
- 2:04 PM Changeset in webkit [54828] by
-
- 4 edits2 adds in trunk/WebCore
2010-02-16 Simon Fraser <Simon Fraser>
Reviewed by Eric Carlson.
With hardware acceleration turned off, video frames never display if poster
image is specified
https://bugs.webkit.org/show_bug.cgi?id=34965
HTMLVideoElement's m_shouldDisplayPosterImage was never updated after
the movie supplied its first video frame, so the poster would continue to show.
Fixed by calling updatePosterImage() from mediaPlayerRepaint(), which is called
each time a new frame is available. updatePosterImage() is cheap.
Also made updatePosterImage() virtual on HTMLMediaElement to avoid a number of
ugly casts.
Test: manual-tests/media-elements/video-replaces-poster.html
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::noneSupported): Call updatePosterImage() without video check. (WebCore::HTMLMediaElement::setNetworkState): Ditto. (WebCore::HTMLMediaElement::setReadyState): Ditto. (WebCore::HTMLMediaElement::mediaPlayerRepaint): Call udpatePosterImage().
- html/HTMLMediaElement.h: (WebCore::HTMLMediaElement::updatePosterImage): Make this an empty virtual method on the base class.
- html/HTMLVideoElement.h: Override updatePosterImage().
- 1:55 PM Changeset in webkit [54827] by
-
- 2 edits in trunk/WebCore
2010-02-16 Simon Fraser <Simon Fraser>
Build fix for platforms without ACCELERATED_COMPOSITING defined.
mediaPlayerRenderingModeChanged() is only available when ACCELERATED_COMPOSITING is defined.
- platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp: (WebCore::MediaPlayerPrivate::setUpVideoRendering):
- 1:46 PM Changeset in webkit [54826] by
-
- 14 edits4 adds in trunk
2010-02-16 Simon Fraser <Simon Fraser>
Reviewed by Eric Carlson.
Autoplaying video with poster doesn't reliably show up
https://bugs.webkit.org/show_bug.cgi?id=34966
A timing issue with compositing updates when replacing the poster image
with the video could cause the video to not display.
Fix by making video layer hook up more similar to WebGL etc, by having the
video kick off a recalcStyle() via a SyntheticStyleChange. This requires
vending a PlaformLayer* from the media player, up through the element.
Test: media/video-replaces-poster.html
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::mediaPlayerRenderingModeChanged): Use setNeedsStyleRecalc() to kick off a compositing update.
- html/HTMLMediaElement.h: (WebCore::HTMLMediaElement::platformLayer): Export the media engine's layer.
- platform/graphics/MediaPlayer.cpp: (WebCore::NullMediaPlayerPrivate::platformLayer): Method to vend the media layer. (WebCore::MediaPlayer::platformLayer):
- platform/graphics/MediaPlayer.h: (WebCore::MediaPlayerClient::mediaPlayerRenderingModeChanged): New client callback to indicate that the rendering mode changed. The element uses this to kick off a recalcStyle.
- platform/graphics/MediaPlayerPrivate.h: (WebCore::MediaPlayerPrivateInterface::platformLayer): Method to vend the media layer.
- platform/graphics/mac/MediaPlayerPrivateQTKit.h: Ditto
- platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::createQTMovieLayer): No longer parent the layer directly via setContentsToMedia(). (WebCore::MediaPlayerPrivate::acceleratedRenderingStateChanged): Ditto. (WebCore::MediaPlayerPrivate::setUpVideoRendering): Tell the client that the rendering mode changed. (WebCore::MediaPlayerPrivate::platformLayer): Method to vend the media layer.
- rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::updateGraphicsLayerConfiguration): Call setContentsToMedia() here.
- platform/graphics/win/MediaPlayerPrivateQuickTimeWin.h: Add platformLayer().
- platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp: (WebCore::MediaPlayerPrivate::platformLayer): Method to vend the media layer. (WebCore::MediaPlayerPrivate::setUpVideoRendering): Call mediaPlayerRenderingModeChanged() (WebCore::MediaPlayerPrivate::createLayerForMovie): Don't parent the layer ourselves any more.
- rendering/RenderVideo.h: videoGraphicsLayer() is no longer needed.
- rendering/RenderVideo.cpp: Ditto.
- 1:06 PM Changeset in webkit [54825] by
-
- 15 edits in trunk/WebKit/gtk/po
2010-02-16 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Refreshed all localization-related files, so that they are
up-to-date with the code.
- de.po: Updated.
- en_GB.po: Updated.
- es.po: Updated.
- it.po: Updated.
- lt.po: Updated.
- nl.po: Updated.
- pt_BR.po: Updated.
- ru.po: Updated.
- sr.po: Updated.
- sr@latin.po: Updated.
- sv.po: Updated.
- vi.po: Updated.
- webkit.pot: Updated.
- zh_CN.po: Updated.
- 1:06 PM Changeset in webkit [54824] by
-
- 1 edit1 add in trunk/WebKit/gtk/po
2010-02-16 Gil Osher <gilosher@gmail.com>
Reviewed by Gustavo Noronha.
Localization of WebKitGTK+ in Hebrew.
- he.po: Added.
- 12:50 PM Changeset in webkit [54823] by
-
- 19 edits in trunk/WebCore
Code cleanup in ImageDecoders; no functional change.
https://bugs.webkit.org/show_bug.cgi?id=28751
Reviewed by Adam Barth.
- Make code mostly comply with the style guide (switch indenting, use of "!" vs. "== 0", don't unnecessarily wrap lines, etc.)
- Eliminate m_allDataReceived in ICO/BMP decoders since it's in the base ImageDecoder class
- Remove some useless or wrong comments, add others
- Wrap comments at 80 columns (most already were) for consistency/readability
- Avoid casts by using correct variable types
- Consistent naming of decode() function/args
- Shorter code in some places
- Make declaration and definition order match
- platform/graphics/qt/ImageDecoderQt.cpp:
(WebCore::ImageDecoderQt::frameCount):
(WebCore::ImageDecoderQt::frameBufferAtIndex):
(WebCore::ImageDecoderQt::forceLoadEverything):
- platform/image-decoders/ImageDecoder.cpp:
(WebCore::ImageDecoder::create):
(WebCore::RGBA32Buffer::clear):
(WebCore::RGBA32Buffer::setSize):
- platform/image-decoders/ImageDecoder.h:
(WebCore::RGBA32Buffer::):
(WebCore::ImageDecoder::ImageDecoder):
- platform/image-decoders/bmp/BMPImageDecoder.cpp:
(WebCore::BMPImageDecoder::BMPImageDecoder):
(WebCore::BMPImageDecoder::setData):
(WebCore::BMPImageDecoder::isSizeAvailable):
(WebCore::BMPImageDecoder::frameBufferAtIndex):
(WebCore::BMPImageDecoder::decode):
(WebCore::BMPImageDecoder::decodeHelper):
(WebCore::BMPImageDecoder::processFileHeader):
- platform/image-decoders/bmp/BMPImageDecoder.h:
(WebCore::BMPImageDecoder::readUint32):
- platform/image-decoders/bmp/BMPImageReader.cpp:
(WebCore::BMPImageReader::BMPImageReader):
(WebCore::BMPImageReader::decodeBMP):
(WebCore::BMPImageReader::readInfoHeaderSize):
(WebCore::BMPImageReader::processInfoHeader):
(WebCore::BMPImageReader::readInfoHeader):
(WebCore::BMPImageReader::isInfoHeaderValid):
(WebCore::BMPImageReader::processBitmasks):
(WebCore::BMPImageReader::processColorTable):
(WebCore::BMPImageReader::processRLEData):
(WebCore::BMPImageReader::processNonRLEData):
- platform/image-decoders/bmp/BMPImageReader.h:
(WebCore::BMPImageReader::readUint32):
(WebCore::BMPImageReader::pastEndOfImage):
(WebCore::BMPImageReader::readCurrentPixel):
(WebCore::BMPImageReader::getComponent):
(WebCore::BMPImageReader::getAlpha):
(WebCore::BMPImageReader::setI):
(WebCore::BMPImageReader::setRGBA):
- platform/image-decoders/gif/GIFImageDecoder.cpp:
(WebCore::GIFImageDecoder::GIFImageDecoder):
(WebCore::GIFImageDecoder::setData):
(WebCore::GIFImageDecoder::isSizeAvailable):
(WebCore::GIFImageDecoder::frameCount):
(WebCore::GIFImageDecoder::frameBufferAtIndex):
(WebCore::GIFImageDecoder::clearFrameBufferCache):
(WebCore::GIFImageDecoder::sizeNowAvailable):
(WebCore::GIFImageDecoder::haveDecodedRow):
(WebCore::GIFImageDecoder::frameComplete):
(WebCore::GIFImageDecoder::decode):
(WebCore::GIFImageDecoder::initFrameBuffer):
- platform/image-decoders/gif/GIFImageDecoder.h:
(WebCore::GIFImageDecoder::):
(WebCore::GIFImageDecoder::filenameExtension):
- platform/image-decoders/gif/GIFImageReader.cpp:
(GIFImageReader::do_lzw):
(GIFImageReader::read):
- platform/image-decoders/gif/GIFImageReader.h:
(GIFImageReader::~GIFImageReader):
- platform/image-decoders/ico/ICOImageDecoder.cpp:
(WebCore::ICOImageDecoder::ICOImageDecoder):
(WebCore::ICOImageDecoder::~ICOImageDecoder):
(WebCore::ICOImageDecoder::setData):
(WebCore::ICOImageDecoder::isSizeAvailable):
(WebCore::ICOImageDecoder::frameSizeAtIndex):
(WebCore::ICOImageDecoder::frameCount):
(WebCore::ICOImageDecoder::frameBufferAtIndex):
(WebCore::ICOImageDecoder::compareEntries):
(WebCore::ICOImageDecoder::setDataForPNGDecoderAtIndex):
(WebCore::ICOImageDecoder::decode):
(WebCore::ICOImageDecoder::decodeDirectory):
(WebCore::ICOImageDecoder::decodeAtIndex):
(WebCore::ICOImageDecoder::processDirectoryEntries):
(WebCore::ICOImageDecoder::readDirectoryEntry):
- platform/image-decoders/ico/ICOImageDecoder.h:
(WebCore::ICOImageDecoder::readUint16):
(WebCore::ICOImageDecoder::readUint32):
- platform/image-decoders/jpeg/JPEGImageDecoder.cpp:
(WebCore::):
(WebCore::JPEGImageReader::JPEGImageReader):
(WebCore::JPEGImageReader::skipBytes):
(WebCore::JPEGImageReader::decode):
(WebCore::error_exit):
(WebCore::fill_input_buffer):
(WebCore::term_source):
(WebCore::JPEGImageDecoder::setData):
(WebCore::JPEGImageDecoder::setSize):
(WebCore::JPEGImageDecoder::frameBufferAtIndex):
(WebCore::JPEGImageDecoder::jpegComplete):
(WebCore::JPEGImageDecoder::decode):
- platform/image-decoders/jpeg/JPEGImageDecoder.h:
(WebCore::JPEGImageDecoder::filenameExtension):
- platform/image-decoders/png/PNGImageDecoder.cpp:
(WebCore::decodingFailed):
(WebCore::decodingWarning):
(WebCore::headerAvailable):
(WebCore::rowAvailable):
(WebCore::pngComplete):
(WebCore::PNGImageReader::PNGImageReader):
(WebCore::PNGImageReader::close):
(WebCore::PNGImageReader::decode):
(WebCore::PNGImageReader::createInterlaceBuffer):
(WebCore::PNGImageDecoder::setData):
(WebCore::PNGImageDecoder::frameBufferAtIndex):
(WebCore::PNGImageDecoder::headerAvailable):
(WebCore::PNGImageDecoder::rowAvailable):
(WebCore::PNGImageDecoder::pngComplete):
(WebCore::PNGImageDecoder::decode):
- platform/image-decoders/png/PNGImageDecoder.h:
(WebCore::PNGImageDecoder::filenameExtension):
- platform/image-decoders/qt/RGBA32BufferQt.cpp:
(WebCore::RGBA32Buffer::setDecodedImage):
- 6:44 AM Changeset in webkit [54822] by
-
- 2 edits in trunk/WebKit/gtk
2010-02-16 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Xan Lopez.
Check if the handle has a SoupMessage before trying to use
it. This will be the case in non-HTTP(S) URLs.
- webkit/webkitdownload.cpp: (webkit_download_new_with_handle): (webkit_download_start):
- 5:32 AM Changeset in webkit [54821] by
-
- 2 edits in trunk/WebCore
[Qt] Unreviewed buildfix.
- WebCore.pro: Missing backslash added.
- 5:17 AM Changeset in webkit [54820] by
-
- 6 edits4 moves in trunk/WebCore
2010-02-16 Mikhail Naganov <mnaganov@chromium.org>
Reviewed by Pavel Feldman.
Move JSC-specific wrappers for Profile and ProfileNode to bindings/js.
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JavaScriptProfile.cpp: Added. (WebCore::profileCache): (WebCore::getTitleCallback): (WebCore::getHeadCallback): (WebCore::getUniqueIdCallback): (WebCore::focus): (WebCore::exclude): (WebCore::restoreAll): (WebCore::finalize): (WebCore::ProfileClass): (WebCore::toJS):
- bindings/js/JavaScriptProfile.h: Added.
- bindings/js/JavaScriptProfileNode.cpp: Added. (WebCore::profileNodeCache): (WebCore::getFunctionName): (WebCore::getURL): (WebCore::getLineNumber): (WebCore::getTotalTime): (WebCore::getSelfTime): (WebCore::getNumberOfCalls): (WebCore::getChildren): (WebCore::getVisible): (WebCore::getCallUID): (WebCore::finalize): (WebCore::ProfileNodeClass): (WebCore::toJS):
- bindings/js/JavaScriptProfileNode.h: Added.
- inspector/JavaScriptProfile.cpp: Removed.
- inspector/JavaScriptProfile.h: Removed.
- inspector/JavaScriptProfileNode.cpp: Removed.
- inspector/JavaScriptProfileNode.h: Removed.
- 5:11 AM Changeset in webkit [54819] by
-
- 7 edits2 adds in trunk
2010-02-16 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: Elements Panel: Limit the number of initially loaded element children
https://bugs.webkit.org/show_bug.cgi?id=34421
Test: inspector/elements-panel-limited-children.html
WebCore:
- English.lproj/localizedStrings.js:
- inspector/front-end/DOMAgent.js: (WebInspector.DOMNode.prototype._insertChild):
- inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel.prototype.updateModifiedNodes):
- inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeOutline.prototype.createTreeElementFor): (WebInspector.ElementsTreeOutline.prototype.revealAndSelectNode): (WebInspector.ElementsTreeElement): (WebInspector.ElementsTreeElement.prototype.get expandedChildrenLimit): (WebInspector.ElementsTreeElement.prototype.set expandedChildrenLimit): (WebInspector.ElementsTreeElement.prototype.get expandedChildCount): (WebInspector.ElementsTreeElement.prototype.showChild): (WebInspector.ElementsTreeElement.prototype.insertChildElement): (WebInspector.ElementsTreeElement.prototype.moveChild): (WebInspector.ElementsTreeElement.prototype._updateChildren.updateChildrenOfNode): (WebInspector.ElementsTreeElement.prototype._updateChildren): (WebInspector.ElementsTreeElement.prototype.adjustCollapsedRange): (WebInspector.ElementsTreeElement.prototype.handleLoadAllChildren): ():
- inspector/front-end/inspector.css:
LayoutTests:
- inspector/elements-panel-limited-children-expected.txt: Added.
- inspector/elements-panel-limited-children.html: Added.
- 4:54 AM Changeset in webkit [54818] by
-
- 7 edits in trunk
2010-02-16 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
Bump version to 1.1.22 so we can depend on it in applications.
- configure.ac:
WebKit/gtk:
2010-02-16 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
Add a new WebKitWebSettings setting, 'auto-resize-window', set to
FALSE by default, that when enabled will apply any resizes or
moves done by a page through various DOM methods (moveTo,
resizeTo, moveBy, resizeBy).
- WebCoreSupport/ChromeClientGtk.cpp:
- webkit/webkitwebsettings.cpp: (webkit_web_settings_class_init): (webkit_web_settings_set_property): (webkit_web_settings_get_property): (webkit_web_settings_copy):
WebKitTools:
2010-02-16 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
Enable 'auto-resize-window' in our DRT.
- DumpRenderTree/gtk/DumpRenderTree.cpp: (resetDefaultsToConsistentValues):
- 3:18 AM Changeset in webkit [54817] by
-
- 1 edit3 copies3 moves in trunk/LayoutTests
Refactor and split up basic-touch-events test
https://bugs.webkit.org/show_bug.cgi?id=34476
Reviewed by Simon Hausmann.
Split the basic-touch-events test into two separate tests, one for single and another for multi touch. Also refactor the tests to run in an asynchronous manner.
- fast/events/touch/basic-multi-touch-events.html: Copied from LayoutTests/fast/events/touch/basic-touch-events.html. Tests the same multi touch tests cases from the old basic-touch-events test.
- fast/events/touch/basic-multi-touch-events-expected.txt: Added.
- fast/events/touch/script-tests/basic-multi-touch-events.js: Added.
- fast/events/touch/basic-single-touch-events.html: Copied from LayoutTests/fast/events/touch/basic-touch-events.html. Tests the same single touch tests cases from the old basic-touch-events test.
- fast/events/touch/script-tests/basic-single-touch-events.js: Added.
- fast/events/touch/basic-single-touch-events-expected.txt: Added.
- fast/events/touch/basic-touch-events.html: Removed.
- fast/events/touch/script-tests/basic-touch-events.js: Removed.
- fast/events/touch/basic-touch-events-expected.txt: Removed.
- 3:14 AM Changeset in webkit [54816] by
-
- 2 edits in trunk/WebKit/qt
Unreviewed Symbian build fix.
Updated the def file with two new exports used by QtLauncher.
- symbian/eabi/QtWebKitu.def:
- 3:10 AM Changeset in webkit [54815] by
-
- 4 edits in trunk
2010-02-16 Ismail Donmez <ismail@namtrac.org>
Reviewed by Pavel Feldman.
Fix compilation with inspector disabled.
https://bugs.webkit.org/show_bug.cgi?id=32724
- rendering/RenderLayerBacking.cpp: (WebCore::inspectorTimelineAgent):
2010-02-16 Ismail Donmez <ismail@namtrac.org>
Reviewed by Pavel Feldman.
Fix compilation with inspector disabled.
https://bugs.webkit.org/show_bug.cgi?id=32724
- Api/qwebpage.cpp: (qt_drt_webinspector_executeScript): (qt_drt_webinspector_close): (qt_drt_webinspector_show): (qt_drt_setTimelineProfilingEnabled):
- 2:27 AM Changeset in webkit [54814] by
-
- 2 edits in trunk/WebKit/qt
[Qt] Fix include paths for forwarding headers in standalone builds.
Patch by Jocelyn Turcotte <jocelyn.turcotte@nokia.com> on 2010-02-16
Reviewed by Simon Hausman.
- Api/DerivedSources.pro: Use relative paths for package builds and added some
documentation.
- 2:25 AM Changeset in webkit [54813] by
-
- 4 edits in trunk/WebCore
2010-02-16 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: turn off line wrapping in source view.
- inspector/front-end/TextViewer.js: (WebInspector.TextViewer.prototype.markAndRevealRange): (WebInspector.TextViewer.prototype._paintLine):
- inspector/front-end/textViewer.css:
- inspector/front-end/utilities.js:
- 2:08 AM Changeset in webkit [54812] by
-
- 4 edits in trunk/WebCore
2010-02-16 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: let search iterate over views in Resources
and keep the view in Scripts.
- inspector/front-end/Panel.js: (WebInspector.Panel.prototype.jumpToNextSearchResult): (WebInspector.Panel.prototype.jumpToPreviousSearchResult): (WebInspector.Panel.prototype.showSourceLineForURL): (WebInspector.Panel.prototype.searchIteratesOverViews):
- inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype.get _resources): (WebInspector.ResourcesPanel.prototype.searchIteratesOverViews):
- inspector/front-end/SourceView.js: (WebInspector.SourceView.prototype.showingLastSearchResult):
- inspector/front-end/inspector.js: (WebInspector.documentKeyDown): (WebInspector.focusSearchField):
- 1:17 AM Changeset in webkit [54811] by
-
- 2 edits in trunk/WebCore
2010-02-16 Noam Rosenthal <noam.rosenthal@nokia.com>
Reviewed by Ariya Hidayat.
[Qt] canvas clipping is buggy
https://bugs.webkit.org/show_bug.cgi?id=32405
Apparently the bug was in GraphicsContext::roundToDevicePixels, we
didn't take unto accounts rotation, so the device pixels were rounded
incorrectly. The new formula is a 1:1 copy from GraphicsContextCG so
it should be rather safe
Test: http://glimr.rubyforge.org/cake/canvas.html#Polaroids now looks right
- platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::roundToDevicePixels): Copy the formula from GraphicsContextCG
- 12:48 AM Changeset in webkit [54810] by
-
- 2 edits in trunk/WebCore
2010-02-16 Yury Semikhatsky <yurys@chromium.org>
Not Reviewed, build fix.
- platform/graphics/FloatRect.h: (WebCore::FloatRect::center): make conversion from float to int explicit so that compiler doesn't complain about that.
Feb 15, 2010:
- 11:42 PM Changeset in webkit [54809] by
-
- 2 edits in trunk/JavaScriptCore
2010-02-15 Gabor Loki <loki@webkit.org>
Reviewed by Gavin Barraclough.
Fix the SP at ctiOpThrowNotCaught on Thumb2 (JSVALUE32)
https://bugs.webkit.org/show_bug.cgi?id=34939
- jit/JITStubs.cpp:
- 10:17 PM Changeset in webkit [54808] by
-
- 3 edits in trunk/WebKitTools
2010-02-15 Martin Robinson <Martin Robinson>
Reviewed by Darin Adler.
check-webkit-style should not complain about NULL sentinel in calls to g_strconcat and g_strjoin
https://bugs.webkit.org/show_bug.cgi?id=34834
- Scripts/webkitpy/style/processors/cpp.py:
- Scripts/webkitpy/style/processors/cpp_unittest.py:
- 8:19 PM Changeset in webkit [54807] by
-
- 8 edits in trunk
WebCore: <rdar://problem/7645609> [webView selectionRect] API is broken for multicolumn layout
Reviewed by Simon Fraser.
Refine the fix for https://bugs.webkit.org/show_bug.cgi?id=34923 by using the center of
a quad’s bounding box, rather than its top left, as the reference point passed to
offsetFromContainer(). This ensures that if a sliver off the top of the selection rect is in
one column, but most of it is on another column, the single rect we return will be for the
second column.
- platform/graphics/FloatRect.h:
(WebCore::FloatRect::center): Added.
- rendering/RenderObject.cpp:
(WebCore::RenderObject::localToContainerQuad): Use the center instead of the top left.
LayoutTests: Add test case for <rdar://problem/7645609> [webView selectionRect] API is broken for multicolumn layout
Reviewed by Simon Fraser.
- fast/multicol/client-rects-expected.checksum:
- fast/multicol/client-rects-expected.png:
- fast/multicol/client-rects-expected.txt:
- fast/multicol/client-rects.html:
- 6:36 PM Changeset in webkit [54806] by
-
- 3 edits in trunk/WebCore
2010-02-15 MORITA Hajime <morrita@gmail.com>
Reviewed by Nikolas Zimmermann.
SVG text refactor: reduce paint specific callbacks on SVGTextChunkWalker
No new tests, no change of functionality.
- rendering/SVGCharacterLayoutInfo.h: (WebCore::SVGTextChunkWalker::SVGTextChunkWalker): Removed setupBackground(), setupFill(), setupFillSelection(), setupStroke(), setupStrokeSelection(), setupForeground() and associated member variables.
- rendering/SVGRootInlineBox.cpp: (WebCore::SVGRootInlineBoxPaintWalker::setupBackground): renamed from chunkSetupBackgroundCallback. (WebCore::SVGRootInlineBoxPaintWalker::setupFill): renamed from chunkSetupFillCallback. (WebCore::SVGRootInlineBoxPaintWalker::setupFillSelection): renamed from chunkSetupFillSelectionCallback. (WebCore::SVGRootInlineBoxPaintWalker::setupStroke): renamed from chunkSetupStrokeCallback. (WebCore::SVGRootInlineBoxPaintWalker::setupStrokeSelection): renamed from chunkSetupStrokeSelectionCallback. (WebCore::SVGRootInlineBoxPaintWalker::setupForeground): renamed from chunkSetupForegroundCallback. (WebCore::SVGRootInlineBoxPaintWalker::paintChunk): renamed from chunkPortionCallback. (WebCore::SVGRootInlineBoxPaintWalker::chunkPortionCallback): extracted from walkTextChunks. (WebCore::SVGRootInlineBox::paint): follow SVGTextChunkWalker change. (WebCore::SVGRootInlineBox::walkTextChunks): moved paint some specific code to SVGRootInlineBoxPaintWalker::chunkPortionCallback().
- 5:54 PM Changeset in webkit [54805] by
-
- 2 edits in trunk/JavaScriptCore
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
Reviewed by NOBODY (Build Fix!).
- 5:32 PM Changeset in webkit [54804] by
-
- 6 edits in trunk/JavaScriptCore
Some general Rope related refactoring.
Reviewed by Oliver Hunt.
Rename Rope::m_ropeLength to m_fiberCount, to be more descriptive.
Rename Rope::m_stringLength to simply m_length (since this is the
more conventional name for the length of a string). Move append
behaviour out into a new RopeBuilder class, so that Rope no longer
needs any knowledge of the JSString or UString implementation.
Make Rope no longer be nested within JSString.
(Rope now no-longer need reside within JSString.h, but leaving
the change of moving this out to a different header as a separate
change from these renames).
- JavaScriptCore.exp:
- jit/JITOpcodes.cpp:
(JSC::JIT::privateCompileCTIMachineTrampolines):
- runtime/JSString.cpp:
(JSC::Rope::destructNonRecursive):
(JSC::Rope::~Rope):
(JSC::JSString::resolveRope):
(JSC::JSString::toBoolean):
(JSC::JSString::getStringPropertyDescriptor):
- runtime/JSString.h:
(JSC::Rope::Fiber::Fiber):
(JSC::Rope::Fiber::deref):
(JSC::Rope::Fiber::ref):
(JSC::Rope::Fiber::refAndGetLength):
(JSC::Rope::Fiber::isRope):
(JSC::Rope::Fiber::rope):
(JSC::Rope::Fiber::isString):
(JSC::Rope::Fiber::string):
(JSC::Rope::Fiber::nonFiber):
(JSC::Rope::tryCreateUninitialized):
(JSC::Rope::append):
(JSC::Rope::fiberCount):
(JSC::Rope::length):
(JSC::Rope::fibers):
(JSC::Rope::Rope):
(JSC::Rope::operator new):
(JSC::):
(JSC::RopeBuilder::JSString):
(JSC::RopeBuilder::~JSString):
(JSC::RopeBuilder::length):
(JSC::RopeBuilder::canGetIndex):
(JSC::RopeBuilder::appendStringInConstruct):
(JSC::RopeBuilder::appendValueInConstructAndIncrementLength):
(JSC::RopeBuilder::isRope):
(JSC::RopeBuilder::fiberCount):
(JSC::JSString::getStringPropertySlot):
- runtime/Operations.h:
(JSC::jsString):
- 4:25 PM Changeset in webkit [54803] by
-
- 2 edits in trunk/WebKit/chromium
[Chromium] Fix StorageNamespaceProxy::copy() for test shell
https://bugs.webkit.org/show_bug.cgi?id=34949
Reviewed by Darin Fisher.
Chromium passes back NULL when you call WebStorageNamespace::proxy()
but TestShell returns a valid object. Both need to work via
the WebStorageNamespace.
- src/StorageNamespaceProxy.cpp:
(WebCore::StorageNamespaceProxy::copy):
- 4:19 PM Changeset in webkit [54802] by
-
- 2 edits in trunk/WebCore
Try to fix the Chromium build.
- rendering/RenderThemeChromiumMac.mm:
(WebCore::RenderThemeChromiumMac::convertToPaintingRect):
- 3:44 PM Changeset in webkit [54801] by
-
- 2 edits in trunk/JavaScriptCore
Add missing cast for !YARR (PPC) builds.
Reviewed by NOBODY (Build fix).
- runtime/RegExp.cpp:
(JSC::RegExp::match):
- 2:58 PM Changeset in webkit [54800] by
-
- 1 edit in trunk/LayoutTests/platform/win/Skipped
Add newline to end of Windows skipped list
- 2:57 PM Changeset in webkit [54799] by
-
- 2 edits in trunk/LayoutTests
Rubber-stamped by Dan Bernstein.
Skipped glyph-reordering on Windows since it has failed since it was landed. Left a comment
in <https://bugs.webkit.org/show_bug.cgi?id=34865> to track the failure.
- platform/win/Skipped:
- 2:37 PM Changeset in webkit [54798] by
-
- 7 edits2 deletes in trunk
https://bugs.webkit.org/show_bug.cgi?id=33731
Many false leaks in release builds due to PtrAndFlags
Reviewed by Darin Adler.
StructureTransitionTable was effectively a smart pointer type,
one machine word in size and wholly contained as a member of
of Structure. It either pointed to an actual table, or could
be used to describe a single transtion entry without use of a
table.
This, however, worked by using a PtrAndFlags, which is not
compatible with the leaks tool. Since there is no clear way to
obtain another bit for 'free' here, and since there are bits
available up in Structure, merge this functionality back up into
Structure. Having this in a separate class was quite clean
from an enacapsulation perspective, but this solution doesn't
seem to bad - all table access is now intermediated through the
Structure::structureTransitionTableFoo methods, keeping the
optimization fairly well contained.
This was the last use of PtrAndFlags, so removing the file too.
- JavaScriptCore.xcodeproj/project.pbxproj:
- bytecode/CodeBlock.h:
- runtime/Structure.cpp:
(JSC::Structure::Structure):
(JSC::Structure::~Structure):
(JSC::Structure::addPropertyTransitionToExistingStructure):
(JSC::Structure::addPropertyTransition):
(JSC::Structure::hasTransition):
- runtime/Structure.h:
(JSC::Structure::):
(JSC::Structure::structureTransitionTableContains):
(JSC::Structure::structureTransitionTableGet):
(JSC::Structure::structureTransitionTableHasTransition):
(JSC::Structure::structureTransitionTableRemove):
(JSC::Structure::structureTransitionTableAdd):
(JSC::Structure::structureTransitionTable):
(JSC::Structure::setStructureTransitionTable):
(JSC::Structure::singleTransition):
(JSC::Structure::setSingleTransition):
- runtime/StructureTransitionTable.h:
- wtf/PtrAndFlags.h: Removed.
WebCore:
PtrAndFlags has now been removed; remove forwarding header.
- ForwardingHeaders/wtf/PtrAndFlags.h: Removed.
- 2:21 PM Changeset in webkit [54797] by
-
- 2 edits in trunk/LayoutTests
Skip more plugin tests on Snow Leopard buildbot, as they need updated closed source components.
- platform/mac-snowleopard/Skipped: Skip netscape-dom-access.html and netscape-browser-object-identity.html.
- 1:48 PM Changeset in webkit [54796] by
-
- 5 edits in trunk/WebKit/win
Add IWebFramePrivate::visibleContentRect
Fixes <http://webkit.org/b/34956> Add API to get a WebFrame's visible
content rect
Reviewed by Jon Honeycutt.
- Interfaces/IWebFramePrivate.idl: Added visibleContentRect.
- Interfaces/WebKit.idl: Touched to force a build.
- WebFrame.cpp:
(WebFrame::visibleContentRect):
- WebFrame.h:
Added. Calls through to FrameView::visibleContentRect.
- 1:43 PM Changeset in webkit [54795] by
-
- 2 edits in trunk/JavaScriptCore
Rubber Stamped by Geoff Garen.
Bug 34948 - tryMakeString should fail on error in length calculation
Ooops! - "bool overflow" argument should have been "bool& overflow".
- runtime/UString.h:
(JSC::sumWithOverflow):
(JSC::tryMakeString):
- 1:41 PM Changeset in webkit [54794] by
-
- 2 edits in trunk/JavaScriptCore
Some symbol names have changed, remove, will readd if required.
Reviewed by NOBODY (Build Fix (pt 2!)).
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- 1:37 PM Changeset in webkit [54793] by
-
- 2 edits in trunk/LayoutTests
[Qt] fast/multicol/client-rects.html fails in QtLauncher
https://bugs.webkit.org/show_bug.cgi?id=34959
- platform/qt/Skipped: fast/multicol/client-rects.html skipped until fix.
- 1:24 PM Changeset in webkit [54792] by
-
- 2 edits in trunk/JavaScriptCore
Some symbol names have changed, remove, will readd if required.
Reviewed by NOBODY (Build Fix (pt 1?)).
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- 1:18 PM Changeset in webkit [54791] by
-
- 3 edits in trunk/WebKit/mac
More build fixing (for what is actually a 64-bit failure, as 32-bit apparently includes
headers that aren't included in 64-bit).
- Plugins/Hosted/NetscapePluginInstanceProxy.h:
- Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::LocalObjectMap::contains): (WebKit::NetscapePluginInstanceProxy::LocalObjectMap::get): Move inline functions to .cpp; also made the class Noncopyable.
- 1:09 PM Changeset in webkit [54790] by
-
- 2 edits in trunk/JavaScriptCore
Removed some mistaken code added in http://trac.webkit.org/changeset/53860.
Reviewed by Oliver Hunt.
- API/APIShims.h:
(JSC::APICallbackShim::APICallbackShim):
(JSC::APICallbackShim::~APICallbackShim): No need to start/stop the
timeout checker when calling out from the API to the client; we want to
monitor the VM for timeouts, not the client. This mistake was harmless /
undetectable, since it's totally redundant with the APIEntryShim, which
also starts / stops the timeout checker.
- 1:03 PM Changeset in webkit [54789] by
-
- 18 edits in trunk
Bug 34952 - String lengths in UString should be unsigned.
This matches WebCore::StringImpl, and better unifies behaviour throughout JSC.
Reviewed by Geoff Garen.
- JavaScriptCore.exp:
- bytecode/EvalCodeCache.h:
- runtime/Identifier.cpp:
(JSC::Identifier::equal):
- runtime/Identifier.h:
- runtime/JSGlobalObjectFunctions.cpp:
(JSC::globalFuncEscape):
- runtime/JSONObject.cpp:
(JSC::gap):
(JSC::Stringifier::indent):
- runtime/NumberPrototype.cpp:
(JSC::numberProtoFuncToFixed):
(JSC::numberProtoFuncToPrecision):
- runtime/RegExp.cpp:
(JSC::RegExp::match):
- runtime/StringPrototype.cpp:
(JSC::substituteBackreferencesSlow):
(JSC::stringProtoFuncReplace):
(JSC::stringProtoFuncSplit):
(JSC::trimString):
- runtime/UString.cpp:
(JSC::UString::UString):
(JSC::UString::from):
(JSC::UString::getCString):
(JSC::UString::ascii):
(JSC::UString::operator[]):
(JSC::UString::toStrictUInt32):
(JSC::UString::find):
(JSC::UString::rfind):
(JSC::UString::substr):
(JSC::operator<):
(JSC::operator>):
(JSC::compare):
(JSC::equal):
(JSC::UString::UTF8String):
- runtime/UString.h:
(JSC::UString::size):
(JSC::operator==):
- runtime/UStringImpl.cpp:
(JSC::UStringImpl::create):
- runtime/UStringImpl.h:
(JSC::UStringImpl::create):
(JSC::UStringImpl::size):
(JSC::UStringImpl::computeHash):
(JSC::UStringImpl::UStringImpl):
WebCore:
- bindings/js/JSDOMWindowCustom.cpp:
(WebCore::JSDOMWindow::atob):
(WebCore::JSDOMWindow::btoa):
- 12:59 PM Changeset in webkit [54788] by
-
- 2 edits in trunk/JavaScriptCore
Bug 34948 - tryMakeString should fail on error in length calculation
Reviewed by Geoff Garen.
The sum of the length of substrings could overflow.
- runtime/UString.h:
(JSC::sumWithOverflow):
(JSC::tryMakeString):
- 12:42 PM Changeset in webkit [54787] by
-
- 3 edits in trunk/WebKit/mac
Mac release build fix attempt.
- Plugins/Hosted/NetscapePluginInstanceProxy.h:
- Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::LocalObjectMap::~LocalObjectMap): Implement destructor in .cpp file, where necessary headers are already included.
- 12:35 PM Changeset in webkit [54786] by
-
- 3 edits3 adds in trunk
2010-02-15 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Xan Lopez.
[GTK] Crashes when going back to a page that has data: URIs, with page cache enabled
https://bugs.webkit.org/show_bug.cgi?id=34944
Set the URL in the newly created response, when parsing data:
URIs.
Test: fast/harness/page-cache-crash-on-data-urls.html
- platform/network/soup/ResourceHandleSoup.cpp: (WebCore::parseDataUrl):
- 12:32 PM Changeset in webkit [54785] by
-
- 2 edits in trunk/JavaScriptCore
Fixed <rdar://problem/7628524> Crash beneath JSGlobalContextRelease when
typing in Google search field with GuardMalloc/full page heap enabled
Reviewed by Oliver Hunt.
- API/JSContextRef.cpp: Don't use APIEntryShim, since that requires
a JSGlobalData, which this function destroys. Do use setCurrentIdentifierTable
and JSLock instead, since those are the two features of APIEntryShim we
require.
- 11:48 AM Changeset in webkit [54784] by
-
- 15 edits4 adds in trunk
<rdar://problem/7647300> Incorrect client rects for blocks the span multiple columns and their descendants
https://bugs.webkit.org/show_bug.cgi?id=34923
Reviewed by Simon Fraser.
WebCore:
Test: fast/multicol/client-rects.html
In column layout, a different transform applies to different points in
the block and its descendants, depending on their y coordinate within the
block. offsetFromContainer() used to return the offset that applied to
the origin. With this change, it returns the offset that applies to a
given reference point. When mapping a quad from local to absolute
coordinates, the top left of the quad’s bounding box is used as that
reference point.
- editing/SelectionController.cpp:
(WebCore::SelectionController::layout): Pass the caret’s origin as the
reference point to offsetFromContainer().
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::adjustForColumns): Adds the offset between the
given point and its image under the column paint-time transform to the
given offset. Used by offsetFromContainer() where it had previously used
adjustRectForColumns(), which takes a rect and operates less efficiently.
- rendering/RenderBlock.h:
- rendering/RenderBox.cpp:
(WebCore::RenderBox::mapLocalToContainer): Pass the transformed point as
the reference point to offsetFromContainer().
(WebCore::RenderBox::mapAbsoluteToLocalPoint): Pass a point to
offsetFromContainer().
(WebCore::RenderBox::offsetFromContainer): Use adjustForColumns() instead
of adjustRectForColumns(), and use the reference point to get the right
adjustment for the point of interest, instead of the origin, in case this
box spans multiple columns.
- rendering/RenderBox.h:
- rendering/RenderInline.cpp:
(WebCore::RenderInline::offsetFromContainer): Ditto. Actually apply the
column offset to the computation, which previously this function didn’t
do.
(WebCore::RenderInline::mapLocalToContainer): Pass the transformed point
as the reference point to offsetFromContainer().
(WebCore::RenderInline::mapAbsoluteToLocalPoint): Pass a point to
offsetFromContainer().
- rendering/RenderInline.h:
- rendering/RenderObject.cpp:
(WebCore::RenderObject::mapLocalToContainer): Apply column adjustment,
based on the reference point, to the transform if needed.
(WebCore::RenderObject::localToContainerQuad): Initialize the
TransformState with the top left corner of the quad’s bounding box. It
is later used as the reference point when deciding on which column to
base the calculations.
(WebCore::RenderObject::offsetFromContainer): Adjust for columns.
(WebCore::RenderObject::offsetFromAncestorContainer): Pass the origin
as the reference point to offsetFromContainer().
- rendering/RenderObject.h:
(WebCore::RenderObject::adjustForColumns): Added.
- rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::offsetFromContainer): Pass the reference
point through.
- rendering/RenderTableCell.h:
- rendering/RenderText.cpp:
(WebCore::RenderText::absoluteRectsForRange): Map (the origin of) each
rect to absolute coordinates individually.
- rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::convertToPaintingRect): Pass a point to
offsetFromContainer().
LayoutTests:
- fast/multicol/client-rects-expected.checksum: Added.
- fast/multicol/client-rects-expected.png: Added.
- fast/multicol/client-rects-expected.txt: Added.
- fast/multicol/client-rects.html: Added.
- 11:16 AM Changeset in webkit [54783] by
-
- 13 edits3 adds in trunk
Reviewed by Kevin Decker.
<rdar://problem/7130641> Browser objects identity is not preserved by Safari
Test: plugins/netscape-browser-object-identity.html
- bridge/runtime_root.h: (JSC::Bindings::RootObject::addInvalidationCallback): RootObject can now call out during invalidation, making it possible for other code to know when this happens.
- bridge/runtime_root.cpp: (JSC::Bindings::RootObject::InvalidationCallback::~InvalidationCallback): Empty destructor, in cpp file since it's virtual. (JSC::Bindings::RootObject::invalidate): Invoke invalidation callbacks.
- bridge/NP_jsobject.cpp: (ObjectMap): Keep a JSObject->NPObject map for each RootObject. It somewhat cleaner to keep it outside RootObject, because (1) it is agnostic of what kinds of objects can wrap JSObject, and (2) out of process NPAPI implementation also keeps its corresponding map separately, due to supporting per-instance granularity (as opposed to per-RootObject here). (jsDeallocate): Remove the corresponding map entry. (_NPN_CreateScriptObject): Try to fetch existing object from the map, incrementing refcount.
- 10:35 AM Changeset in webkit [54782] by
-
- 2 edits in trunk/WebCore
2010-02-15 Philippe Normand <pnormand@igalia.com>
Rubber-stamped by Gustavo Noronha Silva.
Removed redefine of LOG_VERBOSE. This should not have commited in
the first place.
- platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
- 10:04 AM Changeset in webkit [54781] by
-
- 3 edits in trunk/JavaScriptCore
2010-02-15 Patrick Gansterer <paroga@paroga.com>
Reviewed by Laszlo Gombos.
Added additional parameter to create_rvct_stubs
for setting the offset of thunkReturnAddress.
https://bugs.webkit.org/show_bug.cgi?id=34657
- create_rvct_stubs:
- jit/JITStubs.cpp:
- 9:48 AM Changeset in webkit [54780] by
-
- 4 edits2 adds in trunk
2010-02-15 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: incorrect syntax highlighting as HTML in a script tag.
We were preserving initial lexer state upon entering other tags while in <script>
but were not doing it for <script tag itself. As a result, nested script
tags were failing to highlight.
- inspector/front-end/SourceHTMLTokenizer.js: (WebInspector.SourceHTMLTokenizer.prototype.nextToken):
- inspector/front-end/SourceHTMLTokenizer.re2js:
- 9:46 AM Changeset in webkit [54779] by
-
- 3 edits in trunk/WebKit/gtk
2010-02-15 Emilio Pozuelo Monfort <pochu27@gmail.com>
Reviewed by Gustavo Noronha Silva.
[GTK] Fails to build on GNU/Hurd because of PATH_MAX usage
https://bugs.webkit.org/show_bug.cgi?id=34920
Use dynamic allocation instead of fixed PATH_MAX size buffers to
fix the build on GNU/Hurd, where PATH_MAX is undefined.
- tests/testmimehandling.c: (main):
- tests/testwebview.c: (main):
- 9:31 AM Changeset in webkit [54778] by
-
- 4 edits in trunk/WebCore
Add a progress-indicator logging channel to WebCore, and convert the old WebKit Logging
messages over to WebCore-style.
Reviewed by Dan Bernstein.
No new tests. (Logging changes only)
- loader/ProgressTracker.cpp:
(WebCore::ProgressTracker::progressStarted):
(WebCore::ProgressTracker::progressCompleted):
(WebCore::ProgressTracker::finalProgressComplete):
(WebCore::ProgressTracker::incrementProgress):
- platform/Logging.cpp:
(WebCore::):
(WebCore::getChannelFromName):
- platform/Logging.h:
- 9:10 AM Changeset in webkit [54777] by
-
- 7 edits4 moves in trunk/WebCore
Revert 54776
Move JSC-specific wrappers for Profile and ProfileNode to bindings/js.
https://bugs.webkit.org/show_bug.cgi?id=34848
- 8:59 AM Changeset in webkit [54776] by
-
- 7 edits4 moves in trunk/WebCore
2010-02-15 Mikhail Naganov <mnaganov@chromium.org>
Reviewed by Pavel Feldman.
Move JSC-specific wrappers for Profile and ProfileNode to bindings/js.
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSBindingsAllInOne.cpp:
- bindings/js/JavaScriptProfile.cpp: Added. (WebCore::profileCache): (WebCore::getTitleCallback): (WebCore::getHeadCallback): (WebCore::getUniqueIdCallback): (WebCore::focus): (WebCore::exclude): (WebCore::restoreAll): (WebCore::finalize): (WebCore::ProfileClass): (WebCore::toJS):
- bindings/js/JavaScriptProfile.h: Added.
- bindings/js/JavaScriptProfileNode.cpp: Added. (WebCore::profileNodeCache): (WebCore::getFunctionName): (WebCore::getURL): (WebCore::getLineNumber): (WebCore::getTotalTime): (WebCore::getSelfTime): (WebCore::getNumberOfCalls): (WebCore::getChildren): (WebCore::getVisible): (WebCore::getCallUID): (WebCore::finalize): (WebCore::ProfileNodeClass): (WebCore::toJS):
- bindings/js/JavaScriptProfileNode.h: Added.
- inspector/JavaScriptProfile.cpp: Removed.
- inspector/JavaScriptProfile.h: Removed.
- inspector/JavaScriptProfileNode.cpp: Removed.
- inspector/JavaScriptProfileNode.h: Removed.
- 7:36 AM Changeset in webkit [54775] by
-
- 5 edits in trunk
2010-02-15 Noam Rosenthal <noam.rosenthal@nokia.com>
Reviewed by Simon Hausmann.
[Qt] QtWebkit bridge: enable passing a QWebElement to a signal/slot/property
https://bugs.webkit.org/show_bug.cgi?id=34901
When a signal/slot/property is of type QWebElement, it can seamlessly
connect with JS objects that hold a WebCore element.
New tests, see WebKit/qt/ChangeLog
- bridge/qt/qt_runtime.cpp: (JSC::Bindings::QtWebElementRuntime::create): A proxy to QWebElement constructor (JSC::Bindings::QtWebElementRuntime::get): A proxy to QWebElement::element (JSC::Bindings::convertValueToQVariant): handle QWebElement (JSC::Bindings::convertQVariantToValue): handle QWebElement
2010-02-15 Noam Rosenthal <noam.rosenthal@nokia.com>
Reviewed by Simon Hausmann.
[Qt] QtWebkit bridge: enable passing a QWebElement to a signal/slot/property
Add Q_DECLARE_METATYPE to QWebElement, add relevant tests to
tst_qwebframe
https://bugs.webkit.org/show_bug.cgi?id=34901
- Api/qwebelement.h: declare metatype
- tests/qwebframe/tst_qwebframe.cpp: (MyQObject::webElementProperty): new test for QWebElement (MyQObject::setWebElementProperty): new test for QWebElement (MyQObject::myOverloadedSlot): new test for QWebElement
- 5:56 AM Changeset in webkit [54774] by
-
- 2 edits in trunk/WebCore
2010-02-15 Pavel Feldman <pfeldman@chromium.org>
Not reviewed, Chromium tests fix (force conversion of property names to
strings in Web Inspector's injected script).
- inspector/front-end/InjectedScript.js: (injectedScriptConstructor):
- 4:52 AM QtWebKitTableOfFeatures46 edited by
- (diff)
- 4:46 AM HackingGtk edited by
- (diff)
- 4:08 AM Changeset in webkit [54773] by
-
- 4 edits in trunk/JavaScriptCore
2010-02-15 Jedrzej Nowacki <jedrzej.nowacki@nokia.com>
Reviewed by Simon Hausmann.
Fix QScriptValue::toIntXX methods.
More ECMA Script compliance.
[Qt] QScriptValue::toIntXX returns incorrect values
https://bugs.webkit.org/show_bug.cgi?id=34847
- qt/api/qscriptvalue_p.h: (QScriptValuePrivate::toInteger): (QScriptValuePrivate::toInt32): (QScriptValuePrivate::toUInt32): (QScriptValuePrivate::toUInt16):
- qt/tests/qscriptvalue/tst_qscriptvalue.h:
- qt/tests/qscriptvalue/tst_qscriptvalue_generated.cpp: (tst_QScriptValue::toInteger_initData): (tst_QScriptValue::toInteger_makeData): (tst_QScriptValue::toInteger_test): (tst_QScriptValue::toInt32_initData): (tst_QScriptValue::toInt32_makeData): (tst_QScriptValue::toInt32_test): (tst_QScriptValue::toUInt32_initData): (tst_QScriptValue::toUInt32_makeData): (tst_QScriptValue::toUInt32_test): (tst_QScriptValue::toUInt16_initData): (tst_QScriptValue::toUInt16_makeData): (tst_QScriptValue::toUInt16_test):
- 3:11 AM QtWebKitTableOfFeatures46 edited by
- (diff)
- 2:56 AM Changeset in webkit [54772] by
-
- 10 edits in trunk
2010-02-15 Robert Hogan <robert@roberthogan.net>
Reviewed by Simon Hausmann.
[Qt] DRT: Support evaluateInWebInspector(), setTimelineProfilingEnabled().
Support LayoutTestController.evaluateInWebInspector(), setTimelineProfilingEnabled() in Qt DRT.
This allows the following tests to pass:
inspector/console-format-collections.html
inspector/styles-iframe.html
inspector/syntax-highlight-css.html
inspector/syntax-highlight-javascript.html
inspector/timeline-enum-stability.html
inspector/timeline-layout.html
inspector/timeline-mark-timeline.html
inspector/timeline-paint.html
inspector/timeline-parse-html.html
inspector/timeline-recalculate-styles.html
inspector/timeline-script-tag-1.html
inspector/timeline-script-tag-2.html
inspector/timeline-trivial.html
inspector/cookie-resource-match.html
inspector/elements-img-tooltip.html
inspector/elements-panel-selection-on-refresh.html
inspector/inspected-objects-not-overriden.html
inspector/timeline-event-dispatch.html
inspector/timeline-network-resource.html
inspector/elements-panel-rewrite-href.html
inspector/console-dir.html
inspector/console-dirxml.html
inspector/console-format.html
inspector/console-tests.html
inspector/elements-panel-structure.html
inspector/evaluate-in-frontend.html
inspector/console-clear.html
- platform/qt/Skipped:
2010-02-15 Robert Hogan <robert@roberthogan.net>, Jocelyn Turcotte <jocelyn.turcotte@nokia.com>
Reviewed by Simon Hausmann.
[Qt] DRT: Support evaluateInWebInspector(), setTimelineProfilingEnabled().
Support LayoutTestController.evaluateInWebInspector(), setTimelineProfilingEnabled() in Qt DRT.
This allows the following tests to pass:
inspector/console-format-collections.html
inspector/styles-iframe.html
inspector/syntax-highlight-css.html
inspector/syntax-highlight-javascript.html
inspector/timeline-enum-stability.html
inspector/timeline-layout.html
inspector/timeline-mark-timeline.html
inspector/timeline-paint.html
inspector/timeline-parse-html.html
inspector/timeline-recalculate-styles.html
inspector/timeline-script-tag-1.html
inspector/timeline-script-tag-2.html
inspector/timeline-trivial.html
inspector/cookie-resource-match.html
inspector/elements-img-tooltip.html
inspector/elements-panel-selection-on-refresh.html
inspector/inspected-objects-not-overriden.html
inspector/timeline-event-dispatch.html
inspector/timeline-network-resource.html
inspector/elements-panel-rewrite-href.html
inspector/console-dir.html
inspector/console-dirxml.html
inspector/console-format.html
inspector/console-tests.html
inspector/elements-panel-structure.html
inspector/evaluate-in-frontend.html
inspector/console-clear.html
- Api/qwebpage.cpp: (qt_drt_webinspector_executeScript): (qt_drt_webinspector_close): (qt_drt_webinspector_show): (qt_drt_setTimelineProfilingEnabled):
- WebCoreSupport/InspectorClientQt.cpp: (InspectorClientQt::createPage)
2010-02-15 Robert Hogan <robert@roberthogan.net>
Reviewed by Simon Hausmann.
[Qt] DRT: Support evaluateInWebInspector(), setTimelineProfilingEnabled().
Support LayoutTestController.evaluateInWebInspector(), setTimelineProfilingEnabled() in Qt DRT.
This allows the following tests to pass:
inspector/console-format-collections.html
inspector/styles-iframe.html
inspector/syntax-highlight-css.html
inspector/syntax-highlight-javascript.html
inspector/timeline-enum-stability.html
inspector/timeline-layout.html
inspector/timeline-mark-timeline.html
inspector/timeline-paint.html
inspector/timeline-parse-html.html
inspector/timeline-recalculate-styles.html
inspector/timeline-script-tag-1.html
inspector/timeline-script-tag-2.html
inspector/timeline-trivial.html
inspector/cookie-resource-match.html
inspector/elements-img-tooltip.html
inspector/elements-panel-selection-on-refresh.html
inspector/inspected-objects-not-overriden.html
inspector/timeline-event-dispatch.html
inspector/timeline-network-resource.html
inspector/elements-panel-rewrite-href.html
inspector/console-dir.html
inspector/console-dirxml.html
inspector/console-format.html
inspector/console-tests.html
inspector/elements-panel-structure.html
inspector/evaluate-in-frontend.html
inspector/console-clear.html
- DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting): (WebCore::isWebInspectorTest): (WebCore::DumpRenderTree::open):
- DumpRenderTree/qt/DumpRenderTreeQt.h: (WebCore::DumpRenderTree::display):
- DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::closeWebInspector): (LayoutTestController::showWebInspector): (LayoutTestController::evaluateInWebInspector): (LayoutTestController::setTimelineProfilingEnabled): (LayoutTestController::display):
- DumpRenderTree/qt/LayoutTestControllerQt.h:
- 2:51 AM Changeset in webkit [54771] by
-
- 2 edits in trunk/WebCore
2010-02-15 Pavel Feldman <pfeldman@chromium.org>
Not reviewed: touch InspectorController in order to kick win bot tests
with new injected script contents.
- inspector/InspectorController.cpp:
- 2:44 AM QtWebKitTableOfFeatures46 edited by
- (diff)
- 2:34 AM Changeset in webkit [54770] by
-
- 8 edits in trunk/WebCore
2010-02-14 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: highlight actual search match in elements panel.
- inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel.prototype.searchCanceled): (WebInspector.ElementsPanel.prototype.performSearch): (WebInspector.ElementsPanel.prototype.addNodesToSearchResult): (WebInspector.ElementsPanel.prototype.jumpToNextSearchResult): (WebInspector.ElementsPanel.prototype.jumpToPreviousSearchResult): (WebInspector.ElementsPanel.prototype._highlightCurrentSearchResult): (WebInspector.ElementsPanel.prototype._hideSearchHighlights):
- inspector/front-end/InjectedScript.js:
- inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype.findSearchMatches):
- inspector/front-end/TextViewer.js: (WebInspector.TextViewer.prototype._paintLine):
- inspector/front-end/textViewer.css:
- inspector/front-end/utilities.js:
- 2:22 AM QtWebKitTableOfFeatures46 edited by
- (diff)
- 2:20 AM Changeset in webkit [54769] by
-
- 8 edits in trunk
2010-02-14 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: XPathResult objects are not expanded in console.
- inspector/front-end/InjectedScript.js: (injectedScriptConstructor):
- inspector/front-end/ObjectPropertiesSection.js: (WebInspector.ObjectPropertiesSection.prototype.updateProperties): (WebInspector.ObjectPropertiesSection.CompareProperties): (WebInspector.ObjectPropertyTreeElement.prototype.update):
- inspector/front-end/Section.js: (WebInspector.Section):
- inspector/front-end/inspector.css:
Tests:
- inspector/console-dir-expected.txt:
- inspector/console-dir.html:
- 2:20 AM QtWebKitTableOfFeatures46 edited by
- (diff)
- 2:14 AM QtWebKitTableOfFeatures46 edited by
- (diff)
- 2:07 AM QtWebKitTableOfFeatures46 edited by
- (diff)
- 1:51 AM Changeset in webkit [54768] by
-
- 4 edits in trunk/LayoutTests
2010-02-15 Philippe Normand <pnormand@igalia.com>
media/video-display-aspect-ratio.html fails
https://bugs.webkit.org/show_bug.cgi?id=34933
Skipped the new test that fails.
- platform/mac-leopard/Skipped:
- platform/mac-snowleopard/Skipped:
- platform/win/Skipped:
- 1:28 AM Changeset in webkit [54767] by
-
- 4 edits in trunk/WebKit/qt
2010-02-12 Antti Koivisto <koivisto@iki.fi>
Reviewed by Kenneth Rohde Christiansen and Simon Hausmann.
https://bugs.webkit.org/show_bug.cgi?id=34885
Add a QGraphicsWebView mode that makes it automatically resize itself to the size of the content.
This is useful for cases where the client wants to implement page panning and zooming by manipulating
the graphics item.
Add a option to QGVLauncher to test this mode.
- Api/qgraphicswebview.cpp: (QGraphicsWebViewPrivate::QGraphicsWebViewPrivate): (QGraphicsWebViewPrivate::updateResizesToContentsForPage): (QGraphicsWebViewPrivate::_q_contentsSizeChanged): (QGraphicsWebView::setPage): (QGraphicsWebView::setResizesToContents): (QGraphicsWebView::resizesToContents):
- Api/qgraphicswebview.h:
- QGVLauncher/main.cpp: (WebView::WebView): (MainView::MainView): (MainView::setMainWidget): (MainView::resizeEvent): (main):
- 12:48 AM Changeset in webkit [54766] by
-
- 3 edits3 adds in trunk
2010-02-10 Philippe Normand <pnormand@igalia.com>
Reviewed by Gustavo Noronha Silva.
[Gtk] wrong video aspect ratio
https://bugs.webkit.org/show_bug.cgi?id=34790
Fixed natural size calculation regarding pixel aspect ratio and
display aspect ratio.
Test: media/video-display-aspect-ratio.html
- platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::greatestCommonDivisor): (WebCore::MediaPlayerPrivate::naturalSize):
2010-02-12 Philippe Normand <pnormand@igalia.com>
Reviewed by Gustavo Noronha Silva.
[Gtk] wrong video aspect ratio
https://bugs.webkit.org/show_bug.cgi?id=34790
Test checking the size of a 4:3 video with a 16:9 pixel aspect
ratio.
- media/content/test-par-16-9.mp4: Added.
- media/video-display-aspect-ratio-expected.txt: Added.
- media/video-display-aspect-ratio.html: Added.
Feb 14, 2010:
- 10:31 PM Changeset in webkit [54765] by
-
- 2 edits in trunk/JavaScriptCore
2010-02-14 Laszlo Gombos <Laszlo Gombos>
Reviewed by Adam Barth.
Implement NEVER_INLINE and NO_RETURN for RVCT
https://bugs.webkit.org/show_bug.cgi?id=34740
- wtf/AlwaysInline.h:
- 10:05 PM Changeset in webkit [54764] by
-
- 3 edits4 adds in trunk
2010-02-14 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
HTML5 iframe sandbox bypass of window.top.location navigation via <form target="_top">
https://bugs.webkit.org/show_bug.cgi?id=33277
Add a test that _top is covered by @sandbox.
- http/tests/security/resources/fail.html: Added.
- http/tests/security/resources/sandboxed-iframe-form-top.html: Added.
- http/tests/security/sandboxed-iframe-form-top-expected.txt: Added.
- http/tests/security/sandboxed-iframe-form-top.html: Added.
2010-02-14 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
HTML5 iframe sandbox bypass of window.top.location navigation via <form target="_top">
https://bugs.webkit.org/show_bug.cgi?id=33277
submitForm wasn't respecting shouldAllowNavigation. Instead of calling
the wrapper function, we need to call shouldAllowNavigation because we
need to handle the "frame not found" case differently than the
"navigation denied" case.
Test: http/tests/security/sandboxed-iframe-form-top.html
- loader/FrameLoader.cpp: (WebCore::FrameLoader::submitForm):
- 9:47 PM Changeset in webkit [54763] by
-
- 4 edits in trunk/WebKit/chromium
2010-02-14 Vangelis Kokkevis <vangelis@chromium.org>
Reviewed by Darin Fisher.
[Chromium] Add support for the showDebugBorders setting to Chromium.
- public/WebSettings.h: Add declaration for setShowDebugBorders
- src/WebSettingsImpl.cpp: (WebKit::WebSettingsImpl::setShowDebugBorders): Add method implementation
- src/WebSettingsImpl.h: Added declaration for setShowDebugBorders
- 9:31 PM Changeset in webkit [54762] by
-
- 2 edits in trunk/WebKit/gtk
2010-02-14 Diego Escalante Urrelo <descalante@igalia.com>
Reviewed by Gustavo Noronha Silva.
[gtk] WebKitDownload's currentSize property is guint, should be guint64
https://bugs.webkit.org/show_bug.cgi?id=34829
Actually use a guint64 for current-size property in WebKitDownload, we
were using a guint which is likely the cause for wrong sizes for files
over 4 Gb.
- webkit/webkitdownload.cpp:
- 9:14 PM Changeset in webkit [54761] by
-
- 3 edits in trunk/LayoutTests
2010-02-14 Shu Chang <Chang.Shu@nokia.com>
Reviewed by Adam Barth.
[Qt] The original test case failed on Qt because its real output
"A B C DE F" did not match the expected "A B C D E F". The input
field between D and E failed to generate the space in the dumped
text as it normally would if it was broken into a new line.
This DRT issue can be addressed in a seperate bug if necessary
but shrinking the size of font so as to fit all fields into one
line is an immediate fix to pass the test case.
https://bugs.webkit.org/show_bug.cgi?id=33093
- fast/html/text-field-input-types.html:
- platform/qt/Skipped:
- 8:58 PM Changeset in webkit [54760] by
-
- 10 edits in trunk/WebKitTools
2010-02-14 Dirk Pranke <dpranke@chromium.org>
Reviewed by Eric Seidel.
Update rebaseline-chromium-webkit-tests to work with the new code
structure (port objects instead of path_utils and platform_utils).
Added a path_to_test_expectations_file() to the Port interface.
Fixed a bug in the chromium_* platform implementations where the
'target' option was assumed to be set.
- Scripts/rebaseline-chromium-webkit-tests:
- Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
- Scripts/webkitpy/layout_tests/port/base.py:
- Scripts/webkitpy/layout_tests/port/chromium.py:
- Scripts/webkitpy/layout_tests/port/chromium_linux.py:
- Scripts/webkitpy/layout_tests/port/chromium_mac.py:
- Scripts/webkitpy/layout_tests/port/chromium_win.py:
- Scripts/webkitpy/layout_tests/port/test.py:
- Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
- 8:42 PM Changeset in webkit [54759] by
-
- 3 edits in trunk/WebKitTools
2010-02-14 Eric Seidel <eric@webkit.org>
Reviewed by Darin Adler.
webkit-build-directory misuses terms
https://bugs.webkit.org/show_bug.cgi?id=34822
- Scripts/webkit-build-directory:
- Add --top-level and --configuration options and make using one of them required.
- Scripts/webkitpy/layout_tests/port/mac.py:
- Use --top-level instead of --base.
- 8:08 PM Changeset in webkit [54758] by
-
- 5 edits in trunk/WebCore
2010-02-14 Kent Tamura <tkent@chromium.org>
No review. Touch RenderRuny*.cpp to fix Chromium/Windows build bot.
- rendering/RenderRuby.cpp: Add a comment for #endf.
- rendering/RenderRubyBase.cpp: Add a comment for #endf.
- rendering/RenderRubyRun.cpp: Add a comment for #endf.
- rendering/RenderRubyText.cpp: Add a comment for #endf.
- 8:22 AM Changeset in webkit [54757] by
-
- 4 edits in trunk
2010-02-14 Chang Shu <Chang.Shu@nokia.com>
Reviewed by Laszlo Gombos.
[Qt] Enable appcache feature.
https://bugs.webkit.org/show_bug.cgi?id=34713
Re-land r54543 without the change in DumpRenderTree/qt/main.cpp.
Persistent storage for AppCache is already initialized in
DumpRenderTreeQt.cpp.
- DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::WebPage::WebPage):
2010-02-14 Chang Shu <Chang.Shu@nokia.com>
Reviewed by Laszlo Gombos.
[Qt] Enable http/tests/appcache but skip the failed cases.
https://bugs.webkit.org/show_bug.cgi?id=34713
- platform/qt/Skipped:
- 1:17 AM Changeset in webkit [54756] by
-
- 3 edits in trunk/WebCore
2010-02-13 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: cache created row, span and text elements
in TextView to improve scroller performance on debug build.
- inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype.set visible):
- inspector/front-end/TextViewer.js: (WebInspector.TextViewer): (WebInspector.TextViewer.prototype.freeCachedElements): (WebInspector.TextViewer.prototype._buildChunks): (WebInspector.TextViewer.prototype._makeLineAChunk): (WebInspector.TextViewer.prototype._paintLine): (WebInspector.TextViewer.prototype._releaseLines): (WebInspector.TextViewer.prototype._appendSpan): (WebInspector.TextViewer.prototype._appendTextNode): (WebInspector.TextChunk): (WebInspector.TextChunk.prototype.set expanded): (WebInspector.TextChunk.prototype._lineNumberText): (WebInspector.TextChunk.prototype._createRow):
Feb 13, 2010:
- 10:22 PM UsingGitWithWebKit edited by
- Added tip on how to determine the path to git. (diff)
- 9:13 PM WikiStart edited by
- Made "Debugging WebKit with XCode" link directly to webkit.org. (diff)
- 1:44 PM ImprovingLifeOnWindows edited by
- Setting WebKitOutputDir and WebKitLibrariesDir landed in r51932 (diff)
- 1:41 PM BuildingOnWindows edited by
- Adding information about not being able to find SafariTheme.dll … (diff)
- 1:06 PM Changeset in webkit [54755] by
-
- 1 edit in trunk/WebCore/html/HTMLInputElement.cpp
Build fix for Windows, initialize success to false.
- 11:52 AM Changeset in webkit [54754] by
-
- 5 edits in trunk/WebCore
2010-02-13 Kent Tamura <tkent@chromium.org>
Reviewed by Darin Adler.
Refactor parsing/serialization functions in HTMLInputElement.
https://bugs.webkit.org/show_bug.cgi?id=34852
- Rename formStringToDouble() to parseToDoubleForNumberType()
- Rename formStringToDateComponents() to parseToDateComponents()
- Rename formStringFromDouble() to serializeForNumberType()
- Add serializeForDateTimeTypes() The code is moved from setValueAsDate() and setDateValue().
- Add serialize()
parseToDouble() is the top-level function to parse a
type-dependent string and return a double
value. parseToDoubleForNumber() and parseToDateComponents()
functions are helper functions for it. serialize() is the
top-level function to serialize a double value to a type-dependent
string, and serializeForNumberType() and
serializeForDateTimeTypes() are helper functions for it.
No tests because of no functional changes.
- html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::stepMismatch): (WebCore::HTMLInputElement::getAllowedValueStep): (WebCore::HTMLInputElement::parseToDouble): (WebCore::HTMLInputElement::valueAsDate): (WebCore::HTMLInputElement::setValueAsDate): (WebCore::HTMLInputElement::setValueAsNumber): (WebCore::HTMLInputElement::serializeForDateTimeTypes): (WebCore::HTMLInputElement::serialize): (WebCore::HTMLInputElement::serializeForNumberType): (WebCore::HTMLInputElement::parseToDoubleForNumberType): (WebCore::HTMLInputElement::parseToDateComponents):
- html/HTMLInputElement.h:
- html/ValidityState.cpp: (WebCore::ValidityState::typeMismatch):
- rendering/RenderSlider.cpp: (WebCore::SliderRange::valueFromElement): (WebCore::RenderSlider::updateFromElement): (WebCore::RenderSlider::setValueForPosition):
- 7:39 AM Changeset in webkit [54753] by
-
- 2 edits in trunk/LayoutTests
[Qt] Skip new test that fails. See https://webkit.org/b/34918.
- platform/qt/Skipped: fast/text/glyph-reordering.html skipped.
- 6:04 AM Changeset in webkit [54752] by
-
- 2 edits in trunk/LayoutTests
2010-02-13 Gustavo Noronha Silva <Gustavo Noronha Silva>
Skip new test that fails. See https://webkit.org/b/34918.
- platform/gtk/Skipped:
Feb 12, 2010:
- 11:53 PM Changeset in webkit [54751] by
-
- 2 edits in trunk/WebKitTools
- 9:14 PM Changeset in webkit [54750] by
-
- 1 edit1 add in trunk/LayoutTests
2010-02-12 Ojan Vafai <ojan@chromium.org>
Reviewed by Dan Bernstein.
text-control-intrinsic-widths.html failing on tiger bot
https://bugs.webkit.org/show_bug.cgi?id=34917
Final cleanup for http://trac.webkit.org/changeset/54748.
Some MS fonts don't come with a default install of Tiger, but do
come with a default Leopard/SnowLeopard install. As a result we naturally
get different metrics a page uses these fonts.
- platform/mac-tiger/fast/forms/text-control-intrinsic-widths-expected.txt: Added.
- 8:43 PM Changeset in webkit [54749] by
-
- 3 edits1 move1 add in trunk/LayoutTests
2010-02-12 Ojan Vafai <ojan@chromium.org>
Reviewed by Maciej Stachowiak.
Four textcontrol tests fail after http://trac.webkit.org/changeset/54748
https://bugs.webkit.org/show_bug.cgi?id=34916
-Put the baseline for text-control-intrinsic-widths in the right place!
-I missed perspective-non-layer.html because we don't run it on Leopard.
-Accidentally deleted drag-text-delay-expected.txt and text-control-intrinsic-widths-expected.txt
instead of updating their results.
- platform/mac-leopard/fast/forms/text-control-intrinsic-widths-expected.txt: Removed.
- platform/mac/fast/forms/text-control-intrinsic-widths-expected.txt:
- platform/mac/transforms/3d/general/perspective-non-layer-expected.txt:
- platform/win/editing/selection/drag-text-delay-expected.txt: Added.
- platform/win/fast/forms/text-control-intrinsic-widths-expected.txt: Added.
- 7:20 PM Changeset in webkit [54748] by
-
- 437 edits123 deletes in trunk
2010-01-05 Ojan Vafai <ojan@chromium.org>
Reviewed by Eric Seidel.
Improve text control instrinsic widths.
https://bugs.webkit.org/show_bug.cgi?id=25566
https://bugs.webkit.org/show_bug.cgi?id=25581
https://bugs.webkit.org/show_bug.cgi?id=25958
Excluding list of updated results as the list is so long.
2010-01-05 Ojan Vafai <ojan@chromium.org>
Reviewed by Dan Bernstein.
Improve text control intrinsic widths.
https://bugs.webkit.org/show_bug.cgi?id=25566
https://bugs.webkit.org/show_bug.cgi?id=25581
https://bugs.webkit.org/show_bug.cgi?id=25958
For Mac fonts that have invalid avgCharWidth entries in the OS/2 table,
fallback to the Safari 4- behavior of using the width of a zero. For other
fonts, make Mac match Windows (and thus IE) metrics.
Lucida Grande is hard-coded to match MS Shell Dlg for inputs and
Courier New for textareas in order to match Safari Win, Firefox and, in
some cases IE (IE uses different default fonts depending on encoding).
The only case where we still don't match Windows is if no font-size is
set. The default font-size for form controls on the Mac is smaller and
thus text-control widths will be slightly smaller.
No new tests. Covered by existing tests.
- platform/graphics/mac/SimpleFontDataMac.mm: (WebCore::SimpleFontData::platformCharWidthInit):
- rendering/RenderTextControl.cpp: (WebCore::): (WebCore::RenderTextControl::hasValidAvgCharWidth): (WebCore::RenderTextControl::getAvgCharWidth): (WebCore::RenderTextControl::calcPrefWidths):
- rendering/RenderTextControl.h: (WebCore::RenderTextControl::scaleEmToUnits):
- rendering/RenderTextControlMultiLine.cpp: (WebCore::RenderTextControlMultiLine::getAvgCharWidth):
- rendering/RenderTextControlMultiLine.h:
- rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::getAvgCharWidth): (WebCore::RenderTextControlSingleLine::preferredContentWidth):
- rendering/RenderTextControlSingleLine.h:
- 7:09 PM Changeset in webkit [54747] by
-
- 5 edits in trunk/JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=33731
Remove uses of PtrAndFlags from JIT data stuctures.
Reviewed by Oliver Hunt.
These break the OS X Leaks tool. Free up a bit in CallLinkInfo, and invalid
permutation of pointer states in MethodCallLinkInfo to represent the removed bits.
- bytecode/CodeBlock.h:
(JSC::CallLinkInfo::seenOnce):
(JSC::CallLinkInfo::setSeen):
(JSC::MethodCallLinkInfo::MethodCallLinkInfo):
(JSC::MethodCallLinkInfo::seenOnce):
(JSC::MethodCallLinkInfo::setSeen):
- jit/JIT.cpp:
(JSC::JIT::unlinkCall):
- jit/JITPropertyAccess.cpp:
(JSC::JIT::patchMethodCallProto):
- runtime/UString.h:
- 7:01 PM Changeset in webkit [54746] by
-
- 2 edits in trunk/WebCore
2010-02-11 Ariya Hidayat <ariya.hidayat@gmail.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Unnecessary QBrush construction for doing a solid color stroke
https://bugs.webkit.org/show_bug.cgi?id=34874
Use the similar trick like in r54347, i.e. use the special brush for
solid color to avoid expensive QBrush constructor.
- platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::setPlatformStrokeColor):
- 5:46 PM Changeset in webkit [54745] by
-
- 2 edits in trunk/WebKitTools
Ignore compiled Python in more of webkitpy.
- Scripts/webkitpy/style/processors: Added property svn:ignore.
- 5:18 PM Changeset in webkit [54744] by
-
- 24 edits in branches/safari-532-branch
.: Merged from trunk:
2010-02-11 Maciej Stachowiak <mjs@apple.com>
Reviewed by Cameron Zwarich.
Restore ENABLE_RUBY flag so vendors can ship with Ruby disabled if they choose.
https://bugs.webkit.org/show_bug.cgi?id=34698
- configure.ac:
JavaScriptCore: Merged from trunk:
2010-02-11 Maciej Stachowiak <mjs@apple.com>
Reviewed by Cameron Zwarich.
Restore ENABLE_RUBY flag so vendors can ship with Ruby disabled if they choose.
https://bugs.webkit.org/show_bug.cgi?id=34698
- Configurations/FeatureDefines.xcconfig:
WebCore: Merged from trunk:
2010-02-11 Maciej Stachowiak <mjs@apple.com>
Reviewed by Cameron Zwarich.
Restore ENABLE_RUBY flag so vendors can ship with Ruby disabled if they choose.
https://bugs.webkit.org/show_bug.cgi?id=34698
- Configurations/FeatureDefines.xcconfig:
- DerivedSources.make:
- GNUmakefile.am:
- html/HTMLTagNames.in: Make the ruby-related tag names conditional.
- rendering/RenderObject.cpp:
(WebCore::RenderObject::createObject): ifdef the code that would create ruby elements.
- rendering/RenderObject.h: ditto above
- rendering/RenderRuby.cpp: ifdef this whole file
- rendering/RenderRuby.h: ditto
- rendering/RenderRubyBase.cpp: ditto
- rendering/RenderRubyBase.h: ditto
- rendering/RenderRubyRun.cpp: ditto
- rendering/RenderRubyRun.h: ditto
- rendering/RenderRubyText.cpp: ditto
- rendering/RenderRubyText.h: ditto
WebKit/mac: Merged from trunk:
2010-02-11 Maciej Stachowiak <mjs@apple.com>
Reviewed by Cameron Zwarich.
Restore ENABLE_RUBY flag so vendors can ship with Ruby disabled if they choose.
https://bugs.webkit.org/show_bug.cgi?id=34698
- Configurations/FeatureDefines.xcconfig:
WebKitLibraries: Restore ENABLE_RUBY flag so vendors can ship with Ruby disabled if they choose.
https://bugs.webkit.org/show_bug.cgi?id=34698
Reviewed by Cameron Zwarich.
- win/tools/vsprops/FeatureDefines.vsprops:
WebKitTools: Merged from trunk:
2010-02-11 Maciej Stachowiak <mjs@apple.com>
Reviewed by Cameron Zwarich.
Restore ENABLE_RUBY flag so vendors can ship with Ruby disabled if they choose.
https://bugs.webkit.org/show_bug.cgi?id=34698
- Scripts/build-webkit:
- 3:57 PM Changeset in webkit [54743] by
-
- 3 edits in trunk/JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=33731
Many false leaks in release builds due to PtrAndFlags
Reviewed by Darin Adler.
Remove UntypedPtrAndBitfield (similar to PtrAndFlags) in UStringImpl,
and steal bits from the refCount instead.
- runtime/UStringImpl.cpp:
(JSC::UStringImpl::baseSharedBuffer):
(JSC::UStringImpl::~UStringImpl):
- runtime/UStringImpl.h:
(JSC::UStringImpl::cost):
(JSC::UStringImpl::isIdentifier):
(JSC::UStringImpl::setIsIdentifier):
(JSC::UStringImpl::ref):
(JSC::UStringImpl::deref):
(JSC::UStringImpl::UStringImpl):
(JSC::UStringImpl::bufferOwnerString):
(JSC::UStringImpl::bufferOwnership):
(JSC::UStringImpl::isStatic):
(JSC::UStringImpl::):
- 3:29 PM Changeset in webkit [54742] by
-
- 8 edits1 add in trunk
2010-02-11 Darin Fisher <darin@chromium.org>
Reviewed by Jeremy Orlow.
Introduce WebCookieJar, and provide for a frame specific cookie jar.
- WebKit.gyp:
- public/WebCookieJar.h: Added.
- public/WebFrameClient.h: (WebKit::WebFrameClient::cookieJar):
- public/WebKitClient.h: (WebKit::WebKitClient::cookieJar): (WebKit::WebKitClient::setCookies): (WebKit::WebKitClient::cookies): (WebKit::WebKitClient::rawCookies): (WebKit::WebKitClient::deleteCookie): (WebKit::WebKitClient::cookiesEnabled):
- src/ChromiumBridge.cpp: (WebCore::getCookieJar): (WebCore::ChromiumBridge::setCookies): (WebCore::ChromiumBridge::cookies): (WebCore::ChromiumBridge::rawCookies): (WebCore::ChromiumBridge::deleteCookie): (WebCore::ChromiumBridge::cookiesEnabled):
- 3:21 PM Changeset in webkit [54741] by
-
- 10 edits3 deletes in trunk
2010-02-12 Eric Seidel <eric@webkit.org>
No review, rolling out r54694.
http://trac.webkit.org/changeset/54694
https://bugs.webkit.org/show_bug.cgi?id=34633
This appears to have caused crashes on the Leopard bot. See
bug 34898.
- websocket/tests/bufferedAmount-after-close-expected.txt: Removed.
- websocket/tests/bufferedAmount-after-close.html: Removed.
- websocket/tests/script-tests/bufferedAmount-after-close.js: Removed.
2010-02-12 Eric Seidel <eric@webkit.org>
No review, rolling out r54694.
http://trac.webkit.org/changeset/54694
https://bugs.webkit.org/show_bug.cgi?id=34633
This appears to have caused crashes on the Leopard bot. See
bug 34898.
- websockets/ThreadableWebSocketChannelClientWrapper.h: (WebCore::ThreadableWebSocketChannelClientWrapper::didClose):
- websockets/WebSocket.cpp: (WebCore::WebSocket::WebSocket): (WebCore::WebSocket::send): (WebCore::WebSocket::close): (WebCore::WebSocket::bufferedAmount): (WebCore::WebSocket::didConnect): (WebCore::WebSocket::didClose):
- websockets/WebSocket.h:
- websockets/WebSocketChannel.cpp: (WebCore::WebSocketChannel::WebSocketChannel): (WebCore::WebSocketChannel::send): (WebCore::WebSocketChannel::bufferedAmount): (WebCore::WebSocketChannel::didClose):
- websockets/WebSocketChannel.h:
- websockets/WebSocketChannelClient.h: (WebCore::WebSocketChannelClient::didClose):
- websockets/WorkerThreadableWebSocketChannel.cpp: (WebCore::workerContextDidClose): (WebCore::WorkerThreadableWebSocketChannel::Peer::didClose):
- websockets/WorkerThreadableWebSocketChannel.h:
- 2:42 PM Changeset in webkit [54740] by
-
- 4 edits in trunk/WebCore
Workers' EventListeners should be removed before JSGlobalData is destroyed
https://bugs.webkit.org/show_bug.cgi?id=34903
Reviewed by Sam Weinig.
(Patch co-developed with Alexey Proskuryakov).
Since http://trac.webkit.org/changeset/54460 the EventListeners registered by a
worker thread are not removed until after the thread's JSGlobalData has been
destroyed. This is slightly worrisome since the JSEventListener contains
JSObject*s, which will be dangling once the heap is destroyed. The
JSEventListeners may also reference the worker thread's normal world, which
again it makes no sense to keep around after the JSGlobalData is freed.
Remove all event listeners immediately prior to tearing down the JSGlobalData.
https://bugs.webkit.org/show_bug.cgi?id=34728 addressed the symptoms of this
problem, and it is probably cleaner to make the client data's normal world no
longer be a member (since it is a ref-counted object), however they should be
no requirement to 'detatch' – it makes no sense for anyone to be referencing
the world after the JSGlobalData has gone away (the world's purpose is to hold
wrapper objects in the JSGlobalData's heap). Keep the restructuring that makes
the normal world no longer be a member, but remove the detach mechanism this
patch added & replace with stronger ASSERTs.
- bindings/js/JSDOMBinding.cpp:
(WebCore::DOMWrapperWorld::~DOMWrapperWorld):
- bindings/js/JSDOMBinding.h:
(WebCore::WebCoreJSClientData::~WebCoreJSClientData):
- workers/WorkerThread.cpp:
(WebCore::WorkerThreadShutdownStartTask::performTask):
- 2:27 PM Changeset in webkit [54739] by
-
- 4 edits in branches/safari-4-branch
Versioning.
- 2:27 PM Changeset in webkit [54738] by
-
- 2 edits in trunk/WebKit/chromium
2010-02-12 Pavel Feldman <pfeldman@chromium.org>
Reviewed by David Levin.
Chromium: provide theme overrides for Chromium devtools on Mac.
- src/js/devTools.css:
- 2:26 PM Changeset in webkit [54737] by
-
- 1 copy in tags/Safari-6531.22.7
New tag.
- 2:22 PM Changeset in webkit [54736] by
-
- 5 edits in trunk/WebCore
https://bugs.webkit.org/show_bug.cgi?id=33731
Remove uses of PtrAndFlags from WebCore::StringImpl.
Reviewed by Sam Weinig.
These break the OS X Leaks tool. Use a bits stolen from the refCount to hold the
'InTable' and 'HasTerminatingNullCharacter' flags, along with the string type
(fixes a leak where the string data is allocated at the address (this + 1), and is
misinterpreted as being an internal buffer).
- WebCore.base.exp:
- platform/text/StringImpl.cpp:
(WebCore::StringImpl::StringImpl):
(WebCore::StringImpl::~StringImpl):
(WebCore::StringImpl::create):
(WebCore::StringImpl::createWithTerminatingNullCharacter):
(WebCore::StringImpl::crossThreadString):
(WebCore::StringImpl::sharedBuffer):
- platform/text/StringImpl.h:
(WebCore::StringImpl::):
(WebCore::StringImpl::hasTerminatingNullCharacter):
(WebCore::StringImpl::inTable):
(WebCore::StringImpl::setInTable):
(WebCore::StringImpl::ref):
(WebCore::StringImpl::deref):
(WebCore::StringImpl::hasOneRef):
(WebCore::StringImpl::operator new):
(WebCore::StringImpl::bufferOwnership):
- storage/OriginUsageRecord.cpp:
(WebCore::OriginUsageRecord::addDatabase):
(WebCore::OriginUsageRecord::markDatabase):
- 2:18 PM Changeset in webkit [54735] by
-
- 45 edits8 adds in trunk
2010-02-12 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Dirk Schulze.
Repaint bug on Text selection in foreignObject
https://bugs.webkit.org/show_bug.cgi?id=16939
Tests: svg/overflow/overflow-on-foreignObject.svg
svg/text/foreignObject-text-clipping-bug.xml
Selecting text contained in <foreignObject> leads to artefacts. Same for zooming/panning.
RenderForeignObject contained old legacy code returning FloatRect() for repaintRectInLocalCoordinates,
which is obviously wrong. Fixing that leads to even more problems, as the underlying RenderBlock
did not reflect the x/y translation set on the <foreignObject>. This is problematic, as laying out
positioned objects in the XHTML subtree depends on proper size/location values of the frameRect.
Correctly clip on overflow="hidden". overflow="scroll" & friends are not yet supported, see lengthy
comment in RenderSVGBlock why we either need RenderLayer for RenderForeignObject or need to rework
overflow handling to avoid RenderLayer.
SVGForeignObjectElement uses a hacky custom solution to synchronize CSS width/height properties with
the SVG width/height attributes. Remove all of that code and just implement calcWidth/calcHeight in
RenderForeignObject, grabbing the right values from SVGForeignObjectElement::width/height upon layout.
- rendering/RenderForeignObject.cpp: (WebCore::RenderForeignObject::paint): Clip properly to the actual bounds of the foreignObject, respecting that x/y translation is handled by RenderBlock now. (WebCore::RenderForeignObject::clippedOverflowRectForRepaint): Added missing function, forward to SVGRenderBase just like all other SVG renderers. (WebCore::RenderForeignObject::computeRectForRepaint): Remove manual implementation, forward to SVGRenderBase. (WebCore::RenderForeignObject::localToParentTransform): Respect x/y translation here _after_ applying localTransform(). (WebCore::RenderForeignObject::calcWidth): Override RenderBlock::calcWidth to grab width() from SVGForeignObjectElement. (WebCore::RenderForeignObject::calcHeight): Override RenderBlock::calcHeight to grab height() from SVGForeignObjectElement. (WebCore::RenderForeignObject::layout): Calculate viewport once and cache it. Push x/y location down to RenderBlock - analogous to RenderSVGText. (WebCore::RenderForeignObject::nodeAtFloatPoint): Adapt to x/y translation changes (map through localTransform, not localToParentTransform). Respect overflow clipping. (WebCore::RenderForeignObject::mapLocalToContainer): Set useTransforms=true, to avoid assertions when selecting text in foreign objects.
- rendering/RenderForeignObject.h: (WebCore::RenderForeignObject::objectBoundingBox): Return cached m_viewport. (WebCore::RenderForeignObject::strokeBoundingBox): Ditto. (WebCore::RenderForeignObject::repaintRectInLocalCoordinates): Ditto.
- rendering/RenderSVGBlock.cpp: (WebCore::RenderSVGBlock::setStyle): Cleanup code, move setHasOverflowClip() overrides in updateBoxModelInfoFromStyle where it belongs. (WebCore::RenderSVGBlock::updateBoxModelInfoFromStyle): Added to force setting setHasOverflowClip(false).
- rendering/RenderSVGBlock.h:
- svg/SVGForeignObjectElement.cpp: Kill a lot of custom code - it was just plain wrong to utilize CSS to push width/height information down to RenderBlock. (WebCore::SVGForeignObjectElement::svgAttributeChanged):
- 1:30 PM Changeset in webkit [54734] by
-
- 2 edits in trunk/WebKit/win
onmouseout fired when moving over tooltip on Windows
https://bugs.webkit.org/show_bug.cgi?id=16794
<rdar://5762038>.
Reviewed by Adam Roben.
Add WS_EX_TRANSPARENT to out tooltip HWND so it isn't subject to hit testing, and when
you mouse over the tooltip, it doesn't send a mouseout to the web content.
- WebView.cpp:
(WebView::initializeToolTipWindow): Add WS_EX_TRANSPARENT.
- 1:02 PM Changeset in webkit [54733] by
-
- 2 edits in trunk/WebKit/mac
Removed unneeded custom implementation of isDescendantOf.
Reviewed by Sam Weinig.
- Plugins/WebBaseNetscapePluginView.mm:
(-[WebBaseNetscapePluginView shouldClipOutPlugin]): Use the
-[NSView isDescendantOf:] method instead of our own method
named superviewsHaveSuperviews.
- 1:00 PM Changeset in webkit [54732] by
-
- 2 edits in trunk/JavaScriptCore
Removed an unnecessary data dependency from my last patch.
Reviewed by Darin Adler.
- runtime/SmallStrings.cpp:
(JSC::SmallStrings::markChildren): Since isAnyStringMarked being false
is a condition of entering the loop, we can just use '=' instead of '|='.
- 12:29 PM Changeset in webkit [54731] by
-
- 4 edits in trunk/WebKit/chromium
2010-02-12 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Darin Fisher.
[Chromium] Add a blockedByPolicy output to WebStorageArea::setItem.
https://bugs.webkit.org/show_bug.cgi?id=34897
- public/WebStorageArea.h: (WebKit::WebStorageArea::setItem):
- src/WebStorageAreaImpl.cpp: (WebKit::WebStorageAreaImpl::setItem):
- 11:43 AM Changeset in webkit [54730] by
-
- 4 edits in trunk/WebKit/mac
<rdar://problem/7615234> REGRESSION (r48586): Loading an HTML page causes
PDFKit to be loaded
Reviewed by Darin Adler.
- WebView/WebPDFDocumentExtras.h: Removed the category declaration and
addWebPDFDocumentExtras(). Declare allScriptsInPDFDocument().
- WebView/WebPDFDocumentExtras.mm:
(allScriptsInPDFDocument): Changed the -_web_allScripts method into this function.
- WebView/WebPDFRepresentation.mm: Removed +initialize.
(-[WebPDFRepresentation finishedLoadingWithDataSource:]): Use
allScriptsInPDFDocument() instead of -_web_allScripts.
- 11:20 AM Changeset in webkit [54729] by
-
- 6 edits2 adds in trunk
<rdar://problem/7609268> REGRESSION (r50301): Problem selecting text in a Devanagari website
https://bugs.webkit.org/show_bug.cgi?id=34865
Reviewed by Simon Fraser.
WebCore:
Test: fast/text/glyph-reordering.html
- platform/graphics/mac/ComplexTextController.cpp:
(WebCore::ComplexTextController::ComplexTextRun::ComplexTextRun):
(WebCore::ComplexTextController::ComplexTextRun::setIsNonMonotonic): Added. Sets m_isMonotonic
and populates m_glyphEndOffsets with the end offsets of each glyph’s corresponding character range.
(WebCore::ComplexTextController::advance): For non-monotonic runs, use endOffsetAt() to get
glyphs’ end offsets.
(WebCore::ComplexTextController::adjustGlyphsAndAdvances): Check for monotonicity and call
setIsNonMonotonic() if needed.
- platform/graphics/mac/ComplexTextController.h:
(WebCore::ComplexTextController::ComplexTextRun::lastIndexAt): Added this getter.
(WebCore::ComplexTextController::ComplexTextRun::isMonotonic): Ditto.
- platform/graphics/mac/ComplexTextControllerATSUI.cpp:
(WebCore::ComplexTextController::ComplexTextRun::ComplexTextRun): Initialize m_isMonotonic.
- platform/graphics/mac/ComplexTextControllerCoreText.cpp:
(WebCore::ComplexTextController::ComplexTextRun::ComplexTextRun): Ditto.
LayoutTests:
- fast/text/glyph-reordering-expected.txt: Added.
- fast/text/glyph-reordering.html: Added.
- 10:45 AM Changeset in webkit [54728] by
-
- 2 edits in trunk/LayoutTests
Unreviewed trivial fix.
Set Content-Type header, required for chromium test_shell.
- 9:05 AM Changeset in webkit [54727] by
-
- 2 edits in trunk/WebCore
Reviewed by David Levin.
https://bugs.webkit.org/show_bug.cgi?id=34866
Leopard Debug Bot crashed on fast/forms/old-names.html
- html/HTMLFormCollection.cpp: (WebCore::HTMLFormCollection::formCollectionInfo): Removed a misplaced checkConsistency() call. We are not looking at cache content at this point, and caches will be reset on next access.
- 8:05 AM Changeset in webkit [54726] by
-
- 2 edits in trunk/WebKit/chromium
2010-02-11 Jeremy Orlow <jorlow@chromium.org>
Reviewed by David Levin.
[Chromium] Add ENABLE_RUBY to the feature defines gypi
https://bugs.webkit.org/show_bug.cgi?id=34841
- features.gypi:
- 7:38 AM Changeset in webkit [54725] by
-
- 2 edits in trunk/WebKit/chromium
2010-02-12 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Chromium: Web Inspector on an element in a page where JS is blocked crashes the renderer
- src/DebuggerAgentImpl.cpp: (WebKit::DebuggerAgentImpl::createUtilityContext):
- 6:29 AM Changeset in webkit [54724] by
-
- 3 edits in trunk/JavaScriptCore
Additional refptr/passrefptr workarounds for WINSCW compiler
https://bugs.webkit.org/show_bug.cgi?id=28054
Patch by Janne Koskinen <janne.p.koskinen@digia.com> on 2010-02-12
Reviewed by Tor Arne Vestbø.
- wtf/PassRefPtr.h:
(WTF::refIfNotNull):
(WTF::PassRefPtr::PassRefPtr):
(WTF::PassRefPtr::~PassRefPtr):
(WTF::PassRefPtr::clear):
(WTF::::operator):
- wtf/RefPtr.h:
(WTF::RefPtr::RefPtr):
(WTF::::operator):
- 6:22 AM Changeset in webkit [54723] by
-
- 7 edits in trunk
2010-02-12 Diego Gonzalez <diego.gonzalez@openbossa.org>
Reviewed by Kenneth Rohde Christiansen.
Qt DRT now dump the frame loader callbacks when LayoutTestController()
method is called.
LayoutTests:
http/tests/security/mixedContent/data-url-script-in-iframe.html
http/tests/security/mixedContent/empty-url-plugin-in-frame.html
http/tests/security/mixedContent/insecure-css-in-iframe.html
http/tests/security/mixedContent/insecure-iframe-in-iframe.html
http/tests/security/mixedContent/insecure-image-in-iframe.html
http/tests/security/mixedContent/insecure-plugin-in-iframe.html
http/tests/security/mixedContent/insecure-script-in-iframe.html
http/tests/security/mixedContent/redirect-http-to-https-script-in-iframe.html
http/tests/security/mixedContent/redirect-https-to-http-script-in-iframe.html
[Qt] Make possible Qt DRT dump frame load callbacks
https://bugs.webkit.org/show_bug.cgi?id=34702
- platform/qt/Skipped:
2010-02-12 Diego Gonzalez <diego.gonzalez@openbossa.org>
Reviewed by Kenneth Rohde Christiansen.
Qt DRT now dump the frame loader callbacks when LayoutTestController()
method is called.
LayoutTests:
http/tests/security/mixedContent/data-url-script-in-iframe.html
http/tests/security/mixedContent/empty-url-plugin-in-frame.html
http/tests/security/mixedContent/insecure-css-in-iframe.html
http/tests/security/mixedContent/insecure-iframe-in-iframe.html
http/tests/security/mixedContent/insecure-image-in-iframe.html
http/tests/security/mixedContent/insecure-plugin-in-iframe.html
http/tests/security/mixedContent/insecure-script-in-iframe.html
http/tests/security/mixedContent/redirect-http-to-https-script-in-iframe.html
http/tests/security/mixedContent/redirect-https-to-http-script-in-iframe.html
[Qt] Make possible Qt DRT dump frame load callbacks
https://bugs.webkit.org/show_bug.cgi?id=34702
- WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::didDisplayInsecureContent): (WebCore::FrameLoaderClientQt::didRunInsecureContent):
2010-02-12 Diego Gonzalez <diego.gonzalez@openbossa.org>
Reviewed by Kenneth Rohde Christiansen.
Qt DRT now dump the frame loader callbacks when LayoutTestController()
method is called.
LayoutTests:
http/tests/security/mixedContent/data-url-script-in-iframe.html
http/tests/security/mixedContent/empty-url-plugin-in-frame.html
http/tests/security/mixedContent/insecure-css-in-iframe.html
http/tests/security/mixedContent/insecure-iframe-in-iframe.html
http/tests/security/mixedContent/insecure-image-in-iframe.html
http/tests/security/mixedContent/insecure-plugin-in-iframe.html
http/tests/security/mixedContent/insecure-script-in-iframe.html
http/tests/security/mixedContent/redirect-http-to-https-script-in-iframe.html
http/tests/security/mixedContent/redirect-https-to-http-script-in-iframe.html
[Qt] Make possible Qt DRT dump frame load callbacks
https://bugs.webkit.org/show_bug.cgi?id=34702
- DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::reset): (LayoutTestController::dumpFrameLoadCallbacks):
- DumpRenderTree/qt/LayoutTestControllerQt.h:
- 5:48 AM Changeset in webkit [54722] by
-
- 2 edits in trunk/JavaScriptCore
Don't import the cmath functions from std:: for WINSCW.
Patch by Janne Koskinen <janne.p.koskinen@digia.com> on 2010-02-12
Reviewed by Simon Hausmann.
- wtf/MathExtras.h:
- 5:33 AM Changeset in webkit [54721] by
-
- 3 edits in trunk/WebKitTools
Make QtLauncher somewhat useable on S60.
Reviewed by Antti Koivisto.
Show the window fullscreen to make scrollbars appear, resize
the toolbar buttons to 16x16 to give more screen space to
web content and moved the location lineedit into a separate
line.
- QtLauncher/main.cpp:
(LauncherWindow::LauncherWindow):
- QtLauncher/mainwindow.cpp:
(MainWindow::buildUI):
- 5:16 AM Changeset in webkit [54720] by
-
- 3 edits in trunk/WebCore
2010-02-12 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: restore highlighting animation, bring back
keyboard navigation, beautify search results.
- inspector/front-end/TextViewer.js: (WebInspector.TextViewer): (WebInspector.TextViewer.prototype.highlightLine):
- inspector/front-end/textViewer.css:
- 4:55 AM Changeset in webkit [54719] by
-
- 11 edits6 adds in trunk
2010-02-12 Jesus Sanchez-Palencia <jesus.palencia@openbossa.org>
Reviewed by Kenneth Rohde Christiansen.
Support frameset flattening
https://bugs.webkit.org/show_bug.cgi?id=32717
Add expected results of the FrameSet Flattening tests.
- platform/mac/fast/frames/flattening/frameset-flattening-advanced-expected.txt: Added.
- platform/mac/fast/frames/flattening/frameset-flattening-grid-expected.txt: Added.
- platform/mac/fast/frames/flattening/frameset-flattening-simple-expected.txt: Added.
- platform/mac/fast/frames/flattening/frameset-flattening-subframe-resize-expected.txt: Added.
- platform/mac/fast/frames/flattening/frameset-flattening-subframesets-expected.txt: Added.
- platform/mac/Skipped:
2010-02-12 Jesus Sanchez-Palencia <jesus.palencia@openbossa.org>
Reviewed by Kenneth Rohde Christiansen.
Support frameset flattening
https://bugs.webkit.org/show_bug.cgi?id=32717
Add FrameSet Flattening support to Mac DRT.
- DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::setFrameSetFlatteningEnabled):
- DumpRenderTree/win/DumpRenderTree.cpp: (resetDefaultsToConsistentValues):
- DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::setXSSAuditorEnabled):
- DumpRenderTree/wx/LayoutTestControllerWx.cpp: (LayoutTestController::setFrameSetFlatteningEnabled):
- DumpRenderTree/LayoutTestController.cpp: (setFrameSetFlatteningEnabledCallback): (LayoutTestController::staticFunctions):
- DumpRenderTree/LayoutTestController.h:
- DumpRenderTree/mac/DumpRenderTree.mm: (resetDefaultsToConsistentValues):
- DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::setFrameSetFlatteningEnabled):
- 3:03 AM Changeset in webkit [54718] by
-
- 4 edits in trunk/WebCore
2010-02-12 Anton Muhin <antonm@chromium.org>
Reviewed by Adam Barth.
[v8] handle to the document can only own Objects, not Values
https://bugs.webkit.org/show_bug.cgi?id=34854
- bindings/v8/V8DOMWindowShell.cpp: (WebCore::V8DOMWindowShell::updateDocumentWrapper): (WebCore::V8DOMWindowShell::updateDocumentWrapperCache):
- bindings/v8/V8DOMWindowShell.h:
- bindings/v8/custom/V8DocumentCustom.cpp: (WebCore::toV8):
- 2:20 AM Changeset in webkit [54717] by
-
- 3 edits in trunk/JavaScriptCore
2010-02-12 Kwang Yul Seo <skyul@company100.net>
Reviewed by Adam Barth.
Typedef both JSChar and UChar to wchar_t in RVCT.
https://bugs.webkit.org/show_bug.cgi?id=34560
Define both JSChar and UChar to wchar_t as the size
of wchar_t is 2 bytes in RVCT.
- API/JSStringRef.h:
- wtf/unicode/qt4/UnicodeQt4.h:
- 2:13 AM Changeset in webkit [54716] by
-
- 5 edits in trunk
.: Removed WMLInputElement.* from .gitattributes as the file is
now CRLF clean.
Reviewed by Holger Freyther.
- .gitattributes:
WebCore: Replaced stray CRLF with LF.
Reviewed by Holger Freyther.
- wml/WMLInputElement.cpp:
(WebCore::WMLInputElement::suggestedValue):
- wml/WMLInputElement.h:
- 2:02 AM Changeset in webkit [54715] by
-
- 6 edits in trunk
[Qt] Make qtlauncher and qgvlauncher use the generated headers
path to make sure they are correctly generated.
Reviewed by Tor Arne Vestbo.
.:
- WebKit.pri:
WebCore:
- WebCore.pro:
WebKit\qt:
- tests/tests.pri:
- 2:01 AM Changeset in webkit [54714] by
-
- 4 edits1 add in trunk
[Qt] Ensure relative paths in generated .pri files to ensure that
a source package with pre-generated derived sources can be compiled.
- Re-add a separate headers.pri file for WEBKIT_API_HEADERS
- Rename the generated headers.pri to classheaders.pri to avoid
confusion with the one generated by synqt since they don't have the
same content.
- Remove private headers list variable from classheaders.pri
- Use $$PWD in classheaders.pri
- Remove classheaders.pri from the installed files
Reviewed by Tor Arne Vestbo.
WebCore:
- WebCore.pro:
WebKit\qt:
- Api/DerivedSources.pro:
- 2:01 AM Changeset in webkit [54713] by
-
- 4 edits in trunk
[Qt] Manually add support for the install target on Symbian.
This is required to copy the headers over the ones in Qt.
Reviewed by Tor Arne Vestbo.
.:
- WebKit.pro:
WebCore:
- WebCore.pro:
- 2:00 AM Changeset in webkit [54712] by
-
- 4 edits in trunk
[Qt] Minor fixes on QtWebKit headers generation.
- Adds QtWebKit to the generated headers destination path
- Improve compatibility with MinGW
Reviewed by Tor Arne Vestbo.
WebCore:
No new tests. (OOPS!)
- WebCore.pro:
WebKit\qt:
- Api/DerivedSources.pro:
- 1:59 AM Changeset in webkit [54711] by
-
- 3 edits in trunk/WebKit/qt
[Qt] Fix standalone build with MinGW.
Reviewed by nobody, build fix.
- tests/qwebelement/tst_qwebelement.cpp:
- tests/tests.pri:
- 1:47 AM Changeset in webkit [54710] by
-
- 2 edits in trunk/WebKitTools
2010-02-12 Dirk Pranke <dpranke@chromium.org>
Reviewed by Eric Seidel.
Fix typos in driver_test.py
- Scripts/webkitpy/layout_tests/driver_test.py:
- 1:39 AM Changeset in webkit [54709] by
-
- 2 edits in trunk/LayoutTests
[Qt] perl websocket test(s) time out
https://bugs.webkit.org/show_bug.cgi?id=34882
- platform/qt/Skipped: websocket/tests/cookies/httponly-cookie.pl skipped until fix.
- 1:14 AM QtWebKitTableOfFeatures46 edited by
- (diff)
- 12:59 AM Changeset in webkit [54708] by
-
- 3 edits in trunk/WebKitTools
2010-02-12 Simon Hausmann <simon.hausmann@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Make it possible to toggle the use of QGraphicsView in QtLauncher at run-time
https://bugs.webkit.org/show_bug.cgi?id=34844
- QtLauncher/main.cpp: (LauncherWindow::LauncherWindow): (LauncherWindow::initializeView): (LauncherWindow::setupUI):
- QtLauncher/webview.cpp: (WebViewGraphicsBased::WebViewGraphicsBased):
- 12:00 AM Changeset in webkit [54707] by
-
- 19 edits1 copy3 adds in trunk
2010-02-11 Fumitoshi Ukai <ukai@chromium.org>
Reviewed by Alexey Proskuryakov.
WebSocket ignores HttpOnly cookies, but should use in Handshake.
https://bugs.webkit.org/show_bug.cgi?id=34289
- websocket/tests/cookies/echo-cookie_wsh.py: Added.
- websocket/tests/cookies/httponly-cookie-expected.txt: Added.
- websocket/tests/cookies/httponly-cookie.pl: Added.
2010-02-11 Fumitoshi Ukai <ukai@chromium.org>
Reviewed by Alexey Proskuryakov.
WebSocket ignores HttpOnly cookies, but should use in Handshake.
https://bugs.webkit.org/show_bug.cgi?id=34289
Test: websocket/tests/cookies/httponly-cookie.pl
- platform/CookieJar.h: add cookieRequestHeaderFieldValue()
- platform/chromium/ChromiumBridge.h:
- platform/haiku/CookieJarHaiku.cpp: (WebCore::cookieRequestHeaderFieldValue):
- platform/mac/CookieJar.mm: (WebCore::cookies): (WebCore::cookieRequestHeaderFieldValue):
- platform/network/android/CookieJarAndroid.cpp: (WebCore::cookieRequestHeaderFieldValue):
- platform/network/chromium/CookieJarChromium.cpp: (WebCore::cookieRequestHeaderFieldValue):
- platform/network/curl/CookieJarCurl.cpp: (WebCore::cookieRequestHeaderFieldValue):
- platform/network/soup/CookieJarSoup.cpp: (WebCore::cookieRequestHeaderFieldValue):
- platform/network/win/CookieJarCFNetWin.cpp: (WebCore::cookieRequestHeaderFieldValue):
- platform/network/win/CookieJarWin.cpp: (WebCore::cookieRequestHeaderFieldValue):
- platform/qt/CookieJarQt.cpp: (WebCore::cookieRequestHeaderFieldValue):
- websockets/WebSocketHandshake.cpp: (WebCore::WebSocketHandshake::clientHandshakeMessage): use cookieRequestHeaderFieldValue() instead of cookies() to include HttpOnly cookies.
2010-02-11 Fumitoshi Ukai <ukai@chromium.org>
Reviewed by Alexey Proskuryakov.
WebSocket ignores HttpOnly cookies, but should use in Handshake.
https://bugs.webkit.org/show_bug.cgi?id=34289
Update pywebsocket to 0.4.8, which supports cgi directories.
run-webkit-tests and run-webkit-websocketserver will run
pywebsocket, specifying /websocket/test/cookies as cgi directory.
- Scripts/run-webkit-tests:
- Scripts/run-webkit-websocketserver:
- pywebsocket/mod_pywebsocket/standalone.py:
- pywebsocket/setup.py:
Feb 11, 2010:
- 11:52 PM Changeset in webkit [54706] by
-
- 2 edits in trunk
2010-02-11 Fridrich Strba <fridrich.strba@bluewin.ch>
Reviewed by Gustavo Noronha Silva.
Detect properly different versions of libpng out there.
- configure.ac:
- 11:36 PM Changeset in webkit [54705] by
-
- 2 edits in trunk/WebCore
2010-02-11 Ariya Hidayat <ariya.hidayat@gmail.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Use clipRegion instead of clipPath to save lots of CPU cycles.
- platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::clipOut): (WebCore::GraphicsContext::clipOutEllipseInRect):
- 11:20 PM Changeset in webkit [54704] by
-
- 2 edits in trunk/WebKitTools
2010-02-11 Jesus Sanchez-Palencia <jesus.palencia@openbossa.org>
Reviewed by Dan Bernstein.
[Mac] Duplicated setXSSAuditorEnabled preference at Mac DRT
https://bugs.webkit.org/show_bug.cgi?id=34798
Remove duplicated setXSSAuditorEnabled preference at Mac DRT
- DumpRenderTree/mac/DumpRenderTree.mm: (resetDefaultsToConsistentValues):
- 10:42 PM Changeset in webkit [54703] by
-
- 2 edits in trunk/WebCore
2010-02-11 Yuzo Fujishima <yuzo@google.com>
Reviewed by Shinichiro Hamaji.
Rename underscored identifiers in WebCore/css/CSSParser.cpp.
https://bugs.webkit.org/show_bug.cgi?id=34877
Also fix whitespace erros that surface due to the above fix.
This doesn't change the code logic. Hence no new tests are required.
- css/CSSParser.cpp: (WebCore::CSSParser::parseValue):
- 9:14 PM Changeset in webkit [54702] by
-
- 2 edits in trunk/WebCore
2010-02-11 Joseph Pecoraro <Joseph Pecoraro>
Reviewed by Timothy Hatcher.
Web Inspector: Focusing a resource in the inspector should default to content not header
https://bugs.webkit.org/show_bug.cgi?id=34861
- inspector/front-end/Settings.js: (WebInspector.Settings.prototype._load): changed initial default to content tab
- 9:01 PM Changeset in webkit [54701] by
-
- 3 edits in trunk/JavaScriptCore
2010-02-11 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt and Darin Adler.
The rest of the fix for
https://bugs.webkit.org/show_bug.cgi?id=34864 | <rdar://problem/7594198>
Many objects left uncollected after visiting mail.google.com and closing
window
Don't unconditionally hang onto small strings. Instead, hang onto all
small strings as long as any small string is still referenced.
SunSpider reports no change.
- runtime/Collector.cpp: (JSC::Heap::markRoots): Mark the small strings cache last, so it can check if anything else has kept any strings alive.
- runtime/SmallStrings.cpp: (JSC::isMarked): (JSC::SmallStrings::markChildren): Only keep our strings alive if some other reference to at least one of them exists, too.
- 8:59 PM Changeset in webkit [54700] by
-
- 2 edits in trunk/WebCore
2010-02-11 Joseph Pecoraro <Joseph Pecoraro>
Reviewed by Timothy Hatcher.
Web Inspector: Editing Styles Cannot Tab Backwards from a New Style Item
https://bugs.webkit.org/show_bug.cgi?id=34872
- inspector/front-end/StylesSidebarPane.js: (WebInspector.StylePropertiesSection.prototype.update): triggers afterUpdate (WebInspector.StylePropertiesSection.prototype.afterUpdate): factored out _afterUpdate handling
- 7:51 PM Changeset in webkit [54699] by
-
- 2 edits in trunk/WebCore
2010-02-11 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Eric Seidel.
Add roundedIntSize() convenience method converting FloatSize to IntSize, just like roundedIntPoint() converting FloatPoint to IntPoint.
- platform/graphics/FloatSize.h: (WebCore::roundedIntSize):
- 7:13 PM Changeset in webkit [54698] by
-
- 2 edits in trunk/WebKitTools
2010-02-11 Eric Seidel <eric@webkit.org>
No review, build fix only.
webkitdirs.pm has a crazy amount of duplicated feature detection code
https://bugs.webkit.org/show_bug.cgi?id=34869
- Scripts/build-webkit: Fix typo which broke bots.
- 7:04 PM Changeset in webkit [54697] by
-
- 5 edits1 add4 deletes in trunk
2010-02-11 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
webkitdirs.pm has a crazy amount of duplicated feature detection code
https://bugs.webkit.org/show_bug.cgi?id=34869
In editing run-webkit-tests I found these tests were
skipped on all platforms. Removing them since no one is running them.
If we ever need them we can dig them out of SVN history.
- fast/wcss/marquee-dir.xhtml: Removed.
- fast/wcss/marquee-loop.xhtml: Removed.
- fast/wcss/marquee-speed.xhtml: Removed.
- fast/wcss/marquee-style.xhtml: Removed.
2010-02-11 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
webkitdirs.pm has a crazy amount of duplicated feature detection code
https://bugs.webkit.org/show_bug.cgi?id=34869
- Scripts/build-webkit: Use the new hotness.
- Scripts/run-webkit-tests: ditto
- Scripts/webkitdirs.pm: Remove a bunch of bad duplicate code.
- Scripts/webkitperl/features.pm: Added.
- Simplified the 10 methods in webkitdirs.pm into 2 exported methods in this new file.
- 6:51 PM Changeset in webkit [54696] by
-
- 4 edits in trunk/JavaScriptCore
2010-02-11 Geoffrey Garen <ggaren@apple.com>
Reviewed by Gavin Barraclough.
Some progress toward fixing
https://bugs.webkit.org/show_bug.cgi?id=34864 | <rdar://problem/7594198>
Many objects left uncollected after visiting mail.google.com and closing
window
SunSpider reports no change.
Keep weak references, rather than protected references, to cached for-in
property name enumerators.
One problem with protected references is that a chain like
[ gc object 1 ] => [ non-gc object ] => [ gc object 2 ]
takes two GC passes to break, since the first pass collects [ gc object 1 ],
releasing [ non-gc object ] and unprotecting [ gc object 2 ], and only
then can a second pass collect [ gc object 2 ].
Another problem with protected references is that they can keep a bunch
of strings alive long after they're useful. In SunSpider and a few popular
websites, the size-speed tradeoff seems to favor weak references.
- runtime/JSPropertyNameIterator.cpp: (JSC::JSPropertyNameIterator::JSPropertyNameIterator): Moved this constructor into the .cpp file, since it's not used elsewhere.
(JSC::JSPropertyNameIterator::~JSPropertyNameIterator): Added a destructor
to support our weak reference.
- runtime/JSPropertyNameIterator.h: (JSC::Structure::setEnumerationCache): (JSC::Structure::clearEnumerationCache): (JSC::Structure::enumerationCache): Added a function for clearing a Structure's enumeration cache, used by our new destructor. Also fixed indentation to match the rest of the file.
- runtime/Structure.h: Changed from protected pointer to weak pointer.
- 6:37 PM Changeset in webkit [54695] by
-
- 9 edits in trunk
2010-02-11 Kent Tamura <tkent@chromium.org>
Reviewed by Darin Adler.
Fix two issues on maxLength.
https://bugs.webkit.org/show_bug.cgi?id=34783
- Add grapheme test cases
- Improve test result readability
- fast/forms/ValidityState-tooLong-input-expected.txt:
- fast/forms/ValidityState-tooLong-textarea-expected.txt:
- fast/forms/script-tests/ValidityState-tooLong-input.js:
- fast/forms/script-tests/ValidityState-tooLong-textarea.js:
2010-02-11 Kent Tamura <tkent@chromium.org>
Reviewed by Darin Adler.
Fix two issues on maxLength.
https://bugs.webkit.org/show_bug.cgi?id=34783
- ValidityState.tooLong behavior was inconsistent with UIs of <input> and <textarea>. tooLong checked Unicode code point length though the UIs checks grapheme cluster length.
- Setting HTMLTextAreaElement::value didn't update the dirty flag.
- html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::tooLong): Use numGraphemeClusters() instead of length().
- html/HTMLTextAreaElement.cpp: Rename setValue() to setNonDirtyValue(), and introduce setValue() which calls setNonDirtyValue() and sets the dirty flag. (WebCore::HTMLTextAreaElement::childrenChanged): (WebCore::HTMLTextAreaElement::reset): (WebCore::HTMLTextAreaElement::setValue): (WebCore::HTMLTextAreaElement::setNonDirtyValue): (WebCore::HTMLTextAreaElement::setDefaultValue): (WebCore::HTMLTextAreaElement::tooLong): Use numGraphemeClusters() instead of length().
- html/HTMLTextAreaElement.h:
- 6:12 PM Changeset in webkit [54694] by
-
- 10 edits3 adds in trunk
2010-02-11 Fumitoshi Ukai <ukai@chromium.org>
Reviewed by Alexey Proskuryakov.
WebSocket bufferedAmount should not be 0 when send after close.
https://bugs.webkit.org/show_bug.cgi?id=34633
- websocket/tests/bufferedAmount-after-close-expected.txt: Added.
- websocket/tests/bufferedAmount-after-close.html: Added.
- websocket/tests/script-tests/bufferedAmount-after-close.js: Added.
2010-02-11 Fumitoshi Ukai <ukai@chromium.org>
Reviewed by Alexey Proskuryakov.
WebSocket bufferedAmount should not be 0 when send after close.
https://bugs.webkit.org/show_bug.cgi?id=34633
Test: websocket/tests/bufferedAmount-after-close.html
- websockets/ThreadableWebSocketChannelClientWrapper.h: (WebCore::ThreadableWebSocketChannelClientWrapper::didClose):
- websockets/WebSocket.cpp: (WebCore::WebSocket::WebSocket): (WebCore::WebSocket::send): (WebCore::WebSocket::close): (WebCore::WebSocket::bufferedAmount): (WebCore::WebSocket::didConnect): (WebCore::WebSocket::didClose):
- websockets/WebSocket.h:
- websockets/WebSocketChannel.cpp: (WebCore::WebSocketChannel::WebSocketChannel): (WebCore::WebSocketChannel::send): (WebCore::WebSocketChannel::bufferedAmount): (WebCore::WebSocketChannel::didClose):
- websockets/WebSocketChannel.h:
- websockets/WebSocketChannelClient.h: (WebCore::WebSocketChannelClient::didClose):
- websockets/WorkerThreadableWebSocketChannel.cpp: (WebCore::workerContextDidClose): (WebCore::WorkerThreadableWebSocketChannel::Peer::didClose):
- websockets/WorkerThreadableWebSocketChannel.h:
- 5:59 PM Changeset in webkit [54693] by
-
- 7 edits1 add in trunk/WebKitTools
2010-02-11 Daniel Bates <dbates@rim.com>
Reviewed by Adam Barth.
Makes method User.prompt static and adds the parameter repeat
to prompt the user up to repeat times.
- Scripts/test-webkitpy:
- Scripts/webkitpy/bugzilla.py: Substituted method User.prompt for method raw_input.
- Scripts/webkitpy/commands/upload.py: Ditto
- Scripts/webkitpy/credentials.py: Ditto
- Scripts/mock_bugzillatool.py: Updated prototype of MockUser.prompt to match User.prompt.
- Scripts/webkitpy/user.py: Made method prompt static and added parameter repeat.
- Scripts/webkitpy/user_unittest.py: Added.
- 5:48 PM Changeset in webkit [54692] by
-
- 3 edits6 adds in trunk
2010-02-11 Fumitoshi Ukai <ukai@chromium.org>
Reviewed by Alexey Proskuryakov.
WebSocket in Worker failed to close
https://bugs.webkit.org/show_bug.cgi?id=34785
- websocket/tests/workers/close-in-shared-worker-expected.txt: Added.
- websocket/tests/workers/close-in-shared-worker.html: Added.
- websocket/tests/workers/close-in-worker-expected.txt: Added.
- websocket/tests/workers/close-in-worker.html: Added.
- websocket/tests/workers/resources/close-in-worker.js: Added.
- websocket/tests/workers/resources/echo_wsh.py: Copied from LayoutTests/websocket/tests/echo_wsh.py.
2010-02-11 Fumitoshi Ukai <ukai@chromium.org>
Reviewed by Alexey Proskuryakov.
WebSocket in Worker failed to close
https://bugs.webkit.org/show_bug.cgi?id=34785
Tests: websocket/tests/workers/close-in-shared-worker.html
websocket/tests/workers/close-in-worker.html
- websockets/WorkerThreadableWebSocketChannel.cpp: (WebCore::WorkerThreadableWebSocketChannel::close):
- 5:39 PM Changeset in webkit [54691] by
-
- 1 edit37 deletes in trunk/WebKitTools
2010-02-10 Yuzo Fujishima <yuzo@google.com>
Reviewed by Darin Adler.
Allow underscored identifiers in CSSParser.cpp
Flex (http://flex.sourceforge.net/) uses identifiers named as yy_*.
WebCore/css/CSSParser.cpp needs to handle some such identifiers.
We should relax the style rule for the file to allow underscored identifiers.
- Scripts/webkitpy/style/checker.py:
- 5:29 PM Changeset in webkit [54690] by
-
- 2 edits in trunk/WebKitTools
2010-02-10 Yuzo Fujishima <yuzo@google.com>
Reviewed by Darin Adler.
Allow underscored identifiers in CSSParser.cpp
Flex (http://flex.sourceforge.net/) uses identifiers named as yy_*.
WebCore/css/CSSParser.cpp needs to handle some such identifiers.
We should relax the style rule for the file to allow underscored identifiers.
- Scripts/webkitpy/style/checker.py:
- 5:01 PM Changeset in webkit [54689] by
-
- 1 edit2 moves in trunk/LayoutTests
2010-02-11 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed. Oops, move mac-lepard results for mask-invalidation.svg into the correct folder.
- platform/mac-leopard/mask-invalidation-expected.checksum: Removed.
- platform/mac-leopard/mask-invalidation-expected.png: Removed.
- platform/mac-leopard/svg/custom/mask-invalidation-expected.checksum: Copied from platform/mac-leopard/mask-invalidation-expected.checksum.
- platform/mac-leopard/svg/custom/mask-invalidation-expected.png: Copied from platform/mac-leopard/mask-invalidation-expected.png.
- 4:57 PM Changeset in webkit [54688] by
-
- 5 edits1 copy in trunk/WebKitTools
2010-02-11 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Need a command to clear r+ on obsolete patches in the pending-commit queue.
https://bugs.webkit.org/show_bug.cgi?id=34863
Unfortunately our http://webkit.org/pending-commit bugzilla query is not
smart enough to ignore obsolete patches, so bugs show up there which are
still open, but do not have patches ready for landing on them.
This new command "clean-pending-commit" will remove r+ from obsolete patches
in the pending-commit list.
- Scripts/test-webkitpy: Add grammar_unittest
- Scripts/webkitpy/commands/upload.py: Add clean-pending-commit and make assign-to-committer ignore cq+'d patches.
- Scripts/webkitpy/grammar.py: Add join_with_separators
- Scripts/webkitpy/grammar_unittest.py: Added.
- 4:48 PM Changeset in webkit [54687] by
-
- 1 edit2 adds in trunk/LayoutTests
2010-02-11 Nikolas Zimmermann <nzimmermann@rim.com>
Rubber-stamped by Dirk Schulze.
Add special mac-leopard pixel test results for svg/mask-invalidation.svg - has marginal 0.01% diff to snow leopard baseline.
- platform/mac-leopard/mask-invalidation-expected.checksum: Added.
- platform/mac-leopard/mask-invalidation-expected.png: Added.
- 4:38 PM Changeset in webkit [54686] by
-
- 2 edits in trunk/WebKitLibraries
Rubber-stamped by Eric Seidel.
Turn back on SVG Filters on Windows, as they were accidentally disabled and cause
test breakage.
- win/tools/vsprops/FeatureDefines.vsprops:
- 4:36 PM Changeset in webkit [54685] by
-
- 1 edit1 add in trunk/WebCore
2010-02-11 Kwang Yul Seo <skyul@company100.net>
Reviewed by Eric Seidel.
[BREWMP] Add dummy Cursor
https://bugs.webkit.org/show_bug.cgi?id=34672
- platform/brew/CursorBrew.cpp: Added. (WebCore::Cursor::Cursor): (WebCore::Cursor::~Cursor): (WebCore::Cursor::operator=): (WebCore::dummyCursor): (WebCore::pointerCursor): (WebCore::crossCursor): (WebCore::handCursor): (WebCore::moveCursor): (WebCore::iBeamCursor): (WebCore::waitCursor): (WebCore::helpCursor): (WebCore::eastResizeCursor): (WebCore::northResizeCursor): (WebCore::northEastResizeCursor): (WebCore::northWestResizeCursor): (WebCore::southResizeCursor): (WebCore::southEastResizeCursor): (WebCore::southWestResizeCursor): (WebCore::westResizeCursor): (WebCore::northSouthResizeCursor): (WebCore::eastWestResizeCursor): (WebCore::northEastSouthWestResizeCursor): (WebCore::northWestSouthEastResizeCursor): (WebCore::columnResizeCursor): (WebCore::rowResizeCursor): (WebCore::verticalTextCursor): (WebCore::cellCursor): (WebCore::contextMenuCursor): (WebCore::noDropCursor): (WebCore::copyCursor): (WebCore::progressCursor): (WebCore::aliasCursor): (WebCore::noneCursor): (WebCore::notAllowedCursor): (WebCore::zoomInCursor): (WebCore::zoomOutCursor): (WebCore::middlePanningCursor): (WebCore::eastPanningCursor): (WebCore::northPanningCursor): (WebCore::northEastPanningCursor): (WebCore::northWestPanningCursor): (WebCore::southPanningCursor): (WebCore::southEastPanningCursor): (WebCore::southWestPanningCursor): (WebCore::westPanningCursor): (WebCore::grabCursor): (WebCore::grabbingCursor):
- 4:20 PM Changeset in webkit [54684] by
-
- 1 edit1 add in trunk/JavaScriptCore
2010-02-11 Chris Rogers <crogers@google.com>
Reviewed by David Levin.
audio engine: add Complex number class
https://bugs.webkit.org/show_bug.cgi?id=34538
- wtf/Complex.h: Added. (WebCore::complexFromMagnitudePhase):
- 3:38 PM Changeset in webkit [54683] by
-
- 2 edits in trunk/WebKitTools
2010-02-11 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
run-chromium-webkit-tests fails random pixel tests on Mac
https://bugs.webkit.org/show_bug.cgi?id=34862
This is due to the fact that the Mac port has an
invalid path to the image diff tool. Currently it points
to image_diff even though ImageDiff would be correct. We
can't change it to the right path yet without causing the
script to hang. ImageDiff expects to be long-running and
be passed image data over stdin. image_diff (chromium's fork)
expects to be passed command line arguments.
This fix works around the random failures by disabling pixel
tests on mac and logging if the user was trying to run with pixel
tests enabled.
- Scripts/webkitpy/layout_tests/port/mac.py:
- 3:23 PM Changeset in webkit [54682] by
-
- 2 edits in trunk
Touch prefix files to force a rebuild, also so anyone who updates will get a working build
- 3:15 PM Changeset in webkit [54681] by
-
- 2 edits in trunk
Add a missing semicolon to FeatureDefines.vsprops, so both ENABLE_RUBY and ENABLE_SHARED_WORKERS are parsed
- 2:26 PM Changeset in webkit [54680] by
-
- 4 edits in trunk/WebCore
2010-02-11 Nate Chapin <Nate Chapin>
Reviewed by Dimitri Glazkov.
[V8] Add back in a fast path for v8 object wrapping
when it's not possible we're in a WorkerContext (the fast
path is important for performance).
- bindings/scripts/CodeGeneratorV8.pm:
- bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::instantiateV8ObjectInWorkerContext): (WebCore::V8DOMWrapper::instantiateV8Object):
- bindings/v8/V8DOMWrapper.h:
- 2:23 PM Changeset in webkit [54679] by
-
- 1 edit in trunk/WebCore/bindings/js/JSDOMWindowCustom.cpp
Touch JSDOMWindowCustom.cpp to get it to build.
- 2:20 PM Changeset in webkit [54678] by
-
- 1 edit2 deletes in trunk/LayoutTests
2010-02-11 Gustavo Noronha Silva <Gustavo Noronha Silva>
Remove platform-specific expected results that only existed
because we diverged from other ports regarding enabling
GeoLocation (Apple ports now enable it).
- platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt: Removed.
- platform/gtk/fast/dom/prototype-inheritance-2-expected.txt: Removed.
- 2:12 PM Changeset in webkit [54677] by
-
- 3 edits in trunk/LayoutTests
2010-02-11 Gustavo Noronha Silva <Gustavo Noronha Silva>
Rebaseline test after 54646, and skip tests that need results
generated.
- platform/gtk/Skipped:
- platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt:
- 2:12 PM Changeset in webkit [54676] by
-
- 1 edit in trunk/WebCore/page/DOMWindow.idl
Touch DOMWindow.idl to force a rebuild of some of the DOM bindings
- 1:53 PM Changeset in webkit [54675] by
-
- 1 edit in trunk/WebKit/win/WebKitPrefix.h
Touch WebKitPrefix.h to force a WebKit rebuild
- 1:44 PM Changeset in webkit [54674] by
-
- 1 edit in trunk/JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def
That wasn't a fix, rolling it out
- 1:34 PM Changeset in webkit [54673] by
-
- 1 edit in trunk/JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def
Hopefully final build fix for Windows (I really mean it this time)
- 1:28 PM Changeset in webkit [54672] by
-
- 8 edits in trunk
JavaScriptCore: Added an SPI for asking about all the different live objects on the heap.
Useful for memory debugging.
Reviewed by Oliver Hunt.
- JavaScriptCore.exp: Export the new SPI.
- runtime/Collector.cpp:
(JSC::typeName): Use a little capitalization. Don't crash in the case of
a non-object cell, since it might just be an uninitialized cell.
(JSC::Heap::objectTypeCounts): The new SPI.
- runtime/Collector.h:
- runtime/CollectorHeapIterator.h:
(JSC::CollectorHeapIterator::advance):
(JSC::LiveObjectIterator::operator++):
(JSC::DeadObjectIterator::operator++):
(JSC::ObjectIterator::operator++): Made 2 tweaks to these iterators:
(1) Skip the last cell in the block, since it's a dummy sentinel, and
we don't want it to confuse the object count; (2) Fixed a logic error
in LiveObjectIterator that could cause it to iterate dead objects if
m_block were equal to m_heap.nextBlock and m_cell were less than
m_heap.nextCell. No test for this since I can't think of a way that this
could make WebKit behave badly.
WebKit/mac: Exported some new JavaScript heap introspection.
Reviewed by Oliver Hunt.
- Misc/WebCoreStatistics.h:
- Misc/WebCoreStatistics.mm:
(+[WebCoreStatistics javaScriptObjectTypeCounts]): Just like
javaScriptProtectedObjectTypeCounts, except this function enumerates all
live objects, not just protected objects.
- 1:20 PM Changeset in webkit [54671] by
-
- 2 edits in trunk
Turn off 3D_CANVAS and touch WebCorePrefix.h to force a rebuild.
- 1:04 PM Changeset in webkit [54670] by
-
- 1 edit in trunk/WebKit/win/WebView.cpp
Build fix for Windows
- 12:59 PM Changeset in webkit [54669] by
-
- 2 edits in trunk/WebKitTools
2010-02-11 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Adam Roben.
Try to fix build breakage from r54665.
- Scripts/check-for-global-initializers:
- 12:53 PM Changeset in webkit [54668] by
-
- 8 edits in trunk/WebCore
2010-02-11 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Dirk Schulze.
Small cleanups in SVG render tree code.
Centralize calls to inflateShadow(), in SVGRenderSupport::computeRectForRepaint,
instead of spreading them around the subclasses. All classes should inherit
protected from SVGRenderBase, made it consistent.
Doesn't affect layout tests.
- rendering/RenderSVGImage.cpp: (WebCore::RenderSVGImage::computeRectForRepaint):
- rendering/RenderSVGImage.h:
- rendering/RenderSVGModelObject.cpp: (WebCore::RenderSVGModelObject::computeRectForRepaint):
- rendering/RenderSVGRoot.h:
- rendering/RenderSVGText.cpp: (WebCore::RenderSVGText::computeRectForRepaint): (WebCore::RenderSVGText::layout):
- rendering/SVGRenderSupport.cpp: (WebCore::SVGRenderBase::computeRectForRepaint):
- rendering/SVGRootInlineBox.h:
- 12:44 PM Changeset in webkit [54667] by
-
- 2 edits in trunk/WebKit/chromium
2010-02-11 Mikhail Naganov <mnaganov@chromium.org>
Reviewed by Pavel Feldman.
[Chromium] Ignore subsequent requests of the same profiler log
chunks. This eliminates emission of several instances for the same
heap snapshot.
- src/js/ProfilerAgent.js: (devtools.ProfilerAgent): (devtools.ProfilerAgent.prototype.initializeProfiling): (devtools.ProfilerAgent.prototype._getNextLogLines): (devtools.ProfilerAgent.prototype.startProfiling): (devtools.ProfilerAgent.prototype._didGetActiveProfilerModules): (devtools.ProfilerAgent.prototype._didGetLogLines):
- 12:40 PM Changeset in webkit [54666] by
-
- 2 edits in trunk
2010-02-11 Xan Lopez <xlopez@igalia.com>
Try to fix GTK+ build.
- configure.ac:
- 12:05 PM Changeset in webkit [54665] by
-
- 8 edits3 adds in trunk/WebCore
https://bugs.webkit.org/show_bug.cgi?id=34857
Move InlineIterator and BidiRun into new files so subclasses can access them.
Reviewed by Dan Bernstein.
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- rendering/BidiRun.cpp: Added.
(WebCore::BidiRun::destroy):
(WebCore::throw):
(WebCore::BidiRun::operator delete):
- rendering/BidiRun.h: Added.
(WebCore::BidiRun::BidiRun):
(WebCore::BidiRun::next):
- rendering/InlineIterator.h: Added.
(WebCore::InlineIterator::InlineIterator):
(WebCore::operator==):
(WebCore::operator!=):
(WebCore::bidiNext):
(WebCore::bidiFirst):
(WebCore::InlineIterator::increment):
(WebCore::InlineIterator::atEnd):
(WebCore::InlineIterator::current):
(WebCore::InlineIterator::direction):
(WebCore::InlineBidiResolver::increment):
(WebCore::InlineBidiResolver::appendRun):
- rendering/RenderBlock.h:
- rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::appendRunsForObject):
(WebCore::RenderBlock::requiresLineBox):
- 12:03 PM Changeset in webkit [54664] by
-
- 1 edit in trunk/WebCore/platform/graphics/GraphicsContext3D.h
Add a PLATFORM(WIN) check for NO_ERROR, attempted build fix
- 12:01 PM Changeset in webkit [54663] by
-
- 7 edits in trunk/WebCore
Revert accidental commit
- 11:55 AM Changeset in webkit [54662] by
-
- 7 edits in trunk/WebCore
Attempt to fix the Windows build
- 11:43 AM Changeset in webkit [54661] by
-
- 1 edit in trunk/WebCore/WebCorePrefix.h
Touch WebCorePrefix.h to force a rebuild.
- 11:00 AM Changeset in webkit [54660] by
-
- 2 edits in trunk
2010-02-11 Antonio Gomes <tonikitoo@webkit.org>
Adjust gstreamer-plugins-base minimum version check (from 0.10 to 0.10.23).
Reviewed by Xan Lopez.
- configure.ac:
- 10:55 AM Changeset in webkit [54659] by
-
- 32 edits1 move5 adds in trunk/LayoutTests
2010-02-11 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Test that Web Inspector can inspect styles of elements in iframe from a domain
different from main frame domain.
inspector-tests.js moved to LayoutTests/http/tests/inspector because it can
be referenced by relative path from LayoutTests/inspector but not vice versa
(html files served from LayoutTests/http/tests cannot refer it because WebKit
tests httpd doesn't serve content not under LayoutTests/http).
- http/tests/inspector/inspect-iframe-from-different-domain-expected.txt: Added.
- http/tests/inspector/inspect-iframe-from-different-domain.html: Added.
- http/tests/inspector/inspector-test.js: Renamed from LayoutTests/inspector/inspector-test.js. (onload): (evaluateInWebInspector): (notifyDone): (output): (didEvaluateForTestInFrontend):
- http/tests/inspector/resources/iframe-from-different-domain-data.html: Added.
- inspector/console-clear.html:
- inspector/console-dir.html:
- inspector/console-dirxml.html:
- inspector/console-format-collections-expected.txt:
- inspector/console-format-collections.html:
- inspector/console-format.html:
- inspector/console-log-before-inspector-open.html:
- inspector/console-tests.html:
- inspector/cookie-resource-match.html:
- inspector/elements-img-tooltip.html:
- inspector/elements-panel-rewrite-href-expected.txt:
- inspector/elements-panel-rewrite-href.html:
- inspector/elements-panel-selection-on-refresh.html:
- inspector/elements-panel-structure.html:
- inspector/evaluate-in-frontend.html:
- inspector/inspected-objects-not-overriden.html:
- inspector/styles-iframe.html:
- inspector/syntax-highlight-css.html:
- inspector/syntax-highlight-javascript.html:
- inspector/timeline-enum-stability.html:
- inspector/timeline-event-dispatch.html:
- inspector/timeline-layout.html:
- inspector/timeline-mark-timeline.html:
- inspector/timeline-network-resource.html:
- inspector/timeline-paint.html:
- inspector/timeline-parse-html.html:
- inspector/timeline-recalculate-styles.html:
- inspector/timeline-script-tag-1.html:
- inspector/timeline-script-tag-2.html:
- inspector/timeline-trivial.html:
- platform/qt/Skipped:
- 10:27 AM Changeset in webkit [54658] by
-
- 2 edits in trunk/WebCore
Fixes CodeGeneratorV8.pm to include the header for the indexer type when using setCollectionIndexedGetter()
https://bugs.webkit.org/show_bug.cgi?id=34836
setCollectionIndexedGetter() uses getIndexedPropertyOfCollection(),
which in turn uses toV8() with the indexer type, which is declared in
the header for the indexer type.
- 9:16 AM Changeset in webkit [54657] by
-
- 11 edits2 adds3 deletes in trunk/WebCore
2010-02-11 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: split source code into chunks in order to improve text
viewer performance on large files.
This change brings back SourceFrame's canvas+style magic, restores line
wrapping and makes things a lot like they used to be.
It removes TextEditor for now and renames NativeTextViewer into TextViewer.
TextViewer is no longer derived from TextEditor.
This TextViewer is still based on TextEditorModel, no iframes are involved.
Instead of creating div per line, TextViewer splits source code into 50 line
chunks. Upon scroll event, visible chunks are sharded into lines and individual
lines are highlighted. Whenever highlighted region gets outside of the visible
area, highlight spans are thrown away and region is replaced with the original
plain text chunk.
Complex stuff:
- Whenever there is a need to manipulate individual lines (add message bubble / set breakpoint / reveal / etc.), individual chunks for such lines are created.
- There is also an implicit machinery that is maintaining selection when it goes beyond the visible area.
- Search occurrences are implemented as artificial spans interweaving highlighting markup.
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- inspector/front-end/NativeTextViewer.js: Removed.
- inspector/front-end/ScriptView.js: (WebInspector.ScriptView):
- inspector/front-end/Settings.js:
- inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame): (WebInspector.SourceFrame.prototype.set visible): (WebInspector.SourceFrame.prototype.set executionLine): (WebInspector.SourceFrame.prototype.revealLine): (WebInspector.SourceFrame.prototype.addBreakpoint): (WebInspector.SourceFrame.prototype.removeBreakpoint): (WebInspector.SourceFrame.prototype.addMessage): (WebInspector.SourceFrame.prototype.clearMessages): (WebInspector.SourceFrame.prototype.sizeToFitContentHeight): (WebInspector.SourceFrame.prototype.setContent): (WebInspector.SourceFrame.prototype.highlightLine): (WebInspector.SourceFrame.prototype._createViewerIfNeeded): (WebInspector.SourceFrame.prototype.markAndRevealRange): (WebInspector.SourceFrame.prototype.clearMarkedRange): (WebInspector.SourceFrame.prototype._breakpointChanged): (WebInspector.SourceFrame.prototype._updateExecutionLine): (WebInspector.SourceFrame.prototype._addMessageToSource): (WebInspector.SourceFrame.prototype._addExistingBreakpointsToSource): (WebInspector.SourceFrame.prototype._addBreakpointToSource): (WebInspector.SourceFrame.prototype._removeBreakpointFromSource): (WebInspector.SourceFrame.prototype._mouseDown): (WebInspector.SourceFrame.prototype._editBreakpointCondition.committed): (WebInspector.SourceFrame.prototype._editBreakpointCondition.dismissed): (WebInspector.SourceFrame.prototype._editBreakpointCondition): (WebInspector.SourceFrame.prototype._showBreakpointConditionPopup): (WebInspector.SourceFrame.prototype._createConditionElement): (WebInspector.SourceFrame.prototype._keyDown): (WebInspector.SourceFrame.prototype.resize): (WebInspector.SourceFrame.prototype._drawProgramCounterInContext): (WebInspector.SourceFrame.prototype._drawProgramCounterImageIfNeeded): (WebInspector.SourceFrame.prototype._drawBreakpointImagesIfNeeded.drawBreakpoint): (WebInspector.SourceFrame.prototype._drawBreakpointImagesIfNeeded):
- inspector/front-end/SourceView.js: (WebInspector.SourceView): (WebInspector.SourceView.prototype._removeBreakpoint): (WebInspector.SourceView.prototype.searchCanceled): (WebInspector.SourceView.prototype._jumpToSearchResult):
- inspector/front-end/TextEditor.js: Removed.
- inspector/front-end/TextViewer.js: Added. (WebInspector.TextViewer): (WebInspector.TextViewer.prototype.set mimeType): (WebInspector.TextViewer.prototype.get textModel): (WebInspector.TextViewer.prototype.revealLine): (WebInspector.TextViewer.prototype.addDecoration): (WebInspector.TextViewer.prototype.removeDecoration): (WebInspector.TextViewer.prototype.markAndRevealRange): (WebInspector.TextViewer.prototype.highlightLine): (WebInspector.TextViewer.prototype._textChanged): (WebInspector.TextViewer.prototype._createChunkRow): (WebInspector.TextViewer.prototype._makeLineAChunk): (WebInspector.TextViewer.prototype._indexChunks): (WebInspector.TextViewer.prototype._highlightChanged): (WebInspector.TextViewer.prototype._scroll): (WebInspector.TextViewer.prototype.setCoalescingUpdate): (WebInspector.TextViewer.prototype._repaintAll): (WebInspector.TextViewer.prototype._chunkForOffset): (WebInspector.TextViewer.prototype._chunkNumberForLine): (WebInspector.TextViewer.prototype._chunkStartLine): (WebInspector.TextViewer.prototype._restoreChunks): (WebInspector.TextViewer.prototype._repaint): (WebInspector.TextViewer.prototype._getSelection): (WebInspector.TextViewer.prototype._restoreSelection): (WebInspector.TextViewer.prototype._selectionToPosition): (WebInspector.TextViewer.prototype._createLineRow): (WebInspector.TextViewer.prototype._paintLine): (WebInspector.TextViewer.prototype._createSpan): (WebInspector.TextViewer.prototype._createLink): (WebInspector.TextViewer.prototype._rewriteHref): (WebInspector.TextViewer.prototype._markRange): (WebInspector.TextViewer.prototype._decimalDigits): (WebInspector.TextViewer.prototype.resize):
- inspector/front-end/WebKit.qrc:
- inspector/front-end/inspector.css:
- inspector/front-end/inspector.html:
- inspector/front-end/textEditor.css: Removed.
- inspector/front-end/textViewer.css: Added.
- inspector/front-end/utilities.js: (Node.prototype.traverseNextTextNode): (Node.prototype.rangeBoundaryForOffset):
- 8:18 AM Changeset in webkit [54656] by
-
- 2 edits in trunk/WebCore
[Qt] ENABLE_RUBY flag was restored by r54649, but default value wasn't added for Qt port.
https://bugs.webkit.org/show_bug.cgi?id=34698
Reviewed by Tor Arne Vestbø.
- WebCore.pri: Add ENABLE_RUBY=1 as default setting.
- 8:03 AM Changeset in webkit [54655] by
-
- 2 edits in trunk/JavaScriptCore
Guard cmath using declarations in MathExtras.h on Android
https://bugs.webkit.org/show_bug.cgi?id=34840
- 7:44 AM Changeset in webkit [54654] by
-
- 2 edits in trunk/WebKitTools
Make it possible to toggle accelerated compositing from the menu
at run-time.
Reviewed by Tor Arne Vestbø.
- QtLauncher/main.cpp:
(LauncherWindow::toggleAcceleratedCompositing):
(LauncherWindow::setupUI):
- 7:37 AM QtWebKitTableOfFeatures46 edited by
- (diff)
- 7:33 AM QtWebKitTableOfFeatures46 edited by
- (diff)
- 5:29 AM Changeset in webkit [54653] by
-
- 2 edits in trunk/WebCore
2010-02-11 Steve Block <steveblock@google.com>
Reviewed by Jeremy Orlow.
Updates Android V8 Makefile to generate Notifications and WebSockets headers required by V8DOMWrapper.cpp
https://bugs.webkit.org/show_bug.cgi?id=34815
No new tests, build fix only.
- Android.derived.v8bindings.mk:
- 5:27 AM Changeset in webkit [54652] by
-
- 2 edits in trunk/WebCore
2010-02-11 Steve Block <steveblock@google.com>
Reviewed by Jeremy Orlow.
Updates Android V8 Makefile to generate XPath header required by V8Proxy.cpp
https://bugs.webkit.org/show_bug.cgi?id=34814
No new tests, build fix only.
- Android.derived.v8bindings.mk:
- 3:40 AM Changeset in webkit [54651] by
-
- 2 edits in trunk/WebCore
Update Android V8 Makefile to generate Inspector headers required by V8 ScriptObject.cpp
https://bugs.webkit.org/show_bug.cgi?id=34806
- 3:27 AM Changeset in webkit [54650] by
-
- 5 edits in trunk/WebCore
Guards SVG code in V8 bindings with ENABLE(SVG)
https://bugs.webkit.org/show_bug.cgi?id=34812
Also updates Android V8 Makefile to generate required SVG headers.
No new tests, build fix only.
- 2:55 AM Changeset in webkit [54649] by
-
- 25 edits in trunk
2010-02-08 Maciej Stachowiak <mjs@apple.com>
Reviewed by Cameron Zwarich.
Restore ENABLE_RUBY flag so vendors can ship with Ruby disabled if they choose.
https://bugs.webkit.org/show_bug.cgi?id=34698
- Configurations/FeatureDefines.xcconfig:
2010-02-08 Maciej Stachowiak <mjs@apple.com>
Reviewed by Cameron Zwarich.
Restore ENABLE_RUBY flag so vendors can ship with Ruby disabled if they choose.
https://bugs.webkit.org/show_bug.cgi?id=34698
- win/tools/vsprops/FeatureDefines.vsprops:
2010-02-08 Maciej Stachowiak <mjs@apple.com>
Reviewed by Cameron Zwarich.
Restore ENABLE_RUBY flag so vendors can ship with Ruby disabled if they choose.
https://bugs.webkit.org/show_bug.cgi?id=34698
- Configurations/FeatureDefines.xcconfig:
2010-02-08 Maciej Stachowiak <mjs@apple.com>
Reviewed by Cameron Zwarich.
Restore ENABLE_RUBY flag so vendors can ship with Ruby disabled if they choose.
https://bugs.webkit.org/show_bug.cgi?id=34698
- Configurations/FeatureDefines.xcconfig:
- DerivedSources.make:
- GNUmakefile.am:
- html/HTMLTagNames.in: Make the ruby-related tag names conditional.
- rendering/RenderObject.cpp: (WebCore::RenderObject::createObject): ifdef the code that would create ruby elements.
- rendering/RenderObject.h: ditto above
- rendering/RenderRuby.cpp: ifdef this whole file
- rendering/RenderRuby.h: ditto
- rendering/RenderRubyBase.cpp: ditto
- rendering/RenderRubyBase.h: ditto
- rendering/RenderRubyRun.cpp: ditto
- rendering/RenderRubyRun.h: ditto
- rendering/RenderRubyText.cpp: ditto
- rendering/RenderRubyText.h: ditto
2010-02-08 Maciej Stachowiak <mjs@apple.com>
Reviewed by Cameron Zwarich.
Restore ENABLE_RUBY flag so vendors can ship with Ruby disabled if they choose.
https://bugs.webkit.org/show_bug.cgi?id=34698
- configure.ac:
2010-02-08 Maciej Stachowiak <mjs@apple.com>
Reviewed by Cameron Zwarich.
Restore ENABLE_RUBY flag so vendors can ship with Ruby disabled if they choose.
https://bugs.webkit.org/show_bug.cgi?id=34698
- Scripts/build-webkit:
- 1:26 AM Changeset in webkit [54648] by
-
- 5 edits in trunk/LayoutTests
Rubber-stamped by Kenneth Rohde Christiansen.
[Qt] Update expected results for the following tests after r54646 because of ImageData support.
- platform/qt/fast/dom/Window/window-properties-expected.txt:
- platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:
- platform/qt/fast/dom/prototype-inheritance-expected.txt:
- platform/qt/fast/js/global-constructors-expected.txt:
- 12:34 AM Changeset in webkit [54647] by
-
- 11 edits6 adds in trunk
2010-02-11 Kent Tamura <tkent@chromium.org>
Reviewed by Darin Adler.
Step attribute support for date&time types.
https://bugs.webkit.org/show_bug.cgi?id=30847
Add tests for ValidityState.stepMismatch, stepUp() and stepDown()
for date, datetime, datetime-local, month, time, week types.
Update valueAsDate and valueAsNumber tests for a string representation
change.
- fast/forms/ValidityState-stepMismatch-expected.txt: Added.
- fast/forms/ValidityState-stepMismatch.html: Added.
- fast/forms/input-stepup-stepdown-expected.txt: Added.
- fast/forms/input-stepup-stepdown.html: Added.
- fast/forms/input-valueasdate-datetime-expected.txt:
- fast/forms/input-valueasdate-time-expected.txt:
- fast/forms/input-valueasnumber-datetime-expected.txt:
- fast/forms/input-valueasnumber-datetimelocal-expected.txt:
- fast/forms/input-valueasnumber-time-expected.txt:
- fast/forms/script-tests/ValidityState-stepMismatch.js: Added.
- fast/forms/script-tests/input-stepup-stepdown.js: Added.
- fast/forms/script-tests/input-valueasdate-datetime.js:
- fast/forms/script-tests/input-valueasnumber-datetime.js:
2010-02-11 Kent Tamura <tkent@chromium.org>
Reviewed by Darin Adler.
Step attribute support for date&time types.
https://bugs.webkit.org/show_bug.cgi?id=30847
- Add implementation for ValidityState.stepMismatch, stepUp() and stepDown() for date, datetime, datetime-local, month, time, week types.
- Fix string representation of DateComponents.
Tests: fast/forms/ValidityState-stepMismatch.html
fast/forms/input-stepup-stepdown.html
- html/HTMLInputElement.cpp:
- Change monthDefaultMaximum so that DateComponents::m_year doesn't overflow.
(WebCore::HTMLInputElement::stepBase):
(WebCore::HTMLInputElement::stepMismatch):
(WebCore::HTMLInputElement::getStepParameters):
(WebCore::HTMLInputElement::getAllowedValueStep):
(WebCore::HTMLInputElement::applyStep):
Renamed from applyStepForNumberOrRange(), and add support for other types.
(WebCore::HTMLInputElement::stepUp): Rename applyStepForNumberOrRange().
(WebCore::HTMLInputElement::stepDown): Rename applyStepForNumberOrRange().
(WebCore::HTMLInputElement::setValueAsDate): Use setDateValue().
(WebCore::HTMLInputElement::setDateValue):
A helper function to make the best representation of DateComponents.
(WebCore::HTMLInputElement::setValueAsNumber): Use setDateValue().
- html/HTMLInputElement.h:
- 12:30 AM Changeset in webkit [54646] by
-
- 13 edits in trunk
2010-02-10 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
postMessage does not send ImageData
https://bugs.webkit.org/show_bug.cgi?id=34825
Add test for postMessage passing ImageData
Update a few other tests to cover the fact that ImageData's constructor
is now available on the window object.
- fast/dom/Window/window-postmessage-clone-expected.txt:
- fast/dom/Window/window-postmessage-clone.html:
- fast/dom/Window/window-properties-expected.txt:
- fast/dom/Window/window-property-descriptors-expected.txt:
- fast/dom/prototype-inheritance-2-expected.txt:
- fast/dom/prototype-inheritance-expected.txt:
- fast/js/global-constructors-expected.txt:
2010-02-10 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
postMessage does not send ImageData
https://bugs.webkit.org/show_bug.cgi?id=34825
Implement serialisation of ImageData, and for testing reasons
expose the ImageData constructor (which should already have
been exposed).
- bindings/js/SerializedScriptValue.cpp: (WebCore::SerializedImageData::create): (WebCore::SerializedImageData::width): (WebCore::SerializedImageData::height): (WebCore::SerializedImageData::data): (WebCore::SerializedImageData::SerializedImageData): (WebCore::SerializedScriptValueData::SerializedScriptValueData): (WebCore::SharedSerializedData::asImageData): (WebCore::SerializingTreeWalker::convertIfTerminal): (WebCore::DeserializingTreeWalker::convertIfTerminal): (WebCore::TeardownTreeWalker::convertIfTerminal):
- bindings/js/SerializedScriptValue.h: (WebCore::SerializedScriptValueData::): (WebCore::SerializedScriptValueData::asImageData):
- html/canvas/CanvasPixelArray.h: (WebCore::CanvasPixelArray::data):
- page/DOMWindow.idl:
Feb 10, 2010:
- 11:32 PM Changeset in webkit [54645] by
-
- 12 edits in trunk/WebCore
2010-02-10 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
Address last round of review comments on r53607
https://bugs.webkit.org/show_bug.cgi?id=33940
Mostly renaming and cleaning up.
- css/CSSImportRule.cpp: (WebCore::CSSImportRule::insertedIntoParent):
- css/CSSStyleSheet.h: (WebCore::CSSStyleSheet::create): (WebCore::CSSStyleSheet::createInline):
- css/StyleBase.cpp: (WebCore::StyleBase::baseURL):
- css/StyleSheet.cpp: (WebCore::StyleSheet::StyleSheet):
- css/StyleSheet.h: (WebCore::StyleSheet::href): (WebCore::StyleSheet::setFinalURL): (WebCore::StyleSheet::finalURL):
- dom/Document.cpp: (WebCore::Document::updateBaseURL):
- dom/ProcessingInstruction.cpp: (WebCore::ProcessingInstruction::checkStyleSheet):
- xml/XSLImportRule.cpp: (WebCore::XSLImportRule::loadSheet):
- xml/XSLStyleSheet.h: (WebCore::XSLStyleSheet::create): (WebCore::XSLStyleSheet::createInline):
- xml/XSLStyleSheetLibxslt.cpp: (WebCore::XSLStyleSheet::XSLStyleSheet): (WebCore::XSLStyleSheet::parseString): (WebCore::XSLStyleSheet::loadChildSheets):
- xml/XSLStyleSheetQt.cpp: (WebCore::XSLStyleSheet::XSLStyleSheet):
- 11:14 PM Changeset in webkit [54644] by
-
- 2 edits in trunk/WebCore
2010-02-10 Noam Rosenthal <noam.rosenthal@nokia.com>
Reviewed by Ariya Hidayat.
[Qt] GraphicsLayer: somtimes the item flickers at the end of an animation
This is because we try to delete the animation when finished: that is
unnecessary. WebCore manages the animation's lifecycle and makes sure
to call the right function when the animation can be deleted.
No new tests.
- platform/graphics/qt/GraphicsLayerQt.cpp: (WebCore::GraphicsLayerQt::addAnimation): No need to delete here (WebCore::GraphicsLayerQt::removeAnimationsForProperty): deleteLater
- 10:51 PM Changeset in webkit [54643] by
-
- 2 edits1 move in trunk/WebCore
[wx] Build fix for wxMac/Cocoa.
- 10:27 PM Changeset in webkit [54642] by
-
- 2 edits in trunk/WebCore
REGRESSION(24929): PDF page doesn't load in background tab
Reviewed by Dan Bernstein.
- plugins/PluginView.cpp:
(WebCore::PluginView::startOrAddToUnstartedList):
Only delay loading of the plug-in if we'll kick off our own load of the
plug-in data later, in start().
- 7:58 PM Changeset in webkit [54641] by
-
- 2 edits in trunk/WebCore
Crash in WebKit!WebCore::RenderTextControlSingleLine::createInnerTextStyle doing anything in Safari after sitting on a page with 3D site
<rdar://problem/7557201>
https://bugs.webkit.org/show_bug.cgi?id=34823
Reviewed by Simon Fraser.
No tests added because the code is exercised by the existing tests.
The root cause was the fact that we were not releasing a reference that was held by CA.
In debug builds we had an assert in the destructor of WKCACFLayer.
- platform/graphics/win/GraphicsLayerCACF.cpp:
(WebCore::GraphicsLayerCACF::~GraphicsLayerCACF):
- 7:47 PM Changeset in webkit [54640] by
-
- 5 edits in trunk/WebKit/chromium
2010-02-10 James Hawkins <jhawkins@chromium.org>
Reviewed by Eric Seidel.
[Chromium] Remove code from SuggestionsPopup that was removed in a
previous revision of AutocompletePopup and accidentally added back in
the refactoring.
- src/AutoFillPopupMenuClient.cpp:
- src/AutoFillPopupMenuClient.h: Added property svn:eol-style.
- src/SuggestionsPopupMenuClient.cpp: (WebKit::SuggestionsPopupMenuClient::popupDidHide): (WebKit::SuggestionsPopupMenuClient::setTextFromItem): (WebKit::SuggestionsPopupMenuClient::initialize):
- src/SuggestionsPopupMenuClient.h:
- 7:30 PM Changeset in webkit [54639] by
-
- 2 edits in trunk/WebCore
2010-02-10 Kwang Yul Seo <skyul@company100.net>
Reviewed by Eric Seidel.
[BREWMP] Typedef DragImageRef
https://bugs.webkit.org/show_bug.cgi?id=34791
Use IImage* as it is the BREW's image type.
- platform/DragImage.h:
- 7:04 PM Changeset in webkit [54638] by
-
- 6 edits4 adds in trunk
WebCore: Fix for https://bugs.webkit.org/show_bug.cgi?id=34185 REGRESSION:
Mask not invalidating
Reviewed by Simon Fraser and Darin Adler.
SVGMaskElement is the only class that keeps a HashMap of canvas
resources rather than just a pointer to a resource. This
patch makes SVGMaskElement invalidate all of its resources in the
HashMap instead of just one.
- svg/SVGMaskElement.cpp:
(WebCore::SVGMaskElement::svgAttributeChanged):
(WebCore::SVGMaskElement::childrenChanged):
(WebCore::SVGMaskElement::invalidateCanvasResources):
- svg/SVGMaskElement.h:
- svg/SVGStyledElement.cpp:
(WebCore::SVGStyledElement::invalidateResourcesInAncestorChain):
(WebCore::SVGStyledElement::invalidateCanvasResources):
- svg/SVGStyledElement.h:
LayoutTests: Test for https://bugs.webkit.org/show_bug.cgi?id=34185 REGRESSION:
Mask not invalidating
Reviewed by Simon Fraser and Darin Adler.
- platform/mac/svg/custom/mask-invalidation-expected.checksum: Added.
- platform/mac/svg/custom/mask-invalidation-expected.png: Added.
- platform/mac/svg/custom/mask-invalidation-expected.txt: Added.
- svg/custom/mask-invalidation.svg: Added.
- 6:46 PM Changeset in webkit [54637] by
-
- 5 edits in trunk/WebCore
2010-02-10 Stephan Aßmus <superstippi@gmx.de>
Reviewed by David Levin.
Fixes to rect conversion and image rendering on Haiku
https://bugs.webkit.org/show_bug.cgi?id=34684
Covered by existing tests.
The changes to the rect conversions are indeed correct. In Haiku (to stay
compatibly with BeOS), a BRect specifies the left/top and bottom/right pixel
*indices*, even though the values are floating point. So a rectangle covering
just one pixel would be specified as BRect(0, 0, 0, 0). In WebCore and other
frame works, such rectangles would be expressed as 0, 0, 1, 1. In WebCore, the
width and height of rectangles refer to the distance between pixels, while on
Haiku, a one pixel rect has indeed a width and height of 0, as confusing as
that may be.
The part of the patch that affects
WebCore/platform/graphics/haiku/ImageHaiku.cpp also implements the drawing
methods more correctly. Image observers are notified, and pattern drawing takes
the "phase" into account which makes scrolled backgrounds render correctly.
Transformations are still not supported, since the Haiku drawing backend itself
does not yet support them.
Use OwnPtr when creating the BBitmap to avoid future leaks with early returns.
Convert the bitmap data to non pre-multiplied until Haiku supports drawing
pre-multiplied bitmaps.
- platform/graphics/haiku/FloatRectHaiku.cpp: Fixed conversion
- platform/graphics/haiku/ImageHaiku.cpp: (WebCore::BitmapImage::draw): Fixed placement, notify observers (WebCore::Image::drawPattern): Implemented using "phase" to fix scrolling, notify observers
- platform/graphics/haiku/IntRectHaiku.cpp: Fixed conversion
- platform/image-decoders/haiku/ImageDecoderHaiku.cpp: Fixed conversion
- 6:05 PM Changeset in webkit [54636] by
-
- 3 edits in trunk/WebCore
2010-02-10 Simon Fraser <Simon Fraser>
Reviewed by David Levin.
Clean up unused member var and initialization in Document
https://bugs.webkit.org/show_bug.cgi?id=34820
Remove unused m_secureForms member variable in Document.
- dom/Document.cpp: (WebCore::Document::Document):
- dom/Document.h:
- 5:50 PM Changeset in webkit [54635] by
-
- 9 edits in trunk/WebKitTools
2010-02-10 Dirk Pranke <dpranke@chromium.org>
Reviewed by Eric Seidel.
Fix various minor bugs keeping run-chromium-webkit-tests from actually
working on the linux and win ports of Chromium.
- Scripts/webkitpy/layout_tests/layout_package/test_shell_thread.py:
- Scripts/webkitpy/layout_tests/port/init.py:
- Scripts/webkitpy/layout_tests/port/base.py:
- Scripts/webkitpy/layout_tests/port/chromium.py:
- Scripts/webkitpy/layout_tests/port/chromium_linux.py:
- Scripts/webkitpy/layout_tests/port/chromium_win.py:
- Scripts/webkitpy/layout_tests/port/http_server.py:
- Scripts/webkitpy/layout_tests/port/websocket_server.py:
- 5:24 PM Changeset in webkit [54634] by
-
- 4 edits1 add in trunk/WebKitTools
2010-02-10 Eric Seidel <eric@webkit.org>
Reviewed by David Levin.
run-chromium-webkit-tests --platform=mac-leopard crashes when using a custom build directory
https://bugs.webkit.org/show_bug.cgi?id=34817
This doesn't fix the root cause of us not
correctly failing when support binaries are missing.
This only causes the DumpRenderTree binary not to be
missing in the custom build directory case.
Later patches will make us correctly fail fast when
support binaries (like DumpRenderTree or ImageDiff) are missing.
- Scripts/webkit-build-directory: Added.
- Need a way to re-use the perl logic for finding build directories in non-perl scripts.
- Scripts/webkitpy/layout_tests/port/base.py: Add a FIXME.
- Scripts/webkitpy/layout_tests/port/mac.py:
- Call webkit-build-directory to find the build directory instead of assuming "WebKitBuild"
- Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py: Add FIXMEs.
- 5:22 PM Changeset in webkit [54633] by
-
- 16 edits in trunk
Reviewed by Kevin Ollivier.
[wx] Add Windows complex text support and Mac support for containsCharacters.
https://bugs.webkit.org/show_bug.cgi?id=34759
- 4:54 PM Changeset in webkit [54632] by
-
- 1 edit2 adds in trunk/WebCore
2010-02-10 Kwang Yul Seo <skyul@company100.net>
Reviewed by Eric Seidel.
[BREWMP] Add dummy Frame::dragImageForSelection
https://bugs.webkit.org/show_bug.cgi?id=34792
Add FrameBrew.cpp which contains a dummy implementation of
Frame::dragImageForSelection.
- page/brew/FrameBrew.cpp: Added. (WebCore::Frame::dragImageForSelection):
- 4:24 PM Changeset in webkit [54631] by
-
- 5 edits in trunk
[wx] Build fixes. Move drawPattern implementation to the Image class like other platforms have it, and add a stub for a new LayoutTestController method.
- 4:11 PM Changeset in webkit [54630] by
-
- 5 edits in trunk/WebCore
Added CA_PRINT_TREE functionality to WKCACFLayer implementation
https://bugs.webkit.org/show_bug.cgi?id=34779
I've tried to duplicate the look of the output on Mac, but
it's not quite the same. It shows all the useful information though.
It is enabled by setting the environment variable CA_PRINT_TREE=1
- 4:08 PM Changeset in webkit [54629] by
-
- 14 edits in trunk
2010-02-10 Nate Chapin <Nate Chapin>
Reviewed by Adam Barth.
Change V8DOMWrapper::lookupDOMWrapper() and configureTemplate()
to not use V8ClassIndex.
- bindings/scripts/CodeGeneratorV8.pm:
- bindings/v8/V8Binding.cpp:
- bindings/v8/V8Binding.h:
- bindings/v8/V8DOMWindowShell.cpp:
- bindings/v8/V8DOMWrapper.cpp:
- bindings/v8/V8DOMWrapper.h:
- bindings/v8/V8Proxy.cpp:
- bindings/v8/WorkerContextExecutionProxy.cpp:
- bindings/v8/custom/V8DOMWindowCustom.cpp:
- bindings/v8/custom/V8LocationCustom.cpp:
- bindings/v8/custom/V8MessageEventCustom.cpp:
- 4:05 PM Changeset in webkit [54628] by
-
- 7 edits1 delete in trunk
Unreviewed. Roll out r54626, because it broke GTK and Win build.
https://bugs.webkit.org/show_bug.cgi?id=32717
WebKitTools:
- DumpRenderTree/LayoutTestController.cpp:
(LayoutTestController::staticFunctions):
- DumpRenderTree/LayoutTestController.h:
- DumpRenderTree/mac/DumpRenderTree.mm:
(resetDefaultsToConsistentValues):
- DumpRenderTree/mac/LayoutTestControllerMac.mm:
LayoutTests:
- platform/mac/Skipped:
- platform/mac/fast/frames/flattening: Removed.
- platform/mac/fast/frames/flattening/frameset-flattening-advanced-expected.txt: Removed.
- platform/mac/fast/frames/flattening/frameset-flattening-grid-expected.txt: Removed.
- platform/mac/fast/frames/flattening/frameset-flattening-simple-expected.txt: Removed.
- platform/mac/fast/frames/flattening/frameset-flattening-subframe-resize-expected.txt: Removed.
- platform/mac/fast/frames/flattening/frameset-flattening-subframesets-expected.txt: Removed.
- 3:30 PM Changeset in webkit [54627] by
-
- 2 edits in trunk/WebCore
2010-02-10 Nate Chapin <Nate Chapin>
Reviewed by Dimitri Glazkov.
[V8] Handle the possibility that ScheduledAction::execute() may
retrieve a null V8Proxy* even if not in a WorkerContext (e.g., if
JS was disallowed).
- bindings/v8/ScheduledAction.cpp: (WebCore::ScheduledAction::execute):
- 3:23 PM Changeset in webkit [54626] by
-
- 7 edits6 adds in trunk
2010-02-10 Jesus Sanchez-Palencia <jesus.palencia@openbossa.org>
Reviewed by Kenneth Rohde Christiansen.
Support frameset flattening
https://bugs.webkit.org/show_bug.cgi?id=32717
Add expected results of the FrameSet Flattening tests.
- platform/mac/fast/frames/flattening/frameset-flattening-advanced-expected.txt: Added.
- platform/mac/fast/frames/flattening/frameset-flattening-grid-expected.txt: Added.
- platform/mac/fast/frames/flattening/frameset-flattening-simple-expected.txt: Added.
- platform/mac/fast/frames/flattening/frameset-flattening-subframe-resize-expected.txt: Added.
- platform/mac/fast/frames/flattening/frameset-flattening-subframesets-expected.txt: Added.
- platform/mac/Skipped:
2010-02-10 Jesus Sanchez-Palencia <jesus.palencia@openbossa.org>
Reviewed by Kenneth Rohde Christiansen.
Support frameset flattening
https://bugs.webkit.org/show_bug.cgi?id=32717
Add FrameSet Flattening support to Mac DRT.
- DumpRenderTree/LayoutTestController.cpp: (setFrameSetFlatteningEnabledCallback): (LayoutTestController::staticFunctions):
- DumpRenderTree/LayoutTestController.h:
- DumpRenderTree/mac/DumpRenderTree.mm: (resetDefaultsToConsistentValues):
- DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::setFrameSetFlatteningEnabled):
- 3:04 PM Changeset in webkit [54625] by
-
- 8 edits2 adds in trunk
2010-02-10 Kenneth Russell <kbr@google.com>
Reviewed by Oliver Hunt.
Remove automatic viewport resizing
https://bugs.webkit.org/show_bug.cgi?id=34766
Removed automatic viewport resizing per conclusions on the WebGL
mailing list. Added test verifying new behavior and updated a
couple of previous tests failing after this change.
- fast/canvas/webgl/gl-get-calls-expected.txt:
- fast/canvas/webgl/gl-get-calls.html:
- fast/canvas/webgl/texImage2DImageDataTest.html:
- fast/canvas/webgl/viewport-unchanged-upon-resize-expected.txt: Added.
- fast/canvas/webgl/viewport-unchanged-upon-resize.html: Added.
2010-02-10 Kenneth Russell <kbr@google.com>
Reviewed by Oliver Hunt.
Remove automatic viewport resizing
https://bugs.webkit.org/show_bug.cgi?id=34766
Removed automatic viewport resizing per conclusions on the WebGL
mailing list. Added test verifying new behavior and updated a
couple of previous tests failing after this change.
Test: fast/canvas/webgl/viewport-unchanged-upon-resize.html
- platform/graphics/mac/GraphicsContext3DMac.cpp: (WebCore::GraphicsContext3D::reshape):
2010-02-10 Kenneth Russell <kbr@google.com>
Reviewed by Oliver Hunt.
Remove automatic viewport resizing
https://bugs.webkit.org/show_bug.cgi?id=34766
Removed automatic viewport resizing per conclusions on the WebGL
mailing list. Added test verifying new behavior and updated a
couple of previous tests failing after this change.
- src/GraphicsContext3D.cpp: (WebCore::GraphicsContext3DInternal::reshape):
- 2:54 PM Changeset in webkit [54624] by
-
- 3 edits in branches/safari-4-branch/WebCore
MSAA: selected, selectable, extended selectable, and multiple
selectable states are not reported
https://bugs.webkit.org/show_bug.cgi?id=33574
<rdar://problem/7536826>
Follow-up fix to account for the fact that different function names
are used on the branch.
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::isMultiSelectable):
- accessibility/AccessibilityRenderObject.h:
- 2:37 PM Changeset in webkit [54623] by
-
- 2 edits in trunk/WebCore
2010-02-10 Ariya Hidayat <ariya.hidayat@gmail.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Implement image interpolation quality.
- platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContextPlatformPrivate::GraphicsContextPlatformPrivate): (WebCore::GraphicsContext::setImageInterpolationQuality): (WebCore::GraphicsContext::imageInterpolationQuality):
- 2:01 PM Changeset in webkit [54622] by
-
- 2 edits in trunk/WebCore
2010-02-10 Eric Seidel <eric@webkit.org>
No review, Mac build fix.
Crash in Flash at http://www.cctv.com/
https://bugs.webkit.org/show_bug.cgi?id=34673
- plugins/PluginViewNone.cpp: (WebCore::PluginView::getValueStatic):
- 1:52 PM Changeset in webkit [54621] by
-
- 3 edits in branches/safari-4-branch/WebCore
Merge r54615.
- 1:26 PM Changeset in webkit [54620] by
-
- 9 edits6 adds in trunk
WebCore
2010-02-10 Gustavo Noronha Silva <Gustavo Noronha Silva>
Reviewed by Xan Lopez.
[GTK] Hits assertion on history back, with page cache enabled, in specific conditions
https://bugs.webkit.org/show_bug.cgi?id=34773
When unsetting the adjustments from a ScrollView, also disconnect
them from the Scrollbars.
Test: fast/frames/frame-crash-with-page-cache.html
- platform/gtk/ScrollViewGtk.cpp: (WebCore::ScrollView::setGtkAdjustments):
- platform/gtk/ScrollbarGtk.cpp: (ScrollbarGtk::~ScrollbarGtk): (ScrollbarGtk::detachAdjustment):
- platform/gtk/ScrollbarGtk.h:
LayoutTests
2010-02-10 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Xan Lopez.
[GTK] Hits assertion on history back, with page cache enabled, in specific conditions
https://bugs.webkit.org/show_bug.cgi?id=34773
- fast/frames/frame-crash-with-page-cache.html: Added.
- fast/frames/resources/cached-page-1.html: Added.
- fast/frames/resources/cached-page-2.html: Added.
- fast/frames/resources/cached-page-3.html: Added.
- fast/frames/resources/cached-page-iframe.html: Added.
WebKit/gtk
2010-02-09 Gustavo Noronha Silva <Gustavo Noronha Silva>
Reviewed by Xan Lopez.
[GTK] Hits assertion on history back, with page cache enabled, in specific conditions
https://bugs.webkit.org/show_bug.cgi?id=34773
Make sure cached frames have their scrollbars disconnected from
the WebView's adjustments.
- WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::savePlatformDataToCachedFrame):
- 1:18 PM Changeset in webkit [54619] by
-
- 3 edits in trunk/JavaScriptCore
Addressing issues found by style bot.
- wtf/ValueCheck.h: Renamed header guard to match final file name.
- wtf/Vector.h: (WTF::::checkConsistency): Remove braces around a one-line clause.
- 1:14 PM Changeset in webkit [54618] by
-
- 14 edits6 adds in trunk
Reviewed by Geoffrey Garen.
https://bugs.webkit.org/show_bug.cgi?id=34490
WebCore::ImageEventSender::dispatchPendingEvents() crashes in certain conditions
Test: fast/images/destroyed-image-load-event.html
- ForwardingHeaders/wtf/ValueCheck.h: Added.
- loader/ImageLoader.cpp: (WTF::ValueCheck): Special case value check for ImageLoader - it's allocated inside elements, so check the owner instead. (WebCore::ImageEventSender::hasPendingEvents): Added a debugging aid for ImageLoader destructor. (WebCore::ImageLoader::~ImageLoader): Assert that we're not going to leave dangling pointers in ImageEventSender. (WebCore::ImageLoader::setImage): Cancel events that could be dispatched for the previous image. The only client using this method that I could find was DeleteButton, which doesn't care about load events for the new image, so I didn't add any code for firing those. (WebCore::ImageLoader::setLoadingImage): This method only existed to confuse readers - there wasn't any meaningful code shared (callers just undid most assignments made there). Merged the logic into callers. (WebCore::ImageLoader::updateFromElement): We're forgetting the old image, so forget its old events, too. (WebCore::ImageLoader::notifyFinished): This can be called from setImage(), in which case no one is going to dispatch the event "soon". So, don't queue it. (WebCore::ImageEventSender::dispatchPendingEvents): Call checkConsistency(). This didn't help catch this particuar bug, but seems like a useful check anyway.
- loader/ImageLoader.h: Removed setLoadingImage().
- 1:08 PM Changeset in webkit [54617] by
-
- 2 edits in trunk/WebCore
Mac build fix. Unreviewed.
- WebCore.xcodeproj/project.pbxproj:
Add PluginViewNone.cpp to the Mac project.
- 1:05 PM Changeset in webkit [54616] by
-
- 4 edits in trunk/WebCore
Optimize ImageBuffer::toDataURL's CG implementation
There was some unused code that could have been removed in r31830 when
this function was changed not to flip the CG image anymore.
Fixes <http://webkit.org/b/34808> ImageBuffer::toDataURL allocates
unnecessary memory under CoreGraphics
Reviewed by Sam Weinig.
- platform/graphics/cg/ImageBufferCG.cpp:
(WebCore::ImageBuffer::toDataURL): Don't allocate an unused CGImageRef
and buffer, and switch to the new overload of base64Encode that
doesn't require us to copy all the image data into a Vector first.
- platform/text/Base64.cpp:
(WebCore::base64Encode):
- platform/text/Base64.h:
Added an overload that takes a raw data pointer and length, just like
we have for base64Decode. The overload that takes a Vector as input
just calls through to the new overload.
- 1:02 PM Changeset in webkit [54615] by
-
- 3 edits in trunk/WebCore
Complete the fix for <rdar://problem/7577604> Drag and Drop: background elements are bleeding through
https://bugs.webkit.org/show_bug.cgi?id=34546
Reviewed by Dave Hyatt.
- manual-tests/drag-image-table-part-decorations.html:
- rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::paint): Don’t paint collapsed borders if this object shouldn’t
paint within the current painting root.
- 12:18 PM Changeset in webkit [54614] by
-
- 9 edits2 adds in trunk
<rdar://problem/7436875> Crash in Flash when visiting
http://www.cctv.com/default.shtml (WER ID 819298200) [watson 2502260]
Reviewed by Darin Adler.
WebCore:
Test: platform/win/plugins/plugin-delayed-destroy.html
- bridge/NP_jsobject.cpp:
(_NPN_Evaluate):
If Flash calls this to evaluate a script that destroys the PluginView,
we crash when returning to Flash code. Before evaluating the script,
call PluginView::keepAlive() to hold a ref to this instance (and release
it asynchronously).
- plugins/PluginView.cpp:
(WebCore::instanceMap):
Return a map from the NPP to the PluginView.
(WebCore::PluginView::~PluginView):
Assert that the keep alive timer is not running; remove ourselves from
the instance map.
(WebCore::PluginView::performRequest):
The parent Frame is now a RefPtr; use .get().
(WebCore::PluginView::status):
Ditto.
(WebCore::PluginView::didReceiveResponse):
Ditto.
(WebCore::PluginView::PluginView):
Add the view to the instance map.
(WebCore::PluginView::lifeSupportTimerFired):
Deref the PluginView.
(WebCore::PluginView::keepAlive):
Ref the PluginView, then start a time to release the reference
asynchronously.
(WebCore::PluginView::keepAlive):
Find the PluginView in the map, and call its keepAlive() function.
- plugins/PluginView.h:
Made m_parentFrame a RefPtr, so that it will remain valid when the
keep alive timer fires.
(WebCore::PluginView::parentFrame):
Use .get().
- plugins/gtk/PluginViewGtk.cpp:
(WebCore::PluginView::updatePluginWidget):
Use .get().
(WebCore::PluginView::handleKeyboardEvent):
Use .get().
(WebCore::PluginView::handleMouseEvent):
Use .get().
- plugins/PluginViewNone.cpp:
(WebCore::PluginView::keepAlive):
Stubbed.
WebKitTools:
- DumpRenderTree/win/TestNetscapePlugin/main.cpp:
(executeScript):
Moved to an earlier point in the file.
(NPP_New):
If the plug-in has an onDestroy attribute, store its value.
(NPP_Destroy):
If the plug-in has code to run on destruction, run it and free it.
LayoutTests:
- platform/win/plugins/plugin-delayed-destroy-expected.txt: Added.
- platform/win/plugins/plugin-delayed-destroy.html: Added.
- 11:44 AM Changeset in webkit [54613] by
-
- 7 edits in trunk
2010-02-10 Jesus Sanchez-Palencia <jesus.palencia@openbossa.org>
Reviewed by Kenneth Rohde Christiansen.
Support frameset flattening
https://bugs.webkit.org/show_bug.cgi?id=32717
Add support for enabling/disabling FrameSet Flattening on the Mac port.
- WebCore.base.exp:
2010-02-10 Jesus Sanchez-Palencia <jesus.palencia@openbossa.org>
Reviewed by Kenneth Rohde Christiansen.
Support frameset flattening
https://bugs.webkit.org/show_bug.cgi?id=32717
Add support for enabling/disabling FrameSet Flattening on the Mac port.
- WebView/WebPreferenceKeysPrivate.h:
- WebView/WebPreferences.mm: (+[WebPreferences initialize]): (-[WebPreferences isFrameSetFlatteningEnabled]): (-[WebPreferences setFrameSetFlatteningEnabled:]):
- WebView/WebPreferencesPrivate.h:
- WebView/WebView.mm: (-[WebView _preferencesChangedNotification:]):
- 11:26 AM Changeset in webkit [54612] by
-
- 7 edits in trunk
2010-02-10 Diego Gonzalez <diego.gonzalez@openbossa.org>
Reviewed by Kenneth Rohde Christiansen.
Implement pageNumberForElementById() method in Qt DRT LayoutTestController,
to make Qt DRT able to get page number.
LayoutTests:
printing/page-break-always.html
printing/pageNumerForElementById.html
printing/css2.1/page-break-before-000.html
printing/css2.1/page-break-after-000.html
printing/css2.1/page-break-after-004.html
printing/css2.1/page-break-before-001.html
printing/css2.1/page-break-after-001.html
printing/css2.1/page-break-after-002.html
printing/css2.1/page-break-before-002.html
printing/css2.1/page-break-inside-000.html
[Qt] Make possible Qt DRT get a page number for element by ID
https://bugs.webkit.org/show_bug.cgi?id=34777
- platform/qt/Skipped:
2010-02-10 Diego Gonzalez <diego.gonzalez@openbossa.org>
Reviewed by Kenneth Rohde Christiansen.
Implement pageNumberForElementById() method in Qt DRT LayoutTestController,
to make Qt DRT able to get page number.
LayoutTests:
printing/page-break-always.html
printing/pageNumerForElementById.html
printing/css2.1/page-break-before-000.html
printing/css2.1/page-break-after-000.html
printing/css2.1/page-break-after-004.html
printing/css2.1/page-break-before-001.html
printing/css2.1/page-break-after-001.html
printing/css2.1/page-break-after-002.html
printing/css2.1/page-break-before-002.html
printing/css2.1/page-break-inside-000.html
[Qt] Make possible Qt DRT get a page number for element by ID
https://bugs.webkit.org/show_bug.cgi?id=34777
- Api/qwebframe.cpp: (qt_drt_pageNumberForElementById):
2010-02-10 Diego Gonzalez <diego.gonzalez@openbossa.org>
Reviewed by Kenneth Rohde Christiansen.
Implement pageNumberForElementById() method in Qt DRT LayoutTestController,
to make Qt DRT able to get page number.
LayoutTests:
printing/page-break-always.html
printing/pageNumerForElementById.html
printing/css2.1/page-break-before-000.html
printing/css2.1/page-break-after-000.html
printing/css2.1/page-break-after-004.html
printing/css2.1/page-break-before-001.html
printing/css2.1/page-break-after-001.html
printing/css2.1/page-break-after-002.html
printing/css2.1/page-break-before-002.html
printing/css2.1/page-break-inside-000.html
[Qt] Make possible Qt DRT get a page number for element by ID
https://bugs.webkit.org/show_bug.cgi?id=34777
- DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::pageNumberForElementById):
- DumpRenderTree/qt/LayoutTestControllerQt.h:
- 10:50 AM QtWebKitBackportingFixes edited by
- (diff)
- 10:48 AM Changeset in webkit [54611] by
-
- 1 edit in trunk/WebKit/win/Interfaces/WebKit.idl
Touch WebKit.idl to force a rebuild
- 10:47 AM Changeset in webkit [54610] by
-
- 1 edit in trunk/WebKit/win/Interfaces/IWebPreferences.idl
Committed the wrong file, had some local changes trying to fix the build
- 10:46 AM Changeset in webkit [54609] by
-
- 1 edit in trunk/WebKit/win/Interfaces/IWebPreferences.idl
Touch WebKit.idl to force a rebuild of Interfaces
- 10:37 AM Changeset in webkit [54608] by
-
- 2 edits in trunk
Add some details to the change log I just committed. (Sorry for not being more clear.)
- 10:29 AM Changeset in webkit [54607] by
-
- 7 edits2 deletes in trunk
Revert 54599
WebCore:
- inspector/front-end/DOMAgent.js:
(WebInspector.DOMNode.prototype._insertChild):
- inspector/front-end/ElementsPanel.js:
(WebInspector.ElementsPanel.prototype.updateModifiedNodes):
- inspector/front-end/ElementsTreeOutline.js:
(WebInspector.ElementsTreeOutline.prototype.revealAndSelectNode):
(WebInspector.ElementsTreeElement):
(WebInspector.ElementsTreeElement.prototype._updateChildren.updateChildrenOfNode):
(WebInspector.ElementsTreeElement.prototype._updateChildren):
():
- inspector/front-end/inspector.css:
LayoutTests:
- inspector/elements-panel-limited-children-expected.txt: Removed.
- inspector/elements-panel-limited-children.html: Removed.
- platform/qt/Skipped:
- 10:11 AM Changeset in webkit [54606] by
-
- 6 edits in trunk/WebKit/win
2010-02-10 Jesus Sanchez-Palencia <jesus.palencia@openbossa.org>
Reviewed by Kenneth Rohde Christiansen.
Support frameset flattening
https://bugs.webkit.org/show_bug.cgi?id=32717
Add support for enabling/disabling FrameSet Flattening on the Windows port.
- Interfaces/IWebPreferencesPrivate.idl:
- WebPreferenceKeysPrivate.h:
- WebPreferences.cpp: (WebPreferences::initializeDefaultSettings): (WebPreferences::isFrameSetFlatteningEnabled): (WebPreferences::setFrameSetFlatteningEnabled):
- WebPreferences.h:
- WebView.cpp: (WebView::notifyPreferencesChanged):
- 9:55 AM Changeset in webkit [54605] by
-
- 4 edits in trunk/JavaScriptCore
2010-02-10 Jedrzej Nowacki <jedrzej.nowacki@nokia.com>
Reviewed by Simon Hausmann.
Fix QScriptValue::toBool.
Fix ECMA compliance in the QScriptValue for values like 0, NaN and
empty strings.
[Qt] QScriptValue::toBool problem
https://bugs.webkit.org/show_bug.cgi?id=34793
- qt/api/qscriptvalue_p.h: (QScriptValuePrivate::toBool):
- qt/tests/qscriptvalue/tst_qscriptvalue.h:
- qt/tests/qscriptvalue/tst_qscriptvalue_generated.cpp: (tst_QScriptValue::toBool_initData): (tst_QScriptValue::toBool_makeData): (tst_QScriptValue::toBool_test): (tst_QScriptValue::toBoolean_initData): (tst_QScriptValue::toBoolean_makeData): (tst_QScriptValue::toBoolean_test):
- 8:51 AM Changeset in webkit [54604] by
-
- 2 edits in trunk/WebKit/win
Remove unnecessary #include of shfolder.h
shfolder.h has been deprecated in newer versions of the Windows SDK.
Fixes <http://webkit.org/b/34803> WebPreferences.cpp fails to compile
under VS2010 RC due to #include of shfolder.h.
Reviewed by Darin Adler.
- WebPreferences.cpp: Removed #include.
- 8:50 AM Changeset in webkit [54603] by
-
- 2 edits in trunk/WebCore
Fix bad paths in WebCore.vcproj
These were harmless in VS2005, but cause project conversion errors in
VS2010 RC.
Fixes <http://webkit.org/b/34801>.
Reviewed by Dan Bernstein.
- WebCore.vcproj/WebCore.vcproj: Removed leading "." from paths to
JSHTMLFrameSetElement.{cpp,h}.
- 8:36 AM Changeset in webkit [54602] by
-
- 2 edits in trunk/WebCore
Not reviewed (build fix).
- platform/graphics/win/FontCacheWin.cpp:
(WebCore::FontCache::getLastResortFallbackFont): Return a
SimpleFontData here.
- 8:28 AM Changeset in webkit [54601] by
-
- 14 edits in trunk/WebCore
Bug 23287 - Avoid using FontPlatformData outside the FontCache
Patch by Julien Chaffraix <jchaffraix@pleyo.com> on 2010-02-10
Reviewed by Eric Seidel.
No functional change, only refactored the code using FontPlatformData to use SimpleFontData.
This change leaves the class FontCached as it needs some thoughts and more refactoring.
- css/CSSFontFaceSource.cpp:
(WebCore::CSSFontFaceSource::getFontData): Call getCachedFontData with the 2 parameters directly.
- css/CSSFontSelector.cpp:
(WebCore::fontDataForGenericFamily): Ditto.
- platform/graphics/FontCache.cpp:
(WebCore::FontCache::getCachedFontData): This method is meant to replace getCachedFontPlatformData
that was moved in the private section of the class. It calls getCachedFontPlatformData and cache
the returned FontPlatformData if it is not null.
(WebCore::FontCache::getFontData): Updated to use the new getCachedFontData.
- platform/graphics/FontCache.h: Updated several methods to return a SimpleFontData in lieu of a
FontPlatformData. Moved some method in the private sections.
- platform/graphics/chromium/FontCacheChromiumWin.cpp:
(WebCore::FontCache::getSimilarFontPlatformData):
(WebCore::FontCache::getLastResortFallbackFont):
- platform/graphics/chromium/FontCacheLinux.cpp:
(WebCore::FontCache::getSimilarFontPlatformData):
(WebCore::FontCache::getLastResortFallbackFont):
- platform/graphics/gtk/FontCacheGtk.cpp:
(WebCore::FontCache::getSimilarFontPlatformData):
(WebCore::FontCache::getLastResortFallbackFont):
- platform/graphics/haiku/FontCacheHaiku.cpp:
(WebCore::FontCache::getSimilarFontPlatformData):
(WebCore::FontCache::getLastResortFallbackFont):
- platform/graphics/qt/FontCacheQt.cpp:
(WebCore::FontCache::getLastResortFallbackFont):
- platform/graphics/win/FontCacheWin.cpp:
(WebCore::FontCache::getSimilarFontPlatformData):
(WebCore::FontCache::getLastResortFallbackFont):
- platform/graphics/wince/FontCacheWince.cpp:
- platform/graphics/wx/FontCacheWx.cpp:
(WebCore::FontCache::getSimilarFontPlatformData):
(WebCore::FontCache::getLastResortFallbackFont):
Updated all the previous platform methods to return a SimpleFontData.
- platform/graphics/mac/FontCacheMac.mm:
(WebCore::FontCache::getSimilarFontPlatformData): Updated to return a SimpleFontData.
(WebCore::FontCache::getLastResortFallbackFont): Ditto. Also refactored the code
and moved a DEFINE_STATIC_LOCAL where it is needed.
- 8:06 AM Changeset in webkit [54600] by
-
- 1 edit2 adds in trunk/LayoutTests
2010-02-10 Nate Chapin <Nate Chapin>
Reviewed by Adam Barth.
Add test to ensure that a call to history.forward() at the top of
a page doesn't prevent the page from loading when there is no
forward list.
- fast/history/forward-during-load-expected.txt: Added.
- fast/history/forward-during-load.html: Added.
- 7:45 AM Changeset in webkit [54599] by
-
- 7 edits2 adds in trunk
2010-02-10 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: Elements Panel: Limit the number of initially loaded element children
https://bugs.webkit.org/show_bug.cgi?id=34421
Test: inspector/elements-panel-limited-children.html
WebCore:
- English.lproj/localizedStrings.js:
- inspector/front-end/DOMAgent.js: (WebInspector.DOMNode.prototype._insertChild):
- inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel.prototype.updateModifiedNodes):
- inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeOutline.prototype.createTreeElementFor): (WebInspector.ElementsTreeOutline.prototype.revealAndSelectNode): (WebInspector.ElementsTreeElement): (WebInspector.ElementsTreeElement.prototype.get expandedChildrenLimit): (WebInspector.ElementsTreeElement.prototype.set expandedChildrenLimit): (WebInspector.ElementsTreeElement.prototype.get expandedChildCount): (WebInspector.ElementsTreeElement.prototype.showChild): (WebInspector.ElementsTreeElement.prototype.insertChildElement): (WebInspector.ElementsTreeElement.prototype.moveChild): (WebInspector.ElementsTreeElement.prototype._updateChildren.updateChildrenOfNode): (WebInspector.ElementsTreeElement.prototype._updateChildren): (WebInspector.ElementsTreeElement.prototype.adjustCollapsedRange): (WebInspector.ElementsTreeElement.prototype.handleLoadAllChildren): ():
- inspector/front-end/inspector.css:
LayoutTests:
- inspector/elements-panel-limited-children-expected.txt: Added.
- inspector/elements-panel-limited-children.html: Added.
- platform/qt/Skipped:
- 7:22 AM Changeset in webkit [54598] by
-
- 2 edits in trunk/WebKit/chromium
2010-02-10 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Chromium Win build fix. Add third_party/nss to the dependencies list on Windows.
- DEPS:
- 7:18 AM Changeset in webkit [54597] by
-
- 8 edits4 adds in trunk/WebCore
2010-02-10 Mikhail Naganov <mnaganov@chromium.org>
Reviewed by Pavel Feldman.
Remove several #if USE(JSC) branches. Introduce ScriptDebugServer class for
making JavaScriptDebugServer engine-agnostic.
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSBindingsAllInOne.cpp:
- bindings/js/ScriptDebugServer.cpp: Added. (WebCore::ScriptDebugServer::recompileAllJSFunctions): (WebCore::ScriptDebugServer::recompileAllJSFunctionsSoon):
- bindings/js/ScriptDebugServer.h: Added.
- bindings/v8/ScriptDebugServer.cpp: Added. (WebCore::ScriptDebugServer::recompileAllJSFunctions): (WebCore::ScriptDebugServer::recompileAllJSFunctionsSoon):
- bindings/v8/ScriptDebugServer.h: Added.
- inspector/InspectorController.cpp: (WebCore::InspectorController::startUserInitiatedProfiling): (WebCore::InspectorController::enableProfiler): (WebCore::InspectorController::disableProfiler):
- page/Console.cpp: (WebCore::Console::profile): (WebCore::Console::profileEnd):
- 3:59 AM Changeset in webkit [54596] by
-
- 5 edits in trunk
Use derefIfNotNull() to work around WINSCW compiler forward declaration bug
Patch by Yongjun Zhang <yongjun.zhang@nokia.com> on 2009-10-06
Reviewed by Simon Hausmann.
The compiler bug is reported at
https://xdabug001.ext.nokia.com/bugzilla/show_bug.cgi?id=9812.
The change should be reverted when the above bug is fixed in WINSCW compiler.
JObjectWrapper::ref() and deref() made public accessible to derefIfNull().
https://bugs.webkit.org/show_bug.cgi?id=28054
- bridge/jni/jsc/JavaInstanceJSC.h:
- bridge/jni/v8/JavaInstanceV8.h:
- 3:58 AM Changeset in webkit [54595] by
-
- 2 edits in trunk/JavaScriptCore
Get rid of WINSCW hack for UnSpecifiedBoolType
Patch by Yongjun Zhang <yongjun.zhang@nokia.com> on 2009-10-06
Reviewed by Simon Hausmann.
Add parenthesis around (RefPtr::*UnspecifiedBoolType) to make the WINSCW
compiler work with the default UnSpecifiedBoolType() operator.
https://bugs.webkit.org/show_bug.cgi?id=28054
- wtf/RefPtr.h:
- 3:19 AM QtWebKitBackportingFixes edited by
- (diff)
- 3:14 AM Changeset in webkit [54594] by
-
- 2 edits in trunk/WebKit/chromium
2010-02-10 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Rolling Chromium dependencies to match Chromium revision 38580.
- DEPS:
- 2:36 AM Changeset in webkit [54593] by
-
- 8 edits2 moves in trunk
2010-02-10 Yaar Schnitman <yaar@chromium.org>
Reviewed by Adam Barth.
Simplified RuntimeEnabledFeatures and corresponding v8 generated code
https://bugs.webkit.org/show_bug.cgi?id=34667
- WebCore.gypi:
- bindings/generic/RuntimeEnabledFeatures.cpp: Added. (WebCore::RuntimeEnabledFeatures::audioEnabled): (WebCore::RuntimeEnabledFeatures::htmlMediaElementEnabled): (WebCore::RuntimeEnabledFeatures::htmlAudioElementEnabled): (WebCore::RuntimeEnabledFeatures::htmlVideoElementEnabled): (WebCore::RuntimeEnabledFeatures::mediaErrorEnabled): (WebCore::RuntimeEnabledFeatures::sharedWorkerEnabled): (WebCore::RuntimeEnabledFeatures::webSocketEnabled): (WebCore::RuntimeEnabledFeatures::openDatabaseEnabled):
- bindings/generic/RuntimeEnabledFeatures.h: Added. (WebCore::RuntimeEnabledFeatures::setLocalStorageEnabled): (WebCore::RuntimeEnabledFeatures::localStorageEnabled): (WebCore::RuntimeEnabledFeatures::setSessionStorageEnabled): (WebCore::RuntimeEnabledFeatures::sessionStorageEnabled): (WebCore::RuntimeEnabledFeatures::setWebkitNotificationsEnabled): (WebCore::RuntimeEnabledFeatures::webkitNotificationsEnabled): (WebCore::RuntimeEnabledFeatures::setApplicationCacheEnabled): (WebCore::RuntimeEnabledFeatures::applicationCacheEnabled): (WebCore::RuntimeEnabledFeatures::setGeolocationEnabled): (WebCore::RuntimeEnabledFeatures::geolocationEnabled): (WebCore::RuntimeEnabledFeatures::setIndexedDBEnabled): (WebCore::RuntimeEnabledFeatures::indexedDBEnabled): (WebCore::RuntimeEnabledFeatures::RuntimeEnabledFeatures):
- bindings/scripts/CodeGenerator.pm:
- bindings/scripts/CodeGeneratorV8.pm:
- bindings/v8/RuntimeEnabledFeatures.cpp: Removed.
- bindings/v8/RuntimeEnabledFeatures.h: Removed.
- bindings/v8/custom/V8DOMWindowCustom.cpp:
- bindings/v8/custom/V8NavigatorCustom.cpp:
- bindings/v8/custom/V8WorkerContextCustom.cpp:
- 2:25 AM Changeset in webkit [54592] by
-
- 12 edits in trunk/WebKit/chromium
2010-02-10 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Use v8::Debug::ProcessDebugMessages instead of executing an empty function
- src/DebuggerAgent.h:
- src/DebuggerAgentImpl.cpp: (WebKit::DebuggerAgentImpl::processDebugCommands):
- src/DebuggerAgentImpl.h:
- src/ToolsAgent.h:
- src/WebDevToolsAgentImpl.cpp:
- src/WebDevToolsAgentImpl.h:
- src/js/DebuggerAgent.js: (devtools.DebuggerAgent.prototype.addBreakpoint):
- src/js/DevToolsHostStub.js: (.RemoteDebuggerAgentStub.prototype.processDebugCommands):
- src/js/InjectDispatch.js: (dispatch):
- src/js/ProfilerAgent.js: (devtools.ProfilerAgent.prototype.startProfiling): (devtools.ProfilerAgent.prototype.stopProfiling):
- src/js/Tests.js:
- 1:56 AM Changeset in webkit [54591] by
-
- 9 edits2 adds in trunk/WebCore
2010-02-09 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: Add two basic categories for the Audits panel
https://bugs.webkit.org/show_bug.cgi?id=32930
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- inspector/front-end/AuditCategories.js: Added. (WebInspector.AuditCategories.PagePerformance): (WebInspector.AuditCategories.PagePerformance.prototype.initialize): (WebInspector.AuditCategories.NetworkUtilization): (WebInspector.AuditCategories.NetworkUtilization.prototype.initialize):
- inspector/front-end/AuditLauncherView.js: (WebInspector.AuditLauncherView.prototype.updateResourceTrackingState): (WebInspector.AuditLauncherView.prototype._createLauncherUI): (WebInspector.AuditLauncherView.prototype.show):
- inspector/front-end/AuditRules.js: Added. (WebInspector.AuditRules.arrayAsUL): (WebInspector.AuditRules.getDomainToResourcesMap): (WebInspector.AuditRules.evaluateInTargetWindow): (WebInspector.AuditRules.GzipRule): (WebInspector.AuditRules.GzipRule.prototype.doRun): (WebInspector.AuditRules.GzipRule.prototype._isCompressed): (WebInspector.AuditRules.GzipRule.prototype._shouldCompress): (WebInspector.AuditRules.CombineExternalResourcesRule): (WebInspector.AuditRules.CombineExternalResourcesRule.prototype.doRun): (WebInspector.AuditRules.CombineJsResourcesRule): (WebInspector.AuditRules.CombineCssResourcesRule): (WebInspector.AuditRules.MinimizeDnsLookupsRule): (WebInspector.AuditRules.MinimizeDnsLookupsRule.prototype.doRun): (WebInspector.AuditRules.ParallelizeDownloadRule): (WebInspector.AuditRules.ParallelizeDownloadRule.prototype.doRun): (WebInspector.AuditRules.UnusedCssRule): (WebInspector.AuditRules.UnusedCssRule.prototype._getUnusedStylesheetRatioMessage): (WebInspector.AuditRules.UnusedCssRule.prototype._getUnusedTotalRatioMessage): (WebInspector.AuditRules.UnusedCssRule.prototype.doRun.evalCallback): (WebInspector.AuditRules.UnusedCssRule.prototype.doRun.routine): (WebInspector.AuditRules.UnusedCssRule.prototype.doRun): (WebInspector.AuditRules.CacheControlRule): (WebInspector.AuditRules.CacheControlRule.prototype.InfoCheck.1.FailCheck.0.WarningCheck.1.SevereCheck.2.doRun): (WebInspector.AuditRules.CacheControlRule.prototype.handleNonCacheableResources): (WebInspector.AuditRules.CacheControlRule.prototype._cacheableAndNonCacheableResources): (WebInspector.AuditRules.CacheControlRule.prototype.execCheck): (WebInspector.AuditRules.CacheControlRule.prototype.freshnessLifetimeGreaterThan): (WebInspector.AuditRules.CacheControlRule.prototype.responseHeader): (WebInspector.AuditRules.CacheControlRule.prototype.hasResponseHeader): (WebInspector.AuditRules.CacheControlRule.prototype.isCompressible): (WebInspector.AuditRules.CacheControlRule.prototype.isPubliclyCacheable): (WebInspector.AuditRules.CacheControlRule.prototype.responseHeaderMatch): (WebInspector.AuditRules.CacheControlRule.prototype.hasExplicitExpiration): (WebInspector.AuditRules.CacheControlRule.prototype._isExplicitlyNonCacheable): (WebInspector.AuditRules.CacheControlRule.prototype.isCacheableResource): (WebInspector.AuditRules.BrowserCacheControlRule): (WebInspector.AuditRules.BrowserCacheControlRule.prototype.handleNonCacheableResources): (WebInspector.AuditRules.BrowserCacheControlRule.prototype.runChecks): (WebInspector.AuditRules.BrowserCacheControlRule.prototype._missingExpirationCheck): (WebInspector.AuditRules.BrowserCacheControlRule.prototype._varyCheck): (WebInspector.AuditRules.BrowserCacheControlRule.prototype._oneMonthExpirationCheck): (WebInspector.AuditRules.BrowserCacheControlRule.prototype._oneYearExpirationCheck): (WebInspector.AuditRules.ProxyCacheControlRule): (WebInspector.AuditRules.ProxyCacheControlRule.prototype.runChecks): (WebInspector.AuditRules.ProxyCacheControlRule.prototype._questionMarkCheck): (WebInspector.AuditRules.ProxyCacheControlRule.prototype._publicCachingCheck): (WebInspector.AuditRules.ProxyCacheControlRule.prototype._setCookieCacheableCheck): (WebInspector.AuditRules.ImageDimensionsRule): (WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun): (WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun.routine.hasDimension): (WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun.routine.hasWidth): (WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun.routine.hasHeight): (WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun.routine): (WebInspector.AuditRules.CssInHeadRule): (WebInspector.AuditRules.CssInHeadRule.prototype.doRun): (WebInspector.AuditRules.CssInHeadRule.prototype.doRun.routine.allViews): (WebInspector.AuditRules.CssInHeadRule.prototype.doRun.routine): (WebInspector.AuditRules.StylesScriptsOrderRule): (WebInspector.AuditRules.StylesScriptsOrderRule.prototype.doRun): (WebInspector.AuditRules.StylesScriptsOrderRule.prototype.doRun.routine): (WebInspector.AuditRules.CookieRuleBase): (WebInspector.AuditRules.CookieRuleBase.prototype.doRun.resultCallback): (WebInspector.AuditRules.CookieRuleBase.prototype.doRun): (WebInspector.AuditRules.CookieRuleBase.prototype.mapResourceCookies): (WebInspector.AuditRules.CookieRuleBase.prototype._callbackForResourceCookiePairs): (WebInspector.AuditRules.CookieSizeRule): (WebInspector.AuditRules.CookieSizeRule.prototype._average): (WebInspector.AuditRules.CookieSizeRule.prototype._max): (WebInspector.AuditRules.CookieSizeRule.prototype.processCookies): (WebInspector.AuditRules.CookieSizeRule.prototype.processCookies.avgSizeSorter): (WebInspector.AuditRules.StaticCookielessRule): (WebInspector.AuditRules.StaticCookielessRule.prototype.processCookies): (WebInspector.AuditRules.StaticCookielessRule.prototype._collectorCallback):
- inspector/front-end/AuditsPanel.js: (WebInspector.AuditsPanel.prototype._constructCategories): (WebInspector.AuditsPanel.prototype._reloadResources): (WebInspector.AuditsPanel.prototype.show): (WebInspector.AuditsPanel.prototype._updateLauncherViewControls): (WebInspector.AuditCategory): (WebInspector.AuditCategory.prototype.get id): (WebInspector.AuditCategory.prototype.get ruleCount): (WebInspector.AuditCategory.prototype.runRules): (WebInspector.AuditCategory.prototype._ensureInitialized): (WebInspector.AuditCategoryResult):
- inspector/front-end/WebKit.qrc:
- inspector/front-end/audits.css:
- inspector/front-end/inspector.html:
- inspector/front-end/inspector.js: (WebInspector.loaded): (WebInspector.addPanelToolbarIcon): (WebInspector.documentKeyDown):
- 1:51 AM Changeset in webkit [54590] by
-
- 3 edits in trunk/WebKitTools
Make run-iexploder-tests work on Linux.
https://bugs.webkit.org/show_bug.cgi?id=34748
Reviewed by Adam Barth.
Extract the platform dependant Apache configuration checking code in httpd.pm to a separate function
called getHTTPDConfigPathForTestDirectory and use run-launcher instead of run-safari if run on Linux.
- Scripts/run-iexploder-tests:
- Scripts/webkitperl/httpd.pm:
- 1:33 AM QtWebKitBackportingFixes edited by
- (diff)
- 1:23 AM Changeset in webkit [54589] by
-
- 2 edits in trunk/WebKit/chromium
2010-02-10 Tony Chang <tony@chromium.org>
Unreviewed, build fix for Chromium Mac take 2.
- src/AutoFillPopupMenuClient.cpp: (WebKit::AutoFillPopupMenuClient::removeSuggestionAtIndex):
- 1:17 AM Changeset in webkit [54588] by
-
- 2 edits in trunk/WebKit/chromium
2010-02-10 Tony Chang <tony@chromium.org>
Unreviewed, build fix for Chromium Mac.
- src/AutoFillPopupMenuClient.cpp: (WebKit::AutoFillPopupMenuClient::removeSuggestionAtIndex):
- 12:36 AM Changeset in webkit [54587] by
-
- 11 edits in trunk
2010-02-10 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
Freeze sandbox attributes on creation
https://bugs.webkit.org/show_bug.cgi?id=34184
Test that allow-forms is frozen on document creation.
- fast/frames/resources/sandboxed-iframe-form-dynamic-allowed.html: Added.
- fast/frames/resources/sandboxed-iframe-form-dynamic-disallowed.html: Added.
- fast/frames/sandboxed-iframe-forms-dynamic-expected.txt: Added.
- fast/frames/sandboxed-iframe-forms-dynamic.html: Added.
2010-02-10 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
Freeze sandbox attributes on creation
https://bugs.webkit.org/show_bug.cgi?id=34184
This is how the spec works now.
Test: fast/frames/sandboxed-iframe-forms-dynamic.html
- bindings/ScriptControllerBase.cpp: (WebCore::ScriptController::canExecuteScripts):
- bindings/generic/BindingDOMWindow.h: (WebCore::::createWindow):
- bindings/js/JSDOMWindowCustom.cpp: (WebCore::createWindow):
- dom/Document.cpp:
- dom/Document.h:
- loader/FrameLoader.cpp: (WebCore::FrameLoader::submitForm): (WebCore::FrameLoader::requestObject): (WebCore::FrameLoader::shouldAllowNavigation): (WebCore::FrameLoader::updateSandboxFlags):
- page/SecurityOrigin.cpp:
- page/SecurityOrigin.h:
Feb 9, 2010:
- 11:44 PM WebKit Team edited by
- (diff)
- 8:48 PM Changeset in webkit [54586] by
-
- 7 edits1 copy3 adds in trunk/WebKit/chromium
2010-02-09 James Hawkins <jhawkins@chromium.org>
Reviewed by Darin Fisher.
[Chromium] Refactor AutocompletePopupMenuClient into a base class,
SuggestionsPopupMenuClient, and two derived classes,
AutocompletePopupMenuClient and AutoFillPopupMenuClient. Currently
the behavior of suggestions popups has not changed.
- WebKit.gyp:
- public/WebView.h:
- src/AutoFillPopupMenuClient.cpp: Added.
- src/AutoFillPopupMenuClient.h: Added.
- src/AutocompletePopupMenuClient.cpp: (WebKit::AutocompletePopupMenuClient::getSuggestionsCount): (WebKit::AutocompletePopupMenuClient::getSuggestion): (WebKit::AutocompletePopupMenuClient::removeSuggestionAtIndex): (WebKit::AutocompletePopupMenuClient::initialize): (WebKit::AutocompletePopupMenuClient::setSuggestions):
- src/AutocompletePopupMenuClient.h:
- src/SuggestionsPopupMenuClient.cpp: Added.
- src/SuggestionsPopupMenuClient.h: Added.
- src/WebViewImpl.cpp: (WebKit::WebViewImpl::WebViewImpl): (WebKit::WebViewImpl::keyEvent): (WebKit::WebViewImpl::autocompleteHandleKeyEvent): (WebKit::WebViewImpl::applyAutofillSuggestions): (WebKit::WebViewImpl::applyAutoFillSuggestions): (WebKit::WebViewImpl::applyAutocompleteSuggestions):
- src/WebViewImpl.h:
- 8:23 PM Changeset in webkit [54585] by
-
- 2 edits in trunk/WebCore
2010-02-09 Ariya Hidayat <ariya.hidayat@gmail.com>
Rubber-stamped by Kenneth Rohde Christiansen.
[Qt] Remove old, outdated unused code block.
- platform/graphics/qt/GraphicsContextQt.cpp:
- 8:13 PM BuildingQtOnLinux edited by
- (diff)
- 8:01 PM Changeset in webkit [54584] by
-
- 7 edits in trunk
2010-02-09 Chris Guillory <ctguil@google.com>
Reviewed by Darin Fisher.
[Chromium] Notify ChromeClientChromium of state change notifications.
- accessibility/chromium/AXObjectCacheChromium.cpp: (WebCore::toChromeClientChromium): (WebCore::AXObjectCache::postPlatformNotification):
- page/chromium/ChromeClientChromium.h:
2010-02-09 Chris Guillory <ctguil@google.com>
Reviewed by Darin Fisher.
[Chromium] Add function for accessibility object state change notifications.
- gyp_webkit:
- public/WebViewClient.h: (WebKit::WebViewClient::didChangeAccessibilityObjectState):
- src/ChromeClientImpl.cpp: (WebKit::ChromeClientImpl::didChangeAccessibilityObjectState):
- src/ChromeClientImpl.h:
- 7:45 PM Changeset in webkit [54583] by
-
- 2 edits1 add in trunk/WebCore
2010-02-09 Kwang Yul Seo <skyul@company100.net>
Reviewed by Adam Barth.
[BREWMP] Port PlatformMouseEvent
https://bugs.webkit.org/show_bug.cgi?id=34600
Retrieve the event type, position, key modifiers, time stamp
and click count from AEEEvent.
- platform/PlatformMouseEvent.h:
- platform/brew/PlatformMouseEventBrew.cpp: Added. (WebCore::PlatformMouseEvent::PlatformMouseEvent):
- 7:25 PM Changeset in webkit [54582] by
-
- 2 edits in trunk/WebCore
2010-02-09 Avi Drissman <avi@chromium.org>
Reviewed by Timothy Hatcher.
[Chromium] RenderTheme does not draw focus rings on SL for checkboxes, radio buttons
https://bugs.webkit.org/show_bug.cgi?id=34544
Covered by layout tests when run on SL.
- platform/chromium/ThemeChromiumMac.mm: (-[TCMVisibleView _focusRingVisibleRect]): (-[TCMVisibleView _focusRingClipAncestor]): (FocusIndicationFix::currentOSHasSetFocusRingStyleInBitmapBug): (FocusIndicationFix::swizzleFocusView): (FocusIndicationFix::ScopedFixer::ScopedFixer): (FocusIndicationFix::ScopedFixer::~ScopedFixer): (+[NSView TCMInterposing_focusView]): (WebCore::paintCheckbox): (WebCore::paintRadio): (WebCore::paintButton):
- 7:09 PM Changeset in webkit [54581] by
-
- 4 edits in trunk/WebCore
2010-02-09 Anton Muhin <antonm@chromium.org>
Reviewed by Nate Chapin.
[v8] Check if returned wrapper is empty before operating on it.
https://bugs.webkit.org/show_bug.cgi?id=34746
- bindings/v8/custom/V8DocumentCustom.cpp: (WebCore::toV8):
- bindings/v8/custom/V8HTMLDocumentCustom.cpp: (WebCore::toV8):
- bindings/v8/custom/V8SVGDocumentCustom.cpp: (WebCore::toV8):
- 6:53 PM Changeset in webkit [54580] by
-
- 4 edits in trunk/JavaScriptCore
2010-02-09 Jedrzej Nowacki <jedrzej.nowacki@nokia.com>
Reviewed by Simon Hausmann.
New functions nullValue() and undefinedValue().
[Qt] QScriptEngine should contain nullValue and undefinedValue methods
https://bugs.webkit.org/show_bug.cgi?id=34749
- qt/api/qscriptengine.cpp: (QScriptEngine::nullValue): (QScriptEngine::undefinedValue):
- qt/api/qscriptengine.h:
- qt/tests/qscriptengine/tst_qscriptengine.cpp: (tst_QScriptEngine::nullValue): (tst_QScriptEngine::undefinedValue):
- 6:36 PM Changeset in webkit [54579] by
-
- 4 edits in trunk/JavaScriptCore
2010-02-09 Jedrzej Nowacki <jedrzej.nowacki@nokia.com>
Reviewed by Simon Hausmann.
Fixes for QScriptValue::toNumber().
Fix ECMA compliance in QScriptValue for values unbound
to a QScriptEngine.
[Qt] QScriptValue::toNumber() is broken
https://bugs.webkit.org/show_bug.cgi?id=34592
- qt/api/qscriptvalue_p.h: (QScriptValuePrivate::toNumber):
- qt/tests/qscriptvalue/tst_qscriptvalue.h:
- qt/tests/qscriptvalue/tst_qscriptvalue_generated.cpp: (tst_QScriptValue::toNumber_initData): (tst_QScriptValue::toNumber_makeData): (tst_QScriptValue::toNumber_test):
- 6:29 PM Changeset in webkit [54578] by
-
- 2 edits in trunk/WebKit/qt
[Qt] Unit test for window.runModalDialog
https://bugs.webkit.org/show_bug.cgi?id=34755
Reviewed by Adam Barth.
- tests/qwebpage/tst_qwebpage.cpp:
- 6:19 PM Changeset in webkit [54577] by
-
- 4 edits in trunk/JavaScriptCore
2010-02-09 Jedrzej Nowacki <jedrzej.nowacki@nokia.com>
Reviewed by Simon Hausmann.
Fix QScriptValue::isNumber().
The isNumber() should return 'true' if the value is in the CNumber
state.
[Qt] QScriptValue::isNumber() returns an incorrect value
https://bugs.webkit.org/show_bug.cgi?id=34575
- qt/api/qscriptvalue_p.h: (QScriptValuePrivate::isNumber):
- qt/tests/qscriptvalue/tst_qscriptvalue.h:
- qt/tests/qscriptvalue/tst_qscriptvalue_generated.cpp: (tst_QScriptValue::isNumber_initData): (tst_QScriptValue::isNumber_makeData): (tst_QScriptValue::isNumber_test):
- 6:02 PM Changeset in webkit [54576] by
-
- 12 edits in trunk
2010-02-09 Mikhail Naganov <mnaganov@chromium.org>
Reviewed by Pavel Feldman.
Continuing debugger and profiler unforking: narrow scope of JSC-specific ifdefs.
Also, enable JAVASCRIPT_DEBUGGER explicitly in features, it appears to be required
for really enabling it in V8 bindings generation.
- inspector/InjectedScriptHost.idl:
- inspector/InspectorBackend.cpp: (WebCore::InspectorBackend::currentCallFrame): (WebCore::InspectorBackend::getProfile):
- inspector/InspectorBackend.h:
- inspector/InspectorBackend.idl:
- inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController): (WebCore::InspectorController::addProfile): (WebCore::InspectorController::getProfile): (WebCore::InspectorController::startUserInitiatedProfiling): (WebCore::InspectorController::stopUserInitiatedProfiling): (WebCore::InspectorController::enableProfiler): (WebCore::InspectorController::disableProfiler):
- inspector/InspectorController.h:
- inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::pausedScript): (WebCore::InspectorFrontend::resumedScript): (WebCore::InspectorFrontend::profilerWasEnabled): (WebCore::InspectorFrontend::profilerWasDisabled): (WebCore::InspectorFrontend::didGetProfile):
- inspector/InspectorFrontend.h:
- page/Console.idl:
2010-02-09 Mikhail Naganov <mnaganov@chromium.org>
Reviewed by Pavel Feldman.
Continuing debugger and profiler unforking: narrow scope of JSC-specific ifdefs.
Also, enable JAVASCRIPT_DEBUGGER explicitly in features, it appears to be required
for really enabling it in V8 bindings generation.
- features.gypi:
- 5:43 PM Changeset in webkit [54575] by
-
- 2 edits in trunk/WebKit/qt
2010-02-09 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Sync with API changes in Maemo 5 kinetic scrolling
This is a forward-port of http://qt.gitorious.org/+qt-developers/qt/x11-maemo/commit/08497561
- Api/qwebview.cpp: (qt_sendSpontaneousEvent): (QWebViewKineticScroller::QWebViewKineticScroller): (QWebViewKineticScroller::setWidget): (QWebViewKineticScroller::eventFilter): (QWebViewKineticScroller::cancelLeftMouseButtonPress): (QWebViewKineticScroller::currentFrame): (QWebViewKineticScroller::scrollingFrameAt): (QWebViewKineticScroller::maximumScrollPosition): (QWebViewKineticScroller::scrollPosition): (QWebViewKineticScroller::viewportSize): (QWebViewKineticScroller::setScrollPosition): (QWebViewKineticScroller::sendEvent): (QWebView::QWebView):
- 4:28 PM Changeset in webkit [54574] by
-
- 3 edits in trunk/JavaScriptCore
Small refactoring to the small strings cache to allow it to be cleared
dynamically.
Reviewed by Oliver Hunt.
- runtime/SmallStrings.cpp:
(JSC::SmallStrings::SmallStrings):
(JSC::SmallStrings::clear):
- runtime/SmallStrings.h: Moved initialization code into a shared function,
and changed the constructor to call it.
- 4:14 PM Changeset in webkit [54573] by
-
- 5 edits in trunk
[Qt] Unreviewed. Roll-out r54543, because layout tests crash in debug mode.
https://bugs.webkit.org/show_bug.cgi?id=34713
WebKitTools:
- DumpRenderTree/qt/DumpRenderTreeQt.cpp:
(WebCore::WebPage::WebPage):
- DumpRenderTree/qt/main.cpp:
(main):
LayoutTests:
- platform/qt/Skipped:
- 3:28 PM Changeset in webkit [54572] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed trivial fix.
platform/mac/svg/custom/use-on-symbol-inside-pattern-expected.txt updated
by r54560. Qt platform specific expected file should be updated too.
- platform/qt/svg/custom/use-on-symbol-inside-pattern-expected.txt: Updated.
- 3:26 PM Changeset in webkit [54571] by
-
- 12 edits in trunk
Rubber Stamped by Geoff Garen.
Rename StringBuilder::release && JSStringBuilder::releaseJSString
to 'build()'.
- runtime/ArrayPrototype.cpp:
(JSC::arrayProtoFuncToLocaleString):
(JSC::arrayProtoFuncJoin):
- runtime/Executable.cpp:
(JSC::FunctionExecutable::paramString):
- runtime/FunctionConstructor.cpp:
(JSC::constructFunction):
- runtime/JSGlobalObjectFunctions.cpp:
(JSC::encode):
(JSC::decode):
(JSC::globalFuncEscape):
(JSC::globalFuncUnescape):
- runtime/JSONObject.cpp:
(JSC::Stringifier::stringify):
- runtime/JSStringBuilder.h:
(JSC::JSStringBuilder::build):
- runtime/LiteralParser.cpp:
(JSC::LiteralParser::Lexer::lexString):
- runtime/NumberPrototype.cpp:
(JSC::integerPartNoExp):
(JSC::numberProtoFuncToFixed):
- runtime/StringBuilder.h:
(JSC::StringBuilder::build):
WebCore:
- bindings/js/ScriptString.h:
(WebCore::ScriptString::operator+=):
- 3:01 PM Changeset in webkit [54570] by
-
- 5 edits in branches/safari-4-branch/WebKit/mac
Merge r54447.
- 2:58 PM Changeset in webkit [54569] by
-
- 2 edits in trunk/LayoutTests
[Qt] fast/events/multiline-link-arrow-navigation.html introduced in r54566, but our
LayoutTestController::overridePreference() does not support the 'WebKitEnableCaretBrowsing' preference now.
- platform/qt/Skipped: fast/events/multiline-link-arrow-navigation.html skipped.
- 2:48 PM Changeset in webkit [54568] by
-
- 3 edits5 copies in trunk/LayoutTests
Rubber-stamped by Kenneth Rohde Christiansen.
[Qt] window.showModalDialog implemented by r54550. Some tests pass now, so expected files updated.
(We need some new platform specific expected file, because this feature works only on Qt port now.)
https://bugs.webkit.org/show_bug.cgi?id=25585
- platform/qt/fast/dom/Window/window-function-frame-getter-precedence-expected.txt: Copied from LayoutTests/fast/dom/Window/window-function-frame-getter-precedence-expected.txt.
- platform/qt/fast/dom/Window/window-function-name-getter-precedence-expected.txt: Copied from LayoutTests/fast/dom/Window/window-function-name-getter-precedence-expected.txt.
- platform/qt/fast/dom/Window/window-lookup-precedence-expected.txt: Copied from LayoutTests/fast/dom/Window/window-lookup-precedence-expected.txt.
- platform/qt/fast/dom/Window/window-properties-expected.txt: Updated.
- platform/qt/fast/dom/prototype-inheritance-expected.txt: Updated.
- platform/qt/http/tests/security/cross-frame-access-call-expected.txt: Copied from LayoutTests/http/tests/security/cross-frame-access-call-expected.txt.
- cross-frame-access-call-expected.txt might be a false expected file, it needs more investigation.
- platform/qt/http/tests/security/cross-frame-access-get-expected.txt: Copied from LayoutTests/http/tests/security/cross-frame-access-get-expected.txt.
- 2:23 PM Changeset in webkit [54567] by
-
- 4 edits4 adds in trunk
<rdar://problem/7400160> Netscape plug-ins are not instantiated on property access if there are pending stylesheets
https://bugs.webkit.org/show_bug.cgi?id=34776
Reviewed by Anders Carlsson.
WebCore:
Tests: plugins/instance-available-before-stylesheets-loaded-object.html
plugins/instance-available-before-stylesheets-loaded.html
- html/HTMLEmbedElement.cpp:
(WebCore::HTMLEmbedElement::renderWidgetForJSBindings): Call
updateLayoutIgnorePendingStylesheets() before checking for a renderer.
- html/HTMLObjectElement.cpp:
(WebCore::HTMLObjectElement::renderWidgetForJSBindings): Ditto.
LayoutTests:
- plugins/instance-available-before-stylesheets-loaded-expected.txt: Added.
- plugins/instance-available-before-stylesheets-loaded-object-expected.txt: Added.
- plugins/instance-available-before-stylesheets-loaded-object.html: Added.
- plugins/instance-available-before-stylesheets-loaded.html: Added.
- 12:51 PM Changeset in webkit [54566] by
-
- 3 edits2 adds in trunk
Problems navigating by caret in links whose text wraps onto
subsequent lines.
https://bugs.webkit.org/show_bug.cgi?id=25676
Reviewed by Darin Adler.
WebCore:
We should not search ahead if we are not in the last element.
- dom/Position.cpp:
LayoutTests:
Added tests showing the problem.
- fast/events/multiline-link-arrow-navigation.html
- fast/events/multiline-link-arrow-navigation-expected.txt
- 12:50 PM Changeset in webkit [54565] by
-
- 4 edits1 add in trunk/WebKit/chromium
[chromium] Add the chromium interface to support Blob.slice.
https://bugs.webkit.org/show_bug.cgi?id=34652
Reviewed by Darin Fisher.
- WebKit.gyp:
- public/WebFileInfo.h: Added.
- public/WebHTTPBody.h:
- src/WebHTTPBody.cpp:
(WebKit::WebHTTPBody::elementAt):
(WebKit::WebHTTPBody::appendFile):
- 12:46 PM Changeset in webkit [54564] by
-
- 8 edits in trunk/WebCore
2010-02-09 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
More optimization for AffineTransform with SVG
https://bugs.webkit.org/show_bug.cgi?id=34774
Some optimizations to safe unnecessary summations and multiplications.
Optimize AffineTransform to handle an identity or translation matrix
more efficient.
Added translationRight to avoid multiplications of matrices as much as
possible.
No tests added, no change of functionality.
- platform/graphics/transforms/AffineTransform.cpp: (WebCore::AffineTransform::inverse): (WebCore::AffineTransform::translate): (WebCore::AffineTransform::translateRight):
- platform/graphics/transforms/AffineTransform.h:
- rendering/RenderForeignObject.cpp: (WebCore::RenderForeignObject::translationForAttributes): (WebCore::RenderForeignObject::localToParentTransform):
- rendering/RenderForeignObject.h:
- rendering/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::localToBorderBoxTransform): (WebCore::RenderSVGRoot::localToRepaintContainerTransform): (WebCore::RenderSVGRoot::localToParentTransform):
- rendering/RenderSVGViewportContainer.cpp: (WebCore::RenderSVGViewportContainer::localToParentTransform):
- rendering/SVGRootInlineBox.cpp: (WebCore::applyTextLengthCorrectionToTextChunk):
- 12:06 PM Changeset in webkit [54563] by
-
- 2 edits in trunk/JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=34772
Overzealous new assertion in URStringImpl::adopt()
Reviewed by Adam Barth.
- runtime/UStringImpl.h:
(JSC::UStringImpl::adopt):
Only assert that vector.data() is non-zero if vector.size() is non-zero.
- 12:05 PM Changeset in webkit [54562] by
-
- 2 edits in trunk/WebKit/mac
Reviewed by Anders Carlsson.
https://bugs.webkit.org/show_bug.cgi?id=34771
A stray mouse moved event is sent to plug-ins after mouse exit
- WebCoreSupport/WebFrameLoaderClient.mm: (NetscapePluginWidget::handleEvent): A mouseout DOM event is dispatched while handling NSMouseMoved - but we shouldn't be sending a mouse moved event to plug-ins at this point.
- 10:48 AM Changeset in webkit [54561] by
-
- 2 edits in trunk/WebKit/gtk
2010-02-09 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Xan Lopez.
[GTK] Set GtkAdjustments on our FrameView when loading a page in the PageCache
https://bugs.webkit.org/show_bug.cgi?id=34754
Test that lower, and upper bounds are kept when goibg back with
page cache enabled, and disabled. Page cache behaviour is still a
bit broken (see FIXME).
- tests/testwebview.c: (server_callback): (map_event_cb): (do_test_webkit_web_view_adjustments): (test_webkit_web_view_adjustments): (main):
- 10:33 AM Changeset in webkit [54560] by
-
- 23 edits12 adds in trunk
2010-02-09 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
SVG patterns with some scale patternTransform are not displayed correctly for small elements
https://bugs.webkit.org/show_bug.cgi?id=25484
SVG Pattern size was clipped to the size of the target, if the pattern is bigger than the target. This
causes problems, if the patternTransform scales the pattern. This patch deletes the clipping.
Tests: svg/custom/pattern-excessive-malloc.svg
svg/custom/pattern-size-bigger-than-target-size.svg
svg/custom/pattern-skew-transformed.svg
- svg/SVGPatternElement.cpp: (WebCore::SVGPatternElement::buildPattern):
2010-02-09 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
SVG patterns with some scale patternTransform are not displayed correctly for small elements
https://bugs.webkit.org/show_bug.cgi?id=25484
The old DRT results gave back a pattern size of 1x1. That was not very useful.
The new reuslts are much more useful.
- platform/mac/svg/W3C-SVG-1.1/coords-units-01-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/pservers-grad-03-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/pservers-pattern-01-b-expected.txt:
- platform/mac/svg/batik/paints/patternPreserveAspectRatioA-expected.txt:
- platform/mac/svg/batik/paints/patternRegions-expected.txt:
- platform/mac/svg/custom/deep-dynamic-updates-expected.txt:
- platform/mac/svg/custom/js-late-pattern-and-object-creation-expected.txt:
- platform/mac/svg/custom/js-late-pattern-creation-expected.txt:
- platform/mac/svg/custom/js-update-pattern-child-expected.txt:
- platform/mac/svg/custom/js-update-pattern-expected.txt:
- platform/mac/svg/custom/pattern-cycle-detection-expected.txt:
- platform/mac/svg/custom/pattern-deep-referencing-expected.txt:
- platform/mac/svg/custom/pattern-excessive-malloc-expected.checksum: Added.
- platform/mac/svg/custom/pattern-excessive-malloc-expected.png: Added.
- platform/mac/svg/custom/pattern-excessive-malloc-expected.txt: Added.
- platform/mac/svg/custom/pattern-in-defs-expected.txt:
- platform/mac/svg/custom/pattern-size-bigger-than-target-size-expected.checksum: Added.
- platform/mac/svg/custom/pattern-size-bigger-than-target-size-expected.png: Added.
- platform/mac/svg/custom/pattern-size-bigger-than-target-size-expected.txt: Added.
- platform/mac/svg/custom/pattern-skew-transformed-expected.checksum: Added.
- platform/mac/svg/custom/pattern-skew-transformed-expected.png: Added.
- platform/mac/svg/custom/pattern-skew-transformed-expected.txt: Added.
- platform/mac/svg/custom/pattern-with-transformation-expected.txt:
- platform/mac/svg/custom/pattern-y-offset-expected.txt:
- platform/mac/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.png:
- platform/mac/svg/custom/stroked-pattern-expected.txt:
- platform/mac/svg/custom/transformedMaskFails-expected.png:
- platform/mac/svg/custom/use-on-symbol-inside-pattern-expected.txt:
- svg/custom/pattern-excessive-malloc.svg: Added.
- svg/custom/pattern-size-bigger-than-target-size.svg: Added.
- svg/custom/pattern-skew-transformed.svg: Added.
- 10:22 AM Changeset in webkit [54559] by
-
- 2 edits in trunk/WebKit/gtk
2010-02-09 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
[GTK] Set GtkAdjustments on our FrameView when loading a page in the PageCache
https://bugs.webkit.org/show_bug.cgi?id=34754
Set the Gtk Adjustments of the FrameViews when they are restored
from the PageCache too. Right we only do it for the newly created
FrameViews in transitionToCommittedForNewPage, but we it also
needs to be done in the equilavent transition method for cached
pages.
- WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::postCommitFrameViewSetup): (WebKit::FrameLoaderClient::transitionToCommittedFromCachedFrame): (WebKit::FrameLoaderClient::transitionToCommittedForNewPage):
- 10:22 AM Changeset in webkit [54558] by
-
- 2 edits in trunk/LayoutTests
2010-02-09 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
Update Qt specific DRT result after AffineTransform patch.
- platform/qt/svg/custom/use-on-symbol-inside-pattern-expected.txt:
- 10:21 AM Changeset in webkit [54557] by
-
- 2 edits in trunk/WebCore
- rendering/RenderObject.cpp:
(WebCore::RenderObject::styleDidChange): Fixed typo in comment.
- 8:53 AM Changeset in webkit [54556] by
-
- 21 edits4 adds in trunk
2010-02-09 MORITA Hajime <morrita@gmail.com>
Reviewed by Nikolas Zimmermann.
SVG selection text foreground colour does not respect user settings
https://bugs.webkit.org/show_bug.cgi?id=15997
Add two subphases SVGTextPaintSubphaseGlyphFillSelection and
SVGTextPaintSubphaseGlyphStrokeSelection for painting selected
text on SVG. Selected texts are painted with style from
getCachedPseudoStyle() instead of style().
Tests: svg/text/selection-styles.xhtml
- rendering/SVGCharacterLayoutInfo.h: (WebCore::SVGTextChunkWalker::SVGTextChunkWalker): (WebCore::SVGTextChunkWalker::setupFillSelection): (WebCore::SVGTextChunkWalker::setupStrokeSelection):
- rendering/SVGRootInlineBox.cpp: (WebCore::SVGRootInlineBoxPaintWalker::mayHaveSelection): (WebCore::SVGRootInlineBoxPaintWalker::chunkSetupFillSelectionCallback): (WebCore::SVGRootInlineBoxPaintWalker::chunkSetupStrokeSelectionCallback): (WebCore::SVGRootInlineBoxPaintWalker::activePaintServer): (WebCore::SVGRootInlineBox::paint): (WebCore::SVGRootInlineBox::walkTextChunks):
- rendering/SVGInlineTextBox.h: (WebCore::): Add callback hooks and its implementation for handle new subphases.
- rendering/SVGInlineTextBox.cpp: (WebCore::SVGInlineTextBox::chunkSelectionStartEnd): (WebCore::SVGInlineTextBox::paintCharacters): Split box text into selected part and non-selected part, and use separate subphases to paint them.
- svg/SVGFont.cpp: (WebCore::SVGTextRunWalker::walk): Relax ASSERT() condition to accept a part of text.
- svg/graphics/SVGPaintServer.cpp: (WebCore::applyStrokeStyleToContext): (WebCore::SVGPaintServer::setup):
- svg/graphics/SVGPaintServer.h:
- svg/graphics/SVGPaintServerGradient.cpp: (WebCore::SVGPaintServerGradient::setup):
- svg/graphics/SVGPaintServerGradient.h:
- svg/graphics/SVGPaintServerPattern.cpp: (WebCore::SVGPaintServerPattern::setup):
- svg/graphics/SVGPaintServerPattern.h:
- svg/graphics/SVGPaintServerSolid.cpp: (WebCore::SVGPaintServerSolid::setup):
- svg/graphics/SVGPaintServerSolid.h: Change setup() signature to accept RenderStyle instead of always using RenderObject::style().
2010-02-09 MORITA Hajime <morrita@gmail.com>
Reviewed by Nikolas Zimmermann.
SVG selection text foreground colour does not respect user settings
https://bugs.webkit.org/show_bug.cgi?id=15997
Add two subphases SVGTextPaintSubphaseGlyphFillSelection and
SVGTextPaintSubphaseGlyphStrokeSelection for painting SVG text
selection. texts are painted with style from getCachedPseudoStyle() instead of style().
- platform/mac/svg/text/selection-styles-expected.checksum: Added.
- platform/mac/svg/text/selection-styles-expected.png: Added.
- platform/mac/svg/text/selection-styles-expected.txt: Added.
- platform/mac/svg/text/text-deco-01-b-expected.checksum: Updated pixel tests to account for marginal painting differences.
- platform/mac/svg/text/text-deco-01-b-expected.png: Ditto.
- platform/mac/svg/text/text-path-01-b-expected.checksum: Dito.
- platform/mac/svg/text/text-path-01-b-expected.png: Ditto.
- platform/mac/svg/text/text-text-03-b-expected.checksum: Ditto.
- platform/mac/svg/text/text-text-03-b-expected.png: Ditto.
- svg/text/selection-styles.xhtml: Added.
- 8:36 AM Changeset in webkit [54555] by
-
- 1 edit1 add in trunk/WebKit/chromium
2010-02-09 Yury Semikhatsky <yurys@chromium.org>
Unreviewed. Follow-up fix.
Add missing devTools.css file.
- src/js/devTools.css: Added.
- 8:34 AM Changeset in webkit [54554] by
-
- 2 edits in trunk/JavaScriptCore
2010-02-09 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed. Try to fix build problem on SnowLeopard slaves to bring them back.
- API/JSClassRef.cpp: (tryCreateStringFromUTF8): Mark method as 'static inline' to suppress "warning: no previous prototype for ..."
- 8:27 AM Changeset in webkit [54553] by
-
- 2 edits in trunk/WebKitTools
Unreviewed; added myself to committers
- Scripts/webkitpy/committers.py:
- 8:27 AM Changeset in webkit [54552] by
-
- 2 edits11 adds in trunk/WebKit/chromium
2010-02-09 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Upstream DevTools Images and .css files.
- WebKit.gypi:
- src/js/DevTools.css: Added.
- src/js/Images/segmentChromium.png: Added.
- src/js/Images/segmentHoverChromium.png: Added.
- src/js/Images/segmentHoverEndChromium.png: Added.
- src/js/Images/segmentSelectedChromium.png: Added.
- src/js/Images/segmentSelectedEndChromium.png: Added.
- src/js/Images/statusbarBackgroundChromium.png: Added.
- src/js/Images/statusbarBottomBackgroundChromium.png: Added.
- src/js/Images/statusbarButtonsChromium.png: Added.
- src/js/Images/statusbarMenuButtonChromium.png: Added.
- src/js/Images/statusbarMenuButtonSelectedChromium.png: Added.
- 8:08 AM Changeset in webkit [54551] by
-
- 18 edits46 adds in trunk
2010-02-09 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Dirk Schulze.
No scroll bars are displayed for standalone SVG image
https://bugs.webkit.org/show_bug.cgi?id=11225
Height and width defined for svg element are not honored
https://bugs.webkit.org/show_bug.cgi?id=24033
SVG file does not pan and has no scroll bars
https://bugs.webkit.org/show_bug.cgi?id=24448
Adapt to SVG 1.1 errata to change the overflow handling:
Replace "svg { overflow: hidden }" by "svg:not(:root) { overflow: hidden }" to allow standalone SVG documents to contain scrolllbars.
Agreed by SVG WG to make this the default behaviour, already implemented by Opera & FireFox (partial support).
Add new tests in svg/overflow covering all special SVG css overflow handling rules on inner/outer svg elements.
Tests: svg/overflow/overflow-on-inner-svg-element-defaults.svg
svg/overflow/overflow-on-inner-svg-element.svg
svg/overflow/overflow-on-outermost-svg-element-defaults.svg
svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-1.svg
svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-2.svg
svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-3.svg
svg/overflow/overflow-on-outermost-svg-element-in-xhtml-auto.xhtml
svg/overflow/overflow-on-outermost-svg-element-in-xhtml-defaults.xhtml
svg/overflow/overflow-on-outermost-svg-element-in-xhtml-hidden.xhtml
svg/overflow/overflow-on-outermost-svg-element-in-xhtml-scroll.xhtml
svg/overflow/overflow-on-outermost-svg-element-in-xhtml-visible.xhtml
- css/svg.css: Change default <svg> overflow rule to only apply to inner <svg> elements.
- page/FrameView.cpp: (WebCore::FrameView::layout): Only apply overflow rules for non-standalone SVG documents.
- rendering/RenderSVGRoot.cpp: Remove all calls to isOverflowHidden - it's always the case for the outermost SVG element, see spec + errata. (WebCore::RenderSVGRoot::paint): Always clip to initial viewport size. (WebCore::RenderSVGRoot::computeRectForRepaint): Ditto. (WebCore::RenderSVGRoot::nodeAtPoint): Simplify.
- rendering/RenderSVGViewportContainer.cpp: (WebCore::RenderSVGViewportContainer::applyViewportClip): Use isOverflowHidden() instead of a manual oveflow query and clip in float precision.
- rendering/SVGRenderSupport.cpp: (WebCore::SVGRenderBase::isOverflowHidden): Simplify implementation, assure the function is not called anymore for RenderSVGRoot objects.
- 7:55 AM Changeset in webkit [54550] by
-
- 6 edits in trunk
[Qt] Webkit in Qt does not have window.showModalDialog
https://bugs.webkit.org/show_bug.cgi?id=25585
Reviewed by Kenneth Rohde Christiansen.
WebKit/qt:
Create a new eventloop when runModal() is called.
Added comemnt in QWebPage::createWindow that the application is responsible
for setting the modality of the appropriate window.
- Api/qwebpage.cpp:
- WebCoreSupport/ChromeClientQt.cpp:
- WebCoreSupport/ChromeClientQt.h:
WebKitTools:
Set the modality flag when createWindow is called with window type WebWindowDialog.
- QtLauncher/main.cpp:
- 7:30 AM Changeset in webkit [54549] by
-
- 2 edits in trunk/WebKitTools
Unreviewed trivial warning fix.
- Scripts/build-webkit:
- 7:22 AM Changeset in webkit [54548] by
-
- 2 edits in trunk/WebKitTools
Add possibility of passing parameters to build-webkit by environment variable,
because the buildbot slaves can't control the arguments.
Patch by Gabor Rapcsanyi <rgabor@inf.u-szeged.hu> on 2010-02-09
Reviewed by Tor Arne Vestbø.
- Scripts/build-webkit:
- 7:15 AM Changeset in webkit [54547] by
-
- 1 edit11 adds in trunk/WebKit/chromium
2010-02-09 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Upstream JavaScript part of DevTools WebKit API implementation(now
with the added files).
- 7:13 AM QtWebKitBackportingFixes edited by
- (diff)
- 7:03 AM Changeset in webkit [54546] by
-
- 1 edit in trunk/WebKit/chromium/ChangeLog
2010-02-09 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Upstream JavaScript part of DevTools WebKit API implementation
- WebKit.gypi: Added.
- src/js/DebuggerAgent.js: Added. (devtools.DebuggerAgent): (devtools.DebuggerAgent.prototype.reset): (devtools.DebuggerAgent.prototype.initUI): (devtools.DebuggerAgent.prototype.resolveScriptSource.this.requestSeqToCallback_.cmd.getSequenceNumber): (devtools.DebuggerAgent.prototype.resolveScriptSource): (devtools.DebuggerAgent.prototype.pauseExecution): (devtools.DebuggerAgent.prototype.addBreakpoint): (devtools.DebuggerAgent.prototype.removeBreakpoint): (devtools.DebuggerAgent.prototype.updateBreakpoint): (devtools.DebuggerAgent.prototype.stepIntoStatement): (devtools.DebuggerAgent.prototype.stepOutOfFunction): (devtools.DebuggerAgent.prototype.stepOverStatement): (devtools.DebuggerAgent.prototype.resumeExecution): (devtools.DebuggerAgent.prototype.createExceptionMessage_): (devtools.DebuggerAgent.prototype.showPendingExceptionMessage_): (devtools.DebuggerAgent.prototype.clearExceptionMessage_): (devtools.DebuggerAgent.prototype.pauseOnExceptions): (devtools.DebuggerAgent.prototype.setPauseOnExceptions): (devtools.DebuggerAgent.prototype.requestEvaluate): (devtools.DebuggerAgent.prototype.resolveChildren): (devtools.DebuggerAgent.prototype.resolveScope.this.requestSeqToCallback_.cmd.getSequenceNumber): (devtools.DebuggerAgent.prototype.resolveScope): (devtools.DebuggerAgent.prototype.resolveFrameVariables_.scopeResponseHandler): (devtools.DebuggerAgent.prototype.resolveFrameVariables_): (devtools.DebuggerAgent.prototype.resolveCompletionsOnFrame): (devtools.DebuggerAgent.prototype.getScriptContextType): (devtools.DebuggerAgent.prototype.requestClearBreakpoint_): (devtools.DebuggerAgent.prototype.requestChangeBreakpoint_): (devtools.DebuggerAgent.prototype.requestBacktrace_): (devtools.DebuggerAgent.sendCommand_): (devtools.DebuggerAgent.prototype.stepCommand_): (devtools.DebuggerAgent.prototype.requestLookup_): (devtools.DebuggerAgent.prototype.setContextId_.this.requestSeqToCallback_.cmd.getSequenceNumber): (devtools.DebuggerAgent.prototype.setContextId_): (devtools.DebuggerAgent.prototype.handleDebuggerOutput_): (devtools.DebuggerAgent.prototype.handleBreakEvent_): (devtools.DebuggerAgent.prototype.handleExceptionEvent_): (devtools.DebuggerAgent.prototype.handleScriptsResponse_): (devtools.DebuggerAgent.prototype.isScriptFromInspectedContext_): (devtools.DebuggerAgent.prototype.handleSetBreakpointResponse_): (devtools.DebuggerAgent.prototype.handleAfterCompileEvent_): (devtools.DebuggerAgent.prototype.addScriptInfo_): (devtools.DebuggerAgent.prototype.handleClearBreakpointResponse_): (devtools.DebuggerAgent.prototype.handleBacktraceResponse_): (devtools.DebuggerAgent.prototype.doHandleBacktraceResponse_): (devtools.DebuggerAgent.prototype.evaluateInCallFrame): (devtools.DebuggerAgent.prototype.invokeCallbackForResponse_): (devtools.DebuggerAgent.prototype.formatCallFrame_): (devtools.DebuggerAgent.formatObjectProperties_): (devtools.DebuggerAgent.propertiesToProxies_): (devtools.DebuggerAgent.formatObjectProxy_): (devtools.DebuggerAgent.webkitToV8LineNumber_): (devtools.DebuggerAgent.v8ToWwebkitLineNumber_): (devtools.ScriptInfo): (devtools.ScriptInfo.prototype.getLineOffset): (devtools.ScriptInfo.prototype.getContextType): (devtools.ScriptInfo.prototype.getUrl): (devtools.ScriptInfo.prototype.isUnresolved): (devtools.ScriptInfo.prototype.getBreakpointInfo): (devtools.ScriptInfo.prototype.addBreakpointInfo): (devtools.ScriptInfo.prototype.removeBreakpointInfo): (devtools.BreakpointInfo): (devtools.BreakpointInfo.prototype.getLine): (devtools.BreakpointInfo.prototype.getV8Id): (devtools.BreakpointInfo.prototype.setV8Id): (devtools.BreakpointInfo.prototype.markAsRemoved): (devtools.BreakpointInfo.prototype.isRemoved): (devtools.CallFrame): (devtools.CallFrame.prototype.evaluate_): (devtools.DebugCommand): (devtools.DebugCommand.prototype.getSequenceNumber): (devtools.DebugCommand.prototype.toJSONProtocol): (devtools.DebuggerMessage): (devtools.DebuggerMessage.prototype.getType): (devtools.DebuggerMessage.prototype.getEvent): (devtools.DebuggerMessage.prototype.getCommand): (devtools.DebuggerMessage.prototype.getRequestSeq): (devtools.DebuggerMessage.prototype.isRunning): (devtools.DebuggerMessage.prototype.isSuccess): (devtools.DebuggerMessage.prototype.getMessage): (devtools.DebuggerMessage.prototype.getBody): (devtools.DebuggerMessage.prototype.lookup):
- src/js/DevTools.js: Added. (devtools.dispatch): (devtools.ToolsAgent): (devtools.ToolsAgent.prototype.reset): (devtools.ToolsAgent.prototype.evaluateJavaScript): (devtools.ToolsAgent.prototype.getDebuggerAgent): (devtools.ToolsAgent.prototype.getProfilerAgent): (devtools.ToolsAgent.prototype.frameNavigate_): (devtools.ToolsAgent.prototype.dispatchOnClient_): (devtools.ToolsAgent.prototype.evaluate): (WebInspector.setResourcesPanelEnabled): (debugPrint): (devtools): (WebInspector.loaded): (): (WebInspector.ScriptView.prototype.setupSourceFrameIfNeeded): (WebInspector.ScriptView.prototype.didResolveScriptSource_): (WebInspector.UnresolvedPropertyValue): (WebInspector.UIString): (WebInspector.resourceTrackingWasEnabled): (WebInspector.resourceTrackingWasDisabled): (WebInspector.TestController.prototype.runAfterPendingDispatches): (WebInspector.queuesAreEmpty): (WebInspector.pausedScript):
- src/js/DevToolsHostStub.js: Added. (.RemoteDebuggerAgentStub): (.RemoteDebuggerAgentStub.prototype.getContextId): (.RemoteProfilerAgentStub): (.RemoteProfilerAgentStub.prototype.getActiveProfilerModules): (.RemoteProfilerAgentStub.prototype.getLogLines): (.RemoteToolsAgentStub): (.RemoteToolsAgentStub.prototype.dispatchOnInjectedScript): (.RemoteToolsAgentStub.prototype.dispatchOnInspectorController): (.RemoteToolsAgentStub.prototype.executeVoidJavaScript): (.ProfilerStubHelper): (.ProfilerStubHelper.GetInstance): (.ProfilerStubHelper.prototype.StopProfiling): (.ProfilerStubHelper.prototype.StartProfiling): (.ProfilerStubHelper.prototype.getActiveProfilerModules): (.ProfilerStubHelper.prototype.getLogLines): (.RemoteDebuggerCommandExecutorStub): (.RemoteDebuggerCommandExecutorStub.prototype.DebuggerCommand): (.RemoteDebuggerCommandExecutorStub.prototype.DebuggerPauseScript): (.RemoteDebuggerCommandExecutorStub.prototype.sendResponse_): (.DevToolsHostStub): (.DevToolsHostStub.prototype.reset): (.DevToolsHostStub.prototype.setting): (.DevToolsHostStub.prototype.setSetting):
- src/js/HeapProfilerPanel.js: Added. (WebInspector.ProfilesPanel.prototype.addSnapshot): (WebInspector.HeapSnapshotView): (WebInspector.HeapSnapshotView.prototype.get statusBarItems): (WebInspector.HeapSnapshotView.prototype.get profile): (WebInspector.HeapSnapshotView.prototype.set profile): (WebInspector.HeapSnapshotView.prototype.show): (WebInspector.HeapSnapshotView.prototype.hide): (WebInspector.HeapSnapshotView.prototype.resize): (WebInspector.HeapSnapshotView.prototype.refresh): (WebInspector.HeapSnapshotView.prototype.refreshShowAsPercents): (WebInspector.HeapSnapshotView.prototype._deleteSearchMatchedFlags): (WebInspector.HeapSnapshotView.prototype.searchCanceled): (WebInspector.HeapSnapshotView.prototype.performSearch): (WebInspector.HeapSnapshotView.prototype.jumpToFirstSearchResult.WebInspector.CPUProfileView.prototype.jumpToFirstSearchResult.jumpToLastSearchResult.WebInspector.CPUProfileView.prototype.jumpToLastSearchResult.jumpToNextSearchResult.WebInspector.CPUProfileView.prototype.jumpToNextSearchResult.jumpToPreviousSearchResult.WebInspector.CPUProfileView.prototype.jumpToPreviousSearchResult.showingFirstSearchResult.WebInspector.CPUProfileView.prototype.showingFirstSearchResult.showingLastSearchResult.WebInspector.CPUProfileView.prototype.showingLastSearchResult._jumpToSearchResult.WebInspector.CPUProfileView.prototype._jumpToSearchResult.refreshVisibleData): (WebInspector.HeapSnapshotView.prototype._changeBase): (WebInspector.HeapSnapshotView.prototype._createSnapshotDataGridList): (WebInspector.HeapSnapshotView.prototype._mouseDownInDataGrid): (WebInspector.HeapSnapshotView.prototype.get _isShowingAsPercent): (WebInspector.HeapSnapshotView.prototype._percentClicked): (WebInspector.HeapSnapshotView.prototype._resetDataGridList): (WebInspector.HeapSnapshotView.prototype._sortData): (WebInspector.HeapSnapshotView.prototype._updateBaseOptions): (WebInspector.HeapSnapshotView.prototype._updatePercentButton): (WebInspector.HeapSnapshotView.prototype._updateSummaryGraph): (WebInspector.HeapSnapshotView.SearchHelper.operations.LESS): (WebInspector.HeapSnapshotView.SearchHelper.operations.LESS_OR_EQUAL): (WebInspector.HeapSnapshotView.SearchHelper.operations.EQUAL): (WebInspector.HeapSnapshotView.SearchHelper.operations.GREATER_OR_EQUAL): (WebInspector.HeapSnapshotView.SearchHelper.operations.GREATER): (WebInspector.HeapSnapshotView.SearchHelper.parseOperationAndNumber): (WebInspector.HeapSummaryCalculator): (WebInspector.HeapSummaryCalculator.prototype.computeSummaryValues): (WebInspector.HeapSummaryCalculator.prototype.formatValue): (WebInspector.HeapSummaryCalculator.prototype.get showAsPercent): (WebInspector.HeapSummaryCalculator.prototype.set showAsPercent): (WebInspector.HeapSummaryCountCalculator): (WebInspector.HeapSummaryCountCalculator.prototype._highFromLow): (WebInspector.HeapSummaryCountCalculator.prototype._valueToString): (WebInspector.HeapSummarySizeCalculator): (WebInspector.HeapSummarySizeCalculator.prototype._highFromLow): (WebInspector.HeapSnapshotSidebarTreeElement): (WebInspector.HeapSnapshotSidebarTreeElement.prototype.get mainTitle): (WebInspector.HeapSnapshotSidebarTreeElement.prototype.set mainTitle): (WebInspector.HeapSnapshotDataGridNodeWithRetainers): (WebInspector.HeapSnapshotDataGridNodeWithRetainers.prototype.get _hasRetainers): (WebInspector.HeapSnapshotDataGridNodeWithRetainers.prototype.get _parent): (WebInspector.HeapSnapshotDataGridNodeWithRetainers.prototype._populate.if): (WebInspector.HeapSnapshotDataGridNodeWithRetainers.prototype._populate): (WebInspector.HeapSnapshotDataGridNodeWithRetainers.prototype.produceDiff): (WebInspector.HeapSnapshotDataGridNodeWithRetainers.prototype.sort): (WebInspector.HeapSnapshotDataGridNodeWithRetainers.prototype.signForDelta): (WebInspector.HeapSnapshotDataGridNodeWithRetainers.prototype.showDeltaAsPercent): (WebInspector.HeapSnapshotDataGridNodeWithRetainers.prototype.getTotalCount): (WebInspector.HeapSnapshotDataGridNodeWithRetainers.prototype.getTotalSize): (WebInspector.HeapSnapshotDataGridNodeWithRetainers.prototype.get countPercent): (WebInspector.HeapSnapshotDataGridNodeWithRetainers.prototype.get sizePercent): (WebInspector.HeapSnapshotDataGridNodeWithRetainers.prototype.get countDeltaPercent): (WebInspector.HeapSnapshotDataGridNodeWithRetainers.prototype.get sizeDeltaPercent): (WebInspector.HeapSnapshotDataGridNodeWithRetainers.prototype.get data): (WebInspector.HeapSnapshotDataGridNodeWithRetainers.prototype.createCell): (WebInspector.HeapSnapshotDataGridNode): (WebInspector.HeapSnapshotDataGridList): (WebInspector.HeapSnapshotDataGridList.prototype.appendChild): (WebInspector.HeapSnapshotDataGridList.prototype.insertChild): (WebInspector.HeapSnapshotDataGridList.prototype.removeChildren): (WebInspector.HeapSnapshotDataGridList.prototype.populateChildren): (WebInspector.HeapSnapshotDataGridList.propertyComparator.comparator): (WebInspector.HeapSnapshotDataGridList.propertyComparator): (WebInspector.HeapSnapshotDataGridRetainerNode): (WebInspector.HeapSnapshotDataGridRetainerNode.prototype.get sizePercent): (WebInspector.HeapSnapshotDataGridRetainerNode.prototype.get sizeDeltaPercent): (WebInspector.HeapSnapshotDataGridRetainerNode.prototype._calculateRetainers): (WebInspector.HeapSnapshotProfileType): (WebInspector.HeapSnapshotProfileType.prototype.get buttonTooltip): (WebInspector.HeapSnapshotProfileType.prototype.get buttonStyle): (WebInspector.HeapSnapshotProfileType.prototype.buttonClicked): (WebInspector.HeapSnapshotProfileType.prototype.get welcomeMessage): (WebInspector.HeapSnapshotProfileType.prototype.createSidebarTreeElementForProfile): (WebInspector.HeapSnapshotProfileType.prototype.createView): ():
- src/js/InjectDispatch.js: Added. (InspectorControllerDispatcher.dispatch): (ApuAgentDispatcher.dispatchToApu): (dispatch): (devtools):
- src/js/InspectorControllerImpl.js: Added. (devtools.InspectorBackendImpl): (devtools.InspectorBackendImpl.prototype.toggleNodeSearch): (devtools.InspectorBackendImpl.prototype.debuggerEnabled): (devtools.InspectorBackendImpl.prototype.profilerEnabled): (devtools.InspectorBackendImpl.prototype.addBreakpoint): (devtools.InspectorBackendImpl.prototype.removeBreakpoint): (devtools.InspectorBackendImpl.prototype.updateBreakpoint): (devtools.InspectorBackendImpl.prototype.pauseInDebugger): (devtools.InspectorBackendImpl.prototype.resumeDebugger): (devtools.InspectorBackendImpl.prototype.stepIntoStatementInDebugger): (devtools.InspectorBackendImpl.prototype.stepOutOfFunctionInDebugger): (devtools.InspectorBackendImpl.prototype.stepOverStatementInDebugger): (devtools.InspectorBackendImpl.prototype.setPauseOnExceptionsState): (devtools.InspectorBackendImpl.prototype.pauseOnExceptionsState): (devtools.InspectorBackendImpl.prototype.pauseOnExceptions): (devtools.InspectorBackendImpl.prototype.setPauseOnExceptions): (devtools.InspectorBackendImpl.prototype.startProfiling): (devtools.InspectorBackendImpl.prototype.stopProfiling): (devtools.InspectorBackendImpl.prototype.getProfileHeaders): (devtools.InspectorBackendImpl.prototype.addFullProfile): (devtools.InspectorBackendImpl.prototype.getProfile): (devtools.InspectorBackendImpl.prototype.takeHeapSnapshot): (devtools.InspectorBackendImpl.prototype.dispatchOnInjectedScript): (devtools.InspectorBackendImpl.prototype.installInspectorControllerDelegate_): (devtools.InspectorBackendImpl.prototype.callInspectorController_):
- src/js/ProfilerAgent.js: Added. (devtools.ProfilerAgent): (devtools.ProfilerAgent.prototype.setupProfilerProcessorCallbacks): (devtools.ProfilerAgent.prototype.initializeProfiling): (devtools.ProfilerAgent.prototype.startProfiling): (devtools.ProfilerAgent.prototype.stopProfiling): (devtools.ProfilerAgent.prototype.didGetActiveProfilerModules_): (devtools.ProfilerAgent.prototype.didGetLogLines_):
- src/js/ProfilerProcessor.js: Added. (devtools.profiler.WebKitViewBuilder): (devtools.profiler.WebKitViewBuilder.prototype.createViewNode): (devtools.profiler.WebKitViewNode): (set get devtools.profiler.WebKitViewNode.prototype.initFuncInfo_): (devtools.profiler.JsProfile): (devtools.profiler.JsProfile.prototype.skipThisFunction): (devtools.profiler.Processor): (devtools.profiler.Processor.prototype.printError): (devtools.profiler.Processor.prototype.skipDispatch): (devtools.profiler.Processor.prototype.setCallbacks): (devtools.profiler.Processor.prototype.setNewProfileCallback): (devtools.profiler.Processor.prototype.processProfiler_.switch.break): (devtools.profiler.Processor.prototype.processProfiler_): (devtools.profiler.Processor.prototype.processCodeCreation_): (devtools.profiler.Processor.prototype.processCodeMove_): (devtools.profiler.Processor.prototype.processCodeDelete_): (devtools.profiler.Processor.prototype.processFunctionCreation_): (devtools.profiler.Processor.prototype.processFunctionMove_): (devtools.profiler.Processor.prototype.processFunctionDelete_): (devtools.profiler.Processor.prototype.processTick_): (devtools.profiler.Processor.prototype.processTickV2_): (devtools.profiler.Processor.prototype.processHeapSampleBegin_): (devtools.profiler.Processor.prototype.processHeapSampleStats_): (devtools.profiler.Processor.prototype.processHeapSampleItem_): (devtools.profiler.Processor.prototype.processHeapJsConsItem_): (devtools.profiler.Processor.prototype.processHeapJsRetItem_.mergeRetainers): (devtools.profiler.Processor.prototype.processHeapJsRetItem_): (devtools.profiler.Processor.prototype.processHeapSampleEnd_): (devtools.profiler.Processor.prototype.createProfileForView):
- src/js/Tests.js: Added. (.TestSuite): (.TestSuite.prototype.fail): (.TestSuite.prototype.assertEquals): (.TestSuite.prototype.assertTrue): (.TestSuite.prototype.assertContains): (.TestSuite.prototype.takeControl): (.TestSuite.prototype.releaseControl): (.TestSuite.prototype.reportOk_): (.TestSuite.prototype.reportFailure_): (.TestSuite.prototype.runTest): (.TestSuite.prototype.showPanel): (.TestSuite.prototype.addSniffer.receiver.methodName): (.TestSuite.prototype.addSniffer): (.TestSuite.prototype.testHostIsPresent): (.TestSuite.prototype.testElementsTreeRoot): (.TestSuite.prototype.testMainResource): (.TestSuite.prototype.testResourceContentLength.this.addSniffer.): (.TestSuite.prototype.testResourceHeaders): (.TestSuite.prototype.testCachedResourceMimeType.this.addSniffer.): (.TestSuite.prototype.testCachedResourceMimeType): (.TestSuite.prototype.testProfilerTab): (.TestSuite.prototype.testScriptsTabIsPopulatedOnInspectedPageRefresh.waitUntilScriptIsParsed): (.TestSuite.prototype.testScriptsTabIsPopulatedOnInspectedPageRefresh.checkScriptsPanel): (.TestSuite.prototype.testScriptsTabIsPopulatedOnInspectedPageRefresh): (.TestSuite.prototype.testNoScriptDuplicatesOnPanelSwitch.switchToElementsTab): (.TestSuite.prototype.testNoScriptDuplicatesOnPanelSwitch.switchToScriptsTab): (.TestSuite.prototype.testNoScriptDuplicatesOnPanelSwitch.checkScriptsPanel): (.TestSuite.prototype.testNoScriptDuplicatesOnPanelSwitch.checkNoDuplicates): (.TestSuite.prototype.testPauseOnException): (.TestSuite.prototype.testPauseWhenLoadingDevTools): (.TestSuite.prototype.testPauseWhenScriptIsRunning.testScriptPauseAfterDelay): (.TestSuite.prototype.testPauseWhenScriptIsRunning.testScriptPause): (.TestSuite.prototype.testPauseWhenScriptIsRunning): (.TestSuite.prototype.optionsToString_): (.TestSuite.prototype.evaluateInConsole_): (.TestSuite.prototype.waitForSetBreakpointResponse_): (.TestSuite.prototype.testEvalOnCallFrame.setBreakpointCallback): (.TestSuite.prototype.testEvalOnCallFrame.waitForBreakpointHit): (.TestSuite.prototype.testCompletionOnPause): (.TestSuite.prototype.testCompletionOnPause.testLocalsCompletion): (.TestSuite.prototype.testCompletionOnPause.testThisCompletion): (.TestSuite.prototype.testCompletionOnPause.testFieldCompletion): (.TestSuite.prototype.testCompletionOnPause.checkCompletions): (.TestSuite.prototype.testAutoContinueOnSyntaxError.checkScriptsList): (.TestSuite.prototype.testAutoContinueOnSyntaxError.waitForExceptionEvent.test): (.TestSuite.prototype.testAutoContinueOnSyntaxError.waitForExceptionEvent): (.TestSuite.prototype._checkExecutionLine): (.TestSuite.prototype._scriptsAreParsed): (.TestSuite.prototype._waitForScriptPause): (.TestSuite.prototype._checkSourceFrameWhenLoaded.checkExecLine): (.TestSuite.prototype._checkSourceFrameWhenLoaded): (.TestSuite.prototype._performSteps.doNextAction): (.TestSuite.prototype._performSteps): (.TestSuite.prototype._executeCodeWhenScriptsAreParsed.executeFunctionInInspectedPage): (.TestSuite.prototype._waitUntilScriptsAreParsed.waitForAllScripts): (.TestSuite.prototype._waitUntilScriptsAreParsed): (.TestSuite.prototype._executeFunctionForStepTest): (.TestSuite.prototype.testStepOver): (.TestSuite.prototype.testStepOut): (.TestSuite.prototype.testStepIn): (.TestSuite.prototype._evaluateXpath): (.TestSuite.prototype._findNode): (.TestSuite.prototype._findText): (.TestSuite.prototype._nodeIterator): (.TestSuite.prototype._checkScopeSectionDiv): (.TestSuite.prototype._expandScopeSections.updateListener): (.TestSuite.prototype._expandScopeSections): (.TestSuite.prototype.testExpandScope): (.TestSuite.prototype.testExpandScope.examineScopes): (.TestSuite.prototype._findChildProperty): (.TestSuite.prototype._hookGetPropertiesCallback.accessor.getProperties): (.TestSuite.prototype._hookGetPropertiesCallback.try): (.TestSuite.prototype._hookGetPropertiesCallback): (.TestSuite.prototype.testDebugIntrinsicProperties.expandLocalScope): (.TestSuite.prototype.testDebugIntrinsicProperties): (.TestSuite.prototype.testDebugIntrinsicProperties.expandAndCheckNextProperty): (.TestSuite.prototype.testDebugIntrinsicProperties.checkProperty): (.TestSuite.createKeyEvent): (.TestSuite.prototype.testConsoleLog.assertNext): (.TestSuite.prototype.testConsoleLog): (.TestSuite.prototype.testEvalGlobal.initEval): (.TestSuite.prototype.testEvalGlobal): (.TestSuite.prototype.testShowStoragePanel.this.addSniffer.): (.TestSuite.prototype.testShowStoragePanel.this.addSniffer): (.uiTests.runAllTests): (.uiTests.runTest):
- 3:55 AM Changeset in webkit [54545] by
-
- 7 edits in trunk/JavaScriptCore
Three small string fixes:
(1) StringBuilder::release should CRASH if the buffer allocation failed.
(2) Remove weird, dead code from JSString::tryGetValue, replace with an ASSERT.
(3) Move UString::createFromUTF8 out to the API, as tryCreateStringFromUTF8.
This is only used from the API, and (now) unlike other UString::create
methods may return UString::null() to indicate failure cases. Better
handle these in the API.
Reviewed by Oliver Hunt.
- API/JSClassRef.cpp:
(tryCreateStringFromUTF8):
(OpaqueJSClass::OpaqueJSClass):
(OpaqueJSClassContextData::OpaqueJSClassContextData):
- runtime/JSString.h:
(JSC::Fiber::tryGetValue):
- runtime/StringBuilder.h:
(JSC::StringBuilder::release):
- runtime/UString.cpp:
(JSC::UString::UString):
(JSC::UString::from):
(JSC::UString::find):
- runtime/UString.h:
- 3:13 AM Changeset in webkit [54544] by
-
- 2 edits in trunk/LayoutTests
2010-02-09 Yuzo Fujishima <yuzo@google.com>
Unreviewed.
Fix build brekage introduced by r54536.
Add the following two to Skipped:
fast/css/inline-element-line-break.html and
fast/css/pseudo-element-line-break.html
- platform/gtk/Skipped:
- 2:40 AM Changeset in webkit [54543] by
-
- 5 edits in trunk
2010-02-09 Chang Shu <Chang.Shu@nokia.com>
Reviewed by Laszlo Gombos.
[Qt] Enable http/tests/appcache but skip the failed cases.
https://bugs.webkit.org/show_bug.cgi?id=34713
- platform/qt/Skipped:
2010-02-09 Chang Shu <Chang.Shu@nokia.com>
Reviewed by Laszlo Gombos.
[Qt] Enable appcache feature.
https://bugs.webkit.org/show_bug.cgi?id=34713
- DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::WebPage::WebPage):
- DumpRenderTree/qt/main.cpp: (main):
- 2:24 AM Changeset in webkit [54542] by
-
- 1 edit1 add in trunk/WebCore
2010-02-09 Kwang Yul Seo <skyul@company100.net>
Reviewed by Eric Seidel.
[BREWMP] Port KURL::fileSystemPath
https://bugs.webkit.org/show_bug.cgi?id=34516
Convert a file URL to a file path by prefixing
AEEFS_HOME_DIR to access files relative to the current
module directory in a case-sensitive manner.
As IWeb "file:" engine opens files in BREW's application-relative
file namespace, we follow the same policy here.
- platform/brew/KURLBrew.cpp: Added. (WebCore::KURL::fileSystemPath):
- 2:07 AM Changeset in webkit [54541] by
-
- 2 edits in trunk/WebCore
2010-02-09 Noam Rosenthal <noam.rosenthal@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] the above website does not render properly when in compositing mode
https://bugs.webkit.org/show_bug.cgi?id=34681
http://media.24ways.org/2009/15/spinner-alt.html now renders correctly
- platform/graphics/qt/GraphicsLayerQt.cpp: (WebCore::MaskEffectQt::MaskEffectQt): implement mask as QGraphicsEffect (WebCore::MaskEffectQt::draw): reimp (WebCore::GraphicsLayerQtImpl::GraphicsLayerQtImpl): init the effect (WebCore::GraphicsLayerQtImpl::paint): no need for drawContents (WebCore::GraphicsLayerQtImpl::flushChanges): make sure to update the mask layer, not just the actual children
- 2:01 AM Changeset in webkit [54540] by
-
- 2 edits in trunk/LayoutTests
2010-02-09 Eric Seidel <eric@webkit.org>
Reviewed by Shinichiro Hamaji.
storage/database-lock-after-reload.html is flakey
https://bugs.webkit.org/show_bug.cgi?id=29154
- platform/mac/Skipped: Skip for now to keep the bots green until someone can take a look.
- 1:51 AM Changeset in webkit [54539] by
-
- 2 edits in trunk/JavaScriptCore
2010-02-09 Janne Koskinen <janne.p.koskinen@digia.com>
Reviewed by Laszlo Gombos.
[Qt] use nanval() for Symbian as nonInlineNaN
https://bugs.webkit.org/show_bug.cgi?id=34170
numeric_limits<double>::quiet_NaN is broken in Symbian
causing NaN to be evaluated as a number.
- runtime/JSValue.cpp: (JSC::nonInlineNaN):
- 1:39 AM Changeset in webkit [54538] by
-
- 3 edits20 adds in trunk/LayoutTests
2010-02-09 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Darin Adler.
Add modified version of CSS2.1 test suite for paged media
https://bugs.webkit.org/show_bug.cgi?id=34695
Note that page-break-inside-000 is failing now.
- platform/qt/Skipped:
- platform/win/Skipped:
- printing/css2.1/README.txt: Added.
- printing/css2.1/page-break-after-000-expected.txt: Added.
- printing/css2.1/page-break-after-000.html: Added.
- printing/css2.1/page-break-after-001-expected.txt: Added.
- printing/css2.1/page-break-after-001.html: Added.
- printing/css2.1/page-break-after-002-expected.txt: Added.
- printing/css2.1/page-break-after-002.html: Added.
- printing/css2.1/page-break-after-004-expected.txt: Added.
- printing/css2.1/page-break-after-004.html: Added.
- printing/css2.1/page-break-before-000-expected.txt: Added.
- printing/css2.1/page-break-before-000.html: Added.
- printing/css2.1/page-break-before-001-expected.txt: Added.
- printing/css2.1/page-break-before-001.html: Added.
- printing/css2.1/page-break-before-002-expected.txt: Added.
- printing/css2.1/page-break-before-002.html: Added.
- printing/css2.1/page-break-inside-000-expected.txt: Added.
- printing/css2.1/page-break-inside-000.html: Added.
- printing/resources/paged-media-test-utils.js: Added. (pageNumberShouldBe):
- 1:35 AM Changeset in webkit [54537] by
-
- 2 edits in trunk/WebCore
2010-02-09 Kwang Yul Seo <skyul@company100.net>
Reviewed by Laszlo Gombos.
[BREWMP] Fix macro redefinition error in BREWMP simulator build.
https://bugs.webkit.org/show_bug.cgi?id=34738
Remove warning: 'FAR' macro redefinition.
- platform/image-decoders/jpeg/JPEGImageDecoder.cpp:
- 1:16 AM Changeset in webkit [54536] by
-
- 12 edits8 adds in trunk
2010-02-07 Yuzo Fujishima <yuzo@google.com>
Reviewed by Dan Bernstein.
Fix the following bugs:
https://bugs.webkit.org/show_bug.cgi?id=18926 - dt:after generate a line break. Boost documentation page renders poorly
https://bugs.webkit.org/show_bug.cgi?id=7276 - Most W3C padding related tests fail
css2.1/t0803-c5504-imrgn-l-02-b-ag-expected.html and css2.1/t0804-c5509-ipadn-l-02-b-ag-expected.html have been rebaselined
because the original expected values are incorrect, judging from the test description and how IE 8.0, Firefox 3.6, and Opera 10.10 render the pages.
fast/dom/clone-node-dynamic-style-expected.html have been also rebaselined because the original expected values assumes a line break.
Expected values under platform/qt need not be updated because the tests are in the Skipped file for the platform.
- fast/css/inline-element-line-break.html: Added.
- fast/css/pseudo-element-line-break.html: Added.
- platform/mac/css2.1/t0803-c5504-imrgn-l-02-b-ag-expected.checksum:
- platform/mac/css2.1/t0803-c5504-imrgn-l-02-b-ag-expected.png:
- platform/mac/css2.1/t0803-c5504-imrgn-l-02-b-ag-expected.txt:
- platform/mac/css2.1/t0804-c5509-ipadn-l-02-b-ag-expected.checksum:
- platform/mac/css2.1/t0804-c5509-ipadn-l-02-b-ag-expected.png:
- platform/mac/css2.1/t0804-c5509-ipadn-l-02-b-ag-expected.txt:
- platform/mac/fast/css/inline-element-line-break-expected.checksum: Added.
- platform/mac/fast/css/inline-element-line-break-expected.png: Added.
- platform/mac/fast/css/inline-element-line-break-expected.txt: Added.
- platform/mac/fast/css/pseudo-element-line-break-expected.checksum: Added.
- platform/mac/fast/css/pseudo-element-line-break-expected.png: Added.
- platform/mac/fast/css/pseudo-element-line-break-expected.txt: Added.
- platform/mac/fast/dom/clone-node-dynamic-style-expected.checksum:
- platform/mac/fast/dom/clone-node-dynamic-style-expected.png:
- platform/mac/fast/dom/clone-node-dynamic-style-expected.txt:
2010-02-07 Yuzo Fujishima <yuzo@google.com>
Reviewed by Dan Bernstein.
Fix the following bugs:
https://bugs.webkit.org/show_bug.cgi?id=18926 - dt:after generate a line break. Boost documentation page renders poorly
https://bugs.webkit.org/show_bug.cgi?id=7276 - Most W3C padding related tests fail
Tests: fast/css/inline-element-line-break.html
fast/css/pseudo-element-line-break.html
findNextLineBreak() unconditionally allowed lines to break between elements when no other line breaking opportunity had been found,
but that was unnecessary and led to incorrect layout. Disallow that kind of line breaks.
- rendering/RenderBlockLineLayout.cpp: (WebCore::RenderBlock::findNextLineBreak):
- 12:52 AM Changeset in webkit [54535] by
-
- 3 edits2 adds in trunk
2010-02-09 Avi Drissman <avi@chromium.org>
Reviewed by David Levin.
Chromium Mac: Control-A shouldn't select all/Control-C shouldn't copy
https://bugs.webkit.org/show_bug.cgi?id=34615
- fast/events/attempt-select-all-with-wrong-modifier-expected.txt: Added.
- fast/events/attempt-select-all-with-wrong-modifier.html: Added.
2010-02-09 Avi Drissman <avi@chromium.org>
Reviewed by David Levin.
Chromium Mac: Control-A shouldn't select all/Control-C shouldn't copy
https://bugs.webkit.org/show_bug.cgi?id=34615
- src/WebViewImpl.cpp: (WebKit::WebViewImpl::keyEventDefault):
- 12:50 AM Changeset in webkit [54534] by
-
- 6 edits in trunk/JavaScriptCore
Add a soft modulo operation to ARM JIT using a trampoline function.
The performance progression is about ~1.8% on ARMv7
https://bugs.webkit.org/show_bug.cgi?id=34424
Patch by Tamas Szirbucz <szirbucz@inf.u-szeged.hu> on 2010-02-09
Reviewed by Gavin Barraclough.
Developed in cooperation with Gabor Loki.
- jit/JIT.h:
- jit/JITArithmetic.cpp:
(JSC::JIT::emit_op_mod):
(JSC::JIT::emitSlow_op_mod):
- jit/JITOpcodes.cpp:
(JSC::JIT::softModulo):
- jit/JITStubs.h:
(JSC::JITThunks::ctiSoftModulo):
- wtf/Platform.h:
- 12:32 AM Changeset in webkit [54533] by
-
- 17 edits3 adds in trunk
2010-02-09 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Darin Adler.
Provide a way to get total number of pages to be printed
https://bugs.webkit.org/show_bug.cgi?id=34699
- platform/gtk/Skipped:
- platform/qt/Skipped:
- platform/win/Skipped:
- printing/numberOfPages-expected.txt: Added.
- printing/numberOfPages.html: Added.
- printing/script-tests/numberOfPages.js: Added. (createParagraph):
2010-02-09 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Darin Adler.
Provide a way to get total number of pages to be printed
https://bugs.webkit.org/show_bug.cgi?id=34699
Test: printing/numberOfPages.html
- WebCore.base.exp:
- page/PrintContext.cpp: (WebCore::PrintContext::pageNumberForElement): (WebCore::PrintContext::numberOfPages):
- page/PrintContext.h: (WebCore::PrintContext::pageRects):
2010-02-09 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Darin Adler.
Provide a way to get total number of pages to be printed
https://bugs.webkit.org/show_bug.cgi?id=34699
- Misc/WebCoreStatistics.h:
- Misc/WebCoreStatistics.mm: (-[WebFrame numberOfPages:pageWidthInPixels:]):
2010-02-09 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Darin Adler.
Provide a way to get total number of pages to be printed
https://bugs.webkit.org/show_bug.cgi?id=34699
- DumpRenderTree/LayoutTestController.cpp: (parsePageParameters): (pageNumberForElementByIdCallback): (numberOfPagesCallback): (LayoutTestController::staticFunctions):
- DumpRenderTree/LayoutTestController.h:
- DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::numberOfPages):
- DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::numberOfPages):
- DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::numberOfPages):
Feb 8, 2010:
- 11:53 PM Changeset in webkit [54532] by
-
- 3 edits in trunk/JavaScriptCore
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- runtime/StringPrototype.cpp:
Reviewed by NOBODY (SL/win build fixes).
- 11:40 PM Changeset in webkit [54531] by
-
- 5 edits in trunk/JavaScriptCore
Make String.replace throw an exception on out-of-memory, rather than
returning a null (err, empty-ish) string. Move String::replaceRange
and String::spliceSubstringsWithSeparators out to StringPrototype -
these were fairly specific use anyway, and we can better integrate
throwing the JS expcetion this way.
Reviewed by Oliver Hunt
Also removes redundant assignment operator from UString.
- JavaScriptCore.exp:
- runtime/StringPrototype.cpp:
(JSC::StringRange::StringRange):
(JSC::jsSpliceSubstringsWithSeparators):
(JSC::jsReplaceRange):
(JSC::stringProtoFuncReplace):
- runtime/UString.cpp:
- runtime/UString.h:
- 11:32 PM Changeset in webkit [54530] by
-
- 1 edit3 adds in trunk/LayoutTests
Add numerous parse-only tests.
https://bugs.webkit.org/show_bug.cgi?id=34019
Patch by Zoltan Herczeg <zherczeg@inf.u-szeged.hu> on 2010-02-09
Reviewed by Oliver Hunt.
The input file contains a lot of strings, and tests whether they are
valid JavaScript code snippets or contains various syntax errors.
No semantic checks: even if a tests throws an exception, which is not
syntax error, it is considered successfull.
- fast/js/parser-syntax-check-expected.txt: Added.
- fast/js/parser-syntax-check.html: Added.
- fast/js/script-tests/parser-syntax-check.js: Added.
(runTest):
(valid):
(invalid):
- 11:15 PM Changeset in webkit [54529] by
-
- 2 edits in trunk/LayoutTests
2010-02-08 Shinichiro Hamaji <hamaji@chromium.org>
Unreviewed GTK+ test fix.
Web site is stuck loading forever
https://bugs.webkit.org/show_bug.cgi?id=31227
It seems the following bug is addressing this issue.
[GTK] Needs proper reporting of frame loader callbacks, in DRT
https://bugs.webkit.org/show_bug.cgi?id=32170
- platform/gtk/Skipped:
- 11:15 PM Changeset in webkit [54528] by
-
- 2 edits in trunk/JavaScriptCore
2010-02-08 Kwang Yul Seo <skyul@company100.net>
Reviewed by Eric Seidel.
[BREWMP] Undefine WTF_OS_WINDOWS and WTF_PLATFORM_WIN
https://bugs.webkit.org/show_bug.cgi?id=34561
As the binary for simulator is built with MSVC 2005,
WTF_OS_WINDOWS and WTF_PLATFORM_WIN are defined.
Undefine them as we don't target Windows.
- wtf/Platform.h:
- 10:48 PM Changeset in webkit [54527] by
-
- 4 edits1 add in trunk/WebCore
2010-02-08 Dominic Cooney <dominicc@google.com>
Reviewed by Adam Barth.
[V8] Move Element custom methods into generic bindings
This patch moves the security checks in setAttribute,
setAttributeNode, setAttributeNS and setAttributeNodeNS from
V8ElementCustom into the generic bindings so that they can be
reused in other bindings. This is in a similar vein to
<https://bugs.webkit.org/attachment.cgi?id=45872>.
LayoutTests: None
- WebCore.gypi:
- bindings/generic/BindingElement.h: Added. (WebCore::::setAttribute): (WebCore::::setAttributeNode): (WebCore::::setAttributeNS): (WebCore::::setAttributeNodeNS):
- bindings/v8/V8Binding.h:
- bindings/v8/custom/V8ElementCustom.cpp: (WebCore::V8Element::setAttributeCallback): (WebCore::V8Element::setAttributeNodeCallback): (WebCore::V8Element::setAttributeNSCallback): (WebCore::V8Element::setAttributeNodeNSCallback):
- 10:17 PM Changeset in webkit [54526] by
-
- 3 edits4 adds in trunk
2010-02-08 Hayato Ito <hayato@chromium.org>
Reviewed by Darin Adler.
Schedule a loading request when there are many in-flight requests beyond
the limit to avoid forever page loading.
- http/tests/loading/load-javascript-after-many-xhrs-expected.txt: Added.
- http/tests/loading/load-javascript-after-many-xhrs.html: Added.
- http/tests/loading/resources/zero-length.js: Added.
- http/tests/loading/resources/zero-length.txt: Added.
2010-02-08 Hayato Ito <hayato@chromium.org>
Reviewed by Darin Adler.
Schedule a loading request when there are many in-flight requests beyond
the limit to avoid forever page loading.
Test: http/tests/loading/load-javascript-after-many-xhrs.html
- loader/loader.cpp: (WebCore::Loader::Host::servePendingRequests):
- 9:19 PM Changeset in webkit [54525] by
-
- 4 edits in trunk/WebCore
REGRESSION (before r54472): Various tests in fast/workers are crashing on the buildbot.
https://bugs.webkit.org/show_bug.cgi?id=34728
Reviewed by Gavin Barraclough.
The core part of the fix is to change WebCoreJSClientData::m_normalWorld
from DOMWrapperWorld to RefPtr<DOMWrapperWorld> so that the DOMWrapperWorld
is really ref counted.
No new tests because current tests sufficiently cover this as evidenced as
the buildbot crashes.
- bindings/js/JSDOMBinding.cpp:
(WebCore::DOMWrapperWorld::~DOMWrapperWorld): Made this robust to m_globalData
being 0.
- bindings/js/JSDOMBinding.h:
(WebCore::DOMWrapperWorld::create): Made this class follow the standard
create pattern for RefCounted classes.
(WebCore::DOMWrapperWorld::detachFromGlobalData): Since this class can
now outlive JSGlobalData, this method tells it to stop using its JSGlobalData.
(WebCore::WebCoreJSClientData::WebCoreJSClientData): Adjusted due to
m_normalWorld being a RefPtr.
(WebCore::WebCoreJSClientData::~WebCoreJSClientData): Ditto (and added
asserts for the FIXME).
(WebCore::WebCoreJSClientData::normalWorld): Ditto.
- bindings/js/ScriptController.cpp:
(WebCore::IsolatedWorld::create): Made the constructor protected.
(WebCore::IsolatedWorld::IsolatedWorld): Made the constructor protected, so
that code would have to use the create method.
- 7:05 PM Changeset in webkit [54524] by
-
- 2 edits in trunk/WebKit/chromium
2010-02-08 Evan Martin <evan@chromium.org>
dlopen() knows how to search the library search path, so just rely on
it. While I'm at it, print out the dlerror() error message on failure.
[chromium] webgl shouldn't hard code library search path
https://bugs.webkit.org/show_bug.cgi?id=34659
- src/GraphicsContext3D.cpp: (WebCore::GraphicsContext3DInternal::GLConnection::GLConnection): (WebCore::GraphicsContext3DInternal::GLConnection::create):
- 6:48 PM Changeset in webkit [54523] by
-
- 3 edits in trunk/WebCore
2010-02-08 Kinuko Yasuda <kinuko@chromium.org>
Reviewed by David Levin.
Remove special utf-8 tag from Chromium cilpboard code because
we now have the corresponding code in generic clipboard framework
code in chromium (since it's needed by other places than in Web
page rendering) and no longer need the separate workaround code in
WebKit.
https://bugs.webkit.org/show_bug.cgi?id=34567
Test: (for regression) editing/pasteboard
- platform/chromium/ClipboardChromium.cpp: (WebCore::ClipboardChromium::writeRange):
- platform/chromium/PasteboardChromium.cpp: (WebCore::Pasteboard::writeSelection): (WebCore::Pasteboard::documentFragment):
- 6:31 PM Changeset in webkit [54522] by
-
- 1 edit1 add in trunk/JavaScriptCore
2010-02-08 Chris Rogers <crogers@google.com>
Reviewed by Darin Adler.
audio engine: add Vector3 class
https://bugs.webkit.org/show_bug.cgi?id=34548
- wtf/Vector3.h: Added. (WebCore::Vector3::Vector3): (WebCore::Vector3::abs): (WebCore::Vector3::isZero): (WebCore::Vector3::normalize): (WebCore::Vector3::x): (WebCore::Vector3::y): (WebCore::Vector3::z): (WebCore::operator+): (WebCore::operator-): (WebCore::operator*): (WebCore::dot): (WebCore::cross): (WebCore::distance):
- 6:12 PM Changeset in webkit [54521] by
-
- 3 edits2 adds in trunk
Crash due to layout not done in case involving removal of absolute positioning
https://bugs.webkit.org/show_bug.cgi?id=34734
rdar://problem/7588280
Reviewed by Dan Bernstein.
WebCore:
Test: fast/dynamic/position-change-layout.html
- rendering/RenderObject.cpp:
(WebCore::RenderObject::styleDidChange): Call markContainingBlocksForLayout in
a case where the object already needs layout, but might have a new containing
block and so needs to mark the new containing block.
LayoutTests:
- fast/dynamic/position-change-layout-expected.txt: Added.
- fast/dynamic/position-change-layout.html: Added.
- 5:24 PM Changeset in webkit [54520] by
-
- 2 edits in trunk/JavaScriptCore
2010-02-08 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
Fix warning in clang++
- runtime/Structure.h: (JSC::Structure::propertyStorageSize):
- 4:32 PM Changeset in webkit [54519] by
-
- 5 edits2 adds in trunk
2010-02-08 Charlie Reis <creis@chromium.org>
Reviewed by Darin Adler.
onbeforeunload not called at window close + frame or iframe focused
https://bugs.webkit.org/show_bug.cgi?id=27481
Chromium and WebKit on Windows will now fire beforeunload handlers
even if an inner frame is focused.
Layout tests aren't able to test this bug, since it requires closing
the actual browser window, not calling window.close(). Instead,
test with WebCore/manual-tests/onbeforeunload-focused-iframe.html.
- manual-tests/onbeforeunload-focused-iframe.html: Added.
- manual-tests/resources/focused-iframe.html: Added.
2010-02-08 Charlie Reis <creis@chromium.org>
Reviewed by Darin Adler.
onbeforeunload not called at window close + frame or iframe focused
https://bugs.webkit.org/show_bug.cgi?id=27481
http://code.google.com/p/chromium/issues/detail?id=32615
http://code.google.com/p/chromium/issues/detail?id=17157
Chromium and WebKit on Windows will now fire beforeunload handlers
even if an inner frame is focused.
Layout tests aren't able to test this bug, since it requires closing
the actual browser window, not calling window.close(). Instead,
test with WebCore/manual-tests/onbeforeunload-focused-iframe.html.
- src/WebViewImpl.cpp: (WebKit::WebViewImpl::dispatchBeforeUnloadEvent):
2010-02-08 Charlie Reis <creis@chromium.org>
Reviewed by Darin Adler.
onbeforeunload not called at window close + frame or iframe focused
https://bugs.webkit.org/show_bug.cgi?id=27481
Chromium and WebKit on Windows will now fire beforeunload handlers
even if an inner frame is focused.
Layout tests aren't able to test this bug, since it requires closing
the actual browser window, not calling window.close(). Instead,
test with WebCore/manual-tests/onbeforeunload-focused-iframe.html.
- WebView.cpp: (WebView::shouldClose):
- 3:43 PM Changeset in webkit [54518] by
-
- 3 edits in trunk/JavaScriptCore
Make makeString CRASH if we fail to allocate a string.
Reviewed by Geoff Garen.
(tryMakeString or jsMakeNontrivialString can be used where we
expect allocation may fail and want to handle the error).
- runtime/JSStringBuilder.h:
(JSC::jsMakeNontrivialString):
- runtime/UString.h:
(JSC::tryMakeString):
(JSC::makeString):
- 3:28 PM Changeset in webkit [54517] by
-
- 2 edits in trunk/WebCore
Addressing review feedback.
- bridge/c/c_instance.h: Removed argument name.
- 3:27 PM Changeset in webkit [54516] by
-
- 10 edits2 adds in trunk
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=34727
Assertion crashes and freezes when plug-in property access results in an exception
Test: plugins/netscape-plugin-property-access-exception.html
- 3:27 PM Changeset in webkit [54515] by
-
- 2 edits in trunk/WebKit/chromium
2010-02-08 Pavel Feldman <pfeldman@chromium.org>
Reviewed by David Levin.
WebKit/chromium: Custom context menu does not work in inspector.
https://bugs.webkit.org/show_bug.cgi?id=34711
- src/WebDevToolsFrontendImpl.cpp: (WebKit::WebDevToolsFrontendImpl::jsShowContextMenu):
- 3:13 PM Changeset in webkit [54514] by
-
- 2 edits in trunk/JavaScriptCore
Rubber Stamped by Oliver Hunt.
Remove a couple of unnecesary C-style casts spotted by Darin.
- runtime/JSGlobalObjectFunctions.cpp:
(JSC::encode):
(JSC::globalFuncEscape):
- 3:04 PM Changeset in webkit [54513] by
-
- 3 edits in trunk/JavaScriptCore
Switch some more StringBuilder/jsNontrivialString code to use
JSStringBuilder/jsMakeNontrivialString - these methods will
throw an exception if we hit out-of-memory, rather than just
CRASHing.
Reviewed by Geoff Garen.
- runtime/FunctionPrototype.cpp:
(JSC::functionProtoFuncToString):
- runtime/JSGlobalObjectFunctions.cpp:
(JSC::encode):
(JSC::decode):
(JSC::globalFuncEscape):
- 2:58 PM Changeset in webkit [54512] by
-
- 4 edits in trunk/WebKitTools
[Qt] Backport No'am Rosenthal's frame rate measurement
Reviewed by Ariya Hidayat.
- QtLauncher/main.cpp:
(LauncherWindow::LauncherWindow):
(LauncherApplication::handleUserOptions):
- QtLauncher/webview.cpp:
(WebViewGraphicsBased::WebViewGraphicsBased):
(WebViewGraphicsBased::enableFrameRateMeasurement):
(WebViewGraphicsBased::updateFrameRate):
(WebViewGraphicsBased::paintEvent):
- QtLauncher/webview.h:
- 2:43 PM Changeset in webkit [54511] by
-
- 2 edits in trunk/WebKit/chromium
2010-02-08 Nate Chapin <Nate Chapin>
Reviewed by Darin Fisher.
Check that the index passed into BackForwardListClientImpl::itemAtIndex()
is valid, and return null if it isn't.
- src/BackForwardListClientImpl.cpp: (WebKit::BackForwardListClientImpl::itemAtIndex):
- 2:26 PM Changeset in webkit [54510] by
-
- 8 edits in trunk/JavaScriptCore
Use an empty identifier instead of a null identifier for parse
tokens without an identifier.
Reviewed by Sam Weinig.
This helps encapsulate the null UStringImpl within UString.
- parser/Grammar.y:
- parser/NodeConstructors.h:
(JSC::ContinueNode::ContinueNode):
(JSC::BreakNode::BreakNode):
(JSC::ForInNode::ForInNode):
- runtime/CommonIdentifiers.cpp:
(JSC::CommonIdentifiers::CommonIdentifiers):
- runtime/CommonIdentifiers.h:
- runtime/FunctionPrototype.cpp:
(JSC::FunctionPrototype::FunctionPrototype):
- 1:55 PM Changeset in webkit [54509] by
-
- 4 edits in trunk/WebCore
2010-02-08 Dirk Schulze <krit@webkit.org>
Unreviewed build fix of ChromiumWin.
- platform/graphics/chromium/TransparencyWin.cpp: (WebCore::): (WebCore::TransparencyWin::setupLayerForOpaqueCompositeLayer): (WebCore::TransparencyWin::setupTransformForKeepTransform):
- platform/graphics/chromium/TransparencyWin.h:
- rendering/RenderThemeChromiumWin.cpp: (WebCore::):
- 1:48 PM Changeset in webkit [54508] by
-
- 2 edits in trunk/WebKit/gtk
2010-02-08 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
[GTK] Implement FrameLoaderClient::hasWebView
https://bugs.webkit.org/show_bug.cgi?id=34682
Used for sanity-check ASSERTS in the FrameLoader code.
- WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::hasWebView):
- 1:35 PM Changeset in webkit [54507] by
-
- 2 edits in trunk/LayoutTests
Put the test back on skipped list - it needs a newer version of Safari to pass.
- platform/mac-snowleopard/Skipped:
- 1:20 PM Changeset in webkit [54506] by
-
- 7 edits in trunk
WebCore: Adding a way to get the set of all open database handles pointing
to a given database.
https://bugs.webkit.org/show_bug.cgi?id=34619
Reviewed by Jeremy Orlow.
Sometimes we need to be able to close all handles to a database as
soon as possible (to delete the DB file, for example).
- storage/DatabaseTracker.cpp:
(WebCore::DatabaseTracker::getOpenDatabases):
- storage/DatabaseTracker.h:
- storage/chromium/DatabaseTrackerChromium.cpp:
(WebCore::DatabaseTracker::addOpenDatabase):
(WebCore::DatabaseTracker::removeOpenDatabase):
(WebCore::DatabaseTracker::getOpenDatabases):
WebKit/chromium: Adding a way to close all database handles pointing to a certain
database as soon as possible.
https://bugs.webkit.org/show_bug.cgi?id=34619
Reviewed by Jeremy Orlow.
- public/WebDatabase.h:
- src/WebDatabase.cpp:
(WebKit::WebDatabase::closeDatabaseImmediately):
- 12:55 PM Changeset in webkit [54505] by
-
- 2 edits in trunk/WebCore
2010-02-08 Dirk Schulze <krit@webkit.org>
Unreviewed windows build-fix.
- page/win/FrameCGWin.cpp: (WebCore::drawRectIntoContext):
- 12:53 PM Changeset in webkit [54504] by
-
- 8 edits in trunk
Reviewed by Anders Carlsson.
<rdar://problem/6530010> OOP: Support NPN_SetException
Tested by plugins/netscape-throw-exception.html (removed it from skipped list).
- Plugins/Hosted/NetscapePluginHostProxy.mm: (WKPCSetException):
- Plugins/Hosted/NetscapePluginInstanceProxy.h:
- Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::globalExceptionString): (WebKit::NetscapePluginInstanceProxy::setGlobalException): (WebKit::NetscapePluginInstanceProxy::moveGlobalExceptionToExecState):
- Plugins/Hosted/ProxyInstance.mm: (WebKit::ProxyInstance::invoke): (WebKit::ProxyInstance::getPropertyNames): (WebKit::ProxyInstance::fieldValue): (WebKit::ProxyInstance::setFieldValue):
- Plugins/Hosted/WebKitPluginClient.defs: Route exception string to a global that's checked after calling into plug-in (just like in in-process case).
- 12:30 PM Changeset in webkit [54503] by
-
- 154 edits in trunk
2010-02-08 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
Add back an AffineTransform class for use by SVG
https://bugs.webkit.org/show_bug.cgi?id=33750
This adds back AffineTransform. This saves additional 4% memory consumption
on the 50k rects stress test: https://bugs.webkit.org/attachment.cgi?id=46721
It also makes it possible to optimize the calculations internally of
AffineTransform to the needs of 2D transformations (the second benefit for SVG,
which uses transformations relative often at the moment.
Everything that is 2D related (like images, patterns, gradients, fonts), uses
AffineTransform now.
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSSVGMatrixCustom.cpp: (WebCore::JSSVGMatrix::multiply): (WebCore::JSSVGMatrix::inverse): (WebCore::JSSVGMatrix::rotateFromVector):
- bindings/js/JSSVGPODTypeWrapper.h:
- bindings/scripts/CodeGeneratorJS.pm:
- bindings/scripts/CodeGeneratorObjC.pm:
- bindings/scripts/CodeGeneratorV8.pm:
- bindings/v8/V8Index.h:
- bindings/v8/custom/V8SVGMatrixCustom.cpp: (WebCore::V8SVGMatrix::multiplyCallback): (WebCore::V8SVGMatrix::inverseCallback): (WebCore::V8SVGMatrix::rotateFromVectorCallback):
- html/HTMLCanvasElement.cpp: Changed to AffineTransform now (WebCore::HTMLCanvasElement::baseTransform):
- html/HTMLCanvasElement.h:
- platform/graphics/FloatPoint.cpp: (WebCore::FloatPoint::matrixTransform):
- platform/graphics/FloatPoint.h:
- platform/graphics/GeneratedImage.cpp: (WebCore::GeneratedImage::drawPattern):
- platform/graphics/GeneratedImage.h:
- platform/graphics/Gradient.cpp: (WebCore::Gradient::setGradientSpaceTransform): (WebCore::Gradient::setPlatformGradientSpaceTransform):
- platform/graphics/Gradient.h: (WebCore::Gradient::gradientSpaceTransform):
- platform/graphics/GraphicsContext.h:
- platform/graphics/Image.cpp: (WebCore::Image::drawTiled):
- platform/graphics/Image.h:
- platform/graphics/ImageBuffer.h: (WebCore::ImageBuffer::baseTransform):
- platform/graphics/Path.h:
- platform/graphics/Pattern.cpp: (WebCore::Pattern::setPatternSpaceTransform):
- platform/graphics/Pattern.h: (WebCore::Pattern::create): (WebCore::Pattern::tileImage):
- platform/graphics/cairo/FontCairo.cpp: (WebCore::Font::drawGlyphs):
- platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::setPlatformFill): (WebCore::setPlatformStroke): (WebCore::GraphicsContext::getCTM):
- platform/graphics/cairo/ImageCairo.cpp: (WebCore::Image::drawPattern):
- platform/graphics/cairo/PathCairo.cpp:
- platform/graphics/cairo/PatternCairo.cpp: (WebCore::Pattern::createPlatformPattern):
- platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::getCTM):
- platform/graphics/cg/GraphicsContextPlatformPrivateCG.h: (WebCore::GraphicsContextPlatformPrivate::concatCTM):
- platform/graphics/cg/ImageCG.cpp: (WebCore::Image::drawPattern):
- platform/graphics/cg/PathCG.cpp:
- platform/graphics/cg/PatternCG.cpp: (WebCore::Pattern::createPlatformPattern):
- platform/graphics/haiku/GraphicsContextHaiku.cpp: (WebCore::GraphicsContext::getCTM):
- platform/graphics/haiku/ImageHaiku.cpp: (WebCore::Image::drawPattern):
- platform/graphics/haiku/PathHaiku.cpp:
- platform/graphics/qt/FontQt.cpp: (WebCore::Font::drawComplexText):
- platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::getCTM): (WebCore::GraphicsContext::fillPath): (WebCore::GraphicsContext::strokePath): (WebCore::GraphicsContext::fillRect):
- platform/graphics/qt/ImageQt.cpp: (WebCore::Image::drawPattern):
- platform/graphics/qt/PathQt.cpp:
- platform/graphics/qt/PatternQt.cpp: (WebCore::Pattern::createPlatformPattern):
- platform/graphics/skia/GradientSkia.cpp: (WebCore::Gradient::setPlatformGradientSpaceTransform):
- platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContext::getCTM):
- platform/graphics/skia/ImageSkia.cpp: (WebCore::Image::drawPattern):
- platform/graphics/skia/PathSkia.cpp:
- platform/graphics/skia/PatternSkia.cpp: (WebCore::Pattern::platformPattern):
- platform/graphics/skia/SkiaFontWin.cpp: (WebCore::windowsCanHandleTextDrawing):
- platform/graphics/transforms/AffineTransform.cpp: (WebCore::AffineTransform::makeIdentity): needed by some parts of WebCore (WebCore::AffineTransform::scale): Didn't scale the complete matrix (WebCore::AffineTransform::translate): Didn't respect other transformations (WebCore::AffineTransform::shear): direct calculation, no extra multiply of matrices (WebCore::AffineTransform::map): (WebCore::AffineTransform::mapPoint): (WebCore::AffineTransform::mapRect):
- platform/graphics/transforms/AffineTransform.h: (WebCore::AffineTransform::isIdentityOrTranslation):
- platform/graphics/transforms/TransformationMatrix.cpp: (WebCore::TransformationMatrix::toAffineTransform):
- platform/graphics/transforms/TransformationMatrix.h:
- platform/graphics/win/FontCGWin.cpp: (WebCore::drawGDIGlyphs):
- platform/graphics/win/GraphicsContextCGWin.cpp:
- platform/graphics/win/GraphicsContextCairoWin.cpp:
- platform/graphics/win/GraphicsContextWin.cpp: (WebCore::GraphicsContextPlatformPrivate::concatCTM):
- platform/graphics/wince/FontWince.cpp:
- platform/graphics/wince/GraphicsContextWince.cpp: (WebCore::GraphicsContextPlatformPrivate::concatCTM): (WebCore::GraphicsContext::fillPath): (WebCore::GraphicsContext::strokePath): (WebCore::GraphicsContext::getCTM): (WebCore::GraphicsContext::drawBitmapPattern):
- platform/graphics/wince/ImageBufferWince.cpp: (WebCore::): (WebCore::BufferedImage::drawPattern):
- platform/graphics/wince/PathWince.cpp: (WebCore::Path::transform):
- platform/graphics/wince/PlatformPathWince.cpp: (WebCore::drawPolygons): (WebCore::PathPolygon::transform): (WebCore::PlatformPathElement::transform): (WebCore::PlatformPath::strokePath): (WebCore::PlatformPath::fillPath): (WebCore::PlatformPath::transform):
- platform/graphics/wince/PlatformPathWince.h: (WebCore::):
- platform/graphics/wx/GraphicsContextWx.cpp: (WebCore::GraphicsContext::getCTM):
- platform/graphics/wx/ImageWx.cpp: (WebCore::BitmapImage::drawPattern): (WebCore::Image::drawPattern):
- platform/graphics/wx/PathWx.cpp:
- platform/gtk/RenderThemeGtk.cpp: (WebCore::paintMozillaGtkWidget):
- plugins/win/PluginViewWin.cpp: (WebCore::PluginView::paintWindowedPluginIntoContext):
- rendering/RenderBox.cpp: (WebCore::RenderBox::localTransform):
- rendering/RenderBox.h:
- rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelScaleData::RenderBoxModelScaleData): (WebCore::RenderBoxModelScaleData::transform): (WebCore::RenderBoxModelScaleData::setTransform): (WebCore::RenderBoxModelScaleObserver::shouldPaintBackgroundAtLowQuality): (WebCore::RenderBoxModelObject::paintBoxShadow):
- rendering/RenderForeignObject.cpp: (WebCore::RenderForeignObject::translationForAttributes): (WebCore::RenderForeignObject::localToParentTransform):
- rendering/RenderForeignObject.h: (WebCore::RenderForeignObject::localTransform):
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::paintLayer):
- rendering/RenderObject.cpp: (WebCore::RenderObject::localTransform): (WebCore::RenderObject::localToParentTransform): (WebCore::RenderObject::absoluteTransform):
- rendering/RenderObject.h:
- rendering/RenderPath.cpp: (WebCore::RenderPath::localToParentTransform): (WebCore::RenderPath::localTransform):
- rendering/RenderPath.h:
- rendering/RenderSVGHiddenContainer.h: (WebCore::RenderSVGHiddenContainer::absoluteTransform):
- rendering/RenderSVGImage.h: (WebCore::RenderSVGImage::localToParentTransform): (WebCore::RenderSVGImage::localTransform):
- rendering/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::localToBorderBoxTransform): (WebCore::RenderSVGRoot::localToRepaintContainerTransform): (WebCore::RenderSVGRoot::localToParentTransform): (WebCore::RenderSVGRoot::absoluteTransform): (WebCore::RenderSVGRoot::localTransform):
- rendering/RenderSVGRoot.h:
- rendering/RenderSVGText.h: (WebCore::RenderSVGText::localToParentTransform): (WebCore::RenderSVGText::localTransform):
- rendering/RenderSVGTransformableContainer.cpp: (WebCore::RenderSVGTransformableContainer::localToParentTransform): (WebCore::RenderSVGTransformableContainer::localTransform): (WebCore::RenderSVGTransformableContainer::calculateLocalTransform):
- rendering/RenderSVGTransformableContainer.h:
- rendering/RenderSVGViewportContainer.cpp: (WebCore::RenderSVGViewportContainer::markerBoundaries): (WebCore::RenderSVGViewportContainer::markerContentTransformation): (WebCore::RenderSVGViewportContainer::viewportTransform): (WebCore::RenderSVGViewportContainer::localToParentTransform): (WebCore::RenderSVGViewportContainer::absoluteTransform):
- rendering/RenderSVGViewportContainer.h:
- rendering/SVGCharacterLayoutInfo.cpp: (WebCore::SVGChar::characterTransform):
- rendering/SVGCharacterLayoutInfo.h: (WebCore::SVGTextChunkWalker::operator()):
- rendering/SVGInlineTextBox.cpp: (WebCore::SVGInlineTextBox::calculateGlyphBoundaries): (WebCore::SVGInlineTextBoxClosestCharacterToPositionWalker::chunkPortionCallback): (WebCore::SVGInlineTextBoxSelectionRectWalker::chunkPortionCallback): (WebCore::SVGInlineTextBox::paintCharacters): (WebCore::SVGInlineTextBox::paintDecoration):
- rendering/SVGMarkerLayoutInfo.h: (WebCore::MarkerLayout::MarkerLayout):
- rendering/SVGRenderSupport.cpp: (WebCore::applyTransformToPaintInfo):
- rendering/SVGRenderSupport.h:
- rendering/SVGRenderTreeAsText.cpp: (WebCore::operator<<):
- rendering/SVGRenderTreeAsText.h:
- rendering/SVGRootInlineBox.cpp: (WebCore::SVGRootInlineBoxPaintWalker::chunkPortionCallback): (WebCore::applyTextLengthCorrectionToTextChunk): (WebCore::SVGRootInlineBox::buildLayoutInformation):
- rendering/TransformState.cpp: (WebCore::TransformState::applyTransform):
- rendering/TransformState.h:
- svg/GradientAttributes.h: (WebCore::GradientAttributes::gradientTransform): (WebCore::GradientAttributes::setGradientTransform):
- svg/PatternAttributes.h: (WebCore::PatternAttributes::patternTransform): (WebCore::PatternAttributes::setPatternTransform):
- svg/SVGAnimateMotionElement.cpp: (WebCore::SVGAnimateMotionElement::resetToBaseValue): (WebCore::SVGAnimateMotionElement::calculateAnimatedValue): (WebCore::SVGAnimateMotionElement::applyResultsToTarget):
- svg/SVGAnimateMotionElement.h:
- svg/SVGAnimateTransformElement.cpp:
- svg/SVGAnimateTransformElement.h:
- svg/SVGElement.h: (WebCore::SVGElement::supplementalTransform):
- svg/SVGFitToViewBox.cpp: (WebCore::SVGFitToViewBox::viewBoxToViewTransform):
- svg/SVGFitToViewBox.h:
- svg/SVGLocatable.cpp: (WebCore::SVGLocatable::getCTM): (WebCore::SVGLocatable::getScreenCTM): (WebCore::SVGLocatable::getTransformToElement):
- svg/SVGLocatable.h:
- svg/SVGMarkerElement.cpp: (WebCore::SVGMarkerElement::viewBoxToViewTransform):
- svg/SVGMarkerElement.h:
- svg/SVGMaskElement.cpp: (WebCore::SVGMaskElement::drawMaskerContent):
- svg/SVGMatrix.idl:
- svg/SVGPatternElement.cpp: (WebCore::SVGPatternElement::buildPattern):
- svg/SVGPreserveAspectRatio.cpp: (WebCore::SVGPreserveAspectRatio::getCTM):
- svg/SVGPreserveAspectRatio.h:
- svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::viewport): (WebCore::SVGSVGElement::createSVGMatrix): (WebCore::SVGSVGElement::createSVGTransformFromMatrix): (WebCore::SVGSVGElement::getCTM): (WebCore::SVGSVGElement::getScreenCTM): (WebCore::SVGSVGElement::viewBoxToViewTransform):
- svg/SVGSVGElement.h:
- svg/SVGStyledLocatableElement.cpp: (WebCore::SVGStyledLocatableElement::getCTM): (WebCore::SVGStyledLocatableElement::getScreenCTM):
- svg/SVGStyledLocatableElement.h:
- svg/SVGStyledTransformableElement.cpp: (WebCore::SVGStyledTransformableElement::getCTM): (WebCore::SVGStyledTransformableElement::getScreenCTM): (WebCore::SVGStyledTransformableElement::animatedLocalTransform): (WebCore::SVGStyledTransformableElement::supplementalTransform):
- svg/SVGStyledTransformableElement.h: (WebCore::SVGStyledTransformableElement::isStyledTransformable): (WebCore::SVGStyledTransformableElement::toPathData):
- svg/SVGTextContentElement.cpp: (WebCore::SVGInlineTextBoxQueryWalker::chunkPortionCallback):
- svg/SVGTextElement.cpp: (WebCore::SVGTextElement::getScreenCTM): (WebCore::SVGTextElement::getCTM): (WebCore::SVGTextElement::animatedLocalTransform): (WebCore::SVGTextElement::supplementalTransform):
- svg/SVGTextElement.h:
- svg/SVGTextPathElement.cpp:
- svg/SVGTransform.cpp: (SVGTransform::SVGTransform): (SVGTransform::matrix): (SVGTransform::setMatrix):
- svg/SVGTransform.h:
- svg/SVGTransformDistance.cpp: (WebCore::SVGTransformDistance::SVGTransformDistance): (WebCore::SVGTransformDistance::scaledDistance): (WebCore::SVGTransformDistance::isZero):
- svg/SVGTransformDistance.h:
- svg/SVGTransformList.cpp: (SVGTransformList::createSVGTransformFromMatrix): (SVGTransformList::concatenate): (SVGTransformList::valueAsString):
- svg/SVGTransformList.h:
- svg/SVGTransformable.cpp: (WebCore::SVGTransformable::getCTM): (WebCore::SVGTransformable::getScreenCTM): (WebCore::SVGTransformable::parseTransformValue):
- svg/SVGTransformable.h: (WebCore::SVGTransformable::):
- svg/graphics/SVGPaintServerGradient.cpp: (WebCore::SVGPaintServerGradient::gradientTransform): (WebCore::SVGPaintServerGradient::setGradientTransform): (WebCore::clipToTextMask): (WebCore::SVGPaintServerGradient::setup):
- svg/graphics/SVGPaintServerGradient.h:
- svg/graphics/SVGPaintServerPattern.cpp: (WebCore::SVGPaintServerPattern::patternTransform): (WebCore::SVGPaintServerPattern::setPatternTransform): (WebCore::SVGPaintServerPattern::setup):
- svg/graphics/SVGPaintServerPattern.h:
- svg/graphics/SVGResourceClipper.cpp: (WebCore::SVGResourceClipper::applyClip):
- svg/graphics/SVGResourceMarker.cpp: (WebCore::SVGResourceMarker::markerTransformation): (WebCore::SVGResourceMarker::draw):
- svg/graphics/SVGResourceMarker.h:
- svg/graphics/filters/SVGFEImage.cpp:
- svg/graphics/filters/SVGFETile.cpp: (WebCore::FETile::apply):
2010-02-08 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
Add back an AffineTransform class for use by SVG
https://bugs.webkit.org/show_bug.cgi?id=33750
Some negative zero problems fixed, but new one were added on other places. A seperate
patch should fix it all at once.
use-on-disallowed-foreign-object-3 and 4 had wrong results. The old SVG code
with TransformationMatrix used translateRight, that was wrong at this place and is
fixed now.
- platform/mac/svg/W3C-SVG-1.1/animate-elem-80-t-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/fonts-elem-01-t-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/fonts-elem-02-t-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/fonts-elem-03-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/fonts-elem-04-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/fonts-elem-07-b-expected.txt:
- platform/mac/svg/custom/use-on-disallowed-foreign-object-3-expected.txt:
- platform/mac/svg/custom/use-on-disallowed-foreign-object-4-expected.txt:
- svg/dom/SVGMatrix-interface-expected.txt:
- svg/dom/SVGMatrix-interface.xhtml:
2010-02-08 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
Add back an AffineTransform class for use by SVG
https://bugs.webkit.org/show_bug.cgi?id=33750
Use AffineTransform instead of TransformationMatrix here.
- tests/TransparencyWinTest.cpp: (WebCore::TEST):
- 12:25 PM Changeset in webkit [54502] by
-
- 3 edits in trunk/WebCore
2010-02-08 Stephen White <senorblanco@chromium.org>
Reviewed by Dimitri Glazkov.
Make an inline function containing a static var out-of-line. This is
a workaround for Xcode 3.1 bug radar 7070016. We tripped on this in
deviceRGBColorSpaceRef on the Chromium canaries. This is a proactive
fix for the same problem in sRGBColorSpaceRef().
- platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::sRGBColorSpaceRef):
- platform/graphics/cg/GraphicsContextPlatformPrivateCG.h:
- 11:42 AM Changeset in webkit [54501] by
-
- 2 edits in trunk/WebKitTools
[Qt] Make overridePreference complain when it does not
support the preference given.
Reviewed by Tor Arne Vestbø.
- DumpRenderTree/qt/LayoutTestControllerQt.cpp:
(LayoutTestController::overridePreference):
- 11:40 AM Changeset in webkit [54500] by
-
- 1 copy in releases/WebKitGTK/webkit-1.1.21
Tagging 1.1.21.
- 11:32 AM Changeset in webkit [54499] by
-
- 8 edits in trunk/WebCore
2010-02-08 Nate Chapin <Nate Chapin>
Reviewed by Dimitri Glazkov.
[V8] Unify the WorkerContext V8 object wrapping code with
the standard V8 object wrapping code.
- bindings/scripts/CodeGeneratorV8.pm:
- bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::instantiateV8Object): (WebCore::V8DOMWrapper::convertEventTargetToV8Object):
- bindings/v8/V8WorkerContextEventListener.cpp: (WebCore::V8WorkerContextEventListener::handleEvent): (WebCore::V8WorkerContextEventListener::getReceiverObject):
- bindings/v8/WorkerContextExecutionProxy.cpp:
- bindings/v8/WorkerContextExecutionProxy.h:
- bindings/v8/custom/V8NotificationCenterCustom.cpp: (WebCore::V8NotificationCenter::createHTMLNotificationCallback): (WebCore::V8NotificationCenter::createNotificationCallback):
- bindings/v8/custom/V8WorkerContextCustom.cpp: (WebCore::toV8):
- 11:18 AM Changeset in webkit [54498] by
-
- 4 edits in trunk
2010-02-08 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Xan Lopez.
Bump version to 1.1.21, and adjust library versioning accordingly.
- configure.ac:
- 10:54 AM Changeset in webkit [54497] by
-
- 1 edit in trunk/JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def
Build fix, add needed export
- 10:30 AM Changeset in webkit [54496] by
-
- 2 edits in trunk/WebKitTools
[Qt] Set stdout/stderr to binary mode for DRT on Windows
Reviewed by Kenneth Rohde Christiansen.
This makes sure we don't end up with lots of CRLFs in the
DRT output, which breaks tons of results. Matches what
the Windows DRT does.
- DumpRenderTree/qt/main.cpp:
- 10:21 AM Changeset in webkit [54495] by
-
- 8 edits in trunk/WebCore
2010-02-08 Kwang Yul Seo <skyul@company100.net>
Reviewed by Darin Adler.
Use fastStrDup instead of strdup
https://bugs.webkit.org/show_bug.cgi?id=33943
Replace strdup/free with fastStrDup/fastFree.
- bridge/IdentifierRep.h: (WebCore::IdentifierRep::IdentifierRep):
- bridge/jni/JNIBridge.cpp: (JavaMethod::~JavaMethod): (appendClassName): (JavaMethod::signature):
- bridge/jni/jsc/JavaClassJSC.cpp: (JavaClass::JavaClass): (JavaClass::~JavaClass):
- platform/network/curl/ResourceHandleCurl.cpp: (WebCore::ResourceHandleInternal::~ResourceHandleInternal):
- platform/network/curl/ResourceHandleManager.cpp: (WebCore::ResourceHandleManager::~ResourceHandleManager): (WebCore::ResourceHandleManager::setCookieJarFileName): (WebCore::ResourceHandleManager::initializeHandle):
- plugins/PluginStream.cpp: (WebCore::PluginStream::~PluginStream): (WebCore::PluginStream::startStream):
- xml/XSLTProcessorLibxslt.cpp: (WebCore::xsltParamArrayFromParameterMap): (WebCore::freeXsltParamArray):
- 10:20 AM Changeset in webkit [54494] by
-
- 2 edits in trunk/WebKit/win
Include header position in World Transform used for plugin positioning.
https://bugs.webkit.org/show_bug.cgi?id=34709
Reviewed by Adam Roben.
- WebFrame.cpp:
(WebFrame::spoolPage): Correct WinCairo plugin print positioning to
account for header size. Existing code ignored this, causing
plugins to overlay other elements.
- 9:37 AM Changeset in webkit [54493] by
-
- 3 edits in trunk/WebKitTools
Build fix for Qt on Windows.
Reviewed by Kenneth Rohde Christiansen.
Don't use noreturn directly since it's a gcc attribute.
Instead use the NO_RETURN macro from AlwaysInline.h
- QtLauncher/QtLauncher.pro:
- QtLauncher/utils.h:
- 9:33 AM Changeset in webkit [54492] by
-
- 2 edits in trunk/LayoutTests
2010-02-08 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed. Fix last problematic SVG testcase, update coords-trans-01-b.svg win results, marking the end of the baseline regeneration for all platforms.
- platform/win/svg/W3C-SVG-1.1/coords-trans-01-b-expected.txt:
- 8:09 AM Changeset in webkit [54491] by
-
- 4 edits in trunk/LayoutTests
2010-02-08 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed. Should turn Qt slave green again, all platform specific results updated.
- platform/qt/svg/filters/subRegion-one-effect-expected.txt:
- platform/qt/svg/filters/subRegion-two-effects-expected.txt:
- platform/qt/svg/text/selection-background-color-expected.txt:
- 8:06 AM Changeset in webkit [54490] by
-
- 2 edits1 move in trunk/WebCore
Fix Qt build on Windows.
Reviewed by Simon Hausmann.
nmake fails to pick the right cpp file, so we have to
rename the file to to a unique name.
- WebCore.pro:
- platform/graphics/qt/FontCustomPlatformDataQt.cpp: Renamed from WebCore/platform/graphics/qt/FontCustomPlatformData.cpp.
- 8:01 AM Changeset in webkit [54489] by
-
- 17 edits in trunk/LayoutTests
2010-02-08 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed. Hopefully the last set of updates for Gtk/Qt/Win/Mac.
- platform/gtk/svg/custom/text-zoom-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/animate-elem-82-t-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/coords-trans-01-b-expected.txt:
- platform/qt/svg/filters/feComposite-expected.txt:
- platform/qt/svg/filters/feGaussianBlur-expected.txt:
- platform/qt/svg/filters/feMerge-expected.txt:
- platform/qt/svg/filters/feMerge-wrong-input-expected.txt:
- platform/qt/svg/filters/feOffset-expected.txt:
- platform/qt/svg/filters/feTile-expected.txt:
- platform/qt/svg/filters/filter-source-position-expected.txt:
- platform/qt/svg/filters/shadow-on-filter-expected.txt:
- platform/qt/svg/filters/shadow-on-rect-with-filter-expected.txt:
- platform/qt/svg/filters/sourceAlpha-expected.txt:
- platform/qt/svg/filters/subRegion-in-userSpace-expected.txt:
- platform/win/svg/custom/inline-svg-in-xhtml-expected.txt:
- platform/win/svg/hixie/mixed/003-expected.txt:
- 7:57 AM Changeset in webkit [54488] by
-
- 3 edits in trunk/WebKitTools
Notify user that run-webkit-tests has to be run under Cygwin
Reviewed by Simon Hausmann.
The script will bail out if run under Windows shell or Msys.
- Scripts/run-webkit-tests:
- Scripts/webkitdirs.pm:
- 7:39 AM Changeset in webkit [54487] by
-
- 6 edits in trunk/LayoutTests
2010-02-08 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed. Attempt to fix all mac/win bots (expect for leopard which already passes)
- platform/mac/svg/W3C-SVG-1.1/text-intro-05-t-expected.txt:
- platform/mac/svg/custom/junk-data-expected.txt:
- platform/mac/svg/custom/missing-xlink-expected.txt:
- platform/mac/svg/hixie/error/012-expected.txt:
- platform/mac/svg/text/text-intro-05-t-expected.txt:
- 7:09 AM Changeset in webkit [54486] by
-
- 13 edits in trunk/LayoutTests
2010-02-08 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed. Next set of Qt DRT result updates.
- platform/qt/svg/custom/js-update-image-and-display-expected.txt:
- platform/qt/svg/custom/js-update-image-and-display3-expected.txt:
- platform/qt/svg/custom/marker-opacity-expected.txt:
- platform/qt/svg/custom/marker-referencePoint-expected.txt:
- platform/qt/svg/custom/marker-strokeWidth-changes-expected.txt:
- platform/qt/svg/custom/mask-with-default-value-expected.txt:
- platform/qt/svg/custom/relative-sized-deep-shadow-tree-content-expected.txt:
- platform/qt/svg/custom/relative-sized-shadow-tree-content-expected.txt:
- platform/qt/svg/custom/relative-sized-use-on-symbol-expected.txt:
- platform/qt/svg/custom/text-xy-updates-SVGList-expected.txt:
- platform/qt/svg/custom/transformedMaskFails-expected.txt:
- platform/qt/svg/custom/use-on-symbol-inside-pattern-expected.txt:
- 7:04 AM Changeset in webkit [54485] by
-
- 6 edits in trunk/LayoutTests
2010-02-08 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed. Update mac-tiger specific SVG results.
- platform/mac-tiger/svg/W3C-SVG-1.1/metadata-example-01-b-expected.txt:
- platform/mac-tiger/svg/hixie/text/003-expected.txt:
- platform/mac-tiger/svg/hixie/text/003a-expected.txt:
- platform/mac-tiger/svg/hixie/viewbox/preserveAspectRatio/001-expected.txt:
- platform/mac-tiger/svg/hixie/viewbox/preserveAspectRatio/002-expected.txt:
- 6:59 AM Changeset in webkit [54484] by
-
- 11 edits4 adds in trunk/LayoutTests
2010-02-08 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed. Fixing first set of platform specific SVG results for the Qt port.
Unfortunately the bots exit after 20 test failures, so I can't fix the whole set of expected txt files in one go :(
- platform/qt/svg/css/arrow-with-shadow-expected.txt:
- platform/qt/svg/css/circle-in-mask-with-shadow-expected.txt:
- platform/qt/svg/css/clippath-with-shadow-expected.txt:
- platform/qt/svg/css/mask-with-shadow-expected.txt:
- platform/qt/svg/css/path-with-shadow-expected.txt:
- platform/qt/svg/css/shadow-and-opacity-expected.txt: Added.
- platform/qt/svg/css/shadow-with-large-radius-expected.txt: Added.
- platform/qt/svg/css/shadow-with-negative-offset-expected.txt: Added.
- platform/qt/svg/css/stars-with-shadow-expected.txt:
- platform/qt/svg/custom/createImageElement-expected.txt:
- platform/qt/svg/custom/createImageElement2-expected.txt:
- platform/qt/svg/custom/empty-mask-expected.txt:
- platform/qt/svg/custom/js-repaint-rect-on-path-with-stroke-expected.txt: Added.
- platform/qt/svg/custom/js-update-image-and-display2-expected.txt:
- 6:26 AM Changeset in webkit [54483] by
-
- 747 edits in trunk
2010-02-08 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Dirk Schulze.
All SVG *-expected.txt files contain wrong results
https://bugs.webkit.org/show_bug.cgi?id=34703
Finally dump meaningful information for SVG layout tests.
Use 'absoluteClippedOverflowRect' which goes through the same code paths used
to actually calculate repaint rects etc - instead of the legacy CSS-unaware
code path that mapped 'repaintRectInLocalCoordinates' through 'absoluteTransform'.
Remove absoluteTransform() - a long standing TODO, finally not needed anymore.
Despite SVGRenderTreeAsText, SVGPaintServerGradient was also using absoluteTransform().
Rewrite the code in question, fixing svg/W3C-SVG-1.1/pserver-grad-08-b.svg alignment issues
when scaling/panning text using gradient on stroke/fill. Affects some other gradient tests as well.
As we're now dumping clipped overflow rects any problems with repaint rects will become
immediate visible - it turns out we're not supporting the overflow rules on the outermost <svg>
element properly (repaint rects and bounding boxes need to take special SVG overflow rules into account).
Fixing that magically gives pixel-perfect clipped overflow rects for all types of shapes/text/containers.
Note: This will break any overriden platform-specific SVG results, need to wait for build bots in order to update them.
- rendering/RenderObject.cpp: Remove absoluteTransform() method, centralize overflow query code in SVGRenderSupport::isOverflowHidden().
- rendering/RenderObject.h: Remove absoluteTransform() method.
- rendering/RenderSVGHiddenContainer.h: Ditto.
- rendering/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::paint): Use SVGRenderSupport::isOverflowHidden() to query SVG overflow mode. (WebCore::RenderSVGRoot::computeRectForRepaint): Respect SVG overflow rules here: clip repaintRect against overflow rect _before_ passing
along to RenderBox. This is the key issue behind wrong absoluteClippedOverflowRect() values.
(WebCore::RenderSVGRoot::nodeAtPoint): Use SVGRenderSupport::isOverflowHidden() to query SVG overflow mode.
- rendering/RenderSVGRoot.h: Remove absoluteTransform(). Don't expose viewportSize() anymore.
- rendering/RenderSVGText.cpp: (WebCore::RenderSVGText::strokeBoundingBox): Fix default stroke width to 1. This was the only wrong place -> fixes repaint rects for stroked text.
- rendering/RenderSVGViewportContainer.cpp: Remove absoluteTransform() method. (WebCore::RenderSVGViewportContainer::pointIsInsideViewportClip): Use SVGRenderSupport::isOverflowHidden() to query SVG overflow mode.
- rendering/RenderSVGViewportContainer.h: Remove absoluteTransform() method.
- rendering/SVGRenderSupport.cpp: Refactored overflow queries in one place, centralizing SVG specific assumptions about overflowX/Y. (WebCore::SVGRenderBase::isOverflowHidden):
- rendering/SVGRenderSupport.h:
- rendering/SVGRenderTreeAsText.cpp: Dump absoluteClippedOverflowRect() instead of absoluteTransform().mapRect(repaintRectInLocalCoordinates()). (WebCore::writePositionAndStyle): Affects all layout tests dumping render trees.
- svg/graphics/SVGPaintServerGradient.cpp: Rewrite Gradient on text fill/stroke support on Cg, to avoid using absoluteTransform(). (WebCore::absoluteTransformForRenderer): (WebCore::createMaskAndSwapContextForTextGradient): (WebCore::clipToTextMask): (WebCore::SVGPaintServerGradient::setup):
- 5:26 AM Changeset in webkit [54482] by
-
- 7 edits in trunk/WebKitTools
Suppressed check-webkit-style's underscore check in Qt's autotests.
Also made the path-specific filter check case-insensitive.
Reviewed by Shinichiro Hamaji.
https://bugs.webkit.org/show_bug.cgi?id=34574
- Scripts/webkitpy/style/checker.py:
- Added a list element to _PATH_RULES_SPECIFIER for directories that should be excluded from the "readability/naming" category (the category that relates to underscores in identifiers, for example).
- Scripts/webkitpy/style/checker_unittest.py:
- Added an "end-to-end" test for "WebKit/qt/tests/".
- Scripts/webkitpy/style/filter.py:
- Altered FilterConfiguration's should_check() method to check for path substring matches case-insensitively.
- Scripts/webkitpy/style/filter_unittest.py:
- Added a test to check case-insensitive path substring matching.
- Scripts/webkitpy/style/processors/cpp.py:
- Removed the hard-coded "WebKit/gtk/webkit/" path reference since this is now taken care of by the _PATH_RULES_SPECIFIER configuration variable.
- Scripts/webkitpy/style/processors/cpp_unittest.py:
- Removed the unit test for the GTK directory since this is now taken care of by the checker._PATH_RULES_SPECIFIER end-to-end tests.
- 5:21 AM Changeset in webkit [54481] by
-
- 2 edits in trunk/JavaScriptCore
Build fix for make distcheck.
- 5:06 AM Changeset in webkit [54480] by
-
- 2 edits in trunk/LayoutTests
2010-02-08 Xan Lopez <xlopez@igalia.com>
Try to do some clean-up in our Skipped list.
- platform/gtk/Skipped:
- 4:47 AM Changeset in webkit [54479] by
-
- 2 edits in trunk/LayoutTests
2010-02-08 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
Generate new results for this test.
- platform/gtk/editing/execCommand/indent-paragraphs-expected.txt:
- 3:04 AM Changeset in webkit [54478] by
-
- 2 edits1 add1 delete in trunk/LayoutTests
2010-02-08 Tony Chang <tony@chromium.org>
Reviewed by Darin Adler.
Convert editing/execCommand/indent-paragraphs.html to use dumpAsText.
The test copies HTML to the text output, so it doesn't really need
to dump the render tree.
The test was added in r49985, but didn't include pixel results.
https://bugs.webkit.org/show_bug.cgi?id=34625
- platform/mac/editing/execCommand/indent-paragraphs-expected.txt: Modified.
- 2:48 AM Changeset in webkit [54477] by
-
- 2 edits in trunk/WebKitTools
2010-02-08 Leith Bade <leith@leithalweapon.geek.nz>
Reviewed by Darin Adler.
Fixes: https://bugs.webkit.org/show_bug.cgi?id=34637
Corrects the newline inserted into WebKitOutputDir, and WebKitLibrariesDir Windows
environemnt variables when there is a space in the user's /home path.
- Scripts/webkitdirs.pm:
- Added missing quotes around $sourceDir in argument list of cygpath in determineWindowsSourceDir().
- 1:33 AM Changeset in webkit [54476] by
-
- 2 edits in trunk/JavaScriptCore
Unreviewed RVCT build fix.
Similar to r54391, don't import the cmath functions from std:: for RVCT.
- wtf/MathExtras.h:
Feb 7, 2010:
- 4:42 PM Changeset in webkit [54475] by
-
- 5 edits in trunk/LayoutTests
2010-02-07 Tony Chang <tony@chromium.org>
Reviewed by Darin Adler.
Fix 2 pixel test baselines that are incorrect but passing
the fuzzy image diff.
editing/deleting/5390681.html should show a cursor, but doesn't.
In r42549, whitespace collapsing was changed but
editing/pasteboard/5387578.html's result wasn't updated to
reflect the collapsed whitespace.
https://bugs.webkit.org/show_bug.cgi?id=34632
- platform/mac/editing/deleting/5390681-2-expected.checksum:
- platform/mac/editing/deleting/5390681-2-expected.png:
- platform/mac/editing/pasteboard/5387578-expected.checksum:
- platform/mac/editing/pasteboard/5387578-expected.png:
- 2:26 PM Changeset in webkit [54474] by
-
- 1 edit1 add in trunk/LayoutTests
2010-02-07 Daniel Bates <dbates@webkit.org>
Unreviewed, fix Tiger layout test failure.
Adds expected layout test results for Tiger build.
- platform/mac-tiger/fast/lists/w3-css3-list-styles-numeric-expected.txt: Added.
- 1:43 PM Changeset in webkit [54473] by
-
- 1 edit4 adds in trunk/LayoutTests
2010-02-07 Daniel Bates <dbates@webkit.org>
Unreviewed, fix layout test bots.
Adds expected layout test results for Leopard, Windows, and Qt ports.
- platform/mac-leopard/fast/lists: Added.
- platform/mac-leopard/fast/lists/w3-css3-list-styles-numeric-expected.txt: Added.
- platform/qt/fast/lists/w3-css3-list-styles-numeric-expected.txt: Added.
- platform/win/fast/lists/w3-css3-list-styles-numeric-expected.txt: Added.
- 1:08 PM Changeset in webkit [54472] by
-
- 9 edits2 adds in trunk
2010-02-07 Daniel Bates <dbates@webkit.org>
Reviewed by Darin Adler.
Implements all of the numeric CSS3 list-style-types as per
section 4.3 of the CSS3 Lists module <http://www.w3.org/TR/css3-lists/#numeric>.
Test: fast/lists/w3-css3-list-styles-numeric.html
- css/CSSPrimitiveValueMappings.h: (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
- css/CSSValueKeywords.in:
- inspector/front-end/SourceCSSTokenizer.re2js:
- platform/text/CharacterNames.h: Added constant hyphenMinus.
- rendering/RenderListMarker.cpp: (WebCore::): Defined enum SequenceType. (WebCore::toAlphabeticOrNumeric): Added. (WebCore::toAlphabetic): Modified to call WebCore::toAlphabeticOrNumeric. (WebCore::toNumeric): Added. (WebCore::listMarkerSuffix): (WebCore::listMarkerText): (WebCore::RenderListMarker::paint): (WebCore::RenderListMarker::calcPrefWidths): (WebCore::RenderListMarker::getRelativeMarkerRect):
- rendering/style/RenderStyle.h: (WebCore::):
- rendering/style/RenderStyleConstants.h: Added numeric list style types and fixed indent level for the enum values. (WebCore::):
2010-02-07 Daniel Bates <dbates@webkit.org>
Reviewed by Darin Adler.
Tests that all of the numeric CSS3 list-style-types are supported.
- fast/lists/w3-css3-list-styles-numeric.html: Added.
- platform/mac/fast/lists/w3-css3-list-styles-numeric-expected.txt: Added.
- 12:47 PM Changeset in webkit [54471] by
-
- 2 edits in trunk/WebCore
2010-02-07 Ismail Donmez <ismail@namtrac.org>
Reviewed by Darin Adler.
Include wtf/StringExtras.h for strdup definition, which
is needed for WinCE.
- bridge/IdentifierRep.h:
- 4:52 AM Changeset in webkit [54470] by
-
- 6 edits in trunk
2010-02-07 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: Fragment-held Elements Not Shown in Inspector.
- inspector/console-dirxml-expected.txt:
- inspector/console-dirxml.html:
2010-02-07 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: Fragment-held Elements Not Shown in Inspector.
- inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::pushChildNodesToFrontend): (WebCore::InspectorDOMAgent::buildObjectForNode):
- inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeElement.prototype._nodeTitleInfo):
- 4:35 AM Changeset in webkit [54469] by
-
- 7 edits in trunk
2010-02-07 Jian Li <jianli@chromium.org>
Reviewed by Darin Fisher.
[chromium] Change chromium interface to handle DownloadURL format.
https://bugs.webkit.org/show_bug.cgi?id=34655
- platform/chromium/ChromiumDataObject.cpp: (WebCore::ChromiumDataObject::clear): (WebCore::ChromiumDataObject::hasData): (WebCore::ChromiumDataObject::ChromiumDataObject):
- platform/chromium/ChromiumDataObject.h:
- platform/chromium/ClipboardChromium.cpp: (WebCore::ClipboardChromium::setData):
2010-02-07 Jian Li <jianli@chromium.org>
Reviewed by Darin Fisher.
[chromium] Change chromium interface to handle DownloadURL format.
https://bugs.webkit.org/show_bug.cgi?id=34655
- public/WebDragData.h:
- src/WebDragData.cpp: (WebKit::WebDragData::downloadMetadata): (WebKit::WebDragData::setDownloadMetadata):
- 3:42 AM Changeset in webkit [54468] by
-
- 2 edits2 adds in trunk/LayoutTests
Rubber-stamped by Kenneth Rohde Christiansen.
[Qt] Missing fast/frames/flattening/resources/frameset-flattening-subframe-resize.html
https://bugs.webkit.org/show_bug.cgi?id=34662
Missing file added from the original bug: https://bugs.webkit.org/show_bug.cgi?id=32717
- fast/frames/flattening/resources: Added.
- fast/frames/flattening/resources/frameset-flattening-subframe-resize.html: Added.
- platform/qt/Skipped: frameset-flattening-subframe-resize.html unskipped.
- 3:28 AM Changeset in webkit [54467] by
-
- 211 moves in tags/old
Move aside some old tags.
Feb 6, 2010:
- 12:18 PM Changeset in webkit [54466] by
-
- 7 edits in trunk
2010-02-06 Dimitri Glazkov <Dimitri Glazkov>
No review, rolling out r54364.
http://trac.webkit.org/changeset/54364
https://bugs.webkit.org/show_bug.cgi?id=34464
Introduced asserts in layout tests, needs more testing
locally.
- accessibility/chromium/AXObjectCacheChromium.cpp: (WebCore::AXObjectCache::postPlatformNotification):
- page/chromium/ChromeClientChromium.h:
2010-02-06 Dimitri Glazkov <Dimitri Glazkov>
No review, rolling out r54364.
http://trac.webkit.org/changeset/54364
https://bugs.webkit.org/show_bug.cgi?id=34464
Introduced asserts in layout tests, needs more testing
locally.
- public/WebViewClient.h:
- src/ChromeClientImpl.cpp:
- src/ChromeClientImpl.h:
- 11:02 AM Changeset in webkit [54465] by
-
- 3 edits in trunk/WebCore
2010-02-06 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Adam Barth.
Using inlines and function-level statics don't mix, according to gcc.
https://bugs.webkit.org/show_bug.cgi?id=34663
De-inline deviceRGBColorSpaceRef to avoid gcc-bug landmines.
It appears that the initialization check, generated by gcc doesn't account
for a possibility that the function may be inlined, resulting in lazy
initialization failure for more than one inlined instance of the function.
No behavior change, so no new tests.
- platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::deviceRGBColorSpaceRef):
- platform/graphics/cg/GraphicsContextPlatformPrivateCG.h:
- 12:55 AM Changeset in webkit [54464] by
-
- 15 edits in trunk/JavaScriptCore
Change UStringImpl::create to CRASH if the string cannot be allocated,
rather than returning a null string (which will behave like a zero-length
string if used).
Reviewed by Geoff Garen.
Also move createRep function from UString to become new overloaded
UStringImpl::create methods. In doing so, bring their behaviour closer to
being in line with WebCore::StringImpl, in removing the behaviour that they
can be used to produce null UStrings (ASSERT the char* provided is non-null).
This behaviour of converting null C-strings to null UStrings is inefficient
(cmompared to just using UString::null()), incompatible with WebCore::StringImpl's
behaviour, and may generate unexpected behaviour, since in many cases a null
UString can be used like an empty string.
With these changes UStringImpl need not have a concept of null impls, we can
start transitioning this to become an implementation detail of UString, that
internally it chooses to use a null-object rather than an actually zero impl
pointer.
- JavaScriptCore.exp:
- debugger/Debugger.cpp:
(JSC::Debugger::recompileAllJSFunctions):
- debugger/DebuggerCallFrame.cpp:
(JSC::DebuggerCallFrame::calculatedFunctionName):
- parser/Parser.cpp:
(JSC::Parser::parse):
- profiler/Profile.cpp:
(JSC::Profile::Profile):
- profiler/ProfileGenerator.cpp:
(JSC::ProfileGenerator::stopProfiling):
- runtime/Error.cpp:
(JSC::Error::create):
(JSC::throwError):
- runtime/ExceptionHelpers.cpp:
(JSC::createError):
- runtime/Identifier.cpp:
(JSC::Identifier::add):
- runtime/PropertyNameArray.cpp:
(JSC::PropertyNameArray::add):
- runtime/UString.cpp:
(JSC::initializeUString):
(JSC::UString::UString):
(JSC::UString::operator=):
- runtime/UString.h:
(JSC::UString::isNull):
(JSC::UString::null):
(JSC::UString::rep):
(JSC::UString::UString):
- runtime/UStringImpl.cpp:
(JSC::UStringImpl::create):
- runtime/UStringImpl.h:
Feb 5, 2010:
- 10:32 PM Changeset in webkit [54463] by
-
- 2 edits in trunk/WebKitTools
Reviewed by Oliver Hunt.
https://bugs.webkit.org/show_bug.cgi?id=34670
TestNetscapePlugin should work with Firefox
- DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp: (NPP_New): Default to Carbon if browser doesn't tell what it supports.
- 10:17 PM Changeset in webkit [54462] by
-
- 10 edits in branches/safari-532-branch
JavaScriptCore: <rdar://problem/7485972> Disable SVG filters on branch
<rdar://problem/7555331> Disable WebGL on branch
Reviewed by Mark Rowe.
- Configurations/FeatureDefines.xcconfig:
WebCore: <rdar://problem/7485972> Disable SVG filters on branch
<rdar://problem/7555331> Disable WebGL on branch
Reviewed by Mark Rowe.
- Configurations/FeatureDefines.xcconfig:
WebKit/mac: <rdar://problem/7485972> Disable SVG filters on branch
<rdar://problem/7555331> Disable WebGL on branch
Reviewed by Mark Rowe.
- Configurations/FeatureDefines.xcconfig:
WebKitLibraries: <rdar://problem/7485972> Disable SVG filters on branch
<rdar://problem/7555331> Disable WebGL on branch
Reviewed by Mark Rowe.
- win/tools/vsprops/FeatureDefines.vsprops:
WebKitTools: <rdar://problem/7485972> Disable SVG filters on branch
<rdar://problem/7555331> Disable WebGL on branch
Reviewed by Mark Rowe.
- Scripts/build-webkit:
- 9:37 PM Changeset in webkit [54461] by
-
- 7 edits in trunk
2010-02-05 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Gustavo Noronha Silva.
[Gtk] Implement layoutTestController.pageNumberForElementById
https://bugs.webkit.org/show_bug.cgi?id=34572
- platform/gtk/Skipped:
2010-02-05 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Gustavo Noronha Silva.
[Gtk] Implement layoutTestController.pageNumberForElementById
https://bugs.webkit.org/show_bug.cgi?id=34572
- webkit/webkitprivate.h:
- webkit/webkitwebframe.cpp: (webkit_web_frame_page_number_for_element_by_id):
2010-02-05 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Gustavo Noronha Silva.
[Gtk] Implement layoutTestController.pageNumberForElementById
https://bugs.webkit.org/show_bug.cgi?id=34572
- DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::pageNumberForElementById):
- 8:25 PM Changeset in webkit [54460] by
-
- 3 edits in trunk/WebCore
Added an ASSERT to catch an implausible but theoretically possible leak.
Reviewed by Dan Bernstein.
In theory, if malloc allocated a UChar buffer directly after a StringImpl,
the StringImpl might incorrecly assume that the UChar buffer was inline,
and fail to delete it.
This ASSERT is somewhat academic, since we don't use the same allocator
in debug builds, but oh well.
- platform/text/StringImpl.cpp:
(WebCore::StringImpl::StringImpl):
(WebCore::StringImpl::createUninitialized):
- platform/text/StringImpl.h: Separated the inline buffer StringImpl
constructor from the out-of-line buffer StringImpl constructor. Made
the former ASSERT that its buffer was indeed inline, and the latter ASSERT
that its buffer was indeed not inline.
- 6:50 PM Changeset in webkit [54459] by
-
- 1 edit1 delete in trunk/LayoutTests
Removed these special Windows expected results because they represented
incorrect behavior, fixed by a recent patch of mine.
Reviewed by Beth Dakin.
- platform/win/fast/events/mouse-drag-from-frame-to-other-frame-expected.txt: Removed.
- 6:44 PM Changeset in webkit [54458] by
-
- 6 edits in trunk/WebKit/chromium
2010-02-05 James Hawkins <jhawkins@chromium.org>
Reviewed by David Levin.
[Chromium] Rename autocomplete* to suggestions* to prepare for the
refactoring of AutocompletePopupMenuClient.
- public/WebView.h:
- src/AutocompletePopupMenuClient.cpp: (WebKit::AutocompletePopupMenuClient::popupDidHide):
- src/EditorClientImpl.cpp: (WebKit::EditorClientImpl::textFieldDidEndEditing): (WebKit::EditorClientImpl::doAutofill):
- src/WebViewImpl.cpp: (WebKit::): (WebKit::WebViewImpl::WebViewImpl): (WebKit::WebViewImpl::mouseDown): (WebKit::WebViewImpl::autocompleteHandleKeyEvent): (WebKit::WebViewImpl::setFocus): (WebKit::WebViewImpl::applyAutofillSuggestions): (WebKit::WebViewImpl::hideAutofillPopup): (WebKit::WebViewImpl::hideSuggestionsPopup): (WebKit::WebViewImpl::refreshSuggestionsPopup):
- src/WebViewImpl.h: (WebKit::WebViewImpl::suggestionsPopupDidHide):
- 6:28 PM Changeset in webkit [54457] by
-
- 2 edits in trunk/JavaScriptCore
2010-02-05 Kwang Yul Seo <skyul@company100.net>
Reviewed by Eric Seidel.
[BREWMP] Define SYSTEM_MALLOC 1
https://bugs.webkit.org/show_bug.cgi?id=34640
Make BREWMP use system malloc because FastMalloc is not ported.
- wtf/Platform.h:
- 5:30 PM Changeset in webkit [54456] by
-
- 3 edits in trunk/LayoutTests
2010-02-05 Eric Carlson <eric.carlson@apple.com>
Unreviewed revert of r54454, until I can generate new results
- media/video-loop-expected.txt:
- media/video-loop.html:
- 5:10 PM Changeset in webkit [54455] by
-
- 4 edits in trunk/WebCore
Fixed changed virtual function in GraphicsLayerCACF and call order issues
https://bugs.webkit.org/show_bug.cgi?id=34348
The correct virtual function in GraphicsLayerCACF is now being
called. We also fixed an issue in QTMovieWin where the size
of the movie was not being set correctly because the call order
was changed.
I also changed the order of a couple of calls in QTMovieWin to account
for changed calling order from the logic above.
- 4:49 PM Changeset in webkit [54454] by
-
- 3 edits in trunk/LayoutTests
2010-02-05 Eric Carlson <eric.carlson@apple.com>
Reviewed by Oliver Hunt.
https://bugs.webkit.org/show_bug.cgi?id=33671
[GTK] media/video-loop.html fails intermittently on Gtk Bots
Rewrite test to make it less timing dependent.
- media/video-loop-expected.txt:
- media/video-loop.html:
- 4:41 PM Changeset in webkit [54453] by
-
- 1 move in branches/old/WWDC-2009-branch
Move aside another old branch.
- 4:41 PM Changeset in webkit [54452] by
-
- 2 edits3 adds in trunk/WebKitTools
2010-02-03 Dirk Pranke <dpranke@chromium.org>
Reviewed by Eric Seidel.
Add a simple test implementation and the WebKit Mac implementation
for the layout_tests/port package. Also add a simple test driver of
that interface.
- Scripts/webkitpy/layout_tests/driver_test.py: Added.
- Scripts/webkitpy/layout_tests/port/init.py:
- Scripts/webkitpy/layout_tests/port/mac.py: Added.
- Scripts/webkitpy/layout_tests/port/test.py: Added.
- 4:40 PM Changeset in webkit [54451] by
-
- 5 moves in branches/old
Move aside some old branches.
- 4:29 PM Changeset in webkit [54450] by
-
- 1 copy in branches/safari-532-branch
New branch.
- 4:01 PM Changeset in webkit [54449] by
-
- 22 edits2 adds1 delete in trunk/WebKitTools
2010-02-03 Dirk Pranke <dpranke@chromium.org>
Reviewed by Eric Siedel.
Refactor the port package into an object-oriented style and merge
path_utils into it. We add a 'base' and a 'chromium' object to the
port package; this will allow us to easily add new ports (like
WebKit Mac).
- Scripts/rebaseline-chromium-webkit-tests:
- Scripts/run-chromium-webkit-tests:
- Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
- Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
- Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
- Scripts/webkitpy/layout_tests/layout_package/test_files.py:
- Scripts/webkitpy/layout_tests/layout_package/test_shell_thread.py:
- Scripts/webkitpy/layout_tests/port/init.py:
- Scripts/webkitpy/layout_tests/port/apache_http_server.py:
- Scripts/webkitpy/layout_tests/port/base.py: Added.
- Scripts/webkitpy/layout_tests/port/chromium.py: Added.
- Scripts/webkitpy/layout_tests/port/chromium_linux.py:
- Scripts/webkitpy/layout_tests/port/chromium_mac.py:
- Scripts/webkitpy/layout_tests/port/chromium_win.py:
- Scripts/webkitpy/layout_tests/port/http_server.py:
- Scripts/webkitpy/layout_tests/port/http_server_base.py:
- Scripts/webkitpy/layout_tests/port/path_utils.py: Removed.
- Scripts/webkitpy/layout_tests/port/websocket_server.py:
- Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
- Scripts/webkitpy/layout_tests/run_chromium_webkit_tests.py:
- Scripts/webkitpy/layout_tests/test_types/fuzzy_image_diff.py:
- Scripts/webkitpy/layout_tests/test_types/image_diff.py:
- Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
- Scripts/webkitpy/layout_tests/test_types/text_diff.py:
- 3:11 PM Changeset in webkit [54448] by
-
- 2 edits in trunk/WebKit/chromium
2010-02-05 James Hawkins <jhawkins@chromium.org>
Reviewed by David Levin.
[Chromium] Remove an unused forward declaration in WebKitClient.h.
- public/WebKitClient.h:
- 2:53 PM Changeset in webkit [54447] by
-
- 5 edits in trunk/WebKit/mac
Reviewed by Mark Rowe.
https://bugs.webkit.org/show_bug.cgi?id=34661
<rdar://problem/7614067> REGRESSION (Safari 4.0-> Safari 4.0.4): NPP_SetWindow no longer sets a clipRect of (0,0,0,0) when it becomes hidden
- Plugins/Hosted/WebHostedNetscapePluginView.mm: (-[WebHostedNetscapePluginView updateAndSetWindow]): When clipping out NPDrawingModelCoreAnimation plug-ins, provide a zero'd out clipRect.
- Plugins/WebBaseNetscapePluginView.h: Moved superviewsHaveSuperviews to the base class.
- Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView superviewsHaveSuperviews]): Added to the base class; extracted from WebNetscapePluginView. (-[WebBaseNetscapePluginView shouldClipOutPlugin]): Added new method with code extracted from WebNetscapePluginView.
- Plugins/WebNetscapePluginView.mm: (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]): When clipping out NPDrawingModelCoreAnimation plug-ins, provide a zero'd out clipRect.
- 2:40 PM Changeset in webkit [54446] by
-
- 2 edits2 adds in trunk/WebCore
Horizontal scrollbar works in reverse at milliondollarcu.be
<rdar://problem/7556121>
https://bugs.webkit.org/show_bug.cgi?id=33848
Reviewed by Simon Fraser.
Added a manual test.
- manual-tests/win: Added.
- manual-tests/win/horizontal-scroll-composited.html: Added.
- platform/graphics/win/WKCACFLayerRenderer.cpp:
(WebCore::WKCACFLayerRenderer::setScrollFrame):
(WebCore::WKCACFLayerRenderer::setRootChildLayer):
- 2:24 PM Changeset in webkit [54445] by
-
- 2 edits in trunk/LayoutTests
Rubber-stamped by Kenneth Rohde Christiansen.
[Qt] Missing fast/frames/flattening/resources/frameset-flattening-subframe-resize.html
https://bugs.webkit.org/show_bug.cgi?id=34662
- platform/qt/Skipped: fast/frames/flattening/frameset-flattening-subframe-resize.html skipped until fix.
- 2:04 PM Changeset in webkit [54444] by
-
- 3 edits in trunk/LayoutTests
Rubber-stamped by Kenneth Rohde Christiansen.
Update expected results after r54441 to make buildbot happy.
- platform/qt/fast/frames/flattening/frameset-flattening-advanced-expected.txt: Updated.
- platform/qt/fast/frames/flattening/frameset-flattening-subframesets-expected.txt: Updated.
- 1:58 PM Changeset in webkit [54443] by
-
- 3 edits in trunk/WebKit/chromium
2010-02-05 James Hawkins <jhawkins@chromium.org>
Reviewed by Darin Fisher.
Implement WebInputElement::isActivatedSubmit().
- public/WebInputElement.h:
- src/WebInputElement.cpp: (WebKit::WebInputElement::isActivatedSubmit):
- 1:37 PM Changeset in webkit [54442] by
-
- 1 edit1 add in trunk/WebCore
2010-02-05 Ryan Leavengood <leavengood@gmail.com>
Reviewed by David Levin.
Implementation of GlyphPage::fill() for Haiku port.
https://bugs.webkit.org/show_bug.cgi?id=34527
Covered by existing tests.
- platform/graphics/haiku/GlyphPageTreeNodeHaiku.cpp
- 1:21 PM Changeset in webkit [54441] by
-
- 1 edit6 adds in trunk/LayoutTests
Unreviewed, missed in earlier commit.
Add expected frame flattening results for Qt.
- platform/qt/fast/frames/flattening/frameset-flattening-advanced-expected.txt: Added.
- platform/qt/fast/frames/flattening/frameset-flattening-grid-expected.txt: Added.
- platform/qt/fast/frames/flattening/frameset-flattening-simple-expected.txt: Added.
- platform/qt/fast/frames/flattening/frameset-flattening-subframe-resize-expected.txt: Added.
- platform/qt/fast/frames/flattening/frameset-flattening-subframesets-expected.txt: Added.
- 12:47 PM Changeset in webkit [54440] by
-
- 18 edits6 adds in trunk
Implement flattening of framesets
https://bugs.webkit.org/show_bug.cgi?id=32717
Reviewed by Dave Hyatt.
WebCore:
The following patch, builds ontop of Antti Koivisto's frameset
flattening code from the iPhone source, which itself is based on
the old Nokia Series 60 source.
Layout tests have been added to test the functionality and the original
code which has then been fixed to make these pass, as well as support
frameset grids.
Tests: fast/frames/flattening/frameset-flattening-advanced.html
fast/frames/flattening/frameset-flattening-grid.html
fast/frames/flattening/frameset-flattening-simple.html
fast/frames/flattening/frameset-flattening-subframe-resize.html
fast/frames/flattening/frameset-flattening-subframesets.html
- page/FrameView.cpp:
(WebCore::FrameView::layout):
(WebCore::FrameView::scheduleRelayout):
- page/Settings.cpp:
(WebCore::Settings::Settings):
(WebCore::Settings::setFrameSetFlatteningEnabled):
- page/Settings.h:
(WebCore::Settings::frameSetFlatteningEnabled):
- rendering/RenderFrame.cpp:
(WebCore::RenderFrame::layoutWithFlattening):
- rendering/RenderFrame.h:
- rendering/RenderFrameSet.cpp:
(WebCore::RenderFrameSet::layout):
(WebCore::RenderFrameSet::positionFramesWithFlattening):
(WebCore::RenderFrameSet::flattenFrameSet):
(WebCore::RenderFrameSet::userResize):
- rendering/RenderFrameSet.h:
WebKit/qt:
Privately export the setFrameSetFlatteningEnabled setting for
use with the Qt DRT.
- Api/qwebpage.cpp:
(qt_drt_setFrameSetFlatteningEnabled):
(QWebPagePrivate::core):
- Api/qwebpage_p.h:
WebKitTools:
Add support for testing frame flattening with the Qt DRT
- DumpRenderTree/qt/LayoutTestControllerQt.cpp:
(LayoutTestController::setFrameSetFlatteningEnabled):
- DumpRenderTree/qt/LayoutTestControllerQt.h:
LayoutTests:
Frameset flattening layout test, plus expected result for Qt.
- fast/frames/flattening/frameset-flattening-advanced.html: Added.
- fast/frames/flattening/frameset-flattening-grid.html: Added.
- fast/frames/flattening/frameset-flattening-simple.html: Added.
- fast/frames/flattening/frameset-flattening-subframe-resize.html: Added.
- fast/frames/flattening/frameset-flattening-subframesets.html: Added.
- fast/frames/flattening/resources/frameset-flattening-subframe-resize.html: Added.
- platform/qt/fast/frames/flattening/frameset-flattening-advanced-expected.txt: Added.
- platform/qt/fast/frames/flattening/frameset-flattening-grid-expected.txt: Added.
- platform/qt/fast/frames/flattening/frameset-flattening-simple-expected.txt: Added.
- platform/qt/fast/frames/flattening/frameset-flattening-subframe-resize-expected.txt: Added.
- platform/qt/fast/frames/flattening/frameset-flattening-subframesets-expected.txt: Added.
- 12:44 PM Changeset in webkit [54439] by
-
- 9 edits in trunk/WebKitTools
Provided a way in check-webkit-style to specify filter rules
on a per file or folder basis, via a configuration variable.
Reviewed by Shinichiro Hamaji.
https://bugs.webkit.org/show_bug.cgi?id=33684
- Scripts/webkitpy/style/checker.py:
- Added _PATH_RULES_SPECIFIER configuration variable.
- In ProcessorOptions class--
- Changed the CategoryFilter attribute to FilterConfiguration.
- Added path parameter to is_reportable().
- Renamed ArgumentDefaults filter_rules attribute to base_filter_rules.
- Updated ArgumentPrinter class.
- Added filter rule validation to ArgumentParser (instead of in CategoryFilter constructor).
- Scripts/webkitpy/style/checker_unittest.py:
- Updated unit tests as necessary.
- Added unit tests for PATH_RULES_SPECIFIER.
- Scripts/webkitpy/style/error_handlers.py:
- Updated DefaultStyleErrorHandler to use file path when calling is_reportable().
- Scripts/webkitpy/style/error_handlers_unittest.py:
- Updated unit tests as necessary.
- Scripts/webkitpy/style/filter.py:
- Marked CategoryFilter internal with an underscore.
- Removed argument validation from CategoryFilter.
- Added FilterConfiguration class.
- Scripts/webkitpy/style/filter_unittest.py:
- Updated CategoryFilterTest class.
- Added FilterConfigurationTest unit tests.
- Scripts/webkitpy/style/processors/cpp.py:
- Removed _is_test_filename() code.
- Removed hard-coded path checks from check_include_line().
- Scripts/webkitpy/style/processors/cpp_unittest.py:
- Removed three unit tests related to exempted files.
- 11:50 AM Changeset in webkit [54438] by
-
- 7 edits2 adds in trunk
2010-02-05 Simon Fraser <Simon Fraser>
Reviewed by Dan Bernstein.
Changing display type of parent of input on focus causes input field to not receive key events
https://bugs.webkit.org/show_bug.cgi?id=34620
<rdar://problem/7584572>
When layout affects a text input, the RenderTextControl gets destroyed and
recreated, which in turn makes a new innerTextElement. However, if the text field was
focused, the VisibleSelection is left pointing to the old innerTextElement, so text
input no longer works.
The fix is to call updateFocusAppearanceSoon() when attaching the input element,
which will update the selection if necessary.
Test: fast/forms/restore-selection-after-layout.html
- dom/Document.h: Add a paramter to updateFocusAppearanceSoon() and a member variable, m_updateFocusAppearanceRestoresSelection, to store its value until the timer fires.
- dom/Document.cpp: (WebCore::Document::Document): Initialize m_updateFocusAppearanceRestoresSelection (WebCore::Document::updateFocusAppearanceSoon): New restorePreviousSelection parameter. (WebCore::Document::updateFocusAppearanceTimerFired): Pass m_updateFocusAppearanceRestoresSelection down.
- dom/Element.cpp: (WebCore::Element::attach): Call updateFocusAppearanceSoon() with false.
- dom/Element.h: The updateFocusAppearanceSoonAfterAttach() was undefined.
- html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::attach): Call document()->updateFocusAppearanceSoon() with true.
- 11:46 AM Changeset in webkit [54437] by
-
- 3 edits in trunk/WebKitTools
[Qt] Apply the command line options as settings to the graphics system.
Reviewed by Ariya Hidayat.
- QtLauncher/main.cpp:
(LauncherWindow::LauncherWindow):
(requiresGraphicsView):
(LauncherApplication::handleUserOptions):
- QtLauncher/webview.h:
(WebViewGraphicsBased::setItemCacheMode):
- 11:30 AM Changeset in webkit [54436] by
-
- 7 edits in trunk/WebCore
2010-02-05 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: simplify cookies view, introduce DataGrid::autoSizeColumns.
- inspector/front-end/CookieItemsView.js: (WebInspector.CookieItemsView): (WebInspector.CookieItemsView.prototype.show): (WebInspector.CookieItemsView.prototype._update): (WebInspector.CookieItemsView.prototype._updateWithCookies): (WebInspector.CookieItemsView.prototype._filterCookiesForDomain): (WebInspector.CookieItemsView.prototype._createDataGrid): (WebInspector.CookieItemsView.prototype._populateDataGrid.expiresCompare): (WebInspector.CookieItemsView.prototype._populateDataGrid): (WebInspector.CookieItemsView.prototype._createSimpleDataGrid): (WebInspector.CookieItemsView.prototype._populateSimpleDataGrid): (WebInspector.CookieItemsView.prototype._deleteCookieCallback): (WebInspector.CookieItemsView.prototype._refreshButtonClicked):
- inspector/front-end/DOMStorageItemsView.js: (WebInspector.DOMStorageItemsView.prototype._showDOMStorageEntries): (WebInspector.DOMStorageItemsView.prototype._dataGridForDOMStorageEntries):
- inspector/front-end/DataGrid.js: (WebInspector.DataGrid): (WebInspector.DataGrid.prototype.autoSizeColumns):
- inspector/front-end/DatabaseQueryView.js: (WebInspector.DatabaseQueryView.prototype._queryFinished):
- inspector/front-end/DatabaseTableView.js: (WebInspector.DatabaseTableView.prototype._queryFinished):
- inspector/front-end/StoragePanel.js: (WebInspector.StoragePanel.prototype.dataGridForResult):
- 11:22 AM Changeset in webkit [54435] by
-
- 6 edits in trunk/WebCore
2010-02-04 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: group cookies by frame, show total
cookies size, allow sorting cookie table.
- English.lproj/localizedStrings.js:
- inspector/InspectorController.cpp: (WebCore::InspectorController::deleteCookie):
- inspector/front-end/CookieItemsView.js: (WebInspector.CookieItemsView): (WebInspector.CookieItemsView.prototype.update): (WebInspector.CookieItemsView.prototype._updateWithCookies): (WebInspector.CookieItemsView.prototype._cookiesForDomain): (WebInspector.CookieItemsView.prototype.dataGridForCookies): (WebInspector.CookieItemsView.prototype._createNodes): (WebInspector.CookieItemsView.prototype._sortData.localeCompare): (WebInspector.CookieItemsView.prototype._sortData.numberCompare): (WebInspector.CookieItemsView.prototype._sortData.expiresCompare): (WebInspector.CookieItemsView.prototype._sortData):
- inspector/front-end/StoragePanel.js: (WebInspector.StoragePanel.prototype.showCookies): (WebInspector.CookieSidebarTreeElement): (WebInspector.CookieSidebarTreeElement.prototype.onselect): (WebInspector.CookieSidebarTreeElement.prototype.get subtitle): (WebInspector.CookieSidebarTreeElement.prototype.set subtitle):
- inspector/front-end/inspector.js: (WebInspector.updateResource):
- 11:08 AM Changeset in webkit [54434] by
-
- 2 edits in trunk/WebCore
2010-02-05 Maxime Simone <Maxime Simon>
Reviewed by David Levin.
More robust conversion from BString to String for Haiku port.
https://bugs.webkit.org/show_bug.cgi?id=34527
Covered by existing tests.
- platform/text/haiku/StringHaiku.cpp: Fixed include order, Improved coversion from BString.
- 10:44 AM Changeset in webkit [54433] by
-
- 2 edits in tags/Safari-533.0.2/WebCore
Merge r54430.
- 10:43 AM Changeset in webkit [54432] by
-
- 4 edits in tags/Safari-533.0.2
Versioning.
- 10:41 AM Changeset in webkit [54431] by
-
- 1 copy in tags/Safari-533.0.2
New tag.
- 10:35 AM Changeset in webkit [54430] by
-
- 2 edits in trunk/WebCore
Windows build fix.
Reviewed by Adam Roben.
- WebCore.vcproj/WebCore.make:
- 10:08 AM Changeset in webkit [54429] by
-
- 32 edits in trunk
Rubber-stamped by Kenneth Rohde Christiansen.
Reviewed by Dirk Schulze.
[Qt] Modifying SVG path dumping to equal to other ports
https://bugs.webkit.org/show_bug.cgi?id=33784
WebCore:
- platform/graphics/qt/PathQt.cpp:
(WebCore::Path::debugString): Path dumping style is aproached to Mac.
LayoutTests:
Expected files updated.
- platform/qt/svg/css/arrow-with-shadow-expected.txt:
- platform/qt/svg/css/circle-in-mask-with-shadow-expected.txt:
- platform/qt/svg/css/clippath-with-shadow-expected.txt:
- platform/qt/svg/css/mask-with-shadow-expected.txt:
- platform/qt/svg/css/path-with-shadow-expected.txt:
- platform/qt/svg/css/stars-with-shadow-expected.txt:
- platform/qt/svg/custom/empty-mask-expected.txt:
- platform/qt/svg/custom/gradient-userSpaceOnUse-with-percentage-expected.txt:
- platform/qt/svg/custom/marker-opacity-expected.txt:
- platform/qt/svg/custom/marker-referencePoint-expected.txt:
- platform/qt/svg/custom/marker-strokeWidth-changes-expected.txt:
- platform/qt/svg/custom/mask-with-default-value-expected.txt:
- platform/qt/svg/custom/relative-sized-content-expected.txt:
- platform/qt/svg/custom/relative-sized-deep-shadow-tree-content-expected.txt:
- platform/qt/svg/custom/relative-sized-shadow-tree-content-expected.txt:
- platform/qt/svg/custom/relative-sized-shadow-tree-content-with-symbol-expected.txt:
- platform/qt/svg/custom/relative-sized-use-on-symbol-expected.txt:
- platform/qt/svg/custom/transformedMaskFails-expected.txt:
- platform/qt/svg/custom/use-on-symbol-inside-pattern-expected.txt:
- platform/qt/svg/filters/feComposite-expected.txt:
- platform/qt/svg/filters/feGaussianBlur-expected.txt:
- platform/qt/svg/filters/feMerge-expected.txt:
- platform/qt/svg/filters/feMerge-wrong-input-expected.txt:
- platform/qt/svg/filters/feOffset-expected.txt:
- platform/qt/svg/filters/feTile-expected.txt:
- platform/qt/svg/filters/shadow-on-filter-expected.txt:
- platform/qt/svg/filters/shadow-on-rect-with-filter-expected.txt:
- platform/qt/svg/filters/subRegion-one-effect-expected.txt:
- platform/qt/svg/filters/subRegion-two-effects-expected.txt:
- 9:46 AM Changeset in webkit [54428] by
-
- 8 edits in trunk
2010-02-05 Kwang Yul Seo <skyul@company100.net>
Reviewed by Alexey Proskuryakov.
Don't call CRASH() in fastMalloc and fastCalloc when the requested memory size is 0
https://bugs.webkit.org/show_bug.cgi?id=34569
With USE_SYSTEM_MALLOC=1, fastMalloc and fastCalloc call CRASH()
if the return value of malloc and calloc is 0.
However, these functions can return 0 when the request size is 0.
Libc manual says, "If size is 0, then malloc() returns either NULL,
or a unique pointer value that can later be successfully passed to free()."
Though malloc returns a unique pointer in most systems,
0 can be returned in some systems. For instance, BREW's MALLOC returns 0
when size is 0.
If malloc or calloc returns 0 due to allocation size, increase the size
to 1 and try again.
- wtf/FastMalloc.cpp: (WTF::fastMalloc): (WTF::fastCalloc):
2010-02-05 Sebastian Dröge <sebastian.droege@collabora.co.uk>
Reviewed by Gustavo Noronha.
Add a GStreamer HTTP/HTTPS source, using WebKit infrastructure
https://bugs.webkit.org/show_bug.cgi?id=34317
- GNUmakefile.am:
- platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::mediaPlayerPrivateSourceChangedCallback): (WebCore::doGstInit):
- platform/graphics/gtk/WebKitWebSourceGStreamer.cpp:
- platform/graphics/gtk/WebKitWebSourceGStreamer.h: Add a GStreamer HTTP/HTTPS source, using the WebKit infrastructure. This makes sure that referer, cookies, authentication information and all kinds of other context are passed to GStreamer for websites like Vimeo or YouTube.
- 9:24 AM Changeset in webkit [54427] by
-
- 5 edits2 adds in trunk
2010-02-05 Sebastian Dröge <sebastian.droege@collabora.co.uk>
Reviewed by Gustavo Noronha.
Add a GStreamer HTTP/HTTPS source, using WebKit infrastructure
https://bugs.webkit.org/show_bug.cgi?id=34317
- GNUmakefile.am:
- platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::mediaPlayerPrivateSourceChangedCallback): (WebCore::doGstInit):
- platform/graphics/gtk/WebKitWebSourceGStreamer.cpp:
- platform/graphics/gtk/WebKitWebSourceGStreamer.h: Add a GStreamer HTTP/HTTPS source, using the WebKit infrastructure. This makes sure that referer, cookies, authentication information and all kinds of other context are passed to GStreamer for websites like Vimeo or YouTube.
- 8:41 AM Changeset in webkit [54426] by
-
- 2 edits in trunk/WebKit/qt
[Qt] Fix build on Windows
Reviewed by Kenneth Rohde Christiansen.
DerivedSources for our API headers failed on Windows,
due to Windows not accepting ; as a command separator,
not needing quotes for echo, and needing < and > escaped.
We now detect Windows and set these quote markers and
escape markers accordingly, as well as use && for separating
individual commands.
- Api/DerivedSources.pro:
- 8:28 AM Changeset in webkit [54425] by
-
- 17 edits in trunk
2010-02-05 Nate Chapin <Nate Chapin>
Reviewed by Dimitri Glazkov.
[V8] Clean up code for getting a v8::FunctionTemplate.
- bindings/scripts/CodeGeneratorV8.pm: Making GetTemplate() public
- bindings/v8/V8Binding.cpp: (WebCore::configureTemplate):
- bindings/v8/V8DOMWrapper.cpp: Remove getTemplate(), use V8ClassIndex::getTemplate() instead. (WebCore::V8DOMWrapper::getConstructor): (WebCore::V8DOMWrapper::instantiateV8Object):
- bindings/v8/V8DOMWrapper.h: (WebCore::V8DOMWrapper::lookupDOMWrapper):
- bindings/v8/V8Index.cpp: Remove duplicate caching of FunctionTemplates. (WebCore::V8ClassIndex::getTemplate):
- bindings/v8/V8Index.h:
- bindings/v8/WorkerContextExecutionProxy.cpp: (WebCore::WorkerContextExecutionProxy::toV8):
- bindings/v8/custom/V8HTMLAudioElementConstructor.cpp: (WebCore::v8HTMLAudioElementConstructorCallback): (WebCore::V8HTMLAudioElementConstructor::GetTemplate):
- bindings/v8/custom/V8HTMLAudioElementConstructor.h:
- bindings/v8/custom/V8HTMLImageElementConstructor.cpp: (WebCore::v8HTMLImageElementConstructorCallback): (WebCore::V8HTMLImageElementConstructor::GetTemplate):
- bindings/v8/custom/V8HTMLImageElementConstructor.h:
- bindings/v8/custom/V8HTMLOptionElementConstructor.cpp: (WebCore::v8HTMLOptionElementConstructorCallback): (WebCore::V8HTMLOptionElementConstructor::GetTemplate):
- bindings/v8/custom/V8HTMLOptionElementConstructor.h:
- bindings/v8/custom/V8InjectedScriptHostCustom.cpp: (WebCore::createInjectedScriptHostV8Wrapper):
- 8:01 AM Changeset in webkit [54424] by
-
- 2 edits in trunk/LayoutTests
Rubber-stamped by Tor Arne Vestbø.
[Qt] fast/css/dashboard-regions-attr-crash.html skipped,
because ENABLE_DASHBOARD_SUPPORT=0 is the default option.
- platform/qt/Skipped:
- 7:09 AM Changeset in webkit [54423] by
-
- 1 edit1 add in trunk
2010-02-05 Simon Hausmann <simon.hausmann@nokia.com>
Reviewed by Tor Arne Vestbø.
Add .gitattributes file to tell git about files with Windows linefeeds
https://bugs.webkit.org/show_bug.cgi?id=34645
On Windows git defaults to "true" for core.autocrlf, meaning all text
files in the working directory are converted from CRLF to LF on checkin
time. Some files present in the repository have been checked in with
CRLF linefeeds and git should not try to convert them. The added
.gitattributes file tells git to not do any CRLF conversion.
- .gitattributes: Added.
- 6:10 AM Changeset in webkit [54422] by
-
- 2 edits in trunk/WebCore
[Qt] Build break in QtWebkit on Symbian
https://bugs.webkit.org/show_bug.cgi?id=34597
Patch by Siddharth Mathur <siddharth.mathur@nokia.com> on 2010-02-05
Reviewed by Ariya Hidayat.
- plugins/PluginView.h:
- 6:08 AM Changeset in webkit [54421] by
-
- 30 edits in trunk
2010-02-05 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
- Use SerializedScriptValue for passing data between injected script and inspector frontend.
- Remove custom JSON implementation from the instpector utility script.
- Make sure that only objects created in the same ScriptState can be values of ScriptObject/Array properties and arguments to ScriptFunctionCall. We don't want ScriptObjects to leak between contexts.
- Use ScriptState of the 'this' object in ScriptFunctionCall instead of passing it as additional parameter.
- bindings/js/JSInjectedScriptHostCustom.cpp: (WebCore::JSInjectedScriptHost::reportDidDispatchOnInjectedScript):
- bindings/js/ScriptArray.cpp: (WebCore::ScriptArray::set):
- bindings/js/ScriptFunctionCall.cpp: (WebCore::ScriptFunctionCall::ScriptFunctionCall): (WebCore::ScriptFunctionCall::appendArgument):
- bindings/js/ScriptFunctionCall.h:
- bindings/js/ScriptObject.cpp: (WebCore::ScriptObject::set):
- bindings/js/ScriptValue.cpp: (WebCore::ScriptValue::serialize): (WebCore::ScriptValue::deserialize):
- bindings/js/ScriptValue.h:
- bindings/v8/ScriptArray.cpp: (WebCore::ScriptArray::set):
- bindings/v8/ScriptFunctionCall.cpp: (WebCore::ScriptFunctionCall::ScriptFunctionCall): (WebCore::ScriptFunctionCall::appendArgument):
- bindings/v8/ScriptFunctionCall.h:
- bindings/v8/ScriptObject.cpp: (WebCore::ScriptObject::set):
- bindings/v8/ScriptState.h:
- bindings/v8/ScriptValue.cpp: (WebCore::ScriptValue::serialize): (WebCore::deserialize):
- bindings/v8/ScriptValue.h:
- bindings/v8/custom/V8InjectedScriptHostCustom.cpp: (WebCore::V8InjectedScriptHost::reportDidDispatchOnInjectedScriptCallback):
- inspector/InjectedScript.cpp: (WebCore::InjectedScript::dispatch): (WebCore::InjectedScript::callFrames): (WebCore::InjectedScript::wrapForConsole): (WebCore::InjectedScript::releaseWrapperObjectGroup):
- inspector/InjectedScript.h:
- inspector/InjectedScriptHost.cpp: (WebCore::InjectedScriptHost::reportDidDispatchOnInjectedScript):
- inspector/InjectedScriptHost.h:
- inspector/InjectedScriptHost.idl:
- inspector/InspectorBackend.cpp: (WebCore::InspectorBackend::dispatchOnInjectedScript):
- inspector/InspectorController.cpp: (WebCore::InspectorController::setFrontendProxyObject): (WebCore::InspectorController::didPause): (WebCore::InspectorController::didEvaluateForTestInFrontend):
- inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::InspectorFrontend): (WebCore::InspectorFrontend::newScriptArray): (WebCore::InspectorFrontend::newScriptObject): (WebCore::InspectorFrontend::populateFrontendSettings): (WebCore::InspectorFrontend::updateConsoleMessageExpiredCount): (WebCore::InspectorFrontend::addConsoleMessage): (WebCore::InspectorFrontend::updateConsoleMessageRepeatCount): (WebCore::InspectorFrontend::updateResource): (WebCore::InspectorFrontend::removeResource): (WebCore::InspectorFrontend::didGetResourceContent): (WebCore::InspectorFrontend::updateFocusedNode): (WebCore::InspectorFrontend::setAttachedWindow): (WebCore::InspectorFrontend::addRecordToTimeline): (WebCore::InspectorFrontend::parsedScriptSource): (WebCore::InspectorFrontend::failedToParseScriptSource): (WebCore::InspectorFrontend::addProfileHeader): (WebCore::InspectorFrontend::setRecordingProfile): (WebCore::InspectorFrontend::didGetProfileHeaders): (WebCore::InspectorFrontend::didGetProfile): (WebCore::InspectorFrontend::pausedScript): (WebCore::InspectorFrontend::setDocument): (WebCore::InspectorFrontend::setDetachedRoot): (WebCore::InspectorFrontend::setChildNodes): (WebCore::InspectorFrontend::childNodeCountUpdated): (WebCore::InspectorFrontend::childNodeInserted): (WebCore::InspectorFrontend::childNodeRemoved): (WebCore::InspectorFrontend::attributesUpdated): (WebCore::InspectorFrontend::didRemoveNode): (WebCore::InspectorFrontend::didGetChildNodes): (WebCore::InspectorFrontend::didApplyDomChange): (WebCore::InspectorFrontend::didGetEventListenersForNode): (WebCore::InspectorFrontend::didGetCookies): (WebCore::InspectorFrontend::didDispatchOnInjectedScript): (WebCore::InspectorFrontend::addDatabase): (WebCore::InspectorFrontend::selectDatabase): (WebCore::InspectorFrontend::didGetDatabaseTableNames): (WebCore::InspectorFrontend::addDOMStorage): (WebCore::InspectorFrontend::selectDOMStorage): (WebCore::InspectorFrontend::didGetDOMStorageEntries): (WebCore::InspectorFrontend::didSetDOMStorageItem): (WebCore::InspectorFrontend::didRemoveDOMStorageItem): (WebCore::InspectorFrontend::updateDOMStorage): (WebCore::InspectorFrontend::addNodesToSearchResult): (WebCore::InspectorFrontend::contextMenuItemSelected): (WebCore::InspectorFrontend::evaluateForTestInFrontend): (WebCore::InspectorFrontend::callSimpleFunction):
- inspector/InspectorFrontend.h: (WebCore::InspectorFrontend::scriptState):
- inspector/front-end/InjectedScript.js: (injectedScriptConstructor): (injectedScriptConstructor.):
- inspector/front-end/InjectedScriptAccess.js: (InjectedScriptAccess._installHandler.InjectedScriptAccess.prototype.methodName.myCallback): (InjectedScriptAccess._installHandler.InjectedScriptAccess.prototype.methodName): (InjectedScriptAccess._installHandler):
- inspector/front-end/inspector.js: (WebInspector.pausedScript): (WebInspector.addConsoleMessage):
2010-02-05 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Remove unused inmport of ScriptFunctionCall.h
- Api/qwebelement.cpp:
- 6:00 AM WebKit Team edited by
- (diff)
- 5:23 AM Changeset in webkit [54420] by
-
- 7 edits1 add1 delete in trunk
[Qt] Generate convenience headers (QWebView, etc) using qmake
Reviewed by Simon Hausmann.
In Qt this is done using syncqt, but we use a pro-file instead
that generates makefile-rules for each of the extra headers.
These extra headers are installed alongside the normal headers.
WebCore:
- WebCore.pro: Use headers.pri based on DerivedSources instead
of the one previously checked in in the source tree.
WebKit/qt:
- Api/DerivedSources.pro: Added. List of headers + pro file magic
- Api/headers.pri: Removed, list of headers is now in the above file
WebKitTools:
- Scripts/webkitdirs.pm: Run qmake and make on new API-DerivedSources
- 4:27 AM Changeset in webkit [54419] by
-
- 2 edits in trunk/JavaScriptCore
Don't call CRASH() in fastMalloc and fastCalloc when the requested memory size is 0
https://bugs.webkit.org/show_bug.cgi?id=34569
Patch by Kwang Yul Seo <skyul@company100.net> on 2010-02-05
Reviewed by Alexey Proskuryakov.
With USE_SYSTEM_MALLOC=1, fastMalloc and fastCalloc call CRASH()
if the return value of malloc and calloc is 0.
However, these functions can return 0 when the request size is 0.
Libc manual says, "If size is 0, then malloc() returns either NULL,
or a unique pointer value that can later be successfully passed to free()."
Though malloc returns a unique pointer in most systems,
0 can be returned in some systems. For instance, BREW's MALLOC returns 0
when size is 0.
If malloc or calloc returns 0 due to allocation size, increase the size
to 1 and try again.
- wtf/FastMalloc.cpp:
(WTF::fastMalloc):
(WTF::fastCalloc):
- 4:20 AM Changeset in webkit [54418] by
-
- 2 edits in trunk/WebKitTools
2010-02-05 Andras Becsi <abecsi@webkit.org>
Unreviewed typo fix.
Fix wrong whitespace alignment introduced in r54342.
- 4:05 AM Changeset in webkit [54417] by
-
- 6 edits in trunk
2010-02-05 Mikhail Naganov <mnaganov@chromium.org>
Reviewed by Pavel Feldman.
Enable JAVASCRIPT_DEBUGGER in chromium port.
- page/Console.cpp:
- page/Console.h:
- page/Console.idl:
2010-02-05 Mikhail Naganov <mnaganov@chromium.org>
Reviewed by Pavel Feldman.
Enable JAVASCRIPT_DEBUGGER in chromium port.
- features.gypi:
- 3:45 AM Changeset in webkit [54416] by
-
- 4 edits in trunk/WebKitTools
Rubberstamped by Oliver Hunt.
[Qt] Make it possible to choose whether the launcher should
use the traditional QWidget based QWebView or the newer
QGraphics based QGraphicsWebView on a QGraphicsView.
- QtLauncher/main.cpp:
(LauncherWindow::LauncherWindow):
(LauncherWindow::eventFilter):
(LauncherWindow::loadStarted):
(LauncherWindow::print):
(LauncherWindow::screenshot):
(LauncherWindow::setEditable):
(LauncherWindow::setupUI):
(main):
- QtLauncher/webview.cpp:
(WebViewGraphicsBased::WebViewGraphicsBased):
(WebViewGraphicsBased::resizeEvent):
(GraphicsWebView::mousePressEvent):
(GraphicsWebView::contextMenuEvent):
- QtLauncher/webview.h:
(WebViewTraditional::WebViewTraditional):
(GraphicsWebView::GraphicsWebView):
(WebViewGraphicsBased::setPage):
- 2:50 AM Changeset in webkit [54415] by
-
- 3 edits in trunk/WebCore
2010-02-05 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: Tab width for javascript source is 8, should be 4
- inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame):
- inspector/front-end/TextEditorModel.js: (WebInspector.TextEditorModel.prototype.set replaceTabsWithSpaces): (WebInspector.TextEditorModel.prototype._innerSetText): (WebInspector.TextEditorModel.prototype._replaceTabsIfNeeded):
- 1:37 AM Changeset in webkit [54414] by
-
- 1 edit2 adds in trunk/LayoutTests
2010-02-05 Fumitoshi Ukai <ukai@chromium.org>
Reviewed by Alexey Proskuryakov.
send() should return false, after frame that opened a WebSokcet is detached
https://bugs.webkit.org/show_bug.cgi?id=34630
- websocket/tests/send-after-close-on-unload-expected.txt: Added.
- websocket/tests/send-after-close-on-unload.html: Added.
- 1:23 AM Changeset in webkit [54413] by
-
- 6 edits2 adds in trunk
2010-02-05 Tony Chang <tony@chromium.org>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=24872
Add a test to make sure copying from a list and pasting into a list
keeps the list at the same indention level rather than nesting.
- editing/pasteboard/paste-list-002-expected.txt: Added.
- editing/pasteboard/paste-list-002.html: Added.
2010-02-05 Tony Chang <tony@chromium.org>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=24872
When pasting a list into another list should not indent another level.
If the cursor is at the beginning of the line, it should insert the
list items before the current list item. If the cursor is at the end
of the line, it should insert the list items after the current list item.
This matches Firefox and IE and makes the common activity of reordering a list
work as expected.
This also adds a small helper method (isListItem) to htmlediting.h.
Test: editing/pasteboard/paste-list-002.html
- editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::doApply): (WebCore::ReplaceSelectionCommand::insertAsListItems):
- editing/ReplaceSelectionCommand.h:
- editing/htmlediting.cpp: (WebCore::isListItem): (WebCore::appendedSublist):
- editing/htmlediting.h:
Feb 4, 2010:
- 11:45 PM Changeset in webkit [54412] by
-
- 2 edits in trunk
[Qt] Make 'make -f Makefile.DerivedSources qmake' work
Reviewed by Lars Knoll.
Previously this target ended up generating a file named
Makefile.DerivedSources.DerivedSources, and so on.
- DerivedSources.pro:
- 11:34 PM Changeset in webkit [54411] by
-
- 2 edits in trunk/WebKit/mac
Rubber-stamped by Dan Bernstein.
Fix the ability to #include <WebKit/DOMFile.h>.
- MigrateHeaders.make: Mark DOMBlob.h as a public header since the already-public DOMFile.h depends on it.
- 11:18 PM Changeset in webkit [54410] by
-
- 2 edits2 adds in trunk/WebKit/chromium
2010-02-04 Yaar Schnitman <yaar@chromium.org>
Reviewed by Darin Fisher.
Upstreaming gtests from chromium: UniscribeHelper and TransparencyWin
https://bugs.webkit.org/show_bug.cgi?id=34509
Resubmit: The previous commit (r54333) was rolled back.
- WebKit.gyp:
- tests/TransparencyWinTest.cpp: Added. (WebCore::RECTToFloatRect): (WebCore::drawNativeRect): (WebCore::getPixelAt): (WebCore::clearTopLayerAlphaChannel): (WebCore::clearTopLayerAlphaPixel): (WebCore::operator<<): (WebCore::TEST):
- tests/UniscribeHelperTest.cpp: Added. (WebCore::UniscribeTest::UniscribeTest): (WebCore::UniscribeTest::MakeFont): (WebCore::UniscribeTest::SetUp): (WebCore::UniscribeTest::TearDown): (TEST_F):
- 10:22 PM Changeset in webkit [54409] by
-
- 10 edits1 move in tags/Safari-533.0.1
Merge r54405.
- 10:22 PM Changeset in webkit [54408] by
-
- 4 edits in tags/Safari-533.0.1
Versioning.
- 10:20 PM Changeset in webkit [54407] by
-
- 1 copy in tags/Safari-533.0.1
New tag.
- 10:15 PM Changeset in webkit [54406] by
-
- 1 edit5 adds in trunk/LayoutTests
2010-02-04 Fumitoshi Ukai <ukai@chromium.org>
Reviewed by Alexey Proskuryakov.
should not crash when document opened websocket is unloaded
https://bugs.webkit.org/show_bug.cgi?id=34562
- websocket/tests/close-on-unload-and-force-gc-expected.txt: Added.
- websocket/tests/close-on-unload-and-force-gc.html: Added.
- websocket/tests/close-on-unload-reference-in-parent-expected.txt: Added.
- websocket/tests/close-on-unload-reference-in-parent.html: Added.
- websocket/tests/resources/close-on-unload-iframe-reference-in-parent.html: Added.
- 10:13 PM Changeset in webkit [54405] by
-
- 10 edits1 move in trunk
Build fix. Remove a symbol corresponding to an inline function from the linker export
file to prevent a weak external failure.
Reviewed by Timothy Hatcher.
- JavaScriptCore.xcodeproj/project.pbxproj: Accommodate rename of script.
JavaScriptGlue:
- JavaScriptGlue.xcodeproj/project.pbxproj: Accommodate rename of script.
WebCore:
- WebCore.base.exp: Remove symbol.
- WebCore.xcodeproj/project.pbxproj: Accommodate rename of script.
WebKit:
- WebKit.xcodeproj/project.pbxproj: Accommodate rename of script.
WebKitTools:
- Scripts/check-for-weak-vtables-and-externals: Renamed from WebKitTools/Scripts/check-for-weak-vtables.
Teach the script how to detect weak external symbols so that these errors can be caught immediately
in the future.
- 9:59 PM Changeset in webkit [54404] by
-
- 3 edits in trunk/LayoutTests
2010-02-04 Fumitoshi Ukai <ukai@chromium.org>
Reviewed by Shinichiro Hamaji.
websocket/tests/close-on-unload.html failed on Mac Tiger
https://bugs.webkit.org/show_bug.cgi?id=34563
- platform/mac-tiger/Skipped: remove websocket/tests/close-on-unload*.html
- websocket/tests/close-on-unload_wsh.py: use dict instead of set.
- 9:33 PM Changeset in webkit [54403] by
-
- 2 edits in trunk/JavaScriptCore
2010-02-04 Daniel Bates <dbates@webkit.org>
[Qt] Unreviewed, build fix for Qt bot.
- runtime/JSStringBuilder.h: Changed #include <X.h> notation #include "X.h".
- 7:53 PM Changeset in webkit [54402] by
-
- 2 edits in trunk/JavaScriptCore
Build fix: export a header.
- JavaScriptCore.xcodeproj/project.pbxproj:
- 7:47 PM Changeset in webkit [54401] by
-
- 1 edit1 add in trunk/WebCore
Build fix: Added a forwarding header.
- ForwardingHeaders/runtime/WeakGCPtr.h: Added.
- 7:39 PM Changeset in webkit [54400] by
-
- 21 edits2 adds in trunk
WebCore: REGRESSION (r52082): Missing event handlers on JQuery demo page (33383)
https://bugs.webkit.org/show_bug.cgi?id=33383
<rdar://problem/7559449>
Reviewed by Alexey Proskuryakov and Darin Adler.
There were two bugs here:
- A stale wrapper would invalidate a node's event listeners, even if
the node had a fresh wrapper keeping it alive.
The fix for this is for an event listener to keep a WeakGCPtr back-pointer
to the wrapper it expects to mark it. The wrapper destructor checks this
back-pointer, and only invalidates the event listener in the case of a match.
- Conversely, a stale wrapper would not invalidate a node's event
listeners soon enough, if its destructor didn't have a chance to run
before an event fired on the node. (This can only happen in cases where
we've made some other error and failed to mark a wrapper that was circuitously
observable in the DOM. But we know we have edge case bugs like this, and
we don't want them to be crashes.)
The fix for this is to check the wrapper back-pointer before firing the
event listener. As long as the the wrapper back-pointer is not null,
it's safe to fire the listener.
- ForwardingHeaders/runtime/WeakGCPtr.h: Added. Appease build gods.
- bindings/js/JSAbstractWorkerCustom.cpp:
(WebCore::JSAbstractWorker::addEventListener):
(WebCore::JSAbstractWorker::removeEventListener):
- bindings/js/JSDOMApplicationCacheCustom.cpp:
(WebCore::JSDOMApplicationCache::addEventListener):
(WebCore::JSDOMApplicationCache::removeEventListener):
- bindings/js/JSDOMWindowCustom.cpp:
(WebCore::JSDOMWindow::markChildren):
(WebCore::JSDOMWindow::addEventListener):
(WebCore::JSDOMWindow::removeEventListener): Updated to pass a wrapper
to the JSEventListener constructor.
- bindings/js/JSEventListener.cpp:
(WebCore::JSEventListener::JSEventListener):
(WebCore::JSEventListener::initializeJSFunction):
(WebCore::JSEventListener::invalidateJSFunction):
- bindings/js/JSEventListener.h:
(WebCore::JSEventListener::create):
(WebCore::JSEventListener::isolatedWorld):
(WebCore::JSEventListener::wrapper):
(WebCore::JSEventListener::setWrapper):
(WebCore::JSEventListener::jsFunction):
(WebCore::createJSAttributeEventListener): Implemented the back-pointer
described above. Refactored the jsFunction() accessor to return 0 if
the wrapper back-pointer is 0.
- bindings/js/JSEventSourceCustom.cpp:
(WebCore::JSEventSource::addEventListener):
(WebCore::JSEventSource::removeEventListener):
- bindings/js/JSLazyEventListener.cpp:
(WebCore::JSLazyEventListener::JSLazyEventListener):
(WebCore::JSLazyEventListener::initializeJSFunction):
- bindings/js/JSLazyEventListener.h:
(WebCore::JSLazyEventListener::create):
- bindings/js/JSMessagePortCustom.cpp:
(WebCore::JSMessagePort::markChildren):
(WebCore::JSMessagePort::addEventListener):
(WebCore::JSMessagePort::removeEventListener):
- bindings/js/JSNodeCustom.cpp:
(WebCore::JSNode::addEventListener):
(WebCore::JSNode::removeEventListener):
(WebCore::JSNode::markChildren):
- bindings/js/JSSVGElementInstanceCustom.cpp:
(WebCore::JSSVGElementInstance::addEventListener):
(WebCore::JSSVGElementInstance::removeEventListener):
- bindings/js/JSWebSocketCustom.cpp:
(WebCore::JSWebSocket::addEventListener):
(WebCore::JSWebSocket::removeEventListener):
- bindings/js/JSWorkerContextCustom.cpp:
(WebCore::JSWorkerContext::markChildren):
(WebCore::JSWorkerContext::addEventListener):
(WebCore::JSWorkerContext::removeEventListener):
- bindings/js/JSXMLHttpRequestCustom.cpp:
(WebCore::JSXMLHttpRequest::markChildren):
(WebCore::JSXMLHttpRequest::addEventListener):
(WebCore::JSXMLHttpRequest::removeEventListener):
- bindings/js/JSXMLHttpRequestUploadCustom.cpp:
(WebCore::JSXMLHttpRequestUpload::markChildren):
(WebCore::JSXMLHttpRequestUpload::addEventListener):
(WebCore::JSXMLHttpRequestUpload::removeEventListener): Updated to pass a wrapper
to the JSEventListener constructor.
- bindings/js/ScriptEventListener.cpp:
(WebCore::createAttributeEventListener): Updated to pass a wrapper
to the JSEventListener constructor.
(WebCore::getEventListenerHandlerBody): Updated for the fact that jsFunction()
is no longer a virtual accessor on the EventHandler base class.
- bindings/scripts/CodeGeneratorJS.pm: Updated for the fact that jsFunction()
is no longer a virtual accessor on the EventHandler base class. Added a "JS"
to invalidateEventListeners and markEventListeners to clarify that these
actions are for JS event listeners only. Added a wrapper parameter to
invalidateEventListeners for the back-pointer check explained above.
- dom/EventListener.h:
(WebCore::EventListener::invalidateJSFunction): ditto
- dom/EventTarget.h:
(WebCore::EventTarget::markJSEventListeners):
(WebCore::EventTarget::invalidateJSEventListeners): ditto
LayoutTests: REGRESSION (r52082): Missing event handlers on JQuery demo page (33383)
https://bugs.webkit.org/show_bug.cgi?id=33383
<rdar://problem/7559449>
Reviewed by Alexey Proskuryakov and Darin Adler.
- fast/events/bogus-event-listener-invalidation-expected.txt: Added.
- fast/events/bogus-event-listener-invalidation.html: Added.
- 7:06 PM Changeset in webkit [54399] by
-
- 4 edits in tags/Safari-533
Versioning.
- 7:05 PM Changeset in webkit [54398] by
-
- 1 edit in trunk/WebKitLibraries/win/tools/scripts/VERSION
Versioning.
- 7:03 PM Changeset in webkit [54397] by
-
- 4 edits in trunk
Versioning.
- 6:56 PM Changeset in webkit [54396] by
-
- 1 copy in tags/Safari-533
Create tag Safari-533
- 6:38 PM Changeset in webkit [54395] by
-
- 6 edits2 adds in trunk
2010-02-04 Tony Chang <tony@chromium.org>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=25002
When inserting a new paragraph, avoid nesting empty divs. When
pasting near the end of a paragraph, this prevents each paste
command for getting nested one level deeper.
Three paste tests have been rebaselined since this causes the pasted
content to be outside the last div instead of inside. E.g.,
<div>foo<div>bar</div>[pasted content]</div> is now
<div>foo<div>bar</div></div><div>[pasted content]</div>
The new test verifies this behavior.
- editing/inserting/paragraph-outside-nested-divs-expected.txt: Added.
- editing/inserting/paragraph-outside-nested-divs.html: Added.
- platform/mac/editing/pasteboard/paste-text-012-expected.txt:
- platform/mac/editing/pasteboard/paste-text-013-expected.txt:
- platform/mac/editing/pasteboard/paste-text-017-expected.txt:
2010-02-04 Tony Chang <tony@chromium.org>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=25002
When inserting a new paragraph, avoid nesting empty divs. When
pasting near the end of a paragraph, this prevents each paste
command for getting nested one level deeper.
Test: editing/inserting/paragraph-outside-nested-divs.html
- editing/InsertParagraphSeparatorCommand.cpp: (WebCore::highestVisuallyEquivalentDiv): (WebCore::InsertParagraphSeparatorCommand::doApply):
- 6:31 PM Changeset in webkit [54394] by
-
- 15 edits1 add in trunk/JavaScriptCore
Add a JSStringBuilder class (similar-to, and derived-from StringBuilder) to
construct JSStrings, throwing a JS exception should we run out of memory whilst
allocating storage for the string.
Reviewed by Oliver Hunt.
Similarly, add jsMakeNontrivialString methods to use in cases where previously
we were calling makeString & passing the result to jsNontrivialString. Again,
these new methods throw if we hit an out of memory condition.
Move throwOutOfMemoryError into ExceptionHelpers, to make it more widely available.
- JavaScriptCore.xcodeproj/project.pbxproj:
- runtime/ArrayPrototype.cpp:
(JSC::arrayProtoFuncToString):
(JSC::arrayProtoFuncToLocaleString):
(JSC::arrayProtoFuncJoin):
- runtime/DateConstructor.cpp:
(JSC::callDate):
- runtime/DatePrototype.cpp:
(JSC::dateProtoFuncToString):
(JSC::dateProtoFuncToUTCString):
(JSC::dateProtoFuncToGMTString):
- runtime/ErrorPrototype.cpp:
(JSC::errorProtoFuncToString):
- runtime/ExceptionHelpers.cpp:
(JSC::throwOutOfMemoryError):
- runtime/ExceptionHelpers.h:
- runtime/JSStringBuilder.h: Added.
(JSC::JSStringBuilder::releaseJSString):
(JSC::jsMakeNontrivialString):
- runtime/NumberPrototype.cpp:
(JSC::numberProtoFuncToPrecision):
- runtime/ObjectPrototype.cpp:
(JSC::objectProtoFuncToString):
- runtime/Operations.cpp:
- runtime/Operations.h:
- runtime/RegExpPrototype.cpp:
(JSC::regExpProtoFuncToString):
- runtime/StringBuilder.h:
(JSC::StringBuilder::append):
- runtime/StringPrototype.cpp:
(JSC::stringProtoFuncBig):
(JSC::stringProtoFuncSmall):
(JSC::stringProtoFuncBlink):
(JSC::stringProtoFuncBold):
(JSC::stringProtoFuncFixed):
(JSC::stringProtoFuncItalics):
(JSC::stringProtoFuncStrike):
(JSC::stringProtoFuncSub):
(JSC::stringProtoFuncSup):
(JSC::stringProtoFuncFontcolor):
(JSC::stringProtoFuncFontsize):
(JSC::stringProtoFuncAnchor):
- 6:09 PM Changeset in webkit [54393] by
-
- 9 edits in trunk
WebCore: 1. Fix a bug in SQLiteTransaction: do not assume that COMMIT always
succeeds.
- Jump straight to the transaction error callback when a
statement fails in a way that makes sqlite automatically rollback
the transaction.
- Fix the code that handles the "quota reached" failure, as it is
one of the failures that lead to an automatic transaction
rollback.
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=34280
- platform/sql/SQLiteDatabase.cpp:
(WebCore::SQLiteDatabase::isAutoCommitOn):
- platform/sql/SQLiteDatabase.h:
- platform/sql/SQLiteTransaction.cpp:
(WebCore::SQLiteTransaction::begin):
(WebCore::SQLiteTransaction::commit):
(WebCore::SQLiteTransaction::rollback):
(WebCore::SQLiteTransaction::transactionWasRolledBackBySqlite):
- platform/sql/SQLiteTransaction.h:
- storage/SQLTransaction.cpp:
(WebCore::SQLTransaction::SQLTransaction):
(WebCore::SQLTransaction::runStatements):
(WebCore::SQLTransaction::runCurrentStatement):
(WebCore::SQLTransaction::handleCurrentStatementError):
(WebCore::SQLTransaction::deliverQuotaIncreaseCallback):
LayoutTests: 1. Enhance quota-tracking.html: if sqlite automatically rolls back
a transaction because of a statement failure, make sure the rest
of the statements in the transaction are not executed.
- Fix the expectations for quota-tracking.html. Sqlite cannot
recover from reaching a DB's max size.
Reviewed by Eric Seidel.
- storage/quota-tracking-expected.txt:
- storage/quota-tracking.html:
- 5:50 PM Changeset in webkit [54392] by
-
- 2 edits in trunk/WebCore
Not reviewed, rollback.
Rollback r54387, it doesn't fix builds and Chromium doesn't want this behavior.
- platform/chromium/ScrollbarThemeChromiumMac.h:
- 5:41 PM Changeset in webkit [54391] by
-
- 2 edits in trunk/JavaScriptCore
Windows build fix.
- wtf/MathExtras.h:
- 5:35 PM Changeset in webkit [54390] by
-
- 4 edits in branches/safari-4-branch
Versioning.
- 5:33 PM Changeset in webkit [54389] by
-
- 1 copy in tags/Safari-6531.22.6
New tag.
- 5:01 PM Changeset in webkit [54388] by
-
- 2 edits in trunk/JavaScriptCore
2010-02-04 Darin Adler <Darin Adler>
Reviewed by David Levin.
Make MathExtras.h compatible with <cmath>
https://bugs.webkit.org/show_bug.cgi?id=34618
- wtf/MathExtras.h: Include <cmath> instead of <math.h>. Use "using" as we do elsewhere in WTF for the four functions from <cmath> we want to use without the prefix. Later we could consider making the std explicit at call sites instead.
- 4:52 PM Changeset in webkit [54387] by
-
- 2 edits in trunk/WebCore
2010-02-04 Stephen White <senorblanco@chromium.org>
Unreviewed, build fix.
Fix for Chromium/Mac after palindromic scrollbar change (54345).
Covered by many layout tests.
- platform/chromium/ScrollbarThemeChromiumMac.h: (WebCore::ScrollbarThemeChromiumMac::maxOverlapBetweenPages):
- 4:35 PM Changeset in webkit [54386] by
-
- 2 edits in trunk/WebCore
2010-02-04 Clemmitt Sigler <cmsigler@gmail.com>
Reviewed by David Levin.
WebKitGTK doesn't build GtkLauncher when --enable-mathml is specified.
Updated WebCore/GNUmakefile.am to include needed files in build.
No new tests.
- GNUmakefile.am:
- 4:29 PM Changeset in webkit [54385] by
-
- 4 edits in branches/safari-4-branch
Versioning.
- 4:23 PM Changeset in webkit [54384] by
-
- 1 copy in tags/Safari-6531.22.5
New tag.
- 4:19 PM Changeset in webkit [54383] by
-
- 5 edits in trunk/WebCore
2010-02-04 Stephan Aßmus <superstippi@gmx.de>
Reviewed by David Levin.
Misc coding style fixes in Haiku port code.
https://bugs.webkit.org/show_bug.cgi?id=34527
No tests needed.
- platform/haiku/ContextMenuItemHaiku.cpp: Trailing white space, NULL -> 0
- platform/haiku/DragImageHaiku.cpp: Trailing white space.
- platform/haiku/FileChooserHaiku.cpp: Sorted headers.
- platform/haiku/LocalizedStringsHaiku.cpp: Needed to include NotImplemented.h
- 4:11 PM Changeset in webkit [54382] by
-
- 2 edits in branches/safari-4-branch/WebKit/win
Merge r54376.
- 3:50 PM Changeset in webkit [54381] by
-
- 2 edits in trunk/LayoutTests
Unreviewed typo fix for r54379.
- platform/qt/Skipped:
- 3:43 PM Changeset in webkit [54380] by
-
- 2 edits in trunk/WebKit/chromium
2010-02-04 Drew Wilson <atwilson@chromium.org>
Reviewed by David Levin.
WorkerContext.close() does not work in the chromium port
https://bugs.webkit.org/show_bug.cgi?id=34551
Test: Adding new downstream test.
- src/WebWorkerBase.cpp: (WebKit::WebWorkerBase::workerContextClosedTask): Now shuts down the worker thread when WorkerContext::close() is invoked.
- 3:36 PM Changeset in webkit [54379] by
-
- 3 edits in trunk/LayoutTests
editing/pasteboard/drop-inputtext-acquires-style.html
introduced in r54368 skipped because of missing DnD support.
- platform/gtk/Skipped:
- platform/qt/Skipped:
- 3:33 PM Changeset in webkit [54378] by
-
- 3 edits in trunk/WebKit/gtk
2010-02-04 Christian Dywan <christian@twotoasts.de>
Reviewed by Gustavo Noronha Silva.
[GTK] Add and cleanup return values of signals in view and frame
https://bugs.webkit.org/show_bug.cgi?id=33484
Add missing and cleanup return values of web frame and web view signals.
- webkit/webkitwebframe.cpp: (webkit_web_frame_class_init):
- webkit/webkitwebview.cpp: (DNDContentsRequest::webkit_web_view_class_init):
- 3:30 PM Changeset in webkit [54377] by
-
- 2 edits in trunk/WebCore
Fixed crash on QT introduced with the fix for
https://bugs.webkit.org/show_bug.cgi?id=34609
Reviewed by Csaba Osztrogonac.
The test has been added with the original patch.
- platform/qt/ClipboardQt.cpp:
(WebCore::ClipboardQt::writePlainText): Added missing allocation of m_writeData.
- 3:29 PM Changeset in webkit [54376] by
-
- 2 edits in trunk/WebKit/win
https://bugs.webkit.org/show_bug.cgi?id=34612 " MSAA: accSelect returns error
codes for most elements that arent listbox or menupopup related"
<rdar://problem/7436861>
Reviewed by Jon Honeycutt.
- AccessibleBase.cpp:
(AccessibleBase::accSelect):
- Stop sending E_INVALIDARG for elements that request TAKE_SELECTION that aren't beneath listboxes or menupopups. This was too restrictive since any element can be selectable.
- Correct the misinterpretation of MSDN's stipulation of situations involving adding, removing, and extending selection on single-select elements
- 2:51 PM Changeset in webkit [54375] by
-
- 7 edits in trunk
2010-02-04 Christian Dywan <christian@twotasts.de>
Reviewed by Xan Lopez.
Require either libsoup 2.28.2 or 2.29.90.
- configure.ac:
2010-02-04 Christian Dywan <christian@twotoasts.de>
Reviewed by Xan Lopez.
Conditionalize third party cookie policy for libsoup 2.29.90.
- platform/network/soup/CookieJarSoup.cpp: (WebCore::setCookies):
- platform/network/soup/DNSSoup.cpp: (WebCore::prefetchDNS):
- platform/network/soup/ResourceHandleSoup.cpp: (WebCore::restartedCallback): (WebCore::startHttp):
- platform/network/soup/ResourceRequestSoup.cpp: (WebCore::ResourceRequest::toSoupMessage): (WebCore::ResourceRequest::updateFromSoupMessage):
- 2:50 PM Changeset in webkit [54374] by
-
- 2 edits in trunk/WebCore
2010-02-04 Christian Dywan <christian@twotoasts.de>
Rubber-stamped by Gustavo Noronha Silva.
Add ENABLE(VIDEO) guards around freeOwnedGPtr<GstElement> implementation.
- platform/gtk/GOwnPtrGtk.cpp:
- 2:35 PM Changeset in webkit [54373] by
-
- 1 edit in trunk/WebCore/ChangeLog
Correct a mistake in ChangeLog entry.
- 2:12 PM Changeset in webkit [54372] by
-
- 4 edits2 adds in trunk
Reviewed by Darin Adler.
Assertion failure in CheckedRadioButtons::removeButton when using jQuery 1.4.1
https://bugs.webkit.org/show_bug.cgi?id=34520
Test: fast/dom/HTMLInputElement/cloned-input-checked-state.html
- dom/Element.cpp: (WebCore::Element::cloneElementWithoutChildren): Copy non-attribute properties before attributes. Otherwise, copying "checked" property would make the cloned node checked, unchecking original (they share a name, and are thus in the same radio group). We do want the original to be unchecked, but we also want to know its original state in HTMLInputElement::copyNonAttributeProperties().
- html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::copyNonAttributeProperties): Use setChecked instead of plain assignment to prevent m_checked getting out of sync with checkedRadioButtons. Also, copy field related to default checked state, so that m_checked won't be overridden when copying attributes.
- 2:12 PM Changeset in webkit [54371] by
-
- 3 edits in trunk/WebCore
[wx] Build fix after addition of Clipboard::writePlainText method.
- 2:10 PM Changeset in webkit [54370] by
-
- 2 edits in trunk/WebKit/win
Properly handle margin settings when printing Plugins in WinCairo.
https://bugs.webkit.org/show_bug.cgi?id=34613
Reviewed by Adam Roben.
- WebFrame.cpp:
(WebFrame::spoolPage): Adjust the GraphicsContext passed to the
paintContents method so that the World Transform is properly
positioned to account for margin settings at the time that
PluginViewWin.cpp processes the drawing operations.
- 2:07 PM Changeset in webkit [54369] by
-
- 2 edits in trunk/WebKitLibraries
Update auto-version.sh to better handle major version numbers with fewer than three digits,
and the case when WEBKITLIBRARIESDIR is not set.
Reviewed by Steve Falkenburg.
- win/tools/scripts/auto-version.sh:
- 1:50 PM Changeset in webkit [54368] by
-
- 23 edits2 adds in trunk
REGRESSION: Dragging plain text into a styled text region does not acquire the correct style info.
<rdar://problem/7595685>
https://bugs.webkit.org/show_bug.cgi?id=34609
Reviewed by Oliver Hunt.
WebCore:
Test: editing/pasteboard/drop-inputtext-acquires-style.html
The dragging code did not distinguish the case of dragging the content of an input control
as a special case. The markup placed in the pasteboard included the style information.
I've modified the Clipboard class interface adding a new method writePlainText to match the
behavior of the copy and cut commands and modified the drag code to detect the special case.
I've modified all the platform specific implementations of the Clipboard class.
- dom/Clipboard.h: Added writePlainText pure virtual function.
- editing/Editor.cpp:
(WebCore::Editor::cut): Renamed nodeIsTextFormControl to isNodeInTextFormControl.
(WebCore::Editor::copy): Renamed nodeIsTextFormControl to isNodeInTextFormControl.
- editing/htmlediting.cpp:
(WebCore::isNodeInTextFormControl): Added, after removing the implementation with the old name
in Editor.cpp
- editing/htmlediting.h:
- page/DragController.cpp:
(WebCore::DragController::startDrag):
- platform/Pasteboard.h:
- platform/android/ClipboardAndroid.cpp:
(WebCore::ClipboardAndroid::writePlainText): Added.
- platform/android/ClipboardAndroid.h:
- platform/chromium/ClipboardChromium.cpp:
(WebCore::ClipboardChromium::writePlainText): Added.
- platform/chromium/ClipboardChromium.h:
- platform/gtk/ClipboardGtk.cpp:
(WebCore::ClipboardGtk::writePlainText): Added.
- platform/gtk/ClipboardGtk.h:
- platform/haiku/ClipboardHaiku.cpp:
(WebCore::ClipboardHaiku::writePlainText): Added.
- platform/haiku/ClipboardHaiku.h:
- platform/mac/ClipboardMac.h:
- platform/mac/ClipboardMac.mm:
(WebCore::ClipboardMac::writePlainText): Added.
- platform/mac/PasteboardMac.mm:
(WebCore::Pasteboard::writePlainText): Added helper function.
- platform/qt/ClipboardQt.cpp:
(WebCore::ClipboardQt::writePlainText): Added.
- platform/qt/ClipboardQt.h:
- platform/win/ClipboardWin.cpp:
(WebCore::ClipboardWin::writePlainText): Added.
- platform/win/ClipboardWin.h:
LayoutTests:
- editing/pasteboard/drop-inputtext-acquires-style-expected.txt: Added.
- editing/pasteboard/drop-inputtext-acquires-style.html: Added.
- 1:45 PM Changeset in webkit [54367] by
-
- 3 edits1 move in trunk/WebKit
https://bugs.webkit.org/show_bug.cgi?id=34611
WebLocalizedString() could use an assertion that it is being called on the main thread
Reviewed by Tim Hatcher.
WebKit:
- WebKit.xcodeproj/project.pbxproj:
Updated for renamed file (WebLocalizableStrings.m -> WebLocalizableStrings.mm)
WebKit/mac:
- Misc/WebLocalizableStrings.m: Removed.
- Misc/WebLocalizableStrings.mm: Copied from mac/Misc/WebLocalizableStrings.m.
Renamed to use .mm extension so it can include a C++ header.
(WebLocalizedString):
Added an assertion that this is being called on the main thread.
- 1:19 PM Changeset in webkit [54366] by
-
- 2 edits in trunk/WebCore
2010-02-04 Steve Block <steveblock@google.com>
Reviewed by Nate Chapin.
Fix bug in V8 convertNPVariantToJValue when converting float and double types
https://bugs.webkit.org/show_bug.cgi?id=34593
No new tests, build fix only.
- bridge/jni/v8/JNIUtilityPrivate.cpp: Modified. (JSC::Bindings::convertNPVariantToJValue): Modified. Use correct members of 'result' enum.
- 1:11 PM Changeset in webkit [54365] by
-
- 1 copy in releases/WebKitGTK/webkit-1.1.20
Tagging 1.1.20.
- 12:16 PM Changeset in webkit [54364] by
-
- 7 edits in trunk
2010-02-04 Chris Guillory <chris.guillory@google.com>
Reviewed by Darin Fisher.
[Chromium] Notify ChromeClientChromium of AccessibilityObject state
change notifications.
- accessibility/chromium/AXObjectCacheChromium.cpp: (WebCore::toChromeClientChromium): (WebCore::AXObjectCache::postPlatformNotification):
- page/chromium/ChromeClientChromium.h:
- 12:10 PM Changeset in webkit [54363] by
-
- 2 edits in trunk/WebKit/chromium
2010-02-04 Jeremy Moskovich <jeremy@chromium.org>
Reviewed by Darin Fisher.
Update comments to better document the possible values of the
writing direction menu state variables.
- public/WebContextMenuData.h:
- 12:09 PM Changeset in webkit [54362] by
-
- 5 edits in trunk/JavaScriptCore
Use an easily appendable structure for trampolines instead of pointer parameters.
https://bugs.webkit.org/show_bug.cgi?id=34424
Patch by Tamas Szirbucz <szirbucz@inf.u-szeged.hu> on 2010-02-04
Reviewed by Gavin Barraclough.
- assembler/ARMAssembler.cpp:
(JSC::ARMAssembler::executableCopy):
- jit/JIT.h:
(JSC::JIT::compileCTIMachineTrampolines):
- jit/JITOpcodes.cpp:
(JSC::JIT::privateCompileCTIMachineTrampolines):
- jit/JITStubs.cpp:
(JSC::JITThunks::JITThunks):
- jit/JITStubs.h:
(JSC::JITThunks::ctiStringLengthTrampoline):
(JSC::JITThunks::ctiVirtualCallLink):
(JSC::JITThunks::ctiVirtualCall):
(JSC::JITThunks::ctiNativeCallThunk):
- 12:05 PM Changeset in webkit [54361] by
-
- 6 edits in trunk/WebCore
2010-02-04 Stephen White <senorblanco@chromium.org>
Unreviewed, build fix for Chromium.
Revert r54341 ("[v8] Remove clear method from DOM object maps"),
since it causes the worker tests to fail on Chromium.
- bindings/v8/DOMData.h: (WebCore::DOMData::removeObjectsFromWrapperMap):
- bindings/v8/DOMDataStore.h: (WebCore::ChunkedTable::clear): (WebCore::ChunkedTable::clearEntries): (WebCore::DOMDataStore::IntrusiveDOMWrapperMap::clear): (WebCore::DOMDataStore::IntrusiveDOMWrapperMap::ChunkedTableTraits::clear):
- bindings/v8/V8DOMMap.cpp: (WebCore::removeAllDOMObjectsInCurrentThreadHelper): (WebCore::removeAllDOMObjectsInCurrentThread):
- bindings/v8/V8DOMMap.h: (WebCore::WeakReferenceMap::clear):
- bindings/v8/WorkerScriptController.cpp: (WebCore::WorkerScriptController::~WorkerScriptController):
- 11:39 AM Changeset in webkit [54360] by
-
- 2 edits in trunk/WebKit/wx
Build fix after changes in r54345.
- 11:29 AM Changeset in webkit [54359] by
-
- 5 edits in trunk
2010-02-04 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Xan Lopez.
[GTK] Crashes when an invalid hostname is pre-fetched
https://bugs.webkit.org/show_bug.cgi?id=34602
- http/tests/misc/dns-prefetch-control-expected.txt:
- http/tests/misc/dns-prefetch-control.html: Add broken hostname test case.
2010-02-04 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Xan Lopez.
[GTK] Crashes when an invalid hostname is pre-fetched
https://bugs.webkit.org/show_bug.cgi?id=34602
- platform/network/soup/DNSSoup.cpp: (WebCore::prefetchDNS): NULL-check the SoupURI that is created from the hostname; that will happen for invalid hostnames.
- 11:10 AM Changeset in webkit [54358] by
-
- 1 edit1 add in trunk/LayoutTests
Rubber-stamped by Dan Bernstein.
Add Windows expected results to the new scrollbar test because Windows was trying
to compare to platform/mac first instead of cross-platform.
- platform/win/fast/events/scrollbar-double-click-expected.txt: Added.
- 10:52 AM Changeset in webkit [54357] by
-
- 4 edits in trunk/WebKitTools
Rubberstamped by Oliver Hunt.
[Qt] QtLauncher cleanup.
Refactor option handling out in utility functions and make the
arguments more Qt compatible.
- QtLauncher/main.cpp:
(requiresGraphicsView):
(LauncherApplication::handleUserOptions):
- QtLauncher/utils.cpp:
(takeOptionValue):
(formatKeys):
(enumToKeys):
(appQuit):
- QtLauncher/utils.h:
- 10:42 AM Changeset in webkit [54356] by
-
- 2 edits in trunk/WebKit/win
Properly handle margin settings in WinCairo.
https://bugs.webkit.org/show_bug.cgi?id=34545
Reviewed by Adam Roben.
- WebFrame.cpp:
(scaleFactor): Require the margin information as an input
parameter, and use them when computing the scaling factor.
(WebFrame::drawHeader): Pass margin size to scaleFactor.
(WebFrame::drawFooter): Pass margin size to scaleFactor.
(WebFrame::spoolPage):
- Pass margin size to scaleFactor.
- Recognize that the return value of printerMarginRect is already in device units, and therefore scale it so that the Cairo drawing is correct.
- Remove scaling call for margins in GDI code, as it is already in scaled units.
- 10:35 AM Changeset in webkit [54355] by
-
- 2 edits in trunk/WebCore
2010-02-04 José Millán Soto <jmillan@igalia.com>
Reviewed by Xan Lopez.
[Gtk] webkitgtk crashed when Orca open
https://bugs.webkit.org/show_bug.cgi?id=34463
- accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (textForObject): Checking if render objects are texts before calling toRenderText
- 10:21 AM Changeset in webkit [54354] by
-
- 2 edits in tags/Safari-532.8.1/WebKitLibraries
Merge r54348.
- 10:18 AM Changeset in webkit [54353] by
-
- 4 edits in tags/Safari-532.8.1
Versioning.
- 10:09 AM Changeset in webkit [54352] by
-
- 6 edits in trunk
2010-02-04 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
Bump minimum libsoup requirement to 2.29.90
- configure.ac:
WebCore:
2010-02-04 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
Set first party URI in all SoupMessages. This allows libsoup to
implement a "no third party cookies" policy in case it wants
to. Also start a non-JSC-specific, gtk-specific GOwnPtr module and
use it for SoupURI.
- platform/network/soup/CookieJarSoup.cpp: (WebCore::setCookies):
- platform/network/soup/ResourceHandleSoup.cpp: (WebCore::restartedCallback): (WebCore::startHttp):
- platform/network/soup/ResourceRequestSoup.cpp: (WebCore::ResourceRequest::toSoupMessage): (WebCore::ResourceRequest::updateFromSoupMessage):
- 10:06 AM Changeset in webkit [54351] by
-
- 3 edits in trunk/WebCore
2010-02-04 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: group cookies by domains, not frame's domains.
- inspector/front-end/CookieItemsView.js: (WebInspector.CookieItemsView.prototype._cookiesForDomain):
- inspector/front-end/inspector.js: (WebInspector.updateResource): (WebInspector._addCookieDomain):
- 10:03 AM Changeset in webkit [54350] by
-
- 1 copy in tags/Safari-532.8.1
New tag.
- 10:01 AM Changeset in webkit [54349] by
-
- 61 edits in trunk
2010-02-04 Nate Chapin <Nate Chapin>
Reviewed by Dimitri Glazkov.
[V8] Delete V8CustomBinding.h and all references to V8Custom
- bindings/v8/NPV8Object.cpp:
- bindings/v8/V8DOMWindowShell.h:
- bindings/v8/V8NPObject.cpp:
- bindings/v8/V8Utilities.cpp:
- bindings/v8/custom/V8AbstractWorkerCustom.cpp:
- bindings/v8/custom/V8AttrCustom.cpp:
- bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp:
- bindings/v8/custom/V8CanvasRenderingContext2DCustom.cpp:
- bindings/v8/custom/V8ClipboardCustom.cpp:
- bindings/v8/custom/V8CoordinatesCustom.cpp:
- bindings/v8/custom/V8CustomBinding.h: Removed.
- bindings/v8/custom/V8DOMApplicationCacheCustom.cpp:
- bindings/v8/custom/V8DOMWindowCustom.cpp:
- bindings/v8/custom/V8DataGridColumnListCustom.cpp:
- bindings/v8/custom/V8DatabaseCustom.cpp:
- bindings/v8/custom/V8ElementCustom.cpp:
- bindings/v8/custom/V8EventSourceConstructor.cpp:
- bindings/v8/custom/V8EventSourceCustom.cpp:
- bindings/v8/custom/V8GeolocationCustom.cpp:
- bindings/v8/custom/V8HTMLAllCollectionCustom.cpp:
- bindings/v8/custom/V8HTMLAudioElementConstructor.cpp: (WebCore::v8HTMLAudioElementConstructorCallback): (WebCore::V8HTMLAudioElementConstructor::GetTemplate):
- bindings/v8/custom/V8HTMLCollectionCustom.cpp:
- bindings/v8/custom/V8HTMLDataGridElementCustom.cpp:
- bindings/v8/custom/V8HTMLFrameElementCustom.cpp:
- bindings/v8/custom/V8HTMLIFrameElementCustom.cpp:
- bindings/v8/custom/V8HTMLImageElementConstructor.cpp: (WebCore::v8HTMLImageElementConstructorCallback): (WebCore::V8HTMLImageElementConstructor::GetTemplate):
- bindings/v8/custom/V8HTMLInputElementCustom.cpp:
- bindings/v8/custom/V8HTMLOptionElementConstructor.cpp: (WebCore::v8HTMLOptionElementConstructorCallback): (WebCore::V8HTMLOptionElementConstructor::GetTemplate):
- bindings/v8/custom/V8HTMLPlugInElementCustom.cpp:
- bindings/v8/custom/V8HistoryCustom.cpp:
- bindings/v8/custom/V8InspectorFrontendHostCustom.cpp:
- bindings/v8/custom/V8LocationCustom.cpp:
- bindings/v8/custom/V8MessagePortCustom.cpp:
- bindings/v8/custom/V8NodeCustom.cpp:
- bindings/v8/custom/V8NodeFilterCustom.cpp:
- bindings/v8/custom/V8SQLResultSetRowListCustom.cpp:
- bindings/v8/custom/V8SQLTransactionCustom.cpp:
- bindings/v8/custom/V8SVGElementInstanceCustom.cpp:
- bindings/v8/custom/V8SVGLengthCustom.cpp:
- bindings/v8/custom/V8SharedWorkerCustom.cpp:
- bindings/v8/custom/V8StorageCustom.cpp:
- bindings/v8/custom/V8WebGLArrayBufferCustom.cpp:
- bindings/v8/custom/V8WebGLArrayCustom.h:
- bindings/v8/custom/V8WebGLByteArrayCustom.cpp:
- bindings/v8/custom/V8WebGLFloatArrayCustom.cpp:
- bindings/v8/custom/V8WebGLIntArrayCustom.cpp:
- bindings/v8/custom/V8WebGLShortArrayCustom.cpp:
- bindings/v8/custom/V8WebGLUnsignedByteArrayCustom.cpp:
- bindings/v8/custom/V8WebGLUnsignedIntArrayCustom.cpp:
- bindings/v8/custom/V8WebGLUnsignedShortArrayCustom.cpp:
- bindings/v8/custom/V8WebKitPointConstructor.cpp:
- bindings/v8/custom/V8WorkerContextCustom.cpp:
- bindings/v8/custom/V8WorkerCustom.cpp:
- bindings/v8/custom/V8XMLHttpRequestConstructor.cpp:
- bindings/v8/custom/V8XMLHttpRequestCustom.cpp:
- bindings/v8/custom/V8XMLHttpRequestUploadCustom.cpp:
- 9:56 AM Changeset in webkit [54348] by
-
- 2 edits in trunk/WebKitLibraries
Windows build fix for projects not defining WebKitLibrariesDir.
- 9:43 AM Changeset in webkit [54347] by
-
- 2 edits in trunk/WebCore
2010-02-04 Ariya Hidayat <ariya.hidayat@gmail.com>
Reviewed by Simon Hausmann.
[Qt] Unnecessary QBrush construction for doing a solid fill
https://bugs.webkit.org/show_bug.cgi?id=34559
Use the similar trick like r37421, i.e. use the special brush for
solid color to avoid creating QBrush again and again.
- platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::setPlatformFillColor):
- 9:41 AM Changeset in webkit [54346] by
-
- 1 edit1 add in trunk/LayoutTests
REGRESSION (r53718): When scrolling a tall window by page, the overlap between pages is too big
https://bugs.webkit.org/show_bug.cgi?id=34371
Reviewed by Simon Fraser.
- platform/mac/fast/events/scrollbar-double-click-expected.txt: Added.
- 9:35 AM Changeset in webkit [54345] by
-
- 18 edits in trunk
REGRESSION (r53718): When scrolling a tall window by page, the overlap between pages is too big
https://bugs.webkit.org/show_bug.cgi?id=34371
Reviewed by Simon Fraser.
WebCore:
Allow ScrollbarTheme to cap the overlap between pages, and set a cap of
40 in ScrollbarThemeMac.
- WebCore.base.exp: Export Scrollbar::maxOverlapBetweenPages().
- editing/EditorCommand.cpp:
(WebCore::verticalScrollDistance): Use Scrollbar methods instead of
constants, and cap the scroll distance if needed.
- platform/ScrollView.cpp:
(WebCore::ScrollView::updateScrollbars): Ditto.
(WebCore::ScrollView::wheelEvent): Ditto.
- platform/Scrollbar.cpp:
(WebCore::Scrollbar::maxOverlapBetweenPages): Added. Returns the
value from the native scrollbar theme.
- platform/Scrollbar.h: Replaced scroll amount constants with static methods.
(WebCore::Scrollbar::pixelsPerLineStep): Replaces cScrollbarPixelsPerLineStep.
(WebCore::Scrollbar::minFractionToStepWhenPaging): Replaces cFractionToStepWhenPaging.
- platform/ScrollbarTheme.h:
(WebCore::ScrollbarTheme::maxOverlapBetweenPages): A base implementation
that returns the largest int.
- platform/gtk/WheelEventGtk.cpp:
(WebCore::PlatformWheelEvent::PlatformWheelEvent): Use Scrollbar methods instead of
constants.
- platform/haiku/PlatformWheelEventHaiku.cpp:
(WebCore::PlatformWheelEvent::PlatformWheelEvent): Use Scrollbar methods instead of
constants.
- platform/mac/ScrollbarThemeMac.h:
(WebCore::ScrollbarThemeMac::maxOverlapBetweenPages): An override
that returns 40.
- platform/mac/WheelEventMac.mm:
(WebCore::PlatformWheelEvent::PlatformWheelEvent): Use
Scrollbar::pixelsPerLineStep() instead of cScrollbarPixelsPerLineStep.
- platform/wx/MouseWheelEventWx.cpp:
(WebCore::PlatformWheelEvent::PlatformWheelEvent): Use Scrollbar methods instead of
constants.
- platform/wx/ScrollViewWx.cpp:
(WebCore::ScrollView::ScrollViewPrivate::OnScrollWinEvents): Use Scrollbar
methods instead of constants, and cap the scroll distance if needed.
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::updateScrollInfoAfterLayout): Ditto.
WebKit/mac:
- WebView/WebFrameView.mm:
(-[WebFrameView _verticalPageScrollDistance]): Use Scrollbar methods instead of
constants, and cap the scroll distance.
(-[WebFrameView initWithFrame:]): Use Scrollbar::pixelsPerLineStep() instead of
cScrollbarPixelsPerLineStep.
(-[WebFrameView _horizontalPageScrollDistance]):Use Scrollbar methods instead of
constants, and cap the scroll distance.
WebKit/wx:
- WebView.cpp:
(wxWebView::OnKeyEvents): Use Scrollbar method instead of constant.
- 8:56 AM Changeset in webkit [54344] by
-
- 4 edits in trunk
2010-02-04 No'am Rosenthal <noam.rosenthal@nokia.com>
Reviewed by Ariya Hidayat.
[Qt] Tuning and optimizations to GraphicsLayerQt. Reduce unnecessary
recaching, remove QTimer::singleShot and QPixmap::scaled, more
accurate strategy of handling transform operation blends. Rotating a
bordered-table, for example, now runs at 50FPS instead of 40FPS on Maemo5.
This is tested by https://bugs.webkit.org/show_bug.cgi?id=34450, fps measurements.
- platform/graphics/qt/GraphicsLayerQt.cpp: (WebCore::GraphicsLayerQtImpl::flushChanges): Fine-tune caching (WebCore::TransformAnimationQt::TransformAnimationQt): transform bugs (WebCore::OpacityAnimationQt::updateState): style change
2010-02-04 No'am Rosenthal <noam.rosenthal@nokia.com>
Reviewed by Ariya Hidayat.
[Qt] Tuning and optimizations to GraphicsLayerQt. Mainly reduced usage
of QTimer::singleShot, and moved syncLayers() from paint() to update()
https://bugs.webkit.org/show_bug.cgi?id=34062
- Api/qgraphicswebview.cpp: (QGraphicsWebViewPrivate::update): Moved the sync operation to update (QGraphicsWebView::paint): Moved the sync operation to update
- 8:39 AM Changeset in webkit [54343] by
-
- 4 edits in trunk/WebCore
2010-02-04 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: Cookies for resources are not shown in storage panel.
- inspector/InspectorController.cpp: (WebCore::InspectorController::getCookies):
- inspector/InspectorResource.cpp: (WebCore::InspectorResource::updateScriptObject): (WebCore::InspectorResource::cachedResource):
- inspector/InspectorResource.h: (WebCore::InspectorResource::requestURL):
- 6:52 AM Changeset in webkit [54342] by
-
- 3 edits in trunk/WebKitTools
2010-02-04 Andras Becsi <abecsi@inf.u-szeged.hu>
Reviewed by Tor Arne Vestbø.
Implement a locking and scheduling mechanism for http testing sessions to be able
to run multiple instances of run-webkit-tests parallel on the same machine.
If a test session wants to run http tests and this feature is enabled, the pending
sessions create lockfiles with sequential lock numbers. These locks are used to schedule
the running test sessions in first come first served order. An exclusive lock ensures
that the lock numbers are sequential to avoid deadlocks and starvation.
Because the buildbot master specifies the flags used by slaves we need an environment
variable too to be able to use the feature per-slave.
Exporting WEBKIT_WAIT_FOR_HTTPD=1 before testing or using the --wait-for-httpd
flag enables this feature, otherwise this patch has no effect on the testing whatsoever.
- 4:57 AM Changeset in webkit [54341] by
-
- 6 edits in trunk/WebCore
2010-02-04 Anton Muhin <antonm@chromium.org>
Reviewed by Adam Barth.
[v8] Remove clear method from DOM object maps
https://bugs.webkit.org/show_bug.cgi?id=34530
No new tests. Should be covered by existent testing infrastructure.
- bindings/v8/DOMData.h:
- bindings/v8/DOMDataStore.h:
- bindings/v8/V8DOMMap.cpp:
- bindings/v8/V8DOMMap.h:
- bindings/v8/WorkerScriptController.cpp: (WebCore::WorkerScriptController::~WorkerScriptController):
- 3:15 AM Changeset in webkit [54340] by
-
- 3 edits2 adds in trunk/JavaScriptCore
2010-02-04 Jedrzej Nowacki <jedrzej.nowacki@nokia.com>
Reviewed by Simon Hausmann.
Increase test coverage for the QScriptValue.
- qt/tests/qscriptvalue/qscriptvalue.pro:
- qt/tests/qscriptvalue/tst_qscriptvalue.cpp: (tst_QScriptValue::tst_QScriptValue): (tst_QScriptValue::~tst_QScriptValue): (tst_QScriptValue::dataHelper): (tst_QScriptValue::newRow): (tst_QScriptValue::testHelper): (tst_QScriptValue::ctor):
- qt/tests/qscriptvalue/tst_qscriptvalue.h: Added.
- qt/tests/qscriptvalue/tst_qscriptvalue_generated.cpp: Added. (tst_QScriptValue::initScriptValues): (tst_QScriptValue::isValid_initData): (tst_QScriptValue::isValid_makeData): (tst_QScriptValue::isValid_test): (tst_QScriptValue::isBool_initData): (tst_QScriptValue::isBool_makeData): (tst_QScriptValue::isBool_test): (tst_QScriptValue::isBoolean_initData): (tst_QScriptValue::isBoolean_makeData): (tst_QScriptValue::isBoolean_test): (tst_QScriptValue::isFunction_initData): (tst_QScriptValue::isFunction_makeData): (tst_QScriptValue::isFunction_test): (tst_QScriptValue::isNull_initData): (tst_QScriptValue::isNull_makeData): (tst_QScriptValue::isNull_test): (tst_QScriptValue::isString_initData): (tst_QScriptValue::isString_makeData): (tst_QScriptValue::isString_test): (tst_QScriptValue::isUndefined_initData): (tst_QScriptValue::isUndefined_makeData): (tst_QScriptValue::isUndefined_test): (tst_QScriptValue::isObject_initData): (tst_QScriptValue::isObject_makeData): (tst_QScriptValue::isObject_test):
- 2:55 AM Changeset in webkit [54339] by
-
- 3 edits in trunk/WebKitTools
Make run-webkit-tests work under Cygwin for the Qt port
Reviewed by Simon Hausmann.
setPathForRunningWebKitApp() is implemented for the Qt port
by using qmake to query for the location of the Qt libraries.
This requires the original environment (%ENV) to be untouched,
so launchWithCurrentEnv() was refactored to launchWithEnv(),
and the code in openDumpTool() to not use %ENV but a %CLEAN_ENV
instead. This has the added benefit of getting rid of the temp
variables used for storing the current env.
openDumpTool() is also refactored a bit into platform-spesific,
port-spesific, and generic environment variables.
Checks for undef was added a few places to fix Perl concat
warnings when run-webkit-tests is aborted.
https://bugs.webkit.org/show_bug.cgi?id=33895
- Scripts/run-webkit-tests:
- Scripts/webkitdirs.pm:
- 2:50 AM Changeset in webkit [54338] by
-
- 2 edits in trunk/LayoutTests
[Qt] fast/workers/shared-worker-frame-lifecycle.html failed on Qt Bot
https://bugs.webkit.org/show_bug.cgi?id=34281
- platform/qt/Skipped: fast/workers/shared-worker-frame-lifecycle.html skipped until fix.
- 2:50 AM Changeset in webkit [54337] by
-
- 2 edits in trunk/WebCore
[Gtk] Check if the renderer() exists in textForObject.
This is fixing a crash in the textForObject method. It can
happen when inspecting AtkObjects in the accerciser, then
navigating to a new page and still inspecting the old tree.
In this case the AccessibilityObjectWrapperAtk was still
valid but the included renderer() was returning 0. Add a
check for the accObject->renderer() before trying to use
the result.
- accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
(textForObject):
- 2:20 AM Changeset in webkit [54336] by
-
- 2 edits in trunk/WebKitTools
2010-02-04 Yuzo Fujishima <yuzo@google.com>
Unreviewed.
Add Yuzo to the committers list.
- Scripts/webkitpy/committers.py:
- 2:06 AM Changeset in webkit [54335] by
-
- 2 edits2 deletes in trunk/WebKit/chromium
2010-02-04 Yury Semikhatsky <yurys@chromium.org>
Unreviewed. Revert 54333 which broke Chromium build.
- WebKit.gyp:
- tests/TransparencyWinTest.cpp: Removed.
- tests/UniscribeHelperTest.cpp: Removed.
- 1:38 AM Changeset in webkit [54334] by
-
- 15 edits2 adds in trunk/WebCore
2010-02-04 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Provide strongly typed C++ interface for inspector's injected script.
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSInjectedScriptHostCustom.cpp: (WebCore::InjectedScriptHost::injectedScriptFor):
- bindings/v8/custom/V8InjectedScriptHostCustom.cpp: (WebCore::InjectedScriptHost::injectedScriptFor):
- inspector/InjectedScript.cpp: Added. (WebCore::InjectedScript::InjectedScript): (WebCore::InjectedScript::dispatch): (WebCore::InjectedScript::callFrames): (WebCore::InjectedScript::wrapAndStringifyForConsole): (WebCore::InjectedScript::releaseWrapperObjectGroup):
- inspector/InjectedScript.h: Added. (WebCore::InjectedScript::InjectedScript): (WebCore::InjectedScript::~InjectedScript): (WebCore::InjectedScript::hasNoValue):
- inspector/InjectedScriptHost.cpp: (WebCore::InjectedScriptHost::injectedScriptForId): (WebCore::InjectedScriptHost::releaseWrapperObjectGroup):
- inspector/InjectedScriptHost.h:
- inspector/InspectorBackend.cpp: (WebCore::InspectorBackend::dispatchOnInjectedScript):
- inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController): (WebCore::InspectorController::~InspectorController): (WebCore::InspectorController::inspectedPageDestroyed): (WebCore::InspectorController::windowScriptObjectAvailable): (WebCore::InspectorController::scriptObjectReady): (WebCore::InspectorController::setFrontendProxyObject): (WebCore::InspectorController::close): (WebCore::InspectorController::getProfile): (WebCore::InspectorController::enableDebugger): (WebCore::InspectorController::didPause): (WebCore::InspectorController::injectedScriptForNodeId):
- inspector/InspectorController.h: (WebCore::InspectorController::frontendScriptState):
- inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::addConsoleMessage):
- inspector/front-end/InjectedScript.js: (injectedScriptConstructor):
- 1:16 AM Changeset in webkit [54333] by
-
- 2 edits2 adds in trunk/WebKit/chromium
2010-02-04 Yaar Schnitman <yaar@chromium.org>
Reviewed by Darin Fisher.
Upstreaming gtests from chromium: UniscribeHelper and TransparencyWin.
https://bugs.webkit.org/show_bug.cgi?id=34509
- WebKit.gyp:
- tests/TransparencyWinTest.cpp: Added. (WebCore::RECTToFloatRect): (WebCore::drawNativeRect): (WebCore::getPixelAt): (WebCore::clearTopLayerAlphaChannel): (WebCore::clearTopLayerAlphaPixel): (WebCore::operator<<): (WebCore::TEST):
- tests/UniscribeHelperTest.cpp: Added. (WebCore::UniscribeTest::UniscribeTest): (WebCore::UniscribeTest::MakeFont): (WebCore::UniscribeTest::SetUp): (WebCore::UniscribeTest::TearDown): (WebCore::TEST_F):
- 1:11 AM Changeset in webkit [54332] by
-
- 2 edits in trunk/WebCore
2010-02-04 Philippe Normand <pnormand@igalia.com>
Rubber stamped by Xan Lopez.
Missing include, build fix after landing of patch from the bug 34435.
- platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
- 12:41 AM Changeset in webkit [54331] by
-
- 3 edits in trunk/WebKit/chromium
2010-02-04 Jeremy Moskovich <jeremy@chromium.org>
Reviewed by David Levin.
[Chromium] WebKit side of "Writing direction" context menu on OS X.
https://bugs.webkit.org/show_bug.cgi?id=34524
- public/WebContextMenuData.h: (WebKit::WebContextMenuData::):
- src/ContextMenuClientImpl.cpp: (WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems):
- 12:32 AM Changeset in webkit [54330] by
-
- 3 edits2 adds in trunk/WebCore
2010-02-02 Philippe Normand <pnormand@igalia.com>
Reviewed by Gustavo Noronha Silva.
[Gtk] libsoup critical warning in media player http cookies injection code
https://bugs.webkit.org/show_bug.cgi?id=34435
Fixed the critical warning and refactored the
User-Agent/Referer/cookies injection code, in that order. Previous
order (cookies first) was wrong because if cookies injection could
not be done neither the User-Agent nor Referer were injected. Also
started a non-JSC-specific, gtk-specific GOwnPtr module.
- GNUmakefile.am:
- platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::mediaPlayerPrivateSourceChangedCallback):
- platform/gtk/GOwnPtrGtk.cpp: Added. (WTF::SoupURI): (WTF::GstElement):
- platform/gtk/GOwnPtrGtk.h: Added.
- 12:25 AM Changeset in webkit [54329] by
-
- 20 edits in trunk/WebCore
2010-02-04 Mikhail Naganov <mnaganov@chromium.org>
Reviewed by Timothy Hatcher.
Put JSC-specific debugger & profiler code under "USE(JSC)" defines.
The plan is to enable "JAVASCRIPT_DEBUGGER" in Chromium and then
make this code engine-agnostic.
- inspector/InjectedScriptHost.cpp:
- inspector/InjectedScriptHost.h:
- inspector/InspectorBackend.cpp:
- inspector/InspectorBackend.h:
- inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController): (WebCore::InspectorController::setWindowVisible): (WebCore::InspectorController::scriptObjectReady): (WebCore::InspectorController::close): (WebCore::InspectorController::didCommitLoad):
- inspector/InspectorController.h:
- inspector/InspectorFrontend.cpp:
- inspector/InspectorFrontend.h:
- inspector/JavaScriptCallFrame.cpp:
- inspector/JavaScriptCallFrame.h:
- inspector/JavaScriptDebugListener.h:
- inspector/JavaScriptDebugServer.cpp:
- inspector/JavaScriptDebugServer.h:
- inspector/JavaScriptProfile.cpp:
- inspector/JavaScriptProfile.h:
- inspector/JavaScriptProfileNode.cpp:
- inspector/JavaScriptProfileNode.h:
- loader/FrameLoader.cpp: (WebCore::FrameLoader::continueLoadAfterNavigationPolicy):
- page/Page.cpp: (WebCore::Page::Page):
Feb 3, 2010:
- 11:54 PM Changeset in webkit [54328] by
-
- 23 edits in trunk/WebKitTools
2010-02-03 Dirk Pranke <dpranke@chromium.org>
Rubber-stamped by Eric Seidel.
Change "the Chromium name" to "the name of Google Inc." in the licenses
- Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
- Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
- Scripts/webkitpy/layout_tests/layout_package/metered_stream.py:
- Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
- Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
- Scripts/webkitpy/layout_tests/layout_package/test_files.py:
- Scripts/webkitpy/layout_tests/layout_package/test_shell_thread.py:
- Scripts/webkitpy/layout_tests/port/init.py:
- Scripts/webkitpy/layout_tests/port/apache_http_server.py:
- Scripts/webkitpy/layout_tests/port/chromium_linux.py:
- Scripts/webkitpy/layout_tests/port/chromium_mac.py:
- Scripts/webkitpy/layout_tests/port/chromium_win.py:
- Scripts/webkitpy/layout_tests/port/http_server.py:
- Scripts/webkitpy/layout_tests/port/http_server_base.py:
- Scripts/webkitpy/layout_tests/port/path_utils.py:
- Scripts/webkitpy/layout_tests/port/websocket_server.py:
- Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
- Scripts/webkitpy/layout_tests/run_chromium_webkit_tests.py:
- Scripts/webkitpy/layout_tests/test_types/fuzzy_image_diff.py:
- Scripts/webkitpy/layout_tests/test_types/image_diff.py:
- Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
- Scripts/webkitpy/layout_tests/test_types/text_diff.py:
- 11:51 PM Changeset in webkit [54327] by
-
- 12 edits11 moves1 add in trunk/WebKitTools
2010-02-03 Dirk Pranke <dpranke@chromium.org>
Rubber-stamped by Eric Siedel.
Rename files as part of refactoring the layout_tests package. All
the platform_utils* module, the path_utils.py module, and
the http server and web socket server modules are moved into a new
port/ package.
- Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
- Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
- Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
- Scripts/webkitpy/layout_tests/layout_package/test_files.py:
- Scripts/webkitpy/layout_tests/layout_package/test_shell_thread.py:
- Scripts/webkitpy/layout_tests/port/init.py: Renamed from WebKitTools/Scripts/webkitpy/layout_tests/layout_package/platform_utils.py.
- Scripts/webkitpy/layout_tests/port/apache_http_server.py: Renamed from WebKitTools/Scripts/webkitpy/layout_tests/layout_package/apache_http_server.py.
- Scripts/webkitpy/layout_tests/port/chromium_linux.py: Renamed from WebKitTools/Scripts/webkitpy/layout_tests/layout_package/platform_utils_linux.py.
- Scripts/webkitpy/layout_tests/port/chromium_mac.py: Renamed from WebKitTools/Scripts/webkitpy/layout_tests/layout_package/platform_utils_mac.py.
- Scripts/webkitpy/layout_tests/port/chromium_win.py: Renamed from WebKitTools/Scripts/webkitpy/layout_tests/layout_package/platform_utils_win.py.
- Scripts/webkitpy/layout_tests/port/http_server.py: Renamed from WebKitTools/Scripts/webkitpy/layout_tests/layout_package/http_server.py.
- Scripts/webkitpy/layout_tests/port/http_server_base.py: Renamed from WebKitTools/Scripts/webkitpy/layout_tests/layout_package/http_server_base.py.
- Scripts/webkitpy/layout_tests/port/httpd2.pem: Renamed from WebKitTools/Scripts/webkitpy/layout_tests/layout_package/httpd2.pem.
- Scripts/webkitpy/layout_tests/port/lighttpd.conf: Renamed from WebKitTools/Scripts/webkitpy/layout_tests/layout_package/lighttpd.conf.
- Scripts/webkitpy/layout_tests/port/path_utils.py: Renamed from WebKitTools/Scripts/webkitpy/layout_tests/layout_package/path_utils.py.
- Scripts/webkitpy/layout_tests/port/websocket_server.py: Renamed from WebKitTools/Scripts/webkitpy/layout_tests/layout_package/websocket_server.py.
- Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
- Scripts/webkitpy/layout_tests/run_chromium_webkit_tests.py:
- Scripts/webkitpy/layout_tests/test_types/fuzzy_image_diff.py:
- Scripts/webkitpy/layout_tests/test_types/image_diff.py:
- Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
- Scripts/webkitpy/layout_tests/test_types/text_diff.py:
- 11:48 PM Changeset in webkit [54326] by
-
- 6 edits in trunk/WebCore
2010-02-03 Nicholas Young <nicholas.young@nokia.com>
Reviewed by Eric Carlson.
Defer formatting of times displayed on media controls to the current theme.
https://bugs.webkit.org/show_bug.cgi?id=34405
No new tests needed. Refactoring Only.
- rendering/MediaControlElements.cpp: Removed formatTime() (WebCore::MediaControlTimeDisplayElement::setCurrentValue): No longer sets inner text
- rendering/MediaControlElements.h:
- rendering/RenderMedia.cpp: (WebCore::RenderMedia::updateTimeDisplay): Asks the theme to format the time display elements
- rendering/RenderTheme.cpp: (WebCore::RenderTheme::formatMediaControlsTime): new virtual method (WebCore::RenderTheme::formatMediaControlsCurrentTime): new virtual method (WebCore::RenderTheme::formatMediaControlsRemainingTime): new virtual method
- rendering/RenderTheme.h:
- 11:30 PM Changeset in webkit [54325] by
-
- 2 edits in trunk/LayoutTests
Unreviewed fix.
websocket/tests/close-on-unload.html and
close-on-navigate-new-location.html will fail on mac tiger,
because python on the platform doesn't support set(), which is
used in websocket handler for these tests.
- platform/mac-tiger/Skipped: skip websocket/tests/close-on-unload.html and websocket/tests/close-on-navigate-new-location.html
- 11:26 PM Changeset in webkit [54324] by
-
- 1 edit2 adds in trunk/LayoutTests
2010-02-03 Fumitoshi Ukai <ukai@chromium.org>
Reviewed by Alexey Proskuryakov.
navigating a frame to new location closes websocket in the frame
https://bugs.webkit.org/show_bug.cgi?id=34557
- websocket/tests/close-on-navigate-new-location-expected.txt: Added.
- websocket/tests/close-on-navigate-new-location.html: Added.
- 9:52 PM Changeset in webkit [54323] by
-
- 2 edits in trunk/WebCore
Windows Debug_All build fix.
- platform/graphics/win/WKCACFLayer.cpp:
- 7:57 PM Changeset in webkit [54322] by
-
- 1 delete in trunk/LayoutTests/websocket/tests/resources/close-on-unload-iframe.html~
Remove an unnecessary backup file.
- 7:28 PM Changeset in webkit [54321] by
-
- 3 edits9 adds in trunk
REGRESSION (r51644): WebCore/manual-tests/linkjump-1.html fails
<rdar://problem/7595694> and https://bugs.webkit.org/show_bug.cgi?id=34550
Reviewed by Alexey Proskuryakov.
WebCore:
Tests: fast/loader/document-with-fragment-url-1.html
fast/loader/document-with-fragment-url-2.html
fast/loader/document-with-fragment-url-3.html
fast/loader/document-with-fragment-url-4.html
- platform/KURL.cpp:
(WebCore::KURL::init): When resolving new URL from an empty reference relative to an absolute URL,
any fragment identifier from the absolute URL should be removed from the resulting resolution.
LayoutTests:
- fast/loader/document-with-fragment-url-1-expected.txt: Added.
- fast/loader/document-with-fragment-url-1.html: Added.
- fast/loader/document-with-fragment-url-2-expected.txt: Added.
- fast/loader/document-with-fragment-url-2.html: Added.
- fast/loader/document-with-fragment-url-3-expected.txt: Added.
- fast/loader/document-with-fragment-url-3.html: Added.
- fast/loader/document-with-fragment-url-4-expected.txt: Added.
- fast/loader/document-with-fragment-url-4.html: Added.
- fast/loader/resources/document-with-fragment-url-test.html: Added.
- 6:49 PM Changeset in webkit [54320] by
-
- 2 edits in trunk/JavaScriptCore
2010-02-03 Kwang Yul Seo <skyul@company100.net>
Reviewed by Eric Seidel.
[BREWMP] Define WTF_PLATFORM_BREWMP_SIMULATOR when AEE_SIMULATOR is defined
https://bugs.webkit.org/show_bug.cgi?id=34514
PLATFORM(BREWMP_SIMULATOR) guard is needed to make distinction between BREWMP
and BREWMP simulator.
- wtf/Platform.h:
- 6:24 PM Changeset in webkit [54319] by
-
- 1 edit6 adds in trunk/LayoutTests
2010-02-03 Fumitoshi Ukai <ukai@chromium.org>
Reviewed by Alexey Proskuryakov.
WebSocket should close the connection when unloading the document
https://bugs.webkit.org/show_bug.cgi?id=33248
- websocket/tests/close-on-unload-expected.txt: Added.
- websocket/tests/close-on-unload.html: Added.
- websocket/tests/close-on-unload_wsh.py: Added.
- websocket/tests/resources/close-on-unload-iframe.html: Added.
- 6:23 PM Changeset in webkit [54318] by
-
- 1 edit2 adds in trunk/WebCore
2010-02-03 Kwang Yul Seo <skyul@company100.net>
Reviewed by Eric Seidel.
[BREWMP] Port TextBreakIteratorInternalICU
https://bugs.webkit.org/show_bug.cgi?id=34515
Port TextBreakIteratorInternalICU.
- platform/text/brew/TextBreakIteratorInternalICUBrew.cpp: Added. (WebCore::currentSearchLocaleID): (WebCore::currentTextBreakLocaleID):
- 5:52 PM Changeset in webkit [54317] by
-
- 3 edits2 adds in trunk
WebCore: Fix for <rdar://problem/7594212>
https://bugs.webkit.org/show_bug.cgi?id=34549 - CSS counters crash at http://www.w3.org/TR/css3-content/
CrashTracer: [USER] 20 crashes in Safari at com.apple.WebCore: WebCore::CounterNode::insertAfter + 319
Reviewed by Simon Fraser.
Test: fast/css/counters/counter-before-selector-crash.html
- rendering/RenderCounter.cpp: (WebCore::updateCounters): nil check.
LayoutTests: Test for: <rdar://problem/7594212>
https://bugs.webkit.org/show_bug.cgi?id=34549 - CSS counters crash at http://www.w3.org/TR/css3-content/
CrashTracer: [USER] 20 crashes in Safari at com.apple.WebCore: WebCore::CounterNode::insertAfter + 319
Reviewed by Simon Fraser.
- fast/css/counters/counter-before-selector-crash-expected.txt: Added.
- fast/css/counters/counter-before-selector-crash.html: Added.
- 5:32 PM Changeset in webkit [54316] by
-
- 2 edits in trunk/WebCore
Initialize the variable in the last checkin to false. I didn't realize DRT relies on this being false.
So ports that want visited link tracking need to set that flag.
Reviewed by Brady Eidson.
- page/PageGroup.cpp:
- 5:09 PM Changeset in webkit [54315] by
-
- 4 edits1 add in branches/safari-4-branch/WebCore
Merge r54311.
- 5:07 PM Changeset in webkit [54314] by
-
- 4 edits1 add in trunk/WebKitTools
Rubber-stamped by Eric Seidel.
Roll back r53559 and r54084 again, because roll out didn't solve flakeyness on the Windows Test bots
https://bugs.webkit.org/show_bug.cgi?id=34399
- Scripts/run-iexploder-tests:
- Scripts/run-webkit-httpd:
- Scripts/run-webkit-tests:
- Scripts/webkitperl/httpd.pm: Added.
- 4:50 PM Changeset in webkit [54313] by
-
- 2 edits in trunk/WebCore
Fix for https://bugs.webkit.org/show_bug.cgi?id=34547
static shouldTrackVisitedLinks is not initialized
Reviewed by Brady Eidson.
For ports that don't call into WebKit to initialize this,
we should initialize to true so they get the visited link behavior by default.
- page/PageGroup.cpp:
- 4:32 PM Changeset in webkit [54312] by
-
- 4 edits1 delete in trunk/WebKitTools
Rubber-stamped by Eric Seidel.
Roll out r53559 and r54084, because it might caused flakeyness on the Windows Test bots
- Scripts/run-iexploder-tests:
- Scripts/run-webkit-httpd:
- Scripts/run-webkit-tests:
- Scripts/webkitperl/httpd.pm: Removed.
- 4:26 PM Changeset in webkit [54311] by
-
- 4 edits1 add in trunk/WebCore
<rdar://problem/7577604> Drag and Drop: background elements are bleeding through
https://bugs.webkit.org/show_bug.cgi?id=34546
Reviewed by Simon Fraser.
- manual-tests/drag-image-table-part-decorations.html: Added.
- rendering/RenderFieldset.cpp:
(WebCore::RenderFieldset::paintBoxDecorations): Bail out if this object shouldn’t
paint within the current painting root.
- rendering/RenderTable.cpp:
(WebCore::RenderTable::paintBoxDecorations): Ditto.
- rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::paintBackgroundsBehindCell): Ditto.
(WebCore::RenderTableCell::paintBoxDecorations): Ditto.
- 4:19 PM Changeset in webkit [54310] by
-
- 4 edits in branches/safari-4-branch/WebKitTools
Build fix.
- 3:47 PM Changeset in webkit [54309] by
-
- 3 edits in trunk/WebKit/wx
Reviewed by Kevin Ollivier.
Add wxWebKitWindowFeatures and have createWindow send a notification for
clients to handle.
https://bugs.webkit.org/show_bug.cgi?id=34542
- 3:31 PM Changeset in webkit [54308] by
-
- 8 edits in branches/safari-4-branch
Merge r54083.
- 3:31 PM Changeset in webkit [54307] by
-
- 4 edits in trunk
Rubber-stamped by Ariya Hidayat.
Roll back r53889 again, because roll out didn't solve flakeyness on the Windows Test bots
https://bugs.webkit.org/show_bug.cgi?id=34399
WebKitTools:
- DumpRenderTree/win/EventSender.cpp:
(buildModifierFlags):
(mouseDownCallback):
(mouseUpCallback):
(keyDownCallback):
LayoutTests:
- platform/win/Skipped:
- 3:06 PM Changeset in webkit [54306] by
-
- 2 edits in trunk/WebCore
2010-02-03 Nate Chapin <Nate Chapin>
Unreviewed, Chromium mac build fix.
[V8] Remove unused V8Proxy* variable from generated wrapping code.
- bindings/scripts/CodeGeneratorV8.pm:
- 2:33 PM Changeset in webkit [54305] by
-
- 47 edits in trunk/WebCore
2010-02-03 Nate Chapin <Nate Chapin>
Reviewed by Dimitri Glazkov.
[V8] Use toV8() to wrap in the custom bindings, and remove
the old wrapping code from V8DOMWrapper.
- bindings/scripts/CodeGeneratorV8.pm:
- bindings/v8/ScriptController.cpp:
- bindings/v8/ScriptObject.cpp:
- bindings/v8/V8AbstractEventListener.cpp:
- bindings/v8/V8Collection.h:
- bindings/v8/V8DOMWindowShell.cpp:
- bindings/v8/V8DOMWrapper.cpp:
- bindings/v8/V8DOMWrapper.h:
- bindings/v8/V8NodeFilterCondition.cpp:
- bindings/v8/V8Proxy.cpp:
- bindings/v8/WorkerContextExecutionProxy.h
- bindings/v8/custom/V8CanvasRenderingContext2DCustom.cpp:
- bindings/v8/custom/V8CustomPositionCallback.cpp:
- bindings/v8/custom/V8CustomPositionErrorCallback.cpp:
- bindings/v8/custom/V8CustomSQLStatementCallback.cpp:
- bindings/v8/custom/V8CustomSQLStatementErrorCallback.cpp:
- bindings/v8/custom/V8CustomSQLTransactionCallback.cpp:
- bindings/v8/custom/V8CustomSQLTransactionErrorCallback.cpp:
- bindings/v8/custom/V8DOMWindowCustom.cpp:
- bindings/v8/custom/V8DataGridColumnListCustom.cpp:
- bindings/v8/custom/V8DocumentCustom.cpp:
- bindings/v8/custom/V8DocumentLocationCustom.cpp:
- bindings/v8/custom/V8ElementCustom.cpp:
- bindings/v8/custom/V8EventCustom.cpp:
- bindings/v8/custom/V8HTMLAllCollectionCustom.cpp:
- bindings/v8/custom/V8HTMLAudioElementConstructor.cpp:
- bindings/v8/custom/V8HTMLCanvasElementCustom.cpp:
- bindings/v8/custom/V8HTMLCollectionCustom.cpp:
- bindings/v8/custom/V8HTMLDocumentCustom.cpp:
- bindings/v8/custom/V8HTMLFormElementCustom.cpp:
- bindings/v8/custom/V8HTMLFrameSetElementCustom.cpp:
- bindings/v8/custom/V8HTMLImageElementConstructor.cpp:
- bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp:
- bindings/v8/custom/V8HTMLSelectElementCustom.cpp:
- bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
- bindings/v8/custom/V8MessageChannelConstructor.cpp:
- bindings/v8/custom/V8MessageEventCustom.cpp:
- bindings/v8/custom/V8NamedNodeMapCustom.cpp:
- bindings/v8/custom/V8NodeIteratorCustom.cpp:
- bindings/v8/custom/V8NodeListCustom.cpp:
- bindings/v8/custom/V8NotificationCenterCustom.cpp:
- bindings/v8/custom/V8SVGMatrixCustom.cpp:
- bindings/v8/custom/V8StyleSheetListCustom.cpp:
- bindings/v8/custom/V8TreeWalkerCustom.cpp:
- bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:
- bindings/v8/custom/V8XSLTProcessorCustom.cpp:
- 2:32 PM Changeset in webkit [54304] by
-
- 25 edits in trunk/WebKitTools
2010-02-03 Eric Seidel <eric@webkit.org>
No review, just fixing copyrights.
Concerns were expressed about "The Chromium Authors" being
a valid legal entity for copyright assignment in the WebKit repository,
so this change removes all "The Chromium Authors".
I looked at the svn logs in src.chromium.org and failed to find any
non-google contributions to these files, so they are all now
marked as copyright "Google Inc" as all Google contributers assign
copyright to "Google Inc" as part of their employment agreement.
- Scripts/rebaseline-chromium-webkit-tests:
- Scripts/run-chromium-webkit-tests:
- Scripts/webkitpy/layout_tests/layout_package/apache_http_server.py:
- Scripts/webkitpy/layout_tests/layout_package/http_server.py:
- Scripts/webkitpy/layout_tests/layout_package/http_server_base.py:
- Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
- Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
- Scripts/webkitpy/layout_tests/layout_package/metered_stream.py:
- Scripts/webkitpy/layout_tests/layout_package/path_utils.py:
- Scripts/webkitpy/layout_tests/layout_package/platform_utils.py:
- Scripts/webkitpy/layout_tests/layout_package/platform_utils_linux.py:
- Scripts/webkitpy/layout_tests/layout_package/platform_utils_mac.py:
- Scripts/webkitpy/layout_tests/layout_package/platform_utils_win.py:
- Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
- Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
- Scripts/webkitpy/layout_tests/layout_package/test_files.py:
- Scripts/webkitpy/layout_tests/layout_package/test_shell_thread.py:
- Scripts/webkitpy/layout_tests/layout_package/websocket_server.py:
- Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
- Scripts/webkitpy/layout_tests/run_chromium_webkit_tests.py:
- Scripts/webkitpy/layout_tests/test_types/fuzzy_image_diff.py:
- Scripts/webkitpy/layout_tests/test_types/image_diff.py:
- Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
- Scripts/webkitpy/layout_tests/test_types/text_diff.py:
- 2:26 PM Changeset in webkit [54303] by
-
- 7 edits in branches/safari-4-branch
Merge r48879.
- 2:26 PM Changeset in webkit [54302] by
-
- 4 edits in branches/safari-4-branch
Merge r48374.
- 2:26 PM Changeset in webkit [54301] by
-
- 2 edits in branches/safari-4-branch/WebCore
Merge r48364.
- 2:26 PM Changeset in webkit [54300] by
-
- 31 edits1 copy15 adds in branches/safari-4-branch
Merge r48363.
- 2:23 PM Changeset in webkit [54299] by
-
- 2 edits in trunk/WebCore
Fix drawing buttons in viewless WebKit.
Reviewed by Anders Carlsson.
- platform/mac/ThemeMac.mm:
(WebCore::paintButton): If there is no view, make sure to flip the
context so that the button is drawn correctly.
- 2:00 PM Changeset in webkit [54298] by
-
- 3 edits in trunk/WebCore
[Qt] WebSockets : Buffer the data in WebKit instead of QtNetwork
https://bugs.webkit.org/show_bug.cgi?id=34425
Reviewed by Kenneth Rohde Christiansen.
Reverting r54279, it was a misunderstanding.
- platform/network/qt/SocketStreamHandlePrivate.h:
- platform/network/qt/SocketStreamHandleQt.cpp:
- 1:44 PM Changeset in webkit [54297] by
-
- 2 edits in trunk/WebKitTools
[Qt] QtLauncher, refactor argument handling in preparation of merge
with QGVLauncher
Reviewed by Ariya Hidayat.
- QtLauncher/main.cpp:
(LauncherApplication::urls):
(LauncherApplication::isRobotized):
(LauncherApplication::applyDefaultSettings):
(LauncherApplication::LauncherApplication):
(LauncherApplication::formatKeys):
(LauncherApplication::enumToKeys):
(fail):
(LauncherApplication::handleUserOptions):
(main):
- 1:43 PM Changeset in webkit [54296] by
-
- 2 edits in trunk/JavaScriptCore
2010-02-03 Kwang Yul Seo <skyul@company100.net>
Reviewed by Eric Seidel.
[BREWMP] Remove COMPILE_ASSERT conflict with the underlying PLATFORM
https://bugs.webkit.org/show_bug.cgi?id=34190
COMPILE_ASSERT conflicts with the underlying PLATFORM because it is defined
both in WTF's Assertions.h and BREWMP's AEEClassIDs.h. Include AEEClassIDs.h
in Assertions.h and undef COMPILE_ASSERT to avoid redefining COMPILE_ASSERT.
- wtf/Assertions.h:
- 1:19 PM Changeset in webkit [54295] by
-
- 4 edits in trunk
Rubber-stamped by Ariya Hidayat.
Rolling out r53889, because it might caused flakeyness on the Windows Test bots
https://bugs.webkit.org/show_bug.cgi?id=34399
WebKitTools:
- DumpRenderTree/win/EventSender.cpp:
(mouseDownCallback):
(mouseUpCallback):
(keyDownCallback):
LayoutTests:
- platform/win/Skipped:
- 1:17 PM Changeset in webkit [54294] by
-
- 1 edit2 adds in trunk/JavaScriptCore
2010-02-03 Kwang Yul Seo <skyul@company100.net>
Reviewed by Eric Seidel.
[BREWMP] Implement OwnPtrBrew to make sure BREW instances are freed.
https://bugs.webkit.org/show_bug.cgi?id=34518
Add OwnPtrBrew to release IFile, IFileMgr and IBitmap instances.
- wtf/brew/OwnPtrBrew.cpp: Added. (WTF::IFileMgr): (WTF::IFile): (WTF::IBitmap): (WTF::freeOwnedPtrBrew):
- wtf/brew/OwnPtrBrew.h: Added. (WTF::OwnPtrBrew::OwnPtrBrew): (WTF::OwnPtrBrew::~OwnPtrBrew): (WTF::OwnPtrBrew::get): (WTF::OwnPtrBrew::release): (WTF::OwnPtrBrew::outPtr): (WTF::OwnPtrBrew::set): (WTF::OwnPtrBrew::clear): (WTF::OwnPtrBrew::operator*): (WTF::OwnPtrBrew::operator->): (WTF::OwnPtrBrew::operator!): (WTF::OwnPtrBrew::operator UnspecifiedBoolType): (WTF::OwnPtrBrew::swap): (WTF::swap): (WTF::operator==): (WTF::operator!=): (WTF::getPtr):
- 12:58 PM Changeset in webkit [54293] by
-
- 3 edits in trunk/WebKit/win
Scroll does not work with IBM Thinkpad.
<https://bugs.webkit.org/show_bug.cgi?id=14227>
<rdar://7142545>
Reviewed by Steve Falkenburg.
When initializing the WebView, add two scrollbar Windows inside of
our WebView, to allow it to receive WM_VSCROLL and WM_HSCROLL events.
(similar to what Firefox did in: <https://bugzilla.mozilla.org/show_bug.cgi?id=507222>.
Only do this if the user has installed some kind of Trackpoint driver, using an algorithm
like <https://bugzilla.mozilla.org/show_bug.cgi?id=514927>.
Also, add code to handle WM_HSCROLL and WM_VSCROLL messages to scroll
the WebView.
- WebView.cpp:
(WebView::verticalScroll): Handle the WM_VSCROLL messages, and scroll up and down
by lines or pages.
(WebView::horizontalScroll): Handle the WM_HSCROLL messages, and scroll left or right
by lines or pages.
(WebView::WebViewWndProc): Add cases for WM_VSCROLL and WM_HSCROLL.
(WebView::initWithFrame): Call shouldInitializeTrackPointHack, and if we should, create
vertical and horizontal scrollbars to receive WM_VSCROLL and WM_HSCROLL messages.
(WebView::shouldInitializeTrackPointHack): Check if there is a registry key for
the some kind of IBM Trackpoint driver.
- WebView.h:
- 12:14 PM Changeset in webkit [54292] by
-
- 5 edits in trunk
2010-02-03 Drew Wilson <atwilson@chromium.org>
Reviewed by Alexey Proskuryakov.
SharedWorkerScriptLoader should not be an ActiveDOMObject
https://bugs.webkit.org/show_bug.cgi?id=34513
Test: Existing tests suffice (fixes test downstream in Chrome).
- workers/DefaultSharedWorkerRepository.cpp: (WebCore::SharedWorkerScriptLoader::SharedWorkerScriptLoader): Changed to no longer derive from ActiveDOMObject (handles its own refcounting). (WebCore::SharedWorkerScriptLoader::load): Now increments own refcount when a load is pending. (WebCore::SharedWorkerScriptLoader::notifyFinished): Changed to decrement refcount when load is complete.
- workers/WorkerScriptLoaderClient.h: Documentation change about reliability of notifyFinished() when used from worker context.
2010-02-03 Drew Wilson <atwilson@chromium.org>
Reviewed by Alexey Proskuryakov.
SharedWorkerScriptLoader should not be an ActiveDOMObject
https://bugs.webkit.org/show_bug.cgi?id=34513
- src/SharedWorkerRepository.cpp: (WebCore::SharedWorkerScriptLoader::SharedWorkerScriptLoader): Changed SharedWorkerScriptLoader to manage its own lifecycle without using ActiveDOMObject. (WebCore::SharedWorkerScriptLoader::parentContext): (WebCore::pendingLoaders): Now we manually track pending loads so we can shut them down when the parent context shuts down. (WebCore::SharedWorkerScriptLoader::contextDetached): Shuts down/frees any pending worker loads. (WebCore::SharedWorkerScriptLoader::~SharedWorkerScriptLoader): Marks the SharedWorker object as not having pending activity if there was a load active (handles case where load was pending when parent document exits). (WebCore::SharedWorkerScriptLoader::load): (WebCore::SharedWorkerRepository::documentDetached): Now calls SharedWorkerScriptLoader::contextDetached() to shutdown any pending worker loads.
- 11:57 AM Changeset in webkit [54291] by
-
- 2 edits in trunk/WebCore
2010-02-03 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: Inspector renders blank scripts on reloading the webpage.
- inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype.recreateViewForResourceIfNeeded):
- 11:41 AM Changeset in webkit [54290] by
-
- 2 edits in trunk/JavaScriptCore
2010-02-03 Kwang Yul Seo <skyul@company100.net>
Reviewed by Darin Adler.
Export WTF::fastStrDup symbol
https://bugs.webkit.org/show_bug.cgi?id=34526
- JavaScriptCore.exp:
- 11:39 AM Changeset in webkit [54289] by
-
- 2 edits in trunk/WebKitTools
[Qt] Fix pixel tests support.
https://bugs.webkit.org/show_bug.cgi?id=27813
Reviewed by Ariya Hidayat.
- DumpRenderTree/qt/DumpRenderTreeQt.cpp:
(WebCore::DumpRenderTree::open):
(WebCore::DumpRenderTree::processLine):
- Hash processing mechanism moved from DumpRenderTree::open to DumpRenderTree::processLine.
(WebCore::DumpRenderTree::dump): Fixed and renamed variables.
- 11:02 AM Changeset in webkit [54288] by
-
- 2 edits in trunk/WebKitLibraries
Fixed a bug where WKSetNSURLConnectionDefersCallbacks(true) did not defer callbacks during modal dialogs.
Reviewed by Anders Carlsson.
- libWebKitSystemInterfaceLeopard.a:
- 10:52 AM Changeset in webkit [54287] by
-
- 4 edits in trunk
Reviewed by Kevin Ollivier.
[wx] Enable JIT compilation for wx.
https://bugs.webkit.org/show_bug.cgi?id=34536
- 10:26 AM Changeset in webkit [54286] by
-
- 13 edits2 deletes in trunk/WebCore
2010-02-03 Yury Semikhatsky <yurys@chromium.org>
Unreviewed. Revert r54285 which failed to compile on Linux GTK.
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSInjectedScriptHostCustom.cpp: (WebCore::InjectedScriptHost::injectedScriptFor):
- bindings/v8/custom/V8InjectedScriptHostCustom.cpp: (WebCore::InjectedScriptHost::injectedScriptFor):
- inspector/InjectedScript.cpp: Removed.
- inspector/InjectedScript.h: Removed.
- inspector/InjectedScriptHost.cpp: (WebCore::InjectedScriptHost::injectedScriptForId): (WebCore::InjectedScriptHost::releaseWrapperObjectGroup):
- inspector/InjectedScriptHost.h:
- inspector/InspectorBackend.cpp: (WebCore::InspectorBackend::dispatchOnInjectedScript):
- inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController): (WebCore::InspectorController::~InspectorController): (WebCore::InspectorController::inspectedPageDestroyed): (WebCore::InspectorController::windowScriptObjectAvailable): (WebCore::InspectorController::scriptObjectReady): (WebCore::InspectorController::setFrontendProxyObject): (WebCore::InspectorController::close): (WebCore::InspectorController::getProfile): (WebCore::InspectorController::enableDebugger): (WebCore::InspectorController::didPause): (WebCore::InspectorController::injectedScriptForNodeId):
- inspector/InspectorController.h: (WebCore::InspectorController::frontendScriptState):
- inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::addConsoleMessage):
- inspector/front-end/InjectedScript.js: (injectedScriptConstructor):
- 10:11 AM Changeset in webkit [54285] by
-
- 14 edits2 adds in trunk/WebCore
2010-02-03 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Provide strongly typed C++ interface for inspector's injected script.
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSInjectedScriptHostCustom.cpp: (WebCore::InjectedScriptHost::injectedScriptFor):
- bindings/v8/custom/V8InjectedScriptHostCustom.cpp: (WebCore::InjectedScriptHost::injectedScriptFor):
- inspector/InjectedScript.cpp: Added. (WebCore::InjectedScript::InjectedScript): (WebCore::InjectedScript::dispatch): (WebCore::InjectedScript::callFrames): (WebCore::InjectedScript::wrapAndStringify): (WebCore::InjectedScript::releaseWrapperObjectGroup):
- inspector/InjectedScript.h: Added. (WebCore::InjectedScript::InjectedScript): (WebCore::InjectedScript::~InjectedScript): (WebCore::InjectedScript::hasNoValue):
- inspector/InjectedScriptHost.cpp: (WebCore::InjectedScriptHost::injectedScriptForId): (WebCore::InjectedScriptHost::releaseWrapperObjectGroup):
- inspector/InjectedScriptHost.h:
- inspector/InspectorBackend.cpp: (WebCore::InspectorBackend::dispatchOnInjectedScript):
- inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController): (WebCore::InspectorController::~InspectorController): (WebCore::InspectorController::inspectedPageDestroyed): (WebCore::InspectorController::windowScriptObjectAvailable): (WebCore::InspectorController::scriptObjectReady): (WebCore::InspectorController::setFrontendProxyObject): (WebCore::InspectorController::close): (WebCore::InspectorController::getProfile): (WebCore::InspectorController::enableDebugger): (WebCore::InspectorController::didPause): (WebCore::InspectorController::injectedScriptForNodeId):
- inspector/InspectorController.h: (WebCore::InspectorController::frontendScriptState):
- inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::addConsoleMessage):
- 10:02 AM Changeset in webkit [54284] by
-
- 4 edits in trunk
Unreviewed build fix.
[Qt] Roll-out r54281 because it broke the build on the Qt Release bot.
- 9:48 AM Changeset in webkit [54283] by
-
- 2 edits in trunk/WebKit/chromium
2010-02-03 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Timothy Hatcher.
[Chromium] Return a consistent set of platforms from WebDevToolsFrontendImpl
https://bugs.webkit.org/show_bug.cgi?id=34523
- src/WebDevToolsFrontendImpl.cpp: (WebKit::WebDevToolsFrontendImpl::jsPlatform):
- 8:09 AM Changeset in webkit [54282] by
-
- 2 edits in trunk/WebCore
2010-02-02 Bryan Yeung <bryeung@google.com>
Reviewed by Darin Adler.
Avoid using an invalidated KURL object in baseURI.
This change fixes baseURI for Chromium (where the KURL implementation
does not allow invalid KURLs to carry relative paths). This is
regression tested by
LayoutTests/svg/W3C-SVG-1.1/struct-image-07-t.svg
This is a re-application of this patch since it was mistakenly identified as
the cause of a big chromium test regression and rolled out in r54264.
- dom/Element.cpp: (WebCore::Element::baseURI):
- 8:01 AM Changeset in webkit [54281] by
-
- 4 edits in trunk
2010-02-03 No'am Rosenthal <noam.rosenthal@nokia.com>
Reviewed by Laszlo Gombos.
[Qt] Tuning and optimizations to GraphicsLayerQt. Reduce unnecessary
recaching, remove QTimer::singleShot and QPixmap::scaled, more
accurate strategy of handling transform operation blends. Rotating a
bordered-table, for example, now runs at 50FPS instead of 40FPS on Maemo5.
This is tested by https://bugs.webkit.org/show_bug.cgi?id=34450, fps measurements.
- platform/graphics/qt/GraphicsLayerQt.cpp: (WebCore::GraphicsLayerQtImpl::flushChanges): Fine-tune caching (WebCore::TransformAnimationQt::TransformAnimationQt): transform bugs (WebCore::OpacityAnimationQt::updateState): style change
2010-02-03 No'am Rosenthal <noam.rosenthal@nokia.com>
Reviewed by Laszlo Gombos.
[Qt] Tuning and optimizations to GraphicsLayerQt. Mainly reduced usage
of QTimer::singleShot, and moved syncLayers() from paint() to update()
https://bugs.webkit.org/show_bug.cgi?id=34062
- Api/qgraphicswebview.cpp: (QGraphicsWebViewPrivate::update): Moved the sync operation to update (QGraphicsWebView::paint): Moved the sync operation to update
- 7:37 AM Changeset in webkit [54280] by
-
- 5 edits2 adds in trunk
WebCore: [Chromium] Make setCaretBlinkInterval static.
https://bugs.webkit.org/show_bug.cgi?id=31704
Patch by Joel Stanley <joel@jms.id.au> on 2010-02-02
Reviewed by David Levin.
This is so it can be called from the newly exposed Chromium API setter
method.
- rendering/RenderThemeChromiumLinux.cpp:
- rendering/RenderThemeChromiumLinux.h:
WebKit/chromium: [Chromium] Add API method for setting caret blink frequency.
https://bugs.webkit.org/show_bug.cgi?id=31704
Patch by Joel Stanley <joel@jms.id.au> on 2010-02-02
Reviewed by David Levin.
This enables the RenderThemeChromiumLinux::setCaretBlinkInterval method
to be called Chromium's API. The API is linux-only as it is currently
the only port to implement RenderTheme::setCaretBlinkInterval.
- WebKit.gyp: Add WebRenderTheme.{h,cpp}
- public/linux/WebRenderTheme.h: Added.
- src/linux/WebRenderTheme.cpp: Added.
(WebKit::setCaretBlinkInterval): Exposed API
- 5:42 AM Changeset in webkit [54279] by
-
- 3 edits in trunk/WebCore
[Qt] WebSockets : Buffer the data in WebKit instead of QtNetwork
https://bugs.webkit.org/show_bug.cgi?id=34425
Reviewed by Kenneth Rohde Christiansen.
Buffer the sent data in SocketStreamHandlePrivate instead of relying on
the network layer to do it. This is more robust and more consistent with how
Qt's HTTP stack works.
Close the socket in SocketStreamHandlePrivate::close() regardless of its state.
No new tests, since no new functionality is introduced.
- platform/network/qt/SocketStreamHandlePrivate.h:
- platform/network/qt/SocketStreamHandleQt.cpp:
- 5:02 AM Changeset in webkit [54278] by
-
- 45 edits in trunk/WebCore
2010-02-03 Shinichiro Hamaji <hamaji@chromium.org>
Unreviewed revert of r54259 as it seems to break chromium's unit tests.
The tests pass with r54257 but fail with r54260.
As r54258 and r54260 don't touch code, I'm reverting this change.
[V8] Generate toV8 conversion helpers, a la JSC bindings.
https://bugs.webkit.org/show_bug.cgi?id=32563
- bindings/v8/ScriptController.cpp: (WebCore::ScriptController::processingUserGesture): (WebCore::createScriptObject): (WebCore::ScriptController::createScriptObjectForPluginElement):
- bindings/v8/ScriptObject.cpp: (WebCore::ScriptGlobalObject::set):
- bindings/v8/V8AbstractEventListener.cpp: (WebCore::V8AbstractEventListener::handleEvent):
- bindings/v8/V8Collection.h: (WebCore::getV8Object): (WebCore::toNativeCollection): (WebCore::getNamedPropertyOfCollection): (WebCore::collectionNamedPropertyGetter): (WebCore::getIndexedPropertyOfCollection): (WebCore::collectionIndexedPropertyGetter): (WebCore::nodeCollectionIndexedPropertyEnumerator): (WebCore::collectionIndexedPropertyEnumerator): (WebCore::collectionStringOrNullIndexedPropertyGetter): (WebCore::collectionStringIndexedPropertyGetter): (WebCore::setCollectionIndexedGetter): (WebCore::setCollectionNamedGetter): (WebCore::setCollectionStringOrNullIndexedGetter): (WebCore::setCollectionStringIndexedGetter):
- bindings/v8/V8DOMWindowShell.cpp: (WebCore::V8DOMWindowShell::updateDocumentWrapperCache):
- bindings/v8/V8DOMWrapper.cpp: (WebCore::downcastSVGPathSeg): (WebCore::V8DOMWrapper::convertSVGElementInstanceToV8Object): (WebCore::V8DOMWrapper::convertSVGObjectWithContextToV8Object): (WebCore::V8DOMWrapper::convertToV8Object): (WebCore::V8DOMWrapper::instantiateV8Object): (WebCore::V8DOMWrapper::isDOMEventWrapper): (WebCore::V8DOMWrapper::htmlElementType): (WebCore::V8DOMWrapper::svgElementType): (WebCore::V8DOMWrapper::convertEventToV8Object): (WebCore::): (WebCore::V8DOMWrapper::convertDocumentToV8Object): (WebCore::V8DOMWrapper::convertNodeToV8Object): (WebCore::V8DOMWrapper::convertNewNodeToV8Object): (WebCore::V8DOMWrapper::convertEventListenerToV8Object): (WebCore::V8DOMWrapper::convertDOMImplementationToV8Object): (WebCore::V8DOMWrapper::convertStyleSheetToV8Object): (WebCore::V8DOMWrapper::convertCSSValueToV8Object): (WebCore::V8DOMWrapper::convertCSSRuleToV8Object): (WebCore::V8DOMWrapper::convertWindowToV8Object): (WebCore::V8DOMWrapper::convertNamedNodeMapToV8Object):
- bindings/v8/V8DOMWrapper.h: (WebCore::V8DOMWrapper::convertToV8Object): (WebCore::V8DOMWrapper::convertNodeToV8Object): (WebCore::V8DOMWrapper::convertNewNodeToV8Object): (WebCore::V8DOMWrapper::convertEventToV8Object): (WebCore::V8DOMWrapper::convertEventListenerToV8Object): (WebCore::V8DOMWrapper::instantiateV8Object):
- bindings/v8/V8NodeFilterCondition.cpp: (WebCore::V8NodeFilterCondition::acceptNode):
- bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::setDOMException):
- bindings/v8/custom/V8CanvasRenderingContext2DCustom.cpp: (WebCore::toV8Object): (WebCore::V8CanvasRenderingContext2D::createPatternCallback):
- bindings/v8/custom/V8CustomPositionCallback.cpp: (WebCore::V8CustomPositionCallback::handleEvent):
- bindings/v8/custom/V8CustomPositionErrorCallback.cpp: (WebCore::V8CustomPositionErrorCallback::handleEvent):
- bindings/v8/custom/V8CustomSQLStatementCallback.cpp: (WebCore::V8CustomSQLStatementCallback::handleEvent):
- bindings/v8/custom/V8CustomSQLStatementErrorCallback.cpp: (WebCore::V8CustomSQLStatementErrorCallback::handleEvent):
- bindings/v8/custom/V8CustomSQLTransactionCallback.cpp: (WebCore::V8CustomSQLTransactionCallback::handleEvent):
- bindings/v8/custom/V8CustomSQLTransactionErrorCallback.cpp: (WebCore::V8CustomSQLTransactionErrorCallback::handleEvent):
- bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::V8DOMWindow::openCallback): (WebCore::V8DOMWindow::indexedPropertyGetter): (WebCore::V8DOMWindow::namedPropertyGetter):
- bindings/v8/custom/V8DataGridColumnListCustom.cpp: (WebCore::NAMED_PROPERTY_GETTER):
- bindings/v8/custom/V8DocumentCustom.cpp: (WebCore::V8Document::evaluateCallback): (WebCore::V8Document::getCSSCanvasContextCallback): (WebCore::V8Document::implementationAccessorGetter):
- bindings/v8/custom/V8DocumentLocationCustom.cpp: (WebCore::V8Document::locationAccessorGetter):
- bindings/v8/custom/V8ElementCustom.cpp: (WebCore::V8Element::setAttributeNodeCallback): (WebCore::V8Element::setAttributeNodeNSCallback):
- bindings/v8/custom/V8EventCustom.cpp: (WebCore::V8Event::dataTransferAccessorGetter): (WebCore::V8Event::clipboardDataAccessorGetter):
- bindings/v8/custom/V8HTMLAllCollectionCustom.cpp: (WebCore::getNamedItems): (WebCore::getItem): (WebCore::V8HTMLAllCollection::callAsFunctionCallback):
- bindings/v8/custom/V8HTMLAudioElementConstructor.cpp: (WebCore::V8Custom::v8HTMLAudioElementConstructorCallback):
- bindings/v8/custom/V8HTMLCanvasElementCustom.cpp: (WebCore::V8HTMLCanvasElement::getContextCallback):
- bindings/v8/custom/V8HTMLCollectionCustom.cpp: (WebCore::getNamedItems): (WebCore::getItem): (WebCore::V8HTMLCollection::callAsFunctionCallback):
- bindings/v8/custom/V8HTMLDocumentCustom.cpp: (WebCore::V8HTMLDocument::namedPropertyGetter): (WebCore::V8HTMLDocument::allAccessorGetter):
- bindings/v8/custom/V8HTMLFormElementCustom.cpp: (WebCore::V8HTMLFormElement::indexedPropertyGetter): (WebCore::V8HTMLFormElement::namedPropertyGetter):
- bindings/v8/custom/V8HTMLFrameSetElementCustom.cpp: (WebCore::V8HTMLFrameSetElement::namedPropertyGetter):
- bindings/v8/custom/V8HTMLImageElementConstructor.cpp: (WebCore::V8Custom::v8HTMLImageElementConstructorCallback):
- bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp: (WebCore::V8HTMLOptionsCollection::indexedPropertyGetter):
- bindings/v8/custom/V8HTMLSelectElementCustom.cpp: (WebCore::V8HTMLSelectElement::namedPropertyGetter): (WebCore::V8HTMLSelectElement::indexedPropertyGetter):
- bindings/v8/custom/V8InjectedScriptHostCustom.cpp: (WebCore::createInjectedScript): (WebCore::V8InjectedScriptHost::nodeForIdCallback): (WebCore::V8InjectedScriptHost::databaseForIdCallback):
- bindings/v8/custom/V8MessageChannelConstructor.cpp: (WebCore::V8MessageChannel::constructorCallback):
- bindings/v8/custom/V8MessageEventCustom.cpp: (WebCore::V8MessageEvent::portsAccessorGetter):
- bindings/v8/custom/V8NamedNodeMapCustom.cpp: (WebCore::V8NamedNodeMap::indexedPropertyGetter): (WebCore::V8NamedNodeMap::namedPropertyGetter):
- bindings/v8/custom/V8NodeIteratorCustom.cpp: (WebCore::toV8):
- bindings/v8/custom/V8NodeListCustom.cpp: (WebCore::V8NodeList::namedPropertyGetter): (WebCore::V8NodeList::callAsFunctionCallback):
- bindings/v8/custom/V8NotificationCenterCustom.cpp: (WebCore::V8NotificationCenter::createHTMLNotificationCallback): (WebCore::V8NotificationCenter::createNotificationCallback):
- bindings/v8/custom/V8SVGMatrixCustom.cpp: (WebCore::V8SVGMatrix::multiplyCallback): (WebCore::V8SVGMatrix::inverseCallback): (WebCore::V8SVGMatrix::rotateFromVectorCallback):
- bindings/v8/custom/V8StyleSheetListCustom.cpp: (WebCore::V8StyleSheetList::namedPropertyGetter):
- bindings/v8/custom/V8TreeWalkerCustom.cpp: (WebCore::toV8Object):
- bindings/v8/custom/V8WebGLRenderingContextCustom.cpp: (WebCore::toV8Object):
- bindings/v8/custom/V8XSLTProcessorCustom.cpp: (WebCore::V8XSLTProcessor::transformToFragmentCallback): (WebCore::V8XSLTProcessor::transformToDocumentCallback):
- 2:54 AM Changeset in webkit [54277] by
-
- 13 edits2 copies1 move3 adds in trunk/WebCore
2010-02-03 Mikhail Naganov <mnaganov@chromium.org>
Reviewed by Pavel Feldman.
Start unforking debugger and profiler code.
Remove custom implementation of Console.
Add 'ScriptProfiler' and 'ScriptProfile' types.
Start migration to engine-neutral types in InspectorController.
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSBindingsAllInOne.cpp:
- bindings/js/JSConsoleCustom.cpp:
- bindings/js/ScriptProfile.h: Added.
- bindings/js/ScriptProfiler.cpp: Added. (WebCore::ScriptProfiler::start): (WebCore::ScriptProfiler::stop):
- bindings/js/ScriptProfiler.h: Added.
- bindings/scripts/CodeGeneratorV8.pm:
- bindings/v8/ScriptProfile.h: Added. (WebCore::ScriptProfile::create): (WebCore::ScriptProfile::~ScriptProfile): (WebCore::ScriptProfile::title): (WebCore::ScriptProfile::uid): (WebCore::ScriptProfile::ScriptProfile):
- bindings/v8/ScriptProfiler.cpp: Added. (WebCore::ScriptProfiler::start): (WebCore::ScriptProfiler::stop):
- bindings/v8/ScriptProfiler.h: Added.
- bindings/v8/custom/V8ConsoleCustom.cpp: Removed.
- inspector/InspectorController.cpp: (WebCore::InspectorController::endGroup): (WebCore::InspectorController::show): (WebCore::InspectorController::setDOMStorageItem): (WebCore::InspectorController::addProfile): (WebCore::InspectorController::addProfileFinishedMessageToConsole): (WebCore::InspectorController::addStartProfilingMessageToConsole): (WebCore::InspectorController::createProfileHeader): (WebCore::InspectorController::getCurrentUserInitiatedProfileName): (WebCore::InspectorController::startUserInitiatedProfiling): (WebCore::InspectorController::stopUserInitiatedProfiling): (WebCore::InspectorController::enableDebugger): (WebCore::InspectorController::specialPanelForJSName):
- inspector/InspectorController.h: (WebCore::InspectorController::searchingForNodeInPage):
- page/Console.cpp: (WebCore::Console::profile): (WebCore::Console::profileEnd):
- page/Console.h: (WebCore::): (WebCore::Console::create): (WebCore::Console::profiles):
- page/Console.idl:
- 2:13 AM QtWebKitBackportingFixes edited by
- (diff)
- 1:50 AM Changeset in webkit [54276] by
-
- 1 edit in trunk/WebKitTools/Scripts/webkitpy/committers.py
Add myself to commiters.py
- 12:11 AM Changeset in webkit [54275] by
-
- 2 edits in trunk/LayoutTests
Rubber-stamped by Adam Barth.
http/tests/security/xss-DENIED-window-open-javascript-url.html timed out on Windows Debug Bot
https://bugs.webkit.org/show_bug.cgi?id=33349
- platform/win/Skipped: http/tests/security/xss-DENIED-window-open-javascript-url.html skipped.
Feb 2, 2010:
- 10:56 PM Changeset in webkit [54274] by
-
- 11 edits in trunk
2010-02-02 Kent Tamura <tkent@chromium.org>
Reviewed by Darin Adler.
Fix a bug that changes for some constraint attributes doesn't
update validation CSS selectors.
https://bugs.webkit.org/show_bug.cgi?id=31716
Add tests for maxLength changes and step changes.
- fast/forms/input-live-pseudo-selectors-expected.txt:
- fast/forms/resources/input-live-pseudo-selectors.js:
- fast/forms/resources/textarea-live-pseudo-selectors.js:
- fast/forms/textarea-live-pseudo-selectors-expected.txt:
2010-02-02 Kent Tamura <tkent@chromium.org>
Reviewed by Darin Adler.
Fix a bug that changes for some constraint attributes doesn't
update validation CSS selectors.
https://bugs.webkit.org/show_bug.cgi?id=31716
- Rename HTMLFormControlElement::updateValidity() to setNeedsValidityCheck()
- Introduce HTMLFormControlElement::setNeedsWillValidate()
- Introduce HTMLFormControlElement::m_hasName to make willValidate() work in parseMappedAttribute().
- We need to call setNeedsValidityCheck() when HTMLInputElement::step or HTMLTextAreaElement::maxLength is changed.
- html/HTMLFormControlElement.cpp: (WebCore::HTMLFormControlElement::HTMLFormControlElement): (WebCore::HTMLFormControlElement::parseMappedAttribute): (WebCore::HTMLFormControlElement::insertedIntoTree): (WebCore::HTMLFormControlElement::removedFromTree): (WebCore::HTMLFormControlElement::formDestroyed): (WebCore::HTMLFormControlElement::willValidate): Avoids function calls. (WebCore::HTMLFormControlElement::setNeedsWillValidateCheck): (WebCore::HTMLFormControlElement::setNeedsValidityCheck):
- html/HTMLFormControlElement.h: (WebCore::HTMLFormControlElement::disabled): Move the code from .cpp.
- html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::setInputType): (WebCore::HTMLInputElement::parseMappedAttribute): (WebCore::HTMLInputElement::setValue): (WebCore::HTMLInputElement::setValueFromRenderer): (WebCore::HTMLInputElement::setFileListFromRenderer):
- html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::parseMappedAttribute): (WebCore::HTMLTextAreaElement::setValue):
- rendering/RenderTextControlMultiLine.cpp: (WebCore::RenderTextControlMultiLine::subtreeHasChanged):
- 9:57 PM Changeset in webkit [54273] by
-
- 3 edits4 adds in trunk
Bug 34198 - Ruby text should not inherit line-height
(https://bugs.webkit.org/show_bug.cgi?id=34198)
Reviewed by Adele Peterson.
Resetting line-height to 'normal' in the default UA style sheet.
Adding layout-test to check for this.
WebCore:
Test: fast/ruby/ruby-line-height.html
- css/html.css:
LayoutTests:
- fast/ruby/script-tests: Added.
- fast/ruby/script-tests/ruby-line-height.js: Added.
- fast/ruby/ruby-line-height-expected.txt: Added.
- fast/ruby/ruby-line-height.html: Added.
- 9:22 PM Changeset in webkit [54272] by
-
- 3 edits2 adds in trunk
2010-02-02 Kent Tamura <tkent@chromium.org>
Reviewed by Darin Adler.
rangeOverflow/rangeUnderflow support for type=datetime, datetime-local,
month, time and week
https://bugs.webkit.org/show_bug.cgi?id=34483
Add tests for datetime, datetime-local, month, time and week, and
merge existing tests into one test file.
- fast/forms/ValidityState-rangeOverflow-date-expected.txt: Removed.
- fast/forms/ValidityState-rangeOverflow-date.html: Removed.
- fast/forms/ValidityState-rangeOverflow-expected.txt: Added.
- fast/forms/ValidityState-rangeOverflow-number-expected.txt: Removed.
- fast/forms/ValidityState-rangeOverflow-number.html: Removed.
- fast/forms/ValidityState-rangeOverflow-range-expected.txt: Removed.
- fast/forms/ValidityState-rangeOverflow-range.html: Removed.
- fast/forms/ValidityState-rangeOverflow.html: Added.
- fast/forms/ValidityState-rangeUnderflow-date-expected.txt: Removed.
- fast/forms/ValidityState-rangeUnderflow-date.html: Removed.
- fast/forms/ValidityState-rangeUnderflow-expected.txt: Added.
- fast/forms/ValidityState-rangeUnderflow-number-expected.txt: Removed.
- fast/forms/ValidityState-rangeUnderflow-number.html: Removed.
- fast/forms/ValidityState-rangeUnderflow-range-expected.txt: Removed.
- fast/forms/ValidityState-rangeUnderflow-range.html: Removed.
- fast/forms/ValidityState-rangeUnderflow.html: Added.
- fast/forms/script-tests/ValidityState-rangeOverflow-date.js: Removed.
- fast/forms/script-tests/ValidityState-rangeOverflow-number.js: Removed.
- fast/forms/script-tests/ValidityState-rangeOverflow-range.js: Removed.
- fast/forms/script-tests/ValidityState-rangeOverflow.js: Added.
- fast/forms/script-tests/ValidityState-rangeUnderflow-date.js: Removed.
- fast/forms/script-tests/ValidityState-rangeUnderflow-number.js: Removed.
- fast/forms/script-tests/ValidityState-rangeUnderflow-range.js: Removed.
- fast/forms/script-tests/ValidityState-rangeUnderflow.js: Added.
2010-02-02 James Robinson <jamesr@chromium.org>
Reviewed by Dmitry Titov.
Add a null check for image, which might be NULL if tileSize is empty
https://bugs.webkit.org/show_bug.cgi?id=34510
Test: fast/gradients/crash-on-1px-border.html
- rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelScaleObserver::shouldPaintBackgroundAtLowQuality):
- 8:21 PM Changeset in webkit [54271] by
-
- 3 edits2 moves4 adds16 deletes in trunk
2010-02-02 Kent Tamura <tkent@chromium.org>
Reviewed by Darin Adler.
rangeOverflow/rangeUnderflow support for type=datetime, datetime-local,
month, time and week
https://bugs.webkit.org/show_bug.cgi?id=34483
Add tests for datetime, datetime-local, month, time and week, and
merge existing tests into one test file.
- fast/forms/ValidityState-rangeOverflow-date-expected.txt: Removed.
- fast/forms/ValidityState-rangeOverflow-date.html: Removed.
- fast/forms/ValidityState-rangeOverflow-expected.txt: Added.
- fast/forms/ValidityState-rangeOverflow-number-expected.txt: Removed.
- fast/forms/ValidityState-rangeOverflow-number.html: Removed.
- fast/forms/ValidityState-rangeOverflow-range-expected.txt: Removed.
- fast/forms/ValidityState-rangeOverflow-range.html: Removed.
- fast/forms/ValidityState-rangeOverflow.html: Added.
- fast/forms/ValidityState-rangeUnderflow-date-expected.txt: Removed.
- fast/forms/ValidityState-rangeUnderflow-date.html: Removed.
- fast/forms/ValidityState-rangeUnderflow-expected.txt: Added.
- fast/forms/ValidityState-rangeUnderflow-number-expected.txt: Removed.
- fast/forms/ValidityState-rangeUnderflow-number.html: Removed.
- fast/forms/ValidityState-rangeUnderflow-range-expected.txt: Removed.
- fast/forms/ValidityState-rangeUnderflow-range.html: Removed.
- fast/forms/ValidityState-rangeUnderflow.html: Added.
- fast/forms/script-tests/ValidityState-rangeOverflow-date.js: Removed.
- fast/forms/script-tests/ValidityState-rangeOverflow-number.js: Removed.
- fast/forms/script-tests/ValidityState-rangeOverflow-range.js: Removed.
- fast/forms/script-tests/ValidityState-rangeOverflow.js: Added.
- fast/forms/script-tests/ValidityState-rangeUnderflow-date.js: Removed.
- fast/forms/script-tests/ValidityState-rangeUnderflow-number.js: Removed.
- fast/forms/script-tests/ValidityState-rangeUnderflow-range.js: Removed.
- fast/forms/script-tests/ValidityState-rangeUnderflow.js: Added.
2010-02-02 Kent Tamura <tkent@chromium.org>
Reviewed by Darin Adler.
rangeOverflow/rangeUnderflow support for type=datetime, datetime-local,
month, time and week
https://bugs.webkit.org/show_bug.cgi?id=34483
Tests: fast/forms/ValidityState-rangeOverflow.html
fast/forms/ValidityState-rangeUnderflow.html
- html/HTMLInputElement.cpp: Defines the hard limits for the types as double values. (WebCore::HTMLInputElement::rangeUnderflow): Supports the types. (WebCore::HTMLInputElement::rangeOverflow): Supports the types. (WebCore::HTMLInputElement::minimum): Supports the types. (WebCore::HTMLInputElement::maximum): Supports the types.
- 8:20 PM Changeset in webkit [54270] by
-
- 4 edits in trunk/WebKit/chromium
2010-02-02 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Dimitri Glazkov.
[Chromium] Implement WebFrameImpl::pageNumberForElementById
https://bugs.webkit.org/show_bug.cgi?id=34471
- public/WebFrame.h:
- src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::pageNumberForElementById):
- src/WebFrameImpl.h:
- 8:00 PM Changeset in webkit [54269] by
-
- 2 edits in trunk/WebKitTools
[wx] Build fix after introduction of pageNumberForElementById.
- 7:42 PM Changeset in webkit [54268] by
-
- 5 edits in trunk/WebKit/mac
Roll out r54252.
The method it deleted is in fact used, and its deletion resulted in plug-ins that use accelerated compositing not being drawn.
- 5:36 PM Changeset in webkit [54267] by
-
- 5 edits2 adds in trunk
2010-02-02 Fumitoshi Ukai <ukai@chromium.org>
Reviewed by Alexey Proskuryakov.
WebSocket wrapper can be collected even if events are pending
https://bugs.webkit.org/show_bug.cgi?id=34014
- websocket/tests/websocket-pending-activity-expected.txt: Added.
- websocket/tests/websocket-pending-activity.html: Added.
2010-02-02 Fumitoshi Ukai <ukai@chromium.org>
Reviewed by Alexey Proskuryakov.
WebSocket set pending activity to avoid unexpected GC.
https://bugs.webkit.org/show_bug.cgi?id=34014
Test: websocket/tests/websocket-pending-activity.html
- websockets/WebSocket.cpp: (WebCore::WebSocket::connect): set pending activity until it receives didClose. (WebCore::WebSocket::contextDestroyed): check socket is already closed. (WebCore::WebSocket::stop): close the connection and unset pending activity when it stops. (WebCore::WebSocket::didClose): unset pending activity.
- websockets/WebSocket.h:
- websockets/WebSocketChannel.cpp: (WebCore::WebSocketChannel::didReceiveData): protect this while it processes received data.
- 5:21 PM Changeset in webkit [54266] by
-
- 3 edits2 deletes in trunk/WebCore
2010-02-02 Gustavo Noronha Silva <Gustavo Noronha Silva>
No review, rolling out r54261.
http://trac.webkit.org/changeset/54261
https://bugs.webkit.org/show_bug.cgi?id=34435
Causes crashes on release builds
- GNUmakefile.am:
- platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::mediaPlayerPrivateSourceChangedCallback):
- platform/gtk/GOwnPtrGtk.cpp: Removed.
- platform/gtk/GOwnPtrGtk.h: Removed.
- 5:13 PM Changeset in webkit [54265] by
-
- 4 edits in trunk/JavaScriptCore
2010-02-02 Oliver Hunt <oliver@apple.com>
Reviewed by Geoffrey Garen.
Crash in CollectorBitmap::get at nbcolympics.com
https://bugs.webkit.org/show_bug.cgi?id=34504
This was caused by the use of m_offset to determine the offset of
a new property into the property storage. This patch corrects
the effected cases by incorporating the anonymous slot count. It
also removes the duplicate copy of anonymous slot count from the
property table as keeping this up to date merely increased the
chance of a mismatch. Finally I've added a large number of
assertions in an attempt to prevent such a bug from happening
again.
With the new assertions in place the existing anonymous slot tests
all fail without the m_offset fixes.
- runtime/PropertyMapHashTable.h:
- runtime/Structure.cpp: (JSC::Structure::materializePropertyMap): (JSC::Structure::addPropertyTransitionToExistingStructure): (JSC::Structure::addPropertyTransition): (JSC::Structure::removePropertyTransition): (JSC::Structure::flattenDictionaryStructure): (JSC::Structure::addPropertyWithoutTransition): (JSC::Structure::removePropertyWithoutTransition): (JSC::Structure::copyPropertyTable): (JSC::Structure::get): (JSC::Structure::put): (JSC::Structure::remove): (JSC::Structure::insertIntoPropertyMapHashTable): (JSC::Structure::createPropertyMapHashTable): (JSC::Structure::rehashPropertyMapHashTable): (JSC::Structure::checkConsistency):
- 5:12 PM QtWebKitBackportingFixes edited by
- (diff)
- 4:54 PM Changeset in webkit [54264] by
-
- 2 edits in trunk/WebCore
2010-02-02 David Levin <levin@chromium.org>
No review, rolling out r54245.
http://trac.webkit.org/changeset/54245
https://bugs.webkit.org/show_bug.cgi?id=34492
This patch seems to have broken thousands of chromium tests on
Windows (and since it was for chromium, I'm rolling it out).
- dom/Element.cpp: (WebCore::Element::baseURI):
- 4:25 PM Changeset in webkit [54263] by
-
- 8 edits1 add in trunk
2010-02-02 Steve Falkenburg <sfalken@apple.com>
Reviewed by Darin Adler.
Copyright year updating for Windows version resources should be automatic
https://bugs.webkit.org/show_bug.cgi?id=34503
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.rc:
2010-02-02 Steve Falkenburg <sfalken@apple.com>
Reviewed by Darin Adler.
Copyright year updating for Windows version resources should be automatic
https://bugs.webkit.org/show_bug.cgi?id=34503
- win/tools/scripts/auto-version.sh:
2010-02-02 Steve Falkenburg <sfalken@apple.com>
Reviewed by Darin Adler.
Copyright year updating for Windows version resources should be automatic
https://bugs.webkit.org/show_bug.cgi?id=34503
- WebKit.vcproj/WebKit.rc:
2010-02-02 Steve Falkenburg <sfalken@apple.com>
Reviewed by Darin Adler.
Copyright year updating for Windows version resources should be automatic
https://bugs.webkit.org/show_bug.cgi?id=34503
- WebCore.vcproj/QTMovieWin.rc:
- 4:05 PM Changeset in webkit [54262] by
-
- 4 edits in trunk/WebCore
2010-02-02 Dimitri Glazkov <Dimitri Glazkov>
No review, rolling out r54257.
http://trac.webkit.org/changeset/54257
https://bugs.webkit.org/show_bug.cgi?id=34491
[Chromium] broke thousands of Win tests and a few of Linux tests.
- platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContext::beginTransparencyLayer):
- platform/graphics/skia/PlatformContextSkia.cpp: (PlatformContextSkia::applyAntiAliasedClipPaths):
- platform/graphics/skia/PlatformContextSkia.h:
- 4:03 PM Changeset in webkit [54261] by
-
- 3 edits2 adds in trunk/WebCore
2010-02-02 Philippe Normand <pnormand@igalia.com>
Reviewed by Gustavo Noronha Silva.
[Gtk] libsoup critical warning in media player http cookies injection code
https://bugs.webkit.org/show_bug.cgi?id=34435
Fixed the critical warning and refactored the
User-Agent/Referer/cookies injection code, in that order. Previous
order (cookies first) was wrong because if cookies injection could
not be done neither the User-Agent not Referer were injected. Also
started a non-JSC-specific, gtk-specific GOwnPtr module.
- GNUmakefile.am:
- platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::mediaPlayerPrivateSourceChangedCallback):
- platform/gtk/GOwnPtrGtk.cpp: Added. (WTF::SoupURI): (WTF::GstElement):
- platform/gtk/GOwnPtrGtk.h: Added.
- 3:37 PM Changeset in webkit [54260] by
-
- 5 edits in trunk
2010-02-02 Gustavo Noronha Silva <Gustavo Noronha Silva>
Reviewed by Xan Lopez.
Bump version, and adjust library versioning for 1.1.20.
- configure.ac:
WebKit/gtk
2010-02-02 Gustavo Noronha Silva <Gustavo Noronha Silva>
Reviewed by Xan Lopez.
Changes in 1.1.20, and documentation control files update.
- NEWS:
- docs/webkitgtk-docs.sgml:
- 3:23 PM Changeset in webkit [54259] by
-
- 45 edits in trunk/WebCore
2010-02-02 Nate Chapin <Nate Chapin>
Reviewed by Dimitri Glazkov.
[V8] Use toV8() to wrap in the custom bindings, and remove
the old wrapping code from V8DOMWrapper.
- bindings/v8/ScriptController.cpp:
- bindings/v8/ScriptObject.cpp:
- bindings/v8/V8AbstractEventListener.cpp:
- bindings/v8/V8Collection.h:
- bindings/v8/V8DOMWindowShell.cpp:
- bindings/v8/V8DOMWrapper.cpp:
- bindings/v8/V8DOMWrapper.h:
- bindings/v8/V8NodeFilterCondition.cpp:
- bindings/v8/V8Proxy.cpp:
- bindings/v8/custom/V8CanvasRenderingContext2DCustom.cpp:
- bindings/v8/custom/V8CustomPositionCallback.cpp:
- bindings/v8/custom/V8CustomPositionErrorCallback.cpp:
- bindings/v8/custom/V8CustomSQLStatementCallback.cpp:
- bindings/v8/custom/V8CustomSQLStatementErrorCallback.cpp:
- bindings/v8/custom/V8CustomSQLTransactionCallback.cpp:
- bindings/v8/custom/V8CustomSQLTransactionErrorCallback.cpp:
- bindings/v8/custom/V8DOMWindowCustom.cpp:
- bindings/v8/custom/V8DataGridColumnListCustom.cpp:
- bindings/v8/custom/V8DocumentCustom.cpp:
- bindings/v8/custom/V8DocumentLocationCustom.cpp:
- bindings/v8/custom/V8ElementCustom.cpp:
- bindings/v8/custom/V8EventCustom.cpp:
- bindings/v8/custom/V8HTMLAllCollectionCustom.cpp:
- bindings/v8/custom/V8HTMLAudioElementConstructor.cpp:
- bindings/v8/custom/V8HTMLCanvasElementCustom.cpp:
- bindings/v8/custom/V8HTMLCollectionCustom.cpp:
- bindings/v8/custom/V8HTMLDocumentCustom.cpp:
- bindings/v8/custom/V8HTMLFormElementCustom.cpp:
- bindings/v8/custom/V8HTMLFrameSetElementCustom.cpp:
- bindings/v8/custom/V8HTMLImageElementConstructor.cpp:
- bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp:
- bindings/v8/custom/V8HTMLSelectElementCustom.cpp:
- bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
- bindings/v8/custom/V8MessageChannelConstructor.cpp:
- bindings/v8/custom/V8MessageEventCustom.cpp:
- bindings/v8/custom/V8NamedNodeMapCustom.cpp:
- bindings/v8/custom/V8NodeIteratorCustom.cpp:
- bindings/v8/custom/V8NodeListCustom.cpp:
- bindings/v8/custom/V8NotificationCenterCustom.cpp:
- bindings/v8/custom/V8SVGMatrixCustom.cpp:
- bindings/v8/custom/V8StyleSheetListCustom.cpp:
- bindings/v8/custom/V8TreeWalkerCustom.cpp:
- bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:
- bindings/v8/custom/V8XSLTProcessorCustom.cpp:
- 3:16 PM Changeset in webkit [54258] by
-
- 2 edits in trunk/WebKitSite
Clarified coding guidelines on wiki to allow indentation of _nested_ namespaces.
Reviewed by David Levin.
https://bugs.webkit.org/show_bug.cgi?id=32137
- 3:06 PM Changeset in webkit [54257] by
-
- 4 edits in trunk/WebCore
2010-02-02 Garret Kelly <gdk@chromium.org>
Reviewed by David Levin.
When using the Skia graphics context, the beginTransparencyLayer call
currently creates a new layer, but does not keep the current
compositing mode for use when merging the created layer back onto the
rest of the context. This patch fixes that.
https://bugs.webkit.org/show_bug.cgi?id=34491
fast/backgrounds/svg-as-mask.html is affected by this change in Chromium,
but not fixed. This is the first of a series of patches to fix it.
- platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContext::beginTransparencyLayer):
- platform/graphics/skia/PlatformContextSkia.cpp: (PlatformContextSkia::beginTransparencyLayer):
- platform/graphics/skia/PlatformContextSkia.h:
- 2:50 PM Changeset in webkit [54256] by
-
- 3 edits in trunk/WebCore
2010-02-02 Kwang Yul Seo <skyul@company100.net>
Reviewed by Eric Seidel.
Use WTF::getLocalTime instead of localtime_r in FTPDirectoryDocument
https://bugs.webkit.org/show_bug.cgi?id=34409
Platform guards for localtime_r are not needed because we already have
WTF::getLocalTime which does the same thing.
- loader/FTPDirectoryDocument.cpp: (WebCore::processFileDateString):
- loader/FTPDirectoryParser.cpp: (WebCore::gmtimeQt):
- 2:34 PM Changeset in webkit [54255] by
-
- 1 edit2 adds in trunk/JavaScriptCore
2010-02-02 Kwang Yul Seo <skyul@company100.net>
Reviewed by Eric Seidel.
[BREWMP] Add dummy main thread functions
https://bugs.webkit.org/show_bug.cgi?id=33569
Add dummy initializeMainThreadPlatform and
scheduleDispatchFunctionsOnMainThread.
- wtf/brew/MainThreadBrew.cpp: Added. (WTF::initializeMainThreadPlatform): (WTF::scheduleDispatchFunctionsOnMainThread):
- 2:29 PM Changeset in webkit [54254] by
-
- 2 edits in trunk/LayoutTests
2010-02-02 Eric Seidel <eric@webkit.org>
Reviewed by Gustavo Noronha Silva.
http/tests/incremental/split-hex-entities.pl timed out on Gtk Linux 32-bit Debug Bot
https://bugs.webkit.org/show_bug.cgi?id=33445
- platform/gtk/Skipped: Skip this test to keep the bots green until someone with Gtk knowledge can examine why it intermittently times out.
- 2:18 PM Changeset in webkit [54253] by
-
- 4 edits1 copy3 moves1 add in trunk/LayoutTests
2010-02-02 Hayato Ito <hayato@chromium.org>
Reviewed by Darin Adler.
Move misplaced JS files to the proper location.
- fast/events/script-tests/basic-touch-events.js: Removed.
- fast/events/script-tests/create-touch-event.js: Removed.
- fast/events/script-tests/send-oncancel-event.js: Removed.
- fast/events/touch/basic-touch-events.html:
- fast/events/touch/create-touch-event.html:
- fast/events/touch/script-tests: Added.
- fast/events/touch/script-tests/TEMPLATE.html: Copied from LayoutTests/fast/events/script-tests/TEMPLATE.html.
- fast/events/touch/script-tests/basic-touch-events.js: Copied from LayoutTests/fast/events/script-tests/basic-touch-events.js.
- fast/events/touch/script-tests/create-touch-event.js: Copied from LayoutTests/fast/events/script-tests/create-touch-event.js.
- fast/events/touch/script-tests/send-oncancel-event.js: Copied from LayoutTests/fast/events/script-tests/send-oncancel-event.js.
- fast/events/touch/send-oncancel-event.html:
- 2:00 PM Changeset in webkit [54252] by
-
- 5 edits in trunk/WebKit/mac
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=34502
Unused method pluginLayer in Netscape plug-in views
- Plugins/Hosted/WebHostedNetscapePluginView.h:
- Plugins/Hosted/WebHostedNetscapePluginView.mm:
- Plugins/WebNetscapePluginView.h:
- Plugins/WebNetscapePluginView.mm: Removed the method.
- 1:23 PM Changeset in webkit [54251] by
-
- 4 edits2 adds in branches/safari-4-branch
Merge r54242.
- 1:09 PM Changeset in webkit [54250] by
-
- 2 edits in trunk/WebCore
Copy WebCore's bindings generation scripts to the PrivateHeaders directory on Mac
This will allow other projects to use these scripts.
Fixes <http://webkit.org/b/34498>.
Reviewed by Mark Rowe.
- WebCore.xcodeproj/project.pbxproj: Added the bindings generation
scripst to the Copy Headers phase, and marked them as Private.
- 12:55 PM Changeset in webkit [54249] by
-
- 3 edits in trunk/WebCore
Copy WebCore's bindings generation scripts to a more sensible location
Part of Bug 34496: Clean up WebCore's IDL/script copying
<https://bugs.webkit.org/show_bug.cgi?id=34496>
Reviewed by Steve Falkenburg.
- WebCore.vcproj/WebCore.make:
- WebCore.vcproj/WebCoreGenerated.vcproj:
Instead of copying to obj/WebKit/DOMInterfaces, copy to obj/WebCore/scripts.
- 12:54 PM Changeset in webkit [54248] by
-
- 2 edits2 moves in trunk/WebCore
Rename the scripts used to copy WebCore's bindings generation scripts
Part of Bug 34496: Clean up WebCore's IDL/script copying
<https://bugs.webkit.org/show_bug.cgi?id=34496>
Reviewed by Steve Falkenburg.
- WebCore.vcproj/MigrateScripts: Renamed from WebCore/WebCore.vcproj/MigrateIDLAndScripts.
- WebCore.vcproj/migrate-scripts.sh: Renamed from WebCore/WebCore.vcproj/migrate-idls.sh.
- WebCore.vcproj/WebCoreGenerated.vcproj: Updated for renames.
- 12:54 PM Changeset in webkit [54247] by
-
- 2 edits in trunk/WebCore
Stop copying IDL files into $(WebKitOutputDir)
No one uses these anymore (as of r52921).
Part of Bug 34496: Clean up WebCore's IDL/script copying
<https://bugs.webkit.org/show_bug.cgi?id=34496>
Reviewed by Steve Falkenburg.
- WebCore.vcproj/MigrateIDLAndScripts: Don't copy the IDL files
anymore. Keep copying the scripts, though, since other projects
(outside of the WebKit repository) do use those.
- 12:54 PM Changeset in webkit [54246] by
-
- 2 edits in trunk/WebKit/win
Stop copying WebCore's IDL files from SRCROOT to OBJROOT
WebKit doesn't use these anymore (as of r52921).
Part of Bug 34496: Clean up WebCore's IDL/script copying
<https://bugs.webkit.org/show_bug.cgi?id=34496>
Reviewed by Steve Falkenburg.
- WebKit.vcproj/WebKit.make:
- 12:04 PM Changeset in webkit [54245] by
-
- 2 edits in trunk/WebCore
2010-02-02 Bryan Yeung <bryeung@bryeung-chrome.(none)>
Reviewed by Darin Adler.
Avoid using an invalidated KURL object in baseURI.
This change fixes baseURI for Chromium (where the KURL implementation
does not allow invalid KURLs to carry relative paths). This is
regression tested by
LayoutTests/svg/W3C-SVG-1.1/struct-image-07-t.svg
- dom/Element.cpp: (WebCore::Element::baseURI):
- 11:47 AM Changeset in webkit [54244] by
-
- 2 edits in trunk/JavaScriptCore
2010-02-02 Kwang Yul Seo <skyul@company100.net>
Reviewed by Darin Adler.
Add using WTF::getLocalTime to CurrentTime.h
https://bugs.webkit.org/show_bug.cgi?id=34493
- wtf/CurrentTime.h:
- 10:16 AM Changeset in webkit [54243] by
-
- 2 edits in trunk/WebKitTools
Add myself to list of committers.
- 10:00 AM Changeset in webkit [54242] by
-
- 4 edits2 adds in trunk
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=34076
<rdar://problem/7594601> Crash in mangleme in WebCore::Element::getAttribute
Test: fast/forms/misplaced-img-form-registration.html
- html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::registerImgElement): Assert that the same image isn't added to vector again. (WebCore::HTMLFormElement::removeImgElement): Similarly, assert that we're removing something that's actually registered.
- html/HTMLImageElement.cpp: (WebCore::HTMLImageElement::~HTMLImageElement): If parser fails to insert the image element, then there will be no removed from tree notification either, need to unregister right away.
- 9:19 AM Changeset in webkit [54241] by
-
- 2 edits in trunk/WebKit/qt
Do not use a proxy widget for the QComboBox on Maemo 5, as it
is not working properly and it is not needed at all, as the
comboboxes comes up in their full width on the screen and
do not depend on view.
Reviewed by Ariya Hidayat.
- WebCoreSupport/QtFallbackWebPopup.cpp:
(WebCore::QtFallbackWebPopup::show):
- 9:08 AM Changeset in webkit [54240] by
-
- 5 edits in trunk/WebCore
2010-02-02 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: Eliminate some of the platform flavor-specific stylesheet selectors
Extract OS version into WebInspector.platformFlavor
https://bugs.webkit.org/show_bug.cgi?id=34469
- inspector/front-end/InspectorBackendStub.js:
- inspector/front-end/InspectorFrontendHostStub.js: (.WebInspector.InspectorFrontendHostStub.prototype.platform):
- inspector/front-end/inspector.css:
- inspector/front-end/inspector.js: (WebInspector.pendingDispatches.0.URLRegExp.i.get platform): (WebInspector.get platformFlavor): (WebInspector._detectPlatformFlavor): (WebInspector.loaded): (WebInspector.toolbarDragStart): (WebInspector.isMac):
- 8:35 AM Changeset in webkit [54239] by
-
- 2 edits in trunk/WebKitLibraries
2010-02-02 Martin Robinson <Martin Robinson>
Unreviewed build fix.
The WinCairo build requires this script to be executable.
- win/tools/scripts/feature-defines.sh: Added property svn:executable.
- 7:48 AM Changeset in webkit [54238] by
-
- 2 edits in trunk/LayoutTests
Stop skipping some tests that were failing due to buggy versions of CFNetwork
Rubber-stamped by Eric Carlson.
- platform/win/Skipped:
- 7:45 AM Changeset in webkit [54237] by
-
- 2 edits2 adds in trunk/WebCore
2010-02-02 Steve Block <steveblock@google.com>
Reviewed by Ariya Hidayat.
Adds utility functions for converting between JavaInstance and NPAPI types
https://bugs.webkit.org/show_bug.cgi?id=34468
This is required by Android for injecting objects into V8 JavaScript.
No new tests, added utility functions only.
- Android.v8bindings.mk: Modified. Added JavaNPObjectV8.cpp
- bridge/jni/v8/JavaNPObjectV8.cpp: Added. (JSC::Bindings::AllocJavaNPObject): (JSC::Bindings::FreeJavaNPObject): (JSC::Bindings::): (JSC::Bindings::JavaInstanceToNPObject): (JSC::Bindings::ExtractJavaInstance): (JSC::Bindings::JavaNPObjectHasMethod): (JSC::Bindings::JavaNPObjectInvoke): (JSC::Bindings::JavaNPObjectHasProperty): (JSC::Bindings::JavaNPObjectGetProperty):
- bridge/jni/v8/JavaNPObjectV8.h: Added.
- 7:42 AM QtWebKitJSCapp edited by
- (diff)
- 7:35 AM QtWebKitJSCapp created by
- 7:35 AM Changeset in webkit [54236] by
-
- 2 edits in trunk/WebKit/qt
2010-02-02 Jessie Berlin <jberlin@webkit.org>
Rubber Stamped by Holger Freyther.
[Qt] Fix style issue identified in bug:
https://bugs.webkit.org/show_bug.cgi?id=34329
- WebCoreSupport/InspectorClientQt.cpp: (WebCore::InspectorClientWebPage::InspectorClientWebPage): Fix indentation.
- 7:31 AM QtWebKit edited by
- added new page for jsc.exe (diff)
- 7:29 AM Changeset in webkit [54235] by
-
- 2 edits in trunk/WebCore
2010-02-02 Benjamin Poulain <benjamin.poulain@nokia.com>
Reviewed by Ariya Hidayat.
[Qt] Symbian plugins include a wrong header file for QPixmap
https://bugs.webkit.org/show_bug.cgi?id=34475
- plugins/symbian/PluginViewSymbian.cpp:
- 7:28 AM Changeset in webkit [54234] by
-
- 4 edits2 adds in trunk/WebKitTools
2010-02-02 Chris Jerdonek <Chris Jerdonek>
Reviewed by Shinichiro Hamaji.
Moved filter-related check-webkit-style code into a separate
filter module.
This is preparatory refactoring for Bug 33684, which will allow
file and folder-specific filter rules.
- Scripts/webkitpy/style/checker.py:
- Removed CategoryFilter class (moved to filter.py).
- Scripts/webkitpy/style/checker_unittest.py:
- Removed CategoryFilter unit tests (moved to filter_unittest.py).
- Scripts/webkitpy/style/filter.py: Added.
- Added CategoryFilter class (moved from checker.py).
- Scripts/webkitpy/style/filter_unittest.py: Added.
- Added CategoryFilter unit tests (moved from checker_unittest.py).
- Scripts/webkitpy/style/unittests.py:
- Added reference to filter_unittest.py.
- 7:25 AM Changeset in webkit [54233] by
-
- 2 edits in trunk/WebKit/qt
2010-02-01 Jessie Berlin <jberlin@webkit.org>
Reviewed by Holger Freyther.
[Qt] Enable inspecting the Web Inspector in QtLauncher
- WebCoreSupport/InspectorClientQt.cpp: (WebCore::InspectorClientWebPage::InspectorClientWebPage): Allow the DeveloperExtrasEnabled setting to default to true for the page containing the Web Inspector.
- 6:22 AM Changeset in webkit [54232] by
-
- 2 edits18 adds in trunk/WebKit/chromium
2010-02-02 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Upstream DevTools code.
- WebKit.gyp:
- src/APUAgentDelegate.h: Added.
- src/BoundObject.cpp: Added. (WebKit::BoundObject::BoundObject): (WebKit::BoundObject::~BoundObject): (WebKit::BoundObject::addProtoFunction): (WebKit::BoundObject::build):
- src/BoundObject.h: Added.
- src/DebuggerAgent.h: Added.
- src/DebuggerAgentImpl.cpp: Added. (WebKit::DebuggerAgentImpl::DebuggerAgentImpl): (WebKit::DebuggerAgentImpl::~DebuggerAgentImpl): (WebKit::DebuggerAgentImpl::getContextId): (WebKit::DebuggerAgentImpl::debuggerOutput): (WebKit::DebuggerAgentImpl::createUtilityContext): (WebKit::DebuggerAgentImpl::executeUtilityFunction): (WebKit::DebuggerAgentImpl::executeVoidJavaScript): (WebKit::DebuggerAgentImpl::page):
- src/DebuggerAgentImpl.h: Added. (WebKit::DebuggerAgentImpl::setAutoContinueOnException): (WebKit::DebuggerAgentImpl::autoContinueOnException): (WebKit::DebuggerAgentImpl::webdevtoolsAgent): (WebKit::DebuggerAgentImpl::webView):
- src/DebuggerAgentManager.cpp: Added. (WebKit::DebuggerAgentManager::debugHostDispatchHandler): (WebKit::DebuggerAgentManager::debugAttach): (WebKit::DebuggerAgentManager::debugDetach): (WebKit::DebuggerAgentManager::onV8DebugMessage): (WebKit::DebuggerAgentManager::pauseScript): (WebKit::DebuggerAgentManager::executeDebuggerCommand): (WebKit::DebuggerAgentManager::setMessageLoopDispatchHandler): (WebKit::DebuggerAgentManager::setHostId): (WebKit::DebuggerAgentManager::onWebViewClosed): (WebKit::DebuggerAgentManager::onNavigate): (WebKit::DebuggerAgentManager::sendCommandToV8): (WebKit::DebuggerAgentManager::sendContinueCommandToV8): (WebKit::DebuggerAgentManager::findAgentForCurrentV8Context): (WebKit::DebuggerAgentManager::debuggerAgentForHostId):
- src/DebuggerAgentManager.h: Added. (WebKit::DebuggerAgentManager::UtilityContextScope::UtilityContextScope): (WebKit::DebuggerAgentManager::UtilityContextScope::~UtilityContextScope):
- src/DevToolsRPC.h: Added. (WebKit::): (WebKit::DevToolsRPC::Delegate::Delegate): (WebKit::DevToolsRPC::Delegate::~Delegate): (WebKit::DevToolsRPC::DevToolsRPC): (WebKit::DevToolsRPC::~DevToolsRPC): (WebKit::DevToolsRPC::sendRpcMessage):
- src/DevToolsRPCJS.h: Added.
- src/ProfilerAgent.h: Added.
- src/ProfilerAgentImpl.cpp: Added. (WebKit::ProfilerAgentImpl::getActiveProfilerModules): (WebKit::ProfilerAgentImpl::getLogLines):
- src/ProfilerAgentImpl.h: Added. (WebKit::ProfilerAgentImpl::ProfilerAgentImpl): (WebKit::ProfilerAgentImpl::~ProfilerAgentImpl):
- src/ToolsAgent.h: Added.
- src/WebDevToolsAgentImpl.cpp: Added. (WebKit::): (WebKit::WebDevToolsAgentImpl::WebDevToolsAgentImpl): (WebKit::WebDevToolsAgentImpl::~WebDevToolsAgentImpl): (WebKit::WebDevToolsAgentImpl::disposeUtilityContext): (WebKit::WebDevToolsAgentImpl::unhideResourcesPanelIfNecessary): (WebKit::WebDevToolsAgentImpl::attach): (WebKit::WebDevToolsAgentImpl::detach): (WebKit::WebDevToolsAgentImpl::didNavigate): (WebKit::WebDevToolsAgentImpl::didCommitProvisionalLoad): (WebKit::WebDevToolsAgentImpl::didClearWindowObject): (WebKit::WebDevToolsAgentImpl::forceRepaint): (WebKit::WebDevToolsAgentImpl::dispatchOnInspectorController): (WebKit::WebDevToolsAgentImpl::dispatchOnInjectedScript): (WebKit::WebDevToolsAgentImpl::executeVoidJavaScript): (WebKit::WebDevToolsAgentImpl::dispatchMessageFromFrontend): (WebKit::WebDevToolsAgentImpl::inspectElementAt): (WebKit::WebDevToolsAgentImpl::setRuntimeFeatureEnabled): (WebKit::WebDevToolsAgentImpl::sendRpcMessage): (WebKit::WebDevToolsAgentImpl::compileUtilityScripts): (WebKit::WebDevToolsAgentImpl::initDevToolsAgentHost): (WebKit::WebDevToolsAgentImpl::createInspectorBackendV8Wrapper): (WebKit::WebDevToolsAgentImpl::resetInspectorFrontendProxy): (WebKit::WebDevToolsAgentImpl::setApuAgentEnabled): (WebKit::WebDevToolsAgentImpl::jsDispatchOnClient): (WebKit::WebDevToolsAgentImpl::jsDispatchToApu): (WebKit::WebDevToolsAgentImpl::jsEvaluateOnSelf): (WebKit::WebDevToolsAgentImpl::jsOnRuntimeFeatureStateChanged): (WebKit::WebDevToolsAgentImpl::inspectorController): (WebKit::WebDevToolsAgentImpl::identifierForInitialRequest): (WebKit::WebDevToolsAgentImpl::willSendRequest): (WebKit::WebDevToolsAgentImpl::didReceiveData): (WebKit::WebDevToolsAgentImpl::didReceiveResponse): (WebKit::WebDevToolsAgentImpl::didFinishLoading): (WebKit::WebDevToolsAgentImpl::didFailLoading): (WebKit::WebDevToolsAgentImpl::evaluateInWebInspector): (WebKit::WebDevToolsAgentImpl::setTimelineProfilingEnabled): (WebKit::WebDevToolsAgent::create): (WebKit::WebDevToolsAgent::executeDebuggerCommand): (WebKit::WebDevToolsAgent::debuggerPauseScript): (WebKit::WebDevToolsAgent::setMessageLoopDispatchHandler): (WebKit::WebDevToolsAgent::dispatchMessageFromFrontendOnIOThread):
- src/WebDevToolsAgentImpl.h: Added. (WebKit::WebDevToolsAgentImpl::hostId):
- src/WebDevToolsFrontendImpl.cpp: Added. (WebKit::ToV8String): (WebKit::WebDevToolsFrontend::create): (WebKit::WebDevToolsFrontendImpl::WebDevToolsFrontendImpl): (WebKit::WebDevToolsFrontendImpl::~WebDevToolsFrontendImpl): (WebKit::WebDevToolsFrontendImpl::dispatchMessageFromAgent): (WebKit::WebDevToolsFrontendImpl::executeScript): (WebKit::WebDevToolsFrontendImpl::dispatchOnWebInspector): (WebKit::WebDevToolsFrontendImpl::sendRpcMessage): (WebKit::WebDevToolsFrontendImpl::contextMenuItemSelected): (WebKit::WebDevToolsFrontendImpl::contextMenuCleared): (WebKit::WebDevToolsFrontendImpl::jsLoaded): (WebKit::WebDevToolsFrontendImpl::jsPlatform): (WebKit::WebDevToolsFrontendImpl::jsPort): (WebKit::WebDevToolsFrontendImpl::jsCopyText): (WebKit::WebDevToolsFrontendImpl::jsActivateWindow): (WebKit::WebDevToolsFrontendImpl::jsCloseWindow): (WebKit::WebDevToolsFrontendImpl::jsDockWindow): (WebKit::WebDevToolsFrontendImpl::jsUndockWindow): (WebKit::WebDevToolsFrontendImpl::jsLocalizedStringsURL): (WebKit::WebDevToolsFrontendImpl::jsHiddenPanels): (WebKit::WebDevToolsFrontendImpl::jsDebuggerCommand): (WebKit::WebDevToolsFrontendImpl::jsSetting): (WebKit::WebDevToolsFrontendImpl::jsSetSetting): (WebKit::WebDevToolsFrontendImpl::jsDebuggerPauseScript): (WebKit::WebDevToolsFrontendImpl::jsWindowUnloading): (WebKit::WebDevToolsFrontendImpl::jsShowContextMenu):
- src/WebDevToolsFrontendImpl.h: Added. (WebKit::WebDevToolsFrontendImpl::MenuProvider::create): (WebKit::WebDevToolsFrontendImpl::MenuProvider::~MenuProvider): (WebKit::WebDevToolsFrontendImpl::MenuProvider::disconnect): (WebKit::WebDevToolsFrontendImpl::MenuProvider::populateContextMenu): (WebKit::WebDevToolsFrontendImpl::MenuProvider::contextMenuItemSelected): (WebKit::WebDevToolsFrontendImpl::MenuProvider::contextMenuCleared): (WebKit::WebDevToolsFrontendImpl::MenuProvider::MenuProvider):
- 6:20 AM Nightly Builds edited by
- (diff)
- 5:59 AM Changeset in webkit [54231] by
-
- 11 edits in trunk/WebCore
2010-02-02 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: URLs are not syntax-higlighted as links in source view.
This change enables linkifier in the NativeTextViewer. It adds
"linkify" and "a_node" parse states into the highlighter in order
to detect links and distinguish between resource and external ones.
Contains drive-by fix for the webkit-html-* styles and moves them to the
common location.
- inspector/front-end/NativeTextViewer.js: (WebInspector.NativeTextViewer): (WebInspector.NativeTextViewer.prototype._createSpan): (WebInspector.NativeTextViewer.prototype._createLink): (WebInspector.NativeTextViewer.prototype._rewriteHref):
- inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype.setContent): (WebInspector.SourceFrame.prototype._createEditorIfNeeded):
- inspector/front-end/SourceHTMLTokenizer.js: (WebInspector.SourceHTMLTokenizer): (WebInspector.SourceHTMLTokenizer.prototype._isExpectingAttribute): (WebInspector.SourceHTMLTokenizer.prototype._isExpectingAttributeValue): (WebInspector.SourceHTMLTokenizer.prototype._setExpectingAttribute): (WebInspector.SourceHTMLTokenizer.prototype._setExpectingAttributeValue): (WebInspector.SourceHTMLTokenizer.prototype._stringToken): (WebInspector.SourceHTMLTokenizer.prototype._attrValueTokenType): (WebInspector.SourceHTMLTokenizer.prototype.nextToken):
- inspector/front-end/SourceHTMLTokenizer.re2js:
- inspector/front-end/SourceView.js: (WebInspector.SourceView.prototype._contentLoaded):
- inspector/front-end/TextEditorHighlighter.js: (WebInspector.TextEditorHighlighter):
- inspector/front-end/inspector.css:
- inspector/front-end/inspectorSyntaxHighlight.css:
- 5:32 AM Changeset in webkit [54230] by
-
- 2 edits in trunk/WebKit/gtk
2010-02-02 Martin Robinson <martin.james.robinson@gmail.com>
Reviewed by Gustavo Noronha Silva.
[GTK] When selection changes selections in other WebView are not collapsed
https://bugs.webkit.org/show_bug.cgi?id=34043
Collapse the selection of a WebView even when the new selection owner is
a new WebView.
- WebCoreSupport/PasteboardHelperGtk.cpp: (WebKit::clearClipboardContentsCallback): Only clear the DataObject we are setting is not the same as the one referenced in this callback. Use the same behavior for collapsing the selection. (WebKit::PasteboardHelperGtk::writeClipboardContents): Instead of recording a boolean record the actual data used while writing to the clipboard.
- 5:16 AM Changeset in webkit [54229] by
-
- 2 edits in trunk/WebCore
2010-02-02 Simon Hausmann <simon.hausmann@nokia.com>
Reviewed by Ariya Hidayat.
[Qt] Install libraries and headers in package builds
https://bugs.webkit.org/show_bug.cgi?id=34325
Add the QtWebKit libraries to the installable items, except on
Symbian where the libraries are always linked in their final
destination.
Also include the headers generated by syncqt in the installation.
- WebCore.pro:
- 4:59 AM Changeset in webkit [54228] by
-
- 2 edits in trunk/WebKit/qt
2010-02-02 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Display HTML tags verbatim in JS alert/confirm/prompt boxes
- Api/qwebpage.cpp: (QWebPage::javaScriptAlert): (QWebPage::javaScriptConfirm): (QWebPage::javaScriptPrompt):
- 4:43 AM Changeset in webkit [54227] by
-
- 2 edits in trunk/WebCore
2010-02-02 Kavita Kanetkar <kkanetkar@chromium.org>
Reviewed by Dmitry Titov.
[V8] Raising an exception while setting timeout/interval from a detached frame
https://bugs.webkit.org/show_bug.cgi?id=34453
This fixes the issue/failing test mentioned in Chromium bug:
http://code.google.com/p/chromium/issues/detail?id=32671
- bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::WindowSetTimeoutImpl):
- 4:27 AM Changeset in webkit [54226] by
-
- 1 edit1 add in trunk/WebCore
2010-02-02 Kwang Yul Seo <skyul@company100.net>
Reviewed by Eric Seidel.
[BREWMP] Port Screen
https://bugs.webkit.org/show_bug.cgi?id=34299
Get the screen size and depth from the main display bitmap.
- platform/brew/ScreenBrew.cpp: Added. (WebCore::getDisplayInfo): (WebCore::screenRect): (WebCore::screenAvailableRect): (WebCore::screenDepth): (WebCore::screenDepthPerComponent): (WebCore::screenIsMonochrome):
- 4:10 AM Changeset in webkit [54225] by
-
- 1 edit1 add in trunk/WebCore
2010-02-02 Kwang Yul Seo <skyul@company100.net>
Reviewed by Eric Seidel.
[BREWMP] Port LocalizedStrings
https://bugs.webkit.org/show_bug.cgi?id=34257
Port LocalizedStrings to BREWMP.
- platform/brew/LocalizedStringsBrew.cpp: Added. (WebCore::submitButtonDefaultLabel): (WebCore::inputElementAltText): (WebCore::resetButtonDefaultLabel): (WebCore::defaultLanguage): (WebCore::searchableIndexIntroduction): (WebCore::fileButtonChooseFileLabel): (WebCore::fileButtonNoFileSelectedLabel): (WebCore::contextMenuItemTagOpenLinkInNewWindow): (WebCore::contextMenuItemTagDownloadLinkToDisk): (WebCore::contextMenuItemTagCopyLinkToClipboard): (WebCore::contextMenuItemTagOpenImageInNewWindow): (WebCore::contextMenuItemTagDownloadImageToDisk): (WebCore::contextMenuItemTagCopyImageToClipboard): (WebCore::contextMenuItemTagOpenFrameInNewWindow): (WebCore::contextMenuItemTagCopy): (WebCore::contextMenuItemTagGoBack): (WebCore::contextMenuItemTagGoForward): (WebCore::contextMenuItemTagStop): (WebCore::contextMenuItemTagReload): (WebCore::contextMenuItemTagCut): (WebCore::contextMenuItemTagPaste): (WebCore::contextMenuItemTagNoGuessesFound): (WebCore::contextMenuItemTagIgnoreSpelling): (WebCore::contextMenuItemTagLearnSpelling): (WebCore::contextMenuItemTagSearchWeb): (WebCore::contextMenuItemTagLookUpInDictionary): (WebCore::contextMenuItemTagOpenLink): (WebCore::contextMenuItemTagIgnoreGrammar): (WebCore::contextMenuItemTagSpellingMenu): (WebCore::contextMenuItemTagShowSpellingPanel): (WebCore::contextMenuItemTagCheckSpelling): (WebCore::contextMenuItemTagCheckSpellingWhileTyping): (WebCore::contextMenuItemTagCheckGrammarWithSpelling): (WebCore::contextMenuItemTagFontMenu): (WebCore::contextMenuItemTagBold): (WebCore::contextMenuItemTagItalic): (WebCore::contextMenuItemTagUnderline): (WebCore::contextMenuItemTagOutline): (WebCore::contextMenuItemTagWritingDirectionMenu): (WebCore::contextMenuItemTagDefaultDirection): (WebCore::contextMenuItemTagLeftToRight): (WebCore::contextMenuItemTagRightToLeft): (WebCore::contextMenuItemTagInspectElement): (WebCore::searchMenuNoRecentSearchesText): (WebCore::searchMenuRecentSearchesText): (WebCore::searchMenuClearRecentSearchesText): (WebCore::unknownFileSizeText): (WebCore::AXWebAreaText): (WebCore::AXLinkText): (WebCore::AXListMarkerText): (WebCore::AXImageMapText): (WebCore::AXHeadingText): (WebCore::imageTitle): (WebCore::contextMenuItemTagTextDirectionMenu): (WebCore::AXButtonActionVerb): (WebCore::AXTextFieldActionVerb): (WebCore::AXRadioButtonActionVerb): (WebCore::AXCheckedCheckBoxActionVerb): (WebCore::AXUncheckedCheckBoxActionVerb): (WebCore::AXLinkActionVerb): (WebCore::AXMenuListPopupActionVerb): (WebCore::AXMenuListActionVerb): (WebCore::AXDefinitionListTermText): (WebCore::AXDefinitionListDefinitionText): (WebCore::validationMessageValueMissingText): (WebCore::validationMessageTypeMismatchText): (WebCore::validationMessagePatternMismatchText): (WebCore::validationMessageTooLongText): (WebCore::validationMessageRangeUnderflowText): (WebCore::validationMessageRangeOverflowText): (WebCore::validationMessageStepMismatchText):
- 3:56 AM Changeset in webkit [54224] by
-
- 2 edits in trunk/LayoutTests
[Qt] fast/frames/set-unloaded-frame-location.html timed out on Qt Linux Release Build Bot
https://bugs.webkit.org/show_bug.cgi?id=33303
fast/frames/sandboxed-iframe-navigation-windowopen.html made fast/frames/set-unloaded-frame-location.html
time out, but now it works correctly, so we can unskip the test.
- platform/qt/Skipped: fast/frames/sandboxed-iframe-navigation-windowopen.html unskipped.
- 3:54 AM Changeset in webkit [54223] by
-
- 1 edit1 add in trunk/WebCore
2010-02-02 Kwang Yul Seo <skyul@company100.net>
Reviewed by Eric Seidel.
[BREWMP] Port systemBeep
https://bugs.webkit.org/show_bug.cgi?id=33601
Implement systemBeep with IShell_Beep.
- platform/brew/SoundBrew.cpp: Added. (WebCore::systemBeep):
- 3:38 AM Changeset in webkit [54222] by
-
- 2 edits in trunk/WebKit/qt
2010-02-02 Noam Rosenthal <noam.rosenthal@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Enable a way to measure FPS in QGVLauncher
run QGVLauncher with --show-fps to see ongoing fps measurements
This is not meant as accurate FPS, but rather as a way to find
improvements/regressions
https://bugs.webkit.org/show_bug.cgi?id=34450
- QGVLauncher/main.cpp: (MainView::MainView): initialize FPS values (MainView::paintEvent): count a painted frame here (MainView::printFps): we print the fps with qDebug every 5 seconds.
- 3:07 AM Changeset in webkit [54221] by
-
- 5 edits in trunk/WebCore
2010-02-02 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Eric Seidel.
[Win] Utilize PrintContext to share the printing code with other ports
https://bugs.webkit.org/show_bug.cgi?id=34312
No new tests as this is just a small refactoring.
- 2:54 AM Changeset in webkit [54220] by
-
- 2 edits in trunk/JavaScriptCore
2010-02-02 Kwang Yul Seo <skyul@company100.net>
Reviewed by Eric Seidel.
[BREWMP] Add HAVE_XXX definitions
https://bugs.webkit.org/show_bug.cgi?id=34414
Add HAVE_ERRNO_H=1
- wtf/Platform.h:
- 2:32 AM QtWebKitBackportingFixes edited by
- (diff)
- 2:27 AM Changeset in webkit [54219] by
-
- 2 edits1 add in trunk/WebCore
2010-02-02 Kwang Yul Seo <skyul@company100.net>
Reviewed by Eric Seidel.
[BREWMP] Add conversions between IntPoint and AEEPoint
https://bugs.webkit.org/show_bug.cgi?id=34194
Make it easy to convert between IntPoint and AEEPoint.
- platform/graphics/IntPoint.h:
- platform/graphics/brew/IntPointBrew.cpp: Added. (WebCore::IntPoint::IntPoint): (WebCore::IntPoint::operator AEEPoint):
- 1:58 AM Changeset in webkit [54218] by
-
- 2 edits in trunk/WebCore
Adds virtual destructors for AbstractWeakReferenceMap and AbstractWeakReferenceMap::Visitor
https://bugs.webkit.org/show_bug.cgi?id=34434
Reviewed by Adam Barth.
No new tests, build fix only.
- bindings/v8/V8DOMMap.h: Modified.
(WebCore::AbstractWeakReferenceMap::~AbstractWeakReferenceMap): Added.
(WebCore::AbstractWeakReferenceMap::Visitor::~Visitor): Added.
- 1:53 AM WebKit Team edited by
- Committer since last week (diff)
- 1:46 AM Changeset in webkit [54217] by
-
- 2 edits in trunk/JavaScriptCore
2010-02-02 Kwang Yul Seo <skyul@company100.net>
Reviewed by Eric Seidel.
[BREWMP] Don't define HAVE_TM_GMTOFF, HAVE_TM_ZONE and HAVE_TIMEGM
https://bugs.webkit.org/show_bug.cgi?id=34388
BREWMP does not have these features.
- wtf/Platform.h:
- 1:18 AM Changeset in webkit [54216] by
-
- 2 edits in trunk/JavaScriptCore
2010-02-02 Kwang Yul Seo <skyul@company100.net>
Reviewed by Eric Seidel.
[BREWMP] Define WTF_PLATFORM_BREWMP=1 when BUILDING_BREWMP is defined
https://bugs.webkit.org/show_bug.cgi?id=34386
Define WTF_PLATFORM_BREWMP=1 so that PLATFORM(BREWMP) guard can be used.
- wtf/Platform.h:
- 12:52 AM Changeset in webkit [54215] by
-
- 4 edits in trunk/WebCore
2010-02-02 Avi Drissman <avi@chromium.org>
Reviewed by Eric Seidel.
Sync up Chromium Mac render theme to Mac render theme
https://bugs.webkit.org/show_bug.cgi?id=34340
Covered by existing layout tests.
- platform/chromium/ThemeChromiumMac.mm: (WebCore::updateStates): (WebCore::checkbox): (WebCore::paintCheckbox): (WebCore::radio): (WebCore::paintRadio): (WebCore::listButtonSizes): (WebCore::setupButtonCell): (WebCore::button): (WebCore::paintButton): (WebCore::ThemeChromiumMac::controlSize): (WebCore::ThemeChromiumMac::minimumControlSize): (WebCore::ThemeChromiumMac::controlBorder): (WebCore::ThemeChromiumMac::paint):
- rendering/RenderThemeChromiumMac.h:
- rendering/RenderThemeChromiumMac.mm: (-[WebCoreRenderThemeNotificationObserver initWithTheme:WebCore::]): (WebCore::convertNSColorToColor): (WebCore::RenderThemeChromiumMac::systemColor): (WebCore::RenderThemeChromiumMac::isControlStyled): (WebCore::RenderThemeChromiumMac::adjustRepaintRect): (WebCore::RenderThemeChromiumMac::convertToPaintingRect): (WebCore::RenderThemeChromiumMac::paintCapsLockIndicator): (WebCore::RenderThemeChromiumMac::paintMenuList): (WebCore::RenderThemeChromiumMac::paintMenuListButton): (WebCore::RenderThemeChromiumMac::adjustMenuListStyle): (WebCore::RenderThemeChromiumMac::adjustMenuListButtonStyle): (WebCore::RenderThemeChromiumMac::paintSliderTrack): (WebCore::RenderThemeChromiumMac::paintSliderThumb): (WebCore::RenderThemeChromiumMac::paintSearchField): (WebCore::RenderThemeChromiumMac::setSearchFieldSize): (WebCore::RenderThemeChromiumMac::adjustSearchFieldStyle): (WebCore::RenderThemeChromiumMac::paintSearchFieldResultsButton): (WebCore::RenderThemeChromiumMac::adjustSliderThumbSize): (WebCore::RenderThemeChromiumMac::popupButton): (WebCore::RenderThemeChromiumMac::sliderThumbHorizontal): (WebCore::RenderThemeChromiumMac::sliderThumbVertical):
- 12:52 AM Changeset in webkit [54214] by
-
- 3 edits in trunk/WebKit/chromium
2010-02-01 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Darin Fisher.
[Chromium] Add WebSecurityOrigin::createFromString factory
https://bugs.webkit.org/show_bug.cgi?id=34460
- public/WebSecurityOrigin.h:
- src/WebSecurityOrigin.cpp: (WebKit::WebSecurityOrigin::createFromString):
- 12:35 AM Changeset in webkit [54213] by
-
- 1 edit1 add in trunk/WebCore
2010-02-02 Kwang Yul Seo <skyul@company100.net>
Reviewed by Eric Seidel.
[BREWMP] Port Logging
https://bugs.webkit.org/show_bug.cgi?id=34300
Log calls to notImplemented() by default.
- platform/brew/LoggingBrew.cpp: Added. (WebCore::InitializeLoggingChannelsIfNecessary):
- 12:25 AM Changeset in webkit [54212] by
-
- 5 edits in trunk/WebKit/chromium
2010-02-02 Kent Tamura <tkent@chromium.org>
Reviewed by Darin Fisher.
[Chromium] Should not select a word on right-click.
https://bugs.webkit.org/show_bug.cgi?id=33364
For non-Mac platforms, do not select a word around the caret when
a context menu is opening. This behavior is not common in non-Mac
platforms, and it prevents pasting with a context menu.
In order that the spell checker works without the selection, we
introduce WebFrame::selectWordAroundCaret(). We can replace a word
around the caret with selectWordAroundCaret() + replaceSelection().
- public/WebFrame.h: Add pure selectWordAroundCaret() declaration.
- src/ContextMenuClientImpl.cpp: (WebKit::selectMisspelledWord): Move word-selection code to WebFrameImpl::selectWordAroundPosition(), and clear the selection on non-Mac.
- src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::selectWordAroundPosition): (WebKit::WebFrameImpl::selectWordAroundCaret):
- src/WebFrameImpl.h: Add selectWordAroundCaret() declaration.
- 12:19 AM Changeset in webkit [54211] by
-
- 1 edit1 add in trunk/WebCore
2010-02-02 Kwang Yul Seo <skyul@company100.net>
Reviewed by Eric Seidel.
[BREWMP] Port FileChooser
https://bugs.webkit.org/show_bug.cgi?id=34261
Port FileChooser to BREWMP.
- platform/brew/FileChooserBrew.cpp: Added. (WebCore::FileChooser::basenameForWidth):
Feb 1, 2010:
- 11:56 PM Changeset in webkit [54210] by
-
- 2 edits in trunk/WebCore
2010-02-01 Zoltan Horvath <zoltan@webkit.org>
Reviewed by Darin Adler.
Allow custom memory allocation control for IconDatabaseClient class
https://bugs.webkit.org/show_bug.cgi?id=33252
Inherits the following struct from Noncopyable because it is
instantiated by 'new' and no need to be copyable:
class name - instantiated at: WebCore/'location'
class IconDatabaseClient - loader/icon/IconDatabase.cpp:89
- loader/icon/IconDatabaseClient.h:
- 11:51 PM Changeset in webkit [54209] by
-
- 1 edit1 add in trunk/LayoutTests
Check in new expected results for a test that has been failing on Windows
since it was originally landed. This appears to be a font issue, but commenting
on bug <https://bugs.webkit.org/show_bug.cgi?id=34234> to make sure.
- platform/win/fast/text/international/hebrew-vowels-expected.txt: Added.
- 11:46 PM Changeset in webkit [54208] by
-
- 1 edit1 add in trunk/WebCore
2010-02-01 Kwang Yul Seo <skyul@company100.net>
Reviewed by Eric Seidel.
[BREWMP] Port MIMETypeRegistry
https://bugs.webkit.org/show_bug.cgi?id=34220
Port MIMETypeRegistry with an extension map as other ports do.
- platform/brew: Added.
- platform/brew/MIMETypeRegistryBrew.cpp: Added. (WebCore::): (WebCore::MIMETypeRegistry::getMIMETypeForExtension):
- 10:53 PM Changeset in webkit [54207] by
-
- 6 edits7 deletes in trunk
Revert r54194 that fails new test on Qt and Chromium.
https://bugs.webkit.org/show_bug.cgi?id=34382
- 10:41 PM Changeset in webkit [54206] by
-
- 6 edits2 adds in trunk/WebKitTools
Addressed FIXME in check-webkit-style so that the carriage-return
check will work for patches.
Reviewed by Shinichiro Hamaji.
https://bugs.webkit.org/show_bug.cgi?id=34260
Also added support for limiting the number of errors reported
per category, per file.
- Scripts/webkitpy/style/checker.py:
- Added new "whitespace/carriage_return" category from common.py.
- Added MAX_REPORTS_PER_CATEGORY dictionary.
- Added max_reports_per_category attribute to ProcessorOptions class.
- Refactored StyleChecker._process_file().
- Scripts/webkitpy/style/checker_unittest.py:
- Updated ProcessorOptionsTest tests.
- Added test to check MAX_REPORTS_PER_CATEGORY.
- Scripts/webkitpy/style/error_handlers.py:
- Added support for suppressing the display of errors after reaching a per-category maximum (from max_reports_per_category).
- Scripts/webkitpy/style/error_handlers_unittest.py:
- Added test for suppressing error display.
- Scripts/webkitpy/style/processors/common.py: Added.
- Moved carriage-return check to new file.
- Scripts/webkitpy/style/processors/common_unittest.py: Added.
- Added unit tests for carriage-return check.
- Scripts/webkitpy/style/unittests.py:
- Added reference to common_unittest.py.
- 10:28 PM Changeset in webkit [54205] by
-
- 19 edits8 adds in trunk
2010-02-01 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Eric Seidel.
Provide a way to get page number with layoutTestController
https://bugs.webkit.org/show_bug.cgi?id=33840
- platform/gtk/Skipped:
- platform/mac/Skipped:
- platform/qt/Skipped:
- platform/win/Skipped:
- printing/page-break-always-expected.txt: Added.
- printing/page-break-always.html: Added.
- printing/pageNumerForElementById-expected.txt: Added.
- printing/pageNumerForElementById.html: Added.
- printing/script-tests/TEMPLATE.html: Added.
- printing/script-tests/page-break-always.js: Added. (createParagraph):
- printing/script-tests/pageNumerForElementById.js: Added. (createParagraph):
2010-02-01 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Eric Seidel.
Provide a way to get page number with layoutTestController
https://bugs.webkit.org/show_bug.cgi?id=33840
Test: printing/page-break-always.html
- WebCore.base.exp:
- WebCore.xcodeproj/project.pbxproj:
- page/PrintContext.cpp: (WebCore::PrintContext::pageRect): Added a getter function. (WebCore::PrintContext::computePageRects): Move its logic into computePageRectsWithPageSize. (WebCore::PrintContext::computePageRectsWithPageSize): Factored out from computePageRects for pageNumberForElement. (WebCore::enclosingBoxModelObject): Added for pageNumberForElement. (WebCore::PrintContext::pageNumberForElement): Added for testing.
- page/PrintContext.h:
2010-02-01 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Eric Seidel.
Provide a way to get page number with layoutTestController
https://bugs.webkit.org/show_bug.cgi?id=33840
- Misc/WebCoreStatistics.h:
- Misc/WebCoreStatistics.mm: (-[WebFrame pageNumberForElement:element:pageWidth:]):
2010-02-01 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Eric Seidel.
Provide a way to get page number with layoutTestController
https://bugs.webkit.org/show_bug.cgi?id=33840
- DumpRenderTree/LayoutTestController.cpp: (pageNumberForElementByIdCallback): (LayoutTestController::staticFunctions):
- DumpRenderTree/LayoutTestController.h:
- DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::pageNumberForElementById):
- DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::pageNumberForElementById):
- DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::pageNumberForElementById):
- 10:19 PM Changeset in webkit [54204] by
-
- 2 edits2 adds in trunk/WebCore
2010-02-01 Kwang Yul Seo <skyul@company100.net>
Reviewed by Eric Seidel.
[BREWMP] Add conversions between IntSize and AEESize
https://bugs.webkit.org/show_bug.cgi?id=34197
Make it easy to convert between IntSize and AEESize.
- platform/graphics/IntSize.h:
- platform/graphics/brew/IntSizeBrew.cpp: Added. (WebCore::IntSize::IntSize): (WebCore::IntSize::operator AEESize):
- 9:36 PM Changeset in webkit [54203] by
-
- 5 edits in trunk/WebCore
2010-02-01 Stephen White <senorblanco@chromium.org>
Reviewed by Eric Seidel.
Fix for Pattern transformations in Chromium/Skia. This required
reworking Pattern a bit to be more like the Gradient implementation.
In particular, it now holds an m_pattern reference to the
platform-specific implementation, and passes along changes to the
m_patternSpaceTransformation, in the same way that Gradient does for
m_gradientSpaceTransformation. This is necessary since Skia creates the
platform-specific pattern (SkShader) once, rather than recreating it
on each draw.
For platforms other than Skia, m_pattern is unused, they will
continue to use the static createPlatformPattern(), and the new
notification functions are stubbed out. Other platforms can switch to
the new implementation if they so choose.
Covered by svg/custom/pattern-y-offset.svg,
svg/custom/pattern-cycle-detection.svg, and many more.
- platform/graphics/Pattern.cpp: (WebCore::Pattern::Pattern): Initializer for m_pattern. (WebCore::Pattern::~Pattern): call platformDestroy(). (WebCore::Pattern::setPatternSpaceTransform): Pass along the transform via setPlatformPatternSpaceTransform(). (WebCore::Pattern::platformDestroy): (WebCore::Pattern::setPlatformPatternSpaceTransform): Stub implementations for non-skia platforms.
- platform/graphics/Pattern.h:
- platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContext::setPlatformFillPattern): (WebCore::GraphicsContext::setPlatformStrokePattern): Call platformPattern() instead of static version. Since Pattern now owns its SkShader, no need to unref here.
- platform/graphics/skia/PatternSkia.cpp: (WebCore::Pattern::platformDestroy): Unref the SkShader on destroy. (WebCore::Pattern::platformPattern): Create the platform pattern (SkShader) once, and cache it. (WebCore::Pattern::setPlatformPatternSpaceTransform): Set the shader's local matrix from the m_patternSpaceTransformation.
- 9:13 PM Changeset in webkit [54202] by
-
- 8 edits22 adds in trunk
2010-02-01 Daniel Bates <dbates@webkit.org>
Reviewed by Adam Barth.
Implements support for full page blocking via the X-XSS-Protection header.
Tests: http/tests/security/xssAuditor/full-block-base-href.html
http/tests/security/xssAuditor/full-block-get-from-iframe.html
http/tests/security/xssAuditor/full-block-iframe-javascript-url.html
http/tests/security/xssAuditor/full-block-iframe-no-inherit.php
http/tests/security/xssAuditor/full-block-javascript-link.html
http/tests/security/xssAuditor/full-block-link-onclick.html
http/tests/security/xssAuditor/full-block-object-tag.html
http/tests/security/xssAuditor/full-block-post-from-iframe.html
http/tests/security/xssAuditor/full-block-script-tag-with-source.html
http/tests/security/xssAuditor/full-block-script-tag.html
http/tests/security/xssAuditor/malformed-xss-protection-header.html
- page/XSSAuditor.cpp: (WebCore::XSSAuditor::shouldFullPageBlockForXSSProtectionHeader): Added. (WebCore::XSSAuditor::findInRequest): Modified to call method XSSAuditor::shouldFullPageBlockForXSSProtectionHeader.
- page/XSSAuditor.h: Defined method shouldFullPageBlockForXSSProtectionHeader and fixed misspelled words in large comment block.
2010-02-01 Daniel Bates <dbates@webkit.org>
Reviewed by Adam Barth.
Tests that the header "X-XSS-Protection: full-block" leads to a full page block
when an XSS attack is detected.
- http/tests/security/xssAuditor/full-block-base-href-expected.txt: Added.
- http/tests/security/xssAuditor/full-block-base-href.html: Added.
- http/tests/security/xssAuditor/full-block-get-from-iframe-expected.txt: Added.
- http/tests/security/xssAuditor/full-block-get-from-iframe.html: Added.
- http/tests/security/xssAuditor/full-block-iframe-javascript-url-expected.txt: Added.
- http/tests/security/xssAuditor/full-block-iframe-javascript-url.html: Added.
- http/tests/security/xssAuditor/full-block-iframe-no-inherit-expected.txt: Added.
- http/tests/security/xssAuditor/full-block-iframe-no-inherit.php: Added.
- http/tests/security/xssAuditor/full-block-javascript-link-expected.txt: Added.
- http/tests/security/xssAuditor/full-block-javascript-link.html: Added.
- http/tests/security/xssAuditor/full-block-link-onclick-expected.txt: Added.
- http/tests/security/xssAuditor/full-block-link-onclick.html: Added.
- http/tests/security/xssAuditor/full-block-object-tag-expected.txt: Added.
- http/tests/security/xssAuditor/full-block-object-tag.html: Added.
- http/tests/security/xssAuditor/full-block-post-from-iframe-expected.txt: Added.
- http/tests/security/xssAuditor/full-block-post-from-iframe.html: Added.
- http/tests/security/xssAuditor/full-block-script-tag-expected.txt: Added.
- http/tests/security/xssAuditor/full-block-script-tag-with-source-expected.txt: Added.
- http/tests/security/xssAuditor/full-block-script-tag-with-source.html: Added.
- http/tests/security/xssAuditor/full-block-script-tag.html: Added.
- http/tests/security/xssAuditor/malformed-xss-protection-header-expected.txt: Added.
- http/tests/security/xssAuditor/malformed-xss-protection-header.html: Added.
- http/tests/security/xssAuditor/resources/echo-head-base-href.pl: Modified to optionally enable full page blocking.
- http/tests/security/xssAuditor/resources/echo-intertag-click-and-notify.pl: Ditto.
- http/tests/security/xssAuditor/resources/echo-intertag.pl: Ditto.
- http/tests/security/xssAuditor/resources/utilities.js: (checkIfFrameLocationMatchesURLAndCallDone): Added. (sendRequestFromIFrame): Modified to optionally call callback function when done.
- 9:10 PM Changeset in webkit [54201] by
-
- 3 edits in trunk/LayoutTests
2010-02-01 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Dmitry Titov.
Convert textarea-rows-cols.html to dumpAsText()
https://bugs.webkit.org/show_bug.cgi?id=34074
Remove checks for the size of scrollbar as scrollbar doesn't
appear on Windows.
- fast/forms/script-tests/textarea-rows-cols.js:
- fast/forms/textarea-rows-cols-expected.txt:
- 9:01 PM Changeset in webkit [54200] by
-
- 1 edit2 adds in trunk/WebCore
2010-02-01 Kwang Yul Seo <skyul@company100.net>
Reviewed by Eric Seidel.
[BREWMP] Port SharedTimer with IShell_SetTimerEx.
https://bugs.webkit.org/show_bug.cgi?id=33599
As fireTime passed in setSharedTimerFireTime is the absolute time,
we must calcalute the interval by subtracting currentTime() from
fireTime and pass the result to ISHELL_SetTimerEx.
- platform/brew/SharedTimerBrew.cpp: Added. (WebCore::invokeCallback): (WebCore::setSharedTimerFiredFunction): (WebCore::setSharedTimerFireTime): (WebCore::stopSharedTimer):
- 8:56 PM Changeset in webkit [54199] by
-
- 3 edits3 adds in trunk
2010-02-01 Kent Tamura <tkent@chromium.org>
Reviewed by Darin Adler.
Date.UTC() should apply TimeClip operation.
https://bugs.webkit.org/show_bug.cgi?id=34461
ECMAScript 5 15.9.4.3:
9 Return TimeClip(MakeDate(MakeDay(yr, m, dt), MakeTime(h, min, s, milli))).
- runtime/DateConstructor.cpp: (JSC::dateUTC): Calls WTF::timeClip().
2010-02-01 Kent Tamura <tkent@chromium.org>
Reviewed by Darin Adler.
Date.UTC() should apply TimeClip operation.
https://bugs.webkit.org/show_bug.cgi?id=34461
Add tests for corner cases of Date.UTC().
- fast/js/date-utc-timeclip-expected.txt: Added.
- fast/js/date-utc-timeclip.html: Added.
- fast/js/script-tests/date-utc-timeclip.js: Added.
- 8:48 PM Changeset in webkit [54198] by
-
- 3 edits in trunk/LayoutTests
2010-02-01 Kent Tamura <tkent@chromium.org>
Unreviewed. Add two more test cases which I forgot to add in r54197.
https://bugs.webkit.org/show_bug.cgi?id=34462
- fast/js/math-expected.txt:
- fast/js/script-tests/math.js:
- 8:42 PM Changeset in webkit [54197] by
-
- 5 edits in trunk
2010-02-01 Kent Tamura <tkent@chromium.org>
Reviewed by Darin Adler.
Fix a bug that Math.round() retunrs incorrect results for huge integers
https://bugs.webkit.org/show_bug.cgi?id=34462
- runtime/MathObject.cpp: (JSC::mathProtoFuncRound): Avoid "arg + 0.5".
2010-02-01 Kent Tamura <tkent@chromium.org>
Reviewed by Darin Adler.
Fix a bug that Math.round() retunrs incorrect results for huge integers
https://bugs.webkit.org/show_bug.cgi?id=34462
- fast/js/math-expected.txt:
- fast/js/script-tests/math.js: Add test cases for Math.round() for huge numbers.
- 8:13 PM Changeset in webkit [54196] by
-
- 4 edits in trunk/WebCore
2010-02-01 Shinichiro Hamaji <hamaji@chromium.org>
[Chromium] Unreviewed attempt to fix the chromium build.
Corresponding change: http://trac.webkit.org/changeset/54182
- bindings/scripts/CodeGeneratorV8.pm:
- bindings/v8/ScriptController.cpp: (WebCore::ScriptController::processingUserGesture):
- bindings/v8/ScriptController.h:
- 7:19 PM Changeset in webkit [54195] by
-
- 2 edits in trunk/WebKit/chromium
2010-02-01 Shinichiro Hamaji <hamaji@chromium.org>
Unreviewed attempt to fix the broken build.
This was introduced in http://trac.webkit.org/changeset/54182
- src/WebViewImpl.cpp: (WebKit::WebViewImpl::performMediaPlayerAction):
- 7:14 PM Changeset in webkit [54194] by
-
- 6 edits8 adds in trunk
When a live iframe element is moved between pages, it still depends on the old page.
https://bugs.webkit.org/show_bug.cgi?id=34382
Reviewed by David Levin.
WebCore:
Test: fast/frames/iframe-reparenting-new-page.html
- html/HTMLFrameElementBase.cpp:
(WebCore::HTMLFrameElementBase::setName):
Move the code setting the frame name into a separate function.
(WebCore::HTMLFrameElementBase::setNameAndOpenURL):
(WebCore::HTMLFrameElementBase::updateLiveFrame):
Update frame tree, reset page in the contentFrame and re-set the name.
(WebCore::HTMLFrameElementBase::insertedIntoDocument):
- html/HTMLFrameElementBase.h:
- page/Frame.cpp:
(WebCore::Frame::setPage):
- page/Frame.h: Add setPage method. It is only currently used when iframe is
moved between pages (so the ASSERT(m_ownerElement).
LayoutTests:
- fast/frames/iframe-reparenting-new-page-expected.txt: Added.
- fast/frames/iframe-reparenting-new-page.html: Added.
- fast/frames/resources/iframe-reparenting-new-page-1.html: Added.
- fast/frames/resources/iframe-reparenting-new-page-2.html: Added.
- fast/frames/resources/iframe-reparenting-new-page-iframe.html: Added.
- 7:06 PM Changeset in webkit [54193] by
-
- 6 edits in trunk
WebCore: Add common IRC ports to port blocking.
<rdar://problem/7593895> and https://bugs.webkit.org/show_bug.cgi?id=34451
Reviewed by Tim Hatcher.
- platform/KURL.cpp:
(WebCore::portAllowed):
LayoutTests: Add common IRC ports to port blocking.
<rdar://problem/7593895> and https://bugs.webkit.org/show_bug.cgi?id=34451
- platform/mac-tiger/security/block-test-expected.txt:
- platform/mac/security/block-test-expected.txt:
- security/block-test.html:
Reviewed by Tim Hatcher.
- 6:45 PM Changeset in webkit [54192] by
-
- 2 edits in trunk/WebKitTools
2010-02-01 Shinichiro Hamaji <hamaji@chromium.org>
Unreviewed fix for an invalid function call.
check-webkit-style: Remove filename parameter from all functions where no longer used
https://bugs.webkit.org/show_bug.cgi?id=34249
- Scripts/webkitpy/style/checker.py:
- 6:43 PM Changeset in webkit [54191] by
-
- 2 edits in trunk/WebKit/chromium
2010-01-27 Matt Perry <mpcomplete@chromium.org>
Reviewed by Eric Seidel.
Add support for addUserScript to chromium port.
- public/WebView.h:
- src/WebViewImpl.cpp: (WebKit::WebViewImpl::addUserScript): (WebKit::WebViewImpl::removeAllUserContent):
- src/WebViewImpl.h:
- 6:42 PM Changeset in webkit [54190] by
-
- 3 edits in trunk/WebCore
2010-01-29 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Nate Chapin.
[V8] Add compile time guards for IndexedDB custom functions
https://bugs.webkit.org/show_bug.cgi?id=34368
- bindings/v8/custom/V8IDBRequestCustom.cpp:
- bindings/v8/custom/V8IndexedDatabaseRequestCustom.cpp:
- 6:07 PM QtWebKitGraphics edited by
- (diff)
- 6:04 PM CssAnimationTestSuite edited by
- (diff)
- 6:01 PM CssAnimationTestSuite created by
- 5:48 PM Changeset in webkit [54189] by
-
- 2 edits in branches/safari-4-branch/LayoutTests
Merge r53116.
- 5:48 PM Changeset in webkit [54188] by
-
- 3 edits in branches/safari-4-branch/LayoutTests
Merge r53115.
- 5:48 PM Changeset in webkit [54187] by
-
- 7 edits in branches/safari-4-branch
Merge r53114.
- 5:48 PM Changeset in webkit [54186] by
-
- 1 edit2 adds in branches/safari-4-branch/LayoutTests
Merge r53096.
- 5:47 PM Changeset in webkit [54185] by
-
- 1 edit1 add in branches/safari-4-branch/LayoutTests
Merge r53093.
- 5:47 PM Changeset in webkit [54184] by
-
- 3 edits4 adds in branches/safari-4-branch
Merge r53078.
- 5:33 PM Changeset in webkit [54183] by
-
- 2 edits in trunk/JavaScriptCore
2010-02-01 Kwang Yul Seo <skyul@company100.net>
Reviewed by Eric Seidel.
[BREWMP] Port WTF's currentTime
https://bugs.webkit.org/show_bug.cgi?id=33567
Combine GETUTCSECONDS and GETTIMEMS to calculate the number
of milliseconds since 1970/01/01 00:00:00 UTC.
- wtf/CurrentTime.cpp: (WTF::currentTime):
- 5:20 PM Changeset in webkit [54182] by
-
- 25 edits3 adds in trunk
Bug 34346 - With JSC bindings, make processingUserGesture work with events in Isolated Worlds
WebCore:
Reviewed by Sam Weinig + Oliver Hunt.
Change HTMLMediaElement methods that require checking whether the event is a user gesture to
be passed a boolean. This may be passed from the JSC bindings (where we have an exec state),
or read from the event. Add a Flag to the IDL to mark this information is required.
- WebCore.Video.exp:
- bindings/js/JSDOMBinding.cpp:
(WebCore::processingUserGesture):
- bindings/js/JSDOMWindowCustom.cpp:
(WebCore::domWindowAllowPopUp):
(WebCore::JSDOMWindow::open):
(WebCore::JSDOMWindow::showModalDialog):
- bindings/js/JSDocumentCustom.cpp:
(WebCore::JSDocument::setLocation):
- bindings/js/ScriptController.cpp:
(WebCore::ScriptController::processingUserGesture):
(WebCore::ScriptController::processingUserGestureEvent):
(WebCore::ScriptController::anyPageIsProcessingUserGesture):
- bindings/js/ScriptController.h:
- bindings/scripts/CodeGeneratorJS.pm:
- dom/Event.cpp:
(WebCore::Event::isUserEvent):
- dom/Event.h:
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::removedFromDocument):
(WebCore::HTMLMediaElement::load):
(WebCore::HTMLMediaElement::play):
(WebCore::HTMLMediaElement::pause):
(WebCore::HTMLMediaElement::beginScrubbing):
(WebCore::HTMLMediaElement::documentDidBecomeActive):
(WebCore::HTMLMediaElement::webkitEnterFullScreen):
- html/HTMLMediaElement.h:
- html/HTMLMediaElement.idl:
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::isProcessingUserGesture):
- loader/MediaDocument.cpp:
(WebCore::MediaDocument::defaultEventHandler):
- page/DOMWindow.cpp:
(WebCore::DOMWindow::allowPopUp):
- rendering/MediaControlElements.cpp:
(WebCore::MediaControlSeekButtonElement::defaultEventHandler):
WebKit/mac:
Reviewed by Sam Weinig + Oliver Hunt.
Pass processeing user gensture flag to media play/pause methods.
- WebView/WebVideoFullscreenHUDWindowController.mm:
(-[WebVideoFullscreenHUDWindowController setPlaying:]):
WebKit/win:
Reviewed by Sam Weinig + Oliver Hunt.
Pass processeing user gensture flag to media play/pause methods.
- FullscreenVideoController.cpp:
(FullscreenVideoController::play):
(FullscreenVideoController::pause):
LayoutTests:
Reviewed by Sam Weinig.
- http/tests/security/isolatedWorld/resources/userGestureEvents-second-window.html: Added.
- http/tests/security/isolatedWorld/userGestureEvents-expected.txt: Added.
- http/tests/security/isolatedWorld/userGestureEvents.html: Added.
- 5:17 PM Changeset in webkit [54181] by
-
- 5 edits3 adds in branches/safari-4-branch
- 5:16 PM Changeset in webkit [54180] by
-
- 3 edits in trunk/WebCore
2010-02-01 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Use the fallback style on Maemo 5
- platform/qt/RenderThemeQt.cpp: (WebCore::RenderThemeQt::RenderThemeQt): (WebCore::RenderThemeQt::fallbackStyle): (WebCore::RenderThemeQt::qStyle): (WebCore::RenderThemeQt::setPaletteFromPageClientIfExists):
- platform/qt/RenderThemeQt.h:
- 5:00 PM Changeset in webkit [54179] by
-
- 2 edits in trunk/WebCore
2010-02-01 Kavita Kanetkar <kkanetkar@chromium.org>
Reviewed by Nate Chapin.
[V8] Making V8 generated classes' GetTemplate() function public
https://bugs.webkit.org/show_bug.cgi?id=34026
- bindings/scripts/CodeGeneratorV8.pm: Generated code need not depend on V8CustomBinding.h, made GetTemplate() signature public.
- 4:56 PM Changeset in webkit [54178] by
-
- 2 edits in trunk/WebKit/mac
<rdar://problem/7044385> Crash at NetscapePlugInStreamLoader::didReceiveResponse()
Reviewed by Anders Carlsson.
The crash was caused by having two streams with a streamID of 1.
- Plugins/Hosted/NetscapePluginInstanceProxy.mm:
(WebKit::NetscapePluginInstanceProxy::NetscapePluginInstanceProxy): Fixed a typo. Now
correctly increments m_currentURLRequestID to account for the manual stream.
(WebKit::NetscapePluginInstanceProxy::disconnectStream): If the stream is the manual stream,
null it out instead of trying to remove it from the map. Added an assertion.
(WebKit::NetscapePluginInstanceProxy::loadRequest): Added an assertion.
- 4:42 PM Changeset in webkit [54177] by
-
- 3 edits2 adds in branches/safari-4-branch
Merge r51704.
- 4:39 PM Changeset in webkit [54176] by
-
- 2 edits in trunk/JavaScriptCore
2010-02-01 Patrick Gansterer <paroga@paroga.com>
Reviewed by Darin Adler.
[Qt] WinCE buildfix after r52729 and fix for Q_BIG_ENDIAN typo.
https://bugs.webkit.org/show_bug.cgi?id=34378
- wtf/Platform.h:
- 4:35 PM Changeset in webkit [54175] by
-
- 3 edits2 adds in trunk/WebCore
Adds V8-specific JNI bridge classes
https://bugs.webkit.org/show_bug.cgi?id=34166
Reviewed by Ariya Hidayat.
This is the V8 equivalent of bridge/jni/jsc/JNIBridgeJSC.
No new tests, build fix only.
- Android.v8bindings.mk: Modified. Added JNIBridge.cpp and JNIBridgeV8.cpp
- bridge/Bridge.h: Modified. Added missing include for Noncopyable.h
- bridge/jni/v8/JNIBridgeV8.cpp: Added.
(JavaField::JavaField):
- bridge/jni/v8/JNIBridgeV8.h: Added.
(JSC::Bindings::JavaField::name):
(JSC::Bindings::JavaField::type):
(JSC::Bindings::JavaField::getJNIType):
- 4:34 PM Changeset in webkit [54174] by
-
- 5 edits3 adds in branches/safari-4-branch
Merge r51962.
- 4:34 PM Changeset in webkit [54173] by
-
- 6 edits4 adds in branches/safari-4-branch
Merge r50110.
- 4:34 PM Changeset in webkit [54172] by
-
- 5 edits in branches/safari-4-branch/WebCore
Merge r50017.
- 4:25 PM Changeset in webkit [54171] by
-
- 2 edits2 adds in trunk/WebCore
Adds V8-specific JNI utility functions.
https://bugs.webkit.org/show_bug.cgi?id=33901
Reviewed by Ariya Hidayat.
This is the V8 equivalent of bridge/jni/jsc/JNIUtilityPrivate.
No new tests, build fix only.
- Android.v8bindings.mk: Modified. Add JNIUtilityPrivate.cpp
- bridge/jni/v8/JNIUtilityPrivate.cpp: Added.
(JSC::Bindings::convertNPVariantToJValue):
(JSC::Bindings::convertJValueToNPVariant):
- bridge/jni/v8/JNIUtilityPrivate.h: Added.
- 4:23 PM Changeset in webkit [54170] by
-
- 12 edits12 adds in branches/safari-4-branch
Merge r52784.
- 4:15 PM Changeset in webkit [54169] by
-
- 2 edits2 adds in trunk/WebCore
Adds V8 version of JavaClass
https://bugs.webkit.org/show_bug.cgi?id=33898
Reviewed by Ariya Hidayat.
This is the V8 equivalent of bridge/jni/jsc/JavaClassJSC
No new tests, build fix only.
- Android.v8bindings.mk: Modified. Added JavaClassV8.cpp
- bridge/jni/v8/JavaClassV8.cpp: Added.
(JavaClass::JavaClass):
(JavaClass::~JavaClass):
(JavaClass::methodsNamed):
(JavaClass::fieldNamed):
- bridge/jni/v8/JavaClassV8.h: Added.
- 4:09 PM Changeset in webkit [54168] by
-
- 12 edits2 adds in branches/safari-4-branch
Merge r51645.
- 4:09 PM Changeset in webkit [54167] by
-
- 6 edits2 adds in branches/safari-4-branch
Merge r50310.
- 4:08 PM Changeset in webkit [54166] by
-
- 2 edits in trunk/LayoutTests
2010-02-01 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Darin Adler.
REGRESSION: editing/selection/doubleclick-beside-cr-span.html times out on Windows
https://bugs.webkit.org/show_bug.cgi?id=34069
Make the sleep time shorter as this test timed out on Windows bot.
- editing/selection/doubleclick-beside-cr-span.html:
- 4:03 PM Changeset in webkit [54165] by
-
- 3 edits2 adds in trunk/WebCore
Adds V8 version of JavaInstance
https://bugs.webkit.org/show_bug.cgi?id=33951
Reviewed by Ariya Hidayat.
This is the V8 equivalent of bridge/jni/jsc/JavaInstanceJSC.
Also fixes a typo in a comment in JavaInstanceJSC.cpp.
No new tests, build fix only.
- Android.v8bindings.mk: Modified. Added JavaInstanceV8.cpp
- bridge/jni/jsc/JavaInstanceJSC.cpp: Modified.
(JavaInstance::invokeMethod): Modified. Fixed comment
- bridge/jni/v8/JavaInstanceV8.cpp: Added.
(JavaInstance::JavaInstance):
(JavaInstance::~JavaInstance):
(JavaInstance::getClass):
(JavaInstance::invokeMethod):
(JObjectWrapper::JObjectWrapper):
(JObjectWrapper::~JObjectWrapper):
- bridge/jni/v8/JavaInstanceV8.h: Added.
(JSC::Bindings::JObjectWrapper::instance):
(JSC::Bindings::JObjectWrapper::setInstance):
(JSC::Bindings::JObjectWrapper::ref):
(JSC::Bindings::JObjectWrapper::deref):
(JSC::Bindings::JavaInstance::javaInstance):
(JSC::Bindings::JavaInstance::begin):
(JSC::Bindings::JavaInstance::end):
(JSC::Bindings::JavaInstance::virtualBegin):
(JSC::Bindings::JavaInstance::virtualEnd):
- 3:43 PM Changeset in webkit [54164] by
-
- 2 edits in branches/safari-4-branch/WebCore
Merge r47726.
- 3:38 PM Changeset in webkit [54163] by
-
- 2 edits in branches/safari-4-branch/WebCore
Merge r51659.
- 3:32 PM Changeset in webkit [54162] by
-
- 5 edits in trunk/WebCore
Making sure that all in-progress transactions are rolled back on
the database thread before they're destroyed. Otherwise,
SQLiteTransaction's destructor will try to do a rollback and that
would cause an assertion failure, if the object is not destroyed
on the DB thread.
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=34152
- platform/sql/SQLiteTransaction.cpp:
(WebCore::SQLiteTransaction::stop):
- storage/SQLTransaction.cpp:
(WebCore::SQLTransaction::notifyDatabaseThreadIsShuttingDown):
- storage/SQLTransaction.h:
- storage/SQLTransactionCoordinator.cpp:
(WebCore::SQLTransactionCoordinator::shutdown):
- 3:32 PM Changeset in webkit [54161] by
-
- 2 edits in branches/safari-4-branch/WebCore
Merge r53813.
- 3:32 PM Changeset in webkit [54160] by
-
- 4 edits4 adds in branches/safari-4-branch
Merge r53812.
- 3:26 PM Changeset in webkit [54159] by
-
- 4 edits2 adds in branches/safari-4-branch
Merge r50466.
- 3:25 PM Changeset in webkit [54158] by
-
- 10 edits4 adds in branches/safari-4-branch
Merge r50470.
- 3:25 PM Changeset in webkit [54157] by
-
- 3 edits in branches/safari-4-branch/WebCore
Merge r50435.
- 3:23 PM Changeset in webkit [54156] by
-
- 3 edits in trunk/WebCore
Fix EXPERIMENTAL_SINGLE_VIEW_MODE build.
Reviewed by Beth Dakin.
- page/EventHandler.h:
- page/mac/EventHandlerMac.mm:
(WebCore::EventHandler::currentNSEvent):
(WebCore::EventHandler::currentKeyboardEvent):
(WebCore::EventHandler::mouseDown):
(WebCore::EventHandler::mouseDragged):
(WebCore::EventHandler::mouseUp):
(WebCore::EventHandler::mouseMoved):
(WebCore::EventHandler::keyEvent):
(WebCore::EventHandler::wheelEvent):
(WebCore::EventHandler::sendContextMenuEvent):
(WebCore::EventHandler::eventMayStartDrag):
(WebCore::EventHandler::sendFakeEventsAfterWidgetTracking):
- 3:19 PM Changeset in webkit [54155] by
-
- 5 edits in trunk
2010-02-01 Diego Gonzalez <diego.gonzalez@openbossa.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] DRT Provide global flag ability
https://bugs.webkit.org/show_bug.cgi?id=34418
Add the globalFlag property to the Qt LayoutTestController to allow
cross-domain indications.
- platform/qt/Skipped:
2010-02-01 Diego Gonzalez <diego.gonzalez@openbossa.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] DRT Provide global flag ability
https://bugs.webkit.org/show_bug.cgi?id=34418
Add the globalFlag property to the Qt LayoutTestController to allow
cross-domain indications.
- DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::reset):
- DumpRenderTree/qt/LayoutTestControllerQt.h: (LayoutTestController::globalFlag): (LayoutTestController::setGlobalFlag):
- 3:11 PM Changeset in webkit [54154] by
-
- 3 edits2 adds in branches/safari-4-branch
Merge r50083.
- 2:39 PM Changeset in webkit [54153] by
-
- 1 edit13 adds in trunk/WebCore
2010-02-01 Nate Chapin <Nate Chapin>
Unreviewed, Chromium build fix.
Failed to properly add new files for http://trac.webkit.org/changeset/54150.
- bindings/v8/custom/V8BarInfoCustom.cpp: Added.
- bindings/v8/custom/V8CSSRuleCustom.cpp: Added.
- bindings/v8/custom/V8CSSStyleSheetCustom.cpp: Added.
- bindings/v8/custom/V8CSSValueCustom.cpp: Added.
- bindings/v8/custom/V8CanvasPixelArrayCustom.cpp: Added.
- bindings/v8/custom/V8DOMSelectionCustom.cpp: Added.
- bindings/v8/custom/V8HTMLElementCustom.cpp: Added.
- bindings/v8/custom/V8SVGDocumentCustom.cpp: Added.
- bindings/v8/custom/V8SVGElementCustom.cpp: Added.
- bindings/v8/custom/V8SVGPathSegCustom.cpp: Added.
- bindings/v8/custom/V8ScreenCustom.cpp: Added.
- bindings/v8/custom/V8StyleSheetCustom.cpp: Added.
- bindings/v8/custom/V8WebGLArrayCustom.cpp: Added.
- 2:29 PM Changeset in webkit [54152] by
-
- 7 edits in trunk
Add support for addUserScript to chromium port.
- 2:20 PM Changeset in webkit [54151] by
-
- 3 edits in trunk/WebCore
2010-02-01 Eric Carlson <eric.carlson@apple.com>
Reviewed by Dan Bernstein.
https://bugs.webkit.org/show_bug.cgi?id=34448
<rdar://problem/7598130>
RenderVideo::intrinsicSizeChanged infinite recursion
- rendering/RenderImage.h: (WebCore::RenderImage::intrinsicSizeChanged): Make protected instead of private so it can
be called by RenderVideo.
- rendering/RenderVideo.cpp: (WebCore::RenderVideo::intrinsicSizeChanged): Call RenderMedia::intrinsicSizeChanged, not
RenderVideo::intrinsicSizeChanged.
(WebCore::RenderVideo::imageChanged): Call RenderMedia::imageChanged instead of
RenderImage::imageChanged.
- 2:12 PM Changeset in webkit [54150] by
-
- 33 edits in trunk/WebCore
2010-02-01 Nate Chapin <Nate Chapin>
Reviewed by Dimitri Glazkov.
[V8] Generate toV8() converter for most WebCore->V8 conversions,
and defined custom converters in their respective V8<class>Custom.cpp.
Old converters in V8DOMWrapper will be deleted in a later patch.
- Android.v8bindings.mk:
- WebCore.gyp/WebCore.gyp:
- WebCore.gypi:
- bindings/scripts/CodeGeneratorV8.pm:
- bindings/v8/V8Collection.h:
- bindings/v8/V8DOMWrapper.cpp:
- bindings/v8/V8DOMWrapper.h:
- bindings/v8/V8Proxy.h:
- bindings/v8/custom/V8BarInfoCustom.cpp: Added.
- bindings/v8/custom/V8CSSRuleCustom.cpp: Added.
- bindings/v8/custom/V8CSSStyleSheetCustom.cpp: Added.
- bindings/v8/custom/V8CSSValueCustom.cpp: Added.
- bindings/v8/custom/V8CanvasPixelArrayCustom.cpp: Added.
- bindings/v8/custom/V8CanvasRenderingContext2DCustom.cpp:
- bindings/v8/custom/V8ConsoleCustom.cpp:
- bindings/v8/custom/V8DOMSelectionCustom.cpp: Added.
- bindings/v8/custom/V8DOMWindowCustom.cpp:
- bindings/v8/custom/V8DocumentCustom.cpp:
- bindings/v8/custom/V8ElementCustom.cpp:
- bindings/v8/custom/V8EventCustom.cpp:
- bindings/v8/custom/V8HTMLDocumentCustom.cpp:
- bindings/v8/custom/V8HTMLElementCustom.cpp: Added.
- bindings/v8/custom/V8HTMLSelectElementCustom.cpp:
- bindings/v8/custom/V8HistoryCustom.cpp:
- bindings/v8/custom/V8LocationCustom.cpp:
- bindings/v8/custom/V8NamedNodeMapCustom.cpp:
- bindings/v8/custom/V8NavigatorCustom.cpp:
- bindings/v8/custom/V8NodeCustom.cpp:
- bindings/v8/custom/V8SVGDocumentCustom.cpp: Added.
- bindings/v8/custom/V8SVGElementCustom.cpp: Added.
- bindings/v8/custom/V8SVGPathSegCustom.cpp: Added.
- bindings/v8/custom/V8ScreenCustom.cpp: Added.
- bindings/v8/custom/V8StyleSheetCustom.cpp: Added.
- bindings/v8/custom/V8TreeWalkerCustom.cpp:
- bindings/v8/custom/V8WebGLArrayCustom.cpp: Added.
- bindings/v8/custom/V8WebGLByteArrayCustom.cpp:
- bindings/v8/custom/V8WebGLFloatArrayCustom.cpp:
- bindings/v8/custom/V8WebGLIntArrayCustom.cpp:
- bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:
- bindings/v8/custom/V8WebGLShortArrayCustom.cpp:
- bindings/v8/custom/V8WebGLUnsignedByteArrayCustom.cpp:
- bindings/v8/custom/V8WebGLUnsignedIntArrayCustom.cpp:
- bindings/v8/custom/V8WebGLUnsignedShortArrayCustom.cpp:
- dom/make_names.pl: Add options to generate wrapper factory for V8 bindings.
- 2:06 PM Changeset in webkit [54149] by
-
- 1 edit1 add in trunk/LayoutTests
Rubber-stamped by Oliver Hunt.
Check in (failing) expected results for fast/dom/Window/window-postmessage-clone-frames.
This fails because of <rdar://problem/5230396> eventSender.beginDragWithFiles is unimplemented.
- platform/win/fast/dom/Window/window-postmessage-clone-frames-expected.txt: Added.
- 2:03 PM WebKit Team edited by
- minor fix for quotations (diff)
- 2:02 PM Changeset in webkit [54148] by
-
- 3 edits in trunk/WebCore
2010-02-01 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: lazy-load textual resources to avoid UI hangup
https://bugs.webkit.org/show_bug.cgi?id=34332
- inspector/front-end/ResourceView.js: (WebInspector.ResourceView.prototype._innerSelectContentTab):
- inspector/front-end/SourceView.js: (WebInspector.SourceView.prototype.show): (WebInspector.SourceView.prototype.contentTabSelected):
- 1:53 PM Changeset in webkit [54147] by
-
- 2 edits in trunk/LayoutTests
2010-02-01 Eric Carlson <eric.carlson@apple.com>
No review, build fix.
https://bugs.webkit.org/show_bug.cgi?id=34447
http/tests/media/video-referer.html fails on Windows
- platform/win/Skipped:
- 1:35 PM Changeset in webkit [54146] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed trivial fix.
Platform dependent expected file updated after r54143.
- platform/qt/fast/dom/Window/window-properties-expected.txt:
- 1:21 PM Changeset in webkit [54145] by
-
- 11 edits2 adds in trunk
Crash in Safari opening new tabs to "same page"
<rdar://problem/7593857> and https://bugs.webkit.org/show_bug.cgi?id=34444
Reviewed by Adele Peterson.
WebCore:
Test: fast/loader/crash-copying-backforwardlist.html
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::loadItem): Null check currentItem().
- page/Page.cpp:
(WebCore::Page::goToItem): Ditto.
WebKitTools:
Add a mode (Mac-only for now) that exercises the WebView SPI _loadBackForwardListFromOtherView:
- DumpRenderTree/LayoutTestController.cpp:
(LayoutTestController::LayoutTestController):
(setNewWindowsCopyBackForwardListCallback):
(LayoutTestController::staticFunctions):
- DumpRenderTree/LayoutTestController.h:
(LayoutTestController::newWindowsCopyBackForwardList):
(LayoutTestController::setNewWindowsCopyBackForwardList):
- DumpRenderTree/mac/UIDelegate.mm:
(-[UIDelegate webView:createWebViewWithRequest:]):
LayoutTests:
- fast/loader/crash-copying-backforwardlist-expected.txt: Added.
- fast/loader/crash-copying-backforwardlist.html: Added.
- platform/gtk/Skipped:
- platform/qt/Skipped:
- platform/win/Skipped:
- 1:09 PM Changeset in webkit [54144] by
-
- 2 edits in trunk/WebCore
Reviewed by Kevin Ollivier.
[wx] Remove unused file that doesn't seem to belong to the port.
https://bugs.webkit.org/show_bug.cgi?id=34445
- 12:48 PM Changeset in webkit [54143] by
-
- 12 edits in trunk
2010-02-01 Eric Carlson <eric.carlson@apple.com>
Reviewed by Adele Peterson.
Fullscreen API should be on HTMLVideoElement
https://bugs.webkit.org/show_bug.cgi?id=34438
Move fullscreen DOM APIs from HTMLMediaElement to HTMLVideoElement.
- html/HTMLMediaElement.cpp:
- html/HTMLMediaElement.h:
- html/HTMLMediaElement.idl:
- html/HTMLVideoElement.cpp: (WebCore::HTMLVideoElement::paint): Removed outdated FIXME. (WebCore::HTMLVideoElement::paintCurrentFrameInContext): Ditto. (WebCore::HTMLVideoElement::webkitEnterFullScreen): Moved from HTMLMediaElement. (WebCore::HTMLVideoElement::webkitExitFullScreen): Ditto. (WebCore::HTMLVideoElement::webkitSupportsFullscreen): Ditto. (WebCore::HTMLVideoElement::webkitDisplayingFullscreen): Ditto.
- html/HTMLVideoElement.h:
- html/HTMLVideoElement.idl:
2010-02-01 Eric Carlson <eric.carlson@apple.com>
Reviewed by Adele Peterson.
Fullscreen API should be on HTMLVideoElement
https://bugs.webkit.org/show_bug.cgi?id=34438
Update fullscreen tests now that <audio> doesn't have fullscreen API.
- fast/dom/Window/window-properties-expected.txt:
- media/media-fullscreen-inline-expected.txt:
- media/media-fullscreen-not-in-document-expected.txt:
- media/media-fullscreen.js: (buttonClickHandler): (canplaythrough):
- 12:05 PM Changeset in webkit [54142] by
-
- 2 edits in trunk/WebKitTools
2010-02-01 Carol Szabo <carol.szabo@nokia.com>
Unreviewed.
Add myself to list of committers.
- Scripts/webkitpy/committers.py:
- 12:04 PM Changeset in webkit [54141] by
-
- 2 edits in trunk/JavaScriptCore
2010-02-01 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
Structure not accounting for anonymous slots when computing property storage size
https://bugs.webkit.org/show_bug.cgi?id=34441
Previously any Structure with anonymous storage would have a property map, so we
were only including anonymous slot size if there was a property map. Given this
is no longer the case we should always include the anonymous slot count in the
property storage size.
- runtime/Structure.h: (JSC::Structure::propertyStorageSize):
- 10:59 AM Changeset in webkit [54140] by
-
- 2 edits in trunk/WebKitTools
2010-02-01 Nate Chapin <Nate Chapin>
Rubber-stamped by David Levin.
Add myself to reviewer list.
- Scripts/webkitpy/committers.py:
- 10:44 AM Changeset in webkit [54139] by
-
- 7 edits in trunk/WebCore
2010-02-01 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: Syntax highlighting in source view of
Resources pane stops half-way.
There were two problems here: (1) styles for html highlighter were not
added into the css file (they used to be injected manually in the
SourceFrame before). (2) 'Tag' needed to be lexer's state, not parser's.
Otherwise unbalanced quotes in the text nodes were matching too match
into the string tokens.
- inspector/front-end/NativeTextViewer.js: (WebInspector.NativeTextViewer.prototype._createLineDivs): (WebInspector.NativeTextViewer.prototype._lineHeight): (WebInspector.NativeTextViewer.prototype.initFontMetrics):
- inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype._createEditorIfNeeded):
- inspector/front-end/SourceHTMLTokenizer.js: (WebInspector.SourceHTMLTokenizer): (WebInspector.SourceHTMLTokenizer.prototype.nextToken):
- inspector/front-end/SourceHTMLTokenizer.re2js:
- inspector/front-end/TextEditor.js: (WebInspector.TextEditor.prototype.initFontMetrics): (WebInspector.TextEditor.prototype._registerShortcuts):
- inspector/front-end/inspectorSyntaxHighlight.css:
- 10:40 AM WebKit Team edited by
- (diff)
- 10:35 AM Changeset in webkit [54138] by
-
- 6 edits3 deletes in trunk
ScriptCallFrame's do not get line numbers/source id's if the caller is unkown.
https://bugs.webkit.org/show_bug.cgi?id=34335
Reviewed by Darin Adler.
WebCore:
- bindings/js/ScriptCallStack.cpp:
(WebCore::ScriptCallStack::ScriptCallStack): If the caller is unknown, the line number and source information is still availble so pass it to the ScriptCallFrame being constructed.
LayoutTests:
Update layout tests that did not have source and line number information for their console messages, as this information is now available to the ScriptCallFrame and thus can be passed to the inspector, for example.
- fast/js/console-non-string-values-expected.txt: Add console line number/source.
- userscripts/script-not-run-for-fragments-expected.txt: ditto.
- userscripts/script-run-at-start-expected.txt: ditto.
- platform/gtk/inspector/console-log-before-inspector-open-expected.txt: Removed as platform workarounds no longer necessary.
- platform/mac/inspector/console-log-before-inspector-open-expected.txt: ditto.
- platform/win/inspector/console-log-before-inspector-open-expected.txt: ditto.
- 10:07 AM Changeset in webkit [54137] by
-
- 32 edits2 adds in trunk/WebCore
2010-02-01 Dirk Schulze <krit@webkit.org>
Reviewed by Simon Fraser.
Add back an AffineTransform class for use by SVG
https://bugs.webkit.org/show_bug.cgi?id=33750
These are the first steps on reimplementing AffineTransform. Unlike
the old affine code, this one is platform independent like TransformationMatrix.
AffineTransform has the benefit, that it stores just 6 doubles instead of
16 in TransformationMatrix. The calculations of transformations are not that
complex and can improve the memory usage and speed of SVG.
AffineTransform can be used by HTML Canvas3D or SVG, since they are 2D related (at
least for the moment).
HTML Canvas is the first that makes use of the new AffineTransform. Next patches
will introduce the affine code to SVG.
No new tests. The new AffineTransformation code is tested by fast/canvas.
- Android.mk:
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::scale): (WebCore::CanvasRenderingContext2D::rotate): (WebCore::CanvasRenderingContext2D::translate): (WebCore::CanvasRenderingContext2D::transform): (WebCore::CanvasRenderingContext2D::setTransform): (WebCore::CanvasRenderingContext2D::isPointInPath): (WebCore::CanvasRenderingContext2D::willDraw):
- html/canvas/CanvasRenderingContext2D.h:
- platform/graphics/GraphicsContext.h:
- platform/graphics/Path.h:
- platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::getAffineCTM): (WebCore::GraphicsContext::concatCTM):
- platform/graphics/cairo/GraphicsContextPlatformPrivateCairo.h: (WebCore::GraphicsContextPlatformPrivate::concatCTM):
- platform/graphics/cairo/PathCairo.cpp: (WebCore::Path::transform):
- platform/graphics/cairo/TransformationMatrixCairo.cpp: (WebCore::AffineTransform::operator cairo_matrix_t):
- platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::concatCTM): (WebCore::GraphicsContext::getAffineCTM):
- platform/graphics/cg/GraphicsContextPlatformPrivateCG.h: (WebCore::GraphicsContextPlatformPrivate::concatCTM):
- platform/graphics/cg/PathCG.cpp: (WebCore::Path::transform):
- platform/graphics/cg/TransformationMatrixCG.cpp: (WebCore::AffineTransform::operator CGAffineTransform):
- platform/graphics/haiku/GraphicsContextHaiku.cpp: (WebCore::GraphicsContext::getAffineCTM): (WebCore::GraphicsContext::concatCTM):
- platform/graphics/haiku/PathHaiku.cpp: (WebCore::Path::transform):
- platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::getAffineCTM): (WebCore::GraphicsContext::concatCTM):
- platform/graphics/qt/PathQt.cpp: (WebCore::Path::transform):
- platform/graphics/qt/TransformationMatrixQt.cpp: (WebCore::AffineTransform::operator QTransform):
- platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContext::concatCTM): (WebCore::GraphicsContext::getAffineCTM):
- platform/graphics/skia/PathSkia.cpp: (WebCore::Path::transform):
- platform/graphics/skia/TransformationMatrixSkia.cpp: (WebCore::AffineTransform::operator SkMatrix):
- platform/graphics/transforms/AffineTransform.cpp: Added. (WebCore::affineTransformDecompose): (WebCore::affineTransformCompose): (WebCore::AffineTransform::AffineTransform): (WebCore::AffineTransform::reset): (WebCore::AffineTransform::setMatrix): (WebCore::AffineTransform::isIdentity): (WebCore::AffineTransform::det): (WebCore::AffineTransform::isInvertible): (WebCore::AffineTransform::inverse): (WebCore::AffineTransform::multiply): (WebCore::AffineTransform::multLeft): (WebCore::AffineTransform::rotate): (WebCore::AffineTransform::scale): (WebCore::AffineTransform::translate): (WebCore::AffineTransform::scaleNonUniform): (WebCore::AffineTransform::rotateFromVector): (WebCore::AffineTransform::flipX): (WebCore::AffineTransform::flipY): (WebCore::AffineTransform::shear): (WebCore::AffineTransform::skew): (WebCore::AffineTransform::skewX): (WebCore::AffineTransform::skewY): (WebCore::makeMapBetweenRects): (WebCore::AffineTransform::map): (WebCore::AffineTransform::mapPoint): (WebCore::AffineTransform::mapRect): (WebCore::AffineTransform::blend): (WebCore::AffineTransform::toTransformationMatrix):
- platform/graphics/transforms/AffineTransform.h: Added. (WebCore::AffineTransform::a): (WebCore::AffineTransform::setA): (WebCore::AffineTransform::b): (WebCore::AffineTransform::setB): (WebCore::AffineTransform::c): (WebCore::AffineTransform::setC): (WebCore::AffineTransform::d): (WebCore::AffineTransform::setD): (WebCore::AffineTransform::e): (WebCore::AffineTransform::setE): (WebCore::AffineTransform::f): (WebCore::AffineTransform::setF): (WebCore::AffineTransform::operator== ): (WebCore::AffineTransform::operator!=): (WebCore::AffineTransform::operator*=): (WebCore::AffineTransform::operator*): (WebCore::AffineTransform::setMatrix):
- platform/graphics/win/GraphicsContextWin.cpp: (WebCore::GraphicsContextPlatformPrivate::concatCTM):
- platform/graphics/wince/GraphicsContextWince.cpp: (WebCore::GraphicsContext::concatCTM): (WebCore::GraphicsContext::getAffineCTM):
- platform/graphics/wx/GraphicsContextWx.cpp: (WebCore::GraphicsContext::getAffineCTM): (WebCore::GraphicsContext::concatCTM):
- platform/graphics/wx/PathWx.cpp: (WebCore::Path::transform):
- platform/graphics/wx/TransformationMatrixWx.cpp: (WebCore::AffineTransform::operator wxGraphicsMatrix):
- 8:22 AM Changeset in webkit [54136] by
-
- 12 edits in trunk
2010-01-29 Philippe Normand <pnormand@igalia.com>
Reviewed by Eric Carlson.
[GTK] set playbin mute property depending on volume value
https://bugs.webkit.org/show_bug.cgi?id=31586
New API in MediaPlayer for mute control. 3 new methods are
introduced:
- bool supportsMuting() const;
- bool muted() const;
- void setMuted(bool);
Platform MediaPlayer implementations can support it easily if the
underlying sound daemon/API supports muting (eg. not only setting
volume to 0) like PulseAudio for instance on Linux. At the moment
the only player supporting this new API is the
MediaPlayerPrivateGStreamer.
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::setMuted): (WebCore::HTMLMediaElement::mediaPlayerVolumeChanged): (WebCore::HTMLMediaElement::mediaPlayerMuteChanged):
- html/HTMLMediaElement.h:
- platform/graphics/MediaPlayer.cpp: (WebCore::NullMediaPlayerPrivate::supportsMuting): (WebCore::NullMediaPlayerPrivate::setMuted): (WebCore::MediaPlayer::MediaPlayer): (WebCore::MediaPlayer::muted): (WebCore::MediaPlayer::supportsMuting): (WebCore::MediaPlayer::setMuted): (WebCore::MediaPlayer::volumeChanged): (WebCore::MediaPlayer::muteChanged):
- platform/graphics/MediaPlayer.h: (WebCore::MediaPlayerClient::mediaPlayerMuteChanged):
- platform/graphics/MediaPlayerPrivate.h: (WebCore::MediaPlayerPrivateInterface::supportsMuting): (WebCore::MediaPlayerPrivateInterface::setMuted):
- platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::mediaPlayerPrivateVolumeChangedCallback): (WebCore::notifyVolumeIdleCallback): (WebCore::mediaPlayerPrivateMuteChangedCallback): (WebCore::notifyMuteIdleCallback): (WebCore::MediaPlayerPrivate::MediaPlayerPrivate): (WebCore::MediaPlayerPrivate::~MediaPlayerPrivate): (WebCore::MediaPlayerPrivate::volumeChangedCallback): (WebCore::MediaPlayerPrivate::volumeChanged): (WebCore::MediaPlayerPrivate::supportsMuting): (WebCore::MediaPlayerPrivate::setMuted): (WebCore::MediaPlayerPrivate::muteChangedCallback): (WebCore::MediaPlayerPrivate::muteChanged): (WebCore::MediaPlayerPrivate::createGSTPlayBin):
- platform/graphics/gtk/MediaPlayerPrivateGStreamer.h:
2010-01-29 Philippe Normand <pnormand@igalia.com>
Reviewed by Eric Carlson.
[GTK] set playbin mute property depending on volume value
https://bugs.webkit.org/show_bug.cgi?id=31586
New API in MediaPlayer for mute control
- public/WebMediaPlayerClient.h:
- src/WebMediaPlayerClientImpl.cpp: (WebKit::WebMediaPlayerClientImpl::volumeChanged): (WebKit::WebMediaPlayerClientImpl::muteChanged):
- src/WebMediaPlayerClientImpl.h:
- 7:30 AM Changeset in webkit [54135] by
-
- 1 edit1 copy in trunk/LayoutTests
Rubber-stamped by Kenneth Rohde Christiansen.
[Qt] Platform dependent expected file added for test introduced in r53868,
because this test passes. Compared to png file and Mac expected file.
- platform/qt/fast/lists/anonymous-items-expected.txt: Added.
- 7:03 AM Changeset in webkit [54134] by
-
- 3 edits in trunk/WebCore
[Qt] Build without SSL support is broken
Patch by Henry Haverinen <Henry Haverinen> on 2010-02-01
Reviewed by Simon Hausmann.
Added missing #ifdefs for OpenSSL support and one null-pointer
check for the socket.
https://bugs.webkit.org/show_bug.cgi?id=34416
- platform/network/qt/SocketStreamHandlePrivate.h:
- platform/network/qt/SocketStreamHandleQt.cpp:
(WebCore::SocketStreamHandlePrivate::SocketStreamHandlePrivate):
(WebCore::SocketStreamHandlePrivate::send):
- 6:05 AM Changeset in webkit [54133] by
-
- 7 edits in trunk/WebCore
2010-02-01 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: Fix rest of the NativeTextViewer (line numbers,
conditional breakpoints, selection).
- inspector/front-end/NativeTextViewer.js: (WebInspector.NativeTextViewer): (WebInspector.NativeTextViewer.prototype._updatePreferredSize): (WebInspector.NativeTextViewer.prototype._registerMouseListeners): (WebInspector.NativeTextViewer.prototype._mouseDown): (WebInspector.NativeTextViewer.prototype._contextMenu): (WebInspector.NativeTextViewer.prototype._lineForMouseEvent): (WebInspector.NativeTextViewer.prototype._lineHeight):
- inspector/front-end/TextEditor.js: (WebInspector.TextEditor): (WebInspector.TextEditor.prototype._registerMouseListeners): (WebInspector.TextEditor.prototype._offsetToLine): (WebInspector.TextEditor.prototype._lineHeight): (WebInspector.TextEditor.prototype.reveal): (WebInspector.TextEditor.prototype._paint): (WebInspector.TextEditor.prototype._updateDivDecorations): (WebInspector.TextEditor.prototype._paintSelection):
- 5:58 AM QtWebKitBackportingFixes edited by
- (diff)
- 5:54 AM QtWebKitBackportingFixes edited by
- (diff)
- 5:11 AM QtWebKitBackportingFixes edited by
- (diff)
- 4:43 AM QtWebKitBackportingFixes edited by
- (diff)
- 2:50 AM Changeset in webkit [54132] by
-
- 2 edits2 adds in trunk/WebCore
Adds implementation of JavaString for V8.
https://bugs.webkit.org/show_bug.cgi?id=33953
Reviewed by Ariya Hidayat.
No new tests, build fix only.
- bridge/jni/JNIBridge.h: Modified. Include JavaStringV8.h for V8
- bridge/jni/v8: Added.
- bridge/jni/v8/JavaStringV8.h: Added.
(JSC::Bindings::JavaStringImpl::init):
(JSC::Bindings::JavaStringImpl::UTF8String):
(JSC::Bindings::JavaStringImpl::uchars):
(JSC::Bindings::JavaStringImpl::length):
- 2:05 AM Changeset in webkit [54131] by
-
- 2 edits in trunk/JavaScriptCore
2010-02-01 Oliver Hunt <oliver@apple.com>
Windows build fix, update exports file (again)
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- 1:56 AM Changeset in webkit [54130] by
-
- 2 edits in trunk/JavaScriptCore
2010-02-01 Oliver Hunt <oliver@apple.com>
Windows build fix, update exports file
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- 1:43 AM Changeset in webkit [54129] by
-
- 5 edits2 adds in trunk
2010-01-31 Oliver Hunt <oliver@apple.com>
Reviewed by Maciej Stachowiak.
JSC is failing to propagate anonymous slot count on some transitions
https://bugs.webkit.org/show_bug.cgi?id=34321
Remove secondary Structure constructor, and make Structure store a copy
of the number of anonymous slots directly so saving an immediate allocation
of a property map for all structures with anonymous storage, which also
avoids the leaked property map on new property transition in the original
version of this patch.
We need to propagate the the anonymous slot count otherwise we can end up
with a structure recording incorrect information about the available and
needed space for property storage, or alternatively incorrectly reusing
some slots.
- JavaScriptCore.exp:
- runtime/Structure.cpp: (JSC::Structure::Structure): (JSC::Structure::materializePropertyMap): (JSC::Structure::addPropertyTransition): (JSC::Structure::changePrototypeTransition): (JSC::Structure::despecifyFunctionTransition): (JSC::Structure::getterSetterTransition): (JSC::Structure::toDictionaryTransition): (JSC::Structure::flattenDictionaryStructure): (JSC::Structure::copyPropertyTable): (JSC::Structure::put): (JSC::Structure::remove): (JSC::Structure::insertIntoPropertyMapHashTable): (JSC::Structure::createPropertyMapHashTable):
- runtime/Structure.h: (JSC::Structure::create): (JSC::Structure::hasAnonymousSlots): (JSC::Structure::anonymousSlotCount):
2010-02-01 Oliver Hunt <oliver@apple.com>
Reviewed by Maciej Stachowiak.
JSC is failing to propagate anonymous slot count on some transitions
https://bugs.webkit.org/show_bug.cgi?id=34321
Add test case for modifying DOM objects with anonymous storage.
- fast/dom/Window/anonymous-slot-with-changes-expected.txt: Added.
- fast/dom/Window/anonymous-slot-with-changes.html: Added.
- 1:27 AM Changeset in webkit [54128] by
-
- 3 edits in trunk/WebCore
2010-02-01 Alex Milowski <alex@milowski.com>
Reviewed by Darin Adler.
Added compile time debug support for mathml layout (block boundary & baseline)
- mathml/RenderMathMLBlock.cpp: (WebCore::RenderMathMLBlock::stretchToHeight): (WebCore::RenderMathMLBlock::paint):
- mathml/RenderMathMLBlock.h:
- 12:50 AM Changeset in webkit [54127] by
-
- 2 edits in trunk/WebCore
2010-02-01 Philippe Normand <pnormand@igalia.com>
Rubber stamped by Xan Lopez.
Fixed compilation warning about unsigned vs signed comparison.
- plugins/gtk/PluginViewGtk.cpp: (WebCore::PluginView::paint):
Jan 31, 2010:
- 11:29 PM Applications using WebKit edited by
- Paparazzi! is a Universal Binary. Also dropped the "www." from its URL. (diff)
- 11:05 PM Changeset in webkit [54126] by
-
- 5 edits2 adds in trunk/WebKitTools
2010-01-31 Chris Jerdonek <Chris Jerdonek>
Reviewed by Shinichiro Hamaji.
Moved style error handler code to their own classes, and
related refactoring. Increased unit test code coverage of
style error handling.
- Scripts/check-webkit-style:
- Minor change: added error_count variable.
- Scripts/webkitpy/style/checker.py:
- Renamed ProcessorOptions.should_report_error() to is_reportable().
- In the StyleChecker class--
- Removed _default_style_error_handler().
- Added _increment_error_count().
- Refactored to use DefaultStyleErrorHandler and PatchStyleErrorHandler constructors.
- Scripts/webkitpy/style/checker_unittest.py:
- In the StyleStyleCheckerTest class--
- Removed write_sample_error().
- Removed test_default_style_error_handler().
- In the StyleStyleCheckerTest class--
- Scripts/webkitpy/style/error_handlers.py: Added.
- Added DefaultStyleErrorHandler class.
- Added PatchStyleErrorHandler class.
- Scripts/webkitpy/style/error_handlers_unittest.py: Added.
- Added unit tests for DefaultStyleErrorHandler and PatchStyleErrorHandler.
- Scripts/webkitpy/style/unittests.py:
- Added error_handlers unit tests.
- 10:21 PM Changeset in webkit [54125] by
-
- 31 edits2 deletes in trunk/WebCore
2010-01-31 Kent Tamura <tkent@chromium.org>
Unreviewed. Revert r54112 and r54124 because of Windows build error.
- Android.mk:
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::scale): (WebCore::CanvasRenderingContext2D::rotate): (WebCore::CanvasRenderingContext2D::translate): (WebCore::CanvasRenderingContext2D::transform): (WebCore::CanvasRenderingContext2D::setTransform): (WebCore::CanvasRenderingContext2D::isPointInPath): (WebCore::CanvasRenderingContext2D::willDraw):
- html/canvas/CanvasRenderingContext2D.h:
- platform/graphics/GraphicsContext.h:
- platform/graphics/Path.h:
- platform/graphics/cairo/GraphicsContextCairo.cpp:
- platform/graphics/cairo/GraphicsContextPlatformPrivateCairo.h:
- platform/graphics/cairo/PathCairo.cpp:
- platform/graphics/cairo/TransformationMatrixCairo.cpp:
- platform/graphics/cg/GraphicsContextCG.cpp:
- platform/graphics/cg/GraphicsContextPlatformPrivateCG.h:
- platform/graphics/cg/PathCG.cpp:
- platform/graphics/cg/TransformationMatrixCG.cpp:
- platform/graphics/haiku/GraphicsContextHaiku.cpp:
- platform/graphics/haiku/PathHaiku.cpp:
- platform/graphics/qt/GraphicsContextQt.cpp:
- platform/graphics/qt/PathQt.cpp:
- platform/graphics/qt/TransformationMatrixQt.cpp:
- platform/graphics/skia/GraphicsContextSkia.cpp:
- platform/graphics/skia/PathSkia.cpp:
- platform/graphics/skia/TransformationMatrixSkia.cpp:
- platform/graphics/transforms/AffineTransform.cpp: Removed.
- platform/graphics/transforms/AffineTransform.h: Removed.
- platform/graphics/wince/GraphicsContextWince.cpp:
- platform/graphics/wx/GraphicsContextWx.cpp:
- platform/graphics/wx/PathWx.cpp:
- platform/graphics/wx/TransformationMatrixWx.cpp: (WebCore::TransformationMatrix::operator wxGraphicsMatrix):
- 9:04 PM Changeset in webkit [54124] by
-
- 1 edit in trunk/WebCore/WebCore.vcproj/WebCore.vcproj
Unreviewd. Windows build fix.
- 8:23 PM Changeset in webkit [54123] by
-
- 2 edits in trunk/JavaScriptCore
2010-01-31 Patrick Gansterer <paroga@paroga.com>
Reviewed by Darin Adler.
Buildfix for WinCE + style fixes (TLS_OUT_OF_INDEXES is not defined).
https://bugs.webkit.org/show_bug.cgi?id=34380
- wtf/ThreadSpecific.h:
- 6:37 PM Changeset in webkit [54122] by
-
- 2 edits in trunk/WebCore
2010-01-31 Kwang Yul Seo <skyul@company100.net>
Reviewed by Darin Adler.
Limit the scope of packing alignment to avoid MSVC C4103 warning.
https://bugs.webkit.org/show_bug.cgi?id=34390
Use pack(push, 16) and pack(pop) to limit the scope of packing
alignment change.
- bindings/js/JSSVGPODTypeWrapper.h:
- 6:33 PM Changeset in webkit [54121] by
-
- 5 edits in trunk
2010-01-31 Kent Tamura <tkent@chromium.org>
Reviewed by Darin Adler.
[Windows] Fix a bug of round() with huge integral numbers
https://bugs.webkit.org/show_bug.cgi?id=34297
Fix a bug that round() for huge integral numbers returns incorrect
results. For example, round(8639999913600001) returns
8639999913600002 without this change though the double type can
represent 8639999913600001 precisely.
Math.round() of JavaScript has a similar problem. But this change
doesn't fix it because Math.round() doesn't use round() of
MathExtra.h.
- wtf/MathExtras.h: (round): Avoid to do "num + 0.5" or "num - 0.5". (roundf): Fixed similarly. (llround): Calls round(). (llroundf): Calls roundf(). (lround): Calls round(). (lroundf): Calls roundf().
2010-01-31 Kent Tamura <tkent@chromium.org>
Reviewed by Darin Adler.
[Win] Fix a bug of round() with huge integral numbers
https://bugs.webkit.org/show_bug.cgi?id=34297
Add a test case to call round(8639999913600001).
- fast/forms/input-valueasnumber-datetime-expected.txt:
- fast/forms/script-tests/input-valueasnumber-datetime.js:
- 5:56 PM Changeset in webkit [54120] by
-
- 7 edits in trunk
2010-01-31 Kent Tamura <tkent@chromium.org>
Reviewed by Darin Adler.
Fix valueAsNumber calculation for type=month.
https://bugs.webkit.org/show_bug.cgi?id=34304
valueAsNumber calculation for type=month which was checked in as
r53893 was the number of milliseconds since UNIX epoch, and it was
wrong. The correct way is the number months since UNIX epoch.
- fast/forms/input-valueasnumber-month-expected.txt:
- fast/forms/script-tests/input-valueasnumber-month.js:
2010-01-31 Kent Tamura <tkent@chromium.org>
Reviewed by Darin Adler.
Fix valueAsNumber calculation for type=month.
https://bugs.webkit.org/show_bug.cgi?id=34304
valueAsNumber calculation for type=month which was checked in as
r53893 was the number of milliseconds since UNIX epoch, and it was
wrong. The correct way is the number months since UNIX epoch.
- html/DateComponents.cpp: (WebCore::DateComponents::setMonthsSinceEpoch): (WebCore::DateComponents::monthsSinceEpoch):
- html/DateComponents.h: Declare setMonthsSinceEpoch() and monthsSinceEpoch().
- html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::parseToDouble): Switch to monthsSinceEpoch() for type=MONTH. (WebCore::HTMLInputElement::valueAsDate): Add code with millisecondsSinceEpoch() for MONTH because parseToDouble() changed its behavior. (WebCore::HTMLInputElement::setValueAsNumber): Use setMonthsSinceEpoch() for MONTH.
- 5:43 PM Changeset in webkit [54119] by
-
- 2 edits in trunk/WebKit/chromium
2010-01-31 Kent Tamura <tkent@chromium.org>
Reviewed by Jeremy Orlow.
[Chromium] Fix a bug that a selected word is not recognized as a
spell-check source.
https://bugs.webkit.org/show_bug.cgi?id=33660
- src/ContextMenuClientImpl.cpp: (WebKit::isASingleWord): Use wordBreakIterator(), and correctly check the return value of textBreakNext().
- 5:42 PM Changeset in webkit [54118] by
-
- 2 edits in trunk/WebCore
Web Inspector: REGRESSION: Numbers in bubbles are vertically off-center
https://bugs.webkit.org/show_bug.cgi?id=34398
Reviewed by Timothy Hatcher.
- inspector/front-end/inspector.css: Specify line-height: normal for
".console-message .bubble" and ".sidebar-tree-item .status .bubble".
- 4:54 PM Changeset in webkit [54117] by
-
- 6 edits in trunk
2010-01-28 Ojan Vafai <ojan@chromium.org>
Reviewed by Darin Adler.
Implement CSSOM Range.getClientRects for collapsed selections
https://bugs.webkit.org/show_bug.cgi?id=34239
Adds two cases to getClientRects test.
- fast/dom/Range/getClientRects-expected.txt:
- fast/dom/Range/getClientRects.html:
2010-01-28 Ojan Vafai <ojan@chromium.org>
Reviewed by Darin Adler.
Implement CSSOM Range.getClientRects for collapsed selections
https://bugs.webkit.org/show_bug.cgi?id=34239
When getting the quads for a range on a text node, allow returning
zero width quads. This leaves the case of collapsed selections inside
elements still not fixed, but no worse.
- rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::selectionRect):
- rendering/RenderText.cpp: (WebCore::RenderText::absoluteQuadsForRange):
- 3:59 PM Changeset in webkit [54116] by
-
- 4 edits in trunk/WebCore
Roll r54095 out again without making a mess of the ChangeLog.
- 3:59 PM Changeset in webkit [54115] by
-
- 4 edits in trunk/WebCore
Revert r54114 since it made a mess of the ChangeLog.
- 3:43 PM Changeset in webkit [54114] by
-
- 4 edits in trunk/WebCore
2010-01-31 Eric Carlson <eric.carlson@apple.com>
Revert r54095 because it caused many media tests to fail.
- platform/graphics/win/GraphicsLayerCACF.cpp: (WebCore::GraphicsLayerCACF::setContentsToVideo): (WebCore::GraphicsLayerCACF::updateContentsVideo):
- platform/graphics/win/GraphicsLayerCACF.h: (WebCore::GraphicsLayerCACF::):
- platform/graphics/win/QTMovieWin.cpp: (QTMovieWinPrivate::task): (QTMovieWinPrivate::setSize):
- 3:01 PM Changeset in webkit [54113] by
-
- 8 edits in trunk
2010-01-31 Oliver Hunt <oliver@apple.com>
Reviewed by Simon Fraser.
Animated scaling of background-image is too slow
https://bugs.webkit.org/show_bug.cgi?id=33808
Update checksum.
- platform/mac/fast/backgrounds/size/backgroundSize16-expected.checksum:
2010-01-31 Oliver Hunt <oliver@apple.com>
Reviewed by Simon Fraser.
Animated scaling of background-image is too slow
https://bugs.webkit.org/show_bug.cgi?id=33808
Implement a version of the RenderImage animated scaling optimisation
for background images. Due to the possibility of arbitrary transforms
being applied to containing elements we explicitly check the current
CTM of the context for scaling or rotation.
- platform/graphics/GraphicsContext.cpp: (WebCore::GraphicsContext::drawTiledImage):
- platform/graphics/GraphicsContext.h:
- platform/graphics/transforms/TransformationMatrix.h: (WebCore::TransformationMatrix::isIdentityOrTranslation):
- rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelScaleData::RenderBoxModelScaleData): (WebCore::RenderBoxModelScaleData::~RenderBoxModelScaleData): (WebCore::RenderBoxModelScaleData::hiqhQualityRepaintTimer): (WebCore::RenderBoxModelScaleData::size): (WebCore::RenderBoxModelScaleData::setSize): (WebCore::RenderBoxModelScaleData::lastPaintTime): (WebCore::RenderBoxModelScaleData::setLastPaintTime): (WebCore::RenderBoxModelScaleData::useLowQualityScale): (WebCore::RenderBoxModelScaleData::transform): (WebCore::RenderBoxModelScaleData::setTransform): (WebCore::RenderBoxModelScaleData::setUseLowQualityScale): (WebCore::RenderBoxModelScaleObserver::boxModelObjectDestroyed): (WebCore::RenderBoxModelScaleObserver::highQualityRepaintTimerFired): (WebCore::RenderBoxModelScaleObserver::shouldPaintBackgroundAtLowQuality): (WebCore::RenderBoxModelObject::highQualityRepaintTimerFired): (WebCore::RenderBoxModelObject::~RenderBoxModelObject): (WebCore::RenderBoxModelObject::paintFillLayerExtended):
- rendering/RenderBoxModelObject.h:
- 1:04 PM Changeset in webkit [54112] by
-
- 31 edits2 adds in trunk/WebCore
2010-01-31 Dirk Schulze <krit@webkit.org>
Reviewed by Simon Fraser.
Add back an AffineTransform class for use by SVG
https://bugs.webkit.org/show_bug.cgi?id=33750
These are the first steps on reimplementing AffineTransform. Unlike
the old affine code, this one is platform independent like TransformationMatrix.
AffineTransform has the benefit, that it stores just 6 doubles instead of
16 in TransformationMatrix. The calculations of transformations are not that
complex and can improve the memory usage and speed of SVG.
AffineTransform can be used by HTML Canvas3D or SVG, since they are 2D related (at
least for the moment).
HTML Canvas is the first that makes use of the new AffineTransform. Next patches
will introduce the affine code to SVG.
No new tests. The new AffineTransformation code is tested by fast/canvas.
- Android.mk:
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::scale): (WebCore::CanvasRenderingContext2D::rotate): (WebCore::CanvasRenderingContext2D::translate): (WebCore::CanvasRenderingContext2D::transform): (WebCore::CanvasRenderingContext2D::setTransform): (WebCore::CanvasRenderingContext2D::isPointInPath): (WebCore::CanvasRenderingContext2D::willDraw):
- html/canvas/CanvasRenderingContext2D.h:
- platform/graphics/GraphicsContext.h:
- platform/graphics/Path.h:
- platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::getAffineCTM): (WebCore::GraphicsContext::concatCTM):
- platform/graphics/cairo/GraphicsContextPlatformPrivateCairo.h: (WebCore::GraphicsContextPlatformPrivate::concatCTM):
- platform/graphics/cairo/PathCairo.cpp: (WebCore::Path::transform):
- platform/graphics/cairo/TransformationMatrixCairo.cpp: (WebCore::AffineTransform::operator cairo_matrix_t):
- platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::concatCTM): (WebCore::GraphicsContext::getAffineCTM):
- platform/graphics/cg/GraphicsContextPlatformPrivateCG.h: (WebCore::GraphicsContextPlatformPrivate::concatCTM):
- platform/graphics/cg/PathCG.cpp: (WebCore::Path::transform):
- platform/graphics/cg/TransformationMatrixCG.cpp: (WebCore::AffineTransform::operator CGAffineTransform):
- platform/graphics/haiku/GraphicsContextHaiku.cpp: (WebCore::GraphicsContext::getAffineCTM): (WebCore::GraphicsContext::concatCTM):
- platform/graphics/haiku/PathHaiku.cpp: (WebCore::Path::transform):
- platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::getAffineCTM): (WebCore::GraphicsContext::concatCTM):
- platform/graphics/qt/PathQt.cpp: (WebCore::Path::transform):
- platform/graphics/qt/TransformationMatrixQt.cpp: (WebCore::AffineTransform::operator QTransform):
- platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContext::getAffineCTM):
- platform/graphics/skia/PathSkia.cpp: (WebCore::Path::transform):
- platform/graphics/skia/TransformationMatrixSkia.cpp: (WebCore::AffineTransform::operator SkMatrix):
- platform/graphics/transforms/AffineTransform.cpp: Added. (WebCore::affineTransformDecompose): (WebCore::affineTransformCompose): (WebCore::AffineTransform::AffineTransform): (WebCore::AffineTransform::reset): (WebCore::AffineTransform::setMatrix): (WebCore::AffineTransform::isIdentity): (WebCore::AffineTransform::det): (WebCore::AffineTransform::isInvertible): (WebCore::AffineTransform::inverse): (WebCore::AffineTransform::multiply): (WebCore::AffineTransform::multLeft): (WebCore::AffineTransform::rotate): (WebCore::AffineTransform::scale): (WebCore::AffineTransform::translate): (WebCore::AffineTransform::scaleNonUniform): (WebCore::AffineTransform::rotateFromVector): (WebCore::AffineTransform::flipX): (WebCore::AffineTransform::flipY): (WebCore::AffineTransform::shear): (WebCore::AffineTransform::skew): (WebCore::AffineTransform::skewX): (WebCore::AffineTransform::skewY): (WebCore::makeMapBetweenRects): (WebCore::AffineTransform::map): (WebCore::AffineTransform::mapPoint): (WebCore::AffineTransform::mapRect): (WebCore::AffineTransform::blend):
- platform/graphics/transforms/AffineTransform.h: Added. (WebCore::AffineTransform::a): (WebCore::AffineTransform::setA): (WebCore::AffineTransform::b): (WebCore::AffineTransform::setB): (WebCore::AffineTransform::c): (WebCore::AffineTransform::setC): (WebCore::AffineTransform::d): (WebCore::AffineTransform::setD): (WebCore::AffineTransform::e): (WebCore::AffineTransform::setE): (WebCore::AffineTransform::f): (WebCore::AffineTransform::setF): (WebCore::AffineTransform::operator== ): (WebCore::AffineTransform::operator!=): (WebCore::AffineTransform::operator*=): (WebCore::AffineTransform::operator*): (WebCore::AffineTransform::setMatrix):
- platform/graphics/wince/GraphicsContextWince.cpp: (WebCore::GraphicsContext::concatCTM): (WebCore::GraphicsContext::getAffineCTM):
- platform/graphics/wx/GraphicsContextWx.cpp: (WebCore::GraphicsContext::getAffineCTM): (WebCore::GraphicsContext::concatCTM):
- platform/graphics/wx/PathWx.cpp: (WebCore::Path::transform):
- platform/graphics/wx/TransformationMatrixWx.cpp: (WebCore::AffineTransform::operator wxGraphicsMatrix):
- 9:55 AM Changeset in webkit [54111] by
-
- 2 edits in trunk/WebCore
2010-01-31 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: [REGRESSION] Breakpoint source line is not displayed
in the breakpoint manager.
- inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype._addBreakpointToSource):
- 8:36 AM Changeset in webkit [54110] by
-
- 11 edits1 add in trunk/WebCore
2010-01-31 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: Introduce NativeTextViewer.
This change handles rendering highlighted text, using browser's
selection/drag/drop/click logic. Breakpoint decorations and
program counter is working.
Todo: line numbers are painted 'under' the text when scrolling
horizontally, search is not yet implemented.
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- inspector/front-end/DivBasedTextViewer.js: Added. (WebInspector.DivBasedTextViewer): (WebInspector.DivBasedTextViewer.prototype._textChanged): (WebInspector.DivBasedTextViewer.prototype._createLineDivs): (WebInspector.DivBasedTextViewer.prototype._updatePreferredSize): (WebInspector.DivBasedTextViewer.prototype._scroll): (WebInspector.DivBasedTextViewer.prototype._registerMouseListeners): (WebInspector.DivBasedTextViewer.prototype._registerKeyboardListeners): (WebInspector.DivBasedTextViewer.prototype._registerClipboardListeners): (WebInspector.DivBasedTextViewer.prototype._paintSelection): (WebInspector.DivBasedTextViewer.prototype._positionDivDecoration): (WebInspector.DivBasedTextViewer.prototype._mouseDown): (WebInspector.DivBasedTextViewer.prototype._contextMenu): (WebInspector.DivBasedTextViewer.prototype._caretForMouseEvent): (WebInspector.DivBasedTextViewer.prototype._paintLine): (WebInspector.DivBasedTextViewer.prototype._createSpan):
- inspector/front-end/Settings.js:
- inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype.clearMessages): (WebInspector.SourceFrame.prototype.sizeToFitContentHeight): (WebInspector.SourceFrame.prototype._createEditorIfNeeded): (WebInspector.SourceFrame.prototype._addMessageToSource): (WebInspector.SourceFrame.prototype.resize):
- inspector/front-end/TextEditor.js: (WebInspector.TextEditor): (WebInspector.TextEditor.prototype.setDivDecoration): (WebInspector.TextEditor.prototype._registerMouseListeners): (WebInspector.TextEditor.prototype._registerKeyboardListeners): (WebInspector.TextEditor.prototype._registerClipboardListeners): (WebInspector.TextEditor.prototype.reveal): (WebInspector.TextEditor.prototype._textChanged): (WebInspector.TextEditor.prototype.revalidateDecorationsAndPaint): (WebInspector.TextEditor.prototype._updatePreferredSize): (WebInspector.TextEditor.prototype.resize): (WebInspector.TextEditor.prototype._paintLinesContinuation): (WebInspector.TextEditor.prototype._paintLine): (WebInspector.TextEditor.prototype._contextMenu): (WebInspector.TextEditor.prototype._caretForMouseEvent): (WebInspector.TextEditor.prototype._changeFont):
- inspector/front-end/TextEditorHighlighter.js: (WebInspector.TextEditorHighlighter.prototype._lex):
- inspector/front-end/WebKit.qrc:
- inspector/front-end/inspector.html:
- inspector/front-end/textEditor.css:
- 7:42 AM Changeset in webkit [54109] by
-
- 2 edits in trunk/WebCore
2010-01-31 Benjamin Poulain <benjamin.poulain@nokia.com>
Reviewed by Eric Seidel.
[Qt] Enable FAST_MOBILE_SCROLLING on Qt embedded platforms
https://bugs.webkit.org/show_bug.cgi?id=34168
Enable FAST_MOBILE_SCROLLING for Qt on Maemo 5, Linux embedded
and Symbian
- WebCore.pro:
Jan 30, 2010:
- 11:38 PM Changeset in webkit [54108] by
-
- 3 edits in trunk/WebCore
2010-01-31 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Make ScriptState destructor protected since all non-empty
ScriptStates are managed by GC. Remove obsolete constructor.
- bindings/v8/ScriptState.cpp:
- bindings/v8/ScriptState.h:
- 10:01 PM Changeset in webkit [54107] by
-
- 5 edits in trunk/WebCore
2010-01-30 Simon Fraser <Simon Fraser>
Reviewed by Dan Bernstein.
Use CGGradient on Leopard and later, since it's faster than CGShading
https://bugs.webkit.org/show_bug.cgi?id=34384
Use CGGradient on Leopard and later, rather than CGShading, for
performance.
- platform/graphics/Gradient.h:
- platform/graphics/Gradient.cpp: (WebCore::Gradient::sortStopsIfNecessary): Utility method to sort stops. Did not call this from getColor() to avoid overhead of a function call.
- platform/graphics/cg/GradientCG.cpp: (WebCore::Gradient::platformDestroy): Use CGGradientRelease() post-Tiger. (WebCore::Gradient::platformGradient): Create and return a CGGradientRef post-Tiger. (WebCore::Gradient::fill): Call new paint() method. (WebCore::Gradient::paint): New convenence method that avoids testing isRadial() in a bunch of other places.
- platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::fillPath): Call the gradient's paint() method. (WebCore::GraphicsContext::strokePath): Ditto (WebCore::GraphicsContext::fillRect): Ditto (WebCore::GraphicsContext::strokeRect): Ditto
- 7:21 PM Changeset in webkit [54106] by
-
- 3 edits2 adds in trunk
2010-01-30 Simon Fraser <Simon Fraser>
Reviewed by Adele Peterson.
Do color animations on premultiplied colors
https://bugs.webkit.org/show_bug.cgi?id=34383
Convert colors to premultiplied alpha before interpolating them,
then convert the result back to non-premultiplied. This gives better
results when animating from transparent colors.
Test: transitions/color-transition-premultiplied.html
- page/animation/AnimationBase.cpp: (WebCore::blendFunc):
- 4:37 PM Changeset in webkit [54105] by
-
- 5 edits in trunk/WebKit/wx
Reviewed by Kevin Ollivier.
Add a way to get the parse mode to wxWebKit API.
https://bugs.webkit.org/show_bug.cgi?id=34341
- 1:42 PM Changeset in webkit [54104] by
-
- 2 edits in trunk/WebCore
2010-01-30 Gustavo Noronha Silva <Gustavo Noronha Silva>
Build fixes needed for make distcheck.
- GNUmakefile.am:
Jan 29, 2010:
- 9:37 PM Changeset in webkit [54103] by
-
- 2 edits in trunk/WebCore
Stop copying an IDL file in to the framework wrapper.
- WebCore.xcodeproj/project.pbxproj:
- 9:35 PM Changeset in webkit [54102] by
-
- 6 edits in trunk
Sort Xcode projects.
- JavaScriptCore.xcodeproj/project.pbxproj:
WebCore:
- WebCore.xcodeproj/project.pbxproj:
WebKit:
- WebKit.xcodeproj/project.pbxproj:
- 9:32 PM Changeset in webkit [54101] by
-
- 3 edits3 copies in trunk
Roll over a few oversized ChangeLogs.
- 9:30 PM Changeset in webkit [54100] by
-
- 7 edits2 deletes in trunk
Roll out r54073 as it introduced many thousands of leaks.
- 9:21 PM Changeset in webkit [54099] by
-
- 2 edits in trunk/WebKitTools
Fix run-leaks with newer versions of the leaks tool.
Rubber-stamped by Stephanie Lewis.
- Scripts/run-leaks:
- 9:00 PM Changeset in webkit [54098] by
-
- 3 edits in trunk/WebKitLibraries
Keep the Windows feature defines in sync with FeatureDefines.xcconfig.
- win/tools/vsprops/FeatureDefines.vsprops:
- win/tools/vsprops/FeatureDefinesCairo.vsprops:
- 8:51 PM Changeset in webkit [54097] by
-
- 6 edits in trunk
Fix the Mac build.
Disable ENABLE_INDEXED_DATABASE since it is "completely non-functional".
As the comment in FeatureDefines.xcconfig notes, the list of feature defines
needs to be kept in sync across the various files. The default values also
need to be kept in sync between these files and build-webkit.
- Configurations/FeatureDefines.xcconfig:
WebCore:
- Configurations/FeatureDefines.xcconfig:
WebKit/mac:
- Configurations/FeatureDefines.xcconfig:
- 7:04 PM Changeset in webkit [54096] by
-
- 2 edits in trunk/WebCore
2010-01-29 Steve Falkenburg <sfalken@apple.com>
Reviewed by Darin Adler.
Timeout for client-based Geolocation shouldn't start until user gives consent
https://bugs.webkit.org/show_bug.cgi?id=34352
- page/Geolocation.cpp: (WebCore::Geolocation::startRequest): Don't start timer if we're blocked on user consent. (WebCore::Geolocation::setIsAllowed): Start timer after user gives consent.
- 6:17 PM Changeset in webkit [54095] by
-
- 4 edits in trunk/WebCore
Fixed changed virtual function in GraphicsLayerCACF and call order issues
https://bugs.webkit.org/show_bug.cgi?id=34348
The correct virtual function in GraphicsLayerCACF is now being
called. We also fixed an issue in QTMovieWin where the size
of the movie was not being set correctly because the call order
was changed.
- 5:25 PM Changeset in webkit [54094] by
-
- 1 edit4 adds in trunk/WebKitTools
2010-01-29 Dirk Pranke <dpranke@chromium.org>
Reviewed by Eric Siedel.
Top-level test drivers for running the Chromium port of run-webkit-tests
and being able to rebaseline test results from the test bots. The
files in the Scripts directory are simply wrappers around the files
in webkitpy/layout_tests for convenience.
- Scripts/rebaseline-chromium-webkit-tests: Added.
- Scripts/run-chromium-webkit-tests: Added.
- Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py: Added.
- Scripts/webkitpy/layout_tests/run_chromium_webkit_tests.py: Added.
- 5:17 PM Changeset in webkit [54093] by
-
- 1 edit6 adds in trunk/WebKitTools
2010-01-29 Dirk Pranke <dpranke@chromium.org>
Reviewed by Eric Siedel.
Add in the second block of python code for the Chromium port
of run-webkit-tests. These files execute different diffs to classify
the various types of failures from a test.
- Scripts/webkitpy/layout_tests/test_types: Added.
- Scripts/webkitpy/layout_tests/test_types/init.py: Added.
- Scripts/webkitpy/layout_tests/test_types/fuzzy_image_diff.py: Added.
- Scripts/webkitpy/layout_tests/test_types/image_diff.py: Added.
- Scripts/webkitpy/layout_tests/test_types/test_type_base.py: Added.
- Scripts/webkitpy/layout_tests/test_types/text_diff.py: Added.
- 5:12 PM Changeset in webkit [54092] by
-
- 4 edits in branches/safari-4-branch
Versioning.
- 5:06 PM Changeset in webkit [54091] by
-
- 1 edit21 adds in trunk/WebKitTools
2010-01-29 Dirk Pranke <dpranke@chromium.org>
Reviewed by Eric Siedel.
Check in the first part of the Chromium Python port of the
run-webkit-tests test driver. The files under
layout_tests/layout_layout constitute most of the implementation;
they can be roughly divided into code that parses the
"test_expectations.txt" file that describes how we expect tests to
pass or fail, platform-specific hooks for the different Chromium
ports (in platform_utils*), code for parsing the output of the
tests and generating results files and HTML and JSON for the
dashboards, auxiliary scripts for starting and stopping HTTP and
Web Socket servers, and then one of the actual driver files
(test_shell_thread). Code for actually parsing test output for
failures and the top-level driver scripts will follow shortly.
- Scripts/webkitpy/layout_tests: Added.
- Scripts/webkitpy/layout_tests/layout_package: Added.
- Scripts/webkitpy/layout_tests/layout_package/init.py: Added.
- Scripts/webkitpy/layout_tests/layout_package/apache_http_server.py: Added.
- Scripts/webkitpy/layout_tests/layout_package/http_server.py: Added.
- Scripts/webkitpy/layout_tests/layout_package/http_server_base.py: Added.
- Scripts/webkitpy/layout_tests/layout_package/httpd2.pem: Added.
- scripts to start and stop apache. Note that the apache file generates a conf file dynamically, and we should switch to using the same static conf file that the regular run-webkit-tests uses, and we can also use the same httpd2.pem file.
- Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py: Added.
- Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py: Added.
- scripts to generate the JSON layout test dashboard and the flakiness dashboard
- Scripts/webkitpy/layout_tests/layout_package/lighttpd.conf: Added.
- default configuration for LigHTTPd (used on Windows)
- Scripts/webkitpy/layout_tests/layout_package/metered_stream.py: Added.
- utility class that implements progress bars on the console to be displayed while the tests are running
- Scripts/webkitpy/layout_tests/layout_package/path_utils.py: Added.
- various routines for manipulating paths and URIs
- Scripts/webkitpy/layout_tests/layout_package/platform_utils.py: Added.
- Scripts/webkitpy/layout_tests/layout_package/platform_utils_linux.py: Added.
- Scripts/webkitpy/layout_tests/layout_package/platform_utils_mac.py: Added.
- Scripts/webkitpy/layout_tests/layout_package/platform_utils_win.py: Added.
- platform-specific aspects of the drivers (binary names, paths, process control, etc.)
- Scripts/webkitpy/layout_tests/layout_package/test_expectations.py: Added.
- code for parsing the 'test_expectations.txt' file to determine which tests are expected to fail (and how) on which platforms
- Scripts/webkitpy/layout_tests/layout_package/test_failures.py: Added.
- code for handling different kinds of failures (generating output in the results, etc.)
- Scripts/webkitpy/layout_tests/layout_package/test_files.py: Added.
- code to gather the lists of tests
- Scripts/webkitpy/layout_tests/layout_package/test_shell_thread.py: Added.
- code to actually execute tests via TestShell and process the output
- Scripts/webkitpy/layout_tests/layout_package/websocket_server.py: Added.
- scripts to start and stop the pywebsocket server
- 4:59 PM Changeset in webkit [54090] by
-
- 4 edits in trunk/WebKit/win
Roll out r54088 because the functions were already in
IWebPreferencesPrivate, so they should stay there.
- 4:48 PM Changeset in webkit [54089] by
-
- 4 edits in trunk/WebCore
2010-01-29 Jakob Petsovits <jpetsovits@rim.com>
Reviewed by Nikolas Zimmermann.
[OpenVG] Implement more graphics primitives
https://bugs.webkit.org/show_bug.cgi?id=34339
Adds lines, arcs, ellipses, polygons and rounded
rectangles to PainterOpenVG and GraphicsContext.
Rounded rects support by Eli Fidler <efidler@rim.com>.
- platform/graphics/openvg/GraphicsContextOpenVG.cpp: (WebCore::GraphicsContext::drawLine): (WebCore::GraphicsContext::drawEllipse): (WebCore::GraphicsContext::strokeArc): (WebCore::GraphicsContext::drawConvexPolygon): (WebCore::GraphicsContext::fillRect): (WebCore::GraphicsContext::fillRoundedRect): (WebCore::GraphicsContext::drawFocusRing): (WebCore::GraphicsContext::drawLineForText): (WebCore::GraphicsContext::clearRect): (WebCore::GraphicsContext::strokeRect):
- platform/graphics/openvg/PainterOpenVG.cpp: (WebCore::PainterOpenVG::drawRect): (WebCore::PainterOpenVG::drawRoundedRect): (WebCore::PainterOpenVG::drawLine): (WebCore::PainterOpenVG::drawArc): (WebCore::PainterOpenVG::drawEllipse): (WebCore::PainterOpenVG::drawPolygon):
- platform/graphics/openvg/PainterOpenVG.h:
- 4:48 PM Changeset in webkit [54088] by
-
- 4 edits in trunk/WebKit/win
Rubber-stamped by Adam Roben.
Move customDragCursorEnabled preference functions from
IWebPreferences to IWebPreferencesPrivate.
- Interfaces/IWebPreferences.idl: Moved customDragFunctions from here...
- Interfaces/IWebPreferencesPrivate.idl: To here.
- Interfaces/WebKit.idl: Touched to make sure we rebuild.
- 4:34 PM Changeset in webkit [54087] by
-
- 1 edit9 adds in trunk/WebKitTools
2010-01-29 Dirk Pranke <dpranke@chromium.org>
Reviewed by Eric Seidel.
Check in a copy of the simplejson library; it will be used by
the Chromium port of run-webkit-tests.
- simplejson: Added.
- simplejson/LICENSE.txt: Added.
- simplejson/README.txt: Added.
- simplejson/init.py: Added.
- simplejson/_speedups.c: Added. (ascii_escape_char): (ascii_escape_unicode): (ascii_escape_str): (py_encode_basestring_ascii): (init_speedups):
- simplejson/decoder.py: Added.
- simplejson/encoder.py: Added.
- simplejson/jsonfilter.py: Added.
- simplejson/scanner.py: Added.
- 4:27 PM Changeset in webkit [54086] by
-
- 2 edits in trunk/WebKitTools
2010-01-29 Dirk Pranke <dpranke@chromium.org>
No review
Add myself to the committers list
- Scripts/webkitpy/committers.py:
- 4:18 PM Changeset in webkit [54085] by
-
- 23 edits12 adds in trunk
2010-01-29 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Dimitri Glazkov.
A first step towards the Indexed Database API
https://bugs.webkit.org/show_bug.cgi?id=34342
Add runtime enable support for Indexed Database API.
- features.gypi:
- public/WebRuntimeFeatures.h:
- src/WebRuntimeFeatures.cpp: (WebKit::WebRuntimeFeatures::enableIndexedDatabase): (WebKit::WebRuntimeFeatures::isIndexedDatabaseEnabled):
2010-01-29 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Dimitri Glazkov.
A first step towards the Indexed Database API
https://bugs.webkit.org/show_bug.cgi?id=34342
Flesh out the first part of Indexed Database API.
Currently only compiles with v8 + chromium for now.
Completely non-functional, but it seems best to do
this in chunks.
No tests because nothing works yet.
- Configurations/FeatureDefines.xcconfig:
- WebCore.gypi:
- bindings/scripts/CodeGeneratorV8.pm:
- bindings/v8/DOMObjectsInclude.h:
- bindings/v8/DerivedSourcesAllInOne.cpp:
- bindings/v8/RuntimeEnabledFeatures.cpp:
- bindings/v8/RuntimeEnabledFeatures.h: (WebCore::RuntimeEnabledFeatures::setIndexedDatabaseEnabled): (WebCore::RuntimeEnabledFeatures::indexedDatabaseEnabled):
- bindings/v8/V8Index.cpp:
- bindings/v8/V8Index.h:
- bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::V8DOMWindow::IndexedDBEnabled):
- bindings/v8/custom/V8IDBRequestCustom.cpp: Added. (WebCore::V8IDBRequest::resultAccessorGetter):
- bindings/v8/custom/V8IndexedDatabaseRequestCustom.cpp: Added. (WebCore::V8IndexedDatabaseRequest::openCallback):
- dom/EventNames.h:
- page/DOMWindow.cpp: (WebCore::DOMWindow::indexedDB):
- page/DOMWindow.h:
- page/DOMWindow.idl:
- storage/IDBDatabaseError.h: Added. (WebCore::IDBDatabaseError::create): (WebCore::IDBDatabaseError::~IDBDatabaseError): (WebCore::IDBDatabaseError::code): (WebCore::IDBDatabaseError::setCode): (WebCore::IDBDatabaseError::message): (WebCore::IDBDatabaseError::setMessage): (WebCore::IDBDatabaseError::IDBDatabaseError):
- storage/IDBDatabaseError.idl: Added.
- storage/IDBDatabaseException.h: Added. (WebCore::IDBDatabaseException::create): (WebCore::IDBDatabaseException::~IDBDatabaseException): (WebCore::IDBDatabaseException::code): (WebCore::IDBDatabaseException::setCode): (WebCore::IDBDatabaseException::message): (WebCore::IDBDatabaseException::setMessage): (WebCore::IDBDatabaseException::IDBDatabaseException):
- storage/IDBDatabaseException.idl: Added.
- storage/IDBRequest.cpp: Added. (WebCore::IDBRequest::IDBRequest): (WebCore::IDBRequest::~IDBRequest): (WebCore::IDBRequest::abort): (WebCore::IDBRequest::eventTargetData): (WebCore::IDBRequest::ensureEventTargetData):
- storage/IDBRequest.h: Added. (WebCore::IDBRequest::create): (WebCore::IDBRequest::readyState): (WebCore::IDBRequest::error): (WebCore::IDBRequest::result): (WebCore::IDBRequest::scriptExecutionContext): (WebCore::IDBRequest::toIDBRequest): (WebCore::IDBRequest::refEventTarget): (WebCore::IDBRequest::derefEventTarget):
- storage/IDBRequest.idl: Added.
- storage/IndexedDatabaseRequest.cpp: Added. (WebCore::IndexedDatabaseRequest::IndexedDatabaseRequest): (WebCore::IndexedDatabaseRequest::~IndexedDatabaseRequest): (WebCore::IndexedDatabaseRequest::open):
- storage/IndexedDatabaseRequest.h: Added. (WebCore::IndexedDatabaseRequest::create): (WebCore::IndexedDatabaseRequest::request):
- storage/IndexedDatabaseRequest.idl: Added.
2010-01-29 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Dimitri Glazkov.
A first step towards the Indexed Database API
https://bugs.webkit.org/show_bug.cgi?id=34342
Add Indexed Database API
- configure.ac:
2010-01-29 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Dimitri Glazkov.
A first step towards the Indexed Database API
https://bugs.webkit.org/show_bug.cgi?id=34342
Add indexed database API.
- Scripts/build-webkit:
- 4:00 PM Changeset in webkit [54084] by
-
- 2 edits in trunk/WebKitTools
Correct openHTTPD() to print requests to stdout if run-webkit-httpd is used.
This fixes a regression introduced in r53559.
Reviewed by Alexey Proskuryakov.
https://bugs.webkit.org/show_bug.cgi?id=34336
- Scripts/webkitperl/httpd.pm:
- 4:00 PM Changeset in webkit [54083] by
-
- 9 edits in trunk
WebCore: Drag and Drop: Windows uses "stop" sign as cursor when dragging
https://bugs.webkit.org/show_bug.cgi?id=34305
<rdar://problem/7589672>
Reviewed by Adam Roben.
Add a FIXME for the code that needs to be changed to support full
custom cursors.
- page/EventHandler.cpp:
(WebCore::EventHandler::handleDrag):
WebKit/win: Drag and Drop: Windows uses "stop" sign as cursor when dragging
https://bugs.webkit.org/show_bug.cgi?id=34305
<rdar://problem/7589672>
Reviewed by Adam Roben.
Add a preference in WebKit (that defaults to false), for whether or not
we should show the custom cursors during drag and drop. However, this is
currently only used on Windows, and only used to hide the "drop not allowed"
icon inside the WebView is the preference is set to true.
This will be off by default, so no change in behavior.
- Interfaces/IWebPreferencesPrivate.idl: Added new functions.
- Interfaces/WebKit.idl: Touched to force Interfaces build.
- WebDropSource.cpp:
(WebDropSource::GiveFeedback): Implementation of conditional showing cursor
logic.
- WebPreferenceKeysPrivate.h: Added new preference key.
- WebPreferences.cpp: Added new functions.
(WebPreferences::setCustomDragCursorsEnabled):
(WebPreferences::customDragCursorsEnabled):
- WebPreferences.h: Added new functions.
- 3:39 PM Changeset in webkit [54082] by
-
- 4 edits2 adds in trunk
- 2:26 PM Changeset in webkit [54081] by
-
- 9 edits in trunk
Reviewed by Dan Bernstein.
<rdar://problem/7441982> REGRESSION (TOT): Adobe CS4: Installer alerts are displayed as
blank windows
We probably shouldn't be deferring loads below modal dialogs and alerts, because that's not
what being modal means. But making such a change for general Web content would require fixes
in other parts of code, which I'm not ready to implement right now, so making it application
specific.
WebCore:
- page/Page.cpp: (WebCore::Page::setDefersLoading): Do nothing if load deferring is not enabled in page settings.
- WebCore.base.exp:
- page/Settings.cpp: (WebCore::Settings::Settings): (WebCore::Settings::setLoadDeferringEnabled):
- page/Settings.h: (WebCore::Settings::loadDeferringEnabled): Add the ability for client to disable page deferring (still enabled by default).
- platform/mac/RuntimeApplicationChecks.h:
- platform/mac/RuntimeApplicationChecks.mm: (WebCore::applicationIsAdobeInstaller): Added a bundle ID test for Adobe installer.
WebKit/mac:
- WebView/WebView.mm: (shouldEnableLoadDeferring): Load deferring is enabled unless the application is Adobe Installer. (-[WebView _preferencesChangedNotification:]): Call setLoadDeferringEnabled().
- 2:16 PM Changeset in webkit [54080] by
-
- 2 edits in trunk/WebCore
Build fix.
- page/Geolocation.cpp:
(WebCore::Geolocation::startUpdating):
- 2:08 PM Changeset in webkit [54079] by
-
- 3 edits in trunk/WebCore
2010-01-29 Steve Falkenburg <sfalken@apple.com>
Reviewed by Darin Adler.
Client-based Geolocation starts updating before getting consent from the user
https://bugs.webkit.org/show_bug.cgi?id=34343
- page/Geolocation.cpp: (WebCore::Geolocation::startRequest): Pass notifier instead of options to startUpdating. (WebCore::Geolocation::setIsAllowed): Add the observer or notify of error for deferred startUpdating. (WebCore::Geolocation::startUpdating): Pass notifier instead of options, since we may need to call it if we fail to get user consent. Defer adding the observer if we don't yet have user consent, since this could kick off server-based wifi Geolocation requests.
- page/Geolocation.h:
- 1:55 PM Changeset in webkit [54078] by
-
- 17 edits1 copy2 adds in trunk
MSAA: Crash when posting a notification for a detached object
https://bugs.webkit.org/show_bug.cgi?id=34309
<rdar://problem/7409759>
Reviewed by Darin Adler.
WebCore:
Test: platform/win/accessibility/detached-object-notification-crash.html
- accessibility/AccessibilityRenderObject.cpp:
(AccessibilityRenderObject::document):
Null check m_renderer. This is the bug fix; the other changes in the
patch are for the test.
- accessibility/win/AXObjectCacheWin.cpp:
(WebCore::AXObjectCache::postPlatformNotification):
Map AXValueChanged to EVENT_OBJECT_VALUECHANGED, so we'll post a
notification when AXValueChanged is posted. Receiving an event of this
type tells us that the test passed.
WebKit/win:
- AccessibleBase.cpp:
(AccessibleBase::QueryService):
If an unrecognized service ID is passed, return early. Otherwise, return
the result of QueryInterface.
(AccessibleBase::QueryInterface):
Add static_casts. Check for new UUIDs.
(AccessibleBase::isSameObject):
Query the object for AccessibleBase. Return whether the pointers or the
wrapped objects match.
- AccessibleBase.h:
Give the class a UUID so we can query for it in isSameObject(). Inherit
from IAccessibleComparable; inherit from IServiceProvider so clients can
use QueryService to query for a custom interface.
- Interfaces/AccessibleComparable.idl: Added. Declares a function that
can be called to compare to accessible objects.
- Interfaces/WebKit.idl:
Include the new IDL.
- WebKit.vcproj/Interfaces.vcproj:
Add the new IDL to the project.
WebKitTools:
- DumpRenderTree/AccessibilityController.h:
Declare new functions. Add new members to store the event hook and the
mapping of accessibility elements to their JS callbacks.
- DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
(AccessibilityController::notificationReceived):
Stubbed.
(AccessibilityController::addNotificationListener):
Stubbed.
- DumpRenderTree/mac/AccessibilityControllerMac.mm:
(AccessibilityController::notificationReceived):
Stubbed.
(AccessibilityController::addNotificationListener):
Stubbed.
- DumpRenderTree/win/AccessibilityControllerWin.cpp:
(AccessibilityController::AccessibilityController):
Initialize the event hook.
(AccessibilityController::~AccessibilityController):
Remove the event hook. Unprotect all of the JS functions that are stored
in the map.
(logEventProc):
Clean-up a variable.
(stringEvent):
Return a string description of the MSAA event code.
(notificationListenerProc):
Get the accessible object from the event, and query it for IAccessible.
Call the AccessibilityController's notificationReceived().
(comparableObject):
Use QueryService to obtain the IAccessibleComparable for the
IServiceProvider.
(AccessibilityController::notificationReceived):
Iterate the map of objects that have registered for notification
callbacks. Query each for IServiceProvider, then use comparableObject()
to get an IAccessibleComparable. If we find an object matching the
notified object, call its callback, passing the event that was received.
(AccessibilityController::addNotificationListener):
If we have not created the event hook, create it. Protect the JS
callback function object, and add the object and its callback to our
map.
- DumpRenderTree/win/AccessibilityUIElementWin.cpp:
(AccessibilityUIElement::addNotificationListener):
Call through to the AccessibilityController's addNotificationListener().
- DumpRenderTree/win/DumpRenderTreeWin.h:
Add an extern declaration for the shared FrameLoadDelegate extern, so we
can access it from AccessibilityController.
- DumpRenderTree/win/FrameLoadDelegate.h:
(FrameLoadDelegate::accessibilityController):
Return the AccessibilityController.
LayoutTests:
- platform/win/accessibility/detached-object-notification-crash-expected.txt: Added.
- platform/win/accessibility/detached-object-notification-crash.html: Added.
- 1:32 PM Changeset in webkit [54077] by
-
- 2 edits in trunk/WebKitTools
Rubberstamped by Simon Hausmann.
[Qt] Separate implementation from class definition.
- QtLauncher/main.cpp:
(LauncherWindow::webView):
(LauncherWindow::LauncherWindow):
(LauncherWindow::~LauncherWindow):
(LauncherWindow::keyPressEvent):
(LauncherWindow::grabZoomKeys):
(LauncherWindow::sendTouchEvent):
(LauncherWindow::eventFilter):
(LauncherWindow::loadStarted):
(LauncherWindow::loadFinished):
(LauncherWindow::showLinkHover):
(LauncherWindow::zoomIn):
(LauncherWindow::zoomOut):
(LauncherWindow::resetZoom):
(LauncherWindow::toggleZoomTextOnly):
(LauncherWindow::print):
(LauncherWindow::screenshot):
(LauncherWindow::setEditable):
(LauncherWindow::dumpHtml):
(LauncherWindow::selectElements):
(LauncherWindow::setTouchMocking):
(LauncherWindow::newWindow):
(LauncherWindow::setupUI):
- 1:12 PM Changeset in webkit [54076] by
-
- 2 edits in trunk/WebKitTools
2010-01-29 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Darin Adler.
prepare-ChangeLog outputs useless messages for a nonexistent bug ID
https://bugs.webkit.org/show_bug.cgi?id=34313
- Scripts/prepare-ChangeLog:
- 12:21 PM Changeset in webkit [54075] by
-
- 9 edits in trunk
2010-01-29 Darin Fisher <darin@chromium.org>
Okayed by Oliver Hunt.
Rollout r53949, r53951 and r54013 due to a Chromium regression that it
causes. Somehow this code change is triggering an endless repaint loop.
- platform/graphics/GraphicsContext.cpp: (WebCore::GraphicsContext::drawTiledImage):
- platform/graphics/GraphicsContext.h:
- platform/graphics/transforms/TransformationMatrix.h: (WebCore::TransformationMatrix::isIdentityOrTranslation):
- rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::~RenderBoxModelObject): (WebCore::RenderBoxModelObject::paintFillLayerExtended):
- rendering/RenderBoxModelObject.h:
- 11:47 AM Changeset in webkit [54074] by
-
- 3 edits in trunk/WebKitTools
[Qt] On Maemo5, a click/touch in the location bar (when unfocused)
should result in all text selected.
Reviewed by Ariya Hidayat.
- QtLauncher/locationedit.cpp:
(LocationEdit::focusInEvent):
- QtLauncher/locationedit.h:
- 11:46 AM Changeset in webkit [54073] by
-
- 7 edits2 adds in trunk
2010-01-29 Oliver Hunt <oliver@apple.com>
Reviewed by Darin Adler.
JSC is failing to propagate anonymous slot count on some transitions
https://bugs.webkit.org/show_bug.cgi?id=34321
Remove the unsafe two argument Structure::create method, and correct
the uses of it to propagate the anonymous slot count.
- runtime/JSObject.h: (JSC::JSObject::setStructure):
- runtime/Structure.cpp: (JSC::Structure::addPropertyTransition): (JSC::Structure::changePrototypeTransition): (JSC::Structure::despecifyFunctionTransition): (JSC::Structure::getterSetterTransition): (JSC::Structure::toDictionaryTransition):
- runtime/Structure.h:
2010-01-29 Oliver Hunt <oliver@apple.com>
Reviewed by Darin Adler.
JSC is failing to propagate anonymous slot count on some transitions
https://bugs.webkit.org/show_bug.cgi?id=34321
Add a test for modification of a type with anonymous slots.
- fast/dom/Window/anonymous-slot-with-changes-expected.txt: Added.
- fast/dom/Window/anonymous-slot-with-changes.html: Added.
2010-01-29 Oliver Hunt <oliver@apple.com>
Reviewed by Darin Adler.
JSC is failing to propagate anonymous slot count on some transitions
https://bugs.webkit.org/show_bug.cgi?id=34321
Make code generator add assertions for anonymous slot count.
Test: fast/dom/Window/anonymous-slot-with-changes.html
- bindings/scripts/CodeGeneratorJS.pm:
- 11:46 AM Changeset in webkit [54072] by
-
- 3 edits in trunk/WebKitTools
[Qt] Show progress reaching 100% for loads.
Reviewed by Ariya Hidayat.
- QtLauncher/locationedit.cpp:
(LocationEdit::LocationEdit):
(LocationEdit::setProgress):
(LocationEdit::reset):
(LocationEdit::paintEvent):
- QtLauncher/locationedit.h:
- 10:32 AM Changeset in webkit [54071] by
-
- 4 edits in trunk/WebCore
2010-01-29 Tony Chang <tony@chromium.org>
Reviewed by Darin Adler.
Add gdb helper methods for Ranges like we have for VisibleSelections.
https://bugs.webkit.org/show_bug.cgi?id=34308
No new tests, these are only for debugging.
- dom/Position.cpp: (WebCore::Position::showTreeForThis):
- dom/Range.cpp: (showTree):
- dom/Range.h:
- 10:13 AM Changeset in webkit [54070] by
-
- 2 edits in trunk/WebCore
2010-01-29 Drew Wilson <atwilson@chromium.org>
Reviewed by Adam Barth.
V8 implementation of MessageEvent.initMessageEvent() does not set source correctly.
https://bugs.webkit.org/show_bug.cgi?id=34292
Test: fast/events/init-events.html will pass in Chrome now.
- bindings/v8/custom/V8MessageEventCustom.cpp: (WebCore::V8MessageEvent::initMessageEventCallback): Now properly extracts the reference to the DOMWindow object from the passed-in window parameter.
- 9:56 AM Changeset in webkit [54069] by
-
- 7 edits in trunk
2010-01-29 Ben Murdoch <benm@google.com>
Reviewed by Dimitri Glazkov.
[Android] Android needs functionality in the ChromeClient to be informed when touch events are and are not needed by the webpage.
https://bugs.webkit.org/show_bug.cgi?id=34215
Add a function on the ChromeClient that WebCore can use to inform the platform when it needs touch events. This way the platform can optimise by not forwarding the events if they are not required.
No new tests as the only implementation is specific to Android.
- dom/Document.cpp: (WebCore::Document::detach): Check if this is the top level document and if so, stop forwarding touch events. (WebCore::Document::addListenerTypeIfNeeded): Inform the ChromeClient it should start forwarding touch events and guard touch event code properly.
- history/CachedFrame.cpp: (WebCore::CachedFrameBase::restore): If the document uses touch events, inform the ChromeClient to start forwarding them. (WebCore::CachedFrame::CachedFrame): If the document uses touch events, inform the ChromeClient to stop forwarding them, as the document is being put into the page cache.
- loader/EmptyClients.h: (WebCore::EmptyChromeClient::needTouchEvents): Add an empty implementation.
- page/ChromeClient.h: Add the needTouchEvents() function.
2010-01-29 Ben Murdoch <benm@google.com>
Reviewed by Dimitri Glazkov.
[Android] Android needs functionality in the ChromeClient to be informed when touch events are and are not needed by the webpage.
https://bugs.webkit.org/show_bug.cgi?id=34215
Add needTouchEvents() to the ChromeClient which is called when the page decides it needs or no longer needs to be informed of touch events.
- WebCoreSupport/ChromeClientQt.h: (WebCore::ChromeClientQt::needTouchEvents): Add an empty implementation.
- 9:38 AM Changeset in webkit [54068] by
-
- 2 edits in trunk/WebCore
2010-01-29 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Pavel Feldman.
Fix toolbar gradient to match the window's titlebar on Snow Leopard
https://bugs.webkit.org/show_bug.cgi?id=34320
- inspector/front-end/inspector.css:
- 9:22 AM Changeset in webkit [54067] by
-
- 2 edits in trunk/WebCore
2010-01-29 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Pavel Feldman.
Fix MacOS X version detection
MacOS X version can have 2 or 3 segments.
https://bugs.webkit.org/show_bug.cgi?id=34322
- inspector/front-end/inspector.js: (WebInspector._detectPlatform):
- 9:06 AM Changeset in webkit [54066] by
-
- 2 edits in trunk/WebKitTools
2010-01-29 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Disable the QtLauncher statusbar on Maemo
- QtLauncher/main.cpp: (LauncherWindow::showLinkHover): (LauncherWindow::selectElements):
- 8:49 AM Changeset in webkit [54065] by
-
- 4 edits2 copies in trunk/WebKitTools
2010-01-29 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Display page loading progress inside the QtLauncher location bar
- QtLauncher/QtLauncher.pro:
- QtLauncher/locationedit.cpp: Added. (LocationEdit::LocationEdit): (LocationEdit::setProgress): (LocationEdit::paintEvent):
- QtLauncher/locationedit.h: Added.
- QtLauncher/mainwindow.cpp: (MainWindow::buildUI):
- QtLauncher/mainwindow.h:
- 8:25 AM Changeset in webkit [54064] by
-
- 2 edits in trunk/WebKit/qt
Disable auto-uppercase and predictive text on Maemo5, just like the
build-in MicroB Browser.
Reviewed by Simon Hausmann
- WebCoreSupport/EditorClientQt.cpp:
(WebCore::EditorClientQt::setInputMethodState):
- 7:43 AM Changeset in webkit [54063] by
-
- 8 edits4 adds in trunk/WebCore
2010-01-29 Jakob Petsovits <jpetsovits@rim.com>
Reviewed by Nikolas Zimmermann.
[OpenVG] Implement a basic GraphicsContext on top of a new PainterOpenVG class
https://bugs.webkit.org/show_bug.cgi?id=33405
PainterOpenVG provides painter state management that works
on a single (EGL) context, and apart from painter state
implements a single drawing operation (for now), drawRect().
It is a generic painter class that cooperates with
SurfaceOpenVG to enable robust surface/context switching
(given that EGL doesn't notify us if somebody switches
the surface/context behind our backs), and provides
painting operations close to OpenVG's way of working
that GraphicsContext, Path, Image, Font and other WebKit
platform classes can use to draw on.
Initial code for state management and OpenVG scissoring by
Eli Fidler <efidler@rim.com>. VGRect/VGMatrix and the bulk
of the transformations code by Adam Treat <atreat@rim.com>.
Preliminary drawFocusRing() implementation by Yong Li <yoli@rim.com>.
- platform/graphics/FloatRect.h:
- platform/graphics/GraphicsContext.cpp:
- platform/graphics/GraphicsContext.h:
- platform/graphics/openvg/GraphicsContextOpenVG.cpp: Added. (WebCore::GraphicsContextPlatformPrivate::GraphicsContextPlatformPrivate): (WebCore::GraphicsContext::GraphicsContext): (WebCore::GraphicsContext::~GraphicsContext): (WebCore::GraphicsContext::platformContext): (WebCore::GraphicsContext::getCTM): (WebCore::GraphicsContext::savePlatformState): (WebCore::GraphicsContext::restorePlatformState): (WebCore::GraphicsContext::drawRect): (WebCore::GraphicsContext::drawLine): (WebCore::GraphicsContext::drawEllipse): (WebCore::GraphicsContext::strokeArc): (WebCore::GraphicsContext::drawConvexPolygon): (WebCore::GraphicsContext::fillPath): (WebCore::GraphicsContext::strokePath): (WebCore::GraphicsContext::fillRect): (WebCore::GraphicsContext::fillRoundedRect): (WebCore::GraphicsContext::beginPath): (WebCore::GraphicsContext::addPath): (WebCore::GraphicsContext::clip): (WebCore::GraphicsContext::clipPath): (WebCore::GraphicsContext::drawFocusRing): (WebCore::GraphicsContext::drawLineForText): (WebCore::GraphicsContext::drawLineForMisspellingOrBadGrammar): (WebCore::GraphicsContext::roundToDevicePixels): (WebCore::GraphicsContext::setPlatformShadow): (WebCore::GraphicsContext::clearPlatformShadow): (WebCore::GraphicsContext::beginTransparencyLayer): (WebCore::GraphicsContext::endTransparencyLayer): (WebCore::GraphicsContext::clearRect): (WebCore::GraphicsContext::strokeRect): (WebCore::GraphicsContext::setLineCap): (WebCore::GraphicsContext::setLineDash): (WebCore::GraphicsContext::setLineJoin): (WebCore::GraphicsContext::setMiterLimit): (WebCore::GraphicsContext::setAlpha): (WebCore::GraphicsContext::setCompositeOperation): (WebCore::GraphicsContext::canvasClip): (WebCore::GraphicsContext::clipOut): (WebCore::GraphicsContext::scale): (WebCore::GraphicsContext::rotate): (WebCore::GraphicsContext::translate): (WebCore::GraphicsContext::origin): (WebCore::GraphicsContext::clipOutEllipseInRect): (WebCore::GraphicsContext::clipToImageBuffer): (WebCore::GraphicsContext::addInnerRoundedRectClip): (WebCore::GraphicsContext::concatCTM): (WebCore::GraphicsContext::setURLForRect): (WebCore::GraphicsContext::setPlatformStrokeColor): (WebCore::GraphicsContext::setPlatformStrokeStyle): (WebCore::GraphicsContext::setPlatformStrokeThickness): (WebCore::GraphicsContext::setPlatformFillColor): (WebCore::GraphicsContext::setPlatformShouldAntialias): (WebCore::GraphicsContext::setImageInterpolationQuality): (WebCore::GraphicsContext::imageInterpolationQuality):
- platform/graphics/openvg/PainterOpenVG.cpp: Added. (WebCore::isNonRotatedAffineTransformation): (WebCore::toVGCapStyle): (WebCore::toVGJoinStyle): (WebCore::toVGFillRule): (WebCore::colorToVGColor): (WebCore::setVGSolidColor): (WebCore::PlatformPainterState::PlatformPainterState): (WebCore::PlatformPainterState::copyPaintState): (WebCore::PlatformPainterState::applyState): (WebCore::PlatformPainterState::applyBlending): (WebCore::PlatformPainterState::applyTransformationMatrix): (WebCore::PlatformPainterState::applyScissorRect): (WebCore::PlatformPainterState::applyStrokeStyle): (WebCore::PlatformPainterState::strokeDisabled): (WebCore::PlatformPainterState::fillDisabled): (WebCore::PainterOpenVG::PainterOpenVG): (WebCore::PainterOpenVG::~PainterOpenVG): (WebCore::PainterOpenVG::begin): (WebCore::PainterOpenVG::end): (WebCore::PainterOpenVG::destroyPainterStates): (WebCore::PainterOpenVG::applyState): (WebCore::PainterOpenVG::blitToSurface): (WebCore::PainterOpenVG::transformationMatrix): (WebCore::PainterOpenVG::concatTransformationMatrix): (WebCore::PainterOpenVG::setTransformationMatrix): (WebCore::PainterOpenVG::compositeOperation): (WebCore::PainterOpenVG::setCompositeOperation): (WebCore::PainterOpenVG::opacity): (WebCore::PainterOpenVG::setOpacity): (WebCore::PainterOpenVG::strokeThickness): (WebCore::PainterOpenVG::setStrokeThickness): (WebCore::PainterOpenVG::strokeStyle): (WebCore::PainterOpenVG::setStrokeStyle): (WebCore::PainterOpenVG::setLineDash): (WebCore::PainterOpenVG::setLineCap): (WebCore::PainterOpenVG::setLineJoin): (WebCore::PainterOpenVG::setMiterLimit): (WebCore::PainterOpenVG::strokeColor): (WebCore::PainterOpenVG::setStrokeColor): (WebCore::PainterOpenVG::fillColor): (WebCore::PainterOpenVG::setFillColor): (WebCore::PainterOpenVG::antialiasingEnabled): (WebCore::PainterOpenVG::setAntialiasingEnabled): (WebCore::PainterOpenVG::scale): (WebCore::PainterOpenVG::rotate): (WebCore::PainterOpenVG::translate): (WebCore::PainterOpenVG::intersectScissorRect): (WebCore::PainterOpenVG::intersectClipRect): (WebCore::PainterOpenVG::drawRect): (WebCore::PainterOpenVG::save): (WebCore::PainterOpenVG::restore):
- platform/graphics/openvg/PainterOpenVG.h: Added. (WebCore::PainterOpenVG::): (WebCore::PainterOpenVG::surface):
- platform/graphics/openvg/SurfaceOpenVG.cpp: (WebCore::SurfaceOpenVG::SurfaceOpenVG): (WebCore::SurfaceOpenVG::~SurfaceOpenVG): (WebCore::SurfaceOpenVG::makeCurrent): (WebCore::SurfaceOpenVG::makeCompatibleCurrent): (WebCore::SurfaceOpenVG::setActivePainter): (WebCore::SurfaceOpenVG::activePainter):
- platform/graphics/openvg/SurfaceOpenVG.h: (WebCore::SurfaceOpenVG::):
- platform/graphics/openvg/VGUtils.cpp: Added. (WebCore::VGMatrix::VGMatrix): (WebCore::VGMatrix::operator TransformationMatrix): (WebCore::TransformationMatrix::operator VGMatrix): (WebCore::VGRect::VGRect): (WebCore::VGRect::operator FloatRect): (WebCore::FloatRect::operator VGRect):
- platform/graphics/openvg/VGUtils.h: (WebCore::VGMatrix::toVGfloat): (WebCore::VGRect::toVGfloat):
- platform/graphics/transforms/TransformationMatrix.h:
- 7:42 AM Changeset in webkit [54062] by
-
- 5 edits in trunk/LayoutTests
2010-01-29 Philippe Normand <pnormand@igalia.com>
Unreviewed, build fix.
http/tests/media/video-referer.html fails on mac
https://bugs.webkit.org/show_bug.cgi?id=34331
Skipping the failing test. Requires further investigation.
- platform/mac-leopard/Skipped:
- platform/mac-snowleopard/Skipped:
- platform/mac-tiger/Skipped:
- platform/mac/Skipped:
- 7:04 AM Changeset in webkit [54061] by
-
- 3 edits4 adds in trunk
2010-01-29 Philippe Normand <pnormand@igalia.com>
Reviewed by Gustavo Noronha Silva.
[Gtk] Vimeo HTML5 player doesn't work
https://bugs.webkit.org/show_bug.cgi?id=34327
Send Referer when requesting media over HTTP.
Test: http/tests/media/video-referer.html
- platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::mediaPlayerPrivateSourceChangedCallback):
2010-01-29 Philippe Normand <pnormand@igalia.com>
Reviewed by Gustavo Noronha Silva.
[Gtk] Vimeo HTML5 player doesn't work
https://bugs.webkit.org/show_bug.cgi?id=34327
Test for HTTP Referer checking when playing remote media.
- http/tests/media/resources/setCookieAndReferer.cgi: Added.
- http/tests/media/resources/video-referer-check-referer.php: Added.
- http/tests/media/video-referer-expected.txt: Added.
- http/tests/media/video-referer.html: Added.
- 6:33 AM Changeset in webkit [54060] by
-
- 3 edits in trunk/WebCore
[Qt] Speed up the WebCore::String -> QString conversion
Patch by Oswald Buddenhagen <oswald.buddenhagen@nokia.com> on 2010-01-29
Reviewed by Simon Hausmann.
Use QString(const QChar *, int len) constructor instead of QString::fromUtf16 to
avoid BOM checks and byteswapping.
- bridge/qt/qt_class.cpp:
(JSC::Bindings::QtClass::fieldNamed):
- bridge/qt/qt_runtime.cpp:
(JSC::Bindings::convertValueToQVariant):
- 6:10 AM Changeset in webkit [54059] by
-
- 3 edits in trunk/WebCore
2010-01-29 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: Source view displays text using wrong fonts
https://bugs.webkit.org/show_bug.cgi?id=34269
- inspector/front-end/TextEditor.js: (WebInspector.TextEditor): (WebInspector.TextEditor.prototype._initFont):
- inspector/front-end/inspector.js:
- 6:01 AM QtWebKitBackportingFixes edited by
- (diff)
- 6:00 AM Changeset in webkit [54058] by
-
- 2 edits in trunk/WebKitTools
2010-01-29 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Add support for Maemo zoom keys in QtLauncher
- QtLauncher/main.cpp: (LauncherWindow::LauncherWindow): (LauncherWindow::~LauncherWindow): (LauncherWindow::keyPressEvent): (LauncherWindow::grabZoomKeys):
- 5:48 AM QtWebKitBackportingFixes edited by
- (diff)
- 5:46 AM QtWebKitBackportingFixes edited by
- (diff)
- 5:41 AM Changeset in webkit [54057] by
-
- 2 edits in trunk/WebKit/chromium
2010-01-29 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Add API methods for loading inspector utility scripts.
- public/WebDevToolsAgentClient.h: (WebKit::WebDevToolsAgentClient::injectedScriptSource): (WebKit::WebDevToolsAgentClient::injectedScriptDispatcherSource):
- 5:36 AM QtWebKitBackportingFixes edited by
- (diff)
- 5:32 AM QtWebKitBackportingFixes edited by
- (diff)
- 5:29 AM Changeset in webkit [54056] by
-
- 2 edits in trunk/WebCore
2010-01-29 Philippe Normand <pnormand@igalia.com>
Reviewed by Gustavo Noronha Silva.
[Gtk] Apple trailers don't play anymore
https://bugs.webkit.org/show_bug.cgi?id=34316
Fake QuickTime when accessing movie trailers.
- platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::mediaPlayerPrivateSourceChangedCallback):
- 5:02 AM Changeset in webkit [54055] by
-
- 2 edits in trunk/LayoutTests
Unreviewed.
[Qt] Remove disabled tests from Skiplist. The tests were disabled in r53701.
- platform/qt/Skipped: -css2.1/t1204-increment-00-c-o.html -css2.1/t1204-increment-01-c-o.html -css2.1/t1204-increment-02-c-o.html -css2.1/t1204-reset-00-c-o.html -css2.1/t1204-reset-01-c-o.html -css2.1/t1204-reset-02-c-o.html
- 4:17 AM Changeset in webkit [54054] by
-
- 5 edits in trunk/WebKitTools
2010-01-29 Benjamin Poulain <benjamin.poulain@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Implement the display() method of the layout test controller
https://bugs.webkit.org/show_bug.cgi?id=34258
- DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::DumpRenderTree::DumpRenderTree): (WebCore::DumpRenderTree::showPage): (WebCore::DumpRenderTree::hidePage):
- DumpRenderTree/qt/DumpRenderTreeQt.h:
- DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::reset): (LayoutTestController::display):
- DumpRenderTree/qt/LayoutTestControllerQt.h:
- 3:04 AM Changeset in webkit [54053] by
-
- 19 edits2 adds3 deletes in trunk
2010-01-29 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: migrate to tokenizer-based highlighting in the Elements panel.
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- inspector/front-end/CSSSourceSyntaxHighlighter.js: Removed.
- inspector/front-end/DOMSyntaxHighlighter.js: Added. (WebInspector.DOMSyntaxHighlighter): (WebInspector.DOMSyntaxHighlighter.prototype.createSpan): (WebInspector.DOMSyntaxHighlighter.prototype.syntaxHighlightNode):
- inspector/front-end/ElementsTreeOutline.js:
- inspector/front-end/JavaScriptSourceSyntaxHighlighter.js: Removed.
- inspector/front-end/SourceCSSTokenizer.js: (WebInspector.SourceCSSTokenizer): (WebInspector.SourceCSSTokenizer.prototype.nextToken):
- inspector/front-end/SourceCSSTokenizer.re2js:
- inspector/front-end/SourceHTMLTokenizer.js: (WebInspector.SourceHTMLTokenizer): (WebInspector.SourceHTMLTokenizer.prototype.nextToken):
- inspector/front-end/SourceHTMLTokenizer.re2js:
- inspector/front-end/SourceJavaScriptTokenizer.js: (WebInspector.SourceJavaScriptTokenizer): (WebInspector.SourceJavaScriptTokenizer.prototype.nextToken):
- inspector/front-end/SourceJavaScriptTokenizer.re2js:
- inspector/front-end/SourceSyntaxHighlighter.js: Removed.
- inspector/front-end/SourceTokenizer.js: Added. (WebInspector.SourceTokenizer): (WebInspector.SourceTokenizer.prototype.set line): (WebInspector.SourceTokenizer.prototype.set condition): (WebInspector.SourceTokenizer.prototype.get condition): (WebInspector.SourceTokenizer.prototype.hasCondition): (WebInspector.SourceTokenizer.prototype.getLexCondition): (WebInspector.SourceTokenizer.prototype.setLexCondition): (WebInspector.SourceTokenizer.prototype._charAt): (WebInspector.SourceTokenizer.Registry): (WebInspector.SourceTokenizer.Registry.getInstance): (WebInspector.SourceTokenizer.Registry.prototype.getTokenizer):
- inspector/front-end/TextEditorHighlighter.js: (WebInspector.TextEditorHighlighter): (WebInspector.TextEditorHighlighter.prototype.set mimeType):
- inspector/front-end/WebKit.qrc:
- inspector/front-end/inspector.html: LayoutTests:
- inspector/syntax-highlight-css-expected.txt:
- inspector/syntax-highlight-css.html:
- inspector/syntax-highlight-javascript-expected.txt:
- inspector/syntax-highlight-javascript.html:
- inspector/syntax-highlight.js: (frontend_dumpSyntaxHighlight):
- 3:02 AM QtWebKitBackportingFixes edited by
- (diff)
- 2:38 AM Changeset in webkit [54052] by
-
- 8 edits in trunk/WebCore
2010-01-29 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: No need to render background sources
when performing search.
- inspector/front-end/ScriptView.js: (WebInspector.ScriptView): (WebInspector.ScriptView.prototype.show):
- inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame): (WebInspector.SourceFrame.prototype.set visible): (WebInspector.SourceFrame.prototype.set executionLine): (WebInspector.SourceFrame.prototype.revealLine): (WebInspector.SourceFrame.prototype.clearMessages): (WebInspector.SourceFrame.prototype.sizeToFitContentHeight): (WebInspector.SourceFrame.prototype.setContent): (WebInspector.SourceFrame.prototype._createEditorIfNeeded): (WebInspector.SourceFrame.prototype.setSelection): (WebInspector.SourceFrame.prototype.clearSelection): (WebInspector.SourceFrame.prototype._contextMenu.addConditionalBreakpoint): (WebInspector.SourceFrame.prototype._contextMenu): (WebInspector.SourceFrame.prototype._toggleBreakpoint): (WebInspector.SourceFrame.prototype.resize): (WebInspector.BreakpointLineNumberDecorator):
- inspector/front-end/SourceView.js: (WebInspector.SourceView): (WebInspector.SourceView.prototype.show): (WebInspector.SourceView.prototype.hide): (WebInspector.SourceView.prototype.resize):
- inspector/front-end/TextEditor.js: (WebInspector.TextEditor):
- inspector/front-end/TextEditorHighlighter.js: (WebInspector.TextEditorHighlighter):
- inspector/front-end/TextEditorModel.js: (WebInspector.TextEditorModel): (WebInspector.TextEditorModel.prototype.set changeListener): (WebInspector.TextEditorModel.prototype.setText):
- 1:41 AM Changeset in webkit [54051] by
-
- 19 edits in trunk/WebCore
2010-01-29 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Adam Barth.
Remove ScriptState::frame which is only used for reporting exceptions
in some cases in a way that diverges from the regular exception reporting in
v8 bindings.
Cache ScriptState directly on v8::Context instead of providing
implementations specific for isolated worlds and ScriptController.
- bindings/js/ScriptController.cpp:
- bindings/js/ScriptController.h:
- bindings/js/ScriptState.cpp: (WebCore::mainWorldScriptState):
- bindings/js/ScriptState.h:
- bindings/v8/ScriptCallStack.cpp: (WebCore::ScriptCallStack::ScriptCallStack):
- bindings/v8/ScriptController.cpp: (WebCore::ScriptController::evaluate): (WebCore::ScriptController::clearWindowShell):
- bindings/v8/ScriptController.h:
- bindings/v8/ScriptScope.cpp: (WebCore::ScriptScope::ScriptScope): (WebCore::ScriptScope::success):
- bindings/v8/ScriptScope.h:
- bindings/v8/ScriptState.cpp: (WebCore::ScriptState::ScriptState): (WebCore::ScriptState::forContext): (WebCore::ScriptState::current): (WebCore::ScriptState::weakReferenceCallback): (WebCore::mainWorldScriptState): (WebCore::scriptStateFromPage):
- bindings/v8/ScriptState.h: (WebCore::ScriptState::ScriptState): (WebCore::EmptyScriptState::EmptyScriptState): (WebCore::EmptyScriptState::~EmptyScriptState):
- bindings/v8/V8HiddenPropertyName.h:
- bindings/v8/V8IsolatedContext.cpp:
- bindings/v8/V8IsolatedContext.h:
- bindings/v8/V8Utilities.cpp: (WebCore::getScriptExecutionContext): (WebCore::reportException):
- bindings/v8/custom/V8NodeIteratorCustom.cpp: (WebCore::V8NodeIterator::nextNodeCallback): (WebCore::V8NodeIterator::previousNodeCallback):
- bindings/v8/custom/V8TreeWalkerCustom.cpp: (WebCore::V8TreeWalker::parentNodeCallback): (WebCore::V8TreeWalker::firstChildCallback): (WebCore::V8TreeWalker::lastChildCallback): (WebCore::V8TreeWalker::nextNodeCallback): (WebCore::V8TreeWalker::previousNodeCallback): (WebCore::V8TreeWalker::nextSiblingCallback): (WebCore::V8TreeWalker::previousSiblingCallback):
- inspector/InspectorController.cpp: (WebCore::InspectorController::injectedScriptForNodeId):
- 1:23 AM Changeset in webkit [54050] by
-
- 2 edits in trunk/JavaScriptCore
Rubber-stamped by Maciej Stachowiak.
Fix the ARM build.
- runtime/JSNumberCell.h:
(JSC::JSNumberCell::createStructure): Call the right Structure::create overload.
- 12:43 AM Changeset in webkit [54049] by
-
- 13 edits in trunk
2010-01-29 Darin Fisher <darin@chromium.org>
Reviewed by Adam Barth.
Add FrameLoaderClient::allowImages method to allow the client to
overrule image loading policy on a per frame basis.
For completeness, this patch also adds Settings::areImagesEnabled.
This is different from loadsImagesAutomatically as is explained in
Settings.h.
- loader/DocLoader.cpp: (WebCore::DocLoader::requestImage):
- loader/FrameLoaderClient.h: (WebCore::FrameLoaderClient::allowImages):
- loader/ImageDocument.cpp: (WebCore::ImageTokenizer::writeRawData):
- page/Settings.cpp: (WebCore::Settings::Settings): (WebCore::Settings::setImagesEnabled):
- page/Settings.h: (WebCore::Settings::areImagesEnabled):
Jan 28, 2010:
- 11:42 PM Changeset in webkit [54048] by
-
- 3 edits in trunk/WebCore
2010-01-28 Nicholas Young <nicholas.young@nokia.com>
Reviewed by Eric Carlson.
Prefer provided video element width/height properties to hard coded
defaults for intrinsic size when natural video size is unavailable.
https://bugs.webkit.org/show_bug.cgi?id=34302
No new tests needed.
- rendering/RenderVideo.cpp: Attempt to use width/height properties (WebCore::RenderVideo::RenderVideo):
- rendering/RenderVideo.h: More appropriate constructor signature
- 11:16 PM Changeset in webkit [54047] by
-
- 5 edits in trunk
2010-01-28 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
MessageEvent.data should not be repeated deserialised
https://bugs.webkit.org/show_bug.cgi?id=34311
Add test to ensure we get the same value back when accessing event.data multiple times
- fast/dom/Window/window-postmessage-clone.html:
2010-01-28 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
MessageEvent.data should not be repeated deserialised
https://bugs.webkit.org/show_bug.cgi?id=34311
Cache the result of deserialising the event data
- bindings/scripts/CodeGeneratorJS.pm:
- dom/MessageEvent.idl:
- 11:15 PM Changeset in webkit [54046] by
-
- 3 edits in trunk/WebKit/chromium
2010-01-28 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Darin Fisher.
StorageNamespaceProxy::copy() should be a no-op
https://bugs.webkit.org/show_bug.cgi?id=34298
The comment in the code should make clear why.
- public/WebViewClient.h:
- src/StorageNamespaceProxy.cpp: (WebCore::StorageNamespaceProxy::copy):
- 11:01 PM Changeset in webkit [54045] by
-
- 5 edits3 adds in trunk
2010-01-28 Hayato Ito <hayato@chromium.org>
Reviewed by Darin Adler.
Change CSS 'page-break-inside' property from inherited one to non-inherited one because CSS specification defines so.
Note: Currently, the 'page-break-inside' property is used only when parsing the CSS. That property is not used when rendering.
- fast/css/getComputedStyle/computed-style-page-break-inside-expected.txt: Added.
- fast/css/getComputedStyle/computed-style-page-break-inside.html: Added.
- fast/css/getComputedStyle/script-tests/computed-style-page-break-inside.js: Added.
2010-01-28 Hayato Ito <hayato@chromium.org>
Reviewed by Darin Adler.
Change CSS 'page-break-inside' property from inherited one to non-inherited one because CSS specification defines so.
Note: Currently, the 'page-break-inside' property is used only when parsing the CSS. That property is not used when rendering.
- rendering/style/RenderStyle.h: (WebCore::InheritedFlags::NonInheritedFlags::operator==): (WebCore::InheritedFlags::setBitDefaults): (WebCore::InheritedFlags::pageBreakInside): (WebCore::InheritedFlags::setPageBreakInside):
- rendering/style/StyleInheritedData.cpp: (WebCore::StyleInheritedData::StyleInheritedData): (WebCore::StyleInheritedData::operator==):
- rendering/style/StyleInheritedData.h:
- 10:41 PM Changeset in webkit [54044] by
-
- 7 edits4 adds in trunk
2010-01-28 Michael Nordman <Michael Nordman>
Reviewed by Alexey Proskuryakov.
ApplicationCache events should be deferred until after Document onload has fired.
https://bugs.webkit.org/show_bug.cgi?id=29690
- http/tests/appcache/deferred-events-expected.txt: Added.
- http/tests/appcache/deferred-events.html: Added.
- http/tests/appcache/deferred-events-delete-while-raising-expected.txt: Added.
- http/tests/appcache/deferred-events-delete-while-raising.html: Added.
2010-01-28 Michael Nordman <Michael Nordman>
Reviewed by Alexey Proskuryakov.
ApplicationCache events should be deferred until after Document onload has fired.
https://bugs.webkit.org/show_bug.cgi?id=29690
Test: http/tests/appcache/deferred-events.html
- loader/FrameLoader.cpp: (WebCore::FrameLoader::handledOnloadEvents): Tells the ApplicationCacheHost to stop deferring events.
- loader/appcache/ApplicationCacheHost.cpp: (WebCore::ApplicationCacheHost::ApplicationCacheHost): Initialize m_isDeferringEvents to true. (WebCore::ApplicationCacheHost::notifyDOMApplicationCache): Depending, defer or raise the event. (WebCore::ApplicationCacheHost::stopDeferringEvents): Raise any deferred events and reset the flag.
- loader/appcache/ApplicationCacheHost.h: Declare new data members and method.
2010-01-28 Michael Nordman <Michael Nordman>
Reviewed by Alexey Proskuryakov.
ApplicationCache events should be deferred until after Document onload has fired.
https://bugs.webkit.org/show_bug.cgi?id=29690
- src/ApplicationCacheHost.cpp: (WebCore::ApplicationCacheHost::ApplicationCacheHost): Initialize m_isDeferringEvents to true. (WebCore::ApplicationCacheHost::notifyDOMApplicationCache): Depending, defer or raise the event. (WebCore::ApplicationCacheHost::stopDeferringEvents): Raise any deferred events and reset the flag.
- 10:11 PM Changeset in webkit [54043] by
-
- 5 edits in trunk
[wx] Build fix for MSW, use ThreadingWin.cpp as the Windows pthreads implementation
implements pthread_t in a way that makes it impossible to check its validity,
which is needed by ThreadingPthreads.cpp.
- 8:49 PM Changeset in webkit [54042] by
-
- 41 edits3 deletes in trunk/WebCore
2010-01-28 Kavita Kanetkar <kkanetkar@chromium.org>
Reviewed by Dimitri Glazkov.
[V8] Generate header declaration for custom constructor callbacks
https://bugs.webkit.org/show_bug.cgi?id=33680
Added handling of 'CanBeConstructed' and 'OmitConstructor' and a new extended attribute
CustomConstructor'.
Deleted implementation .cpp files for corresponding 'CanBeConstructed'
extended attributes. These are now generated via CodeGeneratorV8.pm
Treating 'OmitConstructor' and 'CustomConstructor' to be the same in
CodeGeneratorJS.pm
Cleaned idls that had 'CustomConstructor' and 'OmitConstructor' together, and
same with CustomConstructor and CanBeConstructed.
- Android.v8bindings.mk:
- WebCore.gypi: Removed deps for classes being generated.
- bindings/scripts/CodeGeneratorJS.pm: OmitConstructor and CustomConstructor have the same behavior in generator.
- bindings/scripts/CodeGeneratorV8.pm: Generating the callbacks for constructors.
- bindings/v8/V8DOMWrapper.cpp: Removed manual calls to SetCallHandler() for constructor callbacks. (WebCore::V8DOMWrapper::getTemplate):
- bindings/v8/custom/V8CustomBinding.h: Removed manual declarations of constructor callbacks.
- bindings/v8/custom/V8DOMParserConstructor.cpp:
- bindings/v8/custom/V8EventSourceConstructor.cpp: (WebCore::V8EventSource::constructorCallback):
- bindings/v8/custom/V8MessageChannelConstructor.cpp: (WebCore::V8MessageChannel::constructorCallback):
- bindings/v8/custom/V8SharedWorkerCustom.cpp: (WebCore::V8SharedWorker::constructorCallback):
- bindings/v8/custom/V8WebGLArrayBufferCustom.cpp: (WebCore::V8WebGLArrayBuffer::constructorCallback):
- bindings/v8/custom/V8WebGLByteArrayCustom.cpp: (WebCore::V8WebGLByteArray::constructorCallback):
- bindings/v8/custom/V8WebGLFloatArrayCustom.cpp: (WebCore::V8WebGLFloatArray::constructorCallback):
- bindings/v8/custom/V8WebGLIntArrayCustom.cpp: (WebCore::V8WebGLIntArray::constructorCallback):
- bindings/v8/custom/V8WebGLShortArrayCustom.cpp: (WebCore::V8WebGLShortArray::constructorCallback):
- bindings/v8/custom/V8WebGLUnsignedByteArrayCustom.cpp: (WebCore::V8WebGLUnsignedByteArray::constructorCallback):
- bindings/v8/custom/V8WebGLUnsignedIntArrayCustom.cpp: (WebCore::V8WebGLUnsignedIntArray::constructorCallback):
- bindings/v8/custom/V8WebGLUnsignedShortArrayCustom.cpp: (WebCore::V8WebGLUnsignedShortArray::constructorCallback):
- bindings/v8/custom/V8WebKitCSSMatrixConstructor.cpp: (WebCore::V8WebKitCSSMatrix::constructorCallback):
- bindings/v8/custom/V8WebKitPointConstructor.cpp: (WebCore::V8WebKitPoint::constructorCallback):
- bindings/v8/custom/V8WebSocketCustom.cpp: (WebCore::V8WebSocket::constructorCallback):
- bindings/v8/custom/V8WorkerCustom.cpp: (WebCore::V8Worker::constructorCallback):
- bindings/v8/custom/V8XMLHttpRequestConstructor.cpp: (WebCore::V8XMLHttpRequest::constructorCallback):
- bindings/v8/custom/V8XMLSerializerConstructor.cpp:
- bindings/v8/custom/V8XPathEvaluatorConstructor.cpp: Deleted the file. Implementation now being generated.
- bindings/v8/custom/V8XSLTProcessorCustom.cpp: Deleted the file. Implementation now being generated. (WebCore::V8XSLTProcessor::constructorCallback): Deleted the file. Implementation now being generated.
- css/WebKitCSSMatrix.idl: Added CustomConstructor attribute.
- dom/MessageChannel.idl: Added CustomConstructor attribute.
- html/canvas/WebGLArrayBuffer.idl: Added CustomConstructor attribute.
- html/canvas/WebGLByteArray.idl: Added CustomConstructor attribute.
- html/canvas/WebGLFloatArray.idl: Added CustomConstructor attribute.
- html/canvas/WebGLIntArray.idl: Added CustomConstructor attribute.
- html/canvas/WebGLShortArray.idl: Added CustomConstructor attribute.
- html/canvas/WebGLUnsignedByteArray.idl: Added CustomConstructor attribute.
- html/canvas/WebGLUnsignedIntArray.idl: Added CustomConstructor attribute.
- 8:27 PM Changeset in webkit [54041] by
-
- 3 edits in trunk/WebCore
2010-01-28 Steve Block <steveblock@google.com>
Reviewed by David Levin.
Add stub for AXObjectCache::contentChanged when HAVE(ACCESSIBILITY) is not defined
https://bugs.webkit.org/show_bug.cgi?id=34271
No new tests, build fix only.
- accessibility/AXObjectCache.cpp: Modified. Added HAVE(ACCESSIBILITY) guards around contentChanged
- accessibility/AXObjectCache.h: Modified. (WebCore::AXObjectCache::contentChanged): Added stub
- 8:00 PM Changeset in webkit [54040] by
-
- 4 edits in trunk
2010-01-28 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
DOM Objects shouldn't all require custom mark functions
https://bugs.webkit.org/show_bug.cgi?id=34291
Make getAnonymousValue const-friendly
- runtime/JSObject.h: (JSC::JSObject::getAnonymousValue):
2010-01-28 Steve Block <steveblock@google.com>
Reviewed by David Levin.
Use long long rather than int64 in V8Binding.h
https://bugs.webkit.org/show_bug.cgi?id=34270
No new tests, build fix only.
- bindings/v8/V8Binding.h: Modified. (WebCore::toInt64): Returns long long
- 7:47 PM WebKit Team edited by
- (diff)
- 7:40 PM Changeset in webkit [54039] by
-
- 2 edits in trunk/WebKitTools
Adding myself to the committer list. No review needed.
- Scripts/webkitpy/committers.py:
- 6:57 PM Changeset in webkit [54038] by
-
- 2 edits in trunk/WebCore
2010-01-28 Steve Block <steveblock@google.com>
Reviewed by David Levin.
Use long long rather than int64 in V8Binding.h
https://bugs.webkit.org/show_bug.cgi?id=34270
No new tests, build fix only.
- bindings/v8/V8Binding.h: Modified. (WebCore::toInt64): Returns long long
- 6:41 PM Changeset in webkit [54037] by
-
- 2 edits in trunk/WebCore
2010-01-28 Avi Drissman <avi@chromium.org>
Reviewed by David Levin.
Unused variable in ThemeMac (followup to change 49103).
https://bugs.webkit.org/show_bug.cgi?id=34274
Covered by existing tests.
- platform/mac/ThemeMac.mm: (WebCore::setupButtonCell):
- 6:10 PM Changeset in webkit [54036] by
-
- 6 edits in trunk
Huge plain text pastes are slow
<rdar://problem/5195056>
https://bugs.webkit.org/show_bug.cgi?id=34237
Reviewed by Maciej Stachowiak.
WebCore:
No new tests. It is a performance improvement.
The performance of the plain text paste is now linear.
We treat as a special case, a fragment that has been
created from plain text. Finding VisiblePositions and
applying style is greatly simplified, given the nature of
the fragment.
- editing/ReplaceSelectionCommand.cpp:
(WebCore::ReplaceSelectionCommand::doApply):
- editing/markup.cpp:
(WebCore::isPlainTextMarkup):
- editing/markup.h:
WebKit/mac:
Mail is ignoring the fragment created from plain text or HTML that is
passed to the delegate function, that creates a new one.
This fix avoids creating the fragment twice.
- WebView/WebHTMLView.mm:
(-[WebHTMLView _pasteWithPasteboard:allowPlainText:]):
- 5:57 PM Changeset in webkit [54035] by
-
- 2 edits in trunk/WebCore
Initialize DOM Storage's quota's current length parameter when we clone it.
https://bugs.webkit.org/show_bug.cgi?id=34294
Patch by Jeremy Orlow <jorlow@chromium.org> on 2010-01-28
Reviewed by Adam Barth.
- storage/StorageMap.cpp:
(WebCore::StorageMap::copy):
- 5:49 PM Changeset in webkit [54034] by
-
- 2 edits in trunk/WebKit/qt
2010-01-28 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Support kinetic scrolling on Maemo 5
Patch by Ralf Engels <ralf.engels@nokia.com> and
Robert Griebl <rgriebl@trolltech.com>
- Api/qwebview.cpp: (QWebViewKineticScroller::QWebViewKineticScroller): (QWebViewKineticScroller::eventFilter): (QWebViewKineticScroller::currentFrame): (QWebViewKineticScroller::scrollingFrameAt): (QWebViewKineticScroller::attachToWidget): (QWebViewKineticScroller::removeFromWidget): (QWebViewKineticScroller::positionRange): (QWebViewKineticScroller::position): (QWebViewKineticScroller::viewportSize): (QWebViewKineticScroller::setPosition): (QWebView::QWebView):
- 5:32 PM Changeset in webkit [54033] by
-
- 2 edits in trunk/WebKitTools
2010-01-28 Hayato Ito <hayato@chromium.org>
Reviewed by David Levin.
Remove NULL char from input JS file because 'grep' fails if the file contains NULL char.
- Scripts/make-script-test-wrappers:
- 5:28 PM Changeset in webkit [54032] by
-
- 2 edits in trunk/WebCore
Unreviewed build fix after r53411 on WinCairo.
- platform/image-decoders/gif/GIFImageDecoder.cpp:
(WebCore::GIFImageDecoder::frameCount):
- 5:21 PM Changeset in webkit [54031] by
-
- 4 edits in branches/safari-4-branch
Versioning.
- 5:15 PM Changeset in webkit [54030] by
-
- 2 edits in trunk/WebCore
2010-01-28 Nayan Kumar K <nayankk@gmail.com>
Reviewed by Laszlo Gombos.
Fix for compilation error in WML enabled build introduced because of the changeset 53514.
- wml/WMLDocument.cpp: (WebCore::WMLDocument::WMLDocument):
- 4:57 PM Changeset in webkit [54029] by
-
- 8 edits in trunk
2010-01-28 Alex Milowski <alex@milowski.com>
Reviewed by Eric Seidel.
Updates from CSS change for mathml.css
- platform/mac/mathml/presentation/sub-expected.txt:
- platform/mac/mathml/presentation/sup-expected.txt:
- platform/mac/mathml/presentation/tables-expected.checksum:
- platform/mac/mathml/presentation/tables-expected.png:
- platform/mac/mathml/presentation/tables-expected.txt:
2010-01-28 Alex Milowski <alex@milowski.com>
Reviewed by Eric Seidel.
Update to CSS to remove unnecessary line-height settings
- css/mathml.css:
- 4:31 PM Changeset in webkit [54028] by
-
- 4 edits in trunk/WebCore
Add missing includes for HashMap/HashSet
https://bugs.webkit.org/show_bug.cgi?id=34276
Reviewed by David Levin.
No new tests, build fix only.
- platform/KURL.cpp: Modified. Include HashMap.h
- platform/network/CredentialStorage.cpp: Modified. Include HashMap.h and HashSet.h
- platform/network/ProtectionSpaceHash.h: Modified. Include HashTraits.h
- 4:20 PM Changeset in webkit [54027] by
-
- 1 edit in trunk/LayoutTests/http/tests/media/resources/setCookie.cgi
Add missing svn:executable property on LayoutTests/http/tests/media/resources/setCookie.cgi
- 3:56 PM Changeset in webkit [54026] by
-
- 5 edits4 adds in trunk
2010-01-28 Sebastian Dröge <sebastian.droege@collabora.co.uk>
Reviewed by Gustavo Noronha.
Pass cookies to the GStreamer HTTP source
https://bugs.webkit.org/show_bug.cgi?id=34003
Test: http/tests/media/video-cookie.html
- platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::mediaPlayerPrivateSourceChangedCallback): When using an appropiate GStreamer HTTP source element, pass the cookies for the media URI to it. This fixes playback of the YouTube HTML5 videos.
- 3:50 PM Changeset in webkit [54025] by
-
- 4 edits in trunk/WebCore
[Qt] Unreviewed buildfix after r54022.
- bridge/qt/qt_instance.cpp:
(JSC::Bindings::QtRuntimeObjectImp::createStructure):
- bridge/qt/qt_pixmapruntime.cpp:
(JSC::Bindings::QtPixmapRuntimeObjectImp::createStructure):
- bridge/qt/qt_runtime.h:
(JSC::Bindings::QtRuntimeMethod::createStructure):
- 3:19 PM Changeset in webkit [54024] by
-
- 2 edits in trunk/LayoutTests
[Qt] Incorrect small caps vs. normal text handling
https://bugs.webkit.org/show_bug.cgi?id=34286
- platform/qt/Skipped: css2.1/t1505-c524-font-var-00-b.html skipped
- 3:03 PM Changeset in webkit [54023] by
-
- 2 edits in trunk/WebCore
Fix an assertion beneath SerializedScriptValue::deserialize on 32-bit builds (e.g., on Windows)
Passing a JSValue to toRef on 32-bit builds can perform an allocation,
so we need to make sure we hold a JSLock when that occurs.
Reviewed by Oliver Hunt.
- bindings/js/SerializedScriptValue.cpp:
(WebCore::SerializedScriptValueData::serialize):
(WebCore::SerializedScriptValueData::deserialize):
Moved JSLocks from here...
(WebCore::SerializedScriptValue::create):
(WebCore::SerializedScriptValue::deserialize):
...to this higher level, from which toRef can be called.
- 2:51 PM Changeset in webkit [54022] by
-
- 49 edits in trunk
2010-01-28 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
Simplify anonymous slot implementation
https://bugs.webkit.org/show_bug.cgi?id=34282
A class must now specify the number of slots it needs at construction time
rather than later on with a transition. This makes many things simpler,
we no longer need to need an additional transition on object creation to
add the anonymous slots, and we remove the need for a number of transition
type checks.
- API/JSCallbackConstructor.h: (JSC::JSCallbackConstructor::createStructure):
- API/JSCallbackFunction.h: (JSC::JSCallbackFunction::createStructure):
- API/JSCallbackObject.h: (JSC::JSCallbackObject::createStructure):
- JavaScriptCore.exp:
- debugger/DebuggerActivation.h: (JSC::DebuggerActivation::createStructure):
- runtime/Arguments.h: (JSC::Arguments::createStructure):
- runtime/BooleanObject.h: (JSC::BooleanObject::createStructure):
- runtime/DateInstance.h: (JSC::DateInstance::createStructure):
- runtime/DatePrototype.h: (JSC::DatePrototype::createStructure):
- runtime/FunctionPrototype.h: (JSC::FunctionPrototype::createStructure):
- runtime/GetterSetter.h: (JSC::GetterSetter::createStructure):
- runtime/GlobalEvalFunction.h: (JSC::GlobalEvalFunction::createStructure):
- runtime/InternalFunction.h: (JSC::InternalFunction::createStructure):
- runtime/JSAPIValueWrapper.h: (JSC::JSAPIValueWrapper::createStructure):
- runtime/JSActivation.h: (JSC::JSActivation::createStructure):
- runtime/JSArray.h: (JSC::JSArray::createStructure):
- runtime/JSByteArray.cpp: (JSC::JSByteArray::createStructure):
- runtime/JSCell.h: (JSC::JSCell::createDummyStructure):
- runtime/JSFunction.h: (JSC::JSFunction::createStructure):
- runtime/JSGlobalObject.h: (JSC::JSGlobalObject::createStructure):
- runtime/JSNotAnObject.h: (JSC::JSNotAnObject::createStructure):
- runtime/JSONObject.h: (JSC::JSONObject::createStructure):
- runtime/JSObject.h: (JSC::JSObject::createStructure): (JSC::JSObject::putAnonymousValue): (JSC::JSObject::getAnonymousValue):
- runtime/JSPropertyNameIterator.h: (JSC::JSPropertyNameIterator::createStructure):
- runtime/JSStaticScopeObject.h: (JSC::JSStaticScopeObject::createStructure):
- runtime/JSString.h: (JSC::Fiber::createStructure):
- runtime/JSVariableObject.h: (JSC::JSVariableObject::createStructure):
- runtime/JSWrapperObject.h: (JSC::JSWrapperObject::createStructure): (JSC::JSWrapperObject::JSWrapperObject):
- runtime/MathObject.h: (JSC::MathObject::createStructure):
- runtime/NumberConstructor.h: (JSC::NumberConstructor::createStructure):
- runtime/NumberObject.h: (JSC::NumberObject::createStructure):
- runtime/RegExpConstructor.h: (JSC::RegExpConstructor::createStructure):
- runtime/RegExpObject.h: (JSC::RegExpObject::createStructure):
- runtime/StringObject.h: (JSC::StringObject::createStructure):
- runtime/StringObjectThatMasqueradesAsUndefined.h: (JSC::StringObjectThatMasqueradesAsUndefined::createStructure):
- runtime/Structure.cpp: (JSC::Structure::~Structure): (JSC::Structure::materializePropertyMap):
- runtime/Structure.h: (JSC::Structure::create): (JSC::Structure::anonymousSlotCount):
- runtime/StructureTransitionTable.h:
2010-01-28 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
Simplify anonymous slot implementation
https://bugs.webkit.org/show_bug.cgi?id=34282
Update JSGlue Structure usage to pass the anonymous slot count.
- UserObjectImp.h: (UserObjectImp::createStructure):
2010-01-28 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
Simplify anonymous slot implementation
https://bugs.webkit.org/show_bug.cgi?id=34282
Update the WebCore JS DOM bindings to correctly pass and
propagate the anonymous slot count information.
- bindings/js/JSDOMBinding.h: (WebCore::DOMObjectWithGlobalPointer::createStructure): (WebCore::DOMConstructorObject::createStructure):
- bindings/js/JSDOMWindowShell.h: (WebCore::JSDOMWindowShell::createStructure):
- bindings/scripts/CodeGeneratorJS.pm:
- bridge/objc/objc_runtime.h: (JSC::Bindings::ObjcFallbackObjectImp::createStructure):
- bridge/runtime_array.h: (JSC::RuntimeArray::createStructure):
- bridge/runtime_method.h: (JSC::RuntimeMethod::createStructure):
- bridge/runtime_object.h: (JSC::RuntimeObjectImp::createStructure):
- 2:37 PM QtWebKitBackportingFixes edited by
- (diff)
- 2:26 PM Changeset in webkit [54021] by
-
- 2 edits in trunk/WebKitTools
[wx] Build fix after removal of the zlib image decoder.
- 2:17 PM Changeset in webkit [54020] by
-
- 4 edits4 adds in trunk
2010-01-27 Evan Martin <evan@chromium.org>
Reviewed by David Levin.
[chromium] hebrew vowel marks incorrectly positioned
https://bugs.webkit.org/show_bug.cgi?id=34234
Add a layout test containing some Hebrew vowels.
- fast/text/international/hebrew-vowels.html: Added.
2010-01-27 Evan Martin <evan@chromium.org>
Reviewed by David Levin.
[chromium] hebrew vowel marks incorrectly positioned
https://bugs.webkit.org/show_bug.cgi?id=34234
Fix glyph metrics computation such that the glyph offsets
are correct, so we can now make use of them.
Test: fast/text/international/hebrew-vowels.html
- platform/graphics/chromium/FontLinux.cpp: (WebCore::TextRunWalker::createGlyphArrays): initialize per-glyph offset table. (WebCore::TextRunWalker::setGlyphXPositions): use per-glyph offsets.
- platform/graphics/chromium/HarfbuzzSkia.cpp: (WebCore::getGlyphMetrics): fix metrics computation such that per-glyph offsets are computed correctly.
- 2:08 PM Changeset in webkit [54019] by
-
- 2 edits in trunk/WebCore
2010-01-28 Laszlo Gombos <Laszlo Gombos>
Unreviewed build fix.
[Qt] Build fix if websockets support is turned off after r53947.
- WebCore.pro:
- 1:47 PM Changeset in webkit [54018] by
-
- 4 edits in branches/safari-4-branch
Versioning.
- 1:46 PM Changeset in webkit [54017] by
-
- 1 copy in tags/Safari-6531.22.2
New tag.
- 1:44 PM Changeset in webkit [54016] by
-
- 19 edits in trunk/WebCore
2010-01-28 Dimitri Glazkov <Dimitri Glazkov>
No review, rolling out r54012.
http://trac.webkit.org/changeset/54012
https://bugs.webkit.org/show_bug.cgi?id=34266
Introduced 33 crashes in V8 traversal/ tests.
- bindings/js/ScriptController.cpp: (WebCore::ScriptController::mainWorldScriptState):
- bindings/js/ScriptController.h:
- bindings/js/ScriptState.cpp:
- bindings/js/ScriptState.h:
- bindings/v8/ScriptCallStack.cpp: (WebCore::ScriptCallStack::ScriptCallStack):
- bindings/v8/ScriptController.cpp: (WebCore::ScriptController::mainWorldScriptState): (WebCore::ScriptController::currentScriptState): (WebCore::ScriptController::clearWindowShell):
- bindings/v8/ScriptController.h:
- bindings/v8/ScriptScope.cpp: (WebCore::ScriptScope::ScriptScope): (WebCore::ScriptScope::success):
- bindings/v8/ScriptScope.h:
- bindings/v8/ScriptState.cpp: (WebCore::ScriptState::ScriptState): (WebCore::scriptStateFromPage):
- bindings/v8/ScriptState.h: (WebCore::ScriptState::ScriptState): (WebCore::ScriptState::frame):
- bindings/v8/V8HiddenPropertyName.h:
- bindings/v8/V8IsolatedContext.cpp: (WebCore::V8IsolatedContext::scriptState):
- bindings/v8/V8IsolatedContext.h:
- bindings/v8/V8Utilities.cpp: (WebCore::getScriptExecutionContext): (WebCore::reportException):
- bindings/v8/custom/V8NodeIteratorCustom.cpp: (WebCore::V8NodeIterator::nextNodeCallback): (WebCore::V8NodeIterator::previousNodeCallback):
- bindings/v8/custom/V8TreeWalkerCustom.cpp: (WebCore::V8TreeWalker::parentNodeCallback): (WebCore::V8TreeWalker::firstChildCallback): (WebCore::V8TreeWalker::lastChildCallback): (WebCore::V8TreeWalker::nextNodeCallback): (WebCore::V8TreeWalker::previousNodeCallback): (WebCore::V8TreeWalker::nextSiblingCallback): (WebCore::V8TreeWalker::previousSiblingCallback):
- inspector/InspectorController.cpp: (WebCore::InspectorController::injectedScriptForNodeId):
- 1:36 PM Changeset in webkit [54015] by
-
- 12 edits in trunk
Reapply 54008: Expand the NotificationPresenter::checkPermission() interface
to send the full URL of the requesting context, as well as a pointer to the
document if that context was a document.
- 1:34 PM Changeset in webkit [54014] by
-
- 4 edits in trunk/WebCore
2010-01-28 Steve Block <steveblock@google.com>
Reviewed by Adam Barth.
Fix missing forward-declarations and includes in V8 bindings
https://bugs.webkit.org/show_bug.cgi?id=34272
No new tests, build fix only.
- bindings/v8/ScriptController.h: Modified. Forward-declare NPObject
- bindings/v8/V8DOMWindowShell.cpp: Modified. Include CString.h and PlatformBridge.h
- bindings/v8/V8DOMWrapper.h: Modified. Forward-declare V8Proxy
- 1:24 PM Changeset in webkit [54013] by
-
- 3 edits in trunk/LayoutTests
2010-01-28 Dimitri Glazkov <Dimitri Glazkov>
Unreviewed, trivial baseline update.
Update baseline for "Animated scaling of background-image is too slow"
https://bugs.webkit.org/show_bug.cgi?id=33808
- platform/mac/fast/backgrounds/size/backgroundSize16-expected.checksum:
- platform/mac/fast/backgrounds/size/backgroundSize16-expected.png:
- 1:05 PM Changeset in webkit [54012] by
-
- 19 edits in trunk/WebCore
2010-01-28 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Adam Barth.
Remove ScriptState::frame which is only used for reporting exceptions
in some cases in a way that diverges from the regular exception reporting in
v8 bindings.
Cache ScriptState directly on v8::Context instead of providing
implementations specific for isolated worlds and ScriptController.
- bindings/js/ScriptController.cpp:
- bindings/js/ScriptController.h:
- bindings/js/ScriptState.cpp: (WebCore::mainWorldScriptState):
- bindings/js/ScriptState.h:
- bindings/v8/ScriptCallStack.cpp: (WebCore::ScriptCallStack::ScriptCallStack):
- bindings/v8/ScriptController.cpp: (WebCore::ScriptController::clearWindowShell):
- bindings/v8/ScriptController.h:
- bindings/v8/ScriptScope.cpp: (WebCore::ScriptScope::ScriptScope): (WebCore::ScriptScope::success):
- bindings/v8/ScriptScope.h:
- bindings/v8/ScriptState.cpp: (WebCore::ScriptState::ScriptState): (WebCore::ScriptState::forContext): (WebCore::ScriptState::current): (WebCore::ScriptState::empty): (WebCore::ScriptState::weakReferenceCallback): (WebCore::mainWorldScriptState): (WebCore::scriptStateFromPage):
- bindings/v8/ScriptState.h:
- bindings/v8/V8HiddenPropertyName.h:
- bindings/v8/V8IsolatedContext.cpp:
- bindings/v8/V8IsolatedContext.h:
- bindings/v8/V8Utilities.cpp: (WebCore::getScriptExecutionContext): (WebCore::reportException):
- bindings/v8/custom/V8NodeIteratorCustom.cpp: (WebCore::V8NodeIterator::nextNodeCallback): (WebCore::V8NodeIterator::previousNodeCallback):
- bindings/v8/custom/V8TreeWalkerCustom.cpp: (WebCore::V8TreeWalker::parentNodeCallback): (WebCore::V8TreeWalker::firstChildCallback): (WebCore::V8TreeWalker::lastChildCallback): (WebCore::V8TreeWalker::nextNodeCallback): (WebCore::V8TreeWalker::previousNodeCallback): (WebCore::V8TreeWalker::nextSiblingCallback): (WebCore::V8TreeWalker::previousSiblingCallback):
- inspector/InspectorController.cpp: (WebCore::InspectorController::injectedScriptForNodeId):
- 12:38 PM Changeset in webkit [54011] by
-
- 12 edits in trunk
revert
- 12:34 PM Changeset in webkit [54010] by
-
- 3 edits3 adds in trunk
2010-01-28 Adam Barth <abarth@webkit.org>
Reviewed by David Levin.
Remove XSSAuditor false positive for Google Translate
https://bugs.webkit.org/show_bug.cgi?id=34242
Add a test that we allow attackers to inject directly into the href
property of the base tag.
- http/tests/security/xssAuditor/base-href-direct-expected.txt: Added.
- http/tests/security/xssAuditor/base-href-direct.html: Added.
- http/tests/security/xssAuditor/resources/echo-head-base-href-direct.pl: Added.
2010-01-28 Adam Barth <abarth@webkit.org>
Reviewed by David Levin.
Remove XSSAuditor false positive for Google Translate
https://bugs.webkit.org/show_bug.cgi?id=34242
Google translate takes a base URL as a parameter, causing a false
positive in the XSS filter. This patch removes the false positive by
allowing direct injections into the href property of the base tag.
Test: http/tests/security/xssAuditor/base-href-direct.html
- page/XSSAuditor.cpp: (WebCore::XSSAuditor::canSetBaseElementURL):
- 12:27 PM Changeset in webkit [54009] by
-
- 17 edits1 add in trunk/WebCore
2010-01-28 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Dirk Schulze.
Save additional memory in SVG*Element classes, by introducing SVGElementRareData
https://bugs.webkit.org/show_bug.cgi?id=34268
Introduce SVGElementRareData, to remove the need to store any members in SVGElement/SVGStyledElement.
This saves some additional MB for the svg-node-count-vs-scroll.xhtml testcase.
SVGElementRareData works just like NodeRareData. Unlike ElementRareData, we're not inheriting from
NodeRareData in SVG, as we don't need all the rare data stored there, unlike Element.
- GNUmakefile.am: Add SVGElementRareData.h to build.
- WebCore.gypi: Ditto.
- WebCore.pro: Ditto.
- WebCore.vcproj/WebCore.vcproj: Ditto.
- WebCore.xcodeproj/project.pbxproj: Ditto.
- dom/Node.cpp: Use Nodes bitfield to keep track wheter a SVGElement has a SVGElementRareData object associated. (WebCore::Node::Node):
- dom/Node.h: Add m_hasRareSVGData flag, merged with the existing bitfield, 10 bits remaining now. (WebCore::Node::hasRareSVGData):
- svg/SVGAnimateMotionElement.cpp: SVGElement::instancesForElement() now returns a const-reference to the HashMap instead of copying. (WebCore::SVGAnimateMotionElement::applyResultsToTarget):
- svg/SVGAnimateTransformElement.cpp: Ditto. (WebCore::SVGAnimateTransformElement::applyResultsToTarget):
- svg/SVGAnimationElement.cpp: Ditto. (WebCore::SVGAnimationElement::setTargetAttributeAnimatedValue):
- svg/SVGElement.cpp: Move the element instances HashSet and two cursor-related pointers into SVGElementRareData. (WebCore::SVGElement::SVGElement): (WebCore::SVGElement::~SVGElement): (WebCore::SVGElement::rareSVGData): Modelled just like Node::rareData(). (WebCore::SVGElement::ensureRareSVGData): Dito. (WebCore::SVGElement::accessDocumentSVGExtensions): (WebCore::SVGElement::mapInstanceToElement): Route call through SVGElementRareData. (WebCore::SVGElement::removeInstanceMapping): Ditto. (WebCore::SVGElement::instancesForElement): Ditto. (WebCore::SVGElement::setCursorElement): Ditto. (WebCore::SVGElement::setCursorImageValue): Ditto.
- svg/SVGElement.h:
- svg/SVGElementInstance.cpp: Ditto. (WebCore::SVGElementInstance::invalidateAllInstancesOfElement):
- svg/SVGElementRareData.h: Added. Based on NodeRareData - works exactly the same. (WebCore::SVGElementRareData::SVGElementRareData): (WebCore::SVGElementRareData::rareDataMap): (WebCore::SVGElementRareData::rareDataFromMap): (WebCore::SVGElementRareData::elementInstances): (WebCore::SVGElementRareData::instanceUpdatesBlocked): (WebCore::SVGElementRareData::setInstanceUpdatesBlocked): (WebCore::SVGElementRareData::cursorElement): (WebCore::SVGElementRareData::setCursorElement): (WebCore::SVGElementRareData::cursorImageValue): (WebCore::SVGElementRareData::setCursorImageValue):
- svg/SVGStyledElement.cpp: Move m_instancesUpdatesBlocked into SVGElementRareData. (WebCore::SVGStyledElement::SVGStyledElement): (WebCore::SVGStyledElement::instanceUpdatesBlocked): (WebCore::SVGStyledElement::setInstanceUpdatesBlocked):
- svg/SVGStyledElement.h:
- svg/SVGUseElement.cpp: Adapt to element instances changes, now passed as const-reference. (WebCore::dumpInstanceTree):
- 11:24 AM Changeset in webkit [54008] by
-
- 13 edits in trunk
2010-01-28 Aaron Boodman <aa@chromium.org>
Reviewed by Darin Adler.
Expand the NotificationPresenter::checkPermission() interface to send the full
URL of the requesting context, as well as a pointer to the document if that
context was a document.
- notifications/Notification.cpp: (WebCore::Notification::Notification):
- notifications/NotificationCenter.cpp: (WebCore::NotificationCenter::NotificationCenter): (WebCore::NotificationCenter::checkPermission): Pass the full URL and document from the requesting context when calling NotificationPresenter::checkPermission().
- notifications/NotificationPresenter.h: (WebCore::NotificationPresenter::): Expand interface.
2010-01-27 Aaron Boodman <aa@chromium.org>
Reviewed by Darin Adler.
Send full URL and application id of requesting context to Chromium
when checking notification permissions.
- public/WebDocument.h:
- src/WebDocument.cpp: (WebKit::WebDocument::applicationID): Implement applicationID() method.
- public/WebNotificationPresenter.h:
- src/NotificationPresenterImpl.cpp: (WebKit::NotificationPresenterImpl::checkPermission):
- src/NotificationPresenterImpl.h: Send applicationID and full URL through to Chromium.
2010-01-27 Aaron Boodman <aa@chromium.org>
Expand NotificationCenter::checkPermission() interface.
It now passes the full URL instead of just the origin.
- WebCoreSupport/WebDesktopNotificationsDelegate.cpp: (WebDesktopNotificationsDelegate::checkPermission):
- WebCoreSupport/WebDesktopNotificationsDelegate.h:
- 10:34 AM Changeset in webkit [54007] by
-
- 2 edits in trunk/LayoutTests/fast/dom/Window
Unreviewed, trivial expectations update.
- 10:08 AM QtWebKitBackportingFixes edited by
- (diff)
- 10:07 AM Changeset in webkit [54006] by
-
- 6 edits4 adds in trunk
2010-01-28 Simon Fraser <Simon Fraser>
Reviewed by Dan Bernstein.
Video can overlap position:fixed element when scrolling
https://bugs.webkit.org/show_bug.cgi?id=32180
When the scroll position changes, and we're using overlap to decide what gets composited,
then we need to re-evaluate what gets compositing when scrolling in case fixed postion elements
overlap composited elements (e.g. video).
Test: compositing/geometry/video-fixed-scrolling.html
- page/FrameView.cpp: (WebCore::FrameView::updateCompositingLayers): (WebCore::FrameView::scrollPositionChanged): Annotate the calls to updateCompositingLayers() with the type of change that occurred.
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::updateCompositingAndLayerListsIfNeeded): Ditto.
- rendering/RenderLayerCompositor.h:
- rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::updateCompositingLayers): For scroll changes, check for hierarchy update if m_compositingConsultsOverlap is true, and do a geometry update. For other changes, always check for hierarchy updates.
- 9:47 AM Changeset in webkit [54005] by
-
- 7 edits2 adds in trunk
Fix for user stylesheet bugs where they get parsed using the wrong compatibility mode. This was a regression
caused from Safari 3 -> 4 by the Acid3 fixes to create a real DOCTYPE in the DOM.
Reviewed by Darin Adler.
This patch makes style selector creation lazy, so that the selector isn't built unless someone asks for it.
In order to avoid creating the style selector before the compatibility mode has been determined, document
style is now created without having a dependence on an instantiated style selector. The creation of the style
is now done as a static method on CSSStyleSelector called styleForDocument, and a couple of font-related
functions have been made static as well so that they can be used by this method.
m_styleSelector on Document is now an OwnPtr.
Added userscripts/mixed-case-stylesheet.html
- css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::styleForDocument):
(WebCore::CSSStyleSelector::applyProperty):
(WebCore::CSSStyleSelector::checkForGenericFamilyChange):
(WebCore::CSSStyleSelector::setFontSize):
(WebCore::CSSStyleSelector::getComputedSizeFromSpecifiedSize):
(WebCore::CSSStyleSelector::fontSizeForKeyword):
- css/CSSStyleSelector.h:
- dom/Document.cpp:
(WebCore::Document::Document):
(WebCore::Document::~Document):
(WebCore::Document::recalcStyle):
(WebCore::Document::createStyleSelector):
(WebCore::Document::attach):
(WebCore::Document::setVisuallyOrdered):
(WebCore::Document::recalcStyleSelector):
- dom/Document.h:
(WebCore::Document::styleSelector):
(WebCore::Document::visuallyOrdered):
- html/HTMLDocument.cpp:
(WebCore::HTMLDocument::determineParseMode):
- loader/PlaceholderDocument.cpp:
(WebCore::PlaceholderDocument::attach):
- 9:03 AM Changeset in webkit [54004] by
-
- 1 edit2 adds in trunk/LayoutTests
2010-01-28 Anton Muhin <antonm@google.com>
Reviewed by Alexey Proskuryakov.
Add layout tests to verify assignment to items of NodeList
https://bugs.webkit.org/show_bug.cgi?id=34213
- fast/dom/NodeList/nodelist-item-assignment-expected.txt: Added.
- fast/dom/NodeList/nodelist-item-assignment.html: Added.
- 8:47 AM Changeset in webkit [54003] by
-
- 9 edits2 moves in trunk/WebCore
2010-01-28 Kent Tamura <tkent@chromium.org>
Reviewed by Darin Adler.
Rename ISODateTime.{cpp,h} to DateComponents.{cpp,h}
https://bugs.webkit.org/show_bug.cgi?id=34245
No functional changes.
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- html/DateComponents.cpp: Copied from WebCore/html/ISODateTime.cpp. (WebCore::DateComponents::maxWeekNumberInYear): (WebCore::DateComponents::parseYear): (WebCore::DateComponents::addDay): (WebCore::DateComponents::addMinute): (WebCore::DateComponents::parseTimeZone): (WebCore::DateComponents::parseMonth): (WebCore::DateComponents::parseDate): (WebCore::DateComponents::parseWeek): (WebCore::DateComponents::parseTime): (WebCore::DateComponents::parseDateTimeLocal): (WebCore::DateComponents::parseDateTime): (WebCore::DateComponents::setMillisecondsSinceMidnightInternal): (WebCore::DateComponents::setMillisecondsSinceEpochForDateInternal): (WebCore::DateComponents::setMillisecondsSinceEpochForDate): (WebCore::DateComponents::setMillisecondsSinceEpochForDateTime): (WebCore::DateComponents::setMillisecondsSinceEpochForDateTimeLocal): (WebCore::DateComponents::setMillisecondsSinceEpochForMonth): (WebCore::DateComponents::setMillisecondsSinceMidnight): (WebCore::DateComponents::setMillisecondsSinceEpochForWeek): (WebCore::DateComponents::millisecondsSinceEpochForTime): (WebCore::DateComponents::millisecondsSinceEpoch): (WebCore::DateComponents::toStringForTime): (WebCore::DateComponents::toString):
- html/DateComponents.h: Copied from WebCore/html/ISODateTime.h. (WebCore::DateComponents::DateComponents):
- html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::parseToDouble): (WebCore::HTMLInputElement::valueAsDate): (WebCore::HTMLInputElement::setValueAsDate): (WebCore::HTMLInputElement::setValueAsNumber): (WebCore::HTMLInputElement::formStringToDateComponents):
- html/HTMLInputElement.h:
- html/ISODateTime.cpp: Removed.
- html/ISODateTime.h: Removed.
- html/ValidityState.cpp: (WebCore::ValidityState::typeMismatch):
- 8:44 AM Changeset in webkit [54002] by
-
- 5 edits in trunk/WebKitTools
[Qt] Unreviewed, roll out r54000.
- DumpRenderTree/qt/DumpRenderTreeQt.cpp:
(WebCore::DumpRenderTree::DumpRenderTree):
- DumpRenderTree/qt/DumpRenderTreeQt.h:
- DumpRenderTree/qt/LayoutTestControllerQt.cpp:
(LayoutTestController::reset):
- DumpRenderTree/qt/LayoutTestControllerQt.h:
(LayoutTestController::display):
- 8:28 AM Changeset in webkit [54001] by
-
- 9 edits in trunk/WebCore
2010-01-28 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Pavel Feldman.
Use platform-specific monospace fonts in the Web Inspector
Move the OS version detection code into the frontend,
add custom CSS monospace styles for known platforms.
https://bugs.webkit.org/show_bug.cgi?id=34040
- inspector/InspectorFrontendHost.cpp: (WebCore::InspectorFrontendHost::platform):
- inspector/front-end/BreakpointsSidebarPane.js: (WebInspector.BreakpointsSidebarPane.prototype._appendBreakpointElement):
- inspector/front-end/DatabaseQueryView.js: (WebInspector.DatabaseQueryView):
- inspector/front-end/InspectorBackendStub.js: (.WebInspector.InspectorBackendStub.prototype.releaseWrapperObjectGroup): (.WebInspector.InspectorBackendStub.prototype.setInjectedScriptSource):
- inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype._createConditionElement):
- inspector/front-end/inspector.css:
- inspector/front-end/inspector.html:
- inspector/front-end/inspector.js: (WebInspector.URLRegExp.i.get platform): (WebInspector._detectPlatform):
- 6:41 AM Changeset in webkit [54000] by
-
- 5 edits in trunk/WebKitTools
2010-01-28 Benjamin Poulain <benjamin.poulain@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Implement the display() method of the layout test controller
https://bugs.webkit.org/show_bug.cgi?id=34258
- DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::DumpRenderTree::DumpRenderTree): (WebCore::DumpRenderTree::showPage): (WebCore::DumpRenderTree::hidePage):
- DumpRenderTree/qt/DumpRenderTreeQt.h:
- DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::reset): (LayoutTestController::display):
- DumpRenderTree/qt/LayoutTestControllerQt.h:
- 5:39 AM Changeset in webkit [53999] by
-
- 2 edits in trunk/WebKit/qt
Do not set the combobox font on Maemo5 and S60; use the
default instead.
Reviewed by Simon Hausmann.
- WebCoreSupport/QtFallbackWebPopup.cpp:
(WebCore::QtFallbackWebPopup::populate):
- 5:22 AM Changeset in webkit [53998] by
-
- 3 edits in trunk/WebKitTools
Eliminated the filename parameter from functions in
check-webkit-style's cpp.py where it is no longer used.
Reviewed by Shinichiro Hamaji.
https://bugs.webkit.org/show_bug.cgi?id=34249
- Scripts/webkitpy/style/processors/cpp.py:
- Reduced number of occurrences of "filename" variable from approximately 200 to 120.
- Scripts/webkitpy/style/processors/cpp_unittest.py:
- Refactored unit tests as necessary to accommodate changes to cpp.py.
- Fixed bug in CppStyleTestBase.perform_include_what_you_use() where the incorrect file extension was getting passed to cpp_style.check_language().
- 5:06 AM Changeset in webkit [53997] by
-
- 2 edits in trunk/WebKit/qt
[Qt] Fix for endless print loop when printing web pages
Patch by Trond Kjernåsen <trond@trolltech.com> on 2010-01-28
Reviewed by Simon Hausmann.
- Api/qwebframe.cpp:
(QWebFrame::print):
- 4:34 AM Changeset in webkit [53996] by
-
- 4 edits in trunk/WebCore
2010-01-28 Mikhail Naganov <mnaganov@chromium.org>
Reviewed by Timothy Hatcher.
Simplify views logic in Profiler panel, and fix the problem described in the issue.
Remove image from Welcome view.
Preserve border on status bar-like buttons in Welcome view on window deactivation.
- inspector/front-end/ProfilesPanel.js: (WebInspector.ProfilesPanel.prototype.show): (WebInspector.ProfilesPanel.prototype.reset): (WebInspector.ProfilesPanel.prototype.addProfileHeader): (WebInspector.ProfilesPanel.prototype.showView): (WebInspector.ProfilesPanel.prototype._updateInterface):
- inspector/front-end/WelcomeView.js: (WebInspector.WelcomeView):
- inspector/front-end/inspector.css:
- 3:54 AM Changeset in webkit [53995] by
-
- 2 edits in trunk/WebCore
[Qt] Speed up KURL to QUrl conversion
https://bugs.webkit.org/show_bug.cgi?id=33873
The WebCore::String::utf8 method will use the generic WebCore::TextCodec
and then call the encode method on it. In QtWebKit this class is implemented
around the QTextCodec class. Instead of going the generic codec way we treat
the WebCore::String as a QString (no copying) and then use the built-in
QString::toUtf8 to do the conversion.
- 3:00 AM Changeset in webkit [53994] by
-
- 12 edits in trunk
[Android] [Qt] Touch event page co-ordinates are incorrect when touch is received in an iframe.
https://bugs.webkit.org/show_bug.cgi?id=34162
Reviewed by Simon Hausmann.
WebCore:
The pageX/pageY co-ordinates of a touch event should be relative to the containing frame, not the main frame. This change implements that and also updates the existing touch-inside-iframe test to also examine the page co-ordinates.
- dom/Touch.cpp:
(WebCore::Touch::Touch): Remove dead code.
- dom/Touch.h: Remove dead code.
- page/EventHandler.cpp:
(WebCore::EventHandler::handleTouchEvent): Rename framePoint to pagePoint, as it seems a clearer name. Also adjust the pagePoint to be relative to the touch target element's containing frame rather than the main frame.
- platform/PlatformTouchEvent.h: Rename Android specific constructor parameter to better reflect it's contents.
- platform/PlatformTouchPoint.h: Ditto.
- platform/android/PlatformTouchEventAndroid.cpp: Ditto.
- platform/android/PlatformTouchPointAndroid.cpp: Ditto.
LayoutTests:
Update the existing iframe touch event test to also examine the page co-ordinates of the touch that is received.
- fast/events/touch/resources/touch-inside-iframe2.html:
- fast/events/touch/touch-inside-iframe-expected.txt:
- fast/events/touch/touch-inside-iframe.html:
- 2:46 AM Changeset in webkit [53993] by
-
- 2 edits in trunk/WebCore
2010-01-28 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Simplify isActivation method.
Test: WebCore/manual-tests/inspector/debugger-scopes-inspection.html
- bindings/js/JSInjectedScriptHostCustom.cpp: (WebCore::JSInjectedScriptHost::isActivation):
- 1:20 AM Changeset in webkit [53992] by
-
- 2 edits in trunk/LayoutTests
2010-01-28 Xan Lopez <xlopez@igalia.com>
[GTK] Can DnD files to our filechooser widget (<input type="file">)
https://bugs.webkit.org/show_bug.cgi?id=34246
Skip failing test because of this missing feature.
- platform/gtk/Skipped:
- 1:10 AM Changeset in webkit [53991] by
-
- 9 edits1 delete in trunk/LayoutTests
2010-01-28 Kent Tamura <tkent@chromium.org>
Reviewed by Darin Fisher.
Remove tests for dates later than 275760-09-13T00:00Z.
https://bugs.webkit.org/show_bug.cgi?id=34240
Date.UTC() of V8 doesn't support such dates though Date.UTC() of
JavaScriptCore does.
- fast/forms/input-valueasnumber-date-expected.txt:
- fast/forms/input-valueasnumber-datetime-expected.txt:
- fast/forms/input-valueasnumber-datetimelocal-expected.txt:
- fast/forms/input-valueasnumber-month-expected.txt:
- fast/forms/script-tests/input-valueasnumber-date.js:
- fast/forms/script-tests/input-valueasnumber-datetime.js:
- fast/forms/script-tests/input-valueasnumber-datetimelocal.js:
- fast/forms/script-tests/input-valueasnumber-month.js:
- platform/win/fast/forms/input-valueasnumber-datetime-expected.txt: Removed.
- 12:45 AM Changeset in webkit [53990] by
-
- 5 edits in trunk/WebKitTools
2010-01-28 Chris Jerdonek <Chris Jerdonek>
Reviewed by Shinichiro Hamaji.
In check-webkit-style, eliminated the dependency of
processors/cpp_unittest.py on checker.py.
- Scripts/webkitpy/style/checker.py:
- Addressed FIXME by removing STYLE_CATEGORIES data.
- Added style_categories().
- Scripts/webkitpy/style/checker_unittest.py:
- Minor changes.
- Scripts/webkitpy/style/processors/cpp.py:
- Added categories attribute to CppProcessor class (data was originally checker.STYLE_CATEGORIES).
- Scripts/webkitpy/style/processors/cpp_unittest.py:
- Addressed FIXME by eliminating "import" from checker.py.
- 12:29 AM Changeset in webkit [53989] by
-
- 3 edits in trunk/WebKitTools
2010-01-28 Anton Muhin <antonm@chromium.org>
Reviewed by Shinichiro Hamaji.
Improve treatment of conditions and rest of the line for if, else, switch and alikes
https://bugs.webkit.org/show_bug.cgi?id=34173
- Scripts/webkitpy/style/cpp_style.py:
- Scripts/webkitpy/style/cpp_style_unittest.py:
- 12:14 AM Changeset in webkit [53988] by
-
- 10 edits2 adds in branches/safari-4-branch
Merge r53567.
- 12:14 AM Changeset in webkit [53987] by
-
- 5 edits2 adds in branches/safari-4-branch
Merge r53368.
- 12:14 AM Changeset in webkit [53986] by
-
- 30 edits1 copy7 adds in branches/safari-4-branch
Merge r53512.
- 12:13 AM Changeset in webkit [53985] by
-
- 3 edits2 adds in branches/safari-4-branch
Merge r53369.
- 12:13 AM Changeset in webkit [53984] by
-
- 10 edits2 adds in branches/safari-4-branch
Merge r53220.
- 12:13 AM Changeset in webkit [53983] by
-
- 3 edits2 adds in branches/safari-4-branch
Merge r53163.
- 12:13 AM Changeset in webkit [53982] by
-
- 6 edits2 adds in branches/safari-4-branch
Merge r52351.
- 12:13 AM Changeset in webkit [53981] by
-
- 3 edits2 adds in branches/safari-4-branch
Merge r52781.
- 12:13 AM Changeset in webkit [53980] by
-
- 14 edits2 adds in branches/safari-4-branch
Merge r52773.
- 12:13 AM Changeset in webkit [53979] by
-
- 3 edits2 adds in branches/safari-4-branch
Merge r52352.
- 12:13 AM Changeset in webkit [53978] by
-
- 7 edits2 adds in branches/safari-4-branch
Merge r52233.
- 12:13 AM Changeset in webkit [53977] by
-
- 4 edits2 adds in branches/safari-4-branch
Merge r50196.
- 12:12 AM Changeset in webkit [53976] by
-
- 2 edits in trunk/WebKitTools
2010-01-28 Joe Mason <jmason@rim.com>
Reviewed by Adam Barth.
Limit login retries to 5
https://bugs.webkit.org/show_bug.cgi?id=34193
- Scripts/webkitpy/bugzilla.py:
Jan 27, 2010:
- 11:29 PM Changeset in webkit [53975] by
-
- 4 edits6 adds in trunk
2010-01-27 Kent Tamura <tkent@chromium.org>
Reviewed by Darin Adler.
rangeOverflow/rangeUnderflow support for type=date
https://bugs.webkit.org/show_bug.cgi?id=34209
- fast/forms/ValidityState-rangeOverflow-date-expected.txt: Added.
- fast/forms/ValidityState-rangeOverflow-date.html: Added.
- fast/forms/ValidityState-rangeUnderflow-date-expected.txt: Added.
- fast/forms/ValidityState-rangeUnderflow-date.html: Added.
- fast/forms/script-tests/ValidityState-rangeOverflow-date.js: Added.
- fast/forms/script-tests/ValidityState-rangeUnderflow-date.js: Added.
2010-01-27 Kent Tamura <tkent@chromium.org>
Reviewed by Darin Adler.
rangeOverflow/rangeUnderflow support for type=date
https://bugs.webkit.org/show_bug.cgi?id=34209
Add DATE type support to rangeUnderflow(), rangeOverflow(),
minimum(), and maximum() of HTMLInputElement.
In order to unify parsing code for value, min, and max strings,
introduce parseToDouble() function and it is called by
valueAsDate() and valueAsNumber() too.
Tests: fast/forms/ValidityState-rangeOverflow-date.html
fast/forms/ValidityState-rangeUnderflow-date.html
- html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::rangeUnderflow): Support DATE type, and use parseToDouble(). (WebCore::HTMLInputElement::rangeOverflow): ditto. (WebCore::HTMLInputElement::minimum): ditto. (WebCore::HTMLInputElement::maximum): ditto. (WebCore::HTMLInputElement::doubleValueFor): Added. (WebCore::HTMLInputElement::valueAsDate): Use parseToDouble(). (WebCore::HTMLInputElement::valueAsNumber): Use parseToDouble().
- html/HTMLInputElement.h: Declare parseToDouble().
- 11:27 PM Changeset in webkit [53974] by
-
- 2 edits in trunk/WebCore
2010-01-27 Darin Fisher <darin@chromium.org>
Fix chromium build bustage (take 2).
- bindings/scripts/CodeGeneratorV8.pm: Really treat V8CustomGetter like CustomGetter in all cases.
- 11:18 PM Changeset in webkit [53973] by
-
- 2 edits in trunk/LayoutTests
[Qt] Skip test introduced in r53972 because of missing eventSender.beginDragWithFiles()
- platform/qt/Skipped: fast/dom/Window/window-postmessage-clone-frames.html skipped.
- 10:50 PM Changeset in webkit [53972] by
-
- 2 edits in trunk/WebCore
2010-01-27 Darin Fisher <darin@chromium.org>
Fix chromium build bustage.
- bindings/scripts/CodeGeneratorV8.pm: Treat V8CustomGetter like CustomGetter in all cases.
- 10:36 PM Changeset in webkit [53971] by
-
- 3 edits in trunk/WebKit/chromium
2010-01-27 Darin Fisher <darin@chromium.org>
Reviewed by Pavel Feldman.
Expose HistoryItem::documentSequenceNumber
https://bugs.webkit.org/show_bug.cgi?id=34243
- public/WebHistoryItem.h:
- src/WebHistoryItem.cpp: (WebKit::WebHistoryItem::documentSequenceNumber): (WebKit::WebHistoryItem::setDocumentSequenceNumber):
- 9:26 PM Changeset in webkit [53970] by
-
- 2 edits in trunk/JavaScriptCore
Windows build fix.
- 8:47 PM Changeset in webkit [53969] by
-
- 12 edits3 adds in trunk
2010-01-27 Oliver Hunt <oliver@apple.com>
Reviewed by Maciej Stachowiak.
MessageEvent.data should deserialize in the context of the MessageEvent's global object
https://bugs.webkit.org/show_bug.cgi?id=34227
Add logic to allow us to create an Object, Array, or Date instance
so we can create them in the context of a specific global object,
rather than just using the current lexical global object.
- JavaScriptCore.exp:
- runtime/DateInstance.cpp: (JSC::DateInstance::DateInstance):
- runtime/DateInstance.h:
- runtime/JSGlobalObject.h: (JSC::constructEmptyObject): (JSC::constructEmptyArray):
2010-01-27 Oliver Hunt <oliver@apple.com>
Reviewed by Maciej Stachowiak.
MessageEvent.data should deserialize in the context of the MessageEvent's global object
https://bugs.webkit.org/show_bug.cgi?id=34227
Test that the object returned from postMessage.data is created in the correct context
- fast/dom/Window/resources/window-postmessage-clone-frames-frame.html: Added.
- fast/dom/Window/window-postmessage-clone-frames-expected.txt: Added.
- fast/dom/Window/window-postmessage-clone-frames.html: Added.
2010-01-27 Oliver Hunt <oliver@apple.com>
Reviewed by Maciej Stachowiak.
MessageEvent.data should deserialize in the context of the MessageEvent's global object
https://bugs.webkit.org/show_bug.cgi?id=34227
Make ScriptValue deserialisation support the provision of a specific global
object to use when creating new objects. This then allows us to make
MessageEvent.data and PopStateEvent.state deserialize in the correct
context.
Test: fast/dom/Window/window-postmessage-clone-frames.html
- bindings/js/JSPopStateEventCustom.cpp: Remove custom implementation of state getter
- bindings/js/SerializedScriptValue.cpp: (WebCore::DeserializingTreeWalker::DeserializingTreeWalker): (WebCore::DeserializingTreeWalker::createOutputArray): (WebCore::DeserializingTreeWalker::createOutputObject): (WebCore::DeserializingTreeWalker::convertIfTerminal): (WebCore::SerializedScriptValueData::deserialize): (WebCore::SerializedScriptValue::deserialize):
- bindings/js/SerializedScriptValue.h: (WebCore::SerializedScriptValue::deserialize):
- bindings/scripts/CodeGeneratorJS.pm: Update bindings generation to pass the correct global object, and to treat "any" as synonymous with SerializedValue.
- dom/PopStateEvent.idl:
- 7:24 PM Changeset in webkit [53968] by
-
- 2 edits in trunk/WebKitTools
Adding myself to the committer list. No review necessary.
- Scripts/webkitpy/committers.py:
- 7:22 PM Changeset in webkit [53967] by
-
- 2 edits in trunk/WebKit/gtk
2010-01-27 Martin Robinson <Martin Robinson>
Reviewed by Gustavo Noronha Silva.
[GTK] Expose the IM context via the API
https://bugs.webkit.org/show_bug.cgi?id=33327
Expose the GtkIMMultiContext as a property of WebKitWebView. This will
allow embedders to generate the input method context menu entries and
make testing certain IM context behavior possible.
- webkit/webkitwebview.cpp: (webkit_web_view_get_property): (DNDContentsRequest::webkit_web_view_get_im_context): (DNDContentsRequest::webkit_web_view_class_init):
- 6:55 PM Changeset in webkit [53966] by
-
- 3 edits in trunk/WebCore
2010-01-27 Nicholas Young <nicholas.young@nokia.com>
Reviewed by Eric Carlson.
Make media controls fade in/out transition duration configurable on a theme level.
https://bugs.webkit.org/show_bug.cgi?id=34196
No new tests needed (I hope).
- rendering/RenderMedia.cpp: (WebCore::RenderMedia::RenderMedia): Removed constant from contructor - the initial value is meaningless. (WebCore::RenderMedia::updateControlVisibility): Get fade in/out duration from theme.
- rendering/RenderTheme.h: (WebCore::RenderTheme::mediaControlsFadeInDuration): New virtual method. (WebCore::RenderTheme::mediaControlsFadeOutDuration): New virtual method.
- 5:41 PM Changeset in webkit [53965] by
-
- 7 edits1 copy2 moves1 add in trunk
2010-01-27 John Abd-El-Malek <jam@chromium.org>
Reviewed by Dimitri Glazkov.
Tests that when a page removes an iframe that sleeps in its unload handler and
terminates its JS execution, the outer page's JS continues running.
- fast/dom/Window/slow-unload-handler-expected.txt: Copied from LayoutTests/fast/dom/Window/slow_unload_handler-expected.txt.
- fast/dom/Window/slow-unload-handler-only-frame-is-stopped.html: Added.
- fast/dom/Window/slow-unload-handler-only-frame-is-stopped-expected.txt: Added.
- fast/dom/Window/slow-unload-handler.html: Copied from LayoutTests/fast/dom/Window/slow_unload_handler.html.
- fast/dom/Window/slow_unload_handler-expected.txt: Removed.
- fast/dom/Window/slow_unload_handler.html: Removed.
- platform/gtk/Skipped:
- platform/mac/Skipped:
- platform/qt/Skipped:
- platform/win/Skipped:
2010-01-27 John Abd-El-Malek <jam@chromium.org>
Reviewed by Dimitri Glazkov.
Tests that when a page removes an iframe that sleeps in its unload handler and
terminates its JS execution, the outer page's JS continues running.
Tests: fast/dom/Window/slow-unload-handler-only-frame-is-stopped.html
fast/dom/Window/slow-unload-handler.html
- bindings/v8/DateExtension.cpp: (WebCore::DateExtension::OnSleepDetected):
- 5:24 PM Changeset in webkit [53964] by
-
- 5 edits3 adds in trunk
2010-01-27 Kent Tamura <tkent@chromium.org>
Reviewed by Darin Adler.
Add valueAsNumber support for type=datetime-local.
https://bugs.webkit.org/show_bug.cgi?id=34200
The test data is equivalent to input-valueasnumber-datetime.html.
The expectation contains two FAIL lines because they check
unimplemented features.
- fast/forms/input-valueasnumber-datetimelocal-expected.txt: Added.
- fast/forms/input-valueasnumber-datetimelocal.html: Added.
- fast/forms/script-tests/input-valueasnumber-datetimelocal.js: Added.
2010-01-27 Kent Tamura <tkent@chromium.org>
Reviewed by Darin Adler.
Add valueAsNumber support for type=datetime-local.
https://bugs.webkit.org/show_bug.cgi?id=34200
Implement necessary methods of ISODateTime, and call them from
HTMLInputElement.
Test: fast/forms/input-valueasnumber-datetimelocal.html
- html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::valueAsNumber): (WebCore::HTMLInputElement::setValueAsNumber):
- html/ISODateTime.cpp: (WebCore::ISODateTime::setMillisecondsSinceEpochForDateTimeLocal): Implemented. Just call setMillisecondsSinceEpochForDateTime(). (WebCore::ISODateTime::millisecondsSinceEpochForTime): Accept to be called for m_type=DateTimeLocal. (WebCore::ISODateTime::toString): Add DateTimeLocal support.
- html/ISODateTime.h: Declare new methods.
- 5:11 PM Changeset in webkit [53963] by
-
- 2 edits1 add in branches/safari-4-branch/WebCore
Merge r53867.
- 5:05 PM Changeset in webkit [53962] by
-
- 2 edits in trunk/WebKitTools
2010-01-27 George Wright <gwright@rim.com>
Reviewed by Adam Treat.
Add missing include for wtf/Platform.h
- DumpRenderTree/AccessibilityController.h:
- 4:46 PM Changeset in webkit [53961] by
-
- 3 edits in trunk/WebCore
Windows Debug_All build fix.
- platform/graphics/win/WKCACFLayer.cpp:
- platform/graphics/win/WKCACFLayerRenderer.cpp:
- 4:28 PM Changeset in webkit [53960] by
-
- 3 edits in trunk/WebKit/win
Make it possible to instantiate WebSerializedJSValue using WebKitCreateInstance
Reviewed by Dave Hyatt.
- ForEachCoClass.h:
- WebKitClassFactory.cpp:
Added WebSerializedJSValue.
- 4:23 PM Changeset in webkit [53959] by
-
- 1 edit2 adds in trunk/LayoutTests
Rubber-stamped by Adam Roben.
Add platform specific failing Windows results for two recently
added tests. I will comment on their originating bugs saying that
failing results were landed for Windows.
<https://bugs.webkit.org/show_bug.cgi?id=29564>
<https://bugs.webkit.org/show_bug.cgi?id=32696>
- platform/win/fast/css/button-height-expected.txt: Added.
- platform/win/fast/forms/input-valueasnumber-datetime-expected.txt: Added.
- 4:16 PM Changeset in webkit [53958] by
-
- 3 edits in trunk/WebCore
2010-01-27 Evan Martin <evan@chromium.org>
Reviewed by David Levin.
[chromium] complex text draws newlines as bells
https://bugs.webkit.org/show_bug.cgi?id=34186
Revert r45496 -- once we've got a glyph array, it is too late to normalize
because we could have had multiple codepoints combine into one glyph. The
Uniscribe code it mentions it's duplicating uses the log cluster map to fix
this.
Instead, we just normalize the input text if it contains any non-ascii-space
whitespace.
This fixes fast/text/international/hindi-whitespace, which currently has an
incorrect baseline containing a square box glyph.
- platform/graphics/chromium/FontLinux.cpp: (WebCore::TextRunWalker::getTextRun): (WebCore::TextRunWalker::getNormalizedTextRun):
- platform/graphics/chromium/HarfbuzzSkia.cpp: (WebCore::stringToGlyphs):
- 3:41 PM Changeset in webkit [53957] by
-
- 20 edits in trunk
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=34150
WebKit needs a mechanism to catch stale HashMap entries
It is very difficult to catch stale pointers that are HashMap keys - since a pointer's hash
is just its value, it is very unlikely that any observable problem is reproducible.
This extends hash table consistency checks to check that pointers are referencing allocated
memory blocks, and makes it possible to invoke the checks explicitly (it is not feasible
to enable CHECK_HASHTABLE_CONSISTENCY by default, because that affects performance too much).
- wtf/HashMap.h: (WTF::::checkConsistency): Call through to HashTable implementation. We can add similar calls to HashSet and HashCountedSet, but I haven't seen hard to debug problems with those yet.
- wtf/HashSet.h: (WTF::::remove): The version of checkTableConsistency that's guarded by CHECK_HASHTABLE_CONSISTENCY is now called internalCheckTableConsistency().
- wtf/HashTable.h: (WTF::HashTable::internalCheckTableConsistency): (WTF::HashTable::internalCheckTableConsistencyExceptSize): (WTF::HashTable::checkTableConsistencyExceptSize): Expose checkTableConsistency() even if CHECK_HASHTABLE_CONSISTENCY is off. (WTF::::add): Updated for checkTableConsistency renaming. (WTF::::addPassingHashCode): Ditto. (WTF::::removeAndInvalidate): Ditto. (WTF::::remove): Ditto. (WTF::::rehash): Ditto. (WTF::::checkTableConsistency): The assertion for !shouldExpand() was not correct - this function returns true for tables with m_table == 0. (WTF::::checkTableConsistencyExceptSize): Call checkValueConsistency for key. Potentially, we could do the same for values.
- wtf/HashTraits.h: (WTF::GenericHashTraits::checkValueConsistency): An empty function that can be overridden to add checks. Currently, the only override is for pointer hashes.
- wtf/RefPtrHashMap.h: (WTF::::remove): Updated for checkTableConsistency renaming.
- 3:32 PM Changeset in webkit [53956] by
-
- 7 edits in trunk
2010-01-27 Diego Gonzalez <diego.gonzalez@openbossa.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] DRT Provide worker thread ability to track counters
https://bugs.webkit.org/show_bug.cgi?id=34221
Implement workerThreadCount() in LayoutTestController of Qt DRT
Tests:
fast/workers/dedicated-worker-lifecycle.html
fast/workers/shared-worker-frame-lifecycle.html
fast/workers/shared-worker-lifecycle.html
fast/workers/worker-lifecycle.html
- platform/qt/Skipped:
2010-01-27 Diego Gonzalez <diego.gonzalez@openbossa.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] DRT Provide worker thread ability to track counters
https://bugs.webkit.org/show_bug.cgi?id=34221
Implement workerThreadCount() in LayoutTestController of Qt DRT
Tests:
fast/workers/dedicated-worker-lifecycle.html
fast/workers/shared-worker-frame-lifecycle.html
fast/workers/shared-worker-lifecycle.html
fast/workers/worker-lifecycle.html
- Api/qwebpage.cpp: (qt_drt_workerThreadCount):
2010-01-27 Diego Gonzalez <diego.gonzalez@openbossa.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] DRT Provide worker thread ability to track counters
https://bugs.webkit.org/show_bug.cgi?id=34221
Implement workerThreadCount() in LayoutTestController of Qt DRT
Tests:
fast/workers/dedicated-worker-lifecycle.html
fast/workers/shared-worker-frame-lifecycle.html
fast/workers/shared-worker-lifecycle.html
fast/workers/worker-lifecycle.html
- DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::workerThreadCount):
- DumpRenderTree/qt/LayoutTestControllerQt.h:
- 3:16 PM Changeset in webkit [53955] by
-
- 4 edits in trunk/WebCore
2010-01-27 Brian Tarricone <brian@kakai.com>
Reviewed by Gustavo Noronha Silva.
[gtk] Add support for windowless NPAPI plugins
Much of this is a translation of how the Qt backend does this,
modified for Gtk.
No new tests; there is already a windowless test in the tree.
- plugins/PluginView.cpp: (WebCore::PluginView::handleEvent): (WebCore::PluginView::PluginView):
- plugins/PluginView.h:
- plugins/gtk/PluginViewGtk.cpp: (WebCore::getRootWindow): (WebCore::PluginView::updatePluginWidget): (WebCore::PluginView::paint): (WebCore::PluginView::handleKeyboardEvent): (WebCore::inputEventState): (WebCore::PluginView::initXEvent): (WebCore::setXButtonEventSpecificFields): (WebCore::setXMotionEventSpecificFields): (WebCore::setXCrossingEventSpecificFields): (WebCore::PluginView::handleMouseEvent): (WebCore::PluginView::handleFocusInEvent): (WebCore::PluginView::handleFocusOutEvent): (WebCore::PluginView::setNPWindowRect): (WebCore::PluginView::setNPWindowIfNeeded): (WebCore::PluginView::getValueStatic): (WebCore::PluginView::invalidateRect): (WebCore::getPluginDisplay): (WebCore::plug_removed_cb): (WebCore::getVisualAndColormap): (WebCore::PluginView::platformStart): (WebCore::PluginView::platformDestroy):
- 2:59 PM Changeset in webkit [53954] by
-
- 2 edits in trunk/JavaScriptCore
2010-01-27 Anton Muhin <antonm@chromium.org>
Reviewed by Darin Adler.
Remove trailing \ from inline function code
https://bugs.webkit.org/show_bug.cgi?id=34223
- assembler/ARMv7Assembler.h: (JSC::ARMThumbImmediate::countLeadingZerosPartial):
- 2:41 PM Changeset in webkit [53953] by
-
- 2 edits in trunk/WebCore
2010-01-27 Anton Muhin <antonm@chromium.org>
Reviewed by David Levin.
[v8] minor cosmetic fix in V8 bindings codegenerator
https://bugs.webkit.org/show_bug.cgi?id=34224
- bindings/scripts/CodeGeneratorV8.pm:
- 2:08 PM Changeset in webkit [53952] by
-
- 2 edits in trunk/WebKitTools
Rubberstamped by Simon Hausmann.
[Qt] QtLauncher refactoring:
Make the LauncherWindow depend less on the view, so that more
code can be shared in near future.
- QtLauncher/main.cpp:
(LauncherWindow::sendTouchEvent):
(LauncherWindow::loadFinished):
(LauncherWindow::zoomIn):
(LauncherWindow::zoomOut):
(LauncherWindow::resetZoom):
(LauncherWindow::toggleZoomTextOnly):
(LauncherWindow::dumpHtml):
(LauncherWindow::selectElements):
(LauncherWindow::setupUI):
- 1:36 PM Changeset in webkit [53951] by
-
- 2 edits in trunk/WebCore
2010-01-27 Darin Fisher <darin@chromium.org>
Fix Chromium build bustage.
- rendering/RenderBoxModelObject.cpp: Add wtf/CurrentTime.h include.
- 1:17 PM Changeset in webkit [53950] by
-
- 17 edits2 deletes in trunk
2010-01-26 Darin Fisher <darin@chromium.org>
Reviewed by Brady Eidson and David Levin.
Chains of history items representing same-document navigation need to
always remember that association
Replace HistoryItem's Document pointer with a DocumentSequenceNumber.
During session history traversal, if the current HistoryItem and the
target HistoryItem have the same DocumentSequenceNumber, then it means
that the current Document should remain.
NOTE: To support Chromium's serialization of HistoryItems, I generate
DocumentSequenceNumbers that are unique across application launches.
DocumentSequenceNumbers are generated using a counter initialized with
the time of day.
Test: fast/loader/stateobjects/document-destroyed-navigate-back.html
- dom/Document.cpp: (WebCore::Document::detach):
- dom/Document.h:
- history/BackForwardList.cpp: (WebCore::BackForwardList::pushStateItem):
- history/BackForwardListChromium.cpp: (WebCore::BackForwardList::pushStateItem):
- history/HistoryItem.cpp: (WebCore::generateDocumentSequenceNumber): (WebCore::HistoryItem::HistoryItem): (WebCore::HistoryItem::~HistoryItem): (WebCore::HistoryItem::setStateObject):
- history/HistoryItem.h: (WebCore::HistoryItem::setDocumentSequenceNumber): (WebCore::HistoryItem::documentSequenceNumber):
- loader/FrameLoader.cpp: (WebCore::FrameLoader::navigateWithinDocument): (WebCore::FrameLoader::loadItem):
- loader/HistoryController.cpp: (WebCore::HistoryController::updateBackForwardListForFragmentScroll): (WebCore::HistoryController::pushState): (WebCore::HistoryController::replaceState):
- loader/RedirectScheduler.cpp: (WebCore::RedirectScheduler::scheduleHistoryNavigation):
- page/History.cpp: (WebCore::History::stateObjectAdded):
- page/Page.cpp: (WebCore::Page::goToItem):
- 1:14 PM Changeset in webkit [53949] by
-
- 6 edits in trunk/WebCore
2010-01-27 Oliver Hunt <oliver@apple.com>
Reviewed by Simon Fraser.
Animated scaling of background-image is too slow
https://bugs.webkit.org/show_bug.cgi?id=33808
Implement a version of the RenderImage animated scaling optimisation
for background images. Due to the possibility of arbitrary transforms
being applied to containing elements we explicitly check the current
CTM of the context for scaling or rotation.
- platform/graphics/GraphicsContext.cpp: (WebCore::GraphicsContext::drawTiledImage):
- platform/graphics/GraphicsContext.h:
- platform/graphics/transforms/TransformationMatrix.h: (WebCore::TransformationMatrix::isIdentityOrTranslation):
- rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelScaleData::RenderBoxModelScaleData): (WebCore::RenderBoxModelScaleData::~RenderBoxModelScaleData): (WebCore::RenderBoxModelScaleData::size): (WebCore::RenderBoxModelScaleData::time): (WebCore::RenderBoxModelScaleData::useLowQualityScale): (WebCore::RenderBoxModelScaleData::hiqhQualityRepaintTimer): (WebCore::RenderBoxModelScaleData::setSize): (WebCore::RenderBoxModelScaleData::setTime): (WebCore::RenderBoxModelScaleData::setUseLowQualityScale): (WebCore::RenderBoxModelScaleObserver::boxModelObjectDestroyed): (WebCore::RenderBoxModelScaleObserver::highQualityRepaintTimerFired): (WebCore::RenderBoxModelScaleObserver::shouldPaintBackgroundAtLowQuality): (WebCore::RenderBoxModelObject::highQualityRepaintTimerFired): (WebCore::RenderBoxModelObject::~RenderBoxModelObject): (WebCore::RenderBoxModelObject::paintFillLayerExtended):
- rendering/RenderBoxModelObject.h:
- 12:40 PM Changeset in webkit [53948] by
-
- 3 edits2 adds in trunk/WebKitTools
Rubberstamped by Simon Hausmann.
[Qt] QtLauncher refactoring:
Move out code from the MainWindow (renamed to LauncherWindow)
that is not depending on the view, and add it to a new class
called MainWindow.
- QtLauncher/QtLauncher.pro:
- QtLauncher/main.cpp:
(LauncherWindow::LauncherWindow):
(LauncherWindow::eventFilter):
(LauncherWindow::loadStarted):
(LauncherWindow::loadFinished):
(LauncherWindow::newWindow):
(LauncherWindow::setupUI):
(WebPage::createWindow):
(main):
- QtLauncher/mainwindow.cpp: Added.
(MainWindow::MainWindow):
(MainWindow::buildUI):
(MainWindow::page):
(MainWindow::setAddressUrl):
(MainWindow::addCompleterEntry):
(MainWindow::load):
(MainWindow::changeLocation):
(MainWindow::openFile):
- QtLauncher/mainwindow.h: Added.
- 12:16 PM Changeset in webkit [53947] by
-
- 6 edits1 copy in trunk
2010-01-27 Yael Aharon <yael.aharon@nokia.com>
Reviewed by Laszlo Gombos.
[Qt] Enable websockets support in QtWebKit
https://bugs.webkit.org/show_bug.cgi?id=34180
Remove websockets tests from skiplist.
- platform/qt/Skipped:
2010-01-27 Yael Aharon <yael.aharon@nokia.com>
Reviewed by Laszlo Gombos.
[Qt] Enable websockets support in QtWebKit
https://bugs.webkit.org/show_bug.cgi?id=34180
Connected between SocketStreamHandle and QTcpSocket/QSslSocket
to enable support for websockets.
Proxy authentication is not yet supported.
SSL certificate errors are ignored while this is under development.
- WebCore.pro:
- platform/network/qt/SocketStreamHandle.h:
- platform/network/qt/SocketStreamHandlePrivate.h: Added.
- platform/network/qt/SocketStreamHandleQt.cpp: (WebCore::SocketStreamHandlePrivate::SocketStreamHandlePrivate): (WebCore::SocketStreamHandlePrivate::~SocketStreamHandlePrivate): (WebCore::SocketStreamHandlePrivate::socketConnected): (WebCore::SocketStreamHandlePrivate::socketReadyRead): (WebCore::SocketStreamHandlePrivate::send): (WebCore::SocketStreamHandlePrivate::close): (WebCore::SocketStreamHandlePrivate::socketSentdata): (WebCore::SocketStreamHandlePrivate::socketClosed): (WebCore::SocketStreamHandlePrivate::socketError): (WebCore::SocketStreamHandlePrivate::socketClosedCallback): (WebCore::SocketStreamHandlePrivate::socketErrorCallback): (WebCore::SocketStreamHandlePrivate::socketSslErrors): (WebCore::SocketStreamHandle::SocketStreamHandle): (WebCore::SocketStreamHandle::~SocketStreamHandle): (WebCore::SocketStreamHandle::platformSend): (WebCore::SocketStreamHandle::platformClose):
- 12:00 PM Changeset in webkit [53946] by
-
- 4 edits2 adds in trunk
2010-01-27 Mads Ager <ager@chromium.org>
Reviewed by Dimitri Glazkov.
[V8] Support getting integer-named properties using indexing notation on document object
https://bugs.webkit.org/show_bug.cgi?id=34211
- fast/dom/HTMLDocument/get-iframe-with-integer-name-expected.txt: Added.
- fast/dom/HTMLDocument/get-iframe-with-integer-name.html: Added.
2010-01-27 Mads Ager <ager@chromium.org>
Reviewed by Dimitri Glazkov.
[V8] Support getting integer-named properties using indexing notation on document object
https://bugs.webkit.org/show_bug.cgi?id=34211
Add indexed property getter to HTMLDocument to support getting
elements with integer names using indexing notation on document.
Test: fast/dom/HTMLDocument/get-iframe-with-integer-name.html
- bindings/scripts/CodeGeneratorV8.pm:
- bindings/v8/custom/V8HTMLDocumentCustom.cpp: (WebCore::V8HTMLDocument::indexedPropertyGetter):
- 11:30 AM Changeset in webkit [53945] by
-
- 4 edits1 add in trunk/WebCore
2010-01-27 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Oliver Hunt.
Instead of relying on Object.prototype.toString result use JSObject::isActivationObject
to check if a scope node is a JSActivation. Object.prototype.toString for JSActivation
will call JSActivation::toThisObject whose result depends on the current call stack.
Test: WebCore/manual-tests/inspector/debugger-scopes-inspection.html
- bindings/js/JSInjectedScriptHostCustom.cpp: (WebCore::JSInjectedScriptHost::isActivation):
- inspector/InjectedScriptHost.idl:
- inspector/front-end/InjectedScript.js: (injectedScriptConstructor.):
- manual-tests/inspector/debugger-scopes-inspection.html: Added.
- 11:18 AM Changeset in webkit [53944] by
-
- 10 edits in trunk/WebCore
2010-01-27 Anton Muhin <antonm@google.com>
Review by Adam Barth.
Implement Node map in intrusive way for better speed.
https://bugs.webkit.org/show_bug.cgi?id=33957
- bindings/v8/DOMData.h: (WebCore::DOMData::removeObjectsFromWrapperMap):
- bindings/v8/DOMDataStore.cpp: (WebCore::DOMDataStore::IntrusiveDOMWrapperMap::get): (WebCore::DOMDataStore::IntrusiveDOMWrapperMap::set): (WebCore::DOMDataStore::IntrusiveDOMWrapperMap::removeIfPresent): (WebCore::DOMDataStore::IntrusiveDOMWrapperMap::contains): (WebCore::DOMDataStore::IntrusiveDOMWrapperMap::visit): (WebCore::DOMDataStore::IntrusiveDOMWrapperMap::clear): (WebCore::DOMDataStore::IntrusiveDOMWrapperMap::allocateTableEntry): (WebCore::DOMDataStore::IntrusiveDOMWrapperMap::freeTableEntry):
- bindings/v8/DOMDataStore.h: (WebCore::DOMDataStore::IntrusiveDOMWrapperMap::IntrusiveDOMWrapperMap): (WebCore::DOMDataStore::IntrusiveDOMWrapperMap::clearEntry): (WebCore::DOMDataStore::IntrusiveDOMWrapperMap::clearEntries): (WebCore::DOMDataStore::IntrusiveDOMWrapperMap::visitEntries): (WebCore::DOMDataStore::IntrusiveDOMWrapperMap::TableChunk::TableChunk): (WebCore::DOMDataStore::domNodeMap):
- bindings/v8/StaticDOMDataStore.cpp: (WebCore::StaticDOMDataStore::StaticDOMDataStore):
- bindings/v8/StaticDOMDataStore.h:
- bindings/v8/V8DOMMap.cpp: (WebCore::getDOMNodeMap):
- bindings/v8/V8DOMMap.h: (WebCore::AbstractWeakReferenceMap::AbstractWeakReferenceMap): (WebCore::AbstractWeakReferenceMap::weakReferenceCallback): (WebCore::WeakReferenceMap::WeakReferenceMap): (WebCore::WeakReferenceMap::set): (WebCore::WeakReferenceMap::visit):
- bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::convertDocumentToV8Object): (WebCore::getWrapper): (WebCore::V8DOMWrapper::convertNodeToV8Object): (WebCore::V8DOMWrapper::convertNewNodeToV8Object):
- bindings/v8/V8DOMWrapper.h:
- 11:15 AM Changeset in webkit [53943] by
-
- 3 edits in trunk/WebKit/chromium
2010-01-26 Darin Fisher <darin@chromium.org>
Reviewed by David Levin.
Add methods to support running a nested modal loop outside of WebKit.
https://bugs.webkit.org/show_bug.cgi?id=34199
- public/WebView.h:
- src/WebViewImpl.cpp: (WebKit::WebView::willEnterModalLoop): Create PageGroupLoadDeferrer (WebKit::WebView::didExitModalLoop): Destroy PageGroupLoadDeferrer
- 11:01 AM Changeset in webkit [53942] by
-
- 7 edits in trunk
2010-01-27 Kinuko Yasuda <kinuko@chromium.org>
Reviewed by Eric Seidel.
Remove fast/events/keydown-numpad-keys.html from gtk's Skipped list.
https://bugs.webkit.org/show_bug.cgi?id=28247
- platform/gtk/Skipped:
2010-01-27 Kinuko Yasuda <kinuko@chromium.org>
Reviewed by Eric Seidel.
Add key event mappings for numpad keys for Gtk and Chromium/Gtk.
http://bugs.webkit.org/show_bug.cgi?id=28247
Test: fast/events/keydown-numpad-keys.html
- platform/chromium/KeyCodeConversionGtk.cpp: (WebCore::windowsKeyCodeForKeyEvent):
- platform/gtk/KeyEventGtk.cpp: (WebCore::windowsKeyCodeForKeyEvent):
2010-01-27 Kinuko Yasuda <kinuko@chromium.org>
Reviewed by Eric Seidel.
Correctly handle the KeyLocation argument that has been introduced
recently to test location-dependent key events in EventSender.keyDown.
http://bugs.webkit.org/show_bug.cgi?id=28247
Test: fast/events/keydown-numpad-keys.html
- DumpRenderTree/gtk/EventSender.cpp: (keyDownCallback):
- 10:36 AM Changeset in webkit [53941] by
-
- 20 edits1 delete in trunk/WebCore
2010-01-27 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: migrate from SourceFrame to SourceFrame2.
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- bindings/js/JSInspectorFrontendHostCustom.cpp:
- bindings/v8/custom/V8InspectorFrontendHostCustom.cpp:
- inspector/InspectorFrontendHost.cpp:
- inspector/InspectorFrontendHost.h:
- inspector/InspectorFrontendHost.idl:
- inspector/front-end/InspectorBackendStub.js:
- inspector/front-end/InspectorFrontendHostStub.js:
- inspector/front-end/ResourceView.js: (WebInspector.ResourceView.prototype._innerSelectContentTab):
- inspector/front-end/ResourcesPanel.js: (WebInspector.getResourceContent):
- inspector/front-end/ScriptView.js: (WebInspector.ScriptView): (WebInspector.ScriptView.prototype.setupSourceFrameIfNeeded):
- inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype._sidebarResizeDrag):
- inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame): (WebInspector.SourceFrame.prototype.set executionLine): (WebInspector.SourceFrame.prototype.revealLine): (WebInspector.SourceFrame.prototype.addBreakpoint): (WebInspector.SourceFrame.prototype.removeBreakpoint): (WebInspector.SourceFrame.prototype.addMessage): (WebInspector.SourceFrame.prototype.clearMessages): (WebInspector.SourceFrame.prototype.sizeToFitContentHeight): (WebInspector.SourceFrame.prototype.setContent): (WebInspector.SourceFrame.prototype.findSearchMatches): (WebInspector.SourceFrame.prototype._collectRegexMatches): (WebInspector.SourceFrame.prototype.setSelection): (WebInspector.SourceFrame.prototype._incrementMessageRepeatCount): (WebInspector.SourceFrame.prototype._addExistingMessagesToSource): (WebInspector.SourceFrame.prototype._addMessageToSource): (WebInspector.SourceFrame.prototype._addExistingBreakpointsToSource): (WebInspector.SourceFrame.prototype._addBreakpointToSource): (WebInspector.SourceFrame.prototype._removeBreakpointFromSource): (WebInspector.SourceFrame.prototype._contextMenu.addConditionalBreakpoint): (WebInspector.SourceFrame.prototype._contextMenu): (WebInspector.SourceFrame.prototype._toggleBreakpoint): (WebInspector.SourceFrame.prototype._editBreakpointCondition.committed): (WebInspector.SourceFrame.prototype._editBreakpointCondition.dismissed): (WebInspector.SourceFrame.prototype._editBreakpointCondition): (WebInspector.SourceFrame.prototype._showBreakpointConditionPopup): (WebInspector.SourceFrame.prototype._createConditionElement): (WebInspector.SourceFrame.prototype._keyDown): (WebInspector.SourceFrame.prototype._evalSelectionInCallFrame): (WebInspector.SourceFrame.prototype._breakpointChanged): (WebInspector.SourceFrame.prototype.resize): (WebInspector.BreakpointLineNumberDecorator): (WebInspector.BreakpointLineNumberDecorator.prototype.decorate): (WebInspector.BreakpointLineNumberDecorator.prototype._paintBreakpoint): (WebInspector.BreakpointLineNumberDecorator.prototype._paintProgramCounter): (WebInspector.BreakpointLineNumberDecorator.prototype.mouseDown): (WebInspector.BreakpointLineNumberDecorator.prototype.contextMenu): (WebInspector.ExecutionLineDecorator): (WebInspector.ExecutionLineDecorator.prototype.decorate):
- inspector/front-end/SourceFrame2.js: Removed.
- inspector/front-end/SourceView.js: (WebInspector.SourceView): (WebInspector.SourceView.prototype.show): (WebInspector.SourceView.prototype.resize): (WebInspector.SourceView.prototype.setupSourceFrameIfNeeded): (WebInspector.SourceView.prototype._contentLoaded): (WebInspector.SourceView.prototype.performSearch.findSearchMatches): (WebInspector.SourceView.prototype.performSearch): (WebInspector.SourceView.prototype._jumpToSearchResult): (WebInspector.SourceView.prototype._sourceFrameSetupFinished):
- inspector/front-end/TextEditor.js: (WebInspector.TextEditor.prototype._mouseDown): (WebInspector.TextEditor.prototype._copy.delayCopy): (WebInspector.TextEditor.prototype._copy): (WebInspector.TextEditor.prototype._cut):
- inspector/front-end/WebKit.qrc:
- inspector/front-end/inspector.html:
- 10:19 AM Changeset in webkit [53940] by
-
- 2 edits in trunk/WebCore
2010-01-27 Dominik Röttsches <dominik.roettsches@access-company.com>
Reviewed by Xan Lopez.
[Gtk] For removing ICU, implement IDN support by means of libidn
https://bugs.webkit.org/show_bug.cgi?id=31470
In order to avoid a new dependency,
IDN support now based on GLib for the GLib unicode backend.
- platform/KURL.cpp: (WebCore::appendEncodedHostname):
- 9:55 AM Changeset in webkit [53939] by
-
- 3 edits1 add in trunk/WebKit/chromium
2010-01-27 Darin Fisher <darin@chromium.org>
Reviewed by Dimitri Glazkov.
Adding missing WebMutationEvent.cpp file to fix build bustage.
https://bugs.webkit.org/show_bug.cgi?id=33882
- public/WebMutationEvent.h: Remove unnecessary constructor.
- src/WebEvent.cpp: Remove unnecessary include of WebMutationEvent.h.
- src/WebMutationEvent.cpp: Added.
- 9:43 AM Changeset in webkit [53938] by
-
- 2 edits in trunk/WebKitTools
Rubberstamped by Simon Hausmann.
[Qt] QtLauncher, coding style fixes.
- QtLauncher/main.cpp:
(MainWindow::MainWindow):
(MainWindow::sendTouchEvent):
(MainWindow::eventFilter):
(MainWindow::loadURL):
(MainWindow::setupUI):
(WebPage::createPlugin):
- 9:41 AM BuildingOnWindows edited by
- (diff)
- 9:40 AM BuildingOnWindows edited by
- (diff)
- 9:02 AM Changeset in webkit [53937] by
-
- 4 edits2 copies in trunk/WebKitTools
Rubberstamped by Simon Hausmann.
[Qt] QtLauncher refactoring, separating the webview and
adding a QGraphicsWebView based version.
- QtLauncher/QtLauncher.pro:
- QtLauncher/main.cpp:
(MainWindow::MainWindow):
- QtLauncher/webpage.h:
- QtLauncher/webview.cpp: Added.
(createContextMenu):
(WebViewGraphicsBased::mousePressEvent):
(WebViewTraditional::mousePressEvent):
(WebViewGraphicsBased::contextMenuEvent):
(WebViewTraditional::contextMenuEvent):
- QtLauncher/webview.h: Added.
(WebViewGraphicsBased::WebViewGraphicsBased):
(WebViewTraditional::WebViewTraditional):
- 8:14 AM Changeset in webkit [53936] by
-
- 2 edits in trunk/WebKit/qt
[Qt] Update the .def files with exported symbols
Reviewed by Laszlo Gombos.
- symbian/eabi/QtWebKitu.def: Add two mangled missing new symbols for arm eabi.
- 8:06 AM Changeset in webkit [53935] by
-
- 4 edits in trunk
.: [Qt] Don't build the tests in packages, only the launcher(s)
Reviewed by Kenneth Rohde Christiansen.
- WebKit.pro:
WebCore: [Qt] For package builds use the .def files on Symbian
Reviewed by Kenneth Rohde Christiansen.
- WebCore.pro:
- 7:15 AM Changeset in webkit [53934] by
-
- 6 edits9 adds in trunk/WebKit/chromium
2010-01-27 Jay Campan <jcampan@google.com>
Reviewed by Darin Fisher.
Adding EventListeners to the chromium API.
- WebKit.gyp:
- public/WebEvent.h: Added.
- public/WebEventListener.h: Added.
- public/WebMutationEvent.h: Added.
- public/WebNode.h:
- public/WebString.h: (WebKit::operator==): (WebKit::operator!=):
- src/EventListenerWrapper.cpp: Added.
- src/EventListenerWrapper.h: Added.
- src/WebEvent.cpp: Added.
- src/WebEventListener.cpp: Added.
- src/WebEventListenerPrivate.cpp: Added.
- src/WebEventListenerPrivate.h: Added.
- src/WebNode.cpp: (WebKit::WebNode::addEventListener): (WebKit::WebNode::removeEventListener):
- src/WebString.cpp: (WebKit::WebString::equals):
- 6:58 AM Changeset in webkit [53933] by
-
- 2 edits in trunk/WebCore
2010-01-27 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Timothy Hatcher.
Avoid watch expressions duplication
https://bugs.webkit.org/show_bug.cgi?id=33996
- inspector/front-end/WatchExpressionsSidebarPane.js: (WebInspector.WatchExpressionsSidebarPane.prototype._settingsLoaded):
- 6:47 AM Changeset in webkit [53932] by
-
- 2 edits in trunk/WebKitTools
2010-01-27 Alexander Pavlov <apavlov@chromium.org>
Adding myself as committer. No review necessary.
- Scripts/webkitpy/committers.py:
- 6:41 AM Changeset in webkit [53931] by
-
- 12 edits2 adds in trunk/WebCore
2010-01-27 Marcus Bulach <bulach@chromium.org>
Reviewed by Dimitri Glazkov.
Adds EventSource bindings for V8
https://bugs.webkit.org/show_bug.cgi?id=33695
No new tests (existing layout tests for EventSource should pass).
- Android.v8bindings.mk:
- WebCore.gypi:
- bindings/scripts/CodeGeneratorV8.pm:
- bindings/v8/DOMObjectsInclude.h:
- bindings/v8/DerivedSourcesAllInOne.cpp:
- bindings/v8/V8DOMWrapper.cpp:
- bindings/v8/V8DOMWrapper.h:
- bindings/v8/V8Index.cpp:
- bindings/v8/V8Index.h:
- bindings/v8/WorkerContextExecutionProxy.cpp:
- bindings/v8/custom/V8CustomBinding.h:
- bindings/v8/custom/V8EventSourceConstructor.cpp: Added.
- bindings/v8/custom/V8EventSourceCustom.cpp: Added.
- 6:25 AM Changeset in webkit [53930] by
-
- 5 edits in trunk
2010-01-27 Kent Hansen <kent.hansen@nokia.com>
Reviewed by Simon Hausmann.
[Qt] Meta-methods can't be introspected using ES5 API
https://bugs.webkit.org/show_bug.cgi?id=34087
Add getOwnPropertyDescriptor() and getOwnPropertyNames() reimplementations.
Tests are in WebKit/qt/tests/qwebframe
- bridge/qt/qt_runtime.cpp: (JSC::Bindings::QtRuntimeMetaMethod::getOwnPropertyDescriptor): (JSC::Bindings::QtRuntimeMetaMethod::getOwnPropertyNames): (JSC::Bindings::QtRuntimeConnectionMethod::getOwnPropertyDescriptor): (JSC::Bindings::QtRuntimeConnectionMethod::getOwnPropertyNames):
- bridge/qt/qt_runtime.h:
2010-01-27 Kent Hansen <kent.hansen@nokia.com>
Reviewed by Simon Hausmann.
[Qt] Meta-methods can't be introspected using ES5 API
https://bugs.webkit.org/show_bug.cgi?id=34087
Test that Object.getOwnPropertyDescriptor and
Object.getOwnPropertyNames work with meta-methods.
- tests/qwebframe/tst_qwebframe.cpp:
- 6:21 AM Changeset in webkit [53929] by
-
- 3 edits2 adds in trunk/WebKitTools
Rubberstamped by Simon Hausmann
[Qt] QtLauncher refactoring, separating utility methods.
- QtLauncher/QtLauncher.pro:
- QtLauncher/main.cpp:
- QtLauncher/utils.cpp: Added.
(urlFromUserInput):
- QtLauncher/utils.h: Added.
- 6:07 AM Changeset in webkit [53928] by
-
- 2 edits in trunk/JavaScriptCore
2010-01-27 Kwang Yul Seo <skyul@company100.net>
Reviewed by Eric Seidel.
[BREWMP] Port WTF's randomNumber
https://bugs.webkit.org/show_bug.cgi?id=33566
Use GETRAND to generate 4 byte random byte sequence to implement
weakRandomNumber. Create a secure random number generator with
AEECLSID_RANDOM to implement randomNumber.
- wtf/RandomNumber.cpp: (WTF::weakRandomNumber): (WTF::randomNumber):
- 5:51 AM Changeset in webkit [53927] by
-
- 3 edits2 adds in trunk
2010-01-27 Tony Chang <tony@chromium.org>
Reviewed by Eric Seidel.
Fix a crash when trying to indent a block element that was contained
in a list. This was happening because enclosingBlock() in
htmlediting.cpp can return the current the same Node when a block
element (like an <hr> or a <table>) is passed in. This causes
the indent command to think that it is not in a list item.
Work around this by checking to see if enclosingBlock returned the
same Node.
- editing/execCommand/indent-block-in-list-expected.txt: Added.
- editing/execCommand/indent-block-in-list.html: Added.
2010-01-27 Tony Chang <tony@chromium.org>
Reviewed by Eric Seidel.
Fix a crash when trying to indent a block element that was contained
in a list. This was happening because enclosingBlock() in
htmlediting.cpp can return the current the same Node when a block
element (like an <hr> or a <table>) is passed in. This causes
the indent command to think that it is not in a list item.
Work around this by checking to see if enclosingBlock returned the
same Node.
Test: editing/execCommand/indent-block-in-list.html
- editing/IndentOutdentCommand.cpp: (WebCore::IndentOutdentCommand::tryIndentingAsListItem):
- 5:34 AM Changeset in webkit [53926] by
-
- 2 edits in trunk/JavaScriptCore
2010-01-27 Kwang Yul Seo <skyul@company100.net>
Reviewed by Eric Seidel.
[BREWMP] Port getCPUTime
https://bugs.webkit.org/show_bug.cgi?id=33572
Use GETUPTIMEMS which returns a continuously and
linearly increasing millisecond timer from the time the device
was powered on. This function is enough to implement getCPUTime.
- runtime/TimeoutChecker.cpp: (JSC::getCPUTime):
- 5:01 AM Changeset in webkit [53925] by
-
- 9 edits1 copy1 add in trunk/WebKitTools
2010-01-27 Eric Seidel <eric@webkit.org>
Reviewed by Darin Adler.
webkit-patch needs an open-bugs command
https://bugs.webkit.org/show_bug.cgi?id=30793
- Scripts/test-webkitpy: import OpenBugsTest
- Scripts/webkit-patch: import OpenBugs
- Scripts/webkitpy/commands/download_unittest.py: don't import unittest
- Scripts/webkitpy/commands/early_warning_system_unittest.py: ditto
- Scripts/webkitpy/commands/queries_unittest.py: ditto
- Scripts/webkitpy/commands/queues_unittest.py: ditto
- Scripts/webkitpy/commands/upload_unittest.py: ditto
- Scripts/webkitpy/mock_bugzillatool.py: log when user.open_url is called.
- 4:43 AM Changeset in webkit [53924] by
-
- 4 edits in trunk
[Qt] Add the "d" suffix to QtWebKit's dll on Windows.
Reviewed by Tor Arne Vestbø.
- WebKit.pri:
WebCore:
- WebCore.pro:
- 4:41 AM Changeset in webkit [53923] by
-
- 1 edit1 delete in trunk/LayoutTests
[Qt] Qt port doesn't need platform dependent expected file anymore
for editing/pasteboard/paste-noscript-xhtml.html from r53873.
- platform/qt/editing/pasteboard/paste-noscript-xhtml-expected.txt: Removed.
- 4:41 AM Changeset in webkit [53922] by
-
- 2 edits1 add in trunk/JavaScriptCore
2010-01-27 Kwang Yul Seo <skyul@company100.net>
Reviewed by Oliver Hunt.
[BREWMP] Add MarkStack fastMalloc implementation for platforms without VirtualAlloc or mmap.
https://bugs.webkit.org/show_bug.cgi?id=33582
Use fastMalloc and fastFree to implement MarkStack::allocateStack and
MarkStack::releaseStack for platforms without page level allocation.
- runtime/MarkStack.h: (JSC::MarkStack::MarkStackArray::shrinkAllocation):
- runtime/MarkStackNone.cpp: Added. (JSC::MarkStack::initializePagesize): (JSC::MarkStack::allocateStack): (JSC::MarkStack::releaseStack):
- 4:17 AM Changeset in webkit [53921] by
-
- 2 edits in trunk/JavaScriptCore
2010-01-27 Kwang Yul Seo <skyul@company100.net>
Reviewed by Eric Seidel.
[BREWMP] Don't use time function
https://bugs.webkit.org/show_bug.cgi?id=33577
Calling time(0) in BREW devices causes a crash because time
is not properly ported in most devices. Cast currentTime() to
time_t to get the same result as time(0).
- wtf/DateMath.cpp: (WTF::calculateUTCOffset):
- 4:10 AM Changeset in webkit [53920] by
-
- 2 edits in trunk/LayoutTests
[Qt] fast/backgrounds/animated-svg-as-background.html make fast/backgrounds/svg-as-background-5.html crash.
https://bugs.webkit.org/show_bug.cgi?id=34202
- platform/qt/Skipped: fast/backgrounds/animated-svg-as-background.html enabled because bug rolled out by r53912.
- 3:56 AM Changeset in webkit [53919] by
-
- 4 edits in trunk/WebKitTools
Rubberstamped by Simon Hausmann
[Qt] Refactor the code in the QtLauncher dealing with HTTP proxy.
- QtLauncher/main.cpp:
(MainWindow::MainWindow):
- QtLauncher/webpage.cpp:
(WebPage::WebPage):
(WebPage::applyProxy):
- QtLauncher/webpage.h:
- 3:51 AM Changeset in webkit [53918] by
-
- 2 edits in trunk
[Qt] Build fix for windows when QTDIR contains release libraries.
Unreviewed build fix
- WebKit.pri: Use the <name>.lib syntax for linking instead of qmake's -l<name> emulation
- 3:43 AM Changeset in webkit [53917] by
-
- 3 edits6 adds in trunk
2010-01-27 Matt Perry <mpcomplete@chromium.org>
Reviewed by Eric Seidel.
Fix a bug where dispatchDocumentElementAvailable was fired for fragment parsing on XML documents.
https://bugs.webkit.org/show_bug.cgi?id=33920
- userscripts/resources: Added.
- userscripts/resources/blank.xhtml: Added.
- userscripts/script-not-run-for-fragments-expected.txt: Added.
- userscripts/script-not-run-for-fragments.html: Added.
- userscripts/script-run-at-start-expected.txt: Added.
- userscripts/script-run-at-start.html: Added.
2010-01-27 Matt Perry <mpcomplete@chromium.org>
Reviewed by Eric Seidel.
Fix a bug where dispatchDocumentElementAvailable was fired for fragment parsing on XML documents.
https://bugs.webkit.org/show_bug.cgi?id=33920
Tests: userscripts/script-not-run-for-fragments.html
userscripts/script-run-at-start.html
- dom/XMLTokenizerLibxml2.cpp: (WebCore::XMLTokenizer::startElementNs):
- 3:18 AM Changeset in webkit [53916] by
-
- 3 edits in trunk/WebCore
2010-01-27 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: Improve SourceHTMLTokenizer so that it treats script tag well.
- inspector/front-end/SourceHTMLTokenizer.js: (WebInspector.SourceHTMLTokenizer): (WebInspector.SourceHTMLTokenizer.prototype._isAttribute): (WebInspector.SourceHTMLTokenizer.prototype._isAttributeValue): (WebInspector.SourceHTMLTokenizer.prototype._setAttributeValue): (WebInspector.SourceHTMLTokenizer.prototype._setAttribute): (WebInspector.SourceHTMLTokenizer.prototype._stringToken): (WebInspector.SourceHTMLTokenizer.prototype.nextToken):
- inspector/front-end/SourceHTMLTokenizer.re2js:
- 3:16 AM Changeset in webkit [53915] by
-
- 8 edits6 deletes in trunk/WebCore
2010-01-27 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: nuke quarantine wrappers.
- Android.jscbindings.mk:
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- bindings/js/JSBindingsAllInOne.cpp:
- bindings/js/JSInspectedObjectWrapper.cpp: Removed.
- bindings/js/JSInspectedObjectWrapper.h: Removed.
- bindings/js/JSInspectorCallbackWrapper.cpp: Removed.
- bindings/js/JSInspectorCallbackWrapper.h: Removed.
- bindings/js/JSQuarantinedObjectWrapper.cpp: Removed.
- bindings/js/JSQuarantinedObjectWrapper.h: Removed.
- 2:41 AM BuildingOnWindows edited by
- (diff)
- 1:49 AM Changeset in webkit [53914] by
-
- 2 edits in trunk/WebKitTools
[Qt] Corrects debug build of DumpRenderTree on Windows.
Reviewed by Tor Arne Vestbø.
- DumpRenderTree/qt/DumpRenderTree.pro:
- 1:09 AM Changeset in webkit [53913] by
-
- 2 edits in trunk
Fix a typo in ChangeLogs.
- 1:06 AM Changeset in webkit [53912] by
-
- 21 edits in trunk
Revert r53899 (HashMap<AtomicStringImpl*, Value> key checks) and subsequent bug fixes,
because they make SVG tests crash in release builds.
- 12:41 AM Changeset in webkit [53911] by
-
- 2 edits in trunk/LayoutTests
[Qt] fast/backgrounds/animated-svg-as-background.html make fast/backgrounds/svg-as-background-5.html crash.
https://bugs.webkit.org/show_bug.cgi?id=34202
- platform/qt/Skipped: fast/backgrounds/animated-svg-as-background.html skipped until fix.
- 12:36 AM Changeset in webkit [53910] by
-
- 3 edits in trunk/WebCore
2010-01-25 Philippe Normand <pnormand@igalia.com>
Reviewed by Eric Seidel.
autobuffer value not forwarded media element to MediaPlayer
https://bugs.webkit.org/show_bug.cgi?id=33889
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::loadResource): Forward autobuffer value to MediaPlayer instance.
- platform/graphics/MediaPlayer.cpp: (WebCore::MediaPlayer::load): Forward autobuffer and preservesPitch values to newly created platform media player instance.
- 12:24 AM Changeset in webkit [53909] by
-
- 5 edits in trunk
2010-01-25 Philippe Normand <pnormand@igalia.com>
Reviewed by Eric Seidel.
[Gtk] media/video-reverse-play-duration.html fails on and off on Gtk buildbots
https://bugs.webkit.org/show_bug.cgi?id=34086
Cache media duration and fix didEnd() in case of reverse
playback. When EOS was reached but in case of reverse playback the
position is not always 0. So to not confuse the HTMLMediaElement
we synchronize position and duration values.
- platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivate::MediaPlayerPrivate): (WebCore::MediaPlayerPrivate::duration): (WebCore::MediaPlayerPrivate::updateStates): (WebCore::MediaPlayerPrivate::didEnd): (WebCore::MediaPlayerPrivate::durationChanged):
- platform/graphics/gtk/MediaPlayerPrivateGStreamer.h:
2010-01-25 Philippe Normand <pnormand@igalia.com>
Reviewed by Eric Seidel.
[Gtk] media/video-reverse-play-duration.html fails on and off on Gtk buildbots
https://bugs.webkit.org/show_bug.cgi?id=34086
- platform/gtk/Skipped: Unskip fixed test.
- 12:06 AM Changeset in webkit [53908] by
-
- 2 edits in trunk/WebCore
- WebCore.xcodeproj/project.pbxproj: Actually land the change to add ContainerNodeAlgorithms.h (it's "svn resolved", not "svn revert"!).
Jan 26, 2010:
- 11:54 PM Changeset in webkit [53907] by
-
- 2 edits in trunk/LayoutTests
2010-01-26 Daniel Bates <dbates@webkit.org>
Unreviewed. Made a minor typo when I added the test case fast/css/button-height.html
to the GTK Skipped file. In changeset 53900, I added test "fast/css/button-height.htm"
to the GTK Skipped file instead of "fast/css/button-height.html". See bug #33936
for more details.
- platform/gtk/Skipped:
- 11:53 PM Changeset in webkit [53906] by
-
- 2 edits in trunk/LayoutTests
[Qt] Failing tests after r53895 skipped.
https://bugs.webkit.org/show_bug.cgi?id=34167
- platform/qt/Skipped:
- http/tests/history/redirect-301.pl
- http/tests/history/redirect-302.pl
- http/tests/history/redirect-303.pl
- http/tests/history/redirect-307.pl
- 11:46 PM Changeset in webkit [53905] by
-
- 2 edits in trunk/LayoutTests
Unreviewed trivial fix.
- platform/qt/editing/pasteboard/paste-noscript-xhtml-expected.txt: updated after r53873.
- 11:02 PM Changeset in webkit [53904] by
-
- 2 edits in trunk/WebKitLibraries
More Windows build fixing.
- win/tools/vsprops/common.vsprops: Disable warning C4180 (qualifier applied to function type has no meaning; ignored). This is a known bug - MSVC tries to compile a wrong specialization sometimes - but it's not instantiated, so it's harmless.
- 10:39 PM Changeset in webkit [53903] by
-
- 2 edits in trunk/JavaScriptCore
More Windows build fixing.
- wtf/HashTraits.h: _msize takes void*, remove const qualifier from type.
- 10:22 PM Changeset in webkit [53902] by
-
- 2 edits in trunk/JavaScriptCore
Windows build fix.
- wtf/HashTraits.h: Include malloc.h for _msize().
- 10:19 PM Changeset in webkit [53901] by
-
- 2 edits in trunk/JavaScriptCore
Build fix.
- wtf/HashTable.h: (WTF::HashTable::checkTableConsistencyExceptSize): Remove const from a static (empty) version of this function.
- 10:07 PM Changeset in webkit [53900] by
-
- 3 edits in trunk/LayoutTests
2010-01-26 Daniel Bates <dbates@webkit.org>
Unreviewed. Updated expected failing results for table-percent-height.html
to reflect one pixel difference between the results generated by the Qt bot
and my machine. Added failing test fast/css/button-height.html to GTK Skipped
file as we need to look into this. See bug #33936 for more details.
- platform/gtk/Skipped: Added failing test fast/css/button-height.html.
- platform/qt/fast/replaced/table-percent-height-expected.txt: Updated result.
- 9:57 PM Changeset in webkit [53899] by
-
- 21 edits in trunk
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=34150
WebKit needs a mechanism to catch stale HashMap entries
It is very difficult to catch stale pointers that are HashMap keys - since a pointer's hash
is just its value, it is very unlikely that any observable problem is reproducible.
This extends hash table consistency checks to check that pointers are referencing allocated
memory blocks, and makes it possible to invoke the checks explicitly (it is not feasible
to enable CHECK_HASHTABLE_CONSISTENCY by default, because that affects performance too much).
- wtf/HashMap.h: (WTF::::checkConsistency): Call through to HashTable implementation. We can add similar calls to HashSet and HashCountedSet, but I haven't seen hard to debug problems with those yet.
- wtf/HashSet.h: (WTF::::remove): The version of checkTableConsistency that's guarded by CHECK_HASHTABLE_CONSISTENCY is now called internalCheckTableConsistency().
- wtf/HashTable.h: (WTF::HashTable::internalCheckTableConsistency): (WTF::HashTable::internalCheckTableConsistencyExceptSize): (WTF::HashTable::checkTableConsistencyExceptSize): Expose checkTableConsistency() even if CHECK_HASHTABLE_CONSISTENCY is off. (WTF::::add): Updated for checkTableConsistency renaming. (WTF::::addPassingHashCode): Ditto. (WTF::::removeAndInvalidate): Ditto. (WTF::::remove): Ditto. (WTF::::rehash): Ditto. (WTF::::checkTableConsistency): The assertion for !shouldExpand() was not correct - this function returns true for tables with m_table == 0. (WTF::::checkTableConsistencyExceptSize): Call checkValueConsistency for key. Potentially, we could do the same for values.
- wtf/HashTraits.h: (WTF::GenericHashTraits::checkValueConsistency): An empty function that can be overridden to add checks. Currently, the only override is for pointer hashes.
- wtf/RefPtrHashMap.h: (WTF::::remove): Updated for checkTableConsistency renaming.
- 9:54 PM Changeset in webkit [53898] by
-
- 2 edits1 add in trunk/WebKit/chromium
2010-01-26 Yaar Schnitman <yaar@chromium.org>
Reviewed by Darin Fisher.
Add KeyboardTest to WebKit API tests
https://bugs.webkit.org/show_bug.cgi?id=34178
- WebKit.gyp:
- tests/KeyboardTest.cpp: Added.
- 9:29 PM Changeset in webkit [53897] by
-
- 5 edits3 adds in trunk
2010-01-26 Daniel Bates <dbates@webkit.org>
Reviewed by Tor Arne Vestbø.
[Qt] Fixes an issue where the height of <button>- and
<input type="button">- elements are fixed to the height of the
button label font plus padding. That is, the CSS height property
is being ignored.
Instead, we should honor the user-specified height, if appropriate
for the platform and context. Notice, the Mac ports do not honor the
height for <input type="button"> elements unless a border and/or
background is also specified.
Test: fast/css/button-height.html
- platform/qt/RenderThemeQt.cpp: (WebCore::RenderThemeQt::adjustButtonStyle):
2010-01-26 Daniel Bates <dbates@webkit.org>
Reviewed by Tor Arne Vestbø.
Tests that the user-specified height for <button>- and <input type="button">-
elements are honored, if appropriate for the platform and context.
- fast/css/button-height-expected.txt: Added.
- fast/css/button-height.html: Added.
- fast/replaced/table-percent-height-expected.txt: Added notice about failing tests in Windows ports.
- fast/replaced/table-percent-height.html: Ditto.
- platform/qt/fast/replaced/table-percent-height-expected.txt: Added.
- 9:26 PM Changeset in webkit [53896] by
-
- 4 edits in trunk/WebKitTools
2010-01-26 Daniel Bates <dbates@webkit.org>
Reviewed by Adam Barth.
Moves the try/catch for OSError exceptions in Executive.run_command
to Credentials.read_credentials() so that the unit test
webkitpy.scm_unittest.SCMClassTests.test_error_handlers can
assert that Executive.run_command throws an OSError exception.
- Scripts/webkitpy/credentials.py:
- Scripts/webkitpy/executive.py: Moved try/catch for OSError to method Credentials.read_credentials().
- Scripts/webkitpy/executive_unittest.py: Removed tests that no longer apply: test_run_command_with_bad_command_check_return_code and test_run_command_with_bad_command_check_calls_error_handler. Added new test to assert that run_command throws OSError exceptions.
- 9:21 PM Changeset in webkit [53895] by
-
- 5 edits in trunk
2010-01-26 Diego Gonzalez <diego.gonzalez@openbossa.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] DRT WebHistory support
https://bugs.webkit.org/show_bug.cgi?id=34167
- platform/qt/Skipped:
2010-01-26 Diego Gonzalez <diego.gonzalez@openbossa.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] DRT WebHistory support
https://bugs.webkit.org/show_bug.cgi?id=34167
- DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::reset): (LayoutTestController::webHistoryItemCount): (LayoutTestController::keepWebHistory):
- DumpRenderTree/qt/LayoutTestControllerQt.h:
- 9:04 PM Changeset in webkit [53894] by
-
- 2 edits in trunk/WebCore
2010-01-26 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Timothy Hatcher.
Enable the Audits panel via a shortcut (Cmd/Ctrl+Alt+A)
https://bugs.webkit.org/show_bug.cgi?id=34158
- inspector/front-end/inspector.js: (WebInspector.documentKeyDown):
- 8:45 PM Changeset in webkit [53893] by
-
- 5 edits24 adds in trunk
2010-01-26 Kent Tamura <tkent@chromium.org>
Reviewed by Darin Adler.
HTMLInputElement::valueAsNumber support except type=datetime-local.
https://bugs.webkit.org/show_bug.cgi?id=32696
input-valueasnumber-datetime-expected.txt and
input-valueasnumber-time-expected.txt have FAIL lines because they
test unimplemented features.
- fast/forms/input-valueasnumber-date-expected.txt: Added.
- fast/forms/input-valueasnumber-date.html: Added.
- fast/forms/input-valueasnumber-datetime-expected.txt: Added.
- fast/forms/input-valueasnumber-datetime.html: Added.
- fast/forms/input-valueasnumber-month-expected.txt: Added.
- fast/forms/input-valueasnumber-month.html: Added.
- fast/forms/input-valueasnumber-number-expected.txt: Added.
- fast/forms/input-valueasnumber-number.html: Added.
- fast/forms/input-valueasnumber-range-expected.txt: Added.
- fast/forms/input-valueasnumber-range.html: Added.
- fast/forms/input-valueasnumber-time-expected.txt: Added.
- fast/forms/input-valueasnumber-time.html: Added.
- fast/forms/input-valueasnumber-unsupported-expected.txt: Added.
- fast/forms/input-valueasnumber-unsupported.html: Added.
- fast/forms/input-valueasnumber-week-expected.txt: Added.
- fast/forms/input-valueasnumber-week.html: Added.
- fast/forms/script-tests/input-valueasnumber-date.js: Added.
- fast/forms/script-tests/input-valueasnumber-datetime.js: Added.
- fast/forms/script-tests/input-valueasnumber-month.js: Added.
- fast/forms/script-tests/input-valueasnumber-number.js: Added.
- fast/forms/script-tests/input-valueasnumber-range.js: Added.
- fast/forms/script-tests/input-valueasnumber-time.js: Added.
- fast/forms/script-tests/input-valueasnumber-unsupported.js: Added.
- fast/forms/script-tests/input-valueasnumber-week.js: Added.
2010-01-26 Kent Tamura <tkent@chromium.org>
Reviewed by Darin Adler.
HTMLInputElement::valueAsNumber support except type=datetime-local.
https://bugs.webkit.org/show_bug.cgi?id=32696
Tests: fast/forms/input-valueasnumber-date.html
fast/forms/input-valueasnumber-datetime.html
fast/forms/input-valueasnumber-month.html
fast/forms/input-valueasnumber-number.html
fast/forms/input-valueasnumber-range.html
fast/forms/input-valueasnumber-time.html
fast/forms/input-valueasnumber-unsupported.html
fast/forms/input-valueasnumber-week.html
- html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::valueAsNumber): According to the specification, we should return NaN for invalid values. (WebCore::HTMLInputElement::setValueAsNumber): According to the specification, throws NOT_SUPPORTED_ERR for Infinitiy or NaN, and throws INVALID_STATE_ERR for unsupported types. (WebCore::HTMLInputElement::formStringToDouble): According to the step 14 of Real Number in the specification, we should round -0 to 0.
- html/HTMLInputElement.h: Declare valueAsNumber() and setValueAsNumber().
- html/HTMLInputElement.idl: Add valueAsNumber.
- 8:44 PM WebKit Team edited by
- add my nick (diff)
- 8:41 PM Changeset in webkit [53892] by
-
- 2 edits in trunk/WebCore
Make sure there is a lock on serialize in SerializedScriptValueData, since type errors can be created when
exceptions are thrown.
Reviewed by Oliver Hunt.
- bindings/js/SerializedScriptValue.cpp:
(WebCore::SerializedScriptValueData::serialize):
- 8:20 PM Changeset in webkit [53891] by
-
- 2 edits in trunk/JavaScriptCore
2010-01-26 Lyon Chen <liachen@rim.com>
Reviewed by Maciej Stachowiak.
Opcode.h use const void* for Opcode cause error #1211 for RVCT compiler
https://bugs.webkit.org/show_bug.cgi?id=33902
- bytecode/Opcode.h:
- 8:17 PM Changeset in webkit [53890] by
-
- 7 edits in trunk/WebCore
2010-01-26 Kent Tamura <tkent@chromium.org>
Reviewed by Eric Seidel.
Add Date type support for Objective-C binding.
https://bugs.webkit.org/show_bug.cgi?id=32810
The Date type in IDLs is mapped to NSTimeInterval in Objective-C.
- bindings/objc/DOMInternal.h: Add kit() and core() for NSTimeInterval.
- bindings/scripts/CodeGenerator.pm: Make Date a primitive type.
- bindings/scripts/CodeGeneratorJS.pm: Move some code for the CodeGeenrator.pm change.
- bindings/scripts/CodeGeneratorObjC.pm:
- bindings/scripts/CodeGeneratorV8.pm: Move some code for the CodeGeenrator.pm change.
- html/HTMLInputElement.idl: Remove Objective-C exclusion for valueAsDate.
- 8:09 PM Changeset in webkit [53889] by
-
- 4 edits in trunk
2010-01-26 Kent Tamura <tkent@chromium.org>
Reviewed by Eric Seidel.
[Win] Add modifiers parameter support to Windows DumpRenderTree
https://bugs.webkit.org/show_bug.cgi?id=34068
Remove listbox-deselect-scroll.html and listbox-selectio-2.html
from Skipped. We improved their portability and Windows DRT now
havs modifiers parameter of eventSender.mouseDown() and
eventSender.mouseUp().
- platform/win/Skipped:
2010-01-26 Kent Tamura <tkent@chromium.org>
Reviewed by Eric Seidel.
[Win] Add modifiers parameter support to Windows DumpRenderTree
https://bugs.webkit.org/show_bug.cgi?id=34068
Add support for functional name modifiers; "addSelectionKey" and
"rangeSelectionKey", and modifiers parameter to eventSender.mouseDown()
and eventSender.mouseUp().
This change is similar to r53498 for Mac.
- DumpRenderTree/win/EventSender.cpp: (buildModifierFlags): New function to set MK_CONTROL or MK_SHIFT to WPARAM. (mouseDownCallback): Call buidlModifiersFlags(). (mouseUpCallback): ditto. (keyDownCallback): Add support for "addSelectionkey" and "rangeSelectionKey".
- 7:58 PM Changeset in webkit [53888] by
-
- 1 edit in trunk/WebKitTools/Scripts/webkitpy/autoinstall.py
No review: fixing broken autoinstall.py
- 7:04 PM Changeset in webkit [53887] by
-
- 2 edits in trunk/WebKitTools
2010-01-26 Chris Jerdonek <Chris Jerdonek>
Reviewed by Eric Seidel.
The Python autoinstall cache directory now only gets created
in the directory containing autoinstall.py.
- Scripts/webkitpy/autoinstall.py:
- Also added a README file to the cache directory saying where it came from.
- 6:56 PM Changeset in webkit [53886] by
-
- 2 edits in trunk/WebCore
Not reviewed, attempt to fix Tiger build.
- rendering/RenderTreeAsText.cpp:
(WebCore::write): Use UNUSED_PARAM macros to prevent compiler warning on targets without accelerated compositing.
- 6:54 PM Changeset in webkit [53885] by
-
- 2 edits in trunk/WebCore
Incorrect boolean expression in isMailBlockquote() (WebCore/htmlediting.cpp)
https://bugs.webkit.org/show_bug.cgi?id=34156
Reviewed by Darin Adler.
No new tests (minor code change).
- editing/htmlediting.cpp:
(WebCore::isMailBlockquote):
- 6:25 PM Changeset in webkit [53884] by
-
- 5 edits in trunk/WebCore
Handle broken images more correctly in the open-source image decoders.
https://bugs.webkit.org/show_bug.cgi?id=33747
Reviewed by David Levin.
No tests since Safari doesn't use these decoders and there's already a
broken-image test in the tree.
- platform/graphics/ImageSource.cpp:
(WebCore::ImageSource::createFrameAtIndex): No need to check isSizeAvailable() since size() is now always safe.
- platform/image-decoders/ImageDecoder.h:
(WebCore::ImageDecoder::size): Don't assert that the bitmap is valid; we don't need a complete successful decode to be able to give info about the size.
- platform/image-decoders/qt/RGBA32BufferQt.cpp:
(WebCore::RGBA32Buffer::setSize): Don't set the frame to complete on failure, since it's not complete, but empty, and callers can better handle empty frames.
- platform/image-decoders/skia/ImageDecoderSkia.cpp:
(WebCore::RGBA32Buffer::setSize): Don't set the frame to complete on failure, since it's not complete, but empty, and callers can better handle empty frames.
- 6:23 PM Changeset in webkit [53883] by
-
- 3 edits in trunk/WebCore
2010-01-26 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed. Synchronize Qt/Gtk build systems with Mac/Win, should fix Qt compilation. Gtk results still pending.
- GNUmakefile.am:
- WebCore.pro:
- 6:14 PM Changeset in webkit [53882] by
-
- 4 edits4 moves2 adds in trunk/WebKitTools
2010-01-26 Chris Jerdonek <Chris Jerdonek>
Reviewed by Eric Seidel.
Moved the check-webkit-style processors into a new
webkitpy/style/processors directory.
- Scripts/webkitpy/style/checker.py:
- Scripts/webkitpy/style/checker_unittest.py:
- Scripts/webkitpy/style/cpp_style.py: Removed.
- Scripts/webkitpy/style/cpp_style_unittest.py: Removed.
- Scripts/webkitpy/style/processors: Added.
- Scripts/webkitpy/style/processors/init.py: Added.
- Scripts/webkitpy/style/processors/cpp.py: Copied from WebKitTools/Scripts/webkitpy/style/cpp_style.py.
- Scripts/webkitpy/style/processors/cpp_unittest.py: Copied from WebKitTools/Scripts/webkitpy/style/cpp_style_unittest.py.
- Scripts/webkitpy/style/processors/text.py: Copied from WebKitTools/Scripts/webkitpy/style/text_style.py.
- Scripts/webkitpy/style/processors/text_unittest.py: Copied from WebKitTools/Scripts/webkitpy/style/text_style_unittest.py.
- Scripts/webkitpy/style/text_style.py: Removed.
- Scripts/webkitpy/style/text_style_unittest.py: Removed.
- Scripts/webkitpy/style/unittests.py:
- 6:02 PM Changeset in webkit [53881] by
-
- 2 edits in trunk/WebCore
2010-01-26 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed. Attempt to fix V8 - change SetterMethod function signatures, just like it has been done for JSSVGPODTypeWrapper.
- bindings/v8/V8SVGPODTypeWrapper.h:
- 5:53 PM Changeset in webkit [53880] by
-
- 2 edits in trunk/WebCore
2010-01-26 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewd. Revert Base.xcconfig changes, was not meant to be committed.
- Configurations/Base.xcconfig:
- 5:51 PM Changeset in webkit [53879] by
-
- 142 edits3 adds3 deletes in trunk/WebCore
2010-01-26 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Oliver Hunt.
SVG consumes way too much memory to store animated properties in the DOM
https://bugs.webkit.org/show_bug.cgi?id=34188
Shrink WebCore library size to 75% (measured in debug builds) and reduce SVG memory usage to <25%.
Adding Oliver testcase as manual-tests/svg-node-count-vs-scroll.xhtml, which creates an arbitary number of
rects (50.000 <rect> elements added to the DOM by default) - memory usage down to 111M from 503M (RPRVT).
The SVG DOM side is almost fine, still some optimizations possible, that will be implemented soon - next
target is the SVG render tree, there are plenty of possibilities to reduce memory usage there.
Redesign the way we store animated properties in the individual SVG*Element files. Short story: In order
to support SVG DOM through the bindings (e.g. JS) we need to associate SVGAnimatedProperty objects with
the SVGElement object that created it - we used to store this pointer directly in the SVGAnimatedProperty.
This means, every SVGAnimatedProperty stored in a SVGRectElement, stored a pointer to the SVGRectElement, resulting
in excessive memory usage. This is now properly implemented, without wasting tons of memory. Unfortunately this
requires touching all SVG*Element files.
Detailed list of changes:
- Remove template bloat by not specializing class templates for each attributeName/tagName combination. Instead SVGAnimatedProperty is a non-specialized template class now, only depending on the AnimatedType (ie. SVGLength for SVGAnimatedLength) -> This heavily reduces the generated code, thus shrinking WebCore size. I hope we can build windows again without SVGAllInOne.cpp
- Remove "exportStrings" / "exportString" handling from make_names.pl - SVG defined string literals for each QualifiedName, in order to use template specialization based on "const char*" parameters. All that bloat is gone, so there's no need for it anymore.
- Redesign SVGAnimatedProperty so it does not need any back-pointers to the SVGElement that created it
- Don't actually store the XML DOM attribute name associated with a SVG DOM property in SVGAnimatedProperty, move the associatedAttributeName() function inside the macro declaration and just return the passed macro parameter DOMAttribute there, storing is inefficient and useless.
- Remove SynchronizablePropertyController, which was living in SVGElement as member variable, keeping a HashMap<AttributeName, SVGAnimatedProperty>. It was needed before to lookup a SVGAnimatedProperty for a XML DOM attribute, in order to synchronize SVG <-> XML dom properties/attributes. Instead just add a "synchronizeProperty(const QualifiedName&)" method to all SVG*Element classes. As each SVG*Element class knows about its animated properties it can just ask them to synchronize themselves - no need for any dynamic lookups anymore.
- Remove SynchronizableTypeWrapper which added more complexity for the sake of SVG <-> XML DOM synchronization, all replaced by synchronizeProperty.
- Pass around any POD objects as const references, instead of copying them for no reason.
- Clean up SVGAnimatedProperty, splitting up into SVGAnimatedProperty/PropertySynchronizer/PropertyTraits.
- Remove baseValue/setBaseValue code from SVGDocumentExtensions, not needed anymore.
... and tons of changes to all SVG*Element classes, adapting to the new way of handling animated properties.
- GNUmakefile.am: Remove Synchronizable* from build, add new SVGAnimatedPropertySynchronizer/Traits files
- WebCore.gypi: Ditto.
- WebCore.vcproj/WebCore.vcproj: Ditto.
- WebCore.xcodeproj/project.pbxproj: Ditto.
- bindings/js/JSSVGPODTypeWrapper.h: Change synchronization callback signatures, as we pass around const-references now.
- dom/Element.cpp: Let updateAnimatedSVGAttribute take a QualifiedName instead of pure Strings. (WebCore::Element::getAttribute): (WebCore::Element::hasAttributes):
- dom/Element.h: (WebCore::Element::updateAnimatedSVGAttribute): (WebCore::Element::attributes):
- dom/make_names.pl: Remove SVG specific "exportString" / "exportStrings" functionality, see above.
- html/HTMLAttributeNames.in: Remove "exportString" tag from "className" attribute.
- manual-tests/svg-node-count-vs-scroll.xhtml: Added. Can be used to verify memory consumption with a lot of DOM objects.
- mathml/mathattrs.in: MathML doesn't need "exportStrings" - remove it.
- mathml/mathtags.in: Ditto.
- svg/SVGAElement.cpp: (WebCore::SVGAElement::SVGAElement): (WebCore::SVGAElement::synchronizeProperty):
- svg/SVGAElement.h:
- svg/SVGAllInOne.cpp: Remove SynchronizablePropertyController.cpp
- svg/SVGAltGlyphElement.cpp: (WebCore::SVGAltGlyphElement::SVGAltGlyphElement): (WebCore::SVGAltGlyphElement::synchronizeProperty):
- svg/SVGAltGlyphElement.h:
- svg/SVGAnimateTransformElement.cpp: (WebCore::SVGAnimateTransformElement::applyResultsToTarget):
- svg/SVGAnimatedProperty.h: Rewritten, see above for details. (WebCore::SVGAnimatedPropertyTearOff::create): (WebCore::SVGAnimatedPropertyTearOff::setBaseVal): (WebCore::SVGAnimatedPropertyTearOff::setAnimVal): (WebCore::SVGAnimatedPropertyTearOff::baseVal): (WebCore::SVGAnimatedPropertyTearOff::animVal): (WebCore::SVGAnimatedPropertyTearOff::associatedAttributeName): (WebCore::SVGAnimatedPropertyTearOff::SVGAnimatedPropertyTearOff): (WebCore::SVGAnimatedPropertyTearOff::~SVGAnimatedPropertyTearOff): (WebCore::SVGAnimatedProperty::~SVGAnimatedProperty): (WebCore::SVGAnimatedProperty::SVGAnimatedProperty): (WebCore::SVGAnimatedProperty::value): (WebCore::SVGAnimatedProperty::baseValue): (WebCore::SVGAnimatedProperty::setValue): (WebCore::SVGAnimatedProperty::setBaseValue): (WebCore::SVGAnimatedProperty::shouldSynchronize): (WebCore::SVGAnimatedProperty::setShouldSynchronize):
- svg/SVGAnimatedPropertySynchronizer.h: Added. (WebCore::):
- svg/SVGAnimatedPropertyTraits.h: Added. (WebCore::):
- svg/SVGAnimatedTemplate.h: Move SVGAnimatedPropertyTraits into its own file. (WebCore::SVGAnimatedTemplate::forgetWrapper): (WebCore::lookupOrCreateWrapper):
- svg/SVGAnimationElement.cpp: (WebCore::SVGAnimationElement::SVGAnimationElement): (WebCore::SVGAnimationElement::synchronizeProperty):
- svg/SVGAnimationElement.h:
- svg/SVGCircleElement.cpp: (WebCore::SVGCircleElement::SVGCircleElement): (WebCore::SVGCircleElement::synchronizeProperty):
- svg/SVGCircleElement.h:
- svg/SVGClipPathElement.cpp: (WebCore::SVGClipPathElement::SVGClipPathElement): (WebCore::SVGClipPathElement::synchronizeProperty):
- svg/SVGClipPathElement.h:
- svg/SVGComponentTransferFunctionElement.cpp: (WebCore::SVGComponentTransferFunctionElement::SVGComponentTransferFunctionElement): (WebCore::SVGComponentTransferFunctionElement::parseMappedAttribute): (WebCore::SVGComponentTransferFunctionElement::synchronizeProperty):
- svg/SVGComponentTransferFunctionElement.h:
- svg/SVGCursorElement.cpp: (WebCore::SVGCursorElement::SVGCursorElement): (WebCore::SVGCursorElement::synchronizeProperty):
- svg/SVGCursorElement.h:
- svg/SVGDefsElement.cpp: (WebCore::SVGDefsElement::SVGDefsElement): (WebCore::SVGDefsElement::synchronizeProperty):
- svg/SVGDefsElement.h:
- svg/SVGDocumentExtensions.h:
- svg/SVGElement.cpp: Adapt to synchronization changes: use synchronizeProperty() call, instead of SynchronizablePropertyController. (WebCore::SVGElement::updateAnimatedSVGAttribute):
- svg/SVGElement.h: Don't store SynchronizablePropertyController anymore, it's gone. (WebCore::SVGElement::synchronizeProperty): (WebCore::SVGElement::setSynchronizedSVGAttributes):
- svg/SVGEllipseElement.cpp: (WebCore::SVGEllipseElement::SVGEllipseElement): (WebCore::SVGEllipseElement::synchronizeProperty):
- svg/SVGEllipseElement.h:
- svg/SVGExternalResourcesRequired.cpp:
- svg/SVGExternalResourcesRequired.h:
- svg/SVGFEBlendElement.cpp: (WebCore::SVGFEBlendElement::SVGFEBlendElement): (WebCore::SVGFEBlendElement::synchronizeProperty):
- svg/SVGFEBlendElement.h:
- svg/SVGFEColorMatrixElement.cpp: (WebCore::SVGFEColorMatrixElement::SVGFEColorMatrixElement): (WebCore::SVGFEColorMatrixElement::synchronizeProperty):
- svg/SVGFEColorMatrixElement.h:
- svg/SVGFEComponentTransferElement.cpp: (WebCore::SVGFEComponentTransferElement::SVGFEComponentTransferElement): (WebCore::SVGFEComponentTransferElement::synchronizeProperty):
- svg/SVGFEComponentTransferElement.h:
- svg/SVGFECompositeElement.cpp: (WebCore::SVGFECompositeElement::SVGFECompositeElement): (WebCore::SVGFECompositeElement::parseMappedAttribute): (WebCore::SVGFECompositeElement::synchronizeProperty):
- svg/SVGFECompositeElement.h:
- svg/SVGFEDiffuseLightingElement.cpp: (WebCore::SVGFEDiffuseLightingElement::SVGFEDiffuseLightingElement): (WebCore::SVGFEDiffuseLightingElement::synchronizeProperty):
- svg/SVGFEDiffuseLightingElement.h:
- svg/SVGFEDisplacementMapElement.cpp: (WebCore::SVGFEDisplacementMapElement::SVGFEDisplacementMapElement): (WebCore::SVGFEDisplacementMapElement::synchronizeProperty):
- svg/SVGFEDisplacementMapElement.h:
- svg/SVGFEGaussianBlurElement.cpp: (WebCore::SVGFEGaussianBlurElement::SVGFEGaussianBlurElement): (WebCore::SVGFEGaussianBlurElement::synchronizeProperty):
- svg/SVGFEGaussianBlurElement.h:
- svg/SVGFEImageElement.cpp: (WebCore::SVGFEImageElement::SVGFEImageElement): (WebCore::SVGFEImageElement::synchronizeProperty):
- svg/SVGFEImageElement.h:
- svg/SVGFELightElement.cpp: (WebCore::SVGFELightElement::SVGFELightElement): (WebCore::SVGFELightElement::synchronizeProperty):
- svg/SVGFELightElement.h:
- svg/SVGFEMergeNodeElement.cpp: (WebCore::SVGFEMergeNodeElement::SVGFEMergeNodeElement): (WebCore::SVGFEMergeNodeElement::synchronizeProperty):
- svg/SVGFEMergeNodeElement.h:
- svg/SVGFEMorphologyElement.cpp: (WebCore::SVGFEMorphologyElement::SVGFEMorphologyElement): (WebCore::SVGFEMorphologyElement::synchronizeProperty):
- svg/SVGFEMorphologyElement.h:
- svg/SVGFEOffsetElement.cpp: (WebCore::SVGFEOffsetElement::SVGFEOffsetElement): (WebCore::SVGFEOffsetElement::synchronizeProperty):
- svg/SVGFEOffsetElement.h:
- svg/SVGFESpecularLightingElement.cpp: (WebCore::SVGFESpecularLightingElement::SVGFESpecularLightingElement): (WebCore::SVGFESpecularLightingElement::synchronizeProperty):
- svg/SVGFESpecularLightingElement.h:
- svg/SVGFETileElement.cpp: (WebCore::SVGFETileElement::SVGFETileElement): (WebCore::SVGFETileElement::synchronizeProperty):
- svg/SVGFETileElement.h:
- svg/SVGFETurbulenceElement.cpp: (WebCore::SVGFETurbulenceElement::SVGFETurbulenceElement): (WebCore::SVGFETurbulenceElement::synchronizeProperty):
- svg/SVGFETurbulenceElement.h:
- svg/SVGFilterElement.cpp: (WebCore::SVGFilterElement::SVGFilterElement): (WebCore::SVGFilterElement::synchronizeProperty):
- svg/SVGFilterElement.h:
- svg/SVGFilterPrimitiveStandardAttributes.cpp: (WebCore::SVGFilterPrimitiveStandardAttributes::SVGFilterPrimitiveStandardAttributes): (WebCore::SVGFilterPrimitiveStandardAttributes::synchronizeProperty):
- svg/SVGFilterPrimitiveStandardAttributes.h:
- svg/SVGFitToViewBox.cpp:
- svg/SVGFitToViewBox.h:
- svg/SVGFontElement.cpp: (WebCore::SVGFontElement::SVGFontElement): (WebCore::SVGFontElement::synchronizeProperty):
- svg/SVGFontElement.h:
- svg/SVGForeignObjectElement.cpp: (WebCore::SVGForeignObjectElement::SVGForeignObjectElement): (WebCore::SVGForeignObjectElement::synchronizeProperty):
- svg/SVGForeignObjectElement.h:
- svg/SVGGElement.cpp: (WebCore::SVGGElement::SVGGElement): (WebCore::SVGGElement::synchronizeProperty):
- svg/SVGGElement.h:
- svg/SVGGradientElement.cpp: (WebCore::SVGGradientElement::SVGGradientElement): (WebCore::SVGGradientElement::synchronizeProperty):
- svg/SVGGradientElement.h:
- svg/SVGImageElement.cpp: (WebCore::SVGImageElement::SVGImageElement): (WebCore::SVGImageElement::synchronizeProperty):
- svg/SVGImageElement.h:
- svg/SVGLineElement.cpp: (WebCore::SVGLineElement::SVGLineElement): (WebCore::SVGLineElement::synchronizeProperty):
- svg/SVGLineElement.h:
- svg/SVGLinearGradientElement.cpp: (WebCore::SVGLinearGradientElement::SVGLinearGradientElement): (WebCore::SVGLinearGradientElement::synchronizeProperty):
- svg/SVGLinearGradientElement.h:
- svg/SVGList.h: Adapt to const-reference changes. (WebCore::SVGPODListItem::setValue):
- svg/SVGMPathElement.cpp: (WebCore::SVGMPathElement::SVGMPathElement): (WebCore::SVGMPathElement::synchronizeProperty):
- svg/SVGMPathElement.h:
- svg/SVGMarkerElement.cpp: (WebCore::SVGMarkerElement::SVGMarkerElement): (WebCore::SVGMarkerElement::synchronizeProperty):
- svg/SVGMarkerElement.h:
- svg/SVGMaskElement.cpp: (WebCore::SVGMaskElement::SVGMaskElement): (WebCore::SVGMaskElement::synchronizeProperty):
- svg/SVGMaskElement.h:
- svg/SVGPathElement.cpp: (WebCore::SVGPathElement::SVGPathElement): (WebCore::SVGPathElement::synchronizeProperty):
- svg/SVGPathElement.h:
- svg/SVGPatternElement.cpp: (WebCore::SVGPatternElement::SVGPatternElement): (WebCore::SVGPatternElement::synchronizeProperty):
- svg/SVGPatternElement.h:
- svg/SVGPolyElement.cpp: (WebCore::SVGPolyElement::SVGPolyElement): (WebCore::SVGPolyElement::svgAttributeChanged): (WebCore::SVGPolyElement::synchronizeProperty):
- svg/SVGPolyElement.h:
- svg/SVGRadialGradientElement.cpp: (WebCore::SVGRadialGradientElement::SVGRadialGradientElement): (WebCore::SVGRadialGradientElement::synchronizeProperty):
- svg/SVGRadialGradientElement.h:
- svg/SVGRectElement.cpp: (WebCore::SVGRectElement::SVGRectElement): (WebCore::SVGRectElement::synchronizeProperty):
- svg/SVGRectElement.h:
- svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::SVGSVGElement): (WebCore::SVGSVGElement::synchronizeProperty):
- svg/SVGSVGElement.h:
- svg/SVGScriptElement.cpp: (WebCore::SVGScriptElement::SVGScriptElement): (WebCore::SVGScriptElement::synchronizeProperty):
- svg/SVGScriptElement.h:
- svg/SVGStopElement.cpp: (WebCore::SVGStopElement::SVGStopElement): (WebCore::SVGStopElement::synchronizeProperty):
- svg/SVGStopElement.h:
- svg/SVGStyledElement.cpp: (WebCore::SVGStyledElement::SVGStyledElement): (WebCore::SVGStyledElement::parseMappedAttribute): (WebCore::SVGStyledElement::synchronizeProperty):
- svg/SVGStyledElement.h:
- svg/SVGStyledTransformableElement.cpp: (WebCore::SVGStyledTransformableElement::SVGStyledTransformableElement): (WebCore::SVGStyledTransformableElement::synchronizeProperty):
- svg/SVGStyledTransformableElement.h:
- svg/SVGSwitchElement.cpp: (WebCore::SVGSwitchElement::SVGSwitchElement): (WebCore::SVGSwitchElement::synchronizeProperty):
- svg/SVGSwitchElement.h:
- svg/SVGSymbolElement.cpp: (WebCore::SVGSymbolElement::SVGSymbolElement): (WebCore::SVGSymbolElement::synchronizeProperty):
- svg/SVGSymbolElement.h:
- svg/SVGTRefElement.cpp: (WebCore::SVGTRefElement::SVGTRefElement): (WebCore::SVGTRefElement::synchronizeProperty):
- svg/SVGTRefElement.h:
- svg/SVGTextContentElement.cpp: (WebCore::SVGTextContentElement::SVGTextContentElement): (WebCore::SVGTextContentElement::synchronizeProperty):
- svg/SVGTextContentElement.h:
- svg/SVGTextElement.cpp: (WebCore::SVGTextElement::SVGTextElement): (WebCore::SVGTextElement::synchronizeProperty):
- svg/SVGTextElement.h:
- svg/SVGTextPathElement.cpp: (WebCore::SVGTextPathElement::SVGTextPathElement): (WebCore::SVGTextPathElement::synchronizeProperty):
- svg/SVGTextPathElement.h:
- svg/SVGTextPositioningElement.cpp: (WebCore::SVGTextPositioningElement::SVGTextPositioningElement): (WebCore::SVGTextPositioningElement::synchronizeProperty):
- svg/SVGTextPositioningElement.h:
- svg/SVGURIReference.cpp:
- svg/SVGURIReference.h:
- svg/SVGUseElement.cpp: (WebCore::SVGUseElement::SVGUseElement): (WebCore::SVGUseElement::synchronizeProperty):
- svg/SVGUseElement.h:
- svg/SVGViewElement.cpp: (WebCore::SVGViewElement::SVGViewElement): (WebCore::SVGViewElement::synchronizeProperty):
- svg/SVGViewElement.h:
- svg/SVGViewSpec.cpp: (WebCore::SVGViewSpec::SVGViewSpec):
- svg/SVGViewSpec.h: (WebCore::SVGViewSpec::contextElement):
- svg/SynchronizablePropertyController.cpp: Removed.
- svg/SynchronizablePropertyController.h: Removed.
- svg/SynchronizableTypeWrapper.h: Removed.
- svg/svgattrs.in: Remove "exportStrings" tag.
- svg/svgtags.in: Ditto.
- svg/xlinkattrs.in:
- 5:35 PM Changeset in webkit [53878] by
-
- 5 edits2 adds in trunk
WebCore: Fix for <rdar://problem/7169464> REGRESSION (r47444): PLT is 1% slower due to implementation of :valid and :invalid CSS selectors
https://bugs.webkit.org/show_bug.cgi?id=34029
Reviewed by Darin Adler.
If we never hit the valid or invalid selectors for a particular document,
then we'll skip the validity checks when deciding about style sharing.
- css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::canShareStyleWithElement):
(WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
- dom/Document.cpp: (WebCore::Document::Document):
- dom/Document.h:
(WebCore::Document::considerValidity):
(WebCore::Document::setConsiderValidity):
LayoutTests: Test for <rdar://problem/7169464> REGRESSION (r47444): PLT is 1% slower due to implementation of :valid and :invalid CSS selectors
https://bugs.webkit.org/show_bug.cgi?id=34029
Reviewed by Darin Adler.
- fast/css/pseudo-valid-dynamic-expected.txt: Added.
- fast/css/pseudo-valid-dynamic.html: Added.
- 5:31 PM Changeset in webkit [53877] by
-
- 6 edits in trunk/WebCore
Revert 53797 as it seems to be causing crashes.
https://bugs.webkit.org/show_bug.cgi?id=34153
Patch by Jeremy Orlow <jorlow@chromium.org> on 2010-01-26
Reviewed by Simon Fraser.
- page/FrameView.cpp:
(WebCore::FrameView::useSlowRepaints):
(WebCore::FrameView::useSlowRepaintsIfNotOverlapped):
- page/FrameView.h:
- platform/ScrollView.cpp:
(WebCore::ScrollView::scrollContents):
- platform/ScrollView.h:
- rendering/RenderObject.cpp:
(WebCore::RenderObject::styleWillChange):
(WebCore::RenderObject::destroy):
- 5:20 PM Changeset in webkit [53876] by
-
- 2 edits in trunk/WebCore
DumpRenderTree silently crashes at the end of the run because geolocationControllerClient pointer is 0.
https://bugs.webkit.org/show_bug.cgi?id=34191
Reviewed by Steve Falkenburg.
- page/GeolocationController.cpp:
(WebCore::GeolocationController::~GeolocationController): Add check for m_client being 0.
(WebCore::GeolocationController::addObserver): Ditto.
(WebCore::GeolocationController::removeObserver): Ditto.
(WebCore::GeolocationController::lastPosition): Ditto.
- 5:09 PM Changeset in webkit [53875] by
-
- 2 edits in trunk/LayoutTests
2010-01-26 Fumitoshi Ukai <ukai@chromium.org>
Reviewed by Alexey Proskuryakov.
Fix url used in websocket-event-target.html
https://bugs.webkit.org/show_bug.cgi?id=34066
- websocket/tests/script-tests/websocket-event-target.js:
- 5:08 PM Changeset in webkit [53874] by
-
- 8 edits in trunk/WebCore
2010-01-26 Simon Fraser <Simon Fraser>
Reviewed by Adele Peterson.
Enhance externalRepresentation() to make it more useful for layer debugging
https://bugs.webkit.org/show_bug.cgi?id=34143
Enhance externalRepresentation() to output additional information about layers when certain flags are passed.
The new flags allow you to show all layers (not just those that would paint), to the structure of the z-order
and normal flow lists, and to show which layers are composited.
- WebCore.base.exp: The signature of externalRepresentation() changed.
- platform/text/TextStream.h: Add operator<<(void*)
- platform/text/TextStream.cpp: Implement operator<<(void*)
- rendering/RenderLayer.h:
- rendering/RenderLayer.cpp: (showLayerTree): New method outside the WebCore namespace, for ease of calling from gdb.
- rendering/RenderTreeAsText.h: New behavior flags for externalRepresentation().
- rendering/RenderTreeAsText.cpp: (WebCore::write): Output compositing information if requested. Also clean up some -1/1 magic numbers with an enum. (WebCore::writeLayers): If requested, show layer nesting via the z-order and normal flow lists. (WebCore::externalRepresentation): New arguments
- 5:00 PM Changeset in webkit [53873] by
-
- 3 edits in trunk/LayoutTests
Fixing for failing test on qt.
https://bugs.webkit.org/show_bug.cgi?id=34148
Reviewed by Jon Honeycutt.
Changed url in anchor tag to avoid the additional trailing slash.
- editing/pasteboard/paste-noscript-xhtml-expected.txt:
- editing/resources/htmlcontent.html:
- 4:36 PM Changeset in webkit [53872] by
-
- 2 edits in trunk/WebCore
Fixed an off-by-one error.
Reviewed by Simon Fraser.
- rendering/break_lines.cpp:
(WebCore::shouldBreakAfter):
- 4:22 PM Changeset in webkit [53871] by
-
- 6 edits5 adds in trunk
Avoid reloading iframe on re-parenting between documents.
https://bugs.webkit.org/show_bug.cgi?id=32848
Reviewed by David Levin.
WebCore:
Achieved by setting a flag on iframe element when it is a target of document.adoptNode(node) operation.
The flag prevents unload/load cycle and is reset once element is attached to a new document.
If iframe is adopted but not actually inserted into the tree, it gets unloaded by async timer
once JS yields, to avoid having active content in non-attached iframe.
Test: fast/frames/iframe-reparenting.html
- dom/Document.cpp:
(WebCore::Document::adoptNode): If the adopted node is iframe, set a remainsAliveOnRemovalFromTree on it.
- html/HTMLFrameElementBase.h:
- html/HTMLFrameElementBase.cpp:
(WebCore::HTMLFrameElementBase::HTMLFrameElementBase):
(WebCore::HTMLFrameElementBase::attach): Skip actual loading of the frame if it has remainsAliveOnRemovalFromTree flag. Reset the flag.
(WebCore::HTMLFrameElementBase::willRemove): Skip unloading the frame if it has remainsAliveOnRemovalFromTree flag set.
(WebCore::HTMLFrameElementBase::setRemainsAliveOnRemovalFromTree): Set the flag, start the async timer to check if the frame was actually attached.
(WebCore::HTMLFrameElementBase::checkAttachedTimerFired):
- html/HTMLFrameOwnerElement.h:
(WebCore::HTMLFrameOwnerElement::willRemove): Move from private to protected, since it is conditionally called in HTMLFrameElementBase::willRemove now.
LayoutTests:
- fast/frames/iframe-reparenting-expected.txt: Added.
- fast/frames/iframe-reparenting.html: Added.
- fast/frames/resources/iframe-reparenting-frame1.html: Added.
- fast/frames/resources/iframe-reparenting-frame2.html: Added.
- fast/frames/resources/iframe-reparenting-iframe-content.html: Added.
- 4:09 PM Changeset in webkit [53870] by
-
- 2 edits in trunk/WebKitTools
[wx] Build fix, make sure stub function returns a value.
- 2:59 PM Changeset in webkit [53869] by
-
- 15 edits in trunk
2010-01-26 Adam Roben <Adam Roben>
No review, rolling out r53861.
http://trac.webkit.org/changeset/53861
https://bugs.webkit.org/show_bug.cgi?id=33224
Caused 2 regression tests to fail.
- fast/loader/stateobjects/document-destroyed-navigate-back-expected.txt:
- fast/loader/stateobjects/document-destroyed-navigate-back.html:
2010-01-26 Adam Roben <Adam Roben>
No review, rolling out r53861.
http://trac.webkit.org/changeset/53861
https://bugs.webkit.org/show_bug.cgi?id=33224
Caused 2 regression tests to fail.
- dom/Document.cpp: (WebCore::Document::detach): (WebCore::Document::registerHistoryItem): (WebCore::Document::unregisterHistoryItem):
- dom/Document.h:
- history/BackForwardList.cpp: (WebCore::BackForwardList::pushStateItem):
- history/BackForwardListChromium.cpp: (WebCore::BackForwardList::pushStateItem):
- history/HistoryItem.cpp: (WebCore::HistoryItem::HistoryItem): (WebCore::HistoryItem::~HistoryItem): (WebCore::HistoryItem::setStateObject): (WebCore::HistoryItem::setDocument): (WebCore::HistoryItem::documentDetached):
- history/HistoryItem.h: (WebCore::HistoryItem::document):
- loader/FrameLoader.cpp: (WebCore::FrameLoader::navigateWithinDocument): (WebCore::FrameLoader::loadItem):
- loader/HistoryController.cpp: (WebCore::HistoryController::updateBackForwardListForFragmentScroll): (WebCore::HistoryController::pushState): (WebCore::HistoryController::replaceState):
- loader/RedirectScheduler.cpp: (WebCore::RedirectScheduler::scheduleHistoryNavigation):
- page/History.cpp: (WebCore::History::stateObjectAdded):
- page/Page.cpp: (WebCore::Page::goToItem):
- 2:48 PM Changeset in webkit [53868] by
-
- 3 edits4 adds in trunk
<rdar://problem/7576663> Crash caused by anonymous list item
https://bugs.webkit.org/show_bug.cgi?id=34183
Reviewed by Beth Dakin.
WebCore:
Test: fast/lists/anonymous-items.html
enclosingList() and previousListItem() were DOM-based, but in order to work with anonymous
list items, they need to work with rthe render tree.
- rendering/RenderListItem.cpp:
(WebCore::isList): Factored out.
(WebCore::enclosingList): Added this variant that takes a RenderObject.
(WebCore::previousListItem): Changed to travers the render tree.
(WebCore::RenderListItem::calcValue): Use the RenderObject version of enclosingList()
(WebCore::RenderListItem::setExplicitValue): Added an assertion.
(WebCore::RenderListItem::clearExplicitValue): Ditto.
LayoutTests:
- fast/lists/anonymous-items.html: Added.
- platform/mac/fast/lists/anonymous-items-expected.checksum: Added.
- platform/mac/fast/lists/anonymous-items-expected.png: Added.
- platform/mac/fast/lists/anonymous-items-expected.txt: Added.
- 2:45 PM Changeset in webkit [53867] by
-
- 2 edits1 add in trunk/WebCore
Crash in WebKit!WebCore::RenderMenuList::itemStyle
https://bugs.webkit.org/show_bug.cgi?id=34182
<rdar://7087757>
Reviewed by Jon Honeycutt.
Added bounds checks in RenderMenuList to make sure we are
not making an out of bounds check in a vector once an option
element has been deleted. If we are out of bounds, we fall back to
a default value and return early, and in the case of itemStyle, we use a
previous option's style, if it is available.
- manual-tests/select-delete-item.html: Added.
- rendering/RenderMenuList.cpp:
(WebCore::RenderMenuList::itemText): If out of bounds check, return early.
(WebCore::RenderMenuList::itemToolTip): Ditto.
(WebCore::RenderMenuList::itemIsEnabled): Ditto.
(WebCore::RenderMenuList::itemStyle): If out of bounds check, try using the 0th index
option style, then fall back to the select's style if that option doesn't exist.
(WebCore::RenderMenuList::itemBackgroundColor): If out of bounds check, return early.
(WebCore::RenderMenuList::itemIsSeparator): Ditto.
(WebCore::RenderMenuList::itemIsLabel): Ditto.
(WebCore::RenderMenuList::itemIsSelected): Ditto.
- 2:20 PM Changeset in webkit [53866] by
-
- 1 edit in trunk/WebCore/ChangeLog
Whoops, fixerate ChangeLog.
- 2:00 PM Changeset in webkit [53865] by
-
- 7 edits in trunk/WebCore
<<<<<<< .mine
- 1:14 PM Changeset in webkit [53864] by
-
- 14 edits in trunk
2010-01-26 Steve Falkenburg <sfalken@apple.com>
Reviewed by Oliver Hunt.
Windows build references non-existent include paths
https://bugs.webkit.org/show_bug.cgi?id=34175
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreCommon.vsprops:
- JavaScriptCore.vcproj/WTF/WTFCommon.vsprops:
- JavaScriptCore.vcproj/jsc/jscCommon.vsprops:
- JavaScriptCore.vcproj/testapi/testapi.vcproj:
- JavaScriptCore.vcproj/testapi/testapiCommon.vsprops:
2010-01-26 Steve Falkenburg <sfalken@apple.com>
Reviewed by Oliver Hunt.
Windows build references non-existent include paths
https://bugs.webkit.org/show_bug.cgi?id=34175
- WebKit.vcproj/WebKit.vcproj:
2010-01-26 Steve Falkenburg <sfalken@apple.com>
Reviewed by Oliver Hunt.
Windows build references non-existent include paths
https://bugs.webkit.org/show_bug.cgi?id=34175
- WebCore.vcproj/QTMovieWin.vcproj:
- WebCore.vcproj/WebCoreCommon.vsprops:
2010-01-26 Steve Falkenburg <sfalken@apple.com>
Reviewed by Oliver Hunt.
Windows build references non-existent include paths
https://bugs.webkit.org/show_bug.cgi?id=34175
- DumpRenderTree/win/DumpRenderTree.vcproj:
- DumpRenderTree/win/ImageDiff.vcproj:
- DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
- 12:20 PM Changeset in webkit [53863] by
-
- 3 edits in trunk/LayoutTests
Another attempt to get this test to pass for GTK.
Add ability for image maps to be focused via tabbing
https://bugs.webkit.org/show_bug.cgi?id=17513
- fast/events/tab-imagemap-expected.txt:
- fast/events/tab-imagemap.html:
- 12:02 PM Changeset in webkit [53862] by
-
- 3 edits2 adds in trunk/WebKitTools
[Qt] Separating out the UrlLoader from the QtLauncher in it's
own implementation and header file.
Reviewed by Ariya Hidayat.
- QtLauncher/main.cpp:
(main):
- QtLauncher/urlloader.cpp: Added.
(UrlLoader::UrlLoader):
(UrlLoader::loadNext):
(UrlLoader::init):
(UrlLoader::getUrl):
- QtLauncher/urlloader.h: Added.
- 11:30 AM Changeset in webkit [53861] by
-
- 15 edits in trunk
2010-01-25 Darin Fisher <darin@chromium.org>
Reviewed by Brady Eidson.
Chains of history items representing same-document navigation need to
always remember that association
Replace HistoryItem's Document pointer with a DocumentSequenceNumber.
During session history traversal, if the current HistoryItem and the
target HistoryItem have the same DocumentSequenceNumber, then it means
that the current Document should remain.
NOTE: To support Chromium's serialization of HistoryItems, I generate
DocumentSequenceNumbers that are unique across application launches.
DocumentSequenceNumbers are generated using a counter initialized with
the time of day.
Test: fast/loader/stateobjects/document-destroyed-navigate-back.html
- dom/Document.cpp: (WebCore::Document::detach):
- dom/Document.h:
- history/BackForwardList.cpp: (WebCore::BackForwardList::pushStateItem):
- history/BackForwardListChromium.cpp: (WebCore::BackForwardList::pushStateItem):
- history/HistoryItem.cpp: (WebCore::generateDocumentSequenceNumber): (WebCore::HistoryItem::HistoryItem): (WebCore::HistoryItem::~HistoryItem): (WebCore::HistoryItem::setStateObject):
- history/HistoryItem.h: (WebCore::HistoryItem::setDocumentSequenceNumber): (WebCore::HistoryItem::documentSequenceNumber):
- loader/FrameLoader.cpp: (WebCore::FrameLoader::navigateWithinDocument): (WebCore::FrameLoader::loadItem):
- loader/HistoryController.cpp: (WebCore::HistoryController::updateBackForwardListForFragmentScroll): (WebCore::HistoryController::pushState): (WebCore::HistoryController::replaceState):
- loader/RedirectScheduler.cpp: (WebCore::RedirectScheduler::scheduleHistoryNavigation):
- page/History.cpp: (WebCore::History::stateObjectAdded):
- page/Page.cpp: (WebCore::Page::goToItem):
- 11:22 AM Changeset in webkit [53860] by
-
- 2 edits in trunk/JavaScriptCore
2010-01-26 Oliver Hunt <oliver@apple.com>
Reviewed by Geoffrey Garen.
Using JavaScriptCore API with a webkit vended context can result in slow script dialog
https://bugs.webkit.org/show_bug.cgi?id=34172
Make the APIShim correctly increment and decrement the timeout
entry counter.
- API/APIShims.h: (JSC::APIEntryShimWithoutLock::APIEntryShimWithoutLock): (JSC::APIEntryShimWithoutLock::~APIEntryShimWithoutLock): (JSC::APICallbackShim::APICallbackShim): (JSC::APICallbackShim::~APICallbackShim):
- 11:00 AM Changeset in webkit [53859] by
-
- 3 edits in trunk/LayoutTests
One more attempt to get GTK version to pass.
Add ability for image maps to be focused via tabbing
https://bugs.webkit.org/show_bug.cgi?id=17513
- fast/events/tab-imagemap-expected.txt:
- fast/events/tab-imagemap.html:
- 10:51 AM Changeset in webkit [53858] by
-
- 2 edits in trunk/LayoutTests
Unreviewed.
Attempt to make this test pass on GTK.
Add ability for image maps to be focused via tabbing
https://bugs.webkit.org/show_bug.cgi?id=17513
- fast/events/tab-imagemap.html:
- 10:06 AM Changeset in webkit [53857] by
-
- 25 edits2 adds in trunk
Add ability for image maps to be focused via tabbing
https://bugs.webkit.org/show_bug.cgi?id=17513
Reviewed by Darin Adler.
WebCore:
Test: fast/events/tab-imagemap.html
- accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::focusedImageMapUIElement):
(WebCore::AXObjectCache::focusedUIElementForPage):
- accessibility/AXObjectCache.h:
- accessibility/AccessibilityImageMapLink.h:
(WebCore::AccessibilityImageMapLink::areaElement):
(WebCore::AccessibilityImageMapLink::mapElement):
(WebCore::AccessibilityImageMapLink::isImageMapLink):
- accessibility/AccessibilityObject.h:
(WebCore::AccessibilityObject::isImageMapLink):
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::accessibilityParentForImageMap):
- html/HTMLAreaElement.cpp:
(WebCore::HTMLAreaElement::getPath):
(WebCore::HTMLAreaElement::getRect):
(WebCore::HTMLAreaElement::imageElement):
(WebCore::HTMLAreaElement::isKeyboardFocusable):
(WebCore::HTMLAreaElement::isFocusable):
(WebCore::HTMLAreaElement::dispatchBlurEvent):
(WebCore::HTMLAreaElement::updateFocusAppearance):
(WebCore::HTMLAreaElement::supportsFocus):
- html/HTMLAreaElement.h:
- html/HTMLMapElement.cpp:
(WebCore::HTMLMapElement::imageElement):
- html/HTMLMapElement.h:
- platform/graphics/GraphicsContext.h:
- platform/graphics/cairo/GraphicsContextCairo.cpp:
(WebCore::GraphicsContext::drawFocusRing):
- platform/graphics/haiku/GraphicsContextHaiku.cpp:
(WebCore::GraphicsContext::drawFocusRing):
- platform/graphics/mac/GraphicsContextMac.mm:
(WebCore::drawFocusRingToContext):
(WebCore::GraphicsContext::drawFocusRing):
- platform/graphics/qt/GraphicsContextQt.cpp:
(WebCore::GraphicsContext::drawFocusRing):
- platform/graphics/skia/GraphicsContextSkia.cpp:
(WebCore::GraphicsContext::drawFocusRing):
- platform/graphics/win/GraphicsContextCGWin.cpp:
(WebCore::GraphicsContext::drawFocusRing):
- platform/graphics/wince/GraphicsContextWince.cpp:
(WebCore::GraphicsContext::drawFocusRing):
- platform/graphics/wx/GraphicsContextWx.cpp:
(WebCore::GraphicsContext::drawFocusRing):
- rendering/RenderImage.cpp:
(WebCore::RenderImage::paint):
(WebCore::RenderImage::paintFocusRings):
(WebCore::RenderImage::imageMap):
- rendering/RenderImage.h:
- rendering/RenderReplaced.h:
LayoutTests:
- fast/events/resources/tabindex-focus-blur-all.js:
(test):
(testProgrammaticFocus):
- fast/events/tab-imagemap-expected.txt: Added.
- fast/events/tab-imagemap.html: Added.
- fast/events/tabindex-focus-blur-all-expected.txt:
- 8:39 AM Changeset in webkit [53856] by
-
- 6 edits in trunk/WebCore
2010-01-26 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: add support for breakpoints, messages and search into the SourceFrame2.
- inspector/front-end/SourceFrame2.js: (WebInspector.SourceFrame2): (WebInspector.SourceFrame2.prototype.get executionLine): (WebInspector.SourceFrame2.prototype.set executionLine): (WebInspector.SourceFrame2.prototype.revealLine): (WebInspector.SourceFrame2.prototype.addBreakpoint): (WebInspector.SourceFrame2.prototype.removeBreakpoint): (WebInspector.SourceFrame2.prototype.sizeToFitContentHeight): (WebInspector.SourceFrame2.prototype.setContent): (WebInspector.SourceFrame2.prototype.findSearchMatches): (WebInspector.SourceFrame2.prototype.setSelection): (WebInspector.SourceFrame2.prototype._addMessageToSource): (WebInspector.SourceFrame2.prototype._addExistingBreakpointsToSource): (WebInspector.SourceFrame2.prototype._addBreakpointToSource): (WebInspector.SourceFrame2.prototype._removeBreakpointFromSource): (WebInspector.SourceFrame2.prototype._contextMenu.addConditionalBreakpoint): (WebInspector.SourceFrame2.prototype._contextMenu): (WebInspector.SourceFrame2.prototype._toggleBreakpoint): (WebInspector.SourceFrame2.prototype._editBreakpointCondition.committed): (WebInspector.SourceFrame2.prototype._editBreakpointCondition.dismissed): (WebInspector.SourceFrame2.prototype._editBreakpointCondition): (WebInspector.SourceFrame2.prototype._showBreakpointConditionPopup): (WebInspector.SourceFrame2.prototype._createConditionElement): (WebInspector.SourceFrame2.prototype._keyDown): (WebInspector.SourceFrame2.prototype._evalSelectionInCallFrame): (WebInspector.SourceFrame2.prototype._breakpointChanged): (WebInspector.SourceFrame2.prototype.resize): (WebInspector.BreakpointLineNumberDecorator.prototype.decorate): (WebInspector.BreakpointLineNumberDecorator.prototype._paintBreakpoint): (WebInspector.BreakpointLineNumberDecorator.prototype.mouseDown): (WebInspector.BreakpointLineNumberDecorator.prototype.contextMenu): (WebInspector.ExecutionLineDecorator.prototype.decorate):
- inspector/front-end/TextEditor.js: (WebInspector.TextEditor): (WebInspector.TextEditor.prototype.set mimeType): (WebInspector.TextEditor.prototype.set readOnly): (WebInspector.TextEditor.prototype.setDivDecoration): (WebInspector.TextEditor.prototype.reveal): (WebInspector.TextEditor.prototype.packAndRepaintAll): (WebInspector.TextEditor.prototype._updateSize): (WebInspector.TextEditor.prototype.updateCanvasSize): (WebInspector.TextEditor.prototype.repaintAll): (WebInspector.TextEditor.prototype._paintLinesContinuation): (WebInspector.TextEditor.prototype._repaintOnScroll): (WebInspector.TextEditor.prototype._mouseDown): (WebInspector.TextEditor.prototype._contextMenu): (WebInspector.TextEditor.prototype._caretForMouseEvent): (WebInspector.TextEditor.prototype._columnForOffset): (WebInspector.TextEditor.prototype._handleNavigationKey): (WebInspector.TextEditor.prototype._positionDivDecoration): (WebInspector.TextEditor.prototype._replaceSelectionWith): (WebInspector.TextEditor.prototype.setCoalescingUpdate): (WebInspector.TextEditor.prototype._handleUndo): (WebInspector.TextEditor.prototype._handleRedo): (WebInspector.TextEditor.prototype._changeFont):
- inspector/front-end/TextEditorHighlighter.js: (WebInspector.TextEditorHighlighter): (WebInspector.TextEditorHighlighter.prototype.set mimeType):
- inspector/front-end/inspector.css:
- inspector/front-end/textEditor.css:
- 8:33 AM Changeset in webkit [53855] by
-
- 11 edits in trunk/WebCore
2010-01-26 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hather.
Web Inspector: add methods for getting resource content from within frontend.
- inspector/InspectorBackend.cpp: (WebCore::InspectorBackend::getResourceContent):
- inspector/InspectorBackend.h:
- inspector/InspectorBackend.idl:
- inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::didGetResourceContent):
- inspector/InspectorFrontend.h:
- inspector/InspectorFrontendHost.cpp:
- inspector/InspectorFrontendHost.h:
- inspector/InspectorFrontendHost.idl:
- inspector/front-end/InspectorBackendStub.js: (.WebInspector.InspectorBackendStub.prototype.getResourceContent):
- inspector/front-end/InspectorFrontendHostStub.js:
- 7:18 AM QtWebKitBackportingFixes edited by
- (diff)
- 7:09 AM Changeset in webkit [53854] by
-
- 2 edits in trunk/JavaScriptCore
[Qt] Fix compilation of QtScript with non-gcc compilers
Variable length stack arrays are a gcc extension. Use QVarLengthArray
as a more portable solution that still tries to allocate on the stack
first.
- qt/api/qscriptvalue_p.h:
(QScriptValuePrivate::call):
- 6:13 AM Changeset in webkit [53853] by
-
- 2 edits in trunk/JavaScriptCore
[Qt] Fix the build on platforms without JIT support.
Reviewed by Tor Arne Vestbø.
The JIT support should be determined at compile-time via wtf/Platform.h
- qt/api/QtScript.pro:
- 6:02 AM Changeset in webkit [53852] by
-
- 2 edits in trunk/WebCore
2010-01-26 Pavel Feldman <pfeldman@chromium.org>
Not reviewed: added null check into the timeline agent getter.
- inspector/InspectorTimelineAgent.h: (WebCore::InspectorTimelineAgent::retrieve):
- 5:39 AM Changeset in webkit [53851] by
-
- 2 edits in trunk/WebKit/qt
2010-01-26 Simon Hausmann <simon.hausmann@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Show comboboxes on Maemo 5
https://bugs.webkit.org/show_bug.cgi?id=34088
Don't try to show the combobox by simulating a mouse event from QCursor::pos() to
get the combobox position right. The position on Maemo 5 is independent from the mouse
and there's no QCursor::pos().
- WebCoreSupport/QtFallbackWebPopup.cpp: (WebCore::QtFallbackWebPopup::show):
- 5:00 AM Changeset in webkit [53850] by
-
- 5 edits21 adds in trunk
2010-01-26 Jedrzej Nowacki <jedrzej.nowacki@nokia.com>
Reviewed by Simon Hausmann.
First steps of the QtScript API.
Two new classes were created; QScriptEngine and QScriptValue.
The first should encapsulate a javascript context and the second a script
value.
This API is still in development, so it isn't compiled by default.
To trigger compilation, pass --qmakearg="CONFIG+=build-qtscript" to
build-webkit.
- WebKit.pro:
2010-01-26 Jedrzej Nowacki <jedrzej.nowacki@nokia.com>
Reviewed by Simon Hausmann.
First steps of the QtScript API.
Two new classes were created; QScriptEngine and QScriptValue.
The first should encapsulate a javascript context and the second a script
value.
This API is still in development, so it isn't compiled by default.
To trigger compilation, pass --qmakearg="CONFIG+=build-qtscript" to
build-webkit.
- qt/api/QtScript.pro: Added.
- qt/api/qscriptconverter_p.h: Added. (QScriptConverter::toString):
- qt/api/qscriptengine.cpp: Added. (QScriptEngine::QScriptEngine): (QScriptEngine::~QScriptEngine): (QScriptEngine::evaluate): (QScriptEngine::collectGarbage):
- qt/api/qscriptengine.h: Added.
- qt/api/qscriptengine_p.cpp: Added. (QScriptEnginePrivate::QScriptEnginePrivate): (QScriptEnginePrivate::~QScriptEnginePrivate): (QScriptEnginePrivate::evaluate):
- qt/api/qscriptengine_p.h: Added. (QScriptEnginePrivate::get): (QScriptEnginePrivate::collectGarbage): (QScriptEnginePrivate::makeJSValue): (QScriptEnginePrivate::context):
- qt/api/qscriptvalue.cpp: Added. (QScriptValue::QScriptValue): (QScriptValue::~QScriptValue): (QScriptValue::isValid): (QScriptValue::isBool): (QScriptValue::isBoolean): (QScriptValue::isNumber): (QScriptValue::isNull): (QScriptValue::isString): (QScriptValue::isUndefined): (QScriptValue::isError): (QScriptValue::isObject): (QScriptValue::isFunction): (QScriptValue::toString): (QScriptValue::toNumber): (QScriptValue::toBool): (QScriptValue::toBoolean): (QScriptValue::toInteger): (QScriptValue::toInt32): (QScriptValue::toUInt32): (QScriptValue::toUInt16): (QScriptValue::call): (QScriptValue::engine): (QScriptValue::operator=): (QScriptValue::equals): (QScriptValue::strictlyEquals):
- qt/api/qscriptvalue.h: Added. (QScriptValue::):
- qt/api/qscriptvalue_p.h: Added. (QScriptValuePrivate::): (QScriptValuePrivate::get): (QScriptValuePrivate::QScriptValuePrivate): (QScriptValuePrivate::isValid): (QScriptValuePrivate::isBool): (QScriptValuePrivate::isNumber): (QScriptValuePrivate::isNull): (QScriptValuePrivate::isString): (QScriptValuePrivate::isUndefined): (QScriptValuePrivate::isError): (QScriptValuePrivate::isObject): (QScriptValuePrivate::isFunction): (QScriptValuePrivate::toString): (QScriptValuePrivate::toNumber): (QScriptValuePrivate::toBool): (QScriptValuePrivate::toInteger): (QScriptValuePrivate::toInt32): (QScriptValuePrivate::toUInt32): (QScriptValuePrivate::toUInt16): (QScriptValuePrivate::equals): (QScriptValuePrivate::strictlyEquals): (QScriptValuePrivate::assignEngine): (QScriptValuePrivate::call): (QScriptValuePrivate::engine): (QScriptValuePrivate::context): (QScriptValuePrivate::value): (QScriptValuePrivate::object): (QScriptValuePrivate::inherits): (QScriptValuePrivate::isJSBased): (QScriptValuePrivate::isNumberBased): (QScriptValuePrivate::isStringBased):
- qt/api/qtscriptglobal.h: Added.
- qt/tests/qscriptengine/qscriptengine.pro: Added.
- qt/tests/qscriptengine/tst_qscriptengine.cpp: Added. (tst_QScriptEngine::tst_QScriptEngine): (tst_QScriptEngine::~tst_QScriptEngine): (tst_QScriptEngine::init): (tst_QScriptEngine::cleanup): (tst_QScriptEngine::collectGarbage): (tst_QScriptEngine::evaluate):
- qt/tests/qscriptvalue/qscriptvalue.pro: Added.
- qt/tests/qscriptvalue/tst_qscriptvalue.cpp: Added. (tst_QScriptValue::tst_QScriptValue): (tst_QScriptValue::~tst_QScriptValue): (tst_QScriptValue::init): (tst_QScriptValue::cleanup): (tst_QScriptValue::ctor): (tst_QScriptValue::toString_data): (tst_QScriptValue::toString): (tst_QScriptValue::copyConstructor_data): (tst_QScriptValue::copyConstructor): (tst_QScriptValue::assignOperator_data): (tst_QScriptValue::assignOperator): (tst_QScriptValue::dataSharing): (tst_QScriptValue::constructors_data): (tst_QScriptValue::constructors): (tst_QScriptValue::call):
- qt/tests/tests.pri: Added.
- qt/tests/tests.pro: Added.
2010-01-26 Jedrzej Nowacki <jedrzej.nowacki@nokia.com>
Reviewed by Simon Hausmann.
First steps of the QtScript API.
Two new classes were created; QScriptEngine and QScriptValue.
The first should encapsulate a javascript context and the second a script
value.
This API is still in development, so it isn't compiled by default.
To trigger compilation, pass --qmakearg="CONFIG+=build-qtscript" to
build-webkit.
- docs/qtwebkit.qdocconf:
- 4:05 AM Changeset in webkit [53849] by
-
- 9 edits1 copy1 add in trunk/WebCore
2010-01-26 Steve Block <steveblock@google.com>
Reviewed by Adam Barth.
Moves JSC-specific classes from bridge/jni/JNIBridge to bridge/jni/jsc/JNIBridgeJSC
https://bugs.webkit.org/show_bug.cgi?id=33958
This allows bridge/jni/JNIBridge to be used with both JSC and V8.
A later change will add the V8 equivalent of these JSC-specific classes.
No new tests, refactoring only.
- Android.jscbindings.mk: Modified. Added JNIBridgeJSC.cpp
- GNUmakefile.am: Modified. Added JNIBridgeJSC.h
- WebCore.xcodeproj/project.pbxproj: Modified. Added JNIBridgeJSC.[cpp|h]
- bridge/jni/JNIBridge.cpp: Modified. Moved JavaField and JavaArray to JNIBridgeJSC.cpp (appendClassName): Modfied. Guard calls to JSLock (JavaMethod::signature): Modfied. Guard calls to JSLock
- bridge/jni/JNIBridge.h: Modified. Moved JavaField and JavaArray to JNIBridgeJSC.h
- bridge/jni/jsc/JNIBridgeJSC.cpp: Copied from WebCore/bridge/jni/JNIBridge.cpp.
- bridge/jni/jsc/JNIBridgeJSC.h: Copied from WebCore/bridge/jni/JNIBridge.h.
- bridge/jni/jsc/JNIUtilityPrivate.cpp: Modified. Include JNIBridgeJSC.h
- bridge/jni/jsc/JavaClassJSC.h: Modified. Include JNIBridgeJSC.h
- bridge/jni/jsc/JavaInstanceJSC.cpp: Modified. Include JNIBridgeJSC.h
- 3:06 AM Changeset in webkit [53848] by
-
- 3 edits in trunk/WebCore
Unreviewed build fix.
[Qt] Fix Windows build when sqlite is not available.
- WebCore.pri:
- WebCore.pro:
- 2:44 AM QtWebKitBackportingFixes edited by
- (diff)
- 2:40 AM Changeset in webkit [53847] by
-
- 4 edits1 delete in trunk
WebCore: [Qt] JavaScript prompt is currently broken.
https://bugs.webkit.org/show_bug.cgi?id=30914
Patch by Holger Hans Peter Freyther <zecke@selfish.org> on 2010-01-26
Reviewed by Simon Hausmann.
Remove the manual test case in favor of an automated
test case in WebKit/qt/tests/qwebpage.
- manual-tests/qt/java-script-prompt.html: Removed.
WebKit/qt: [Qt] JavaScript prompt is currently broken
https://bugs.webkit.org/show_bug.cgi?id=30914
Patch by Holger Hans Peter Freyther <zecke@selfish.org> on 2010-01-26
Reviewed by Simon Hausmann.
In r52152 a patch was landed to convert a null QString
to an empty WebCore::String in case the prompt was accepted
but the default implementation returned the null QString.
The patch tried to avoid assign to result twice and
was not checking the QString if it is null but the default
value. This lead to always returning an empty string on
successful prompts. Fix it by checking the variable 'x'
for isNull.
The manual test case used didn't cover the case of non
empty input, replace it with an automatic test case that
should cover all cases.
- WebCoreSupport/ChromeClientQt.cpp:
(WebCore::ChromeClientQt::runJavaScriptPrompt): Fix the bug.
- tests/qwebpage/tst_qwebpage.cpp: Add automatic test case
(JSPromptPage::JSPromptPage):
(JSPromptPage::javaScriptPrompt):
(tst_QWebPage::testJSPrompt):
- 2:18 AM Changeset in webkit [53846] by
-
- 6 edits2 moves4 adds in trunk/WebCore
2010-01-26 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: Implement HTML and CSS highlighters.
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- inspector/front-end/JavaScriptTokenizer.js: Removed.
- inspector/front-end/JavaScriptTokenizer.re2js: Removed.
- inspector/front-end/SourceCSSTokenizer.js: Added. (WebInspector.SourceCSSTokenizer): (WebInspector.SourceCSSTokenizer.prototype._stringToken): (WebInspector.SourceCSSTokenizer.prototype._isPropertyValue): (WebInspector.SourceCSSTokenizer.prototype.nextToken):
- inspector/front-end/SourceCSSTokenizer.re2js: Added.
- inspector/front-end/SourceHTMLTokenizer.js: Added. (WebInspector.SourceHTMLTokenizer): (WebInspector.SourceHTMLTokenizer.prototype._stringToken): (WebInspector.SourceHTMLTokenizer.prototype.nextToken):
- inspector/front-end/SourceHTMLTokenizer.re2js: Added.
- inspector/front-end/SourceJavaScriptTokenizer.js: Added. (WebInspector.SourceJavaScriptTokenizer): (WebInspector.SourceJavaScriptTokenizer.prototype.nextToken):
- inspector/front-end/SourceJavaScriptTokenizer.re2js: Added.
- inspector/front-end/TextEditorHighlighter.js: (WebInspector.TextEditorHighlighter): (WebInspector.TextEditorHighlighter.prototype._highlightLines): (WebInspector.TextEditorHighlighter.Tokenizer): (WebInspector.TextEditorHighlighter.Tokenizer.prototype.set line): (WebInspector.TextEditorHighlighter.Tokenizer.prototype.set condition): (WebInspector.TextEditorHighlighter.Tokenizer.prototype.get condition): (WebInspector.TextEditorHighlighter.Tokenizer.prototype.hasCondition): (WebInspector.TextEditorHighlighter.Tokenizer.prototype.getLexCondition): (WebInspector.TextEditorHighlighter.Tokenizer.prototype.setLexCondition): (WebInspector.TextEditorHighlighter.Tokenizer.prototype._charAt):
- inspector/front-end/WebKit.qrc:
- inspector/front-end/inspector.html:
- 2:04 AM Changeset in webkit [53845] by
-
- 3 edits1 add in trunk
REGRESSION(r53835): Fix editing/pasteboard/paste-noscript-xhtml.xhtml
https://bugs.webkit.org/show_bug.cgi?id=34157
Reviewed by Holger Freyther.
WebCore:
Pass the FragmentScriptingPermission correctly through to the DOM
and disallow scripting elements in parseEndElement(), similar to
the libxml tokenizer change in r53835.
- dom/XMLTokenizerQt.cpp:
(WebCore::handleElementNamespaces):
(WebCore::handleElementAttributes):
(WebCore::XMLTokenizer::parseStartElement):
(WebCore::XMLTokenizer::parseEndElement):
LayoutTests:
Add Qt specific result for this test that differs from the cross-platform
result in only one character: In htmlcontent.html the href attribute value
is http://www.cnn.com, which somehow becomes http://www.cnn.com/ in the cross
platform result. With the Qt xml parser that attribute is somehow preserved
and so our result does not have the trailing slash.
- platform/qt/editing/pasteboard/paste-noscript-xhtml-expected.txt: Added.
- 1:42 AM Changeset in webkit [53844] by
-
- 2 edits2 adds5 deletes in trunk/LayoutTests
2010-01-26 Kent Tamura <tkent@chromium.org>
Reviewed by Shinichiro Hamaji.
Convert textarea-rows-cols.html to dumpAsText()
https://bugs.webkit.org/show_bug.cgi?id=34074
- fast/forms/script-tests/textarea-rows-cols.js: Added.
- fast/forms/textarea-rows-cols-expected.txt: Added.
- fast/forms/textarea-rows-cols.html:
- platform/mac/fast/forms/textarea-rows-cols-expected.checksum: Removed.
- platform/mac/fast/forms/textarea-rows-cols-expected.png: Removed.
- platform/mac/fast/forms/textarea-rows-cols-expected.txt: Removed.
- platform/qt/fast/forms/textarea-rows-cols-expected.txt: Removed.
- platform/win/fast/forms/textarea-rows-cols-expected.txt: Removed.
- 1:40 AM Changeset in webkit [53843] by
-
- 2 edits in trunk/WebCore
2010-01-26 Garret Kelly <gdk@chromium.org>
Reviewed by Eric Seidel.
Add missing declaration for the feMorphology SVG element.
https://bugs.webkit.org/show_bug.cgi?id=34151
- bindings/v8/V8DOMWrapper.cpp:
- 12:30 AM Changeset in webkit [53842] by
-
- 2 edits in trunk/WebCore
Unreviewed build fix.
Patch by Andras Becsi <abecsi@inf.u-szeged.hu> on 2010-01-26
[Qt] Build fix after API changes in r53835.
No new tests needed.
- dom/XMLTokenizerQt.cpp:
(WebCore::XMLTokenizer::XMLTokenizer):
(WebCore::parseXMLDocumentFragment):
