Timeline
Feb 4, 2016:
- 9:57 PM Changeset in webkit [196166] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: console.table background stripes are misaligned
https://bugs.webkit.org/show_bug.cgi?id=152954
<rdar://problem/24197735>
Reviewed by Timothy Hatcher.
- UserInterface/Views/LogContentView.css:
(.console-item .data-grid table.data):
(.console-item .data-grid table.data tr:nth-child(even)):
Replace CSS gradient that produces fixed height stripes with
a rule that sets background only on even table rows.
- 9:24 PM Changeset in webkit [196165] by
-
- 64 edits in trunk
Web Inspector: InspectorTimelineAgent doesn't need to recompile functions because it now uses the sampling profiler
https://bugs.webkit.org/show_bug.cgi?id=153500
<rdar://problem/24352458>
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-02-04
Reviewed by Timothy Hatcher.
Source/JavaScriptCore:
Be more explicit about enabling legacy profiling.
- jsc.cpp:
- runtime/Executable.cpp:
(JSC::ScriptExecutable::newCodeBlockFor):
- runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::hasLegacyProfiler):
(JSC::JSGlobalObject::createProgramCodeBlock):
(JSC::JSGlobalObject::createEvalCodeBlock):
(JSC::JSGlobalObject::createModuleProgramCodeBlock):
(JSC::JSGlobalObject::hasProfiler): Deleted.
- runtime/JSGlobalObject.h:
(JSC::JSGlobalObject::supportsLegacyProfiling):
(JSC::JSGlobalObject::supportsProfiling): Deleted.
Source/WebCore:
- bindings/js/JSDOMWindowBase.cpp:
(WebCore::JSDOMWindowBase::supportsLegacyProfiling):
(WebCore::JSDOMWindowBase::supportsRichSourceInfo):
(WebCore::JSDOMWindowBase::supportsProfiling): Deleted.
- bindings/js/JSDOMWindowBase.h:
- bindings/js/JSWorkerGlobalScopeBase.cpp:
(WebCore::JSWorkerGlobalScopeBase::supportsLegacyProfiling):
(WebCore::JSWorkerGlobalScopeBase::supportsProfiling): Deleted.
- bindings/js/JSWorkerGlobalScopeBase.h:
- inspector/InspectorController.h:
- inspector/InspectorController.cpp:
(WebCore::InspectorController::legacyProfilerEnabled):
(WebCore::InspectorController::setLegacyProfilerEnabled):
Be more explicit about enabling legacy profiling.
- inspector/InspectorTimelineAgent.cpp:
(WebCore::InspectorTimelineAgent::willDestroyFrontendAndBackend):
(WebCore::InspectorTimelineAgent::didCreateFrontendAndBackend): Deleted.
TimelineAgent doesn't need to recompile if using the sampling profiler.
This breaks console.profile, but console.profile should move to using
the sampling profiler as well.
(WebCore::InspectorTimelineAgent::startFromConsole):
(WebCore::InspectorTimelineAgent::stopFromConsole):
(WebCore::startProfiling): Deleted.
(WebCore::stopProfiling): Deleted.
Inlined the use once static functions.
- page/PageConsoleClient.cpp:
(WebCore::PageConsoleClient::profile):
(WebCore::PageConsoleClient::profileEnd):
Added FIXMEs for improving console.profile and profileEnd.
- testing/Internals.cpp:
(WebCore::Internals::resetToConsistentState):
(WebCore::Internals::setLegacyJavaScriptProfilingEnabled):
(WebCore::Internals::setJavaScriptProfilingEnabled): Deleted.
- testing/Internals.h:
- testing/Internals.idl:
Be more explicit about enabling legacy profiling.
Source/WebKit/win:
- WebInspector.cpp:
(WebInspector::isJavaScriptProfilingEnabled):
(WebInspector::setJavaScriptProfilingEnabled):
Switch to the new API names.
LayoutTests:
- fast/profiler/*.html
Be more explicit about enabling legacy profiling.
- inspector/sampling-profiler/eval-source-url.html
Remove an inner loop that was causing tail call optimizations
to eliminate the sourceURL we were expecting.
- 6:01 PM Changeset in webkit [196164] by
-
- 2 edits in trunk/Source/WebCore
Follow-up: Add "WebKit built-in PDF" Plugin to set of publicly visible plugins
https://bugs.webkit.org/show_bug.cgi?id=153657
<rdar://problem/24413107>
Reviewed by Darin Adler.
- plugins/PluginData.cpp:
(WebCore::shouldBePubliclyVisible): Revise comments to provide a
better explanation of the function and why it exists.
- 5:31 PM Changeset in webkit [196163] by
-
- 2 edits6 deletes in trunk/Source/WebInspectorUI
Unreviewed, follow-up fix to r196151 that removes some more images.
- UserInterface/Images/Colors.png: Removed.
- UserInterface/Images/Colors@2x.png: Removed.
- UserInterface/Images/Network.png: Removed.
- UserInterface/Images/Network@2x.png: Removed.
- UserInterface/Images/Script.png: Removed.
- UserInterface/Images/Script@2x.png: Removed.
These images were supposed to also be removed.
- WebInspectorUI.vcxproj/WebInspectorUI.vcxproj:
Also remove references to now removed images.
- 5:20 PM Changeset in webkit [196162] by
-
- 5 edits in branches/safari-601-branch/Source
Versioning.
- 5:19 PM Changeset in webkit [196161] by
-
- 5 edits in branches/safari-601.1.46-branch/Source
Versioning.
- 5:18 PM Changeset in webkit [196160] by
-
- 1 copy in tags/Safari-601.1.46.97
New tag.
- 5:18 PM Changeset in webkit [196159] by
-
- 1 copy in tags/Safari-601.5.15
New tag.
- 4:51 PM Changeset in webkit [196158] by
-
- 2 edits in trunk/Tools
The status message for passing combined builder queues should say "all builds succeeded" when expanded. https://bugs.webkit.org/show_bug.cgi?id=153882
Reviewed by Alexey Proskuryakov.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js:
(BuildbotCombinedQueueView.prototype.update): Set status to "all builds succeeded" for combined builder queues
when expanded.
- 4:46 PM Changeset in webkit [196157] by
-
- 2 edits in trunk/LayoutTests
Unreviewed. EFL gardening. Mark some video tests to failure.
- platform/efl/TestExpectations:
- 4:42 PM Changeset in webkit [196156] by
-
- 1 edit1 delete in trunk/LayoutTests
Remove ios-simulator-wk2 specific expectation for imported/w3c/web-platform-tests/html/dom/interfaces.html
https://bugs.webkit.org/show_bug.cgi?id=153844
Unreviewed test gardening.
- platform/ios-simulator-wk2/imported/w3c/web-platform-tests/html/dom/interfaces-expected.txt: Removed.
- 4:36 PM Changeset in webkit [196155] by
-
- 5 edits in trunk/Source/JavaScriptCore
ArrayPrototype should have a destroy function
https://bugs.webkit.org/show_bug.cgi?id=153847
Reviewed by Filip Pizlo.
ArrayPrototype should have an destroy function as it now has a unique_ptr member that
needs to be freed at the end of the object's life cycle. Also, this patch adds an
option, gcAtEnd, that will cause jsc.cpp to do a garbage collection before exiting.
- jsc.cpp:
(runJSC):
(jscmain):
- runtime/ArrayPrototype.cpp:
(JSC::ArrayPrototype::create):
(JSC::ArrayPrototype::destroy):
- runtime/ArrayPrototype.h:
- runtime/Options.h:
- 3:54 PM Changeset in webkit [196154] by
-
- 2 edits in trunk/Source/WebCore
Add Fetch API and CSS Variables to feature status
https://bugs.webkit.org/show_bug.cgi?id=153896
Reviewed by Timothy Hatcher.
- features.json:
- 3:47 PM Changeset in webkit [196153] by
-
- 2 edits in trunk/LayoutTests
Rebaseline imported/w3c/web-platform-tests/html/dom/interfaces.html for ios-simulator
https://bugs.webkit.org/show_bug.cgi?id=153844
Reviewed by Chris Dumez.
- platform/ios-simulator/imported/w3c/web-platform-tests/html/dom/interfaces-expected.txt:
- 3:23 PM Changeset in webkit [196152] by
-
- 6 edits in trunk/Source/JavaScriptCore
REGRESSION(192409): Cannot rely on add32() to zero-extend
https://bugs.webkit.org/show_bug.cgi?id=153897
Unreviewed rollout of r192409.
- assembler/MacroAssemblerARM64.h:
(JSC::MacroAssemblerARM64::add32):
(JSC::MacroAssemblerARM64::add64):
- assembler/MacroAssemblerARMv7.h:
(JSC::MacroAssemblerARMv7::add32):
- assembler/MacroAssemblerX86.h:
(JSC::MacroAssemblerX86::add32):
- assembler/MacroAssemblerX86Common.h:
(JSC::MacroAssemblerX86Common::add32):
(JSC::MacroAssemblerX86Common::add8):
(JSC::MacroAssemblerX86Common::branchAdd32):
(JSC::MacroAssemblerX86Common::generateTest32):
(JSC::MacroAssemblerX86Common::clz32AfterBsr):
(JSC::MacroAssemblerX86Common::add32AndSetFlags): Deleted.
- assembler/MacroAssemblerX86_64.h:
(JSC::MacroAssemblerX86_64::add32):
(JSC::MacroAssemblerX86_64::add64):
(JSC::MacroAssemblerX86_64::branchAdd64):
(JSC::MacroAssemblerX86_64::repatchCall):
(JSC::MacroAssemblerX86_64::clz64AfterBsr):
(JSC::MacroAssemblerX86_64::add64AndSetFlags): Deleted.
- 3:13 PM Changeset in webkit [196151] by
-
- 4 edits5 adds8 deletes in trunk/Source/WebInspectorUI
Web Inspector: New timeline images for instruments
https://bugs.webkit.org/show_bug.cgi?id=153884
<rdar://problem/24509429>
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-02-04
Reviewed by Timothy Hatcher.
- UserInterface/Views/TimelineTabContentView.js:
(WebInspector.TimelineTabContentView.iconClassNameForTimeline):
Better names and give Memory timeline a name for an icon.
- UserInterface/Views/TreeOutline.css:
(.tree-outline.large .item .icon):
Add more padding next to large icons.
- UserInterface/Images/ColorsLarge.png: Removed.
- UserInterface/Images/ColorsLarge@2x.png: Removed.
- UserInterface/Images/Frames.png: Removed.
- UserInterface/Images/Frames@2x.png: Removed.
- UserInterface/Images/LayoutInstrument.svg: Added.
- UserInterface/Images/MemoryInstrument.svg: Added.
- UserInterface/Images/NetworkInstrument.svg: Added.
- UserInterface/Images/NetworkLarge.png: Removed.
- UserInterface/Images/NetworkLarge@2x.png: Removed.
- UserInterface/Images/RenderingFramesInstrument.svg: Added.
- UserInterface/Images/ScriptLarge.png: Removed.
- UserInterface/Images/ScriptLarge@2x.png: Removed.
Remove old timeline pngs.
- UserInterface/Images/ScriptsInstrument.svg: Added.
- UserInterface/Views/TimelineIcons.css:
(.network-icon .icon):
(.script-icon .icon):
(.memory-icon .icon):
(.layout-icon .icon):
(.rendering-frame-icon .icon):
Use the new SVGs.
(body:not(.mac-platform, .windows-platform) .network-icon .icon):
(body:not(.mac-platform, .windows-platform) .network-icon.large .icon):
(body:not(.mac-platform, .windows-platform) .layout-icon .icon):
(body:not(.mac-platform, .windows-platform) .layout-icon.large .icon):
(body:not(.mac-platform, .windows-platform) .script-icon .icon):
(body:not(.mac-platform, .windows-platform) .script-icon.large .icon):
(body:not(.mac-platform, .windows-platform) .rendering-frame-icon .icon):
Fallback to old icons for non-Mac/Windows ports using Images/gtk images.
- 2:54 PM Changeset in webkit [196150] by
-
- 2 edits in trunk/LayoutTests
media/video-size.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=124932
<rdar://problem/23336430>
Reviewed by Jer Noble.
- media/video-size.html: Add logic to retry each stage silently twice before logging failure because we can't predict how long it will take to load the poster frame.
- 2:07 PM Changeset in webkit [196149] by
-
- 3 edits in trunk/Source/JavaScriptCore
Remove dead ENABLE(BYTECODE_COMMENTS) cruft.
<https://webkit.org/b/153888>
Reviewed by Antti Koivisto.
- bytecode/UnlinkedCodeBlock.cpp:
(JSC::UnlinkedCodeBlock::UnlinkedCodeBlock): Deleted.
- bytecode/UnlinkedCodeBlock.h:
(JSC::UnlinkedCodeBlock::shrinkToFit): Deleted.
- 1:52 PM Changeset in webkit [196148] by
-
- 4 edits in trunk/Source
WebKit for iOS Simulator fails to build with public iOS SDK
https://bugs.webkit.org/show_bug.cgi?id=153881
Reviewed by Alex Christensen.
Source/WebCore:
Make constants have internal linkage to match the Apple Internal SDK.
- platform/spi/ios/MobileGestaltSPI.h:
Source/WebKit2:
Add version guards around SPI that is now API as of iOS SDK 9.2. Until we upgrade the iOS EWS
and iOS buildbots to use the 9.2 SDK we need to keep these SPI declarations to avoid breaking
the build.
- Platform/spi/ios/UIKitSPI.h:
- 1:51 PM Changeset in webkit [196147] by
-
- 5 edits3 adds in trunk/Source/JavaScriptCore
JSC Sampling Profiler: (host) is confusing in cases where I would expect to see JS name
https://bugs.webkit.org/show_bug.cgi?id=153663
<rdar://problem/24415092>
Reviewed by Geoffrey Garen.
We now collect the Callee in the processed StackFrame
when the Callee is a valid GC object. We later ask
the Callee for it's .displayName or .name property.
When we don't have a valid callee, we will still
use the Executable for this information.
This helps us come up with good names for frames where
the Callee object is a bound function or an InternalFunction.
- inspector/agents/InspectorScriptProfilerAgent.cpp:
(Inspector::InspectorScriptProfilerAgent::addEvent):
(Inspector::buildSamples):
(Inspector::InspectorScriptProfilerAgent::trackingComplete):
- runtime/SamplingProfiler.cpp:
(JSC::reportStats):
(JSC::FrameWalker::walk):
(JSC::SamplingProfiler::processUnverifiedStackTraces):
(JSC::SamplingProfiler::visit):
(JSC::SamplingProfiler::shutdown):
(JSC::SamplingProfiler::clearData):
(JSC::SamplingProfiler::StackFrame::nameFromCallee):
(JSC::SamplingProfiler::StackFrame::displayName):
(JSC::SamplingProfiler::StackFrame::displayNameForJSONTests):
(JSC::SamplingProfiler::stackTracesAsJSON):
- runtime/SamplingProfiler.h:
(JSC::SamplingProfiler::UnprocessedStackFrame::UnprocessedStackFrame):
(JSC::SamplingProfiler::StackFrame::StackFrame):
- tests/stress/sampling-profiler-basic.js:
(platformSupportsSamplingProfiler.nothing):
(platformSupportsSamplingProfiler.top):
- tests/stress/sampling-profiler-bound-function-name.js: Added.
(platformSupportsSamplingProfiler.foo):
(platformSupportsSamplingProfiler.bar):
(platformSupportsSamplingProfiler.let.baz):
(platformSupportsSamplingProfiler):
- tests/stress/sampling-profiler-display-name.js: Added.
(platformSupportsSamplingProfiler.foo):
(platformSupportsSamplingProfiler.baz):
(platformSupportsSamplingProfiler.):
(platformSupportsSamplingProfiler.bar):
(platformSupportsSamplingProfiler.jaz):
(platformSupportsSamplingProfiler.makeFunction.let.result):
(platformSupportsSamplingProfiler.makeFunction):
- tests/stress/sampling-profiler-internal-function-name.js: Added.
(platformSupportsSamplingProfiler.foo):
(platformSupportsSamplingProfiler.bar):
(platformSupportsSamplingProfiler):
- 1:51 PM Changeset in webkit [196146] by
-
- 6 edits in trunk/Source/WebInspectorUI
Web Inspector: Show error icons if invalid values already exist for properties in the Visual sidebar
https://bugs.webkit.org/show_bug.cgi?id=153702
<rdar://problem/24424025>
Patch by Devin Rousso <Devin Rousso> on 2016-02-04
Reviewed by Timothy Hatcher.
When CSS properties have invalid values, instead of displaying the computed
value for that property in the Visual sidebar, show an error icon with the
the invalid value.
- Localizations/en.lproj/localizedStrings.js:
- UserInterface/Views/VisualStyleNumberInputBox.css:
(.visual-style-property-container > .visual-style-property-value-container > .number-input-container > .number-input-value):
(.visual-style-property-container > .visual-style-property-value-container > .visual-style-special-property-placeholder[hidden] ~ .number-input-container > .number-input-value):
By default, do not allow any pointer events to interact with the input element.
Instead, only allow interaction when the placeholder element is hidden to ensure
that the user cannot add a value when the computed value is displayed.
- UserInterface/Views/VisualStyleNumberInputBox.js:
(WebInspector.VisualStyleNumberInputBox.prototype.set specialPropertyPlaceholderElementText):
Reset the selected keyword to "Unchanged" since this is either a warning
message or the computed value.
- UserInterface/Views/VisualStylePropertyEditor.css:
(.visual-style-property-container > .visual-style-property-editor-warning.missing-dependency):
(.visual-style-property-container > .visual-style-property-editor-warning.invalid-value):
(.visual-style-property-container > .visual-style-property-editor-warning):
- UserInterface/Views/VisualStylePropertyEditor.js:
(WebInspector.VisualStylePropertyEditor):
Replaced document.createElement with [element].createChild for simplicity.
(WebInspector.VisualStylePropertyEditor.prototype.update):
Before assigning the value of the property to the editor, check to see if
the property is valid. If not, display an Error icon and message stating
that the current value is invalid.
(WebInspector.VisualStylePropertyEditor.prototype.updateEditorValues):
(WebInspector.VisualStylePropertyEditor.prototype.set specialPropertyPlaceholderElementText):
Unhides the special placeholder element with the given text as its content.
(WebInspector.VisualStylePropertyEditor.prototype._valueDidChange):
(WebInspector.VisualStylePropertyEditor.prototype._checkDependencies):
(WebInspector.VisualStylePropertyEditor.prototype.addDependency):
- 1:36 PM Changeset in webkit [196145] by
-
- 19 edits6 adds in trunk
Object.getOwnPropertyDescriptor() returns incomplete descriptor for instance properties
https://bugs.webkit.org/show_bug.cgi?id=153817
Reviewed by Geoffrey Garen.
LayoutTests/imported/w3c:
Rebaseline W3C HTML test now that more checks are passing. Some checks are still
failing because getter.call(undefined) / getter.call() currently throws an exception
for Window properties but shouldn't. Global object property getters should not require
an explicit |this|.
- web-platform-tests/html/dom/interfaces-expected.txt:
Source/JavaScriptCore:
Extend support for Object.getOwnPropertyDescriptor() on native bindings
to instance properties (e.g. Unforgeable properties or Global object
properties) so that the returned descriptor has getter / setter
functions, as expected.
- runtime/JSObject.cpp:
(JSC::JSObject::reifyAllStaticProperties):
Add method that reifies all static properties, including the custom
accessors. This is similar to what is done eagerly on the prototype
objects in the bindings code.
(JSC::JSObject::getOwnPropertyDescriptor):
getOwnPropertyDescriptor() would previously fails for custom accessors
that are on the instance because getDirect() does not check the static
property table and those custom accessors were not reified (We only
reified all properties eagerly - including custom accessors - on
prototype objects. To address this issue, we now call
reifyAllStaticProperties() if the call to getDirect() fails and then
call getDirect() again. This fix is however insufficient for Window
properties because |this| is a JSDOMWindowShell / JSProxy in this case
and getDirect() / reifyAllStaticProperties() would fail as the proxy
does not actually have the properties. This issue was addressed by
checking if |this| is a JSProxy and then using JSProxy::target() instead
of |this| for the calls to getDirect() and for the reification.
- runtime/JSObject.h:
- runtime/Lookup.h:
(JSC::reifyStaticProperty):
(JSC::reifyStaticProperties):
Move most code in reifyStaticProperties() to a separate function so the
code can be shared with JSObject::reifyAllStaticProperties().
reifyStaticProperties() is currently called by the bindings on the
prototype objects.
Source/WebCore:
Update the bindings generator so that property getters / setters now
make sure |this| has the right type and throw a TypeError if it does
not, as per:
- http://heycam.github.io/webidl/#dfn-attribute-getter (step 2.4.2)
- http://heycam.github.io/webidl/#dfn-attribute-setter (step 3.5)
This was an issue when doing something like:
Object.getOwnPropertyDescriptor(window, "location").get.call(nonWindow)
We would call toJSDOMWindow(thisValue), which would return null as
thisValue is not a JSDOMWindow. We would then dereference this null
pointer and crash. We now do a null check and throw a TypeError in
this case, as per the Web IDL specification.
The generated bindings still have some non-spec compliant behavior
though:
- The getters / setters of instance properties use slotBase instead of thisValue, which means that calling instanceA's getter on instanceB returns instanceA's property insteas of instanceB's.
- Global object property getters should not require an explicit
|this| so calling the following should work:
- Object.getOwnPropertyDescriptor(window, "location").get.call() We currently throw in this case.
These issues will be addressed in follow-up patches.
Tests: js/getOwnPropertyDescriptor-unforgeable-attributes.html
js/getOwnPropertyDescriptor-window-attributes.html
js/instance-property-getter-other-instance.html
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateImplementation):
- bindings/scripts/test/JS/JSTestActiveDOMObject.cpp:
(WebCore::jsTestActiveDOMObjectExcitingAttr):
- bindings/scripts/test/JS/JSTestException.cpp:
(WebCore::jsTestExceptionName):
- bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::jsTestObjConstructorTestSubObj):
(WebCore::jsTestObjTestSubObjEnabledBySettingConstructor):
(WebCore::jsTestObjConditionalAttr4Constructor):
(WebCore::jsTestObjConditionalAttr5Constructor):
(WebCore::jsTestObjConditionalAttr6Constructor):
(WebCore::jsTestObjContentDocument):
(WebCore::setJSTestObjTestSubObjEnabledBySettingConstructor):
(WebCore::setJSTestObjConditionalAttr4Constructor):
(WebCore::setJSTestObjConditionalAttr5Constructor):
(WebCore::setJSTestObjConditionalAttr6Constructor):
(WebCore::setJSTestObjConstructor): Deleted.
(WebCore::setJSTestObjConstructorStaticStringAttr): Deleted.
(WebCore::setJSTestObjConditionalAttr3): Deleted.
- bindings/scripts/test/JS/JSTestTypedefs.cpp:
(WebCore::jsTestTypedefsConstructorTestSubObj):
LayoutTests:
Add layout test coverage for calling Object.getOwnPropertyDescriptor()
on instance properties (e.g. Unforgeable properties and Window properties).
- http/tests/security/cross-origin-window-property-access-expected.txt:
- http/tests/security/cross-origin-window-property-access.html:
- Fix bug causing the onload function to not find the crossOriginWindow variable.
- Update the case for accessing crossOriginWindow.location property as this is actually expected to work as per the specification: https://html.spec.whatwg.org/multipage/browsers.html#security-window
- js/dom/dom-as-prototype-assignment-exception-expected.txt:
- js/dom/getOwnPropertyDescriptor-expected.txt:
- js/dom/script-tests/dom-as-prototype-assignment-exception.js:
- js/getOwnPropertyDescriptor-unforgeable-attributes-expected.txt: Added.
- js/getOwnPropertyDescriptor-unforgeable-attributes.html: Added.
- js/getOwnPropertyDescriptor-window-attributes-expected.txt: Added.
- js/getOwnPropertyDescriptor-window-attributes.html: Added.
- js/instance-property-getter-other-instance-expected.txt: Added.
- js/instance-property-getter-other-instance.html: Added.
- js/resources/getOwnPropertyDescriptor.js:
- 1:20 PM Changeset in webkit [196144] by
-
- 2 edits in trunk/Source/JavaScriptCore
Fix internal Windows build
https://bugs.webkit.org/show_bug.cgi?id=153886
<rdar://problem/24499887>
Reviewed by Mark Lam.
- JavaScriptCore.vcxproj/JavaScriptCore.proj:
In r190253 I changed the directory of the headers from AppleInternal/include/JavaScriptCore
to AppleInternal/include/private/JavaScriptCore. This is ok for WebCore and WebKit, but not
other projects, such as CFNetwork, which expect the public API headers to be in the old location.
This used to be done by a combination of copy-files.cmd and the old JavaScriptCore.proj.
This change copies all the API headers, which copies everything in copy-files.cmd except APIShims.h
which does not exist any more. It copies additional headers that were not copied before, but
I think this is beneficial so we do not forget to add new public headers to a list of public headers
to be copied in the internal build. Having extra public headers in the internal Windows build is
not a problem because only internal clients use the internal Windows build.
- 1:14 PM Changeset in webkit [196143] by
-
- 2 edits in trunk/Tools
run-jsc-stress-tests should be better at telling you details about test failures
https://bugs.webkit.org/show_bug.cgi?id=153845
Reviewed by Geoffrey Garen.
Here's an example of the contents of results/resultsByFamily, one of the new files that this
generates, for some local testing I'm doing. Notice how it groups families of tests together.
You won't see this unless you cat results/resultsByFamily.
regress.yaml/Regress/radar-24289839.js:
regress.yaml/Regress/radar-24289839.js.default: PASS
regress.yaml/Regress/radar-24289839.js.ftl: PASS
regress.yaml/Regress/radar-24289839.js.ftl-no-cjit: FAIL
regress.yaml/Regress/radar-24289839.js.ftl-eager-no-cjit: FAIL
regress.yaml/Regress/radar-24290639.js:
regress.yaml/Regress/radar-24290639.js.default: PASS
regress.yaml/Regress/radar-24290639.js.ftl: PASS
regress.yaml/Regress/radar-24290639.js.ftl-no-cjit: PASS
regress.yaml/Regress/radar-24290639.js.ftl-eager-no-cjit: FAIL
regress.yaml/Regress/radar-24290670.js: FAILED
- Scripts/run-jsc-stress-tests:
- 1:02 PM Changeset in webkit [196142] by
-
- 6 edits in trunk/Source/WebKit2
Web Inspector: Give nested inspectors their own process pool
https://bugs.webkit.org/show_bug.cgi?id=153880
<rdar://problem/24508310>
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-02-04
Reviewed by Timothy Hatcher.
When inspecting the inspector both inspectors were using the same
Inspector process and sharing the same VM. This meant that profiling
information was confusing (memory and JavaScript sampling) because
it was showing data about both inspectors sharing the same process.
- UIProcess/WebInspectorProxy.cpp:
(WebKit::WebInspectorProxy::inspectorProcessPool):
(WebKit::WebInspectorProxy::isInspectorProcessPool):
Have two process pools. The main inspector process pool (1st level inspectors)
and a nested inspector process pool (inspecting the inspector, only expected
by WebKit developers).
- UIProcess/WebInspectorProxy.h:
- UIProcess/efl/WebInspectorProxyEfl.cpp:
(WebKit::WebInspectorProxy::platformCreateInspectorPage):
- UIProcess/gtk/WebInspectorProxyGtk.cpp:
(WebKit::WebInspectorProxy::platformCreateInspectorPage):
- UIProcess/mac/WebInspectorProxyMac.mm:
(WebKit::WebInspectorProxy::platformCreateInspectorPage):
Pass the inspectionLevel to determine the appropriate pool to use.
- 12:38 PM Changeset in webkit [196141] by
-
- 2 edits in trunk/LayoutTests
Marking imported/w3c/web-platform-tests/html/semantics/document-metadata/styling/LinkStyle.html as flaky on Mac
https://bugs.webkit.org/show_bug.cgi?id=153871
Unreviewed test gardening.
- platform/mac/TestExpectations:
- 12:26 PM Changeset in webkit [196140] by
-
- 2 edits in trunk/LayoutTests
Marking webgl/1.0.3/conformance/extensions/oes-texture-half-float-linear.html as flaky on mac
https://bugs.webkit.org/show_bug.cgi?id=153883
Unreviewed test gardening.
- platform/mac/TestExpectations:
- 12:23 PM Changeset in webkit [196139] by
-
- 2 edits in trunk/Websites/webkit.org
Fix bad link on the Feature Status page.
https://bugs.webkit.org/show_bug.cgi?id=152086
Reviewed by Timothy Hatcher.
- wp-content/themes/webkit/status.php:
- 12:06 PM Changeset in webkit [196138] by
-
- 2 edits in trunk/Source/WebKit2
Fix the !ENABLE(NETSCAPE_PLUGIN_API) build after r196053
https://bugs.webkit.org/show_bug.cgi?id=153878
Unreviewed buildfix.
- WebProcess/Plugins/Netscape/x11/NetscapePluginX11.h:
- 11:46 AM Changeset in webkit [196137] by
-
- 5 edits5 adds in trunk
Modern IDB: LayoutTest imported/w3c/indexeddb/keyorder-private.html is flaky.
https://bugs.webkit.org/show_bug.cgi?id=153438.
Reviewed by Alex Christensen.
Source/WebCore:
Tests: storage/indexeddb/modern/idbkey-array-equality-private.html
storage/indexeddb/modern/idbkey-array-equality.html
- Modules/indexeddb/IDBKeyData.cpp:
(WebCore::IDBKeyData::loggingString):
(WebCore::IDBKeyData::operator==): Fix obvious bug.
LayoutTests:
- platform/mac-wk1/TestExpectations: Re-enable the flaky test.
- resources/js-test.js:
- storage/indexeddb/modern/idbkey-array-equality-expected.txt: Added.
- storage/indexeddb/modern/idbkey-array-equality-private-expected.txt: Added.
- storage/indexeddb/modern/idbkey-array-equality-private.html: Added.
- storage/indexeddb/modern/idbkey-array-equality.html: Added.
- storage/indexeddb/modern/resources/idbkey-array-equality.js: Added.
- 11:38 AM Changeset in webkit [196136] by
-
- 7 edits in trunk/Source/WebCore
Unreviewed, fix the EFL clean build after r196123
https://bugs.webkit.org/show_bug.cgi?id=153875
- CMakeLists.txt:
- PlatformGTK.cmake:
- PlatformMac.cmake:
- html/DOMSettableTokenList.h:
- html/DOMSettableTokenList.idl:
- 11:27 AM Changeset in webkit [196135] by
-
- 10 edits in trunk/Source/WebCore
PageGroup::captionPreferences should return a reference
https://bugs.webkit.org/show_bug.cgi?id=153877
<rdar://problem/24506917>
Reviewed by Jer Noble.
No new tests, no functional change.
- Modules/mediacontrols/MediaControlsHost.cpp:
(WebCore::MediaControlsHost::sortedTrackListForMenu):
(WebCore::MediaControlsHost::displayNameForTrack):
(WebCore::MediaControlsHost::captionMenuOffItem):
(WebCore::MediaControlsHost::captionDisplayMode):
- dom/Document.cpp:
(WebCore::Document::registerForCaptionPreferencesChangedCallbacks):
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::HTMLMediaElement):
(WebCore::HTMLMediaElement::addTextTrack):
(WebCore::HTMLMediaElement::configureTextTrackGroup):
(WebCore::HTMLMediaElement::setSelectedTextTrack):
(WebCore::HTMLMediaElement::configureTextTracks):
(WebCore::HTMLMediaElement::captionPreferencesChanged):
(WebCore::HTMLMediaElement::mediaPlayerPreferredAudioCharacteristics):
- html/shadow/MediaControlElements.cpp:
(WebCore::MediaControlClosedCaptionsTrackListElement::updateDisplay):
(WebCore::MediaControlClosedCaptionsTrackListElement::rebuildTrackListMenu):
(WebCore::MediaControlTextTrackContainerElement::updateActiveCuesFontSize):
- page/PageGroup.cpp:
(WebCore::PageGroup::captionPreferencesChanged):
(WebCore::PageGroup::captionPreferences):
- page/PageGroup.h:
- platform/cocoa/WebVideoFullscreenModelVideoElement.mm:
(WebVideoFullscreenModelVideoElement::updateLegibleOptions):
- testing/InternalSettings.cpp:
(WebCore::InternalSettings::setShouldDisplayTrackKind):
(WebCore::InternalSettings::shouldDisplayTrackKind):
- testing/Internals.cpp:
(WebCore::Internals::resetToConsistentState):
(WebCore::Internals::Internals):
(WebCore::Internals::userPreferredAudioCharacteristics):
(WebCore::Internals::setUserPreferredAudioCharacteristic):
(WebCore::Internals::captionsStyleSheetOverride):
(WebCore::Internals::setCaptionsStyleSheetOverride):
(WebCore::Internals::setPrimaryAudioTrackLanguageOverride):
(WebCore::Internals::setCaptionDisplayMode):
- 11:20 AM Changeset in webkit [196134] by
-
- 2 edits in trunk/Source/WebCore
Removed unused Settings::setPrivateBrowsingEnabled.
https://bugs.webkit.org/show_bug.cgi?id=153869
Patch by Konstantin Tokarev <Konstantin Tokarev> on 2016-02-04
Reviewed by Alexey Proskuryakov.
Implementation of Settings::setPrivateBrowsingEnabled was removed
in r166661, but declaration is still here.
No new tests needed.
- page/Settings.h:
(WebCore::Settings::setPrivateBrowsingEnabled): Deleted.
- 11:12 AM Changeset in webkit [196133] by
-
- 2 edits in trunk/LayoutTests
Skip two flaky indexeddb tests on Yosemite Release WK2
Unreviewed test gardening.
- platform/mac-wk2/TestExpectations:
- 10:29 AM Changeset in webkit [196132] by
-
- 1 edit in branches/safari-601-branch/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm
Guard use of MediaToolbox by ENABLE(AVF_CAPTIONS).
- 10:20 AM Changeset in webkit [196131] by
-
- 7 edits in trunk
Don't discard in-band cues with negative start times
https://bugs.webkit.org/show_bug.cgi?id=153867
<rdar://problem/19588632>
Reviewed by Jer Noble.
Source/WebCore:
No new tests, updated and un-skipped http/tests/media/track-in-band-hls-metadata.html.
- platform/graphics/avfoundation/InbandMetadataTextTrackPrivateAVF.cpp:
(WebCore::InbandMetadataTextTrackPrivateAVF::addDataCue): ASSERT if passed negative time value.
(WebCore::InbandMetadataTextTrackPrivateAVF::updatePendingCueEndTimes): Ditto. Correct logging.
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::processCue): ASSERT if passed negative time value.
(WebCore::MediaPlayerPrivateAVFoundationObjC::metadataDidArrive): Convert negative cue times to zero.
(-[WebCoreAVFMovieObserver legibleOutput:didOutputAttributedStrings:nativeSampleBuffers:forItemTime:]):
Ditto.
LayoutTests:
- http/tests/media/track-in-band-hls-metadata-expected.txt:
- http/tests/media/track-in-band-hls-metadata.html: Test more attributes for correctness, fail test immediately if cue.value is undefined so the test doesn't generate an exception and exit without any results.
- platform/mac/TestExpectations: Unskip test.
- 10:03 AM Changeset in webkit [196130] by
-
- 7 edits2 adds in trunk
Specify an exception for createChannelMerger, createChannelSplitter and createPeriodicWave
https://bugs.webkit.org/show_bug.cgi?id=150925
Patch by Hyemi Shin <hyemi.sin@samsung.com> on 2016-02-04
Reviewed by Darin Adler.
createChannelMerger and createChannelSplitter should throw INDEX_SIZE_ERR
for invalid numberOfInputs value.
createPeriodicWave should throw INDEX_SIZE_ERR for invalid lengths of parameters.
Source/WebCore:
Tests: webaudio/audiochannelmerger-basic.html
webaudio/audiochannelsplitter.html
webaudio/periodicwave-lengths.html
- Modules/webaudio/AudioContext.cpp:
(WebCore::AudioContext::createChannelSplitter):
(WebCore::AudioContext::createChannelMerger):
(WebCore::AudioContext::createPeriodicWave):
LayoutTests:
- webaudio/audiochannelmerger-basic-expected.txt: numberOfInputs could be 32.
- webaudio/audiochannelmerger-basic.html: Ditto.
- webaudio/audiochannelsplitter-expected.txt: Ditto.
- webaudio/audiochannelsplitter.html: Ditto.
- webaudio/periodicwave-lengths-expected.txt: Added.
- webaudio/periodicwave-lengths.html: Added.
- 9:45 AM Changeset in webkit [196129] by
-
- 1 edit in branches/safari-601-branch/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm
Use feature-based guards instead of OS-based guards, and wrap them around both MediaToolbox SOFT_LINK macros.
- 9:43 AM Changeset in webkit [196128] by
-
- 15 edits1 copy1 add in trunk
[Fetch API] Add support for iterating over Headers
https://bugs.webkit.org/show_bug.cgi?id=153787
Reviewed by Darin Adler.
LayoutTests/imported/w3c:
Relanding.
- web-platform-tests/fetch/api/headers/headers-basic-expected.txt:
- web-platform-tests/fetch/api/headers/headers-basic.html:
- web-platform-tests/fetch/api/headers/headers-structure-expected.txt:
- web-platform-tests/fetch/api/request/request-clone.sub-expected.txt:
- web-platform-tests/fetch/api/request/request-init-003.sub-expected.txt:
- web-platform-tests/fetch/api/resources/utils.js:
(checkRequest):
(readTextStream):
Source/WebCore:
Relanding, updating bindings/js/JSKeyValueIterator.h for Windows bots.
Covered by updated tests.
Introducing template class (JSKeyValueIterator) to support key-value iterators in DOM classes.
Using JSKeyValueIterator to implement Headers entries(), keys() and values() as custom methods.
Binding generator should be updated to generate directly these custom methods and handle iterator Symbol.
- CMakeLists.txt:
- Modules/fetch/FetchHeaders.cpp:
(WebCore::FetchHeaders::Iterator::next):
(WebCore::FetchHeaders::Iterator::Iterator):
- Modules/fetch/FetchHeaders.h:
(WebCore::FetchHeaders::createIterator):
- Modules/fetch/FetchHeaders.idl:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSBindingsAllInOne.cpp:
- bindings/js/JSDOMBinding.h:
(WebCore::jsPair):
- bindings/js/JSFetchHeadersCustom.cpp: Added.
(WebCore::JSFetchHeaders::entries):
(WebCore::JSFetchHeaders::keys):
(WebCore::JSFetchHeaders::values):
- bindings/js/JSKeyValueIterator.h: Added.
(WebCore::JSKeyValueIteratorPrototype::create):
(WebCore::JSKeyValueIteratorPrototype::createStructure):
(WebCore::JSKeyValueIteratorPrototype::JSKeyValueIteratorPrototype):
(WebCore::createIterator):
(WebCore::DOMWrapped>::destroy):
(WebCore::DOMWrapped>::next):
(WebCore::DOMWrapped>::finishCreation):
- 9:39 AM Changeset in webkit [196127] by
-
- 1 edit in branches/safari-601-branch/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm
Build fix.
- 9:34 AM Changeset in webkit [196126] by
-
- 2 edits2 adds in trunk/LayoutTests
Rebaseline imported/w3c/web-platform-tests/html/semantics/forms/the-select-element/select-ask-for-reset.html for ios-simulator
https://bugs.webkit.org/show_bug.cgi?id=153850
Unreviewed test gardening.
- platform/ios-simulator/TestExpectations:
- platform/ios-simulator/imported/w3c/web-platform-tests/html/semantics/forms/the-select-element/select-ask-for-reset-expected.txt: Added.
- 9:27 AM Changeset in webkit [196125] by
-
- 1 edit in branches/safari-601-branch/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm
Speculative Mavericks Build Fix. rdar://problem/24417428
- 9:12 AM Changeset in webkit [196124] by
-
- 2 edits in trunk/Source/WebKit2
Unreviewed, rolling out r196067.
Re-enable speculative revalidation now that we have measured
the impact on the perf bots
Reverted changeset:
"Unreviewed, rolling out r195555."
https://bugs.webkit.org/show_bug.cgi?id=153443
http://trac.webkit.org/changeset/196067
- 8:57 AM Changeset in webkit [196123] by
-
- 43 edits1 delete in trunk
Merge DOMTokenList and DOMSettableTokenList
https://bugs.webkit.org/show_bug.cgi?id=153677
<rdar://problem/24419675>
Reviewed by Sam Weinig.
LayoutTests/imported/w3c:
Rebaseline several W3C tests now that more checks are passing.
- web-platform-tests/dom/historical-expected.txt:
- web-platform-tests/dom/interfaces-expected.txt:
- web-platform-tests/dom/nodes/Element-classlist-expected.txt:
- web-platform-tests/html/dom/interfaces-expected.txt:
- web-platform-tests/html/dom/interfaces.html:
Update HTMLAreaElement.relList to match the specification.
Source/WebCore:
Merge DOMTokenList and DOMSettableTokenList, as per a recent
specification change:
No new tests, already covered by existing tests.
- CMakeLists.txt:
- DerivedSources.cpp:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
- dom/Element.idl:
- dom/Node.h:
- dom/NodeRareData.h:
- html/AttributeDOMTokenList.h:
- html/DOMSettableTokenList.cpp: Removed.
- html/DOMSettableTokenList.h:
- html/DOMSettableTokenList.idl:
- html/DOMTokenList.cpp:
(WebCore::DOMTokenList::setValue):
- html/DOMTokenList.h:
- html/DOMTokenList.idl:
- html/HTMLAnchorElement.idl:
- html/HTMLAreaElement.idl:
- html/HTMLElement.cpp:
- html/HTMLElement.idl:
- html/HTMLIFrameElement.cpp:
(WebCore::HTMLIFrameElement::sandbox):
- html/HTMLIFrameElement.h:
- html/HTMLIFrameElement.idl:
- html/HTMLLinkElement.cpp:
(WebCore::HTMLLinkElement::sizes):
- html/HTMLLinkElement.h:
- html/HTMLLinkElement.idl:
- html/HTMLOutputElement.cpp:
(WebCore::HTMLOutputElement::htmlFor):
- html/HTMLOutputElement.h:
- html/HTMLOutputElement.idl:
- html/HTMLTableCellElement.idl:
- page/DOMWindow.cpp:
- page/DOMWindow.idl:
LayoutTests:
Update / rebaseline several tests now that relList attributes
use [PutForward=value].
- fast/dom/HTMLElement/class-list-expected.txt:
- fast/dom/HTMLElement/class-list-quirks-expected.txt:
- fast/dom/HTMLElement/script-tests/class-list.js:
- fast/dom/rel-list-expected.txt:
- fast/dom/rel-list.html:
- 8:22 AM Changeset in webkit [196122] by
-
- 3 edits2 adds in branches/safari-601.1.46-branch
Merge r195837. rdar://problem/24001782
- 8:22 AM Changeset in webkit [196121] by
-
- 14 edits2 adds in branches/safari-601.1.46-branch
Merge r196010. rdar://problem/24416768
- 8:22 AM Changeset in webkit [196120] by
-
- 4 edits4 adds in branches/safari-601.1.46-branch
Merge r195912. rdar://problem/24416768
- 8:22 AM Changeset in webkit [196119] by
-
- 4 edits2 adds in branches/safari-601.1.46-branch
Merge r192570. rdar://problem/24416768
- 4:46 AM Changeset in webkit [196118] by
-
- 14 edits2 deletes in trunk
Unreviewed. Reverting r196115 and r19116, related tohttps://bugs.webkit.org/show_bug.cgi?id=153787.
- 3:39 AM Changeset in webkit [196117] by
-
- 5 edits2 adds in trunk/Source/WebCore
[GTK] Implement mediastream mediaplayer
https://bugs.webkit.org/show_bug.cgi?id=153541
Reviewed by Martin Robinson.
Added the implementation of the mediaplayer for the
mediastream. The code was implemented by Philippe Normand and
Alessandro Decina.
- PlatformGTK.cmake: Added the file to the compilation.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::setSrcObject): Set the src of the
media element to the mediastream.
- platform/graphics/MediaPlayer.cpp:
(WebCore::buildMediaEnginesVector): Register the mediastream
mediaplayer as an option in the media engines vector.
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamerOwr.cpp: Added.
(WebCore::MediaPlayerPrivateGStreamerOwr::MediaPlayerPrivateGStreamerOwr):
(WebCore::MediaPlayerPrivateGStreamerOwr::~MediaPlayerPrivateGStreamerOwr):
(WebCore::MediaPlayerPrivateGStreamerOwr::play):
(WebCore::MediaPlayerPrivateGStreamerOwr::pause):
(WebCore::MediaPlayerPrivateGStreamerOwr::hasVideo):
(WebCore::MediaPlayerPrivateGStreamerOwr::hasAudio):
(WebCore::MediaPlayerPrivateGStreamerOwr::currentTime):
(WebCore::MediaPlayerPrivateGStreamerOwr::load):
(WebCore::MediaPlayerPrivateGStreamerOwr::loadingFailed):
(WebCore::MediaPlayerPrivateGStreamerOwr::didLoadingProgress):
(WebCore::MediaPlayerPrivateGStreamerOwr::internalLoad):
(WebCore::MediaPlayerPrivateGStreamerOwr::stop):
(WebCore::MediaPlayerPrivateGStreamerOwr::registerMediaEngine):
(WebCore::MediaPlayerPrivateGStreamerOwr::getSupportedTypes):
(WebCore::MediaPlayerPrivateGStreamerOwr::supportsType):
(WebCore::MediaPlayerPrivateGStreamerOwr::isAvailable):
(WebCore::MediaPlayerPrivateGStreamerOwr::createGSTAudioSinkBin):
(WebCore::MediaPlayerPrivateGStreamerOwr::sourceStopped):
(WebCore::MediaPlayerPrivateGStreamerOwr::sourceMutedChanged):
(WebCore::MediaPlayerPrivateGStreamerOwr::sourceSettingsChanged):
(WebCore::MediaPlayerPrivateGStreamerOwr::preventSourceFromStopping):
(WebCore::MediaPlayerPrivateGStreamerOwr::createVideoSink):
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamerOwr.h: Added.
(WebCore::MediaPlayerPrivateGStreamerOwr::engineDescription):
(WebCore::MediaPlayerPrivateGStreamerOwr::load):
(WebCore::MediaPlayerPrivateGStreamerOwr::cancelLoad):
(WebCore::MediaPlayerPrivateGStreamerOwr::prepareToPlay):
(WebCore::MediaPlayerPrivateGStreamerOwr::duration):
(WebCore::MediaPlayerPrivateGStreamerOwr::seek):
(WebCore::MediaPlayerPrivateGStreamerOwr::seeking):
(WebCore::MediaPlayerPrivateGStreamerOwr::setRate):
(WebCore::MediaPlayerPrivateGStreamerOwr::setPreservesPitch):
(WebCore::MediaPlayerPrivateGStreamerOwr::paused):
(WebCore::MediaPlayerPrivateGStreamerOwr::hasClosedCaptions):
(WebCore::MediaPlayerPrivateGStreamerOwr::setClosedCaptionsVisible):
(WebCore::MediaPlayerPrivateGStreamerOwr::maxTimeSeekable):
(WebCore::MediaPlayerPrivateGStreamerOwr::buffered):
(WebCore::MediaPlayerPrivateGStreamerOwr::totalBytes):
(WebCore::MediaPlayerPrivateGStreamerOwr::bytesLoaded):
(WebCore::MediaPlayerPrivateGStreamerOwr::canLoadPoster):
(WebCore::MediaPlayerPrivateGStreamerOwr::setPoster):
(WebCore::MediaPlayerPrivateGStreamerOwr::isLiveStream):
(WebCore::MediaPlayerPrivateGStreamerOwr::audioSink):
- 3:14 AM Changeset in webkit [196116] by
-
- 3 edits in trunk/Source/WebCore/bindings/js
Unreviewed. Speculative Win Build fix
- 2:39 AM Changeset in webkit [196115] by
-
- 15 edits1 copy1 add in trunk
[Fetch API] Add support for iterating over Headers
https://bugs.webkit.org/show_bug.cgi?id=153787
Reviewed by Darin Adler.
LayoutTests/imported/w3c:
- web-platform-tests/fetch/api/headers/headers-basic-expected.txt:
- web-platform-tests/fetch/api/headers/headers-basic.html:
- web-platform-tests/fetch/api/headers/headers-structure-expected.txt:
- web-platform-tests/fetch/api/request/request-clone.sub-expected.txt:
- web-platform-tests/fetch/api/request/request-init-003.sub-expected.txt:
- web-platform-tests/fetch/api/resources/utils.js: fixed typo in test.
Source/WebCore:
Covered by updated tests.
Introducing template class (JSKeyValueIterator) to support key-value iterators in DOM classes.
Using JSKeyValueIterator to implement Headers entries(), keys() and values() as custom methods.
Binding generator should be updated to generate directly these custom methods and handle iterator Symbol.
- CMakeLists.txt:
- Modules/fetch/FetchHeaders.cpp:
(WebCore::FetchHeaders::Iterator::next):
(WebCore::FetchHeaders::Iterator::Iterator):
- Modules/fetch/FetchHeaders.h:
(WebCore::FetchHeaders::createIterator):
- Modules/fetch/FetchHeaders.idl:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSDOMBinding.h:
(WebCore::jsPair):
- bindings/js/JSBindingsAllInOne.cpp:
- bindings/js/JSFetchHeadersCustom.cpp: Added.
(WebCore::JSFetchHeaders::entries):
(WebCore::JSFetchHeaders::keys):
(WebCore::JSFetchHeaders::values):
- bindings/js/JSKeyValueIterator.h: Added.
(WebCore::JSKeyValueIteratorPrototype::create):
(WebCore::JSKeyValueIteratorPrototype::createStructure):
(WebCore::JSKeyValueIteratorPrototype::JSKeyValueIteratorPrototype):
(WebCore::JSKeyValueIteratorPrototypeFuncNext):
- 2:10 AM Changeset in webkit [196114] by
-
- 15 edits in trunk/LayoutTests
Unreviewed. EFL gardening after r195740.
- platform/efl/accessibility/table-attributes-expected.txt:
- platform/efl/accessibility/table-cell-spans-expected.txt:
- platform/efl/accessibility/table-cells-expected.txt:
- platform/efl/accessibility/table-sections-expected.txt:
- platform/efl/accessibility/table-with-rules-expected.txt:
- platform/efl/css2.1/20110323/table-height-algorithm-023-expected.txt:
- platform/efl/css2.1/20110323/table-height-algorithm-024-expected.txt:
- platform/efl/css3/selectors3/xml/css3-modsel-43b-expected.txt:
- platform/efl/editing/deleting/5099303-expected.txt:
- platform/efl/editing/deleting/5144139-2-expected.txt:
- platform/efl/editing/deleting/5483370-expected.txt:
- platform/efl/editing/deleting/delete-to-select-table-expected.txt:
- platform/efl/editing/deleting/table-cells-expected.txt:
- platform/efl/fast/text/atsui-multiple-renderers-expected.txt:
- 2:05 AM Changeset in webkit [196113] by
-
- 3 edits in trunk
Unreviewed non X86_64 buildfix after r196077.
- Source/cmake/OptionsEfl.cmake:
- Source/cmake/OptionsGTK.cmake:
- 12:25 AM Changeset in webkit [196112] by
-
- 3 edits2 adds in trunk
Do not show context menu when right clicking on a scrollbar
https://bugs.webkit.org/show_bug.cgi?id=153493
Reviewed by Michael Catanzaro.
Source/WebCore:
Scrollbars don't currently handle right clicks, but we are showing
the context menu when they are right clicked. This is not desired
at least in GTK+ and I've checked that it isn't consistent with
other applications in Mac either.
Test: fast/events/contextmenu-on-scrollbars.html
- page/EventHandler.cpp:
(WebCore::EventHandler::sendContextMenuEvent):
LayoutTests:
Add a test to check that context menu event is not sent when right
clicking on a scrollbar.
- fast/events/contextmenu-on-scrollbars-expected.txt: Added.
- fast/events/contextmenu-on-scrollbars.html: Added.
Feb 3, 2016:
- 11:37 PM Changeset in webkit [196111] by
-
- 1 edit in trunk/Tools/ChangeLog
Fix a typo in Tools/ChangeLog
- 11:34 PM Changeset in webkit [196110] by
-
- 2 edits in trunk/Tools
[WTR] Crash in EventSendingController::contextClick() when context menu event is not handled
https://bugs.webkit.org/show_bug.cgi?id=153835
Reviewed by Martin Robinson.
WKBundlePageCopyContextMenuAtPointInWindow() returns nullptr when
the context menu event is not hanlded, but we are using the
returned value without null checking it.
- WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
(WTR::EventSendingController::contextClick):
- 10:07 PM Changeset in webkit [196109] by
-
- 3 edits in trunk/Tools
Format revisions for display according to repository type https://bugs.webkit.org/show_bug.cgi?id=153818
Reviewed by Alexey Proskuryakov.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
(BuildbotQueueView.prototype._popoverLinesForCommitRange): Use new _formatRevisionForDisplay to display revisions according
to repository type.
(BuildbotQueueView.prototype._revisionContentWithPopoverForIteration): Ditto.
(BuildbotQueueView.prototype._formatRevisionForDisplay): Formats revisions for display according to repository type.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js: Added unit tests to test new
_formatRevisionForDisplay function.
- 9:41 PM Changeset in webkit [196108] by
-
- 7 edits in trunk/Source/JavaScriptCore
[JSC] Make some classes non JSDestructibleObject
https://bugs.webkit.org/show_bug.cgi?id=153838
Reviewed by Geoffrey Garen.
SymbolPrototype, JSMapIterator and JSSetIterator are trivially destructible.
So there is no need to inherit JSDestructibleObject.
- runtime/JSMapIterator.cpp:
(JSC::JSMapIterator::destroy): Deleted.
- runtime/JSMapIterator.h:
- runtime/JSSetIterator.cpp:
(JSC::JSSetIterator::destroy): Deleted.
- runtime/JSSetIterator.h:
- runtime/MapData.h:
- runtime/SymbolPrototype.h:
- 9:38 PM Changeset in webkit [196107] by
-
- 2 edits1 add in trunk/Source/JavaScriptCore
[JSC] Symbol structure has unnecessary flags
https://bugs.webkit.org/show_bug.cgi?id=153840
Reviewed by Saam Barati.
- runtime/Symbol.h:
- tests/stress/symbol-get-own-property.js: Added.
(shouldBe):
- 9:16 PM Changeset in webkit [196106] by
-
- 2 edits in trunk/Tools
Logs/CoreSimulator filling up OS disk on WebKit testers
https://bugs.webkit.org/show_bug.cgi?id=153853
<rdar://problem/24496003>
Reviewed by Alexey Proskuryakov.
- Scripts/webkitpy/port/ios.py:
(IOSSimulatorPort.clean_up_test_run): Delete Logs during cleanup.
- 7:36 PM Changeset in webkit [196105] by
-
- 1 edit2 adds in trunk/LayoutTests
Accepted candidates should not be autocorrected
https://bugs.webkit.org/show_bug.cgi?id=153813
-and corresponding-
rdar://problem/24066924
Reviewed by Darin Adler.
- editing/mac/spelling/accept-misspelled-candidate-expected.txt: Added.
- editing/mac/spelling/accept-misspelled-candidate.html: Added.
- 7:12 PM Changeset in webkit [196104] by
-
- 7 edits in trunk/Source
[iOS] Throw away linked code when navigating to a new page.
<https://webkit.org/b/153851>
Reviewed by Gavin Barraclough.
Source/JavaScriptCore:
Add a VM API for throwing away linked code only.
- runtime/VM.cpp:
(JSC::VM::deleteAllLinkedCode):
- runtime/VM.h:
Source/WebCore:
When navigating to a new page, tell JSC to throw out any linked code it has lying around.
Linked code is tied to a specific global object, and as we're creating a new one for the
new page, none of it is useful to us here.
In the event that the user navigates back, the cost of relinking some code will be far
lower than the memory cost of keeping all of it around.
- bindings/js/GCController.cpp:
(WebCore::GCController::deleteAllLinkedCode):
- bindings/js/GCController.h:
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::commitProvisionalLoad):
- 5:48 PM Changeset in webkit [196103] by
-
- 2 edits in trunk/LayoutTests
Marking http/tests/history/back-to-post.php as flaky on ios-simulator
https://bugs.webkit.org/show_bug.cgi?id=153314
Unreviewed test gardening.
- platform/ios-simulator/TestExpectations:
- 5:41 PM Changeset in webkit [196102] by
-
- 2 edits in trunk/LayoutTests
Skip imported/w3c/web-platform-tests/html/semantics/forms/the-select-element/select-ask-for-reset.html on ios-simulator
https://bugs.webkit.org/show_bug.cgi?id=153850
Unreviewed test gardening.
- platform/ios-simulator/TestExpectations:
- 5:39 PM Changeset in webkit [196101] by
-
- 7 edits in trunk/Source
Report wasBlocked and cannotShowURL errors when using NetworkSession
https://bugs.webkit.org/show_bug.cgi?id=153846
Reviewed by Antti Koivisto.
Source/WebCore:
No new tests, but this fixes http/tests/xmlhttprequest/redirect-cross-origin-2.html
when using NetworkSession.
- platform/URL.h:
WEBCORE_EXPORT because we are using portAllowed in WebKit2 now.
Source/WebKit2:
- NetworkProcess/NetworkLoad.cpp:
(WebKit::NetworkLoad::NetworkLoad):
(WebKit::NetworkLoad::didSendData):
(WebKit::NetworkLoad::wasBlocked):
(WebKit::NetworkLoad::cannotShowURL):
(WebKit::NetworkLoad::didReceiveResponseAsync):
- NetworkProcess/NetworkLoad.h:
NetworkDataTask is now RefCounted so we can protect it when reporting errors which delete the NetworkLoad.
- NetworkProcess/NetworkSession.h:
(WebKit::NetworkSessionTaskClient::~NetworkSessionTaskClient):
(WebKit::NetworkDataTask::create):
- NetworkProcess/cocoa/NetworkSessionCocoa.mm:
(WebKit::NetworkSession::takeDownloadID):
(WebKit::NetworkDataTask::NetworkDataTask):
Check the validity of the requested url and check if the port is allowed like we do in the ResourceHandle constructor.
(WebKit::NetworkDataTask::~NetworkDataTask):
Don't remove the task from the NetworkSession's map if we didn't make it because there was an error.
(WebKit::NetworkDataTask::scheduleFailure):
(WebKit::NetworkDataTask::failureTimerFired):
Implemented like ResourceHandle's.
(WebKit::NetworkDataTask::tryPasswordBasedAuthentication):
(WebKit::NetworkDataTask::resume):
(WebKit::NetworkDataTask::suspend):
Handle the failure timer like we do in ResourceHandle::setDefersLoading.
- 5:33 PM Changeset in webkit [196100] by
-
- 2 edits in trunk/LayoutTests
Marking displaylists tests as flaky on ios-simulator. Previous attempt was unsuccessful.
https://bugs.webkit.org/show_bug.cgi?id=153656
Unreviewed test gardening.
- platform/ios-simulator/TestExpectations:
- 4:57 PM Changeset in webkit [196099] by
-
- 2 edits in trunk/LayoutTests
Marking transitions/clip-path-transitions.html and transitions/clip-path-path-transitions.html as flaky on Mac
https://bugs.webkit.org/show_bug.cgi?id=153809
Unreviewed test gardening.
- platform/mac/TestExpectations:
- 4:56 PM Changeset in webkit [196098] by
-
- 5 edits2 adds in trunk
Web Inspector: JS PrettyPrinting unary - and + issues
https://bugs.webkit.org/show_bug.cgi?id=134007
<rdar://problem/17351953>
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-02-03
Reviewed by Timothy Hatcher.
Source/WebInspectorUI:
- UserInterface/Views/CodeMirrorFormatters.js:
(shouldHaveSpaceBeforeToken):
(shouldHaveSpaceAfterLastToken):
(removeLastNewline):
(modifyStateForTokenPre):
(modifyStateForTokenPost):
LayoutTests:
- inspector/codemirror/prettyprinting-javascript-expected.txt:
- inspector/codemirror/prettyprinting-javascript.html:
- inspector/codemirror/resources/prettyprinting/javascript-tests/unary-binary-operators-expected.js: Added.
- inspector/codemirror/resources/prettyprinting/javascript-tests/unary-binary-operators.js: Added.
New tests for unary and some binary operators in JavaScript pretty printing.
- 4:35 PM Changeset in webkit [196097] by
-
- 3 edits in trunk/Tools
git-add-reviewer should work when run from a subdirectory within the repository
https://bugs.webkit.org/show_bug.cgi?id=153842
Reviewed by David Kilzer.
There are two problems that needed to be fixed:
- We can't assume .git is in $PWD/.git
- We can't specify absolute paths to
git commit
Fix these problems using the helpers in VCSUtils that were added to
fix this same issue for prepare-changeCogs.
- Scripts/VCSUtils.pm: Export gitDirectory()
- Scripts/git-add-reviewer:
(nonInteractive): Cache gitDirectory() result.
(addReviewer):
(commit):
(changeLogsForCommit): Make paths relative.
- 4:27 PM Changeset in webkit [196096] by
-
- 14 edits2 adds in branches/safari-601-branch
Merge r196010. rdar://problem/24417428
- 4:26 PM Changeset in webkit [196095] by
-
- 4 edits4 adds in branches/safari-601-branch
Merge r195912. rdar://problem/24417428
- 4:26 PM Changeset in webkit [196094] by
-
- 4 edits2 adds in branches/safari-601-branch
Merge r192570. rdar://problem/24417428
- 4:16 PM Changeset in webkit [196093] by
-
- 2 edits in trunk/Tools
Yet another Yosemite build fix.
- TestWebKitAPI/Tests/WebCore/WebCoreNSURLSession.mm:
- 4:05 PM Changeset in webkit [196092] by
-
- 5 edits in trunk
iOS build fix after Yosemite build fix broke iOS build.
Source/WebCore:
- platform/network/cocoa/WebCoreNSURLSession.h:
- platform/network/cocoa/WebCoreNSURLSession.mm:
Tools:
- TestWebKitAPI/Tests/WebCore/WebCoreNSURLSession.mm:
- 4:04 PM Changeset in webkit [196091] by
-
- 25 edits5 copies56 adds in trunk/LayoutTests
Re-sync W3C HTML web-platform-tests
https://bugs.webkit.org/show_bug.cgi?id=153832
Reviewed by Sam Weinig.
Re-sync W3C HTML web-platform-tests from:
https://github.com/w3c/web-platform-tests/tree/master/html
- web-platform-tests/html/dom/dynamic-markup-insertion/document-writeln/document.writeln-03-expected.txt: Added.
- web-platform-tests/html/dom/dynamic-markup-insertion/document-writeln/document.writeln-03.html: Added.
- web-platform-tests/html/dom/dynamic-markup-insertion/document-writeln/w3c-import.log:
- web-platform-tests/html/dom/elements-obsolete.js:
- web-platform-tests/html/dom/interfaces-expected.txt:
- web-platform-tests/html/dom/interfaces.html:
- web-platform-tests/html/semantics/document-metadata/styling/LinkStyle-expected.txt: Added.
- web-platform-tests/html/semantics/document-metadata/styling/LinkStyle.html: Added.
- web-platform-tests/html/semantics/document-metadata/styling/w3c-import.log: Copied from LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/form-submission-0/w3c-import.log.
- web-platform-tests/html/semantics/embedded-content/media-elements/offsets-into-the-media-resource/w3c-import.log:
- web-platform-tests/html/semantics/embedded-content/media-elements/playing-the-media-resource/w3c-import.log:
- web-platform-tests/html/semantics/embedded-content/media-elements/track/track-element/w3c-import.log:
- web-platform-tests/html/semantics/embedded-content/media-elements/w3c-import.log:
- web-platform-tests/html/semantics/embedded-content/the-area-element/area-coords-expected.txt: Added.
- web-platform-tests/html/semantics/embedded-content/the-area-element/area-coords.html: Added.
- web-platform-tests/html/semantics/embedded-content/the-area-element/area-processing-expected.txt: Added.
- web-platform-tests/html/semantics/embedded-content/the-area-element/area-processing.html: Added.
- web-platform-tests/html/semantics/embedded-content/the-area-element/area-shape-expected.txt: Added.
- web-platform-tests/html/semantics/embedded-content/the-area-element/area-shape.html: Added.
- web-platform-tests/html/semantics/embedded-content/the-area-element/support/hit-test.js: Added.
(onload):
- web-platform-tests/html/semantics/embedded-content/the-area-element/support/w3c-import.log: Copied from LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-area-element/w3c-import.log.
- web-platform-tests/html/semantics/embedded-content/the-area-element/w3c-import.log:
- web-platform-tests/html/semantics/embedded-content/the-canvas-element/toDataURL.nocontext.html:
- web-platform-tests/html/semantics/embedded-content/the-embed-element/w3c-import.log:
- web-platform-tests/html/semantics/embedded-content/the-iframe-element/iframe_javascript_url_01-expected.txt: Added.
- web-platform-tests/html/semantics/embedded-content/the-iframe-element/iframe_javascript_url_01.htm: Added.
- web-platform-tests/html/semantics/embedded-content/the-iframe-element/iframe_sandbox_allow_script-expected.txt: Added.
- web-platform-tests/html/semantics/embedded-content/the-iframe-element/iframe_sandbox_allow_script.html: Added.
- web-platform-tests/html/semantics/embedded-content/the-iframe-element/move_iframe_in_dom_01-expected.txt: Added.
- web-platform-tests/html/semantics/embedded-content/the-iframe-element/move_iframe_in_dom_01.html: Added.
- web-platform-tests/html/semantics/embedded-content/the-iframe-element/move_iframe_in_dom_02-expected.txt: Added.
- web-platform-tests/html/semantics/embedded-content/the-iframe-element/move_iframe_in_dom_02.html: Added.
- web-platform-tests/html/semantics/embedded-content/the-iframe-element/move_iframe_in_dom_03-expected.txt: Added.
- web-platform-tests/html/semantics/embedded-content/the-iframe-element/move_iframe_in_dom_03.html: Added.
- web-platform-tests/html/semantics/embedded-content/the-iframe-element/move_iframe_in_dom_04-expected.txt: Added.
- web-platform-tests/html/semantics/embedded-content/the-iframe-element/move_iframe_in_dom_04.html: Added.
- web-platform-tests/html/semantics/embedded-content/the-iframe-element/support/blank.htm: Added.
- web-platform-tests/html/semantics/embedded-content/the-iframe-element/support/sandbox_allow_script.html: Added.
- web-platform-tests/html/semantics/embedded-content/the-iframe-element/support/w3c-import.log: Copied from LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/track/track-element/w3c-import.log.
- web-platform-tests/html/semantics/embedded-content/the-iframe-element/w3c-import.log: Copied from LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-object-element/w3c-import.log.
- web-platform-tests/html/semantics/embedded-content/the-img-element/w3c-import.log:
- web-platform-tests/html/semantics/embedded-content/the-object-element/w3c-import.log:
- web-platform-tests/html/semantics/forms/form-submission-0/url-encoded-expected.txt: Added.
- web-platform-tests/html/semantics/forms/form-submission-0/url-encoded.html: Added.
- web-platform-tests/html/semantics/forms/form-submission-0/w3c-import.log:
- web-platform-tests/html/semantics/forms/textfieldselection/w3c-import.log:
- web-platform-tests/html/semantics/forms/the-button-element/button-activate-expected.txt: Added.
- web-platform-tests/html/semantics/forms/the-button-element/button-activate-frame.html: Added.
- web-platform-tests/html/semantics/forms/the-button-element/button-activate.html: Added.
- web-platform-tests/html/semantics/forms/the-button-element/button-events-expected.txt:
- web-platform-tests/html/semantics/forms/the-button-element/button-events.html:
- web-platform-tests/html/semantics/forms/the-button-element/w3c-import.log:
- web-platform-tests/html/semantics/forms/the-form-element/form-elements-sameobject-expected.txt: Added.
- web-platform-tests/html/semantics/forms/the-form-element/form-elements-sameobject.html: Added.
- web-platform-tests/html/semantics/forms/the-form-element/w3c-import.log:
- web-platform-tests/html/semantics/forms/the-input-element/checkbox-expected.txt:
- web-platform-tests/html/semantics/forms/the-input-element/checkbox.html:
- web-platform-tests/html/semantics/forms/the-input-element/maxlength-expected.txt: Added.
- web-platform-tests/html/semantics/forms/the-input-element/maxlength.html: Added.
- web-platform-tests/html/semantics/forms/the-input-element/radio-expected.txt:
- web-platform-tests/html/semantics/forms/the-input-element/radio.html:
- web-platform-tests/html/semantics/forms/the-input-element/w3c-import.log:
- web-platform-tests/html/semantics/forms/the-option-element/option-selected-expected.txt: Added.
- web-platform-tests/html/semantics/forms/the-option-element/option-selected.html: Added.
- web-platform-tests/html/semantics/forms/the-option-element/w3c-import.log:
- web-platform-tests/html/semantics/forms/the-select-element/select-ask-for-reset-expected.txt: Added.
- web-platform-tests/html/semantics/forms/the-select-element/select-ask-for-reset.html: Added.
- web-platform-tests/html/semantics/forms/the-select-element/w3c-import.log:
- web-platform-tests/html/semantics/interactive-elements/the-details-element/w3c-import.log:
- web-platform-tests/html/semantics/scripting-1/the-script-element/script-text-expected.txt:
- web-platform-tests/html/semantics/scripting-1/the-script-element/script-text.html:
- web-platform-tests/html/semantics/scripting-1/the-script-element/w3c-import.log:
- web-platform-tests/html/semantics/tabular-data/the-tbody-element/rows-expected.txt: Added.
- web-platform-tests/html/semantics/tabular-data/the-tbody-element/rows.html: Added.
- web-platform-tests/html/semantics/tabular-data/the-tbody-element/w3c-import.log:
- web-platform-tests/html/semantics/tabular-data/the-tfoot-element/rows-expected.txt: Added.
- web-platform-tests/html/semantics/tabular-data/the-tfoot-element/rows.html: Added.
- web-platform-tests/html/semantics/tabular-data/the-tfoot-element/w3c-import.log: Copied from LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/form-submission-0/w3c-import.log.
- web-platform-tests/html/semantics/tabular-data/the-thead-element/rows-expected.txt: Added.
- web-platform-tests/html/semantics/tabular-data/the-thead-element/rows.html: Added.
- web-platform-tests/html/semantics/tabular-data/the-thead-element/w3c-import.log: Copied from LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/form-submission-0/w3c-import.log.
- web-platform-tests/html/semantics/tabular-data/the-tr-element/cells-expected.txt: Added.
- web-platform-tests/html/semantics/tabular-data/the-tr-element/cells.html: Added.
- web-platform-tests/html/semantics/tabular-data/the-tr-element/w3c-import.log:
- 4:01 PM Changeset in webkit [196090] by
-
- 9 edits in trunk/Source/WebCore
Accepted candidates should not be autocorrected
https://bugs.webkit.org/show_bug.cgi?id=153813
-and corresponding-
rdar://problem/24066924
Reviewed by Darin Adler.
New document marker to mark inserted candidates. This was we can treat
inserted candidates just like a RejectedCorrection and we won’t accidentally
autocorrect them later on.
- dom/DocumentMarker.h:
(WebCore::DocumentMarker::AllMarkers::AllMarkers):
- editing/AlternativeTextController.cpp:
(WebCore::AlternativeTextController::processMarkersOnTextToBeReplacedByResult):
When handling an acceptant candidate, set m_isHandlingAcceptedCandidate to
true while the text is being inserted, and then mark the range as an accepted
candidate.
- editing/Editor.cpp:
(WebCore::Editor::handleAcceptedCandidate):
- editing/Editor.h:
(WebCore::Editor::isHandlingAcceptedCandidate):
If frame.editor. isHandlingAcceptedCandidate() then return early from
markMisspellingsAfterTyping.
- editing/TypingCommand.cpp:
(WebCore::TypingCommand::markMisspellingsAfterTyping):
Add some test infrastructure.
- testing/Internals.cpp:
(WebCore::Internals::handleAcceptedCandidate):
- testing/Internals.h:
- testing/Internals.idl:
- 4:00 PM Changeset in webkit [196089] by
-
- 2 edits in trunk/Source/WebCore
[Win] Pass entire request (rather than just URL) to clients of WebCoreAVCFResourceLoader
https://bugs.webkit.org/show_bug.cgi?id=153653
Reviewed by Brent Fulgham.
This will allow those clients to see the byte-range request ("Range:") header and respond
appropriately.
- platform/graphics/avfoundation/cf/WebCoreAVCFResourceLoader.cpp:
(WebCore::WebCoreAVCFResourceLoader::startLoading):
- 3:53 PM Changeset in webkit [196088] by
-
- 5 edits in trunk
Yosemite build fix; hide the entire WebCoreNSURLSessionDataTask class from Yosemite and prior.
Source/WebCore:
- platform/network/cocoa/WebCoreNSURLSession.h:
- platform/network/cocoa/WebCoreNSURLSession.mm:
(-[WebCoreNSURLSessionDataTask initWithSession:identifier:URL:]):
(-[WebCoreNSURLSessionDataTask initWithSession:identifier:request:]):
Tools:
- TestWebKitAPI/Tests/WebCore/WebCoreNSURLSession.mm:
- 3:30 PM Changeset in webkit [196087] by
-
- 5 edits in tags/Safari-602.1.18.1.1/Source
Versioning.
- 3:26 PM Changeset in webkit [196086] by
-
- 1 copy in tags/Safari-602.1.18.1.1
New tag.
- 3:06 PM Changeset in webkit [196085] by
-
- 2 edits in trunk/Tools
[Tools] Remove $additionalCMakeArgs variable because without this variable --cmakeargs options works well
https://bugs.webkit.org/show_bug.cgi?id=153827
Reviewed by Michael Catanzaro.
When an array is passed to subroutines as argument in perl,
a list containing its element is returned from the array.
Currently @$ arguments are being passed, then it is going to be one list
including all the elements not only from @ but also from $.
As a result, --cmakeargs option's value is included in @cmakeArgs
at generateBuildSystemFromCMakeProject subroutine,
so $additionalCMakeArgs doesn't needed anymore.
- Scripts/webkitdirs.pm:
(generateBuildSystemFromCMakeProject):
- 3:01 PM Changeset in webkit [196084] by
-
- 3 edits1 delete in trunk/LayoutTests
REGRESSION: LayoutTest http/tests/plugins/visible_plugins.html failing on Yosemite WK1
https://bugs.webkit.org/show_bug.cgi?id=153752
Reviewed by Alexey Proskuryakov.
Revise test to skip the plugins we expect to be displayed, and only display plugins
that are surprising.
- http/tests/plugins/visible_plugins.html:
- http/tests/plugins/visible_plugins-expected.txt:
- platform/mac-wk2/http/tests/plugins/visible_plugins-expected.txt: Removed.
- 2:59 PM Changeset in webkit [196083] by
-
- 2 edits in trunk/Source/WebCore
[EME][Mac] MediaKeys.createSession() fails with initData containing a contentId whose length is > 1/2 the initData.
https://bugs.webkit.org/show_bug.cgi?id=153517
<rdar://problem/24303782>
Reviewed by Eric Carlson.
The length of contentId is given in bytes, not Uint16 characters. Use the former when extracting
the contentId string from the initData.
- platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
(WebCore::MediaPlayerPrivateAVFoundation::extractKeyURIKeyIDAndCertificateFromInitData):
- 2:57 PM Changeset in webkit [196082] by
-
- 5 edits4 adds in trunk
[Mac] Wrap a resource and resource loader in a NSURLSession-like object for use by lower level frameworks
https://bugs.webkit.org/show_bug.cgi?id=153669
Reviewed by Alex Christensen.
Source/WebCore:
API Test: WebCore.WebCoreNSURLSession
Add a NSURLSession-like object, which wraps a CachedResourceLoader and CachedRawResource, which we can
hand to lower-level frameworks, so that network loads by those frameworks use WebKit's loader.
- platform/network/cocoa/WebCoreNSURLSession.h: Added.
- platform/network/cocoa/WebCoreNSURLSession.mm: Added.
(-[WebCoreNSURLSession initWithResourceLoader:delegate:delegateQueue:]):
(-[WebCoreNSURLSession dealloc]):
(-[WebCoreNSURLSession copyWithZone:]):
(-[WebCoreNSURLSession delegateQueue]):
(-[WebCoreNSURLSession configuration]):
(-[WebCoreNSURLSession loader]):
(-[WebCoreNSURLSession finishTasksAndInvalidate]):
(-[WebCoreNSURLSession invalidateAndCancel]):
(-[WebCoreNSURLSession resetWithCompletionHandler:]):
(-[WebCoreNSURLSession flushWithCompletionHandler:]):
(-[WebCoreNSURLSession getTasksWithCompletionHandler:]):
(-[WebCoreNSURLSession getAllTasksWithCompletionHandler:]):
(-[WebCoreNSURLSession dataTaskWithRequest:]):
(-[WebCoreNSURLSession dataTaskWithURL:]):
(-[WebCoreNSURLSession uploadTaskWithRequest:fromFile:]):
(-[WebCoreNSURLSession uploadTaskWithRequest:fromData:]):
(-[WebCoreNSURLSession uploadTaskWithStreamedRequest:]):
(-[WebCoreNSURLSession downloadTaskWithRequest:]):
(-[WebCoreNSURLSession downloadTaskWithURL:]):
(-[WebCoreNSURLSession downloadTaskWithResumeData:]):
(-[WebCoreNSURLSession streamTaskWithHostName:port:]):
(-[WebCoreNSURLSession streamTaskWithNetService:]):
(-[WebCoreNSURLSession isKindOfClass:]):
Add a C++ class which can act as a CachedRawResourceClient, passing the results back to a WebCoreNSURLSessionDataTask:
(WebCore::WebCoreNSURLSessionDataTaskClient::WebCoreNSURLSessionDataTaskClient):
(WebCore::WebCoreNSURLSessionDataTaskClient::dataSent):
(WebCore::WebCoreNSURLSessionDataTaskClient::responseReceived):
(WebCore::WebCoreNSURLSessionDataTaskClient::dataReceived):
(WebCore::WebCoreNSURLSessionDataTaskClient::redirectReceived):
(WebCore::WebCoreNSURLSessionDataTaskClient::notifyFinished):
Add a NSURLSessionDataTask-like object, which takes a request, then uses it to create and wrap a CachedRawResource.
Becase NSURSessionDataTask is intended to be used off-main-thread, care must be taken to dispatch back to the main-
(or web-) thread before calling CachedRawResource functions.
(-[WebCoreNSURLSessionDataTask initWithSession:identifier:URL:]):
(-[WebCoreNSURLSessionDataTask initWithSession:identifier:request:]):
(-[WebCoreNSURLSessionDataTask copyWithZone:]):
(-[WebCoreNSURLSessionDataTask _restart]):
(-[WebCoreNSURLSessionDataTask _cancel]):
(-[WebCoreNSURLSessionDataTask _finish]):
(-[WebCoreNSURLSessionDataTask _setDefersLoading:]):
(-[WebCoreNSURLSessionDataTask cancel]):
(-[WebCoreNSURLSessionDataTask suspend]):
(-[WebCoreNSURLSessionDataTask resume]):
(-[WebCoreNSURLSessionDataTask _timingData]):
(-[WebCoreNSURLSessionDataTask resource:sentBytes:totalBytesToBeSent:]):
(-[WebCoreNSURLSessionDataTask resource:receivedResponse:]):
(-[WebCoreNSURLSessionDataTask resource:receivedData:length:]):
(-[WebCoreNSURLSessionDataTask resource:receivedRedirect:request:]):
(-[WebCoreNSURLSessionDataTask resourceFinished:]):
- WebCore.xcodeproj/project.pbxproj: Add new files to project.
Tools:
Add an API test for WebCoreNSURLSession, testing that it behaves like a regulare NSURLSession, including
calling appropriate NSURLSessionDelegate callbacks.
Drive-by fix: Add a FeatureDefines.xcconfig to TestWebKitAPI. Without this, the ENABLE macros in WebCore
header files will not match the one used when compiling WebCore, leading to strange crashes and weird
inconsistencies when calling, e.g., inline methods.
- TestWebKitAPI/Configurations/FeatureDefines.xcconfig: Added.
- TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/WebCore/WebCoreNSURLSession.mm: Added.
(-[TestNSURLSessionLoaderDelegate webView:didCommitLoadForFrame:]):
(-[TestNSURLSessionDataDelegate URLSession:task:didCompleteWithError:]):
(-[TestNSURLSessionDataDelegate URLSession:dataTask:didReceiveResponse:completionHandler:]):
(-[TestNSURLSessionDataDelegate URLSession:dataTask:didReceiveData:]):
(TestWebKitAPI::WebCoreNSURLSessionTest::SetUp):
(TestWebKitAPI::WebCoreNSURLSessionTest::TearDown):
(TestWebKitAPI::TEST_F):
- 2:46 PM Changeset in webkit [196081] by
-
- 2 edits in branches/safari-601-branch/LayoutTests
Work towards rdar://problem/24190682
- 2:08 PM Changeset in webkit [196080] by
-
- 34 edits in trunk/Source
Convert another batch of String::lower callsites to something better, typically convertToASCIILowercase
https://bugs.webkit.org/show_bug.cgi?id=153789
Reviewed by Sam Weinig.
Source/WebCore:
- dom/DOMImplementation.cpp:
(WebCore::DOMImplementation::isXMLMIMEType): Use equalLettersIgnoringASCIICase
and the boolean argument to endsWith to ignore ASCII case.
(WebCore::DOMImplementation::isTextMIMEType): Ditto. Also simplified the logic
by removing an if statement.
- dom/Document.cpp:
(WebCore::isSeparator): Deleted. Moved to WindowFeatures.cpp.
(WebCore::processArguments): Ditto.
(WebCore::Document::processViewport): Call the processFeaturesString function
from WindowFeatures.h; the code here was originally just a pasted copy of that code!
(WebCore::Document::processFormatDetection): Ditto.
- html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::toEncodingMimeType): Remove now-unneeded
lowercasing of MIME type before calling isSupportedImageMIMETypeForEncoding,
since the MIME type registry now ignores ASCII case. Use convertToASCIILowercase
on the return value, to preserve behavior.
(WebCore::HTMLCanvasElement::toDataURL): Minor coding style tweaks.
- html/HTMLEmbedElement.cpp:
(WebCore::HTMLEmbedElement::parseAttribute): Use convertToASCIILowercase for
the service type here.
- html/HTMLImageElement.cpp:
(WebCore::HTMLImageElement::bestFitSourceFromPictureElement): Remove now-unneeded
lowercasing since MIME type registry now ignores ASCII case. And use
equalLettersIgnoringASCIICase for the case here.
- html/HTMLInputElement.cpp:
(WebCore::parseAcceptAttribute): Use convertToASCIILowercase for the type here.
- html/HTMLLinkElement.cpp:
(WebCore::HTMLLinkElement::parseAttribute): Use convertToASCIILowercase for the
media value here.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::canPlayType): Use convertToASCIILowercase for the
content type here.
(WebCore::HTMLMediaElement::selectNextSourceChild): Ditto.
- html/HTMLObjectElement.cpp:
(WebCore::HTMLObjectElement::parseAttribute): Use convertToASCIILowercase for
the service type here.
- html/HTMLTrackElement.cpp:
(WebCore::HTMLTrackElement::parseAttribute): Use convertToASCIILowercase for
the kind here.
(WebCore::HTMLTrackElement::ensureTrack): Ditto. Also use fastGetAttribute
since this is neither the style attribute nor an animatable SVG attribute.
- html/parser/HTMLTreeBuilder.cpp:
(WebCore::createCaseMap): Use convertToASCIILowercase for the local names here.
- inspector/DOMPatchSupport.cpp:
(WebCore::DOMPatchSupport::patchNode): Use containsIgnoringASCIICase instead
of combining lower with find == notFound here.
(WebCore::nodeName): Use convertToASCIILowercase here.
- inspector/InspectorOverlay.cpp:
(WebCore::buildObjectForElementData): Use convertToASCIILowercase for node
name here.
- inspector/InspectorPageAgent.cpp:
(WebCore::createXHRTextDecoder): Remove a now-unneeded call to lower since
DOMImplementation::isXMLMIMEType now ignores ASCII case.
- inspector/InspectorStyleSheet.cpp:
(WebCore::lowercasePropertyName): Use convertToASCIILowercase for property
names here. Also use startsWith rather than a hand-written alternative.
(WebCore::InspectorStyle::populateAllProperties): Use the return value of
the add function to avoid doing a double hash table lookp.
(WebCore::InspectorStyle::styleWithProperties): Use convertToASCIILowercase
to lowercase the property name.
- inspector/NetworkResourcesData.cpp:
(WebCore::createOtherResourceTextDecoder): Remove unneeded call to lower since
DOMImplement::isXMLMIMEType now ignores ASCII case.
- loader/CrossOriginAccessControl.cpp:
(WebCore::createAccessControlPreflightRequest): Use convertToASCIILowercase
to lowercase the access control request header field value.
- loader/cache/CachedScript.cpp:
(WebCore::CachedScript::mimeType): Use convertToASCIILowercase on the content type.
- page/CaptionUserPreferencesMediaAF.cpp:
(WebCore::languageIdentifier): Use convertToASCIILowercase on the language code.
- page/DOMWindow.cpp:
(WebCore::DOMWindow::open): Call parseWindowFeatures instead of using the
constructor for WindowFeatures.
(WebCore::DOMWindow::showModalDialog): Call parseDialogFeatures instead of
using the constructor for WindowFeatures.
- page/EventHandler.cpp:
(WebCore::findDropZone): Remove unneeded lowercasing and empty string checking,
and use the option SpaceSplitString already has to convert to lowercase.
(WebCore::EventHandler::handleAccessKey): Remove unneeded call to lower since
getElementByAccessKey now ignores case. Also tweaked coding style a bit.
- page/OriginAccessEntry.cpp:
(WebCore::OriginAccessEntry::OriginAccessEntry): Use convertToASCIILowercase
on the protocol and host.
(WebCore::OriginAccessEntry::matchesOrigin): Ditto.
- page/SecurityOrigin.cpp:
(WebCore::shouldTreatAsUniqueOrigin): Remove unneeded call to lower since
SchemeRegistry now ignores ASCII case.
(WebCore::SecurityOrigin::SecurityOrigin): Use convertToASCIILowercase on
the protocol and host.
(WebCore::SecurityOrigin::setDomainFromDOM): Use convertToASCIILowercase on
the domain.
(WebCore::SecurityOrigin::canDisplay): Remove call to lower since SchemeRegistry
now ignores ASCII case and because this now uses equalIgnoringASCIICase in
one place that used to use exact matching.
- page/WindowFeatures.cpp: Refactored so this is now some helper functions
plus a struct rather than a class.
(WebCore::isSeparator): Renamed this and removed special handling for NUL.
(WebCore::parseWindowFeatures): Moved the code that was formerly in the
WindowFeatures constructor in here. Refactored the parsing into the
processFeaturesString function, shared with the functions in Document that
do the same kind of parsing. Removed the code that converts the entire string
to lowercase before parsing.
(WebCore::processFeaturesString): Moved the improved version of this function
here from Document.cpp; more efficient because it doesn't allocate strings.
(WebCore::setWindowFeature): Changed to be a function private to this file
with internal linkage. Use equalLettersIgnoringASCIICase so we no longer
rely on converting the string to lowercase before parsing.
(WebCore::parseDialogFeatures): Similar refactoring, but also changed all
the default handling to use Optional<> instead of default values.
(WebCore::boolFeature): Changed to use option and to ignore ASCII case.
(WebCore::floatFeature): Ditto.
(WebCore::parseDialogFeaturesMap): Removed the calls to lower, which are
not needed any more.
- page/WindowFeatures.h: Added default values for all the data members,
and removed all the functions from the WindowFeatures struct. Added the two
functions for parsing window and dialog features. Also added the
processFeaturesString function so we can share it with Document.cpp.
- platform/SchemeRegistry.cpp:
(WebCore::SchemeRegistry::removeURLSchemeRegisteredAsLocal): Use
equalLettersIgnoringASCIICase to ignore ASCII case.
- platform/efl/MIMETypeRegistryEfl.cpp:
(WebCore::MIMETypeRegistry::getMIMETypeForExtension): Use a modern for loop,
and equalIgnoringASCIICase rather than calling lower.
- platform/graphics/MediaPlayer.cpp:
(WebCore::MediaPlayer::load): Use convertToASCIILowercase on MIME type and
key system.
(WebCore::MediaPlayer::generateKeyRequest): Ditto.
(WebCore::MediaPlayer::addKey): Ditto.
(WebCore::MediaPlayer::cancelKeyRequest): Ditto.
- platform/graphics/opengl/Extensions3DOpenGLCommon.cpp:
(WebCore::Extensions3DOpenGLCommon::Extensions3DOpenGLCommon): Use
convertToASCIILowercase on vendor string.
- platform/gtk/MIMETypeRegistryGtk.cpp:
(WebCore::MIMETypeRegistry::getMIMETypeForExtension): Use a modern for loop,
and equalIgnoringASCIICase rather than calling lower.
- platform/mac/PasteboardMac.mm:
(WebCore::cocoaTypeFromHTMLClipboardType): Use convertToASCIILowercase
on the type. Also did a bit of renaming and tweaking the logic.
Source/WTF:
- wtf/text/StringView.h:
(WTF::StringView::toInt): Added an overload without the out parameter.
- 1:54 PM Changeset in webkit [196079] by
-
- 18 edits1 copy1 move11 adds in trunk/LayoutTests/imported/w3c
Re-sync W3C DOM web-platform-tests
https://bugs.webkit.org/show_bug.cgi?id=153831
Reviewed by Darin Adler.
Re-sync W3C DOM web-platform-tests from:
https://github.com/w3c/web-platform-tests/tree/master/dom
- web-platform-tests/dom/collections/domstringmap-supported-property-names-expected.txt: Added.
- web-platform-tests/dom/collections/domstringmap-supported-property-names.html: Added.
- web-platform-tests/dom/collections/namednodemap-supported-property-names-expected.txt: Added.
- web-platform-tests/dom/collections/namednodemap-supported-property-names.html: Added.
- web-platform-tests/dom/collections/w3c-import.log:
- web-platform-tests/dom/events/Event-dispatch-propagation-stopped-expected.txt: Added.
- web-platform-tests/dom/events/Event-dispatch-propagation-stopped.html: Added.
- web-platform-tests/dom/events/w3c-import.log:
- web-platform-tests/dom/historical-expected.txt:
- web-platform-tests/dom/historical.html:
- web-platform-tests/dom/interface-objects-expected.txt:
- web-platform-tests/dom/interface-objects.html:
- web-platform-tests/dom/interfaces-expected.txt:
- web-platform-tests/dom/interfaces.html:
- web-platform-tests/dom/nodes/DOMImplementation-createDocument-expected.txt:
- web-platform-tests/dom/nodes/DOMImplementation-createDocument.html:
- web-platform-tests/dom/nodes/Document-createElement-namespace-tests/empty.html: Added.
- web-platform-tests/dom/nodes/Document-createElement-namespace-tests/empty.svg: Added.
- web-platform-tests/dom/nodes/Document-createElement-namespace-tests/empty.xhtml: Added.
- web-platform-tests/dom/nodes/Document-createElement-namespace-tests/empty.xml: Added.
- web-platform-tests/dom/nodes/Element-classlist-expected.txt:
- web-platform-tests/dom/nodes/Element-classlist.html:
- web-platform-tests/dom/nodes/Node-contains-xhtml-expected.txt: Added.
- web-platform-tests/dom/nodes/Node-contains-xhtml.xhtml: Added.
- web-platform-tests/dom/nodes/Node-isEqualNode-expected.txt:
- web-platform-tests/dom/nodes/Node-isEqualNode-xhtml-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/dom/nodes/Node-isEqualNode-expected.txt.
- web-platform-tests/dom/nodes/Node-isEqualNode-xhtml.xhtml: Renamed from LayoutTests/imported/w3c/web-platform-tests/dom/nodes/Node-isEqualNode.xhtml.
- web-platform-tests/dom/nodes/Node-isEqualNode.html: Added.
- web-platform-tests/dom/nodes/attributes-expected.txt:
- web-platform-tests/dom/nodes/attributes.html:
- web-platform-tests/dom/nodes/w3c-import.log:
- web-platform-tests/dom/ranges/Range-constructor-expected.txt: Added.
- web-platform-tests/dom/ranges/Range-constructor.html: Added.
- web-platform-tests/dom/ranges/w3c-import.log:
- web-platform-tests/dom/w3c-import.log:
- 1:26 PM Changeset in webkit [196078] by
-
- 2 edits in trunk/LayoutTests
Skip http/tests/contentdispositionattachmentsandbox/form-submission-disabled.html on ios-simulator until it can be rewritten.
https://bugs.webkit.org/show_bug.cgi?id=152993
Unreviewed test gardening.
- platform/ios-simulator/TestExpectations:
- 1:21 PM Changeset in webkit [196077] by
-
- 13 edits in trunk
[GTK][EFL] Switch FTL to B3
https://bugs.webkit.org/show_bug.cgi?id=153478
Reviewed by Csaba Osztrogonác.
.:
- Source/cmake/OptionsEfl.cmake:
- Source/cmake/OptionsGTK.cmake:
Source/JavaScriptCore:
Conditionalize code to make it possible to build FTL completely without LLVM.
- CMakeLists.txt:
- dfg/DFGCommon.h:
- dfg/DFGPlan.cpp:
(JSC::DFG::Plan::compileInThreadImpl):
- ftl/FTLAbbreviatedTypes.h:
- ftl/FTLFail.cpp:
(JSC::FTL::fail):
- ftl/FTLState.cpp:
(JSC::FTL::State::State):
(JSC::FTL::State::~State):
Source/WTF:
Enable B3 by default on all x86.
- wtf/Platform.h:
- 1:10 PM Changeset in webkit [196076] by
-
- 2 edits in trunk/Source/WebInspectorUI
Add hanging-punctuation property to Web Inspector
https://bugs.webkit.org/show_bug.cgi?id=153841
Reviewed by Zalan Bujtas.
- UserInterface/Models/CSSKeywordCompletions.js:
- 12:54 PM Changeset in webkit [196075] by
-
- 14 edits3 adds in trunk
Implement hanging-punctuation property parsing.
https://bugs.webkit.org/show_bug.cgi?id=18109.
Reviewed by Zalan Bujtas.
Source/WebCore:
Added parsing test in fast/css.
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::renderEmphasisPositionFlagsToCSSValue):
(WebCore::hangingPunctuationToCSSValue):
(WebCore::fillRepeatToCSSValue):
(WebCore::ComputedStyleExtractor::propertyValue):
- css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseTextIndent):
(WebCore::CSSParser::parseHangingPunctuation):
(WebCore::CSSParser::parseLineBoxContain):
- css/CSSParser.h:
- css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator HangingPunctuation):
(WebCore::CSSPrimitiveValue::operator LineBreak):
- css/CSSPropertyNames.in:
- css/CSSValueKeywords.in:
- css/StyleBuilderConverter.h:
(WebCore::StyleBuilderConverter::convertRegionBreakInside):
(WebCore::StyleBuilderConverter::convertHangingPunctuation):
- rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::changeRequiresLayout):
- rendering/style/RenderStyle.h:
- rendering/style/RenderStyleConstants.h:
(WebCore::operator| ):
(WebCore::operator|= ):
- rendering/style/StyleRareInheritedData.cpp:
(WebCore::StyleRareInheritedData::StyleRareInheritedData):
(WebCore::StyleRareInheritedData::operator==):
- rendering/style/StyleRareInheritedData.h:
LayoutTests:
- fast/css/parsing-hanging-punctuation-expected.txt: Added.
- fast/css/parsing-hanging-punctuation.html: Added.
- fast/css/resources/parsing-hanging-punctuation.js: Added.
(test):
- 12:15 PM Changeset in webkit [196074] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Uncaught exception TimelineRuler.prototype.resize no longer exists
https://bugs.webkit.org/show_bug.cgi?id=153839
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-02-03
Reviewed by Brian Burg.
- UserInterface/Views/MemoryTimelineView.js:
(WebInspector.MemoryTimelineView.prototype.shown):
After r195995 the resize method was eliminated in favor of this approach.
- 12:14 PM Changeset in webkit [196073] by
-
- 2 edits in branches/safari-601-branch/Source/WebKit2
Update WebKit2.framework copyright string to include 2016.
This framework no longer exists on trunk, so we missed this as part of the merge of r194479.
- mac/Info-WebKit2.plist:
- 10:58 AM Changeset in webkit [196072] by
-
- 2 edits in trunk/Source/WebKit2
Use proposed credentials in authentication challenges with NetworkSession
https://bugs.webkit.org/show_bug.cgi?id=153811
Reviewed by Darin Adler.
This fixes http/tests/xmlhttprequest/basic-auth-default.html
- NetworkProcess/cocoa/NetworkSessionCocoa.mm:
(WebKit::NetworkDataTask::tryPasswordBasedAuthentication):
Use the proposed credential if there is one. This matches behavior in
ResourceHandle::tryHandlePasswordBasedAuthentication.
- 10:21 AM Changeset in webkit [196071] by
-
- 2 edits in trunk/Source/WTF
Fix BlockPtr's call operator
https://bugs.webkit.org/show_bug.cgi?id=153836
Reviewed by Enrica Casucci.
- wtf/BlockPtr.h:
- 9:59 AM Changeset in webkit [196070] by
-
- 7 edits in trunk/Source
Build fix.
[NSEvent context] has always returned nil. Replace uses with nullptr.
Source/WebCore:
- page/mac/EventHandlerMac.mm:
(WebCore::EventHandler::sendFakeEventsAfterWidgetTracking):
Source/WebKit/mac:
- WebView/WebHTMLView.mm:
(-[WebHTMLView _postFakeMouseMovedEventForFlagsChangedEvent:]):
(-[WebHTMLView _updateMouseoverWithFakeEvent]):
(-[WebHTMLView _updateMouseoverWithEvent:]):
(-[WebHTMLView _autoscroll]):
(-[WebHTMLView draggedImage:endedAt:operation:]):
Source/WebKit2:
- UIProcess/Cocoa/WebViewImpl.mm:
(WebKit::WebViewImpl::postFakeMouseMovedEventForFlagsChangedEvent):
- UIProcess/mac/WebPopupMenuProxyMac.mm:
(WebKit::WebPopupMenuProxyMac::showPopupMenu):
- 9:51 AM Changeset in webkit [196069] by
-
- 2 edits in trunk/LayoutTests
Skip fast/forms/input-user-input-sanitization.html on ios-simulator
https://bugs.webkit.org/show_bug.cgi?id=152306
Unreviewed test gardening.
- platform/ios-simulator/TestExpectations:
- 9:49 AM Changeset in webkit [196068] by
-
- 3 edits in trunk/Source/WebKit2
[iOS] Engineering builds use manual sandboxing, but don’t need to
https://bugs.webkit.org/show_bug.cgi?id=153834
Reviewed by Anders Carlsson.
Now that engineering builds use the non-re-execing variant of XPC services, they can be
statically sandboxed and no longer need to be manually sandboxed.
- Configurations/DebugRelease.xcconfig: Don’t set WK_MANUAL_SANDBOXING_ENABLED to YES.
- WebKit2.xcodeproj/project.pbxproj: Let Xcode make changes to the built product references.
- 9:09 AM Changeset in webkit [196067] by
-
- 2 edits in trunk/Source/WebKit2
Unreviewed, rolling out r195555.
Temporarily disable speculative revalidation to measure the
impact on the bots
Reverted changeset:
"[WK2][NetworkCache] Enable speculative revalidation"
https://bugs.webkit.org/show_bug.cgi?id=153443
http://trac.webkit.org/changeset/195555
- 8:34 AM Changeset in webkit [196066] by
-
- 2 edits in trunk/Source/WebKit2
REGRESSION (r194660): Legacy WebProcess crashes in ChildProcess::initializeSandbox()
https://bugs.webkit.org/show_bug.cgi?id=153734
<rdar://problem/24433179>
Reviewed by Dan Bernstein.
Fixes an issue where clients that used the legacy WebProcess bootstrapping process would crash.
Additionally, only consider the extra initialization parameter user-directory-suffix for
unsigned apps (e.g. WebKitTestRunner).
- Shared/mac/ChildProcessMac.mm:
(WebKit::ChildProcess::initializeSandbox):
- 3:38 AM Changeset in webkit [196065] by
-
- 6 edits in trunk/Tools
[webkitdirs] Clarify logic behind is{PortName} functions.
https://bugs.webkit.org/show_bug.cgi?id=153554
Patch by Konstantin Tokarev <Konstantin Tokarev> on 2016-02-03
Reviewed by Michael Catanzaro.
- Scripts/webkitdirs.pm:
(prohibitUnknownPort): This function makes determinePortName()
failure fatal.
(determinePortName): Added new function which decides which port are
we building based on command line switches and platform defaults.
(portName): Added getter for determined $portName.
(isEfl): Modified to use portName().
(isGtk): Ditto.
(isWinCairo): Ditto.
(isAppleMacWebKit): Ditto.
(isAppleWinWebKit): Ditto.
(isIOSWebKit): Ditto.
(cmakeBasedPortName): Return portName() with capitalized first letter.
(determineIsEfl): Deleted.
(determineIsGtk): Deleted.
(determineIsWinCairo): Deleted.
- Scripts/build-jsc: Call prohibitUnknownPort().
- Scripts/run-minibrowser: Ditto.
- Scripts/webkitperl/FeatureList.pm: Ditto.
- Scripts/update-webkit: Call determinePortName() instead of
determineIsWinCairo().
- 3:29 AM Changeset in webkit [196064] by
-
- 2 edits in trunk/Source/WebKit2
Unreviewed speculative buildfix after r195979.
- PlatformMac.cmake:
- 3:13 AM Changeset in webkit [196063] by
-
- 254 edits in trunk/LayoutTests
Unreviewed. EFL gardening: rebaseline tests after r195740.
- platform/efl/css1/box_properties/border_width_inline-expected.txt:
- platform/efl/css1/formatting_model/floating_elements-expected.txt:
- platform/efl/css2.1/t080301-c411-vt-mrgn-00-b-expected.txt:
- platform/efl/css2.1/t0805-c5511-brdr-tw-00-b-expected.txt:
- platform/efl/css2.1/t0805-c5513-brdr-bw-00-b-expected.txt:
- platform/efl/css2.1/t0805-c5518-brdr-t-01-e-expected.txt:
- platform/efl/css2.1/t0805-c5519-brdr-r-01-e-expected.txt:
- platform/efl/css2.1/t0805-c5520-brdr-b-01-e-expected.txt:
- platform/efl/css2.1/t0805-c5521-brdr-l-01-e-expected.txt:
- platform/efl/css2.1/t0805-c5522-brdr-02-e-expected.txt:
- platform/efl/css2.1/t170602-bdr-conflct-w-00-d-expected.txt:
- platform/efl/css2.1/t170602-bdr-conflct-w-01-d-expected.txt:
- platform/efl/css2.1/t170602-bdr-conflct-w-02-d-expected.txt:
- platform/efl/css2.1/t170602-bdr-conflct-w-03-d-expected.txt:
- platform/efl/css2.1/t170602-bdr-conflct-w-05-d-expected.txt:
- platform/efl/css2.1/t170602-bdr-conflct-w-07-d-expected.txt:
- platform/efl/css2.1/t170602-bdr-conflct-w-09-d-expected.txt:
- platform/efl/css2.1/t170602-bdr-conflct-w-10-d-expected.txt:
- platform/efl/css2.1/t170602-bdr-conflct-w-11-d-expected.txt:
- platform/efl/css2.1/t170602-bdr-conflct-w-12-d-expected.txt:
- platform/efl/css2.1/t170602-bdr-conflct-w-15-d-expected.txt:
- platform/efl/css2.1/t170602-bdr-conflct-w-19-d-expected.txt:
- platform/efl/css2.1/t170602-bdr-conflct-w-20-d-expected.txt:
- platform/efl/css2.1/t170602-bdr-conflct-w-21-d-expected.txt:
- platform/efl/css2.1/t170602-bdr-conflct-w-22-d-expected.txt:
- platform/efl/css2.1/t170602-bdr-conflct-w-23-d-expected.txt:
- platform/efl/css2.1/t170602-bdr-conflct-w-26-d-expected.txt:
- platform/efl/css2.1/t170602-bdr-conflct-w-27-d-expected.txt:
- platform/efl/css2.1/t170602-bdr-conflct-w-28-d-expected.txt:
- platform/efl/css2.1/t170602-bdr-conflct-w-29-d-expected.txt:
- platform/efl/css2.1/t170602-bdr-conflct-w-32-d-expected.txt:
- platform/efl/css2.1/t170602-bdr-conflct-w-33-d-expected.txt:
- platform/efl/css2.1/t170602-bdr-conflct-w-35-d-expected.txt:
- platform/efl/css2.1/t170602-bdr-conflct-w-36-d-expected.txt:
- platform/efl/css2.1/t170602-bdr-conflct-w-37-d-expected.txt:
- platform/efl/css2.1/t170602-bdr-conflct-w-38-d-expected.txt:
- platform/efl/css2.1/t170602-bdr-conflct-w-39-d-expected.txt:
- platform/efl/css2.1/t170602-bdr-conflct-w-40-d-expected.txt:
- platform/efl/css2.1/t170602-bdr-conflct-w-41-d-expected.txt:
- platform/efl/css2.1/t170602-bdr-conflct-w-42-d-expected.txt:
- platform/efl/css2.1/t170602-bdr-conflct-w-43-d-expected.txt:
- platform/efl/css2.1/t170602-bdr-conflct-w-45-d-expected.txt:
- platform/efl/css2.1/t170602-bdr-conflct-w-46-d-expected.txt:
- platform/efl/css2.1/t170602-bdr-conflct-w-47-d-expected.txt:
- platform/efl/css2.1/t170602-bdr-conflct-w-48-d-expected.txt:
- platform/efl/css2.1/t170602-bdr-conflct-w-49-d-expected.txt:
- platform/efl/css2.1/t170602-bdr-conflct-w-50-d-expected.txt:
- platform/efl/css2.1/t170602-bdr-conflct-w-51-d-expected.txt:
- platform/efl/css2.1/t170602-bdr-conflct-w-53-d-expected.txt:
- platform/efl/css2.1/t170602-bdr-conflct-w-55-d-expected.txt:
- platform/efl/css2.1/t170602-bdr-conflct-w-56-d-expected.txt:
- platform/efl/css2.1/t170602-bdr-conflct-w-57-d-expected.txt:
- platform/efl/css2.1/t170602-bdr-conflct-w-58-d-expected.txt:
- platform/efl/css2.1/t170602-bdr-conflct-w-60-d-expected.txt:
- platform/efl/css2.1/t170602-bdr-conflct-w-61-d-expected.txt:
- platform/efl/css2.1/t170602-bdr-conflct-w-62-d-expected.txt:
- platform/efl/css2.1/t170602-bdr-conflct-w-63-d-expected.txt:
- platform/efl/css2.1/t170602-bdr-conflct-w-66-d-expected.txt:
- platform/efl/css2.1/t170602-bdr-conflct-w-67-d-expected.txt:
- platform/efl/css2.1/t170602-bdr-conflct-w-68-d-expected.txt:
- platform/efl/css2.1/t170602-bdr-conflct-w-69-d-expected.txt:
- platform/efl/css2.1/t170602-bdr-conflct-w-72-d-expected.txt:
- platform/efl/css2.1/t170602-bdr-conflct-w-73-d-expected.txt:
- platform/efl/css2.1/t170602-bdr-conflct-w-75-d-expected.txt:
- platform/efl/css2.1/t170602-bdr-conflct-w-76-d-expected.txt:
- platform/efl/css2.1/t170602-bdr-conflct-w-77-d-expected.txt:
- platform/efl/css2.1/t170602-bdr-conflct-w-78-d-expected.txt:
- platform/efl/css2.1/t170602-bdr-conflct-w-79-d-expected.txt:
- platform/efl/css2.1/t170602-bdr-conflct-w-80-d-expected.txt:
- platform/efl/css2.1/t170602-bdr-conflct-w-81-d-expected.txt:
- platform/efl/css2.1/t170602-bdr-conflct-w-82-d-expected.txt:
- platform/efl/css2.1/t170602-bdr-conflct-w-83-d-expected.txt:
- platform/efl/css2.1/t170602-bdr-conflct-w-86-d-expected.txt:
- platform/efl/css2.1/t170602-bdr-conflct-w-87-d-expected.txt:
- platform/efl/css2.1/t170602-bdr-conflct-w-88-d-expected.txt:
- platform/efl/css2.1/t170602-bdr-conflct-w-89-d-expected.txt:
- platform/efl/css2.1/t170602-bdr-conflct-w-90-d-expected.txt:
- platform/efl/css2.1/t170602-bdr-conflct-w-91-d-expected.txt:
- platform/efl/css2.1/t170602-bdr-conflct-w-92-d-expected.txt:
- platform/efl/css2.1/t170602-bdr-conflct-w-93-d-expected.txt:
- platform/efl/css2.1/t170602-bdr-conflct-w-95-d-expected.txt:
- platform/efl/css2.1/t170602-bdr-conflct-w-96-d-expected.txt:
- platform/efl/css2.1/t170602-bdr-conflct-w-97-d-expected.txt:
- platform/efl/css2.1/t170602-bdr-conflct-w-98-d-expected.txt:
- platform/efl/css2.1/t170602-bdr-conflct-w-99-d-expected.txt:
- platform/efl/css3/css3-modsel-33-expected.txt:
- platform/efl/css3/flexbox/flexbox-baseline-expected.txt:
- platform/efl/css3/selectors3/html/css3-modsel-161-expected.txt:
- platform/efl/css3/selectors3/html/css3-modsel-18b-expected.txt:
- platform/efl/css3/selectors3/html/css3-modsel-28-expected.txt:
- platform/efl/css3/selectors3/html/css3-modsel-28b-expected.txt:
- platform/efl/css3/selectors3/html/css3-modsel-32-expected.txt:
- platform/efl/css3/selectors3/html/css3-modsel-43-expected.txt:
- platform/efl/css3/selectors3/html/css3-modsel-43b-expected.txt:
- platform/efl/css3/selectors3/html/css3-modsel-44-expected.txt:
- platform/efl/css3/selectors3/html/css3-modsel-44b-expected.txt:
- platform/efl/css3/selectors3/html/css3-modsel-74-expected.txt:
- platform/efl/css3/selectors3/html/css3-modsel-74b-expected.txt:
- platform/efl/css3/selectors3/html/css3-modsel-78-expected.txt:
- platform/efl/css3/selectors3/html/css3-modsel-78b-expected.txt:
- platform/efl/css3/selectors3/xhtml/css3-modsel-161-expected.txt:
- platform/efl/css3/selectors3/xhtml/css3-modsel-18b-expected.txt:
- platform/efl/css3/selectors3/xhtml/css3-modsel-28-expected.txt:
- platform/efl/css3/selectors3/xhtml/css3-modsel-28b-expected.txt:
- platform/efl/css3/selectors3/xhtml/css3-modsel-32-expected.txt:
- platform/efl/css3/selectors3/xhtml/css3-modsel-43-expected.txt:
- platform/efl/css3/selectors3/xhtml/css3-modsel-43b-expected.txt:
- platform/efl/css3/selectors3/xhtml/css3-modsel-44-expected.txt:
- platform/efl/css3/selectors3/xhtml/css3-modsel-44b-expected.txt:
- platform/efl/css3/selectors3/xhtml/css3-modsel-74-expected.txt:
- platform/efl/css3/selectors3/xhtml/css3-modsel-74b-expected.txt:
- platform/efl/css3/selectors3/xhtml/css3-modsel-78-expected.txt:
- platform/efl/css3/selectors3/xhtml/css3-modsel-78b-expected.txt:
- platform/efl/css3/selectors3/xml/css3-modsel-161-expected.txt:
- platform/efl/css3/selectors3/xml/css3-modsel-18b-expected.txt:
- platform/efl/css3/selectors3/xml/css3-modsel-28-expected.txt:
- platform/efl/css3/selectors3/xml/css3-modsel-28b-expected.txt:
- platform/efl/css3/selectors3/xml/css3-modsel-32-expected.txt:
- platform/efl/css3/selectors3/xml/css3-modsel-43-expected.txt:
- platform/efl/css3/selectors3/xml/css3-modsel-44-expected.txt:
- platform/efl/css3/selectors3/xml/css3-modsel-44b-expected.txt:
- platform/efl/css3/selectors3/xml/css3-modsel-74-expected.txt:
- platform/efl/css3/selectors3/xml/css3-modsel-74b-expected.txt:
- platform/efl/css3/selectors3/xml/css3-modsel-78-expected.txt:
- platform/efl/css3/selectors3/xml/css3-modsel-78b-expected.txt:
- platform/efl/editing/inserting/5058163-1-expected.txt:
- platform/efl/editing/inserting/insert-paragraph-01-expected.txt:
- platform/efl/editing/inserting/insert-paragraph-02-expected.txt:
- platform/efl/editing/inserting/paragraph-separator-in-table-2-expected.txt:
- platform/efl/editing/selection/4818145-expected.txt:
- platform/efl/editing/selection/4889598-expected.txt:
- platform/efl/editing/selection/4895428-2-expected.txt:
- platform/efl/editing/selection/5076323-1-expected.txt:
- platform/efl/editing/selection/5076323-2-expected.txt:
- platform/efl/editing/selection/5076323-3-expected.txt:
- platform/efl/editing/selection/7152-1-expected.txt:
- platform/efl/editing/selection/7152-2-expected.txt:
- platform/efl/editing/selection/display-table-text-expected.txt:
- platform/efl/editing/selection/iframe-expected.txt:
- platform/efl/editing/selection/inline-table-expected.txt:
- platform/efl/editing/selection/mixed-editability-3-expected.txt:
- platform/efl/editing/selection/mixed-editability-4-expected.txt:
- platform/efl/editing/selection/mixed-editability-5-expected.txt:
- platform/efl/editing/selection/mixed-editability-8-expected.txt:
- platform/efl/editing/selection/mixed-editability-9-expected.txt:
- platform/efl/editing/selection/table-caret-1-expected.txt:
- platform/efl/editing/selection/table-caret-2-expected.txt:
- platform/efl/editing/selection/table-caret-3-expected.txt:
- platform/efl/editing/style/5017613-1-expected.txt:
- platform/efl/editing/style/5017613-2-expected.txt:
- platform/efl/editing/style/apple-style-editable-mix-expected.txt:
- platform/efl/editing/style/table-selection-expected.txt:
- platform/efl/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.txt:
- platform/efl/fast/block/float/011-expected.txt:
- platform/efl/fast/block/margin-collapse/001-expected.txt:
- platform/efl/fast/block/margin-collapse/005-expected.txt:
- platform/efl/fast/block/margin-collapse/104-expected.txt:
- platform/efl/fast/block/margin-collapse/block-inside-inline/001-expected.txt:
- platform/efl/fast/block/margin-collapse/block-inside-inline/005-expected.txt:
- platform/efl/fast/block/positioning/053-expected.txt:
- platform/efl/fast/borders/bidi-009a-expected.txt:
- platform/efl/fast/box-shadow/basic-shadows-expected.txt:
- platform/efl/fast/css-generated-content/015-expected.txt:
- platform/efl/fast/css-generated-content/inline-display-types-expected.txt:
- platform/efl/fast/css-generated-content/table-before-after-child-add-expected.txt:
- platform/efl/fast/css-generated-content/table-cell-before-content-expected.txt:
- platform/efl/fast/css-generated-content/table-row-before-after-child-add-expected.txt:
- platform/efl/fast/css-generated-content/table-row-before-after-expected.txt:
- platform/efl/fast/css-generated-content/table-table-before-after-child-add-expected.txt:
- platform/efl/fast/css/first-letter-float-expected.txt:
- platform/efl/fast/dynamic/007-expected.txt:
- platform/efl/fast/dynamic/014-expected.txt:
- platform/efl/fast/dynamic/015-expected.txt:
- platform/efl/fast/dynamic/create-renderer-for-whitespace-only-text-expected.txt:
- platform/efl/fast/forms/button-white-space-expected.txt:
- platform/efl/fast/forms/file/file-input-direction-expected.txt:
- platform/efl/fast/forms/form-added-to-table-expected.txt:
- platform/efl/fast/forms/input-double-click-selection-gap-bug-expected.txt:
- platform/efl/fast/forms/input-value-expected.txt:
- platform/efl/fast/invalid/table-inside-stray-table-content-expected.txt:
- platform/efl/fast/invalid/td-inside-object-expected.txt:
- platform/efl/fast/lists/ordered-list-with-no-ol-tag-expected.txt:
- platform/efl/fast/overflow/overflow-auto-table-expected.txt:
- platform/efl/fast/replaced/width100percent-button-expected.txt:
- platform/efl/fast/ruby/ruby-inline-table-expected.txt:
- platform/efl/fast/selectors/018-expected.txt:
- platform/efl/fast/selectors/018b-expected.txt:
- platform/efl/fast/selectors/032-expected.txt:
- platform/efl/fast/selectors/043-expected.txt:
- platform/efl/fast/selectors/043b-expected.txt:
- platform/efl/fast/selectors/044-expected.txt:
- platform/efl/fast/selectors/044b-expected.txt:
- platform/efl/fast/selectors/078b-expected.txt:
- platform/efl/fast/table/001-expected.txt:
- platform/efl/fast/table/004-expected.txt:
- platform/efl/fast/table/006-expected.txt:
- platform/efl/fast/table/010-expected.txt:
- platform/efl/fast/table/011-expected.txt:
- platform/efl/fast/table/015-expected.txt:
- platform/efl/fast/table/016-expected.txt:
- platform/efl/fast/table/022-expected.txt:
- platform/efl/fast/table/026-expected.txt:
- platform/efl/fast/table/033-expected.txt:
- platform/efl/fast/table/035-expected.txt:
- platform/efl/fast/table/035-vertical-expected.txt:
- platform/efl/fast/table/037-expected.txt:
- platform/efl/fast/table/041-expected.txt:
- platform/efl/fast/table/auto-with-percent-height-expected.txt:
- platform/efl/fast/table/auto-with-percent-height-vertical-expected.txt:
- platform/efl/fast/table/border-collapsing/002-vertical-expected.txt:
- platform/efl/fast/table/cell-coalescing-expected.txt:
- platform/efl/fast/table/cellindex-expected.txt:
- platform/efl/fast/table/colgroup-preceded-by-caption-expected.txt:
- platform/efl/fast/table/colgroup-spanning-groups-rules-expected.txt:
- platform/efl/fast/table/dynamic-descendant-percentage-height-expected.txt:
- platform/efl/fast/table/floating-th-expected.txt:
- platform/efl/fast/table/generated-caption-expected.txt:
- platform/efl/fast/table/insert-before-anonymous-ancestors-expected.txt:
- platform/efl/fast/table/insert-cell-before-form-expected.txt:
- platform/efl/fast/table/insert-row-before-form-expected.txt:
- platform/efl/fast/table/multiple-captions-display-expected.txt:
- platform/efl/fast/table/nested-percent-height-table-expected.txt:
- platform/efl/fast/table/quote-text-around-iframe-expected.txt:
- platform/efl/fast/table/rowindex-expected.txt:
- platform/efl/fast/table/rtl-cell-display-none-assert-expected.txt:
- platform/efl/fast/table/rules-attr-dynchange1-expected.txt:
- platform/efl/fast/table/rules-attr-dynchange2-expected.txt:
- platform/efl/fast/table/table-after-child-in-table-expected.txt:
- platform/efl/fast/table/table-and-parts-outline-expected.txt:
- platform/efl/fast/table/table-before-child-in-table-expected.txt:
- platform/efl/fast/table/table-cell-after-child-in-block-expected.txt:
- platform/efl/fast/table/table-cell-after-child-in-table-expected.txt:
- platform/efl/fast/table/table-cell-before-child-in-block-expected.txt:
- platform/efl/fast/table/table-continuation-outline-paint-crash-expected.txt:
- platform/efl/fast/table/table-hspace-align-center-expected.txt:
- platform/efl/fast/table/table-row-after-child-in-block-expected.txt:
- platform/efl/fast/table/table-row-after-child-in-table-expected.txt:
- platform/efl/fast/table/table-row-before-child-in-block-expected.txt:
- platform/efl/fast/table/table-row-before-child-in-table-expected.txt:
- platform/efl/fast/table/tableInsideCaption-expected.txt:
- platform/efl/fast/table/text-field-baseline-expected.txt:
- platform/efl/fast/table/unbreakable-images-quirk-expected.txt:
- platform/efl/fast/table/vertical-align-baseline-expected.txt:
- platform/efl/fast/text/basic/001-expected.txt:
- platform/efl/fast/text/basic/006-expected.txt:
- platform/efl/fast/text/basic/007-expected.txt:
- platform/efl/fast/text/capitalize-boundaries-expected.txt:
- platform/efl/fast/text/hyphenate-locale-expected.txt:
- platform/efl/fast/text/international/bidi-layout-across-linebreak-expected.txt:
- platform/efl/fast/text/whitespace/024-expected.txt:
- platform/efl/fast/text/whitespace/027-expected.txt:
- platform/efl/fast/text/word-break-expected.txt:
- platform/efl/fast/transforms/transform-table-row-expected.txt:
- 3:04 AM Changeset in webkit [196062] by
-
- 3 edits in trunk/Source/WebKit2
[GTK] Reduce IPC traffic due to view state changes
https://bugs.webkit.org/show_bug.cgi?id=153745
Reviewed by Sergio Villar Senin.
Very often view state changes happen one after another in a very
short period of time, even in the same run loop iteration. For
example, when you switch to the web view window, the view is
focused and the active window flag changes as well. In that case
we are sending two messages to the web process and the page
updates its status according to the new flags in two steps. So, we
could group all state changes happening in the same run loop
iteration and notify about them all in the next iteration. This
also prevents unnecessary changes of state when we quickly go back
to a previous state, for example in focus follows mouse
configurations if you move the mouse outside the window and then
inside the window again quickly.
- UIProcess/API/gtk/WebKitWebViewBase.cpp:
(_WebKitWebViewBasePrivate::_WebKitWebViewBasePrivate): Use
VirewState::Flags to keep the web view state instead of
boolean, and also to keep the flags that need to be updated. Use a
timer to update web view state flags.
(_WebKitWebViewBasePrivate::updateViewStateTimerFired): Call
WebPageProxy::viewStateDidChange() and reset the flags that need
to be updated.
(webkitWebViewBaseScheduleUpdateViewState): Update the flags that
need to be updated and schedule the timer if it's not active.
(toplevelWindowFocusInEvent): Use the flags and schedule an update.
(toplevelWindowFocusOutEvent): Ditto.
(toplevelWindowStateEvent): Also mark the view as hidden when minimized.
(webkitWebViewBaseSetToplevelOnScreenWindow): Connect to
window-state-event instead of deprecated visibility-notify-event.
(webkitWebViewBaseMap): Use the flags and schedule an update.
(webkitWebViewBaseUnmap): Ditto.
(webkitWebViewBaseSetFocus): Ditto.
(webkitWebViewBaseIsInWindowActive): Use the flags.
(webkitWebViewBaseIsFocused): Ditto
(webkitWebViewBaseIsVisible): Ditto.
(webkitWebViewBaseIsInWindow): Removed this since it was unused.
- UIProcess/API/gtk/WebKitWebViewBasePrivate.h:
- 2:37 AM Changeset in webkit [196061] by
-
- 4 edits in trunk
[GTK] Layout Test http/tests/appcache/different-https-origin-resource-main.html is failing
https://bugs.webkit.org/show_bug.cgi?id=145253
Reviewed by Michael Catanzaro.
Source/WebCore:
The problem is that when the load is cancelled while the
connection is still being established,
SoupMessage::notify::tls-errors is emitted and the handler calls
ResourceHandleClient::didFail() which can delete the ResourceHandle.
- platform/network/soup/ResourceHandleSoup.cpp:
(WebCore::tlsErrorsChangedCallback): Protect the ResourceHandle
for the scope of the callback because
ResourceHandleClient::didFail() could delete the object.
LayoutTests:
Update test expectation.
- platform/gtk/TestExpectations:
- 2:31 AM Changeset in webkit [196060] by
-
- 4 edits in trunk
REGRESSION(r191948): [GStreamer] 4 new timeouts on layout tests.
https://bugs.webkit.org/show_bug.cgi?id=152797
Reviewed by Darin Adler.
Source/WebCore:
Always schedule messages to the main thread, even when the bus
sync handlder was called in the main thread. It seems that
GStreamer expects things to happen in the next main loop
iteration.
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::createGSTPlayBin):
LayoutTests:
Update test expectations.
- platform/gtk/TestExpectations:
- 1:56 AM Changeset in webkit [196059] by
-
- 2 edits in trunk/Source/WebKit2
Unreviewed. Fix incorrect ASSERT introduced in r196053.
- WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:
(WebKit::NetscapePluginX11::paint): Ensure the plugin is not
windowed if paint() is called.
- 1:54 AM Changeset in webkit [196058] by
-
- 3 edits in trunk/Source/WebCore
[TexMap] CompositingCoordinator should store the overlay layer, flush it as appropriate
https://bugs.webkit.org/show_bug.cgi?id=152058
Reviewed by Michael Catanzaro.
Previously, the CompositingCoordinator only added the overlay layer to the
layer tree, but flushing its compositing state is also required. For that to
happen, CompositingCoordinator has to store a pointer to the overlay layer
object and flush it in ::flushPendingLayerChanges().
Overlay layers are most prominently used by the Web Inspector to highlight
the DOM elements on the Web page that are being hovered in the inspector.
- platform/graphics/texmap/coordinated/CompositingCoordinator.cpp:
(WebCore::CompositingCoordinator::CompositingCoordinator):
(WebCore::CompositingCoordinator::setRootCompositingLayer):
(WebCore::CompositingCoordinator::flushPendingLayerChanges):
- platform/graphics/texmap/coordinated/CompositingCoordinator.h:
- 12:48 AM Changeset in webkit [196057] by
-
- 3 edits in trunk/Source/JavaScriptCore
Unreviewed. Fix JavaScriptCore build with B3 enabled.
Include <limits.h> for UINT_MAX.
- b3/B3StackSlot.h:
- b3/air/AirStackSlot.h:
- 12:41 AM Changeset in webkit [196056] by
-
- 3 edits in trunk/Source/WebCore
[CoordinatedGraphics] CompositingCoordinator destructor is scheduling layer flushes
https://bugs.webkit.org/show_bug.cgi?id=153823
Reviewed by Carlos Garcia Campos.
Purging the backing stores during the CompositingCoordinator destructor
is also scheduling layer flushes in the object's client, which is an object
of the LayerTreeHost-deriving class that owns the CompositingCoordinator
object in question and is also being destroyed.
In case of ThreadedCoordinatedLayerTreeHost, this scheduling can access
the RunLoop::Timer object which has already been destroyed, causing a
crash. Another problem with this is that we're invoking a virtual function
on an object that's being destructed, which works well enough in this case
but should be discouraged in general.
In order to avoid this, add the m_isDestructing boolean to the
CompositingCoordinator class, flip it to true during the destruction,
and check for its falseness before scheduling a layer flush.
- platform/graphics/texmap/coordinated/CompositingCoordinator.cpp:
(WebCore::CompositingCoordinator::CompositingCoordinator):
(WebCore::CompositingCoordinator::~CompositingCoordinator):
(WebCore::CompositingCoordinator::notifyFlushRequired):
- platform/graphics/texmap/coordinated/CompositingCoordinator.h:
- 12:34 AM Changeset in webkit [196055] by
-
- 2 edits in trunk/Source/WebCore
[TexMap] Don't use RELEASE_ASSERT in TextureMapperLayer::computeTransformsRecursive()
https://bugs.webkit.org/show_bug.cgi?id=153822
Reviewed by Carlos Garcia Campos.
- platform/graphics/texmap/TextureMapperLayer.cpp:
(WebCore::TextureMapperLayer::computeTransformsRecursive):
Use ASSERT to check that the m_children members are indeed children
of the current layer, RELEASE_ASSERT probably slipped in unnoticed
at some point.
- 12:33 AM Changeset in webkit [196054] by
-
- 2 edits in trunk/Source/WebCore
PlatformPathCairo: Lazily allocate the path surface
https://bugs.webkit.org/show_bug.cgi?id=153821
Reviewed by Carlos Garcia Campos.
Move the static variable that holds the Cairo surface into
the pathSurface() function (previously getPathSurface). This
way the surface will only be allocated once the function is
called for the first time from the CairoPath surface.
No change in functionality, just a cleanup.
- platform/graphics/cairo/PlatformPathCairo.cpp:
(WebCore::pathSurface):
(WebCore::CairoPath::CairoPath):
(WebCore::getPathSurface): Deleted.
- 12:18 AM Changeset in webkit [196053] by
-
- 9 edits3 adds in trunk/Source/WebKit2
[UNIX] Add support for windowless NPAPI plugins with no UI in non X11 platforms
https://bugs.webkit.org/show_bug.cgi?id=151992
Reviewed by Darin Adler.
We are currently disabling all plugins when running under wayland,
for example. There are some plugins, like the one used by
extensions.gnome.org, that don't do any rendering, so there's not
reason not to support those plugins under wayland or any other
unix non-x11 platform.
X11 specific code has been moved to a new class NetscapePluginX11,
only used under X11. The common code is in NetscapePluginUnix.cpp
that will use the X11 implementatin only when needed and
available. For windowed plugins we will fail the initialization
under non-X11 plaforms, while for windowless plugins we will just
return early from paint method.
- PlatformEfl.cmake: Add new files to compilation.
- PlatformGTK.cmake: Ditto.
- UIProcess/API/gtk/WebKitSettings.cpp:
(webkit_settings_set_enable_plugins): Do not disable plugins in wayland.
- UIProcess/gtk/WebPreferencesGtk.cpp:
(WebKit::WebPreferences::platformInitializeStore): Ditto.
- WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:
(WebKit::NPN_GetValue): Use PlatformDisplay instead of
NetscapePlugin::x11HostDisplay() and don't claim to support X11
specific features under non-x11 platforms.
- WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
(WebKit::NetscapePlugin::NetscapePlugin): Remove X11 and GTK
specific memebers that are now moved to a dedicated class NetscapePluginX11.
- WebProcess/Plugins/Netscape/NetscapePlugin.h:
(WebKit::NetscapePlugin::frameRectInWindowCoordinates): Make this public.
(WebKit::NetscapePlugin::clipRect): Add getter.
(WebKit::NetscapePlugin::size): Ditto.
(WebKit::NetscapePlugin::isWindowed): Ditto.
(WebKit::NetscapePlugin::isVisible): Ditto.
- WebProcess/Plugins/Netscape/unix/NetscapePluginUnix.cpp: Added.
(WebKit::NetscapePlugin::platformPreInitialize):
(WebKit::NetscapePlugin::platformPostInitialize):
(WebKit::NetscapePlugin::platformDestroy):
(WebKit::NetscapePlugin::platformInvalidate):
(WebKit::NetscapePlugin::platformGeometryDidChange):
(WebKit::NetscapePlugin::platformVisibilityDidChange):
(WebKit::NetscapePlugin::platformPaint):
(WebKit::NetscapePlugin::platformHandleMouseEvent):
(WebKit::NetscapePlugin::platformHandleWheelEvent):
(WebKit::NetscapePlugin::platformSetFocus):
(WebKit::NetscapePlugin::wantsPluginRelativeNPWindowCoordinates):
(WebKit::NetscapePlugin::platformHandleMouseEnterEvent):
(WebKit::NetscapePlugin::platformHandleMouseLeaveEvent):
(WebKit::NetscapePlugin::platformHandleKeyboardEvent):
- WebProcess/Plugins/Netscape/unix/NetscapePluginUnix.h: Added.
(WebKit::NetscapePluginUnix::~NetscapePluginUnix):
- WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:
(WebKit::getPluginDisplay):
(WebKit::displayDepth):
(WebKit::x11HostDisplay):
(WebKit::NetscapePluginX11::create):
(WebKit::NetscapePluginX11::NetscapePluginX11):
(WebKit::NetscapePluginX11::~NetscapePluginX11):
(WebKit::NetscapePluginX11::windowType):
(WebKit::NetscapePluginX11::window):
(WebKit::NetscapePluginX11::geometryDidChange):
(WebKit::NetscapePluginX11::visibilityDidChange):
(WebKit::NetscapePluginX11::paint):
(WebKit::initializeXEvent):
(WebKit::NetscapePluginX11::handleMouseEvent):
(WebKit::NetscapePluginX11::handleWheelEvent):
(WebKit::NetscapePluginX11::setFocus):
(WebKit::NetscapePluginX11::handleMouseEnterEvent):
(WebKit::NetscapePluginX11::handleMouseLeaveEvent):
(WebKit::NetscapePluginX11::handleKeyboardEvent):
(WebKit::setCommonMouseEventFields): Deleted.
(WebKit::setXKeyEventFields): Deleted.
- WebProcess/Plugins/Netscape/x11/NetscapePluginX11.h: Added.
Feb 2, 2016:
- 11:01 PM Changeset in webkit [196052] by
-
- 3 edits2 adds in trunk
ASSERTION FAILED: roundedIntPoint(rendererMappedResult) == roundedIntPoint(result)
https://bugs.webkit.org/show_bug.cgi?id=153576
Patch by Fujii Hironori <Hironori.Fujii@jp.sony.com> on 2016-02-02
Reviewed by Darin Adler.
Source/WebCore:
Tests: fast/block/geometry-map-assertion-with-rounding-negative-half.html
The results of roundedIntPoint of FloatPoint and LayoutPoint may be different
because of the uniqueness of LayoutUnit::round introduced by this bug
<https://bugs.webkit.org/show_bug.cgi?id=107208>.
Should convert a FloatPoint to a LayoutPoint before rounding.
- rendering/RenderGeometryMap.cpp:
(WebCore::RenderGeometryMap::mapToContainer):
LayoutTests:
- fast/block/geometry-map-assertion-with-rounding-negative-half-expected.txt: Added.
- fast/block/geometry-map-assertion-with-rounding-negative-half.html: Added.
- 10:34 PM Changeset in webkit [196051] by
-
- 3 edits1 add in trunk/Source/JavaScriptCore
JSSymbolTableObject::deleteProperty() crashes deleting Symbols
https://bugs.webkit.org/show_bug.cgi?id=153816
Patch by Caitlin Potter <caitp@igalia.com> on 2016-02-02
Reviewed by Darin Adler.
Changes JSSymbolTableObject::deleteProperty() to check if its
symbolTable() contains the property's uid() rather than publicName().
This ensures that it will not crash in the case of Symbols.
- runtime/JSSymbolTableObject.cpp:
(JSC::JSSymbolTableObject::deleteProperty):
- tests/es6/Object_static_methods_Object.getOwnPropertyDescriptors.js:
(testGlobalProxy):
- tests/stress/regress-153816.js: Added.
(deleteSymbolFromJSSymbolTableObject):
- 10:31 PM Changeset in webkit [196050] by
-
- 5 edits in tags/Safari-602.1.18.3/Source
Versioning.
- 10:28 PM Changeset in webkit [196049] by
-
- 1 copy in tags/Safari-602.1.18.3
New tag.
- 10:14 PM Changeset in webkit [196048] by
-
- 6 edits in trunk/Tools
Better fix for Layout Test fast/parser/external-entities-in-xslt.xml is flaky on El Capitan (but fails most of the time)
https://bugs.webkit.org/show_bug.cgi?id=153683
Reviewed by Darin Adler.
- Scripts/webkitpy/port/driver.py:
(Driver._setup_environ_for_driver): Reverted change from r196013. DUMPRENDERTREE_TEMP is not
used by any code in the Web Content process. If that ever changed, we should send it over
as a bundle parameter.
- Scripts/webkitpy/port/ios.py:
(IOSSimulatorPort.setup_environ_for_server): Reverted change from r196013.
- Scripts/webkitpy/port/mac.py:
(MacPort.setup_environ_for_server): Ditto.
- WebKitTestRunner/InjectedBundle/ios/InjectedBundleIOS.mm:
(WTR::InjectedBundle::platformInitialize): Set XML_CATALOG_FILES in the Web Process
environment. This is early enough that libxml2 has not been initialized yet.
- WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
(WTR::InjectedBundle::platformInitialize): Ditto.
- 10:06 PM Changeset in webkit [196047] by
-
- 2 edits in trunk/LayoutTests
Follow up for:
Cut down on calls to String::lower; mostly replace with convertToASCIILowercase
https://bugs.webkit.org/show_bug.cgi?id=153732
- fast/viewport/viewport-warnings-7-expected.txt: Updated expected results now that
viewport parsing doesn't lowercase the string to parse it.
- 10:02 PM Changeset in webkit [196046] by
-
- 2 edits in trunk/Source/WebKit2
Remove ENABLE(GLOBAL_FASTMALLOC_NEW) guard in WebMemorySamplerLinux.cpp
https://bugs.webkit.org/show_bug.cgi?id=153812
Reviewed by Darin Adler.
r164261 already removed ENABLE_GLOBAL_FASTMALLOC_NEW guard though, WebMemorySamplerLinux
is still using it. That's why EFL and GTK memory sampler don't show fast malloc memory use.
- Shared/linux/WebMemorySamplerLinux.cpp:
(WebKit::WebMemorySampler::sampleWebKit): Deleted.
- 9:03 PM Changeset in webkit [196045] by
-
- 2 edits in trunk/Source/JavaScriptCore
[JSC] Do not copy FP when lowering FramePointer
https://bugs.webkit.org/show_bug.cgi?id=153769
Reviewed by Michael Saboff.
That extra move is just wasted time. The fewer Moves we have,
the happier IRC is.
- b3/B3LowerToAir.cpp:
(JSC::B3::Air::LowerToAir::tmp):
(JSC::B3::Air::LowerToAir::lower):
- 8:53 PM Changeset in webkit [196044] by
-
- 12 edits in trunk/Source/JavaScriptCore
DFG, FTL, B3, and Air should all have a unique option for printing their graphs
https://bugs.webkit.org/show_bug.cgi?id=153815
Reviewed by Benjamin Poulain.
This patch adds a new printing option for each of the DFG/FTL compilation phases.
- b3/B3Common.cpp:
(JSC::B3::shouldDumpIR):
(JSC::B3::shouldDumpIRAtEachPhase):
- b3/B3Common.h:
- b3/B3Generate.cpp:
(JSC::B3::generateToAir):
- b3/B3PhaseScope.cpp:
(JSC::B3::PhaseScope::PhaseScope):
- b3/air/AirGenerate.cpp:
(JSC::B3::Air::prepareForGeneration):
- b3/air/AirPhaseScope.cpp:
(JSC::B3::Air::PhaseScope::PhaseScope):
- dfg/DFGCFAPhase.cpp:
(JSC::DFG::CFAPhase::run):
- dfg/DFGCommon.h:
(JSC::DFG::shouldDumpGraphAtEachPhase):
- dfg/DFGPhase.cpp:
(JSC::DFG::Phase::beginPhase):
- runtime/Options.cpp:
(JSC::recomputeDependentOptions):
- runtime/Options.h:
- 8:32 PM Changeset in webkit [196043] by
-
- 630 edits in trunk/LayoutTests
Unreviewed. EFL gardening: rebaseline tests after r195740.
- platform/efl/fast/replaced/005-expected.txt:
- platform/efl/fast/replaced/percent-height-in-anonymous-block-in-table-expected.txt:
- platform/efl/fast/replaced/selection-rect-in-table-cell-expected.txt:
- platform/efl/fast/replaced/table-percent-height-positioned-expected.txt:
- platform/efl/fast/replaced/width100percent-checkbox-expected.txt:
- platform/efl/fast/replaced/width100percent-image-expected.txt:
- platform/efl/fast/replaced/width100percent-menulist-expected.txt:
- platform/efl/fast/replaced/width100percent-radio-expected.txt:
- platform/efl/fast/replaced/width100percent-searchfield-expected.txt:
- platform/efl/fast/replaced/width100percent-textarea-expected.txt:
- platform/efl/fast/replaced/width100percent-textfield-expected.txt:
- platform/efl/fast/selectors/077-expected.txt:
- platform/efl/fast/selectors/077b-expected.txt:
- platform/efl/fast/table/002-expected.txt:
- platform/efl/fast/table/003-expected.txt:
- platform/efl/fast/table/005-expected.txt:
- platform/efl/fast/table/007-expected.txt:
- platform/efl/fast/table/008-expected.txt:
- platform/efl/fast/table/009-expected.txt:
- platform/efl/fast/table/012-expected.txt:
- platform/efl/fast/table/013-expected.txt:
- platform/efl/fast/table/021-expected.txt:
- platform/efl/fast/table/023-expected.txt:
- platform/efl/fast/table/024-expected.txt:
- platform/efl/fast/table/025-expected.txt:
- platform/efl/fast/table/028-expected.txt:
- platform/efl/fast/table/028-vertical-expected.txt:
- platform/efl/fast/table/029-expected.txt:
- platform/efl/fast/table/031-expected.txt:
- platform/efl/fast/table/032-expected.txt:
- platform/efl/fast/table/034-expected.txt:
- platform/efl/fast/table/038-expected.txt:
- platform/efl/fast/table/038-vertical-expected.txt:
- platform/efl/fast/table/039-expected.txt:
- platform/efl/fast/table/040-expected.txt:
- platform/efl/fast/table/040-vertical-expected.txt:
- platform/efl/fast/table/100-percent-cell-width-expected.txt:
- platform/efl/fast/table/add-before-anonymous-child-expected.txt:
- platform/efl/fast/table/border-collapsing/001-expected.txt:
- platform/efl/fast/table/border-collapsing/001-vertical-expected.txt:
- platform/efl/fast/table/border-collapsing/002-expected.txt:
- platform/efl/fast/table/border-collapsing/003-expected.txt:
- platform/efl/fast/table/border-collapsing/003-vertical-expected.txt:
- platform/efl/fast/table/border-collapsing/004-expected.txt:
- platform/efl/fast/table/border-collapsing/004-vertical-expected.txt:
- platform/efl/fast/table/border-collapsing/border-collapsing-head-foot-expected.txt:
- platform/efl/fast/table/border-collapsing/border-collapsing-head-foot-vertical-expected.txt:
- platform/efl/fast/table/border-collapsing/bug14274-expected.txt:
- platform/efl/fast/table/border-collapsing/cached-69296-expected.txt:
- platform/efl/fast/table/border-collapsing/cached-cell-append-expected.txt:
- platform/efl/fast/table/border-collapsing/cached-cell-remove-expected.txt:
- platform/efl/fast/table/border-collapsing/cached-change-cell-border-color-expected.txt:
- platform/efl/fast/table/border-collapsing/cached-change-cell-border-width-expected.txt:
- platform/efl/fast/table/border-collapsing/cached-change-cell-sl-border-color-expected.txt:
- platform/efl/fast/table/border-collapsing/cached-change-col-border-color-expected.txt:
- platform/efl/fast/table/border-collapsing/cached-change-col-border-width-expected.txt:
- platform/efl/fast/table/border-collapsing/cached-change-colgroup-border-color-expected.txt:
- platform/efl/fast/table/border-collapsing/cached-change-colgroup-border-width-expected.txt:
- platform/efl/fast/table/border-collapsing/cached-change-row-border-color-expected.txt:
- platform/efl/fast/table/border-collapsing/cached-change-row-border-width-expected.txt:
- platform/efl/fast/table/border-collapsing/cached-change-table-border-color-expected.txt:
- platform/efl/fast/table/border-collapsing/cached-change-table-border-width-expected.txt:
- platform/efl/fast/table/border-collapsing/cached-change-tbody-border-color-expected.txt:
- platform/efl/fast/table/border-collapsing/collapsed-borders-adjoining-sections-vertical-rl-expected.txt:
- platform/efl/fast/table/border-collapsing/collapsed-borders-painted-once-on-inner-cells-expected.txt:
- platform/efl/fast/table/border-collapsing/equal-precedence-resolution-expected.txt:
- platform/efl/fast/table/border-collapsing/equal-precedence-resolution-vertical-expected.txt:
- platform/efl/fast/table/border-collapsing/rtl-border-collapsing-expected.txt:
- platform/efl/fast/table/border-collapsing/rtl-border-collapsing-vertical-expected.txt:
- platform/efl/fast/table/caption-relayout-expected.txt:
- platform/efl/fast/table/cell-absolute-child-expected.txt:
- platform/efl/fast/table/cell-width-auto-expected.txt:
- platform/efl/fast/table/colspan-with-all-percent-cells-expected.txt:
- platform/efl/fast/table/colspanMinWidth-expected.txt:
- platform/efl/fast/table/colspanMinWidth-vertical-expected.txt:
- platform/efl/fast/table/dynamic-cellpadding-expected.txt:
- platform/efl/fast/table/edge-offsets-expected.txt:
- platform/efl/fast/table/empty-cells-expected.txt:
- platform/efl/fast/table/frame-and-rules-expected.txt:
- platform/efl/fast/table/giantRowspan-expected.txt:
- platform/efl/fast/table/growCellForImageQuirk-expected.txt:
- platform/efl/fast/table/growCellForImageQuirk-vertical-expected.txt:
- platform/efl/fast/table/height-percent-test-expected.txt:
- platform/efl/fast/table/height-percent-test-vertical-expected.txt:
- platform/efl/fast/table/invisible-cell-background-expected.txt:
- platform/efl/fast/table/large-width-expected.txt:
- platform/efl/fast/table/max-width-integer-overflow-expected.txt:
- platform/efl/fast/table/mozilla-bug10296-vertical-align-1-expected.txt:
- platform/efl/fast/table/mozilla-bug10296-vertical-align-2-expected.txt:
- platform/efl/fast/table/nobr-expected.txt:
- platform/efl/fast/table/overflowHidden-expected.txt:
- platform/efl/fast/table/percent-heights-expected.txt:
- platform/efl/fast/table/percent-widths-stretch-expected.txt:
- platform/efl/fast/table/percent-widths-stretch-vertical-expected.txt:
- platform/efl/fast/table/prepend-in-anonymous-table-expected.txt:
- platform/efl/fast/table/relative-position-containment-expected.txt:
- platform/efl/fast/table/relative-position-offsets-expected.txt:
- platform/efl/fast/table/relative-position-stacking-expected.txt:
- platform/efl/fast/table/replaced-percent-height-expected.txt:
- platform/efl/fast/table/row-height-recalc-expected.txt:
- platform/efl/fast/table/rowspan-paint-order-expected.txt:
- platform/efl/fast/table/rowspan-paint-order-vertical-expected.txt:
- platform/efl/fast/table/simple_paint-expected.txt:
- platform/efl/fast/table/spanOverlapRepaint-expected.txt:
- platform/efl/fast/table/stale-grid-crash-expected.txt:
- platform/efl/fast/table/table-anonymous-cell-bug-expected.txt:
- platform/efl/fast/table/table-anonymous-row-bug-expected.txt:
- platform/efl/fast/table/table-anonymous-section-bug-expected.txt:
- platform/efl/fast/table/table-before-child-style-update-expected.txt:
- platform/efl/fast/table/table-cell-before-after-content-around-table-block-expected.txt:
- platform/efl/fast/table/table-cell-before-after-content-around-table-expected.txt:
- platform/efl/fast/table/table-cell-before-after-content-around-table-row-expected.txt:
- platform/efl/fast/table/table-cell-before-child-in-table-expected.txt:
- platform/efl/fast/table/table-cell-split-expected.txt:
- platform/efl/fast/table/table-display-types-expected.txt:
- platform/efl/fast/table/table-display-types-strict-expected.txt:
- platform/efl/fast/table/table-display-types-vertical-expected.txt:
- platform/efl/fast/table/table-insert-before-non-anonymous-block-expected.txt:
- platform/efl/fast/table/table-row-before-after-content-around-block-expected.txt:
- platform/efl/fast/table/table-row-before-after-content-around-table-cell-expected.txt:
- platform/efl/fast/table/table-row-before-after-content-around-table-expected.txt:
- platform/efl/fast/table/table-row-before-child-style-update-expected.txt:
- platform/efl/fast/table/table-row-outline-paint-expected.txt:
- platform/efl/fast/table/table-row-split2-expected.txt:
- platform/efl/fast/table/table-row-style-not-updated-expected.txt:
- platform/efl/fast/table/table-row-style-not-updated-with-after-content-expected.txt:
- platform/efl/fast/table/table-row-style-not-updated-with-before-content-expected.txt:
- platform/efl/fast/table/table-section-split2-expected.txt:
- platform/efl/fast/table/table-split-expected.txt:
- platform/efl/fast/table/table-split2-expected.txt:
- platform/efl/fast/table/table-style-not-updated-expected.txt:
- platform/efl/fast/table/wide-colspan-expected.txt:
- platform/efl/fast/table/wide-column-expected.txt:
- platform/efl/fast/text/atsui-negative-spacing-features-expected.txt:
- platform/efl/fast/text/atsui-spacing-features-expected.txt:
- platform/efl/fast/text/basic/generic-family-reset-expected.txt:
- platform/efl/fast/text/international/003-expected.txt:
- platform/efl/fast/text/international/bidi-LDB-2-CSS-expected.txt:
- platform/efl/fast/text/international/bidi-LDB-2-HTML-expected.txt:
- platform/efl/fast/text/international/bidi-LDB-2-formatting-characters-expected.txt:
- platform/efl/fast/text/international/bidi-override-expected.txt:
- platform/efl/fast/text/wbr-expected.txt:
- platform/efl/fast/text/whitespace/002-expected.txt:
- platform/efl/fast/text/whitespace/003-expected.txt:
- platform/efl/fast/text/whitespace/004-expected.txt:
- platform/efl/fast/text/whitespace/005-expected.txt:
- platform/efl/fast/text/whitespace/010-expected.txt:
- platform/efl/fast/text/whitespace/011-expected.txt:
- platform/efl/fast/text/whitespace/013-expected.txt:
- platform/efl/fast/text/whitespace/014-expected.txt:
- platform/efl/fast/text/whitespace/015-expected.txt:
- platform/efl/fast/text/whitespace/016-expected.txt:
- platform/efl/fast/text/whitespace/025-expected.txt:
- platform/efl/fast/text/whitespace/026-expected.txt:
- platform/efl/fast/writing-mode/table-percent-width-quirk-expected.txt:
- platform/efl/fast/writing-mode/vertical-align-table-baseline-expected.txt:
- platform/efl/http/tests/misc/acid2-expected.txt:
- platform/efl/ietestcenter/css3/bordersbackgrounds/background_properties_greater_than_images-expected.txt:
- platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-006-expected.txt:
- platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-007-expected.txt:
- platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-008-expected.txt:
- platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-009-expected.txt:
- platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-011-expected.txt:
- platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-012-expected.txt:
- platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-013-expected.txt:
- platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-014-expected.txt:
- platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-015-expected.txt:
- platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-016-expected.txt:
- platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-different-width-001-expected.txt:
- platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-shorthand-001-expected.txt:
- platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-001-expected.txt:
- platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-002-expected.txt:
- platform/efl/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-004-expected.txt:
- platform/efl/ietestcenter/css3/bordersbackgrounds/border-top-right-radius-values-004-expected.txt:
- platform/efl/ietestcenter/css3/bordersbackgrounds/none-as-image-layer-expected.txt:
- platform/efl/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.txt:
- platform/efl/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.txt:
- platform/efl/tables/layering/paint-test-layering-1-expected.txt:
- platform/efl/tables/layering/paint-test-layering-2-expected.txt:
- platform/efl/tables/mozilla/bugs/bug10009-expected.txt:
- platform/efl/tables/mozilla/bugs/bug10036-expected.txt:
- platform/efl/tables/mozilla/bugs/bug101201-expected.txt:
- platform/efl/tables/mozilla/bugs/bug101674-expected.txt:
- platform/efl/tables/mozilla/bugs/bug10296-1-expected.txt:
- platform/efl/tables/mozilla/bugs/bug1055-1-expected.txt:
- platform/efl/tables/mozilla/bugs/bug10565-expected.txt:
- platform/efl/tables/mozilla/bugs/bug10633-expected.txt:
- platform/efl/tables/mozilla/bugs/bug1067-1-expected.txt:
- platform/efl/tables/mozilla/bugs/bug1067-2-expected.txt:
- platform/efl/tables/mozilla/bugs/bug106795-expected.txt:
- platform/efl/tables/mozilla/bugs/bug106816-expected.txt:
- platform/efl/tables/mozilla/bugs/bug113235-1-expected.txt:
- platform/efl/tables/mozilla/bugs/bug113424-expected.txt:
- platform/efl/tables/mozilla/bugs/bug1163-1-expected.txt:
- platform/efl/tables/mozilla/bugs/bug1188-expected.txt:
- platform/efl/tables/mozilla/bugs/bug12008-expected.txt:
- platform/efl/tables/mozilla/bugs/bug120107-expected.txt:
- platform/efl/tables/mozilla/bugs/bug120364-expected.txt:
- platform/efl/tables/mozilla/bugs/bug1224-expected.txt:
- platform/efl/tables/mozilla/bugs/bug12268-expected.txt:
- platform/efl/tables/mozilla/bugs/bug12709-expected.txt:
- platform/efl/tables/mozilla/bugs/bug1271-expected.txt:
- platform/efl/tables/mozilla/bugs/bug12908-1-expected.txt:
- platform/efl/tables/mozilla/bugs/bug12908-2-expected.txt:
- platform/efl/tables/mozilla/bugs/bug1296-expected.txt:
- platform/efl/tables/mozilla/bugs/bug1302-expected.txt:
- platform/efl/tables/mozilla/bugs/bug13169-expected.txt:
- platform/efl/tables/mozilla/bugs/bug1318-expected.txt:
- platform/efl/tables/mozilla/bugs/bug137388-1-expected.txt:
- platform/efl/tables/mozilla/bugs/bug137388-2-expected.txt:
- platform/efl/tables/mozilla/bugs/bug137388-3-expected.txt:
- platform/efl/tables/mozilla/bugs/bug139524-1-expected.txt:
- platform/efl/tables/mozilla/bugs/bug139524-2-expected.txt:
- platform/efl/tables/mozilla/bugs/bug139524-3-expected.txt:
- platform/efl/tables/mozilla/bugs/bug139524-4-expected.txt:
- platform/efl/tables/mozilla/bugs/bug1430-expected.txt:
- platform/efl/tables/mozilla/bugs/bug14323-expected.txt:
- platform/efl/tables/mozilla/bugs/bug14929-expected.txt:
- platform/efl/tables/mozilla/bugs/bug15247-expected.txt:
- platform/efl/tables/mozilla/bugs/bug154780-expected.txt:
- platform/efl/tables/mozilla/bugs/bug15544-expected.txt:
- platform/efl/tables/mozilla/bugs/bug159108-expected.txt:
- platform/efl/tables/mozilla/bugs/bug15933-expected.txt:
- platform/efl/tables/mozilla/bugs/bug16012-expected.txt:
- platform/efl/tables/mozilla/bugs/bug16252-expected.txt:
- platform/efl/tables/mozilla/bugs/bug17138-expected.txt:
- platform/efl/tables/mozilla/bugs/bug175455-4-expected.txt:
- platform/efl/tables/mozilla/bugs/bug17548-expected.txt:
- platform/efl/tables/mozilla/bugs/bug17587-expected.txt:
- platform/efl/tables/mozilla/bugs/bug1800-expected.txt:
- platform/efl/tables/mozilla/bugs/bug1802-expected.txt:
- platform/efl/tables/mozilla/bugs/bug1802s-expected.txt:
- platform/efl/tables/mozilla/bugs/bug1809-expected.txt:
- platform/efl/tables/mozilla/bugs/bug18440-expected.txt:
- platform/efl/tables/mozilla/bugs/bug18664-expected.txt:
- platform/efl/tables/mozilla/bugs/bug18955-expected.txt:
- platform/efl/tables/mozilla/bugs/bug19061-1-expected.txt:
- platform/efl/tables/mozilla/bugs/bug19061-2-expected.txt:
- platform/efl/tables/mozilla/bugs/bug19356-expected.txt:
- platform/efl/tables/mozilla/bugs/bug20804-expected.txt:
- platform/efl/tables/mozilla/bugs/bug2123-expected.txt:
- platform/efl/tables/mozilla/bugs/bug215629-expected.txt:
- platform/efl/tables/mozilla/bugs/bug219693-1-expected.txt:
- platform/efl/tables/mozilla/bugs/bug219693-2-expected.txt:
- platform/efl/tables/mozilla/bugs/bug22019-expected.txt:
- platform/efl/tables/mozilla/bugs/bug220536-expected.txt:
- platform/efl/tables/mozilla/bugs/bug222336-expected.txt:
- platform/efl/tables/mozilla/bugs/bug22246-3-expected.txt:
- platform/efl/tables/mozilla/bugs/bug22246-3a-expected.txt:
- platform/efl/tables/mozilla/bugs/bug22513-expected.txt:
- platform/efl/tables/mozilla/bugs/bug2296-expected.txt:
- platform/efl/tables/mozilla/bugs/bug23235-expected.txt:
- platform/efl/tables/mozilla/bugs/bug24200-expected.txt:
- platform/efl/tables/mozilla/bugs/bug2479-2-expected.txt:
- platform/efl/tables/mozilla/bugs/bug2479-3-expected.txt:
- platform/efl/tables/mozilla/bugs/bug25004-expected.txt:
- platform/efl/tables/mozilla/bugs/bug25074-expected.txt:
- platform/efl/tables/mozilla/bugs/bug25663-expected.txt:
- platform/efl/tables/mozilla/bugs/bug26553-expected.txt:
- platform/efl/tables/mozilla/bugs/bug2684-expected.txt:
- platform/efl/tables/mozilla/bugs/bug269566-expected.txt:
- platform/efl/tables/mozilla/bugs/bug277062-expected.txt:
- platform/efl/tables/mozilla/bugs/bug2773-expected.txt:
- platform/efl/tables/mozilla/bugs/bug27993-1-expected.txt:
- platform/efl/tables/mozilla/bugs/bug2886-expected.txt:
- platform/efl/tables/mozilla/bugs/bug28933-expected.txt:
- platform/efl/tables/mozilla/bugs/bug29058-1-expected.txt:
- platform/efl/tables/mozilla/bugs/bug29314-expected.txt:
- platform/efl/tables/mozilla/bugs/bug29429-expected.txt:
- platform/efl/tables/mozilla/bugs/bug2954-expected.txt:
- platform/efl/tables/mozilla/bugs/bug2981-1-expected.txt:
- platform/efl/tables/mozilla/bugs/bug2981-2-expected.txt:
- platform/efl/tables/mozilla/bugs/bug2997-expected.txt:
- platform/efl/tables/mozilla/bugs/bug30273-expected.txt:
- platform/efl/tables/mozilla/bugs/bug30559-expected.txt:
- platform/efl/tables/mozilla/bugs/bug3103-expected.txt:
- platform/efl/tables/mozilla/bugs/bug32205-3-expected.txt:
- platform/efl/tables/mozilla/bugs/bug3260-expected.txt:
- platform/efl/tables/mozilla/bugs/bug33137-expected.txt:
- platform/efl/tables/mozilla/bugs/bug33855-expected.txt:
- platform/efl/tables/mozilla/bugs/bug3454-expected.txt:
- platform/efl/tables/mozilla/bugs/bug38916-expected.txt:
- platform/efl/tables/mozilla/bugs/bug3977-expected.txt:
- platform/efl/tables/mozilla/bugs/bug4093-expected.txt:
- platform/efl/tables/mozilla/bugs/bug42187-expected.txt:
- platform/efl/tables/mozilla/bugs/bug4385-expected.txt:
- platform/efl/tables/mozilla/bugs/bug4427-expected.txt:
- platform/efl/tables/mozilla/bugs/bug44505-expected.txt:
- platform/efl/tables/mozilla/bugs/bug4501-expected.txt:
- platform/efl/tables/mozilla/bugs/bug4527-expected.txt:
- platform/efl/tables/mozilla/bugs/bug45350-expected.txt:
- platform/efl/tables/mozilla/bugs/bug45486-expected.txt:
- platform/efl/tables/mozilla/bugs/bug4576-expected.txt:
- platform/efl/tables/mozilla/bugs/bug46268-1-expected.txt:
- platform/efl/tables/mozilla/bugs/bug46268-2-expected.txt:
- platform/efl/tables/mozilla/bugs/bug46368-1-expected.txt:
- platform/efl/tables/mozilla/bugs/bug46623-1-expected.txt:
- platform/efl/tables/mozilla/bugs/bug46623-2-expected.txt:
- platform/efl/tables/mozilla/bugs/bug47432-expected.txt:
- platform/efl/tables/mozilla/bugs/bug4803-expected.txt:
- platform/efl/tables/mozilla/bugs/bug4849-2-expected.txt:
- platform/efl/tables/mozilla/bugs/bug4849-expected.txt:
- platform/efl/tables/mozilla/bugs/bug51727-expected.txt:
- platform/efl/tables/mozilla/bugs/bug5188-expected.txt:
- platform/efl/tables/mozilla/bugs/bug52505-expected.txt:
- platform/efl/tables/mozilla/bugs/bug52506-expected.txt:
- platform/efl/tables/mozilla/bugs/bug53690-1-expected.txt:
- platform/efl/tables/mozilla/bugs/bug53690-2-expected.txt:
- platform/efl/tables/mozilla/bugs/bug53891-expected.txt:
- platform/efl/tables/mozilla/bugs/bug5538-expected.txt:
- platform/efl/tables/mozilla/bugs/bug55789-expected.txt:
- platform/efl/tables/mozilla/bugs/bug56201-expected.txt:
- platform/efl/tables/mozilla/bugs/bug57828-2-expected.txt:
- platform/efl/tables/mozilla/bugs/bug5797-expected.txt:
- platform/efl/tables/mozilla/bugs/bug5835-expected.txt:
- platform/efl/tables/mozilla/bugs/bug60804-expected.txt:
- platform/efl/tables/mozilla/bugs/bug60807-expected.txt:
- platform/efl/tables/mozilla/bugs/bug6184-expected.txt:
- platform/efl/tables/mozilla/bugs/bug6304-expected.txt:
- platform/efl/tables/mozilla/bugs/bug6404-expected.txt:
- platform/efl/tables/mozilla/bugs/bug647-expected.txt:
- platform/efl/tables/mozilla/bugs/bug6674-expected.txt:
- platform/efl/tables/mozilla/bugs/bug68998-expected.txt:
- platform/efl/tables/mozilla/bugs/bug69382-1-expected.txt:
- platform/efl/tables/mozilla/bugs/bug69382-2-expected.txt:
- platform/efl/tables/mozilla/bugs/bug72359-expected.txt:
- platform/efl/tables/mozilla/bugs/bug7342-expected.txt:
- platform/efl/tables/mozilla/bugs/bug7714-expected.txt:
- platform/efl/tables/mozilla/bugs/bug78162-expected.txt:
- platform/efl/tables/mozilla/bugs/bug82946-2-expected.txt:
- platform/efl/tables/mozilla/bugs/bug86708-expected.txt:
- platform/efl/tables/mozilla/bugs/bug8950-expected.txt:
- platform/efl/tables/mozilla/bugs/bug9123-1-expected.txt:
- platform/efl/tables/mozilla/bugs/bug9123-2-expected.txt:
- platform/efl/tables/mozilla/bugs/bug92143-expected.txt:
- platform/efl/tables/mozilla/bugs/bug92647-2-expected.txt:
- platform/efl/tables/mozilla/bugs/bug963-expected.txt:
- platform/efl/tables/mozilla/bugs/bug96334-expected.txt:
- platform/efl/tables/mozilla/bugs/bug97383-expected.txt:
- platform/efl/tables/mozilla/bugs/bug9879-1-expected.txt:
- platform/efl/tables/mozilla/collapsing_borders/bug41262-3-expected.txt:
- platform/efl/tables/mozilla/core/bloomberg-expected.txt:
- platform/efl/tables/mozilla/core/borders-expected.txt:
- platform/efl/tables/mozilla/core/cell_heights-expected.txt:
- platform/efl/tables/mozilla/core/col_span-expected.txt:
- platform/efl/tables/mozilla/core/col_widths_auto_autoFix-expected.txt:
- platform/efl/tables/mozilla/core/col_widths_auto_autoFixPer-expected.txt:
- platform/efl/tables/mozilla/core/col_widths_auto_fix-expected.txt:
- platform/efl/tables/mozilla/core/col_widths_auto_fixPer-expected.txt:
- platform/efl/tables/mozilla/core/col_widths_auto_per-expected.txt:
- platform/efl/tables/mozilla/core/col_widths_fix_autoFix-expected.txt:
- platform/efl/tables/mozilla/core/col_widths_fix_fix-expected.txt:
- platform/efl/tables/mozilla/core/col_widths_fix_fixPer-expected.txt:
- platform/efl/tables/mozilla/core/col_widths_fix_per-expected.txt:
- platform/efl/tables/mozilla/core/margins-expected.txt:
- platform/efl/tables/mozilla/core/misc-expected.txt:
- platform/efl/tables/mozilla/core/nested1-expected.txt:
- platform/efl/tables/mozilla/core/one_row-expected.txt:
- platform/efl/tables/mozilla/core/table_frame-expected.txt:
- platform/efl/tables/mozilla/core/table_heights-expected.txt:
- platform/efl/tables/mozilla/core/table_rules-expected.txt:
- platform/efl/tables/mozilla/core/table_widths-expected.txt:
- platform/efl/tables/mozilla/dom/insertColGroups1-expected.txt:
- platform/efl/tables/mozilla/dom/insertColGroups2-expected.txt:
- platform/efl/tables/mozilla/dom/insertCols1-expected.txt:
- platform/efl/tables/mozilla/dom/insertCols2-expected.txt:
- platform/efl/tables/mozilla/dom/insertCols3-expected.txt:
- platform/efl/tables/mozilla/dom/insertCols4-expected.txt:
- platform/efl/tables/mozilla/dom/insertCols5-expected.txt:
- platform/efl/tables/mozilla/marvin/backgr_layers-opacity-expected.txt:
- platform/efl/tables/mozilla/marvin/backgr_position-table-expected.txt:
- platform/efl/tables/mozilla/marvin/backgr_simple-table-cell-expected.txt:
- platform/efl/tables/mozilla/marvin/backgr_simple-table-column-expected.txt:
- platform/efl/tables/mozilla/marvin/backgr_simple-table-column-group-expected.txt:
- platform/efl/tables/mozilla/marvin/backgr_simple-table-expected.txt:
- platform/efl/tables/mozilla/marvin/backgr_simple-table-row-expected.txt:
- platform/efl/tables/mozilla/marvin/backgr_simple-table-row-group-expected.png:
- platform/efl/tables/mozilla/marvin/backgr_simple-table-row-group-expected.txt:
- platform/efl/tables/mozilla/marvin/colgroup_align_center-expected.txt:
- platform/efl/tables/mozilla/marvin/colgroup_align_justify-expected.txt:
- platform/efl/tables/mozilla/marvin/colgroup_align_left-expected.txt:
- platform/efl/tables/mozilla/marvin/colgroup_align_right-expected.txt:
- platform/efl/tables/mozilla/marvin/colgroup_span-expected.txt:
- platform/efl/tables/mozilla/marvin/colgroup_valign_baseline-expected.txt:
- platform/efl/tables/mozilla/marvin/colgroup_valign_bottom-expected.txt:
- platform/efl/tables/mozilla/marvin/colgroup_valign_middle-expected.txt:
- platform/efl/tables/mozilla/marvin/colgroup_valign_top-expected.txt:
- platform/efl/tables/mozilla/marvin/colgroup_width_pct-expected.txt:
- platform/efl/tables/mozilla/marvin/colgroup_width_px-expected.txt:
- platform/efl/tables/mozilla/marvin/table_overflow_hidden_td-expected.txt:
- platform/efl/tables/mozilla/marvin/table_overflow_td_dynamic_deactivate-expected.txt:
- platform/efl/tables/mozilla/marvin/table_row_align_center-expected.txt:
- platform/efl/tables/mozilla/marvin/table_row_align_left-expected.txt:
- platform/efl/tables/mozilla/marvin/table_row_align_right-expected.txt:
- platform/efl/tables/mozilla/marvin/table_rules_groups-expected.txt:
- platform/efl/tables/mozilla/marvin/tables_bgcolor_aqua-expected.txt:
- platform/efl/tables/mozilla/marvin/tables_bgcolor_aqua_rgb-expected.txt:
- platform/efl/tables/mozilla/marvin/tables_bgcolor_black-expected.txt:
- platform/efl/tables/mozilla/marvin/tables_bgcolor_black_rgb-expected.txt:
- platform/efl/tables/mozilla/marvin/tables_bgcolor_blue-expected.txt:
- platform/efl/tables/mozilla/marvin/tables_bgcolor_blue_rgb-expected.txt:
- platform/efl/tables/mozilla/marvin/tables_bgcolor_fuchsia-expected.txt:
- platform/efl/tables/mozilla/marvin/tables_bgcolor_fuchsia_rgb-expected.txt:
- platform/efl/tables/mozilla/marvin/tables_bgcolor_gray-expected.txt:
- platform/efl/tables/mozilla/marvin/tables_bgcolor_gray_rgb-expected.txt:
- platform/efl/tables/mozilla/marvin/tables_bgcolor_green-expected.txt:
- platform/efl/tables/mozilla/marvin/tables_bgcolor_green_rgb-expected.txt:
- platform/efl/tables/mozilla/marvin/tables_bgcolor_lime-expected.txt:
- platform/efl/tables/mozilla/marvin/tables_bgcolor_lime_rgb-expected.txt:
- platform/efl/tables/mozilla/marvin/tables_bgcolor_maroon-expected.txt:
- platform/efl/tables/mozilla/marvin/tables_bgcolor_maroon_rgb-expected.txt:
- platform/efl/tables/mozilla/marvin/tables_bgcolor_navy-expected.txt:
- platform/efl/tables/mozilla/marvin/tables_bgcolor_navy_rgb-expected.txt:
- platform/efl/tables/mozilla/marvin/tables_bgcolor_olive-expected.txt:
- platform/efl/tables/mozilla/marvin/tables_bgcolor_olive_rgb-expected.txt:
- platform/efl/tables/mozilla/marvin/tables_bgcolor_purple-expected.txt:
- platform/efl/tables/mozilla/marvin/tables_bgcolor_purple_rgb-expected.txt:
- platform/efl/tables/mozilla/marvin/tables_bgcolor_red-expected.txt:
- platform/efl/tables/mozilla/marvin/tables_bgcolor_red_rgb-expected.txt:
- platform/efl/tables/mozilla/marvin/tables_bgcolor_silver-expected.txt:
- platform/efl/tables/mozilla/marvin/tables_bgcolor_silver_rgb-expected.txt:
- platform/efl/tables/mozilla/marvin/tables_bgcolor_teal-expected.txt:
- platform/efl/tables/mozilla/marvin/tables_bgcolor_teal_rgb-expected.txt:
- platform/efl/tables/mozilla/marvin/tables_bgcolor_white-expected.txt:
- platform/efl/tables/mozilla/marvin/tables_bgcolor_white_rgb-expected.txt:
- platform/efl/tables/mozilla/marvin/tables_bgcolor_yellow-expected.txt:
- platform/efl/tables/mozilla/marvin/tables_bgcolor_yellow_rgb-expected.txt:
- platform/efl/tables/mozilla/marvin/tables_cellpadding-expected.txt:
- platform/efl/tables/mozilla/marvin/tables_cellpadding_pct-expected.txt:
- platform/efl/tables/mozilla/marvin/tables_td_width-expected.txt:
- platform/efl/tables/mozilla/marvin/tables_th_width-expected.txt:
- platform/efl/tables/mozilla/marvin/tables_width_percent-expected.txt:
- platform/efl/tables/mozilla/marvin/tables_width_px-expected.txt:
- platform/efl/tables/mozilla/marvin/tbody_valign_baseline-expected.txt:
- platform/efl/tables/mozilla/marvin/tbody_valign_bottom-expected.txt:
- platform/efl/tables/mozilla/marvin/tbody_valign_middle-expected.txt:
- platform/efl/tables/mozilla/marvin/tbody_valign_top-expected.txt:
- platform/efl/tables/mozilla/marvin/td_valign_baseline-expected.txt:
- platform/efl/tables/mozilla/marvin/td_valign_bottom-expected.txt:
- platform/efl/tables/mozilla/marvin/td_valign_middle-expected.txt:
- platform/efl/tables/mozilla/marvin/td_valign_top-expected.txt:
- platform/efl/tables/mozilla/marvin/tfoot_valign_baseline-expected.txt:
- platform/efl/tables/mozilla/marvin/tfoot_valign_bottom-expected.txt:
- platform/efl/tables/mozilla/marvin/tfoot_valign_middle-expected.txt:
- platform/efl/tables/mozilla/marvin/tfoot_valign_top-expected.txt:
- platform/efl/tables/mozilla/marvin/th_valign_baseline-expected.txt:
- platform/efl/tables/mozilla/marvin/th_valign_bottom-expected.txt:
- platform/efl/tables/mozilla/marvin/th_valign_middle-expected.txt:
- platform/efl/tables/mozilla/marvin/th_valign_top-expected.txt:
- platform/efl/tables/mozilla/marvin/thead_valign_baseline-expected.txt:
- platform/efl/tables/mozilla/marvin/thead_valign_bottom-expected.txt:
- platform/efl/tables/mozilla/marvin/thead_valign_middle-expected.txt:
- platform/efl/tables/mozilla/marvin/thead_valign_top-expected.txt:
- platform/efl/tables/mozilla/marvin/tr_bgcolor_aqua_rgb-expected.txt:
- platform/efl/tables/mozilla/marvin/tr_bgcolor_black-expected.txt:
- platform/efl/tables/mozilla/marvin/tr_bgcolor_black_rgb-expected.txt:
- platform/efl/tables/mozilla/marvin/tr_bgcolor_blue-expected.txt:
- platform/efl/tables/mozilla/marvin/tr_bgcolor_blue_rgb-expected.txt:
- platform/efl/tables/mozilla/marvin/tr_bgcolor_fuchsia-expected.txt:
- platform/efl/tables/mozilla/marvin/tr_bgcolor_fuchsia_rgb-expected.txt:
- platform/efl/tables/mozilla/marvin/tr_bgcolor_gray-expected.txt:
- platform/efl/tables/mozilla/marvin/tr_bgcolor_gray_rgb-expected.txt:
- platform/efl/tables/mozilla/marvin/tr_bgcolor_green-expected.txt:
- platform/efl/tables/mozilla/marvin/tr_bgcolor_green_rgb-expected.txt:
- platform/efl/tables/mozilla/marvin/tr_bgcolor_lime-expected.txt:
- platform/efl/tables/mozilla/marvin/tr_bgcolor_lime_rgb-expected.txt:
- platform/efl/tables/mozilla/marvin/tr_bgcolor_maroon-expected.txt:
- platform/efl/tables/mozilla/marvin/tr_bgcolor_maroon_rgb-expected.txt:
- platform/efl/tables/mozilla/marvin/tr_bgcolor_navy-expected.txt:
- platform/efl/tables/mozilla/marvin/tr_bgcolor_navy_rgb-expected.txt:
- platform/efl/tables/mozilla/marvin/tr_bgcolor_olive-expected.txt:
- platform/efl/tables/mozilla/marvin/tr_bgcolor_olive_rgb-expected.txt:
- platform/efl/tables/mozilla/marvin/tr_bgcolor_purple-expected.txt:
- platform/efl/tables/mozilla/marvin/tr_bgcolor_purple_rgb-expected.txt:
- platform/efl/tables/mozilla/marvin/tr_bgcolor_red-expected.txt:
- platform/efl/tables/mozilla/marvin/tr_bgcolor_red_rgb-expected.txt:
- platform/efl/tables/mozilla/marvin/tr_bgcolor_silver-expected.txt:
- platform/efl/tables/mozilla/marvin/tr_bgcolor_silver_rgb-expected.txt:
- platform/efl/tables/mozilla/marvin/tr_bgcolor_teal-expected.txt:
- platform/efl/tables/mozilla/marvin/tr_bgcolor_teal_rgb-expected.txt:
- platform/efl/tables/mozilla/marvin/tr_bgcolor_white-expected.txt:
- platform/efl/tables/mozilla/marvin/tr_bgcolor_white_rgb-expected.txt:
- platform/efl/tables/mozilla/marvin/tr_bgcolor_yellow-expected.txt:
- platform/efl/tables/mozilla/marvin/tr_bgcolor_yellow_rgb-expected.txt:
- platform/efl/tables/mozilla/marvin/tr_valign_baseline-expected.txt:
- platform/efl/tables/mozilla/marvin/tr_valign_bottom-expected.txt:
- platform/efl/tables/mozilla/marvin/tr_valign_middle-expected.txt:
- platform/efl/tables/mozilla/marvin/tr_valign_top-expected.txt:
- platform/efl/tables/mozilla/marvin/x_col_align_char-expected.txt:
- platform/efl/tables/mozilla/marvin/x_col_span-expected.txt:
- platform/efl/tables/mozilla/marvin/x_col_valign_baseline-expected.txt:
- platform/efl/tables/mozilla/marvin/x_col_valign_bottom-expected.txt:
- platform/efl/tables/mozilla/marvin/x_col_valign_middle-expected.txt:
- platform/efl/tables/mozilla/marvin/x_col_valign_top-expected.txt:
- platform/efl/tables/mozilla/marvin/x_col_width_px-expected.txt:
- platform/efl/tables/mozilla/marvin/x_col_width_rel-expected.txt:
- platform/efl/tables/mozilla/marvin/x_colgroup_align_char-expected.txt:
- platform/efl/tables/mozilla/marvin/x_colgroup_span-expected.txt:
- platform/efl/tables/mozilla/marvin/x_colgroup_valign_baseline-expected.txt:
- platform/efl/tables/mozilla/marvin/x_colgroup_valign_bottom-expected.txt:
- platform/efl/tables/mozilla/marvin/x_colgroup_valign_middle-expected.txt:
- platform/efl/tables/mozilla/marvin/x_colgroup_valign_top-expected.txt:
- platform/efl/tables/mozilla/marvin/x_colgroup_width_rel-expected.txt:
- platform/efl/tables/mozilla/marvin/x_tbody_valign_baseline-expected.txt:
- platform/efl/tables/mozilla/marvin/x_tbody_valign_bottom-expected.txt:
- platform/efl/tables/mozilla/marvin/x_tbody_valign_middle-expected.txt:
- platform/efl/tables/mozilla/marvin/x_tbody_valign_top-expected.txt:
- platform/efl/tables/mozilla/marvin/x_td_align_center-expected.txt:
- platform/efl/tables/mozilla/marvin/x_td_align_char-expected.txt:
- platform/efl/tables/mozilla/marvin/x_td_align_justify-expected.txt:
- platform/efl/tables/mozilla/marvin/x_td_align_left-expected.txt:
- platform/efl/tables/mozilla/marvin/x_td_align_right-expected.txt:
- platform/efl/tables/mozilla/marvin/x_td_valign_baseline-expected.txt:
- platform/efl/tables/mozilla/marvin/x_td_valign_bottom-expected.txt:
- platform/efl/tables/mozilla/marvin/x_td_valign_middle-expected.txt:
- platform/efl/tables/mozilla/marvin/x_td_valign_top-expected.txt:
- platform/efl/tables/mozilla/marvin/x_td_width-expected.txt:
- platform/efl/tables/mozilla/marvin/x_tfoot_valign_baseline-expected.txt:
- platform/efl/tables/mozilla/marvin/x_tfoot_valign_bottom-expected.txt:
- platform/efl/tables/mozilla/marvin/x_tfoot_valign_middle-expected.txt:
- platform/efl/tables/mozilla/marvin/x_tfoot_valign_top-expected.txt:
- platform/efl/tables/mozilla/marvin/x_th_align_center-expected.txt:
- platform/efl/tables/mozilla/marvin/x_th_align_char-expected.txt:
- platform/efl/tables/mozilla/marvin/x_th_align_justify-expected.txt:
- platform/efl/tables/mozilla/marvin/x_th_align_left-expected.txt:
- platform/efl/tables/mozilla/marvin/x_th_align_right-expected.txt:
- platform/efl/tables/mozilla/marvin/x_th_rowspan-expected.txt:
- platform/efl/tables/mozilla/marvin/x_th_valign_baseline-expected.txt:
- platform/efl/tables/mozilla/marvin/x_th_valign_bottom-expected.txt:
- platform/efl/tables/mozilla/marvin/x_th_valign_middle-expected.txt:
- platform/efl/tables/mozilla/marvin/x_th_valign_top-expected.txt:
- platform/efl/tables/mozilla/marvin/x_th_width-expected.txt:
- platform/efl/tables/mozilla/marvin/x_thead_valign_baseline-expected.txt:
- platform/efl/tables/mozilla/marvin/x_thead_valign_bottom-expected.txt:
- platform/efl/tables/mozilla/marvin/x_thead_valign_middle-expected.txt:
- platform/efl/tables/mozilla/marvin/x_thead_valign_top-expected.txt:
- platform/efl/tables/mozilla/marvin/x_tr_align_char-expected.txt:
- platform/efl/tables/mozilla/marvin/x_tr_valign_baseline-expected.txt:
- platform/efl/tables/mozilla/marvin/x_tr_valign_bottom-expected.txt:
- platform/efl/tables/mozilla/marvin/x_tr_valign_middle-expected.txt:
- platform/efl/tables/mozilla/marvin/x_tr_valign_top-expected.txt:
- platform/efl/tables/mozilla/other/cell_widths-expected.txt:
- platform/efl/tables/mozilla/other/ms-expected.txt:
- platform/efl/tables/mozilla/other/nested2-expected.txt:
- platform/efl/tables/mozilla/other/nestedTables-expected.txt:
- platform/efl/tables/mozilla/other/slashlogo-expected.txt:
- platform/efl/tables/mozilla/other/test3-expected.txt:
- platform/efl/tables/mozilla/other/test6-expected.txt:
- platform/efl/tables/mozilla/other/wa_table_thtd_rowspan-expected.txt:
- platform/efl/tables/mozilla/other/wa_table_tr_align-expected.txt:
- platform/efl/tables/mozilla_expected_failures/bugs/97619-expected.txt:
- platform/efl/tables/mozilla_expected_failures/bugs/bug1010-expected.txt:
- platform/efl/tables/mozilla_expected_failures/bugs/bug1128-expected.txt:
- platform/efl/tables/mozilla_expected_failures/bugs/bug1164-expected.txt:
- platform/efl/tables/mozilla_expected_failures/bugs/bug128876-expected.txt:
- platform/efl/tables/mozilla_expected_failures/bugs/bug14007-1-expected.txt:
- platform/efl/tables/mozilla_expected_failures/bugs/bug14007-2-expected.txt:
- platform/efl/tables/mozilla_expected_failures/bugs/bug1647-expected.txt:
- platform/efl/tables/mozilla_expected_failures/bugs/bug1725-expected.txt:
- platform/efl/tables/mozilla_expected_failures/bugs/bug17826-expected.txt:
- platform/efl/tables/mozilla_expected_failures/bugs/bug21518-expected.txt:
- platform/efl/tables/mozilla_expected_failures/bugs/bug22122-expected.txt:
- platform/efl/tables/mozilla_expected_failures/bugs/bug23847-expected.txt:
- platform/efl/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt:
- platform/efl/tables/mozilla_expected_failures/bugs/bug27993-2-expected.txt:
- platform/efl/tables/mozilla_expected_failures/bugs/bug29058-2-expected.txt:
- platform/efl/tables/mozilla_expected_failures/bugs/bug3105-expected.txt:
- platform/efl/tables/mozilla_expected_failures/bugs/bug56024-expected.txt:
- platform/efl/tables/mozilla_expected_failures/bugs/bug59252-expected.txt:
- platform/efl/tables/mozilla_expected_failures/bugs/bug7121-2-expected.txt:
- platform/efl/tables/mozilla_expected_failures/bugs/bug72393-expected.txt:
- platform/efl/tables/mozilla_expected_failures/bugs/bug7243-expected.txt:
- platform/efl/tables/mozilla_expected_failures/bugs/bug80762-2-expected.txt:
- platform/efl/tables/mozilla_expected_failures/bugs/bug8499-expected.txt:
- platform/efl/tables/mozilla_expected_failures/bugs/bug85016-expected.txt:
- platform/efl/tables/mozilla_expected_failures/bugs/bug89315-expected.txt:
- platform/efl/tables/mozilla_expected_failures/bugs/bug91057-expected.txt:
- platform/efl/tables/mozilla_expected_failures/bugs/bug9879-1-expected.txt:
- platform/efl/tables/mozilla_expected_failures/collapsing_borders/bug41262-1-expected.txt:
- platform/efl/tables/mozilla_expected_failures/core/captions1-expected.txt:
- platform/efl/tables/mozilla_expected_failures/core/captions2-expected.txt:
- platform/efl/tables/mozilla_expected_failures/core/col_span2-expected.txt:
- platform/efl/tables/mozilla_expected_failures/core/cols1-expected.txt:
- platform/efl/tables/mozilla_expected_failures/core/columns-expected.txt:
- platform/efl/tables/mozilla_expected_failures/core/standards1-expected.txt:
- platform/efl/tables/mozilla_expected_failures/dom/appendColGroup1-expected.txt:
- platform/efl/tables/mozilla_expected_failures/marvin/backgr_border-table-cell-expected.txt:
- platform/efl/tables/mozilla_expected_failures/marvin/backgr_border-table-column-expected.txt:
- platform/efl/tables/mozilla_expected_failures/marvin/backgr_border-table-column-group-expected.txt:
- platform/efl/tables/mozilla_expected_failures/marvin/backgr_border-table-expected.txt:
- platform/efl/tables/mozilla_expected_failures/marvin/backgr_border-table-quirks-expected.txt:
- platform/efl/tables/mozilla_expected_failures/marvin/backgr_border-table-row-expected.txt:
- platform/efl/tables/mozilla_expected_failures/marvin/backgr_border-table-row-group-expected.txt:
- platform/efl/tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.txt:
- platform/efl/tables/mozilla_expected_failures/marvin/backgr_layers-hide-expected.txt:
- platform/efl/tables/mozilla_expected_failures/marvin/backgr_layers-show-expected.txt:
- platform/efl/tables/mozilla_expected_failures/marvin/backgr_position-table-cell-expected.txt:
- platform/efl/tables/mozilla_expected_failures/marvin/backgr_position-table-column-expected.txt:
- platform/efl/tables/mozilla_expected_failures/marvin/backgr_position-table-column-group-expected.txt:
- platform/efl/tables/mozilla_expected_failures/marvin/backgr_position-table-row-expected.txt:
- platform/efl/tables/mozilla_expected_failures/marvin/backgr_position-table-row-group-expected.txt:
- platform/efl/tables/mozilla_expected_failures/marvin/table_overflow_caption-expected.txt:
- platform/efl/tables/mozilla_expected_failures/marvin/table_overflow_caption_bottom-expected.txt:
- platform/efl/tables/mozilla_expected_failures/marvin/table_overflow_caption_hidden-expected.txt:
- platform/efl/tables/mozilla_expected_failures/marvin/table_overflow_caption_hidden_table-expected.txt:
- platform/efl/tables/mozilla_expected_failures/marvin/table_overflow_caption_left-expected.txt:
- platform/efl/tables/mozilla_expected_failures/marvin/table_overflow_caption_right-expected.txt:
- platform/efl/tables/mozilla_expected_failures/marvin/table_overflow_caption_top-expected.txt:
- platform/efl/tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow-expected.txt:
- platform/efl/tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow_table-expected.txt:
- platform/efl/tables/mozilla_expected_failures/marvin/table_overflow_hidden_table-expected.txt:
- platform/efl/tables/mozilla_expected_failures/marvin/table_overflow_hidden_tbody-expected.txt:
- platform/efl/tables/mozilla_expected_failures/marvin/table_overflow_hidden_tr-expected.txt:
- platform/efl/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_cell-expected.txt:
- platform/efl/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_cell_sibling-expected.txt:
- platform/efl/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_row-expected.txt:
- platform/efl/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_row_sibling-expected.txt:
- platform/efl/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_table-expected.txt:
- platform/efl/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_table_caption-expected.txt:
- platform/efl/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_tbody-expected.txt:
- platform/efl/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_tbody_sibling-expected.txt:
- platform/efl/tables/mozilla_expected_failures/marvin/table_overflow_td_align_right-expected.txt:
- platform/efl/tables/mozilla_expected_failures/marvin/table_overflow_td_dynamic_deactivate-expected.txt:
- platform/efl/tables/mozilla_expected_failures/marvin/table_overflow_td_valign_bottom-expected.txt:
- platform/efl/tables/mozilla_expected_failures/marvin/table_overflow_td_valign_middle-expected.txt:
- platform/efl/tables/mozilla_expected_failures/marvin/table_overflow_td_valign_top-expected.txt:
- platform/efl/tables/mozilla_expected_failures/marvin/tables_cellspacing_pct-expected.txt:
- platform/efl/tables/mozilla_expected_failures/other/empty_cells-expected.txt:
- platform/efl/tables/mozilla_expected_failures/other/test4-expected.txt:
- 8:22 PM Changeset in webkit [196042] by
-
- 3 edits in trunk/Source/JavaScriptCore
[JSC] make Object.getOwnPropertyDescriptors() work with non-JSObject types
https://bugs.webkit.org/show_bug.cgi?id=153814
Patch by Caitlin Potter <caitp@igalia.com> on 2016-02-02
Reviewed by Yusuke Suzuki.
- runtime/ObjectConstructor.cpp:
(JSC::objectConstructorGetOwnPropertyDescriptors):
- tests/es6/Object_static_methods_Object.getOwnPropertyDescriptors.js:
(testGlobalProxy):
- 8:16 PM Changeset in webkit [196041] by
-
- 4 edits1 delete in trunk/Source
Remove references to CallFrameInlines.h
https://bugs.webkit.org/show_bug.cgi?id=153810
Reviewed by Mark Lam.
Source/JavaScriptCore:
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters:
Source/WebCore:
- ForwardingHeaders/interpreter/CallFrameInlines.h: Removed.
- 7:17 PM Changeset in webkit [196040] by
-
- 7 edits2 adds in trunk
[JSC] Implement Object.getOwnPropertyDescriptors() proposal
https://bugs.webkit.org/show_bug.cgi?id=153799
Patch by Caitlin Potter <caitp@igalia.com> on 2016-02-02
Reviewed by Darin Adler.
Source/JavaScriptCore:
Implements the Object.getOwnPropertyDescriptors() proposal, which
reached Stage 3 in the TC39 process in January 2016.
https://github.com/tc39/proposal-object-getownpropertydescriptors
The method extracts a set of property descriptor objects, which can
be safely used viaObject.create().
- runtime/ObjectConstructor.cpp:
(JSC::objectConstructorGetOwnPropertyDescriptors):
LayoutTests:
- js/Object-getOwnPropertyNames-expected.txt:
- js/script-tests/Object-getOwnPropertyNames.js:
- 6:27 PM Changeset in webkit [196039] by
-
- 3 edits in trunk/Source/WebCore
WEBGL_debug_shaders should be disabled for OpenGLES backend also
https://bugs.webkit.org/show_bug.cgi?id=153788
Reviewed by Darin Adler.
WEBGL_debug_shaders extension is disabled for OpenGL backed platform
because the implementation is not fully compliant to the spec yet.
Because this is not an OpenGL-specific problem, WEBGL_debug_shaders extension
should be disabled for OpenGLES backed platforms also.
No new tests, already covered by existing tests.
- platform/graphics/opengl/Extensions3DOpenGL.cpp:
(WebCore::Extensions3DOpenGL::supportsExtension): Deleted.
- platform/graphics/opengl/Extensions3DOpenGLCommon.cpp:
(WebCore::Extensions3DOpenGLCommon::supports):
- 4:12 PM Changeset in webkit [196038] by
-
- 5 edits in trunk
Modern IDB: storage/indexeddb/cursor-primary-key-order.html fails with SQLite backend.
https://bugs.webkit.org/show_bug.cgi?id=153800
Reviewed by Alex Christensen.
Source/WebCore:
No new tests (Existing tests now unskipped).
The IndexRecords SQL schema did not order things by primaryKey.
Easy fix to the schema. Sadly requires a migration...
- Modules/indexeddb/server/SQLiteIDBBackingStore.cpp:
(WebCore::IDBServer::v1IndexRecordsTableSchema):
(WebCore::IDBServer::v1IndexRecordsTableSchemaAlternate):
(WebCore::IDBServer::v2IndexRecordsTableSchema):
(WebCore::IDBServer::v2IndexRecordsTableSchemaAlternate):
(WebCore::IDBServer::SQLiteIDBBackingStore::ensureValidIndexRecordsTable):
(WebCore::IDBServer::SQLiteIDBBackingStore::createAndPopulateInitialDatabaseInfo):
- Modules/indexeddb/server/SQLiteIDBBackingStore.h:
LayoutTests:
- platform/mac-wk1/TestExpectations:
- 4:09 PM Changeset in webkit [196037] by
-
- 3 edits in trunk/Source/WebKit2
Provide handleKeyWebEvent with completion handler.
https://bugs.webkit.org/show_bug.cgi?id=153806
rdar://problem/24399218
Reviewed by Tim Horton.
- UIProcess/ios/WKContentViewInteraction.h:
- UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView handleKeyWebEvent:withCompletionHandler:]):
(-[WKContentView _didHandleKeyEvent:eventWasHandled:]):
- 4:08 PM Changeset in webkit [196036] by
-
- 5 edits2 adds in trunk
<attachment> should attempt to guess the icon from the file extension if all else fails
https://bugs.webkit.org/show_bug.cgi?id=153804
<rdar://problem/24448146>
Reviewed by Anders Carlsson.
Source/WebCore:
Test: fast/attachment/attachment-icon-from-file-extension.html
- platform/graphics/Icon.h:
- platform/graphics/mac/IconMac.mm:
(WebCore::Icon::createIconForFileExtension):
- rendering/RenderThemeMac.mm:
(WebCore::iconForAttachment):
If we can't find an icon any other way, try assuming that the title is a filename,
grab its extension, and have NSWorkspace try to work out an icon for it.
LayoutTests:
- fast/attachment/attachment-icon-from-file-extension-expected.html: Added.
- fast/attachment/attachment-icon-from-file-extension.html: Added.
- 3:46 PM Changeset in webkit [196035] by
-
- 4 edits in trunk/Source/JavaScriptCore
B3 should be able to compile trivial self-loops
https://bugs.webkit.org/show_bug.cgi?id=153802
rdar://problem/24465632
Reviewed by Michael Saboff.
Tail-duplicating a self-loop would mean doing a kind of loop unrolling. It wouldn't be
profitable even if it did work. It turns out that it doesn't work, because we edit the target
block before reading the source block, which breaks if the target and source block are the
same.
This disables tail duplication of self-loops, adds a test, and adds better validation for this
issue.
- b3/B3DuplicateTails.cpp:
- b3/B3Procedure.cpp:
(JSC::B3::Procedure::resetReachability):
- b3/testb3.cpp:
(JSC::B3::testComputeDivisionMagic):
(JSC::B3::testTrivialInfiniteLoop):
(JSC::B3::zero):
(JSC::B3::run):
- 3:42 PM Changeset in webkit [196034] by
-
- 6 edits in trunk/Source/WebKit2
Fix authentication with NetworkSession
https://bugs.webkit.org/show_bug.cgi?id=153779
Reviewed by Brady Eidson.
This fixes many tests, including http/tests/xmlhttprequest/cross-origin-authorization.html.
- NetworkProcess/NetworkLoad.cpp:
(WebKit::NetworkLoad::NetworkLoad):
NetworkingContexts are not used with NetworkSession. NetworkSession is used instead.
Pass allowStoredCredentials to the NetworkLoad so it knows whether to use a session with credential storage or not.
(WebKit::NetworkLoad::didReceiveChallenge):
Always call continueCanAuthenticateAgainstProtectionSpace because we might need credentials for synchronous requests.
(WebKit::NetworkLoad::continueCanAuthenticateAgainstProtectionSpace):
Reject the protection space if we cannot authenticate against this protection space.
If the protection space is not password-based (such as ServerTrustEvaluationRequested) and we can authenticate against this protection space,
then perform default handling instead of asking the UI process for a password, which wouldn't mean anything.
- NetworkProcess/NetworkLoad.h:
- NetworkProcess/NetworkSession.h:
Use a NSURLSession with configuration.URLCredentialStorage = nil but with the same cookie storage for requests without credentials.
- NetworkProcess/cocoa/NetworkSessionCocoa.mm:
(WebKit::NetworkSession::NetworkSession):
(WebKit::NetworkSession::~NetworkSession):
(WebKit::NetworkSession::dataTaskForIdentifier):
(WebKit::NetworkSession::takeDownloadID):
(WebKit::NetworkDataTask::NetworkDataTask):
- WebProcess/Network/WebResourceLoader.cpp:
(WebKit::WebResourceLoader::canAuthenticateAgainstProtectionSpace):
Always send a reply message so we can always do the callbacks of NSURLSession delegates.
- 3:26 PM Changeset in webkit [196033] by
-
- 11 edits in trunk
[ES6] bound functions .name property should be "bound " + the target function's name
https://bugs.webkit.org/show_bug.cgi?id=153796
Reviewed by Mark Lam.
Source/JavaScriptCore:
See http://tc39.github.io/ecma262/#sec-function.prototype.bind for details.
What the spec says:
`
function foo() { }
foo.bind(null).name === "bound foo"
(function bar() { }).bind(null).name === "bound bar"
`
- runtime/FunctionPrototype.cpp:
(JSC::functionProtoFuncToString):
- runtime/JSBoundFunction.cpp:
(JSC::hasInstanceBoundFunction):
(JSC::JSBoundFunction::create):
(JSC::JSBoundFunction::visitChildren):
(JSC::JSBoundFunction::toStringName):
- runtime/JSBoundFunction.h:
(JSC::JSBoundFunction::boundThis):
(JSC::JSBoundFunction::boundArgs):
(JSC::JSBoundFunction::createStructure):
- tests/es6.yaml:
LayoutTests:
- inspector/runtime/getProperties-expected.txt:
- platform/mac/http/tests/media/media-source/SourceBuffer-abort-readyState-expected.txt:
- platform/mac/http/tests/media/media-source/SourceBuffer-abort-removed-expected.txt:
- platform/mac/http/tests/media/media-source/SourceBuffer-abort-updating-expected.txt:
- platform/mac/http/tests/media/media-source/mediasource-sourcebuffer-mode-expected.txt:
- 3:21 PM Changeset in webkit [196032] by
-
- 62 edits2 moves5 adds in trunk
Get rid of anonymous stack slots
https://bugs.webkit.org/show_bug.cgi?id=151128
Reviewed by Mark Lam.
Source/JavaScriptCore:
When I first designed stack slots, the idea was that an "anonymous" stack slot was one that
behaved exactly like a C variable: if it never escaped, it would not need to get stack space
for the entire lifetime of the function - it could get any slab of stack so long as it
didn't interfere with other stack slots that would be live at the same time. The reason I
called them "anonymous" is that external code could not get its address. This felt like it
gave the stack slot anonymity. But it was never a good name for this concept.
Then I had the register allocator lower temporaries to anonymous stack slots when it spilled
them. Spilling became the sole client of anonymous stack slots.
Then I realized that there was an aspect of how spill slots work that make them want
slightly different semantics than a normal C variable. A C variable is a proper memory
location - you could do a store to only some bytes in the variable, and it's reasonable to
expect that this will not destroy the other bytes in the variable. But that means that to
compute their liveness, you have to do something like a per-byte liveness. That's overkill
for spill slots. You want any store to the spill slot to kill the whole slot even if it
writes to just part of the slot. This matches how temporaries work. So rather than implement
per-byte liveness, I decided to change the semantics of anonymous stack slots to make them
work like how I wanted spill slots to work. This was quite dirty, and put B3 in the awkward
situation that B3's anonymous stack slots behaved like spill slots. But it was OK since
nobody used anonymous stack slots in B3.
Then I added tail duplication, which required having a mechanism for introducing non-SSA
variables in B3. I decided to use anonymous stack slots for this purpose. All of a sudden
this all felt like it made sense: anonymous stack slots were just like variables! Hooray for
the amazing foresight of anonymous stack slots!
But then I realized that this was all very bad. We want B3 to be able to optimize Store and
Load operations by reasoning about how they affect bytes in memory. For example, if you do
a Load of a 64-bit value, and then you modify just the low 32 bits of that value, and then
you do a 64-bit store back to the same location, then it would be better to transform this
into 32-bit operations. We don't do this optimization yet, but it's the kind of thing that
we want B3 to be able to do. To do it, we need Store to mean that it only affects N bytes
starting at the pointer, where N is the size of the thing being stored. But that's not what
Store means for anonymous stack slots. For anonymous slots, storing to any byte in the slot
clobbers all bytes in the slot. We were never clear if you need to store directly to an
anonymous slot to get this behavior, or if any pointer that points to an anoymous slot must
exhibit this behavior when stored to. Neither kinds of semantics make sense to me.
This change fixes the problem by eradicating anonymous stack slots. In B3, they are replaced
with Variables. In Air, they are replaced with a different stack slot kind, called Spill.
There is no such thing as stack slot kinds in B3 anymore, all B3 stack slots are locked. In
Air, there is still the concept of stack slot kind - Locked or Spill.
B3 Variables are awesome. They are exactly what they seem to be. They have a type. They are
declared at the top level in the Procedure. You can access them with new opcodes, Get and
Set. This greatly simplifies demoting SSA values to variables and promoting them back to
SSA. I even made the instruction selector do the right things for variables, which means
that introducing variables won't hurt instruction selection (there will be extra moves, but
IRC will kill them). It's great to have non-SSA variables as an explicit concept in IR
because it means that you don't have to do any magic to use them - they Just Work.
Air spill slots behave almost like anonymous stack slots, with one exception: you cannot
escape them. We validate this by making it illegal to UseAddr on a spill slot. This removes
the need to answer awkward questions like: does a 32-bit Def on a pointer that may point to
a 64-bit spill slot do anything to the 32 bits above the pointer? Does it write zero to it?
Does it write zero to it just when the pointer actually points to a spill slot or always?
These are silly questions, and we don't have to answer them because the only way to refer to
a spill slot is directly. No escaping means no aliasing.
This doesn't affect performance. It just makes the compiler more fun to work with by
removing some cognitive dissonance.
- CMakeLists.txt:
- JavaScriptCore.xcodeproj/project.pbxproj:
- b3/B3ArgumentRegValue.h:
- b3/B3CCallValue.h:
- b3/B3CheckValue.cpp:
(JSC::B3::CheckValue::cloneImpl):
(JSC::B3::CheckValue::CheckValue):
- b3/B3CheckValue.h:
- b3/B3Const32Value.h:
- b3/B3Const64Value.h:
- b3/B3ConstDoubleValue.h:
- b3/B3ConstFloatValue.h:
- b3/B3ConstPtrValue.h:
(JSC::B3::ConstPtrValue::ConstPtrValue):
- b3/B3ControlValue.cpp:
(JSC::B3::ControlValue::convertToJump):
(JSC::B3::ControlValue::convertToOops):
(JSC::B3::ControlValue::dumpMeta):
- b3/B3ControlValue.h:
- b3/B3Effects.cpp:
(JSC::B3::Effects::interferes):
(JSC::B3::Effects::dump):
- b3/B3Effects.h:
(JSC::B3::Effects::mustExecute):
- b3/B3EliminateCommonSubexpressions.cpp:
- b3/B3FixSSA.cpp:
(JSC::B3::demoteValues):
(JSC::B3::fixSSA):
- b3/B3FixSSA.h:
- b3/B3IndexMap.h:
(JSC::B3::IndexMap::resize):
(JSC::B3::IndexMap::clear):
(JSC::B3::IndexMap::size):
(JSC::B3::IndexMap::operator[]):
- b3/B3IndexSet.h:
(JSC::B3::IndexSet::contains):
(JSC::B3::IndexSet::size):
(JSC::B3::IndexSet::isEmpty):
- b3/B3LowerToAir.cpp:
(JSC::B3::Air::LowerToAir::run):
(JSC::B3::Air::LowerToAir::lower):
- b3/B3MemoryValue.h:
- b3/B3Opcode.cpp:
(WTF::printInternal):
- b3/B3Opcode.h:
- b3/B3PatchpointValue.cpp:
(JSC::B3::PatchpointValue::cloneImpl):
(JSC::B3::PatchpointValue::PatchpointValue):
- b3/B3PatchpointValue.h:
- b3/B3Procedure.cpp:
(JSC::B3::Procedure::Procedure):
(JSC::B3::Procedure::addBlock):
(JSC::B3::Procedure::addStackSlot):
(JSC::B3::Procedure::addVariable):
(JSC::B3::Procedure::clone):
(JSC::B3::Procedure::addIntConstant):
(JSC::B3::Procedure::dump):
(JSC::B3::Procedure::deleteStackSlot):
(JSC::B3::Procedure::deleteVariable):
(JSC::B3::Procedure::deleteValue):
(JSC::B3::Procedure::deleteOrphans):
(JSC::B3::Procedure::calleeSaveRegisters):
(JSC::B3::Procedure::addValueImpl):
(JSC::B3::Procedure::setBlockOrderImpl):
(JSC::B3::Procedure::addAnonymousStackSlot): Deleted.
(JSC::B3::Procedure::addStackSlotIndex): Deleted.
(JSC::B3::Procedure::addValueIndex): Deleted.
- b3/B3Procedure.h:
(JSC::B3::Procedure::setBlockOrder):
(JSC::B3::Procedure::stackSlots):
(JSC::B3::Procedure::variables):
(JSC::B3::Procedure::values):
(JSC::B3::Procedure::StackSlotsCollection::StackSlotsCollection): Deleted.
(JSC::B3::Procedure::StackSlotsCollection::size): Deleted.
(JSC::B3::Procedure::StackSlotsCollection::at): Deleted.
(JSC::B3::Procedure::StackSlotsCollection::operator[]): Deleted.
(JSC::B3::Procedure::StackSlotsCollection::iterator::iterator): Deleted.
(JSC::B3::Procedure::StackSlotsCollection::iterator::operator*): Deleted.
(JSC::B3::Procedure::StackSlotsCollection::iterator::operator++): Deleted.
(JSC::B3::Procedure::StackSlotsCollection::iterator::operator==): Deleted.
(JSC::B3::Procedure::StackSlotsCollection::iterator::operator!=): Deleted.
(JSC::B3::Procedure::StackSlotsCollection::iterator::findNext): Deleted.
(JSC::B3::Procedure::StackSlotsCollection::begin): Deleted.
(JSC::B3::Procedure::StackSlotsCollection::end): Deleted.
(JSC::B3::Procedure::ValuesCollection::ValuesCollection): Deleted.
(JSC::B3::Procedure::ValuesCollection::iterator::iterator): Deleted.
(JSC::B3::Procedure::ValuesCollection::iterator::operator*): Deleted.
(JSC::B3::Procedure::ValuesCollection::iterator::operator++): Deleted.
(JSC::B3::Procedure::ValuesCollection::iterator::operator==): Deleted.
(JSC::B3::Procedure::ValuesCollection::iterator::operator!=): Deleted.
(JSC::B3::Procedure::ValuesCollection::iterator::findNext): Deleted.
(JSC::B3::Procedure::ValuesCollection::begin): Deleted.
(JSC::B3::Procedure::ValuesCollection::end): Deleted.
(JSC::B3::Procedure::ValuesCollection::size): Deleted.
(JSC::B3::Procedure::ValuesCollection::at): Deleted.
(JSC::B3::Procedure::ValuesCollection::operator[]): Deleted.
- b3/B3ProcedureInlines.h:
(JSC::B3::Procedure::add):
- b3/B3ReduceStrength.cpp:
- b3/B3SlotBaseValue.h:
- b3/B3SparseCollection.h: Added.
(JSC::B3::SparseCollection::SparseCollection):
(JSC::B3::SparseCollection::add):
(JSC::B3::SparseCollection::addNew):
(JSC::B3::SparseCollection::remove):
(JSC::B3::SparseCollection::size):
(JSC::B3::SparseCollection::isEmpty):
(JSC::B3::SparseCollection::at):
(JSC::B3::SparseCollection::operator[]):
(JSC::B3::SparseCollection::iterator::iterator):
(JSC::B3::SparseCollection::iterator::operator*):
(JSC::B3::SparseCollection::iterator::operator++):
(JSC::B3::SparseCollection::iterator::operator==):
(JSC::B3::SparseCollection::iterator::operator!=):
(JSC::B3::SparseCollection::iterator::findNext):
(JSC::B3::SparseCollection::begin):
(JSC::B3::SparseCollection::end):
- b3/B3StackSlot.cpp:
(JSC::B3::StackSlot::deepDump):
(JSC::B3::StackSlot::StackSlot):
- b3/B3StackSlot.h:
(JSC::B3::StackSlot::byteSize):
(JSC::B3::StackSlot::index):
(JSC::B3::StackSlot::setOffsetFromFP):
(JSC::B3::StackSlot::kind): Deleted.
(JSC::B3::StackSlot::isLocked): Deleted.
- b3/B3StackSlotKind.cpp: Removed.
- b3/B3StackSlotKind.h: Removed.
- b3/B3StackmapValue.cpp:
(JSC::B3::StackmapValue::dumpMeta):
(JSC::B3::StackmapValue::StackmapValue):
- b3/B3StackmapValue.h:
- b3/B3SwitchValue.cpp:
(JSC::B3::SwitchValue::cloneImpl):
(JSC::B3::SwitchValue::SwitchValue):
- b3/B3SwitchValue.h:
- b3/B3UpsilonValue.h:
- b3/B3Validate.cpp:
- b3/B3Value.cpp:
(JSC::B3::Value::replaceWithIdentity):
(JSC::B3::Value::replaceWithNop):
(JSC::B3::Value::replaceWithPhi):
(JSC::B3::Value::dump):
(JSC::B3::Value::effects):
(JSC::B3::Value::checkOpcode):
- b3/B3Value.h:
- b3/B3Variable.cpp: Added.
(JSC::B3::Variable::~Variable):
(JSC::B3::Variable::dump):
(JSC::B3::Variable::deepDump):
(JSC::B3::Variable::Variable):
- b3/B3Variable.h: Added.
(JSC::B3::Variable::type):
(JSC::B3::Variable::index):
(JSC::B3::DeepVariableDump::DeepVariableDump):
(JSC::B3::DeepVariableDump::dump):
(JSC::B3::deepDump):
- b3/B3VariableValue.cpp: Added.
(JSC::B3::VariableValue::~VariableValue):
(JSC::B3::VariableValue::dumpMeta):
(JSC::B3::VariableValue::cloneImpl):
(JSC::B3::VariableValue::VariableValue):
- b3/B3VariableValue.h: Added.
- b3/air/AirAllocateStack.cpp:
(JSC::B3::Air::allocateStack):
- b3/air/AirCode.cpp:
(JSC::B3::Air::Code::addStackSlot):
(JSC::B3::Air::Code::addSpecial):
(JSC::B3::Air::Code::cCallSpecial):
- b3/air/AirCode.h:
(JSC::B3::Air::Code::begin):
(JSC::B3::Air::Code::end):
(JSC::B3::Air::Code::stackSlots):
(JSC::B3::Air::Code::specials):
(JSC::B3::Air::Code::forAllTmps):
(JSC::B3::Air::Code::StackSlotsCollection::StackSlotsCollection): Deleted.
(JSC::B3::Air::Code::StackSlotsCollection::size): Deleted.
(JSC::B3::Air::Code::StackSlotsCollection::at): Deleted.
(JSC::B3::Air::Code::StackSlotsCollection::operator[]): Deleted.
(JSC::B3::Air::Code::StackSlotsCollection::iterator::iterator): Deleted.
(JSC::B3::Air::Code::StackSlotsCollection::iterator::operator*): Deleted.
(JSC::B3::Air::Code::StackSlotsCollection::iterator::operator++): Deleted.
(JSC::B3::Air::Code::StackSlotsCollection::iterator::operator==): Deleted.
(JSC::B3::Air::Code::StackSlotsCollection::iterator::operator!=): Deleted.
(JSC::B3::Air::Code::StackSlotsCollection::begin): Deleted.
(JSC::B3::Air::Code::StackSlotsCollection::end): Deleted.
(JSC::B3::Air::Code::SpecialsCollection::SpecialsCollection): Deleted.
(JSC::B3::Air::Code::SpecialsCollection::size): Deleted.
(JSC::B3::Air::Code::SpecialsCollection::at): Deleted.
(JSC::B3::Air::Code::SpecialsCollection::operator[]): Deleted.
(JSC::B3::Air::Code::SpecialsCollection::iterator::iterator): Deleted.
(JSC::B3::Air::Code::SpecialsCollection::iterator::operator*): Deleted.
(JSC::B3::Air::Code::SpecialsCollection::iterator::operator++): Deleted.
(JSC::B3::Air::Code::SpecialsCollection::iterator::operator==): Deleted.
(JSC::B3::Air::Code::SpecialsCollection::iterator::operator!=): Deleted.
(JSC::B3::Air::Code::SpecialsCollection::begin): Deleted.
(JSC::B3::Air::Code::SpecialsCollection::end): Deleted.
- b3/air/AirFixObviousSpills.cpp:
- b3/air/AirInstInlines.h:
- b3/air/AirIteratedRegisterCoalescing.cpp:
- b3/air/AirLiveness.h:
- b3/air/AirLowerAfterRegAlloc.cpp:
(JSC::B3::Air::lowerAfterRegAlloc):
- b3/air/AirSpecial.cpp:
(JSC::B3::Air::Special::Special):
- b3/air/AirSpecial.h:
- b3/air/AirSpillEverything.cpp:
(JSC::B3::Air::spillEverything):
- b3/air/AirStackSlot.cpp:
(JSC::B3::Air::StackSlot::dump):
(JSC::B3::Air::StackSlot::deepDump):
(JSC::B3::Air::StackSlot::StackSlot):
- b3/air/AirStackSlot.h:
(JSC::B3::Air::StackSlot::byteSize):
(JSC::B3::Air::StackSlot::kind):
(JSC::B3::Air::StackSlot::isLocked):
(JSC::B3::Air::StackSlot::isSpill):
(JSC::B3::Air::StackSlot::index):
(JSC::B3::Air::StackSlot::ensureSize):
- b3/air/AirStackSlotKind.cpp: Copied from Source/JavaScriptCore/b3/B3StackSlotKind.cpp.
(WTF::printInternal):
- b3/air/AirStackSlotKind.h: Copied from Source/JavaScriptCore/b3/B3StackSlotKind.h.
- b3/air/opcode_generator.rb:
- b3/air/testair.cpp:
(JSC::B3::Air::testShuffleBroadcastAllRegs):
(JSC::B3::Air::testShuffleShiftAllRegs):
(JSC::B3::Air::testShuffleRotateAllRegs):
- b3/testb3.cpp:
(JSC::B3::testStackSlot):
(JSC::B3::testStoreLoadStackSlot):
- ftl/FTLB3Output.cpp:
(JSC::FTL::Output::lockedStackSlot):
(JSC::FTL::Output::neg):
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::DFG::LowerDFGToLLVM::compileInvalidationPoint):
Websites/webkit.org:
This changes the documentation to account for the addition of Variables and the Get and Set
opcodes, and the removal of anonymous stack slots from B3 IR.
- docs/b3/intermediate-representation.html:
- 2:34 PM Changeset in webkit [196031] by
-
- 20 edits2 adds in trunk/Source/WebCore
Factor style sharing code out of StyleResolver
https://bugs.webkit.org/show_bug.cgi?id=153768
Reviewed by Darin Adler.
Move the code to a new class, Style::SharingResolver.
When resolving document style we query the sharing resolver first before using the regular style resolver.
Other paths that call style resolver were mostly already disabling it with DisallowStyleSharing flag.
- WebCore.xcodeproj/project.pbxproj:
- css/ElementRuleCollector.cpp:
(WebCore::MatchRequest::MatchRequest):
(WebCore::ElementRuleCollector::matchAllRules):
(WebCore::ElementRuleCollector::hasAnyMatchingRules):
More const.
- css/ElementRuleCollector.h:
(WebCore::ElementRuleCollector::setRegionForStyling):
(WebCore::ElementRuleCollector::setMedium):
- css/MediaQueryMatcher.cpp:
(WebCore::MediaQueryMatcher::prepareEvaluator):
- css/StyleMedia.cpp:
(WebCore::StyleMedia::matchMedium):
- css/StyleResolver.cpp:
(WebCore::StyleResolver::State::cacheBorderAndBackground):
(WebCore::StyleResolver::StyleResolver):
(WebCore::StyleResolver::sweepMatchedPropertiesCache):
(WebCore::StyleResolver::State::State):
(WebCore::StyleResolver::State::setStyle):
(WebCore::isAtShadowBoundary):
(WebCore::StyleResolver::styleForElement):
(WebCore::StyleResolver::classNamesAffectedByRules): Deleted.
(WebCore::parentElementPreventsSharing): Deleted.
(WebCore::StyleResolver::locateCousinList): Deleted.
(WebCore::StyleResolver::styleSharingCandidateMatchesRuleSet): Deleted.
(WebCore::StyleResolver::canShareStyleWithControl): Deleted.
(WebCore::elementHasDirectionAuto): Deleted.
(WebCore::StyleResolver::sharingCandidateHasIdenticalStyleAffectingAttributes): Deleted.
(WebCore::StyleResolver::canShareStyleWithElement): Deleted.
(WebCore::StyleResolver::findSiblingForStyleSharing): Deleted.
(WebCore::StyleResolver::locateSharedStyle): Deleted.
Style sharing code moves to SharingResolver.
- css/StyleResolver.h:
(WebCore::StyleResolver::mediaQueryEvaluator):
(WebCore::StyleResolver::State::regionForStyling):
(WebCore::StyleResolver::State::elementLinkState):
(WebCore::StyleResolver::State::setApplyPropertyToRegularStyle):
(WebCore::StyleResolver::State::setApplyPropertyToVisitedLinkStyle):
(WebCore::StyleResolver::state):
(WebCore::StyleResolver::setTextOrientation):
(WebCore::StyleResolver::State::setElementAffectedByClassRules): Deleted.
(WebCore::StyleResolver::State::elementAffectedByClassRules): Deleted.
(WebCore::StyleResolver::styleNotYetAvailable): Deleted.
Placeholder code moves to TreeResolver.
- dom/VisitedLinkState.cpp:
(WebCore::linkAttribute):
(WebCore::VisitedLinkState::invalidateStyleForAllLinks):
(WebCore::linkHashForElement):
(WebCore::VisitedLinkState::invalidateStyleForLink):
(WebCore::VisitedLinkState::determineLinkStateSlowCase):
- dom/VisitedLinkState.h:
(WebCore::VisitedLinkState::determineLinkState):
- html/HTMLFormControlElement.h:
- rendering/RenderElement.cpp:
(WebCore::RenderElement::getUncachedPseudoStyle):
- rendering/RenderNamedFlowFragment.cpp:
(WebCore::RenderNamedFlowFragment::computeStyleInRegion):
- rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::isStyleAvailable):
(WebCore::RenderStyle::hasUniquePseudoStyle):
- style/StyleSharingResolver.cpp: Added.
(WebCore::Style::SharingResolver::SharingResolver):
(WebCore::Style::parentElementPreventsSharing):
(WebCore::Style::elementHasDirectionAuto):
(WebCore::Style::SharingResolver::searchSimilar):
(WebCore::Style::SharingResolver::findSibling):
(WebCore::Style::SharingResolver::locateCousinList):
(WebCore::Style::canShareStyleWithControl):
(WebCore::Style::SharingResolver::canShareStyleWithElement):
(WebCore::Style::SharingResolver::styleSharingCandidateMatchesRuleSet):
(WebCore::Style::SharingResolver::sharingCandidateHasIdenticalStyleAffectingAttributes):
(WebCore::Style::SharingResolver::classNamesAffectedByRules):
- style/StyleSharingResolver.h: Added.
- style/StyleTreeResolver.cpp:
(WebCore::Style::ensurePlaceholderStyle):
(WebCore::Style::TreeResolver::TreeResolver):
(WebCore::Style::TreeResolver::styleForElement):
Try to use SharingResolver first.
Also move placeholder style handling here, it is only relevant when resolving document style.
(WebCore::Style::postResolutionCallbacksAreSuspended):
(WebCore::Style::isPlaceholderStyle):
- style/StyleTreeResolver.h:
- svg/SVGElement.cpp:
(WebCore::SVGElement::customStyleForRenderer):
- svg/SVGElementRareData.h:
(WebCore::SVGElementRareData::overrideComputedStyle):
- 2:34 PM Changeset in webkit [196030] by
-
- 2 edits in trunk/LayoutTests
Marking perf/show-hide-table-rows.html as flaky on ios-simulator
https://bugs.webkit.org/show_bug.cgi?id=153803
Unreviewed test gardening.
- platform/ios-simulator/TestExpectations:
- 1:58 PM Changeset in webkit [196029] by
-
- 4 edits in trunk/Websites/webkit.org
Tagline in B3 docs should match the rest of the website
https://bugs.webkit.org/show_bug.cgi?id=153801
Reviewed by Filip Pizlo.
Fix the tagline.
- docs/b3/assembly-intermediate-representation.html:
- docs/b3/index.html:
- docs/b3/intermediate-representation.html:
- 1:31 PM Changeset in webkit [196028] by
-
- 3 edits2 adds in trunk
<attachment> icon should be a folder for the custom MIME type multipart/x-folder
https://bugs.webkit.org/show_bug.cgi?id=153795
<rdar://problem/24416632>
Reviewed by Anders Carlsson.
Source/WebCore:
Test: fast/attachment/attachment-folder-icon.html
- rendering/RenderThemeMac.mm:
(WebCore::iconForAttachment):
(WebCore::paintAttachmentIcon):
Mail uses this special MIME type to indicate that something is a folder, which there
isn't a normal non-deprecated MIME type for.
LayoutTests:
- fast/attachment/attachment-folder-icon-expected.html: Added.
- fast/attachment/attachment-folder-icon.html: Added.
Make sure that the rendering of an attachment with multipart/x-folder
matches that of a file reference pointing at a folder.
- 1:16 PM Changeset in webkit [196027] by
-
- 2 edits in trunk/LayoutTests
[GTK] Layout Test fast/images/animated-gif-no-layout.html is failing
https://bugs.webkit.org/show_bug.cgi?id=153798
Unreviewed gardening.
Patch by Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> on 2016-02-02
- platform/gtk/TestExpectations: mark a couple tests as failing. The
green frame of the gif is being rendered in a slightly lighter green.
- 1:14 PM WebKitGTK/Gardening/Calendar edited by
- (diff)
- 1:11 PM Changeset in webkit [196026] by
-
- 5 edits in trunk/LayoutTests
[Win] gardening after r195740.
Unreviewed.
- platform/win/editing/selection/5057506-2-expected.txt:
- platform/win/fast/block/margin-collapse/021-expected.txt:
- platform/win/fast/table/border-collapsing/cached-change-row-border-color-expected.txt:
- platform/win/tables/mozilla/marvin/x_tbody_style-expected.txt:
- 12:51 PM Changeset in webkit [196025] by
-
- 8 edits in trunk
Modern IDB: storage/indexeddb/cursor-continue-validity.html fails.
https://bugs.webkit.org/show_bug.cgi?id=153791
Reviewed by Alex Christensen.
Source/WebCore:
No new tests (Existing test now unskipped).
There was a preexisting check in the SQLite cursor for remembering the current record and
refusing to refetch it.
This check was causing this bug, because we needed to refetch the current record.
Removing the check (and its associated flag) doesn't regress any other test, and fixes this one.
- Modules/indexeddb/server/SQLiteIDBCursor.cpp:
(WebCore::IDBServer::SQLiteIDBCursor::resetAndRebindStatement):
(WebCore::IDBServer::SQLiteIDBCursor::internalAdvanceOnce):
- Modules/indexeddb/server/SQLiteIDBCursor.h:
LayoutTests:
In addition to unskipping the test, I augmented it to print out more of what was going on.
The additional printed info is what helped me track down the bug, and will make it more
likely to catch any future regressions.
- platform/mac-wk1/TestExpectations:
- storage/indexeddb/cursor-continue-validity-expected.txt:
- storage/indexeddb/cursor-continue-validity-private-expected.txt:
- storage/indexeddb/resources/cursor-continue-validity.js:
- 11:50 AM Changeset in webkit [196024] by
-
- 45 edits32 adds in trunk
Add a line grid pagination SPI to WebKit.
https://bugs.webkit.org/show_bug.cgi?id=153757
<rdar://problem/23041598>
Reviewed by Anders Carlsson.
Source/WebCore:
New tests in fast/multicol/pagination.
- page/Page.cpp:
(WebCore::Page::setPaginationLineGridEnabled):
- page/Page.h:
(WebCore::Page::paginationLineGridEnabled):
Add a boolean to the page to turn the line grid on and off.
- rendering/RenderBox.cpp:
(WebCore::RenderBox::styleDidChange):
Propagate the body's font up to the paginated RenderView so that
it can be used to establish the line grid.
- style/StyleResolveForDocument.cpp:
(WebCore::Style::resolveForDocument):
Set up a line grid with containment snapping by default if the
line grid enabled flag is set.
- testing/Internals.cpp:
(WebCore::Internals::resetToConsistentState):
(WebCore::Internals::setPagination):
(WebCore::Internals::setPaginationLineGridEnabled):
(WebCore::Internals::configurationForViewport):
- testing/Internals.h:
(WebCore::Internals::setPagination):
- testing/Internals.idl:
Add support for testing the grid being enabled.
Source/WebKit/mac:
- WebView/WebView.mm:
(-[WebView _setPaginationLineGridEnabled:]):
(-[WebView _paginationLineGridEnabled]):
- WebView/WebViewPrivate.h:
Source/WebKit2:
- Shared/WebPageCreationParameters.cpp:
(WebKit::WebPageCreationParameters::encode):
(WebKit::WebPageCreationParameters::decode):
- Shared/WebPageCreationParameters.h:
- UIProcess/API/C/WKPage.cpp:
(WKPageSetPaginationLineGridEnabled):
(WKPageGetPaginationLineGridEnabled):
- UIProcess/API/C/WKPagePrivate.h:
- UIProcess/API/Cocoa/WKBrowsingContextController.mm:
(-[WKBrowsingContextController setPaginationLineGridEnabled:]):
(-[WKBrowsingContextController paginationLineGridEnabled]):
- UIProcess/API/Cocoa/WKBrowsingContextControllerPrivate.h:
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _paginationLineGridEnabled]):
(-[WKWebView _setPaginationLineGridEnabled:]):
- UIProcess/API/Cocoa/WKWebViewPrivate.h:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::setPaginationLineGridEnabled):
(WebKit::WebPageProxy::creationParameters):
- UIProcess/WebPageProxy.h:
(WebKit::WebPageProxy::paginationLineGridEnabled):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::setPaginationLineGridEnabled):
WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/WebPage.messages.in:
LayoutTests:
- platform/mac/fast/multicol/pagination/BottomToTop-bt-expected.png:
- platform/mac/fast/multicol/pagination/BottomToTop-lr-expected.png:
- platform/mac/fast/multicol/pagination/BottomToTop-rl-expected.png:
- platform/mac/fast/multicol/pagination/BottomToTop-tb-expected.png:
- platform/mac/fast/multicol/pagination/BottomToTopGrid-bt-expected.png: Added.
- platform/mac/fast/multicol/pagination/BottomToTopGrid-bt-expected.txt: Added.
- platform/mac/fast/multicol/pagination/BottomToTopGrid-lr-expected.png: Added.
- platform/mac/fast/multicol/pagination/BottomToTopGrid-lr-expected.txt: Added.
- platform/mac/fast/multicol/pagination/BottomToTopGrid-rl-expected.png: Added.
- platform/mac/fast/multicol/pagination/BottomToTopGrid-rl-expected.txt: Added.
- platform/mac/fast/multicol/pagination/BottomToTopGrid-tb-expected.png: Added.
- platform/mac/fast/multicol/pagination/BottomToTopGrid-tb-expected.txt: Added.
- platform/mac/fast/multicol/pagination/LeftToRight-bt-expected.png:
- platform/mac/fast/multicol/pagination/LeftToRight-lr-expected.png:
- platform/mac/fast/multicol/pagination/LeftToRight-rl-expected.png:
- platform/mac/fast/multicol/pagination/LeftToRight-tb-expected.png:
- platform/mac/fast/multicol/pagination/LeftToRightGrid-bt-expected.png: Added.
- platform/mac/fast/multicol/pagination/LeftToRightGrid-bt-expected.txt: Added.
- platform/mac/fast/multicol/pagination/LeftToRightGrid-lr-expected.png: Added.
- platform/mac/fast/multicol/pagination/LeftToRightGrid-lr-expected.txt: Added.
- platform/mac/fast/multicol/pagination/LeftToRightGrid-rl-expected.png: Added.
- platform/mac/fast/multicol/pagination/LeftToRightGrid-rl-expected.txt: Added.
- platform/mac/fast/multicol/pagination/LeftToRightGrid-tb-expected.png: Added.
- platform/mac/fast/multicol/pagination/LeftToRightGrid-tb-expected.txt: Added.
- platform/mac/fast/multicol/pagination/RightToLeft-bt-expected.png:
- platform/mac/fast/multicol/pagination/RightToLeft-lr-expected.png:
- platform/mac/fast/multicol/pagination/RightToLeft-max-width-expected.png:
- platform/mac/fast/multicol/pagination/RightToLeft-rl-dynamic-expected.png:
- platform/mac/fast/multicol/pagination/RightToLeft-rl-expected.png:
- platform/mac/fast/multicol/pagination/RightToLeft-tb-expected.png:
- platform/mac/fast/multicol/pagination/RightToLeftGrid-bt-expected.png: Added.
- platform/mac/fast/multicol/pagination/RightToLeftGrid-bt-expected.txt: Added.
- platform/mac/fast/multicol/pagination/RightToLeftGrid-lr-expected.png: Added.
- platform/mac/fast/multicol/pagination/RightToLeftGrid-lr-expected.txt: Added.
- platform/mac/fast/multicol/pagination/RightToLeftGrid-rl-expected.png: Added.
- platform/mac/fast/multicol/pagination/RightToLeftGrid-rl-expected.txt: Added.
- platform/mac/fast/multicol/pagination/RightToLeftGrid-tb-expected.png: Added.
- platform/mac/fast/multicol/pagination/RightToLeftGrid-tb-expected.txt: Added.
- platform/mac/fast/multicol/pagination/TopToBottom-bt-expected.png:
- platform/mac/fast/multicol/pagination/TopToBottom-lr-expected.png:
- platform/mac/fast/multicol/pagination/TopToBottom-rl-expected.png:
- platform/mac/fast/multicol/pagination/TopToBottom-tb-expected.png:
- platform/mac/fast/multicol/pagination/TopToBottomGrid-bt-expected.png: Added.
- platform/mac/fast/multicol/pagination/TopToBottomGrid-bt-expected.txt: Added.
- platform/mac/fast/multicol/pagination/TopToBottomGrid-lr-expected.png: Added.
- platform/mac/fast/multicol/pagination/TopToBottomGrid-lr-expected.txt: Added.
- platform/mac/fast/multicol/pagination/TopToBottomGrid-rl-expected.png: Added.
- platform/mac/fast/multicol/pagination/TopToBottomGrid-rl-expected.txt: Added.
- platform/mac/fast/multicol/pagination/TopToBottomGrid-tb-expected.png: Added.
- platform/mac/fast/multicol/pagination/TopToBottomGrid-tb-expected.txt: Added.
- platform/mac/fast/multicol/pagination/nested-transforms-expected.png:
- 11:43 AM Changeset in webkit [196023] by
-
- 3 edits in trunk/Source/WebCore
Tab suspension code shouldn't use page cache cacheability logic
https://bugs.webkit.org/show_bug.cgi?id=153680
Reviewed by Andreas Kling.
Most of PageCache::canCache() is unnecessary for tab suspension.
Also improve robustness and introduce 1 minute delay before suspending.
- page/Page.cpp:
(WebCore::Page::setPageActivityState):
(WebCore::Page::setIsVisible):
(WebCore::Page::setIsVisibleInternal):
(WebCore::Page::setIsPrerender):
(WebCore::Page::canTabSuspend):
Include visibility test here.
Instead of calling PageCache::canCache() just check for each frame
- that the document is loaded
- that active DOM objects allow suspension
(WebCore::Page::setIsTabSuspended):
(WebCore::Page::setTabSuspensionEnabled):
(WebCore::Page::updateTabSuspensionState):
Refactor for robustness.
(WebCore::Page::tabSuspensionTimerFired):
Call canTabSuspend, the result might have changed.
(WebCore::Page::scheduleTabSuspension): Deleted.
- page/Page.h:
- 11:33 AM Changeset in webkit [196022] by
-
- 42 edits in trunk/Source
[JSC] Introduce BytecodeIntrinsic constant rep like @undefined
https://bugs.webkit.org/show_bug.cgi?id=153737
Reviewed by Darin Adler.
Source/JavaScriptCore:
This patch enhances existing BytecodeIntrinsic mechanism to accept
@xxxform,
that will be used to represent bytecode intrinsic constants.
After this change, we can use 2 forms for bytecode intrinsics. (1) Function form (like, @toString(value))
and (2) Constant form (like @undefined).
Bytecode intrinsic constants allow us to easily expose constant values from C++ world.
For example, we can expose ArrayIterationKind flags to JS world without using private global variables.
Exposed constant values are loaded from bytecodes directly through constant registers.
While previously we expose them through private global variables, bytecode intrinsic constants
can be loaded directly from CodeBlock. And later, it will become JSConstant in DFG.
And by using this mechanism, we implement several constants. @undefined, @arrayIterationKindKeyValue etc.
- builtins/ArrayConstructor.js:
(from):
- builtins/ArrayIteratorPrototype.js:
(next):
- builtins/ArrayPrototype.js:
(reduce):
(reduceRight):
(every):
(forEach):
(filter):
(map):
(some):
(fill):
(find):
(findIndex):
(includes):
(sort.compactSparse):
(sort.compactSlow):
(sort.compact):
(sort):
(copyWithin):
- builtins/DatePrototype.js:
(toLocaleString.toDateTimeOptionsAnyAll):
(toLocaleString):
(toLocaleDateString.toDateTimeOptionsDateDate):
(toLocaleDateString):
(toLocaleTimeString.toDateTimeOptionsTimeTime):
(toLocaleTimeString):
- builtins/GeneratorPrototype.js:
(generatorResume):
- builtins/GlobalObject.js:
(isDictionary):
- builtins/InternalPromiseConstructor.js:
(internalAll.newResolveElement):
(internalAll):
- builtins/IteratorPrototype.js:
(symbolIteratorGetter):
(symbolIterator): Deleted.
- builtins/MapPrototype.js:
(forEach):
- builtins/ModuleLoaderObject.js:
(newRegistryEntry):
(forceFulfillPromise):
(commitInstantiated):
(requestFetch):
(requestTranslate):
(requestInstantiate):
(requestLink):
(provide):
- builtins/PromiseConstructor.js:
(all.newResolveElement):
(all):
(race):
(reject):
(resolve):
- builtins/PromiseOperations.js:
(newPromiseCapability.executor):
(newPromiseCapability):
(rejectPromise):
(fulfillPromise):
(createResolvingFunctions.resolve):
(createResolvingFunctions.reject):
(createResolvingFunctions):
(promiseReactionJob):
(promiseResolveThenableJob):
(initializePromise):
- builtins/PromisePrototype.js:
(catch):
(then):
- builtins/SetPrototype.js:
(forEach):
- builtins/StringConstructor.js:
(raw):
- builtins/StringIteratorPrototype.js:
(next):
- builtins/StringPrototype.js:
(localeCompare):
- builtins/TypedArrayConstructor.js:
(of):
(from):
- builtins/TypedArrayPrototype.js:
(every):
(find):
(findIndex):
(forEach):
(some):
(reduce):
(reduceRight):
(map):
(filter):
- bytecode/BytecodeIntrinsicRegistry.cpp:
(JSC::BytecodeIntrinsicRegistry::BytecodeIntrinsicRegistry):
(JSC::BytecodeIntrinsicRegistry::lookup):
- bytecode/BytecodeIntrinsicRegistry.h:
- bytecompiler/NodesCodegen.cpp:
- parser/ASTBuilder.h:
(JSC::ASTBuilder::createResolve):
(JSC::ASTBuilder::makeFunctionCallNode):
- parser/NodeConstructors.h:
(JSC::BytecodeIntrinsicNode::BytecodeIntrinsicNode):
- parser/Nodes.h:
(JSC::ExpressionNode::isBytecodeIntrinsicNode):
(JSC::BytecodeIntrinsicNode::type):
(JSC::BytecodeIntrinsicNode::emitter):
- parser/Parser.cpp:
(JSC::Parser<LexerType>::parseProperty):
(JSC::Parser<LexerType>::parsePrimaryExpression):
- parser/SyntaxChecker.h:
(JSC::SyntaxChecker::createResolve):
- runtime/CommonIdentifiers.cpp:
(JSC::CommonIdentifiers::CommonIdentifiers): Deleted.
- runtime/CommonIdentifiers.h:
(JSC::CommonIdentifiers::bytecodeIntrinsicRegistry): Deleted.
- runtime/IteratorPrototype.cpp:
(JSC::IteratorPrototype::finishCreation):
- runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::init): Deleted.
- runtime/VM.cpp:
(JSC::VM::VM):
- runtime/VM.h:
(JSC::VM::bytecodeIntrinsicRegistry):
Source/WebCore:
- Modules/fetch/FetchHeaders.js:
(initializeFetchHeaders):
- Modules/streams/ReadableStream.js:
(initializeReadableStream):
(closeDestination):
(abortDestination):
(pipeTo):
- Modules/streams/ReadableStreamInternals.js:
(privateInitializeReadableStreamController):
(teeReadableStream):
(isReadableStreamReader):
(errorReadableStream):
(finishClosingReadableStream):
(enqueueInReadableStream):
(readFromReadableStreamReader):
- Modules/streams/ReadableStreamReader.js:
(releaseLock):
- Modules/streams/StreamInternals.js:
(shieldingPromiseResolve):
(promiseInvokeOrNoopNoCatch):
(promiseInvokeOrFallbackOrNoop):
(validateAndNormalizeQueuingStrategy):
- Modules/streams/WritableStream.js:
(initializeWritableStream):
(write):
- Modules/streams/WritableStreamInternals.js:
(errorWritableStream):
- 11:27 AM Changeset in webkit [196021] by
-
- 4 edits in trunk
Modern IDB: storage/indexeddb/dont-wedge.html sometimes ASSERTs.
https://bugs.webkit.org/show_bug.cgi?id=153790
Reviewed by Tim Horton.
Source/WebCore:
No new tests (Failing test now unskipped).
This test uncovered an unhandled race where the main thread tried to perform an OpenDB operation
multiple times while it was already in-progress on the server thread.
There was already a flag meant to cover this race, and it just needed to be applied to one more site.
- Modules/indexeddb/server/UniqueIDBDatabase.cpp:
(WebCore::IDBServer::UniqueIDBDatabase::performCurrentOpenOperation):
(WebCore::IDBServer::UniqueIDBDatabase::openBackingStore):
LayoutTests:
- platform/mac-wk1/TestExpectations:
- 11:10 AM Changeset in webkit [196020] by
-
- 3 edits in trunk
Unreviewed attempt to fix Mac CMake build after r195999.
- Source/cmake/OptionsMac.cmake:
- Source/cmake/WebKitFeatures.cmake:
Add ENABLE_RESOURCE_USAGE to CMake builds.
- 11:07 AM Changeset in webkit [196019] by
-
- 4 edits in trunk/Source/JavaScriptCore
[B3][Win64] Compile fixes.
https://bugs.webkit.org/show_bug.cgi?id=153605
Reviewed by Filip Pizlo.
Fix remaining compile errors on Win64.
- CMakeLists.txt:
- b3/B3CFG.h:
(JSC::B3::CFG::newMap):
- ftl/FTLJITCode.h:
- 10:52 AM Changeset in webkit [196018] by
-
- 2 edits in trunk/Source/WebInspectorUI
Uncaught Exception: TypeError: undefined is not an object (evaluating 'highlightedRange.from')
https://bugs.webkit.org/show_bug.cgi?id=153685
Reviewed by Timothy Hatcher.
- UserInterface/Controllers/CodeMirrorTokenTrackingController.js:
(WebInspector.CodeMirrorTokenTrackingController.prototype.highlightRange):
The highlighted range could have just gotten removed, in which case the
marker would return undefined. Just bail in such cases.
- 10:51 AM Changeset in webkit [196017] by
-
- 240 edits in trunk/LayoutTests
[Win] gardening after r195740.
Unreviewed.
- platform/win/tables/mozilla/marvin/x_tbody_align_left-expected.txt:
- platform/win/tables/mozilla/marvin/x_tbody_align_right-expected.txt:
- platform/win/tables/mozilla/marvin/x_tbody_class-expected.txt:
- platform/win/tables/mozilla/marvin/x_tbody_id-expected.txt:
- platform/win/tables/mozilla/marvin/x_tbody_valign_baseline-expected.txt:
- platform/win/tables/mozilla/marvin/x_tbody_valign_bottom-expected.txt:
- platform/win/tables/mozilla/marvin/x_tbody_valign_middle-expected.txt:
- platform/win/tables/mozilla/marvin/x_tbody_valign_top-expected.txt:
- platform/win/tables/mozilla/marvin/x_td_align_center-expected.txt:
- platform/win/tables/mozilla/marvin/x_td_align_char-expected.txt:
- platform/win/tables/mozilla/marvin/x_td_align_justify-expected.txt:
- platform/win/tables/mozilla/marvin/x_td_align_left-expected.txt:
- platform/win/tables/mozilla/marvin/x_td_align_right-expected.txt:
- platform/win/tables/mozilla/marvin/x_td_bgcolor_name-expected.txt:
- platform/win/tables/mozilla/marvin/x_td_bgcolor_rgb-expected.txt:
- platform/win/tables/mozilla/marvin/x_td_class-expected.txt:
- platform/win/tables/mozilla/marvin/x_td_colspan-expected.txt:
- platform/win/tables/mozilla/marvin/x_td_height-expected.txt:
- platform/win/tables/mozilla/marvin/x_td_id-expected.txt:
- platform/win/tables/mozilla/marvin/x_td_nowrap-expected.txt:
- platform/win/tables/mozilla/marvin/x_td_rowspan-expected.txt:
- platform/win/tables/mozilla/marvin/x_td_style-expected.txt:
- platform/win/tables/mozilla/marvin/x_td_valign_baseline-expected.txt:
- platform/win/tables/mozilla/marvin/x_td_valign_bottom-expected.txt:
- platform/win/tables/mozilla/marvin/x_td_valign_middle-expected.txt:
- platform/win/tables/mozilla/marvin/x_td_valign_top-expected.txt:
- platform/win/tables/mozilla/marvin/x_td_width-expected.txt:
- platform/win/tables/mozilla/marvin/x_tfoot_align_center-expected.txt:
- platform/win/tables/mozilla/marvin/x_tfoot_align_char-expected.txt:
- platform/win/tables/mozilla/marvin/x_tfoot_align_left-expected.txt:
- platform/win/tables/mozilla/marvin/x_tfoot_align_right-expected.txt:
- platform/win/tables/mozilla/marvin/x_tfoot_class-expected.txt:
- platform/win/tables/mozilla/marvin/x_tfoot_id-expected.txt:
- platform/win/tables/mozilla/marvin/x_tfoot_style-expected.txt:
- platform/win/tables/mozilla/marvin/x_tfoot_valign_baseline-expected.txt:
- platform/win/tables/mozilla/marvin/x_tfoot_valign_bottom-expected.txt:
- platform/win/tables/mozilla/marvin/x_tfoot_valign_middle-expected.txt:
- platform/win/tables/mozilla/marvin/x_tfoot_valign_top-expected.txt:
- platform/win/tables/mozilla/marvin/x_th_align_center-expected.txt:
- platform/win/tables/mozilla/marvin/x_th_align_char-expected.txt:
- platform/win/tables/mozilla/marvin/x_th_align_justify-expected.txt:
- platform/win/tables/mozilla/marvin/x_th_align_left-expected.txt:
- platform/win/tables/mozilla/marvin/x_th_align_right-expected.txt:
- platform/win/tables/mozilla/marvin/x_th_bgcolor_name-expected.txt:
- platform/win/tables/mozilla/marvin/x_th_bgcolor_rgb-expected.txt:
- platform/win/tables/mozilla/marvin/x_th_class-expected.txt:
- platform/win/tables/mozilla/marvin/x_th_colspan-expected.txt:
- platform/win/tables/mozilla/marvin/x_th_height-expected.txt:
- platform/win/tables/mozilla/marvin/x_th_id-expected.txt:
- platform/win/tables/mozilla/marvin/x_th_nowrap-expected.txt:
- platform/win/tables/mozilla/marvin/x_th_rowspan-expected.txt:
- platform/win/tables/mozilla/marvin/x_th_style-expected.txt:
- platform/win/tables/mozilla/marvin/x_th_valign_baseline-expected.txt:
- platform/win/tables/mozilla/marvin/x_th_valign_bottom-expected.txt:
- platform/win/tables/mozilla/marvin/x_th_valign_middle-expected.txt:
- platform/win/tables/mozilla/marvin/x_th_valign_top-expected.txt:
- platform/win/tables/mozilla/marvin/x_th_width-expected.txt:
- platform/win/tables/mozilla/marvin/x_thead_align_center-expected.txt:
- platform/win/tables/mozilla/marvin/x_thead_align_char-expected.txt:
- platform/win/tables/mozilla/marvin/x_thead_align_left-expected.txt:
- platform/win/tables/mozilla/marvin/x_thead_align_right-expected.txt:
- platform/win/tables/mozilla/marvin/x_thead_class-expected.txt:
- platform/win/tables/mozilla/marvin/x_thead_id-expected.txt:
- platform/win/tables/mozilla/marvin/x_thead_style-expected.txt:
- platform/win/tables/mozilla/marvin/x_thead_valign_baseline-expected.txt:
- platform/win/tables/mozilla/marvin/x_thead_valign_bottom-expected.txt:
- platform/win/tables/mozilla/marvin/x_thead_valign_middle-expected.txt:
- platform/win/tables/mozilla/marvin/x_thead_valign_top-expected.txt:
- platform/win/tables/mozilla/marvin/x_tr_align_char-expected.txt:
- platform/win/tables/mozilla/marvin/x_tr_bgcolor_name-expected.txt:
- platform/win/tables/mozilla/marvin/x_tr_bgcolor_rgb-expected.txt:
- platform/win/tables/mozilla/marvin/x_tr_class-expected.txt:
- platform/win/tables/mozilla/marvin/x_tr_id-expected.txt:
- platform/win/tables/mozilla/marvin/x_tr_style-expected.txt:
- platform/win/tables/mozilla/marvin/x_tr_valign_baseline-expected.txt:
- platform/win/tables/mozilla/marvin/x_tr_valign_bottom-expected.txt:
- platform/win/tables/mozilla/marvin/x_tr_valign_middle-expected.txt:
- platform/win/tables/mozilla/marvin/x_tr_valign_top-expected.txt:
- platform/win/tables/mozilla/other/body_col-expected.txt:
- platform/win/tables/mozilla/other/cell_widths-expected.txt:
- platform/win/tables/mozilla/other/cellspacing-expected.txt:
- platform/win/tables/mozilla/other/move_row-expected.txt:
- platform/win/tables/mozilla/other/ms-expected.txt:
- platform/win/tables/mozilla/other/nested2-expected.txt:
- platform/win/tables/mozilla/other/nestedTables-expected.txt:
- platform/win/tables/mozilla/other/padding-expected.txt:
- platform/win/tables/mozilla/other/slashlogo-expected.txt:
- platform/win/tables/mozilla/other/test3-expected.txt:
- platform/win/tables/mozilla/other/test6-expected.txt:
- platform/win/tables/mozilla/other/wa_table_thtd_rowspan-expected.txt:
- platform/win/tables/mozilla/other/wa_table_tr_align-expected.txt:
- platform/win/tables/mozilla_expected_failures/bugs/97619-expected.txt:
- platform/win/tables/mozilla_expected_failures/bugs/bug1010-expected.txt:
- platform/win/tables/mozilla_expected_failures/bugs/bug10140-expected.txt:
- platform/win/tables/mozilla_expected_failures/bugs/bug101759-expected.txt:
- platform/win/tables/mozilla_expected_failures/bugs/bug10216-expected.txt:
- platform/win/tables/mozilla_expected_failures/bugs/bug104898-expected.txt:
- platform/win/tables/mozilla_expected_failures/bugs/bug1055-2-expected.txt:
- platform/win/tables/mozilla_expected_failures/bugs/bug106336-expected.txt:
- platform/win/tables/mozilla_expected_failures/bugs/bug1128-expected.txt:
- platform/win/tables/mozilla_expected_failures/bugs/bug1164-expected.txt:
- platform/win/tables/mozilla_expected_failures/bugs/bug11945-expected.txt:
- platform/win/tables/mozilla_expected_failures/bugs/bug128876-expected.txt:
- platform/win/tables/mozilla_expected_failures/bugs/bug131020-3-expected.txt:
- platform/win/tables/mozilla_expected_failures/bugs/bug14007-1-expected.txt:
- platform/win/tables/mozilla_expected_failures/bugs/bug14007-2-expected.txt:
- platform/win/tables/mozilla_expected_failures/bugs/bug14159-2-expected.txt:
- platform/win/tables/mozilla_expected_failures/bugs/bug1647-expected.txt:
- platform/win/tables/mozilla_expected_failures/bugs/bug1725-expected.txt:
- platform/win/tables/mozilla_expected_failures/bugs/bug17826-expected.txt:
- platform/win/tables/mozilla_expected_failures/bugs/bug178855-expected.txt:
- platform/win/tables/mozilla_expected_failures/bugs/bug18770-expected.txt:
- platform/win/tables/mozilla_expected_failures/bugs/bug21518-expected.txt:
- platform/win/tables/mozilla_expected_failures/bugs/bug22122-expected.txt:
- platform/win/tables/mozilla_expected_failures/bugs/bug23847-expected.txt:
- platform/win/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt:
- platform/win/tables/mozilla_expected_failures/bugs/bug24880-1-expected.txt:
- platform/win/tables/mozilla_expected_failures/bugs/bug25707-expected.txt:
- platform/win/tables/mozilla_expected_failures/bugs/bug27993-2-expected.txt:
- platform/win/tables/mozilla_expected_failures/bugs/bug29058-2-expected.txt:
- platform/win/tables/mozilla_expected_failures/bugs/bug3105-expected.txt:
- platform/win/tables/mozilla_expected_failures/bugs/bug3166-11-expected.txt:
- platform/win/tables/mozilla_expected_failures/bugs/bug3166-12-expected.txt:
- platform/win/tables/mozilla_expected_failures/bugs/bug3166-13-expected.txt:
- platform/win/tables/mozilla_expected_failures/bugs/bug3166-14-expected.txt:
- platform/win/tables/mozilla_expected_failures/bugs/bug3166-16-expected.txt:
- platform/win/tables/mozilla_expected_failures/bugs/bug3166-17-expected.txt:
- platform/win/tables/mozilla_expected_failures/bugs/bug3166-18-expected.txt:
- platform/win/tables/mozilla_expected_failures/bugs/bug32205-1-expected.txt:
- platform/win/tables/mozilla_expected_failures/bugs/bug32205-4-expected.txt:
- platform/win/tables/mozilla_expected_failures/bugs/bug4294-expected.txt:
- platform/win/tables/mozilla_expected_failures/bugs/bug46268-4-expected.txt:
- platform/win/tables/mozilla_expected_failures/bugs/bug51000-expected.txt:
- platform/win/tables/mozilla_expected_failures/bugs/bug56024-expected.txt:
- platform/win/tables/mozilla_expected_failures/bugs/bug58402-2-expected.txt:
- platform/win/tables/mozilla_expected_failures/bugs/bug59252-expected.txt:
- platform/win/tables/mozilla_expected_failures/bugs/bug65372-expected.txt:
- platform/win/tables/mozilla_expected_failures/bugs/bug6933-expected.txt:
- platform/win/tables/mozilla_expected_failures/bugs/bug7113-expected.txt:
- platform/win/tables/mozilla_expected_failures/bugs/bug7121-2-expected.txt:
- platform/win/tables/mozilla_expected_failures/bugs/bug72393-expected.txt:
- platform/win/tables/mozilla_expected_failures/bugs/bug7243-expected.txt:
- platform/win/tables/mozilla_expected_failures/bugs/bug73629-expected.txt:
- platform/win/tables/mozilla_expected_failures/bugs/bug80762-2-expected.txt:
- platform/win/tables/mozilla_expected_failures/bugs/bug8499-expected.txt:
- platform/win/tables/mozilla_expected_failures/bugs/bug85016-expected.txt:
- platform/win/tables/mozilla_expected_failures/bugs/bug89315-expected.txt:
- platform/win/tables/mozilla_expected_failures/bugs/bug91057-expected.txt:
- platform/win/tables/mozilla_expected_failures/bugs/bug92647-1-expected.txt:
- platform/win/tables/mozilla_expected_failures/bugs/bug92868_1-expected.txt:
- platform/win/tables/mozilla_expected_failures/bugs/bug9879-1-expected.txt:
- platform/win/tables/mozilla_expected_failures/collapsing_borders/bug41262-1-expected.txt:
- platform/win/tables/mozilla_expected_failures/collapsing_borders/bug41262-5-expected.txt:
- platform/win/tables/mozilla_expected_failures/collapsing_borders/bug41262-6-expected.txt:
- platform/win/tables/mozilla_expected_failures/core/backgrounds-expected.txt:
- platform/win/tables/mozilla_expected_failures/core/captions1-expected.txt:
- platform/win/tables/mozilla_expected_failures/core/captions2-expected.txt:
- platform/win/tables/mozilla_expected_failures/core/captions3-expected.txt:
- platform/win/tables/mozilla_expected_failures/core/col_span2-expected.txt:
- platform/win/tables/mozilla_expected_failures/core/cols1-expected.txt:
- platform/win/tables/mozilla_expected_failures/core/columns-expected.txt:
- platform/win/tables/mozilla_expected_failures/core/conflicts-expected.txt:
- platform/win/tables/mozilla_expected_failures/core/standards1-expected.txt:
- platform/win/tables/mozilla_expected_failures/dom/appendCells1-expected.txt:
- platform/win/tables/mozilla_expected_failures/dom/appendCellsRebuild1-expected.txt:
- platform/win/tables/mozilla_expected_failures/dom/appendCol1-expected.txt:
- platform/win/tables/mozilla_expected_failures/dom/appendColGroup1-expected.txt:
- platform/win/tables/mozilla_expected_failures/dom/insertTbodyExpand1-expected.txt:
- platform/win/tables/mozilla_expected_failures/dom/insertTbodyRebuild1-expected.txt:
- platform/win/tables/mozilla_expected_failures/marvin/backgr_border-table-cell-expected.txt:
- platform/win/tables/mozilla_expected_failures/marvin/backgr_border-table-column-expected.txt:
- platform/win/tables/mozilla_expected_failures/marvin/backgr_border-table-column-group-expected.txt:
- platform/win/tables/mozilla_expected_failures/marvin/backgr_border-table-expected.txt:
- platform/win/tables/mozilla_expected_failures/marvin/backgr_border-table-quirks-expected.txt:
- platform/win/tables/mozilla_expected_failures/marvin/backgr_border-table-row-expected.txt:
- platform/win/tables/mozilla_expected_failures/marvin/backgr_border-table-row-group-expected.txt:
- platform/win/tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.txt:
- platform/win/tables/mozilla_expected_failures/marvin/backgr_layers-hide-expected.txt:
- platform/win/tables/mozilla_expected_failures/marvin/backgr_layers-show-expected.txt:
- platform/win/tables/mozilla_expected_failures/marvin/backgr_position-table-cell-expected.txt:
- platform/win/tables/mozilla_expected_failures/marvin/backgr_position-table-column-expected.txt:
- platform/win/tables/mozilla_expected_failures/marvin/backgr_position-table-column-group-expected.txt:
- platform/win/tables/mozilla_expected_failures/marvin/backgr_position-table-row-expected.txt:
- platform/win/tables/mozilla_expected_failures/marvin/backgr_position-table-row-group-expected.txt:
- platform/win/tables/mozilla_expected_failures/marvin/table_frame_above-expected.txt:
- platform/win/tables/mozilla_expected_failures/marvin/table_frame_below-expected.txt:
- platform/win/tables/mozilla_expected_failures/marvin/table_frame_hsides-expected.txt:
- platform/win/tables/mozilla_expected_failures/marvin/table_frame_lhs-expected.txt:
- platform/win/tables/mozilla_expected_failures/marvin/table_frame_rhs-expected.txt:
- platform/win/tables/mozilla_expected_failures/marvin/table_frame_void-expected.txt:
- platform/win/tables/mozilla_expected_failures/marvin/table_frame_vsides-expected.txt:
- platform/win/tables/mozilla_expected_failures/marvin/table_overflow_caption-expected.txt:
- platform/win/tables/mozilla_expected_failures/marvin/table_overflow_caption_bottom-expected.txt:
- platform/win/tables/mozilla_expected_failures/marvin/table_overflow_caption_hidden-expected.txt:
- platform/win/tables/mozilla_expected_failures/marvin/table_overflow_caption_hidden_table-expected.txt:
- platform/win/tables/mozilla_expected_failures/marvin/table_overflow_caption_left-expected.txt:
- platform/win/tables/mozilla_expected_failures/marvin/table_overflow_caption_right-expected.txt:
- platform/win/tables/mozilla_expected_failures/marvin/table_overflow_caption_top-expected.txt:
- platform/win/tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow-expected.txt:
- platform/win/tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow_row-expected.txt:
- platform/win/tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow_table-expected.txt:
- platform/win/tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow_tbody-expected.txt:
- platform/win/tables/mozilla_expected_failures/marvin/table_overflow_hidden_table-expected.txt:
- platform/win/tables/mozilla_expected_failures/marvin/table_overflow_hidden_tbody-expected.txt:
- platform/win/tables/mozilla_expected_failures/marvin/table_overflow_hidden_tr-expected.txt:
- platform/win/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_cell-expected.txt:
- platform/win/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_cell_sibling-expected.txt:
- platform/win/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_row-expected.txt:
- platform/win/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_row_sibling-expected.txt:
- platform/win/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_table-expected.txt:
- platform/win/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_table_caption-expected.txt:
- platform/win/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_tbody-expected.txt:
- platform/win/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_tbody_sibling-expected.txt:
- platform/win/tables/mozilla_expected_failures/marvin/table_overflow_td_align_right-expected.txt:
- platform/win/tables/mozilla_expected_failures/marvin/table_overflow_td_dynamic_deactivate-expected.txt:
- platform/win/tables/mozilla_expected_failures/marvin/table_overflow_td_valign_bottom-expected.txt:
- platform/win/tables/mozilla_expected_failures/marvin/table_overflow_td_valign_middle-expected.txt:
- platform/win/tables/mozilla_expected_failures/marvin/table_overflow_td_valign_top-expected.txt:
- platform/win/tables/mozilla_expected_failures/marvin/table_rules_cols-expected.txt:
- platform/win/tables/mozilla_expected_failures/marvin/table_rules_rows-expected.txt:
- platform/win/tables/mozilla_expected_failures/marvin/tables_caption_align_left-expected.txt:
- platform/win/tables/mozilla_expected_failures/marvin/tables_caption_align_right-expected.txt:
- platform/win/tables/mozilla_expected_failures/marvin/tables_cellspacing_pct-expected.txt:
- platform/win/tables/mozilla_expected_failures/marvin/x_caption_align_left-expected.txt:
- platform/win/tables/mozilla_expected_failures/marvin/x_caption_align_right-expected.txt:
- platform/win/tables/mozilla_expected_failures/marvin/x_colgroup_width_px-expected.txt:
- platform/win/tables/mozilla_expected_failures/marvin/x_table_frame_above-expected.txt:
- platform/win/tables/mozilla_expected_failures/marvin/x_table_frame_below-expected.txt:
- platform/win/tables/mozilla_expected_failures/marvin/x_table_frame_border-expected.txt:
- platform/win/tables/mozilla_expected_failures/marvin/x_table_frame_box-expected.txt:
- platform/win/tables/mozilla_expected_failures/marvin/x_table_frame_hsides-expected.txt:
- platform/win/tables/mozilla_expected_failures/marvin/x_table_frame_lhs-expected.txt:
- platform/win/tables/mozilla_expected_failures/marvin/x_table_frame_rhs-expected.txt:
- platform/win/tables/mozilla_expected_failures/marvin/x_table_frame_vsides-expected.txt:
- platform/win/tables/mozilla_expected_failures/marvin/x_table_rules_all-expected.txt:
- platform/win/tables/mozilla_expected_failures/marvin/x_table_rules_cols-expected.txt:
- platform/win/tables/mozilla_expected_failures/marvin/x_table_rules_rows-expected.txt:
- platform/win/tables/mozilla_expected_failures/other/empty_cells-expected.txt:
- platform/win/tables/mozilla_expected_failures/other/test4-expected.txt:
- 10:24 AM Changeset in webkit [196016] by
-
- 5 edits in tags/Safari-602.1.18.2
Merged r195968. rdar://problem/24434627
- 10:23 AM Changeset in webkit [196015] by
-
- 5 edits in tags/Safari-602.1.18.2/Source
Versioning.
- 10:19 AM Changeset in webkit [196014] by
-
- 1 copy in tags/Safari-602.1.18.2
New tag.
- 10:06 AM Changeset in webkit [196013] by
-
- 6 edits in trunk
Layout Test fast/parser/external-entities-in-xslt.xml is flaky on El Capitan (but fails most of the time)
https://bugs.webkit.org/show_bug.cgi?id=153683
Reviewed by Alexey Proskuryakov.
Tools:
Ensure that XML_CATALOG_FILES is set in the Web Content service’s environment as well.
- Scripts/webkitpy/port/driver.py:
(Driver._setup_environ_for_driver): Also set XPC_DUMPRENDERTREE_TEMP.
- Scripts/webkitpy/port/ios.py:
(IOSSimulatorPort.setup_environ_for_server): Set XPC_XML_CATALOG_FILES.
- Scripts/webkitpy/port/mac.py:
(MacPort.setup_environ_for_server): Ditto.
LayoutTests:
- platform/mac/TestExpectations: Removed the failure expectation for this test.
- 9:57 AM Changeset in webkit [196012] by
-
- 5 edits in trunk/Source/WebCore
CSP: Support checking content security policy without a script execution context
https://bugs.webkit.org/show_bug.cgi?id=153748
<rdar://problem/24439149>
Reviewed by Darin Alder.
Towards checking a Web Worker's content security policy against a redirected worker
script load or redirected XHR request for an XHR request initiated from it, we should
support instantiating a ContentSecurityPolicy object without a ScriptExecutionContext.
No functionality was changed. So, no new tests.
- dom/Document.cpp:
(WebCore::Document::initSecurityContext): Pass |this| as a reference instead of as a pointer.
- page/csp/ContentSecurityPolicy.cpp: Remove extraneous includes ScriptState.h, TextEncoding.h,
and URL.h as they are included by ContentSecurityPolicy.h, FormDataList.h and FormData.h, respectively.
(WebCore::CSPSource::CSPSource): Take a constant reference to a ContentSecurityPolicy instead
of a pointer since we never expected a null pointer.
(WebCore::CSPSource::schemeMatches): Move logic for checking the protocol of source "self"
from here to ContentSecurityPolicy::protocolMatchesSelf() because we may not have a security
origin if ContentSecurityPolicy was initiated without a ScriptExecutionContext object.
(WebCore::CSPSourceList::allowSelf): Added.
(WebCore::CSPSourceList::CSPSourceList): Take a constant reference to a ContentSecurityPolicy
instead of a pointer since we never expected a null pointer. Remove fields from member
initialization list that can be initialized using C++11 in-class initialization syntax.
(WebCore::CSPSourceList::matches): Call ContentSecurityPolicy::urlMatchesSelf() to match the
effective URL against the URL of source "self".
(WebCore::CSPSourceList::parse): Update code as necessary now that m_policy is a reference
instead of a pointer.
(WebCore::CSPSourceList::parseSource): Simplify code by setting internal member fields directly
instead of via member functions.
(WebCore::CSPSourceList::parsePath): Update code as necessary now that m_policy is a reference
instead of a pointer.
(WebCore::CSPDirective::CSPDirective): Take a constant reference to a ContentSecurityPolicy
instead of a pointer since we never expected a null pointer.
(WebCore::CSPDirective::policy): Return a reference to a const ContentSecurityPolicy.
(WebCore::MediaListDirective::MediaListDirective): Take a constant reference to a ContentSecurityPolicy
instead of a pointer since we never expected a null pointer.
(WebCore::MediaListDirective::parse): Update code as necessary now that m_policy is a reference
instead of a pointer.
(WebCore::SourceListDirective::SourceListDirective): Take a constant reference to a ContentSecurityPolicy
instead of a pointer since we never expected a null pointer.
(WebCore::SourceListDirective::allows): Write in terms of CSPSourceList::allowSelf() because we
may not have a security origin to get a URL from if ContentSecurityPolicy was initiated without
a ScriptExecutionContext object.
(WebCore::CSPDirectiveList::reportURIs): Change return type from Vector<URL> to Vector<String>
The caller will convert the strings to URLs with respect to the script execution context.
(WebCore::CSPDirectiveList::parseReportURI): Store the report URI as a string instead of a URL
because we may not have a security origin to compute the absolute URL if ContentSecurityPolicy
was initiated without a ScriptExecutionContext object.
(WebCore::CSPDirectiveList::CSPDirectiveList): Take a reference to a ContentSecurityPolicy
instead of a pointer since we never expected a null pointer. It would be better to take a const
reference to a ContentSecurityPolicy, but ContentSecurityPolicy::applySandboxPolicy() needs to set
state on ContentSecurityPolicy :(
(WebCore::CSPDirectiveList::create): Ditto.
(WebCore::CSPDirectiveList::reportViolation): Update code as necessary now that m_policy is a reference
instead of a pointer.
(WebCore::CSPDirectiveList::checkEvalAndReportViolation): Ditto.
(WebCore::CSPDirectiveList::checkInlineAndReportViolation): Ditto.
(WebCore::CSPDirectiveList::parseDirective): Ditto.
(WebCore::CSPDirectiveList::parseReportURI): Store the report URI as a string instead of a URL
because we may not have a security origin to compute the absolute URL if ContentSecurityPolicy
was initiated without a ScriptExecutionContext object.
(WebCore::CSPDirectiveList::setCSPDirective): Update code as necessary now that m_policy is a reference
instead of a pointer.
(WebCore::CSPDirectiveList::applySandboxPolicy): Ditto.
(WebCore::CSPDirectiveList::parseReflectedXSS): Ditto.
(WebCore::CSPDirectiveList::addDirective): Ditto.
(WebCore::ContentSecurityPolicy::ContentSecurityPolicy): Modified to take the ScriptExecutionObject
as a reference and compute the CSPSource object for "self" and cache the protocol for "self". Removed
field m_overrideInlineStyleAllowed from the member initialization list and used C++11 in-class
initialization syntax to initialize it. Added overloaded constructor that takes a SecurityOrigin object.
We are not making use of this overloaded constructor at this time. We will in a subsequent patch.
(WebCore::ContentSecurityPolicy::didReceiveHeader): Store the eval disabled error message for
the last parsed policy in a member field instead of using it as part of disabling eval execution
on the script execution context because we may not have such a context.
(WebCore::ContentSecurityPolicy::applyPolicyToScriptExecutionContext): Applies the content security
policy eval and sandbox restrictions to the script execution context.
(WebCore::ContentSecurityPolicy::urlMatchesSelf): Match the specified URL against the URL for
source "self".
(WebCore::ContentSecurityPolicy::protocolMatchesSelf): Match the protocol of the specified URL
against the protocol for source "self".
(WebCore::ContentSecurityPolicy::gatherReportURIs): Modified to use the script execution context
to compute the absolute URL for each report URI.
(WebCore::ContentSecurityPolicy::reportViolation): Bail out if we do not have a script execution
context.
(WebCore::ContentSecurityPolicy::logToConsole): Only log to the console if we have a script
execution context.
(WebCore::ContentSecurityPolicy::reportBlockedScriptExecutionToInspector): Only report blocked
script execution to the Web Inspector if we have a script execution context.
(WebCore::CSPSourceList::addSourceSelf): Deleted.
(WebCore::CSPSourceList::addSourceStar): Deleted.
(WebCore::CSPSourceList::addSourceUnsafeInline): Deleted.
(WebCore::CSPSourceList::addSourceUnsafeEval): Deleted.
(WebCore::CSPDirectiveList::gatherReportURIs): Deleted.
(WebCore::ContentSecurityPolicy::securityOrigin): Deleted.
(WebCore::ContentSecurityPolicy::url): Deleted.
(WebCore::ContentSecurityPolicy::completeURL): Deleted.
(WebCore::ContentSecurityPolicy::enforceSandboxFlags): Deleted.
- page/csp/ContentSecurityPolicy.h:
(WebCore::ContentSecurityPolicy::enforceSandboxFlags): Accumulates the parsed sandbox flags. We
will apply the sandbox flags in ContentSecurityPolicy::applyPolicyToScriptExecutionContext().
- workers/WorkerGlobalScope.cpp:
(WebCore::WorkerGlobalScope::WorkerGlobalScope): Instantiate ContentSecurityPolicy.
(WebCore::WorkerGlobalScope::applyContentSecurityPolicyResponseHeaders): Move instantiation of
ContentSecurityPolicy from here to constructor.
- 8:58 AM Changeset in webkit [196011] by
-
- 2 edits in trunk/Websites/webkit.org
Minor fixes for B3 IR documentation
https://bugs.webkit.org/show_bug.cgi?id=153782
Reviewed by Michael Saboff.
Fix minor issues that Geoff found.
- docs/b3/intermediate-representation.html:
- 8:38 AM Changeset in webkit [196010] by
-
- 14 edits2 adds in trunk
Allow ports to disable automatic text track selection
https://bugs.webkit.org/show_bug.cgi?id=153761
<rdar://problem/24416768>
Reviewed by Darin Adler.
Source/WebCore:
Test: media/track/track-manual-mode.html
- Modules/mediacontrols/MediaControlsHost.cpp:
(WebCore::MediaControlsHost::manualKeyword): New.
(WebCore::MediaControlsHost::captionDisplayMode): Support 'manual' mode.
- Modules/mediacontrols/MediaControlsHost.h:
- Modules/mediacontrols/mediaControlsApple.js:
(Controller.prototype.buildCaptionMenu): Check the 'off' item when in manual mode.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::addTextTrack): Update m_captionDisplayMode when called for the first
time so it is always correct. Set the track's manual selection mode as appropriate.
(WebCore::HTMLMediaElement::captionPreferencesChanged): Set each track's manual selection
mode as appropriate.
- html/track/TextTrack.cpp:
(WebCore::TextTrack::kind): Return 'subtitles' for forced tracks when in manual mode.
- html/track/TextTrack.h:
- html/track/TrackBase.h:
(WebCore::TrackBase::kind): Make virtual.
- page/CaptionUserPreferences.cpp:
(WebCore::CaptionUserPreferences::beginBlockingNotifications): New.
(WebCore::CaptionUserPreferences::endBlockingNotifications): Ditto.
(WebCore::CaptionUserPreferences::notify): Don't notify when blocked.
- page/CaptionUserPreferences.h:
- page/CaptionUserPreferencesMediaAF.cpp:
(WebCore::CaptionUserPreferencesMediaAF::CaptionUserPreferencesMediaAF): Set manual mode
when appropriate.
(WebCore::CaptionUserPreferencesMediaAF::captionDisplayMode): Check manual mode.
(WebCore::CaptionUserPreferencesMediaAF::setCaptionDisplayMode): Ditto.
(WebCore::CaptionUserPreferencesMediaAF::setPreferredLanguage): Ditto.
(WebCore::CaptionUserPreferencesMediaAF::textTrackSelectionScore): Return zero when in manual mode.
(WebCore::CaptionUserPreferencesMediaAF::sortedTrackListForMenu): Consider manual mode. Fix
typos in logging.
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::mediaDescriptionForKind): Return 'auxiliary' when in manual mode.
- testing/Internals.cpp:
(WebCore::Internals::setCaptionDisplayMode): Support manual mode.
LayoutTests:
- media/track/track-manual-mode-expected.txt: Added.
- media/track/track-manual-mode.html: Added.
- 8:16 AM Changeset in webkit [196009] by
-
- 2 edits in trunk/Source/WebCore
REGRESSION(r195899): ASSERTION FAILED: is<Target>(source) in EventPath::retargetTouch() since r195899
https://bugs.webkit.org/show_bug.cgi?id=153741
Patch by Adrien Plazas <aplazas@igalia.com> on 2016-02-02
Reviewed by Ryosuke Niwa.
- dom/EventDispatcher.cpp:
(WebCore::EventPath::retargetTouch):
- 8:11 AM Changeset in webkit [196008] by
-
- 421 edits in trunk/LayoutTests
[Win] gardening after r195740. (more to follow)
Unreviewed.
- platform/win/tables/mozilla/bugs/bug101201-expected.txt:
- platform/win/tables/mozilla/bugs/bug101674-expected.txt:
- platform/win/tables/mozilla/bugs/bug103533-expected.txt:
- platform/win/tables/mozilla/bugs/bug106158-1-expected.txt:
- platform/win/tables/mozilla/bugs/bug106795-expected.txt:
- platform/win/tables/mozilla/bugs/bug106816-expected.txt:
- platform/win/tables/mozilla/bugs/bug108340-expected.txt:
- platform/win/tables/mozilla/bugs/bug110566-expected.txt:
- platform/win/tables/mozilla/bugs/bug113235-1-expected.txt:
- platform/win/tables/mozilla/bugs/bug113235-3-expected.txt:
- platform/win/tables/mozilla/bugs/bug113424-expected.txt:
- platform/win/tables/mozilla/bugs/bug119786-expected.txt:
- platform/win/tables/mozilla/bugs/bug120107-expected.txt:
- platform/win/tables/mozilla/bugs/bug120364-expected.txt:
- platform/win/tables/mozilla/bugs/bug133756-1-expected.txt:
- platform/win/tables/mozilla/bugs/bug133756-2-expected.txt:
- platform/win/tables/mozilla/bugs/bug137388-1-expected.txt:
- platform/win/tables/mozilla/bugs/bug137388-2-expected.txt:
- platform/win/tables/mozilla/bugs/bug137388-3-expected.txt:
- platform/win/tables/mozilla/bugs/bug138725-expected.txt:
- platform/win/tables/mozilla/bugs/bug139524-1-expected.txt:
- platform/win/tables/mozilla/bugs/bug139524-2-expected.txt:
- platform/win/tables/mozilla/bugs/bug139524-3-expected.txt:
- platform/win/tables/mozilla/bugs/bug139524-4-expected.txt:
- platform/win/tables/mozilla/bugs/bug149275-2-expected.txt:
- platform/win/tables/mozilla/bugs/bug154780-expected.txt:
- platform/win/tables/mozilla/bugs/bug159108-expected.txt:
- platform/win/tables/mozilla/bugs/bug175455-4-expected.txt:
- platform/win/tables/mozilla/bugs/bug20579-expected.txt:
- platform/win/tables/mozilla/bugs/bug20804-expected.txt:
- platform/win/tables/mozilla/bugs/bug21299-expected.txt:
- platform/win/tables/mozilla/bugs/bug215629-expected.txt:
- platform/win/tables/mozilla/bugs/bug21918-expected.txt:
- platform/win/tables/mozilla/bugs/bug219693-1-expected.txt:
- platform/win/tables/mozilla/bugs/bug219693-2-expected.txt:
- platform/win/tables/mozilla/bugs/bug22019-expected.txt:
- platform/win/tables/mozilla/bugs/bug220536-expected.txt:
- platform/win/tables/mozilla/bugs/bug221784-1-expected.txt:
- platform/win/tables/mozilla/bugs/bug221784-2-expected.txt:
- platform/win/tables/mozilla/bugs/bug222336-expected.txt:
- platform/win/tables/mozilla/bugs/bug22246-2-expected.txt:
- platform/win/tables/mozilla/bugs/bug22246-2a-expected.txt:
- platform/win/tables/mozilla/bugs/bug22246-3-expected.txt:
- platform/win/tables/mozilla/bugs/bug22246-3a-expected.txt:
- platform/win/tables/mozilla/bugs/bug22513-expected.txt:
- platform/win/tables/mozilla/bugs/bug23072-expected.txt:
- platform/win/tables/mozilla/bugs/bug23151-expected.txt:
- platform/win/tables/mozilla/bugs/bug23235-expected.txt:
- platform/win/tables/mozilla/bugs/bug23299-expected.txt:
- platform/win/tables/mozilla/bugs/bug24200-expected.txt:
- platform/win/tables/mozilla/bugs/bug24503-expected.txt:
- platform/win/tables/mozilla/bugs/bug24627-expected.txt:
- platform/win/tables/mozilla/bugs/bug24880-expected.txt:
- platform/win/tables/mozilla/bugs/bug25004-expected.txt:
- platform/win/tables/mozilla/bugs/bug25074-expected.txt:
- platform/win/tables/mozilla/bugs/bug25086-expected.txt:
- platform/win/tables/mozilla/bugs/bug25367-expected.txt:
- platform/win/tables/mozilla/bugs/bug25663-expected.txt:
- platform/win/tables/mozilla/bugs/bug26178-expected.txt:
- platform/win/tables/mozilla/bugs/bug26553-expected.txt:
- platform/win/tables/mozilla/bugs/bug269566-expected.txt:
- platform/win/tables/mozilla/bugs/bug27038-1-expected.txt:
- platform/win/tables/mozilla/bugs/bug27038-2-expected.txt:
- platform/win/tables/mozilla/bugs/bug275625-expected.txt:
- platform/win/tables/mozilla/bugs/bug277062-expected.txt:
- platform/win/tables/mozilla/bugs/bug278266-expected.txt:
- platform/win/tables/mozilla/bugs/bug278385-expected.txt:
- platform/win/tables/mozilla/bugs/bug27993-1-expected.txt:
- platform/win/tables/mozilla/bugs/bug28928-expected.txt:
- platform/win/tables/mozilla/bugs/bug28933-expected.txt:
- platform/win/tables/mozilla/bugs/bug29058-1-expected.txt:
- platform/win/tables/mozilla/bugs/bug29157-expected.txt:
- platform/win/tables/mozilla/bugs/bug29314-expected.txt:
- platform/win/tables/mozilla/bugs/bug29429-expected.txt:
- platform/win/tables/mozilla/bugs/bug30273-expected.txt:
- platform/win/tables/mozilla/bugs/bug30418-expected.txt:
- platform/win/tables/mozilla/bugs/bug30559-expected.txt:
- platform/win/tables/mozilla/bugs/bug30985-expected.txt:
- platform/win/tables/mozilla/bugs/bug32205-2-expected.txt:
- platform/win/tables/mozilla/bugs/bug32205-3-expected.txt:
- platform/win/tables/mozilla/bugs/bug32205-5-expected.txt:
- platform/win/tables/mozilla/bugs/bug32447-expected.txt:
- platform/win/tables/mozilla/bugs/bug33137-expected.txt:
- platform/win/tables/mozilla/bugs/bug33855-expected.txt:
- platform/win/tables/mozilla/bugs/bug34538-expected.txt:
- platform/win/tables/mozilla/bugs/bug35662-expected.txt:
- platform/win/tables/mozilla/bugs/bug38916-expected.txt:
- platform/win/tables/mozilla/bugs/bug39209-expected.txt:
- platform/win/tables/mozilla/bugs/bug40828-expected.txt:
- platform/win/tables/mozilla/bugs/bug42187-expected.txt:
- platform/win/tables/mozilla/bugs/bug44505-expected.txt:
- platform/win/tables/mozilla/bugs/bug44523-expected.txt:
- platform/win/tables/mozilla/bugs/bug45055-expected.txt:
- platform/win/tables/mozilla/bugs/bug45350-expected.txt:
- platform/win/tables/mozilla/bugs/bug45486-expected.txt:
- platform/win/tables/mozilla/bugs/bug46268-1-expected.txt:
- platform/win/tables/mozilla/bugs/bug46268-2-expected.txt:
- platform/win/tables/mozilla/bugs/bug46268-3-expected.txt:
- platform/win/tables/mozilla/bugs/bug46268-5-expected.txt:
- platform/win/tables/mozilla/bugs/bug46268-expected.txt:
- platform/win/tables/mozilla/bugs/bug46368-1-expected.txt:
- platform/win/tables/mozilla/bugs/bug46480-1-expected.txt:
- platform/win/tables/mozilla/bugs/bug46480-2-expected.txt:
- platform/win/tables/mozilla/bugs/bug46623-1-expected.txt:
- platform/win/tables/mozilla/bugs/bug46623-2-expected.txt:
- platform/win/tables/mozilla/bugs/bug47432-expected.txt:
- platform/win/tables/mozilla/bugs/bug48028-1-expected.txt:
- platform/win/tables/mozilla/bugs/bug48028-2-expected.txt:
- platform/win/tables/mozilla/bugs/bug51037-expected.txt:
- platform/win/tables/mozilla/bugs/bug51140-expected.txt:
- platform/win/tables/mozilla/bugs/bug51727-expected.txt:
- platform/win/tables/mozilla/bugs/bug52505-expected.txt:
- platform/win/tables/mozilla/bugs/bug52506-expected.txt:
- platform/win/tables/mozilla/bugs/bug53690-1-expected.txt:
- platform/win/tables/mozilla/bugs/bug53690-2-expected.txt:
- platform/win/tables/mozilla/bugs/bug53891-expected.txt:
- platform/win/tables/mozilla/bugs/bug55545-expected.txt:
- platform/win/tables/mozilla/bugs/bug55694-expected.txt:
- platform/win/tables/mozilla/bugs/bug55789-expected.txt:
- platform/win/tables/mozilla/bugs/bug56201-expected.txt:
- platform/win/tables/mozilla/bugs/bug56405-expected.txt:
- platform/win/tables/mozilla/bugs/bug57300-expected.txt:
- platform/win/tables/mozilla/bugs/bug57378-expected.txt:
- platform/win/tables/mozilla/bugs/bug57828-2-expected.txt:
- platform/win/tables/mozilla/bugs/bug57828-expected.txt:
- platform/win/tables/mozilla/bugs/bug58402-1-expected.txt:
- platform/win/tables/mozilla/bugs/bug59354-expected.txt:
- platform/win/tables/mozilla/bugs/bug60013-expected.txt:
- platform/win/tables/mozilla/bugs/bug60749-expected.txt:
- platform/win/tables/mozilla/bugs/bug60804-expected.txt:
- platform/win/tables/mozilla/bugs/bug60807-expected.txt:
- platform/win/tables/mozilla/bugs/bug60992-expected.txt:
- platform/win/tables/mozilla/bugs/bug63785-expected.txt:
- platform/win/tables/mozilla/bugs/bug67864-expected.txt:
- platform/win/tables/mozilla/bugs/bug67915-1-expected.txt:
- platform/win/tables/mozilla/bugs/bug68998-expected.txt:
- platform/win/tables/mozilla/bugs/bug69187-expected.txt:
- platform/win/tables/mozilla/bugs/bug69382-1-expected.txt:
- platform/win/tables/mozilla/bugs/bug69382-2-expected.txt:
- platform/win/tables/mozilla/bugs/bug72359-expected.txt:
- platform/win/tables/mozilla/bugs/bug75250-expected.txt:
- platform/win/tables/mozilla/bugs/bug78162-expected.txt:
- platform/win/tables/mozilla/bugs/bug82946-1-expected.txt:
- platform/win/tables/mozilla/bugs/bug82946-2-expected.txt:
- platform/win/tables/mozilla/bugs/bug83786-expected.txt:
- platform/win/tables/mozilla/bugs/bug86708-expected.txt:
- platform/win/tables/mozilla/bugs/bug92143-expected.txt:
- platform/win/tables/mozilla/bugs/bug92647-2-expected.txt:
- platform/win/tables/mozilla/bugs/bug93363-expected.txt:
- platform/win/tables/mozilla/bugs/bug96334-expected.txt:
- platform/win/tables/mozilla/bugs/bug96343-expected.txt:
- platform/win/tables/mozilla/bugs/bug97138-expected.txt:
- platform/win/tables/mozilla/bugs/bug97383-expected.txt:
- platform/win/tables/mozilla/bugs/bug99923-expected.txt:
- platform/win/tables/mozilla/bugs/bug99948-expected.txt:
- platform/win/tables/mozilla/collapsing_borders/bug127040-expected.txt:
- platform/win/tables/mozilla/collapsing_borders/bug41262-3-expected.txt:
- platform/win/tables/mozilla/collapsing_borders/bug41262-4-expected.txt:
- platform/win/tables/mozilla/core/bloomberg-expected.txt:
- platform/win/tables/mozilla/core/borders-expected.txt:
- platform/win/tables/mozilla/core/captions-expected.txt:
- platform/win/tables/mozilla/core/cell_heights-expected.txt:
- platform/win/tables/mozilla/core/col_span-expected.txt:
- platform/win/tables/mozilla/core/col_widths_auto_auto-expected.txt:
- platform/win/tables/mozilla/core/col_widths_auto_autoFix-expected.txt:
- platform/win/tables/mozilla/core/col_widths_auto_autoFixPer-expected.txt:
- platform/win/tables/mozilla/core/col_widths_auto_autoPer-expected.txt:
- platform/win/tables/mozilla/core/col_widths_auto_fix-expected.txt:
- platform/win/tables/mozilla/core/col_widths_auto_fixPer-expected.txt:
- platform/win/tables/mozilla/core/col_widths_auto_per-expected.txt:
- platform/win/tables/mozilla/core/col_widths_fix_autoFix-expected.txt:
- platform/win/tables/mozilla/core/col_widths_fix_autoPer-expected.txt:
- platform/win/tables/mozilla/core/col_widths_fix_fix-expected.txt:
- platform/win/tables/mozilla/core/col_widths_fix_fixPer-expected.txt:
- platform/win/tables/mozilla/core/col_widths_fix_per-expected.txt:
- platform/win/tables/mozilla/core/margins-expected.txt:
- platform/win/tables/mozilla/core/misc-expected.txt:
- platform/win/tables/mozilla/core/nested1-expected.txt:
- platform/win/tables/mozilla/core/one_row-expected.txt:
- platform/win/tables/mozilla/core/row_span-expected.txt:
- platform/win/tables/mozilla/core/table_frame-expected.txt:
- platform/win/tables/mozilla/core/table_heights-expected.txt:
- platform/win/tables/mozilla/core/table_rules-expected.txt:
- platform/win/tables/mozilla/core/table_widths-expected.txt:
- platform/win/tables/mozilla/dom/appendCol2-expected.txt:
- platform/win/tables/mozilla/dom/appendRowsExpand1-expected.txt:
- platform/win/tables/mozilla/dom/appendTbodyExpand1-expected.txt:
- platform/win/tables/mozilla/dom/deleteCellsRebuild1-expected.txt:
- platform/win/tables/mozilla/dom/deleteCellsShrink1-expected.txt:
- platform/win/tables/mozilla/dom/deleteCellsShrink2-expected.txt:
- platform/win/tables/mozilla/dom/deleteCol1-expected.txt:
- platform/win/tables/mozilla/dom/deleteCol2-expected.txt:
- platform/win/tables/mozilla/dom/deleteCol3-expected.txt:
- platform/win/tables/mozilla/dom/deleteColGroup1-expected.txt:
- platform/win/tables/mozilla/dom/deleteColGroup2-expected.txt:
- platform/win/tables/mozilla/dom/deleteRowsRebuild1-expected.txt:
- platform/win/tables/mozilla/dom/deleteRowsShrink1-expected.txt:
- platform/win/tables/mozilla/dom/deleteTbodyExpand1-expected.txt:
- platform/win/tables/mozilla/dom/deleteTbodyRebuild1-expected.txt:
- platform/win/tables/mozilla/dom/insertCellsExpand1-expected.txt:
- platform/win/tables/mozilla/dom/insertCellsExpand2-expected.txt:
- platform/win/tables/mozilla/dom/insertCellsRebuild1-expected.txt:
- platform/win/tables/mozilla/dom/insertCellsRebuild2-expected.txt:
- platform/win/tables/mozilla/dom/insertColGroups1-expected.txt:
- platform/win/tables/mozilla/dom/insertColGroups2-expected.txt:
- platform/win/tables/mozilla/dom/insertCols1-expected.txt:
- platform/win/tables/mozilla/dom/insertCols2-expected.txt:
- platform/win/tables/mozilla/dom/insertCols3-expected.txt:
- platform/win/tables/mozilla/dom/insertCols4-expected.txt:
- platform/win/tables/mozilla/dom/insertCols5-expected.txt:
- platform/win/tables/mozilla/dom/insertRowsExpand1-expected.txt:
- platform/win/tables/mozilla/dom/insertRowsRebuild1-expected.txt:
- platform/win/tables/mozilla/dom/tableDom-expected.txt:
- platform/win/tables/mozilla/marvin/backgr_layers-opacity-expected.txt:
- platform/win/tables/mozilla/marvin/backgr_position-table-expected.txt:
- platform/win/tables/mozilla/marvin/backgr_simple-table-cell-expected.txt:
- platform/win/tables/mozilla/marvin/backgr_simple-table-column-expected.txt:
- platform/win/tables/mozilla/marvin/backgr_simple-table-column-group-expected.txt:
- platform/win/tables/mozilla/marvin/backgr_simple-table-expected.txt:
- platform/win/tables/mozilla/marvin/backgr_simple-table-row-expected.txt:
- platform/win/tables/mozilla/marvin/backgr_simple-table-row-group-expected.txt:
- platform/win/tables/mozilla/marvin/body_col-expected.txt:
- platform/win/tables/mozilla/marvin/body_tbody-expected.txt:
- platform/win/tables/mozilla/marvin/body_tfoot-expected.txt:
- platform/win/tables/mozilla/marvin/body_thead-expected.txt:
- platform/win/tables/mozilla/marvin/col_span-expected.txt:
- platform/win/tables/mozilla/marvin/colgroup_align_center-expected.txt:
- platform/win/tables/mozilla/marvin/colgroup_align_justify-expected.txt:
- platform/win/tables/mozilla/marvin/colgroup_align_left-expected.txt:
- platform/win/tables/mozilla/marvin/colgroup_align_right-expected.txt:
- platform/win/tables/mozilla/marvin/colgroup_span-expected.txt:
- platform/win/tables/mozilla/marvin/colgroup_valign_baseline-expected.txt:
- platform/win/tables/mozilla/marvin/colgroup_valign_bottom-expected.txt:
- platform/win/tables/mozilla/marvin/colgroup_valign_middle-expected.txt:
- platform/win/tables/mozilla/marvin/colgroup_valign_top-expected.txt:
- platform/win/tables/mozilla/marvin/colgroup_width_pct-expected.txt:
- platform/win/tables/mozilla/marvin/colgroup_width_px-expected.txt:
- platform/win/tables/mozilla/marvin/table_frame_border-expected.txt:
- platform/win/tables/mozilla/marvin/table_frame_box-expected.txt:
- platform/win/tables/mozilla/marvin/table_overflow_hidden_td-expected.txt:
- platform/win/tables/mozilla/marvin/table_overflow_td_dynamic_deactivate-expected.txt:
- platform/win/tables/mozilla/marvin/table_row_align_center-expected.txt:
- platform/win/tables/mozilla/marvin/table_row_align_left-expected.txt:
- platform/win/tables/mozilla/marvin/table_row_align_right-expected.txt:
- platform/win/tables/mozilla/marvin/table_rules_all-expected.txt:
- platform/win/tables/mozilla/marvin/table_rules_groups-expected.txt:
- platform/win/tables/mozilla/marvin/table_rules_none-expected.txt:
- platform/win/tables/mozilla/marvin/tables_align_center-expected.txt:
- platform/win/tables/mozilla/marvin/tables_align_left-expected.txt:
- platform/win/tables/mozilla/marvin/tables_align_right-expected.txt:
- platform/win/tables/mozilla/marvin/tables_bgcolor_aqua-expected.txt:
- platform/win/tables/mozilla/marvin/tables_bgcolor_aqua_rgb-expected.txt:
- platform/win/tables/mozilla/marvin/tables_bgcolor_black-expected.txt:
- platform/win/tables/mozilla/marvin/tables_bgcolor_black_rgb-expected.txt:
- platform/win/tables/mozilla/marvin/tables_bgcolor_blue-expected.txt:
- platform/win/tables/mozilla/marvin/tables_bgcolor_blue_rgb-expected.txt:
- platform/win/tables/mozilla/marvin/tables_bgcolor_fuchsia-expected.txt:
- platform/win/tables/mozilla/marvin/tables_bgcolor_fuchsia_rgb-expected.txt:
- platform/win/tables/mozilla/marvin/tables_bgcolor_gray-expected.txt:
- platform/win/tables/mozilla/marvin/tables_bgcolor_gray_rgb-expected.txt:
- platform/win/tables/mozilla/marvin/tables_bgcolor_green-expected.txt:
- platform/win/tables/mozilla/marvin/tables_bgcolor_green_rgb-expected.txt:
- platform/win/tables/mozilla/marvin/tables_bgcolor_lime-expected.txt:
- platform/win/tables/mozilla/marvin/tables_bgcolor_lime_rgb-expected.txt:
- platform/win/tables/mozilla/marvin/tables_bgcolor_maroon-expected.txt:
- platform/win/tables/mozilla/marvin/tables_bgcolor_maroon_rgb-expected.txt:
- platform/win/tables/mozilla/marvin/tables_bgcolor_navy-expected.txt:
- platform/win/tables/mozilla/marvin/tables_bgcolor_navy_rgb-expected.txt:
- platform/win/tables/mozilla/marvin/tables_bgcolor_olive-expected.txt:
- platform/win/tables/mozilla/marvin/tables_bgcolor_olive_rgb-expected.txt:
- platform/win/tables/mozilla/marvin/tables_bgcolor_purple-expected.txt:
- platform/win/tables/mozilla/marvin/tables_bgcolor_purple_rgb-expected.txt:
- platform/win/tables/mozilla/marvin/tables_bgcolor_red-expected.txt:
- platform/win/tables/mozilla/marvin/tables_bgcolor_red_rgb-expected.txt:
- platform/win/tables/mozilla/marvin/tables_bgcolor_silver-expected.txt:
- platform/win/tables/mozilla/marvin/tables_bgcolor_silver_rgb-expected.txt:
- platform/win/tables/mozilla/marvin/tables_bgcolor_teal-expected.txt:
- platform/win/tables/mozilla/marvin/tables_bgcolor_teal_rgb-expected.txt:
- platform/win/tables/mozilla/marvin/tables_bgcolor_white-expected.txt:
- platform/win/tables/mozilla/marvin/tables_bgcolor_white_rgb-expected.txt:
- platform/win/tables/mozilla/marvin/tables_bgcolor_yellow-expected.txt:
- platform/win/tables/mozilla/marvin/tables_bgcolor_yellow_rgb-expected.txt:
- platform/win/tables/mozilla/marvin/tables_border_0-expected.txt:
- platform/win/tables/mozilla/marvin/tables_border_1-expected.txt:
- platform/win/tables/mozilla/marvin/tables_border_2-expected.txt:
- platform/win/tables/mozilla/marvin/tables_border_3-expected.txt:
- platform/win/tables/mozilla/marvin/tables_caption_align_bot-expected.txt:
- platform/win/tables/mozilla/marvin/tables_caption_align_top-expected.txt:
- platform/win/tables/mozilla/marvin/tables_cellpadding-expected.txt:
- platform/win/tables/mozilla/marvin/tables_cellpadding_pct-expected.txt:
- platform/win/tables/mozilla/marvin/tables_cellspacing-expected.txt:
- platform/win/tables/mozilla/marvin/tables_default-expected.txt:
- platform/win/tables/mozilla/marvin/tables_id-expected.txt:
- platform/win/tables/mozilla/marvin/tables_row_th_nowrap-expected.txt:
- platform/win/tables/mozilla/marvin/tables_td_align_center-expected.txt:
- platform/win/tables/mozilla/marvin/tables_td_align_left-expected.txt:
- platform/win/tables/mozilla/marvin/tables_td_align_right-expected.txt:
- platform/win/tables/mozilla/marvin/tables_td_colspan-expected.txt:
- platform/win/tables/mozilla/marvin/tables_td_height-expected.txt:
- platform/win/tables/mozilla/marvin/tables_td_nowrap-expected.txt:
- platform/win/tables/mozilla/marvin/tables_td_rowspan-expected.txt:
- platform/win/tables/mozilla/marvin/tables_td_width-expected.txt:
- platform/win/tables/mozilla/marvin/tables_th_align_center-expected.txt:
- platform/win/tables/mozilla/marvin/tables_th_align_left-expected.txt:
- platform/win/tables/mozilla/marvin/tables_th_align_right-expected.txt:
- platform/win/tables/mozilla/marvin/tables_th_colspan-expected.txt:
- platform/win/tables/mozilla/marvin/tables_th_height-expected.txt:
- platform/win/tables/mozilla/marvin/tables_th_rowspan-expected.txt:
- platform/win/tables/mozilla/marvin/tables_th_width-expected.txt:
- platform/win/tables/mozilla/marvin/tables_width_percent-expected.txt:
- platform/win/tables/mozilla/marvin/tables_width_px-expected.txt:
- platform/win/tables/mozilla/marvin/tbody_align_center-expected.txt:
- platform/win/tables/mozilla/marvin/tbody_align_char-expected.txt:
- platform/win/tables/mozilla/marvin/tbody_align_justify-expected.txt:
- platform/win/tables/mozilla/marvin/tbody_align_left-expected.txt:
- platform/win/tables/mozilla/marvin/tbody_align_right-expected.txt:
- platform/win/tables/mozilla/marvin/tbody_char-expected.txt:
- platform/win/tables/mozilla/marvin/tbody_valign_baseline-expected.txt:
- platform/win/tables/mozilla/marvin/tbody_valign_bottom-expected.txt:
- platform/win/tables/mozilla/marvin/tbody_valign_middle-expected.txt:
- platform/win/tables/mozilla/marvin/tbody_valign_top-expected.txt:
- platform/win/tables/mozilla/marvin/td_valign_baseline-expected.txt:
- platform/win/tables/mozilla/marvin/td_valign_bottom-expected.txt:
- platform/win/tables/mozilla/marvin/td_valign_middle-expected.txt:
- platform/win/tables/mozilla/marvin/td_valign_top-expected.txt:
- platform/win/tables/mozilla/marvin/tfoot_align_center-expected.txt:
- platform/win/tables/mozilla/marvin/tfoot_align_char-expected.txt:
- platform/win/tables/mozilla/marvin/tfoot_align_justify-expected.txt:
- platform/win/tables/mozilla/marvin/tfoot_align_left-expected.txt:
- platform/win/tables/mozilla/marvin/tfoot_align_right-expected.txt:
- platform/win/tables/mozilla/marvin/tfoot_char-expected.txt:
- platform/win/tables/mozilla/marvin/tfoot_valign_baseline-expected.txt:
- platform/win/tables/mozilla/marvin/tfoot_valign_bottom-expected.txt:
- platform/win/tables/mozilla/marvin/tfoot_valign_middle-expected.txt:
- platform/win/tables/mozilla/marvin/tfoot_valign_top-expected.txt:
- platform/win/tables/mozilla/marvin/th_valign_baseline-expected.txt:
- platform/win/tables/mozilla/marvin/th_valign_bottom-expected.txt:
- platform/win/tables/mozilla/marvin/th_valign_middle-expected.txt:
- platform/win/tables/mozilla/marvin/th_valign_top-expected.txt:
- platform/win/tables/mozilla/marvin/thead_align_center-expected.txt:
- platform/win/tables/mozilla/marvin/thead_align_char-expected.txt:
- platform/win/tables/mozilla/marvin/thead_align_justify-expected.txt:
- platform/win/tables/mozilla/marvin/thead_align_left-expected.txt:
- platform/win/tables/mozilla/marvin/thead_align_right-expected.txt:
- platform/win/tables/mozilla/marvin/thead_char-expected.txt:
- platform/win/tables/mozilla/marvin/thead_valign_baseline-expected.txt:
- platform/win/tables/mozilla/marvin/thead_valign_bottom-expected.txt:
- platform/win/tables/mozilla/marvin/thead_valign_middle-expected.txt:
- platform/win/tables/mozilla/marvin/thead_valign_top-expected.txt:
- platform/win/tables/mozilla/marvin/tr_bgcolor_aqua_rgb-expected.txt:
- platform/win/tables/mozilla/marvin/tr_bgcolor_black-expected.txt:
- platform/win/tables/mozilla/marvin/tr_bgcolor_black_rgb-expected.txt:
- platform/win/tables/mozilla/marvin/tr_bgcolor_blue-expected.txt:
- platform/win/tables/mozilla/marvin/tr_bgcolor_blue_rgb-expected.txt:
- platform/win/tables/mozilla/marvin/tr_bgcolor_fuchsia-expected.txt:
- platform/win/tables/mozilla/marvin/tr_bgcolor_fuchsia_rgb-expected.txt:
- platform/win/tables/mozilla/marvin/tr_bgcolor_gray-expected.txt:
- platform/win/tables/mozilla/marvin/tr_bgcolor_gray_rgb-expected.txt:
- platform/win/tables/mozilla/marvin/tr_bgcolor_green-expected.txt:
- platform/win/tables/mozilla/marvin/tr_bgcolor_green_rgb-expected.txt:
- platform/win/tables/mozilla/marvin/tr_bgcolor_lime-expected.txt:
- platform/win/tables/mozilla/marvin/tr_bgcolor_lime_rgb-expected.txt:
- platform/win/tables/mozilla/marvin/tr_bgcolor_maroon-expected.txt:
- platform/win/tables/mozilla/marvin/tr_bgcolor_maroon_rgb-expected.txt:
- platform/win/tables/mozilla/marvin/tr_bgcolor_navy-expected.txt:
- platform/win/tables/mozilla/marvin/tr_bgcolor_navy_rgb-expected.txt:
- platform/win/tables/mozilla/marvin/tr_bgcolor_olive-expected.txt:
- platform/win/tables/mozilla/marvin/tr_bgcolor_olive_rgb-expected.txt:
- platform/win/tables/mozilla/marvin/tr_bgcolor_purple-expected.txt:
- platform/win/tables/mozilla/marvin/tr_bgcolor_purple_rgb-expected.txt:
- platform/win/tables/mozilla/marvin/tr_bgcolor_red-expected.txt:
- platform/win/tables/mozilla/marvin/tr_bgcolor_red_rgb-expected.txt:
- platform/win/tables/mozilla/marvin/tr_bgcolor_silver-expected.txt:
- platform/win/tables/mozilla/marvin/tr_bgcolor_silver_rgb-expected.txt:
- platform/win/tables/mozilla/marvin/tr_bgcolor_teal-expected.txt:
- platform/win/tables/mozilla/marvin/tr_bgcolor_teal_rgb-expected.txt:
- platform/win/tables/mozilla/marvin/tr_bgcolor_white-expected.txt:
- platform/win/tables/mozilla/marvin/tr_bgcolor_white_rgb-expected.txt:
- platform/win/tables/mozilla/marvin/tr_bgcolor_yellow-expected.txt:
- platform/win/tables/mozilla/marvin/tr_bgcolor_yellow_rgb-expected.txt:
- platform/win/tables/mozilla/marvin/tr_valign_baseline-expected.txt:
- platform/win/tables/mozilla/marvin/tr_valign_bottom-expected.txt:
- platform/win/tables/mozilla/marvin/tr_valign_middle-expected.txt:
- platform/win/tables/mozilla/marvin/tr_valign_top-expected.txt:
- platform/win/tables/mozilla/marvin/x_caption_align_bottom-expected.txt:
- platform/win/tables/mozilla/marvin/x_caption_align_top-expected.txt:
- platform/win/tables/mozilla/marvin/x_col_align_char-expected.txt:
- platform/win/tables/mozilla/marvin/x_col_span-expected.txt:
- platform/win/tables/mozilla/marvin/x_col_valign_baseline-expected.txt:
- platform/win/tables/mozilla/marvin/x_col_valign_bottom-expected.txt:
- platform/win/tables/mozilla/marvin/x_col_valign_middle-expected.txt:
- platform/win/tables/mozilla/marvin/x_col_valign_top-expected.txt:
- platform/win/tables/mozilla/marvin/x_col_width_px-expected.txt:
- platform/win/tables/mozilla/marvin/x_col_width_rel-expected.txt:
- platform/win/tables/mozilla/marvin/x_colgroup_align_char-expected.txt:
- platform/win/tables/mozilla/marvin/x_colgroup_span-expected.txt:
- platform/win/tables/mozilla/marvin/x_colgroup_valign_baseline-expected.txt:
- platform/win/tables/mozilla/marvin/x_colgroup_valign_bottom-expected.txt:
- platform/win/tables/mozilla/marvin/x_colgroup_valign_middle-expected.txt:
- platform/win/tables/mozilla/marvin/x_colgroup_valign_top-expected.txt:
- platform/win/tables/mozilla/marvin/x_colgroup_width_rel-expected.txt:
- platform/win/tables/mozilla/marvin/x_table-expected.txt:
- platform/win/tables/mozilla/marvin/x_table_align_center-expected.txt:
- platform/win/tables/mozilla/marvin/x_table_align_left-expected.txt:
- platform/win/tables/mozilla/marvin/x_table_align_right-expected.txt:
- platform/win/tables/mozilla/marvin/x_table_bgcolor_name-expected.txt:
- platform/win/tables/mozilla/marvin/x_table_bgcolor_rgb-expected.txt:
- platform/win/tables/mozilla/marvin/x_table_border-expected.txt:
- platform/win/tables/mozilla/marvin/x_table_border_none-expected.txt:
- platform/win/tables/mozilla/marvin/x_table_border_px-expected.txt:
- platform/win/tables/mozilla/marvin/x_table_cellpadding-expected.txt:
- platform/win/tables/mozilla/marvin/x_table_cellpadding_pct-expected.txt:
- platform/win/tables/mozilla/marvin/x_table_cellspacing-expected.txt:
- platform/win/tables/mozilla/marvin/x_table_cellspacing_pct-expected.txt:
- platform/win/tables/mozilla/marvin/x_table_frame_void-expected.txt:
- platform/win/tables/mozilla/marvin/x_table_rules_groups-expected.txt:
- platform/win/tables/mozilla/marvin/x_table_rules_none-expected.txt:
- platform/win/tables/mozilla/marvin/x_table_style-expected.txt:
- platform/win/tables/mozilla/marvin/x_tbody_align_center-expected.txt:
- platform/win/tables/mozilla/marvin/x_tbody_align_char-expected.txt:
- 4:26 AM Changeset in webkit [196007] by
-
- 2 edits in trunk/Tools
[EFL] Virtual Keyboard overlaps MiniBrowser's WebView
https://bugs.webkit.org/show_bug.cgi?id=153009
Reviewed by Gyuyoung Kim.
On mobile, virtual keyboard represented by ecore_imf module appears on
the top of application layer usually covering bottom part of the screen.
If the web page contains the editable content on the bottom of the page
it will be overlapped by keyboard which prevents user from seeing the
typed text.
Pack MiniBrowser layout into conformant widget to allow EFL to guess
the space that will be required by the keyboard, finally resizing it
to the desired size. As a result, webview gets resized and scrolled
into focused elements which makes the editable elements visible while
typing.
More details about elm_conformant widger can be found at:
https://docs.enlightenment.org/elementary/1.15.0/group__Conformant.html
https://docs.enlightenment.org/elementary/1.15.0/conformant_example.html
- MiniBrowser/efl/main.c:
(window_create): pack a box into conformant widget.
- 3:39 AM BuildingGtk edited by
- (diff)
- 3:35 AM Changeset in webkit [196006] by
-
- 8 edits1 add in trunk
[GTK][EFL] Upgrade OpenWebRTC dependency
https://bugs.webkit.org/show_bug.cgi?id=153489
Reviewed by Philippe Normand.
.:
- Source/cmake/FindOpenWebRTC.cmake: Bump OpenWebRTC dependency,
required to make the mediastream work.
Tools:
- Scripts/run-gtk-tests:
(TestRunner): Avoid running the mediastream API test.
- Scripts/webkitperl/FeatureList.pm: Stop compiling mediastream by
default for gtk and efl.
- gtk/jhbuild-webrtc.modules: Added modules files with
dependencies required to compile and test the mediastream.
LayoutTests:
Skiped the mediastream tests by default, until we have the code
ready and gstreamer dependency is bumped.
- platform/efl/TestExpectations:
- platform/gtk/TestExpectations:
- 3:00 AM Changeset in webkit [196005] by
-
- 3 edits in trunk/Source/WebKit2
[GTK] Several tests fail due to assert not reached in DrawingArea::dispatchAfterEnsuringDrawing()
https://bugs.webkit.org/show_bug.cgi?id=153785
Patch by Adrien Plazas <aplazas@igalia.com> on 2016-02-02
Reviewed by Carlos Garcia Campos.
- UIProcess/DrawingAreaProxyImpl.cpp:
(WebKit::DrawingAreaProxyImpl::dispatchAfterEnsuringDrawing):
- UIProcess/DrawingAreaProxyImpl.h:
Feb 1, 2016:
- 10:35 PM Changeset in webkit [196004] by
-
- 3 edits2 adds in trunk
object.lookupGetter() / object.lookupSetter() does not work for native bindings
https://bugs.webkit.org/show_bug.cgi?id=153765
<rdar://problem/24439699>
Reviewed by Oliver Hunt.
Source/JavaScriptCore:
Add support for CustomAccessor slots to objectProtoFuncLookupGetter() and
objectProtoFuncLookupSetter() by return getOwnPropertyDescriptor().get / set.
getOwnPropertyDescriptor() now correctly deals with CustomAccessors since
r196001.
- runtime/ObjectPrototype.cpp:
(JSC::objectProtoFuncLookupGetter):
(JSC::objectProtoFuncLookupSetter):
LayoutTests:
Add layout tests to test that object.lookupGetter() / object.lookupSetter()
works for native bindings.
- js/lookupGetterGetter-native-bindings-expected.txt: Added.
- js/lookupGetterGetter-native-bindings.html: Added.
- 10:15 PM Changeset in webkit [196003] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Option+Up/Down should not move cursor outside of number
https://bugs.webkit.org/show_bug.cgi?id=153784
<rdar://problem/24453133>
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-02-01
Reviewed by Timothy Hatcher.
- UserInterface/Views/CodeMirrorAdditions.js:
When selectionStart === selectionEnd we were duplicating the
movement mutation by performing it twice on the same object.
After much experimentation, I left in the existing code path
for handling mutation with a selection. It is not perfect,
but it is better then just applying the ch diff.
- 10:12 PM Changeset in webkit [196002] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, fix http/tests/security/cross-origin-window-property-access.html
Update http/tests/security/cross-origin-window-property-access.html that was
introduced in r196001 so that it does not assert on Mac DRT. Mac DRT asserts
that testRunner.waitUntilDone() must be called *BEFORE* calling window.open().
- http/tests/security/cross-origin-window-property-access.html:
- 7:47 PM Changeset in webkit [196001] by
-
- 19 edits13 adds in trunk
Native Bindings Descriptors are Incomplete
https://bugs.webkit.org/show_bug.cgi?id=140575
<rdar://problem/19506502>
Reviewed by Oliver Hunt.
LayoutTests/imported/w3c:
Rebaseline several W3C tests now that a lot more checks are passing.
- web-platform-tests/XMLHttpRequest/interfaces-expected.txt:
- web-platform-tests/dom/interfaces-expected.txt:
- web-platform-tests/html/dom/interfaces-expected.txt:
Source/JavaScriptCore:
This patch is based on initial work by Joe Pecoraro and Matthew Mirman.
This patch was initially rolled out for breaking chromeexperiments.com,
presumably because our IDL attributes were not marked as [configurable]
at the time. However, since r190104, our IDL attributes are now
configurable. Based on local testing, chromeexperiments.com seems to be
working fine now.
- JavaScriptCore.xcodeproj/project.pbxproj:
- inspector/InjectedScriptSource.js:
(endsWith):
(InjectedScript.prototype.processProperties):
- runtime/JSBoundSlotBaseFunction.cpp: Added.
(JSC::boundSlotBaseFunctionCall):
(JSC::JSBoundSlotBaseFunction::JSBoundSlotBaseFunction):
(JSC::JSBoundSlotBaseFunction::create):
(JSC::JSBoundSlotBaseFunction::visitChildren):
(JSC::JSBoundSlotBaseFunction::finishCreation):
- runtime/JSBoundSlotBaseFunction.h: Added.
(JSC::JSBoundSlotBaseFunction::createStructure):
(JSC::JSBoundSlotBaseFunction::boundSlotBase):
(JSC::JSBoundSlotBaseFunction::customGetterSetter):
(JSC::JSBoundSlotBaseFunction::isSetter):
- runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::init):
(JSC::JSGlobalObject::visitChildren):
- runtime/JSGlobalObject.h:
(JSC::JSGlobalObject::boundSlotBaseFunctionStructure):
- runtime/JSObject.cpp:
(JSC::getBoundSlotBaseFunctionForGetterSetter):
(JSC::JSObject::getOwnPropertyDescriptor):
- runtime/VM.cpp:
(JSC::VM::VM):
- runtime/VM.h:
LayoutTests:
Add test coverage.
- http/tests/security/cross-origin-window-property-access-expected.txt: Added.
- http/tests/security/cross-origin-window-property-access.html: Added.
- inspector/runtime/getProperties-expected.txt:
- js/dom/native-bindings-descriptors-expected.txt: Added.
- js/dom/native-bindings-descriptors.html: Added.
- js/dom/native-bindings-descriptors2-expected.txt: Added.
- js/dom/native-bindings-descriptors2.html: Added.
- js/dom/native-bindings-descriptors3-expected.txt: Added.
- js/dom/native-bindings-descriptors3.html: Added.
- js/dom/native-bindings-descriptors4-expected.txt: Added.
- js/dom/native-bindings-descriptors4.html: Added.
- js/dom/native-bindings-descriptors5-expected.txt: Added.
- js/dom/native-bindings-descriptors5.html: Added.
- 6:35 PM Changeset in webkit [196000] by
-
- 2 edits in trunk/LayoutTests
[GTK] [EFL] [AppleWin] Layout Test fast/shadow-dom/slot-removal-crash-2.html timeouts
https://bugs.webkit.org/show_bug.cgi?id=153772
Reviewed by Michael Catanzaro.
Don't call wait untilDone if attachShadow is not available.
- fast/shadow-dom/slot-removal-crash-2.html:
- 5:52 PM Changeset in webkit [195999] by
-
- 32 edits6 copies14 adds in trunk
Web Inspector: High Level Memory Overview Instrument
https://bugs.webkit.org/show_bug.cgi?id=153516
<rdar://problem/24356378>
Reviewed by Brian Burg.
Source/JavaScriptCore:
- CMakeLists.txt:
- Configurations/FeatureDefines.xcconfig:
- DerivedSources.make:
- inspector/protocol/Memory.json: Added.
- inspector/scripts/codegen/generator.py:
New Memory domain guarded by ENABLE(RESOURCE_USAGE).
This feature flag was already used in WebCore.
Source/WebCore:
Add a new agent that gathers data from the ResourceUsageThread
and sends to the frontend.
Test: inspector/memory/tracking.html
- CMakeLists.txt:
- Configurations/FeatureDefines.xcconfig:
- WebCore.xcodeproj/project.pbxproj:
New files.
- inspector/InspectorController.cpp:
(WebCore::InspectorController::InspectorController):
Add the new agent.
- inspector/InspectorMemoryAgent.h: Added.
- inspector/InspectorMemoryAgent.cpp: Added.
(WebCore::InspectorMemoryAgent::InspectorMemoryAgent):
(WebCore::InspectorMemoryAgent::didCreateFrontendAndBackend):
(WebCore::InspectorMemoryAgent::willDestroyFrontendAndBackend):
(WebCore::InspectorMemoryAgent::startTracking):
(WebCore::InspectorMemoryAgent::stopTracking):
(WebCore::InspectorMemoryAgent::collectSample):
Implement the agent by adding / removing it as a ResourceUsage
observer. When receiving the data forward it to the frontend.
Source/WebInspectorUI:
Use the new "Memory" domain to track page memory size over time.
This allows the timeline to help visualize total process memory
broken down into a few different categories. The timeline graph
allows seeing the total size over time, and you can drill in to
a specific section and get a better breakdown and comparison
of the different categories of memory that we currently track.
- Localizations/en.lproj/localizedStrings.js:
New UI strings.
- UserInterface/Main.html:
New files.
- UserInterface/Base/Main.js:
(WebInspector.loaded):
- UserInterface/Protocol/MemoryObserver.js:
(WebInspector.MemoryObserver.prototype.trackingStart):
(WebInspector.MemoryObserver.prototype.trackingUpdate):
(WebInspector.MemoryObserver.prototype.trackingComplete):
Add a memory observer.
- UserInterface/Controllers/TimelineManager.js:
(WebInspector.TimelineManager.defaultInstruments):
(WebInspector.TimelineManager.prototype.memoryTrackingStart):
(WebInspector.TimelineManager.prototype.memoryTrackingUpdate):
(WebInspector.TimelineManager.prototype.memoryTrackingComplete):
Create Memory timeline records from Memory tracking updates.
- UserInterface/Models/MemoryCategory.js:
(WebInspector.MemoryCategory):
Consolidate some of the raw data of categories we get from the backend
into a set of 4 user-facing categories.
- UserInterface/Models/MemoryTimelineRecord.js: Added.
(WebInspector.MemoryTimelineRecord):
(WebInspector.MemoryTimelineRecord.memoryCategoriesFromProtocol):
(WebInspector.MemoryTimelineRecord.prototype.get timestamp):
(WebInspector.MemoryTimelineRecord.prototype.get categories):
(WebInspector.MemoryTimelineRecord.prototype.get totalSize):
(WebInspector.MemoryTimelineRecord.prototype.get startTime):
(WebInspector.MemoryTimelineRecord.prototype.get endTime):
Memory timeline record for the event data.
- UserInterface/Models/MemoryInstrument.js:
(WebInspector.MemoryInstrument):
(WebInspector.MemoryInstrument.supported):
(WebInspector.MemoryInstrument.prototype.get timelineRecordType):
(WebInspector.MemoryInstrument.prototype.startInstrumentation):
(WebInspector.MemoryInstrument.prototype.stopInstrumentation):
Instrument to start / stop memory tracking.
- UserInterface/Models/TimelineRecord.js:
Add a new "Memory" Timeline type.
- UserInterface/Views/ContentView.js:
(WebInspector.ContentView.createFromRepresentedObject):
- UserInterface/Models/TimelineRecording.js:
(WebInspector.TimelineRecording):
Add the new "Memory" Timeline.
(WebInspector.TimelineRecording.prototype.addRecord):
Memory timeline records do not show in the SourceCode Timelines Overview.
- UserInterface/Views/CircleChart.css:
(.circle-chart):
(.circle-chart > svg > path.background):
(.circle-chart > .center):
- UserInterface/Views/CircleChart.js: Added.
(WebInspector.CircleChart):
(WebInspector.CircleChart.prototype.get element):
(WebInspector.CircleChart.prototype.get points):
(WebInspector.CircleChart.prototype.get size):
(WebInspector.CircleChart.prototype.get centerElement):
(WebInspector.CircleChart.prototype.get segments):
(WebInspector.CircleChart.prototype.set segments):
(WebInspector.CircleChart.prototype.get values):
(WebInspector.CircleChart.prototype.set values):
(WebInspector.CircleChart.prototype.clear):
(WebInspector.CircleChart.prototype.needsLayout):
(WebInspector.CircleChart.prototype.updateLayout):
(WebInspector.CircleChart.prototype._needsLayout):
(WebInspector.CircleChart.prototype._createCompleteCirclePathData):
(WebInspector.CircleChart.prototype._createSegmentPathData):
(WebInspector.CircleChart.prototype._updateLayout):
Standalone circle "donut" chart, copied mostly from Rendering Frames Timeline.
Initialize the chart's segments, then feed it a set of ([v1, v2, ...]) values
corresponding to each of the segments.
- UserInterface/Views/LineChart.js: Added.
(WebInspector.LineChart):
(WebInspector.LineChart.prototype.get element):
(WebInspector.LineChart.prototype.get points):
(WebInspector.LineChart.prototype.get size):
(WebInspector.LineChart.prototype.set size):
(WebInspector.LineChart.prototype.addPoint):
(WebInspector.LineChart.prototype.clear):
(WebInspector.LineChart.prototype.needsLayout):
(WebInspector.LineChart.prototype.updateLayout):
(WebInspector.LineChart.prototype._needsLayout):
(WebInspector.LineChart.prototype._updateLayout):
Standalone line chart. Uses a single SVG path, given a set of (x, y) points.
- UserInterface/Views/StackedLineChart.js: Added.
(WebInspector.StackedLineChart):
(WebInspector.StackedLineChart.prototype.get element):
(WebInspector.StackedLineChart.prototype.get points):
(WebInspector.StackedLineChart.prototype.get size):
(WebInspector.StackedLineChart.prototype.set size):
(WebInspector.StackedLineChart.prototype.initializeSections):
(WebInspector.StackedLineChart.prototype.addPointSet):
(WebInspector.StackedLineChart.prototype.clear):
(WebInspector.StackedLineChart.prototype.needsLayout):
(WebInspector.StackedLineChart.prototype.updateLayout):
(WebInspector.StackedLineChart.prototype._needsLayout):
(WebInspector.StackedLineChart.prototype._updateLayout):
Standalone stacked line chart. Initialize the chart's sections,
then feed it a set of (x, [y1, y2 ...]) points where the y
values correspond to each of the sections.
- UserInterface/Views/TimelineOverview.js:
(WebInspector.TimelineOverview.prototype.get scrollContainerWidth):
Add a way to get this value without forcing layout all the time.
- UserInterface/Views/TimelineTabContentView.js:
(WebInspector.TimelineTabContentView.displayNameForTimeline):
(WebInspector.TimelineTabContentView.iconClassNameForTimeline):
(WebInspector.TimelineTabContentView.genericClassNameForTimeline):
(WebInspector.TimelineTabContentView.iconClassNameForRecord):
(WebInspector.TimelineTabContentView.displayNameForRecord):
Add placeholders for the new Memory Timeline Type.
- UserInterface/Views/MemoryCategoryView.css:
(.memory-category-view):
(.memory-category-view > .details):
(.memory-category-view > .details > .name):
(.memory-category-view > .graph):
- UserInterface/Views/MemoryCategoryView.js: Added.
(WebInspector.MemoryCategoryView):
(WebInspector.MemoryCategoryView.prototype.get element):
(WebInspector.MemoryCategoryView.prototype.get category):
(WebInspector.MemoryCategoryView.prototype.clear):
(WebInspector.MemoryCategoryView.prototype.layoutWithDataPoints):
(WebInspector.MemoryCategoryView.prototype._updateDetails):
- UserInterface/Views/MemoryTimelineOverviewGraph.css:
(body .timeline-overview > .graphs-container > .timeline-overview-graph.memory):
(.timeline-overview-graph.memory):
(.timeline-overview-graph.memory > .legend):
(.timeline-overview-graph.memory > .stacked-line-chart > svg > path.javascript):
(.timeline-overview-graph.memory > .stacked-line-chart > svg > path.images):
(.timeline-overview-graph.memory > .stacked-line-chart > svg > path.layers):
(.timeline-overview-graph.memory > .stacked-line-chart > svg > path.page):
- UserInterface/Views/MemoryTimelineOverviewGraph.js: Added.
(WebInspector.MemoryTimelineOverviewGraph):
(WebInspector.MemoryTimelineOverviewGraph.prototype.get height):
(WebInspector.MemoryTimelineOverviewGraph.prototype.reset):
(WebInspector.MemoryTimelineOverviewGraph.prototype.layout.timeToX):
(WebInspector.MemoryTimelineOverviewGraph.prototype.layout.sizeToY):
(WebInspector.MemoryTimelineOverviewGraph.prototype.layout.sizesToYs):
(WebInspector.MemoryTimelineOverviewGraph.prototype.layout.ysForRecord):
(WebInspector.MemoryTimelineOverviewGraph.prototype.layout):
(WebInspector.MemoryTimelineOverviewGraph.prototype._updateLegend):
(WebInspector.MemoryTimelineOverviewGraph.prototype._visibleRecords):
(WebInspector.MemoryTimelineOverviewGraph.prototype._memoryTimelineRecordAdded):
- UserInterface/Views/MemoryTimelineView.css: Added.
(.timeline-view.memory):
(.timeline-view.memory > .content):
(.timeline-view.memory > .content > .overview):
(.timeline-view.memory > .content .title):
(.timeline-view.memory > .content .subtitle):
(.timeline-view.memory > .content > .details > .timeline-ruler):
(.timeline-view.memory > .content > .details > .subtitle):
(.timeline-view.memory > .content > .overview > .chart):
(.timeline-view.memory > .content > .overview > .chart > .subtitle):
(.timeline-view.memory > .content > .overview > .chart > .container):
(.timeline-view.memory > .content > .overview > .divider):
(.timeline-view.memory > .content > .overview .max-percentage):
(.timeline-view.memory .legend):
(.timeline-view.memory .legend > .row):
(.timeline-view.memory .legend > .row > .swatch):
(.timeline-view.memory .legend > .row > p):
(.timeline-view.memory .legend > .row > .label):
(.timeline-view.memory .legend > .row > .size):
(.timeline-view.memory .legend > .row > .swatch.javascript):
(.timeline-view.memory .legend > .row > .swatch.images):
(.timeline-view.memory .legend > .row > .swatch.layers):
(.timeline-view.memory .legend > .row > .swatch.page):
(.memory-category-view.javascript .line-chart > svg > path):
(.memory-category-view.images .line-chart > svg > path):
(.memory-category-view.layers .line-chart > svg > path):
(.memory-category-view.page .line-chart > svg > path):
(.timeline-view.memory .legend > .row > .swatch.current):
(.timeline-view.memory .circle-chart > svg > path.current):
(.timeline-view.memory .circle-chart > svg > path.remainder):
- UserInterface/Views/MemoryTimelineView.js: Added.
(WebInspector.MemoryTimelineView):
(WebInspector.MemoryTimelineView.displayNameForCategory):
(WebInspector.MemoryTimelineView.prototype.get navigationSidebarTreeOutlineLabel):
(WebInspector.MemoryTimelineView.prototype.shown):
(WebInspector.MemoryTimelineView.prototype.hidden):
(WebInspector.MemoryTimelineView.prototype.closed):
(WebInspector.MemoryTimelineView.prototype.reset):
(WebInspector.MemoryTimelineView.prototype.treeElementPathComponentSelected):
(WebInspector.MemoryTimelineView.prototype.layout.timeToX):
(WebInspector.MemoryTimelineView.prototype.layout.sizeToY):
(WebInspector.MemoryTimelineView.prototype.layout.layoutCategoryView):
(WebInspector.MemoryTimelineView.prototype.layout):
(WebInspector.MemoryTimelineView.prototype._clearUsageLegend):
(WebInspector.MemoryTimelineView.prototype._updateUsageLegend):
(WebInspector.MemoryTimelineView.prototype._clearMaxComparisonLegend):
(WebInspector.MemoryTimelineView.prototype._updateMaxComparisonLegend):
(WebInspector.MemoryTimelineView.prototype._visibleRecords):
(WebInspector.MemoryTimelineView.prototype._initializeCategoryViews.appendLegendRow):
(WebInspector.MemoryTimelineView.prototype._initializeCategoryViews):
(WebInspector.MemoryTimelineView.prototype._memoryTimelineRecordAdded):
- UserInterface/Views/Variables.css:
(:root):
Memory timeline view styles.
Source/WebKit/mac:
- Configurations/FeatureDefines.xcconfig:
Source/WebKit2:
- Configurations/FeatureDefines.xcconfig:
LayoutTests:
- inspector/memory/tracking-expected.txt: Added.
- inspector/memory/tracking.html: Added.
Basic test for the new domain tracking commands and events.
- platform/efl/TestExpectations:
- platform/gtk/TestExpectations:
- platform/win/TestExpectations:
Skip the directory on ports that have not implemented ENABLE(RESOURCE_USAGE).
- 5:51 PM Changeset in webkit [195998] by
-
- 4 edits in trunk/Source
Fix CMake build.
- PlatformMac.cmake:
- 5:42 PM Changeset in webkit [195997] by
-
- 13 edits2 adds in trunk/Source/WebCore
Modern IDB: Cursors (still) do not keep their opening request alive.
https://bugs.webkit.org/show_bug.cgi?id=153724
Reviewed by Alex Christensen.
No new tests (All existing tests pass without flakiness).
IDBCursors did not properly keep their JS wrappers alive.
Making them ActiveDOMObjects that keep track of how many requests might be in flight fixes this.
This also makes them actually keep their opening-request live via the opaque-root mechanism.
IDBCursorWithValue also needed to opt in to all of these mechanisms.
- CMakeLists.txt:
- WebCore.xcodeproj/project.pbxproj:
- Modules/indexeddb/IDBCursor.h:
(WebCore::IDBCursor::hasPendingActivity): The base IDBCursor always has no pending activity,
to maintain current behavior in LegacyIDB. This weirdness will go away when LegacyIDB does.
- Modules/indexeddb/IDBCursor.idl:
- Modules/indexeddb/IDBCursorWithValue.idl:
Track a count for all outstanding requests to keep the cursor alive as an ActiveDOMObject.
- Modules/indexeddb/client/IDBCursorImpl.cpp:
(WebCore::IDBClient::IDBCursor::IDBCursor):
(WebCore::IDBClient::IDBCursor::update):
(WebCore::IDBClient::IDBCursor::uncheckedIterateCursor):
(WebCore::IDBClient::IDBCursor::deleteFunction):
(WebCore::IDBClient::IDBCursor::activeDOMObjectName):
(WebCore::IDBClient::IDBCursor::canSuspendForDocumentSuspension):
(WebCore::IDBClient::IDBCursor::hasPendingActivity):
(WebCore::IDBClient::IDBCursor::decrementOutstandingRequestCount):
- Modules/indexeddb/client/IDBCursorImpl.h:
Rework the "delete" family of functions on the object store to allow for returning a modern IDBRequest.
A lot of this can go away when LegacyIDB does.
- Modules/indexeddb/client/IDBObjectStoreImpl.cpp:
(WebCore::IDBClient::IDBObjectStore::deleteFunction):
(WebCore::IDBClient::IDBObjectStore::doDelete):
(WebCore::IDBClient::IDBObjectStore::modernDelete):
- Modules/indexeddb/client/IDBObjectStoreImpl.h:
- Modules/indexeddb/client/IDBRequestImpl.cpp:
(WebCore::IDBClient::IDBRequest::setSource): Setup a ScopeGuard to decrement the cursor's request
count whenever it makes sense to do so.
(WebCore::IDBClient::IDBRequest::dispatchEvent): Clear the ScopeGuard (if it exists) to decrement the count.
(WebCore::IDBClient::IDBRequest::willIterateCursor): Set the ScopeGuard.
(WebCore::IDBClient::IDBRequest::didOpenOrIterateCursor): Clear the ScopeGuard (if it exists) to decrement the count.
- Modules/indexeddb/client/IDBRequestImpl.h:
- Modules/indexeddb/server/UniqueIDBDatabase.cpp:
(WebCore::IDBServer::ScopeGuard::ScopeGuard): Deleted.
(WebCore::IDBServer::ScopeGuard::~ScopeGuard): Deleted.
(WebCore::IDBServer::ScopeGuard::enable): Deleted.
(WebCore::IDBServer::ScopeGuard::disable): Deleted.
- bindings/js/JSIDBCursorWithValueCustom.cpp: Added.
(WebCore::JSIDBCursorWithValue::visitAdditionalChildren):
- platform/ScopeGuard.h: Added.
(WebCore::ScopeGuard::ScopeGuard):
(WebCore::ScopeGuard::~ScopeGuard):
(WebCore::ScopeGuard::enable):
(WebCore::ScopeGuard::disable):
- 5:39 PM Changeset in webkit [195996] by
-
- 2 edits in trunk/LayoutTests
Skipping http/tests/plugins/visible_plugins.html on Yosemite during investigation.
https://bugs.webkit.org/show_bug.cgi?id=153752
Unreviewed test gardening.
- platform/mac/TestExpectations:
- 5:27 PM Changeset in webkit [195995] by
-
- 8 edits in trunk/Source/WebInspectorUI
Web Inspector: add a LayoutReason enum to the View base class
https://bugs.webkit.org/show_bug.cgi?id=153731
<rdar://problem/24430938>
Reviewed by Brian Burg.
Added a LayoutReason enum to the View base class, which can be passed as an optional
argument to needsLayout() and updateLayout(). The value is propagated to the view's
subtree during layout.
- UserInterface/Base/Main.js:
Update top-level views with Resize layout reason when window is resized.
- UserInterface/Views/DataGrid.js:
(WebInspector.DataGrid.prototype._positionHeaderViews):
Update header view with Resize layout reason when column is resized.
- UserInterface/Views/OverviewTimelineView.js:
(WebInspector.OverviewTimelineView.prototype.shown):
Assume the view has been resized when shown, and update layout.
(WebInspector.OverviewTimelineView.prototype.updateLayoutForResize): Deleted.
No longer needed, handled by the View base class.
- UserInterface/Views/TimelineOverview.js:
(WebInspector.TimelineOverview.prototype.shown):
Assume the view has been resized when shown, and update layout.
(WebInspector.TimelineOverview.prototype.layout):
Invalidate cached scroll container width if resized.
(WebInspector.TimelineOverview.prototype.updateLayoutForResize): Deleted.
No longer needed, handled by the View base class.
- UserInterface/Views/TimelineRecordingContentView.js:
(WebInspector.TimelineRecordingContentView.prototype.layout): Deleted.
No longer needed, handled by the View base class.
- UserInterface/Views/TimelineRuler.js:
(WebInspector.TimelineRuler.prototype.needsLayout):
(WebInspector.TimelineRuler.prototype.layout):
Update cached client width if resized.
(WebInspector.TimelineRuler.prototype.resize): Deleted.
Moved resize logic to layout override.
- UserInterface/Views/View.js:
(WebInspector.View):
(WebInspector.View.prototype.updateLayout):
Set layout reason.
(WebInspector.View.prototype.needsLayout):
Set layout reason even if an animation frame has already been scheduled,
since the layout reason could have changed.
(WebInspector.View.prototype._layoutSubtree):
Propagate layout reason to subtree, and reset the value when done.
(WebInspector.View.prototype._setLayoutReason):
Helper method for updating the layout reason. Ensures that LayoutReason.Resize
has priority over the default (LayoutReason.Dirty).
- 5:12 PM Changeset in webkit [195994] by
-
- 2 edits in trunk/LayoutTests
Marking imported/w3c/web-platform-tests/streams-api/readable-streams/garbage-collection-1.html as flaky on Mac debug
https://bugs.webkit.org/show_bug.cgi?id=153781
Unreviewed test gardening.
- platform/mac/TestExpectations:
- 4:55 PM Changeset in webkit [195993] by
-
- 4 edits1 add in trunk/Tools
Add code to parse the git branches out of the Trac RSS feed https://bugs.webkit.org/show_bug.cgi?id=153624
Reviewed by Daniel Bates.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
(Trac.prototype.commitsOnBranch): Update filter to check for Git branches.
(Trac.prototype._convertCommitInfoElementToObject): Parse Git branches from the Trac RSS feed. Also changed "branchName" to
"branches" and updated the code to work with an array instead of a string.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockTrac.js:
(MockTrac): Refactored example commits out into a constant, MockTrac.EXAMPLE_TRAC_COMMITS.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/test-fixture-git-trac-rss.xml: Added. Test
fixture that contains XML with a Git branch.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js: Added unit test to test parsing Git
branches from Trac RSS feed. Also updated code to work with the new MockTrac.EXAMPLE_TRAC_COMMITS constant.
- 4:46 PM Changeset in webkit [195992] by
-
- 2 edits in trunk/Source/WebCore
Free Colormap when XWindow is destroyed.
https://bugs.webkit.org/show_bug.cgi?id=153413
Patch by Sun-woo Nam <sunny.nam@samsung.com> on 2016-02-01
Reviewed by Žan Doberšek.
Colormap is needed to create XWindow and it should be freed when XWindow is destroyed.
Unless Colormap is freed before destroying XWindow, memory leak is suspected.
XFreeColormap therefore is needed on X11Helper.
- platform/graphics/surfaces/glx/X11Helper.cpp: Added XFreeColormap.
(WebCore::X11Helper::destroyWindow):
- 4:45 PM Changeset in webkit [195991] by
-
- 2 edits in trunk/Source/WebKit2
More iOS build fix.
- Platform/spi/ios/UIKitSPI.h:
- 4:41 PM Changeset in webkit [195990] by
-
- 2 edits in trunk/Source/WebKit2
iOS build fix.
- Platform/IPC/mac/ConnectionMac.mm:
- 4:35 PM Changeset in webkit [195989] by
-
- 2 edits in trunk/Source/WebKit2
Copy sandbox profiles during installhdrs.
Reviewed by Anders Carlsson.
- Configurations/SandboxProfiles.xcconfig:
- 4:32 PM Changeset in webkit [195988] by
-
- 1 edit2 adds in branches/safari-601-branch/LayoutTests
Merge Layout Tests for r191331. rdar://problem/24448992
- 4:20 PM Changeset in webkit [195987] by
-
- 3 edits2 adds in branches/safari-601-branch
Merge r195837. rdar://problem/24002220
- 4:19 PM WebKitGTK/Gardening/Calendar edited by
- (diff)
- 4:00 PM Changeset in webkit [195986] by
-
- 4 edits in trunk/LayoutTests
[GTK] Unreviewed GTK+ Gardening.
- platform/efl/TestExpectations: Add fast/shadow-dom/slot-removal-crash-2.html timeout expectation.
- platform/gtk/TestExpectations: Report and update a bunch of test expectations.
- platform/win/TestExpectations: Add fast/shadow-dom/slot-removal-crash-2.html timeout expectation.
- 3:55 PM Changeset in webkit [195985] by
-
- 7 edits in trunk/Source/WebKit2
[Cocoa] Remove some more has_include guards
https://bugs.webkit.org/show_bug.cgi?id=153774
Reviewed by Tim Horton.
Guard private header includes with #if USE(APPLE_INTERNAL_SDK) rather than with has_include.
- Platform/IPC/mac/ConnectionMac.mm:
- Platform/IPC/mac/ImportanceAssertion.h:
- Shared/EntryPointUtilities/mac/XPCService/XPCServiceEntryPoint.h:
- Shared/cf/ArgumentCodersCF.cpp:
- Shared/mac/ChildProcessMac.mm:
- Shared/mac/SecItemShim.cpp:
- 3:40 PM Changeset in webkit [195984] by
-
- 2 edits in trunk/Tools
Add command line flag to DRT to output the number of tests completed in server mode.
https://bugs.webkit.org/show_bug.cgi?id=153750
Reviewed by Darin Adler.
- DumpRenderTree/mac/DumpRenderTree.mm:
(initializeGlobalsFromCommandLineOptions):
(runTestingServerLoop):
- 3:37 PM Changeset in webkit [195983] by
-
- 3 edits in trunk/Source/WebKit2
[Xcode] Let Xcode know that the WebKit XPC service products are XPC services
https://bugs.webkit.org/show_bug.cgi?id=153773
Reviewed by Tim Horton.
- Configurations/BaseXPCService.xcconfig: Removed now-redundant definitions of MACH_O_TYPE and WRAPPER_EXTENSION.
- WebKit2.xcodeproj/project.pbxproj: Updated product types.
- 3:31 PM Changeset in webkit [195982] by
-
- 2 edits in trunk/Source/WebKit2
Crash using WKPDFView, in -[UIPDFPageView showContent]
https://bugs.webkit.org/show_bug.cgi?id=153770
<rdar://problem/20157864>
Reviewed by Anders Carlsson.
When scrolling, we throw away UIPDFPageViews, but forget to unhook their delegates.
In some cases (also because their delegate is a raw pointer, not weak), they can call
back into a deleted WKPDFView, causing a crash.
- UIProcess/ios/WKPDFView.mm:
(detachViewForPage):
Add a helper to detach a page view, and unhook its delegates.
(-[WKPDFView _clearPages]):
(-[WKPDFView _revalidateViews]):
Make use of the new helper.
- 3:19 PM Changeset in webkit [195981] by
-
- 3 edits in trunk/Source/JavaScriptCore
[JSC] IRC can coalesce the frame pointer with a Tmp that is modified
https://bugs.webkit.org/show_bug.cgi?id=153694
Reviewed by Filip Pizlo.
Let's say we have:
Move(FP, Tmp1)
Add64(#1, Tmp1)
If we were to coalesce the Move, we would modify the frame pointer.
Well, that's exactly what was happening with IRC.
Since the epilogue is not know to Air before IRC, the liveness analysis
never discovers that FP is live when Tmp1 is UseDef by Add64. Adding
FP would a be a problem anyway for a bunch of reasons.
I tried two ways to prevent IRC to override IRC:
1) Add an interference edge with FP for all non-duplication Defs.
2) Let coalesce() know about FP and constraint any coalescing with a re-Def.
The two are within margin of error for performance. The second one was considerably
more complicated. This patch implements the first one.
Some extra note:
-It is very important to not increment the degree of a Tmp when making it interfere
with FP. FP is not a valid color, it is not counted in the "K" colors considered
for coloring. Increasing the degree with the edge to FP would make every stage
pessimistic since there is an extra degree that can never be removed.
-I put "interferenceEdges" and "adjacencyList" in an inconsistent state.
This is intentional, "interferenceEdges" is used to test the existence of an edge,
"adjacencyList" is used to go over all the edges. In this case, we don't want
the edge with FP to be considered when pruning the graph.
- b3/air/AirIteratedRegisterCoalescing.cpp:
One branch could be transformed into an assertion: TmpLiveness is type specific now.
- b3/testb3.cpp:
(JSC::B3::testOverrideFramePointer):
(JSC::B3::run):
- 2:13 PM Changeset in webkit [195980] by
-
- 2 edits in trunk/LayoutTests
Marking imported/w3c/web-platform-tests/XMLHttpRequest/open-url-multi-window-4.htm as flaky on ios-simulator
https://bugs.webkit.org/show_bug.cgi?id=153336
Unreviewed test gardening.
- platform/ios-simulator/TestExpectations:
- 2:07 PM Changeset in webkit [195979] by
-
- 3 edits in trunk/Source/WebCore
Move some SPI declarations into the appropriate SPI header
https://bugs.webkit.org/show_bug.cgi?id=153755
Reviewed by Darin Adler.
- platform/graphics/cocoa/IOSurface.mm:
- platform/spi/cg/CoreGraphicsSPI.h:
- 1:50 PM Changeset in webkit [195978] by
-
- 2 edits in trunk/LayoutTests
Marking http/tests/appcache/404-resource-with-slow-main-resource.php as flaky on ios-simulator-wk2
https://bugs.webkit.org/show_bug.cgi?id=153503
Unreviewed test gardening.
- platform/ios-simulator/TestExpectations:
- 1:31 PM Changeset in webkit [195977] by
-
- 2 edits in trunk/LayoutTests
Marking fast/replaced/preferred-widths.html as flaky on ios-simulator
https://bugs.webkit.org/show_bug.cgi?id=153311
Unreviewed test gardening.
- platform/ios-simulator/TestExpectations:
- 1:25 PM Changeset in webkit [195976] by
-
- 2 edits in trunk/LayoutTests
Skip fast/shadow-dom/touch-event-ios.html on ios-simulator since touch events are not supported.
https://bugs.webkit.org/show_bug.cgi?id=149592
Unreviewed test gardening.
- platform/ios-simulator/TestExpectations:
- 12:47 PM Changeset in webkit [195975] by
-
- 2 edits in trunk/Source/WebCore
Snapshot surfaces are forever wired after being compressed
https://bugs.webkit.org/show_bug.cgi?id=153751
<rdar://problem/24354546>
Reviewed by Darin Adler.
- platform/graphics/cocoa/IOSurface.mm:
(IOSurface::convertToFormat):
Allow IOSurfaceAccelerator to unwire surfaces after they're transformed.
- 12:40 PM Changeset in webkit [195974] by
-
- 2 edits in tags/Safari-602.1.18.0.1/Source/WebKit2
Merged r195964. rdar://problem/24424987
- 12:35 PM Changeset in webkit [195973] by
-
- 5 edits in tags/Safari-602.1.18.0.1/Source
Versioning.
- 12:33 PM Changeset in webkit [195972] by
-
- 1 copy in tags/Safari-602.1.18.0.1
New tag.
- 12:23 PM Changeset in webkit [195971] by
-
- 5 edits in trunk/Source
<rdar://problem/20150072> [iOS] Remove some file upload code only needed before iOS 9
https://bugs.webkit.org/show_bug.cgi?id=153754
Reviewed by Darin Adler.
Source/WebCore:
- English.lproj/Localizable.strings: Updated for removal of WebKit2 string.
Source/WebKit2:
- Platform/spi/ios/UIKitSPI.h: Removed conditional forward declaration of SPI.
- UIProcess/ios/forms/WKFileUploadPanel.mm:
(photoLibraryIcon): Removed check for HAVE_WEBKIT_DOC_PICKER_ICONS, which is always true in
iOS 9 and later.
(cameraIcon): Ditto.
(-[WKFileUploadPanel presentWithParameters:resultListener:]): Removed branch for when
UIDocumentMenuViewController doesn’t respond to
-_initIgnoringApplicationEntitlementForImportOfTypes:.
(-[WKFileUploadPanel _showMediaSourceSelectionSheet]): Deleted now-unused method.
- 11:45 AM Changeset in webkit [195970] by
-
- 8 edits in trunk/Source
Cache the Path instead of creating it every time it is required
https://bugs.webkit.org/show_bug.cgi?id=152939
Patch by Said Abou-Hallawa <sabouhallawa@apple.com> on 2016-02-01
Reviewed by Darin Adler.
Source/WebCore:
Instead of creating the Path object every time it is required, we should
cache it in an LRU cache. TinyLRUCache returns a reference to the cached
entry so we do not have to pay the cost of copying it either.
- platform/graphics/FloatRoundedRect.h:
(WebCore::operator!=):
Implement the inequality operator for FloatRoundedRect since it is
called by TinyLRUCache.
- rendering/ClipPathOperation.h:
Return a reference to the path in the cache since instead of creating a
new copy.
- rendering/style/BasicShapes.cpp:
(WebCore::SVGPathTranslatedByteStream::SVGPathTranslatedByteStream):
(WebCore::SVGPathTranslatedByteStream::operator==):
(WebCore::SVGPathTranslatedByteStream::operator!=):
(WebCore::SVGPathTranslatedByteStream::isEmpty):
(WebCore::SVGPathTranslatedByteStream::path):
This struct holds an offset and an SVGPathByteStream. It is the key of
the LRU cache for the the translated SVGPathByteStream.
(WebCore::EllipsePathPolicy::isKeyNull):
(WebCore::EllipsePathPolicy::createValueForKey):
(WebCore::RoundedRectPathPolicy::isKeyNull):
(WebCore::RoundedRectPathPolicy::createValueForKey):
(WebCore::PolygonPathPolicy::isKeyNull):
(WebCore::PolygonPathPolicy::createValueForKey):
(WebCore::TranslatedByteStreamPathPolicy::isKeyNull):
(WebCore::TranslatedByteStreamPathPolicy::createValueForKey):
Inherit from the LRU cache policy template, so have a specific name for
the desired path contents and pass this class explicitly to the LRU cache
template.
(WebCore::cachedEllipsePath):
(WebCore::cachedRoundedRectPath):
(WebCore::cachedPolygonPath):
(WebCore::cachedTranslatedByteStreamPath):
Return a cached path object for specific path contents.
(WebCore::BasicShapeCircle::path):
(WebCore::BasicShapeEllipse::path):
(WebCore::BasicShapePolygon::path):
(WebCore::BasicShapePath::path):
(WebCore::BasicShapeInset::path):
Get the Path object from the cache; create a new one if it does not exist.
- rendering/style/BasicShapes.h:
Change the prototype of the path() function to return a reference to the
path in the cache instead of a having to copying it.
- svg/SVGPathByteStream.h:
(WebCore::SVGPathByteStream::operator!=):
Implement the inequality operator for SVGPathByteStream because it is
called by TinyLRUCache.
Source/WTF:
If the key type of an LRU cache can't to be strongly tided to a specific
data type; e.g. FloatRect -> Path, we need to be able to pass the policy
type to the TinyLRUCache template instead of just specializing it. This
will make the code more readable and will allow different caches for the
same key type.
- wtf/TinyLRUCache.h:
(WebCore::TinyLRUCache::get):
- 11:42 AM Changeset in webkit [195969] by
-
- 20 edits in trunk
Move properties that use custom bindings to the prototype
https://bugs.webkit.org/show_bug.cgi?id=153735
Reviewed by Darin Adler.
LayoutTests/imported/w3c:
Rebaseline several W3C tests now that more checks are passing.
- web-platform-tests/dom/interfaces-expected.txt:
- web-platform-tests/html/dom/interfaces-expected.txt:
- web-platform-tests/XMLHttpRequest/interfaces-expected.txt:
Source/WebCore:
Move properties that use custom bindings to the prototype. Whether a
property's bindings code is generated or custom-written should not
impact where the property is located.
No new tests, already covered by existing tests.
- bindings/js/JSHTMLDocumentCustom.cpp:
(WebCore::JSHTMLDocument::getOwnPropertySlot):
Add null-check for staticPropHashTable. HTMLDocument no longer has
any property on the instance so staticPropHashTable is now null.
- bindings/scripts/CodeGeneratorJS.pm:
LayoutTests:
Rebaseline / update existing tests now that properties using custom
bindings are on the prototype, as expected.
- fast/mediastream/MediaStream-video-element-expected.txt:
- fast/xmlhttprequest/xmlhttprequest-properties-prototype-expected.txt:
- inspector/model/remote-object-get-properties-expected.txt:
- js/dom/dom-attributes-on-mismatch-type-expected.txt:
- js/dom/dom-attributes-on-mismatch-type.html:
- platform/mac/inspector/model/remote-object-expected.txt:
- 11:05 AM Changeset in webkit [195968] by
-
- 5 edits in trunk
[Win] WTFHeaderDetection.h no longer needed
https://bugs.webkit.org/show_bug.cgi?id=153753
rdar://problem/24434627
Reviewed by Darin Adler.
.:
- Source/cmake/WebKitFS.cmake:
Source/WTF:
- wtf/Platform.h:
- wtf/PlatformWin.cmake:
- 10:24 AM Changeset in webkit [195967] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Rendering Frames timeline draws all frame bars at minimum height
https://bugs.webkit.org/show_bug.cgi?id=153736
<rdar://problem/21946301>
Reviewed by Timothy Hatcher.
- UserInterface/Views/TimelineRecordingContentView.js:
(WebInspector.TimelineRecordingContentView.prototype._currentContentViewDidChange):
Update the new timeline overview's height before it's shown. Showing the
overview causes the rendering frames graph to do a layout, which requires
the height of the containing view to be a valid value.
- 10:22 AM Changeset in webkit [195966] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: DataGridNode should support adding go-to arrow buttons to any cell
https://bugs.webkit.org/show_bug.cgi?id=153733
<rdar://problem/24431813>
Reviewed by Brian Burg.
Provide a way to add go-to arrow buttons to any grid cell from within a
DataGridNode subclass's implementation of createCellContent.
- UserInterface/Views/DataGrid.js:
New event type, GoToArrowClicked.
(WebInspector.DataGridNode.prototype.createGoToArrowButton.buttonClicked):
(WebInspector.DataGridNode.prototype.createGoToArrowButton):
Adds a go-to arrow button to the cell's content element. Clicking the button
dispatches an event on the DataGrid, with event data containing the
DataGridNode and identifier of the cell containing the arrow button.
- 10:15 AM Changeset in webkit [195965] by
-
- 2 edits in trunk/Source/WebCore
REGRESSION(r195770): Use-after-free in ResourceLoaderOptions::cachingPolicy
https://bugs.webkit.org/show_bug.cgi?id=153727
<rdar://problem/24429886>
Reviewed by Chris Dumez.
The
thisobject may be freed after calling deleteIfPossible(). Make the early-return-if-
deleted more explicit, and only check allowsCaching() after the deleteIfPossible() return
value check.
- loader/cache/CachedResource.cpp:
(WebCore::CachedResource::removeClient):
- 9:56 AM Changeset in webkit [195964] by
-
- 2 edits in trunk/Source/WebKit2
Stop linking to PassKit
https://bugs.webkit.org/show_bug.cgi?id=153746
Reviewed by Tim Horton.
- Configurations/WebKit.xcconfig:
- 9:53 AM Changeset in webkit [195963] by
-
- 7 edits in trunk/Source/WebKit2
[Cocoa] Get rid of WK_ macros for initializers
https://bugs.webkit.org/show_bug.cgi?id=153744
Reviewed by Anders Carlsson.
- Shared/API/Cocoa/WKFoundation.h: Removed definitions of WK_DESIGNATED_INITIALIZER and WK_UNAVAILABLE.
- mac/postprocess-framework-headers.sh: Removed rules for rewriting the above macros. Also removed Foundation import that became unnecessary, and definitions that were only needed before iOS 8.
Replaced instances of the above macros with their expansions.
- UIProcess/API/Cocoa/WKProcessPoolPrivate.h:
- UIProcess/API/Cocoa/WKSecurityOrigin.h:
- UIProcess/API/Cocoa/WKWebView.h:
- UIProcess/API/Cocoa/WKWebsiteDataStore.h:
- 9:02 AM Changeset in webkit [195962] by
-
- 4 edits in trunk/Tools
Improvements to botwatcher's dashboard unit tests.
https://bugs.webkit.org/show_bug.cgi?id=153621
Reviewed by Darin Adler.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/PopoverTracker.js:
(PopoverTracker): Retain a reference to the PopoverTracker so that we can make assertions about it in the unit tests.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockTrac.js:
(MockTrac): Changing revision 33019 to be on a different branch so that _appendPendingRevisionCount and
_popoverLinesForCommitRange have to traverse commits from different branches.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js: Changing equal to strictEqual
in unit test for _appendPendingRevisionCount. Also added assertions for Popover in test for
_revisionContentWithPopoverForIteration.
- 9:01 AM Changeset in webkit [195961] by
-
- 3 edits in trunk/Tools
Refactor to add event listeners and start periodic updates for all trac instances.
https://bugs.webkit.org/show_bug.cgi?id=153609
Reviewed by Darin Adler.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
(BuildbotQueueView): Adding event listeners for all trac instances.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js: Starting periodic updates
for all trac instances.
- 8:00 AM Changeset in webkit [195960] by
-
- 2 edits in trunk/Source/WebCore
Tried to fix a build after r195899.
- dom/EventContext.h: Enabled TouchEventContext type trait specialization on iOS.
- 4:33 AM Changeset in webkit [195959] by
-
- 6 edits in trunk/LayoutTests
Unreviewed. Updating global-constructors-attributes expectations after introducing Request in r195954.
- 4:31 AM Changeset in webkit [195958] by
-
- 2 edits in trunk/Source/WebKit2
One more unreviewed speculative buildfix after r195755.
- PlatformMac.cmake:
- 4:19 AM Changeset in webkit [195957] by
-
- 2 edits in trunk/Source/WebKit2
Unreviewed speculative buildfix after r195755.
- PlatformMac.cmake:
- 3:26 AM Changeset in webkit [195956] by
-
- 2 edits in trunk/Source/JavaScriptCore
Unreviewed speculative buildfix.
- dfg/DFGCommon.h: FTL_USES_B3 should be false if FTL JIT is disabled.
- 3:20 AM Changeset in webkit [195955] by
-
- 2 edits in trunk/Source/WebKit2
Unreviewed speculative buildfix after r195795.
- PlatformMac.cmake: Remove Shared/EntryPointUtilities/mac/XPCService/XPCServiceMain.Development.mm.
- 3:05 AM Changeset in webkit [195954] by
-
- 23 edits2 copies36 adds in trunk
[Fetch API] Implement Fetch API Request
https://bugs.webkit.org/show_bug.cgi?id=153437
LayoutTests/imported/w3c:
Reviewed by Darin Adler.
- web-platform-tests/fetch/api/headers/headers-basic.html:
- web-platform-tests/fetch/api/request/request-clone.sub-expected.txt: Added.
- web-platform-tests/fetch/api/request/request-clone.sub.html: Added.
- web-platform-tests/fetch/api/request/request-consume-expected.txt: Added.
- web-platform-tests/fetch/api/request/request-consume.html: Added.
- web-platform-tests/fetch/api/request/request-disturbed-expected.txt: Added.
- web-platform-tests/fetch/api/request/request-disturbed.html: Added.
- web-platform-tests/fetch/api/request/request-error-expected.txt: Added.
- web-platform-tests/fetch/api/request/request-error.html: Added.
- web-platform-tests/fetch/api/request/request-headers-expected.txt: Added.
- web-platform-tests/fetch/api/request/request-headers.html: Added.
- web-platform-tests/fetch/api/request/request-idl-expected.txt: Added.
- web-platform-tests/fetch/api/request/request-idl.html: Added.
- web-platform-tests/fetch/api/request/request-init-001.sub-expected.txt: Added.
- web-platform-tests/fetch/api/request/request-init-001.sub.html: Added.
- web-platform-tests/fetch/api/request/request-init-002-expected.txt: Added.
- web-platform-tests/fetch/api/request/request-init-002.html: Added.
- web-platform-tests/fetch/api/request/request-init-003.sub-expected.txt: Added.
- web-platform-tests/fetch/api/request/request-init-003.sub.html: Added.
- web-platform-tests/fetch/api/request/request-structure-expected.txt: Added.
- web-platform-tests/fetch/api/request/request-structure.html: Added.
- web-platform-tests/fetch/api/resources/authentication.py: Added.
(main):
- web-platform-tests/fetch/api/resources/clean-stash.py: Added.
(main):
- web-platform-tests/fetch/api/resources/inspect-headers.py: Added.
(main):
- web-platform-tests/fetch/api/resources/method.py: Added.
(main):
- web-platform-tests/fetch/api/resources/preflight.py: Added.
(main):
- web-platform-tests/fetch/api/resources/redirect.py: Added.
(main):
- web-platform-tests/fetch/api/resources/top.txt: Added.
- web-platform-tests/fetch/api/resources/trickle.py: Added.
(main):
- web-platform-tests/fetch/api/resources/utils.js: Added.
(catch):
(dirname):
(checkRequest):
(readTextStream):
Source/WebCore:
Added support for Fetch Request and Body.
Body is sharing functionality between Request and Response.
Conversion between various body types are not implemented yet.
Added a FetchOptions class. Options in this class are partially redundant with ResourceLoaderOptions.
Fixing bug in Headers constructor.
Making error reporting in case of modifying headers compliant with the spec.
Reviewed by Darin Adler.
Tests: imported/w3c/web-platform-tests/fetch/api/request/request-clone.sub.html
imported/w3c/web-platform-tests/fetch/api/request/request-consume.html
imported/w3c/web-platform-tests/fetch/api/request/request-disturbed.html
imported/w3c/web-platform-tests/fetch/api/request/request-error.html
imported/w3c/web-platform-tests/fetch/api/request/request-headers.html
imported/w3c/web-platform-tests/fetch/api/request/request-idl.html
imported/w3c/web-platform-tests/fetch/api/request/request-init-001.sub.html
imported/w3c/web-platform-tests/fetch/api/request/request-init-002.html
imported/w3c/web-platform-tests/fetch/api/request/request-init-003.sub.html
imported/w3c/web-platform-tests/fetch/api/request/request-structure.html
- CMakeLists.txt:
- DerivedSources.cpp:
- DerivedSources.make:
- Modules/fetch/FetchBody.cpp: Added.
(WebCore::FetchBody::initBody):
(WebCore::FetchBody::clear):
(WebCore::FetchBody::processIfEmptyOrDisturbed):
(WebCore::FetchBody::arrayBuffer):
(WebCore::FetchBody::formData):
(WebCore::FetchBody::blob):
(WebCore::FetchBody::text):
(WebCore::FetchBody::json):
- Modules/fetch/FetchBody.h: Added.
(WebCore::FetchBody::~FetchBody):
(WebCore::FetchBody::isEmpty):
(WebCore::FetchBody::isDisturbed):
(WebCore::FetchBody::setDisturbed):
(WebCore::FetchBody::setMimeType):
(WebCore::FetchBody::mimeType):
- Modules/fetch/FetchBody.idl: Added.
- Modules/fetch/FetchHeaders.cpp:
(WebCore::canWriteHeader):
(WebCore::FetchHeaders::append):
(WebCore::FetchHeaders::remove):
(WebCore::FetchHeaders::set):
(WebCore::FetchHeaders::fill): Helper routine implementing https://fetch.spec.whatwg.org/#concept-headers-fill
- Modules/fetch/FetchHeaders.h: Adding header getter/setter for FetchRequest.
(WebCore::FetchHeaders::fastGet):
(WebCore::FetchHeaders::fastSet):
- Modules/fetch/FetchHeaders.js: Fixing bug in constructor (covered by modified headers-basc.html test).
(initializeFetchHeaders):
- Modules/fetch/FetchOptions.h: Added.
(WebCore::FetchOptions::FetchOptions):
(WebCore::FetchOptions::type):
(WebCore::FetchOptions::destination):
(WebCore::FetchOptions::mode):
(WebCore::FetchOptions::credentials):
(WebCore::FetchOptions::cache):
(WebCore::FetchOptions::redirect):
(WebCore::FetchOptions::referrerPolicy):
(WebCore::FetchOptions::setType):
(WebCore::FetchOptions::setDestination):
(WebCore::FetchOptions::setMode):
(WebCore::FetchOptions::setCredentials):
(WebCore::FetchOptions::setCache):
(WebCore::FetchOptions::setRedirect):
(WebCore::FetchOptions::setReferrerPolicy):
- Modules/fetch/FetchRequest.cpp: Added.
(WebCore::FetchRequest::create):
(WebCore::FetchRequest::FetchRequest):
(WebCore::FetchRequest::init):
(WebCore::FetchRequest::setReferrer):
(WebCore::FetchRequest::setReferrerPolicy):
(WebCore::FetchRequest::setMode):
(WebCore::FetchRequest::setCredentials):
(WebCore::FetchRequest::setCache):
(WebCore::FetchRequest::setRedirect):
(WebCore::FetchRequest::type):
(WebCore::FetchRequest::destination):
(WebCore::FetchRequest::referrerPolicy):
(WebCore::FetchRequest::referrer):
(WebCore::FetchRequest::mode):
(WebCore::FetchRequest::credentials):
(WebCore::FetchRequest::cache):
(WebCore::FetchRequest::redirect):
(WebCore::FetchRequest::setMethod):
(WebCore::FetchRequest::clone):
- Modules/fetch/FetchRequest.h: Added.
(WebCore::FetchRequest::method):
(WebCore::FetchRequest::url):
(WebCore::FetchRequest::integrity):
(WebCore::FetchRequest::headers):
- Modules/fetch/FetchRequest.idl: Added.
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/Dictionary.h:
(WebCore::Dictionary::execState):
- bindings/js/JSDictionary.cpp:
(WebCore::JSDictionary::convertValue):
- bindings/js/JSDictionary.h:
(WebCore::JSDictionary::get):
LayoutTests:
Reviewed by Darin Adler.
- js/dom/global-constructors-attributes-dedicated-worker-expected.txt:
- js/dom/global-constructors-attributes-expected.txt:
- platform/efl/js/dom/global-constructors-attributes-dedicated-worker-expected.txt:
- platform/efl/js/dom/global-constructors-attributes-expected.txt:
- platform/gtk/js/dom/global-constructors-attributes-expected.txt:
- platform/mac-mavericks/js/dom/global-constructors-attributes-expected.txt:
- platform/mac-yosemite/js/dom/global-constructors-attributes-expected.txt:
- platform/mac/js/dom/global-constructors-attributes-expected.txt:
- platform/win/js/dom/global-constructors-attributes-expected.txt:
Jan 31, 2016:
- 10:34 PM Changeset in webkit [195953] by
-
- 17 edits4 adds in trunk
Add resize event for HTMLMediaElement
https://bugs.webkit.org/show_bug.cgi?id=125715
Patch by Jeremy Jones <jeremyj@apple.com> on 2016-01-31
Reviewed by Darin Adler.
LayoutTests/imported/w3c:
Rebaselined test after moving 'resize' from DOMWindow.idl to GlobalEventHandlers.idl
per https://html.spec.whatwg.org/multipage/webappapis.html#globaleventhandlers
- web-platform-tests/html/dom/interfaces-expected.txt:
Source/WebCore:
Tests: http/tests/media/hls/hls-video-resize.html
media/video-resize.html
Move resize javascript event from DOMWindow.idl to GlobalEventHandlers.idl
per https://html.spec.whatwg.org/multipage/webappapis.html#globaleventhandlers
Post resize event from video element when metadata loads and when content size changes.
- dom/GlobalEventHandlers.idl: Add onresize.
- html/HTMLElement.cpp:
(WebCore::HTMLElement::createEventHandlerNameMap): Add onresizeAttr.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::setReadyState):
(WebCore::HTMLMediaElement::mediaPlayerSizeChanged):
- html/HTMLMediaElement.h:
(WebCore::HTMLMediaElement::scheduleResizeEvent):
(WebCore::HTMLMediaElement::scheduleResizeEventIfSizeChanged):
- html/HTMLVideoElement.cpp:
(WebCore::HTMLVideoElement::scheduleResizeEvent): Sechedule event.
(WebCore::HTMLVideoElement::scheduleResizeEventIfSizeChanged): Schedule event if size has changed.
- html/HTMLVideoElement.h: Add declarations.
- page/DOMWindow.idl: Remove onresize.
Source/WebInspectorUI:
Add a display name for "resize" event.
- UserInterface/Models/ScriptTimelineRecord.js:
(WebInspector.ScriptTimelineRecord.EventType.displayName):
LayoutTests:
Update test for change: move resize javascript event from DOMWindow.idl to GlobalEventHandlers.idl
per https://html.spec.whatwg.org/multipage/webappapis.html#globaleventhandlers
- fast/dom/event-handler-attributes-expected.txt: Rebaselined.
- fast/dom/event-handler-attributes.html:
Move resize from uniqueWindowEvents to eventsInGlobalEventHandlers.
- http/tests/media/hls/hls-video-resize-expected.txt: Added.
- http/tests/media/hls/hls-video-resize.html: Added.
- js/dom/dom-static-property-for-in-iteration-expected.txt: Rebaselined.
- media/video-resize-expected.txt: Added.
- media/video-resize.html: Added.
- media/video-test.js:
(requiredEvents): Deleted global. Value is now captured by closure.
(waitForEventsAndCall): Remove dependence on global variable, and fix event observation leak.
- 9:51 PM Changeset in webkit [195952] by
-
- 2 edits in trunk/Source/WebCore
Revert accidental behavior change from previous patch.
- platform/URL.cpp:
(WebCore::mimeTypeFromDataURL): Restore behavior where an empty MIME type would
be turned into "text/plain".
- 9:46 PM Changeset in webkit [195951] by
-
- 53 edits in trunk/Source
Cut down on calls to String::lower; mostly replace with convertToASCIILowercase
https://bugs.webkit.org/show_bug.cgi?id=153732
Reviewed by Dean Jackson.
Source/WebCore:
- Modules/mediasource/MediaSource.cpp:
(WebCore::MediaSource::isTypeSupported): Added comment about mysterious call
to lower(); should probably return here and remove it.
- Modules/navigatorcontentutils/NavigatorContentUtils.cpp:
(WebCore::initProtocolHandlerWhitelist): Deleted. Moved into isProtocolWhitelisted.
(WebCore::isProtocolWhitelisted): Changed set to be ASCIICaseInsensitiveHash and
initialized it using a lambda instead of a separate function.
(WebCore::verifyProtocolHandlerScheme): Added a FIXME about some case sensitive
checking of the protocol prefix here.
- Modules/plugins/QuickTimePluginReplacement.mm:
(WebCore::QuickTimePluginReplacement::supportsMimeType): Changed set to be
ASCIICaseInsensitiveHash and initialized it using a lambda instead of using
an explict check for empty.
(WebCore::QuickTimePluginReplacement::supportsFileExtension): Ditto.
- Modules/plugins/YouTubePluginReplacement.cpp:
(WebCore::queryKeysAndValues): Use convertToASCIILowercase. The keys here are
going to be all ASCII.
(WebCore::isYouTubeURL): Use equalLettersIgnoringASCIICase instead of lowercasing
the string.
(WebCore::processAndCreateYouTubeURL): Use url.protocolIsInHTTPFamily instead of
listing "http" and then "https" explicitly. Use equalLettersIgnoringASCIICase
instead of lowercasing a string.
(WebCore::YouTubePluginReplacement::youTubeURL): Ditto.
- Modules/websockets/WebSocketHandshake.cpp:
(WebCore::hostName): Use convertToASCIILowercase on host name.
(WebCore::WebSocketHandshake::host): Ditto.
- accessibility/atk/WebKitAccessibleWrapperAtk.cpp:
(webkitAccessibleGetAttributes): Call convertToASCIILowercase instead of lower
to lowercase an element's tag name. This is a strange way to do things; typically
would be better to use some other function on Element, since tagName goes out of
its way to be capitalized, but some ATK expert can improve this later.
- css/CSSGrammar.y.in: Use the new convertToASCIILowercaseInPlace function rather
than the old lower function. We only need to lowercase the ASCII letters, and it's
also better to have the function have a clearer name.
- css/CSSParser.cpp:
(WebCore::convertToASCIILowercaseInPlace): Renamed from makeLower and made it deal
with only ASCII lowercasing.
(WebCore::CSSParserString::convertToASCIILowercaseInPlace): Renamed from lower.
(WebCore::isUniversalKeyword): Added. Helper for the function below that uses
equalLettersIgnoringASCIICase rather than lowercasing the string.
(WebCore::parseKeywordValue): Use isUniversalKeyword. Also clarified a comment.
(WebCore::CSSParser::parseAttr): Use convertToASCIILowercaseInPlace and delay
String creation until later in the function, using CSSParserString operations more.
- css/CSSParserValues.cpp:
(WebCore::CSSParserSelector::parsePseudoElementSelector): Use
convertToASCIILowercaseInPlace by its new name, with its new behavior.
- css/CSSParserValues.h: Tweaked comment and formatting a bit. Replaced the lower
function with the convertToASCIILowercaseInPlace function.
- css/CSSSelector.cpp:
(WebCore::CSSSelector::RareData::parseNth): Rewrote this to avoid the need to
make a lowercased copy of m_argument. Use equalLettersIgnoringASCIICase, and two
calls to find. Also use String::toIntStrict so we don't have to create String
objects for substrings.
- css/MediaQuery.cpp:
(WebCore::MediaQuery::MediaQuery): Use convertToASCIILowercase for media type name.
- css/MediaQueryExp.cpp:
(WebCore::MediaQueryExp::serialize): Use convertToASCIILowercase for media feature name.
- dom/Document.cpp:
(WebCore::isSeparator): Tweaked formatting and removed non-helpful comment.
(WebCore::processArguments): Changed this from a static member function to a non-member
file internal function. Use a std::function instead of a function pointer with a void*
pointer. Rewrote algorithm to simplify it and use StringView instead of String for the
keys and values.
(WebCore::Document::processViewport): Use a lambda instead of a function pointer to
call setViewportFeature, so that function's interface is no longer dictated by
the exact type of the function pointer argument to processArguments.
(WebCore::Document::processFormatDetection): Use a lambda instead of the
setParserFeature function above; use equalLettersIgnoringASCIICase for both the
key and the value, since processArguments no longer lowercases the string.
(WebCore::Document::processArguments): Deleted.
- dom/Document.h: Removed unnecessary declaration of processArguments and
ArgumentsCallback. Both are now private to the cpp file.
- dom/Element.cpp:
(WebCore::makeIdForStyleResolution): Use convertToASCIILowercase. When in quirks mode,
we want to match IDs in an ASCII case-insensitive way not match compatibility caseless.
- dom/ScriptElement.cpp:
(WebCore::ScriptElement::isScriptTypeSupported): Remove the use of lower here since
the MIME type registry is now itself ASCII case-insensitive.
- dom/ViewportArguments.cpp:
(WebCore::numericPrefix): Changed to use StringView and take a Document&, rearranged
argument order so Document& comes first.
(WebCore::findSizeValue): Ditto.
(WebCore::findScaleValue): Ditto.
(WebCore::findBooleanValue): Ditto. Also use std::abs instead of fabs, possibly
avoiding a conversion from float to double (not sure it was happening before but it's
definitely not happening now).
(WebCore::setViewportFeature): Changed to put arguments in a more logical order, to take
the ViewportArguments as a reference, not a void*, and to use StringView to avoid forcing
the caller to allocate strings. Also changed to use equalLettersIgnoringASCIICase so we
don't rely on the caller to make the key lowercase for us.
(WebCore::reportViewportWarning): Changed argument types. Added a couple comments about
mistakes in the function.
- dom/ViewportArguments.h: Removed unnecessary declaration of reportViewportWarning,
which is now private to the cpp file. Updated for new arguments to setViewportFeature.
- editing/EditorCommand.cpp:
(WebCore::executeFormatBlock): Use convertToASCIILowercase on the argument, which is
specifying a tag name.
- fileapi/Blob.cpp:
(WebCore::Blob::isValidContentType): Removed unnecessary separate loops for
8-bit and 16-bit strings. Content types are short strings and this small optimization is
not worth the additional code complexity.
(WebCore::Blob::normalizedContentType): Use convertToASCIILowercase since valid
content types are guaranteed to be all ASCII.
(WebCore::Blob::isNormalizedContentType): Removed unnecessary separate loops for
8-bit and 16-bit strings. Content types are short strings and this small optimization is
not worth the additional code complexity.
- html/parser/HTMLParserIdioms.cpp: Added now-needed include of QualifiedName.h.
- html/parser/HTMLParserIdioms.h: Removed unneeded include of QualifiedName.h and
WTFString.h. Made sure every function is declared first, even if it's also defined
later in the header in the section for functions templates and inline functions.
- loader/archive/ArchiveFactory.cpp:
(WebCore::ArchiveFactory::registerKnownArchiveMIMETypes): Use auto& for the type of
the set of MIME types here, since it's now using ASCIICaseInsensitiveHash.
- platform/MIMETypeRegistry.cpp: Changed the MIME type sets to use
ASCIICaseInsensitiveHash since MIME type are not case sensitive.
(WebCore::initializeSupportedImageMIMETypes): Use a modern for loop.
(WebCore::initializeSupportedImageMIMETypesForEncoding): Updated for HashSet type change.
(WebCore::initializePDFMIMETypes): Use a modern for loop.
(WebCore::initializeSupportedNonImageMimeTypes): Use a modern for loop.
(WebCore::initializeSupportedMediaMIMETypes): Updated for HashSet type change.
(WebCore::initializeUnsupportedTextMIMETypes): Use a modern for loop.
(WebCore::initializeMIMETypeRegistry): Updated for HashSet type change.
(WebCore::MIMETypeRegistry::getSupportedImageMIMETypes): Ditto.
(WebCore::MIMETypeRegistry::getSupportedImageResourceMIMETypes): Ditto.
(WebCore::MIMETypeRegistry::getSupportedImageMIMETypesForEncoding): Ditto.
(WebCore::MIMETypeRegistry::getSupportedNonImageMIMETypes): Ditto.
(WebCore::MIMETypeRegistry::getSupportedMediaMIMETypes): Ditto.
(WebCore::MIMETypeRegistry::getPDFMIMETypes): Ditto.
(WebCore::MIMETypeRegistry::getPDFAndPostScriptMIMETypes): Ditto.
(WebCore::MIMETypeRegistry::getUnsupportedTextMIMETypes): Ditto.
(WebCore::mimeTypeAssociationMap): Use ASCIICaseInsensitiveHash.
(WebCore::MIMETypeRegistry::getNormalizedMIMEType): Use auto to make code tighter.
- platform/MIMETypeRegistry.h: Changed return types of the getMIMETypes functions
to use ASCIICaseInsensitiveHash.
- platform/SchemeRegistry.cpp:
(WebCore::schemesForbiddenFromDomainRelaxation): Changed type to
use ASCIICaseInsensitiveHash.
- platform/URL.cpp:
(WebCore::mimeTypeFromDataURL): Use convertToASCIILowercase instead of lower.
Also removed some dead code that tried to handle the case where the data URL
has a comma as one of the first 5 characters: That can't happen since it's a
precondition of this function that the first five characters are "data:".
- platform/graphics/MediaPlayer.cpp:
(WebCore::MediaPlayer::getSupportedTypes): Change type of argument to
a HashSet with ASCIICaseInsensitiveHash.
- platform/graphics/MediaPlayer.h: Ditto.
- platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
(WebCore::MediaPlayerPrivateAVFoundation::staticMIMETypeList):
Changed type of HashSet to use ASCIICaseInsensitiveHash.
- platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h: Ditto.
- platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp:
(WebCore::avfMIMETypes):
Changed type of HashSet to use ASCIICaseInsensitiveHash.
(WebCore::MediaPlayerPrivateAVFoundationCF::getSupportedTypes): Ditto.
- platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.h: Ditto.
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
Changed type of HashSet to use ASCIICaseInsensitiveHash.
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::paintWithImageGenerator): Removed
an unnecessary line of code to set a local variable to 0 just before it falls
out of scope.
(WebCore::avfMIMETypes): Ditto. Also tightened up the code a bit.
(WebCore::MediaPlayerPrivateAVFoundationObjC::getSupportedTypes): Ditto.
- platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.h:
Changed type of HashSet to use ASCIICaseInsensitiveHash.
- platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:
(WebCore::mimeTypeCache): Ditto.
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::getSupportedTypes): Ditto.
- platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.h: Ditto.
- platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm:
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::getSupportedTypes): Ditto.
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::mimeTypeCache): Ditto.
(WebCore::MediaPlayerPrivateGStreamer::getSupportedTypes): Ditto.
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h: Ditto.
- platform/graphics/mac/MediaPlayerPrivateQTKit.h: Ditto.
- platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
(WebCore::shouldRejectMIMEType): Made this non-case-sensitive by using startsWith
and the "false" argument. Later change this to startsWithIgnoringASCIICase or
startsWithLettersIgnoringASCIICase.
(WebCore::addFileTypesToCache): Use ASCIICaseInsensitiveHash. ALso rewrote to
tighten up the code a bit and use modern Objective-C for loops.
(WebCore::mimeCommonTypesCache): Use ASCIICaseInsensitiveHash.
(WebCore::mimeModernTypesCache): Ditto.
(WebCore::concatenateHashSets): Ditto.
(WebCore::MediaPlayerPrivateQTKit::getSupportedTypes): Ditto.
(WebCore::MediaPlayerPrivateQTKit::disableUnsupportedTracks): Initialied
track type set using lambda, but left it case sensitive.
- platform/graphics/win/MediaPlayerPrivateMediaFoundation.cpp:
(WebCore::mimeTypeCache): Changed type of HashSet to use ASCIICaseInsensitiveHash.
(WebCore::MediaPlayerPrivateMediaFoundation::getSupportedTypes): Ditto.
- platform/graphics/win/MediaPlayerPrivateMediaFoundation.h:
- platform/mock/mediasource/MockMediaPlayerMediaSource.cpp:
(WebCore::mimeTypeCache): Ditto.
(WebCore::MockMediaPlayerMediaSource::getSupportedTypes): Ditto.
- platform/mock/mediasource/MockMediaPlayerMediaSource.h: Ditto.
Source/WebKit/mac:
- WebView/WebHTMLRepresentation.mm:
(newArrayWithStrings): Updated to use HashSet<String, ASCIICaseInsensitiveHash>
and also to use a modern for loop.
Source/WTF:
- wtf/text/StringView.h: Added toIntStrict. Not thrilled about the name of this
function, but generally it seems likely to be useful more often than toInt.
And it's needed for one call site in WebCore that was using String::lower.
- 8:44 PM Changeset in webkit [195950] by
-
- 3 edits4 adds in trunk
Add "WebKit built-in PDF" Plugin to set of publicly visible plugins
https://bugs.webkit.org/show_bug.cgi?id=153657
<rdar://problem/24413107>
Reviewed by Darin Adler.
Source/WebCore:
Tested by http/tests/plugins/visible_plugins.html.
A number of poorly-coded sites break when WebKit reports that it understands PDF mime types,
but does not have a list of plugins that the site can iterate through.
To avoid this compatibility problem, we should also expose the "WebKit built-in PDF" plugin
to avoid this edge case.
- plugins/PluginData.cpp:
(WebCore::shouldBePubliclyVisible): Add "WebKit built-in PDF" plugin.
LayoutTests:
- http/tests/plugins/visible_plugins-expected.txt: Added.
- http/tests/plugins/visible_plugins.html: Added.
- platform/mac-wk2/http/tests/plugins: Added.
- platform/mac-wk2/http/tests/plugins/visible_plugins-expected.txt: Added.
- 8:09 PM Changeset in webkit [195949] by
-
- 11 edits2 adds in trunk
AX: Add a boundary value to AXTextStateChangeType
https://bugs.webkit.org/show_bug.cgi?id=153085
Patch by Doug Russell <d_russell@apple.com> on 2016-01-31
Reviewed by Darin Adler.
Post an AT notification when navigation is attempted past
an editable element's boundaries.
Source/WebCore:
Test: accessibility/mac/selection-boundary-userinfo.html
- accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::showIntent):
- accessibility/AXTextStateChangeIntent.h:
- accessibility/mac/AXObjectCacheMac.mm:
(platformChangeTypeForWebCoreChangeType):
(WebCore::AXObjectCache::postTextStateChangePlatformNotification):
- editing/FrameSelection.cpp:
(WebCore::FrameSelection::modifyMovingRight):
(WebCore::FrameSelection::modifyMovingForward):
(WebCore::FrameSelection::modifyMovingLeft):
(WebCore::FrameSelection::modifyMovingBackward):
(WebCore::textSelectionWithDirectionAndGranularity):
(WebCore::FrameSelection::modify):
(WebCore::FrameSelection::modifyExtendingBackward): Deleted.
(WebCore::FrameSelection::textSelectionIntent): Deleted.
- editing/FrameSelection.h:
- editing/VisiblePosition.cpp:
(WebCore::VisiblePosition::next):
(WebCore::VisiblePosition::previous):
(WebCore::VisiblePosition::left):
(WebCore::VisiblePosition::right):
(WebCore::VisiblePosition::honorEditingBoundaryAtOrBefore):
(WebCore::VisiblePosition::honorEditingBoundaryAtOrAfter):
(WebCore::VisiblePosition::leftVisuallyDistinctCandidate): Deleted.
(WebCore::VisiblePosition::rightVisuallyDistinctCandidate): Deleted.
- editing/VisiblePosition.h:
- editing/VisibleUnits.cpp:
(WebCore::startOfLine):
(WebCore::logicalStartOfLine):
(WebCore::endOfLine):
(WebCore::logicalEndOfLine):
(WebCore::leftBoundaryOfLine):
(WebCore::rightBoundaryOfLine):
(WebCore::inSameLogicalLine): Deleted.
(WebCore::endOfEditableContent): Deleted.
(WebCore::isEndOfEditableOrNonEditableContent): Deleted.
- editing/VisibleUnits.h:
LayoutTests:
- accessibility/mac/selection-boundary-userinfo-expected.txt: Added.
- accessibility/mac/selection-boundary-userinfo.html: Added.
- 7:10 PM Changeset in webkit [195948] by
-
- 26 edits10 adds in trunk
CSP: Use the served CSP header for dedicated workers
https://bugs.webkit.org/show_bug.cgi?id=153157
<rdar://problem/24383254>
And
https://bugs.webkit.org/show_bug.cgi?id=153156
<rdar://problem/24383246>
Patch by Daniel Bates <dabates@apple.com> on 2016-01-31
Reviewed by Brent Fulgham.
Source/WebCore:
Inspired by Blink commit:
<https://src.chromium.org/viewvc/blink?revision=194143&view=revision>
Implement support for respecting Content Security Policy (CSP) HTTP headers included in the
HTTP response for a Web Worker's script as per section Workers of the CSP 2.0 spec,
<https://w3c.github.io/webappsec-csp/2/#processing-model-workers> (29 August 2015).
Currently a Web Worker always inherits the CSP of its owner document. Instead a web worker
will inherit the CSP of its owner document only if its script is incapable of defining a
content security policy (i.e. its origin is a globally unique identifier). Otherwise, the
CSP HTTP headers delivered with the script will be used to define the CSP for the worker.
Tests: fast/workers/worker-inherits-csp-blocks-eval.html
fast/workers/worker-inherits-csp-blocks-xhr.html
http/tests/security/contentSecurityPolicy/worker-blob-inherits-csp-blocks-eval.html
- CMakeLists.txt: Add file ContentSecurityPolicyResponseHeaders.cpp.
- WebCore.vcxproj/WebCore.vcxproj: Add files ContentSecurityPolicyResponseHeaders.{cpp, h}.
- WebCore.vcxproj/WebCore.vcxproj.filters: Ditto.
- WebCore.xcodeproj/project.pbxproj: Ditto.
- dom/Document.cpp:
(WebCore::Document::processHttpEquiv): Update code to use enum class ContentSecurityPolicyHeaderType.
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::didBeginDocument): Extract logic to collect Content Security Policy HTTP headers
into class ContentSecurityPolicyResponseHeaders and make use of it here.
- page/csp/ContentSecurityPolicy.cpp:
(WebCore::CSPDirectiveList::headerType): Modified to use enum class ContentSecurityPolicyHeaderType.
(WebCore::CSPDirectiveList::CSPDirectiveList): Ditto.
(WebCore::CSPDirectiveList::create): Ditto.
(WebCore::ContentSecurityPolicy::responseHeaders): Creates and returns a ContentSecurityPolicyResponseHeaders
object with the parsed CSP policy headers.
(WebCore::ContentSecurityPolicy::didReceiveHeaders): Processed the CSP policy headers represented by the
specified ContentSecurityPolicyResponseHeaders object.
(WebCore::ContentSecurityPolicy::deprecatedHeader): Deleted.
(WebCore::ContentSecurityPolicy::deprecatedHeaderType): Deleted.
- page/csp/ContentSecurityPolicy.h: Defines a class that represents a collection of CSP policy headers.
This class has two purposes:
- It extracts the CSP policy headers from a HTTP response (ResourceResponse object). We make use of this functionality in both FrameLoader::didBeginDocument() and Worker::didReceiveResponse().
- It serves as a memento that externalizes the internal CSP policy details of an instance of ContentSecurityPolicy. We make use of this memento functionality to support inheriting the CSP policy of the worker's owner document in a thread-safe manner. You can create and restore a memento using ContentSecurityPolicy::responseHeaders() and ContentSecurityPolicy::didReceiveHeaders(), respectively.
- page/csp/ContentSecurityPolicyResponseHeaders.cpp: Added.
(WebCore::ContentSecurityPolicyResponseHeaders::ContentSecurityPolicyResponseHeaders): Extracts the
CSP HTTP headers from a ResourceResponse object.
(WebCore::ContentSecurityPolicyResponseHeaders::isolatedCopy): Make a copy of this object that is
safe to pass to another thread.
- page/csp/ContentSecurityPolicyResponseHeaders.h: Added.
- workers/DedicatedWorkerGlobalScope.cpp:
(WebCore::DedicatedWorkerGlobalScope::create): Modified to use class ContentSecurityPolicyResponseHeaders.
- workers/DedicatedWorkerGlobalScope.h:
- workers/DedicatedWorkerThread.cpp:
(WebCore::DedicatedWorkerThread::create): Ditto.
(WebCore::DedicatedWorkerThread::DedicatedWorkerThread): Ditto.
(WebCore::DedicatedWorkerThread::createWorkerGlobalScope): Ditto.
- workers/DedicatedWorkerThread.h:
- workers/Worker.cpp:
(WebCore::Worker::didReceiveResponse): Create a ContentSecurityPolicyResponseHeaders if the origin of
the worker's script is capable of providing a CSP. Otherwise, we will inherit the CSP of the worker's owner
document in Worker::notifyFinished().
(WebCore::Worker::notifyFinished): Pass the appropriate CSP response headers to WorkerMessagingProxy::startWorkerGlobalScope().
- workers/Worker.h:
- workers/WorkerGlobalScope.cpp:
(WebCore::WorkerGlobalScope::applyContentSecurityPolicyResponseHeaders): Renamed; formerly named applyContentSecurityPolicyFromString().
Modified to take a ContentSecurityPolicyResponseHeaders and apply it to the ContentSecurityPolicy object associated with the worker.
(WebCore::WorkerGlobalScope::applyContentSecurityPolicyFromString): Deleted.
- workers/WorkerGlobalScope.h:
- workers/WorkerMessagingProxy.cpp:
(WebCore::WorkerMessagingProxy::startWorkerGlobalScope): Pass the worker's ContentSecurityPolicyResponseHeaders object.
- workers/WorkerThread.cpp:
(WebCore::WorkerThreadStartupData::WorkerThreadStartupData): Added field m_contentSecurityPolicyResponseHeaders to store
the CSP response headers to be applied to the worker's ContentSecurityPolicy object.
(WebCore::WorkerThread::WorkerThread): Modified to use ContentSecurityPolicyResponseHeaders.
(WebCore::WorkerThread::workerThread): Pass the ContentSecurityPolicyResponseHeaders object from the start up data struct
to DedicatedWorkerThread::createWorkerGlobalScope().
- workers/WorkerThread.h:
LayoutTests:
Add new tests to ensure we block eval() in blob-, file-URL workers and block XHR in a file-URL worker.
- TestExpectations: Remove now passing tests http/tests/security/contentSecurityPolicy/worker-{multiple-csp-headers, without-own-csp}.html
and update the associated bug # for tests that fail.
- fast/workers/resources/worker-inherits-csp-blocks-eval.js: Added.
(catch):
- fast/workers/resources/worker-inherits-csp-blocks-xhr.js: Added.
(catch):
- fast/workers/worker-inherits-csp-blocks-eval-expected.txt: Added.
- fast/workers/worker-inherits-csp-blocks-eval.html: Added.
- fast/workers/worker-inherits-csp-blocks-xhr-expected.txt: Added.
- fast/workers/worker-inherits-csp-blocks-xhr.html: Added.
- http/tests/security/contentSecurityPolicy/worker-blob-inherits-csp-blocks-eval-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/worker-blob-inherits-csp-blocks-eval.html: Added.
- http/tests/security/contentSecurityPolicy/worker-multiple-csp-headers-expected.txt: Updated expected results as
the result was incorrect.
- http/tests/security/contentSecurityPolicy/worker-without-own-csp-expected.txt: Ditto.
- 6:22 PM Changeset in webkit [195947] by
-
- 322 edits in trunk/LayoutTests
Unreviewed. EFL gardening: rebaseline tests after r195740. (more to follow)
- platform/efl/css1/basic/containment-expected.txt:
- platform/efl/css1/basic/contextual_selectors-expected.txt:
- platform/efl/css1/basic/grouping-expected.txt:
- platform/efl/css1/basic/id_as_selector-expected.txt:
- platform/efl/css1/basic/inheritance-expected.txt:
- platform/efl/css1/box_properties/border-expected.txt:
- platform/efl/css1/box_properties/border_bottom-expected.txt:
- platform/efl/css1/box_properties/border_bottom_inline-expected.txt:
- platform/efl/css1/box_properties/border_bottom_width-expected.txt:
- platform/efl/css1/box_properties/border_bottom_width_inline-expected.txt:
- platform/efl/css1/box_properties/border_color-expected.txt:
- platform/efl/css1/box_properties/border_color_inline-expected.txt:
- platform/efl/css1/box_properties/border_inline-expected.txt:
- platform/efl/css1/box_properties/border_left-expected.txt:
- platform/efl/css1/box_properties/border_left_inline-expected.txt:
- platform/efl/css1/box_properties/border_left_width-expected.txt:
- platform/efl/css1/box_properties/border_left_width_inline-expected.txt:
- platform/efl/css1/box_properties/border_right-expected.txt:
- platform/efl/css1/box_properties/border_right_inline-expected.txt:
- platform/efl/css1/box_properties/border_right_width-expected.txt:
- platform/efl/css1/box_properties/border_right_width_inline-expected.txt:
- platform/efl/css1/box_properties/border_style-expected.txt:
- platform/efl/css1/box_properties/border_style_inline-expected.txt:
- platform/efl/css1/box_properties/border_top-expected.txt:
- platform/efl/css1/box_properties/border_top_inline-expected.txt:
- platform/efl/css1/box_properties/border_top_width-expected.txt:
- platform/efl/css1/box_properties/border_top_width_inline-expected.txt:
- platform/efl/css1/box_properties/clear-expected.txt:
- platform/efl/css1/box_properties/clear_float-expected.txt:
- platform/efl/css1/box_properties/float-expected.txt:
- platform/efl/css1/box_properties/float_elements_in_series-expected.txt:
- platform/efl/css1/box_properties/float_margin-expected.txt:
- platform/efl/css1/box_properties/height-expected.txt:
- platform/efl/css1/box_properties/margin-expected.txt:
- platform/efl/css1/box_properties/margin_bottom-expected.txt:
- platform/efl/css1/box_properties/margin_bottom_inline-expected.txt:
- platform/efl/css1/box_properties/margin_inline-expected.txt:
- platform/efl/css1/box_properties/margin_left-expected.txt:
- platform/efl/css1/box_properties/margin_left_inline-expected.txt:
- platform/efl/css1/box_properties/margin_right-expected.txt:
- platform/efl/css1/box_properties/margin_right_inline-expected.txt:
- platform/efl/css1/box_properties/margin_top-expected.txt:
- platform/efl/css1/box_properties/margin_top_inline-expected.txt:
- platform/efl/css1/box_properties/padding-expected.txt:
- platform/efl/css1/box_properties/padding_bottom-expected.txt:
- platform/efl/css1/box_properties/padding_bottom_inline-expected.txt:
- platform/efl/css1/box_properties/padding_inline-expected.txt:
- platform/efl/css1/box_properties/padding_left-expected.txt:
- platform/efl/css1/box_properties/padding_left_inline-expected.txt:
- platform/efl/css1/box_properties/padding_right-expected.txt:
- platform/efl/css1/box_properties/padding_right_inline-expected.txt:
- platform/efl/css1/box_properties/padding_top-expected.txt:
- platform/efl/css1/box_properties/padding_top_inline-expected.txt:
- platform/efl/css1/box_properties/width-expected.txt:
- platform/efl/css1/cascade/cascade_order-expected.txt:
- platform/efl/css1/cascade/important-expected.txt:
- platform/efl/css1/classification/display-expected.txt:
- platform/efl/css1/classification/list_style-expected.txt:
- platform/efl/css1/classification/list_style_image-expected.txt:
- platform/efl/css1/classification/list_style_position-expected.txt:
- platform/efl/css1/classification/list_style_type-expected.txt:
- platform/efl/css1/classification/white_space-expected.txt:
- platform/efl/css1/color_and_background/background-expected.txt:
- platform/efl/css1/color_and_background/background_attachment-expected.txt:
- platform/efl/css1/color_and_background/background_color-expected.txt:
- platform/efl/css1/color_and_background/background_image-expected.txt:
- platform/efl/css1/color_and_background/background_position-expected.txt:
- platform/efl/css1/color_and_background/background_repeat-expected.txt:
- platform/efl/css1/color_and_background/color-expected.txt:
- platform/efl/css1/conformance/forward_compatible_parsing-expected.txt:
- platform/efl/css1/font_properties/font-expected.txt:
- platform/efl/css1/font_properties/font_family-expected.txt:
- platform/efl/css1/font_properties/font_size-expected.txt:
- platform/efl/css1/font_properties/font_style-expected.txt:
- platform/efl/css1/font_properties/font_variant-expected.txt:
- platform/efl/css1/font_properties/font_weight-expected.txt:
- platform/efl/css1/formatting_model/canvas-expected.txt:
- platform/efl/css1/formatting_model/height_of_lines-expected.txt:
- platform/efl/css1/formatting_model/inline_elements-expected.txt:
- platform/efl/css1/formatting_model/replaced_elements-expected.txt:
- platform/efl/css1/formatting_model/vertical_formatting-expected.txt:
- platform/efl/css1/pseudo/anchor-expected.txt:
- platform/efl/css1/pseudo/firstletter-expected.txt:
- platform/efl/css1/pseudo/firstline-expected.txt:
- platform/efl/css1/pseudo/multiple_pseudo_elements-expected.txt:
- platform/efl/css1/pseudo/pseudo_elements_in_selectors-expected.txt:
- platform/efl/css1/text_properties/letter_spacing-expected.txt:
- platform/efl/css1/text_properties/line_height-expected.txt:
- platform/efl/css1/text_properties/text_align-expected.txt:
- platform/efl/css1/text_properties/text_decoration-expected.txt:
- platform/efl/css1/text_properties/text_indent-expected.txt:
- platform/efl/css1/text_properties/text_transform-expected.txt:
- platform/efl/css1/text_properties/vertical_align-expected.txt:
- platform/efl/css1/text_properties/word_spacing-expected.txt:
- platform/efl/css1/units/color_units-expected.txt:
- platform/efl/css1/units/length_units-expected.txt:
- platform/efl/css1/units/percentage_units-expected.txt:
- platform/efl/css1/units/urls-expected.txt:
- platform/efl/css2.1/20110323/border-collapse-offset-002-expected.txt:
- platform/efl/css2.1/20110323/border-conflict-style-079-expected.txt:
- platform/efl/css2.1/20110323/border-conflict-style-088-expected.txt:
- platform/efl/css2.1/20110323/dynamic-top-change-002-expected.txt:
- platform/efl/css2.1/20110323/dynamic-top-change-003-expected.txt:
- platform/efl/css2.1/20110323/inline-table-001-expected.txt:
- platform/efl/css2.1/20110323/inline-table-002a-expected.txt:
- platform/efl/css2.1/20110323/inline-table-003-expected.txt:
- platform/efl/css2.1/20110323/margin-applies-to-001-expected.txt:
- platform/efl/css2.1/20110323/margin-applies-to-002-expected.txt:
- platform/efl/css2.1/20110323/margin-applies-to-003-expected.txt:
- platform/efl/css2.1/20110323/margin-applies-to-004-expected.txt:
- platform/efl/css2.1/20110323/margin-applies-to-005-expected.txt:
- platform/efl/css2.1/20110323/margin-applies-to-006-expected.txt:
- platform/efl/css2.1/20110323/margin-applies-to-007-expected.txt:
- platform/efl/css2.1/20110323/margin-applies-to-013-expected.txt:
- platform/efl/css2.1/20110323/margin-applies-to-014-expected.txt:
- platform/efl/css2.1/20110323/margin-applies-to-015-expected.txt:
- platform/efl/css2.1/20110323/replaced-intrinsic-ratio-001-expected.txt:
- platform/efl/css2.1/20110323/table-caption-001-expected.txt:
- platform/efl/css2.1/20110323/table-caption-optional-001-expected.txt:
- platform/efl/css2.1/20110323/table-caption-optional-002-expected.txt:
- platform/efl/css2.1/t040302-c61-ex-len-00-b-a-expected.txt:
- platform/efl/css2.1/t0803-c5501-mrgn-t-00-b-a-expected.txt:
- platform/efl/css2.1/t0803-c5503-mrgn-b-00-b-a-expected.txt:
- platform/efl/css2.1/t0804-c5506-padn-t-00-b-a-expected.txt:
- platform/efl/css2.1/t0804-c5508-ipadn-b-03-b-a-expected.txt:
- platform/efl/css2.1/t090402-c42-ibx-pad-00-d-ag-expected.txt:
- platform/efl/css2.1/t0905-c5525-fltmult-00-d-g-expected.txt:
- platform/efl/css2.1/t170602-bdr-conflct-w-04-d-expected.txt:
- platform/efl/css2.1/t170602-bdr-conflct-w-06-d-expected.txt:
- platform/efl/css2.1/t170602-bdr-conflct-w-08-d-expected.txt:
- platform/efl/css2.1/t170602-bdr-conflct-w-13-d-expected.txt:
- platform/efl/css2.1/t170602-bdr-conflct-w-14-d-expected.txt:
- platform/efl/css2.1/t170602-bdr-conflct-w-16-d-expected.txt:
- platform/efl/css2.1/t170602-bdr-conflct-w-17-d-expected.txt:
- platform/efl/css2.1/t170602-bdr-conflct-w-18-d-expected.txt:
- platform/efl/css2.1/t170602-bdr-conflct-w-24-d-expected.txt:
- platform/efl/css2.1/t170602-bdr-conflct-w-25-d-expected.txt:
- platform/efl/css2.1/t170602-bdr-conflct-w-30-d-expected.txt:
- platform/efl/css2.1/t170602-bdr-conflct-w-31-d-expected.txt:
- platform/efl/css2.1/t170602-bdr-conflct-w-34-d-expected.txt:
- platform/efl/css2.1/t170602-bdr-conflct-w-44-d-expected.txt:
- platform/efl/css2.1/t170602-bdr-conflct-w-52-d-expected.txt:
- platform/efl/css2.1/t170602-bdr-conflct-w-54-d-expected.txt:
- platform/efl/css2.1/t170602-bdr-conflct-w-59-d-expected.txt:
- platform/efl/css2.1/t170602-bdr-conflct-w-64-d-expected.txt:
- platform/efl/css2.1/t170602-bdr-conflct-w-65-d-expected.txt:
- platform/efl/css2.1/t170602-bdr-conflct-w-70-d-expected.txt:
- platform/efl/css2.1/t170602-bdr-conflct-w-71-d-expected.txt:
- platform/efl/css2.1/t170602-bdr-conflct-w-74-d-expected.txt:
- platform/efl/css2.1/t170602-bdr-conflct-w-84-d-expected.txt:
- platform/efl/css2.1/t170602-bdr-conflct-w-85-d-expected.txt:
- platform/efl/css2.1/t170602-bdr-conflct-w-94-d-expected.txt:
- platform/efl/css3/selectors3/html/css3-modsel-18-expected.txt:
- platform/efl/css3/selectors3/html/css3-modsel-29-expected.txt:
- platform/efl/css3/selectors3/html/css3-modsel-29b-expected.txt:
- platform/efl/css3/selectors3/html/css3-modsel-33-expected.txt:
- platform/efl/css3/selectors3/html/css3-modsel-73-expected.txt:
- platform/efl/css3/selectors3/html/css3-modsel-73b-expected.txt:
- platform/efl/css3/selectors3/html/css3-modsel-77-expected.txt:
- platform/efl/css3/selectors3/html/css3-modsel-77b-expected.txt:
- platform/efl/css3/selectors3/xhtml/css3-modsel-18-expected.txt:
- platform/efl/css3/selectors3/xhtml/css3-modsel-29-expected.txt:
- platform/efl/css3/selectors3/xhtml/css3-modsel-29b-expected.txt:
- platform/efl/css3/selectors3/xhtml/css3-modsel-33-expected.txt:
- platform/efl/css3/selectors3/xhtml/css3-modsel-73-expected.txt:
- platform/efl/css3/selectors3/xhtml/css3-modsel-73b-expected.txt:
- platform/efl/css3/selectors3/xhtml/css3-modsel-77-expected.txt:
- platform/efl/css3/selectors3/xhtml/css3-modsel-77b-expected.txt:
- platform/efl/css3/selectors3/xml/css3-modsel-18-expected.txt:
- platform/efl/css3/selectors3/xml/css3-modsel-29-expected.txt:
- platform/efl/css3/selectors3/xml/css3-modsel-29b-expected.txt:
- platform/efl/css3/selectors3/xml/css3-modsel-33-expected.txt:
- platform/efl/css3/selectors3/xml/css3-modsel-73-expected.txt:
- platform/efl/css3/selectors3/xml/css3-modsel-73b-expected.txt:
- platform/efl/css3/selectors3/xml/css3-modsel-77-expected.txt:
- platform/efl/css3/selectors3/xml/css3-modsel-77b-expected.txt:
- platform/efl/editing/deleting/4922367-expected.txt:
- platform/efl/editing/deleting/5126166-expected.txt:
- platform/efl/editing/deleting/5206311-1-expected.txt:
- platform/efl/editing/deleting/5433862-2-expected.txt:
- platform/efl/editing/inserting/paragraph-separator-in-table-1-expected.txt:
- platform/efl/editing/selection/3690703-2-expected.txt:
- platform/efl/editing/selection/3690703-expected.txt:
- platform/efl/editing/selection/3690719-expected.txt:
- platform/efl/editing/selection/5057506-2-expected.txt:
- platform/efl/editing/selection/5057506-expected.txt:
- platform/efl/editing/selection/5131716-1-expected.txt:
- platform/efl/editing/selection/5131716-2-expected.txt:
- platform/efl/editing/selection/5131716-3-expected.txt:
- platform/efl/editing/selection/5131716-4-expected.txt:
- platform/efl/editing/selection/move-by-line-001-expected.txt:
- platform/efl/editing/selection/select-all-004-expected.txt:
- platform/efl/editing/unsupported-content/table-type-after-expected.txt:
- platform/efl/editing/unsupported-content/table-type-before-expected.txt:
- platform/efl/fast/block/basic/016-expected.txt:
- platform/efl/fast/block/basic/quirk-percent-height-table-cell-expected.txt:
- platform/efl/fast/block/float/015-expected.txt:
- platform/efl/fast/block/margin-collapse/006-expected.txt:
- platform/efl/fast/block/margin-collapse/010-expected.txt:
- platform/efl/fast/block/margin-collapse/011-expected.txt:
- platform/efl/fast/block/margin-collapse/012-expected.txt:
- platform/efl/fast/block/margin-collapse/015-expected.txt:
- platform/efl/fast/block/margin-collapse/016-expected.txt:
- platform/efl/fast/block/margin-collapse/017-expected.txt:
- platform/efl/fast/block/margin-collapse/018-expected.txt:
- platform/efl/fast/block/margin-collapse/019-expected.txt:
- platform/efl/fast/block/margin-collapse/020-expected.txt:
- platform/efl/fast/block/margin-collapse/021-expected.txt:
- platform/efl/fast/block/margin-collapse/022-expected.txt:
- platform/efl/fast/block/margin-collapse/025-expected.txt:
- platform/efl/fast/block/margin-collapse/032-expected.txt:
- platform/efl/fast/block/margin-collapse/033-expected.txt:
- platform/efl/fast/block/margin-collapse/034-expected.txt:
- platform/efl/fast/block/margin-collapse/041-expected.txt:
- platform/efl/fast/block/margin-collapse/042-expected.txt:
- platform/efl/fast/block/margin-collapse/055-expected.txt:
- platform/efl/fast/block/margin-collapse/056-expected.txt:
- platform/efl/fast/block/margin-collapse/057-expected.txt:
- platform/efl/fast/block/margin-collapse/058-expected.txt:
- platform/efl/fast/block/margin-collapse/059-expected.txt:
- platform/efl/fast/block/margin-collapse/block-inside-inline/006-expected.txt:
- platform/efl/fast/block/margin-collapse/block-inside-inline/010-expected.txt:
- platform/efl/fast/block/margin-collapse/block-inside-inline/011-expected.txt:
- platform/efl/fast/block/margin-collapse/block-inside-inline/012-expected.txt:
- platform/efl/fast/block/margin-collapse/block-inside-inline/015-expected.txt:
- platform/efl/fast/block/margin-collapse/block-inside-inline/016-expected.txt:
- platform/efl/fast/block/margin-collapse/block-inside-inline/017-expected.txt:
- platform/efl/fast/block/margin-collapse/block-inside-inline/018-expected.txt:
- platform/efl/fast/block/margin-collapse/block-inside-inline/019-expected.txt:
- platform/efl/fast/block/margin-collapse/block-inside-inline/020-expected.txt:
- platform/efl/fast/block/margin-collapse/block-inside-inline/021-expected.txt:
- platform/efl/fast/block/margin-collapse/block-inside-inline/022-expected.txt:
- platform/efl/fast/block/margin-collapse/block-inside-inline/025-expected.txt:
- platform/efl/fast/block/positioning/negative-right-pos-expected.txt:
- platform/efl/fast/block/positioning/table-cell-static-position-expected.txt:
- platform/efl/fast/borders/border-antialiasing-expected.txt:
- platform/efl/fast/borders/border-radius-different-width-001-expected.txt:
- platform/efl/fast/borders/table-borders-expected.txt:
- platform/efl/fast/css-generated-content/first-letter-in-nested-before-expected.txt:
- platform/efl/fast/css-generated-content/first-letter-in-nested-before-table-expected.txt:
- platform/efl/fast/css-generated-content/nested-tables-with-before-after-content-crash-expected.txt:
- platform/efl/fast/css-generated-content/table-cell-before-after-child-add-expected.txt:
- platform/efl/fast/css-generated-content/table-parts-before-and-after-expected.txt:
- platform/efl/fast/css-generated-content/table-row-group-with-before-expected.txt:
- platform/efl/fast/css-generated-content/table-row-with-before-expected.txt:
- platform/efl/fast/css-generated-content/table-with-before-expected.txt:
- platform/efl/fast/css/003-expected.txt:
- platform/efl/fast/css/absolute-poition-in-rtl-parent-expected.txt:
- platform/efl/fast/css/acid2-expected.txt:
- platform/efl/fast/css/acid2-pixel-expected.txt:
- platform/efl/fast/css/bidi-override-in-anonymous-block-expected.txt:
- platform/efl/fast/css/box-shadow-and-border-radius-expected.txt:
- platform/efl/fast/css/caption-width-absolute-position-expected.txt:
- platform/efl/fast/css/caption-width-absolute-position-offset-top-expected.txt:
- platform/efl/fast/css/caption-width-fixed-position-expected.txt:
- platform/efl/fast/css/caption-width-fixed-position-offset-top-expected.txt:
- platform/efl/fast/css/caption-width-relative-position-expected.txt:
- platform/efl/fast/css/caption-width-relative-position-offset-top-expected.txt:
- platform/efl/fast/css/css3-nth-child-expected.txt:
- platform/efl/fast/css/focus-ring-detached-expected.txt:
- platform/efl/fast/css/focus-ring-multiline-expected.txt:
- platform/efl/fast/css/h1-in-section-elements-expected.txt:
- platform/efl/fast/css/image-rendering-expected.txt:
- platform/efl/fast/css/min-width-with-spanned-cell-expected.txt:
- platform/efl/fast/css/percentage-non-integer-expected.txt:
- platform/efl/fast/css/table-text-align-quirk-expected.txt:
- platform/efl/fast/css/table-text-align-strict-expected.txt:
- platform/efl/fast/dom/34176-expected.txt:
- platform/efl/fast/dom/HTMLTableElement/colSpan-expected.txt:
- platform/efl/fast/dom/HTMLTableElement/createCaption-expected.txt:
- platform/efl/fast/dom/row-inner-text-expected.txt:
- platform/efl/fast/dynamic/001-expected.txt:
- platform/efl/fast/dynamic/containing-block-change-expected.txt:
- platform/efl/fast/dynamic/float-withdrawal-expected.txt:
- platform/efl/fast/dynamic/insert-before-table-part-in-continuation-expected.txt:
- platform/efl/fast/dynamic/subtree-table-cell-height-expected.txt:
- platform/efl/fast/encoding/utf-16-big-endian-expected.txt:
- platform/efl/fast/encoding/utf-16-little-endian-expected.txt:
- platform/efl/fast/forms/001-expected.txt:
- platform/efl/fast/forms/005-expected.txt:
- platform/efl/fast/forms/basic-buttons-expected.txt:
- platform/efl/fast/forms/form-element-geometry-expected.txt:
- platform/efl/fast/forms/form-hides-table-expected.txt:
- platform/efl/fast/forms/form-in-malformed-markup-expected.txt:
- platform/efl/fast/forms/formmove3-expected.txt:
- platform/efl/fast/forms/input-table-expected.txt:
- platform/efl/fast/forms/listbox-bidi-align-expected.txt:
- platform/efl/fast/forms/preserveFormDuringResidualStyle-expected.txt:
- platform/efl/fast/forms/select-dirty-parent-pref-widths-expected.txt:
- platform/efl/fast/html/details-writing-mode-expected.txt:
- platform/efl/fast/inline-block/001-expected.txt:
- platform/efl/fast/inline-block/overflow-clip-expected.txt:
- platform/efl/fast/invalid/012-expected.txt:
- platform/efl/fast/invalid/018-expected.txt:
- platform/efl/fast/lists/004-expected.txt:
- platform/efl/fast/lists/list-marker-before-content-table-expected.txt:
- platform/efl/fast/multicol/span/before-child-anonymous-column-block-expected.txt:
- platform/efl/fast/overflow/002-expected.txt:
- platform/efl/fast/overflow/overflow-rtl-expected.txt:
- platform/efl/fast/overflow/overflow-rtl-vertical-expected.txt:
- platform/efl/fast/overflow/table-overflow-float-expected.txt:
- platform/efl/fast/reflections/table-cell-expected.txt:
- platform/efl/fast/repaint/block-selection-gap-in-table-cell-expected.txt:
- platform/efl/fast/repaint/float-overflow-expected.txt:
- platform/efl/fast/repaint/float-overflow-right-expected.txt:
- platform/efl/fast/repaint/subtree-root-clip-3-expected.txt:
- platform/efl/fast/repaint/table-cell-collapsed-border-expected.txt:
- platform/efl/fast/repaint/table-cell-collapsed-border-scroll-expected.txt:
- platform/efl/fast/repaint/table-cell-move-expected.txt:
- platform/efl/fast/repaint/table-cell-overflow-expected.txt:
- platform/efl/fast/repaint/table-cell-vertical-overflow-expected.txt:
- platform/efl/fast/repaint/table-col-background-expected.txt:
- platform/efl/fast/repaint/table-collapsed-border-expected.txt:
- platform/efl/fast/repaint/table-extra-bottom-grow-expected.txt:
- platform/efl/fast/repaint/table-outer-border-expected.txt:
- platform/efl/fast/repaint/table-row-expected.txt:
- platform/efl/fast/repaint/table-section-overflow-expected.txt:
- platform/efl/fast/repaint/table-section-repaint-expected.txt:
- platform/efl/fast/repaint/table-two-pass-layout-overpaint-expected.txt:
- platform/efl/fast/repaint/table-writing-modes-h-expected.txt:
- platform/efl/fast/repaint/table-writing-modes-v-expected.txt:
- 5:50 PM Changeset in webkit [195946] by
-
- 9 edits in trunk/Source
Get rid of most calls to String::upper; mostly replace them with convertToASCIIUppercase
https://bugs.webkit.org/show_bug.cgi?id=153715
Reviewed by Gyuyoung Kim.
Source/WebCore:
- editing/cocoa/HTMLConverter.mm:
(HTMLConverter::computedAttributesForElement): Use convertToASCIILowercase to fold
ASCII case when searching for fonts by name.
- platform/network/cf/ResourceResponseCFNet.cpp:
(WebCore::ResourceResponse::platformLazyInit): Use convertToASCIIUppercase to make
the HTTP version string canonical. Not sure why it's needed at all, but the letters
we might be uppercasing are "HTTP", so no need to handle non-ASCII.
- platform/network/cocoa/ResourceResponseCocoa.mm:
(WebCore::ResourceResponse::platformLazyInit): Ditto.
- rendering/svg/SVGRenderTreeAsText.cpp:
(WebCore::operator<<): Use convertToASCIIUppercase when writing the spread
method type into a text stream. The method types are all ASCII.
Source/WebKit2:
- UIProcess/API/efl/tests/test_ewk2_text_checker.cpp:
Use convertToASCIIUppercase on language names.
Source/WTF:
- wtf/text/AtomicString.h:
(WTF::AtomicString::upper): Deleted.
- 5:20 PM Changeset in webkit [195945] by
-
- 2 edits in trunk
[EFL] All API tests are broken on 15.10
https://bugs.webkit.org/show_bug.cgi?id=153528
Reviewed by Gyuyoung Kim.
- CMakeLists.txt: Having include(WebKitCommon) statement follow
CMAKE_FOO_OUTPUT_DIRECTORY otherwise all the API tests gets blocked.
- 4:27 PM Changeset in webkit [195944] by
-
- 5 edits in branches/safari-601-branch/Source
Versioning.
- 4:27 PM Changeset in webkit [195943] by
-
- 5 edits in branches/safari-601.1.46-branch/Source
Versioning.
- 4:26 PM Changeset in webkit [195942] by
-
- 6 edits in trunk/Source
[Cocoa] Remove unused definition of HAVE_HEADER_DETECTION_H
https://bugs.webkit.org/show_bug.cgi?id=153729
Reviewed by Sam Weinig.
After r141700, HAVE_HEADER_DETECTION_H is no longer used.
- Configurations/Base.xcconfig:
- 4:10 PM Changeset in webkit [195941] by
-
- 1 copy in tags/Safari-601.1.46.96
New tag.
- 4:10 PM Changeset in webkit [195940] by
-
- 1 copy in tags/Safari-601.5.14
New tag.
- 4:07 PM Changeset in webkit [195939] by
-
- 2 edits in trunk/Source/JavaScriptCore
B3->Air lowering should use MoveFloat more
https://bugs.webkit.org/show_bug.cgi?id=153714
Reviewed by Sam Weinig.
This is a very minor and benign bug. It just means that we will use the more canonical
MoveFloat instruction when moving floats, rather than using MoveDouble.
- b3/B3LowerToAir.cpp:
(JSC::B3::Air::LowerToAir::relaxedMoveForType):
- 3:05 PM Changeset in webkit [195938] by
-
- 5 edits7 adds in trunk/Source/JavaScriptCore
Should not predict OtherObj for ToThis with primitive types under strict mode
https://bugs.webkit.org/show_bug.cgi?id=153544
Reviewed by Filip Pizlo.
Currently, ToThis predicates OtherObj for primitive values.
But it's not true in strict mode.
In strict mode, ToThis does nothing on primitive values.
In this patch, we
- fix prediction. Handles primitive types in strict mode. And we also handles StringObject.
- convert it to Identity if the argument should be predicted as primitive types.
This optimization is important to implement Primitive.prototype.methods[1].
Otherwise, we always got BadType OSR exits.
[1]: https://bugs.webkit.org/show_bug.cgi?id=143889
- dfg/DFGAbstractInterpreterInlines.h:
(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):
- dfg/DFGConstantFoldingPhase.cpp:
(JSC::DFG::ConstantFoldingPhase::foldConstants):
- dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
(JSC::DFG::FixupPhase::fixupToThis):
- dfg/DFGPredictionPropagationPhase.cpp:
(JSC::DFG::PredictionPropagationPhase::propagate):
- tests/stress/to-this-boolean.js: Added.
(Boolean.prototype.negate):
(Boolean.prototype.negate2):
- tests/stress/to-this-double.js: Added.
(Number.prototype.negate):
- tests/stress/to-this-int32.js: Added.
(Number.prototype.negate):
- tests/stress/to-this-int52.js: Added.
(Number.prototype.negate):
- tests/stress/to-this-number.js: Added.
(Number.prototype.negate):
- tests/stress/to-this-string.js: Added.
(String.prototype.prefix):
(String.prototype.first):
(String.prototype.second):
- tests/stress/to-this-symbol.js: Added.
(Symbol.prototype.identity):
(Symbol.prototype.identity2):
- 3:00 PM Changeset in webkit [195937] by
-
- 20 edits in trunk/Source
[Cocoa] Remove has_include guards around use of WebKitAdditions
https://bugs.webkit.org/show_bug.cgi?id=153728
Reviewed by Andy Estes.
Guard WebKitAdditions includes with #if USE(APPLE_INTERNAL_SDK) rather than with has_include.
Source/WebCore:
- dom/EventNames.h:
- loader/EmptyClients.cpp:
(WebCore::fillWithEmptyClients):
- page/MainFrame.cpp:
(WebCore::MainFrame::MainFrame):
- page/MainFrame.h:
- page/PageConfiguration.h:
- platform/cocoa/WebKitAdditions.mm:
- platform/graphics/ca/cocoa/PlatformCALayerCocoa.mm:
- platform/ios/LegacyTileGridTile.mm:
Source/WebKit/mac:
- WebKitAdditions.mm:
- WebView/WebView.mm:
(-[WebView _commonInitializationWithFrameName:groupName:]):
(-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
Source/WebKit2:
- Shared/Cocoa/WebKitAdditions.mm:
- Shared/WebCoreArgumentCoders.h:
- Shared/mac/RemoteLayerBackingStore.mm:
- UIProcess/API/Cocoa/WKWebView.mm:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::reattachToWebProcess):
(WebKit::WebPageProxy::resetState):
- UIProcess/WebPageProxy.h:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::m_shouldDispatchFakeMouseMoveEvents):
- 2:46 PM Changeset in webkit [195936] by
-
- 5 edits in tags/Safari-602.1.18.1/Source
Versioning.
- 2:42 PM Changeset in webkit [195935] by
-
- 1 copy in tags/Safari-602.1.18.1
New tag.
- 12:59 PM Changeset in webkit [195934] by
-
- 2 edits in trunk/Source/WebKit2
Include the right WebKitAdditions files
<rdar://problem/24429804>
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::resetState):
- 12:49 PM Changeset in webkit [195933] by
-
- 2 edits in branches/safari-601.1.46-branch/Source/WebCore
Merged r195932. rdar://problem/24430138
- 12:39 PM Changeset in webkit [195932] by
-
- 2 edits in branches/safari-601-branch/Source/WebCore
Merge patch for rdar://problem/24426332 and rdar://problem/24209109.
- 12:27 PM Changeset in webkit [195931] by
-
- 4 edits in branches/safari-601-branch/Source/WebCore
Roll out r195817.
- 11:51 AM Changeset in webkit [195930] by
-
- 5 edits in branches/safari-601.1.46-branch/Source
Versioning.
- 11:51 AM Changeset in webkit [195929] by
-
- 5 edits in branches/safari-601-branch/Source
Versioning.
- 11:22 AM Changeset in webkit [195928] by
-
- 37 edits in trunk
Replace CaseFoldingHash with ASCIICaseInsensitiveHash
https://bugs.webkit.org/show_bug.cgi?id=153639
Reviewed by Filip Pizlo.
Source/WebCore:
- Modules/webdatabase/DatabaseAuthorizer.h: Use ASCIICaseInsensitiveHash
for whitelisted functions. Function names are all ASCII.
- accessibility/AccessibilityObject.cpp: Use ASCIICaseInsensitiveHash
for ARIA roles. ARIA roles are all ASCII.
- crypto/CryptoAlgorithmRegistry.h: Use ASCIICaseInsensitiveHash for
crypto algorithm names. Algorithm names are all ASCII.
- css/CSSFontSelector.cpp:
(WebCore::registerLocalFontFacesForFamily): Use ASCIICaseInsensitiveHash
for font faces. Face names should use ASCII case insensitive matching;
there is no need for non-ASCII case folding.
- css/CSSFontSelector.h: Ditto.
- dom/DOMImplementation.cpp: Use ASCIICaseInsensitiveHash for the
FeatureSet. The features are all ASCII.
- dom/Document.h: Use ASCIICaseInsensitiveHash for the access key
map. Access keys are all ASCII.
- dom/ScriptElement.cpp:
(WebCore::isLegacySupportedJavaScriptLanguage): Use ASCIICaseInsensitiveHash
for the language set. These strings are all ASCII.
- editing/EditorCommand.cpp: Use ASCIICaseInsensitiveHash for editor
command names. These names are all ASCII.
- html/HTMLObjectElement.cpp:
(WebCore::HTMLObjectElement::parametersForPlugin): Use ASCIICaseInsensitiveHash
for parameter names. These names are all ASCII.
- html/InputType.cpp: Use ASCIICaseInsensitiveHash for the input types.
The input types are all ASCII.
- loader/CrossOriginAccessControl.h: Use ASCIICaseInsensitiveHash for
HTTP header field names. These names are all ASCII.
- loader/CrossOriginPreflightResultCache.h: Ditto.
- loader/archive/ArchiveFactory.cpp: Use ASCIICaseInsensitiveHash for
MIME types. MIME types are all ASCII.
- platform/MIMETypeRegistry.cpp:
(WebCore::initializeSupportedImageMIMETypes): Ditto.
- platform/SchemeRegistry.h: Use ASCIICaseInsensitiveHas for URL schemes.
URL schemes are all ASCII.
- platform/URL.cpp: Ditto.
- platform/graphics/FontCache.cpp:
(WebCore::FontPlatformDataCacheKey::operator==): Use ASCIICaseInsensitiveHash.
(WebCore::FontPlatformDataCacheKeyHash::hash): Use ASCIICaseInsensitiveHash.
- platform/graphics/FontCascade.cpp:
(WebCore::keysMatch): Rename from operator== since this operation is not
equality. Changed to equalIgnoringASCIICase and did a little streamlining.
(WebCore::makeFontCascadeCacheKey): Use reserveInitialCapacity for slightly
better memory use.
(WebCore::computeFontCascadeCacheHash): Use IntegerHasher to make computing
a hash more efficient by eliminating the overhead of building a vector and
even possible heap allocation and deallocation.
(WebCore::retrieveOrAddCachedFonts): Use keysMatch instead of ==.
- platform/graphics/cocoa/FontCacheCoreText.cpp: Use ASCIICaseInsensitiveHash
for font family names. These names should use ASCII case insensitive matching;
there is no need for non-ASCII case folding.
- platform/network/HTTPHeaderMap.h: Use ASCIICaseInsensitiveHash for
HTTP header field names. These names are all ASCII.
- rendering/style/RenderStyle.cpp:
(WebCore::computeFontHash): Use IntegerHasher to avoid allocating memory just
to compute a hash. Use ASCIICaseInsensitiveHash.
Source/WebKit/win:
- WebCoreStatistics.cpp:
(WebCoreStatistics::memoryStatistics): Use ASCIICaseInsensitiveHash for field names.
These names are all ASCII.
- WebURLResponse.cpp:
(WebURLResponse::allHeaderFields): Use ASCIICaseInsensitiveHash for HTTP header
field names. These names are all ASCII.
Source/WebKit2:
- UIProcess/Cocoa/WKWebViewContentProviderRegistry.mm: Use ASCIICaseInsensitiveHash
for MIME types. MIME types are all ASCII.
- UIProcess/Plugins/PlugInAutoStartProvider.h: Use ASCIICaseInsensitiveHash for
origins. Origin strings should use ASCII case insensitive matching and should not
fold non-ASCII case.
- WebProcess/WebPage/WebPage.h: Use ASCIICaseInsensitiveHash for MIME types.
MIME types are all ASCII.
- WebProcess/WebProcess.cpp:
(WebKit::addCaseFoldedCharacters): Use ASCIICaseInsensitiveHash to hash plug-in
origin strings. (See rationale above.)
(WebKit::hashForPlugInOrigin): Updated comment.
Source/WTF:
- wtf/text/StringHash.h: Renamed CaseFoldingHash to ASCIICaseInsensitiveHash.
(WTF::ASCIICaseInsensitiveHash::foldCase): Use toASCIILower.
(WTF::ASCIICaseInsensitiveHash::equal): Use equalIgnoringASCIICase.
Also added some assertions.
- wtf/text/StringImpl.cpp: Made the latin1CaseFoldTable private to this file,
since it's no longer needed by CaseFoldingHash. Moved it up before its first use.
(WTF::equalCompatibilityCaseless): Fixed typo in the name of this function.
(WTF::equalCompatibiltyCaselessNonNull): Deleted.
- wtf/text/StringImpl.h: Removed declarations of latin1CaseFoldTable and
equalCompatibiltyCaselessNonNull
Tools:
- Scripts/do-webcore-rename: Use script to do this rename.
- 4:08 AM Changeset in webkit [195927] by
-
- 27 edits in trunk/Source
Reduce PassRefPtr uses in dom - 5
https://bugs.webkit.org/show_bug.cgi?id=153470
Reviewed by Darin Adler.
As a step to remove PassRefPtr, this patch reduces uses of PassRefPtr in WebCore/dom.
- dom/Document.cpp:
(WebCore::Document::adoptNode):
(WebCore::Document::implicitClose):
(WebCore::Document::enqueuePopstateEvent):
(WebCore::Document::setInputCursor):
- dom/Document.h:
- dom/DocumentMarker.cpp:
(WebCore::DocumentMarkerTextMatch::instanceFor):
- dom/Event.cpp:
(WebCore::Event::setUnderlyingEvent):
- dom/Event.h:
- dom/EventDispatcher.h:
- dom/GenericEventQueue.cpp:
(WebCore::GenericEventQueue::enqueueEvent):
- dom/GenericEventQueue.h:
- dom/MouseEvent.cpp:
(WebCore::SimulatedMouseEvent::SimulatedMouseEvent):
- dom/Node.cpp:
(WebCore::Node::dispatchDOMActivateEvent):
- dom/NodeIterator.h:
- dom/PendingScript.h:
- dom/PopStateEvent.cpp:
(WebCore::PopStateEvent::create):
- dom/PopStateEvent.h:
- dom/ProcessingInstruction.cpp:
(WebCore::ProcessingInstruction::setCSSStyleSheet): Deleted. Nobody calls this function.
- dom/ProcessingInstruction.h:
- dom/RangeBoundaryPoint.h:
(WebCore::RangeBoundaryPoint::RangeBoundaryPoint):
- dom/TextEvent.cpp:
(WebCore::TextEvent::createForFragmentPaste):
(WebCore::TextEvent::TextEvent):
- dom/TextEvent.h:
- editing/Editor.cpp:
(WebCore::Editor::pasteAsFragment):
- editing/Editor.h:
- editing/mac/EditorMac.mm:
(WebCore::Editor::replaceNodeFromPasteboard):
- 3:41 AM Changeset in webkit [195926] by
-
- 3 edits in trunk/Source/JavaScriptCore
[mips] don't save to a callee saved register too early
https://bugs.webkit.org/show_bug.cgi?id=153463
If we save $gp to $s4 in pichdr, then in some cases, we were
overwriting $s4 before LLInt's pushCalleeSaves() is called (as pichdr
is at the very beginning of a function). Now we save $gp to $s4 at the
end of pushCalleeSaves().
Patch by Guillaume Emont <guijemont@igalia.com> on 2016-01-31
Reviewed by Michael Saboff.
- offlineasm/mips.rb:
- llint/LowLevelInterpreter.asm:
Move the saving of $gp to $s4 from pichdr to pushCalleeSaves(). Take
the opportunity to only save $s4 as we never use the other callee
saved registers.
- 3:41 AM Changeset in webkit [195925] by
-
- 14 edits in trunk/Source
Use std::make_unique<> when creating an unique_ptr object.
https://bugs.webkit.org/show_bug.cgi?id=153705
Reviewed by Darin Adler.
Source/WebCore:
Some factory functions have used std::unique_ptr<> for creating an unique_ptr object.
It is wrong. We have to use std::make_unique<>.
- Modules/mediasession/WebMediaSessionManager.cpp:
(WebCore::WebMediaSessionManager::mockPicker):
- inspector/InspectorTimelineAgent.cpp:
(WebCore::InspectorTimelineAgent::internalStart):
- platform/cf/RunLoopObserver.cpp:
(WebCore::RunLoopObserver::create): Deleted.
- platform/cf/RunLoopObserver.h:
(WebCore::RunLoopObserver::RunLoopObserver):
- platform/graphics/avfoundation/WebMediaSessionManagerMac.cpp:
(WebCore::WebMediaSessionManagerMac::platformPicker):
- platform/graphics/avfoundation/objc/MediaPlaybackTargetPickerMac.h:
- platform/graphics/avfoundation/objc/MediaPlaybackTargetPickerMac.mm:
(WebCore::MediaPlaybackTargetPickerMac::create): Deleted.
- platform/graphics/ca/cocoa/LayerFlushSchedulerMac.cpp:
(WebCore::LayerFlushScheduler::LayerFlushScheduler):
- platform/mock/MediaPlaybackTargetPickerMock.cpp:
(WebCore::MediaPlaybackTargetPickerMock::create): Deleted.
- platform/mock/MediaPlaybackTargetPickerMock.h:
- rendering/FloatingObjects.cpp:
(WebCore::FloatingObject::copyToNewContainer):
Source/WebKit2:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::WebPageProxy): Use std::make_unique<> instead of RunLoopObserver::create().
- 1:20 AM Changeset in webkit [195924] by
-
- 3 edits in trunk/LayoutTests/imported/w3c
imported/w3c/web-platform-tests/streams-api/readable-streams/garbage-collection.html asserts frequently
https://bugs.webkit.org/show_bug.cgi?id=152436
Reviewed by Darin Adler.
GCController is not available in Worker environments, explaining probably why garbage-collection-2.html is not crashing at all.
Inlining half of the tests in garbage-collection-2.html (runned in window) to compare with garbage-collection-1.html.
- web-platform-tests/streams-api/readable-streams/garbage-collection-2-expected.txt:
- web-platform-tests/streams-api/readable-streams/garbage-collection-2.html:
Jan 30, 2016:
- 9:57 PM Changeset in webkit [195923] by
-
- 2 edits in trunk/Source/WebInspectorUI
Add the break-* properties to Web Inspector's completion set
https://bugs.webkit.org/show_bug.cgi?id=153706
Reviewed by Darin Adler.
- UserInterface/Models/CSSKeywordCompletions.js:
- 8:11 PM Changeset in webkit [195922] by
-
- 25 edits in trunk/Source/WebKit2
[Cocoa] Get rid of many WK_ macros for nullability
https://bugs.webkit.org/show_bug.cgi?id=153718
Sam Weinig reviewed an earlier version of this change, and Simon Fraser rubber-stamped this version.
- Shared/API/Cocoa/WKFoundation.h: Removed definitions of WK_ASSUME_NONNULL_{BEGIN, END}, WK_NULLABLE, WK_NULL_UNSPECIFIED, and WK_NULLABLE_PROPERTY. Removed the __has_feature(assume_nonnull) case.
- mac/postprocess-framework-headers.sh: Removed rules for rewriting the above macros. Also chanegd to rewrite WK_NULLABLE_SPECIFIER to the modern _Nullable instead of nullable.
Replaced instances of the above macros with their expansions.
- UIProcess/API/Cocoa/WKBackForwardList.h:
- UIProcess/API/Cocoa/WKBackForwardListItem.h:
- UIProcess/API/Cocoa/WKError.h:
- UIProcess/API/Cocoa/WKFrameInfo.h:
- UIProcess/API/Cocoa/WKNavigationAction.h:
- UIProcess/API/Cocoa/WKNavigationDelegate.h:
- UIProcess/API/Cocoa/WKNavigationResponse.h:
- UIProcess/API/Cocoa/WKScriptMessage.h:
- UIProcess/API/Cocoa/WKScriptMessageHandler.h:
- UIProcess/API/Cocoa/WKSecurityOrigin.h:
- UIProcess/API/Cocoa/WKUIDelegate.h:
- UIProcess/API/Cocoa/WKUserContentController.h:
- UIProcess/API/Cocoa/WKUserScript.h:
- UIProcess/API/Cocoa/WKWebView.h:
- UIProcess/API/Cocoa/WKWebViewConfiguration.h:
- UIProcess/API/Cocoa/WKWebsiteDataRecord.h:
- UIProcess/API/Cocoa/WKWebsiteDataStore.h:
- UIProcess/API/Cocoa/WKWindowFeatures.h:
- UIProcess/API/Cocoa/_WKContextMenuElementInfo.h:
- UIProcess/API/Cocoa/_WKElementInfo.h:
- UIProcess/API/Cocoa/_WKPreviewElementInfo.h:
- UIProcess/API/Cocoa/_WKUserStyleSheet.h:
- 7:59 PM Changeset in webkit [195921] by
-
- 2 edits in trunk/Websites/webkit.org
B3 documentation style shouldn't have hacks for h1
https://bugs.webkit.org/show_bug.cgi?id=153725
Reviewed by Alexey Proskuryakov.
- docs/b3/style.css:
- 5:22 PM Changeset in webkit [195920] by
-
- 25 edits in trunk/Source/WebKit2
Reverted r195914, because at least one of the build.webkit.org builders still uses a compiler that doesn’t understand _Nullable.
- Shared/API/Cocoa/WKFoundation.h:
- UIProcess/API/Cocoa/WKBackForwardList.h:
- UIProcess/API/Cocoa/WKBackForwardListItem.h:
- UIProcess/API/Cocoa/WKError.h:
- UIProcess/API/Cocoa/WKFrameInfo.h:
- UIProcess/API/Cocoa/WKNavigationAction.h:
- UIProcess/API/Cocoa/WKNavigationDelegate.h:
- UIProcess/API/Cocoa/WKNavigationResponse.h:
- UIProcess/API/Cocoa/WKScriptMessage.h:
- UIProcess/API/Cocoa/WKScriptMessageHandler.h:
- UIProcess/API/Cocoa/WKSecurityOrigin.h:
- UIProcess/API/Cocoa/WKUIDelegate.h:
- UIProcess/API/Cocoa/WKUserContentController.h:
- UIProcess/API/Cocoa/WKUserScript.h:
- UIProcess/API/Cocoa/WKWebView.h:
- UIProcess/API/Cocoa/WKWebViewConfiguration.h:
- UIProcess/API/Cocoa/WKWebsiteDataRecord.h:
- UIProcess/API/Cocoa/WKWebsiteDataStore.h:
- UIProcess/API/Cocoa/WKWindowFeatures.h:
- UIProcess/API/Cocoa/_WKContextMenuElementInfo.h:
- UIProcess/API/Cocoa/_WKElementInfo.h:
- UIProcess/API/Cocoa/_WKPreviewElementInfo.h:
- UIProcess/API/Cocoa/_WKUserStyleSheet.h:
- mac/postprocess-framework-headers.sh:
- 5:19 PM Changeset in webkit [195919] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed, fix GTK debug build after r195899
- dom/EventContext.h:
(isType):
- 5:15 PM Changeset in webkit [195918] by
-
- 2 edits in trunk/Source/WebCore
Add missing include to fix building debug configuration
https://bugs.webkit.org/show_bug.cgi?id=153719
Patch by Jeremy Huddleston Sequoia <jeremyhu@apple.com> on 2016-01-30
Reviewed by Darin Adler.
No new tests.
- rendering/RenderObject.cpp:
- 4:53 PM Changeset in webkit [195917] by
-
- 37 edits in trunk
Unreviewed, rolling out r195911.
https://bugs.webkit.org/show_bug.cgi?id=153723
Caused frequent assertion failures on bots (Requested by ap on
#webkit).
Reverted changeset:
"Replace CaseFoldingHash with ASCIICaseInsensitiveHash"
https://bugs.webkit.org/show_bug.cgi?id=153639
http://trac.webkit.org/changeset/195911
- 4:41 PM Changeset in webkit [195916] by
-
- 64 edits in trunk
Unreviewed, rolling out r195799 and r195828.
https://bugs.webkit.org/show_bug.cgi?id=153722
Caused assertion failures, severely affecting EWS (Requested
by ap on #webkit).
Reverted changesets:
"Web Inspector: InspectorTimelineAgent doesn't need to
recompile functions because it now uses the sampling profiler"
https://bugs.webkit.org/show_bug.cgi?id=153500
http://trac.webkit.org/changeset/195799
"Attempt to fix the Windows build after r195799"
http://trac.webkit.org/changeset/195828
- 4:24 PM Changeset in webkit [195915] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Network panel is empty until the window is resized
https://bugs.webkit.org/show_bug.cgi?id=153701
<rdar://problem/24423739>
Reviewed by Timothy Hatcher.
NetworkGridContentView shouldn't prevent a layout from being scheduled
when the network sidebar is collapsed.
- UserInterface/Views/NetworkGridContentView.js:
(WebInspector.NetworkGridContentView.prototype.needsLayout): Deleted.
Removed View.prototype.needsLayout override that was preventing
layouts from being scheduled as timeline records are added.
- 3:50 PM Changeset in webkit [195914] by
-
- 25 edits in trunk/Source/WebKit2
[Cocoa] Get rid of WK_ macros for nullability
https://bugs.webkit.org/show_bug.cgi?id=153718
Reviewed by Sam Weinig.
- Shared/API/Cocoa/WKFoundation.h: Removed definitions of WK_ASSUME_NONNULL_{BEGIN, END}, WK_NULLABLE, WK_NULL_UNSPECIFIED, WK_NULLABLE_SPECIFIER, and WK_NULLABLE_PROPERTY.
- mac/postprocess-framework-headers.sh: Removed rules for rewriting those macros.
Replaced instances of those macros with their expansions, but using the modern _Nullable
instead of nullable:
- UIProcess/API/Cocoa/WKBackForwardList.h:
- UIProcess/API/Cocoa/WKBackForwardListItem.h:
- UIProcess/API/Cocoa/WKError.h:
- UIProcess/API/Cocoa/WKFrameInfo.h:
- UIProcess/API/Cocoa/WKNavigationAction.h:
- UIProcess/API/Cocoa/WKNavigationDelegate.h:
- UIProcess/API/Cocoa/WKNavigationResponse.h:
- UIProcess/API/Cocoa/WKScriptMessage.h:
- UIProcess/API/Cocoa/WKScriptMessageHandler.h:
- UIProcess/API/Cocoa/WKSecurityOrigin.h:
- UIProcess/API/Cocoa/WKUIDelegate.h:
- UIProcess/API/Cocoa/WKUserContentController.h:
- UIProcess/API/Cocoa/WKUserScript.h:
- UIProcess/API/Cocoa/WKWebView.h:
- UIProcess/API/Cocoa/WKWebViewConfiguration.h:
- UIProcess/API/Cocoa/WKWebsiteDataRecord.h:
- UIProcess/API/Cocoa/WKWebsiteDataStore.h:
- UIProcess/API/Cocoa/WKWindowFeatures.h:
- UIProcess/API/Cocoa/_WKContextMenuElementInfo.h:
- UIProcess/API/Cocoa/_WKElementInfo.h:
- UIProcess/API/Cocoa/_WKPreviewElementInfo.h:
- UIProcess/API/Cocoa/_WKUserStyleSheet.h:
- 2:25 PM Changeset in webkit [195913] by
-
- 4 edits in trunk
Modern IDB: Some tests crash with specific odd database names.
https://bugs.webkit.org/show_bug.cgi?id=153688
Reviewed by Darin Adler.
Source/WebCore:
No new tests (2 existing tests now pass).
- platform/FileSystem.cpp:
(WebCore::shouldEscapeUChar): Return true for some surrogate-pair situations.
(WebCore::encodeForFileName): Pass along the previous and next characters, as well,
and do a two byte escaping for some characters.
LayoutTests:
- platform/mac-wk1/TestExpectations:
- 2:19 PM Changeset in webkit [195912] by
-
- 5 edits2 adds in trunk
More than one audio and/or text track sometimes selected in media controls menu
https://bugs.webkit.org/show_bug.cgi?id=153664
Source/WebCore:
Use an <img> element for the track menu item checkmark instead of a background image and
the ::before selector.
Reviewed by Jer Noble.
Test: media/controls/track-menu.html
- Modules/mediacontrols/mediaControlsApple.css:
(audio::-webkit-media-controls-closed-captions-container li:hover):
(audio::-webkit-media-controls-closed-captions-container li .checkmark-container):
(audio::-webkit-media-controls-closed-captions-container li.selected .checkmark-container):
(audio::-webkit-media-controls-closed-captions-container li.selected:hover .checkmark-container):
(audio::-webkit-media-controls-closed-captions-container li.selected::before): Deleted.
(audio::-webkit-media-controls-closed-captions-container li.selected:hover::before): Deleted.
- Modules/mediacontrols/mediaControlsApple.js:
(Controller.prototype.buildCaptionMenu):
(Controller.prototype.):
(Controller.prototype.getCurrentControlsStatus):
LayoutTests:
Reviewed by Jer Noble.
- media/controls/controls-test-helpers.js:
(ControlsTest.prototype.get currentState):
(ControlsTest.prototype.get video):
(ControlsTest.prototype.stateForControlsElement):
(ControlsTest.prototype.handleEvent):
(ControlsTest.prototype.setup):
(ControlsTest.prototype.start):
(ControlsTest.prototype.isEqualTo):
(ControlsTest.prototype.isNotEqualTo):
(ControlsTest.prototype.contains):
- media/controls/track-menu-expected.txt: Added.
- media/controls/track-menu.html: Added.
- 1:53 PM Changeset in webkit [195911] by
-
- 37 edits in trunk
Replace CaseFoldingHash with ASCIICaseInsensitiveHash
https://bugs.webkit.org/show_bug.cgi?id=153639
Reviewed by Filip Pizlo.
Source/WebCore:
- Modules/webdatabase/DatabaseAuthorizer.h: Use ASCIICaseInsensitiveHash
for whitelisted functions. Function names are all ASCII.
- accessibility/AccessibilityObject.cpp: Use ASCIICaseInsensitiveHash
for ARIA roles. ARIA roles are all ASCII.
- crypto/CryptoAlgorithmRegistry.h: Use ASCIICaseInsensitiveHash for
crypto algorithm names. Algorithm names are all ASCII.
- css/CSSFontSelector.cpp:
(WebCore::registerLocalFontFacesForFamily): Use ASCIICaseInsensitiveHash
for font faces. Face names should use ASCII case insensitive matching;
there is no need for non-ASCII case folding.
- css/CSSFontSelector.h: Ditto.
- dom/DOMImplementation.cpp: Use ASCIICaseInsensitiveHash for the
FeatureSet. The features are all ASCII.
- dom/Document.h: Use ASCIICaseInsensitiveHash for the access key
map. Access keys are all ASCII.
- dom/ScriptElement.cpp:
(WebCore::isLegacySupportedJavaScriptLanguage): Use ASCIICaseInsensitiveHash
for the language set. These strings are all ASCII.
- editing/EditorCommand.cpp: Use ASCIICaseInsensitiveHash for editor
command names. These names are all ASCII.
- html/HTMLObjectElement.cpp:
(WebCore::HTMLObjectElement::parametersForPlugin): Use ASCIICaseInsensitiveHash
for parameter names. These names are all ASCII.
- html/InputType.cpp: Use ASCIICaseInsensitiveHash for the input types.
The input types are all ASCII.
- loader/CrossOriginAccessControl.h: Use ASCIICaseInsensitiveHash for
HTTP header field names. These names are all ASCII.
- loader/CrossOriginPreflightResultCache.h: Ditto.
- loader/archive/ArchiveFactory.cpp: Use ASCIICaseInsensitiveHash for
MIME types. MIME types are all ASCII.
- platform/MIMETypeRegistry.cpp:
(WebCore::initializeSupportedImageMIMETypes): Ditto.
- platform/SchemeRegistry.h: Use ASCIICaseInsensitiveHas for URL schemes.
URL schemes are all ASCII.
- platform/URL.cpp: Ditto.
- platform/graphics/FontCache.cpp: Reworked FontPlatformDataCacheKey struct:
Made it a conventional struct with non-prefixed data members names. Removed
the "==" operator since it was appropriate for hash table lookup but wasn't
a true equality operator. Tightened the implementations of the constructors.
(WebCore::FontPlatformDataCacheKeyHash::hash): Use ASCIICaseInsensitiveHash.
(WebCore::FontPlatformDataCacheKeyHash::equal): Do the equality check here,
not using the == operator. And use equalIgnoringASCIICase.
(WebCore::FontPlatformDataCacheKeyTraits::isEmptyValue): Added this entire
traits struct so we check empty values in a more efficient way.
(WebCore::FontCache::getCachedFontPlatformData): Added comments and tweaked
style in this function.
- platform/graphics/FontCascade.cpp:
(WebCore::keysMatch): Rename from operator== since this operation is not
equality. Changed to equalIgnoringASCIICase and did a little streamlining.
(WebCore::makeFontCascadeCacheKey): Use reserveInitialCapacity for slightly
better memory use.
(WebCore::computeFontCascadeCacheHash): Use IntegerHasher to make computing
a hash more efficient by eliminating the overhead of building a vector and
even possible heap allocation and deallocation.
(WebCore::retrieveOrAddCachedFonts): Use keysMatch instead of ==.
- platform/graphics/cocoa/FontCacheCoreText.cpp: Use ASCIICaseInsensitiveHash
for font family names. These names should use ASCII case insensitive matching;
there is no need for non-ASCII case folding.
- platform/network/HTTPHeaderMap.h: Use ASCIICaseInsensitiveHash for
HTTP header field names. These names are all ASCII.
- rendering/style/RenderStyle.cpp:
(WebCore::computeFontHash): Use IntegerHasher to avoid allocating memory just
to compute a hash. Use ASCIICaseInsensitiveHash.
Source/WebKit/win:
- WebCoreStatistics.cpp:
(WebCoreStatistics::memoryStatistics): Use ASCIICaseInsensitiveHash for field names.
These names are all ASCII.
- WebURLResponse.cpp:
(WebURLResponse::allHeaderFields): Use ASCIICaseInsensitiveHash for HTTP header
field names. These names are all ASCII.
Source/WebKit2:
- UIProcess/Cocoa/WKWebViewContentProviderRegistry.mm: Use ASCIICaseInsensitiveHash
for MIME types. MIME types are all ASCII.
- UIProcess/Plugins/PlugInAutoStartProvider.h: Use ASCIICaseInsensitiveHash for
origins. Origin strings should use ASCII case insensitive matching and should not
fold non-ASCII case.
- WebProcess/WebPage/WebPage.h: Use ASCIICaseInsensitiveHash for MIME types.
MIME types are all ASCII.
- WebProcess/WebProcess.cpp:
(WebKit::addCaseFoldedCharacters): Use ASCIICaseInsensitiveHash to hash plug-in
origin strings. (See rationale above.)
(WebKit::hashForPlugInOrigin): Updated comment.
Source/WTF:
- wtf/text/StringHash.h: Renamed CaseFoldingHash to ASCIICaseInsensitiveHash.
(WTF::ASCIICaseInsensitiveHash::foldCase): Use toASCIILower.
(WTF::ASCIICaseInsensitiveHash::equal): Use equalIgnoringASCIICase.
Also added some assertions.
- wtf/text/StringImpl.cpp: Made the latin1CaseFoldTable private to this file,
since it's no longer needed by CaseFoldingHash. Moved it up before its first use.
(WTF::equalCompatibilityCaseless): Fixed typo in the name of this function.
(WTF::equalCompatibiltyCaselessNonNull): Deleted.
- wtf/text/StringImpl.h: Removed declarations of latin1CaseFoldTable and
equalCompatibiltyCaselessNonNull
Tools:
- Scripts/do-webcore-rename: Use script to do this rename.
- 1:49 PM Changeset in webkit [195910] by
-
- 3 edits in trunk/Source/WebInspectorUI
Web Inspector: Object tree parent items are misaligned
https://bugs.webkit.org/show_bug.cgi?id=153699
<rdar://problem/24423683>
Patch by Devin Rousso <Devin Rousso> on 2016-01-30
Reviewed by Darin Adler.
- UserInterface/Views/ObjectTreeView.css:
(.object-tree .object-tree):
Ensure that toplevel Object preview trees are displayed properly while also
making child trees inline.
- UserInterface/Views/TreeOutline.css:
(.tree-outline:not(.hide-disclosure-buttons) .item:not(.parent) > .icon):
(.tree-outline:not(.hide-disclosure-buttons) .item:not(.parent) .icon): Deleted.
This would apply to all .icon elements contained within a non-parent item,
which is not the desired effect. Instead, this should only apply to only the
.icon element of that particular non-parent item.
- 1:39 PM Changeset in webkit [195909] by
-
- 3 edits in trunk/Source/WebCore
Unreviewed, rolling out r195871.
Caused several layout tests to time out
Reverted changeset:
"Tab suspension code shouldn't use page cache cacheability
logic"
https://bugs.webkit.org/show_bug.cgi?id=153680
http://trac.webkit.org/changeset/195871
- 1:34 PM Changeset in webkit [195908] by
-
- 4 edits in trunk/Source/WebCore
Unreviewed, rebaseline bindings tests after r195904.
- bindings/scripts/test/JS/JSTestCustomNamedGetter.cpp:
(WebCore::JSTestCustomNamedGetter::getOwnPropertySlot):
(WebCore::jsTestCustomNamedGetterConstructor):
(WebCore::setJSTestCustomNamedGetterConstructor):
- bindings/scripts/test/JS/JSTestEventTarget.cpp:
(WebCore::JSTestEventTarget::getOwnPropertySlot):
(WebCore::jsTestEventTargetConstructor):
(WebCore::setJSTestEventTargetConstructor):
- bindings/scripts/test/JS/JSTestOverrideBuiltins.cpp:
(WebCore::JSTestOverrideBuiltins::getOwnPropertySlot):
(WebCore::jsTestOverrideBuiltinsConstructor):
(WebCore::setJSTestOverrideBuiltinsConstructor):
- 1:01 PM Changeset in webkit [195907] by
-
- 32 edits4 adds in trunk
[JS Bindings] prototype.constructor should be writable
https://bugs.webkit.org/show_bug.cgi?id=149412
<rdar://problem/22545096>
Reviewed by Darin Adler.
LayoutTests/imported/w3c:
Rebaseline W3C tests now that more checks are passing.
- web-platform-tests/XMLHttpRequest/interfaces-expected.txt:
- web-platform-tests/dom/interfaces-expected.txt:
- web-platform-tests/fetch/api/headers/headers-idl-expected.txt:
- web-platform-tests/html/dom/interfaces-expected.txt:
Source/WebCore:
prototype.constructor should have the following properties:
{ Writable: true, Enumerable: false, Configurable: true }
as per the Web IDL specification:
https://heycam.github.io/webidl/#interface-prototype-object
In WebKit, it is currently not writable. It is writable in Firefox.
This patch was first landed in r190085 but was rolled out for causing
crashes: <rdar://problem/22825602>. The issue was that even though we
marked constructor as writable, we failed to generate a setter for it.
This patch addresses the issue and the crash in <rdar://problem/22825602>
no longer occurs after this change. A regression test is also added for
this crash.
Tests:
fast/dom/HTMLDocument/constructor-setter-crash.html
fast/dom/prototype-constructor-setter.html
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateAttributesHashTable):
(GenerateImplementation):
- bindings/scripts/IDLAttributes.txt:
- bindings/scripts/test/JS/JSTestActiveDOMObject.cpp:
(WebCore::setJSTestActiveDOMObjectConstructor):
- bindings/scripts/test/JS/JSTestClassWithJSBuiltinConstructor.cpp:
(WebCore::setJSTestClassWithJSBuiltinConstructorConstructor):
- bindings/scripts/test/JS/JSTestCustomConstructorWithNoInterfaceObject.cpp:
(WebCore::setJSTestCustomConstructorWithNoInterfaceObjectConstructor):
- bindings/scripts/test/JS/JSTestCustomNamedGetter.cpp:
(WebCore::setJSTestCustomNamedGetterConstructor):
- bindings/scripts/test/JS/JSTestEventConstructor.cpp:
(WebCore::setJSTestEventConstructorConstructor):
- bindings/scripts/test/JS/JSTestEventTarget.cpp:
(WebCore::setJSTestEventTargetConstructor):
- bindings/scripts/test/JS/JSTestException.cpp:
(WebCore::setJSTestExceptionConstructor):
- bindings/scripts/test/JS/JSTestGenerateIsReachable.cpp:
(WebCore::setJSTestGenerateIsReachableConstructor):
- bindings/scripts/test/JS/JSTestInterface.cpp:
(WebCore::setJSTestInterfaceConstructor):
- bindings/scripts/test/JS/JSTestJSBuiltinConstructor.cpp:
(WebCore::setJSTestJSBuiltinConstructorConstructor):
- bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:
(WebCore::setJSTestMediaQueryListListenerConstructor):
- bindings/scripts/test/JS/JSTestNamedConstructor.cpp:
(WebCore::setJSTestNamedConstructorConstructor):
- bindings/scripts/test/JS/JSTestNode.cpp:
(WebCore::setJSTestNodeConstructor):
- bindings/scripts/test/JS/JSTestNondeterministic.cpp:
(WebCore::setJSTestNondeterministicConstructor):
- bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::setJSTestObjConstructor):
- bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp:
(WebCore::setJSTestOverloadedConstructorsConstructor):
- bindings/scripts/test/JS/JSTestOverrideBuiltins.cpp:
(WebCore::setJSTestOverrideBuiltinsConstructor):
- bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:
(WebCore::setJSTestSerializedScriptValueInterfaceConstructor):
- bindings/scripts/test/JS/JSTestTypedefs.cpp:
(WebCore::setJSTestTypedefsConstructor):
- bindings/scripts/test/JS/JSattribute.cpp:
(WebCore::setJSattributeConstructor):
- bindings/scripts/test/JS/JSreadonly.cpp:
(WebCore::setJSreadonlyConstructor):
- page/DOMWindow.idl:
LayoutTests:
- fast/dom/HTMLDocument/constructor-setter-crash-expected.txt: Added.
- fast/dom/HTMLDocument/constructor-setter-crash.html: Added.
Add regression test for crash at <rdar://problem/22825602>.
- fast/dom/prototype-constructor-setter-expected.txt: Added.
- fast/dom/prototype-constructor-setter.html: Added.
Add new test checking that prototype.constructor is writable.
- js/dom/constructor-attributes-expected.txt:
Rebaseline existing test now that prototype.constructor is writable.
- 12:57 PM Changeset in webkit [195906] by
-
- 3 edits in trunk/Source/JavaScriptCore
[B3] JetStream/quicksort.c fails/hangs on Linux with GCC
https://bugs.webkit.org/show_bug.cgi?id=153647
Reviewed by Filip Pizlo.
In B3ComputeDivisionMagic, we accidentally perform sub, add operation onto signed integer. (In this case, int32_t)
But integer overflow is undefined behavior in C[1][2]
As a result, in GCC 4.9 release build, computeDivisionMagic(2) returns unexpected value.
divisor = 2
d = 2
signedMin = INT32_MIN = -2147483647 (-0x7fffffff)
t = signedMin
anc = t - 1 - (t % ad)Oops, we performed overflow operation!
So,
ancvalue becomes undefined.
In this patch, we first cast all the operated values to unsigned one.
Reading the code, there are no operations that depends on signedness. (For example, we used aboveEqual like unsigned operations for comparison.)
[1]: http://blog.llvm.org/2011/05/what-every-c-programmer-should-know.html
[2]: http://dl.acm.org/citation.cfm?id=2522728
- b3/B3ComputeDivisionMagic.h:
(JSC::B3::computeDivisionMagic):
- b3/testb3.cpp:
(JSC::B3::testComputeDivisionMagic):
(JSC::B3::run):
- 12:48 PM Changeset in webkit [195905] by
-
- 2 edits in trunk/Source/JavaScriptCore
Shrink Heap::m_executables after cleaning it.
<https://webkit.org/b/153682>
Reviewed by Darin Adler.
The Heap::m_executables Vector was never shrunk down, despite sometimes
getting pretty huge (~500kB in my longest-running WebContent process.)
After GC has finished pruning unmarked Executables, shrink the Vector.
- heap/Heap.cpp:
(JSC::Heap::clearUnmarkedExecutables):
- 12:10 PM Changeset in webkit [195904] by
-
- 12 edits in trunk
Move more 'constructor' properties to the prototype
https://bugs.webkit.org/show_bug.cgi?id=153667
Reviewed by Darin Adler.
LayoutTests/imported/w3c:
Rebaseline several W3C tests now that more checks are passing. A lot of
the 'constructor' attributes checks are still failing because the
attribute is not writable. This is being addressed via Bug 149412.
- web-platform-tests/dom/collections/HTMLCollection-supported-property-names-expected.txt:
- web-platform-tests/dom/interfaces-expected.txt:
- web-platform-tests/dom/nodes/Element-getElementsByTagName-expected.txt:
- web-platform-tests/html/dom/documents/dom-tree-accessors/document.forms-expected.txt:
- web-platform-tests/html/dom/interfaces-expected.txt:
Source/WebCore:
Move more 'constructor' properties to the prototype. In particular, we
used to keep the 'constructor' on the instance for interfaces that have
an indexed / named property getter because our getOwnPropertySlot()
implementation used to be wrong for such interfaces.
However, getOwnPropertySlot() should be correct after r188590 so we
should now be able to move the 'constructor' up to the prototype for
these interfaces, as per the specification:
http://heycam.github.io/webidl/#interface-prototype-object
No new tests, already covered by existing tests.
- bindings/js/JSPluginElementFunctions.h:
(WebCore::pluginElementCustomGetOwnPropertySlot):
Add a null check for staticPropHashTable. It is now null because this
type no longer has any property on the instance now that 'constructor'
is on the prototype.
- bindings/scripts/CodeGeneratorJS.pm:
(ConstructorShouldBeOnInstance):
LayoutTests:
Rebaseline a couple of tests now that 'constructor' is on the prototype
for more interfaces.
- fast/dom/htmlcollection-getownpropertynames-expected.txt:
- storage/domstorage/localstorage/delete-defineproperty-removal-expected.txt:
- 12:06 PM Changeset in webkit [195903] by
-
- 5 edits in trunk/Websites/webkit.org
Improve the style of B3 documentation
https://bugs.webkit.org/show_bug.cgi?id=153674
Reviewed by Oliver Hunt.
This makes the style of the B3 documentation look like the Wiki, which I think is
appropriate for the kind of content that we're putting into it - in particular, the font
is the perfect size for dense content. The style also doesn't require much spoonfeeding
from the HTML side so you can write nice looking documentation by just using really
basic HTML constructs.
- docs/b3/assembly-intermediate-representation.html:
- docs/b3/index.html:
- docs/b3/intermediate-representation.html:
- docs/b3/style.css:
- 12:01 PM Changeset in webkit [195902] by
-
- 2 edits in trunk/Source/WebKit2
[GTK] Use configured python executable when executing generate-inspector-gresource-manifest.py
https://bugs.webkit.org/show_bug.cgi?id=153712
Patch by Jeremy Huddleston Sequoia <jeremyhu@apple.com> on 2016-01-30
Reviewed by Michael Catanzaro.
- PlatformGTK.cmake:
- 11:30 AM Changeset in webkit [195901] by
-
- 10 edits in trunk/Source
Enable VIDEO_PRESENTATION_MODE only in Debug and Release builds on Mac
https://bugs.webkit.org/show_bug.cgi?id=153665
Reviewed by Dan Bernstein.
Source/JavaScriptCore:
- Configurations/FeatureDefines.xcconfig:
Source/WebCore:
- Configurations/FeatureDefines.xcconfig:
Source/WebKit/mac:
- Configurations/FeatureDefines.xcconfig:
Source/WebKit2:
- Configurations/FeatureDefines.xcconfig:
Source/WTF:
- wtf/Platform.h:
Remove this as the flag is already defined in FeatureDefines.xcconfig files.
- 11:22 AM Changeset in webkit [195900] by
-
- 2 edits in trunk/Source/WebCore
[iOS] WebKit1 apps crash in _ZN7WebCore16DiskCacheMonitorC2ERKNS_15ResourceRequestENS_9SessionIDEPK20_CFCachedURLResponse_block_invoke1
<http://webkit.org/b/153710>
<rdar://problem/23116706>
Reviewed by Darin Adler.
- loader/cocoa/DiskCacheMonitorCocoa.mm:
(WebCore::DiskCacheMonitor::DiskCacheMonitor):
- Fix race condition on iOS WebKit1 clients by calling the block to cancel the DiskCacheMonitor on the WebThread, which is the same thread where the CFCachedURLResponseCallBackBlock is called.
- Removed whitespace to adhere to style.
- 10:38 AM Changeset in webkit [195899] by
-
- 14 edits2 adds in trunk
TouchList should be retargeted
https://bugs.webkit.org/show_bug.cgi?id=149592
Reviewed by Antti Koivisto.
Source/WebCore:
Retarget touch target's using the same algorithm as the one used for related targets instead of
EventRelatedNodeResolver which is removed in this patch.
Also enable the retargeting on iOS.
Test: fast/shadow-dom/touch-event-ios.html
- dom/EventContext.cpp:
(WebCore::TouchEventContext::TouchEventContext):
(WebCore::TouchEventContext::handleLocalEvents):
(WebCore::TouchEventContext::checkReachability):
- dom/EventContext.h:
(WebCore::toTouchEventContext):
(WebCore::EventContext::isUnreachableNode):
- dom/EventDispatcher.cpp:
(WebCore::EventRelatedNodeResolver): Deleted.
(WebCore::EventPath::EventPath):
(WebCore::EventDispatcher::dispatchEvent):
(WebCore::addRelatedNodeResolversForTouchList): Deleted.
(WebCore::EventPath::updateTouchLists): Deleted.
(WebCore::EventPath::setRelatedTarget): Removed superfluous UNUSED_PARAM since the argument is always used.
(WebCore::EventPath::retargetTouch): Extracted from updateTouchLists/setRelatedTarget. Clones Touch object
with the new target for each event context just like related targets.
(WebCore::EventPath::retargetTouchLists): Renamed from updateTouchLists. Calls retargetTouch on each Touch
object in each TouchList.
- dom/TouchEvent.h:
Tools:
Added touchDownAtPoint and liftUpAtPoint to UIScriptController so that we can test touch events with
multiple touch targets on iOS. fast/shadow-dom/touch-event-ios.html uses this new testing feature.
- WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl:
- WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
(WTR::UIScriptController::touchDownAtPoint): Added.
(WTR::UIScriptController::liftUpAtPoint): Added.
- WebKitTestRunner/UIScriptContext/UIScriptController.h:
- WebKitTestRunner/ios/HIDEventGenerator.h:
- WebKitTestRunner/ios/HIDEventGenerator.mm:
(-[HIDEventGenerator touchDown:touchCount:completionBlock:]): Added. Sends touch down and waits.
(-[HIDEventGenerator liftUp:touchCount:completionBlock:]): Ditto for lift up.
- WebKitTestRunner/ios/UIScriptControllerIOS.mm:
(WTR::UIScriptController::touchDownAtPoint): Added.
(WTR::UIScriptController::liftUpAtPoint): Added.
LayoutTests:
Added a regression test for retargeting touch targets on iOS.
- fast/shadow-dom/touch-event-ios-expected.txt: Added.
- fast/shadow-dom/touch-event-ios.html: Added.
- platform/mac/TestExpectations: Added the failing expectation on Mac since touch support is not enabled.
- 10:09 AM Changeset in webkit [195898] by
-
- 2 edits in trunk/Source/JavaScriptCore
[B3] REGRESSION(r195882): Should break early after modConstant replaceWithNewValue succeeds
https://bugs.webkit.org/show_bug.cgi?id=153711
Reviewed by Filip Pizlo.
Should break after modConstant replaceWithNewValue succeeds. m_value is already replaced with Identity
if modConstant succeeds. So it does not have any children. m_value->child(1) breaks testb3.
- b3/B3ReduceStrength.cpp:
- 9:03 AM WebKitGTK/Gardening/Calendar edited by
- (diff)
- 9:03 AM WebKitGTK/Gardening/Calendar edited by
- (diff)
- 9:02 AM Changeset in webkit [195897] by
-
- 2 edits in trunk/LayoutTests
[GTK] Two disk cache tests are failing
Unreviewed gardening.
- platform/gtk/TestExpectations:
- 8:48 AM Changeset in webkit [195896] by
-
- 2 edits in trunk/LayoutTests
[GTK] Some W3C DOM tests are failing
Unreviewed gardening.
- platform/gtk/TestExpectations:
- 8:38 AM Changeset in webkit [195895] by
-
- 2 edits in trunk/LayoutTests
[GTK] IndexedDB expectations gardening
Unreviewed gardening.
- platform/gtk/TestExpectations:
- 8:14 AM Changeset in webkit [195894] by
-
- 2 edits in trunk/LayoutTests
[GTK] platform/gtk/scrollbars/overflow-scrollbar-horizontal-wheel-scroll.html is failing
Unreviewed gardening.
- platform/gtk/TestExpectations:
- 8:03 AM Changeset in webkit [195893] by
-
- 2 edits in trunk/LayoutTests
[GTK] Some organization in the test expectations file
Unreviewed.
- platform/gtk/TestExpectations:
- 7:33 AM WebKitGTK/Gardening/Calendar edited by
- (diff)
- 7:28 AM Changeset in webkit [195892] by
-
- 20 edits35 adds in trunk
Support break-after, break-before and break-inside.
https://bugs.webkit.org/show_bug.cgi?id=148814
Reviewed by Dean Jackson.
Source/WebCore:
New tests added in printing/, fast/multicol/, and fast/regions.
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::convertToPageBreak):
(WebCore::convertToColumnBreak):
(WebCore::convertToRegionBreak):
For backwards compatibility, keep support for all the old properties in
computed style. This means we have to convert the break-* property values
into keywords that make sense for the legacy properties. This mainly
involves mapping "page", "column", "region" to "always" (similar rule for
the avoid-* versions as well).
(WebCore::ComputedStyleExtractor::propertyValue):
Add support for the three new break-* properties.
- css/CSSParser.cpp:
(WebCore::isValidKeywordPropertyAndValue):
(WebCore::isKeywordPropertyID):
(WebCore::CSSParser::parseValue):
Add support for the new break properties.
- css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::operator BreakBetween):
(WebCore::CSSPrimitiveValue::operator BreakInside):
Add converters for the new BreakBetween and BreakInside enums. Remove
the EPageBreak enum, since it is no longer used.
- css/CSSPropertyNames.in:
- css/CSSValueKeywords.in:
Add the new properties and the new values supported by the properties
to the keywords lists.
- css/StyleBuilderConverter.h:
(WebCore::StyleBuilderConverter::convertFontSynthesis):
(WebCore::StyleBuilderConverter::convertPageBreakBetween):
(WebCore::StyleBuilderConverter::convertPageBreakInside):
(WebCore::StyleBuilderConverter::convertColumnBreakBetween):
(WebCore::StyleBuilderConverter::convertColumnBreakInside):
(WebCore::StyleBuilderConverter::convertRegionBreakBetween):
(WebCore::StyleBuilderConverter::convertRegionBreakInside):
In order to map the legacy properties into the new break-* values
we have custom converter functions.
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::paintChild):
(WebCore::RenderBlock::childBoxIsUnsplittableForFragmentation):
(WebCore::RenderBlock::computeRegionRangeForBoxChild):
- rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::applyBeforeBreak):
(WebCore::RenderBlockFlow::applyAfterBreak):
Patch the block code to check the correct new break-* constants. For
avoidance, this means checking both the general avoid value and the
specific value (e.g., avoid-page). In place of "always", we check
the specific value (e.g., column) and then for page specifically, we
also treat "left", "right", "recto" and "verso" as "always break" for now.
- rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::changeRequiresLayout):
Make sure changes to the break properties trigger relayout.
- rendering/style/RenderStyle.h:
Add getters and setters for the break-* properties and remove all
occurrences of the legacy page, column and region values from the RenderStyle.
- rendering/style/RenderStyleConstants.cpp:
(WebCore::alwaysPageBreak):
We have a helper function here for mapping several constant values to "page".
- rendering/style/RenderStyleConstants.h:
Definitions of the new BreakBetween and BreakInside enums.
- rendering/style/StyleMultiColData.cpp:
(WebCore::StyleMultiColData::StyleMultiColData):
(WebCore::StyleMultiColData::operator==):
- rendering/style/StyleMultiColData.h:
Remove the column-specific break data.
- rendering/style/StyleRareNonInheritedData.cpp:
(WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
(WebCore::StyleRareNonInheritedData::operator==):
- rendering/style/StyleRareNonInheritedData.h:
Remove the region-specific break data and replace it with generic break
data that is now used by all three pagination models.
LayoutTests:
- TestExpectations:
- fast/multicol/standardized-break-properties-expected.txt: Added.
- fast/multicol/standardized-break-properties.html: Added.
- fast/multicol/vertical-lr/standardized-break-properties-expected.txt: Added.
- fast/multicol/vertical-lr/standardized-break-properties.html: Added.
- fast/multicol/vertical-rl/standardized-break-properties-expected.txt: Added.
- fast/multicol/vertical-rl/standardized-break-properties.html: Added.
- fast/regions/text-break-properties-expected.txt: Added.
- fast/regions/text-break-properties.html: Added.
- printing/allowed-breaks-expected.txt: Added.
- printing/allowed-breaks.html: Added.
- printing/break-after-avoid-expected.txt: Added.
- printing/break-after-avoid-page-expected.txt: Added.
- printing/break-after-avoid-page.html: Added.
- printing/break-after-avoid.html: Added.
- printing/break-always-expected.txt: Added.
- printing/break-always.html: Added.
- printing/break-avoid-expected.txt: Added.
- printing/break-avoid-page-expected.txt: Added.
- printing/break-avoid-page.html: Added.
- printing/break-avoid.html: Added.
- printing/break-display-none-expected.txt: Added.
- printing/break-display-none.html: Added.
- printing/break-inside-avoid-expected.txt: Added.
- printing/break-inside-avoid-page-expected.txt: Added.
- printing/break-inside-avoid-page.html: Added.
- printing/break-inside-avoid.html: Added.
- printing/script-tests/allowed-breaks.js: Added.
(test):
- printing/script-tests/break-after-avoid-page.js: Added.
(test):
- printing/script-tests/break-after-avoid.js: Added.
(test):
- printing/script-tests/break-always.js: Added.
(test):
- printing/script-tests/break-avoid-page.js: Added.
(test):
- printing/script-tests/break-avoid.js: Added.
(test):
- printing/script-tests/break-display-none.js: Added.
(test):
- printing/script-tests/break-inside-avoid-page.js: Added.
(test):
- printing/script-tests/break-inside-avoid.js: Added.
(test):
- 7:25 AM WebKitGTK/Gardening/Calendar edited by
- (diff)
- 4:53 AM Changeset in webkit [195891] by
-
- 13 edits in trunk
Enable SamplingProfiler on POSIX environment
https://bugs.webkit.org/show_bug.cgi?id=153584
Reviewed by Michael Saboff.
.:
Add features.h header check. It will define GLIBC.
- Source/cmake/OptionsCommon.cmake:
Source/JavaScriptCore:
In this patch, we implement suspend and resume mechanizm for POSIX threads.
And with GLIBC, we can retrieve registers from it.
We take the following strategy.
Suspend side.
- install sigaction to the threads.
- in the profiler (suspend / resume callers), emit signal with pthread_kill and wait with POSIX semaphore.
- in the signal handler, up the POSIX semaphore. Use sem_post because it is the async-signal-safe function in POSIX.
- in the signal handler, perform sigsuspend to stop the thread until being resumed.
- in the profiler, we can be waken up from the semaphore because (3) ups.
Resume side.
- in the profiler, emit signal and wait on the semaphore.
- in the signal handler, it is waken up from the sigsuspend.
- in the signal handler, up the semaphore.
- in the profiler, the profiler is waken up from the semaphore. It is ensured that the given thread is resumed by the signal.
- heap/MachineStackMarker.cpp:
(pthreadSignalHandlerSuspendResume):
(JSC::MachineThreads::Thread::Thread):
(JSC::MachineThreads::Thread::~Thread):
(JSC::MachineThreads::Thread::suspend):
(JSC::MachineThreads::Thread::resume):
(JSC::MachineThreads::Thread::getRegisters):
(JSC::MachineThreads::Thread::Registers::stackPointer):
(JSC::MachineThreads::Thread::Registers::framePointer):
(JSC::MachineThreads::Thread::Registers::instructionPointer):
(JSC::MachineThreads::Thread::Registers::llintPC):
(JSC::MachineThreads::Thread::freeRegisters):
- heap/MachineStackMarker.h:
- runtime/SamplingProfiler.cpp:
(JSC::reportStats):
- tests/stress/call-varargs-from-inlined-code-with-odd-number-of-arguments.js:
- tests/stress/call-varargs-from-inlined-code.js:
- tests/stress/v8-earley-boyer-strict.js:
Source/WTF:
Use GLIBC since mcontext_t layout depends on it.
- wtf/Platform.h:
Tools:
- Scripts/run-jsc-stress-tests:
Jan 29, 2016:
- 11:10 PM B3IntermediateRepresentation created by
- 11:10 PM BareBonesBackend created by
- 10:03 PM WebKitGTK/Gardening/Calendar edited by
- (diff)
- 9:59 PM Changeset in webkit [195890] by
-
- 2 edits in trunk/LayoutTests
[GTK] Mark two CSS multicolumn tests as failing
Unreviewed test gardening.
- platform/gtk/TestExpectations:
- 9:57 PM Changeset in webkit [195889] by
-
- 2 edits in trunk/LayoutTests
[GTK] Mark two scrollbar tests as crashing
Unreviewed test gardening.
- platform/gtk/TestExpectations:
- 9:56 PM Changeset in webkit [195888] by
-
- 2 edits in trunk/LayoutTests
[GTK] Really mark imported/blink/fast/css/first-letter-float-block.html as crashing
Unreviewed test gardening. Copypaste error in the previous commit.
- platform/gtk/TestExpectations:
- 9:53 PM Changeset in webkit [195887] by
-
- 2 edits in trunk/LayoutTests
[GTK] Mark imported/blink/fast/css/first-letter-float-block.html as crashing
Unreviewed test gardening.
- platform/gtk/TestExpectations:
- 9:49 PM Changeset in webkit [195886] by
-
- 2 edits in trunk/LayoutTests
[GTK] Mark some accessibility role tests as failing
Unreviewed test gardening.
- platform/gtk/TestExpectations:
- 9:47 PM Changeset in webkit [195885] by
-
- 2 edits in trunk/LayoutTests
[GTK] Mark some content security policy tests as failing
Unreviewed test gardening.
- platform/gtk/TestExpectations:
- 9:46 PM Changeset in webkit [195884] by
-
- 2 edits in trunk/LayoutTests
[GTK] Mark Ruby expansion tests as failing
Unreviewed test gardening.
- platform/gtk/TestExpectations:
- 9:42 PM Changeset in webkit [195883] by
-
- 1 edit5 adds in trunk/LayoutTests
[GTK] Add expectations for media source SourceBuffer tests
Unreviewed test gardening.
- platform/gtk/http/tests/media/media-source/SourceBuffer-abort-expected.txt: Added.
- platform/gtk/http/tests/media/media-source/SourceBuffer-abort-readyState-expected.txt: Added.
- platform/gtk/http/tests/media/media-source/SourceBuffer-abort-removed-expected.txt: Added.
- platform/gtk/http/tests/media/media-source/SourceBuffer-abort-updating-expected.txt: Added.
- 9:14 PM Changeset in webkit [195882] by
-
- 2 edits in trunk/Source/JavaScriptCore
B3 should reduce Mod(value, constant) to Div and Mul so that our Div optimizations can do things
https://bugs.webkit.org/show_bug.cgi?id=153693
Reviewed by Saam Barati.
The most efficient way to handle Mod(value, constant) is to reduce it to
Sub(value, Mul(Div(value, constant), constant)) and then let the Div optimizations do their
thing.
In the future we could add special handling of Mod(value, 1 << constant), but it's not
obvious that this would produce better code than reducing through Div, if we also make sure
that we have great optimizations for Mul and Div.
- b3/B3ReduceStrength.cpp:
- 7:31 PM Changeset in webkit [195881] by
-
- 7 edits in trunk/Source/WebInspectorUI
Web Inspector: Add support for variable size timeline graphs
https://bugs.webkit.org/show_bug.cgi?id=153690
<rdar://problem/24421696>
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-01-29
Reviewed by Timothy Hatcher.
- UserInterface/Views/LayoutTimelineDataGrid.js:
(WebInspector.LayoutTimelineDataGrid): Deleted.
Remove unnecessary constructor.
- UserInterface/Views/TimelineOverviewGraph.js:
(WebInspector.TimelineOverviewGraph.prototype.set selectedRecord):
Default graph height.
- UserInterface/Views/RenderingFrameTimelineOverview.js:
(WebInspector.RenderingFrameTimelineOverview.prototype.get height):
Custom graph height.
- UserInterface/Views/TimelineOverview.js:
(WebInspector.TimelineOverview.prototype.get height):
Provide a way to get the height of the overview which accumulates graph heights.
- UserInterface/Views/TimelineRecordingContentView.js:
(WebInspector.TimelineRecordingContentView.prototype.get timelineOverviewHeight):
(WebInspector.TimelineRecordingContentView.prototype._updateTimelineOverviewHeight):
- UserInterface/Views/TimelineSidebarPanel.js:
(WebInspector.TimelineSidebarPanel.prototype._updateTimelineOverviewHeight):
Switch from assuming certain graph heights to asking the overview for its height.
- 7:19 PM Changeset in webkit [195880] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Object previews in the Console are misaligned
https://bugs.webkit.org/show_bug.cgi?id=153676
<rdar://problem/24418796>
Patch by Devin Rousso <Devin Rousso> on 2016-01-29
Reviewed by Timothy Hatcher.
- UserInterface/Views/ObjectTreeView.css:
(.object-tree .tree-outline.object.compact):
(.object-tree): Deleted.
- 6:57 PM Changeset in webkit [195879] by
-
- 2 edits in trunk/Source/WebCore
[Win] Fix compile error.
https://bugs.webkit.org/show_bug.cgi?id=153646
Reviewed by Darin Adler.
- platform/text/win/LocaleWin.cpp:
(WebCore::LCIDFromLocaleInternal):
- 6:45 PM Changeset in webkit [195878] by
-
- 9 edits1 add in trunk/Source/JavaScriptCore
Array.prototype native functions should use Symbol.species to construct the result
https://bugs.webkit.org/show_bug.cgi?id=153660
Reviewed by Saam Barati.
This patch adds support for Symbol.species in the Array.prototype native functions.
We make an optimization to avoid regressions on some benchmarks by using an
adaptive watchpoint to check if Array.prototype.constructor is ever changed.
- runtime/ArrayPrototype.cpp:
(JSC::putLength):
(JSC::setLength):
(JSC::speciesConstructArray):
(JSC::arrayProtoFuncConcat):
(JSC::arrayProtoFuncSlice):
(JSC::arrayProtoFuncSplice):
(JSC::ArrayPrototype::setConstructor):
(JSC::ArrayPrototypeAdaptiveInferredPropertyWatchpoint::ArrayPrototypeAdaptiveInferredPropertyWatchpoint):
(JSC::ArrayPrototypeAdaptiveInferredPropertyWatchpoint::handleFire):
- runtime/ArrayPrototype.h:
(JSC::ArrayPrototype::didChangeConstructorProperty):
- runtime/ConstructData.cpp:
(JSC::construct):
- runtime/ConstructData.h:
- runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::init):
- tests/es6.yaml:
- tests/stress/array-species-functions.js: Added.
(Symbol.species):
(funcThrows):
(test.species):
(test):
- 6:36 PM Changeset in webkit [195877] by
-
- 3 edits in trunk/Source/JavaScriptCore
CallLinkStatus should trust BadCell exit sites whenever there is no stub
https://bugs.webkit.org/show_bug.cgi?id=153691
Reviewed by Benjamin Poulain.
This fixes a regression in our treatment of inlining failure exit sites when deciding if we
should inline a call.
A long time ago, a BadCell exit site would ensure that a CallLinkStatus returned
takesSlowPath.
But then we added closure calls. A BadCell exit site might just mean that we should do
closure call inlining. We added a BadExecutable exit site to indicate that even closure call
inlining had failed. BadCell would no longer force CallLinkStatus to return takesSlowPath,
but BadExecutable would stuff do so.
But then we unified the IR for checking functions and executables, and the DFG stopped using
the BadExecutable exit kind. Probably this change disabled our ability to use exit site
counting for deciding when to takesSlowPath. But this isn't necessarily a disaster, since
any time you exited in this way, you'd be taken to a baseline call inline cache, and that
inline cache would record the slow path.
But then we introduced polymorphic call inlining. Polymorphic call inlining means that call
unlinking, like when one of the callees is optimized, will reset the stub. We also made it
so that the stub is like a gate for the slow path count. A clear inline cache must first
cause the creation of a stub and then cause it to overflow before the slow path is counted.
So, if the DFG or FTL exits on a cell check associated with a particular callsite being
speculatively inlined, then it's possible that nobody will know about the exit because:
- The exit kind is BadCell but CallLinkStatus needs BadExecutable to disable inlining.
- Between when we tiered up to the DFG (or FTL) and when the exit happened, one of the callees was tiered up, causing the baseline CallLinkInfo to be unlinked. Therefore, after the exit, the inline cache is in a reset state and will not count the call as taking slow path.
The challenge when dealing with this is that often, we will have an super early compilation
of a minimorphic call site before we have seen all of its small set of callees. For example
we may have seen only one of two possible callees. That early compilation will OSR exit, and
in trunk, will be recompiled with bimorphic speculative inlining. That's a pretty good
outcome. Basically, we are trusting that if during the time that the function has been
running prior to a given compilation, a callsite has only seen a small number of callees,
then it's safe to assume that it won't see another one anytime soon.
So, simply forcing the CallLinkStatus to set takesSlowPath any time there was a BadCell exit
would hurt our performance in some cases, because trunk prior to this change would have their
final compilation use speculative inlining, and this change would make guarded inlining
instead.
The compromise that I came up with relies on the fact that a CallLinkInfo must be reset quite
frequently for it to routinely happen in between tier-up to DFG (or FTL) and an exit. So,
most likely, such a CallLinkInfo will also show up as being clear when the CallLinkStatus
is built during DFG profiling. The CallLinkStatus will then fall back on the CallLinkInfo's
lastSeenCallee field, which is persistent across resets. This change just makes it so that
CallLinkStatus sets takesSlowPath if there is a BadCell exit and the status had to be
inferred from the lastSeenCallee.
This change reduces pointless recompilations in gbemu. It's an 11% speed-up on gbemu. It
doesn't seem to hurt any benchmarks.
- bytecode/CallLinkStatus.cpp:
(JSC::CallLinkStatus::computeFor):
(JSC::CallLinkStatus::computeExitSiteData):
(JSC::CallLinkStatus::computeFromCallLinkInfo):
- bytecode/CallLinkStatus.h:
(JSC::CallLinkStatus::CallLinkStatus):
(JSC::CallLinkStatus::at):
(JSC::CallLinkStatus::operator[]):
(JSC::CallLinkStatus::isProved):
(JSC::CallLinkStatus::isBasedOnStub):
(JSC::CallLinkStatus::canOptimize):
(JSC::CallLinkStatus::maxNumArguments):
(JSC::CallLinkStatus::ExitSiteData::ExitSiteData): Deleted.
- 6:05 PM Changeset in webkit [195876] by
-
- 7 edits in trunk/Source/JavaScriptCore
Pack FunctionExecutable and UnlinkedFunctionExecutable harder
https://bugs.webkit.org/show_bug.cgi?id=153687
Reviewed by Andreas Kling.
This patch reduces FunctionExecutable from 120 to 104 bytes.
This patch reduces UnlinkedFunctionExecutable from 144 to 136 bytes.
- bytecode/ExecutableInfo.h:
- bytecode/UnlinkedFunctionExecutable.cpp:
(JSC::UnlinkedFunctionExecutable::UnlinkedFunctionExecutable):
- bytecode/UnlinkedFunctionExecutable.h:
- parser/ParserModes.h:
(JSC::functionNameScopeIsDynamic):
- runtime/Executable.cpp:
(JSC::ScriptExecutable::ScriptExecutable):
- runtime/Executable.h:
(JSC::ScriptExecutable::needsActivation):
(JSC::ScriptExecutable::isArrowFunctionContext):
(JSC::ScriptExecutable::isStrictMode):
(JSC::ScriptExecutable::derivedContextType):
(JSC::ScriptExecutable::ecmaMode):
(JSC::ScriptExecutable::finishCreation):
- 5:53 PM Changeset in webkit [195875] by
-
- 1 copy in tags/Safari-601.5.13
New tag.
- 5:51 PM Changeset in webkit [195874] by
-
- 1 edit in branches/safari-601-branch/Source/WebCore/platform/graphics/mac/FontCacheMac.mm
Build fix after r195857. rdar://problem/24208101
- 5:38 PM Changeset in webkit [195873] by
-
- 2 edits in trunk/LayoutTests
Rebaseline fast/block/basic/016.html for ios-simulator after r195740
Unreviewed test gardening.
- platform/ios-simulator/fast/block/basic/016-expected.txt:
- 5:31 PM Changeset in webkit [195872] by
-
- 2 edits in trunk/LayoutTests
Last commit should have marked fast/text/fallback-language-han-2.html as an ImageOnlyFailure. Fixing that.
https://bugs.webkit.org/show_bug.cgi?id=152438
Unreviewed test gardening.
- platform/ios-simulator/TestExpectations:
- 5:29 PM Changeset in webkit [195871] by
-
- 3 edits in trunk/Source/WebCore
Tab suspension code shouldn't use page cache cacheability logic
https://bugs.webkit.org/show_bug.cgi?id=153680
Reviewed by Andreas Kling.
Most of PageCache::canCache() is unnecessary for tab suspension.
Also improve robustness.
- page/Page.cpp:
(WebCore::Page::setPageActivityState):
(WebCore::Page::setIsVisible):
(WebCore::Page::setIsVisibleInternal):
(WebCore::Page::setIsPrerender):
(WebCore::Page::canTabSuspend):
Include visibility test here.
Instead of calling PageCache::canCache() just check for each frame that
- that the document is loaded
- that active DOM objects allow suspension
(WebCore::Page::setIsTabSuspended):
(WebCore::Page::setTabSuspensionEnabled):
(WebCore::Page::updateTabSuspensionState):
Refactor for robustness.
(WebCore::Page::tabSuspensionTimerFired):
Call canTabSuspend, the result might have changed.
(WebCore::Page::scheduleTabSuspension): Deleted.
- page/Page.h:
- 5:28 PM Changeset in webkit [195870] by
-
- 2 edits in trunk/LayoutTests
Mark fast/text/fallback-language-han-2.html as failing on ios-simulator.
https://bugs.webkit.org/show_bug.cgi?id=152438
Unreviewed test gardening.
- platform/ios-simulator/TestExpectations:
- 5:24 PM Changeset in webkit [195869] by
-
- 2 edits in trunk/LayoutTests
Marking two WPT dom-tree-accessors/document.getElementsByName tests as failing on ios-simulator.
https://bugs.webkit.org/show_bug.cgi?id=153370
Unreviewed test gardening.
- platform/ios-simulator/TestExpectations:
- 5:20 PM Changeset in webkit [195868] by
-
- 2 edits in trunk/LayoutTests
Marking webarchive/loading/object.html as flaky on ios-simulator-wk2
https://bugs.webkit.org/show_bug.cgi?id=153380
Unreviewed test gardening.
- platform/ios-simulator-wk2/TestExpectations:
- 5:14 PM Changeset in webkit [195867] by
-
- 1 copy in tags/Safari-601.1.46.95
New tag.
- 5:13 PM Changeset in webkit [195866] by
-
- 2 edits in trunk/LayoutTests
Marking all displaylists tests as flaky on ios-simulator
https://bugs.webkit.org/show_bug.cgi?id=153656
Unreviewed test gardening.
- platform/ios-simulator/TestExpectations:
- 5:11 PM Changeset in webkit [195865] by
-
- 45 edits3 adds in trunk/Source/JavaScriptCore
JSC Sampling Profiler: Come up with a (program counter => CodeOrigin) mapping
https://bugs.webkit.org/show_bug.cgi?id=152629
Reviewed by Filip Pizlo.
This patch implements a mapping from PC to CodeOrigin
that lives off of JITed CodeBlocks. We build this mapping
while JITing code, and then we compress it and store
it on the CodeBlock. We only build the mapping if a debugger
has ever been attached to any global object.
CodeBlock consults this mapping when searching for a CodeOrigin
for a given PC, but it also consults other code ranges
off the main path that may own the PC. Specifically, it searches
through inline caches, OSRExits, and LazySlowPaths.
To find PC info for the LLInt, we also save the LLInt pc when
taking a stack trace where the top frame is in LLInt code.
This patch also cleans up code inside the SamplingProfier.
I realized a bug in the SamplingProfiler's implementation.
We used to walk the inline stack while gathering a stack
trace. This is wrong. It's super dangerous to do this because
we might pause the JSC process while it's modifying its
CodeOrigin table. We used to walk the inline stack while
taking a stack trace because doing so could save us from
having to verify a particular stack trace. This patch changes that.
We now have to verify all stack traces taken. This verification step
includes walking the inline stack.
Because we have a PC=>CodeOrigin map, we can now gather more
detailed information about the top-frame we pause. This allows
us to correctly observe inlining. It also allows us to observe
expression-level line/column information for the top frame.
The reason we don't consult this mapping for parent frames is
that all parent frames should set the CallSiteIndex on the call
frame header, which means we can consult that value to get inlining
and expression-level line/column information.
- CMakeLists.txt:
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters:
- JavaScriptCore.xcodeproj/project.pbxproj:
- assembler/AbstractMacroAssembler.h:
(JSC::AbstractMacroAssembler::Label::Label):
(JSC::AbstractMacroAssembler::Label::operator==):
(JSC::AbstractMacroAssembler::Label::isSet):
- assembler/AssemblerBuffer.h:
(JSC::AssemblerLabel::labelAtOffset):
(JSC::AssemblerLabel::operator==):
- b3/B3Generate.cpp:
- b3/B3Origin.h:
(JSC::B3::Origin::data):
(JSC::B3::Origin::operator==):
- b3/B3PCToOriginMap.h: Added.
(JSC::B3::PCToOriginMap::PCToOriginMap):
(JSC::B3::PCToOriginMap::appendItem):
(JSC::B3::PCToOriginMap::ranges):
- b3/B3Procedure.h:
(JSC::B3::Procedure::pcToOriginMap):
(JSC::B3::Procedure::releasePCToOriginMap):
- b3/air/AirGenerate.cpp:
(JSC::B3::Air::generate):
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::insertBasicBlockBoundariesForControlFlowProfiler):
(JSC::CodeBlock::setPCToCodeOriginMap):
(JSC::CodeBlock::findPC):
- bytecode/CodeBlock.h:
(JSC::CodeBlock::jitCodeMap):
(JSC::CodeBlock::bytecodeOffset):
- bytecode/CodeOrigin.h:
(JSC::CodeOrigin::operator==):
(JSC::CodeOriginHash::hash):
(JSC::CodeOriginHash::equal):
- bytecode/InlineCallFrame.h:
(JSC::baselineCodeBlockForOriginAndBaselineCodeBlock):
(JSC::CodeOrigin::walkUpInlineStack):
- bytecode/PolymorphicAccess.h:
(JSC::PolymorphicAccess::containsPC):
- bytecode/StructureStubInfo.cpp:
(JSC::StructureStubInfo::visitWeakReferences):
(JSC::StructureStubInfo::containsPC):
- bytecode/StructureStubInfo.h:
- bytecode/UnlinkedCodeBlock.h:
(JSC::UnlinkedCodeBlock::hasExpressionInfo):
(JSC::UnlinkedCodeBlock::expressionInfo):
(JSC::UnlinkedCodeBlock::setThisRegister):
- debugger/Debugger.cpp:
(JSC::Debugger::attach):
- dfg/DFGJITCode.cpp:
(JSC::DFG::JITCode::validateReferences):
(JSC::DFG::JITCode::findPC):
- dfg/DFGJITCode.h:
(JSC::DFG::JITCode::commonDataOffset):
- dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::JITCompiler):
(JSC::DFG::JITCompiler::link):
(JSC::DFG::JITCompiler::compile):
(JSC::DFG::JITCompiler::compileFunction):
(JSC::DFG::JITCompiler::recordCallSiteAndGenerateExceptionHandlingOSRExitIfNeeded):
(JSC::DFG::JITCompiler::setEndOfMainPath):
(JSC::DFG::JITCompiler::setEndOfCode):
- dfg/DFGJITCompiler.h:
(JSC::DFG::JITCompiler::setStartOfCode):
(JSC::DFG::JITCompiler::setForNode):
(JSC::DFG::JITCompiler::addCallSite):
(JSC::DFG::JITCompiler::pcToCodeOriginMapBuilder):
(JSC::DFG::JITCompiler::setEndOfMainPath): Deleted.
(JSC::DFG::JITCompiler::setEndOfCode): Deleted.
- dfg/DFGSlowPathGenerator.h:
(JSC::DFG::SlowPathGenerator::call):
(JSC::DFG::SlowPathGenerator::origin):
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::addSlowPathGenerator):
(JSC::DFG::SpeculativeJIT::runSlowPathGenerators):
(JSC::DFG::SpeculativeJIT::compileCurrentBlock):
- dfg/DFGSpeculativeJIT.h:
- ftl/FTLB3Compile.cpp:
(JSC::FTL::compile):
- ftl/FTLJITCode.cpp:
(JSC::FTL::JITCode::liveRegistersToPreserveAtExceptionHandlingCallSite):
(JSC::FTL::JITCode::findPC):
- ftl/FTLJITCode.h:
(JSC::FTL::JITCode::b3Code):
- heap/MachineStackMarker.cpp:
(JSC::MachineThreads::Thread::Registers::instructionPointer):
(JSC::MachineThreads::Thread::Registers::llintPC):
(JSC::MachineThreads::Thread::freeRegisters):
- heap/MachineStackMarker.h:
- inspector/agents/InspectorScriptProfilerAgent.cpp:
(Inspector::InspectorScriptProfilerAgent::addEvent):
(Inspector::buildSamples):
(Inspector::InspectorScriptProfilerAgent::trackingComplete):
- jit/JIT.cpp:
(JSC::JIT::JIT):
(JSC::JIT::privateCompileMainPass):
(JSC::JIT::privateCompileSlowCases):
(JSC::JIT::privateCompile):
- jit/JIT.h:
- jit/JITCode.h:
(JSC::JITCode::findPC):
- jit/PCToCodeOriginMap.cpp: Added.
(JSC::PCToCodeOriginMapBuilder::PCToCodeOriginMapBuilder):
(JSC::PCToCodeOriginMapBuilder::appendItem):
(JSC::PCToCodeOriginMap::PCToCodeOriginMap):
(JSC::PCToCodeOriginMap::~PCToCodeOriginMap):
(JSC::PCToCodeOriginMap::memorySize):
(JSC::PCToCodeOriginMap::findPC):
- jit/PCToCodeOriginMap.h: Added.
(JSC::PCToCodeOriginMapBuilder::defaultCodeOrigin):
(JSC::PCToCodeOriginMapBuilder::didBuildMapping):
- jsc.cpp:
(functionSamplingProfilerStackTraces):
- llint/LLIntPCRanges.h:
(JSC::LLInt::isLLIntPC):
- llint/LowLevelInterpreter.asm:
- runtime/Options.h:
- runtime/SamplingProfiler.cpp:
(JSC::reportStats):
(JSC::FrameWalker::FrameWalker):
(JSC::FrameWalker::walk):
(JSC::FrameWalker::resetAtMachineFrame):
(JSC::FrameWalker::isValidFramePointer):
(JSC::SamplingProfiler::SamplingProfiler):
(JSC::SamplingProfiler::~SamplingProfiler):
(JSC::tryGetBytecodeIndex):
(JSC::SamplingProfiler::processUnverifiedStackTraces):
(JSC::SamplingProfiler::visit):
(JSC::SamplingProfiler::noticeVMEntry):
(JSC::SamplingProfiler::clearData):
(JSC::SamplingProfiler::StackFrame::displayName):
(JSC::SamplingProfiler::StackFrame::displayNameForJSONTests):
(JSC::SamplingProfiler::StackFrame::functionStartLine):
(JSC::SamplingProfiler::StackFrame::functionStartColumn):
(JSC::SamplingProfiler::StackFrame::sourceID):
(JSC::SamplingProfiler::StackFrame::url):
(JSC::SamplingProfiler::releaseStackTraces):
(JSC::SamplingProfiler::stackTracesAsJSON):
(WTF::printInternal):
(JSC::SamplingProfiler::StackFrame::startLine): Deleted.
(JSC::SamplingProfiler::StackFrame::startColumn): Deleted.
(JSC::SamplingProfiler::stackTraces): Deleted.
- runtime/SamplingProfiler.h:
(JSC::SamplingProfiler::UnprocessedStackFrame::UnprocessedStackFrame):
(JSC::SamplingProfiler::StackFrame::StackFrame):
(JSC::SamplingProfiler::StackTrace::StackTrace):
(JSC::SamplingProfiler::totalTime):
(JSC::SamplingProfiler::setStopWatch):
- runtime/VM.cpp:
(JSC::VM::VM):
- runtime/VM.h:
(JSC::VM::setShouldBuildPCToCodeOriginMapping):
(JSC::VM::shouldBuilderPCToCodeOriginMapping):
- tests/stress/sampling-profiler-basic.js:
(platformSupportsSamplingProfiler.top):
(platformSupportsSamplingProfiler.jaz):
(platformSupportsSamplingProfiler.kaz):
- 4:34 PM Changeset in webkit [195864] by
-
- 2 edits in trunk/LayoutTests
Marking fast/parser/external-entities-in-xslt.xml as flaky on El Capitan
https://bugs.webkit.org/show_bug.cgi?id=153683
Unreviewed test gardening.
- platform/mac/TestExpectations:
- 4:06 PM Changeset in webkit [195863] by
-
- 4 edits in trunk
fast/shadow-dom/Element-interface-attachShadow.html fails on iOS
https://bugs.webkit.org/show_bug.cgi?id=153681
Reviewed by Antti Koivisto.
Source/WebCore:
The bug was caused by canHaveUserAgentShadowRoot() returning false on a meter element since it's disabled on iOS.
Override HTMLUnknownElement's canHaveUserAgentShadowRoot to return false for compatbility on iOS.
- html/HTMLUnknownElement.h:
(WebCore::HTMLUnknownElement::canHaveUserAgentShadowRoot):
LayoutTests:
Enable shadow DOM and custom elements tests on iOS; matches that's in platform/mac/TestExpectations.
- platform/ios-simulator/TestExpectations:
- 4:01 PM Changeset in webkit [195862] by
-
- 18 edits in trunk/Source/JavaScriptCore
Remove our notion of having a single activation register
https://bugs.webkit.org/show_bug.cgi?id=153673
Reviewed by Filip Pizlo.
We have many functions lurking around where we think a function
might only have one activation register. This is clearly wrong
now that ES6 has block scoping. This patch removes this false notion.
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::dumpBytecode):
(JSC::CodeBlock::CodeBlock):
- bytecode/CodeBlock.h:
(JSC::CodeBlock::scopeRegister):
(JSC::CodeBlock::codeType):
(JSC::CodeBlock::setActivationRegister): Deleted.
(JSC::CodeBlock::activationRegister): Deleted.
(JSC::CodeBlock::uncheckedActivationRegister): Deleted.
(JSC::CodeBlock::needsActivation): Deleted.
- bytecode/ExecutableInfo.h:
(JSC::ExecutableInfo::ExecutableInfo):
(JSC::ExecutableInfo::usesEval):
(JSC::ExecutableInfo::isStrictMode):
(JSC::ExecutableInfo::isConstructor):
(JSC::ExecutableInfo::isClassContext):
(JSC::ExecutableInfo::needsActivation): Deleted.
- bytecode/UnlinkedCodeBlock.cpp:
(JSC::UnlinkedCodeBlock::UnlinkedCodeBlock):
- bytecode/UnlinkedCodeBlock.h:
(JSC::UnlinkedCodeBlock::isArrowFunctionContext):
(JSC::UnlinkedCodeBlock::isClassContext):
(JSC::UnlinkedCodeBlock::setThisRegister):
(JSC::UnlinkedCodeBlock::setScopeRegister):
(JSC::UnlinkedCodeBlock::usesGlobalObject):
(JSC::UnlinkedCodeBlock::setGlobalObjectRegister):
(JSC::UnlinkedCodeBlock::thisRegister):
(JSC::UnlinkedCodeBlock::scopeRegister):
(JSC::UnlinkedCodeBlock::addPropertyAccessInstruction):
(JSC::UnlinkedCodeBlock::needsFullScopeChain): Deleted.
(JSC::UnlinkedCodeBlock::setActivationRegister): Deleted.
(JSC::UnlinkedCodeBlock::activationRegister): Deleted.
(JSC::UnlinkedCodeBlock::hasActivationRegister): Deleted.
- bytecode/UnlinkedFunctionExecutable.cpp:
(JSC::generateUnlinkedFunctionCodeBlock):
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::BytecodeGenerator):
(JSC::BytecodeGenerator::initializeVarLexicalEnvironment):
- bytecompiler/BytecodeGenerator.h:
(JSC::BytecodeGenerator::destinationForAssignResult):
(JSC::BytecodeGenerator::leftHandSideNeedsCopy):
(JSC::BytecodeGenerator::emitNodeForLeftHandSide):
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::inliningCost):
(JSC::DFG::ByteCodeParser::parseCodeBlock):
- dfg/DFGGraph.h:
(JSC::DFG::Graph::hasExitSite):
(JSC::DFG::Graph::activationRegister): Deleted.
(JSC::DFG::Graph::uncheckedActivationRegister): Deleted.
(JSC::DFG::Graph::machineActivationRegister): Deleted.
(JSC::DFG::Graph::uncheckedMachineActivationRegister): Deleted.
- dfg/DFGStackLayoutPhase.cpp:
(JSC::DFG::StackLayoutPhase::run):
- interpreter/CallFrame.cpp:
(JSC::CallFrame::callSiteIndex):
(JSC::CallFrame::stack):
(JSC::CallFrame::callerFrame):
(JSC::CallFrame::friendlyFunctionName):
(JSC::CallFrame::hasActivation): Deleted.
(JSC::CallFrame::uncheckedActivation): Deleted.
(JSC::CallFrame::lexicalEnvironment): Deleted.
(JSC::CallFrame::lexicalEnvironmentOrNullptr): Deleted.
(JSC::CallFrame::setActivation): Deleted.
- interpreter/CallFrame.h:
(JSC::ExecState::scope):
(JSC::ExecState::setCallerFrame):
(JSC::ExecState::setScope):
(JSC::ExecState::init):
- interpreter/Register.h:
- llint/LLIntSlowPaths.cpp:
(JSC::LLInt::LLINT_SLOW_PATH_DECL):
- runtime/Executable.h:
(JSC::ScriptExecutable::usesEval):
(JSC::ScriptExecutable::usesArguments):
(JSC::ScriptExecutable::isArrowFunctionContext):
(JSC::ScriptExecutable::isStrictMode):
(JSC::ScriptExecutable::derivedContextType):
(JSC::ScriptExecutable::needsActivation): Deleted.
- runtime/JSLexicalEnvironment.h:
(JSC::asActivation):
(JSC::Register::lexicalEnvironment): Deleted.
- 3:58 PM Changeset in webkit [195861] by
-
- 2 edits in trunk/LayoutTests
Missed one rebaseline for ios-simulator after r195740 in the last patch.
Unreviewed test gardening.
- platform/ios-simulator/fast/forms/form-in-malformed-markup-expected.txt:
- 3:47 PM WindowsWithoutCygwin edited by
- Added step regarding proxy environment variables - … (diff)
- 3:45 PM Changeset in webkit [195860] by
-
- 7 edits1 delete in trunk/LayoutTests
Rebaselining tests on ios-simulator after r195740
Unreviewed test gardning.
- platform/ios-simulator-wk2/editing/inserting/paragraph-separator-in-table-1-expected.txt: Removed.
- platform/ios-simulator/compositing/contents-opaque/table-parts-expected.txt:
- platform/ios-simulator/fast/text/emoji-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/colgroup_align_center-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/colgroup_align_justify-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/colgroup_align_left-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/colgroup_align_right-expected.txt:
- 3:43 PM Changeset in webkit [195859] by
-
- 3 edits in trunk/Websites/webkit.org
Clean up the B3 documentation a bit
https://bugs.webkit.org/show_bug.cgi?id=153678
Reviewed by Saam Barati.
- docs/b3/index.html: Fix some links and fix small issues.
- docs/b3/intermediate-representation.html: Clean up some text and fix small issues.
- 3:42 PM Changeset in webkit [195858] by
-
- 1 edit in branches/safari-601-branch/Source/WebCore/platform/graphics/mac/FontCacheMac.mm
Build fix after r195857. rdar://problem/24208101.
- 3:41 PM Changeset in webkit [195857] by
-
- 1 edit in branches/safari-601-branch/Source/WebCore/platform/graphics/mac/FontCacheMac.mm
Build fix after r195847 rdar://problem/24208101.
- 3:34 PM Changeset in webkit [195856] by
-
- 2 edits in trunk/LayoutTests
Unreviewed test gardening.
- platform/mac-wk1/TestExpectations: Break out some IDB failures with better descriptions.
- 3:31 PM Changeset in webkit [195855] by
-
- 1 edit in trunk/LayoutTests/ChangeLog
Finish getting rid of those conflict markers.
- 3:30 PM Changeset in webkit [195854] by
-
- 25 edits10 deletes in tags/Safari-602.1.17.2
Merged r195795. rdar://problem/24074990
- 3:30 PM Changeset in webkit [195853] by
-
- 1 edit in trunk/LayoutTests/ChangeLog
Get rid of conflit markers added to ChangeLog in r195837
- 3:28 PM Changeset in webkit [195852] by
-
- 5 edits in tags/Safari-602.1.17.2/Source
Versioning.
- 3:27 PM Changeset in webkit [195851] by
-
- 1 copy in tags/Safari-602.1.17.2
New tag.
- 3:23 PM Changeset in webkit [195850] by
-
- 4 edits in trunk
Modern IDB: Getting records for key ranges with null keys aren't properly handled in SQLite backend
https://bugs.webkit.org/show_bug.cgi?id=153666
Reviewed by Tim Horton.
Source/WebCore:
No new tests (Two failing tests now pass).
- Modules/indexeddb/server/SQLiteIDBBackingStore.cpp:
(WebCore::IDBServer::SQLiteIDBBackingStore::getRecord):
LayoutTests:
- platform/mac-wk1/TestExpectations:
- 3:18 PM Changeset in webkit [195849] by
-
- 12 adds in branches/safari-601-branch/LayoutTests/css3
Complete the merge of the patch in rdar://problem/24190682.
- 3:15 PM Changeset in webkit [195848] by
-
- 20 edits2 adds in trunk
image-rendering: -webkit-optimize-contrast not working for background images
https://bugs.webkit.org/show_bug.cgi?id=97991
Reviewed by Darin Adler.
Source/WebCore:
Don't equate "pixelated" and "crisp-edges" values for image-rendering with low
quality scaling; they should map to InterpolationNone, not InterpolationLow.
To support this change ImageQualityController to return a InterpolationQuality
from the renamed chooseInterpolationQuality(). If the returned value is not
InterpolationDefault, set the GraphicsContext image interpolation when drawing
images and image buffers.
Remove the redundant "useLowQualityScale" from
Test: fast/images/image-rendering-interpolation.html
- html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::paint):
- html/HTMLCanvasElement.h:
- page/DragController.cpp:
(WebCore::DragController::doImageDrag):
- platform/graphics/GraphicsContext.cpp:
(WebCore::GraphicsContext::drawImage):
(WebCore::GraphicsContext::drawTiledImage):
(WebCore::GraphicsContext::drawImageBuffer):
(WebCore::GraphicsContext::drawConsumingImageBuffer):
(WebCore::InterpolationQualityMaintainer::InterpolationQualityMaintainer): Deleted.
(WebCore::InterpolationQualityMaintainer::~InterpolationQualityMaintainer): Deleted.
- platform/graphics/GraphicsContext.h:
(WebCore::ImagePaintingOptions::ImagePaintingOptions):
(WebCore::ImagePaintingOptions::usesDefaultInterpolation):
(WebCore::InterpolationQualityMaintainer::InterpolationQualityMaintainer):
(WebCore::InterpolationQualityMaintainer::~InterpolationQualityMaintainer):
- platform/graphics/GraphicsTypes.h:
- platform/graphics/ImageBuffer.h:
- platform/graphics/cg/ImageBufferCG.cpp:
(WebCore::ImageBuffer::drawConsuming):
(WebCore::ImageBuffer::draw):
- rendering/ImageQualityController.cpp:
(WebCore::ImageQualityController::interpolationQualityFromStyle):
(WebCore::ImageQualityController::chooseInterpolationQuality):
(WebCore::ImageQualityController::ImageQualityController): Deleted.
(WebCore::ImageQualityController::shouldPaintAtLowQuality): Deleted.
- rendering/ImageQualityController.h:
- rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::chooseInterpolationQuality):
(WebCore::RenderBoxModelObject::paintFillLayerExtended):
(WebCore::RenderBoxModelObject::shouldPaintAtLowQuality): Deleted.
- rendering/RenderBoxModelObject.h:
- rendering/RenderEmbeddedObject.cpp:
(WebCore::RenderEmbeddedObject::paintSnapshotImage):
- rendering/RenderHTMLCanvas.cpp:
(WebCore::RenderHTMLCanvas::paintReplaced):
- rendering/RenderImage.cpp:
(WebCore::RenderImage::paintIntoRect):
- rendering/RenderSnapshottedPlugIn.cpp:
(WebCore::RenderSnapshottedPlugIn::paintSnapshot):
- rendering/style/RenderStyle.h:
LayoutTests:
- fast/images/image-rendering-interpolation-expected.html: Added.
- fast/images/image-rendering-interpolation.html: Added.
- 3:13 PM Changeset in webkit [195847] by
-
- 1 edit in branches/safari-601-branch/Source/WebCore/platform/graphics/mac/FontCacheMac.mm
Patch for rdar://problem/24208101
- 3:12 PM Changeset in webkit [195846] by
-
- 3 edits in trunk/Source/WebInspectorUI
Web Inspector: Provide a way to clear the network panel
https://bugs.webkit.org/show_bug.cgi?id=153632
<rdar://problem/23317773>
Patch by Devin Rousso <Devin Rousso> on 2016-01-29
Reviewed by Timothy Hatcher.
Added a navigation item to the Network tab that resets the network grid's content.
- Localizations/en.lproj/localizedStrings.js:
- UserInterface/Views/NetworkGridContentView.js:
(WebInspector.NetworkGridContentView):
(WebInspector.NetworkGridContentView.prototype.get navigationItems):
(WebInspector.NetworkGridContentView.prototype._clearNetworkItems):
- 3:10 PM Changeset in webkit [195845] by
-
- 2 edits in trunk/Source/JavaScriptCore
Air:fixObviousSpills should handle floats and doubles
https://bugs.webkit.org/show_bug.cgi?id=153197
Reviewed by Saam Barati.
This adds the most obvious handling of float spills, where we just enable load elimination on
float spill code.
- b3/air/AirFixObviousSpills.cpp:
- 3:06 PM Changeset in webkit [195844] by
-
- 2 edits in trunk/Source/WebKit2
Don’t use the “.Development” suffix for engineering builds targeting iOS devices, because the XPC cache is only aware of the unsuffixed service identifiers.
Reviewed by Chris Dumez.
- Configurations/DebugRelease.xcconfig:
- 3:01 PM Changeset in webkit [195843] by
-
- 2 edits in trunk/Tools
update-webkit-dependency fails to fetch updates through firewall on Windows
https://bugs.webkit.org/show_bug.cgi?id=153619
Patch by Nikos Andronikos <nikos.andronikos-webkit@cisra.canon.com.au> on 2016-01-29
Reviewed by Myles C. Maxfield.
On Windows, when a firewall is present we need to read proxy settings
from environment variables.
This patch relies on the following environment variables being set:
HTTP_PROXY
HTTPS_PROXY
- Scripts/update-webkit-dependency:
- 2:59 PM Changeset in webkit [195842] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: WebInspector.Setting should not access localStorage if the value did not change
https://bugs.webkit.org/show_bug.cgi?id=153671
<rdar://problem/24417029>
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-01-29
Reviewed by Brian Burg.
- UserInterface/Base/Setting.js:
(WebInspector.Setting.prototype.set value):
- 2:50 PM Changeset in webkit [195841] by
-
- 1 edit4 adds1 delete in trunk/Websites/webkit.org
B3 should have documentation
https://bugs.webkit.org/show_bug.cgi?id=153658
Reviewed by Saam Barati.
Change the documentation to use HTML instead of Markdown. Markdown has trouble with
definition lists. Things go downhill when you try to add paragraphs or code blocks to
a definition. That's unfortunate since we use definitions for the IR document.
Since there is no way to use our preferred styling for the IR document without doing a
lot of bad hacks, it's best if we just stick to HTML. It looks plain but it's highly
practical.
- docs/b3/assembly-intermediate-representation.html: Added.
- docs/b3/bare-bones-backend.md: Removed.
- docs/b3/index.html: Added.
- docs/b3/intermediate-representation.html: Added.
- docs/b3/style.css: Added.
(dd):
(dd:last-child):
- 2:11 PM Changeset in webkit [195840] by
-
- 2 edits in trunk/Source/WebKit2
One more iOS build fix.
Unreviewed.
- Platform/spi/ios/UIKitSPI.h:
- 1:29 PM Changeset in webkit [195839] by
-
- 2 edits in trunk/Websites/webkit.org
Add some defintion list styles.
- wp-content/themes/webkit/style.css:
(dl):
(dt):
(dd):
- 1:22 PM Changeset in webkit [195838] by
-
- 4 edits in trunk
Modern IDB: storage/indexeddb/modern/index-3.html fails.
https://bugs.webkit.org/show_bug.cgi?id=153661
Reviewed by Tim Horton.
Source/WebCore:
No new tests (1 failing test now passes, others get closer).
When indexing a new record fails due to uniqueness constraints, remove all traces of the record.
- Modules/indexeddb/server/SQLiteIDBBackingStore.cpp:
(WebCore::IDBServer::SQLiteIDBBackingStore::createIndex):
(WebCore::IDBServer::SQLiteIDBBackingStore::updateAllIndexesForAddRecord):
(WebCore::IDBServer::SQLiteIDBBackingStore::addRecord):
LayoutTests:
- platform/mac-wk1/TestExpectations:
- 1:00 PM Changeset in webkit [195837] by
-
- 3 edits2 adds in trunk
Source/WebCore:
[WebGL] Check vertex array bounds before permitting a glDrawArrays to execute
https://bugs.webkit.org/show_bug.cgi?id=153643
<rdar://problem/23424456>
Reviewed by Dean Jackson.
Tested by fast/canvas/webgl/webgl-drawarrays-crash.html.
- html/canvas/WebGLRenderingContextBase.cpp:
(WebCore::WebGLRenderingContextBase::validateDrawArrays): Make sure that we have at
least one buffer bound to a program if a drawArray call with a non-zero range of
requested data is being made.
(WebCore::WebGLRenderingContextBase::validateDrawElements): Drive-by formatting fix.
LayoutTests:
Test to check for stack recursion when indexed propertyNames defined using Object.defineProperty are deleted.
https://bugs.webkit.org/show_bug.cgi?id=149179
<rdar://problem/22708019>.
Patch by Pranjal Jumde <pjumde@apple.com> on 2015-12-22
Reviewed by Dean Jackson.
- storage/domstorage/localstorage/delete-defineproperty-removal-expected.txt: Added.
- storage/domstorage/localstorage/delete-defineproperty-removal.html: Added.
- 12:37 PM Changeset in webkit [195836] by
-
- 3 edits in trunk/Source/JavaScriptCore
Shrink CodeBlock!
<https://webkit.org/b/153640>
Reviewed by Saam Barati.
Shrink CodeBlock by 112 bytes (from 640 to 528) by employing
these sophisticated tricks:
- Remove members that are not used by anyone.
- Don't cache both VM* and Heap* in members.
- Reorder members to minimize struct padding.
- Use RefCountedArray instead of Vector for arrays that never resize.
- Put a not-always-present HashMap in a std::unique_ptr.
This increases CodeBlock space efficiency by 20%, as we can now
fit 30 of them in a MarkedBlock, up from 25.)
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::CodeBlock):
(JSC::CodeBlock::finishCreation):
(JSC::CodeBlock::setNumParameters):
(JSC::CodeBlock::jettison):
(JSC::CodeBlock::noticeIncomingCall):
(JSC::CodeBlock::resultProfileForBytecodeOffset):
- bytecode/CodeBlock.h:
(JSC::CodeBlock::setJITCode):
(JSC::CodeBlock::capabilityLevelState):
(JSC::CodeBlock::codeType):
(JSC::CodeBlock::ensureResultProfile):
(JSC::CodeBlock::heap):
- 12:35 PM Changeset in webkit [195835] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Duplicate tab-types being saved to setting, causing duplicate tabs to be opened
https://bugs.webkit.org/show_bug.cgi?id=153659
<rdar://problem/24413157>
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-01-29
Reviewed by Brian Burg.
- UserInterface/Base/Main.js:
(WebInspector.contentLoaded):
(WebInspector._rememberOpenTabs):
De-duplicate the setting when building the list of tabs for existing
cases where the setting has duplicates and de-duplicate storing into
the setting, which was causing the issue to begin with.
- 12:30 PM WebKitGTK/Gardening/Calendar edited by
- (diff)
- 12:27 PM Changeset in webkit [195834] by
-
- 11 edits in trunk/LayoutTests
Rebaseline fast/forms tests after r195700
https://bugs.webkit.org/show_bug.cgi?id=153618
Unreviewed test gardening.
- fast/forms/date/ValidityState-rangeOverflow-date-expected.txt:
- fast/forms/date/ValidityState-rangeUnderflow-date-expected.txt:
- fast/forms/datetimelocal/ValidityState-rangeOverflow-datetimelocal-expected.txt:
- fast/forms/datetimelocal/ValidityState-rangeUnderflow-datetimelocal-expected.txt:
- fast/forms/month/ValidityState-rangeOverflow-month-expected.txt:
- fast/forms/month/ValidityState-rangeUnderflow-month-expected.txt:
- fast/forms/time/time-validity-rangeoverflow-expected.txt:
- fast/forms/time/time-validity-rangeunderflow-expected.txt:
- fast/forms/week/ValidityState-rangeOverflow-week-expected.txt:
- fast/forms/week/ValidityState-rangeUnderflow-week-expected.txt:
- 12:15 PM Changeset in webkit [195833] by
-
- 2 edits in trunk/Source/WebKit2
iOS build fix after r195826.
Unreviewed.
- Platform/spi/ios/UIKitSPI.h:
- 11:47 AM Changeset in webkit [195832] by
-
- 5 edits in trunk
Modern IDB: Fix logging that overwhelms python with strings of excessive length.
https://bugs.webkit.org/show_bug.cgi?id=153652
Reviewed by Tim Horton.
Source/WebCore:
No new tests (Two skipped tests now pass).
- Modules/indexeddb/IDBKeyData.cpp:
(WebCore::IDBKeyData::loggingString): Limit the length of the string.
- Modules/indexeddb/IDBKeyRangeData.cpp:
(WebCore::IDBKeyRangeData::loggingString): Limit the length of the string.
LayoutTests:
- platform/mac-wk1/TestExpectations:
- 11:46 AM Changeset in webkit [195831] by
-
- 24 edits3 adds in trunk
Exits from exceptions shouldn't jettison code
https://bugs.webkit.org/show_bug.cgi?id=153564
Reviewed by Geoffrey Garen.
Source/JavaScriptCore:
We create two new exit kinds for exception-handling
OSRExits:
- ExceptionCheck: an exception check after a C call.
- GenericUnwind: an OSR exit executes because it's jumped to from genericUnwind machinery.
Having these two new exit kinds allows us to remove fields from
various OSRExit variants that store booleans indicating
if the exit is an exception handler, and if so, what kind
of exception handler. Most of this patch is just removing
those old fields and adding new equivalent functions.
This patch also implements the policy that we should never consider jettisoning
code from exits that happen from an exception check to an op_catch (it might be worth
considering a similar policy for 'throw'). We're choosing this policy because
it will almost never be more expensive, in total, to execute the OSR exit than
to execute the baseline variant of the code. When an exception is thrown, we do
really expensive work, like call through to genericUnwind, and also create an error
object with a stack trace. The cost of OSR exiting here is small in comparison to
those other operations. And penalizing a CodeBlock for OSR exiting from an exception
is silly because the basis of our implementation of exception handling in the
upper tiers is to OSR exit on a caught exception. So we used to penalize
ourselves for having an implementation that is correct w.r.t our design goals.
I've verified this hypothesis with on v8-raytrace by adding a new
benchmark that throws with very high frequency. Implementing
this policy on that benchmark results in about a 4-5% speed up.
- bytecode/ExitKind.cpp:
(JSC::exitKindToString):
(JSC::exitKindMayJettison):
(JSC::exitKindIsCountable): Deleted.
- bytecode/ExitKind.h:
- dfg/DFGJITCode.cpp:
(JSC::DFG::JITCode::liveRegistersToPreserveAtExceptionHandlingCallSite):
- dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::noticeOSREntry):
(JSC::DFG::JITCompiler::appendExceptionHandlingOSRExit):
(JSC::DFG::JITCompiler::exceptionCheck):
(JSC::DFG::JITCompiler::recordCallSiteAndGenerateExceptionHandlingOSRExitIfNeeded):
- dfg/DFGJITCompiler.h:
- dfg/DFGOSRExit.cpp:
(JSC::DFG::OSRExit::OSRExit):
- dfg/DFGOSRExit.h:
(JSC::DFG::OSRExit::considerAddingAsFrequentExitSite):
- dfg/DFGOSRExitBase.h:
(JSC::DFG::OSRExitBase::OSRExitBase):
(JSC::DFG::OSRExitBase::isExceptionHandler):
(JSC::DFG::OSRExitBase::isGenericUnwindHandler):
(JSC::DFG::OSRExitBase::considerAddingAsFrequentExitSite):
- dfg/DFGOSRExitCompiler.cpp:
- dfg/DFGOSRExitCompiler32_64.cpp:
(JSC::DFG::OSRExitCompiler::compileExit):
- dfg/DFGOSRExitCompiler64.cpp:
(JSC::DFG::OSRExitCompiler::compileExit):
- dfg/DFGOSRExitCompilerCommon.cpp:
(JSC::DFG::handleExitCounts):
(JSC::DFG::osrWriteBarrier):
(JSC::DFG::adjustAndJumpToTarget):
- dfg/DFGOSRExitCompilerCommon.h:
(JSC::DFG::adjustFrameAndStackInOSRExitCompilerThunk):
- ftl/FTLCompile.cpp:
(JSC::FTL::mmAllocateDataSection):
- ftl/FTLExitThunkGenerator.cpp:
(JSC::FTL::ExitThunkGenerator::emitThunk):
- ftl/FTLJITCode.cpp:
(JSC::FTL::JITCode::liveRegistersToPreserveAtExceptionHandlingCallSite):
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::DFG::LowerDFGToLLVM::callCheck):
(JSC::FTL::DFG::LowerDFGToLLVM::appendOSRExitArgumentsForPatchpointIfWillCatchException):
(JSC::FTL::DFG::LowerDFGToLLVM::appendOSRExit):
(JSC::FTL::DFG::LowerDFGToLLVM::blessSpeculation):
- ftl/FTLOSRExit.cpp:
(JSC::FTL::OSRExitDescriptor::emitOSRExit):
(JSC::FTL::OSRExitDescriptor::emitOSRExitLater):
(JSC::FTL::OSRExitDescriptor::prepareOSRExitHandle):
(JSC::FTL::OSRExit::OSRExit):
(JSC::FTL::OSRExit::spillRegistersToSpillSlot):
(JSC::FTL::OSRExit::recoverRegistersFromSpillSlot):
(JSC::FTL::OSRExit::willArriveAtExitFromIndirectExceptionCheck):
(JSC::FTL::OSRExit::willArriveAtOSRExitFromCallOperation):
(JSC::FTL::exceptionTypeWillArriveAtOSRExitFromGenericUnwind): Deleted.
(JSC::FTL::OSRExit::willArriveAtOSRExitFromGenericUnwind): Deleted.
- ftl/FTLOSRExit.h:
- ftl/FTLOSRExitCompiler.cpp:
(JSC::FTL::compileStub):
(JSC::FTL::compileFTLOSRExit):
- ftl/FTLPatchpointExceptionHandle.cpp:
(JSC::FTL::PatchpointExceptionHandle::scheduleExitCreation):
(JSC::FTL::PatchpointExceptionHandle::scheduleExitCreationForUnwind):
(JSC::FTL::PatchpointExceptionHandle::PatchpointExceptionHandle):
(JSC::FTL::PatchpointExceptionHandle::createHandle):
- ftl/FTLPatchpointExceptionHandle.h:
LayoutTests:
- js/regress/script-tests/v8-raytrace-with-try-catch-high-frequency-throws.js: Added.
(randomException):
(Class.create):
(Object.extend):
(Flog.RayTracer.Color.prototype.initialize):
(Flog.RayTracer.Color.prototype.add):
(Flog.RayTracer.Color.prototype.addScalar):
(Flog.RayTracer.Color.prototype.subtract):
(Flog.RayTracer.Color.prototype.multiply):
(Flog.RayTracer.Color.prototype.multiplyScalar):
(Flog.RayTracer.Color.prototype.divideFactor):
(Flog.RayTracer.Color.prototype.limit):
(Flog.RayTracer.Color.prototype.distance):
(Flog.RayTracer.Color.prototype.blend):
(Flog.RayTracer.Color.prototype.brightness):
(Flog.RayTracer.Color.prototype.toString):
(Flog.RayTracer.Light.prototype.initialize):
(Flog.RayTracer.Light.prototype.toString):
(Flog.RayTracer.Vector.prototype.initialize):
(Flog.RayTracer.Vector.prototype.copy):
(Flog.RayTracer.Vector.prototype.normalize):
(Flog.RayTracer.Vector.prototype.magnitude):
(Flog.RayTracer.Vector.prototype.cross):
(Flog.RayTracer.Vector.prototype.dot):
(Flog.RayTracer.Vector.prototype.add):
(Flog.RayTracer.Vector.prototype.subtract):
(Flog.RayTracer.Vector.prototype.multiplyVector):
(Flog.RayTracer.Vector.prototype.multiplyScalar):
(Flog.RayTracer.Vector.prototype.toString):
(Flog.RayTracer.Ray.prototype.initialize):
(Flog.RayTracer.Ray.prototype.toString):
(Flog.RayTracer.Scene.prototype.initialize):
(Flog.RayTracer.Material.BaseMaterial.prototype.initialize):
(Flog.RayTracer.Material.BaseMaterial.prototype.getColor):
(Flog.RayTracer.Material.BaseMaterial.prototype.wrapUp):
(Flog.RayTracer.Material.BaseMaterial.prototype.toString):
(Flog.RayTracer.Material.Solid.prototype.Object.extend.new.Flog.RayTracer.Material.BaseMaterial.initialize):
(Flog.RayTracer.Material.Solid.prototype.Object.extend.new.Flog.RayTracer.Material.BaseMaterial.getColor):
(Flog.RayTracer.Material.Solid.prototype.Object.extend.new.Flog.RayTracer.Material.BaseMaterial.toString):
(Flog.RayTracer.Material.Solid.prototype.Object.extend.new.Flog.RayTracer.Material.BaseMaterial):
(Flog.RayTracer.Material.Chessboard.prototype.Object.extend.new.Flog.RayTracer.Material.BaseMaterial.initialize):
(Flog.RayTracer.Material.Chessboard.prototype.Object.extend.new.Flog.RayTracer.Material.BaseMaterial.getColor):
(Flog.RayTracer.Material.Chessboard.prototype.Object.extend.new.Flog.RayTracer.Material.BaseMaterial.toString):
(Flog.RayTracer.Material.Chessboard.prototype.Object.extend.new.Flog.RayTracer.Material.BaseMaterial):
(Flog.RayTracer.Shape.Sphere.prototype.initialize):
(Flog.RayTracer.Shape.Sphere.prototype.intersect):
(Flog.RayTracer.Shape.Sphere.prototype.toString):
(Flog.RayTracer.Shape.Plane.prototype.initialize):
(Flog.RayTracer.Shape.Plane.prototype.intersect):
(Flog.RayTracer.Shape.Plane.prototype.toString):
(Flog.RayTracer.IntersectionInfo.prototype.initialize):
(Flog.RayTracer.IntersectionInfo.prototype.toString):
(Flog.RayTracer.Camera.prototype.initialize):
(Flog.RayTracer.Camera.prototype.getRay):
(Flog.RayTracer.Camera.prototype.toString):
(Flog.RayTracer.Background.prototype.initialize):
(Flog.RayTracer.Engine.prototype.initialize):
(Flog.RayTracer.Engine.prototype.setPixel):
(Flog.RayTracer.Engine.prototype.renderScene):
(Flog.RayTracer.Engine.prototype.getPixelColor):
(Flog.RayTracer.Engine.prototype.testIntersection):
(Flog.RayTracer.Engine.prototype.getReflectionRay):
(Flog.RayTracer.Engine.prototype.rayTrace):
(renderScene):
- js/regress/v8-raytrace-with-try-catch-high-frequency-throws-expected.txt: Added.
- js/regress/v8-raytrace-with-try-catch-high-frequency-throws.html: Added.
- 11:19 AM Changeset in webkit [195830] by
-
- 1 edit3 adds in trunk/Websites/webkit.org
B3 should have documentation
https://bugs.webkit.org/show_bug.cgi?id=153658
Reviewed by Timothy Hatcher.
- docs: Added.
- docs/b3: Added.
- docs/b3/bare-bones-backend.md: Added.
- 11:15 AM Changeset in webkit [195829] by
-
- 3 edits in branches/safari-601.1.46-branch/Source/WebKit2
Merged r195826. rdar://problem/24337778
- 11:13 AM Changeset in webkit [195828] by
-
- 2 edits in trunk/Source/WebKit/win
Attempt to fix the Windows build after r195799
Unreviewed build fix.
- WebInspector.cpp:
(WebInspector::isJavaScriptProfilingEnabled):
(WebInspector::setJavaScriptProfilingEnabled):
- 11:12 AM Changeset in webkit [195827] by
-
- 1100 edits12 copies50 adds in trunk/LayoutTests
[GTK] Unreviewed gardening after r195740 (v2).
https://bugs.webkit.org/show_bug.cgi?id=153654
Rebaseline another 652 tests after r195740.
Unreviewed.
- platform/gtk/accessibility/table-attributes-expected.txt:
- platform/gtk/accessibility/table-cell-spans-expected.txt:
- platform/gtk/accessibility/table-cells-expected.txt:
- platform/gtk/accessibility/table-sections-expected.txt:
- platform/gtk/accessibility/table-with-rules-expected.txt:
- platform/gtk/css2.1/20110323/inline-table-002a-expected.txt:
- platform/gtk/css2.1/20110323/table-height-algorithm-023-expected.txt:
- platform/gtk/css2.1/20110323/table-height-algorithm-024-expected.txt:
- platform/gtk/css2.1/t0805-c5511-brdr-tw-00-b-expected.txt:
- platform/gtk/css2.1/t0805-c5513-brdr-bw-00-b-expected.txt:
- platform/gtk/css2.1/t0805-c5518-brdr-t-01-e-expected.png:
- platform/gtk/css2.1/t0805-c5518-brdr-t-01-e-expected.txt:
- platform/gtk/css2.1/t0805-c5519-brdr-r-01-e-expected.txt:
- platform/gtk/css2.1/t0805-c5520-brdr-b-01-e-expected.png:
- platform/gtk/css2.1/t0805-c5520-brdr-b-01-e-expected.txt:
- platform/gtk/css2.1/t0805-c5521-brdr-l-01-e-expected.txt:
- platform/gtk/css2.1/t0805-c5522-brdr-02-e-expected.txt:
- platform/gtk/css2.1/t170602-bdr-conflct-w-00-d-expected.png:
- platform/gtk/css2.1/t170602-bdr-conflct-w-00-d-expected.txt:
- platform/gtk/css2.1/t170602-bdr-conflct-w-01-d-expected.png:
- platform/gtk/css2.1/t170602-bdr-conflct-w-01-d-expected.txt:
- platform/gtk/css2.1/t170602-bdr-conflct-w-02-d-expected.png:
- platform/gtk/css2.1/t170602-bdr-conflct-w-02-d-expected.txt:
- platform/gtk/css2.1/t170602-bdr-conflct-w-03-d-expected.png:
- platform/gtk/css2.1/t170602-bdr-conflct-w-03-d-expected.txt:
- platform/gtk/css2.1/t170602-bdr-conflct-w-05-d-expected.png:
- platform/gtk/css2.1/t170602-bdr-conflct-w-05-d-expected.txt:
- platform/gtk/css2.1/t170602-bdr-conflct-w-07-d-expected.png:
- platform/gtk/css2.1/t170602-bdr-conflct-w-07-d-expected.txt:
- platform/gtk/css2.1/t170602-bdr-conflct-w-09-d-expected.png:
- platform/gtk/css2.1/t170602-bdr-conflct-w-09-d-expected.txt:
- platform/gtk/css2.1/t170602-bdr-conflct-w-10-d-expected.png:
- platform/gtk/css2.1/t170602-bdr-conflct-w-10-d-expected.txt:
- platform/gtk/css2.1/t170602-bdr-conflct-w-11-d-expected.png:
- platform/gtk/css2.1/t170602-bdr-conflct-w-11-d-expected.txt:
- platform/gtk/css2.1/t170602-bdr-conflct-w-12-d-expected.png:
- platform/gtk/css2.1/t170602-bdr-conflct-w-12-d-expected.txt:
- platform/gtk/css2.1/t170602-bdr-conflct-w-15-d-expected.png:
- platform/gtk/css2.1/t170602-bdr-conflct-w-15-d-expected.txt:
- platform/gtk/css2.1/t170602-bdr-conflct-w-19-d-expected.png:
- platform/gtk/css2.1/t170602-bdr-conflct-w-19-d-expected.txt:
- platform/gtk/css2.1/t170602-bdr-conflct-w-20-d-expected.png:
- platform/gtk/css2.1/t170602-bdr-conflct-w-20-d-expected.txt:
- platform/gtk/css2.1/t170602-bdr-conflct-w-21-d-expected.png:
- platform/gtk/css2.1/t170602-bdr-conflct-w-21-d-expected.txt:
- platform/gtk/css2.1/t170602-bdr-conflct-w-22-d-expected.png:
- platform/gtk/css2.1/t170602-bdr-conflct-w-22-d-expected.txt:
- platform/gtk/css2.1/t170602-bdr-conflct-w-23-d-expected.png:
- platform/gtk/css2.1/t170602-bdr-conflct-w-23-d-expected.txt:
- platform/gtk/css2.1/t170602-bdr-conflct-w-26-d-expected.png:
- platform/gtk/css2.1/t170602-bdr-conflct-w-26-d-expected.txt:
- platform/gtk/css2.1/t170602-bdr-conflct-w-27-d-expected.png:
- platform/gtk/css2.1/t170602-bdr-conflct-w-27-d-expected.txt:
- platform/gtk/css2.1/t170602-bdr-conflct-w-28-d-expected.png:
- platform/gtk/css2.1/t170602-bdr-conflct-w-28-d-expected.txt:
- platform/gtk/css2.1/t170602-bdr-conflct-w-29-d-expected.png:
- platform/gtk/css2.1/t170602-bdr-conflct-w-29-d-expected.txt:
- platform/gtk/css2.1/t170602-bdr-conflct-w-32-d-expected.png:
- platform/gtk/css2.1/t170602-bdr-conflct-w-32-d-expected.txt:
- platform/gtk/css2.1/t170602-bdr-conflct-w-33-d-expected.png:
- platform/gtk/css2.1/t170602-bdr-conflct-w-33-d-expected.txt:
- platform/gtk/css2.1/t170602-bdr-conflct-w-35-d-expected.png:
- platform/gtk/css2.1/t170602-bdr-conflct-w-35-d-expected.txt:
- platform/gtk/css2.1/t170602-bdr-conflct-w-36-d-expected.png:
- platform/gtk/css2.1/t170602-bdr-conflct-w-36-d-expected.txt:
- platform/gtk/css2.1/t170602-bdr-conflct-w-37-d-expected.png:
- platform/gtk/css2.1/t170602-bdr-conflct-w-37-d-expected.txt:
- platform/gtk/css2.1/t170602-bdr-conflct-w-38-d-expected.png:
- platform/gtk/css2.1/t170602-bdr-conflct-w-38-d-expected.txt:
- platform/gtk/css2.1/t170602-bdr-conflct-w-39-d-expected.png:
- platform/gtk/css2.1/t170602-bdr-conflct-w-39-d-expected.txt:
- platform/gtk/css2.1/t170602-bdr-conflct-w-40-d-expected.png:
- platform/gtk/css2.1/t170602-bdr-conflct-w-40-d-expected.txt:
- platform/gtk/css2.1/t170602-bdr-conflct-w-41-d-expected.png:
- platform/gtk/css2.1/t170602-bdr-conflct-w-41-d-expected.txt:
- platform/gtk/css2.1/t170602-bdr-conflct-w-42-d-expected.png:
- platform/gtk/css2.1/t170602-bdr-conflct-w-42-d-expected.txt:
- platform/gtk/css2.1/t170602-bdr-conflct-w-43-d-expected.png:
- platform/gtk/css2.1/t170602-bdr-conflct-w-43-d-expected.txt:
- platform/gtk/css2.1/t170602-bdr-conflct-w-45-d-expected.png:
- platform/gtk/css2.1/t170602-bdr-conflct-w-45-d-expected.txt:
- platform/gtk/css2.1/t170602-bdr-conflct-w-46-d-expected.png:
- platform/gtk/css2.1/t170602-bdr-conflct-w-46-d-expected.txt:
- platform/gtk/css2.1/t170602-bdr-conflct-w-47-d-expected.png:
- platform/gtk/css2.1/t170602-bdr-conflct-w-47-d-expected.txt:
- platform/gtk/css2.1/t170602-bdr-conflct-w-48-d-expected.png:
- platform/gtk/css2.1/t170602-bdr-conflct-w-48-d-expected.txt:
- platform/gtk/css2.1/t170602-bdr-conflct-w-49-d-expected.png:
- platform/gtk/css2.1/t170602-bdr-conflct-w-49-d-expected.txt:
- platform/gtk/css2.1/t170602-bdr-conflct-w-50-d-expected.png:
- platform/gtk/css2.1/t170602-bdr-conflct-w-50-d-expected.txt:
- platform/gtk/css2.1/t170602-bdr-conflct-w-51-d-expected.png:
- platform/gtk/css2.1/t170602-bdr-conflct-w-51-d-expected.txt:
- platform/gtk/css2.1/t170602-bdr-conflct-w-53-d-expected.png:
- platform/gtk/css2.1/t170602-bdr-conflct-w-53-d-expected.txt:
- platform/gtk/css2.1/t170602-bdr-conflct-w-55-d-expected.png:
- platform/gtk/css2.1/t170602-bdr-conflct-w-55-d-expected.txt:
- platform/gtk/css2.1/t170602-bdr-conflct-w-56-d-expected.png:
- platform/gtk/css2.1/t170602-bdr-conflct-w-56-d-expected.txt:
- platform/gtk/css2.1/t170602-bdr-conflct-w-57-d-expected.png:
- platform/gtk/css2.1/t170602-bdr-conflct-w-57-d-expected.txt:
- platform/gtk/css2.1/t170602-bdr-conflct-w-58-d-expected.png:
- platform/gtk/css2.1/t170602-bdr-conflct-w-58-d-expected.txt:
- platform/gtk/css2.1/t170602-bdr-conflct-w-60-d-expected.png:
- platform/gtk/css2.1/t170602-bdr-conflct-w-60-d-expected.txt:
- platform/gtk/css2.1/t170602-bdr-conflct-w-61-d-expected.png:
- platform/gtk/css2.1/t170602-bdr-conflct-w-61-d-expected.txt:
- platform/gtk/css2.1/t170602-bdr-conflct-w-62-d-expected.png:
- platform/gtk/css2.1/t170602-bdr-conflct-w-62-d-expected.txt:
- platform/gtk/css2.1/t170602-bdr-conflct-w-63-d-expected.png:
- platform/gtk/css2.1/t170602-bdr-conflct-w-63-d-expected.txt:
- platform/gtk/css2.1/t170602-bdr-conflct-w-66-d-expected.png:
- platform/gtk/css2.1/t170602-bdr-conflct-w-66-d-expected.txt:
- platform/gtk/css2.1/t170602-bdr-conflct-w-67-d-expected.png:
- platform/gtk/css2.1/t170602-bdr-conflct-w-67-d-expected.txt:
- platform/gtk/css2.1/t170602-bdr-conflct-w-68-d-expected.png:
- platform/gtk/css2.1/t170602-bdr-conflct-w-68-d-expected.txt:
- platform/gtk/css2.1/t170602-bdr-conflct-w-69-d-expected.png:
- platform/gtk/css2.1/t170602-bdr-conflct-w-69-d-expected.txt:
- platform/gtk/css2.1/t170602-bdr-conflct-w-72-d-expected.png:
- platform/gtk/css2.1/t170602-bdr-conflct-w-72-d-expected.txt:
- platform/gtk/css2.1/t170602-bdr-conflct-w-73-d-expected.png:
- platform/gtk/css2.1/t170602-bdr-conflct-w-73-d-expected.txt:
- platform/gtk/css2.1/t170602-bdr-conflct-w-75-d-expected.png:
- platform/gtk/css2.1/t170602-bdr-conflct-w-75-d-expected.txt:
- platform/gtk/css2.1/t170602-bdr-conflct-w-76-d-expected.png:
- platform/gtk/css2.1/t170602-bdr-conflct-w-76-d-expected.txt:
- platform/gtk/css2.1/t170602-bdr-conflct-w-77-d-expected.png:
- platform/gtk/css2.1/t170602-bdr-conflct-w-77-d-expected.txt:
- platform/gtk/css2.1/t170602-bdr-conflct-w-78-d-expected.png:
- platform/gtk/css2.1/t170602-bdr-conflct-w-78-d-expected.txt:
- platform/gtk/css2.1/t170602-bdr-conflct-w-79-d-expected.png:
- platform/gtk/css2.1/t170602-bdr-conflct-w-79-d-expected.txt:
- platform/gtk/css2.1/t170602-bdr-conflct-w-80-d-expected.png:
- platform/gtk/css2.1/t170602-bdr-conflct-w-80-d-expected.txt:
- platform/gtk/css2.1/t170602-bdr-conflct-w-81-d-expected.png:
- platform/gtk/css2.1/t170602-bdr-conflct-w-81-d-expected.txt:
- platform/gtk/css2.1/t170602-bdr-conflct-w-82-d-expected.png:
- platform/gtk/css2.1/t170602-bdr-conflct-w-82-d-expected.txt:
- platform/gtk/css2.1/t170602-bdr-conflct-w-83-d-expected.png:
- platform/gtk/css2.1/t170602-bdr-conflct-w-83-d-expected.txt:
- platform/gtk/css2.1/t170602-bdr-conflct-w-86-d-expected.png:
- platform/gtk/css2.1/t170602-bdr-conflct-w-86-d-expected.txt:
- platform/gtk/css2.1/t170602-bdr-conflct-w-87-d-expected.png:
- platform/gtk/css2.1/t170602-bdr-conflct-w-87-d-expected.txt:
- platform/gtk/css2.1/t170602-bdr-conflct-w-88-d-expected.png:
- platform/gtk/css2.1/t170602-bdr-conflct-w-88-d-expected.txt:
- platform/gtk/css2.1/t170602-bdr-conflct-w-89-d-expected.png:
- platform/gtk/css2.1/t170602-bdr-conflct-w-89-d-expected.txt:
- platform/gtk/css2.1/t170602-bdr-conflct-w-90-d-expected.png:
- platform/gtk/css2.1/t170602-bdr-conflct-w-90-d-expected.txt:
- platform/gtk/css2.1/t170602-bdr-conflct-w-91-d-expected.png:
- platform/gtk/css2.1/t170602-bdr-conflct-w-91-d-expected.txt:
- platform/gtk/css2.1/t170602-bdr-conflct-w-92-d-expected.png:
- platform/gtk/css2.1/t170602-bdr-conflct-w-92-d-expected.txt:
- platform/gtk/css2.1/t170602-bdr-conflct-w-93-d-expected.png:
- platform/gtk/css2.1/t170602-bdr-conflct-w-93-d-expected.txt:
- platform/gtk/css2.1/t170602-bdr-conflct-w-95-d-expected.png:
- platform/gtk/css2.1/t170602-bdr-conflct-w-95-d-expected.txt:
- platform/gtk/css2.1/t170602-bdr-conflct-w-96-d-expected.png:
- platform/gtk/css2.1/t170602-bdr-conflct-w-96-d-expected.txt:
- platform/gtk/css2.1/t170602-bdr-conflct-w-97-d-expected.png:
- platform/gtk/css2.1/t170602-bdr-conflct-w-97-d-expected.txt:
- platform/gtk/css2.1/t170602-bdr-conflct-w-98-d-expected.png:
- platform/gtk/css2.1/t170602-bdr-conflct-w-98-d-expected.txt:
- platform/gtk/css2.1/t170602-bdr-conflct-w-99-d-expected.png:
- platform/gtk/css2.1/t170602-bdr-conflct-w-99-d-expected.txt:
- platform/gtk/css2.1/tables/table-anonymous-objects-015-expected.png: Added.
- platform/gtk/css2.1/tables/table-anonymous-objects-015-expected.txt:
- platform/gtk/css2.1/tables/table-anonymous-objects-016-expected.png: Added.
- platform/gtk/css2.1/tables/table-anonymous-objects-016-expected.txt:
- platform/gtk/css2.1/tables/table-anonymous-objects-023-expected.png: Added.
- platform/gtk/css2.1/tables/table-anonymous-objects-023-expected.txt:
- platform/gtk/css2.1/tables/table-anonymous-objects-024-expected.png: Added.
- platform/gtk/css2.1/tables/table-anonymous-objects-024-expected.txt:
- platform/gtk/css2.1/tables/table-anonymous-objects-035-expected.png: Added.
- platform/gtk/css2.1/tables/table-anonymous-objects-035-expected.txt:
- platform/gtk/css2.1/tables/table-anonymous-objects-036-expected.png: Added.
- platform/gtk/css2.1/tables/table-anonymous-objects-036-expected.txt:
- platform/gtk/css2.1/tables/table-anonymous-objects-037-expected.png: Added.
- platform/gtk/css2.1/tables/table-anonymous-objects-037-expected.txt:
- platform/gtk/css2.1/tables/table-anonymous-objects-038-expected.png: Added.
- platform/gtk/css2.1/tables/table-anonymous-objects-038-expected.txt:
- platform/gtk/css2.1/tables/table-anonymous-objects-045-expected.png: Added.
- platform/gtk/css2.1/tables/table-anonymous-objects-045-expected.txt:
- platform/gtk/css2.1/tables/table-anonymous-objects-046-expected.png: Added.
- platform/gtk/css2.1/tables/table-anonymous-objects-046-expected.txt:
- platform/gtk/css2.1/tables/table-anonymous-objects-047-expected.png: Added.
- platform/gtk/css2.1/tables/table-anonymous-objects-047-expected.txt:
- platform/gtk/css2.1/tables/table-anonymous-objects-048-expected.png: Added.
- platform/gtk/css2.1/tables/table-anonymous-objects-048-expected.txt:
- platform/gtk/css2.1/tables/table-anonymous-objects-049-expected.png: Added.
- platform/gtk/css2.1/tables/table-anonymous-objects-049-expected.txt:
- platform/gtk/css2.1/tables/table-anonymous-objects-050-expected.png: Added.
- platform/gtk/css2.1/tables/table-anonymous-objects-050-expected.txt:
- platform/gtk/css2.1/tables/table-anonymous-objects-055-expected.png: Added.
- platform/gtk/css2.1/tables/table-anonymous-objects-055-expected.txt:
- platform/gtk/css2.1/tables/table-anonymous-objects-056-expected.png: Added.
- platform/gtk/css2.1/tables/table-anonymous-objects-056-expected.txt:
- platform/gtk/css2.1/tables/table-anonymous-objects-091-expected.png: Added.
- platform/gtk/css2.1/tables/table-anonymous-objects-091-expected.txt:
- platform/gtk/css2.1/tables/table-anonymous-objects-092-expected.png: Added.
- platform/gtk/css2.1/tables/table-anonymous-objects-092-expected.txt:
- platform/gtk/css2.1/tables/table-anonymous-objects-099-expected.png: Added.
- platform/gtk/css2.1/tables/table-anonymous-objects-099-expected.txt:
- platform/gtk/css2.1/tables/table-anonymous-objects-100-expected.png: Added.
- platform/gtk/css2.1/tables/table-anonymous-objects-100-expected.txt:
- platform/gtk/css2.1/tables/table-anonymous-objects-103-expected.png: Added.
- platform/gtk/css2.1/tables/table-anonymous-objects-103-expected.txt:
- platform/gtk/css2.1/tables/table-anonymous-objects-104-expected.png: Added.
- platform/gtk/css2.1/tables/table-anonymous-objects-104-expected.txt:
- platform/gtk/css2.1/tables/table-anonymous-objects-105-expected.png: Added.
- platform/gtk/css2.1/tables/table-anonymous-objects-105-expected.txt:
- platform/gtk/css2.1/tables/table-anonymous-objects-106-expected.png: Added.
- platform/gtk/css2.1/tables/table-anonymous-objects-106-expected.txt:
- platform/gtk/css2.1/tables/table-anonymous-objects-107-expected.png: Added.
- platform/gtk/css2.1/tables/table-anonymous-objects-107-expected.txt:
- platform/gtk/css2.1/tables/table-anonymous-objects-108-expected.png: Added.
- platform/gtk/css2.1/tables/table-anonymous-objects-108-expected.txt:
- platform/gtk/css2.1/tables/table-anonymous-objects-109-expected.png: Added.
- platform/gtk/css2.1/tables/table-anonymous-objects-109-expected.txt:
- platform/gtk/css2.1/tables/table-anonymous-objects-110-expected.png: Added.
- platform/gtk/css2.1/tables/table-anonymous-objects-110-expected.txt:
- platform/gtk/css2.1/tables/table-anonymous-objects-111-expected.png: Added.
- platform/gtk/css2.1/tables/table-anonymous-objects-111-expected.txt:
- platform/gtk/css2.1/tables/table-anonymous-objects-112-expected.png: Added.
- platform/gtk/css2.1/tables/table-anonymous-objects-112-expected.txt:
- platform/gtk/css2.1/tables/table-anonymous-objects-113-expected.png: Added.
- platform/gtk/css2.1/tables/table-anonymous-objects-113-expected.txt:
- platform/gtk/css2.1/tables/table-anonymous-objects-114-expected.png: Added.
- platform/gtk/css2.1/tables/table-anonymous-objects-114-expected.txt:
- platform/gtk/css2.1/tables/table-anonymous-objects-123-expected.png: Added.
- platform/gtk/css2.1/tables/table-anonymous-objects-123-expected.txt:
- platform/gtk/css2.1/tables/table-anonymous-objects-124-expected.png: Added.
- platform/gtk/css2.1/tables/table-anonymous-objects-124-expected.txt:
- platform/gtk/css2.1/tables/table-anonymous-objects-139-expected.png: Added.
- platform/gtk/css2.1/tables/table-anonymous-objects-139-expected.txt:
- platform/gtk/css2.1/tables/table-anonymous-objects-140-expected.png: Added.
- platform/gtk/css2.1/tables/table-anonymous-objects-140-expected.txt:
- platform/gtk/css2.1/tables/table-anonymous-objects-149-expected.png: Added.
- platform/gtk/css2.1/tables/table-anonymous-objects-149-expected.txt:
- platform/gtk/css2.1/tables/table-anonymous-objects-150-expected.png: Added.
- platform/gtk/css2.1/tables/table-anonymous-objects-150-expected.txt:
- platform/gtk/css2.1/tables/table-anonymous-objects-155-expected.png: Added.
- platform/gtk/css2.1/tables/table-anonymous-objects-155-expected.txt:
- platform/gtk/css2.1/tables/table-anonymous-objects-156-expected.png: Added.
- platform/gtk/css2.1/tables/table-anonymous-objects-156-expected.txt:
- platform/gtk/css2.1/tables/table-anonymous-objects-159-expected.png: Added.
- platform/gtk/css2.1/tables/table-anonymous-objects-159-expected.txt:
- platform/gtk/css2.1/tables/table-anonymous-objects-160-expected.png: Added.
- platform/gtk/css2.1/tables/table-anonymous-objects-160-expected.txt:
- platform/gtk/css2.1/tables/table-anonymous-objects-165-expected.png: Added.
- platform/gtk/css2.1/tables/table-anonymous-objects-165-expected.txt:
- platform/gtk/css2.1/tables/table-anonymous-objects-166-expected.png: Added.
- platform/gtk/css2.1/tables/table-anonymous-objects-166-expected.txt:
- platform/gtk/css2.1/tables/table-anonymous-objects-207-expected.png: Added.
- platform/gtk/css2.1/tables/table-anonymous-objects-207-expected.txt:
- platform/gtk/css2.1/tables/table-anonymous-objects-208-expected.png: Added.
- platform/gtk/css2.1/tables/table-anonymous-objects-208-expected.txt:
- platform/gtk/css3/flexbox/flexbox-baseline-expected.txt:
- platform/gtk/css3/selectors3/html/css3-modsel-161-expected.png:
- platform/gtk/css3/selectors3/html/css3-modsel-161-expected.txt:
- platform/gtk/css3/selectors3/html/css3-modsel-18b-expected.txt:
- platform/gtk/css3/selectors3/html/css3-modsel-28-expected.png:
- platform/gtk/css3/selectors3/html/css3-modsel-28-expected.txt:
- platform/gtk/css3/selectors3/html/css3-modsel-28b-expected.png:
- platform/gtk/css3/selectors3/html/css3-modsel-28b-expected.txt:
- platform/gtk/css3/selectors3/html/css3-modsel-32-expected.png:
- platform/gtk/css3/selectors3/html/css3-modsel-32-expected.txt:
- platform/gtk/css3/selectors3/html/css3-modsel-43-expected.txt:
- platform/gtk/css3/selectors3/html/css3-modsel-43b-expected.txt:
- platform/gtk/css3/selectors3/html/css3-modsel-44-expected.txt:
- platform/gtk/css3/selectors3/html/css3-modsel-44b-expected.txt:
- platform/gtk/css3/selectors3/html/css3-modsel-74-expected.png:
- platform/gtk/css3/selectors3/html/css3-modsel-74-expected.txt:
- platform/gtk/css3/selectors3/html/css3-modsel-74b-expected.png:
- platform/gtk/css3/selectors3/html/css3-modsel-74b-expected.txt:
- platform/gtk/css3/selectors3/html/css3-modsel-78-expected.png:
- platform/gtk/css3/selectors3/html/css3-modsel-78-expected.txt:
- platform/gtk/css3/selectors3/html/css3-modsel-78b-expected.png:
- platform/gtk/css3/selectors3/html/css3-modsel-78b-expected.txt:
- platform/gtk/css3/selectors3/xhtml/css3-modsel-161-expected.png:
- platform/gtk/css3/selectors3/xhtml/css3-modsel-161-expected.txt:
- platform/gtk/css3/selectors3/xhtml/css3-modsel-18b-expected.txt:
- platform/gtk/css3/selectors3/xhtml/css3-modsel-28-expected.png:
- platform/gtk/css3/selectors3/xhtml/css3-modsel-28-expected.txt:
- platform/gtk/css3/selectors3/xhtml/css3-modsel-28b-expected.png:
- platform/gtk/css3/selectors3/xhtml/css3-modsel-28b-expected.txt:
- platform/gtk/css3/selectors3/xhtml/css3-modsel-32-expected.png:
- platform/gtk/css3/selectors3/xhtml/css3-modsel-32-expected.txt:
- platform/gtk/css3/selectors3/xhtml/css3-modsel-43-expected.txt:
- platform/gtk/css3/selectors3/xhtml/css3-modsel-43b-expected.txt:
- platform/gtk/css3/selectors3/xhtml/css3-modsel-44-expected.txt:
- platform/gtk/css3/selectors3/xhtml/css3-modsel-44b-expected.txt:
- platform/gtk/css3/selectors3/xhtml/css3-modsel-74-expected.png:
- platform/gtk/css3/selectors3/xhtml/css3-modsel-74-expected.txt:
- platform/gtk/css3/selectors3/xhtml/css3-modsel-74b-expected.png:
- platform/gtk/css3/selectors3/xhtml/css3-modsel-74b-expected.txt:
- platform/gtk/css3/selectors3/xhtml/css3-modsel-78-expected.png:
- platform/gtk/css3/selectors3/xhtml/css3-modsel-78-expected.txt:
- platform/gtk/css3/selectors3/xhtml/css3-modsel-78b-expected.png:
- platform/gtk/css3/selectors3/xhtml/css3-modsel-78b-expected.txt:
- platform/gtk/css3/selectors3/xml/css3-modsel-161-expected.png:
- platform/gtk/css3/selectors3/xml/css3-modsel-161-expected.txt:
- platform/gtk/css3/selectors3/xml/css3-modsel-18b-expected.txt:
- platform/gtk/css3/selectors3/xml/css3-modsel-28-expected.png:
- platform/gtk/css3/selectors3/xml/css3-modsel-28-expected.txt:
- platform/gtk/css3/selectors3/xml/css3-modsel-28b-expected.png:
- platform/gtk/css3/selectors3/xml/css3-modsel-28b-expected.txt:
- platform/gtk/css3/selectors3/xml/css3-modsel-32-expected.png:
- platform/gtk/css3/selectors3/xml/css3-modsel-32-expected.txt:
- platform/gtk/css3/selectors3/xml/css3-modsel-43-expected.txt:
- platform/gtk/css3/selectors3/xml/css3-modsel-43b-expected.txt:
- platform/gtk/css3/selectors3/xml/css3-modsel-44-expected.txt:
- platform/gtk/css3/selectors3/xml/css3-modsel-44b-expected.txt:
- platform/gtk/css3/selectors3/xml/css3-modsel-74-expected.png:
- platform/gtk/css3/selectors3/xml/css3-modsel-74-expected.txt:
- platform/gtk/css3/selectors3/xml/css3-modsel-74b-expected.png:
- platform/gtk/css3/selectors3/xml/css3-modsel-74b-expected.txt:
- platform/gtk/css3/selectors3/xml/css3-modsel-78-expected.png:
- platform/gtk/css3/selectors3/xml/css3-modsel-78-expected.txt:
- platform/gtk/css3/selectors3/xml/css3-modsel-78b-expected.png:
- platform/gtk/css3/selectors3/xml/css3-modsel-78b-expected.txt:
- platform/gtk/editing/deleting/5099303-expected.png:
- platform/gtk/editing/deleting/5099303-expected.txt:
- platform/gtk/editing/deleting/5483370-expected.png:
- platform/gtk/editing/deleting/5483370-expected.txt:
- platform/gtk/editing/deleting/delete-to-select-table-expected.png:
- platform/gtk/editing/deleting/delete-to-select-table-expected.txt:
- platform/gtk/editing/deleting/table-cells-expected.png:
- platform/gtk/editing/deleting/table-cells-expected.txt:
- platform/gtk/editing/execCommand/5481523-expected.png:
- platform/gtk/editing/execCommand/5481523-expected.txt:
- platform/gtk/editing/inserting/5058163-1-expected.png:
- platform/gtk/editing/inserting/5058163-1-expected.txt:
- platform/gtk/editing/inserting/insert-paragraph-01-expected.png:
- platform/gtk/editing/inserting/insert-paragraph-01-expected.txt:
- platform/gtk/editing/inserting/insert-paragraph-02-expected.png:
- platform/gtk/editing/inserting/insert-paragraph-02-expected.txt:
- platform/gtk/editing/inserting/paragraph-separator-in-table-2-expected.png:
- platform/gtk/editing/inserting/paragraph-separator-in-table-2-expected.txt:
- platform/gtk/editing/pasteboard/5156401-1-expected.png:
- platform/gtk/editing/pasteboard/5156401-1-expected.txt:
- platform/gtk/editing/pasteboard/5387578-expected.png:
- platform/gtk/editing/pasteboard/5387578-expected.txt:
- platform/gtk/editing/selection/4818145-expected.png:
- platform/gtk/editing/selection/4818145-expected.txt:
- platform/gtk/editing/selection/4889598-expected.png:
- platform/gtk/editing/selection/4889598-expected.txt:
- platform/gtk/editing/selection/4895428-2-expected.png:
- platform/gtk/editing/selection/4895428-2-expected.txt:
- platform/gtk/editing/selection/5076323-1-expected.png:
- platform/gtk/editing/selection/5076323-1-expected.txt:
- platform/gtk/editing/selection/5076323-2-expected.png:
- platform/gtk/editing/selection/5076323-2-expected.txt:
- platform/gtk/editing/selection/5076323-3-expected.png:
- platform/gtk/editing/selection/5076323-3-expected.txt:
- platform/gtk/editing/selection/7152-1-expected.png:
- platform/gtk/editing/selection/7152-1-expected.txt:
- platform/gtk/editing/selection/7152-2-expected.png:
- platform/gtk/editing/selection/7152-2-expected.txt:
- platform/gtk/editing/selection/display-table-text-expected.png:
- platform/gtk/editing/selection/display-table-text-expected.txt:
- platform/gtk/editing/selection/iframe-expected.png:
- platform/gtk/editing/selection/iframe-expected.txt:
- platform/gtk/editing/selection/inline-table-expected.png:
- platform/gtk/editing/selection/inline-table-expected.txt:
- platform/gtk/editing/selection/mixed-editability-3-expected.png:
- platform/gtk/editing/selection/mixed-editability-3-expected.txt:
- platform/gtk/editing/selection/mixed-editability-4-expected.png:
- platform/gtk/editing/selection/mixed-editability-4-expected.txt:
- platform/gtk/editing/selection/mixed-editability-5-expected.png:
- platform/gtk/editing/selection/mixed-editability-5-expected.txt:
- platform/gtk/editing/selection/mixed-editability-8-expected.png:
- platform/gtk/editing/selection/mixed-editability-8-expected.txt:
- platform/gtk/editing/selection/mixed-editability-9-expected.png:
- platform/gtk/editing/selection/mixed-editability-9-expected.txt:
- platform/gtk/editing/selection/table-caret-1-expected.png:
- platform/gtk/editing/selection/table-caret-1-expected.txt:
- platform/gtk/editing/selection/table-caret-2-expected.png:
- platform/gtk/editing/selection/table-caret-2-expected.txt:
- platform/gtk/editing/selection/table-caret-3-expected.png:
- platform/gtk/editing/selection/table-caret-3-expected.txt:
- platform/gtk/editing/style/5017613-1-expected.png:
- platform/gtk/editing/style/5017613-1-expected.txt:
- platform/gtk/editing/style/5017613-2-expected.png:
- platform/gtk/editing/style/5017613-2-expected.txt:
- platform/gtk/editing/style/apple-style-editable-mix-expected.png:
- platform/gtk/editing/style/apple-style-editable-mix-expected.txt:
- platform/gtk/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.png:
- platform/gtk/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.txt:
- platform/gtk/fast/block/float/011-expected.txt:
- platform/gtk/fast/block/margin-collapse/001-expected.txt:
- platform/gtk/fast/block/margin-collapse/005-expected.txt:
- platform/gtk/fast/block/margin-collapse/104-expected.txt:
- platform/gtk/fast/block/margin-collapse/block-inside-inline/001-expected.txt:
- platform/gtk/fast/block/margin-collapse/block-inside-inline/005-expected.txt:
- platform/gtk/fast/block/positioning/053-expected.txt:
- platform/gtk/fast/borders/bidi-009a-expected.png:
- platform/gtk/fast/borders/bidi-009a-expected.txt:
- platform/gtk/fast/box-shadow/basic-shadows-expected.png:
- platform/gtk/fast/box-shadow/basic-shadows-expected.txt:
- platform/gtk/fast/css-generated-content/015-expected.txt:
- platform/gtk/fast/css-generated-content/inline-display-types-expected.txt:
- platform/gtk/fast/css-generated-content/table-before-after-child-add-expected.txt:
- platform/gtk/fast/css-generated-content/table-cell-before-content-expected.txt:
- platform/gtk/fast/css-generated-content/table-row-before-after-child-add-expected.txt:
- platform/gtk/fast/css-generated-content/table-row-before-after-expected.txt:
- platform/gtk/fast/css-generated-content/table-table-before-after-child-add-expected.txt:
- platform/gtk/fast/css/first-letter-float-expected.png:
- platform/gtk/fast/css/first-letter-float-expected.txt:
- platform/gtk/fast/css/layerZOrderCrash-expected.txt:
- platform/gtk/fast/dom/HTMLTableColElement/resize-table-using-col-width-expected.png:
- platform/gtk/fast/dom/HTMLTableColElement/resize-table-using-col-width-expected.txt:
- platform/gtk/fast/dynamic/007-expected.txt:
- platform/gtk/fast/dynamic/014-expected.txt:
- platform/gtk/fast/dynamic/015-expected.png:
- platform/gtk/fast/dynamic/015-expected.txt:
- platform/gtk/fast/dynamic/create-renderer-for-whitespace-only-text-expected.png:
- platform/gtk/fast/dynamic/create-renderer-for-whitespace-only-text-expected.txt:
- platform/gtk/fast/forms/button-white-space-expected.png:
- platform/gtk/fast/forms/button-white-space-expected.txt:
- platform/gtk/fast/forms/file/file-input-direction-expected.png:
- platform/gtk/fast/forms/file/file-input-direction-expected.txt:
- platform/gtk/fast/forms/form-added-to-table-expected.png:
- platform/gtk/fast/forms/form-added-to-table-expected.txt:
- platform/gtk/fast/forms/input-double-click-selection-gap-bug-expected.png:
- platform/gtk/fast/forms/input-double-click-selection-gap-bug-expected.txt:
- platform/gtk/fast/forms/input-value-expected.png:
- platform/gtk/fast/forms/input-value-expected.txt:
- platform/gtk/fast/invalid/table-inside-stray-table-content-expected.png:
- platform/gtk/fast/invalid/table-inside-stray-table-content-expected.txt:
- platform/gtk/fast/invalid/td-inside-object-expected.txt:
- platform/gtk/fast/lists/ordered-list-with-no-ol-tag-expected.png:
- platform/gtk/fast/lists/ordered-list-with-no-ol-tag-expected.txt:
- platform/gtk/fast/overflow/overflow-auto-table-expected.txt:
- platform/gtk/fast/replaced/width100percent-button-expected.png:
- platform/gtk/fast/replaced/width100percent-button-expected.txt:
- platform/gtk/fast/ruby/ruby-inline-table-expected.txt:
- platform/gtk/fast/selectors/018-expected.png:
- platform/gtk/fast/selectors/018-expected.txt:
- platform/gtk/fast/selectors/018b-expected.txt:
- platform/gtk/fast/selectors/032-expected.png:
- platform/gtk/fast/selectors/032-expected.txt:
- platform/gtk/fast/selectors/043-expected.txt:
- platform/gtk/fast/selectors/043b-expected.txt:
- platform/gtk/fast/selectors/044-expected.txt:
- platform/gtk/fast/selectors/044b-expected.txt:
- platform/gtk/fast/selectors/078b-expected.png:
- platform/gtk/fast/selectors/078b-expected.txt:
- platform/gtk/fast/sub-pixel/selection/selection-rect-in-sub-pixel-table-expected.txt:
- platform/gtk/fast/table/001-expected.txt:
- platform/gtk/fast/table/004-expected.png:
- platform/gtk/fast/table/004-expected.txt:
- platform/gtk/fast/table/006-expected.png:
- platform/gtk/fast/table/006-expected.txt:
- platform/gtk/fast/table/010-expected.txt:
- platform/gtk/fast/table/011-expected.png:
- platform/gtk/fast/table/011-expected.txt:
- platform/gtk/fast/table/015-expected.txt:
- platform/gtk/fast/table/016-expected.txt:
- platform/gtk/fast/table/022-expected.png:
- platform/gtk/fast/table/022-expected.txt:
- platform/gtk/fast/table/026-expected.txt:
- platform/gtk/fast/table/033-expected.txt:
- platform/gtk/fast/table/035-expected.png:
- platform/gtk/fast/table/035-expected.txt:
- platform/gtk/fast/table/035-vertical-expected.png:
- platform/gtk/fast/table/035-vertical-expected.txt:
- platform/gtk/fast/table/037-expected.txt:
- platform/gtk/fast/table/041-expected.png:
- platform/gtk/fast/table/041-expected.txt:
- platform/gtk/fast/table/auto-with-percent-height-expected.txt:
- platform/gtk/fast/table/auto-with-percent-height-vertical-expected.txt:
- platform/gtk/fast/table/cell-coalescing-expected.txt:
- platform/gtk/fast/table/cellindex-expected.txt:
- platform/gtk/fast/table/click-near-anonymous-table-expected.png:
- platform/gtk/fast/table/click-near-anonymous-table-expected.txt:
- platform/gtk/fast/table/colgroup-preceded-by-caption-expected.txt:
- platform/gtk/fast/table/colgroup-spanning-groups-rules-expected.txt:
- platform/gtk/fast/table/dynamic-descendant-percentage-height-expected.txt:
- platform/gtk/fast/table/floating-th-expected.txt:
- platform/gtk/fast/table/generated-caption-expected.png:
- platform/gtk/fast/table/generated-caption-expected.txt:
- platform/gtk/fast/table/insert-before-anonymous-ancestors-expected.png:
- platform/gtk/fast/table/insert-before-anonymous-ancestors-expected.txt:
- platform/gtk/fast/table/insert-cell-before-form-expected.png:
- platform/gtk/fast/table/insert-cell-before-form-expected.txt:
- platform/gtk/fast/table/insert-row-before-form-expected.png:
- platform/gtk/fast/table/insert-row-before-form-expected.txt:
- platform/gtk/fast/table/nested-percent-height-table-expected.png:
- platform/gtk/fast/table/nested-percent-height-table-expected.txt:
- platform/gtk/fast/table/quote-text-around-iframe-expected.png:
- platform/gtk/fast/table/quote-text-around-iframe-expected.txt:
- platform/gtk/fast/table/rowindex-expected.png:
- platform/gtk/fast/table/rowindex-expected.txt:
- platform/gtk/fast/table/rtl-cell-display-none-assert-expected.png:
- platform/gtk/fast/table/rtl-cell-display-none-assert-expected.txt:
- platform/gtk/fast/table/rules-attr-dynchange1-expected.txt:
- platform/gtk/fast/table/rules-attr-dynchange2-expected.txt:
- platform/gtk/fast/table/table-after-child-in-table-expected.txt:
- platform/gtk/fast/table/table-and-parts-outline-expected.png:
- platform/gtk/fast/table/table-and-parts-outline-expected.txt:
- platform/gtk/fast/table/table-before-child-in-table-expected.txt:
- platform/gtk/fast/table/table-cell-after-child-in-block-expected.txt:
- platform/gtk/fast/table/table-cell-after-child-in-table-expected.txt:
- platform/gtk/fast/table/table-cell-before-child-in-block-expected.txt:
- platform/gtk/fast/table/table-continuation-outline-paint-crash-expected.txt:
- platform/gtk/fast/table/table-hspace-align-center-expected.png:
- platform/gtk/fast/table/table-hspace-align-center-expected.txt:
- platform/gtk/fast/table/table-row-after-child-in-block-expected.txt:
- platform/gtk/fast/table/table-row-after-child-in-table-expected.txt:
- platform/gtk/fast/table/table-row-before-child-in-block-expected.txt:
- platform/gtk/fast/table/table-row-before-child-in-table-expected.txt:
- platform/gtk/fast/table/tableInsideCaption-expected.png:
- platform/gtk/fast/table/tableInsideCaption-expected.txt:
- platform/gtk/fast/table/text-field-baseline-expected.png:
- platform/gtk/fast/table/text-field-baseline-expected.txt:
- platform/gtk/fast/table/unbreakable-images-quirk-expected.png:
- platform/gtk/fast/table/unbreakable-images-quirk-expected.txt:
- platform/gtk/fast/table/vertical-align-baseline-expected.png:
- platform/gtk/fast/table/vertical-align-baseline-expected.txt:
- platform/gtk/fast/text/atsui-multiple-renderers-expected.png:
- platform/gtk/fast/text/atsui-multiple-renderers-expected.txt:
- platform/gtk/fast/text/basic/001-expected.png:
- platform/gtk/fast/text/basic/001-expected.txt:
- platform/gtk/fast/text/basic/006-expected.png:
- platform/gtk/fast/text/basic/006-expected.txt:
- platform/gtk/fast/text/basic/007-expected.png:
- platform/gtk/fast/text/basic/007-expected.txt:
- platform/gtk/fast/text/capitalize-boundaries-expected.png:
- platform/gtk/fast/text/capitalize-boundaries-expected.txt:
- platform/gtk/fast/text/international/bidi-layout-across-linebreak-expected.png:
- platform/gtk/fast/text/international/bidi-layout-across-linebreak-expected.txt:
- platform/gtk/fast/text/textIteratorNilRenderer-expected.png:
- platform/gtk/fast/text/textIteratorNilRenderer-expected.txt:
- platform/gtk/fast/text/whitespace/024-expected.png:
- platform/gtk/fast/text/whitespace/024-expected.txt:
- platform/gtk/fast/text/whitespace/027-expected.png:
- platform/gtk/fast/text/whitespace/027-expected.txt:
- platform/gtk/fast/text/word-break-expected.png:
- platform/gtk/fast/text/word-break-expected.txt:
- platform/gtk/fast/transforms/transform-table-row-expected.png:
- platform/gtk/fast/transforms/transform-table-row-expected.txt:
- platform/gtk/http/tests/misc/generated-content-inside-table-expected.txt:
- platform/gtk/svg/as-background-image/background-image-preserveaspectRatio-support-expected.png:
- platform/gtk/svg/as-background-image/background-image-preserveaspectRatio-support-expected.txt:
- platform/gtk/svg/as-image/img-preserveAspectRatio-support-1-expected.png:
- platform/gtk/svg/as-image/img-preserveAspectRatio-support-1-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug10036-expected.png:
- platform/gtk/tables/mozilla/bugs/bug10036-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug10269-1-expected.png: Copied from LayoutTests/platform/gtk/tables/mozilla/bugs/bug21918-expected.png.
- platform/gtk/tables/mozilla/bugs/bug10269-1-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug10269-2-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug10296-2-expected.png: Copied from LayoutTests/platform/gtk/tables/mozilla/bugs/bug12384-expected.png.
- platform/gtk/tables/mozilla/bugs/bug10296-2-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug103533-expected.png: Added.
- platform/gtk/tables/mozilla/bugs/bug103533-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug106158-1-expected.png:
- platform/gtk/tables/mozilla/bugs/bug106158-1-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug108340-expected.png:
- platform/gtk/tables/mozilla/bugs/bug108340-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug110566-expected.png:
- platform/gtk/tables/mozilla/bugs/bug110566-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug11321-expected.png: Copied from LayoutTests/platform/gtk/tables/mozilla_expected_failures/bugs/bug106336-expected.png.
- platform/gtk/tables/mozilla/bugs/bug11321-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug113235-3-expected.png:
- platform/gtk/tables/mozilla/bugs/bug113235-3-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug11944-expected.png:
- platform/gtk/tables/mozilla/bugs/bug11944-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug119786-expected.png:
- platform/gtk/tables/mozilla/bugs/bug119786-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug12384-expected.png:
- platform/gtk/tables/mozilla/bugs/bug12384-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug1261-expected.png:
- platform/gtk/tables/mozilla/bugs/bug1261-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug13105-expected.png: Added.
- platform/gtk/tables/mozilla/bugs/bug13105-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug13118-expected.png:
- platform/gtk/tables/mozilla/bugs/bug13118-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug133756-1-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug133756-2-expected.png:
- platform/gtk/tables/mozilla/bugs/bug133756-2-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug13484-expected.png:
- platform/gtk/tables/mozilla/bugs/bug13484-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug13526-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug138725-expected.png:
- platform/gtk/tables/mozilla/bugs/bug138725-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug14159-3-expected.png: Added.
- platform/gtk/tables/mozilla/bugs/bug14159-3-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug149275-2-expected.png:
- platform/gtk/tables/mozilla/bugs/bug149275-2-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug17130-1-expected.png:
- platform/gtk/tables/mozilla/bugs/bug17130-1-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug1828-expected.png:
- platform/gtk/tables/mozilla/bugs/bug1828-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug18359-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug18558-expected.png:
- platform/gtk/tables/mozilla/bugs/bug18558-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug2050-expected.png:
- platform/gtk/tables/mozilla/bugs/bug2050-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug20579-expected.png:
- platform/gtk/tables/mozilla/bugs/bug20579-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug21299-expected.png:
- platform/gtk/tables/mozilla/bugs/bug21299-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug21918-expected.png:
- platform/gtk/tables/mozilla/bugs/bug21918-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug221784-1-expected.png:
- platform/gtk/tables/mozilla/bugs/bug221784-1-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug221784-2-expected.png:
- platform/gtk/tables/mozilla/bugs/bug221784-2-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug2267-expected.png:
- platform/gtk/tables/mozilla/bugs/bug2267-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug23072-expected.png: Copied from LayoutTests/platform/gtk/tables/mozilla/bugs/bug12384-expected.png.
- platform/gtk/tables/mozilla/bugs/bug23072-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug23151-expected.png:
- platform/gtk/tables/mozilla/bugs/bug23151-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug23299-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug24503-expected.png:
- platform/gtk/tables/mozilla/bugs/bug24503-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug24627-expected.png:
- platform/gtk/tables/mozilla/bugs/bug24627-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug2469-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug2479-1-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug24880-expected.png:
- platform/gtk/tables/mozilla/bugs/bug24880-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug25086-expected.png:
- platform/gtk/tables/mozilla/bugs/bug25086-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug2516-expected.png:
- platform/gtk/tables/mozilla/bugs/bug2516-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug25367-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug2585-expected.png:
- platform/gtk/tables/mozilla/bugs/bug2585-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug26178-expected.png:
- platform/gtk/tables/mozilla/bugs/bug26178-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug27038-1-expected.png:
- platform/gtk/tables/mozilla/bugs/bug27038-1-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug27038-2-expected.png:
- platform/gtk/tables/mozilla/bugs/bug27038-2-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug275625-expected.png: Copied from LayoutTests/platform/gtk/tables/mozilla/bugs/bug55545-expected.png.
- platform/gtk/tables/mozilla/bugs/bug275625-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug2757-expected.png:
- platform/gtk/tables/mozilla/bugs/bug2757-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug278266-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug278385-expected.png:
- platform/gtk/tables/mozilla/bugs/bug278385-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug2886-2-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug28928-expected.png:
- platform/gtk/tables/mozilla/bugs/bug28928-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug29157-expected.png:
- platform/gtk/tables/mozilla/bugs/bug29157-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug2973-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug3037-1-expected.png: Copied from LayoutTests/platform/gtk/tables/mozilla/bugs/bug3309-2-expected.png.
- platform/gtk/tables/mozilla/bugs/bug3037-1-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug3037-2-expected.png: Copied from LayoutTests/platform/gtk/tables/mozilla/bugs/bug221784-2-expected.png.
- platform/gtk/tables/mozilla/bugs/bug3037-2-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug30418-expected.png:
- platform/gtk/tables/mozilla/bugs/bug30418-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug30985-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug3191-expected.png:
- platform/gtk/tables/mozilla/bugs/bug3191-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug32205-2-expected.png:
- platform/gtk/tables/mozilla/bugs/bug32205-2-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug32205-5-expected.png:
- platform/gtk/tables/mozilla/bugs/bug32205-5-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug32447-expected.png: Copied from LayoutTests/platform/gtk/tables/mozilla/bugs/bug3309-2-expected.png.
- platform/gtk/tables/mozilla/bugs/bug32447-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug3263-expected.png:
- platform/gtk/tables/mozilla/bugs/bug3263-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug3309-2-expected.png:
- platform/gtk/tables/mozilla/bugs/bug3309-2-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug34538-expected.png: Copied from LayoutTests/platform/gtk/tables/mozilla/bugs/bug3309-2-expected.png.
- platform/gtk/tables/mozilla/bugs/bug34538-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug35662-expected.png:
- platform/gtk/tables/mozilla/bugs/bug35662-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug3718-expected.png:
- platform/gtk/tables/mozilla/bugs/bug3718-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug39209-expected.png:
- platform/gtk/tables/mozilla/bugs/bug39209-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug40828-expected.png:
- platform/gtk/tables/mozilla/bugs/bug40828-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug4284-expected.png:
- platform/gtk/tables/mozilla/bugs/bug4284-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug4429-expected.png:
- platform/gtk/tables/mozilla/bugs/bug4429-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug44523-expected.png:
- platform/gtk/tables/mozilla/bugs/bug44523-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug45055-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug4520-expected.png:
- platform/gtk/tables/mozilla/bugs/bug4520-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug46268-3-expected.png:
- platform/gtk/tables/mozilla/bugs/bug46268-3-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug46268-5-expected.png:
- platform/gtk/tables/mozilla/bugs/bug46268-5-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug46268-expected.png:
- platform/gtk/tables/mozilla/bugs/bug46268-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug46480-1-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug46480-2-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug4739-expected.png:
- platform/gtk/tables/mozilla/bugs/bug4739-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug48028-1-expected.png:
- platform/gtk/tables/mozilla/bugs/bug48028-1-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug48028-2-expected.png:
- platform/gtk/tables/mozilla/bugs/bug48028-2-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug51037-expected.png:
- platform/gtk/tables/mozilla/bugs/bug51037-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug51140-expected.png:
- platform/gtk/tables/mozilla/bugs/bug51140-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug55527-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug55545-expected.png:
- platform/gtk/tables/mozilla/bugs/bug55545-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug55694-expected.png:
- platform/gtk/tables/mozilla/bugs/bug55694-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug56405-expected.png: Copied from LayoutTests/platform/gtk/tables/mozilla/bugs/bug3309-2-expected.png.
- platform/gtk/tables/mozilla/bugs/bug56405-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug57300-expected.png:
- platform/gtk/tables/mozilla/bugs/bug57300-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug57378-expected.png:
- platform/gtk/tables/mozilla/bugs/bug57378-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug57828-expected.png:
- platform/gtk/tables/mozilla/bugs/bug57828-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug5798-expected.png:
- platform/gtk/tables/mozilla/bugs/bug5798-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug5799-expected.png:
- platform/gtk/tables/mozilla/bugs/bug5799-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug5838-expected.png:
- platform/gtk/tables/mozilla/bugs/bug5838-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug58402-1-expected.png:
- platform/gtk/tables/mozilla/bugs/bug58402-1-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug60013-expected.png:
- platform/gtk/tables/mozilla/bugs/bug60013-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug60749-expected.png:
- platform/gtk/tables/mozilla/bugs/bug60749-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug60992-expected.png:
- platform/gtk/tables/mozilla/bugs/bug60992-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug63785-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug650-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug67864-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug67915-1-expected.png:
- platform/gtk/tables/mozilla/bugs/bug67915-1-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug69187-expected.png:
- platform/gtk/tables/mozilla/bugs/bug69187-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug709-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug7112-1-expected.png:
- platform/gtk/tables/mozilla/bugs/bug7112-1-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug7112-2-expected.png:
- platform/gtk/tables/mozilla/bugs/bug7112-2-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug75250-expected.png: Added.
- platform/gtk/tables/mozilla/bugs/bug75250-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug8032-1-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug82946-1-expected.png:
- platform/gtk/tables/mozilla/bugs/bug82946-1-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug8361-expected.png: Copied from LayoutTests/platform/gtk/tables/mozilla/bugs/bug3309-2-expected.png.
- platform/gtk/tables/mozilla/bugs/bug8361-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug83786-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug8381-expected.png:
- platform/gtk/tables/mozilla/bugs/bug8381-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug9072-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug9271-1-expected.png:
- platform/gtk/tables/mozilla/bugs/bug9271-1-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug93363-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug96343-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug965-expected.png:
- platform/gtk/tables/mozilla/bugs/bug965-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug97138-expected.png:
- platform/gtk/tables/mozilla/bugs/bug97138-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug99923-expected.png:
- platform/gtk/tables/mozilla/bugs/bug99923-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug99948-expected.png:
- platform/gtk/tables/mozilla/bugs/bug99948-expected.txt:
- platform/gtk/tables/mozilla/collapsing_borders/bug127040-expected.txt:
- platform/gtk/tables/mozilla/collapsing_borders/bug41262-4-expected.png:
- platform/gtk/tables/mozilla/collapsing_borders/bug41262-4-expected.txt:
- platform/gtk/tables/mozilla/core/captions-expected.png:
- platform/gtk/tables/mozilla/core/captions-expected.txt:
- platform/gtk/tables/mozilla/core/col_widths_auto_auto-expected.png:
- platform/gtk/tables/mozilla/core/col_widths_auto_auto-expected.txt:
- platform/gtk/tables/mozilla/core/col_widths_auto_autoPer-expected.png:
- platform/gtk/tables/mozilla/core/col_widths_auto_autoPer-expected.txt:
- platform/gtk/tables/mozilla/core/col_widths_fix_autoPer-expected.png:
- platform/gtk/tables/mozilla/core/col_widths_fix_autoPer-expected.txt:
- platform/gtk/tables/mozilla/core/row_span-expected.png:
- platform/gtk/tables/mozilla/core/row_span-expected.txt:
- platform/gtk/tables/mozilla/dom/appendCol2-expected.png:
- platform/gtk/tables/mozilla/dom/appendCol2-expected.txt:
- platform/gtk/tables/mozilla/dom/appendRowsExpand1-expected.png:
- platform/gtk/tables/mozilla/dom/appendRowsExpand1-expected.txt:
- platform/gtk/tables/mozilla/dom/appendTbodyExpand1-expected.png:
- platform/gtk/tables/mozilla/dom/appendTbodyExpand1-expected.txt:
- platform/gtk/tables/mozilla/dom/deleteCellsRebuild1-expected.png:
- platform/gtk/tables/mozilla/dom/deleteCellsRebuild1-expected.txt:
- platform/gtk/tables/mozilla/dom/deleteCellsShrink1-expected.png:
- platform/gtk/tables/mozilla/dom/deleteCellsShrink1-expected.txt:
- platform/gtk/tables/mozilla/dom/deleteCellsShrink2-expected.png:
- platform/gtk/tables/mozilla/dom/deleteCellsShrink2-expected.txt:
- platform/gtk/tables/mozilla/dom/deleteCol1-expected.png:
- platform/gtk/tables/mozilla/dom/deleteCol1-expected.txt:
- platform/gtk/tables/mozilla/dom/deleteCol2-expected.png:
- platform/gtk/tables/mozilla/dom/deleteCol2-expected.txt:
- platform/gtk/tables/mozilla/dom/deleteCol3-expected.png:
- platform/gtk/tables/mozilla/dom/deleteCol3-expected.txt:
- platform/gtk/tables/mozilla/dom/deleteColGroup1-expected.png:
- platform/gtk/tables/mozilla/dom/deleteColGroup1-expected.txt:
- platform/gtk/tables/mozilla/dom/deleteColGroup2-expected.png:
- platform/gtk/tables/mozilla/dom/deleteColGroup2-expected.txt:
- platform/gtk/tables/mozilla/dom/deleteRowsRebuild1-expected.png:
- platform/gtk/tables/mozilla/dom/deleteRowsRebuild1-expected.txt:
- platform/gtk/tables/mozilla/dom/deleteRowsShrink1-expected.png:
- platform/gtk/tables/mozilla/dom/deleteRowsShrink1-expected.txt:
- platform/gtk/tables/mozilla/dom/deleteTbodyExpand1-expected.png:
- platform/gtk/tables/mozilla/dom/deleteTbodyExpand1-expected.txt:
- platform/gtk/tables/mozilla/dom/deleteTbodyRebuild1-expected.png:
- platform/gtk/tables/mozilla/dom/deleteTbodyRebuild1-expected.txt:
- platform/gtk/tables/mozilla/dom/insertCellsExpand1-expected.png:
- platform/gtk/tables/mozilla/dom/insertCellsExpand1-expected.txt:
- platform/gtk/tables/mozilla/dom/insertCellsExpand2-expected.png:
- platform/gtk/tables/mozilla/dom/insertCellsExpand2-expected.txt:
- platform/gtk/tables/mozilla/dom/insertCellsRebuild1-expected.png:
- platform/gtk/tables/mozilla/dom/insertCellsRebuild1-expected.txt:
- platform/gtk/tables/mozilla/dom/insertCellsRebuild2-expected.png:
- platform/gtk/tables/mozilla/dom/insertCellsRebuild2-expected.txt:
- platform/gtk/tables/mozilla/dom/insertRowsExpand1-expected.png:
- platform/gtk/tables/mozilla/dom/insertRowsExpand1-expected.txt:
- platform/gtk/tables/mozilla/dom/insertRowsRebuild1-expected.png:
- platform/gtk/tables/mozilla/dom/insertRowsRebuild1-expected.txt:
- platform/gtk/tables/mozilla/dom/tableDom-expected.txt:
- platform/gtk/tables/mozilla/marvin/body_col-expected.png:
- platform/gtk/tables/mozilla/marvin/body_col-expected.txt:
- platform/gtk/tables/mozilla/marvin/body_tbody-expected.txt:
- platform/gtk/tables/mozilla/marvin/body_tfoot-expected.png:
- platform/gtk/tables/mozilla/marvin/body_tfoot-expected.txt:
- platform/gtk/tables/mozilla/marvin/col_span-expected.png:
- platform/gtk/tables/mozilla/marvin/col_span-expected.txt:
- platform/gtk/tables/mozilla/marvin/table_frame_border-expected.png:
- platform/gtk/tables/mozilla/marvin/table_frame_border-expected.txt:
- platform/gtk/tables/mozilla/marvin/table_frame_box-expected.png:
- platform/gtk/tables/mozilla/marvin/table_frame_box-expected.txt:
- platform/gtk/tables/mozilla/marvin/table_rules_all-expected.png:
- platform/gtk/tables/mozilla/marvin/table_rules_all-expected.txt:
- platform/gtk/tables/mozilla/marvin/table_rules_none-expected.png:
- platform/gtk/tables/mozilla/marvin/table_rules_none-expected.txt:
- platform/gtk/tables/mozilla/marvin/tables_align_center-expected.txt:
- platform/gtk/tables/mozilla/marvin/tables_align_left-expected.txt:
- platform/gtk/tables/mozilla/marvin/tables_align_right-expected.txt:
- platform/gtk/tables/mozilla/marvin/tables_border_0-expected.txt:
- platform/gtk/tables/mozilla/marvin/tables_border_1-expected.png:
- platform/gtk/tables/mozilla/marvin/tables_border_1-expected.txt:
- platform/gtk/tables/mozilla/marvin/tables_border_2-expected.png:
- platform/gtk/tables/mozilla/marvin/tables_border_2-expected.txt:
- platform/gtk/tables/mozilla/marvin/tables_border_3-expected.png:
- platform/gtk/tables/mozilla/marvin/tables_border_3-expected.txt:
- platform/gtk/tables/mozilla/marvin/tables_caption_align_bot-expected.png:
- platform/gtk/tables/mozilla/marvin/tables_caption_align_bot-expected.txt:
- platform/gtk/tables/mozilla/marvin/tables_caption_align_top-expected.png:
- platform/gtk/tables/mozilla/marvin/tables_caption_align_top-expected.txt:
- platform/gtk/tables/mozilla/marvin/tables_cellpadding-expected.png:
- platform/gtk/tables/mozilla/marvin/tables_cellpadding-expected.txt:
- platform/gtk/tables/mozilla/marvin/tables_cellspacing-expected.txt:
- platform/gtk/tables/mozilla/marvin/tables_default-expected.txt:
- platform/gtk/tables/mozilla/marvin/tables_id-expected.png:
- platform/gtk/tables/mozilla/marvin/tables_id-expected.txt:
- platform/gtk/tables/mozilla/marvin/tables_row_th_nowrap-expected.png:
- platform/gtk/tables/mozilla/marvin/tables_row_th_nowrap-expected.txt:
- platform/gtk/tables/mozilla/marvin/tables_td_align_center-expected.png:
- platform/gtk/tables/mozilla/marvin/tables_td_align_center-expected.txt:
- platform/gtk/tables/mozilla/marvin/tables_td_align_left-expected.png:
- platform/gtk/tables/mozilla/marvin/tables_td_align_left-expected.txt:
- platform/gtk/tables/mozilla/marvin/tables_td_align_right-expected.png:
- platform/gtk/tables/mozilla/marvin/tables_td_align_right-expected.txt:
- platform/gtk/tables/mozilla/marvin/tables_td_colspan-expected.png:
- platform/gtk/tables/mozilla/marvin/tables_td_colspan-expected.txt:
- platform/gtk/tables/mozilla/marvin/tables_td_height-expected.png:
- platform/gtk/tables/mozilla/marvin/tables_td_height-expected.txt:
- platform/gtk/tables/mozilla/marvin/tables_td_nowrap-expected.png:
- platform/gtk/tables/mozilla/marvin/tables_td_nowrap-expected.txt:
- platform/gtk/tables/mozilla/marvin/tables_td_rowspan-expected.png:
- platform/gtk/tables/mozilla/marvin/tables_td_rowspan-expected.txt:
- platform/gtk/tables/mozilla/marvin/tables_th_align_center-expected.png:
- platform/gtk/tables/mozilla/marvin/tables_th_align_center-expected.txt:
- platform/gtk/tables/mozilla/marvin/tables_th_align_left-expected.png:
- platform/gtk/tables/mozilla/marvin/tables_th_align_left-expected.txt:
- platform/gtk/tables/mozilla/marvin/tables_th_align_right-expected.png:
- platform/gtk/tables/mozilla/marvin/tables_th_align_right-expected.txt:
- platform/gtk/tables/mozilla/marvin/tables_th_height-expected.png:
- platform/gtk/tables/mozilla/marvin/tables_th_height-expected.txt:
- platform/gtk/tables/mozilla/marvin/tables_th_rowspan-expected.png:
- platform/gtk/tables/mozilla/marvin/tables_th_rowspan-expected.txt:
- platform/gtk/tables/mozilla/marvin/tbody_align_center-expected.png:
- platform/gtk/tables/mozilla/marvin/tbody_align_center-expected.txt:
- platform/gtk/tables/mozilla/marvin/tbody_align_char-expected.png:
- platform/gtk/tables/mozilla/marvin/tbody_align_char-expected.txt:
- platform/gtk/tables/mozilla/marvin/tbody_align_justify-expected.png:
- platform/gtk/tables/mozilla/marvin/tbody_align_justify-expected.txt:
- platform/gtk/tables/mozilla/marvin/tbody_align_left-expected.png:
- platform/gtk/tables/mozilla/marvin/tbody_align_left-expected.txt:
- platform/gtk/tables/mozilla/marvin/tbody_align_right-expected.png:
- platform/gtk/tables/mozilla/marvin/tbody_align_right-expected.txt:
- platform/gtk/tables/mozilla/marvin/tbody_char-expected.png:
- platform/gtk/tables/mozilla/marvin/tbody_char-expected.txt:
- platform/gtk/tables/mozilla/marvin/tfoot_align_center-expected.png:
- platform/gtk/tables/mozilla/marvin/tfoot_align_center-expected.txt:
- platform/gtk/tables/mozilla/marvin/tfoot_align_char-expected.png:
- platform/gtk/tables/mozilla/marvin/tfoot_align_char-expected.txt:
- platform/gtk/tables/mozilla/marvin/tfoot_align_justify-expected.png:
- platform/gtk/tables/mozilla/marvin/tfoot_align_justify-expected.txt:
- platform/gtk/tables/mozilla/marvin/tfoot_align_left-expected.png:
- platform/gtk/tables/mozilla/marvin/tfoot_align_left-expected.txt:
- platform/gtk/tables/mozilla/marvin/tfoot_align_right-expected.png:
- platform/gtk/tables/mozilla/marvin/tfoot_align_right-expected.txt:
- platform/gtk/tables/mozilla/marvin/tfoot_char-expected.png:
- platform/gtk/tables/mozilla/marvin/tfoot_char-expected.txt:
- platform/gtk/tables/mozilla/marvin/thead_align_center-expected.png:
- platform/gtk/tables/mozilla/marvin/thead_align_center-expected.txt:
- platform/gtk/tables/mozilla/marvin/thead_align_char-expected.png:
- platform/gtk/tables/mozilla/marvin/thead_align_char-expected.txt:
- platform/gtk/tables/mozilla/marvin/thead_align_justify-expected.png:
- platform/gtk/tables/mozilla/marvin/thead_align_justify-expected.txt:
- platform/gtk/tables/mozilla/marvin/thead_align_left-expected.png:
- platform/gtk/tables/mozilla/marvin/thead_align_left-expected.txt:
- platform/gtk/tables/mozilla/marvin/thead_align_right-expected.png:
- platform/gtk/tables/mozilla/marvin/thead_align_right-expected.txt:
- platform/gtk/tables/mozilla/marvin/thead_char-expected.png:
- platform/gtk/tables/mozilla/marvin/thead_char-expected.txt:
- platform/gtk/tables/mozilla/marvin/x_caption_align_bottom-expected.png:
- platform/gtk/tables/mozilla/marvin/x_caption_align_bottom-expected.txt:
- platform/gtk/tables/mozilla/marvin/x_caption_align_top-expected.png:
- platform/gtk/tables/mozilla/marvin/x_caption_align_top-expected.txt:
- platform/gtk/tables/mozilla/marvin/x_table-expected.txt:
- platform/gtk/tables/mozilla/marvin/x_table_align_center-expected.png:
- platform/gtk/tables/mozilla/marvin/x_table_align_center-expected.txt:
- platform/gtk/tables/mozilla/marvin/x_table_align_left-expected.png:
- platform/gtk/tables/mozilla/marvin/x_table_align_left-expected.txt:
- platform/gtk/tables/mozilla/marvin/x_table_align_right-expected.png:
- platform/gtk/tables/mozilla/marvin/x_table_align_right-expected.txt:
- platform/gtk/tables/mozilla/marvin/x_table_bgcolor_name-expected.png:
- platform/gtk/tables/mozilla/marvin/x_table_bgcolor_name-expected.txt:
- platform/gtk/tables/mozilla/marvin/x_table_bgcolor_rgb-expected.png:
- platform/gtk/tables/mozilla/marvin/x_table_bgcolor_rgb-expected.txt:
- platform/gtk/tables/mozilla/marvin/x_table_border-expected.png:
- platform/gtk/tables/mozilla/marvin/x_table_border-expected.txt:
- platform/gtk/tables/mozilla/marvin/x_table_border_none-expected.txt:
- platform/gtk/tables/mozilla/marvin/x_table_border_px-expected.png:
- platform/gtk/tables/mozilla/marvin/x_table_border_px-expected.txt:
- platform/gtk/tables/mozilla/marvin/x_table_cellpadding-expected.png:
- platform/gtk/tables/mozilla/marvin/x_table_cellpadding-expected.txt:
- platform/gtk/tables/mozilla/marvin/x_table_cellpadding_pct-expected.png:
- platform/gtk/tables/mozilla/marvin/x_table_cellpadding_pct-expected.txt:
- platform/gtk/tables/mozilla/marvin/x_table_cellspacing-expected.png:
- platform/gtk/tables/mozilla/marvin/x_table_cellspacing-expected.txt:
- platform/gtk/tables/mozilla/marvin/x_table_cellspacing_pct-expected.png:
- platform/gtk/tables/mozilla/marvin/x_table_cellspacing_pct-expected.txt:
- platform/gtk/tables/mozilla/marvin/x_table_frame_void-expected.txt:
- platform/gtk/tables/mozilla/marvin/x_table_rules_groups-expected.txt:
- platform/gtk/tables/mozilla/marvin/x_table_rules_none-expected.txt:
- platform/gtk/tables/mozilla/marvin/x_table_style-expected.txt:
- platform/gtk/tables/mozilla/marvin/x_tbody_align_center-expected.png:
- platform/gtk/tables/mozilla/marvin/x_tbody_align_center-expected.txt:
- platform/gtk/tables/mozilla/marvin/x_tbody_align_char-expected.png:
- platform/gtk/tables/mozilla/marvin/x_tbody_align_char-expected.txt:
- platform/gtk/tables/mozilla/marvin/x_tbody_align_left-expected.png:
- platform/gtk/tables/mozilla/marvin/x_tbody_align_left-expected.txt:
- platform/gtk/tables/mozilla/marvin/x_tbody_align_right-expected.png:
- platform/gtk/tables/mozilla/marvin/x_tbody_align_right-expected.txt:
- platform/gtk/tables/mozilla/marvin/x_tbody_class-expected.png:
- platform/gtk/tables/mozilla/marvin/x_tbody_class-expected.txt:
- platform/gtk/tables/mozilla/marvin/x_tbody_id-expected.png:
- platform/gtk/tables/mozilla/marvin/x_tbody_id-expected.txt:
- platform/gtk/tables/mozilla/marvin/x_tbody_style-expected.png:
- platform/gtk/tables/mozilla/marvin/x_tbody_style-expected.txt:
- platform/gtk/tables/mozilla/marvin/x_td_bgcolor_name-expected.png:
- platform/gtk/tables/mozilla/marvin/x_td_bgcolor_name-expected.txt:
- platform/gtk/tables/mozilla/marvin/x_td_bgcolor_rgb-expected.png:
- platform/gtk/tables/mozilla/marvin/x_td_bgcolor_rgb-expected.txt:
- platform/gtk/tables/mozilla/marvin/x_td_class-expected.png:
- platform/gtk/tables/mozilla/marvin/x_td_class-expected.txt:
- platform/gtk/tables/mozilla/marvin/x_td_colspan-expected.png:
- platform/gtk/tables/mozilla/marvin/x_td_colspan-expected.txt:
- platform/gtk/tables/mozilla/marvin/x_td_height-expected.png:
- platform/gtk/tables/mozilla/marvin/x_td_height-expected.txt:
- platform/gtk/tables/mozilla/marvin/x_td_id-expected.png:
- platform/gtk/tables/mozilla/marvin/x_td_id-expected.txt:
- platform/gtk/tables/mozilla/marvin/x_td_nowrap-expected.png:
- platform/gtk/tables/mozilla/marvin/x_td_nowrap-expected.txt:
- platform/gtk/tables/mozilla/marvin/x_td_rowspan-expected.png:
- platform/gtk/tables/mozilla/marvin/x_td_rowspan-expected.txt:
- platform/gtk/tables/mozilla/marvin/x_td_style-expected.png:
- platform/gtk/tables/mozilla/marvin/x_td_style-expected.txt:
- platform/gtk/tables/mozilla/marvin/x_tfoot_align_center-expected.png:
- platform/gtk/tables/mozilla/marvin/x_tfoot_align_center-expected.txt:
- platform/gtk/tables/mozilla/marvin/x_tfoot_align_char-expected.png:
- platform/gtk/tables/mozilla/marvin/x_tfoot_align_char-expected.txt:
- platform/gtk/tables/mozilla/marvin/x_tfoot_align_left-expected.png:
- platform/gtk/tables/mozilla/marvin/x_tfoot_align_left-expected.txt:
- platform/gtk/tables/mozilla/marvin/x_tfoot_align_right-expected.png:
- platform/gtk/tables/mozilla/marvin/x_tfoot_align_right-expected.txt:
- platform/gtk/tables/mozilla/marvin/x_tfoot_class-expected.png:
- platform/gtk/tables/mozilla/marvin/x_tfoot_class-expected.txt:
- platform/gtk/tables/mozilla/marvin/x_tfoot_id-expected.png:
- platform/gtk/tables/mozilla/marvin/x_tfoot_id-expected.txt:
- platform/gtk/tables/mozilla/marvin/x_tfoot_style-expected.png:
- platform/gtk/tables/mozilla/marvin/x_tfoot_style-expected.txt:
- platform/gtk/tables/mozilla/marvin/x_th_bgcolor_name-expected.png:
- platform/gtk/tables/mozilla/marvin/x_th_bgcolor_name-expected.txt:
- platform/gtk/tables/mozilla/marvin/x_th_bgcolor_rgb-expected.png:
- platform/gtk/tables/mozilla/marvin/x_th_bgcolor_rgb-expected.txt:
- platform/gtk/tables/mozilla/marvin/x_th_class-expected.png:
- platform/gtk/tables/mozilla/marvin/x_th_class-expected.txt:
- platform/gtk/tables/mozilla/marvin/x_th_colspan-expected.png:
- platform/gtk/tables/mozilla/marvin/x_th_colspan-expected.txt:
- platform/gtk/tables/mozilla/marvin/x_th_height-expected.png:
- platform/gtk/tables/mozilla/marvin/x_th_height-expected.txt:
- platform/gtk/tables/mozilla/marvin/x_th_id-expected.png:
- platform/gtk/tables/mozilla/marvin/x_th_id-expected.txt:
- platform/gtk/tables/mozilla/marvin/x_th_nowrap-expected.png:
- platform/gtk/tables/mozilla/marvin/x_th_nowrap-expected.txt:
- platform/gtk/tables/mozilla/marvin/x_th_style-expected.png:
- platform/gtk/tables/mozilla/marvin/x_th_style-expected.txt:
- platform/gtk/tables/mozilla/marvin/x_thead_align_center-expected.png:
- platform/gtk/tables/mozilla/marvin/x_thead_align_center-expected.txt:
- platform/gtk/tables/mozilla/marvin/x_thead_align_char-expected.png:
- platform/gtk/tables/mozilla/marvin/x_thead_align_char-expected.txt:
- platform/gtk/tables/mozilla/marvin/x_thead_align_left-expected.png:
- platform/gtk/tables/mozilla/marvin/x_thead_align_left-expected.txt:
- platform/gtk/tables/mozilla/marvin/x_thead_align_right-expected.png:
- platform/gtk/tables/mozilla/marvin/x_thead_align_right-expected.txt:
- platform/gtk/tables/mozilla/marvin/x_thead_class-expected.png:
- platform/gtk/tables/mozilla/marvin/x_thead_class-expected.txt:
- platform/gtk/tables/mozilla/marvin/x_thead_id-expected.png:
- platform/gtk/tables/mozilla/marvin/x_thead_id-expected.txt:
- platform/gtk/tables/mozilla/marvin/x_thead_style-expected.png:
- platform/gtk/tables/mozilla/marvin/x_thead_style-expected.txt:
- platform/gtk/tables/mozilla/marvin/x_tr_bgcolor_name-expected.png:
- platform/gtk/tables/mozilla/marvin/x_tr_bgcolor_name-expected.txt:
- platform/gtk/tables/mozilla/marvin/x_tr_bgcolor_rgb-expected.png:
- platform/gtk/tables/mozilla/marvin/x_tr_bgcolor_rgb-expected.txt:
- platform/gtk/tables/mozilla/marvin/x_tr_class-expected.png:
- platform/gtk/tables/mozilla/marvin/x_tr_class-expected.txt:
- platform/gtk/tables/mozilla/marvin/x_tr_id-expected.png:
- platform/gtk/tables/mozilla/marvin/x_tr_id-expected.txt:
- platform/gtk/tables/mozilla/marvin/x_tr_style-expected.png:
- platform/gtk/tables/mozilla/marvin/x_tr_style-expected.txt:
- platform/gtk/tables/mozilla/other/body_col-expected.png:
- platform/gtk/tables/mozilla/other/body_col-expected.txt:
- platform/gtk/tables/mozilla/other/cellspacing-expected.png:
- platform/gtk/tables/mozilla/other/cellspacing-expected.txt:
- platform/gtk/tables/mozilla/other/move_row-expected.png:
- platform/gtk/tables/mozilla/other/move_row-expected.txt:
- platform/gtk/tables/mozilla/other/padding-expected.png:
- platform/gtk/tables/mozilla/other/padding-expected.txt:
- platform/gtk/tables/mozilla_expected_failures/bugs/bug10140-expected.txt:
- platform/gtk/tables/mozilla_expected_failures/bugs/bug101759-expected.png:
- platform/gtk/tables/mozilla_expected_failures/bugs/bug101759-expected.txt:
- platform/gtk/tables/mozilla_expected_failures/bugs/bug10216-expected.png:
- platform/gtk/tables/mozilla_expected_failures/bugs/bug10216-expected.txt:
- platform/gtk/tables/mozilla_expected_failures/bugs/bug104898-expected.png:
- platform/gtk/tables/mozilla_expected_failures/bugs/bug104898-expected.txt:
- platform/gtk/tables/mozilla_expected_failures/bugs/bug106336-expected.png:
- platform/gtk/tables/mozilla_expected_failures/bugs/bug106336-expected.txt:
- platform/gtk/tables/mozilla_expected_failures/bugs/bug11945-expected.png:
- platform/gtk/tables/mozilla_expected_failures/bugs/bug11945-expected.txt:
- platform/gtk/tables/mozilla_expected_failures/bugs/bug131020-3-expected.png:
- platform/gtk/tables/mozilla_expected_failures/bugs/bug131020-3-expected.txt:
- platform/gtk/tables/mozilla_expected_failures/bugs/bug178855-expected.png: Copied from LayoutTests/platform/gtk/tables/mozilla/bugs/bug12384-expected.png.
- platform/gtk/tables/mozilla_expected_failures/bugs/bug178855-expected.txt:
- platform/gtk/tables/mozilla_expected_failures/bugs/bug18770-expected.png:
- platform/gtk/tables/mozilla_expected_failures/bugs/bug18770-expected.txt:
- platform/gtk/tables/mozilla_expected_failures/bugs/bug24880-1-expected.png:
- platform/gtk/tables/mozilla_expected_failures/bugs/bug24880-1-expected.txt:
- platform/gtk/tables/mozilla_expected_failures/bugs/bug25707-expected.png:
- platform/gtk/tables/mozilla_expected_failures/bugs/bug25707-expected.txt:
- platform/gtk/tables/mozilla_expected_failures/bugs/bug3166-11-expected.txt:
- platform/gtk/tables/mozilla_expected_failures/bugs/bug3166-12-expected.txt:
- platform/gtk/tables/mozilla_expected_failures/bugs/bug3166-13-expected.txt:
- platform/gtk/tables/mozilla_expected_failures/bugs/bug3166-14-expected.png:
- platform/gtk/tables/mozilla_expected_failures/bugs/bug3166-14-expected.txt:
- platform/gtk/tables/mozilla_expected_failures/bugs/bug3166-16-expected.txt:
- platform/gtk/tables/mozilla_expected_failures/bugs/bug3166-17-expected.png:
- platform/gtk/tables/mozilla_expected_failures/bugs/bug3166-17-expected.txt:
- platform/gtk/tables/mozilla_expected_failures/bugs/bug3166-18-expected.txt:
- platform/gtk/tables/mozilla_expected_failures/bugs/bug32205-1-expected.png:
- platform/gtk/tables/mozilla_expected_failures/bugs/bug32205-1-expected.txt:
- platform/gtk/tables/mozilla_expected_failures/bugs/bug32205-4-expected.png:
- platform/gtk/tables/mozilla_expected_failures/bugs/bug32205-4-expected.txt:
- platform/gtk/tables/mozilla_expected_failures/bugs/bug4294-expected.png:
- platform/gtk/tables/mozilla_expected_failures/bugs/bug4294-expected.txt:
- platform/gtk/tables/mozilla_expected_failures/bugs/bug46268-4-expected.png:
- platform/gtk/tables/mozilla_expected_failures/bugs/bug46268-4-expected.txt:
- platform/gtk/tables/mozilla_expected_failures/bugs/bug51000-expected.png:
- platform/gtk/tables/mozilla_expected_failures/bugs/bug51000-expected.txt:
- platform/gtk/tables/mozilla_expected_failures/bugs/bug58402-2-expected.png:
- platform/gtk/tables/mozilla_expected_failures/bugs/bug58402-2-expected.txt:
- platform/gtk/tables/mozilla_expected_failures/bugs/bug65372-expected.png:
- platform/gtk/tables/mozilla_expected_failures/bugs/bug65372-expected.txt:
- platform/gtk/tables/mozilla_expected_failures/bugs/bug6933-expected.png:
- platform/gtk/tables/mozilla_expected_failures/bugs/bug6933-expected.txt:
- platform/gtk/tables/mozilla_expected_failures/bugs/bug7113-expected.png:
- platform/gtk/tables/mozilla_expected_failures/bugs/bug7113-expected.txt:
- platform/gtk/tables/mozilla_expected_failures/bugs/bug73629-expected.png:
- platform/gtk/tables/mozilla_expected_failures/bugs/bug73629-expected.txt:
- platform/gtk/tables/mozilla_expected_failures/bugs/bug92647-1-expected.txt:
- platform/gtk/tables/mozilla_expected_failures/bugs/bug92868_1-expected.txt:
- platform/gtk/tables/mozilla_expected_failures/collapsing_borders/bug41262-5-expected.png:
- platform/gtk/tables/mozilla_expected_failures/collapsing_borders/bug41262-5-expected.txt:
- platform/gtk/tables/mozilla_expected_failures/collapsing_borders/bug41262-6-expected.png:
- platform/gtk/tables/mozilla_expected_failures/collapsing_borders/bug41262-6-expected.txt:
- platform/gtk/tables/mozilla_expected_failures/core/backgrounds-expected.png:
- platform/gtk/tables/mozilla_expected_failures/core/backgrounds-expected.txt:
- platform/gtk/tables/mozilla_expected_failures/core/captions3-expected.txt:
- platform/gtk/tables/mozilla_expected_failures/core/conflicts-expected.png:
- platform/gtk/tables/mozilla_expected_failures/core/conflicts-expected.txt:
- platform/gtk/tables/mozilla_expected_failures/dom/appendCells1-expected.png:
- platform/gtk/tables/mozilla_expected_failures/dom/appendCells1-expected.txt:
- platform/gtk/tables/mozilla_expected_failures/dom/appendCellsRebuild1-expected.png:
- platform/gtk/tables/mozilla_expected_failures/dom/appendCellsRebuild1-expected.txt:
- platform/gtk/tables/mozilla_expected_failures/dom/appendCol1-expected.png:
- platform/gtk/tables/mozilla_expected_failures/dom/appendCol1-expected.txt:
- platform/gtk/tables/mozilla_expected_failures/dom/insertTbodyExpand1-expected.png:
- platform/gtk/tables/mozilla_expected_failures/dom/insertTbodyExpand1-expected.txt:
- platform/gtk/tables/mozilla_expected_failures/dom/insertTbodyRebuild1-expected.png:
- platform/gtk/tables/mozilla_expected_failures/dom/insertTbodyRebuild1-expected.txt:
- platform/gtk/tables/mozilla_expected_failures/marvin/table_frame_above-expected.png:
- platform/gtk/tables/mozilla_expected_failures/marvin/table_frame_above-expected.txt:
- platform/gtk/tables/mozilla_expected_failures/marvin/table_frame_below-expected.png:
- platform/gtk/tables/mozilla_expected_failures/marvin/table_frame_below-expected.txt:
- platform/gtk/tables/mozilla_expected_failures/marvin/table_frame_hsides-expected.png:
- platform/gtk/tables/mozilla_expected_failures/marvin/table_frame_hsides-expected.txt:
- platform/gtk/tables/mozilla_expected_failures/marvin/table_frame_lhs-expected.png:
- platform/gtk/tables/mozilla_expected_failures/marvin/table_frame_lhs-expected.txt:
- platform/gtk/tables/mozilla_expected_failures/marvin/table_frame_rhs-expected.png:
- platform/gtk/tables/mozilla_expected_failures/marvin/table_frame_rhs-expected.txt:
- platform/gtk/tables/mozilla_expected_failures/marvin/table_frame_void-expected.png:
- platform/gtk/tables/mozilla_expected_failures/marvin/table_frame_void-expected.txt:
- platform/gtk/tables/mozilla_expected_failures/marvin/table_frame_vsides-expected.png:
- platform/gtk/tables/mozilla_expected_failures/marvin/table_frame_vsides-expected.txt:
- platform/gtk/tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow_row-expected.png:
- platform/gtk/tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow_row-expected.txt:
- platform/gtk/tables/mozilla_expected_failures/marvin/table_rules_cols-expected.png:
- platform/gtk/tables/mozilla_expected_failures/marvin/table_rules_cols-expected.txt:
- platform/gtk/tables/mozilla_expected_failures/marvin/table_rules_rows-expected.png:
- platform/gtk/tables/mozilla_expected_failures/marvin/table_rules_rows-expected.txt:
- platform/gtk/tables/mozilla_expected_failures/marvin/tables_caption_align_left-expected.png:
- platform/gtk/tables/mozilla_expected_failures/marvin/tables_caption_align_left-expected.txt:
- platform/gtk/tables/mozilla_expected_failures/marvin/tables_caption_align_right-expected.png:
- platform/gtk/tables/mozilla_expected_failures/marvin/tables_caption_align_right-expected.txt:
- platform/gtk/tables/mozilla_expected_failures/marvin/x_caption_align_left-expected.png:
- platform/gtk/tables/mozilla_expected_failures/marvin/x_caption_align_left-expected.txt:
- platform/gtk/tables/mozilla_expected_failures/marvin/x_caption_align_right-expected.png:
- platform/gtk/tables/mozilla_expected_failures/marvin/x_caption_align_right-expected.txt:
- platform/gtk/tables/mozilla_expected_failures/marvin/x_colgroup_width_px-expected.png:
- platform/gtk/tables/mozilla_expected_failures/marvin/x_colgroup_width_px-expected.txt:
- platform/gtk/tables/mozilla_expected_failures/marvin/x_table_frame_above-expected.txt:
- platform/gtk/tables/mozilla_expected_failures/marvin/x_table_frame_below-expected.txt:
- platform/gtk/tables/mozilla_expected_failures/marvin/x_table_frame_border-expected.txt:
- platform/gtk/tables/mozilla_expected_failures/marvin/x_table_frame_box-expected.txt:
- platform/gtk/tables/mozilla_expected_failures/marvin/x_table_frame_hsides-expected.txt:
- platform/gtk/tables/mozilla_expected_failures/marvin/x_table_frame_lhs-expected.txt:
- platform/gtk/tables/mozilla_expected_failures/marvin/x_table_frame_rhs-expected.txt:
- platform/gtk/tables/mozilla_expected_failures/marvin/x_table_frame_vsides-expected.txt:
- platform/gtk/tables/mozilla_expected_failures/marvin/x_table_rules_all-expected.txt:
- platform/gtk/tables/mozilla_expected_failures/marvin/x_table_rules_cols-expected.txt:
- platform/gtk/tables/mozilla_expected_failures/marvin/x_table_rules_rows-expected.txt:
- 11:07 AM Changeset in webkit [195826] by
-
- 3 edits in trunk/Source/WebKit2
Disable text interaction with pencil.
https://bugs.webkit.org/show_bug.cgi?id=153655
rdar://problem/24337778
Reviewed by Tim Horton.
- Platform/spi/ios/UIKitSPI.h:
- UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView _createAndConfigureDoubleTapGestureRecognizer]):
(-[WKContentView _singleTapCommited:]):
- 10:59 AM Changeset in webkit [195825] by
-
- 2 edits in trunk/LayoutTests
Unreviewed test gardening.
- platform/mac-wk1/TestExpectations: This one still crashes, just flakily. *sigh*
- 10:46 AM Changeset in webkit [195824] by
-
- 5 edits in trunk/Source
Versioning.
- 10:43 AM Changeset in webkit [195823] by
-
- 1 copy in tags/Safari-602.1.18
New tag.
- 10:43 AM Changeset in webkit [195822] by
-
- 2 edits in trunk/LayoutTests
Marking 3 displaylist tests as flaky on ios-simulator
https://bugs.webkit.org/show_bug.cgi?id=153656
Unreviewed test gardening.
- platform/ios-simulator/TestExpectations:
- 10:34 AM Changeset in webkit [195821] by
-
- 5 edits in tags/Safari-602.1.17.0.3/Source
Versioning.
- 10:29 AM Changeset in webkit [195820] by
-
- 1 copy in tags/Safari-602.1.17.0.3
New tag.
- 10:00 AM Changeset in webkit [195819] by
-
- 4 edits1 delete in trunk/Source/WebInspectorUI
Web Inspector: Add font-variant-* to the visual styles sidebar
https://bugs.webkit.org/show_bug.cgi?id=148720
<rdar://problem/22569974>
Patch by Devin Rousso <Devin Rousso> on 2016-01-29
Reviewed by Timothy Hatcher.
Added another subsection to the "Text" section for font-variant-*
properties.
- Localizations/en.lproj/localizedStrings.js:
- UserInterface/Images/FontVariantSmallCaps.svg: Removed.
- UserInterface/Views/VisualStyleDetailsPanel.js:
(WebInspector.VisualStyleDetailsPanel):
Added another keyword grouping with the "normal" value since it is used
frequently in multiple subsections.
(WebInspector.VisualStyleDetailsPanel.prototype._populateFontSection):
(WebInspector.VisualStyleDetailsPanel.prototype._populateFontVariantsSection):
Added the five new font-variant-* properties specified in
<https://webkit.org/blog/5735/css-font-features/>.
(WebInspector.VisualStyleDetailsPanel.prototype._populateTextSpacingSection):
(WebInspector.VisualStyleDetailsPanel.prototype._populateAnimationSection):
Replaced the hardcoded "normal" keyword with the new grouping.
- UserInterface/Views/VisualStyleKeywordCheckbox.css:
(.visual-style-property-container.keyword-checkbox.font-variant > .visual-style-property-value-container > input::after): Deleted.
- 9:52 AM WebKitGTK/Gardening/Calendar edited by
- (diff)
- 9:50 AM Changeset in webkit [195818] by
-
- 2 edits in trunk/LayoutTests
Rebaseline fast/forms/auto-fill-button/input-contacts-auto-fill-button.html for ios-simulator
https://bugs.webkit.org/show_bug.cgi?id=153567
Unreviewed test gardening.
- platform/ios-simulator/fast/forms/auto-fill-button/input-contacts-auto-fill-button-expected.txt:
- 9:44 AM Changeset in webkit [195817] by
-
- 3 edits in branches/safari-601-branch/Source/WebCore/dom
Applied patch from rdar://problem/24209109.
- 9:38 AM Changeset in webkit [195816] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed Windows build fix; one more ResourceLoaderOptions call site which needs to
be updated after adding the CachingPolicy parameter.
- platform/graphics/avfoundation/cf/WebCoreAVCFResourceLoader.cpp:
(WebCore::WebCoreAVCFResourceLoader::startLoading):
- 9:28 AM Changeset in webkit [195815] by
-
- 1 copy in releases/WebKitGTK/webkit-2.10.7
WebKitGTK+ 2.10.7
- 9:25 AM Changeset in webkit [195814] by
-
- 2 edits in trunk/LayoutTests
Unreviewed test gardening.
- platform/mac-wk1/TestExpectations: Enable some IndexedDB tests that pass.
- 9:24 AM Changeset in webkit [195813] by
-
- 4 edits in releases/WebKitGTK/webkit-2.10
Unreviewed. Update OptionsGTK.cmake and NEWS for 2.10.7 release.
.:
- Source/cmake/OptionsGTK.cmake: Bump version numbers.
Source/WebKit2:
- gtk/NEWS: Add release notes for 2.10.7
- 8:53 AM Changeset in webkit [195812] by
-
- 3 edits in releases/WebKitGTK/webkit-2.10/Source/WebKit2
Merge r195811 - [GTK] WebProcess crashes when quickly attempting many DnD operations
https://bugs.webkit.org/show_bug.cgi?id=138468
Reviewed by Michael Catanzaro.
Guard all the new DnD-related code under GTK_CHECK_VERSION #if's to
make sure we don't bump the required version of GTK+ up to 3.16, and
it's buildable again with GTK+ >= 3.6.
- UIProcess/gtk/DragAndDropHandler.cpp:
(WebKit::DragAndDropHandler::DragAndDropHandler):
(WebKit::DragAndDropHandler::startDrag):
(WebKit::DragAndDropHandler::fillDragData):
(WebKit::DragAndDropHandler::finishDrag):
- UIProcess/gtk/DragAndDropHandler.h:
- 8:26 AM Changeset in webkit [195811] by
-
- 3 edits in trunk/Source/WebKit2
[GTK] WebProcess crashes when quickly attempting many DnD operations
https://bugs.webkit.org/show_bug.cgi?id=138468
Reviewed by Michael Catanzaro.
Guard all the new DnD-related code under GTK_CHECK_VERSION #if's to
make sure we don't bump the required version of GTK+ up to 3.16, and
it's buildable again with GTK+ >= 3.6.
- UIProcess/gtk/DragAndDropHandler.cpp:
(WebKit::DragAndDropHandler::DragAndDropHandler):
(WebKit::DragAndDropHandler::startDrag):
(WebKit::DragAndDropHandler::fillDragData):
(WebKit::DragAndDropHandler::finishDrag):
- UIProcess/gtk/DragAndDropHandler.h:
- 2:58 AM Changeset in webkit [195810] by
-
- 8 edits2 adds in trunk/Source/WebCore
[GTK] Implement overlay scrollbars
https://bugs.webkit.org/show_bug.cgi?id=153405
Reviewed by Michael Catanzaro.
Add support for overlay scrollbars to GTK+ platform following the
same style and behavior than GtkScrolledWindow. They are only
available for GTK+ >= 3.19, but honoring the GTK_OVERLAY_SCROLLING
environment variable, so they could be disable at run time, except
when threaded compositor is enabled. A new ScrollAnimator class
has been added for GTK+ to implement overlay scrollbars and still
allow smooth scrolling when available.
- PlatformGTK.cmake: Add ScrollAnimatorGtk and stop building ScrollAnimatorSmooth.
- platform/ScrollAnimator.h:
(WebCore::ScrollAnimator::ScrollAnimator::mouseEnteredContentArea):
Remove const to allow the ScrollAnimator to be updated.
(WebCore::ScrollAnimator::ScrollAnimator::mouseExitedContentArea): Ditto.
(WebCore::ScrollAnimator::ScrollAnimator::mouseMovedInContentArea): Ditto.
(WebCore::ScrollAnimator::ScrollAnimator::contentAreaDidShow): Ditto.
(WebCore::ScrollAnimator::ScrollAnimator::contentAreaDidHide): Ditto.
- platform/Scrollbar.h:
(WebCore::Scrollbar::opacity): Get scrollbar opacity.
(WebCore::Scrollbar::setOpacity): Set scrollbar opacity.
- platform/gtk/ScrollAnimatorGtk.cpp: Added.
(WebCore::ScrollAnimator::create): Create a ScrollAnimatorGtk.
(WebCore::ScrollAnimatorGtk::ScrollAnimatorGtk):
(WebCore::ScrollAnimatorGtk::~ScrollAnimatorGtk):
(WebCore::ScrollAnimatorGtk::ensureSmoothScrollingAnimation):
Initialize the ScrollAnimationSmooth if it doesn't exist.
(WebCore::ScrollAnimatorGtk::scroll): Ensure we have a
ScrollAnimationSmooth if smooth scrolling is enabled. This also
fixes the problem of having to reload the page after changing the
smooth scrolling setting.
(WebCore::ScrollAnimatorGtk::scrollToOffsetWithoutAnimation):
(WebCore::ScrollAnimatorGtk::willEndLiveResize):
(WebCore::ScrollAnimatorGtk::didAddVerticalScrollbar): Register
the scrollbar if it's an overlay scrollbar and make it visible
without animating it. Start the hide animation.
(WebCore::ScrollAnimatorGtk::didAddHorizontalScrollbar): Ditto.
(WebCore::ScrollAnimatorGtk::willRemoveVerticalScrollbar):
Unregister the scrollbar if it was registered and resrt the
animation state if it was the only scrollbar.
(WebCore::ScrollAnimatorGtk::willRemoveHorizontalScrollbar): Ditto.
(WebCore::ScrollAnimatorGtk::updateOverlayScrollbarsOpacity): Update
the scrollbars opacity and invalidate the indicator.
(WebCore::easeOutCubic):
(WebCore::ScrollAnimatorGtk::overlayScrollbarAnimationTimerFired):
Update the scrollbars opacity and schedule a next frame if the
animation didn't finish or start the hide animation otherwhise.
(WebCore::ScrollAnimatorGtk::showOverlayScrollbars): Start the
fade animation to show the scrollbars if needed.
(WebCore::ScrollAnimatorGtk::hideOverlayScrollbars): Start the
dafe animation to hide the scrollbars if needed.
(WebCore::ScrollAnimatorGtk::mouseEnteredContentArea): Call
showOverlayScrollbars().
(WebCore::ScrollAnimatorGtk::mouseExitedContentArea): Call
hideOverlayScrollbars().
(WebCore::ScrollAnimatorGtk::mouseMovedInContentArea): Call
showOverlayScrollbars().
(WebCore::ScrollAnimatorGtk::contentAreaDidShow): Ditto.
(WebCore::ScrollAnimatorGtk::contentAreaDidHide): Hide the
scrollbars without animations.
(WebCore::ScrollAnimatorGtk::notifyContentAreaScrolled): Call
showOverlayScrollbars().
(WebCore::ScrollAnimatorGtk::lockOverlayScrollbarStateToHidden):
Update the lock state and hide or show the scrollbars when locked
or unlocked.
- platform/gtk/ScrollAnimatorGtk.h: Added.
- platform/gtk/ScrollbarThemeGtk.cpp:
(WebCore::ScrollbarThemeGtk::backButtonRect): Pass
StyleContextMode to getOrCreateStyleContext depending on the
painting parameter.
(WebCore::ScrollbarThemeGtk::forwardButtonRect): Ditto.
(WebCore::ScrollbarThemeGtk::trackRect): Ditto.
(WebCore::ScrollbarThemeGtk::getOrCreateStyleContext): Add
StyleContextMode parameter to add the hovering class
unconditionally when using overlay scrollbars in layout mode. In
paint mode we add the hovering clas only when the scrollbar is
hovered. This way we always claim the size of the scrollbar when
hovered to be able to show the full scrollbar when the mouse is
close enough to the indicator.
(WebCore::ScrollbarThemeGtk::ScrollbarThemeGtk): Initialize
m_usesOverlayScrollbars.
(WebCore::ScrollbarThemeGtk::thumbRect): Pass the scrollbar to
getOrCreateStyleContext().
(WebCore::adjustRectAccordingToMargin): Fix the top margin.
(WebCore::ScrollbarThemeGtk::paintTrackBackground): Pass the
scrollbar and paint mode to getOrCreateStyleContext().
(WebCore::ScrollbarThemeGtk::paintScrollbarBackground): Ditto.
(WebCore::ScrollbarThemeGtk::paintThumb): Adjust the thumb
rectangle when overlay scrollbar is not hovered to its current
size, since we always claim the size of the scrollbar in hovered
mode.
(WebCore::ScrollbarThemeGtk::paintButton): Pass the scrollbar and
paint mode to getOrCreateStyleContext().
(WebCore::ScrollbarThemeGtk::paint): Take the scrollbar opacity
into account when rendering overlay scrollbars as indicators. Also
get the scrollbar opacity from the GTK+ theme and use a
transparency group when the global opacity is not full opaque.
(WebCore::ScrollbarThemeGtk::buttonSize): Pass the scrollbar to
getOrCreateStyleContext().
- platform/gtk/ScrollbarThemeGtk.h:
- platform/mac/ScrollAnimatorMac.h:
- platform/mac/ScrollAnimatorMac.mm:
(WebCore::ScrollAnimatorMac::mouseEnteredContentArea):
(WebCore::ScrollAnimatorMac::mouseExitedContentArea):
(WebCore::ScrollAnimatorMac::mouseMovedInContentArea):
(WebCore::ScrollAnimatorMac::contentAreaDidShow):
(WebCore::ScrollAnimatorMac::contentAreaDidHide):
- 1:58 AM Changeset in webkit [195809] by
-
- 3 edits2 adds in trunk
[GStreamer] built-in media player doesn't update
https://bugs.webkit.org/show_bug.cgi?id=151816
Reviewed by Xabier Rodriguez-Calvar.
Source/WebCore:
The timeline of audio controls in media document is not properly updated since it is assumed
that the controls are hidden as soon as playing. However, such full page audio always has
opacity : 1 declared by video:-webkit-full-page-media::-webkit-media-controls-panel.no-video.
i.e. it is not actually hidden. We can fix this by simply returning false for no-video media
in controlsAreHidden();
Test: media/audio-controls-timeline-in-media-document.html
- Modules/mediacontrols/mediaControlsBase.js:
(Controller.prototype.controlsAreAlwaysVisible):
(Controller.prototype.controlsAreHidden):
LayoutTests:
- media/audio-controls-timeline-in-media-document-expected.txt: Added.
- media/audio-controls-timeline-in-media-document.html: Added.
- 1:22 AM Changeset in webkit [195808] by
-
- 9 edits in trunk/Source/WebCore
[css-grid] Store lines instead of tracks in GridResolvedPosition
https://bugs.webkit.org/show_bug.cgi?id=153592
Reviewed by Sergio Villar Senin.
Due to the new feature that allows to create implicit tracks before the
explicit ones, we will need to use lines instead of tracks in the
code to be able to implement it properly.
This is just a first simple patch using lines instead of tracks in
GridResolvedPosition. It modifies the code that was using it, as it was
considering that the resolvedFinalPosition was a track index and
not a line index.
So if we've an item positioned like:
grid-column: 2 / 5;
grid-row: 1 / span 2;
Before we were storing this information on the GridSpan:
- columns:
- resolvedInitialPosition: 1
- resolvedFinalPosition: 3
- rows:
- resolvedInitialPosition: 0
- resolvedFinalPosition: 1
And now we're storing:
- columns:
- resolvedInitialPosition: 1
- resolvedFinalPosition: 4
- rows:
- resolvedInitialPosition: 0
- resolvedFinalPosition: 2
No new tests, no change of behavior.
- css/CSSGridTemplateAreasValue.cpp:
(WebCore::stringForPosition):
- css/CSSParser.cpp:
(WebCore::CSSParser::parseGridTemplateAreasRow):
- css/StyleBuilderConverter.h:
(WebCore::StyleBuilderConverter::createImplicitNamedGridLinesFromGridArea):
- rendering/RenderGrid.cpp:
(WebCore::RenderGrid::GridIterator::nextEmptyGridArea):
(WebCore::RenderGrid::computeUsedBreadthOfGridTracks):
(WebCore::RenderGrid::ensureGridSize):
(WebCore::RenderGrid::populateExplicitGridAndOrderIterator):
(WebCore::RenderGrid::placeAutoMajorAxisItemOnGrid):
(WebCore::RenderGrid::offsetAndBreadthForPositionedChild):
(WebCore::RenderGrid::gridAreaBreadthForChildIncludingAlignmentOffsets):
(WebCore::RenderGrid::columnAxisOffsetForChild):
(WebCore::RenderGrid::rowAxisOffsetForChild):
- rendering/RenderGrid.h:
- rendering/style/GridCoordinate.h:
(WebCore::GridSpan::GridSpan):
(WebCore::GridSpan::integerSpan):
(WebCore::GridSpan::end):
(WebCore::GridCoordinate::GridCoordinate):
- rendering/style/GridResolvedPosition.cpp:
(WebCore::resolveRowStartColumnStartNamedGridLinePositionAgainstOppositePosition):
(WebCore::resolveRowEndColumnEndNamedGridLinePositionAgainstOppositePosition):
(WebCore::resolveNamedGridLinePositionAgainstOppositePosition):
(WebCore::resolveGridPositionAgainstOppositePosition):
(WebCore::GridResolvedPosition::resolveGridPositionsFromAutoPlacementPosition):
(WebCore::GridResolvedPosition::resolveGridPositionsFromStyle):
(WebCore::resolveNamedGridLinePositionFromStyle): Deleted.
- rendering/style/GridResolvedPosition.h:
- 12:38 AM Changeset in webkit [195807] by
-
- 29 edits in branches/safari-601-branch
Merged r194479. rdar://problem/24404073
- 12:35 AM Changeset in webkit [195806] by
-
- 6 edits in branches/safari-601-branch
Merged r195615. rdar://problem/24302726
- 12:22 AM Changeset in webkit [195805] by
-
- 1 edit2 copies in branches/safari-601-branch/LayoutTests
Merged r191251. rdar://problem/24399452
- 12:20 AM Changeset in webkit [195804] by
-
- 2 edits in branches/safari-601-branch/Source/JavaScriptCore
Merge patch for rdar://problem/23968717.
- 12:12 AM Changeset in webkit [195803] by
-
- 2 edits in branches/safari-601-branch/Source/WebCore
Merge patch for rdar://problem/24394636.
Jan 28, 2016:
- 11:21 PM Changeset in webkit [195802] by
-
- 4 edits in branches/safari-601.1.46-branch/Source/WebCore
- 10:50 PM Changeset in webkit [195801] by
-
- 4 edits in trunk
Modern IDB: SQLite backend mismanages key generator values.
https://bugs.webkit.org/show_bug.cgi?id=153625
Reviewed by Andy Estes.
Source/WebCore:
No new tests (Many failing tests pass, a few get closer).
There's mixed assumptions about whether the value stored is the current value or the next value.
Fixing those assumptions fixes tests.
- Modules/indexeddb/server/SQLiteIDBBackingStore.cpp:
(WebCore::IDBServer::SQLiteIDBBackingStore::generateKeyNumber): Store/retrieve the correct value.
(WebCore::IDBServer::SQLiteIDBBackingStore::revertGeneratedKeyNumber): Ditto.
(WebCore::IDBServer::SQLiteIDBBackingStore::maybeUpdateKeyGeneratorNumber): Ditto.
LayoutTests:
- platform/mac-wk1/TestExpectations:
- 9:37 PM Changeset in webkit [195800] by
-
- 3 edits in trunk/Source/JavaScriptCore
[B3] REGRESSION(r195395): testComplex(64, 128) asserts on Linux with GCC
https://bugs.webkit.org/show_bug.cgi?id=153422
Reviewed by Filip Pizlo.
Previously proc.values() returns ValuesCollection (Not reference!).
values.values takes const ValueCollection&.
And later it produces IndexSet<Value>::Iterable<Procedure::ValuesCollection>,
it holds const ValueCollection& as its member.
But IndexSet<Value>::Iterable<Procedure::ValuesCollection> is just an instance.
So after creating this, the lifetime of the ValueCollection const reference finished.
To fix that, we hold ValuesCollection as a member of Procedure.
And change the signature to const ValuesCollection& Procedure::values().
- b3/B3Procedure.cpp:
(JSC::B3::Procedure::Procedure):
- b3/B3Procedure.h:
(JSC::B3::Procedure::values):
- 7:46 PM Changeset in webkit [195799] by
-
- 62 edits in trunk
Web Inspector: InspectorTimelineAgent doesn't need to recompile functions because it now uses the sampling profiler
https://bugs.webkit.org/show_bug.cgi?id=153500
<rdar://problem/24352458>
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-01-28
Reviewed by Timothy Hatcher.
Source/JavaScriptCore:
Be more explicit about enabling legacy profiling.
- jsc.cpp:
- runtime/Executable.cpp:
(JSC::ScriptExecutable::newCodeBlockFor):
- runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::hasLegacyProfiler):
(JSC::JSGlobalObject::createProgramCodeBlock):
(JSC::JSGlobalObject::createEvalCodeBlock):
(JSC::JSGlobalObject::createModuleProgramCodeBlock):
(JSC::JSGlobalObject::hasProfiler): Deleted.
- runtime/JSGlobalObject.h:
(JSC::JSGlobalObject::supportsLegacyProfiling):
(JSC::JSGlobalObject::supportsProfiling): Deleted.
Source/WebCore:
- bindings/js/JSDOMWindowBase.cpp:
(WebCore::JSDOMWindowBase::supportsLegacyProfiling):
(WebCore::JSDOMWindowBase::supportsRichSourceInfo):
(WebCore::JSDOMWindowBase::supportsProfiling): Deleted.
- bindings/js/JSDOMWindowBase.h:
- bindings/js/JSWorkerGlobalScopeBase.cpp:
(WebCore::JSWorkerGlobalScopeBase::supportsLegacyProfiling):
(WebCore::JSWorkerGlobalScopeBase::supportsProfiling): Deleted.
- bindings/js/JSWorkerGlobalScopeBase.h:
- inspector/InspectorController.h:
- inspector/InspectorController.cpp:
(WebCore::InspectorController::legacyProfilerEnabled):
(WebCore::InspectorController::setLegacyProfilerEnabled):
Be more explicit about enabling legacy profiling.
- inspector/InspectorTimelineAgent.cpp:
(WebCore::InspectorTimelineAgent::willDestroyFrontendAndBackend):
(WebCore::InspectorTimelineAgent::didCreateFrontendAndBackend): Deleted.
TimelineAgent doesn't need to recompile if using the sampling profiler.
This breaks console.profile, but console.profile should move to using
the sampling profiler as well.
(WebCore::InspectorTimelineAgent::startFromConsole):
(WebCore::InspectorTimelineAgent::stopFromConsole):
(WebCore::startProfiling): Deleted.
(WebCore::stopProfiling): Deleted.
Inlined the use once static functions.
- page/PageConsoleClient.cpp:
(WebCore::PageConsoleClient::profile):
(WebCore::PageConsoleClient::profileEnd):
Added FIXMEs for improving console.profile and profileEnd.
- testing/Internals.cpp:
(WebCore::Internals::resetToConsistentState):
(WebCore::Internals::setLegacyJavaScriptProfilingEnabled):
(WebCore::Internals::setJavaScriptProfilingEnabled): Deleted.
- testing/Internals.h:
- testing/Internals.idl:
Be more explicit about enabling legacy profiling.
LayoutTests:
- fast/profiler/*.html
Be more explicit about enabling legacy profiling.
- inspector/sampling-profiler/eval-source-url.html
Remove an inner loop that was causing tail call optimizations
to eliminate the sourceURL we were expecting.
- 7:42 PM Changeset in webkit [195798] by
-
- 5 edits in trunk
Move attributes to the prototype for List types / and types with indexed/named property getters
https://bugs.webkit.org/show_bug.cgi?id=153599
Reviewed by Darin Adler.
LayoutTests/imported/w3c:
Rebaseline W3C tests now that more checks are passing.
- web-platform-tests/dom/interfaces-expected.txt:
- web-platform-tests/html/dom/interfaces-expected.txt:
Source/WebCore:
Move attributes to the prototype for List types / and types with indexed/named property getters.
We used to keep them on the instance because:
- Our GetOwnProperty lookup used to be in incorrect order for interfaces with indexed/named property getters.
-> This was fixed recently and we now match the specification and other browsers.
- This used to regress performance when iterating over those list types
-> Local testing seems to show that this is no longer a regression (tested Speedometer and various related Bindings PerformanceTests).
No new tests, already covered by existing tests.
- bindings/scripts/CodeGeneratorJS.pm:
(InterfaceRequiresAttributesOnInstance): Deleted.
(AttributeShouldBeOnInstanceForCompatibility): Deleted.
- 7:36 PM Changeset in webkit [195797] by
-
- 2 edits in trunk/Source/WebKit2
Enable background tab suspension by default on OSX
https://bugs.webkit.org/show_bug.cgi?id=153629
<rdar://problem/24402895>
Reviewed by Andreas Kling.
- UIProcess/Cocoa/WebProcessPoolCocoa.mm:
(WebKit::registerUserDefaultsIfNeeded):
- 6:58 PM Changeset in webkit [195796] by
-
- 2 edits in trunk/LayoutTests
Modern IDB: Enabled all of the imported IndexedDB tests that pass in the SQLite backing store.
https://bugs.webkit.org/show_bug.cgi?id=153623
Reviewed by Andy Estes.
- platform/mac-wk1/TestExpectations: TONS of these now pass. List of failing tests is now small.
- 6:02 PM Changeset in webkit [195795] by
-
- 25 edits10 deletes in trunk
[Cocoa] Use the non-Development variants of XPC services for development
https://bugs.webkit.org/show_bug.cgi?id=152545
Reviewed by Darin Adler.
Source/WebKit2:
The purpose of the Development variants of the WebKit XPC services is to allow the service
to link against the development WebKit dylibs rather than the system ones. Instead, we
accomplish this here by including dyld environment load commands in the normal services
when the WebKit dylibs are expected to be relocated. A new build setting,
WK_RELOCATABLE_FRAMEWORKS, controls this.
To make it easy to identify engineering builds of the services at runtime, they can be
given a distinctive suffix. A new build setting, WK_XPC_SERVICE_SUFFIX, controls this.
- Configurations/DebugRelease.xcconfig: Set WK_RELOCATABLE_FRAMEWORKS to YES and WK_XPC_SERVICE_SUFFIX to ".Development".
- Configurations/BaseTarget.xcconfig: Make the quoted value of the WK_XPC_SERVICE_SUFFIX build setting available as a preprocessor macro.
- Configurations/BaseXPCService.xcconfig:
- Simplify the definition of INSTALL_PATH now that there are no Development variants.
- Define WK_RELOCATABLE_FRAMEWORKS_LDFLAGS when building relocatable frameworks to include -dyld_env options setting DYLD_FRAMEWORK_PATH to point to the directory containing WebKit.framework and DYLD_LIBRARY_PATH to the framework’s Frameworks subdirectory. When not building relocatable frameworks, define WK_RELOCATABLE_FRAMEWORKS_LDFLAGS to include a -headerpad option allowing dyld environment load commands to be added after the fact.
- Add WK_RELOCATABLE_FRAMEWORKS_LDFLAGS to OTHER_LDFLAGS.
- Define WK_XPC_SERVICE_INSERT_LIBRARIES_DIR when building relocatable frameworks to be the path to the Frameworks subdirectory of the WebKit framework containing the service. When not building relocatable frameworks, define it to the absolute path of the Frameworks subdirectory of the installed WebKit framework.
- Configurations/DatabaseService.xcconfig: Append WK_XPC_SERVICE_SUFFIX to PRODUCT_NAME, and remove no-longer-used definition of WK_XPC_SERVICE_VARIANT.
- Configurations/NetworkService.xcconfig: Append WK_XPC_SERVICE_SUFFIX to PRODUCT_NAME, add WK_RELOCATABLE_FRAMEWORKS_LDFLAGS to OTHER_LDFLAGS, and remove no-longer-used definition of WK_XPC_SERVICE_VARIANT.
- Configurations/PluginService.32.xcconfig: Ditto.
- Configurations/PluginService.64.xcconfig: Ditto.
- Configurations/WebContentService.xcconfig: Ditto.
- Configurations/DatabaseService.Development.xcconfig: Removed.
- Configurations/NetworkService.Development.xcconfig: Removed.
- Configurations/PluginService.32.Development.xcconfig: Removed.
- Configurations/PluginService.64.Development.xcconfig: Removed.
- Configurations/WebContentService.Development.xcconfig: Removed.
- DatabaseProcess/EntryPoint/mac/XPCService/DatabaseService.Development: Removed.
- DatabaseProcess/EntryPoint/mac/XPCService/DatabaseService.Development/Info.plist: Removed.
- DatabaseProcess/EntryPoint/mac/XPCService/DatabaseService/Info.plist: Set CFBundleIdentifier to PRODUCT_NAME in order to include the optional suffix.
- NetworkProcess/EntryPoint/mac/XPCService/NetworkService.Development: Removed.
- NetworkProcess/EntryPoint/mac/XPCService/NetworkService.Development/Info-OSX.plist: Removed.
- NetworkProcess/EntryPoint/mac/XPCService/NetworkService.Development/Info-iOS.plist: Removed.
- NetworkProcess/EntryPoint/mac/XPCService/NetworkService/Info-OSX-10.9-10.10.plist: Set CFBundleIdentifier to PRODUCT_NAME in order to include the optional suffix. Use WK_XPC_SERVICE_INSERT_LIBRARIES_DIR in the value of DYLD_INSERT_LIBRARIES.
- NetworkProcess/EntryPoint/mac/XPCService/NetworkService/Info-OSX.plist: Set CFBundleIdentifier to PRODUCT_NAME in order to include the optional suffix.
- NetworkProcess/EntryPoint/mac/XPCService/NetworkService/Info-iOS.plist: Ditto.
- PluginProcess/EntryPoint/mac/XPCService/PluginService.32-64-10.9-10.10.Info.plist: Ditto.
- PluginProcess/EntryPoint/mac/XPCService/PluginService.Development: Removed.
- PluginProcess/EntryPoint/mac/XPCService/PluginService.Development/Info.plist: Removed.
- WebProcess/EntryPoint/mac/XPCService/WebContentService.Development: Removed.
- WebProcess/EntryPoint/mac/XPCService/WebContentService.Development/Info-OSX.plist: Removed.
- WebProcess/EntryPoint/mac/XPCService/WebContentService.Development/Info-iOS.plist: Removed.
- WebProcess/EntryPoint/mac/XPCService/WebContentService/Info-OSX-10.9-10.10.plist: Set CFBundleIdentifier to PRODUCT_NAME in order to include the optional suffix. Use WK_XPC_SERVICE_INSERT_LIBRARIES_DIR in the value of DYLD_INSERT_LIBRARIES.
- WebProcess/EntryPoint/mac/XPCService/WebContentService/Info-OSX.plist: Set CFBundleIdentifier to PRODUCT_NAME in order to include the optional suffix.
- WebProcess/EntryPoint/mac/XPCService/WebContentService/Info-iOS.plist: Ditto.
- Shared/EntryPointUtilities/mac/XPCService/XPCServiceMain.Development.mm: Removed.
- Shared/EntryPointUtilities/mac/XPCService/XPCServiceMain.mm:
(WebKit::XPCServiceEventHandler): If stdout and stderr file descriptors are included in the
bootstrap message, hook them up to the serviceâs stdout and stderr, like the Development
services do.
(main): Moved code from XPCServiceMain.Development.mm to handle the optional
OverrideLanguages array.
- UIProcess/Launcher/mac/ProcessLauncherMac.mm:
(WebKit::addDYLDEnvironmentAdditions): Addressed a FIXME.
(WebKit::serviceName): Removed forDevelopment argument and .Development service names.
Added WK_XPC_SERVICE_SUFFIX to the names.
(WebKit::connectToService): Updated for removal of forDevelopment argument. Removed
"framework-executable-path" key from the bootstrap message, because it was only used in
the Development variants.
(WebKit::connectToReExecService): Deleted.
(WebKit::createService): Removed call to connectToReExecService. Instead pass forDevelopment
to connectToService.
- WebKit2.xcodeproj/project.pbxproj: Removed references to removed files. Removed targets for Development services. Removed Development services from script build phase that copies services into the framework in engineering builds, and made it respect WK_XPC_SERVICE_SUFFIX.
Tools:
- Scripts/webkitdirs.pm:
(setUpGuardMallocIfNeeded): Ensure that libgmalloc is loaded into XPC services as well.
- Scripts/webkitpy/port/driver.py:
(Driver._setup_environ_for_driver): Ensure that the DYLD_LIBRARY_PATH and ASAN_OPTIONS are
set in the XPC services as well.
- Scripts/webkitpy/port/ios.py:
(IOSSimulatorPort.setup_environ_for_server): Ensure that malloc stack logging for leaks and
Guard Malloc are enabled in XPC services as well.
- Scripts/webkitpy/port/mac.py:
(MacPort.setup_environ_for_server): Ditto.
- 4:48 PM Changeset in webkit [195794] by
-
- 5 edits in branches/safari-601-branch/Source
Versioning.
- 4:35 PM Changeset in webkit [195793] by
-
- 1 copy in tags/Safari-601.5.12
New tag.
- 4:23 PM WebKitGTK/Gardening/Calendar edited by
- (diff)
- 3:44 PM Changeset in webkit [195792] by
-
- 5 edits in branches/safari-601.1.46-branch/Source
Versioning.
- 3:41 PM Changeset in webkit [195791] by
-
- 1 copy in tags/Safari-601.1.46.94
New tag.
- 3:30 PM Changeset in webkit [195790] by
-
- 6 edits in trunk/Source/WebCore
Tab suspension code hits asserts
Reviewed by Chris Dumez.
Enabling tab suspension and navigating around in a few tabs hits an assert in
ScriptExecutionContext::suspendActiveDOMObject. This is because suspend/resume reasons don't pair properly
- dom/Document.cpp:
(WebCore::Document::documentWillBecomeInactive):
(WebCore::Document::suspend):
(WebCore::Document::resume):
Provide the reason as argument.
- dom/Document.h:
- history/CachedFrame.cpp:
(WebCore::CachedFrameBase::restore):
No need to call resumeActiveDOMObjects/resumeScriptedAnimationControllerCallbacks explicitly as Document::resume does that.
(WebCore::CachedFrame::CachedFrame):
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::commitProvisionalLoad):
- page/Page.cpp:
(WebCore::Page::canTabSuspend):
(WebCore::Page::setIsTabSuspended):
- 3:28 PM Changeset in webkit [195789] by
-
- 416 edits in trunk/LayoutTests
[Win] gardening after r195740. (more to follow)
Unreviewed.
- platform/win/css1/box_properties/padding_left-expected.txt:
- platform/win/fast/dom/HTMLTableElement/colSpan-expected.txt:
- platform/win/fast/encoding/utf-16-big-endian-expected.txt:
- platform/win/fast/encoding/utf-16-little-endian-expected.txt:
- platform/win/fast/forms/001-expected.txt:
- platform/win/fast/forms/005-expected.txt:
- platform/win/fast/forms/auto-fill-button/input-contacts-auto-fill-button-expected.txt:
- platform/win/fast/forms/basic-buttons-expected.txt:
- platform/win/fast/forms/button-white-space-expected.txt:
- platform/win/fast/forms/file/file-input-direction-expected.txt:
- platform/win/fast/forms/form-added-to-table-expected.txt:
- platform/win/fast/forms/form-element-geometry-expected.txt:
- platform/win/fast/forms/form-hides-table-expected.txt:
- platform/win/fast/forms/form-in-malformed-markup-expected.txt:
- platform/win/fast/forms/formmove3-expected.txt:
- platform/win/fast/forms/input-appearance-spinbutton-expected.txt:
- platform/win/fast/forms/input-double-click-selection-gap-bug-expected.txt:
- platform/win/fast/forms/input-table-expected.txt:
- platform/win/fast/forms/input-value-expected.txt:
- platform/win/fast/forms/listbox-bidi-align-expected.txt:
- platform/win/fast/forms/preserveFormDuringResidualStyle-expected.txt:
- platform/win/fast/forms/select-dirty-parent-pref-widths-expected.txt:
- platform/win/fast/html/details-writing-mode-expected.txt:
- platform/win/fast/inline-block/001-expected.txt:
- platform/win/fast/inline-block/overflow-clip-expected.txt:
- platform/win/fast/invalid/012-expected.txt:
- platform/win/fast/invalid/018-expected.txt:
- platform/win/fast/invalid/table-inside-stray-table-content-expected.txt:
- platform/win/fast/invalid/td-inside-object-expected.txt:
- platform/win/fast/lists/004-expected.txt:
- platform/win/fast/lists/list-marker-before-content-table-expected.txt:
- platform/win/fast/lists/ordered-list-with-no-ol-tag-expected.txt:
- platform/win/fast/multicol/span/before-child-anonymous-column-block-expected.txt:
- platform/win/fast/overflow/002-expected.txt:
- platform/win/fast/overflow/overflow-auto-table-expected.txt:
- platform/win/fast/overflow/overflow-rtl-expected.txt:
- platform/win/fast/overflow/overflow-rtl-vertical-expected.txt:
- platform/win/fast/overflow/table-overflow-float-expected.txt:
- platform/win/fast/reflections/table-cell-expected.txt:
- platform/win/fast/repaint/block-selection-gap-in-table-cell-expected.txt:
- platform/win/fast/repaint/float-overflow-expected.txt:
- platform/win/fast/repaint/float-overflow-right-expected.txt:
- platform/win/fast/repaint/subtree-root-clip-3-expected.txt:
- platform/win/fast/repaint/table-cell-collapsed-border-expected.txt:
- platform/win/fast/repaint/table-cell-collapsed-border-scroll-expected.txt:
- platform/win/fast/repaint/table-cell-move-expected.txt:
- platform/win/fast/repaint/table-cell-overflow-expected.txt:
- platform/win/fast/repaint/table-cell-vertical-overflow-expected.txt:
- platform/win/fast/repaint/table-col-background-expected.txt:
- platform/win/fast/repaint/table-collapsed-border-expected.txt:
- platform/win/fast/repaint/table-extra-bottom-grow-expected.txt:
- platform/win/fast/repaint/table-outer-border-expected.txt:
- platform/win/fast/repaint/table-row-expected.txt:
- platform/win/fast/repaint/table-section-overflow-expected.txt:
- platform/win/fast/repaint/table-section-repaint-expected.txt:
- platform/win/fast/repaint/table-two-pass-layout-overpaint-expected.txt:
- platform/win/fast/repaint/table-writing-modes-h-expected.txt:
- platform/win/fast/repaint/table-writing-modes-v-expected.txt:
- platform/win/fast/replaced/005-expected.txt:
- platform/win/fast/replaced/percent-height-in-anonymous-block-in-table-expected.txt:
- platform/win/fast/replaced/selection-rect-in-table-cell-expected.txt:
- platform/win/fast/replaced/table-percent-height-positioned-expected.txt:
- platform/win/fast/replaced/width100percent-button-expected.txt:
- platform/win/fast/replaced/width100percent-checkbox-expected.txt:
- platform/win/fast/replaced/width100percent-image-expected.txt:
- platform/win/fast/replaced/width100percent-menulist-expected.txt:
- platform/win/fast/replaced/width100percent-radio-expected.txt:
- platform/win/fast/ruby/ruby-inline-table-expected.txt:
- platform/win/fast/selectors/018-expected.txt:
- platform/win/fast/selectors/018b-expected.txt:
- platform/win/fast/selectors/032-expected.txt:
- platform/win/fast/selectors/043-expected.txt:
- platform/win/fast/selectors/043b-expected.txt:
- platform/win/fast/selectors/044-expected.txt:
- platform/win/fast/selectors/044b-expected.txt:
- platform/win/fast/selectors/077-expected.txt:
- platform/win/fast/selectors/077b-expected.txt:
- platform/win/fast/selectors/078b-expected.txt:
- platform/win/fast/table/001-expected.txt:
- platform/win/fast/table/002-expected.txt:
- platform/win/fast/table/003-expected.txt:
- platform/win/fast/table/004-expected.txt:
- platform/win/fast/table/005-expected.txt:
- platform/win/fast/table/006-expected.txt:
- platform/win/fast/table/007-expected.txt:
- platform/win/fast/table/008-expected.txt:
- platform/win/fast/table/009-expected.txt:
- platform/win/fast/table/010-expected.txt:
- platform/win/fast/table/011-expected.txt:
- platform/win/fast/table/012-expected.txt:
- platform/win/fast/table/013-expected.txt:
- platform/win/fast/table/015-expected.txt:
- platform/win/fast/table/016-expected.txt:
- platform/win/fast/table/021-expected.txt:
- platform/win/fast/table/022-expected.txt:
- platform/win/fast/table/023-expected.txt:
- platform/win/fast/table/024-expected.txt:
- platform/win/fast/table/025-expected.txt:
- platform/win/fast/table/026-expected.txt:
- platform/win/fast/table/028-expected.txt:
- platform/win/fast/table/028-vertical-expected.txt:
- platform/win/fast/table/029-expected.txt:
- platform/win/fast/table/031-expected.txt:
- platform/win/fast/table/032-expected.txt:
- platform/win/fast/table/033-expected.txt:
- platform/win/fast/table/034-expected.txt:
- platform/win/fast/table/035-expected.txt:
- platform/win/fast/table/035-vertical-expected.txt:
- platform/win/fast/table/037-expected.txt:
- platform/win/fast/table/038-expected.txt:
- platform/win/fast/table/038-vertical-expected.txt:
- platform/win/fast/table/039-expected.txt:
- platform/win/fast/table/040-expected.txt:
- platform/win/fast/table/040-vertical-expected.txt:
- platform/win/fast/table/041-expected.txt:
- platform/win/fast/table/100-percent-cell-width-expected.txt:
- platform/win/fast/table/add-before-anonymous-child-expected.txt:
- platform/win/fast/table/auto-with-percent-height-expected.txt:
- platform/win/fast/table/auto-with-percent-height-vertical-expected.txt:
- platform/win/fast/table/border-collapsing/001-expected.txt:
- platform/win/fast/table/border-collapsing/001-vertical-expected.txt:
- platform/win/fast/table/border-collapsing/002-expected.txt:
- platform/win/fast/table/border-collapsing/002-vertical-expected.txt:
- platform/win/fast/table/border-collapsing/003-expected.txt:
- platform/win/fast/table/border-collapsing/003-vertical-expected.txt:
- platform/win/fast/table/border-collapsing/004-expected.txt:
- platform/win/fast/table/border-collapsing/004-vertical-expected.txt:
- platform/win/fast/table/border-collapsing/border-collapsing-head-foot-expected.txt:
- platform/win/fast/table/border-collapsing/border-collapsing-head-foot-vertical-expected.txt:
- platform/win/fast/table/border-collapsing/bug14274-expected.txt:
- platform/win/fast/table/border-collapsing/cached-69296-expected.txt:
- platform/win/fast/table/border-collapsing/cached-cell-append-expected.txt:
- platform/win/fast/table/border-collapsing/cached-cell-remove-expected.txt:
- platform/win/fast/table/border-collapsing/cached-change-cell-border-color-expected.txt:
- platform/win/fast/table/border-collapsing/cached-change-cell-border-width-expected.txt:
- platform/win/fast/table/border-collapsing/cached-change-cell-sl-border-color-expected.txt:
- platform/win/fast/table/border-collapsing/cached-change-col-border-color-expected.txt:
- platform/win/fast/table/border-collapsing/cached-change-col-border-width-expected.txt:
- platform/win/fast/table/border-collapsing/cached-change-colgroup-border-color-expected.txt:
- platform/win/fast/table/border-collapsing/cached-change-colgroup-border-width-expected.txt:
- platform/win/fast/table/border-collapsing/cached-change-row-border-width-expected.txt:
- platform/win/fast/table/border-collapsing/cached-change-table-border-color-expected.txt:
- platform/win/fast/table/border-collapsing/cached-change-table-border-width-expected.txt:
- platform/win/fast/table/border-collapsing/cached-change-tbody-border-color-expected.txt:
- platform/win/fast/table/border-collapsing/collapsed-borders-adjoining-sections-vertical-rl-expected.txt:
- platform/win/fast/table/border-collapsing/collapsed-borders-painted-once-on-inner-cells-expected.txt:
- platform/win/fast/table/border-collapsing/equal-precedence-resolution-expected.txt:
- platform/win/fast/table/border-collapsing/equal-precedence-resolution-vertical-expected.txt:
- platform/win/fast/table/border-collapsing/rtl-border-collapsing-expected.txt:
- platform/win/fast/table/border-collapsing/rtl-border-collapsing-vertical-expected.txt:
- platform/win/fast/table/caption-relayout-expected.txt:
- platform/win/fast/table/cell-absolute-child-expected.txt:
- platform/win/fast/table/cell-coalescing-expected.txt:
- platform/win/fast/table/cell-width-auto-expected.txt:
- platform/win/fast/table/cellindex-expected.txt:
- platform/win/fast/table/click-near-anonymous-table-expected.txt:
- platform/win/fast/table/colgroup-preceded-by-caption-expected.txt:
- platform/win/fast/table/colgroup-spanning-groups-rules-expected.txt:
- platform/win/fast/table/colspan-with-all-percent-cells-expected.txt:
- platform/win/fast/table/colspanMinWidth-expected.txt:
- platform/win/fast/table/colspanMinWidth-vertical-expected.txt:
- platform/win/fast/table/dynamic-cellpadding-expected.txt:
- platform/win/fast/table/dynamic-descendant-percentage-height-expected.txt:
- platform/win/fast/table/edge-offsets-expected.txt:
- platform/win/fast/table/empty-cells-expected.txt:
- platform/win/fast/table/floating-th-expected.txt:
- platform/win/fast/table/frame-and-rules-expected.txt:
- platform/win/fast/table/generated-caption-expected.txt:
- platform/win/fast/table/giantRowspan-expected.txt:
- platform/win/fast/table/growCellForImageQuirk-expected.txt:
- platform/win/fast/table/growCellForImageQuirk-vertical-expected.txt:
- platform/win/fast/table/height-percent-test-expected.txt:
- platform/win/fast/table/height-percent-test-vertical-expected.txt:
- platform/win/fast/table/insert-before-anonymous-ancestors-expected.txt:
- platform/win/fast/table/insert-cell-before-form-expected.txt:
- platform/win/fast/table/insert-row-before-form-expected.txt:
- platform/win/fast/table/invisible-cell-background-expected.txt:
- platform/win/fast/table/large-width-expected.txt:
- platform/win/fast/table/max-width-integer-overflow-expected.txt:
- platform/win/fast/table/mozilla-bug10296-vertical-align-1-expected.txt:
- platform/win/fast/table/mozilla-bug10296-vertical-align-2-expected.txt:
- platform/win/fast/table/multiple-captions-display-expected.txt:
- platform/win/fast/table/nested-percent-height-table-expected.txt:
- platform/win/fast/table/nobr-expected.txt:
- platform/win/fast/table/overflowHidden-expected.txt:
- platform/win/fast/table/percent-heights-expected.txt:
- platform/win/fast/table/percent-widths-stretch-expected.txt:
- platform/win/fast/table/percent-widths-stretch-vertical-expected.txt:
- platform/win/fast/table/prepend-in-anonymous-table-expected.txt:
- platform/win/fast/table/quote-text-around-iframe-expected.txt:
- platform/win/fast/table/relative-position-containment-expected.txt:
- platform/win/fast/table/relative-position-offsets-expected.txt:
- platform/win/fast/table/relative-position-stacking-expected.txt:
- platform/win/fast/table/replaced-percent-height-expected.txt:
- platform/win/fast/table/row-height-recalc-expected.txt:
- platform/win/fast/table/rowspan-paint-order-expected.txt:
- platform/win/fast/table/rowspan-paint-order-vertical-expected.txt:
- platform/win/fast/table/rtl-cell-display-none-assert-expected.txt:
- platform/win/fast/table/rules-attr-dynchange1-expected.txt:
- platform/win/fast/table/rules-attr-dynchange2-expected.txt:
- platform/win/fast/table/simple_paint-expected.txt:
- platform/win/fast/table/spanOverlapRepaint-expected.txt:
- platform/win/fast/table/stale-grid-crash-expected.txt:
- platform/win/fast/table/table-after-child-in-table-expected.txt:
- platform/win/fast/table/table-and-parts-outline-expected.txt:
- platform/win/fast/table/table-anonymous-cell-bug-expected.txt:
- platform/win/fast/table/table-anonymous-row-bug-expected.txt:
- platform/win/fast/table/table-anonymous-section-bug-expected.txt:
- platform/win/fast/table/table-before-child-in-table-expected.txt:
- platform/win/fast/table/table-before-child-style-update-expected.txt:
- platform/win/fast/table/table-cell-after-child-in-block-expected.txt:
- platform/win/fast/table/table-cell-after-child-in-table-expected.txt:
- platform/win/fast/table/table-cell-before-after-content-around-table-block-expected.txt:
- platform/win/fast/table/table-cell-before-after-content-around-table-expected.txt:
- platform/win/fast/table/table-cell-before-after-content-around-table-row-expected.txt:
- platform/win/fast/table/table-cell-before-child-in-block-expected.txt:
- platform/win/fast/table/table-cell-before-child-in-table-expected.txt:
- platform/win/fast/table/table-cell-split-expected.txt:
- platform/win/fast/table/table-continuation-outline-paint-crash-expected.txt:
- platform/win/fast/table/table-display-types-expected.txt:
- platform/win/fast/table/table-display-types-strict-expected.txt:
- platform/win/fast/table/table-display-types-vertical-expected.txt:
- platform/win/fast/table/table-hspace-align-center-expected.txt:
- platform/win/fast/table/table-insert-before-non-anonymous-block-expected.txt:
- platform/win/fast/table/table-row-after-child-in-block-expected.txt:
- platform/win/fast/table/table-row-after-child-in-table-expected.txt:
- platform/win/fast/table/table-row-before-after-content-around-block-expected.txt:
- platform/win/fast/table/table-row-before-after-content-around-table-cell-expected.txt:
- platform/win/fast/table/table-row-before-after-content-around-table-expected.txt:
- platform/win/fast/table/table-row-before-child-in-block-expected.txt:
- platform/win/fast/table/table-row-before-child-in-table-expected.txt:
- platform/win/fast/table/table-row-before-child-style-update-expected.txt:
- platform/win/fast/table/table-row-outline-paint-expected.txt:
- platform/win/fast/table/table-row-split2-expected.txt:
- platform/win/fast/table/table-row-style-not-updated-expected.txt:
- platform/win/fast/table/table-row-style-not-updated-with-after-content-expected.txt:
- platform/win/fast/table/table-row-style-not-updated-with-before-content-expected.txt:
- platform/win/fast/table/table-section-split2-expected.txt:
- platform/win/fast/table/table-split-expected.txt:
- platform/win/fast/table/table-split2-expected.txt:
- platform/win/fast/table/table-style-not-updated-expected.txt:
- platform/win/fast/table/tableInsideCaption-expected.txt:
- platform/win/fast/table/text-field-baseline-expected.txt:
- platform/win/fast/table/unbreakable-images-quirk-expected.txt:
- platform/win/fast/table/vertical-align-baseline-expected.txt:
- platform/win/fast/table/wide-colspan-expected.txt:
- platform/win/fast/table/wide-column-expected.txt:
- platform/win/fast/text/atsui-negative-spacing-features-expected.txt:
- platform/win/fast/text/atsui-spacing-features-expected.txt:
- platform/win/fast/text/basic/001-expected.txt:
- platform/win/fast/text/basic/006-expected.txt:
- platform/win/fast/text/basic/007-expected.txt:
- platform/win/fast/text/basic/generic-family-reset-expected.txt:
- platform/win/fast/text/capitalize-boundaries-expected.txt:
- platform/win/fast/text/international/bidi-LDB-2-CSS-expected.txt:
- platform/win/fast/text/international/bidi-LDB-2-HTML-expected.txt:
- platform/win/fast/text/international/bidi-LDB-2-formatting-characters-expected.txt:
- platform/win/fast/text/international/bidi-override-expected.txt:
- platform/win/fast/text/textIteratorNilRenderer-expected.txt:
- platform/win/fast/text/wbr-expected.txt:
- platform/win/fast/text/whitespace/002-expected.txt:
- platform/win/fast/text/whitespace/003-expected.txt:
- platform/win/fast/text/whitespace/004-expected.txt:
- platform/win/fast/text/whitespace/005-expected.txt:
- platform/win/fast/text/whitespace/010-expected.txt:
- platform/win/fast/text/whitespace/011-expected.txt:
- platform/win/fast/text/whitespace/013-expected.txt:
- platform/win/fast/text/whitespace/014-expected.txt:
- platform/win/fast/text/whitespace/015-expected.txt:
- platform/win/fast/text/whitespace/016-expected.txt:
- platform/win/fast/text/whitespace/024-expected.txt:
- platform/win/fast/text/whitespace/025-expected.txt:
- platform/win/fast/text/whitespace/026-expected.txt:
- platform/win/fast/text/whitespace/027-expected.txt:
- platform/win/fast/text/word-break-expected.txt:
- platform/win/fast/transforms/transform-table-row-expected.txt:
- platform/win/fast/writing-mode/table-percent-width-quirk-expected.txt:
- platform/win/fast/writing-mode/vertical-align-table-baseline-expected.txt:
- platform/win/http/tests/misc/acid2-expected.txt:
- platform/win/http/tests/misc/acid2-pixel-expected.txt:
- platform/win/http/tests/misc/generated-content-inside-table-expected.txt:
- platform/win/http/tests/misc/object-embedding-svg-delayed-size-negotiation-2-expected.txt:
- platform/win/svg/as-background-image/background-image-preserveaspectRatio-support-expected.txt:
- platform/win/tables/layering/paint-test-layering-1-expected.txt:
- platform/win/tables/layering/paint-test-layering-2-expected.txt:
- platform/win/tables/mozilla/bugs/bug10009-expected.txt:
- platform/win/tables/mozilla/bugs/bug10036-expected.txt:
- platform/win/tables/mozilla/bugs/bug10269-1-expected.txt:
- platform/win/tables/mozilla/bugs/bug10269-2-expected.txt:
- platform/win/tables/mozilla/bugs/bug10296-1-expected.txt:
- platform/win/tables/mozilla/bugs/bug10296-2-expected.txt:
- platform/win/tables/mozilla/bugs/bug1055-1-expected.txt:
- platform/win/tables/mozilla/bugs/bug10565-expected.txt:
- platform/win/tables/mozilla/bugs/bug10633-expected.txt:
- platform/win/tables/mozilla/bugs/bug1067-1-expected.txt:
- platform/win/tables/mozilla/bugs/bug1067-2-expected.txt:
- platform/win/tables/mozilla/bugs/bug11321-expected.txt:
- platform/win/tables/mozilla/bugs/bug1163-1-expected.txt:
- platform/win/tables/mozilla/bugs/bug1188-expected.txt:
- platform/win/tables/mozilla/bugs/bug11944-expected.txt:
- platform/win/tables/mozilla/bugs/bug12008-expected.txt:
- platform/win/tables/mozilla/bugs/bug1224-expected.txt:
- platform/win/tables/mozilla/bugs/bug12268-expected.txt:
- platform/win/tables/mozilla/bugs/bug12384-expected.txt:
- platform/win/tables/mozilla/bugs/bug1261-expected.txt:
- platform/win/tables/mozilla/bugs/bug12709-expected.txt:
- platform/win/tables/mozilla/bugs/bug1271-expected.txt:
- platform/win/tables/mozilla/bugs/bug12908-1-expected.txt:
- platform/win/tables/mozilla/bugs/bug12908-2-expected.txt:
- platform/win/tables/mozilla/bugs/bug12910-2-expected.txt:
- platform/win/tables/mozilla/bugs/bug1296-expected.txt:
- platform/win/tables/mozilla/bugs/bug1302-expected.txt:
- platform/win/tables/mozilla/bugs/bug13105-expected.txt:
- platform/win/tables/mozilla/bugs/bug13118-expected.txt:
- platform/win/tables/mozilla/bugs/bug13169-expected.txt:
- platform/win/tables/mozilla/bugs/bug1318-expected.txt:
- platform/win/tables/mozilla/bugs/bug13484-expected.txt:
- platform/win/tables/mozilla/bugs/bug13526-expected.txt:
- platform/win/tables/mozilla/bugs/bug14159-3-expected.txt:
- platform/win/tables/mozilla/bugs/bug1430-expected.txt:
- platform/win/tables/mozilla/bugs/bug14323-expected.txt:
- platform/win/tables/mozilla/bugs/bug14929-expected.txt:
- platform/win/tables/mozilla/bugs/bug15247-expected.txt:
- platform/win/tables/mozilla/bugs/bug15544-expected.txt:
- platform/win/tables/mozilla/bugs/bug15933-expected.txt:
- platform/win/tables/mozilla/bugs/bug16012-expected.txt:
- platform/win/tables/mozilla/bugs/bug16252-expected.txt:
- platform/win/tables/mozilla/bugs/bug17130-1-expected.txt:
- platform/win/tables/mozilla/bugs/bug17138-expected.txt:
- platform/win/tables/mozilla/bugs/bug17548-expected.txt:
- platform/win/tables/mozilla/bugs/bug17587-expected.txt:
- platform/win/tables/mozilla/bugs/bug1800-expected.txt:
- platform/win/tables/mozilla/bugs/bug1802-expected.txt:
- platform/win/tables/mozilla/bugs/bug1802s-expected.txt:
- platform/win/tables/mozilla/bugs/bug1809-expected.txt:
- platform/win/tables/mozilla/bugs/bug1828-expected.txt:
- platform/win/tables/mozilla/bugs/bug18359-expected.txt:
- platform/win/tables/mozilla/bugs/bug18440-expected.txt:
- platform/win/tables/mozilla/bugs/bug18558-expected.txt:
- platform/win/tables/mozilla/bugs/bug18664-expected.txt:
- platform/win/tables/mozilla/bugs/bug18955-expected.txt:
- platform/win/tables/mozilla/bugs/bug19061-1-expected.txt:
- platform/win/tables/mozilla/bugs/bug19061-2-expected.txt:
- platform/win/tables/mozilla/bugs/bug19356-expected.txt:
- platform/win/tables/mozilla/bugs/bug2050-expected.txt:
- platform/win/tables/mozilla/bugs/bug2123-expected.txt:
- platform/win/tables/mozilla/bugs/bug2267-expected.txt:
- platform/win/tables/mozilla/bugs/bug2296-expected.txt:
- platform/win/tables/mozilla/bugs/bug2469-expected.txt:
- platform/win/tables/mozilla/bugs/bug2479-1-expected.txt:
- platform/win/tables/mozilla/bugs/bug2479-2-expected.txt:
- platform/win/tables/mozilla/bugs/bug2479-3-expected.txt:
- platform/win/tables/mozilla/bugs/bug2516-expected.txt:
- platform/win/tables/mozilla/bugs/bug2585-expected.txt:
- platform/win/tables/mozilla/bugs/bug2684-expected.txt:
- platform/win/tables/mozilla/bugs/bug2757-expected.txt:
- platform/win/tables/mozilla/bugs/bug2773-expected.txt:
- platform/win/tables/mozilla/bugs/bug2886-2-expected.txt:
- platform/win/tables/mozilla/bugs/bug2886-expected.txt:
- platform/win/tables/mozilla/bugs/bug2954-expected.txt:
- platform/win/tables/mozilla/bugs/bug2973-expected.txt:
- platform/win/tables/mozilla/bugs/bug2981-1-expected.txt:
- platform/win/tables/mozilla/bugs/bug2981-2-expected.txt:
- platform/win/tables/mozilla/bugs/bug2997-expected.txt:
- platform/win/tables/mozilla/bugs/bug3037-1-expected.txt:
- platform/win/tables/mozilla/bugs/bug3037-2-expected.txt:
- platform/win/tables/mozilla/bugs/bug3103-expected.txt:
- platform/win/tables/mozilla/bugs/bug3191-expected.txt:
- platform/win/tables/mozilla/bugs/bug3260-expected.txt:
- platform/win/tables/mozilla/bugs/bug3263-expected.txt:
- platform/win/tables/mozilla/bugs/bug3309-2-expected.txt:
- platform/win/tables/mozilla/bugs/bug3454-expected.txt:
- platform/win/tables/mozilla/bugs/bug3718-expected.txt:
- platform/win/tables/mozilla/bugs/bug3977-expected.txt:
- platform/win/tables/mozilla/bugs/bug4093-expected.txt:
- platform/win/tables/mozilla/bugs/bug4284-expected.txt:
- platform/win/tables/mozilla/bugs/bug4385-expected.txt:
- platform/win/tables/mozilla/bugs/bug4427-expected.txt:
- platform/win/tables/mozilla/bugs/bug4429-expected.txt:
- platform/win/tables/mozilla/bugs/bug4501-expected.txt:
- platform/win/tables/mozilla/bugs/bug4520-expected.txt:
- platform/win/tables/mozilla/bugs/bug4527-expected.txt:
- platform/win/tables/mozilla/bugs/bug4576-expected.txt:
- platform/win/tables/mozilla/bugs/bug4739-expected.txt:
- platform/win/tables/mozilla/bugs/bug4803-expected.txt:
- platform/win/tables/mozilla/bugs/bug4849-2-expected.txt:
- platform/win/tables/mozilla/bugs/bug4849-expected.txt:
- platform/win/tables/mozilla/bugs/bug5188-expected.txt:
- platform/win/tables/mozilla/bugs/bug5538-expected.txt:
- platform/win/tables/mozilla/bugs/bug5797-expected.txt:
- platform/win/tables/mozilla/bugs/bug5798-expected.txt:
- platform/win/tables/mozilla/bugs/bug5799-expected.txt:
- platform/win/tables/mozilla/bugs/bug5835-expected.txt:
- platform/win/tables/mozilla/bugs/bug5838-expected.txt:
- platform/win/tables/mozilla/bugs/bug6184-expected.txt:
- platform/win/tables/mozilla/bugs/bug6304-expected.txt:
- platform/win/tables/mozilla/bugs/bug6404-expected.txt:
- platform/win/tables/mozilla/bugs/bug647-expected.txt:
- platform/win/tables/mozilla/bugs/bug650-expected.txt:
- platform/win/tables/mozilla/bugs/bug6674-expected.txt:
- platform/win/tables/mozilla/bugs/bug709-expected.txt:
- platform/win/tables/mozilla/bugs/bug7112-1-expected.txt:
- platform/win/tables/mozilla/bugs/bug7112-2-expected.txt:
- platform/win/tables/mozilla/bugs/bug7342-expected.txt:
- platform/win/tables/mozilla/bugs/bug7714-expected.txt:
- platform/win/tables/mozilla/bugs/bug8032-1-expected.txt:
- platform/win/tables/mozilla/bugs/bug8361-expected.txt:
- platform/win/tables/mozilla/bugs/bug8381-expected.txt:
- platform/win/tables/mozilla/bugs/bug8950-expected.txt:
- platform/win/tables/mozilla/bugs/bug9072-expected.txt:
- platform/win/tables/mozilla/bugs/bug9123-1-expected.txt:
- platform/win/tables/mozilla/bugs/bug9123-2-expected.txt:
- platform/win/tables/mozilla/bugs/bug9271-1-expected.txt:
- platform/win/tables/mozilla/bugs/bug963-expected.txt:
- platform/win/tables/mozilla/bugs/bug965-expected.txt:
- platform/win/tables/mozilla/bugs/bug9879-1-expected.txt:
- 3:21 PM Changeset in webkit [195788] by
-
- 2 edits in trunk/Source/JavaScriptCore
Fix the B3 build with GCC 4.9.3
https://bugs.webkit.org/show_bug.cgi?id=151624
Reviewed by Filip Pizlo.
Due to GCC 4.9's compiler issue[1], method calls inside (2 or so) nested lambdas need to use
thisto avoid internal compiler errors.
[1]: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=62272
- b3/air/AirIteratedRegisterCoalescing.cpp:
- 3:18 PM Changeset in webkit [195787] by
-
- 6 edits in trunk
Modern IDB: Fix several more problems with object store changes during cursor iteration in SQLite backend.
https://bugs.webkit.org/show_bug.cgi?id=153616
Reviewed by Alex Christensen.
Source/WebCore:
No new tests (A few failing tests pass, a few get closer).
- Modules/indexeddb/server/SQLiteIDBBackingStore.cpp:
(WebCore::IDBServer::SQLiteIDBBackingStore::clearObjectStore):
- Modules/indexeddb/server/SQLiteIDBCursor.cpp:
(WebCore::IDBServer::SQLiteIDBCursor::resetAndRebindStatement):
(WebCore::IDBServer::SQLiteIDBCursor::bindArguments):
- Modules/indexeddb/server/UniqueIDBDatabaseTransaction.cpp:
(WebCore::IDBServer::UniqueIDBDatabaseTransaction::iterateCursor):
LayoutTests:
- platform/mac-wk1/TestExpectations:
- 3:16 PM Changeset in webkit [195786] by
-
- 2 edits in trunk/Source/WebCore
Cleanup: Make DedicatedWorkerThread::create() an inline template method
https://bugs.webkit.org/show_bug.cgi?id=153612
Apply feedback given by Andy Estes in <https://bugs.webkit.org/show_bug.cgi?id=153612#c3> that
I inadvertently did not include in <http://trac.webkit.org/changeset/195785>.
- workers/DedicatedWorkerThread.h:
(WebCore::DedicatedWorkerThread::create): Substitute typename for class.
- 3:04 PM Changeset in webkit [195785] by
-
- 3 edits in trunk/Source/WebCore
Cleanup: Make DedicatedWorkerThread::create() an inline template method
https://bugs.webkit.org/show_bug.cgi?id=153612
Reviewed by Andy Estes.
Make use of variadic template arguments and std::forward() to forward the arguments passed
to DedicatedWorkerThread::create() to DedicatedWorkerThread::DedicatedWorkerThread(). This
removes the need to duplicate code whenever we modify the parameter types or number of
parameters taken by DedicatedWorkerThread::DedicatedWorkerThread().
- workers/DedicatedWorkerThread.cpp:
(WebCore::DedicatedWorkerThread::create): Deleted.
- workers/DedicatedWorkerThread.h: Reorganized listing of member functions such that we
group the creation/constructor and destructor functions.
(WebCore::DedicatedWorkerThread::create): Modified to be an inline template with variadic
parameters that std::forward()s its arguments to DedicatedWorkerThread::DedicatedWorkerThread().
- 2:52 PM Changeset in webkit [195784] by
-
- 8 edits in trunk
Modern IDB: SQLite backend doesn't handle mutation during cursor iteration.
https://bugs.webkit.org/show_bug.cgi?id=153614
Reviewed by Alex Christensen.
Source/WebCore:
No new tests (A few failing tests pass, a few get closer).
- Modules/indexeddb/server/SQLiteIDBBackingStore.cpp:
(WebCore::IDBServer::SQLiteIDBBackingStore::deleteRange): Call notifyCursorsOfChanges.
(WebCore::IDBServer::SQLiteIDBBackingStore::addRecord): Ditto.
- Modules/indexeddb/server/SQLiteIDBCursor.cpp:
(WebCore::IDBServer::SQLiteIDBCursor::SQLiteIDBCursor):
(WebCore::IDBServer::SQLiteIDBCursor::~SQLiteIDBCursor):
- Modules/indexeddb/server/SQLiteIDBCursor.h:
- Modules/indexeddb/server/SQLiteIDBTransaction.cpp:
(WebCore::IDBServer::SQLiteIDBTransaction::maybeOpenBackingStoreCursor): Remember these transient backing
store cursors so they can be notified of changes.
(WebCore::IDBServer::SQLiteIDBTransaction::closeCursor): Handle removing the cursor from the right set.
(WebCore::IDBServer::SQLiteIDBTransaction::notifyCursorsOfChanges):
- Modules/indexeddb/server/SQLiteIDBTransaction.h:
LayoutTests:
- platform/mac-wk1/TestExpectations:
- 2:40 PM Changeset in webkit [195783] by
-
- 4 edits in trunk
Modern IDB: SQLite backend doesn't support deleting ranges with more than one key.
https://bugs.webkit.org/show_bug.cgi?id=153604
Reviewed by Andy Estes.
Source/WebCore:
No new tests (A few failing tests pass, a few get closer).
- Modules/indexeddb/server/SQLiteIDBBackingStore.cpp:
(WebCore::IDBServer::SQLiteIDBBackingStore::deleteRange):
LayoutTests:
- platform/mac-wk1/TestExpectations:
- 2:24 PM Changeset in webkit [195782] by
-
- 2 edits in trunk/Source/WebCore
Fix Windows build after r195774.
- platform/network/ParsedContentRange.cpp:
- 1:17 PM Changeset in webkit [195781] by
-
- 3 edits in trunk/Source/WebCore
Add an ArrayValue::get overload that returns a string
https://bugs.webkit.org/show_bug.cgi?id=153613
Reviewed by Tim Horton.
- bindings/js/ArrayValue.cpp:
(WebCore::ArrayValue::get):
- bindings/js/ArrayValue.h:
- 1:14 PM Changeset in webkit [195780] by
-
- 1712 edits23 copies25 adds in trunk/LayoutTests
[GTK] Unreviewed gardening after r195740.
- platform/gtk/TestExpectations
- platform/gtk/accessibility/table-detection-expected.txt
- platform/gtk/css1/basic/containment-expected.png
- platform/gtk/css1/basic/containment-expected.txt
- platform/gtk/css1/basic/contextual_selectors-expected.png
- platform/gtk/css1/basic/contextual_selectors-expected.txt
- platform/gtk/css1/basic/grouping-expected.png
- platform/gtk/css1/basic/grouping-expected.txt
- platform/gtk/css1/basic/id_as_selector-expected.png
- platform/gtk/css1/basic/id_as_selector-expected.txt
- platform/gtk/css1/basic/inheritance-expected.png
- platform/gtk/css1/basic/inheritance-expected.txt
- platform/gtk/css1/box_properties/border-expected.png
- platform/gtk/css1/box_properties/border-expected.txt
- platform/gtk/css1/box_properties/border_bottom-expected.png
- platform/gtk/css1/box_properties/border_bottom-expected.txt
- platform/gtk/css1/box_properties/border_bottom_inline-expected.png
- platform/gtk/css1/box_properties/border_bottom_inline-expected.txt
- platform/gtk/css1/box_properties/border_bottom_width-expected.png
- platform/gtk/css1/box_properties/border_bottom_width-expected.txt
- platform/gtk/css1/box_properties/border_bottom_width_inline-expected.png
- platform/gtk/css1/box_properties/border_bottom_width_inline-expected.txt
- platform/gtk/css1/box_properties/border_color-expected.png
- platform/gtk/css1/box_properties/border_color-expected.txt
- platform/gtk/css1/box_properties/border_color_inline-expected.png
- platform/gtk/css1/box_properties/border_color_inline-expected.txt
- platform/gtk/css1/box_properties/border_inline-expected.png
- platform/gtk/css1/box_properties/border_inline-expected.txt
- platform/gtk/css1/box_properties/border_left-expected.png
- platform/gtk/css1/box_properties/border_left-expected.txt
- platform/gtk/css1/box_properties/border_left_inline-expected.png
- platform/gtk/css1/box_properties/border_left_inline-expected.txt
- platform/gtk/css1/box_properties/border_left_width-expected.png
- platform/gtk/css1/box_properties/border_left_width-expected.txt
- platform/gtk/css1/box_properties/border_left_width_inline-expected.png
- platform/gtk/css1/box_properties/border_left_width_inline-expected.txt
- platform/gtk/css1/box_properties/border_right-expected.png
- platform/gtk/css1/box_properties/border_right-expected.txt
- platform/gtk/css1/box_properties/border_right_inline-expected.png
- platform/gtk/css1/box_properties/border_right_inline-expected.txt
- platform/gtk/css1/box_properties/border_right_width-expected.png
- platform/gtk/css1/box_properties/border_right_width-expected.txt
- platform/gtk/css1/box_properties/border_right_width_inline-expected.png
- platform/gtk/css1/box_properties/border_right_width_inline-expected.txt
- platform/gtk/css1/box_properties/border_style-expected.png
- platform/gtk/css1/box_properties/border_style-expected.txt
- platform/gtk/css1/box_properties/border_style_inline-expected.png
- platform/gtk/css1/box_properties/border_style_inline-expected.txt
- platform/gtk/css1/box_properties/border_top-expected.png
- platform/gtk/css1/box_properties/border_top-expected.txt
- platform/gtk/css1/box_properties/border_top_inline-expected.png
- platform/gtk/css1/box_properties/border_top_inline-expected.txt
- platform/gtk/css1/box_properties/border_top_width-expected.png
- platform/gtk/css1/box_properties/border_top_width-expected.txt
- platform/gtk/css1/box_properties/border_top_width_inline-expected.png
- platform/gtk/css1/box_properties/border_top_width_inline-expected.txt
- platform/gtk/css1/box_properties/border_width-expected.png
- platform/gtk/css1/box_properties/border_width-expected.txt
- platform/gtk/css1/box_properties/border_width_inline-expected.png
- platform/gtk/css1/box_properties/border_width_inline-expected.txt
- platform/gtk/css1/box_properties/clear-expected.png
- platform/gtk/css1/box_properties/clear-expected.txt
- platform/gtk/css1/box_properties/clear_float-expected.png
- platform/gtk/css1/box_properties/clear_float-expected.txt
- platform/gtk/css1/box_properties/float-expected.png
- platform/gtk/css1/box_properties/float-expected.txt
- platform/gtk/css1/box_properties/float_elements_in_series-expected.png
- platform/gtk/css1/box_properties/float_elements_in_series-expected.txt
- platform/gtk/css1/box_properties/float_margin-expected.png
- platform/gtk/css1/box_properties/float_margin-expected.txt
- platform/gtk/css1/box_properties/float_on_text_elements-expected.png
- platform/gtk/css1/box_properties/float_on_text_elements-expected.txt
- platform/gtk/css1/box_properties/height-expected.png
- platform/gtk/css1/box_properties/height-expected.txt
- platform/gtk/css1/box_properties/margin-expected.png
- platform/gtk/css1/box_properties/margin-expected.txt
- platform/gtk/css1/box_properties/margin_bottom-expected.png
- platform/gtk/css1/box_properties/margin_bottom-expected.txt
- platform/gtk/css1/box_properties/margin_bottom_inline-expected.png
- platform/gtk/css1/box_properties/margin_bottom_inline-expected.txt
- platform/gtk/css1/box_properties/margin_inline-expected.png
- platform/gtk/css1/box_properties/margin_inline-expected.txt
- platform/gtk/css1/box_properties/margin_left-expected.png
- platform/gtk/css1/box_properties/margin_left-expected.txt
- platform/gtk/css1/box_properties/margin_left_inline-expected.png
- platform/gtk/css1/box_properties/margin_left_inline-expected.txt
- platform/gtk/css1/box_properties/margin_right-expected.png
- platform/gtk/css1/box_properties/margin_right-expected.txt
- platform/gtk/css1/box_properties/margin_right_inline-expected.png
- platform/gtk/css1/box_properties/margin_right_inline-expected.txt
- platform/gtk/css1/box_properties/margin_top-expected.png
- platform/gtk/css1/box_properties/margin_top-expected.txt
- platform/gtk/css1/box_properties/margin_top_inline-expected.png
- platform/gtk/css1/box_properties/margin_top_inline-expected.txt
- platform/gtk/css1/box_properties/padding-expected.txt
- platform/gtk/css1/box_properties/padding_bottom-expected.png
- platform/gtk/css1/box_properties/padding_bottom-expected.txt
- platform/gtk/css1/box_properties/padding_bottom_inline-expected.png
- platform/gtk/css1/box_properties/padding_bottom_inline-expected.txt
- platform/gtk/css1/box_properties/padding_inline-expected.png
- platform/gtk/css1/box_properties/padding_inline-expected.txt
- platform/gtk/css1/box_properties/padding_left-expected.png
- platform/gtk/css1/box_properties/padding_left-expected.txt
- platform/gtk/css1/box_properties/padding_left_inline-expected.png
- platform/gtk/css1/box_properties/padding_left_inline-expected.txt
- platform/gtk/css1/box_properties/padding_right-expected.png
- platform/gtk/css1/box_properties/padding_right-expected.txt
- platform/gtk/css1/box_properties/padding_right_inline-expected.png
- platform/gtk/css1/box_properties/padding_right_inline-expected.txt
- platform/gtk/css1/box_properties/padding_top-expected.txt
- platform/gtk/css1/box_properties/padding_top_inline-expected.png
- platform/gtk/css1/box_properties/padding_top_inline-expected.txt
- platform/gtk/css1/box_properties/width-expected.png
- platform/gtk/css1/box_properties/width-expected.txt
- platform/gtk/css1/cascade/cascade_order-expected.png
- platform/gtk/css1/cascade/cascade_order-expected.txt
- platform/gtk/css1/cascade/important-expected.png
- platform/gtk/css1/cascade/important-expected.txt
- platform/gtk/css1/classification/display-expected.png
- platform/gtk/css1/classification/display-expected.txt
- platform/gtk/css1/classification/list_style-expected.png
- platform/gtk/css1/classification/list_style-expected.txt
- platform/gtk/css1/classification/list_style_image-expected.png
- platform/gtk/css1/classification/list_style_image-expected.txt
- platform/gtk/css1/classification/list_style_position-expected.png
- platform/gtk/css1/classification/list_style_position-expected.txt
- platform/gtk/css1/classification/list_style_type-expected.png
- platform/gtk/css1/classification/list_style_type-expected.txt
- platform/gtk/css1/classification/white_space-expected.png
- platform/gtk/css1/classification/white_space-expected.txt
- platform/gtk/css1/color_and_background/background-expected.png
- platform/gtk/css1/color_and_background/background-expected.txt
- platform/gtk/css1/color_and_background/background_attachment-expected.png
- platform/gtk/css1/color_and_background/background_attachment-expected.txt
- platform/gtk/css1/color_and_background/background_color-expected.png
- platform/gtk/css1/color_and_background/background_color-expected.txt
- platform/gtk/css1/color_and_background/background_image-expected.png
- platform/gtk/css1/color_and_background/background_image-expected.txt
- platform/gtk/css1/color_and_background/background_position-expected.png
- platform/gtk/css1/color_and_background/background_position-expected.txt
- platform/gtk/css1/color_and_background/background_repeat-expected.png
- platform/gtk/css1/color_and_background/background_repeat-expected.txt
- platform/gtk/css1/color_and_background/color-expected.png
- platform/gtk/css1/color_and_background/color-expected.txt
- platform/gtk/css1/conformance/forward_compatible_parsing-expected.txt
- platform/gtk/css1/font_properties/font-expected.png
- platform/gtk/css1/font_properties/font-expected.txt
- platform/gtk/css1/font_properties/font_family-expected.png
- platform/gtk/css1/font_properties/font_family-expected.txt
- platform/gtk/css1/font_properties/font_size-expected.png
- platform/gtk/css1/font_properties/font_size-expected.txt
- platform/gtk/css1/font_properties/font_style-expected.png
- platform/gtk/css1/font_properties/font_style-expected.txt
- platform/gtk/css1/font_properties/font_variant-expected.png
- platform/gtk/css1/font_properties/font_variant-expected.txt
- platform/gtk/css1/font_properties/font_weight-expected.png
- platform/gtk/css1/font_properties/font_weight-expected.txt
- platform/gtk/css1/formatting_model/canvas-expected.png
- platform/gtk/css1/formatting_model/canvas-expected.txt
- platform/gtk/css1/formatting_model/floating_elements-expected.png
- platform/gtk/css1/formatting_model/floating_elements-expected.txt
- platform/gtk/css1/formatting_model/height_of_lines-expected.png
- platform/gtk/css1/formatting_model/height_of_lines-expected.txt
- platform/gtk/css1/formatting_model/inline_elements-expected.png
- platform/gtk/css1/formatting_model/inline_elements-expected.txt
- platform/gtk/css1/formatting_model/replaced_elements-expected.png
- platform/gtk/css1/formatting_model/replaced_elements-expected.txt
- platform/gtk/css1/formatting_model/vertical_formatting-expected.txt
- platform/gtk/css1/pseudo/anchor-expected.png
- platform/gtk/css1/pseudo/anchor-expected.txt
- platform/gtk/css1/pseudo/firstletter-expected.png
- platform/gtk/css1/pseudo/firstletter-expected.txt
- platform/gtk/css1/pseudo/firstline-expected.png
- platform/gtk/css1/pseudo/firstline-expected.txt
- platform/gtk/css1/pseudo/multiple_pseudo_elements-expected.png
- platform/gtk/css1/pseudo/multiple_pseudo_elements-expected.txt
- platform/gtk/css1/pseudo/pseudo_elements_in_selectors-expected.png
- platform/gtk/css1/pseudo/pseudo_elements_in_selectors-expected.txt
- platform/gtk/css1/text_properties/letter_spacing-expected.txt
- platform/gtk/css1/text_properties/line_height-expected.png
- platform/gtk/css1/text_properties/line_height-expected.txt
- platform/gtk/css1/text_properties/text_align-expected.png
- platform/gtk/css1/text_properties/text_align-expected.txt
- platform/gtk/css1/text_properties/text_decoration-expected.png
- platform/gtk/css1/text_properties/text_decoration-expected.txt
- platform/gtk/css1/text_properties/text_indent-expected.png
- platform/gtk/css1/text_properties/text_indent-expected.txt
- platform/gtk/css1/text_properties/text_transform-expected.png
- platform/gtk/css1/text_properties/text_transform-expected.txt
- platform/gtk/css1/text_properties/vertical_align-expected.png
- platform/gtk/css1/text_properties/vertical_align-expected.txt
- platform/gtk/css1/text_properties/word_spacing-expected.png
- platform/gtk/css1/text_properties/word_spacing-expected.txt
- platform/gtk/css1/units/color_units-expected.png
- platform/gtk/css1/units/color_units-expected.txt
- platform/gtk/css1/units/length_units-expected.png
- platform/gtk/css1/units/length_units-expected.txt
- platform/gtk/css1/units/percentage_units-expected.png
- platform/gtk/css1/units/percentage_units-expected.txt
- platform/gtk/css1/units/urls-expected.png
- platform/gtk/css1/units/urls-expected.txt
- platform/gtk/css2.1/20110323/border-collapse-offset-002-expected.png
- platform/gtk/css2.1/20110323/border-collapse-offset-002-expected.txt
- platform/gtk/css2.1/20110323/border-conflict-style-079-expected.png
- platform/gtk/css2.1/20110323/border-conflict-style-079-expected.txt
- platform/gtk/css2.1/20110323/border-conflict-style-088-expected.png
- platform/gtk/css2.1/20110323/border-conflict-style-088-expected.txt
- platform/gtk/css2.1/20110323/dynamic-top-change-002-expected.txt
- platform/gtk/css2.1/20110323/dynamic-top-change-003-expected.txt
- platform/gtk/css2.1/20110323/inline-table-001-expected.txt
- platform/gtk/css2.1/20110323/inline-table-003-expected.txt
- platform/gtk/css2.1/20110323/margin-applies-to-001-expected.txt
- platform/gtk/css2.1/20110323/margin-applies-to-002-expected.txt
- platform/gtk/css2.1/20110323/margin-applies-to-003-expected.txt
- platform/gtk/css2.1/20110323/margin-applies-to-004-expected.txt
- platform/gtk/css2.1/20110323/margin-applies-to-005-expected.txt
- platform/gtk/css2.1/20110323/margin-applies-to-006-expected.txt
- platform/gtk/css2.1/20110323/margin-applies-to-007-expected.txt
- platform/gtk/css2.1/20110323/margin-applies-to-013-expected.txt
- platform/gtk/css2.1/20110323/margin-applies-to-014-expected.txt
- platform/gtk/css2.1/20110323/margin-applies-to-015-expected.txt
- platform/gtk/css2.1/20110323/replaced-intrinsic-ratio-001-expected.png
- platform/gtk/css2.1/20110323/replaced-intrinsic-ratio-001-expected.txt
- platform/gtk/css2.1/20110323/table-caption-001-expected.txt
- platform/gtk/css2.1/20110323/table-caption-optional-001-expected.txt
- platform/gtk/css2.1/20110323/table-caption-optional-002-expected.txt
- platform/gtk/css2.1/t040302-c61-ex-len-00-b-a-expected.txt
- platform/gtk/css2.1/t0803-c5501-mrgn-t-00-b-a-expected.txt
- platform/gtk/css2.1/t0803-c5503-mrgn-b-00-b-a-expected.txt
- platform/gtk/css2.1/t080301-c411-vt-mrgn-00-b-expected.txt
- platform/gtk/css2.1/t0804-c5506-padn-t-00-b-a-expected.txt
- platform/gtk/css2.1/t0804-c5508-ipadn-b-03-b-a-expected.txt
- platform/gtk/css2.1/t090402-c42-ibx-pad-00-d-ag-expected.txt
- platform/gtk/css2.1/t0905-c5525-fltmult-00-d-g-expected.txt
- platform/gtk/css2.1/t170602-bdr-conflct-w-04-d-expected.png
- platform/gtk/css2.1/t170602-bdr-conflct-w-04-d-expected.txt
- platform/gtk/css2.1/t170602-bdr-conflct-w-06-d-expected.png
- platform/gtk/css2.1/t170602-bdr-conflct-w-06-d-expected.txt
- platform/gtk/css2.1/t170602-bdr-conflct-w-08-d-expected.png
- platform/gtk/css2.1/t170602-bdr-conflct-w-08-d-expected.txt
- platform/gtk/css2.1/t170602-bdr-conflct-w-13-d-expected.png
- platform/gtk/css2.1/t170602-bdr-conflct-w-13-d-expected.txt
- platform/gtk/css2.1/t170602-bdr-conflct-w-14-d-expected.png
- platform/gtk/css2.1/t170602-bdr-conflct-w-14-d-expected.txt
- platform/gtk/css2.1/t170602-bdr-conflct-w-16-d-expected.png
- platform/gtk/css2.1/t170602-bdr-conflct-w-16-d-expected.txt
- platform/gtk/css2.1/t170602-bdr-conflct-w-17-d-expected.png
- platform/gtk/css2.1/t170602-bdr-conflct-w-17-d-expected.txt
- platform/gtk/css2.1/t170602-bdr-conflct-w-18-d-expected.png
- platform/gtk/css2.1/t170602-bdr-conflct-w-18-d-expected.txt
- platform/gtk/css2.1/t170602-bdr-conflct-w-24-d-expected.png
- platform/gtk/css2.1/t170602-bdr-conflct-w-24-d-expected.txt
- platform/gtk/css2.1/t170602-bdr-conflct-w-25-d-expected.png
- platform/gtk/css2.1/t170602-bdr-conflct-w-25-d-expected.txt
- platform/gtk/css2.1/t170602-bdr-conflct-w-30-d-expected.png
- platform/gtk/css2.1/t170602-bdr-conflct-w-30-d-expected.txt
- platform/gtk/css2.1/t170602-bdr-conflct-w-31-d-expected.png
- platform/gtk/css2.1/t170602-bdr-conflct-w-31-d-expected.txt
- platform/gtk/css2.1/t170602-bdr-conflct-w-34-d-expected.png
- platform/gtk/css2.1/t170602-bdr-conflct-w-34-d-expected.txt
- platform/gtk/css2.1/t170602-bdr-conflct-w-44-d-expected.png
- platform/gtk/css2.1/t170602-bdr-conflct-w-44-d-expected.txt
- platform/gtk/css2.1/t170602-bdr-conflct-w-52-d-expected.png
- platform/gtk/css2.1/t170602-bdr-conflct-w-52-d-expected.txt
- platform/gtk/css2.1/t170602-bdr-conflct-w-54-d-expected.png
- platform/gtk/css2.1/t170602-bdr-conflct-w-54-d-expected.txt
- platform/gtk/css2.1/t170602-bdr-conflct-w-59-d-expected.png
- platform/gtk/css2.1/t170602-bdr-conflct-w-59-d-expected.txt
- platform/gtk/css2.1/t170602-bdr-conflct-w-64-d-expected.png
- platform/gtk/css2.1/t170602-bdr-conflct-w-64-d-expected.txt
- platform/gtk/css2.1/t170602-bdr-conflct-w-65-d-expected.png
- platform/gtk/css2.1/t170602-bdr-conflct-w-65-d-expected.txt
- platform/gtk/css2.1/t170602-bdr-conflct-w-70-d-expected.png
- platform/gtk/css2.1/t170602-bdr-conflct-w-70-d-expected.txt
- platform/gtk/css2.1/t170602-bdr-conflct-w-71-d-expected.png
- platform/gtk/css2.1/t170602-bdr-conflct-w-71-d-expected.txt
- platform/gtk/css2.1/t170602-bdr-conflct-w-74-d-expected.png
- platform/gtk/css2.1/t170602-bdr-conflct-w-74-d-expected.txt
- platform/gtk/css2.1/t170602-bdr-conflct-w-84-d-expected.png
- platform/gtk/css2.1/t170602-bdr-conflct-w-84-d-expected.txt
- platform/gtk/css2.1/t170602-bdr-conflct-w-85-d-expected.png
- platform/gtk/css2.1/t170602-bdr-conflct-w-85-d-expected.txt
- platform/gtk/css2.1/t170602-bdr-conflct-w-94-d-expected.png
- platform/gtk/css2.1/t170602-bdr-conflct-w-94-d-expected.txt
- platform/gtk/css2.1/tables/table-anonymous-objects-177-expected.txt
- platform/gtk/css2.1/tables/table-anonymous-objects-178-expected.txt
- platform/gtk/css2.1/tables/table-anonymous-objects-179-expected.txt
- platform/gtk/css2.1/tables/table-anonymous-objects-180-expected.txt
- platform/gtk/css2.1/tables/table-anonymous-objects-181-expected.txt
- platform/gtk/css2.1/tables/table-anonymous-objects-189-expected.txt
- platform/gtk/css2.1/tables/table-anonymous-objects-190-expected.txt
- platform/gtk/css2.1/tables/table-anonymous-objects-191-expected.txt
- platform/gtk/css2.1/tables/table-anonymous-objects-192-expected.txt
- platform/gtk/css2.1/tables/table-anonymous-objects-193-expected.txt
- platform/gtk/css2.1/tables/table-anonymous-objects-194-expected.txt
- platform/gtk/css2.1/tables/table-anonymous-objects-195-expected.txt
- platform/gtk/css2.1/tables/table-anonymous-objects-196-expected.txt
- platform/gtk/css2.1/tables/table-anonymous-objects-205-expected.txt
- platform/gtk/css2.1/tables/table-anonymous-objects-206-expected.txt
- platform/gtk/css3/css3-modsel-33-expected.png
- platform/gtk/css3/css3-modsel-33-expected.txt
- platform/gtk/css3/selectors3/html/css3-modsel-18-expected.png
- platform/gtk/css3/selectors3/html/css3-modsel-18-expected.txt
- platform/gtk/css3/selectors3/html/css3-modsel-29-expected.png
- platform/gtk/css3/selectors3/html/css3-modsel-29-expected.txt
- platform/gtk/css3/selectors3/html/css3-modsel-29b-expected.png
- platform/gtk/css3/selectors3/html/css3-modsel-29b-expected.txt
- platform/gtk/css3/selectors3/html/css3-modsel-33-expected.png
- platform/gtk/css3/selectors3/html/css3-modsel-33-expected.txt
- platform/gtk/css3/selectors3/html/css3-modsel-73-expected.png
- platform/gtk/css3/selectors3/html/css3-modsel-73-expected.txt
- platform/gtk/css3/selectors3/html/css3-modsel-73b-expected.png
- platform/gtk/css3/selectors3/html/css3-modsel-73b-expected.txt
- platform/gtk/css3/selectors3/html/css3-modsel-77-expected.png
- platform/gtk/css3/selectors3/html/css3-modsel-77-expected.txt
- platform/gtk/css3/selectors3/html/css3-modsel-77b-expected.png
- platform/gtk/css3/selectors3/html/css3-modsel-77b-expected.txt
- platform/gtk/css3/selectors3/xhtml/css3-modsel-18-expected.png
- platform/gtk/css3/selectors3/xhtml/css3-modsel-18-expected.txt
- platform/gtk/css3/selectors3/xhtml/css3-modsel-29-expected.png
- platform/gtk/css3/selectors3/xhtml/css3-modsel-29-expected.txt
- platform/gtk/css3/selectors3/xhtml/css3-modsel-29b-expected.png
- platform/gtk/css3/selectors3/xhtml/css3-modsel-29b-expected.txt
- platform/gtk/css3/selectors3/xhtml/css3-modsel-33-expected.png
- platform/gtk/css3/selectors3/xhtml/css3-modsel-33-expected.txt
- platform/gtk/css3/selectors3/xhtml/css3-modsel-73-expected.png
- platform/gtk/css3/selectors3/xhtml/css3-modsel-73-expected.txt
- platform/gtk/css3/selectors3/xhtml/css3-modsel-73b-expected.png
- platform/gtk/css3/selectors3/xhtml/css3-modsel-73b-expected.txt
- platform/gtk/css3/selectors3/xhtml/css3-modsel-77-expected.png
- platform/gtk/css3/selectors3/xhtml/css3-modsel-77-expected.txt
- platform/gtk/css3/selectors3/xhtml/css3-modsel-77b-expected.png
- platform/gtk/css3/selectors3/xhtml/css3-modsel-77b-expected.txt
- platform/gtk/css3/selectors3/xml/css3-modsel-18-expected.png
- platform/gtk/css3/selectors3/xml/css3-modsel-18-expected.txt
- platform/gtk/css3/selectors3/xml/css3-modsel-29-expected.png
- platform/gtk/css3/selectors3/xml/css3-modsel-29-expected.txt
- platform/gtk/css3/selectors3/xml/css3-modsel-29b-expected.png
- platform/gtk/css3/selectors3/xml/css3-modsel-29b-expected.txt
- platform/gtk/css3/selectors3/xml/css3-modsel-33-expected.png
- platform/gtk/css3/selectors3/xml/css3-modsel-33-expected.txt
- platform/gtk/css3/selectors3/xml/css3-modsel-73-expected.png
- platform/gtk/css3/selectors3/xml/css3-modsel-73-expected.txt
- platform/gtk/css3/selectors3/xml/css3-modsel-73b-expected.png
- platform/gtk/css3/selectors3/xml/css3-modsel-73b-expected.txt
- platform/gtk/css3/selectors3/xml/css3-modsel-77-expected.png
- platform/gtk/css3/selectors3/xml/css3-modsel-77-expected.txt
- platform/gtk/css3/selectors3/xml/css3-modsel-77b-expected.png
- platform/gtk/css3/selectors3/xml/css3-modsel-77b-expected.txt
- platform/gtk/editing/deleting/4922367-expected.txt
- platform/gtk/editing/deleting/5126166-expected.png
- platform/gtk/editing/deleting/5126166-expected.txt
- platform/gtk/editing/deleting/5144139-2-expected.png
- platform/gtk/editing/deleting/5144139-2-expected.txt
- platform/gtk/editing/deleting/5206311-1-expected.png
- platform/gtk/editing/deleting/5206311-1-expected.txt
- platform/gtk/editing/deleting/5433862-2-expected.png
- platform/gtk/editing/deleting/5433862-2-expected.txt
- platform/gtk/editing/inserting/paragraph-separator-in-table-1-expected.png
- platform/gtk/editing/inserting/paragraph-separator-in-table-1-expected.txt
- platform/gtk/editing/pasteboard/innerText-inline-table-expected.png
- platform/gtk/editing/pasteboard/innerText-inline-table-expected.txt
- platform/gtk/editing/selection/3690703-2-expected.png
- platform/gtk/editing/selection/3690703-2-expected.txt
- platform/gtk/editing/selection/3690703-expected.png
- platform/gtk/editing/selection/3690703-expected.txt
- platform/gtk/editing/selection/3690719-expected.png
- platform/gtk/editing/selection/3690719-expected.txt
- platform/gtk/editing/selection/5057506-2-expected.png
- platform/gtk/editing/selection/5057506-2-expected.txt
- platform/gtk/editing/selection/5057506-expected.png
- platform/gtk/editing/selection/5057506-expected.txt
- platform/gtk/editing/selection/5131716-1-expected.txt
- platform/gtk/editing/selection/5131716-2-expected.txt
- platform/gtk/editing/selection/5131716-3-expected.txt
- platform/gtk/editing/selection/5131716-4-expected.txt
- platform/gtk/editing/selection/move-by-line-001-expected.png
- platform/gtk/editing/selection/move-by-line-001-expected.txt
- platform/gtk/editing/selection/select-all-004-expected.png
- platform/gtk/editing/selection/select-all-004-expected.txt
- platform/gtk/editing/unsupported-content/table-type-after-expected.png
- platform/gtk/editing/unsupported-content/table-type-after-expected.txt
- platform/gtk/editing/unsupported-content/table-type-before-expected.png
- platform/gtk/editing/unsupported-content/table-type-before-expected.txt
- platform/gtk/fast/block/basic/016-expected.txt
- platform/gtk/fast/block/basic/quirk-percent-height-table-cell-expected.png
- platform/gtk/fast/block/basic/quirk-percent-height-table-cell-expected.txt
- platform/gtk/fast/block/float/015-expected.png
- platform/gtk/fast/block/float/015-expected.txt
- platform/gtk/fast/block/margin-collapse/006-expected.txt
- platform/gtk/fast/block/margin-collapse/010-expected.txt
- platform/gtk/fast/block/margin-collapse/011-expected.txt
- platform/gtk/fast/block/margin-collapse/012-expected.txt
- platform/gtk/fast/block/margin-collapse/015-expected.txt
- platform/gtk/fast/block/margin-collapse/016-expected.txt
- platform/gtk/fast/block/margin-collapse/017-expected.txt
- platform/gtk/fast/block/margin-collapse/018-expected.txt
- platform/gtk/fast/block/margin-collapse/019-expected.png
- platform/gtk/fast/block/margin-collapse/019-expected.txt
- platform/gtk/fast/block/margin-collapse/020-expected.png
- platform/gtk/fast/block/margin-collapse/020-expected.txt
- platform/gtk/fast/block/margin-collapse/021-expected.txt
- platform/gtk/fast/block/margin-collapse/022-expected.txt
- platform/gtk/fast/block/margin-collapse/025-expected.txt
- platform/gtk/fast/block/margin-collapse/032-expected.txt
- platform/gtk/fast/block/margin-collapse/033-expected.txt
- platform/gtk/fast/block/margin-collapse/034-expected.txt
- platform/gtk/fast/block/margin-collapse/041-expected.txt
- platform/gtk/fast/block/margin-collapse/042-expected.txt
- platform/gtk/fast/block/margin-collapse/055-expected.txt
- platform/gtk/fast/block/margin-collapse/056-expected.txt
- platform/gtk/fast/block/margin-collapse/057-expected.txt
- platform/gtk/fast/block/margin-collapse/058-expected.txt
- platform/gtk/fast/block/margin-collapse/059-expected.txt
- platform/gtk/fast/block/margin-collapse/block-inside-inline/006-expected.txt
- platform/gtk/fast/block/margin-collapse/block-inside-inline/010-expected.txt
- platform/gtk/fast/block/margin-collapse/block-inside-inline/011-expected.txt
- platform/gtk/fast/block/margin-collapse/block-inside-inline/012-expected.txt
- platform/gtk/fast/block/margin-collapse/block-inside-inline/015-expected.txt
- platform/gtk/fast/block/margin-collapse/block-inside-inline/016-expected.txt
- platform/gtk/fast/block/margin-collapse/block-inside-inline/017-expected.txt
- platform/gtk/fast/block/margin-collapse/block-inside-inline/018-expected.txt
- platform/gtk/fast/block/margin-collapse/block-inside-inline/019-expected.png
- platform/gtk/fast/block/margin-collapse/block-inside-inline/019-expected.txt
- platform/gtk/fast/block/margin-collapse/block-inside-inline/020-expected.png
- platform/gtk/fast/block/margin-collapse/block-inside-inline/020-expected.txt
- platform/gtk/fast/block/margin-collapse/block-inside-inline/021-expected.txt
- platform/gtk/fast/block/margin-collapse/block-inside-inline/022-expected.txt
- platform/gtk/fast/block/margin-collapse/block-inside-inline/025-expected.txt
- platform/gtk/fast/block/positioning/table-cell-static-position-expected.txt
- platform/gtk/fast/borders/border-antialiasing-expected.png
- platform/gtk/fast/borders/border-antialiasing-expected.txt
- platform/gtk/fast/borders/border-radius-different-width-001-expected.png
- platform/gtk/fast/borders/border-radius-different-width-001-expected.txt
- platform/gtk/fast/borders/table-borders-expected.png
- platform/gtk/fast/borders/table-borders-expected.txt
- platform/gtk/fast/css-generated-content/first-letter-in-nested-before-expected.txt
- platform/gtk/fast/css-generated-content/first-letter-in-nested-before-table-expected.txt
- platform/gtk/fast/css-generated-content/nested-tables-with-before-after-content-crash-expected.txt
- platform/gtk/fast/css-generated-content/table-cell-before-after-child-add-expected.txt
- platform/gtk/fast/css-generated-content/table-parts-before-and-after-expected.txt
- platform/gtk/fast/css-generated-content/table-row-group-with-before-expected.png
- platform/gtk/fast/css-generated-content/table-row-group-with-before-expected.txt
- platform/gtk/fast/css-generated-content/table-row-with-before-expected.png
- platform/gtk/fast/css-generated-content/table-row-with-before-expected.txt
- platform/gtk/fast/css-generated-content/table-with-before-expected.png
- platform/gtk/fast/css-generated-content/table-with-before-expected.txt
- platform/gtk/fast/css/003-expected.txt
- platform/gtk/fast/css/absolute-poition-in-rtl-parent-expected.txt
- platform/gtk/fast/css/acid2-expected.png
- platform/gtk/fast/css/acid2-expected.txt
- platform/gtk/fast/css/acid2-pixel-expected.png
- platform/gtk/fast/css/acid2-pixel-expected.txt
- platform/gtk/fast/css/bidi-override-in-anonymous-block-expected.png
- platform/gtk/fast/css/bidi-override-in-anonymous-block-expected.txt
- platform/gtk/fast/css/box-shadow-and-border-radius-expected.png
- platform/gtk/fast/css/box-shadow-and-border-radius-expected.txt
- platform/gtk/fast/css/caption-width-absolute-position-expected.txt
- platform/gtk/fast/css/caption-width-absolute-position-offset-top-expected.txt
- platform/gtk/fast/css/caption-width-fixed-position-expected.txt
- platform/gtk/fast/css/caption-width-fixed-position-offset-top-expected.txt
- platform/gtk/fast/css/caption-width-relative-position-expected.txt
- platform/gtk/fast/css/caption-width-relative-position-offset-top-expected.txt
- platform/gtk/fast/css/css3-nth-child-expected.png
- platform/gtk/fast/css/css3-nth-child-expected.txt
- platform/gtk/fast/css/focus-ring-detached-expected.png
- platform/gtk/fast/css/focus-ring-detached-expected.txt
- platform/gtk/fast/css/focus-ring-multiline-expected.png
- platform/gtk/fast/css/focus-ring-multiline-expected.txt
- platform/gtk/fast/css/h1-in-section-elements-expected.png
- platform/gtk/fast/css/h1-in-section-elements-expected.txt
- platform/gtk/fast/css/min-width-with-spanned-cell-expected.txt
- platform/gtk/fast/css/percentage-non-integer-expected.png
- platform/gtk/fast/css/percentage-non-integer-expected.txt
- platform/gtk/fast/css/table-text-align-quirk-expected.txt
- platform/gtk/fast/css/table-text-align-strict-expected.txt
- platform/gtk/fast/dom/34176-expected.png
- platform/gtk/fast/dom/34176-expected.txt
- platform/gtk/fast/dom/HTMLTableElement/colSpan-expected.png
- platform/gtk/fast/dom/HTMLTableElement/colSpan-expected.txt
- platform/gtk/fast/dom/HTMLTableElement/createCaption-expected.png
- platform/gtk/fast/dom/HTMLTableElement/createCaption-expected.txt
- platform/gtk/fast/dom/row-inner-text-expected.png
- platform/gtk/fast/dom/row-inner-text-expected.txt
- platform/gtk/fast/dynamic/001-expected.txt
- platform/gtk/fast/dynamic/containing-block-change-expected.png
- platform/gtk/fast/dynamic/containing-block-change-expected.txt
- platform/gtk/fast/dynamic/float-withdrawal-expected.png
- platform/gtk/fast/dynamic/float-withdrawal-expected.txt
- platform/gtk/fast/dynamic/insert-before-table-part-in-continuation-expected.png
- platform/gtk/fast/dynamic/insert-before-table-part-in-continuation-expected.txt
- platform/gtk/fast/dynamic/subtree-table-cell-height-expected.txt
- platform/gtk/fast/encoding/utf-16-big-endian-expected.png
- platform/gtk/fast/encoding/utf-16-big-endian-expected.txt
- platform/gtk/fast/encoding/utf-16-little-endian-expected.png
- platform/gtk/fast/encoding/utf-16-little-endian-expected.txt
- platform/gtk/fast/forms/001-expected.png
- platform/gtk/fast/forms/001-expected.txt
- platform/gtk/fast/forms/005-expected.txt
- platform/gtk/fast/forms/basic-buttons-expected.png
- platform/gtk/fast/forms/basic-buttons-expected.txt
- platform/gtk/fast/forms/form-element-geometry-expected.png
- platform/gtk/fast/forms/form-element-geometry-expected.txt
- platform/gtk/fast/forms/form-hides-table-expected.png
- platform/gtk/fast/forms/form-hides-table-expected.txt
- platform/gtk/fast/forms/form-in-malformed-markup-expected.txt
- platform/gtk/fast/forms/formmove3-expected.png
- platform/gtk/fast/forms/formmove3-expected.txt
- platform/gtk/fast/forms/input-table-expected.png
- platform/gtk/fast/forms/input-table-expected.txt
- platform/gtk/fast/forms/listbox-bidi-align-expected.png
- platform/gtk/fast/forms/listbox-bidi-align-expected.txt
- platform/gtk/fast/forms/preserveFormDuringResidualStyle-expected.txt
- platform/gtk/fast/forms/select-dirty-parent-pref-widths-expected.png
- platform/gtk/fast/forms/select-dirty-parent-pref-widths-expected.txt
- platform/gtk/fast/html/details-writing-mode-expected.png
- platform/gtk/fast/html/details-writing-mode-expected.txt
- platform/gtk/fast/inline-block/001-expected.txt
- platform/gtk/fast/inline-block/overflow-clip-expected.png
- platform/gtk/fast/inline-block/overflow-clip-expected.txt
- platform/gtk/fast/invalid/012-expected.txt
- platform/gtk/fast/invalid/018-expected.txt
- platform/gtk/fast/lists/004-expected.png
- platform/gtk/fast/lists/004-expected.txt
- platform/gtk/fast/lists/list-marker-before-content-table-expected.png
- platform/gtk/fast/lists/list-marker-before-content-table-expected.txt
- platform/gtk/fast/multicol/span/before-child-anonymous-column-block-expected.txt
- platform/gtk/fast/multicol/table-vertical-align-expected.png
- platform/gtk/fast/overflow/002-expected.png
- platform/gtk/fast/overflow/002-expected.txt
- platform/gtk/fast/overflow/overflow-rtl-expected.png
- platform/gtk/fast/overflow/overflow-rtl-expected.txt
- platform/gtk/fast/overflow/overflow-rtl-vertical-expected.png
- platform/gtk/fast/overflow/overflow-rtl-vertical-expected.txt
- platform/gtk/fast/overflow/table-overflow-float-expected.txt
- platform/gtk/fast/reflections/table-cell-expected.txt
- platform/gtk/fast/repaint/block-selection-gap-in-table-cell-expected.txt
- platform/gtk/fast/repaint/float-overflow-expected.png
- platform/gtk/fast/repaint/float-overflow-expected.txt
- platform/gtk/fast/repaint/float-overflow-right-expected.png
- platform/gtk/fast/repaint/float-overflow-right-expected.txt
- platform/gtk/fast/repaint/subtree-root-clip-3-expected.txt
- platform/gtk/fast/repaint/table-cell-collapsed-border-expected.png
- platform/gtk/fast/repaint/table-cell-collapsed-border-expected.txt
- platform/gtk/fast/repaint/table-cell-collapsed-border-scroll-expected.txt
- platform/gtk/fast/repaint/table-cell-move-expected.png
- platform/gtk/fast/repaint/table-cell-move-expected.txt
- platform/gtk/fast/repaint/table-cell-overflow-expected.txt
- platform/gtk/fast/repaint/table-cell-vertical-overflow-expected.png
- platform/gtk/fast/repaint/table-cell-vertical-overflow-expected.txt
- platform/gtk/fast/repaint/table-col-background-expected.txt
- platform/gtk/fast/repaint/table-collapsed-border-expected.txt
- platform/gtk/fast/repaint/table-extra-bottom-grow-expected.png
- platform/gtk/fast/repaint/table-extra-bottom-grow-expected.txt
- platform/gtk/fast/repaint/table-outer-border-expected.txt
- platform/gtk/fast/repaint/table-row-expected.txt
- platform/gtk/fast/repaint/table-section-overflow-expected.txt
- platform/gtk/fast/repaint/table-section-repaint-expected.txt
- platform/gtk/fast/repaint/table-two-pass-layout-overpaint-expected.png
- platform/gtk/fast/repaint/table-two-pass-layout-overpaint-expected.txt
- platform/gtk/fast/repaint/table-writing-modes-h-expected.txt
- platform/gtk/fast/repaint/table-writing-modes-v-expected.txt
- platform/gtk/fast/replaced/005-expected.png
- platform/gtk/fast/replaced/005-expected.txt
- platform/gtk/fast/replaced/percent-height-in-anonymous-block-in-table-expected.png
- platform/gtk/fast/replaced/percent-height-in-anonymous-block-in-table-expected.txt
- platform/gtk/fast/replaced/selection-rect-in-table-cell-expected.png
- platform/gtk/fast/replaced/selection-rect-in-table-cell-expected.txt
- platform/gtk/fast/replaced/table-percent-height-positioned-expected.txt
- platform/gtk/fast/replaced/width100percent-checkbox-expected.png
- platform/gtk/fast/replaced/width100percent-checkbox-expected.txt
- platform/gtk/fast/replaced/width100percent-image-expected.png
- platform/gtk/fast/replaced/width100percent-image-expected.txt
- platform/gtk/fast/replaced/width100percent-menulist-expected.png
- platform/gtk/fast/replaced/width100percent-menulist-expected.txt
- platform/gtk/fast/replaced/width100percent-radio-expected.png
- platform/gtk/fast/replaced/width100percent-radio-expected.txt
- platform/gtk/fast/replaced/width100percent-searchfield-expected.png
- platform/gtk/fast/replaced/width100percent-searchfield-expected.txt
- platform/gtk/fast/replaced/width100percent-textarea-expected.png
- platform/gtk/fast/replaced/width100percent-textarea-expected.txt
- platform/gtk/fast/replaced/width100percent-textfield-expected.png
- platform/gtk/fast/replaced/width100percent-textfield-expected.txt
- platform/gtk/fast/selectors/077-expected.png
- platform/gtk/fast/selectors/077-expected.txt
- platform/gtk/fast/selectors/077b-expected.png
- platform/gtk/fast/selectors/077b-expected.txt
- platform/gtk/fast/table/002-expected.png
- platform/gtk/fast/table/002-expected.txt
- platform/gtk/fast/table/005-expected.png
- platform/gtk/fast/table/005-expected.txt
- platform/gtk/fast/table/007-expected.png
- platform/gtk/fast/table/007-expected.txt
- platform/gtk/fast/table/008-expected.txt
- platform/gtk/fast/table/009-expected.png
- platform/gtk/fast/table/009-expected.txt
- platform/gtk/fast/table/012-expected.txt
- platform/gtk/fast/table/013-expected.png
- platform/gtk/fast/table/013-expected.txt
- platform/gtk/fast/table/021-expected.png
- platform/gtk/fast/table/021-expected.txt
- platform/gtk/fast/table/023-expected.png
- platform/gtk/fast/table/023-expected.txt
- platform/gtk/fast/table/024-expected.txt
- platform/gtk/fast/table/025-expected.png
- platform/gtk/fast/table/025-expected.txt
- platform/gtk/fast/table/028-expected.png
- platform/gtk/fast/table/028-expected.txt
- platform/gtk/fast/table/028-vertical-expected.png
- platform/gtk/fast/table/028-vertical-expected.txt
- platform/gtk/fast/table/029-expected.png
- platform/gtk/fast/table/029-expected.txt
- platform/gtk/fast/table/031-expected.txt
- platform/gtk/fast/table/032-expected.txt
- platform/gtk/fast/table/034-expected.txt
- platform/gtk/fast/table/038-expected.png
- platform/gtk/fast/table/038-expected.txt
- platform/gtk/fast/table/038-vertical-expected.png
- platform/gtk/fast/table/038-vertical-expected.txt
- platform/gtk/fast/table/039-expected.png
- platform/gtk/fast/table/039-expected.txt
- platform/gtk/fast/table/040-expected.png
- platform/gtk/fast/table/040-expected.txt
- platform/gtk/fast/table/040-vertical-expected.png
- platform/gtk/fast/table/040-vertical-expected.txt
- platform/gtk/fast/table/100-percent-cell-width-expected.png
- platform/gtk/fast/table/100-percent-cell-width-expected.txt
- platform/gtk/fast/table/add-before-anonymous-child-expected.png
- platform/gtk/fast/table/add-before-anonymous-child-expected.txt
- platform/gtk/fast/table/border-collapsing/001-expected.png
- platform/gtk/fast/table/border-collapsing/001-expected.txt
- platform/gtk/fast/table/border-collapsing/001-vertical-expected.png
- platform/gtk/fast/table/border-collapsing/001-vertical-expected.txt
- platform/gtk/fast/table/border-collapsing/002-expected.png
- platform/gtk/fast/table/border-collapsing/002-expected.txt
- platform/gtk/fast/table/border-collapsing/002-vertical-expected.png
- platform/gtk/fast/table/border-collapsing/002-vertical-expected.txt
- platform/gtk/fast/table/border-collapsing/003-expected.txt
- platform/gtk/fast/table/border-collapsing/003-vertical-expected.txt
- platform/gtk/fast/table/border-collapsing/004-expected.png
- platform/gtk/fast/table/border-collapsing/004-expected.txt
- platform/gtk/fast/table/border-collapsing/004-vertical-expected.png
- platform/gtk/fast/table/border-collapsing/004-vertical-expected.txt
- platform/gtk/fast/table/border-collapsing/border-collapsing-head-foot-expected.png
- platform/gtk/fast/table/border-collapsing/border-collapsing-head-foot-expected.txt
- platform/gtk/fast/table/border-collapsing/border-collapsing-head-foot-vertical-expected.png
- platform/gtk/fast/table/border-collapsing/border-collapsing-head-foot-vertical-expected.txt
- platform/gtk/fast/table/border-collapsing/bug14274-expected.txt
- platform/gtk/fast/table/border-collapsing/cached-69296-expected.png
- platform/gtk/fast/table/border-collapsing/cached-69296-expected.txt
- platform/gtk/fast/table/border-collapsing/cached-cell-append-expected.png
- platform/gtk/fast/table/border-collapsing/cached-cell-append-expected.txt
- platform/gtk/fast/table/border-collapsing/cached-cell-remove-expected.png
- platform/gtk/fast/table/border-collapsing/cached-cell-remove-expected.txt
- platform/gtk/fast/table/border-collapsing/cached-change-cell-border-color-expected.txt
- platform/gtk/fast/table/border-collapsing/cached-change-cell-border-width-expected.png
- platform/gtk/fast/table/border-collapsing/cached-change-cell-border-width-expected.txt
- platform/gtk/fast/table/border-collapsing/cached-change-cell-sl-border-color-expected.txt
- platform/gtk/fast/table/border-collapsing/cached-change-col-border-color-expected.txt
- platform/gtk/fast/table/border-collapsing/cached-change-col-border-width-expected.png
- platform/gtk/fast/table/border-collapsing/cached-change-col-border-width-expected.txt
- platform/gtk/fast/table/border-collapsing/cached-change-colgroup-border-color-expected.png
- platform/gtk/fast/table/border-collapsing/cached-change-colgroup-border-color-expected.txt
- platform/gtk/fast/table/border-collapsing/cached-change-colgroup-border-width-expected.png
- platform/gtk/fast/table/border-collapsing/cached-change-colgroup-border-width-expected.txt
- platform/gtk/fast/table/border-collapsing/cached-change-row-border-color-expected.png
- platform/gtk/fast/table/border-collapsing/cached-change-row-border-color-expected.txt
- platform/gtk/fast/table/border-collapsing/cached-change-row-border-width-expected.txt
- platform/gtk/fast/table/border-collapsing/cached-change-table-border-color-expected.txt
- platform/gtk/fast/table/border-collapsing/cached-change-table-border-width-expected.txt
- platform/gtk/fast/table/border-collapsing/cached-change-tbody-border-color-expected.png
- platform/gtk/fast/table/border-collapsing/cached-change-tbody-border-color-expected.txt
- platform/gtk/fast/table/border-collapsing/cached-change-tbody-border-width-expected.txt
- platform/gtk/fast/table/border-collapsing/collapsed-borders-adjoining-sections-vertical-rl-expected.txt
- platform/gtk/fast/table/border-collapsing/collapsed-borders-painted-once-on-inner-cells-expected.txt
- platform/gtk/fast/table/border-collapsing/equal-precedence-resolution-expected.txt
- platform/gtk/fast/table/border-collapsing/equal-precedence-resolution-vertical-expected.txt
- platform/gtk/fast/table/border-collapsing/rtl-border-collapsing-expected.png
- platform/gtk/fast/table/border-collapsing/rtl-border-collapsing-expected.txt
- platform/gtk/fast/table/border-collapsing/rtl-border-collapsing-vertical-expected.png
- platform/gtk/fast/table/border-collapsing/rtl-border-collapsing-vertical-expected.txt
- platform/gtk/fast/table/caption-relayout-expected.txt
- platform/gtk/fast/table/cell-absolute-child-expected.png
- platform/gtk/fast/table/cell-absolute-child-expected.txt
- platform/gtk/fast/table/cell-width-auto-expected.txt
- platform/gtk/fast/table/colspan-with-all-percent-cells-expected.png
- platform/gtk/fast/table/colspan-with-all-percent-cells-expected.txt
- platform/gtk/fast/table/colspanMinWidth-expected.png
- platform/gtk/fast/table/colspanMinWidth-expected.txt
- platform/gtk/fast/table/colspanMinWidth-vertical-expected.png
- platform/gtk/fast/table/colspanMinWidth-vertical-expected.txt
- platform/gtk/fast/table/dynamic-cellpadding-expected.png
- platform/gtk/fast/table/dynamic-cellpadding-expected.txt
- platform/gtk/fast/table/edge-offsets-expected.png
- platform/gtk/fast/table/edge-offsets-expected.txt
- platform/gtk/fast/table/empty-cells-expected.png
- platform/gtk/fast/table/empty-cells-expected.txt
- platform/gtk/fast/table/frame-and-rules-expected.png
- platform/gtk/fast/table/frame-and-rules-expected.txt
- platform/gtk/fast/table/giantRowspan-expected.png
- platform/gtk/fast/table/giantRowspan-expected.txt
- platform/gtk/fast/table/growCellForImageQuirk-expected.txt
- platform/gtk/fast/table/growCellForImageQuirk-vertical-expected.txt
- platform/gtk/fast/table/height-percent-test-expected.txt
- platform/gtk/fast/table/height-percent-test-vertical-expected.txt
- platform/gtk/fast/table/invisible-cell-background-expected.txt
- platform/gtk/fast/table/large-width-expected.png
- platform/gtk/fast/table/large-width-expected.txt
- platform/gtk/fast/table/max-width-integer-overflow-expected.txt
- platform/gtk/fast/table/mozilla-bug10296-vertical-align-1-expected.txt
- platform/gtk/fast/table/mozilla-bug10296-vertical-align-2-expected.txt
- platform/gtk/fast/table/nobr-expected.png
- platform/gtk/fast/table/nobr-expected.txt
- platform/gtk/fast/table/overflowHidden-expected.png
- platform/gtk/fast/table/overflowHidden-expected.txt
- platform/gtk/fast/table/percent-heights-expected.png
- platform/gtk/fast/table/percent-heights-expected.txt
- platform/gtk/fast/table/percent-widths-stretch-expected.png
- platform/gtk/fast/table/percent-widths-stretch-expected.txt
- platform/gtk/fast/table/percent-widths-stretch-vertical-expected.txt
- platform/gtk/fast/table/prepend-in-anonymous-table-expected.png
- platform/gtk/fast/table/prepend-in-anonymous-table-expected.txt
- platform/gtk/fast/table/relative-position-containment-expected.txt
- platform/gtk/fast/table/relative-position-offsets-expected.txt
- platform/gtk/fast/table/relative-position-stacking-expected.txt
- platform/gtk/fast/table/replaced-percent-height-expected.png
- platform/gtk/fast/table/replaced-percent-height-expected.txt
- platform/gtk/fast/table/row-height-recalc-expected.png
- platform/gtk/fast/table/row-height-recalc-expected.txt
- platform/gtk/fast/table/rowspan-paint-order-expected.png
- platform/gtk/fast/table/rowspan-paint-order-expected.txt
- platform/gtk/fast/table/rowspan-paint-order-vertical-expected.png
- platform/gtk/fast/table/rowspan-paint-order-vertical-expected.txt
- platform/gtk/fast/table/simple_paint-expected.txt
- platform/gtk/fast/table/spanOverlapRepaint-expected.png
- platform/gtk/fast/table/spanOverlapRepaint-expected.txt
- platform/gtk/fast/table/stale-grid-crash-expected.png
- platform/gtk/fast/table/stale-grid-crash-expected.txt
- platform/gtk/fast/table/table-anonymous-cell-bug-expected.txt
- platform/gtk/fast/table/table-anonymous-row-bug-expected.txt
- platform/gtk/fast/table/table-anonymous-section-bug-expected.txt
- platform/gtk/fast/table/table-before-child-style-update-expected.txt
- platform/gtk/fast/table/table-cell-before-after-content-around-table-block-expected.txt
- platform/gtk/fast/table/table-cell-before-after-content-around-table-expected.txt
- platform/gtk/fast/table/table-cell-before-after-content-around-table-row-expected.txt
- platform/gtk/fast/table/table-cell-before-child-in-table-expected.txt
- platform/gtk/fast/table/table-cell-split-expected.txt
- platform/gtk/fast/table/table-display-types-expected.txt
- platform/gtk/fast/table/table-display-types-strict-expected.txt
- platform/gtk/fast/table/table-display-types-vertical-expected.txt
- platform/gtk/fast/table/table-insert-before-non-anonymous-block-expected.txt
- platform/gtk/fast/table/table-row-before-after-content-around-block-expected.txt
- platform/gtk/fast/table/table-row-before-after-content-around-table-cell-expected.txt
- platform/gtk/fast/table/table-row-before-after-content-around-table-expected.txt
- platform/gtk/fast/table/table-row-before-child-style-update-expected.txt
- platform/gtk/fast/table/table-row-outline-paint-expected.png
- platform/gtk/fast/table/table-row-outline-paint-expected.txt
- platform/gtk/fast/table/table-row-split2-expected.txt
- platform/gtk/fast/table/table-row-style-not-updated-expected.txt
- platform/gtk/fast/table/table-row-style-not-updated-with-after-content-expected.txt
- platform/gtk/fast/table/table-row-style-not-updated-with-before-content-expected.txt
- platform/gtk/fast/table/table-section-split2-expected.txt
- platform/gtk/fast/table/table-split-expected.txt
- platform/gtk/fast/table/table-split2-expected.txt
- platform/gtk/fast/table/table-style-not-updated-expected.txt
- platform/gtk/fast/table/wide-colspan-expected.txt
- platform/gtk/fast/table/wide-column-expected.txt
- platform/gtk/fast/text/atsui-negative-spacing-features-expected.png
- platform/gtk/fast/text/atsui-negative-spacing-features-expected.txt
- platform/gtk/fast/text/atsui-spacing-features-expected.png
- platform/gtk/fast/text/atsui-spacing-features-expected.txt
- platform/gtk/fast/text/basic/generic-family-reset-expected.png
- platform/gtk/fast/text/basic/generic-family-reset-expected.txt
- platform/gtk/fast/text/international/003-expected.png
- platform/gtk/fast/text/international/003-expected.txt
- platform/gtk/fast/text/international/bidi-LDB-2-CSS-expected.png
- platform/gtk/fast/text/international/bidi-LDB-2-CSS-expected.txt
- platform/gtk/fast/text/international/bidi-LDB-2-HTML-expected.png
- platform/gtk/fast/text/international/bidi-LDB-2-HTML-expected.txt
- platform/gtk/fast/text/international/bidi-LDB-2-formatting-characters-expected.png
- platform/gtk/fast/text/international/bidi-LDB-2-formatting-characters-expected.txt
- platform/gtk/fast/text/international/bidi-override-expected.txt
- platform/gtk/fast/text/wbr-expected.txt
- platform/gtk/fast/text/whitespace/002-expected.txt
- platform/gtk/fast/text/whitespace/003-expected.txt
- platform/gtk/fast/text/whitespace/004-expected.txt
- platform/gtk/fast/text/whitespace/005-expected.txt
- platform/gtk/fast/text/whitespace/010-expected.txt
- platform/gtk/fast/text/whitespace/011-expected.txt
- platform/gtk/fast/text/whitespace/013-expected.txt
- platform/gtk/fast/text/whitespace/014-expected.txt
- platform/gtk/fast/text/whitespace/015-expected.txt
- platform/gtk/fast/text/whitespace/016-expected.txt
- platform/gtk/fast/text/whitespace/025-expected.txt
- platform/gtk/fast/text/whitespace/026-expected.txt
- platform/gtk/fast/writing-mode/table-percent-width-quirk-expected.txt
- platform/gtk/fast/writing-mode/vertical-align-table-baseline-expected.png
- platform/gtk/fast/writing-mode/vertical-align-table-baseline-expected.txt
- platform/gtk/http/tests/misc/acid2-expected.png
- platform/gtk/http/tests/misc/acid2-pixel-expected.png
- platform/gtk/http/tests/misc/object-embedding-svg-delayed-size-negotiation-2-expected.png
- platform/gtk/http/tests/misc/object-embedding-svg-delayed-size-negotiation-2-expected.txt
- platform/gtk/ietestcenter/css3/bordersbackgrounds/background_properties_greater_than_images-expected.txt
- platform/gtk/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-006-expected.png
- platform/gtk/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-006-expected.txt
- platform/gtk/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-007-expected.png
- platform/gtk/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-007-expected.txt
- platform/gtk/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-008-expected.png
- platform/gtk/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-008-expected.txt
- platform/gtk/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-009-expected.txt
- platform/gtk/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-011-expected.png
- platform/gtk/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-011-expected.txt
- platform/gtk/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-012-expected.txt
- platform/gtk/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-013-expected.txt
- platform/gtk/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-014-expected.txt
- platform/gtk/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-015-expected.txt
- platform/gtk/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-016-expected.txt
- platform/gtk/ietestcenter/css3/bordersbackgrounds/border-radius-different-width-001-expected.png
- platform/gtk/ietestcenter/css3/bordersbackgrounds/border-radius-different-width-001-expected.txt
- platform/gtk/ietestcenter/css3/bordersbackgrounds/border-radius-shorthand-001-expected.png
- platform/gtk/ietestcenter/css3/bordersbackgrounds/border-radius-shorthand-001-expected.txt
- platform/gtk/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-001-expected.png
- platform/gtk/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-001-expected.txt
- platform/gtk/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-002-expected.png
- platform/gtk/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-002-expected.txt
- platform/gtk/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-004-expected.png
- platform/gtk/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-004-expected.txt
- platform/gtk/ietestcenter/css3/bordersbackgrounds/border-top-right-radius-values-004-expected.png
- platform/gtk/ietestcenter/css3/bordersbackgrounds/border-top-right-radius-values-004-expected.txt
- platform/gtk/ietestcenter/css3/bordersbackgrounds/none-as-image-layer-expected.txt
- platform/gtk/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.png
- platform/gtk/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.txt
- platform/gtk/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png
- platform/gtk/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.txt
- platform/gtk/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png
- platform/gtk/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.txt
- platform/gtk/tables/layering/paint-test-layering-1-expected.png
- platform/gtk/tables/layering/paint-test-layering-1-expected.txt
- platform/gtk/tables/layering/paint-test-layering-2-expected.png
- platform/gtk/tables/layering/paint-test-layering-2-expected.txt
- platform/gtk/tables/mozilla/bugs/bug10009-expected.png
- platform/gtk/tables/mozilla/bugs/bug10009-expected.txt
- platform/gtk/tables/mozilla/bugs/bug101201-expected.png
- platform/gtk/tables/mozilla/bugs/bug101201-expected.txt
- platform/gtk/tables/mozilla/bugs/bug101674-expected.png
- platform/gtk/tables/mozilla/bugs/bug101674-expected.txt
- platform/gtk/tables/mozilla/bugs/bug10296-1-expected.txt
- platform/gtk/tables/mozilla/bugs/bug1055-1-expected.png
- platform/gtk/tables/mozilla/bugs/bug1055-1-expected.txt
- platform/gtk/tables/mozilla/bugs/bug10565-expected.png
- platform/gtk/tables/mozilla/bugs/bug10565-expected.txt
- platform/gtk/tables/mozilla/bugs/bug10633-expected.png
- platform/gtk/tables/mozilla/bugs/bug10633-expected.txt
- platform/gtk/tables/mozilla/bugs/bug1067-1-expected.txt
- platform/gtk/tables/mozilla/bugs/bug1067-2-expected.png
- platform/gtk/tables/mozilla/bugs/bug1067-2-expected.txt
- platform/gtk/tables/mozilla/bugs/bug106795-expected.png
- platform/gtk/tables/mozilla/bugs/bug106795-expected.txt
- platform/gtk/tables/mozilla/bugs/bug106816-expected.png
- platform/gtk/tables/mozilla/bugs/bug106816-expected.txt
- platform/gtk/tables/mozilla/bugs/bug113235-1-expected.png
- platform/gtk/tables/mozilla/bugs/bug113235-1-expected.txt
- platform/gtk/tables/mozilla/bugs/bug113424-expected.png
- platform/gtk/tables/mozilla/bugs/bug113424-expected.txt
- platform/gtk/tables/mozilla/bugs/bug1163-1-expected.txt
- platform/gtk/tables/mozilla/bugs/bug1188-expected.png
- platform/gtk/tables/mozilla/bugs/bug1188-expected.txt
- platform/gtk/tables/mozilla/bugs/bug12008-expected.png
- platform/gtk/tables/mozilla/bugs/bug12008-expected.txt
- platform/gtk/tables/mozilla/bugs/bug120107-expected.txt
- platform/gtk/tables/mozilla/bugs/bug120364-expected.png
- platform/gtk/tables/mozilla/bugs/bug120364-expected.txt
- platform/gtk/tables/mozilla/bugs/bug1224-expected.png
- platform/gtk/tables/mozilla/bugs/bug1224-expected.txt
- platform/gtk/tables/mozilla/bugs/bug12268-expected.png
- platform/gtk/tables/mozilla/bugs/bug12268-expected.txt
- platform/gtk/tables/mozilla/bugs/bug12709-expected.png
- platform/gtk/tables/mozilla/bugs/bug12709-expected.txt
- platform/gtk/tables/mozilla/bugs/bug1271-expected.txt
- platform/gtk/tables/mozilla/bugs/bug12908-1-expected.png
- platform/gtk/tables/mozilla/bugs/bug12908-1-expected.txt
- platform/gtk/tables/mozilla/bugs/bug12908-2-expected.txt
- platform/gtk/tables/mozilla/bugs/bug12910-2-expected.txt
- platform/gtk/tables/mozilla/bugs/bug1296-expected.png
- platform/gtk/tables/mozilla/bugs/bug1296-expected.txt
- platform/gtk/tables/mozilla/bugs/bug1302-expected.png
- platform/gtk/tables/mozilla/bugs/bug1302-expected.txt
- platform/gtk/tables/mozilla/bugs/bug13169-expected.png
- platform/gtk/tables/mozilla/bugs/bug13169-expected.txt
- platform/gtk/tables/mozilla/bugs/bug1318-expected.png
- platform/gtk/tables/mozilla/bugs/bug1318-expected.txt
- platform/gtk/tables/mozilla/bugs/bug137388-1-expected.png
- platform/gtk/tables/mozilla/bugs/bug137388-1-expected.txt
- platform/gtk/tables/mozilla/bugs/bug137388-2-expected.png
- platform/gtk/tables/mozilla/bugs/bug137388-2-expected.txt
- platform/gtk/tables/mozilla/bugs/bug137388-3-expected.png
- platform/gtk/tables/mozilla/bugs/bug137388-3-expected.txt
- platform/gtk/tables/mozilla/bugs/bug139524-1-expected.png
- platform/gtk/tables/mozilla/bugs/bug139524-1-expected.txt
- platform/gtk/tables/mozilla/bugs/bug139524-2-expected.txt
- platform/gtk/tables/mozilla/bugs/bug139524-3-expected.png
- platform/gtk/tables/mozilla/bugs/bug139524-3-expected.txt
- platform/gtk/tables/mozilla/bugs/bug139524-4-expected.png
- platform/gtk/tables/mozilla/bugs/bug139524-4-expected.txt
- platform/gtk/tables/mozilla/bugs/bug1430-expected.png
- platform/gtk/tables/mozilla/bugs/bug1430-expected.txt
- platform/gtk/tables/mozilla/bugs/bug14323-expected.png
- platform/gtk/tables/mozilla/bugs/bug14323-expected.txt
- platform/gtk/tables/mozilla/bugs/bug1474-expected.png
- platform/gtk/tables/mozilla/bugs/bug14929-expected.png
- platform/gtk/tables/mozilla/bugs/bug14929-expected.txt
- platform/gtk/tables/mozilla/bugs/bug15247-expected.png
- platform/gtk/tables/mozilla/bugs/bug15247-expected.txt
- platform/gtk/tables/mozilla/bugs/bug154780-expected.png
- platform/gtk/tables/mozilla/bugs/bug154780-expected.txt
- platform/gtk/tables/mozilla/bugs/bug15544-expected.png
- platform/gtk/tables/mozilla/bugs/bug15544-expected.txt
- platform/gtk/tables/mozilla/bugs/bug159108-expected.txt
- platform/gtk/tables/mozilla/bugs/bug15933-expected.png
- platform/gtk/tables/mozilla/bugs/bug15933-expected.txt
- platform/gtk/tables/mozilla/bugs/bug16012-expected.txt
- platform/gtk/tables/mozilla/bugs/bug16252-expected.png
- platform/gtk/tables/mozilla/bugs/bug16252-expected.txt
- platform/gtk/tables/mozilla/bugs/bug17138-expected.png
- platform/gtk/tables/mozilla/bugs/bug17138-expected.txt
- platform/gtk/tables/mozilla/bugs/bug175455-4-expected.png
- platform/gtk/tables/mozilla/bugs/bug175455-4-expected.txt
- platform/gtk/tables/mozilla/bugs/bug17548-expected.png
- platform/gtk/tables/mozilla/bugs/bug17548-expected.txt
- platform/gtk/tables/mozilla/bugs/bug17587-expected.png
- platform/gtk/tables/mozilla/bugs/bug17587-expected.txt
- platform/gtk/tables/mozilla/bugs/bug1800-expected.png
- platform/gtk/tables/mozilla/bugs/bug1800-expected.txt
- platform/gtk/tables/mozilla/bugs/bug1802-expected.png
- platform/gtk/tables/mozilla/bugs/bug1802-expected.txt
- platform/gtk/tables/mozilla/bugs/bug1802s-expected.png
- platform/gtk/tables/mozilla/bugs/bug1802s-expected.txt
- platform/gtk/tables/mozilla/bugs/bug1809-expected.png
- platform/gtk/tables/mozilla/bugs/bug1809-expected.txt
- platform/gtk/tables/mozilla/bugs/bug18440-expected.png
- platform/gtk/tables/mozilla/bugs/bug18440-expected.txt
- platform/gtk/tables/mozilla/bugs/bug18664-expected.png
- platform/gtk/tables/mozilla/bugs/bug18664-expected.txt
- platform/gtk/tables/mozilla/bugs/bug18955-expected.png
- platform/gtk/tables/mozilla/bugs/bug18955-expected.txt
- platform/gtk/tables/mozilla/bugs/bug19061-1-expected.png
- platform/gtk/tables/mozilla/bugs/bug19061-1-expected.txt
- platform/gtk/tables/mozilla/bugs/bug19061-2-expected.png
- platform/gtk/tables/mozilla/bugs/bug19061-2-expected.txt
- platform/gtk/tables/mozilla/bugs/bug19356-expected.png
- platform/gtk/tables/mozilla/bugs/bug19356-expected.txt
- platform/gtk/tables/mozilla/bugs/bug20804-expected.png
- platform/gtk/tables/mozilla/bugs/bug20804-expected.txt
- platform/gtk/tables/mozilla/bugs/bug2123-expected.txt
- platform/gtk/tables/mozilla/bugs/bug215629-expected.txt
- platform/gtk/tables/mozilla/bugs/bug219693-1-expected.png
- platform/gtk/tables/mozilla/bugs/bug219693-1-expected.txt
- platform/gtk/tables/mozilla/bugs/bug219693-2-expected.png
- platform/gtk/tables/mozilla/bugs/bug219693-2-expected.txt
- platform/gtk/tables/mozilla/bugs/bug22019-expected.png
- platform/gtk/tables/mozilla/bugs/bug22019-expected.txt
- platform/gtk/tables/mozilla/bugs/bug220536-expected.png
- platform/gtk/tables/mozilla/bugs/bug220536-expected.txt
- platform/gtk/tables/mozilla/bugs/bug222336-expected.txt
- platform/gtk/tables/mozilla/bugs/bug22246-2-expected.png
- platform/gtk/tables/mozilla/bugs/bug22246-2-expected.txt
- platform/gtk/tables/mozilla/bugs/bug22246-2a-expected.png
- platform/gtk/tables/mozilla/bugs/bug22246-2a-expected.txt
- platform/gtk/tables/mozilla/bugs/bug22246-3-expected.png
- platform/gtk/tables/mozilla/bugs/bug22246-3-expected.txt
- platform/gtk/tables/mozilla/bugs/bug22246-3a-expected.png
- platform/gtk/tables/mozilla/bugs/bug22246-3a-expected.txt
- platform/gtk/tables/mozilla/bugs/bug22513-expected.txt
- platform/gtk/tables/mozilla/bugs/bug2296-expected.png
- platform/gtk/tables/mozilla/bugs/bug2296-expected.txt
- platform/gtk/tables/mozilla/bugs/bug23235-expected.png
- platform/gtk/tables/mozilla/bugs/bug23235-expected.txt
- platform/gtk/tables/mozilla/bugs/bug24200-expected.png
- platform/gtk/tables/mozilla/bugs/bug24200-expected.txt
- platform/gtk/tables/mozilla/bugs/bug2479-2-expected.png
- platform/gtk/tables/mozilla/bugs/bug2479-2-expected.txt
- platform/gtk/tables/mozilla/bugs/bug2479-3-expected.txt
- platform/gtk/tables/mozilla/bugs/bug25004-expected.png
- platform/gtk/tables/mozilla/bugs/bug25004-expected.txt
- platform/gtk/tables/mozilla/bugs/bug25074-expected.txt
- platform/gtk/tables/mozilla/bugs/bug25663-expected.png
- platform/gtk/tables/mozilla/bugs/bug25663-expected.txt
- platform/gtk/tables/mozilla/bugs/bug26553-expected.txt
- platform/gtk/tables/mozilla/bugs/bug2684-expected.png
- platform/gtk/tables/mozilla/bugs/bug2684-expected.txt
- platform/gtk/tables/mozilla/bugs/bug269566-expected.txt
- platform/gtk/tables/mozilla/bugs/bug277062-expected.txt
- platform/gtk/tables/mozilla/bugs/bug2773-expected.png
- platform/gtk/tables/mozilla/bugs/bug2773-expected.txt
- platform/gtk/tables/mozilla/bugs/bug27993-1-expected.png
- platform/gtk/tables/mozilla/bugs/bug27993-1-expected.txt
- platform/gtk/tables/mozilla/bugs/bug2886-expected.png
- platform/gtk/tables/mozilla/bugs/bug2886-expected.txt
- platform/gtk/tables/mozilla/bugs/bug28933-expected.txt
- platform/gtk/tables/mozilla/bugs/bug29058-1-expected.png
- platform/gtk/tables/mozilla/bugs/bug29058-1-expected.txt
- platform/gtk/tables/mozilla/bugs/bug29314-expected.txt
- platform/gtk/tables/mozilla/bugs/bug29429-expected.png
- platform/gtk/tables/mozilla/bugs/bug29429-expected.txt
- platform/gtk/tables/mozilla/bugs/bug2954-expected.txt
- platform/gtk/tables/mozilla/bugs/bug2981-1-expected.png
- platform/gtk/tables/mozilla/bugs/bug2981-1-expected.txt
- platform/gtk/tables/mozilla/bugs/bug2981-2-expected.png
- platform/gtk/tables/mozilla/bugs/bug2981-2-expected.txt
- platform/gtk/tables/mozilla/bugs/bug2997-expected.png
- platform/gtk/tables/mozilla/bugs/bug2997-expected.txt
- platform/gtk/tables/mozilla/bugs/bug30273-expected.png
- platform/gtk/tables/mozilla/bugs/bug30273-expected.txt
- platform/gtk/tables/mozilla/bugs/bug30559-expected.png
- platform/gtk/tables/mozilla/bugs/bug30559-expected.txt
- platform/gtk/tables/mozilla/bugs/bug3103-expected.png
- platform/gtk/tables/mozilla/bugs/bug3103-expected.txt
- platform/gtk/tables/mozilla/bugs/bug32205-3-expected.png
- platform/gtk/tables/mozilla/bugs/bug32205-3-expected.txt
- platform/gtk/tables/mozilla/bugs/bug3260-expected.png
- platform/gtk/tables/mozilla/bugs/bug3260-expected.txt
- platform/gtk/tables/mozilla/bugs/bug32841-expected.png
- platform/gtk/tables/mozilla/bugs/bug33137-expected.png
- platform/gtk/tables/mozilla/bugs/bug33137-expected.txt
- platform/gtk/tables/mozilla/bugs/bug33855-expected.txt
- platform/gtk/tables/mozilla/bugs/bug3454-expected.png
- platform/gtk/tables/mozilla/bugs/bug3454-expected.txt
- platform/gtk/tables/mozilla/bugs/bug38916-expected.png
- platform/gtk/tables/mozilla/bugs/bug38916-expected.txt
- platform/gtk/tables/mozilla/bugs/bug3977-expected.png
- platform/gtk/tables/mozilla/bugs/bug3977-expected.txt
- platform/gtk/tables/mozilla/bugs/bug4093-expected.png
- platform/gtk/tables/mozilla/bugs/bug4093-expected.txt
- platform/gtk/tables/mozilla/bugs/bug42187-expected.png
- platform/gtk/tables/mozilla/bugs/bug42187-expected.txt
- platform/gtk/tables/mozilla/bugs/bug4385-expected.png
- platform/gtk/tables/mozilla/bugs/bug4385-expected.txt
- platform/gtk/tables/mozilla/bugs/bug4427-expected.png
- platform/gtk/tables/mozilla/bugs/bug4427-expected.txt
- platform/gtk/tables/mozilla/bugs/bug44505-expected.png
- platform/gtk/tables/mozilla/bugs/bug44505-expected.txt
- platform/gtk/tables/mozilla/bugs/bug4501-expected.png
- platform/gtk/tables/mozilla/bugs/bug4501-expected.txt
- platform/gtk/tables/mozilla/bugs/bug4527-expected.png
- platform/gtk/tables/mozilla/bugs/bug4527-expected.txt
- platform/gtk/tables/mozilla/bugs/bug45350-expected.txt
- platform/gtk/tables/mozilla/bugs/bug45486-expected.png
- platform/gtk/tables/mozilla/bugs/bug45486-expected.txt
- platform/gtk/tables/mozilla/bugs/bug4576-expected.png
- platform/gtk/tables/mozilla/bugs/bug4576-expected.txt
- platform/gtk/tables/mozilla/bugs/bug46268-1-expected.png
- platform/gtk/tables/mozilla/bugs/bug46268-1-expected.txt
- platform/gtk/tables/mozilla/bugs/bug46268-2-expected.png
- platform/gtk/tables/mozilla/bugs/bug46268-2-expected.txt
- platform/gtk/tables/mozilla/bugs/bug46368-1-expected.png
- platform/gtk/tables/mozilla/bugs/bug46368-1-expected.txt
- platform/gtk/tables/mozilla/bugs/bug46623-1-expected.png
- platform/gtk/tables/mozilla/bugs/bug46623-1-expected.txt
- platform/gtk/tables/mozilla/bugs/bug46623-2-expected.png
- platform/gtk/tables/mozilla/bugs/bug46623-2-expected.txt
- platform/gtk/tables/mozilla/bugs/bug47432-expected.png
- platform/gtk/tables/mozilla/bugs/bug47432-expected.txt
- platform/gtk/tables/mozilla/bugs/bug4803-expected.txt
- platform/gtk/tables/mozilla/bugs/bug4849-2-expected.txt
- platform/gtk/tables/mozilla/bugs/bug4849-expected.txt
- platform/gtk/tables/mozilla/bugs/bug51727-expected.png
- platform/gtk/tables/mozilla/bugs/bug51727-expected.txt
- platform/gtk/tables/mozilla/bugs/bug5188-expected.png
- platform/gtk/tables/mozilla/bugs/bug5188-expected.txt
- platform/gtk/tables/mozilla/bugs/bug52505-expected.png
- platform/gtk/tables/mozilla/bugs/bug52505-expected.txt
- platform/gtk/tables/mozilla/bugs/bug52506-expected.png
- platform/gtk/tables/mozilla/bugs/bug52506-expected.txt
- platform/gtk/tables/mozilla/bugs/bug53690-1-expected.png
- platform/gtk/tables/mozilla/bugs/bug53690-1-expected.txt
- platform/gtk/tables/mozilla/bugs/bug53690-2-expected.png
- platform/gtk/tables/mozilla/bugs/bug53690-2-expected.txt
- platform/gtk/tables/mozilla/bugs/bug53891-expected.png
- platform/gtk/tables/mozilla/bugs/bug53891-expected.txt
- platform/gtk/tables/mozilla/bugs/bug5538-expected.png
- platform/gtk/tables/mozilla/bugs/bug5538-expected.txt
- platform/gtk/tables/mozilla/bugs/bug55789-expected.txt
- platform/gtk/tables/mozilla/bugs/bug56201-expected.png
- platform/gtk/tables/mozilla/bugs/bug56201-expected.txt
- platform/gtk/tables/mozilla/bugs/bug57828-2-expected.png
- platform/gtk/tables/mozilla/bugs/bug57828-2-expected.txt
- platform/gtk/tables/mozilla/bugs/bug5797-expected.png
- platform/gtk/tables/mozilla/bugs/bug5797-expected.txt
- platform/gtk/tables/mozilla/bugs/bug5835-expected.png
- platform/gtk/tables/mozilla/bugs/bug5835-expected.txt
- platform/gtk/tables/mozilla/bugs/bug59354-expected.png
- platform/gtk/tables/mozilla/bugs/bug59354-expected.txt
- platform/gtk/tables/mozilla/bugs/bug60804-expected.png
- platform/gtk/tables/mozilla/bugs/bug60804-expected.txt
- platform/gtk/tables/mozilla/bugs/bug60807-expected.png
- platform/gtk/tables/mozilla/bugs/bug60807-expected.txt
- platform/gtk/tables/mozilla/bugs/bug6184-expected.png
- platform/gtk/tables/mozilla/bugs/bug6184-expected.txt
- platform/gtk/tables/mozilla/bugs/bug6304-expected.png
- platform/gtk/tables/mozilla/bugs/bug6304-expected.txt
- platform/gtk/tables/mozilla/bugs/bug6404-expected.png
- platform/gtk/tables/mozilla/bugs/bug6404-expected.txt
- platform/gtk/tables/mozilla/bugs/bug647-expected.png
- platform/gtk/tables/mozilla/bugs/bug647-expected.txt
- platform/gtk/tables/mozilla/bugs/bug6674-expected.png
- platform/gtk/tables/mozilla/bugs/bug6674-expected.txt
- platform/gtk/tables/mozilla/bugs/bug68998-expected.png
- platform/gtk/tables/mozilla/bugs/bug68998-expected.txt
- platform/gtk/tables/mozilla/bugs/bug69382-1-expected.png
- platform/gtk/tables/mozilla/bugs/bug69382-1-expected.txt
- platform/gtk/tables/mozilla/bugs/bug69382-2-expected.png
- platform/gtk/tables/mozilla/bugs/bug69382-2-expected.txt
- platform/gtk/tables/mozilla/bugs/bug72359-expected.txt
- platform/gtk/tables/mozilla/bugs/bug7342-expected.png
- platform/gtk/tables/mozilla/bugs/bug7342-expected.txt
- platform/gtk/tables/mozilla/bugs/bug7714-expected.png
- platform/gtk/tables/mozilla/bugs/bug7714-expected.txt
- platform/gtk/tables/mozilla/bugs/bug78162-expected.png
- platform/gtk/tables/mozilla/bugs/bug78162-expected.txt
- platform/gtk/tables/mozilla/bugs/bug82946-2-expected.png
- platform/gtk/tables/mozilla/bugs/bug82946-2-expected.txt
- platform/gtk/tables/mozilla/bugs/bug86708-expected.png
- platform/gtk/tables/mozilla/bugs/bug86708-expected.txt
- platform/gtk/tables/mozilla/bugs/bug8950-expected.png
- platform/gtk/tables/mozilla/bugs/bug8950-expected.txt
- platform/gtk/tables/mozilla/bugs/bug9123-1-expected.png
- platform/gtk/tables/mozilla/bugs/bug9123-1-expected.txt
- platform/gtk/tables/mozilla/bugs/bug9123-2-expected.png
- platform/gtk/tables/mozilla/bugs/bug9123-2-expected.txt
- platform/gtk/tables/mozilla/bugs/bug92143-expected.png
- platform/gtk/tables/mozilla/bugs/bug92143-expected.txt
- platform/gtk/tables/mozilla/bugs/bug92647-2-expected.png
- platform/gtk/tables/mozilla/bugs/bug92647-2-expected.txt
- platform/gtk/tables/mozilla/bugs/bug963-expected.txt
- platform/gtk/tables/mozilla/bugs/bug96334-expected.txt
- platform/gtk/tables/mozilla/bugs/bug97383-expected.png
- platform/gtk/tables/mozilla/bugs/bug97383-expected.txt
- platform/gtk/tables/mozilla/bugs/bug9879-1-expected.png
- platform/gtk/tables/mozilla/bugs/bug9879-1-expected.txt
- platform/gtk/tables/mozilla/collapsing_borders/bug41262-3-expected.png
- platform/gtk/tables/mozilla/collapsing_borders/bug41262-3-expected.txt
- platform/gtk/tables/mozilla/core/bloomberg-expected.png
- platform/gtk/tables/mozilla/core/bloomberg-expected.txt
- platform/gtk/tables/mozilla/core/borders-expected.png
- platform/gtk/tables/mozilla/core/borders-expected.txt
- platform/gtk/tables/mozilla/core/cell_heights-expected.png
- platform/gtk/tables/mozilla/core/cell_heights-expected.txt
- platform/gtk/tables/mozilla/core/col_span-expected.png
- platform/gtk/tables/mozilla/core/col_span-expected.txt
- platform/gtk/tables/mozilla/core/col_widths_auto_autoFix-expected.png
- platform/gtk/tables/mozilla/core/col_widths_auto_autoFix-expected.txt
- platform/gtk/tables/mozilla/core/col_widths_auto_autoFixPer-expected.png
- platform/gtk/tables/mozilla/core/col_widths_auto_autoFixPer-expected.txt
- platform/gtk/tables/mozilla/core/col_widths_auto_fix-expected.png
- platform/gtk/tables/mozilla/core/col_widths_auto_fix-expected.txt
- platform/gtk/tables/mozilla/core/col_widths_auto_fixPer-expected.png
- platform/gtk/tables/mozilla/core/col_widths_auto_fixPer-expected.txt
- platform/gtk/tables/mozilla/core/col_widths_auto_per-expected.png
- platform/gtk/tables/mozilla/core/col_widths_auto_per-expected.txt
- platform/gtk/tables/mozilla/core/col_widths_fix_autoFix-expected.png
- platform/gtk/tables/mozilla/core/col_widths_fix_autoFix-expected.txt
- platform/gtk/tables/mozilla/core/col_widths_fix_fix-expected.png
- platform/gtk/tables/mozilla/core/col_widths_fix_fix-expected.txt
- platform/gtk/tables/mozilla/core/col_widths_fix_fixPer-expected.png
- platform/gtk/tables/mozilla/core/col_widths_fix_fixPer-expected.txt
- platform/gtk/tables/mozilla/core/col_widths_fix_per-expected.png
- platform/gtk/tables/mozilla/core/col_widths_fix_per-expected.txt
- platform/gtk/tables/mozilla/core/margins-expected.txt
- platform/gtk/tables/mozilla/core/misc-expected.png
- platform/gtk/tables/mozilla/core/misc-expected.txt
- platform/gtk/tables/mozilla/core/nested1-expected.png
- platform/gtk/tables/mozilla/core/nested1-expected.txt
- platform/gtk/tables/mozilla/core/one_row-expected.png
- platform/gtk/tables/mozilla/core/one_row-expected.txt
- platform/gtk/tables/mozilla/core/table_frame-expected.png
- platform/gtk/tables/mozilla/core/table_frame-expected.txt
- platform/gtk/tables/mozilla/core/table_heights-expected.png
- platform/gtk/tables/mozilla/core/table_heights-expected.txt
- platform/gtk/tables/mozilla/core/table_rules-expected.txt
- platform/gtk/tables/mozilla/core/table_widths-expected.png
- platform/gtk/tables/mozilla/core/table_widths-expected.txt
- platform/gtk/tables/mozilla/dom/insertColGroups1-expected.png
- platform/gtk/tables/mozilla/dom/insertColGroups1-expected.txt
- platform/gtk/tables/mozilla/dom/insertColGroups2-expected.png
- platform/gtk/tables/mozilla/dom/insertColGroups2-expected.txt
- platform/gtk/tables/mozilla/dom/insertCols1-expected.png
- platform/gtk/tables/mozilla/dom/insertCols1-expected.txt
- platform/gtk/tables/mozilla/dom/insertCols2-expected.png
- platform/gtk/tables/mozilla/dom/insertCols2-expected.txt
- platform/gtk/tables/mozilla/dom/insertCols3-expected.png
- platform/gtk/tables/mozilla/dom/insertCols3-expected.txt
- platform/gtk/tables/mozilla/dom/insertCols4-expected.png
- platform/gtk/tables/mozilla/dom/insertCols4-expected.txt
- platform/gtk/tables/mozilla/dom/insertCols5-expected.png
- platform/gtk/tables/mozilla/dom/insertCols5-expected.txt
- platform/gtk/tables/mozilla/marvin/backgr_layers-opacity-expected.png
- platform/gtk/tables/mozilla/marvin/backgr_layers-opacity-expected.txt
- platform/gtk/tables/mozilla/marvin/backgr_position-table-expected.png
- platform/gtk/tables/mozilla/marvin/backgr_position-table-expected.txt
- platform/gtk/tables/mozilla/marvin/backgr_simple-table-cell-expected.png
- platform/gtk/tables/mozilla/marvin/backgr_simple-table-cell-expected.txt
- platform/gtk/tables/mozilla/marvin/backgr_simple-table-column-expected.png
- platform/gtk/tables/mozilla/marvin/backgr_simple-table-column-expected.txt
- platform/gtk/tables/mozilla/marvin/backgr_simple-table-column-group-expected.png
- platform/gtk/tables/mozilla/marvin/backgr_simple-table-column-group-expected.txt
- platform/gtk/tables/mozilla/marvin/backgr_simple-table-expected.png
- platform/gtk/tables/mozilla/marvin/backgr_simple-table-expected.txt
- platform/gtk/tables/mozilla/marvin/backgr_simple-table-row-expected.png
- platform/gtk/tables/mozilla/marvin/backgr_simple-table-row-expected.txt
- platform/gtk/tables/mozilla/marvin/backgr_simple-table-row-group-expected.png
- platform/gtk/tables/mozilla/marvin/backgr_simple-table-row-group-expected.txt
- platform/gtk/tables/mozilla/marvin/body_thead-expected.txt
- platform/gtk/tables/mozilla/marvin/colgroup_align_center-expected.png
- platform/gtk/tables/mozilla/marvin/colgroup_align_center-expected.txt
- platform/gtk/tables/mozilla/marvin/colgroup_align_justify-expected.png
- platform/gtk/tables/mozilla/marvin/colgroup_align_justify-expected.txt
- platform/gtk/tables/mozilla/marvin/colgroup_align_left-expected.png
- platform/gtk/tables/mozilla/marvin/colgroup_align_left-expected.txt
- platform/gtk/tables/mozilla/marvin/colgroup_align_right-expected.png
- platform/gtk/tables/mozilla/marvin/colgroup_align_right-expected.txt
- platform/gtk/tables/mozilla/marvin/colgroup_span-expected.png
- platform/gtk/tables/mozilla/marvin/colgroup_span-expected.txt
- platform/gtk/tables/mozilla/marvin/colgroup_valign_baseline-expected.png
- platform/gtk/tables/mozilla/marvin/colgroup_valign_baseline-expected.txt
- platform/gtk/tables/mozilla/marvin/colgroup_valign_bottom-expected.png
- platform/gtk/tables/mozilla/marvin/colgroup_valign_bottom-expected.txt
- platform/gtk/tables/mozilla/marvin/colgroup_valign_middle-expected.png
- platform/gtk/tables/mozilla/marvin/colgroup_valign_middle-expected.txt
- platform/gtk/tables/mozilla/marvin/colgroup_valign_top-expected.png
- platform/gtk/tables/mozilla/marvin/colgroup_valign_top-expected.txt
- platform/gtk/tables/mozilla/marvin/colgroup_width_pct-expected.png
- platform/gtk/tables/mozilla/marvin/colgroup_width_pct-expected.txt
- platform/gtk/tables/mozilla/marvin/colgroup_width_px-expected.png
- platform/gtk/tables/mozilla/marvin/colgroup_width_px-expected.txt
- platform/gtk/tables/mozilla/marvin/table_overflow_hidden_td-expected.png
- platform/gtk/tables/mozilla/marvin/table_overflow_hidden_td-expected.txt
- platform/gtk/tables/mozilla/marvin/table_overflow_td_dynamic_deactivate-expected.png
- platform/gtk/tables/mozilla/marvin/table_overflow_td_dynamic_deactivate-expected.txt
- platform/gtk/tables/mozilla/marvin/table_row_align_center-expected.png
- platform/gtk/tables/mozilla/marvin/table_row_align_center-expected.txt
- platform/gtk/tables/mozilla/marvin/table_row_align_left-expected.png
- platform/gtk/tables/mozilla/marvin/table_row_align_left-expected.txt
- platform/gtk/tables/mozilla/marvin/table_row_align_right-expected.png
- platform/gtk/tables/mozilla/marvin/table_row_align_right-expected.txt
- platform/gtk/tables/mozilla/marvin/table_rules_groups-expected.txt
- platform/gtk/tables/mozilla/marvin/tables_bgcolor_aqua-expected.png
- platform/gtk/tables/mozilla/marvin/tables_bgcolor_aqua-expected.txt
- platform/gtk/tables/mozilla/marvin/tables_bgcolor_aqua_rgb-expected.png
- platform/gtk/tables/mozilla/marvin/tables_bgcolor_aqua_rgb-expected.txt
- platform/gtk/tables/mozilla/marvin/tables_bgcolor_black-expected.png
- platform/gtk/tables/mozilla/marvin/tables_bgcolor_black-expected.txt
- platform/gtk/tables/mozilla/marvin/tables_bgcolor_black_rgb-expected.png
- platform/gtk/tables/mozilla/marvin/tables_bgcolor_black_rgb-expected.txt
- platform/gtk/tables/mozilla/marvin/tables_bgcolor_blue-expected.png
- platform/gtk/tables/mozilla/marvin/tables_bgcolor_blue-expected.txt
- platform/gtk/tables/mozilla/marvin/tables_bgcolor_blue_rgb-expected.png
- platform/gtk/tables/mozilla/marvin/tables_bgcolor_blue_rgb-expected.txt
- platform/gtk/tables/mozilla/marvin/tables_bgcolor_fuchsia-expected.png
- platform/gtk/tables/mozilla/marvin/tables_bgcolor_fuchsia-expected.txt
- platform/gtk/tables/mozilla/marvin/tables_bgcolor_fuchsia_rgb-expected.png
- platform/gtk/tables/mozilla/marvin/tables_bgcolor_fuchsia_rgb-expected.txt
- platform/gtk/tables/mozilla/marvin/tables_bgcolor_gray-expected.png
- platform/gtk/tables/mozilla/marvin/tables_bgcolor_gray-expected.txt
- platform/gtk/tables/mozilla/marvin/tables_bgcolor_gray_rgb-expected.png
- platform/gtk/tables/mozilla/marvin/tables_bgcolor_gray_rgb-expected.txt
- platform/gtk/tables/mozilla/marvin/tables_bgcolor_green-expected.png
- platform/gtk/tables/mozilla/marvin/tables_bgcolor_green-expected.txt
- platform/gtk/tables/mozilla/marvin/tables_bgcolor_green_rgb-expected.png
- platform/gtk/tables/mozilla/marvin/tables_bgcolor_green_rgb-expected.txt
- platform/gtk/tables/mozilla/marvin/tables_bgcolor_lime-expected.png
- platform/gtk/tables/mozilla/marvin/tables_bgcolor_lime-expected.txt
- platform/gtk/tables/mozilla/marvin/tables_bgcolor_lime_rgb-expected.png
- platform/gtk/tables/mozilla/marvin/tables_bgcolor_lime_rgb-expected.txt
- platform/gtk/tables/mozilla/marvin/tables_bgcolor_maroon-expected.png
- platform/gtk/tables/mozilla/marvin/tables_bgcolor_maroon-expected.txt
- platform/gtk/tables/mozilla/marvin/tables_bgcolor_maroon_rgb-expected.png
- platform/gtk/tables/mozilla/marvin/tables_bgcolor_maroon_rgb-expected.txt
- platform/gtk/tables/mozilla/marvin/tables_bgcolor_navy-expected.png
- platform/gtk/tables/mozilla/marvin/tables_bgcolor_navy-expected.txt
- platform/gtk/tables/mozilla/marvin/tables_bgcolor_navy_rgb-expected.png
- platform/gtk/tables/mozilla/marvin/tables_bgcolor_navy_rgb-expected.txt
- platform/gtk/tables/mozilla/marvin/tables_bgcolor_olive-expected.png
- platform/gtk/tables/mozilla/marvin/tables_bgcolor_olive-expected.txt
- platform/gtk/tables/mozilla/marvin/tables_bgcolor_olive_rgb-expected.png
- platform/gtk/tables/mozilla/marvin/tables_bgcolor_olive_rgb-expected.txt
- platform/gtk/tables/mozilla/marvin/tables_bgcolor_purple-expected.png
- platform/gtk/tables/mozilla/marvin/tables_bgcolor_purple-expected.txt
- platform/gtk/tables/mozilla/marvin/tables_bgcolor_purple_rgb-expected.png
- platform/gtk/tables/mozilla/marvin/tables_bgcolor_purple_rgb-expected.txt
- platform/gtk/tables/mozilla/marvin/tables_bgcolor_red-expected.png
- platform/gtk/tables/mozilla/marvin/tables_bgcolor_red-expected.txt
- platform/gtk/tables/mozilla/marvin/tables_bgcolor_red_rgb-expected.png
- platform/gtk/tables/mozilla/marvin/tables_bgcolor_red_rgb-expected.txt
- platform/gtk/tables/mozilla/marvin/tables_bgcolor_silver-expected.png
- platform/gtk/tables/mozilla/marvin/tables_bgcolor_silver-expected.txt
- platform/gtk/tables/mozilla/marvin/tables_bgcolor_silver_rgb-expected.png
- platform/gtk/tables/mozilla/marvin/tables_bgcolor_silver_rgb-expected.txt
- platform/gtk/tables/mozilla/marvin/tables_bgcolor_teal-expected.png
- platform/gtk/tables/mozilla/marvin/tables_bgcolor_teal-expected.txt
- platform/gtk/tables/mozilla/marvin/tables_bgcolor_teal_rgb-expected.png
- platform/gtk/tables/mozilla/marvin/tables_bgcolor_teal_rgb-expected.txt
- platform/gtk/tables/mozilla/marvin/tables_bgcolor_white-expected.png
- platform/gtk/tables/mozilla/marvin/tables_bgcolor_white-expected.txt
- platform/gtk/tables/mozilla/marvin/tables_bgcolor_white_rgb-expected.png
- platform/gtk/tables/mozilla/marvin/tables_bgcolor_white_rgb-expected.txt
- platform/gtk/tables/mozilla/marvin/tables_bgcolor_yellow-expected.png
- platform/gtk/tables/mozilla/marvin/tables_bgcolor_yellow-expected.txt
- platform/gtk/tables/mozilla/marvin/tables_bgcolor_yellow_rgb-expected.png
- platform/gtk/tables/mozilla/marvin/tables_bgcolor_yellow_rgb-expected.txt
- platform/gtk/tables/mozilla/marvin/tables_cellpadding_pct-expected.png
- platform/gtk/tables/mozilla/marvin/tables_cellpadding_pct-expected.txt
- platform/gtk/tables/mozilla/marvin/tables_td_width-expected.png
- platform/gtk/tables/mozilla/marvin/tables_td_width-expected.txt
- platform/gtk/tables/mozilla/marvin/tables_th_colspan-expected.png
- platform/gtk/tables/mozilla/marvin/tables_th_colspan-expected.txt
- platform/gtk/tables/mozilla/marvin/tables_th_width-expected.png
- platform/gtk/tables/mozilla/marvin/tables_th_width-expected.txt
- platform/gtk/tables/mozilla/marvin/tables_width_percent-expected.png
- platform/gtk/tables/mozilla/marvin/tables_width_percent-expected.txt
- platform/gtk/tables/mozilla/marvin/tables_width_px-expected.png
- platform/gtk/tables/mozilla/marvin/tables_width_px-expected.txt
- platform/gtk/tables/mozilla/marvin/tbody_valign_baseline-expected.png
- platform/gtk/tables/mozilla/marvin/tbody_valign_baseline-expected.txt
- platform/gtk/tables/mozilla/marvin/tbody_valign_bottom-expected.png
- platform/gtk/tables/mozilla/marvin/tbody_valign_bottom-expected.txt
- platform/gtk/tables/mozilla/marvin/tbody_valign_middle-expected.png
- platform/gtk/tables/mozilla/marvin/tbody_valign_middle-expected.txt
- platform/gtk/tables/mozilla/marvin/tbody_valign_top-expected.png
- platform/gtk/tables/mozilla/marvin/tbody_valign_top-expected.txt
- platform/gtk/tables/mozilla/marvin/td_valign_baseline-expected.png
- platform/gtk/tables/mozilla/marvin/td_valign_baseline-expected.txt
- platform/gtk/tables/mozilla/marvin/td_valign_bottom-expected.png
- platform/gtk/tables/mozilla/marvin/td_valign_bottom-expected.txt
- platform/gtk/tables/mozilla/marvin/td_valign_middle-expected.png
- platform/gtk/tables/mozilla/marvin/td_valign_middle-expected.txt
- platform/gtk/tables/mozilla/marvin/td_valign_top-expected.png
- platform/gtk/tables/mozilla/marvin/td_valign_top-expected.txt
- platform/gtk/tables/mozilla/marvin/tfoot_valign_baseline-expected.png
- platform/gtk/tables/mozilla/marvin/tfoot_valign_baseline-expected.txt
- platform/gtk/tables/mozilla/marvin/tfoot_valign_bottom-expected.png
- platform/gtk/tables/mozilla/marvin/tfoot_valign_bottom-expected.txt
- platform/gtk/tables/mozilla/marvin/tfoot_valign_middle-expected.png
- platform/gtk/tables/mozilla/marvin/tfoot_valign_middle-expected.txt
- platform/gtk/tables/mozilla/marvin/tfoot_valign_top-expected.png
- platform/gtk/tables/mozilla/marvin/tfoot_valign_top-expected.txt
- platform/gtk/tables/mozilla/marvin/th_valign_baseline-expected.png
- platform/gtk/tables/mozilla/marvin/th_valign_baseline-expected.txt
- platform/gtk/tables/mozilla/marvin/th_valign_bottom-expected.png
- platform/gtk/tables/mozilla/marvin/th_valign_bottom-expected.txt
- platform/gtk/tables/mozilla/marvin/th_valign_middle-expected.png
- platform/gtk/tables/mozilla/marvin/th_valign_middle-expected.txt
- platform/gtk/tables/mozilla/marvin/th_valign_top-expected.png
- platform/gtk/tables/mozilla/marvin/th_valign_top-expected.txt
- platform/gtk/tables/mozilla/marvin/thead_valign_baseline-expected.png
- platform/gtk/tables/mozilla/marvin/thead_valign_baseline-expected.txt
- platform/gtk/tables/mozilla/marvin/thead_valign_bottom-expected.png
- platform/gtk/tables/mozilla/marvin/thead_valign_bottom-expected.txt
- platform/gtk/tables/mozilla/marvin/thead_valign_middle-expected.png
- platform/gtk/tables/mozilla/marvin/thead_valign_middle-expected.txt
- platform/gtk/tables/mozilla/marvin/thead_valign_top-expected.png
- platform/gtk/tables/mozilla/marvin/thead_valign_top-expected.txt
- platform/gtk/tables/mozilla/marvin/tr_bgcolor_aqua_rgb-expected.png
- platform/gtk/tables/mozilla/marvin/tr_bgcolor_aqua_rgb-expected.txt
- platform/gtk/tables/mozilla/marvin/tr_bgcolor_black-expected.png
- platform/gtk/tables/mozilla/marvin/tr_bgcolor_black-expected.txt
- platform/gtk/tables/mozilla/marvin/tr_bgcolor_black_rgb-expected.png
- platform/gtk/tables/mozilla/marvin/tr_bgcolor_black_rgb-expected.txt
- platform/gtk/tables/mozilla/marvin/tr_bgcolor_blue-expected.png
- platform/gtk/tables/mozilla/marvin/tr_bgcolor_blue-expected.txt
- platform/gtk/tables/mozilla/marvin/tr_bgcolor_blue_rgb-expected.png
- platform/gtk/tables/mozilla/marvin/tr_bgcolor_blue_rgb-expected.txt
- platform/gtk/tables/mozilla/marvin/tr_bgcolor_fuchsia-expected.png
- platform/gtk/tables/mozilla/marvin/tr_bgcolor_fuchsia-expected.txt
- platform/gtk/tables/mozilla/marvin/tr_bgcolor_fuchsia_rgb-expected.png
- platform/gtk/tables/mozilla/marvin/tr_bgcolor_fuchsia_rgb-expected.txt
- platform/gtk/tables/mozilla/marvin/tr_bgcolor_gray-expected.png
- platform/gtk/tables/mozilla/marvin/tr_bgcolor_gray-expected.txt
- platform/gtk/tables/mozilla/marvin/tr_bgcolor_gray_rgb-expected.png
- platform/gtk/tables/mozilla/marvin/tr_bgcolor_gray_rgb-expected.txt
- platform/gtk/tables/mozilla/marvin/tr_bgcolor_green-expected.png
- platform/gtk/tables/mozilla/marvin/tr_bgcolor_green-expected.txt
- platform/gtk/tables/mozilla/marvin/tr_bgcolor_green_rgb-expected.png
- platform/gtk/tables/mozilla/marvin/tr_bgcolor_green_rgb-expected.txt
- platform/gtk/tables/mozilla/marvin/tr_bgcolor_lime-expected.png
- platform/gtk/tables/mozilla/marvin/tr_bgcolor_lime-expected.txt
- platform/gtk/tables/mozilla/marvin/tr_bgcolor_lime_rgb-expected.png
- platform/gtk/tables/mozilla/marvin/tr_bgcolor_lime_rgb-expected.txt
- platform/gtk/tables/mozilla/marvin/tr_bgcolor_maroon-expected.png
- platform/gtk/tables/mozilla/marvin/tr_bgcolor_maroon-expected.txt
- platform/gtk/tables/mozilla/marvin/tr_bgcolor_maroon_rgb-expected.png
- platform/gtk/tables/mozilla/marvin/tr_bgcolor_maroon_rgb-expected.txt
- platform/gtk/tables/mozilla/marvin/tr_bgcolor_navy-expected.png
- platform/gtk/tables/mozilla/marvin/tr_bgcolor_navy-expected.txt
- platform/gtk/tables/mozilla/marvin/tr_bgcolor_navy_rgb-expected.png
- platform/gtk/tables/mozilla/marvin/tr_bgcolor_navy_rgb-expected.txt
- platform/gtk/tables/mozilla/marvin/tr_bgcolor_olive-expected.png
- platform/gtk/tables/mozilla/marvin/tr_bgcolor_olive-expected.txt
- platform/gtk/tables/mozilla/marvin/tr_bgcolor_olive_rgb-expected.png
- platform/gtk/tables/mozilla/marvin/tr_bgcolor_olive_rgb-expected.txt
- platform/gtk/tables/mozilla/marvin/tr_bgcolor_purple-expected.png
- platform/gtk/tables/mozilla/marvin/tr_bgcolor_purple-expected.txt
- platform/gtk/tables/mozilla/marvin/tr_bgcolor_purple_rgb-expected.png
- platform/gtk/tables/mozilla/marvin/tr_bgcolor_purple_rgb-expected.txt
- platform/gtk/tables/mozilla/marvin/tr_bgcolor_red-expected.png
- platform/gtk/tables/mozilla/marvin/tr_bgcolor_red-expected.txt
- platform/gtk/tables/mozilla/marvin/tr_bgcolor_red_rgb-expected.png
- platform/gtk/tables/mozilla/marvin/tr_bgcolor_red_rgb-expected.txt
- platform/gtk/tables/mozilla/marvin/tr_bgcolor_silver-expected.png
- platform/gtk/tables/mozilla/marvin/tr_bgcolor_silver-expected.txt
- platform/gtk/tables/mozilla/marvin/tr_bgcolor_silver_rgb-expected.png
- platform/gtk/tables/mozilla/marvin/tr_bgcolor_silver_rgb-expected.txt
- platform/gtk/tables/mozilla/marvin/tr_bgcolor_teal-expected.png
- platform/gtk/tables/mozilla/marvin/tr_bgcolor_teal-expected.txt
- platform/gtk/tables/mozilla/marvin/tr_bgcolor_teal_rgb-expected.png
- platform/gtk/tables/mozilla/marvin/tr_bgcolor_teal_rgb-expected.txt
- platform/gtk/tables/mozilla/marvin/tr_bgcolor_white-expected.png
- platform/gtk/tables/mozilla/marvin/tr_bgcolor_white-expected.txt
- platform/gtk/tables/mozilla/marvin/tr_bgcolor_white_rgb-expected.png
- platform/gtk/tables/mozilla/marvin/tr_bgcolor_white_rgb-expected.txt
- platform/gtk/tables/mozilla/marvin/tr_bgcolor_yellow-expected.png
- platform/gtk/tables/mozilla/marvin/tr_bgcolor_yellow-expected.txt
- platform/gtk/tables/mozilla/marvin/tr_bgcolor_yellow_rgb-expected.png
- platform/gtk/tables/mozilla/marvin/tr_bgcolor_yellow_rgb-expected.txt
- platform/gtk/tables/mozilla/marvin/tr_valign_baseline-expected.png
- platform/gtk/tables/mozilla/marvin/tr_valign_baseline-expected.txt
- platform/gtk/tables/mozilla/marvin/tr_valign_bottom-expected.png
- platform/gtk/tables/mozilla/marvin/tr_valign_bottom-expected.txt
- platform/gtk/tables/mozilla/marvin/tr_valign_middle-expected.png
- platform/gtk/tables/mozilla/marvin/tr_valign_middle-expected.txt
- platform/gtk/tables/mozilla/marvin/tr_valign_top-expected.png
- platform/gtk/tables/mozilla/marvin/tr_valign_top-expected.txt
- platform/gtk/tables/mozilla/marvin/x_col_align_char-expected.png
- platform/gtk/tables/mozilla/marvin/x_col_align_char-expected.txt
- platform/gtk/tables/mozilla/marvin/x_col_span-expected.png
- platform/gtk/tables/mozilla/marvin/x_col_span-expected.txt
- platform/gtk/tables/mozilla/marvin/x_col_valign_baseline-expected.png
- platform/gtk/tables/mozilla/marvin/x_col_valign_baseline-expected.txt
- platform/gtk/tables/mozilla/marvin/x_col_valign_bottom-expected.png
- platform/gtk/tables/mozilla/marvin/x_col_valign_bottom-expected.txt
- platform/gtk/tables/mozilla/marvin/x_col_valign_middle-expected.png
- platform/gtk/tables/mozilla/marvin/x_col_valign_middle-expected.txt
- platform/gtk/tables/mozilla/marvin/x_col_valign_top-expected.png
- platform/gtk/tables/mozilla/marvin/x_col_valign_top-expected.txt
- platform/gtk/tables/mozilla/marvin/x_col_width_px-expected.png
- platform/gtk/tables/mozilla/marvin/x_col_width_px-expected.txt
- platform/gtk/tables/mozilla/marvin/x_col_width_rel-expected.png
- platform/gtk/tables/mozilla/marvin/x_col_width_rel-expected.txt
- platform/gtk/tables/mozilla/marvin/x_colgroup_align_char-expected.png
- platform/gtk/tables/mozilla/marvin/x_colgroup_align_char-expected.txt
- platform/gtk/tables/mozilla/marvin/x_colgroup_span-expected.png
- platform/gtk/tables/mozilla/marvin/x_colgroup_span-expected.txt
- platform/gtk/tables/mozilla/marvin/x_colgroup_valign_baseline-expected.png
- platform/gtk/tables/mozilla/marvin/x_colgroup_valign_baseline-expected.txt
- platform/gtk/tables/mozilla/marvin/x_colgroup_valign_bottom-expected.png
- platform/gtk/tables/mozilla/marvin/x_colgroup_valign_bottom-expected.txt
- platform/gtk/tables/mozilla/marvin/x_colgroup_valign_middle-expected.png
- platform/gtk/tables/mozilla/marvin/x_colgroup_valign_middle-expected.txt
- platform/gtk/tables/mozilla/marvin/x_colgroup_valign_top-expected.png
- platform/gtk/tables/mozilla/marvin/x_colgroup_valign_top-expected.txt
- platform/gtk/tables/mozilla/marvin/x_colgroup_width_rel-expected.png
- platform/gtk/tables/mozilla/marvin/x_colgroup_width_rel-expected.txt
- platform/gtk/tables/mozilla/marvin/x_tbody_valign_baseline-expected.png
- platform/gtk/tables/mozilla/marvin/x_tbody_valign_baseline-expected.txt
- platform/gtk/tables/mozilla/marvin/x_tbody_valign_bottom-expected.png
- platform/gtk/tables/mozilla/marvin/x_tbody_valign_bottom-expected.txt
- platform/gtk/tables/mozilla/marvin/x_tbody_valign_middle-expected.png
- platform/gtk/tables/mozilla/marvin/x_tbody_valign_middle-expected.txt
- platform/gtk/tables/mozilla/marvin/x_tbody_valign_top-expected.png
- platform/gtk/tables/mozilla/marvin/x_tbody_valign_top-expected.txt
- platform/gtk/tables/mozilla/marvin/x_td_align_center-expected.png
- platform/gtk/tables/mozilla/marvin/x_td_align_center-expected.txt
- platform/gtk/tables/mozilla/marvin/x_td_align_char-expected.png
- platform/gtk/tables/mozilla/marvin/x_td_align_char-expected.txt
- platform/gtk/tables/mozilla/marvin/x_td_align_justify-expected.png
- platform/gtk/tables/mozilla/marvin/x_td_align_justify-expected.txt
- platform/gtk/tables/mozilla/marvin/x_td_align_left-expected.png
- platform/gtk/tables/mozilla/marvin/x_td_align_left-expected.txt
- platform/gtk/tables/mozilla/marvin/x_td_align_right-expected.png
- platform/gtk/tables/mozilla/marvin/x_td_align_right-expected.txt
- platform/gtk/tables/mozilla/marvin/x_td_valign_baseline-expected.png
- platform/gtk/tables/mozilla/marvin/x_td_valign_baseline-expected.txt
- platform/gtk/tables/mozilla/marvin/x_td_valign_bottom-expected.png
- platform/gtk/tables/mozilla/marvin/x_td_valign_bottom-expected.txt
- platform/gtk/tables/mozilla/marvin/x_td_valign_middle-expected.png
- platform/gtk/tables/mozilla/marvin/x_td_valign_middle-expected.txt
- platform/gtk/tables/mozilla/marvin/x_td_valign_top-expected.png
- platform/gtk/tables/mozilla/marvin/x_td_valign_top-expected.txt
- platform/gtk/tables/mozilla/marvin/x_td_width-expected.png
- platform/gtk/tables/mozilla/marvin/x_td_width-expected.txt
- platform/gtk/tables/mozilla/marvin/x_tfoot_valign_baseline-expected.png
- platform/gtk/tables/mozilla/marvin/x_tfoot_valign_baseline-expected.txt
- platform/gtk/tables/mozilla/marvin/x_tfoot_valign_bottom-expected.png
- platform/gtk/tables/mozilla/marvin/x_tfoot_valign_bottom-expected.txt
- platform/gtk/tables/mozilla/marvin/x_tfoot_valign_middle-expected.png
- platform/gtk/tables/mozilla/marvin/x_tfoot_valign_middle-expected.txt
- platform/gtk/tables/mozilla/marvin/x_tfoot_valign_top-expected.png
- platform/gtk/tables/mozilla/marvin/x_tfoot_valign_top-expected.txt
- platform/gtk/tables/mozilla/marvin/x_th_align_center-expected.png
- platform/gtk/tables/mozilla/marvin/x_th_align_center-expected.txt
- platform/gtk/tables/mozilla/marvin/x_th_align_char-expected.png
- platform/gtk/tables/mozilla/marvin/x_th_align_char-expected.txt
- platform/gtk/tables/mozilla/marvin/x_th_align_justify-expected.png
- platform/gtk/tables/mozilla/marvin/x_th_align_justify-expected.txt
- platform/gtk/tables/mozilla/marvin/x_th_align_left-expected.png
- platform/gtk/tables/mozilla/marvin/x_th_align_left-expected.txt
- platform/gtk/tables/mozilla/marvin/x_th_align_right-expected.png
- platform/gtk/tables/mozilla/marvin/x_th_align_right-expected.txt
- platform/gtk/tables/mozilla/marvin/x_th_rowspan-expected.png
- platform/gtk/tables/mozilla/marvin/x_th_rowspan-expected.txt
- platform/gtk/tables/mozilla/marvin/x_th_valign_baseline-expected.png
- platform/gtk/tables/mozilla/marvin/x_th_valign_baseline-expected.txt
- platform/gtk/tables/mozilla/marvin/x_th_valign_bottom-expected.png
- platform/gtk/tables/mozilla/marvin/x_th_valign_bottom-expected.txt
- platform/gtk/tables/mozilla/marvin/x_th_valign_middle-expected.png
- platform/gtk/tables/mozilla/marvin/x_th_valign_middle-expected.txt
- platform/gtk/tables/mozilla/marvin/x_th_valign_top-expected.png
- platform/gtk/tables/mozilla/marvin/x_th_valign_top-expected.txt
- platform/gtk/tables/mozilla/marvin/x_th_width-expected.png
- platform/gtk/tables/mozilla/marvin/x_th_width-expected.txt
- platform/gtk/tables/mozilla/marvin/x_thead_valign_baseline-expected.png
- platform/gtk/tables/mozilla/marvin/x_thead_valign_baseline-expected.txt
- platform/gtk/tables/mozilla/marvin/x_thead_valign_bottom-expected.png
- platform/gtk/tables/mozilla/marvin/x_thead_valign_bottom-expected.txt
- platform/gtk/tables/mozilla/marvin/x_thead_valign_middle-expected.png
- platform/gtk/tables/mozilla/marvin/x_thead_valign_middle-expected.txt
- platform/gtk/tables/mozilla/marvin/x_thead_valign_top-expected.png
- platform/gtk/tables/mozilla/marvin/x_thead_valign_top-expected.txt
- platform/gtk/tables/mozilla/marvin/x_tr_align_char-expected.png
- platform/gtk/tables/mozilla/marvin/x_tr_align_char-expected.txt
- platform/gtk/tables/mozilla/marvin/x_tr_valign_baseline-expected.png
- platform/gtk/tables/mozilla/marvin/x_tr_valign_baseline-expected.txt
- platform/gtk/tables/mozilla/marvin/x_tr_valign_bottom-expected.png
- platform/gtk/tables/mozilla/marvin/x_tr_valign_bottom-expected.txt
- platform/gtk/tables/mozilla/marvin/x_tr_valign_middle-expected.png
- platform/gtk/tables/mozilla/marvin/x_tr_valign_middle-expected.txt
- platform/gtk/tables/mozilla/marvin/x_tr_valign_top-expected.png
- platform/gtk/tables/mozilla/marvin/x_tr_valign_top-expected.txt
- platform/gtk/tables/mozilla/other/cell_widths-expected.png
- platform/gtk/tables/mozilla/other/cell_widths-expected.txt
- platform/gtk/tables/mozilla/other/ms-expected.png
- platform/gtk/tables/mozilla/other/ms-expected.txt
- platform/gtk/tables/mozilla/other/nested2-expected.png
- platform/gtk/tables/mozilla/other/nested2-expected.txt
- platform/gtk/tables/mozilla/other/nestedTables-expected.png
- platform/gtk/tables/mozilla/other/nestedTables-expected.txt
- platform/gtk/tables/mozilla/other/slashlogo-expected.png
- platform/gtk/tables/mozilla/other/slashlogo-expected.txt
- platform/gtk/tables/mozilla/other/test3-expected.png
- platform/gtk/tables/mozilla/other/test3-expected.txt
- platform/gtk/tables/mozilla/other/test6-expected.png
- platform/gtk/tables/mozilla/other/test6-expected.txt
- platform/gtk/tables/mozilla/other/wa_table_thtd_rowspan-expected.png
- platform/gtk/tables/mozilla/other/wa_table_thtd_rowspan-expected.txt
- platform/gtk/tables/mozilla/other/wa_table_tr_align-expected.png
- platform/gtk/tables/mozilla/other/wa_table_tr_align-expected.txt
- platform/gtk/tables/mozilla_expected_failures/bugs/97619-expected.png
- platform/gtk/tables/mozilla_expected_failures/bugs/97619-expected.txt
- platform/gtk/tables/mozilla_expected_failures/bugs/bug1010-expected.png
- platform/gtk/tables/mozilla_expected_failures/bugs/bug1010-expected.txt
- platform/gtk/tables/mozilla_expected_failures/bugs/bug1055-2-expected.png
- platform/gtk/tables/mozilla_expected_failures/bugs/bug1055-2-expected.txt
- platform/gtk/tables/mozilla_expected_failures/bugs/bug1128-expected.png
- platform/gtk/tables/mozilla_expected_failures/bugs/bug1128-expected.txt
- platform/gtk/tables/mozilla_expected_failures/bugs/bug1164-expected.png
- platform/gtk/tables/mozilla_expected_failures/bugs/bug1164-expected.txt
- platform/gtk/tables/mozilla_expected_failures/bugs/bug128876-expected.txt
- platform/gtk/tables/mozilla_expected_failures/bugs/bug14007-1-expected.png
- platform/gtk/tables/mozilla_expected_failures/bugs/bug14007-1-expected.txt
- platform/gtk/tables/mozilla_expected_failures/bugs/bug14007-2-expected.png
- platform/gtk/tables/mozilla_expected_failures/bugs/bug14007-2-expected.txt
- platform/gtk/tables/mozilla_expected_failures/bugs/bug14159-2-expected.png
- platform/gtk/tables/mozilla_expected_failures/bugs/bug14159-2-expected.txt
- platform/gtk/tables/mozilla_expected_failures/bugs/bug1647-expected.png
- platform/gtk/tables/mozilla_expected_failures/bugs/bug1647-expected.txt
- platform/gtk/tables/mozilla_expected_failures/bugs/bug1725-expected.png
- platform/gtk/tables/mozilla_expected_failures/bugs/bug1725-expected.txt
- platform/gtk/tables/mozilla_expected_failures/bugs/bug17826-expected.png
- platform/gtk/tables/mozilla_expected_failures/bugs/bug17826-expected.txt
- platform/gtk/tables/mozilla_expected_failures/bugs/bug21518-expected.png
- platform/gtk/tables/mozilla_expected_failures/bugs/bug21518-expected.txt
- platform/gtk/tables/mozilla_expected_failures/bugs/bug22122-expected.png
- platform/gtk/tables/mozilla_expected_failures/bugs/bug22122-expected.txt
- platform/gtk/tables/mozilla_expected_failures/bugs/bug23847-expected.png
- platform/gtk/tables/mozilla_expected_failures/bugs/bug23847-expected.txt
- platform/gtk/tables/mozilla_expected_failures/bugs/bug2479-5-expected.png
- platform/gtk/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt
- platform/gtk/tables/mozilla_expected_failures/bugs/bug27993-2-expected.png
- platform/gtk/tables/mozilla_expected_failures/bugs/bug27993-2-expected.txt
- platform/gtk/tables/mozilla_expected_failures/bugs/bug29058-2-expected.png
- platform/gtk/tables/mozilla_expected_failures/bugs/bug29058-2-expected.txt
- platform/gtk/tables/mozilla_expected_failures/bugs/bug3105-expected.png
- platform/gtk/tables/mozilla_expected_failures/bugs/bug3105-expected.txt
- platform/gtk/tables/mozilla_expected_failures/bugs/bug56024-expected.png
- platform/gtk/tables/mozilla_expected_failures/bugs/bug56024-expected.txt
- platform/gtk/tables/mozilla_expected_failures/bugs/bug59252-expected.png
- platform/gtk/tables/mozilla_expected_failures/bugs/bug59252-expected.txt
- platform/gtk/tables/mozilla_expected_failures/bugs/bug7121-2-expected.txt
- platform/gtk/tables/mozilla_expected_failures/bugs/bug72393-expected.png
- platform/gtk/tables/mozilla_expected_failures/bugs/bug72393-expected.txt
- platform/gtk/tables/mozilla_expected_failures/bugs/bug7243-expected.png
- platform/gtk/tables/mozilla_expected_failures/bugs/bug7243-expected.txt
- platform/gtk/tables/mozilla_expected_failures/bugs/bug80762-2-expected.png
- platform/gtk/tables/mozilla_expected_failures/bugs/bug80762-2-expected.txt
- platform/gtk/tables/mozilla_expected_failures/bugs/bug8499-expected.png
- platform/gtk/tables/mozilla_expected_failures/bugs/bug8499-expected.txt
- platform/gtk/tables/mozilla_expected_failures/bugs/bug85016-expected.png
- platform/gtk/tables/mozilla_expected_failures/bugs/bug85016-expected.txt
- platform/gtk/tables/mozilla_expected_failures/bugs/bug91057-expected.txt
- platform/gtk/tables/mozilla_expected_failures/bugs/bug9879-1-expected.png
- platform/gtk/tables/mozilla_expected_failures/bugs/bug9879-1-expected.txt
- platform/gtk/tables/mozilla_expected_failures/collapsing_borders/bug41262-1-expected.png
- platform/gtk/tables/mozilla_expected_failures/collapsing_borders/bug41262-1-expected.txt
- platform/gtk/tables/mozilla_expected_failures/core/captions1-expected.png
- platform/gtk/tables/mozilla_expected_failures/core/captions1-expected.txt
- platform/gtk/tables/mozilla_expected_failures/core/captions2-expected.png
- platform/gtk/tables/mozilla_expected_failures/core/captions2-expected.txt
- platform/gtk/tables/mozilla_expected_failures/core/col_span2-expected.png
- platform/gtk/tables/mozilla_expected_failures/core/col_span2-expected.txt
- platform/gtk/tables/mozilla_expected_failures/core/cols1-expected.png
- platform/gtk/tables/mozilla_expected_failures/core/cols1-expected.txt
- platform/gtk/tables/mozilla_expected_failures/core/columns-expected.png
- platform/gtk/tables/mozilla_expected_failures/core/columns-expected.txt
- platform/gtk/tables/mozilla_expected_failures/core/standards1-expected.png
- platform/gtk/tables/mozilla_expected_failures/core/standards1-expected.txt
- platform/gtk/tables/mozilla_expected_failures/dom/appendColGroup1-expected.png
- platform/gtk/tables/mozilla_expected_failures/dom/appendColGroup1-expected.txt
- platform/gtk/tables/mozilla_expected_failures/marvin/backgr_border-table-cell-expected.png
- platform/gtk/tables/mozilla_expected_failures/marvin/backgr_border-table-cell-expected.txt
- platform/gtk/tables/mozilla_expected_failures/marvin/backgr_border-table-column-expected.png
- platform/gtk/tables/mozilla_expected_failures/marvin/backgr_border-table-column-expected.txt
- platform/gtk/tables/mozilla_expected_failures/marvin/backgr_border-table-column-group-expected.png
- platform/gtk/tables/mozilla_expected_failures/marvin/backgr_border-table-column-group-expected.txt
- platform/gtk/tables/mozilla_expected_failures/marvin/backgr_border-table-expected.png
- platform/gtk/tables/mozilla_expected_failures/marvin/backgr_border-table-expected.txt
- platform/gtk/tables/mozilla_expected_failures/marvin/backgr_border-table-quirks-expected.png
- platform/gtk/tables/mozilla_expected_failures/marvin/backgr_border-table-quirks-expected.txt
- platform/gtk/tables/mozilla_expected_failures/marvin/backgr_border-table-row-expected.png
- platform/gtk/tables/mozilla_expected_failures/marvin/backgr_border-table-row-expected.txt
- platform/gtk/tables/mozilla_expected_failures/marvin/backgr_border-table-row-group-expected.png
- platform/gtk/tables/mozilla_expected_failures/marvin/backgr_border-table-row-group-expected.txt
- platform/gtk/tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.png
- platform/gtk/tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.txt
- platform/gtk/tables/mozilla_expected_failures/marvin/backgr_layers-hide-expected.png
- platform/gtk/tables/mozilla_expected_failures/marvin/backgr_layers-hide-expected.txt
- platform/gtk/tables/mozilla_expected_failures/marvin/backgr_layers-show-expected.png
- platform/gtk/tables/mozilla_expected_failures/marvin/backgr_layers-show-expected.txt
- platform/gtk/tables/mozilla_expected_failures/marvin/backgr_position-table-cell-expected.png
- platform/gtk/tables/mozilla_expected_failures/marvin/backgr_position-table-cell-expected.txt
- platform/gtk/tables/mozilla_expected_failures/marvin/backgr_position-table-column-expected.png
- platform/gtk/tables/mozilla_expected_failures/marvin/backgr_position-table-column-expected.txt
- platform/gtk/tables/mozilla_expected_failures/marvin/backgr_position-table-column-group-expected.png
- platform/gtk/tables/mozilla_expected_failures/marvin/backgr_position-table-column-group-expected.txt
- platform/gtk/tables/mozilla_expected_failures/marvin/backgr_position-table-row-expected.png
- platform/gtk/tables/mozilla_expected_failures/marvin/backgr_position-table-row-expected.txt
- platform/gtk/tables/mozilla_expected_failures/marvin/backgr_position-table-row-group-expected.png
- platform/gtk/tables/mozilla_expected_failures/marvin/backgr_position-table-row-group-expected.txt
- platform/gtk/tables/mozilla_expected_failures/marvin/table_overflow_caption-expected.png
- platform/gtk/tables/mozilla_expected_failures/marvin/table_overflow_caption-expected.txt
- platform/gtk/tables/mozilla_expected_failures/marvin/table_overflow_caption_bottom-expected.png
- platform/gtk/tables/mozilla_expected_failures/marvin/table_overflow_caption_bottom-expected.txt
- platform/gtk/tables/mozilla_expected_failures/marvin/table_overflow_caption_hidden-expected.png
- platform/gtk/tables/mozilla_expected_failures/marvin/table_overflow_caption_hidden-expected.txt
- platform/gtk/tables/mozilla_expected_failures/marvin/table_overflow_caption_hidden_table-expected.png
- platform/gtk/tables/mozilla_expected_failures/marvin/table_overflow_caption_hidden_table-expected.txt
- platform/gtk/tables/mozilla_expected_failures/marvin/table_overflow_caption_left-expected.png
- platform/gtk/tables/mozilla_expected_failures/marvin/table_overflow_caption_left-expected.txt
- platform/gtk/tables/mozilla_expected_failures/marvin/table_overflow_caption_right-expected.png
- platform/gtk/tables/mozilla_expected_failures/marvin/table_overflow_caption_right-expected.txt
- platform/gtk/tables/mozilla_expected_failures/marvin/table_overflow_caption_top-expected.png
- platform/gtk/tables/mozilla_expected_failures/marvin/table_overflow_caption_top-expected.txt
- platform/gtk/tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow-expected.txt
- platform/gtk/tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow_table-expected.png
- platform/gtk/tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow_table-expected.txt
- platform/gtk/tables/mozilla_expected_failures/marvin/table_overflow_hidden_table-expected.png
- platform/gtk/tables/mozilla_expected_failures/marvin/table_overflow_hidden_table-expected.txt
- platform/gtk/tables/mozilla_expected_failures/marvin/table_overflow_hidden_tbody-expected.png
- platform/gtk/tables/mozilla_expected_failures/marvin/table_overflow_hidden_tbody-expected.txt
- platform/gtk/tables/mozilla_expected_failures/marvin/table_overflow_hidden_tr-expected.png
- platform/gtk/tables/mozilla_expected_failures/marvin/table_overflow_hidden_tr-expected.txt
- platform/gtk/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_cell-expected.png
- platform/gtk/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_cell-expected.txt
- platform/gtk/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_cell_sibling-expected.png
- platform/gtk/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_cell_sibling-expected.txt
- platform/gtk/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_row-expected.png
- platform/gtk/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_row-expected.txt
- platform/gtk/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_row_sibling-expected.png
- platform/gtk/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_row_sibling-expected.txt
- platform/gtk/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_table-expected.png
- platform/gtk/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_table-expected.txt
- platform/gtk/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_table_caption-expected.png
- platform/gtk/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_table_caption-expected.txt
- platform/gtk/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_tbody-expected.png
- platform/gtk/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_tbody-expected.txt
- platform/gtk/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_tbody_sibling-expected.png
- platform/gtk/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_tbody_sibling-expected.txt
- platform/gtk/tables/mozilla_expected_failures/marvin/table_overflow_td_align_right-expected.png
- platform/gtk/tables/mozilla_expected_failures/marvin/table_overflow_td_align_right-expected.txt
- platform/gtk/tables/mozilla_expected_failures/marvin/table_overflow_td_dynamic_deactivate-expected.png
- platform/gtk/tables/mozilla_expected_failures/marvin/table_overflow_td_dynamic_deactivate-expected.txt
- platform/gtk/tables/mozilla_expected_failures/marvin/table_overflow_td_valign_bottom-expected.png
- platform/gtk/tables/mozilla_expected_failures/marvin/table_overflow_td_valign_bottom-expected.txt
- platform/gtk/tables/mozilla_expected_failures/marvin/table_overflow_td_valign_middle-expected.png
- platform/gtk/tables/mozilla_expected_failures/marvin/table_overflow_td_valign_middle-expected.txt
- platform/gtk/tables/mozilla_expected_failures/marvin/table_overflow_td_valign_top-expected.png
- platform/gtk/tables/mozilla_expected_failures/marvin/table_overflow_td_valign_top-expected.txt
- platform/gtk/tables/mozilla_expected_failures/marvin/tables_cellspacing_pct-expected.png
- platform/gtk/tables/mozilla_expected_failures/marvin/tables_cellspacing_pct-expected.txt
- platform/gtk/tables/mozilla_expected_failures/other/empty_cells-expected.png
- platform/gtk/tables/mozilla_expected_failures/other/empty_cells-expected.txt
- platform/gtk/tables/mozilla_expected_failures/other/test4-expected.png
- platform/gtk/tables/mozilla_expected_failures/other/test4-expected.txt
- 1:06 PM Changeset in webkit [195779] by
-
- 4 edits in trunk/Source/WebInspectorUI
Web Inspector: Avoid recreating Timeline's DataGridNode data multiple times
https://bugs.webkit.org/show_bug.cgi?id=153608
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-01-28
Reviewed by Timothy Hatcher.
- UserInterface/Views/LayoutTimelineDataGridNode.js:
(WebInspector.LayoutTimelineDataGridNode.prototype.get data):
- UserInterface/Views/RenderingFrameTimelineDataGridNode.js:
(WebInspector.RenderingFrameTimelineDataGridNode.prototype.get data):
- UserInterface/Views/ScriptTimelineDataGridNode.js:
(WebInspector.ScriptTimelineDataGridNode.prototype.get data):
Cache the data when we create it the first time.
- 12:50 PM FTLJIT edited by
- (diff)
- 12:46 PM FTLJIT edited by
- (diff)
- 12:35 PM Changeset in webkit [195778] by
-
- 8 edits in trunk
EventHandler IDL attributes should be enumerable
https://bugs.webkit.org/show_bug.cgi?id=153595
Reviewed by Sam Weinig.
LayoutTests/imported/w3c:
Rebaseline W3C HTML test now that EventHandler attributes are enumerable,
as per the specification.
- web-platform-tests/html/dom/interfaces-expected.txt:
Source/WebCore:
Most of our EventHandler IDL attributes were marked as [NotEnumerable]
but should not have been according to the specification:
- https://html.spec.whatwg.org/#globaleventhandlers
- https://html.spec.whatwg.org/#windoweventhandlers
Firefox and Chrome behave according to the specification.
This patch aligns our behavior.
No new tests, already covered by existing tests.
- dom/Document.idl:
- dom/GlobalEventHandlers.idl:
- page/WindowEventHandlers.idl:
LayoutTests:
Rebaseline test now that more EventHandler attributes are enumerable.
- js/dom/dom-static-property-for-in-iteration-expected.txt:
- 12:20 PM Changeset in webkit [195777] by
-
- 2 edits in branches/safari-601-branch/Source/WebCore
Merged r192700. rdar://problem/19861992
- 12:18 PM Changeset in webkit [195776] by
-
- 2 edits in branches/safari-601-branch/Source/WebCore
Merged r194235. rdar://problem/23944407
- 12:16 PM Changeset in webkit [195775] by
-
- 3 edits in branches/safari-601-branch/Source/WebCore
Merged r192166. rdar://problem/22956040
- 12:13 PM Changeset in webkit [195774] by
-
- 2 edits in trunk/Source/WebCore
Windows build fix; PRId64 formatting macro for int64_t undefined, so provide Windows-specific alternative.
- platform/network/ParsedContentRange.cpp:
- 12:13 PM Changeset in webkit [195773] by
-
- 2 edits in branches/safari-601-branch/Source/WebKit/win
Merge patch for rdar://problem/23025615.
- 12:11 PM Changeset in webkit [195772] by
-
- 3 edits in branches/safari-601-branch/Source/WebKit/win
Merge patch for rdar://problem/23025615.
- 12:03 PM Changeset in webkit [195771] by
-
- 2 edits in trunk/Source/WebCore
[ThreadedCompositor] Fix flickers happening on video when entering/leaving fullscreen.
https://bugs.webkit.org/show_bug.cgi?id=153585
Reviewed by Michael Catanzaro.
Video thumbnail flickers where threaded compositor is enabled. This is because
a content buffer is not set to a target layer which changes before swapBuffer.
This is a very rare case though, it happens where video size changes many times in a short period.
- platform/graphics/texmap/TextureMapperPlatformLayerProxy.cpp:
(WebCore::TextureMapperPlatformLayerProxy::activateOnCompositingThread):
- 11:52 AM Changeset in webkit [195770] by
-
- 11 edits in trunk/Source/WebCore
Allow CachedResourceLoader clients to opt out of the MemoryCache.
https://bugs.webkit.org/show_bug.cgi?id=153549
Reviewed by Darin Adler.
Add a flag to ResourceLoaderOptions which allow loader clients to opt out of having
resources stored in the MemoryCache.
- loader/ResourceLoaderOptions.h:
(WebCore::ResourceLoaderOptions::ResourceLoaderOptions):
(WebCore::ResourceLoaderOptions::cachingPolicy):
Existing clients will have to add the (default) AllowCaching flag when they create a
ResourceLoaderOptions object.
- loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::startLoadingMainResource):
- loader/MediaResourceLoader.cpp:
(WebCore::MediaResourceLoader::start):
- loader/NetscapePlugInStreamLoader.cpp:
(WebCore::NetscapePlugInStreamLoader::NetscapePlugInStreamLoader):
(WebCore::ResourceLoaderOptions::setCachingPolicy):
- loader/icon/IconLoader.cpp:
(WebCore::IconLoader::startLoading):
- platform/graphics/avfoundation/objc/WebCoreAVFResourceLoader.mm:
(WebCore::WebCoreAVFResourceLoader::startLoading):
Every time the CachedResource or CachedResourceLoader accesses the MemoryCache, check
to see whether the resource or the request have allowed caching before adding resources
to, removing resources from, or sourcing resource data from the MemoryCache.
- loader/cache/CachedResource.cpp:
(WebCore::CachedResource::~CachedResource):
(WebCore::CachedResource::failBeforeStarting):
(WebCore::CachedResource::addClientToSet):
(WebCore::CachedResource::removeClient):
(WebCore::CachedResource::setDecodedSize):
(WebCore::CachedResource::setEncodedSize):
(WebCore::CachedResource::didAccessDecodedData):
- loader/cache/CachedResource.h:
(WebCore::CachedResource::allowsCaching):
- loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::requestUserCSSStyleSheet):
(WebCore::CachedResourceLoader::requestResource):
(WebCore::CachedResourceLoader::revalidateResource):
(WebCore::CachedResourceLoader::loadResource):
(WebCore::CachedResourceLoader::printPreloadStats):
(WebCore::CachedResourceLoader::defaultCachedResourceOptions):
- loader/cache/CachedResourceRequest.h:
(WebCore::CachedResourceRequest::allowsCaching):
- 11:40 AM Changeset in webkit [195769] by
-
- 11 edits in trunk/Source
Should avoid navigation for some data detector urls.
https://bugs.webkit.org/show_bug.cgi?id=153600
Reviewed by Tim Horton.
Source/WebCore:
Adding helper function to decide whether the default action should be performed.
- editing/cocoa/DataDetection.h:
- editing/cocoa/DataDetection.mm:
(WebCore::DataDetection::shouldCancelDefaultAction):
Source/WebKit2:
When a tap is commited, we normally generate a synthetic click if
the node responds to click events.
This patch adds the logic to prevent that from happening if the node
is a data detector link with certain characteristics (calendar event, telephone, etc.).
If this is the case, we compute the interaction information as position, send it
over to the UI process and notify that we did not handle the tap.
The page client is now also notified of this event and can show the data detector sheet if
appropriate.
- UIProcess/PageClient.h:
- UIProcess/ios/PageClientImplIOS.h:
- UIProcess/ios/PageClientImplIOS.mm:
(WebKit::PageClientImpl::toolTipChanged):
(WebKit::PageClientImpl::didNotHandleTapAsClick):
(WebKit::PageClientImpl::decidePolicyForGeolocationPermissionRequest):
- UIProcess/ios/WKContentViewInteraction.h:
- UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView clearSelection]):
(-[WKContentView _didNotHandleTapAsClick:]):
(-[WKContentView _positionInformationDidChange:]):
- UIProcess/ios/WebPageProxyIOS.mm:
(WebKit::WebPageProxy::didNotHandleTapAsClick):
- WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::commitPotentialTap):
- 11:34 AM Changeset in webkit [195768] by
-
- 2 edits in trunk/Tools
Unreviewed buildfix after r195743.
- WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
(WTR::AccessibilityUIElement::isPressActionSupported):
- 11:30 AM Changeset in webkit [195767] by
-
- 9 edits3 adds in branches/safari-601.1.46-branch
Merged r195607. rdar://problem/23962929
- 11:21 AM Changeset in webkit [195766] by
-
- 2 edits in trunk/Source/WebCore
Roll out r194555, as it introduced some bad regressions and was not
correct.
- rendering/RenderText.cpp:
(WebCore::RenderText::computePreferredLogicalWidths):
- 11:20 AM Changeset in webkit [195765] by
-
- 5 edits in trunk
Modern IDB: Index uniqueness broken in the SQLite backend.
https://bugs.webkit.org/show_bug.cgi?id=153596
Reviewed by Alex Christensen.
Source/WebCore:
No new tests (Many failing tests now pass, others improve).
- Modules/indexeddb/server/SQLiteIDBBackingStore.cpp:
(WebCore::IDBServer::SQLiteIDBBackingStore::createIndex):
(WebCore::IDBServer::SQLiteIDBBackingStore::uncheckedHasIndexRecord):
(WebCore::IDBServer::SQLiteIDBBackingStore::uncheckedPutIndexKey):
(WebCore::IDBServer::SQLiteIDBBackingStore::updateOneIndexForAddRecord):
(WebCore::IDBServer::SQLiteIDBBackingStore::updateAllIndexesForAddRecord):
(WebCore::IDBServer::SQLiteIDBBackingStore::addRecord):
(WebCore::IDBServer::SQLiteIDBBackingStore::updateIndexesForAddRecord): Deleted.
- Modules/indexeddb/server/SQLiteIDBBackingStore.h:
LayoutTests:
- platform/mac-wk1/TestExpectations:
- 11:17 AM Changeset in webkit [195764] by
-
- 16 edits5 adds in trunk
Custom protocol loading through AVFoundation does not support byte-range requests.
https://bugs.webkit.org/show_bug.cgi?id=152919
<rdar://problem/23664657>
Reviewed by Alex Christensen.
Source/WebCore:
Tests: http/tests/xmlhttprequest/blob-request-byte-range.html
TestWebkitAPI/Tests/WebCore/ParsedContentRange.cpp
When loading data through the AVAssetResourceLoaderDelegateProtocol, AVFoundation will issue
requests for specific byte-ranges by adding a "Range:" HTTP header to the NSURLRequest it
passes to the delegate. WebCore ignores this header, loads the entire resource, and replies
to the callback with the requested subset of the entire resource.
For byte-range requests near the end of a resource, this is inefficient, as the entire
resource up to, and including, the requested range must be loaded before any data can be
returned. Explicitly handle byte-range requests by creating a CachedResourceRequest with the
underlying NSURLRequest (which includes the "Range:" header) rather than just the request's
URL. BlobResourceHandle must be modified to add the "Content-Range:" response header to the
ResourceResponse.
To facilitate both generating and parsing the "Content-Range:" header, add a new
ParsedContentRange class for use by ResourceResponse and its clients. This class provides
methods both for parsing a "Content-Range" header value string, and for generating the
header value from elemental values.
- platform/graphics/avfoundation/objc/WebCoreAVFResourceLoader.mm:
(WebCore::WebCoreAVFResourceLoader::startLoading):
(WebCore::WebCoreAVFResourceLoader::responseReceived):
(WebCore::WebCoreAVFResourceLoader::fulfillRequestWithResource):
- platform/network/BlobResourceHandle.cpp:
(WebCore::BlobResourceHandle::BlobResourceHandle):
(WebCore::BlobResourceHandle::didGetSize):
(WebCore::BlobResourceHandle::seek):
(WebCore::BlobResourceHandle::notifyResponseOnSuccess):
- platform/network/BlobResourceHandle.h:
- platform/network/HTTPHeaderNames.in:
- platform/network/ParsedContentRange.cpp: Added.
(WebCore::areContentRangeValuesValid):
(WebCore::parseContentRange):
(WebCore::ParsedContentRange::ParsedContentRange):
(WebCore::ParsedContentRange::headerValue):
- platform/network/ParsedContentRange.h: Added.
(WebCore::ParsedContentRange::ParsedContentRange):
(WebCore::ParsedContentRange::isValid):
(WebCore::ParsedContentRange::firstBytePosition):
(WebCore::ParsedContentRange::lastBytePosition):
(WebCore::ParsedContentRange::instanceLength):
- platform/network/ResourceResponseBase.cpp:
(WebCore::ResourceResponseBase::updateHeaderParsedState):
(WebCore::parseContentRangeInHeader):
(WebCore::ResourceResponseBase::contentRange):
- platform/network/ResourceResponseBase.h:
- CMakeLists.txt:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
Tools:
Add tests for new ParsedContntRange class.
- TestWebKitAPI/PlatformWin.cmake:
- TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
- TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters:
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/WebCore/ParsedContentRange.cpp: Added.
(TestWebKitAPI::TEST):
- 11:07 AM Changeset in webkit [195763] by
-
- 2 edits in branches/safari-601.1.46-branch/Source/WebKit2
Merge follow-up fix for r194750.
- 11:04 AM Changeset in webkit [195762] by
-
- 2 edits in branches/safari-601.1.46-branch/Source/WebCore
Merge follow-up fix for r195625.
- 11:00 AM Changeset in webkit [195761] by
-
- 1 edit in branches/safari-601-branch/Source/WebCore/html/HTMLImageElement.h
Follow-up fix to r195751. rdar://problem/24192280
- 10:55 AM Changeset in webkit [195760] by
-
- 7 edits in trunk
Storage interface's attributes / operations should be enumerable
https://bugs.webkit.org/show_bug.cgi?id=153573
Reviewed by Darin Adler.
LayoutTests/imported/w3c:
Rebaseline W3C HTML test now that more checks are passing.
- web-platform-tests/html/dom/interfaces-expected.txt:
Source/WebCore:
Storage interface's attributes / operations should be enumerable:
Firefox matches the specification.
No new tests, already covered by existing test.
- storage/Storage.idl:
- 10:41 AM Changeset in webkit [195759] by
-
- 3 edits in trunk/Tools
Use isAnyWindows() instead of isCygwin() isWindows() in Perl scripts. https://bugs.webkit.org/show_bug.cgi?id=153594
Patch by Konstantin Tokarev <Konstantin Tokarev> on 2016-01-28
Reviewed by Alex Christensen.
- Scripts/webkitdirs.pm:
(determineNumberOfCPUs):
(jscPath):
(checkFrameworks):
(setupCygwinEnv):
(wrapperPrefixIfNeeded):
(cmakeGeneratedBuildfile):
(generateBuildSystemFromCMakeProject):
- Scripts/webkitperl/features.pm:
(libraryContainsSymbol):
- 10:41 AM Changeset in webkit [195758] by
-
- 1 edit in branches/safari-601-branch/Source/WebCore/bindings/js/JSHistoryCustom.cpp
Follow-up fix for rdar://problem/24337870
- 10:40 AM Changeset in webkit [195757] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Tabs height should be 2px less to match Safari
https://bugs.webkit.org/show_bug.cgi?id=153581
<rdar://problem/24383501>
Reviewed by Darin Adler.
- UserInterface/Views/TabBar.css:
(.tab-bar):
(.tab-bar > .item):
(.tab-bar > .item.pinned):
Make the new tab button ("+") a square.
- 10:33 AM Changeset in webkit [195756] by
-
- 2 edits in trunk/Source/WebKit2
[iOS] Update Web Process sandbox profile for audiodeviceclock access
https://bugs.webkit.org/show_bug.cgi?id=153571
<rdar://problem/24134612>
Reviewed by Alexey Proskuryakov.
- Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:
- 10:28 AM Changeset in webkit [195755] by
-
- 25 edits2 copies1 add in trunk/Source
Get WebVideoFullscreenManager and related classes to also compile for Mac platform
with video presentation mode support.
https://bugs.webkit.org/show_bug.cgi?id=153221
Reviewed by Eric Carlson.
Source/WebCore:
No new tests, no actual behavior change with a stub implementation of WebVideoFullscreenInterfaceMac.
- WebCore.xcodeproj/project.pbxproj:
Add PlatformView.h, WebVideoFullscreenChangeObserver.h, and WebVideoFullscreenInterfaceMac.h.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::HTMLMediaElement):
(WebCore::HTMLMediaElement::mediaPlayerEngineUpdated):
(WebCore::HTMLMediaElement::shouldOverrideBackgroundPlaybackRestriction):
- html/HTMLMediaElement.h:
Enable the code that deals with the video fullscreen layer also for Mac platform with
video presentation mode support.
- platform/cocoa/PlatformView.h:
Header file for declaring the view types for each Cocoa platform.
- platform/cocoa/WebVideoFullscreenChangeObserver.h:
(WebCore::WebVideoFullscreenChangeObserver::~WebVideoFullscreenChangeObserver):
Interface declaration moved from WebVideoFullscreenInterfaceAVKit.h.
- platform/cocoa/WebVideoFullscreenInterface.h:
Stop guarding the declaration of WebVideoFullscreenInterface to be iOS specific. It is now
enabled for iOS and Mac platform with video presentation mode support.
- platform/cocoa/WebVideoFullscreenModel.h:
- platform/cocoa/WebVideoFullscreenModelVideoElement.h:
- platform/cocoa/WebVideoFullscreenModelVideoElement.mm:
Enable also for Mac platform with video presentation mode support.
(WebVideoFullscreenModelVideoElement::setVideoFullscreenLayer):
Set the video fullscreen layer's anchor point to (0, 0) since we are not changing the position of
the video layer on Mac.
- platform/ios/WebVideoFullscreenControllerAVKit.mm:
Import WebVideoFullscreenChangeObserver.h now that the interface declaration has been moved to that file.
- platform/ios/WebVideoFullscreenInterfaceAVKit.h:
Move the declaration of WebVideoFullscreenChangeObserver to a separate header.
- platform/ios/WebVideoFullscreenInterfaceAVKit.mm:
Import WebVideoFullscreenChangeObserver.h now that the interface declaration has been moved to that file.
- platform/mac/WebVideoFullscreenInterfaceMac.h: Added.
- platform/mac/WebVideoFullscreenInterfaceMac.mm:
(WebCore::WebVideoFullscreenInterfaceMac::~WebVideoFullscreenInterfaceMac):
(WebCore::WebVideoFullscreenInterfaceMac::setWebVideoFullscreenModel):
(WebCore::WebVideoFullscreenInterfaceMac::setWebVideoFullscreenChangeObserver):
(WebCore::WebVideoFullscreenInterfaceMac::resetMediaState):
(WebCore::WebVideoFullscreenInterfaceMac::setDuration):
(WebCore::WebVideoFullscreenInterfaceMac::setCurrentTime):
(WebCore::WebVideoFullscreenInterfaceMac::setBufferedTime):
(WebCore::WebVideoFullscreenInterfaceMac::setRate):
(WebCore::WebVideoFullscreenInterfaceMac::setVideoDimensions):
(WebCore::WebVideoFullscreenInterfaceMac::setSeekableRanges):
(WebCore::WebVideoFullscreenInterfaceMac::setCanPlayFastReverse):
(WebCore::WebVideoFullscreenInterfaceMac::setAudioMediaSelectionOptions):
(WebCore::WebVideoFullscreenInterfaceMac::setLegibleMediaSelectionOptions):
(WebCore::WebVideoFullscreenInterfaceMac::setExternalPlayback):
(WebCore::WebVideoFullscreenInterfaceMac::setWirelessVideoPlaybackDisabled):
(WebCore::WebVideoFullscreenInterfaceMac::setupFullscreen):
(WebCore::WebVideoFullscreenInterfaceMac::enterFullscreen):
(WebCore::WebVideoFullscreenInterfaceMac::exitFullscreen):
(WebCore::WebVideoFullscreenInterfaceMac::cleanupFullscreen):
(WebCore::WebVideoFullscreenInterfaceMac::invalidate):
(WebCore::WebVideoFullscreenInterfaceMac::requestHideAndExitFullscreen):
(WebCore::WebVideoFullscreenInterfaceMac::preparedToReturnToInline):
(WebCore::WebVideoFullscreenInterfaceMac::setMode):
(WebCore::WebVideoFullscreenInterfaceMac::clearMode):
(WebCore::WebVideoFullscreenInterfaceMac::mayAutomaticallyShowVideoPictureInPicture):
(WebCore::WebVideoFullscreenInterfaceMac::applicationDidBecomeActive):
(WebCore::supportsPictureInPicture):
Add a stub implementation of WebVideoFullscreenInterfaceMac.
Source/WebKit2:
- UIProcess/Cocoa/WebVideoFullscreenManagerProxy.h:
- UIProcess/Cocoa/WebVideoFullscreenManagerProxy.messages.in:
- UIProcess/Cocoa/WebVideoFullscreenManagerProxy.mm:
Enabled also for Mac with video presentation mode support.
(-[WKLayerHostView makeBackingLayer]):
Make sure this view uses CALayerHost for its layer.
(WebKit::WebVideoFullscreenManagerProxy::invalidate):
(WebKit::WebVideoFullscreenManagerProxy::createModelAndInterface):
(WebKit::WebVideoFullscreenManagerProxy::ensureInterface):
(WebKit::WebVideoFullscreenManagerProxy::setupFullscreenWithID):
Replace WebCore::WebVideoFullscreenInterfaceAVKit with PlatformWebVideoFullscreenInterface.
(WebKit::WebVideoFullscreenManagerProxy::setVideoLayerFrame):
+[UIWindow _synchronizeDrawingAcrossProcesses] is not available on Mac.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::reattachToWebProcess):
(WebKit::WebPageProxy::viewDidLeaveWindow):
(WebKit::WebPageProxy::resetState):
- UIProcess/WebPageProxy.h:
The code that creates m_videoFullscreenManager is now enabled also on Mac with video
presentation mode support.
- WebProcess/WebCoreSupport/WebChromeClient.cpp:
- WebProcess/WebCoreSupport/WebChromeClient.h:
Enable the API related to the video fullscreen layer also on Mac with video presentation
mode support.
- WebProcess/WebPage/WebPage.cpp:
- WebProcess/WebPage/WebPage.h:
The code that creates m_videoFullscreenManager is now enabled also on Mac with video
presentation mode support.
- WebProcess/cocoa/WebVideoFullscreenManager.h:
- WebProcess/cocoa/WebVideoFullscreenManager.messages.in:
- WebProcess/cocoa/WebVideoFullscreenManager.mm:
Enabled also for Mac with video presentation mode support.
(WebKit::WebVideoFullscreenManager::supportsVideoFullscreen):
Return false for now on Mac.
- 10:18 AM Changeset in webkit [195754] by
-
- 1 edit in branches/safari-601-branch/LayoutTests/TestExpectations
Skip test that rely on ES6. rdar://problem/24190123
- 10:15 AM Changeset in webkit [195753] by
-
- 2 deletes in branches/safari-601-branch/LayoutTests/svg/custom
Remove pattern-content-inheritance-cycle tests. rdar://problem/23910829
- 10:08 AM Changeset in webkit [195752] by
-
- 491 edits in trunk/LayoutTests
[Win] gardening after r195740. (more to follow)
Unreviewed.
- platform/win/css1/basic/containment-expected.txt:
- platform/win/css1/basic/contextual_selectors-expected.txt:
- platform/win/css1/basic/grouping-expected.txt:
- platform/win/css1/basic/id_as_selector-expected.txt:
- platform/win/css1/basic/inheritance-expected.txt:
- platform/win/css1/box_properties/border-expected.txt:
- platform/win/css1/box_properties/border_bottom-expected.txt:
- platform/win/css1/box_properties/border_bottom_inline-expected.txt:
- platform/win/css1/box_properties/border_bottom_width-expected.txt:
- platform/win/css1/box_properties/border_bottom_width_inline-expected.txt:
- platform/win/css1/box_properties/border_color-expected.txt:
- platform/win/css1/box_properties/border_color_inline-expected.txt:
- platform/win/css1/box_properties/border_inline-expected.txt:
- platform/win/css1/box_properties/border_left-expected.txt:
- platform/win/css1/box_properties/border_left_inline-expected.txt:
- platform/win/css1/box_properties/border_left_width-expected.txt:
- platform/win/css1/box_properties/border_left_width_inline-expected.txt:
- platform/win/css1/box_properties/border_right-expected.txt:
- platform/win/css1/box_properties/border_right_inline-expected.txt:
- platform/win/css1/box_properties/border_right_width-expected.txt:
- platform/win/css1/box_properties/border_right_width_inline-expected.txt:
- platform/win/css1/box_properties/border_style-expected.txt:
- platform/win/css1/box_properties/border_style_inline-expected.txt:
- platform/win/css1/box_properties/border_top-expected.txt:
- platform/win/css1/box_properties/border_top_inline-expected.txt:
- platform/win/css1/box_properties/border_top_width-expected.txt:
- platform/win/css1/box_properties/border_top_width_inline-expected.txt:
- platform/win/css1/box_properties/border_width-expected.txt:
- platform/win/css1/box_properties/border_width_inline-expected.txt:
- platform/win/css1/box_properties/clear-expected.txt:
- platform/win/css1/box_properties/clear_float-expected.txt:
- platform/win/css1/box_properties/float-expected.txt:
- platform/win/css1/box_properties/float_elements_in_series-expected.txt:
- platform/win/css1/box_properties/float_margin-expected.txt:
- platform/win/css1/box_properties/float_on_text_elements-expected.txt:
- platform/win/css1/box_properties/height-expected.txt:
- platform/win/css1/box_properties/margin-expected.txt:
- platform/win/css1/box_properties/margin_bottom-expected.txt:
- platform/win/css1/box_properties/margin_bottom_inline-expected.txt:
- platform/win/css1/box_properties/margin_inline-expected.txt:
- platform/win/css1/box_properties/margin_left-expected.txt:
- platform/win/css1/box_properties/margin_left_inline-expected.txt:
- platform/win/css1/box_properties/margin_right-expected.txt:
- platform/win/css1/box_properties/margin_right_inline-expected.txt:
- platform/win/css1/box_properties/margin_top-expected.txt:
- platform/win/css1/box_properties/margin_top_inline-expected.txt:
- platform/win/css1/box_properties/padding-expected.txt:
- platform/win/css1/box_properties/padding_bottom-expected.txt:
- platform/win/css1/box_properties/padding_bottom_inline-expected.txt:
- platform/win/css1/box_properties/padding_inline-expected.txt:
- platform/win/css1/box_properties/padding_left_inline-expected.txt:
- platform/win/css1/box_properties/padding_right-expected.txt:
- platform/win/css1/box_properties/padding_right_inline-expected.txt:
- platform/win/css1/box_properties/padding_top-expected.txt:
- platform/win/css1/box_properties/padding_top_inline-expected.txt:
- platform/win/css1/box_properties/width-expected.txt:
- platform/win/css1/cascade/cascade_order-expected.txt:
- platform/win/css1/cascade/important-expected.txt:
- platform/win/css1/classification/display-expected.txt:
- platform/win/css1/classification/list_style-expected.txt:
- platform/win/css1/classification/list_style_image-expected.txt:
- platform/win/css1/classification/list_style_position-expected.txt:
- platform/win/css1/classification/list_style_type-expected.txt:
- platform/win/css1/classification/white_space-expected.txt:
- platform/win/css1/color_and_background/background-expected.txt:
- platform/win/css1/color_and_background/background_attachment-expected.txt:
- platform/win/css1/color_and_background/background_color-expected.txt:
- platform/win/css1/color_and_background/background_image-expected.txt:
- platform/win/css1/color_and_background/background_position-expected.txt:
- platform/win/css1/color_and_background/background_repeat-expected.txt:
- platform/win/css1/color_and_background/color-expected.txt:
- platform/win/css1/conformance/forward_compatible_parsing-expected.txt:
- platform/win/css1/font_properties/font-expected.txt:
- platform/win/css1/font_properties/font_family-expected.txt:
- platform/win/css1/font_properties/font_size-expected.txt:
- platform/win/css1/font_properties/font_style-expected.txt:
- platform/win/css1/font_properties/font_variant-expected.txt:
- platform/win/css1/font_properties/font_weight-expected.txt:
- platform/win/css1/formatting_model/canvas-expected.txt:
- platform/win/css1/formatting_model/floating_elements-expected.txt:
- platform/win/css1/formatting_model/height_of_lines-expected.txt:
- platform/win/css1/formatting_model/inline_elements-expected.txt:
- platform/win/css1/formatting_model/replaced_elements-expected.txt:
- platform/win/css1/formatting_model/vertical_formatting-expected.txt:
- platform/win/css1/pseudo/anchor-expected.txt:
- platform/win/css1/pseudo/firstletter-expected.txt:
- platform/win/css1/pseudo/firstline-expected.txt:
- platform/win/css1/pseudo/multiple_pseudo_elements-expected.txt:
- platform/win/css1/pseudo/pseudo_elements_in_selectors-expected.txt:
- platform/win/css1/text_properties/letter_spacing-expected.txt:
- platform/win/css1/text_properties/line_height-expected.txt:
- platform/win/css1/text_properties/text_align-expected.txt:
- platform/win/css1/text_properties/text_decoration-expected.txt:
- platform/win/css1/text_properties/text_indent-expected.txt:
- platform/win/css1/text_properties/text_transform-expected.txt:
- platform/win/css1/text_properties/vertical_align-expected.txt:
- platform/win/css1/text_properties/word_spacing-expected.txt:
- platform/win/css1/units/color_units-expected.txt:
- platform/win/css1/units/length_units-expected.txt:
- platform/win/css1/units/percentage_units-expected.txt:
- platform/win/css1/units/urls-expected.txt:
- platform/win/css2.1/20110323/border-collapse-offset-002-expected.txt:
- platform/win/css2.1/20110323/border-conflict-style-079-expected.txt:
- platform/win/css2.1/20110323/border-conflict-style-088-expected.txt:
- platform/win/css2.1/20110323/dynamic-top-change-002-expected.txt:
- platform/win/css2.1/20110323/dynamic-top-change-003-expected.txt:
- platform/win/css2.1/20110323/inline-table-001-expected.txt:
- platform/win/css2.1/20110323/inline-table-002a-expected.txt:
- platform/win/css2.1/20110323/inline-table-003-expected.txt:
- platform/win/css2.1/20110323/margin-applies-to-001-expected.txt:
- platform/win/css2.1/20110323/margin-applies-to-002-expected.txt:
- platform/win/css2.1/20110323/margin-applies-to-003-expected.txt:
- platform/win/css2.1/20110323/margin-applies-to-004-expected.txt:
- platform/win/css2.1/20110323/margin-applies-to-005-expected.txt:
- platform/win/css2.1/20110323/margin-applies-to-006-expected.txt:
- platform/win/css2.1/20110323/margin-applies-to-007-expected.txt:
- platform/win/css2.1/20110323/margin-applies-to-013-expected.txt:
- platform/win/css2.1/20110323/margin-applies-to-014-expected.txt:
- platform/win/css2.1/20110323/margin-applies-to-015-expected.txt:
- platform/win/css2.1/20110323/replaced-intrinsic-ratio-001-expected.txt:
- platform/win/css2.1/20110323/table-caption-001-expected.txt:
- platform/win/css2.1/20110323/table-caption-optional-001-expected.txt:
- platform/win/css2.1/20110323/table-caption-optional-002-expected.txt:
- platform/win/css2.1/20110323/table-height-algorithm-023-expected.txt:
- platform/win/css2.1/20110323/table-height-algorithm-024-expected.txt:
- platform/win/css2.1/t040302-c61-ex-len-00-b-a-expected.txt:
- platform/win/css2.1/t0803-c5501-mrgn-t-00-b-a-expected.txt:
- platform/win/css2.1/t0803-c5503-mrgn-b-00-b-a-expected.txt:
- platform/win/css2.1/t080301-c411-vt-mrgn-00-b-expected.txt:
- platform/win/css2.1/t0804-c5506-padn-t-00-b-a-expected.txt:
- platform/win/css2.1/t0804-c5508-ipadn-b-03-b-a-expected.txt:
- platform/win/css2.1/t0805-c5511-brdr-tw-00-b-expected.txt:
- platform/win/css2.1/t0805-c5513-brdr-bw-00-b-expected.txt:
- platform/win/css2.1/t0805-c5518-brdr-t-01-e-expected.txt:
- platform/win/css2.1/t0805-c5519-brdr-r-01-e-expected.txt:
- platform/win/css2.1/t0805-c5520-brdr-b-01-e-expected.txt:
- platform/win/css2.1/t0805-c5521-brdr-l-01-e-expected.txt:
- platform/win/css2.1/t0805-c5522-brdr-02-e-expected.txt:
- platform/win/css2.1/t090402-c42-ibx-pad-00-d-ag-expected.txt:
- platform/win/css2.1/t0905-c5525-fltmult-00-d-g-expected.txt:
- platform/win/css2.1/t170602-bdr-conflct-w-00-d-expected.txt:
- platform/win/css2.1/t170602-bdr-conflct-w-01-d-expected.txt:
- platform/win/css2.1/t170602-bdr-conflct-w-02-d-expected.txt:
- platform/win/css2.1/t170602-bdr-conflct-w-03-d-expected.txt:
- platform/win/css2.1/t170602-bdr-conflct-w-04-d-expected.txt:
- platform/win/css2.1/t170602-bdr-conflct-w-05-d-expected.txt:
- platform/win/css2.1/t170602-bdr-conflct-w-06-d-expected.txt:
- platform/win/css2.1/t170602-bdr-conflct-w-07-d-expected.txt:
- platform/win/css2.1/t170602-bdr-conflct-w-08-d-expected.txt:
- platform/win/css2.1/t170602-bdr-conflct-w-09-d-expected.txt:
- platform/win/css2.1/t170602-bdr-conflct-w-10-d-expected.txt:
- platform/win/css2.1/t170602-bdr-conflct-w-11-d-expected.txt:
- platform/win/css2.1/t170602-bdr-conflct-w-12-d-expected.txt:
- platform/win/css2.1/t170602-bdr-conflct-w-13-d-expected.txt:
- platform/win/css2.1/t170602-bdr-conflct-w-14-d-expected.txt:
- platform/win/css2.1/t170602-bdr-conflct-w-15-d-expected.txt:
- platform/win/css2.1/t170602-bdr-conflct-w-16-d-expected.txt:
- platform/win/css2.1/t170602-bdr-conflct-w-17-d-expected.txt:
- platform/win/css2.1/t170602-bdr-conflct-w-18-d-expected.txt:
- platform/win/css2.1/t170602-bdr-conflct-w-19-d-expected.txt:
- platform/win/css2.1/t170602-bdr-conflct-w-20-d-expected.txt:
- platform/win/css2.1/t170602-bdr-conflct-w-21-d-expected.txt:
- platform/win/css2.1/t170602-bdr-conflct-w-22-d-expected.txt:
- platform/win/css2.1/t170602-bdr-conflct-w-23-d-expected.txt:
- platform/win/css2.1/t170602-bdr-conflct-w-24-d-expected.txt:
- platform/win/css2.1/t170602-bdr-conflct-w-25-d-expected.txt:
- platform/win/css2.1/t170602-bdr-conflct-w-26-d-expected.txt:
- platform/win/css2.1/t170602-bdr-conflct-w-27-d-expected.txt:
- platform/win/css2.1/t170602-bdr-conflct-w-28-d-expected.txt:
- platform/win/css2.1/t170602-bdr-conflct-w-29-d-expected.txt:
- platform/win/css2.1/t170602-bdr-conflct-w-30-d-expected.txt:
- platform/win/css2.1/t170602-bdr-conflct-w-31-d-expected.txt:
- platform/win/css2.1/t170602-bdr-conflct-w-32-d-expected.txt:
- platform/win/css2.1/t170602-bdr-conflct-w-33-d-expected.txt:
- platform/win/css2.1/t170602-bdr-conflct-w-34-d-expected.txt:
- platform/win/css2.1/t170602-bdr-conflct-w-35-d-expected.txt:
- platform/win/css2.1/t170602-bdr-conflct-w-36-d-expected.txt:
- platform/win/css2.1/t170602-bdr-conflct-w-37-d-expected.txt:
- platform/win/css2.1/t170602-bdr-conflct-w-38-d-expected.txt:
- platform/win/css2.1/t170602-bdr-conflct-w-39-d-expected.txt:
- platform/win/css2.1/t170602-bdr-conflct-w-40-d-expected.txt:
- platform/win/css2.1/t170602-bdr-conflct-w-41-d-expected.txt:
- platform/win/css2.1/t170602-bdr-conflct-w-42-d-expected.txt:
- platform/win/css2.1/t170602-bdr-conflct-w-43-d-expected.txt:
- platform/win/css2.1/t170602-bdr-conflct-w-44-d-expected.txt:
- platform/win/css2.1/t170602-bdr-conflct-w-45-d-expected.txt:
- platform/win/css2.1/t170602-bdr-conflct-w-46-d-expected.txt:
- platform/win/css2.1/t170602-bdr-conflct-w-47-d-expected.txt:
- platform/win/css2.1/t170602-bdr-conflct-w-48-d-expected.txt:
- platform/win/css2.1/t170602-bdr-conflct-w-49-d-expected.txt:
- platform/win/css2.1/t170602-bdr-conflct-w-50-d-expected.txt:
- platform/win/css2.1/t170602-bdr-conflct-w-51-d-expected.txt:
- platform/win/css2.1/t170602-bdr-conflct-w-52-d-expected.txt:
- platform/win/css2.1/t170602-bdr-conflct-w-53-d-expected.txt:
- platform/win/css2.1/t170602-bdr-conflct-w-54-d-expected.txt:
- platform/win/css2.1/t170602-bdr-conflct-w-55-d-expected.txt:
- platform/win/css2.1/t170602-bdr-conflct-w-56-d-expected.txt:
- platform/win/css2.1/t170602-bdr-conflct-w-57-d-expected.txt:
- platform/win/css2.1/t170602-bdr-conflct-w-58-d-expected.txt:
- platform/win/css2.1/t170602-bdr-conflct-w-59-d-expected.txt:
- platform/win/css2.1/t170602-bdr-conflct-w-60-d-expected.txt:
- platform/win/css2.1/t170602-bdr-conflct-w-61-d-expected.txt:
- platform/win/css2.1/t170602-bdr-conflct-w-62-d-expected.txt:
- platform/win/css2.1/t170602-bdr-conflct-w-63-d-expected.txt:
- platform/win/css2.1/t170602-bdr-conflct-w-64-d-expected.txt:
- platform/win/css2.1/t170602-bdr-conflct-w-65-d-expected.txt:
- platform/win/css2.1/t170602-bdr-conflct-w-66-d-expected.txt:
- platform/win/css2.1/t170602-bdr-conflct-w-67-d-expected.txt:
- platform/win/css2.1/t170602-bdr-conflct-w-68-d-expected.txt:
- platform/win/css2.1/t170602-bdr-conflct-w-69-d-expected.txt:
- platform/win/css2.1/t170602-bdr-conflct-w-70-d-expected.txt:
- platform/win/css2.1/t170602-bdr-conflct-w-71-d-expected.txt:
- platform/win/css2.1/t170602-bdr-conflct-w-72-d-expected.txt:
- platform/win/css2.1/t170602-bdr-conflct-w-73-d-expected.txt:
- platform/win/css2.1/t170602-bdr-conflct-w-74-d-expected.txt:
- platform/win/css2.1/t170602-bdr-conflct-w-75-d-expected.txt:
- platform/win/css2.1/t170602-bdr-conflct-w-76-d-expected.txt:
- platform/win/css2.1/t170602-bdr-conflct-w-77-d-expected.txt:
- platform/win/css2.1/t170602-bdr-conflct-w-78-d-expected.txt:
- platform/win/css2.1/t170602-bdr-conflct-w-79-d-expected.txt:
- platform/win/css2.1/t170602-bdr-conflct-w-80-d-expected.txt:
- platform/win/css2.1/t170602-bdr-conflct-w-81-d-expected.txt:
- platform/win/css2.1/t170602-bdr-conflct-w-82-d-expected.txt:
- platform/win/css2.1/t170602-bdr-conflct-w-83-d-expected.txt:
- platform/win/css2.1/t170602-bdr-conflct-w-84-d-expected.txt:
- platform/win/css2.1/t170602-bdr-conflct-w-85-d-expected.txt:
- platform/win/css2.1/t170602-bdr-conflct-w-86-d-expected.txt:
- platform/win/css2.1/t170602-bdr-conflct-w-87-d-expected.txt:
- platform/win/css2.1/t170602-bdr-conflct-w-88-d-expected.txt:
- platform/win/css2.1/t170602-bdr-conflct-w-89-d-expected.txt:
- platform/win/css2.1/t170602-bdr-conflct-w-90-d-expected.txt:
- platform/win/css2.1/t170602-bdr-conflct-w-91-d-expected.txt:
- platform/win/css2.1/t170602-bdr-conflct-w-92-d-expected.txt:
- platform/win/css2.1/t170602-bdr-conflct-w-93-d-expected.txt:
- platform/win/css2.1/t170602-bdr-conflct-w-94-d-expected.txt:
- platform/win/css2.1/t170602-bdr-conflct-w-95-d-expected.txt:
- platform/win/css2.1/t170602-bdr-conflct-w-96-d-expected.txt:
- platform/win/css2.1/t170602-bdr-conflct-w-97-d-expected.txt:
- platform/win/css2.1/t170602-bdr-conflct-w-98-d-expected.txt:
- platform/win/css2.1/t170602-bdr-conflct-w-99-d-expected.txt:
- platform/win/css2.1/tables/table-anonymous-objects-015-expected.txt:
- platform/win/css2.1/tables/table-anonymous-objects-016-expected.txt:
- platform/win/css2.1/tables/table-anonymous-objects-023-expected.txt:
- platform/win/css2.1/tables/table-anonymous-objects-024-expected.txt:
- platform/win/css2.1/tables/table-anonymous-objects-035-expected.txt:
- platform/win/css2.1/tables/table-anonymous-objects-036-expected.txt:
- platform/win/css2.1/tables/table-anonymous-objects-037-expected.txt:
- platform/win/css2.1/tables/table-anonymous-objects-038-expected.txt:
- platform/win/css2.1/tables/table-anonymous-objects-045-expected.txt:
- platform/win/css2.1/tables/table-anonymous-objects-046-expected.txt:
- platform/win/css2.1/tables/table-anonymous-objects-047-expected.txt:
- platform/win/css2.1/tables/table-anonymous-objects-048-expected.txt:
- platform/win/css2.1/tables/table-anonymous-objects-049-expected.txt:
- platform/win/css2.1/tables/table-anonymous-objects-050-expected.txt:
- platform/win/css2.1/tables/table-anonymous-objects-055-expected.txt:
- platform/win/css2.1/tables/table-anonymous-objects-056-expected.txt:
- platform/win/css2.1/tables/table-anonymous-objects-091-expected.txt:
- platform/win/css2.1/tables/table-anonymous-objects-092-expected.txt:
- platform/win/css2.1/tables/table-anonymous-objects-099-expected.txt:
- platform/win/css2.1/tables/table-anonymous-objects-100-expected.txt:
- platform/win/css2.1/tables/table-anonymous-objects-103-expected.txt:
- platform/win/css2.1/tables/table-anonymous-objects-104-expected.txt:
- platform/win/css2.1/tables/table-anonymous-objects-105-expected.txt:
- platform/win/css2.1/tables/table-anonymous-objects-106-expected.txt:
- platform/win/css2.1/tables/table-anonymous-objects-107-expected.txt:
- platform/win/css2.1/tables/table-anonymous-objects-108-expected.txt:
- platform/win/css2.1/tables/table-anonymous-objects-109-expected.txt:
- platform/win/css2.1/tables/table-anonymous-objects-110-expected.txt:
- platform/win/css2.1/tables/table-anonymous-objects-111-expected.txt:
- platform/win/css2.1/tables/table-anonymous-objects-112-expected.txt:
- platform/win/css2.1/tables/table-anonymous-objects-113-expected.txt:
- platform/win/css2.1/tables/table-anonymous-objects-114-expected.txt:
- platform/win/css2.1/tables/table-anonymous-objects-123-expected.txt:
- platform/win/css2.1/tables/table-anonymous-objects-124-expected.txt:
- platform/win/css2.1/tables/table-anonymous-objects-139-expected.txt:
- platform/win/css2.1/tables/table-anonymous-objects-140-expected.txt:
- platform/win/css2.1/tables/table-anonymous-objects-149-expected.txt:
- platform/win/css2.1/tables/table-anonymous-objects-150-expected.txt:
- platform/win/css2.1/tables/table-anonymous-objects-155-expected.txt:
- platform/win/css2.1/tables/table-anonymous-objects-156-expected.txt:
- platform/win/css2.1/tables/table-anonymous-objects-159-expected.txt:
- platform/win/css2.1/tables/table-anonymous-objects-160-expected.txt:
- platform/win/css2.1/tables/table-anonymous-objects-165-expected.txt:
- platform/win/css2.1/tables/table-anonymous-objects-166-expected.txt:
- platform/win/css2.1/tables/table-anonymous-objects-177-expected.txt:
- platform/win/css2.1/tables/table-anonymous-objects-178-expected.txt:
- platform/win/css2.1/tables/table-anonymous-objects-179-expected.txt:
- platform/win/css2.1/tables/table-anonymous-objects-180-expected.txt:
- platform/win/css2.1/tables/table-anonymous-objects-181-expected.txt:
- platform/win/css2.1/tables/table-anonymous-objects-189-expected.txt:
- platform/win/css2.1/tables/table-anonymous-objects-190-expected.txt:
- platform/win/css2.1/tables/table-anonymous-objects-191-expected.txt:
- platform/win/css2.1/tables/table-anonymous-objects-192-expected.txt:
- platform/win/css2.1/tables/table-anonymous-objects-193-expected.txt:
- platform/win/css2.1/tables/table-anonymous-objects-194-expected.txt:
- platform/win/css2.1/tables/table-anonymous-objects-195-expected.txt:
- platform/win/css2.1/tables/table-anonymous-objects-196-expected.txt:
- platform/win/css2.1/tables/table-anonymous-objects-205-expected.txt:
- platform/win/css2.1/tables/table-anonymous-objects-206-expected.txt:
- platform/win/css2.1/tables/table-anonymous-objects-207-expected.txt:
- platform/win/css2.1/tables/table-anonymous-objects-208-expected.txt:
- platform/win/css3/css3-modsel-33-expected.txt:
- platform/win/css3/flexbox/flexbox-baseline-expected.txt:
- platform/win/css3/selectors3/html/css3-modsel-161-expected.txt:
- platform/win/css3/selectors3/html/css3-modsel-18-expected.txt:
- platform/win/css3/selectors3/html/css3-modsel-18b-expected.txt:
- platform/win/css3/selectors3/html/css3-modsel-28-expected.txt:
- platform/win/css3/selectors3/html/css3-modsel-28b-expected.txt:
- platform/win/css3/selectors3/html/css3-modsel-29-expected.txt:
- platform/win/css3/selectors3/html/css3-modsel-29b-expected.txt:
- platform/win/css3/selectors3/html/css3-modsel-32-expected.txt:
- platform/win/css3/selectors3/html/css3-modsel-33-expected.txt:
- platform/win/css3/selectors3/html/css3-modsel-43-expected.txt:
- platform/win/css3/selectors3/html/css3-modsel-43b-expected.txt:
- platform/win/css3/selectors3/html/css3-modsel-44-expected.txt:
- platform/win/css3/selectors3/html/css3-modsel-44b-expected.txt:
- platform/win/css3/selectors3/html/css3-modsel-73-expected.txt:
- platform/win/css3/selectors3/html/css3-modsel-73b-expected.txt:
- platform/win/css3/selectors3/html/css3-modsel-74-expected.txt:
- platform/win/css3/selectors3/html/css3-modsel-74b-expected.txt:
- platform/win/css3/selectors3/html/css3-modsel-77-expected.txt:
- platform/win/css3/selectors3/html/css3-modsel-77b-expected.txt:
- platform/win/css3/selectors3/html/css3-modsel-78-expected.txt:
- platform/win/css3/selectors3/html/css3-modsel-78b-expected.txt:
- platform/win/css3/selectors3/xhtml/css3-modsel-161-expected.txt:
- platform/win/css3/selectors3/xhtml/css3-modsel-18-expected.txt:
- platform/win/css3/selectors3/xhtml/css3-modsel-18b-expected.txt:
- platform/win/css3/selectors3/xhtml/css3-modsel-28-expected.txt:
- platform/win/css3/selectors3/xhtml/css3-modsel-28b-expected.txt:
- platform/win/css3/selectors3/xhtml/css3-modsel-29-expected.txt:
- platform/win/css3/selectors3/xhtml/css3-modsel-29b-expected.txt:
- platform/win/css3/selectors3/xhtml/css3-modsel-32-expected.txt:
- platform/win/css3/selectors3/xhtml/css3-modsel-33-expected.txt:
- platform/win/css3/selectors3/xhtml/css3-modsel-43-expected.txt:
- platform/win/css3/selectors3/xhtml/css3-modsel-43b-expected.txt:
- platform/win/css3/selectors3/xhtml/css3-modsel-44-expected.txt:
- platform/win/css3/selectors3/xhtml/css3-modsel-44b-expected.txt:
- platform/win/css3/selectors3/xhtml/css3-modsel-73-expected.txt:
- platform/win/css3/selectors3/xhtml/css3-modsel-73b-expected.txt:
- platform/win/css3/selectors3/xhtml/css3-modsel-74-expected.txt:
- platform/win/css3/selectors3/xhtml/css3-modsel-74b-expected.txt:
- platform/win/css3/selectors3/xhtml/css3-modsel-77-expected.txt:
- platform/win/css3/selectors3/xhtml/css3-modsel-77b-expected.txt:
- platform/win/css3/selectors3/xhtml/css3-modsel-78-expected.txt:
- platform/win/css3/selectors3/xhtml/css3-modsel-78b-expected.txt:
- platform/win/css3/selectors3/xml/css3-modsel-161-expected.txt:
- platform/win/css3/selectors3/xml/css3-modsel-18-expected.txt:
- platform/win/css3/selectors3/xml/css3-modsel-18b-expected.txt:
- platform/win/css3/selectors3/xml/css3-modsel-28-expected.txt:
- platform/win/css3/selectors3/xml/css3-modsel-28b-expected.txt:
- platform/win/css3/selectors3/xml/css3-modsel-29-expected.txt:
- platform/win/css3/selectors3/xml/css3-modsel-29b-expected.txt:
- platform/win/css3/selectors3/xml/css3-modsel-32-expected.txt:
- platform/win/css3/selectors3/xml/css3-modsel-33-expected.txt:
- platform/win/css3/selectors3/xml/css3-modsel-43-expected.txt:
- platform/win/css3/selectors3/xml/css3-modsel-43b-expected.txt:
- platform/win/css3/selectors3/xml/css3-modsel-44-expected.txt:
- platform/win/css3/selectors3/xml/css3-modsel-44b-expected.txt:
- platform/win/css3/selectors3/xml/css3-modsel-73-expected.txt:
- platform/win/css3/selectors3/xml/css3-modsel-73b-expected.txt:
- platform/win/css3/selectors3/xml/css3-modsel-74-expected.txt:
- platform/win/css3/selectors3/xml/css3-modsel-74b-expected.txt:
- platform/win/css3/selectors3/xml/css3-modsel-77-expected.txt:
- platform/win/css3/selectors3/xml/css3-modsel-77b-expected.txt:
- platform/win/css3/selectors3/xml/css3-modsel-78-expected.txt:
- platform/win/css3/selectors3/xml/css3-modsel-78b-expected.txt:
- platform/win/editing/deleting/4922367-expected.txt:
- platform/win/editing/deleting/5099303-expected.txt:
- platform/win/editing/deleting/5126166-expected.txt:
- platform/win/editing/deleting/5144139-2-expected.txt:
- platform/win/editing/deleting/5206311-1-expected.txt:
- platform/win/editing/deleting/5433862-2-expected.txt:
- platform/win/editing/deleting/5483370-expected.txt:
- platform/win/editing/deleting/delete-to-select-table-expected.txt:
- platform/win/editing/deleting/table-cells-expected.txt:
- platform/win/editing/execCommand/5481523-expected.txt:
- platform/win/editing/inserting/5058163-1-expected.txt:
- platform/win/editing/inserting/insert-paragraph-01-expected.txt:
- platform/win/editing/inserting/insert-paragraph-02-expected.txt:
- platform/win/editing/inserting/paragraph-separator-in-table-1-expected.txt:
- platform/win/editing/inserting/paragraph-separator-in-table-2-expected.txt:
- platform/win/editing/style/5017613-1-expected.txt:
- platform/win/editing/style/5017613-2-expected.txt:
- platform/win/editing/style/apple-style-editable-mix-expected.txt:
- platform/win/editing/style/table-selection-expected.txt:
- platform/win/editing/unsupported-content/table-type-after-expected.txt:
- platform/win/editing/unsupported-content/table-type-before-expected.txt:
- platform/win/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.txt:
- platform/win/fast/block/basic/016-expected.txt:
- platform/win/fast/block/basic/quirk-percent-height-table-cell-expected.txt:
- platform/win/fast/block/float/011-expected.txt:
- platform/win/fast/block/float/015-expected.txt:
- platform/win/fast/block/margin-collapse/001-expected.txt:
- platform/win/fast/block/margin-collapse/005-expected.txt:
- platform/win/fast/block/margin-collapse/006-expected.txt:
- platform/win/fast/block/margin-collapse/010-expected.txt:
- platform/win/fast/block/margin-collapse/011-expected.txt:
- platform/win/fast/block/margin-collapse/012-expected.txt:
- platform/win/fast/block/margin-collapse/015-expected.txt:
- platform/win/fast/block/margin-collapse/016-expected.txt:
- platform/win/fast/block/margin-collapse/017-expected.txt:
- platform/win/fast/block/margin-collapse/018-expected.txt:
- platform/win/fast/block/margin-collapse/019-expected.txt:
- platform/win/fast/block/margin-collapse/020-expected.txt:
- platform/win/fast/block/margin-collapse/022-expected.txt:
- platform/win/fast/block/margin-collapse/025-expected.txt:
- platform/win/fast/block/margin-collapse/032-expected.txt:
- platform/win/fast/block/margin-collapse/033-expected.txt:
- platform/win/fast/block/margin-collapse/034-expected.txt:
- platform/win/fast/block/margin-collapse/041-expected.txt:
- platform/win/fast/block/margin-collapse/042-expected.txt:
- platform/win/fast/block/margin-collapse/055-expected.txt:
- platform/win/fast/block/margin-collapse/056-expected.txt:
- platform/win/fast/block/margin-collapse/057-expected.txt:
- platform/win/fast/block/margin-collapse/058-expected.txt:
- platform/win/fast/block/margin-collapse/059-expected.txt:
- platform/win/fast/block/margin-collapse/104-expected.txt:
- platform/win/fast/block/margin-collapse/block-inside-inline/001-expected.txt:
- platform/win/fast/block/margin-collapse/block-inside-inline/005-expected.txt:
- platform/win/fast/block/margin-collapse/block-inside-inline/006-expected.txt:
- platform/win/fast/block/margin-collapse/block-inside-inline/010-expected.txt:
- platform/win/fast/block/margin-collapse/block-inside-inline/011-expected.txt:
- platform/win/fast/block/margin-collapse/block-inside-inline/012-expected.txt:
- platform/win/fast/block/margin-collapse/block-inside-inline/015-expected.txt:
- platform/win/fast/block/margin-collapse/block-inside-inline/016-expected.txt:
- platform/win/fast/block/margin-collapse/block-inside-inline/017-expected.txt:
- platform/win/fast/block/margin-collapse/block-inside-inline/018-expected.txt:
- platform/win/fast/block/margin-collapse/block-inside-inline/019-expected.txt:
- platform/win/fast/block/margin-collapse/block-inside-inline/020-expected.txt:
- platform/win/fast/block/margin-collapse/block-inside-inline/021-expected.txt:
- platform/win/fast/block/margin-collapse/block-inside-inline/022-expected.txt:
- platform/win/fast/block/margin-collapse/block-inside-inline/025-expected.txt:
- platform/win/fast/block/positioning/053-expected.txt:
- platform/win/fast/block/positioning/negative-right-pos-expected.txt:
- platform/win/fast/block/positioning/table-cell-static-position-expected.txt:
- platform/win/fast/borders/bidi-009a-expected.txt:
- platform/win/fast/borders/border-antialiasing-expected.txt:
- platform/win/fast/borders/border-radius-different-width-001-expected.txt:
- platform/win/fast/borders/table-borders-expected.txt:
- platform/win/fast/box-shadow/basic-shadows-expected.txt:
- platform/win/fast/css-generated-content/015-expected.txt:
- platform/win/fast/css-generated-content/first-letter-in-nested-before-expected.txt:
- platform/win/fast/css-generated-content/first-letter-in-nested-before-table-expected.txt:
- platform/win/fast/css-generated-content/inline-display-types-expected.txt:
- platform/win/fast/css-generated-content/nested-tables-with-before-after-content-crash-expected.txt:
- platform/win/fast/css-generated-content/table-before-after-child-add-expected.txt:
- platform/win/fast/css-generated-content/table-cell-before-after-child-add-expected.txt:
- platform/win/fast/css-generated-content/table-cell-before-content-expected.txt:
- platform/win/fast/css-generated-content/table-parts-before-and-after-expected.txt:
- platform/win/fast/css-generated-content/table-row-before-after-child-add-expected.txt:
- platform/win/fast/css-generated-content/table-row-before-after-expected.txt:
- platform/win/fast/css-generated-content/table-row-group-with-before-expected.txt:
- platform/win/fast/css-generated-content/table-row-with-before-expected.txt:
- platform/win/fast/css-generated-content/table-table-before-after-child-add-expected.txt:
- platform/win/fast/css-generated-content/table-with-before-expected.txt:
- platform/win/fast/css/003-expected.txt:
- platform/win/fast/css/absolute-poition-in-rtl-parent-expected.txt:
- platform/win/fast/css/acid2-expected.txt:
- platform/win/fast/css/acid2-pixel-expected.txt:
- platform/win/fast/css/bidi-override-in-anonymous-block-expected.txt:
- platform/win/fast/css/box-shadow-and-border-radius-expected.txt:
- platform/win/fast/css/caption-width-absolute-position-expected.txt:
- platform/win/fast/css/caption-width-absolute-position-offset-top-expected.txt:
- platform/win/fast/css/caption-width-fixed-position-expected.txt:
- platform/win/fast/css/caption-width-fixed-position-offset-top-expected.txt:
- platform/win/fast/css/caption-width-relative-position-expected.txt:
- platform/win/fast/css/caption-width-relative-position-offset-top-expected.txt:
- platform/win/fast/css/css3-nth-child-expected.txt:
- platform/win/fast/css/first-letter-float-expected.txt:
- platform/win/fast/css/focus-ring-detached-expected.txt:
- platform/win/fast/css/focus-ring-multiline-expected.txt:
- platform/win/fast/css/h1-in-section-elements-expected.txt:
- platform/win/fast/css/image-rendering-expected.txt:
- platform/win/fast/css/layerZOrderCrash-expected.txt:
- platform/win/fast/css/min-width-with-spanned-cell-expected.txt:
- platform/win/fast/css/percentage-non-integer-expected.txt:
- platform/win/fast/css/table-text-align-quirk-expected.txt:
- platform/win/fast/css/table-text-align-strict-expected.txt:
- platform/win/fast/dom/HTMLTableColElement/resize-table-using-col-width-expected.txt:
- platform/win/fast/dom/HTMLTableElement/createCaption-expected.txt:
- platform/win/fast/dom/row-inner-text-expected.txt:
- platform/win/fast/dynamic/001-expected.txt:
- platform/win/fast/dynamic/007-expected.txt:
- platform/win/fast/dynamic/014-expected.txt:
- platform/win/fast/dynamic/015-expected.txt:
- platform/win/fast/dynamic/containing-block-change-expected.txt:
- platform/win/fast/dynamic/create-renderer-for-whitespace-only-text-expected.txt:
- platform/win/fast/dynamic/float-withdrawal-expected.txt:
- platform/win/fast/dynamic/insert-before-table-part-in-continuation-expected.txt:
- platform/win/fast/dynamic/subtree-table-cell-height-expected.txt:
- 10:07 AM Changeset in webkit [195751] by
-
- 3 edits in branches/safari-601-branch/Source/WebCore/html
Fix failing fast/picture tests.
- 10:00 AM Changeset in webkit [195750] by
-
- 2 edits in branches/safari-601-branch/LayoutTests
Merge r191322. rdar://problem/24190923
- 9:59 AM Changeset in webkit [195749] by
-
- 1 edit1 add in branches/safari-601-branch/LayoutTests
Merge r193931. rdar://problem/24190799
- 9:59 AM Changeset in webkit [195748] by
-
- 3 edits in branches/safari-601-branch/LayoutTests
Merge r194237. rdar://problem/24268438
- 9:46 AM Changeset in webkit [195747] by
-
- 1 edit in branches/safari-601-branch/LayoutTests/css3/font-feature-settings-parsing.html
Fix Font Features test failures.
- 9:44 AM Changeset in webkit [195746] by
-
- 2 edits in trunk/Tools
Unreviewed, rolling out r195742.
Broke EWS
Reverted changeset:
"[webkitdirs] Clarify logic behind is{PortName} functions."
https://bugs.webkit.org/show_bug.cgi?id=153554
http://trac.webkit.org/changeset/195742
- 9:33 AM Changeset in webkit [195745] by
-
- 7 edits2 adds in trunk
[SVG] Add support for 'lighter' operator in feComposite
https://bugs.webkit.org/show_bug.cgi?id=141376
Patch by Nikos Andronikos <nikos.andronikos-webkit@cisra.canon.com.au> on 2016-01-28
Reviewed by Darin Adler.
Source/WebCore:
Added new cases where needed to support the lighter (aka 'plus')
Porter Duff operator in SVG Filter Effects.
https://www.w3.org/TR/filter-effects/#valdef-operator-lighter
Note that in the specification, no constant was added to the IDL for
the lighter operator.
Test: svg/filters/feCompositeOpaque.html
svg/dom/script-tests/SVGAnimatedEnumeration-SVGFECompositeElement.js
- platform/graphics/filters/FEComposite.cpp:
(WebCore::FEComposite::platformApplySoftware):
Add case to support lighter.
(WebCore::operator<<):
Add case to support lighter for text stream operations.
- platform/graphics/filters/FEComposite.h: Add case for lighter to CompositeOperationType enum.
- svg/SVGFECompositeElement.h:
(WebCore::SVGIDLEnumLimits<CompositeOperationType>::highestExposedEnumValue):
Higest exposed value is arithmetic - do not expose lighter.
(WebCore::SVGPropertyTraits<CompositeOperationType>::highestEnumValue):
Highest possible value is now lighter.
(WebCore::SVGPropertyTraits<CompositeOperationType>::toString):
Add case to support lighter.
(WebCore::SVGPropertyTraits<CompositeOperationType>::fromString):
Add case to support lighter.
LayoutTests:
Add case to support lighter to DOM manipulation test for feComposite.
Add a new reftest that tests lighter case and supercedes older
pixel test for other modes.
- svg/dom/script-tests/SVGAnimatedEnumeration-SVGFECompositeElement.js: Test DOM read/write of SVGFEComposite operator property with new lighter mode.
- svg/dom/SVGAnimatedEnumeration-SVGFECompositeElement-expected.txt:
- svg/filters/feCompositeOpaque.html: Added. A reftest that supersedes svg/filters/feComposite.svg That test used opacity 0.5 which resulted in differing colors across platforms. This makes it very hard to maintain the references but it's probably still useful as a regression test. This new test uses solid colors which result in consistency across platforms and allow a reftest to be used.
- svg/filters/feCompositeOpaque-expected.html: Added.
- 9:30 AM Changeset in webkit [195744] by
-
- 2 edits in trunk/Source/JavaScriptCore
LowerToAir::preferRightForResult() should resolve use count ties by selecting the child that is closest in an idom walk
https://bugs.webkit.org/show_bug.cgi?id=153583
Reviewed by Benjamin Poulain.
This undoes the AsmBench/n-body regression in r195654 while preserving that revision's
Kraken progression.
- b3/B3LowerToAir.cpp:
(JSC::B3::Air::LowerToAir::LowerToAir):
(JSC::B3::Air::LowerToAir::preferRightForResult):
- 9:26 AM Changeset in webkit [195743] by
-
- 74 edits7 adds in trunk
Remove equalIgnoringCase since all callers really wanted equalIgnoringASCIICase
https://bugs.webkit.org/show_bug.cgi?id=153411
Reviewed by Ryosuke Niwa.
Source/WebCore:
Tests: fast/media/media-query-non-ASCII-case-folding.html
fast/dom/HTMLAnchorElement/anchor-non-ASCII-case-folding.html
fast/xpath/xpath-non-ASCII-case-folding.html
No tests included that cover the minor behavior changes in Document::setDomain,
CSPSource::schemeMatches, CSPSource::hostMatches, OriginAccessEntry::operator==,
UserContentURLPattern::matches, UserContentURLPattern::matchesHost,
ContentFilterUnblockHandler::canHandleRequest. Would like to add tests for those
if possible, but it seems clear all are progressions.
For background on why this is the right thing to do in almost every case:
- MIME types are all ASCII and not case sensitive (details in RFC 2045) <http://tools.ietf.org/html/rfc2045>
- case insensitive comparisons in HTML are all "ASCII case-insensitive" https://www.w3.org/TR/html/infrastructure.html#ascii-case-insensitive
- same for CSS
- Modules/webdatabase/DatabaseAuthorizer.cpp:
(WebCore::DatabaseAuthorizer::denyBasedOnTableName): Use equalIgnoringASCIICase.
No change in behavior since the string we are comparing with is always
"WebKitDatabaseInfoTable" in practice.
- accessibility/AccessibilityNodeObject.cpp:
(WebCore::siblingWithAriaRole): Changed argument type to take a const char*,
added some FIXMEs and use equalIgnoringCase. No change in behavior since the
strings we are comparing with are "menu" and "menuitem".
(WebCore::AccessibilityNodeObject::menuElementForMenuButton): Updated to pass
arguments in reverse order.
(WebCore::AccessibilityNodeObject::menuItemElementForMenu): Ditto.
- css/CSSParser.cpp:
(WebCore::CSSParser::parseFontFaceValue): Use equalIgnoringASCIICase.
No change in behavior because the property names are all ASCII constants.
- css/CSSParserValues.h: Removed unused equalIgnoringCase function.
- css/MediaQueryEvaluator.cpp:
(WebCore::MediaQueryEvaluator::mediaTypeMatch): Use equalIgnoringASCIICase.
Changes behavior: No non-ASCII case folding when matching media types.
Covered by new test.
(WebCore::MediaQueryEvaluator::mediaTypeMatchSpecific): Use equalIgnoringASCIICase.
No change in behavior since the only string this is ever called with is "print".
- dom/DataTransfer.cpp:
(WebCore::DataTransfer::hasFileOfType): Use equalIgnoringASCIICase.
No change in behavior because local files will not have content types with
non-ASCII characters in them. In the extremely unlikely case that this is incorrect,
the change in behavior is a progression.
- dom/Document.cpp:
(WebCore::Document::setDomain): Use equalIgnoringASCIICase.
Changes behavior: Domains considered equal because of non-ASCII case folding
would get through without an error before, and now will properly throw an exception.
- dom/Element.cpp:
(WebCore::isStyleAttribute): Refactored into a helper function. Use
equalLettersIgnoringASCIICase. No change in behavior.
(WebCore::Element::synchronizeAttribute): Use isStyleAttribute.
- dom/TreeScope.cpp:
(WebCore::TreeScope::findAnchor): Use equalIgnoringASCIICase.
Changes behavior: Could go to an anchor and it would be considered a match because
of non-ASCII case folding. Covered by new test.
- html/HiddenInputType.cpp:
(WebCore::HiddenInputType::appendFormData): Use equalIgnoringASCIICase.
No change in behavior: comparing with an ASCII literal.
- html/canvas/WebGL2RenderingContext.cpp:
(WebCore::WebGL2RenderingContext::getExtension): Ditto.
- html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::getExtension): Ditto.
- html/parser/CSSPreloadScanner.cpp:
(WebCore::CSSPreloadScanner::emitRule): Use equalLettersIgnoringASCIICase and
StringView to avoid needing a special ruleEqualIgnoringCase function.
No change in behavior.
- inspector/InspectorNodeFinder.cpp:
(WebCore::InspectorNodeFinder::matchesElement): Use equalIgnoringASCIICase.
Changes behavior, but it's an inspector UI thing, not a web behavior thing,
so I don't think a new regression test is needed.
- loader/HistoryController.cpp:
(WebCore::HistoryController::currentItemShouldBeReplaced): Use
equalIgnoringASCIICase. No change in behavior because we are comparing
with "about:blank".
- loader/SubframeLoader.cpp:
(WebCore::findPluginMIMETypeFromURL): Use equalIgnoringASCIICase.
No change in behavior unless a plug-in claims an extension with non-ASCII
characters. I don't think a new regression test is needed.
- loader/appcache/ApplicationCacheHost.cpp:
(WebCore::ApplicationCacheHost::shouldLoadResourceFromApplicationCache):
Use equalIgnoringASCIICase. No change in behavior because both strings are
protocols from URLs and we don't parse non-ASCII characters into protocol strings;
non-ASCII are already encoding as punycode.
- loader/appcache/ManifestParser.cpp:
(WebCore::parseManifest): Ditto.
- page/ContentSecurityPolicy.cpp:
(WebCore::isExperimentalDirectiveName): Added. Used by isDirectiveName.
Uses equalLettersIgnoringASCIICase. No change in behavior.
(WebCore::isDirectiveName): Use equalLettersIgnoringASCIICase.
No change in behavior.
(WebCore::isSourceListNone): Use equalLettersIgnoringASCIICase. No
change in behavior.
(WebCore::CSPSource::schemeMatches): Use equalLettersIgnoringASCIICase
and equalIgnoringASCIICase. It's all about comparing URL protocols. The
old code might have done something strange if someone specified a protocol
with a non-ASCII character in it.
(WebCore::CSPSource::hostMatches): Use equalIgnoringASCIICase.
(WebCore::CSPSourceList::parseSource): Use equalLettersIgnoringASCIICase.
No change in behavior.
(WebCore::CSPDirectiveList::checkSourceAndReportViolation): Tweaked code
to do less unnecessary String allocation.
(WebCore::CSPDirectiveList::parseReflectedXSS): Use
equalLettersIgnoringASCIICase. No change in behavior.
(WebCore::CSPDirectiveList::addDirective): Ditto.
(WebCore::ContentSecurityPolicy::reportUnsupportedDirective): Use
equalLettersIgnoringASCIICase and remove unneeded global constant strings.
No change in behavior.
(WebCore::ContentSecurityPolicy::reportDirectiveAsSourceExpression):
Tweak code to eliminate unneeded local.
(WebCore::ContentSecurityPolicy::reportDuplicateDirective): Ditto.
(WebCore::ContentSecurityPolicy::reportInvalidSourceExpression): Use
equalLettersIgnoringASCIICase. No change in behavior.
- page/OriginAccessEntry.h:
(WebCore::operator==): Use equalLettersIgnoringASCIICase.
- page/Performance.cpp:
(WebCore::Performance::webkitGetEntriesByName): Use equalLettersIgnoringASCIICase.
No change in behavior.
- page/UserContentURLPattern.cpp:
(WebCore::UserContentURLPattern::matches): Use equalIgnoringASCIICase to match
schemes.
(WebCore::UserContentURLPattern::matchesHost): Use equalIgnoringASCIICase to
match host names.
- platform/URL.cpp:
(WebCore::URL::init): Use equalIgnoringASCIICase, and also use StringView to
avoid having to allocate a second string just for comparison purposes. Should be
better for efficiency with no change in behavior.
- platform/cocoa/ContentFilterUnblockHandlerCocoa.mm:
(WebCore::ContentFilterUnblockHandler::canHandleRequest): Use equalIgnoringASCIICase
to compare hosts.
- platform/efl/PlatformSpeechSynthesisProviderEfl.cpp:
(WebCore::PlatformSpeechSynthesisProviderEfl::voiceName): Use StringView and
equalIgnoringASCIICase to compare language tags. No test needed because there are
no language tags with non-ASCII characters in them.
- platform/graphics/FontCache.cpp:
(WebCore::FontPlatformDataCacheKey::operator==): Changed to use the equal
function from CaseFoldingHash. In a subsequent patch we will change this to be
ASCIICaseFoldingHash since font names don't need to compare non-ASCII characters
in a case folding manner, but for now preserve behavior.
(WebCore::alternateFamilyName): Use equalLettersIgnoringASCIICase to avoid having
to use a special familyNameEqualIgnoringCase function. This does mean there will
be a null check and a length check that wasn't there before, but the actual
comparison function will be tighter. Guessing it will be a wash. Also improved
the comments and sorted the Windows cases in with the others. No behavior change.
- platform/graphics/FontCascade.cpp:
(WebCore::operator==): Changed to use the equal function from CaseFoldingHash.
Same rationale as above in FontPlatformDataCacheKey.
- platform/graphics/FontDescription.cpp:
(WebCore::FontCascadeDescription::familiesEqualForTextAutoSizing): Use
equalIgnoringASCIICase to compare font family names. Only possible change in
behavior would be if actual fonts with non-ASCII names but that were specified
with different case in style sheets. Highly unlikely this exists.
- platform/graphics/MediaPlayer.cpp:
(WebCore::MediaPlayer::supportsType): Use equalLettersIgnoringASCIICase.
No change in behavior.
- platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp:
(WebCore::keySystemIsSupported): Ditto.
- platform/graphics/freetype/FontCacheFreeType.cpp:
(WebCore::isCommonlyUsedGenericFamily): Added.
(WebCore::FontCache::createFontPlatformData): Moved code into the
isCommonlyUsedGenericFamily helper and used equalIgnoringASCIICase.
- platform/graphics/freetype/FontCustomPlatformDataFreeType.cpp:
(WebCore::FontCustomPlatformData::supportsFormat): Use
equalLettersIgnoringASCIICase. No change in behavior.
- platform/graphics/win/FontCacheWin.cpp:
(WebCore::adjustedGDIFontWeight): Ditto.
(WebCore::FontCache::createFontPlatformData): Ditto.
- platform/graphics/win/FontCustomPlatformData.cpp:
(WebCore::FontCustomPlatformData::supportsFormat): Ditto.
- platform/graphics/win/FontCustomPlatformDataCairo.cpp:
(WebCore::FontCustomPlatformData::supportsFormat): Ditto.
- platform/mac/PlatformSpeechSynthesizerMac.mm:
(-[WebSpeechSynthesisWrapper speakUtterance:]): Use equalIgnoringASCIICase to
compare languages. No change in behavior because languages have all-ASCII names.
- platform/network/CacheValidation.cpp:
(WebCore::shouldUpdateHeaderAfterRevalidation): Use equalIgnoringASCIICase.
No change in behavior since it's a fixed list of all ASCII headers.
- platform/network/curl/ResourceHandleManager.cpp:
(WebCore::isAppendableHeader): Ditto.
- platform/network/mac/ResourceHandleMac.mm:
(WebCore::ResourceHandle::willSendRequest): Use equalIgnoringASCIICase.
No change in behavior because HTTP methods are all ASCII letters.
- platform/text/mac/LocaleMac.mm:
(WebCore::determineLocale): Use equalIgnoringASCIICase. No change in behavior
because locale languages identifiers are all ASCII.
- platform/text/win/LocaleWin.cpp:
(WebCore::LCIDFromLocaleInternal): Ditto.
- svg/SVGToOTFFontConversion.cpp:
(WebCore::SVGToOTFFontConverter::appendArabicReplacementSubtable):
Use equalIgnoringASCIICase. No change in behavior because Arabic form attribute
values are all ASCII.
- xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::uppercaseKnownHTTPMethod): Use equalIgnoringASCIICase.
No change in behavior because these are all fixed known ASCII HTTP method names.
- xml/XPathFunctions.cpp:
(WebCore::XPath::FunLang::evaluate): Use equalIgnoringASCIICase. Changes behavior
if specifying a non-ASCII character. Covered by new test.
- xml/XPathStep.cpp:
(WebCore::XPath::nodeMatchesBasicTest): Use equalIgnoringASCIICase. Changes
behavior if an element local name or XPath predicate has a non-ASCII character.
Covered by new test.
Source/WebKit/mac:
- WebCoreSupport/WebFrameLoaderClient.mm:
(parameterValue): Use equalIgnoringASCIICase. No behavior change because the
only name we ever search for with this is "pluginspage".
Source/WebKit/win:
- Plugins/PluginDatabase.cpp:
(WebCore::PluginDatabase::MIMETypeForExtension): Use equalIgnoringASCIICase to compare
file extensions.
- Plugins/PluginDatabaseWin.cpp:
(WebCore::PluginDatabase::getPluginPathsInDirectories): Use equalLettersIgnoringASCIICase
to compare filenames.
- Plugins/PluginPackageWin.cpp:
(WebCore::PluginPackage::isPluginBlacklisted): Use equalLettersIgnoringASCIICase to
compare DLL filenames.
- Plugins/PluginStream.cpp:
(WebCore::PluginStream::destroyStream): Use equalLettersIgnoringASCIICase to check HTTP method.
- Plugins/PluginView.cpp:
(WebCore::PluginView::setParameters): Use equalLettersIgnoringASCIICase to check
plug-in parameter name.
- WebView.cpp:
(WebView::canHandleRequest): Use URL::protocolIs instead of equalIgnoringCase.
Source/WebKit2:
- Shared/API/c/WKString.cpp:
(WKStringIsEqualToUTF8CStringIgnoringCase): Use equalIgnoringASCIICase.
This is a change in behavior for callers who passed non-ASCII letters to
this function and expected case insensitive comparison.
- WebProcess/Plugins/PDF/DeprecatedPDFPlugin.mm:
(WebKit::PDFPlugin::streamDidReceiveResponse): Use equalIgnoringASCIICase.
No change in behavior because this is just checking a fixed ASCII MIME type.
(WebKit::PDFPlugin::manualStreamDidReceiveResponse): Ditto.
- WebProcess/Plugins/PDF/PDFPlugin.mm:
(WebKit::PDFPlugin::streamDidReceiveResponse): Ditto.
(WebKit::PDFPlugin::manualStreamDidReceiveResponse): Ditto.
Source/WTF:
- wtf/text/AtomicString.h: Removed equalIgnoringCase.
Added some overloads for equalIgnoringASCIICase and moved the function bodies to
bottom of the file to make the function declarations easier to read and scan through.
I plan to do this for more of the functions in this class in the future.
- wtf/text/StringCommon.h: Added overloads for equalIgnoringASCIICase,
equalPossiblyIgnoringASCIICase, and a helper named equalIgnoringASCIICaseCommon.
Added an overload for equalLettersIgnoringASCIICase.
- wtf/text/StringImpl.cpp:
(WTF::equalIgnoringCase): Made the few remaining versions of this function private
to this file. Once we get done moving every client that should be using ASCII case
instead to new functions, these will almost certainly be deleted.
(WTF::equalIgnoringASCIICaseNonNull): Tweaked implementation a tiny bit.
- wtf/text/StringImpl.h: Sorted forward declarations at the top of the file.
Fixed some small formatting mistakes. Removed equalIgnoringCase, but left
equalIgnoringCaseNonNull behind for use by CaseFoldingHash until it is replaced
with ASCIICaseFoldingHash. Improved equalIgnoringASCIICase implementation.
Removed unneeded using for equalIgnoringASCIICase now that StringCommon.h takes
care of it.
- wtf/text/StringView.cpp:
(WTF::equalIgnoringASCIICase): Deleted. We no longer pass in the length for this,
so the arguments have changed and the implementation is also now in ASCIICommon.h
so it's an inline in the header file.
- wtf/text/StringView.h: Added an overload of equalIgnoringASCIICase,while
removing another.
- wtf/text/WTFString.h: Removed some unneeded forward delcarations. Fixed formatting
of the type name NSString *. Improved some comments. Removed equalIgnoringCase.
Separated declaration from implementation in a few cases to start making the
function declarations easier to read and scan through. I plan to do more in the future.
Tools:
- Scripts/do-webcore-rename: Removed rename of equalIgnoringCase since we
have removed the function instead.
- TestWebKitAPI/Tests/WTF/StringImpl.cpp:
(TestWebKitAPI::TEST): Updated test since nullptr is now ambiguous since we
added overloads for const char*.
- WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
(WTR::AccessibilityUIElement::isPressActionSupported): Use equalLettersIgnoringASCIICase.
(WTR::AccessibilityUIElement::hasPopup): Ditto.
- WebKitTestRunner/cocoa/CrashReporterInfo.mm:
(WTR::testPathFromURL): Ditto.
LayoutTests:
- fast/dom/HTMLAnchorElement/anchor-non-ASCII-case-folding-expected.txt: Added.
- fast/dom/HTMLAnchorElement/anchor-non-ASCII-case-folding.html: Added.
- fast/dom/HTMLAnchorElement/resources/iframe-with-non-ASCII-matching-anchor.html: Added.
- fast/media/media-query-non-ASCII-case-folding-expected.txt: Added.
- fast/media/media-query-non-ASCII-case-folding.html: Added.
- fast/xpath/xpath-non-ASCII-case-folding-expected.txt: Added.
- fast/xpath/xpath-non-ASCII-case-folding.html: Added.
- 9:18 AM Changeset in webkit [195742] by
-
- 2 edits in trunk/Tools
[webkitdirs] Clarify logic behind is{PortName} functions.
https://bugs.webkit.org/show_bug.cgi?id=153554
Patch by Konstantin Tokarev <Konstantin Tokarev> on 2016-01-28
Reviewed by Darin Adler.
- Scripts/webkitdirs.pm:
(determinePortName): Added new function which decides which port are
we building based on command line switches and platform defaults.
(portName): Added getter for determined $portName.
(isEfl): Modified to use portName().
(isGtk): Ditto.
(isWinCairo): Ditto.
(isAppleMacWebKit): Ditto.
(isAppleWinWebKit): Ditto.
(isIOSWebKit): Ditto.
(cmakeBasedPortName): Code replaced with portName() call.
(determineIsEfl): Deleted.
(determineIsGtk): Deleted.
(determineIsWinCairo): Deleted.
- 8:56 AM Changeset in webkit [195741] by
-
- 6 edits26 adds in branches/safari-601-branch
Merge r195710. rdar://problem/24337780
- 8:31 AM Changeset in webkit [195740] by
-
- 1833 edits2 adds in trunk
Unexpected content wrapping at http://email.osh.com/H/2/v100000152474feb8ec7c1a1f4bbe5c7c0/HTML
https://bugs.webkit.org/show_bug.cgi?id=153430
Reviewed by Simon Fraser.
Ensure that min/max preferred and computed widths never shrink while converting LayoutUnit to float and back.
Source/WebCore:
Test: fast/table/fixed-size-table-with-fixed-size-content.html
- rendering/AutoTableLayout.cpp:
(WebCore::AutoTableLayout::recalcColumn):
(WebCore::AutoTableLayout::calcEffectiveLogicalWidth):
(WebCore::AutoTableLayout::layout):
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::computePreferredLogicalWidths): Deleted.
LayoutTests:
- fast/table/fixed-size-table-with-fixed-size-content-expected.html: Added.
- fast/table/fixed-size-table-with-fixed-size-content.html: Added.
- platform/ios-simulator/css1/basic/containment-expected.txt:
- platform/ios-simulator/css1/basic/contextual_selectors-expected.txt:
- platform/ios-simulator/css1/basic/grouping-expected.txt:
- platform/ios-simulator/css1/basic/id_as_selector-expected.txt:
- platform/ios-simulator/css1/basic/inheritance-expected.txt:
- platform/ios-simulator/css1/box_properties/border-expected.txt:
- platform/ios-simulator/css1/box_properties/border_bottom-expected.txt:
- platform/ios-simulator/css1/box_properties/border_bottom_inline-expected.txt:
- platform/ios-simulator/css1/box_properties/border_bottom_width-expected.txt:
- platform/ios-simulator/css1/box_properties/border_bottom_width_inline-expected.txt:
- platform/ios-simulator/css1/box_properties/border_color-expected.txt:
- platform/ios-simulator/css1/box_properties/border_color_inline-expected.txt:
- platform/ios-simulator/css1/box_properties/border_inline-expected.txt:
- platform/ios-simulator/css1/box_properties/border_left-expected.txt:
- platform/ios-simulator/css1/box_properties/border_left_inline-expected.txt:
- platform/ios-simulator/css1/box_properties/border_left_width-expected.txt:
- platform/ios-simulator/css1/box_properties/border_left_width_inline-expected.txt:
- platform/ios-simulator/css1/box_properties/border_right-expected.txt:
- platform/ios-simulator/css1/box_properties/border_right_inline-expected.txt:
- platform/ios-simulator/css1/box_properties/border_right_width-expected.txt:
- platform/ios-simulator/css1/box_properties/border_right_width_inline-expected.txt:
- platform/ios-simulator/css1/box_properties/border_style-expected.txt:
- platform/ios-simulator/css1/box_properties/border_style_inline-expected.txt:
- platform/ios-simulator/css1/box_properties/border_top-expected.txt:
- platform/ios-simulator/css1/box_properties/border_top_inline-expected.txt:
- platform/ios-simulator/css1/box_properties/border_top_width-expected.txt:
- platform/ios-simulator/css1/box_properties/border_top_width_inline-expected.txt:
- platform/ios-simulator/css1/box_properties/border_width-expected.txt:
- platform/ios-simulator/css1/box_properties/border_width_inline-expected.txt:
- platform/ios-simulator/css1/box_properties/clear-expected.txt:
- platform/ios-simulator/css1/box_properties/clear_float-expected.txt:
- platform/ios-simulator/css1/box_properties/float-expected.txt:
- platform/ios-simulator/css1/box_properties/float_elements_in_series-expected.txt:
- platform/ios-simulator/css1/box_properties/float_margin-expected.txt:
- platform/ios-simulator/css1/box_properties/height-expected.txt:
- platform/ios-simulator/css1/box_properties/margin-expected.txt:
- platform/ios-simulator/css1/box_properties/margin_bottom-expected.txt:
- platform/ios-simulator/css1/box_properties/margin_bottom_inline-expected.txt:
- platform/ios-simulator/css1/box_properties/margin_inline-expected.txt:
- platform/ios-simulator/css1/box_properties/margin_left-expected.txt:
- platform/ios-simulator/css1/box_properties/margin_left_inline-expected.txt:
- platform/ios-simulator/css1/box_properties/margin_right-expected.txt:
- platform/ios-simulator/css1/box_properties/margin_right_inline-expected.txt:
- platform/ios-simulator/css1/box_properties/margin_top-expected.txt:
- platform/ios-simulator/css1/box_properties/margin_top_inline-expected.txt:
- platform/ios-simulator/css1/box_properties/padding-expected.txt:
- platform/ios-simulator/css1/box_properties/padding_bottom-expected.txt:
- platform/ios-simulator/css1/box_properties/padding_bottom_inline-expected.txt:
- platform/ios-simulator/css1/box_properties/padding_inline-expected.txt:
- platform/ios-simulator/css1/box_properties/padding_left-expected.txt:
- platform/ios-simulator/css1/box_properties/padding_left_inline-expected.txt:
- platform/ios-simulator/css1/box_properties/padding_right-expected.txt:
- platform/ios-simulator/css1/box_properties/padding_right_inline-expected.txt:
- platform/ios-simulator/css1/box_properties/padding_top-expected.txt:
- platform/ios-simulator/css1/box_properties/padding_top_inline-expected.txt:
- platform/ios-simulator/css1/box_properties/width-expected.txt:
- platform/ios-simulator/css1/cascade/cascade_order-expected.txt:
- platform/ios-simulator/css1/cascade/important-expected.txt:
- platform/ios-simulator/css1/classification/display-expected.txt:
- platform/ios-simulator/css1/classification/list_style-expected.txt:
- platform/ios-simulator/css1/classification/list_style_image-expected.txt:
- platform/ios-simulator/css1/classification/list_style_position-expected.txt:
- platform/ios-simulator/css1/classification/list_style_type-expected.txt:
- platform/ios-simulator/css1/classification/white_space-expected.txt:
- platform/ios-simulator/css1/color_and_background/background-expected.txt:
- platform/ios-simulator/css1/color_and_background/background_attachment-expected.txt:
- platform/ios-simulator/css1/color_and_background/background_color-expected.txt:
- platform/ios-simulator/css1/color_and_background/background_image-expected.txt:
- platform/ios-simulator/css1/color_and_background/background_position-expected.txt:
- platform/ios-simulator/css1/color_and_background/background_repeat-expected.txt:
- platform/ios-simulator/css1/color_and_background/color-expected.txt:
- platform/ios-simulator/css1/conformance/forward_compatible_parsing-expected.txt:
- platform/ios-simulator/css1/font_properties/font-expected.txt:
- platform/ios-simulator/css1/font_properties/font_family-expected.txt:
- platform/ios-simulator/css1/font_properties/font_size-expected.txt:
- platform/ios-simulator/css1/font_properties/font_style-expected.txt:
- platform/ios-simulator/css1/font_properties/font_variant-expected.txt:
- platform/ios-simulator/css1/font_properties/font_weight-expected.txt:
- platform/ios-simulator/css1/formatting_model/canvas-expected.txt:
- platform/ios-simulator/css1/formatting_model/height_of_lines-expected.txt:
- platform/ios-simulator/css1/formatting_model/inline_elements-expected.txt:
- platform/ios-simulator/css1/formatting_model/replaced_elements-expected.txt:
- platform/ios-simulator/css1/formatting_model/vertical_formatting-expected.txt:
- platform/ios-simulator/css1/pseudo/anchor-expected.txt:
- platform/ios-simulator/css1/pseudo/firstletter-expected.txt:
- platform/ios-simulator/css1/pseudo/firstline-expected.txt:
- platform/ios-simulator/css1/pseudo/multiple_pseudo_elements-expected.txt:
- platform/ios-simulator/css1/pseudo/pseudo_elements_in_selectors-expected.txt:
- platform/ios-simulator/css1/text_properties/letter_spacing-expected.txt:
- platform/ios-simulator/css1/text_properties/line_height-expected.txt:
- platform/ios-simulator/css1/text_properties/text_align-expected.txt:
- platform/ios-simulator/css1/text_properties/text_decoration-expected.txt:
- platform/ios-simulator/css1/text_properties/text_indent-expected.txt:
- platform/ios-simulator/css1/text_properties/text_transform-expected.txt:
- platform/ios-simulator/css1/text_properties/vertical_align-expected.txt:
- platform/ios-simulator/css1/text_properties/word_spacing-expected.txt:
- platform/ios-simulator/css1/units/color_units-expected.txt:
- platform/ios-simulator/css1/units/length_units-expected.txt:
- platform/ios-simulator/css1/units/percentage_units-expected.txt:
- platform/ios-simulator/css1/units/urls-expected.txt:
- platform/ios-simulator/css2.1/20110323/border-collapse-offset-002-expected.txt:
- platform/ios-simulator/css2.1/20110323/border-conflict-style-079-expected.txt:
- platform/ios-simulator/css2.1/20110323/border-conflict-style-088-expected.txt:
- platform/ios-simulator/css2.1/20110323/dynamic-top-change-002-expected.txt:
- platform/ios-simulator/css2.1/20110323/dynamic-top-change-003-expected.txt:
- platform/ios-simulator/css2.1/20110323/inline-table-001-expected.txt:
- platform/ios-simulator/css2.1/20110323/inline-table-003-expected.txt:
- platform/ios-simulator/css2.1/20110323/margin-applies-to-001-expected.txt:
- platform/ios-simulator/css2.1/20110323/margin-applies-to-002-expected.txt:
- platform/ios-simulator/css2.1/20110323/margin-applies-to-003-expected.txt:
- platform/ios-simulator/css2.1/20110323/margin-applies-to-004-expected.txt:
- platform/ios-simulator/css2.1/20110323/margin-applies-to-005-expected.txt:
- platform/ios-simulator/css2.1/20110323/margin-applies-to-006-expected.txt:
- platform/ios-simulator/css2.1/20110323/margin-applies-to-007-expected.txt:
- platform/ios-simulator/css2.1/20110323/margin-applies-to-013-expected.txt:
- platform/ios-simulator/css2.1/20110323/margin-applies-to-014-expected.txt:
- platform/ios-simulator/css2.1/20110323/margin-applies-to-015-expected.txt:
- platform/ios-simulator/css2.1/20110323/replaced-intrinsic-ratio-001-expected.txt:
- platform/ios-simulator/css2.1/20110323/table-caption-001-expected.txt:
- platform/ios-simulator/css2.1/20110323/table-caption-optional-001-expected.txt:
- platform/ios-simulator/css2.1/20110323/table-caption-optional-002-expected.txt:
- platform/ios-simulator/css2.1/t040302-c61-ex-len-00-b-a-expected.txt:
- platform/ios-simulator/css2.1/t0803-c5501-mrgn-t-00-b-a-expected.txt:
- platform/ios-simulator/css2.1/t0803-c5503-mrgn-b-00-b-a-expected.txt:
- platform/ios-simulator/css2.1/t080301-c411-vt-mrgn-00-b-expected.txt:
- platform/ios-simulator/css2.1/t0804-c5506-padn-t-00-b-a-expected.txt:
- platform/ios-simulator/css2.1/t0804-c5508-ipadn-b-03-b-a-expected.txt:
- platform/ios-simulator/css2.1/t090402-c42-ibx-pad-00-d-ag-expected.txt:
- platform/ios-simulator/css2.1/t0905-c5525-fltmult-00-d-g-expected.txt:
- platform/ios-simulator/css2.1/t170602-bdr-conflct-w-04-d-expected.txt:
- platform/ios-simulator/css2.1/t170602-bdr-conflct-w-06-d-expected.txt:
- platform/ios-simulator/css2.1/t170602-bdr-conflct-w-08-d-expected.txt:
- platform/ios-simulator/css2.1/t170602-bdr-conflct-w-13-d-expected.txt:
- platform/ios-simulator/css2.1/t170602-bdr-conflct-w-14-d-expected.txt:
- platform/ios-simulator/css2.1/t170602-bdr-conflct-w-16-d-expected.txt:
- platform/ios-simulator/css2.1/t170602-bdr-conflct-w-17-d-expected.txt:
- platform/ios-simulator/css2.1/t170602-bdr-conflct-w-18-d-expected.txt:
- platform/ios-simulator/css2.1/t170602-bdr-conflct-w-24-d-expected.txt:
- platform/ios-simulator/css2.1/t170602-bdr-conflct-w-25-d-expected.txt:
- platform/ios-simulator/css2.1/t170602-bdr-conflct-w-30-d-expected.txt:
- platform/ios-simulator/css2.1/t170602-bdr-conflct-w-31-d-expected.txt:
- platform/ios-simulator/css2.1/t170602-bdr-conflct-w-34-d-expected.txt:
- platform/ios-simulator/css2.1/t170602-bdr-conflct-w-44-d-expected.txt:
- platform/ios-simulator/css2.1/t170602-bdr-conflct-w-52-d-expected.txt:
- platform/ios-simulator/css2.1/t170602-bdr-conflct-w-54-d-expected.txt:
- platform/ios-simulator/css2.1/t170602-bdr-conflct-w-59-d-expected.txt:
- platform/ios-simulator/css2.1/t170602-bdr-conflct-w-64-d-expected.txt:
- platform/ios-simulator/css2.1/t170602-bdr-conflct-w-65-d-expected.txt:
- platform/ios-simulator/css2.1/t170602-bdr-conflct-w-70-d-expected.txt:
- platform/ios-simulator/css2.1/t170602-bdr-conflct-w-71-d-expected.txt:
- platform/ios-simulator/css2.1/t170602-bdr-conflct-w-74-d-expected.txt:
- platform/ios-simulator/css2.1/t170602-bdr-conflct-w-84-d-expected.txt:
- platform/ios-simulator/css2.1/t170602-bdr-conflct-w-85-d-expected.txt:
- platform/ios-simulator/css2.1/t170602-bdr-conflct-w-94-d-expected.txt:
- platform/ios-simulator/css2.1/tables/table-anonymous-objects-177-expected.txt:
- platform/ios-simulator/css2.1/tables/table-anonymous-objects-178-expected.txt:
- platform/ios-simulator/css2.1/tables/table-anonymous-objects-179-expected.txt:
- platform/ios-simulator/css2.1/tables/table-anonymous-objects-180-expected.txt:
- platform/ios-simulator/css2.1/tables/table-anonymous-objects-181-expected.txt:
- platform/ios-simulator/css2.1/tables/table-anonymous-objects-189-expected.txt:
- platform/ios-simulator/css2.1/tables/table-anonymous-objects-190-expected.txt:
- platform/ios-simulator/css2.1/tables/table-anonymous-objects-191-expected.txt:
- platform/ios-simulator/css2.1/tables/table-anonymous-objects-192-expected.txt:
- platform/ios-simulator/css2.1/tables/table-anonymous-objects-193-expected.txt:
- platform/ios-simulator/css2.1/tables/table-anonymous-objects-194-expected.txt:
- platform/ios-simulator/css2.1/tables/table-anonymous-objects-195-expected.txt:
- platform/ios-simulator/css2.1/tables/table-anonymous-objects-196-expected.txt:
- platform/ios-simulator/css2.1/tables/table-anonymous-objects-205-expected.txt:
- platform/ios-simulator/css2.1/tables/table-anonymous-objects-206-expected.txt:
- platform/ios-simulator/css3/css3-modsel-33-expected.txt:
- platform/ios-simulator/css3/selectors3/html/css3-modsel-18-expected.txt:
- platform/ios-simulator/css3/selectors3/html/css3-modsel-29-expected.txt:
- platform/ios-simulator/css3/selectors3/html/css3-modsel-29b-expected.txt:
- platform/ios-simulator/css3/selectors3/html/css3-modsel-33-expected.txt:
- platform/ios-simulator/css3/selectors3/html/css3-modsel-73-expected.txt:
- platform/ios-simulator/css3/selectors3/html/css3-modsel-73b-expected.txt:
- platform/ios-simulator/css3/selectors3/html/css3-modsel-77-expected.txt:
- platform/ios-simulator/css3/selectors3/html/css3-modsel-77b-expected.txt:
- platform/ios-simulator/css3/selectors3/xhtml/css3-modsel-18-expected.txt:
- platform/ios-simulator/css3/selectors3/xhtml/css3-modsel-29-expected.txt:
- platform/ios-simulator/css3/selectors3/xhtml/css3-modsel-29b-expected.txt:
- platform/ios-simulator/css3/selectors3/xhtml/css3-modsel-33-expected.txt:
- platform/ios-simulator/css3/selectors3/xhtml/css3-modsel-73-expected.txt:
- platform/ios-simulator/css3/selectors3/xhtml/css3-modsel-73b-expected.txt:
- platform/ios-simulator/css3/selectors3/xhtml/css3-modsel-77-expected.txt:
- platform/ios-simulator/css3/selectors3/xhtml/css3-modsel-77b-expected.txt:
- platform/ios-simulator/css3/selectors3/xml/css3-modsel-18-expected.txt:
- platform/ios-simulator/css3/selectors3/xml/css3-modsel-29-expected.txt:
- platform/ios-simulator/css3/selectors3/xml/css3-modsel-29b-expected.txt:
- platform/ios-simulator/css3/selectors3/xml/css3-modsel-33-expected.txt:
- platform/ios-simulator/css3/selectors3/xml/css3-modsel-73-expected.txt:
- platform/ios-simulator/css3/selectors3/xml/css3-modsel-73b-expected.txt:
- platform/ios-simulator/css3/selectors3/xml/css3-modsel-77-expected.txt:
- platform/ios-simulator/css3/selectors3/xml/css3-modsel-77b-expected.txt:
- platform/ios-simulator/editing/deleting/4922367-expected.txt:
- platform/ios-simulator/editing/deleting/5126166-expected.txt:
- platform/ios-simulator/editing/deleting/5206311-1-expected.txt:
- platform/ios-simulator/editing/deleting/5433862-2-expected.txt:
- platform/ios-simulator/editing/inserting/paragraph-separator-in-table-1-expected.txt:
- platform/ios-simulator/editing/selection/5057506-2-expected.txt:
- platform/ios-simulator/editing/selection/5057506-expected.txt:
- platform/ios-simulator/editing/selection/5131716-1-expected.txt:
- platform/ios-simulator/editing/selection/5131716-2-expected.txt:
- platform/ios-simulator/editing/selection/5131716-3-expected.txt:
- platform/ios-simulator/editing/selection/5131716-4-expected.txt:
- platform/ios-simulator/fast/block/basic/quirk-percent-height-table-cell-expected.txt:
- platform/ios-simulator/fast/block/float/015-expected.txt:
- platform/ios-simulator/fast/block/margin-collapse/006-expected.txt:
- platform/ios-simulator/fast/block/margin-collapse/010-expected.txt:
- platform/ios-simulator/fast/block/margin-collapse/011-expected.txt:
- platform/ios-simulator/fast/block/margin-collapse/012-expected.txt:
- platform/ios-simulator/fast/block/margin-collapse/015-expected.txt:
- platform/ios-simulator/fast/block/margin-collapse/016-expected.txt:
- platform/ios-simulator/fast/block/margin-collapse/017-expected.txt:
- platform/ios-simulator/fast/block/margin-collapse/018-expected.txt:
- platform/ios-simulator/fast/block/margin-collapse/019-expected.txt:
- platform/ios-simulator/fast/block/margin-collapse/020-expected.txt:
- platform/ios-simulator/fast/block/margin-collapse/021-expected.txt:
- platform/ios-simulator/fast/block/margin-collapse/022-expected.txt:
- platform/ios-simulator/fast/block/margin-collapse/025-expected.txt:
- platform/ios-simulator/fast/block/margin-collapse/032-expected.txt:
- platform/ios-simulator/fast/block/margin-collapse/033-expected.txt:
- platform/ios-simulator/fast/block/margin-collapse/034-expected.txt:
- platform/ios-simulator/fast/block/margin-collapse/041-expected.txt:
- platform/ios-simulator/fast/block/margin-collapse/042-expected.txt:
- platform/ios-simulator/fast/block/margin-collapse/055-expected.txt:
- platform/ios-simulator/fast/block/margin-collapse/056-expected.txt:
- platform/ios-simulator/fast/block/margin-collapse/057-expected.txt:
- platform/ios-simulator/fast/block/margin-collapse/058-expected.txt:
- platform/ios-simulator/fast/block/margin-collapse/059-expected.txt:
- platform/ios-simulator/fast/block/margin-collapse/block-inside-inline/006-expected.txt:
- platform/ios-simulator/fast/block/margin-collapse/block-inside-inline/010-expected.txt:
- platform/ios-simulator/fast/block/margin-collapse/block-inside-inline/011-expected.txt:
- platform/ios-simulator/fast/block/margin-collapse/block-inside-inline/012-expected.txt:
- platform/ios-simulator/fast/block/margin-collapse/block-inside-inline/015-expected.txt:
- platform/ios-simulator/fast/block/margin-collapse/block-inside-inline/016-expected.txt:
- platform/ios-simulator/fast/block/margin-collapse/block-inside-inline/017-expected.txt:
- platform/ios-simulator/fast/block/margin-collapse/block-inside-inline/018-expected.txt:
- platform/ios-simulator/fast/block/margin-collapse/block-inside-inline/019-expected.txt:
- platform/ios-simulator/fast/block/margin-collapse/block-inside-inline/020-expected.txt:
- platform/ios-simulator/fast/block/margin-collapse/block-inside-inline/021-expected.txt:
- platform/ios-simulator/fast/block/margin-collapse/block-inside-inline/022-expected.txt:
- platform/ios-simulator/fast/block/margin-collapse/block-inside-inline/025-expected.txt:
- platform/ios-simulator/fast/block/positioning/negative-right-pos-expected.txt:
- platform/ios-simulator/fast/block/positioning/table-cell-static-position-expected.txt:
- platform/ios-simulator/fast/borders/border-antialiasing-expected.txt:
- platform/ios-simulator/fast/borders/border-radius-different-width-001-expected.txt:
- platform/ios-simulator/fast/borders/table-borders-expected.txt:
- platform/ios-simulator/fast/css-generated-content/first-letter-in-nested-before-expected.txt:
- platform/ios-simulator/fast/css-generated-content/first-letter-in-nested-before-table-expected.txt:
- platform/ios-simulator/fast/css-generated-content/nested-tables-with-before-after-content-crash-expected.txt:
- platform/ios-simulator/fast/css-generated-content/table-cell-before-after-child-add-expected.txt:
- platform/ios-simulator/fast/css-generated-content/table-row-group-with-before-expected.txt:
- platform/ios-simulator/fast/css-generated-content/table-row-with-before-expected.txt:
- platform/ios-simulator/fast/css-generated-content/table-with-before-expected.txt:
- platform/ios-simulator/fast/css/003-expected.txt:
- platform/ios-simulator/fast/css/absolute-poition-in-rtl-parent-expected.txt:
- platform/ios-simulator/fast/css/acid2-expected.txt:
- platform/ios-simulator/fast/css/acid2-pixel-expected.txt:
- platform/ios-simulator/fast/css/bidi-override-in-anonymous-block-expected.txt:
- platform/ios-simulator/fast/css/box-shadow-and-border-radius-expected.txt:
- platform/ios-simulator/fast/css/css3-nth-child-expected.txt:
- platform/ios-simulator/fast/css/focus-ring-detached-expected.txt:
- platform/ios-simulator/fast/css/focus-ring-multiline-expected.txt:
- platform/ios-simulator/fast/css/h1-in-section-elements-expected.txt:
- platform/ios-simulator/fast/css/percentage-non-integer-expected.txt:
- platform/ios-simulator/fast/css/table-text-align-quirk-expected.txt:
- platform/ios-simulator/fast/css/table-text-align-strict-expected.txt:
- platform/ios-simulator/fast/dom/34176-expected.txt:
- platform/ios-simulator/fast/dom/HTMLTableElement/colSpan-expected.txt:
- platform/ios-simulator/fast/dom/HTMLTableElement/createCaption-expected.txt:
- platform/ios-simulator/fast/dom/row-inner-text-expected.txt:
- platform/ios-simulator/fast/dynamic/001-expected.txt:
- platform/ios-simulator/fast/dynamic/containing-block-change-expected.txt:
- platform/ios-simulator/fast/dynamic/float-withdrawal-expected.txt:
- platform/ios-simulator/fast/dynamic/insert-before-table-part-in-continuation-expected.txt:
- platform/ios-simulator/fast/dynamic/subtree-table-cell-height-expected.txt:
- platform/ios-simulator/fast/forms/001-expected.txt:
- platform/ios-simulator/fast/forms/005-expected.txt:
- platform/ios-simulator/fast/forms/form-element-geometry-expected.txt:
- platform/ios-simulator/fast/forms/form-hides-table-expected.txt:
- platform/ios-simulator/fast/forms/formmove3-expected.txt:
- platform/ios-simulator/fast/forms/input-table-expected.txt:
- platform/ios-simulator/fast/forms/listbox-bidi-align-expected.txt:
- platform/ios-simulator/fast/forms/preserveFormDuringResidualStyle-expected.txt:
- platform/ios-simulator/fast/forms/select-dirty-parent-pref-widths-expected.txt:
- platform/ios-simulator/fast/html/details-writing-mode-expected.txt:
- platform/ios-simulator/fast/inline-block/001-expected.txt:
- platform/ios-simulator/fast/inline-block/overflow-clip-expected.txt:
- platform/ios-simulator/fast/invalid/012-expected.txt:
- platform/ios-simulator/fast/lists/004-expected.txt:
- platform/ios-simulator/fast/multicol/span/before-child-anonymous-column-block-expected.txt:
- platform/ios-simulator/fast/multicol/table-vertical-align-expected.txt:
- platform/ios-simulator/fast/overflow/002-expected.txt:
- platform/ios-simulator/fast/overflow/overflow-rtl-expected.txt:
- platform/ios-simulator/fast/overflow/overflow-rtl-vertical-expected.txt:
- platform/ios-simulator/fast/overflow/table-overflow-float-expected.txt:
- platform/ios-simulator/fast/reflections/table-cell-expected.txt:
- platform/ios-simulator/fast/replaced/005-expected.txt:
- platform/ios-simulator/fast/replaced/percent-height-in-anonymous-block-in-table-expected.txt:
- platform/ios-simulator/fast/replaced/selection-rect-in-table-cell-expected.txt:
- platform/ios-simulator/fast/replaced/table-percent-height-positioned-expected.txt:
- platform/ios-simulator/fast/replaced/width100percent-checkbox-expected.txt:
- platform/ios-simulator/fast/replaced/width100percent-image-expected.txt:
- platform/ios-simulator/fast/replaced/width100percent-menulist-expected.txt:
- platform/ios-simulator/fast/replaced/width100percent-radio-expected.txt:
- platform/ios-simulator/fast/replaced/width100percent-searchfield-expected.txt:
- platform/ios-simulator/fast/replaced/width100percent-textarea-expected.txt:
- platform/ios-simulator/fast/replaced/width100percent-textfield-expected.txt:
- platform/ios-simulator/fast/selectors/077-expected.txt:
- platform/ios-simulator/fast/selectors/077b-expected.txt:
- platform/ios-simulator/fast/table/002-expected.txt:
- platform/ios-simulator/fast/table/003-expected.txt:
- platform/ios-simulator/fast/table/005-expected.txt:
- platform/ios-simulator/fast/table/007-expected.txt:
- platform/ios-simulator/fast/table/008-expected.txt:
- platform/ios-simulator/fast/table/009-expected.txt:
- platform/ios-simulator/fast/table/012-expected.txt:
- platform/ios-simulator/fast/table/013-expected.txt:
- platform/ios-simulator/fast/table/021-expected.txt:
- platform/ios-simulator/fast/table/023-expected.txt:
- platform/ios-simulator/fast/table/028-expected.txt:
- platform/ios-simulator/fast/table/028-vertical-expected.txt:
- platform/ios-simulator/fast/table/029-expected.txt:
- platform/ios-simulator/fast/table/038-expected.txt:
- platform/ios-simulator/fast/table/038-vertical-expected.txt:
- platform/ios-simulator/fast/table/039-expected.txt:
- platform/ios-simulator/fast/table/040-expected.txt:
- platform/ios-simulator/fast/table/040-vertical-expected.txt:
- platform/ios-simulator/fast/table/100-percent-cell-width-expected.txt:
- platform/ios-simulator/fast/table/add-before-anonymous-child-expected.txt:
- platform/ios-simulator/fast/table/border-collapsing/001-expected.txt:
- platform/ios-simulator/fast/table/border-collapsing/001-vertical-expected.txt:
- platform/ios-simulator/fast/table/border-collapsing/002-expected.txt:
- platform/ios-simulator/fast/table/border-collapsing/002-vertical-expected.txt:
- platform/ios-simulator/fast/table/border-collapsing/003-expected.txt:
- platform/ios-simulator/fast/table/border-collapsing/003-vertical-expected.txt:
- platform/ios-simulator/fast/table/border-collapsing/border-collapsing-head-foot-expected.txt:
- platform/ios-simulator/fast/table/border-collapsing/border-collapsing-head-foot-vertical-expected.txt:
- platform/ios-simulator/fast/table/border-collapsing/cached-69296-expected.txt:
- platform/ios-simulator/fast/table/border-collapsing/cached-change-row-border-width-expected.txt:
- platform/ios-simulator/fast/table/border-collapsing/cached-change-tbody-border-width-expected.txt:
- platform/ios-simulator/fast/table/border-collapsing/equal-precedence-resolution-expected.txt:
- platform/ios-simulator/fast/table/border-collapsing/rtl-border-collapsing-expected.txt:
- platform/ios-simulator/fast/table/border-collapsing/rtl-border-collapsing-vertical-expected.txt:
- platform/ios-simulator/fast/table/caption-relayout-expected.txt:
- platform/ios-simulator/fast/table/cell-absolute-child-expected.txt:
- platform/ios-simulator/fast/table/cell-width-auto-expected.txt:
- platform/ios-simulator/fast/table/colspanMinWidth-expected.txt:
- platform/ios-simulator/fast/table/dynamic-cellpadding-expected.txt:
- platform/ios-simulator/fast/table/edge-offsets-expected.txt:
- platform/ios-simulator/fast/table/empty-cells-expected.txt:
- platform/ios-simulator/fast/table/frame-and-rules-expected.txt:
- platform/ios-simulator/fast/table/giantRowspan-expected.txt:
- platform/ios-simulator/fast/table/growCellForImageQuirk-expected.txt:
- platform/ios-simulator/fast/table/growCellForImageQuirk-vertical-expected.txt:
- platform/ios-simulator/fast/table/invisible-cell-background-expected.txt:
- platform/ios-simulator/fast/table/large-width-expected.txt:
- platform/ios-simulator/fast/table/max-width-integer-overflow-expected.txt:
- platform/ios-simulator/fast/table/mozilla-bug10296-vertical-align-1-expected.txt:
- platform/ios-simulator/fast/table/mozilla-bug10296-vertical-align-2-expected.txt:
- platform/ios-simulator/fast/table/nobr-expected.txt:
- platform/ios-simulator/fast/table/overflowHidden-expected.txt:
- platform/ios-simulator/fast/table/percent-heights-expected.txt:
- platform/ios-simulator/fast/table/percent-widths-stretch-expected.txt:
- platform/ios-simulator/fast/table/prepend-in-anonymous-table-expected.txt:
- platform/ios-simulator/fast/table/relative-position-containment-expected.txt:
- platform/ios-simulator/fast/table/relative-position-offsets-expected.txt:
- platform/ios-simulator/fast/table/relative-position-stacking-expected.txt:
- platform/ios-simulator/fast/table/replaced-percent-height-expected.txt:
- platform/ios-simulator/fast/table/row-height-recalc-expected.txt:
- platform/ios-simulator/fast/table/rowspan-paint-order-expected.txt:
- platform/ios-simulator/fast/table/rowspan-paint-order-vertical-expected.txt:
- platform/ios-simulator/fast/table/spanOverlapRepaint-expected.txt:
- platform/ios-simulator/fast/table/stale-grid-crash-expected.txt:
- platform/ios-simulator/fast/table/table-cell-before-child-in-table-expected.txt:
- platform/ios-simulator/fast/table/table-display-types-expected.txt:
- platform/ios-simulator/fast/table/table-display-types-strict-expected.txt:
- platform/ios-simulator/fast/table/table-display-types-vertical-expected.txt:
- platform/ios-simulator/fast/table/table-row-before-after-content-around-table-cell-expected.txt:
- platform/ios-simulator/fast/table/table-row-outline-paint-expected.txt:
- platform/ios-simulator/fast/table/table-row-split2-expected.txt:
- platform/ios-simulator/fast/table/table-section-split2-expected.txt:
- platform/ios-simulator/fast/table/table-split-expected.txt:
- platform/ios-simulator/fast/table/table-split2-expected.txt:
- platform/ios-simulator/fast/text/basic/004-expected.txt:
- platform/ios-simulator/fast/text/basic/005-expected.txt:
- platform/ios-simulator/fast/text/emoji-expected.txt:
- platform/ios-simulator/fast/text/international/bidi-LDB-2-CSS-expected.txt:
- platform/ios-simulator/fast/text/international/bidi-LDB-2-HTML-expected.txt:
- platform/ios-simulator/fast/text/international/bidi-LDB-2-formatting-characters-expected.txt:
- platform/ios-simulator/fast/text/whitespace/002-expected.txt:
- platform/ios-simulator/fast/text/whitespace/003-expected.txt:
- platform/ios-simulator/fast/text/whitespace/004-expected.txt:
- platform/ios-simulator/fast/text/whitespace/005-expected.txt:
- platform/ios-simulator/fast/text/whitespace/010-expected.txt:
- platform/ios-simulator/fast/text/whitespace/011-expected.txt:
- platform/ios-simulator/fast/text/whitespace/015-expected.txt:
- platform/ios-simulator/fast/text/whitespace/016-expected.txt:
- platform/ios-simulator/fast/text/whitespace/025-expected.txt:
- platform/ios-simulator/fast/writing-mode/table-percent-width-quirk-expected.txt:
- platform/ios-simulator/fast/writing-mode/vertical-align-table-baseline-expected.txt:
- platform/ios-simulator/http/tests/misc/acid2-expected.txt:
- platform/ios-simulator/http/tests/misc/acid2-pixel-expected.txt:
- platform/ios-simulator/http/tests/misc/object-embedding-svg-delayed-size-negotiation-2-expected.txt:
- platform/ios-simulator/ietestcenter/css3/bordersbackgrounds/background_properties_greater_than_images-expected.txt:
- platform/ios-simulator/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-006-expected.txt:
- platform/ios-simulator/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-007-expected.txt:
- platform/ios-simulator/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-008-expected.txt:
- platform/ios-simulator/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-009-expected.txt:
- platform/ios-simulator/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-011-expected.txt:
- platform/ios-simulator/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-012-expected.txt:
- platform/ios-simulator/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-013-expected.txt:
- platform/ios-simulator/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-014-expected.txt:
- platform/ios-simulator/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-015-expected.txt:
- platform/ios-simulator/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-016-expected.txt:
- platform/ios-simulator/ietestcenter/css3/bordersbackgrounds/border-radius-different-width-001-expected.txt:
- platform/ios-simulator/ietestcenter/css3/bordersbackgrounds/border-radius-shorthand-001-expected.txt:
- platform/ios-simulator/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-001-expected.txt:
- platform/ios-simulator/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-002-expected.txt:
- platform/ios-simulator/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-004-expected.txt:
- platform/ios-simulator/ietestcenter/css3/bordersbackgrounds/border-top-right-radius-values-004-expected.txt:
- platform/ios-simulator/ietestcenter/css3/bordersbackgrounds/none-as-image-layer-expected.txt:
- platform/ios-simulator/mathml/opentype/opentype-stretchy-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug10009-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug101201-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug101674-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug10296-1-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug1055-1-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug10565-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug10633-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug1067-1-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug1067-2-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug106795-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug106816-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug113235-1-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug113424-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug1163-1-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug1188-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug12008-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug120107-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug120364-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug1224-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug12268-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug12709-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug1271-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug12908-1-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug12908-2-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug12910-2-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug1296-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug1302-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug13169-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug1318-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug139524-1-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug139524-2-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug139524-3-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug139524-4-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug1430-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug14323-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug1474-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug14929-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug15247-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug154780-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug15544-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug159108-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug15933-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug16012-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug16252-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug17138-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug175455-4-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug17548-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug17587-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug1800-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug1802-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug1802s-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug1809-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug18440-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug18664-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug18955-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug19061-1-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug19061-2-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug19356-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug20804-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug2123-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug215629-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug219693-1-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug219693-2-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug22019-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug222336-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug22246-2-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug22246-2a-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug22246-3-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug22246-3a-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug22513-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug2296-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug23235-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug24200-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug2479-3-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug25004-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug25074-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug25663-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug2684-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug269566-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug277062-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug2773-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug27993-1-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug2886-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug28933-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug29058-1-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug29429-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug2954-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug2981-1-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug2981-2-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug2997-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug30273-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug3103-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug32205-3-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug3260-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug32841-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug33137-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug33855-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug3454-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug3977-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug4093-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug42187-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug4385-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug44505-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug4501-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug4527-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug45350-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug45486-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug4576-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug46268-1-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug46268-2-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug46368-1-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug46623-1-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug46623-2-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug47432-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug4803-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug4849-2-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug4849-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug51727-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug5188-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug52505-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug52506-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug53690-1-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug53690-2-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug53891-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug5538-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug55789-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug57828-2-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug5797-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug5835-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug59354-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug60804-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug60807-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug6184-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug6304-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug6404-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug647-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug6674-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug68998-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug69382-1-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug69382-2-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug72359-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug7342-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug7714-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug78162-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug82946-2-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug86708-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug8950-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug9123-1-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug9123-2-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug92143-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug963-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug96334-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug97383-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug9879-1-expected.txt:
- platform/ios-simulator/tables/mozilla/collapsing_borders/bug41262-3-expected.txt:
- platform/ios-simulator/tables/mozilla/core/bloomberg-expected.txt:
- platform/ios-simulator/tables/mozilla/core/borders-expected.txt:
- platform/ios-simulator/tables/mozilla/core/cell_heights-expected.txt:
- platform/ios-simulator/tables/mozilla/core/col_span-expected.txt:
- platform/ios-simulator/tables/mozilla/core/col_widths_auto_autoFix-expected.txt:
- platform/ios-simulator/tables/mozilla/core/col_widths_auto_autoFixPer-expected.txt:
- platform/ios-simulator/tables/mozilla/core/col_widths_auto_fix-expected.txt:
- platform/ios-simulator/tables/mozilla/core/col_widths_auto_fixPer-expected.txt:
- platform/ios-simulator/tables/mozilla/core/col_widths_auto_per-expected.txt:
- platform/ios-simulator/tables/mozilla/core/col_widths_fix_autoFix-expected.txt:
- platform/ios-simulator/tables/mozilla/core/col_widths_fix_fix-expected.txt:
- platform/ios-simulator/tables/mozilla/core/col_widths_fix_fixPer-expected.txt:
- platform/ios-simulator/tables/mozilla/core/col_widths_fix_per-expected.txt:
- platform/ios-simulator/tables/mozilla/core/margins-expected.txt:
- platform/ios-simulator/tables/mozilla/core/misc-expected.txt:
- platform/ios-simulator/tables/mozilla/core/nested1-expected.txt:
- platform/ios-simulator/tables/mozilla/core/one_row-expected.txt:
- platform/ios-simulator/tables/mozilla/core/table_frame-expected.txt:
- platform/ios-simulator/tables/mozilla/core/table_heights-expected.txt:
- platform/ios-simulator/tables/mozilla/core/table_rules-expected.txt:
- platform/ios-simulator/tables/mozilla/core/table_widths-expected.txt:
- platform/ios-simulator/tables/mozilla/dom/insertColGroups1-expected.txt:
- platform/ios-simulator/tables/mozilla/dom/insertColGroups2-expected.txt:
- platform/ios-simulator/tables/mozilla/dom/insertCols1-expected.txt:
- platform/ios-simulator/tables/mozilla/dom/insertCols2-expected.txt:
- platform/ios-simulator/tables/mozilla/dom/insertCols3-expected.txt:
- platform/ios-simulator/tables/mozilla/dom/insertCols4-expected.txt:
- platform/ios-simulator/tables/mozilla/dom/insertCols5-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/backgr_layers-opacity-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/backgr_position-table-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/backgr_simple-table-cell-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/backgr_simple-table-column-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/backgr_simple-table-column-group-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/backgr_simple-table-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/backgr_simple-table-row-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/backgr_simple-table-row-group-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/colgroup_span-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/colgroup_valign_baseline-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/colgroup_valign_bottom-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/colgroup_valign_middle-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/colgroup_valign_top-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/colgroup_width_pct-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/colgroup_width_px-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/table_overflow_td_dynamic_deactivate-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/table_row_align_center-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/table_row_align_left-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/table_row_align_right-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/tables_bgcolor_aqua-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/tables_bgcolor_aqua_rgb-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/tables_bgcolor_black-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/tables_bgcolor_black_rgb-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/tables_bgcolor_blue-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/tables_bgcolor_blue_rgb-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/tables_bgcolor_fuchsia-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/tables_bgcolor_fuchsia_rgb-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/tables_bgcolor_gray-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/tables_bgcolor_gray_rgb-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/tables_bgcolor_green-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/tables_bgcolor_green_rgb-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/tables_bgcolor_lime-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/tables_bgcolor_lime_rgb-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/tables_bgcolor_maroon-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/tables_bgcolor_maroon_rgb-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/tables_bgcolor_navy-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/tables_bgcolor_navy_rgb-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/tables_bgcolor_olive-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/tables_bgcolor_olive_rgb-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/tables_bgcolor_purple-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/tables_bgcolor_purple_rgb-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/tables_bgcolor_red-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/tables_bgcolor_red_rgb-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/tables_bgcolor_silver-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/tables_bgcolor_silver_rgb-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/tables_bgcolor_teal-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/tables_bgcolor_teal_rgb-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/tables_bgcolor_white-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/tables_bgcolor_white_rgb-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/tables_bgcolor_yellow-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/tables_bgcolor_yellow_rgb-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/tables_cellpadding_pct-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/tables_td_width-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/tables_th_colspan-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/tables_th_width-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/tables_width_px-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/tbody_valign_baseline-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/tbody_valign_bottom-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/tbody_valign_middle-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/tbody_valign_top-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/td_valign_baseline-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/td_valign_bottom-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/td_valign_middle-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/td_valign_top-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/tfoot_valign_baseline-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/tfoot_valign_bottom-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/tfoot_valign_middle-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/tfoot_valign_top-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/th_valign_baseline-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/th_valign_bottom-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/th_valign_middle-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/th_valign_top-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/thead_valign_baseline-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/thead_valign_bottom-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/thead_valign_middle-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/thead_valign_top-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/tr_bgcolor_aqua_rgb-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/tr_bgcolor_black-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/tr_bgcolor_black_rgb-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/tr_bgcolor_blue-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/tr_bgcolor_blue_rgb-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/tr_bgcolor_fuchsia-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/tr_bgcolor_fuchsia_rgb-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/tr_bgcolor_gray-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/tr_bgcolor_gray_rgb-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/tr_bgcolor_green-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/tr_bgcolor_green_rgb-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/tr_bgcolor_lime-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/tr_bgcolor_lime_rgb-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/tr_bgcolor_maroon-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/tr_bgcolor_maroon_rgb-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/tr_bgcolor_navy-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/tr_bgcolor_navy_rgb-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/tr_bgcolor_olive-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/tr_bgcolor_olive_rgb-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/tr_bgcolor_purple-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/tr_bgcolor_purple_rgb-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/tr_bgcolor_red-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/tr_bgcolor_red_rgb-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/tr_bgcolor_silver-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/tr_bgcolor_silver_rgb-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/tr_bgcolor_teal-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/tr_bgcolor_teal_rgb-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/tr_bgcolor_white-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/tr_bgcolor_white_rgb-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/tr_bgcolor_yellow-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/tr_bgcolor_yellow_rgb-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/tr_valign_baseline-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/tr_valign_bottom-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/tr_valign_middle-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/tr_valign_top-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/x_col_align_char-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/x_col_span-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/x_col_valign_baseline-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/x_col_valign_bottom-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/x_col_valign_middle-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/x_col_valign_top-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/x_col_width_px-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/x_col_width_rel-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/x_colgroup_align_char-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/x_colgroup_span-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/x_colgroup_valign_baseline-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/x_colgroup_valign_bottom-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/x_colgroup_valign_middle-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/x_colgroup_valign_top-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/x_colgroup_width_rel-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/x_tbody_valign_baseline-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/x_tbody_valign_bottom-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/x_tbody_valign_middle-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/x_tbody_valign_top-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/x_td_align_center-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/x_td_align_char-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/x_td_align_justify-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/x_td_align_left-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/x_td_align_right-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/x_td_valign_baseline-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/x_td_valign_bottom-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/x_td_valign_middle-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/x_td_valign_top-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/x_td_width-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/x_tfoot_valign_baseline-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/x_tfoot_valign_bottom-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/x_tfoot_valign_middle-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/x_tfoot_valign_top-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/x_th_align_center-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/x_th_align_char-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/x_th_align_justify-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/x_th_align_left-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/x_th_align_right-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/x_th_rowspan-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/x_th_valign_baseline-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/x_th_valign_bottom-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/x_th_valign_middle-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/x_th_valign_top-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/x_th_width-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/x_thead_valign_baseline-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/x_thead_valign_bottom-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/x_thead_valign_middle-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/x_thead_valign_top-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/x_tr_align_char-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/x_tr_valign_baseline-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/x_tr_valign_bottom-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/x_tr_valign_middle-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/x_tr_valign_top-expected.txt:
- platform/ios-simulator/tables/mozilla/other/cell_widths-expected.txt:
- platform/ios-simulator/tables/mozilla/other/ms-expected.txt:
- platform/ios-simulator/tables/mozilla/other/nested2-expected.txt:
- platform/ios-simulator/tables/mozilla/other/nestedTables-expected.txt:
- platform/ios-simulator/tables/mozilla/other/slashlogo-expected.txt:
- platform/ios-simulator/tables/mozilla/other/test3-expected.txt:
- platform/ios-simulator/tables/mozilla/other/test6-expected.txt:
- platform/ios-simulator/tables/mozilla/other/wa_table_thtd_rowspan-expected.txt:
- platform/ios-simulator/tables/mozilla_expected_failures/bugs/97619-expected.txt:
- platform/ios-simulator/tables/mozilla_expected_failures/bugs/bug1055-2-expected.txt:
- platform/ios-simulator/tables/mozilla_expected_failures/bugs/bug1128-expected.txt:
- platform/ios-simulator/tables/mozilla_expected_failures/bugs/bug1164-expected.txt:
- platform/ios-simulator/tables/mozilla_expected_failures/bugs/bug14007-1-expected.txt:
- platform/ios-simulator/tables/mozilla_expected_failures/bugs/bug14007-2-expected.txt:
- platform/ios-simulator/tables/mozilla_expected_failures/bugs/bug14159-2-expected.txt:
- platform/ios-simulator/tables/mozilla_expected_failures/bugs/bug1647-expected.txt:
- platform/ios-simulator/tables/mozilla_expected_failures/bugs/bug1725-expected.txt:
- platform/ios-simulator/tables/mozilla_expected_failures/bugs/bug17826-expected.txt:
- platform/ios-simulator/tables/mozilla_expected_failures/bugs/bug21518-expected.txt:
- platform/ios-simulator/tables/mozilla_expected_failures/bugs/bug22122-expected.txt:
- platform/ios-simulator/tables/mozilla_expected_failures/bugs/bug23847-expected.txt:
- platform/ios-simulator/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt:
- platform/ios-simulator/tables/mozilla_expected_failures/bugs/bug27993-2-expected.txt:
- platform/ios-simulator/tables/mozilla_expected_failures/bugs/bug29058-2-expected.txt:
- platform/ios-simulator/tables/mozilla_expected_failures/bugs/bug3105-expected.txt:
- platform/ios-simulator/tables/mozilla_expected_failures/bugs/bug56024-expected.txt:
- platform/ios-simulator/tables/mozilla_expected_failures/bugs/bug59252-expected.txt:
- platform/ios-simulator/tables/mozilla_expected_failures/bugs/bug7121-2-expected.txt:
- platform/ios-simulator/tables/mozilla_expected_failures/bugs/bug72393-expected.txt:
- platform/ios-simulator/tables/mozilla_expected_failures/bugs/bug7243-expected.txt:
- platform/ios-simulator/tables/mozilla_expected_failures/bugs/bug80762-2-expected.txt:
- platform/ios-simulator/tables/mozilla_expected_failures/bugs/bug89315-expected.txt:
- platform/ios-simulator/tables/mozilla_expected_failures/bugs/bug91057-expected.txt:
- platform/ios-simulator/tables/mozilla_expected_failures/bugs/bug9879-1-expected.txt:
- platform/ios-simulator/tables/mozilla_expected_failures/collapsing_borders/bug41262-1-expected.txt:
- platform/ios-simulator/tables/mozilla_expected_failures/core/captions1-expected.txt:
- platform/ios-simulator/tables/mozilla_expected_failures/core/captions2-expected.txt:
- platform/ios-simulator/tables/mozilla_expected_failures/core/col_span2-expected.txt:
- platform/ios-simulator/tables/mozilla_expected_failures/core/cols1-expected.txt:
- platform/ios-simulator/tables/mozilla_expected_failures/core/columns-expected.txt:
- platform/ios-simulator/tables/mozilla_expected_failures/core/standards1-expected.txt:
- platform/ios-simulator/tables/mozilla_expected_failures/dom/appendColGroup1-expected.txt:
- platform/ios-simulator/tables/mozilla_expected_failures/marvin/backgr_border-table-cell-expected.txt:
- platform/ios-simulator/tables/mozilla_expected_failures/marvin/backgr_border-table-column-expected.txt:
- platform/ios-simulator/tables/mozilla_expected_failures/marvin/backgr_border-table-column-group-expected.txt:
- platform/ios-simulator/tables/mozilla_expected_failures/marvin/backgr_border-table-expected.txt:
- platform/ios-simulator/tables/mozilla_expected_failures/marvin/backgr_border-table-quirks-expected.txt:
- platform/ios-simulator/tables/mozilla_expected_failures/marvin/backgr_border-table-row-expected.txt:
- platform/ios-simulator/tables/mozilla_expected_failures/marvin/backgr_border-table-row-group-expected.txt:
- platform/ios-simulator/tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.txt:
- platform/ios-simulator/tables/mozilla_expected_failures/marvin/backgr_layers-hide-expected.txt:
- platform/ios-simulator/tables/mozilla_expected_failures/marvin/backgr_layers-show-expected.txt:
- platform/ios-simulator/tables/mozilla_expected_failures/marvin/backgr_position-table-cell-expected.txt:
- platform/ios-simulator/tables/mozilla_expected_failures/marvin/backgr_position-table-column-expected.txt:
- platform/ios-simulator/tables/mozilla_expected_failures/marvin/backgr_position-table-column-group-expected.txt:
- platform/ios-simulator/tables/mozilla_expected_failures/marvin/backgr_position-table-row-expected.txt:
- platform/ios-simulator/tables/mozilla_expected_failures/marvin/backgr_position-table-row-group-expected.txt:
- platform/ios-simulator/tables/mozilla_expected_failures/marvin/table_overflow_caption-expected.txt:
- platform/ios-simulator/tables/mozilla_expected_failures/marvin/table_overflow_caption_bottom-expected.txt:
- platform/ios-simulator/tables/mozilla_expected_failures/marvin/table_overflow_caption_hidden-expected.txt:
- platform/ios-simulator/tables/mozilla_expected_failures/marvin/table_overflow_caption_hidden_table-expected.txt:
- platform/ios-simulator/tables/mozilla_expected_failures/marvin/table_overflow_caption_left-expected.txt:
- platform/ios-simulator/tables/mozilla_expected_failures/marvin/table_overflow_caption_right-expected.txt:
- platform/ios-simulator/tables/mozilla_expected_failures/marvin/table_overflow_caption_top-expected.txt:
- platform/ios-simulator/tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow-expected.txt:
- platform/ios-simulator/tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow_table-expected.txt:
- platform/ios-simulator/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_cell-expected.txt:
- platform/ios-simulator/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_row_sibling-expected.txt:
- platform/ios-simulator/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_table-expected.txt:
- platform/ios-simulator/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_table_caption-expected.txt:
- platform/ios-simulator/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_tbody-expected.txt:
- platform/ios-simulator/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_tbody_sibling-expected.txt:
- platform/ios-simulator/tables/mozilla_expected_failures/marvin/table_overflow_td_align_right-expected.txt:
- platform/ios-simulator/tables/mozilla_expected_failures/marvin/table_overflow_td_dynamic_deactivate-expected.txt:
- platform/ios-simulator/tables/mozilla_expected_failures/marvin/table_overflow_td_valign_bottom-expected.txt:
- platform/ios-simulator/tables/mozilla_expected_failures/marvin/table_overflow_td_valign_middle-expected.txt:
- platform/ios-simulator/tables/mozilla_expected_failures/marvin/table_overflow_td_valign_top-expected.txt:
- platform/ios-simulator/tables/mozilla_expected_failures/marvin/tables_cellspacing_pct-expected.txt:
- platform/ios-simulator/tables/mozilla_expected_failures/other/empty_cells-expected.txt:
- platform/mac/accessibility/table-detection-expected.txt:
- platform/mac/compositing/contents-opaque/table-parts-expected.txt:
- platform/mac/css1/basic/containment-expected.txt:
- platform/mac/css1/basic/contextual_selectors-expected.txt:
- platform/mac/css1/basic/grouping-expected.txt:
- platform/mac/css1/basic/id_as_selector-expected.txt:
- platform/mac/css1/basic/inheritance-expected.txt:
- platform/mac/css1/box_properties/border-expected.txt:
- platform/mac/css1/box_properties/border_bottom-expected.txt:
- platform/mac/css1/box_properties/border_bottom_inline-expected.txt:
- platform/mac/css1/box_properties/border_bottom_width-expected.txt:
- platform/mac/css1/box_properties/border_bottom_width_inline-expected.txt:
- platform/mac/css1/box_properties/border_color-expected.txt:
- platform/mac/css1/box_properties/border_color_inline-expected.txt:
- platform/mac/css1/box_properties/border_inline-expected.txt:
- platform/mac/css1/box_properties/border_left-expected.txt:
- platform/mac/css1/box_properties/border_left_inline-expected.txt:
- platform/mac/css1/box_properties/border_left_width-expected.txt:
- platform/mac/css1/box_properties/border_left_width_inline-expected.txt:
- platform/mac/css1/box_properties/border_right-expected.txt:
- platform/mac/css1/box_properties/border_right_inline-expected.txt:
- platform/mac/css1/box_properties/border_right_width-expected.txt:
- platform/mac/css1/box_properties/border_right_width_inline-expected.txt:
- platform/mac/css1/box_properties/border_style-expected.txt:
- platform/mac/css1/box_properties/border_style_inline-expected.txt:
- platform/mac/css1/box_properties/border_top-expected.txt:
- platform/mac/css1/box_properties/border_top_inline-expected.txt:
- platform/mac/css1/box_properties/border_top_width-expected.txt:
- platform/mac/css1/box_properties/border_top_width_inline-expected.txt:
- platform/mac/css1/box_properties/border_width-expected.txt:
- platform/mac/css1/box_properties/border_width_inline-expected.txt:
- platform/mac/css1/box_properties/clear-expected.txt:
- platform/mac/css1/box_properties/clear_float-expected.txt:
- platform/mac/css1/box_properties/float-expected.txt:
- platform/mac/css1/box_properties/float_elements_in_series-expected.txt:
- platform/mac/css1/box_properties/float_margin-expected.txt:
- platform/mac/css1/box_properties/float_on_text_elements-expected.txt:
- platform/mac/css1/box_properties/height-expected.txt:
- platform/mac/css1/box_properties/margin-expected.txt:
- platform/mac/css1/box_properties/margin_bottom-expected.txt:
- platform/mac/css1/box_properties/margin_bottom_inline-expected.txt:
- platform/mac/css1/box_properties/margin_inline-expected.txt:
- platform/mac/css1/box_properties/margin_left-expected.txt:
- platform/mac/css1/box_properties/margin_left_inline-expected.txt:
- platform/mac/css1/box_properties/margin_right-expected.txt:
- platform/mac/css1/box_properties/margin_right_inline-expected.txt:
- platform/mac/css1/box_properties/margin_top-expected.txt:
- platform/mac/css1/box_properties/margin_top_inline-expected.txt:
- platform/mac/css1/box_properties/padding-expected.txt:
- platform/mac/css1/box_properties/padding_bottom-expected.txt:
- platform/mac/css1/box_properties/padding_bottom_inline-expected.txt:
- platform/mac/css1/box_properties/padding_inline-expected.txt:
- platform/mac/css1/box_properties/padding_left-expected.txt:
- platform/mac/css1/box_properties/padding_left_inline-expected.txt:
- platform/mac/css1/box_properties/padding_right-expected.txt:
- platform/mac/css1/box_properties/padding_right_inline-expected.txt:
- platform/mac/css1/box_properties/padding_top-expected.txt:
- platform/mac/css1/box_properties/padding_top_inline-expected.txt:
- platform/mac/css1/box_properties/width-expected.txt:
- platform/mac/css1/cascade/cascade_order-expected.txt:
- platform/mac/css1/cascade/important-expected.txt:
- platform/mac/css1/classification/display-expected.txt:
- platform/mac/css1/classification/list_style-expected.txt:
- platform/mac/css1/classification/list_style_image-expected.txt:
- platform/mac/css1/classification/list_style_position-expected.txt:
- platform/mac/css1/classification/list_style_type-expected.txt:
- platform/mac/css1/classification/white_space-expected.txt:
- platform/mac/css1/color_and_background/background-expected.txt:
- platform/mac/css1/color_and_background/background_attachment-expected.txt:
- platform/mac/css1/color_and_background/background_color-expected.txt:
- platform/mac/css1/color_and_background/background_image-expected.txt:
- platform/mac/css1/color_and_background/background_position-expected.txt:
- platform/mac/css1/color_and_background/background_repeat-expected.txt:
- platform/mac/css1/color_and_background/color-expected.txt:
- platform/mac/css1/conformance/forward_compatible_parsing-expected.txt:
- platform/mac/css1/font_properties/font-expected.txt:
- platform/mac/css1/font_properties/font_family-expected.txt:
- platform/mac/css1/font_properties/font_size-expected.txt:
- platform/mac/css1/font_properties/font_style-expected.txt:
- platform/mac/css1/font_properties/font_variant-expected.txt:
- platform/mac/css1/font_properties/font_weight-expected.txt:
- platform/mac/css1/formatting_model/canvas-expected.txt:
- platform/mac/css1/formatting_model/floating_elements-expected.txt:
- platform/mac/css1/formatting_model/height_of_lines-expected.txt:
- platform/mac/css1/formatting_model/inline_elements-expected.txt:
- platform/mac/css1/formatting_model/replaced_elements-expected.txt:
- platform/mac/css1/formatting_model/vertical_formatting-expected.txt:
- platform/mac/css1/pseudo/anchor-expected.txt:
- platform/mac/css1/pseudo/firstletter-expected.txt:
- platform/mac/css1/pseudo/firstline-expected.txt:
- platform/mac/css1/pseudo/multiple_pseudo_elements-expected.txt:
- platform/mac/css1/pseudo/pseudo_elements_in_selectors-expected.txt:
- platform/mac/css1/text_properties/letter_spacing-expected.txt:
- platform/mac/css1/text_properties/line_height-expected.txt:
- platform/mac/css1/text_properties/text_align-expected.txt:
- platform/mac/css1/text_properties/text_decoration-expected.txt:
- platform/mac/css1/text_properties/text_indent-expected.txt:
- platform/mac/css1/text_properties/text_transform-expected.txt:
- platform/mac/css1/text_properties/vertical_align-expected.txt:
- platform/mac/css1/text_properties/word_spacing-expected.txt:
- platform/mac/css1/units/color_units-expected.txt:
- platform/mac/css1/units/length_units-expected.txt:
- platform/mac/css1/units/percentage_units-expected.txt:
- platform/mac/css1/units/urls-expected.txt:
- platform/mac/css2.1/20110323/border-collapse-offset-002-expected.txt:
- platform/mac/css2.1/20110323/border-conflict-style-079-expected.txt:
- platform/mac/css2.1/20110323/border-conflict-style-088-expected.txt:
- platform/mac/css2.1/20110323/dynamic-top-change-002-expected.txt:
- platform/mac/css2.1/20110323/dynamic-top-change-003-expected.txt:
- platform/mac/css2.1/20110323/inline-table-001-expected.txt:
- platform/mac/css2.1/20110323/inline-table-003-expected.txt:
- platform/mac/css2.1/20110323/margin-applies-to-001-expected.txt:
- platform/mac/css2.1/20110323/margin-applies-to-002-expected.txt:
- platform/mac/css2.1/20110323/margin-applies-to-003-expected.txt:
- platform/mac/css2.1/20110323/margin-applies-to-004-expected.txt:
- platform/mac/css2.1/20110323/margin-applies-to-005-expected.txt:
- platform/mac/css2.1/20110323/margin-applies-to-006-expected.txt:
- platform/mac/css2.1/20110323/margin-applies-to-007-expected.txt:
- platform/mac/css2.1/20110323/margin-applies-to-013-expected.txt:
- platform/mac/css2.1/20110323/margin-applies-to-014-expected.txt:
- platform/mac/css2.1/20110323/margin-applies-to-015-expected.txt:
- platform/mac/css2.1/20110323/replaced-intrinsic-ratio-001-expected.txt:
- platform/mac/css2.1/20110323/table-caption-001-expected.txt:
- platform/mac/css2.1/20110323/table-caption-optional-001-expected.txt:
- platform/mac/css2.1/20110323/table-caption-optional-002-expected.txt:
- platform/mac/css2.1/t040302-c61-ex-len-00-b-a-expected.txt:
- platform/mac/css2.1/t0803-c5501-mrgn-t-00-b-a-expected.txt:
- platform/mac/css2.1/t0803-c5503-mrgn-b-00-b-a-expected.txt:
- platform/mac/css2.1/t080301-c411-vt-mrgn-00-b-expected.txt:
- platform/mac/css2.1/t0804-c5506-padn-t-00-b-a-expected.txt:
- platform/mac/css2.1/t0804-c5508-ipadn-b-03-b-a-expected.txt:
- platform/mac/css2.1/t090402-c42-ibx-pad-00-d-ag-expected.txt:
- platform/mac/css2.1/t0905-c5525-fltmult-00-d-g-expected.txt:
- platform/mac/css2.1/t170602-bdr-conflct-w-04-d-expected.txt:
- platform/mac/css2.1/t170602-bdr-conflct-w-06-d-expected.txt:
- platform/mac/css2.1/t170602-bdr-conflct-w-08-d-expected.txt:
- platform/mac/css2.1/t170602-bdr-conflct-w-13-d-expected.txt:
- platform/mac/css2.1/t170602-bdr-conflct-w-14-d-expected.txt:
- platform/mac/css2.1/t170602-bdr-conflct-w-16-d-expected.txt:
- platform/mac/css2.1/t170602-bdr-conflct-w-17-d-expected.txt:
- platform/mac/css2.1/t170602-bdr-conflct-w-18-d-expected.txt:
- platform/mac/css2.1/t170602-bdr-conflct-w-24-d-expected.txt:
- platform/mac/css2.1/t170602-bdr-conflct-w-25-d-expected.txt:
- platform/mac/css2.1/t170602-bdr-conflct-w-30-d-expected.txt:
- platform/mac/css2.1/t170602-bdr-conflct-w-31-d-expected.txt:
- platform/mac/css2.1/t170602-bdr-conflct-w-34-d-expected.txt:
- platform/mac/css2.1/t170602-bdr-conflct-w-44-d-expected.txt:
- platform/mac/css2.1/t170602-bdr-conflct-w-52-d-expected.txt:
- platform/mac/css2.1/t170602-bdr-conflct-w-54-d-expected.txt:
- platform/mac/css2.1/t170602-bdr-conflct-w-59-d-expected.txt:
- platform/mac/css2.1/t170602-bdr-conflct-w-64-d-expected.txt:
- platform/mac/css2.1/t170602-bdr-conflct-w-65-d-expected.txt:
- platform/mac/css2.1/t170602-bdr-conflct-w-70-d-expected.txt:
- platform/mac/css2.1/t170602-bdr-conflct-w-71-d-expected.txt:
- platform/mac/css2.1/t170602-bdr-conflct-w-74-d-expected.txt:
- platform/mac/css2.1/t170602-bdr-conflct-w-84-d-expected.txt:
- platform/mac/css2.1/t170602-bdr-conflct-w-85-d-expected.txt:
- platform/mac/css2.1/t170602-bdr-conflct-w-94-d-expected.txt:
- platform/mac/css2.1/tables/table-anonymous-objects-177-expected.txt:
- platform/mac/css2.1/tables/table-anonymous-objects-178-expected.txt:
- platform/mac/css2.1/tables/table-anonymous-objects-179-expected.txt:
- platform/mac/css2.1/tables/table-anonymous-objects-180-expected.txt:
- platform/mac/css2.1/tables/table-anonymous-objects-181-expected.txt:
- platform/mac/css2.1/tables/table-anonymous-objects-189-expected.txt:
- platform/mac/css2.1/tables/table-anonymous-objects-190-expected.txt:
- platform/mac/css2.1/tables/table-anonymous-objects-191-expected.txt:
- platform/mac/css2.1/tables/table-anonymous-objects-192-expected.txt:
- platform/mac/css2.1/tables/table-anonymous-objects-193-expected.txt:
- platform/mac/css2.1/tables/table-anonymous-objects-194-expected.txt:
- platform/mac/css2.1/tables/table-anonymous-objects-195-expected.txt:
- platform/mac/css2.1/tables/table-anonymous-objects-196-expected.txt:
- platform/mac/css2.1/tables/table-anonymous-objects-205-expected.txt:
- platform/mac/css2.1/tables/table-anonymous-objects-206-expected.txt:
- platform/mac/css3/css3-modsel-33-expected.txt:
- platform/mac/css3/selectors3/html/css3-modsel-29-expected.txt:
- platform/mac/css3/selectors3/html/css3-modsel-29b-expected.txt:
- platform/mac/css3/selectors3/html/css3-modsel-33-expected.txt:
- platform/mac/css3/selectors3/html/css3-modsel-73-expected.txt:
- platform/mac/css3/selectors3/html/css3-modsel-73b-expected.txt:
- platform/mac/css3/selectors3/html/css3-modsel-77-expected.txt:
- platform/mac/css3/selectors3/html/css3-modsel-77b-expected.txt:
- platform/mac/css3/selectors3/xhtml/css3-modsel-29-expected.txt:
- platform/mac/css3/selectors3/xhtml/css3-modsel-29b-expected.txt:
- platform/mac/css3/selectors3/xhtml/css3-modsel-33-expected.txt:
- platform/mac/css3/selectors3/xhtml/css3-modsel-73-expected.txt:
- platform/mac/css3/selectors3/xhtml/css3-modsel-73b-expected.txt:
- platform/mac/css3/selectors3/xhtml/css3-modsel-77-expected.txt:
- platform/mac/css3/selectors3/xhtml/css3-modsel-77b-expected.txt:
- platform/mac/css3/selectors3/xml/css3-modsel-29-expected.txt:
- platform/mac/css3/selectors3/xml/css3-modsel-29b-expected.txt:
- platform/mac/css3/selectors3/xml/css3-modsel-33-expected.txt:
- platform/mac/css3/selectors3/xml/css3-modsel-73-expected.txt:
- platform/mac/css3/selectors3/xml/css3-modsel-73b-expected.txt:
- platform/mac/css3/selectors3/xml/css3-modsel-77-expected.txt:
- platform/mac/css3/selectors3/xml/css3-modsel-77b-expected.txt:
- platform/mac/editing/deleting/4922367-expected.txt:
- platform/mac/editing/deleting/5126166-expected.txt:
- platform/mac/editing/deleting/5144139-2-expected.txt:
- platform/mac/editing/deleting/5206311-1-expected.txt:
- platform/mac/editing/deleting/5433862-2-expected.txt:
- platform/mac/editing/inserting/paragraph-separator-in-table-1-expected.txt:
- platform/mac/editing/pasteboard/innerText-inline-table-expected.txt:
- platform/mac/editing/selection/3690703-2-expected.txt:
- platform/mac/editing/selection/3690703-expected.txt:
- platform/mac/editing/selection/3690719-expected.txt:
- platform/mac/editing/selection/5057506-2-expected.txt:
- platform/mac/editing/selection/5057506-expected.txt:
- platform/mac/editing/selection/5131716-1-expected.txt:
- platform/mac/editing/selection/5131716-2-expected.txt:
- platform/mac/editing/selection/5131716-3-expected.txt:
- platform/mac/editing/selection/5131716-4-expected.txt:
- platform/mac/editing/selection/move-by-line-001-expected.txt:
- platform/mac/editing/selection/select-all-004-expected.txt:
- platform/mac/editing/unsupported-content/table-type-after-expected.txt:
- platform/mac/editing/unsupported-content/table-type-before-expected.txt:
- platform/mac/fast/block/basic/016-expected.txt:
- platform/mac/fast/block/basic/quirk-percent-height-table-cell-expected.txt:
- platform/mac/fast/block/float/015-expected.txt:
- platform/mac/fast/block/margin-collapse/006-expected.txt:
- platform/mac/fast/block/margin-collapse/010-expected.txt:
- platform/mac/fast/block/margin-collapse/011-expected.txt:
- platform/mac/fast/block/margin-collapse/012-expected.txt:
- platform/mac/fast/block/margin-collapse/015-expected.txt:
- platform/mac/fast/block/margin-collapse/016-expected.txt:
- platform/mac/fast/block/margin-collapse/017-expected.txt:
- platform/mac/fast/block/margin-collapse/018-expected.txt:
- platform/mac/fast/block/margin-collapse/019-expected.txt:
- platform/mac/fast/block/margin-collapse/020-expected.txt:
- platform/mac/fast/block/margin-collapse/021-expected.txt:
- platform/mac/fast/block/margin-collapse/022-expected.txt:
- platform/mac/fast/block/margin-collapse/025-expected.txt:
- platform/mac/fast/block/margin-collapse/032-expected.txt:
- platform/mac/fast/block/margin-collapse/033-expected.txt:
- platform/mac/fast/block/margin-collapse/034-expected.txt:
- platform/mac/fast/block/margin-collapse/041-expected.txt:
- platform/mac/fast/block/margin-collapse/042-expected.txt:
- platform/mac/fast/block/margin-collapse/055-expected.txt:
- platform/mac/fast/block/margin-collapse/056-expected.txt:
- platform/mac/fast/block/margin-collapse/057-expected.txt:
- platform/mac/fast/block/margin-collapse/058-expected.txt:
- platform/mac/fast/block/margin-collapse/059-expected.txt:
- platform/mac/fast/block/margin-collapse/block-inside-inline/006-expected.txt:
- platform/mac/fast/block/margin-collapse/block-inside-inline/010-expected.txt:
- platform/mac/fast/block/margin-collapse/block-inside-inline/011-expected.txt:
- platform/mac/fast/block/margin-collapse/block-inside-inline/012-expected.txt:
- platform/mac/fast/block/margin-collapse/block-inside-inline/015-expected.txt:
- platform/mac/fast/block/margin-collapse/block-inside-inline/016-expected.txt:
- platform/mac/fast/block/margin-collapse/block-inside-inline/017-expected.txt:
- platform/mac/fast/block/margin-collapse/block-inside-inline/018-expected.txt:
- platform/mac/fast/block/margin-collapse/block-inside-inline/019-expected.txt:
- platform/mac/fast/block/margin-collapse/block-inside-inline/020-expected.txt:
- platform/mac/fast/block/margin-collapse/block-inside-inline/021-expected.txt:
- platform/mac/fast/block/margin-collapse/block-inside-inline/022-expected.txt:
- platform/mac/fast/block/margin-collapse/block-inside-inline/025-expected.txt:
- platform/mac/fast/block/positioning/negative-right-pos-expected.txt:
- platform/mac/fast/block/positioning/table-cell-static-position-expected.txt:
- platform/mac/fast/borders/border-antialiasing-expected.txt:
- platform/mac/fast/borders/border-radius-different-width-001-expected.txt:
- platform/mac/fast/borders/table-borders-expected.txt:
- platform/mac/fast/css-generated-content/first-letter-in-nested-before-expected.txt:
- platform/mac/fast/css-generated-content/first-letter-in-nested-before-table-expected.txt:
- platform/mac/fast/css-generated-content/nested-tables-with-before-after-content-crash-expected.txt:
- platform/mac/fast/css-generated-content/table-cell-before-after-child-add-expected.txt:
- platform/mac/fast/css-generated-content/table-parts-before-and-after-expected.txt:
- platform/mac/fast/css-generated-content/table-row-group-with-before-expected.txt:
- platform/mac/fast/css-generated-content/table-row-with-before-expected.txt:
- platform/mac/fast/css-generated-content/table-with-before-expected.txt:
- platform/mac/fast/css/003-expected.txt:
- platform/mac/fast/css/absolute-poition-in-rtl-parent-expected.txt:
- platform/mac/fast/css/acid2-expected.txt:
- platform/mac/fast/css/acid2-pixel-expected.txt:
- platform/mac/fast/css/bidi-override-in-anonymous-block-expected.txt:
- platform/mac/fast/css/box-shadow-and-border-radius-expected.txt:
- platform/mac/fast/css/caption-width-absolute-position-expected.txt:
- platform/mac/fast/css/caption-width-absolute-position-offset-top-expected.txt:
- platform/mac/fast/css/caption-width-fixed-position-expected.txt:
- platform/mac/fast/css/caption-width-fixed-position-offset-top-expected.txt:
- platform/mac/fast/css/caption-width-relative-position-expected.txt:
- platform/mac/fast/css/caption-width-relative-position-offset-top-expected.txt:
- platform/mac/fast/css/css3-nth-child-expected.txt:
- platform/mac/fast/css/focus-ring-detached-expected.txt:
- platform/mac/fast/css/focus-ring-multiline-expected.txt:
- platform/mac/fast/css/h1-in-section-elements-expected.txt:
- platform/mac/fast/css/image-rendering-expected.txt:
- platform/mac/fast/css/min-width-with-spanned-cell-expected.txt:
- platform/mac/fast/css/percentage-non-integer-expected.txt:
- platform/mac/fast/css/table-text-align-quirk-expected.txt:
- platform/mac/fast/css/table-text-align-strict-expected.txt:
- platform/mac/fast/dom/34176-expected.txt:
- platform/mac/fast/dom/HTMLTableElement/colSpan-expected.txt:
- platform/mac/fast/dom/HTMLTableElement/createCaption-expected.txt:
- platform/mac/fast/dom/row-inner-text-expected.txt:
- platform/mac/fast/dynamic/001-expected.txt:
- platform/mac/fast/dynamic/containing-block-change-expected.txt:
- platform/mac/fast/dynamic/float-withdrawal-expected.txt:
- platform/mac/fast/dynamic/insert-before-table-part-in-continuation-expected.txt:
- platform/mac/fast/dynamic/subtree-table-cell-height-expected.txt:
- platform/mac/fast/encoding/utf-16-big-endian-expected.txt:
- platform/mac/fast/encoding/utf-16-little-endian-expected.txt:
- platform/mac/fast/forms/001-expected.txt:
- platform/mac/fast/forms/005-expected.txt:
- platform/mac/fast/forms/basic-buttons-expected.txt:
- platform/mac/fast/forms/form-element-geometry-expected.txt:
- platform/mac/fast/forms/form-hides-table-expected.txt:
- platform/mac/fast/forms/form-in-malformed-markup-expected.txt:
- platform/mac/fast/forms/formmove3-expected.txt:
- platform/mac/fast/forms/input-table-expected.txt:
- platform/mac/fast/forms/listbox-bidi-align-expected.txt:
- platform/mac/fast/forms/preserveFormDuringResidualStyle-expected.txt:
- platform/mac/fast/forms/select-dirty-parent-pref-widths-expected.txt:
- platform/mac/fast/html/details-writing-mode-expected.txt:
- platform/mac/fast/inline-block/001-expected.txt:
- platform/mac/fast/inline-block/overflow-clip-expected.txt:
- platform/mac/fast/invalid/012-expected.txt:
- platform/mac/fast/invalid/018-expected.txt:
- platform/mac/fast/lists/004-expected.txt:
- platform/mac/fast/lists/list-marker-before-content-table-expected.txt:
- platform/mac/fast/multicol/span/before-child-anonymous-column-block-expected.txt:
- platform/mac/fast/overflow/002-expected.txt:
- platform/mac/fast/overflow/overflow-rtl-expected.txt:
- platform/mac/fast/overflow/overflow-rtl-vertical-expected.txt:
- platform/mac/fast/overflow/table-overflow-float-expected.txt:
- platform/mac/fast/reflections/table-cell-expected.txt:
- platform/mac/fast/repaint/block-selection-gap-in-table-cell-expected.txt:
- platform/mac/fast/repaint/float-overflow-expected.txt:
- platform/mac/fast/repaint/float-overflow-right-expected.txt:
- platform/mac/fast/repaint/subtree-root-clip-3-expected.txt:
- platform/mac/fast/repaint/table-cell-collapsed-border-expected.txt:
- platform/mac/fast/repaint/table-cell-collapsed-border-scroll-expected.txt:
- platform/mac/fast/repaint/table-cell-move-expected.txt:
- platform/mac/fast/repaint/table-cell-overflow-expected.txt:
- platform/mac/fast/repaint/table-cell-vertical-overflow-expected.txt:
- platform/mac/fast/repaint/table-col-background-expected.txt:
- platform/mac/fast/repaint/table-collapsed-border-expected.txt:
- platform/mac/fast/repaint/table-extra-bottom-grow-expected.txt:
- platform/mac/fast/repaint/table-outer-border-expected.txt:
- platform/mac/fast/repaint/table-row-expected.txt:
- platform/mac/fast/repaint/table-section-overflow-expected.txt:
- platform/mac/fast/repaint/table-section-repaint-expected.txt:
- platform/mac/fast/repaint/table-two-pass-layout-overpaint-expected.txt:
- platform/mac/fast/repaint/table-writing-modes-h-expected.txt:
- platform/mac/fast/repaint/table-writing-modes-v-expected.txt:
- platform/mac/fast/replaced/005-expected.txt:
- platform/mac/fast/replaced/percent-height-in-anonymous-block-in-table-expected.txt:
- platform/mac/fast/replaced/selection-rect-in-table-cell-expected.txt:
- platform/mac/fast/replaced/table-percent-height-positioned-expected.txt:
- platform/mac/fast/replaced/width100percent-checkbox-expected.txt:
- platform/mac/fast/replaced/width100percent-image-expected.txt:
- platform/mac/fast/replaced/width100percent-menulist-expected.txt:
- platform/mac/fast/replaced/width100percent-radio-expected.txt:
- platform/mac/fast/replaced/width100percent-searchfield-expected.txt:
- platform/mac/fast/replaced/width100percent-textarea-expected.txt:
- platform/mac/fast/replaced/width100percent-textfield-expected.txt:
- platform/mac/fast/selectors/077-expected.txt:
- platform/mac/fast/selectors/077b-expected.txt:
- platform/mac/fast/table/002-expected.txt:
- platform/mac/fast/table/003-expected.txt:
- platform/mac/fast/table/005-expected.txt:
- platform/mac/fast/table/007-expected.txt:
- platform/mac/fast/table/008-expected.txt:
- platform/mac/fast/table/009-expected.txt:
- platform/mac/fast/table/012-expected.txt:
- platform/mac/fast/table/013-expected.txt:
- platform/mac/fast/table/021-expected.txt:
- platform/mac/fast/table/023-expected.txt:
- platform/mac/fast/table/024-expected.txt:
- platform/mac/fast/table/025-expected.txt:
- platform/mac/fast/table/028-expected.txt:
- platform/mac/fast/table/028-vertical-expected.txt:
- platform/mac/fast/table/029-expected.txt:
- platform/mac/fast/table/031-expected.txt:
- platform/mac/fast/table/032-expected.txt:
- platform/mac/fast/table/034-expected.txt:
- platform/mac/fast/table/038-expected.txt:
- platform/mac/fast/table/038-vertical-expected.txt:
- platform/mac/fast/table/039-expected.txt:
- platform/mac/fast/table/040-expected.txt:
- platform/mac/fast/table/040-vertical-expected.txt:
- platform/mac/fast/table/100-percent-cell-width-expected.txt:
- platform/mac/fast/table/add-before-anonymous-child-expected.txt:
- platform/mac/fast/table/border-collapsing/001-expected.txt:
- platform/mac/fast/table/border-collapsing/001-vertical-expected.txt:
- platform/mac/fast/table/border-collapsing/002-expected.txt:
- platform/mac/fast/table/border-collapsing/002-vertical-expected.txt:
- platform/mac/fast/table/border-collapsing/003-expected.txt:
- platform/mac/fast/table/border-collapsing/003-vertical-expected.txt:
- platform/mac/fast/table/border-collapsing/004-expected.txt:
- platform/mac/fast/table/border-collapsing/004-vertical-expected.txt:
- platform/mac/fast/table/border-collapsing/border-collapsing-head-foot-expected.txt:
- platform/mac/fast/table/border-collapsing/border-collapsing-head-foot-vertical-expected.txt:
- platform/mac/fast/table/border-collapsing/bug14274-expected.txt:
- platform/mac/fast/table/border-collapsing/cached-69296-expected.txt:
- platform/mac/fast/table/border-collapsing/cached-cell-append-expected.txt:
- platform/mac/fast/table/border-collapsing/cached-cell-remove-expected.txt:
- platform/mac/fast/table/border-collapsing/cached-change-cell-border-color-expected.txt:
- platform/mac/fast/table/border-collapsing/cached-change-cell-border-width-expected.txt:
- platform/mac/fast/table/border-collapsing/cached-change-cell-sl-border-color-expected.txt:
- platform/mac/fast/table/border-collapsing/cached-change-col-border-color-expected.txt:
- platform/mac/fast/table/border-collapsing/cached-change-col-border-width-expected.txt:
- platform/mac/fast/table/border-collapsing/cached-change-colgroup-border-color-expected.txt:
- platform/mac/fast/table/border-collapsing/cached-change-colgroup-border-width-expected.txt:
- platform/mac/fast/table/border-collapsing/cached-change-row-border-color-expected.txt:
- platform/mac/fast/table/border-collapsing/cached-change-row-border-width-expected.txt:
- platform/mac/fast/table/border-collapsing/cached-change-table-border-color-expected.txt:
- platform/mac/fast/table/border-collapsing/cached-change-table-border-width-expected.txt:
- platform/mac/fast/table/border-collapsing/cached-change-tbody-border-color-expected.txt:
- platform/mac/fast/table/border-collapsing/cached-change-tbody-border-width-expected.txt:
- platform/mac/fast/table/border-collapsing/collapsed-borders-adjoining-sections-vertical-rl-expected.txt:
- platform/mac/fast/table/border-collapsing/collapsed-borders-painted-once-on-inner-cells-expected.txt:
- platform/mac/fast/table/border-collapsing/equal-precedence-resolution-expected.txt:
- platform/mac/fast/table/border-collapsing/equal-precedence-resolution-vertical-expected.txt:
- platform/mac/fast/table/border-collapsing/rtl-border-collapsing-expected.txt:
- platform/mac/fast/table/border-collapsing/rtl-border-collapsing-vertical-expected.txt:
- platform/mac/fast/table/caption-relayout-expected.txt:
- platform/mac/fast/table/cell-absolute-child-expected.txt:
- platform/mac/fast/table/cell-width-auto-expected.txt:
- platform/mac/fast/table/colspan-with-all-percent-cells-expected.txt:
- platform/mac/fast/table/colspanMinWidth-expected.txt:
- platform/mac/fast/table/colspanMinWidth-vertical-expected.txt:
- platform/mac/fast/table/dynamic-cellpadding-expected.txt:
- platform/mac/fast/table/edge-offsets-expected.txt:
- platform/mac/fast/table/empty-cells-expected.txt:
- platform/mac/fast/table/frame-and-rules-expected.txt:
- platform/mac/fast/table/giantRowspan-expected.txt:
- platform/mac/fast/table/growCellForImageQuirk-expected.txt:
- platform/mac/fast/table/growCellForImageQuirk-vertical-expected.txt:
- platform/mac/fast/table/height-percent-test-expected.txt:
- platform/mac/fast/table/height-percent-test-vertical-expected.txt:
- platform/mac/fast/table/invisible-cell-background-expected.txt:
- platform/mac/fast/table/large-width-expected.txt:
- platform/mac/fast/table/max-width-integer-overflow-expected.txt:
- platform/mac/fast/table/mozilla-bug10296-vertical-align-1-expected.txt:
- platform/mac/fast/table/mozilla-bug10296-vertical-align-2-expected.txt:
- platform/mac/fast/table/nobr-expected.txt:
- platform/mac/fast/table/overflowHidden-expected.txt:
- platform/mac/fast/table/percent-heights-expected.txt:
- platform/mac/fast/table/percent-widths-stretch-expected.txt:
- platform/mac/fast/table/percent-widths-stretch-vertical-expected.txt:
- platform/mac/fast/table/prepend-in-anonymous-table-expected.txt:
- platform/mac/fast/table/relative-position-containment-expected.txt:
- platform/mac/fast/table/relative-position-offsets-expected.txt:
- platform/mac/fast/table/relative-position-stacking-expected.txt:
- platform/mac/fast/table/replaced-percent-height-expected.txt:
- platform/mac/fast/table/row-height-recalc-expected.txt:
- platform/mac/fast/table/rowspan-paint-order-expected.txt:
- platform/mac/fast/table/rowspan-paint-order-vertical-expected.txt:
- platform/mac/fast/table/simple_paint-expected.txt:
- platform/mac/fast/table/spanOverlapRepaint-expected.txt:
- platform/mac/fast/table/stale-grid-crash-expected.txt:
- platform/mac/fast/table/table-anonymous-cell-bug-expected.txt:
- platform/mac/fast/table/table-anonymous-row-bug-expected.txt:
- platform/mac/fast/table/table-anonymous-section-bug-expected.txt:
- platform/mac/fast/table/table-before-child-style-update-expected.txt:
- platform/mac/fast/table/table-cell-before-after-content-around-table-block-expected.txt:
- platform/mac/fast/table/table-cell-before-after-content-around-table-expected.txt:
- platform/mac/fast/table/table-cell-before-after-content-around-table-row-expected.txt:
- platform/mac/fast/table/table-cell-before-child-in-table-expected.txt:
- platform/mac/fast/table/table-cell-split-expected.txt:
- platform/mac/fast/table/table-display-types-expected.txt:
- platform/mac/fast/table/table-display-types-strict-expected.txt:
- platform/mac/fast/table/table-display-types-vertical-expected.txt:
- platform/mac/fast/table/table-insert-before-non-anonymous-block-expected.txt:
- platform/mac/fast/table/table-row-before-after-content-around-block-expected.txt:
- platform/mac/fast/table/table-row-before-after-content-around-table-cell-expected.txt:
- platform/mac/fast/table/table-row-before-after-content-around-table-expected.txt:
- platform/mac/fast/table/table-row-before-child-style-update-expected.txt:
- platform/mac/fast/table/table-row-outline-paint-expected.txt:
- platform/mac/fast/table/table-row-split2-expected.txt:
- platform/mac/fast/table/table-row-style-not-updated-expected.txt:
- platform/mac/fast/table/table-row-style-not-updated-with-after-content-expected.txt:
- platform/mac/fast/table/table-row-style-not-updated-with-before-content-expected.txt:
- platform/mac/fast/table/table-section-split2-expected.txt:
- platform/mac/fast/table/table-split-expected.txt:
- platform/mac/fast/table/table-split2-expected.txt:
- platform/mac/fast/table/table-style-not-updated-expected.txt:
- platform/mac/fast/table/wide-colspan-expected.txt:
- platform/mac/fast/table/wide-column-expected.txt:
- platform/mac/fast/text/atsui-negative-spacing-features-expected.txt:
- platform/mac/fast/text/atsui-spacing-features-expected.txt:
- platform/mac/fast/text/basic/generic-family-reset-expected.txt:
- platform/mac/fast/text/international/003-expected.txt:
- platform/mac/fast/text/international/bidi-LDB-2-CSS-expected.txt:
- platform/mac/fast/text/international/bidi-LDB-2-HTML-expected.txt:
- platform/mac/fast/text/international/bidi-LDB-2-formatting-characters-expected.txt:
- platform/mac/fast/text/international/bidi-override-expected.txt:
- platform/mac/fast/text/wbr-expected.txt:
- platform/mac/fast/text/whitespace/002-expected.txt:
- platform/mac/fast/text/whitespace/003-expected.txt:
- platform/mac/fast/text/whitespace/004-expected.txt:
- platform/mac/fast/text/whitespace/005-expected.txt:
- platform/mac/fast/text/whitespace/010-expected.txt:
- platform/mac/fast/text/whitespace/011-expected.txt:
- platform/mac/fast/text/whitespace/013-expected.txt:
- platform/mac/fast/text/whitespace/014-expected.txt:
- platform/mac/fast/text/whitespace/015-expected.txt:
- platform/mac/fast/text/whitespace/016-expected.txt:
- platform/mac/fast/text/whitespace/025-expected.txt:
- platform/mac/fast/text/whitespace/026-expected.txt:
- platform/mac/fast/writing-mode/table-percent-width-quirk-expected.txt:
- platform/mac/fast/writing-mode/vertical-align-table-baseline-expected.txt:
- platform/mac/http/tests/misc/acid2-expected.txt:
- platform/mac/http/tests/misc/acid2-pixel-expected.txt:
- platform/mac/http/tests/misc/object-embedding-svg-delayed-size-negotiation-2-expected.txt:
- platform/mac/ietestcenter/css3/bordersbackgrounds/background_properties_greater_than_images-expected.txt:
- platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-006-expected.txt:
- platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-007-expected.txt:
- platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-008-expected.txt:
- platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-009-expected.txt:
- platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-011-expected.txt:
- platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-012-expected.txt:
- platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-013-expected.txt:
- platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-014-expected.txt:
- platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-015-expected.txt:
- platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-016-expected.txt:
- platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-different-width-001-expected.txt:
- platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-shorthand-001-expected.txt:
- platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-001-expected.txt:
- platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-002-expected.txt:
- platform/mac/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-004-expected.txt:
- platform/mac/ietestcenter/css3/bordersbackgrounds/border-top-right-radius-values-004-expected.txt:
- platform/mac/ietestcenter/css3/bordersbackgrounds/none-as-image-layer-expected.txt:
- platform/mac/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.txt:
- platform/mac/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.txt:
- platform/mac/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.txt:
- platform/mac/tables/layering/paint-test-layering-1-expected.txt:
- platform/mac/tables/layering/paint-test-layering-2-expected.txt:
- platform/mac/tables/mozilla/bugs/bug10009-expected.txt:
- platform/mac/tables/mozilla/bugs/bug101201-expected.txt:
- platform/mac/tables/mozilla/bugs/bug101674-expected.txt:
- platform/mac/tables/mozilla/bugs/bug10296-1-expected.txt:
- platform/mac/tables/mozilla/bugs/bug1055-1-expected.txt:
- platform/mac/tables/mozilla/bugs/bug10565-expected.txt:
- platform/mac/tables/mozilla/bugs/bug10633-expected.txt:
- platform/mac/tables/mozilla/bugs/bug1067-1-expected.txt:
- platform/mac/tables/mozilla/bugs/bug1067-2-expected.txt:
- platform/mac/tables/mozilla/bugs/bug106795-expected.txt:
- platform/mac/tables/mozilla/bugs/bug106816-expected.txt:
- platform/mac/tables/mozilla/bugs/bug113235-1-expected.txt:
- platform/mac/tables/mozilla/bugs/bug113424-expected.txt:
- platform/mac/tables/mozilla/bugs/bug1163-1-expected.txt:
- platform/mac/tables/mozilla/bugs/bug1188-expected.txt:
- platform/mac/tables/mozilla/bugs/bug12008-expected.txt:
- platform/mac/tables/mozilla/bugs/bug120107-expected.txt:
- platform/mac/tables/mozilla/bugs/bug120364-expected.txt:
- platform/mac/tables/mozilla/bugs/bug1224-expected.txt:
- platform/mac/tables/mozilla/bugs/bug12268-expected.txt:
- platform/mac/tables/mozilla/bugs/bug12709-expected.txt:
- platform/mac/tables/mozilla/bugs/bug1271-expected.txt:
- platform/mac/tables/mozilla/bugs/bug12908-1-expected.txt:
- platform/mac/tables/mozilla/bugs/bug12908-2-expected.txt:
- platform/mac/tables/mozilla/bugs/bug12910-2-expected.txt:
- platform/mac/tables/mozilla/bugs/bug1296-expected.txt:
- platform/mac/tables/mozilla/bugs/bug1302-expected.txt:
- platform/mac/tables/mozilla/bugs/bug13169-expected.txt:
- platform/mac/tables/mozilla/bugs/bug1318-expected.txt:
- platform/mac/tables/mozilla/bugs/bug137388-1-expected.txt:
- platform/mac/tables/mozilla/bugs/bug137388-2-expected.txt:
- platform/mac/tables/mozilla/bugs/bug137388-3-expected.txt:
- platform/mac/tables/mozilla/bugs/bug139524-1-expected.txt:
- platform/mac/tables/mozilla/bugs/bug139524-2-expected.txt:
- platform/mac/tables/mozilla/bugs/bug139524-3-expected.txt:
- platform/mac/tables/mozilla/bugs/bug139524-4-expected.txt:
- platform/mac/tables/mozilla/bugs/bug1430-expected.txt:
- platform/mac/tables/mozilla/bugs/bug14323-expected.txt:
- platform/mac/tables/mozilla/bugs/bug1474-expected.txt:
- platform/mac/tables/mozilla/bugs/bug14929-expected.txt:
- platform/mac/tables/mozilla/bugs/bug15247-expected.txt:
- platform/mac/tables/mozilla/bugs/bug154780-expected.txt:
- platform/mac/tables/mozilla/bugs/bug15544-expected.txt:
- platform/mac/tables/mozilla/bugs/bug159108-expected.txt:
- platform/mac/tables/mozilla/bugs/bug15933-expected.txt:
- platform/mac/tables/mozilla/bugs/bug16012-expected.txt:
- platform/mac/tables/mozilla/bugs/bug16252-expected.txt:
- platform/mac/tables/mozilla/bugs/bug17138-expected.txt:
- platform/mac/tables/mozilla/bugs/bug175455-4-expected.txt:
- platform/mac/tables/mozilla/bugs/bug17548-expected.txt:
- platform/mac/tables/mozilla/bugs/bug17587-expected.txt:
- platform/mac/tables/mozilla/bugs/bug1800-expected.txt:
- platform/mac/tables/mozilla/bugs/bug1802-expected.txt:
- platform/mac/tables/mozilla/bugs/bug1802s-expected.txt:
- platform/mac/tables/mozilla/bugs/bug1809-expected.txt:
- platform/mac/tables/mozilla/bugs/bug18440-expected.txt:
- platform/mac/tables/mozilla/bugs/bug18664-expected.txt:
- platform/mac/tables/mozilla/bugs/bug18955-expected.txt:
- platform/mac/tables/mozilla/bugs/bug19061-1-expected.txt:
- platform/mac/tables/mozilla/bugs/bug19061-2-expected.txt:
- platform/mac/tables/mozilla/bugs/bug19356-expected.txt:
- platform/mac/tables/mozilla/bugs/bug20804-expected.txt:
- platform/mac/tables/mozilla/bugs/bug2123-expected.txt:
- platform/mac/tables/mozilla/bugs/bug215629-expected.txt:
- platform/mac/tables/mozilla/bugs/bug219693-1-expected.txt:
- platform/mac/tables/mozilla/bugs/bug219693-2-expected.txt:
- platform/mac/tables/mozilla/bugs/bug22019-expected.txt:
- platform/mac/tables/mozilla/bugs/bug220536-expected.txt:
- platform/mac/tables/mozilla/bugs/bug222336-expected.txt:
- platform/mac/tables/mozilla/bugs/bug22246-3-expected.txt:
- platform/mac/tables/mozilla/bugs/bug22246-3a-expected.txt:
- platform/mac/tables/mozilla/bugs/bug22513-expected.txt:
- platform/mac/tables/mozilla/bugs/bug2296-expected.txt:
- platform/mac/tables/mozilla/bugs/bug23235-expected.txt:
- platform/mac/tables/mozilla/bugs/bug24200-expected.txt:
- platform/mac/tables/mozilla/bugs/bug2479-2-expected.txt:
- platform/mac/tables/mozilla/bugs/bug2479-3-expected.txt:
- platform/mac/tables/mozilla/bugs/bug25004-expected.txt:
- platform/mac/tables/mozilla/bugs/bug25074-expected.txt:
- platform/mac/tables/mozilla/bugs/bug25663-expected.txt:
- platform/mac/tables/mozilla/bugs/bug26553-expected.txt:
- platform/mac/tables/mozilla/bugs/bug2684-expected.txt:
- platform/mac/tables/mozilla/bugs/bug269566-expected.txt:
- platform/mac/tables/mozilla/bugs/bug277062-expected.txt:
- platform/mac/tables/mozilla/bugs/bug2773-expected.txt:
- platform/mac/tables/mozilla/bugs/bug27993-1-expected.txt:
- platform/mac/tables/mozilla/bugs/bug2886-expected.txt:
- platform/mac/tables/mozilla/bugs/bug28933-expected.txt:
- platform/mac/tables/mozilla/bugs/bug29058-1-expected.txt:
- platform/mac/tables/mozilla/bugs/bug29314-expected.txt:
- platform/mac/tables/mozilla/bugs/bug29429-expected.txt:
- platform/mac/tables/mozilla/bugs/bug2954-expected.txt:
- platform/mac/tables/mozilla/bugs/bug2981-1-expected.txt:
- platform/mac/tables/mozilla/bugs/bug2981-2-expected.txt:
- platform/mac/tables/mozilla/bugs/bug2997-expected.txt:
- platform/mac/tables/mozilla/bugs/bug30273-expected.txt:
- platform/mac/tables/mozilla/bugs/bug30559-expected.txt:
- platform/mac/tables/mozilla/bugs/bug3103-expected.txt:
- platform/mac/tables/mozilla/bugs/bug32205-3-expected.txt:
- platform/mac/tables/mozilla/bugs/bug3260-expected.txt:
- platform/mac/tables/mozilla/bugs/bug32841-expected.txt:
- platform/mac/tables/mozilla/bugs/bug33137-expected.txt:
- platform/mac/tables/mozilla/bugs/bug33855-expected.txt:
- platform/mac/tables/mozilla/bugs/bug3454-expected.txt:
- platform/mac/tables/mozilla/bugs/bug38916-expected.txt:
- platform/mac/tables/mozilla/bugs/bug3977-expected.txt:
- platform/mac/tables/mozilla/bugs/bug4093-expected.txt:
- platform/mac/tables/mozilla/bugs/bug42187-expected.txt:
- platform/mac/tables/mozilla/bugs/bug4385-expected.txt:
- platform/mac/tables/mozilla/bugs/bug4427-expected.txt:
- platform/mac/tables/mozilla/bugs/bug44505-expected.txt:
- platform/mac/tables/mozilla/bugs/bug4501-expected.txt:
- platform/mac/tables/mozilla/bugs/bug4527-expected.txt:
- platform/mac/tables/mozilla/bugs/bug45350-expected.txt:
- platform/mac/tables/mozilla/bugs/bug45486-expected.txt:
- platform/mac/tables/mozilla/bugs/bug4576-expected.txt:
- platform/mac/tables/mozilla/bugs/bug46268-1-expected.txt:
- platform/mac/tables/mozilla/bugs/bug46268-2-expected.txt:
- platform/mac/tables/mozilla/bugs/bug46368-1-expected.txt:
- platform/mac/tables/mozilla/bugs/bug46623-1-expected.txt:
- platform/mac/tables/mozilla/bugs/bug46623-2-expected.txt:
- platform/mac/tables/mozilla/bugs/bug47432-expected.txt:
- platform/mac/tables/mozilla/bugs/bug4803-expected.txt:
- platform/mac/tables/mozilla/bugs/bug4849-2-expected.txt:
- platform/mac/tables/mozilla/bugs/bug4849-expected.txt:
- platform/mac/tables/mozilla/bugs/bug51727-expected.txt:
- platform/mac/tables/mozilla/bugs/bug5188-expected.txt:
- platform/mac/tables/mozilla/bugs/bug52505-expected.txt:
- platform/mac/tables/mozilla/bugs/bug52506-expected.txt:
- platform/mac/tables/mozilla/bugs/bug53690-1-expected.txt:
- platform/mac/tables/mozilla/bugs/bug53690-2-expected.txt:
- platform/mac/tables/mozilla/bugs/bug53891-expected.txt:
- platform/mac/tables/mozilla/bugs/bug5538-expected.txt:
- platform/mac/tables/mozilla/bugs/bug55789-expected.txt:
- platform/mac/tables/mozilla/bugs/bug56201-expected.txt:
- platform/mac/tables/mozilla/bugs/bug57828-2-expected.txt:
- platform/mac/tables/mozilla/bugs/bug5797-expected.txt:
- platform/mac/tables/mozilla/bugs/bug5835-expected.txt:
- platform/mac/tables/mozilla/bugs/bug60804-expected.txt:
- platform/mac/tables/mozilla/bugs/bug60807-expected.txt:
- platform/mac/tables/mozilla/bugs/bug6184-expected.txt:
- platform/mac/tables/mozilla/bugs/bug6304-expected.txt:
- platform/mac/tables/mozilla/bugs/bug6404-expected.txt:
- platform/mac/tables/mozilla/bugs/bug647-expected.txt:
- platform/mac/tables/mozilla/bugs/bug6674-expected.txt:
- platform/mac/tables/mozilla/bugs/bug68998-expected.txt:
- platform/mac/tables/mozilla/bugs/bug69382-1-expected.txt:
- platform/mac/tables/mozilla/bugs/bug69382-2-expected.txt:
- platform/mac/tables/mozilla/bugs/bug72359-expected.txt:
- platform/mac/tables/mozilla/bugs/bug7342-expected.txt:
- platform/mac/tables/mozilla/bugs/bug7714-expected.txt:
- platform/mac/tables/mozilla/bugs/bug78162-expected.txt:
- platform/mac/tables/mozilla/bugs/bug82946-2-expected.txt:
- platform/mac/tables/mozilla/bugs/bug86708-expected.txt:
- platform/mac/tables/mozilla/bugs/bug8950-expected.txt:
- platform/mac/tables/mozilla/bugs/bug9123-1-expected.txt:
- platform/mac/tables/mozilla/bugs/bug9123-2-expected.txt:
- platform/mac/tables/mozilla/bugs/bug92143-expected.txt:
- platform/mac/tables/mozilla/bugs/bug92647-2-expected.txt:
- platform/mac/tables/mozilla/bugs/bug963-expected.txt:
- platform/mac/tables/mozilla/bugs/bug96334-expected.txt:
- platform/mac/tables/mozilla/bugs/bug97383-expected.txt:
- platform/mac/tables/mozilla/bugs/bug9879-1-expected.txt:
- platform/mac/tables/mozilla/collapsing_borders/bug41262-3-expected.txt:
- platform/mac/tables/mozilla/core/bloomberg-expected.txt:
- platform/mac/tables/mozilla/core/borders-expected.txt:
- platform/mac/tables/mozilla/core/cell_heights-expected.txt:
- platform/mac/tables/mozilla/core/col_span-expected.txt:
- platform/mac/tables/mozilla/core/col_widths_auto_autoFix-expected.txt:
- platform/mac/tables/mozilla/core/col_widths_auto_autoFixPer-expected.txt:
- platform/mac/tables/mozilla/core/col_widths_auto_fix-expected.txt:
- platform/mac/tables/mozilla/core/col_widths_auto_fixPer-expected.txt:
- platform/mac/tables/mozilla/core/col_widths_auto_per-expected.txt:
- platform/mac/tables/mozilla/core/col_widths_fix_autoFix-expected.txt:
- platform/mac/tables/mozilla/core/col_widths_fix_fix-expected.txt:
- platform/mac/tables/mozilla/core/col_widths_fix_fixPer-expected.txt:
- platform/mac/tables/mozilla/core/col_widths_fix_per-expected.txt:
- platform/mac/tables/mozilla/core/margins-expected.txt:
- platform/mac/tables/mozilla/core/misc-expected.txt:
- platform/mac/tables/mozilla/core/nested1-expected.txt:
- platform/mac/tables/mozilla/core/one_row-expected.txt:
- platform/mac/tables/mozilla/core/table_frame-expected.txt:
- platform/mac/tables/mozilla/core/table_heights-expected.txt:
- platform/mac/tables/mozilla/core/table_rules-expected.txt:
- platform/mac/tables/mozilla/core/table_widths-expected.txt:
- platform/mac/tables/mozilla/dom/insertColGroups1-expected.txt:
- platform/mac/tables/mozilla/dom/insertColGroups2-expected.txt:
- platform/mac/tables/mozilla/dom/insertCols1-expected.txt:
- platform/mac/tables/mozilla/dom/insertCols2-expected.txt:
- platform/mac/tables/mozilla/dom/insertCols3-expected.txt:
- platform/mac/tables/mozilla/dom/insertCols4-expected.txt:
- platform/mac/tables/mozilla/dom/insertCols5-expected.txt:
- platform/mac/tables/mozilla/marvin/backgr_layers-opacity-expected.txt:
- platform/mac/tables/mozilla/marvin/backgr_position-table-expected.txt:
- platform/mac/tables/mozilla/marvin/backgr_simple-table-cell-expected.txt:
- platform/mac/tables/mozilla/marvin/backgr_simple-table-column-expected.txt:
- platform/mac/tables/mozilla/marvin/backgr_simple-table-column-group-expected.txt:
- platform/mac/tables/mozilla/marvin/backgr_simple-table-expected.txt:
- platform/mac/tables/mozilla/marvin/backgr_simple-table-row-expected.txt:
- platform/mac/tables/mozilla/marvin/backgr_simple-table-row-group-expected.txt:
- platform/mac/tables/mozilla/marvin/body_thead-expected.txt:
- platform/mac/tables/mozilla/marvin/colgroup_align_center-expected.txt:
- platform/mac/tables/mozilla/marvin/colgroup_align_justify-expected.txt:
- platform/mac/tables/mozilla/marvin/colgroup_align_left-expected.txt:
- platform/mac/tables/mozilla/marvin/colgroup_align_right-expected.txt:
- platform/mac/tables/mozilla/marvin/colgroup_span-expected.txt:
- platform/mac/tables/mozilla/marvin/colgroup_valign_baseline-expected.txt:
- platform/mac/tables/mozilla/marvin/colgroup_valign_bottom-expected.txt:
- platform/mac/tables/mozilla/marvin/colgroup_valign_middle-expected.txt:
- platform/mac/tables/mozilla/marvin/colgroup_valign_top-expected.txt:
- platform/mac/tables/mozilla/marvin/colgroup_width_pct-expected.txt:
- platform/mac/tables/mozilla/marvin/colgroup_width_px-expected.txt:
- platform/mac/tables/mozilla/marvin/table_overflow_hidden_td-expected.txt:
- platform/mac/tables/mozilla/marvin/table_overflow_td_dynamic_deactivate-expected.txt:
- platform/mac/tables/mozilla/marvin/table_row_align_center-expected.txt:
- platform/mac/tables/mozilla/marvin/table_row_align_left-expected.txt:
- platform/mac/tables/mozilla/marvin/table_row_align_right-expected.txt:
- platform/mac/tables/mozilla/marvin/table_rules_groups-expected.txt:
- platform/mac/tables/mozilla/marvin/tables_bgcolor_aqua-expected.txt:
- platform/mac/tables/mozilla/marvin/tables_bgcolor_aqua_rgb-expected.txt:
- platform/mac/tables/mozilla/marvin/tables_bgcolor_black-expected.txt:
- platform/mac/tables/mozilla/marvin/tables_bgcolor_black_rgb-expected.txt:
- platform/mac/tables/mozilla/marvin/tables_bgcolor_blue-expected.txt:
- platform/mac/tables/mozilla/marvin/tables_bgcolor_blue_rgb-expected.txt:
- platform/mac/tables/mozilla/marvin/tables_bgcolor_fuchsia-expected.txt:
- platform/mac/tables/mozilla/marvin/tables_bgcolor_fuchsia_rgb-expected.txt:
- platform/mac/tables/mozilla/marvin/tables_bgcolor_gray-expected.txt:
- platform/mac/tables/mozilla/marvin/tables_bgcolor_gray_rgb-expected.txt:
- platform/mac/tables/mozilla/marvin/tables_bgcolor_green-expected.txt:
- platform/mac/tables/mozilla/marvin/tables_bgcolor_green_rgb-expected.txt:
- platform/mac/tables/mozilla/marvin/tables_bgcolor_lime-expected.txt:
- platform/mac/tables/mozilla/marvin/tables_bgcolor_lime_rgb-expected.txt:
- platform/mac/tables/mozilla/marvin/tables_bgcolor_maroon-expected.txt:
- platform/mac/tables/mozilla/marvin/tables_bgcolor_maroon_rgb-expected.txt:
- platform/mac/tables/mozilla/marvin/tables_bgcolor_navy-expected.txt:
- platform/mac/tables/mozilla/marvin/tables_bgcolor_navy_rgb-expected.txt:
- platform/mac/tables/mozilla/marvin/tables_bgcolor_olive-expected.txt:
- platform/mac/tables/mozilla/marvin/tables_bgcolor_olive_rgb-expected.txt:
- platform/mac/tables/mozilla/marvin/tables_bgcolor_purple-expected.txt:
- platform/mac/tables/mozilla/marvin/tables_bgcolor_purple_rgb-expected.txt:
- platform/mac/tables/mozilla/marvin/tables_bgcolor_red-expected.txt:
- platform/mac/tables/mozilla/marvin/tables_bgcolor_red_rgb-expected.txt:
- platform/mac/tables/mozilla/marvin/tables_bgcolor_silver-expected.txt:
- platform/mac/tables/mozilla/marvin/tables_bgcolor_silver_rgb-expected.txt:
- platform/mac/tables/mozilla/marvin/tables_bgcolor_teal-expected.txt:
- platform/mac/tables/mozilla/marvin/tables_bgcolor_teal_rgb-expected.txt:
- platform/mac/tables/mozilla/marvin/tables_bgcolor_white-expected.txt:
- platform/mac/tables/mozilla/marvin/tables_bgcolor_white_rgb-expected.txt:
- platform/mac/tables/mozilla/marvin/tables_bgcolor_yellow-expected.txt:
- platform/mac/tables/mozilla/marvin/tables_bgcolor_yellow_rgb-expected.txt:
- platform/mac/tables/mozilla/marvin/tables_cellpadding_pct-expected.txt:
- platform/mac/tables/mozilla/marvin/tables_td_width-expected.txt:
- platform/mac/tables/mozilla/marvin/tables_th_width-expected.txt:
- platform/mac/tables/mozilla/marvin/tables_width_percent-expected.txt:
- platform/mac/tables/mozilla/marvin/tables_width_px-expected.txt:
- platform/mac/tables/mozilla/marvin/tbody_valign_baseline-expected.txt:
- platform/mac/tables/mozilla/marvin/tbody_valign_bottom-expected.txt:
- platform/mac/tables/mozilla/marvin/tbody_valign_middle-expected.txt:
- platform/mac/tables/mozilla/marvin/tbody_valign_top-expected.txt:
- platform/mac/tables/mozilla/marvin/td_valign_baseline-expected.txt:
- platform/mac/tables/mozilla/marvin/td_valign_bottom-expected.txt:
- platform/mac/tables/mozilla/marvin/td_valign_middle-expected.txt:
- platform/mac/tables/mozilla/marvin/td_valign_top-expected.txt:
- platform/mac/tables/mozilla/marvin/tfoot_valign_baseline-expected.txt:
- platform/mac/tables/mozilla/marvin/tfoot_valign_bottom-expected.txt:
- platform/mac/tables/mozilla/marvin/tfoot_valign_middle-expected.txt:
- platform/mac/tables/mozilla/marvin/tfoot_valign_top-expected.txt:
- platform/mac/tables/mozilla/marvin/th_valign_baseline-expected.txt:
- platform/mac/tables/mozilla/marvin/th_valign_bottom-expected.txt:
- platform/mac/tables/mozilla/marvin/th_valign_middle-expected.txt:
- platform/mac/tables/mozilla/marvin/th_valign_top-expected.txt:
- platform/mac/tables/mozilla/marvin/thead_valign_baseline-expected.txt:
- platform/mac/tables/mozilla/marvin/thead_valign_bottom-expected.txt:
- platform/mac/tables/mozilla/marvin/thead_valign_middle-expected.txt:
- platform/mac/tables/mozilla/marvin/thead_valign_top-expected.txt:
- platform/mac/tables/mozilla/marvin/tr_bgcolor_aqua_rgb-expected.txt:
- platform/mac/tables/mozilla/marvin/tr_bgcolor_black-expected.txt:
- platform/mac/tables/mozilla/marvin/tr_bgcolor_black_rgb-expected.txt:
- platform/mac/tables/mozilla/marvin/tr_bgcolor_blue-expected.txt:
- platform/mac/tables/mozilla/marvin/tr_bgcolor_blue_rgb-expected.txt:
- platform/mac/tables/mozilla/marvin/tr_bgcolor_fuchsia-expected.txt:
- platform/mac/tables/mozilla/marvin/tr_bgcolor_fuchsia_rgb-expected.txt:
- platform/mac/tables/mozilla/marvin/tr_bgcolor_gray-expected.txt:
- platform/mac/tables/mozilla/marvin/tr_bgcolor_gray_rgb-expected.txt:
- platform/mac/tables/mozilla/marvin/tr_bgcolor_green-expected.txt:
- platform/mac/tables/mozilla/marvin/tr_bgcolor_green_rgb-expected.txt:
- platform/mac/tables/mozilla/marvin/tr_bgcolor_lime-expected.txt:
- platform/mac/tables/mozilla/marvin/tr_bgcolor_lime_rgb-expected.txt:
- platform/mac/tables/mozilla/marvin/tr_bgcolor_maroon-expected.txt:
- platform/mac/tables/mozilla/marvin/tr_bgcolor_maroon_rgb-expected.txt:
- platform/mac/tables/mozilla/marvin/tr_bgcolor_navy-expected.txt:
- platform/mac/tables/mozilla/marvin/tr_bgcolor_navy_rgb-expected.txt:
- platform/mac/tables/mozilla/marvin/tr_bgcolor_olive-expected.txt:
- platform/mac/tables/mozilla/marvin/tr_bgcolor_olive_rgb-expected.txt:
- platform/mac/tables/mozilla/marvin/tr_bgcolor_purple-expected.txt:
- platform/mac/tables/mozilla/marvin/tr_bgcolor_purple_rgb-expected.txt:
- platform/mac/tables/mozilla/marvin/tr_bgcolor_red-expected.txt:
- platform/mac/tables/mozilla/marvin/tr_bgcolor_red_rgb-expected.txt:
- platform/mac/tables/mozilla/marvin/tr_bgcolor_silver-expected.txt:
- platform/mac/tables/mozilla/marvin/tr_bgcolor_silver_rgb-expected.txt:
- platform/mac/tables/mozilla/marvin/tr_bgcolor_teal-expected.txt:
- platform/mac/tables/mozilla/marvin/tr_bgcolor_teal_rgb-expected.txt:
- platform/mac/tables/mozilla/marvin/tr_bgcolor_white-expected.txt:
- platform/mac/tables/mozilla/marvin/tr_bgcolor_white_rgb-expected.txt:
- platform/mac/tables/mozilla/marvin/tr_bgcolor_yellow-expected.txt:
- platform/mac/tables/mozilla/marvin/tr_bgcolor_yellow_rgb-expected.txt:
- platform/mac/tables/mozilla/marvin/tr_valign_baseline-expected.txt:
- platform/mac/tables/mozilla/marvin/tr_valign_bottom-expected.txt:
- platform/mac/tables/mozilla/marvin/tr_valign_middle-expected.txt:
- platform/mac/tables/mozilla/marvin/tr_valign_top-expected.txt:
- platform/mac/tables/mozilla/marvin/x_col_align_char-expected.txt:
- platform/mac/tables/mozilla/marvin/x_col_span-expected.txt:
- platform/mac/tables/mozilla/marvin/x_col_valign_baseline-expected.txt:
- platform/mac/tables/mozilla/marvin/x_col_valign_bottom-expected.txt:
- platform/mac/tables/mozilla/marvin/x_col_valign_middle-expected.txt:
- platform/mac/tables/mozilla/marvin/x_col_valign_top-expected.txt:
- platform/mac/tables/mozilla/marvin/x_col_width_px-expected.txt:
- platform/mac/tables/mozilla/marvin/x_col_width_rel-expected.txt:
- platform/mac/tables/mozilla/marvin/x_colgroup_align_char-expected.txt:
- platform/mac/tables/mozilla/marvin/x_colgroup_span-expected.txt:
- platform/mac/tables/mozilla/marvin/x_colgroup_valign_baseline-expected.txt:
- platform/mac/tables/mozilla/marvin/x_colgroup_valign_bottom-expected.txt:
- platform/mac/tables/mozilla/marvin/x_colgroup_valign_middle-expected.txt:
- platform/mac/tables/mozilla/marvin/x_colgroup_valign_top-expected.txt:
- platform/mac/tables/mozilla/marvin/x_colgroup_width_rel-expected.txt:
- platform/mac/tables/mozilla/marvin/x_tbody_valign_baseline-expected.txt:
- platform/mac/tables/mozilla/marvin/x_tbody_valign_bottom-expected.txt:
- platform/mac/tables/mozilla/marvin/x_tbody_valign_middle-expected.txt:
- platform/mac/tables/mozilla/marvin/x_tbody_valign_top-expected.txt:
- platform/mac/tables/mozilla/marvin/x_td_align_center-expected.txt:
- platform/mac/tables/mozilla/marvin/x_td_align_char-expected.txt:
- platform/mac/tables/mozilla/marvin/x_td_align_justify-expected.txt:
- platform/mac/tables/mozilla/marvin/x_td_align_left-expected.txt:
- platform/mac/tables/mozilla/marvin/x_td_align_right-expected.txt:
- platform/mac/tables/mozilla/marvin/x_td_valign_baseline-expected.txt:
- platform/mac/tables/mozilla/marvin/x_td_valign_bottom-expected.txt:
- platform/mac/tables/mozilla/marvin/x_td_valign_middle-expected.txt:
- platform/mac/tables/mozilla/marvin/x_td_valign_top-expected.txt:
- platform/mac/tables/mozilla/marvin/x_td_width-expected.txt:
- platform/mac/tables/mozilla/marvin/x_tfoot_valign_baseline-expected.txt:
- platform/mac/tables/mozilla/marvin/x_tfoot_valign_bottom-expected.txt:
- platform/mac/tables/mozilla/marvin/x_tfoot_valign_middle-expected.txt:
- platform/mac/tables/mozilla/marvin/x_tfoot_valign_top-expected.txt:
- platform/mac/tables/mozilla/marvin/x_th_align_center-expected.txt:
- platform/mac/tables/mozilla/marvin/x_th_align_char-expected.txt:
- platform/mac/tables/mozilla/marvin/x_th_align_justify-expected.txt:
- platform/mac/tables/mozilla/marvin/x_th_align_left-expected.txt:
- platform/mac/tables/mozilla/marvin/x_th_align_right-expected.txt:
- platform/mac/tables/mozilla/marvin/x_th_rowspan-expected.txt:
- platform/mac/tables/mozilla/marvin/x_th_valign_baseline-expected.txt:
- platform/mac/tables/mozilla/marvin/x_th_valign_bottom-expected.txt:
- platform/mac/tables/mozilla/marvin/x_th_valign_middle-expected.txt:
- platform/mac/tables/mozilla/marvin/x_th_valign_top-expected.txt:
- platform/mac/tables/mozilla/marvin/x_th_width-expected.txt:
- platform/mac/tables/mozilla/marvin/x_thead_valign_baseline-expected.txt:
- platform/mac/tables/mozilla/marvin/x_thead_valign_bottom-expected.txt:
- platform/mac/tables/mozilla/marvin/x_thead_valign_middle-expected.txt:
- platform/mac/tables/mozilla/marvin/x_thead_valign_top-expected.txt:
- platform/mac/tables/mozilla/marvin/x_tr_align_char-expected.txt:
- platform/mac/tables/mozilla/marvin/x_tr_valign_baseline-expected.txt:
- platform/mac/tables/mozilla/marvin/x_tr_valign_bottom-expected.txt:
- platform/mac/tables/mozilla/marvin/x_tr_valign_middle-expected.txt:
- platform/mac/tables/mozilla/marvin/x_tr_valign_top-expected.txt:
- platform/mac/tables/mozilla/other/cell_widths-expected.txt:
- platform/mac/tables/mozilla/other/ms-expected.txt:
- platform/mac/tables/mozilla/other/nested2-expected.txt:
- platform/mac/tables/mozilla/other/nestedTables-expected.txt:
- platform/mac/tables/mozilla/other/slashlogo-expected.txt:
- platform/mac/tables/mozilla/other/test3-expected.txt:
- platform/mac/tables/mozilla/other/test6-expected.txt:
- platform/mac/tables/mozilla/other/wa_table_thtd_rowspan-expected.txt:
- platform/mac/tables/mozilla/other/wa_table_tr_align-expected.txt:
- platform/mac/tables/mozilla_expected_failures/bugs/97619-expected.txt:
- platform/mac/tables/mozilla_expected_failures/bugs/bug1010-expected.txt:
- platform/mac/tables/mozilla_expected_failures/bugs/bug1055-2-expected.txt:
- platform/mac/tables/mozilla_expected_failures/bugs/bug1128-expected.txt:
- platform/mac/tables/mozilla_expected_failures/bugs/bug1164-expected.txt:
- platform/mac/tables/mozilla_expected_failures/bugs/bug128876-expected.txt:
- platform/mac/tables/mozilla_expected_failures/bugs/bug14007-1-expected.txt:
- platform/mac/tables/mozilla_expected_failures/bugs/bug14007-2-expected.txt:
- platform/mac/tables/mozilla_expected_failures/bugs/bug1647-expected.txt:
- platform/mac/tables/mozilla_expected_failures/bugs/bug1725-expected.txt:
- platform/mac/tables/mozilla_expected_failures/bugs/bug17826-expected.txt:
- platform/mac/tables/mozilla_expected_failures/bugs/bug21518-expected.txt:
- platform/mac/tables/mozilla_expected_failures/bugs/bug22122-expected.txt:
- platform/mac/tables/mozilla_expected_failures/bugs/bug23847-expected.txt:
- platform/mac/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt:
- platform/mac/tables/mozilla_expected_failures/bugs/bug27993-2-expected.txt:
- platform/mac/tables/mozilla_expected_failures/bugs/bug29058-2-expected.txt:
- platform/mac/tables/mozilla_expected_failures/bugs/bug3105-expected.txt:
- platform/mac/tables/mozilla_expected_failures/bugs/bug56024-expected.txt:
- platform/mac/tables/mozilla_expected_failures/bugs/bug59252-expected.txt:
- platform/mac/tables/mozilla_expected_failures/bugs/bug7121-2-expected.txt:
- platform/mac/tables/mozilla_expected_failures/bugs/bug72393-expected.txt:
- platform/mac/tables/mozilla_expected_failures/bugs/bug7243-expected.txt:
- platform/mac/tables/mozilla_expected_failures/bugs/bug80762-2-expected.txt:
- platform/mac/tables/mozilla_expected_failures/bugs/bug8499-expected.txt:
- platform/mac/tables/mozilla_expected_failures/bugs/bug85016-expected.txt:
- platform/mac/tables/mozilla_expected_failures/bugs/bug89315-expected.txt:
- platform/mac/tables/mozilla_expected_failures/bugs/bug91057-expected.txt:
- platform/mac/tables/mozilla_expected_failures/bugs/bug9879-1-expected.txt:
- platform/mac/tables/mozilla_expected_failures/collapsing_borders/bug41262-1-expected.txt:
- platform/mac/tables/mozilla_expected_failures/core/captions1-expected.txt:
- platform/mac/tables/mozilla_expected_failures/core/captions2-expected.txt:
- platform/mac/tables/mozilla_expected_failures/core/col_span2-expected.txt:
- platform/mac/tables/mozilla_expected_failures/core/cols1-expected.txt:
- platform/mac/tables/mozilla_expected_failures/core/columns-expected.txt:
- platform/mac/tables/mozilla_expected_failures/core/standards1-expected.txt:
- platform/mac/tables/mozilla_expected_failures/dom/appendColGroup1-expected.txt:
- platform/mac/tables/mozilla_expected_failures/marvin/backgr_border-table-cell-expected.txt:
- platform/mac/tables/mozilla_expected_failures/marvin/backgr_border-table-column-expected.txt:
- platform/mac/tables/mozilla_expected_failures/marvin/backgr_border-table-column-group-expected.txt:
- platform/mac/tables/mozilla_expected_failures/marvin/backgr_border-table-expected.txt:
- platform/mac/tables/mozilla_expected_failures/marvin/backgr_border-table-quirks-expected.txt:
- platform/mac/tables/mozilla_expected_failures/marvin/backgr_border-table-row-expected.txt:
- platform/mac/tables/mozilla_expected_failures/marvin/backgr_border-table-row-group-expected.txt:
- platform/mac/tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.txt:
- platform/mac/tables/mozilla_expected_failures/marvin/backgr_layers-hide-expected.txt:
- platform/mac/tables/mozilla_expected_failures/marvin/backgr_layers-show-expected.txt:
- platform/mac/tables/mozilla_expected_failures/marvin/backgr_position-table-cell-expected.txt:
- platform/mac/tables/mozilla_expected_failures/marvin/backgr_position-table-column-expected.txt:
- platform/mac/tables/mozilla_expected_failures/marvin/backgr_position-table-column-group-expected.txt:
- platform/mac/tables/mozilla_expected_failures/marvin/backgr_position-table-row-expected.txt:
- platform/mac/tables/mozilla_expected_failures/marvin/backgr_position-table-row-group-expected.txt:
- platform/mac/tables/mozilla_expected_failures/marvin/table_overflow_caption-expected.txt:
- platform/mac/tables/mozilla_expected_failures/marvin/table_overflow_caption_bottom-expected.txt:
- platform/mac/tables/mozilla_expected_failures/marvin/table_overflow_caption_hidden-expected.txt:
- platform/mac/tables/mozilla_expected_failures/marvin/table_overflow_caption_hidden_table-expected.txt:
- platform/mac/tables/mozilla_expected_failures/marvin/table_overflow_caption_left-expected.txt:
- platform/mac/tables/mozilla_expected_failures/marvin/table_overflow_caption_right-expected.txt:
- platform/mac/tables/mozilla_expected_failures/marvin/table_overflow_caption_top-expected.txt:
- platform/mac/tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow-expected.txt:
- platform/mac/tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow_table-expected.txt:
- platform/mac/tables/mozilla_expected_failures/marvin/table_overflow_hidden_table-expected.txt:
- platform/mac/tables/mozilla_expected_failures/marvin/table_overflow_hidden_tbody-expected.txt:
- platform/mac/tables/mozilla_expected_failures/marvin/table_overflow_hidden_tr-expected.txt:
- platform/mac/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_cell-expected.txt:
- platform/mac/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_cell_sibling-expected.txt:
- platform/mac/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_row-expected.txt:
- platform/mac/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_row_sibling-expected.txt:
- platform/mac/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_table-expected.txt:
- platform/mac/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_table_caption-expected.txt:
- platform/mac/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_tbody-expected.txt:
- platform/mac/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_tbody_sibling-expected.txt:
- platform/mac/tables/mozilla_expected_failures/marvin/table_overflow_td_align_right-expected.txt:
- platform/mac/tables/mozilla_expected_failures/marvin/table_overflow_td_dynamic_deactivate-expected.txt:
- platform/mac/tables/mozilla_expected_failures/marvin/table_overflow_td_valign_bottom-expected.txt:
- platform/mac/tables/mozilla_expected_failures/marvin/table_overflow_td_valign_middle-expected.txt:
- platform/mac/tables/mozilla_expected_failures/marvin/table_overflow_td_valign_top-expected.txt:
- platform/mac/tables/mozilla_expected_failures/marvin/tables_cellspacing_pct-expected.txt:
- platform/mac/tables/mozilla_expected_failures/other/empty_cells-expected.txt:
- platform/mac/tables/mozilla_expected_failures/other/test4-expected.txt:
- 8:30 AM Changeset in webkit [195739] by
-
- 1 edit in branches/safari-601-branch/Source/JavaScriptCore/dfg/DFGPutStackSinkingPhase.cpp
Apply custom patch for rdar://problem/24209116
- 8:26 AM Changeset in webkit [195738] by
-
- 4 edits in branches/safari-601-branch/Source/WebCore
Cherry-pick r195592 and parts of r194672 to fix rdar://24154288
- 8:18 AM Changeset in webkit [195737] by
-
- 5 edits in trunk/Tools
[webkitdirs] Don't pass cmakeBasedPortName around.
https://bugs.webkit.org/show_bug.cgi?id=153589
Patch by Konstantin Tokarev <Konstantin Tokarev> on 2016-01-28
Reviewed by Darin Adler.
It should be local function of webkitdirs.pm instead.
- Scripts/build-jsc: Don't pass cmakeBasedPortName to
buildCMakeProjectOrExit().
- Scripts/build-webkit: Don't pass cmakeBasedPortName to
buildCMakeProjectOrExit() and generateBuildSystemFromCMakeProject().
- Scripts/run-efl-tests: Don't pass cmakeBasedPortName to
generateBuildSystemFromCMakeProject().
- Scripts/webkitdirs.pm: Don't export cmakeBasedPortName.
(generateBuildSystemFromCMakeProject): Removed $port argument as we
can get it from cmakeBasedPortName().
(buildCMakeProjectOrExit): Ditto.
- 7:16 AM Changeset in webkit [195736] by
-
- 5 edits in trunk
[GStreamer] Clean up includes and headers related with GStreamerGL
https://bugs.webkit.org/show_bug.cgi?id=153590
Reviewed by Philippe Normand.
Source/WebCore:
Remove gstglmemory from the including list and reorder includes to
organize GSTREAMER_GL related headers. It violates style rules of the
include order, but there is no clean way to include gst/gl/gl.h
without violating it.
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.h:
Tools:
- Scripts/webkitpy/style/checker.py: Skips
include_order check for MediaPlayerPrivateGStreamerBase.cpp
Removes VideoSinkGStreamer1.cpp which doesn't exist anymore.
- 1:06 AM Changeset in webkit [195735] by
-
- 4 edits in trunk/Source/WebCore
[GStreamer] MediaPlayerPrivateGStreamerBase::handleSyncMessage leaks GstContext
https://bugs.webkit.org/show_bug.cgi?id=153580
Reviewed by Philippe Normand.
When we creates GstContext using gst_context_new it increases refcount itself.
And the refcount of GstContext is increased when it is passed to
gst_element_set_context, also. Therefore We should unref GstContext after
using it to prevent GstContext leaks.
- platform/graphics/gstreamer/GRefPtrGStreamer.cpp:
(WTF::adoptGRef): Added for GstContext.
(WTF::refGPtr<GstContext>): Ditto
(WTF::derefGPtr<GstContext>): Ditto
- platform/graphics/gstreamer/GRefPtrGStreamer.h:
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:
(WebCore::MediaPlayerPrivateGStreamerBase::handleSyncMessage):
Use GRefPtr<GstContext> to handle currect refcounting
- 12:52 AM Changeset in webkit [195734] by
-
- 2 edits in trunk/Source/JavaScriptCore
[JSC] B3 Tail Call with Varargs do not restore callee saved registers
https://bugs.webkit.org/show_bug.cgi?id=153579
Patch by Benjamin Poulain <bpoulain@apple.com> on 2016-01-28
Reviewed by Michael Saboff.
We were trashing the callee saved registers in Tail Calls.
I just copied the code from DFG to fix this :)
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::DFG::LowerDFGToLLVM::compileCallOrConstructVarargs):
Jan 27, 2016:
- 10:46 PM Changeset in webkit [195733] by
-
- 4 edits in trunk/Source
Source/WebCore:
Fix clean CMake build after r195711.
- PlatformWin.cmake:
Copy forwarding headers from the new directory to find ContentSecurityPolicy.h.
This should fix EWS issues like the one seen in bug 153573.
Source/WebKit2:
Fix CMake build after r195722.
- PlatformMac.cmake:
Include new file.
- 10:45 PM Changeset in webkit [195732] by
-
- 2 edits in trunk/Source/WebKit2
Fix other builds.
- Configurations/WebKit.xcconfig:
- 10:23 PM Changeset in webkit [195731] by
-
- 12 edits in trunk
Expose ValidityState on the global Window object
https://bugs.webkit.org/show_bug.cgi?id=153582
Reviewed by Antti Koivisto.
LayoutTests/imported/w3c:
Rebaseline W3C html test now that more checks are passing.
- web-platform-tests/html/dom/interfaces-expected.txt:
Source/WebCore:
Expose ValidityState on the global Window object:
https://html.spec.whatwg.org/#validitystate
Firefox and Chrome match the specification.
No new tests, already covered by existing tests.
- html/ValidityState.idl:
LayoutTests:
Rebaseline test now that ValidityState is exposed on the global Window
object.
- js/dom/global-constructors-attributes-expected.txt:
- platform/efl/js/dom/global-constructors-attributes-expected.txt:
- platform/gtk/js/dom/global-constructors-attributes-expected.txt:
- platform/mac-mavericks/js/dom/global-constructors-attributes-expected.txt:
- platform/mac-yosemite/js/dom/global-constructors-attributes-expected.txt:
- platform/mac/js/dom/global-constructors-attributes-expected.txt:
- platform/win/js/dom/global-constructors-attributes-expected.txt:
- 10:00 PM Changeset in webkit [195730] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Don't show hand cursor for edited attribute
https://bugs.webkit.org/show_bug.cgi?id=152211
<rdar://problem/23870523>
Reviewed by Joseph Pecoraro.
- UserInterface/Views/Editing.css:
(.editing, .editing *):
- 9:33 PM Changeset in webkit [195729] by
-
- 13 edits in trunk
Expose ApplicationCache on the global Window object
https://bugs.webkit.org/show_bug.cgi?id=153578
Reviewed by Antti Koivisto.
LayoutTests/imported/w3c:
Rebaseline W3C HTML test now that more checks are passing.
- web-platform-tests/html/dom/interfaces-expected.txt:
Source/WebCore:
Expose ApplicationCache on the global Window object as per:
https://html.spec.whatwg.org/#the-storage-interface
Chrome follows the spec.
No new tests, already covered by existing test.
- loader/appcache/DOMApplicationCache.idl:
LayoutTests:
Rebaseline test now that ApplicationCache is exposed on the global
Window object.
- js/dom/global-constructors-attributes-expected.txt:
- platform/efl/js/dom/global-constructors-attributes-expected.txt:
- platform/gtk/js/dom/global-constructors-attributes-expected.txt:
- platform/mac-mavericks/js/dom/global-constructors-attributes-expected.txt:
- platform/mac-yosemite/js/dom/global-constructors-attributes-expected.txt:
- platform/mac/js/dom/global-constructors-attributes-expected.txt:
- platform/win/js/dom/global-constructors-attributes-expected.txt:
- 9:21 PM Changeset in webkit [195728] by
-
- 3 edits in trunk/Source/JavaScriptCore
B3 IntRange analysis should know more about shifting
https://bugs.webkit.org/show_bug.cgi?id=153568
Reviewed by Benjamin Poulain.
This teaches the IntRange analysis that the result of a right shift is usually better than
the worst-case mask based on the shift amount. In fact, you can reach useful conclusions
from looking at the IntRange of the input. This helps because Octane/crypto does something
like:
CheckMul((@x & $268435455) >> 14, @y >> 14, ...)
If you consider just the shifts, then this may overflow. But if you consider that @x is
first masked, then the IntRange coming out of the first shift is tight enough to prove that
the CheckMul cannot overflow.
- b3/B3ReduceStrength.cpp:
- b3/testb3.cpp:
- 8:42 PM Changeset in webkit [195727] by
-
- 3 edits2 adds in trunk
REGRESSION(r190430): Assertion failure in Text::~Text()
https://bugs.webkit.org/show_bug.cgi?id=153577
Reviewed by Antti Koivisto.
Source/WebCore:
The bug was caused by destroyRenderTreeIfNeeded exiting early on all HTMLSlotElement as it lacks a render object.
Fixed it by explicitly avoiding the early return when child is a HTMLSlotElement.
Test: fast/shadow-dom/slot-removal-crash-2.html
- dom/ContainerNode.cpp:
(WebCore::destroyRenderTreeIfNeeded):
LayoutTests:
Added a regression test. The test hits an assertion in debug build without the fix.
- fast/shadow-dom/slot-removal-crash-2-expected.txt: Added.
- fast/shadow-dom/slot-removal-crash-2.html: Added.
- 7:33 PM Changeset in webkit [195726] by
-
- 2 edits in trunk/Source/WebKit2
Fix build.
- Configurations/WebKit.xcconfig:
- 6:28 PM Changeset in webkit [195725] by
-
- 4 edits in trunk
[EFL] Remove unused accessibility related code
https://bugs.webkit.org/show_bug.cgi?id=153543
Reviewed by Darin Adler.
Source/WebKit2:
Do not need to load external library to expose WebKit's
accessibility tree. There have been changes in EFL/Elementary
in terms of support of accessibility and we should follow those.
- WebProcess/efl/WebProcessMainEfl.cpp:
(eailLibraryPath): Deleted.
(eail): Deleted.
Tools:
Removed reference to EAIL library.
It not going to be support anymore. There have been changes in
EFL/Elementary in terms of the accessibility and we should
follow those.
- efl/jhbuild-optional.modules:
- 6:21 PM Changeset in webkit [195724] by
-
- 3 edits4 adds in trunk
Garbage is displayed when root svg element has mix-blend-mode set
https://bugs.webkit.org/show_bug.cgi?id=150556
Patch by Said Abou-Hallawa <sabouhallawa@apple.com> on 2016-01-27
Reviewed by Darin Adler.
Source/WebCore:
This bug happens when compositing on a CALayer and drawing on a transparent
layer, so it happens with WK2 with <svg style="mix-blend-mode...">. And it
can happen with WK1 also with <svg style="opacity=...;mix-blend-mode...">.
But in both cases, the SVG root renderer should be the root of the render
tree. So it happens only with the stand alone SVG documents.
SVGRenderContext::prepareToRenderSVGContent() ignores the opacity of
the SVG root but it creates a transparent layer for the blend-mode.
But RenderLayer::beginTransparencyLayers() creates a transparent layer
for opacity and it sets the blend-mode also.
The fix is to begin two transparent layers for the SVG root renderer: one
for the opacity and the second for the blend-mode. The opacity transparent
layer will be still managed by RenderLayer::beginTransparencyLayers(). While
the blend-mode transparent layer will be managed by SVGRenderContext
::prepareToRenderSVGContent().
Tests: svg/css/mix-blend-mode-background-root.svg
svg/css/mix-blend-mode-opacity-root.svg
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::beginTransparencyLayers):
LayoutTests:
Ensure blending the SVG root renderer will be displayed correctly with
compositing when the SVG root renderer is the root of the render tree.
- svg/css/mix-blend-mode-background-root-expected.svg: Added.
- svg/css/mix-blend-mode-background-root.svg: Added.
- svg/css/mix-blend-mode-opacity-root-expected.svg: Added.
- svg/css/mix-blend-mode-opacity-root.svg: Added.
- 6:14 PM Changeset in webkit [195723] by
-
- 3 edits in trunk/Source/WebInspectorUI
CodeMirror will strip out "\r" from files with "\r\n" as newlines causing our offsets into the file to be incorrect
https://bugs.webkit.org/show_bug.cgi?id=153529
<rdar://problem/24376799>
Reviewed by Timothy Hatcher.
This problem manifested in the type token annotator inserting
tokens in the wrong places. Because our offsets are computed
based on the resource we get from backend, CodeMirror changing
the source text will cause all of our offsets to be incorrect.
- UserInterface/Views/CodeMirrorEditor.js:
(WebInspector.CodeMirrorEditor.create):
(WebInspector.CodeMirrorEditor):
- UserInterface/Views/TextEditor.js:
(WebInspector.TextEditor.set string.update):
(WebInspector.TextEditor.prototype.set string):
- 5:36 PM Changeset in webkit [195722] by
-
- 20 edits2 adds in trunk/Source
Cache results of data detection in the UI process when load completes.
https://bugs.webkit.org/show_bug.cgi?id=153560
Reviewed by Tim Horton.
Source/WebCore:
Adding new FrameLoaderClient method to notify that data
detection is complete and provide the results.
- loader/EmptyClients.h:
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::checkLoadCompleteForThisFrame):
- loader/FrameLoaderClient.h:
Source/WebKit/mac:
Adding empty implementation for WK1.
- WebCoreSupport/WebFrameLoaderClient.h:
- WebCoreSupport/WebFrameLoaderClient.mm:
(WebFrameLoaderClient::dispatchDidFinishDataDetection):
Source/WebKit2:
This patch changes when the results of data detections are sent to the
UIProcess. Before this change, they were only provided as part of
InteractionInformationAtPosition, which is populated when long press
gesture is triggered.
We need to have the results available if the client wants to allow navigation
to a data detector link, in order to allow them to retrieve the full url.
With this change, we now send the results as soon as they are computed
and keep them in the WebPageProxy object so that they can be fetched when
necessary from a WKWebView private interface.
- Shared/Cocoa/DataDetectionResult.h: Added.
- Shared/Cocoa/DataDetectionResult.mm: Added.
(WebKit::DataDetectionResult::encode):
(WebKit::DataDetectionResult::decode):
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _snapshotLayerContentsForBackForwardListItem:]):
(-[WKWebView _dataDetectionResults]):
(-[WKWebView _didRelaunchProcess]):
- UIProcess/API/Cocoa/WKWebViewPrivate.h:
- UIProcess/Cocoa/WebPageProxyCocoa.mm:
(WebKit::WebPageProxy::setDataDetectionResult):
(WebKit::WebPageProxy::saveRecentSearches):
- UIProcess/WebPageProxy.h:
(WebKit::WebPageProxy::websiteDataStore):
(WebKit::WebPageProxy::dataDetectionResults):
(WebKit::WebPageProxy::scrollingCoordinatorProxy):
- UIProcess/WebPageProxy.messages.in:
- UIProcess/ios/WKContentViewInteraction.h:
- UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView ensurePositionInformationIsUpToDate:]):
(-[WKContentView _dataDetectionResults]):
(-[WKContentView gestureRecognizerShouldBegin:]):
- WebKit2.xcodeproj/project.pbxproj:
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::dispatchDidReceiveContentLength):
(WebKit::WebFrameLoaderClient::dispatchDidFinishDataDetection):
(WebKit::WebFrameLoaderClient::dispatchDidFinishLoading):
- WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences):
(WebKit::WebPage::setDataDetectionResults):
(WebKit::WebPage::willCommitLayerTree):
- WebProcess/WebPage/WebPage.h:
(WebKit::WebPage::shouldExtendIncrementalRenderingSuppression):
- 5:34 PM Changeset in webkit [195721] by
-
- 2 edits in branches/safari-601-branch/Source/WebCore
Merge r195609. rdar://problem/24337868
- 5:34 PM Changeset in webkit [195720] by
-
- 2 edits in branches/safari-601-branch/Source/WebCore
Merge r195606. rdar://problem/24242476
- 5:34 PM Changeset in webkit [195719] by
-
- 2 edits in branches/safari-601-branch/LayoutTests
Merge r195492. rdar://problem/24002217
- 5:34 PM Changeset in webkit [195718] by
-
- 6 edits8 adds in branches/safari-601-branch
Merge r195477. rdar://problem/24002217
- 5:34 PM Changeset in webkit [195717] by
-
- 4 edits4 adds in branches/safari-601-branch
Merge r195162. rdar://problem/24302736
- 5:34 PM Changeset in webkit [195716] by
-
- 6 edits in branches/safari-601-branch/Source/WebCore
Merge r195132. rdar://problem/24154292
- 5:34 PM Changeset in webkit [195715] by
-
- 5 edits15 adds in branches/safari-601-branch
Merge r195075. rdar://problem/24302727
- 5:34 PM Changeset in webkit [195714] by
-
- 10 edits in branches/safari-601-branch/Source
Merge r194559. rdar://problem/24269083
- 5:34 PM Changeset in webkit [195713] by
-
- 2 edits1 add in branches/safari-601-branch/Source/JavaScriptCore
Merge r193782. rdar://problem/24358367
- 5:14 PM Changeset in webkit [195712] by
-
- 2 edits in trunk/Source/WebKit2
Include the right WebKitAdditions files
https://bugs.webkit.org/show_bug.cgi?id=153572
Reviewed by Tim Horton.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::reattachToWebProcess):
- 5:08 PM Changeset in webkit [195711] by
-
- 7 edits2 moves1 add in trunk/Source
Move ContentSecurityPolicy.{cpp, h} to its own directory
https://bugs.webkit.org/show_bug.cgi?id=153527
<rdar://problem/24359892>
Reviewed by Sam Weinig.
Source/WebCore:
Move ContentSecurityPolicy.{cpp, h} from Source/WebCore/page to Source/WebCore/page/csp.
This will facilitate separating out the policy support classes (e.g. CSPDirectiveList)
into their own files to improve the hackability of this code.
- CMakeLists.txt:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
- page/csp/ContentSecurityPolicy.cpp: Renamed from Source/WebCore/page/ContentSecurityPolicy.cpp.
- page/csp/ContentSecurityPolicy.h: Renamed from Source/WebCore/page/ContentSecurityPolicy.h.
Source/WebKit2:
Add ${WEBCORE_DIR}/page/csp to the list of WebKit2 include directories.
- CMakeLists.txt:
- 4:38 PM Changeset in webkit [195710] by
-
- 6 edits15 copies in branches/safari-601.1.46-branch
Merged r195625. rdar://problem/24337780
- 4:37 PM Changeset in webkit [195709] by
-
- 4 edits in trunk
Modern IDB: Incorrect handling of iterating cursors to their end.
https://bugs.webkit.org/show_bug.cgi?id=153569
Reviewed by Alex Christensen.
Source/WebCore:
No new tests (3 tests now pass, others are closer to passing).
- Modules/indexeddb/server/SQLiteIDBCursor.cpp:
(WebCore::IDBServer::SQLiteIDBCursor::advance):
(WebCore::IDBServer::SQLiteIDBCursor::internalAdvanceOnce):
LayoutTests:
- platform/mac-wk1/TestExpectations:
- 4:32 PM Changeset in webkit [195708] by
-
- 1 edit3 adds in trunk/LayoutTests
Layout Test fast/forms/auto-fill-button/input-contacts-auto-fill-button.html is failing.
https://bugs.webkit.org/show_bug.cgi?id=153567.
Unreviewed test gardening.
Update expected test results for ios-simulator, win, and gtk.
Patch by Zhuo Li <zachli@apple.com> on 2016-01-27
- platform/gtk/fast/forms/auto-fill-button/input-contacts-auto-fill-button-expected.txt: Added.
- platform/ios-simulator/fast/forms/auto-fill-button/input-contacts-auto-fill-button-expected.txt: Added.
- platform/win/fast/forms/auto-fill-button/input-contacts-auto-fill-button-expected.txt: Added.
- 4:29 PM Changeset in webkit [195707] by
-
- 2 edits in trunk/Source/JavaScriptCore
[JSC] adjustFrameAndStackInOSRExitCompilerThunk() can trash values in FTL
https://bugs.webkit.org/show_bug.cgi?id=153536
Patch by Benjamin Poulain <bpoulain@apple.com> on 2016-01-27
Reviewed by Saam Barati.
Workaround to get B3 working on ARM.
- dfg/DFGOSRExitCompilerCommon.h:
(JSC::DFG::adjustFrameAndStackInOSRExitCompilerThunk):
The code was using the scratch registers in a few places.
I initially tried to make is not use scratch registers anywhere
but that looked super fragile.
Instead, I just preserve the scratch registers. That's easy and
it should be relatively cheap compared to everything done on OSR Exits.
- 4:18 PM Changeset in webkit [195706] by
-
- 4 edits in trunk/Source/WebInspectorUI
Web Inspector: Regression (r195303) - Changes to TreeOutline break styling of lists in Visual sidebar
https://bugs.webkit.org/show_bug.cgi?id=153563
Patch by Devin Rousso <Devin Rousso> on 2016-01-27
Reviewed by Timothy Hatcher.
Removed duplicate properties and used new methods of TreeOutline to achieve
the desired styling effects.
- UserInterface/Views/VisualStyleCommaSeparatedKeywordEditor.css:
(.visual-style-property-container.comma-separated-keyword-editor > .visual-style-property-value-container > .visual-style-comma-separated-keyword-list > .visual-style-comma-separated-keyword-item.visual-style-font-family-list-item > .visual-style-comma-separated-keyword-item-editor):
(.visual-style-property-container.comma-separated-keyword-editor > .visual-style-property-value-container > .visual-style-comma-separated-keyword-list > .visual-style-comma-separated-keyword-item > .titles): Deleted.
- UserInterface/Views/VisualStyleSelectorSection.js:
(WebInspector.VisualStyleSelectorSection):
- UserInterface/Views/VisualStyleSelectorTreeItem.css:
(.item.visual-style-selector-item > .icon):
(.item.visual-style-selector-item > .titles):
(.item.visual-style-selector-item > .titles > .subtitle):
(.item.visual-style-selector-item.selected > .titles > .subtitle):
(.item.visual-style-selector-item > .titles > .subtitle::before): Deleted.
- 4:17 PM Changeset in webkit [195705] by
-
- 4 edits in trunk/Source/WebCore
AX: Crash in AccessibilityTableColumn::headerObject
https://bugs.webkit.org/show_bug.cgi?id=153553
<rdar://problem/23196278>
Reviewed by Chris Fleizach.
Webkit was crashing sometimes when we asked for column headers of a table.
The columns vector of the table was reset during the iteration when we
were asking for the headerObject of each column. The column's addChildren()
function calls elementRect() for each child cell and that sometimes causes
the parent table to reset its children.
Fixed it by caching the columns vector and moving out the elementRect() logic
from AccessibilityTalbeColumn::addChildren().
- accessibility/AccessibilityTable.cpp:
(WebCore::AccessibilityTable::columnHeaders):
(WebCore::AccessibilityTable::rowHeaders):
- accessibility/AccessibilityTableColumn.cpp:
(WebCore::AccessibilityTableColumn::elementRect):
(WebCore::AccessibilityTableColumn::headerObject):
(WebCore::AccessibilityTableColumn::addChildren):
- accessibility/AccessibilityTableColumn.h:
- 4:16 PM Changeset in webkit [195704] by
-
- 3 edits8 deletes in trunk
Remove WebKitSystemInterface for iOS SDK < 9
https://bugs.webkit.org/show_bug.cgi?id=153570
Reviewed by Andy Estes.
Tools:
- Scripts/copy-webkitlibraries-to-product-directory:
WebKitLibraries:
We no longer support building for iOS < 9.
- libWebKitSystemInterfaceIOSDevice8.1.a: Removed.
- libWebKitSystemInterfaceIOSDevice8.2.a: Removed.
- libWebKitSystemInterfaceIOSDevice8.3.a: Removed.
- libWebKitSystemInterfaceIOSDevice8.4.a: Removed.
- libWebKitSystemInterfaceIOSSimulator8.1.a: Removed.
- libWebKitSystemInterfaceIOSSimulator8.2.a: Removed.
- libWebKitSystemInterfaceIOSSimulator8.3.a: Removed.
- libWebKitSystemInterfaceIOSSimulator8.4.a: Removed.
- 4:02 PM Changeset in webkit [195703] by
-
- 3 edits2 copies in branches/safari-601.1.46-branch
Merged r195671. rdar://problem/24302956
- 3:55 PM Changeset in webkit [195702] by
-
- 5 edits in branches/safari-601.1.46-branch/Source/WebKit2
Merged r195651. rdar://problem/24302943
- 3:45 PM Changeset in webkit [195701] by
-
- 2 edits in trunk/Source/JavaScriptCore
[mips] Use reinterpret_cast_ptr to suppress alignment warnings.
https://bugs.webkit.org/show_bug.cgi?id=153424
Patch by Konstantin Tokarev <Konstantin Tokarev> on 2016-01-27
Reviewed by Darin Adler.
- runtime/JSGenericTypedArrayView.h:
(JSC::JSGenericTypedArrayView::sortFloat):
- 3:42 PM Changeset in webkit [195700] by
-
- 25 edits in trunk
Settings a reflected DOMString attribute to null should set it to the "null" string rather than the empty string
https://bugs.webkit.org/show_bug.cgi?id=153504
<rdar://problem/24353072>
Reviewed by Ryosuke Niwa.
Source/WebCore:
Settings a reflected DOMString attribute to null should set it to the "null"
string rather than the empty string:
- https://html.spec.whatwg.org/#reflecting-content-attributes-in-idl-attributes
- http://heycam.github.io/webidl/#es-DOMString
- http://people.mozilla.org/~jorendorff/es6-draft.html#sec-tostring
Firefox and Chrome match the specification here.
This is causing a lot of W3C HTML reflection tests to fail on WebKit, e.g.:
No new tests, already covered by existing tests.
- bindings/scripts/CodeGeneratorJS.pm:
(JSValueToNative):
Call toString() instead of valueToStringWithNullCheck() for reflected
attributes. This way, null gets converted to the string "null", as
expected, instead of a null String object.
- html/HTMLInputElement.idl:
Dropping [TreatNullAs=NullString] IDL extended attribute for
input.defaultValue, as this is not present in the specification:
Without this change, assigning null to input.defaultValue would not
set to to the "null" string, as is expected.
- html/HTMLTextAreaElement.idl:
Dropping [TreatNullAs=NullString] IDL extended attribute for
textArea.defaultValue, as this is not present in the specification:
Without this change, assigning null to textArea.defaultValue would not
set to to the "null" string, as is expected.
- html/HTMLTitleElement.idl:
Dropping [TreatNullAs=NullString] IDL extended attribute for
title.text, as this is not present in the specification:
Without this change, assigning null to title.text would not
set to to the "null" string, as is expected.
LayoutTests:
Update existing tests as a lot of them were expecting that setting
a reflected DOMString attribute to null would set it to the empty
string instead of the string "null".
- fast/dom/domstring-attribute-reflection-expected.txt:
- fast/dom/domstring-attribute-reflection.html:
- fast/dom/element-attribute-js-null-expected.txt:
- fast/dom/element-attribute-js-null.html:
- fast/dom/ping-attribute-dom-binding-expected.txt:
- fast/dom/ping-attribute-dom-binding.html:
- fast/forms/fieldset/fieldset-name-expected.txt:
- fast/forms/fieldset/fieldset-name.html:
- fast/forms/input-minmax-expected.txt:
- fast/forms/input-minmax.html:
- fast/forms/input-pattern-expected.txt:
- fast/forms/input-pattern.html:
- fast/forms/submit-form-attributes-expected.txt:
- fast/forms/submit-form-attributes.html:
- fast/shadow-dom/HTMLSlotElement-interface.html:
- fast/shadow-dom/NonDocumentTypeChildNode-interface-assignedSlot.html:
- fast/shadow-dom/shadow-layout-after-slot-changes.html:
- svg/dom/svg-element-attribute-js-null-expected.txt:
- svg/dom/svg-element-attribute-js-null.xhtml:
- 3:31 PM Changeset in webkit [195699] by
-
- 13 edits3 adds in trunk
Support CSS3 Images values for the image-rendering property
https://bugs.webkit.org/show_bug.cgi?id=153556
Reviewed by Dean Jackson.
Source/WebCore:
CSS3 Images has the following values for image-rendering:
auto, crisp-edges, pixelated
The old code supported:
optimizeSpeed, optimizeQuality, -webkit-crisp-edges, -webkit-optimize-contrast
Add support for the new values without prefixes. Map -webkit-crisp-edges to crisp-edges,
and -webkit-optimize-contrast to crisp-edges. Support pixelated which behaves like
crisp-edges (a low quality scale).
The spec says that optimizeQuality should behave like 'auto', but that would be
a behavior change since ImageQualityController::shouldPaintAtLowQuality() currently
uses it as a trigger to avoid low quality scaling, so don't change that for now.
No new tests, covered by fast/css/script-tests/image-rendering-parsing.js
- css/CSSParser.cpp:
(WebCore::isValidKeywordPropertyAndValue):
- css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator EImageRendering):
- css/CSSValueKeywords.in:
- rendering/ImageQualityController.cpp:
(WebCore::ImageQualityController::shouldPaintAtLowQuality):
- rendering/RenderHTMLCanvas.cpp:
(WebCore::RenderHTMLCanvas::paintReplaced):
- rendering/style/RenderStyleConstants.h:
- rendering/style/StyleRareInheritedData.h: Need another bit.
Source/WebInspectorUI:
Add "crisp-edges", "pixelated" to the suggestions for image-rendering.
- UserInterface/Models/CSSKeywordCompletions.js:
LayoutTests:
Update for new values. Add a new SVG shape-rendering test which would have
detected a bug I caused with an earlier patch.
- fast/css/image-rendering-parsing-expected.txt:
- fast/css/script-tests/image-rendering-parsing.js:
- svg/css/script-tests/shape-rendering-parsing.js: Added.
- svg/css/shape-rendering-parsing.html: Added.
- 3:12 PM Changeset in webkit [195698] by
-
- 21 edits3 adds in trunk/Source
Add WebKitAdditions extension points to WebCore, WebKit and WebKitLegacy
https://bugs.webkit.org/show_bug.cgi?id=153550
Reviewed by Sam Weinig.
Source/WebCore:
- DerivedSources.make:
Add the ability for WebKitAdditions to add events and event targets.
- WebCore.xcodeproj/project.pbxproj:
Add new files.
- bindings/scripts/InFilesCompiler.pm:
(initializeFromCommandLine):
(compile):
Handle multiple --input parameters.
- dom/EventNames.h:
Handle adding more event names.
- loader/EmptyClients.cpp:
(WebCore::fillWithEmptyClients):
- page/MainFrame.cpp:
(WebCore::MainFrame::MainFrame):
- page/MainFrame.h:
- page/PageConfiguration.h:
Add extension points.
- platform/cocoa/WebKitAdditions.mm: Added.
Import additions.
Source/WebKit:
- WebKit.xcodeproj/project.pbxproj:
Add new files.
Source/WebKit/mac:
- Configurations/WebKitLegacy.xcconfig:
Add WKA header search paths.
- WebKitAdditions.mm: Added.
Add addition files.
- WebView/WebView.mm:
(-[WebView _commonInitializationWithFrameName:groupName:]):
(-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
Add extension points.
Source/WebKit2:
- DerivedSources.make:
Add the ability for WebKitAdditions to add new message receivers.
- Shared/Cocoa/WebKitAdditions.mm: Added.
Add addition files.
- Shared/WebCoreArgumentCoders.h:
Add extension points.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::reattachToWebProcess):
(WebKit::WebPageProxy::resetState):
Add extension points.
- UIProcess/WebPageProxy.h:
Add extension points.
- WebKit2.xcodeproj/project.pbxproj:
Add new files.
- WebProcess/WebPage/WebPage.cpp:
Add extension points.
- 3:03 PM Changeset in webkit [195697] by
-
- 6 edits in trunk
Modern IDB: Fix many Index tests.
https://bugs.webkit.org/show_bug.cgi?id=153561
Reviewed by Alex Christensen.
Source/WebCore:
No new tests (Many failing tests now pass).
- Modules/indexeddb/server/MemoryIndex.cpp:
(WebCore::IDBServer::MemoryIndex::getResultForKeyRange):
- Modules/indexeddb/server/SQLiteIDBBackingStore.cpp:
(WebCore::IDBServer::SQLiteIDBBackingStore::uncheckedPutIndexKey):
(WebCore::IDBServer::SQLiteIDBBackingStore::uncheckedPutIndexRecord):
(WebCore::IDBServer::SQLiteIDBBackingStore::getIndexRecord):
(WebCore::IDBServer::SQLiteIDBBackingStore::iterateCursor):
- Modules/indexeddb/server/SQLiteIDBCursor.h:
(WebCore::IDBServer::SQLiteIDBCursor::didComplete):
LayoutTests:
- platform/mac-wk1/TestExpectations:
- 2:57 PM Changeset in webkit [195696] by
-
- 6 edits in trunk
Modern IDB: Cursors are utterly broken in the SQLite backend.
https://bugs.webkit.org/show_bug.cgi?id=153558
Reviewed by Alex Christensen.
Source/WebCore:
No new tests (35 failures now pass, others improve).
- Fixes incorrect usage of Index cursors when ObjectStore cursors are intended.
- Improves the state of getting the cursor value vs. reaching the end of a cursor.
- Modules/indexeddb/server/SQLiteIDBBackingStore.cpp:
(WebCore::IDBServer::SQLiteIDBBackingStore::openCursor):
(WebCore::IDBServer::SQLiteIDBBackingStore::iterateCursor):
- Modules/indexeddb/server/SQLiteIDBCursor.cpp:
(WebCore::IDBServer::SQLiteIDBCursor::SQLiteIDBCursor):
(WebCore::IDBServer::SQLiteIDBCursor::currentData):
- Modules/indexeddb/server/SQLiteIDBCursor.h:
LayoutTests:
- platform/mac-wk1/TestExpectations:
- 2:40 PM Changeset in webkit [195695] by
-
- 27 edits1 move1 add1 delete in trunk
Getting / Setting property on prototype object must throw TypeError
https://bugs.webkit.org/show_bug.cgi?id=153547
<rdar://problem/24370650>
Reviewed by Ryosuke Niwa.
LayoutTests/imported/w3c:
Rebaseline several W3C tests now that more checks are passing.
- web-platform-tests/XMLHttpRequest/interfaces-expected.txt:
- web-platform-tests/dom/interfaces-expected.txt:
- web-platform-tests/html/dom/interfaces-expected.txt:
Source/WebCore:
Gettingi / Setting property on prototype object must throw TypeError as per
Web IDL specification:
http://heycam.github.io/webidl/#dfn-attribute-getter (Step 2.4.2)
http://heycam.github.io/webidl/#dfn-attribute-setter (Step 3.5)
Firefox and Chrome already throw a TypeError in this case, as per
the specification. However, WebKit was returning null and merely
logging a deprecation error message. This patch aligns our behavior
with other browsers and the specification.
This patch also adds support for the [LenientThis] IDL extended
attribute:
http://heycam.github.io/webidl/#LenientThis
For [LenientThis] attributes, we do not throw a TypeError if the
attribute getter / setter is called on an object which does not
implement the expected interface, as per:
http://heycam.github.io/webidl/#dfn-attribute-getter (Step 2.4.1)
http://heycam.github.io/webidl/#dfn-attribute-setter (Step 3.5)
No new tests, already covered by existing tests.
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateImplementation):
- bindings/scripts/IDLAttributes.txt:
Add support for [LenientThis]:
http://heycam.github.io/webidl/#LenientThis
- bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
- bindings/scripts/test/GObject/WebKitDOMTestObj.h:
- bindings/scripts/test/JS/JSTestEventConstructor.cpp:
- bindings/scripts/test/JS/JSTestInterface.cpp:
- bindings/scripts/test/JS/JSTestNode.cpp:
- bindings/scripts/test/JS/JSTestNondeterministic.cpp:
- bindings/scripts/test/JS/JSTestObj.cpp:
- bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:
- bindings/scripts/test/JS/JSTestTypedefs.cpp:
- bindings/scripts/test/JS/JSattribute.cpp:
- bindings/scripts/test/ObjC/DOMTestObj.h:
- bindings/scripts/test/ObjC/DOMTestObj.mm:
Rebaseline bindings tests.
- bindings/scripts/test/TestObj.idl:
Add coverage for [LenientThis] attributes.
- dom/Document.idl:
Mark 'onreadystatechange' as [LenientThis] as per the HTML
specification:
https://html.spec.whatwg.org/#document
- dom/GlobalEventHandlers.idl:
Mark 'onmouseeneter' / 'onmouseleave' as [LenientThis] as per the
HTML specification:
https://html.spec.whatwg.org/#globaleventhandlers
LayoutTests:
Update a few layout tests that were expecting getting a property on
the prototype object to return undefined instead of throwing.
- js/dom/dom-as-prototype-assignment-exception-expected.txt:
- js/dom/dom-attributes-on-mismatch-type-expected.txt:
- js/dom/dom-attributes-on-mismatch-type.html:
- js/dom/script-tests/dom-as-prototype-assignment-exception.js:
- 2:37 PM Changeset in webkit [195694] by
-
- 15 edits in trunk
window.atob() should ignore spaces in input
https://bugs.webkit.org/show_bug.cgi?id=153522
<rdar://problem/24357822>
Reviewed by Benjamin Poulain.
Source/WebCore:
window.atob() should ignore spaces in input as per:
Previously, WebKit would throw an exception and it was the only browser
to do so. Firefox and Chrome behavior according to the specification.
This was causing us to fail 10 checks in the following W3C HTML test:
http://w3c-test.org/html/webappapis/atob/base64.html
No new tests, updated existing test.
- page/DOMWindow.cpp:
(WebCore::DOMWindow::atob):
- page/Page.cpp:
(WebCore::Page::userStyleSheetLocationChanged):
- platform/network/DataURL.cpp:
(WebCore::handleDataURL):
- platform/network/DataURLDecoder.cpp:
(WebCore::DataURLDecoder::decodeBase64):
Source/WebKit/mac:
- WebCoreSupport/WebInspectorClient.mm:
(WebInspectorFrontendClient::save):
Source/WebKit2:
- UIProcess/mac/WebInspectorProxyMac.mm:
(WebKit::WebInspectorProxy::platformSave):
Source/WTF:
Turn Base64DecodePolicy enum into flags so that the caller can indicate
to both validate padding AND ignore spaces.
Also make sure that the output Vector size is properly shrunk when
spaces are ignored.
- wtf/text/Base64.cpp:
(WTF::base64DecodeInternal):
(WTF::base64Decode):
(WTF::base64URLDecode):
- wtf/text/Base64.h:
LayoutTests:
Update window.atob() test to cover cases with spaces in
input.
- fast/dom/Window/atob-btoa-expected.txt:
- fast/dom/Window/atob-btoa.html:
- 2:31 PM Changeset in webkit [195693] by
-
- 4 edits in trunk/Source/WebCore
Move some logic related to the presentation mode button from mediaControlsiOS.js to mediaControlsApple.js
https://bugs.webkit.org/show_bug.cgi?id=153476
Reviewed by Eric Carlson.
Also, add the necessary styles to support that control in mediaControlsApple.css.
- Modules/mediacontrols/mediaControlsApple.css:
(video::-webkit-media-controls-panel.picture-in-picture):
(audio::-webkit-media-controls-wireless-playback-status.picture-in-picture):
(audio::-webkit-media-controls-wireless-playback-text-top.picture-in-picture):
(audio::-webkit-media-controls-wireless-playback-text-bottom.picture-in-picture):
(video::-webkit-media-controls-panel .picture-in-picture-button):
Use the same mask image as iOS, but with a different size and a background color specified
(since there's another rule that makes buttons within the panel have a transparent
background color).
(video::-webkit-media-controls-panel .picture-in-picture-button.return-from-picture-in-picture):
- Modules/mediacontrols/mediaControlsApple.js:
(Controller.prototype.addVideoListeners):
(Controller.prototype.removeVideoListeners):
Listen for (and stop listening for) the webkitpresentationmodechanged event if presentation
mode is supported for this video element.
(Controller.prototype.createControls):
Add a class name to the pictureInPictureButton so we can query for it in the stylesheet.
(Controller.prototype.configureInlineControls):
Call updatePictureInPictureButton().
(Controller.prototype.presentationMode):
Moved from mediaControlsiOS.js.
(Controller.prototype.isFullScreen):
Ditto, with a bug fix to not call presentationMode(), since that method calls isFullScreen(),
resulting in infinite recursion.
(Controller.prototype.updatePictureInPictureButton):
Ditto.
(Controller.prototype.handlePresentationModeChange):
Ditto.
(Controller.prototype.handleFullscreenChange):
Call handlePresentationModeChanged() if presentation mode is supported for this video element.
(Controller.prototype.controlsAlwaysVisible):
Ditto.
(Controller.prototype.handlePictureInPictureButtonClicked):
Ditto.
- Modules/mediacontrols/mediaControlsiOS.js:
(ControllerIOS.prototype.handlePresentationModeChange):
Most logic has been moved to the same method in mediaControlsApple.js, except
updating the style of the panelContainer, which doesn't exist in the Mac controls.
(ControllerIOS.prototype.addVideoListeners): Deleted.
(ControllerIOS.prototype.removeVideoListeners): Deleted.
(ControllerIOS.prototype.presentationMode): Deleted.
(ControllerIOS.prototype.isFullScreen): Deleted.
(ControllerIOS.prototype.handlePictureInPictureButtonClicked): Deleted.
(ControllerIOS.prototype.updatePictureInPictureButton): Deleted.
(ControllerIOS.prototype.handleFullscreenChange): Deleted.
(ControllerIOS.prototype.controlsAlwaysVisible): Deleted.
Delete all code that's already handled in the Controller.
- 2:23 PM Changeset in webkit [195692] by
-
- 3 edits in trunk/Source/WebCore
Enable API related to the video fullscreen layer in MediaPlayerPrivateMediaSourceAVFObjC
also on Mac platform with video presentation mode support.
https://bugs.webkit.org/show_bug.cgi?id=153223
Reviewed by Jer Noble.
Reuse VideoFullscreenLayerManager to manage moving the video layer between the fullscreen
layer and the inline layer depending on the current presentation mode.
- platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.h:
- platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::MediaPlayerPrivateMediaSourceAVFObjC):
Create m_videoFullscreenLayerManager.
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::platformLayer):
Return the video inline layer from the VideoFullscreenLayerManager.
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::addDisplayLayer):
Call VideoFullscreenLayerManager::setVideoLayer() with the m_sampleBufferDisplayLayer.
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::removeDisplayLayer):
Call VideoFullscreenLayerManager::didDestroyVideoLayer().
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::setVideoFullscreenLayer):
Call VideoFullscreenLayerManager::setVideoFullscreenLayer().
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::setVideoFullscreenFrame):
Call VideoFullscreenLayerManager::setVideoFullscreenFrame().
- 2:08 PM Changeset in webkit [195691] by
-
- 2 edits in trunk/Source/JavaScriptCore
[FTL][Win64] Compile fix.
https://bugs.webkit.org/show_bug.cgi?id=153555
Reviewed by Alex Christensen.
MSVC does not accept preprocessor conditionals in macros.
- ftl/FTLOSRExitCompiler.cpp:
(JSC::FTL::compileStub):
- 2:04 PM Changeset in webkit [195690] by
-
- 3 edits in trunk/Tools
Fix bugs caused by incorrect usage of "branch" vs. "branchName". https://bugs.webkit.org/show_bug.cgi?id=153330
Reviewed by Daniel Bates.
In an earlier patch we started using the name "branch" to indicate a branch object, whereas
"branchName" implies that the variable or property in question is simply a string. We fixed some
inconsistencies regarding this issue in 152982 but further bugs and inconsistencies were recently
spotted in BuildbotQueueView.js.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
(BuildbotQueueView.prototype._popoverLinesForCommitRange): Change branchName to branch in method signature.
Changed branchName to branch.name in call to commitsOnBranch.
(BuildbotQueueView.prototype._presentPopoverForPendingCommits): Change branch.name to branch in call to
_popoverLinesForCommitRange.
(BuildbotQueueView.prototype._presentPopoverForRevisionRange): Changed context.branchName to context.branch.name.
(BuildbotQueueView.prototype._revisionContentWithPopoverForIteration): Changed branch.name to branch.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js: Added tests to verify
fix.
- 1:57 PM Changeset in webkit [195689] by
-
- 10 edits in trunk
Modern IDB: SQLite backend doesn't update index records as object records are added.
https://bugs.webkit.org/show_bug.cgi?id=153548
Reviewed by Alex Christensen.
Source/WebCore:
No new tests (4 more tests pass, others improve).
- Modules/indexeddb/server/IDBBackingStore.h:
- Modules/indexeddb/server/MemoryIDBBackingStore.cpp:
(WebCore::IDBServer::MemoryIDBBackingStore::addRecord):
- Modules/indexeddb/server/MemoryIDBBackingStore.h:
- Modules/indexeddb/server/SQLiteIDBBackingStore.cpp:
(WebCore::IDBServer::SQLiteIDBBackingStore::initializeVM):
(WebCore::IDBServer::SQLiteIDBBackingStore::vm):
(WebCore::IDBServer::SQLiteIDBBackingStore::globalObject):
(WebCore::IDBServer::SQLiteIDBBackingStore::createIndex):
(WebCore::IDBServer::SQLiteIDBBackingStore::uncheckedPutIndexKey):
(WebCore::IDBServer::SQLiteIDBBackingStore::updateIndexesForAddRecord):
(WebCore::IDBServer::SQLiteIDBBackingStore::addRecord):
- Modules/indexeddb/server/SQLiteIDBBackingStore.h:
- Modules/indexeddb/server/UniqueIDBDatabase.cpp:
(WebCore::IDBServer::UniqueIDBDatabase::performPutOrAdd):
- Modules/indexeddb/shared/IDBObjectStoreInfo.h:
LayoutTests:
- platform/mac-wk1/TestExpectations:
- 12:47 PM Changeset in webkit [195688] by
-
- 2 edits in trunk/LayoutTests
LayoutTest fast/loader/stateobjects/replacestate-frequency-iframe.html is flaky on El Cap, always times out on Yosemite.
https://bugs.webkit.org/show_bug.cgi?id=153551
Unreviewed.
The iframe file name is "replacestate-iframe.html", but the main frame src refers to "replaceState-iframe.html"
Notice the case difference on the 'S'.
Apparently some of our bots have case sensitive filesystems, and others do not.
- fast/loader/stateobjects/replacestate-frequency-iframe.html:
- 12:37 PM Changeset in webkit [195687] by
-
- 3 edits in trunk/LayoutTests
Noticed while exploring:
LayoutTest fast/loader/stateobjects/replacestate-frequency-iframe.html is flaky on El Cap, always times out on Yosemite.
https://bugs.webkit.org/show_bug.cgi?id=153551
Unreviewed gardening.
Probably won't fix anything, but hey, let's try.
- fast/loader/stateobjects/replacestate-frequency-iframe-expected.txt:
- fast/loader/stateobjects/replacestate-frequency-iframe.html:
- 12:29 PM Changeset in webkit [195686] by
-
- 12 edits1 copy1 add in trunk
Add API to access closed shadowRoot in InjectedBundle
https://bugs.webkit.org/show_bug.cgi?id=153533
Reviewed by Antti Koivisto.
Source/WebCore:
Always return the shadow root in Element.shadowRootForBindings when the DOM wrapper world has
shadowRootIsAlwaysOpen set to true. Also renamed bindingShadowRoot to shadowRootForBindings
to be consistent.
- bindings/js/DOMWrapperWorld.h:
(WebCore::DOMWrapperWorld::setShadowRootIsAlwaysOpen): Added.
(WebCore::DOMWrapperWorld::shadowRootIsAlwaysOpen): Added.
- dom/Element.cpp:
(WebCore::Element::shadowRootForBindings): Renamed from bindingShadowRoot.
- dom/Element.h:
- dom/Element.idl:
Source/WebKit2:
Added WKBundleScriptWorldMakeAllShadowRootsOpen to make all shadow roots open.
This is needed to keep supporting certain browser-level features such as autofill.
- WebProcess/InjectedBundle/API/c/WKBundleScriptWorld.cpp:
(WKBundleScriptWorldMakeAllShadowRootsOpen): Added.
- WebProcess/InjectedBundle/API/c/WKBundleScriptWorld.h:
- WebProcess/InjectedBundle/InjectedBundleScriptWorld.cpp:
(WebKit::InjectedBundleScriptWorld::makeAllShadowRootsOpen): Added.
- WebProcess/InjectedBundle/InjectedBundleScriptWorld.h:
Tools:
Added WebKit2 API test for WKBundleScriptWorldMakeAllShadowRootsOpen.
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/WebKit2/InjectedBundleMakeAllShadowRootsOpen.cpp: Added.
(TestWebKitAPI::runJavaScriptAlert):
(TestWebKitAPI::TEST):
- TestWebKitAPI/Tests/WebKit2/InjectedBundleMakrAllShadowRootOpen_Bundle.cpp: Added.
(TestWebKitAPI::InjectedBundleMakrAllShadowRootOpenTest::InjectedBundleMakrAllShadowRootOpenTest):
(TestWebKitAPI::InjectedBundleMakrAllShadowRootOpenTest::initialize):
- 12:24 PM Changeset in webkit [195685] by
-
- 23 edits4 adds in trunk
Need ability to specify alternate image for AutoFill button in input fields.
https://bugs.webkit.org/show_bug.cgi?id=153116.
rdar://problem/23384854.
Patch by Zhuo Li <zachli@apple.com> on 2016-01-27
Reviewed by Darin Adler.
Source/WebCore:
Add a new AutoFill button that can be shown in <input> elements.
Tests: fast/forms/auto-fill-button/input-contacts-auto-fill-button.html
fast/forms/auto-fill-button/show-correct-auto-fill-button-when-auto-fill-button-type-changes.html
- css/html.css:
(input::-webkit-contacts-auto-fill-button):
(input::-webkit-contacts-auto-fill-button:hover):
(input::-webkit-contacts-auto-fill-button:active):
Add default style rules for the Contacts AutoFill button based on the ones used for
Manual AutoFill button.
- html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::setShowAutoFillButton):
- html/HTMLInputElement.h:
(WebCore::HTMLInputElement::autoFillButtonType):
- Replace the boolean parameter with a new parameter to specify the type of the AutoFill button.
- Declare a private variable to keep a record of the type of the current AutoFill
button.
(WebCore::HTMLInputElement::showAutoFillButton): Deleted.
- html/HTMLTextFormControlElement.h:
Declare enum for AutoFill button type.
- html/TextFieldInputType.cpp:
(WebCore::autoFillButtonTypeToAutoFillButtonPseudoClassName):
(WebCore::isAutoFillButtonTypeChanged):
(WebCore::TextFieldInputType::shouldDrawAutoFillButton): None means the AutoFill button is not
enabled.
(WebCore::TextFieldInputType::createAutoFillButton): Only create the AutoFill button
if the type is expected.
(WebCore::TextFieldInputType::updateAutoFillButton):
Handle the case where AutoFill button type changes in the text field.
- html/TextFieldInputType.h:
- testing/Internals.cpp:
(WebCore::stringToAutoFillButtonType): Convert the string to AutoFill button type.
(WebCore::Internals::setShowAutoFillButton): Add a new parameter to specify the type of the AutoFill button.
- testing/Internals.h: Ditto.
- testing/Internals.idl: Ditto.
Source/WebKit2:
- WebProcess/InjectedBundle/API/c/WKBundleNodeHandle.cpp:
(toAutoFillButtonType): Convert the WebKit AutoFill button type enum to WebCore AutoFill button
type enum.
(WKBundleNodeHandleSetHTMLInputElementAutoFillButtonEnabledWithButtonType): Added to be able to specify
what the AutoFill button type is. None means the AutoFill button is not shown.
(WKBundleNodeHandleSetHTMLInputElementAutoFillButtonEnabled): Deprecate this method.
- WebProcess/InjectedBundle/API/c/WKBundleNodeHandlePrivate.h: Declare an AutoFill button type enum.
- WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp:
(WebKit::InjectedBundleNodeHandle::isHTMLInputElementAutoFillButtonEnabled): None means the AutoFill button is not enabled.
(WebKit::InjectedBundleNodeHandle::setHTMLInputElementAutoFillButtonEnabledWithButtonType): Use the new parameter to specify
what the AutoFill button type is.
- WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.h: Ditto.
LayoutTests:
- fast/forms/auto-fill-button/hide-auto-fill-button-when-input-becomes-disabled.html: The test API has
another parameter to specify what type the AutoFill button is.
- fast/forms/auto-fill-button/hide-auto-fill-button-when-input-becomes-readonly.html: Ditto.
- fast/forms/auto-fill-button/input-contacts-auto-fill-button-expected.txt: Added.
- fast/forms/auto-fill-button/input-contacts-auto-fill-button.html: Added.
- fast/forms/auto-fill-button/input-auto-fill-button.html: Ditto.
- fast/forms/auto-fill-button/input-disabled-auto-fill-button.html: Ditto.
- fast/forms/auto-fill-button/input-readonly-non-empty-auto-fill-button.html: Ditto.
- fast/forms/auto-fill-button/mouse-down-input-mouse-release-auto-fill-button.html: Ditto.
- fast/forms/auto-fill-button/show-correct-auto-fill-button-when-auto-fill-button-type-changes-expected.html: Added.
- fast/forms/auto-fill-button/show-correct-auto-fill-button-when-auto-fill-button-type-changes.html: Added.
- 12:12 PM Changeset in webkit [195684] by
-
- 2 edits in trunk/Source/WebKit
[Win] Clean build fix after r195680.
- PlatformWin.cmake:
Use the post build command for the post build event.
- 12:10 PM Changeset in webkit [195683] by
-
- 2 edits in trunk/Source/JavaScriptCore
Air::TmpWidth uses a stale pointer into its HashMap after it calls add()
https://bugs.webkit.org/show_bug.cgi?id=153546
Reviewed by Saam Barati.
- b3/air/AirTmpWidth.cpp:
(JSC::B3::Air::TmpWidth::recompute):
- 12:09 PM Changeset in webkit [195682] by
-
- 4 edits2 adds in trunk
Add Node.treeRoot
https://bugs.webkit.org/show_bug.cgi?id=153537
Reviewed by Antti Koivisto.
Source/WebCore:
Exposed highestAncestor as Node.prototype.treeRoot, which was added to shadow DOM spec in
https://github.com/w3c/webcomponents/commit/6864a40fe4efa8a737e78512e3c85319ddc5bf8b
See also:
http://w3c.github.io/webcomponents/spec/shadow/#extensions-to-node-interface
Test: fast/shadow-dom/Node-interface-treeRoot.html
- dom/Node.idl:
LayoutTests:
Added a testharness.js test for Node.treeRoot. Also rebaselined a test.
- js/dom/dom-static-property-for-in-iteration-expected.txt: Rebaselined.
- fast/shadow-dom/Node-interface-treeRoot-expected.txt: Added.
- fast/shadow-dom/Node-interface-treeRoot.html: Added.
- 12:08 PM Changeset in webkit [195681] by
-
- 6 edits in trunk
Rename HTMLSlotElement.getDistributedNodes to getAssignedNodes
https://bugs.webkit.org/show_bug.cgi?id=153534
Reviewed by Antti Koivisto.
Source/WebCore:
Did the rename.
- html/HTMLSlotElement.idl:
LayoutTests:
Updated the tests to refect the rename. Also added test cases after r192763
to assert we don't assign comment and processing instruction nodes to a slot.
- fast/shadow-dom/HTMLSlotElement-interface-expected.txt:
- fast/shadow-dom/HTMLSlotElement-interface.html:
- fast/shadow-dom/NonDocumentTypeChildNode-interface-assignedSlot.html:
- 12:00 PM Changeset in webkit [195680] by
-
- 2 edits in trunk/Source/WebKit
Fix Win EWS after r195545.
https://bugs.webkit.org/show_bug.cgi?id=153434
- PlatformWin.cmake:
Copy WebKit.h after building WebKitGUID, because it doesn't exist before.
This should fix EWS problems like the one seen in bug 153522.
- 11:54 AM Changeset in webkit [195679] by
-
- 3 edits in trunk/Tools
Refactor logic for parsing Trac revisions into its own function and add logic for parsing git hashes.
https://bugs.webkit.org/show_bug.cgi?id=153332
Reviewed by Alexey Proskuryakov.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
(Trac.prototype._xmlTimelineURL): Uses new function.
(Trac.prototype._parseRevisionFromURL): Added. Pulled out logic for parsing revisions from a URL. Also added
logic for parsing git hashes.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js: Added tests for
Trac._parseRevisionFromURL.
- 11:11 AM Changeset in webkit [195678] by
-
- 7 edits4 adds in trunk
Need to be able to specify MIME type for <attachment> without filename or handle
https://bugs.webkit.org/show_bug.cgi?id=153552
<rdar://problem/20145857>
Reviewed by Anders Carlsson.
Tests: fast/attachment/attachment-default-icon.html
fast/attachment/attachment-type-attribute.html
- html/HTMLAttachmentElement.cpp:
(WebCore::HTMLAttachmentElement::parseAttribute):
Invalidate attachment when 'type' attribute changes.
(WebCore::HTMLAttachmentElement::attachmentType):
- html/HTMLAttachmentElement.h:
- platform/graphics/Icon.h:
- platform/graphics/mac/IconMac.mm:
(WebCore::Icon::createIconForUTI):
(WebCore::Icon::createIconForMIMEType):
Add Icon class methods to retrieve an icon given a UTI or MIME type.
- rendering/RenderThemeMac.mm:
(WebCore::paintAttachmentIcon):
Use the 'type' attribute (a MIME type) if we have one. Otherwise,
use the filename. Lastly fall back to a plain file icon (using the root
file UTI, public.data).
- fast/attachment/attachment-default-icon-expected.html: Added.
- fast/attachment/attachment-default-icon.html: Added.
- fast/attachment/attachment-type-attribute-expected.html: Added.
- fast/attachment/attachment-type-attribute.html: Added.
Add some tests.
- 10:38 AM Changeset in webkit [195677] by
-
- 2 edits in trunk/Source/WebKit2
More trying to fix the build.
- Configurations/WebKit.xcconfig:
- 10:34 AM Changeset in webkit [195676] by
-
- 3 edits in trunk/Tools
Remove Mavericks from the flakiness dashboard
https://bugs.webkit.org/show_bug.cgi?id=153521
Reviewed by Dan Bernstein.
- TestResultServer/static-dashboards/builders.jsonp:
- TestResultServer/static-dashboards/flakiness_dashboard.js:
- 10:24 AM Changeset in webkit [195675] by
-
- 20 edits in trunk
Remove ENABLE_CURRENTSRC
https://bugs.webkit.org/show_bug.cgi?id=153545
Reviewed by Simon Fraser.
.:
- Source/cmake/OptionsEfl.cmake:
- Source/cmake/OptionsGTK.cmake:
- Source/cmake/OptionsMac.cmake:
- Source/cmake/OptionsWin.cmake:
- Source/cmake/WebKitFeatures.cmake:
- Source/cmake/tools/vsprops/FeatureDefines.props:
- Source/cmake/tools/vsprops/FeatureDefinesCairo.props:
Source/JavaScriptCore:
- Configurations/FeatureDefines.xcconfig:
Source/WebCore:
- Configurations/FeatureDefines.xcconfig:
Source/WebKit/mac:
- Configurations/FeatureDefines.xcconfig:
Source/WebKit2:
- Configurations/FeatureDefines.xcconfig:
Source/WTF:
- wtf/FeatureDefines.h:
Tools:
- Scripts/webkitperl/FeatureList.pm:
- 10:23 AM Changeset in webkit [195674] by
-
- 2 edits in trunk/Source/WebKit2
Try to fix the build.
- Configurations/WebKit.xcconfig:
- 8:57 AM Changeset in webkit [195673] by
-
- 2 edits in trunk/Source/WebCore
Stop echoing echo commands to stdout
https://bugs.webkit.org/show_bug.cgi?id=153531
Reviewed by Csaba Osztrogonác.
- DerivedSources.make:
- 7:35 AM Changeset in webkit [195672] by
-
- 1 edit3 adds in trunk/LayoutTests
[GTK] Problem running promises code in workers
https://bugs.webkit.org/show_bug.cgi?id=152340
Reviewed by Carlos Garcia Campos.
Test file that creates two testharness promise tests. Each test creates 10000 promises, pushes them into an
array and vends them in a timeout.
- js/promises-tests/promises-in-workers-expected.txt: Added.
- js/promises-tests/promises-in-workers.html: Added.
- js/promises-tests/promises-in-workers.js: Added.
- 7:20 AM Changeset in webkit [195671] by
-
- 3 edits2 adds in trunk
Calling video.controls=true during a scrub operation cancels scrub.
https://bugs.webkit.org/show_bug.cgi?id=153494
Reviewed by Eric Carlson.
Source/WebCore:
Test: media/media-controls-drag-timeline-set-controls-property.html
Verify that the video.controls attribute actually changed before tearing down and
re-adding the media controls to the Shadow DOM.
- Modules/mediacontrols/mediaControlsApple.js:
(Controller.prototype.handleControlsChange):
(Controller.prototype.hasControls):
LayoutTests:
- media/media-controls-drag-timeline-set-controls-property-expected.txt: Added.
- media/media-controls-drag-timeline-set-controls-property.html: Added.
- 6:34 AM Changeset in webkit [195670] by
-
- 1 copy in releases/WebKitGTK/webkit-2.10.6
WebKitGTK+ 2.10.6
- 6:30 AM WebKitGTK/Gardening/Calendar edited by
- (diff)
- 6:17 AM Changeset in webkit [195669] by
-
- 4 edits in releases/WebKitGTK/webkit-2.10
Unreviewed. Update OptionsGTK.cmake and NEWS for 2.10.6 release.
.:
- Source/cmake/OptionsGTK.cmake: Bump version numbers.
Source/WebKit2:
- gtk/NEWS: Add release notes for 2.10.6
- 5:40 AM Changeset in webkit [195668] by
-
- 5 edits2 adds in releases/WebKitGTK/webkit-2.10
Merge r195586 - [GTK] WebProcess crashes when quickly attempting many DnD operations
https://bugs.webkit.org/show_bug.cgi?id=138468
Reviewed by Michael Catanzaro.
Source/WebKit2:
Do not allow different DnD operations over the same element at the
same time, so that any new attempt to DnD an element happening before
a previous attempt has ended will take precedence, cancelling the older
operation before going ahead with the new one.
This is consistent with how WebCore::EventHandler handles DnD operations,
preventing the web process from crashing in scenarios where the user might
try to perform many DnD operations over the same element very quickly.
- UIProcess/gtk/DragAndDropHandler.cpp:
(WebKit::DragAndDropHandler::DragAndDropHandler): Initialized new member.
(WebKit::DragAndDropHandler::startDrag): Ensure a previous DnD operation
is cancelled before handling the new one that has just started.
(WebKit::DragAndDropHandler::fillDragData): Protect against calling this
function from webkitWebViewBaseDragDataGet for already cancelled operations.
(WebKit::DragAndDropHandler::finishDrag): Protect against calling this
function from webkitWebViewBaseDragEnd for already cancelled operations.
- UIProcess/gtk/DragAndDropHandler.h:
LayoutTests:
New test added to check that the web process does not crash when multiple
DnD operations are quickly attempted over the same draggable element.
- fast/events/drag-and-drop-link-fast-multiple-times-does-not-crash-expected.txt: Added.
- fast/events/drag-and-drop-link-fast-multiple-times-does-not-crash.html: Added.
Added the new test to the failure expectations for mac-wk2, as there's no
suitable implementation of eventSender in place yet (see bug 42194).
- platform/mac-wk2/TestExpectations: Added failure expectation for the new test.
- 5:33 AM Changeset in webkit [195667] by
-
- 3 edits in releases/WebKitGTK/webkit-2.10/Source/WebCore
Merge r195537 - REGRESSION(r192773): [GTK] maps.google.com unresponsive/stalls since r192773
https://bugs.webkit.org/show_bug.cgi?id=153194
Reviewed by Michael Catanzaro.
In r192773 we implemented the JavaScriptCore garbage collector
timers for the GTK+ port. Those timers schedule sources in the
current thread default main context, but JS web worker threads
implementation doesn't use WTF::RunLoop, but its own WorkerRunLoop
class that doesn't create a GMainContext for the new thread. This
means that for web sites using workers, we are now doing garbage
collection of worker VMs in the main thread which ends up in a
deadlock at some point. We need to ensure that worker threads
create a GMainContext and push it as the default one for the
thread before the WorkerGlobalScope is created. This way when the
worker Heap is created, the GC timers use the right context to
schedule their sources. And then we need to check if there are
sources pending in the thread main context on every worker run
loop iteration.
- workers/WorkerRunLoop.cpp:
(WebCore::WorkerRunLoop::runInMode):
- workers/WorkerThread.cpp:
(WebCore::WorkerThread::workerThread):
- 5:31 AM Changeset in webkit [195666] by
-
- 3 edits2 adds in releases/WebKitGTK/webkit-2.10
Merge r195511 - [GTK] Fix media controls displaying without controls attribute
https://bugs.webkit.org/show_bug.cgi?id=152500
Media controls is not displayed without controls attribute by default
when the video element has text track. It'll be displayed on fullscreen
regardless of controls attribute.
Patch by Wonchul Lee <wonchul.lee@collabora.co.uk> on 2016-01-23
Reviewed by Michael Catanzaro.
Source/WebCore:
- Modules/mediacontrols/mediaControlsGtk.js:
(ControllerGtk.prototype.shouldHaveControls):
(ControllerGtk.prototype.reconnectControls):
(ControllerGtk.prototype.removeControls):
(ControllerGtk.prototype.configureControls): Deleted.
LayoutTests:
- media/video-controls-no-display-with-text-track-expected.txt: Added.
- media/video-controls-no-display-with-text-track.html: Added.
- 5:23 AM Changeset in webkit [195665] by
-
- 4 edits2 adds in releases/WebKitGTK/webkit-2.10
Merge r195453 - Elements with overflow and border-radius don't show in multicolumn properly.
https://bugs.webkit.org/show_bug.cgi?id=152920
Reviewed by Simon Fraser.
Source/WebCore:
Added new test in fast/multicol.
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::convertToLayerCoords):
(WebCore::RenderLayer::offsetFromAncestor):
(WebCore::RenderLayer::clipToRect):
- rendering/RenderLayer.h:
Make sure the crawl up the containing block chain to apply clips properly offsets
to account for columns. convertToLayerCoords could already handle this, so
offsetFromAncestor now takes the same extra argument (whether or not to adjust for
columns) that convertToLayerCoords does.
LayoutTests:
- fast/multicol/border-radius-overflow-columns-expected.html: Added.
- fast/multicol/border-radius-overflow-columns.html: Added.
- 5:21 AM Changeset in webkit [195664] by
-
- 9 edits2 adds in releases/WebKitGTK/webkit-2.10
Merge r195445 - REGRESSION (r168244): Content in horizontal-bt page is offset such that only the end is viewable and there is a white gap at the top
https://bugs.webkit.org/show_bug.cgi?id=136019
Reviewed by Dan Bernstein.
Source/WebCore:
In horizontal-bt documents (where the page starts scrolled to the bottom, and scrolling up goes into negative scroll positions),
the position of the root content layer would be set incorrectly by the scrolling thread, resulting in misplaced
content.
Fix by having the renamed "yPositionForRootContentLayer" take scroll origin into
account, and being more consistent about using scrollOrigin to position this layer.
Test: fast/scrolling/programmatic-horizontal-bt-document-scroll.html
- page/FrameView.cpp:
(WebCore::FrameView::yPositionForFooterLayer): Moved
(WebCore::FrameView::positionForRootContentLayer): Take scrollOrigin, and subtract it from the computed value.
(WebCore::FrameView::yPositionForRootContentLayer): Renamed.
- page/FrameView.h:
- page/scrolling/AsyncScrollingCoordinator.cpp:
(WebCore::AsyncScrollingCoordinator::updateScrollPositionAfterAsyncScroll): We've already pushed the new scrollPosition onto the FrameView,
so we can just use the member function to compute the positionForContentsLayer.
- page/scrolling/mac/ScrollingTreeFrameScrollingNodeMac.mm:
(WebCore::ScrollingTreeFrameScrollingNodeMac::setScrollLayerPosition): This is the bug fix; FrameView::positionForRootContentLayer()
now takes scrollOrigin into account.
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::updateRootLayerPosition): Rather than using the documentRect, position the root content layer
in terms of the scroll origin (which is -documentRect.location()).
Source/WebKit2:
Now call frameView.positionForRootContentLayer(), and add a FIXME questioning the
behavior in horizontal b-t documents. However, this code isn't hit now that we always
do extended backgrounds, so never have shadow layers.
- WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::shadowLayerPositionForFrame):
LayoutTests:
Test that scrolls a horizontal-bt document.
- fast/scrolling/programmatic-horizontal-bt-document-scroll-expected.html: Added.
- fast/scrolling/programmatic-horizontal-bt-document-scroll.html: Added.
- 4:34 AM Changeset in webkit [195663] by
-
- 13 edits4 adds in releases/WebKitGTK/webkit-2.10
Merge r195411 - A crash reproducible in Path::isEmpty() under RenderSVGShape::paint()
https://bugs.webkit.org/show_bug.cgi?id=149613
Patch by Said Abou-Hallawa <sabouhallawa@apple.com> on 2016-01-21
Reviewed by Darin Adler.
Source/WebCore:
When RenderSVGRoot::layout() realizes its layout size has changed and
it has resources which have relative sizes, it marks all the clients of
the resources for invalidates regardless whether they belong to the
same RenderSVGRoot or not. But it reruns the layout only for its children.
If one of these clients comes before the current RenderSVGRoot in the render
tree, ee end up having renderer marked for invalidation at rendering time.
This also prevents scheduling the layout if the same renderer is marked
for another invalidation later. We prevent this because we do not want
to schedule another layout for a renderer which is already marked for
invalidation. This can cause crash if the renderer is an RenderSVGPath.
The fix is to mark "only" the clients of a resource which belong to the
same RenderSVGRoot of the resource. Also we need to run the layout for
all the resources which belong to different RenderSVGRoots before running
the layout for an SVG renderer.
Tests: svg/custom/filter-update-different-root.html
svg/custom/pattern-update-different-root.html
- rendering/svg/RenderSVGResourceContainer.cpp:
(WebCore::RenderSVGResourceContainer::markAllClientsForInvalidation):
We should not mark any client outside the current root for invalidation
- rendering/svg/RenderSVGResourceContainer.h: Remove unneeded private keyword.
- rendering/svg/RenderSVGRoot.cpp:
(WebCore::RenderSVGRoot::addResourceForClientInvalidation):
Code clean up; use findTreeRootObject() instead of repeating the same code.
- rendering/svg/RenderSVGShape.cpp:
(WebCore::RenderSVGShape::isEmpty): Avoid crashing if RenderSVGShape::isEmpty()
is called before calling RenderSVGShape::layout().
- rendering/svg/RenderSVGText.cpp:
(WebCore::RenderSVGText::layout): findTreeRootObject() now returns a pointer.
- rendering/svg/SVGRenderSupport.cpp:
(WebCore::SVGRenderSupport::findTreeRootObject): I do think nothing
guarantees that an SVG renderer has to have an RenderSVGRoot in its
ancestors. So change this function to return a pointer. Also Provide
the non-const version of this function.
(WebCore::SVGRenderSupport::layoutDifferentRootIfNeeded): Runs the layout
if needed for all the resources which belong to different RenderSVGRoots.
(WebCore::SVGRenderSupport::layoutChildren): Make sure all the renderer's
resources which belong to different RenderSVGRoots are laid out before
running the layout for this renderer.
- rendering/svg/SVGRenderSupport.h: Remove a mysterious comment.
- rendering/svg/SVGResources.cpp:
(WebCore::SVGResources::layoutDifferentRootIfNeeded): Run the layout for
all the resources which belong to different RenderSVGRoots outside the
context of their RenderSVGRoots.
- rendering/svg/SVGResources.h:
(WebCore::SVGResources::clipper):
(WebCore::SVGResources::markerStart):
(WebCore::SVGResources::markerMid):
(WebCore::SVGResources::markerEnd):
(WebCore::SVGResources::masker):
(WebCore::SVGResources::filter):
(WebCore::SVGResources::fill):
(WebCore::SVGResources::stroke):
Code clean up; use nullptr instead of 0.
LayoutTests:
When running the layout of an SVG root and it has resources which are
referenced by clients in other SVG roots, make sure we run the layout
for these resources before running the layout for their clients.
- svg/custom/filter-update-different-root-expected.html: Added.
- svg/custom/filter-update-different-root.html: Added.
Without this patch this test crashes because we paint a dirty RenderSVGShape.
- svg/custom/pattern-update-different-root-expected.html: Added.
- svg/custom/pattern-update-different-root.html: Added.
Without this patch this test works fine but it is good to have it to catch
cases where the SVG root needs to run re-layout for its children resources
and hence their clients if its size has changed.
- svg/custom/unicode-in-tspan-multi-svg-crash-expected.txt:
- svg/custom/unicode-in-tspan-multi-svg-crash.html:
This test was ported from Blink in http://trac.webkit.org/changeset/166420.
The expectation of this test was changed in Blink:
https://src.chromium.org/viewvc/blink?revision=158480&view=revision.
- 4:28 AM Changeset in webkit [195662] by
-
- 5 edits2 adds in releases/WebKitGTK/webkit-2.10
Merge r195397 - http://victordarras.fr/cssgame/ doesn't work in Safari.
https://bugs.webkit.org/show_bug.cgi?id=153285
<rdar://problem/24212369>
Reviewed by Tim Horton.
This patch adds support for hittesting ClipPathOperation::Reference.
Source/WebCore:
Tests: svg/clip-path/hittest-clip-path-reference-miss.html
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::nodeAtPoint):
- rendering/RenderObject.h:
(WebCore::RenderObject::isSVGResourceClipper):
- rendering/svg/RenderSVGResourceClipper.h:
(isType):
LayoutTests:
- svg/clip-path/hittest-clip-path-reference-miss-expected.html: Added.
- svg/clip-path/hittest-clip-path-reference-miss.html: Added.
- 2:32 AM Changeset in webkit [195661] by
-
- 6 edits5 adds2 deletes in trunk/Source/WebCore
[GTK][EFL] Rename ScrollAnimationNone as ScrollAnimationSmooth
https://bugs.webkit.org/show_bug.cgi?id=153481
Reviewed by Simon Fraser.
ScrollAnimationNone has always been used by EFL and GTK ports to
implement smooth scrolling. I think it should be possible for
other scroll animators to implement smooth scrolling or even
implement other kind of scroll animations. For example, in the
future I would like to have kinetic scrolling implemented for the
GTK+ port to match all other GTK+ application and decide at
runtime between different animations without having to use a
different scroll animator class. So, this patch also moves the
smooth scrolling animation implementation to its own class
ScrollAnimationSmooth that impements an interface ScrollAnimation
that could be used to implement other animations. This will allow
the GTK+ port to add its own scroll animator class and still
support smooth scrolling sharing the code with the
ScrollAnimationSmooth.
- PlatformEfl.cmake: Add new files to compilation and remove ScrollAnimationNone.
- PlatformGTK.cmake: Ditto.
- platform/ScrollAnimation.h: Added.
(WebCore::ScrollAnimation::serviceAnimation):
(WebCore::ScrollAnimation::ScrollAnimation):
- platform/ScrollAnimationSmooth.cpp: Added.
(WebCore::ScrollAnimationSmooth::ScrollAnimationSmooth):
(WebCore::ScrollAnimationSmooth::scroll):
(WebCore::ScrollAnimationSmooth::stop):
(WebCore::ScrollAnimationSmooth::updateVisibleLengths):
(WebCore::ScrollAnimationSmooth::setCurrentPosition):
(WebCore::ScrollAnimationSmooth::serviceAnimation):
(WebCore::ScrollAnimationSmooth::~ScrollAnimationSmooth):
(WebCore::curveAt):
(WebCore::attackCurve):
(WebCore::releaseCurve):
(WebCore::coastCurve):
(WebCore::curveIntegralAt):
(WebCore::attackArea):
(WebCore::releaseArea):
(WebCore::getAnimationParametersForGranularity):
(WebCore::ScrollAnimationSmooth::updatePerAxisData):
(WebCore::ScrollAnimationSmooth::animateScroll):
(WebCore::ScrollAnimationSmooth::animationTimerFired):
(WebCore::ScrollAnimationSmooth::startNextTimer):
(WebCore::ScrollAnimationSmooth::animationTimerActive):
- platform/ScrollAnimationSmooth.h: Added.
- platform/ScrollAnimator.cpp:
(WebCore::ScrollAnimator::scroll):
(WebCore::ScrollAnimator::scrollToOffsetWithoutAnimation):
(WebCore::ScrollAnimator::setCurrentPosition):
(WebCore::ScrollAnimator::updateActiveScrollSnapIndexForOffset):
(WebCore::ScrollAnimator::notifyPositionChanged):
(WebCore::ScrollAnimator::scrollOffsetOnAxis):
- platform/ScrollAnimator.h:
(WebCore::ScrollAnimator::ScrollAnimator::currentPosition):
- platform/ScrollAnimatorNone.cpp: Removed.
- platform/ScrollAnimatorNone.h: Removed.
- platform/ScrollAnimatorSmooth.cpp: Added.
(WebCore::ScrollAnimator::create):
(WebCore::ScrollAnimatorSmooth::ScrollAnimatorSmooth):
(WebCore::ScrollAnimatorSmooth::~ScrollAnimatorSmooth):
(WebCore::ScrollAnimatorSmooth::scroll):
(WebCore::ScrollAnimatorSmooth::scrollToOffsetWithoutAnimation):
(WebCore::ScrollAnimatorSmooth::cancelAnimations):
(WebCore::ScrollAnimatorSmooth::serviceScrollAnimations):
(WebCore::ScrollAnimatorSmooth::willEndLiveResize):
(WebCore::ScrollAnimatorSmooth::didAddVerticalScrollbar):
(WebCore::ScrollAnimatorSmooth::didAddHorizontalScrollbar):
- platform/ScrollAnimatorSmooth.h: Added.
- platform/mac/ScrollAnimatorMac.mm:
(WebCore::ScrollAnimatorMac::immediateScrollToPosition):
(WebCore::ScrollAnimatorMac::immediateScrollBy):
- 2:28 AM Changeset in webkit [195660] by
-
- 3 edits in trunk/Source/WebCore
Overlay scrollbars should always use the whole contents
https://bugs.webkit.org/show_bug.cgi?id=153352
Reviewed by Michael Catanzaro.
In case of having both horizontal and vertical scrollbars, the
scrollbars respect the scroll corner. That looks good for legacy
scrollbars that show the track, but with the overlay indicators
it looks weird that the indicator stops so early before the end of
the contents, giving the impression that there's something else to
scroll. This happens because the scroll corner is transparent, so
it's not obvious that's the scroll corner. It also happens with
the text areas having a resizer. Legacy scrollbars take into
account the resizer, which is good, but I expect overlay
scrollbars to be rendered also over the resizer. The resizer takes
precedence so you can still click and drag to resize the text area.
In the case of main frame scrollbars we are indeed returning an
empty rectangle from ScrollView::scrollCornerRect() when using
overlay scrollbars, but when calculating the size of the
scrollbars we are using the actual width/height instead of the
occupied with/height. For other scrollbars
RenderLayer::scrollCornerRect() is not checking whether scrollbars
are overlay or not and we are always returning a scroll corner
rectangle when scrollbars are present.
- platform/ScrollView.cpp:
(WebCore::ScrollView::updateScrollbars): Use the occupied
width/height when calculating the space the one scrollbar
should leave for the other.
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::scrollCornerRect): Return an empty
rectangle when using overlay scrollbars.
- 2:24 AM Changeset in webkit [195659] by
-
- 2 edits in trunk/Source/WebCore
ScrollAnimator is not notified when mouse entered, moved or exited a RenderListBox
https://bugs.webkit.org/show_bug.cgi?id=153398
Reviewed by Michael Catanzaro.
EvenHandler is checking whether the enclosing layer of a node is
registered as scrollable area of its frame view. That doesn't work
for list boxes, because they are the scrollable area
themselves. Also when entering a list box the node under mouse is
not usually the list box itself, but any of its children, a
HTMLOptionElement or a HTMLOptGroupElement. Instead of comparing
layers, we should find the enclosing scrollable area of the target
elements and compare them to decide whether the mouse has entered,
left or moved a scrollable area.
- page/EventHandler.cpp:
(WebCore::enclosingScrollableArea): Return the enclosing
scrollable area of the given node. If the node doesn't have a
renderer, it traverses its parents. If the renderer is a
RenderListBox it is returned, otherwhise the enclosing layer is
returned.
(WebCore::EventHandler::mouseMoved): Use enclosingScrollableArea.
(WebCore::EventHandler::updateMouseEventTargetNode): Ditto.
Jan 26, 2016:
- 11:43 PM Changeset in webkit [195658] by
-
- 4 edits1 add in trunk/Tools
Sort incoming commits via date instead of revision number.
https://bugs.webkit.org/show_bug.cgi?id=153467
Reviewed by Alexey Proskuryakov.
Future Trac instances may use Git or other revision control systems where we cannnot rely on the revision number
for sorting revisions. Instead we use the commit date to sort revisions chronologically.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
(Trac.prototype._loaded): Sort via date instead of revision number.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockTrac.js:
(MockTrac): Fix up the mock data to look more like real-world data.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/test-fixture-trac-rss.xml: Added.
Fake RSS feed that adds three more commits.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js: Added unit tests to test
Trac._loaded().
- 11:13 PM Changeset in webkit [195657] by
-
- 2 edits in trunk/Source/WebKit2
Attempt to force a rebuild.
- DerivedSources.make:
- 10:39 PM Changeset in webkit [195656] by
-
- 3 edits in trunk/Source/WebCore
Try touching DerivedSources.make to force rebuilding.
- DerivedSources.make:
- page/DOMWindow.idl:
- 10:27 PM Changeset in webkit [195655] by
-
- 2 edits in trunk/Source/WebCore
Try to force a rebuild.
- page/DOMWindow.idl:
- 10:10 PM Changeset in webkit [195654] by
-
- 2 edits in trunk/Source/JavaScriptCore
[JSC] When lowering B3 to Air, preferRightForResult() should prefer values from the same block
https://bugs.webkit.org/show_bug.cgi?id=153477
Reviewed by Filip Pizlo.
In cases like this:
Block #0
@1 = something
@2 = Jump #1
Block #1
@3 = something else
@4 = Add(@3, @1)
...
@42 = Branch(@x, #1, #2)
B3LowerToAir would pick @1 for the argument copied
for what goes into the UseDef side of Add.
This created a bunch of moves that could never be coalesced.
In Kraken's imaging-desaturate, there were enough Moves to slow
down the hot loop.
Ideally, we should not use UseCount for lowering. We should use
the real liveness for preferRightForResult(), and a loop-weighted
use-count for effective addresses. The problem is keeping the cost
low for those simple helpers.
In this patch, I went with a simple heuristic: prioritize the value
defined in the same block for UseDef.
There is one other way that would be cheap but a bit invasive:
-Get rid of UseDef.
-Make every ops, 3 operands.
-Tell the register allocator to attempt aliasing of the 2 uses
with the def.
-If the allocator fails, just add a move as needed.
For now, the simple heuristic seems okay for the cases have.
- b3/B3LowerToAir.cpp:
(JSC::B3::Air::LowerToAir::preferRightForResult):
- 7:49 PM Changeset in webkit [195653] by
-
- 2 edits in trunk/Source/JavaScriptCore
Tail duplication should break critical edges first
https://bugs.webkit.org/show_bug.cgi?id=153530
Reviewed by Benjamin Poulain.
This speeds up Octane/boyer.
- b3/B3DuplicateTails.cpp:
- 7:45 PM Changeset in webkit [195652] by
-
- 5 edits in trunk
fast/history/page-cache-webdatabase-no-transaction-db.html flakily crashes
https://bugs.webkit.org/show_bug.cgi?id=153525
Reviewed by Andreas Kling.
Source/WebCore:
The test was crashing because DatabaseThread::hasPendingDatabaseActivity()
was accessing m_openDatabaseSet from the main thread without any locking
mechanism. This is an issue because m_openDatabaseSet is altered by the
database thread.
No new tests, already covered by fast/history/page-cache-webdatabase-no-transaction-db.html.
- Modules/webdatabase/DatabaseThread.cpp:
(WebCore::DatabaseThread::databaseThread):
(WebCore::DatabaseThread::recordDatabaseOpen):
(WebCore::DatabaseThread::recordDatabaseClosed):
(WebCore::DatabaseThread::hasPendingDatabaseActivity):
- Modules/webdatabase/DatabaseThread.h:
LayoutTests:
Unskip fast/history/page-cache-webdatabase-no-transaction-db.html now
that it no longer crashes.
- 7:16 PM Changeset in webkit [195651] by
-
- 5 edits in trunk/Source/WebKit2
REGRESSION (r194557): Keyboard shortcuts stop working after the WKWebView is unparented and reparented
https://bugs.webkit.org/show_bug.cgi?id=153492
<rdar://problem/24138989>
Reviewed by Dan Bernstein.
- UIProcess/ios/WKContentViewInteraction.h:
- UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView canBecomeFirstResponder]):
(-[WKContentView becomeFirstResponder]):
(-[WKContentView resignFirstResponder]):
When WKWebView is unparented, WKContentView will attempt to resignFirstResponder upwards,
first asking WKWebView. After r194557, WKWebView will accept first responder and forward
it on to the WKContentView, which will happily accept it again, despite being the view
that's trying to resign. This will cause us to completely lose first responder,
where it was actually supposed to propagate up above WKWebView to the client.
Keep track of when WKContentView is resigning first responder, and don't
let it become first responder while it is doing so, breaking the cycle.
- UIProcess/ios/WKContentView.h:
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView canBecomeFirstResponder]):
If the WKContentView is currently in the process of resigning first responder status,
we shouldn't accept it, because clients expect to receive it.
- 7:05 PM Changeset in webkit [195650] by
-
- 10 edits1 add in trunk
Source/WebKit2:
Implement wildcard matching for plug-in policy host.
https://bugs.webkit.org/show_bug.cgi?id=153090
Patch by I-Ting Liu <iting_liu@apple.com> on 2016-01-26
Reviewed by Darin Adler.
WebPlatformStrategies decides the plug-in load policy for a host by looking
for a matched hostname in the list of plug-in policies sent by Safari. This
patch adds support for wildcard matching -- if there's a policy with hostname
"*.example.com," the policy for "foo.example.com" would be replaced with that
of "*.example.com" if there's no policy for this hostname. If there is more
than one wildcard hostname, the host with the longest wildcard hostname will
be used.
This patch adds a helper function in StringUtilites that matches a string to
another string, which may contain wildcard ('*') characters.
- Platform/mac/StringUtilities.h:
- Add WebKit::stringMatchesWildcardString.
- Remove #if ENABLE(TELEPHONE_NUMBER_DETECTION) && PLATFORM(MAC) flag so that
the compiler allows exposing StringUtilities.h.
- Add #if OBJC to allow the file to be included in WebPltformStrategies.cpp
- Platform/mac/StringUtilities.mm:
(WebKit::stringMatchesWildcardString):
Return true if the entire first given String matches the second. The second string
may contain wildcard characters.
(WebKit::wildcardRegexPatternString):
Return the regex expression from a wildcard string by replacing the wildcard
character ('*') with (".*") and escaping regular expression metacharacters.
(WebKit::formattedPhoneNumberString):
To expose StringUtilities.h for tests, we removed #if ENABLE(TELEPHONE_NUMBER_DETECTION)
&& PLATFORM(MAC) flag in the header. Add a function that returns nil for
#if !(ENABLE(TELEPHONE_NUMBER_DETECTION) && PLATFORM(MAC)) to fix the removal
of the flag in the header file.
- WebKit2.xcodeproj/project.pbxproj:
Change the file attribute of StringUtilities.h from Project to Private for
testing in TestWebKitAPI.
- WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
(WebKit::WebPlatformStrategies::longestMatchedWildcardHostForHost):
Return the wildcard hostname whose matched substring with the host is the longest.
(WebKit::WebPlatformStrategies::replaceHostWithMatchedWildcardHost):
Replace the look-up host with a matched wildcard host if there is a match and that
the matched wildcard host's plug-in identifier is the same as that of the host.
(WebKit::WebPlatformStrategies::pluginLoadClientPolicyForHost):
Try to replace the look-up host with the wildcard host if there's no policy for
the host. Restructure the function to reduce hashmap lookup.
- WebProcess/WebCoreSupport/WebPlatformStrategies.h:
Declare the methods.
Source/WTF:
Implement wildcard matching for plug-in policy host.
https://bugs.webkit.org/show_bug.cgi?id=153090
Patch by I-Ting Liu <iting_liu@apple.com> on 2016-01-26
Reviewed by Darin Adler.
- wtf/text/AtomicString.h:
(WTF::AtomicString::AtomicString):
Add bridge to allow compilation.
Tools:
Add a test for WebKit::stringMatchesWildcardString.
https://bugs.webkit.org/show_bug.cgi?id=153090
Patch by I-Ting Liu <iting_liu@apple.com> on 2016-01-26
Reviewed by Darin Adler.
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
Add the file to the project.
- TestWebKitAPI/Tests/WebKit2/mac/StringUtilities.mm: Added.
(TestWebKitAPI::TEST):
Test that a string matches another string that may contain wildcard characters.
- 6:41 PM Changeset in webkit [195649] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed CMake build fix after r195644.
- PlatformMac.cmake:
- 6:25 PM Changeset in webkit [195648] by
-
- 5 edits in trunk
Modern IDB: Key generator support for SQLite backend.
https://bugs.webkit.org/show_bug.cgi?id=153427
Reviewed by Alex Christensen.
Source/WebCore:
No new tests (Existing failing tests now pass, others improved).
- Modules/indexeddb/server/SQLiteIDBBackingStore.cpp:
(WebCore::IDBServer::SQLiteIDBBackingStore::uncheckedGetKeyGeneratorValue):
(WebCore::IDBServer::SQLiteIDBBackingStore::uncheckedSetKeyGeneratorValue):
(WebCore::IDBServer::SQLiteIDBBackingStore::generateKeyNumber):
(WebCore::IDBServer::SQLiteIDBBackingStore::revertGeneratedKeyNumber):
(WebCore::IDBServer::SQLiteIDBBackingStore::maybeUpdateKeyGeneratorNumber):
- Modules/indexeddb/server/SQLiteIDBBackingStore.h:
LayoutTests:
- platform/mac-wk1/TestExpectations:
- 6:16 PM Changeset in webkit [195647] by
-
- 2 edits in trunk/Source/WebKit2
Remove -d flag from make invocation.
- WebKit2.xcodeproj/project.pbxproj:
- 5:53 PM Changeset in webkit [195646] by
-
- 8 edits2 adds in trunk
Allow canvas to use display-list drawing for testing
https://bugs.webkit.org/show_bug.cgi?id=153475
Reviewed by Dean Jackson.
Source/WebCore:
Optionally have 2D <canvas> use display-list drawing, which is only enabled
via Internals for now.
Support displayListAsText() and replayDisplayListAsText() on canvas, so we can
use it to test playback optimizations. [Note that displayListAsText() always
returns an empty string currently, because the display list is cleared when the
canvas is painted to the page.]
Display list rendering is implemented by giving CanvasRenderingContext2D an
optional DisplayListDrawingContext, which packages up a display list, recorder
and recording context. The existing paintRenderingResultsToCanvas() is overridden
to replay the recorded display list into the primary canvas context.
Tracked replay display lists are stored in a static map, keyed by the CanvasRenderingContext2D.
Test: displaylists/canvas-display-list.html
- html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::HTMLCanvasElement):
(WebCore::HTMLCanvasElement::getContext):
(WebCore::HTMLCanvasElement::paint):
(WebCore::HTMLCanvasElement::setUsesDisplayListDrawing):
(WebCore::HTMLCanvasElement::setTracksDisplayListReplay):
(WebCore::HTMLCanvasElement::displayListAsText):
(WebCore::HTMLCanvasElement::replayDisplayListAsText):
- html/HTMLCanvasElement.h:
- html/canvas/CanvasRenderingContext.h:
- html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::DisplayListDrawingContext::DisplayListDrawingContext):
(WebCore::contextDisplayListMap):
(WebCore::CanvasRenderingContext2D::~CanvasRenderingContext2D):
(WebCore::CanvasRenderingContext2D::setTracksDisplayListReplay):
(WebCore::CanvasRenderingContext2D::displayListAsText):
(WebCore::CanvasRenderingContext2D::replayDisplayListAsText):
(WebCore::CanvasRenderingContext2D::paintRenderingResultsToCanvas):
(WebCore::CanvasRenderingContext2D::drawingContext):
(WebCore::CanvasRenderingContext2D::CanvasRenderingContext2D): Deleted.
- html/canvas/CanvasRenderingContext2D.h:
- testing/Internals.cpp:
(WebCore::Internals::setElementUsesDisplayListDrawing):
(WebCore::Internals::setElementTracksDisplayListReplay):
(WebCore::Internals::displayListForElement):
(WebCore::Internals::replayDisplayListForElement):
LayoutTests:
Simple canvas-based display list test.
- displaylists/canvas-display-list-expected.txt: Added.
- displaylists/canvas-display-list.html: Added.
- 5:31 PM Changeset in webkit [195645] by
-
- 2 edits4 deletes in trunk/Source/WebInspectorUI
Web Inspector: Remove unused FramesLarge.png variants, only the smaller Frames icon is used for the Rendering Frames timeline
https://bugs.webkit.org/show_bug.cgi?id=153523
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-01-26
Reviewed by Timothy Hatcher.
- UserInterface/Images/FramesLarge.png: Removed.
- UserInterface/Images/FramesLarge@2x.png: Removed.
- UserInterface/Images/gtk/FramesLarge.png: Removed.
- UserInterface/Images/gtk/FramesLarge@2x.png: Removed.
- UserInterface/Views/TimelineIcons.css:
(.rendering-frame-icon.large .icon): Deleted.
- 5:29 PM Changeset in webkit [195644] by
-
- 19 edits5 adds in trunk/Source
Generalize ResourceUsageData gathering to be used outside of ResourceUsageOverlay
https://bugs.webkit.org/show_bug.cgi?id=153509
<rdar://problem/24354291>
Reviewed by Andreas Kling.
Source/JavaScriptCore:
- heap/Heap.h:
- heap/HeapInlines.h:
(JSC::Heap::didAllocateBlock):
(JSC::Heap::didFreeBlock):
Rename the ENABLE flag.
Source/WebCore:
- CMakeLists.txt:
- PlatformMac.cmake:
- WebCore.xcodeproj/project.pbxproj:
- page/Page.cpp:
- page/Page.h:
- page/Settings.cpp:
- page/Settings.h:
- page/ResourceUsageOverlay.cpp:
- page/ResourceUsageOverlay.h:
Add new files to the build and updated ENABLE flag name.
- page/ResourceUsageData.cpp: Added.
(WebCore::ResourceUsageData::ResourceUsageData):
- page/ResourceUsageData.h: Added.
(WebCore::MemoryCategoryInfo::MemoryCategoryInfo):
Platform agnostic resource data that may be used by multiple clients,
such as the ResourceUsageOverlay and later the Inspector.
- page/ResourceUsageThread.h: Added.
- page/ResourceUsageThread.cpp: Added.
(WebCore::ResourceUsageThread::ResourceUsageThread):
(WebCore::ResourceUsageThread::singleton):
(WebCore::ResourceUsageThread::addObserver):
(WebCore::ResourceUsageThread::removeObserver):
(WebCore::ResourceUsageThread::waitUntilObservers):
(WebCore::ResourceUsageThread::notifyObservers):
(WebCore::ResourceUsageThread::createThreadIfNeeded):
(WebCore::ResourceUsageThread::threadCallback):
(WebCore::ResourceUsageThread::threadBody):
Platform agnostic resource usage thread that can be used to gather data
into a ResourceUsageData struct on a background thread and notify observers
on the main thread. Platforms need only implement ResourceUsageThread::platformThreadBody
to populate the ResourceUsageData struct with data.
- page/cocoa/ResourceUsageOverlayCocoa.mm:
(WebCore::HistoricMemoryCategoryInfo::HistoricMemoryCategoryInfo):
(WebCore::HistoricResourceUsageData::HistoricResourceUsageData):
(WebCore::historicUsageData):
(WebCore::appendDataToHistory):
(WebCore::ResourceUsageOverlay::platformInitialize):
(WebCore::ResourceUsageOverlay::platformDestroy):
(WebCore::drawMemHistory):
(WebCore::drawMemoryPie):
(WebCore::ResourceUsageOverlay::platformDraw):
Move CPU and memory resource usage calculations to ResourceUsageThread.
The overlay adds itself as an observer, and builds its RingBuffer list
of data from notifications from the ResourceUsageThread. Renamed
some of the fields.
- page/cocoa/ResourceUsageThreadCocoa.mm: Added.
(WebCore::vmPageSize):
(WebCore::TagInfo::TagInfo):
(WebCore::pagesPerVMTag):
(WebCore::cpuUsage):
(WebCore::categoryForVMTag):
(WebCore::ResourceUsageThread::platformThreadBody):
Extracted from ResourceUsageOverlayCocoa.
- page/scrolling/ScrollingThread.cpp:
(WebCore::ScrollingThread::dispatch):
Drive-by, don't call singleton again, we already have the result.
Source/WebKit2:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences):
Rename the ENABLE flag.
Source/WTF:
- wtf/Platform.h:
Rename the ENABLE flag.
- 5:22 PM Changeset in webkit [195643] by
-
- 3 edits in trunk/Source/WebCore
Use initializers in HTMLCanvasElement
https://bugs.webkit.org/show_bug.cgi?id=153472
Reviewed by Michael Catanzaro.
Use initializers, and re-order member variables for better packing.
- html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::HTMLCanvasElement):
- html/HTMLCanvasElement.h:
- 5:16 PM Changeset in webkit [195642] by
-
- 3 edits2 adds in trunk
Setting HTMLInputElement.value to null to set its value to the empty string
https://bugs.webkit.org/show_bug.cgi?id=153519
Reviewed by Ryosuke Niwa.
Source/WebCore:
Setting HTMLInputElement.value to null to set its value to the empty string:
WebKit would previously unset the value attribute instead, which caused
it to fallback to input.defaultValue if set.
Firefox and Chrome behave correctly.
Test: fast/dom/HTMLInputElement/input-value-set-null.html
- html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::setValue):
LayoutTests:
Add a layout test to make sure that setting HTMLInputElement.value to null
actually sets its value to the empty string.
- fast/dom/HTMLInputElement/input-value-set-null-expected.txt: Added.
- fast/dom/HTMLInputElement/input-value-set-null.html: Added.
- 5:11 PM Changeset in webkit [195641] by
-
- 3 edits in trunk/Source/WebKit2
Unreviewed, rolling out r195602.
https://bugs.webkit.org/show_bug.cgi?id=153526
broke more than it fixed (Requested by thorton on #webkit).
Reverted changeset:
"REGRESSION (r194557): Keyboard shortcuts stop working after
the WKWebView is unparented and reparented"
https://bugs.webkit.org/show_bug.cgi?id=153492
http://trac.webkit.org/changeset/195602
- 5:10 PM Changeset in webkit [195640] by
-
- 2 edits in trunk/Source/JavaScriptCore
[B3] Fix control reaches end of non-void function GCC warning after r195139
https://bugs.webkit.org/show_bug.cgi?id=153426
Reviewed by Michael Catanzaro.
- b3/air/AirArg.h:
(JSC::B3::Air::Arg::cooled):
- 4:57 PM Changeset in webkit [195639] by
-
- 2 edits in trunk/Source/JavaScriptCore
testb3 and testAir should be compiled under -O0
https://bugs.webkit.org/show_bug.cgi?id=153520
Reviewed by Benjamin Poulain.
- JavaScriptCore.xcodeproj/project.pbxproj:
- 4:52 PM Changeset in webkit [195638] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, temporarily skip fast/history/page-cache-webdatabase-no-transaction-db.html
https://bugs.webkit.org/show_bug.cgi?id=153525
The test flakily crashes, skip it until I can fix it.
- 4:49 PM Changeset in webkit [195637] by
-
- 3 edits in trunk/Source/JavaScriptCore
B3's integer range analysis should know that Mul'ing two sufficiently small numbers will yield a number that still has a meaningful range
https://bugs.webkit.org/show_bug.cgi?id=153518
Reviewed by Benjamin Poulain.
Octane/encrypt had an addition overflow check that can be proved away by being sufficiently
sneaky about the analysis of adds, multiplies, and shifts.
I almost added these optimizations to the DFG integer range optimization phase. That phase is
very complicated. B3's integer range analysis is trivial. So I added it to B3. Eventually
we'll want this same machinery in the DFG also.
8% speed-up on Octane/encrypt.
- b3/B3ReduceStrength.cpp:
- b3/B3Value.cpp:
(JSC::B3::Value::dump): Dumping a constant value's name now dumps its value. This makes a huge difference for reading IR.
(JSC::B3::Value::cloneImpl):
(JSC::B3::Value::deepDump):
- 4:33 PM Changeset in webkit [195636] by
-
- 2 edits1 delete in trunk/LayoutTests
Rebaseline imported/w3c/web-platform-tests/html/semantics/interfaces.html for ios-simulator after support
for HTMLDataElement was added in r195627, removing ios-simulator-wk2 specific result.
https://bugs.webkit.org/show_bug.cgi?id=153459
Unreviewed test gardening.
- platform/ios-simulator-wk2/imported/w3c/web-platform-tests/html/semantics/interfaces-expected.txt: Removed.
- platform/ios-simulator/imported/w3c/web-platform-tests/html/semantics/interfaces-expected.txt:
- 4:29 PM Changeset in webkit [195635] by
-
- 8 edits in trunk/Source
WebKitAdditions should be able to modify derived source rules
https://bugs.webkit.org/show_bug.cgi?id=153514
Reviewed by Tim Horton.
Source/WebCore:
- DerivedSources.make:
Include WebCoreDerivedSourcesAdditions.make.
- WebCore.xcodeproj/project.pbxproj:
Pass our WebKitAdditions paths as include paths to make.
Source/WebKit2:
- Configurations/BaseTarget.xcconfig:
- Configurations/WebKit.xcconfig:
Set WEBKITADDITIONS_HEADER_SEARCH_PATHS.
- DerivedSources.make:
Move the path computation earlier and include WebKitDerivedSourcesAdditions.make.
- WebKit2.xcodeproj/project.pbxproj:
Pass our WebKitAdditions paths as include paths to make.
- 4:08 PM Changeset in webkit [195634] by
-
- 2 edits in trunk/LayoutTests
Skipping tests added with r195625 that are unsupported on ios-simulator
Unreviewed test gardening.
- platform/ios-simulator/TestExpectations:
- 4:02 PM Changeset in webkit [195633] by
-
- 2 edits in tags/Safari-602.1.17.0.2/Source/WTF
Merged r195629. rdar://problem/24322314
- 4:01 PM Changeset in webkit [195632] by
-
- 11 edits in tags/Safari-602.1.17.0.2
Merged r195582. rdar://problem/24356482
- 3:59 PM Changeset in webkit [195631] by
-
- 5 edits in tags/Safari-602.1.17.0.2/Source
Versioning.
- 3:56 PM Changeset in webkit [195630] by
-
- 1 copy in tags/Safari-602.1.17.0.2
New tag.
- 3:46 PM Changeset in webkit [195629] by
-
- 2 edits in trunk/Source/WTF
Make HashTable iterators STL iterators compatible
https://bugs.webkit.org/show_bug.cgi?id=153512
Patch by Yusuke Suzuki <Yusuke Suzuki> on 2016-01-26
Reviewed by Alex Christensen.
While r178581 makes many hash table iterators STL compatible, still several iterators are not.
This patch fixes that; inheriting std::iterator correctly to meet STL iterator requirements (like iterator_category etc.)
It could recover Windows build failure.
- wtf/HashTable.h:
- 3:22 PM Changeset in webkit [195628] by
-
- 3 edits3 adds in trunk
document.open() / write() should be prevented in beforeunload event handlers
https://bugs.webkit.org/show_bug.cgi?id=153432
Reviewed by Ryosuke Niwa.
Source/WebCore:
document.open() / write() should be prevented in beforeunload event handlers:
- https://html.spec.whatwg.org/multipage/webappapis.html#dom-document-open (step 6)
- https://html.spec.whatwg.org/multipage/webappapis.html#dom-document-write (step 3)
- https://html.spec.whatwg.org/multipage/webappapis.html#ignore-opens-during-unload-counter
- https://html.spec.whatwg.org/multipage/browsers.html#unload-a-document
Test: fast/frames/page-beforeunload-document-open.html
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::dispatchBeforeUnloadEvent):
LayoutTests:
Add a layout test to check that document.open() / write() is indeed
prevented inside 'beforeunload' event handlers.
- fast/frames/page-beforeunload-document-open-expected.txt: Added.
- fast/frames/page-beforeunload-document-open.html: Added.
- fast/frames/resources/page-beforeunload-document-open-frame.html: Added.
- 3:21 PM Changeset in webkit [195627] by
-
- 20 edits3 adds in trunk
Add support for HTMLDataElement
https://bugs.webkit.org/show_bug.cgi?id=153459
Reviewed by Ryosuke Niwa.
LayoutTests/imported/w3c:
Rebaseline existing W3C tests now that more checks are passing.
- web-platform-tests/dom/nodes/Node-cloneNode-expected.txt:
- web-platform-tests/html/dom/interfaces-expected.txt:
- web-platform-tests/html/semantics/interfaces-expected.txt:
Source/WebCore:
Add support for HTMLDataElement:
https://html.spec.whatwg.org/multipage/semantics.html#the-data-element
Firefox already supports it.
No new tests, already covered by existing tests.
- CMakeLists.txt:
- DerivedSources.cpp:
- DerivedSources.make:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
- html/HTMLDataElement.cpp: Added.
(WebCore::HTMLDataElement::create):
(WebCore::HTMLDataElement::HTMLDataElement):
- html/HTMLDataElement.h: Added.
- html/HTMLDataElement.idl: Added.
- html/HTMLElementsAllInOne.cpp:
- html/HTMLTagNames.in:
LayoutTests:
Rebaseline existing test now that HTMLDataElement is exposed on the
global Window object.
- platform/efl/js/dom/global-constructors-attributes-expected.txt:
- platform/gtk/js/dom/global-constructors-attributes-expected.txt:
- platform/mac-mavericks/js/dom/global-constructors-attributes-expected.txt:
- platform/mac-yosemite/js/dom/global-constructors-attributes-expected.txt:
- platform/mac/js/dom/global-constructors-attributes-expected.txt:
- platform/win/js/dom/global-constructors-attributes-expected.txt:
- 3:14 PM Changeset in webkit [195626] by
-
- 3 edits2 deletes in trunk
Unreviewed, rolling out r195610.
https://bugs.webkit.org/show_bug.cgi?id=153513
The test added with this change is timing out on almost every
run (Requested by ryanhaddad on #webkit).
Reverted changeset:
"Calling video.controls=true during a scrub operation cancels
scrub."
https://bugs.webkit.org/show_bug.cgi?id=153494
http://trac.webkit.org/changeset/195610
Patch by Commit Queue <commit-queue@webkit.org> on 2016-01-26
- 2:48 PM Changeset in webkit [195625] by
-
- 6 edits26 adds in trunk
History.pushState causes intense memory pressure.
https://bugs.webkit.org/show_bug.cgi?id=153435
Reviewed by Sam Weinig, Oliver Hunt, and Geoff Garen.
Source/WebCore:
Tests: fast/loader/stateobjects/pushstate-frequency-iframe.html
fast/loader/stateobjects/pushstate-frequency-with-user-gesture.html
fast/loader/stateobjects/pushstate-frequency.html
fast/loader/stateobjects/replacestate-frequency-iframe.html
fast/loader/stateobjects/replacestate-frequency-with-user-gesture.html
fast/loader/stateobjects/replacestate-frequency.html
loader/stateobjects/pushstate-size-iframe.html
loader/stateobjects/pushstate-size.html
loader/stateobjects/replacestate-size-iframe.html
loader/stateobjects/replacestate-size.html
Add restrictions on how frequently push/replaceState can be called,
as well as how much of a cumulative payload they can deliver.
- bindings/js/JSHistoryCustom.cpp:
(WebCore::JSHistory::pushState):
(WebCore::JSHistory::replaceState):
- page/History.cpp:
(WebCore::History::stateObjectAdded):
- page/History.h:
LayoutTests:
- TestExpectations: Mark some of the new tests as slow.
- fast/loader/stateobjects/pushstate-frequency-expected.txt: Added.
- fast/loader/stateobjects/pushstate-frequency-iframe-expected.txt: Added.
- fast/loader/stateobjects/pushstate-frequency-iframe.html: Added.
- fast/loader/stateobjects/pushstate-frequency-with-user-gesture-expected.txt: Added.
- fast/loader/stateobjects/pushstate-frequency-with-user-gesture.html: Added.
- fast/loader/stateobjects/pushstate-frequency.html: Added.
- fast/loader/stateobjects/replacestate-frequency-expected.txt: Added.
- fast/loader/stateobjects/replacestate-frequency-iframe-expected.txt: Added.
- fast/loader/stateobjects/replacestate-frequency-iframe.html: Added.
- fast/loader/stateobjects/replacestate-frequency-with-user-gesture-expected.txt: Added.
- fast/loader/stateobjects/replacestate-frequency-with-user-gesture.html: Added.
- fast/loader/stateobjects/replacestate-frequency.html: Added.
- fast/loader/stateobjects/resources/pushstate-iframe.html: Added.
- fast/loader/stateobjects/resources/replacestate-iframe.html: Added.
- loader/stateobjects/pushstate-size-expected.txt: Added.
- loader/stateobjects/pushstate-size-iframe-expected.txt: Added.
- loader/stateobjects/pushstate-size-iframe.html: Added.
- loader/stateobjects/pushstate-size.html: Added.
- loader/stateobjects/replacestate-size-expected.txt: Added.
- loader/stateobjects/replacestate-size-iframe-expected.txt: Added.
- loader/stateobjects/replacestate-size-iframe.html: Added.
- loader/stateobjects/replacestate-size.html: Added.
- loader/stateobjects/resources/pushstate-iframe.html: Added.
- loader/stateobjects/resources/replacestate-iframe.html: Added.
- 2:22 PM Changeset in webkit [195624] by
-
- 1 edit2 adds in trunk/LayoutTests
Rebaselining cssom/subpixel-offsetleft-top-width-height-values.html for ios-simulator
https://bugs.webkit.org/show_bug.cgi?id=152308
Unreviewed test gardening.
- platform/ios-simulator/cssom/subpixel-offsetleft-top-width-height-values-expected.txt: Added.
- 2:22 PM Changeset in webkit [195623] by
-
- 5 edits in trunk/Source/WebKit2
Add a private WKUIDelegate method for getting a presenting view controller for a WKWebView on iOS
https://bugs.webkit.org/show_bug.cgi?id=153510
Reviewed by Dan Bernstein.
- UIProcess/API/APIUIClient.h:
(API::UIClient::presentingViewController):
- UIProcess/API/Cocoa/WKUIDelegatePrivate.h:
- UIProcess/Cocoa/UIDelegate.h:
- UIProcess/Cocoa/UIDelegate.mm:
(WebKit::UIDelegate::setDelegate):
(WebKit::UIDelegate::UIClient::presentingViewController):
- 2:20 PM Changeset in webkit [195622] by
-
- 3 edits in trunk/Source/JavaScriptCore
It should be possible to disable FTL for a range like we disable DFG for a range
https://bugs.webkit.org/show_bug.cgi?id=153511
Reviewed by Geoffrey Garen.
- dfg/DFGTierUpCheckInjectionPhase.cpp:
(JSC::DFG::TierUpCheckInjectionPhase::run):
- runtime/Options.h:
- 2:07 PM Changeset in webkit [195621] by
-
- 2 edits in trunk/Source/JavaScriptCore
Shifts by an amount computed using BitAnd with a mask that subsumes the shift's own mask should be rewired around the BitAnd
https://bugs.webkit.org/show_bug.cgi?id=153505
Reviewed by Saam Barati.
Turn this: Shl(@x, BitAnd(@y, 63))
Into this: Shl(@x, @y)
It matters for Octane/crypto.
We should also stop FTL from generating such code, but even if we did that, we'd still want
this optimization in case user code did the BitAnd.
Also we can't stop the FTL from generating such code yet, because when targetting LLVM, you
must mask your shifts this way.
- b3/B3ReduceStrength.cpp:
- 2:05 PM Changeset in webkit [195620] by
-
- 24 edits2 moves2 adds in trunk/Source/JavaScriptCore
The thing that B3 uses to describe a stack slot should not be a Value
https://bugs.webkit.org/show_bug.cgi?id=153491
rdar://problem/24349446
Reviewed by Geoffrey Garen and Saam Barati.
Prior to this change, B3 represented stack slots by having a StackSlotValue that carried
two meanings:
- It represented a stack slot.
- It was a kind of Value for getting the base of the stack slot.
This seems like a good idea until you consider the following issues.
1) A Value can be killed if it is on an unreachable path, or if it has no effects and
nobody refers to it. But the FTL uses StackSlotValue to allocate space on the stack.
When it does this, it doesn't want it to be killed. It will dereference the object, so
killing it is a bug.
2) A premise of B3 is that it should be always legal to perform the following
transformation on a value:
value->replaceWithIdentity(insertionSet.insertValue(index, proc.clone(value)));
This inserts a new value just before the old one. The new value is a clone of the old
one. Then the old one is essentially deleted (anything that becomes an identity dies
shortly thereafter). Problem (1) prevents this from being legal, which breaks a major
premise of B3 IR.
3) A premise of B3 is that it should be always legal to perform the following
transformation on a value:
Before:
@42 = Thing(...)
After:
Branch(@doesntMatter, #yes, #no)
BB#yes:
@42_one = Thing(...)
Upsilon(@42_one, 42)
Jump(#done)
BB#no:
@42_two = Thing(...)
Upsilon(@42_two, 42)
Jump(#done)
BB#done:
@42 = Phi()
But prior to this change, such a transformation makes absolutely no sense for
StackSlot. It will "work" in the sense that the compiler will proceed undaunted, but
it will disable SSA fix-up for the cloned stack slot and we will end up allocating two
stack slots instead of one, and then we will assume that they both escape, which will
disable efficient stack allocation. Note that the moral equivalent of this
transformation could already happen due to tail duplication, and the only reason why
it's not a bug right now is that we happen to hoist stack slots to the root block. But
the whole point of our stack slots was supposed to be that they do not have to be
hoisted.
This change fixes this issue by splitting StackSlotValue into two things: SlotBaseValue,
which is a pure operation for getting the base address of a StackSlot, and StackSlot,
which is a representation of the actual stack slot. StackSlot cannot get duplicated and
can only be killed if it's anonymous. SlotBaseValue can be killed, moved, cloned,
hoisted, etc. Since it has no effects and it has a ValueKey, it's one of the most
permissive Values in the IR, just as one would hope (after all, there is actually zero
code that needs to execute to evaluate SlotBaseValue).
This fixes a crash that we saw with GuardMalloc and ASan. It also makes the IR a lot more
easy to reason about.
- CMakeLists.txt:
- JavaScriptCore.xcodeproj/project.pbxproj:
- b3/B3EliminateCommonSubexpressions.cpp:
- b3/B3FixSSA.cpp:
(JSC::B3::demoteValues):
(JSC::B3::fixSSA):
- b3/B3LowerToAir.cpp:
(JSC::B3::Air::LowerToAir::run):
(JSC::B3::Air::LowerToAir::effectiveAddr):
(JSC::B3::Air::LowerToAir::lower):
- b3/B3Opcode.cpp:
(WTF::printInternal):
- b3/B3Opcode.h:
- b3/B3Procedure.cpp:
(JSC::B3::Procedure::setBlockOrderImpl):
(JSC::B3::Procedure::addStackSlot):
(JSC::B3::Procedure::addAnonymousStackSlot):
(JSC::B3::Procedure::clone):
(JSC::B3::Procedure::dump):
(JSC::B3::Procedure::blocksInPostOrder):
(JSC::B3::Procedure::deleteStackSlot):
(JSC::B3::Procedure::deleteValue):
(JSC::B3::Procedure::calleeSaveRegisters):
(JSC::B3::Procedure::addStackSlotIndex):
(JSC::B3::Procedure::addValueIndex):
- b3/B3Procedure.h:
(JSC::B3::Procedure::setBlockOrder):
(JSC::B3::Procedure::StackSlotsCollection::StackSlotsCollection):
(JSC::B3::Procedure::StackSlotsCollection::size):
(JSC::B3::Procedure::StackSlotsCollection::at):
(JSC::B3::Procedure::StackSlotsCollection::operator[]):
(JSC::B3::Procedure::StackSlotsCollection::iterator::iterator):
(JSC::B3::Procedure::StackSlotsCollection::iterator::operator*):
(JSC::B3::Procedure::StackSlotsCollection::iterator::operator++):
(JSC::B3::Procedure::StackSlotsCollection::iterator::operator==):
(JSC::B3::Procedure::StackSlotsCollection::iterator::operator!=):
(JSC::B3::Procedure::StackSlotsCollection::iterator::findNext):
(JSC::B3::Procedure::StackSlotsCollection::begin):
(JSC::B3::Procedure::StackSlotsCollection::end):
(JSC::B3::Procedure::stackSlots):
(JSC::B3::Procedure::ValuesCollection::ValuesCollection):
- b3/B3ReduceStrength.cpp:
- b3/B3SlotBaseValue.cpp: Copied from Source/JavaScriptCore/b3/B3StackSlotValue.cpp.
(JSC::B3::SlotBaseValue::~SlotBaseValue):
(JSC::B3::SlotBaseValue::dumpMeta):
(JSC::B3::SlotBaseValue::cloneImpl):
(JSC::B3::StackSlotValue::~StackSlotValue): Deleted.
(JSC::B3::StackSlotValue::dumpMeta): Deleted.
(JSC::B3::StackSlotValue::cloneImpl): Deleted.
- b3/B3SlotBaseValue.h: Copied from Source/JavaScriptCore/b3/B3StackSlotValue.h.
- b3/B3StackSlot.cpp: Added.
(JSC::B3::StackSlot::~StackSlot):
(JSC::B3::StackSlot::dump):
(JSC::B3::StackSlot::deepDump):
(JSC::B3::StackSlot::StackSlot):
- b3/B3StackSlot.h: Added.
(JSC::B3::StackSlot::byteSize):
(JSC::B3::StackSlot::kind):
(JSC::B3::StackSlot::isLocked):
(JSC::B3::StackSlot::index):
(JSC::B3::StackSlot::offsetFromFP):
(JSC::B3::StackSlot::setOffsetFromFP):
(JSC::B3::DeepStackSlotDump::DeepStackSlotDump):
(JSC::B3::DeepStackSlotDump::dump):
(JSC::B3::deepDump):
- b3/B3StackSlotValue.cpp: Removed.
- b3/B3StackSlotValue.h: Removed.
- b3/B3Validate.cpp:
- b3/B3Value.cpp:
(JSC::B3::Value::effects):
(JSC::B3::Value::key):
(JSC::B3::Value::checkOpcode):
- b3/B3ValueKey.cpp:
(JSC::B3::ValueKey::materialize):
- b3/air/AirCode.cpp:
(JSC::B3::Air::Code::addBlock):
(JSC::B3::Air::Code::addStackSlot):
(JSC::B3::Air::Code::addSpecial):
- b3/air/AirCode.h:
- b3/air/AirStackSlot.cpp:
(JSC::B3::Air::StackSlot::setOffsetFromFP):
(JSC::B3::Air::StackSlot::dump):
(JSC::B3::Air::StackSlot::deepDump):
(JSC::B3::Air::StackSlot::StackSlot):
- b3/air/AirStackSlot.h:
(JSC::B3::Air::StackSlot::alignment):
(JSC::B3::Air::StackSlot::b3Slot):
(JSC::B3::Air::StackSlot::offsetFromFP):
(WTF::printInternal):
(JSC::B3::Air::StackSlot::value): Deleted.
- b3/testb3.cpp:
(JSC::B3::testStackSlot):
(JSC::B3::testStoreLoadStackSlot):
- ftl/FTLB3Compile.cpp:
- ftl/FTLB3Output.cpp:
(JSC::FTL::Output::appendTo):
(JSC::FTL::Output::lockedStackSlot):
(JSC::FTL::Output::neg):
- ftl/FTLB3Output.h:
(JSC::FTL::Output::framePointer):
(JSC::FTL::Output::constBool):
(JSC::FTL::Output::constInt32):
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::DFG::LowerDFGToLLVM::lower):
- ftl/FTLState.h:
- 1:55 PM Changeset in webkit [195619] by
-
- 1 edit3 adds in branches/safari-601-branch/Source/WebInspectorUI
Merge r195323. rdar://problem/24302730
- 1:43 PM Changeset in webkit [195618] by
-
- 2 edits in branches/safari-601.1.46-branch/Source/WebCore
Merge r195606. rdar://problem/24243317
- 1:38 PM Changeset in webkit [195617] by
-
- 2 edits in trunk/Tools
[webkitdirs] Removed check for bison, gperf, and flex.
https://bugs.webkit.org/show_bug.cgi?id=153496
Patch by Konstantin Tokarev <Konstantin Tokarev> on 2016-01-26
Reviewed by Alex Christensen.
This prerequisites are checked in WebKitCommon.cmake and don't
have to be in $PATH.
- Scripts/webkitdirs.pm:
(checkRequiredSystemConfig):
- 1:22 PM Changeset in webkit [195616] by
-
- 2 edits in trunk/Source/WebCore
Add a Dictionary overload that returns an Optional result
https://bugs.webkit.org/show_bug.cgi?id=153507
Reviewed by Tim Horton.
- bindings/js/Dictionary.h:
(WebCore::Dictionary::get):
- 1:19 PM Changeset in webkit [195615] by
-
- 6 edits in branches/safari-601.1.46-branch
Re-enable synchronous popstate event for safari-601-branch
- 1:19 PM Changeset in webkit [195614] by
-
- 8 edits8 adds in trunk
Let SVG images not taint canvases except when containing foreignObjects
https://bugs.webkit.org/show_bug.cgi?id=119639
Patch by Philip Rogers <pdr@chromium.org> on 2016-01-26
Reviewed by Brent Fulgham.
Source/WebCore:
r153876 caused SVG images to not taint canvases but the patch allowed
for subimage resources. This can be a problem if a subimage (e.g., data
uri image) contains a foreignObject which can violate security (e.g.,
visited links).
This patch updates SVGImage::hasSingleSecurityOrigin to check if the
image contains any foreignObjects or images that themselves contain
foreignObjects. SVG images without foreignObjects are allowed to not
taint canvases.
Canvas patterns are problematic because an animated SVG image can switch
between tainting and not tainting the canvas. A FIXME has been added to
solve this, and in the meantime we cause SVG images to taint patterns.
Tests: svg/as-image/svg-canvas-pattern-with-link-tainted.html
svg/as-image/svg-canvas-svg-with-feimage-with-link-tainted.html
svg/as-image/svg-canvas-svg-with-image-with-link-tainted.html
- html/canvas/CanvasPattern.cpp:
(WebCore::CanvasPattern::CanvasPattern):
(WebCore::CanvasPattern::~CanvasPattern):
- svg/SVGFEImageElement.cpp:
(WebCore::SVGFEImageElement::~SVGFEImageElement):
(WebCore::SVGFEImageElement::hasSingleSecurityOrigin):
(WebCore::SVGFEImageElement::clearResourceReferences):
- svg/SVGFEImageElement.h:
- svg/SVGImageElement.cpp:
(WebCore::SVGImageElement::create):
(WebCore::SVGImageElement::hasSingleSecurityOrigin):
(WebCore::SVGImageElement::isSupportedAttribute):
- svg/SVGImageElement.h:
- svg/graphics/SVGImage.cpp:
(WebCore::SVGImage::hasSingleSecurityOrigin):
LayoutTests:
- svg/as-image/resources/svg-with-feimage-with-link.svg: Added.
- svg/as-image/resources/svg-with-image-with-link.svg: Added.
- svg/as-image/svg-canvas-pattern-with-link-tainted-expected.txt: Added.
- svg/as-image/svg-canvas-pattern-with-link-tainted.html: Added.
- svg/as-image/svg-canvas-svg-with-feimage-with-link-tainted-expected.txt: Added.
- svg/as-image/svg-canvas-svg-with-feimage-with-link-tainted.html: Added.
- svg/as-image/svg-canvas-svg-with-image-with-link-tainted-expected.txt: Added.
- svg/as-image/svg-canvas-svg-with-image-with-link-tainted.html: Added.
- 1:14 PM Changeset in webkit [195613] by
-
- 2 edits in trunk/Tools
[webkitdirs] isCMakeBuild should be true by default
https://bugs.webkit.org/show_bug.cgi?id=153497
Patch by Konstantin Tokarev <Konstantin Tokarev> on 2016-01-26
Reviewed by Michael Catanzaro.
- Scripts/webkitdirs.pm:
(isCMakeBuild):
- 1:12 PM Changeset in webkit [195612] by
-
- 2 edits in trunk/Source/WebCore
CSSGrammar.y:1742.31-34: warning: unused value: $3
https://bugs.webkit.org/show_bug.cgi?id=153462
Reviewed by Alex Christensen.
This warning indicates that we have a memory leak. From the bison manual:
"Right-hand side symbols of a rule that explicitly triggers a syntax error via YYERROR are
not discarded automatically. As a rule of thumb, destructors are invoked only when user
actions cannot manage the memory."
Arguably a design error, but that's how it is.
- css/CSSGrammar.y.in:
- 1:09 PM Changeset in webkit [195611] by
-
- 2 edits in trunk/Source/WTF
BlockPtr needs boolean operators
https://bugs.webkit.org/show_bug.cgi?id=153506
Reviewed by Tim Horton.
- wtf/BlockPtr.h:
- 12:58 PM Changeset in webkit [195610] by
-
- 3 edits2 adds in trunk
Calling video.controls=true during a scrub operation cancels scrub.
https://bugs.webkit.org/show_bug.cgi?id=153494
Reviewed by Eric Carlson.
Source/WebCore:
Test: media/media-controls-drag-timeline-set-controls-property.html
Verify that the video.controls attribute actually changed before tearing down and
re-adding the media controls to the Shadow DOM.
- Modules/mediacontrols/mediaControlsApple.js:
(Controller.prototype.handleControlsChange):
(Controller.prototype.hasControls):
LayoutTests:
- media/media-controls-drag-timeline-set-controls-property-expected.txt: Added.
- media/media-controls-drag-timeline-set-controls-property.html: Added.
- 12:45 PM Changeset in webkit [195609] by
-
- 2 edits in trunk/Source/WebCore
[EME][Mac] Crash in [AVStreamSession addStreamDataParser:]; uncaught exception
https://bugs.webkit.org/show_bug.cgi?id=153495
Reviewed by Eric Carlson.
When AVContentKeySession is not available, fall back to pre-AVContentKeySession behavior;
namely, immediately create an AVStreamSession object in
willProvideContentKeyRequestInitializationData, rather than waiting for didProvide.
- platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:
(WebCore::SourceBufferPrivateAVFObjC::willProvideContentKeyRequestInitializationDataForTrackID):
- 12:30 PM Changeset in webkit [195608] by
-
- 2 edits in trunk/LayoutTests
Marking svg/dom/SVGScriptElement/script-change-externalResourcesRequired-while-loading.svg as flaky on ios-simulator
https://bugs.webkit.org/show_bug.cgi?id=153498
Unreviewed test gardening.
- platform/ios-simulator/TestExpectations:
- 12:09 PM Changeset in webkit [195607] by
-
- 10 edits3 adds in trunk
[iOS] Documents without an explicit width should not get fast tapping
https://bugs.webkit.org/show_bug.cgi?id=153465
Source/WebCore:
<rdar://problem/23962529>
Reviewed by Simon Fraser (and Wenson Hseih).
As the title says, documents that do not set a viewport should
not get the fast click behaviour. There were complaints that we broke
double-tap to scroll in ImageDocuments where the image was narrow and long.
The fix is to just keep a flag that tells the UI process if the
width was explicit. However, it turns out that those ImageDocuments
are given an explicit device-width, which is fine for scaling but
really should behave as auto for fast tapping. So we also need
to tell the UIProcess if the viewport arguments came from an
ImageDocument.
Test: fast/events/ios/viewport-no-width-value-allows-double-tap.html
- dom/ViewportArguments.cpp:
(WebCore::findSizeValue): Add a parameter that toggles a flag
if the size was explicitly set.
(WebCore::setViewportFeature): Remember if the width was
explicit.
- dom/ViewportArguments.h: Add a widthWasExplicit flag.
(WebCore::ViewportArguments::operator==):
Source/WebKit2:
<rdar://problem/23962529>
Reviewed by Simon Fraser (and Wenson Hseih).
As the title says, documents that do not set a viewport should
not get the fast click behaviour. There were complaints that we broke
double-tap to scroll in ImageDocuments where the image was narrow and long.
The fix is to just keep a flag that tells the UI process if the
width was explicit. However, it turns out that those ImageDocuments
are given an explicit device-width, which is fine for scaling but
really should behave as auto for fast tapping. So we also need
to tell the UIProcess if the viewport arguments came from an
ImageDocument.
- Shared/mac/RemoteLayerTreeTransaction.h: Add two new flags into
the transaction.
(WebKit::RemoteLayerTreeTransaction::viewportMetaTagWidthWasExplicit):
(WebKit::RemoteLayerTreeTransaction::setViewportMetaTagWidthWasExplicit):
(WebKit::RemoteLayerTreeTransaction::viewportMetaTagCameFromImageDocument):
(WebKit::RemoteLayerTreeTransaction::setViewportMetaTagCameFromImageDocument):
- Shared/mac/RemoteLayerTreeTransaction.mm:
(WebKit::RemoteLayerTreeTransaction::encode):
(WebKit::RemoteLayerTreeTransaction::decode):
(WebKit::RemoteLayerTreeTransaction::description):
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _didCommitLayerTree:]): Notice whether or not the viewport
width was explicit.
(-[WKWebView _allowsDoubleTapGestures]): Return yes if the width
was not explicit, or if the viewport came from an ImageDocument.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::willCommitLayerTree):
LayoutTests:
Reviewed by Simon Fraser (and Wenson Hseih).
- fast/events/ios/thin-gradient.jpg: Added.
- fast/events/ios/viewport-no-width-value-allows-double-tap-expected.txt: Added.
- fast/events/ios/viewport-no-width-value-allows-double-tap.html: Added.
- platform/ios-simulator/TestExpectations:
- 12:07 PM Changeset in webkit [195606] by
-
- 2 edits in trunk/Source/WebCore
Speculative fixes for crashing in viewportChangeAffectedPicture
https://bugs.webkit.org/show_bug.cgi?id=153450
Reviewed by Dean Jackson.
Don't attach any conditions to the removal of a picture element from
the document's HashSet. This ensures that if the condition is ever
wrong for any reason, we'll still remove the picture element on
destruction.
Fix the media query evaluation to match the other evaluations (used by
the preload scanner and HTMLImageElement). This includes using the
document element's computed style instead of our own and also null
checking the document element first. This is the likely cause of the
crashes.
- html/HTMLPictureElement.cpp:
(WebCore::HTMLPictureElement::~HTMLPictureElement):
(WebCore::HTMLPictureElement::didMoveToNewDocument):
(WebCore::HTMLPictureElement::viewportChangeAffectedPicture):
- 11:57 AM Changeset in webkit [195605] by
-
- 6 edits in trunk/Source/WebCore
Make sure a page is still PageCache-able after firing the 'pagehide' events
https://bugs.webkit.org/show_bug.cgi?id=153449
Reviewed by Andreas Kling.
Make sure a page is still PageCache-able after firing the 'pagehide'
events and abort if it isn't. This should improve robustness and it is
easy for pagehide event handlers to do things that would make a Page no
longer PageCache-able and this leads to bugs that are difficult to
investigate.
To achieve this, the 'pagehide' event firing logic was moved out of the
CachedFrame constructor. It now happens earlier in
PageCache::addIfCacheable() after checking if the page is cacheable and
before constructing the CachedPage / CachedFrames. After firing the
'pagehide' event in PageCache::addIfCacheable(), we check again that
the page is still cacheable and we abort early if it is not.
- history/CachedFrame.cpp:
(WebCore::CachedFrame::CachedFrame):
- history/PageCache.cpp:
(WebCore::setInPageCache):
(WebCore::firePageHideEventRecursively):
(WebCore::PageCache::addIfCacheable):
- history/PageCache.h:
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::commitProvisionalLoad):
- 11:33 AM Changeset in webkit [195604] by
-
- 2 edits in trunk/Source/JavaScriptCore
Remove a useless #include
https://bugs.webkit.org/show_bug.cgi?id=153474
Reviewed by Alexey Proskuryakov.
- b3/B3ReduceStrength.cpp:
- 11:28 AM Changeset in webkit [195603] by
-
- 2 edits in trunk/Source/WebCore
Rubber-stamped by Tim Horton.
Add one more bit of SPI.
- platform/spi/mac/NSSpellCheckerSPI.h:
- 11:12 AM Changeset in webkit [195602] by
-
- 3 edits in trunk/Source/WebKit2
REGRESSION (r194557): Keyboard shortcuts stop working after the WKWebView is unparented and reparented
https://bugs.webkit.org/show_bug.cgi?id=153492
<rdar://problem/24138989>
Reviewed by Dan Bernstein.
- UIProcess/ios/WKContentViewInteraction.h:
- UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView canBecomeFirstResponder]):
(-[WKContentView becomeFirstResponder]):
(-[WKContentView resignFirstResponder]):
When WKWebView is unparented, WKContentView will attempt to resignFirstResponder upwards,
first asking WKWebView. After r194557, WKWebView will accept first responder and forward
it on to the WKContentView, which will happily accept it again, despite being the view
that's trying to resign. This will cause us to completely lose first responder,
where it was actually supposed to propagate up above WKWebView to the client.
Keep track of when WKContentView is resigning first responder, and don't
let it become first responder while it is doing so, breaking the cycle.
- 11:02 AM Changeset in webkit [195601] by
-
- 2 edits in trunk/Source/WebCore
Fix build with ENABLE_DEVICE_ORIENTATION on non-iOS platforms
https://bugs.webkit.org/show_bug.cgi?id=153490
Patch by Olivier Blin <Olivier Blin> on 2016-01-26
Reviewed by Michael Catanzaro.
This has been broken since r178702, which changed the Page
argument from a pointer to a reference in logCanCachePageDecision().
No new tests since this is a build fix.
- history/PageCache.cpp:
(WebCore::canCachePage):
- 10:56 AM Changeset in webkit [195600] by
-
- 5 edits9 moves in trunk/Source
Move WebVideoFullscreenManager and related classes from iOS specific folders to cocoa folders
https://bugs.webkit.org/show_bug.cgi?id=153473
Reviewed by Eric Carlson.
Source/WebCore:
No new tests, just moving files.
- WebCore.xcodeproj/project.pbxproj:
Update due to changes to the file locations.
- platform/cocoa/WebVideoFullscreenModel.h: Renamed from Source/WebCore/platform/ios/WebVideoFullscreenModel.h.
- platform/cocoa/WebVideoFullscreenModelVideoElement.h: Renamed from Source/WebCore/platform/ios/WebVideoFullscreenModelVideoElement.h.
(WebCore::WebVideoFullscreenModelVideoElement::create):
Fix a style error by moving the opening curly brace down one line.
- platform/cocoa/WebVideoFullscreenModelVideoElement.mm: Renamed from Source/WebCore/platform/ios/WebVideoFullscreenModelVideoElement.mm.
Source/WebKit2:
- DerivedSources.make:
Add new paths.
- UIProcess/Cocoa/WebVideoFullscreenManagerProxy.h: Renamed from Source/WebKit2/UIProcess/ios/WebVideoFullscreenManagerProxy.h.
- UIProcess/Cocoa/WebVideoFullscreenManagerProxy.messages.in: Renamed from Source/WebKit2/UIProcess/ios/WebVideoFullscreenManagerProxy.messages.in.
- UIProcess/Cocoa/WebVideoFullscreenManagerProxy.mm: Renamed from Source/WebKit2/UIProcess/ios/WebVideoFullscreenManagerProxy.mm.
(WebKit::WebVideoFullscreenManagerProxy::setSeekableRangesVector):
Fix a style error by moving the opening curly brace to the same line as the for statement.
- WebKit2.xcodeproj/project.pbxproj:
Update due to changes to the file locations.
- WebProcess/cocoa/WebVideoFullscreenManager.h: Renamed from Source/WebKit2/WebProcess/ios/WebVideoFullscreenManager.h.
- WebProcess/cocoa/WebVideoFullscreenManager.messages.in: Renamed from Source/WebKit2/WebProcess/ios/WebVideoFullscreenManager.messages.in.
- WebProcess/cocoa/WebVideoFullscreenManager.mm: Renamed from Source/WebKit2/WebProcess/ios/WebVideoFullscreenManager.mm.
(WebKit::WebVideoFullscreenInterfaceContext::setSeekableRanges):
Fix a style error by adding a missing space after a comma.
- 10:46 AM Changeset in webkit [195599] by
-
- 2 edits in trunk/LayoutTests
Skipping fast/events/drag-and-drop-link-fast-multiple-times-does-not-crash.html on ios-simulator
https://bugs.webkit.org/show_bug.cgi?id=138468
Unreviewed test gardening.
- platform/ios-simulator/TestExpectations:
- 10:46 AM Changeset in webkit [195598] by
-
- 2 edits in trunk/LayoutTests
Marking inspector/codemirror/prettyprinting-css-rules.html as flaky on mac-wk1 debug
https://bugs.webkit.org/show_bug.cgi?id=153460
Unreviewed test gardening.
- platform/mac-wk1/TestExpectations:
- 10:40 AM Changeset in webkit [195597] by
-
- 4 edits2 adds1 delete in trunk
Add WebKitSystemInterface for iOS 9.2
https://bugs.webkit.org/show_bug.cgi?id=153355
Rubber-stamped by David Kilzer.
Tools:
- Scripts/copy-webkitlibraries-to-product-directory:
WebKitLibraries:
- WebKitSystemInterface.h:
- WebKitSystemInterfaceIOS.h: Removed.
- libWebKitSystemInterfaceIOSDevice9.2.a: Added.
- libWebKitSystemInterfaceIOSSimulator9.2.a: Added.
- 10:37 AM Changeset in webkit [195596] by
-
- 2 edits in trunk/Source/WebCore
Do not convert GlyphBufferAdvance to FloatSize
https://bugs.webkit.org/show_bug.cgi?id=153429
GlyphBufferAdvance is not necessaryly convertible to FloatSize.
Also, this code was doing extra work by transforming height value.
Patch by Konstantin Tokarev <Konstantin Tokarev> on 2016-01-26
Reviewed by Antti Koivisto.
No new tests needed.
- rendering/svg/SVGTextRunRenderingContext.cpp:
(WebCore::SVGGlyphToPathTranslator::extents):
- 10:35 AM Changeset in webkit [195595] by
-
- 6 edits2 adds in trunk/Source/WebCore
Enable API related to the video fullscreen layer in MediaPlayerPrivateAVFoundationObjC
also on Mac with video presentation mode support.
https://bugs.webkit.org/show_bug.cgi?id=153222
Reviewed by Eric Carlson.
No new tests. Covered by existing tests.
Introduce VideoFullscreenLayerManager to deal with the video layer when switching
between inline and fullscreen mode. We'll reuse it in other MediaPlayerPrivateInterface
implementations.
Now that MediaPlayerPrivateAVFoundationObjC's platform layer can be a WebVideoContainerLayer,
this exposes a bug in PlatformCALayerCocoa::clone() where we assumed the platform layer
is always an AVPlayerLayer if the PlatformCALayer's layer type is LayerTypeAVPlayerLayer.
Add a helper method to get an AVPlayerLayer from a PlatformCALayerCocoa (which also handles
WebVideoContainerLayer case) and use it in PlatformCALayerCocoa::clone().
- WebCore.xcodeproj/project.pbxproj:
Add VideoFullscreenLayerManager to the project.
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::MediaPlayerPrivateAVFoundationObjC):
Create m_videoFullscreenLayerManager. The video inline layer, video fullscreen layer,
and the video fullscreen frame are now managed by that class.
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayerLayer):
Just call VideoFullscreenLayerManager::setVideoLayer() to handle adding the video
layer in either the inline or fullscreen layer.
(WebCore::MediaPlayerPrivateAVFoundationObjC::destroyVideoLayer):
Call VideoFullscreenLayerManager::didDestroyVideoLayer().
(WebCore::MediaPlayerPrivateAVFoundationObjC::platformLayer):
Get the video inline layer from VideoFullscreenLayerManager.
(WebCore::MediaPlayerPrivateAVFoundationObjC::setVideoFullscreenLayer):
Call VideoFullscreenLayerManager::setVideoFullscreenLayer().
(WebCore::MediaPlayerPrivateAVFoundationObjC::setVideoFullscreenFrame):
Call VideoFullscreenLayerManager::setVideoFullscreenFrame().
(WebCore::MediaPlayerPrivateAVFoundationObjC::setVideoFullscreenMode):
Guard the iOS specific code properly.
(WebCore::MediaPlayerPrivateAVFoundationObjC::updateVideoLayerGravity):
Get the video fullscreen layer from VideoFullscreenLayerManager.
(WebCore::MediaPlayerPrivateAVFoundationObjC::requiresTextTrackRepresentation):
Ditto.
(WebCore::MediaPlayerPrivateAVFoundationObjC::syncTextTrackBounds):
Get the video fullscreen layer and video fullscreen frame from VideoFullscreenLayerManager.
(WebCore::MediaPlayerPrivateAVFoundationObjC::setTextTrackRepresentation):
Get the video fullscreen layer from VideoFullscreenLayerManager.
- platform/graphics/avfoundation/objc/VideoFullscreenLayerManager.h: Added.
(WebCore::VideoFullscreenLayerManager::videoInlineLayer):
(WebCore::VideoFullscreenLayerManager::videoFullscreenLayer):
(WebCore::VideoFullscreenLayerManager::videoFullscreenFrame):
- platform/graphics/avfoundation/objc/VideoFullscreenLayerManager.mm: Added.
(-[WebVideoContainerLayer setBounds:]):
(-[WebVideoContainerLayer setPosition:]):
WebVideoContainerLayer was moved from MediaPlayerPrivateAVFoundationObjC.mm.
(WebCore::VideoFullscreenLayerManager::create):
(WebCore::VideoFullscreenLayerManager::VideoFullscreenLayerManager):
(WebCore::VideoFullscreenLayerManager::setVideoLayer):
Code moved from MediaPlayerPrivateAVFoundationObjC::createAVPlayerLayer().
(WebCore::VideoFullscreenLayerManager::setVideoFullscreenLayer):
Code moved from MediaPlayerPrivateAVFoundationObjC::setVideoFullscreenLayer().
(WebCore::VideoFullscreenLayerManager::setVideoFullscreenFrame):
Code moved from MediaPlayerPrivateAVFoundationObjC::setVideoFullscreenFrame().
(WebCore::VideoFullscreenLayerManager::didDestroyVideoLayer):
Code moved from MediaPlayerPrivateAVFoundationObjC::destroyVideoLayer().
- platform/graphics/ca/cocoa/PlatformCALayerCocoa.h:
- platform/graphics/ca/cocoa/PlatformCALayerCocoa.mm:
(PlatformCALayerCocoa::clone):
Use the new PlatformCALayerCocoa::avPlayerLayer() method to get the AVPlayerLayer from both the
destination and source PlatformCALayers.
(PlatformCALayerCocoa::avPlayerLayer):
Return nil if the layer type is not LayerTypeAVPlayerLayer. Otherwise, return the
platform layer if it is indeed an AVPlayerLayer. If not, it should be a WebVideoContainerLayer
and we should return its sublayer which should be an AVPlayerLayer.
- 10:04 AM Changeset in webkit [195594] by
-
- 7 edits2 adds in trunk
First parameter to window.showModalDialog() should be mandatory
https://bugs.webkit.org/show_bug.cgi?id=153436
Reviewed by Youenn Fablet.
LayoutTests/imported/w3c:
Drop temporary WebKit workaround in html/dom/interfaces.html
imported W3C test. This test would previously time out without
the workaround but this is fixed now.
- web-platform-tests/html/dom/interfaces-expected.txt:
- web-platform-tests/html/dom/interfaces.html:
Source/WebCore:
Make window.showModalDialog()'s first parameter mandatory to match the
last specification containing it:
http://dev.w3.org/html5/spec-preview/user-prompts.html#dialogs-implemented-using-separate-documents
The new behavior also matches Firefox, while Chrome no longer supports
this operation.
With this change, the W3C HTML test suite no longer hangs in the middle
because it mistakenly pops up a modal dialog during testing.
Test: fast/dom/Window/showModalDialog-mandatory-parameter.html
- bindings/js/JSDOMWindowCustom.cpp:
(WebCore::JSDOMWindow::showModalDialog):
LayoutTests:
- fast/dom/Window/showModalDialog-mandatory-parameter-expected.txt: Added.
- fast/dom/Window/showModalDialog-mandatory-parameter.html: Added.
Add layout test to check that showModalDialog()'s first parameter is indeed
mandatory.
- fast/dom/null-page-show-modal-dialog-crash.html:
Update existing test now that showModalDialog()'s first parameter is
mandatory.
- 9:23 AM Changeset in webkit [195593] by
-
- 3 edits in trunk/Source/JavaScriptCore
[Win] Fix clean build after r195545.
https://bugs.webkit.org/show_bug.cgi?id=153434
- CMakeLists.txt:
- PlatformWin.cmake:
Derived sources need to be copied after the build, but everything else should be copied before.
This should fix ews issues like the one seen in bug 153473.
- 9:17 AM Changeset in webkit [195592] by
-
- 5 edits in trunk
LayoutTest media/airplay-target-availability.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=153100
<rdar://problem/24346796>
Reviewed by Daniel Bates.
Source/WebCore:
No new tests, media/airplay-target-availability.html was updated
- Modules/mediasession/WebMediaSessionManager.cpp:
(WebCore::WebMediaSessionManager::clientStateDidChange): Schedule a configuration scan if
any of the config flags have changed.
(WebCore::WebMediaSessionManager::configurePlaybackTargetMonitoring): Update logging.
LayoutTests:
- media/airplay-target-availability-expected.txt:
- media/airplay-target-availability.html:
- 9:00 AM Changeset in webkit [195591] by
-
- 2 edits in trunk/Source/WebCore
Main frame scrollbars not updated on hovering when using overlay scrollbars
https://bugs.webkit.org/show_bug.cgi?id=153304
Reviewed by Michael Catanzaro.
Legacy scrollbars were fixed in r194155, but overlay scrollbars
are not notified when they are hovered. This is because the layer
hit test in RenderView::hitTest always returns true when using
overlay scrollbars and we are returning early in such case,
ignoring the HitTestRequest::AllowFrameScrollbars flag. So, in
case of using overlay scrollbars we still need to check the
RenderView scrollbars even when the layer hit test succeeded.
- rendering/RenderView.cpp:
(WebCore::RenderView::hitTest):
- 8:15 AM Changeset in webkit [195590] by
-
- 3 edits5 adds in trunk
LayoutTest http/tests/security/xssAuditor/embed-tag-in-path-unterminated.html crashing
https://bugs.webkit.org/show_bug.cgi?id=153250
<rdar://problem/12172843>
And
<rdar://problem/24248040>
Reviewed by Alexey Proskuryakov.
Source/WebCore:
Remove an incorrect assertion that the absolute URL associated with a protection space cannot
contain consecutive forward slash (/) characters. A URL can contain consecutive forward slashes.
This also makes the invariants for CredentialStorage::findDefaultProtectionSpaceForURL() symmetric
with the invariants for WebCore::protectionSpaceMapKeyFromURL().
Tests: http/tests/loading/basic-auth-load-URL-with-consecutive-slashes.html
http/tests/xmlhttprequest/basic-auth-load-URL-with-consecutive-slashes.html
- platform/network/CredentialStorage.cpp:
(WebCore::CredentialStorage::findDefaultProtectionSpaceForURL):
LayoutTests:
The test case http/tests/xmlhttprequest/basic-auth-load-URL-with-consecutive-slashes.html was derived
from a test case written by Yongjun Zhang in <https://bugs.webkit.org/attachment.cgi?id=65189> (bug #44461).
- http/tests/loading/basic-auth-load-URL-with-consecutive-slashes-expected.txt: Added.
- http/tests/loading/basic-auth-load-URL-with-consecutive-slashes.html: Added.
- http/tests/xmlhttprequest/basic-auth-load-URL-with-consecutive-slashes-expected.txt: Added.
- http/tests/xmlhttprequest/basic-auth-load-URL-with-consecutive-slashes.html: Added.
- platform/wk2/http/tests/loading/basic-auth-load-URL-with-consecutive-slashes-expected.txt: Added.
- 8:08 AM Changeset in webkit [195589] by
-
- 13 edits in trunk
WebKitTestRunner: Credential cache is not cleared between tests
https://bugs.webkit.org/show_bug.cgi?id=153407
<rdar://problem/24280834>
Reviewed by Alexey Proskuryakov.
Source/WebKit2:
Expose SPI to call CredentialStorage::clearCredentials() on the default network storage
session to clear cached credentials.
- NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::clearCachedCredentials): Added.
- NetworkProcess/NetworkProcess.h:
- NetworkProcess/NetworkProcess.messages.in: Added message ClearCachedCredentials().
- UIProcess/API/C/WKContext.cpp:
(WKContextClearCachedCredentials): Added.
- UIProcess/API/C/WKContextPrivate.h:
- UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::clearCachedCredentials): Notify all web processes and the
network process to clear cached credentials.
- UIProcess/WebProcessPool.h:
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::clearCachedCredentials): Clear cached credentials in the default
network storage session.
- WebProcess/WebProcess.h:
- WebProcess/WebProcess.messages.in: Added message ClearCachedCredentials().
Tools:
- WebKitTestRunner/TestController.cpp:
(WTR::TestController::resetStateToConsistentValues): Call WKContextClearCachedCredentials()
to clear cached credentials.
- 8:06 AM Changeset in webkit [195588] by
-
- 54 edits3 deletes in trunk
Remove XMLHttpRequestException
https://bugs.webkit.org/show_bug.cgi?id=102698
<rdar://problem/24338476>
Reviewed by Chris Dumez.
LayoutTests/imported/w3c:
Update test result now that we throw DOMException.{ABORT, NETWORK, TIMEOUT}Error instead of XMLHttpRequestException.{ABORT, NETWORK, TIMEOUT}_ERR.
- web-platform-tests/XMLHttpRequest/send-network-error-sync-events.sub-expected.txt:
- web-platform-tests/XMLHttpRequest/send-non-same-origin.sub-expected.txt:
- web-platform-tests/XMLHttpRequest/send-redirect-bogus-sync-expected.txt:
- web-platform-tests/XMLHttpRequest/send-redirect-infinite-sync-expected.txt:
- web-platform-tests/XMLHttpRequest/xmlhttprequest-network-error-sync-expected.txt:
Source/WebCore:
Inspired by a patch by Erik Arvidsson.
As per <https://xhr.spec.whatwg.org> (21 January 2016) and <https://html.spec.whatwg.org/multipage/workers.html#dom-workerglobalscope-importscripts> (25 January 2016)
XMLHttpRequest and WorkerGlobalScope.importScripts() should throw a DOMException object instead
of a XMLHttpRequestException object when a NetworkError, AbortError, or TimeoutError occur. This
makes the behavior of WebKit more closely conform to these standards as well as the behavior of
other browsers.
- CMakeLists.txt: Remove entries for XMLHttpRequestException.idl and XMLHttpRequestException.cpp.
- DerivedSources.make: Remove entry for XMLHttpRequestException.idl.
- WebCore.order: Remove exported symbols for XMLHttpRequestException.
- WebCore.vcxproj/WebCore.vcxproj: Remove entries for JSXMLHttpRequestException.{cpp, h}, XMLHttpRequestException.{cpp, h}
- WebCore.vcxproj/WebCore.vcxproj.filters: Ditto.
- WebCore.xcodeproj/project.pbxproj: Ditto.
- bindings/js/JSExceptionBase.cpp:
(WebCore::toExceptionBase): Remove logic for XMLHttpRequestException.
- dom/DOMExceptions.in: Remove entry for XMLHttpRequestException.
- workers/WorkerGlobalScope.cpp:
(WebCore::WorkerGlobalScope::importScripts): Throw DOMException.NETWORK_ERR instead of XMLHttpRequestException.NETWORK_ERR.
- xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::createRequest): Ditto.
(WebCore::XMLHttpRequest::didFail): Throw DOMException.ABORT_ERR instead of XMLHttpRequestException.ABORT_ERR.
(WebCore::XMLHttpRequest::didReachTimeout): Throw DOMException.TIMEOUT_ERR instead of XMLHttpRequestException.TIMEOUT_ERR.
- xml/XMLHttpRequestException.cpp: Removed.
- xml/XMLHttpRequestException.h: Removed.
- xml/XMLHttpRequestException.idl: Removed.
LayoutTests:
Update test result now that we throw DOMException.{ABORT, NETWORK, TIMEOUT}Error instead of XMLHttpRequestException.{ABORT, NETWORK, TIMEOUT}_ERR.
- fast/dom/Window/resources/window-properties.js:
- fast/dom/Window/window-lookup-precedence-expected.txt:
- fast/files/apply-blob-url-to-xhr-expected.txt:
- fast/files/workers/worker-apply-blob-url-to-xhr-expected.txt:
- http/tests/appcache/non-html.xhtml:
- http/tests/appcache/simple.html:
- http/tests/contentextensions/sync-xhr-blocked-expected.txt:
- http/tests/local/fileapi/send-sliced-dragged-file-expected.txt:
- http/tests/workers/worker-importScripts-expected.txt:
- http/tests/xmlhttprequest/XMLHttpRequestException-expected.txt:
- http/tests/xmlhttprequest/XMLHttpRequestException.html:
- http/tests/xmlhttprequest/access-control-and-redirects-expected.txt:
- http/tests/xmlhttprequest/access-control-basic-denied-expected.txt:
- http/tests/xmlhttprequest/access-control-basic-get-fail-non-simple-expected.txt:
- http/tests/xmlhttprequest/access-control-basic-non-simple-deny-cached-expected.txt:
- http/tests/xmlhttprequest/access-control-basic-post-fail-non-simple-content-type-expected.txt:
- http/tests/xmlhttprequest/access-control-sandboxed-iframe-denied-expected.txt:
- http/tests/xmlhttprequest/access-control-sandboxed-iframe-denied-without-wildcard-expected.txt:
- http/tests/xmlhttprequest/connection-error-sync-expected.txt:
- http/tests/xmlhttprequest/cross-origin-no-authorization-expected.txt:
- http/tests/xmlhttprequest/origin-exact-matching-expected.txt:
- http/tests/xmlhttprequest/origin-whitelisting-https-expected.txt:
- http/tests/xmlhttprequest/origin-whitelisting-ip-addresses-with-subdomains-expected.txt:
- http/tests/xmlhttprequest/origin-whitelisting-removal-expected.txt:
- http/tests/xmlhttprequest/workers/access-control-basic-get-fail-non-simple-expected.txt:
- http/tests/xmlhttprequest/xmlhttprequest-sync-no-progress-events-expected.txt:
- http/tests/xmlhttprequest/xmlhttprequest-unsafe-redirect-expected.txt:
- platform/efl/js/dom/global-constructors-attributes-expected.txt:
- platform/gtk/fast/dom/Window/window-lookup-precedence-expected.txt:
- platform/gtk/js/dom/global-constructors-attributes-expected.txt:
- platform/mac-mavericks/js/dom/global-constructors-attributes-expected.txt:
- platform/mac-yosemite/js/dom/global-constructors-attributes-expected.txt:
- platform/mac/fast/dom/Window/window-lookup-precedence-expected.txt:
- platform/mac/js/dom/global-constructors-attributes-expected.txt:
- platform/win/TestExpectations:
- platform/win/js/dom/global-constructors-attributes-expected.txt:
- 7:47 AM Changeset in webkit [195587] by
-
- 2 edits in trunk/Tools
kill-old-processes: allow to specify on the environment of the bot a list of process that should be killed.
https://bugs.webkit.org/show_bug.cgi?id=153483
Reviewed by Csaba Osztrogonác.
- BuildSlaveSupport/kill-old-processes:
(main): Allow to specify extra tasks to kill via the environment variable WEBKITBOT_TASKSTOKILL
- 6:48 AM WebKitGTK/Gardening/Calendar edited by
- (diff)
- 1:45 AM Changeset in webkit [195586] by
-
- 5 edits2 adds in trunk
[GTK] WebProcess crashes when quickly attempting many DnD operations
https://bugs.webkit.org/show_bug.cgi?id=138468
Reviewed by Michael Catanzaro.
Source/WebKit2:
Do not allow different DnD operations over the same element at the
same time, so that any new attempt to DnD an element happening before
a previous attempt has ended will take precedence, cancelling the older
operation before going ahead with the new one.
This is consistent with how WebCore::EventHandler handles DnD operations,
preventing the web process from crashing in scenarios where the user might
try to perform many DnD operations over the same element very quickly.
- UIProcess/gtk/DragAndDropHandler.cpp:
(WebKit::DragAndDropHandler::DragAndDropHandler): Initialized new member.
(WebKit::DragAndDropHandler::startDrag): Ensure a previous DnD operation
is cancelled before handling the new one that has just started.
(WebKit::DragAndDropHandler::fillDragData): Protect against calling this
function from webkitWebViewBaseDragDataGet for already cancelled operations.
(WebKit::DragAndDropHandler::finishDrag): Protect against calling this
function from webkitWebViewBaseDragEnd for already cancelled operations.
- UIProcess/gtk/DragAndDropHandler.h:
LayoutTests:
New test added to check that the web process does not crash when multiple
DnD operations are quickly attempted over the same draggable element.
- fast/events/drag-and-drop-link-fast-multiple-times-does-not-crash-expected.txt: Added.
- fast/events/drag-and-drop-link-fast-multiple-times-does-not-crash.html: Added.
Added the new test to the failure expectations for mac-wk2, as there's no
suitable implementation of eventSender in place yet (see bug 42194).
- platform/mac-wk2/TestExpectations: Added failure expectation for the new test.
- 1:45 AM WebKitGTK/2.10.x edited by
- (diff)
- 12:17 AM Changeset in webkit [195585] by
-
- 12 edits1 add in trunk/Source
FTLB3Output should maintain good block order like the LLVM one does
https://bugs.webkit.org/show_bug.cgi?id=152222
Reviewed by Geoffrey Garen.
Source/JavaScriptCore:
This fixes FTLB3Output to emit an ordered B3 IR. This makes inspecting IR *a lot* easier.
It will also be a performance win whenever we use range-based data structures for
liveness.
Also two small other changes:
- Added some more dumping in integer range optimization phase.
- Refined the disassembler's printing of instruction width suffixes so that "jzl" is not a thing. It was using "l" as the suffix because jumps take a 32-bit immediate.
- b3/B3Procedure.cpp:
(JSC::B3::Procedure::addBlock):
(JSC::B3::Procedure::setBlockOrderImpl):
(JSC::B3::Procedure::clone):
- b3/B3Procedure.h:
(JSC::B3::Procedure::frontendData):
(JSC::B3::Procedure::setBlockOrder):
- dfg/DFGIntegerRangeOptimizationPhase.cpp:
- disassembler/udis86/udis86_syn-att.c:
(ud_translate_att):
- ftl/FTLB3Output.cpp:
(JSC::FTL::Output::initialize):
(JSC::FTL::Output::newBlock):
(JSC::FTL::Output::applyBlockOrder):
(JSC::FTL::Output::appendTo):
- ftl/FTLB3Output.h:
(JSC::FTL::Output::setFrequency):
(JSC::FTL::Output::insertNewBlocksBefore):
(JSC::FTL::Output::callWithoutSideEffects):
(JSC::FTL::Output::newBlock): Deleted.
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::DFG::LowerDFGToLLVM::lower):
Source/WTF:
In the FTL we need to be able to construct a list by inserting elements before other
specific elements. We didn't already have a scalable way to do this, so this adds such a
data structure to WTF. This also has changes to SentinelLinkedList to make it support
these kinds of insertions.
- WTF.xcodeproj/project.pbxproj:
- wtf/OrderMaker.h: Added.
(WTF::OrderMaker::Node::Node):
(WTF::OrderMaker::OrderMaker):
(WTF::OrderMaker::prepend):
(WTF::OrderMaker::append):
(WTF::OrderMaker::insertBefore):
(WTF::OrderMaker::insertAfter):
(WTF::OrderMaker::iterator::iterator):
(WTF::OrderMaker::iterator::operator*):
(WTF::OrderMaker::iterator::operator++):
(WTF::OrderMaker::iterator::operator==):
(WTF::OrderMaker::iterator::operator!=):
(WTF::OrderMaker::begin):
(WTF::OrderMaker::end):
(WTF::OrderMaker::newNode):
- wtf/SentinelLinkedList.h:
(WTF::BasicRawSentinelNode::isOnList):
(WTF::BasicRawSentinelNode<T>::remove):
(WTF::BasicRawSentinelNode<T>::prepend):
(WTF::BasicRawSentinelNode<T>::append):
(WTF::RawNode>::SentinelLinkedList):
(WTF::RawNode>::push):
(WTF::RawNode>::append):
(WTF::RawNode>::remove):
(WTF::RawNode>::prepend):
(WTF::RawNode>::isOnList):
Jan 25, 2016:
- 11:32 PM Changeset in webkit [195584] by
-
- 5 edits in trunk/Source/WebCore
WebCoreJSBuiltins do not use to do conditional include
https://bugs.webkit.org/show_bug.cgi?id=153306
Reviewed by Alex Christensen.
Removing compilation guards as builtin generator adds them in the files themselves.
Fixing MediaDevices.js to generate MEDIA_STREAM compilation guard.
No change in behavior.
- Modules/mediastream/MediaDevices.js: Changing @optional to @conditional.
- Modules/mediastream/NavigatorUserMedia.js: Making it @conditional.
- bindings/js/WebCoreJSBuiltins.cpp:
- bindings/js/WebCoreJSBuiltins.h:
- 11:28 PM Changeset in webkit [195583] by
-
- 3 edits4 adds in trunk/LayoutTests
imported/w3c/web-platform-tests/streams-api/readable-streams/garbage-collection.html asserts frequently
https://bugs.webkit.org/show_bug.cgi?id=152436
Reviewed by Alexey Proskuryakov.
LayoutTests/imported/w3c:
Adding temporary tests that splits garbage collection readable stream
tests in worker and window mode.
- web-platform-tests/streams-api/readable-streams/garbage-collection-1-expected.txt: Added.
- web-platform-tests/streams-api/readable-streams/garbage-collection-1.html: Added.
- web-platform-tests/streams-api/readable-streams/garbage-collection-2-expected.txt: Added.
- web-platform-tests/streams-api/readable-streams/garbage-collection-2.html: Added.
LayoutTests:
- platform/mac/TestExpectations: Marked imported/w3c/web-platform-tests/streams-api/readable-streams/garbage-collection.html as crash/pass.
- 10:12 PM Changeset in webkit [195582] by
-
- 11 edits in trunk
Fix internal Windows build
https://bugs.webkit.org/show_bug.cgi?id=153469
Patch by Alex Christensen <achristensen@webkit.org> on 2016-01-25
Reviewed by Brent Fulgham.
.:
- Source/cmake/WebKitMacros.cmake:
Pass the GPERF_EXECUTABLE that we found to make-hash-tools.pl.
Source/WebCore:
- CMakeLists.txt:
Pass the GPERF_EXECUTABLE that we found to perl scripts so they can use it instead of just calling gperf.
This is needed for builds where gperf is not in the PATH.
- DerivedSources.make:
Pass "gperf" as the gperf command to retain existing functionality on mac.
- bindings/scripts/preprocess-idls.pl:
(CygwinPathIfNeeded):
- bindings/scripts/preprocessor.pm:
(applyPreprocessor):
Add /cygdrive/c/cygwin/bin to the PATH before calling cygpath.
This is needed for builds where we are using cygwin, but C:/cygwin/bin is not in the PATH.
- css/makeSelectorPseudoClassAndCompatibilityElementMap.py:
- css/makeSelectorPseudoElementsMap.py:
- css/makeprop.pl:
- platform/network/create-http-header-name-table:
Use the gperf executable passed in as a command line parameter if it is given.
- 9:43 PM Changeset in webkit [195581] by
-
- 7 edits9 adds in trunk
[ES6] Arrow function syntax. Arrow function specific features. Lexical bind "arguments"
https://bugs.webkit.org/show_bug.cgi?id=145132
Patch by Skachkov Oleksandr <gskachkov@gmail.com> on 2016-01-25
Reviewed by Saam Barati.
Source/JavaScriptCore:
Added support of ES6 arrow function specific feature, lexical bind of arguments.
http://www.ecma-international.org/ecma-262/6.0/#sec-arrow-function-definitions-runtime-semantics-evaluation
'arguments' variable in arrow function must resolve to a binding in a lexically enclosing environment.
In srict mode it points to arguments object, and in non-stric mode it points to arguments object or varible
with name 'arguments' if it was declared.
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::BytecodeGenerator):
- parser/Parser.h:
(JSC::Scope::Scope):
(JSC::Scope::setSourceParseMode):
(JSC::Scope::isArrowFunction):
(JSC::Scope::collectFreeVariables):
(JSC::Scope::setIsArrowFunction):
- tests/es6.yaml:
- tests/stress/arrowfunction-lexical-bind-arguments-non-strict-1.js: Added.
- tests/stress/arrowfunction-lexical-bind-arguments-non-strict-2.js: Added.
- tests/stress/arrowfunction-lexical-bind-arguments-strict.js: Added.
Source/WebInspectorUI:
Current patch is implementing lexical bind of arguments, so in this callback we need
to return to ordinary function.
- UserInterface/Base/Object.js:
(WebInspector.Object.singleFireEventListener.let.wrappedCallback):
(WebInspector.Object.singleFireEventListener):
LayoutTests:
- js/arrowfunction-lexical-bind-arguments-non-strict-expected.txt: Added.
- js/arrowfunction-lexical-bind-arguments-non-strict.html: Added.
- js/arrowfunction-lexical-bind-arguments-strict-expected.txt: Added.
- js/arrowfunction-lexical-bind-arguments-strict.html: Added.
- js/script-tests/arrowfunction-lexical-bind-arguments-non-strict.js: Added.
- js/script-tests/arrowfunction-lexical-bind-arguments-strict.js: Added.
- 9:41 PM Changeset in webkit [195580] by
-
- 3 edits in trunk/Source/WebCore
DisplayList items can log paths now
https://bugs.webkit.org/show_bug.cgi?id=153417
Reviewed by Zalan Bujtas.
Now that Path supports TextStream logging, clean up its output a little and
enable dumping of Paths in DisplayListItems.
- platform/graphics/Path.cpp:
(WebCore::operator<<):
- platform/graphics/displaylists/DisplayListItems.cpp:
(WebCore::DisplayList::operator<<):
- 9:40 PM Changeset in webkit [195579] by
-
- 4 edits in trunk
Give the layout test results file a <title> showing the date and time the tests were run
https://bugs.webkit.org/show_bug.cgi?id=153187
Reviewed by Darin Adler.
Tools:
Include a 'date' property in the JSON with the date and time the tests completed.
- Scripts/webkitpy/layout_tests/models/test_run_results.py:
(summarize_results):
LayoutTests:
Generate a <title> element from the 'date' property in the JSON.
- fast/harness/results.html:
- 8:01 PM Changeset in webkit [195578] by
-
- 5 edits in trunk/Source/JavaScriptCore
[JSC] We should never use x18 on iOS ARM64
https://bugs.webkit.org/show_bug.cgi?id=153461
Patch by Benjamin Poulain <bpoulain@apple.com> on 2016-01-25
Reviewed by Filip Pizlo.
The register x18 is reserved in the iOS variant of the ARM64 ABI.
The weird thing is: if you use it, its value will change completely
randomly. It looks like it is changed by the system on interrupts.
This patch adds x18 to the reserved register and add assertions
to the assembler to prevent similar problems in the future.
- assembler/ARM64Assembler.h:
(JSC::ARM64Assembler::xOrSp):
(JSC::ARM64Assembler::xOrZr):
- assembler/AbstractMacroAssembler.h:
(JSC::isIOS): Deleted.
- assembler/AssemblerCommon.h:
(JSC::isIOS):
- jit/RegisterSet.cpp:
(JSC::RegisterSet::reservedHardwareRegisters):
- 7:13 PM Changeset in webkit [195577] by
-
- 2 edits in trunk/Source/WebCore
Fix the comment.
- rendering/style/RenderStyle.h:
- 7:12 PM Changeset in webkit [195576] by
-
- 2 edits in trunk/Source/JavaScriptCore
Unreviewed, rolling out r195550.
https://bugs.webkit.org/show_bug.cgi?id=153471
broke animometer bot (and now we have crash logs!) (Requested
by kling on #webkit).
Reverted changeset:
"Restore CodeBlock jettison code Geoff accidentally removed"
https://bugs.webkit.org/show_bug.cgi?id=151241
http://trac.webkit.org/changeset/195550
- 6:57 PM Changeset in webkit [195575] by
-
- 3 edits in trunk/Source/JavaScriptCore
MarkedSpace should have more precise allocators.
<https://webkit.org/b/153448>
<rdar://problem/23897477>
Reviewed by Geoffrey Garen.
The four classes responsible for the bulk of MarkedBlock allocations today are:
- FunctionCodeBlock (640 bytes)
- UnlinkedFunctionCodeBlock (304 bytes)
- FunctionExecutable (168 bytes)
- UnlinkedFunctionExecutable (144 bytes)
Due to the size class distribution in MarkedSpace, we've been wasting quite a lot
of heap space on these objects. Our "precise" allocators allowed allocation sizes
in 16-byte increments up to 128 bytes, but after that point, we'd only allocate
in 256-byte size increments.
Thus each instance of those classes would waste space as follows:
- FunctionCodeBlock (768-byte cell, 128 bytes wasted)
- UnlinkedFunctionCodeBlock (512-byte cell, 208 bytes wasted)
- FunctionExecutable(256-byte cell, 88 bytes wasted)
- UnlinkedFunctionExecutable(256-byte cell, 112 bytes wasted)
This patch raises the limit for precise allocations from 128 to 768, allowing us
to allocate these objects with far better space efficiency.
The cost of this is 7kB worth of MarkedAllocators and 70 (~2x) more allocators to
iterate whenever we iterate all the allocators.
- heap/MarkedSpace.h:
- heap/MarkedSpace.cpp:
(JSC::MarkedSpace::MarkedSpace):
(JSC::MarkedSpace::resetAllocators):
(JSC::MarkedSpace::forEachAllocator):
(JSC::MarkedSpace::isPagedOut):
- 6:18 PM Changeset in webkit [195574] by
-
- 13 edits2 moves in trunk/Source
Add support for DataDetectors in WK (iOS).
https://bugs.webkit.org/show_bug.cgi?id=152989
rdar://problem/22855960
Reviewed by Tim Horton.
Source/WebCore:
Adding new helper functions for data detection related tasks.
The patch also fixes a bug when creating DOM ranges from DDQueryRange
spanning multiple fragments.
- editing/cocoa/DataDetection.h:
- editing/cocoa/DataDetection.mm:
(WebCore::DataDetection::isDataDetectorLink):
(WebCore::DataDetection::dataDetectorIdentifier):
(WebCore::detectItemAtPositionWithRange):
(WebCore::DataDetection::detectItemAroundHitTestResult):
(WebCore::resultIsURL):
(WebCore::removeResultLinksFromAnchor):
(WebCore::searchForLinkRemovingExistingDDLinks):
(WebCore::DataDetection::detectContentInRange):
Source/WebKit2:
Moving InteractionInformationAtPosition files to platform folder,
since this is only used on iOS and changing from .cpp to .mm.
The structure is extended to include data detection specific fields
and the relevant encode/decode functions have been updated to
handle the new fields.
The patch also adds a new WKUIDelegatePrivate method to allow
the client to provide additional context for data detection actions.
- Platform/spi/ios/UIKitSPI.h:
- Shared/InteractionInformationAtPosition.cpp: Removed.
- Shared/InteractionInformationAtPosition.h: Removed.
- Shared/ios/InteractionInformationAtPosition.h: Copied from Shared/InteractionInformationAtPosition.h.
- Shared/ios/InteractionInformationAtPosition.mm: Copied from Shared/InteractionInformationAtPosition.cpp.
(WebKit::InteractionInformationAtPosition::encode):
(WebKit::InteractionInformationAtPosition::decode):
- UIProcess/API/Cocoa/WKUIDelegatePrivate.h:
- UIProcess/WebPageProxy.h:
- UIProcess/ios/WKActionSheetAssistant.h:
- UIProcess/ios/WKActionSheetAssistant.mm:
(-[WKActionSheetAssistant showDataDetectorsSheet]):
- UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView actionSheetAssistantDidStopInteraction:]):
(-[WKContentView dataDetectionContextForActionSheetAssistant:]):
(-[WKContentView selectedTextForActionSheetAssistant:]):
(-[WKContentView _dataForPreviewItemController:atPosition:type:]):
- UIProcess/ios/WebPageProxyIOS.mm:
- WebKit2.xcodeproj/project.pbxproj:
- WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::getPositionInformation):
- 5:56 PM Changeset in webkit [195573] by
-
- 29 edits1 add in trunk/LayoutTests
[GTK] Unreviewed GTK gardening.
Skip all inspector/sampling-profiler tests meanwhile the feature is not enabled on the GTK+ port.
Report and mark a new regression on test inspector/dom-debugger/node-removed.html timing out.
Rebaseline a bunch of tests after r194847.
- platform/gtk/TestExpectations:
- platform/gtk/fast/forms/auto-fill-button/input-auto-fill-button-expected.txt: Rebaseline after r194847.
- platform/gtk/fast/forms/auto-fill-button/input-auto-fill-button-expected.png: Added. Rebaseline after r194847.
- platform/gtk/tables/mozilla/bugs/bug1188-expected.png: Rebaseline after r194847.
- platform/gtk/tables/mozilla/bugs/bug1188-expected.txt: Rebaseline after r194847.
- platform/gtk/tables/mozilla/bugs/bug18359-expected.png: Rebaseline after r194847.
- platform/gtk/tables/mozilla/bugs/bug18359-expected.txt: Rebaseline after r194847.
- platform/gtk/tables/mozilla/bugs/bug2479-3-expected.png: Rebaseline after r194847.
- platform/gtk/tables/mozilla/bugs/bug2479-3-expected.txt: Rebaseline after r194847.
- platform/gtk/tables/mozilla/bugs/bug2479-4-expected.png: Rebaseline after r194847.
- platform/gtk/tables/mozilla/bugs/bug2479-4-expected.txt: Rebaseline after r194847.
- platform/gtk/tables/mozilla/bugs/bug29326-expected.png: Rebaseline after r194847.
- platform/gtk/tables/mozilla/bugs/bug29326-expected.txt: Rebaseline after r194847.
- platform/gtk/tables/mozilla/bugs/bug33855-expected.png: Rebaseline after r194847.
- platform/gtk/tables/mozilla/bugs/bug33855-expected.txt: Rebaseline after r194847.
- platform/gtk/tables/mozilla/bugs/bug4382-expected.png: Rebaseline after r194847.
- platform/gtk/tables/mozilla/bugs/bug4382-expected.txt: Rebaseline after r194847.
- platform/gtk/tables/mozilla/bugs/bug96334-expected.png: Rebaseline after r194847.
- platform/gtk/tables/mozilla/bugs/bug96334-expected.txt: Rebaseline after r194847.
- platform/gtk/tables/mozilla/core/margins-expected.png: Rebaseline after r194847.
- platform/gtk/tables/mozilla/core/margins-expected.txt: Rebaseline after r194847.
- platform/gtk/tables/mozilla/dom/tableDom-expected.png: Rebaseline after r194847.
- platform/gtk/tables/mozilla/dom/tableDom-expected.txt: Rebaseline after r194847.
- platform/gtk/tables/mozilla_expected_failures/bugs/bug2479-5-expected.png: Rebaseline after r194847.
- platform/gtk/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt: Rebaseline after r194847.
- platform/gtk/tables/mozilla_expected_failures/bugs/bug92647-1-expected.png: Rebaseline after r194847.
- platform/gtk/tables/mozilla_expected_failures/bugs/bug92647-1-expected.txt: Rebaseline after r194847.
- platform/gtk/transforms/2d/zoom-menulist-expected.png: Rebaseline after r194847.
- platform/gtk/transforms/2d/zoom-menulist-expected.txt: Rebaseline after r194847.
- 5:56 PM WebKitGTK/Gardening/Calendar edited by
- (diff)
- 5:19 PM WebKitGTK/Gardening/Calendar edited by
- sign up for tomorrow since I missed last week too (diff)
- 4:43 PM Changeset in webkit [195572] by
-
- 2 edits in branches/safari-601.1.46-branch/LayoutTests
Merge r195492. rdar://problem/24001780
- 4:43 PM Changeset in webkit [195571] by
-
- 6 edits8 adds in branches/safari-601.1.46-branch
Merge r195477. rdar://problem/24001780
- 4:43 PM Changeset in webkit [195570] by
-
- 4 edits in branches/safari-601.1.46-branch/Source/WebKit2
Merge r195424. rdar://problem/24222456
- 4:43 PM Changeset in webkit [195569] by
-
- 2 edits in branches/safari-601.1.46-branch/Source/WebCore
Merge r195393. rdar://problem/24042909
- 4:43 PM Changeset in webkit [195568] by
-
- 3 edits2 adds in branches/safari-601.1.46-branch
Merge r195150. rdar://problem/24208162
- 4:35 PM Changeset in webkit [195567] by
-
- 3 edits in trunk/Source/WebCore
Remove broken cache from CSSFontFaceSource
https://bugs.webkit.org/show_bug.cgi?id=153440
Reviewed by Simon Fraser.
This cache has been broken since 2013 (r158085). Given we didn't notice a perf
hit when it broke, and the fact it's been broken for years, it clearly isn't
necessary.
https://bugs.webkit.org/show_bug.cgi?id=153414 consists of a fairly invasive
change to CSSFontFaceSource; this patch includes a working version of this
cache, along with an easy way to enable/disable it (to measure possible perf
changes).
This patch is a short-term cleanup patch in the mean time until the above
invasive change gets landed.
No new tests because there is no behavior (or performance!) change.
- css/CSSFontFaceSource.cpp:
(WebCore::CSSFontFaceSource::font):
(WebCore::CSSFontFaceSource::~CSSFontFaceSource): Deleted.
(WebCore::CSSFontFaceSource::pruneTable): Deleted.
(WebCore::CSSFontFaceSource::fontLoaded): Deleted.
- css/CSSFontFaceSource.h:
- 4:25 PM Changeset in webkit [195566] by
-
- 3 edits in trunk/Source/WebInspectorUI
Web Inspector: Have top-level ScriptTimelineDataGridNode events show sample counts
https://bugs.webkit.org/show_bug.cgi?id=153447
<rdar://problem/24334137>
Reviewed by Joseph Pecoraro.
- UserInterface/Models/ScriptTimelineRecord.js:
(WebInspector.ScriptTimelineRecord):
(WebInspector.ScriptTimelineRecord.prototype.get profile):
(WebInspector.ScriptTimelineRecord.prototype.get callCount):
(WebInspector.ScriptTimelineRecord.prototype.isGarbageCollection):
(WebInspector.ScriptTimelineRecord.prototype._initializeProfileFromPayload):
- UserInterface/Views/ScriptTimelineDataGridNode.js:
(WebInspector.ScriptTimelineDataGridNode.prototype.get data):
- 4:16 PM Changeset in webkit [195565] by
-
- 2 edits in trunk/Source/WebCore
Try to fix the simulator build.
- platform/spi/cocoa/DataDetectorsCoreSPI.h:
- 3:54 PM Changeset in webkit [195564] by
-
- 5 edits2 copies in trunk/Source/WebCore
Roll back in r195559 with a build fix.
- WebCore.xcodeproj/project.pbxproj:
- editing/cocoa/DataDetection.mm:
- platform/cocoa/DataDetectorsCoreSoftLink.mm: Added.
- platform/cocoa/DataDetectorsCoreSoftLink.h: Added.
- platform/spi/cocoa/DataDetectorsCoreSPI.h:
- 3:44 PM Changeset in webkit [195563] by
-
- 2 edits in trunk/Source/JavaScriptCore
Fix the comment about FTL_USES_B3.
- dfg/DFGCommon.h:
- 3:41 PM Changeset in webkit [195562] by
-
- 2 edits in trunk/Source/JavaScriptCore
Switch FTL to B3 on X86_64/Mac
https://bugs.webkit.org/show_bug.cgi?id=153445
Rubber stamped by Geoffrey Garen.
This finally switches from LLVM to B3 in the FTL on X86_64 on the Mac. We recommend that other
X86_64 platforms make the switch as well. We will be focusing our performance work on B3 rather
than LLVM in the future. ARM64 support is also coming soon, so we will be able to remove FTL
LLVM code once that lands.
Right now this mostly appears as perf-neutral on the major tests. However, it does have the
following immediate benefits:
- Dramatic reduction in FTL compile times, on the order of 5x-10x. This means huge speed-ups in shorter-running tests like V8Spider (21%) and JSRegress (8%).
- It makes the FTL simpler and more robust because we don't have to do stackmap section parsing. This makes it easier to add new FTL features. We are already working on features, like the sampling profiler, which will only have a FTL B3 implementation.
- Speed-ups on some throughput benchmarks like mandreel, richards, imaging-gaussian-blur. It's still a slow down on other throughput benchmarks, though.
We started writing B3 in October, so it's pretty awesome that the throughput of the code it
generates is already on par with LLVM.
This does not fundamentally change how the FTL works. FTL was built to lower DFG IR to a C-like
SSA IR, and then rely on powerful SSA optimizations and comprehensive instruction selection and
register allocation to turn that code into something that runs fast. B3 also has a C-like SSA
IR, has an instruction selector that is in some ways more powerful than LLVM's (B3 does global
instruction selection rather than block-local like LLVM), and it has a register allocator that
is in some ways more powerful also (B3 uses IRC, a mature graph coloring allocator, while LLVM
does not do graph coloring). We expect FTL B3's performance to improve a lot after we turn it
on and can focus our efforts on tuning it.
I didn't find any test regressions after running both JSC tests and layout tests. Basic
browsing still works. JetStream performance difference is within the margin of error. EWS is
happy.
- dfg/DFGCommon.h:
- 3:38 PM Changeset in webkit [195561] by
-
- 4 edits2 deletes in trunk/Source/WebCore
Unreviewed, rolling out r195559.
https://bugs.webkit.org/show_bug.cgi?id=153458
This change broke the iOS build (Requested by ryanhaddad on
#webkit).
Reverted changeset:
"Fix the ASAN build."
http://trac.webkit.org/changeset/195559
Patch by Commit Queue <commit-queue@webkit.org> on 2016-01-25
- 3:33 PM Changeset in webkit [195560] by
-
- 8 edits in trunk/Source/WebCore
Resolving direction and writing mode properties should not mutate document
https://bugs.webkit.org/show_bug.cgi?id=153446
Reviewed by Andreas Kling.
Replace directionSetOnDocumentElement/writingModeSetOnDocumentElement document flags them with style flags.
- css/StyleBuilderCustom.h:
(WebCore::StyleBuilderCustom::applyValueDirection):
(WebCore::StyleBuilderCustom::resetEffectiveZoom):
(WebCore::StyleBuilderCustom::applyValueWebkitWritingMode):
(WebCore::StyleBuilderCustom::applyValueWebkitTextOrientation):
- css/StyleResolver.cpp:
(WebCore::StyleResolver::styleForElement):
- dom/Document.cpp:
(WebCore::Document::Document):
- dom/Document.h:
(WebCore::Document::markers):
(WebCore::Document::directionSetOnDocumentElement): Deleted.
(WebCore::Document::writingModeSetOnDocumentElement): Deleted.
(WebCore::Document::setDirectionSetOnDocumentElement): Deleted.
(WebCore::Document::setWritingModeSetOnDocumentElement): Deleted.
- rendering/RenderBox.cpp:
(WebCore::RenderBox::styleDidChange):
- rendering/style/RenderStyle.h:
- style/StyleResolveForDocument.cpp:
(WebCore::Style::resolveForDocument):
- 3:12 PM Changeset in webkit [195559] by
-
- 4 edits2 adds in trunk/Source/WebCore
Fix the ASAN build.
- WebCore.xcodeproj/project.pbxproj:
- editing/cocoa/DataDetection.mm:
- platform/cocoa/DataDetectorsCoreSoftLink.mm: Added.
- platform/cocoa/DataDetectorsCoreSoftLink.h: Added.
- platform/spi/cocoa/DataDetectorsCoreSPI.h:
- 3:08 PM Changeset in webkit [195558] by
-
- 13 edits in trunk
Unreviewed, rolling out r195543.
https://bugs.webkit.org/show_bug.cgi?id=153451
regressed performance of test bots by ~6% (Requested by dydz
on #webkit).
Reverted changeset:
"WebKitTestRunner: Credential cache is not cleared between
tests"
https://bugs.webkit.org/show_bug.cgi?id=153407
http://trac.webkit.org/changeset/195543
- 2:37 PM Changeset in webkit [195557] by
-
- 2 edits in trunk/Tools
Failing to upload to flakiness dashboard should not be a hard error
https://bugs.webkit.org/show_bug.cgi?id=153444
<rdar://problem/22146294>
Reviewed by Alexey Proskuryakov.
- Scripts/webkitpy/layout_tests/controllers/manager.py:
(Manager._upload_json_files): If JSON file is not generated, do not try to upload it.
- 2:35 PM Changeset in webkit [195556] by
-
- 2 edits in trunk/LayoutTests
Marking imported/w3c/indexeddb/keyorder-private.html as flaky on mac-wk1
https://bugs.webkit.org/show_bug.cgi?id=153438
Unreviewed test gardening.
- platform/mac-wk1/TestExpectations:
- 2:13 PM Changeset in webkit [195555] by
-
- 2 edits in trunk/Source/WebKit2
[WK2][NetworkCache] Enable speculative revalidation
https://bugs.webkit.org/show_bug.cgi?id=153443
<rdar://problem/23092196>
Reviewed by Antti Koivisto.
Enable speculative revalidation to better evaluate performance and
robustness.
- UIProcess/Cocoa/WebProcessPoolCocoa.mm:
(WebKit::registerUserDefaultsIfNeeded):
- 2:07 PM Changeset in webkit [195554] by
-
- 2 edits in trunk/LayoutTests
Marking imported/w3c/web-platform-tests/XMLHttpRequest/getresponseheader-chunked-trailer.htm as flaky
on ios-simulator, removing flaky expectation that was incorrectly added for a different WPT LayoutTest.
https://bugs.webkit.org/show_bug.cgi?id=153371
Unreviewed test gardening.
- platform/ios-simulator/TestExpectations:
- 1:40 PM Changeset in webkit [195553] by
-
- 2 edits in trunk/Source/WebKit/mac
Build fix.
- WebView/WebHTMLView.mm:
(-[WebHTMLView initWithFrame:]):
(-[WebHTMLView insertText:]):
- 1:38 PM Changeset in webkit [195552] by
-
- 4 edits in trunk/Source/WebKit/mac
WK1: Handle soft spaces after accepted candidates
https://bugs.webkit.org/show_bug.cgi?id=153442
-and corresponding-
rdar://problem/23958418
Reviewed by Tim Horton.
The space at the end of candidates is a soft space. If that space exists,
cache the range of the space in m_softSpaceRange.
- WebCoreSupport/WebEditorClient.mm:
(WebEditorClient::handleAcceptedCandidate):
New ivar in WebHTMLViewPrivate softSpaceRange keeps track to the NSRange of a
soft space if the last text that was inserted has a soft space at the end.
- WebView/WebHTMLView.mm:
(-[WebHTMLView initWithFrame:]):
(-[WebHTMLView _setSoftSpaceRange:]):
When new text is inserted, find out if it is being inserted right after a
soft space. If it is, then [NSSpellChecker deletesAutospaceBeforeString] will
tell us if the space needs to be removed. If that is the case, then set the
replacementString to the soft space.
(-[WebHTMLView insertText:]):
- WebView/WebHTMLViewInternal.h:
- 1:12 PM Changeset in webkit [195551] by
-
- 2 edits in trunk/Source/WebCore
[Win] Another build fix after r195545
- CMakeLists.txt:
r195548 didn't change all the pre-builds back to post-builds.
- 1:04 PM Changeset in webkit [195550] by
-
- 2 edits in trunk/Source/JavaScriptCore
Restore CodeBlock jettison code Geoff accidentally removed
https://bugs.webkit.org/show_bug.cgi?id=151241
Rubber-stamped by Geoffrey Garen.
Geoff meant to add this back in <http://trac.webkit.org/changeset/190827>
but missed.
Then he added it back in, but it was rolled out due to a crash on Animometer.
I can no longer produce a crash on Animometer, either with today's version of
the benchmark, or the one that existed at the time of the rollout.
Given this, let's roll it back in and see how it goes.
- bytecode/CodeBlock.cpp:
(JSC::timeToLive):
(JSC::CodeBlock::shouldJettisonDueToOldAge):
- 12:47 PM Changeset in webkit [195549] by
-
- 10 edits in trunk/Source/JavaScriptCore
mandreel should run just as fast in FTL B3 as FTL LLVM
https://bugs.webkit.org/show_bug.cgi?id=153394
Reviewed by Gavin Barraclough.
This fixes two performance bugs and one disassembler bug.
- B3 now turns Branches into Jumps when they are dominated by a Check on the same condition. This is like the opposite of foldPathConstants() was doing.
- Air now supports adding to 8-bit or 16-bit memory locations on x86. B3 now knows how to lower Store8(Add(Load8Z(...))) and various other things to these new instructions.
- Disassembler now knows to print out the instruction's width, whenever it has one. Previously, we'd print movb, movw, movl, and movq as "mov", which is unhelpful if you're storing an immediate, for example.
This adds a bunch of tests for the new instruction forms. This is a big speed-up on
mandreel. It makes us just as fast as LLVM on that benchmark.
- assembler/MacroAssemblerX86Common.h:
(JSC::MacroAssemblerX86Common::add32):
(JSC::MacroAssemblerX86Common::add8):
(JSC::MacroAssemblerX86Common::add16):
(JSC::MacroAssemblerX86Common::add32AndSetFlags):
(JSC::MacroAssemblerX86Common::clz32AfterBsr):
- assembler/X86Assembler.h:
(JSC::X86Assembler::addl_rm):
(JSC::X86Assembler::addb_rm):
(JSC::X86Assembler::addw_rm):
(JSC::X86Assembler::addl_ir):
(JSC::X86Assembler::addl_im):
(JSC::X86Assembler::addb_im):
(JSC::X86Assembler::addw_im):
(JSC::X86Assembler::addq_rr):
- b3/B3LowerToAir.cpp:
(JSC::B3::Air::LowerToAir::addr):
(JSC::B3::Air::LowerToAir::loadPromiseAnyOpcode):
(JSC::B3::Air::LowerToAir::loadPromise):
(JSC::B3::Air::LowerToAir::tryAppendStoreBinOp):
(JSC::B3::Air::LowerToAir::lower):
- b3/B3PureCSE.cpp:
(JSC::B3::PureCSE::clear):
(JSC::B3::PureCSE::findMatch):
(JSC::B3::PureCSE::process):
- b3/B3PureCSE.h:
- b3/B3ReduceStrength.cpp:
- b3/air/AirOpcode.opcodes:
- b3/testb3.cpp:
(JSC::B3::testNegPtr):
(JSC::B3::testStoreAddLoad32):
(JSC::B3::testStoreAddLoadImm32):
(JSC::B3::testStoreAddLoad8):
(JSC::B3::testStoreAddLoadImm8):
(JSC::B3::testStoreAddLoad16):
(JSC::B3::testStoreAddLoadImm16):
(JSC::B3::testStoreAddLoad64):
(JSC::B3::testStoreAddLoadImm64):
(JSC::B3::testStoreAddLoad32Index):
(JSC::B3::testStoreAddLoadImm32Index):
(JSC::B3::testStoreAddLoad8Index):
(JSC::B3::testStoreAddLoadImm8Index):
(JSC::B3::testStoreAddLoad16Index):
(JSC::B3::testStoreAddLoadImm16Index):
(JSC::B3::testStoreAddLoad64Index):
(JSC::B3::testStoreAddLoadImm64Index):
(JSC::B3::testStoreSubLoad):
(JSC::B3::run):
(JSC::B3::testStoreAddLoad): Deleted.
- disassembler/udis86/udis86_syn-att.c:
(ud_translate_att):
- 12:37 PM Changeset in webkit [195548] by
-
- 3 edits in trunk/Source/WebCore
[Win] Fix clean build after r195545.
- CMakeLists.txt:
- PlatformWin.cmake:
I got a little carried away. WebCore already had a pre-build event. It was correct before r195545.
- 12:29 PM Changeset in webkit [195547] by
-
- 6 edits in trunk/Source
Handle soft spaces after accepted candidates
https://bugs.webkit.org/show_bug.cgi?id=153331
-and corresponding-
rdar://problem/23958418
Reviewed by Darin Adler.
Source/WebCore:
Candidates now come with built-in spaces, so we should not insert a space for
them.
- editing/Editor.cpp:
(WebCore::Editor::handleAcceptedCandidate):
New SPI to properly handle these soft spaces.
- platform/spi/mac/NSSpellCheckerSPI.h:
Source/WebKit2:
New member variable m_softSpaceRange keeps track to the NSRange of a soft
space if the last text that was inserted has a soft space at the end.
- UIProcess/Cocoa/WebViewImpl.h:
- UIProcess/Cocoa/WebViewImpl.mm:
(WebKit::WebViewImpl::WebViewImpl):
The space at the end of candidates is a soft space. If that space exists,
cache the range of the space in m_softSpaceRange.
(WebKit::WebViewImpl::handleAcceptedCandidate):
When new text is inserted, find out if it is being inserted right after a
soft space. If it is, then [NSSpellChecker deletesAutospaceBeforeString] will
tell us if the space needs to be removed. If that is the case, then set the
replacementString to the soft space.
(WebKit::WebViewImpl::insertText):
- 12:25 PM Changeset in webkit [195546] by
-
- 2 edits in trunk/LayoutTests
Marking inspector/heap/garbageCollected.html as flaky on mac-wk1 debug
https://bugs.webkit.org/show_bug.cgi?id=153039
Unreviewed test gardening.
- platform/mac-wk1/TestExpectations:
- 12:12 PM Changeset in webkit [195545] by
-
- 11 edits in trunk/Source
[Win] Copy forwarding headers before building a project
https://bugs.webkit.org/show_bug.cgi?id=153434
Reviewed by Brent Fulgham.
Source/JavaScriptCore:
- CMakeLists.txt:
- PlatformWin.cmake:
Source/WebCore:
- CMakeLists.txt:
- PlatformWin.cmake:
Source/WebKit:
- PlatformWin.cmake:
Source/WTF:
- wtf/CMakeLists.txt:
- wtf/PlatformWin.cmake:
- 11:48 AM Changeset in webkit [195544] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Reduce unnecessary forced layouts in TimelineOverview
https://bugs.webkit.org/show_bug.cgi?id=153392
<rdar://problem/24312344>
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-01-25
Reviewed by Timothy Hatcher.
- UserInterface/Views/TimelineOverview.js:
(WebInspector.TimelineOverview.prototype.layout):
Ignore setting the scrollLeft if we would be setting it to 0.
This helps avoid a forced layout in common cases.
- 10:41 AM Changeset in webkit [195543] by
-
- 13 edits in trunk
WebKitTestRunner: Credential cache is not cleared between tests
https://bugs.webkit.org/show_bug.cgi?id=153407
<rdar://problem/24280834>
Reviewed by Brady Eidson.
Source/WebKit2:
Add SPI to call NetworkStorageSession::switchToNewTestingSession() to create a new testing session.
The new testing session will have an empty credential cache.
- NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::switchToNewTestingSession): Added.
- NetworkProcess/NetworkProcess.h:
- NetworkProcess/NetworkProcess.messages.in: Added message SwitchToNewTestingSession().
- UIProcess/API/C/WKContext.cpp:
(WKContextResetTestingNetworkSession): Added.
- UIProcess/API/C/WKContextPrivate.h:
- UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::resetTestingNetworkSession): Added.
- UIProcess/WebProcessPool.h:
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::switchToNewTestingSession): Added.
- WebProcess/WebProcess.h:
- WebProcess/WebProcess.messages.in: Added message SwitchToNewTestingSession().
Tools:
- WebKitTestRunner/TestController.cpp:
(WTR::TestController::resetStateToConsistentValues): Reset testing network session
to clear cached credentials.
- 10:38 AM Changeset in webkit [195542] by
-
- 2 edits in trunk/LayoutTests
Marking http/tests/loading/preload-no-store-frame-src.html as failing on ios-simulator
https://bugs.webkit.org/show_bug.cgi?id=152446
Unreviewed test gardening.
- platform/ios-simulator/TestExpectations:
- 10:20 AM Changeset in webkit [195541] by
-
- 4 edits in trunk
Modern IDB: Implement getIndexRecord in the SQLite backing store.
https://bugs.webkit.org/show_bug.cgi?id=153425
Reviewed by Darin Adler.
Source/WebCore:
No new tests (Some failures now pass, other failures progressed closer to passing).
- Modules/indexeddb/server/SQLiteIDBBackingStore.cpp:
(WebCore::IDBServer::SQLiteIDBBackingStore::getIndexRecord):
LayoutTests:
- platform/mac-wk1/TestExpectations:
- 9:55 AM Changeset in webkit [195540] by
-
- 3 edits2 adds in trunk
Media "ended" event incorrectly fires when currentTime is set
https://bugs.webkit.org/show_bug.cgi?id=150348
<rdar://problem/24247974>
Reviewed by Jer Noble.
Source/WebCore:
Test: media/media-ended-fired-once.html
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::invalidateCachedTime): Always mark m_cachedTime as invalid.
LayoutTests:
- media/media-ended-fired-once-expected.txt: Added.
- media/media-ended-fired-once.html: Added.
- 9:49 AM Changeset in webkit [195539] by
-
- 2 edits in trunk/Source/WebCore
Do not convert GlyphBufferAdvance to FloatSize
https://bugs.webkit.org/show_bug.cgi?id=153421
Patch by Konstantin Tokarev <Konstantin Tokarev> on 2016-01-25
Reviewed by Simon Fraser.
No new tests needed.
- platform/graphics/displaylists/DisplayListItems.cpp:
(WebCore::DisplayList::DrawGlyphs::computeBounds):
- 9:23 AM Changeset in webkit [195538] by
-
- 20 edits2 adds in trunk
document.createElement should be able to create a custom element
https://bugs.webkit.org/show_bug.cgi?id=153173
Reviewed by Darin Adler.
Source/WebCore:
Added the support for constructing a custom element via document.createElement.
Extracted HTMLElementFactory::createKnownElement, which returns nullptr when the specified name doesn't match
any builtin element instead of out of HTMLUnknownElement, out of HTMLElementFactory::createElement.
Test: fast/custom-elements/Document-createElement.html
- bindings/js/JSCustomElementInterface.cpp:
(WebCore::JSCustomElementInterface::constructHTMLElement): Added. Constructs a custom element by invoking its
constructor. We allow exceptions to be thrown by the constructor so the caller is responsible for checking
any exceptions in the ExecState before preceeding if the returned value is null.
- bindings/js/JSCustomElementInterface.h:
(WebCore::JSCustomElementInterface::constructSVGElement): Added.
- bindings/js/JSElementCustom.cpp:
(WebCore::toJSNewlyCreated): Exit early if the element is a custom element as the wrapper had already been
created by super() call inside the custom element'c constructor.
- bindings/js/JSMainThreadExecState.h:
(WebCore::JSMainThreadExecState):
- bindings/js/JSMainThreadExecStateInstrumentation.h:
(WebCore::JSMainThreadExecState::instrumentFunctionInternal): Generalized from instrumentFunctionCall so that
we can use it for both call and construct.
(WebCore::JSMainThreadExecState::instrumentFunctionCall): Specialized the above function for call.
(WebCore::JSMainThreadExecState::instrumentFunctionConstruct): Ditto for construct.
- dom/CustomElementDefinitions.cpp:
(WebCore::CustomElementDefinitions::findInterface): Added.
- dom/CustomElementDefinitions.h:
- dom/Document.cpp:
(WebCore::createHTMLElementWithNameValidation): Extracted from createElement.
(WebCore::Document::createElementForBindings): Renamed from createElement. Specifies
ShouldCreateCustomElement::Create to create a custom element before using fallback elements.
- dom/Document.h:
- dom/Document.idl:
- dom/Node.h:
(WebCore::Node::isCustomElement): Added. This flag is used to identify a custom element.
(WebCore::Node::setIsCustomElement): Added.
- dom/make_names.pl: Extracted createKnownElement from createElement for createHTMLElementWithNameValidation.
- inspector/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::createInspectorStyleSheetForDocument): Use qualified name object to instantiate
a style element and set type content attribute.
- inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::setNodeName): Use createElementForBindings here since we might be creating an
arbitrary element here. Also use RefPtr instead of raw pointers while mutating DOM for safety.
Source/WebKit/win:
Use createElementForBindings here since this is a C++ binding for Windows.
- DOMCoreClasses.cpp:
(DOMDocument::createElement):
Source/WebKit2:
Use createElementForBindings here since this is for SPI.
- WebProcess/InjectedBundle/API/mac/WKDOMDocument.mm:
(-[WKDOMDocument createElement:]):
(-[WKDOMDocument createTextNode:]):
LayoutTests:
Add a test for creating a custom elemnet via document.createElement.
The behavior is to be documented later.
- fast/custom-elements/Document-createElement-expected.txt: Added.
- fast/custom-elements/Document-createElement.html: Added.
- 9:13 AM Changeset in webkit [195537] by
-
- 3 edits in trunk/Source/WebCore
REGRESSION(r192773): [GTK] maps.google.com unresponsive/stalls since r192773
https://bugs.webkit.org/show_bug.cgi?id=153194
Reviewed by Michael Catanzaro.
In r192773 we implemented the JavaScriptCore garbage collector
timers for the GTK+ port. Those timers schedule sources in the
current thread default main context, but JS web worker threads
implementation doesn't use WTF::RunLoop, but its own WorkerRunLoop
class that doesn't create a GMainContext for the new thread. This
means that for web sites using workers, we are now doing garbage
collection of worker VMs in the main thread which ends up in a
deadlock at some point. We need to ensure that worker threads
create a GMainContext and push it as the default one for the
thread before the WorkerGlobalScope is created. This way when the
worker Heap is created, the GC timers use the right context to
schedule their sources. And then we need to check if there are
sources pending in the thread main context on every worker run
loop iteration.
- workers/WorkerRunLoop.cpp:
(WebCore::WorkerRunLoop::runInMode):
- workers/WorkerThread.cpp:
(WebCore::WorkerThread::workerThread):
- 8:19 AM Changeset in webkit [195536] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: timelines clear button should be inactive if nothing can be cleared
https://bugs.webkit.org/show_bug.cgi?id=132756
Patch by Johan K. Jensen <jj@johanjensen.dk> on 2016-01-25
Reviewed by Timothy Hatcher.
- UserInterface/Views/TimelineRecordingContentView.js:
(WebInspector.TimelineRecordingContentView.prototype.shown):
Enable clear button if timeline is not readonly and contains data, when switching timelines.
(WebInspector.TimelineRecordingContentView.prototype._capturingStarted):
Enable clear button when a capturing starts.
(WebInspector.TimelineRecordingContentView.prototype._recordingReset):
Disable clear button after resetting recording.
- 8:18 AM Changeset in webkit [195535] by
-
- 4 edits in trunk/Source/WebCore
Unreviewed, rolling out r195533.
https://bugs.webkit.org/show_bug.cgi?id=153423
It is again breaking builds of several ports (Requested by
youenn on #webkit).
Reverted changeset:
"WebCoreJSBuiltins do not use to do conditional include"
https://bugs.webkit.org/show_bug.cgi?id=153306
http://trac.webkit.org/changeset/195533
- 8:17 AM Changeset in webkit [195534] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Timelines: "Timer Installed150ms delay" — no space before the delay number
https://bugs.webkit.org/show_bug.cgi?id=153416
Reviewed by Timothy Hatcher.
Fix for tree element subtitle rule that regressed in https://bugs.webkit.org/show_bug.cgi?id=153146.
- UserInterface/Views/TreeOutline.css:
(.tree-outline .item .alternate-subtitle::before):
Em dash should be inserted before both subtitle types.
- 6:06 AM Changeset in webkit [195533] by
-
- 4 edits in trunk/Source/WebCore
WebCoreJSBuiltins do not use to do conditional include
https://bugs.webkit.org/show_bug.cgi?id=153306
Reviewed by Alex Christensen.
Removing compilation guards as builtin generator adds them in the files themselves.
Fixing MediaDevices.js to generate MEDIA_STREAM compilation guard.
No change in behavior.
- Modules/mediastream/MediaDevices.js: Changing @optional to @conditional.
- bindings/js/WebCoreJSBuiltins.cpp:
- bindings/js/WebCoreJSBuiltins.h:
- 3:57 AM Changeset in webkit [195532] by
-
- 3 edits in trunk/Source/WebCore
Unreviewed, rolling out r195531.
https://bugs.webkit.org/show_bug.cgi?id=153420
It is breaking builds of several ports (Requested by youenn on
#webkit).
Reverted changeset:
"WebCoreJSBuiltins do not use to do conditional include"
https://bugs.webkit.org/show_bug.cgi?id=153306
http://trac.webkit.org/changeset/195531
- 3:36 AM Changeset in webkit [195531] by
-
- 3 edits in trunk/Source/WebCore
WebCoreJSBuiltins do not use to do conditional include
https://bugs.webkit.org/show_bug.cgi?id=153306
Reviewed by Alex Christensen.
Removing compilation guards as builtin generator adds them in the files themselves.
No change in behavior.
- bindings/js/WebCoreJSBuiltins.cpp:
- bindings/js/WebCoreJSBuiltins.h:
- 2:53 AM Changeset in webkit [195530] by
-
- 21 edits22 adds in trunk
[Fetch API] Implement Fetch API Headers
https://bugs.webkit.org/show_bug.cgi?id=152384
Reviewed by Darin Adler.
LayoutTests/imported/w3c:
- web-platform-tests/fetch/api/headers/headers-basic-expected.txt: Added.
- web-platform-tests/fetch/api/headers/headers-basic.html: Added.
- web-platform-tests/fetch/api/headers/headers-casing-expected.txt: Added.
- web-platform-tests/fetch/api/headers/headers-casing.html: Added.
- web-platform-tests/fetch/api/headers/headers-errors-expected.txt: Added.
- web-platform-tests/fetch/api/headers/headers-errors.html: Added.
- web-platform-tests/fetch/api/headers/headers-idl-expected.txt: Added.
- web-platform-tests/fetch/api/headers/headers-idl.html: Added.
- web-platform-tests/fetch/api/headers/headers-nameshake-expected.txt: Added.
- web-platform-tests/fetch/api/headers/headers-nameshake.html: Added.
- web-platform-tests/fetch/api/headers/headers-normalize-expected.txt: Added.
- web-platform-tests/fetch/api/headers/headers-normalize.html: Added.
- web-platform-tests/fetch/api/headers/headers-structure-expected.txt: Added.
- web-platform-tests/fetch/api/headers/headers-structure.html: Added.
Source/WebCore:
Adding Fetch Headers API as a wapper around HTTPHeaderMap.
Tests: imported/w3c/web-platform-tests/fetch/api/headers/headers-basic.html
imported/w3c/web-platform-tests/fetch/api/headers/headers-casing.html
imported/w3c/web-platform-tests/fetch/api/headers/headers-errors.html
imported/w3c/web-platform-tests/fetch/api/headers/headers-idl.html
imported/w3c/web-platform-tests/fetch/api/headers/headers-nameshake.html
imported/w3c/web-platform-tests/fetch/api/headers/headers-normalize.html
imported/w3c/web-platform-tests/fetch/api/headers/headers-structure.html
- CMakeLists.txt:
- DerivedSources.cpp:
- DerivedSources.make:
- Modules/fetch/FetchHeaders.cpp: Added.
(WebCore::FetchHeaders::initializeWith):
(WebCore::isForbiddenHeaderName):
(WebCore::isForbiddenResponseHeaderName):
(WebCore::isSimpleHeader):
(WebCore::canWriteHeader):
(WebCore::FetchHeaders::append):
(WebCore::FetchHeaders::remove):
(WebCore::FetchHeaders::get):
(WebCore::FetchHeaders::has):
(WebCore::FetchHeaders::set):
- Modules/fetch/FetchHeaders.h: Added.
(WebCore::FetchHeaders::create):
(WebCore::FetchHeaders::~FetchHeaders):
(WebCore::FetchHeaders::internalHeaders):
(WebCore::FetchHeaders::FetchHeaders):
- Modules/fetch/FetchHeaders.idl: Added.
- Modules/fetch/FetchHeaders.js: Added.
(initializeFetchHeaders):
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/WebCoreBuiltinNames.h:
- bindings/js/WebCoreJSBuiltins.cpp:
- bindings/js/WebCoreJSBuiltins.h:
(WebCore::JSBuiltinFunctions::JSBuiltinFunctions):
(WebCore::JSBuiltinFunctions::fetchHeadersBuiltins):
- platform/network/HTTPHeaderMap.cpp:
(WebCore::HTTPHeaderMap::contains):
(WebCore::HTTPHeaderMap::remove):
- platform/network/HTTPHeaderMap.h:
LayoutTests:
- js/dom/global-constructors-attributes-dedicated-worker-expected.txt:
- js/dom/global-constructors-attributes-expected.txt:
- platform/efl/js/dom/global-constructors-attributes-dedicated-worker-expected.txt:
- platform/efl/js/dom/global-constructors-attributes-expected.txt:
- platform/gtk/js/dom/global-constructors-attributes-expected.txt:
- platform/mac-mavericks/js/dom/global-constructors-attributes-expected.txt:
- platform/mac-yosemite/js/dom/global-constructors-attributes-expected.txt:
- platform/mac/js/dom/global-constructors-attributes-expected.txt:
- platform/win/js/dom/global-constructors-attributes-expected.txt:
- 1:24 AM Changeset in webkit [195529] by
-
- 6 edits in trunk
[css-grid] grid shorthand must reset gap properties to their initial values
https://bugs.webkit.org/show_bug.cgi?id=153354
Reviewed by Darin Adler.
Source/WebCore:
Both 'grid-row-gap' & 'grid-column-gap' are considered reset-only subproperties of the
'grid' shorthand meaning that, even thought the shorthand does not offer a way to set
their values, it must in any case reset them to the initial ones.
- css/CSSParser.cpp:
(WebCore::CSSParser::parseGridShorthand):
- css/CSSPropertyNames.in:
LayoutTests:
- fast/css-grid-layout/grid-shorthand-get-set-expected.txt:
- fast/css-grid-layout/grid-shorthand-get-set.html:
- 12:18 AM Changeset in webkit [195528] by
-
- 24 edits in trunk/Source/JavaScriptCore
Reduce number of Structures created at startup.
<https://webkit.org/b/153399>
Reviewed by Darin Adler.
For *Constructor and *Prototype objects that are only created once per JSGlobalObject,
build up the Structures using addPropertyWithoutTransition() helpers to avoid creating
tons of transitions that would just end up floating around and never getting used.
- inspector/JSInjectedScriptHostPrototype.cpp:
(Inspector::JSInjectedScriptHostPrototype::finishCreation):
- inspector/JSJavaScriptCallFramePrototype.cpp:
(Inspector::JSJavaScriptCallFramePrototype::finishCreation):
- runtime/ArrayPrototype.cpp:
(JSC::ArrayPrototype::finishCreation):
- runtime/ConsolePrototype.cpp:
(JSC::ConsolePrototype::finishCreation):
- runtime/DatePrototype.cpp:
(JSC::DatePrototype::finishCreation):
- runtime/JSArrayBufferConstructor.cpp:
(JSC::JSArrayBufferConstructor::finishCreation):
- runtime/JSArrayBufferPrototype.cpp:
(JSC::JSArrayBufferPrototype::finishCreation):
- runtime/JSObject.cpp:
(JSC::JSObject::putDirectNativeFunctionWithoutTransition):
(JSC::JSObject::putDirectBuiltinFunctionWithoutTransition): Deleted.
- runtime/JSObject.h:
- runtime/JSPromiseConstructor.cpp:
(JSC::JSPromiseConstructor::addOwnInternalSlots):
- runtime/JSPromisePrototype.cpp:
(JSC::JSPromisePrototype::addOwnInternalSlots):
- runtime/JSTypedArrayViewConstructor.cpp:
(JSC::JSTypedArrayViewConstructor::finishCreation):
- runtime/JSTypedArrayViewPrototype.cpp:
(JSC::JSTypedArrayViewPrototype::finishCreation):
- runtime/MapIteratorPrototype.cpp:
(JSC::MapIteratorPrototype::finishCreation):
- runtime/MapPrototype.cpp:
(JSC::MapPrototype::finishCreation):
- runtime/NumberPrototype.cpp:
(JSC::NumberPrototype::finishCreation):
- runtime/ObjectConstructor.cpp:
(JSC::ObjectConstructor::finishCreation):
- runtime/ObjectPrototype.cpp:
(JSC::ObjectPrototype::finishCreation):
- runtime/SetIteratorPrototype.cpp:
(JSC::SetIteratorPrototype::finishCreation):
- runtime/SetPrototype.cpp:
(JSC::SetPrototype::finishCreation):
- runtime/StringPrototype.cpp:
(JSC::StringPrototype::finishCreation):
- runtime/WeakMapPrototype.cpp:
(JSC::WeakMapPrototype::finishCreation):
- runtime/WeakSetPrototype.cpp:
(JSC::WeakSetPrototype::finishCreation):
Jan 24, 2016:
- 11:55 PM Changeset in webkit [195527] by
-
- 18 edits in trunk
Modern IDB: Implement deleteIndex and getCount for the SQLite backing store.
https://bugs.webkit.org/show_bug.cgi?id=153415
Reviewed by Darin Adler.
Source/WebCore:
No new tests (Handful of tests now pass, improvements on a handful of others).
- Modules/indexeddb/server/IDBBackingStore.h:
- Modules/indexeddb/server/MemoryIDBBackingStore.cpp:
(WebCore::IDBServer::MemoryIDBBackingStore::deleteIndex):
- Modules/indexeddb/server/MemoryIDBBackingStore.h:
- Modules/indexeddb/server/MemoryObjectStore.cpp:
(WebCore::IDBServer::MemoryObjectStore::takeIndexByIdentifier):
(WebCore::IDBServer::MemoryObjectStore::deleteIndex):
(WebCore::IDBServer::MemoryObjectStore::deleteAllIndexes):
(WebCore::IDBServer::MemoryObjectStore::takeIndexByName): Deleted.
- Modules/indexeddb/server/MemoryObjectStore.h:
- Modules/indexeddb/server/SQLiteIDBBackingStore.cpp:
(WebCore::IDBServer::SQLiteIDBBackingStore::createIndex):
(WebCore::IDBServer::SQLiteIDBBackingStore::deleteIndex):
(WebCore::IDBServer::SQLiteIDBBackingStore::getCount):
- Modules/indexeddb/server/SQLiteIDBBackingStore.h:
- Modules/indexeddb/server/SQLiteIDBCursor.cpp:
(WebCore::IDBServer::SQLiteIDBCursor::maybeCreateBackingStoreCursor):
(WebCore::IDBServer::SQLiteIDBCursor::SQLiteIDBCursor):
- Modules/indexeddb/server/SQLiteIDBCursor.h:
- Modules/indexeddb/server/SQLiteIDBTransaction.cpp:
(WebCore::IDBServer::SQLiteIDBTransaction::maybeOpenBackingStoreCursor):
- Modules/indexeddb/server/SQLiteIDBTransaction.h:
- Modules/indexeddb/server/UniqueIDBDatabase.cpp:
(WebCore::IDBServer::UniqueIDBDatabase::deleteIndex):
(WebCore::IDBServer::UniqueIDBDatabase::performDeleteIndex):
(WebCore::IDBServer::UniqueIDBDatabase::didPerformDeleteIndex):
- Modules/indexeddb/server/UniqueIDBDatabase.h:
- Modules/indexeddb/shared/IDBObjectStoreInfo.cpp:
(WebCore::IDBObjectStoreInfo::deleteIndex):
- Modules/indexeddb/shared/IDBObjectStoreInfo.h:
LayoutTests:
- platform/mac-wk1/TestExpectations:
- 11:45 PM Changeset in webkit [195526] by
-
- 5 edits in trunk/Source/WebKit2
Report upload progress to NetworkLoadClient when using NetworkSession
https://bugs.webkit.org/show_bug.cgi?id=153388
Patch by Alex Christensen <achristensen@webkit.org> on 2016-01-24
Reviewed by Darin Adler.
This fixes http/tests/xmlhttprequest/upload-onload-event.html and a few other tests.
- NetworkProcess/NetworkLoad.cpp:
(WebKit::NetworkLoad::didBecomeDownload):
(WebKit::NetworkLoad::didSendData):
(WebKit::NetworkLoad::didReceiveResponseAsync):
- NetworkProcess/NetworkLoad.h:
- NetworkProcess/NetworkSession.h:
(WebKit::NetworkSessionTaskClient::~NetworkSessionTaskClient):
- NetworkProcess/cocoa/NetworkSessionCocoa.mm:
(-[WKNetworkSessionDelegate initWithNetworkSession:]):
(-[WKNetworkSessionDelegate URLSession:task:didSendBodyData:totalBytesSent:totalBytesExpectedToSend:]):
(-[WKNetworkSessionDelegate URLSession:task:willPerformHTTPRedirection:newRequest:completionHandler:]):
- 11:04 PM Changeset in webkit [195525] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed, speculative fix for:
Modern IDB: Some IDB tests crash in ~SQLiteIDBBackingStore
https://bugs.webkit.org/show_bug.cgi?id=153418
No new tests.
- Modules/indexeddb/server/SQLiteIDBBackingStore.cpp:
(WebCore::IDBServer::SQLiteIDBBackingStore::~SQLiteIDBBackingStore): Clear the global object
before wiping out the VM.
- 10:13 PM Changeset in webkit [195524] by
-
- 18 edits in trunk/Source
Reduce PassRefPtr uses in dom - 4
https://bugs.webkit.org/show_bug.cgi?id=153270
Reviewed by Darin Adler.
As a step to remove PassRefPtr uses, this patch reduces the uses in WebCore/dom.
Source/WebCore:
- bindings/js/JSDeviceMotionEventCustom.cpp:
(WebCore::JSDeviceMotionEvent::initDeviceMotionEvent):
- dom/DeviceMotionData.cpp:
(WebCore::DeviceMotionData::create):
(WebCore::DeviceMotionData::DeviceMotionData):
- dom/DeviceMotionData.h:
- dom/Document.cpp:
(WebCore::Document::setBodyOrFrameset):
(WebCore::Document::setFocusedElement):
(WebCore::Document::setDecoder):
(WebCore::Document::pushCurrentScript):
- dom/Document.h:
- dom/Event.cpp:
(WebCore::Event::cloneFor):
- dom/Event.h:
- dom/MouseEvent.cpp:
(WebCore::MouseEvent::cloneFor):
- dom/MouseEvent.h:
- dom/NodeIterator.cpp:
(WebCore::NodeIterator::NodePointer::NodePointer):
(WebCore::NodeIterator::NodeIterator):
- dom/NodeIterator.h:
(WebCore::NodeIterator::create):
- html/RadioInputType.cpp:
(WebCore::RadioInputType::handleKeydownEvent):
- platform/ios/DeviceMotionClientIOS.mm:
(WebCore::DeviceMotionClientIOS::motionChanged):
- xml/XSLTProcessor.cpp:
(WebCore::XSLTProcessor::createDocumentFromSource):
Source/WebKit/win:
- Plugins/PluginView.cpp:
(WebCore::PluginView::focusPluginElement):
Source/WebKit2:
- WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::focusPluginElement):
- 9:23 PM Changeset in webkit [195523] by
-
- 9 edits in trunk/Source/WebCore
[Font Loading] General cleanup
https://bugs.webkit.org/show_bug.cgi?id=153403
Reviewed by Darin Adler.
It turns out that CSSFontFaceSource::m_hasExternalSVGFont exactly equals
whether or not CSSFontFaceSource::m_font is a CachedSVGFont. Therefore,
the variable is redundant.
In addition, it was being passed to functions on CSSFontFaceSource::m_font,
which means it was always true inside the CachedSVGFont subclass and
always false for the CachedFont. Therefore, there is no reason pass this
variable to these functions because its value can be determined at
authorship time.
No new tests because there is no behavior change.
- css/CSSFontFaceSource.cpp:
(WebCore::CSSFontFaceSource::font):
(WebCore::CSSFontFaceSource::CSSFontFaceSource): Deleted.
- css/CSSFontFaceSource.h:
- css/CSSFontSelector.cpp:
(WebCore::createFontFace):
- loader/cache/CachedFont.cpp:
(WebCore::CachedFont::ensureCustomFontData):
(WebCore::CachedFont::createFont):
- loader/cache/CachedFont.h:
- loader/cache/CachedSVGFont.cpp:
(WebCore::CachedSVGFont::createFont):
(WebCore::CachedSVGFont::ensureCustomFontData):
- loader/cache/CachedSVGFont.h:
- platform/network/HTTPParsers.cpp:
(WebCore::isValidHTTPToken):
- xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::uppercaseKnownHTTPMethod):
- 8:00 PM Changeset in webkit [195522] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: add support for placing Views in DataGrid column headers
https://bugs.webkit.org/show_bug.cgi?id=153387
<rdar://problem/24310797>
Reviewed by Timothy Hatcher.
This patch adds a new DataGrid column property,
headerView, allowing a
custom View object to be placed in a column's header cell. The grid ensures
that the left and right edges of the view are kept in sync as columns are
resized. As most views use absolute positioning and are styled in CSS, the
vertical position and height of the view isn't set by the grid.
- UserInterface/Views/DataGrid.js:
(WebInspector.DataGrid.prototype.insertColumn):
If the new column includes theheaderViewcolumn data property,
it should take priority overtitleDOMFragmentand title text.
The specified View object is inserted into the DOM under the
column's <th> element, and added as a subview of the data grid.
(WebInspector.DataGrid.prototype.layout):
Update header views after performing default layout.
(WebInspector.DataGrid.prototype._showColumn):
Sethiddencolumn property false instead of deleting it.
(WebInspector.DataGrid.prototype._positionHeaderViews):
Update the left and right style positions for all Views embedded in
column header cells, then update their layouts.
(WebInspector.DataGrid.prototype.resizerDragging):
Update header views after column resizers are repositioned.
- 5:19 PM Changeset in webkit [195521] by
-
- 3 edits in trunk/LayoutTests
Unreviewed, update test after r195497
This test did not make much sense as it was, after the behavior change
in r195497.
- fast/dom/Document/document-charset-expected.txt:
- fast/dom/Document/document-charset.html:
- 5:11 PM Changeset in webkit [195520] by
-
- 45 edits2 adds in trunk
An XMLDocument interface should be exposed on the global Window object
https://bugs.webkit.org/show_bug.cgi?id=153378
<rdar://problem/24315465>
Reviewed by Darin Adler.
LayoutTests/imported/w3c:
Rebaseline several W3C DOM and HTML tests now that more checks are
passing.
- web-platform-tests/dom/interfaces-expected.txt:
- web-platform-tests/dom/nodes/Document-constructor-expected.txt:
- web-platform-tests/html/dom/interfaces-expected.txt:
Source/WebCore:
Expose an XMLDocument interface on the global Window object, as per:
DOMImplementation.createDocument() now returns an XMLDocument instead
of a Document, as per:
Previously, WebKit would alias XMLDocument to Document which caused
some W3C tests to fail.
Chrome and Firefox already match the specification here.
No new tests, already covered by existing tests.
- CMakeLists.txt:
- DerivedSources.cpp:
- DerivedSources.make:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSBindingsAllInOne.cpp:
- bindings/js/JSDocumentCustom.cpp:
(WebCore::createNewDocumentWrapper):
- dom/DOMImplementation.cpp:
(WebCore::DOMImplementation::createDocument):
- dom/DOMImplementation.h:
- dom/DOMImplementation.idl:
- dom/Document.cpp:
(WebCore::Document::cloneDocumentWithoutChildren):
- dom/Document.h:
(WebCore::Document::isXMLDocument):
(WebCore::Document::create): Deleted.
(WebCore::Document::createNonRenderedPlaceholder): Deleted.
- dom/XMLDocument.h: Added.
(WebCore::XMLDocument::create):
(WebCore::XMLDocument::createXHTML):
(WebCore::XMLDocument::XMLDocument):
(isType):
- dom/XMLDocument.idl: Added.
- inspector/DOMPatchSupport.cpp:
(WebCore::DOMPatchSupport::patchDocument):
- inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::setOuterHTML):
- page/DOMWindow.idl:
- page/PageSerializer.cpp:
(WebCore::SerializerMarkupAccumulator::SerializerMarkupAccumulator):
- svg/SVGDocument.cpp:
(WebCore::SVGDocument::SVGDocument):
- svg/SVGDocument.h:
- svg/SVGDocument.idl:
- xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::responseXML):
- xml/XSLTProcessor.cpp:
(WebCore::XSLTProcessor::createDocumentFromSource):
LayoutTests:
Rebaseline some layout tests now that XMLDocument is exposed.
- fast/dom/DOMImplementation/createDocument-namespace-err-expected.txt:
- fast/dom/DOMImplementation/script-tests/createDocument-namespace-err.js:
- fast/dom/Document/clone-node-expected.txt:
- fast/dom/Document/clone-node.html:
- fast/dom/Document/xml-document-focus-expected.txt:
- fast/dom/Document/xml-document-focus.xml:
- fast/dom/dom-parse-serialize-display-expected.txt:
- fast/dom/dom-parse-serialize-expected.txt:
- fast/dom/wrapper-classes-expected.txt:
- fast/dom/wrapper-classes.html:
- fast/dom/xmlserializer-serialize-to-string-exception-expected.txt:
- fast/xmlhttprequest/xmlhttprequest-bad-mimetype-expected.txt:
- http/tests/xmlhttprequest/supported-xml-content-types-expected.txt:
- platform/mac/fast/dom/Window/window-lookup-precedence-expected.txt:
- 4:58 PM Changeset in webkit [195519] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Highlight timeline range handles on hover
https://bugs.webkit.org/show_bug.cgi?id=153395
<rdar://problem/24312364>
Reviewed by Timothy Hatcher.
- UserInterface/Views/TimelineRuler.css:
(.timeline-ruler > .selection-handle.clamped):
Gardening. No need to repeat "1px solid".
(.timeline-ruler > .selection-handle:hover, .timeline-ruler > .selection-handle:active):
":active" pseudo selector is needed to keep the handle highligted while it's being dragged
regardress if the mouse cursor is hovering over it or not.
- 3:43 PM Changeset in webkit [195518] by
-
- 3 edits in trunk/LayoutTests
New WK1 baselines.
- platform/mac-wk1/displaylists/extent-includes-shadow-expected.txt:
- platform/mac-wk1/displaylists/extent-includes-transforms-expected.txt:
- 3:42 PM Changeset in webkit [195517] by
-
- 9 edits in trunk
Modern IDB: Support IDBObjectStore.createIndex in the SQLite backing store.
https://bugs.webkit.org/show_bug.cgi?id=153410
Reviewed by Darin Adler.
Source/WebCore:
No new tests (Covered by unskipping many existing tests).
- Modules/indexeddb/server/SQLiteIDBBackingStore.cpp:
(WebCore::IDBServer::SQLiteIDBBackingStore::~SQLiteIDBBackingStore):
(WebCore::IDBServer::SQLiteIDBBackingStore::createIndex):
(WebCore::IDBServer::SQLiteIDBBackingStore::uncheckedHasIndexRecord):
(WebCore::IDBServer::SQLiteIDBBackingStore::uncheckedPutIndexRecord):
- Modules/indexeddb/server/SQLiteIDBBackingStore.h:
- Modules/indexeddb/server/SQLiteIDBCursor.cpp:
(WebCore::IDBServer::SQLiteIDBCursor::maybeCreateBackingStoreCursor):
(WebCore::IDBServer::SQLiteIDBCursor::SQLiteIDBCursor):
- Modules/indexeddb/server/SQLiteIDBCursor.h:
- Modules/indexeddb/server/SQLiteIDBTransaction.cpp:
(WebCore::IDBServer::SQLiteIDBTransaction::maybeOpenBackingStoreCursor):
- Modules/indexeddb/server/SQLiteIDBTransaction.h:
LayoutTests:
- platform/mac-wk1/TestExpectations:
- 12:39 PM Changeset in webkit [195516] by
-
- 7 edits in trunk
Make the dumped display list representation a bit more compact
https://bugs.webkit.org/show_bug.cgi?id=153409
Reviewed by Zalan Bujtas.
Source/WebCore:
Don't make a group for every display list item.
- platform/graphics/displaylists/DisplayList.cpp:
(WebCore::DisplayList::DisplayList::asText):
LayoutTests:
Updated results.
- displaylists/extent-includes-shadow-expected.txt:
- displaylists/extent-includes-transforms-expected.txt:
- displaylists/layer-dispay-list-expected.txt:
- displaylists/replay-skip-clipped-rect-expected.txt:
- 12:39 PM Changeset in webkit [195515] by
-
- 14 edits3 adds in trunk
Add testing for display list replay, and skip clipped-out items on replay
https://bugs.webkit.org/show_bug.cgi?id=153408
Reviewed by Zalan Bujtas.
Source/WebCore:
Make it possible to save and serialize a DisplayList of Items which were
actually applied on replay, so that replay-time optimizations can be tested.
This exposes internals.setElementTracksDisplayListReplay() and
internals.replayDisplayListForElement().
Do a trivial replay-time optimization, which is to skip items whose extents are
outside the replay clip.
Test: displaylists/replay-skip-clipped-rect.html
- platform/graphics/GraphicsLayer.cpp:
(WebCore::GraphicsLayer::GraphicsLayer):
- platform/graphics/GraphicsLayer.h:
(WebCore::GraphicsLayer::setIsTrackingDisplayListReplay):
(WebCore::GraphicsLayer::isTrackingDisplayListReplay):
(WebCore::GraphicsLayer::replayDisplayListAsText):
- platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::layerDisplayListMap): Use a singleton map to store the replay display lists
to avoid bloating GraphicsLayerCA for test-only code. The map stores a pair of the
replay list and a clip rect, which are both dumped. Dumping the clip rect ensures that
we're reporting the replay for the correct tile in a test (since there will be a replay
for each tile).
(WebCore::GraphicsLayerCA::~GraphicsLayerCA):
(WebCore::GraphicsLayerCA::platformCALayerPaintContents):
(WebCore::GraphicsLayerCA::setIsTrackingDisplayListReplay):
(WebCore::GraphicsLayerCA::replayDisplayListAsText):
- platform/graphics/ca/GraphicsLayerCA.h:
- platform/graphics/displaylists/DisplayList.h:
(WebCore::DisplayList::DisplayList::appendItem):
- platform/graphics/displaylists/DisplayListReplayer.cpp:
(WebCore::DisplayList::Replayer::replay): In the unlikely event of tracking replays,
allocate a new DisplayList and append to it items which actually get applied.
- platform/graphics/displaylists/DisplayListReplayer.h:
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::setIsTrackingDisplayListReplay):
(WebCore::RenderLayerBacking::replayDisplayListAsText):
- rendering/RenderLayerBacking.h:
- testing/Internals.cpp:
(WebCore::Internals::setElementTracksDisplayListReplay):
(WebCore::Internals::replayDisplayListForElement):
- testing/Internals.h:
- testing/Internals.idl:
LayoutTests:
Test that a clipped-out rectangle is not painted.
In order to get the rect into the display list, we need to make the target
compositing layer be tiled, and to be clipped by an ancestor so that only the
second tile renders. (This complexity is required because in simpler scenarios,
the rect is clipped out at recording time.)
- displaylists/replay-skip-clipped-rect-expected.txt: Added.
- displaylists/replay-skip-clipped-rect.html: Added.
- displaylists/resources/dump-target-replay-list.js: Added.
(doTest):
- 12:39 PM Changeset in webkit [195514] by
-
- 2 edits in trunk/LayoutTests
Layout Test displaylists/extent-includes-transforms.html is flaky on mac-wk1
https://bugs.webkit.org/show_bug.cgi?id=153308
Reviewed by Dan Bernstein.
Rather than assuming that a zero-delay timer will fire after the next layer flush,
force a flush with testRunner.display(), which fixes flakiness.
- displaylists/resources/dump-target-display-list.js:
(doTest):
- 9:06 AM Changeset in webkit [195513] by
-
- 2 edits in trunk/Tools
Added project.xcworkspace and xcuserdata to this project’s svn:ignore.
- LayoutTestRelay/LayoutTestRelay.xcodeproj: Added property svn:ignore.
Jan 23, 2016:
- 6:47 PM Changeset in webkit [195512] by
-
- 5 edits1 add in trunk
Web Inspector: AXI: node-link-list should be collapsible
https://bugs.webkit.org/show_bug.cgi?id=130911
.:
Added a manual test to test the node list in the Accessibility Inspector
Patch by Aaron Chu <arona.chu@gmail.com> on 2016-01-23
Reviewed by Timothy Hatcher.
- ManualTests/accessibility/collapsible-node-link-list.html: Added.
Source/WebInspectorUI:
Patch by Aaron Chu <arona.chu@gmail.com> on 2016-01-23
Reviewed by Timothy Hatcher.
Accessibility Inspector: for a very long children node list, only the first 5 nodes are shown.
Remaining nodes are hidden by a "# More…" link by which a user can click to reveal the remainder
of the node list.
- Localizations/en.lproj/localizedStrings.js:
- UserInterface/Views/DOMNodeDetailsSidebarPanel.js:
(WebInspector.DOMNodeDetailsSidebarPanel.prototype._refreshAccessibility.linkListForNodeIds):
- UserInterface/Views/Main.css:
(.expand-list-button):
(.node-link-list, .node-link-list li:not([hidden])):
(.node-link-list, .node-link-list li): Deleted.
- 2:51 PM Changeset in webkit [195511] by
-
- 3 edits2 adds in trunk
[GTK] Fix media controls displaying without controls attribute
https://bugs.webkit.org/show_bug.cgi?id=152500
Media controls is not displayed without controls attribute by default
when the video element has text track. It'll be displayed on fullscreen
regardless of controls attribute.
Patch by Wonchul Lee <wonchul.lee@collabora.co.uk> on 2016-01-23
Reviewed by Michael Catanzaro.
Source/WebCore:
- Modules/mediacontrols/mediaControlsGtk.js:
(ControllerGtk.prototype.shouldHaveControls):
(ControllerGtk.prototype.reconnectControls):
(ControllerGtk.prototype.removeControls):
(ControllerGtk.prototype.configureControls): Deleted.
LayoutTests:
- media/video-controls-no-display-with-text-track-expected.txt: Added.
- media/video-controls-no-display-with-text-track.html: Added.
- 2:08 AM Changeset in webkit [195510] by
-
- 2 edits in trunk/Source/WebKit2
CMake build fix after r195494.
- PlatformMac.cmake:
WebKit2 needs to be able to find DataDetectors.h.
- 1:44 AM Changeset in webkit [195509] by
-
- 8 edits in trunk/Source
Use credentials from a URL with NetworkSession like we did with ResourceHandle
https://bugs.webkit.org/show_bug.cgi?id=153328
Patch by Alex Christensen <achristensen@webkit.org> on 2016-01-23
Reviewed by Alexey Proskuryakov.
Source/WebCore:
This patch fixes at least http/tests/xmlhttprequest/basic-auth-credentials-escaping.html when using NetworkSession.
- platform/network/ProtectionSpaceBase.h:
(WebCore::ProtectionSpaceBase::encodingRequiresPlatformData):
- platform/network/ResourceRequestBase.h:
Add some WEBCORE_EXPORT macros for functions that are now used in WebKit2.
Source/WebKit2:
- NetworkProcess/NetworkLoad.cpp:
(WebKit::NetworkLoad::NetworkLoad):
createDataTaskWithRequest is being removed, so use std::make_unique<NetworkDataTask> directly instead.
Also, create the task even if we are deferring loading. Don't call resume if we are deferring loading.
- NetworkProcess/NetworkSession.h:
Callbacks are not just used in NetworkSessionTaskClient, so declare them outside.
The NetworkDataTask now takes a ResourceRequest so we can strip its credentials.
- NetworkProcess/cocoa/NetworkSessionCocoa.mm:
(-[WKNetworkSessionDelegate URLSession:task:didReceiveChallenge:completionHandler:]):
Try credentials stored with the NetworkDataTask before asking the client for credentials.
(WebKit::NetworkSession::~NetworkSession):
(WebKit::NetworkSession::dataTaskForIdentifier):
(WebKit::NetworkSession::takeDownloadID):
(WebKit::NetworkDataTask::NetworkDataTask):
Strip the credentials from the url before creating the task because we do not know the authentication type.
We will use these credentials when a challenge is received.
(WebKit::NetworkDataTask::~NetworkDataTask):
(WebKit::NetworkDataTask::tryPasswordBasedAuthentication):
If we have credentials from the initial URL, try using them if it is appropriate.
(WebKit::NetworkDataTask::cancel):
(WebKit::NetworkSession::createDataTaskWithRequest): Deleted.
- Shared/Authentication/AuthenticationManager.h:
- 12:19 AM Changeset in webkit [195508] by
-
- 4 edits in trunk
Modern IDB: Implement clearing object stores and opening cursors in the SQLite backend.
https://bugs.webkit.org/show_bug.cgi?id=153396
Reviewed by Alex Christensen.
Source/WebCore:
No new tests (Some failing tests now pass, others improved).
Copy more LegacyIDB SQLite backend code over to the new SQLite backend.
- Modules/indexeddb/server/SQLiteIDBBackingStore.cpp:
(WebCore::IDBServer::SQLiteIDBBackingStore::clearObjectStore):
(WebCore::IDBServer::SQLiteIDBBackingStore::openCursor):
(WebCore::IDBServer::SQLiteIDBBackingStore::iterateCursor):
LayoutTests:
- platform/mac-wk1/TestExpectations:
Jan 22, 2016:
- 11:13 PM Changeset in webkit [195507] by
-
- 3 edits5 deletes in trunk
Unreviewed, rolling out r195493.
https://bugs.webkit.org/show_bug.cgi?id=153397
Broke authenticaiton tests (leaks credentials) (Requested by
ap on #webkit).
Reverted changeset:
"LayoutTest http/tests/security/xssAuditor/embed-tag-in-path-
unterminated.html crashing"
https://bugs.webkit.org/show_bug.cgi?id=153250
http://trac.webkit.org/changeset/195493
- 11:13 PM Changeset in webkit [195506] by
-
- 1 edit in trunk/Source/WebKit2/ChangeLog
Fixed a computer error.
- 11:07 PM Changeset in webkit [195505] by
-
- 2 edits in trunk/Source/WebKit2
<rdar://problem/24304228> REGRESSION (r184215): Staged XPC services load non-staged shims
https://bugs.webkit.org/show_bug.cgi?id=153389
Reviewed by Alexey Prooskuryakov.
- Configurations/Shim.xcconfig: Don’t override the install name when using a staged install path.
- 10:46 PM Changeset in webkit [195504] by
-
- 6 edits in trunk/Source/WebInspectorUI
Web Inspector: Reduce unnecessary forced layouts in TimelineRuler
https://bugs.webkit.org/show_bug.cgi?id=153390
<rdar://problem/24312241>
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-01-22
Reviewed by Timothy Hatcher.
TimelineRuler's width rarely changes. It should only need to calculate
its width when added to the DOM or if the content view containing it
has resized and the bounds of the ruler may have changed.
Switch everything in TimelineRuler to using a cached width, and add
an explicit method, resize, to update this width. This eliminated
frequent hangs I was seeing while recording timelines.
- UserInterface/Views/OverviewTimelineView.js:
(WebInspector.OverviewTimelineView.prototype.shown):
(WebInspector.OverviewTimelineView.prototype.updateLayoutForResize):
Resize the ruler when the view is shown or resized.
- UserInterface/Views/TimelineOverview.js:
(WebInspector.TimelineOverview.prototype.shown):
(WebInspector.TimelineOverview.prototype.updateLayoutForResize):
Resize the ruler when the view is shown or resized.
- UserInterface/Views/TimelineRecordingContentView.js:
(WebInspector.TimelineRecordingContentView.prototype.layout):
Inform the current content view of a resize if possible.
- UserInterface/Views/TimelineRuler.js:
(WebInspector.TimelineRuler.prototype.resize):
Update the width.
(WebInspector.TimelineRuler.prototype._recalculate):
(WebInspector.TimelineRuler.prototype._needsMarkerLayout):
(WebInspector.TimelineRuler.prototype._needsSelectionLayout):
(WebInspector.TimelineRuler.prototype._handleMouseMove):
(WebInspector.TimelineRuler.prototype._handleSelectionHandleMouseMove):
Use cached width.
- UserInterface/Views/TimelineRecordBar.js:
(WebInspector.TimelineRecordBar.createCombinedBars): Deleted.
Remove some stale code.
- 7:24 PM Changeset in webkit [195503] by
-
- 3 edits1 add in trunk/Source/JavaScriptCore
B3 should strength-reduce division by a constant
https://bugs.webkit.org/show_bug.cgi?id=153386
Reviewed by Benjamin Poulain.
You can turn a 32-bit division by a constant into a 64-bit multiplication by a constant
plus some shifts. A book called "Hacker's Delight" has a bunch of math about this. The
hard part is finding the constant by which to multiply, and the amount by which to shift.
The book tells you some theroems, but you still have to turn that into code by thinking
deep thoughts. Luckily I was able to avoid that because it turns out that LLVM already
has code for this. It's called APInt::magic(), where APInt is their class for reasoning
about integers.
The code has a compatible license to ours and we have already in the past taken code from
LLVM. So, that's what this patch does. The LLVM code is localized in
B3ComputeDivisionMagic.h. Then reduceStrength() uses that to construct the multiply+shift
sequence.
This is an enormous speed-up on AsmBench-0.9/bigfib.cpp.js. It makes us as fast on that
test as LLVM. It reduces our deficit on AsmBench to 1.5%. Previously it was 4.5%.
- JavaScriptCore.xcodeproj/project.pbxproj:
- b3/B3ComputeDivisionMagic.h: Added.
(JSC::B3::computeDivisionMagic):
- b3/B3ReduceStrength.cpp:
- 6:10 PM Changeset in webkit [195502] by
-
- 2 edits in trunk/Source/JavaScriptCore
genericUnwind might overflow the instructions() vector when catching an FTL exception
https://bugs.webkit.org/show_bug.cgi?id=153383
Reviewed by Benjamin Poulain.
- jit/JITExceptions.cpp:
(JSC::genericUnwind):
- 6:04 PM Changeset in webkit [195501] by
-
- 13 edits2 adds in trunk
HTMLElement::nodeName should not upper case non-ASCII characters
https://bugs.webkit.org/show_bug.cgi?id=153231
Reviewed by Darin Adler.
LayoutTests/imported/w3c:
Rebaselined the test now that all test cases pass.
- web-platform-tests/dom/nodes/Document-createElement-expected.txt:
Source/WebCore:
Use the newly added convertToASCIIUppercase to generate the string for tagName and nodeName.
Test: fast/dom/Element/tagName-must-be-ASCII-uppercase-in-HTML-document.html
- dom/QualifiedName.cpp:
(WebCore::QualifiedName::localNameUpper): Use convertToASCIIUppercase.
- html/HTMLElement.cpp:
(WebCore::HTMLElement::nodeName): Use convertToASCIIUppercase.
Source/WTF:
Added convertToASCIIUppercase to AtomicString, String, and StringImpl.
- wtf/text/AtomicString.cpp:
(WTF::AtomicString::convertASCIICase): Generalized from convertToASCIILowercase.
(WTF::AtomicString::convertToASCIILowercase):
(WTF::AtomicString::convertToASCIIUppercase):
- wtf/text/AtomicString.h:
- wtf/text/StringImpl.cpp:
(WTF::StringImpl::convertASCIICase): Generalized from convertToASCIILowercase.
(WTF::StringImpl::convertToASCIILowercase):
(WTF::StringImpl::convertToASCIIUppercase):
- wtf/text/StringImpl.h:
- wtf/text/WTFString.cpp:
(WTF::String::convertToASCIIUppercase): Added.
- wtf/text/WTFString.h:
LayoutTests:
Added a regression test since the rebaselined W3C test case is very simple and doesn't all permutations.
- fast/dom/Element/tagName-must-be-ASCII-uppercase-in-HTML-document-expected.txt: Added.
- fast/dom/Element/tagName-must-be-ASCII-uppercase-in-HTML-document.html: Added.
- 6:00 PM Changeset in webkit [195500] by
-
- 2 edits1 copy in tags/Safari-602.1.17.0.1
Merged r195498. rdar://problem/24310408
- 5:48 PM Changeset in webkit [195499] by
-
- 8 edits in trunk
Modern IDB: Disable simultaneous transactions in the SQLite backend for now.
https://bugs.webkit.org/show_bug.cgi?id=153381
Reviewed by Alex Christensen.
Source/WebCore:
No new tests (This resolves many of the currently crashing/asserting tests).
Right now we're porting the Legacy IDB SQLite backend to Modern IDB.
The way the Legacy backend works is restricted to one transaction at a time.
There's many tricks we can play to resolve this, but that task is better performed
once all of the basic functionality is done.
Fixing this limitation is covered by https://bugs.webkit.org/show_bug.cgi?id=153382
- Modules/indexeddb/server/IDBBackingStore.h: Add a "supports simultaneous transactions" getter.
- Modules/indexeddb/server/MemoryIDBBackingStore.h:
- Modules/indexeddb/server/SQLiteIDBBackingStore.h:
- Modules/indexeddb/server/UniqueIDBDatabase.cpp:
(WebCore::IDBServer::UniqueIDBDatabase::deleteBackingStore):
(WebCore::IDBServer::UniqueIDBDatabase::openBackingStore):
(WebCore::IDBServer::UniqueIDBDatabase::enqueueTransaction):
(WebCore::IDBServer::UniqueIDBDatabase::takeNextRunnableTransaction): If the backing store does
not support simultaneous transactions but there is a transaction in progress, return.
- Modules/indexeddb/server/UniqueIDBDatabase.h:
LayoutTests:
- platform/mac-wk1/TestExpectations:
- 5:32 PM Changeset in webkit [195498] by
-
- 2 edits1 copy in trunk
Fix internal Windows build
https://bugs.webkit.org/show_bug.cgi?id=153385
rdar://problem/24310408
Reviewed by Brian Weinstein.
- Source/cmake/WinTools.make:
- Source/cmake/tools/vsprops: Copied from WebKitLibraries/win/tools/vsprops.
These property sheets are needed for some projects that are not in this repository
and don't use CMake in the official build. We want to leave them unchanged for now.
- 5:10 PM Changeset in webkit [195497] by
-
- 16 edits2 deletes in trunk
document.charset should be an alias for document.characterSet
https://bugs.webkit.org/show_bug.cgi?id=153367
Reviewed by Ryosuke Niwa.
LayoutTests/imported/w3c:
Rebaseline existing W3C tests now that more checks are passing.
- web-platform-tests/dom/interfaces-expected.txt:
- web-platform-tests/dom/nodes/DOMImplementation-createDocument-expected.txt:
- web-platform-tests/dom/nodes/DOMImplementation-createHTMLDocument-expected.txt:
- web-platform-tests/dom/nodes/Document-constructor-expected.txt:
- web-platform-tests/dom/nodes/Node-properties-expected.txt:
- web-platform-tests/html/dom/interfaces-expected.txt:
Source/WebCore:
document.charset should be an alias for document.characterSet:
It should also be read-only.
Chrome matches the specification.
No new tests, already covered by existing tests.
- dom/Document.h:
- dom/Document.idl:
LayoutTests:
Drop outdated tests.
- fast/dom/Document/document-charset-expected.txt:
- fast/dom/document-attribute-js-null-expected.txt:
- fast/dom/document-attribute-js-null.html:
- fast/encoding/css-charset-default-expected.txt:
- fast/encoding/css-charset-default.xhtml:
- fast/encoding/external-script-charset.js: Removed.
- fast/encoding/external-script-charset.xhtml: Removed.
- 5:04 PM Changeset in webkit [195496] by
-
- 7 edits10 adds in trunk
Document.open / Document.write should be prevented while the document is being unloaded
https://bugs.webkit.org/show_bug.cgi?id=153255
<rdar://problem/22741293>
Reviewed by Ryosuke Niwa.
Source/WebCore:
Document.open / Document.write should be prevented while the document
is being unloaded, as per the HTML specification:
- https://html.spec.whatwg.org/multipage/webappapis.html#dom-document-open (step 6)
- https://html.spec.whatwg.org/multipage/webappapis.html#dom-document-write (step 3)
This patch is aligning our behavior with the specification and Firefox.
Calling Document.open / Document.write during the document was being
unloaded would cause us to crash as this was unexpected.
Tests: fast/frames/page-hide-document-open.html
fast/frames/page-unload-document-open.html
- WebCore.xcodeproj/project.pbxproj:
Add new IgnoreOpensDuringUnloadCountIncrementer.h header.
- dom/Document.cpp:
(WebCore::Document::open):
Abort if the document's ignore-opens-during-unload counter is greater
than zero, as per:
https://html.spec.whatwg.org/multipage/webappapis.html#dom-document-open (step 6)
(WebCore::Document::write):
Abort if the insertion point is undefined and the document's
ignore-opens-during-unload counter is greater than zero, as per:
https://html.spec.whatwg.org/multipage/webappapis.html#dom-document-write (step 3)
- dom/Document.h:
Add data member to maintain the document's ignore-opens-during-unload counter:
https://html.spec.whatwg.org/multipage/webappapis.html#ignore-opens-during-unload-counter
- dom/IgnoreOpensDuringUnloadCountIncrementer.h: Added.
Add utility class to increment / decrement a document's
ignore-opens-during-unload counter.
- history/CachedFrame.cpp:
(WebCore::CachedFrame::CachedFrame):
When a page goes into PageCache, we don't end up calling
FrameLoader::detachChildren() so we need to increment the document's
ignore-opens-during-unload counter before calling stopLoading() on each
subframe.
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::detachChildren):
detachChildren() will end up firing the pagehide / unload events in each
child frame so we increment the parent frame's document's
ignore-opens-during-unload counter. This behavior matches the text of:
https://html.spec.whatwg.org/multipage/browsers.html#unload-a-document
As per the spec, the document's ignore-opens-during-unload counter should
be incremented before firing the pagehide / unload events at the document's
Window object. It should be decremented only after firing the pagehide /
unload events in each subframe. This is needed in case a subframe tries to
call document.open / document.write on a parent frame's document, from its
pagehide or unload handler.
(WebCore::FrameLoader::dispatchUnloadEvents):
Increment the document's ignore-opens-during-unload counter before firing
the pagehide / unload events and decrement it after. As per the spec, we
are not supposed to decrement this early. We actually supposed to wait
until the pagehide / unload events have been fired in all the subframes.
For this reason, we take care of re-incrementing the document's
ignore-opens-during-unload in detachChildren(), which will take care of
firing the pagehide / unload in the subframes.
LayoutTests:
Add layout tests that cover calling Document.open / Document.write from
unload and pagehide handlers.
- fast/frames/page-hide-document-open-expected.txt: Added.
- fast/frames/page-hide-document-open.html: Added.
- fast/frames/page-unload-document-open-expected.txt: Added.
- fast/frames/page-unload-document-open.html: Added.
- fast/frames/resources/finish-test.html: Added.
- fast/frames/resources/page-hide-document-open-frame.html: Added.
- fast/frames/resources/page-hide-document-open-win.html: Added.
- fast/frames/resources/page-unload-document-open-frame.html: Added.
- fast/frames/resources/page-unload-document-open-win.html: Added.
- 4:41 PM Changeset in webkit [195495] by
-
- 5 edits in trunk
Modern IDB: Implement put, get, and delete records for the SQLite backend.
https://bugs.webkit.org/show_bug.cgi?id=153375
Reviewed by Alex Christensen.
Source/WebCore:
No new tests (Covered by many existing tests now passing).
- Modules/indexeddb/server/SQLiteIDBBackingStore.cpp:
(WebCore::IDBServer::SQLiteIDBBackingStore::keyExistsInObjectStore):
(WebCore::IDBServer::SQLiteIDBBackingStore::deleteRecord):
(WebCore::IDBServer::SQLiteIDBBackingStore::deleteRange):
(WebCore::IDBServer::SQLiteIDBBackingStore::addRecord):
(WebCore::IDBServer::SQLiteIDBBackingStore::getRecord):
- Modules/indexeddb/server/SQLiteIDBBackingStore.h:
LayoutTests:
- platform/mac-wk1/TestExpectations:
- 4:24 PM Changeset in webkit [195494] by
-
- 8 edits in trunk/Source
Add support for DataDetectors in WK (iOS).
https://bugs.webkit.org/show_bug.cgi?id=152989
rdar://problem/22855960
Reviewed by Tim Horton.
Source/WebCore:
This patch adds the logic to perform data detection and modify
the DOM by adding data detector links as appropriate.
The data detector results returned by detectContentInRange are
stored in the Frame object.
- editing/cocoa/DataDetection.h:
- editing/cocoa/DataDetection.mm:
(WebCore::resultIsURL):
(WebCore::constructURLStringForResult):
(WebCore::removeResultLinksFromAnchor):
(WebCore::searchForLinkRemovingExistingDDLinks):
(WebCore::dataDetectorTypeForCategory):
(WebCore::buildQuery):
(WebCore::DataDetection::detectContentInRange):
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::checkLoadCompleteForThisFrame):
- page/Frame.h:
(WebCore::Frame::setDataDetectionResults):
(WebCore::Frame::dataDetectionResults):
- platform/spi/cocoa/DataDetectorsCoreSPI.h:
(DDQueryOffsetCompare):
Source/WebKit2:
- UIProcess/API/Cocoa/WKWebView.mm:
(fromWKDataDetectorTypes): Changed parameter to uint64_t to
successfully compare against WKDataDetectorTypeAll.
- 4:19 PM Changeset in webkit [195493] by
-
- 3 edits5 adds in trunk
LayoutTest http/tests/security/xssAuditor/embed-tag-in-path-unterminated.html crashing
https://bugs.webkit.org/show_bug.cgi?id=153250
<rdar://problem/12172843>
And
<rdar://problem/24248040>
Reviewed by Alexey Proskuryakov.
Source/WebCore:
Remove an incorrect assertion that the absolute URL associated with a protection space cannot
contain consecutive forward slash (/) characters. A URL can contain consecutive forward slashes.
This also makes the invariants for CredentialStorage::findDefaultProtectionSpaceForURL() symmetric
with the invariants for WebCore::protectionSpaceMapKeyFromURL().
Tests: http/tests/loading/basic-auth-load-URL-with-consecutive-slashes.html
http/tests/xmlhttprequest/basic-auth-load-URL-with-consecutive-slashes.html
- platform/network/CredentialStorage.cpp:
(WebCore::CredentialStorage::findDefaultProtectionSpaceForURL):
LayoutTests:
The test case http/tests/xmlhttprequest/basic-auth-load-URL-with-consecutive-slashes.html was derived
from a test case written by Yongjun Zhang in <https://bugs.webkit.org/attachment.cgi?id=65189> (bug #44461).
- http/tests/loading/basic-auth-load-URL-with-consecutive-slashes-expected.txt: Added.
- http/tests/loading/basic-auth-load-URL-with-consecutive-slashes.html: Added.
- http/tests/xmlhttprequest/basic-auth-load-URL-with-consecutive-slashes-expected.txt: Added.
- http/tests/xmlhttprequest/basic-auth-load-URL-with-consecutive-slashes.html: Added.
- platform/wk2/http/tests/loading/basic-auth-load-URL-with-consecutive-slashes-expected.txt: Added.
- 3:45 PM Changeset in webkit [195492] by
-
- 2 edits in trunk/LayoutTests
Rebaselining http/tests/security/originHeader/origin-header-for-https.html after r195477
Unreviewed test gardening.
- http/tests/security/originHeader/origin-header-for-https-expected.txt:
- 3:43 PM Changeset in webkit [195491] by
-
- 5 edits in trunk
DOMImplementation.createHTMLDocument("") should append an empty Text Node to the title Element
https://bugs.webkit.org/show_bug.cgi?id=153374
Reviewed by Ryosuke Niwa.
LayoutTests/imported/w3c:
Rebaseline existing W3C DOM tests now that more checks are passing.
- web-platform-tests/dom/nodes/DOMImplementation-createHTMLDocument-expected.txt:
- web-platform-tests/dom/ranges/Range-selectNode-expected.txt:
Source/WebCore:
DOMImplementation.createHTMLDocument("") should append an empty Text
Node to the title Element as per the steps at:
Firefox and Chrome follow the specification here.
Previously, WebKit would rely on HTMLTitleElement.text setter which
does not create a Text Node if the title is the empty string, as per:
- https://html.spec.whatwg.org/multipage/semantics.html#dom-title-text
- https://dom.spec.whatwg.org/#dom-node-textcontent
No new tests, already covered by existing test.
- dom/DOMImplementation.cpp:
(WebCore::DOMImplementation::createHTMLDocument):
- 3:37 PM Changeset in webkit [195490] by
-
- 2 edits in tags/Safari-602.1.17.0.1/Source/JavaScriptCore
Merged r195464. rdar://problem/24296328
- 3:36 PM Changeset in webkit [195489] by
-
- 5 edits in tags/Safari-602.1.17.0.1/Source
Versioning.
- 3:30 PM Changeset in webkit [195488] by
-
- 5 edits in trunk/Source/JavaScriptCore
We should OSR exit with Int52Overflow when we fail to make an Int52 where we expect one.
https://bugs.webkit.org/show_bug.cgi?id=153379
Reviewed by Filip Pizlo.
In DFG::Graph::addShouldSpeculateMachineInt(), we check
!hasExitSite(add, Int52Overflow) when determining whether it's ok to speculate
that an operand is of type Int52 or not. However, the Int52Rep code that
converts a double to Int52 will OSR exit with exit kind BadType instead.
This renders the hasExitSite() check in addShouldSpeculateMachineInt() useless.
This patch fixes this by changing Int52Rep to OSR exit with exit kind
Int52Overflow instead when it fails to convert a double to an Int52.
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::terminateSpeculativeExecution):
(JSC::DFG::SpeculativeJIT::typeCheck):
(JSC::DFG::SpeculativeJIT::usedRegisters):
- dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::needsTypeCheck):
(JSC::DFG::SpeculativeJIT::speculateStringObjectForStructure):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::DFG::LowerDFGToLLVM::typeCheck):
(JSC::FTL::DFG::LowerDFGToLLVM::appendTypeCheck):
(JSC::FTL::DFG::LowerDFGToLLVM::doubleToStrictInt52):
- 3:26 PM Changeset in webkit [195487] by
-
- 21 edits in trunk/Source
Add a mode parameter to MediaControllerInterface::supportsFullscreen() and ChromeClient::supportsVideoFullscreen().
https://bugs.webkit.org/show_bug.cgi?id=153220
Reviewed by Eric Carlson.
Source/WebCore:
No new tests, just code refactoring.
- Modules/mediacontrols/MediaControlsHost.cpp:
(WebCore::MediaControlsHost::supportsFullscreen):
Just pass in VideoFullscreenModeStandard as this is used for checking the standard fullscreen case.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::enterFullscreen):
Only use the FullScreen API if the mode is VideoFullscreenModeStandard. Call ChromeClient::supportsVideoFullscreen()
with the mode.
(WebCore::HTMLMediaElement::exitFullscreen):
Move the fullscreen element check up so we can use this method to exit picture-in-picture mode.
- html/HTMLMediaElement.h:
- html/HTMLVideoElement.cpp:
(WebCore::HTMLVideoElement::supportsFullscreen):
Ditto.
(WebCore::HTMLVideoElement::webkitEnterFullscreen):
Pass in VideoFullscreenModeStandard to supportsFullscreen() as this is used for the standard fullscreen case.
(WebCore::HTMLVideoElement::webkitSupportsFullscreen):
Ditto.
(WebCore::HTMLVideoElement::webkitSupportsPresentationMode):
Pass in the correct VideoFullscreenMode to supportsFullscreen() corresponding to the mode string passed in.
(WebCore::HTMLVideoElement::setFullscreenMode):
Pass in the mode to supportsFullscreen().
- html/HTMLVideoElement.h:
- html/MediaController.h:
- html/MediaControllerInterface.h:
Make supportsFullscreen() take a VideoFullscreenMode.
- html/shadow/MediaControls.cpp:
(WebCore::MediaControls::reset):
Pass in VideoFullscreenModeStandard to supportsFullscreen() here since this is used for the standard
fullscreen button.
- html/shadow/MediaControlsApple.cpp:
(WebCore::MediaControlsApple::reset):
Ditto.
- page/ChromeClient.h:
Make supportsVideoFullscreen() take a VideoFullscreenMode.
- rendering/HitTestResult.cpp:
(WebCore::HitTestResult::mediaSupportsFullscreen):
(WebCore::HitTestResult::toggleMediaFullscreenState):
(WebCore::HitTestResult::enterFullscreenForVideo):
Pass in VideoFullscreenModeStandard in the code relating to the standard fullscreen.
Source/WebKit/mac:
- WebCoreSupport/WebChromeClient.h:
- WebCoreSupport/WebChromeClient.mm:
(WebChromeClient::supportsVideoFullscreen):
Source/WebKit/win:
- WebCoreSupport/WebChromeClient.cpp:
(WebChromeClient::supportsVideoFullscreen):
- WebCoreSupport/WebChromeClient.h:
Source/WebKit2:
- WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::supportsVideoFullscreen):
- WebProcess/WebCoreSupport/WebChromeClient.h:
- 3:25 PM Changeset in webkit [195486] by
-
- 1 copy in tags/Safari-602.1.17.0.1
New tag.
- 3:22 PM Changeset in webkit [195485] by
-
- 13 edits9 deletes in trunk
Document.URL / Document.documentURI should return "about:blank" instead of empty string / null
https://bugs.webkit.org/show_bug.cgi?id=153363
<rdar://problem/22549736>
Reviewed by Ryosuke Niwa.
LayoutTests/imported/w3c:
Rebaseline several W3C tests now that more checks are passing.
- web-platform-tests/dom/interfaces-expected.txt:
- web-platform-tests/dom/nodes/DOMImplementation-createDocument-expected.txt:
- web-platform-tests/dom/nodes/DOMImplementation-createHTMLDocument-expected.txt:
- web-platform-tests/dom/nodes/Document-constructor-expected.txt:
- web-platform-tests/dom/nodes/Node-properties-expected.txt:
- web-platform-tests/html/dom/interfaces-expected.txt:
Source/WebCore:
Document.URL / Document.documentURI should return "about:blank" instead
of empty string / null, as per the specification:
Also, Document.documentURI should be an alias for Document.URL as per:
Firefox matches the specification.
No new tests, already covered by existing W3C tests.
- dom/Document.h:
(WebCore::Document::urlForBindings):
- dom/Document.idl:
LayoutTests:
Drop outdated tests.
- dom/xhtml/level3/core/documentgetdocumenturi02-expected.txt: Removed.
- dom/xhtml/level3/core/documentgetdocumenturi02.js: Removed.
- dom/xhtml/level3/core/documentgetdocumenturi02.xhtml: Removed.
- dom/xhtml/level3/core/documentgetdocumenturi03-expected.txt: Removed.
- dom/xhtml/level3/core/documentgetdocumenturi03.js: Removed.
- dom/xhtml/level3/core/documentgetdocumenturi03.xhtml: Removed.
- dom/xhtml/level3/core/documentsetdocumenturi03-expected.txt: Removed.
- dom/xhtml/level3/core/documentsetdocumenturi03.js: Removed.
- dom/xhtml/level3/core/documentsetdocumenturi03.xhtml: Removed.
- fast/dom/document-attribute-js-null-expected.txt:
- fast/dom/document-attribute-js-null.html:
- 2:52 PM Changeset in webkit [195484] by
-
- 3 edits in trunk/Source/JavaScriptCore
Current implementation of Parser::createSavePoint is a foot gun
https://bugs.webkit.org/show_bug.cgi?id=153293
Reviewed by Oliver Hunt.
The previous use of SavePoint (up until this patch)
really meant that we're saving the LexerState. This
was so poorly named that it was being misused all over
our parser. For example, anything that parsed an
AssignmentExpression between saving/restoring really
wanted to save both Lexer state and Parser state.
This patch changes SavePoint to mean save all the
state. The old SavePoint is renamed to LexerState with
corresponding internal<Save/Restore>LexerState functions.
The old <save/restore>State() function is renamed to
internal<Save/Restore>ParserState().
- parser/Parser.cpp:
(JSC::Parser<LexerType>::Parser):
(JSC::Parser<LexerType>::parseInner):
(JSC::Parser<LexerType>::isArrowFunctionParameters):
(JSC::Parser<LexerType>::parseSourceElements):
(JSC::Parser<LexerType>::declareRestOrNormalParameter):
(JSC::Parser<LexerType>::parseAssignmentElement):
(JSC::Parser<LexerType>::parseDestructuringPattern):
(JSC::Parser<LexerType>::parseForStatement):
(JSC::Parser<LexerType>::parseStatement):
(JSC::Parser<LexerType>::parseFunctionParameters):
(JSC::Parser<LexerType>::parseFunctionInfo):
(JSC::Parser<LexerType>::parseClass):
(JSC::Parser<LexerType>::parseExpression):
(JSC::Parser<LexerType>::parseAssignmentExpression):
(JSC::Parser<LexerType>::parseYieldExpression):
(JSC::Parser<LexerType>::parseConditionalExpression):
(JSC::Parser<LexerType>::parseBinaryExpression):
(JSC::Parser<LexerType>::parseObjectLiteral):
(JSC::Parser<LexerType>::parseStrictObjectLiteral):
(JSC::Parser<LexerType>::parseArrayLiteral):
(JSC::Parser<LexerType>::parsePrimaryExpression):
(JSC::Parser<LexerType>::parseMemberExpression):
(JSC::Parser<LexerType>::parseUnaryExpression):
- parser/Parser.h:
(JSC::Parser::hasError):
(JSC::Parser::internalSaveParserState):
(JSC::Parser::restoreParserState):
(JSC::Parser::internalSaveLexerState):
(JSC::Parser::restoreLexerState):
(JSC::Parser::createSavePointForError):
(JSC::Parser::createSavePoint):
(JSC::Parser::restoreSavePointWithError):
(JSC::Parser::restoreSavePoint):
(JSC::Parser::saveState): Deleted.
(JSC::Parser::restoreState): Deleted.
- 2:50 PM Changeset in webkit [195483] by
-
- 3 edits in trunk/Source/WebCore
Don't ignore the return value of CCRandomCopyBytes
https://bugs.webkit.org/show_bug.cgi?id=153369
<rdar://problem/22198376>
<rdar://problem/22198378>
Reviewed by Alexey Proskuryakov.
Tested by existing Crypto tests.
- crypto/mac/CryptoKeyMac.cpp:
(WebCore::CryptoKey::randomData): RELEASE_ASSERT if CCRandomCopyBytes ever returns
anything besides kCCSuccess.
- crypto/mac/SerializedCryptoKeyWrapMac.mm:
(WebCore::createAndStoreMasterKey): Ditto.
(WebCore::wrapSerializedCryptoKey): Ditto.
- 2:43 PM Changeset in webkit [195482] by
-
- 8 edits2 adds in trunk
Add a test for iOS arrow-key repeat
https://bugs.webkit.org/show_bug.cgi?id=152857
<rdar://problem/24017380>
Reviewed by Darin Adler.
- WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl:
- WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
(WTR::UIScriptController::keyUpUsingHardwareKeyboard):
(WTR::UIScriptController::keyDownUsingHardwareKeyboard):
- WebKitTestRunner/UIScriptContext/UIScriptController.h:
- WebKitTestRunner/ios/HIDEventGenerator.h:
- WebKitTestRunner/ios/HIDEventGenerator.mm:
(-[HIDEventGenerator keyPress:completionBlock:]):
(-[HIDEventGenerator keyDown:completionBlock:]):
(-[HIDEventGenerator keyUp:completionBlock:]):
- WebKitTestRunner/ios/UIScriptControllerIOS.mm:
(WTR::UIScriptController::typeCharacterUsingHardwareKeyboard):
(WTR::UIScriptController::keyDownUsingHardwareKeyboard):
(WTR::UIScriptController::keyUpUsingHardwareKeyboard):
Make it possible to independently send keyUp/keyDown, instead of just paired.
- fast/events/ios/keyboard-scrolling-repeat-expected.txt: Added.
- fast/events/ios/keyboard-scrolling-repeat.html: Added.
Add the aforementioned test. It waits for the held-down arrow key to scroll twice, then sends the up.
- 2:42 PM Changeset in webkit [195481] by
-
- 2 edits in trunk/Tools
Unreviewed build fix after http://trac.webkit.org/changeset/195474.
- WebKitTestRunner/cocoa/TestControllerCocoa.mm:
(WTR::TestController::platformCreateWebView):
- 2:41 PM Changeset in webkit [195480] by
-
- 2 edits in trunk/Source/JavaScriptCore
Unreviewed. fnormal => normal.
- tests/es6.yaml:
- 2:25 PM Changeset in webkit [195479] by
-
- 5 edits in trunk
Reproducible "Unhanded web process message 'WebUserContentController:AddUserScripts'" and friends
https://bugs.webkit.org/show_bug.cgi?id=153193
<rdar://problem/24222034>
Reviewed by Darin Adler.
The WebPageProxy constructor assumes that if its WebProcess is already running,
it can add itself to the existing WebUserContentController(Proxy) and all will be well.
However, if the API client constructs a different WKUserContentController for two views,
and forces them both into the same process, WebPageProxy's constructor sends a message
with a WebUserContentController ID that doesn't exist yet on the WebProcess side
(because createWebPage, which usually brings it up, hasn't happened yet), and we
drop the message on the floor (and get the aforementioned logging).
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::initializeWebPageAfterProcessLaunch):
Instead of connecting our WebUserContentControllerProxy and WebVisitedLinkStoreProxy
to our WebProcessProxy in the constructor, when doing so might send messages
to the WebProcess that arrive before their corresponding WebProcess objects have
been created, do this in initializeWebPageAfterProcessLaunch, which always runs
during-or-after inititalizeWebPage (and always after the CreateWebPage message goes out).
(WebKit::WebPageProxy::initializeWebPage):
Mark us as needing initializeWebPageAfterProcessLaunch run, and run it right now
if the WebProcess is already up.
(WebKit::WebPageProxy::processDidFinishLaunching):
If the WebProcess wasn't up at the end of initializeWebPage, we'll eventually end up here
after it is launched, and will initializeWebPageAfterProcessLaunch.
(WebKit::WebPageProxy::resetStateAfterProcessExited):
If the WebProcess dies, we don't want to initializeWebPageAfterProcessLaunch
until after initializeWebPage runs again, so make sure the flag isn't set.
- UIProcess/WebPageProxy.h:
- TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm:
(webViewForScriptMessageHandlerMultipleHandlerRemovalTest):
(TEST):
Add a test that exhibits the problems we're fixing here.
Before, it would both log and assert in debug, and crash in release.
Now it runs happily to completion.
- 2:25 PM Changeset in webkit [195478] by
-
- 2 edits in trunk
Only set CMake output directories if they aren't already set
https://bugs.webkit.org/show_bug.cgi?id=153373
Reviewed by Michael Catanzaro.
- CMakeLists.txt:
r195242 caused Windows builds to copy files to bin instead of bin64.
CMAKE_RUNTIME_OUTPUT_DIRECTORY is being set in OptionsWin.cmake, and this was now resetting it.
This also makes it so you can set these variables by command line.
- 2:24 PM Changeset in webkit [195477] by
-
- 6 edits8 adds in trunk
Treat non-https actions on secure pages as mixed content
<rdar://problem/23144492>
https://bugs.webkit.org/show_bug.cgi?id=153322
Source/WebCore:
Reviewed by Alexey Proskuryakov.
Tests: http/tests/security/mixedContent/insecure-form-in-iframe.html
http/tests/security/mixedContent/insecure-form-in-main-frame.html
http/tests/security/mixedContent/javascript-url-form-in-main-frame.html
- html/HTMLFormElement.cpp:
(WebCore::HTMLFormElement::parseAttribute):
Check form actions for mixed content.
- loader/MixedContentChecker.cpp:
(WebCore::MixedContentChecker::checkFormForMixedContent):
- loader/MixedContentChecker.h:
Add new function to check and warn if a form's action is mixed content.
LayoutTests:
Reviewed by Alexey Proskuryakov.
- http/tests/security/mixedContent/insecure-form-in-iframe-expected.txt: Added.
- http/tests/security/mixedContent/insecure-form-in-iframe.html: Added.
- http/tests/security/mixedContent/insecure-form-in-main-frame-expected.txt: Added.
- http/tests/security/mixedContent/insecure-form-in-main-frame.html: Added.
- http/tests/security/mixedContent/javascript-url-form-in-main-frame-expected.txt: Added.
- http/tests/security/mixedContent/javascript-url-form-in-main-frame.html: Added.
- http/tests/security/mixedContent/resources/frame-with-insecure-form.html: Added.
- http/tests/security/mixedContent/resources/frame-with-javascript-url-form.html: Added.
- 2:21 PM Changeset in webkit [195476] by
-
- 2 edits in trunk/Source/JavaScriptCore
Unreviewed. Forgot to git stash pop some of the changes.
This should mark the rest of the es6 tests as passing.
- tests/es6.yaml:
- 2:19 PM Changeset in webkit [195475] by
-
- 2 edits in trunk/Source/JavaScriptCore
Unreviewed. Mark es6 tests as passing.
- tests/es6.yaml:
- 2:17 PM Changeset in webkit [195474] by
-
- 4 edits in trunk/Tools
Add support for testing data detection.
https://bugs.webkit.org/show_bug.cgi?id=153360
Reviewed by Tim Horton.
Adding a new testing option (useDataDetection) to turn on
data detection when running the a test.
- WebKitTestRunner/TestController.cpp:
(WTR::updateTestOptionsFromTestHeader):
- WebKitTestRunner/TestOptions.h:
- WebKitTestRunner/cocoa/TestControllerCocoa.mm:
(WTR::TestController::platformCreateWebView):
- 2:12 PM Changeset in webkit [195473] by
-
- 2 edits in trunk/Source/JavaScriptCore
op_profile_type 32-bit LLInt implementation has a bug
https://bugs.webkit.org/show_bug.cgi?id=153368
Reviewed by Michael Saboff.
r189293 changed which registers were used, specifically
using t5 instead of t4. That change forgot to replace
t4 with t5 in one specific instance.
- llint/LowLevelInterpreter32_64.asm:
- 2:08 PM Changeset in webkit [195472] by
-
- 2 edits in trunk/LayoutTests
Marking imported/w3c/web-platform-tests/XMLHttpRequest/getresponseheader-chunked-trailer.htm as flaky on ios-simulator
https://bugs.webkit.org/show_bug.cgi?id=153371
Unreviewed test gardening.
- platform/ios-simulator/TestExpectations:
- 2:03 PM Changeset in webkit [195471] by
-
- 2 edits in tags/Safari-602.1.17.1/Source/WebCore
Merged r195459. rdar://problem/24294651
- 2:01 PM Changeset in webkit [195470] by
-
- 5 edits in tags/Safari-602.1.17.1/Source
Versioning.
- 1:00 PM Changeset in webkit [195469] by
-
- 1 copy in tags/Safari-602.1.17.1
New tag.
- 12:53 PM Changeset in webkit [195468] by
-
- 3 edits2 adds in trunk
AX: Crash in setTextMarkerDataWithCharacterOffset
https://bugs.webkit.org/show_bug.cgi?id=153365
<rdar://problem/24287924>
Reviewed by Chris Fleizach.
Source/WebCore:
Sometimes when we try to create a text marker range from a stale text marker with a removed
node, it will cause crash. Fixed it by adding a null check for the AccessibilityObject we
create in setTextMarkerDataWithCharacterOffset.
Test: accessibility/text-marker/text-marker-range-with-removed-node-crash.html
- accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::setTextMarkerDataWithCharacterOffset):
LayoutTests:
- accessibility/text-marker/text-marker-range-with-removed-node-crash-expected.txt: Added.
- accessibility/text-marker/text-marker-range-with-removed-node-crash.html: Added.
- 12:37 PM Changeset in webkit [195467] by
-
- 16 edits in trunk
Modern IDB: Add transactions and create/delete object store to SQLite backend
https://bugs.webkit.org/show_bug.cgi?id=153359
Reviewed by Alex Christensen.
Source/WebCore:
No new tests (Covered by many tests now passing).
- Modules/indexeddb/server/IDBBackingStore.h: Change deleteObjectStore to work on an ID instead of name.
- Modules/indexeddb/server/MemoryIDBBackingStore.cpp:
(WebCore::IDBServer::MemoryIDBBackingStore::deleteObjectStore):
(WebCore::IDBServer::MemoryIDBBackingStore::takeObjectStoreByIdentifier):
(WebCore::IDBServer::MemoryIDBBackingStore::takeObjectStoreByName): Deleted.
- Modules/indexeddb/server/MemoryIDBBackingStore.h:
Clean up filename generation a bit to actually match the previous directory structure.
Add begin/commit/abort transaction support.
Add create/delete object store support:
- Modules/indexeddb/server/SQLiteIDBBackingStore.cpp:
(WebCore::IDBServer::SQLiteIDBBackingStore::filenameForDatabaseName):
(WebCore::IDBServer::SQLiteIDBBackingStore::fullDatabaseDirectory):
(WebCore::IDBServer::SQLiteIDBBackingStore::fullDatabasePath):
(WebCore::IDBServer::SQLiteIDBBackingStore::getOrEstablishDatabaseInfo):
(WebCore::IDBServer::SQLiteIDBBackingStore::beginTransaction):
(WebCore::IDBServer::SQLiteIDBBackingStore::abortTransaction):
(WebCore::IDBServer::SQLiteIDBBackingStore::commitTransaction):
(WebCore::IDBServer::SQLiteIDBBackingStore::createObjectStore):
(WebCore::IDBServer::SQLiteIDBBackingStore::deleteObjectStore):
(WebCore::IDBServer::SQLiteIDBBackingStore::deleteBackingStore):
- Modules/indexeddb/server/SQLiteIDBBackingStore.h:
Clean up SQLiteIDBTransaction to fit with the new WebCore backing store model, which is slightly
different from the old WebKit2 backing store model:
- Modules/indexeddb/server/SQLiteIDBTransaction.cpp:
(WebCore::IDBServer::SQLiteIDBTransaction::SQLiteIDBTransaction):
(WebCore::IDBServer::SQLiteIDBTransaction::begin):
(WebCore::IDBServer::SQLiteIDBTransaction::commit):
(WebCore::IDBServer::SQLiteIDBTransaction::abort):
(WebCore::IDBServer::SQLiteIDBTransaction::reset):
(WebCore::IDBServer::SQLiteIDBTransaction::rollback): Deleted.
- Modules/indexeddb/server/SQLiteIDBTransaction.h:
(WebCore::IDBServer::SQLiteIDBTransaction::transactionIdentifier):
(WebCore::IDBServer::SQLiteIDBTransaction::mode):
- Modules/indexeddb/server/UniqueIDBDatabase.cpp:
(WebCore::IDBServer::UniqueIDBDatabase::deleteObjectStore):
(WebCore::IDBServer::UniqueIDBDatabase::performDeleteObjectStore):
(WebCore::IDBServer::UniqueIDBDatabase::didPerformDeleteObjectStore):
- Modules/indexeddb/server/UniqueIDBDatabase.h:
- Modules/indexeddb/shared/IDBDatabaseInfo.cpp:
(WebCore::IDBDatabaseInfo::deleteObjectStore):
- Modules/indexeddb/shared/IDBDatabaseInfo.h:
- Modules/indexeddb/shared/IDBObjectStoreInfo.h:
(WebCore::IDBObjectStoreInfo::maxIndexID):
- Modules/indexeddb/shared/IDBTransactionInfo.h:
(WebCore::IDBTransactionInfo::identifier):
LayoutTests:
- platform/mac-wk1/TestExpectations:
- 12:03 PM Changeset in webkit [195466] by
-
- 3 edits in trunk/Source/JavaScriptCore
B3 should reduce obvious forms of Shl(SShr)
https://bugs.webkit.org/show_bug.cgi?id=153362
Reviewed by Mark Lam and Saam Barati.
This is a 40% speed-up in AsmBench-0.9/dry.c.js.
- b3/B3ReduceStrength.cpp:
- b3/testb3.cpp:
(JSC::B3::testStore16Load16Z):
(JSC::B3::testSShrShl32):
(JSC::B3::testSShrShl64):
(JSC::B3::zero):
(JSC::B3::run):
- 12:00 PM Changeset in webkit [195465] by
-
- 12 edits in trunk/Source/WebCore
Style resolver initialization cleanups
https://bugs.webkit.org/show_bug.cgi?id=153356
Reviewed by Simon Fraser.
Simplify StyleResolver::State initialization.
Also use more references and other cleanups.
- css/MediaQueryMatcher.cpp:
(WebCore::MediaQueryMatcher::prepareEvaluator):
- css/StyleMedia.cpp:
(WebCore::StyleMedia::matchMedium):
- css/StyleResolver.cpp:
(WebCore::StyleResolver::State::clear):
(WebCore::StyleResolver::StyleResolver):
(WebCore::StyleResolver::classNamesAffectedByRules):
(WebCore::StyleResolver::State::State):
Initialize State using a constructor instead of bunch of construction functions.
Remove m_styledElement field which is just a casted version of m_element.
(WebCore::StyleResolver::State::updateConversionData):
(WebCore::StyleResolver::State::setStyle):
(WebCore::StyleResolver::sharingCandidateHasIdenticalStyleAffectingAttributes):
(WebCore::StyleResolver::canShareStyleWithElement):
(WebCore::StyleResolver::locateSharedStyle):
(WebCore::isAtShadowBoundary):
(WebCore::StyleResolver::styleForElement):
(WebCore::StyleResolver::styleForKeyframe):
(WebCore::StyleResolver::keyframeStylesForAnimation):
(WebCore::StyleResolver::pseudoStyleForElement):
(WebCore::StyleResolver::styleForPage):
(WebCore::StyleResolver::pseudoStyleRulesForElement):
(WebCore::StyleResolver::clearCachedPropertiesAffectedByViewportUnits):
(WebCore::isCacheableInMatchedPropertiesCache):
Disallow caching of document element style entirely because the writing-mode and direction properties have special handling.
The existing check wasn't robust.
(WebCore::extractDirectionAndWritingMode):
(WebCore::StyleResolver::applyMatchedProperties):
(WebCore::StyleResolver::applyPropertyToStyle):
(WebCore::StyleResolver::State::initElement): Deleted.
(WebCore::StyleResolver::initElement): Deleted.
(WebCore::StyleResolver::State::initForStyleResolve): Deleted.
- css/StyleResolver.h:
(WebCore::StyleResolver::mediaQueryEvaluator):
(WebCore::StyleResolver::State::State):
(WebCore::StyleResolver::State::document):
(WebCore::StyleResolver::State::element):
(WebCore::StyleResolver::State::style):
(WebCore::StyleResolver::State::takeStyle):
(WebCore::StyleResolver::State::styledElement): Deleted.
- dom/Element.cpp:
(WebCore::Element::resolveStyle):
- page/animation/KeyframeAnimation.cpp:
(WebCore::KeyframeAnimation::KeyframeAnimation):
- rendering/RenderElement.cpp:
(WebCore::RenderElement::getUncachedPseudoStyle):
(WebCore::RenderElement::containingBlockForFixedPosition):
- rendering/RenderNamedFlowFragment.cpp:
(WebCore::RenderNamedFlowFragment::computeStyleInRegion):
- style/StyleTreeResolver.cpp:
(WebCore::Style::TreeResolver::styleForElement):
- svg/SVGElement.cpp:
(WebCore::SVGElement::customStyleForRenderer):
(WebCore::SVGElement::computedStyle):
(WebCore::addQualifiedName):
- svg/SVGElementRareData.h:
(WebCore::SVGElementRareData::ensureAnimatedSMILStyleProperties):
(WebCore::SVGElementRareData::overrideComputedStyle):
- 11:44 AM Changeset in webkit [195464] by
-
- 2 edits in trunk/Source/JavaScriptCore
Fix internal Windows build
https://bugs.webkit.org/show_bug.cgi?id=153364
<rdar://problem/24296328>
Reviewed by Brent Fulgham.
- PlatformWin.cmake:
The internal build does not build JavaScriptCore with WTF, so it does not automatically link to winmm.lib
like it does when everything is built together.
- 11:31 AM Changeset in webkit [195463] by
-
- 10 edits2 adds in trunk
AX: <code> group and friends should have a custom subrole
https://bugs.webkit.org/show_bug.cgi?id=153282
Reviewed by Mario Sanchez Prada.
Source/WebCore:
Add some custom subroles for the mac for code, ins, del, cite, var, samp, pre, kbd,
so that assistive tech can recognize them.
Test: accessibility/mac/subroles-for-formatted-groups.html
- accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::isStyleFormatGroup):
- accessibility/AccessibilityObject.h:
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::computeAccessibilityIsIgnored):
(WebCore::AccessibilityRenderObject::determineAccessibilityRole):
- accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(-[WebAccessibilityObjectWrapper subrole]):
LayoutTests:
- accessibility/duplicate-child-nodes-expected.txt:
- accessibility/mac/subroles-for-formatted-groups-expected.txt: Added.
- accessibility/mac/subroles-for-formatted-groups.html: Added.
- accessibility/roles-computedRoleString-expected.txt:
- accessibility/roles-computedRoleString.html:
- 11:31 AM Changeset in webkit [195462] by
-
- 2 edits1 add in trunk/Source/JavaScriptCore
Equivalence PropertyCondition needs to check the offset it uses to load the value from is not invalidOffset
https://bugs.webkit.org/show_bug.cgi?id=152912
Reviewed by Mark Lam.
When checking the validity of an Equivalence PropertyCondition we do not check that the offset returned by
the structure of the object in the equivalence condition is valid. The offset might be wrong for many reasons.
The one we now test for is when the GlobalObject has a property that becomes a variable the property is deleted
thus the offset is now invalid.
- bytecode/PropertyCondition.cpp:
(JSC::PropertyCondition::isStillValidAssumingImpurePropertyWatchpoint):
- tests/stress/global-property-into-variable-get-from-scope.js: Added.
- 10:47 AM Changeset in webkit [195461] by
-
- 3 edits in trunk/LayoutTests
[ES6] Arrow function. Default arguments in arrow functions
https://bugs.webkit.org/show_bug.cgi?id=152537
Patch by Skachkov Oleksandr <gskachkov@gmail.com> on 2016-01-22
Reviewed by Saam Barati.
Default arguments in arrow function parameters have been already
implemented by patch from issue https://bugs.webkit.org/show_bug.cgi?id=146934.
Current patch adds only tests for this feature
- js/arrowfunction-syntax-expected.txt:
- js/script-tests/arrowfunction-syntax.js:
- 10:44 AM Changeset in webkit [195460] by
-
- 31 edits1 add in trunk
[ES6] Add Symbol.species properties to the relevant constructors
https://bugs.webkit.org/show_bug.cgi?id=153339
Reviewed by Michael Saboff.
Source/JavaScriptCore:
This patch adds Symbol.species to the RegExp, Array, TypedArray, Map, Set, ArrayBuffer, and
Promise constructors. The functions that use these properties will be added in a later
patch.
- builtins/GlobalObject.js:
(speciesGetter):
- runtime/ArrayConstructor.cpp:
(JSC::ArrayConstructor::finishCreation):
- runtime/ArrayConstructor.h:
(JSC::ArrayConstructor::create):
- runtime/BooleanConstructor.h:
(JSC::BooleanConstructor::create):
- runtime/CommonIdentifiers.h:
- runtime/DateConstructor.h:
(JSC::DateConstructor::create):
- runtime/ErrorConstructor.h:
(JSC::ErrorConstructor::create):
- runtime/JSArrayBufferConstructor.cpp:
(JSC::JSArrayBufferConstructor::finishCreation):
(JSC::JSArrayBufferConstructor::create):
- runtime/JSArrayBufferConstructor.h:
- runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::init):
- runtime/JSInternalPromiseConstructor.cpp:
(JSC::JSInternalPromiseConstructor::create):
- runtime/JSInternalPromiseConstructor.h:
- runtime/JSPromiseConstructor.cpp:
(JSC::JSPromiseConstructor::create):
(JSC::JSPromiseConstructor::finishCreation):
- runtime/JSPromiseConstructor.h:
- runtime/JSTypedArrayViewConstructor.cpp:
(JSC::JSTypedArrayViewConstructor::finishCreation):
(JSC::JSTypedArrayViewConstructor::create): Deleted.
- runtime/JSTypedArrayViewConstructor.h:
(JSC::JSTypedArrayViewConstructor::create):
- runtime/MapConstructor.cpp:
(JSC::MapConstructor::finishCreation):
- runtime/MapConstructor.h:
(JSC::MapConstructor::create):
- runtime/NumberConstructor.h:
(JSC::NumberConstructor::create):
- runtime/RegExpConstructor.cpp:
(JSC::RegExpConstructor::finishCreation):
- runtime/RegExpConstructor.h:
(JSC::RegExpConstructor::create):
- runtime/SetConstructor.cpp:
(JSC::SetConstructor::finishCreation):
- runtime/SetConstructor.h:
(JSC::SetConstructor::create):
- runtime/StringConstructor.h:
(JSC::StringConstructor::create):
- runtime/SymbolConstructor.h:
(JSC::SymbolConstructor::create):
- runtime/WeakMapConstructor.h:
(JSC::WeakMapConstructor::create):
- runtime/WeakSetConstructor.h:
(JSC::WeakSetConstructor::create):
- tests/stress/symbol-species.js: Added.
(testSymbolSpeciesOnConstructor):
LayoutTests:
Add species to the list of property names on the Symbol object.
- js/Object-getOwnPropertyNames-expected.txt:
- js/script-tests/Object-getOwnPropertyNames.js:
- 10:37 AM Changeset in webkit [195459] by
-
- 2 edits in trunk/Source/WebCore
Remove dependency from DataDetectorsCore on iOS.
https://bugs.webkit.org/show_bug.cgi?id=153358
rdar://problem/24294651
Reviewed by Anders Carlsson.
Avoid build dependencies.
- Configurations/WebCore.xcconfig:
- 10:24 AM Changeset in webkit [195458] by
-
- 2 edits in trunk/Source/WTF
Unreviewed attempt to fix the Windows build after r195452.
- wtf/text/WTFString.h:
- 10:11 AM Changeset in webkit [195457] by
-
- 3 edits2 adds in trunk
AX: ARIA combo boxes are not returning the right value for selected text range
https://bugs.webkit.org/show_bug.cgi?id=153260
Reviewed by Darin Adler.
Source/WebCore:
Just because an element has an ARIA role doesn't mean we should always use the selected text range of the whole document.
If the element is also a text based ARIA control, we can still use the element's inner text range to return the right value.
Test: accessibility/selected-text-range-aria-elements.html
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::selectedTextRange):
LayoutTests:
- accessibility/selected-text-range-aria-elements-expected.txt: Added.
- accessibility/selected-text-range-aria-elements.html: Added.
- 10:07 AM Changeset in webkit [195456] by
-
- 4 edits in trunk/Source/WebInspectorUI
Web Inspector: Sidebar's should remember their width's
https://bugs.webkit.org/show_bug.cgi?id=153007
Patch by Devin Rousso <Devin Rousso> on 2016-01-22
Reviewed by Timothy Hatcher.
- UserInterface/Views/CSSStyleDetailsSidebarPanel.js:
(WebInspector.CSSStyleDetailsSidebarPanel.prototype.widthDidChange):
Now calls superclass function.
- UserInterface/Views/Sidebar.js:
(WebInspector.Sidebar.prototype.set selectedSidebarPanel):
Now calls _recalculateWidth with the saved width value of the sidebar as
the first parameter.
(WebInspector.Sidebar.prototype.set collapsed):
Now only calls _recalculateWidth if the selected sidebar panel is visible,
seeing as if it is hidden the width is irrelevant.
- UserInterface/Views/SidebarPanel.js:
(WebInspector.SidebarPanel):
Creates a setting object using the panel's identifier to store the current width.
(WebInspector.SidebarPanel.prototype.get savedWidth):
(WebInspector.SidebarPanel.prototype.widthDidChange):
So long as the current width has a value, save it to the setting object.
- 10:06 AM Changeset in webkit [195455] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed iOS build fix after r195452.
- accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::colorValue):
- 10:03 AM Changeset in webkit [195454] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Class toggle add icon flashes when changing nodes
https://bugs.webkit.org/show_bug.cgi?id=153341
Patch by Devin Rousso <Devin Rousso> on 2016-01-22
Reviewed by Timothy Hatcher.
- UserInterface/Views/CSSStyleDetailsSidebarPanel.js:
(WebInspector.CSSStyleDetailsSidebarPanel.prototype._populateClassToggles):
Changed the way in which the class toggles are repopulated to prevent the
add class icon from being removed and re-added.
- 9:35 AM Changeset in webkit [195453] by
-
- 4 edits2 adds in trunk
Elements with overflow and border-radius don't show in multicolumn properly.
https://bugs.webkit.org/show_bug.cgi?id=152920
Reviewed by Simon Fraser.
Source/WebCore:
Added new test in fast/multicol.
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::convertToLayerCoords):
(WebCore::RenderLayer::offsetFromAncestor):
(WebCore::RenderLayer::clipToRect):
- rendering/RenderLayer.h:
Make sure the crawl up the containing block chain to apply clips properly offsets
to account for columns. convertToLayerCoords could already handle this, so
offsetFromAncestor now takes the same extra argument (whether or not to adjust for
columns) that convertToLayerCoords does.
LayoutTests:
- fast/multicol/border-radius-overflow-columns-expected.html: Added.
- fast/multicol/border-radius-overflow-columns.html: Added.
- 9:17 AM Changeset in webkit [195452] by
-
- 142 edits in trunk/Source
Reduce use of equalIgnoringCase to just ignore ASCII case
https://bugs.webkit.org/show_bug.cgi?id=153266
Reviewed by Ryosuke Niwa.
Source/WebCore:
Changed many call sites that were using equalIgnoringCase to instead use
equalLettersIgnoringASCIICase. What these all have in common is that the
thing they are comparing with is a string literal that has all lowercase
letters, spaces, and a few simple examples of punctuation.
Not 100% sure that the new function name is just right, but it's a long name
so it's easy to change it with a global replace if we come up with a better one.
Or if we decide ther eis no need for the "letters" optimization, we can change
these all to just use equalIgnoringASCIICase, also with a global replace.
Also made a few tweaks to some code nearby and some includes.
- Modules/encryptedmedia/CDMPrivateClearKey.cpp:
(WebCore::CDMPrivateClearKey::supportsKeySystem): Use equalLettersIgnoringASCIICase.
(WebCore::CDMPrivateClearKey::supportsKeySystemAndMimeType): Ditto.
- Modules/encryptedmedia/CDMSessionClearKey.cpp:
(WebCore::CDMSessionClearKey::update): Ditto.
- Modules/plugins/YouTubePluginReplacement.cpp:
(WebCore::YouTubePluginReplacement::supportsMimeType): Ditto.
(WebCore::YouTubePluginReplacement::supportsFileExtension): Ditto.
- Modules/webdatabase/DatabaseAuthorizer.cpp:
(WebCore::DatabaseAuthorizer::createVTable): Ditto.
(WebCore::DatabaseAuthorizer::dropVTable): Ditto.
- Modules/websockets/WebSocketHandshake.cpp:
(WebCore::WebSocketHandshake::readHTTPHeaders): Ditto.
(WebCore::WebSocketHandshake::checkResponseHeaders): Ditto.
- accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::findAriaModalNodes): Ditto.
(WebCore::AXObjectCache::handleMenuItemSelected): Ditto.
(WebCore::AXObjectCache::handleAriaModalChange): Ditto.
(WebCore::isNodeAriaVisible): Ditto.
- accessibility/AccessibilityListBoxOption.cpp:
(WebCore::AccessibilityListBoxOption::isEnabled): Ditto.
- accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::determineAccessibilityRole): Use isColorControl
instead of checking the typeAttr of the HTMLInputElement directly.
(WebCore::AccessibilityNodeObject::isEnabled): Use equalLettersIgnoringASCIICase.
(WebCore::AccessibilityNodeObject::isPressed): Ditto.
(WebCore::AccessibilityNodeObject::isChecked): Ditto.
(WebCore::AccessibilityNodeObject::isMultiSelectable): Ditto.
(WebCore::AccessibilityNodeObject::isRequired): Ditto.
(WebCore::shouldUseAccessibilityObjectInnerText): Ditto.
(WebCore::AccessibilityNodeObject::colorValue): Ditto.
- accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::contentEditableAttributeIsEnabled):
Use equalLettersIgnoringASCIICase.
(WebCore::AccessibilityObject::ariaIsMultiline): Ditto.
(WebCore::AccessibilityObject::liveRegionStatusIsEnabled): Ditto.
(WebCore::AccessibilityObject::sortDirection): Ditto.
(WebCore::AccessibilityObject::supportsARIAPressed): Ditto.
(WebCore::AccessibilityObject::supportsExpanded): Ditto.
(WebCore::AccessibilityObject::isExpanded): Ditto.
(WebCore::AccessibilityObject::checkboxOrRadioValue): Ditto.
(WebCore::AccessibilityObject::isARIAHidden): Ditto.
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::supportsARIADragging): Ditto.
(WebCore::AccessibilityRenderObject::defaultObjectInclusion): Ditto.
(WebCore::AccessibilityRenderObject::elementAttributeValue): Ditto.
(WebCore::AccessibilityRenderObject::isSelected): Ditto.
(WebCore::AccessibilityRenderObject::determineAccessibilityRole): Ditto.
(WebCore::AccessibilityRenderObject::orientation): Ditto.
(WebCore::AccessibilityRenderObject::canSetExpandedAttribute): Ditto.
(WebCore::AccessibilityRenderObject::canSetValueAttribute): Ditto.
(WebCore::AccessibilityRenderObject::ariaLiveRegionAtomic): Ditto.
- accessibility/AccessibilityTableCell.cpp:
(WebCore::AccessibilityTableCell::ariaRowSpan): Use == to compare a string
with "0" since there is no need to "ignore case" when there are no letters.
- css/CSSCalculationValue.cpp:
(WebCore::CSSCalcValue::create): Use equalLettersIgnoringASCIICase.
- css/CSSCalculationValue.h: Removed unneeded include of CSSParserValues.h.
- css/CSSCustomPropertyValue.h: Ditto.
- css/CSSFontFaceSrcValue.cpp:
(WebCore::CSSFontFaceSrcValue::isSVGFontFaceSrc): Use equalLettersIgnoringASCIICase.
- css/CSSGrammar.y.in: Use equalLettersIgnoringASCIICase. Also restructured the code
a bit to have more normal formatting and reordered it slightly.
- css/CSSParser.cpp:
(WebCore::equal): Deleted.
(WebCore::equalIgnoringCase): Deleted.
(WebCore::equalLettersIgnoringASCIICase): Added. Replaces function templates named
equal and equalIgnoringCase that are no longer used.
(WebCore::CSSParser::parseValue): Use equalLettersIgnoringASCIICase.
(WebCore::CSSParser::parseNonElementSnapPoints): Ditto.
(WebCore::CSSParser::parseAlt): Ditto.
(WebCore::CSSParser::parseContent): Ditto.
(WebCore::CSSParser::parseFillImage): Ditto.
(WebCore::CSSParser::parseAnimationName): Ditto.
(WebCore::CSSParser::parseAnimationTrigger): Ditto.
(WebCore::CSSParser::parseAnimationProperty): Ditto.
(WebCore::CSSParser::parseKeyframeSelector): Ditto.
(WebCore::CSSParser::parseAnimationTimingFunction): Ditto.
(WebCore::CSSParser::parseGridTrackList): Ditto.
(WebCore::CSSParser::parseGridTrackSize): Ditto.
(WebCore::CSSParser::parseDashboardRegions): Ditto.
(WebCore::CSSParser::parseClipShape): Ditto.
(WebCore::CSSParser::parseBasicShapeInset): Ditto.
(WebCore::CSSParser::parseBasicShape): Ditto.
(WebCore::CSSParser::parseFontFaceSrcURI): Ditto.
(WebCore::CSSParser::parseFontFaceSrc): Ditto.
(WebCore::CSSParser::isCalculation): Ditto.
(WebCore::CSSParser::parseColorFromValue): Ditto.
(WebCore::CSSParser::parseBorderImage): Ditto.
(WebCore::parseDeprecatedGradientPoint): Ditto.
(WebCore::parseDeprecatedGradientColorStop): Ditto.
(WebCore::CSSParser::parseDeprecatedGradient): Ditto.
(WebCore::CSSParser::parseLinearGradient): Ditto.
(WebCore::CSSParser::parseRadialGradient): Ditto.
(WebCore::CSSParser::isGeneratedImageValue): Ditto.
(WebCore::CSSParser::parseGeneratedImage): Ditto.
(WebCore::filterInfoForName): Ditto.
(WebCore::validFlowName): Ditto.
(WebCore::CSSParser::realLex): Ditto.
(WebCore::isValidNthToken): Ditto.
- css/CSSParserValues.cpp:
(WebCore::CSSParserSelector::parsePagePseudoSelector): Ditto.
- css/CSSParserValues.h:
(WebCore::equalLettersIgnoringASCIICase): Added.
- css/CSSVariableDependentValue.h: Removed unneeded include of CSSParserValues.h.
- css/MediaList.cpp:
(WebCore::reportMediaQueryWarningIfNeeded): Use equalLettersIgnoringASCIICase.
- css/MediaQueryEvaluator.cpp:
(WebCore::MediaQueryEvaluator::mediaTypeMatch): Ditto.
(WebCore::MediaQueryEvaluator::mediaTypeMatchSpecific): Ditto.
(WebCore::evalResolution): Ditto.
- css/SelectorPseudoTypeMap.h: Removed unneeded include of CSSParserValues.h.
- css/StyleBuilderConverter.h:
(WebCore::StyleBuilderConverter::convertTouchCallout): Use equalLettersIgnoringASCIICase.
- css/makeSelectorPseudoClassAndCompatibilityElementMap.py: Added an include of
CSSParserValues.h since it's no longer included by SelectorPseudoTypeMap.h.
- dom/Document.cpp:
(WebCore::setParserFeature): Use equalLettersIgnoringASCIICase.
(WebCore::Document::processReferrerPolicy): Ditto.
(WebCore::Document::createEvent): Ditto.
(WebCore::Document::parseDNSPrefetchControlHeader): Ditto.
- dom/Element.cpp:
(WebCore::Element::spellcheckAttributeState): Use isNull instead of doing
checking equality with nullAtom. Use isEmpty instead of equalIgnoringCase("").
Use equalLettersIgnoringASCIICase.
(WebCore::Element::canContainRangeEndPoint): Ditto.
- dom/InlineStyleSheetOwner.cpp:
(WebCore::isValidCSSContentType): Use equalLettersIgnoringASCIICase.
Added comment about peculiar behavior where we do case-sensitive processing of
the MIME type if the document is XML.
- dom/ScriptElement.cpp:
(WebCore::ScriptElement::requestScript): Use equalLettersIgnoringASCIICase.
(WebCore::ScriptElement::isScriptForEventSupported): Ditto.
- dom/SecurityContext.cpp:
(WebCore::SecurityContext::parseSandboxPolicy): Ditto.
- dom/ViewportArguments.cpp:
(WebCore::findSizeValue): Ditto.
(WebCore::findScaleValue): Ditto.
(WebCore::findBooleanValue): Ditto.
- editing/EditorCommand.cpp:
(WebCore::executeDefaultParagraphSeparator): Use equalLettersIgnoringASCIICase.
(WebCore::executeInsertBacktab): Use ASCIILiteral.
(WebCore::executeInsertHTML): Use emptyString.
(WebCore::executeInsertLineBreak): Use ASCIILiteral.
(WebCore::executeInsertNewline): Ditto.
(WebCore::executeInsertTab): Ditto.
(WebCore::executeJustifyCenter): Ditto.
(WebCore::executeJustifyFull): Ditto.
(WebCore::executeJustifyLeft): Ditto.
(WebCore::executeJustifyRight): Ditto.
(WebCore::executeStrikethrough): Ditto.
(WebCore::executeStyleWithCSS): Use equalLettersIgnoringASCIICase.
(WebCore::executeUseCSS): Ditto.
(WebCore::executeSubscript): Use ASCIILiteral.
(WebCore::executeSuperscript): Ditto.
(WebCore::executeToggleBold): Ditto.
(WebCore::executeToggleItalic): Ditto.
(WebCore::executeUnderline): Ditto.
(WebCore::executeUnscript): Ditto.
(WebCore::stateBold): Ditto.
(WebCore::stateItalic): Ditto.
(WebCore::stateStrikethrough): Ditto.
(WebCore::stateSubscript): Ditto.
(WebCore::stateSuperscript): Ditto.
(WebCore::stateUnderline): Ditto.
(WebCore::stateJustifyCenter): Ditto.
(WebCore::stateJustifyFull): Ditto.
(WebCore::stateJustifyLeft): Ditto.
(WebCore::stateJustifyRight): Ditto.
(WebCore::valueFormatBlock): Use emptyString.
(WebCore::Editor::Command::value): Use ASCIILiteral.
- editing/TextIterator.cpp:
(WebCore::isRendererReplacedElement): Use equalLettersIgnoringASCIICase.
- fileapi/Blob.cpp:
(WebCore::Blob::isNormalizedContentType): Use isASCIIUpper.
- history/HistoryItem.cpp:
(WebCore::HistoryItem::setFormInfoFromRequest): Use equalLettersIgnoringASCIICase.
- html/Autocapitalize.cpp:
(WebCore::valueOn): Deleted.
(WebCore::valueOff): Deleted.
(WebCore::valueNone): Deleted.
(WebCore::valueWords): Deleted.
(WebCore::valueSentences): Deleted.
(WebCore::valueAllCharacters): Deleted.
(WebCore::autocapitalizeTypeForAttributeValue): Use equalLettersIgnoringASCIICase.
(WebCore::stringForAutocapitalizeType): Put the AtomicString globals right in the
switch statement instead of in separate functions.
- html/HTMLAnchorElement.cpp:
(WebCore::HTMLAnchorElement::draggable): Use equalLettersIgnoringASCIICase.
- html/HTMLAreaElement.cpp:
(WebCore::HTMLAreaElement::parseAttribute): Ditto.
- html/HTMLBRElement.cpp:
(WebCore::HTMLBRElement::collectStyleForPresentationAttribute): Ditto.
- html/HTMLBodyElement.cpp:
(WebCore::HTMLBodyElement::collectStyleForPresentationAttribute): Ditto.
- html/HTMLButtonElement.cpp:
(WebCore::HTMLButtonElement::parseAttribute): Ditto.
- html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::toDataURL): Use ASCIILiteral.
- html/HTMLDivElement.cpp:
(WebCore::HTMLDivElement::collectStyleForPresentationAttribute):
Use equalLettersIgnoringASCIICase.
- html/HTMLDocument.cpp:
(WebCore::HTMLDocument::designMode): Use ASCIILiteral.
(WebCore::HTMLDocument::setDesignMode): Use equalLettersIgnoringASCIICase.
- html/HTMLElement.cpp:
(WebCore::HTMLElement::nodeName): Updated comment.
(WebCore::isLTROrRTLIgnoringCase): Use equalLettersIgnoringASCIICase.
(WebCore::contentEditableType): Ditto.
(WebCore::HTMLElement::collectStyleForPresentationAttribute): Ditto.
(WebCore::toValidDirValue): Ditto.
(WebCore::HTMLElement::insertAdjacent): Ditto.
(WebCore::contextElementForInsertion): Ditto.
(WebCore::HTMLElement::applyAlignmentAttributeToStyle): Ditto.
(WebCore::HTMLElement::setContentEditable): Ditto.
(WebCore::HTMLElement::draggable): Ditto.
(WebCore::HTMLElement::translateAttributeMode): Ditto.
(WebCore::HTMLElement::hasDirectionAuto): Ditto.
(WebCore::HTMLElement::directionality): Ditto.
(WebCore::HTMLElement::dirAttributeChanged): Ditto.
(WebCore::HTMLElement::addHTMLColorToStyle): Ditto.
- html/HTMLEmbedElement.cpp:
(WebCore::HTMLEmbedElement::collectStyleForPresentationAttribute): Ditto.
- html/HTMLFormControlElement.cpp:
(WebCore::HTMLFormControlElement::autocorrect): Ditto.
- html/HTMLFormElement.cpp:
(WebCore::HTMLFormElement::autocorrect): Ditto.
(WebCore::HTMLFormElement::shouldAutocomplete): Ditto.
- html/HTMLFrameElementBase.cpp:
(WebCore::HTMLFrameElementBase::parseAttribute): Ditto.
- html/HTMLFrameSetElement.cpp:
(WebCore::HTMLFrameSetElement::parseAttribute): Use equalLettersIgnoringASCIICase.
Use == when comparing with "0" and "1" since there is no need for case folding.
- html/HTMLHRElement.cpp:
(WebCore::HTMLHRElement::collectStyleForPresentationAttribute):
Use equalLettersIgnoringASCIICase.
- html/HTMLImageElement.cpp:
(WebCore::HTMLImageElement::draggable): Ditto.
- html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::parseAttribute): Ditto.
- html/HTMLKeygenElement.cpp:
(WebCore::HTMLKeygenElement::appendFormData): Ditto.
- html/HTMLMarqueeElement.cpp:
(WebCore::HTMLMarqueeElement::collectStyleForPresentationAttribute): Ditto.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::parseAttribute): Ditto.
- html/HTMLMetaElement.cpp:
(WebCore::HTMLMetaElement::process): Ditto.
- html/HTMLObjectElement.cpp:
(WebCore::mapDataParamToSrc): Use references, modern for loops, simplify
logic to not use array indices, use ASCIILiteral and equalLettersIgnoringASCIICase.
(WebCore::HTMLObjectElement::parametersForPlugin): Update to call new function.
(WebCore::HTMLObjectElement::shouldAllowQuickTimeClassIdQuirk): Use equalLettersIgnoringASCIICase.
(WebCore::HTMLObjectElement::containsJavaApplet): Ditto.
- html/HTMLParagraphElement.cpp:
(WebCore::HTMLParagraphElement::collectStyleForPresentationAttribute): Ditto.
- html/HTMLParamElement.cpp:
(WebCore::HTMLParamElement::isURLParameter): Ditto.
- html/HTMLTableElement.cpp:
(WebCore::getBordersFromFrameAttributeValue): Ditto.
(WebCore::HTMLTableElement::collectStyleForPresentationAttribute): Ditto.
(WebCore::HTMLTableElement::parseAttribute): Ditto.
- html/HTMLTablePartElement.cpp:
(WebCore::HTMLTablePartElement::collectStyleForPresentationAttribute): Ditto.
- html/HTMLTextAreaElement.cpp:
(WebCore::HTMLTextAreaElement::parseAttribute): Ditto.
- html/HTMLTextFormControlElement.cpp:
(WebCore::HTMLTextFormControlElement::setRangeText): Ditto.
(WebCore::HTMLTextFormControlElement::directionForFormData): Ditto.
- html/HTMLVideoElement.cpp:
(WebCore::HTMLVideoElement::parseAttribute): Ditto.
- html/InputType.cpp:
(WebCore::InputType::applyStep): Ditto.
- html/LinkRelAttribute.cpp:
(WebCore::LinkRelAttribute::LinkRelAttribute): Ditto.
- html/MediaElementSession.cpp:
(WebCore::MediaElementSession::wirelessVideoPlaybackDisabled): Ditto.
- html/NumberInputType.cpp:
(WebCore::NumberInputType::sizeShouldIncludeDecoration): Ditto.
- html/RangeInputType.cpp:
(WebCore::RangeInputType::createStepRange): Ditto.
(WebCore::RangeInputType::handleKeydownEvent): Ditto.
- html/StepRange.cpp:
(WebCore::StepRange::parseStep): Ditto.
- html/canvas/CanvasStyle.cpp:
(WebCore::parseColor): Ditto.
- html/parser/HTMLConstructionSite.cpp:
(WebCore::HTMLConstructionSite::setCompatibilityModeFromDoctype): Ditto.
- html/parser/HTMLElementStack.cpp:
(WebCore::HTMLElementStack::isHTMLIntegrationPoint): Ditto.
- html/parser/HTMLMetaCharsetParser.cpp:
(WebCore::HTMLMetaCharsetParser::encodingFromMetaAttributes): Ditto.
- html/parser/HTMLPreloadScanner.cpp:
(WebCore::TokenPreloadScanner::StartTagScanner::processAttribute): Ditto.
(WebCore::TokenPreloadScanner::StartTagScanner::crossOriginModeAllowsCookies): Ditto.
- html/parser/HTMLTreeBuilder.cpp:
(WebCore::HTMLTreeBuilder::processStartTagForInBody): Ditto.
(WebCore::HTMLTreeBuilder::processStartTagForInTable): Ditto.
- html/parser/XSSAuditor.cpp:
(WebCore::isDangerousHTTPEquiv): Ditto.
- html/track/WebVTTParser.cpp:
(WebCore::WebVTTParser::hasRequiredFileIdentifier): Removed unneeded special case
for empty string.
- inspector/InspectorPageAgent.cpp:
(WebCore::createXHRTextDecoder): Use equalLettersIgnoringASCIICase.
- inspector/NetworkResourcesData.cpp:
(WebCore::createOtherResourceTextDecoder): Ditto.
- loader/CrossOriginAccessControl.cpp:
(WebCore::isOnAccessControlSimpleRequestHeaderWhitelist): Ditto.
- loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::continueAfterContentPolicy): Ditto.
- loader/FormSubmission.cpp:
(WebCore::appendMailtoPostFormDataToURL): Ditto.
(WebCore::FormSubmission::Attributes::parseEncodingType): Ditto.
(WebCore::FormSubmission::Attributes::parseMethodType): Ditto.
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::shouldPerformFragmentNavigation): Ditto.
(WebCore::FrameLoader::shouldTreatURLAsSrcdocDocument): Ditto.
- loader/ImageLoader.cpp:
(WebCore::ImageLoader::updateFromElement): Ditto.
- loader/MediaResourceLoader.cpp:
(WebCore::MediaResourceLoader::start): Ditto.
- loader/SubframeLoader.cpp:
(WebCore::SubframeLoader::createJavaAppletWidget): Ditto.
- loader/TextResourceDecoder.cpp:
(WebCore::TextResourceDecoder::determineContentType): Ditto.
- loader/TextTrackLoader.cpp:
(WebCore::TextTrackLoader::load): Ditto.
- loader/appcache/ApplicationCache.cpp:
(WebCore::ApplicationCache::requestIsHTTPOrHTTPSGet): Ditto.
- loader/cache/CachedCSSStyleSheet.cpp:
(WebCore::CachedCSSStyleSheet::canUseSheet): Ditto.
- loader/cache/CachedResource.cpp:
(WebCore::shouldCacheSchemeIndefinitely): Ditto.
- page/DOMSelection.cpp:
(WebCore::DOMSelection::modify): Ditto.
- page/EventSource.cpp:
(WebCore::EventSource::didReceiveResponse): Ditto.
- page/FrameView.cpp:
(WebCore::FrameView::scrollToAnchor): Ditto.
- page/Performance.cpp:
(WebCore::Performance::webkitGetEntriesByType): Ditto.
- page/PerformanceResourceTiming.cpp:
(WebCore::passesTimingAllowCheck): Ditto.
- page/SecurityOrigin.cpp:
(WebCore::SecurityOrigin::SecurityOrigin): Use emptyString.
(WebCore::SecurityOrigin::toString): Use ASCIILiteral.
(WebCore::SecurityOrigin::databaseIdentifier): Ditto.
- page/UserContentURLPattern.cpp:
(WebCore::UserContentURLPattern::parse): Use equalLettersIgnoringASCIICase.
(WebCore::UserContentURLPattern::matches): Ditto.
- platform/URL.cpp:
(WebCore::URL::protocolIs): Ditto.
- platform/graphics/avfoundation/CDMPrivateMediaSourceAVFObjC.mm:
(WebCore::CDMPrivateMediaSourceAVFObjC::supportsKeySystemAndMimeType):
Changed to use early exit and equalLettersIgnoringASCIICase. Added comment
about inconsistency with next function.
(WebCore::CDMPrivateMediaSourceAVFObjC::supportsMIMEType): Added comment
about inconsistency with previous function.
- platform/graphics/avfoundation/objc/CDMSessionAVContentKeySession.mm:
(WebCore::CDMSessionAVContentKeySession::generateKeyRequest):
Use equalLettersIgnoringASCIICase.
- platform/graphics/avfoundation/objc/CDMSessionAVStreamSession.mm:
(WebCore::CDMSessionAVStreamSession::generateKeyRequest): Ditto.
- platform/graphics/cg/ImageBufferCG.cpp:
(WebCore::utiFromMIMEType): Ditto.
- platform/graphics/cocoa/FontCacheCoreText.cpp:
(WebCore::FontCache::similarFont): Changed to not use so many global
variables and use equalLettersIgnoringASCIICase.
- platform/graphics/ios/FontCacheIOS.mm:
(WebCore::platformFontWithFamilySpecialCase): Ditto.
- platform/graphics/mac/FontCustomPlatformData.cpp:
(WebCore::FontCustomPlatformData::supportsFormat): Use equalLettersIgnoringASCIICase.
- platform/mac/PasteboardMac.mm:
(WebCore::Pasteboard::readString): Ditto.
- platform/network/BlobResourceHandle.cpp:
(WebCore::BlobResourceHandle::createAsync): Ditto.
(WebCore::BlobResourceHandle::loadResourceSynchronously): Ditto.
- platform/network/CacheValidation.cpp:
(WebCore::parseCacheControlDirectives): Ditto.
- platform/network/FormData.h:
(WebCore::FormData::parseEncodingType): Ditto.
- platform/network/HTTPParsers.cpp:
(WebCore::contentDispositionType): Ditto.
(WebCore::parseXFrameOptionsHeader): Ditto.
- platform/network/ResourceResponseBase.cpp:
(WebCore::ResourceResponseBase::isHTTP): Use protocolIsInHTTPFamily, which is
both clearer and more efficient.
(WebCore::ResourceResponseBase::isAttachment): Rewrite to be a bit more terse
and use equalLettersIgnoringASCIICase.
- platform/network/cf/ResourceHandleCFURLConnectionDelegate.cpp:
(WebCore::ResourceHandleCFURLConnectionDelegate::createResourceRequest):
Use equalLettersIgnoringASCIICase.
- platform/network/mac/ResourceHandleMac.mm:
(WebCore::ResourceHandle::willSendRequest): Ditto.
- platform/sql/SQLiteDatabase.cpp:
(WebCore::SQLiteDatabase::open): Ditto.
- platform/sql/SQLiteStatement.cpp:
(WebCore::SQLiteStatement::isColumnDeclaredAsBlob): Ditto.
- platform/text/TextEncodingRegistry.cpp:
(WebCore::defaultTextEncodingNameForSystemLanguage): Use ASCIILiteral
and equalLettersIgnoringASCIICase.
- rendering/mathml/RenderMathMLFraction.cpp:
(WebCore::RenderMathMLFraction::updateFromElement): Use equalLettersIgnoringASCIICase.
- svg/SVGToOTFFontConversion.cpp:
(WebCore::SVGToOTFFontConverter::compareCodepointsLexicographically): Ditto.
(WebCore::SVGToOTFFontConverter::SVGToOTFFontConverter): Ditto.
- testing/InternalSettings.cpp:
(WebCore::InternalSettings::setEditingBehavior): Ditto.
(WebCore::InternalSettings::setShouldDisplayTrackKind): Ditto.
(WebCore::InternalSettings::shouldDisplayTrackKind): Ditto.
- testing/Internals.cpp:
(WebCore::markerTypeFrom): Ditto.
(WebCore::markerTypesFrom): Ditto.
(WebCore::Internals::mediaElementHasCharacteristic): Ditto.
(WebCore::Internals::setCaptionDisplayMode): Ditto.
(WebCore::Internals::beginMediaSessionInterruption): Ditto.
(WebCore::Internals::endMediaSessionInterruption): Ditto.
(WebCore::Internals::setMediaSessionRestrictions): Ditto.
(WebCore::Internals::setMediaElementRestrictions): Ditto.
(WebCore::Internals::postRemoteControlCommand): Ditto.
(WebCore::Internals::setAudioContextRestrictions): Ditto.
(WebCore::Internals::setMockMediaPlaybackTargetPickerState): Ditto.
- testing/MockCDM.cpp:
(WebCore::MockCDM::supportsKeySystem): Ditto.
(WebCore::MockCDM::supportsKeySystemAndMimeType): Ditto.
(WebCore::MockCDM::supportsMIMEType): Ditto.
- xml/XMLHttpRequest.cpp:
(WebCore::isSetCookieHeader): Ditto.
(WebCore::XMLHttpRequest::responseXML): Ditto.
(WebCore::XMLHttpRequest::isAllowedHTTPMethod): Ditto.
(WebCore::XMLHttpRequest::didReceiveData): Ditto.
Source/WebKit:
- Storage/StorageTracker.cpp:
(WebCore::StorageTracker::syncFileSystemAndTrackerDatabase):
Removed extraneous unneeded ", true" in call to String::endsWith.
Preparation for later removing the boolean argument.
Source/WebKit/mac:
- WebCoreSupport/WebFrameLoaderClient.mm:
(WebFrameLoaderClient::createPlugin): Use equalLettersIgnoringASCIICase.
Source/WebKit2:
- UIProcess/PageLoadState.cpp:
(WebKit::PageLoadState::hasOnlySecureContent): Use the protocolIs
function from WebCore instead of calling startsWith.
- WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
(WebKit::NetscapePlugin::initialize): Use equalLettersIgnoringASCIICase.
Source/WTF:
- wtf/ASCIICType.h:
(WTF::isASCIIAlphaCaselessEqual): Loosened the assertion in this function
so it can work with ASCII spaces, numeric digits, and some punctuation.
Commented that we might want to change its name later.
- wtf/Assertions.cpp:
(WTFInitializeLogChannelStatesFromString): Use equalLettersIgnoringASCIICase.
- wtf/text/AtomicString.h:
(WTF::equalLettersIgnoringASCIICase): Added. Calls the version that takes a String.
- wtf/text/StringCommon.h:
(WTF::equalLettersIgnoringASCIICase): Added. Takes a pointer to characters.
(WTF::equalLettersIgnoringASCIICaseCommonWithoutLength): Added.
(WTF::equalLettersIgnoringASCIICaseCommon): Added.
- wtf/text/StringImpl.h:
(WTF::equalLettersIgnoringASCIICase): Added. Calls equalLettersIgnoringASCIICaseCommon.
- wtf/text/StringView.h:
(WTF::equalLettersIgnoringASCIICase): Added. Calls equalLettersIgnoringASCIICaseCommon.
- wtf/text/WTFString.h: Reordered/reformatted a little.
(WTF::equalIgnoringASCIICase): Added. Calls the version that takes a StringImpl.
- 8:50 AM Changeset in webkit [195451] by
-
- 9 edits in trunk/Source
[Mac] Tooltips do not honor some types of obscuring windows
https://bugs.webkit.org/show_bug.cgi?id=153263
<rdar://problem/21423972>
Reviewed by Simon Fraser.
Source/WebKit/mac:
- WebView/WebHTMLView.mm:
(-[WebHTMLView _updateMouseoverWithEvent:]): When the WebView is not the key window, don't
display tooltips.
Source/WebKit2:
Recognize that the current WebView is obscured by comparing the current event's Window Number against
the Window Number of the current WebView. If they don't match, something is in the way.
- UIProcess/Cocoa/WebViewImpl.h:
- UIProcess/Cocoa/WebViewImpl.mm:
(WebKit::WebViewImpl::windowIsFrontWindowUnderMouse): Added.
- UIProcess/PageClient.h:
(WebKit::PageClient::windowIsFrontWindowUnderMouse):
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::handleMouseEvent): Check if the current WebView is obscured. If it
is, clear the tooltip and return.
- UIProcess/mac/PageClientImpl.h:
- UIProcess/mac/PageClientImpl.mm:
(WebKit::PageClientImpl::windowIsFrontWindowUnderMouse): Added.
- 6:51 AM Changeset in webkit [195450] by
-
- 23 edits in trunk/Source
Remove PassRefPtr from ResourceRequest and FormData
https://bugs.webkit.org/show_bug.cgi?id=153229
Reviewed by Chris Dumez.
Source/WebCore:
Covered by existing tests.
Making ResourceRequest::setHTTPBody take a RefPtr<FormData>&&.
Moving FormData from PassRefPtr to RefPtr.
- html/parser/XSSAuditorDelegate.cpp:
(WebCore::XSSAuditorDelegate::didBlockScript):
- loader/FormSubmission.cpp:
(WebCore::FormSubmission::populateFrameLoadRequest):
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::loadPostRequest):
(WebCore::FrameLoader::loadDifferentDocumentItem):
- loader/PingLoader.cpp:
(WebCore::PingLoader::sendViolationReport):
- loader/PingLoader.h:
- page/ContentSecurityPolicy.cpp:
(WebCore::ContentSecurityPolicy::reportViolation):
- platform/network/FormData.cpp:
(WebCore::FormData::create):
(WebCore::FormData::createMultiPart):
(WebCore::FormData::copy):
(WebCore::FormData::deepCopy):
(WebCore::FormData::resolveBlobReferences):
- platform/network/FormData.h:
(WebCore::FormData::decode):
- platform/network/ResourceRequestBase.cpp:
(WebCore::ResourceRequestBase::adopt):
(WebCore::ResourceRequestBase::setHTTPBody):
- platform/network/ResourceRequestBase.h:
(WebCore::ResourceRequestBase::setHTTPBody):
- platform/network/cf/FormDataStreamCFNet.cpp:
(WebCore::setHTTPBody):
- platform/network/cf/FormDataStreamCFNet.h:
- platform/network/cf/ResourceRequestCFNet.cpp:
(WebCore::ResourceRequest::doUpdatePlatformHTTPBody):
(WebCore::ResourceRequest::updateFromDelegatePreservingOldProperties):
- platform/network/cocoa/ResourceRequestCocoa.mm:
(WebCore::ResourceRequest::doUpdatePlatformHTTPBody):
- platform/network/curl/ResourceHandleManager.cpp:
(WebCore::getFormElementsCount):
- platform/network/mac/FormDataStreamMac.h:
- platform/network/mac/FormDataStreamMac.mm:
(WebCore::setHTTPBody):
- platform/network/soup/ResourceHandleSoup.cpp:
(WebCore::doRedirect):
- xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::createRequest):
Source/WebKit/win:
- WebMutableURLRequest.cpp:
(WebMutableURLRequest::setHTTPBody):
Source/WebKit2:
- NetworkProcess/NetworkResourceLoadParameters.cpp:
(WebKit::NetworkResourceLoadParameters::decode):
- NetworkProcess/cache/NetworkCacheEntry.cpp:
(WebKit::NetworkCache::Entry::Entry):
- 3:06 AM Changeset in webkit [195449] by
-
- 2 edits in trunk/Source/WebCore
Fix the !ENABLE(INDEXED_DATABASE) build after r195443
https://bugs.webkit.org/show_bug.cgi?id=153350
Unreviewed buildfix.
- page/Page.cpp:
(WebCore::Page::setSessionID):
- 3:01 AM Changeset in webkit [195448] by
-
- 2 edits in trunk/Source/WTF
Buildfix for older GCCs after r195142
https://bugs.webkit.org/show_bug.cgi?id=153351
Unreviewed buildfix.
- wtf/SystemTracing.h:
- 1:19 AM Changeset in webkit [195447] by
-
- 3 edits2 deletes in trunk
[GTK] Remove a focus ring on anchor node when focused by mouse.
https://bugs.webkit.org/show_bug.cgi?id=136121
Reviewed by Michael Catanzaro.
Source/WebCore:
Safari, Chrome and FF don't show a focus ring, the dotted rectangle on anchor node
for mouse clicking. I think the behavior is reasonable and looks better.
No reason for gtk & efl ports to keep the focus on anchor node. Of course, this change should not
affect the focus ring for tab navigation.
No new tests since an existing test can cover this.
Tests: fast/events/click-focus-anchor.html
- html/HTMLAnchorElement.cpp:
(WebCore::HTMLAnchorElement::isMouseFocusable):
LayoutTests:
Removed gtk and efl specific results for the test.
- platform/efl/fast/events/click-focus-anchor-expected.txt: Removed.
- platform/gtk/fast/events/click-focus-anchor-expected.txt: Removed.
Jan 21, 2016:
- 11:24 PM Changeset in webkit [195446] by
-
- 2 edits in trunk/Source/JavaScriptCore
[JSC] The IRC allocator can mess up the degree of Tmps interfering with move-related Tmps
https://bugs.webkit.org/show_bug.cgi?id=153340
Reviewed by Filip Pizlo.
The JavaScriptCore tests uncovered an interested bug in the iterated register
coalescing allocator. When coalescing a move under the right conditions, it is
possible to mess-up the graph for the Tmps interfering with the coalesced Tmps.
Some context first:
-When coalescing a move, we alias one Tmp to another. Let say that we had
Move X, Y
the coalescing may alias Y to X: Y->X.
-Since X and Y are equivalent after coalescing, any interference
edge with Y is "moved" to X.
The way this was done was to add an edge to X for every edge there was with Y.
Say we had an edge R--Y, we add an edge R--X.
Adding an edge increases the degree of R and Y. The degree of R was then
fixed by calling decrementDegree() on it.
-decrementDegree() is non trivial. It will move the Tmp to the right list
for further processing if the Tmp's degree becomes lower than the number
of available registers.
The bug appear in a particular case. Say we have 3 Tmp, A, B, and C.
-A and B are move related, they can be coalesced.
-A has an interference edge with C.
-B does not have and interfence edge with C.
-C's degree is exactly the number of avaialble registers/colors minus one (k - 1).
-> This implies C is already in its list.
We coalesce A and B into B (A->B).
-The first step, addEdgeDistinct() adds an edge between B and C. The degrees of
B and C are increased by one. The degree of C becomes k.
-Next, decrementDegree() is called on C. Its degree decreases to k-1.
Because of the change from k to k-1, decrementDegree() adds C to a list again.
We have two kinds of bugs depending on the test:
-A Tmp can be added to the simplifyWorklist several time.
-A Tmp can be in both simplifyWorklist and freezeWorklist (because its move-related
status changed since the last decrementDegree()).
In both cases, the Tmps interfering with the duplicated Tmp will end up with
a degree lower than their real value.
- b3/air/AirIteratedRegisterCoalescing.cpp:
- 10:45 PM Changeset in webkit [195445] by
-
- 9 edits2 adds in trunk
REGRESSION (r168244): Content in horizontal-bt page is offset such that only the end is viewable and there is a white gap at the top
https://bugs.webkit.org/show_bug.cgi?id=136019
Reviewed by Dan Bernstein.
Source/WebCore:
In horizontal-bt documents (where the page starts scrolled to the bottom, and scrolling up goes into negative scroll positions),
the position of the root content layer would be set incorrectly by the scrolling thread, resulting in misplaced
content.
Fix by having the renamed "yPositionForRootContentLayer" take scroll origin into
account, and being more consistent about using scrollOrigin to position this layer.
Test: fast/scrolling/programmatic-horizontal-bt-document-scroll.html
- page/FrameView.cpp:
(WebCore::FrameView::yPositionForFooterLayer): Moved
(WebCore::FrameView::positionForRootContentLayer): Take scrollOrigin, and subtract it from the computed value.
(WebCore::FrameView::yPositionForRootContentLayer): Renamed.
- page/FrameView.h:
- page/scrolling/AsyncScrollingCoordinator.cpp:
(WebCore::AsyncScrollingCoordinator::updateScrollPositionAfterAsyncScroll): We've already pushed the new scrollPosition onto the FrameView,
so we can just use the member function to compute the positionForContentsLayer.
- page/scrolling/mac/ScrollingTreeFrameScrollingNodeMac.mm:
(WebCore::ScrollingTreeFrameScrollingNodeMac::setScrollLayerPosition): This is the bug fix; FrameView::positionForRootContentLayer()
now takes scrollOrigin into account.
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::updateRootLayerPosition): Rather than using the documentRect, position the root content layer
in terms of the scroll origin (which is -documentRect.location()).
Source/WebKit2:
Now call frameView.positionForRootContentLayer(), and add a FIXME questioning the
behavior in horizontal b-t documents. However, this code isn't hit now that we always
do extended backgrounds, so never have shadow layers.
- WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::shadowLayerPositionForFrame):
LayoutTests:
Test that scrolls a horizontal-bt document.
- fast/scrolling/programmatic-horizontal-bt-document-scroll-expected.html: Added.
- fast/scrolling/programmatic-horizontal-bt-document-scroll.html: Added.
- 10:44 PM Changeset in webkit [195444] by
-
- 2 edits in trunk/Tools
Fix the lldb WebCoreLayoutUnitProvider to not dynamically look up the LayoutUnit denominator
https://bugs.webkit.org/show_bug.cgi?id=153334
Reviewed by Zalan Bujtas.
Evaluating expressions in the LayoutUnit summary provider seems to cause
re-entrancy problems in lldb python bindings, so just hardcode the LayoutUnit
denominator to 64.
- lldb/lldb_webkit.py:
(WebCoreLayoutUnitProvider.to_string):
- 10:39 PM Changeset in webkit [195443] by
-
- 11 edits6 adds in trunk
Modern IDB: Support populating/extracting database metadata with SQLite backend.
Source/WebCore:
Nhttps://bugs.webkit.org/show_bug.cgi?id=153318
Reviewed by Alex Christensen.
No new tests (Covered by current tests).
- CMakeLists.txt:
- WebCore.xcodeproj/project.pbxproj:
- Modules/indexeddb/client/IDBDatabaseImpl.cpp:
(WebCore::IDBClient::IDBDatabase::willAbortTransaction): Committing transactions can abort if the commit
ends in error.
- Modules/indexeddb/client/IDBTransactionImpl.cpp:
(WebCore::IDBClient::IDBTransaction::didCommit): Before a committing transaction is aborted, notify the
IDBDatabase that it aborted.
Copied over from WK2:
- Modules/indexeddb/server/IDBSerialization.cpp: Added.
(WebCore::serializeIDBKeyPath):
(WebCore::deserializeIDBKeyPath):
(WebCore::serializeIDBKeyData):
(WebCore::deserializeIDBKeyData):
- Modules/indexeddb/server/IDBSerialization.h: Added.
- Modules/indexeddb/server/IDBServer.cpp:
(WebCore::IDBServer::IDBServer::createBackingStore): Optionally create a SQLite backing store.
Mostly copied over verbatim from WebKit2's UniqueIDBDatabaseBackingStoreSQLite.cpp:
- Modules/indexeddb/server/SQLiteIDBBackingStore.cpp:
(WebCore::IDBServer::idbKeyCollate):
(WebCore::IDBServer::v1RecordsTableSchema):
(WebCore::IDBServer::v1RecordsTableSchemaAlternate):
(WebCore::IDBServer::v2RecordsTableSchema):
(WebCore::IDBServer::v2RecordsTableSchemaAlternate):
(WebCore::IDBServer::createOrMigrateRecordsTableIfNecessary):
(WebCore::IDBServer::SQLiteIDBBackingStore::ensureValidRecordsTable):
(WebCore::IDBServer::SQLiteIDBBackingStore::createAndPopulateInitialDatabaseInfo):
(WebCore::IDBServer::SQLiteIDBBackingStore::extractExistingDatabaseInfo):
(WebCore::IDBServer::SQLiteIDBBackingStore::getOrEstablishDatabaseInfo):
(WebCore::IDBServer::SQLiteIDBBackingStore::beginTransaction):
(WebCore::IDBServer::SQLiteIDBBackingStore::abortTransaction):
(WebCore::IDBServer::SQLiteIDBBackingStore::commitTransaction):
(WebCore::IDBServer::SQLiteIDBBackingStore::createObjectStore):
(WebCore::IDBServer::SQLiteIDBBackingStore::unregisterCursor):
- Modules/indexeddb/server/SQLiteIDBBackingStore.h:
Copied over from WK2:
- Modules/indexeddb/server/SQLiteIDBCursor.cpp: Added.
(WebCore::IDBServer::SQLiteIDBCursor::maybeCreate):
(WebCore::IDBServer::SQLiteIDBCursor::SQLiteIDBCursor):
(WebCore::IDBServer::buildIndexStatement):
(WebCore::IDBServer::buildObjectStoreStatement):
(WebCore::IDBServer::SQLiteIDBCursor::establishStatement):
(WebCore::IDBServer::SQLiteIDBCursor::createSQLiteStatement):
(WebCore::IDBServer::SQLiteIDBCursor::objectStoreRecordsChanged):
(WebCore::IDBServer::SQLiteIDBCursor::resetAndRebindStatement):
(WebCore::IDBServer::SQLiteIDBCursor::bindArguments):
(WebCore::IDBServer::SQLiteIDBCursor::advance):
(WebCore::IDBServer::SQLiteIDBCursor::advanceUnique):
(WebCore::IDBServer::SQLiteIDBCursor::advanceOnce):
(WebCore::IDBServer::SQLiteIDBCursor::internalAdvanceOnce):
(WebCore::IDBServer::SQLiteIDBCursor::iterate):
- Modules/indexeddb/server/SQLiteIDBCursor.h: Added.
(WebCore::IDBServer::SQLiteIDBCursor::identifier):
(WebCore::IDBServer::SQLiteIDBCursor::transaction):
(WebCore::IDBServer::SQLiteIDBCursor::objectStoreID):
(WebCore::IDBServer::SQLiteIDBCursor::currentKey):
(WebCore::IDBServer::SQLiteIDBCursor::currentPrimaryKey):
(WebCore::IDBServer::SQLiteIDBCursor::currentValueBuffer):
(WebCore::IDBServer::SQLiteIDBCursor::didError):
Copied over from WK2:
- Modules/indexeddb/server/SQLiteIDBTransaction.cpp: Added.
(WebCore::IDBServer::SQLiteIDBTransaction::SQLiteIDBTransaction):
(WebCore::IDBServer::SQLiteIDBTransaction::~SQLiteIDBTransaction):
(WebCore::IDBServer::SQLiteIDBTransaction::begin):
(WebCore::IDBServer::SQLiteIDBTransaction::commit):
(WebCore::IDBServer::SQLiteIDBTransaction::reset):
(WebCore::IDBServer::SQLiteIDBTransaction::rollback):
(WebCore::IDBServer::SQLiteIDBTransaction::maybeOpenCursor):
(WebCore::IDBServer::SQLiteIDBTransaction::closeCursor):
(WebCore::IDBServer::SQLiteIDBTransaction::notifyCursorsOfChanges):
(WebCore::IDBServer::SQLiteIDBTransaction::clearCursors):
(WebCore::IDBServer::SQLiteIDBTransaction::inProgress):
- Modules/indexeddb/server/SQLiteIDBTransaction.h: Added.
(WebCore::IDBServer::SQLiteIDBTransaction::transactionIdentifier):
(WebCore::IDBServer::SQLiteIDBTransaction::mode):
(WebCore::IDBServer::SQLiteIDBTransaction::sqliteTransaction):
- page/Page.cpp:
(WebCore::Page::setSessionID): If the new SessionID is different from the last one,
clear the IDBConnectionToServer.
(WebCore::Page::idbConnection): Always ask the DatabaseProvider; It handles whether or not
the session is ephemeral.
LayoutTests:
https://bugs.webkit.org/show_bug.cgi?id=153318
Reviewed by Alex Christensen.
- platform/mac-wk1/TestExpectations: Skip all of the tests that run against the SQLite backend and currently fail (which is most of them!)
- 9:54 PM Changeset in webkit [195442] by
-
- 3 edits2 adds in trunk
REGRESSION (r195305): Web Inspector: WebInspector.Object can dispatch constructor-level events multiple times
https://bugs.webkit.org/show_bug.cgi?id=153269
<rdar://problem/24253106>
Reviewed by Timothy Hatcher.
Source/WebInspectorUI:
Bring back object.hasOwnProperty("_listeners") check.
- UserInterface/Base/Object.js:
(WebInspector.Object.prototype.dispatchEventToListeners.dispatch):
(WebInspector.Object.prototype.dispatchEventToListeners):
(WebInspector.Object):
Check !object._listeners before !object.hasOwnProperty("_listeners")
because !object._listeners is more common case thus we can exit earlier
most of the time.
LayoutTests:
- inspector/unit-tests/object-expected.txt: Added.
- inspector/unit-tests/object.html: Added.
- 9:49 PM Changeset in webkit [195441] by
-
- 2 edits in trunk/Source/WebCore
CMake build fix after r195302.
- PlatformMac.cmake:
- 9:22 PM Changeset in webkit [195440] by
-
- 6 edits in trunk/Source/JavaScriptCore
Add some missing WTF_MAKE_FAST_ALLOCATED in JavaScriptCore.
<https://webkit.org/b/153335>
Reviewed by Alex Christensen.
Saw these things getting system malloc()'ed in an Instruments trace.
- inspector/InspectorAgentBase.h:
- jit/CallFrameShuffleData.h:
- jit/CallFrameShuffler.h:
- jit/RegisterAtOffsetList.h:
- runtime/GenericOffset.h:
- 8:21 PM Changeset in webkit [195439] by
-
- 23 edits3 adds in trunk
[ES6] Catch parameter should accept BindingPattern
https://bugs.webkit.org/show_bug.cgi?id=152385
Reviewed by Saam Barati.
Source/JavaScriptCore:
This patch implements destructuring in catch parameter.
Catch parameter accepts binding pattern and binding identifier.
It creates lexical bindings. And "yield" and "let" are specially
handled as is the same to function parameters.
In addition to that, we make destructuring parsing errors more descriptive.
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::emitPushCatchScope):
- bytecompiler/BytecodeGenerator.h:
- bytecompiler/NodesCodegen.cpp:
(JSC::TryNode::emitBytecode):
- parser/ASTBuilder.h:
(JSC::ASTBuilder::createTryStatement):
- parser/NodeConstructors.h:
(JSC::TryNode::TryNode):
- parser/Nodes.h:
- parser/Parser.cpp:
(JSC::Parser<LexerType>::createBindingPattern):
(JSC::Parser<LexerType>::tryParseDestructuringPatternExpression):
(JSC::Parser<LexerType>::parseBindingOrAssignmentElement):
(JSC::destructuringKindToVariableKindName):
(JSC::Parser<LexerType>::parseDestructuringPattern):
(JSC::Parser<LexerType>::parseTryStatement):
(JSC::Parser<LexerType>::parseFormalParameters):
(JSC::Parser<LexerType>::parseFunctionParameters):
- parser/Parser.h:
(JSC::Parser::destructuringKindFromDeclarationType):
- parser/SyntaxChecker.h:
(JSC::SyntaxChecker::createTryStatement):
- tests/es6.yaml:
- tests/es6/destructuring_in_catch_heads.js: Added.
(test):
- tests/stress/catch-parameter-destructuring.js: Added.
(shouldBe):
(shouldThrow):
(prototype.call):
(catch):
(shouldThrow.try.throw.get error):
(initialize):
(array):
(generator.gen):
(generator):
- tests/stress/catch-parameter-syntax.js: Added.
(testSyntax):
(testSyntaxError):
- tests/stress/reserved-word-with-escape.js:
(testSyntaxError.String.raw.a):
(String.raw.SyntaxError.Cannot.use.the.keyword.string_appeared_here.as.a.name):
- tests/stress/yield-named-variable.js:
LayoutTests:
- js/dom/reserved-words-as-property-expected.txt:
- js/let-syntax-expected.txt:
- js/mozilla/strict/12.14.1-expected.txt:
- js/mozilla/strict/script-tests/12.14.1.js:
- sputnik/Conformance/12_Statement/12.14_The_try_Statement/S12.14_A16_T10-expected.txt:
- sputnik/Conformance/12_Statement/12.14_The_try_Statement/S12.14_A16_T13-expected.txt:
- sputnik/Conformance/12_Statement/12.14_The_try_Statement/S12.14_A16_T5-expected.txt:
- sputnik/Conformance/12_Statement/12.14_The_try_Statement/S12.14_A16_T7-expected.txt:
- sputnik/Conformance/12_Statement/12.14_The_try_Statement/S12.14_A16_T8-expected.txt:
- 7:47 PM Changeset in webkit [195438] by
-
- 4 edits in trunk/Source/WebCore
createElementFromSavedToken shouldn't have the code to create a non-HTML element
https://bugs.webkit.org/show_bug.cgi?id=153327
Reviewed by Chris Dumez.
Since HTMLConstructionSite::createElementFromSavedToken is only used to instantiate a formatting element,
there is no need for it to support creating a non-HTML elements. Remove the branch and assert that this
is indeed the case.
createElementFromSavedToken is called in HTMLTreeBuilder::callTheAdoptionAgency and HTMLConstructionSite's
reconstructTheActiveFormattingElements. In both cases, the stack item passed to createElementFromSavedToken
is guaranteed to be in the list of active formatting elements, which only contains formatting elements.
No new tests since there is no behavioral change.
- html/parser/HTMLConstructionSite.cpp:
(WebCore::HTMLConstructionSite::insertHTMLHeadElement):
(WebCore::HTMLConstructionSite::insertHTMLHtmlStartTagBeforeHTML):
(WebCore::HTMLConstructionSite::insertFormattingElement):
(WebCore::HTMLConstructionSite::createElement): Returns Ref<Element> instead of PassRefPtr<Element>.
(WebCore::HTMLConstructionSite::createHTMLElement): Ditto.
(WebCore::HTMLConstructionSite::createElementFromSavedToken): Ditto. Removed the code to instantiate
a non-HTML element. Also assert that an element created by this function is a formatting tag.
- html/parser/HTMLConstructionSite.h:
- html/parser/HTMLTreeBuilder.cpp:
(WebCore::HTMLConstructionSite::isFormattingTag): Put into HTMLConstructionSite to add an assertion.
(WebCore::HTMLTreeBuilder::processEndTagForInBody):
- 7:40 PM Changeset in webkit [195437] by
-
- 5 edits in branches/safari-601.1.46-branch/Source
Versioning.
- 7:40 PM Changeset in webkit [195436] by
-
- 5 edits in branches/safari-601-branch/Source
Versioning.
- 7:36 PM Changeset in webkit [195435] by
-
- 2 edits in trunk/Source/JavaScriptCore
Unreviewed, fix build.
- b3/B3EliminateCommonSubexpressions.cpp:
- 7:31 PM Changeset in webkit [195434] by
-
- 8 edits in trunk/Source/JavaScriptCore
B3 CSE should be able to match a full redundancy even if none of the matches dominate the value in question
https://bugs.webkit.org/show_bug.cgi?id=153321
Reviewed by Benjamin Poulain.
I once learned that LLVM's GVN can manufacture Phi functions. I don't know the details
but I'm presuming that it involves:
if (p)
tmp1 = *ptr
else
tmp2 = *ptr
tmp3 = *ptr Replace this with Phi(tmp1, tmp2).
This adds such an optimization to our CSE. The idea is that we search through basic
blocks until we find the value we want, a side effect, or the start of the procedure. If
we find a value that matches our search criteria, we record it and ignore the
predecessors. If we find a side effect or the start of the procedure, we give up the
whole search. This ensures that if we come out of the search without giving up, we'll
have a set of matches that are fully redundant.
CSE could then create a Phi graph by using SSACalculator. But the recent work on FixSSA
revealed a much more exciting option: create a stack slot! In case there is more than one
match, CSE now creates a stack slot that each match stores to, and replaces the redundant
instruction with a loadfrom the stack slot. The stack slot is anonymous, which ensures
that FixSSA will turn it into an optimal Phi graph or whatever.
This is a significant speed-up on Octane/richards.
- b3/B3DuplicateTails.cpp:
- b3/B3EliminateCommonSubexpressions.cpp:
- b3/B3FixSSA.cpp:
(JSC::B3::fixSSA):
- b3/B3Generate.cpp:
(JSC::B3::generateToAir):
- b3/B3Procedure.h:
(JSC::B3::Procedure::setFrontendData):
(JSC::B3::Procedure::frontendData):
- b3/testb3.cpp:
- ftl/FTLState.cpp:
(JSC::FTL::State::State):
- 6:21 PM Changeset in webkit [195433] by
-
- 2 edits in trunk/Source/JavaScriptCore
Air should know that CeilDouble has the partial register stall issue
https://bugs.webkit.org/show_bug.cgi?id=153338
Rubber stamped by Benjamin Poulain.
This is a 8% speed-up on Kraken with B3 enabled, mostly because of a 2.4x speed-up on
audio-oscillator.
- b3/air/AirFixPartialRegisterStalls.cpp:
- 6:06 PM Changeset in webkit [195432] by
-
- 5 edits in trunk/Source/WebInspectorUI
Web Inspector: Add toggle-able list of classes for each element
https://bugs.webkit.org/show_bug.cgi?id=152678
Patch by Devin Rousso <Devin Rousso> on 2016-01-21
Reviewed by Timothy Hatcher.
Adds a button to the CSS sidebar that, when toggled, displays a section
directly above it containing all the classes for the selected node that,
when toggled, adds or removes the class from the node.
- Localizations/en.lproj/localizedStrings.js:
- UserInterface/Protocol/RemoteObject.js:
(WebInspector.RemoteObject.prototype.callFunction.mycallback):
(WebInspector.RemoteObject.prototype.callFunction):
Add extra handling of arguments to allow nicer looking calls by other classes.
- UserInterface/Views/CSSStyleDetailsSidebarPanel.css:
Changed next-sibling selector (+) to general-sibling selector (~).
(.sidebar > .panel.details.css-style > .content ~ :matches(.options-container, .class-list-container)):
(.sidebar > .panel.details.css-style > .content:not(.supports-new-rule, .has-filter-bar) ~ :matches(.options-container, .class-list-container)):
(.sidebar > .panel.details.css-style > .content ~ .options-container > .toggle-class-toggle):
(.sidebar > .panel.details.css-style > .content ~ .options-container > .toggle-class-toggle.selected):
(.sidebar > .panel.details.css-style > .content ~ .options-container > .toggle-class-toggle:not(.selected):hover):
(.sidebar > .panel.details.css-style > .content ~ .class-list-container):
(.sidebar > .panel.details.css-style > .content ~ .class-list-container[hidden]):
(.sidebar > .panel.details.css-style > .content ~ .class-list-container > .new-class):
(.sidebar > .panel.details.css-style > .content ~ .class-list-container > .new-class > input[type="checkbox"]):
(.sidebar > .panel.details.css-style > .content ~ .class-list-container > .new-class > .add-class-icon):
(.sidebar > .panel.details.css-style > .content ~ .class-list-container > .new-class > .class-name-input):
(.sidebar > .panel.details.css-style > .content ~ .class-list-container > .new-class:not(.active) > .class-name-input):
(.sidebar > .panel.details.css-style > .content ~ .class-list-container > *:matches(.new-class, .class-toggle)):
- UserInterface/Views/CSSStyleDetailsSidebarPanel.js:
(WebInspector.CSSStyleDetailsSidebarPanel):
Also changed the few instances of "var" to "let".
(WebInspector.CSSStyleDetailsSidebarPanel.prototype.refresh):
(WebInspector.CSSStyleDetailsSidebarPanel.prototype.addEventListeners):
(WebInspector.CSSStyleDetailsSidebarPanel.prototype._handleNodeAttributeModified):
(WebInspector.CSSStyleDetailsSidebarPanel.prototype._handleNodeAttributeRemoved):
Adds listeners to the DOMNode specifically listening for changes to the
class attribute and repopulates the class toggle list if fired.
(WebInspector.CSSStyleDetailsSidebarPanel.prototype._classToggleButtonClicked):
(WebInspector.CSSStyleDetailsSidebarPanel.prototype._addClassContainerClicked):
(WebInspector.CSSStyleDetailsSidebarPanel.prototype._addClassInputKeyPressed):
If the Enter key is pressed, add a new class equal to the input value.
(WebInspector.CSSStyleDetailsSidebarPanel.prototype._addClassInputBlur):
(WebInspector.CSSStyleDetailsSidebarPanel.prototype._populateClassToggles):
Loops through all the classes, including previously removed ones, for the
selected node and creates a toggle for each.
(WebInspector.CSSStyleDetailsSidebarPanel.prototype._createToggleForClassName.classNameToggleChanged):
(WebInspector.CSSStyleDetailsSidebarPanel.prototype._createToggleForClassName):
Creates a toggle element for the given className and adds it to the container.
(WebInspector.CSSStyleDetailsSidebarPanel.prototype._toggleClass.resolvedNode.toggleClass):
(WebInspector.CSSStyleDetailsSidebarPanel.prototype._toggleClass.resolvedNode):
(WebInspector.CSSStyleDetailsSidebarPanel.prototype._toggleClass):
Uses the Element.classList to toggle the given className on the selected node.
- 6:05 PM Changeset in webkit [195431] by
-
- 3 edits3 adds in trunk
[INTL] Implement Array.prototype.toLocaleString in ECMA-402
https://bugs.webkit.org/show_bug.cgi?id=147614
Patch by Andy VanWagoner <andy@instructure.com> on 2016-01-21
Reviewed by Benjamin Poulain.
Source/JavaScriptCore:
The primary changes in the ECMA-402 version, and the existing implementation
are passing the arguments on to each element's toLocaleString call, and
missing/undefined/null elements become empty string instead of being skipped.
- runtime/ArrayPrototype.cpp:
(JSC::arrayProtoFuncToLocaleString):
LayoutTests:
- js/array-toLocaleString-expected.txt: Added.
- js/array-toLocaleString.html: Added.
- js/script-tests/array-toLocaleString.js: Added.
- 6:00 PM Changeset in webkit [195430] by
-
- 5 edits in trunk/Source/WebCore
CGImageSource sometimes retains temporary SharedBuffer data indefinitely, doubling memory cost.
<https://webkit.org/b/153325>
Reviewed by Anders Carlsson.
After a resource has finished downloading, and has been cached to disk cache,
we mmap() the disk cached version so we can throw out the temporary download buffer.
Due to the way CGImageSource works on Mac/iOS, it's not possible to replace the data
being decoded once the image has been fully decoded once. When doing the replacement,
we'd end up with the SharedBuffer wrapping the mmap() data, and the CGImageSource
keeping the old SharedBuffer::DataBuffer alive, effectively doubling the memory cost.
This patch adds a CachedResource::didReplaceSharedBufferContents() callback that
CachedImage implements to throw out the decoded data. This is currently the only way
to make CGImageSource drop the retain it holds on the SharedBuffer::DataBuffer.
The downside of this approach is that we'll sometimes incur the cost of one additional
image decode after an image downloads and is cached for the first time.
I put a FIXME in there since we could do better with a little help from CGImageSource.
- loader/cache/CachedImage.cpp:
(WebCore::CachedImage::didReplaceSharedBufferContents):
- loader/cache/CachedImage.h:
- loader/cache/CachedResource.cpp:
(WebCore::CachedResource::tryReplaceEncodedData):
- loader/cache/CachedResource.h:
(WebCore::CachedResource::didReplaceSharedBufferContents):
- 4:47 PM Changeset in webkit [195429] by
-
- 2 edits in trunk/Source/WebKit2
Move _allowsDoubleTapGestures implementation out of category
https://bugs.webkit.org/show_bug.cgi?id=153329
<rdar://problem/24289768>
Reviewed by Simon Fraser.
We were generating a linker warning because the implementation
was located inside the WKPrivate category.
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _allowsDoubleTapGestures]): Move this out of
the category.
- 3:57 PM Changeset in webkit [195428] by
-
- 2 edits in trunk/LayoutTests
Rebaseline fast/block/float/overhanging-tall-block.html for ios-simulator-wk2
https://bugs.webkit.org/show_bug.cgi?id=152440
Reviewed by Zalan Bujtas.
- platform/ios-simulator-wk2/fast/block/float/overhanging-tall-block-expected.txt:
- 3:52 PM Changeset in webkit [195427] by
-
- 1 copy in tags/Safari-601.1.46.93
New tag.
- 3:52 PM Changeset in webkit [195426] by
-
- 1 copy in tags/Safari-601.5.11
New tag.
- 3:45 PM Changeset in webkit [195425] by
-
- 2 edits in trunk/Source/JavaScriptCore
[B3][Win64] Compile fixes.
https://bugs.webkit.org/show_bug.cgi?id=153312
Reviewed by Alex Christensen.
Since MSVC has several overloads of sin, cos, pow, and log, we need to specify
which one we want to use.
- ftl/FTLB3Output.h:
(JSC::FTL::Output::doubleSin):
(JSC::FTL::Output::doubleCos):
(JSC::FTL::Output::doublePow):
(JSC::FTL::Output::doubleLog):
- 3:34 PM Changeset in webkit [195424] by
-
- 4 edits in trunk/Source/WebKit2
[iOS] Crash in _endPotentialTapAndEnableDoubleTapGesturesIfNecessary
https://bugs.webkit.org/show_bug.cgi?id=153326
<rdar://problem/24264339>
Reviewed by Anders Carlsson.
UIKit's UIGestureRecognizer could call back into the WKContentView
after the associated WKWebView has disappeared. The fix is to
explicitly null the WKWebView reference as we deallocate.
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView dealloc]): Tell the WKContentView we are going away.
- UIProcess/ios/WKContentView.h:
- UIProcess/ios/WKContentView.mm:
(-[WKContentView _webViewDestroyed]):
- UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView _endPotentialTapAndEnableDoubleTapGesturesIfNecessary]):
Only do something if the WKWebView is still around.
- 3:15 PM Changeset in webkit [195423] by
-
- 5 edits1 copy487 adds in trunk/LayoutTests
Modern IDB: Make -private copies of each w3c IDB test.
https://bugs.webkit.org/show_bug.cgi?id=153319
Reviewed by Alex Christensen.
LayoutTests/imported/w3c:
- indexeddb/support.js: If the test filename ends with -private.htm(l), enable private browsing.
- indexeddb/abort-in-initial-upgradeneeded-private-expected.txt: Added.
- indexeddb/abort-in-initial-upgradeneeded-private.html: Added.
- indexeddb/close-in-upgradeneeded-private-expected.txt: Added.
- indexeddb/close-in-upgradeneeded-private.html: Added.
- indexeddb/cursor-overloads-private-expected.txt: Added.
- indexeddb/cursor-overloads-private.html: Added.
- indexeddb/idb_webworkers-private-expected.txt: Added.
- indexeddb/idb_webworkers-private.html: Added.
- indexeddb/idbcursor-advance-continue-async-private-expected.txt: Added.
- indexeddb/idbcursor-advance-continue-async-private.html: Added.
- indexeddb/idbcursor-advance-invalid-private-expected.txt: Added.
- indexeddb/idbcursor-advance-invalid-private.html: Added.
- indexeddb/idbcursor-advance-private-expected.txt: Added.
- indexeddb/idbcursor-advance-private.html: Added.
- indexeddb/idbcursor-continue-private-expected.txt: Added.
- indexeddb/idbcursor-continue-private.html: Added.
- indexeddb/idbcursor-direction-index-keyrange-private-expected.txt: Added.
- indexeddb/idbcursor-direction-index-keyrange-private.html: Added.
- indexeddb/idbcursor-direction-index-private-expected.txt: Added.
- indexeddb/idbcursor-direction-index-private.html: Added.
- indexeddb/idbcursor-direction-objectstore-keyrange-private-expected.txt: Added.
- indexeddb/idbcursor-direction-objectstore-keyrange-private.html: Added.
- indexeddb/idbcursor-direction-objectstore-private-expected.txt: Added.
- indexeddb/idbcursor-direction-objectstore-private.html: Added.
- indexeddb/idbcursor-direction-private-expected.txt: Added.
- indexeddb/idbcursor-direction-private.html: Added.
- indexeddb/idbcursor-key-private-expected.txt: Added.
- indexeddb/idbcursor-key-private.html: Added.
- indexeddb/idbcursor-primarykey-private-expected.txt: Added.
- indexeddb/idbcursor-primarykey-private.html: Added.
- indexeddb/idbcursor-reused-private-expected.txt: Added.
- indexeddb/idbcursor-reused-private.html: Added.
- indexeddb/idbcursor-source-private-expected.txt: Added.
- indexeddb/idbcursor-source-private.html: Added.
- indexeddb/idbcursor_advance_index-private-expected.txt: Added.
- indexeddb/idbcursor_advance_index-private.html: Added.
- indexeddb/idbcursor_advance_index2-private-expected.txt: Added.
- indexeddb/idbcursor_advance_index2-private.html: Added.
- indexeddb/idbcursor_advance_index3-private-expected.txt: Added.
- indexeddb/idbcursor_advance_index3-private.html: Added.
- indexeddb/idbcursor_advance_index5-private-expected.txt: Added.
- indexeddb/idbcursor_advance_index5-private.html: Added.
- indexeddb/idbcursor_advance_index6-private-expected.txt: Added.
- indexeddb/idbcursor_advance_index6-private.html: Added.
- indexeddb/idbcursor_advance_index7-private-expected.txt: Added.
- indexeddb/idbcursor_advance_index7-private.html: Added.
- indexeddb/idbcursor_advance_index8-private-expected.txt: Added.
- indexeddb/idbcursor_advance_index8-private.html: Added.
- indexeddb/idbcursor_advance_index9-private-expected.txt: Added.
- indexeddb/idbcursor_advance_index9-private.html: Added.
- indexeddb/idbcursor_advance_objectstore-private-expected.txt: Added.
- indexeddb/idbcursor_advance_objectstore-private.html: Added.
- indexeddb/idbcursor_advance_objectstore2-private-expected.txt: Added.
- indexeddb/idbcursor_advance_objectstore2-private.html: Added.
- indexeddb/idbcursor_advance_objectstore3-private-expected.txt: Added.
- indexeddb/idbcursor_advance_objectstore3-private.html: Added.
- indexeddb/idbcursor_advance_objectstore4-private-expected.txt: Added.
- indexeddb/idbcursor_advance_objectstore4-private.html: Added.
- indexeddb/idbcursor_advance_objectstore5-private-expected.txt: Added.
- indexeddb/idbcursor_advance_objectstore5-private.html: Added.
- indexeddb/idbcursor_continue_index-private-expected.txt: Added.
- indexeddb/idbcursor_continue_index-private.html: Added.
- indexeddb/idbcursor_continue_index2-private-expected.txt: Added.
- indexeddb/idbcursor_continue_index2-private.html: Added.
- indexeddb/idbcursor_continue_index3-private-expected.txt: Added.
- indexeddb/idbcursor_continue_index3-private.html: Added.
- indexeddb/idbcursor_continue_index4-private-expected.txt: Added.
- indexeddb/idbcursor_continue_index4-private.html: Added.
- indexeddb/idbcursor_continue_index5-private-expected.txt: Added.
- indexeddb/idbcursor_continue_index5-private.html: Added.
- indexeddb/idbcursor_continue_index6-private-expected.txt: Added.
- indexeddb/idbcursor_continue_index6-private.html: Added.
- indexeddb/idbcursor_continue_index7-private-expected.txt: Added.
- indexeddb/idbcursor_continue_index7-private.html: Added.
- indexeddb/idbcursor_continue_index8-private-expected.txt: Added.
- indexeddb/idbcursor_continue_index8-private.html: Added.
- indexeddb/idbcursor_continue_invalid-private-expected.txt: Added.
- indexeddb/idbcursor_continue_invalid-private.html: Added.
- indexeddb/idbcursor_continue_objectstore-private-expected.txt: Added.
- indexeddb/idbcursor_continue_objectstore-private.html: Added.
- indexeddb/idbcursor_continue_objectstore2-private-expected.txt: Added.
- indexeddb/idbcursor_continue_objectstore2-private.html: Added.
- indexeddb/idbcursor_continue_objectstore3-private-expected.txt: Added.
- indexeddb/idbcursor_continue_objectstore3-private.html: Added.
- indexeddb/idbcursor_continue_objectstore4-private-expected.txt: Added.
- indexeddb/idbcursor_continue_objectstore4-private.html: Added.
- indexeddb/idbcursor_continue_objectstore5-private-expected.txt: Added.
- indexeddb/idbcursor_continue_objectstore5-private.html: Added.
- indexeddb/idbcursor_continue_objectstore6-private-expected.txt: Added.
- indexeddb/idbcursor_continue_objectstore6-private.html: Added.
- indexeddb/idbcursor_delete_index-private-expected.txt: Added.
- indexeddb/idbcursor_delete_index-private.html: Added.
- indexeddb/idbcursor_delete_index2-private-expected.txt: Added.
- indexeddb/idbcursor_delete_index2-private.html: Added.
- indexeddb/idbcursor_delete_index3-private-expected.txt: Added.
- indexeddb/idbcursor_delete_index3-private.html: Added.
- indexeddb/idbcursor_delete_index4-private-expected.txt: Added.
- indexeddb/idbcursor_delete_index4-private.html: Added.
- indexeddb/idbcursor_delete_index5-private-expected.txt: Added.
- indexeddb/idbcursor_delete_index5-private.html: Added.
- indexeddb/idbcursor_delete_objectstore-private-expected.txt: Added.
- indexeddb/idbcursor_delete_objectstore-private.html: Added.
- indexeddb/idbcursor_delete_objectstore2-private-expected.txt: Added.
- indexeddb/idbcursor_delete_objectstore2-private.html: Added.
- indexeddb/idbcursor_delete_objectstore3-private-expected.txt: Added.
- indexeddb/idbcursor_delete_objectstore3-private.html: Added.
- indexeddb/idbcursor_delete_objectstore4-private-expected.txt: Added.
- indexeddb/idbcursor_delete_objectstore4-private.html: Added.
- indexeddb/idbcursor_delete_objectstore5-private-expected.txt: Added.
- indexeddb/idbcursor_delete_objectstore5-private.html: Added.
- indexeddb/idbcursor_iterating-private-expected.txt: Added.
- indexeddb/idbcursor_iterating-private.html: Added.
- indexeddb/idbcursor_iterating_index-private-expected.txt: Added.
- indexeddb/idbcursor_iterating_index-private.html: Added.
- indexeddb/idbcursor_iterating_index2-private-expected.txt: Added.
- indexeddb/idbcursor_iterating_index2-private.html: Added.
- indexeddb/idbcursor_iterating_objectstore-private-expected.txt: Added.
- indexeddb/idbcursor_iterating_objectstore-private.html: Added.
- indexeddb/idbcursor_iterating_objectstore2-private-expected.txt: Added.
- indexeddb/idbcursor_iterating_objectstore2-private.html: Added.
- indexeddb/idbcursor_update_index-private-expected.txt: Added.
- indexeddb/idbcursor_update_index-private.html: Added.
- indexeddb/idbcursor_update_index2-private-expected.txt: Added.
- indexeddb/idbcursor_update_index2-private.html: Added.
- indexeddb/idbcursor_update_index3-private-expected.txt: Added.
- indexeddb/idbcursor_update_index3-private.html: Added.
- indexeddb/idbcursor_update_index4-private-expected.txt: Added.
- indexeddb/idbcursor_update_index4-private.html: Added.
- indexeddb/idbcursor_update_index5-private-expected.txt: Added.
- indexeddb/idbcursor_update_index5-private.html: Added.
- indexeddb/idbcursor_update_index6-private-expected.txt: Added.
- indexeddb/idbcursor_update_index6-private.html: Added.
- indexeddb/idbcursor_update_index7-private-expected.txt: Added.
- indexeddb/idbcursor_update_index7-private.html: Added.
- indexeddb/idbcursor_update_objectstore-private-expected.txt: Added.
- indexeddb/idbcursor_update_objectstore-private.html: Added.
- indexeddb/idbcursor_update_objectstore2-private-expected.txt: Added.
- indexeddb/idbcursor_update_objectstore2-private.html: Added.
- indexeddb/idbcursor_update_objectstore3-private-expected.txt: Added.
- indexeddb/idbcursor_update_objectstore3-private.html: Added.
- indexeddb/idbcursor_update_objectstore4-private-expected.txt: Added.
- indexeddb/idbcursor_update_objectstore4-private.html: Added.
- indexeddb/idbcursor_update_objectstore5-private-expected.txt: Added.
- indexeddb/idbcursor_update_objectstore5-private.html: Added.
- indexeddb/idbcursor_update_objectstore6-private-expected.txt: Added.
- indexeddb/idbcursor_update_objectstore6-private.html: Added.
- indexeddb/idbcursor_update_objectstore7-private-expected.txt: Added.
- indexeddb/idbcursor_update_objectstore7-private.html: Added.
- indexeddb/idbcursor_update_objectstore8-private-expected.txt: Added.
- indexeddb/idbcursor_update_objectstore8-private.html: Added.
- indexeddb/idbdatabase_close-private-expected.txt: Added.
- indexeddb/idbdatabase_close-private.html: Added.
- indexeddb/idbdatabase_close2-private-expected.txt: Added.
- indexeddb/idbdatabase_close2-private.html: Added.
- indexeddb/idbdatabase_createObjectStore-createIndex-emptyname-private-expected.txt: Added.
- indexeddb/idbdatabase_createObjectStore-createIndex-emptyname-private.html: Added.
- indexeddb/idbdatabase_createObjectStore-private-expected.txt: Added.
- indexeddb/idbdatabase_createObjectStore-private.html: Added.
- indexeddb/idbdatabase_createObjectStore10-1000ends-private-expected.txt: Added.
- indexeddb/idbdatabase_createObjectStore10-1000ends-private.html: Added.
- indexeddb/idbdatabase_createObjectStore10-emptyname-private-expected.txt: Added.
- indexeddb/idbdatabase_createObjectStore10-emptyname-private.html: Added.
- indexeddb/idbdatabase_createObjectStore11-private-expected.txt: Added.
- indexeddb/idbdatabase_createObjectStore11-private.html: Added.
- indexeddb/idbdatabase_createObjectStore2-private-expected.txt: Added.
- indexeddb/idbdatabase_createObjectStore2-private.html: Added.
- indexeddb/idbdatabase_createObjectStore3-private-expected.txt: Added.
- indexeddb/idbdatabase_createObjectStore3-private.html: Added.
- indexeddb/idbdatabase_createObjectStore4-private-expected.txt: Added.
- indexeddb/idbdatabase_createObjectStore4-private.html: Added.
- indexeddb/idbdatabase_createObjectStore5-private-expected.txt: Added.
- indexeddb/idbdatabase_createObjectStore5-private.html: Added.
- indexeddb/idbdatabase_createObjectStore6-private-expected.txt: Added.
- indexeddb/idbdatabase_createObjectStore6-private.html: Added.
- indexeddb/idbdatabase_createObjectStore7-private-expected.txt: Added.
- indexeddb/idbdatabase_createObjectStore7-private.html: Added.
- indexeddb/idbdatabase_createObjectStore8-parameters-private-expected.txt: Added.
- indexeddb/idbdatabase_createObjectStore8-parameters-private.html: Added.
- indexeddb/idbdatabase_createObjectStore9-invalidparameters-private-expected.txt: Added.
- indexeddb/idbdatabase_createObjectStore9-invalidparameters-private.html: Added.
- indexeddb/idbdatabase_deleteObjectStore-private-expected.txt: Added.
- indexeddb/idbdatabase_deleteObjectStore-private.html: Added.
- indexeddb/idbdatabase_deleteObjectStore2-private-expected.txt: Added.
- indexeddb/idbdatabase_deleteObjectStore2-private.html: Added.
- indexeddb/idbdatabase_deleteObjectStore3-private-expected.txt: Added.
- indexeddb/idbdatabase_deleteObjectStore3-private.html: Added.
- indexeddb/idbdatabase_deleteObjectStore4-not_reused-private-expected.txt: Added.
- indexeddb/idbdatabase_deleteObjectStore4-not_reused-private.html: Added.
- indexeddb/idbdatabase_transaction-private-expected.txt: Added.
- indexeddb/idbdatabase_transaction-private.html: Added.
- indexeddb/idbdatabase_transaction2-private-expected.txt: Added.
- indexeddb/idbdatabase_transaction2-private.html: Added.
- indexeddb/idbdatabase_transaction3-private-expected.txt: Added.
- indexeddb/idbdatabase_transaction3-private.html: Added.
- indexeddb/idbdatabase_transaction4-private-expected.txt: Added.
- indexeddb/idbdatabase_transaction4-private.html: Added.
- indexeddb/idbdatabase_transaction5-private-expected.txt: Added.
- indexeddb/idbdatabase_transaction5-private.html: Added.
- indexeddb/idbfactory_cmp-private-expected.txt: Added.
- indexeddb/idbfactory_cmp-private.html: Added.
- indexeddb/idbfactory_cmp2-private-expected.txt: Added.
- indexeddb/idbfactory_cmp2-private.html: Added.
- indexeddb/idbfactory_deleteDatabase-private-expected.txt: Added.
- indexeddb/idbfactory_deleteDatabase-private.html: Added.
- indexeddb/idbfactory_deleteDatabase2-private-expected.txt: Added.
- indexeddb/idbfactory_deleteDatabase2-private.html: Added.
- indexeddb/idbfactory_deleteDatabase3-private-expected.txt: Added.
- indexeddb/idbfactory_deleteDatabase3-private.html: Added.
- indexeddb/idbfactory_deleteDatabase4-private-expected.txt: Added.
- indexeddb/idbfactory_deleteDatabase4-private.html: Added.
- indexeddb/idbfactory_open-private-expected.txt: Added.
- indexeddb/idbfactory_open-private.html: Added.
- indexeddb/idbfactory_open10-private-expected.txt: Added.
- indexeddb/idbfactory_open10-private.html: Added.
- indexeddb/idbfactory_open11-private-expected.txt: Added.
- indexeddb/idbfactory_open11-private.html: Added.
- indexeddb/idbfactory_open12-private-expected.txt: Added.
- indexeddb/idbfactory_open12-private.html: Added.
- indexeddb/idbfactory_open2-private-expected.txt: Added.
- indexeddb/idbfactory_open2-private.html: Added.
- indexeddb/idbfactory_open3-private-expected.txt: Added.
- indexeddb/idbfactory_open3-private.html: Added.
- indexeddb/idbfactory_open4-private-expected.txt: Added.
- indexeddb/idbfactory_open4-private.html: Added.
- indexeddb/idbfactory_open5-private-expected.txt: Added.
- indexeddb/idbfactory_open5-private.html: Added.
- indexeddb/idbfactory_open6-private-expected.txt: Added.
- indexeddb/idbfactory_open6-private.html: Added.
- indexeddb/idbfactory_open7-private-expected.txt: Added.
- indexeddb/idbfactory_open7-private.html: Added.
- indexeddb/idbfactory_open8-private-expected.txt: Added.
- indexeddb/idbfactory_open8-private.html: Added.
- indexeddb/idbfactory_open9-private-expected.txt: Added.
- indexeddb/idbfactory_open9-private.html: Copied from LayoutTests/imported/w3c/indexeddb/idbfactory_open9.htm.
- indexeddb/idbfactory_open9.htm:
- indexeddb/idbindex-multientry-arraykeypath-private-expected.txt: Added.
- indexeddb/idbindex-multientry-arraykeypath-private.html: Added.
- indexeddb/idbindex-multientry-big-private-expected.txt: Added.
- indexeddb/idbindex-multientry-big-private.html: Added.
- indexeddb/idbindex-multientry-private-expected.txt: Added.
- indexeddb/idbindex-multientry-private.html: Added.
- indexeddb/idbindex_count-private-expected.txt: Added.
- indexeddb/idbindex_count-private.html: Added.
- indexeddb/idbindex_count2-private-expected.txt: Added.
- indexeddb/idbindex_count2-private.html: Added.
- indexeddb/idbindex_count3-private-expected.txt: Added.
- indexeddb/idbindex_count3-private.html: Added.
- indexeddb/idbindex_count4-private-expected.txt: Added.
- indexeddb/idbindex_count4-private.html: Added.
- indexeddb/idbindex_get-private-expected.txt: Added.
- indexeddb/idbindex_get-private.html: Added.
- indexeddb/idbindex_get2-private-expected.txt: Added.
- indexeddb/idbindex_get2-private.html: Added.
- indexeddb/idbindex_get3-private-expected.txt: Added.
- indexeddb/idbindex_get3-private.html: Added.
- indexeddb/idbindex_get4-private-expected.txt: Added.
- indexeddb/idbindex_get4-private.html: Added.
- indexeddb/idbindex_get5-private-expected.txt: Added.
- indexeddb/idbindex_get5-private.html: Added.
- indexeddb/idbindex_get6-private-expected.txt: Added.
- indexeddb/idbindex_get6-private.html: Added.
- indexeddb/idbindex_get7-private-expected.txt: Added.
- indexeddb/idbindex_get7-private.html: Added.
- indexeddb/idbindex_getKey-private-expected.txt: Added.
- indexeddb/idbindex_getKey-private.html: Added.
- indexeddb/idbindex_getKey2-private-expected.txt: Added.
- indexeddb/idbindex_getKey2-private.html: Added.
- indexeddb/idbindex_getKey3-private-expected.txt: Added.
- indexeddb/idbindex_getKey3-private.html: Added.
- indexeddb/idbindex_getKey4-private-expected.txt: Added.
- indexeddb/idbindex_getKey4-private.html: Added.
- indexeddb/idbindex_getKey5-private-expected.txt: Added.
- indexeddb/idbindex_getKey5-private.html: Added.
- indexeddb/idbindex_getKey6-private-expected.txt: Added.
- indexeddb/idbindex_getKey6-private.html: Added.
- indexeddb/idbindex_getKey7-private-expected.txt: Added.
- indexeddb/idbindex_getKey7-private.html: Added.
- indexeddb/idbindex_indexNames-private-expected.txt: Added.
- indexeddb/idbindex_indexNames-private.html: Added.
- indexeddb/idbindex_openCursor-private-expected.txt: Added.
- indexeddb/idbindex_openCursor-private.html: Added.
- indexeddb/idbindex_openCursor2-private-expected.txt: Added.
- indexeddb/idbindex_openCursor2-private.html: Added.
- indexeddb/idbindex_openKeyCursor-private-expected.txt: Added.
- indexeddb/idbindex_openKeyCursor-private.html: Added.
- indexeddb/idbindex_openKeyCursor2-private-expected.txt: Added.
- indexeddb/idbindex_openKeyCursor2-private.html: Added.
- indexeddb/idbindex_openKeyCursor3-private-expected.txt: Added.
- indexeddb/idbindex_openKeyCursor3-private.html: Added.
- indexeddb/idbkeyrange-private-expected.txt: Added.
- indexeddb/idbkeyrange-private.html: Added.
- indexeddb/idbkeyrange_incorrect-private-expected.txt: Added.
- indexeddb/idbkeyrange_incorrect-private.html: Added.
- indexeddb/idbobjectstore_add-private-expected.txt: Added.
- indexeddb/idbobjectstore_add-private.html: Added.
- indexeddb/idbobjectstore_add10-private-expected.txt: Added.
- indexeddb/idbobjectstore_add10-private.html: Added.
- indexeddb/idbobjectstore_add11-private-expected.txt: Added.
- indexeddb/idbobjectstore_add11-private.html: Added.
- indexeddb/idbobjectstore_add12-private-expected.txt: Added.
- indexeddb/idbobjectstore_add12-private.html: Added.
- indexeddb/idbobjectstore_add13-private-expected.txt: Added.
- indexeddb/idbobjectstore_add13-private.html: Added.
- indexeddb/idbobjectstore_add14-private-expected.txt: Added.
- indexeddb/idbobjectstore_add14-private.html: Added.
- indexeddb/idbobjectstore_add15-private-expected.txt: Added.
- indexeddb/idbobjectstore_add15-private.html: Added.
- indexeddb/idbobjectstore_add16-private-expected.txt: Added.
- indexeddb/idbobjectstore_add16-private.html: Added.
- indexeddb/idbobjectstore_add2-private-expected.txt: Added.
- indexeddb/idbobjectstore_add2-private.html: Added.
- indexeddb/idbobjectstore_add3-private-expected.txt: Added.
- indexeddb/idbobjectstore_add3-private.html: Added.
- indexeddb/idbobjectstore_add4-private-expected.txt: Added.
- indexeddb/idbobjectstore_add4-private.html: Added.
- indexeddb/idbobjectstore_add5-private-expected.txt: Added.
- indexeddb/idbobjectstore_add5-private.html: Added.
- indexeddb/idbobjectstore_add6-private-expected.txt: Added.
- indexeddb/idbobjectstore_add6-private.html: Added.
- indexeddb/idbobjectstore_add7-private-expected.txt: Added.
- indexeddb/idbobjectstore_add7-private.html: Added.
- indexeddb/idbobjectstore_add8-private-expected.txt: Added.
- indexeddb/idbobjectstore_add8-private.html: Added.
- indexeddb/idbobjectstore_add9-private-expected.txt: Added.
- indexeddb/idbobjectstore_add9-private.html: Added.
- indexeddb/idbobjectstore_clear-private-expected.txt: Added.
- indexeddb/idbobjectstore_clear-private.html: Added.
- indexeddb/idbobjectstore_clear2-private-expected.txt: Added.
- indexeddb/idbobjectstore_clear2-private.html: Added.
- indexeddb/idbobjectstore_clear3-private-expected.txt: Added.
- indexeddb/idbobjectstore_clear3-private.html: Added.
- indexeddb/idbobjectstore_clear4-private-expected.txt: Added.
- indexeddb/idbobjectstore_clear4-private.html: Added.
- indexeddb/idbobjectstore_count-private-expected.txt: Added.
- indexeddb/idbobjectstore_count-private.html: Added.
- indexeddb/idbobjectstore_count2-private-expected.txt: Added.
- indexeddb/idbobjectstore_count2-private.html: Added.
- indexeddb/idbobjectstore_count3-private-expected.txt: Added.
- indexeddb/idbobjectstore_count3-private.html: Added.
- indexeddb/idbobjectstore_count4-private-expected.txt: Added.
- indexeddb/idbobjectstore_count4-private.html: Added.
- indexeddb/idbobjectstore_createIndex-private-expected.txt: Added.
- indexeddb/idbobjectstore_createIndex-private.html: Added.
- indexeddb/idbobjectstore_createIndex10-private-expected.txt: Added.
- indexeddb/idbobjectstore_createIndex10-private.html: Added.
- indexeddb/idbobjectstore_createIndex11-private-expected.txt: Added.
- indexeddb/idbobjectstore_createIndex11-private.html: Added.
- indexeddb/idbobjectstore_createIndex12-private-expected.txt: Added.
- indexeddb/idbobjectstore_createIndex12-private.html: Added.
- indexeddb/idbobjectstore_createIndex13-private-expected.txt: Added.
- indexeddb/idbobjectstore_createIndex13-private.html: Added.
- indexeddb/idbobjectstore_createIndex2-private-expected.txt: Added.
- indexeddb/idbobjectstore_createIndex2-private.html: Added.
- indexeddb/idbobjectstore_createIndex3-usable-right-away-private-expected.txt: Added.
- indexeddb/idbobjectstore_createIndex3-usable-right-away-private.html: Added.
- indexeddb/idbobjectstore_createIndex4-deleteIndex-event_order-private-expected.txt: Added.
- indexeddb/idbobjectstore_createIndex4-deleteIndex-event_order-private.html: Added.
- indexeddb/idbobjectstore_createIndex5-emptykeypath-private-expected.txt: Added.
- indexeddb/idbobjectstore_createIndex5-emptykeypath-private.html: Added.
- indexeddb/idbobjectstore_createIndex6-event_order-private-expected.txt: Added.
- indexeddb/idbobjectstore_createIndex6-event_order-private.html: Added.
- indexeddb/idbobjectstore_createIndex7-event_order-private-expected.txt: Added.
- indexeddb/idbobjectstore_createIndex7-event_order-private.html: Added.
- indexeddb/idbobjectstore_createIndex8-valid_keys-private-expected.txt: Added.
- indexeddb/idbobjectstore_createIndex8-valid_keys-private.html: Added.
- indexeddb/idbobjectstore_createIndex9-emptyname-private-expected.txt: Added.
- indexeddb/idbobjectstore_createIndex9-emptyname-private.html: Added.
- indexeddb/idbobjectstore_delete-private-expected.txt: Added.
- indexeddb/idbobjectstore_delete-private.html: Added.
- indexeddb/idbobjectstore_delete2-private-expected.txt: Added.
- indexeddb/idbobjectstore_delete2-private.html: Added.
- indexeddb/idbobjectstore_delete3-private-expected.txt: Added.
- indexeddb/idbobjectstore_delete3-private.html: Added.
- indexeddb/idbobjectstore_delete4-private-expected.txt: Added.
- indexeddb/idbobjectstore_delete4-private.html: Added.
- indexeddb/idbobjectstore_delete5-private-expected.txt: Added.
- indexeddb/idbobjectstore_delete5-private.html: Added.
- indexeddb/idbobjectstore_delete6-private-expected.txt: Added.
- indexeddb/idbobjectstore_delete6-private.html: Added.
- indexeddb/idbobjectstore_delete7-private-expected.txt: Added.
- indexeddb/idbobjectstore_delete7-private.html: Added.
- indexeddb/idbobjectstore_deleteIndex-private-expected.txt: Added.
- indexeddb/idbobjectstore_deleteIndex-private.html: Added.
- indexeddb/idbobjectstore_deleted-private-expected.txt: Added.
- indexeddb/idbobjectstore_deleted-private.html: Added.
- indexeddb/idbobjectstore_get-private-expected.txt: Added.
- indexeddb/idbobjectstore_get-private.html: Added.
- indexeddb/idbobjectstore_get2-private-expected.txt: Added.
- indexeddb/idbobjectstore_get2-private.html: Added.
- indexeddb/idbobjectstore_get3-private-expected.txt: Added.
- indexeddb/idbobjectstore_get3-private.html: Added.
- indexeddb/idbobjectstore_get4-private-expected.txt: Added.
- indexeddb/idbobjectstore_get4-private.html: Added.
- indexeddb/idbobjectstore_get5-private-expected.txt: Added.
- indexeddb/idbobjectstore_get5-private.html: Added.
- indexeddb/idbobjectstore_get6-private-expected.txt: Added.
- indexeddb/idbobjectstore_get6-private.html: Added.
- indexeddb/idbobjectstore_get7-private-expected.txt: Added.
- indexeddb/idbobjectstore_get7-private.html: Added.
- indexeddb/idbobjectstore_index-private-expected.txt: Added.
- indexeddb/idbobjectstore_index-private.html: Added.
- indexeddb/idbobjectstore_openCursor-private-expected.txt: Added.
- indexeddb/idbobjectstore_openCursor-private.html: Added.
- indexeddb/idbobjectstore_openCursor_invalid-private-expected.txt: Added.
- indexeddb/idbobjectstore_openCursor_invalid-private.html: Added.
- indexeddb/idbobjectstore_put-private-expected.txt: Added.
- indexeddb/idbobjectstore_put-private.html: Added.
- indexeddb/idbobjectstore_put10-private-expected.txt: Added.
- indexeddb/idbobjectstore_put10-private.html: Added.
- indexeddb/idbobjectstore_put11-private-expected.txt: Added.
- indexeddb/idbobjectstore_put11-private.html: Added.
- indexeddb/idbobjectstore_put12-private-expected.txt: Added.
- indexeddb/idbobjectstore_put12-private.html: Added.
- indexeddb/idbobjectstore_put13-private-expected.txt: Added.
- indexeddb/idbobjectstore_put13-private.html: Added.
- indexeddb/idbobjectstore_put14-private-expected.txt: Added.
- indexeddb/idbobjectstore_put14-private.html: Added.
- indexeddb/idbobjectstore_put15-private-expected.txt: Added.
- indexeddb/idbobjectstore_put15-private.html: Added.
- indexeddb/idbobjectstore_put16-private-expected.txt: Added.
- indexeddb/idbobjectstore_put16-private.html: Added.
- indexeddb/idbobjectstore_put2-private-expected.txt: Added.
- indexeddb/idbobjectstore_put2-private.html: Added.
- indexeddb/idbobjectstore_put3-private-expected.txt: Added.
- indexeddb/idbobjectstore_put3-private.html: Added.
- indexeddb/idbobjectstore_put4-private-expected.txt: Added.
- indexeddb/idbobjectstore_put4-private.html: Added.
- indexeddb/idbobjectstore_put5-private-expected.txt: Added.
- indexeddb/idbobjectstore_put5-private.html: Added.
- indexeddb/idbobjectstore_put6-private-expected.txt: Added.
- indexeddb/idbobjectstore_put6-private.html: Added.
- indexeddb/idbobjectstore_put7-private-expected.txt: Added.
- indexeddb/idbobjectstore_put7-private.html: Added.
- indexeddb/idbobjectstore_put8-private-expected.txt: Added.
- indexeddb/idbobjectstore_put8-private.html: Added.
- indexeddb/idbobjectstore_put9-private-expected.txt: Added.
- indexeddb/idbobjectstore_put9-private.html: Added.
- indexeddb/idbtransaction-oncomplete-private-expected.txt: Added.
- indexeddb/idbtransaction-oncomplete-private.html: Added.
- indexeddb/idbtransaction-private-expected.txt: Added.
- indexeddb/idbtransaction-private.html: Added.
- indexeddb/idbtransaction_abort-private-expected.txt: Added.
- indexeddb/idbtransaction_abort-private.html: Added.
- indexeddb/idbversionchangeevent-private-expected.txt: Added.
- indexeddb/idbversionchangeevent-private.html: Added.
- indexeddb/index_sort_order-private-expected.txt: Added.
- indexeddb/index_sort_order-private.html: Added.
- indexeddb/key_invalid-private-expected.txt: Added.
- indexeddb/key_invalid-private.html: Added.
- indexeddb/key_valid-private-expected.txt: Added.
- indexeddb/key_valid-private.html: Added.
- indexeddb/keygenerator-constrainterror-private-expected.txt: Added.
- indexeddb/keygenerator-constrainterror-private.html: Added.
- indexeddb/keygenerator-overflow-private-expected.txt: Added.
- indexeddb/keygenerator-overflow-private.html: Added.
- indexeddb/keygenerator-private-expected.txt: Added.
- indexeddb/keygenerator-private.html: Added.
- indexeddb/keyorder-private-expected.txt: Added.
- indexeddb/keyorder-private.html: Added.
- indexeddb/keypath-private-expected.txt: Added.
- indexeddb/keypath-private.html: Added.
- indexeddb/keypath_invalid-private-expected.txt: Added.
- indexeddb/keypath_invalid-private.html: Added.
- indexeddb/keypath_maxsize-private-expected.txt: Added.
- indexeddb/keypath_maxsize-private.html: Added.
- indexeddb/list_ordering-private-expected.txt: Added.
- indexeddb/list_ordering-private.html: Added.
- indexeddb/objectstore_keyorder-private-expected.txt: Added.
- indexeddb/objectstore_keyorder-private.html: Added.
- indexeddb/request_bubble-and-capture-private-expected.txt: Added.
- indexeddb/request_bubble-and-capture-private.html: Added.
- indexeddb/string-list-ordering-private-expected.txt: Added.
- indexeddb/string-list-ordering-private.html: Added.
- indexeddb/transaction-create_in_versionchange-private-expected.txt: Added.
- indexeddb/transaction-create_in_versionchange-private.html: Added.
- indexeddb/transaction-lifetime-blocked-private-expected.txt: Added.
- indexeddb/transaction-lifetime-blocked-private.html: Added.
- indexeddb/transaction-lifetime-private-expected.txt: Added.
- indexeddb/transaction-lifetime-private.html: Added.
- indexeddb/transaction-requestqueue-private-expected.txt: Added.
- indexeddb/transaction-requestqueue-private.html: Added.
- indexeddb/transaction_bubble-and-capture-private-expected.txt: Added.
- indexeddb/transaction_bubble-and-capture-private.html: Added.
- indexeddb/value-private-expected.txt: Added.
- indexeddb/value-private.html: Added.
- indexeddb/value_recursive-private-expected.txt: Added.
- indexeddb/value_recursive-private.html: Added.
- indexeddb/writer-starvation-private-expected.txt: Added.
- indexeddb/writer-starvation-private.html: Added.
LayoutTests:
- platform/wk2/TestExpectations:
- 2:56 PM Changeset in webkit [195422] by
-
- 4 edits in trunk/Source/JavaScriptCore
[JSC] foldPathConstants() makes invalid assumptions with Switch
https://bugs.webkit.org/show_bug.cgi?id=153324
Reviewed by Filip Pizlo.
If a Switch() has two cases pointing to the same basic block, foldPathConstants()
was adding two override for that block with two different constants.
If the block with the Switch dominates the target, both override were equally valid
and we were assuming any of the constants as the value in the target block.
See testSwitchTargettingSameBlockFoldPathConstant() for an example that breaks.
This patch adds checks to ignore any block that is reached more than
once by the control value.
- b3/B3FoldPathConstants.cpp:
- b3/B3Generate.cpp:
(JSC::B3::generateToAir):
- b3/testb3.cpp:
(JSC::B3::testSwitchTargettingSameBlock):
(JSC::B3::testSwitchTargettingSameBlockFoldPathConstant):
(JSC::B3::run):
- 1:51 PM Changeset in webkit [195421] by
-
- 7 edits in trunk/Source
Add the ability to update WebKitAdditions to WK2
https://bugs.webkit.org/show_bug.cgi?id=153320
-and corresponding-
rdar://problem/23639629
Reviewed by Anders Carlsson.
Source/WebCore:
This SPI is un-used now.
- platform/spi/mac/NSSpellCheckerSPI.h:
Source/WebKit2:
- UIProcess/API/Cocoa/WKWebView.mm:
- UIProcess/API/mac/WKView.mm:
- UIProcess/Cocoa/WebViewImpl.h:
(WebKit::WebViewImpl::createWeakPtr):
- UIProcess/Cocoa/WebViewImpl.mm:
(WebKit::WebViewImpl::updateWebViewImplAdditions):
(WebKit::WebViewImpl::showCandidates):
(WebKit::WebViewImpl::webViewImplAdditionsWillDestroyView):
(WebKit::trackingAreaOptions):
(WebKit::WebViewImpl::~WebViewImpl):
(WebKit::WebViewImpl::becomeFirstResponder):
(WebKit::WebViewImpl::selectionDidChange):
(WebKit::WebViewImpl::handleRequestedCandidates):
(WebKit::textCheckingResultFromNSTextCheckingResult):
- 1:37 PM Changeset in webkit [195420] by
-
- 3 edits in trunk/Source/WTF
REGRESSION(r195417): many tests crash
https://bugs.webkit.org/show_bug.cgi?id=153316
Reviewed by Saam Barati.
This rolls out the StdLibExtras.h change, and simplifies RangeSet to not use binary search.
That's fine for now, since B3 doesn't stress RangeSet enough right now.
- wtf/RangeSet.h:
(WTF::RangeSet::contains):
(WTF::RangeSet::overlaps):
(WTF::RangeSet::clear):
(WTF::RangeSet::findRange):
- wtf/StdLibExtras.h:
(WTF::binarySearchImpl):
(WTF::binarySearch):
(WTF::tryBinarySearch):
(WTF::approximateBinarySearch):
- 12:16 PM Changeset in webkit [195419] by
-
- 2 edits in trunk/Source/JavaScriptCore
Unreviewed, undo DFGCommon.h change that accidentally enabled the B3 JIT.
- dfg/DFGCommon.h:
- 12:15 PM Changeset in webkit [195418] by
-
- 4 edits in trunk/Source/JavaScriptCore
Move32 should have an Imm, Tmp form
https://bugs.webkit.org/show_bug.cgi?id=153313
Reviewed by Mark Lam.
This enables some useful optimizations, like constant propagation in fixObviousSpills().
- assembler/MacroAssemblerX86Common.h:
(JSC::MacroAssemblerX86Common::zeroExtend32ToPtr):
(JSC::MacroAssemblerX86Common::move):
- b3/air/AirOpcode.opcodes:
- 11:54 AM Changeset in webkit [195417] by
-
- 15 edits5 adds in trunk/Source
B3 should have load elimination
https://bugs.webkit.org/show_bug.cgi?id=153288
Reviewed by Geoffrey Garen.
Source/JavaScriptCore:
This adds a complete GCSE pass that includes load elimination. It would have been super hard
to make this work as part of the reduceStrength() fixpoint, since GCSE needs to analyze
control flow and reduceStrength() is messing with control flow. So, I did a compromise: I
factored out the pure CSE that reduceStrength() was already doing, and now we have:
- reduceStrength() still does pure CSE using the new PureCSE helper.
- eliminateCommonSubexpressions() is a separate phase that does general CSE. It uses the PureCSE helper for pure values and does its own special thing for memory values.
Unfortunately, this doesn't help any benchmark right now. It doesn't hurt anything, either,
and it's likely to become a bigger pay-off once we implement other features, like mapping
FTL's abstract heaps onto B3's heap ranges.
- CMakeLists.txt:
- JavaScriptCore.xcodeproj/project.pbxproj:
- b3/B3EliminateCommonSubexpressions.cpp: Added.
(JSC::B3::eliminateCommonSubexpressions):
- b3/B3EliminateCommonSubexpressions.h: Added.
- b3/B3Generate.cpp:
(JSC::B3::generateToAir):
- b3/B3HeapRange.h:
(JSC::B3::HeapRange::HeapRange):
- b3/B3InsertionSet.h:
(JSC::B3::InsertionSet::InsertionSet):
(JSC::B3::InsertionSet::isEmpty):
(JSC::B3::InsertionSet::code):
(JSC::B3::InsertionSet::appendInsertion):
- b3/B3MemoryValue.h:
- b3/B3PureCSE.cpp: Added.
(JSC::B3::PureCSE::PureCSE):
(JSC::B3::PureCSE::~PureCSE):
(JSC::B3::PureCSE::clear):
(JSC::B3::PureCSE::process):
- b3/B3PureCSE.h: Added.
- b3/B3ReduceStrength.cpp:
- b3/B3ReduceStrength.h:
- b3/B3Validate.cpp:
Source/WTF:
I needed a way to track sets of ranges, where there is a high likelihood that all of the
ranges overlap. So I created RangeSet. It's a usually-sorted list of coalesced ranges.
Practically this means that right now, FTL B3 will end up with two kinds of range sets: a set
that just contains top and a set that contains nothing. In the future, most sets will either
be top of empty but some of them will contain a handful of other things.
- WTF.xcodeproj/project.pbxproj:
- wtf/CMakeLists.txt:
- wtf/MathExtras.h:
(WTF::leftShiftWithSaturation):
(WTF::nonEmptyRangesOverlap):
(WTF::rangesOverlap):
- wtf/RangeSet.h: Added.
(WTF::RangeSet::RangeSet):
(WTF::RangeSet::~RangeSet):
(WTF::RangeSet::add):
(WTF::RangeSet::contains):
(WTF::RangeSet::overlaps):
(WTF::RangeSet::clear):
(WTF::RangeSet::dump):
(WTF::RangeSet::dumpRaw):
(WTF::RangeSet::compact):
(WTF::RangeSet::overlapsNonEmpty):
(WTF::RangeSet::subsumesNonEmpty):
(WTF::RangeSet::findRange):
- wtf/StdLibExtras.h:
(WTF::binarySearchImpl):
(WTF::binarySearch):
(WTF::tryBinarySearch):
(WTF::approximateBinarySearch):
- 11:16 AM Changeset in webkit [195416] by
-
- 2 edits1 add in trunk/Source/JavaScriptCore
Fix bug in TypedArray.prototype.set and add tests
https://bugs.webkit.org/show_bug.cgi?id=153309
Reviewed by Michael Saboff.
This patch fixes an issue with TypedArray.prototype.set where we would
assign a double to an unsigned without checking that the double was
in the range of the unsigned. Additionally, the patch also adds
tests for set for cases that were not covered before.
- runtime/JSGenericTypedArrayViewPrototypeFunctions.h:
(JSC::genericTypedArrayViewProtoFuncSet):
- tests/stress/typedarray-set.js: Added.
- 11:00 AM Changeset in webkit [195415] by
-
- 2 edits in trunk/Source/WebCore
GraphicsContext: low quality drawImage and drawImageBuffer should use InterpolationLow
https://bugs.webkit.org/show_bug.cgi?id=49002
Reviewed by Chris Dumez.
When using low quality image scaling for images which are getting painted often,
the code used InterpolationNone, which make the images look even worse than they should.
Not easily testable.
- platform/graphics/GraphicsContext.cpp:
(WebCore::GraphicsContext::drawImage):
(WebCore::GraphicsContext::drawImageBuffer):
(WebCore::GraphicsContext::drawConsumingImageBuffer):
- 10:58 AM Changeset in webkit [195414] by
-
- 1 edit1 delete in trunk/LayoutTests
Remove a ios-simulator-wk2 specific expectation file since the results are identical on wk1 and wk2
https://bugs.webkit.org/show_bug.cgi?id=152139
Unreviewed test gardening.
- platform/ios-simulator-wk2/imported/w3c/web-platform-tests/html/semantics/forms/constraints/form-validation-validity-valueMissing-expected.txt: Removed.
- 10:27 AM Changeset in webkit [195413] by
-
- 5 edits in branches/safari-601.1.46-branch/Source
Versioning.
- 10:25 AM Changeset in webkit [195412] by
-
- 16 edits1 move1 add in trunk/Source
Make it possible to enable VIDEO_PRESENTATION_MODE on other Cocoa platforms.
https://bugs.webkit.org/show_bug.cgi?id=153218
Reviewed by Eric Carlson.
Source/JavaScriptCore:
- Configurations/FeatureDefines.xcconfig:
Source/WebCore:
No new tests. Code refactoring.
- Configurations/FeatureDefines.xcconfig:
- WebCore.xcodeproj/project.pbxproj:
Move WebVideoFullscreenInterface.h from ios to cocoa.
- html/HTMLVideoElement.cpp:
(WebCore::HTMLVideoElement::webkitSupportsPresentationMode):
The declaration of supportsPictureInPicture() has been moved to WebVideoFullscreenInterface.h
so include that header instead. Guard the supportsPictureInPicture() call with PLATFORM(COCOA)
as that method is only defined in Cocoa.
- platform/cocoa/WebVideoFullscreenInterface.h: Renamed from Source/WebCore/platform/ios/WebVideoFullscreenInterface.h.
Also move the declaration of supportsPictureInPicture() here.
- platform/graphics/MediaPlayer.cpp:
- platform/graphics/MediaPlayer.h:
- platform/graphics/MediaPlayerPrivate.h:
Implementations of methods related to the video fullscreen layer are now guarded by
PLATFORM(IOS) (PLATFORM(MAC) && ENABLE(VIDEO_PRESENTATION_MODE)) instead. - platform/ios/WebVideoFullscreenInterfaceAVKit.h:
Declaration of supportsPictureInPicture() has been moved to WebVideoFullscreenInterface.h
- platform/mac/WebVideoFullscreenInterfaceMac.mm: Added.
(WebCore::supportsPictureInPicture):
Return false for now.
Source/WebKit/mac:
- Configurations/FeatureDefines.xcconfig:
Source/WebKit2:
- Configurations/FeatureDefines.xcconfig:
Source/WTF:
- wtf/Platform.h:
- 9:50 AM Changeset in webkit [195411] by
-
- 13 edits4 adds in trunk
A crash reproducible in Path::isEmpty() under RenderSVGShape::paint()
https://bugs.webkit.org/show_bug.cgi?id=149613
Patch by Said Abou-Hallawa <sabouhallawa@apple.com> on 2016-01-21
Reviewed by Darin Adler.
Source/WebCore:
When RenderSVGRoot::layout() realizes its layout size has changed and
it has resources which have relative sizes, it marks all the clients of
the resources for invalidates regardless whether they belong to the
same RenderSVGRoot or not. But it reruns the layout only for its children.
If one of these clients comes before the current RenderSVGRoot in the render
tree, ee end up having renderer marked for invalidation at rendering time.
This also prevents scheduling the layout if the same renderer is marked
for another invalidation later. We prevent this because we do not want
to schedule another layout for a renderer which is already marked for
invalidation. This can cause crash if the renderer is an RenderSVGPath.
The fix is to mark "only" the clients of a resource which belong to the
same RenderSVGRoot of the resource. Also we need to run the layout for
all the resources which belong to different RenderSVGRoots before running
the layout for an SVG renderer.
Tests: svg/custom/filter-update-different-root.html
svg/custom/pattern-update-different-root.html
- rendering/svg/RenderSVGResourceContainer.cpp:
(WebCore::RenderSVGResourceContainer::markAllClientsForInvalidation):
We should not mark any client outside the current root for invalidation
- rendering/svg/RenderSVGResourceContainer.h: Remove unneeded private keyword.
- rendering/svg/RenderSVGRoot.cpp:
(WebCore::RenderSVGRoot::addResourceForClientInvalidation):
Code clean up; use findTreeRootObject() instead of repeating the same code.
- rendering/svg/RenderSVGShape.cpp:
(WebCore::RenderSVGShape::isEmpty): Avoid crashing if RenderSVGShape::isEmpty()
is called before calling RenderSVGShape::layout().
- rendering/svg/RenderSVGText.cpp:
(WebCore::RenderSVGText::layout): findTreeRootObject() now returns a pointer.
- rendering/svg/SVGRenderSupport.cpp:
(WebCore::SVGRenderSupport::findTreeRootObject): I do think nothing
guarantees that an SVG renderer has to have an RenderSVGRoot in its
ancestors. So change this function to return a pointer. Also Provide
the non-const version of this function.
(WebCore::SVGRenderSupport::layoutDifferentRootIfNeeded): Runs the layout
if needed for all the resources which belong to different RenderSVGRoots.
(WebCore::SVGRenderSupport::layoutChildren): Make sure all the renderer's
resources which belong to different RenderSVGRoots are laid out before
running the layout for this renderer.
- rendering/svg/SVGRenderSupport.h: Remove a mysterious comment.
- rendering/svg/SVGResources.cpp:
(WebCore::SVGResources::layoutDifferentRootIfNeeded): Run the layout for
all the resources which belong to different RenderSVGRoots outside the
context of their RenderSVGRoots.
- rendering/svg/SVGResources.h:
(WebCore::SVGResources::clipper):
(WebCore::SVGResources::markerStart):
(WebCore::SVGResources::markerMid):
(WebCore::SVGResources::markerEnd):
(WebCore::SVGResources::masker):
(WebCore::SVGResources::filter):
(WebCore::SVGResources::fill):
(WebCore::SVGResources::stroke):
Code clean up; use nullptr instead of 0.
LayoutTests:
When running the layout of an SVG root and it has resources which are
referenced by clients in other SVG roots, make sure we run the layout
for these resources before running the layout for their clients.
- svg/custom/filter-update-different-root-expected.html: Added.
- svg/custom/filter-update-different-root.html: Added.
Without this patch this test crashes because we paint a dirty RenderSVGShape.
- svg/custom/pattern-update-different-root-expected.html: Added.
- svg/custom/pattern-update-different-root.html: Added.
Without this patch this test works fine but it is good to have it to catch
cases where the SVG root needs to run re-layout for its children resources
and hence their clients if its size has changed.
- svg/custom/unicode-in-tspan-multi-svg-crash-expected.txt:
- svg/custom/unicode-in-tspan-multi-svg-crash.html:
This test was ported from Blink in http://trac.webkit.org/changeset/166420.
The expectation of this test was changed in Blink:
https://src.chromium.org/viewvc/blink?revision=158480&view=revision.
- 9:15 AM Changeset in webkit [195410] by
-
- 21 edits2 copies in trunk/Source/WebCore
[EME] Correctly report errors when generating key requests from AVContentKeySession.
https://bugs.webkit.org/show_bug.cgi?id=151963
Reviewed by Eric Carlson.
WebIDL's "unsigned long" is a 32-bit unsigned integer, and C++'s "unsigned long" is (or, can
be) a 64-bit integer on 64-bit platforms. Casting a negative integer to a 64-bit integer
results in a number which cannot be accurately stored in a double-length floating point
number. Previously, the mac CDM code would work around this issue by returning the absolute
value of NSError code returned by media frameworks. Instead, fix the underlying problem by
storing the MediaKeyError's systemCode as a uint32_t (which more accurately represents the
size of a WebIDL "unsigned long" on all platforms.)
Check the error code issued by -contentKeyRequestDataForApp:contentIdentifier:options:error:.
- Modules/encryptedmedia/CDM.h:
- Modules/encryptedmedia/CDMSessionClearKey.cpp:
(WebCore::CDMSessionClearKey::generateKeyRequest):
(WebCore::CDMSessionClearKey::update):
- Modules/encryptedmedia/CDMSessionClearKey.h:
- Modules/encryptedmedia/MediaKeySession.cpp:
(WebCore::MediaKeySession::keyRequestTimerFired):
(WebCore::MediaKeySession::addKeyTimerFired):
(WebCore::MediaKeySession::sendError):
- Modules/encryptedmedia/MediaKeySession.h:
- Modules/mediacontrols/mediaControlsApple.js:
(Controller.prototype.handleReadyStateChange):
- WebCore.xcodeproj/project.pbxproj:
- html/MediaKeyError.h:
(WebCore::MediaKeyError::create):
(WebCore::MediaKeyError::systemCode):
- html/MediaKeyEvent.h:
- platform/graphics/CDMSession.h:
- platform/graphics/avfoundation/cf/CDMSessionAVFoundationCF.cpp:
(WebCore::CDMSessionAVFoundationCF::generateKeyRequest):
(WebCore::CDMSessionAVFoundationCF::update):
- platform/graphics/avfoundation/cf/CDMSessionAVFoundationCF.h:
- platform/graphics/avfoundation/objc/CDMSessionAVContentKeySession.h:
- platform/graphics/avfoundation/objc/CDMSessionAVContentKeySession.mm:
(WebCore::CDMSessionAVContentKeySession::generateKeyRequest):
(WebCore::CDMSessionAVContentKeySession::update):
(WebCore::CDMSessionAVContentKeySession::generateKeyReleaseMessage):
- platform/graphics/avfoundation/objc/CDMSessionAVFoundationObjC.h:
- platform/graphics/avfoundation/objc/CDMSessionAVFoundationObjC.mm:
(WebCore::CDMSessionAVFoundationObjC::generateKeyRequest):
(WebCore::CDMSessionAVFoundationObjC::update):
- platform/graphics/avfoundation/objc/CDMSessionAVStreamSession.h:
- platform/graphics/avfoundation/objc/CDMSessionAVStreamSession.mm:
(WebCore::CDMSessionAVStreamSession::generateKeyRequest):
(WebCore::CDMSessionAVStreamSession::update):
(WebCore::CDMSessionAVStreamSession::generateKeyReleaseMessage):
- platform/graphics/avfoundation/objc/CDMSessionMediaSourceAVFObjC.h:
- platform/graphics/avfoundation/objc/CDMSessionMediaSourceAVFObjC.mm:
(WebCore::CDMSessionMediaSourceAVFObjC::layerDidReceiveError):
(WebCore::CDMSessionMediaSourceAVFObjC::rendererDidReceiveError):
(WebCore::CDMSessionMediaSourceAVFObjC::systemCodeForError): Deleted.
- testing/MockCDM.cpp:
(WebCore::MockCDMSession::generateKeyRequest):
(WebCore::MockCDMSession::update):2016-01-15 Simon Fraser <Simon Fraser>
- 7:47 AM Changeset in webkit [195409] by
-
- 2 edits in trunk/Tools
display-profiler-output should be able to display code blocks sorted by machine counts
https://bugs.webkit.org/show_bug.cgi?id=153298
Reviewed by Oliver Hunt.
- Scripts/display-profiler-output:
- 7:27 AM Changeset in webkit [195408] by
-
- 3 edits in trunk/Tools
Ensure to use compatible liborc version with wanted gstreamer version
https://bugs.webkit.org/show_bug.cgi?id=153276
For example gst-plugins-base-1.4.4 fails to build with liborc-0.4.24.
The user may have a very recent liborc installed on his system.
Patch by Julien Isorce <j.isorce@samsung.com> on 2016-01-21
Reviewed by Philippe Normand.
- efl/jhbuild.modules: add liborc-0.4.17 and make it a gst dependency.
- gtk/jhbuild.modules: add liborc-0.4.17 and make it a gst depencendy.
- 4:51 AM Changeset in webkit [195407] by
-
- 2 edits in trunk/Source/JavaScriptCore
[B3][CMake] Add missing source file.
https://bugs.webkit.org/show_bug.cgi?id=153303
Reviewed by Csaba Osztrogonác.
- CMakeLists.txt:
- 1:17 AM Changeset in webkit [195406] by
-
- 2 edits in trunk/Source/WebCore
[SOUP] GResource resources should be cached indefinitely in memory cache
https://bugs.webkit.org/show_bug.cgi?id=153275
Reviewed by Žan Doberšek.
GResources can't change so they will always return the same data,
we never need to revalidate them.
- loader/cache/CachedResource.cpp:
(WebCore::shouldCacheSchemeIndefinitely):
- 12:35 AM Changeset in webkit [195405] by
-
- 15 edits1 copy4 moves1 add in trunk
AX: [IOS] Implement next/previous text marker functions using TextIterator
https://bugs.webkit.org/show_bug.cgi?id=153292
<rdar://problem/24268243>
Reviewed by Chris Fleizach.
Source/WebCore:
Added support for the refactored next/previous text marker functions on iOS. And
made text marker tests working on iOS.
Also, fixed an issue in AXObjectCache where creating a range with a replaced node
at the start or end might exclude that node.
Tests: accessibility/text-marker/text-marker-previous-next.html
accessibility/text-marker/text-marker-with-user-select-none.html
- accessibility/AXObjectCache.cpp:
(WebCore::characterOffsetsInOrder):
(WebCore::resetNodeAndOffsetForReplacedNode):
(WebCore::AXObjectCache::rangeForUnorderedCharacterOffsets):
- accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:
(+[WebAccessibilityTextMarker textMarkerWithVisiblePosition:cache:]):
(+[WebAccessibilityTextMarker textMarkerWithCharacterOffset:cache:]):
(+[WebAccessibilityTextMarker startOrEndTextMarkerForRange:isStart:cache:]):
(-[WebAccessibilityTextMarker dataRepresentation]):
(-[WebAccessibilityTextMarker visiblePosition]):
(-[WebAccessibilityTextMarker characterOffset]):
(-[WebAccessibilityTextMarker isIgnored]):
(-[WebAccessibilityTextMarker accessibilityObject]):
(-[WebAccessibilityTextMarker description]):
(-[WebAccessibilityObjectWrapper stringForTextMarkers:]):
(blockquoteLevel):
(-[WebAccessibilityObjectWrapper textMarkerRange]):
(-[WebAccessibilityObjectWrapper accessibilityObjectForTextMarker:]):
(-[WebAccessibilityObjectWrapper nextMarkerForMarker:]):
(-[WebAccessibilityObjectWrapper previousMarkerForMarker:]):
(-[WebAccessibilityObjectWrapper textMarkerForPoint:]):
(-[WebAccessibilityObjectWrapper nextMarkerForCharacterOffset:]):
(-[WebAccessibilityObjectWrapper previousMarkerForCharacterOffset:]):
(-[WebAccessibilityObjectWrapper rangeForTextMarkers:]):
(-[WebAccessibilityObjectWrapper lengthForTextMarkers:]):
(-[WebAccessibilityObjectWrapper startOrEndTextMarkerForTextMarkers:isStart:]):
(-[WebAccessibilityObjectWrapper textMarkerRangeForMarkers:]):
(-[WebAccessibilityObjectWrapper accessibilityIdentifier]):
Tools:
Made text marker tests available on iOS.
- DumpRenderTree/AccessibilityTextMarker.h:
- DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
- DumpRenderTree/ios/AccessibilityTextMarkerIOS.mm: Added.
(AccessibilityTextMarker::AccessibilityTextMarker):
(AccessibilityTextMarker::~AccessibilityTextMarker):
(AccessibilityTextMarker::isEqual):
(AccessibilityTextMarker::platformTextMarker):
(AccessibilityTextMarkerRange::AccessibilityTextMarkerRange):
(AccessibilityTextMarkerRange::~AccessibilityTextMarkerRange):
(AccessibilityTextMarkerRange::isEqual):
(AccessibilityTextMarkerRange::platformTextMarkerRange):
- DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
(AccessibilityUIElement::pathDescription):
(AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
(AccessibilityUIElement::textMarkerRangeForElement):
(AccessibilityUIElement::selectedTextMarkerRange):
(AccessibilityUIElement::resetSelectedTextMarkerRange):
(AccessibilityUIElement::textMarkerRangeLength):
(AccessibilityUIElement::textMarkerRangeForMarkers):
(AccessibilityUIElement::startTextMarkerForTextMarkerRange):
(AccessibilityUIElement::endTextMarkerForTextMarkerRange):
(AccessibilityUIElement::accessibilityElementForTextMarker):
(AccessibilityUIElement::endTextMarkerForBounds):
(AccessibilityUIElement::startTextMarkerForBounds):
(AccessibilityUIElement::textMarkerForPoint):
(AccessibilityUIElement::previousTextMarker):
(AccessibilityUIElement::nextTextMarker):
(AccessibilityUIElement::stringForTextMarkerRange):
(AccessibilityUIElement::attributedStringForTextMarkerRangeContainsAttribute):
(AccessibilityUIElement::indexForTextMarker):
(AccessibilityUIElement::isTextMarkerValid):
(AccessibilityUIElement::textMarkerForIndex):
(AccessibilityUIElement::startTextMarker):
(AccessibilityUIElement::endTextMarker):
(AccessibilityUIElement::setSelectedVisibleTextRange):
(AccessibilityUIElement::getLinkedUIElements):
- DumpRenderTree/mac/AccessibilityTextMarkerMac.mm:
(AccessibilityTextMarkerRange::platformTextMarkerRange):
- DumpRenderTree/mac/AccessibilityUIElementMac.mm:
(AccessibilityUIElement::removeSelection):
(AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
(AccessibilityUIElement::setSelectedVisibleTextRange):
(AccessibilityUIElement::supportedActions):
- WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
(WTR::AccessibilityUIElement::textMarkerRangeForElement):
(WTR::AccessibilityUIElement::textMarkerRangeLength):
(WTR::AccessibilityUIElement::previousTextMarker):
(WTR::AccessibilityUIElement::nextTextMarker):
(WTR::AccessibilityUIElement::stringForTextMarkerRange):
(WTR::AccessibilityUIElement::textMarkerRangeForMarkers):
(WTR::AccessibilityUIElement::startTextMarkerForTextMarkerRange):
(WTR::AccessibilityUIElement::endTextMarkerForTextMarkerRange):
(WTR::AccessibilityUIElement::endTextMarkerForBounds):
(WTR::AccessibilityUIElement::accessibilityElementForTextMarker):
(WTR::AccessibilityUIElement::attributedStringForTextMarkerRangeContainsAttribute):
LayoutTests:
- accessibility/mac/previous-next-text-marker-expected.txt: Removed.
- accessibility/mac/previous-next-text-marker.html: Removed.
- accessibility/mac/text-marker-with-user-select-none-expected.txt: Removed.
- accessibility/mac/text-marker-with-user-select-none.html: Removed.
- accessibility/text-marker: Added.
- accessibility/text-marker/text-marker-previous-next-expected.txt: Added.
- accessibility/text-marker/text-marker-previous-next.html: Added.
- accessibility/text-marker/text-marker-with-user-select-none-expected.txt: Added.
- accessibility/text-marker/text-marker-with-user-select-none.html: Added.
- platform/efl/TestExpectations:
- platform/gtk/TestExpectations:
- platform/ios-simulator/TestExpectations:
- platform/win/TestExpectations:
Jan 20, 2016:
- 11:59 PM Changeset in webkit [195404] by
-
- 1 edit1 copy in branches/safari-601-branch/LayoutTests
Merged r188383. rdar://problem/24208102
- 11:58 PM Changeset in webkit [195403] by
-
- 6 edits2 copies in branches/safari-601-branch
Merged r188377. rdar://problem/24208102
- 11:57 PM Changeset in webkit [195402] by
-
- 7 edits2 copies in branches/safari-601-branch
Merged r188263. rdar://problem/24208102
- 11:16 PM Changeset in webkit [195401] by
-
- 6 edits in branches/safari-601.1.46-branch/Source/WebCore
Merged r195132. rdar://problem/24154424
- 11:13 PM Changeset in webkit [195400] by
-
- 5 edits15 copies in branches/safari-601.1.46-branch
Merged r195075. rdar://problem/24001776
- 11:11 PM Changeset in webkit [195399] by
-
- 4 edits4 copies in branches/safari-601.1.46-branch
Merged r195162. rdar://problem/23978912
- 8:47 PM Changeset in webkit [195398] by
-
- 2 edits1 delete in trunk/Source/JavaScriptCore
Unreviewed, rolling out r195375.
https://bugs.webkit.org/show_bug.cgi?id=153300
Caused crashes on GuardMalloc (Requested by ap on #webkit).
Reverted changeset:
"TypedArray's .buffer does not return the JSArrayBuffer that
was passed to it on creation."
https://bugs.webkit.org/show_bug.cgi?id=153281
http://trac.webkit.org/changeset/195375
- 7:50 PM Changeset in webkit [195397] by
-
- 5 edits2 adds in trunk
http://victordarras.fr/cssgame/ doesn't work in Safari.
https://bugs.webkit.org/show_bug.cgi?id=153285
<rdar://problem/24212369>
Reviewed by Tim Horton.
This patch adds support for hittesting ClipPathOperation::Reference.
Source/WebCore:
Tests: svg/clip-path/hittest-clip-path-reference-miss.html
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::nodeAtPoint):
- rendering/RenderObject.h:
(WebCore::RenderObject::isSVGResourceClipper):
- rendering/svg/RenderSVGResourceClipper.h:
(isType):
LayoutTests:
- svg/clip-path/hittest-clip-path-reference-miss-expected.html: Added.
- svg/clip-path/hittest-clip-path-reference-miss.html: Added.
- 7:20 PM Changeset in webkit [195396] by
-
- 2 edits in trunk/Tools
Unreviewed, revert accidental unreviewed commit.
- Scripts/display-profiler-output:
- 7:12 PM Changeset in webkit [195395] by
-
- 57 edits11 adds in trunk
B3 should have basic path specialization
https://bugs.webkit.org/show_bug.cgi?id=153200
Reviewed by Benjamin Poulain.
Source/JavaScriptCore:
This adds two different kind of path specializations:
- Check(Select) where the Select results are constants is specialized into a Branch instead of a Select and duplicated paths where the results of the Select are folded.
- Tail duplication. A jump to a small block causes the block's contents to be copied over the Jump.
Both optimizations required being able to clone Values. We can now do that using
proc.clone(value).
Check(Select) specialization needed some utilities for walking graphs of Values.
Tail duplication needed SSA fixup, so I added a way to demote values to anonymous stack
slots (B3's equivalent of non-SSA variables) and a way to "fix SSA", i.e. to allocate
anonymous stack slots to SSA values along with an optimal Phi graph.
This is a big speed-up on Octane/deltablue. It's a 2.2% speed-up on Octane overall.
- CMakeLists.txt:
- JavaScriptCore.xcodeproj/project.pbxproj:
- b3/B3ArgumentRegValue.cpp:
(JSC::B3::ArgumentRegValue::dumpMeta):
(JSC::B3::ArgumentRegValue::cloneImpl):
- b3/B3ArgumentRegValue.h:
- b3/B3BasicBlock.cpp:
(JSC::B3::BasicBlock::append):
(JSC::B3::BasicBlock::appendNonTerminal):
(JSC::B3::BasicBlock::removeLast):
- b3/B3BasicBlock.h:
(JSC::B3::BasicBlock::values):
- b3/B3BasicBlockInlines.h:
(JSC::B3::BasicBlock::appendNew):
(JSC::B3::BasicBlock::appendNewNonTerminal):
(JSC::B3::BasicBlock::replaceLastWithNew):
- b3/B3BlockInsertionSet.h:
- b3/B3BreakCriticalEdges.cpp: Added.
(JSC::B3::breakCriticalEdges):
- b3/B3BreakCriticalEdges.h: Added.
- b3/B3CCallValue.cpp:
(JSC::B3::CCallValue::~CCallValue):
(JSC::B3::CCallValue::cloneImpl):
- b3/B3CCallValue.h:
- b3/B3CheckValue.cpp:
(JSC::B3::CheckValue::convertToAdd):
(JSC::B3::CheckValue::cloneImpl):
(JSC::B3::CheckValue::CheckValue):
- b3/B3CheckValue.h:
- b3/B3Const32Value.cpp:
(JSC::B3::Const32Value::dumpMeta):
(JSC::B3::Const32Value::cloneImpl):
- b3/B3Const32Value.h:
- b3/B3Const64Value.cpp:
(JSC::B3::Const64Value::dumpMeta):
(JSC::B3::Const64Value::cloneImpl):
- b3/B3Const64Value.h:
- b3/B3ConstDoubleValue.cpp:
(JSC::B3::ConstDoubleValue::dumpMeta):
(JSC::B3::ConstDoubleValue::cloneImpl):
- b3/B3ConstDoubleValue.h:
- b3/B3ConstFloatValue.cpp:
(JSC::B3::ConstFloatValue::dumpMeta):
(JSC::B3::ConstFloatValue::cloneImpl):
- b3/B3ConstFloatValue.h:
- b3/B3ControlValue.cpp:
(JSC::B3::ControlValue::dumpMeta):
(JSC::B3::ControlValue::cloneImpl):
- b3/B3ControlValue.h:
- b3/B3DuplicateTails.cpp: Added.
(JSC::B3::duplicateTails):
- b3/B3DuplicateTails.h: Added.
- b3/B3FixSSA.cpp: Added.
(JSC::B3::demoteValues):
(JSC::B3::fixSSA):
- b3/B3FixSSA.h: Added.
- b3/B3Generate.cpp:
(JSC::B3::generateToAir):
- b3/B3IndexSet.h:
(JSC::B3::IndexSet::Iterable::Iterable):
(JSC::B3::IndexSet::values):
(JSC::B3::IndexSet::indices):
- b3/B3InsertionSet.cpp:
(JSC::B3::InsertionSet::insertIntConstant):
(JSC::B3::InsertionSet::insertBottom):
(JSC::B3::InsertionSet::execute):
- b3/B3InsertionSet.h:
- b3/B3LowerToAir.cpp:
(JSC::B3::Air::LowerToAir::run):
(JSC::B3::Air::LowerToAir::tmp):
- b3/B3MemoryValue.cpp:
(JSC::B3::MemoryValue::dumpMeta):
(JSC::B3::MemoryValue::cloneImpl):
- b3/B3MemoryValue.h:
- b3/B3OriginDump.cpp: Added.
(JSC::B3::OriginDump::dump):
- b3/B3OriginDump.h:
(JSC::B3::OriginDump::OriginDump):
(JSC::B3::OriginDump::dump): Deleted.
- b3/B3PatchpointValue.cpp:
(JSC::B3::PatchpointValue::dumpMeta):
(JSC::B3::PatchpointValue::cloneImpl):
(JSC::B3::PatchpointValue::PatchpointValue):
- b3/B3PatchpointValue.h:
- b3/B3Procedure.cpp:
(JSC::B3::Procedure::addBlock):
(JSC::B3::Procedure::clone):
(JSC::B3::Procedure::addIntConstant):
(JSC::B3::Procedure::addBottom):
(JSC::B3::Procedure::addBoolConstant):
(JSC::B3::Procedure::deleteValue):
- b3/B3Procedure.h:
- b3/B3ReduceStrength.cpp:
- b3/B3SSACalculator.cpp: Added.
(JSC::B3::SSACalculator::Variable::dump):
(JSC::B3::SSACalculator::Variable::dumpVerbose):
(JSC::B3::SSACalculator::Def::dump):
(JSC::B3::SSACalculator::SSACalculator):
(JSC::B3::SSACalculator::~SSACalculator):
(JSC::B3::SSACalculator::reset):
(JSC::B3::SSACalculator::newVariable):
(JSC::B3::SSACalculator::newDef):
(JSC::B3::SSACalculator::nonLocalReachingDef):
(JSC::B3::SSACalculator::reachingDefAtTail):
(JSC::B3::SSACalculator::dump):
- b3/B3SSACalculator.h: Added.
(JSC::B3::SSACalculator::Variable::index):
(JSC::B3::SSACalculator::Variable::Variable):
(JSC::B3::SSACalculator::Def::variable):
(JSC::B3::SSACalculator::Def::block):
(JSC::B3::SSACalculator::Def::value):
(JSC::B3::SSACalculator::Def::Def):
(JSC::B3::SSACalculator::variable):
(JSC::B3::SSACalculator::computePhis):
(JSC::B3::SSACalculator::phisForBlock):
(JSC::B3::SSACalculator::reachingDefAtHead):
- b3/B3StackSlotKind.h:
- b3/B3StackSlotValue.cpp:
(JSC::B3::StackSlotValue::dumpMeta):
(JSC::B3::StackSlotValue::cloneImpl):
- b3/B3StackSlotValue.h:
- b3/B3SwitchValue.cpp:
(JSC::B3::SwitchValue::dumpMeta):
(JSC::B3::SwitchValue::cloneImpl):
(JSC::B3::SwitchValue::SwitchValue):
- b3/B3SwitchValue.h:
- b3/B3UpsilonValue.cpp:
(JSC::B3::UpsilonValue::dumpMeta):
(JSC::B3::UpsilonValue::cloneImpl):
- b3/B3UpsilonValue.h:
- b3/B3Validate.cpp:
- b3/B3Value.cpp:
(JSC::B3::Value::replaceWithNop):
(JSC::B3::Value::replaceWithPhi):
(JSC::B3::Value::dump):
(JSC::B3::Value::cloneImpl):
(JSC::B3::Value::dumpChildren):
(JSC::B3::Value::deepDump):
- b3/B3Value.h:
(JSC::B3::DeepValueDump::DeepValueDump):
(JSC::B3::DeepValueDump::dump):
(JSC::B3::deepDump):
- b3/B3ValueInlines.h:
(JSC::B3::Value::asNumber):
(JSC::B3::Value::walk):
- b3/B3ValueKey.cpp:
(JSC::B3::ValueKey::intConstant):
(JSC::B3::ValueKey::dump):
- b3/B3ValueKey.h:
(JSC::B3::ValueKey::ValueKey):
(JSC::B3::ValueKey::opcode):
(JSC::B3::ValueKey::type):
(JSC::B3::ValueKey::childIndex):
- b3/air/AirCode.h:
(JSC::B3::Air::Code::forAllTmps):
(JSC::B3::Air::Code::isFastTmp):
- b3/air/AirIteratedRegisterCoalescing.cpp:
- b3/air/AirUseCounts.h:
(JSC::B3::Air::UseCounts::UseCounts):
(JSC::B3::Air::UseCounts::operator[]):
(JSC::B3::Air::UseCounts::dump):
- b3/testb3.cpp:
(JSC::B3::testSelectInvert):
(JSC::B3::testCheckSelect):
(JSC::B3::testCheckSelectCheckSelect):
(JSC::B3::testPowDoubleByIntegerLoop):
(JSC::B3::run):
- runtime/Options.h:
Source/WTF:
- wtf/GraphNodeWorklist.h:
(WTF::GraphNodeWorklist::push):
(WTF::GraphNodeWorklist::pushAll):
(WTF::GraphNodeWorklist::isEmpty):
(WTF::GraphNodeWorklist::notEmpty):
- 6:13 PM Changeset in webkit [195394] by
-
- 11 edits280 adds2 deletes in trunk/LayoutTests
Modern IDB: Add -private.html variants of every storage/indexeddb test that doesn't already have them.
https://bugs.webkit.org/show_bug.cgi?id=153272
Reviewed by Alex Christensen.
This includes some cleanups to the shared js files to make each test more resilient to being run twice.
- TestExpectations:
- platform/mac-wk1/TestExpectations:
- platform/wk2/TestExpectations:
- storage/indexeddb/clone-exception-private-expected.txt: Added.
- storage/indexeddb/clone-exception-private.html: Added.
- storage/indexeddb/closed-cursor-private-expected.txt: Added.
- storage/indexeddb/closed-cursor-private.html: Added.
- storage/indexeddb/connection-leak-private-expected.txt: Added.
- storage/indexeddb/connection-leak-private.html: Added.
- storage/indexeddb/cursor-cast-private-expected.txt: Added.
- storage/indexeddb/cursor-cast-private.html: Added.
- storage/indexeddb/cursor-leak-private-expected.txt: Added.
- storage/indexeddb/cursor-leak-private.html: Added.
- storage/indexeddb/cursor-overloads-private-expected.txt: Added.
- storage/indexeddb/cursor-overloads-private.html: Added.
- storage/indexeddb/cursor-request-cycle-private-expected.txt: Added.
- storage/indexeddb/cursor-request-cycle-private.html: Added.
- storage/indexeddb/deleteIndex-bug110792-private-expected.txt: Added.
- storage/indexeddb/deleteIndex-bug110792-private.html: Added.
- storage/indexeddb/deletedatabase-delayed-by-versionchange-private-expected.txt: Removed.
- storage/indexeddb/deletedatabase-transaction-private-expected.txt: Added.
- storage/indexeddb/deletedatabase-transaction-private.html: Added.
- storage/indexeddb/dont-commit-on-blocked-private-expected.txt: Added.
- storage/indexeddb/dont-commit-on-blocked-private.html: Added.
- storage/indexeddb/lazy-index-population-private-expected.txt: Added.
- storage/indexeddb/lazy-index-population-private.html: Added.
- storage/indexeddb/metadata-race-private-expected.txt: Added.
- storage/indexeddb/metadata-race-private.html: Added.
- storage/indexeddb/modern/abort-objectstore-info-private-expected.txt: Added.
- storage/indexeddb/modern/abort-objectstore-info-private.html: Added.
- storage/indexeddb/modern/abort-requests-cancelled-private-expected.txt: Added.
- storage/indexeddb/modern/abort-requests-cancelled-private.html: Added.
- storage/indexeddb/modern/aborted-put-private-expected.txt: Added.
- storage/indexeddb/modern/aborted-put-private.html: Added.
- storage/indexeddb/modern/autoincrement-abort-private-expected.txt: Added.
- storage/indexeddb/modern/autoincrement-abort-private.html: Added.
- storage/indexeddb/modern/basic-add-private-expected.txt: Added.
- storage/indexeddb/modern/basic-add-private.html: Added.
- storage/indexeddb/modern/basic-put-private-expected.txt: Added.
- storage/indexeddb/modern/basic-put-private.html: Added.
- storage/indexeddb/modern/blocked-open-db-requests-private-expected.txt: Added.
- storage/indexeddb/modern/blocked-open-db-requests-private.html: Added.
- storage/indexeddb/modern/create-index-failures-private-expected.txt: Added.
- storage/indexeddb/modern/create-index-failures-private.html: Added.
- storage/indexeddb/modern/createobjectstore-basic-private-expected.txt: Added.
- storage/indexeddb/modern/createobjectstore-basic-private.html: Added.
- storage/indexeddb/modern/createobjectstore-failures-private-expected.txt: Added.
- storage/indexeddb/modern/createobjectstore-failures-private.html: Added.
- storage/indexeddb/modern/cursor-1-private-expected.txt: Added.
- storage/indexeddb/modern/cursor-1-private.html: Added.
- storage/indexeddb/modern/cursor-2-private-expected.txt: Added.
- storage/indexeddb/modern/cursor-2-private.html: Added.
- storage/indexeddb/modern/cursor-3-private-expected.txt: Added.
- storage/indexeddb/modern/cursor-3-private.html: Added.
- storage/indexeddb/modern/cursor-4-private-expected.txt: Added.
- storage/indexeddb/modern/cursor-4-private.html: Added.
- storage/indexeddb/modern/cursor-5-private-expected.txt: Added.
- storage/indexeddb/modern/cursor-5-private.html: Added.
- storage/indexeddb/modern/cursor-6-private-expected.txt: Added.
- storage/indexeddb/modern/cursor-6-private.html: Added.
- storage/indexeddb/modern/cursor-7-private-expected.txt: Added.
- storage/indexeddb/modern/cursor-7-private.html: Added.
- storage/indexeddb/modern/cursor-8-private-expected.txt: Added.
- storage/indexeddb/modern/cursor-8-private.html: Added.
- storage/indexeddb/modern/date-basic-private-expected.txt: Added.
- storage/indexeddb/modern/date-basic-private.html: Added.
- storage/indexeddb/modern/deletedatabase-1-private-expected.txt: Added.
- storage/indexeddb/modern/deletedatabase-1-private.html: Added.
- storage/indexeddb/modern/deletedatabase-2-private-expected.txt: Added.
- storage/indexeddb/modern/deletedatabase-2-private.html: Added.
- storage/indexeddb/modern/deletedatabase-null-name-exception-private-expected.txt: Added.
- storage/indexeddb/modern/deletedatabase-null-name-exception-private.html: Added.
- storage/indexeddb/modern/deletedatabase-request-event-private-expected.txt: Added.
- storage/indexeddb/modern/deletedatabase-request-event-private.html: Added.
- storage/indexeddb/modern/deletedatabase-request-private-expected.txt: Added.
- storage/indexeddb/modern/deletedatabase-request-private.html: Added.
- storage/indexeddb/modern/deleteindex-1-private-expected.txt: Added.
- storage/indexeddb/modern/deleteindex-1-private.html: Added.
- storage/indexeddb/modern/deleteindex-2-private-expected.txt: Added.
- storage/indexeddb/modern/deleteindex-2-private.html: Added.
- storage/indexeddb/modern/deleteobjectstore-1-private-expected.txt: Added.
- storage/indexeddb/modern/deleteobjectstore-1-private.html: Added.
- storage/indexeddb/modern/double-abort-private-expected.txt: Added.
- storage/indexeddb/modern/double-abort-private.html: Added.
- storage/indexeddb/modern/double-open-private-expected.txt: Added.
- storage/indexeddb/modern/double-open-private.html: Added.
- storage/indexeddb/modern/get-index-failures-private-expected.txt: Added.
- storage/indexeddb/modern/get-index-failures-private.html: Added.
- storage/indexeddb/modern/get-keyrange-private-expected.txt: Added.
- storage/indexeddb/modern/get-keyrange-private.html: Added.
- storage/indexeddb/modern/idbdatabase-deleteobjectstore-failures-private-expected.txt: Added.
- storage/indexeddb/modern/idbdatabase-deleteobjectstore-failures-private.html: Added.
- storage/indexeddb/modern/idbdatabase-transaction-failures-private-expected.txt: Added.
- storage/indexeddb/modern/idbdatabase-transaction-failures-private.html: Added.
- storage/indexeddb/modern/idbindex-properties-basic-private-expected.txt: Added.
- storage/indexeddb/modern/idbindex-properties-basic-private.html: Added.
- storage/indexeddb/modern/idbobjectstore-clear-1-private-expected.txt: Added.
- storage/indexeddb/modern/idbobjectstore-clear-1-private.html: Added.
- storage/indexeddb/modern/idbobjectstore-clear-2-private-expected.txt: Added.
- storage/indexeddb/modern/idbobjectstore-clear-2-private.html: Added.
- storage/indexeddb/modern/idbobjectstore-count-1-private-expected.txt: Added.
- storage/indexeddb/modern/idbobjectstore-count-1-private.html: Added.
- storage/indexeddb/modern/idbobjectstore-count-failures-private-expected.txt: Added.
- storage/indexeddb/modern/idbobjectstore-count-failures-private.html: Added.
- storage/indexeddb/modern/idbobjectstore-delete-1-private-expected.txt: Added.
- storage/indexeddb/modern/idbobjectstore-delete-1-private.html: Added.
- storage/indexeddb/modern/idbobjectstore-delete-2-private-expected.txt: Added.
- storage/indexeddb/modern/idbobjectstore-delete-2-private.html: Added.
- storage/indexeddb/modern/idbobjectstore-delete-failures-private-expected.txt: Added.
- storage/indexeddb/modern/idbobjectstore-delete-failures-private.html: Added.
- storage/indexeddb/modern/idbobjectstore-get-failures-private-expected.txt: Added.
- storage/indexeddb/modern/idbobjectstore-get-failures-private.html: Added.
- storage/indexeddb/modern/idbobjectstore-put-and-clear-failures-private-expected.txt: Added.
- storage/indexeddb/modern/idbobjectstore-put-and-clear-failures-private.html: Added.
- storage/indexeddb/modern/idbtransaction-objectstore-failures-private-expected.txt: Added.
- storage/indexeddb/modern/idbtransaction-objectstore-failures-private.html: Added.
- storage/indexeddb/modern/index-1-private-expected.txt: Added.
- storage/indexeddb/modern/index-1-private.html: Added.
- storage/indexeddb/modern/index-2-private-expected.txt: Added.
- storage/indexeddb/modern/index-2-private.html: Added.
- storage/indexeddb/modern/index-3-private-expected.txt: Added.
- storage/indexeddb/modern/index-3-private.html: Added.
- storage/indexeddb/modern/index-4-private-expected.txt: Added.
- storage/indexeddb/modern/index-4-private.html: Added.
- storage/indexeddb/modern/index-5-private-expected.txt: Added.
- storage/indexeddb/modern/index-5-private.html: Added.
- storage/indexeddb/modern/index-cursor-1-private-expected.txt: Added.
- storage/indexeddb/modern/index-cursor-1-private.html: Added.
- storage/indexeddb/modern/index-cursor-2-private-expected.txt: Added.
- storage/indexeddb/modern/index-cursor-2-private.html: Added.
- storage/indexeddb/modern/index-cursor-3-private-expected.txt: Added.
- storage/indexeddb/modern/index-cursor-3-private.html: Added.
- storage/indexeddb/modern/index-get-count-basic-private-expected.txt: Added.
- storage/indexeddb/modern/index-get-count-basic-private.html: Added.
- storage/indexeddb/modern/index-get-count-failures-private-expected.txt: Added.
- storage/indexeddb/modern/index-get-count-failures-private.html: Added.
- storage/indexeddb/modern/keypath-basic-private-expected.txt: Added.
- storage/indexeddb/modern/keypath-basic-private.html: Added.
- storage/indexeddb/modern/memory-index-not-deleted-with-objectstore-private-expected.txt: Added.
- storage/indexeddb/modern/memory-index-not-deleted-with-objectstore-private.html: Added.
- storage/indexeddb/modern/objectstore-attributes-private-expected.txt: Added.
- storage/indexeddb/modern/objectstore-attributes-private.html: Added.
- storage/indexeddb/modern/objectstore-cursor-advance-failures-private-expected.txt: Added.
- storage/indexeddb/modern/objectstore-cursor-advance-failures-private.html: Added.
- storage/indexeddb/modern/objectstore-cursor-continue-failures-private-expected.txt: Added.
- storage/indexeddb/modern/objectstore-cursor-continue-failures-private.html: Added.
- storage/indexeddb/modern/opencursor-failures-private-expected.txt: Added.
- storage/indexeddb/modern/opencursor-failures-private.html: Added.
- storage/indexeddb/modern/opendatabase-request-event-private-expected.txt: Added.
- storage/indexeddb/modern/opendatabase-request-event-private.html: Added.
- storage/indexeddb/modern/opendatabase-request-private-expected.txt: Added.
- storage/indexeddb/modern/opendatabase-request-private.html: Added.
- storage/indexeddb/modern/opendatabase-success-after-versionchange-private-expected.txt: Added.
- storage/indexeddb/modern/opendatabase-success-after-versionchange-private.html: Added.
- storage/indexeddb/modern/opendatabase-versions-private-expected.txt: Added.
- storage/indexeddb/modern/opendatabase-versions-private.html: Added.
- storage/indexeddb/modern/request-readystate-private-expected.txt: Added.
- storage/indexeddb/modern/request-readystate-private.html: Added.
- storage/indexeddb/modern/resources/opendatabase-request-event.js:
- storage/indexeddb/modern/resources/opendatabase-versions.js:
- storage/indexeddb/modern/resources/request-readystate.js:
- storage/indexeddb/modern/resources/versionchange-abort-then-reopen.js:
- storage/indexeddb/modern/transaction-scheduler-1-private-expected.txt: Added.
- storage/indexeddb/modern/transaction-scheduler-1-private.html: Added.
- storage/indexeddb/modern/transaction-scheduler-2-private-expected.txt: Added.
- storage/indexeddb/modern/transaction-scheduler-2-private.html: Added.
- storage/indexeddb/modern/transaction-scheduler-3-private-expected.txt: Added.
- storage/indexeddb/modern/transaction-scheduler-3-private.html: Added.
- storage/indexeddb/modern/transaction-scheduler-4-private-expected.txt: Added.
- storage/indexeddb/modern/transaction-scheduler-4-private.html: Added.
- storage/indexeddb/modern/transaction-scheduler-5-private-expected.txt: Added.
- storage/indexeddb/modern/transaction-scheduler-5-private.html: Added.
- storage/indexeddb/modern/transaction-scheduler-6-private-expected.txt: Added.
- storage/indexeddb/modern/transaction-scheduler-6-private.html: Added.
- storage/indexeddb/modern/transactions-stop-on-navigation-private-expected.txt: Added.
- storage/indexeddb/modern/transactions-stop-on-navigation-private.html: Added.
- storage/indexeddb/modern/versionchange-abort-then-reopen-private-expected.txt: Added.
- storage/indexeddb/modern/versionchange-abort-then-reopen-private.html: Added.
- storage/indexeddb/modern/versionchange-event-private-expected.txt: Added.
- storage/indexeddb/modern/versionchange-event-private.html: Added.
- storage/indexeddb/mozilla/add-twice-failure-private-expected.txt: Added.
- storage/indexeddb/mozilla/add-twice-failure-private.html: Added.
- storage/indexeddb/mozilla/autoincrement-indexes-private-expected.txt: Added.
- storage/indexeddb/mozilla/autoincrement-indexes-private.html: Added.
- storage/indexeddb/mozilla/bad-keypath-private-expected.txt: Added.
- storage/indexeddb/mozilla/bad-keypath-private.html: Added.
- storage/indexeddb/mozilla/clear-private-expected.txt: Added.
- storage/indexeddb/mozilla/clear-private.html: Added.
- storage/indexeddb/mozilla/create-index-unique-private-expected.txt: Added.
- storage/indexeddb/mozilla/create-index-unique-private.html: Added.
- storage/indexeddb/mozilla/create-index-with-integer-keys-private-expected.txt: Added.
- storage/indexeddb/mozilla/create-index-with-integer-keys-private.html: Added.
- storage/indexeddb/mozilla/create-objectstore-basics-private-expected.txt: Added.
- storage/indexeddb/mozilla/create-objectstore-basics-private.html: Added.
- storage/indexeddb/mozilla/create-objectstore-null-name-private-expected.txt: Added.
- storage/indexeddb/mozilla/create-objectstore-null-name-private.html: Added.
- storage/indexeddb/mozilla/cursor-mutation-objectstore-only-private-expected.txt: Added.
- storage/indexeddb/mozilla/cursor-mutation-objectstore-only-private.html: Added.
- storage/indexeddb/mozilla/cursor-mutation-private-expected.txt: Added.
- storage/indexeddb/mozilla/cursor-mutation-private.html: Added.
- storage/indexeddb/mozilla/cursor-update-updates-indexes-private-expected.txt: Added.
- storage/indexeddb/mozilla/cursor-update-updates-indexes-private.html: Added.
- storage/indexeddb/mozilla/cursors-private-expected.txt: Added.
- storage/indexeddb/mozilla/cursors-private.html: Added.
- storage/indexeddb/mozilla/delete-result-private-expected.txt: Added.
- storage/indexeddb/mozilla/delete-result-private.html: Added.
- storage/indexeddb/mozilla/event-source-private-expected.txt: Added.
- storage/indexeddb/mozilla/event-source-private.html: Added.
- storage/indexeddb/mozilla/global-data-private-expected.txt: Added.
- storage/indexeddb/mozilla/global-data-private.html: Added.
- storage/indexeddb/mozilla/index-prev-no-duplicate-private-expected.txt: Added.
- storage/indexeddb/mozilla/index-prev-no-duplicate-private.html: Added.
- storage/indexeddb/mozilla/indexes-private-expected.txt: Added.
- storage/indexeddb/mozilla/indexes-private.html: Added.
- storage/indexeddb/mozilla/key-requirements-delete-null-key-private-expected.txt: Added.
- storage/indexeddb/mozilla/key-requirements-delete-null-key-private.html: Added.
- storage/indexeddb/mozilla/key-requirements-inline-and-passed-private-expected.txt: Added.
- storage/indexeddb/mozilla/key-requirements-inline-and-passed-private.html: Added.
- storage/indexeddb/mozilla/key-requirements-private-expected.txt: Added.
- storage/indexeddb/mozilla/key-requirements-private.html: Added.
- storage/indexeddb/mozilla/key-requirements-put-no-key-private-expected.txt: Added.
- storage/indexeddb/mozilla/key-requirements-put-no-key-private.html: Added.
- storage/indexeddb/mozilla/key-requirements-put-null-key-private-expected.txt: Added.
- storage/indexeddb/mozilla/key-requirements-put-null-key-private.html: Added.
- storage/indexeddb/mozilla/object-cursors-private-expected.txt: Added.
- storage/indexeddb/mozilla/object-cursors-private.html: Added.
- storage/indexeddb/mozilla/object-identity-private-expected.txt: Added.
- storage/indexeddb/mozilla/object-identity-private.html: Added.
- storage/indexeddb/mozilla/object-store-inline-autoincrement-key-added-on-put-private-expected.txt: Added.
- storage/indexeddb/mozilla/object-store-inline-autoincrement-key-added-on-put-private.html: Added.
- storage/indexeddb/mozilla/object-store-remove-values-private-expected.txt: Added.
- storage/indexeddb/mozilla/object-store-remove-values-private.html: Added.
- storage/indexeddb/mozilla/objectstorenames-private-expected.txt: Added.
- storage/indexeddb/mozilla/objectstorenames-private.html: Added.
- storage/indexeddb/mozilla/odd-result-order-private-expected.txt: Added.
- storage/indexeddb/mozilla/odd-result-order-private.html: Added.
- storage/indexeddb/mozilla/open-database-null-name-private-expected.txt: Added.
- storage/indexeddb/mozilla/open-database-null-name-private.html: Added.
- storage/indexeddb/mozilla/put-get-values-private-expected.txt: Added.
- storage/indexeddb/mozilla/put-get-values-private.html: Added.
- storage/indexeddb/mozilla/readonly-transactions-private-expected.txt: Added.
- storage/indexeddb/mozilla/readonly-transactions-private.html: Added.
- storage/indexeddb/mozilla/readwrite-transactions-private-expected.txt: Added.
- storage/indexeddb/mozilla/readwrite-transactions-private.html: Added.
- storage/indexeddb/mozilla/readyState-private-expected.txt: Added.
- storage/indexeddb/mozilla/readyState-private.html: Added.
- storage/indexeddb/mozilla/remove-index-private-expected.txt: Added.
- storage/indexeddb/mozilla/remove-index-private.html: Added.
- storage/indexeddb/mozilla/remove-objectstore-private-expected.txt: Added.
- storage/indexeddb/mozilla/remove-objectstore-private.html: Added.
- storage/indexeddb/mozilla/versionchange-abort-private-expected.txt: Added.
- storage/indexeddb/mozilla/versionchange-abort-private.html: Added.
- storage/indexeddb/noblobs-private-expected.txt: Added.
- storage/indexeddb/noblobs-private.html: Added.
- storage/indexeddb/object-lookups-in-versionchange-private-expected.txt: Added.
- storage/indexeddb/object-lookups-in-versionchange-private.html: Added.
- storage/indexeddb/open-bad-versions-private-expected.txt: Added.
- storage/indexeddb/open-bad-versions-private.html: Added.
- storage/indexeddb/optional-arguments-private-expected.txt: Added.
- storage/indexeddb/optional-arguments-private.html: Added.
- storage/indexeddb/pending-version-change-stuck-works-with-terminate-private-expected.txt: Added.
- storage/indexeddb/pending-version-change-stuck-works-with-terminate-private.html: Added.
- storage/indexeddb/prefetch-invalidation-private-expected.txt: Added.
- storage/indexeddb/prefetch-invalidation-private.html: Added.
- storage/indexeddb/prefetch-race-private-expected.txt: Added.
- storage/indexeddb/prefetch-race-private.html: Added.
- storage/indexeddb/primary-key-unique-to-objectstore-private-expected.txt: Added.
- storage/indexeddb/primary-key-unique-to-objectstore-private.html: Added.
- storage/indexeddb/request-leak-private-expected.txt: Added.
- storage/indexeddb/request-leak-private.html: Added.
- storage/indexeddb/request-result-cache-private-expected.txt: Added.
- storage/indexeddb/request-result-cache-private.html: Added.
- storage/indexeddb/resources/primary-key-unique-to-objectstore.js:
- storage/indexeddb/resources/shared.js:
- storage/indexeddb/resources/version-change-event-basic.js:
- storage/indexeddb/structured-clone-private-expected.txt: Added.
- storage/indexeddb/structured-clone-private.html: Added.
- storage/indexeddb/transaction-complete-with-js-recursion-cross-frame-private-expected.txt: Added.
- storage/indexeddb/transaction-complete-with-js-recursion-cross-frame-private.html: Added.
- storage/indexeddb/transaction-complete-with-js-recursion-private-expected.txt: Added.
- storage/indexeddb/transaction-complete-with-js-recursion-private.html: Added.
- storage/indexeddb/transaction-crash-in-tasks-private-expected.txt: Added.
- storage/indexeddb/transaction-crash-in-tasks-private.html: Added.
- storage/indexeddb/transaction-ordering-private-expected.txt: Added.
- storage/indexeddb/transaction-ordering-private.html: Added.
- storage/indexeddb/transaction-overlapping-private-expected.txt: Added.
- storage/indexeddb/transaction-overlapping-private.html: Added.
- storage/indexeddb/transaction-starvation-private-expected.txt: Removed.
- storage/indexeddb/version-change-event-basic-private-expected.txt: Added.
- storage/indexeddb/version-change-event-basic-private.html: Added.
- storage/indexeddb/version-change-event-private-expected.txt: Added.
- storage/indexeddb/version-change-event-private.html: Added.
- 5:49 PM Changeset in webkit [195393] by
-
- 2 edits in trunk/Source/WebCore
ResourceHandleCFURLConnectionDelegateWithOperationQueue delegate methods don't NULL-check m_handle->client()
<https://webkit.org/b/152675>
<rdar://problem/24034044>
Reviewed by Brent Fulgham.
- platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.cpp:
(WebCore::ResourceHandleCFURLConnectionDelegateWithOperationQueue::didReceiveResponse):
(WebCore::ResourceHandleCFURLConnectionDelegateWithOperationQueue::didReceiveData):
(WebCore::ResourceHandleCFURLConnectionDelegateWithOperationQueue::didFinishLoading):
(WebCore::ResourceHandleCFURLConnectionDelegateWithOperationQueue::didFail):
(WebCore::ResourceHandleCFURLConnectionDelegateWithOperationQueue::willCacheResponse):
(WebCore::ResourceHandleCFURLConnectionDelegateWithOperationQueue::didSendBodyData):
(WebCore::ResourceHandleCFURLConnectionDelegateWithOperationQueue::didReceiveDataArray):
- Add NULL check for m_handle->client() as is done in the WebCoreResourceHandleAsOperationQueueDelegate class in WebCoreResourceHandleAsOperationQueueDelegate.mm. (The NULL check for -connection:didReceiveResponse: is currently missing, but there are crashes there, too, that are covered by Bug 152673.)
- 4:41 PM Changeset in webkit [195392] by
-
- 2 edits in trunk/Source/WebCore
Use TinyLRUCache in caching the CGColorRef in WebCore::cachedCGColor()
https://bugs.webkit.org/show_bug.cgi?id=153279
Patch by Said Abou-Hallawa <sabouhallawa@apple.com> on 2016-01-20
Reviewed by Dean Jackson.
Reuse the new template TinyLRUCache in caching the CGColor instead of
having the same code repeated twice.
- platform/graphics/cg/ColorCG.cpp:
(WebCore::leakCGColor):
(WebCore::RetainPtr<CGColorRef>>::createValueForKey):
(WebCore::cachedCGColor):
- 4:20 PM Changeset in webkit [195391] by
-
- 3 edits in trunk/Tools
Refactor compareIterations to remove duplicate code.
https://bugs.webkit.org/show_bug.cgi?id=152913
Reviewed by Daniel Bates.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
(BuildbotQueue.prototype.compareIterations): Refactored to remove duplicate code.
(BuildbotQueue.prototype.sortIterations): Add binding to call to compareIterations.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js: Added tests in order to ensure
the same behavior before and after refactor.
- 3:40 PM Changeset in webkit [195390] by
-
- 6 edits in trunk/LayoutTests
Update ios-simulator specific -expected.txt files after most recent WPT revision in r194580
https://bugs.webkit.org/show_bug.cgi?id=152139
Unreviewed test gardening.
- platform/ios-simulator/imported/w3c/web-platform-tests/html/semantics/forms/constraints/form-validation-checkValidity-expected.txt:
- platform/ios-simulator/imported/w3c/web-platform-tests/html/semantics/forms/constraints/form-validation-validity-valid-expected.txt:
- platform/ios-simulator/imported/w3c/web-platform-tests/html/semantics/forms/constraints/form-validation-validity-valueMissing-expected.txt:
- platform/ios-simulator/imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/input-textselection-01-expected.txt:
- platform/ios-simulator/imported/w3c/web-platform-tests/html/semantics/forms/the-label-element/labelable-elements-expected.txt:
- 3:38 PM Changeset in webkit [195389] by
-
- 8 edits in tags/Safari-602.1.17
Roll out r195178. rdar://problem/24265144
- 3:25 PM Changeset in webkit [195388] by
-
- 2 edits in trunk/Source/JavaScriptCore
[JSC] Fix a typo in the Air definition of CeilDouble/CeilFloat
https://bugs.webkit.org/show_bug.cgi?id=153286
Patch by Benjamin Poulain <bpoulain@apple.com> on 2016-01-20
Reviewed by Mark Lam.
- b3/air/AirOpcode.opcodes:
The second argument should a Def. The previous definition was
adding useless constraints on the allocation of the second argument.
- 3:11 PM Changeset in webkit [195387] by
-
- 3 edits in trunk/Source/JavaScriptCore
[JSC] The register allocator can use a dangling pointer when selecting a spill candidate
https://bugs.webkit.org/show_bug.cgi?id=153287
Reviewed by Mark Lam.
A tricky bug I discovered while experimenting with live range breaking.
We have the following initial conditions:
-UseCounts is slow, so we only compute it once for all the iterations
of the allocator.
-The only new Tmps we create are for spills and refills. They are unspillable
by definition so it is fine to not update UseCounts accordingly.
But, in selectSpill(), we go over all the spill candidates and select the best
one based on its score. The score() lambda uses useCounts, it cannot be used
with a new Tmps created for something we already spilled.
The first time we use score is correct, we started by skipping all the unspillable
Tmps from the candidate. The next use was incorrect: we were checking unspillableTmps
*after* calling score().
The existing tests did not catch this due to back luck. I added an assertion
to find similar problems in the future.
- b3/air/AirIteratedRegisterCoalescing.cpp:
- b3/air/AirUseCounts.h:
- 3:00 PM Changeset in webkit [195386] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: InspectorCSSAgent does not call disable in willDestroyFrontendAndBackend
https://bugs.webkit.org/show_bug.cgi?id=153289
<rdar://problem/24242600>
Reviewed by Joseph Pecoraro.
- inspector/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::willDestroyFrontendAndBackend): Call disable().
- 2:57 PM Changeset in webkit [195385] by
-
- 2 edits in branches/safari-601.1.46-branch/Source/WebCore
<rdar://problem/24242600> CrashTracer: com.apple.WebKit.WebContent at …pector::CSSFrontendDispatcher::mediaQueryResultChanged + 316
Reviewed by Joseph Pecoraro.
- inspector/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::willDestroyFrontendAndBackend): Call disable().
(WebCore::InspectorCSSAgent::mediaQueryResultChanged): Add null check.
- 2:55 PM Changeset in webkit [195384] by
-
- 2 edits in branches/safari-601-branch/Source/WebCore
<rdar://problem/24242600> CrashTracer: com.apple.WebKit.WebContent at …pector::CSSFrontendDispatcher::mediaQueryResultChanged + 316
Reviewed by Joseph Pecoraro.
- inspector/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::willDestroyFrontendAndBackend): Call disable().
(WebCore::InspectorCSSAgent::mediaQueryResultChanged): Add null check.
- 2:55 PM Changeset in webkit [195383] by
-
- 2 edits in trunk/Source/JavaScriptCore
Fix CLoop build after bug https://bugs.webkit.org/show_bug.cgi?id=152766
Unreviewed build fix.
- inspector/agents/InspectorScriptProfilerAgent.h:
- 2:54 PM Changeset in webkit [195382] by
-
- 3 edits in trunk/LayoutTests
Follow up to r195361. Removing ios-simulator-wk2 fast/viewport/ios directory pass expectation, explicitly re-enabling passing tests
https://bugs.webkit.org/show_bug.cgi?id=153110
Unreviewed test gardening.
- platform/ios-simulator-wk2/TestExpectations:
- platform/ios-simulator/TestExpectations:
- 2:49 PM Changeset in webkit [195381] by
-
- 6 edits in trunk
[INTL] Implement Date.prototype.toLocaleTimeString in ECMA-402
https://bugs.webkit.org/show_bug.cgi?id=147613
Patch by Andy VanWagoner <thetalecrafter@gmail.com> on 2016-01-20
Reviewed by Darin Adler.
Source/JavaScriptCore:
Implement toLocaleTimeString in builtin JavaScript.
- builtins/DatePrototype.js:
(toLocaleTimeString.toDateTimeOptionsTimeTime):
(toLocaleTimeString):
- runtime/DatePrototype.cpp:
(JSC::DatePrototype::finishCreation):
LayoutTests:
Added tests for toLocaleTimeString.
- js/date-toLocaleString-expected.txt:
- js/script-tests/date-toLocaleString.js:
- 2:27 PM Changeset in webkit [195380] by
-
- 132 edits in trunk/LayoutTests
Modern IDB: Make storage/indexeddb/modern tests more modern.
https://bugs.webkit.org/show_bug.cgi?id=153284
Reviewed by Alex Christensen.
- storage/indexeddb/modern/abort-requests-cancelled-expected.txt:
- storage/indexeddb/modern/aborted-put-expected.txt:
- storage/indexeddb/modern/autoincrement-abort-expected.txt:
- storage/indexeddb/modern/basic-add-expected.txt:
- storage/indexeddb/modern/basic-put-expected.txt:
- storage/indexeddb/modern/create-index-failures-expected.txt:
- storage/indexeddb/modern/createobjectstore-basic-expected.txt:
- storage/indexeddb/modern/createobjectstore-failures-expected.txt:
- storage/indexeddb/modern/cursor-1-expected.txt:
- storage/indexeddb/modern/cursor-2-expected.txt:
- storage/indexeddb/modern/cursor-3-expected.txt:
- storage/indexeddb/modern/cursor-4-expected.txt:
- storage/indexeddb/modern/cursor-5-expected.txt:
- storage/indexeddb/modern/cursor-6-expected.txt:
- storage/indexeddb/modern/cursor-7-expected.txt:
- storage/indexeddb/modern/cursor-8-expected.txt:
- storage/indexeddb/modern/date-basic-expected.txt:
- storage/indexeddb/modern/deletedatabase-1-expected.txt:
- storage/indexeddb/modern/deletedatabase-2-expected.txt:
- storage/indexeddb/modern/deleteindex-1-expected.txt:
- storage/indexeddb/modern/deleteindex-2-expected.txt:
- storage/indexeddb/modern/deleteobjectstore-1-expected.txt:
- storage/indexeddb/modern/double-abort-expected.txt:
- storage/indexeddb/modern/get-index-failures-expected.txt:
- storage/indexeddb/modern/get-keyrange-expected.txt:
- storage/indexeddb/modern/idbdatabase-deleteobjectstore-failures-expected.txt:
- storage/indexeddb/modern/idbdatabase-transaction-failures-expected.txt:
- storage/indexeddb/modern/idbindex-properties-basic-expected.txt:
- storage/indexeddb/modern/idbobjectstore-clear-1-expected.txt:
- storage/indexeddb/modern/idbobjectstore-clear-2-expected.txt:
- storage/indexeddb/modern/idbobjectstore-count-1-expected.txt:
- storage/indexeddb/modern/idbobjectstore-count-failures-expected.txt:
- storage/indexeddb/modern/idbobjectstore-delete-1-expected.txt:
- storage/indexeddb/modern/idbobjectstore-delete-2-expected.txt:
- storage/indexeddb/modern/idbobjectstore-delete-failures-expected.txt:
- storage/indexeddb/modern/idbobjectstore-get-failures-expected.txt:
- storage/indexeddb/modern/idbobjectstore-put-and-clear-failures-expected.txt:
- storage/indexeddb/modern/idbtransaction-objectstore-failures-expected.txt:
- storage/indexeddb/modern/index-1-expected.txt:
- storage/indexeddb/modern/index-2-expected.txt:
- storage/indexeddb/modern/index-3-expected.txt:
- storage/indexeddb/modern/index-4-expected.txt:
- storage/indexeddb/modern/index-5-expected.txt:
- storage/indexeddb/modern/index-cursor-1-expected.txt:
- storage/indexeddb/modern/index-cursor-2-expected.txt:
- storage/indexeddb/modern/index-cursor-3-expected.txt:
- storage/indexeddb/modern/index-get-count-basic-expected.txt:
- storage/indexeddb/modern/index-get-count-failures-expected.txt:
- storage/indexeddb/modern/keypath-basic-expected.txt:
- storage/indexeddb/modern/objectstore-attributes-expected.txt:
- storage/indexeddb/modern/objectstore-cursor-advance-failures-expected.txt:
- storage/indexeddb/modern/objectstore-cursor-continue-failures-expected.txt:
- storage/indexeddb/modern/opencursor-failures-expected.txt:
- storage/indexeddb/modern/opendatabase-success-after-versionchange-expected.txt:
- storage/indexeddb/modern/opendatabase-versions-expected.txt:
- storage/indexeddb/modern/resources/abort-requests-cancelled.js:
- storage/indexeddb/modern/resources/aborted-put.js:
- storage/indexeddb/modern/resources/autoincrement-abort.js:
- storage/indexeddb/modern/resources/basic-add.js:
- storage/indexeddb/modern/resources/basic-put.js:
- storage/indexeddb/modern/resources/create-index-failures.js:
- storage/indexeddb/modern/resources/createobjectstore-basic.js:
- storage/indexeddb/modern/resources/createobjectstore-failures.js:
- storage/indexeddb/modern/resources/cursor-1.js:
- storage/indexeddb/modern/resources/cursor-2.js:
- storage/indexeddb/modern/resources/cursor-3.js:
- storage/indexeddb/modern/resources/cursor-4.js:
- storage/indexeddb/modern/resources/cursor-5.js:
- storage/indexeddb/modern/resources/cursor-6.js:
- storage/indexeddb/modern/resources/cursor-7.js:
- storage/indexeddb/modern/resources/cursor-8.js:
- storage/indexeddb/modern/resources/date-basic.js:
- storage/indexeddb/modern/resources/deletedatabase-1.js:
- storage/indexeddb/modern/resources/deletedatabase-2.js:
- storage/indexeddb/modern/resources/deletedatabase-null-name-exception.js:
- storage/indexeddb/modern/resources/deletedatabase-request-event.js:
- storage/indexeddb/modern/resources/deletedatabase-request.js:
- storage/indexeddb/modern/resources/deleteindex-1.js:
- storage/indexeddb/modern/resources/deleteindex-2.js:
- storage/indexeddb/modern/resources/deleteobjectstore-1.js:
- storage/indexeddb/modern/resources/double-abort.js:
- storage/indexeddb/modern/resources/double-open.js:
- storage/indexeddb/modern/resources/get-index-failures.js:
- storage/indexeddb/modern/resources/get-keyrange.js:
- storage/indexeddb/modern/resources/idbdatabase-deleteobjectstore-failures.js:
- storage/indexeddb/modern/resources/idbdatabase-transaction-failures.js:
- storage/indexeddb/modern/resources/idbindex-properties-basic.js:
- storage/indexeddb/modern/resources/idbobjectstore-clear-1.js:
- storage/indexeddb/modern/resources/idbobjectstore-clear-2.js:
- storage/indexeddb/modern/resources/idbobjectstore-count-1.js:
- storage/indexeddb/modern/resources/idbobjectstore-count-failures.js:
- storage/indexeddb/modern/resources/idbobjectstore-delete-1.js:
- storage/indexeddb/modern/resources/idbobjectstore-delete-2.js:
- storage/indexeddb/modern/resources/idbobjectstore-delete-failures.js:
- storage/indexeddb/modern/resources/idbobjectstore-get-failures.js:
- storage/indexeddb/modern/resources/idbobjectstore-put-and-clear-failures.js:
- storage/indexeddb/modern/resources/idbtransaction-objectstore-failures.js:
- storage/indexeddb/modern/resources/index-1.js:
- storage/indexeddb/modern/resources/index-2.js:
- storage/indexeddb/modern/resources/index-3.js:
- storage/indexeddb/modern/resources/index-4.js:
- storage/indexeddb/modern/resources/index-5.js:
- storage/indexeddb/modern/resources/index-cursor-1.js:
- storage/indexeddb/modern/resources/index-cursor-2.js:
- storage/indexeddb/modern/resources/index-cursor-3.js:
- storage/indexeddb/modern/resources/index-get-count-basic.js:
- storage/indexeddb/modern/resources/index-get-count-failures.js:
- storage/indexeddb/modern/resources/keypath-basic.js:
- storage/indexeddb/modern/resources/objectstore-attributes.js:
- storage/indexeddb/modern/resources/objectstore-cursor-advance-failures.js:
- storage/indexeddb/modern/resources/objectstore-cursor-continue-failures.js:
- storage/indexeddb/modern/resources/opencursor-failures.js:
- storage/indexeddb/modern/resources/opendatabase-request-event.js:
- storage/indexeddb/modern/resources/opendatabase-request.js:
- storage/indexeddb/modern/resources/opendatabase-success-after-versionchange.js:
- storage/indexeddb/modern/resources/opendatabase-versions.js:
- storage/indexeddb/modern/resources/request-readystate.js:
- storage/indexeddb/modern/resources/transaction-scheduler-1.js:
- storage/indexeddb/modern/resources/transaction-scheduler-2.js:
- storage/indexeddb/modern/resources/transaction-scheduler-3.js:
- storage/indexeddb/modern/resources/transaction-scheduler-5.js:
- storage/indexeddb/modern/resources/transaction-scheduler-6.js:
- storage/indexeddb/modern/resources/versionchange-abort-then-reopen.js:
- storage/indexeddb/modern/resources/versionchange-event.js:
- storage/indexeddb/modern/transaction-scheduler-1-expected.txt:
- storage/indexeddb/modern/transaction-scheduler-2-expected.txt:
- storage/indexeddb/modern/transaction-scheduler-3-expected.txt:
- storage/indexeddb/modern/transaction-scheduler-5-expected.txt:
- storage/indexeddb/modern/transaction-scheduler-6-expected.txt:
- storage/indexeddb/modern/versionchange-abort-then-reopen-expected.txt:
- storage/indexeddb/modern/versionchange-event-expected.txt:
- 2:18 PM Changeset in webkit [195379] by
-
- 9 edits in branches/safari-601-branch/Source
- 2:18 PM Changeset in webkit [195378] by
-
- 44 edits4 deletes in branches/safari-601-branch
- 2:18 PM Changeset in webkit [195377] by
-
- 15 edits2 deletes in branches/safari-601-branch
- 1:51 PM Changeset in webkit [195376] by
-
- 30 edits12 adds in trunk
Web Inspector: Hook the sampling profiler into the Timelines UI
https://bugs.webkit.org/show_bug.cgi?id=152766
<rdar://problem/24066360>
Reviewed by Joseph Pecoraro.
Source/JavaScriptCore:
This patch adds some necessary functions to SamplingProfiler::StackFrame
to allow it to give data to the Inspector for the timelines UI. i.e, the
sourceID of the executable of a stack frame.
This patch also swaps in the SamplingProfiler in place of the
LegacyProfiler inside InspectorScriptProfilerAgent. It adds
the necessary protocol data to allow the SamplingProfiler's
data to hook into the timelines UI.
- debugger/Debugger.cpp:
(JSC::Debugger::setProfilingClient):
(JSC::Debugger::willEvaluateScript):
(JSC::Debugger::didEvaluateScript):
(JSC::Debugger::toggleBreakpoint):
- debugger/Debugger.h:
- debugger/ScriptProfilingScope.h:
(JSC::ScriptProfilingScope::ScriptProfilingScope):
(JSC::ScriptProfilingScope::~ScriptProfilingScope):
- inspector/agents/InspectorScriptProfilerAgent.cpp:
(Inspector::InspectorScriptProfilerAgent::willDestroyFrontendAndBackend):
(Inspector::InspectorScriptProfilerAgent::startTracking):
(Inspector::InspectorScriptProfilerAgent::stopTracking):
(Inspector::InspectorScriptProfilerAgent::isAlreadyProfiling):
(Inspector::InspectorScriptProfilerAgent::willEvaluateScript):
(Inspector::InspectorScriptProfilerAgent::didEvaluateScript):
(Inspector::InspectorScriptProfilerAgent::addEvent):
(Inspector::buildSamples):
(Inspector::InspectorScriptProfilerAgent::trackingComplete):
(Inspector::buildAggregateCallInfoInspectorObject): Deleted.
(Inspector::buildInspectorObject): Deleted.
(Inspector::buildProfileInspectorObject): Deleted.
- inspector/agents/InspectorScriptProfilerAgent.h:
- inspector/protocol/ScriptProfiler.json:
- jsc.cpp:
(functionSamplingProfilerStackTraces):
- runtime/SamplingProfiler.cpp:
(JSC::SamplingProfiler::start):
(JSC::SamplingProfiler::stop):
(JSC::SamplingProfiler::clearData):
(JSC::SamplingProfiler::StackFrame::displayName):
(JSC::SamplingProfiler::StackFrame::displayNameForJSONTests):
(JSC::SamplingProfiler::StackFrame::startLine):
(JSC::SamplingProfiler::StackFrame::startColumn):
(JSC::SamplingProfiler::StackFrame::sourceID):
(JSC::SamplingProfiler::StackFrame::url):
(JSC::SamplingProfiler::stackTraces):
(JSC::SamplingProfiler::stackTracesAsJSON):
(JSC::displayName): Deleted.
(JSC::SamplingProfiler::stacktracesAsJSON): Deleted.
- runtime/SamplingProfiler.h:
(JSC::SamplingProfiler::StackFrame::StackFrame):
(JSC::SamplingProfiler::getLock):
(JSC::SamplingProfiler::setTimingInterval):
(JSC::SamplingProfiler::totalTime):
(JSC::SamplingProfiler::setStopWatch):
(JSC::SamplingProfiler::stackTraces): Deleted.
- tests/stress/sampling-profiler-anonymous-function.js:
(platformSupportsSamplingProfiler.baz):
(platformSupportsSamplingProfiler):
- tests/stress/sampling-profiler-basic.js:
(platformSupportsSamplingProfiler.nothing):
(platformSupportsSamplingProfiler.top):
- tests/stress/sampling-profiler/samplingProfiler.js:
(doesTreeHaveStackTrace):
Source/WebInspectorUI:
The main change in this patch is to swap in the SamplingProfiler
in place of the LegacyProfiler. To do this, we've created a data
structure called CallingContextTree which aggregates the SamplingProfiler's
data into an easy to manage tree. To see how the data structure works,
consider the following program:
`
function bar() { run code here for a long time. }
function baz() { run code here for a long time. }
function foo() { bar(); baz(); }
foo();
`
From this program, we will create a tree like this:
(program)
|
|
foo
| |
/ \
/ \
bar baz
From this type of tree, we can easily create a CPUProfile payload
object. Because the Timelines UI knows how to interact with the
CPUProfile object and display it, we currently map the tree to this object
to make it trivially easy to display the SamplingProfiler's data. In the future,
we may want to find ways to work directly with the CallingContextTree instead
of mapping it into another object.
- Localizations/en.lproj/localizedStrings.js:
- UserInterface/Controllers/TimelineManager.js:
- UserInterface/Main.html:
- UserInterface/Models/CallingContextTree.js: Added.
- UserInterface/Models/ScriptInstrument.js:
- UserInterface/Protocol/ScriptProfilerObserver.js:
- UserInterface/TestStub.html:
- UserInterface/Views/ScriptTimelineView.js:
LayoutTests:
- inspector/sampling-profiler: Added.
- inspector/sampling-profiler/basic-expected.txt: Added.
- inspector/sampling-profiler/basic.html: Added.
- inspector/sampling-profiler/call-frame-with-dom-functions-expected.txt: Added.
- inspector/sampling-profiler/call-frame-with-dom-functions.html: Added.
- inspector/sampling-profiler/eval-source-url-expected.txt: Added.
- inspector/sampling-profiler/eval-source-url.html: Added.
- inspector/sampling-profiler/many-call-frames-expected.txt: Added.
- inspector/sampling-profiler/many-call-frames.html: Added.
- inspector/sampling-profiler/named-function-expression-expected.txt: Added.
- inspector/sampling-profiler/named-function-expression.html: Added.
- inspector/script-profiler/event-type-API-expected.txt:
- inspector/script-profiler/event-type-API.html:
- inspector/script-profiler/event-type-Microtask-expected.txt:
- inspector/script-profiler/event-type-Microtask.html:
- inspector/script-profiler/event-type-Other-expected.txt:
- inspector/script-profiler/event-type-Other.html:
- inspector/script-profiler/tracking-expected.txt:
- inspector/script-profiler/tracking.html:
- 1:49 PM Changeset in webkit [195375] by
-
- 2 edits1 add in trunk/Source/JavaScriptCore
TypedArray's .buffer does not return the JSArrayBuffer that was passed to it on creation.
https://bugs.webkit.org/show_bug.cgi?id=153281
Reviewed by Geoffrey Garen.
When creating an JSArrayBuffer we should make sure that the backing ArrayBuffer uses the
new JSArrayBuffer as its wrapper. This causes issues when we get the buffer of a Typed Array
created by passing a JSArrayBuffer as the backing ArrayBuffer does not have a reference to
the original JSArrayBuffer and a new object is created.
- runtime/JSArrayBuffer.cpp:
(JSC::JSArrayBuffer::finishCreation):
- tests/stress/typedarray-buffer-neutered.js: Added.
(arrays.typedArrays.map):
- 1:32 PM Changeset in webkit [195374] by
-
- 1 edit4 adds in trunk/LayoutTests
CSP: Add tests to ensure that alternative text of an image is rendered when CSP blocks its load
https://bugs.webkit.org/show_bug.cgi?id=153280
Reviewed by Alexey Proskuryakov.
These tests were inspired by the Blink test
<https://src.chromium.org/viewvc/blink/trunk/LayoutTests/http/tests/security/contentSecurityPolicy/image-blocked-alt-content.html?revision=186800>.
- http/tests/security/contentSecurityPolicy/image-blocked-alt-text-expected.html: Added.
- http/tests/security/contentSecurityPolicy/image-blocked-alt-text.html: Added.
- http/tests/security/contentSecurityPolicy/image-data-URL-blocked-alt-text-expected.html: Added.
- http/tests/security/contentSecurityPolicy/image-data-URL-blocked-alt-text.html: Added.
- 1:00 PM Changeset in webkit [195373] by
-
- 1 edit2 adds in branches/safari-601.1.46-branch/LayoutTests
Merge r195158. rdar://problem/24208157
- 1:00 PM Changeset in webkit [195372] by
-
- 2 edits in branches/safari-601.1.46-branch/LayoutTests
Merge r195089. rdar://problem/24101168
- 1:00 PM Changeset in webkit [195371] by
-
- 5 edits3 adds in branches/safari-601.1.46-branch
Merge r195088. rdar://problem/24101168
- 12:59 PM Changeset in webkit [195370] by
-
- 5 edits in branches/safari-601.1.46-branch/Source
Merge r195082. rdar://problem/23633319
- 12:59 PM Changeset in webkit [195369] by
-
- 3 edits in branches/safari-601.1.46-branch
Merge r188377. rdar://problem/24208161
- 12:59 PM Changeset in webkit [195368] by
-
- 6 edits in branches/safari-601.1.46-branch
Merge r188263. rdar://problem/24208161
- 12:59 PM Changeset in webkit [195367] by
-
- 46 edits2 copies273 adds in trunk/LayoutTests
CSP: Merge from Blink many new tests and changes to existing tests
https://bugs.webkit.org/show_bug.cgi?id=153277
<rdar://problem/24260782>
Reviewed by Brent Fulgham.
Merge new Content Security Policy tests from Blink as well as changes made to existing tests
as of Blink r202656: <https://src.chromium.org/viewvc/blink/trunk/LayoutTests/http/tests/security/contentSecurityPolicy/?pathrev=202656>.
Many of these new tests fail and have been marked accordingly with associated WebKit bugs in
TestExpectations. We also do not run CSP 1.1 tests as we do not compile with ENABLE(CSP_NEXT)
enabled (see <https://bugs.webkit.org/show_bug.cgi?id=85558>). We will look to enable CSP 1.1
and make all these merged tests pass in subsequent commits.
One non-mechanical change I made is that I removed the sub-test for shared workers when
merging http/tests/security/contentSecurityPolicy/worker-without-own-csp.html as WebKit does
not support shared workers. I also swapped the argument order in the call to assert_equals()
in the remaining sub-test so that the expected result, "xhr allowed", is the second argument (as
expected by assert_equals()) and hence the failure message would read well.
The tests http/tests/security/contentSecurityPolicy/1.1/frame-ancestors/frame-ancestors-overrides-xfo.html,
http/tests/security/contentSecurityPolicy/1.1/{script, style}hash-default-src.html do not have
expected results and are skipped for now. These tests do not have expected results because no
expected results were committed to Blink and it is not straightforward to generate the expected
result without reasoning about the test or compiling Blink. When it comes time to enable CSP 1.1
support we can generate the expected results and verify correctness.
- TestExpectations:
- http/tests/security/contentSecurityPolicy/1.1/child-src/frame-about-blank-allowed-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/1.1/child-src/frame-about-blank-allowed.html: Added.
- http/tests/security/contentSecurityPolicy/1.1/child-src/frame-allowed-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/1.1/child-src/frame-allowed.html: Added.
- http/tests/security/contentSecurityPolicy/1.1/child-src/frame-blocked-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/1.1/child-src/frame-blocked.html: Added.
- http/tests/security/contentSecurityPolicy/1.1/child-src/frame-redirect-blocked-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/1.1/child-src/frame-redirect-blocked.html: Added.
- http/tests/security/contentSecurityPolicy/1.1/child-src/worker-allowed-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/1.1/child-src/worker-allowed.html: Added.
- http/tests/security/contentSecurityPolicy/1.1/child-src/worker-blocked-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/1.1/child-src/worker-blocked.html: Added.
- http/tests/security/contentSecurityPolicy/1.1/child-src/worker-shared-allowed-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/1.1/child-src/worker-shared-allowed.html: Added.
- http/tests/security/contentSecurityPolicy/1.1/child-src/worker-shared-blocked-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/1.1/child-src/worker-shared-blocked.html: Added.
- http/tests/security/contentSecurityPolicy/1.1/frame-ancestors/frame-ancestors-nested-cross-in-cross-none-block-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/1.1/frame-ancestors/frame-ancestors-nested-cross-in-cross-none-block.html: Added.
- http/tests/security/contentSecurityPolicy/1.1/frame-ancestors/frame-ancestors-nested-cross-in-cross-self-block-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/1.1/frame-ancestors/frame-ancestors-nested-cross-in-cross-self-block.html: Added.
- http/tests/security/contentSecurityPolicy/1.1/frame-ancestors/frame-ancestors-nested-cross-in-cross-star-allow-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/1.1/frame-ancestors/frame-ancestors-nested-cross-in-cross-star-allow.html: Added.
- http/tests/security/contentSecurityPolicy/1.1/frame-ancestors/frame-ancestors-nested-cross-in-cross-url-allow-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/1.1/frame-ancestors/frame-ancestors-nested-cross-in-cross-url-allow.html: Added.
- http/tests/security/contentSecurityPolicy/1.1/frame-ancestors/frame-ancestors-nested-cross-in-cross-url-block-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/1.1/frame-ancestors/frame-ancestors-nested-cross-in-cross-url-block.html: Added.
- http/tests/security/contentSecurityPolicy/1.1/frame-ancestors/frame-ancestors-nested-cross-in-same-none-block-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/1.1/frame-ancestors/frame-ancestors-nested-cross-in-same-none-block.html: Added.
- http/tests/security/contentSecurityPolicy/1.1/frame-ancestors/frame-ancestors-nested-cross-in-same-self-block-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/1.1/frame-ancestors/frame-ancestors-nested-cross-in-same-self-block.html: Added.
- http/tests/security/contentSecurityPolicy/1.1/frame-ancestors/frame-ancestors-nested-cross-in-same-star-allow-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/1.1/frame-ancestors/frame-ancestors-nested-cross-in-same-star-allow.html: Added.
- http/tests/security/contentSecurityPolicy/1.1/frame-ancestors/frame-ancestors-nested-cross-in-same-url-allow-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/1.1/frame-ancestors/frame-ancestors-nested-cross-in-same-url-allow.html: Added.
- http/tests/security/contentSecurityPolicy/1.1/frame-ancestors/frame-ancestors-nested-cross-in-same-url-block-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/1.1/frame-ancestors/frame-ancestors-nested-cross-in-same-url-block.html: Added.
- http/tests/security/contentSecurityPolicy/1.1/frame-ancestors/frame-ancestors-nested-same-in-cross-none-block-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/1.1/frame-ancestors/frame-ancestors-nested-same-in-cross-none-block.html: Added.
- http/tests/security/contentSecurityPolicy/1.1/frame-ancestors/frame-ancestors-nested-same-in-cross-self-block-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/1.1/frame-ancestors/frame-ancestors-nested-same-in-cross-self-block.html: Added.
- http/tests/security/contentSecurityPolicy/1.1/frame-ancestors/frame-ancestors-nested-same-in-cross-star-allow-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/1.1/frame-ancestors/frame-ancestors-nested-same-in-cross-star-allow.html: Added.
- http/tests/security/contentSecurityPolicy/1.1/frame-ancestors/frame-ancestors-nested-same-in-cross-url-allow-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/1.1/frame-ancestors/frame-ancestors-nested-same-in-cross-url-allow.html: Added.
- http/tests/security/contentSecurityPolicy/1.1/frame-ancestors/frame-ancestors-nested-same-in-cross-url-block-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/1.1/frame-ancestors/frame-ancestors-nested-same-in-cross-url-block.html: Added.
- http/tests/security/contentSecurityPolicy/1.1/frame-ancestors/frame-ancestors-nested-same-in-same-none-block-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/1.1/frame-ancestors/frame-ancestors-nested-same-in-same-none-block.html: Added.
- http/tests/security/contentSecurityPolicy/1.1/frame-ancestors/frame-ancestors-nested-same-in-same-self-allow-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/1.1/frame-ancestors/frame-ancestors-nested-same-in-same-self-allow.html: Added.
- http/tests/security/contentSecurityPolicy/1.1/frame-ancestors/frame-ancestors-nested-same-in-same-star-allow-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/1.1/frame-ancestors/frame-ancestors-nested-same-in-same-star-allow.html: Added.
- http/tests/security/contentSecurityPolicy/1.1/frame-ancestors/frame-ancestors-nested-same-in-same-url-allow-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/1.1/frame-ancestors/frame-ancestors-nested-same-in-same-url-allow.html: Added.
- http/tests/security/contentSecurityPolicy/1.1/frame-ancestors/frame-ancestors-nested-same-in-same-url-block-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/1.1/frame-ancestors/frame-ancestors-nested-same-in-same-url-block.html: Added.
- http/tests/security/contentSecurityPolicy/1.1/frame-ancestors/frame-ancestors-none-block-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/1.1/frame-ancestors/frame-ancestors-none-block.html: Added.
- http/tests/security/contentSecurityPolicy/1.1/frame-ancestors/frame-ancestors-overrides-xfo.html: Added.
- http/tests/security/contentSecurityPolicy/1.1/frame-ancestors/frame-ancestors-protocolless-allow-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/1.1/frame-ancestors/frame-ancestors-protocolless-allow.html: Added.
- http/tests/security/contentSecurityPolicy/1.1/frame-ancestors/frame-ancestors-self-allow-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/1.1/frame-ancestors/frame-ancestors-self-allow.html: Added.
- http/tests/security/contentSecurityPolicy/1.1/frame-ancestors/frame-ancestors-self-block-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/1.1/frame-ancestors/frame-ancestors-self-block.html: Added.
- http/tests/security/contentSecurityPolicy/1.1/frame-ancestors/frame-ancestors-star-allow-crossorigin-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/1.1/frame-ancestors/frame-ancestors-star-allow-crossorigin.html: Added.
- http/tests/security/contentSecurityPolicy/1.1/frame-ancestors/frame-ancestors-star-allow-sameorigin-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/1.1/frame-ancestors/frame-ancestors-star-allow-sameorigin.html: Added.
- http/tests/security/contentSecurityPolicy/1.1/frame-ancestors/frame-ancestors-url-allow-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/1.1/frame-ancestors/frame-ancestors-url-allow.html: Added.
- http/tests/security/contentSecurityPolicy/1.1/frame-ancestors/frame-ancestors-url-block-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/1.1/frame-ancestors/frame-ancestors-url-block.html: Added.
- http/tests/security/contentSecurityPolicy/1.1/meta-outside-head-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/1.1/meta-outside-head.html: Added.
- http/tests/security/contentSecurityPolicy/1.1/plugintypes-affects-child-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/1.1/plugintypes-affects-child.html: Added.
- http/tests/security/contentSecurityPolicy/1.1/plugintypes-invalid.html:
- http/tests/security/contentSecurityPolicy/1.1/referrer-always-http-http-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/1.1/referrer-always-http-http.html: Added.
- http/tests/security/contentSecurityPolicy/1.1/referrer-always-http-https-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/1.1/referrer-always-http-https.html: Added.
- http/tests/security/contentSecurityPolicy/1.1/referrer-always-https-http-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/1.1/referrer-always-https-http.html: Added.
- http/tests/security/contentSecurityPolicy/1.1/referrer-always-https-https-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/1.1/referrer-always-https-https.html: Added.
- http/tests/security/contentSecurityPolicy/1.1/referrer-default-http-http-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/1.1/referrer-default-http-http.html: Added.
- http/tests/security/contentSecurityPolicy/1.1/referrer-default-http-https-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/1.1/referrer-default-http-https.html: Added.
- http/tests/security/contentSecurityPolicy/1.1/referrer-default-https-http-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/1.1/referrer-default-https-http.html: Added.
- http/tests/security/contentSecurityPolicy/1.1/referrer-default-https-https-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/1.1/referrer-default-https-https.html: Added.
- http/tests/security/contentSecurityPolicy/1.1/referrer-empty-http-http-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/1.1/referrer-empty-http-http.html: Added.
- http/tests/security/contentSecurityPolicy/1.1/referrer-empty-http-https-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/1.1/referrer-empty-http-https.html: Added.
- http/tests/security/contentSecurityPolicy/1.1/referrer-empty-https-http-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/1.1/referrer-empty-https-http.html: Added.
- http/tests/security/contentSecurityPolicy/1.1/referrer-empty-https-https-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/1.1/referrer-empty-https-https.html: Added.
- http/tests/security/contentSecurityPolicy/1.1/referrer-invalid-http-http-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/1.1/referrer-invalid-http-http.html: Added.
- http/tests/security/contentSecurityPolicy/1.1/referrer-invalid-http-https-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/1.1/referrer-invalid-http-https.html: Added.
- http/tests/security/contentSecurityPolicy/1.1/referrer-invalid-https-http-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/1.1/referrer-invalid-https-http.html: Added.
- http/tests/security/contentSecurityPolicy/1.1/referrer-invalid-https-https-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/1.1/referrer-invalid-https-https.html: Added.
- http/tests/security/contentSecurityPolicy/1.1/referrer-never-http-http-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/1.1/referrer-never-http-http.html: Added.
- http/tests/security/contentSecurityPolicy/1.1/referrer-never-http-https-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/1.1/referrer-never-http-https.html: Added.
- http/tests/security/contentSecurityPolicy/1.1/referrer-never-https-http-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/1.1/referrer-never-https-http.html: Added.
- http/tests/security/contentSecurityPolicy/1.1/referrer-never-https-https-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/1.1/referrer-never-https-https.html: Added.
- http/tests/security/contentSecurityPolicy/1.1/referrer-origin-http-http-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/1.1/referrer-origin-http-http.html: Added.
- http/tests/security/contentSecurityPolicy/1.1/referrer-origin-http-https-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/1.1/referrer-origin-http-https.html: Added.
- http/tests/security/contentSecurityPolicy/1.1/referrer-origin-https-http-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/1.1/referrer-origin-https-http.html: Added.
- http/tests/security/contentSecurityPolicy/1.1/referrer-origin-https-https-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/1.1/referrer-origin-https-https.html: Added.
- http/tests/security/contentSecurityPolicy/1.1/report-uri-effective-directive-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/reportonly-in-meta-ignored-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/1.1/reportonly-in-meta-ignored.html: Added.
- http/tests/security/contentSecurityPolicy/1.1/scripthash-allowed-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/1.1/scripthash-allowed.html: Added.
- http/tests/security/contentSecurityPolicy/1.1/scripthash-basic-blocked-error-event-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/1.1/scripthash-basic-blocked-error-event.html: Added.
- http/tests/security/contentSecurityPolicy/1.1/scripthash-basic-blocked-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/1.1/scripthash-basic-blocked.html: Added.
- http/tests/security/contentSecurityPolicy/1.1/scripthash-default-src.html: Added.
- http/tests/security/contentSecurityPolicy/1.1/scripthash-ignore-unsafeinline-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/1.1/scripthash-ignore-unsafeinline.html: Added.
- http/tests/security/contentSecurityPolicy/1.1/scripthash-malformed-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/1.1/scripthash-malformed.html: Added.
- http/tests/security/contentSecurityPolicy/1.1/scripthash-unicode-normalization-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/1.1/scripthash-unicode-normalization.html: Added.
- http/tests/security/contentSecurityPolicy/1.1/scriptnonce-allowed-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/1.1/scriptnonce-allowed.html: Added.
- http/tests/security/contentSecurityPolicy/1.1/scriptnonce-and-scripthash-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/1.1/scriptnonce-and-scripthash.html: Added.
- http/tests/security/contentSecurityPolicy/1.1/scriptnonce-basic-blocked-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/1.1/scriptnonce-basic-blocked.html: Added.
- http/tests/security/contentSecurityPolicy/1.1/scriptnonce-blocked-expected.txt: Copied from LayoutTests/http/tests/security/contentSecurityPolicy/source-list-parsing-03-expected.txt.
- http/tests/security/contentSecurityPolicy/1.1/scriptnonce-blocked.html: Added.
- http/tests/security/contentSecurityPolicy/1.1/scriptnonce-ignore-unsafeinline-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/1.1/scriptnonce-ignore-unsafeinline.html: Added.
- http/tests/security/contentSecurityPolicy/1.1/scriptnonce-invalidnonce-expected.txt: Copied from LayoutTests/http/tests/security/contentSecurityPolicy/source-list-parsing-07-expected.txt.
- http/tests/security/contentSecurityPolicy/1.1/scriptnonce-invalidnonce.html: Added.
- http/tests/security/contentSecurityPolicy/1.1/scriptnonce-redirect-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/1.1/scriptnonce-redirect.html: Added.
- http/tests/security/contentSecurityPolicy/1.1/securitypolicyviolation-basics-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/securitypolicyviolation-basics.html:
- http/tests/security/contentSecurityPolicy/1.1/securitypolicyviolation-block-cross-origin-image-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/securitypolicyviolation-block-cross-origin-image-from-script-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/securitypolicyviolation-block-cross-origin-image-from-script.html:
- http/tests/security/contentSecurityPolicy/1.1/securitypolicyviolation-block-cross-origin-image.html:
- http/tests/security/contentSecurityPolicy/1.1/securitypolicyviolation-block-image-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/securitypolicyviolation-block-image-from-script-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/securitypolicyviolation-block-image-from-script.html:
- http/tests/security/contentSecurityPolicy/1.1/securitypolicyviolation-block-image.html:
- http/tests/security/contentSecurityPolicy/1.1/stylehash-allowed-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/1.1/stylehash-allowed.html: Added.
- http/tests/security/contentSecurityPolicy/1.1/stylehash-basic-blocked-error-event-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/1.1/stylehash-basic-blocked-error-event.html: Added.
- http/tests/security/contentSecurityPolicy/1.1/stylehash-basic-blocked-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/1.1/stylehash-basic-blocked.html: Added.
- http/tests/security/contentSecurityPolicy/1.1/stylehash-default-src.html: Added.
- http/tests/security/contentSecurityPolicy/1.1/stylehash-svg-style-basic-blocked-error-event-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/1.1/stylehash-svg-style-basic-blocked-error-event.html: Added.
- http/tests/security/contentSecurityPolicy/1.1/stylenonce-allowed-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/1.1/stylenonce-allowed.html: Added.
- http/tests/security/contentSecurityPolicy/1.1/stylenonce-basic-blocked-error-event-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/1.1/stylenonce-basic-blocked-error-event.html: Added.
- http/tests/security/contentSecurityPolicy/1.1/stylenonce-blocked-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/1.1/stylenonce-blocked.html: Added.
- http/tests/security/contentSecurityPolicy/1.1/stylenonce-svg-style-basic-blocked-error-event-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/1.1/stylenonce-svg-style-basic-blocked-error-event.html: Added.
- http/tests/security/contentSecurityPolicy/blob-urls-match-self.html:
- http/tests/security/contentSecurityPolicy/connect-src-eventsource-redirect-to-blocked-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/connect-src-eventsource-redirect-to-blocked.html: Added.
- http/tests/security/contentSecurityPolicy/connect-src-xmlhttprequest-redirect-to-blocked-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/connect-src-xmlhttprequest-redirect-to-blocked.html: Added.
- http/tests/security/contentSecurityPolicy/csp-header-is-sent-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/csp-header-is-sent.html: Added.
- http/tests/security/contentSecurityPolicy/eval-allowed-in-report-only-mode-and-sends-report-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/eval-allowed-in-report-only-mode-and-sends-report.html: Added.
- http/tests/security/contentSecurityPolicy/eval-blocked-and-sends-report-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/eval-blocked-and-sends-report.html: Added.
- http/tests/security/contentSecurityPolicy/frame-src-cross-origin-load-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/frame-src-cross-origin-load.html: Added.
- http/tests/security/contentSecurityPolicy/icon-allowed-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/icon-allowed.html: Added.
- http/tests/security/contentSecurityPolicy/icon-blocked-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/icon-blocked.html: Added.
- http/tests/security/contentSecurityPolicy/image-document-default-src-none-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/image-document-default-src-none.html: Added.
- http/tests/security/contentSecurityPolicy/inline-event-handler-blocked-after-injecting-meta-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/inline-event-handler-blocked-after-injecting-meta.html: Added.
- http/tests/security/contentSecurityPolicy/manifest-src-allowed-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/manifest-src-allowed.html: Added.
- http/tests/security/contentSecurityPolicy/manifest-src-blocked-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/manifest-src-blocked.html: Added.
- http/tests/security/contentSecurityPolicy/manifest.test/manifest.json: Added.
- http/tests/security/contentSecurityPolicy/object-in-svg-foreignobject-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/object-in-svg-foreignobject.html: Added.
- http/tests/security/contentSecurityPolicy/object-src-applet-archive-codebase-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/object-src-applet-archive-codebase.html: Added.
- http/tests/security/contentSecurityPolicy/object-src-applet-archive-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/object-src-applet-archive.html: Added.
- http/tests/security/contentSecurityPolicy/object-src-applet-code-codebase-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/object-src-applet-code-codebase.html: Added.
- http/tests/security/contentSecurityPolicy/object-src-applet-code-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/object-src-applet-code.html: Added.
- http/tests/security/contentSecurityPolicy/object-src-does-not-affect-child-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/object-src-does-not-affect-child.html: Added.
- http/tests/security/contentSecurityPolicy/object-src-param-code-blocked-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/object-src-param-code-blocked.html: Added.
- http/tests/security/contentSecurityPolicy/object-src-param-movie-blocked-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/object-src-param-movie-blocked.html: Added.
- http/tests/security/contentSecurityPolicy/object-src-param-src-blocked-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/object-src-param-src-blocked.html: Added.
- http/tests/security/contentSecurityPolicy/object-src-param-url-blocked-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/object-src-param-url-blocked.html: Added.
- http/tests/security/contentSecurityPolicy/plugin-in-iframe-with-csp-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/plugin-in-iframe-with-csp.html: Added.
- http/tests/security/contentSecurityPolicy/redirect-does-not-match-paths-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/redirect-does-not-match-paths.html: Added.
- http/tests/security/contentSecurityPolicy/register-bypassing-scheme-partial-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/register-bypassing-scheme-partial.html: Added.
- http/tests/security/contentSecurityPolicy/report-and-enforce-expected.txt:
- http/tests/security/contentSecurityPolicy/report-and-enforce.html:
- http/tests/security/contentSecurityPolicy/report-blocked-data-uri-expected.txt:
- http/tests/security/contentSecurityPolicy/report-blocked-file-uri-expected.txt:
- http/tests/security/contentSecurityPolicy/report-blocked-uri-cross-origin-expected.txt:
- http/tests/security/contentSecurityPolicy/report-blocked-uri-expected.txt:
- http/tests/security/contentSecurityPolicy/report-cross-origin-no-cookies-expected.txt:
- http/tests/security/contentSecurityPolicy/report-multiple-violations-01-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/report-multiple-violations-01.html: Added.
- http/tests/security/contentSecurityPolicy/report-multiple-violations-02-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/report-multiple-violations-02.html: Added.
- http/tests/security/contentSecurityPolicy/report-only-expected.txt:
- http/tests/security/contentSecurityPolicy/report-only-from-header-expected.txt:
- http/tests/security/contentSecurityPolicy/report-same-origin-with-cookies-expected.txt:
- http/tests/security/contentSecurityPolicy/report-uri-expected.txt:
- http/tests/security/contentSecurityPolicy/report-uri-from-child-frame-expected.txt:
- http/tests/security/contentSecurityPolicy/report-uri-from-inline-javascript-expected.txt:
- http/tests/security/contentSecurityPolicy/report-uri-from-javascript-expected.txt:
- http/tests/security/contentSecurityPolicy/report-uri-scheme-relative-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/report-uri-scheme-relative.html: Added.
- http/tests/security/contentSecurityPolicy/resources/alert-pass.js: Added.
- http/tests/security/contentSecurityPolicy/resources/child-src-test.js: Added.
(window.onload):
(injectFrame):
(iframeLoaded):
(injectFrameRedirectingTo):
(injectWorker):
(injectSharedWorker):
- http/tests/security/contentSecurityPolicy/resources/csp-header-is-sent.js: Added.
(async_test.xhr.onload):
(async_test):
(test):
- http/tests/security/contentSecurityPolicy/resources/fail-to-inject-script.js: Added.
(s.onerror):
(s.onload):
- http/tests/security/contentSecurityPolicy/resources/frame-ancestors-and-x-frame-options.pl: Added.
- http/tests/security/contentSecurityPolicy/resources/frame-ancestors-test.js: Added.
(injectNestedIframe):
(injectIFrame):
(iframeLoaded):
(crossOriginFrameShouldBeBlocked.window.onload):
(crossOriginFrameShouldBeBlocked):
(crossOriginFrameShouldBeAllowed.window.onload):
(crossOriginFrameShouldBeAllowed):
(sameOriginFrameShouldBeBlocked.window.onload):
(sameOriginFrameShouldBeBlocked):
(sameOriginFrameShouldBeAllowed.window.onload):
(sameOriginFrameShouldBeAllowed):
(window.onload):
(testNestedIFrame):
- http/tests/security/contentSecurityPolicy/resources/frame-ancestors.pl: Added.
- http/tests/security/contentSecurityPolicy/resources/frame-in-frame.pl: Added.
- http/tests/security/contentSecurityPolicy/resources/generate-csp-report.html: Added.
- http/tests/security/contentSecurityPolicy/resources/iframe-redirect-not-allowed.html: Added.
- http/tests/security/contentSecurityPolicy/resources/image-document-default-src-none-iframe.php: Added.
- http/tests/security/contentSecurityPolicy/resources/multiple-iframe-test.js:
- http/tests/security/contentSecurityPolicy/resources/nph-cached-csp.pl:
- http/tests/security/contentSecurityPolicy/resources/object-src-param.js: Added.
(appendObjectElement.window.onload):
(appendObjectElement):
- http/tests/security/contentSecurityPolicy/resources/post-message.js: Added.
- http/tests/security/contentSecurityPolicy/resources/redir.php: Added.
- http/tests/security/contentSecurityPolicy/resources/redirect-does-not-match-paths.js: Added.
(test):
(async_test.img.onload):
(async_test):
(async_test.xhr.onload):
- http/tests/security/contentSecurityPolicy/resources/redirect.pl: Added.
- http/tests/security/contentSecurityPolicy/resources/referrer-test-endpoint.php: Added.
- http/tests/security/contentSecurityPolicy/resources/referrer-test.js: Added.
(ReferrerTest.bindHandler):
(ReferrerTest.base):
(ReferrerTest.generateFrameURL):
(ReferrerTest.injectFrame):
(expectFullReferrer):
(expectNoReferrer):
(expectOriginReferrer):
- http/tests/security/contentSecurityPolicy/resources/referrer-test.php: Added.
- http/tests/security/contentSecurityPolicy/resources/sandbox.php:
- http/tests/security/contentSecurityPolicy/resources/script-redirect-not-allowed.js: Added.
- http/tests/security/contentSecurityPolicy/resources/script-set-value.js: Added.
- http/tests/security/contentSecurityPolicy/resources/style-set-red.css: Added.
(p):
- http/tests/security/contentSecurityPolicy/resources/stylesheet-redirect-not-allowed.css: Added.
(body):
- http/tests/security/contentSecurityPolicy/resources/test-csp-header.pl: Added.
- http/tests/security/contentSecurityPolicy/resources/worker.php: Added.
- http/tests/security/contentSecurityPolicy/resources/xhr-redirect-not-allowed.pl: Added.
- http/tests/security/contentSecurityPolicy/sandbox-report-only-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/sandbox-report-only.html: Added.
- http/tests/security/contentSecurityPolicy/script-src-appended-script-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/script-src-appended-script.html: Added.
- http/tests/security/contentSecurityPolicy/script-src-blocked-error-event-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/script-src-blocked-error-event.html: Added.
- http/tests/security/contentSecurityPolicy/script-src-redirect-expected.txt:
- http/tests/security/contentSecurityPolicy/script-src-redirect.html:
- http/tests/security/contentSecurityPolicy/source-list-parsing-03-expected.txt:
- http/tests/security/contentSecurityPolicy/source-list-parsing-03.html:
- http/tests/security/contentSecurityPolicy/source-list-parsing-07-expected.txt:
- http/tests/security/contentSecurityPolicy/source-list-parsing-07.html:
- http/tests/security/contentSecurityPolicy/source-list-parsing-paths-03-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/source-list-parsing-paths-03.html: Added.
- http/tests/security/contentSecurityPolicy/style-src-blocked-error-event-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/style-src-blocked-error-event.html: Added.
- http/tests/security/contentSecurityPolicy/worker-blob-inherits-csp-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/worker-blob-inherits-csp.html: Added.
- http/tests/security/contentSecurityPolicy/worker-connect-src-allowed.html:
- http/tests/security/contentSecurityPolicy/worker-connect-src-blocked.html:
- http/tests/security/contentSecurityPolicy/worker-eval-blocked.html:
- http/tests/security/contentSecurityPolicy/worker-function-function-blocked.html:
- http/tests/security/contentSecurityPolicy/worker-importscripts-blocked-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/worker-importscripts-blocked.html: Added.
- http/tests/security/contentSecurityPolicy/worker-multiple-csp-headers-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/worker-multiple-csp-headers.html: Added.
- http/tests/security/contentSecurityPolicy/worker-script-src-expected.txt:
- http/tests/security/contentSecurityPolicy/worker-script-src.html:
- http/tests/security/contentSecurityPolicy/worker-set-timeout-blocked.html:
- http/tests/security/contentSecurityPolicy/worker-without-own-csp-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/worker-without-own-csp.html: Added.
- platform/wk2/TestExpectations:
- 12:59 PM Changeset in webkit [195366] by
-
- 1 edit in branches/safari-601.1.46-branch/Source/WebCore/ChangeLog
Merge r187693. rdar://problem/24208161
- 12:27 PM Changeset in webkit [195365] by
-
- 3 edits in trunk/Source/JavaScriptCore
Pack RegisterAtOffset harder.
<https://webkit.org/b/152501>
Reviewed by Michael Saboff.
Pack the register index and the offset into a single pointer-sized word instead of two.
This reduces memory consumption by 620 kB on mobile theverge.com.
The packing doesn't succeed on MSVC for some reason, so I've left out the static
assertion about class size in those builds.
- jit/RegisterAtOffset.cpp:
- jit/RegisterAtOffset.h:
- 12:02 PM Changeset in webkit [195364] by
-
- 5 edits in branches/safari-601.3.9.1-branch/Source
Versioning.
- 12:00 PM Changeset in webkit [195363] by
-
- 1 copy in tags/Safari-601.3.9.1.2
New tag.
- 11:58 AM Changeset in webkit [195362] by
-
- 3 edits in trunk/Source/JavaScriptCore
[B3][Win64] Compile fix.
https://bugs.webkit.org/show_bug.cgi?id=153278
Reviewed by Filip Pizlo.
MSVC does not accept that a class declared as exported also have members declared as exported.
- b3/B3Const32Value.h:
- b3/B3ControlValue.h:
- 11:56 AM Changeset in webkit [195361] by
-
- 2 edits in trunk/LayoutTests
Marking three fast/viewport/ios/width-is-device-width-overflowing* tests as flaky on ios-simulator.
https://bugs.webkit.org/show_bug.cgi?id=153110
Unreviewed test gardening.
- platform/ios-simulator/TestExpectations:
- 11:32 AM Changeset in webkit [195360] by
-
- 6 edits1 add in trunk/Source/JavaScriptCore
[ES6] Fix various issues with TypedArrays.
https://bugs.webkit.org/show_bug.cgi?id=153245
Reviewed by Geoffrey Garen.
This patch fixes a couple of issues with TypedArrays:
1) We were not checking if a view had been neutered and throwing an error
if it had in the our TypedArray.prototype functions.
2) The TypedArray.prototype.set function had a couple of minor issues with
checking for the offset being negative.
3) The JSArrayBufferView class did not check if the backing store had
been neutered when computing the offset even though the view's vector
pointer had been set to NULL. This meant that under some conditions we
could, occasionally, return a garbage number as the offset. Now, we only
neuter views if the backing ArrayBuffer's view is actually transfered.
- jsc.cpp:
(GlobalObject::finishCreation):
(functionNeuterTypedArray):
- runtime/JSArrayBufferView.h:
(JSC::JSArrayBufferView::isNeutered):
- runtime/JSArrayBufferViewInlines.h:
(JSC::JSArrayBufferView::byteOffset):
- runtime/JSGenericTypedArrayViewPrototypeFunctions.h:
(JSC::genericTypedArrayViewProtoFuncSet):
(JSC::genericTypedArrayViewProtoFuncEntries):
(JSC::genericTypedArrayViewProtoFuncCopyWithin):
(JSC::genericTypedArrayViewProtoFuncFill):
(JSC::genericTypedArrayViewProtoFuncIndexOf):
(JSC::genericTypedArrayViewProtoFuncJoin):
(JSC::genericTypedArrayViewProtoFuncKeys):
(JSC::genericTypedArrayViewProtoFuncLastIndexOf):
(JSC::genericTypedArrayViewProtoFuncReverse):
(JSC::genericTypedArrayViewPrivateFuncSort):
(JSC::genericTypedArrayViewProtoFuncSlice):
(JSC::genericTypedArrayViewProtoFuncSubarray):
(JSC::typedArrayViewProtoFuncValues):
- runtime/JSTypedArrayViewPrototype.cpp:
(JSC::typedArrayViewPrivateFuncLength):
(JSC::typedArrayViewPrivateFuncSort): Deleted.
- tests/stress/typedarray-functions-with-neutered.js: Added.
(getGetter):
(unit):
(args.new.Int32Array):
(arrays.typedArrays.map):
(checkProtoFunc.throwsCorrectError):
(checkProtoFunc):
(test):
- 11:30 AM Changeset in webkit [195359] by
-
- 2 edits in trunk/Tools
Botwatcher's dashboard should show an 'X' when the build is broken
https://bugs.webkit.org/show_bug.cgi?id=152507
Reviewed by David Kilzer.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotStaticAnalyzerQueueView.js:
(BuildbotStaticAnalyzerQueueView.prototype.appendStaticAnalyzerQueueStatus):
(BuildbotStaticAnalyzerQueueView.prototype.update):
- 11:27 AM Changeset in webkit [195358] by
-
- 2 edits in trunk/Source/WebKit2
Fix CMake build after r195300.
- PlatformMac.cmake:
Include editing/mac to find DataDetection.h.
- 10:23 AM Changeset in webkit [195357] by
-
- 11 edits in trunk/Source/WebKit2
Ask UI Process before sending redirect requests when downloading
https://bugs.webkit.org/show_bug.cgi?id=153041
Reviewed by Darin Adler.
- NetworkProcess/Downloads/DownloadManager.cpp:
(WebKit::DownloadManager::continueCanAuthenticateAgainstProtectionSpace):
(WebKit::DownloadManager::continueWillSendRequest):
(WebKit::DownloadManager::convertHandleToDownload):
- NetworkProcess/Downloads/DownloadManager.h:
- NetworkProcess/Downloads/PendingDownload.cpp:
(WebKit::PendingDownload::willSendRedirectedRequest):
(WebKit::PendingDownload::continueWillSendRequest):
- NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::continueCanAuthenticateAgainstProtectionSpace):
(WebKit::NetworkProcess::continueWillSendRequest):
(WebKit::NetworkProcess::setCacheModel):
- NetworkProcess/NetworkProcess.h:
- NetworkProcess/NetworkProcess.messages.in:
- UIProcess/API/APIDownloadClient.h:
(API::DownloadClient::didCancel):
(API::DownloadClient::processDidCrash):
(API::DownloadClient::canAuthenticateAgainstProtectionSpace):
(API::DownloadClient::willSendRequest):
- UIProcess/Downloads/DownloadProxy.cpp:
(WebKit::DownloadProxy::didReceiveAuthenticationChallenge):
(WebKit::DownloadProxy::canAuthenticateAgainstProtectionSpace):
(WebKit::DownloadProxy::willSendRequest):
(WebKit::DownloadProxy::didReceiveResponse):
- UIProcess/Downloads/DownloadProxy.h:
- UIProcess/Downloads/DownloadProxy.messages.in:
- 9:59 AM Changeset in webkit [195356] by
-
- 6 edits1 move in trunk/Source
Refactor AtomicStringKeyedMRUCache to be a generic LRU cache
https://bugs.webkit.org/show_bug.cgi?id=153109
Patch by Said Abou-Hallawa <sabouhallawa@apple.com> on 2016-01-20
Reviewed by Darin Adler.
Source/WebCore:
Replace the template specialization of AtomicStringKeyedMRUCache with
template derived from TinyLRUCachePolicy. Override the functions which
are needed for creating the values and the null value. Also replace the
static function which was returning a NeverDestroyed AtomicStringKeyedMRUCache
with a singleton function 'cache' inside the derived template.
- WebCore.xcodeproj/project.pbxproj:
- platform/text/AtomicStringKeyedMRUCache.h: Removed.
- platform/text/cf/HyphenationCF.cpp:
(WebCore::canHyphenate):
(WebCore::lastHyphenLocation):
(WebCore::AtomicStringKeyedMRUCache<RetainPtr<CFLocaleRef>>::createValueForNullKey): Deleted.
(WebCore::AtomicStringKeyedMRUCache<RetainPtr<CFLocaleRef>>::createValueForKey): Deleted.
(WebCore::cfLocaleCache): Deleted.
- platform/text/hyphen/HyphenationLibHyphen.cpp:
(WebCore::countLeadingSpaces):
(WebCore::lastHyphenLocation):
(WebCore::AtomicStringKeyedMRUCache<RefPtr<HyphenationDictionary>>::createValueForNullKey): Deleted.
(WebCore::AtomicStringKeyedMRUCache<RefPtr<HyphenationDictionary>>::createValueForKey): Deleted.
(WebCore::hyphenDictionaryCache): Deleted.
Source/WTF:
Refactor AtomicStringKeyedMRUCache, move it to WTF project and rename it
to be TinyLRUCache. Define another template and call it TinyLRUCachePolicy.
This one can be overridden for different keys and values. Its function is
creating the cached values.
- WTF.xcodeproj/project.pbxproj:
- wtf/TinyLRUCache.h: Added.
(WebCore::TinyLRUCachePolicy::isKeyNull):
(WebCore::TinyLRUCachePolicy::createValueForNullKey):
(WebCore::TinyLRUCachePolicy::createValueForKey):
(WebCore::TinyLRUCache::get):
- 9:16 AM Changeset in webkit [195355] by
-
- 11 edits81 deletes in trunk
Drop support for obsolete Node.isSupported()
https://bugs.webkit.org/show_bug.cgi?id=153164
Reviewed by Darin Adler.
LayoutTests/imported/w3c:
Rebaseline W3C test now that one more check is passing.
- web-platform-tests/dom/historical-expected.txt:
Source/WebCore:
Drop support for obsolete Node.isSupported(). Chrome and Firefox already
dropped it.
No new tests, already covered by existing test.
- dom/Node.cpp:
(WebCore::Node::isSupportedForBindings):
- dom/Node.h:
- dom/Node.idl:
LayoutTests:
Drop obsolete DOM tests.
- dom/html/level2/html/HTMLBodyElement07-expected.txt: Removed.
- dom/html/level2/html/HTMLBodyElement07.html: Removed.
- dom/html/level2/html/HTMLBodyElement07.js: Removed.
- dom/html/level2/html/HTMLBodyElement08-expected.txt: Removed.
- dom/html/level2/html/HTMLBodyElement08.html: Removed.
- dom/html/level2/html/HTMLBodyElement08.js: Removed.
- dom/html/level2/html/HTMLBodyElement09-expected.txt: Removed.
- dom/html/level2/html/HTMLBodyElement09.html: Removed.
- dom/html/level2/html/HTMLBodyElement09.js: Removed.
- dom/html/level2/html/HTMLBodyElement10-expected.txt: Removed.
- dom/html/level2/html/HTMLBodyElement10.html: Removed.
- dom/html/level2/html/HTMLBodyElement10.js: Removed.
- dom/html/level2/html/HTMLBodyElement11-expected.txt: Removed.
- dom/html/level2/html/HTMLBodyElement11.html: Removed.
- dom/html/level2/html/HTMLBodyElement11.js: Removed.
- dom/html/level2/html/HTMLBodyElement12-expected.txt: Removed.
- dom/html/level2/html/HTMLBodyElement12.html: Removed.
- dom/html/level2/html/HTMLBodyElement12.js: Removed.
- dom/html/level2/html/HTMLDocument22-expected.txt: Removed.
- dom/html/level2/html/HTMLDocument22.html: Removed.
- dom/html/level2/html/HTMLDocument22.js: Removed.
- dom/html/level2/html/HTMLDocument23-expected.txt: Removed.
- dom/html/level2/html/HTMLDocument23.html: Removed.
- dom/html/level2/html/HTMLDocument23.js: Removed.
- dom/html/level2/html/HTMLDocument24-expected.txt: Removed.
- dom/html/level2/html/HTMLDocument24.html: Removed.
- dom/html/level2/html/HTMLDocument24.js: Removed.
- dom/html/level2/html/HTMLDocument25-expected.txt: Removed.
- dom/html/level2/html/HTMLDocument25.html: Removed.
- dom/html/level2/html/HTMLDocument25.js: Removed.
- dom/html/level2/html/HTMLDocument26-expected.txt: Removed.
- dom/html/level2/html/HTMLDocument26.html: Removed.
- dom/html/level2/html/HTMLDocument26.js: Removed.
- dom/html/level2/html/HTMLDocument27-expected.txt: Removed.
- dom/html/level2/html/HTMLDocument27.html: Removed.
- dom/html/level2/html/HTMLDocument27.js: Removed.
- dom/svg/level3/xpath/Conformance_isSupported_3-expected.txt: Removed.
- dom/svg/level3/xpath/Conformance_isSupported_3.js: Removed.
- dom/svg/level3/xpath/Conformance_isSupported_3.svg: Removed.
- dom/svg/level3/xpath/Conformance_isSupported_empty-expected.txt: Removed.
- dom/svg/level3/xpath/Conformance_isSupported_empty.js: Removed.
- dom/svg/level3/xpath/Conformance_isSupported_empty.svg: Removed.
- dom/svg/level3/xpath/Conformance_isSupported_null-expected.txt: Removed.
- dom/svg/level3/xpath/Conformance_isSupported_null.js: Removed.
- dom/svg/level3/xpath/Conformance_isSupported_null.svg: Removed.
- dom/xhtml/level2/html/HTMLBodyElement07-expected.txt: Removed.
- dom/xhtml/level2/html/HTMLBodyElement07.js: Removed.
- dom/xhtml/level2/html/HTMLBodyElement07.xhtml: Removed.
- dom/xhtml/level2/html/HTMLBodyElement08-expected.txt: Removed.
- dom/xhtml/level2/html/HTMLBodyElement08.js: Removed.
- dom/xhtml/level2/html/HTMLBodyElement08.xhtml: Removed.
- dom/xhtml/level2/html/HTMLBodyElement09-expected.txt: Removed.
- dom/xhtml/level2/html/HTMLBodyElement09.js: Removed.
- dom/xhtml/level2/html/HTMLBodyElement09.xhtml: Removed.
- dom/xhtml/level2/html/HTMLBodyElement10-expected.txt: Removed.
- dom/xhtml/level2/html/HTMLBodyElement10.js: Removed.
- dom/xhtml/level2/html/HTMLBodyElement10.xhtml: Removed.
- dom/xhtml/level2/html/HTMLBodyElement11-expected.txt: Removed.
- dom/xhtml/level2/html/HTMLBodyElement11.js: Removed.
- dom/xhtml/level2/html/HTMLBodyElement11.xhtml: Removed.
- dom/xhtml/level2/html/HTMLBodyElement12-expected.txt: Removed.
- dom/xhtml/level2/html/HTMLBodyElement12.js: Removed.
- dom/xhtml/level2/html/HTMLBodyElement12.xhtml: Removed.
- dom/xhtml/level2/html/HTMLDocument22-expected.txt: Removed.
- dom/xhtml/level2/html/HTMLDocument22.js: Removed.
- dom/xhtml/level2/html/HTMLDocument22.xhtml: Removed.
- dom/xhtml/level2/html/HTMLDocument23-expected.txt: Removed.
- dom/xhtml/level2/html/HTMLDocument23.js: Removed.
- dom/xhtml/level2/html/HTMLDocument23.xhtml: Removed.
- dom/xhtml/level2/html/HTMLDocument24-expected.txt: Removed.
- dom/xhtml/level2/html/HTMLDocument24.js: Removed.
- dom/xhtml/level2/html/HTMLDocument24.xhtml: Removed.
- dom/xhtml/level2/html/HTMLDocument25-expected.txt: Removed.
- dom/xhtml/level2/html/HTMLDocument25.js: Removed.
- dom/xhtml/level2/html/HTMLDocument25.xhtml: Removed.
- dom/xhtml/level2/html/HTMLDocument26-expected.txt: Removed.
- dom/xhtml/level2/html/HTMLDocument26.js: Removed.
- dom/xhtml/level2/html/HTMLDocument26.xhtml: Removed.
- dom/xhtml/level2/html/HTMLDocument27-expected.txt: Removed.
- dom/xhtml/level2/html/HTMLDocument27.js: Removed.
- dom/xhtml/level2/html/HTMLDocument27.xhtml: Removed.
- fast/dom/features-expected.txt:
- fast/dom/features.html:
- 5:25 AM Changeset in webkit [195354] by
-
- 1 copy in releases/WebKitGTK/webkit-2.10.5
WebKitGTK+ 2.10.5
- 5:19 AM Changeset in webkit [195353] by
-
- 4 edits in releases/WebKitGTK/webkit-2.10
Unreviewed. Update OptionsGTK.cmake and NEWS for 2.10.5 release.
.:
- Source/cmake/OptionsGTK.cmake: Bump version numbers.
Source/WebKit2:
- gtk/NEWS: Add release notes for 2.10.5
- 4:46 AM Changeset in webkit [195352] by
-
- 2 edits in releases/WebKitGTK/webkit-2.10/Source/WebCore
Merge r195312 - Fixed compilation of AXObjectCache in case of !HAVE(ACCESSIBILITY).
https://bugs.webkit.org/show_bug.cgi?id=153243
Patch by Konstantin Tokarev <Konstantin Tokarev> on 2016-01-19
Reviewed by Chris Fleizach.
No new tests needed.
- accessibility/AXObjectCache.h:
(WebCore::AXObjectCache::AXObjectCache):
(WebCore::nodeHasRole): Deleted.
- 4:43 AM Changeset in webkit [195351] by
-
- 5 edits in releases/WebKitGTK/webkit-2.10/Source/WebKit2
Merge r195231 - [EFL][GTK][WK2] Fix UIProcess build with GStreamer and without VIDEO
https://bugs.webkit.org/show_bug.cgi?id=153135
Patch by Olivier Blin <Olivier Blin> on 2016-01-18
Reviewed by Michael Catanzaro.
GStreamer builds fail when WebAudio is enabled but VIDEO disabled.
This change makes the flag more consistent around the
decicePolicyForInstallMissingMediaPluginsPermissionRequest() method:
ENABLE(VIDEO) && USE(GSTREAMER) everywhere, while the code used to
test either one or the other.
This does not enable InstallMissingMediaPlugins for WebAudio, since no
code makes use of this in WebKitWebAudioSourceGStreamer.
It also fixes a naming typo for the following method:
decidePolicyForInstallMissingMediaPluginsPermissionRequest()
- UIProcess/API/gtk/PageClientImpl.cpp:
(WebKit::PageClientImpl::decidePolicyForInstallMissingMediaPluginsPermissionRequest):
- UIProcess/API/gtk/PageClientImpl.h:
- UIProcess/PageClient.h:
- UIProcess/efl/WebViewEfl.h:
- UIProcess/gstreamer/WebPageProxyGStreamer.cpp:
(WebKit::WebPageProxy::requestInstallMissingMediaPlugins):
- 4:38 AM Changeset in webkit [195350] by
-
- 2 edits in releases/WebKitGTK/webkit-2.10/Source/WebCore
Merge r195349 - Unreviewed. Fix compile warning when building with GTK+ < 3.14.
- rendering/RenderThemeGtk.cpp:
(WebCore::loadThemedIcon):
- 4:12 AM Changeset in webkit [195349] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed. Fix compile warning when building with GTK+ < 3.14.
- rendering/RenderThemeGtk.cpp:
(WebCore::loadThemedIcon):
- 2:49 AM Changeset in webkit [195348] by
-
- 2 edits in trunk/Source/WebCore
[Mac] Speculative cmake buildfix after r195317.
- PlatformMac.cmake:
- 1:07 AM Changeset in webkit [195347] by
-
- 1 copy in releases/WebKitGTK/webkit-2.11.4
WebKitGTK+ 2.11.4
- 1:04 AM Changeset in webkit [195346] by
-
- 4 edits in trunk
Unreviewed. Update OptionsGTK.cmake and NEWS for 2.11.4 release.
.:
- Source/cmake/OptionsGTK.cmake: Bump version numbers.
Source/WebKit2:
- gtk/NEWS: Add release notes for 2.11.4.
Jan 19, 2016:
- 10:23 PM Changeset in webkit [195345] by
-
- 2 edits in trunk/LayoutTests
Web Inspector: Fix inspector/model/remote-object.html test
https://bugs.webkit.org/show_bug.cgi?id=153261
<rdar://problem/24249553>
Reviewed by Timothy Hatcher.
Rebaseline the test for Mac platform that broke in r195305.
- platform/mac/inspector/model/remote-object-expected.txt:
- 10:22 PM Changeset in webkit [195344] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Uncaught exception when logging an Error object
https://bugs.webkit.org/show_bug.cgi?id=153258
<rdar://problem/24249068>
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-01-19
Reviewed by Timothy Hatcher.
- UserInterface/Views/ErrorObjectView.js:
(WebInspector.ErrorObjectView):
Initialize members that are used later for clarity.
(WebInspector.ErrorObjectView.prototype.collapse):
(WebInspector.ErrorObjectView.prototype.expand):
This never has a previewView, remove it.
(WebInspector.ErrorObjectView.prototype.appendTitleSuffix):
Add the suffix ("= $1") after the description and before the
content tree outline.
- 10:20 PM Changeset in webkit [195343] by
-
- 5 edits in trunk/Source/WebInspectorUI
Web Inspector: Subclasses of WebInspector.Object shouldn't overwrite this._listeners
https://bugs.webkit.org/show_bug.cgi?id=153268
<rdar://problem/24252766>
Reviewed by Timothy Hatcher.
- UserInterface/Base/Object.js:
(WebInspector.Object.prototype.dispatchEventToListeners):
Add a console.assert.
- UserInterface/Views/BreakpointTreeElement.js:
(WebInspector.BreakpointTreeElement):
(WebInspector.BreakpointTreeElement.prototype.onattach):
(WebInspector.BreakpointTreeElement.prototype.ondetach):
- UserInterface/Views/ProbeSetDataGrid.js:
(WebInspector.ProbeSetDataGrid):
(WebInspector.ProbeSetDataGrid.prototype.closed):
- UserInterface/Views/ProbeSetDetailsSection.js:
(WebInspector.ProbeSetDetailsSection):
(WebInspector.ProbeSetDetailsSection.prototype.closed):
Replace all instances of "this._listeners" with "this._listenerSet".
- 10:20 PM Changeset in webkit [195342] by
-
- 2 edits in trunk/Tools
Remove assertion from revisionContentForIteration that is causing errors on the dashboard.
https://bugs.webkit.org/show_bug.cgi?id=153262
Reviewed by Alexey Proskuryakov.
Occasionaly some buildbot iterations will not have their "got_revisions" property populated. In
such cases this revisionContentForIteration method does not have any content to return, thus the
assertion fails.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
(BuildbotQueueView.prototype.revisionContentForIteration): Removed assertion that was causing errors.
- 10:07 PM Changeset in webkit [195341] by
-
- 5 edits in trunk/Source
Versioning.
- 10:05 PM Changeset in webkit [195340] by
-
- 1 copy in tags/Safari-602.1.17
New tag.
- 8:39 PM Changeset in webkit [195339] by
-
- 3 edits in trunk/Source/WTF
WTF::Bag should be non-copyable
https://bugs.webkit.org/show_bug.cgi?id=153253
Reviewed by Filip Pizlo.
- wtf/Bag.h:
- wtf/SegmentedVector.h:
(WTF::SegmentedVector::append):
(WTF::SegmentedVector::alloc):
- 8:37 PM Changeset in webkit [195338] by
-
- 5 edits in branches/safari-601.3.9.1-branch/Source
Versioning.
- 8:34 PM Changeset in webkit [195337] by
-
- 1 copy in tags/Safari-601.3.9.1.1
New tag.
- 8:06 PM Changeset in webkit [195336] by
-
- 7 edits3 deletes in trunk
DocumentType.publicId / systemId should never return null
https://bugs.webkit.org/show_bug.cgi?id=153264
Reviewed by Ryosuke Niwa.
LayoutTests/imported/w3c:
Rebaseline several W3C DOM tests now that more checks are passing.
- web-platform-tests/dom/interfaces-expected.txt:
- web-platform-tests/dom/nodes/DOMImplementation-createHTMLDocument-expected.txt:
- web-platform-tests/dom/nodes/Node-properties-expected.txt:
Source/WebCore:
DocumentType.publicId / systemId should never return null as these
attributes are not nullable in the IDL:
https://dom.spec.whatwg.org/#interface-documenttype
Instead we should return the empty string. Firefox and Chrome match the
specification.
No new tests, already covered by existing tests.
- dom/DocumentType.idl:
LayoutTests:
Drop outdated DOM test.
- dom/xhtml/level3/core/documentgetdoctype01-expected.txt: Removed.
- dom/xhtml/level3/core/documentgetdoctype01.js: Removed.
- dom/xhtml/level3/core/documentgetdoctype01.xhtml: Removed.
- 7:50 PM Changeset in webkit [195335] by
-
- 19 edits2 deletes in trunk/Source/WebCore
Unreviewed, rolling out r195302.
https://bugs.webkit.org/show_bug.cgi?id=153267
This change broke the Windows build, rolling out so it isn't
broken all night before investigation. (Requested by
ryanhaddad on #webkit).
Reverted changeset:
"[EME] Correctly report errors when generating key requests
from AVContentKeySession."
https://bugs.webkit.org/show_bug.cgi?id=151963
http://trac.webkit.org/changeset/195302
- 5:18 PM Changeset in webkit [195334] by
-
- 67 edits in trunk/LayoutTests
Modern IDB: Remove unneeded "Alert: " string from storage/indexeddb/modern tests.
https://bugs.webkit.org/show_bug.cgi?id=153257
Reviewed by Sam Weinig.
These were put in to minimize the diff for https://trac.webkit.org/changeset/195321 and
make it easier to review.
Now they can be removed.
- storage/indexeddb/modern/aborted-put-expected.txt:
- storage/indexeddb/modern/autoincrement-abort-expected.txt:
- storage/indexeddb/modern/basic-add-expected.txt:
- storage/indexeddb/modern/basic-put-expected.txt:
- storage/indexeddb/modern/createobjectstore-basic-expected.txt:
- storage/indexeddb/modern/createobjectstore-failures-expected.txt:
- storage/indexeddb/modern/date-basic-expected.txt:
- storage/indexeddb/modern/deletedatabase-null-name-exception-expected.txt:
- storage/indexeddb/modern/deletedatabase-request-event-expected.txt:
- storage/indexeddb/modern/deletedatabase-request-expected.txt:
- storage/indexeddb/modern/deleteobjectstore-1-expected.txt:
- storage/indexeddb/modern/double-abort-expected.txt:
- storage/indexeddb/modern/get-keyrange-expected.txt:
- storage/indexeddb/modern/idbdatabase-deleteobjectstore-failures-expected.txt:
- storage/indexeddb/modern/idbdatabase-transaction-failures-expected.txt:
- storage/indexeddb/modern/idbindex-properties-basic-expected.txt:
- storage/indexeddb/modern/idbobjectstore-clear-1-expected.txt:
- storage/indexeddb/modern/idbobjectstore-clear-2-expected.txt:
- storage/indexeddb/modern/idbobjectstore-count-1-expected.txt:
- storage/indexeddb/modern/idbobjectstore-count-failures-expected.txt:
- storage/indexeddb/modern/idbobjectstore-get-failures-expected.txt:
- storage/indexeddb/modern/idbobjectstore-put-and-clear-failures-expected.txt:
- storage/indexeddb/modern/idbtransaction-objectstore-failures-expected.txt:
- storage/indexeddb/modern/keypath-basic-expected.txt:
- storage/indexeddb/modern/opendatabase-request-event-expected.txt:
- storage/indexeddb/modern/opendatabase-request-expected.txt:
- storage/indexeddb/modern/resources/aborted-put.js:
- storage/indexeddb/modern/resources/autoincrement-abort.js:
- storage/indexeddb/modern/resources/basic-add.js:
- storage/indexeddb/modern/resources/basic-put.js:
- storage/indexeddb/modern/resources/createobjectstore-basic.js:
- storage/indexeddb/modern/resources/createobjectstore-failures.js:
- storage/indexeddb/modern/resources/date-basic.js:
- storage/indexeddb/modern/resources/deletedatabase-null-name-exception.js:
- storage/indexeddb/modern/resources/deletedatabase-request-event.js:
- storage/indexeddb/modern/resources/deletedatabase-request.js:
- storage/indexeddb/modern/resources/deleteobjectstore-1.js:
- storage/indexeddb/modern/resources/double-abort.js:
- storage/indexeddb/modern/resources/get-keyrange.js:
- storage/indexeddb/modern/resources/idbdatabase-deleteobjectstore-failures.js:
- storage/indexeddb/modern/resources/idbdatabase-transaction-failures.js:
- storage/indexeddb/modern/resources/idbindex-properties-basic.js:
- storage/indexeddb/modern/resources/idbobjectstore-clear-1.js:
- storage/indexeddb/modern/resources/idbobjectstore-clear-2.js:
- storage/indexeddb/modern/resources/idbobjectstore-count-1.js:
- storage/indexeddb/modern/resources/idbobjectstore-count-failures.js:
- storage/indexeddb/modern/resources/idbobjectstore-get-failures.js:
- storage/indexeddb/modern/resources/idbobjectstore-put-and-clear-failures.js:
- storage/indexeddb/modern/resources/idbtransaction-objectstore-failures.js:
- storage/indexeddb/modern/resources/keypath-basic.js:
- storage/indexeddb/modern/resources/opendatabase-request-event.js:
- storage/indexeddb/modern/resources/opendatabase-request.js:
- storage/indexeddb/modern/resources/transaction-scheduler-1.js:
- storage/indexeddb/modern/resources/transaction-scheduler-2.js:
- storage/indexeddb/modern/resources/transaction-scheduler-3.js:
- storage/indexeddb/modern/resources/transaction-scheduler-5.js:
- storage/indexeddb/modern/resources/transaction-scheduler-6.js:
- storage/indexeddb/modern/resources/versionchange-abort-then-reopen.js:
- storage/indexeddb/modern/resources/versionchange-event.js:
- storage/indexeddb/modern/transaction-scheduler-1-expected.txt:
- storage/indexeddb/modern/transaction-scheduler-2-expected.txt:
- storage/indexeddb/modern/transaction-scheduler-3-expected.txt:
- storage/indexeddb/modern/transaction-scheduler-5-expected.txt:
- storage/indexeddb/modern/transaction-scheduler-6-expected.txt:
- storage/indexeddb/modern/versionchange-abort-then-reopen-expected.txt:
- storage/indexeddb/modern/versionchange-event-expected.txt:
- 5:14 PM Changeset in webkit [195333] by
-
- 2 edits in branches/safari-601.3.9.1-branch/Source/WebCore
Merged r192700. rdar://problem/19861992
- 5:11 PM Changeset in webkit [195332] by
-
- 2 edits in branches/safari-601.3.9.1-branch/Source/WebCore
Merged r194235. rdar://problem/23944407
- 5:07 PM Changeset in webkit [195331] by
-
- 3 edits in branches/safari-601.3.9.1-branch/Source/WebCore
Merged r192166. rdar://problem/22956040
- 5:07 PM Changeset in webkit [195330] by
-
- 6 edits in trunk
[INTL] Implement Date.prototype.toLocaleDateString in ECMA-402
https://bugs.webkit.org/show_bug.cgi?id=147612
Patch by Andy VanWagoner <thetalecrafter@gmail.com> on 2016-01-19
Reviewed by Benjamin Poulain.
Source/JavaScriptCore:
Implement toLocaleDateString in builtin JavaScript. Remove comments with
spec steps, and instead link to the new HTML version of the spec.
Avoids creating an extra empty object in the prototype chain of the options
object in ToDateTimeOptions. The version used in toLocaleString was updated
to match as well.
- builtins/DatePrototype.js:
(toLocaleString.toDateTimeOptionsAnyAll):
(toLocaleString):
(toLocaleDateString.toDateTimeOptionsDateDate):
(toLocaleDateString):
- runtime/DatePrototype.cpp:
(JSC::DatePrototype::finishCreation):
LayoutTests:
Added tests for toLocaleDateString.
- js/date-toLocaleString-expected.txt:
- js/script-tests/date-toLocaleString.js:
- 5:05 PM Changeset in webkit [195329] by
-
- 2 edits in branches/safari-601.3.9.1-branch/Source/WebKit/win
Merge patch for rdar://problem/23025615.
- 5:03 PM Changeset in webkit [195328] by
-
- 3 edits in branches/safari-601.3.9.1-branch/Source/WebKit/win
Merge patch for rdar://problem/23025615.
- 4:56 PM Changeset in webkit [195327] by
-
- 3 edits in trunk/Source/WebKit/mac
32-bit build fix.
- WebView/WebView.mm:
(-[WebView updateWebViewAdditions]):
(-[WebView showCandidates:forString:inRect:view:completionHandler:]):
- WebView/WebViewInternal.h:
- 4:55 PM Changeset in webkit [195326] by
-
- 5 edits in branches/safari-601.3.9.1-branch/Source
Versioning.
- 4:53 PM Changeset in webkit [195325] by
-
- 1 copy in branches/safari-601.3.9.1-branch
New Branch.
- 4:46 PM Changeset in webkit [195324] by
-
- 4 edits in trunk/Source/WebKit/mac
Move away from NSSpellChecker's showCandidates method
https://bugs.webkit.org/show_bug.cgi?id=153254
-and corresponding-
rdar://problem/24216292
Reviewed by Tim Horton.
- WebCoreSupport/WebEditorClient.mm:
(WebEditorClient::handleRequestedCandidates):
- WebView/WebView.mm:
(-[WebView updateWebViewAdditions]):
(-[WebView showCandidates:forString:inRect:view:completionHandler:]):
- WebView/WebViewInternal.h:
- 4:45 PM Changeset in webkit [195323] by
-
- 1 edit3 adds in trunk/Source/WebInspectorUI
Web Inspector: Add protocol version for iOS 9.3
https://bugs.webkit.org/show_bug.cgi?id=153256
rdar://problem/24247951
Reviewed by Joseph Pecoraro.
- UserInterface/Protocol/Legacy/9.3/InspectorBackendCommands.js: Added.
- Versions/Inspector-iOS-9.3.json: Added.
- 4:17 PM Changeset in webkit [195322] by
-
- 4 edits in trunk
LayoutTests/imported/w3c:
Document.createDocument() should treat undefined namespace as null
https://bugs.webkit.org/show_bug.cgi?id=153252
Reviewed by Ryosuke Niwa.
Rebaseline W3C DOM test now that more checks are passing.
- web-platform-tests/dom/nodes/DOMImplementation-createDocument-expected.txt:
Source/WebCore:
DOMImplementation.createDocument() should treat undefined namespace as null
https://bugs.webkit.org/show_bug.cgi?id=153252
Reviewed by Ryosuke Niwa.
DOMImplementation.createDocument() should treat undefined namespace as null as
the DOMString parameter is nullable:
https://dom.spec.whatwg.org/#domimplementation
Firefox behaves according to the specification, Chrome does not.
No new tests, already covered by existing test.
- dom/DOMImplementation.idl:
- 3:41 PM Changeset in webkit [195321] by
-
- 141 edits63 copies6 adds in trunk/LayoutTests
Modern IDB: Split all storage/indexeddb/modern tests into separate HTML + JS format.
https://bugs.webkit.org/show_bug.cgi?id=153251
Reviewed by Sam Weinig.
- storage/indexeddb/modern/abort-requests-cancelled-expected.txt:
- storage/indexeddb/modern/abort-requests-cancelled.html:
- storage/indexeddb/modern/aborted-put-expected.txt:
- storage/indexeddb/modern/aborted-put.html:
- storage/indexeddb/modern/autoincrement-abort-expected.txt:
- storage/indexeddb/modern/autoincrement-abort.html:
- storage/indexeddb/modern/basic-add-expected.txt:
- storage/indexeddb/modern/basic-add.html:
- storage/indexeddb/modern/basic-put-expected.txt:
- storage/indexeddb/modern/basic-put.html:
- storage/indexeddb/modern/create-index-failures-expected.txt:
- storage/indexeddb/modern/create-index-failures.html:
- storage/indexeddb/modern/createobjectstore-basic-expected.txt:
- storage/indexeddb/modern/createobjectstore-basic.html:
- storage/indexeddb/modern/createobjectstore-failures-expected.txt:
- storage/indexeddb/modern/createobjectstore-failures.html:
- storage/indexeddb/modern/cursor-1-expected.txt:
- storage/indexeddb/modern/cursor-1.html:
- storage/indexeddb/modern/cursor-2-expected.txt:
- storage/indexeddb/modern/cursor-2.html:
- storage/indexeddb/modern/cursor-3-expected.txt:
- storage/indexeddb/modern/cursor-3.html:
- storage/indexeddb/modern/cursor-4-expected.txt:
- storage/indexeddb/modern/cursor-4.html:
- storage/indexeddb/modern/cursor-5-expected.txt:
- storage/indexeddb/modern/cursor-5.html:
- storage/indexeddb/modern/cursor-6-expected.txt:
- storage/indexeddb/modern/cursor-6.html:
- storage/indexeddb/modern/cursor-7-expected.txt:
- storage/indexeddb/modern/cursor-7.html:
- storage/indexeddb/modern/cursor-8-expected.txt:
- storage/indexeddb/modern/cursor-8.html:
- storage/indexeddb/modern/date-basic-expected.txt:
- storage/indexeddb/modern/date-basic.html:
- storage/indexeddb/modern/deletedatabase-1-expected.txt:
- storage/indexeddb/modern/deletedatabase-1.html:
- storage/indexeddb/modern/deletedatabase-2-expected.txt:
- storage/indexeddb/modern/deletedatabase-2.html:
- storage/indexeddb/modern/deletedatabase-null-name-exception-expected.txt:
- storage/indexeddb/modern/deletedatabase-null-name-exception.html:
- storage/indexeddb/modern/deletedatabase-request-event-expected.txt:
- storage/indexeddb/modern/deletedatabase-request-event.html:
- storage/indexeddb/modern/deletedatabase-request-expected.txt:
- storage/indexeddb/modern/deletedatabase-request.html:
- storage/indexeddb/modern/deleteindex-1-expected.txt:
- storage/indexeddb/modern/deleteindex-1.html:
- storage/indexeddb/modern/deleteindex-2-expected.txt:
- storage/indexeddb/modern/deleteindex-2.html:
- storage/indexeddb/modern/deleteobjectstore-1-expected.txt:
- storage/indexeddb/modern/deleteobjectstore-1.html:
- storage/indexeddb/modern/double-abort-expected.txt:
- storage/indexeddb/modern/double-abort.html:
- storage/indexeddb/modern/double-open-expected.txt:
- storage/indexeddb/modern/double-open.html:
- storage/indexeddb/modern/get-index-failures-expected.txt:
- storage/indexeddb/modern/get-index-failures.html:
- storage/indexeddb/modern/get-keyrange-expected.txt:
- storage/indexeddb/modern/get-keyrange.html:
- storage/indexeddb/modern/idbdatabase-deleteobjectstore-failures-expected.txt:
- storage/indexeddb/modern/idbdatabase-deleteobjectstore-failures.html:
- storage/indexeddb/modern/idbdatabase-transaction-failures-expected.txt:
- storage/indexeddb/modern/idbdatabase-transaction-failures.html:
- storage/indexeddb/modern/idbindex-properties-basic-expected.txt:
- storage/indexeddb/modern/idbindex-properties-basic.html:
- storage/indexeddb/modern/idbobjectstore-clear-1-expected.txt:
- storage/indexeddb/modern/idbobjectstore-clear-1.html:
- storage/indexeddb/modern/idbobjectstore-clear-2-expected.txt:
- storage/indexeddb/modern/idbobjectstore-clear-2.html:
- storage/indexeddb/modern/idbobjectstore-count-1-expected.txt:
- storage/indexeddb/modern/idbobjectstore-count-1.html:
- storage/indexeddb/modern/idbobjectstore-count-failures-expected.txt:
- storage/indexeddb/modern/idbobjectstore-count-failures.html:
- storage/indexeddb/modern/idbobjectstore-delete-1-expected.txt:
- storage/indexeddb/modern/idbobjectstore-delete-1.html:
- storage/indexeddb/modern/idbobjectstore-delete-2-expected.txt:
- storage/indexeddb/modern/idbobjectstore-delete-2.html:
- storage/indexeddb/modern/idbobjectstore-delete-failures-expected.txt:
- storage/indexeddb/modern/idbobjectstore-delete-failures.html:
- storage/indexeddb/modern/idbobjectstore-get-failures-expected.txt:
- storage/indexeddb/modern/idbobjectstore-get-failures.html:
- storage/indexeddb/modern/idbobjectstore-put-and-clear-failures-expected.txt:
- storage/indexeddb/modern/idbobjectstore-put-and-clear-failures.html:
- storage/indexeddb/modern/idbtransaction-objectstore-failures-expected.txt:
- storage/indexeddb/modern/idbtransaction-objectstore-failures.html:
- storage/indexeddb/modern/index-1-expected.txt:
- storage/indexeddb/modern/index-1.html:
- storage/indexeddb/modern/index-2-expected.txt:
- storage/indexeddb/modern/index-2.html:
- storage/indexeddb/modern/index-3-expected.txt:
- storage/indexeddb/modern/index-3.html:
- storage/indexeddb/modern/index-4-expected.txt:
- storage/indexeddb/modern/index-4.html:
- storage/indexeddb/modern/index-5-expected.txt:
- storage/indexeddb/modern/index-5.html:
- storage/indexeddb/modern/index-cursor-1-expected.txt:
- storage/indexeddb/modern/index-cursor-1.html:
- storage/indexeddb/modern/index-cursor-2-expected.txt:
- storage/indexeddb/modern/index-cursor-2.html:
- storage/indexeddb/modern/index-cursor-3-expected.txt:
- storage/indexeddb/modern/index-cursor-3.html:
- storage/indexeddb/modern/index-get-count-basic-expected.txt:
- storage/indexeddb/modern/index-get-count-basic.html:
- storage/indexeddb/modern/index-get-count-failures-expected.txt:
- storage/indexeddb/modern/index-get-count-failures.html:
- storage/indexeddb/modern/keypath-basic-expected.txt:
- storage/indexeddb/modern/keypath-basic.html:
- storage/indexeddb/modern/objectstore-attributes-expected.txt:
- storage/indexeddb/modern/objectstore-attributes.html:
- storage/indexeddb/modern/objectstore-cursor-advance-failures-expected.txt:
- storage/indexeddb/modern/objectstore-cursor-advance-failures.html:
- storage/indexeddb/modern/objectstore-cursor-continue-failures-expected.txt:
- storage/indexeddb/modern/objectstore-cursor-continue-failures.html:
- storage/indexeddb/modern/opencursor-failures-expected.txt:
- storage/indexeddb/modern/opencursor-failures.html:
- storage/indexeddb/modern/opendatabase-request-event-expected.txt:
- storage/indexeddb/modern/opendatabase-request-event.html:
- storage/indexeddb/modern/opendatabase-request-expected.txt:
- storage/indexeddb/modern/opendatabase-request.html:
- storage/indexeddb/modern/opendatabase-success-after-versionchange-expected.txt:
- storage/indexeddb/modern/opendatabase-success-after-versionchange.html:
- storage/indexeddb/modern/opendatabase-versions-expected.txt:
- storage/indexeddb/modern/opendatabase-versions.html:
- storage/indexeddb/modern/request-readystate-expected.txt:
- storage/indexeddb/modern/request-readystate.html:
- storage/indexeddb/modern/resources/abort-requests-cancelled.js: Copied from LayoutTests/storage/indexeddb/modern/abort-requests-cancelled.html.
- storage/indexeddb/modern/resources/aborted-put.js: Copied from LayoutTests/storage/indexeddb/modern/aborted-put.html.
- storage/indexeddb/modern/resources/autoincrement-abort.js: Copied from LayoutTests/storage/indexeddb/modern/autoincrement-abort.html.
- storage/indexeddb/modern/resources/basic-add.js: Copied from LayoutTests/storage/indexeddb/modern/basic-add.html.
- storage/indexeddb/modern/resources/basic-put.js: Copied from LayoutTests/storage/indexeddb/modern/basic-put.html.
- storage/indexeddb/modern/resources/create-index-failures.js: Copied from LayoutTests/storage/indexeddb/modern/create-index-failures.html.
- storage/indexeddb/modern/resources/createobjectstore-basic.js: Copied from LayoutTests/storage/indexeddb/modern/createobjectstore-basic.html.
- storage/indexeddb/modern/resources/createobjectstore-failures.js: Copied from LayoutTests/storage/indexeddb/modern/createobjectstore-failures.html.
- storage/indexeddb/modern/resources/cursor-1.js: Copied from LayoutTests/storage/indexeddb/modern/cursor-1.html.
- storage/indexeddb/modern/resources/cursor-2.js: Copied from LayoutTests/storage/indexeddb/modern/cursor-2.html.
- storage/indexeddb/modern/resources/cursor-3.js: Copied from LayoutTests/storage/indexeddb/modern/cursor-3.html.
- storage/indexeddb/modern/resources/cursor-4.js: Copied from LayoutTests/storage/indexeddb/modern/cursor-4.html.
- storage/indexeddb/modern/resources/cursor-5.js: Copied from LayoutTests/storage/indexeddb/modern/cursor-5.html.
- storage/indexeddb/modern/resources/cursor-6.js: Copied from LayoutTests/storage/indexeddb/modern/cursor-6.html.
- storage/indexeddb/modern/resources/cursor-7.js: Copied from LayoutTests/storage/indexeddb/modern/cursor-7.html.
- storage/indexeddb/modern/resources/cursor-8.js: Copied from LayoutTests/storage/indexeddb/modern/cursor-8.html.
- storage/indexeddb/modern/resources/date-basic.js: Copied from LayoutTests/storage/indexeddb/modern/date-basic.html.
- storage/indexeddb/modern/resources/deletedatabase-1.js: Copied from LayoutTests/storage/indexeddb/modern/deletedatabase-1.html.
- storage/indexeddb/modern/resources/deletedatabase-2.js: Copied from LayoutTests/storage/indexeddb/modern/deletedatabase-2.html.
- storage/indexeddb/modern/resources/deletedatabase-null-name-exception.js: Added.
- storage/indexeddb/modern/resources/deletedatabase-request-event.js: Copied from LayoutTests/storage/indexeddb/modern/deletedatabase-request-event.html.
- storage/indexeddb/modern/resources/deletedatabase-request.js: Added.
- storage/indexeddb/modern/resources/deleteindex-1.js: Copied from LayoutTests/storage/indexeddb/modern/deleteindex-1.html.
- storage/indexeddb/modern/resources/deleteindex-2.js: Copied from LayoutTests/storage/indexeddb/modern/deleteindex-2.html.
- storage/indexeddb/modern/resources/deleteobjectstore-1.js: Copied from LayoutTests/storage/indexeddb/modern/deleteobjectstore-1.html.
- storage/indexeddb/modern/resources/double-abort.js: Copied from LayoutTests/storage/indexeddb/modern/double-abort.html.
- storage/indexeddb/modern/resources/double-open.js: Added.
- storage/indexeddb/modern/resources/get-index-failures.js: Copied from LayoutTests/storage/indexeddb/modern/get-index-failures.html.
- storage/indexeddb/modern/resources/get-keyrange.js: Copied from LayoutTests/storage/indexeddb/modern/get-keyrange.html.
- storage/indexeddb/modern/resources/idbdatabase-deleteobjectstore-failures.js: Copied from LayoutTests/storage/indexeddb/modern/idbdatabase-deleteobjectstore-failures.html.
- storage/indexeddb/modern/resources/idbdatabase-transaction-failures.js: Copied from LayoutTests/storage/indexeddb/modern/idbdatabase-transaction-failures.html.
- storage/indexeddb/modern/resources/idbindex-properties-basic.js: Copied from LayoutTests/storage/indexeddb/modern/idbindex-properties-basic.html.
- storage/indexeddb/modern/resources/idbobjectstore-clear-1.js: Copied from LayoutTests/storage/indexeddb/modern/idbobjectstore-clear-1.html.
- storage/indexeddb/modern/resources/idbobjectstore-clear-2.js: Copied from LayoutTests/storage/indexeddb/modern/idbobjectstore-clear-2.html.
- storage/indexeddb/modern/resources/idbobjectstore-count-1.js: Copied from LayoutTests/storage/indexeddb/modern/idbobjectstore-count-1.html.
- storage/indexeddb/modern/resources/idbobjectstore-count-failures.js: Copied from LayoutTests/storage/indexeddb/modern/idbobjectstore-count-failures.html.
- storage/indexeddb/modern/resources/idbobjectstore-delete-1.js: Copied from LayoutTests/storage/indexeddb/modern/idbobjectstore-delete-1.html.
- storage/indexeddb/modern/resources/idbobjectstore-delete-2.js: Copied from LayoutTests/storage/indexeddb/modern/idbobjectstore-delete-2.html.
- storage/indexeddb/modern/resources/idbobjectstore-delete-failures.js: Copied from LayoutTests/storage/indexeddb/modern/idbobjectstore-delete-failures.html.
- storage/indexeddb/modern/resources/idbobjectstore-get-failures.js: Copied from LayoutTests/storage/indexeddb/modern/idbobjectstore-get-failures.html.
- storage/indexeddb/modern/resources/idbobjectstore-put-and-clear-failures.js: Copied from LayoutTests/storage/indexeddb/modern/idbobjectstore-put-and-clear-failures.html.
- storage/indexeddb/modern/resources/idbtransaction-objectstore-failures.js: Added.
- storage/indexeddb/modern/resources/index-1.js: Copied from LayoutTests/storage/indexeddb/modern/index-1.html.
- storage/indexeddb/modern/resources/index-2.js: Copied from LayoutTests/storage/indexeddb/modern/index-2.html.
- storage/indexeddb/modern/resources/index-3.js: Copied from LayoutTests/storage/indexeddb/modern/index-3.html.
- storage/indexeddb/modern/resources/index-4.js: Copied from LayoutTests/storage/indexeddb/modern/index-4.html.
- storage/indexeddb/modern/resources/index-5.js: Copied from LayoutTests/storage/indexeddb/modern/index-5.html.
- storage/indexeddb/modern/resources/index-cursor-1.js: Copied from LayoutTests/storage/indexeddb/modern/index-cursor-1.html.
- storage/indexeddb/modern/resources/index-cursor-2.js: Copied from LayoutTests/storage/indexeddb/modern/index-cursor-2.html.
- storage/indexeddb/modern/resources/index-cursor-3.js: Copied from LayoutTests/storage/indexeddb/modern/index-cursor-3.html.
- storage/indexeddb/modern/resources/index-get-count-basic.js: Copied from LayoutTests/storage/indexeddb/modern/index-get-count-basic.html.
- storage/indexeddb/modern/resources/index-get-count-failures.js: Copied from LayoutTests/storage/indexeddb/modern/index-get-count-failures.html.
- storage/indexeddb/modern/resources/keypath-basic.js: Copied from LayoutTests/storage/indexeddb/modern/keypath-basic.html.
- storage/indexeddb/modern/resources/objectstore-attributes.js: Copied from LayoutTests/storage/indexeddb/modern/objectstore-attributes.html.
- storage/indexeddb/modern/resources/objectstore-cursor-advance-failures.js: Copied from LayoutTests/storage/indexeddb/modern/objectstore-cursor-advance-failures.html.
- storage/indexeddb/modern/resources/objectstore-cursor-continue-failures.js: Copied from LayoutTests/storage/indexeddb/modern/objectstore-cursor-continue-failures.html.
- storage/indexeddb/modern/resources/opencursor-failures.js: Copied from LayoutTests/storage/indexeddb/modern/opencursor-failures.html.
- storage/indexeddb/modern/resources/opendatabase-request-event.js: Added.
- storage/indexeddb/modern/resources/opendatabase-request.js: Copied from LayoutTests/storage/indexeddb/modern/opendatabase-request.html.
- storage/indexeddb/modern/resources/opendatabase-success-after-versionchange.js: Copied from LayoutTests/storage/indexeddb/modern/opendatabase-success-after-versionchange.html.
- storage/indexeddb/modern/resources/opendatabase-versions.js: Copied from LayoutTests/storage/indexeddb/modern/opendatabase-versions.html.
- storage/indexeddb/modern/resources/request-readystate.js: Added.
- storage/indexeddb/modern/resources/transaction-scheduler-1.js: Copied from LayoutTests/storage/indexeddb/modern/transaction-scheduler-1.html.
- storage/indexeddb/modern/resources/transaction-scheduler-2.js: Copied from LayoutTests/storage/indexeddb/modern/transaction-scheduler-2.html.
- storage/indexeddb/modern/resources/transaction-scheduler-3.js: Copied from LayoutTests/storage/indexeddb/modern/transaction-scheduler-3.html.
- storage/indexeddb/modern/resources/transaction-scheduler-5.js: Copied from LayoutTests/storage/indexeddb/modern/transaction-scheduler-5.html.
- storage/indexeddb/modern/resources/transaction-scheduler-6.js: Copied from LayoutTests/storage/indexeddb/modern/transaction-scheduler-6.html.
- storage/indexeddb/modern/resources/transactions-stop-on-navigation-2.html:
- storage/indexeddb/modern/resources/versionchange-abort-then-reopen.js: Copied from LayoutTests/storage/indexeddb/modern/versionchange-abort-then-reopen.html.
- storage/indexeddb/modern/resources/versionchange-event.js: Copied from LayoutTests/storage/indexeddb/modern/versionchange-event.html.
- storage/indexeddb/modern/transaction-scheduler-1-expected.txt:
- storage/indexeddb/modern/transaction-scheduler-1.html:
- storage/indexeddb/modern/transaction-scheduler-2-expected.txt:
- storage/indexeddb/modern/transaction-scheduler-2.html:
- storage/indexeddb/modern/transaction-scheduler-3-expected.txt:
- storage/indexeddb/modern/transaction-scheduler-3.html:
- storage/indexeddb/modern/transaction-scheduler-5-expected.txt:
- storage/indexeddb/modern/transaction-scheduler-5.html:
- storage/indexeddb/modern/transaction-scheduler-6-expected.txt:
- storage/indexeddb/modern/transaction-scheduler-6.html:
- storage/indexeddb/modern/transactions-stop-on-navigation-expected.txt:
- storage/indexeddb/modern/versionchange-abort-then-reopen-expected.txt:
- storage/indexeddb/modern/versionchange-abort-then-reopen.html:
- storage/indexeddb/modern/versionchange-event-expected.txt:
- storage/indexeddb/modern/versionchange-event.html:
- 3:17 PM Changeset in webkit [195320] by
-
- 1 edit in branches/safari-601-branch/Source/WebCore/platform/mock/MediaPlaybackTargetPickerMock.cpp
Release build fix.
- 3:15 PM Changeset in webkit [195319] by
-
- 5 edits in trunk/Source/JavaScriptCore
[JSC] fixSpillSlotZDef() crashes on ARM64
https://bugs.webkit.org/show_bug.cgi?id=153246
Patch by Benjamin Poulain <bpoulain@apple.com> on 2016-01-19
Reviewed by Geoffrey Garen.
Moving an immediate to memory is not a valid instruction on ARM64.
This patch adds a small workaround for this specific case: an instruction
to zero a chunk of memory.
- assembler/MacroAssemblerARM64.h:
(JSC::MacroAssemblerARM64::storeZero32):
- assembler/MacroAssemblerX86Common.h:
(JSC::MacroAssemblerX86Common::storeZero32):
- b3/air/AirFixSpillSlotZDef.h:
(JSC::B3::Air::fixSpillSlotZDef):
- b3/air/AirOpcode.opcodes:
- 3:03 PM Changeset in webkit [195318] by
-
- 2 edits in trunk/Source/WebInspectorUI
REGRESSION: Web Inspector: Hovering linkified node references should show node highlight
https://bugs.webkit.org/show_bug.cgi?id=153248
<rdar://problem/24245518>
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-01-19
Reviewed by Timothy Hatcher.
- UserInterface/Base/DOMUtilities.js:
Show the complete node highlight details (colors and node info).
- 2:58 PM Changeset in webkit [195317] by
-
- 21 edits2 moves in trunk/Source
Add support for DataDetectors in WK (iOS).
https://bugs.webkit.org/show_bug.cgi?id=152989
rdar://problem/22855960
Reviewed by Tim Horton.
Source/JavaScriptCore:
Adding feature definition for data detection.
- Configurations/FeatureDefines.xcconfig:
Source/WebCore:
This is the first step toward implementing Data Detectors support
in WK2. The patch adds a new memeber to the Settings object
to retrieve the type of detection desired. The DataDetection files
have been moved under cocoa, since they are no longer OS X specific.
- Configurations/FeatureDefines.xcconfig:
- Configurations/WebCore.xcconfig:
- WebCore.xcodeproj/project.pbxproj:
- editing/cocoa/DataDetection.h: Copied from Source/WebCore/editing/mac/DataDetection.h.
- editing/cocoa/DataDetection.mm: Copied from Source/WebCore/editing/mac/DataDetection.mm.
(WebCore::detectItemAtPositionWithRange):
(WebCore::DataDetection::detectItemAroundHitTestResult):
(WebCore::DataDetection::detectContentInRange):
- editing/mac/DataDetection.h: Removed.
- editing/mac/DataDetection.mm: Removed.
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::checkLoadCompleteForThisFrame):
- page/Settings.h:
- page/Settings.in:
- platform/spi/mac/DataDetectorsSPI.h:
Source/WebKit/mac:
Adding feature definition for data detection.
- Configurations/FeatureDefines.xcconfig:
Source/WebKit2:
This is the first step toward implementing Data Detectors support
in WK2. The patch adds a new property to the configuration
object to indicate the type of detection desired and propagates
to the WebProcess.
- Configurations/FeatureDefines.xcconfig:
- Shared/WebPreferencesDefinitions.h:
- UIProcess/API/Cocoa/WKWebView.mm:
(fromWKDataDetectorTypes):
(-[WKWebView initWithFrame:configuration:]):
- UIProcess/API/Cocoa/WKWebViewConfiguration.h:
- UIProcess/API/Cocoa/WKWebViewConfiguration.mm:
(-[WKWebViewConfiguration copyWithZone:]):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences):
Source/WTF:
Adding feature definition for data detection.
- wtf/FeatureDefines.h:
- 2:37 PM Changeset in webkit [195316] by
-
- 6 edits in branches/safari-601-branch/Source/WebInspectorUI
Merge r194920. rdar://problem/24208104
- 2:01 PM Changeset in webkit [195315] by
-
- 4 edits in trunk/Source/WebCore
SVG 2 requires a mechanism for restricting enum values exposed through the DOM
https://bugs.webkit.org/show_bug.cgi?id=152814
Patch by Nikos Andronikos <nikos.andronikos-webkit@cisra.canon.com.au> on 2016-01-19
Reviewed by Darin Adler.
No new tests (No change in functionality, blocked bugs add new tests).
This patch adds a mechanism to restrict the values returned through the
SVGAnimatedEnumeration interface.
This is required for SVG 2, which does not expose new enumeration
values through the IDL.
See http://www.w3.org/TR/SVG2/types.html#InterfaceSVGAnimatedEnumeration
Getters:
SVG 2 does not add numeric type values for new options, new options
should return UNKNOWN.
E.g. See the table defining numeric type values for orient at
http://www.w3.org/TR/SVG2/painting.html#InterfaceSVGMarkerElement
Setters:
On setting baseVal, the following steps are run:
- ...
- If value is 0 or is not the numeric type value for any value of the reflected attribute, then set the reflected attribute to the empty string.
- svg/properties/SVGAnimatedEnumerationPropertyTearOff.h:
Override baseVal() and animVal() to perform range checks against
the highest exposed enum value.
- svg/properties/SVGAnimatedStaticPropertyTearOff.h:
(WebCore::SVGAnimatedStaticPropertyTearOff::baseVal): Mark function as virtual as it's over-ridden for enumerations.
(WebCore::SVGAnimatedStaticPropertyTearOff::animVal): Mark function as virtual as it's over-ridden for enumerations.
- svg/properties/SVGPropertyTraits.h:
Add SVGIDLEnumLimits struct that contains function for querying the
highest exposed enum value.
(WebCore::SVGIDLEnumLimits::highestExposedEnumValue): New function that returns the highest enum value that should
be exposed through the DOM. This function should be specialized for enum types that need to restrict the exposed
values.
- 1:49 PM Changeset in webkit [195314] by
-
- 3 edits in trunk/Source/JavaScriptCore
[B3][Win64] Compile and warning fixes.
https://bugs.webkit.org/show_bug.cgi?id=153234
Reviewed by Alex Christensen.
The size of 'long' is 4 bytes on Win64. We can use 'long long' instead,
when we want the size to be 8 bytes.
- b3/B3LowerMacrosAfterOptimizations.cpp:
- b3/B3ReduceStrength.cpp:
- 1:48 PM Changeset in webkit [195313] by
-
- 2 edits in trunk/Source/JavaScriptCore
[cmake] Fix the B3 build after r195159
https://bugs.webkit.org/show_bug.cgi?id=153232
Reviewed by Yusuke Suzuki.
- CMakeLists.txt:
- 1:48 PM Changeset in webkit [195312] by
-
- 2 edits in trunk/Source/WebCore
Fixed compilation of AXObjectCache in case of !HAVE(ACCESSIBILITY).
https://bugs.webkit.org/show_bug.cgi?id=153243
Patch by Konstantin Tokarev <Konstantin Tokarev> on 2016-01-19
Reviewed by Chris Fleizach.
No new tests needed.
- accessibility/AXObjectCache.h:
(WebCore::AXObjectCache::AXObjectCache):
(WebCore::nodeHasRole): Deleted.
- 1:26 PM Changeset in webkit [195311] by
-
- 5 edits in trunk/Source/WebCore
Use references in SelectorChecker
https://bugs.webkit.org/show_bug.cgi?id=153240
Reviewed by Andreas Kling.
Element and selector can't be null in most places.
- css/ElementRuleCollector.cpp:
(WebCore::ElementRuleCollector::collectMatchingRules):
- css/SelectorChecker.cpp:
(WebCore::attributeValueMatches):
(WebCore::anyAttributeMatches):
(WebCore::SelectorChecker::checkOne):
(WebCore::SelectorChecker::matchSelectorList):
(WebCore::SelectorChecker::checkScrollbarPseudoClass):
(WebCore::SelectorChecker::determineLinkMatchType):
(WebCore::isFrameFocused):
(WebCore::SelectorChecker::matchesFocusPseudoClass):
- css/SelectorChecker.h:
(WebCore::SelectorChecker::isCommonPseudoClassSelector):
(WebCore::SelectorChecker::checkExactAttribute): Deleted.
- css/SelectorCheckerTestFunctions.h:
(WebCore::isAutofilled):
(WebCore::isDefaultButtonForForm):
(WebCore::isDisabled):
(WebCore::isEnabled):
(WebCore::isMediaDocument):
(WebCore::isChecked):
(WebCore::isInRange):
(WebCore::isOutOfRange):
(WebCore::isInvalid):
(WebCore::isOptionalFormControl):
(WebCore::isRequiredFormControl):
(WebCore::isValid):
(WebCore::isWindowInactive):
(WebCore::containslanguageSubtagMatchingRange):
(WebCore::matchesLangPseudoClass):
(WebCore::matchesReadOnlyPseudoClass):
(WebCore::matchesReadWritePseudoClass):
(WebCore::shouldAppearIndeterminate):
(WebCore::scrollbarMatchesEnabledPseudoClass):
(WebCore::scrollbarMatchesCornerPresentPseudoClass):
(WebCore::matchesFullScreenPseudoClass):
(WebCore::matchesFullScreenAnimatingFullScreenTransitionPseudoClass):
(WebCore::matchesFullScreenAncestorPseudoClass):
(WebCore::matchesFullScreenDocumentPseudoClass):
(WebCore::matchesFutureCuePseudoClass):
(WebCore::matchesPastCuePseudoClass):
- 1:00 PM Changeset in webkit [195310] by
-
- 4 edits in trunk/Source/WebCore
Unreviewed, rolling out r195179.
It relies on r195141 which was rolled out
Reverted changeset:
"Allocate style sheet media queries in BumpArena."
https://bugs.webkit.org/show_bug.cgi?id=153188
http://trac.webkit.org/changeset/195179
- 12:59 PM Changeset in webkit [195309] by
-
- 3 edits in trunk/Source/WebCore
Unreviewed, rolling out r195173.
It relies on r195141 which was rolled out
Reverted changeset:
"Give RuleSet a BumpArena and start using it for
RuleDataVectors."
https://bugs.webkit.org/show_bug.cgi?id=153169
http://trac.webkit.org/changeset/195173
- 12:56 PM Changeset in webkit [195308] by
-
- 23 edits2 moves1 delete in trunk/Source
Unreviewed, rolling out r195300.
https://bugs.webkit.org/show_bug.cgi?id=153244
enrica wants more time to fix Windows (Requested by thorton on
#webkit).
Reverted changeset:
"Add support for DataDetectors in WK (iOS)."
https://bugs.webkit.org/show_bug.cgi?id=152989
http://trac.webkit.org/changeset/195300
- 12:55 PM Changeset in webkit [195307] by
-
- 7 edits1 add in trunk/Source/JavaScriptCore
Reconsider B3's constant motion policy
https://bugs.webkit.org/show_bug.cgi?id=152202
Reviewed by Geoffrey Garen.
This changes moveConstants() to hoist constants. This is a speed-up on things like mandreel.
It has a generally positive impact on the Octane score, but it's within margin of error.
This also changes IRC to make it a bit more likely to spill constants. We don't want it to
spill them too much, because we can't rely on fixObviousSpills() to always replace a load of
a constant from the stack with the constant itself, especially in case of instructions that
need an extra register to materialize the immediate.
Also fixed DFG graph dumping to print a bit less things. It was trying to print the results of
constant property inference, and this sometimes caused crashes when you dumped the graph at an
inopportune time.
- JavaScriptCore.xcodeproj/project.pbxproj:
- b3/B3MoveConstants.cpp:
- b3/air/AirArg.h:
- b3/air/AirArgInlines.h: Added.
(JSC::B3::Air::ArgThingHelper<Tmp>::is):
(JSC::B3::Air::ArgThingHelper<Tmp>::as):
(JSC::B3::Air::ArgThingHelper<Tmp>::forEachFast):
(JSC::B3::Air::ArgThingHelper<Tmp>::forEach):
(JSC::B3::Air::ArgThingHelper<Arg>::is):
(JSC::B3::Air::ArgThingHelper<Arg>::as):
(JSC::B3::Air::ArgThingHelper<Arg>::forEachFast):
(JSC::B3::Air::ArgThingHelper<Arg>::forEach):
(JSC::B3::Air::Arg::is):
(JSC::B3::Air::Arg::as):
(JSC::B3::Air::Arg::forEachFast):
(JSC::B3::Air::Arg::forEach):
- b3/air/AirIteratedRegisterCoalescing.cpp:
- b3/air/AirUseCounts.h:
(JSC::B3::Air::UseCounts::UseCounts):
- dfg/DFGGraph.cpp:
(JSC::DFG::Graph::dump):
- 12:32 PM Changeset in webkit [195306] by
-
- 3 edits2 adds in trunk
outline-offset does not work for inlines.
https://bugs.webkit.org/show_bug.cgi?id=153238
Reviewed by Simon Fraser.
Adjust outline box width/height with outline-offset.
Test: fast/inline/inlines-with-outline-offset.html
Source/WebCore:
- rendering/RenderInline.cpp:
(WebCore::RenderInline::paintOutline):
(WebCore::RenderInline::paintOutlineForLine):
LayoutTests:
- fast/inline/inlines-with-outline-offset-expected.html: Added.
- fast/inline/inlines-with-outline-offset.html: Added.
- 12:20 PM Changeset in webkit [195305] by
-
- 9 edits6 adds in trunk
Web Inspector: WebInspector.Object.addEventListener is O(n), make it O(1)
https://bugs.webkit.org/show_bug.cgi?id=152422
<rdar://problem/24038047>
Reviewed by Timothy Hatcher.
Source/WebInspectorUI:
Slow addEventListener was the main cause of Console sluggishness[1].
This patch changes:
addEventListener from O(n) to O(1)
removeEventListener from O(n) to O(1)
Now, addEventListener and removeEventListener take <1ms regardless of the
number of listeners attached.
removeEventListener(null, null, thisObject), a special case when all events
for thisObject are removed, was improved from O(n2) to O(n).
- UserInterface/Base/LinkedList.js: Added.
(LinkedList):
(LinkedList.prototype.clear):
(LinkedList.prototype.get last):
(LinkedList.prototype.push):
(LinkedList.prototype.remove):
(LinkedList.prototype.forEach):
(LinkedList.prototype.toArray):
(LinkedList.prototype.toJSON):
(LinkedListNode):
LinkedList ensures O(1) time complexity for push and remove operations.
- UserInterface/Base/ListMultimap.js: Added.
(ListMultimap):
(ListMultimap.prototype.get size):
(ListMultimap.prototype.add):
(ListMultimap.prototype.delete):
(ListMultimap.prototype.deleteAll):
(ListMultimap.prototype.has):
(ListMultimap.prototype.clear):
(ListMultimap.prototype.forEach):
(ListMultimap.prototype.toArray):
(ListMultimap.prototype.toJSON):
ListMultimap unsures O(1) time complexity for add, has and delete operations.
ListMultimap preserves insertion order by using a LinkedList.
- UserInterface/Base/Object.js:
(WebInspector.Object):
(WebInspector.Object.addEventListener):
(WebInspector.Object.removeEventListener):
(WebInspector.Object.hasEventListeners):
(WebInspector.Object.retainedObjectsWithPrototype):
(WebInspector.Object.prototype.dispatchEventToListeners):
Replace this._listeners[eventType] from array of objects to ListMultimap.
- UserInterface/Main.html:
- UserInterface/Test.html:
- UserInterface/TestStub.html:
LayoutTests:
- inspector/console/console-api-expected.txt:
- inspector/console/console-table-expected.txt:
- inspector/model/remote-object-expected.txt:
Rebaseline tests, add "_listeners: null" to all WebInspector.Object instances.
- inspector/unit-tests/linked-list-expected.txt: Added.
- inspector/unit-tests/linked-list.html: Added.
- inspector/unit-tests/list-multimap-expected.txt: Added.
- inspector/unit-tests/list-multimap.html: Added.
- 12:16 PM Changeset in webkit [195304] by
-
- 23 edits2 deletes in trunk/Source
Unreviewed, rolling out r195141.
Seems to cause crashes on iOS9 64bit
Reverted changeset:
"Fragmentation-free allocator for timeless and/or coupled
allocations."
https://bugs.webkit.org/show_bug.cgi?id=152696
http://trac.webkit.org/changeset/195141
- 11:53 AM Changeset in webkit [195303] by
-
- 50 edits1 add in trunk/Source/WebInspectorUI
Web Inspector: cleanup TreeOutline class and separate styles from NavigationSidebarPanel
https://bugs.webkit.org/show_bug.cgi?id=153146
<rdar://problem/24213071>
Reviewed by Timothy Hatcher.
This patch consolidates and simplifies the tree outline styles that were previously
defined across various classes. A new stylesheet, TreeOutline.css, includes all
the styles needed to create a basic TreeOutline.
In addition, certain tree features which were previously controlled by manually
toggling class names have been promoted to properties of TreeOutline:
- compact: tree elements have reduced vertical spacing. Used by object trees. The compact and large settings are mutually exclusive.
- large: tree elements (and their icons) are large. Used by TimelinesSidebarPanel.
Previously there existed a
smallclass name which was enabled in every case except TimelineSidebarPanel's Timelines tree. Since it was the rule rather than the exception the class has been removed and is now the default style. - disclosureButtons: control the appearance of disclosure buttons.
- customIndent: control use of generated style rules.
- UserInterface/Main.html:
New CSS file.
- UserInterface/Views/ApplicationCacheFrameTreeElement.js:
(WebInspector.ApplicationCacheFrameTreeElement): Deleted.
- UserInterface/Views/BreakpointTreeElement.js:
(WebInspector.BreakpointTreeElement): Deleted.
- UserInterface/Views/CallFrameTreeElement.js:
(WebInspector.CallFrameTreeElement): Deleted.
- UserInterface/Views/ContentFlowTreeElement.js:
(WebInspector.ContentFlowTreeElement): Deleted.
Removed call to obsolete TreeOutline.prototype.small setter.
- UserInterface/Views/DOMTreeOutline.css:
(.tree-outline.dom):
(.tree-outline.dom li.hovered:not(.selected) .selection):
(.tree-outline.dom li .selection):
(.tree-outline.dom li.selected .selection):
(.tree-outline.dom li.elements-drag-over .selection):
(.tree-outline.dom:focus li.selected .selection):
(.tree-outline.dom li.selected > span::after):
(.tree-outline.dom:focus li.selected > span::after):
(.tree-outline.dom ol):
(.tree-outline.dom ol.children):
(.tree-outline.dom ol.children.expanded):
(.tree-outline.dom li):
(.tree-outline.dom li.pseudo-class-enabled > .selection::before):
(.tree-outline.dom.single-node li):
(.tree-outline.dom:focus li.selected):
(.tree-outline.dom:focus li.selected.pseudo-class-enabled > .selection::before):
(.tree-outline.dom:focus li.selected *):
(.tree-outline.dom li.parent):
(.tree-outline.dom li .html-tag.close):
(.tree-outline.dom li.parent::before):
(.tree-outline.dom:focus li.parent.selected::before):
(.tree-outline.dom li.parent.expanded::before):
(.tree-outline.dom:focus li.parent.expanded.selected::before):
(.tree-outline.dom .html-text-node.large):
(.tree-outline.dom .html-pseudo-element):
(.tree-outline.dom .html-fragment.shadow):
(.showing-find-banner .tree-outline.dom .search-highlight):
(.dom-tree-outline): Deleted.
(.dom-tree-outline li.hovered:not(.selected) .selection): Deleted.
(.dom-tree-outline li .selection): Deleted.
(.dom-tree-outline li.selected .selection): Deleted.
(.dom-tree-outline li.elements-drag-over .selection): Deleted.
(.dom-tree-outline:focus li.selected .selection): Deleted.
(.dom-tree-outline li.selected > span::after): Deleted.
(.dom-tree-outline:focus li.selected > span::after): Deleted.
(.dom-tree-outline ol): Deleted.
(.dom-tree-outline ol.children): Deleted.
(.dom-tree-outline ol.children.expanded): Deleted.
(.dom-tree-outline li): Deleted.
(.dom-tree-outline li.pseudo-class-enabled > .selection::before): Deleted.
(.dom-tree-outline.single-node li): Deleted.
(.dom-tree-outline:focus li.selected): Deleted.
(.dom-tree-outline:focus li.selected.pseudo-class-enabled > .selection::before): Deleted.
(.dom-tree-outline:focus li.selected *): Deleted.
(.dom-tree-outline li.parent): Deleted.
(.dom-tree-outline li .html-tag.close): Deleted.
(.dom-tree-outline li.parent::before): Deleted.
(.dom-tree-outline:focus li.parent.selected::before): Deleted.
(.dom-tree-outline li.parent.expanded::before): Deleted.
(.dom-tree-outline:focus li.parent.expanded.selected::before): Deleted.
(.dom-tree-outline .html-text-node.large): Deleted.
(.dom-tree-outline .html-pseudo-element): Deleted.
(.dom-tree-outline .html-fragment.shadow): Deleted.
(.showing-find-banner .dom-tree-outline .search-highlight): Deleted.
Updated selectors with new tree outline class names.
- UserInterface/Views/DOMTreeOutline.js:
(WebInspector.DOMTreeOutline):
Use default TreeOutline DOM element, and simplify element class name.
- UserInterface/Views/DatabaseTableTreeElement.js:
(WebInspector.DatabaseTableTreeElement): Deleted.
- UserInterface/Views/DatabaseTreeElement.js:
(WebInspector.DatabaseTreeElement): Deleted.
Removed call to obsolete TreeOutline.prototype.small setter.
- UserInterface/Views/ErrorObjectView.css:
(.error-object:not(.expanded) .tree-outline):
(.error-object .tree-outline):
(.error-object:not(.expanded) .error-object-outline): Deleted.
(.error-object-outline): Deleted.
Updated selectors with new tree outline class names.
- UserInterface/Views/ErrorObjectView.js:
(WebInspector.ErrorObjectView): Deleted.
Removed unused tree outline class name.
- UserInterface/Views/FolderTreeElement.js:
(WebInspector.FolderTreeElement): Deleted.
Removed call to obsolete TreeOutline.prototype.small setter.
- UserInterface/Views/FormattedValue.css:
(.formatted-node > .tree-outline.dom):
(.formatted-node > .tree-outline.dom ol):
(.formatted-node > .tree-outline.dom li):
(.formatted-node > .tree-outline.dom li.hovered:not(.selected) .selection):
(.formatted-node > .dom-tree-outline): Deleted.
(.formatted-node > .dom-tree-outline ol): Deleted.
(.formatted-node > .dom-tree-outline li): Deleted.
(.formatted-node > .dom-tree-outline li.hovered:not(.selected) .selection): Deleted.
Updated selectors with new tree outline class names.
- UserInterface/Views/GeneralTreeElement.js:
(WebInspector.GeneralTreeElement.prototype._updateTitleTooltip):
(WebInspector.GeneralTreeElement.prototype.get small): Deleted.
(WebInspector.GeneralTreeElement.prototype.set small): Deleted.
(WebInspector.GeneralTreeElement.prototype.get twoLine): Deleted.
(WebInspector.GeneralTreeElement.prototype.set twoLine): Deleted.
Removed propertiessmallandtwoLine. The first is no longer needed as
it is now the default tree element style. The second was not being used.
- UserInterface/Views/IndexedDatabaseObjectStoreIndexTreeElement.js:
(WebInspector.IndexedDatabaseObjectStoreIndexTreeElement): Deleted.
- UserInterface/Views/IndexedDatabaseObjectStoreTreeElement.js:
(WebInspector.IndexedDatabaseObjectStoreTreeElement): Deleted.
- UserInterface/Views/IndexedDatabaseTreeElement.js:
(WebInspector.IndexedDatabaseTreeElement): Deleted.
Removed call to obsolete TreeOutline.prototype.small setter.
- UserInterface/Views/IssueTreeElement.css:
(.navigation-sidebar-panel-content-tree-outline .item.small.issue .icon): Deleted.
No longer needed.
- UserInterface/Views/IssueTreeElement.js:
(WebInspector.IssueTreeElement): Deleted.
Removed call to obsolete TreeOutline.prototype.small setter.
- UserInterface/Views/LayoutTimelineView.css:
(.sidebar > .panel.navigation.timeline.timeline-recording-content-view-showing .tree-outline.layout .item .subtitle):
(.sidebar > .panel.navigation.timeline.timeline-recording-content-view-showing .navigation-sidebar-panel-content-tree-outline.layout .item .subtitle): Deleted.
Updated selectors with new tree outline class names.
- UserInterface/Views/LogTreeElement.js:
(WebInspector.LogTreeElement): Deleted.
Removed call to obsolete TreeOutline.prototype.small setter.
- UserInterface/Views/NavigationSidebarPanel.css:
(.navigation-sidebar-panel-content-tree-outline .children): Deleted.
(.navigation-sidebar-panel-content-tree-outline .children.expanded): Deleted.
(.navigation-sidebar-panel-content-tree-outline .item): Deleted.
(.navigation-sidebar-panel-content-tree-outline.hide-disclosure-buttons > .children): Deleted.
(.navigation-sidebar-panel-content-tree-outline > .children.hide-disclosure-buttons > .children): Deleted.
(.navigation-sidebar-panel-content-tree-outline:not(.hide-disclosure-buttons) .item:not(.parent) .icon): Deleted.
(.navigation-sidebar-panel-content-tree-outline.hide-disclosure-buttons .item.small): Deleted.
(.navigation-sidebar-panel-content-tree-outline .item .disclosure-button): Deleted.
(.navigation-sidebar-panel-content-tree-outline.hide-disclosure-buttons .item .disclosure-button): Deleted.
(.navigation-sidebar-panel-content-tree-outline .item.parent .disclosure-button): Deleted.
(.navigation-sidebar-panel-content-tree-outline:matches(:focus, .force-focus) .item.selected .disclosure-button): Deleted.
(.navigation-sidebar-panel-content-tree-outline .item.expanded .disclosure-button): Deleted.
(.navigation-sidebar-panel-content-tree-outline:matches(:focus, .force-focus) .item.selected.expanded .disclosure-button): Deleted.
(.navigation-sidebar-panel-content-tree-outline .item .icon): Deleted.
(.navigation-sidebar-panel-content-tree-outline .item .status): Deleted.
(.navigation-sidebar-panel-content-tree-outline .item .status:empty): Deleted.
(.navigation-sidebar-panel-content-tree-outline .item.selected): Deleted.
(.navigation-sidebar-panel-content-tree-outline:matches(:focus, .force-focus) .item.selected): Deleted.
(body.window-inactive .navigation-sidebar-panel-content-tree-outline .item.selected): Deleted.
(.navigation-sidebar-panel-content-tree-outline .item .titles): Deleted.
(.navigation-sidebar-panel-content-tree-outline .item .highlighted): Deleted.
(.navigation-sidebar-panel-content-tree-outline .item .titles.no-subtitle): Deleted.
(.navigation-sidebar-panel-content-tree-outline .item .title::after): Deleted.
(.navigation-sidebar-panel-content-tree-outline .item .subtitle): Deleted.
(.navigation-sidebar-panel-content-tree-outline:matches(:focus, .force-focus) .item.selected .subtitle): Deleted.
(.navigation-sidebar-panel-content-tree-outline .item .subtitle:empty): Deleted.
(.navigation-sidebar-panel-content-tree-outline .item.small): Deleted.
(.navigation-sidebar-panel-content-tree-outline .item.small.two-line): Deleted.
(.navigation-sidebar-panel-content-tree-outline .item.small .icon): Deleted.
(.navigation-sidebar-panel-content-tree-outline .item.small .status): Deleted.
(.navigation-sidebar-panel-content-tree-outline .item.small .status .indeterminate-progress-spinner): Deleted.
(.navigation-sidebar-panel-content-tree-outline .item.small .titles): Deleted.
(.navigation-sidebar-panel-content-tree-outline .item.small.two-line .status): Deleted.
(.navigation-sidebar-panel-content-tree-outline .item.small.two-line .titles): Deleted.
(.navigation-sidebar-panel-content-tree-outline .item.small.two-line .titles.no-subtitle): Deleted.
(.navigation-sidebar-panel-content-tree-outline .item.small .subtitle): Deleted.
(.navigation-sidebar-panel-content-tree-outline .item.small.two-line .icon): Deleted.
(.navigation-sidebar-panel-content-tree-outline .item.small:not(.two-line) .title::after): Deleted.
(.navigation-sidebar-panel-content-tree-outline .item.small:not(.two-line) .subtitle::before): Deleted.
Generic tree outline styles removed, cleaned up, and relocated to TreeOutline.css.
- UserInterface/Views/NavigationSidebarPanel.js:
Removed static property HideDisclosureButtonsStyleClassName, which is now
encapsulated by TreeOutline.
(WebInspector.NavigationSidebarPanel.prototype.createContentTreeOutline):
Use default TreeOutline DOM element instead of creating it.
(WebInspector.NavigationSidebarPanel): Deleted.
Remove call to generate style rules.
(WebInspector.NavigationSidebarPanel.prototype._generateStyleRulesIfNeeded): Deleted.
Moved to TreeOutline.js.
- UserInterface/Views/NetworkSidebarPanel.css:
(.sidebar > .panel.navigation.network.network-grid-content-view-showing .tree-outline.network-grid .item .subtitle):
(.sidebar > .panel.navigation.network > .content > .tree-outline):
(.sidebar > .panel.navigation.network.network-grid-content-view-showing > .content > .tree-outline):
(.sidebar > .panel.navigation.network.network-grid-content-view-showing .navigation-sidebar-panel-content-tree-outline.network-grid .item .subtitle): Deleted.
(.sidebar > .panel.navigation.network > .content > .navigation-sidebar-panel-content-tree-outline): Deleted.
(.sidebar > .panel.navigation.network.network-grid-content-view-showing > .content > .navigation-sidebar-panel-content-tree-outline): Deleted.
Updated selectors with new tree outline class names.
- UserInterface/Views/NetworkSidebarPanel.js:
(WebInspector.NetworkSidebarPanel):
Disable tree outline disclosure buttons.
- UserInterface/Views/NetworkTimelineView.css:
(.sidebar > .panel.navigation.timeline.timeline-recording-content-view-showing .tree-outline.network .item .subtitle):
(.sidebar > .panel.navigation.timeline.timeline-recording-content-view-showing .navigation-sidebar-panel-content-tree-outline.network .item .subtitle): Deleted.
Updated selectors with new tree outline class names.
- UserInterface/Views/NetworkTimelineView.js:
(WebInspector.NetworkTimelineView):
Disable tree outline disclosure buttons.
- UserInterface/Views/ObjectTreeArrayIndexTreeElement.css:
(.object-tree-array-index .index-value .object-tree .tree-outline.object):
(.object-tree-array-index .index-value .formatted-node .tree-outline.dom):
(.object-tree-array-index .index-value .object-tree .object-tree-outline): Deleted.
(.object-tree-array-index .index-value .formatted-node .dom-tree-outline): Deleted.
Updated selectors with new tree outline class names.
- UserInterface/Views/ObjectTreeBaseTreeElement.js:
(WebInspector.ObjectTreeBaseTreeElement): Deleted.
Removed call to obsolete TreeOutline.prototype.small setter.
- UserInterface/Views/ObjectTreePropertyTreeElement.css:
(.tree-outline .item.object-tree-property):
(.item.object-tree-property.prototype-property):
(.item.object-tree-property.prototype-property + ol):
(.object-tree-property): Deleted.
(.object-tree-property > .titles): Deleted.
(.object-tree-property > .disclosure-button): Deleted.
(.object-tree-property.parent > .disclosure-button): Deleted.
(.object-tree-property.parent.expanded > .disclosure-button): Deleted.
(.object-tree-property > .icon): Deleted.
(.object-tree-property.prototype-property): Deleted.
(.object-tree-property.prototype-property + ol): Deleted.
Updated selectors with new tree outline class names, removed styles which
are now provided by TreeOutline.css.
- UserInterface/Views/ObjectTreeView.css:
(.object-tree .tree-outline.object):
(.object-tree.expanded > .tree-outline.object):
(.tree-outline.object):
(.object-tree.properties-only .tree-outline.object):
(.tree-outline.object li):
(.tree-outline.object ol):
(.tree-outline.object ol.expanded):
(.tree-outline.object li .empty-message):
(.object-tree .object-tree-outline): Deleted.
(.object-tree.expanded > .object-tree-outline): Deleted.
(.object-tree-outline): Deleted.
(.object-tree.properties-only .object-tree-outline): Deleted.
(.object-tree-outline li): Deleted.
(.object-tree-outline ol): Deleted.
(.object-tree-outline ol.expanded): Deleted.
(.object-tree-outline li .empty-message): Deleted.
Updated selectors with new tree outline class names.
- UserInterface/Views/ObjectTreeView.js:
(WebInspector.ObjectTreeView):
Use default TreeOutline DOM element, and simplify element class name.
Enable custom indent (disables generated style rules).
- UserInterface/Views/ProfileNodeTreeElement.js:
(WebInspector.ProfileNodeTreeElement): Deleted.
Removed call to obsolete TreeOutline.prototype.small setter.
- UserInterface/Views/RenderingFrameTimelineView.css:
(.sidebar > .panel.navigation.timeline.timeline-recording-content-view-showing .tree-outline.rendering-frame .item:not(.paint-record):not(.layout-record) .subtitle):
(.sidebar > .panel.navigation.timeline.timeline-recording-content-view-showing .navigation-sidebar-panel-content-tree-outline.rendering-frame .item:not(.paint-record):not(.layout-record) .subtitle): Deleted.
Updated selectors with new tree outline class names.
- UserInterface/Views/ResourceSidebarPanel.js:
(WebInspector.ResourceSidebarPanel):
Disable tree outline disclosure buttons.
(WebInspector.ResourceSidebarPanel.prototype._extraDomainsActivated):
Enable tree outline disclosure buttons.
- UserInterface/Views/ScriptTimelineView.css:
(.sidebar > .panel.navigation.timeline.timeline-recording-content-view-showing .tree-outline.script .item .subtitle):
(.sidebar > .panel.navigation.timeline:not(.timeline-recording-content-view-showing) .tree-outline.script .item .alternate-subtitle):
(.tree-outline .item .alternate-subtitle):
(.tree-outline:matches(:focus, .force-focus) .item.selected .alternate-subtitle):
(.tree-outline .item.small:not(.two-line) .alternate-subtitle::before):
(.sidebar > .panel.navigation.timeline.timeline-recording-content-view-showing .navigation-sidebar-panel-content-tree-outline.script .item .subtitle): Deleted.
(.sidebar > .panel.navigation.timeline:not(.timeline-recording-content-view-showing) .navigation-sidebar-panel-content-tree-outline.script .item .alternate-subtitle): Deleted.
(.navigation-sidebar-panel-content-tree-outline .item .alternate-subtitle): Deleted.
(.navigation-sidebar-panel-content-tree-outline:matches(:focus, .force-focus) .item.selected .alternate-subtitle): Deleted.
(.navigation-sidebar-panel-content-tree-outline .item.small:not(.two-line) .alternate-subtitle::before): Deleted.
Updated selectors with new tree outline class names.
- UserInterface/Views/SearchResultTreeElement.js:
(WebInspector.SearchResultTreeElement): Deleted.
- UserInterface/Views/SourceCodeTreeElement.js:
(WebInspector.SourceCodeTreeElement): Deleted.
- UserInterface/Views/StorageTreeElement.js:
(WebInspector.StorageTreeElement): Deleted.
Removed call to obsolete TreeOutline.prototype.small setter.
- UserInterface/Views/TimelineDataGrid.css:
(.tree-outline.timeline-data-grid .item:hover):
(.tree-outline.timeline-data-grid .item:hover .subtitle):
(.timeline-data-grid-tree-outline): Deleted.
(.timeline-data-grid-tree-outline .item): Deleted.
(.timeline-data-grid-tree-outline .item .status): Deleted.
(.timeline-data-grid-tree-outline .item .icon): Deleted.
(.timeline-data-grid-tree-outline .item:hover): Deleted.
(.timeline-data-grid-tree-outline .item .titles): Deleted.
(.timeline-data-grid-tree-outline .item .title::after): Deleted.
(.timeline-data-grid-tree-outline .item .subtitle): Deleted.
(.timeline-data-grid-tree-outline .item:hover .subtitle): Deleted.
(.timeline-data-grid-tree-outline .item .subtitle:empty): Deleted.
(.timeline-data-grid-tree-outline .item.small): Deleted.
(.timeline-data-grid-tree-outline .item.small .icon): Deleted.
(.timeline-data-grid-tree-outline .item.small .status): Deleted.
(.timeline-data-grid-tree-outline .item.small .titles): Deleted.
(.timeline-data-grid-tree-outline .item.small .subtitle): Deleted.
(.timeline-data-grid-tree-outline .item.small:not(.two-line) .title::after): Deleted.
(.timeline-data-grid-tree-outline .item.small:not(.two-line) .subtitle::before): Deleted.
Updated selectors with new tree outline class names, removed styles which
are now provided by TreeOutline.css.
- UserInterface/Views/TimelineDataGrid.js:
(WebInspector.TimelineDataGrid.prototype._createPopoverContent):
Use default TreeOutline DOM element, and simplify element class name.
- UserInterface/Views/TimelineRecordTreeElement.js:
(WebInspector.TimelineRecordTreeElement): Deleted.
Removed call to obsolete TreeOutline.prototype.small setter.
- UserInterface/Views/TimelineSidebarPanel.css:
(.sidebar > .panel.navigation.timeline > .timelines-content .close-button): Deleted.
Removed styles which are now provided by TreeOutline.css.
- UserInterface/Views/TimelineSidebarPanel.js:
(WebInspector.TimelineSidebarPanel):
Disable tree outline disclosure buttons, enable large tree style.
- UserInterface/Views/TimelineView.css:
(.panel.navigation.timeline > .content > .tree-outline):
(.panel.navigation.timeline.timeline-recording-content-view-showing > .content > .tree-outline):
(.panel.navigation.timeline > .content > .navigation-sidebar-panel-content-tree-outline): Deleted.
(.panel.navigation.timeline.timeline-recording-content-view-showing > .content > .navigation-sidebar-panel-content-tree-outline): Deleted.
Updated selectors with new tree outline class names.
- UserInterface/Views/TreeOutline.css: Added.
(.tree-outline .children):
(.tree-outline .children.expanded):
(.tree-outline .item):
(.tree-outline.compact .item):
(.tree-outline.large .item):
(.tree-outline.hide-disclosure-buttons > .children):
(.tree-outline > .children.hide-disclosure-buttons > .children):
(.tree-outline:not(.hide-disclosure-buttons) .item:not(.parent) .icon):
(.tree-outline .item .disclosure-button):
(.tree-outline.hide-disclosure-buttons .item .disclosure-button):
(.tree-outline .item.parent .disclosure-button):
(.tree-outline:matches(:focus, .force-focus) .item.selected .disclosure-button):
(.tree-outline .item.expanded .disclosure-button):
(.tree-outline:matches(:focus, .force-focus) .item.selected.expanded .disclosure-button):
(.tree-outline .item .icon):
(.tree-outline.compact .item .icon):
(.tree-outline.large .item .icon):
(.tree-outline .item .status):
(.tree-outline.large .item .status):
(.tree-outline .item .status:empty):
(.tree-outline .item.selected):
(.tree-outline:matches(:focus, .force-focus) .item.selected):
(body.window-inactive .tree-outline .item.selected):
(.tree-outline .item .titles):
(.tree-outline.compact .item .titles):
(.tree-outline.large .item .titles):
(.tree-outline .item .highlighted):
(.tree-outline.large .item .titles.no-subtitle):
(.tree-outline .item .title::after):
(.tree-outline .item .subtitle):
(.tree-outline.large .item .subtitle):
(.tree-outline:matches(:focus, .force-focus) .item.selected .subtitle):
(.tree-outline .item .subtitle:empty):
(.tree-outline:not(.large) .item .status .indeterminate-progress-spinner):
(.tree-outline .item .subtitle::before):
Relocated tree outlines styles from NavigationSidebarPanel.css.
- UserInterface/Views/TreeOutline.js:
(WebInspector.TreeOutline):
(WebInspector.TreeOutline.prototype.get compact):
(WebInspector.TreeOutline.prototype.set compact):
(WebInspector.TreeOutline.prototype.get large):
(WebInspector.TreeOutline.prototype.set large):
(WebInspector.TreeOutline.prototype.get disclosureButtons):
(WebInspector.TreeOutline.prototype.set disclosureButtons):
(WebInspector.TreeOutline.prototype.get customIndent):
(WebInspector.TreeOutline.prototype.set customIndent):
Added properties for tree element appearance and indentation
behavior, so clients don't need to manually toggle style classes.
(WebInspector.TreeOutline._generateStyleRulesIfNeeded):
Relocated from NavigationSidebarPanel.js.
- UserInterface/Views/TypeTreeElement.js:
(WebInspector.TypeTreeElement): Deleted.
Removed call to obsolete TreeOutline.prototype.small setter.
- UserInterface/Views/TypeTreeView.css:
(.tree-outline.type):
(.tree-outline.type li):
(.tree-outline.type ol):
(.tree-outline.type ol.expanded):
(.tree-outline.type li .empty-message):
(.type-tree-outline): Deleted.
(.type-tree-outline li): Deleted.
(.type-tree-outline ol): Deleted.
(.type-tree-outline ol.expanded): Deleted.
(.type-tree-outline li .empty-message): Deleted.
Updated selectors with new tree outline class names.
- UserInterface/Views/TypeTreeView.js:
(WebInspector.TypeTreeView):
Use default TreeOutline DOM element, and simplify element class name.
- 11:37 AM Changeset in webkit [195302] by
-
- 19 edits2 copies in trunk/Source/WebCore
[EME] Correctly report errors when generating key requests from AVContentKeySession.
https://bugs.webkit.org/show_bug.cgi?id=151963
Reviewed by Eric Carlson.
WebIDL's "unsigned long" is a 32-bit unsigned integer, and C++'s "unsigned long" is (or, can
be) a 64-bit integer on 64-bit platforms. Casting a negative integer to a 64-bit integer
results in a number which cannot be accurately stored in a double-length floating point
number. Previously, the mac CDM code would work around this issue by returning the absolute
value of NSError code returned by media frameworks. Instead, fix the underlying problem by
storing the MediaKeyError's systemCode as a uint32_t (which more accurately represents the
size of a WebIDL "unsigned long" on all platforms.)
Check the error code issued by -contentKeyRequestDataForApp:contentIdentifier:options:error:.
- Modules/encryptedmedia/CDM.h:
- Modules/encryptedmedia/CDMSessionClearKey.cpp:
(WebCore::CDMSessionClearKey::generateKeyRequest):
(WebCore::CDMSessionClearKey::update):
- Modules/encryptedmedia/CDMSessionClearKey.h:
- Modules/encryptedmedia/MediaKeySession.cpp:
(WebCore::MediaKeySession::keyRequestTimerFired):
(WebCore::MediaKeySession::addKeyTimerFired):
(WebCore::MediaKeySession::sendError):
- Modules/encryptedmedia/MediaKeySession.h:
- Modules/mediacontrols/mediaControlsApple.js:
(Controller.prototype.handleReadyStateChange):
- WebCore.xcodeproj/project.pbxproj:
- html/MediaKeyError.h:
(WebCore::MediaKeyError::create):
(WebCore::MediaKeyError::systemCode):
- html/MediaKeyEvent.h:
- platform/graphics/CDMSession.h:
- platform/graphics/avfoundation/objc/CDMSessionAVContentKeySession.h:
- platform/graphics/avfoundation/objc/CDMSessionAVContentKeySession.mm:
(WebCore::CDMSessionAVContentKeySession::generateKeyRequest):
(WebCore::CDMSessionAVContentKeySession::update):
(WebCore::CDMSessionAVContentKeySession::generateKeyReleaseMessage):
- platform/graphics/avfoundation/objc/CDMSessionAVFoundationObjC.h:
- platform/graphics/avfoundation/objc/CDMSessionAVFoundationObjC.mm:
(WebCore::CDMSessionAVFoundationObjC::generateKeyRequest):
(WebCore::CDMSessionAVFoundationObjC::update):
- platform/graphics/avfoundation/objc/CDMSessionAVStreamSession.h:
- platform/graphics/avfoundation/objc/CDMSessionAVStreamSession.mm:
(WebCore::CDMSessionAVStreamSession::generateKeyRequest):
(WebCore::CDMSessionAVStreamSession::update):
(WebCore::CDMSessionAVStreamSession::generateKeyReleaseMessage):
- platform/graphics/avfoundation/objc/CDMSessionMediaSourceAVFObjC.h:
- platform/graphics/avfoundation/objc/CDMSessionMediaSourceAVFObjC.mm:
(WebCore::CDMSessionMediaSourceAVFObjC::layerDidReceiveError):
(WebCore::CDMSessionMediaSourceAVFObjC::rendererDidReceiveError):
(WebCore::CDMSessionMediaSourceAVFObjC::systemCodeForError): Deleted.
- testing/MockCDM.cpp:
(WebCore::MockCDMSession::generateKeyRequest):
(WebCore::MockCDMSession::update):2016-01-15 Simon Fraser <Simon Fraser>
- 11:35 AM Changeset in webkit [195301] by
-
- 2 edits1 copy in trunk/LayoutTests
Modern IDB: Split all storage/indexeddb/mozilla tests into separate HTML + JS format.
https://bugs.webkit.org/show_bug.cgi?id=153237
Reviewed by Sam Weinig.
- storage/indexeddb/mozilla/index-prev-no-duplicate.html:
- storage/indexeddb/mozilla/resources/index-prev-no-duplicate.js: Copied from LayoutTests/storage/indexeddb/mozilla/index-prev-no-duplicate.html.
- 11:34 AM Changeset in webkit [195300] by
-
- 23 edits2 moves1 add in trunk/Source
Add support for DataDetectors in WK (iOS).
https://bugs.webkit.org/show_bug.cgi?id=152989
rdar://problem/22855960
Reviewed by Tim Horton.
Source/JavaScriptCore:
Adding feature definition.
- Configurations/FeatureDefines.xcconfig:
Source/WebCore:
This is the first step toward implementing Data Detectors support
in WK2. The patch adds a new memeber to the Settings object
to retrieve the type of detection desired. The DataDetection files
have been moved under cocoa, since they are no longer OS X specific.
- Configurations/FeatureDefines.xcconfig:
- Configurations/WebCore.xcconfig:
- WebCore.xcodeproj/project.pbxproj:
- editing/cocoa/DataDetection.h: Copied from Source/WebCore/editing/mac/DataDetection.h.
- editing/cocoa/DataDetection.mm: Copied from Source/WebCore/editing/mac/DataDetection.mm.
(WebCore::detectItemAtPositionWithRange):
(WebCore::DataDetection::detectItemAroundHitTestResult):
(WebCore::DataDetection::detectContentInRange):
- editing/mac/DataDetection.h: Removed.
- editing/mac/DataDetection.mm: Removed.
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::checkLoadCompleteForThisFrame):
- page/Settings.h:
- page/Settings.in:
- platform/spi/mac/DataDetectorsSPI.h:
Source/WebKit/mac:
Adding feature definition for data detection.
- Configurations/FeatureDefines.xcconfig:
Source/WebKit2:
This is the first step toward implementing Data Detectors support
in WK2. The patch adds a new property to the configuration
object to indicate the type of detection desired and propagates
to the WebProcess.
- Configurations/FeatureDefines.xcconfig:
- Shared/WebPreferencesDefinitions.h:
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView initWithFrame:configuration:]):
- UIProcess/API/Cocoa/WKWebViewConfiguration.h:
- UIProcess/API/Cocoa/WKWebViewConfiguration.mm:
(-[WKWebViewConfiguration copyWithZone:]):
- WebKit2.xcodeproj/project.pbxproj:
- WebProcess/WebPage/Cocoa/WebPageCocoa.mm: Added.
(WebKit::WebPage::fromWKDataDetectorTypes):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences):
- WebProcess/WebPage/WebPage.h:
Source/WTF:
Adding feature definition for data detection.
- wtf/FeatureDefines.h:
- 11:32 AM Changeset in webkit [195299] by
-
- 29 edits27 copies in trunk/LayoutTests
Modern IDB: Split all storage/indexeddb tests into separate HTML + JS format.
https://bugs.webkit.org/show_bug.cgi?id=153178
Reviewed by Sam Weinig.
- storage/indexeddb/clone-exception.html:
- storage/indexeddb/closed-cursor.html:
- storage/indexeddb/connection-leak.html:
- storage/indexeddb/cursor-cast.html:
- storage/indexeddb/cursor-leak.html:
- storage/indexeddb/cursor-overloads.html:
- storage/indexeddb/cursor-request-cycle.html:
- storage/indexeddb/deleteIndex-bug110792.html:
- storage/indexeddb/deletedatabase-transaction.html:
- storage/indexeddb/metadata-race.html:
- storage/indexeddb/noblobs.html:
- storage/indexeddb/object-lookups-in-versionchange.html:
- storage/indexeddb/open-bad-versions.html:
- storage/indexeddb/optional-arguments.html:
- storage/indexeddb/prefetch-invalidation.html:
- storage/indexeddb/prefetch-race.html:
- storage/indexeddb/primary-key-unique-to-objectstore.html:
- storage/indexeddb/request-leak.html:
- storage/indexeddb/request-result-cache.html:
- storage/indexeddb/resources/clone-exception.js: Copied from LayoutTests/storage/indexeddb/clone-exception.html.
- storage/indexeddb/resources/closed-cursor.js: Copied from LayoutTests/storage/indexeddb/closed-cursor.html.
- storage/indexeddb/resources/connection-leak.js: Copied from LayoutTests/storage/indexeddb/connection-leak.html.
- storage/indexeddb/resources/cursor-cast.js: Copied from LayoutTests/storage/indexeddb/cursor-cast.html.
- storage/indexeddb/resources/cursor-leak.js: Copied from LayoutTests/storage/indexeddb/cursor-leak.html.
- storage/indexeddb/resources/cursor-overloads.js: Copied from LayoutTests/storage/indexeddb/cursor-overloads.html.
- storage/indexeddb/resources/cursor-request-cycle.js: Copied from LayoutTests/storage/indexeddb/cursor-request-cycle.html.
- storage/indexeddb/resources/deleteIndex-bug110792.js: Copied from LayoutTests/storage/indexeddb/deleteIndex-bug110792.html.
- storage/indexeddb/resources/deletedatabase-transaction.js: Copied from LayoutTests/storage/indexeddb/deletedatabase-transaction.html.
- storage/indexeddb/resources/metadata-race.js: Copied from LayoutTests/storage/indexeddb/metadata-race.html.
- storage/indexeddb/resources/noblobs.js: Copied from LayoutTests/storage/indexeddb/noblobs.html.
- storage/indexeddb/resources/object-lookups-in-versionchange.js: Copied from LayoutTests/storage/indexeddb/object-lookups-in-versionchange.html.
- storage/indexeddb/resources/open-bad-versions.js: Copied from LayoutTests/storage/indexeddb/open-bad-versions.html.
- storage/indexeddb/resources/optional-arguments.js: Copied from LayoutTests/storage/indexeddb/optional-arguments.html.
- storage/indexeddb/resources/prefetch-invalidation.js: Copied from LayoutTests/storage/indexeddb/prefetch-invalidation.html.
- storage/indexeddb/resources/prefetch-race.js: Copied from LayoutTests/storage/indexeddb/prefetch-race.html.
- storage/indexeddb/resources/primary-key-unique-to-objectstore.js: Copied from LayoutTests/storage/indexeddb/primary-key-unique-to-objectstore.html.
- storage/indexeddb/resources/request-leak.js: Copied from LayoutTests/storage/indexeddb/request-leak.html.
- storage/indexeddb/resources/request-result-cache.js: Copied from LayoutTests/storage/indexeddb/request-result-cache.html.
- storage/indexeddb/resources/structured-clone.js: Copied from LayoutTests/storage/indexeddb/structured-clone.html.
- storage/indexeddb/resources/transaction-complete-with-js-recursion-cross-frame.js: Copied from LayoutTests/storage/indexeddb/transaction-complete-with-js-recursion-cross-frame.html.
- storage/indexeddb/resources/transaction-complete-with-js-recursion.js: Copied from LayoutTests/storage/indexeddb/transaction-complete-with-js-recursion.html.
- storage/indexeddb/resources/transaction-crash-in-tasks.js: Copied from LayoutTests/storage/indexeddb/transaction-crash-in-tasks.html.
- storage/indexeddb/resources/transaction-ordering.js: Copied from LayoutTests/storage/indexeddb/transaction-ordering.html.
- storage/indexeddb/resources/transaction-overlapping.js: Copied from LayoutTests/storage/indexeddb/transaction-overlapping.html.
- storage/indexeddb/resources/version-change-event-basic.js: Copied from LayoutTests/storage/indexeddb/version-change-event-basic.html.
- storage/indexeddb/resources/version-change-event.js: Copied from LayoutTests/storage/indexeddb/version-change-event.html.
- storage/indexeddb/structured-clone.html:
- storage/indexeddb/transaction-complete-with-js-recursion-cross-frame.html:
- storage/indexeddb/transaction-complete-with-js-recursion.html:
- storage/indexeddb/transaction-crash-in-tasks.html:
- storage/indexeddb/transaction-ordering.html:
- storage/indexeddb/transaction-overlapping.html:
- storage/indexeddb/transaction-starvation.html:
- storage/indexeddb/version-change-event-basic.html:
- storage/indexeddb/version-change-event.html:
- 11:20 AM Changeset in webkit [195298] by
-
- 40 edits4 adds1 delete in trunk/Source
FTL B3 should be just as fast as FTL LLVM on Octane/crypto
https://bugs.webkit.org/show_bug.cgi?id=153113
Reviewed by Saam Barati.
Source/JavaScriptCore:
This is the result of a hacking rampage to close the gap between FTL B3 and FTL LLVM on
Octane/crypto. It was a very successful rampage.
The biggest change in this patch is the introduction of a phase called fixObviousSpills()
that fixes patterns like:
Store register to stack slot and then use stack slot:
Move %rcx, (stack42)
Foo use:(stack42) replace (stack42) with %rcx here.
Load stack slot into register and then use stack slot:
Move (stack42), %rcx
Foo use:(stack42) replace (stack42) with %rcx here.
Store constant into stack slot and then use stack slot:
Move $42, %rcx
Move %rcx, (stack42)
Bar def:%rcx %rcx isn't available anymore, but we still know that (stack42) is $42
Foo use:(stack42) replace (stack42) with $42 here.
This phases does these fixups by doing a global forward flow that propagates sets of
must-aliases.
Also added a phase to report register pressure. It pretty-prints code alongside the set of
in-use registers above each instruction. Using this phase, I found that our register
allocator is actually doing a pretty awesome job. I had previously feared that we'd have to
make substantial changes to register allocation. I don't have such a fear anymore, at least
for Octane/crypto. In the future, we can check how the regalloc is performing just by
enabling logAirRegisterPressure.
Also fixed some FTL codegen pathologies. We were using bitOr where we meant to use a
conditional or. LLVM likes to canonicalize boolean expressions this way. B3, on the other
hand, doesn't do this canonicalization and doesn't have logic to decompose it into sequences
of branches.
Also added strength reductions for checked arithmetic. It turns out that LLVM learned how to
reduce checked multiply to unchecked multiply in some obvious cases that our existing DFG
optimizations lacked. Ideally, our DFG integer range optimization phase would cover this. But
the cases of interest were dead simple - the incoming values to the CheckMul were obviously
too small to cause overflow. I added such reasoning to B3's strength reduction.
Finally, this fixes some bugs with how we were handling subwidth spill slots. The register
allocator was making two mistakes. First, it might cause a Width64 def or use of a 4-byte
spill slot. In that case, it would extend the size of the spill slot to ensure that the use
or def is safe. Second, it emulates ZDef on Tmp behavior by emitting a Move32 to initialize
the high bits of a spill slot. But this is unsound because of the liveness semantics of spill
slots. They cannot have more than one def to initialize their value. I fixed that by making
allocateStack() be the thing that fixes ZDefs. That's a change to ZDef semantics: now, ZDef
on an anonymous stack slot means that the high bits are zero-filled. I wasn't able to
construct a test for this. It might be a hypothetical bug, but still, I like how this
simplifies the register allocator.
This is a ~0.7% speed-up on Octane.
- CMakeLists.txt:
- JavaScriptCore.xcodeproj/project.pbxproj:
- b3/B3CheckSpecial.cpp:
(JSC::B3::CheckSpecial::hiddenBranch):
(JSC::B3::CheckSpecial::forEachArg):
(JSC::B3::CheckSpecial::commitHiddenBranch): Deleted.
- b3/B3CheckSpecial.h:
- b3/B3LowerToAir.cpp:
(JSC::B3::Air::LowerToAir::fillStackmap):
(JSC::B3::Air::LowerToAir::lower):
- b3/B3StackmapValue.h:
- b3/air/AirAllocateStack.cpp:
(JSC::B3::Air::allocateStack):
- b3/air/AirAllocateStack.h:
- b3/air/AirArg.h:
(JSC::B3::Air::Arg::callArg):
(JSC::B3::Air::Arg::stackAddr):
(JSC::B3::Air::Arg::isValidScale):
- b3/air/AirBasicBlock.cpp:
(JSC::B3::Air::BasicBlock::deepDump):
(JSC::B3::Air::BasicBlock::dumpHeader):
(JSC::B3::Air::BasicBlock::dumpFooter):
- b3/air/AirBasicBlock.h:
- b3/air/AirCCallSpecial.cpp:
(JSC::B3::Air::CCallSpecial::CCallSpecial):
(JSC::B3::Air::CCallSpecial::~CCallSpecial):
- b3/air/AirCode.h:
(JSC::B3::Air::Code::lastPhaseName):
(JSC::B3::Air::Code::setEnableRCRS):
(JSC::B3::Air::Code::enableRCRS):
- b3/air/AirCustom.cpp:
(JSC::B3::Air::PatchCustom::isValidForm):
(JSC::B3::Air::CCallCustom::isValidForm):
- b3/air/AirCustom.h:
(JSC::B3::Air::PatchCustom::isValidFormStatic):
(JSC::B3::Air::PatchCustom::admitsStack):
(JSC::B3::Air::PatchCustom::isValidForm): Deleted.
- b3/air/AirEmitShuffle.cpp:
(JSC::B3::Air::ShufflePair::dump):
(JSC::B3::Air::createShuffle):
(JSC::B3::Air::emitShuffle):
- b3/air/AirEmitShuffle.h:
- b3/air/AirFixObviousSpills.cpp: Added.
(JSC::B3::Air::fixObviousSpills):
- b3/air/AirFixObviousSpills.h: Added.
- b3/air/AirFixSpillSlotZDef.h: Removed.
- b3/air/AirGenerate.cpp:
(JSC::B3::Air::prepareForGeneration):
(JSC::B3::Air::generate):
- b3/air/AirHandleCalleeSaves.cpp:
(JSC::B3::Air::handleCalleeSaves):
- b3/air/AirInst.h:
- b3/air/AirInstInlines.h:
(JSC::B3::Air::Inst::reportUsedRegisters):
(JSC::B3::Air::Inst::admitsStack):
(JSC::B3::Air::isShiftValid):
- b3/air/AirIteratedRegisterCoalescing.cpp:
- b3/air/AirLiveness.h:
(JSC::B3::Air::AbstractLiveness::AbstractLiveness):
(JSC::B3::Air::AbstractLiveness::LocalCalc::Iterable::begin):
(JSC::B3::Air::AbstractLiveness::LocalCalc::Iterable::end):
(JSC::B3::Air::AbstractLiveness::LocalCalc::Iterable::contains):
(JSC::B3::Air::AbstractLiveness::LocalCalc::live):
(JSC::B3::Air::AbstractLiveness::LocalCalc::isLive):
(JSC::B3::Air::AbstractLiveness::LocalCalc::execute):
(JSC::B3::Air::AbstractLiveness::rawLiveAtHead):
(JSC::B3::Air::AbstractLiveness::Iterable::begin):
(JSC::B3::Air::AbstractLiveness::Iterable::end):
(JSC::B3::Air::AbstractLiveness::Iterable::contains):
(JSC::B3::Air::AbstractLiveness::liveAtTail):
(JSC::B3::Air::AbstractLiveness::workset):
- b3/air/AirLogRegisterPressure.cpp: Added.
(JSC::B3::Air::logRegisterPressure):
- b3/air/AirLogRegisterPressure.h: Added.
- b3/air/AirOptimizeBlockOrder.cpp:
(JSC::B3::Air::blocksInOptimizedOrder):
(JSC::B3::Air::optimizeBlockOrder):
- b3/air/AirOptimizeBlockOrder.h:
- b3/air/AirReportUsedRegisters.cpp:
(JSC::B3::Air::reportUsedRegisters):
- b3/air/AirReportUsedRegisters.h:
- b3/air/AirSpillEverything.cpp:
(JSC::B3::Air::spillEverything):
- b3/air/AirStackSlot.h:
(JSC::B3::Air::StackSlot::isLocked):
(JSC::B3::Air::StackSlot::index):
(JSC::B3::Air::StackSlot::ensureSize):
(JSC::B3::Air::StackSlot::alignment):
- b3/air/AirValidate.cpp:
- ftl/FTLB3Compile.cpp:
(JSC::FTL::compile):
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::DFG::LowerDFGToLLVM::compileArithMul):
(JSC::FTL::DFG::LowerDFGToLLVM::compileArithDiv):
(JSC::FTL::DFG::LowerDFGToLLVM::compileArithMod):
- jit/RegisterSet.h:
(JSC::RegisterSet::get):
(JSC::RegisterSet::setAll):
(JSC::RegisterSet::merge):
(JSC::RegisterSet::filter):
- runtime/Options.h:
Source/WTF:
- wtf/IndexSparseSet.h:
(WTF::IndexSparseSet<OverflowHandler>::IndexSparseSet):
(WTF::IndexSparseSet<OverflowHandler>::add):
(WTF::IndexSparseSet<OverflowHandler>::remove):
- wtf/StringPrintStream.h:
(WTF::StringPrintStream::length):
- 10:35 AM Changeset in webkit [195297] by
-
- 2 edits in trunk/Source/JavaScriptCore
Unreviewed, undo unintended commit.
- dfg/DFGCommon.h:
- 10:34 AM Changeset in webkit [195296] by
-
- 6 edits in trunk/Source/JavaScriptCore
Fix Air shuffling assertions
https://bugs.webkit.org/show_bug.cgi?id=153213
Reviewed by Saam Barati.
Fixes some assertions that I was seeing running JSC tests. Adds a new Air test.
- assembler/MacroAssemblerX86Common.h:
(JSC::MacroAssemblerX86Common::store8):
(JSC::MacroAssemblerX86Common::getUnusedRegister):
- b3/air/AirEmitShuffle.cpp:
(JSC::B3::Air::emitShuffle):
- b3/air/AirLowerAfterRegAlloc.cpp:
(JSC::B3::Air::lowerAfterRegAlloc):
- b3/air/testair.cpp:
(JSC::B3::Air::testShuffleRotateWithFringe):
(JSC::B3::Air::testShuffleRotateWithFringeInWeirdOrder):
(JSC::B3::Air::testShuffleRotateWithLongFringe):
(JSC::B3::Air::run):
- 10:21 AM Changeset in webkit [195295] by
-
- 2 edits in trunk/Source/WebKit2
Unreviewed, rolling out r187471.
https://bugs.webkit.org/show_bug.cgi?id=153236
purportedly caused a significant memory regression and want to
see if that is true (Requested by thorton on #webkit).
Reverted changeset:
"First in-window viewStateChange synchronously blocks despite
not previously being in-window"
https://bugs.webkit.org/show_bug.cgi?id=147344
http://trac.webkit.org/changeset/187471
- 9:50 AM Changeset in webkit [195294] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed, fix typo in comment added in r195157.
- dom/DocumentType.h:
- 9:39 AM Changeset in webkit [195293] by
-
- 12 edits in trunk/Source/WebCore
Selector checker should not mutate document and style
https://bugs.webkit.org/show_bug.cgi?id=153205
Reviewed by Darin Adler.
Selector checker currently writes affected-by bits and similar directly to the document and style during selector
matching. This is confusing, complicated and wrong.
This patch changes SelectorChecker and SelectorCompiler to collect style relatationship metadata to a separate
data structure (currently part of SelectorChecker::CheckingContext) instead of changing the document and style
directly. The mutations are performed later outside selector checker.
- css/ElementRuleCollector.cpp:
(WebCore::ElementRuleCollector::ruleMatches):
(WebCore::ElementRuleCollector::commitStyleRelations):
Apply the relationship bit to elements and style.
(WebCore::ElementRuleCollector::collectMatchingRulesForList):
- css/ElementRuleCollector.h:
- css/SelectorChecker.cpp:
(WebCore::SelectorChecker::LocalContext::LocalContext):
LocalContext is now a separate data structure.
(WebCore::addStyleRelation):
Helper for recording new style relations. This is used where code mutated elements or style directly before.
(WebCore::isFirstChildElement):
(WebCore::isLastChildElement):
(WebCore::isFirstOfType):
(WebCore::isLastOfType):
(WebCore::countElementsBefore):
(WebCore::countElementsOfTypeBefore):
(WebCore::SelectorChecker::SelectorChecker):
(WebCore::SelectorChecker::match):
(WebCore::hasScrollbarPseudoElement):
(WebCore::localContextForParent):
(WebCore::SelectorChecker::matchRecursively):
(WebCore::attributeValueMatches):
(WebCore::anyAttributeMatches):
(WebCore::canMatchHoverOrActiveInQuirksMode):
(WebCore::tagMatches):
(WebCore::SelectorChecker::checkOne):
(WebCore::SelectorChecker::matchSelectorList):
(WebCore::SelectorChecker::checkScrollbarPseudoClass):
(WebCore::SelectorChecker::CheckingContextWithStatus::CheckingContextWithStatus): Deleted.
(WebCore::checkingContextForParent): Deleted.
- css/SelectorChecker.h:
(WebCore::SelectorChecker::CheckingContext::CheckingContext):
- css/SelectorCheckerTestFunctions.h:
(WebCore::isEnabled):
(WebCore::isMediaDocument):
(WebCore::isChecked):
(WebCore::isInRange):
(WebCore::isOutOfRange):
- css/StyleResolver.h:
(WebCore::checkRegionSelector):
- cssjit/SelectorCompiler.cpp:
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateAddStyleRelationIfResolvingStyle):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateAddStyleRelation):
Helpers for generating code for recording new style relations. This is used where code mutated elements or style directly before.
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateSelectorCheckerExcludingPseudoElements):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateDirectAdjacentTreeWalker):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateIndirectAdjacentTreeWalker):
(WebCore::SelectorCompiler::addStyleRelationElementFunction):
(WebCore::SelectorCompiler::SelectorCodeGenerator::jumpIfNoPreviousAdjacentElement):
(WebCore::SelectorCompiler::SelectorCodeGenerator::moduloIsZero):
(WebCore::SelectorCompiler::SelectorCodeGenerator::linkFailures):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementMatching):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateContextFunctionCallTest):
(WebCore::SelectorCompiler::elementIsActive):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementIsActive):
(WebCore::SelectorCompiler::jumpIfElementIsNotEmpty):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementIsEmpty):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementIsFirstChild):
(WebCore::SelectorCompiler::elementIsHovered):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementIsHovered):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementIsInLanguage):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementIsLastChild):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementIsOnlyChild):
(WebCore::SelectorCompiler::makeContextStyleUniqueIfNecessaryAndTestIsPlaceholderShown):
(WebCore::SelectorCompiler::isPlaceholderShown):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementHasPlaceholderShown):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementIsLink):
(WebCore::SelectorCompiler::nthFilterIsAlwaysSatisified):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementIsNthChild):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementIsNthChildOf):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementIsNthLastChild):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementIsNthLastChildOf):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateMarkPseudoStyleForPseudoElement):
(WebCore::SelectorCompiler::SelectorCodeGenerator::addFlagsToElementStyleFromContext): Deleted.
(WebCore::SelectorCompiler::setNodeFlag): Deleted.
(WebCore::SelectorCompiler::SelectorCodeGenerator::markElementIfResolvingStyle): Deleted.
(WebCore::SelectorCompiler::setFirstChildState): Deleted.
(WebCore::SelectorCompiler::elementIsActiveForStyleResolution): Deleted.
(WebCore::SelectorCompiler::setElementStyleIsAffectedByEmpty): Deleted.
(WebCore::SelectorCompiler::setElementStyleFromContextIsAffectedByEmptyAndUpdateRenderStyleIfNecessary): Deleted.
(WebCore::SelectorCompiler::elementIsHoveredForStyleResolution): Deleted.
(WebCore::SelectorCompiler::setLastChildState): Deleted.
(WebCore::SelectorCompiler::setOnlyChildState): Deleted.
(WebCore::SelectorCompiler::makeElementStyleUniqueIfNecessaryAndTestIsPlaceholderShown): Deleted.
(WebCore::SelectorCompiler::setElementChildIndex): Deleted.
(WebCore::SelectorCompiler::setChildrenAffectedByBackwardPositionalRules): Deleted.
(WebCore::SelectorCompiler::setParentAffectedByLastChildOf): Deleted.
- dom/SelectorQuery.cpp:
(WebCore::SelectorDataList::selectorMatches):
(WebCore::SelectorDataList::selectorClosest):
(WebCore::SelectorDataList::matches):
- inspector/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::buildArrayForMatchedRuleList):
- inspector/InspectorStyleSheet.cpp:
(WebCore::buildObjectForSelectorHelper):
- 9:20 AM Changeset in webkit [195292] by
-
- 2 edits in releases/WebKitGTK/webkit-2.10/Source/WebCore
Merge r195291 - Unreviewed. Fix GTK+ build with GTK+ < 3.14.
Flags GTK_ICON_LOOKUP_DIR_LTR and GTK_ICON_LOOKUP_DIR_RTL were
added in GTK+ 3.14.
- rendering/RenderThemeGtk.cpp:
(WebCore::loadThemedIcon):
- 9:06 AM Changeset in webkit [195291] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed. Fix GTK+ build with GTK+ < 3.14.
Flags GTK_ICON_LOOKUP_DIR_LTR and GTK_ICON_LOOKUP_DIR_RTL were
added in GTK+ 3.14.
- rendering/RenderThemeGtk.cpp:
(WebCore::loadThemedIcon):
- 9:03 AM Changeset in webkit [195290] by
-
- 2 edits in trunk/Source/JavaScriptCore
[mips] Logical instructions allow immediates in range 0..0xffff, not 0x7fff
https://bugs.webkit.org/show_bug.cgi?id=152693
Patch by Konstantin Tokarev <Konstantin Tokarev> on 2016-01-19
Reviewed by Michael Saboff.
- offlineasm/mips.rb:
- 9:00 AM Changeset in webkit [195289] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed. Fix GObject DOM bindings API break after r195264.
Add webkit_dom_character_data_set_data to the list of functions
that used to raise exceptions.
- bindings/scripts/CodeGeneratorGObject.pm:
(FunctionUsedToRaiseException):
- 8:49 AM Changeset in webkit [195288] by
-
- 4 edits in trunk
[GTK] Runtime critical warnings when loading a URL after a session restore
https://bugs.webkit.org/show_bug.cgi?id=153233
Reviewed by Michael Catanzaro.
Source/WebKit2:
This happens when doing a normal load after restoring the back
forward list from session state and the list contained forward
items. In that case the forward items are removed from the list
and we try to reference a WebBackForwardListItem wrapper that
hasn't been created. We create the wrappers on demand, and when
the back forward list is populated from session state, items are
added to the list without creating their wrappers. That was not
possible before, and that's why we assumed that any item that is
removed from the list should have a wrapper already created.
- UIProcess/API/gtk/WebKitBackForwardList.cpp:
(webkitBackForwardListChanged): If we don't have a wrapper for the
removed item, create a new one to be passed to the signal, but
without adding it to the map.
Tools:
Add new test case.
- TestWebKitAPI/Tests/WebKit2Gtk/TestBackForwardList.cpp:
(viewLoadChanged):
(testWebKitWebViewNavigationAfterSessionRestore):
(beforeAll):
- 7:40 AM Changeset in webkit [195287] by
-
- 2 edits1 delete in trunk/Tools
[GTK] Remove jhbuild-optional.modules
https://bugs.webkit.org/show_bug.cgi?id=152964
Reviewed by Alex Christensen.
- gtk/jhbuild-optional.modules: Removed.
- gtk/jhbuild.modules:
- 5:15 AM Changeset in webkit [195286] by
-
- 4 edits in trunk/Tools
[GTK] Add support to load/save session in MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=153201
Reviewed by Michael Catanzaro.
It makes it easier to test the new WebView session API.
- MiniBrowser/gtk/BrowserWindow.c:
(browserWindowFinalize): Free the session file path.
(browserWindowSaveSession): Save the current WebView session if
there's a session file path.
(browserWindowDeleteEvent): Call browserWindowSaveSession().
(browser_window_load_session): Try to load the session from the
given file path, otherwise fall back to homepage and keep the
session file to save the session on window close.
- MiniBrowser/gtk/BrowserWindow.h:
- MiniBrowser/gtk/main.c:
(createBrowserWindow): Pass the given session file path when
shouldLoadSession is TRUE.
(main): Only allow to restore/save session when MiniBrowser is
launched without URL arguments.
- 5:14 AM Changeset in webkit [195285] by
-
- 2 edits in trunk/Tools
Unreviewed. Fix GTK+ test /webkit2/WebKitWebView/geolocation-permission-requests after r195075.
Geolocation is no longer allowed for unique origins after r195075.
- TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
(testWebViewGeolocationPermissionRequests):
- 3:36 AM Changeset in webkit [195284] by
-
- 4 edits2 adds in trunk
[css-grid][css-align] justify-self stretch is not applied for img elements
https://bugs.webkit.org/show_bug.cgi?id=153206
Reviewed by Darin Adler.
Source/WebCore:
When computing the logical height, we check first if there is an override
height value set as a consequence of the stretching logic, so we use it
directly for any kind of element. However, in the case of the width
computation, we don't use such override value because it's the default
behavior of block-level boxes.
However, we consider some special cases which have to be treated as
replaced elements. Theses cases are evaluated first, so we don't let the
regular width computation logic to be executed, which is what we want
to implement the stretch behavior.
In order to let replaced elements, such images, to be stretched as a
consequence of the CSS alignment properties, we need to exclude grid
items from the cases to be treated as replaced elements during the width
computation.
Test: fast/css-grid-layout/grid-align-stretching-replaced-items.html
- rendering/RenderBox.cpp:
(WebCore::RenderBox::computeLogicalWidthInRegion):
(WebCore::RenderBox::hasStretchedLogicalWidth):
(WebCore::RenderBox::sizesLogicalWidthToFitContent):
- rendering/RenderBox.h:
LayoutTests:
Test to verify Replaced Elements, like images, are stretched in the inline
axis, when fulfilling the Box Alignment restrictions on this regard.
- fast/css-grid-layout/grid-align-stretching-replaced-items-expected.txt: Added.
- fast/css-grid-layout/grid-align-stretching-replaced-items.html: Added.
- 3:23 AM Changeset in webkit [195283] by
-
- 15 edits2 adds in releases/WebKitGTK/webkit-2.10/Source/JavaScriptCore
Merge r189454 - StackOverflow stack unwinding should stop at native frames.
https://bugs.webkit.org/show_bug.cgi?id=148749
Reviewed by Michael Saboff.
In the present code, after ping-pong'ing back and forth between native and JS
code a few times, if we have a stack overflow on re-entry into the VM to run
JS code's whose stack frame would overflow the JS stack, the code will end up
unwinding past the native function that is making the call to re-enter the VM.
As a result, any clean up code (e.g. destructors for stack variables) in the
skipped native function frame (and its chain of native function callers) will
not be called.
This patch is based on the Michael Saboff's fix of this issue landed on the
jsc-tailcall branch: http://trac.webkit.org/changeset/188555
We now check for the case where there are no JS frames to unwind since the
last native frame, and treat the exception as an unhandled exception. The
native function is responsible for further propagating the exception if needed.
Other supporting work:
- Remove vm->vmEntryFrameForThrow. It should always be the same as vm->topVMEntryFrame.
- Change operationThrowStackOverflowError() to use the throwStackOverflowError() helper function instead of rolling its own.
- Added a test that exercises this edge case. The test should not hang or crash.
- API/tests/PingPongStackOverflowTest.cpp: Added.
(PingPongStackOverflowObject_hasInstance):
(testPingPongStackOverflow):
- API/tests/PingPongStackOverflowTest.h: Added.
- API/tests/testapi.c:
(main):
- JavaScriptCore.xcodeproj/project.pbxproj:
- interpreter/CallFrame.h:
(JSC::ExecState::operator=):
(JSC::ExecState::callerFrame):
(JSC::ExecState::callerFrameOrVMEntryFrame):
(JSC::ExecState::argIndexForRegister):
(JSC::ExecState::callerFrameAndPC):
- interpreter/Interpreter.cpp:
(JSC::UnwindFunctor::UnwindFunctor):
(JSC::UnwindFunctor::operator()):
(JSC::Interpreter::unwind):
- interpreter/Interpreter.h:
(JSC::NativeCallFrameTracer::NativeCallFrameTracer):
(JSC::Interpreter::sampler):
- jit/CCallHelpers.h:
(JSC::CCallHelpers::jumpToExceptionHandler):
- jit/JITExceptions.cpp:
(JSC::genericUnwind):
- jit/JITExceptions.h:
- jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_catch):
- jit/JITOpcodes32_64.cpp:
(JSC::JIT::emit_op_catch):
- jit/JITOperations.cpp:
- llint/LowLevelInterpreter32_64.asm:
- llint/LowLevelInterpreter64.asm:
- runtime/VM.h:
(JSC::VM::exceptionOffset):
(JSC::VM::callFrameForThrowOffset):
(JSC::VM::vmEntryFrameForThrowOffset): Deleted.
(JSC::VM::topVMEntryFrameOffset): Deleted.
- 3:23 AM Changeset in webkit [195282] by
-
- 2 edits in releases/WebKitGTK/webkit-2.10/Source/WebCore
Merge r189979 - WebContent crash in WebCore::MemoryPressureHandler::releaseCriticalMemory() with GuardMalloc when preparing to suspend
https://bugs.webkit.org/show_bug.cgi?id=149350
Reviewed by Antti Koivisto.
in MemoryPressureHandler::releaseCriticalMemory(), iterate over a copy of
Document::allDocuments() instead of iterating over allDocuments() directly.
Also make sure the Documents are ref'd inside the copy.
This is needed because clearing the StyleResolver of a Document may cause
Documents to be unref'd and removed from the allDocument() HashSet.
No new tests, already covered by existing tests.
- platform/MemoryPressureHandler.cpp:
(WebCore::MemoryPressureHandler::releaseCriticalMemory):
- 2:47 AM Changeset in webkit [195281] by
-
- 6 edits2 adds in trunk
Text::splitText doesn't update Range end points anchored on parent nodes
https://bugs.webkit.org/show_bug.cgi?id=153227
Reviewed by Antti Koivisto.
LayoutTests/imported/w3c:
Rebaseline the test now that we're passing more test cases.
- web-platform-tests/dom/ranges/Range-mutations-expected.txt:
Source/WebCore:
When a Text node is split into two and there is a Range whose boundary points' container node
is its parent and offset appears after the Text node, we must update the boundary points as specified
in step 7 of the concept "split" a Text node at https://dom.spec.whatwg.org/#concept-text-split
- Insert new node into parent before node’s next sibling.
- For each range whose start node is node and start offset is greater than offset, set its start node to new node and decrease its start offset by offset.
- For each range whose end node is node and end offset is greater than offset, set its end node to new node and decrease its end offset by offset.
- For each range whose start node is parent and start offset is equal to the index of node + 1, increase its start offset by one.
- For each range whose end node is parent and end offset is equal to the index of node + 1, increase its end offset by one.
Fixed the bug by implementing steps 4 and 5 in boundaryTextNodesSplit. New behavior matches the DOM spec
as well as the behavior of Firefox.
Test: fast/dom/Range/update-range-in-split-text.html
- dom/Range.cpp:
(WebCore::boundaryTextNodesSplit): See above.
- dom/RangeBoundaryPoint.h:
(WebCore::RangeBoundaryPoint::setToAfterChild): Added.
LayoutTests:
Added a regression test since the rebaselined W3C test is incomprehensible.
- fast/dom/Range/update-range-in-split-text-expected.txt: Added.
- fast/dom/Range/update-range-in-split-text.html: Added.
- 2:13 AM Changeset in webkit [195280] by
-
- 2 edits in releases/WebKitGTK/webkit-2.10/Source/WebKit2
Merge r193626 - [GTK] Allow applications to force Accelerated Compositing mode
https://bugs.webkit.org/show_bug.cgi?id=150558
Patch by Mario Sanchez Prada <mario@endlessm.com> on 2015-12-07
Reviewed by Carlos Garcia Campos.
Enable forcing Accelerated Compositing mode to be always on if
a WEBKIT_FORCE_COMPOSITING_MODE environment variable is set.
This can be useful for controlled environments where we know that
AC always on works well enough, to get smoother animations.
- UIProcess/gtk/WebPreferencesGtk.cpp:
(WebKit::WebPreferences::platformInitializeStore): Set forceCompositingMode
setting to true if the environment variable is found.
- 2:13 AM WebKitGTK/2.10.x edited by
- (diff)
- 2:09 AM WebKitGTK/2.10.x edited by
- (diff)
- 2:05 AM Changeset in webkit [195279] by
-
- 2 edits in releases/WebKitGTK/webkit-2.10/Source/WebKit2
Merge r195186 - Add quotes around ${CMAKE_SHARED_LINKER_FLAGS} in case it is unset
https://bugs.webkit.org/show_bug.cgi?id=153175
Patch by Jeremy Huddleston Sequoia <jeremyhu@apple.com> on 2016-01-17
Reviewed by Michael Catanzaro.
- PlatformGTK.cmake:
- 1:56 AM Changeset in webkit [195278] by
-
- 2 edits in releases/WebKitGTK/webkit-2.10/Source/WebCore
Merge r195169 - Add Platform.cpp to ANGLESupport
https://bugs.webkit.org/show_bug.cgi?id=153120
Patch by Jeremy Huddleston Sequoia <jeremyhu@apple.com> on 2016-01-16
Reviewed by Darin Adler.
No new tests, only addresses a build failure.
- CMakeLists.txt:
- 1:47 AM Changeset in webkit [195277] by
-
- 4 edits4 adds in releases/WebKitGTK/webkit-2.10
Merge r195162 - FrameLoaderClient::didReceiveServerRedirectForProvisionalLoadForFrame() is never called when loading a main resource from the memory cache
https://bugs.webkit.org/show_bug.cgi?id=152520
<rdar://problem/23305737>
Reviewed by Andy Estes.
Source/WebCore:
Test: http/tests/loading/server-redirect-for-provisional-load-caching.html
- loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::responseReceived):
Dispatch message to notify client that a cached resource was redirected. So,
client can make proper actions to treat server side redirection.
- loader/cache/CachedRawResource.h:
Add a method to tell whether the cached resource was redirected.
LayoutTests:
- http/tests/loading/resources/server-redirect-result.html: Added.
- http/tests/loading/resources/server-redirect.php: Added.
- http/tests/loading/server-redirect-for-provisional-load-caching-expected.txt: Added.
- http/tests/loading/server-redirect-for-provisional-load-caching.html: Added.
- 1:40 AM Changeset in webkit [195276] by
-
- 2 edits in releases/WebKitGTK/webkit-2.10/Source/WebCore
Merge r195153 - [GTK] Fix build of RenderThemeGtk without VIDEO by including HTMLInputElement
https://bugs.webkit.org/show_bug.cgi?id=153133
Patch by Olivier Blin <Olivier Blin> on 2016-01-15
Reviewed by Michael Catanzaro.
Build was fine with VIDEO enabled, since HTMLInputElement.h was
included by transitivity through MediaControlElements.h and
MediaControlElementTypes.h.
This seems to be broken since r194847.
No new tests since this is just a build fix.
- rendering/RenderThemeGtk.cpp:
- 1:39 AM Changeset in webkit [195275] by
-
- 3 edits2 adds in releases/WebKitGTK/webkit-2.10
Merge r195146 - ASSERTION FAILED: canHaveChildren() canHaveGeneratedChildren() in WebCore::RenderElement::insertChildInternal https://bugs.webkit.org/show_bug.cgi?id=123331
Reviewed by Darin Adler.
Do not set named flow fragment bit on the flow until after the renderer is attached. Setting/resetting it too early
could affect the attach/detach process itself (This is similar to attaching a multi column flow thread).
Source/WebCore:
Test: fast/regions/input-box-with-region-assert.html
- rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::willBeDestroyed):
(WebCore::RenderBlockFlow::createRenderNamedFlowFragmentIfNeeded):
(WebCore::RenderBlockFlow::setRenderNamedFlowFragment):
LayoutTests:
- fast/regions/input-box-with-region-assert-expected.txt: Added.
- fast/regions/input-box-with-region-assert.html: Added.
- 1:37 AM Changeset in webkit [195274] by
-
- 3 edits in releases/WebKitGTK/webkit-2.10/Source/JavaScriptCore
Merge r195134 - [mips] Implemented emitFunctionPrologue/Epilogue
https://bugs.webkit.org/show_bug.cgi?id=152947
Patch by Konstantin Tokarev <Konstantin Tokarev> on 2016-01-15
Reviewed by Michael Saboff.
- assembler/MacroAssemblerMIPS.h:
(JSC::MacroAssemblerMIPS::popPair):
(JSC::MacroAssemblerMIPS::pushPair):
- jit/AssemblyHelpers.h:
(JSC::AssemblyHelpers::emitFunctionPrologue):
(JSC::AssemblyHelpers::emitFunctionEpilogueWithEmptyFrame):
(JSC::AssemblyHelpers::emitFunctionEpilogue):
- 1:36 AM Changeset in webkit [195273] by
-
- 5 edits8 adds in releases/WebKitGTK/webkit-2.10
Merge r195100 - CORS: Fix the handling of redirected request containing Origin null.
https://bugs.webkit.org/show_bug.cgi?id=128816
Reviewed by Brent Fulgham.
Source/WebCore:
Merging Blink patch from George Ancil (https://chromiumcodereview.appspot.com/20735002).
This patch removes the check for securityOrigin->isUnique() in passesAccessControlCheck().
This check prevented a redirected request with "Origin: null" from being
successful even when the response contains "Access-Control-Allow-Origin: null"
Tests: http/tests/xmlhttprequest/access-control-sandboxed-iframe-allow-origin-null.html
http/tests/xmlhttprequest/redirect-cors-origin-null.html
- loader/CrossOriginAccessControl.cpp:
(WebCore::passesAccessControlCheck):
LayoutTests:
Merging Blink patch from George Ancil (https://chromiumcodereview.appspot.com/20735002)
Added two tests to check CORS with Origin null in HTTP redirect and iframe cases.
Updated two test sandboxed iframes test expectations (requests are still denied but error messages are different).
- http/tests/xmlhttprequest/access-control-sandboxed-iframe-allow-origin-null-expected.txt: Added.
- http/tests/xmlhttprequest/access-control-sandboxed-iframe-allow-origin-null.html: Added.
- http/tests/xmlhttprequest/access-control-sandboxed-iframe-denied-expected.txt:
- http/tests/xmlhttprequest/access-control-sandboxed-iframe-denied-without-wildcard-expected.txt:
- http/tests/xmlhttprequest/redirect-cors-origin-null-expected.txt: Added.
- http/tests/xmlhttprequest/redirect-cors-origin-null.html: Added.
- http/tests/xmlhttprequest/resources/access-control-sandboxed-iframe-allow-origin-null-iframe.html: Added.
- http/tests/xmlhttprequest/resources/access-control-sandboxed-iframe-allow-origin-null.cgi: Added.
- http/tests/xmlhttprequest/resources/redirect-cors-origin-null-pass.php: Added.
- http/tests/xmlhttprequest/resources/redirect-cors-origin-null.php: Added.
- 1:33 AM Changeset in webkit [195272] by
-
- 3 edits in releases/WebKitGTK/webkit-2.10/Source/JavaScriptCore
Merge r195093 - [mips] Add countLeadingZeros32 implementation in macro assembler
https://bugs.webkit.org/show_bug.cgi?id=152886
Reviewed by Michael Saboff.
- assembler/MIPSAssembler.h:
(JSC::MIPSAssembler::lui):
(JSC::MIPSAssembler::clz):
(JSC::MIPSAssembler::addiu):
- assembler/MacroAssemblerMIPS.h:
(JSC::MacroAssemblerMIPS::and32):
(JSC::MacroAssemblerMIPS::countLeadingZeros32):
(JSC::MacroAssemblerMIPS::lshift32):
- 1:30 AM Changeset in webkit [195271] by
-
- 6 edits15 adds in releases/WebKitGTK/webkit-2.10
Merge r195075 - Disallow use of Geolocation service from unique origins
https://bugs.webkit.org/show_bug.cgi?id=153102
<rdar://problem/23055645>
Reviewed by Alexey Proskuryakov.
Source/WebCore:
Tests: fast/dom/Geolocation/dataURL-getCurrentPosition.html
fast/dom/Geolocation/dataURL-watchPosition.html
fast/dom/Geolocation/srcdoc-getCurrentPosition.html
fast/dom/Geolocation/srcdoc-watchPosition.html
http/tests/security/sandboxed-iframe-geolocation-getCurrentPosition.html
http/tests/security/sandboxed-iframe-geolocation-watchPosition.html
- Modules/geolocation/Geolocation.cpp:
(WebCore::Geolocation::securityOrigin): Convenience function to get the SecurityOrigin object
associated with this script execution context.
(WebCore::Geolocation::startRequest): Notify requester POSITION_UNAVAILABLE when requested
from a document with a unique origin.
- Modules/geolocation/Geolocation.h:
- page/SecurityOrigin.h:
(WebCore::SecurityOrigin::canRequestGeolocation): Added.
LayoutTests:
- fast/dom/Geolocation/dataURL-getCurrentPosition-expected.txt: Added.
- fast/dom/Geolocation/dataURL-getCurrentPosition.html: Added.
- fast/dom/Geolocation/dataURL-watchPosition-expected.txt: Added.
- fast/dom/Geolocation/dataURL-watchPosition.html: Added.
- fast/dom/Geolocation/srcdoc-getCurrentPosition-expected.txt: Added.
- fast/dom/Geolocation/srcdoc-getCurrentPosition.html: Added.
- fast/dom/Geolocation/srcdoc-watchPosition-expected.txt: Added.
- fast/dom/Geolocation/srcdoc-watchPosition.html: Added.
- http/tests/security/resources/checkThatPositionErrorCallbackIsCalledWithPositionUnavailableForGeolocationMethod.js: Added.
(done):
(logMessage):
(didReceivePosition):
(didReceiveError):
(checkThatPositionErrorCallbackIsCalledWithPositionUnavailableForGeolocationMethod):
(markupToCheckThatPositionErrorCallbackIsCalledWithPositionUnavailableForGeolocationMethod):
(dataURLToCheckThatPositionErrorCallbackIsCalledWithPositionUnavailableForGeolocationMethod):
- http/tests/security/resources/sandboxed-iframe-geolocation-getCurrentPosition.html: Added.
- http/tests/security/resources/sandboxed-iframe-geolocation-watchPosition.html: Added.
- http/tests/security/sandboxed-iframe-geolocation-getCurrentPosition-expected.txt: Added.
- http/tests/security/sandboxed-iframe-geolocation-getCurrentPosition.html: Added.
- http/tests/security/sandboxed-iframe-geolocation-watchPosition-expected.txt: Added.
- http/tests/security/sandboxed-iframe-geolocation-watchPosition.html: Added.
- 1:07 AM Changeset in webkit [195270] by
-
- 3 edits in releases/WebKitGTK/webkit-2.10/Source/WebCore
Merge r195074 - [XSS Auditor] Extract attribute truncation logic and formalize string canonicalization
https://bugs.webkit.org/show_bug.cgi?id=152874
Reviewed by Brent Fulgham.
Derived from Blink patch (by Tom Sepez <tsepez@chromium.org>):
<https://src.chromium.org/viewvc/blink?revision=176339&view=revision>
Extract the src-like and script-like attribute truncation logic into independent functions
towards making it more straightforward to re-purpose this logic. Additionally, formalize the
concept of string canonicalization as a member function that consolidates the process of
decoding URL escape sequences, truncating the decoded string (if applicable), and removing
characters that are considered noise.
- html/parser/XSSAuditor.cpp:
(WebCore::truncateForSrcLikeAttribute): Extracted from XSSAuditor::decodedSnippetForAttribute().
(WebCore::truncateForScriptLikeAttribute): Ditto.
(WebCore::XSSAuditor::init): Write in terms of XSSAuditor::canonicalize().
(WebCore::XSSAuditor::filterCharacterToken): Updated to make use of formalized canonicalization methods.
(WebCore::XSSAuditor::filterScriptToken): Ditto.
(WebCore::XSSAuditor::filterObjectToken): Ditto.
(WebCore::XSSAuditor::filterParamToken): Ditto.
(WebCore::XSSAuditor::filterEmbedToken): Ditto.
(WebCore::XSSAuditor::filterAppletToken): Ditto.
(WebCore::XSSAuditor::filterFrameToken): Ditto.
(WebCore::XSSAuditor::filterInputToken): Ditto.
(WebCore::XSSAuditor::filterButtonToken): Ditto.
(WebCore::XSSAuditor::eraseDangerousAttributesIfInjected): Ditto.
(WebCore::XSSAuditor::eraseAttributeIfInjected): Updated code to use early return style and avoid an unnecessary string
comparison when we know that a src attribute was injected.
(WebCore::XSSAuditor::canonicalizedSnippetForTagName): Renamed; formerly known as XSSAuditor::decodedSnippetForName(). Updated
to make use of XSSAuditor::canonicalize().
(WebCore::XSSAuditor::snippetFromAttribute): Renamed; formerly known as XSSAuditor::decodedSnippetForAttribute(). Moved
truncation logic from here to WebCore::truncateFor{Script, Src}LikeAttribute.
(WebCore::XSSAuditor::canonicalize): Added.
(WebCore::XSSAuditor::canonicalizedSnippetForJavaScript): Added.
(WebCore::canonicalize): Deleted.
(WebCore::XSSAuditor::decodedSnippetForName): Deleted.
(WebCore::XSSAuditor::decodedSnippetForAttribute): Deleted.
(WebCore::XSSAuditor::decodedSnippetForJavaScript): Deleted.
- html/parser/XSSAuditor.h: Define enum class for the various attribute truncation styles.
- 1:06 AM Changeset in webkit [195269] by
-
- 4 edits2 adds in releases/WebKitGTK/webkit-2.10
Merge r195073 - [XSS Auditor] Partial bypass when web server collapses path components
https://bugs.webkit.org/show_bug.cgi?id=152872
Reviewed by Brent Fulgham.
Merged from Blink (patch by Tom Sepez <tsepez@chromium.org>):
<https://src.chromium.org/viewvc/blink?revision=167610&view=revision>
Source/WebCore:
Test: http/tests/security/xssAuditor/embed-tag-in-path-unterminated.html
- html/parser/XSSAuditor.cpp:
(WebCore::isNonCanonicalCharacter):
(WebCore::XSSAuditor::init):
(WebCore::XSSAuditor::decodedSnippetForName):
(WebCore::XSSAuditor::decodedSnippetForAttribute):
(WebCore::XSSAuditor::decodedSnippetForJavaScript):
(WebCore::fullyDecodeString): Deleted.
LayoutTests:
- http/tests/security/xssAuditor/embed-tag-in-path-unterminated-expected.txt: Added.
- http/tests/security/xssAuditor/embed-tag-in-path-unterminated.html: Added.
- http/tests/security/xssAuditor/intercept/.htaccess:
- 1:04 AM Changeset in webkit [195268] by
-
- 2 edits in releases/WebKitGTK/webkit-2.10/Source/WebCore
Merge r195072 - imported/blink/editing/text-iterator/read-past-cloned-first-letter.html crashes
https://bugs.webkit.org/show_bug.cgi?id=153104
-and corresponding-
rdar://problem/24155631
Reviewed by Simon Fraser.
Though we merged the Blink test, we never merged Blink patch that fixed this
bug. So this is a merge of https://github.com/ChromiumWebApps/blink/commit/5a0d23d4368c661f621364339fde66b41ef019e5
- editing/TextIterator.cpp:
(WebCore::SimplifiedBackwardsTextIterator::handleFirstLetter):
- 1:02 AM Changeset in webkit [195267] by
-
- 6 edits2 adds in releases/WebKitGTK/webkit-2.10
Merge r195069 - ASSERTION FAILED: !newRelayoutRoot.container() !newRelayoutRoot.container()->needsLayout() in WebCore::FrameView::scheduleRelayoutOfSubtree https://bugs.webkit.org/show_bug.cgi?id=151605#c1
Reviewed by David Hyatt.
Do not let RenderMultiColumnSet/RenderFlowThread mark ancestors dirty while updating scrollbars
for overflow content. While updating scrollbars, we only layout descendants so marking parents dirty
is unnecessary and could lead to an invalid dirty state.
Source/WebCore:
Test: fast/multicol/body-stuck-with-dirty-bit-with-columns.html
- rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::layoutSpecialExcludedChild):
- rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::invalidateRegions):
- rendering/RenderFlowThread.h:
- rendering/RenderMultiColumnSet.cpp:
(WebCore::RenderMultiColumnSet::prepareForLayout):
LayoutTests:
- fast/multicol/body-stuck-with-dirty-bit-with-columns-expected.txt: Added.
- fast/multicol/body-stuck-with-dirty-bit-with-columns.html: Added.
- 1:00 AM Changeset in webkit [195266] by
-
- 5 edits2 adds in releases/WebKitGTK/webkit-2.10
Merge r195058 - [GTK] [EFL] Hyphenation can never work in practice due to requirements on lang tags
https://bugs.webkit.org/show_bug.cgi?id=147310
Patch by Martin Robinson <mrobinson@igalia.com> on 2016-01-14
Reviewed by Michael Catanzaro.
Source/WebCore:
Test: platform/gtk/fast/text/hyphenate-flexible-locales.html
- platform/text/hyphen/HyphenationLibHyphen.cpp: Make locale matching for dictionary
selection a lot looser by matching case insensitively, matching multiple dictionaries
when only the language is specified, and ignoring the difference between '_' and '-' in
the locale name.
(WebCore::scanDirectoryForDicionaries): Now produce HashMap of Vectors instead of a single
path for each locale. Also add alternate entries to handle different ways of specifying
the locale.
(WebCore::scanTestDictionariesDirectoryIfNecessary): Update to handle the difference
in HashMap type.
(WebCore::availableLocales): Ditto.
(WebCore::canHyphenate): Also look for the lowercased version of the locale.
(WebCore::AtomicStringKeyedMRUCache<RefPtr<HyphenationDictionary>>::createValueForKey):
Key on the dictionary path now so that we can load more than one dictionary per locale.
(WebCore::lastHyphenLocation): Iterate through each matched dictionary in turn.
LayoutTests:
Update some baselines and add a GTK+ specific test for locale variations.
- platform/gtk/fast/text/hyphenate-flexible-locales-expected.html: Added.
- platform/gtk/fast/text/hyphenate-flexible-locales.html: Added.
- platform/gtk/fast/text/hyphenate-locale-expected.png: We now properly hyphenate
text with the 'en' locale.
- platform/gtk/fast/text/hyphenate-locale-expected.txt:
- 12:59 AM Changeset in webkit [195265] by
-
- 24 edits3 adds in releases/WebKitGTK/webkit-2.10
Merge r195010 - Fix problems with cross-origin redirects
https://bugs.webkit.org/show_bug.cgi?id=116075
Reviewed by Daniel Bates.
LayoutTests/imported/w3c:
Rebasing test expectations.
These tests cannot work as expected as WTR/DRT block access to www2.localhost and example.not.
- web-platform-tests/XMLHttpRequest/send-redirect-bogus-expected.txt:
- web-platform-tests/XMLHttpRequest/send-redirect-to-cors-expected.txt:
- web-platform-tests/XMLHttpRequest/send-redirect-to-non-cors-expected.txt:
Source/WebCore:
Merging https://chromium.googlesource.com/chromium/blink/+/7ea774e478f84f355748108d2aaabca15355d512 by Ken Russell
Same origin redirect responses leading to cross-origin requests were checked as cross-origin redirect responses.
Introduced ClientRequestedCredentials to manage whether credentials are needed or not in the cross-origin request.
In addition to Blink patch, it was needed to update some loaders with the newly introduced ClientRequestedCredentials parameter.
Added the clearing of "Accept-Encoding" header from cross-origin requests as Mac HTTP network layer is adding it for same-origin requests.
Test: http/tests/xmlhttprequest/access-control-and-redirects-async-same-origin.html
- loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::startLoadingMainResource): Added new security parameter (from Blink patch).
- loader/DocumentThreadableLoader.cpp:
(WebCore::DocumentThreadableLoader::redirectReceived): Updated checks so that same origin redirections are not treated as cross origin redirections (from Blink patch).
- loader/MediaResourceLoader.cpp:
(WebCore::MediaResourceLoader::start):
- loader/NetscapePlugInStreamLoader.cpp:
(WebCore::NetscapePlugInStreamLoader::NetscapePlugInStreamLoader): Added new security parameter.
- loader/ResourceLoaderOptions.h:
(WebCore::ResourceLoaderOptions::ResourceLoaderOptions): Added new security parameter (from Blink patch).
(WebCore::ResourceLoaderOptions::credentialRequest):
(WebCore::ResourceLoaderOptions::setCredentialRequest):
- loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::requestUserCSSStyleSheet): Ditto.
(WebCore::CachedResourceLoader::defaultCachedResourceOptions): Ditto.
- loader/icon/IconLoader.cpp:
(WebCore::IconLoader::startLoading): Added new security parameter.
- page/EventSource.cpp:
(WebCore::EventSource::connect): Added new security parameter (from Blink patch).
- platform/graphics/avfoundation/cf/WebCoreAVCFResourceLoader.cpp:
(WebCore::WebCoreAVCFResourceLoader::startLoading): Added new security parameter.
- platform/graphics/avfoundation/objc/WebCoreAVFResourceLoader.mm:
(WebCore::WebCoreAVFResourceLoader::startLoading): Ditto.
- platform/network/ResourceHandleTypes.h: Added new security parameter constants (from Blink patch).
- platform/network/ResourceRequestBase.cpp:
(WebCore::ResourceRequestBase::clearHTTPAcceptEncoding): Function to remove "Accept-Encoding" header.
- platform/network/ResourceRequestBase.h: Ditto.
- xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::createRequest): Added new security parameter.
LayoutTests:
Merging https://chromium.googlesource.com/chromium/blink/+/7ea774e478f84f355748108d2aaabca15355d512 by Ken Russell
This merge adds tests for cross origin requests triggered from same origin redirection responses with and without credentials).
Rebaseline of some tests due to console error messages generated from newly hit CORS checks.
- TestExpectations: Disabled WPT tests that require access to non localhost URLs which are currently blocked by DTR/WTR.
- http/tests/xmlhttprequest/access-control-and-redirects-async-expected.txt:
- http/tests/xmlhttprequest/access-control-and-redirects-async-same-origin-expected.txt: Added.
- http/tests/xmlhttprequest/access-control-and-redirects-async-same-origin.html: Added.
- http/tests/xmlhttprequest/access-control-and-redirects-async.html:
- http/tests/xmlhttprequest/access-control-and-redirects-expected.txt:
- http/tests/xmlhttprequest/access-control-and-redirects.html:
- http/tests/xmlhttprequest/redirect-cross-origin-2-expected.txt:
- http/tests/xmlhttprequest/redirect-cross-origin-expected.txt:
- http/tests/xmlhttprequest/redirect-cross-origin-post-expected.txt:
- http/tests/xmlhttprequest/redirect-cross-origin-tripmine-expected.txt:
- http/tests/xmlhttprequest/resources/access-control-basic-allow-no-credentials.cgi: Added.
- http/tests/xmlhttprequest/xmlhttprequest-unsafe-redirect-expected.txt:
- 12:58 AM Changeset in webkit [195264] by
-
- 12 edits in trunk/Source
CharacterData::setData doesn't need ExceptionCode as an out argument
https://bugs.webkit.org/show_bug.cgi?id=153225
Reviewed by Antti Koivisto.
Source/WebCore:
Removed the ExceptionCode out argument from CharacterData::setData since it's never used.
- dom/CharacterData.cpp:
(WebCore::CharacterData::setData):
(WebCore::CharacterData::containsOnlyWhitespace):
(WebCore::CharacterData::setNodeValue):
(WebCore::CharacterData::setDataAndUpdate):
- dom/CharacterData.h:
(WebCore::CharacterData::data):
(WebCore::CharacterData::dataMemoryOffset):
(WebCore::CharacterData::length):
- dom/CharacterData.idl:
- dom/Range.cpp:
(WebCore::Range::processContentsBetweenOffsets):
- dom/Text.cpp:
(WebCore::Text::replaceWholeText):
- editing/markup.cpp:
(WebCore::replaceChildrenWithFragment):
(WebCore::replaceChildrenWithText):
- html/HTMLOptionElement.cpp:
(WebCore::HTMLOptionElement::setText):
- html/HTMLScriptElement.cpp:
(WebCore::HTMLScriptElement::setText):
- html/HTMLTitleElement.cpp:
(WebCore::HTMLTitleElement::setText):
Source/WebKit2:
- WebProcess/InjectedBundle/API/mac/WKDOMText.mm:
(-[WKDOMText setData:]):
- 12:39 AM Changeset in webkit [195263] by
-
- 10 edits2 adds in trunk
innerHTML should always add a mutation record for removing all children
https://bugs.webkit.org/show_bug.cgi?id=148782
<rdar://problem/22571962>
Reviewed by Antti Koivisto.
LayoutTests/imported/w3c:
Rebaseline a test now that all test test cases are passing.
- web-platform-tests/dom/nodes/MutationObserver-inner-outer-expected.txt:
Source/WebCore:
Fixed the bug by disabling WebKit's optimization to avoid the node replacement when the behavior
is observable to scripts by either:
- Author scripts has a reference to the node
- MutationObserver can be observing this subtree
- Mutation events can be observing this subtree
Note that no caller of this function exposes fragment to author scripts so it couldn't be referenced.
It also means that we don't need to check DOMNodeInsertedIntoDocument since it doesn't bubble up
(it's only relevant if the text node in fragment has its event listener but that's impossible).
Test: fast/dom/innerHTML-single-text-node.html
- dom/ChildListMutationScope.h:
(WebCore::ChildListMutationScope::canObserve): Added.
- editing/markup.cpp:
(WebCore::hasMutationEventListeners): Added.
(WebCore::replaceChildrenWithFragment):
LayoutTests:
Add a more comprehensive test for replacing a single text node with innerHTML's setter to ensure
WebKit's optimization to avoid replacing the node should not be observable by scripts in any way.
- fast/dom/innerHTML-single-text-node-expected.txt: Added.
- fast/dom/innerHTML-single-text-node.html: Added.
- 12:29 AM Changeset in webkit [195262] by
-
- 3 edits in releases/WebKitGTK/webkit-2.10/Source/WebCore
Merge r194982 - Cleanup: XSS Auditor should avoid re-evaluating the parsed script tag
https://bugs.webkit.org/show_bug.cgi?id=152870
Patch by Daniel Bates <dabates@apple.com> on 2016-01-13
Reviewed by Brent Fulgham.
Merged from Blink (patch by Tom Sepez <tsepez@chromium.org>):
<https://src.chromium.org/viewvc/blink?revision=154354&view=revision>
Although the XSS Auditor caches the decoded start tag of a script as an optimization to
avoid decoding it again when filtering the character data of the script, it is sufficient
to cache whether the HTTP response contains the decoded start tag of a script. This
avoids both decoding the start tag of a script and determining whether the HTTP response
contains it again when filtering the character data of the script. Moreover, this removes
the need to cache a string object.
- html/parser/XSSAuditor.cpp:
(WebCore::XSSAuditor::filterCharacterToken):
(WebCore::XSSAuditor::filterScriptToken):
- html/parser/XSSAuditor.h:
- 12:29 AM Changeset in webkit [195261] by
-
- 3 edits2 adds in releases/WebKitGTK/webkit-2.10
Merge r194979 - [XSS Auditor] Do not include trailing comment characters in JavaScript snippets
https://bugs.webkit.org/show_bug.cgi?id=152873
Patch by Daniel Bates <dabates@apple.com> on 2016-01-13
Reviewed by Brent Fulgham.
Merged from Blink (patch by Tom Sepez <tsepez@chromium.org>):
<https://src.chromium.org/viewvc/blink?view=rev&revision=169967>
Source/WebCore:
Test: http/tests/security/xssAuditor/script-tag-with-injected-comment.html
- html/parser/XSSAuditor.cpp:
(WebCore::XSSAuditor::decodedSnippetForJavaScript):
LayoutTests:
- http/tests/security/xssAuditor/script-tag-with-injected-comment-expected.txt: Added.
- http/tests/security/xssAuditor/script-tag-with-injected-comment.html: Added.
- 12:28 AM Changeset in webkit [195260] by
-
- 3 edits5 adds in releases/WebKitGTK/webkit-2.10
Merge r194978 - [XSS Auditor] Add test when XSS payload is in the path portion of the URL
https://bugs.webkit.org/show_bug.cgi?id=152871
Patch by Daniel Bates <dabates@apple.com> on 2016-01-13
Reviewed by Brent Fulgham.
Merged from Blink (patch by Tom Sepez <tsepez@chromium.org>):
<https://src.chromium.org/viewvc/blink?revision=164746&view=revision>
Tools:
- Scripts/webkitpy/layout_tests/servers/lighttpd.conf:
LayoutTests:
Add infrastructure and a test for an XSS attack where the payload is
embedded in the path portion of the URL.
Many XSS Auditor tests pass the XSS payload to CGI scripts via the
query string portion of the URL. Now we also support calling these
same scripts with the payload embedded in the path portion of the
URL.
Loading <http://127.0.0.1:8000/security/xssAuditor/intercept/X/Y>
returns a response whose content is identical to <http://127.0.0.1:8000/security/xssAuditor/resoures/X?q=Y>,
where X is the filename of some CGI script in directory LayoutTests/http/tests/security/xssAuditor/resources
and Y is the XSS payload.
- http/tests/security/xssAuditor/intercept/.htaccess: Added.
- http/tests/security/xssAuditor/reflection-in-path-expected.txt: Added.
- http/tests/security/xssAuditor/reflection-in-path.html: Added.
- http/tests/security/xssAuditor/resources/echo-form-action.pl: Added.
- 12:26 AM Changeset in webkit [195259] by
-
- 30 edits in releases/WebKitGTK/webkit-2.10/Source/WebCore
Merge r194964 - Reference cycle between SVGPathElement and SVGPathSegWithContext leaks Document
https://bugs.webkit.org/show_bug.cgi?id=151810
Patch by Said Abou-Hallawa <sabouhallawa@apple.com> on 2016-01-13
Reviewed by Darin Adler.
Break the reference cycle between SVGPathElement and SVGPathSegWithContext
by changing the back-pointer to be a WeakPtr pointer instead of having it
RefPtr. Make sure the SVGPathSegWithContext derived classes handle correctly
the case when the SVGPathElement back-pointer is deleted.
Also change the SVGPathElement argument to the SVGPathSeg creation functions
and constructors to be a const reference instead of having it as a pointer
since SVGPathElement is the class factory for all these classes.
- svg/SVGPathElement.cpp:
(WebCore::SVGPathElement::SVGPathElement):
(WebCore::SVGPathElement::createSVGPathSegClosePath):
(WebCore::SVGPathElement::createSVGPathSegMovetoAbs):
(WebCore::SVGPathElement::createSVGPathSegMovetoRel):
(WebCore::SVGPathElement::createSVGPathSegLinetoAbs):
(WebCore::SVGPathElement::createSVGPathSegLinetoRel):
(WebCore::SVGPathElement::createSVGPathSegCurvetoCubicAbs):
(WebCore::SVGPathElement::createSVGPathSegCurvetoCubicRel):
(WebCore::SVGPathElement::createSVGPathSegCurvetoQuadraticAbs):
(WebCore::SVGPathElement::createSVGPathSegCurvetoQuadraticRel):
(WebCore::SVGPathElement::createSVGPathSegArcAbs):
(WebCore::SVGPathElement::createSVGPathSegArcRel):
(WebCore::SVGPathElement::createSVGPathSegLinetoHorizontalAbs):
(WebCore::SVGPathElement::createSVGPathSegLinetoHorizontalRel):
(WebCore::SVGPathElement::createSVGPathSegLinetoVerticalAbs):
(WebCore::SVGPathElement::createSVGPathSegLinetoVerticalRel):
(WebCore::SVGPathElement::createSVGPathSegCurvetoCubicSmoothAbs):
(WebCore::SVGPathElement::createSVGPathSegCurvetoCubicSmoothRel):
(WebCore::SVGPathElement::createSVGPathSegCurvetoQuadraticSmoothAbs):
(WebCore::SVGPathElement::createSVGPathSegCurvetoQuadraticSmoothRel):
(WebCore::SVGPathElement::isSupportedAttribute):
- svg/SVGPathElement.h:
- svg/SVGPathSegArc.h:
(WebCore::SVGPathSegArc::SVGPathSegArc):
- svg/SVGPathSegArcAbs.h:
(WebCore::SVGPathSegArcAbs::create):
(WebCore::SVGPathSegArcAbs::SVGPathSegArcAbs):
- svg/SVGPathSegArcRel.h:
(WebCore::SVGPathSegArcRel::create):
(WebCore::SVGPathSegArcRel::SVGPathSegArcRel):
- svg/SVGPathSegClosePath.h:
(WebCore::SVGPathSegClosePath::create):
(WebCore::SVGPathSegClosePath::SVGPathSegClosePath):
- svg/SVGPathSegCurvetoCubic.h:
(WebCore::SVGPathSegCurvetoCubic::SVGPathSegCurvetoCubic):
- svg/SVGPathSegCurvetoCubicAbs.h:
(WebCore::SVGPathSegCurvetoCubicAbs::create):
(WebCore::SVGPathSegCurvetoCubicAbs::SVGPathSegCurvetoCubicAbs):
- svg/SVGPathSegCurvetoCubicRel.h:
(WebCore::SVGPathSegCurvetoCubicRel::create):
(WebCore::SVGPathSegCurvetoCubicRel::SVGPathSegCurvetoCubicRel):
- svg/SVGPathSegCurvetoCubicSmooth.h:
(WebCore::SVGPathSegCurvetoCubicSmooth::SVGPathSegCurvetoCubicSmooth):
- svg/SVGPathSegCurvetoCubicSmoothAbs.h:
(WebCore::SVGPathSegCurvetoCubicSmoothAbs::create):
(WebCore::SVGPathSegCurvetoCubicSmoothAbs::SVGPathSegCurvetoCubicSmoothAbs):
- svg/SVGPathSegCurvetoCubicSmoothRel.h:
(WebCore::SVGPathSegCurvetoCubicSmoothRel::create):
(WebCore::SVGPathSegCurvetoCubicSmoothRel::SVGPathSegCurvetoCubicSmoothRel):
- svg/SVGPathSegCurvetoQuadratic.h:
(WebCore::SVGPathSegCurvetoQuadratic::SVGPathSegCurvetoQuadratic):
- svg/SVGPathSegCurvetoQuadraticAbs.h:
(WebCore::SVGPathSegCurvetoQuadraticAbs::create):
(WebCore::SVGPathSegCurvetoQuadraticAbs::SVGPathSegCurvetoQuadraticAbs):
- svg/SVGPathSegCurvetoQuadraticRel.h:
(WebCore::SVGPathSegCurvetoQuadraticRel::create):
(WebCore::SVGPathSegCurvetoQuadraticRel::SVGPathSegCurvetoQuadraticRel):
- svg/SVGPathSegCurvetoQuadraticSmoothAbs.h:
(WebCore::SVGPathSegCurvetoQuadraticSmoothAbs::create):
(WebCore::SVGPathSegCurvetoQuadraticSmoothAbs::SVGPathSegCurvetoQuadraticSmoothAbs):
- svg/SVGPathSegCurvetoQuadraticSmoothRel.h:
(WebCore::SVGPathSegCurvetoQuadraticSmoothRel::create):
(WebCore::SVGPathSegCurvetoQuadraticSmoothRel::SVGPathSegCurvetoQuadraticSmoothRel):
- svg/SVGPathSegLinetoAbs.h:
(WebCore::SVGPathSegLinetoAbs::create):
(WebCore::SVGPathSegLinetoAbs::SVGPathSegLinetoAbs):
- svg/SVGPathSegLinetoHorizontal.h:
(WebCore::SVGPathSegLinetoHorizontal::SVGPathSegLinetoHorizontal):
- svg/SVGPathSegLinetoHorizontalAbs.h:
(WebCore::SVGPathSegLinetoHorizontalAbs::create):
(WebCore::SVGPathSegLinetoHorizontalAbs::SVGPathSegLinetoHorizontalAbs):
- svg/SVGPathSegLinetoHorizontalRel.h:
(WebCore::SVGPathSegLinetoHorizontalRel::create):
(WebCore::SVGPathSegLinetoHorizontalRel::SVGPathSegLinetoHorizontalRel):
- svg/SVGPathSegLinetoRel.h:
(WebCore::SVGPathSegLinetoRel::create):
(WebCore::SVGPathSegLinetoRel::SVGPathSegLinetoRel):
- svg/SVGPathSegLinetoVertical.h:
(WebCore::SVGPathSegLinetoVertical::SVGPathSegLinetoVertical):
- svg/SVGPathSegLinetoVerticalAbs.h:
(WebCore::SVGPathSegLinetoVerticalAbs::create):
(WebCore::SVGPathSegLinetoVerticalAbs::SVGPathSegLinetoVerticalAbs):
- svg/SVGPathSegLinetoVerticalRel.h:
(WebCore::SVGPathSegLinetoVerticalRel::create):
(WebCore::SVGPathSegLinetoVerticalRel::SVGPathSegLinetoVerticalRel):
- svg/SVGPathSegMovetoAbs.h:
(WebCore::SVGPathSegMovetoAbs::create):
(WebCore::SVGPathSegMovetoAbs::SVGPathSegMovetoAbs):
- svg/SVGPathSegMovetoRel.h:
(WebCore::SVGPathSegMovetoRel::create):
(WebCore::SVGPathSegMovetoRel::SVGPathSegMovetoRel):
- svg/SVGPathSegWithContext.h:
(WebCore::SVGPathSegWithContext::SVGPathSegWithContext):
(WebCore::SVGPathSegWithContext::animatedProperty):
(WebCore::SVGPathSegWithContext::contextElement):
(WebCore::SVGPathSegWithContext::setContextAndRole):
(WebCore::SVGPathSegWithContext::commitChange):
(WebCore::SVGPathSegSingleCoordinate::setY):
(WebCore::SVGPathSegSingleCoordinate::SVGPathSegSingleCoordinate):
- svg/properties/SVGPathSegListPropertyTearOff.cpp:
(WebCore::SVGPathSegListPropertyTearOff::clearContextAndRoles):
(WebCore::SVGPathSegListPropertyTearOff::replaceItem):
(WebCore::SVGPathSegListPropertyTearOff::removeItem):
- 12:23 AM Changeset in webkit [195258] by
-
- 2 edits in releases/WebKitGTK/webkit-2.10/Source/WebCore
Merge r194961 - [TexMap] BitmapTextureGL is not released while scene is updated continuously.
https://bugs.webkit.org/show_bug.cgi?id=152524
Patch by YongGeol Jung <yg48.jung@samsung.com> on 2016-01-13
Reviewed by Žan Doberšek.
This patch fixes two issues.
First, m_releaseUnusedTexturesTimer is not fired if scene is updated within 0.5s continuously.
In this case, BitmapTexturePool will not remove texture even if texture is not used for long time.
Second, m_releaseUnusedTexturesTimer is triggered by acquireTexture function only.
So, if next scene does not need to use BitmapTexture, remained textures in pool will not removed.
No new tests needed.
- platform/graphics/texmap/BitmapTexturePool.cpp:
(WebCore::BitmapTexturePool::scheduleReleaseUnusedTextures):
(WebCore::BitmapTexturePool::releaseUnusedTexturesTimerFired):
- 12:22 AM Changeset in webkit [195257] by
-
- 27 edits2 adds in releases/WebKitGTK/webkit-2.10
Merge r194927 - XSS Auditor should navigate to empty substitute data on full page block
https://bugs.webkit.org/show_bug.cgi?id=152868
<rdar://problem/18658448>
Reviewed by David Kilzer and Andy Estes.
Derived from Blink patch (by Tom Sepez <tsepez@chromium.org>):
<https://src.chromium.org/viewvc/blink?view=rev&revision=179240>
Source/WebCore:
Test: http/tests/security/xssAuditor/block-does-not-leak-that-page-was-blocked-using-empty-data-url.html
- html/parser/XSSAuditorDelegate.cpp:
(WebCore::XSSAuditorDelegate::didBlockScript): Modified to call NavigationScheduler::schedulePageBlock().
- loader/NavigationScheduler.cpp:
(WebCore::ScheduledPageBlock::ScheduledPageBlock): Added.
(WebCore::NavigationScheduler::schedulePageBlock): Navigate to empty substitute data with
the same URL as the originating document.
- loader/NavigationScheduler.h:
LayoutTests:
Added additional test block-does-not-leak-that-page-was-blocked-using-empty-data-url.html to explicitly
tests that we do redirect to an empty data URL when a full page block is triggered.
- http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-allow-block-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-block-allow-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-block-block-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-block-filter-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-block-invalid-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-block-unset-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-filter-block-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-invalid-block-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-unset-block-expected.txt:
- http/tests/security/xssAuditor/block-does-not-leak-location-expected.txt:
- http/tests/security/xssAuditor/block-does-not-leak-referrer-expected.txt:
- http/tests/security/xssAuditor/block-does-not-leak-that-page-was-blocked-using-empty-data-url-expected.txt: Added.
- http/tests/security/xssAuditor/block-does-not-leak-that-page-was-blocked-using-empty-data-url.html: Added.
- http/tests/security/xssAuditor/full-block-base-href-expected.txt:
- http/tests/security/xssAuditor/full-block-iframe-javascript-url-expected.txt:
- http/tests/security/xssAuditor/full-block-javascript-link-expected.txt:
- http/tests/security/xssAuditor/full-block-link-onclick-expected.txt:
- http/tests/security/xssAuditor/full-block-object-tag-expected.txt:
- http/tests/security/xssAuditor/full-block-script-tag-cross-domain-expected.txt:
- http/tests/security/xssAuditor/full-block-script-tag-expected.txt:
- http/tests/security/xssAuditor/full-block-script-tag-with-source-expected.txt:
- http/tests/security/xssAuditor/full-block-script-tag.html:
- http/tests/security/xssAuditor/xss-protection-parsing-03-expected.txt:
- http/tests/security/xssAuditor/xss-protection-parsing-04-expected.txt:
- 12:12 AM Changeset in webkit [195256] by
-
- 2 edits in releases/WebKitGTK/webkit-2.10/Source/WebKit2
Merge r194925 - WebPageProxy should reattach to the web process before navigating
https://bugs.webkit.org/show_bug.cgi?id=153026
Reviewed by Anders Carlsson.
This fixes a crash (and lots of other corruption) when force-quitting
the web process during navigation.
Some objects (like ViewGestureController) use one-time initialization
to point to a ChildProcessProxy -- and, by design, we destroy them when
the ChildProcessProxy becomes invalid (i.e., crashes or quits).
If we navigate *before* creating a new, valid ChildProcessProxy, then
we accidentally re-create these objects pointing to the old, invalid
ChildProcessProxy.
We need to wait until we have a valid ChildProcessProxy before we
initialize these objects.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::reattachToWebProcessWithItem): Navigate after
reattaching to the web process so that lazily allocated helper objects
point to the right ChildProcessProxy.
- 12:09 AM Changeset in webkit [195255] by
-
- 2 edits in releases/WebKitGTK/webkit-2.10/Source/WebCore/platform/gtk/po
Merge r194907 - [l10n] Updated French translation for WebKitGTK+
https://bugs.webkit.org/show_bug.cgi?id=153013
Patch by Sam Friedmann <sfriedma@redhat.com> on 2016-01-12
Rubber-stamped by Michael Catanzaro.
- fr.po:
- 12:09 AM Changeset in webkit [195254] by
-
- 4 edits3 adds in releases/WebKitGTK/webkit-2.10
Merge r194898 - Don't reuse memory cache entries with different charset
https://bugs.webkit.org/show_bug.cgi?id=110031
Source/WebCore:
rdar://problem/13666418
Reviewed by Andreas Kling.
Test: fast/loader/cache-encoding.html
- loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::requestResource):
(WebCore::logResourceRevalidationDecision):
(WebCore::CachedResourceLoader::determineRevalidationPolicy):
Pass full CachedResourceRequest to the function.
If charset differs don't reuse the cache entry.
- loader/cache/CachedResourceLoader.h:
LayoutTests:
Reviewed by Andreas Kling.
- fast/loader/cache-encoding-expected.txt: Added.
- fast/loader/cache-encoding.html: Added.
- fast/loader/resources/success.js: Added.
- 12:01 AM Changeset in webkit [195253] by
-
- 2 edits in releases/WebKitGTK/webkit-2.10/Source/WebKit2
Merge r194890 - [GTK] UI process crashes if webkit_web_view_get_tls_info is called before internal load-committed event
https://bugs.webkit.org/show_bug.cgi?id=142375
Reviewed by Michael Catanzaro.
Remove all the hacks to emit delayed load events now that the
page cache resource load delegates are consistent with all other
resource loads.
- UIProcess/API/gtk/WebKitWebView.cpp:
(webkitWebViewLoadChanged):
(webkitWebViewResourceLoadStarted):
(webkit_web_view_get_tls_info): Add a g_return_val_if_fail to
prevent this function from being misused.
(webkitWebViewDisconnectMainResourceResponseChangedSignalHandler): Deleted.
(webkitWebViewDispose): Deleted.
(webkitWebViewEmitLoadChanged): Deleted.
(webkitWebViewEmitDelayedLoadEvents): Deleted.
(mainResourceResponseChangedCallback): Deleted.
(waitForMainResourceResponseIfWaitingForResource): Deleted.
Jan 18, 2016:
- 11:57 PM Changeset in webkit [195252] by
-
- 4 edits3 adds in releases/WebKitGTK/webkit-2.10
Merge r194888 - Inconsistencies in main resource load delegates when loading from history
https://bugs.webkit.org/show_bug.cgi?id=150927
Reviewed by Michael Catanzaro.
Source/WebCore:
When restoring a page from the page cache, even though there
isn't an actual load of resources, we are still emitting the load
delegates to let the API layer know there are contents being
loaded in the web view. This makes the page cache restoring
transparent for the API layer. However, when restoring a page from
the cache, all the delegates are emitted after the load is
committed. This is not consistent with real loads, where we first
load the main resource and once we get a response we commit the
load. This inconsistency is problematic if the API layer expects
to always have a main resource with a response when the load is
committed. This is the case of the GTK+ port, for example. So,
this patch ensures that when a page is restored from the page
cache, the main resource load delegates that are emitted until a
response is received in normal loads, are emitted before the load
is committed.
Test: http/tests/loading/main-resource-delegates-on-back-navigation.html
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::commitProvisionalLoad): When loading from
the page cache, send delegate messages up to didReceiveResponse
for the main resource before the load is committed, and the
remaining messages afterwards.
LayoutTests:
Add test to check that main resource load delegates are emitted in
the same order before the load is committed when loading a page
from history with the page cache enabled and disabled.
- http/tests/loading/main-resource-delegates-on-back-navigation-expected.txt: Added.
- http/tests/loading/main-resource-delegates-on-back-navigation.html: Added.
- http/tests/loading/resources/page-go-back-onload.html: Added.
- loader/go-back-cached-main-resource-expected.txt:
- 11:51 PM Changeset in webkit [195251] by
-
- 3 edits2 adds in releases/WebKitGTK/webkit-2.10
Merge r194867 - Padding added to table-cell element after font-size change.
https://bugs.webkit.org/show_bug.cgi?id=152796
Reviewed by David Hyatt.
Do not include intrinsicPaddingBefore value while figuring out the height of a row.
In RenderTableSection::calcRowLogicalHeight() we are interested in the height of the content
without the additional padding (normal padding is included).
Source/WebCore:
Test: fast/table/table-baseline-grows.html
- rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::calcRowLogicalHeight):
LayoutTests:
- TestExpectations: This test fails even without the patch when Ahem font is not used.
- fast/table/table-baseline-grows-expected.html: Added.
- fast/table/table-baseline-grows.html: Added.
- 11:44 PM Changeset in webkit [195250] by
-
- 2 edits in releases/WebKitGTK/webkit-2.10/Source/WebKit2
Merge r194846 - [WK2][GTK] Propagate motion-notify-event signals from the WebView
https://bugs.webkit.org/show_bug.cgi?id=152974
Reviewed by Carlos Garcia Campos.
Always propagate motion-notify-event signals, regardless of what the
web process does, so that we can listen for those events (which does
not act on specific targets inside the webview) from the container
widget too, and not just from the WebView itself.
- UIProcess/API/gtk/WebKitWebViewBase.cpp:
(webkitWebViewBaseMotionNotifyEvent): Ensure the signal gets propagated.
- 11:41 PM Changeset in webkit [195249] by
-
- 3 edits2 adds in releases/WebKitGTK/webkit-2.10
Merge r194823 - REGRESSION (r194426): First email field is not autofilled on amazon.com
https://bugs.webkit.org/show_bug.cgi?id=152945
<rdar://problem/24082914>
Reviewed by Simon Fraser.
r194426 missed marking the m_layoutRoot for layout while converting to full layout (it only marked the new layout root).
Source/WebCore:
Test: fast/forms/multiple-subtree-layout-failure.html
- page/FrameView.cpp:
(WebCore::FrameView::scheduleRelayoutOfSubtree):
LayoutTests:
- fast/forms/multiple-subtree-layout-failure-expected.html: Added.
- fast/forms/multiple-subtree-layout-failure.html: Added.
- 11:37 PM Changeset in webkit [195248] by
-
- 13 edits1 copy1 move1 add in trunk
createAttribute should lowercase the attribute name in a HTML document
https://bugs.webkit.org/show_bug.cgi?id=153112
Reviewed by Darin Adler.
LayoutTests/imported/w3c:
Rebaseline a test now that it's passing all test cases.
- web-platform-tests/dom/nodes/Document-createAttribute-expected.txt:
Source/WebCore:
In a HTML document, we should always lowercase localName in document.createAttribute as specified in
https://dom.spec.whatwg.org/#dom-document-createattribute:
- If localName does not match the Name production in XML, throw an InvalidCharacterError exception.
- If the context object is an HTML document, let localName be converted to ASCII lowercase.
- Return a new attribute whose local name is localName.
Change WebKit's behavior to match the spec as well as Firefox. document.createAttributeNS will
continue to preserve the case as spec'ed.
No new tests are added since the behavior change is covered by existing tests.
- dom/Document.cpp:
(WebCore::Document::createAttribute):
LayoutTests:
Update tests, rebaseline tests, and add more test cases as needed.
createAttribute lowercases localName and getAttributeNode finds attribute ignoring cases
whereas createAttributeNS preserves localName's case and getAttributeNodeNS finds attribute preserving cases
- fast/dom/Element/mozilla-dom-base-tests/test_bug1075702-expected.txt: Since the test is adding "aa" as well
as "AA" as Attr nodes, we should be able to get both.
- fast/dom/Element/mozilla-dom-base-tests/test_bug1075702.xhtml: Renamed from .html file since test cases here
are more relevant for XHTML documents.
- fast/dom/Element/getAttribute-check-case-sensitivity-expected.txt:
- fast/dom/Element/script-tests/getAttribute-check-case-sensitivity.js:
(testGetAttributeNodeMixedCase): Change the test case to retrieve the attribute name with lowercase name
since createAttribute always lowercases the name in a HTML document.
(testAttribNodeNamePreservesCase): Use getAttributeNode instead of getAttributeNodeNS since the former does
case insensitive lookup as needed here.
(testAttribNodeNamePreservesCaseGetNode): Ditto.
(testAttribNodeNamePreservesCaseGetNode2): Ditto. Use createAttributeNS to create a case-preserving Attr node.
- fast/dom/Element/setAttributeNode-case-insensitivity-expected.txt:
- fast/dom/Element/setAttributeNode-case-insensitivity.html: Since getAttributeNode does a case-insensitive
lookup, we should be getting the same Attr node for both 'style' and 'STYLE'.
- fast/dom/Element/setAttributeNode-for-existing-attribute-expected.txt: Rebaselined. This is a progression
since we're now getting "green" when querying style.backgroundColor as expected.
- fast/dom/Element/setAttributeNode-overriding-lowercase-values-1-expected.txt:
- fast/dom/Element/setAttributeNode-overriding-lowercase-values-1.html: Updated test cases for new behavior.
- fast/dom/Element/setAttributeNode-overriding-lowercase-values-1-xml-expected.txt: Added.
- fast/dom/Element/setAttributeNode-overriding-lowercase-values-1-xml.xhtml: Added. Test behaviors in a XML
document.
- 10:02 PM Changeset in webkit [195247] by
-
- 9 edits1 copy301 adds in trunk
Modern IDB: Add private-browsing variant for many IDB tests, and enable private browsing in Modern IDB.
https://bugs.webkit.org/show_bug.cgi?id=153179
Reviewed by Darin Adler.
Source/WebCore:
Tests: Many private-browsing copies of existing IDB tests.
- Modules/indexeddb/client/IDBFactoryImpl.cpp:
(WebCore::IDBClient::shouldThrowSecurityException): Allow IDB access in private browsing.
LayoutTests:
Update many expectations files to skip some of the new tests on some platforms:
- TestExpectations:
- platform/mac-wk1/TestExpectations:
- platform/wk2/TestExpectations:
Add a special case for URLs that end with "-private.html" to enable private browsing:
- resources/js-test.js:
Add a whole bunch of -private.html wrappers along with new test expectations, along
with some minor test changes to remove unnecessary ambiguity due to .html filename:
- storage/indexeddb/aborted-versionchange-closes-private-expected.txt: Added.
- storage/indexeddb/aborted-versionchange-closes-private.html: Added.
- storage/indexeddb/basics-private-expected.txt: Added.
- storage/indexeddb/basics-private.html: Added.
- storage/indexeddb/create-and-remove-object-store-private-expected.txt: Added.
- storage/indexeddb/create-and-remove-object-store-private.html: Added.
- storage/indexeddb/create-object-store-options-private-expected.txt: Added.
- storage/indexeddb/create-object-store-options-private.html: Added.
- storage/indexeddb/createIndex-after-failure-private-expected.txt: Added.
- storage/indexeddb/createIndex-after-failure-private.html: Added.
- storage/indexeddb/createObjectStore-name-argument-required-private-expected.txt: Added.
- storage/indexeddb/createObjectStore-name-argument-required-private.html: Added.
- storage/indexeddb/createObjectStore-null-name-private-expected.txt: Added.
- storage/indexeddb/createObjectStore-null-name-private.html: Added.
- storage/indexeddb/cursor-added-bug-private-expected.txt: Added.
- storage/indexeddb/cursor-added-bug-private.html: Added.
- storage/indexeddb/cursor-advance-private-expected.txt: Added.
- storage/indexeddb/cursor-advance-private.html: Added.
- storage/indexeddb/cursor-basics-private-expected.txt: Added.
- storage/indexeddb/cursor-basics-private.html: Added.
- storage/indexeddb/cursor-continue-dir-private-expected.txt: Added.
- storage/indexeddb/cursor-continue-dir-private.html: Added.
- storage/indexeddb/cursor-continue-private-expected.txt: Added.
- storage/indexeddb/cursor-continue-private.html: Added.
- storage/indexeddb/cursor-continue-validity-private-expected.txt: Added.
- storage/indexeddb/cursor-continue-validity-private.html: Added.
- storage/indexeddb/cursor-delete-private-expected.txt: Added.
- storage/indexeddb/cursor-delete-private.html: Added.
- storage/indexeddb/cursor-finished-private-expected.txt: Added.
- storage/indexeddb/cursor-finished-private.html: Added.
- storage/indexeddb/cursor-inconsistency-private-expected.txt: Added.
- storage/indexeddb/cursor-inconsistency-private.html: Added.
- storage/indexeddb/cursor-index-delete-private-expected.txt: Added.
- storage/indexeddb/cursor-index-delete-private.html: Added.
- storage/indexeddb/cursor-key-order-private-expected.txt: Added.
- storage/indexeddb/cursor-key-order-private.html: Added.
- storage/indexeddb/cursor-prev-no-duplicate-private-expected.txt: Added.
- storage/indexeddb/cursor-prev-no-duplicate-private.html: Added.
- storage/indexeddb/cursor-primary-key-order-private-expected.txt: Added.
- storage/indexeddb/cursor-primary-key-order-private.html: Added.
- storage/indexeddb/cursor-properties-private-expected.txt: Added.
- storage/indexeddb/cursor-properties-private.html: Added.
- storage/indexeddb/cursor-reverse-bug-private-expected.txt: Added.
- storage/indexeddb/cursor-reverse-bug-private.html: Added.
- storage/indexeddb/cursor-skip-deleted-private-expected.txt: Added.
- storage/indexeddb/cursor-skip-deleted-private.html: Added.
- storage/indexeddb/cursor-update-private-expected.txt: Added.
- storage/indexeddb/cursor-update-private.html: Added.
- storage/indexeddb/cursor-update-value-argument-required-private-expected.txt: Added.
- storage/indexeddb/cursor-update-value-argument-required-private.html: Added.
- storage/indexeddb/cursor-value-private-expected.txt: Added.
- storage/indexeddb/cursor-value-private.html: Added.
- storage/indexeddb/database-basics-private-expected.txt: Added.
- storage/indexeddb/database-basics-private.html: Added.
- storage/indexeddb/database-close-private-expected.txt: Added.
- storage/indexeddb/database-close-private.html: Added.
- storage/indexeddb/database-closepending-flag-private-expected.txt: Added.
- storage/indexeddb/database-closepending-flag-private.html: Added.
- storage/indexeddb/database-deletepending-flag-private-expected.txt: Added.
- storage/indexeddb/database-deletepending-flag-private.html: Added.
- storage/indexeddb/database-name-undefined-private-expected.txt: Added.
- storage/indexeddb/database-name-undefined-private.html: Added.
- storage/indexeddb/database-odd-names-private-expected.txt: Added.
- storage/indexeddb/database-odd-names-private.html: Added.
- storage/indexeddb/database-quota-private-expected.txt: Added.
- storage/indexeddb/database-quota-private.html: Added.
- storage/indexeddb/database-wrapper-private-expected.txt: Added.
- storage/indexeddb/database-wrapper-private.html: Added.
- storage/indexeddb/delete-closed-database-object-private-expected.txt: Added.
- storage/indexeddb/delete-closed-database-object-private.html: Added.
- storage/indexeddb/delete-in-upgradeneeded-close-in-open-success-private-expected.txt: Added.
- storage/indexeddb/delete-in-upgradeneeded-close-in-open-success-private.html: Added.
- storage/indexeddb/delete-in-upgradeneeded-close-in-versionchange-private-expected.txt: Added.
- storage/indexeddb/delete-in-upgradeneeded-close-in-versionchange-private.html: Added.
- storage/indexeddb/delete-range-private-expected.txt: Added.
- storage/indexeddb/delete-range-private.html: Added.
- storage/indexeddb/deleteIndex-private-expected.txt: Added.
- storage/indexeddb/deleteIndex-private.html: Added.
- storage/indexeddb/deleteObjectStore-name-argument-required-private-expected.txt: Added.
- storage/indexeddb/deleteObjectStore-name-argument-required-private.html: Added.
- storage/indexeddb/deleteObjectStore-null-name-private-expected.txt: Added.
- storage/indexeddb/deleteObjectStore-null-name-private.html: Added.
- storage/indexeddb/deleted-objects-private-expected.txt: Added.
- storage/indexeddb/deleted-objects-private.html: Added.
- storage/indexeddb/deletedatabase-blocked-private-expected.txt: Added.
- storage/indexeddb/deletedatabase-blocked-private.html: Added.
- storage/indexeddb/deletedatabase-delayed-by-open-and-versionchange-private-expected.txt: Added.
- storage/indexeddb/deletedatabase-delayed-by-open-and-versionchange-private.html: Added.
- storage/indexeddb/deletedatabase-delayed-by-versionchange-private-expected.txt: Added.
- storage/indexeddb/deletedatabase-not-blocked-private-expected.txt: Added.
- storage/indexeddb/deletedatabase-not-blocked-private.html: Added.
- storage/indexeddb/dont-wedge-private-expected.txt: Added.
- storage/indexeddb/dont-wedge-private.html: Added.
- storage/indexeddb/duplicates-private-expected.txt: Added.
- storage/indexeddb/duplicates-private.html: Added.
- storage/indexeddb/error-causes-abort-by-default-private-expected.txt: Added.
- storage/indexeddb/error-causes-abort-by-default-private.html: Added.
- storage/indexeddb/events-private-expected.txt: Added.
- storage/indexeddb/events-private.html: Added.
- storage/indexeddb/exception-in-event-aborts-private-expected.txt: Added.
- storage/indexeddb/exception-in-event-aborts-private.html: Added.
- storage/indexeddb/exceptions-private-expected.txt: Added.
- storage/indexeddb/exceptions-private.html: Added.
- storage/indexeddb/factory-cmp-private-expected.txt: Added.
- storage/indexeddb/factory-cmp-private.html: Added.
- storage/indexeddb/factory-deletedatabase-private-expected.txt: Added.
- storage/indexeddb/factory-deletedatabase-private.html: Added.
- storage/indexeddb/get-keyrange-private-expected.txt: Added.
- storage/indexeddb/get-keyrange-private.html: Added.
- storage/indexeddb/index-basics-private-expected.txt: Added.
- storage/indexeddb/index-basics-private.html: Added.
- storage/indexeddb/index-count-private-expected.txt: Added.
- storage/indexeddb/index-count-private.html: Added.
- storage/indexeddb/index-cursor-private-expected.txt: Added.
- storage/indexeddb/index-cursor-private.html: Added.
- storage/indexeddb/index-duplicate-keypaths-private-expected.txt: Added.
- storage/indexeddb/index-duplicate-keypaths-private.html: Added.
- storage/indexeddb/index-get-key-argument-required-private-expected.txt: Added.
- storage/indexeddb/index-get-key-argument-required-private.html: Added.
- storage/indexeddb/index-multientry-private-expected.txt: Added.
- storage/indexeddb/index-multientry-private.html: Added.
- storage/indexeddb/index-population-private-expected.txt: Added.
- storage/indexeddb/index-population-private.html: Added.
- storage/indexeddb/index-unique-private-expected.txt: Added.
- storage/indexeddb/index-unique-private.html: Added.
- storage/indexeddb/interfaces-private-expected.txt: Added.
- storage/indexeddb/interfaces-private.html: Added.
- storage/indexeddb/intversion-abort-in-initial-upgradeneeded-private-expected.txt: Added.
- storage/indexeddb/intversion-abort-in-initial-upgradeneeded-private.html: Added.
- storage/indexeddb/intversion-bad-parameters-private-expected.txt: Added.
- storage/indexeddb/intversion-bad-parameters-private.html: Added.
- storage/indexeddb/intversion-blocked-private-expected.txt: Added.
- storage/indexeddb/intversion-blocked-private.html: Added.
- storage/indexeddb/intversion-close-between-events-private-expected.txt: Added.
- storage/indexeddb/intversion-close-between-events-private.html: Added.
- storage/indexeddb/intversion-close-in-oncomplete-private-expected.txt: Added.
- storage/indexeddb/intversion-close-in-oncomplete-private.html: Added.
- storage/indexeddb/intversion-close-in-upgradeneeded-private-expected.txt: Added.
- storage/indexeddb/intversion-close-in-upgradeneeded-private.html: Added.
- storage/indexeddb/intversion-encoding-private-expected.txt: Added.
- storage/indexeddb/intversion-encoding-private.html: Added.
- storage/indexeddb/intversion-gated-on-delete-private-expected.txt: Added.
- storage/indexeddb/intversion-gated-on-delete-private.html: Added.
- storage/indexeddb/intversion-long-queue-private-expected.txt: Added.
- storage/indexeddb/intversion-long-queue-private.html: Added.
- storage/indexeddb/intversion-omit-parameter-private-expected.txt: Added.
- storage/indexeddb/intversion-omit-parameter-private.html: Added.
- storage/indexeddb/intversion-open-in-upgradeneeded-private-expected.txt: Added.
- storage/indexeddb/intversion-open-in-upgradeneeded-private.html: Added.
- storage/indexeddb/intversion-open-with-version-private-expected.txt: Added.
- storage/indexeddb/intversion-open-with-version-private.html: Added.
- storage/indexeddb/intversion-pending-version-changes-ascending-private-expected.txt: Added.
- storage/indexeddb/intversion-pending-version-changes-ascending-private.html: Added.
- storage/indexeddb/intversion-pending-version-changes-descending-private-expected.txt: Added.
- storage/indexeddb/intversion-pending-version-changes-descending-private.html: Added.
- storage/indexeddb/intversion-pending-version-changes-same-private-expected.txt: Added.
- storage/indexeddb/intversion-pending-version-changes-same-private.html: Added.
- storage/indexeddb/intversion-persistence-private-expected.txt: Added.
- storage/indexeddb/intversion-persistence-private.html: Added.
- storage/indexeddb/intversion-revert-on-abort-private-expected.txt: Added.
- storage/indexeddb/intversion-revert-on-abort-private.html: Added.
- storage/indexeddb/intversion-two-opens-no-versions-private-expected.txt: Added.
- storage/indexeddb/intversion-two-opens-no-versions-private.html: Added.
- storage/indexeddb/intversion-upgrades-private-expected.txt: Added.
- storage/indexeddb/intversion-upgrades-private.html: Added.
- storage/indexeddb/invalid-keys-private-expected.txt: Added.
- storage/indexeddb/invalid-keys-private.html: Added.
- storage/indexeddb/key-generator-private-expected.txt: Added.
- storage/indexeddb/key-generator-private.html: Added.
- storage/indexeddb/key-sort-order-across-types-private-expected.txt: Added.
- storage/indexeddb/key-sort-order-across-types-private.html: Added.
- storage/indexeddb/key-sort-order-date-private-expected.txt: Added.
- storage/indexeddb/key-sort-order-date-private.html: Added.
- storage/indexeddb/key-type-array-private-expected.txt: Added.
- storage/indexeddb/key-type-array-private.html: Added.
- storage/indexeddb/key-type-binary-private-expected.txt: Added.
- storage/indexeddb/key-type-binary-private.html: Added.
- storage/indexeddb/key-type-infinity-private-expected.txt: Added.
- storage/indexeddb/key-type-infinity-private.html: Added.
- storage/indexeddb/keypath-arrays-private-expected.txt: Added.
- storage/indexeddb/keypath-arrays-private.html: Added.
- storage/indexeddb/keypath-basics-private-expected.txt: Added.
- storage/indexeddb/keypath-basics-private.html: Added.
- storage/indexeddb/keypath-edges-private-expected.txt: Added.
- storage/indexeddb/keypath-edges-private.html: Added.
- storage/indexeddb/keypath-fetch-key-private-expected.txt: Added.
- storage/indexeddb/keypath-fetch-key-private.html: Added.
- storage/indexeddb/keypath-intrinsic-properties-private-expected.txt: Added.
- storage/indexeddb/keypath-intrinsic-properties-private.html: Added.
- storage/indexeddb/keyrange-private-expected.txt: Added.
- storage/indexeddb/keyrange-private.html: Added.
- storage/indexeddb/keyrange-required-arguments-private-expected.txt: Added.
- storage/indexeddb/keyrange-required-arguments-private.html: Added.
- storage/indexeddb/lazy-index-types-private-expected.txt: Added.
- storage/indexeddb/lazy-index-types-private.html: Added.
- storage/indexeddb/legacy-constants-private-expected.txt: Added.
- storage/indexeddb/legacy-constants-private.html: Added.
- storage/indexeddb/list-ordering-private-expected.txt: Added.
- storage/indexeddb/list-ordering-private.html: Added.
- storage/indexeddb/metadata-private-expected.txt: Added.
- storage/indexeddb/metadata-private.html: Added.
- storage/indexeddb/mutating-cursor-private-expected.txt: Added.
- storage/indexeddb/mutating-cursor-private.html: Added.
- storage/indexeddb/objectStore-required-arguments-private-expected.txt: Added.
- storage/indexeddb/objectStore-required-arguments-private.html: Added.
- storage/indexeddb/objectstore-autoincrement-private-expected.txt: Added.
- storage/indexeddb/objectstore-autoincrement-private.html: Added.
- storage/indexeddb/objectstore-basics-private-expected.txt: Added.
- storage/indexeddb/objectstore-basics-private.html: Added.
- storage/indexeddb/objectstore-clear-private-expected.txt: Added.
- storage/indexeddb/objectstore-clear-private.html: Added.
- storage/indexeddb/objectstore-count-private-expected.txt: Added.
- storage/indexeddb/objectstore-count-private.html: Added.
- storage/indexeddb/objectstore-cursor-private-expected.txt: Added.
- storage/indexeddb/objectstore-cursor-private.html: Added.
- storage/indexeddb/objectstore-removeobjectstore-private-expected.txt: Added.
- storage/indexeddb/objectstore-removeobjectstore-private.html: Added.
- storage/indexeddb/odd-strings-private-expected.txt: Added.
- storage/indexeddb/odd-strings-private.html: Added.
- storage/indexeddb/open-cursor-private-expected.txt: Added.
- storage/indexeddb/open-cursor-private.html: Added.
- storage/indexeddb/open-during-transaction-private-expected.txt: Added.
- storage/indexeddb/open-during-transaction-private.html: Added.
- storage/indexeddb/open-ordering-private-expected.txt: Added.
- storage/indexeddb/open-ordering-private.html: Added.
- storage/indexeddb/opencursor-key-private-expected.txt: Added.
- storage/indexeddb/opencursor-key-private.html: Added.
- storage/indexeddb/pending-activity-private-expected.txt: Added.
- storage/indexeddb/pending-activity-private.html: Added.
- storage/indexeddb/pending-version-change-on-exit-private-expected.txt: Added.
- storage/indexeddb/pending-version-change-on-exit-private.html: Added.
- storage/indexeddb/pending-version-change-stuck-private-expected.txt: Added.
- storage/indexeddb/pending-version-change-stuck-private.html: Added.
- storage/indexeddb/persistence-expected.txt:
- storage/indexeddb/persistence-private-expected.txt: Copied from LayoutTests/storage/indexeddb/persistence-expected.txt.
- storage/indexeddb/persistence-private.html: Added.
- storage/indexeddb/prefetch-bugfix-108071-private-expected.txt: Added.
- storage/indexeddb/prefetch-bugfix-108071-private.html: Added.
- storage/indexeddb/queued-commands-private-expected.txt: Added.
- storage/indexeddb/queued-commands-private.html: Added.
- storage/indexeddb/readonly-private-expected.txt: Added.
- storage/indexeddb/readonly-private.html: Added.
- storage/indexeddb/readonly-properties-private-expected.txt: Added.
- storage/indexeddb/readonly-properties-private.html: Added.
- storage/indexeddb/removed-private-expected.txt: Added.
- storage/indexeddb/removed-private.html: Added.
- storage/indexeddb/request-continue-abort-private-expected.txt: Added.
- storage/indexeddb/request-continue-abort-private.html: Added.
- storage/indexeddb/request-event-propagation-private-expected.txt: Added.
- storage/indexeddb/request-event-propagation-private.html: Added.
- storage/indexeddb/resources/persistence.js:
- storage/indexeddb/set_version_blocked-private-expected.txt: Added.
- storage/indexeddb/set_version_blocked-private.html: Added.
- storage/indexeddb/setversion-blocked-by-versionchange-close-private-expected.txt: Added.
- storage/indexeddb/setversion-blocked-by-versionchange-close-private.html: Added.
- storage/indexeddb/setversion-not-blocked-private-expected.txt: Added.
- storage/indexeddb/setversion-not-blocked-private.html: Added.
- storage/indexeddb/transaction-abort-private-expected.txt: Added.
- storage/indexeddb/transaction-abort-private.html: Added.
- storage/indexeddb/transaction-active-flag-private-expected.txt: Added.
- storage/indexeddb/transaction-active-flag-private.html: Added.
- storage/indexeddb/transaction-after-close-private-expected.txt: Added.
- storage/indexeddb/transaction-after-close-private.html: Added.
- storage/indexeddb/transaction-and-objectstore-calls-private-expected.txt: Added.
- storage/indexeddb/transaction-and-objectstore-calls-private.html: Added.
- storage/indexeddb/transaction-basics-private-expected.txt: Added.
- storage/indexeddb/transaction-basics-private.html: Added.
- storage/indexeddb/transaction-complete-workers-private-expected.txt: Added.
- storage/indexeddb/transaction-complete-workers-private.html: Added.
- storage/indexeddb/transaction-coordination-across-databases-private-expected.txt: Added.
- storage/indexeddb/transaction-coordination-across-databases-private.html: Added.
- storage/indexeddb/transaction-coordination-within-database-private-expected.txt: Added.
- storage/indexeddb/transaction-coordination-within-database-private.html: Added.
- storage/indexeddb/transaction-crash-on-abort-private-expected.txt: Added.
- storage/indexeddb/transaction-crash-on-abort-private.html: Added.
- storage/indexeddb/transaction-error-private-expected.txt: Added.
- storage/indexeddb/transaction-error-private.html: Added.
- storage/indexeddb/transaction-event-propagation-private-expected.txt: Added.
- storage/indexeddb/transaction-event-propagation-private.html: Added.
- storage/indexeddb/transaction-read-only-private-expected.txt: Added.
- storage/indexeddb/transaction-read-only-private.html: Added.
- storage/indexeddb/transaction-readwrite-exclusive-private-expected.txt: Added.
- storage/indexeddb/transaction-readwrite-exclusive-private.html: Added.
- storage/indexeddb/transaction-rollback-private-expected.txt: Added.
- storage/indexeddb/transaction-rollback-private.html: Added.
- storage/indexeddb/transaction-scope-sequencing-private-expected.txt: Added.
- storage/indexeddb/transaction-scope-sequencing-private.html: Added.
- storage/indexeddb/transaction-starvation-private-expected.txt: Added.
- storage/indexeddb/transaction-storeNames-required-private-expected.txt: Added.
- storage/indexeddb/transaction-storeNames-required-private.html: Added.
- storage/indexeddb/unblocked-version-changes-private-expected.txt: Added.
- storage/indexeddb/unblocked-version-changes-private.html: Added.
- storage/indexeddb/unprefix-private-expected.txt: Added.
- storage/indexeddb/unprefix-private.html: Added.
- storage/indexeddb/value-undefined-private-expected.txt: Added.
- storage/indexeddb/value-undefined-private.html: Added.
- storage/indexeddb/values-odd-types-private-expected.txt: Added.
- storage/indexeddb/values-odd-types-private.html: Added.
- storage/indexeddb/version-change-abort-private-expected.txt: Added.
- storage/indexeddb/version-change-abort-private.html: Added.
- storage/indexeddb/version-change-exclusive-private-expected.txt: Added.
- storage/indexeddb/version-change-exclusive-private.html: Added.
- storage/indexeddb/versionchangerequest-activedomobject-private-expected.txt: Added.
- storage/indexeddb/versionchangerequest-activedomobject-private.html: Added.
- 8:08 PM Changeset in webkit [195246] by
-
- 2 edits in trunk/Source/JavaScriptCore
assertions in BytecodeUseDef.h about opcode length are off by one
https://bugs.webkit.org/show_bug.cgi?id=153215
Reviewed by Dan Bernstein.
- bytecode/BytecodeUseDef.h:
(JSC::computeUsesForBytecodeOffset):
- 8:05 PM Changeset in webkit [195245] by
-
- 2 edits in trunk/Tools
[GTK][EFL] Layout tests abort with PulseAudioSanitizer instance has no attribute '_pa_module_index' when the build is not ready.
https://bugs.webkit.org/show_bug.cgi?id=153216
Reviewed by Michael Catanzaro.
- Scripts/webkitpy/port/pulseaudio_sanitizer.py:
(PulseAudioSanitizer.init): initialize _pa_module_index in the constructor.
- 7:28 PM Changeset in webkit [195244] by
-
- 2 edits in trunk/Source/WebCore
[iOS Simulator WK1] ASSERT loading Blink layout test imported/web-platform-tests/mediacapture-streams/stream-api/mediastream/mediastream-idl.html
https://bugs.webkit.org/show_bug.cgi?id=153070
<rdar://problem/24183105>
Reviewed by Darin Adler.
No new tests, this prevents an existing test from crashing.
- platform/mock/MockRealtimeVideoSource.cpp:
(WebCore::MockRealtimeVideoSource::MockRealtimeVideoSource): Create the timer with RunLoop::current
instead of RunLoop::main.
- 6:56 PM Changeset in webkit [195243] by
-
- 18 edits in trunk/Source/WebCore
Reduce PassRefPtr uses in dom - 3
https://bugs.webkit.org/show_bug.cgi?id=153055
Reviewed by Darin Adler.
Third patch to reduce uses of PassRefPtr in WebCore/dom.
- dom/MutationObserverInterestGroup.cpp:
(WebCore::MutationObserverInterestGroup::enqueueMutationRecord):
- dom/MutationRecord.cpp:
(WebCore::MutationRecord::createChildList):
(WebCore::MutationRecord::createAttributes):
(WebCore::MutationRecord::createCharacterData):
(WebCore::MutationRecord::createWithNullOldValue):
- dom/MutationRecord.h:
- dom/NamedFlowCollection.cpp:
(WebCore::NamedFlowCollection::createCSSOMSnapshot):
- dom/NamedFlowCollection.h:
- dom/PendingScript.cpp:
(WebCore::PendingScript::releaseElementAndClear):
- dom/PendingScript.h:
- dom/ScriptRunner.h:
- dom/SecurityContext.h:
- dom/ShadowRoot.cpp:
(WebCore::ShadowRoot::cloneNode):
- dom/ShadowRoot.h:
- dom/SpaceSplitString.cpp:
(WebCore::SpaceSplitStringData::create):
- dom/SpaceSplitString.h:
- dom/TreeWalker.cpp:
(WebCore::TreeWalker::setCurrent):
(WebCore::TreeWalker::parentNode):
(WebCore::TreeWalker::previousNode):
(WebCore::TreeWalker::nextNode):
- dom/TreeWalker.h:
- dom/default/PlatformMessagePortChannel.cpp:
(WebCore::PlatformMessagePortChannel::entangledChannel):
- dom/default/PlatformMessagePortChannel.h:
- 5:23 PM Changeset in webkit [195242] by
-
- 3 edits in trunk
[CMake] Duplicate attempts to find software during cmake stage
https://bugs.webkit.org/show_bug.cgi?id=153211
Reviewed by Martin Robinson.
- CMakeLists.txt: Remove duplication of commands in WebKitCommon.cmake.
- Source/cmake/WebKitCommon.cmake: Guard the entire file so it runs only once.
- 5:08 PM Changeset in webkit [195241] by
-
- 7 edits in trunk/Source/WebKit2
[EFL] Remove wkView() from EwkView
https://bugs.webkit.org/show_bug.cgi?id=152604
Reviewed by Gyuyoung Kim.
- UIProcess/API/efl/EwkView.cpp:
(EwkViewEventHandler<EVAS_CALLBACK_SHOW>::handleEvent):
(EwkViewEventHandler<EVAS_CALLBACK_HIDE>::handleEvent):
(EwkView::EwkView):
(EwkView::create):
(EwkView::wkPage):
(EwkView::isVisible):
(EwkView::setVisible):
(EwkView::setDeviceScaleFactor):
(EwkView::deviceSize):
(EwkView::displayTimerFired):
(EwkView::setViewportPosition):
(EwkView::requestExitFullScreen):
(EwkView::contentsSize):
(EwkView::setThemePath):
(EwkView::feedTouchEvent):
(EwkView::createGLSurface):
(EwkView::showContextMenu):
(EwkView::requestPopupMenu):
(EwkView::webView):
(EwkView::handleEvasObjectCalculate):
(EwkView::handleEvasObjectColorSet):
(EwkView::handleEwkViewFocusIn):
(EwkView::handleEwkViewFocusOut):
(EwkView::feedTouchEvents):
(EwkView::takeSnapshot):
(EwkView::scrollBy):
(EwkView::setBackgroundColor):
(EwkView::backgroundColor):
- UIProcess/API/efl/EwkView.h:
(EwkView::wkView): Deleted.
- UIProcess/API/efl/GestureRecognizer.cpp:
(WebKit::GestureHandler::handleSingleTap):
- UIProcess/API/efl/ewk_view.cpp:
(EWKViewCreate):
(EWKViewGetWKView):
(ewk_view_fullscreen_exit):
(ewk_view_layout_fixed_set):
(ewk_view_layout_fixed_get):
(ewk_view_layout_fixed_size_set):
(ewk_view_layout_fixed_size_get):
(ewk_view_bg_color_get):
(ewk_view_contents_size_get):
- UIProcess/efl/PageViewportControllerClientEfl.cpp:
(WebKit::PageViewportControllerClientEfl::setPageScaleFactor):
- UIProcess/efl/ViewClientEfl.cpp:
(WebKit::ViewClientEfl::webProcessDidRelaunch):
(WebKit::ViewClientEfl::ViewClientEfl):
(WebKit::ViewClientEfl::~ViewClientEfl):
- 4:56 PM Changeset in webkit [195240] by
-
- 9 edits4 adds in trunk
AX: [Mac] Implement next/previous text marker functions using TextIterator
https://bugs.webkit.org/show_bug.cgi?id=152728
Reviewed by Chris Fleizach.
Source/WebCore:
The existing AXTextMarker based calls are implemented using visible position, and that introduced
some bugs which make VoiceOver working incorrectly on Mac sometimes. Since TextIterator uses rendering
position, we tried to use it to refactor those AXTextMarker based calls.
In this patch, I implemented functions to navigate to previous/next text marker using Range and TextIterator.
Also added a conversion between visible position and character offset to make sure unconverted text marker
related functions are still working correctly.
Tests: accessibility/mac/previous-next-text-marker.html
accessibility/mac/text-marker-with-user-select-none.html
- accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::visiblePositionForTextMarkerData):
(WebCore::AXObjectCache::traverseToOffsetInRange):
(WebCore::AXObjectCache::lengthForRange):
(WebCore::AXObjectCache::rangeForNodeContents):
(WebCore::characterOffsetsInOrder):
(WebCore::AXObjectCache::rangeForUnorderedCharacterOffsets):
(WebCore::AXObjectCache::setTextMarkerDataWithCharacterOffset):
(WebCore::AXObjectCache::startOrEndTextMarkerDataForRange):
(WebCore::AXObjectCache::textMarkerDataForCharacterOffset):
(WebCore::AXObjectCache::nextNode):
(WebCore::AXObjectCache::previousNode):
(WebCore::AXObjectCache::visiblePositionFromCharacterOffset):
(WebCore::AXObjectCache::characterOffsetFromVisiblePosition):
(WebCore::AXObjectCache::accessibilityObjectForTextMarkerData):
(WebCore::AXObjectCache::textMarkerDataForVisiblePosition):
- accessibility/AXObjectCache.h:
(WebCore::CharacterOffset::CharacterOffset):
(WebCore::CharacterOffset::remaining):
(WebCore::CharacterOffset::isNull):
(WebCore::AXObjectCache::setNodeInUse):
(WebCore::AXObjectCache::removeNodeForUse):
(WebCore::AXObjectCache::isNodeInUse):
- accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::selectionRange):
(WebCore::AccessibilityObject::elementRange):
(WebCore::AccessibilityObject::selectText):
(WebCore::AccessibilityObject::lineRangeForPosition):
(WebCore::AccessibilityObject::replacedNodeNeedsCharacter):
(WebCore::renderListItemContainerForNode):
(WebCore::listMarkerTextForNode):
(WebCore::AccessibilityObject::listMarkerTextForNodeAndPosition):
(WebCore::AccessibilityObject::stringForRange):
(WebCore::AccessibilityObject::stringForVisiblePositionRange):
(WebCore::replacedNodeNeedsCharacter): Deleted.
- accessibility/AccessibilityObject.h:
(WebCore::AccessibilityObject::visiblePositionRange):
(WebCore::AccessibilityObject::visiblePositionRangeForLine):
(WebCore::AccessibilityObject::boundsForVisiblePositionRange):
(WebCore::AccessibilityObject::setSelectedVisiblePositionRange):
- accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(isTextMarkerIgnored):
(-[WebAccessibilityObjectWrapper accessibilityObjectForTextMarker:]):
(accessibilityObjectForTextMarker):
(-[WebAccessibilityObjectWrapper textMarkerRangeFromRange:]):
(textMarkerRangeFromRange):
(-[WebAccessibilityObjectWrapper startOrEndTextMarkerForRange:isStart:]):
(startOrEndTextmarkerForRange):
(-[WebAccessibilityObjectWrapper nextTextMarkerForNode:offset:]):
(-[WebAccessibilityObjectWrapper previousTextMarkerForNode:offset:]):
(-[WebAccessibilityObjectWrapper textMarkerForNode:offset:]):
(textMarkerForCharacterOffset):
(-[WebAccessibilityObjectWrapper rangeForTextMarkerRange:]):
(-[WebAccessibilityObjectWrapper characterOffsetForTextMarker:]):
(textMarkerForVisiblePosition):
(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:forParameter:]):
Tools:
- WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
(WTR::AccessibilityUIElement::accessibilityElementForTextMarker):
LayoutTests:
- accessibility/mac/previous-next-text-marker-expected.txt: Added.
- accessibility/mac/previous-next-text-marker.html: Added.
- accessibility/mac/text-marker-with-user-select-none-expected.txt: Added.
- accessibility/mac/text-marker-with-user-select-none.html: Added.
- 4:06 PM Changeset in webkit [195239] by
-
- 2 edits in trunk/Source/WebCore
[Mac] Remove unused playerToPrivateMap()
https://bugs.webkit.org/show_bug.cgi?id=153203
Patch by Olivier Blin <Olivier Blin> on 2016-01-18
Reviewed by Darin Adler.
This was used in previous EME implementations, but is unnecessary
since r163907.
No new tests since this removes dead code only.
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::globalLoaderDelegateQueue): Deleted.
(WebCore::MediaPlayerPrivateAVFoundationObjC::~MediaPlayerPrivateAVFoundationObjC): Deleted.
- 2:15 PM Changeset in webkit [195238] by
-
- 2 edits1 add in trunk/Source/JavaScriptCore
FTL doesn't do proper spilling for exception handling when GetById/Snippets go to slow path
https://bugs.webkit.org/show_bug.cgi?id=153186
Reviewed by Michael Saboff.
Michael was investigating a bug he found while doing the new JSC calling
convention work and it turns out to be a latent bug in FTL try/catch machinery.
After I looked at the code again, I realized that what I had previously
written is wrong in a subtle way. The FTL callOperation machinery will remove
its result register from the set of registers it needs to spill. This is not
correct when we have try/catch. We may want to do value recovery on
the value that the result register is prior to the call after the call
throws an exception. The case that we were solving before was when the
resultRegister == baseRegister in a GetById, or left/rightRegister == resultRegister in a Snippet.
This code is correct in wanting to spill in that case, even though it might spill
when we don't need it to (i.e the result is not needed for value recovery). Once I
investigated this bug further, I realized that the previous rule is just a
partial subset of the rule that says we should spill anytime the result is
a register we might do value recovery on. This patch implements the rule that
says we always want to spill the result when we will do value recovery on it
if an exception is thrown.
- ftl/FTLCompile.cpp:
(JSC::FTL::mmAllocateDataSection):
- tests/stress/ftl-try-catch-getter-throw-interesting-value-recovery.js: Added.
(assert):
(random):
(identity):
(let.o2.get f):
(let.o3.get f):
(foo):
(i.else):
- 1:27 PM Changeset in webkit [195237] by
-
- 5 edits in trunk/Source/WebCore
Add TextStream-based logging for Position and VisiblePosition
https://bugs.webkit.org/show_bug.cgi?id=153195
Reviewed by Ryosuke Niwa.
Make it easy to dump Positions and VisiblePositions with a TextStream.
- dom/Position.cpp:
(WebCore::operator<<):
- dom/Position.h:
- editing/VisiblePosition.cpp:
(WebCore::operator<<):
- editing/VisiblePosition.h:
- 1:07 PM Changeset in webkit [195236] by
-
- 4 edits in trunk/Source/JavaScriptCore
[MIPS] LLInt: fix calculation of Global Offset Table
https://bugs.webkit.org/show_bug.cgi?id=150381
Offlineasm adds a .cpload $t9 when we create a label in MIPS, which
computes address of GOT. However, this instruction requires $t9 to
contain address of current function. So we need to set $t9 to pcBase,
otherwise GOT-related calculations will be invalid.
Since offlineasm does not allow direct move to $t9 on MIPS, added new
instruction setcallreg which does exactly that.
Patch by Konstantin Tokarev <Konstantin Tokarev> on 2016-01-18
Reviewed by Michael Saboff.
- llint/LowLevelInterpreter.asm:
- offlineasm/instructions.rb:
- offlineasm/mips.rb:
- 12:26 PM Changeset in webkit [195235] by
-
- 13 edits in trunk/Source
Sink the Vector<uint8_t> buffer into the SerializedScriptValue constructor
https://bugs.webkit.org/show_bug.cgi?id=142634
Patch by Zan Dobersek <zdobersek@igalia.com> on 2016-01-18
Reviewed by Darin Adler.
Source/WebCore:
Have the SerializedScriptValue constructor take in the Vector<uint8_t> buffer
through an rvalue reference, avoiding the copying into the m_data member. The
three-parameter constructor now takes in the Vector<String> blob URL object
via const reference, and the std::unique_ptr<> object via a rvalue reference.
Adjust all the call sites and affected code to now either move or copy a
non-movable object into the SerializedScriptValue constructor or the helper
methods.
No new tests -- no change in behavior.
- bindings/js/IDBBindingUtilities.cpp:
(WebCore::deserializeIDBValueDataToJSValue):
(WebCore::deserializeIDBValueBuffer):
(WebCore::idbValueDataToJSValue):
- bindings/js/IDBBindingUtilities.h:
- bindings/js/SerializedScriptValue.cpp:
(WebCore::SerializedScriptValue::SerializedScriptValue):
(WebCore::SerializedScriptValue::create):
(WebCore::SerializedScriptValue::numberValue):
(WebCore::SerializedScriptValue::undefinedValue):
(WebCore::SerializedScriptValue::nullValue):
- bindings/js/SerializedScriptValue.h:
- testing/Internals.cpp:
(WebCore::Internals::deserializeBuffer):
Source/WebKit2:
Update API::SerializedScriptValue::adopt() to take in a Vector<uint8_t>
rvalue, moving it into the WebCore::SerializedScriptValue::adopt() call.
Update other places that are affected by the SerializedScriptValue changes.
- DatabaseProcess/IndexedDB/sqlite/UniqueIDBDatabaseBackingStoreSQLite.cpp:
(WebKit::UniqueIDBDatabaseBackingStoreSQLite::createIndex):
- Shared/API/APISerializedScriptValue.h:
(API::SerializedScriptValue::adopt):
- Shared/UserData.cpp:
(WebKit::UserData::decode):
- UIProcess/UserContent/WebUserContentControllerProxy.cpp:
(WebKit::WebUserContentControllerProxy::didPostMessage):
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::scriptValueCallback):
- WebProcess/WebCoreSupport/SessionStateConversion.cpp:
(WebKit::applyFrameState):
- 11:22 AM Changeset in webkit [195234] by
-
- 3 edits in trunk/Source/WebCore
[GStreamer] Remove unused m_endTime
https://bugs.webkit.org/show_bug.cgi?id=153209
Patch by Olivier Blin <Olivier Blin> on 2016-01-18
Reviewed by Michael Catanzaro.
m_endTime has been unused since r47710 in MediaPlayerPrivateGStreamer.
No new tests since this is just a member cleanup.
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::MediaPlayerPrivateGStreamer): Deleted.
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
- 8:47 AM WebKitGTK/Gardening/Calendar edited by
- (diff)
- 7:28 AM Changeset in webkit [195233] by
-
- 2 edits in trunk/Source/JavaScriptCore
REGRESSION(r194601): Fix the jsc timeout option of jsc.cpp
https://bugs.webkit.org/show_bug.cgi?id=153204
Reviewed by Michael Catanzaro.
- jsc.cpp:
(main):
- 7:19 AM Changeset in webkit [195232] by
-
- 4 edits in trunk
[cmake] Add testair to the build system
https://bugs.webkit.org/show_bug.cgi?id=153126
Reviewed by Michael Catanzaro.
Source/JavaScriptCore:
- shell/CMakeLists.txt:
Tools:
- Scripts/build-jsc:
- 7:17 AM Changeset in webkit [195231] by
-
- 6 edits in trunk/Source/WebKit2
[EFL][GTK][WK2] Fix UIProcess build with GStreamer and without VIDEO
https://bugs.webkit.org/show_bug.cgi?id=153135
Patch by Olivier Blin <Olivier Blin> on 2016-01-18
Reviewed by Michael Catanzaro.
GStreamer builds fail when WebAudio is enabled but VIDEO disabled.
This change makes the flag more consistent around the
decicePolicyForInstallMissingMediaPluginsPermissionRequest() method:
ENABLE(VIDEO) && USE(GSTREAMER) everywhere, while the code used to
test either one or the other.
This does not enable InstallMissingMediaPlugins for WebAudio, since no
code makes use of this in WebKitWebAudioSourceGStreamer.
It also fixes a naming typo for the following method:
decidePolicyForInstallMissingMediaPluginsPermissionRequest()
- UIProcess/API/gtk/PageClientImpl.cpp:
(WebKit::PageClientImpl::decidePolicyForInstallMissingMediaPluginsPermissionRequest):
- UIProcess/API/gtk/PageClientImpl.h:
- UIProcess/PageClient.h:
- UIProcess/efl/WebViewEfl.h:
- UIProcess/gstreamer/WebPageProxyGStreamer.cpp:
(WebKit::WebPageProxy::requestInstallMissingMediaPlugins):
- 5:57 AM Changeset in webkit [195230] by
-
- 2 edits in releases/WebKitGTK/webkit-2.10/Source/WebCore/platform/gtk/po
Merge r194822 - [l10n] Updated Turkish translation of WebKitGTK+
https://bugs.webkit.org/show_bug.cgi?id=152948
"Reviewed" by Michael Catanzaro.
Patch by Muhammet Kara <muhammetk@gmail.com> on 2016-01-09
- tr.po:
- 5:54 AM Changeset in webkit [195229] by
-
- 3 edits in trunk/LayoutTests/imported/w3c
[Streams API] Import tests updated to Jan 13 2016
https://bugs.webkit.org/show_bug.cgi?id=153059
Reviewed by Youenn Fablet.
Update tests after merge of https://github.com/whatwg/streams/pull/420.
- web-platform-tests/streams-api/README.txt: Updated last version.
- web-platform-tests/streams-api/readable-streams/bad-strategies.js: Updated.
- 5:54 AM Changeset in webkit [195228] by
-
- 2 edits in releases/WebKitGTK/webkit-2.10/Source/ThirdParty/ANGLE
Merge r194780 - [ANGLE] Correct UNREACHABLE runtime assertion for void constructors
https://bugs.webkit.org/show_bug.cgi?id=152900
<rdar://problem/24107501>
Reviewed by Alex Christensen.
Tested by Khronos WebGL 1.0.4 suite.
Merge a small part of ANGLE upstream commit r284735:
commit 01971113492d9aca386f2bca021b1f4b134fc277
author Dmitry Skiba <dskiba@google.com> Fri Jul 10 18:54:00 2015
committer Jamie Madill <jmadill@chromium.org> Fri Jul 10 19:03:34 2015
tree 47e42eac00f7d64cddb14b3cc21a4e605c189d20
This issue was found by <https://www.khronos.org/registry/webgl/sdk/tests/conformance/glsl/bugs/angle-constructor-invalid-parameters.html?webglVersion=1&quiet=0>
- src/compiler/translator/Types.cpp:
(TType::buildMangledName): Don't assert with UNREACHABLE here.
- 5:40 AM Changeset in webkit [195227] by
-
- 2 edits in releases/WebKitGTK/webkit-2.10/Source/JavaScriptCore
Merge r194766 - [mips] Fixed unused parameter warnings
https://bugs.webkit.org/show_bug.cgi?id=152885
Patch by Konstantin Tokarev <Konstantin Tokarev> on 2016-01-08
Reviewed by Mark Lam.
- jit/CCallHelpers.h:
(JSC::CCallHelpers::setupArgumentsWithExecState):
- 5:39 AM Changeset in webkit [195226] by
-
- 2 edits in releases/WebKitGTK/webkit-2.10/Source/JavaScriptCore
Merge r194764 - [mips] Max value of immediate arg of logical ops is 0xffff
https://bugs.webkit.org/show_bug.cgi?id=152884
Patch by Konstantin Tokarev <Konstantin Tokarev> on 2016-01-08
Reviewed by Michael Saboff.
Replaced imm.m_value < 65535 checks with imm.m_value <= 65535
- assembler/MacroAssemblerMIPS.h:
(JSC::MacroAssemblerMIPS::and32):
(JSC::MacroAssemblerMIPS::or32):
- 5:38 AM Changeset in webkit [195225] by
-
- 4 edits in releases/WebKitGTK/webkit-2.10/Source/WebCore
Merge r194751 - Correct missing EXT_sRGB Format Handling
https://bugs.webkit.org/show_bug.cgi?id=152876
<rdar://problem/23284389>
Reviewed by Alex Christensen.
Tested by WebGL 1.0.4 suite.
- platform/graphics/GraphicsContext3D.cpp:
(getDataFormat): Handle missing SRGB and SRGB_ALPHA cases.
- platform/graphics/GraphicsContext3D.h: Add missing SRGB_ALPHA value from the Khronos standard.
- platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:
(WebCore::GraphicsContext3D::texImage2D): Add an assertion that we are not being handed
an internal format to a method that works with normal formats.
- 5:35 AM Changeset in webkit [195224] by
-
- 2 edits in releases/WebKitGTK/webkit-2.10/Source/JavaScriptCore
Merge r194725 - [mips] Lower immediates of logical operations.
https://bugs.webkit.org/show_bug.cgi?id=152693
On MIPS immediate operands of andi, ori, and xori are required to be 16-bit
non-negative numbers.
Patch by Konstantin Tokarev <Konstantin Tokarev> on 2016-01-07
Reviewed by Michael Saboff.
- offlineasm/mips.rb:
- 5:34 AM Changeset in webkit [195223] by
-
- 2 edits in releases/WebKitGTK/webkit-2.10/Source/JavaScriptCore
Merge r194715 - [mips] Implemented missing branch patching methods.
https://bugs.webkit.org/show_bug.cgi?id=152845
Patch by Konstantin Tokarev <Konstantin Tokarev> on 2016-01-07
Reviewed by Michael Saboff.
- assembler/MacroAssemblerMIPS.h:
(JSC::MacroAssemblerMIPS::canJumpReplacePatchableBranch32WithPatch):
(JSC::MacroAssemblerMIPS::startOfPatchableBranch32WithPatchOnAddress):
(JSC::MacroAssemblerMIPS::revertJumpReplacementToPatchableBranch32WithPatch):
- 5:33 AM Changeset in webkit [195222] by
-
- 2 edits in releases/WebKitGTK/webkit-2.10/Source/JavaScriptCore
Merge r194713 - [mips] Make repatchCall public to fix compilation.
https://bugs.webkit.org/show_bug.cgi?id=152843
Patch by Konstantin Tokarev <Konstantin Tokarev> on 2016-01-07
Reviewed by Michael Saboff.
- assembler/MacroAssemblerMIPS.h:
(JSC::MacroAssemblerMIPS::repatchCall):
(JSC::MacroAssemblerMIPS::linkCall): Deleted.
- 5:33 AM Changeset in webkit [195221] by
-
- 2 edits in releases/WebKitGTK/webkit-2.10/Source/JavaScriptCore
Merge r194712 - [mips] Replaced subi with addi in getHostCallReturnValue
https://bugs.webkit.org/show_bug.cgi?id=152841
Patch by Konstantin Tokarev <Konstantin Tokarev> on 2016-01-07
Reviewed by Michael Saboff.
MIPS architecture does not have subi instruction, addi with negative
number should be used instead.
- jit/JITOperations.cpp:
- 5:31 AM Changeset in webkit [195220] by
-
- 3 edits4 adds in releases/WebKitGTK/webkit-2.10
Merge r194710 - Incorrect position: fixed; rendering when child of position:relative/sticky.
https://bugs.webkit.org/show_bug.cgi?id=147284
Reviewed by Simon Fraser and David Hyatt.
Computing logical left for positioned objects should take the relative positioned ancestors' offset
into account.
Source/WebCore:
Tests: fast/block/positioning/fixed-container-with-relative-parent.html
fast/block/positioning/fixed-container-with-sticky-parent.html
- rendering/RenderBox.cpp:
(WebCore::computeInlineStaticDistance):
LayoutTests:
- fast/block/positioning/fixed-container-with-relative-parent-expected.html: Added.
- fast/block/positioning/fixed-container-with-relative-parent.html: Added.
- fast/block/positioning/fixed-container-with-sticky-parent-expected.html: Added.
- fast/block/positioning/fixed-container-with-sticky-parent.html: Added.
- 5:27 AM Changeset in webkit [195219] by
-
- 2 edits in trunk/Source/WebCore
Fix the --minimal build due to missing VM.h include
https://bugs.webkit.org/show_bug.cgi?id=153128
Reviewed by Michael Catanzaro.
- bindings/js/WebCoreJSBuiltinInternals.h:
- 5:26 AM Changeset in webkit [195218] by
-
- 3 edits in trunk/Source/WebCore
Remove the SKIP_UNUSED_PARAM define
https://bugs.webkit.org/show_bug.cgi?id=153129
Reviewed by Michael Catanzaro.
- bindings/js/WebCoreJSBuiltinInternals.cpp:
(WebCore::JSBuiltinInternalFunctions::visit):
(WebCore::JSBuiltinInternalFunctions::initialize):
- bindings/js/WebCoreJSBuiltinInternals.h:
- 5:21 AM Changeset in webkit [195217] by
-
- 2 edits in releases/WebKitGTK/webkit-2.10/Source/JavaScriptCore
Merge r194709 - [mips] GPRInfo::toArgumentRegister missing
https://bugs.webkit.org/show_bug.cgi?id=152838
Patch by Konstantin Tokarev <Konstantin Tokarev> on 2016-01-07
Reviewed by Michael Saboff.
- jit/GPRInfo.h:
(JSC::GPRInfo::toArgumentRegister):
- 5:20 AM Changeset in webkit [195216] by
-
- 7 edits2 adds in releases/WebKitGTK/webkit-2.10
Merge r194706 - Directly-composited animated GIFs never resume once scrolled offscreen
https://bugs.webkit.org/show_bug.cgi?id=152817
<rdar://problem/19982020>
Reviewed by Daniel Bates.
Source/WebCore:
Directly-composited animated GIFs would never resume once scrolled
offscreen. This is because calling repaint() in this case would not
cause BitmapImage::draw() to be called and the animation would thus
not be resumed. To address the problem,
repaintForPausedImageAnimationsIfNeeded() now calls
RenderBoxModelObject::contentChanged(ImageChanged) in addition to
repaint() to make sure the animation actually gets resumed, even in
the directly-composited animated GIF case.
Test: fast/images/composited-animated-gif-outside-viewport.html
- platform/graphics/BitmapImage.h:
Make currentFrame() public so it can be exposed via Internals for the
purpose of testing.
- rendering/RenderElement.cpp:
(WebCore::RenderElement::repaintForPausedImageAnimationsIfNeeded):
Call RenderBoxModelObject::contentChanged(ImageChanged) in addition to
calling repaint() to make sure the animation actually gets resumed in
the directly-composited animated GIFs case.
- testing/Internals.cpp:
(WebCore::Internals::imageFrameIndex):
- testing/Internals.h:
- testing/Internals.idl:
Expose new "unsigned long imageFrameIndex(Element)" operation on
Internals so layout tests can better check if an image is actually
animating. Previously, we would rely on the output of
internals.hasPausedImageAnimations(Element) but this is not sufficient
to cover this bug as our rendering code believed it has resumed the
animations but the GIF was not actually animating due to it being
directly-composited.
LayoutTests:
Add a layout test to check that directly-composited animated GIFs are
properly suspended / resumed based on visibility inside the viewport.
- fast/images/composited-animated-gif-outside-viewport-expected.txt: Added.
- fast/images/composited-animated-gif-outside-viewport.html: Added.
- 5:08 AM Changeset in webkit [195215] by
-
- 2 edits in releases/WebKitGTK/webkit-2.10/Source/JavaScriptCore
Merge r194699 - [mips] Add two missing abortWithReason implementations
https://bugs.webkit.org/show_bug.cgi?id=136753
Patch by Julien Brianceau <jbriance@cisco.com> on 2016-01-07
Reviewed by Benjamin Poulain.
- assembler/MacroAssemblerMIPS.h:
(JSC::MacroAssemblerMIPS::memoryFence):
(JSC::MacroAssemblerMIPS::abortWithReason):
(JSC::MacroAssemblerMIPS::readCallTarget):
- 5:08 AM Changeset in webkit [195214] by
-
- 2 edits in releases/WebKitGTK/webkit-2.10/Source/WebCore
Merge r194697 - [SOUP] Consider reducing max simultaneous connections
https://bugs.webkit.org/show_bug.cgi?id=137282
Reviewed by Carlos Garcia Campos.
Reduce max simultaneous connections from 35 to 17, because (a) all major browsers except
Chrome use 17, and (b) Chrome uses 10. The only reason we previously used 35 was that other
browsers were using 35 at the time.
- platform/network/soup/SoupNetworkSession.cpp:
(WebCore::SoupNetworkSession::SoupNetworkSession):
- 5:06 AM Changeset in webkit [195213] by
-
- 5 edits2 adds in releases/WebKitGTK/webkit-2.10
Merge r194666 - Port blocking bypass issue using 307 redirect
https://bugs.webkit.org/show_bug.cgi?id=152801
<rdar://problem/24048554>
Reviewed by Anders Carlsson.
Source/WebCore:
Tested by http/tests/security/blocked-on-redirect.html.
Make sure that 307 redirects check the requested URL via 'portAllowed'.
- loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::willSendRequest): Confirm that the requested port
is valid, and block load if it is not.
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::reportBlockedPortFailed): Added.
(WebCore::FrameLoader::blockedError): Added.
- loader/FrameLoader.h:
LayoutTests:
- http/tests/security/blocked-on-redirect-expected.txt: Added.
- http/tests/security/blocked-on-redirect.html: Added.
- 4:56 AM Changeset in webkit [195212] by
-
- 3 edits2 adds in releases/WebKitGTK/webkit-2.10
Merge r194645 - Float with media query positioned incorrectly after window resize.
https://bugs.webkit.org/show_bug.cgi?id=152558
Reviewed by Simon Fraser and David Hyatt.
This patch ensures that when a renderer becomes floated, it is moved
to the right containing block.
When this floated renderer's previous sibling is an anonymous block, it needs
to be reparented so that the float is positioned as if there was no anonymous block at all.
Source/WebCore:
Test: fast/block/float/float-with-anonymous-previous-sibling.html
- rendering/RenderElement.cpp:
(WebCore::RenderElement::styleDidChange):
LayoutTests:
- fast/block/float/float-with-anonymous-previous-sibling-expected.html: Added.
- fast/block/float/float-with-anonymous-previous-sibling.html: Added.
- 4:54 AM Changeset in webkit [195211] by
-
- 2 edits in releases/WebKitGTK/webkit-2.10/Source/JavaScriptCore
Merge r194641 - [mips] Fix branchTruncateDoubleToUint32 implementation in macro assembler
https://bugs.webkit.org/show_bug.cgi?id=152782
Patch by Julien Brianceau <jbriance@cisco.com> on 2016-01-06
Reviewed by Benjamin Poulain.
Already covered by LayoutTests/js/dfg-uint32array-overflow-values test.
- assembler/MacroAssemblerMIPS.h:
(JSC::MacroAssemblerMIPS::branchTruncateDoubleToUint32):
- 4:54 AM Changeset in webkit [195210] by
-
- 2 edits in releases/WebKitGTK/webkit-2.10/Source/JavaScriptCore
Merge r194640 - [mips] Fix or32 implementation in macro assembler
https://bugs.webkit.org/show_bug.cgi?id=152781
Reviewed by Michael Saboff.
- assembler/MacroAssemblerMIPS.h:
(JSC::MacroAssemblerMIPS::or32):
- 4:53 AM Changeset in webkit [195209] by
-
- 2 edits in releases/WebKitGTK/webkit-2.10/Source/JavaScriptCore
Merge r194639 - [mips] Add missing branchAdd32 implementation in macro assembler
https://bugs.webkit.org/show_bug.cgi?id=152785
Reviewed by Michael Saboff.
- assembler/MacroAssemblerMIPS.h:
(JSC::MacroAssemblerMIPS::branchAdd32):
- 4:52 AM Changeset in webkit [195208] by
-
- 4 edits2 adds in releases/WebKitGTK/webkit-2.10
Merge r194638 - isAnonymousInlineBlock() should exclude any ruby content.
https://bugs.webkit.org/show_bug.cgi?id=152648
<rdar://problem/23872549>
Reviewed by David Hyatt.
isAnonymousInlineBlock is designed for the new Block-Inside-Inline Model
and all other anonymous inline-block renderers (including Ruby) should bail out of it.
(see webkit.org/b/143145)
Source/WebCore:
Test: fast/ruby/ruby-inline-margin-collapse-crash.html
- rendering/RenderObject.cpp:
(WebCore::RenderObject::isAnonymousInlineBlock):
- rendering/RenderObject.h:
(WebCore::RenderObject::isAnonymousInlineBlock): Deleted.
LayoutTests:
- fast/ruby/ruby-inline-margin-collapse-crash-expected.txt: Added.
- fast/ruby/ruby-inline-margin-collapse-crash.html: Added.
- 4:18 AM Changeset in webkit [195207] by
-
- 3 edits2 adds in releases/WebKitGTK/webkit-2.10
Merge r194617 - Image should not be re-registered if m_form already exists. This leads to an assertion failure.
https://bugs.webkit.org/show_bug.cgi?id=152741
<rdar://problem/24030778>
Patch by Pranjal Jumde <pjumde@apple.com> on 2016-01-05
Reviewed by Brent Fulgham.
Source/WebCore:
- Source/WebCore/html/HTMLImageElement.cpp: Node::InsertionNotificationRequest HTMLImageElement::insertedInto(ContainerNode& insertionPoint)
LayoutTests:
- LayoutTests/fast/html/form-registerimg-multiple-crash-expected.txt: Added.
- LayoutTests/fast/html/form-registerimg-multiple-crash.html: Added.
- 4:16 AM Changeset in webkit [195206] by
-
- 2 edits in releases/WebKitGTK/webkit-2.10/Source/WebCore
Merge r194589 - Avoid NULL deference in Page::updateIsPlayingMedia
https://bugs.webkit.org/show_bug.cgi?id=152732
No new tests, this fixes a rare crash that I am unable to reproduce.
Reviewed by David Kilzer.
- page/Page.cpp:
(WebCore::Page::updateIsPlayingMedia): frame->document() can return NULL.
- 4:14 AM Changeset in webkit [195205] by
-
- 2 edits in releases/WebKitGTK/webkit-2.10/Source/WebCore
Merge r194576 - Shave off a TransformationMatrix copy if RenderLayer's transparencyClipBox()
https://bugs.webkit.org/show_bug.cgi?id=152119
Reviewed by Simon Fraser.
- rendering/RenderLayer.cpp:
(WebCore::transparencyClipBox): Multiply the transformation matrix returned by
layer.transform() directly into the transform object, instead of first
multiplying them and then copying the result back into the transform object.
- 4:09 AM Changeset in webkit [195204] by
-
- 3 edits in releases/WebKitGTK/webkit-2.10/Source/WebCore
Merge r194503 - APNG decoder: only decode the frames up to haltAtFrame
https://bugs.webkit.org/show_bug.cgi?id=146205
Patch by Max Stepin <maxstepin@gmail.com> on 2016-01-02
Reviewed by Michael Catanzaro.
No new tests, already covered by existing tests.
- platform/image-decoders/png/PNGImageDecoder.cpp:
(WebCore::PNGImageReader::close):
(WebCore::PNGImageReader::decode):
(WebCore::PNGImageDecoder::isSizeAvailable):
(WebCore::PNGImageDecoder::frameBufferAtIndex):
(WebCore::PNGImageDecoder::pngComplete):
(WebCore::PNGImageDecoder::decode):
- platform/image-decoders/png/PNGImageDecoder.h:
(WebCore::PNGImageDecoder::isComplete):
(WebCore::PNGImageDecoder::isCompleteAtIndex):
- 4:08 AM Changeset in webkit [195203] by
-
- 2 edits in releases/WebKitGTK/webkit-2.10/Source/WebInspectorUI
Merge r194498 - [GTK] webkit 2.3.5 build failure with python 3.3.4
https://bugs.webkit.org/show_bug.cgi?id=128971
Reviewed by Michael Catanzaro.
Make sure that the stdin encoding is 'UTF-8' if using Python 3,
otherwise the build will break.
- Scripts/cssmin.py:
- 4:05 AM Changeset in webkit [195202] by
-
- 6 edits1 add in releases/WebKitGTK/webkit-2.10
Merge r194480 - [SOUP] REGRESSION(r192761): Broke resource URIs for applications that use g_resource_load in a web extension
https://bugs.webkit.org/show_bug.cgi?id=152634
Reviewed by Carlos Garcia Campos.
Source/WebKit2:
Load GResource URIs locally, not in the network process. Applications expect calling
g_resource_load in a web extension to make it possible to load resource URIs, but that
doesn't work now that the network process is in use. Loading them locally solves this.
- WebProcess/Network/WebLoaderStrategy.cpp:
(WebKit::WebLoaderStrategy::scheduleLoad):
Tools:
- TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp:
(testLoadFromGResource): Added test.
(beforeAll):
- TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
(registerGResource): Added.
(webkit_web_extension_initialize_with_user_data): Load the test gresource.
- TestWebKitAPI/Tests/WebKit2Gtk/resources/boring.html: Added.
- TestWebKitAPI/Tests/WebKit2Gtk/resources/webkit2gtk-tests.gresource.xml: Add an HTML file.
- 3:55 AM Changeset in webkit [195201] by
-
- 3 edits2 adds in releases/WebKitGTK/webkit-2.10
Merge r194462 - Simple line layout: Text with stroke width is not positioned correctly.
https://bugs.webkit.org/show_bug.cgi?id=152614
Reviewed by Simon Fraser.
Visual overflow should not affect text position.
Source/WebCore:
Test: fast/text/simple-line-layout-text-position-with-stroke.html
- rendering/SimpleLineLayoutFunctions.cpp:
(WebCore::SimpleLineLayout::paintFlow):
LayoutTests:
- fast/text/simple-line-layout-text-position-with-stroke-expected.html: Added.
- fast/text/simple-line-layout-text-position-with-stroke.html: Added.
- 3:55 AM Changeset in webkit [195200] by
-
- 5 edits2 adds in releases/WebKitGTK/webkit-2.10
Merge r192564 - Simple line layout: Add letter-spacing support.
https://bugs.webkit.org/show_bug.cgi?id=151362
Reviewed by Antti Koivisto.
This enables us to use simple line layout on letter-spacing content.
(fixme: webkit.org/b/151368 -> Repaint rect is not computed correctly when negative letter-spacing applied)
Source/WebCore:
Test: fast/text/simple-line-letterspacing.html
- rendering/SimpleLineLayout.cpp:
(WebCore::SimpleLineLayout::canUseForStyle):
- rendering/SimpleLineLayoutFunctions.cpp:
(WebCore::SimpleLineLayout::paintFlow): RenderLineBoxList tests vertical intersection only.
- rendering/SimpleLineLayoutTextFragmentIterator.cpp:
(WebCore::SimpleLineLayout::TextFragmentIterator::runWidth):
LayoutTests:
- fast/text/simple-line-letterspacing-expected.html: Added.
- fast/text/simple-line-letterspacing.html: Added.
- 3:49 AM Changeset in webkit [195199] by
-
- 3 edits2 adds in releases/WebKitGTK/webkit-2.10
Merge r194461 - Simple line layout: Nested block with pseudo first-line parent should bail out of simple line layout.
https://bugs.webkit.org/show_bug.cgi?id=152599
Reviewed by Simon Fraser.
We should bail out of simple line layout if any of the ancestors have pseudo first-line style.
(see RenderBlock::firstLineBlock())
Source/WebCore:
Test: fast/block/line-layout/first-line-should-bail-out-of-simple-line-layout.html
- rendering/SimpleLineLayout.cpp:
(WebCore::SimpleLineLayout::canUseForWithReason):
LayoutTests:
- fast/block/line-layout/first-line-should-bail-out-of-simple-line-layout-expected.html: Added.
- fast/block/line-layout/first-line-should-bail-out-of-simple-line-layout.html: Added.
- 3:43 AM Changeset in webkit [195198] by
-
- 3 edits2 adds in releases/WebKitGTK/webkit-2.10
Merge r194426 - Should never be reached failure in WebCore::RenderElement::clearLayoutRootIfNeeded
https://bugs.webkit.org/show_bug.cgi?id=151590
Reviewed by Simon Fraser.
We should always set the layoutroot when a new subtree layout is requested (and convert it
to a full layout when needed). It ensures that renderers are detached cleanly even when
they are set as layoutroot.
Source/WebCore:
Test: fast/block/assert-when-layout-root-is-not-cleared.html
- page/FrameView.cpp:
(WebCore::FrameView::scheduleRelayoutOfSubtree):
LayoutTests:
- fast/block/assert-when-layout-root-is-not-cleared-expected.txt: Added.
- fast/block/assert-when-layout-root-is-not-cleared.html: Added.
- 3:41 AM Changeset in webkit [195197] by
-
- 3 edits4 adds in releases/WebKitGTK/webkit-2.10
Merge r194418 - ASSERTION FAILED: x2 >= x1 in WebCore::RenderElement::drawLineForBoxSide
https://bugs.webkit.org/show_bug.cgi?id=151210
Reviewed by Simon Fraser.
Source/WebCore:
"IntRect outer = snappedIntRect(inner)" explicitly converts inner to LayoutRect first and
returns a snapped IntRect. When inner (after the inflate) overflows LayoutUnit,
the snapped rect might become smaller than the inner rect.
This patch also enables outline painting on subpixel positions.
Tests: fast/borders/hidpi-outline-on-subpixel-position.html
fast/borders/outline-offset-overflow.html
- rendering/RenderElement.cpp:
(WebCore::RenderElement::paintOutline):
LayoutTests:
"IntRect outer = snappedIntRect(inner)" explicitly converts inner to LayoutRect and
returns a snapped IntRect. When inner (after the inflate) overflows LayoutUnit,
the snapped outer rect becomes smaller than the inner rect.
This patch also enables outline painting on subpixel positions.
- fast/borders/hidpi-outline-on-subpixel-position-expected.html: Added.
- fast/borders/hidpi-outline-on-subpixel-position.html: Added.
- fast/borders/outline-offset-overflow-expected.txt: Added.
- fast/borders/outline-offset-overflow.html: Added.
- 3:36 AM Changeset in webkit [195196] by
-
- 13 edits2 adds in releases/WebKitGTK/webkit-2.10
Merge r194405 - REGRESSION (r187593): Scroll position jumps when selecting text in an iframe
https://bugs.webkit.org/show_bug.cgi?id=152541
rdar://problem/23886181
Reviewed by Tim Horton.
Source/WebCore:
r154382 added code that modifies parentLayer traversal, looking for ancestor
scrollable layers. However, it confusingly added another code path in which
the ancestor layer traversal cross a frame boundary, when RenderLayer::scrollRectToVisible()
already has one. I fixed this new location to adjust the rect coordinates in r187593,
but then code that hit both crossing points double-mapped the coordinates, causing
autoscroll jumping.
Fix by reverting r154382 and r187593, going back to doing the ancestor walk in
one place. Re-fix r154382 by implementing RenderLayer::allowsCurrentScroll(),
which contains the logic for line clamp, autoscroll and ensuring that overflow:hidden
can be programmatically scrolled.
Form controls are special; they can have overflow:hidden but still be user-scrollable
during autoscroll; this is handled via the confusingly-named canBeProgramaticallyScrolled().
RenderTextControlSingleLine implements this to ensure that readonly text inputs
autoscroll (which is exercised by a test).
The frame-to-parent-frame rect mapping in RenderLayer::scrollRectToVisible() is
fixed to use the coordinate mapping functions from Widget/ScrollView, with the
addition of a new utility function contentsToContainingViewContents().
A "Scrolling" logging channel is added with a few log points.
Test: fast/events/autoscroll-in-iframe-body.html
- page/scrolling/ScrollingCoordinator.cpp:
(WebCore::ScrollingCoordinator::absoluteNonFastScrollableRegionForFrame):
use contentsToContainingViewContents().
- platform/Logging.h:
- platform/ScrollView.cpp:
(WebCore::ScrollView::contentsToContainingViewContents):
- platform/ScrollView.h:
- platform/graphics/IntPoint.cpp:
(WebCore::IntPoint::constrainedBetween): New helper to constrain a point between
two other points.
- platform/graphics/IntPoint.h:
(WebCore::IntPoint::expandedTo):
(WebCore::IntPoint::shrunkTo):
- rendering/RenderBox.cpp:
- rendering/RenderLayer.cpp:
(WebCore::parentLayerCrossFrame):
(WebCore::RenderLayer::enclosingScrollableLayer):
(WebCore::frameElementAndViewPermitScroll):
(WebCore::RenderLayer::allowsCurrentScroll):
(WebCore::RenderLayer::scrollRectToVisible):
- rendering/RenderLayer.h:
- rendering/RenderTextControlSingleLine.h:
LayoutTests:
New test for autoscrolling iframe contents (an existing test scrolled an overflow:scroll
inside an iframe, and didn't catch the bug).
- fast/events/autoscroll-in-iframe-body-expected.txt: Added.
- fast/events/autoscroll-in-iframe-body.html: Added.
- fast/forms/input-readonly-autoscroll.html: Fix a missing double quote.
- 3:36 AM Changeset in webkit [195195] by
-
- 4 edits2 adds in releases/WebKitGTK/webkit-2.10
Merge r194404 - Minor cleanup in RenderBox::canBeProgramaticallyScrolled()
https://bugs.webkit.org/show_bug.cgi?id=152515
Reviewed by Tim Horton.
Source/WebCore:
Remove the scrollsOverflow() check in RenderBox::canBeProgramaticallyScrolled(),
since if hasScrollableOverflow is true, scrollsOverflow() must also be true.
Factor clientWidth/Height vs. scrollWidth/Height checks into separate functions,
and call them from two places.
Added a test which is not affected by this particular change, but will verify
that a later change doesn't break anything.
Test: fast/overflow/overflow-hidden-scroll-into-view.html
- rendering/RenderBox.cpp:
(WebCore::RenderBox::canBeScrolledAndHasScrollableArea):
(WebCore::RenderBox::canBeProgramaticallyScrolled):
- rendering/RenderBox.h:
(WebCore::RenderBox::hasHorizontalOverflow):
(WebCore::RenderBox::hasVerticalOverflow):
(WebCore::RenderBox::hasScrollableOverflowX):
(WebCore::RenderBox::hasScrollableOverflowY):
LayoutTests:
Test that programmatic scrolling works inside overflow:hidden.
- fast/overflow/overflow-hidden-scroll-into-view-expected.html: Added.
- fast/overflow/overflow-hidden-scroll-into-view.html: Added.
- 2:57 AM Changeset in webkit [195194] by
-
- 3 edits2 adds in releases/WebKitGTK/webkit-2.10
Merge r194399 - Avoids stack recursion when indexed propertyNames defined using Object.defineProperty are deleted.
https://bugs.webkit.org/show_bug.cgi?id=149179
<rdar://problem/22708019>.
Patch by Pranjal Jumde <pjumde@apple.com> on 2015-12-23
Reviewed by Filip Pizlo.
- runtime/JSObject.cpp:
(JSStorage::deletePropertyByIndex was invoking Base::deleteProperty for indexed propertyNames instead of Base::deletePropertyByIndex leading to a stack recursion)
LayoutTests:
Test to check for stack recursion when indexed propertyNames defined using Object.defineProperty are deleted.
https://bugs.webkit.org/show_bug.cgi?id=149179
<rdar://problem/22708019>.
Patch by Pranjal Jumde <pjumde@apple.com> on 2015-12-23
Reviewed by Filip Pizlo.
- storage/domstorage/localstorage/delete-defineproperty-removal-expected.txt: Added.
- storage/domstorage/localstorage/delete-defineproperty-removal.html: Added.
- 2:42 AM Changeset in webkit [195193] by
-
- 2 edits in releases/WebKitGTK/webkit-2.10/Tools
Merge r194327 - [GTK] jquery.min.js violates DFSG
https://bugs.webkit.org/show_bug.cgi?id=152428
Reviewed by Joseph Pecoraro.
Stop distributing Source/WebInspectorUI/Tools. It is not needed in tarballs. This brings us
into compliance with DFSG by removing a bundled, minified copy of jQuery from our tarball.
- gtk/manifest.txt.in:
- 2:41 AM Changeset in webkit [195192] by
-
- 7 edits in releases/WebKitGTK/webkit-2.10/Source
Merge r194323 - [SOUP] Performs DNS prefetch when a proxy is configured (information leak)
https://bugs.webkit.org/show_bug.cgi?id=145542
Reviewed by Darin Adler.
Source/WebCore:
Perform DNS prefetch only when no proxy is configured.
No new tests. Test this manually with Wireshark. Run the simple-proxy example program found
in libsoup's examples directory, set that as your system HTTP proxy, and see if DNS queries
show up in Wireshark when refreshing a page sent over HTTP. They should appear only when the
proxy is not configured.
- platform/network/DNSResolveQueue.cpp:
(WebCore::DNSResolveQueue::DNSResolveQueue):
(WebCore::DNSResolveQueue::isUsingProxy):
- platform/network/DNSResolveQueue.h:
- platform/network/cf/DNSCFNet.cpp:
(WebCore::DNSResolveQueue::updateIsUsingProxy):
(WebCore::DNSResolveQueue::platformProxyIsEnabledInSystemPreferences): Deleted.
- platform/network/soup/DNSSoup.cpp:
(WebCore::didResolveProxy):
(WebCore::proxyResolvedForHttpUriCallback):
(WebCore::proxyResolvedForHttpsUriCallback):
(WebCore::DNSResolveQueue::updateIsUsingProxy):
(WebCore::DNSResolveQueue::platformProxyIsEnabledInSystemPreferences): Deleted.
Source/WTF:
Specialize GUniquePtr<char*>, using g_strfreev.
- wtf/glib/GUniquePtr.h:
- 1:50 AM Changeset in webkit [195191] by
-
- 2 edits in releases/WebKitGTK/webkit-2.10/Source/WebCore/platform/gtk/po
Merge r194321 - German translation update
https://bugs.webkit.org/show_bug.cgi?id=152228
Unreviewed.
Patch by Bernd Homuth <dev@hmt.im> on 2015-12-20
- de.po:
- 12:23 AM Changeset in webkit [195190] by
-
- 3 edits in releases/WebKitGTK/webkit-2.10/Source/WebCore
Merge r194290 - Place an upper bound on canvas pixel count
https://bugs.webkit.org/show_bug.cgi?id=151825
<rdar://problem/23324916>
Reviewed by Simon Fraser (Relanded by Brent Fulgham)
Malformed JavaScript can attempt to create lots of canvas contexts. Limit the amount of memory
we will use for this purpose to some percentage of system RAM.
- html/HTMLCanvasElement.cpp:
(WebCore::removeFromActivePixelMemory): Added helper function
(WebCore::HTMLCanvasElement::~HTMLCanvasElement): Call new 'releaseImageBufferAndContext' method
to ensure ImageBuffer and graphics context state are properly cleaned up.
(WebCore::maxActivePixels): Use one quarter of the system RAM, or 2 GB (whichever is more) as
an upper bound on active pixel memory.
(WebCore::HTMLCanvasElement::getContext): If we are attempting to create a context that will cause
us to exceed the allowed active pixel count, fail.
(WebCore::HTMLCanvasElement::releaseImageBufferAndContext): Added helper function
(WebCore::HTMLCanvasElement::setSurfaceSize): Use the new 'releaseImageBufferAndContext' method
to handle active pixel memory counts.
(WebCore::HTMLCanvasElement::createImageBuffer): Refuse to create a backing buffer if it will
exceed our available pixel memory.
- 12:15 AM Changeset in webkit [195189] by
-
- 2 edits in releases/WebKitGTK/webkit-2.10/Source/JavaScriptCore
Merge r194208 - ARM64 MacroAssembler improperly reuses data temp register in test32() and test8() calls
https://bugs.webkit.org/show_bug.cgi?id=152370
Reviewed by Benjamin Poulain.
Changed the test8/32(Address, Register) flavors to use the memoryTempRegister for loading the value
att Address so that it doesn't collide with the subsequent use of dataTempRegister by the
test32(Register, Register) function.
- assembler/MacroAssemblerARM64.h:
(JSC::MacroAssemblerARM64::test32):
(JSC::MacroAssemblerARM64::test8):
- 12:10 AM Changeset in webkit [195188] by
-
- 3 edits in releases/WebKitGTK/webkit-2.10/Source/WebCore
Merge r194155 - Legacy style scrollbars do not change color when you mouse over them if you
are scrolled
https://bugs.webkit.org/show_bug.cgi?id=152319
-and corresponding-
rdar://problem/23317668
Reviewed by Darin Adler.
The scrollbar’s frameRect is in window coordinates, so we need to compare a
point in window coordinates when we test this.
The call to convertFromContainingWindow does not return a point in view
coordinates, so we should not call the variable viewPoint. We do still need
to call it for subframes. convertFromContainingWindow doesn’t do anything for
the root ScrollView (for Mac WK2 at least).
- platform/ScrollView.cpp:
(WebCore::ScrollView::scrollbarAtPoint):
HitTestLocation is in contents coordinates. It needs to be converted to
window coordinates
- rendering/RenderView.cpp:
(WebCore::RenderView::hitTest):
- 12:09 AM Changeset in webkit [195187] by
-
- 3 edits2 adds in releases/WebKitGTK/webkit-2.10
Merge r194558 - REGRESSION(r194143): Float width incorrectly calculated on Wikipedia
https://bugs.webkit.org/show_bug.cgi?id=152644
Reviewed by Myles C. Maxfield.
Source/WebCore:
The min/max-content contribution computation for non replaced
blocks changed in r194143. The implementation was actually
more complex than it should be and actually incomplete as it
was not considering the case of out of flow elements (because
it was directly calling computeLogicalWidthInRegion()).
This new implementation simplifies a lot the code and makes it
more complete as it relies on min|maxPreferredLogicalWidth()
calls which already consider all the different types of boxes.
Test: fast/css-intrinsic-dimensions/inlinesize-contribution-floats.html
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::computeBlockPreferredLogicalWidths):
LayoutTests:
- fast/css-intrinsic-dimensions/inlinesize-contribution-floats-expected.html: Added.
- fast/css-intrinsic-dimensions/inlinesize-contribution-floats.html: Added.
Jan 17, 2016:
- 8:41 PM Changeset in webkit [195186] by
-
- 2 edits in trunk/Source/WebKit2
Add quotes around ${CMAKE_SHARED_LINKER_FLAGS} in case it is unset
https://bugs.webkit.org/show_bug.cgi?id=153175
Patch by Jeremy Huddleston Sequoia <jeremyhu@apple.com> on 2016-01-17
Reviewed by Michael Catanzaro.
- PlatformGTK.cmake:
- 7:20 PM Changeset in webkit [195185] by
-
- 5 edits9 adds in trunk
More displaylist tests, and minor cleanup
https://bugs.webkit.org/show_bug.cgi?id=153198
Reviewed by Zalan Bujtas.
Source/WebCore:
Have the DisplayListRecorder's constructor push the recorder onto the GraphicsContext,
and remove that code from GraphicsLayerCA.
Tests: displaylists/extent-includes-shadow.html
displaylists/extent-includes-transforms.html
- platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::recursiveCommitChanges):
- platform/graphics/displaylists/DisplayListRecorder.cpp:
(WebCore::DisplayList::Recorder::Recorder):
LayoutTests:
A couple more display list tests that check that the computed extent of an item
includes shadows and transforms.
WK1 results differ in that they disable should-subpixel-quantize-fonts in the state
(which is a bug).
Move some shared JS into a helper file.
- displaylists/extent-includes-shadow-expected.txt: Added.
- displaylists/extent-includes-shadow.html: Added.
- displaylists/extent-includes-transforms-expected.txt: Added.
- displaylists/extent-includes-transforms.html: Added.
- displaylists/layer-dispay-list.html:
- displaylists/resources/dump-target-display-list.js: Added.
(doTest):
- platform/mac-wk1/displaylists/extent-includes-shadow-expected.txt: Added.
- platform/mac-wk1/displaylists/extent-includes-transforms-expected.txt: Added.
- 2:24 PM Changeset in webkit [195184] by
-
- 2 edits in trunk/Source/JavaScriptCore
Ensure that CF_AVAILABLE is undefined when building webkit-gtk
https://bugs.webkit.org/show_bug.cgi?id=152720
This change ensures that CF_AVAILABLE is correctly a no-op to
address build failure that was observed when building on older
versions of OSX. Previously, CF_AVAILABLE may have been unexpectedly
re-defined to the system header value based on include-order.
Patch by Jeremy Huddleston Sequoia <jeremyhu@apple.com> on 2016-01-17
Reviewed by Michael Catanzaro.
- API/WebKitAvailability.h:
- 10:09 AM Changeset in webkit [195183] by
-
- 5 edits in trunk
[CMake] Do not build bmalloc when USE_SYSTEM_MALLOC is ON
https://bugs.webkit.org/show_bug.cgi?id=153190
Reviewed by Csaba Osztrogonác.
Build bmalloc when NOT USE_SYSTEM_MALLOC rather than when NOT WIN32.
.:
- Source/CMakeLists.txt:
- Source/cmake/OptionsWin.cmake:
Source/WTF:
- wtf/CMakeLists.txt:
- 1:15 AM Changeset in webkit [195182] by
-
- 5 edits in trunk/Source/JavaScriptCore
[mips] Fix regT2 and regT3 trampling in MacroAssembler
https://bugs.webkit.org/show_bug.cgi?id=153131
Mips $t2 and $t3 registers were used as temporary registers
in MacroAssemblerMIPS.h, whereas they are mapped to regT2
and regT3 in LLInt and GPRInfo.
This patch rearranges register mapping for the mips architecture:
- use $t0 and $t1 as temp registers in LLInt (as in MacroAssembler)
- use $t7 and $t8 as temp registers in MacroAssembler (as in LLInt)
- remove $t6 from temp registers list in LLInt
- update GPRInfo.h accordingly
- add mips macroScratchRegisters() list in RegisterSet.cpp
Reviewed by Michael Saboff.
- assembler/MacroAssemblerMIPS.h:
- jit/GPRInfo.h:
(JSC::GPRInfo::toRegister):
(JSC::GPRInfo::toIndex):
- jit/RegisterSet.cpp:
(JSC::RegisterSet::macroScratchRegisters):
(JSC::RegisterSet::calleeSaveRegisters):
- offlineasm/mips.rb:
- 12:13 AM Changeset in webkit [195181] by
-
- 227 edits in trunk/LayoutTests
Modern IDB: .js test files should not log database names.
https://bugs.webkit.org/show_bug.cgi?id=153181
Reviewed by Alex Christensen.
We'll be sharing .js files as well as test expectations between different HTML test files,
and logging the filename is counter to this goal, as it will change depending on the HTML
driver running the test.
- storage/indexeddb/resources/shared.js:
(setDBNameFromPath): eval() setting the filename instead of evalAndLog().
- platform/wk2/storage/indexeddb/aborted-versionchange-closes-expected.txt:
- platform/wk2/storage/indexeddb/create-and-remove-object-store-expected.txt:
- platform/wk2/storage/indexeddb/cursor-continue-dir-expected.txt:
- platform/wk2/storage/indexeddb/cursor-continue-expected.txt:
- platform/wk2/storage/indexeddb/cursor-finished-expected.txt:
- platform/wk2/storage/indexeddb/database-basics-expected.txt:
- platform/wk2/storage/indexeddb/index-count-expected.txt:
- platform/wk2/storage/indexeddb/intversion-abort-in-initial-upgradeneeded-expected.txt:
- platform/wk2/storage/indexeddb/intversion-close-in-oncomplete-expected.txt:
- platform/wk2/storage/indexeddb/intversion-close-in-upgradeneeded-expected.txt:
- platform/wk2/storage/indexeddb/invalid-keys-expected.txt:
- platform/wk2/storage/indexeddb/key-type-array-expected.txt:
- platform/wk2/storage/indexeddb/keypath-arrays-expected.txt:
- platform/wk2/storage/indexeddb/keypath-edges-expected.txt:
- platform/wk2/storage/indexeddb/mozilla/bad-keypath-expected.txt:
- platform/wk2/storage/indexeddb/mozilla/clear-expected.txt:
- platform/wk2/storage/indexeddb/mozilla/create-objectstore-basics-expected.txt:
- platform/wk2/storage/indexeddb/mozilla/cursors-expected.txt:
- platform/wk2/storage/indexeddb/mozilla/key-requirements-delete-null-key-expected.txt:
- platform/wk2/storage/indexeddb/mozilla/key-requirements-inline-and-passed-expected.txt:
- platform/wk2/storage/indexeddb/mozilla/key-requirements-put-no-key-expected.txt:
- platform/wk2/storage/indexeddb/mozilla/key-requirements-put-null-key-expected.txt:
- platform/wk2/storage/indexeddb/mozilla/readonly-transactions-expected.txt:
- platform/wk2/storage/indexeddb/object-lookups-in-versionchange-expected.txt:
- platform/wk2/storage/indexeddb/objectstore-count-expected.txt:
- platform/wk2/storage/indexeddb/open-cursor-expected.txt:
- platform/wk2/storage/indexeddb/request-result-cache-expected.txt:
- platform/wk2/storage/indexeddb/transaction-abort-expected.txt:
- platform/wk2/storage/indexeddb/transaction-active-flag-expected.txt:
- platform/wk2/storage/indexeddb/transaction-after-close-expected.txt:
- platform/wk2/storage/indexeddb/transaction-read-only-expected.txt:
- platform/wk2/storage/indexeddb/version-change-exclusive-expected.txt:
- storage/indexeddb/aborted-versionchange-closes-expected.txt:
- storage/indexeddb/clone-exception-expected.txt:
- storage/indexeddb/closed-cursor-expected.txt:
- storage/indexeddb/create-and-remove-object-store-expected.txt:
- storage/indexeddb/create-object-store-options-expected.txt:
- storage/indexeddb/createIndex-after-failure-expected.txt:
- storage/indexeddb/createObjectStore-name-argument-required-expected.txt:
- storage/indexeddb/createObjectStore-null-name-expected.txt:
- storage/indexeddb/cursor-added-bug-expected.txt:
- storage/indexeddb/cursor-advance-expected.txt:
- storage/indexeddb/cursor-basics-expected.txt:
- storage/indexeddb/cursor-cast-expected.txt:
- storage/indexeddb/cursor-continue-dir-expected.txt:
- storage/indexeddb/cursor-continue-expected.txt:
- storage/indexeddb/cursor-continue-validity-expected.txt:
- storage/indexeddb/cursor-delete-expected.txt:
- storage/indexeddb/cursor-finished-expected.txt:
- storage/indexeddb/cursor-inconsistency-expected.txt:
- storage/indexeddb/cursor-index-delete-expected.txt:
- storage/indexeddb/cursor-key-order-expected.txt:
- storage/indexeddb/cursor-overloads-expected.txt:
- storage/indexeddb/cursor-prev-no-duplicate-expected.txt:
- storage/indexeddb/cursor-primary-key-order-expected.txt:
- storage/indexeddb/cursor-properties-expected.txt:
- storage/indexeddb/cursor-reverse-bug-expected.txt:
- storage/indexeddb/cursor-skip-deleted-expected.txt:
- storage/indexeddb/cursor-update-expected.txt:
- storage/indexeddb/cursor-update-value-argument-required-expected.txt:
- storage/indexeddb/cursor-value-expected.txt:
- storage/indexeddb/database-basics-expected.txt:
- storage/indexeddb/database-close-expected.txt:
- storage/indexeddb/database-closepending-flag-expected.txt:
- storage/indexeddb/database-deletepending-flag-expected.txt:
- storage/indexeddb/database-wrapper-expected.txt:
- storage/indexeddb/delete-closed-database-object-expected.txt:
- storage/indexeddb/delete-in-upgradeneeded-close-in-open-success-expected.txt:
- storage/indexeddb/delete-in-upgradeneeded-close-in-versionchange-expected.txt:
- storage/indexeddb/delete-range-expected.txt:
- storage/indexeddb/deleteIndex-expected.txt:
- storage/indexeddb/deleteObjectStore-name-argument-required-expected.txt:
- storage/indexeddb/deleteObjectStore-null-name-expected.txt:
- storage/indexeddb/deleted-objects-expected.txt:
- storage/indexeddb/deletedatabase-blocked-expected.txt:
- storage/indexeddb/deletedatabase-delayed-by-open-and-versionchange-expected.txt:
- storage/indexeddb/deletedatabase-not-blocked-expected.txt:
- storage/indexeddb/deletedatabase-transaction-expected.txt:
- storage/indexeddb/dont-wedge-expected.txt:
- storage/indexeddb/duplicates-expected.txt:
- storage/indexeddb/error-causes-abort-by-default-expected.txt:
- storage/indexeddb/exception-in-event-aborts-expected.txt:
- storage/indexeddb/exceptions-expected.txt:
- storage/indexeddb/factory-deletedatabase-expected.txt:
- storage/indexeddb/get-keyrange-expected.txt:
- storage/indexeddb/index-basics-expected.txt:
- storage/indexeddb/index-count-expected.txt:
- storage/indexeddb/index-cursor-expected.txt:
- storage/indexeddb/index-duplicate-keypaths-expected.txt:
- storage/indexeddb/index-get-key-argument-required-expected.txt:
- storage/indexeddb/index-multientry-expected.txt:
- storage/indexeddb/index-population-expected.txt:
- storage/indexeddb/index-unique-expected.txt:
- storage/indexeddb/intversion-abort-in-initial-upgradeneeded-expected.txt:
- storage/indexeddb/intversion-bad-parameters-expected.txt:
- storage/indexeddb/intversion-blocked-expected.txt:
- storage/indexeddb/intversion-close-between-events-expected.txt:
- storage/indexeddb/intversion-close-in-oncomplete-expected.txt:
- storage/indexeddb/intversion-close-in-upgradeneeded-expected.txt:
- storage/indexeddb/intversion-encoding-expected.txt:
- storage/indexeddb/intversion-gated-on-delete-expected.txt:
- storage/indexeddb/intversion-long-queue-expected.txt:
- storage/indexeddb/intversion-omit-parameter-expected.txt:
- storage/indexeddb/intversion-open-in-upgradeneeded-expected.txt:
- storage/indexeddb/intversion-open-with-version-expected.txt:
- storage/indexeddb/intversion-pending-version-changes-ascending-expected.txt:
- storage/indexeddb/intversion-pending-version-changes-descending-expected.txt:
- storage/indexeddb/intversion-pending-version-changes-same-expected.txt:
- storage/indexeddb/intversion-persistence-expected.txt:
- storage/indexeddb/intversion-revert-on-abort-expected.txt:
- storage/indexeddb/intversion-two-opens-no-versions-expected.txt:
- storage/indexeddb/intversion-upgrades-expected.txt:
- storage/indexeddb/invalid-keys-expected.txt:
- storage/indexeddb/key-generator-expected.txt:
- storage/indexeddb/key-sort-order-across-types-expected.txt:
- storage/indexeddb/key-sort-order-date-expected.txt:
- storage/indexeddb/key-type-array-expected.txt:
- storage/indexeddb/key-type-binary-expected.txt:
- storage/indexeddb/key-type-infinity-expected.txt:
- storage/indexeddb/keypath-arrays-expected.txt:
- storage/indexeddb/keypath-basics-expected.txt:
- storage/indexeddb/keypath-edges-expected.txt:
- storage/indexeddb/keypath-fetch-key-expected.txt:
- storage/indexeddb/keypath-intrinsic-properties-expected.txt:
- storage/indexeddb/lazy-index-population-expected.txt:
- storage/indexeddb/lazy-index-types-expected.txt:
- storage/indexeddb/list-ordering-expected.txt:
- storage/indexeddb/metadata-expected.txt:
- storage/indexeddb/metadata-race-expected.txt:
- storage/indexeddb/modern/abort-objectstore-info-expected.txt:
- storage/indexeddb/modern/blocked-open-db-requests-expected.txt:
- storage/indexeddb/modern/memory-index-not-deleted-with-objectstore-expected.txt:
- storage/indexeddb/modern/transaction-scheduler-4-expected.txt:
- storage/indexeddb/mozilla/add-twice-failure-expected.txt:
- storage/indexeddb/mozilla/autoincrement-indexes-expected.txt:
- storage/indexeddb/mozilla/bad-keypath-expected.txt:
- storage/indexeddb/mozilla/clear-expected.txt:
- storage/indexeddb/mozilla/create-index-unique-expected.txt:
- storage/indexeddb/mozilla/create-index-with-integer-keys-expected.txt:
- storage/indexeddb/mozilla/create-objectstore-basics-expected.txt:
- storage/indexeddb/mozilla/create-objectstore-null-name-expected.txt:
- storage/indexeddb/mozilla/cursor-mutation-expected.txt:
- storage/indexeddb/mozilla/cursor-mutation-objectstore-only-expected.txt:
- storage/indexeddb/mozilla/cursor-update-updates-indexes-expected.txt:
- storage/indexeddb/mozilla/cursors-expected.txt:
- storage/indexeddb/mozilla/delete-result-expected.txt:
- storage/indexeddb/mozilla/event-source-expected.txt:
- storage/indexeddb/mozilla/global-data-expected.txt:
- storage/indexeddb/mozilla/index-prev-no-duplicate-expected.txt:
- storage/indexeddb/mozilla/indexes-expected.txt:
- storage/indexeddb/mozilla/key-requirements-delete-null-key-expected.txt:
- storage/indexeddb/mozilla/key-requirements-expected.txt:
- storage/indexeddb/mozilla/key-requirements-inline-and-passed-expected.txt:
- storage/indexeddb/mozilla/key-requirements-put-no-key-expected.txt:
- storage/indexeddb/mozilla/key-requirements-put-null-key-expected.txt:
- storage/indexeddb/mozilla/object-cursors-expected.txt:
- storage/indexeddb/mozilla/object-identity-expected.txt:
- storage/indexeddb/mozilla/object-store-inline-autoincrement-key-added-on-put-expected.txt:
- storage/indexeddb/mozilla/object-store-remove-values-expected.txt:
- storage/indexeddb/mozilla/objectstorenames-expected.txt:
- storage/indexeddb/mozilla/odd-result-order-expected.txt:
- storage/indexeddb/mozilla/put-get-values-expected.txt:
- storage/indexeddb/mozilla/readonly-transactions-expected.txt:
- storage/indexeddb/mozilla/readwrite-transactions-expected.txt:
- storage/indexeddb/mozilla/readyState-expected.txt:
- storage/indexeddb/mozilla/remove-index-expected.txt:
- storage/indexeddb/mozilla/remove-objectstore-expected.txt:
- storage/indexeddb/mozilla/versionchange-abort-expected.txt:
- storage/indexeddb/mutating-cursor-expected.txt:
- storage/indexeddb/noblobs-expected.txt:
- storage/indexeddb/object-lookups-in-versionchange-expected.txt:
- storage/indexeddb/objectStore-required-arguments-expected.txt:
- storage/indexeddb/objectstore-autoincrement-expected.txt:
- storage/indexeddb/objectstore-basics-expected.txt:
- storage/indexeddb/objectstore-clear-expected.txt:
- storage/indexeddb/objectstore-count-expected.txt:
- storage/indexeddb/objectstore-cursor-expected.txt:
- storage/indexeddb/objectstore-removeobjectstore-expected.txt:
- storage/indexeddb/open-cursor-expected.txt:
- storage/indexeddb/open-during-transaction-expected.txt:
- storage/indexeddb/open-ordering-expected.txt:
- storage/indexeddb/opencursor-key-expected.txt:
- storage/indexeddb/optional-arguments-expected.txt:
- storage/indexeddb/pending-activity-expected.txt:
- storage/indexeddb/persistence-expected.txt:
- storage/indexeddb/prefetch-bugfix-108071-expected.txt:
- storage/indexeddb/prefetch-invalidation-expected.txt:
- storage/indexeddb/prefetch-race-expected.txt:
- storage/indexeddb/queued-commands-expected.txt:
- storage/indexeddb/readonly-expected.txt:
- storage/indexeddb/readonly-properties-expected.txt:
- storage/indexeddb/request-continue-abort-expected.txt:
- storage/indexeddb/request-event-propagation-expected.txt:
- storage/indexeddb/request-result-cache-expected.txt:
- storage/indexeddb/set_version_blocked-expected.txt:
- storage/indexeddb/setversion-blocked-by-versionchange-close-expected.txt:
- storage/indexeddb/setversion-not-blocked-expected.txt:
- storage/indexeddb/structured-clone-expected.txt:
- storage/indexeddb/transaction-abort-expected.txt:
- storage/indexeddb/transaction-active-flag-expected.txt:
- storage/indexeddb/transaction-after-close-expected.txt:
- storage/indexeddb/transaction-and-objectstore-calls-expected.txt:
- storage/indexeddb/transaction-basics-expected.txt:
- storage/indexeddb/transaction-complete-with-js-recursion-cross-frame-expected.txt:
- storage/indexeddb/transaction-complete-with-js-recursion-expected.txt:
- storage/indexeddb/transaction-coordination-across-databases-expected.txt:
- storage/indexeddb/transaction-coordination-within-database-expected.txt:
- storage/indexeddb/transaction-crash-in-tasks-expected.txt:
- storage/indexeddb/transaction-crash-on-abort-expected.txt:
- storage/indexeddb/transaction-error-expected.txt:
- storage/indexeddb/transaction-event-propagation-expected.txt:
- storage/indexeddb/transaction-ordering-expected.txt:
- storage/indexeddb/transaction-overlapping-expected.txt:
- storage/indexeddb/transaction-read-only-expected.txt:
- storage/indexeddb/transaction-readwrite-exclusive-expected.txt:
- storage/indexeddb/transaction-rollback-expected.txt:
- storage/indexeddb/transaction-scope-sequencing-expected.txt:
- storage/indexeddb/transaction-starvation-expected.txt:
- storage/indexeddb/transaction-storeNames-required-expected.txt:
- storage/indexeddb/unblocked-version-changes-expected.txt:
- storage/indexeddb/value-undefined-expected.txt:
- storage/indexeddb/values-odd-types-expected.txt:
- storage/indexeddb/version-change-abort-expected.txt:
- storage/indexeddb/version-change-event-expected.txt:
- storage/indexeddb/version-change-exclusive-expected.txt:
Jan 16, 2016:
- 8:54 PM Changeset in webkit [195180] by
-
- 34 edits8 deletes in trunk
Remove TextRun::allowsRoundingHacks()
https://bugs.webkit.org/show_bug.cgi?id=153185
Reviewed by Simon Fraser.
Source/WebCore:
Rounding hacks are disallowed by default, and are only re-enabled on iOS 4 and
earlier, which are not supported OSes. Because they are disallowed on all
supported configurations, remove support for them wholesale.
No new tests.
- html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::drawTextInternal):
- platform/graphics/FontCascade.cpp:
- platform/graphics/FontCascade.h:
(WebCore::FontCascade::isRoundingHackCharacter): Deleted.
- platform/graphics/StringTruncator.cpp:
(WebCore::stringWidth):
(WebCore::truncateString):
(WebCore::StringTruncator::centerTruncate):
(WebCore::StringTruncator::rightTruncate):
(WebCore::StringTruncator::width):
(WebCore::StringTruncator::leftTruncate):
(WebCore::StringTruncator::rightClipToCharacter):
(WebCore::StringTruncator::rightClipToWord):
- platform/graphics/StringTruncator.h:
- platform/graphics/TextRun.cpp:
(WebCore::TextRun::setAllowsRoundingHacks): Deleted.
(WebCore::TextRun::allowsRoundingHacks): Deleted.
- platform/graphics/TextRun.h:
(WebCore::TextRun::TextRun):
(WebCore::TextRun::applyRunRounding): Deleted.
(WebCore::TextRun::applyWordRounding): Deleted.
(WebCore::TextRun::disableRoundingHacks): Deleted.
- platform/graphics/WidthIterator.cpp:
(WebCore::WidthIterator::advanceInternal):
- platform/graphics/mac/ComplexTextController.cpp:
(WebCore::ComplexTextController::adjustGlyphsAndAdvances):
- platform/mac/DragImageMac.mm:
(WebCore::widthWithFont): Deleted.
(WebCore::drawAtPoint): Deleted.
- rendering/RenderFileUploadControl.cpp:
(WebCore::RenderFileUploadControl::fileTextValue):
(WebCore::RenderFileUploadControl::paintObject): Deleted.
- rendering/RenderListBox.cpp:
(WebCore::RenderListBox::paintItemForeground):
(WebCore::RenderListBox::updateFromElement): Deleted.
- rendering/RenderTextControl.cpp:
(WebCore::RenderTextControl::getAverageCharWidth): Deleted.
- rendering/RenderTheme.cpp:
(WebCore::RenderTheme::fileListNameForWidth):
- rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::fileListNameForWidth):
- rendering/svg/SVGInlineTextBox.cpp:
(WebCore::SVGInlineTextBox::constructTextRun): Deleted.
- rendering/svg/SVGTextMetrics.cpp:
(WebCore::SVGTextMetrics::constructTextRun): Deleted.
- testing/Internals.cpp:
(WebCore::Internals::resetToConsistentState): Deleted.
(WebCore::Internals::allowRoundingHacks): Deleted.
- testing/Internals.h:
- testing/Internals.idl:
Source/WebKit/ios:
- Misc/WebUIKitSupport.mm:
(WebKitInitialize): Deleted.
Source/WebKit/mac:
- Misc/WebKitNSStringExtras.mm:
(-[NSString _web_drawAtPoint:font:textColor:allowingFontSmoothing:]): Deleted.
(-[NSString _web_widthWithFont:]): Deleted.
- WebView/WebView.mm:
(+[WebView _setAllowsRoundingHacks:]): Deleted.
(+[WebView _allowsRoundingHacks]): Deleted.
- WebView/WebViewPrivate.h:
Tools:
- DumpRenderTree/mac/DumpRenderTree.mm:
(resetWebViewToConsistentStateBeforeTesting): Deleted.
LayoutTests:
- platform/mac/fast/text/rounding-hacks-expansion.html: Removed.
- platform/mac/fast/text/rounding-hacks.html: Removed.
- platform/mac/platform/mac/fast/text/rounding-hacks-expansion-expected.png: Removed.
- platform/mac/platform/mac/fast/text/rounding-hacks-expansion-expected.txt: Removed.
- platform/mac/platform/mac/fast/text/rounding-hacks-expected.png: Removed.
- platform/mac/platform/mac/fast/text/rounding-hacks-expected.txt: Removed.
- svg/text/svg-font-word-rounding-hacks-spaces-expected.html: Removed.
- svg/text/svg-font-word-rounding-hacks-spaces.html: Removed.
- 4:21 PM Changeset in webkit [195179] by
-
- 4 edits in trunk/Source/WebCore
Allocate style sheet media queries in BumpArena.
<https://webkit.org/b/153188>
Reviewed by Antti Koivisto.
Teach the CSS parser to allocate MediaQuery and MediaQueryExp from BumpArena as well.
- css/CSSGrammar.y.in:
- css/MediaQuery.h:
- css/MediaQueryExp.h:
- 4:04 PM Changeset in webkit [195178] by
-
- 8 edits in trunk
[ES6] Arrow function syntax. Arrow function should support the destructuring parameters.
https://bugs.webkit.org/show_bug.cgi?id=146934
Patch by Skachkov Oleksandr <gskachkov@gmail.com> on 2016-01-16
Reviewed by Saam Barati.
Source/JavaScriptCore:
Added support of destructuring parameters, before arrow function expect only simple parameters,
e.g. (), (x), (x, y) or x in assigment expressio. To support destructuring parameters added
additional check that check for destructuring paramters if check does not pass for simple parameters.
- parser/Parser.cpp:
(JSC::Parser<LexerType>::isArrowFunctionParameters):
(JSC::Parser<LexerType>::parseAssignmentExpression):
- parser/Parser.h:
LayoutTests:
- js/arrowfunction-syntax-errors-expected.txt:
- js/arrowfunction-syntax-expected.txt:
- js/script-tests/arrowfunction-syntax-errors.js:
- js/script-tests/arrowfunction-syntax.js:
- 4:00 PM Changeset in webkit [195177] by
-
- 2 edits in trunk/Source/WebCore
[GTK] Add a couple comments to ScrollbarThemeGtk
https://bugs.webkit.org/show_bug.cgi?id=153184
Reviewed by Carlos Garcia Campos.
- platform/gtk/ScrollbarThemeGtk.cpp:
(WebCore::ScrollbarThemeGtk::paint):
- 1:05 PM Changeset in webkit [195176] by
-
- 2 edits in trunk/Websites/webkit.org
Fix some responsive issues on smaller screens.
- wp-content/themes/webkit/style.css:
(.timeline .time):
(@media (max-width: 900px)):
(.timeline:before):
(.timeline > li):
(.timeline > li:before):
(.timeline .content):
(.timeline li .time::before):
- 12:53 PM Changeset in webkit [195175] by
-
- 1 edit2 adds in trunk/LayoutTests
Web Inspector: Add tests for Array Utilities like lowerBound/upperBound
https://bugs.webkit.org/show_bug.cgi?id=153177
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-01-16
Reviewed by Timothy Hatcher.
- inspector/unit-tests/array-utilities-expected.txt: Added.
- inspector/unit-tests/array-utilities.html: Added.
- 12:50 PM Changeset in webkit [195174] by
-
- 4 edits in trunk
.:
[GTK] Use -Wl,-all_load on darwin to include contents of all static archives
https://bugs.webkit.org/show_bug.cgi?id=153117
Patch by Jeremy Huddleston Sequoia <jeremyhu@apple.com> on 2016-01-16
Reviewed by Michael Catanzaro.
- Source/cmake/OptionsGTK.cmake:
Source/WebKit2:
Remove a now-irrelevant darwin build hack
https://bugs.webkit.org/show_bug.cgi?id=153117
Patch by Jeremy Huddleston Sequoia <jeremyhu@apple.com> on 2016-01-16
Reviewed by Michael Catanzaro.
- PlatformGTK.cmake:
- 12:37 PM Changeset in webkit [195173] by
-
- 3 edits in trunk/Source/WebCore
Give RuleSet a BumpArena and start using it for RuleDataVectors.
<https://webkit.org/b/153169>
Reviewed by Antti Koivisto.
Since RuleSet only supports appending rules and doesn't need to worry about removing them,
it's a great candidate for BumpArena optimizations.
Give each RuleSet its own BumpArena and teach them how to allocate RuleDataVector objects
out of them.
There are more things that can be done here, ideally all the sub-allocations inside RuleSet
that happen via e.g Vector and HashMap would also come out of the BumpArena.
- css/RuleSet.cpp:
(WebCore::RuleSet::RuleSet):
(WebCore::RuleSet::addToRuleSet):
(WebCore::RuleSet::copyShadowPseudoElementRulesFrom):
- css/RuleSet.h:
(WebCore::RuleSet::RuleDataVector::create):
(WebCore::RuleSet::RuleSet): Deleted.
- 11:07 AM Changeset in webkit [195172] by
-
- 4 edits in trunk
Source/WebCore:
Fix flakiness of displaylists/layer-dispay-list.html
When toggling "uses display list drawing" on a GraphicsLayerCA, do
a repaint.
- platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::setUsesDisplayListDrawing):
LayoutTests:
This test needs to force layout before calling setElementUsesDisplayListDrawing(),
so that the layer already has its "drawsContents" property updated.
- displaylists/layer-dispay-list.html:
- 11:03 AM Changeset in webkit [195171] by
-
- 3 edits in trunk/Source/WebKit2
[iOS] Replace deprecated -[UIDocumentMenuViewController
_setIgnoreApplicationEntitlementForImport:]
<https://bugs.webkit.org/show_bug.cgi?id=145690>
<rdar://problem/20636577>
Reviewed by Brent Fulgham.
- Platform/spi/ios/UIKitSPI.h:
Replace deprecated SPI with newer SPI.
- UIProcess/ios/forms/WKFileUploadPanel.mm:
(-[WKFileUploadPanel presentWithParameters:resultListener:]):
(-[WKFileUploadPanel _showDocumentPickerMenu]):
Ditto.
- 10:12 AM Changeset in webkit [195170] by
-
- 17 edits in trunk/Source
Remove GraphicsContext::drawConvexPolygon() and GraphicsContext::clipConvexPolygon()
https://bugs.webkit.org/show_bug.cgi?id=153174
Reviewed by Zalan Bujtas.
GraphicsContext::drawConvexPolygon() and GraphicsContext::clipConvexPolygon() were
poorly named (non-convex polygons are allowed), and just syntactic sugar over
clipPath() and drawPath().
Remove them, but add a convenience function to create a Path from a Vector of
points. For CG, we can use the more efficient CGPathAddLines().
Source/WebCore:
Add TextStream dumping for Path.
- platform/graphics/GraphicsContext.h:
- platform/graphics/Path.cpp:
(WebCore::Path::polygonPathFromPoints):
(WebCore::Path::dump):
(WebCore::operator<<):
- platform/graphics/Path.h:
- platform/graphics/cairo/GraphicsContextCairo.cpp:
(WebCore::GraphicsContext::setPlatformShouldAntialias):
(WebCore::addConvexPolygonToContext): Deleted.
(WebCore::GraphicsContext::drawConvexPolygon): Deleted.
(WebCore::GraphicsContext::clipConvexPolygon): Deleted.
- platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::addConvexPolygonToPath): Deleted.
(WebCore::GraphicsContext::drawConvexPolygon): Deleted.
(WebCore::GraphicsContext::clipConvexPolygon): Deleted.
- platform/graphics/cg/PathCG.cpp:
(WebCore::Path::polygonPathFromPoints):
(WebCore::Path::moveTo):
(WebCore::Path::addLineTo):
(WebCore::Path::addQuadCurveTo):
(WebCore::Path::addBezierCurveTo):
(WebCore::Path::addArcTo):
- platform/graphics/displaylists/DisplayListItems.cpp:
(WebCore::DisplayList::Item::sizeInBytes): Deleted.
(WebCore::DisplayList::ClipConvexPolygon::ClipConvexPolygon): Deleted.
(WebCore::DisplayList::ClipConvexPolygon::apply): Deleted.
(WebCore::DisplayList::operator<<): Deleted.
(WebCore::DisplayList::addConvexPolygonToPath): Deleted.
(WebCore::DisplayList::DrawConvexPolygon::DrawConvexPolygon): Deleted.
(WebCore::DisplayList::DrawConvexPolygon::localBounds): Deleted.
(WebCore::DisplayList::DrawConvexPolygon::apply): Deleted.
- platform/graphics/displaylists/DisplayListItems.h:
(WebCore::DisplayList::ClipConvexPolygon::create): Deleted.
(WebCore::DisplayList::ClipConvexPolygon::points): Deleted.
(WebCore::DisplayList::ClipConvexPolygon::antialias): Deleted.
(WebCore::DisplayList::DrawConvexPolygon::create): Deleted.
(WebCore::DisplayList::DrawConvexPolygon::points): Deleted.
(WebCore::DisplayList::DrawConvexPolygon::antialiased): Deleted.
- platform/graphics/displaylists/DisplayListRecorder.cpp:
(WebCore::DisplayList::Recorder::drawConvexPolygon): Deleted.
(WebCore::DisplayList::Recorder::clipConvexPolygon): Deleted.
- platform/graphics/displaylists/DisplayListRecorder.h:
- rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::clipBorderSidePolygon):
- rendering/RenderElement.cpp:
(WebCore::RenderElement::drawLineForBoxSide):
- rendering/RenderThemeIOS.mm:
(WebCore::RenderThemeIOS::paintMenuListButtonDecorations):
- rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::paintMenuListButtonDecorations):
Source/WebKit/win:
- FullscreenVideoController.cpp:
(HUDSlider::draw):
- 8:46 AM Changeset in webkit [195169] by
-
- 2 edits in trunk/Source/WebCore
Add Platform.cpp to ANGLESupport
https://bugs.webkit.org/show_bug.cgi?id=153120
Patch by Jeremy Huddleston Sequoia <jeremyhu@apple.com> on 2016-01-16
Reviewed by Darin Adler.
No new tests, only addresses a build failure.
- CMakeLists.txt:
- 7:15 AM Changeset in webkit [195168] by
-
- 2 edits in trunk/Source/WebKit2
[GTK] Unreviewed. Fix a typo in an API comment.
- UIProcess/API/gtk/WebKitWebViewSessionState.cpp:
- 1:44 AM Changeset in webkit [195167] by
-
- 2 edits in trunk/Source/WebCore
[GTK] List box selections stopped working again with GTK+ from current git master
https://bugs.webkit.org/show_bug.cgi?id=153122
Reviewed by Michael Catanzaro.
The problem is that the ListBox selection implementation is
wrong. We are using a similar implementation to GtkEntry, but
GtkTreeView doesn't have a child CSS node for selections.
- rendering/RenderThemeGtk.cpp:
(WebCore::styleColor): Don't use a child style context for ListBox selections.
(WebCore::createStyleContext): Remove ListBoxSelection.
- 1:36 AM Changeset in webkit [195166] by
-
- 2 edits in trunk/Source/WebKit2
[GTK] GVariant runtime critical errors when encoding session data
https://bugs.webkit.org/show_bug.cgi?id=153130
Reviewed by Michael Catanzaro.
It happens when the FrameState has children, because the recursive
serialization is wrong. Also fix serialization of
documentSequenceNumber and itemSequenceNumber that are gint64, not
guint64.
- UIProcess/API/gtk/WebKitWebViewSessionState.cpp:
(encodeFrameState): Let the caller open/init the given
builder. Use a new builder to encode child states recursively.
(encodePageState): Do the builder open/close for the FrameState encoding.
(decodeFrameState): Get the variant of every child.
- 12:49 AM Changeset in webkit [195165] by
-
- 2 edits in trunk/Source/WebCore
[SOUP] Initialize HTTP version of ResourceResponse
https://bugs.webkit.org/show_bug.cgi?id=153088
Reviewed by Michael Catanzaro.
- platform/network/soup/ResourceResponseSoup.cpp:
(WebCore::ResourceResponse::updateFromSoupMessage):
- 12:25 AM Changeset in webkit [195164] by
-
- 2 edits in trunk/Source/WebCore
Tiny cleanup in FontFaceComparator
https://bugs.webkit.org/show_bug.cgi?id=153044
Reviewed by Zalan Bujtas.
This is a follow-up patch to r194923.
No new tests because there is no behavior change.
- css/CSSFontSelector.cpp:
(WebCore::FontFaceComparator::FontFaceComparator):
(WebCore::FontFaceComparator::operator()):
Jan 15, 2016:
- 7:57 PM Changeset in webkit [195163] by
-
- 2 edits in trunk/Tools
[webkitdirs] Avoid list form of open because it broke WinCairo
https://bugs.webkit.org/show_bug.cgi?id=153106
Patch by Konstantin Tokarev <Konstantin Tokarev> on 2016-01-15
Reviewed by Alex Christensen.
- Scripts/webkitdirs.pm:
(determineArchitecture):
- 6:08 PM Changeset in webkit [195162] by
-
- 4 edits4 adds in trunk
FrameLoaderClient::didReceiveServerRedirectForProvisionalLoadForFrame() is never called when loading a main resource from the memory cache
https://bugs.webkit.org/show_bug.cgi?id=152520
<rdar://problem/23305737>
Reviewed by Andy Estes.
Source/WebCore:
Test: http/tests/loading/server-redirect-for-provisional-load-caching.html
- loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::responseReceived):
Dispatch message to notify client that a cached resource was redirected. So,
client can make proper actions to treat server side redirection.
- loader/cache/CachedRawResource.h:
Add a method to tell whether the cached resource was redirected.
LayoutTests:
- http/tests/loading/resources/server-redirect-result.html: Added.
- http/tests/loading/resources/server-redirect.php: Added.
- http/tests/loading/server-redirect-for-provisional-load-caching-expected.txt: Added.
- http/tests/loading/server-redirect-for-provisional-load-caching.html: Added.
- 5:55 PM Changeset in webkit [195161] by
-
- 2 edits in trunk/LayoutTests
Content blocking console messages are not deterministic for one test
https://bugs.webkit.org/show_bug.cgi?id=153051
Unreviewed.
Console messages will print the line number of whichever JavaScript line is
being parsed. However, font requests (and therefore content blockers) are
not run in response to script. The solution is to add the webfont style
from script, so the line number is deterministic.
- http/tests/contentextensions/font-display-none-repeated-layout.html:
- 5:03 PM Changeset in webkit [195160] by
-
- 7 edits2 deletes in trunk
Drop obsolete HTMLDocument.width / height attributes
https://bugs.webkit.org/show_bug.cgi?id=153144
Reviewed by Ryosuke Niwa.
LayoutTests/imported/w3c:
Rebaseline W3C test now that more checks are passing.
- web-platform-tests/dom/historical-expected.txt:
Source/WebCore:
Drop obsolete HTMLDocument.width / height attributes as these are
obsolete and already not supported by other major browsers (tested
Firefox and Chrome).
No new tests, already covered by existing tests.
- html/HTMLDocument.idl:
LayoutTests:
- fast/dom/HTMLDocument/width-and-height-expected.txt: Removed.
- fast/dom/HTMLDocument/width-and-height.html: Removed.
Drop outdated test.
- fast/dom/Window/window-property-invalid-characters-ignored-expected.txt:
- fast/dom/Window/window-property-invalid-characters-ignored.html:
Stop relying on Document.width / height as these are obsolete.
- 4:37 PM Changeset in webkit [195159] by
-
- 5 edits2 adds in trunk/Source/JavaScriptCore
[JSC] Legalize Memory Offsets for ARM64 before lowering to Air
https://bugs.webkit.org/show_bug.cgi?id=153065
Patch by Benjamin Poulain <bpoulain@apple.com> on 2016-01-15
Reviewed by Mark Lam.
Reviewed by Filip Pizlo.
On ARM64, we cannot use signed 32bits offset for memory addressing.
There are two available addressing: signed 9bits and unsigned scaled 12bits.
Air already knows about it.
In this patch, the offsets are changed to something valid for ARM64
prior to lowering. When an offset is invalid, it is just computed
before the instruction and used as the base for addressing.
- JavaScriptCore.xcodeproj/project.pbxproj:
- b3/B3Generate.cpp:
(JSC::B3::generateToAir):
- b3/B3LegalizeMemoryOffsets.cpp: Added.
(JSC::B3::legalizeMemoryOffsets):
- b3/B3LegalizeMemoryOffsets.h: Added.
- b3/B3LowerToAir.cpp:
(JSC::B3::Air::LowerToAir::effectiveAddr): Deleted.
- b3/testb3.cpp:
(JSC::B3::testLoadWithOffsetImpl):
(JSC::B3::testLoadOffsetImm9Max):
(JSC::B3::testLoadOffsetImm9MaxPlusOne):
(JSC::B3::testLoadOffsetImm9MaxPlusTwo):
(JSC::B3::testLoadOffsetImm9Min):
(JSC::B3::testLoadOffsetImm9MinMinusOne):
(JSC::B3::testLoadOffsetScaledUnsignedImm12Max):
(JSC::B3::testLoadOffsetScaledUnsignedOverImm12Max):
(JSC::B3::run):
- 4:16 PM Changeset in webkit [195158] by
-
- 1 edit2 adds in trunk/LayoutTests
Add a test for touch events in scaled documents
https://bugs.webkit.org/show_bug.cgi?id=153149
-and corresponding-
rdar://problem/24181371
Reviewed by Simon Fraser.
- fast/events/touch/ios/touch-event-in-scaled-document-expected.txt: Added.
- fast/events/touch/ios/touch-event-in-scaled-document.html: Added.
- 4:08 PM Changeset in webkit [195157] by
-
- 5 edits in trunk
Drop obsolete DocumentType.entities / notations
https://bugs.webkit.org/show_bug.cgi?id=153147
Reviewed by Ryosuke Niwa.
LayoutTests/imported/w3c:
Rebaseline W3C test now that more checks are passing.
- web-platform-tests/dom/historical-expected.txt:
Source/WebCore:
Drop obsolete DocumentType.entities / notations attributes.
Firefox and Chrome already dropped those. We already dropped support for
entities and notations so these always returned null.
No new tests, already covered by existing tests.
- dom/DocumentType.h:
- dom/DocumentType.idl:
- 3:57 PM Changeset in webkit [195156] by
-
- 15 edits3 adds in trunk
Make a way to test display-list drawing
https://bugs.webkit.org/show_bug.cgi?id=152956
Reviewed by Ryosuke Niwa.
Source/WebCore:
Make it possible to toggle display-list drawing for a given compositing
layer via internals, as well as getting a textual representation of the display
list, optionally including items with platform-specific behavior.
Add one test that uses this.
Test: displaylists/layer-dispay-list.html
- platform/graphics/GraphicsLayer.h:
(WebCore::GraphicsLayer::displayListAsText):
- platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::displayListAsText):
- platform/graphics/ca/GraphicsLayerCA.h:
- platform/graphics/displaylists/DisplayList.cpp:
(WebCore::DisplayList::DisplayList::shouldDumpForFlags):
(WebCore::DisplayList::DisplayList::asText):
- platform/graphics/displaylists/DisplayList.h:
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::setUsesDisplayListDrawing):
(WebCore::RenderLayerBacking::displayListAsText):
- rendering/RenderLayerBacking.h:
- testing/Internals.cpp:
(WebCore::Internals::setElementUsesDisplayListDrawing):
(WebCore::Internals::displayListForElement):
- testing/Internals.h:
- testing/Internals.idl:
LayoutTests:
Enable displaylists tests on Mac and iOS.
- TestExpectations:
- displaylists/layer-dispay-list-expected.txt: Added.
- displaylists/layer-dispay-list.html: Added.
- platform/ios-simulator/TestExpectations:
- platform/mac/TestExpectations:
- 3:42 PM Changeset in webkit [195155] by
-
- 16 edits in trunk/Source
Fix internal Windows build
https://bugs.webkit.org/show_bug.cgi?id=153142
Source/JavaScriptCore:
Reviewed by Brent Fulgham.
The internal Windows build builds JavaScriptCore from a directory that is not called JavaScriptCore.
Searching for JavaScriptCore/API/APICast.h fails because it is in SomethingElse/API/APICast.h.
Since we are including the JavaScriptCore directory, it is not necessary to have JavaScriptCore in
the forwarding headers, but removing it allows builds form directories that are not named JavaScriptCore.
- ForwardingHeaders/JavaScriptCore/APICast.h:
- ForwardingHeaders/JavaScriptCore/JSBase.h:
- ForwardingHeaders/JavaScriptCore/JSCTestRunnerUtils.h:
- ForwardingHeaders/JavaScriptCore/JSContextRef.h:
- ForwardingHeaders/JavaScriptCore/JSObjectRef.h:
- ForwardingHeaders/JavaScriptCore/JSRetainPtr.h:
- ForwardingHeaders/JavaScriptCore/JSStringRef.h:
- ForwardingHeaders/JavaScriptCore/JSStringRefCF.h:
- ForwardingHeaders/JavaScriptCore/JSValueRef.h:
- ForwardingHeaders/JavaScriptCore/JavaScript.h:
- ForwardingHeaders/JavaScriptCore/JavaScriptCore.h:
- ForwardingHeaders/JavaScriptCore/OpaqueJSString.h:
- ForwardingHeaders/JavaScriptCore/WebKitAvailability.h:
Source/WebKit2:
Unreviewed addition to Alex's JSC patch, which was reviewed by Brent Fulgham. Pass
-I${JAVASCRIPTCORE_DIR} to g-ir-scanner.
Patch by Michael Catanzaro <Michael Catanzaro> on 2016-01-15
- PlatformGTK.cmake:
- 3:34 PM Changeset in webkit [195154] by
-
- 5 edits in trunk/Source/WebCore
Fix audio build with video disabled
https://bugs.webkit.org/show_bug.cgi?id=153134
Patch by Olivier Blin <Olivier Blin> on 2016-01-15
Reviewed by Michael Catanzaro.
Build fails when WebAudio is enabled but VIDEO disabled.
No new tests since this is a build fix only.
- platform/audio/PlatformMediaSession.cpp:
- platform/audio/PlatformMediaSession.h:
- platform/audio/PlatformMediaSessionManager.cpp:
- testing/Internals.cpp:
(WebCore::Internals::setAudioContextRestrictions):
- 3:22 PM Changeset in webkit [195153] by
-
- 2 edits in trunk/Source/WebCore
[GTK] Fix build of RenderThemeGtk without VIDEO by including HTMLInputElement
https://bugs.webkit.org/show_bug.cgi?id=153133
Patch by Olivier Blin <Olivier Blin> on 2016-01-15
Reviewed by Michael Catanzaro.
Build was fine with VIDEO enabled, since HTMLInputElement.h was
included by transitivity through MediaControlElements.h and
MediaControlElementTypes.h.
This seems to be broken since r194847.
No new tests since this is just a build fix.
- rendering/RenderThemeGtk.cpp:
- 3:06 PM Changeset in webkit [195152] by
-
- 5 edits2 adds in trunk
createElementNS and createAttributeNS should treat undefined namespaceURI as null string
https://bugs.webkit.org/show_bug.cgi?id=153119
Reviewed by Chris Dumez.
LayoutTests/imported/w3c:
Rebaseline a test now that more test cases are passing.
- web-platform-tests/dom/nodes/Document-createElementNS-expected.txt:
Source/WebCore:
Treat undefined as null in document.createElementNS and document.createAttributeNS as defined in:
https://dom.spec.whatwg.org/#document
Test: fast/dom/Document/createAttributeNS-undefined-namespace.html
- dom/Document.idl:
LayoutTests:
Add a regression test for calling createAttributeNS with undefined namespaceURI.
- fast/dom/Document/createAttributeNS-undefined-namespace-expected.txt: Added.
- fast/dom/Document/createAttributeNS-undefined-namespace.html: Added.
- 3:03 PM Changeset in webkit [195151] by
-
- 10 edits in trunk/LayoutTests
Refine http/tests/contentdispositionattachmentsandbox/referer-header-stripped-with-meta-referer*
https://bugs.webkit.org/show_bug.cgi?id=153140
Reviewed by Alexey Proskuryakov.
- http/tests/contentdispositionattachmentsandbox/referer-header-stripped-with-meta-referer-always.html:
- http/tests/contentdispositionattachmentsandbox/referer-header-stripped-with-meta-referer-default.html:
- http/tests/contentdispositionattachmentsandbox/referer-header-stripped-with-meta-referer-never.html:
- http/tests/contentdispositionattachmentsandbox/referer-header-stripped-with-meta-referer-no-referrer-when-downgrade.html:
- http/tests/contentdispositionattachmentsandbox/referer-header-stripped-with-meta-referer-no-referrer.html:
- http/tests/contentdispositionattachmentsandbox/referer-header-stripped-with-meta-referer-origin.html:
- http/tests/contentdispositionattachmentsandbox/referer-header-stripped-with-meta-referer-unsafe-url.html:
- http/tests/contentdispositionattachmentsandbox/referer-header-stripped.html:
- http/tests/contentdispositionattachmentsandbox/resources/referer-header-stripped.js:
(onload):
(navigation): Deleted.
The reason why the tests are not completed after calling testRunner.notifyDone() is that the original navigation()
is bound as the onload of the iframe which will dispatch two load events. Therefore, navigation() will be called
twice. Here, change the navigation() to be bound with the main frame's onload function, which will restrict it to
be called only once.
- 2:58 PM Changeset in webkit [195150] by
-
- 3 edits2 adds in trunk
[Cocoa] Font features are not applied to the system font
https://bugs.webkit.org/show_bug.cgi?id=153053
Reviewed by Dean Jackson.
Source/WebCore:
We simply need to call preparePlatformFont() on it.
Test: fast/text/system-font-features.html
- platform/graphics/cocoa/FontCacheCoreText.cpp:
(WebCore::fontWithFamily):
LayoutTests:
- fast/text/system-font-features-expected.html: Added.
- fast/text/system-font-features.html: Added.
- 2:29 PM Changeset in webkit [195149] by
-
- 6 edits in trunk/Source
Data detector yellow highlight location is vertically mirrored in WebKit1
https://bugs.webkit.org/show_bug.cgi?id=152216
<rdar://problem/23848003>
Reviewed by Beth Dakin.
No new tests, because we currently have no decent mechanism for testing
where TextIndicator/Lookup/DataDetectors actually make it to the screen,
nor for synthetic force-click in WebKit1.
- editing/mac/DictionaryLookup.h:
- editing/mac/DictionaryLookup.mm:
(WebCore::showPopupOrCreateAnimationController):
(WebCore::DictionaryLookup::showPopup):
(WebCore::DictionaryLookup::animationControllerForPopup):
Add an optional function for converting between root-FrameView and
handed-in-NSView coordinates, and use it to convert textBoundingRectInRootViewCoordinates
into the coordinates of the WebView.
- WebView/WebImmediateActionController.mm:
(-[WebImmediateActionController _animationControllerForDataDetectedText]):
(-[WebImmediateActionController _animationControllerForDataDetectedLink]):
These assignments have no effect because they're operating on a copy, because
TextIndicator::data() does not return a reference... so remove them.
- WebView/WebView.mm:
(-[WebView _setTextIndicator:withLifetime:]):
Convert textBoundingRectInRootViewCoordinates to WebView coordinates before
converting to Window coordinates from WebView coordinates so we get flipping right.
(-[WebView _animationControllerForDictionaryLookupPopupInfo:]):
(-[WebView _showDictionaryLookupPopup:]):
Ditto for these, except in the aforementioned conversion callback.
- 2:28 PM Changeset in webkit [195148] by
-
- 4 edits2 adds2 deletes in trunk
Media Query (-webkit-video-playable-inline) is failing as an invalid media query expression
https://bugs.webkit.org/show_bug.cgi?id=153111
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-01-15
Reviewed by Dean Jackson.
Source/WebCore:
Test: fast/media/video-playable-inline-media-query.html
- css/MediaQueryEvaluator.cpp:
(WebCore::video_playable_inlineMediaFeatureEval):
(WebCore::isRunningOnIPhoneOrIPod): Deleted.
Make the media query work regardless of the platform.
It should just check the web view's settings.
- css/MediaQueryExp.cpp:
(WebCore::featureWithoutValue):
This media query expects no value, include it in the list
so it is not treated as invalid.
LayoutTests:
- fast/media/video-playable-inline-media-query-expected.txt: Added.
- fast/media/video-playable-inline-media-query.html: Added.
- platform/ios-simulator/ios/fast/media/video-inline-expected.txt: Removed.
- platform/ios-simulator/ios/fast/media/video-inline.html: Removed.
- 2:21 PM Changeset in webkit [195147] by
-
- 5 edits4 adds in trunk/LayoutTests
LayoutTest inspector/script-profiler/event-type-Other.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=153016
<rdar://problem/24192919>
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-01-15
Reviewed by Brian Burg.
Introduce a better way for the inspected page to signal to
the inspector page by dispatching an event with JSON data.
Use it in this test to try to eliminate flakyness.
- http/tests/inspector/resources/inspector-test.js:
(TestPage.dispatchEventToFrontend):
- http/tests/inspector/resources/protocol-test.js:
(TestPage.runTest.window.runTest):
(TestPage.dispatchEventToFrontend):
- inspector/script-profiler/event-type-Other.html:
- inspector/unit-tests/inspector-test-dispatch-event-to-frontend-expected.txt: Added.
- inspector/unit-tests/inspector-test-dispatch-event-to-frontend.html: Added.
- inspector/unit-tests/protocol-test-dispatch-event-to-frontend-expected.txt: Added.
- inspector/unit-tests/protocol-test-dispatch-event-to-frontend.html: Added.
- platform/mac/TestExpectations:
- 1:49 PM Changeset in webkit [195146] by
-
- 3 edits2 adds in trunk
ASSERTION FAILED: canHaveChildren() canHaveGeneratedChildren() in WebCore::RenderElement::insertChildInternal https://bugs.webkit.org/show_bug.cgi?id=123331
Reviewed by Darin Adler.
Do not set named flow fragment bit on the flow until after the renderer is attached. Setting/resetting it too early
could affect the attach/detach process itself (This is similar to attaching a multi column flow thread).
Source/WebCore:
Test: fast/regions/input-box-with-region-assert.html
- rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::willBeDestroyed):
(WebCore::RenderBlockFlow::createRenderNamedFlowFragmentIfNeeded):
(WebCore::RenderBlockFlow::setRenderNamedFlowFragment):
LayoutTests:
- fast/regions/input-box-with-region-assert-expected.txt: Added.
- fast/regions/input-box-with-region-assert.html: Added.
- 1:43 PM Changeset in webkit [195145] by
-
- 5 edits in trunk/Source/JavaScriptCore
[B3][Win64] Compile fixes.
https://bugs.webkit.org/show_bug.cgi?id=153127
Reviewed by Alex Christensen.
MSVC have several overloads of fmod, pow, and ceil. We need to suggest to MSVC
which one we want to use.
- b3/B3LowerMacros.cpp:
- b3/B3LowerMacrosAfterOptimizations.cpp:
- b3/B3MathExtras.cpp:
(JSC::B3::powDoubleInt32):
- b3/B3ReduceStrength.cpp:
- 1:18 PM Changeset in webkit [195144] by
-
- 5 edits in trunk/LayoutTests
Web Inspector: Fix some typos in unit tests
https://bugs.webkit.org/show_bug.cgi?id=153141
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-01-15
Reviewed by Brian Burg.
- inspector/unit-tests/async-test-suite-expected.txt:
- inspector/unit-tests/async-test-suite.html:
- inspector/unit-tests/sync-test-suite-expected.txt:
- inspector/unit-tests/sync-test-suite.html:
Fix some typos.
- 1:11 PM Changeset in webkit [195143] by
-
- 2 edits in trunk/LayoutTests
Rebaseline tables/mozilla_expected_failures/bugs/bug89315.html for ios-simulator
https://bugs.webkit.org/show_bug.cgi?id=152130
Unreviewed test gardening.
- platform/ios-simulator/tables/mozilla_expected_failures/bugs/bug89315-expected.txt:
- 12:57 PM Changeset in webkit [195142] by
-
- 9 edits3 adds in trunk
Add kdebug_trace signposts for a few WebCore operations
https://bugs.webkit.org/show_bug.cgi?id=153136
rdar://problem/24208487
Reviewed by Sam Weinig.
Source/WebCore:
Add trace points for style recalc, layout, view painting and layer painting.
- dom/Document.cpp:
(WebCore::Document::recalcStyle):
- page/FrameView.cpp:
(WebCore::FrameView::layout):
(WebCore::FrameView::paintContents):
- platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::platformCALayerPaintContents):
Source/WTF:
New header with the reserved WebKit component code, trace point codes, and
a stack-based helper that traces scope entry and exit.
The available range of trace point codes is arbitrarily segmented into WTF, JSC,
WebCore, WebKit and WebKit2.
- WTF.xcodeproj/project.pbxproj:
- wtf/CMakeLists.txt:
- wtf/SystemTracing.h: Added.
(WTF::TraceScope::TraceScope):
(WTF::TraceScope::~TraceScope):
Tools:
Plist used by kdebug_trace() viewing tools.
- Tracing/SystemTracePoints.plist: Added.
- 12:01 PM Changeset in webkit [195141] by
-
- 23 edits2 adds in trunk/Source
Source/WebCore:
Use BumpArena for style sheet object tree.
<https://webkit.org/b/152696>
Reviewed by Antti Koivisto.
Give each StyleSheetContents its own BumpArena, and plumb it down through CSSParser
to allocate StyleRule, StyleProperties and CSSSelectorList's selector arrays there.
This basically means that most objects that make up a given style sheet will end up
in one (or a few) contiguous region(s) of memory, instead of being scattered all
over the malloc heap.
In the common case (no CSSOM manipulation), the lifetimes of these objects are very
predictable: everything tends to die when the StyleSheetContents dies.
This dramatically improves space-efficiency in those cases, and allows us to return
contiguous chunks of memory to the system once a style sheet is no longer needed.
One-off CSS parses that don't work within a StyleSheetContents context will have
their StyleRules & co allocated through FastMalloc just like before.
Bonus: give SelectorQueryCache a dedicated BumpArena as well, since it has very
predictable lifetime.
- css/CSSGrammar.y.in:
- css/CSSKeyframesRule.h:
(WebCore::StyleRuleKeyframes::create):
- css/CSSParser.cpp:
(WebCore::CSSParser::createStyleProperties):
(WebCore::CSSParser::createMediaRule):
(WebCore::CSSParser::createSupportsRule):
(WebCore::CSSParser::createKeyframesRule):
(WebCore::CSSParser::setArena):
(WebCore::CSSParser::arena):
(WebCore::CSSParser::createStyleRule):
(WebCore::CSSParser::createFontFaceRule):
(WebCore::CSSParser::createPageRule):
(WebCore::CSSParser::createRegionRule):
(WebCore::CSSParser::createViewportRule):
- css/CSSParser.h:
- css/CSSParserValues.cpp:
(WebCore::CSSParserSelector::parsePseudoElementCueFunctionSelector):
(WebCore::CSSParserSelector::adoptSelectorVector):
- css/CSSParserValues.h:
- css/CSSSelectorList.cpp:
(WebCore::CSSSelectorList::CSSSelectorList):
(WebCore::CSSSelectorList::adoptSelectorVector):
(WebCore::CSSSelectorList::deleteSelectors):
- css/CSSSelectorList.h:
- css/StyleProperties.cpp:
(WebCore::ImmutableStyleProperties::create):
(WebCore::StyleProperties::immutableCopyIfNeeded):
- css/StyleProperties.h:
- css/StyleRule.cpp:
(WebCore::StyleRule::create):
(WebCore::StyleRule::splitIntoMultipleRulesWithMaximumSelectorComponentCount):
(WebCore::StyleRuleRegion::StyleRuleRegion):
- css/StyleRule.h:
(WebCore::StyleRule::create):
(WebCore::StyleRule::parserAdoptSelectorVector):
(WebCore::StyleRuleFontFace::create):
(WebCore::StyleRulePage::create):
(WebCore::StyleRulePage::parserAdoptSelectorVector):
(WebCore::StyleRuleMedia::create):
(WebCore::StyleRuleSupports::create):
(WebCore::StyleRuleRegion::create):
(WebCore::StyleRuleViewport::create):
- css/StyleSheetContents.cpp:
(WebCore::StyleSheetContents::StyleSheetContents):
(WebCore::StyleSheetContents::parseAuthorStyleSheet):
(WebCore::StyleSheetContents::parseStringAtPosition):
- css/StyleSheetContents.h:
- dom/SelectorQuery.cpp:
(WebCore::SelectorQueryCache::SelectorQueryCache):
(WebCore::SelectorQueryCache::add):
- dom/SelectorQuery.h:
- svg/SVGFontFaceElement.cpp:
(WebCore::SVGFontFaceElement::SVGFontFaceElement):
Source/WTF:
Fragmentation-free allocator for timeless and/or coupled allocations.
<https://webkit.org/b/152696>
Reviewed by Antti Koivisto.
Introduce BumpArena, a space-efficient memory allocator for situations where
you feel pretty confident betting on allocation lifetimes.
Basic design:
- Reserves 128MB range of memory at startup.
- Allocates 4kB-aligned blocks of 4kB from VM at a time.
- Bump-pointer allocates out of a block until it reaches end.
- Each allocation increments the ref-count of its block.
- Each deallocation decrements the ref-count of its block.
- Transparently falls back to fastMalloc()/fastFree() when needed.
Interface:
- BumpArena::create()
Create your very own BumpArena!
- BumpArena::allocate(BumpArena* arena, size_t size)
Allocates 'size' bytes of memory from 'arena'.
If 'arena' is null, falls back to fastMalloc().
- BumpArena::deallocate(void* ptr)
If 'ptr' is BumpArena allocation, decrements block ref-count.
If 'ptr' is FastMalloc allocation, calls fastFree() on it.
- WTF_MAKE_BUMPARENA_ALLOCATED;
Macro that gives a class or struct custom operators new and delete
for allocation out of BumpArena. Just like WTF_MAKE_FAST_ALLOCATED;
Note that while the name of this patch says "fragmentation-free allocator"
it will only be fragmentation-free when used for appropriate things.
This is not meant to be a general-purpose allocator. Only use it for sets of
allocations that are known to die roughly at the same time.
BumpArena will never resume allocating from a block that has been filled,
so it's even more important than usual that everything gets deallocated.
BumpArena redirects allocations to FastMalloc in three cases:
- When invoked with a null BumpArena*
- When allocation request is larger than BumpArena's block size (4kB)
- When BumpArena has exhausted all of its pre-reserved VM. (128MB)
The VM allocator will eagerly return blocks of VM to the kernel by calling
madvise(). Average time spent in madvise is around 0.007ms on my box.
- WTF.vcxproj/WTF.vcxproj:
- WTF.vcxproj/WTF.vcxproj.filters:
- WTF.xcodeproj/project.pbxproj:
- wtf/BumpArena.cpp: Added.
(WTF::BumpArena::Block::capacity):
(WTF::BumpArena::Block::arena):
(WTF::BumpArena::Block::payloadStart):
(WTF::arenas):
(WTF::BumpArena::Block::Block):
(WTF::BumpArena::Block::~Block):
(WTF::BumpArena::Block::ref):
(WTF::BlockAllocator::BlockAllocator):
(WTF::BlockAllocator::isAllocation):
(WTF::blockAllocator):
(WTF::BlockAllocator::allocateBlock):
(WTF::BlockAllocator::deallocateBlock):
(WTF::BumpArena::Block::deref):
(WTF::BumpArena::Block::create):
(WTF::BumpArena::Block::dump):
(WTF::BumpArena::dump):
(WTF::BumpArena::create):
(WTF::BumpArena::BumpArena):
(WTF::BumpArena::~BumpArena):
(WTF::BumpArena::allocateSlow):
(WTF::BumpArena::allocate):
(WTF::BumpArena::deallocate):
(WTF::BumpArena::Block::blockFor):
(WTF::BumpArena::arenaFor):
- wtf/BumpArena.h: Added.
- wtf/CMakeLists.txt:
- 11:55 AM Changeset in webkit [195140] by
-
- 2 edits in trunk/Websites/webkit.org
Eliminate the margin on timeline elements so multiple timelines can touch.
- wp-content/themes/webkit/style.css:
(.timeline):
- 11:41 AM Changeset in webkit [195139] by
-
- 30 edits10 adds in trunk/Source/JavaScriptCore
Air needs a Shuffle instruction
https://bugs.webkit.org/show_bug.cgi?id=152952
Reviewed by Saam Barati.
This adds an instruction called Shuffle. Shuffle allows you to simultaneously perform
multiple moves to perform arbitrary permutations over registers and memory. We call these
rotations. It also allows you to perform "shifts", like (a => b, b => c): after the shift,
c will have b's old value, b will have a's old value, and a will be unchanged. Shifts can
use immediates as their source.
Shuffle is added as a custom instruction, since it has a variable number of arguments. It
takes any number of triplets of arguments, where each triplet describes one mapping of the
shuffle. For example, to represent (a => b, b => c), we might say:
Shuffle %a, %b, 64, %b, %c, 64
Note the "64"s, those are width arguments that describe how many bits of the register are
being moved. Each triplet is referred to as a "shuffle pair". We call it a pair because the
most relevant part of it is the pair of registers or memroy locations (i.e. %a, %b form one
of the pairs in the example). For GP arguments, the width follows ZDef semantics.
In the future, we will be able to use Shuffle for a lot of things. This patch is modest about
how to use it:
- C calling convention argument marshalling. Previously we used move instructions. But that's problematic since it introduces artificial interference between the argument registers and the inputs. Using Shuffle removes that interference. This helps a bit.
- Cold C calls. This is what really motivated me to write this patch. If we have a C call on a cold path, then we want it to appear to the register allocator like it doesn't clobber any registers. Only after register allocation should we handle the clobbering by simply saving all of the live volatile registers to the stack. If you imagine the saving and the argument marshalling, you can see how before the call, we want to have a Shuffle that does both of those things. This is important. If argument marshalling was separate from the saving, then we'd still appear to clobber argument registers. Doing them together as one Shuffle means that the cold call doesn't appear to even clobber the argument registers.
Unfortunately, I was wrong about cold C calls being the dominant problem with our register
allocator right now. Fixing this revealed other problems in my current tuning benchmark,
Octane/encrypt. Nonetheless, this is a small speed-up across the board, and gives us some
functionality we will need to implement other optimizations.
Relanding after fixing production build.
- CMakeLists.txt:
- JavaScriptCore.xcodeproj/project.pbxproj:
- assembler/AbstractMacroAssembler.h:
(JSC::isX86_64):
(JSC::isIOS):
(JSC::optimizeForARMv7IDIVSupported):
- assembler/MacroAssemblerX86Common.h:
(JSC::MacroAssemblerX86Common::zeroExtend32ToPtr):
(JSC::MacroAssemblerX86Common::swap32):
(JSC::MacroAssemblerX86Common::moveConditionally32):
- assembler/MacroAssemblerX86_64.h:
(JSC::MacroAssemblerX86_64::store64WithAddressOffsetPatch):
(JSC::MacroAssemblerX86_64::swap64):
(JSC::MacroAssemblerX86_64::move64ToDouble):
- assembler/X86Assembler.h:
(JSC::X86Assembler::xchgl_rr):
(JSC::X86Assembler::xchgl_rm):
(JSC::X86Assembler::xchgq_rr):
(JSC::X86Assembler::xchgq_rm):
(JSC::X86Assembler::movl_rr):
- b3/B3CCallValue.h:
- b3/B3Compilation.cpp:
(JSC::B3::Compilation::Compilation):
(JSC::B3::Compilation::~Compilation):
- b3/B3Compilation.h:
(JSC::B3::Compilation::code):
- b3/B3LowerToAir.cpp:
(JSC::B3::Air::LowerToAir::run):
(JSC::B3::Air::LowerToAir::createSelect):
(JSC::B3::Air::LowerToAir::lower):
(JSC::B3::Air::LowerToAir::marshallCCallArgument): Deleted.
- b3/B3OpaqueByproducts.h:
(JSC::B3::OpaqueByproducts::count):
- b3/B3StackmapSpecial.cpp:
(JSC::B3::StackmapSpecial::isArgValidForValue):
(JSC::B3::StackmapSpecial::isArgValidForRep):
- b3/air/AirArg.cpp:
(JSC::B3::Air::Arg::isStackMemory):
(JSC::B3::Air::Arg::isRepresentableAs):
(JSC::B3::Air::Arg::usesTmp):
(JSC::B3::Air::Arg::canRepresent):
(JSC::B3::Air::Arg::isCompatibleType):
(JSC::B3::Air::Arg::dump):
(WTF::printInternal):
- b3/air/AirArg.h:
(JSC::B3::Air::Arg::forEachType):
(JSC::B3::Air::Arg::isWarmUse):
(JSC::B3::Air::Arg::cooled):
(JSC::B3::Air::Arg::isEarlyUse):
(JSC::B3::Air::Arg::imm64):
(JSC::B3::Air::Arg::immPtr):
(JSC::B3::Air::Arg::addr):
(JSC::B3::Air::Arg::special):
(JSC::B3::Air::Arg::widthArg):
(JSC::B3::Air::Arg::operator==):
(JSC::B3::Air::Arg::isImm64):
(JSC::B3::Air::Arg::isSomeImm):
(JSC::B3::Air::Arg::isAddr):
(JSC::B3::Air::Arg::isIndex):
(JSC::B3::Air::Arg::isMemory):
(JSC::B3::Air::Arg::isRelCond):
(JSC::B3::Air::Arg::isSpecial):
(JSC::B3::Air::Arg::isWidthArg):
(JSC::B3::Air::Arg::isAlive):
(JSC::B3::Air::Arg::base):
(JSC::B3::Air::Arg::hasOffset):
(JSC::B3::Air::Arg::offset):
(JSC::B3::Air::Arg::width):
(JSC::B3::Air::Arg::isGPTmp):
(JSC::B3::Air::Arg::isGP):
(JSC::B3::Air::Arg::isFP):
(JSC::B3::Air::Arg::isType):
(JSC::B3::Air::Arg::isGPR):
(JSC::B3::Air::Arg::isValidForm):
(JSC::B3::Air::Arg::forEachTmpFast):
- b3/air/AirBasicBlock.h:
(JSC::B3::Air::BasicBlock::insts):
(JSC::B3::Air::BasicBlock::appendInst):
(JSC::B3::Air::BasicBlock::append):
- b3/air/AirCCallingConvention.cpp: Added.
(JSC::B3::Air::computeCCallingConvention):
(JSC::B3::Air::cCallResult):
(JSC::B3::Air::buildCCall):
- b3/air/AirCCallingConvention.h: Added.
- b3/air/AirCode.h:
(JSC::B3::Air::Code::proc):
- b3/air/AirCustom.cpp: Added.
(JSC::B3::Air::CCallCustom::isValidForm):
(JSC::B3::Air::CCallCustom::generate):
(JSC::B3::Air::ShuffleCustom::isValidForm):
(JSC::B3::Air::ShuffleCustom::generate):
- b3/air/AirCustom.h:
(JSC::B3::Air::PatchCustom::forEachArg):
(JSC::B3::Air::PatchCustom::generate):
(JSC::B3::Air::CCallCustom::forEachArg):
(JSC::B3::Air::CCallCustom::isValidFormStatic):
(JSC::B3::Air::CCallCustom::admitsStack):
(JSC::B3::Air::CCallCustom::hasNonArgNonControlEffects):
(JSC::B3::Air::ColdCCallCustom::forEachArg):
(JSC::B3::Air::ShuffleCustom::forEachArg):
(JSC::B3::Air::ShuffleCustom::isValidFormStatic):
(JSC::B3::Air::ShuffleCustom::admitsStack):
(JSC::B3::Air::ShuffleCustom::hasNonArgNonControlEffects):
- b3/air/AirEmitShuffle.cpp: Added.
(JSC::B3::Air::ShufflePair::dump):
(JSC::B3::Air::emitShuffle):
- b3/air/AirEmitShuffle.h: Added.
(JSC::B3::Air::ShufflePair::ShufflePair):
(JSC::B3::Air::ShufflePair::src):
(JSC::B3::Air::ShufflePair::dst):
(JSC::B3::Air::ShufflePair::width):
- b3/air/AirGenerate.cpp:
(JSC::B3::Air::prepareForGeneration):
- b3/air/AirGenerate.h:
- b3/air/AirInsertionSet.cpp:
(JSC::B3::Air::InsertionSet::insertInsts):
(JSC::B3::Air::InsertionSet::execute):
- b3/air/AirInsertionSet.h:
(JSC::B3::Air::InsertionSet::insertInst):
(JSC::B3::Air::InsertionSet::insert):
- b3/air/AirInst.h:
(JSC::B3::Air::Inst::operator bool):
(JSC::B3::Air::Inst::append):
- b3/air/AirLowerAfterRegAlloc.cpp: Added.
(JSC::B3::Air::lowerAfterRegAlloc):
- b3/air/AirLowerAfterRegAlloc.h: Added.
- b3/air/AirLowerMacros.cpp: Added.
(JSC::B3::Air::lowerMacros):
- b3/air/AirLowerMacros.h: Added.
- b3/air/AirOpcode.opcodes:
- b3/air/AirRegisterPriority.h:
(JSC::B3::Air::regsInPriorityOrder):
- b3/air/testair.cpp: Added.
(hiddenTruthBecauseNoReturnIsStupid):
(usage):
(JSC::B3::Air::compile):
(JSC::B3::Air::invoke):
(JSC::B3::Air::compileAndRun):
(JSC::B3::Air::testSimple):
(JSC::B3::Air::loadConstantImpl):
(JSC::B3::Air::loadConstant):
(JSC::B3::Air::loadDoubleConstant):
(JSC::B3::Air::testShuffleSimpleSwap):
(JSC::B3::Air::testShuffleSimpleShift):
(JSC::B3::Air::testShuffleLongShift):
(JSC::B3::Air::testShuffleLongShiftBackwards):
(JSC::B3::Air::testShuffleSimpleRotate):
(JSC::B3::Air::testShuffleSimpleBroadcast):
(JSC::B3::Air::testShuffleBroadcastAllRegs):
(JSC::B3::Air::testShuffleTreeShift):
(JSC::B3::Air::testShuffleTreeShiftBackward):
(JSC::B3::Air::testShuffleTreeShiftOtherBackward):
(JSC::B3::Air::testShuffleMultipleShifts):
(JSC::B3::Air::testShuffleRotateWithFringe):
(JSC::B3::Air::testShuffleRotateWithLongFringe):
(JSC::B3::Air::testShuffleMultipleRotates):
(JSC::B3::Air::testShuffleShiftAndRotate):
(JSC::B3::Air::testShuffleShiftAllRegs):
(JSC::B3::Air::testShuffleRotateAllRegs):
(JSC::B3::Air::testShuffleSimpleSwap64):
(JSC::B3::Air::testShuffleSimpleShift64):
(JSC::B3::Air::testShuffleSwapMixedWidth):
(JSC::B3::Air::testShuffleShiftMixedWidth):
(JSC::B3::Air::testShuffleShiftMemory):
(JSC::B3::Air::testShuffleShiftMemoryLong):
(JSC::B3::Air::testShuffleShiftMemoryAllRegs):
(JSC::B3::Air::testShuffleShiftMemoryAllRegs64):
(JSC::B3::Air::combineHiLo):
(JSC::B3::Air::testShuffleShiftMemoryAllRegsMixedWidth):
(JSC::B3::Air::testShuffleRotateMemory):
(JSC::B3::Air::testShuffleRotateMemory64):
(JSC::B3::Air::testShuffleRotateMemoryMixedWidth):
(JSC::B3::Air::testShuffleRotateMemoryAllRegs64):
(JSC::B3::Air::testShuffleRotateMemoryAllRegsMixedWidth):
(JSC::B3::Air::testShuffleSwapDouble):
(JSC::B3::Air::testShuffleShiftDouble):
(JSC::B3::Air::run):
(run):
(main):
- b3/testb3.cpp:
(JSC::B3::testCallSimple):
(JSC::B3::testCallRare):
(JSC::B3::testCallRareLive):
(JSC::B3::testCallSimplePure):
(JSC::B3::run):
- 11:30 AM Changeset in webkit [195138] by
-
- 12 edits4 adds in trunk
[INTL] Implement Date.prototype.toLocaleString in ECMA-402
https://bugs.webkit.org/show_bug.cgi?id=147611
Patch by Andy VanWagoner <thetalecrafter@gmail.com> on 2016-01-15
Reviewed by Benjamin Poulain.
Source/JavaScriptCore:
Expose dateProtoFuncGetTime as thisTimeValue for builtins.
Remove unused code in DateTimeFormat toDateTimeOptions, and make the
function specific to the call in initializeDateTimeFormat. Properly
throw when the options parameter is null.
Add toLocaleString in builtin JavaScript, with it's own specific branch
of toDateTimeOptions.
- CMakeLists.txt:
- DerivedSources.make:
- JavaScriptCore.xcodeproj/project.pbxproj:
- builtins/DatePrototype.js: Added.
(toLocaleString.toDateTimeOptionsAnyAll):
(toLocaleString):
- runtime/CommonIdentifiers.h:
- runtime/DatePrototype.cpp:
(JSC::DatePrototype::finishCreation):
- runtime/DatePrototype.h:
- runtime/IntlDateTimeFormat.cpp:
(JSC::toDateTimeOptionsAnyDate):
(JSC::IntlDateTimeFormat::initializeDateTimeFormat):
(JSC::toDateTimeOptions): Deleted.
- runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::init):
LayoutTests:
- js/intl-datetimeformat-expected.txt: Added test for null options.
- js/date-toLocaleString-expected.txt: Added.
- js/date-toLocaleString.html: Added.
- js/script-tests/intl-datetimeformat.js: Added test for null options.
- js/script-tests/date-toLocaleString.js: Added.
- 10:59 AM Changeset in webkit [195137] by
-
- 2 edits in branches/safari-601.1.46-branch/LayoutTests
Merged r195130. rdar://problem/24154420
- 10:57 AM Changeset in webkit [195136] by
-
- 2 edits in branches/safari-601-branch/LayoutTests
Merged r195130. rdar://problem/24154290
- 10:56 AM Changeset in webkit [195135] by
-
- 5 edits in branches/safari-601-branch/Source
Versioning.
- 10:53 AM Changeset in webkit [195134] by
-
- 3 edits in trunk/Source/JavaScriptCore
[mips] Implemented emitFunctionPrologue/Epilogue
https://bugs.webkit.org/show_bug.cgi?id=152947
Patch by Konstantin Tokarev <Konstantin Tokarev> on 2016-01-15
Reviewed by Michael Saboff.
- assembler/MacroAssemblerMIPS.h:
(JSC::MacroAssemblerMIPS::popPair):
(JSC::MacroAssemblerMIPS::pushPair):
- jit/AssemblyHelpers.h:
(JSC::AssemblyHelpers::emitFunctionPrologue):
(JSC::AssemblyHelpers::emitFunctionEpilogueWithEmptyFrame):
(JSC::AssemblyHelpers::emitFunctionEpilogue):
- 9:07 AM Changeset in webkit [195133] by
-
- 30 edits10 deletes in trunk/Source/JavaScriptCore
Unreviewed, rolling out r195084.
https://bugs.webkit.org/show_bug.cgi?id=153132
Broke Production build (Requested by ap on #webkit).
Reverted changeset:
"Air needs a Shuffle instruction"
https://bugs.webkit.org/show_bug.cgi?id=152952
http://trac.webkit.org/changeset/195084
- 9:06 AM Changeset in webkit [195132] by
-
- 6 edits in trunk/Source/WebCore
Avoid downloading the wrong image for <picture> elements.
https://bugs.webkit.org/show_bug.cgi?id=153027
Reviewed by Dean Jackson.
No tests, since they are always flaky.
- html/HTMLImageElement.cpp:
(WebCore::HTMLImageElement::HTMLImageElement):
(WebCore::HTMLImageElement::~HTMLImageElement):
(WebCore::HTMLImageElement::createForJSConstructor):
(WebCore::HTMLImageElement::bestFitSourceFromPictureElement):
(WebCore::HTMLImageElement::insertedInto):
(WebCore::HTMLImageElement::removedFrom):
(WebCore::HTMLImageElement::pictureElement):
(WebCore::HTMLImageElement::setPictureElement):
(WebCore::HTMLImageElement::width):
- html/HTMLImageElement.h:
(WebCore::HTMLImageElement::hasShadowControls):
- html/HTMLPictureElement.h:
- html/parser/HTMLConstructionSite.cpp:
(WebCore::HTMLConstructionSite::createHTMLElement):
- html/parser/HTMLPreloadScanner.cpp:
(WebCore::TokenPreloadScanner::StartTagScanner::processAttribute):
Images that are built underneath a <picture> element are now connected
to that picture element via a setPictureNode call from the parser. This
ensures that the correct <source> elements are examined before checking the image.
This connection between images and their picture owners is handled using a static
HashMap in HTMLImageElement. This connection is made both from the parser and from
DOM insertions, and the map is queried now instead of looking directly at the
image's parentNode().
- 5:41 AM Changeset in webkit [195131] by
-
- 3 edits29 adds in releases/WebKitGTK/webkit-2.10
Merge r194143 - Fix computation of min|max-content contribution of non-replaced blocks
https://bugs.webkit.org/show_bug.cgi?id=152004
Reviewed by Darin Adler.
Source/WebCore:
WebKit currently always returns the min preferred logical
width for the min-content contribution (and the max preferred
logical width for the max-content contribution) for
non-replaced blocks. That is not correct according to specs
https://drafts.csswg.org/css-sizing/#block-intrinsic.
The min-content and max-content contributions actually depend
on the computed inline size of the block:
- for min-content,max-content or definite sizes: min-content
and max-content contributions are the inline size plus border,
margin and padding.
- otherwise: min-content contribution is the min-content size
and max-content contribution is the max-content size (in both
cases plus border, padding and margin).
Tests: fast/css-intrinsic-dimensions/auto-maxcontent-inlinesize-contribution-nonreplaced-blocks.html
fast/css-intrinsic-dimensions/auto-mincontent-inlinesize-contribution-nonreplaced-blocks.html
fast/css-intrinsic-dimensions/fillavailable-maxcontent-inlinesize-contribution-nonreplaced-blocks.html
fast/css-intrinsic-dimensions/fillavailable-mincontent-inlinesize-contribution-nonreplaced-blocks.html
fast/css-intrinsic-dimensions/fitcontent-maxcontent-inlinesize-contribution-nonreplaced-blocks.html
fast/css-intrinsic-dimensions/fitcontent-mincontent-inlinesize-contribution-nonreplaced-blocks.html
fast/css-intrinsic-dimensions/fixed-inlinesize-contribution-nonreplaced-blocks-1.html
fast/css-intrinsic-dimensions/fixed-inlinesize-contribution-nonreplaced-blocks-2.html
fast/css-intrinsic-dimensions/indefinite-percent-maxcontent-inlinesize-contribution-nonreplaced-blocks.html
fast/css-intrinsic-dimensions/indefinite-percent-mincontent-inlinesize-contribution-nonreplaced-blocks.html
fast/css-intrinsic-dimensions/maxcontent-maxcontent-inlinesize-contribution-nonreplaced-blocks.html
fast/css-intrinsic-dimensions/maxcontent-mincontent-inlinesize-contribution-nonreplaced-blocks.html
fast/css-intrinsic-dimensions/mincontent-maxcontent-inlinesize-contribution-nonreplaced-blocks.html
fast/css-intrinsic-dimensions/mincontent-mincontent-inlinesize-contribution-nonreplaced-blocks.html
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::computeBlockPreferredLogicalWidths):
LayoutTests:
- fast/css-intrinsic-dimensions/auto-maxcontent-inlinesize-contribution-nonreplaced-blocks-expected.html: Added.
- fast/css-intrinsic-dimensions/auto-maxcontent-inlinesize-contribution-nonreplaced-blocks.html: Added.
- fast/css-intrinsic-dimensions/auto-mincontent-inlinesize-contribution-nonreplaced-blocks-expected.html: Added.
- fast/css-intrinsic-dimensions/auto-mincontent-inlinesize-contribution-nonreplaced-blocks.html: Added.
- fast/css-intrinsic-dimensions/fillavailable-maxcontent-inlinesize-contribution-nonreplaced-blocks-expected.html: Added.
- fast/css-intrinsic-dimensions/fillavailable-maxcontent-inlinesize-contribution-nonreplaced-blocks.html: Added.
- fast/css-intrinsic-dimensions/fillavailable-mincontent-inlinesize-contribution-nonreplaced-blocks-expected.html: Added.
- fast/css-intrinsic-dimensions/fillavailable-mincontent-inlinesize-contribution-nonreplaced-blocks.html: Added.
- fast/css-intrinsic-dimensions/fitcontent-maxcontent-inlinesize-contribution-nonreplaced-blocks-expected.html: Added.
- fast/css-intrinsic-dimensions/fitcontent-maxcontent-inlinesize-contribution-nonreplaced-blocks.html: Added.
- fast/css-intrinsic-dimensions/fitcontent-mincontent-inlinesize-contribution-nonreplaced-blocks-expected.html: Added.
- fast/css-intrinsic-dimensions/fitcontent-mincontent-inlinesize-contribution-nonreplaced-blocks.html: Added.
- fast/css-intrinsic-dimensions/fixed-inlinesize-contribution-nonreplaced-blocks-1-expected.html: Added.
- fast/css-intrinsic-dimensions/fixed-inlinesize-contribution-nonreplaced-blocks-1.html: Added.
- fast/css-intrinsic-dimensions/fixed-inlinesize-contribution-nonreplaced-blocks-2-expected.html: Added.
- fast/css-intrinsic-dimensions/fixed-inlinesize-contribution-nonreplaced-blocks-2.html: Added.
- fast/css-intrinsic-dimensions/indefinite-percent-maxcontent-inlinesize-contribution-nonreplaced-blocks-expected.html: Added.
- fast/css-intrinsic-dimensions/indefinite-percent-maxcontent-inlinesize-contribution-nonreplaced-blocks.html: Added.
- fast/css-intrinsic-dimensions/indefinite-percent-mincontent-inlinesize-contribution-nonreplaced-blocks-expected.html: Added.
- fast/css-intrinsic-dimensions/indefinite-percent-mincontent-inlinesize-contribution-nonreplaced-blocks.html: Added.
- fast/css-intrinsic-dimensions/maxcontent-maxcontent-inlinesize-contribution-nonreplaced-blocks-expected.html: Added.
- fast/css-intrinsic-dimensions/maxcontent-maxcontent-inlinesize-contribution-nonreplaced-blocks.html: Added.
- fast/css-intrinsic-dimensions/maxcontent-mincontent-inlinesize-contribution-nonreplaced-blocks-expected.html: Added.
- fast/css-intrinsic-dimensions/maxcontent-mincontent-inlinesize-contribution-nonreplaced-blocks.html: Added.
- fast/css-intrinsic-dimensions/mincontent-maxcontent-inlinesize-contribution-nonreplaced-blocks-expected.html: Added.
- fast/css-intrinsic-dimensions/mincontent-maxcontent-inlinesize-contribution-nonreplaced-blocks.html: Added.
- fast/css-intrinsic-dimensions/mincontent-mincontent-inlinesize-contribution-nonreplaced-blocks-expected.html: Added.
- fast/css-intrinsic-dimensions/mincontent-mincontent-inlinesize-contribution-nonreplaced-blocks.html: Added.
- fast/css-intrinsic-dimensions/resources/intrinsic-size-contribution.css: Added.
(.container):
(.item):
(.border):
(.padding):
(.margin):
- 5:23 AM Changeset in webkit [195130] by
-
- 2 edits in trunk/LayoutTests
Switch out from ES6 arrow function syntax to allow the test to work with an older WebKit.
- fast/loader/cache-encoding.html:
- 5:16 AM Changeset in webkit [195129] by
-
- 4 edits in releases/WebKitGTK/webkit-2.10/Source/WTF
Merge r194037 - REGRESSION (r162777): Remove Boost Software License from WTF
<http://webkit.org/b/152243>
Reviewed by Darin Adler.
The source code that the Boost Software License was referring to
was removed in r162777 by switching to std::atomic.
- wtf/Atomics.cpp:
- wtf/Atomics.h:
- wtf/ThreadSafeRefCounted.h:
- Remove Boost Software License.
- Update Apple Inc. copyright as needed.
- Refresh Apple Inc. license text.
- 5:14 AM Changeset in webkit [195128] by
-
- 4 edits2 adds in releases/WebKitGTK/webkit-2.10
Merge r194016 - Clean up absolute positioned map properly.
https://bugs.webkit.org/show_bug.cgi?id=152219
rdar://problem/23861165
Reviewed by Simon Fraser.
We insert positioned renderers into a static map (RenderBlock::gPositionedDescendantsMap) to keep track of them.
Since this static map is at block level, (positioned)inline renderers use their containing block to store
their positioned descendants.
This patch ensures that when an inline element can no longer hold positioned children, we remove them from
the inline's containing block's map. -unless the container itself can hold positioned renderers(see RenderElement::canContainAbsolutelyPositionedObjects).
Source/WebCore:
Test: fast/block/positioning/crash-when-positioned-inline-has-positioned-child.html
- rendering/RenderInline.cpp:
(WebCore::RenderInline::styleWillChange):
- rendering/RenderInline.h:
LayoutTests:
- fast/block/positioning/crash-when-positioned-inline-has-positioned-child-expected.txt: Added.
- fast/block/positioning/crash-when-positioned-inline-has-positioned-child.html: Added.
- 5:11 AM Changeset in webkit [195127] by
-
- 3 edits2 adds in releases/WebKitGTK/webkit-2.10
Merge r194002 - ASSERTION FAILED: !rect.isEmpty() in WebCore::GraphicsContext::drawRect
https://bugs.webkit.org/show_bug.cgi?id=151201
Reviewed by Simon Fraser.
Drawing empty rect is a waste.
Source/WebCore:
Test: fast/borders/empty-drawrect-assert-after-pixelsnap.html
- rendering/RenderElement.cpp:
(WebCore::RenderElement::drawLineForBoxSide):
LayoutTests:
- fast/borders/empty-drawrect-assert-after-pixelsnap-expected.txt: Added.
- fast/borders/empty-drawrect-assert-after-pixelsnap.html: Added.
- 5:10 AM Changeset in webkit [195126] by
-
- 3 edits4 adds in releases/WebKitGTK/webkit-2.10
Merge r194001 - Strip out Referer header when requesting subresources or following links for documents with "Content-Disposition: attachment"
https://bugs.webkit.org/show_bug.cgi?id=152102
<rdar://problem/22124230>
Reviewed by Andy Estes.
Source/WebCore:
Keep the ReferrerPolicy for a document as ReferrerPolicyNever if the document is loaded with
"Content-Disposition: attachment".
Test: http/tests/contentdispositionattachmentsandbox/subresource-request-not-include-referer-header.html
- dom/Document.cpp:
(WebCore::Document::processReferrerPolicy):
(WebCore::Document::applyContentDispositionAttachmentSandbox):
LayoutTests:
- http/tests/contentdispositionattachmentsandbox/resources/echo-http-referer.php: Added.
- http/tests/contentdispositionattachmentsandbox/resources/subresource-request-not-include-referer-header-frame.php: Added.
- http/tests/contentdispositionattachmentsandbox/subresource-request-not-include-referer-header-expected.txt: Added.
- http/tests/contentdispositionattachmentsandbox/subresource-request-not-include-referer-header.html: Added.
- 4:42 AM Changeset in webkit [195125] by
-
- 6 edits1 copy4 adds in releases/WebKitGTK/webkit-2.10
Merge r193939 - [CSP] eval() is not blocked for stringified literals
https://bugs.webkit.org/show_bug.cgi?id=152158
<rdar://problem/15775625>
Reviewed by Saam Barati.
Source/JavaScriptCore:
Fixes an issue where stringified literals can be eval()ed despite being disallowed by
Content Security Policy of the page.
- interpreter/Interpreter.cpp:
(JSC::eval): Throw a JavaScript EvalError exception if eval() is disallowed for the page
and return undefined.
- runtime/JSGlobalObjectFunctions.cpp:
(JSC::globalFuncEval): Ditto.
LayoutTests:
Update test LayoutTests/http/tests/security/contentSecurityPolicy/eval-blocked.html to be
more comprehensive.
Add tests to ensure that we block eval() from within an external JavaScript script when the
policy of the page disallows eval() and that we block eval() inside a subframe that disallows
eval() when the page in the main frame allows eval().
- http/tests/security/contentSecurityPolicy/eval-blocked-expected.txt:
- http/tests/security/contentSecurityPolicy/eval-blocked-in-external-script-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/eval-blocked-in-external-script.html: Added.
- http/tests/security/contentSecurityPolicy/eval-blocked-in-subframe-expected.txt: Copied from LayoutTests/http/tests/security/contentSecurityPolicy/eval-blocked-expected.txt.
- http/tests/security/contentSecurityPolicy/eval-blocked-in-subframe.html: Added.
- http/tests/security/contentSecurityPolicy/eval-blocked.html:
- http/tests/security/contentSecurityPolicy/resources/eval-blocked-in-external-script.js: Added.
- 4:38 AM Changeset in webkit [195124] by
-
- 3 edits in releases/WebKitGTK/webkit-2.10/Source/WebCore
Merge r194955 - [GTK] Fix return value of some paint methods in RenderThemeGtk
https://bugs.webkit.org/show_bug.cgi?id=153015
Reviewed by Michael Catanzaro.
The bool value returned by paint methods in RenderTheme means
whether the appearance is supported or not, so we should return
true when not supported (so we didn't paint anything) and false
when supported (so we actually painted the theme part).
- rendering/RenderThemeGtk.cpp:
(WebCore::RenderThemeGtk::paintSearchFieldResultsDecorationPart):
(WebCore::RenderThemeGtk::paintSearchFieldCancelButton):
(WebCore::RenderThemeGtk::paintMediaButton):
(WebCore::RenderThemeGtk::paintMediaMuteButton):
(WebCore::RenderThemeGtk::paintMediaPlayButton):
(WebCore::RenderThemeGtk::paintMediaSliderTrack):
(WebCore::RenderThemeGtk::paintMediaVolumeSliderContainer): Deleted.
- rendering/RenderThemeGtk.h:
- 4:38 AM Changeset in webkit [195123] by
-
- 3 edits in releases/WebKitGTK/webkit-2.10/Source/WebCore
Merge r194847 - [GTK] Cleanup RenderThemeGtk
https://bugs.webkit.org/show_bug.cgi?id=152888
Reviewed by Michael Catanzaro.
Use a common path for GTK+ 3.19 and previous versions, simplifying
the code and removing a lot of ifdefs.
- createStyleContext() now receives a theme part enum value, and an optional parent GtkStyleContext. It encapsulates all the differences between GTK+ 3.19 and previous version leaving the rendering code common and free of ifdefs.
- Stock icons support have been removed, simplifying the code that now always renders symbolic icons, updating the colors depending on the current state.
- Media button and colors have been removed, because they are unused now that we render the media controls with CSS.
- ComboBox separators support has also been removed. In GTK+ 3.19 combo boxes no longer have separators and most of the GTK+ themes don't use the either, so it's better to simple not render them anymore in WebKit either.
- Code to paint caps lock indicator has been removed too, since caps lock indicator is now shadow dom and automatically rendered by WebCore.
- rendering/RenderThemeGtk.cpp:
(WebCore::createStyleContext):
(WebCore::loadThemedIcon):
(WebCore::gtkIconStateFlags):
(WebCore::RenderThemeGtk::adjustRepaintRect):
(WebCore::setToggleSize):
(WebCore::paintToggle):
(WebCore::RenderThemeGtk::setCheckboxSize):
(WebCore::RenderThemeGtk::paintCheckbox):
(WebCore::RenderThemeGtk::setRadioSize):
(WebCore::RenderThemeGtk::paintRadio):
(WebCore::RenderThemeGtk::paintButton):
(WebCore::getComboBoxMetrics):
(WebCore::RenderThemeGtk::popupInternalPaddingLeft):
(WebCore::RenderThemeGtk::popupInternalPaddingRight):
(WebCore::RenderThemeGtk::popupInternalPaddingTop):
(WebCore::RenderThemeGtk::popupInternalPaddingBottom):
(WebCore::RenderThemeGtk::paintMenuList):
(WebCore::RenderThemeGtk::paintTextField):
(WebCore::adjustSearchFieldIconStyle):
(WebCore::RenderThemeGtk::adjustSearchFieldResultsDecorationPartStyle):
(WebCore::paintIcon):
(WebCore::paintEntryIcon):
(WebCore::RenderThemeGtk::paintSearchFieldResultsDecorationPart):
(WebCore::RenderThemeGtk::adjustSearchFieldCancelButtonStyle):
(WebCore::RenderThemeGtk::paintSearchFieldCancelButton):
(WebCore::RenderThemeGtk::shouldHaveCapsLockIndicator):
(WebCore::RenderThemeGtk::paintSliderTrack):
(WebCore::RenderThemeGtk::paintSliderThumb):
(WebCore::RenderThemeGtk::adjustSliderThumbSize):
(WebCore::RenderThemeGtk::paintProgressBar):
(WebCore::RenderThemeGtk::adjustInnerSpinButtonStyle):
(WebCore::paintSpinArrowButton):
(WebCore::RenderThemeGtk::paintInnerSpinButton):
(WebCore::styleColor):
(WebCore::RenderThemeGtk::platformActiveSelectionBackgroundColor):
(WebCore::RenderThemeGtk::platformInactiveSelectionBackgroundColor):
(WebCore::RenderThemeGtk::platformActiveSelectionForegroundColor):
(WebCore::RenderThemeGtk::platformInactiveSelectionForegroundColor):
(WebCore::RenderThemeGtk::platformActiveListBoxSelectionBackgroundColor):
(WebCore::RenderThemeGtk::platformInactiveListBoxSelectionBackgroundColor):
(WebCore::RenderThemeGtk::platformActiveListBoxSelectionForegroundColor):
(WebCore::RenderThemeGtk::platformInactiveListBoxSelectionForegroundColor):
(WebCore::RenderThemeGtk::systemColor):
(WebCore::RenderThemeGtk::paintMediaButton):
(WebCore::RenderThemeGtk::paintMediaFullscreenButton):
(WebCore::RenderThemeGtk::paintMediaMuteButton):
(WebCore::RenderThemeGtk::paintMediaPlayButton):
(WebCore::RenderThemeGtk::paintMediaSeekBackButton):
(WebCore::RenderThemeGtk::paintMediaSeekForwardButton):
(WebCore::RenderThemeGtk::paintMediaToggleClosedCaptionsButton):
- rendering/RenderThemeGtk.h:
- 4:37 AM Changeset in webkit [195122] by
-
- 3 edits in releases/WebKitGTK/webkit-2.10/Source/WebCore
Merge r194844 - [GTK] Cleanup ScrollbarThemeGtk
https://bugs.webkit.org/show_bug.cgi?id=152830
Reviewed by Michael Catanzaro.
Use a common path for GTK+ 3.19 and previous versions, simplifying
the code and removing a lot of ifdefs. Use always a new
GtkStyleContext, but when painting cache the newly created one so
all paint methods use that one. We were also caching some theme
properties assuming they don't change unless the theme changes,
but some of them can have different values depending on the state,
for example, when hovered or pressed. Those properties are now
only cached when we create a new GtkStyleContext.
The method updateScrollbarsFrameThickness() has also been removed,
since the Scrollbar constructor already initializes the frame rect
using the scrollbarThickness(). This method was not doing anything
anyway, since that was called on the constructor of the theme,
when there were no scrollbars registered. This also means we no
longer need to track registered/unregistered scrollbars.
- platform/gtk/ScrollbarThemeGtk.cpp:
(WebCore::ScrollbarThemeGtk::backButtonRect): Use the cached
GtkStyleContext and properties or create a new.
(WebCore::ScrollbarThemeGtk::forwardButtonRect): Ditto.
(WebCore::ScrollbarThemeGtk::trackRect): Ditto.
(WebCore::orientationStyleClass):
(WebCore::ScrollbarThemeGtk::getOrCreateStyleContext): Create a
new GtkStyleContext for the scrollbar if there isn't a cached
one. Also initialize the properties that depend on the state.
(WebCore::createChildStyleContext): Create a new GtkStyleContext
from a parent one.
(WebCore::ScrollbarThemeGtk::updateThemeProperties): Get the
properties that can only change when the theme changes.
(WebCore::ScrollbarThemeGtk::thumbRect): Use the cached
GtkStyleContext and properties or create a new.
(WebCore::adjustRectAccordingToMargin): Use always the
GtkStyleContext state instead of receiving it and setting it again.
(WebCore::ScrollbarThemeGtk::paintTrackBackground): Get or create
a GtkStyleContext for the scrollbar and create a child one for the trough.
(WebCore::ScrollbarThemeGtk::paintScrollbarBackground): Use the
cached GtkStyleContext or create a new one.
(WebCore::ScrollbarThemeGtk::paintThumb): Get or create a
GtkStyleContext for the scrollbar and create a child ones for
trough and slider.
(WebCore::ScrollbarThemeGtk::paintButton): Get or create a
GtkStyleContext for the scrollbar and create a child one for the button.
(WebCore::ScrollbarThemeGtk::paint): Create a GtkStyleContext and
cache it temporarily using TemporaryChange until the method finishes.
(WebCore::ScrollbarThemeGtk::scrollbarThickness): Use the cached
GtkStyleContext and properties or create a new.
(WebCore::ScrollbarThemeGtk::buttonSize): Ditto.
- platform/gtk/ScrollbarThemeGtk.h:
- 4:37 AM Changeset in webkit [195121] by
-
- 8 edits2 adds in releases/WebKitGTK/webkit-2.10
Merge r194817 - Absolute positioning -webkit-search-cancel-button crashes Safari.
https://bugs.webkit.org/show_bug.cgi?id=152847
<rdar://problem/24112087>
Reviewed by Simon Fraser.
Do not call offsetFromContainer while resolving the painting position for the search/cancel button renderer.
It skips the static positioned parent input renderer, when the search/cancel renderer is absolute positioned.
This patch also fixes a rendering glitch when the margin-right is > 0.
Source/WebCore:
Test: fast/forms/absolute-positioned-custom-search-cancel-crash.html
- rendering/RenderTheme.h:
(WebCore::RenderTheme::paintSearchFieldCancelButton):
(WebCore::RenderTheme::paintSearchFieldResultsDecorationPart):
(WebCore::RenderTheme::paintSearchFieldResultsButton):
- rendering/RenderThemeMac.h:
- rendering/RenderThemeMac.mm:
(WebCore::convertToPaintingPosition):
(WebCore::RenderThemeMac::paintSearchFieldCancelButton):
(WebCore::RenderThemeMac::paintSearchFieldResultsDecorationPart):
(WebCore::RenderThemeMac::paintSearchFieldResultsButton):
(WebCore::RenderThemeMac::convertToPaintingRect): Deleted.
LayoutTests:
- fast/forms/absolute-positioned-custom-search-cancel-crash-expected.txt: Added.
- fast/forms/absolute-positioned-custom-search-cancel-crash.html: Added.
- 4:37 AM Changeset in webkit [195120] by
-
- 5 edits in releases/WebKitGTK/webkit-2.10/Source/WebCore
Merge r194377 - [GTK] Everything broken in GTK+ 3.19
https://bugs.webkit.org/show_bug.cgi?id=150550
Reviewed by Carlos Garcia Campos.
Port RenderThemeGtk and ScrollbarThemeGtk to use CSS nodes. This makes it possible to render
stuff with modern GTK+.
No new tests. We already have tons of tests for this functionality, but we're running them
with GTK+ 3.16, so they cannot have detected this breakage. These fixes require unreleased
GTK+, and GTK+ rendering is currently in a state of flux; once things settle down, we can
consider upgrading the GTK+ used for our layout tests.
- platform/gtk/GRefPtrGtk.cpp:
(WTF::refGPtr):
(WTF::derefGPtr):
- platform/gtk/GRefPtrGtk.h:
- platform/gtk/ScrollbarThemeGtk.cpp:
(WebCore::ScrollbarThemeGtk::themeChanged):
(WebCore::ScrollbarThemeGtk::updateThemeProperties):
(WebCore::orientationStyleClass):
(WebCore::applyScrollbarStyleContextClasses):
(WebCore::ScrollbarThemeGtk::paintTrackBackground):
(WebCore::ScrollbarThemeGtk::paintScrollbarBackground):
(WebCore::ScrollbarThemeGtk::paintThumb):
(WebCore::ScrollbarThemeGtk::paintButton):
- rendering/RenderThemeGtk.cpp:
(WebCore::createStyleContext):
(WebCore::setToggleSize):
(WebCore::paintToggle):
(WebCore::RenderThemeGtk::paintButton):
(WebCore::getComboBoxMetrics):
(WebCore::RenderThemeGtk::paintMenuList):
(WebCore::RenderThemeGtk::paintTextField):
(WebCore::applySliderStyleContextClasses):
(WebCore::RenderThemeGtk::paintSliderTrack):
(WebCore::RenderThemeGtk::paintSliderThumb):
(WebCore::RenderThemeGtk::paintProgressBar):
(WebCore::paintSpinArrowButton):
(WebCore::styleColor):
- 4:36 AM Changeset in webkit [195119] by
-
- 2 edits in releases/WebKitGTK/webkit-2.10/Source/WebCore
Merge r193896 - [GTK] RenderThemeGtk::platformActiveSelectionBackgroundColor, et. al. should not clobber state of cached GtkStyleContexts
https://bugs.webkit.org/show_bug.cgi?id=151533
Reviewed by Carlos Garcia Campos.
Remove the style context cache to simplify the code, drastically reduce the number of
expensive save/restore operations performed on style contexts, and avoid unwanted
side-effects in RenderThemeGtk::styleColor. This is also a speculative fix for improper
button rendering with certain custom themes, and a simplification that will make it easier
to fix bug #150550.
This change does have performance implications, which I intend to check on the perf bot
after landing to ensure that removing the cache does not have a significant negative impact
on performance; I have no clue whether this will be a net performance win or loss. However,
this is a bit tricky, because the bot is running GTK+ 3.16, whereas I expect save/restore
might be much more expensive in GTK+ 3.20, and I do not want to make performance decisions
except based on the latest GTK+ due to large changes in the implementation of
GtkStyleContext.
- rendering/RenderThemeGtk.cpp:
(WebCore::createStyleContext):
(WebCore::getStockIconForWidgetType):
(WebCore::getStockSymbolicIconForWidgetType):
(WebCore::RenderThemeGtk::initMediaColors):
(WebCore::RenderThemeGtk::adjustRepaintRect):
(WebCore::setToggleSize):
(WebCore::paintToggle):
(WebCore::RenderThemeGtk::setCheckboxSize):
(WebCore::RenderThemeGtk::setRadioSize):
(WebCore::RenderThemeGtk::paintButton):
(WebCore::getComboBoxMetrics):
(WebCore::RenderThemeGtk::paintMenuList):
(WebCore::RenderThemeGtk::paintTextField):
(WebCore::RenderThemeGtk::paintSliderTrack):
(WebCore::RenderThemeGtk::paintSliderThumb):
(WebCore::RenderThemeGtk::adjustSliderThumbSize):
(WebCore::RenderThemeGtk::paintProgressBar):
(WebCore::RenderThemeGtk::adjustInnerSpinButtonStyle):
(WebCore::RenderThemeGtk::paintInnerSpinButton):
(WebCore::styleColor):
(WebCore::gtkStyleChangedCallback): Deleted.
(WebCore::styleContextMap): Deleted.
(WebCore::getStyleContext): Deleted.
- 3:34 AM Changeset in webkit [195118] by
-
- 6 edits4 adds in releases/WebKitGTK/webkit-2.10
Merge r193841 - AX: [GTK] Anonymous render block flow elements should be exposed as ATK_ROLE_SECTION; not ATK_ROLE_PANEL
https://bugs.webkit.org/show_bug.cgi?id=152070
Reviewed by Mario Sanchez Prada.
Source/WebCore:
Map the element to WebCore AccessibilityRole DivRole for GTK. This is being
done in the shared layer rather than in the platform layer because we want all
subsequent logic to treat anonymous render block flow elements as divs.
No new tests. We already have sufficient test coverage. The expectations
been updated accordingly.
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::determineAccessibilityRole):
LayoutTests:
- platform/gtk/accessibility/deleting-iframe-destroys-axcache-expected.txt: Added.
- platform/gtk/accessibility/gtk/media-controls-panel-title-expected.txt: Added.
- platform/gtk/accessibility/gtk/replaced-objects-in-anonymous-blocks-expected.txt: Added.
- platform/gtk/accessibility/image-link-expected.txt: Updated
- platform/gtk/accessibility/image-with-alt-and-map-expected.txt: Updated.
- platform/gtk/accessibility/lists-expected.txt: Updated.
- platform/gtk/accessibility/media-emits-object-replacement-expected.txt: Updated.
- 3:32 AM Changeset in webkit [195117] by
-
- 8 edits in releases/WebKitGTK/webkit-2.10
Merge r193840 - form.elements should reflect the element ordering after the HTML tree builder algorithm
https://bugs.webkit.org/show_bug.cgi?id=148870
rdar://problem/22589879
Patch by Keith Rollin <Keith Rollin> on 2015-12-09
Reviewed by Ryosuke Niwa.
LayoutTests/imported/w3c:
Rebaseline existing test.
- web-platform-tests/html/semantics/forms/the-form-element/form-elements-nameditem-02-expected.txt:
Source/WebCore:
form.elements should return form-associated elements in tree order.
However, when presented with an HTML fragment like the following,
forms.elements is not built in tree order. Instead, the elements
appear in forms.element in the same order they appear in the HTML --
that is in the same order as they are parsed.
<form id=form>
<table>
<tr>
<td><input type="radio" name="radio1" id="r1" value=1></td>
<td><input type="radio" name="radio2" id="r2" value=2></td>
<input type="radio" name="radio0" id="r0" value=0>
</tr>
</table>
</form>
The reason why elements appear in forms.elements in parse order is
because they register themselves with the designated form when they
are created. At this time, they are not in the DOM tree, so the form
can only assume that the element will be appended to the DOM tree,
with the result that it records the elements in the HTML fragment
above as [r1, r2, r0].
However, it's not always the case that the newly-created element will
be appended to the current tree. In the HTML fragment above, the r0
input element is hoised out of the table element. It ends up being the
preceding sibling of the table element, with the result that the
actual tree-order of the input elements is [r0, r1, r2].
Because the problem is due to registering form-associated elements
with the form *before* the elements are added to the DOM tree, the
solution is to defer that registration until afterwards. With the new
element in the tree, the form can now use its current location in the
tree to correctly place the element in form.elements.
Existing tests now pass:
- imported/w3c/web-platform-tests/html/semantics/forms/the-form-element/form-elements-nameditem-02-html
- html/FormAssociatedElement.cpp:
(WebCore::FormAssociatedElement::FormAssociatedElement):
(WebCore::FormAssociatedElement::insertedInto):
(WebCore::FormAssociatedElement::removedFrom):
(WebCore::FormAssociatedElement::formRemovedFromTree):
(WebCore::FormAssociatedElement::formWillBeDestroyed):
- html/FormAssociatedElement.h:
- html/HTMLFormControlElement.cpp:
(WebCore::HTMLFormControlElement::HTMLFormControlElement):
- html/HTMLImageElement.cpp:
(WebCore::HTMLImageElement::HTMLImageElement):
(WebCore::HTMLImageElement::insertedInto):
(WebCore::HTMLImageElement::removedFrom):
- html/HTMLImageElement.h:
- html/HTMLObjectElement.cpp:
(WebCore::HTMLObjectElement::HTMLObjectElement):
- 3:21 AM Changeset in webkit [195116] by
-
- 11 edits in releases/WebKitGTK/webkit-2.10
Merge r193830 - [GTK] Crash in WebProcess when loading large content with custom URI schemes
https://bugs.webkit.org/show_bug.cgi?id=144262
Reviewed by Carlos Garcia Campos.
Source/WebKit2:
Properly handle scenarios where errors happen after reading the first
chunk of data coming from the GInputStream provided by the application.
- UIProcess/API/gtk/WebKitWebContextPrivate.h:
- UIProcess/API/gtk/WebKitWebContext.cpp:
(webkitWebContextIsLoadingCustomProtocol): New, checks whether a load
is still in progress, after the startLoading method has been called.
- UIProcess/API/gtk/WebKitURISchemeRequest.cpp:
(webkitURISchemeRequestReadCallback): Early return if the stream has been
cancelled on finish_error, so that we make sure we don't keep on reading
the GInputStream after that point.
(webkit_uri_scheme_request_finish_error): Don't send a didFailWithError
message to the Network process if the load is not longer in progress.
- Shared/Network/CustomProtocols/soup/CustomProtocolManagerImpl.cpp:
(WebKit::CustomProtocolManagerImpl::didFailWithError): Handle the case where
an error is notified from the UI process after the first chunk has been read.
(WebKit::CustomProtocolManagerImpl::didReceiveResponse): Handle the case where
data might no longer be available if an error happened even before this point.
- WebProcess/soup/WebKitSoupRequestInputStream.h:
- WebProcess/soup/WebKitSoupRequestInputStream.cpp:
(webkitSoupRequestInputStreamDidFailWithError): Notify the custom GInputStream
that we no longer want to keep reading data in chunks due to a specific error.
(webkitSoupRequestInputStreamReadAsync): Early finish the GTask with a specific
error whenever webkitSoupRequestInputStreamDidFailWithError() has been called.
Tools:
Added new unit test to check the additional scenarios we now
handle for custom URI schemes.
- TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
(generateHTMLContent): New helper function to generate big enough content.
(testWebContextURIScheme): New unit test.
- 2:42 AM Changeset in webkit [195115] by
-
- 4 edits2 adds in releases/WebKitGTK/webkit-2.10
Merge r193829 - Bad position of large operators inside an munderover element
https://bugs.webkit.org/show_bug.cgi?id=151916
Reviewed by Alejandro G. Castro.
Source/WebCore:
Test: mathml/opentype/large-operators-munderover.html
- rendering/mathml/RenderMathMLOperator.h:
(WebCore::RenderMathMLOperator::isVertical): Expose the direction of the operator.
- rendering/mathml/RenderMathMLUnderOver.cpp:
(WebCore::RenderMathMLUnderOver::layout): Remove call to horizontal stretching for vertical operators.
LayoutTests:
- mathml/opentype/large-operators-munderover-expected.txt: Added.
- mathml/opentype/large-operators-munderover.html: Added.
Add a test to verify the position and size of a large operator used as an munderover base.
- 2:40 AM Changeset in webkit [195114] by
-
- 2 edits in releases/WebKitGTK/webkit-2.10/Source/WebCore
Merge r193819 - [TextureMapper] TextureMapperShaderProgram::setMatrix() should use TransformationMatrix::FloatMatrix4
https://bugs.webkit.org/show_bug.cgi?id=152042
Reviewed by Martin Robinson.
- platform/graphics/texmap/TextureMapperShaderProgram.cpp:
(WebCore::TextureMapperShaderProgram::setMatrix): Instead of manually writing out
the complete matrix in a C array, simply use TransformationMatrix::FloatMatrix4
and fill that via the TransformationMatrix::toColumnMajorFloatArray() method
called on the passed-in TransformationMatrix.
- 2:39 AM Changeset in webkit [195113] by
-
- 2 edits in releases/WebKitGTK/webkit-2.10/Source/WebCore
Merge r193818 - [Soup] Attach the SocketStreamHandleSoup write-ready source to the thread-default context
https://bugs.webkit.org/show_bug.cgi?id=152041
Reviewed by Carlos Garcia Campos.
- platform/network/soup/SocketStreamHandleSoup.cpp:
(WebCore::SocketStreamHandle::beginWaitingForSocketWritability): Attach the
write-ready source to the thread-default context, instead of implicitly
relying on the default context for dispatching.
- 2:38 AM Changeset in webkit [195112] by
-
- 2 edits in releases/WebKitGTK/webkit-2.10/Source/WebCore
Merge r193817 - [Soup] SocketStreamHandle should call g_source_destroy() on the write-ready source
https://bugs.webkit.org/show_bug.cgi?id=152040
Reviewed by Carlos Garcia Campos.
- platform/network/soup/SocketStreamHandleSoup.cpp:
(WebCore::SocketStreamHandle::stopWaitingForSocketWritability): Instead of
calling the g_source_get_id()-g_source_remove() pair, destroy the source via
the g_source_destroy() call. Also use nullptr to clear out the pointer
variable.
- 2:37 AM Changeset in webkit [195111] by
-
- 2 edits in releases/WebKitGTK/webkit-2.10/Source/WebCore
Merge r193798 - Changing <video> src during 'ended' event can leave screen sleep disabled
https://bugs.webkit.org/show_bug.cgi?id=152018
Reviewed by Eric Carlson.
Resetting a HTMLMediaElement's src during 'ended' introduces a race condition: whether
the 'mediaPlayerRateChanged()' notification will fire before createMediaPlayer() destroys
the old MediaPlayer firing said notification.
To break the race condition, always update the sleep disabling assertion after destroying
the media player (by creating a new one).
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::createMediaPlayer):
- 2:35 AM Changeset in webkit [195110] by
-
- 3 edits2 adds in releases/WebKitGTK/webkit-2.10
Merge r193773 - Do not insert positioned renderers to multiple gPositionedDescendantsMap.
https://bugs.webkit.org/show_bug.cgi?id=151878
rdar://problem/22229889
Reviewed by Simon Fraser.
We insert positioned renderers into a static map (RenderBlock::gPositionedDescendantsMap) to keep track of them.
This static map is at block level. A particular absolute positioned object is added to its closest ancestor that
returns true for RenderElement::canContainAbsolutelyPositionedObjects().
canContainAbsolutelyPositionedObjects() returns true if the ancestor is either positioned or has transform.
If this container's style changes so that it's no longer positioned and it has no transform anymore,
we need to clear its static map of positioned objects (they'll get re-inserted to another ancestor at next layout).
This patch addresses the case when the renderer does not have transforms anymore.
Source/WebCore:
Test: fast/block/positioning/crash-when-transform-is-removed.html
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::styleWillChange):
LayoutTests:
- fast/block/positioning/crash-when-transform-is-removed-expected.txt: Added.
- fast/block/positioning/crash-when-transform-is-removed.html: Added.
- 2:32 AM Changeset in webkit [195109] by
-
- 3 edits2 adds in releases/WebKitGTK/webkit-2.10
Merge r193743 - [cairo] Solid stroke of lines with thickness less than 1 pixel broken after r191658
https://bugs.webkit.org/show_bug.cgi?id=151947
Reviewed by Martin Robinson.
Source/WebCore:
Test: mathml/presentation/radical-bar-visibility.html
- platform/graphics/cairo/GraphicsContextCairo.cpp:
(WebCore::GraphicsContext::drawLine): Force a minimal thickness of 1px
LayoutTests:
Add a test to check that the radical overbar appears on the screen when it has thickness less than 1px.
- mathml/presentation/radical-bar-visibility-expected-mismatch.html: Added.
- mathml/presentation/radical-bar-visibility.html: Added.
- 2:30 AM Changeset in webkit [195108] by
-
- 3 edits in releases/WebKitGTK/webkit-2.10/Source/WebKit2
Merge r193654 - [WK2] Regression(r187691): If a page is showing an auth pane in one tab, any new tabs with same page hang until credentials are entered in first tab
https://bugs.webkit.org/show_bug.cgi?id=151960
<rdar://problem/23618112>
Reviewed by Alex Christensen.
After r187691, if a page is showing an auth pane in one tab, any new
tabs with same page hang until credentials are entered in first tab.
This is because we coalescing all authentication challenges from the
same domain, no matter what tab they are for. This can be confusing
so we now only coalesce authentication challenges within each tab,
by leveraging the pageID (in addition to the domain).
- Shared/Authentication/AuthenticationManager.cpp:
(WebKit::AuthenticationManager::shouldCoalesceChallenge):
(WebKit::AuthenticationManager::coalesceChallengesMatching):
(WebKit::AuthenticationManager::didReceiveAuthenticationChallenge):
- Shared/Authentication/AuthenticationManager.h:
- 2:30 AM Changeset in webkit [195107] by
-
- 6 edits in releases/WebKitGTK/webkit-2.10/Source/WebKit2
Merge r192287 - Implement authentication challenge handling when using NETWORK_SESSION
https://bugs.webkit.org/show_bug.cgi?id=150968
Reviewed by Antti Koivisto.
- NetworkProcess/NetworkLoad.cpp:
(WebKit::NetworkLoad::didReceiveChallenge):
Copy functionality from NetworkLoad::canAuthenticateAgainstProtectionSpaceAsync (which is used when we don't use NETWORK_SESSION)
because there is no canAuthenticateAgainstProtectionSpace delegate callback when using NSURLSession, according to
https://developer.apple.com/library/ios/documentation/Cocoa/Conceptual/URLLoadingSystem/Articles/AuthenticationChallenges.html
Instead, all authentication challenge callbacks go to URLSession:task:didReceiveChallenge:completionHandler:
because we do not implement URLSession:didReceiveChallenge:completionHandler:
- NetworkProcess/cocoa/NetworkSessionCocoa.mm:
(-[NetworkSessionDelegate URLSession:task:willPerformHTTPRedirection:newRequest:completionHandler:]):
(-[NetworkSessionDelegate URLSession:task:didReceiveChallenge:completionHandler:]):
(-[NetworkSessionDelegate URLSession:dataTask:didReceiveResponse:completionHandler:]):
Make a block copy of the completion handlers so we can copy the std::functions that wrap them into HashMaps and call them later,
in this case we call the completion handler after the UIProcess gives us credentials for an authentication challenge.
- Shared/Authentication/AuthenticationManager.cpp:
(WebKit::AuthenticationManager::AuthenticationManager):
(WebKit::AuthenticationManager::addChallengeToChallengeMap):
(WebKit::AuthenticationManager::shouldCoalesceChallenge):
(WebKit::AuthenticationManager::coalesceChallengesMatching):
(WebKit::AuthenticationManager::didReceiveAuthenticationChallenge):
Fix an existing bug that caused multiple calls to addChallengeToChallengeMap for one challenge. This caused too many calls to
the AuthenticationClient methods, which did not cause a problem because they were not one-time-use block copies of completion handlers before.
(WebKit::AuthenticationManager::useCredentialForSingleChallenge):
(WebKit::AuthenticationManager::continueWithoutCredentialForChallenge):
(WebKit::AuthenticationManager::continueWithoutCredentialForSingleChallenge):
(WebKit::AuthenticationManager::cancelChallenge):
(WebKit::AuthenticationManager::cancelSingleChallenge):
(WebKit::AuthenticationManager::performDefaultHandling):
(WebKit::AuthenticationManager::performDefaultHandlingForSingleChallenge):
(WebKit::AuthenticationManager::rejectProtectionSpaceAndContinue):
(WebKit::AuthenticationManager::rejectProtectionSpaceAndContinueForSingleChallenge):
Call completion handlers which we stored in a HashMap before doing IPC if we are using NETWORK_SESSION,
which has completion handlers instead of continueSomething client calls.
- Shared/Authentication/AuthenticationManager.h:
(WebKit::AuthenticationManager::outstandingAuthenticationChallengeCount):
- Shared/Downloads/Download.cpp:
(WebKit::Download::didReceiveAuthenticationChallenge):
(WebKit::Download::didReceiveResponse):
- Shared/Downloads/DownloadAuthenticationClient.cpp:
(WebKit::DownloadAuthenticationClient::receivedChallengeRejection):
- Shared/Downloads/DownloadAuthenticationClient.h:
Add ifdefs for code related to downloading I will implement later.
- 2:06 AM Changeset in webkit [195106] by
-
- 3 edits in releases/WebKitGTK/webkit-2.10/Source/JavaScriptCore
Merge r193648 - Crashes on PPC64 due to mprotect() on address not aligned to the page size
https://bugs.webkit.org/show_bug.cgi?id=130237
Reviewed by Mark Lam.
Make sure that commitSize is at least as big as the page size.
- interpreter/JSStack.cpp:
(JSC::commitSize):
(JSC::JSStack::JSStack):
(JSC::JSStack::growSlowCase):
- interpreter/JSStack.h:
- 1:35 AM Changeset in webkit [195105] by
-
- 2 edits in releases/WebKitGTK/webkit-2.10/Source/WebCore
Merge r193635 - Crash in MemoryCache::pruneDeadResourcesToSize()
https://bugs.webkit.org/show_bug.cgi?id=151833
<rdar://problem/22392235>
Reviewed by David Kilzer.
MemoryCache::pruneDeadResourcesToSize() is iterating over m_allResources
(which is a vector of LRUList). It first destroys decoded data for each
resource in the LRUList. Then, if it does not suffice to reach the
target size, and starts actually removing resources from the cache.
The issue is that this code alters m_allResources (and its LRULists) as
it is iterating over it. We tried to deal with this in various ways:
- Increment the iterator before removing the resource pointed by the iterator.
- Protect the next resource in the LRUList and abort early if it is no longer in the cache.
This adds code complexity and apparently does not correctly handle all
the edge cases as we still see crashes in this code. In particular, I
suspect that 2. may not be sufficient if it is possible for the next
resource to be moved to another LRUList (in which case, next->inCache()
would still return true but the iterator would however become invalid).
To make the code simpler and more robust, this patch copies the LRUList
(and refs the CachedResources) before iterating over it. This is a lot
safer and should hopefully fix the crashes we see in this function.
No new tests, no reproduction case.
- loader/cache/MemoryCache.cpp:
(WebCore::MemoryCache::pruneDeadResourcesToSize):
- 1:33 AM Changeset in webkit [195104] by
-
- 3 edits2 adds in releases/WebKitGTK/webkit-2.10
Merge r193613 - Clipping along compositing borders in svg-edit
https://bugs.webkit.org/show_bug.cgi?id=151791
Reviewed by Zalan Bujtas.
Source/WebCore:
RenderSVGRoot::layout() failed to clear overflow before recomputing
visual overflow, which could cause it to get stuck with stale overflow.
This would cause underpainting if its size went from small to large.
Test: svg/overflow/visual-overflow-change.html
- rendering/svg/RenderSVGRoot.cpp:
(WebCore::RenderSVGRoot::layout):
LayoutTests:
Ref test that triggers recomputation of overflow.
- svg/overflow/visual-overflow-change-expected.html: Added.
- svg/overflow/visual-overflow-change.html: Added.
- 1:31 AM Changeset in webkit [195103] by
-
- 6 edits2 adds in releases/WebKitGTK/webkit-2.10
Merge r193610 - REGRESSION (r187121): Can't get to the main content of the page at https://theintercept.com/drone-papers/
https://bugs.webkit.org/show_bug.cgi?id=151849
rdar://problem/23132828
Reviewed by Zalan Bujtas.
Source/WebCore:
This page uses a fill-forwards animation where the last keyframe has height: auto.
After r187121, we tried to blend the height Length value from the last keyframe to the
first keyframe with progress=0 (which should pick up the 'auto' from the last keyframe).
However, Length::blend() just considered both 0 and 'auto' to be zero, and returned
the 0 length.
So fix Length::blend() to return the "from" length if progress is zero.
Test: animations/fill-forwards-auto-height.html
- page/animation/CSSPropertyAnimation.cpp:
(WebCore::blendFunc): Length::blend takes a double, so don't narrow to float.
- page/animation/KeyframeAnimation.cpp:
(WebCore::KeyframeAnimation::fetchIntervalEndpointsForProperty): Declare two variables
at first use.
- platform/Length.h:
(WebCore::Length::blend):
LayoutTests:
New ref test.
The behavior of imported/blink/transitions/transition-not-interpolable.html changed
with this patch, but that test is trying to determine if transitions run to/from
'auto' values, and doing it wrong. The current patch doesn't change the user-visible
behavior of transitions with 'auto' endpoints (covered by http://webkit.org/b/38243).
- animations/fill-forwards-auto-height-expected.html: Added.
- animations/fill-forwards-auto-height.html: Added.
- imported/blink/transitions/transition-not-interpolable-expected.txt:
- 1:15 AM Changeset in webkit [195102] by
-
- 2 edits in releases/WebKitGTK/webkit-2.10/Source/WebCore
Merge r193609 - Give SVGTransformList some inline vector capacity
https://bugs.webkit.org/show_bug.cgi?id=151644
Reviewed by Andreas Kling.
Giving SVGTransformList inline capacity of one drops time under SVGTransformList::parse() by
about 1% on http://animateplus.com/demos/stress-test/
- svg/SVGTransformList.h:
- 1:14 AM Changeset in webkit [195101] by
-
- 23 edits in trunk
[Streams API] Expose ReadableStream and relatives to Worker
https://bugs.webkit.org/show_bug.cgi?id=152066
Reviewed by Darin Adler.
LayoutTests/imported/w3c:
Rebasing tests as Worker tests are now running.
- web-platform-tests/streams-api/byte-length-queuing-strategy-expected.txt:
- web-platform-tests/streams-api/count-queuing-strategy-expected.txt:
- web-platform-tests/streams-api/readable-streams/bad-underlying-sources-expected.txt:
- web-platform-tests/streams-api/readable-streams/bad-strategies-expected.txt:
- web-platform-tests/streams-api/readable-streams/brand-checks-expected.txt:
- web-platform-tests/streams-api/readable-streams/cancel-expected.txt:
- web-platform-tests/streams-api/readable-streams/count-queuing-strategy-integration-expected.txt:
- web-platform-tests/streams-api/readable-streams/garbage-collection-expected.txt:
- web-platform-tests/streams-api/readable-streams/general-expected.txt:
- web-platform-tests/streams-api/readable-streams/pipe-through-expected.txt:
- web-platform-tests/streams-api/readable-streams/readable-stream-reader-expected.txt:
- web-platform-tests/streams-api/readable-streams/tee-expected.txt:
- web-platform-tests/streams-api/readable-streams/templated-expected.txt:
Source/WebCore:
Covered by rebased tests.
- Modules/streams/ByteLengthQueuingStrategy.idl:
- Modules/streams/CountQueuingStrategy.idl:
- Modules/streams/ReadableStream.idl:
- Modules/streams/ReadableStreamController.idl:
- Modules/streams/ReadableStreamReader.idl:
LayoutTests:
Rebasing tests as ReadableStream is now available in workers.
- js/dom/global-constructors-attributes-dedicated-worker-expected.txt:
- platform/efl/js/dom/global-constructors-attributes-dedicated-worker-expected.txt:
- 1:11 AM Changeset in webkit [195100] by
-
- 5 edits8 adds in trunk
CORS: Fix the handling of redirected request containing Origin null.
https://bugs.webkit.org/show_bug.cgi?id=128816
Reviewed by Brent Fulgham.
Source/WebCore:
Merging Blink patch from George Ancil (https://chromiumcodereview.appspot.com/20735002).
This patch removes the check for securityOrigin->isUnique() in passesAccessControlCheck().
This check prevented a redirected request with "Origin: null" from being
successful even when the response contains "Access-Control-Allow-Origin: null"
Tests: http/tests/xmlhttprequest/access-control-sandboxed-iframe-allow-origin-null.html
http/tests/xmlhttprequest/redirect-cors-origin-null.html
- loader/CrossOriginAccessControl.cpp:
(WebCore::passesAccessControlCheck):
LayoutTests:
Merging Blink patch from George Ancil (https://chromiumcodereview.appspot.com/20735002)
Added two tests to check CORS with Origin null in HTTP redirect and iframe cases.
Updated two test sandboxed iframes test expectations (requests are still denied but error messages are different).
- http/tests/xmlhttprequest/access-control-sandboxed-iframe-allow-origin-null-expected.txt: Added.
- http/tests/xmlhttprequest/access-control-sandboxed-iframe-allow-origin-null.html: Added.
- http/tests/xmlhttprequest/access-control-sandboxed-iframe-denied-expected.txt:
- http/tests/xmlhttprequest/access-control-sandboxed-iframe-denied-without-wildcard-expected.txt:
- http/tests/xmlhttprequest/redirect-cors-origin-null-expected.txt: Added.
- http/tests/xmlhttprequest/redirect-cors-origin-null.html: Added.
- http/tests/xmlhttprequest/resources/access-control-sandboxed-iframe-allow-origin-null-iframe.html: Added.
- http/tests/xmlhttprequest/resources/access-control-sandboxed-iframe-allow-origin-null.cgi: Added.
- http/tests/xmlhttprequest/resources/redirect-cors-origin-null-pass.php: Added.
- http/tests/xmlhttprequest/resources/redirect-cors-origin-null.php: Added.
- 1:04 AM Changeset in webkit [195099] by
-
- 2 edits in releases/WebKitGTK/webkit-2.10/Source/WebCore
Merge r193390 - Remove the use of GraphicsContextStateSaver from RenderLayer::paintLayerByApplyingTransform
https://bugs.webkit.org/show_bug.cgi?id=151829
Patch by Said Abou-Hallawa <sabouhallawa@apple.com> on 2015-12-03
Reviewed by Simon Fraser.
Set the CTM of the GraphicsContext to its original value before changing
it. This is a lot cheaper than using GraphicsContextStateSaver to save the
whole state of the GraphicsContext and restore it back;
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::paintLayerByApplyingTransform):
- 12:58 AM Changeset in webkit [195098] by
-
- 5 edits in releases/WebKitGTK/webkit-2.10/Source/bmalloc
Merge r193373 - bmalloc: extra large allocations could be more efficient
https://bugs.webkit.org/show_bug.cgi?id=151817
Reviewed by Geoffrey Garen.
Reduced the super chunk size from 4MB to 2MB.
Added path to reallocate() of an extra large object to see if we can extend the allocation.
- bmalloc/Allocator.cpp:
(bmalloc::Allocator::reallocate):
- bmalloc/SegregatedFreeList.h:
- bmalloc/Sizes.h:
- bmalloc/VMAllocate.h:
(bmalloc::tryVMAllocate):
(bmalloc::tryVMExtend):
(bmalloc::vmAllocate):
- 12:36 AM Changeset in webkit [195097] by
-
- 3 edits in releases/WebKitGTK/webkit-2.10/Source/WebCore
Merge r192989 - Reduce size of ScriptElement
https://bugs.webkit.org/show_bug.cgi?id=151786
Patch by Alex Christensen <achristensen@webkit.org> on 2015-12-02
Reviewed by Andreas Kling.
- dom/ScriptElement.cpp:
(WebCore::ScriptElement::ScriptElement):
(WebCore::ScriptElement::requestScript):
- dom/ScriptElement.h:
Use callOnMainThread instead of a Timer to save memory on a timer that is rarely used.
Use bit fields for the boolean values to save another 8 bytes per ScriptElement.
This reduces sizeof(ScriptElement) from 168 to 48 bytes.
- 12:33 AM Changeset in webkit [195096] by
-
- 8 edits3 adds in releases/WebKitGTK/webkit-2.10
Merge r192983 - Asynchronously call onerror when a content blocker blocks ascript element's load
https://bugs.webkit.org/show_bug.cgi?id=151649
Patch by Alex Christensen <achristensen@webkit.org> on 2015-12-02
Reviewed by Brady Eidson.
Source/WebCore:
Test: http/tests/contentextensions/script-onerror.html
- dom/ScriptElement.cpp:
(WebCore::ScriptElement::ScriptElement):
(WebCore::ScriptElement::requestScript):
- dom/ScriptElement.h:
LayoutTests:
- http/tests/contentextensions/script-onerror-expected.txt: Added.
- http/tests/contentextensions/script-onerror.html: Added.
- http/tests/contentextensions/script-onerror.html.json: Added.
- http/tests/misc/unloadable-script-expected.txt:
- http/tests/misc/unloadable-script.html:
- http/tests/security/local-JavaScript-from-remote-expected.txt:
- http/tests/security/local-JavaScript-from-remote.html:
Added testRunner.waitUntilDone and testRunner.notifyDone to reflect the fact that onerror is no longer called synchronously.
- 12:26 AM Changeset in webkit [195095] by
-
- 3 edits2 adds in releases/WebKitGTK/webkit-2.10
Merge r192969 - Fix preloader issue with srcdoc documents.
https://bugs.webkit.org/show_bug.cgi?id=151744
Reviewed by Ryosuke Niwa.
Source/WebCore:
Make sure that PreloadRequest is resolving URLs based on the document's
baseURL() rather than using url() as the base URL, which is not how URLs
are resolved by the parser, and fails when document->url() diverges from
the document's base URL (e.g. in the case of srcdoc based documents).
Test: fast/preloader/iframe-srcdoc.html
- html/parser/HTMLResourcePreloader.cpp:
(WebCore::PreloadRequest::completeURL):
LayoutTests:
Added a test that makes sure that srcdoc based subresources are properly preloaded.
- fast/preloader/iframe-srcdoc-expected.txt: Added.
- fast/preloader/iframe-srcdoc.html: Added.
- 12:22 AM Changeset in webkit [195094] by
-
- 2 edits in trunk/Source/WTF
[EFL] WorkQueue methods should be defined inside WTF namespace.
https://bugs.webkit.org/show_bug.cgi?id=153097
Patch by Konstantin Tokarev <Konstantin Tokarev> on 2016-01-15
Reviewed by Gyuyoung Kim.
- wtf/efl/WorkQueueEfl.cpp:
- 12:11 AM Changeset in webkit [195093] by
-
- 3 edits in trunk/Source/JavaScriptCore
[mips] Add countLeadingZeros32 implementation in macro assembler
https://bugs.webkit.org/show_bug.cgi?id=152886
Reviewed by Michael Saboff.
- assembler/MIPSAssembler.h:
(JSC::MIPSAssembler::lui):
(JSC::MIPSAssembler::clz):
(JSC::MIPSAssembler::addiu):
- assembler/MacroAssemblerMIPS.h:
(JSC::MacroAssemblerMIPS::and32):
(JSC::MacroAssemblerMIPS::countLeadingZeros32):
(JSC::MacroAssemblerMIPS::lshift32):
Jan 14, 2016:
- 11:18 PM Changeset in webkit [195092] by
-
- 8 edits3 deletes in trunk
Unreviewed, rolling out r195064.
https://bugs.webkit.org/show_bug.cgi?id=153118
test fails most of the time (Requested by alexchristensen on
#webkit).
Reverted changeset:
"Avoid downloading the wrong image for <picture> elements."
https://bugs.webkit.org/show_bug.cgi?id=153027
http://trac.webkit.org/changeset/195064
Patch by Commit Queue <commit-queue@webkit.org> on 2016-01-14
- 10:12 PM Changeset in webkit [195091] by
-
- 10 edits in trunk
createElement should not lowercase non-ASCII characters
https://bugs.webkit.org/show_bug.cgi?id=153114
Reviewed by Alex Christensen.
LayoutTests/imported/w3c:
Rebaselined the tests for document.createElement now that more test cases are passing.
- web-platform-tests/dom/nodes/Document-createElement-expected.txt:
- web-platform-tests/dom/nodes/Document-getElementsByTagName-expected.txt:
- web-platform-tests/dom/nodes/Element-getElementsByTagName-expected.txt:
- web-platform-tests/dom/nodes/case-expected.txt:
Source/WebCore:
According to step 2 in https://dom.spec.whatwg.org/#dom-document-createelement, document.createElement should not
lowercase non-ASCII letters, and this is also what Firefox does. Match that behavior by lowercasing the tag name
by convertToASCIILowercase() instead of lower() in createElement.
Also merged HTMLDocument::createElement into Document::createElement for simplicity and avoid duplicating
the call to isValidName and setting a DOM exception.
No new tests since the behavior change is covered by the existing W3C tests.
- dom/Document.cpp:
(WebCore::Document::createElement): Create a HTML element with ASCII-lowercased tag name inside a HTML document.
- dom/Document.h:
- html/HTMLDocument.cpp:
(WebCore::addLocalNameToSet):
(WebCore::HTMLDocument::createElement): Merged into Document::createElement.
- html/HTMLDocument.h:
- 9:40 PM Changeset in webkit [195090] by
-
- 14 edits1 copy in trunk/Source
Modern IDB: Support opening and deleting SQLite databases on disk.
https://bugs.webkit.org/show_bug.cgi?id=153084
Reviewed by Alex Christensen, Sam Weinig and Andy Estes (oh my!).
Source/WebCore:
No new tests (Infrastructure, no testable change in behavior).
- Modules/indexeddb/IDBDatabaseIdentifier.cpp:
(WebCore::IDBDatabaseIdentifier::databaseDirectoryRelativeToRoot):
- Modules/indexeddb/IDBDatabaseIdentifier.h:
- Modules/indexeddb/server/IDBServer.cpp:
(WebCore::IDBServer::IDBServer::create):
(WebCore::IDBServer::IDBServer::IDBServer):
(WebCore::IDBServer::IDBServer::createBackingStore):
- Modules/indexeddb/server/IDBServer.h:
- Modules/indexeddb/server/SQLiteIDBBackingStore.cpp:
(WebCore::IDBServer::SQLiteIDBBackingStore::SQLiteIDBBackingStore):
(WebCore::IDBServer::SQLiteIDBBackingStore::getOrEstablishDatabaseInfo):
(WebCore::IDBServer::SQLiteIDBBackingStore::deleteBackingStore):
- Modules/indexeddb/server/SQLiteIDBBackingStore.h:
- Modules/indexeddb/shared/InProcessIDBServer.cpp:
(WebCore::InProcessIDBServer::create):
(WebCore::InProcessIDBServer::InProcessIDBServer):
- Modules/indexeddb/shared/InProcessIDBServer.h:
Source/WebKit:
- Storage/WebDatabaseProvider.cpp:
(WebDatabaseProvider::idbConnectionToServerForSession):
- Storage/WebDatabaseProvider.h:
- WebKit.xcodeproj/project.pbxproj:
Source/WebKit/mac:
- Storage/WebDatabaseProvider.mm: Copied from Source/WebKit/Storage/WebDatabaseProvider.cpp.
(WebDatabaseProvider::indexedDatabaseDirectoryPath):
- 9:23 PM Changeset in webkit [195089] by
-
- 2 edits in trunk/LayoutTests
Test gardening after r195088
Unreviewed.
- http/tests/contentextensions/font-display-none-repeated-layout-expected.txt:
- 7:31 PM Changeset in webkit [195088] by
-
- 5 edits3 adds in trunk
Mixing Content Blocking of fonts and display:none rules causes battery drain
https://bugs.webkit.org/show_bug.cgi?id=153051
<rdar://problem/23187709>
Reviewed by Alex Christensen.
Source/WebCore:
If we have applied a rule before and we are not applying it again, don't
resolve the style again.
Test: http/tests/contentextensions/font-display-none-repeated-layout.html
- contentextensions/ContentExtensionStyleSheet.cpp:
(WebCore::ContentExtensions::ContentExtensionStyleSheet::addDisplayNoneSelector):
- contentextensions/ContentExtensionStyleSheet.h:
- dom/ExtensionStyleSheets.cpp:
(WebCore::ExtensionStyleSheets::addDisplayNoneSelector):
LayoutTests:
Make sure that layoutCount does not skyrocket.
- http/tests/contentextensions/font-display-none-repeated-layout-expected.txt: Added.
- http/tests/contentextensions/font-display-none-repeated-layout.html: Added.
- http/tests/contentextensions/font-display-none-repeated-layout.html.json: Added.
- 6:59 PM Changeset in webkit [195087] by
-
- 12 edits9 adds in trunk
Add document.defineCustomElement
https://bugs.webkit.org/show_bug.cgi?id=153092
Reviewed by Chris Dumez.
Source/WebCore:
Added document.defineCustomElement and added a constructor to HTMLElement which can be called
as "super" in a subclass of HTMLElement. This is a prototype of new custom elements API and
willfully violates the current specification at http://w3c.github.io/webcomponents/spec/custom/
Each author defined class can define multiple elements using distinct tag names. In such cases,
the super call must specify the tag name. e.g.
class SomeCustomElement extends HTMLElement { constructor(name) { super(name); } }
document.defineCustomElement('some-custom-element', SomeCustomElement);
document.defineCustomElement('other-custom-element', SomeCustomElement);
new SomeCustomElement('some-custom-element');
When a class is associated with exactly one tag name, the argument can be omitted. e.g.
class AnotherCustomElement extends HTMLElement {}
document.defineCustomElement('another-custom-element', AnotherCustomElement);
new AnotherCustomElement();
We allow only subclassing of HTMLElement and only in (X)HTML namespace.
Tests: fast/custom-elements/Document-defineCustomElement.html
fast/custom-elements/HTMLElement-constructor.html
- CMakeLists.txt:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSCustomElementInterface.cpp: Added. Abstracts an author-defined class associated
with a custom element. It's a Active DOM object and lives until the associated document dies.
(WebCore::JSCustomElementInterface::JSCustomElementInterface):
(WebCore::JSCustomElementInterface::~JSCustomElementInterface):
- bindings/js/JSCustomElementInterface.h: Added.
(WebCore::JSCustomElementInterface::create):
(WebCore::JSCustomElementInterface::scriptExecutionContext):
(WebCore::JSCustomElementInterface::constructor):
- bindings/js/JSDocumentCustom.cpp:
(WebCore::JSDocument::defineCustomElement): Added. Define a custom element by associating a tag
name with an author defined JS class after validating arguments.
- bindings/js/JSHTMLElementCustom.cpp:
(WebCore::constructJSHTMLElement): Added. Look up the tag name based on new.target if one is not
specified. If a tag name is specified, check that new.target is associated with the tag name.
- dom/CustomElementDefinitions.cpp: Added.
(WebCore::CustomElementDefinitions::checkName): Added. Restricts tag names similarly to
http://w3c.github.io/webcomponents/spec/custom/#dfn-custom-element-type
(WebCore::CustomElementDefinitions::defineElement): Added. Associates a JS class with a tag name.
(WebCore::CustomElementDefinitions::findInterface): Added. Finds a JS class by a tag name.
(WebCore::CustomElementDefinitions::findName): Added. Finds a tag name by a JS class.
- dom/CustomElementDefinitions.h: Added.
(WebCore::CustomElementDefinitions::CustomElementInfo): Added.
- dom/Document.cpp:
(WebCore::Document::ensureCustomElementDefinitions): Added.
- dom/Document.h:
(WebCore::Document::customElementDefinitions): Added.
- dom/Document.idl:
- html/HTMLElement.idl:
LayoutTests:
Added tests for document.defineCustomElement and instantiating custom elements.
- TestExpectations: Skipped the tests on non-Mac ports.
- fast/custom-elements: Added.
- fast/custom-elements/Document-defineCustomElement-expected.txt: Added.
- fast/custom-elements/Document-defineCustomElement.html: Added.
- fast/custom-elements/HTMLElement-constructor-expected.txt: Added.
- fast/custom-elements/HTMLElement-constructor.html: Added.
- platform/mac/TestExpectations:
- 5:04 PM Changeset in webkit [195086] by
-
- 1 copy in tags/Safari-601.5.10
New Tag.
- 4:59 PM Changeset in webkit [195085] by
-
- 1 copy in tags/Safari-601.1.46.92
New Tag.
- 4:58 PM Changeset in webkit [195084] by
-
- 30 edits10 adds in trunk/Source/JavaScriptCore
Air needs a Shuffle instruction
https://bugs.webkit.org/show_bug.cgi?id=152952
Reviewed by Saam Barati.
This adds an instruction called Shuffle. Shuffle allows you to simultaneously perform
multiple moves to perform arbitrary permutations over registers and memory. We call these
rotations. It also allows you to perform "shifts", like (a => b, b => c): after the shift,
c will have b's old value, b will have a's old value, and a will be unchanged. Shifts can
use immediates as their source.
Shuffle is added as a custom instruction, since it has a variable number of arguments. It
takes any number of triplets of arguments, where each triplet describes one mapping of the
shuffle. For example, to represent (a => b, b => c), we might say:
Shuffle %a, %b, 64, %b, %c, 64
Note the "64"s, those are width arguments that describe how many bits of the register are
being moved. Each triplet is referred to as a "shuffle pair". We call it a pair because the
most relevant part of it is the pair of registers or memroy locations (i.e. %a, %b form one
of the pairs in the example). For GP arguments, the width follows ZDef semantics.
In the future, we will be able to use Shuffle for a lot of things. This patch is modest about
how to use it:
- C calling convention argument marshalling. Previously we used move instructions. But that's problematic since it introduces artificial interference between the argument registers and the inputs. Using Shuffle removes that interference. This helps a bit.
- Cold C calls. This is what really motivated me to write this patch. If we have a C call on a cold path, then we want it to appear to the register allocator like it doesn't clobber any registers. Only after register allocation should we handle the clobbering by simply saving all of the live volatile registers to the stack. If you imagine the saving and the argument marshalling, you can see how before the call, we want to have a Shuffle that does both of those things. This is important. If argument marshalling was separate from the saving, then we'd still appear to clobber argument registers. Doing them together as one Shuffle means that the cold call doesn't appear to even clobber the argument registers.
Unfortunately, I was wrong about cold C calls being the dominant problem with our register
allocator right now. Fixing this revealed other problems in my current tuning benchmark,
Octane/encrypt. Nonetheless, this is a small speed-up across the board, and gives us some
functionality we will need to implement other optimizations.
- CMakeLists.txt:
- JavaScriptCore.xcodeproj/project.pbxproj:
- assembler/AbstractMacroAssembler.h:
(JSC::isX86_64):
(JSC::isIOS):
(JSC::optimizeForARMv7IDIVSupported):
- assembler/MacroAssemblerX86Common.h:
(JSC::MacroAssemblerX86Common::zeroExtend32ToPtr):
(JSC::MacroAssemblerX86Common::swap32):
(JSC::MacroAssemblerX86Common::moveConditionally32):
- assembler/MacroAssemblerX86_64.h:
(JSC::MacroAssemblerX86_64::store64WithAddressOffsetPatch):
(JSC::MacroAssemblerX86_64::swap64):
(JSC::MacroAssemblerX86_64::move64ToDouble):
- assembler/X86Assembler.h:
(JSC::X86Assembler::xchgl_rr):
(JSC::X86Assembler::xchgl_rm):
(JSC::X86Assembler::xchgq_rr):
(JSC::X86Assembler::xchgq_rm):
(JSC::X86Assembler::movl_rr):
- b3/B3CCallValue.h:
- b3/B3Compilation.cpp:
(JSC::B3::Compilation::Compilation):
(JSC::B3::Compilation::~Compilation):
- b3/B3Compilation.h:
(JSC::B3::Compilation::code):
- b3/B3LowerToAir.cpp:
(JSC::B3::Air::LowerToAir::run):
(JSC::B3::Air::LowerToAir::createSelect):
(JSC::B3::Air::LowerToAir::lower):
(JSC::B3::Air::LowerToAir::marshallCCallArgument): Deleted.
- b3/B3OpaqueByproducts.h:
(JSC::B3::OpaqueByproducts::count):
- b3/B3StackmapSpecial.cpp:
(JSC::B3::StackmapSpecial::isArgValidForValue):
(JSC::B3::StackmapSpecial::isArgValidForRep):
- b3/air/AirArg.cpp:
(JSC::B3::Air::Arg::isStackMemory):
(JSC::B3::Air::Arg::isRepresentableAs):
(JSC::B3::Air::Arg::usesTmp):
(JSC::B3::Air::Arg::canRepresent):
(JSC::B3::Air::Arg::isCompatibleType):
(JSC::B3::Air::Arg::dump):
(WTF::printInternal):
- b3/air/AirArg.h:
(JSC::B3::Air::Arg::forEachType):
(JSC::B3::Air::Arg::isWarmUse):
(JSC::B3::Air::Arg::cooled):
(JSC::B3::Air::Arg::isEarlyUse):
(JSC::B3::Air::Arg::imm64):
(JSC::B3::Air::Arg::immPtr):
(JSC::B3::Air::Arg::addr):
(JSC::B3::Air::Arg::special):
(JSC::B3::Air::Arg::widthArg):
(JSC::B3::Air::Arg::operator==):
(JSC::B3::Air::Arg::isImm64):
(JSC::B3::Air::Arg::isSomeImm):
(JSC::B3::Air::Arg::isAddr):
(JSC::B3::Air::Arg::isIndex):
(JSC::B3::Air::Arg::isMemory):
(JSC::B3::Air::Arg::isRelCond):
(JSC::B3::Air::Arg::isSpecial):
(JSC::B3::Air::Arg::isWidthArg):
(JSC::B3::Air::Arg::isAlive):
(JSC::B3::Air::Arg::base):
(JSC::B3::Air::Arg::hasOffset):
(JSC::B3::Air::Arg::offset):
(JSC::B3::Air::Arg::width):
(JSC::B3::Air::Arg::isGPTmp):
(JSC::B3::Air::Arg::isGP):
(JSC::B3::Air::Arg::isFP):
(JSC::B3::Air::Arg::isType):
(JSC::B3::Air::Arg::isGPR):
(JSC::B3::Air::Arg::isValidForm):
(JSC::B3::Air::Arg::forEachTmpFast):
- b3/air/AirBasicBlock.h:
(JSC::B3::Air::BasicBlock::insts):
(JSC::B3::Air::BasicBlock::appendInst):
(JSC::B3::Air::BasicBlock::append):
- b3/air/AirCCallingConvention.cpp: Added.
(JSC::B3::Air::computeCCallingConvention):
(JSC::B3::Air::cCallResult):
(JSC::B3::Air::buildCCall):
- b3/air/AirCCallingConvention.h: Added.
- b3/air/AirCode.h:
(JSC::B3::Air::Code::proc):
- b3/air/AirCustom.cpp: Added.
(JSC::B3::Air::CCallCustom::isValidForm):
(JSC::B3::Air::CCallCustom::generate):
(JSC::B3::Air::ShuffleCustom::isValidForm):
(JSC::B3::Air::ShuffleCustom::generate):
- b3/air/AirCustom.h:
(JSC::B3::Air::PatchCustom::forEachArg):
(JSC::B3::Air::PatchCustom::generate):
(JSC::B3::Air::CCallCustom::forEachArg):
(JSC::B3::Air::CCallCustom::isValidFormStatic):
(JSC::B3::Air::CCallCustom::admitsStack):
(JSC::B3::Air::CCallCustom::hasNonArgNonControlEffects):
(JSC::B3::Air::ColdCCallCustom::forEachArg):
(JSC::B3::Air::ShuffleCustom::forEachArg):
(JSC::B3::Air::ShuffleCustom::isValidFormStatic):
(JSC::B3::Air::ShuffleCustom::admitsStack):
(JSC::B3::Air::ShuffleCustom::hasNonArgNonControlEffects):
- b3/air/AirEmitShuffle.cpp: Added.
(JSC::B3::Air::ShufflePair::dump):
(JSC::B3::Air::emitShuffle):
- b3/air/AirEmitShuffle.h: Added.
(JSC::B3::Air::ShufflePair::ShufflePair):
(JSC::B3::Air::ShufflePair::src):
(JSC::B3::Air::ShufflePair::dst):
(JSC::B3::Air::ShufflePair::width):
- b3/air/AirGenerate.cpp:
(JSC::B3::Air::prepareForGeneration):
- b3/air/AirGenerate.h:
- b3/air/AirInsertionSet.cpp:
(JSC::B3::Air::InsertionSet::insertInsts):
(JSC::B3::Air::InsertionSet::execute):
- b3/air/AirInsertionSet.h:
(JSC::B3::Air::InsertionSet::insertInst):
(JSC::B3::Air::InsertionSet::insert):
- b3/air/AirInst.h:
(JSC::B3::Air::Inst::operator bool):
(JSC::B3::Air::Inst::append):
- b3/air/AirLowerAfterRegAlloc.cpp: Added.
(JSC::B3::Air::lowerAfterRegAlloc):
- b3/air/AirLowerAfterRegAlloc.h: Added.
- b3/air/AirLowerMacros.cpp: Added.
(JSC::B3::Air::lowerMacros):
- b3/air/AirLowerMacros.h: Added.
- b3/air/AirOpcode.opcodes:
- b3/air/AirRegisterPriority.h:
(JSC::B3::Air::regsInPriorityOrder):
- b3/air/testair.cpp: Added.
(hiddenTruthBecauseNoReturnIsStupid):
(usage):
(JSC::B3::Air::compile):
(JSC::B3::Air::invoke):
(JSC::B3::Air::compileAndRun):
(JSC::B3::Air::testSimple):
(JSC::B3::Air::loadConstantImpl):
(JSC::B3::Air::loadConstant):
(JSC::B3::Air::loadDoubleConstant):
(JSC::B3::Air::testShuffleSimpleSwap):
(JSC::B3::Air::testShuffleSimpleShift):
(JSC::B3::Air::testShuffleLongShift):
(JSC::B3::Air::testShuffleLongShiftBackwards):
(JSC::B3::Air::testShuffleSimpleRotate):
(JSC::B3::Air::testShuffleSimpleBroadcast):
(JSC::B3::Air::testShuffleBroadcastAllRegs):
(JSC::B3::Air::testShuffleTreeShift):
(JSC::B3::Air::testShuffleTreeShiftBackward):
(JSC::B3::Air::testShuffleTreeShiftOtherBackward):
(JSC::B3::Air::testShuffleMultipleShifts):
(JSC::B3::Air::testShuffleRotateWithFringe):
(JSC::B3::Air::testShuffleRotateWithLongFringe):
(JSC::B3::Air::testShuffleMultipleRotates):
(JSC::B3::Air::testShuffleShiftAndRotate):
(JSC::B3::Air::testShuffleShiftAllRegs):
(JSC::B3::Air::testShuffleRotateAllRegs):
(JSC::B3::Air::testShuffleSimpleSwap64):
(JSC::B3::Air::testShuffleSimpleShift64):
(JSC::B3::Air::testShuffleSwapMixedWidth):
(JSC::B3::Air::testShuffleShiftMixedWidth):
(JSC::B3::Air::testShuffleShiftMemory):
(JSC::B3::Air::testShuffleShiftMemoryLong):
(JSC::B3::Air::testShuffleShiftMemoryAllRegs):
(JSC::B3::Air::testShuffleShiftMemoryAllRegs64):
(JSC::B3::Air::combineHiLo):
(JSC::B3::Air::testShuffleShiftMemoryAllRegsMixedWidth):
(JSC::B3::Air::testShuffleRotateMemory):
(JSC::B3::Air::testShuffleRotateMemory64):
(JSC::B3::Air::testShuffleRotateMemoryMixedWidth):
(JSC::B3::Air::testShuffleRotateMemoryAllRegs64):
(JSC::B3::Air::testShuffleRotateMemoryAllRegsMixedWidth):
(JSC::B3::Air::testShuffleSwapDouble):
(JSC::B3::Air::testShuffleShiftDouble):
(JSC::B3::Air::run):
(run):
(main):
- b3/testb3.cpp:
(JSC::B3::testCallSimple):
(JSC::B3::testCallRare):
(JSC::B3::testCallRareLive):
(JSC::B3::testCallSimplePure):
(JSC::B3::run):
- 4:50 PM Changeset in webkit [195083] by
-
- 2 edits in trunk/Tools
[webkitdirs] Replaced grep invocation with perl code
https://bugs.webkit.org/show_bug.cgi?id=153106
Patch by Konstantin Tokarev <Konstantin Tokarev> on 2016-01-14
Reviewed by Alex Christensen.
- Scripts/webkitdirs.pm:
(determineArchitecture):
- 4:14 PM Changeset in webkit [195082] by
-
- 5 edits in trunk/Source
Remove workaround for rdar://problem/23623670
https://bugs.webkit.org/show_bug.cgi?id=153107
rdar://problem/23633319
Reviewed by Tim Horton.
Remove the code that uses IOSurfaceAcceleratorTransformSurface() when copying from
back-to-front buffer, now that CGIOSurfaceContextCreate()-code path works correctly.
Source/WebCore:
- platform/graphics/cocoa/IOSurface.h:
- platform/graphics/cocoa/IOSurface.mm:
(IOSurface::ensurePlatformContext):
(IOSurface::copyToSurface): Deleted.
Source/WebKit2:
- Shared/mac/RemoteLayerBackingStore.mm:
(WebKit::RemoteLayerBackingStore::display):
- 4:07 PM Changeset in webkit [195081] by
-
- 9 edits in trunk/Source
WK1 and WK2 should share more candidate request code
https://bugs.webkit.org/show_bug.cgi?id=153108
Reviewed by Simon Fraser.
requestCandidatesForSelection() does not need to be exposed as an
EditorClient function. WK1 can just call invoke this code from the existing
respondToChangedSelection EditorClient function, which is what WK2 does.
Source/WebCore:
- editing/Editor.cpp:
(WebCore::Editor::respondToChangedSelection):
- loader/EmptyClients.h:
- page/EditorClient.h:
(WebCore::EditorClient::supportsGlobalSelection):
Source/WebKit/mac:
- WebCoreSupport/WebEditorClient.h:
- WebCoreSupport/WebEditorClient.mm:
(WebEditorClient::respondToChangedSelection):
Cleanup — use some code that was moved to WebCore::Editor.
(WebEditorClient::requestCandidatesForSelection):
(WebEditorClient::handleRequestedCandidates):
(textCheckingResultFromNSTextCheckingResult):
(WebEditorClient::handleAcceptedCandidate):
(candidateRangeForSelection): Deleted.
(candidateWouldReplaceText): Deleted.
Source/WebKit2:
- WebProcess/WebCoreSupport/WebEditorClient.h:
- 3:07 PM Changeset in webkit [195080] by
-
- 2 edits in trunk/Tools
prepare-changelog does not read paths containing spaces properly
https://bugs.webkit.org/show_bug.cgi?id=137982
Reviewed by Joseph Pecoraro.
Escape whitespace in filenames before passing the file path to other functions.
- Scripts/prepare-ChangeLog:
(generateFunctionLists): Use the more explicit 3-argument form of 'open'.
- 3:00 PM Changeset in webkit [195079] by
-
- 2 edits in trunk/Source/WTF
Unreviewed, rolling out r195035.
Caused 1-3% PLT regression on iOS
Reverted changeset:
"Part 2/2: Stop using USE(CFNETWORK) path on iOS"
https://bugs.webkit.org/show_bug.cgi?id=142540
http://trac.webkit.org/changeset/195035
- 2:44 PM Changeset in webkit [195078] by
-
- 15 edits2 adds in trunk
WK2: Request completion candidates when needed
https://bugs.webkit.org/show_bug.cgi?id=153040
-and corresponding-
rdar://problem/24155631
Reviewed by Enrica Casucci and Tim Horton.
Source/WebCore:
Helper functions for stringForCandidateRequest() and
handleAcceptedCandidate()
- editing/Editor.cpp:
(WebCore::candidateRangeForSelection):
(WebCore::candidateWouldReplaceText):
Request candidates for the word that is currently being typed so long as the
candidate would replace that word. Otherwise, use String().
(WebCore::Editor::stringForCandidateRequest):
When a candidate has been accepted, insert the text.
(WebCore::Editor::handleAcceptedCandidate):
- editing/Editor.h:
Source/WebKit2:
Mac needs to support postLayoutData in order to have some layout-related
editing information to request candidates. This patch re-shuffles some items
in the struct so that they can be shared by Mac and iOS, and it adds 3 new
items for Mac only.
- Shared/EditorState.cpp:
(WebKit::EditorState::encode):
(WebKit::EditorState::decode):
(WebKit::EditorState::PostLayoutData::encode):
(WebKit::EditorState::PostLayoutData::decode):
- Shared/EditorState.h:
Request and handle candidates here in WebViewImpl, and cache the
m_lastStringForCandidateRequest so that we can ensure the results we receive
were received in a timely enough manner that they are still for the same
String.
- UIProcess/Cocoa/WebViewImpl.h:
- UIProcess/Cocoa/WebViewImpl.mm:
(WebKit::WebViewImpl::selectionDidChange):
When selection changes, request new candidates.
(WebKit::WebViewImpl::requestCandidatesForSelectionIfNeeded):
Once candidates have been received, we ask the sharedSpellChecker to show
them.
(WebKit::WebViewImpl::handleRequestedCandidates):
If a candidate is accepted, we ask the WebProcess to accept it, so we start
by converting the NSTextCheckingResult to a WebCore::TextCheckingResult.
(WebKit::textCheckingResultFromNSTextCheckingResult):
(WebKit::WebViewImpl::handleAcceptedCandidate):
Ask the WebProcess to handle accepting the candidate.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::handleAcceptedCandidate):
- UIProcess/WebPageProxy.h:
- WebProcess/WebPage/WebPage.h:
(WebKit::WebPage:: handleAcceptedCandidate):
- WebProcess/WebPage/WebPage.messages.in:
Now that Mac has some postLayoutData in the EditorState, fill that in in
platformEditorState().
- WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::WebPage::platformEditorState):
Ask WebCore::Editor to handle the accepted candidate.
(WebKit::WebPage::handleAcceptedCandidate):
LayoutTests:
Getting updated EditorState in platformEditorState causes some extra layout
to happen, so now the layout test results for WK2 reflect the results that we
already see on iOS for this test and they reflect the render tree as it is
when you load the page in browser.
- platform/mac/fast/dom/focus-contenteditable-expected.txt:
WebKit 1 is not affected by these new results, so this adds WK-1 only results
that match the old Mac results.
- platform/mac-wk1/fast/dom: Added.
- platform/mac-wk1/fast/dom/focus-contenteditable-expected.txt: Added.
- 2:44 PM Changeset in webkit [195077] by
-
- 2 edits in trunk/Source/JavaScriptCore
Unreviewed mark passing es6 tests as no longer failing.
- tests/es6.yaml:
- 2:33 PM Changeset in webkit [195076] by
-
- 4 edits in trunk/Tools
Standardize the usage of "branch" vs. "branchName". https://bugs.webkit.org/show_bug.cgi?id=152982
Reviewed by Daniel Bates.
In an earlier patch we started using the name "branch" to indicate a branch object, whereas
"branchName" implies that the variable or property in question is simply a string.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
(BuildbotQueueView.prototype._popoverLinesForCommitRange): Change branch to branchName.
(BuildbotQueueView.prototype._presentPopoverForRevisionRange): Change branch to branch.name.
(BuildbotQueueView.prototype._revisionContentWithPopoverForIteration): Change branch to branchName.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
(Trac.prototype.commitsOnBranch): Change branch to branchName.
(Trac.prototype._convertCommitInfoElementToObject): Ditto.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockTrac.js:
(MockTrac): Ditto.
- 1:42 PM Changeset in webkit [195075] by
-
- 5 edits15 adds in trunk
Disallow use of Geolocation service from unique origins
https://bugs.webkit.org/show_bug.cgi?id=153102
<rdar://problem/23055645>
Reviewed by Alexey Proskuryakov.
Source/WebCore:
Tests: fast/dom/Geolocation/dataURL-getCurrentPosition.html
fast/dom/Geolocation/dataURL-watchPosition.html
fast/dom/Geolocation/srcdoc-getCurrentPosition.html
fast/dom/Geolocation/srcdoc-watchPosition.html
http/tests/security/sandboxed-iframe-geolocation-getCurrentPosition.html
http/tests/security/sandboxed-iframe-geolocation-watchPosition.html
- Modules/geolocation/Geolocation.cpp:
(WebCore::Geolocation::securityOrigin): Convenience function to get the SecurityOrigin object
associated with this script execution context.
(WebCore::Geolocation::startRequest): Notify requester POSITION_UNAVAILABLE when requested
from a document with a unique origin.
- Modules/geolocation/Geolocation.h:
- page/SecurityOrigin.h:
(WebCore::SecurityOrigin::canRequestGeolocation): Added.
LayoutTests:
- fast/dom/Geolocation/dataURL-getCurrentPosition-expected.txt: Added.
- fast/dom/Geolocation/dataURL-getCurrentPosition.html: Added.
- fast/dom/Geolocation/dataURL-watchPosition-expected.txt: Added.
- fast/dom/Geolocation/dataURL-watchPosition.html: Added.
- fast/dom/Geolocation/srcdoc-getCurrentPosition-expected.txt: Added.
- fast/dom/Geolocation/srcdoc-getCurrentPosition.html: Added.
- fast/dom/Geolocation/srcdoc-watchPosition-expected.txt: Added.
- fast/dom/Geolocation/srcdoc-watchPosition.html: Added.
- http/tests/security/resources/checkThatPositionErrorCallbackIsCalledWithPositionUnavailableForGeolocationMethod.js: Added.
(done):
(logMessage):
(didReceivePosition):
(didReceiveError):
(checkThatPositionErrorCallbackIsCalledWithPositionUnavailableForGeolocationMethod):
(markupToCheckThatPositionErrorCallbackIsCalledWithPositionUnavailableForGeolocationMethod):
(dataURLToCheckThatPositionErrorCallbackIsCalledWithPositionUnavailableForGeolocationMethod):
- http/tests/security/resources/sandboxed-iframe-geolocation-getCurrentPosition.html: Added.
- http/tests/security/resources/sandboxed-iframe-geolocation-watchPosition.html: Added.
- http/tests/security/sandboxed-iframe-geolocation-getCurrentPosition-expected.txt: Added.
- http/tests/security/sandboxed-iframe-geolocation-getCurrentPosition.html: Added.
- http/tests/security/sandboxed-iframe-geolocation-watchPosition-expected.txt: Added.
- http/tests/security/sandboxed-iframe-geolocation-watchPosition.html: Added.
- 1:40 PM Changeset in webkit [195074] by
-
- 3 edits in trunk/Source/WebCore
[XSS Auditor] Extract attribute truncation logic and formalize string canonicalization
https://bugs.webkit.org/show_bug.cgi?id=152874
Reviewed by Brent Fulgham.
Derived from Blink patch (by Tom Sepez <tsepez@chromium.org>):
<https://src.chromium.org/viewvc/blink?revision=176339&view=revision>
Extract the src-like and script-like attribute truncation logic into independent functions
towards making it more straightforward to re-purpose this logic. Additionally, formalize the
concept of string canonicalization as a member function that consolidates the process of
decoding URL escape sequences, truncating the decoded string (if applicable), and removing
characters that are considered noise.
- html/parser/XSSAuditor.cpp:
(WebCore::truncateForSrcLikeAttribute): Extracted from XSSAuditor::decodedSnippetForAttribute().
(WebCore::truncateForScriptLikeAttribute): Ditto.
(WebCore::XSSAuditor::init): Write in terms of XSSAuditor::canonicalize().
(WebCore::XSSAuditor::filterCharacterToken): Updated to make use of formalized canonicalization methods.
(WebCore::XSSAuditor::filterScriptToken): Ditto.
(WebCore::XSSAuditor::filterObjectToken): Ditto.
(WebCore::XSSAuditor::filterParamToken): Ditto.
(WebCore::XSSAuditor::filterEmbedToken): Ditto.
(WebCore::XSSAuditor::filterAppletToken): Ditto.
(WebCore::XSSAuditor::filterFrameToken): Ditto.
(WebCore::XSSAuditor::filterInputToken): Ditto.
(WebCore::XSSAuditor::filterButtonToken): Ditto.
(WebCore::XSSAuditor::eraseDangerousAttributesIfInjected): Ditto.
(WebCore::XSSAuditor::eraseAttributeIfInjected): Updated code to use early return style and avoid an unnecessary string
comparison when we know that a src attribute was injected.
(WebCore::XSSAuditor::canonicalizedSnippetForTagName): Renamed; formerly known as XSSAuditor::decodedSnippetForName(). Updated
to make use of XSSAuditor::canonicalize().
(WebCore::XSSAuditor::snippetFromAttribute): Renamed; formerly known as XSSAuditor::decodedSnippetForAttribute(). Moved
truncation logic from here to WebCore::truncateFor{Script, Src}LikeAttribute.
(WebCore::XSSAuditor::canonicalize): Added.
(WebCore::XSSAuditor::canonicalizedSnippetForJavaScript): Added.
(WebCore::canonicalize): Deleted.
(WebCore::XSSAuditor::decodedSnippetForName): Deleted.
(WebCore::XSSAuditor::decodedSnippetForAttribute): Deleted.
(WebCore::XSSAuditor::decodedSnippetForJavaScript): Deleted.
- html/parser/XSSAuditor.h: Define enum class for the various attribute truncation styles.
- 1:37 PM Changeset in webkit [195073] by
-
- 4 edits2 adds in trunk
[XSS Auditor] Partial bypass when web server collapses path components
https://bugs.webkit.org/show_bug.cgi?id=152872
Reviewed by Brent Fulgham.
Merged from Blink (patch by Tom Sepez <tsepez@chromium.org>):
<https://src.chromium.org/viewvc/blink?revision=167610&view=revision>
Source/WebCore:
Test: http/tests/security/xssAuditor/embed-tag-in-path-unterminated.html
- html/parser/XSSAuditor.cpp:
(WebCore::isNonCanonicalCharacter):
(WebCore::XSSAuditor::init):
(WebCore::XSSAuditor::decodedSnippetForName):
(WebCore::XSSAuditor::decodedSnippetForAttribute):
(WebCore::XSSAuditor::decodedSnippetForJavaScript):
(WebCore::fullyDecodeString): Deleted.
LayoutTests:
- http/tests/security/xssAuditor/embed-tag-in-path-unterminated-expected.txt: Added.
- http/tests/security/xssAuditor/embed-tag-in-path-unterminated.html: Added.
- http/tests/security/xssAuditor/intercept/.htaccess:
- 1:31 PM Changeset in webkit [195072] by
-
- 2 edits in trunk/Source/WebCore
imported/blink/editing/text-iterator/read-past-cloned-first-letter.html
crashes
https://bugs.webkit.org/show_bug.cgi?id=153104
-and corresponding-
rdar://problem/24155631
Reviewed by Simon Fraser.
Though we merged the Blink test, we never merged Blink patch that fixed this
bug. So this is a merge of https://github.com/ChromiumWebApps/blink/commit/5a0d23d4368c661f621364339fde66b41ef019e5
- editing/TextIterator.cpp:
(WebCore::SimplifiedBackwardsTextIterator::handleFirstLetter):
- 1:11 PM Changeset in webkit [195071] by
-
- 2 edits in trunk/LayoutTests
[iOS Simulator] fast/table/003.html failing
https://bugs.webkit.org/show_bug.cgi?id=152444
Unreviewed gardening.
- platform/ios-simulator/fast/table/003-expected.txt:
- 12:45 PM Changeset in webkit [195070] by
-
- 10 edits1 add in trunk
[ES6] Support subclassing Function.
https://bugs.webkit.org/show_bug.cgi?id=153081
Reviewed by Geoffrey Garen.
Source/JavaScriptCore:
This patch enables subclassing the Function object. It also fixes an existing
bug that prevented users from subclassing functions that have a function in
the superclass's prototype property.
- bytecompiler/NodesCodegen.cpp:
(JSC::ClassExprNode::emitBytecode):
- runtime/FunctionConstructor.cpp:
(JSC::constructWithFunctionConstructor):
(JSC::constructFunction):
(JSC::constructFunctionSkippingEvalEnabledCheck):
- runtime/FunctionConstructor.h:
- runtime/JSFunction.cpp:
(JSC::JSFunction::create):
- runtime/JSFunction.h:
(JSC::JSFunction::createImpl):
- runtime/JSFunctionInlines.h:
(JSC::JSFunction::createWithInvalidatedReallocationWatchpoint):
(JSC::JSFunction::JSFunction): Deleted.
- tests/stress/class-subclassing-function.js: Added.
LayoutTests:
Rebasline tests with the new clearer error message.
- js/class-syntax-extends-expected.txt:
- js/script-tests/class-syntax-extends.js:
- 12:09 PM Changeset in webkit [195069] by
-
- 6 edits2 adds in trunk
ASSERTION FAILED: !newRelayoutRoot.container() !newRelayoutRoot.container()->needsLayout() in WebCore::FrameView::scheduleRelayoutOfSubtree https://bugs.webkit.org/show_bug.cgi?id=151605#c1
Reviewed by David Hyatt.
Do not let RenderMultiColumnSet/RenderFlowThread mark ancestors dirty while updating scrollbars
for overflow content. While updating scrollbars, we only layout descendants so marking parents dirty
is unnecessary and could lead to an invalid dirty state.
Source/WebCore:
Test: fast/multicol/body-stuck-with-dirty-bit-with-columns.html
- rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::layoutSpecialExcludedChild):
- rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::invalidateRegions):
- rendering/RenderFlowThread.h:
- rendering/RenderMultiColumnSet.cpp:
(WebCore::RenderMultiColumnSet::prepareForLayout):
LayoutTests:
- fast/multicol/body-stuck-with-dirty-bit-with-columns-expected.txt: Added.
- fast/multicol/body-stuck-with-dirty-bit-with-columns.html: Added.
- 11:19 AM Changeset in webkit [195068] by
-
- 15 edits2 adds in branches/safari-601-branch
Merge r194672. rdar://problem/24154288
- 11:19 AM Changeset in webkit [195067] by
-
- 43 edits3 copies1 add in branches/safari-601-branch
Merge r192200. rdar://problem/24154288
- 11:18 AM Changeset in webkit [195066] by
-
- 9 edits in branches/safari-601-branch/Source
Merge r189135. rdar://problem/24154288
- 11:18 AM Changeset in webkit [195065] by
-
- 2 edits in branches/safari-601-branch/Source/WebInspectorUI
<rdar://problem/24189668> REGRESSION: The Web Inspector isn't visible when its associated menu item is selected via the "Develop" menu
- UserInterface/Base/Main.js:
(WebInspector._dockedResizerMouseDown.dockedResizerDrag): Change let to var.
- 11:13 AM Changeset in webkit [195064] by
-
- 8 edits3 adds in trunk
Avoid downloading the wrong image for <picture> elements.
https://bugs.webkit.org/show_bug.cgi?id=153027
Reviewed by Dean Jackson.
Source/WebCore:
Added test in fast/picture.
- html/HTMLImageElement.cpp:
(WebCore::HTMLImageElement::HTMLImageElement):
(WebCore::HTMLImageElement::~HTMLImageElement):
(WebCore::HTMLImageElement::createForJSConstructor):
(WebCore::HTMLImageElement::bestFitSourceFromPictureElement):
(WebCore::HTMLImageElement::insertedInto):
(WebCore::HTMLImageElement::removedFrom):
(WebCore::HTMLImageElement::pictureElement):
(WebCore::HTMLImageElement::setPictureElement):
(WebCore::HTMLImageElement::width):
- html/HTMLImageElement.h:
(WebCore::HTMLImageElement::hasShadowControls):
- html/HTMLPictureElement.h:
- html/parser/HTMLConstructionSite.cpp:
(WebCore::HTMLConstructionSite::createHTMLElement):
- html/parser/HTMLPreloadScanner.cpp:
(WebCore::TokenPreloadScanner::StartTagScanner::processAttribute):
Images that are built underneath a <picture> element are now connected
to that picture element via a setPictureNode call from the parser. This
ensures that the correct <source> elements are examined before checking the image.
This connection between images and their picture owners is handled using a static
HashMap in HTMLImageElement. This connection is made both from the parser and from
DOM insertions, and the map is queried now instead of looking directly at the
image's parentNode().
LayoutTests:
- fast/picture/image-picture-loads-1x-expected.txt: Added.
- fast/picture/image-picture-loads-1x.html: Added.
- 11:05 AM Changeset in webkit [195063] by
-
- 2 edits in trunk/Websites/webkit.org
Use a 2px border radius instead to look good on 2x devices as well as 1x.
- wp-content/themes/webkit/style.css:
(.timeline .time):
- 11:01 AM Changeset in webkit [195062] by
-
- 1 edit6 adds in trunk/Tools
Add a unit test to test BuildbotQueueView._appendPendingRevisionCount. https://bugs.webkit.org/show_bug.cgi?id=152910
Reviewed by Daniel Bates.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockBuildbotQueue.js: Added.
(MockBuildbotQueue): Added. Mock BuildbotQueue object that doesn't need to talk to an actual Buildbot server.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockBuildbotQueueView.js: Added.
(MockBuildbotQueueView): Added. Mock BuildbotQueueView object that returns a pre-specified _latestProductiveIteration without
the need to talk to a real Buildbot server.
(MockBuildbotQueueView.prototype._latestProductiveIteration): Added. Returns a pre-specified _latestProductiveIteration
without the need to talk to a real Buildbot server.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockTrac.js: Added.
(MockTrac): Added. Mock Trac constructor that has pre-populated "recordedCommits" and does not need to talk to a real Trac
server.
(MockTrac.prototype.get oldestRecordedRevisionNumber): Added. Returns a pre-specified revision.
(MockTrac.prototype.get latestRecordedRevisionNumber): Ditto.
(MockTrac.prototype.loadMoreHistoricalData): Added. Overrides the real loadMoreHistoricalData so that we don't waste time
trying to talk to Trac.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/index.html: Added. Web page container for
QUnit unit tests.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js: Added. QUnit unit tests.
- 11:00 AM Changeset in webkit [195061] by
-
- 2 edits in trunk/Websites/webkit.org
Fix hairline crack on 1x devices between arrow and time label.
- wp-content/themes/webkit/style.css:
(.timeline .content):
(.timeline .time):
- 10:18 AM Changeset in webkit [195060] by
-
- 1 edit1 move1 add1 delete in trunk/LayoutTests
Move streams/webkitGetUserMedia-shadowing-then.html to fast/mediastream
https://bugs.webkit.org/show_bug.cgi?id=152973
Reviewed by Brent Fulgham.
Moved the test, made it asynchronous to ensure that the error callback is called.
- fast/mediastream/webkitGetUserMedia-shadowing-then-expected.txt: Renamed from LayoutTests/streams/webkitGetUserMedia-shadowing-then-expected.txt.
- fast/mediastream/webkitGetUserMedia-shadowing-then.html: Renamed from LayoutTests/streams/webkitGetUserMedia-shadowing-then.html.
- 9:50 AM Changeset in webkit [195059] by
-
- 15 edits1 delete in trunk
Unreviewed, rolling out r195002.
https://bugs.webkit.org/show_bug.cgi?id=153098
Crashes many/most editing tests (Requested by ap on #webkit).
Reverted changeset:
"WK2: Request completion candidates when needed"
https://bugs.webkit.org/show_bug.cgi?id=153040
http://trac.webkit.org/changeset/195002
- 9:32 AM Changeset in webkit [195058] by
-
- 5 edits2 adds in trunk
[GTK] [EFL] Hyphenation can never work in practice due to requirements on lang tags
https://bugs.webkit.org/show_bug.cgi?id=147310
Patch by Martin Robinson <mrobinson@igalia.com> on 2016-01-14
Reviewed by Michael Catanzaro.
Source/WebCore:
Test: platform/gtk/fast/text/hyphenate-flexible-locales.html
- platform/text/hyphen/HyphenationLibHyphen.cpp: Make locale matching for dictionary
selection a lot looser by matching case insensitively, matching multiple dictionaries
when only the language is specified, and ignoring the difference between '_' and '-' in
the locale name.
(WebCore::scanDirectoryForDicionaries): Now produce HashMap of Vectors instead of a single
path for each locale. Also add alternate entries to handle different ways of specifying
the locale.
(WebCore::scanTestDictionariesDirectoryIfNecessary): Update to handle the difference
in HashMap type.
(WebCore::availableLocales): Ditto.
(WebCore::canHyphenate): Also look for the lowercased version of the locale.
(WebCore::AtomicStringKeyedMRUCache<RefPtr<HyphenationDictionary>>::createValueForKey):
Key on the dictionary path now so that we can load more than one dictionary per locale.
(WebCore::lastHyphenLocation): Iterate through each matched dictionary in turn.
LayoutTests:
Update some baselines and add a GTK+ specific test for locale variations.
- platform/gtk/fast/text/hyphenate-flexible-locales-expected.html: Added.
- platform/gtk/fast/text/hyphenate-flexible-locales.html: Added.
- platform/gtk/fast/text/hyphenate-locale-expected.png: We now properly hyphenate
text with the 'en' locale.
- platform/gtk/fast/text/hyphenate-locale-expected.txt:
- 8:31 AM Changeset in webkit [195057] by
-
- 2 edits in trunk/Tools
[CMake][GTK] CMake Error: Could not create named generator Eclipse CDT4 - Ninja
https://bugs.webkit.org/show_bug.cgi?id=132599
Patch by Nikos Andronikos <nikos.andronikos-webkit@cisra.canon.com.au> on 2016-01-14
Reviewed by Michael Catanzaro.
Check if cmake Ninja generators are installed.
- Scripts/webkitdirs.pm:
(canUseNinjaGenerator):
(canUseEclipseNinjaGenerator):
(generateBuildSystemFromCMakeProject):
(canUseEclipse): Deleted.
- 6:42 AM Changeset in webkit [195056] by
-
- 2 edits in trunk/Source/WebKit2
[EFL][GTK][SeccompFilter] Fix build break when enabling --seccomp-filters
https://bugs.webkit.org/show_bug.cgi?id=153094
Reviewed by Csaba Osztrogonác.
diskCacheDirectory and cookiePersistentStoragePath were removed by r192796.
But SyscallPolicy::addDefaultWebProcessPolicy has added directory permission
to the removed paths.
It looks two paths needs to be handled by network process.
- Shared/linux/SeccompFilters/SyscallPolicy.cpp:
(WebKit::SyscallPolicy::addDefaultWebProcessPolicy): Deleted.
- 6:22 AM Changeset in webkit [195055] by
-
- 3 edits2 adds in releases/WebKitGTK/webkit-2.10
Merge r192947 - Null dereference loading Blink layout test fast/loader/unload-mutation-crash.html
https://bugs.webkit.org/show_bug.cgi?id=149305
<rdar://problem/22747892>
Reviewed by Brent Fulgham.
Source/WebCore:
Add an extra guard to replaceDocument() against rude JS in unload event handlers.
Test: fast/loader/unload-mutation-crash.html
- loader/DocumentWriter.cpp:
(WebCore::DocumentWriter::replaceDocument):
(WebCore::DocumentWriter::begin):
LayoutTests:
This test case is from Blink r180918:
https://codereview.chromium.org/495743003
- fast/loader/unload-mutation-crash-expected.txt: Added.
- fast/loader/unload-mutation-crash.html: Added.
- 5:59 AM Changeset in webkit [195054] by
-
- 2 edits in releases/WebKitGTK/webkit-2.10/Source/WebCore
Merge r192880 - [GTK] ASSERTION FAILED: m_table running /webkit2/BackForwardList/navigation in Debug build
https://bugs.webkit.org/show_bug.cgi?id=151700
Reviewed by Martin Robinson.
This happens when the frame notifies its observers that the page
will be detached. The m_table that asserts is the
FrameDestructionObserver HashSet. It happens when clearing the
GObject DOM cache wrappers during frame destruction, and there's a
Document object wrapped whose last reference is held by the DOM
wrapper. In that case, the Document object is destroyed while the
frame is being destroyed. Deleting the wrapper objects after the
frame destruction fixes the crash.
- bindings/gobject/DOMObjectCache.cpp:
- 5:54 AM Changeset in webkit [195053] by
-
- 3 edits2 adds in releases/WebKitGTK/webkit-2.10
Merge r192854 - Amazon.com Additional Information links aren't clickable
https://bugs.webkit.org/show_bug.cgi?id=151401
<rdar://problem/23454261>
Reviewed by Darin Adler.
Source/WebCore:
The cause of this issue is that the painting order is different from the hittest order so we can end up
with visible but unreachable content. To fix this, the executation flow of hittest has been reordered.
According to the paint system, which renders the webpage from the bottom RenderLayer to the top, contents
are rendered before floats. Hence, for the hittest, which determines the hitted location from top RenderLayer
to the bottom, should do it reversedly. Now, hittest will first test floats then contents.
Test: fast/block/float/hit-test-on-overlapping-floats.html
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::nodeAtPoint):
LayoutTests:
- fast/block/float/hit-test-on-overlapping-floats-expected.txt: Added.
- fast/block/float/hit-test-on-overlapping-floats.html: Added.
- 5:53 AM Changeset in webkit [195052] by
-
- 7 edits3 adds in releases/WebKitGTK/webkit-2.10
Merge r192844 - Null dereference loading Blink layout test http/tests/misc/detach-during-notifyDone.html
https://bugs.webkit.org/show_bug.cgi?id=149309
<rdar://problem/22748363>
Reviewed by Brent Fulgham.
Source/WebCore:
A weird order of event execution introduced by the test case will kill the webpage in a
subframe of the page while executing its |frame.loader().checkLoadCompleteForThisFrame()|.
Therefore, any frames comes after the failing subframe will have no page. Check it before
calling to those frames' |frame.loader().checkLoadCompleteForThisFrame()|, otherwise the
assertion in |frame.loader().checkLoadCompleteForThisFrame()| will fail.
Test: http/tests/misc/detach-during-notifyDone.html
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::checkLoadComplete):
Source/WebKit/mac:
- WebView/WebDataSource.mm:
(WebDataSourcePrivate::~WebDataSourcePrivate):
Refine the assertion to treat <rdar://problem/9673866>.
Source/WebKit2:
Callback of bundle clients could kill the documentloader. Therefore, make a copy
of the navigationID before invoking the callback.
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::dispatchDidChangeLocationWithinPage):
(WebKit::WebFrameLoaderClient::dispatchDidPushStateWithinPage):
(WebKit::WebFrameLoaderClient::dispatchDidReplaceStateWithinPage):
(WebKit::WebFrameLoaderClient::dispatchDidPopStateWithinPage):
(WebKit::WebFrameLoaderClient::dispatchDidFailLoad):
(WebKit::WebFrameLoaderClient::dispatchDidFinishDocumentLoad):
(WebKit::WebFrameLoaderClient::dispatchDidFinishLoad):
LayoutTests:
The test case is from Blink r175601:
https://codereview.chromium.org/317513002
The test case will generate a set of weird ordering events that affects the documentLoader:
- The subframe finishes loading, and since the frame’s testRunner is not set to wait until
done, WebKitTestRunner stops the load (by calling WKBundlePageStopLoading()).
- This causes the in-progress XHR to be aborted, which causes its readyState to become DONE
(this bug doesn’t always reproduce because sometimes the XHR has already finished before the
frame finishes loading).
- The onreadystatechange callback is executed, which sets innerHTML on the parent frame.
- Setting innerHTML disconnects the subframe, nulling out its DocumentLoader.
- We return to WebFrameLoaderClient::dispatchDidFinishLoad() from step #1, but now the
FrameLoader’s DocumentLoader is null. And WebKit crashes here.
Note that steps 2-4 happen synchronously inside WebFrameLoaderClient::dispatchDidFinishLoad().
- http/tests/misc/detach-during-notifyDone-expected.txt: Added.
- http/tests/misc/detach-during-notifyDone.html: Added.
- http/tests/misc/resources/detached-frame.html: Added.
- 5:49 AM Changeset in webkit [195051] by
-
- 7 edits in releases/WebKitGTK/webkit-2.10
Merge r192810 - location.origin is undefined in a web worker
https://bugs.webkit.org/show_bug.cgi?id=151614
Reviewed by Darin Adler.
Source/WebCore:
Expose location.origin to web workers, as per:
https://html.spec.whatwg.org/multipage/workers.html#workerlocation
This behavior is consistent with the behavior of Firefox and Chrome.
Test: fast/workers/worker-location.html
- workers/WorkerLocation.cpp:
(WebCore::WorkerLocation::origin):
- workers/WorkerLocation.h:
- workers/WorkerLocation.idl:
LayoutTests:
Update existing layout test to confirm the existence of location.origin when in a
WorkerGlobalScope.
- fast/workers/resources/worker-location.js:
- fast/workers/worker-location-expected.txt:
- 5:40 AM Changeset in webkit [195050] by
-
- 2 edits in releases/WebKitGTK/webkit-2.10/Source/WebKit2
Merge r192792 - [GTK] UI process crash when the screensaver DBus proxy is being created while the web view is destroyed
https://bugs.webkit.org/show_bug.cgi?id=151653
Reviewed by Martin Robinson.
We correctly cancel the proxy creation, but when the async ready
callback is called, the view could be destroyed already. In that
case g_dbus_proxy_new_for_bus_finish() will return nullptr and
fail with cancelled error, but we are using the passed web view
without checking first if the creation failed or not.
- UIProcess/API/gtk/WebKitWebViewBase.cpp:
(screenSaverProxyCreatedCallback):
- 5:39 AM Changeset in webkit [195049] by
-
- 5 edits4 adds in releases/WebKitGTK/webkit-2.10
Merge r192788 - Browser does not fall back to SVG attribute value when CSS style value is invalid or not supported
https://bugs.webkit.org/show_bug.cgi?id=147932
Patch by Antoine Quint <Antoine Quint> on 2015-11-29
Reviewed by Dean Jackson.
Source/WebCore:
Instead of returning an SVGPaint object of type SVG_PAINTTYPE_UNKNOWN when we encounter an SVG paint
value that cannot be parsed, we now returnnullptrwhich will cause that value to be ignored and
let another paint value in the cascade be used instead. This is the same approach used for SVGColor.
Since we're removing the only call site forSVGPaint::createUnknown(), we remove that function entirely.
Tests: svg/css/invalid-color-cascade.svg
svg/css/invalid-paint-cascade.svg
- css/SVGCSSParser.cpp:
(WebCore::CSSParser::parseSVGPaint):
- svg/SVGPaint.h:
(WebCore::SVGPaint::createUnknown): Deleted.
LayoutTests:
Testing that we correctly fall back to the presentation attribute for SVGPaint and SVGColor values
specified with an invalid keyword in astyleattribute. We also update the expected output for
svg/css/svg-attribute-parser-mode.html which is now in line with values returned by Firefox and
Chrome, where we correctly use the default value instead of null objects, which was definitely
an error.
- svg/css/invalid-color-cascade-expected.svg: Added.
- svg/css/invalid-color-cascade.svg: Added.
- svg/css/invalid-paint-cascade-expected.svg: Added.
- svg/css/invalid-paint-cascade.svg: Added.
- svg/css/script-tests/svg-attribute-parser-mode.js:
- svg/css/svg-attribute-parser-mode-expected.txt:
- 5:29 AM Changeset in webkit [195048] by
-
- 3 edits in releases/WebKitGTK/webkit-2.10/Source/WebCore
Merge r192787 - Use SVGTransform::SVGTransformType instead of an unsigned short
https://bugs.webkit.org/show_bug.cgi?id=151637
Reviewed by Brady Eidson.
Make 'type' more strongly typed.
- svg/SVGTransformable.cpp:
(WebCore::SVGTransformable::parseTransformValue):
(WebCore::parseAndSkipType):
(WebCore::SVGTransformable::parseTransformType):
(WebCore::SVGTransformable::parseTransformAttribute):
- svg/SVGTransformable.h:
- 5:23 AM Changeset in webkit [195047] by
-
- 2 edits in releases/WebKitGTK/webkit-2.10/Source/WebCore
Merge r192775 - [GTK] Do not use the WebCore garbage collector timer
https://bugs.webkit.org/show_bug.cgi?id=151623
Reviewed by Martin Robinson.
Now that garbage collector timers have been implemented in
JavaScriptCore for glib, we don't need to use another Timer in WebCore.
- bindings/js/GCController.cpp:
(WebCore::GCController::garbageCollectSoon):
(WebCore::GCController::garbageCollectNowIfNotDoneRecently):
- 5:22 AM Changeset in webkit [195046] by
-
- 10 edits in releases/WebKitGTK/webkit-2.10/Source/JavaScriptCore
Merge r192773 - [GLIB] Implement garbage collector timers
https://bugs.webkit.org/show_bug.cgi?id=151391
Reviewed by Žan Doberšek.
Add GLib implementation using GSource.
- heap/EdenGCActivityCallback.cpp:
- heap/FullGCActivityCallback.cpp:
- heap/GCActivityCallback.cpp:
(JSC::GCActivityCallback::GCActivityCallback):
(JSC::GCActivityCallback::scheduleTimer):
(JSC::GCActivityCallback::cancelTimer):
- heap/GCActivityCallback.h:
- heap/Heap.cpp:
(JSC::Heap::Heap):
- heap/HeapTimer.cpp:
(JSC::HeapTimer::HeapTimer):
(JSC::HeapTimer::~HeapTimer):
(JSC::HeapTimer::timerDidFire):
- heap/HeapTimer.h:
- heap/IncrementalSweeper.cpp:
(JSC::IncrementalSweeper::IncrementalSweeper):
(JSC::IncrementalSweeper::scheduleTimer):
(JSC::IncrementalSweeper::cancelTimer):
- heap/IncrementalSweeper.h:
- 5:17 AM Changeset in webkit [195045] by
-
- 3 edits in releases/WebKitGTK/webkit-2.10/Source/JavaScriptCore
Merge r192721 - GC timers should carry on gracefully when Heap claims it grew from GC.
<https://webkit.org/b/151521>
Reviewed by Mark Lam.
TL;DR the Heap "extra memory" reporting APIs are hard to use 100% correctly
and GC scheduling shouldn't break if someone makes a mistake with it.
The JSC::Heap allows you to report an extra memory cost for any GC object.
This is reported first when allocating the memory, and then each time the
object is visited during the marking phase.
When reporting an allocation, it's added to the Heap's "bytes allocated in
this cycle" counter. This contributes to the computed heap size at the start
of a collection.
When visiting a GC object that reports extra memory, it's added to the Heap's
"extra memory visited in this collection" counter. This contributes to the
computed heap size at the end of a collection.
As you can see, this means that visiting more memory than we said we allocated
can lead to the Heap thinking it's bigger after a collection than it was before.
Clients of this API do some sketchy things to compute costs, for instance
StringImpl cost is determined by dividing the number of bytes used for the
characters, and dividing it by the StringImpl's ref count. Since a JSString
could be backed by any StringImpl, any code that modifies a StringImpl's
ref count during collection will change the extra memory reported by all
JSString objects that wrap that StringImpl.
So anyways...
The object death rate, which is the basis for when to schedule the next
collection is computed like so:
deathRate = (sizeBeforeGC - sizeAfterGC) / sizeBeforeGC
This patch adds a safety mechanism that returns a zero death rate when the Heap
claims it grew from collection.
- heap/EdenGCActivityCallback.cpp:
(JSC::EdenGCActivityCallback::deathRate):
- heap/FullGCActivityCallback.cpp:
(JSC::FullGCActivityCallback::deathRate):
- 5:14 AM Changeset in webkit [195044] by
-
- 4 edits2 adds in releases/WebKitGTK/webkit-2.10
Merge r192770 - Checks for buffer-overflows when reading characters from textRun
https://bugs.webkit.org/show_bug.cgi?id=151055
<rdar://problem/23251789>
Patch by Pranjal Jumde <pjumde@apple.com> on 2015-11-25
Reviewed by Myles C. Maxfield.
Source/WebCore:
Prevents an off by one error when adding the last font data to the GlyphBuffer.
- Source/WebCore/platform/graphics/WidthIterator.cpp:
- Source/WebCore/platform/graphics/FontCascade.cpp:
LayoutTests:
- dom/html/level1/core/151055_asan.html:
- dom/html/level1/core/151055_asan-expected.txt:
- 5:12 AM Changeset in webkit [195043] by
-
- 4 edits in releases/WebKitGTK/webkit-2.10/Source/WebCore
Merge r192758 - Hardening against CSSSelector double frees
<http://webkit.org/b/56124>
<rdar://problem/9119036>
Reviewed by Antti Koivisto.
Add some security assertions to catch this issue if it ever
happens in Debug builds, and make changes in
CSSSelector::~CSSSelector() and
CSSSelectorList::deleteSelectors() to prevent obvious issues if
they're ever called twice in Release builds.
No new tests because we don't know how to reproduce this.
- css/CSSSelector.cpp:
(WebCore::CSSSelector::CSSSelector): Initialize
m_destructorHasBeenCalled.
- css/CSSSelector.h:
(WebCore::CSSSelector::m_destructorHasBeenCalled): Add bitfield.
(WebCore::CSSSelector::CSSSelector): Initialize
m_destructorHasBeenCalled.
(WebCore::CSSSelector::~CSSSelector): Add security assertion
that this is never called twice. Clear out any fields that
would have caused us to dereference an object twice.
- css/CSSSelectorList.cpp:
(WebCore::CSSSelectorList::deleteSelectors): Clear
m_selectorArray when freeing the memory to which it was
pointing. This prevents re-entrancy issues or calling this
method twice on the same thread. Also restructure the for()
loop to prevent calling CSSSelector::isLastInSelectorList()
after CSSSelector::~CSSSelector() has been called (via CRBug
241892).
- 5:02 AM Changeset in webkit [195042] by
-
- 4 edits in releases/WebKitGTK/webkit-2.10
Merge r192747 - Fix crash in ~WebProcessPool when using Geolocation with useNetworkProcess=true
https://bugs.webkit.org/show_bug.cgi?id=151532
Reviewed by Benjamin Poulain.
Source/WebKit2:
- UIProcess/WebGeolocationManagerProxy.cpp:
(WebKit::WebGeolocationManagerProxy::processPoolDestroyed):
(WebKit::WebGeolocationManagerProxy::processDidClose):
When a WebProcessPool is destroyed, only call stopUpdating if m_updateRequesters.clear()
stopped the updating, like we do in WebGeolocationManagerProxy::removeRequester.
Otherwise, call setEnableHighAccuracy if needed, also like we do in WebGeolocationManagerProxy::removeRequester.
Tools:
- TestWebKitAPI/Tests/WebKit2/Geolocation.cpp:
(TestWebKitAPI::GeolocationTransitionToHighAccuracyStateTracker::eventsChanged):
(TestWebKitAPI::TEST):
(TestWebKitAPI::GeolocationTransitionToLowAccuracyStateTracker::eventsChanged):
(TestWebKitAPI::GeolocationTransitionToHighAccuracyStateTracker::GeolocationTransitionToHighAccuracyStateTracker): Deleted.
(TestWebKitAPI::GeolocationTransitionToLowAccuracyStateTracker::GeolocationTransitionToLowAccuracyStateTracker): Deleted.
Properly load about:blank in all WebViews to clean up. Without this change, we had a
Geolocation provider stopping after its state tracker was destroyed with its stack frame,
so it was calling a function on a test object that had gone out of scope.
Also, call WKContextSetUsesNetworkProcess(context, true) to show what crash this fixed,
but that will become the default soon and that call will be removed.
- 4:30 AM Changeset in webkit [195041] by
-
- 2 edits in releases/WebKitGTK/webkit-2.10/Source/WebCore/platform/gtk/po
Merge r192737 - [GTK] [l10n] Updated Italian translation of WebKitGTK+
https://bugs.webkit.org/show_bug.cgi?id=151543
Unreviewed.
Patch by Milo Casagrande <milo@milo.name> on 2015-11-22
- it.po:
- 4:27 AM Changeset in webkit [195040] by
-
- 2 edits in releases/WebKitGTK/webkit-2.10/Source/WebCore
Merge r192724 - [GTK] Off-by-one error in getStyleContext()
https://bugs.webkit.org/show_bug.cgi?id=151524
Reviewed by Carlos Garcia Campos.
GtkWidgetPath* path = gtk_widget_path_new();
gtk_widget_path_append_type(path, widgetType);
...
gtk_widget_path_iter_add_class(path, 0, GTK_STYLE_CLASS_BUTTON);
gtk_widget_path_iter_add_class(path, 1, "text-button");
Only one widget type was appended to the widget path, so the maximum valid index is 0. This
code means to add both style classes to the first widget type in the widget path, so the
second call should use index 0 rather than index 1.
This caused no bug in practice, because when the index is invalid,
gtk_widget_path_iter_add_class() automatically changes the index to the last valid position
in the widget path -- in this case, 0. This is routinely done with -1 as a convention for
specifying the last position in the widget path.
- rendering/RenderThemeGtk.cpp:
(WebCore::getStyleContext):
- 4:26 AM Changeset in webkit [195039] by
-
- 3 edits in releases/WebKitGTK/webkit-2.10/Source/WebCore
Merge r192723 - [GTK] Warning spam from GtkStyleContext
https://bugs.webkit.org/show_bug.cgi?id=151520
Reviewed by Carlos Garcia Campos.
Audit every use of gtk_style_context_get_* to fix compatibility with GTK+ 3.19. Some of
these were already fine and are only changed for clarity.
Company: gtk_style_context_get() (and _get_padding/border/color()) should only ever be
called with the same state as gtk_style_context_get_state()
Company: usually that's a simple replacing of the old state (like in the trace you posted)
Company: sometimes it requires calling gtk_style_context_set_sate() with the right state
first
Company: and in very rare cases it needs a gtk_style_context_save() before the set_state(),
too
- platform/gtk/ScrollbarThemeGtk.cpp:
(WebCore::adjustRectAccordingToMargin):
- rendering/RenderThemeGtk.cpp:
(gtk_css_section_print):
(WebCore::getStyleContext):
(WebCore::RenderThemeGtk::initMediaColors):
(WebCore::renderButton):
(WebCore::getComboBoxMetrics):
(WebCore::RenderThemeGtk::paintMenuList):
(WebCore::RenderThemeGtk::paintTextField):
(WebCore::RenderThemeGtk::paintProgressBar):
(WebCore::spinButtonArrowSize):
(WebCore::RenderThemeGtk::adjustInnerSpinButtonStyle):
(WebCore::styleColor):
- 4:23 AM Changeset in webkit [195038] by
-
- 8 edits in releases/WebKitGTK/webkit-2.10/Source/WebKit2
Merge r192702 - A hung webpage pretends to be responsive if you scroll
https://bugs.webkit.org/show_bug.cgi?id=151518
Reviewed by Sam Weinig.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::sendWheelEvent):
(WebKit::WebPageProxy::didReceiveEvent): Don't treat wheel events as
starting or stopping the responsiveness timer. Wheel events usually
process on the event dispatch thread, which responds even if the main
thread is hung.
Instead, send an out-of-band ping to the main thread to verify that
it is still responsive and we'll be able to paint and respond to clicks
after scrolling.
- UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::sendMainThreadPing):
(WebKit::WebProcessProxy::didReceiveMainThreadPing):
- UIProcess/WebProcessProxy.h:
- UIProcess/WebProcessProxy.messages.in: UI process support for pinging
the main thread in the web process.
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::mainThreadPing):
- WebProcess/WebProcess.h:
- WebProcess/WebProcess.messages.in: Web process support for responding
to pings.
- 4:14 AM Changeset in webkit [195037] by
-
- 7 edits4 adds in releases/WebKitGTK/webkit-2.10
Merge r192641 - REGRESSION(r8780): Backwards delete by word incorrectly appends deleted text to kill ring, should be prepend
https://bugs.webkit.org/show_bug.cgi?id=151300
Reviewed by Darin Adler.
Source/WebCore:
Over 11 years ago, someone was in a big hurry to fix a bunch
of emacs keybindings bugs, and accidentally regressed the kill ring
behavior for backwards-delete-word. It should prepend to the beginning.
This patch fixes the regression and cleans up the kill ring-related
code in Editor and commands. It also adds some tests to cover the
regressed code a bit better.
Tests: editing/pasteboard/emacs-killring-alternating-append-prepend.html
editing/pasteboard/emacs-killring-backward-delete-prepend.html
- editing/Editor.cpp:
Use more explicit names for insertion mode parameters and member variables.
(WebCore::Editor::deleteWithDirection):
(WebCore::Editor::performDelete):
(WebCore::Editor::addRangeToKillRing):
(WebCore::Editor::addTextToKillRing):
Only one call site for now, but another will be added in a dependent fix.
(WebCore::Editor::addToKillRing): Deleted.
- editing/Editor.h:
- editing/TypingCommand.cpp:
(WebCore::TypingCommand::TypingCommand):
(WebCore::TypingCommand::deleteKeyPressed):
(WebCore::TypingCommand::forwardDeleteKeyPressed):
(WebCore::TypingCommand::doApply):
- editing/TypingCommand.h:
- platform/mac/KillRingMac.mm:
(WebCore::KillRing::append):
(WebCore::KillRing::prepend):
It turns out that the native API implicitly clears the kill sequence when
alternating between prepend and append operations. Its behavior does not match
what Sublime Text or Emacs do in this case. Clear the previous operation flag
to prevent this behavior from happening.
LayoutTests:
- editing/pasteboard/emacs-killring-alternating-append-prepend-expected.txt: Added.
- editing/pasteboard/emacs-killring-alternating-append-prepend.html: Added.
- editing/pasteboard/emacs-killring-backward-delete-prepend-expected.txt: Added.
- editing/pasteboard/emacs-killring-backward-delete-prepend.html: Added.
- 4:08 AM Changeset in webkit [195036] by
-
- 5 edits5 adds in releases/WebKitGTK/webkit-2.10
Merge r192604 - [WK1] Crash loading Blink layout test fast/dom/Window/property-access-on-cached-window-after-frame-removed.html
https://bugs.webkit.org/show_bug.cgi?id=150198
<rdar://problem/23136026>
Reviewed by Brent Fulgham.
Source/WebCore:
Test: fast/dom/Window/property-access-on-cached-window-after-frame-removed.html
Properties of a contentWindow could be accessed even if the frame who owns the window is
detached. Therefore, check whether the document loader is still alive before using it.
- page/PerformanceTiming.cpp:
(WebCore::PerformanceTiming::monotonicTimeToIntegerMilliseconds):
Tools:
- WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
(WTR::TestRunner::inspectorTestStubURL):
Since WebInspectorUI.framework is not available for iOS, the framework
and corresponding functions are disabled in iOS.
LayoutTests:
- fast/dom/Window/666869-expected.txt: Added.
- fast/dom/Window/666869.html: Added.
Test case is from Mozilla.
- fast/dom/Window/property-access-on-cached-window-after-frame-removed-expected.txt: Added.
- fast/dom/Window/property-access-on-cached-window-after-frame-removed.html: Added.
- fast/dom/Window/resources/window-property-collector.js: Added.
(collectProperties):
(emitExpectedResult):
(collectPropertiesHelper):
Test case is from Blink r168256:
https://codereview.chromium.org/131113003
- platform/mac-wk2/TestExpectations:
- 4:04 AM Changeset in webkit [195035] by
-
- 2 edits in trunk/Source/WTF
Part 2/2: Stop using USE(CFNETWORK) path on iOS
<https://webkit.org/b/142540>
Original patch by Antti Koivisto <Antti Koivisto> on 2015-03-10
Reviewed by Chris Dumez.
- wtf/Platform.h: Turn off USE(CFNETWORK) for PLATFORM(IOS).
- 4:03 AM Changeset in webkit [195034] by
-
- 4 edits in releases/WebKitGTK/webkit-2.10/Source/WebCore
Merge r192582 - Null dereference in Performance::Performance(WebCore::Frame*)
https://bugs.webkit.org/show_bug.cgi?id=151390
Reviewed by Brady Eidson.
Based on the stack trace, it appears the DocumentLoader can be null
when constructing the Performance object. This patch thus adds a null
check before trying to dereference it.
No new tests, was not able to reproduce.
- page/DOMWindow.cpp:
(WebCore::DOMWindow::navigator):
(WebCore::DOMWindow::performance):
- page/Performance.cpp:
(WebCore::Performance::Performance):
(WebCore::Performance::scriptExecutionContext):
- page/Performance.h:
- 4:02 AM Changeset in webkit [195033] by
-
- 2 edits in releases/WebKitGTK/webkit-2.10/Source/WebCore
Merge r192574 - [Cairo] SolidStroke broken in drawLine after r191658
https://bugs.webkit.org/show_bug.cgi?id=151385
Patch by Alejandro G. Castro <alex@igalia.com> on 2015-11-18
Reviewed by Carlos Garcia Campos.
Fix the drawLine function after r191658, we have to make sure the
color is set when line is SolidStroke.
- platform/graphics/cairo/GraphicsContextCairo.cpp:
(WebCore::GraphicsContext::drawLine):
- 4:01 AM Changeset in webkit [195032] by
-
- 3 edits in releases/WebKitGTK/webkit-2.10/Tools
Merge r192568 - [XvfbDriver] Fail to run all layout tests when X server started with -displayfd option
https://bugs.webkit.org/show_bug.cgi?id=151135
Reviewed by Darin Adler.
The XvfbDriver uses the x server command line to check the
displays that are currently in use. This doesn't work when X
server was started with -displayfd option. This option is used to let
the server find the display id available that is written to the
given file descriptor. With this option xorg doesn't need to
create the lock files in tmp either. The -displayfd option is also
available in Xvfb, so we could use it too. That would simplify the
code, fixing also race conditions between the check for available
displays and Xvfb opening the connection, we wouldn't need to wait
for 4 seconds after launching Xvfb, and all lock files we are
using won't be needed either.
- Scripts/webkitpy/port/xvfbdriver.py:
(XvfbDriver._xvfb_pipe): Helper function to create the pipe, only
needed to be overriden by unit tests.
(XvfbDriver._xvfb_read_display_id): Helper function to read from
the pipe, only needed to be overriden by unit tests.
(XvfbDriver._xvfb_run): Run Xvfb with -displayfd option, using a
pipe to read the display id.
(XvfbDriver._start): Call _xvfb_run() and remove the code to run
Xvfb for a given display.
(XvfbDriver.stop): Remove code to release and delete file locks.
- Scripts/webkitpy/port/xvfbdriver_unittest.py:
(XvfbDriverTest.make_driver):
(XvfbDriverTest.test_start):
(XvfbDriverTest.test_start_arbitrary_worker_number):
(XvfbDriverTest.test_stop):
(XvfbDriverTest.assertDriverStartSuccessful): Deleted.
(XvfbDriverTest): Deleted.
(XvfbDriverTest.test_stop.FakeXvfbProcess): Deleted.
- 3:58 AM Changeset in webkit [195031] by
-
- 3 edits in releases/WebKitGTK/webkit-2.10
Merge r192567 - Null dereference loading Blink layout test editing/execCommand/indent-button-crash.html
https://bugs.webkit.org/show_bug.cgi?id=151187
Reviewed by Darin Adler.
Source/WebCore:
This is a merge of Blink r174671:
https://codereview.chromium.org/291143002
Fixes imported/blink/editing/execCommand/indent-button-crash.html.
- editing/ApplyBlockElementCommand.cpp:
(WebCore::ApplyBlockElementCommand::doApply):
LayoutTests:
Unskip the test.
- platform/gtk/TestExpectations:
- platform/win/TestExpectations:
- 3:56 AM Changeset in webkit [195030] by
-
- 3 edits in releases/WebKitGTK/webkit-2.10/Source/WebKit2
Merge r192528 - A window with a hung tab waits 5s before closing
https://bugs.webkit.org/show_bug.cgi?id=151319
Reviewed by Anders Carlsson.
I manually tested that I did not break unload events upon window close
by running run-webkit-httpd and invoking a 1x1 image load of
http://127.0.0.1:8000/navigation/resources/save-Ping.php from an unload
handler.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::tryClose): Use the sudden termination bit to
close without waiting for a response.
- UIProcess/WebProcessProxy.h:
(WebKit::WebProcessProxy::isSuddenTerminationEnabled): Expose the bit.
- 3:51 AM Changeset in webkit [195029] by
-
- 2 edits in releases/WebKitGTK/webkit-2.10/Source/JavaScriptCore
Merge r192527 - Reserved VM pool established in r187125 is likely too conservative
https://bugs.webkit.org/show_bug.cgi?id=151351
Reviewed by Filip Pizlo.
Reduce the VM allocation reserved pool from 25% to 15% for ARM32.
- jit/ExecutableAllocator.h:
- 3:31 AM Changeset in webkit [195028] by
-
- 3 edits2 adds in releases/WebKitGTK/webkit-2.10
Merge r192513 - ASSERTION FAILED: contentSize >= 0 in WebCore::RenderFlexibleBox::adjustChildSizeForMinAndMax
https://bugs.webkit.org/show_bug.cgi?id=151025
Reviewed by Darin Adler.
Source/WebCore:
Negative margins could make RenderFlexibleBox compute negative
intrinsic sizes. Clamp intrinsic sizes to 0.
Test: css3/flexbox/negative-margins-assert.html
- rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::computeIntrinsicLogicalWidths):
LayoutTests:
- css3/flexbox/negative-margins-assert-expected.txt: Added.
- css3/flexbox/negative-margins-assert.html: Added.
- 3:30 AM Changeset in webkit [195027] by
-
- 9 edits in releases/WebKitGTK/webkit-2.10/Source/WebKit2
Merge r192510 - [GTK] Web Process crashes on reparenting a WebView with AC mode on
https://bugs.webkit.org/show_bug.cgi?id=151139
Reviewed by Mario Sanchez Prada.
When the web view is reparented, the widget is first unrealized,
and then realized again when added to the new parent. In the
second realize, the old redirected XComposite window is destroyed
and a new one is created, but the web process is still using the
old redirected window ID. As soon as the redirected window is
destroyed and the web process tries to use the window ID, it
crashes due to a BadDrawable X error. We have to notify the web
process as soon as the web view is unrealized to stop using the
current window ID and exit accelerated compositing mode until a
new window ID is given. This notification needs to be synchronous,
because the window can be destroyed in the UI process before the
message is received in the web process.
- UIProcess/API/gtk/WebKitWebViewBase.cpp:
(webkitWebViewBaseRealize): Add an assert to ensure we never have
a redirected window when the view is realized. Also check drawing
area is not nullptr, since it can be destroyed at any time if the
web process crashes.
(webkitWebViewBaseUnrealize): Call
DrawingAreaProxyImpl::destroyNativeSurfaceHandleForCompositing()
and destroy the redirected XComposite window.
- UIProcess/DrawingAreaProxyImpl.cpp:
(WebKit::DrawingAreaProxyImpl::destroyNativeSurfaceHandleForCompositing):
Send DestroyNativeSurfaceHandleForCompositing synchronous messsage
to the web process.
- UIProcess/DrawingAreaProxyImpl.h:
- WebProcess/WebPage/DrawingArea.h:
- WebProcess/WebPage/DrawingArea.messages.in: Add
DestroyNativeSurfaceHandleForCompositing message.
- WebProcess/WebPage/DrawingAreaImpl.cpp:
(WebKit::DrawingAreaImpl::destroyNativeSurfaceHandleForCompositing):
Set the native surface handler for compositing to 0 to reset it.
- WebProcess/WebPage/DrawingAreaImpl.h:
- WebProcess/WebPage/gtk/LayerTreeHostGtk.cpp:
(WebKit::LayerTreeHostGtk::makeContextCurrent): Return false
early always when layer tree context ID is 0, even if we already
have a context.
(WebKit::LayerTreeHostGtk::setNativeSurfaceHandleForCompositing):
Cancel any pending layer flush when setting a new handler.
- 3:27 AM Changeset in webkit [195026] by
-
- 3 edits2 adds in releases/WebKitGTK/webkit-2.10
Merge r192499 - Source/WebCore:
Fixes the buffer-overflow when reading characters from textRun
https://bugs.webkit.org/attachment.cgi?bugid=151055
<rdar://problem/23251789>
Patch by Pranjal Jumde <pjumde@apple.com> on 2015-11-16
Reviewed by Brent Fulgham.
- platform/graphics/FontCascade.cpp
LayoutTests:
Checks for buffer-overflows when reading characters from textRun
https://bugs.webkit.org/attachment.cgi?bugid=151055
<rdar://problem/23251789>
Patch by Pranjal Jumde <pjumde@apple.com> on 2015-11-16
Reviewed by Brent Fulgham.
- webgl/1.0.3/151055_asan-expected.txt
- webgl/1.0.3/151055_asan.html
- 3:26 AM Changeset in webkit [195025] by
-
- 2 edits in releases/WebKitGTK/webkit-2.10/Source/WebKit2
Merge r192496 - WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction calls an std::function after it's been moved from
https://bugs.webkit.org/show_bug.cgi?id=151248
Reviewed by Darin Adler.
Like r188287, calling an empty std::function results in a std::bad_function_call
exception being thrown when sendSync is failed.
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
- 3:14 AM Changeset in webkit [195024] by
-
- 4 edits4 adds in releases/WebKitGTK/webkit-2.10
Merge r192477 - Null-pointer dereference in WebCore::firstEditablePositionAfterPositionInRoot
https://bugs.webkit.org/show_bug.cgi?id=151288
<rdar://problem/23450367>
Reviewed by Darin Adler.
Source/WebCore:
Some problematic organization of body element could cause problems to JustifyRight
and Indent commnads.
Tests: editing/execCommand/justify-right-then-indent-with-problematic-body.html
editing/execCommand/justify-right-with-problematic-body.html
- editing/CompositeEditCommand.cpp:
(WebCore::CompositeEditCommand::moveParagraphContentsToNewBlockIfNecessary):
Assertion at l1017 is not held anymore with the testcase:
editing/execCommand/justify-right-with-problematic-body.html.
Therefore, change it to an if statement.
Also, add a guardance before calling insertNewDefaultParagraphElementAt()
as insertNodeAt() requires an editable position.
(WebCore::CompositeEditCommand::moveParagraphWithClones):
Add a guardance before calling insertNodeAt() as it requires an editable position.
- editing/htmlediting.cpp:
(WebCore::firstEditablePositionAfterPositionInRoot):
(WebCore::lastEditablePositionBeforePositionInRoot):
LayoutTests:
- editing/execCommand/justify-right-then-indent-with-problematic-body-expected.txt: Added.
- editing/execCommand/justify-right-then-indent-with-problematic-body.html: Added.
- editing/execCommand/justify-right-with-problematic-body-expected.txt: Added.
- editing/execCommand/justify-right-with-problematic-body.html: Added.
- 3:11 AM Changeset in webkit [195023] by
-
- 2 edits in releases/WebKitGTK/webkit-2.10/Source/WebCore
Merge r192458 - Regression(r188820): Downloads of data URLs is broken
https://bugs.webkit.org/show_bug.cgi?id=150900
rdar://problem/23399223
Reviewed by Darin Adler.
No test, the current test infrastructure only allows testing policy decisions, not the actual download.
- loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::continueAfterContentPolicy):
Use normal download path for data URLs instead of trying to convert the main resource load.
Since we decode data URLs locally there is no associated resource load on WebKit side.
- 3:09 AM Changeset in webkit [195022] by
-
- 10 edits in releases/WebKitGTK/webkit-2.10
Merge r192444 - Always render at least a device pixel line when border/outline width > 0.
https://bugs.webkit.org/show_bug.cgi?id=151269
This matches Firefox behaviour.
Reviewed by Simon Fraser.
Source/WebCore:
Existing test is modified to reflect the new behaviour.
- css/StyleBuilderConverter.h:
(WebCore::StyleBuilderConverter::convertLineWidth):
- rendering/BorderEdge.cpp:
(WebCore::BorderEdge::BorderEdge): Deleted.
- rendering/BorderEdge.h:
LayoutTests:
- fast/borders/hidpi-border-width-flooring-expected.html:
- fast/borders/hidpi-border-width-flooring.html:
- 2:56 AM Changeset in webkit [195021] by
-
- 3 edits2 adds in releases/WebKitGTK/webkit-2.10
Merge r192433 - Element::focus() should acquire the ownership of Frame.
https://bugs.webkit.org/show_bug.cgi?id=150204
<rdar://problem/23136794>
Reviewed by Brent Fulgham.
Source/WebCore:
The FrameSelection::setSelection method sometimes releases the last reference to a frame.
When this happens, the Element::updateFocusAppearance would attempt to use dereferenced memory.
Instead, we should ensure that the Frame lifetime is guaranteed to extend through the duration
of the method call.
Test: editing/selection/focus-iframe-removal-crash.html
- dom/Element.cpp:
(WebCore::Element::updateFocusAppearance):
LayoutTests:
- editing/selection/focus-iframe-removal-crash-expected.txt: Added.
- editing/selection/focus-iframe-removal-crash.html: Added.
- 2:20 AM Changeset in webkit [195020] by
-
- 4 edits2 adds in releases/WebKitGTK/webkit-2.10
Merge r192389 - Ignore visited background color when deciding if the input renderer needs to be painted natively.
https://bugs.webkit.org/show_bug.cgi?id=151211
rdar://problem/21449823
Reviewed by Antti Koivisto.
Source/WebCore:
Test: fast/css/pseudo-visited-background-color-on-input.html
- rendering/RenderTheme.cpp:
(WebCore::RenderTheme::isControlStyled):
- rendering/style/RenderStyle.h:
LayoutTests:
- fast/css/pseudo-visited-background-color-on-input-expected.html: Added.
- fast/css/pseudo-visited-background-color-on-input.html: Added.
- 2:07 AM Changeset in webkit [195019] by
-
- 4 edits6 adds in releases/WebKitGTK/webkit-2.10
Merge r192369 - popstate event should be dispatched asynchronously
https://bugs.webkit.org/show_bug.cgi?id=36202
<rdar://problem/7761279>
Based on an original patch by Mihai Parparita <mihaip@chromium.org>.
Reviewed by Brent Fulgham.
Source/WebCore:
Tests: fast/loader/remove-iframe-during-history-navigation-different.html
fast/loader/remove-iframe-during-history-navigation-same.html
fast/loader/stateobjects/popstate-is-asynchronous.html
- dom/Document.cpp:
(WebCore::Document::enqueuePopstateEvent):
Use enqueueWindowEvent().
LayoutTests:
- fast/loader/remove-iframe-during-history-navigation-different-expected.txt: Added.
- fast/loader/remove-iframe-during-history-navigation-different.html: Added.
Imported from Blink.
- fast/loader/remove-iframe-during-history-navigation-same-expected.txt: Added.
- fast/loader/remove-iframe-during-history-navigation-same.html: Added.
Ditto.
- fast/loader/stateobjects/popstate-fires-on-history-traversal.html:
Modified to account for popstate firing asynchronously.
- fast/loader/stateobjects/popstate-is-asynchronous-expected.txt: Added.
- fast/loader/stateobjects/popstate-is-asynchronous.html: Added.
Based on Mihai's original test. Modified to pass in current WebKit.
- 2:00 AM Changeset in webkit [195018] by
-
- 3 edits2 adds in releases/WebKitGTK/webkit-2.10
Merge r192316 - Crash loading Blink layout test fast/parser/strip-script-attrs-on-input.html
https://bugs.webkit.org/show_bug.cgi?id=150201
<rdar://problem/23136478>
Reviewed by Brent Fulgham.
Source/WebCore:
Test: fast/parser/strip-script-attrs-on-input.html
- html/parser/HTMLTreeBuilder.cpp:
(WebCore::HTMLTreeBuilder::processStartTagForInBody):
Get the attribute after calling
HTMLConstructionSite::insertSelfClosingHTMLElement(), as this may
mutate the token's attributes.
LayoutTests:
- fast/parser/strip-script-attrs-on-input-expected.txt: Added.
- fast/parser/strip-script-attrs-on-input.html: Added.
- 1:56 AM Changeset in webkit [195017] by
-
- 2 edits in releases/WebKitGTK/webkit-2.10/Source/WebKit2
Merge r192311 - [GTK] Runtime critical warnings when closing a page containing windowed plugins
https://bugs.webkit.org/show_bug.cgi?id=151132
Reviewed by Martin Robinson.
This is because our plugin widget, that is a GtkPlug (derived from
GtkWindow), can receive the delete-event signal before
NetscapePlugin::platformDestroy is called. The delete-event
signal, by default, destroys the window when the signal is not
handled. So, after the delete-event the GtkPlug is destroyed, but
our pointer hasn't been reset. We can handle the delete-event
using gtk_widget_hide_on_delete as callback, so that the plugin
widget is hidden instead of destroyed.
- WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:
(WebKit::NetscapePlugin::platformPostInitializeWindowed):
- 1:52 AM Changeset in webkit [195016] by
-
- 4 edits2 adds in releases/WebKitGTK/webkit-2.10
Merge r192281 - Crash running webaudio/panner-loop.html
https://bugs.webkit.org/show_bug.cgi?id=150200
<rdar://problem/23136282>
Reviewed by Jer Noble.
Source/WebCore:
Test: webaudio/panner-loop.html
This is based on the changes in Blink r164822:
https://codereview.chromium.org/130003002
Avoid infinitely recursing on audio nodes by keeping track of which nodes we've already
visited.
- Modules/webaudio/PannerNode.cpp:
(WebCore::PannerNode::pullInputs): Pass set of visited nodes so we don't revisit
nodes we've already serviced.
(WebCore::PannerNode::notifyAudioSourcesConnectedToNode): Accept visitedNodes argument
so we can avoid revisiting nodes. Check if the current node has already been visited
before processing it.
- Modules/webaudio/PannerNode.h:
LayoutTests:
This is based on the changes in Blink r164822:
https://codereview.chromium.org/130003002
- webaudio/panner-loop-expected.txt: Added.
- webaudio/panner-loop.html: Added.
- 1:49 AM Changeset in webkit [195015] by
-
- 3 edits2 adds in releases/WebKitGTK/webkit-2.10
Merge r192275 - Continuations with anonymous wrappers inside misplaces child renderers.
https://bugs.webkit.org/show_bug.cgi?id=150908
When a child is appended to an inline container and the beforeChild is not a direct child, but
it is inside a generated subtree, we need to special case the inline split to form continuation.
RenderInline::splitInlines() assumes that beforeChild is always a direct child of the current
inline container. However when beforeChild type requires wrapper content (such as table cells), the DOM and the
render tree get out of sync. In such cases, we need to ensure that both the beforeChild and its siblings end up
in the correct generated block.
Reviewed by Darin Adler and David Hyatt.
Source/WebCore:
Test: fast/inline/continuation-with-anon-wrappers.html
- rendering/RenderInline.cpp:
(WebCore::RenderInline::splitInlines):
(WebCore::RenderInline::addChildToContinuation):
LayoutTests:
- fast/inline/continuation-with-anon-wrappers-expected.txt: Added.
- fast/inline/continuation-with-anon-wrappers.html: Added.
- 1:45 AM Changeset in webkit [195014] by
-
- 9 edits36 adds in releases/WebKitGTK/webkit-2.10
Merge r191011 - Anonymous table objects: inline parent box requires inline-table child.
https://bugs.webkit.org/show_bug.cgi?id=150090
Reviewed by David Hyatt.
According to the CSS2.1 specification, if a child needs anonymous table wrapper
and the child's parent is an inline box, the generated table needs to be inline-table.
(inline-block and block parents generate non-inline table)
Import W3C CSS2.1 anonymous table tests.
Source/WebCore:
- rendering/RenderElement.cpp:
(WebCore::RenderElement::childRequiresTable):
(WebCore::RenderElement::addChild):
- rendering/RenderElement.h:
- rendering/RenderInline.cpp:
(WebCore::RenderInline::newChildIsInline):
(WebCore::RenderInline::addChildIgnoringContinuation):
(WebCore::RenderInline::addChildToContinuation):
- rendering/RenderInline.h:
- rendering/RenderTable.cpp:
(WebCore::RenderTable::createAnonymousWithParentRenderer):
LayoutTests:
- css2.1/tables/table-anonymous-objects-177.xht: Added.
- css2.1/tables/table-anonymous-objects-178.xht: Added.
- css2.1/tables/table-anonymous-objects-179.xht: Added.
- css2.1/tables/table-anonymous-objects-180.xht: Added.
- css2.1/tables/table-anonymous-objects-181.xht: Added.
- css2.1/tables/table-anonymous-objects-189.xht: Added.
- css2.1/tables/table-anonymous-objects-190.xht: Added.
- css2.1/tables/table-anonymous-objects-191.xht: Added.
- css2.1/tables/table-anonymous-objects-192.xht: Added.
- css2.1/tables/table-anonymous-objects-193.xht: Added.
- css2.1/tables/table-anonymous-objects-194.xht: Added.
- css2.1/tables/table-anonymous-objects-195.xht: Added.
- css2.1/tables/table-anonymous-objects-196.xht: Added.
- css2.1/tables/table-anonymous-objects-205.xht: Added.
- css2.1/tables/table-anonymous-objects-206.xht: Added.
- css2.1/tables/table-anonymous-objects-207.xht: Added.
- css2.1/tables/table-anonymous-objects-208.xht: Added.
- platform/mac/css2.1/tables/table-anonymous-objects-177-expected.txt: Added.
- platform/mac/css2.1/tables/table-anonymous-objects-178-expected.txt: Added.
- platform/mac/css2.1/tables/table-anonymous-objects-179-expected.txt: Added.
- platform/mac/css2.1/tables/table-anonymous-objects-180-expected.txt: Added.
- platform/mac/css2.1/tables/table-anonymous-objects-181-expected.txt: Added.
- platform/mac/css2.1/tables/table-anonymous-objects-189-expected.txt: Added.
- platform/mac/css2.1/tables/table-anonymous-objects-190-expected.txt: Added.
- platform/mac/css2.1/tables/table-anonymous-objects-191-expected.txt: Added.
- platform/mac/css2.1/tables/table-anonymous-objects-192-expected.txt: Added.
- platform/mac/css2.1/tables/table-anonymous-objects-193-expected.txt: Added.
- platform/mac/css2.1/tables/table-anonymous-objects-194-expected.txt: Added.
- platform/mac/css2.1/tables/table-anonymous-objects-195-expected.txt: Added.
- platform/mac/css2.1/tables/table-anonymous-objects-196-expected.txt: Added.
- platform/mac/css2.1/tables/table-anonymous-objects-205-expected.txt: Added.
- platform/mac/css2.1/tables/table-anonymous-objects-206-expected.txt: Added.
- platform/mac/css2.1/tables/table-anonymous-objects-207-expected.txt: Added.
- platform/mac/css2.1/tables/table-anonymous-objects-208-expected.txt: Added.
- 1:35 AM Changeset in webkit [195013] by
-
- 18 edits25 adds in releases/WebKitGTK/webkit-2.10
Merge r192270 - alert, confirm, prompt, showModalDialog should be forbidden during page close and navigation
https://bugs.webkit.org/show_bug.cgi?id=150980
Reviewed by Chris Dumez.
Source/WebCore:
Tests: fast/events/beforeunload-alert.html
fast/events/beforeunload-confirm.html
fast/events/beforeunload-prompt.html
fast/events/beforeunload-showModalDialog.html
fast/events/pagehide-alert.html
fast/events/pagehide-confirm.html
fast/events/pagehide-prompt.html
fast/events/pagehide-showModalDialog.html
fast/events/unload-alert.html
fast/events/unload-confirm.html
fast/events/unload-prompt.html
fast/events/unload-showModalDialog.html
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::stopLoading): Factored out a helper function for
unload event processing.
(WebCore::FrameLoader::handleUnloadEvents): Forbid prompts in unload
events just like we do in beforeunload events, and for the same reasons.
(WebCore::FrameLoader::handleBeforeUnloadEvent): Updated for renames.
- loader/FrameLoader.h:
- page/DOMWindow.cpp:
(WebCore::DOMWindow::print):
(WebCore::DOMWindow::alert):
(WebCore::DOMWindow::confirm):
(WebCore::DOMWindow::prompt):
(WebCore::DOMWindow::showModalDialog): Updated for renames. Refactored
some of this code to handle null pages more cleanly. In particular, we
sometimes used to treat null page as "everything is permitted" -- but it
is best practice in a permissions context to treat lack of information
as no permission granted rather than all permissions granted. (I don't
know of a way to trigger this condition in practice.)
- page/Page.cpp:
(WebCore::Page::Page):
(WebCore::Page::forbidPrompts):
(WebCore::Page::allowPrompts):
(WebCore::Page::arePromptsAllowed): Renamed to make these functions
reflect their new, broader context.
(WebCore::Page::incrementFrameHandlingBeforeUnloadEventCount): Deleted.
(WebCore::Page::decrementFrameHandlingBeforeUnloadEventCount): Deleted.
(WebCore::Page::isAnyFrameHandlingBeforeUnloadEvent): Deleted.
- page/Page.h:
LayoutTests:
Added tests to cover the matrix of [ alert, confirm, prompt, showModalDialog ] x [ beforeunload, unload, pagehide ].
- fast/events/beforeunload-alert-expected.txt: Added.
- fast/events/beforeunload-alert.html: Added.
- fast/events/beforeunload-confirm-expected.txt: Added.
- fast/events/beforeunload-confirm.html: Added.
- fast/events/beforeunload-prompt-expected.txt: Added.
- fast/events/beforeunload-prompt.html: Added.
- fast/events/beforeunload-showModalDialog-expected.txt: Added.
- fast/events/beforeunload-showModalDialog.html: Added.
- fast/events/onunload-expected.txt:
- fast/events/onunload-not-on-body-expected.txt:
- fast/events/onunload-window-property-expected.txt:
- fast/events/pagehide-alert-expected.txt: Added.
- fast/events/pagehide-alert.html: Added.
- fast/events/pagehide-confirm-expected.txt: Added.
- fast/events/pagehide-confirm.html: Added.
- fast/events/pagehide-prompt-expected.txt: Added.
- fast/events/pagehide-prompt.html: Added.
- fast/events/pagehide-showModalDialog-expected.txt: Added.
- fast/events/pagehide-showModalDialog.html: Added.
- fast/events/pageshow-pagehide-on-back-cached-expected.txt:
- fast/events/pageshow-pagehide-on-back-uncached-expected.txt:
- fast/events/resources/prompt-landing-page.html: Added.
- fast/events/unload-alert-expected.txt: Added.
- fast/events/unload-alert.html: Added.
- fast/events/unload-confirm-expected.txt: Added.
- fast/events/unload-confirm.html: Added.
- fast/events/unload-prompt-expected.txt: Added.
- fast/events/unload-prompt.html: Added.
- fast/events/unload-showModalDialog-expected.txt: Added.
- fast/events/unload-showModalDialog.html: Added.
- platform/wk2/TestExpectations: WebKit2 can't handle showModalDialog tests.
- compositing/iframes/page-cache-layer-tree-expected.txt:
- fast/dom/Geolocation/notimer-after-unload-expected.txt:
- fast/history/timed-refresh-in-cached-frame-expected.txt:
- fast/loader/frames-with-unload-handlers-in-page-cache-expected.txt:
- fast/loader/page-dismissal-modal-dialogs-expected.txt: These were
pre-existing tests that tried to alert during unload.
- 1:17 AM Changeset in webkit [195012] by
-
- 3 edits in releases/WebKitGTK/webkit-2.10/Source/JavaScriptCore
Merge r192267 - X86_64 support for compareDouble(DoubleCondition, FPRegisterID left, FPRegisterID right, RegisterID dest)
https://bugs.webkit.org/show_bug.cgi?id=151009
Reviewed by Filip Pizlo.
Added compareDouble() macro assembler function and the supporting setnp_r() and setp_r() X86 assembler functions.
Hand tested.
- assembler/MacroAssemblerX86_64.h:
(JSC::MacroAssemblerX86_64::compare64):
(JSC::MacroAssemblerX86_64::compareDouble):
(JSC::MacroAssemblerX86_64::branch64):
- assembler/X86Assembler.h:
(JSC::X86Assembler::setnz_r):
(JSC::X86Assembler::setnp_r):
(JSC::X86Assembler::setp_r):
(JSC::X86Assembler::cdq):
- 12:50 AM Changeset in webkit [195011] by
-
- 4 edits in trunk/Source
[Win] Remove workarounds for fixed bugs in fmod and pow.
https://bugs.webkit.org/show_bug.cgi?id=153071
Reviewed by Brent Fulgham.
Source/WebCore:
Compile fix, help MSVC pick correct pow overload.
- rendering/shapes/BoxShape.cpp:
(WebCore::adjustRadiusForMarginBoxShape):
Source/WTF:
The bugs have been fixed in the MSVC CRT, and we can remove the workarounds.
- wtf/MathExtras.h:
(wtf_fmod): Deleted.
(wtf_pow): Deleted.
- 12:39 AM Changeset in webkit [195010] by
-
- 28 edits3 adds in trunk
Fix problems with cross-origin redirects
https://bugs.webkit.org/show_bug.cgi?id=116075
Reviewed by Daniel Bates.
LayoutTests/imported/w3c:
Rebasing test expectations.
These tests cannot work as expected as WTR/DRT block access to www2.localhost and example.not.
- web-platform-tests/XMLHttpRequest/send-redirect-bogus-expected.txt:
- web-platform-tests/XMLHttpRequest/send-redirect-to-cors-expected.txt:
- web-platform-tests/XMLHttpRequest/send-redirect-to-non-cors-expected.txt:
Source/WebCore:
Merging https://chromium.googlesource.com/chromium/blink/+/7ea774e478f84f355748108d2aaabca15355d512 by Ken Russell
Same origin redirect responses leading to cross-origin requests were checked as cross-origin redirect responses.
Introduced ClientRequestedCredentials to manage whether credentials are needed or not in the cross-origin request.
In addition to Blink patch, it was needed to update some loaders with the newly introduced ClientRequestedCredentials parameter.
Added the clearing of "Accept-Encoding" header from cross-origin requests as Mac HTTP network layer is adding it for same-origin requests.
Test: http/tests/xmlhttprequest/access-control-and-redirects-async-same-origin.html
- loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::startLoadingMainResource): Added new security parameter (from Blink patch).
- loader/DocumentThreadableLoader.cpp:
(WebCore::DocumentThreadableLoader::redirectReceived): Updated checks so that same origin redirections are not treated as cross origin redirections (from Blink patch).
- loader/MediaResourceLoader.cpp:
(WebCore::MediaResourceLoader::start):
- loader/NetscapePlugInStreamLoader.cpp:
(WebCore::NetscapePlugInStreamLoader::NetscapePlugInStreamLoader): Added new security parameter.
- loader/ResourceLoaderOptions.h:
(WebCore::ResourceLoaderOptions::ResourceLoaderOptions): Added new security parameter (from Blink patch).
(WebCore::ResourceLoaderOptions::credentialRequest):
(WebCore::ResourceLoaderOptions::setCredentialRequest):
- loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::requestUserCSSStyleSheet): Ditto.
(WebCore::CachedResourceLoader::defaultCachedResourceOptions): Ditto.
- loader/icon/IconLoader.cpp:
(WebCore::IconLoader::startLoading): Added new security parameter.
- page/EventSource.cpp:
(WebCore::EventSource::connect): Added new security parameter (from Blink patch).
- platform/graphics/avfoundation/cf/WebCoreAVCFResourceLoader.cpp:
(WebCore::WebCoreAVCFResourceLoader::startLoading): Added new security parameter.
- platform/graphics/avfoundation/objc/WebCoreAVFResourceLoader.mm:
(WebCore::WebCoreAVFResourceLoader::startLoading): Ditto.
- platform/network/ResourceHandleTypes.h: Added new security parameter constants (from Blink patch).
- platform/network/ResourceRequestBase.cpp:
(WebCore::ResourceRequestBase::clearHTTPAcceptEncoding): Function to remove "Accept-Encoding" header.
- platform/network/ResourceRequestBase.h: Ditto.
- xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::createRequest): Added new security parameter.
LayoutTests:
Merging https://chromium.googlesource.com/chromium/blink/+/7ea774e478f84f355748108d2aaabca15355d512 by Ken Russell
This merge adds tests for cross origin requests triggered from same origin redirection responses with and without credentials).
Rebaseline of some tests due to console error messages generated from newly hit CORS checks.
- TestExpectations: Disabled WPT tests that require access to non localhost URLs which are currently blocked by DTR/WTR.
- http/tests/xmlhttprequest/access-control-and-redirects-async-expected.txt:
- http/tests/xmlhttprequest/access-control-and-redirects-async-same-origin-expected.txt: Added.
- http/tests/xmlhttprequest/access-control-and-redirects-async-same-origin.html: Added.
- http/tests/xmlhttprequest/access-control-and-redirects-async.html:
- http/tests/xmlhttprequest/access-control-and-redirects-expected.txt:
- http/tests/xmlhttprequest/access-control-and-redirects.html:
- http/tests/xmlhttprequest/redirect-cross-origin-2-expected.txt:
- http/tests/xmlhttprequest/redirect-cross-origin-expected.txt:
- http/tests/xmlhttprequest/redirect-cross-origin-post-expected.txt:
- http/tests/xmlhttprequest/redirect-cross-origin-tripmine-expected.txt:
- http/tests/xmlhttprequest/resources/access-control-basic-allow-no-credentials.cgi: Added.
- http/tests/xmlhttprequest/xmlhttprequest-unsafe-redirect-expected.txt:
Jan 13, 2016:
- 11:34 PM Changeset in webkit [195009] by
-
- 5 edits in trunk
[CMake] Do not use LLVM static libraries for FTL JIT
https://bugs.webkit.org/show_bug.cgi?id=151559
Reviewed by Michael Catanzaro.
.:
Also export LLVM_LIBRARIES variable that can be used to prefer
linking to the llvm dynamic libraries.
- Source/cmake/FindLLVM.cmake:
Source/JavaScriptCore:
Allow ports decide whether to prefer linking to llvm static or
dynamic libraries. This patch only changes the behavior of the GTK
port, other ports can change the default behavior by setting
llvmForJSC_LIBRARIES in their platform specific cmake files.
- CMakeLists.txt: Move llvmForJSC library definition after the
WEBKIT_INCLUDE_CONFIG_FILES_IF_EXISTS, to allow platform specific
files to set their own llvmForJSC_LIBRARIES. When not set, it
defaults to LLVM_STATIC_LIBRARIES. The command to create
WebKitLLVMLibraryToken.h no longer depends on the static
libraries, since we are going to make the build fail anyway when
not found in case of linking to the static libraries. If platform
specific file defined llvmForJSC_INSTALL_DIR llvmForJSC is also
installed to the given destination.
- PlatformGTK.cmake: Set llvmForJSC_LIBRARIES and
llvmForJSC_INSTALL_DIR.
- 11:00 PM Changeset in webkit [195008] by
-
- 2 edits in trunk/Websites/webkit.org
Correct some history timeline styles.
- wp-content/themes/webkit/style.css:
(.timeline .content):
- 10:49 PM Changeset in webkit [195007] by
-
- 2 edits in trunk/Websites/webkit.org
Add styles for a history timeline, needed by an upcoming blog post.
- wp-content/themes/webkit/style.css:
(.timeline):
(.timeline:after):
(.timeline *):
(.timeline:before):
(.timeline > li):
(.timeline > li:before):
(.timeline .content):
(.timeline figure):
(.timeline .time):
(.timeline h2, .timeline h3):
(.timeline .time::before):
(.timeline img):
(@media (min-width: 900px)):
(.timeline > li.force-clear):
(.timeline > li:nth-child(odd)):
(.timeline > li:nth-child(even)):
(.timeline > li.force-clear + li):
(.timeline li .time):
(.timeline li:nth-child(odd) .time):
(.timeline li:nth-child(even) .time):
(.timeline li:nth-child(even) .time::before):
(.timeline > li:nth-child(even):before):
- 10:22 PM Changeset in webkit [195006] by
-
- 2 edits in trunk/Source/WebCore
Addressing more post-review comments after r194566
Unreviewed.
No new tests because there is no behavior change.
- platform/text/mac/TextBreakIteratorInternalICUMac.mm:
(WebCore::topLanguagePreference):
- 6:43 PM Changeset in webkit [195005] by
-
- 6 edits in trunk/Source
Implement custom protocols when using NetworkSession
https://bugs.webkit.org/show_bug.cgi?id=153078
Patch by Alex Christensen <achristensen@webkit.org> on 2016-01-13
Reviewed by Andy Estes.
Source/WebCore:
No new tests, but this makes the WebKit2CustomProtocolsTest api tests pass when using NetworkSession.
- WebCore.xcodeproj/project.pbxproj:
Make NSURLConnectionSPI.h private so we can include it from within WebKit2.
Source/WebKit2:
- NetworkProcess/CustomProtocols/Cocoa/CustomProtocolManagerCocoa.mm:
(WebKit::generateCustomProtocolID):
(+[WKCustomProtocol canInitWithRequest:]):
(+[WKCustomProtocol canonicalRequestForRequest:]):
(-[WKCustomProtocol initWithRequest:cachedResponse:client:]):
(-[WKCustomProtocol startLoading]):
(-[WKCustomProtocol stopLoading]):
There's no need to have a static pointer when we can use NetworkProcess::singleton to access
the process-global CustomProtocolManager, and add null checks because that's a good thing to do.
(WebKit::CustomProtocolManager::CustomProtocolManager):
Call UTF8Encoding when creating the CustomProtocolManager on the main thread to make sure it exists
for when we decode URLS in ResourceResponses from IPC later, which is done on a different WorkQueue.
(WebKit::CustomProtocolManager::initializeConnection):
(WebKit::CustomProtocolManager::initialize):
(WebKit::CustomProtocolManager::removeCustomProtocol):
(WebKit::CustomProtocolManager::registerProtocolClass):
(WebKit::CustomProtocolManager::registerScheme):
- NetworkProcess/CustomProtocols/CustomProtocolManager.h:
- NetworkProcess/cocoa/NetworkSessionCocoa.mm:
(WebKit::NetworkSession::NetworkSession):
Call registerProtocolClass to set configuration.protocolClasses if there is a CustomProtocolManager.
- 5:29 PM Changeset in webkit [195004] by
-
- 8 edits in trunk/Source/WebCore
Cross-protocol, cross-site scripting (XPSS) using HTML forms
https://bugs.webkit.org/show_bug.cgi?id=153017
<rdar://problem/5873254>
Reviewed by David Kilzer.
- loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::responseReceived): If response HTTP version is 0.9,
sandbox against script execution and plugins.
- loader/ResourceLoader.cpp:
(WebCore::ResourceLoader::didReceiveResponse): Ditto.
- loader/SubresourceLoader.cpp:
(WebCore::SubresourceLoader::didReceiveResponse): Ditto.
- platform/network/ResourceResponseBase.cpp:
(WebCore::ResourceResponseBase::adopt): Update for HTTP version.
(WebCore::ResourceResponseBase::copyData): Ditto.
(WebCore::ResourceResponseBase::httpVersion): Added.
(WebCore::ResourceResponseBase::setHTTPVersion): Ditto.
- platform/network/ResourceResponseBase.h:
(WebCore::ResourceResponseBase::encode): Update for HTTP version.
(WebCore::ResourceResponseBase::decode): Ditto.
- platform/network/cf/ResourceResponseCFNet.cpp:
(WebCore::ResourceResponse::platformLazyInit): Capture HTTP version.
- platform/network/cocoa/ResourceResponseCocoa.mm:
(WebCore::ResourceResponse::platformLazyInit): Ditto.
- 5:12 PM Changeset in webkit [195003] by
-
- 2 edits in trunk/LayoutTests
Marking test as flaky: sputnik/Conformance/15_Native_Objects/15.1_The_Global_Object/15.1.3/15.1.3.3_encodeURI/S15.1.3.3_A2.4_T2.html
https://bugs.webkit.org/show_bug.cgi?id=153086
Unreviewed test gardening.
- platform/mac/TestExpectations:
- 5:03 PM Changeset in webkit [195002] by
-
- 15 edits2 adds in trunk
WK2: Request completion candidates when needed
https://bugs.webkit.org/show_bug.cgi?id=153040
-and corresponding-
rdar://problem/24155631
Reviewed by Enrica Casucci.
Source/WebCore:
Helper functions for stringForCandidateRequest() and
handleAcceptedCandidate()
- editing/Editor.cpp:
(WebCore::candidateRangeForSelection):
(WebCore::candidateWouldReplaceText):
Request candidates for the word that is currently being typed so long as the
candidate would replace that word. Otherwise, use String().
(WebCore::Editor::stringForCandidateRequest):
When a candidate has been accepted, insert the text.
(WebCore::Editor::handleAcceptedCandidate):
- editing/Editor.h:
Source/WebKit2:
Mac needs to support postLayoutData in order to have some layout-related
editing information to request candidates. This patch re-shuffles some items
in the struct so that they can be shared by Mac and iOS, and it adds 3 new
items for Mac only.
- Shared/EditorState.cpp:
(WebKit::EditorState::encode):
(WebKit::EditorState::decode):
(WebKit::EditorState::PostLayoutData::encode):
(WebKit::EditorState::PostLayoutData::decode):
- Shared/EditorState.h:
Request and handle candidates here in WebViewImpl, and cache the
m_lastStringForCandidateRequest so that we can ensure the results we receive
were received in a timely enough manner that they are still for the same
String.
- UIProcess/Cocoa/WebViewImpl.h:
- UIProcess/Cocoa/WebViewImpl.mm:
(WebKit::WebViewImpl::selectionDidChange):
When selection changes, request new candidates.
(WebKit::WebViewImpl::requestCandidatesForSelectionIfNeeded):
Once candidates have been received, we ask the sharedSpellChecker to show
them.
(WebKit::WebViewImpl::handleRequestedCandidates):
If a candidate is accepted, we ask the WebProcess to accept it, so we start
by converting the NSTextCheckingResult to a WebCore::TextCheckingResult.
(WebKit::textCheckingResultFromNSTextCheckingResult):
(WebKit::WebViewImpl::handleAcceptedCandidate):
Ask the WebProcess to handle accepting the candidate.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::handleAcceptedCandidate):
- UIProcess/WebPageProxy.h:
- WebProcess/WebPage/WebPage.h:
(WebKit::WebPage:: handleAcceptedCandidate):
- WebProcess/WebPage/WebPage.messages.in:
Now that Mac has some postLayoutData in the EditorState, fill that in in
platformEditorState().
- WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::WebPage::platformEditorState):
Ask WebCore::Editor to handle the accepted candidate.
(WebKit::WebPage::handleAcceptedCandidate):
LayoutTests:
Getting updated EditorState in platformEditorState causes some extra layout
to happen, so now the layout test results for WK2 reflect the results that we
already see on iOS for this test and they reflect the render tree as it is
when you load the page in browser.
- platform/mac/fast/dom/focus-contenteditable-expected.txt:
WebKit 1 is not affected by these new results, so this adds WK-1 only results
that match the old Mac results.
- platform/mac-wk1/fast/dom: Added.
- platform/mac-wk1/fast/dom/focus-contenteditable-expected.txt: Added.
- 4:29 PM Changeset in webkit [195001] by
-
- 2 edits in trunk/Source/WebCore
Addressing post-review comments after r194566
Unreviewed.
No new tests because there is no behavior difference.
- platform/text/mac/TextBreakIteratorInternalICUMac.mm:
(WebCore::textBreakLocalePreference):
(WebCore::topLanguagePreference):
(WebCore::getSearchLocale):
(WebCore::getTextBreakLocale):
(WebCore::canonicalLanguageIdentifier): Deleted.
- 4:28 PM Changeset in webkit [195000] by
-
- 10 edits in trunk/Source/JavaScriptCore
NativeExecutable should have a name field
https://bugs.webkit.org/show_bug.cgi?id=153083
Reviewed by Geoffrey Garen.
This is going to help the SamplingProfiler come up
with names for NativeExecutable objects it encounters.
- jit/JITThunks.cpp:
(JSC::JITThunks::finalize):
(JSC::JITThunks::hostFunctionStub):
- jit/JITThunks.h:
- runtime/Executable.h:
- runtime/JSBoundFunction.cpp:
(JSC::JSBoundFunction::create):
- runtime/JSFunction.cpp:
(JSC::JSFunction::create):
(JSC::JSFunction::lookUpOrCreateNativeExecutable):
- runtime/JSFunction.h:
(JSC::JSFunction::createImpl):
- runtime/JSNativeStdFunction.cpp:
(JSC::JSNativeStdFunction::create):
- runtime/VM.cpp:
(JSC::thunkGeneratorForIntrinsic):
(JSC::VM::getHostFunction):
- runtime/VM.h:
(JSC::VM::getCTIStub):
(JSC::VM::exceptionOffset):
- 4:04 PM Changeset in webkit [194999] by
-
- 11 edits2 adds in trunk
formaction must return document's address when formaction is missing
https://bugs.webkit.org/show_bug.cgi?id=148874
Reviewed by Chris Dumez.
LayoutTests/imported/w3c:
Rebaselined the tests now that more test cases are passing.
- web-platform-tests/html/semantics/forms/attributes-common-to-form-controls/formAction_document_address-expected.txt:
- web-platform-tests/html/semantics/forms/attributes-common-to-form-controls/formaction-expected.txt:
Source/WebCore:
Fixed the bug by falling back to document.url() when the attribute is not set or is empty in formAction getter.
Test: fast/forms/formaction-attribute-with-empty-value.html
- html/HTMLButtonElement.idl:
- html/HTMLFormControlElement.cpp:
(WebCore::HTMLFormControlElement::formAction): Added.
(WebCore::HTMLFormControlElement::setFormAction): Added.
- html/HTMLFormControlElement.h:
- html/HTMLInputElement.idl:
LayoutTests:
Added a regression test and rebaselined imported W3C tests.
- fast/forms/formaction-attribute-with-empty-value-expected.txt: Added.
- fast/forms/formaction-attribute-with-empty-value.html: Added.
- fast/forms/submit-form-attributes-expected.txt:
- fast/forms/submit-form-attributes.html:
- 3:45 PM Changeset in webkit [194998] by
-
- 3 edits1 add in trunk/Source/JavaScriptCore
[ES6] Support subclassing the String builtin object
https://bugs.webkit.org/show_bug.cgi?id=153068
Reviewed by Michael Saboff.
This patch adds subclassing of strings. Also, this patch fixes a bug where we could have
the wrong indexing type for builtins constructed without storage.
- runtime/PrototypeMap.cpp:
(JSC::PrototypeMap::emptyStructureForPrototypeFromBaseStructure):
- runtime/StringConstructor.cpp:
(JSC::constructWithStringConstructor):
- tests/stress/class-subclassing-string.js: Added.
(test):
- 3:31 PM Changeset in webkit [194997] by
-
- 4 edits in trunk/Tools
[Cocoa] Testing with font family name "System Font" is unused
https://bugs.webkit.org/show_bug.cgi?id=153073
<rdar://problem/24091683>
Reviewed by Brent Fulgham.
- DumpRenderTree/mac/DumpRenderTree.mm:
(allowedFontFamilySet): Deleted.
- WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
(WTR::allowedFontFamilySet): Deleted.
- WebKitTestRunner/mac/TestControllerMac.mm:
(WTR::allowedFontFamilySet): Deleted.
- 3:28 PM Changeset in webkit [194996] by
-
- 10 edits3 adds in trunk
The StringFromCharCode DFG intrinsic should support untyped operands.
https://bugs.webkit.org/show_bug.cgi?id=153046
Reviewed by Geoffrey Garen.
Source/JavaScriptCore:
The current StringFromCharCode DFG intrinsic assumes that its operand charCode
must be an Int32. This results in 26000+ BadType OSR exits in the LongSpider
crypto-aes benchmark. With support for Untyped operands, the number of OSR
exits drops to 202.
- dfg/DFGClobberize.h:
(JSC::DFG::clobberize):
- dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
- dfg/DFGOperations.cpp:
- dfg/DFGOperations.h:
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileFromCharCode):
- dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::callOperation):
- dfg/DFGValidate.cpp:
(JSC::DFG::Validate::validate):
- runtime/JSCJSValueInlines.h:
(JSC::JSValue::toUInt32):
LayoutTests:
- js/regress/ftl-polymorphic-StringFromCharCode-expected.txt: Added.
- js/regress/ftl-polymorphic-StringFromCharCode.html: Added.
- js/regress/script-tests/ftl-polymorphic-StringFromCharCode.js: Added.
(o1.valueOf):
(foo):
- 3:11 PM Changeset in webkit [194995] by
-
- 22 edits1 copy1 add in branches/safari-601.1.46-branch
Merge r194950. rdar://problem/23270886
- 3:10 PM Changeset in webkit [194994] by
-
- 27 edits2 adds in branches/safari-601.1.46-branch
Merge r194927. rdar://problem/24101173
- 3:10 PM Changeset in webkit [194993] by
-
- 4 edits3 adds in branches/safari-601.1.46-branch
Merge r194898. rdar://problem/24154420
- 3:10 PM Changeset in webkit [194992] by
-
- 4 edits17 adds in branches/safari-601.1.46-branch
Merge r194865. rdar://problem/24154421
- 3:10 PM Changeset in webkit [194991] by
-
- 4 edits5 adds in branches/safari-601.1.46-branch
Merge r191180. rdar://problem/24154421
- 3:10 PM Changeset in webkit [194990] by
-
- 2 edits in branches/safari-601.1.46-branch/Source/WebCore
Merge r190641. rdar://problem/24154421
- 3:10 PM Changeset in webkit [194989] by
-
- 6 edits1 copy4 adds in branches/safari-601.1.46-branch
Merge r193939. rdar://problem/24154418
- 3:06 PM Changeset in webkit [194988] by
-
- 2 edits in trunk
[GTK] Add comments above options declarations in OptionsGTK.cmake
https://bugs.webkit.org/show_bug.cgi?id=153074
Reviewed by Martin Robinson.
- Source/cmake/OptionsGTK.cmake:
- 3:00 PM Changeset in webkit [194987] by
-
- 21 edits in trunk/Source
Unreviewed, rolling out r194900.
Roll back in as this did not actually regress PLT
Reverted changeset:
"Unreviewed, rolling out r194826."
https://bugs.webkit.org/show_bug.cgi?id=153020
http://trac.webkit.org/changeset/194900
- 2:45 PM Changeset in webkit [194986] by
-
- 7 edits in trunk/Source/WebKit2
WebKit2 should have an API for eagerly querying whether the web process is responsive
https://bugs.webkit.org/show_bug.cgi?id=153037
Reviewed by Tim Horton.
WebKit2 provides a delegate notification when the web process doesn't
respond to a message after a while. But there's no way to send a message
eagerly and check for reply.
We want this new mechanism so that navigation can terminate the web
process eagerly if it is hung.
- UIProcess/API/C/WKPage.cpp:
(WKPageGetWebProcessIsResponsive):
- UIProcess/API/C/WKPagePrivate.h: This is the new API.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::sendWheelEvent): Updated for interface change.
(WebKit::WebPageProxy::getWebProcessIsResponsive): Calls through to the
web process proxy. We claim that we are responsive when there is no
web process because we assume that a fresh web process will not hang.
- UIProcess/WebPageProxy.h:
- UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::WebProcessProxy):
(WebKit::WebProcessProxy::didBecomeUnresponsive): Keep a flag indicating
whether the process is unresponsive so that we can fire unresponsiveness
callbacks immediately for a hung process instead of waiting another 3s.
(WebKit::WebProcessProxy::didBecomeResponsive): We don't fire responsiveness
callbacks inside didBecomeResponsive because we assume that a responsive
web process will invoke didReceiveMainThreadPing -- and we fire the
callbacks there.
(WebKit::WebProcessProxy::getIsResponsive): If the web process is already
known to be unresponsive, fire the callback right away. Otherwise, queue
it up to fire once we have an answer from a main thread ping.
(WebKit::WebProcessProxy::didReceiveMainThreadPing): Fire any pending
callbacks when we learn that the web process is responsive.
- UIProcess/WebProcessProxy.h:
- 2:32 PM Changeset in webkit [194985] by
-
- 2 edits in trunk/Source/WebCore
Removed empty #if block from Font.h
https://bugs.webkit.org/show_bug.cgi?id=153067
Patch by Konstantin Tokarev <Konstantin Tokarev> on 2016-01-13
Reviewed by Alex Christensen.
No new tests needed.
- platform/graphics/Font.h:
(WebCore::Font::scriptCache): Deleted.
- 2:29 PM Changeset in webkit [194984] by
-
- 2 edits in trunk/Source/WebCore
[GTK] Consistently use virtual and override specifiers in ScrollbarThemeGtk
https://bugs.webkit.org/show_bug.cgi?id=153076
Reviewed by Alex Christensen.
No behavior change.
- platform/gtk/ScrollbarThemeGtk.h:
- 2:21 PM Changeset in webkit [194983] by
-
- 4 edits in trunk/Source/JavaScriptCore
Use DFG Graph::binary/unaryArithShouldSpeculateInt32/MachineInt() functions consistently.
https://bugs.webkit.org/show_bug.cgi?id=153080
Reviewed by Geoffrey Garen.
We currently have Graph::mulShouldSpeculateInt32/machineInt() and
Graph::negateShouldSpeculateInt32/MachineInt() functions which are only used by
the ArithMul and ArithNegate nodes. However, the same tests need to be done for
many other arith nodes in the DFG. This patch renames these functions as
Graph::binaryArithShouldSpeculateInt32/machineInt() and
Graph::unaryArithShouldSpeculateInt32/MachineInt(), and uses them consistently
in the DFG.
- dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
- dfg/DFGGraph.h:
(JSC::DFG::Graph::addShouldSpeculateMachineInt):
(JSC::DFG::Graph::binaryArithShouldSpeculateInt32):
(JSC::DFG::Graph::binaryArithShouldSpeculateMachineInt):
(JSC::DFG::Graph::unaryArithShouldSpeculateInt32):
(JSC::DFG::Graph::unaryArithShouldSpeculateMachineInt):
(JSC::DFG::Graph::mulShouldSpeculateInt32): Deleted.
(JSC::DFG::Graph::mulShouldSpeculateMachineInt): Deleted.
(JSC::DFG::Graph::negateShouldSpeculateInt32): Deleted.
(JSC::DFG::Graph::negateShouldSpeculateMachineInt): Deleted.
- dfg/DFGPredictionPropagationPhase.cpp:
(JSC::DFG::PredictionPropagationPhase::propagate):
(JSC::DFG::PredictionPropagationPhase::doDoubleVoting):
- 1:45 PM Changeset in webkit [194982] by
-
- 3 edits in trunk/Source/WebCore
Cleanup: XSS Auditor should avoid re-evaluating the parsed script tag
https://bugs.webkit.org/show_bug.cgi?id=152870
Patch by Daniel Bates <dabates@apple.com> on 2016-01-13
Reviewed by Brent Fulgham.
Merged from Blink (patch by Tom Sepez <tsepez@chromium.org>):
<https://src.chromium.org/viewvc/blink?revision=154354&view=revision>
Although the XSS Auditor caches the decoded start tag of a script as an optimization to
avoid decoding it again when filtering the character data of the script, it is sufficient
to cache whether the HTTP response contains the decoded start tag of a script. This
avoids both decoding the start tag of a script and determining whether the HTTP response
contains it again when filtering the character data of the script. Moreover, this removes
the need to cache a string object.
- html/parser/XSSAuditor.cpp:
(WebCore::XSSAuditor::filterCharacterToken):
(WebCore::XSSAuditor::filterScriptToken):
- html/parser/XSSAuditor.h:
- 1:32 PM Changeset in webkit [194981] by
-
- 11 edits in trunk
Web Inspector: Inspector should use the last sourceURL / sourceMappingURL directive
https://bugs.webkit.org/show_bug.cgi?id=153072
<rdar://problem/24168312>
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-01-13
Reviewed by Timothy Hatcher.
Source/JavaScriptCore:
- parser/Lexer.cpp:
(JSC::Lexer<T>::parseCommentDirective):
Just keep overwriting the member variable so we end up with
the last directive value.
Source/WebInspectorUI:
- UserInterface/Base/Utilities.js:
Prepend instead of append the sourceURL so the provided string
can include a sourceURL and override it. Such as manually
evaluating a script through the quick console with a sourceURL.
- UserInterface/Models/SourceMapResource.js:
Fix an incorrectly named property.
LayoutTests:
- inspector/console/console-api-expected.txt:
- inspector/console/console-table-expected.txt:
- platform/mac/inspector/model/remote-object-expected.txt:
Updated line number in output now that code evaluated through the frontend
gets the WebInspectorInternal sourceURL prepended to the start instead
of appended to the end.
- inspector/debugger/sourceURLs-expected.txt:
- inspector/debugger/sourceURLs.html:
Update the test to find the second sourceURL, not the first.
- 1:24 PM Changeset in webkit [194980] by
-
- 23 edits2 deletes in trunk/Source
Unreviewed, rolling out r194963.
https://bugs.webkit.org/show_bug.cgi?id=153079
This change causes ASan tests to crash and exit early
(Requested by ryanhaddad on #webkit).
Reverted changeset:
"Fragmentation-free allocator for timeless and/or coupled
allocations."
https://bugs.webkit.org/show_bug.cgi?id=152696
http://trac.webkit.org/changeset/194963
Patch by Commit Queue <commit-queue@webkit.org> on 2016-01-13
- 1:20 PM Changeset in webkit [194979] by
-
- 3 edits2 adds in trunk
[XSS Auditor] Do not include trailing comment characters in JavaScript snippets
https://bugs.webkit.org/show_bug.cgi?id=152873
Patch by Daniel Bates <dabates@apple.com> on 2016-01-13
Reviewed by Brent Fulgham.
Merged from Blink (patch by Tom Sepez <tsepez@chromium.org>):
<https://src.chromium.org/viewvc/blink?view=rev&revision=169967>
Source/WebCore:
Test: http/tests/security/xssAuditor/script-tag-with-injected-comment.html
- html/parser/XSSAuditor.cpp:
(WebCore::XSSAuditor::decodedSnippetForJavaScript):
LayoutTests:
- http/tests/security/xssAuditor/script-tag-with-injected-comment-expected.txt: Added.
- http/tests/security/xssAuditor/script-tag-with-injected-comment.html: Added.
- 1:18 PM Changeset in webkit [194978] by
-
- 3 edits5 adds in trunk
[XSS Auditor] Add test when XSS payload is in the path portion of the URL
https://bugs.webkit.org/show_bug.cgi?id=152871
Patch by Daniel Bates <dabates@apple.com> on 2016-01-13
Reviewed by Brent Fulgham.
Merged from Blink (patch by Tom Sepez <tsepez@chromium.org>):
<https://src.chromium.org/viewvc/blink?revision=164746&view=revision>
Tools:
- Scripts/webkitpy/layout_tests/servers/lighttpd.conf:
LayoutTests:
Add infrastructure and a test for an XSS attack where the payload is
embedded in the path portion of the URL.
Many XSS Auditor tests pass the XSS payload to CGI scripts via the
query string portion of the URL. Now we also support calling these
same scripts with the payload embedded in the path portion of the
URL.
Loading <http://127.0.0.1:8000/security/xssAuditor/intercept/X/Y>
returns a response whose content is identical to <http://127.0.0.1:8000/security/xssAuditor/resoures/X?q=Y>,
where X is the filename of some CGI script in directory LayoutTests/http/tests/security/xssAuditor/resources
and Y is the XSS payload.
- http/tests/security/xssAuditor/intercept/.htaccess: Added.
- http/tests/security/xssAuditor/reflection-in-path-expected.txt: Added.
- http/tests/security/xssAuditor/reflection-in-path.html: Added.
- http/tests/security/xssAuditor/resources/echo-form-action.pl: Added.
- 1:14 PM Changeset in webkit [194977] by
-
- 13 edits2 moves in trunk/Source/WebInspectorUI
Web Inspector: Add support for the existing GradientEditor in the CSS Rules sidebar
https://bugs.webkit.org/show_bug.cgi?id=153004
Patch by Devin Rousso <Devin Rousso> on 2016-01-13
Reviewed by Timothy Hatcher.
Both the Visual sidebar and Resource view have editors for CSS gradient
values, but the Rules sidebar instead only adds editors for basic color
values. Instead of duplicating the code for gradient swatches, existing
code will be used to give this same functionality to the Rules sidebar.
- Localizations/en.lproj/localizedStrings.js:
- UserInterface/Main.html:
- UserInterface/Models/Gradient.js:
(WebInspector.Gradient):
(WebInspector.Gradient.fromString):
(WebInspector.Gradient.stopsWithComponents):
(WebInspector.Gradient.prototype.copy):
(WebInspector.Gradient.prototype.toString):
Refactored WebInspector.Gradient into its own class.
(WebInspector.LinearGradient):
(WebInspector.LinearGradient.prototype.toString):
Now uses WebInspector.Gradient inheritance and methods.
(WebInspector.RadialGradient):
(WebInspector.RadialGradient.prototype.toString):
Now uses WebInspector.Gradient inheritance and methods.
- UserInterface/Views/CSSStyleDeclarationTextEditor.css:
Use InlineSwatch.css values instead.
(.css-style-text-editor > .CodeMirror .CodeMirror-lines .cubic-bezier-marker): Deleted.
(@media (-webkit-max-device-pixel-ratio: 1)): Deleted.
(.css-style-text-editor > .CodeMirror .CodeMirror-lines .cubic-bezier-marker:hover): Deleted.
(.css-style-text-editor > .CodeMirror .CodeMirror-lines .cubic-bezier-marker:active): Deleted.
- UserInterface/Views/CSSStyleDeclarationTextEditor.js:
(WebInspector.CSSStyleDeclarationTextEditor.prototype.didDismissPopover): Deleted.
Removed unused popover member variable.
(WebInspector.CSSStyleDeclarationTextEditor.prototype._contentChanged):
(WebInspector.CSSStyleDeclarationTextEditor.prototype._updateTextMarkers.update):
(WebInspector.CSSStyleDeclarationTextEditor.prototype._createInlineSwatches.createSwatch):
(WebInspector.CSSStyleDeclarationTextEditor.prototype._createInlineSwatches.update):
(WebInspector.CSSStyleDeclarationTextEditor.prototype._createInlineSwatches):
Renamed variables for more consistent naming and reimplemented the logic
to use the new WebInspector.InlineSwatch methods. As a result, it was
possible to consolidate the 3 different type of swatch functions into a
single function.
(WebInspector.CSSStyleDeclarationTextEditor.prototype._commentProperty.update):
(WebInspector.CSSStyleDeclarationTextEditor.prototype._uncommentRange.update):
(WebInspector.CSSStyleDeclarationTextEditor.prototype._inlineSwatchValueChanged.update):
(WebInspector.CSSStyleDeclarationTextEditor.prototype._inlineSwatchValueChanged):
(WebInspector.CSSStyleDeclarationTextEditor.prototype._resetContent.update):
(WebInspector.CSSStyleDeclarationTextEditor.prototype._createColorSwatches.createSwatch): Deleted.
(WebInspector.CSSStyleDeclarationTextEditor.prototype._createColorSwatches.update): Deleted.
(WebInspector.CSSStyleDeclarationTextEditor.prototype._createColorSwatches): Deleted.
(WebInspector.CSSStyleDeclarationTextEditor.prototype._createBezierEditors.update): Deleted.
(WebInspector.CSSStyleDeclarationTextEditor.prototype._createBezierEditors): Deleted.
(WebInspector.CSSStyleDeclarationTextEditor.prototype._colorSwatchColorChanged.update): Deleted.
(WebInspector.CSSStyleDeclarationTextEditor.prototype._colorSwatchColorChanged): Deleted.
(WebInspector.CSSStyleDeclarationTextEditor.prototype._cubicBezierMarkerClicked.updateCodeMirror.update): Deleted.
(WebInspector.CSSStyleDeclarationTextEditor.prototype._cubicBezierMarkerClicked.updateCodeMirror): Deleted.
(WebInspector.CSSStyleDeclarationTextEditor.prototype._cubicBezierMarkerClicked): Deleted.
- UserInterface/Views/CodeMirrorTextMarkers.js:
(createCodeMirrorColorTextMarkers.matchFunction):
Added logic so that if the matched color string is found inside a gradient,
it will not have a marker created for it.
- UserInterface/Views/InlineSwatch.css: Renamed from Source/WebInspectorUI/UserInterface/Views/ColorSwatch.css.
Consolidated the various swatch CSS classes into one file.
(.inline-swatch):
(.inline-swatch.bezier):
(.inline-swatch.bezier:hover):
(.inline-swatch.bezier:active):
(@media (-webkit-max-device-pixel-ratio: 1)):
(.inline-swatch > span):
Ensured that the inner swatch element can not be selected so that the "click"
listener on its parent always fires.
(.inline-swatch:hover > span):
(.inline-swatch:active > span):
(.inline-swatch.bezier > span):
- UserInterface/Views/InlineSwatch.js: Renamed from Source/WebInspectorUI/UserInterface/Views/ColorSwatch.js.
(WebInspector.InlineSwatch):
Now accepts a new first argument to indicate what type of color swatch
to create and what functionality it will have. Currently has options
for WebInspector.Color, WebInspector.Gradient, and WebInspector.CubicBezier.
(WebInspector.InlineSwatch.prototype.get element):
(WebInspector.InlineSwatch.prototype.get value):
(WebInspector.InlineSwatch.prototype.set value):
(WebInspector.InlineSwatch.prototype._fallbackValue):
(WebInspector.InlineSwatch.prototype._updateSwatch):
(WebInspector.InlineSwatch.prototype._swatchElementClicked):
(WebInspector.InlineSwatch.prototype._valueEditorValueDidChange):
(WebInspector.InlineSwatch.prototype._handleContextMenuEvent):
(WebInspector.InlineSwatch.prototype._getNextValidHEXFormat.hexMatchesCurrentColor):
(WebInspector.InlineSwatch.prototype._getNextValidHEXFormat):
- UserInterface/Views/VisualStyleBackgroundPicker.css:
(.visual-style-property-container.background-picker > .visual-style-property-value-container > .inline-swatch.gradient):
(.visual-style-property-container.background-picker > .visual-style-property-value-container:not(.gradient-value) > .inline-swatch.gradient):
(.visual-style-property-container.background-picker > .visual-style-property-value-container > .inline-swatch.gradient:hover):
(.visual-style-property-container.background-picker > .visual-style-property-value-container > .inline-swatch.gradient:active):
(.visual-style-property-container.background-picker > .visual-style-property-value-container > .inline-swatch.gradient > span):
(.visual-style-property-container.background-picker > .visual-style-property-value-container.gradient-value > .inline-swatch.gradient + .value-input):
(.visual-style-property-container.background-picker > .visual-style-property-value-container > .color-swatch): Deleted.
(.visual-style-property-container.background-picker > .visual-style-property-value-container:not(.gradient-value) > .color-swatch): Deleted.
(.visual-style-property-container.background-picker > .visual-style-property-value-container > .color-swatch:hover): Deleted.
(.visual-style-property-container.background-picker > .visual-style-property-value-container > .color-swatch:active): Deleted.
(.visual-style-property-container.background-picker > .visual-style-property-value-container > .color-swatch > span): Deleted.
(.visual-style-property-container.background-picker > .visual-style-property-value-container.gradient-value > .color-swatch + .value-input): Deleted.
- UserInterface/Views/VisualStyleBackgroundPicker.js:
Removed the specific code for the gradient swatch and moved to using a
gradient-type InlineSwatch for gradient values instead.
(WebInspector.VisualStyleBackgroundPicker):
(WebInspector.VisualStyleBackgroundPicker.prototype.set value):
(WebInspector.VisualStyleBackgroundPicker.prototype._updateGradient):
(WebInspector.VisualStyleBackgroundPicker.prototype._gradientSwatchColorChanged):
(WebInspector.VisualStyleBackgroundPicker.prototype._valueInputValueChanged):
(WebInspector.VisualStyleBackgroundPicker.prototype._handleKeywordChanged):
(WebInspector.VisualStyleBackgroundPicker.prototype._updateGradientSwatch): Deleted.
(WebInspector.VisualStyleBackgroundPicker.prototype._gradientSwatchClicked.handleColorPickerToggled): Deleted.
(WebInspector.VisualStyleBackgroundPicker.prototype._gradientSwatchClicked): Deleted.
(WebInspector.VisualStyleBackgroundPicker.prototype._gradientEditorGradientChanged): Deleted.
- UserInterface/Views/VisualStyleColorPicker.css:
(.visual-style-property-container.input-color-picker > .visual-style-property-value-container > .inline-swatch.color):
(.visual-style-property-container.input-color-picker > .visual-style-property-value-container > .inline-swatch.color:hover):
(.visual-style-property-container.input-color-picker > .visual-style-property-value-container > .inline-swatch.color:active):
(.visual-style-property-container.input-color-picker > .visual-style-property-value-container > .inline-swatch.color > span):
Add override CSS to ensure that the color-type InlineSwatch displays nicely
next to the flexbox style Visual sidebar.
(.visual-style-property-container.input-color-picker > .visual-style-property-value-container > .color-swatch): Deleted.
(.visual-style-property-container.input-color-picker > .visual-style-property-value-container > .color-swatch:hover): Deleted.
(.visual-style-property-container.input-color-picker > .visual-style-property-value-container > .color-swatch:active): Deleted.
(.visual-style-property-container.input-color-picker > .visual-style-property-value-container > .color-swatch > span): Deleted.
Refactored to only use overriding properties of the basic .inline-swatch values.
- UserInterface/Views/VisualStyleColorPicker.js:
(WebInspector.VisualStyleColorPicker):
(WebInspector.VisualStyleColorPicker.prototype._colorSwatchColorChanged):
(WebInspector.VisualStyleColorPicker.prototype._updateColorSwatch):
- UserInterface/Views/VisualStyleTimingEditor.css:
(.visual-style-property-container.timing-editor > .visual-style-property-value-container > .inline-swatch.bezier):
(.visual-style-property-container.timing-editor > .visual-style-property-value-container:not(.bezier-value) > .inline-swatch.bezier):
(@media (-webkit-min-device-pixel-ratio: 2)):
Add override CSS to ensure that the color-type InlineSwatch displays nicely
next to the flexbox style Visual sidebar.
(.visual-style-property-container.timing-editor > .visual-style-property-value-container > .bezier-editor): Deleted.
(.visual-style-property-container.timing-editor > .visual-style-property-value-container > .bezier-editor:hover): Deleted.
(.visual-style-property-container.timing-editor > .visual-style-property-value-container > .bezier-editor:active): Deleted.
Refactored to only use overriding properties of the basic .inline-swatch values.
- UserInterface/Views/VisualStyleTimingEditor.js:
Removed the specific code for the cubic-bezier swatch and moved to using a
cubic-bezier-type InlineSwatch for gradient values instead.
(WebInspector.VisualStyleTimingEditor):
(WebInspector.VisualStyleTimingEditor.prototype.get bezierValue):
(WebInspector.VisualStyleTimingEditor.prototype.set bezierValue):
(WebInspector.VisualStyleTimingEditor.prototype._setValue):
(WebInspector.VisualStyleTimingEditor.prototype._handleKeywordChanged):
(WebInspector.VisualStyleTimingEditor.prototype._bezierSwatchValueChanged):
(WebInspector.VisualStyleTimingEditor.prototype._bezierMarkerClicked): Deleted.
- 12:52 PM Changeset in webkit [194976] by
-
- 5 edits2 deletes in trunk/Source/JavaScriptCore
Unreviewed, rolling out r194969.
https://bugs.webkit.org/show_bug.cgi?id=153075
This change broke the iOS build (Requested by ryanhaddad on
#webkit).
Reverted changeset:
"[JSC] Legalize Memory Offsets for ARM64 before lowering to
Air"
https://bugs.webkit.org/show_bug.cgi?id=153065
http://trac.webkit.org/changeset/194969
Patch by Commit Queue <commit-queue@webkit.org> on 2016-01-13
- 12:17 PM Changeset in webkit [194975] by
-
- 27 edits2 adds in branches/safari-601-branch
Merge r194927. rdar://problem/24101254
- 12:17 PM Changeset in webkit [194974] by
-
- 4 edits3 adds in branches/safari-601-branch
Merge r194898. rdar://problem/24154290
- 12:17 PM Changeset in webkit [194973] by
-
- 4 edits17 adds in branches/safari-601-branch
Merge r194865. rdar://problem/24154291
- 12:17 PM Changeset in webkit [194972] by
-
- 4 edits5 adds in branches/safari-601-branch
Merge r191180. rdar://problem/24154291
- 12:17 PM Changeset in webkit [194971] by
-
- 2 edits in branches/safari-601-branch/Source/WebCore
Merge r190641. rdar://problem/24154291
- 12:17 PM Changeset in webkit [194970] by
-
- 6 edits1 copy4 adds in branches/safari-601-branch
Merge r193939. rdar://problem/24154418
- 11:33 AM Changeset in webkit [194969] by
-
- 5 edits2 adds in trunk/Source/JavaScriptCore
[JSC] Legalize Memory Offsets for ARM64 before lowering to Air
https://bugs.webkit.org/show_bug.cgi?id=153065
Patch by Benjamin Poulain <bpoulain@apple.com> on 2016-01-13
Reviewed by Mark Lam.
Reviewed by Filip Pizlo.
On ARM64, we cannot use signed 32bits offset for memory addressing.
There are two available addressing: signed 9bits and unsigned scaled 12bits.
Air already knows about it.
In this patch, the offsets are changed to something valid for ARM64
prior to lowering. When an offset is invalid, it is just computed
before the instruction and used as the base for addressing.
- JavaScriptCore.xcodeproj/project.pbxproj:
- b3/B3Generate.cpp:
(JSC::B3::generateToAir):
- b3/B3LegalizeMemoryOffsets.cpp: Added.
(JSC::B3::legalizeMemoryOffsets):
- b3/B3LegalizeMemoryOffsets.h: Added.
- b3/B3LowerToAir.cpp:
(JSC::B3::Air::LowerToAir::effectiveAddr): Deleted.
- b3/testb3.cpp:
(JSC::B3::testLoadWithOffsetImpl):
(JSC::B3::testLoadOffsetImm9Max):
(JSC::B3::testLoadOffsetImm9MaxPlusOne):
(JSC::B3::testLoadOffsetImm9MaxPlusTwo):
(JSC::B3::testLoadOffsetImm9Min):
(JSC::B3::testLoadOffsetImm9MinMinusOne):
(JSC::B3::testLoadOffsetScaledUnsignedImm12Max):
(JSC::B3::testLoadOffsetScaledUnsignedOverImm12Max):
(JSC::B3::run):
- 11:22 AM Changeset in webkit [194968] by
-
- 10 edits2 adds in trunk
WebRTC: Add support for RTCRtpSender.replaceTrack()
https://bugs.webkit.org/show_bug.cgi?id=153063
Reviewed by Eric Carlson.
Source/WebCore:
Add the API and infrastructure to support RTCRtpSender.replaceTrack(). The platform is
reached through the RTCPeerConnection object that created the RTCRtpSender via a client
interface.
Test: fast/mediastream/RTCRtpSender-replaceTrack.html
- Modules/mediastream/MediaEndpointPeerConnection.cpp:
(WebCore::MediaEndpointPeerConnection::replaceTrack):
- Modules/mediastream/MediaEndpointPeerConnection.h:
- Modules/mediastream/PeerConnectionBackend.h:
- Modules/mediastream/RTCPeerConnection.cpp:
(WebCore::RTCPeerConnection::addTrack):
(WebCore::RTCPeerConnection::removeTrack):
(WebCore::RTCPeerConnection::replaceTrack):
- Modules/mediastream/RTCPeerConnection.h:
- Modules/mediastream/RTCRtpSender.cpp:
(WebCore::RTCRtpSender::RTCRtpSender):
(WebCore::RTCRtpSender::replaceTrack):
- Modules/mediastream/RTCRtpSender.h:
(WebCore::RTCRtpSenderClient::~RTCRtpSenderClient):
(WebCore::RTCRtpSender::create):
(WebCore::RTCRtpSender::trackId):
(WebCore::RTCRtpSender::stop):
- Modules/mediastream/RTCRtpSender.idl:
LayoutTests:
Add API test for RTCRtpSender.replaceTrack(). A successful call is still
rejected (promise) until proper support is available in the WebRTC backend.
- fast/mediastream/RTCRtpSender-replaceTrack-expected.txt: Added.
- fast/mediastream/RTCRtpSender-replaceTrack.html: Added.
- 10:42 AM Changeset in webkit [194967] by
-
- 8 edits1 add in trunk/Source/WebCore
Modern IDB: A few cursor tests are flaky because JS wrappers are GC'ed.
https://bugs.webkit.org/show_bug.cgi?id=153038
Reviewed by Alex Christensen.
No new tests (Couldn't write a test that was any more reliable than "flaky", so fixing the existing flaky tests will do).
And IDBCursor has an associated IDBRequest that is re-used each time the IDBCursor iterates.
The normal ActiveDOMObject approach to prevent the IDBRequest's wrapper from being garbage collected was not good enough
because, while the IDBRequest may not currently be waiting on any activity, as long as its associated IDBCursor is still
reachable then the request might be reused in the future.
Fortunately there's an IDL allowance for "one object keeping another alive during GC" and that's JSCustomMarkFunction
combined with GenerateIsReachable.
Applying those to IDBCursor and IDBRequest fix this handily.
- CMakeLists.txt:
- WebCore.xcodeproj/project.pbxproj:
- Modules/indexeddb/IDBCursor.h:
(WebCore::IDBCursor::isModernCursor):
- Modules/indexeddb/IDBCursor.idl:
- Modules/indexeddb/IDBRequest.idl:
- Modules/indexeddb/client/IDBCursorImpl.cpp:
(WebCore::IDBClient::IDBCursor::advance):
(WebCore::IDBClient::IDBCursor::continueFunction):
(WebCore::IDBClient::IDBCursor::uncheckedIterateCursor):
(WebCore::IDBClient::IDBCursor::uncheckedIteratorCursor): Deleted. Fixed the typo of this name.
- Modules/indexeddb/client/IDBCursorImpl.h:
- bindings/js/JSIDBCursorCustom.cpp: Added.
(WebCore::JSIDBCursor::visitAdditionalChildren):
- 10:19 AM Changeset in webkit [194966] by
-
- 8 edits in trunk/Source/WebCore
Get text drawing working with display lists.
https://bugs.webkit.org/show_bug.cgi?id=152957
Reviewed by Simon Fraser.
This patch enables text drawing for display lists.
- platform/graphics/FontCascade.cpp:
(WebCore::FontCascade::drawGlyphBuffer):
- platform/graphics/FontCascade.h:
- platform/graphics/GraphicsContext.cpp:
(WebCore::GraphicsContext::drawGlyphs):
(WebCore::GraphicsContext::drawText): Deleted.
- platform/graphics/cocoa/FontCascadeCocoa.mm:
(WebCore::FontCascade::drawGlyphs):
- platform/graphics/displaylists/DisplayListItems.cpp:
(WebCore::DisplayList::DrawGlyphs::apply):
- 9:08 AM Changeset in webkit [194965] by
-
- 10 edits in trunk
Simple line layout: Add support for word-break property.
https://bugs.webkit.org/show_bug.cgi?id=153054
Reviewed by Antti Koivisto.
This patch enables word-break property for simple line layout.
(https://drafts.csswg.org/css-text-3/#propdef-word-break)
word-break: normal and keep-all -> existing, non-(force)breaking behaviour.
break-all -> breaks words when needed.
Covered by existing tests like fast/text/word-break.html
- rendering/SimpleLineLayout.cpp:
(WebCore::SimpleLineLayout::createLineRuns):
(WebCore::SimpleLineLayout::canUseForStyle): Deleted.
(WebCore::SimpleLineLayout::printReason): Deleted.
- rendering/SimpleLineLayoutTextFragmentIterator.cpp:
(WebCore::SimpleLineLayout::TextFragmentIterator::Style::Style):
(WebCore::SimpleLineLayout::TextFragmentIterator::findNextTextFragment):
- rendering/SimpleLineLayoutTextFragmentIterator.h:
(WebCore::SimpleLineLayout::TextFragmentIterator::TextFragment::TextFragment):
(WebCore::SimpleLineLayout::TextFragmentIterator::TextFragment::operator==):
(WebCore::SimpleLineLayout::TextFragmentIterator::TextFragment::isBreakable): Deleted.
(WebCore::SimpleLineLayout::TextFragmentIterator::TextFragment::split): Deleted.
- 9:04 AM Changeset in webkit [194964] by
-
- 30 edits in trunk/Source/WebCore
Reference cycle between SVGPathElement and SVGPathSegWithContext leaks Document
https://bugs.webkit.org/show_bug.cgi?id=151810
Patch by Said Abou-Hallawa <sabouhallawa@apple.com> on 2016-01-13
Reviewed by Darin Adler.
Break the reference cycle between SVGPathElement and SVGPathSegWithContext
by changing the back-pointer to be a WeakPtr pointer instead of having it
RefPtr. Make sure the SVGPathSegWithContext derived classes handle correctly
the case when the SVGPathElement back-pointer is deleted.
Also change the SVGPathElement argument to the SVGPathSeg creation functions
and constructors to be a const reference instead of having it as a pointer
since SVGPathElement is the class factory for all these classes.
- svg/SVGPathElement.cpp:
(WebCore::SVGPathElement::SVGPathElement):
(WebCore::SVGPathElement::createSVGPathSegClosePath):
(WebCore::SVGPathElement::createSVGPathSegMovetoAbs):
(WebCore::SVGPathElement::createSVGPathSegMovetoRel):
(WebCore::SVGPathElement::createSVGPathSegLinetoAbs):
(WebCore::SVGPathElement::createSVGPathSegLinetoRel):
(WebCore::SVGPathElement::createSVGPathSegCurvetoCubicAbs):
(WebCore::SVGPathElement::createSVGPathSegCurvetoCubicRel):
(WebCore::SVGPathElement::createSVGPathSegCurvetoQuadraticAbs):
(WebCore::SVGPathElement::createSVGPathSegCurvetoQuadraticRel):
(WebCore::SVGPathElement::createSVGPathSegArcAbs):
(WebCore::SVGPathElement::createSVGPathSegArcRel):
(WebCore::SVGPathElement::createSVGPathSegLinetoHorizontalAbs):
(WebCore::SVGPathElement::createSVGPathSegLinetoHorizontalRel):
(WebCore::SVGPathElement::createSVGPathSegLinetoVerticalAbs):
(WebCore::SVGPathElement::createSVGPathSegLinetoVerticalRel):
(WebCore::SVGPathElement::createSVGPathSegCurvetoCubicSmoothAbs):
(WebCore::SVGPathElement::createSVGPathSegCurvetoCubicSmoothRel):
(WebCore::SVGPathElement::createSVGPathSegCurvetoQuadraticSmoothAbs):
(WebCore::SVGPathElement::createSVGPathSegCurvetoQuadraticSmoothRel):
(WebCore::SVGPathElement::isSupportedAttribute):
- svg/SVGPathElement.h:
- svg/SVGPathSegArc.h:
(WebCore::SVGPathSegArc::SVGPathSegArc):
- svg/SVGPathSegArcAbs.h:
(WebCore::SVGPathSegArcAbs::create):
(WebCore::SVGPathSegArcAbs::SVGPathSegArcAbs):
- svg/SVGPathSegArcRel.h:
(WebCore::SVGPathSegArcRel::create):
(WebCore::SVGPathSegArcRel::SVGPathSegArcRel):
- svg/SVGPathSegClosePath.h:
(WebCore::SVGPathSegClosePath::create):
(WebCore::SVGPathSegClosePath::SVGPathSegClosePath):
- svg/SVGPathSegCurvetoCubic.h:
(WebCore::SVGPathSegCurvetoCubic::SVGPathSegCurvetoCubic):
- svg/SVGPathSegCurvetoCubicAbs.h:
(WebCore::SVGPathSegCurvetoCubicAbs::create):
(WebCore::SVGPathSegCurvetoCubicAbs::SVGPathSegCurvetoCubicAbs):
- svg/SVGPathSegCurvetoCubicRel.h:
(WebCore::SVGPathSegCurvetoCubicRel::create):
(WebCore::SVGPathSegCurvetoCubicRel::SVGPathSegCurvetoCubicRel):
- svg/SVGPathSegCurvetoCubicSmooth.h:
(WebCore::SVGPathSegCurvetoCubicSmooth::SVGPathSegCurvetoCubicSmooth):
- svg/SVGPathSegCurvetoCubicSmoothAbs.h:
(WebCore::SVGPathSegCurvetoCubicSmoothAbs::create):
(WebCore::SVGPathSegCurvetoCubicSmoothAbs::SVGPathSegCurvetoCubicSmoothAbs):
- svg/SVGPathSegCurvetoCubicSmoothRel.h:
(WebCore::SVGPathSegCurvetoCubicSmoothRel::create):
(WebCore::SVGPathSegCurvetoCubicSmoothRel::SVGPathSegCurvetoCubicSmoothRel):
- svg/SVGPathSegCurvetoQuadratic.h:
(WebCore::SVGPathSegCurvetoQuadratic::SVGPathSegCurvetoQuadratic):
- svg/SVGPathSegCurvetoQuadraticAbs.h:
(WebCore::SVGPathSegCurvetoQuadraticAbs::create):
(WebCore::SVGPathSegCurvetoQuadraticAbs::SVGPathSegCurvetoQuadraticAbs):
- svg/SVGPathSegCurvetoQuadraticRel.h:
(WebCore::SVGPathSegCurvetoQuadraticRel::create):
(WebCore::SVGPathSegCurvetoQuadraticRel::SVGPathSegCurvetoQuadraticRel):
- svg/SVGPathSegCurvetoQuadraticSmoothAbs.h:
(WebCore::SVGPathSegCurvetoQuadraticSmoothAbs::create):
(WebCore::SVGPathSegCurvetoQuadraticSmoothAbs::SVGPathSegCurvetoQuadraticSmoothAbs):
- svg/SVGPathSegCurvetoQuadraticSmoothRel.h:
(WebCore::SVGPathSegCurvetoQuadraticSmoothRel::create):
(WebCore::SVGPathSegCurvetoQuadraticSmoothRel::SVGPathSegCurvetoQuadraticSmoothRel):
- svg/SVGPathSegLinetoAbs.h:
(WebCore::SVGPathSegLinetoAbs::create):
(WebCore::SVGPathSegLinetoAbs::SVGPathSegLinetoAbs):
- svg/SVGPathSegLinetoHorizontal.h:
(WebCore::SVGPathSegLinetoHorizontal::SVGPathSegLinetoHorizontal):
- svg/SVGPathSegLinetoHorizontalAbs.h:
(WebCore::SVGPathSegLinetoHorizontalAbs::create):
(WebCore::SVGPathSegLinetoHorizontalAbs::SVGPathSegLinetoHorizontalAbs):
- svg/SVGPathSegLinetoHorizontalRel.h:
(WebCore::SVGPathSegLinetoHorizontalRel::create):
(WebCore::SVGPathSegLinetoHorizontalRel::SVGPathSegLinetoHorizontalRel):
- svg/SVGPathSegLinetoRel.h:
(WebCore::SVGPathSegLinetoRel::create):
(WebCore::SVGPathSegLinetoRel::SVGPathSegLinetoRel):
- svg/SVGPathSegLinetoVertical.h:
(WebCore::SVGPathSegLinetoVertical::SVGPathSegLinetoVertical):
- svg/SVGPathSegLinetoVerticalAbs.h:
(WebCore::SVGPathSegLinetoVerticalAbs::create):
(WebCore::SVGPathSegLinetoVerticalAbs::SVGPathSegLinetoVerticalAbs):
- svg/SVGPathSegLinetoVerticalRel.h:
(WebCore::SVGPathSegLinetoVerticalRel::create):
(WebCore::SVGPathSegLinetoVerticalRel::SVGPathSegLinetoVerticalRel):
- svg/SVGPathSegMovetoAbs.h:
(WebCore::SVGPathSegMovetoAbs::create):
(WebCore::SVGPathSegMovetoAbs::SVGPathSegMovetoAbs):
- svg/SVGPathSegMovetoRel.h:
(WebCore::SVGPathSegMovetoRel::create):
(WebCore::SVGPathSegMovetoRel::SVGPathSegMovetoRel):
- svg/SVGPathSegWithContext.h:
(WebCore::SVGPathSegWithContext::SVGPathSegWithContext):
(WebCore::SVGPathSegWithContext::animatedProperty):
(WebCore::SVGPathSegWithContext::contextElement):
(WebCore::SVGPathSegWithContext::setContextAndRole):
(WebCore::SVGPathSegWithContext::commitChange):
(WebCore::SVGPathSegSingleCoordinate::setY):
(WebCore::SVGPathSegSingleCoordinate::SVGPathSegSingleCoordinate):
- svg/properties/SVGPathSegListPropertyTearOff.cpp:
(WebCore::SVGPathSegListPropertyTearOff::clearContextAndRoles):
(WebCore::SVGPathSegListPropertyTearOff::replaceItem):
(WebCore::SVGPathSegListPropertyTearOff::removeItem):
- 6:52 AM Changeset in webkit [194963] by
-
- 23 edits2 adds in trunk/Source
Source/WebCore:
Use BumpArena for style sheet object tree.
<https://webkit.org/b/152696>
Reviewed by Antti Koivisto.
Give each StyleSheetContents its own BumpArena, and plumb it down through CSSParser
to allocate StyleRule, StyleProperties and CSSSelectorList's selector arrays there.
This basically means that most objects that make up a given style sheet will end up
in one (or a few) contiguous region(s) of memory, instead of being scattered all
over the malloc heap.
In the common case (no CSSOM manipulation), the lifetimes of these objects are very
predictable: everything tends to die when the StyleSheetContents dies.
This dramatically improves space-efficiency in those cases, and allows us to return
contiguous chunks of memory to the system once a style sheet is no longer needed.
One-off CSS parses that don't work within a StyleSheetContents context will have
their StyleRules & co allocated out of the global BumpArena.
Bonus: give SelectorQueryCache a dedicated BumpArena as well, since it has very
predictable lifetime.
- css/CSSGrammar.y.in:
- css/CSSKeyframesRule.h:
(WebCore::StyleRuleKeyframes::create):
- css/CSSParser.cpp:
(WebCore::CSSParser::createStyleProperties):
(WebCore::CSSParser::createMediaRule):
(WebCore::CSSParser::createSupportsRule):
(WebCore::CSSParser::createKeyframesRule):
(WebCore::CSSParser::setArena):
(WebCore::CSSParser::arena):
(WebCore::CSSParser::createStyleRule):
(WebCore::CSSParser::createFontFaceRule):
(WebCore::CSSParser::createPageRule):
(WebCore::CSSParser::createRegionRule):
(WebCore::CSSParser::createViewportRule):
- css/CSSParser.h:
- css/CSSParserValues.cpp:
(WebCore::CSSParserSelector::parsePseudoElementCueFunctionSelector):
(WebCore::CSSParserSelector::adoptSelectorVector):
- css/CSSParserValues.h:
- css/CSSSelectorList.cpp:
(WebCore::CSSSelectorList::CSSSelectorList):
(WebCore::CSSSelectorList::adoptSelectorVector):
(WebCore::CSSSelectorList::deleteSelectors):
- css/CSSSelectorList.h:
- css/StyleProperties.cpp:
(WebCore::ImmutableStyleProperties::create):
(WebCore::StyleProperties::immutableCopyIfNeeded):
- css/StyleProperties.h:
- css/StyleRule.cpp:
(WebCore::StyleRule::create):
(WebCore::StyleRule::splitIntoMultipleRulesWithMaximumSelectorComponentCount):
(WebCore::StyleRuleRegion::StyleRuleRegion):
- css/StyleRule.h:
(WebCore::StyleRule::create):
(WebCore::StyleRule::parserAdoptSelectorVector):
(WebCore::StyleRuleFontFace::create):
(WebCore::StyleRulePage::create):
(WebCore::StyleRulePage::parserAdoptSelectorVector):
(WebCore::StyleRuleMedia::create):
(WebCore::StyleRuleSupports::create):
(WebCore::StyleRuleRegion::create):
(WebCore::StyleRuleViewport::create):
- css/StyleSheetContents.cpp:
(WebCore::StyleSheetContents::StyleSheetContents):
(WebCore::StyleSheetContents::parseAuthorStyleSheet):
(WebCore::StyleSheetContents::parseStringAtPosition):
- css/StyleSheetContents.h:
- dom/SelectorQuery.cpp:
(WebCore::SelectorQueryCache::SelectorQueryCache):
(WebCore::SelectorQueryCache::add):
- dom/SelectorQuery.h:
- svg/SVGFontFaceElement.cpp:
(WebCore::SVGFontFaceElement::SVGFontFaceElement):
Source/WTF:
Fragmentation-free allocator for timeless and/or coupled allocations.
<https://webkit.org/b/152696>
Reviewed by Antti Koivisto.
Introduce BumpArena, a space-efficient memory allocator for situations where
you feel pretty confident betting on allocation lifetimes.
Basic design:
- Allocates 4kB-aligned blocks of 4kB from bmalloc at a time.
- Bump-pointer allocates out of a block until it reaches end.
- Each allocation increments the ref-count of its block.
- Each deallocation decrements the ref-count of its block.
Interface:
- BumpArena::create()
Create your very own BumpArena!
- BumpArena::allocate(BumpArena* arena, size_t size)
Allocates 'size' bytes of memory from 'arena'.
If 'arena' is null, allocation comes out of the shared global BumpArena.
- BumpArena::deallocate(void* ptr)
Deallocates 'ptr', decrementing the ref-count of its block.
- WTF_MAKE_BUMPARENA_ALLOCATED;
Macro that gives a class or struct custom operators new and delete
for allocation out of BumpArena. Just like WTF_MAKE_FAST_ALLOCATED;
Note that while the name of this patch says "fragmentation-free allocator"
it will only be fragmentation-free when used for appropriate things.
This is not meant to be a general-purpose allocator. Only use it for sets of
allocations that are known to die roughly at the same time.
BumpArena will never resume allocating from a block that has been filled,
so it's even more important than usual that everything gets deallocated.
As noted above, calling allocate() with a null BumpArena will allocate out
of a global shared arena. Ideally you're always allocating out of a specific,
controlled arena, but there are situations where you may not have one.
- WTF.vcxproj/WTF.vcxproj:
- WTF.vcxproj/WTF.vcxproj.filters:
- WTF.xcodeproj/project.pbxproj:
- wtf/BumpArena.cpp: Added.
(WTF::BumpArena::Block::defaultCapacity):
(WTF::BumpArena::Block::arena):
(WTF::BumpArena::Block::payloadStart):
(WTF::globalArena):
(WTF::arenas):
(WTF::BumpArena::Block::Block):
(WTF::BumpArena::Block::~Block):
(WTF::BumpArena::Block::ref):
(WTF::BumpArena::Block::deref):
(WTF::BumpArena::Block::create):
(WTF::BumpArena::Block::dump):
(WTF::BumpArena::dump):
(WTF::BumpArena::create):
(WTF::BumpArena::BumpArena):
(WTF::BumpArena::~BumpArena):
(WTF::BumpArena::allocateSlow):
(WTF::BumpArena::allocate):
(WTF::BumpArena::deallocate):
(WTF::BumpArena::Block::blockFor):
(WTF::BumpArena::arenaFor):
- wtf/BumpArena.h: Added.
- wtf/CMakeLists.txt:
- 4:30 AM Changeset in webkit [194962] by
-
- 2 edits in trunk/LayoutTests
[GTK] Unreviewed gardening.
Patch by Mario Sanchez Prada <mario@webkit.org> on 2016-01-13
- platform/gtk/TestExpectations: Mark three tests failing in the
GTK bots as Crash, Timeout (release builds only) and Failure.
- 4:29 AM WebKitGTK/Gardening/Calendar edited by
- (diff)
- 2:32 AM Changeset in webkit [194961] by
-
- 2 edits in trunk/Source/WebCore
[TexMap] BitmapTextureGL is not released while scene is updated continuously.
https://bugs.webkit.org/show_bug.cgi?id=152524
Patch by YongGeol Jung <yg48.jung@samsung.com> on 2016-01-13
Reviewed by Žan Doberšek.
This patch fixes two issues.
First, m_releaseUnusedTexturesTimer is not fired if scene is updated within 0.5s continuously.
In this case, BitmapTexturePool will not remove texture even if texture is not used for long time.
Second, m_releaseUnusedTexturesTimer is triggered by acquireTexture function only.
So, if next scene does not need to use BitmapTexture, remained textures in pool will not removed.
No new tests needed.
- platform/graphics/texmap/BitmapTexturePool.cpp:
(WebCore::BitmapTexturePool::scheduleReleaseUnusedTextures):
(WebCore::BitmapTexturePool::releaseUnusedTexturesTimerFired):
- 1:54 AM Changeset in webkit [194960] by
-
- 11 edits1 add in trunk/Source/WebCore
[Streams API] Refactor builtin internals to prepare support for streams API in worker
https://bugs.webkit.org/show_bug.cgi?id=152535
Reviewed by Darin Adler.
Moving the code that links internal functions to the GlobalObject in WebCoreJSBuiltinInternals.cpp.
This file should be generated by the builtin generator once refactoring is done.
This code is located in JSBuiltinInternalFunctions::initialize.
Adding private controller and reader constructors to the JS DOM constructor map so that they do not get garbage collected.
No change in behavior, except that private builtins are usable in workers (but not actually used).
- CMakeLists.txt:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSDOMGlobalObject.cpp:
(WebCore::JSDOMGlobalObject::JSDOMGlobalObject):
(WebCore::JSDOMGlobalObject::addBuiltinGlobals):
(WebCore::JSDOMGlobalObject::finishCreation):
(WebCore::JSDOMGlobalObject::visitChildren):
- bindings/js/JSDOMGlobalObject.h:
- bindings/js/JSDOMWindowBase.cpp:
(WebCore::JSDOMWindowBase::finishCreation):
(WebCore::JSDOMWindowBase::visitChildren):
- bindings/js/JSDOMWindowBase.h:
- bindings/js/WebCoreJSBuiltinInternals.cpp: Added.
(WebCore::JSBuiltinInternalFunctions::JSBuiltinInternalFunctions):
(WebCore::JSBuiltinInternalFunctions::visit):
(WebCore::JSBuiltinInternalFunctions::initialize):
- bindings/js/WebCoreJSBuiltinInternals.h:
- 12:15 AM Changeset in webkit [194959] by
-
- 1 copy in releases/WebKitGTK/webkit-2.11.3
WebKitGTK+ 2.11.3
- 12:12 AM Changeset in webkit [194958] by
-
- 4 edits in trunk
Unreviewed. Update OptionsGTK.cmake and NEWS for 2.11.3 release.
.:
- Source/cmake/OptionsGTK.cmake: Bump version numbers.
Source/WebKit2:
- gtk/NEWS: Add release notes for 2.11.3.
- 12:01 AM Changeset in webkit [194957] by
-
- 2 edits in trunk/Source/WebCore
[EFL] Fix wrong return value of paintThemePart in RenderThemeEfl
https://bugs.webkit.org/show_bug.cgi?id=153058
Reviewed by Carlos Garcia Campos.
To return false in paint functions in RenderThemeEfl means that it is supported though,
paintThemePart has returned false even when failing to get image cache of theme.
- rendering/RenderThemeEfl.cpp:
(WebCore::RenderThemeEfl::paintThemePart):
Jan 12, 2016:
- 10:58 PM Changeset in webkit [194956] by
-
- 3 edits in trunk/Source/WebCore
[Content Filtering] forEachContentFilterUntilBlocked should accept a lambda by rvalue reference
https://bugs.webkit.org/show_bug.cgi?id=153057
Reviewed by Dan Bernstein.
No new tests. No change in behavior.
Instead of having ContentFilter::forEachContentFilterUntilBlocked() take a std::function, just have it take an
rvalue reference to the lambda its passed.
- loader/ContentFilter.cpp:
(WebCore::ContentFilter::forEachContentFilterUntilBlocked):
- loader/ContentFilter.h:
- 10:47 PM Changeset in webkit [194955] by
-
- 3 edits in trunk/Source/WebCore
[GTK] Fix return value of some paint methods in RenderThemeGtk
https://bugs.webkit.org/show_bug.cgi?id=153015
Reviewed by Michael Catanzaro.
The bool value returned by paint methods in RenderTheme means
whether the appearance is supported or not, so we should return
true when not supported (so we didn't paint anything) and false
when supported (so we actually painted the theme part).
- rendering/RenderThemeGtk.cpp:
(WebCore::RenderThemeGtk::paintSearchFieldResultsDecorationPart):
(WebCore::RenderThemeGtk::paintSearchFieldCancelButton):
(WebCore::RenderThemeGtk::paintMediaButton):
(WebCore::RenderThemeGtk::paintMediaMuteButton):
(WebCore::RenderThemeGtk::paintMediaPlayButton):
(WebCore::RenderThemeGtk::paintMediaSliderTrack):
(WebCore::RenderThemeGtk::paintMediaVolumeSliderContainer): Deleted.
- rendering/RenderThemeGtk.h:
- 9:55 PM Changeset in webkit [194954] by
-
- 5 edits in trunk/Source
Versioning.
- 9:48 PM Changeset in webkit [194953] by
-
- 1 copy in tags/Safari-602.1.16
New tag.
- 7:23 PM Changeset in webkit [194952] by
-
- 10 edits in trunk/Source/WebCore
[Content Filtering] De-virtualize PlatformContentFilter::{needsMoreData, didBlockData}()
https://bugs.webkit.org/show_bug.cgi?id=153052
Reviewed by Andreas Kling.
No new tests. No change in behavior.
Instead of having virtual functions that each platform content filter implement in terms of their own state,
store the state in the base class so that these functions can be non-virtual. Teach each subclass to update the
base class state appropriately.
- loader/ContentFilter.h:
- platform/PlatformContentFilter.h:
(WebCore::PlatformContentFilter::needsMoreData):
(WebCore::PlatformContentFilter::didBlockData):
- platform/cocoa/NetworkExtensionContentFilter.h:
- platform/cocoa/NetworkExtensionContentFilter.mm:
(WebCore::NetworkExtensionContentFilter::willSendRequest):
(WebCore::NetworkExtensionContentFilter::responseReceived):
(WebCore::NetworkExtensionContentFilter::handleDecision):
(WebCore::NetworkExtensionContentFilter::NetworkExtensionContentFilter): Deleted.
(WebCore::NetworkExtensionContentFilter::needsMoreData): Deleted.
(WebCore::NetworkExtensionContentFilter::didBlockData): Deleted.
- platform/cocoa/ParentalControlsContentFilter.h:
- platform/cocoa/ParentalControlsContentFilter.mm:
(WebCore::ParentalControlsContentFilter::responseReceived):
(WebCore::ParentalControlsContentFilter::updateFilterState):
(WebCore::ParentalControlsContentFilter::ParentalControlsContentFilter): Deleted.
(WebCore::ParentalControlsContentFilter::needsMoreData): Deleted.
(WebCore::ParentalControlsContentFilter::didBlockData): Deleted.
- platform/spi/cocoa/NEFilterSourceSPI.h:
- testing/MockContentFilter.cpp:
(WebCore::MockContentFilter::willSendRequest):
(WebCore::MockContentFilter::maybeDetermineStatus):
(WebCore::MockContentFilter::needsMoreData): Deleted.
(WebCore::MockContentFilter::didBlockData): Deleted.
- testing/MockContentFilter.h:
- 6:09 PM Changeset in webkit [194951] by
-
- 2 edits in trunk/Source/WebCore
Address missed review feedback after r194950.
- platform/cocoa/NetworkExtensionContentFilter.mm:
(WebCore::NetworkExtensionContentFilter::initialize): Renamed the NetworkExtension dispatch queue.
- 6:07 PM Changeset in webkit [194950] by
-
- 22 edits1 copy1 add in trunk
[Content Filtering] Lazily load platform frameworks
https://bugs.webkit.org/show_bug.cgi?id=152881
rdar://problem/23270886
Reviewed by Brady Eidson.
Source/WebCore:
On Cocoa platforms, ContentFilter soft-links two frameworks that perform the underlying filtering operations.
There is a one-time cost associated with the soft-linking, and the current design requires all clients to pay
this cost whether or not they ever load a resource that is subject to filtering.
Addressed this by deferring the loading of frameworks until it is known that a resource will require filtering.
It is rather simple to defer the soft-linking at the PlatformContentFilter level, but doing this alone would
mean that every CachedRawResourceClient callback would be routed through ContentFilter, even in the very common
case where both platform content filters are disabled. This is because checking if a platform content filter is
enabled involves loading its framework, so creating a ContentFilter (which DocumentLoader will add as the
CachedRawResource client in place of itself) cannot be avoided by checking that all its platform content filters
are disabled.
Resolved this by inverting the relationship between ContentFilter and DocumentLoader. Instead of ContentFilter
being the CachedRawResource's client and forwarding callbacks to DocumentLoader when one or more platform
filters are enabled, DocumentLoader is now always the client and it forwards callbacks to ContentFilter.
ContentFilter then returns a boolean value indicating whether or not DocumentLoader should proceed with each
callback.
New API test: ContentFiltering.LazilyLoadPlatformFrameworks
- loader/ContentFilter.cpp:
(WebCore::ContentFilter::create): Renamed from createIfEnabled(). Since the enabled check causes frameworks to
be loaded, the check is skipped here and all types are always created.
(WebCore::ContentFilter::continueAfterWillSendRequest): Renamed from willSendRequest(). Renamed requestCopy to
originalRequest, and only created it for logging purposes. Since the copy was only used for logging purposes,
request is now modified directly. Returned false if request is null.
(WebCore::ContentFilter::continueAfterResponseReceived): Renamed from responseReceived(). Stopped asserting that
resource is non-null, since it will be null in the case of substitute data loads. Stopped asserting that m_state
is not Initialized, since that state was removed and the function can now be called in all states. Only logged
if m_state is Filtering. Returned false if m_state is Blocked.
(WebCore::ContentFilter::continueAfterDataReceived): Renamed from dataReceived(). Stopped asserting that
resource is non-null and that m_state is Initialized, and moved the logging, for the same reasons as above.
Returned false if m_state is Filtering or Blocked.
(WebCore::ContentFilter::continueAfterNotifyFinished): Renamed from notifyFinished(). Stopped asserting that
resource is non-null and that m_state is not Initialized, and moved the logging, for the same reasons as above.
If m_state is not Blocked at this point, set m_state to Allowed in order for deliverResourceData() to not get
caught in continueAfterDataReceived(). Returned false if m_state is Blocked or Stopped after delivering data.
(WebCore::ContentFilter::createIfEnabled): Renamed to create().
(WebCore::ContentFilter::~ContentFilter): Stopped removing ourself as m_mainResource's client.
(WebCore::ContentFilter::willSendRequest): Renamed to continueAfterWillSendRequest().
(WebCore::ContentFilter::startFilteringMainResource): Stopped adding ourself as m_mainResource's client. Stopped
asserting that m_state is not Initialized and instead returned early if m_state is not Stopped.
(WebCore::ContentFilter::stopFilteringMainResource): Stopped removing ourself as m_mainResource's client.
(WebCore::ContentFilter::responseReceived): Renamed to continueAfterResponseReceived().
(WebCore::ContentFilter::dataReceived): Renamed to continueAfterDataReceived().
(WebCore::ContentFilter::redirectReceived): Removed. DocumentLoader now calls continueAfterWillSendRequest()
directly on redirects.
(WebCore::ContentFilter::notifyFinished): Renamed to continueAfterNotifyFinished().
(WebCore::ContentFilter::didDecide): Instead of calling DocumentLoader::contentFilterDidDecide(), called
DocumentLoader::contentFilterDidBlock() when m_state is Blocked.
(WebCore::ContentFilter::deliverResourceData): Asserted that m_state is Allowed.
- loader/ContentFilter.h: Stopped inheriting from CachedRawResourceClient. Redeclared the
CachedRawResourceClient virtual functions as the continue* functions mentioned above. Made State enum private
and removed Initialized. Initialized m_state to Stopped and removed its getter.
(WebCore::ContentFilter::type): Returned a ContentFilter::Type that does not include an enabled function.
- loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::notifyFinished): Returned early if ContentFilter::continueAfterNotifyFinished()
returned false.
(WebCore::DocumentLoader::willSendRequest): Called ContentFilter::continueAfterWillSendRequest() even for
redirects, since ContentFilter is no longer a CachedRawResourceClient and so will no longer receive
redirectReceived(). Returned early if continueAfterWillSendRequest() returns false.
(WebCore::DocumentLoader::responseReceived): Returned early if ContentFilter::continueAfterResponseReceived()
returned false.
(WebCore::DocumentLoader::dataReceived): Ditto for ContentFilter::continueAfterDataReceived().
(WebCore::DocumentLoader::startLoadingMainResource): Called ContentFilter::create(), not createIfEnabled().
(WebCore::DocumentLoader::becomeMainResourceClient): Called ContentFilter::startFilteringMainResource() even if
m_state is not Initialized. Added ourself as a client of m_mainResource unconditionally.
(WebCore::DocumentLoader::contentFilterDidBlock): Renamed from contentFilterDidDecide. Removed assertions and
the early return when m_state is Allowed, since the state is guaranteed to be Blocked.
(WebCore::DocumentLoader::contentFilterDidDecide): Renamed to contentFilterDidBlock.
- platform/cocoa/NetworkExtensionContentFilter.h: Moved definition of HAVE_NETWORK_EXTENSION to Platform.h so
that this file doesn't need to become a Private header. Made enabled() private, and declared initialize().
- platform/cocoa/NetworkExtensionContentFilter.mm:
(WebCore::NetworkExtensionContentFilter::initialize): Added a function to lazily initialize the object.
(WebCore::NetworkExtensionContentFilter::willSendRequest): For the modern NEFilterSource, checked if it is
enabled only after checking if the request is HTTP(S). If both checks pass, then called initialize().
(WebCore::NetworkExtensionContentFilter::responseReceived): Ditto for the legacy NEFilterSource.
- platform/cocoa/ParentalControlsContentFilter.h: Made enabled() private.
- platform/cocoa/ParentalControlsContentFilter.mm:
(WebCore::ParentalControlsContentFilter::responseReceived): Checked if WebFilterEvaluator is enabled only after
checking if the response is from a protocol that can be handled.
- testing/MockContentFilter.cpp:
(WebCore::MockContentFilter::willSendRequest): Immediately set m_status to Status::Allowed if !enabled().
- testing/MockContentFilter.h: Made enabled() private.
Source/WTF:
- wtf/Platform.h: Moved definition of HAVE_NETWORK_EXTENSION to here from WebCore/platform/cocoa/NetworkExtensionContentFilter.h.
Tools:
Added an API test that verifies that the Parental Controls and Network Extension frameworks are loaded at the
expected times. The test verifies that they are not loaded after creating a WKWebView, loading an HTML string,
loading NSData, loading a file, or loading from a custom protocol. It verifies that Network Extension on Mac/iOS
and Parental Controls on iOS are loaded after an HTTP request. It finally verifies that Parental Controls on Mac
is loaded after an HTTPS request.
To accomplish this, TestProtocol was generalized to allow tests to specify the scheme they wish to use.
Other tests that used TestProtocol were updated to account for this change. TestProtocol was removed from
WebKit2.PreventImageLoadWithAutoResizingTest, which didn't actually need to use it. ContentFiltering tests were
also re-enabled on iOS after mistakenly being disabled by r188892.
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
(TestWebKitAPI::TEST):
- TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.h: Added.
- TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.html: Added.
- TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm:
(TEST):
(downloadTest):
(-[LazilyLoadPlatformFrameworksController init]):
(-[LazilyLoadPlatformFrameworksController webView]):
(-[LazilyLoadPlatformFrameworksController expectParentalControlsLoaded:networkExtensionLoaded:]):
(-[LazilyLoadPlatformFrameworksController webView:didFinishNavigation:]):
- TestWebKitAPI/Tests/WebKit2Cocoa/ContentFilteringPlugIn.mm:
(-[ContentFilteringPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
(-[ContentFilteringPlugIn observeValueForKeyPath:ofObject:change:context:]):
(-[ContentFilteringPlugIn checkIfPlatformFrameworksAreLoaded:]):
- TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
(TestWebKitAPI::TEST):
- TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing.mm:
(TestWebKitAPI::TEST): Deleted.
- TestWebKitAPI/cocoa/TestProtocol.h:
- TestWebKitAPI/cocoa/TestProtocol.mm:
(+[TestProtocol registerWithScheme:]):
(+[TestProtocol unregister]):
- 5:41 PM Changeset in webkit [194949] by
-
- 2 edits in branches/safari-601-branch/Source/ThirdParty/ANGLE
Merge r194780. rdar://problem/24043054
- 5:41 PM Changeset in webkit [194948] by
-
- 4 edits in branches/safari-601-branch/Source/WebCore
Merge r194751. rdar://problem/24043054
- 5:41 PM Changeset in webkit [194947] by
-
- 3 edits in branches/safari-601-branch/Source/WebCore
Merge r194745. rdar://problem/24101258
- 5:41 PM Changeset in webkit [194946] by
-
- 6 edits3 adds in branches/safari-601-branch
Merge r194704. rdar://problem/24043057
- 5:41 PM Changeset in webkit [194945] by
-
- 5 edits2 adds in branches/safari-601-branch
Merge r194910. rdar://problem/24101255
- 5:41 PM Changeset in webkit [194944] by
-
- 2 edits in branches/safari-601-branch/Source/WebInspectorUI
Merge r194602. rdar://problem/24101260
- 5:41 PM Changeset in webkit [194943] by
-
- 2 edits in branches/safari-601-branch/Source/WebCore
Merge r194589. rdar://problem/24101250
- 5:41 PM Changeset in webkit [194942] by
-
- 7 edits2 adds in branches/safari-601-branch
Merge r194083. rdar://problem/24101257
- 5:41 PM Changeset in webkit [194941] by
-
- 2 edits in branches/safari-601-branch/Source/WebInspectorUI
Merge r194066. rdar://problem/24101252
- 5:41 PM Changeset in webkit [194940] by
-
- 2 edits in branches/safari-601-branch/Source/WebInspectorUI
Merge r194009. rdar://problem/24101259
- 5:41 PM Changeset in webkit [194939] by
-
- 2 edits in branches/safari-601-branch/Source/WebInspectorUI
Merge r193858. rdar://problem/24101282
- 5:41 PM Changeset in webkit [194938] by
-
- 20 edits2 copies4 adds2 deletes in branches/safari-601-branch
Merge r194908. rdar://problem/24101253
- 5:18 PM Changeset in webkit [194937] by
-
- 2 edits in trunk/LayoutTests
Changing expectation from flaky to skip for two crashing tests.
https://bugs.webkit.org/show_bug.cgi?id=152279
Unreviewed test gardening.
- platform/ios-simulator/TestExpectations:
- 5:14 PM Changeset in webkit [194936] by
-
- 4 edits in trunk/Source/WebInspectorUI
Web Inspector: Timeline recording controls should use NavigationBar
https://bugs.webkit.org/show_bug.cgi?id=152997
Reviewed by Brian Burg.
NavigtaionBar should always be preferred over manually editing the DOM.
Reusing existing button types for the record button and status element lets us
eliminate a bunch of CSS, and will make future changes to the Timelines UI
(such as adding addition recording controls), easier to implement.
- Localizations/en.lproj/localizedStrings.js:
New tooltip strings.
- UserInterface/Views/TimelineSidebarPanel.css:
(.sidebar > .panel.navigation.timeline > .navigation-bar > .item.record-start-stop):
(.sidebar > .panel.navigation.timeline > .navigation-bar > .item.record-start-stop:hover):
(.sidebar > .panel.navigation.timeline > .navigation-bar > .item.record-start-stop:active):
Replaced similar styles used for the record glyph.
(.sidebar > .panel.navigation.timeline > .navigation-bar > .item.record-start-stop *):
Prevent multiple mouseover/mouseout events while hovering the navigation item.
(.sidebar > .panel.navigation.timeline > .navigation-bar > .item.flexible-space):
Replaced similar styles used for the record status element.
(.sidebar > .panel.navigation.timeline > .status-bar): Deleted.
(body.window-inactive .sidebar > .panel.navigation.timeline > .status-bar): Deleted.
(.sidebar > .panel.navigation.timeline > .status-bar > .record-glyph): Deleted.
(.sidebar > .panel.navigation.timeline > .status-bar > .record-glyph:hover): Deleted.
(.sidebar > .panel.navigation.timeline > .status-bar > .record-glyph:active): Deleted.
(.sidebar > .panel.navigation.timeline > .status-bar > .record-glyph.recording): Deleted.
(.sidebar > .panel.navigation.timeline > .status-bar > .record-status): Deleted.
(.panel.timeline .navigation-bar.timelines-view): Deleted.
No longer used.
- UserInterface/Views/TimelineSidebarPanel.js:
Removed unused CSS static variables.
(WebInspector.TimelineSidebarPanel):
Create navigation bar, remove status bar DOM elements. Create keyboard shortcut
before the record button, so the shortcut's display name can be used in tooltips.
(WebInspector.TimelineSidebarPanel.prototype._capturingStartedOrStopped):
Update record button state and flexible space (status) text.
(WebInspector.TimelineSidebarPanel.prototype._recordButtonClicked):
Toggle recording state, and update record button state and flexible space (status) text.
(WebInspector.TimelineSidebarPanel.prototype._recordButtonMousedOver):
(WebInspector.TimelineSidebarPanel.prototype._recordButtonMousedOut):
Update flexible space (status) text.
(WebInspector.TimelineSidebarPanel.prototype._updateRecordButton):
(WebInspector.TimelineSidebarPanel.prototype._updateReplayInterfaceVisibility):
(WebInspector.TimelineSidebarPanel.prototype._toggleRecording): Deleted.
(WebInspector.TimelineSidebarPanel.prototype._capturingStarted): Deleted.
(WebInspector.TimelineSidebarPanel.prototype._capturingStopped): Deleted.
(WebInspector.TimelineSidebarPanel.prototype._recordGlyphMousedOver): Deleted.
(WebInspector.TimelineSidebarPanel.prototype._recordGlyphMousedOut): Deleted.
(WebInspector.TimelineSidebarPanel.prototype._recordGlyphClicked): Deleted.
No longer used.
- 5:05 PM Changeset in webkit [194935] by
-
- 2 edits in trunk/Websites/perf.webkit.org
buildbot syncing scripts sometimes schedule more than one requests per builder
https://bugs.webkit.org/show_bug.cgi?id=153047
Reviewed by Chris Dumez.
The bug was caused by the check for singularity of scheduledRequests being conducted per configuration
instead of per builder. So if there were multiple test configurations (e.g. Speedometer and Octane) that
both used the same builder, then we may end up scheduling both at once.
Fixed the bug by sharing a single set to keep track of the scheduled requests for all configurations per
builder.
- tools/sync-with-buildbot.py:
(load_config): Share a set amongst test configurations for each builder.
(find_request_updates): Instead of creating a new set for each configuration, reuse the existing sets to
share a single set agmonst test configurations for each builder.
- 4:32 PM Changeset in webkit [194934] by
-
- 5 edits2 deletes in trunk
Unreviewed, rolling out r194926 and r194928.
https://bugs.webkit.org/show_bug.cgi?id=153048
This change is causing LayoutTest crashes (Requested by
ryanhaddad on #webkit).
Reverted changesets:
"Avoid downloading the wrong image for <picture> elements."
https://bugs.webkit.org/show_bug.cgi?id=153027
http://trac.webkit.org/changeset/194926
"Avoid downloading the wrong image for <picture> elements."
https://bugs.webkit.org/show_bug.cgi?id=153027
http://trac.webkit.org/changeset/194928
- 4:10 PM Changeset in webkit [194933] by
-
- 5 edits2 adds in trunk
[iOS] Antialiasing doesn't work in WebGL
https://bugs.webkit.org/show_bug.cgi?id=153000
<rdar://problem/9165531>
Reviewed by Alex Christensen.
Source/WebCore:
WebGL has supported platform antialiasing since
the beginning, but we never hooked it up for iOS
because it used a slightly different extension.
Test: fast/canvas/webgl/antialiasing-enabled.html
- platform/graphics/mac/GraphicsContext3DMac.mm:
(WebCore::GraphicsContext3D::endPaint): Resolve the multisampling
buffer once we're done painting.
(WebCore::GraphicsContext3D::~GraphicsContext3D): We never created
the m_compositorTexture RenderBuffer on iOS, so no point deleting
it.
- platform/graphics/opengl/Extensions3DOpenGL.cpp:
(WebCore::Extensions3DOpenGL::supportsExtension): The iOS extension
has a slightly different name.
- platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:
(WebCore::GraphicsContext3D::reshapeFBOs): Make sure to create the
multisample buffer with the correct format.
(WebCore::GraphicsContext3D::resolveMultisamplingIfNecessary): We
need to remember what our bound frame buffer is when we
enter this call, and restore it afterwards. In the middle we can
discard our multisample read buffer once we have resolved it
into the normal framebuffer.
LayoutTests:
New test to check if WebGL antialiasing happened on a rendered canvas.
- fast/canvas/webgl/antialiasing-enabled-expected.txt: Added.
- fast/canvas/webgl/antialiasing-enabled.html: Added.
- 4:04 PM Changeset in webkit [194932] by
-
- 5 edits in trunk/Source/WebInspectorUI
Web Inspector: Move helper methods for getting icons/text to TimelineTabContentView
https://bugs.webkit.org/show_bug.cgi?id=152996
Reviewed by Brian Burg.
In preparation for the Timelines UI redesign, helper methods which existed
in the sidebar panel and timeline tree elements need to be relocated,
since the sidebar won't exist in the new UI.
- UserInterface/Views/TimelineRecordTreeElement.js:
(WebInspector.TimelineRecordTreeElement):
Removed icon/title code, replaced with calls to new helper methods.
Code to create the alternate subtitle was broken out form the rest
of the icon/title code, and kept in the constructor.
- UserInterface/Views/TimelineRecordingContentView.js:
(WebInspector.TimelineRecordingContentView.prototype._instrumentAdded):
Updated calls to helper methods.
- UserInterface/Views/TimelineSidebarPanel.js:
(WebInspector.TimelineSidebarPanel.prototype._instrumentAdded):
(WebInspector.TimelineSidebarPanel.displayNameForTimeline): Deleted.
(WebInspector.TimelineSidebarPanel.iconClassNameForTimeline): Deleted.
Moved to TimelineTabContentView.
- UserInterface/Views/TimelineTabContentView.js:
(WebInspector.TimelineTabContentView.displayNameForTimeline):
(WebInspector.TimelineTabContentView.iconClassNameForTimeline):
Relocated from TimelineSidebarPanel.
(WebInspector.TimelineTabContentView.iconClassNameForRecord):
(WebInspector.TimelineTabContentView.displayNameForRecord):
New helper methods. Previously part of TimelineRecordTreeElement.
- 4:02 PM Changeset in webkit [194931] by
-
- 2 edits in trunk/LayoutTests
Skipped more tests related to picture element on ios-simulator and grouped them together in TestExpectations file.
Unreviewed test gardening.
- platform/ios-simulator/TestExpectations:
- 3:51 PM Changeset in webkit [194930] by
-
- 2 edits in trunk/LayoutTests
Skipping crashing test fast/picture/image-picture-loads-1x.html on ios-simulator
https://bugs.webkit.org/show_bug.cgi?id=153043
Unreviewed test gardening.
- platform/ios-simulator/TestExpectations:
- 2:48 PM Changeset in webkit [194929] by
-
- 2 edits in trunk/Websites/perf.webkit.org
Analysis results viewer sometimes doesn't show the correct relative difference
https://bugs.webkit.org/show_bug.cgi?id=152930
Reviewed by Chris Dumez.
The bug was caused by single A/B testing result associated with multiple rows when there are multiple data
points with the same root set which matches that of an A/B testing.
Fixed the bug by detecting such a case, and only associating each A/B testing result with the row created
for the first matching point.
- public/v3/components/analysis-results-viewer.js:
(AnalysisResultsViewer.prototype._buildRowsForPointsAndTestGroups):
- 2:29 PM Changeset in webkit [194928] by
-
- 1 edit2 adds in trunk/LayoutTests
Avoid downloading the wrong image for <picture> elements.
https://bugs.webkit.org/show_bug.cgi?id=153027
Reviewed by Dean Jackson.
- fast/picture/image-picture-loads-1x-expected.txt: Added.
- fast/picture/image-picture-loads-1x.html: Added.
- 2:28 PM Changeset in webkit [194927] by
-
- 27 edits2 adds in trunk
XSS Auditor should navigate to empty substitute data on full page block
https://bugs.webkit.org/show_bug.cgi?id=152868
<rdar://problem/18658448>
Reviewed by David Kilzer and Andy Estes.
Derived from Blink patch (by Tom Sepez <tsepez@chromium.org>):
<https://src.chromium.org/viewvc/blink?view=rev&revision=179240>
Source/WebCore:
Test: http/tests/security/xssAuditor/block-does-not-leak-that-page-was-blocked-using-empty-data-url.html
- html/parser/XSSAuditorDelegate.cpp:
(WebCore::XSSAuditorDelegate::didBlockScript): Modified to call NavigationScheduler::schedulePageBlock().
- loader/NavigationScheduler.cpp:
(WebCore::ScheduledPageBlock::ScheduledPageBlock): Added.
(WebCore::NavigationScheduler::schedulePageBlock): Navigate to empty substitute data with
the same URL as the originating document.
- loader/NavigationScheduler.h:
LayoutTests:
Added additional test block-does-not-leak-that-page-was-blocked-using-empty-data-url.html to explicitly
tests that we do redirect to an empty data URL when a full page block is triggered.
- http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-allow-block-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-block-allow-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-block-block-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-block-filter-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-block-invalid-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-block-unset-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-filter-block-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-invalid-block-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-unset-block-expected.txt:
- http/tests/security/xssAuditor/block-does-not-leak-location-expected.txt:
- http/tests/security/xssAuditor/block-does-not-leak-referrer-expected.txt:
- http/tests/security/xssAuditor/block-does-not-leak-that-page-was-blocked-using-empty-data-url-expected.txt: Added.
- http/tests/security/xssAuditor/block-does-not-leak-that-page-was-blocked-using-empty-data-url.html: Added.
- http/tests/security/xssAuditor/full-block-base-href-expected.txt:
- http/tests/security/xssAuditor/full-block-iframe-javascript-url-expected.txt:
- http/tests/security/xssAuditor/full-block-javascript-link-expected.txt:
- http/tests/security/xssAuditor/full-block-link-onclick-expected.txt:
- http/tests/security/xssAuditor/full-block-object-tag-expected.txt:
- http/tests/security/xssAuditor/full-block-script-tag-cross-domain-expected.txt:
- http/tests/security/xssAuditor/full-block-script-tag-expected.txt:
- http/tests/security/xssAuditor/full-block-script-tag-with-source-expected.txt:
- http/tests/security/xssAuditor/full-block-script-tag.html:
- http/tests/security/xssAuditor/xss-protection-parsing-03-expected.txt:
- http/tests/security/xssAuditor/xss-protection-parsing-04-expected.txt:
- 2:18 PM Changeset in webkit [194926] by
-
- 4 edits in trunk/Source/WebCore
Avoid downloading the wrong image for <picture> elements.
https://bugs.webkit.org/show_bug.cgi?id=153027
Reviewed by Dean Jackson.
I was unable to write a reliable test for this feature (I welcome suggestions regarding
how this could be tested).
- html/HTMLImageElement.cpp:
(WebCore::HTMLImageElement::HTMLImageElement):
(WebCore::HTMLImageElement::~HTMLImageElement):
(WebCore::HTMLImageElement::bestFitSourceFromPictureElement):
(WebCore::HTMLImageElement::insertedInto):
(WebCore::HTMLImageElement::removedFrom):
(WebCore::HTMLImageElement::pictureNode):
(WebCore::HTMLImageElement::setPictureNode):
- html/HTMLImageElement.h:
- html/parser/HTMLConstructionSite.cpp:
(WebCore::HTMLConstructionSite::createHTMLElement):
Images that are built underneath a <picture> element are now connected
to that picture element via a setPictureNode call from the parser. This
ensures that the correct <source> elements are examined before checking the image.
This connection between images and their picture owners is handled using a static
HashMap in HTMLImageElement. This connection is made both from the parser and from
DOM insertions, and the map is queried now instead of looking directly at the
image's parentNode().
Also note the change to pass the document element's computed style in for media
query evaluation. Just as with the preload scanner, the image's style can't be
used as it has not been determined yet.
- 2:06 PM Changeset in webkit [194925] by
-
- 2 edits in trunk/Source/WebKit2
WebPageProxy should reattach to the web process before navigating
https://bugs.webkit.org/show_bug.cgi?id=153026
Reviewed by Anders Carlsson.
This fixes a crash (and lots of other corruption) when force-quitting
the web process during navigation.
Some objects (like ViewGestureController) use one-time initialization
to point to a ChildProcessProxy -- and, by design, we destroy them when
the ChildProcessProxy becomes invalid (i.e., crashes or quits).
If we navigate *before* creating a new, valid ChildProcessProxy, then
we accidentally re-create these objects pointing to the old, invalid
ChildProcessProxy.
We need to wait until we have a valid ChildProcessProxy before we
initialize these objects.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::reattachToWebProcessWithItem): Navigate after
reattaching to the web process so that lazily allocated helper objects
point to the right ChildProcessProxy.
- 1:53 PM Changeset in webkit [194924] by
-
- 2 edits in trunk/Tools
Fix the Sunpider converage in slow device.
https://bugs.webkit.org/show_bug.cgi?id=152938
<rdar://problem/22511411>
Reviewed by Ryosuke Niwa.
Updated the patch for RunBenchmark to resume sunspider coverage by removing unused subresources in sub-tests.
- Scripts/webkitpy/benchmark_runner/data/patches/SunSpider.patch:
- 1:36 PM Changeset in webkit [194923] by
-
- 12 edits in trunk/Source/WebCore
Cleanup in font loading code
https://bugs.webkit.org/show_bug.cgi?id=153023
Reviewed by Zalan Bujtas.
See detailed notes below.
No new tests because there is no behavior change.
- css/CSSFontFace.cpp:
(WebCore::CSSFontFace::isLoaded): Deleted. Never called.
- css/CSSFontFace.h: Ditto.
- css/CSSFontFaceSource.cpp:
(WebCore::CSSFontFaceSource::font): No need to use a helper
isLoaded() function.
(WebCore::CSSFontFaceSource::isLoaded): Deleted. Unnecessary.
- css/CSSFontFaceSource.h:
- css/CSSFontFaceSrcValue.cpp:
(WebCore::CSSFontFaceSrcValue::cachedFont): Un-indent code.
- css/CSSFontSelector.cpp:
(WebCore::registerLocalFontFacesForFamily): constructFamilyFontFaces()
always returns an empty Vector. Therefore, the function of this function
is to perform the ancillary processing related to the case where the Faces
don't already exist. Renames the function and removes the empty vector
return.
(WebCore::CSSFontSelector::addFontFaceRule): Update for
registerLocalFontFacesForFamily().
(WebCore::FontFaceComparator::FontFaceComparator): Instead of using a static,
construct a wrapper class around the comparator.
(WebCore::FontFaceComparator::operator()): Ditto.
(WebCore::CSSFontSelector::getFontFace): Un-indent code and update to use
FontFaceComparator.
(WebCore::CSSFontSelector::fallbackFontAt): Migrate off PassRefPtr.
(WebCore::constructFamilyFontFaces): Deleted.
(WebCore::compareFontFaces): Deleted.
(WebCore::CSSFontSelector::resolvesFamilyFor): Deleted. Never called.
- css/CSSFontSelector.h:
- css/CSSSegmentedFontFace.cpp:
(WebCore::CSSSegmentedFontFace::isValid): Deleted.
(WebCore::CSSSegmentedFontFace::fontRanges): Cache negative validity results.
- css/CSSSegmentedFontFace.h:
- platform/graphics/FontCascade.h:
(WebCore::FontCascade::fontSelector): Use nullptr.
- platform/graphics/FontSelector.h:
- 1:34 PM Changeset in webkit [194922] by
-
- 2 edits in trunk/Source/JavaScriptCore
[FTL][Win64] Compile error.
https://bugs.webkit.org/show_bug.cgi?id=153031
Reviewed by Brent Fulgham.
The header file dlfcn.h does not exist on Windows.
- ftl/FTLLowerDFGToLLVM.cpp:
- 1:25 PM Changeset in webkit [194921] by
-
- 16 edits in trunk
Add a build flag for custom element
https://bugs.webkit.org/show_bug.cgi?id=153005
Reviewed by Alex Christensen.
.:
- Source/cmake/OptionsEfl.cmake:
- Source/cmake/OptionsWin.cmake:
- Source/cmake/WebKitFeatures.cmake:
Source/JavaScriptCore:
- Configurations/FeatureDefines.xcconfig:
Source/WebCore:
Added a build flag for enabling custom elements.
- Configurations/FeatureDefines.xcconfig:
Source/WebKit/mac:
- Configurations/FeatureDefines.xcconfig:
Source/WebKit2:
- Configurations/FeatureDefines.xcconfig:
Source/WTF:
- wtf/FeatureDefines.h:
Tools:
Added --custom-elements option to enable custom elements support.
- Scripts/webkitperl/FeatureList.pm:
- 12:52 PM Changeset in webkit [194920] by
-
- 6 edits in trunk/Source/WebInspectorUI
Web Inspector: fix some common misspellings in localized strings
https://bugs.webkit.org/show_bug.cgi?id=153030
<rdar://problem/24153340>
Reviewed by Joseph Pecoraro.
Replace 'occured', 'transfered' with 'occurred' and 'transferred'.
- Localizations/en.lproj/localizedStrings.js:
- UserInterface/Views/DatabaseTableContentView.js:
(WebInspector.DatabaseTableContentView.prototype._queryError):
- UserInterface/Views/NetworkGridContentView.js:
(WebInspector.NetworkGridContentView):
- UserInterface/Views/NetworkTimelineView.js:
(WebInspector.NetworkTimelineView):
- UserInterface/Views/ResourceDetailsSidebarPanel.js:
(WebInspector.ResourceDetailsSidebarPanel):
- 12:28 PM Changeset in webkit [194919] by
-
- 1 edit2 adds in trunk/LayoutTests
Null dereference loading Blink layout test fast/frames/navigation-in-pagehide.html
https://bugs.webkit.org/show_bug.cgi?id=149303
<rdar://problem/22747634>
Reviewed by Brent Fulgham.
- imported/blink/fast/frames/navigation-in-pagehide-expected.txt: Added.
- imported/blink/fast/frames/navigation-in-pagehide.html: Added.
- 12:20 PM Changeset in webkit [194918] by
-
- 6 edits2 adds in trunk
WebRTC: Update RTCPeerConnection.add/removeTrack() and add test
https://bugs.webkit.org/show_bug.cgi?id=153010
Reviewed by Eric Carlson.
Source/WebCore:
RTCPeerConnection.add/removeTrack() are not fully spec compliant yet, since that would
require support for RTCRtpTransceiver which is a new work-in-progress feature. Use
Vector, instead of map, for senders and receivers since nothing is removed from these
sets anymore.
Test: fast/mediastream/RTCPeerConnection-add-removeTrack.html
- Modules/mediastream/RTCPeerConnection.cpp:
(WebCore::RTCPeerConnection::addTrack):
(WebCore::RTCPeerConnection::removeTrack):
(WebCore::RTCPeerConnection::queuedCreateOffer): Deleted.
- Modules/mediastream/RTCPeerConnection.h:
- Modules/mediastream/RTCRtpSender.cpp:
(WebCore::RTCRtpSender::RTCRtpSender):
- Modules/mediastream/RTCRtpSender.h:
(WebCore::RTCRtpSender::create):
(WebCore::RTCRtpSender::mediaStreamIds):
LayoutTests:
Add test for RTCPeerConnection.add/removeTrack() (currently not covered by other tests).
This test also covers some of the functionality of RTCRtpSender.
- fast/mediastream/RTCPeerConnection-add-removeTrack-expected.txt: Added.
- fast/mediastream/RTCPeerConnection-add-removeTrack.html: Added.
- 12:16 PM Changeset in webkit [194917] by
-
- 2 edits2 adds in trunk/LayoutTests
Null dereference loading Blink layout test editing/selection/selectstart-event-crash.html
https://bugs.webkit.org/show_bug.cgi?id=150210
<rdar://problem/23137259>
Reviewed by Brent Fulgham.
- imported/blink/editing/selection/selectstart-event-crash-expected.txt: Added.
- imported/blink/editing/selection/selectstart-event-crash.html: Added.
- platform/ios-simulator-wk2/TestExpectations:
- 12:11 PM Changeset in webkit [194916] by
-
- 1 edit2 adds in trunk/LayoutTests
Null dereference loading Blink layout test editing/apply-inline-style-to-element-with-no-renderer-crash.html
https://bugs.webkit.org/show_bug.cgi?id=149287
<rdar://problem/22746217>
Reviewed by Brent Fulgham.
- imported/blink/editing/apply-inline-style-to-element-with-no-renderer-crash-expected.txt: Added.
- imported/blink/editing/apply-inline-style-to-element-with-no-renderer-crash.html: Added.
- 12:05 PM Changeset in webkit [194915] by
-
- 4 edits in trunk/Source/JavaScriptCore
[JSC] Remove some invalid immediate instruction forms from ARM64 Air
https://bugs.webkit.org/show_bug.cgi?id=153024
Patch by Benjamin Poulain <bpoulain@apple.com> on 2016-01-12
Reviewed by Michael Saboff.
- b3/B3BasicBlock.h:
Export the symbols for testb3.
- b3/air/AirOpcode.opcodes:
We had 2 invalid opcodes:
-Compare with immediate just does not exist.
-Test64 with immediate exists but Air does not recognize
the valid form of bit-immediates.
- b3/testb3.cpp:
(JSC::B3::genericTestCompare):
(JSC::B3::testCompareImpl):
Extend the tests to cover what was invalid.
- 11:31 AM Changeset in webkit [194914] by
-
- 2 edits in branches/safari-601.1.46-branch/Source/ThirdParty/ANGLE
Merge r194780. rdar://problem/24042915
- 11:31 AM Changeset in webkit [194913] by
-
- 4 edits in branches/safari-601.1.46-branch/Source/WebCore
Merge r194751. rdar://problem/24042915
- 11:31 AM Changeset in webkit [194912] by
-
- 5 edits in branches/safari-601.1.46-branch/Source
Merge r194750. rdar://problem/24074335
- 11:31 AM Changeset in webkit [194911] by
-
- 8 edits in branches/safari-601.1.46-branch
Merge r194667. rdar://problem/24074334
- 11:31 AM Changeset in webkit [194910] by
-
- 5 edits2 adds in branches/safari-601.1.46-branch
Merge r194666. rdar://problem/24101185
- 11:31 AM Changeset in webkit [194909] by
-
- 3 edits12 adds in branches/safari-601.1.46-branch
Merge r194038. rdar://problem/24101170
- 11:31 AM Changeset in webkit [194908] by
-
- 20 edits2 copies4 adds2 deletes in branches/safari-601.1.46-branch
Merge r192186. rdar://problem/24101174
- 11:27 AM Changeset in webkit [194907] by
-
- 2 edits in trunk/Source/WebCore/platform/gtk/po
[l10n] Updated French translation for WebKitGTK+
https://bugs.webkit.org/show_bug.cgi?id=153013
Patch by Sam Friedmann <sfriedma@redhat.com> on 2016-01-12
Rubber-stamped by Michael Catanzaro.
- fr.po:
- 11:27 AM Changeset in webkit [194906] by
-
- 3 edits in trunk/Source/WebInspectorUI
Web Inspector: Fix DataGrid row disclosure appearance and behavior
https://bugs.webkit.org/show_bug.cgi?id=152991
Reviewed by Brian Burg.
- UserInterface/Views/DataGrid.css:
(.data-grid tr.parent td.disclosure::before):
Ensure triangle is vertically aligned for any row height.
(.data-grid tr:not(.parent) td.disclosure):
Fix indent size.
- UserInterface/Views/DataGrid.js:
(WebInspector.DataGridNode.prototype.createCell):
Addediconcolumn property, encapsulate icon element creation.
(WebInspector.DataGridNode.prototype.isEventWithinDisclosureTriangle):
Fix hit test logic by computing left padding.
- 11:17 AM Changeset in webkit [194905] by
-
- 3 edits2 adds in trunk/Source/WebCore
Modern IDB: Check in empty SQLite backing store implementation.
https://bugs.webkit.org/show_bug.cgi?id=153022
Reviewed by Alex Christensen.
No new tests (No change in behavior).
Just to get the implementation files in the tree, this backing store currently does nothing
other than return errors for every operation.
- CMakeLists.txt:
- WebCore.xcodeproj/project.pbxproj:
- Modules/indexeddb/server/SQLiteIDBBackingStore.cpp: Added.
(WebCore::IDBServer::SQLiteIDBBackingStore::SQLiteIDBBackingStore):
(WebCore::IDBServer::SQLiteIDBBackingStore::~SQLiteIDBBackingStore):
(WebCore::IDBServer::SQLiteIDBBackingStore::getOrEstablishDatabaseInfo):
(WebCore::IDBServer::SQLiteIDBBackingStore::beginTransaction):
(WebCore::IDBServer::SQLiteIDBBackingStore::abortTransaction):
(WebCore::IDBServer::SQLiteIDBBackingStore::commitTransaction):
(WebCore::IDBServer::SQLiteIDBBackingStore::createObjectStore):
(WebCore::IDBServer::SQLiteIDBBackingStore::deleteObjectStore):
(WebCore::IDBServer::SQLiteIDBBackingStore::clearObjectStore):
(WebCore::IDBServer::SQLiteIDBBackingStore::createIndex):
(WebCore::IDBServer::SQLiteIDBBackingStore::deleteIndex):
(WebCore::IDBServer::SQLiteIDBBackingStore::keyExistsInObjectStore):
(WebCore::IDBServer::SQLiteIDBBackingStore::deleteRange):
(WebCore::IDBServer::SQLiteIDBBackingStore::addRecord):
(WebCore::IDBServer::SQLiteIDBBackingStore::getRecord):
(WebCore::IDBServer::SQLiteIDBBackingStore::getIndexRecord):
(WebCore::IDBServer::SQLiteIDBBackingStore::getCount):
(WebCore::IDBServer::SQLiteIDBBackingStore::generateKeyNumber):
(WebCore::IDBServer::SQLiteIDBBackingStore::revertGeneratedKeyNumber):
(WebCore::IDBServer::SQLiteIDBBackingStore::maybeUpdateKeyGeneratorNumber):
(WebCore::IDBServer::SQLiteIDBBackingStore::openCursor):
(WebCore::IDBServer::SQLiteIDBBackingStore::iterateCursor):
(WebCore::IDBServer::SQLiteIDBBackingStore::deleteBackingStore):
- Modules/indexeddb/server/SQLiteIDBBackingStore.h: Added.
- 11:17 AM Changeset in webkit [194904] by
-
- 13 edits in trunk
Modern IDB: storage/indexeddb/dont-wedge.html is flaky.
https://bugs.webkit.org/show_bug.cgi?id=152892
Reviewed by Alex Christensen.
Source/WebCore:
No new tests (Reenabled existing test).
- Modules/indexeddb/client/IDBConnectionToServer.cpp:
(WebCore::IDBClient::IDBConnectionToServer::abortOpenAndUpgradeNeeded):
- Modules/indexeddb/client/IDBConnectionToServer.h:
- Modules/indexeddb/client/IDBConnectionToServerDelegate.h:
- Modules/indexeddb/client/IDBOpenDBRequestImpl.cpp:
(WebCore::IDBClient::IDBOpenDBRequest::requestCompleted): If the database was opened
or an upgrade transaction was started, but the script execution context is already
stopped, immediately message back to the server so it doesn't wedge.
- Modules/indexeddb/server/IDBServer.cpp:
(WebCore::IDBServer::IDBServer::abortOpenAndUpgradeNeeded):
- Modules/indexeddb/server/IDBServer.h:
- Modules/indexeddb/server/UniqueIDBDatabaseTransaction.cpp:
(WebCore::IDBServer::UniqueIDBDatabaseTransaction::abortWithoutCallback):
- Modules/indexeddb/server/UniqueIDBDatabaseTransaction.h:
- Modules/indexeddb/shared/InProcessIDBServer.cpp:
(WebCore::InProcessIDBServer::abortOpenAndUpgradeNeeded):
- Modules/indexeddb/shared/InProcessIDBServer.h:
LayoutTests:
- platform/mac-wk1/TestExpectations:
- 11:16 AM Changeset in webkit [194903] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: REGRESSION (r194879) - Opening views without being previously opened causes an Uncaught Exception
https://bugs.webkit.org/show_bug.cgi?id=153006
Patch by Devin Rousso <Devin Rousso> on 2016-01-12
Reviewed by Brian Burg.
- UserInterface/Views/MultipleScopeBarItem.js:
(WebInspector.MultipleScopeBarItem.prototype.displaySelectedItem):
If there is no selected item, default to the first item in the list.
- 10:48 AM Changeset in webkit [194902] by
-
- 15 edits1 delete in trunk/Source/WebKit2
Ask for UI Process approval of ProtectionSpace when authenticating downloads with NetworkSession
https://bugs.webkit.org/show_bug.cgi?id=152999
Reviewed by Brady Eidson.
- DerivedSources.make:
I mistakenly added PendingDownload.messages.in in r194810, but this will not be needed because
the PendingDownload is not a MessageReceiver. Rather, the NetworkProcess receives the messages
and forwards their contents to the PendingDownload through its DownloadManager.
- NetworkProcess/Downloads/DownloadManager.cpp:
(WebKit::DownloadManager::dataTaskBecameDownloadTask):
(WebKit::DownloadManager::continueCanAuthenticateAgainstProtectionSpace):
(WebKit::DownloadManager::convertHandleToDownload):
- NetworkProcess/Downloads/DownloadManager.h:
- NetworkProcess/Downloads/PendingDownload.cpp:
(WebKit::PendingDownload::continueWillSendRequest):
(WebKit::PendingDownload::canAuthenticateAgainstProtectionSpaceAsync):
Instead of taking a shortcut I added in r194810, send a message to the UI process and wait for its
asynchronous reply to determine if we can authenticate against this protection space.
(WebKit::PendingDownload::continueCanAuthenticateAgainstProtectionSpace):
(WebKit::PendingDownload::didConvertToDownload):
- NetworkProcess/Downloads/PendingDownload.h:
- NetworkProcess/Downloads/PendingDownload.messages.in: Removed.
- NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::cancelDownload):
(WebKit::NetworkProcess::continueCanAuthenticateAgainstProtectionSpace):
(WebKit::NetworkProcess::setCacheModel):
- NetworkProcess/NetworkProcess.h:
- NetworkProcess/NetworkProcess.messages.in:
- Shared/Authentication/AuthenticationManager.h:
- UIProcess/API/APIDownloadClient.h:
(API::DownloadClient::didFail):
(API::DownloadClient::didCancel):
(API::DownloadClient::processDidCrash):
(API::DownloadClient::canAuthenticateAgainstProtectionSpace):
- UIProcess/Downloads/DownloadProxy.cpp:
(WebKit::DownloadProxy::didReceiveAuthenticationChallenge):
(WebKit::DownloadProxy::canAuthenticateAgainstProtectionSpace):
(WebKit::DownloadProxy::didReceiveResponse):
- UIProcess/Downloads/DownloadProxy.h:
- UIProcess/Downloads/DownloadProxy.messages.in:
- WebKit2.xcodeproj/project.pbxproj:
- 10:44 AM Changeset in webkit [194901] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: creating a gradient in the Visual sidebar causes a crash
https://bugs.webkit.org/show_bug.cgi?id=153003
Patch by Devin Rousso <Devin Rousso> on 2016-01-12
Reviewed by Brian Burg.
- UserInterface/Views/VisualStyleBackgroundPicker.js:
(WebInspector.VisualStyleBackgroundPicker.prototype._gradientSwatchClicked):
If a gradient does not already exist when the swatch is clicked, create a basic
gradient using the current type and two "transparent" color stops (a minimum of
two color stops are needed for a valid gradient).
- 10:13 AM Changeset in webkit [194900] by
-
- 21 edits in trunk/Source
Unreviewed, rolling out r194826.
https://bugs.webkit.org/show_bug.cgi?id=153020
Appears to have regressed PLT (Requested by kling on #webkit).
Reverted changeset:
"Use NeverDestroyed instead of DEPRECATED_DEFINE_STATIC_LOCAL
cont'd"
https://bugs.webkit.org/show_bug.cgi?id=152902
http://trac.webkit.org/changeset/194826
- 9:48 AM Changeset in webkit [194899] by
-
- 2 edits in trunk/Tools
[JSC] Add a help message when run-jsc-stress-tests fails
https://bugs.webkit.org/show_bug.cgi?id=153014
Patch by Benjamin Poulain <bpoulain@apple.com> on 2016-01-12
Reviewed by Csaba Osztrogonác.
- Scripts/run-jsc-stress-tests:
- 9:31 AM Changeset in webkit [194898] by
-
- 4 edits3 adds in trunk
Don't reuse memory cache entries with different charset
https://bugs.webkit.org/show_bug.cgi?id=110031
Source/WebCore:
rdar://problem/13666418
Reviewed by Andreas Kling.
Test: fast/loader/cache-encoding.html
- loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::requestResource):
(WebCore::logResourceRevalidationDecision):
(WebCore::CachedResourceLoader::determineRevalidationPolicy):
Pass full CachedResourceRequest to the function.
If charset differs don't reuse the cache entry.
- loader/cache/CachedResourceLoader.h:
LayoutTests:
Reviewed by Andreas Kling.
- fast/loader/cache-encoding-expected.txt: Added.
- fast/loader/cache-encoding.html: Added.
- fast/loader/resources/success.js: Added.
- 9:28 AM Changeset in webkit [194897] by
-
- 2 edits in trunk/LayoutTests
Marking inspector/model/scope-chain-node.html as flaky on Mac debug
https://bugs.webkit.org/show_bug.cgi?id=153018
Unreviewed test gardening.
- platform/mac/TestExpectations:
- 9:23 AM Changeset in webkit [194896] by
-
- 17 edits in trunk/Source/WebCore
Use a pointer instead of PassRefPtr in AbstractView argument of UIEvent class
https://bugs.webkit.org/show_bug.cgi?id=152829
Reviewed by Darin Adler.
As a step to reduce uses of PassRefPtr, UIEvent class doesn't need to use PassRefPtr for AbstractView argument.
Nobody hands us ownership when making one of these objects.
- dom/FocusEvent.cpp:
(WebCore::FocusEvent::FocusEvent):
- dom/FocusEvent.h:
- dom/KeyboardEvent.cpp:
(WebCore::KeyboardEvent::KeyboardEvent):
- dom/MouseEvent.cpp:
(WebCore::MouseEvent::create):
(WebCore::MouseEvent::MouseEvent):
(WebCore::MouseEvent::initMouseEvent):
(WebCore::SimulatedMouseEvent::create):
(WebCore::SimulatedMouseEvent::SimulatedMouseEvent):
- dom/MouseEvent.h:
- dom/MouseRelatedEvent.cpp:
(WebCore::MouseRelatedEvent::MouseRelatedEvent):
- dom/MouseRelatedEvent.h:
- dom/TextEvent.cpp:
(WebCore::TextEvent::create):
(WebCore::TextEvent::createForPlainTextPaste):
(WebCore::TextEvent::createForFragmentPaste):
(WebCore::TextEvent::createForDrop):
(WebCore::TextEvent::createForDictation):
(WebCore::TextEvent::TextEvent):
(WebCore::TextEvent::initTextEvent):
- dom/TextEvent.h:
- dom/TouchEvent.cpp:
(WebCore::TouchEvent::TouchEvent):
(WebCore::TouchEvent::initTouchEvent):
- dom/TouchEvent.h:
- dom/UIEvent.cpp:
(WebCore::UIEvent::UIEvent):
(WebCore::UIEvent::initUIEvent):
- dom/UIEvent.h:
(WebCore::UIEvent::create):
(WebCore::UIEvent::view):
- dom/UIEventWithKeyState.h:
(WebCore::UIEventWithKeyState::UIEventWithKeyState):
- 9:23 AM Changeset in webkit [194895] by
-
- 4 edits2 moves in trunk/Source/WebKit2
Move ChildProcessProxy from Shared to UIProcess
https://bugs.webkit.org/show_bug.cgi?id=125570
Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2016-01-12
Reviewed by Darin Adler.
ChildProcessProxy is only used by the UI process.
- CMakeLists.txt:
- PlatformGTK.cmake:
- UIProcess/ChildProcessProxy.cpp: Renamed from Source/WebKit2/Shared/ChildProcessProxy.cpp.
(WebKit::ChildProcessProxy::ChildProcessProxy):
(WebKit::ChildProcessProxy::~ChildProcessProxy):
(WebKit::ChildProcessProxy::fromConnection):
(WebKit::ChildProcessProxy::getLaunchOptions):
(WebKit::ChildProcessProxy::connect):
(WebKit::ChildProcessProxy::terminate):
(WebKit::ChildProcessProxy::state):
(WebKit::ChildProcessProxy::sendMessage):
(WebKit::ChildProcessProxy::addMessageReceiver):
(WebKit::ChildProcessProxy::removeMessageReceiver):
(WebKit::ChildProcessProxy::dispatchMessage):
(WebKit::ChildProcessProxy::dispatchSyncMessage):
(WebKit::ChildProcessProxy::didFinishLaunching):
(WebKit::ChildProcessProxy::shutDownProcess):
(WebKit::ChildProcessProxy::connectionWillOpen):
- UIProcess/ChildProcessProxy.h: Renamed from Source/WebKit2/Shared/ChildProcessProxy.h.
(WebKit::ChildProcessProxy::connection):
(WebKit::ChildProcessProxy::processIdentifier):
(WebKit::ChildProcessProxy::canSendMessage):
(WebKit::ChildProcessProxy::send):
(WebKit::ChildProcessProxy::sendSync):
- WebKit2.xcodeproj/project.pbxproj:
- 9:17 AM Changeset in webkit [194894] by
-
- 3 edits in trunk/Source/JavaScriptCore
[JSC] JSC does not build with FTL_USES_B3 on ARM64
https://bugs.webkit.org/show_bug.cgi?id=153011
Patch by Benjamin Poulain <bpoulain@apple.com> on 2016-01-12
Reviewed by Saam Barati.
Apparently the static const member can only be used for constexpr.
C++ is weird.
- jit/GPRInfo.cpp:
- jit/GPRInfo.h:
- 9:11 AM Changeset in webkit [194893] by
-
- 2 edits in trunk/LayoutTests
Marking inspector/script-profiler/event-type-Other.html as flaky on Mac
https://bugs.webkit.org/show_bug.cgi?id=153016
Unreviewed test gardening.
- platform/mac/TestExpectations:
- 8:47 AM Changeset in webkit [194892] by
-
- 3 edits in trunk/Source/WebCore
Fix unused-private-field warnings in DisplayListItems.h
https://bugs.webkit.org/show_bug.cgi?id=153012
Reviewed by Michael Catanzaro.
- platform/graphics/displaylists/DisplayListItems.cpp:
(WebCore::DisplayList::DrawNativeImage::DrawNativeImage):
- platform/graphics/displaylists/DisplayListItems.h:
- 6:32 AM Changeset in webkit [194891] by
-
- 69 edits in trunk/LayoutTests
Unreviewed GTK+ gardening. Rebaseline test results after r194847.
Before r194847 we were always taking the separator of combo boxes
into account when calculating the size of menu list buttons, even
when we didn't render the separator. In r194847 we removed all the
code to deal with separators in combo boxes. Also, since r194847
we are correctly adding the padding between the icon and the text
in search fileds.
- platform/gtk/css3/selectors3/html/css3-modsel-161-expected.txt:
- platform/gtk/css3/selectors3/xhtml/css3-modsel-161-expected.txt:
- platform/gtk/css3/selectors3/xml/css3-modsel-161-expected.txt:
- platform/gtk/editing/pasteboard/4641033-expected.txt:
- platform/gtk/editing/pasteboard/4944770-1-expected.txt:
- platform/gtk/editing/pasteboard/4944770-2-expected.txt:
- platform/gtk/editing/selection/caret-before-select-expected.txt:
- platform/gtk/editing/selection/replaced-boundaries-3-expected.txt:
- platform/gtk/editing/selection/select-box-expected.txt:
- platform/gtk/editing/selection/select-element-paragraph-boundary-expected.txt:
- platform/gtk/fast/css/focus-ring-exists-for-search-field-expected.txt:
- platform/gtk/fast/css/input-search-padding-expected.txt:
- platform/gtk/fast/css/text-input-with-webkit-border-radius-expected.txt:
- platform/gtk/fast/css/text-overflow-input-expected.txt:
- platform/gtk/fast/css/text-transform-select-expected.txt:
- platform/gtk/fast/forms/001-expected.txt:
- platform/gtk/fast/forms/003-expected.txt:
- platform/gtk/fast/forms/004-expected.txt:
- platform/gtk/fast/forms/basic-inputs-expected.txt:
- platform/gtk/fast/forms/basic-selects-expected.txt:
- platform/gtk/fast/forms/box-shadow-override-expected.txt:
- platform/gtk/fast/forms/control-restrict-line-height-expected.txt:
- platform/gtk/fast/forms/disabled-select-change-index-expected.txt:
- platform/gtk/fast/forms/form-element-geometry-expected.txt:
- platform/gtk/fast/forms/input-appearance-height-expected.txt:
- platform/gtk/fast/forms/input-value-expected.txt:
- platform/gtk/fast/forms/menulist-deselect-update-expected.txt:
- platform/gtk/fast/forms/menulist-narrow-width-expected.txt:
- platform/gtk/fast/forms/menulist-no-overflow-expected.txt:
- platform/gtk/fast/forms/menulist-restrict-line-height-expected.txt:
- platform/gtk/fast/forms/menulist-separator-painting-expected.txt:
- platform/gtk/fast/forms/menulist-style-color-expected.txt:
- platform/gtk/fast/forms/menulist-width-change-expected.txt:
- platform/gtk/fast/forms/option-script-expected.txt:
- platform/gtk/fast/forms/option-strip-whitespace-expected.txt:
- platform/gtk/fast/forms/placeholder-position-expected.txt:
- platform/gtk/fast/forms/placeholder-pseudo-style-expected.txt:
- platform/gtk/fast/forms/search-cancel-button-style-sharing-expected.txt:
- platform/gtk/fast/forms/search-display-none-cancel-button-expected.txt:
- platform/gtk/fast/forms/search-rtl-expected.txt:
- platform/gtk/fast/forms/search-styled-expected.txt:
- platform/gtk/fast/forms/search/search-size-with-decorations-expected.txt:
- platform/gtk/fast/forms/searchfield-heights-expected.txt:
- platform/gtk/fast/forms/select-background-none-expected.txt:
- platform/gtk/fast/forms/select-baseline-expected.txt:
- platform/gtk/fast/forms/select-change-listbox-to-popup-expected.txt:
- platform/gtk/fast/forms/select-dirty-parent-pref-widths-expected.txt:
- platform/gtk/fast/forms/select-disabled-appearance-expected.txt:
- platform/gtk/fast/forms/select-element-focus-ring-expected.txt:
- platform/gtk/fast/forms/select-initial-position-expected.txt:
- platform/gtk/fast/forms/select-selected-expected.txt:
- platform/gtk/fast/forms/select-size-expected.txt:
- platform/gtk/fast/forms/select-style-expected.txt:
- platform/gtk/fast/forms/select-visual-hebrew-expected.txt:
- platform/gtk/fast/forms/select/optgroup-rendering-expected.txt:
- platform/gtk/fast/forms/selectlist-minsize-expected.txt:
- platform/gtk/fast/forms/stuff-on-my-optgroup-expected.txt:
- platform/gtk/fast/forms/validation-message-appearance-expected.txt:
- platform/gtk/fast/html/keygen-expected.txt:
- platform/gtk/fast/invalid/014-expected.txt:
- platform/gtk/fast/parser/document-write-option-expected.txt:
- platform/gtk/fast/repaint/search-field-cancel-expected.txt:
- platform/gtk/fast/replaced/replaced-breaking-expected.txt:
- platform/gtk/fast/replaced/replaced-breaking-mixture-expected.txt:
- platform/gtk/fast/replaced/three-selects-break-expected.txt:
- platform/gtk/fast/replaced/width100percent-menulist-expected.txt:
- platform/gtk/fast/replaced/width100percent-searchfield-expected.txt:
- platform/gtk/http/tests/navigation/javascriptlink-frames-expected.txt:
- 3:41 AM Changeset in webkit [194890] by
-
- 2 edits in trunk/Source/WebKit2
[GTK] UI process crashes if webkit_web_view_get_tls_info is called before internal load-committed event
https://bugs.webkit.org/show_bug.cgi?id=142375
Reviewed by Michael Catanzaro.
Remove all the hacks to emit delayed load events now that the
page cache resource load delegates are consistent with all other
resource loads.
- UIProcess/API/gtk/WebKitWebView.cpp:
(webkitWebViewLoadChanged):
(webkitWebViewResourceLoadStarted):
(webkit_web_view_get_tls_info): Add a g_return_val_if_fail to
prevent this function from being misused.
(webkitWebViewDisconnectMainResourceResponseChangedSignalHandler): Deleted.
(webkitWebViewDispose): Deleted.
(webkitWebViewEmitLoadChanged): Deleted.
(webkitWebViewEmitDelayedLoadEvents): Deleted.
(mainResourceResponseChangedCallback): Deleted.
(waitForMainResourceResponseIfWaitingForResource): Deleted.
- 12:29 AM Changeset in webkit [194889] by
-
- 3 edits in trunk/Source/WebCore
Unreviewed. Fix isRecording condition logic in GraphicsContext::roundToDevicePixels after r194816.
This looks like a typo introduced in r194816, we want to return early logging
a message when isRecording() returns true.
- platform/graphics/cairo/GraphicsContextCairo.cpp:
(WebCore::GraphicsContext::roundToDevicePixels):
- platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::GraphicsContext::roundToDevicePixels):
- 12:23 AM Changeset in webkit [194888] by
-
- 4 edits3 adds in trunk
Inconsistencies in main resource load delegates when loading from history
https://bugs.webkit.org/show_bug.cgi?id=150927
Reviewed by Michael Catanzaro.
Source/WebCore:
When restoring a page from the page cache, even though there
isn't an actual load of resources, we are still emitting the load
delegates to let the API layer know there are contents being
loaded in the web view. This makes the page cache restoring
transparent for the API layer. However, when restoring a page from
the cache, all the delegates are emitted after the load is
committed. This is not consistent with real loads, where we first
load the main resource and once we get a response we commit the
load. This inconsistency is problematic if the API layer expects
to always have a main resource with a response when the load is
committed. This is the case of the GTK+ port, for example. So,
this patch ensures that when a page is restored from the page
cache, the main resource load delegates that are emitted until a
response is received in normal loads, are emitted before the load
is committed.
Test: http/tests/loading/main-resource-delegates-on-back-navigation.html
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::commitProvisionalLoad): When loading from
the page cache, send delegate messages up to didReceiveResponse
for the main resource before the load is committed, and the
remaining messages afterwards.
LayoutTests:
Add test to check that main resource load delegates are emitted in
the same order before the load is committed when loading a page
from history with the page cache enabled and disabled.
- http/tests/loading/main-resource-delegates-on-back-navigation-expected.txt: Added.
- http/tests/loading/main-resource-delegates-on-back-navigation.html: Added.
- http/tests/loading/resources/page-go-back-onload.html: Added.
- loader/go-back-cached-main-resource-expected.txt:
Jan 11, 2016:
- 11:39 PM Changeset in webkit [194887] by
-
- 5 edits in trunk
Web Inspector: console.count() shouldn't show a colon in front of a number
https://bugs.webkit.org/show_bug.cgi?id=152038
Patch by Johan K. Jensen <jj@johanjensen.dk> on 2016-01-11
Reviewed by Brian Burg.
Source/JavaScriptCore:
- inspector/agents/InspectorConsoleAgent.cpp:
(Inspector::InspectorConsoleAgent::count):
Do not include title and colon if the title is empty.
LayoutTests:
- inspector/console/console-api-expected.txt:
- inspector/console/console-api.html:
Add testcases for console.count
- 11:16 PM Changeset in webkit [194886] by
-
- 3 edits in trunk/Source/WebKit2
REGRESSION(r190717): [GTK] Popup menus stop working after being dismissed without selecting an item
https://bugs.webkit.org/show_bug.cgi?id=152977
Reviewed by Michael Catanzaro.
This happens since r190717 when you open a popup menu and without
selecting any option it's dismissed (press ESC or click somewhere
else). This is because I removed the code to track when the menu
is unmapped, thinking that it was no longer necessary. But we need
to send the DidChangeSelectedIndexForActivePopupMenu to the
WebProcess with -1 as index to keep the web process in sync.
- UIProcess/gtk/WebPopupMenuProxyGtk.cpp:
(WebKit::WebPopupMenuProxyGtk::WebPopupMenuProxyGtk):
(WebKit::WebPopupMenuProxyGtk::showPopupMenu):
(WebKit::WebPopupMenuProxyGtk::cancelTracking):
(WebKit::WebPopupMenuProxyGtk::menuItemActivated):
(WebKit::WebPopupMenuProxyGtk::dismissMenuTimerFired):
(WebKit::WebPopupMenuProxyGtk::menuUnmappedCallback):
- UIProcess/gtk/WebPopupMenuProxyGtk.h:
- 8:40 PM Changeset in webkit [194885] by
-
- 2 edits in trunk/Tools
run-jsc-stress-tests should try to figure out a JSC path
https://bugs.webkit.org/show_bug.cgi?id=152971
Reviewed by Yusuke Suzuki.
This patch now allows run-jsc-stress-tests to be run
without a "--jsc <jsc-path>" argument. It tries
to take its best guess at a <jsc-path> automagically.
This makes it much easier to just run run-jsc-stress-tests
with a directory or a yaml file as an argument.
You now just do this:
run-jsc-stress-tests <path-to-yaml>
or
run-jsc-stress-tests <path-to-directory-of-js-files>
I wrote this patch because I'd often find myself hacking the
run-javascriptcore-tests file just to run a particular subset of tests.
Because I always forget the arguments to run-jsc-stress-tests (which means
I always forgot to provide a --jsc argument), I always found it easier to
just hack on that file instead of calling run-jsc-stress-tests directly.
No longer is this true!
- Scripts/run-jsc-stress-tests:
- 8:21 PM Changeset in webkit [194884] by
-
- 2 edits in trunk/Source/JavaScriptCore
Reverted r194317.
Reviewed by Joseph Pecoraro.
r194317 did not contain a change log entry, did not explain the motivation, did not name a
reviewer, and does not seem necessary.
- JavaScriptCore.xcodeproj/project.pbxproj:
- 7:05 PM Changeset in webkit [194883] by
-
- 5 edits in tags/Safari-601.5.8.3/Source
Versioning.
- 7:03 PM Changeset in webkit [194882] by
-
- 1 copy in tags/Safari-601.5.8.3
New tag.
- 7:02 PM Changeset in webkit [194881] by
-
- 5 edits3 adds in trunk
keywords ("super", "delete", etc) should be valid method names
https://bugs.webkit.org/show_bug.cgi?id=144281
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-01-11
Reviewed by Ryosuke Niwa.
Source/JavaScriptCore:
- parser/Parser.cpp:
(JSC::Parser<LexerType>::parseClass):
- When parsing "static(" treat it as a method named "static" and not a static method.
- When parsing a keyword treat it like a string method name (get and set are not keywords)
- When parsing a getter / setter method name identifier, allow lookahead to be a keyword
(JSC::Parser<LexerType>::parseGetterSetter):
- When parsing the getter / setter's name, allow it to be a keyword.
LayoutTests:
- js/class-syntax-super-expected.txt:
- js/script-tests/class-syntax-super.js:
Update the test for the correct expected result.
- js/keyword-method-names-expected.txt: Added.
- js/keyword-method-names.html: Added.
- js/script-tests/keyword-method-names.js: Added.
Add tests to cover parsing allows keywords in method name syntax.
- 6:12 PM Changeset in webkit [194880] by
-
- 18 edits1 add in trunk
[Cocoa] Add SPI to opt out a URL scheme from the memory cache
https://bugs.webkit.org/show_bug.cgi?id=152950
rdar://problem/24066652
Reviewed by Tim Horton.
Source/WebCore:
Added a list of schemes to SchemeRegistry whose resources should always be revalidated. Taught CachedResource to
return a freshness lifetime of 0 for these resources, unless the scheme is one that should be cached indefinitely.
New API test: WebKit2.AlwaysRevalidatedURLSchemes
- loader/cache/CachedResource.cpp:
(WebCore::shouldCacheSchemeIndefinitely): Moved from SchemeRegistry::shouldCacheResponsesFromURLSchemeIndefinitely().
(WebCore::CachedResource::freshnessLifetime): For a scheme that should not be cached indefinitely, return 0 if
that scheme should always be revalidated according to SchemeRegistry.
- platform/SchemeRegistry.cpp:
(WebCore::alwaysRevalidatedSchemes):
(WebCore::SchemeRegistry::registerURLSchemeAsAlwaysRevalidated):
(WebCore::SchemeRegistry::shouldAlwaysRevalidateURLScheme):
(WebCore::SchemeRegistry::shouldCacheResponsesFromURLSchemeIndefinitely): Moved to WebCore::shouldCacheSchemeIndefinitely().
There was no reason for this to be in SchemeRegistry.
- platform/SchemeRegistry.h:
Source/WebKit2:
Added a alwaysRevalidatedURLSchemes property to _WKProcessPoolConfiguration. Taught WebProcess to add these
schemes to SchemeRegistry when initializing a new web process.
- Shared/API/Cocoa/WKFoundation.h: Added a newline to force re-postprocessing.
- Shared/WebProcessCreationParameters.cpp:
(WebKit::WebProcessCreationParameters::encode):
(WebKit::WebProcessCreationParameters::decode):
- Shared/WebProcessCreationParameters.h:
- UIProcess/API/APIProcessPoolConfiguration.cpp:
(API::ProcessPoolConfiguration::copy):
- UIProcess/API/APIProcessPoolConfiguration.h:
- UIProcess/API/Cocoa/_WKProcessPoolConfiguration.h:
- UIProcess/API/Cocoa/_WKProcessPoolConfiguration.mm:
(-[_WKProcessPoolConfiguration alwaysRevalidatedURLSchemes]):
(-[_WKProcessPoolConfiguration setAlwaysRevalidatedURLSchemes:]):
- UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::createNewWebProcess):
- UIProcess/WebProcessPool.h:
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::initializeWebProcess):
(WebKit::WebProcess::registerURLSchemeAsAlwaysRevalidated):
- WebProcess/WebProcess.h:
Tools:
Added an API test.
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/WebKit2Cocoa/AlwaysRevalidatedURLSchemes.mm: Added.
(+[AlwaysRevalidatedURLSchemeProtocol canInitWithRequest:]):
(+[AlwaysRevalidatedURLSchemeProtocol canonicalRequestForRequest:]):
(+[AlwaysRevalidatedURLSchemeProtocol requestIsCacheEquivalent:toRequest:]):
(-[AlwaysRevalidatedURLSchemeProtocol startLoading]):
(-[AlwaysRevalidatedURLSchemeProtocol stopLoading]):
(-[AlwaysRevalidatedURLSchemesDelegate webView:didFinishNavigation:]):
(TEST):
- 5:40 PM Changeset in webkit [194879] by
-
- 12 edits in trunk/Source/WebInspectorUI
Web Inspector: Storage tab navigation bar should fit on a single line
https://bugs.webkit.org/show_bug.cgi?id=152473
Patch by Devin Rousso <Devin Rousso> on 2016-01-11
Reviewed by Timothy Hatcher.
The wrapping of the navigation bar on the Storage tab was caused by the
fact that Sidebar.js used a minimum width of 200px, regardless of the
content within the sidebar (unless it had a NavigationBar). Logic has
been added that causes the sidebar to use the selected panel's own
minimum width calculation if it is greater than 200px.
- UserInterface/Views/DebuggerSidebarPanel.js:
(WebInspector.DebuggerSidebarPanel.prototype.get minimumWidth):
- UserInterface/Views/MultipleScopeBarItem.js:
(WebInspector.MultipleScopeBarItem.prototype.set selectedScopeBarItem):
(WebInspector.MultipleScopeBarItem.prototype.displaySelectedItem):
Sets the displayed text to the currently selected item.
(WebInspector.MultipleScopeBarItem.prototype.displayWidestItem):
Sets the displayed text to the widest (pixel wise) item in the select element.
- UserInterface/Views/NavigationBar.js:
(WebInspector.NavigationBar.prototype._calculateMinimumWidth):
Now uses NavigationItem.prototype.get minimumWidth.
- UserInterface/Views/NavitationItem.js:
(WebInspector.NavitationItem.prototype.get minimumWidth):
Returns the element's realOffsetWidth.
- UserInterface/Views/NetworkSidebarPanel.js:
(WebInspector.NetworkSidebarPanel.prototype.get minimumWidth):
- UserInterface/Views/ResourceSidebarPanel.js:
(WebInspector.ResourceSidebarPanel.prototype.get minimumWidth):
- UserInterface/Views/ScopeBar.js:
(WebInspector.ScopeBar):
(WebInspector.ScopeBar.prototype.get minimumWidth):
- UserInterface/Views/Sidebar.js:
(WebInspector.Sidebar.prototype.set selectedSidebarPanel):
(WebInspector.Sidebar.prototype.get minimumWidth):
(WebInspector.Sidebar.prototype.set width):
(WebInspector.Sidebar.prototype.set collapsed):
(WebInspector.Sidebar.prototype._recalculateWidth):
Whenever the sidebar changes (e.g. tab change, sidebar becomes
visible/hidden, etc.), a width recalculation is necessary to ensure
that the navigation bar never wraps.
- UserInterface/Views/SidebarPanel.js:
(WebInspector.SidebarPanel.prototype.get minimumWidth):
- UserInterface/Views/StorageSidebarPanel.js:
(WebInspector.StorageSidebarPanel.prototype.get minimumWidth):
- UserInterface/Views/TimelineSidebarPanel.js:
(WebInspector.TimelineSidebarPanel.prototype.get minimumWidth):
- 5:34 PM Changeset in webkit [194878] by
-
- 11 edits in trunk/Source/WebInspectorUI
Web Inspector: Make Timelines view also remember sort order
https://bugs.webkit.org/show_bug.cgi?id=152811
Patch by Devin Rousso <Devin Rousso> on 2016-01-11
Reviewed by Timothy Hatcher.
Changeset r194574 introduced the ability for WebInspector.Setting objects to
be passed to DataGrid instances to save the sort column for that grid. These
changes also add the ability for the sort order to be save as well.
- UserInterface/Views/ApplicationCacheFrameContentView.js:
(WebInspector.ApplicationCacheFrameContentView.prototype._createDataGrid):
- UserInterface/Views/CookieStorageContentView.js:
(WebInspector.CookieStorageContentView.prototype._rebuildTable):
- UserInterface/Views/DOMStorageContentView.js:
(WebInspector.DOMStorageContentView):
- UserInterface/Views/DataGrid.js:
(WebInspector.DataGrid):
(WebInspector.DataGrid.prototype.set sortOrder):
If a WebInspector.Setting object has been given, save the new sort order.
(WebInspector.DataGrid.prototype.set sortOrderSetting):
Saves the given WebInspector.Setting object for modification whenever the user
changes the sort order.
- UserInterface/Views/LayerTreeDetailsSidebarPanel.js:
(WebInspector.LayerTreeDetailsSidebarPanel.prototype._buildDataGridSection):
- UserInterface/Views/LayoutTimelineView.js:
(WebInspector.LayoutTimelineView):
- UserInterface/Views/NetworkGridContentView.js:
(WebInspector.NetworkGridContentView):
- UserInterface/Views/NetworkTimelineView.js:
(WebInspector.NetworkTimelineView):
- UserInterface/Views/RenderingFrameTimelineView.js:
(WebInspector.RenderingFrameTimelineView):
- UserInterface/Views/ScriptTimelineView.js:
(WebInspector.ScriptTimelineView):
- 5:34 PM Changeset in webkit [194877] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Copying JS object output from console shouldn't include trailing '= $n'
https://bugs.webkit.org/show_bug.cgi?id=119347
Patch by Johan K. Jensen <jj@johanjensen.dk> on 2016-01-11
Reviewed by Joseph Pecoraro.
- UserInterface/Views/ConsoleMessageView.js:
(WebInspector.ConsoleMessageView.prototype.toClipboardString):
- 5:32 PM Changeset in webkit [194876] by
-
- 5 edits in trunk/Source/WebInspectorUI
Web Inspector: Add basic Content section to Visual Sidebar
https://bugs.webkit.org/show_bug.cgi?id=152972
Patch by Devin Rousso <Devin Rousso> on 2016-01-11
Reviewed by Timothy Hatcher.
Since the "content" property has so many different types of values, a
simple text input editor should be added to provide some support for
the CSS property until a better, more specialized editor is created.
- Localizations/en.lproj/localizedStrings.js:
- UserInterface/Views/VisualStyleCommaSeparatedKeywordEditor.css:
(.visual-style-property-container.comma-separated-keyword-editor):
Moved margin-left to new rule in VisualStylePropertyEditor.css.
- UserInterface/Views/VisualStyleDetailsPanel.js:
(WebInspector.VisualStyleDetailsPanel):
(WebInspector.VisualStyleDetailsPanel.prototype._populateContentSection):
Adds the basic editor under the Text section in a new subsection
called Content.
- UserInterface/Views/VisualStylePropertyEditor.css:
(.visual-style-property-container > *:first-child:matches(.visual-style-property-value-container)):
Adds a left margin to property editors without a title.
- 5:31 PM Changeset in webkit [194875] by
-
- 3 edits in trunk/Source/WebInspectorUI
Web Inspector: Visual sidebar minor bug fixes
https://bugs.webkit.org/show_bug.cgi?id=152967
Patch by Devin Rousso <Devin Rousso> on 2016-01-11
Reviewed by Timothy Hatcher.
- UserInterface/Views/VisualStyleDetailsPanel.js:
(WebInspector.VisualStyleDetailsPanel.prototype.refresh):
Only update sections when it is not a significant change, as they are
updated when the selector changes.
(WebInspector.VisualStyleDetailsPanel.prototype._updateProperties):
Only reset links if the refresh is a significant change (node or selected
style changes).
- UserInterface/Views/VisualStyleNumberInputBox.js:
(WebInspector.VisualStyleNumberInputBox):
(WebInspector.VisualStyleNumberInputBox.prototype.get value):
Removed unreachable return.
(WebInspector.VisualStyleNumberInputBox.prototype.set value):
(WebInspector.VisualStyleNumberInputBox.prototype._valueNumberInputKeyDown.adjustValue):
_updatedValues.propertyMissing was changed to _propertyMissing in a
prior patch.
- 4:33 PM Changeset in webkit [194874] by
-
- 4 edits in trunk/LayoutTests
Modern IDB: storage/indexeddb/intversion-long-queue.html fails.
https://bugs.webkit.org/show_bug.cgi?id=152995
Reviewed by Alex Christensen.
- platform/mac-wk1/TestExpectations:
- storage/indexeddb/intversion-long-queue-expected.txt:
- storage/indexeddb/resources/intversion-long-queue.js:
- 4:11 PM Changeset in webkit [194873] by
-
- 5 edits in trunk/Source/JavaScriptCore
[JSC] Add Div/Mod and fix Mul for B3 ARM64
https://bugs.webkit.org/show_bug.cgi?id=152978
Patch by Benjamin Poulain <bpoulain@apple.com> on 2016-01-11
Reviewed by Filip Pizlo.
Add the 3 operands forms of Mul.
Remove the form taking immediate on ARM64, there are no such instruction.
Add Div with sdiv.
Unfortunately, I discovered ChillMod's division by zero
makes it non-trivial on ARM64. I just made it into a macro like on x86.
- assembler/MacroAssemblerARM64.h:
(JSC::MacroAssemblerARM64::mul32):
(JSC::MacroAssemblerARM64::mul64):
(JSC::MacroAssemblerARM64::div32):
(JSC::MacroAssemblerARM64::div64):
- b3/B3LowerMacros.cpp:
- b3/B3LowerToAir.cpp:
(JSC::B3::Air::LowerToAir::lower):
- b3/air/AirOpcode.opcodes:
- 3:44 PM Changeset in webkit [194872] by
-
- 5 edits in trunk
Modern IDB: storage/indexeddb/index-multientry.html fails under GuardMalloc/ASAN.
https://bugs.webkit.org/show_bug.cgi?id=152990
Reviewed by Alex Christensen.
Source/WebCore:
No new tests (Covered by re-enabling existing test).
- Modules/indexeddb/client/IDBRequestImpl.cpp:
(WebCore::IDBClient::IDBRequest::dispatchEvent): Use String::utf8() instead of AtomicString::characters8() for
the format string, as the latter fails under ASAN.
- Modules/indexeddb/server/IndexValueStore.cpp:
(WebCore::IDBServer::IndexValueStore::removeEntriesWithValueKey): We can't save off pointers to IDBKeyDatas
used as keys in the map, because the moment we start mutating the map the keys can be rehashed, invalidating
our pointers. Save off the IDBKeyDatas by value instead.
LayoutTests:
- platform/mac-wk1/TestExpectations:
- 3:34 PM Changeset in webkit [194871] by
-
- 20 edits4 adds in trunk
Web Inspector: Migrate Page Timeline recording to ScriptProfiler
https://bugs.webkit.org/show_bug.cgi?id=152727
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-01-11
Reviewed by Brian Burg.
Source/WebCore:
Test: inspector/script-profiler/event-type-Other.html
This now shares the JavaScript profiling code between JSContext and Page
inspection. It also moves forward splitting the Page's Timeline domain
into smaller components that can be turned on/off individually.
- bindings/js/JSCallbackData.cpp:
(WebCore::JSCallbackData::invokeCallback):
- bindings/js/JSErrorHandler.cpp:
(WebCore::JSErrorHandler::handleEvent):
- bindings/js/JSEventListener.cpp:
(WebCore::JSEventListener::handleEvent):
- bindings/js/JSMainThreadExecState.h:
(WebCore::JSMainThreadExecState::profiledCall):
(WebCore::JSMainThreadExecState::profiledEvaluate):
- bindings/js/JSMutationCallback.cpp:
(WebCore::JSMutationCallback::call):
- bindings/js/ScheduledAction.cpp:
(WebCore::ScheduledAction::executeFunctionInContext):
- bindings/js/ScriptController.cpp:
(WebCore::ScriptController::evaluateInWorld):
- bindings/objc/WebScriptObject.mm:
(-[WebScriptObject callWebScriptMethod:withArguments:]):
(-[WebScriptObject evaluateWebScript:]):
Identify entry points into JSC that we want to profile for the frontend.
These were nearly all already classified for the Timeline. We added missing
support for ErrorHandlers (window.onerror handler functions).
- inspector/InspectorTimelineAgent.cpp:
(WebCore::InspectorTimelineAgent::didCallFunction):
(WebCore::InspectorTimelineAgent::didEvaluateScript):
(WebCore::startProfiling): Deleted.
(WebCore::stopProfiling): Deleted.
(WebCore::InspectorTimelineAgent::willCallFunction): Deleted.
(WebCore::InspectorTimelineAgent::willEvaluateScript): Deleted.
- inspector/InspectorTimelineAgent.h:
TimelineAgent no longer needs to start/stop the Legacy Profiler
since ScriptProfiler will automatically do that for us. Delete
all code associated with that. There is still an open question
regardingconsole.profileandconsole.profileEndthat
starts/stops the profiler.
Source/WebInspectorUI:
- UserInterface/Images/TimelineRecordAPI.svg: Added.
- UserInterface/Images/gtk/TimelineRecordAPI.svg: Added.
New [S] image for API initiated script evaluations.
Display matches the existing [S] Script Evaluated.
Colors match the gray [N] Native image colors.
- UserInterface/Models/ScriptInstrument.js:
(WebInspector.ScriptInstrument.prototype.startInstrumentation):
(WebInspector.ScriptInstrument.prototype.stopInstrumentation):
(WebInspector.ScriptInstrument):
Use ScriptProfiler, if available, in Web debuggables.
- UserInterface/Controllers/TimelineManager.js:
(WebInspector.TimelineManager):
(WebInspector.TimelineManager.prototype.capturingStarted):
(WebInspector.TimelineManager.prototype._processRecord):
(WebInspector.TimelineManager.prototype._scriptProfilerTypeToScriptTimelineRecordType):
(WebInspector.TimelineManager.prototype.scriptProfilerTrackingUpdated):
(WebInspector.TimelineManager.prototype.scriptProfilerTrackingCompleted):
(WebInspector.TimelineManager.prototype._mergeScriptProfileRecords.let.nextRecord):
(WebInspector.TimelineManager.prototype._mergeScriptProfileRecords.let.recordContainsRecord):
(WebInspector.TimelineManager.prototype._mergeScriptProfileRecords):
When running a timeline on a web debuggable the frontend receives both
Timeline event records and ScriptProfiler events. Timeline (Web) records
are high level web events like "Script Evaluated", "Event Dispatched",
"Timer Fired". The timestamps for these records should always be wrapping
a ScriptProfiler event and its associated profile data. So, at the end
of a recording we merge ScriptProfiler profile data into the original
Timeline (Web) record.
- UserInterface/Models/ScriptTimelineRecord.js:
(WebInspector.ScriptTimelineRecord.prototype.get profilePayload):
(WebInspector.ScriptTimelineRecord.prototype.set profilePayload):
(WebInspector.ScriptTimelineRecord.prototype.setProfilePayload): Deleted.
Replace method with getter/setter.
(WebInspector.ScriptTimelineRecord.EventType.displayName):
Add a new event type for API records, but share display name with Script Evaluated.
- UserInterface/Views/NavigationSidebarPanel.js:
Fix typo.
- UserInterface/Views/ScriptTimelineView.css:
(.timeline-view.script > .data-grid .eventType-column): Deleted.
There is no "eventType" column in the ScriptTimelineView datagrid, so remove styles.
- UserInterface/Views/TimelineIcons.css:
(.api-record .icon):
- UserInterface/Views/TimelineRecordTreeElement.js:
(WebInspector.TimelineRecordTreeElement):
For API Script Evaluation records use the new icon.
LayoutTests:
- inspector/script-profiler/event-type-Other-expected.txt: Added.
- inspector/script-profiler/event-type-Other.html: Added.
Add a test that Web script evaluations create "Other" ScriptProfiler events.
- 3:16 PM Changeset in webkit [194870] by
-
- 8 edits in trunk/Source
Get rid of CFMakeCollectable, it is a no-op
https://bugs.webkit.org/show_bug.cgi?id=152988
Reviewed by Sam Weinig.
Source/WebCore:
- platform/mac/WebCoreNSURLExtras.mm:
(WebCore::URLByTruncatingOneCharacterBeforeComponent):
(WebCore::URLByRemovingComponentAndSubsequentCharacter):
Source/WebKit/mac:
- Misc/WebNSDataExtras.m:
(-[NSString _web_capitalizeRFC822HeaderFieldName]):
(-[NSData _webkit_parseRFC822HeaderFields]):
- Plugins/WebPluginController.mm:
(-[WebPluginController initWithDocumentView:]):
Source/WebKit2:
- Shared/Cocoa/WKNSString.mm:
- Shared/Cocoa/WKNSURL.mm:
(-[WKNSURL _web_createTarget]):
- 2:40 PM Changeset in webkit [194869] by
-
- 7 edits in trunk/Source/JavaScriptCore
Arrays should use the InternalFunctionAllocationProfile when constructing new Arrays
https://bugs.webkit.org/show_bug.cgi?id=152949
Reviewed by Michael Saboff.
This patch updates Array constructors to use the new InternalFunctionAllocationProfile.
- runtime/ArrayConstructor.cpp:
(JSC::constructArrayWithSizeQuirk):
(JSC::constructWithArrayConstructor):
- runtime/InternalFunction.h:
(JSC::InternalFunction::createStructure):
- runtime/JSGlobalObject.h:
(JSC::JSGlobalObject::arrayStructureForIndexingTypeDuringAllocation):
(JSC::JSGlobalObject::arrayStructureForProfileDuringAllocation):
(JSC::constructEmptyArray):
(JSC::constructArray):
(JSC::constructArrayNegativeIndexed):
- runtime/PrototypeMap.cpp:
(JSC::PrototypeMap::emptyStructureForPrototypeFromBaseStructure):
- runtime/Structure.h:
- runtime/StructureInlines.h:
- 2:34 PM Changeset in webkit [194868] by
-
- 17 edits1 delete in trunk
Unreviewed, rolling out r194866.
https://bugs.webkit.org/show_bug.cgi?id=152986
This change broke the mac build (Requested by ryanhaddad on
#webkit).
Reverted changeset:
"[Cocoa] Add SPI to opt out a URL scheme from the memory
cache"
https://bugs.webkit.org/show_bug.cgi?id=152950
http://trac.webkit.org/changeset/194866
- 2:03 PM Changeset in webkit [194867] by
-
- 4 edits2 adds in trunk
Padding added to table-cell element after font-size change.
https://bugs.webkit.org/show_bug.cgi?id=152796
Reviewed by David Hyatt.
Do not include intrinsicPaddingBefore value while figuring out the height of a row.
In RenderTableSection::calcRowLogicalHeight() we are interested in the height of the content
without the additional padding (normal padding is included).
Source/WebCore:
Test: fast/table/table-baseline-grows.html
- rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::calcRowLogicalHeight):
LayoutTests:
- TestExpectations: This test fails even without the patch when Ahem font is not used.
- fast/table/table-baseline-grows-expected.html: Added.
- fast/table/table-baseline-grows.html: Added.
- 1:57 PM Changeset in webkit [194866] by
-
- 17 edits1 add in trunk
[Cocoa] Add SPI to opt out a URL scheme from the memory cache
https://bugs.webkit.org/show_bug.cgi?id=152950
rdar://problem/24066652
Reviewed by Tim Horton.
Source/WebCore:
Added a list of schemes to SchemeRegistry whose resources should always be revalidated. Taught CachedResource to
return a freshness lifetime of 0 for these resources, unless the scheme is one that should be cached indefinitely.
New API test: WebKit2.AlwaysRevalidatedURLSchemes
- loader/cache/CachedResource.cpp:
(WebCore::shouldCacheSchemeIndefinitely): Moved from SchemeRegistry::shouldCacheResponsesFromURLSchemeIndefinitely().
(WebCore::CachedResource::freshnessLifetime): For a scheme that should not be cached indefinitely, return 0 if
that scheme should always be revalidated according to SchemeRegistry.
- platform/SchemeRegistry.cpp:
(WebCore::alwaysRevalidatedSchemes):
(WebCore::SchemeRegistry::registerURLSchemeAsAlwaysRevalidated):
(WebCore::SchemeRegistry::shouldAlwaysRevalidateURLScheme):
(WebCore::SchemeRegistry::shouldCacheResponsesFromURLSchemeIndefinitely): Moved to WebCore::shouldCacheSchemeIndefinitely().
There was no reason for this to be in SchemeRegistry.
- platform/SchemeRegistry.h:
Source/WebKit2:
Added a alwaysRevalidatedURLSchemes property to _WKProcessPoolConfiguration. Taught WebProcess to add these
schemes to SchemeRegistry when initializing a new web process.
- Shared/WebProcessCreationParameters.cpp:
(WebKit::WebProcessCreationParameters::encode):
(WebKit::WebProcessCreationParameters::decode):
- Shared/WebProcessCreationParameters.h:
- UIProcess/API/APIProcessPoolConfiguration.cpp:
(API::ProcessPoolConfiguration::copy):
- UIProcess/API/APIProcessPoolConfiguration.h:
- UIProcess/API/Cocoa/_WKProcessPoolConfiguration.h:
- UIProcess/API/Cocoa/_WKProcessPoolConfiguration.mm:
(-[_WKProcessPoolConfiguration alwaysRevalidatedURLSchemes]):
(-[_WKProcessPoolConfiguration setAlwaysRevalidatedURLSchemes:]):
- UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::createNewWebProcess):
- UIProcess/WebProcessPool.h:
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::initializeWebProcess):
(WebKit::WebProcess::registerURLSchemeAsAlwaysRevalidated):
- WebProcess/WebProcess.h:
Tools:
Added an API test.
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/WebKit2Cocoa/AlwaysRevalidatedURLSchemes.mm: Added.
(+[AlwaysRevalidatedURLSchemeProtocol canInitWithRequest:]):
(+[AlwaysRevalidatedURLSchemeProtocol canonicalRequestForRequest:]):
(+[AlwaysRevalidatedURLSchemeProtocol requestIsCacheEquivalent:toRequest:]):
(-[AlwaysRevalidatedURLSchemeProtocol startLoading]):
(-[AlwaysRevalidatedURLSchemeProtocol stopLoading]):
(-[AlwaysRevalidatedURLSchemesDelegate webView:didFinishNavigation:]):
(TEST):
- 1:49 PM Changeset in webkit [194865] by
-
- 4 edits17 adds in trunk
Picture element needs to work with the preload scanner and select the correct
source element instead of loading the image.
https://bugs.webkit.org/show_bug.cgi?id=152983
Reviewed by Dean Jackson.
Source/WebCore:
Added new tests in http/tests/loading.
- html/parser/HTMLPreloadScanner.cpp:
(WebCore::TokenPreloadScanner::tagIdFor):
(WebCore::TokenPreloadScanner::initiatorFor):
(WebCore::TokenPreloadScanner::StartTagScanner::StartTagScanner):
(WebCore::TokenPreloadScanner::StartTagScanner::processAttributes):
(WebCore::TokenPreloadScanner::StartTagScanner::processImageAndScriptAttribute):
(WebCore::TokenPreloadScanner::StartTagScanner::processAttribute):
(WebCore::TokenPreloadScanner::StartTagScanner::resourceType):
(WebCore::TokenPreloadScanner::scan):
- html/parser/HTMLPreloadScanner.h:
(WebCore::TokenPreloadScanner::setPredictedBaseElementURL):
(WebCore::TokenPreloadScanner::inPicture):
LayoutTests:
These tests are imported from Blink, although they have been modified slightly to
reflect the fact that we pass the nested <picture> cases that Blink fails.
- http/tests/loading/hidpi-preload-picture-sizes-expected.txt: Added.
- http/tests/loading/hidpi-preload-picture-sizes.html: Added.
- http/tests/loading/preload-picture-invalid-expected.txt: Added.
- http/tests/loading/preload-picture-invalid.html: Added.
- http/tests/loading/preload-picture-nested-expected.txt: Added.
- http/tests/loading/preload-picture-nested.html: Added.
- http/tests/loading/preload-picture-sizes-expected.txt: Added.
- http/tests/loading/preload-picture-sizes.html: Added.
- http/tests/loading/resources/base-image1.png: Added.
- http/tests/loading/resources/base-image2.png: Added.
- http/tests/loading/resources/base-image3.png: Added.
- http/tests/loading/resources/dup-image1.png: Added.
- http/tests/loading/resources/dup-image2.png: Added.
- http/tests/loading/resources/dup-image3.png: Added.
- http/tests/loading/resources/image1.png: Added.
- http/tests/loading/resources/image2.png: Added.
- http/tests/loading/resources/picture-preload-helper.js: Added.
- 1:37 PM Changeset in webkit [194864] by
-
- 9 edits1 copy in trunk
LayoutTests/imported/w3c:
Modern IDB: IDBBindingUtilities chokes on unicode strings for get/set.
https://bugs.webkit.org/show_bug.cgi?id=152921
Reviewed by Alex Christensen.
- indexeddb/keygenerator-overflow-expected.txt:
Source/WebCore:
Modern IDB: storage/indexeddb/key-generator.html fails.
https://bugs.webkit.org/show_bug.cgi?id=152981
Reviewed by Alex Christensen.
No new tests (One failing test now passes, and one test's results get a progression).
- Modules/indexeddb/server/IDBBackingStore.h:
- Modules/indexeddb/server/MemoryIDBBackingStore.cpp:
(WebCore::IDBServer::MemoryIDBBackingStore::generateKeyNumber): Throw an error if the current
value is already over 253.
(WebCore::IDBServer::MemoryIDBBackingStore::revertGeneratedKeyNumber):
(WebCore::IDBServer::MemoryIDBBackingStore::maybeUpdateKeyGeneratorNumber): Handle double -> uint64_t
conversions properly when calculating the next key.
- Modules/indexeddb/server/MemoryIDBBackingStore.h:
- Modules/indexeddb/server/UniqueIDBDatabase.cpp:
(WebCore::IDBServer::ScopeGuard::ScopeGuard): Add this utility class to call a function
any time it goes out of scope.
(WebCore::IDBServer::ScopeGuard::~ScopeGuard):
(WebCore::IDBServer::ScopeGuard::enable):
(WebCore::IDBServer::ScopeGuard::disable):
(WebCore::IDBServer::UniqueIDBDatabase::performPutOrAdd): Revert the key generator value if
the put/add operation ends in error.
LayoutTests:
Modern IDB: storage/indexeddb/key-generator.html fails.
https://bugs.webkit.org/show_bug.cgi?id=152981
Reviewed by Alex Christensen.
- platform/mac-wk1/TestExpectations:
- platform/wk2/imported/w3c/indexeddb/keygenerator-overflow-expected.txt: Copied from LayoutTests/imported/w3c/indexeddb/keygenerator-overflow-expected.txt.
- 1:31 PM Changeset in webkit [194863] by
-
- 40 edits2 adds in trunk/Source/JavaScriptCore
Use a profile to store allocation structures for subclasses of InternalFunctions
https://bugs.webkit.org/show_bug.cgi?id=152942
Reviewed by Michael Saboff.
This patch adds InternalFunctionAllocationProfile to FunctionRareData, which holds
a cached structure that can be used to quickly allocate any derived class of an InternalFunction.
InternalFunctionAllocationProfile ended up being distinct from ObjectAllocationProfile, due to
constraints imposed by Reflect.construct. Reflect.construct allows the user to pass an arbitrary
constructor as a new.target to any other constructor. This means that a user can pass some
non-derived constructor to an InternalFunction (they can even pass another InternalFunction as the
new.target). If we use the same profile for both InternalFunctions and JS allocations then we always
need to check in both JS code and C++ code that the profiled structure has the same ClassInfo as the
current constructor. By using different profiles, we only need to check the profile in InternalFunctions
as all JS constructed objects share the same ClassInfo (JSFinalObject). This comes at the relatively
low cost of using slightly more memory on FunctionRareData and being slightly more conceptually complex.
Additionally, this patch adds subclassing to some omitted classes.
- API/JSObjectRef.cpp:
(JSObjectMakeDate):
(JSObjectMakeRegExp):
- JavaScriptCore.xcodeproj/project.pbxproj:
- bytecode/InternalFunctionAllocationProfile.h: Added.
(JSC::InternalFunctionAllocationProfile::structure):
(JSC::InternalFunctionAllocationProfile::clear):
(JSC::InternalFunctionAllocationProfile::visitAggregate):
(JSC::InternalFunctionAllocationProfile::createAllocationStructureFromBase):
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
- dfg/DFGOperations.cpp:
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_create_this):
- jit/JITOpcodes32_64.cpp:
(JSC::JIT::emit_op_create_this):
- llint/LowLevelInterpreter32_64.asm:
- llint/LowLevelInterpreter64.asm:
- runtime/BooleanConstructor.cpp:
(JSC::constructWithBooleanConstructor):
- runtime/CommonSlowPaths.cpp:
(JSC::SLOW_PATH_DECL):
- runtime/DateConstructor.cpp:
(JSC::constructDate):
(JSC::constructWithDateConstructor):
- runtime/DateConstructor.h:
- runtime/ErrorConstructor.cpp:
(JSC::Interpreter::constructWithErrorConstructor):
- runtime/FunctionRareData.cpp:
(JSC::FunctionRareData::create):
(JSC::FunctionRareData::visitChildren):
(JSC::FunctionRareData::FunctionRareData):
(JSC::FunctionRareData::initializeObjectAllocationProfile):
(JSC::FunctionRareData::clear):
(JSC::FunctionRareData::finishCreation): Deleted.
(JSC::FunctionRareData::initialize): Deleted.
- runtime/FunctionRareData.h:
(JSC::FunctionRareData::offsetOfObjectAllocationProfile):
(JSC::FunctionRareData::objectAllocationProfile):
(JSC::FunctionRareData::objectAllocationStructure):
(JSC::FunctionRareData::allocationProfileWatchpointSet):
(JSC::FunctionRareData::isObjectAllocationProfileInitialized):
(JSC::FunctionRareData::internalFunctionAllocationStructure):
(JSC::FunctionRareData::createInternalFunctionAllocationStructureFromBase):
(JSC::FunctionRareData::offsetOfAllocationProfile): Deleted.
(JSC::FunctionRareData::allocationProfile): Deleted.
(JSC::FunctionRareData::allocationStructure): Deleted.
(JSC::FunctionRareData::isInitialized): Deleted.
- runtime/InternalFunction.cpp:
(JSC::InternalFunction::createSubclassStructure):
- runtime/InternalFunction.h:
- runtime/JSArrayBufferConstructor.cpp:
(JSC::constructArrayBuffer):
- runtime/JSFunction.cpp:
(JSC::JSFunction::allocateRareData):
(JSC::JSFunction::allocateAndInitializeRareData):
(JSC::JSFunction::initializeRareData):
- runtime/JSFunction.h:
(JSC::JSFunction::rareData):
- runtime/JSGenericTypedArrayViewConstructorInlines.h:
(JSC::constructGenericTypedArrayView):
- runtime/JSObject.h:
(JSC::JSFinalObject::typeInfo):
(JSC::JSFinalObject::createStructure):
- runtime/JSPromiseConstructor.cpp:
(JSC::constructPromise):
- runtime/JSPromiseConstructor.h:
- runtime/JSWeakMap.cpp:
- runtime/JSWeakSet.cpp:
- runtime/MapConstructor.cpp:
(JSC::constructMap):
- runtime/NativeErrorConstructor.cpp:
(JSC::Interpreter::constructWithNativeErrorConstructor):
- runtime/NumberConstructor.cpp:
(JSC::constructWithNumberConstructor):
- runtime/PrototypeMap.cpp:
(JSC::PrototypeMap::createEmptyStructure):
(JSC::PrototypeMap::emptyStructureForPrototypeFromBaseStructure):
(JSC::PrototypeMap::emptyObjectStructureForPrototype):
(JSC::PrototypeMap::clearEmptyObjectStructureForPrototype):
- runtime/PrototypeMap.h:
- runtime/RegExpConstructor.cpp:
(JSC::getRegExpStructure):
(JSC::constructRegExp):
(JSC::constructWithRegExpConstructor):
- runtime/RegExpConstructor.h:
- runtime/SetConstructor.cpp:
(JSC::constructSet):
- runtime/WeakMapConstructor.cpp:
(JSC::constructWeakMap):
- runtime/WeakSetConstructor.cpp:
(JSC::constructWeakSet):
- tests/stress/class-subclassing-misc.js:
(A):
(D):
(E):
(WM):
(WS):
(test):
- tests/stress/class-subclassing-typedarray.js: Added.
(test):
- 1:28 PM Changeset in webkit [194862] by
-
- 2 edits in trunk/Source/JavaScriptCore
[B3][Win64] Compile error.
https://bugs.webkit.org/show_bug.cgi?id=152984
Reviewed by Alex Christensen.
Windows does not have bzero, use memset instead.
- b3/air/AirIteratedRegisterCoalescing.cpp:
- 1:04 PM Changeset in webkit [194861] by
-
- 2 edits in trunk/Source/JavaScriptCore
Fixed compilation of JavaScriptCore with GCC 4.8 on 32-bit platforms
https://bugs.webkit.org/show_bug.cgi?id=152923
Patch by Konstantin Tokarev <Konstantin Tokarev> on 2016-01-11
Reviewed by Alex Christensen.
- jit/CallFrameShuffler.h:
(JSC::CallFrameShuffler::assumeCalleeIsCell):
- 1:00 PM Changeset in webkit [194860] by
-
- 2 edits in trunk/Source/WebKit2
Fix Mac CMake build after r194810.
- PlatformMac.cmake:
PendingDownload isn't needed until NETWORK_SESSION is used by default.
I'll figure this out when I make the switch.
- 12:18 PM Changeset in webkit [194859] by
-
- 5 edits in trunk
Modern IDB: storage/indexeddb/lazy-index-population.html fails.
https://bugs.webkit.org/show_bug.cgi?id=152976
Reviewed by Alex Christensen.
Source/WebCore:
No new tests (At least one failing test now passes).
We were restoring objectstores/indexes incorrectly on transaction abort.
- Modules/indexeddb/server/MemoryBackingStoreTransaction.cpp:
(WebCore::IDBServer::MemoryBackingStoreTransaction::abort):
- Modules/indexeddb/server/MemoryIDBBackingStore.cpp:
(WebCore::IDBServer::MemoryIDBBackingStore::removeObjectStoreForVersionChangeAbort):
LayoutTests:
- platform/mac-wk1/TestExpectations:
- 10:13 AM Changeset in webkit [194858] by
-
- 6 edits in trunk/Source/JavaScriptCore
[B3] Fix control reaches end of non-void function GCC warnings on Linux
https://bugs.webkit.org/show_bug.cgi?id=152887
Reviewed by Mark Lam.
- b3/B3LowerToAir.cpp:
(JSC::B3::Air::LowerToAir::createBranch):
(JSC::B3::Air::LowerToAir::createCompare):
(JSC::B3::Air::LowerToAir::createSelect):
- b3/B3Type.h:
(JSC::B3::sizeofType):
- b3/air/AirArg.cpp:
(JSC::B3::Air::Arg::isRepresentableAs):
- b3/air/AirArg.h:
(JSC::B3::Air::Arg::isAnyUse):
(JSC::B3::Air::Arg::isColdUse):
(JSC::B3::Air::Arg::isEarlyUse):
(JSC::B3::Air::Arg::isLateUse):
(JSC::B3::Air::Arg::isAnyDef):
(JSC::B3::Air::Arg::isEarlyDef):
(JSC::B3::Air::Arg::isLateDef):
(JSC::B3::Air::Arg::isZDef):
(JSC::B3::Air::Arg::widthForB3Type):
(JSC::B3::Air::Arg::isGP):
(JSC::B3::Air::Arg::isFP):
(JSC::B3::Air::Arg::isType):
(JSC::B3::Air::Arg::isValidForm):
- b3/air/AirCode.h:
(JSC::B3::Air::Code::newTmp):
(JSC::B3::Air::Code::numTmps):
- 9:39 AM Changeset in webkit [194857] by
-
- 9 edits in trunk/Source/WebCore
Modern IDB: Make MemoryIndex and MemoryObjectStore RefCounted.
https://bugs.webkit.org/show_bug.cgi?id=152966
Reviewed by Alex Christensen.
No new tests (Refactor, no change in behavior)
- Modules/indexeddb/server/MemoryBackingStoreTransaction.cpp:
(WebCore::IDBServer::MemoryBackingStoreTransaction::indexDeleted):
(WebCore::IDBServer::MemoryBackingStoreTransaction::objectStoreDeleted):
(WebCore::IDBServer::MemoryBackingStoreTransaction::abort):
- Modules/indexeddb/server/MemoryBackingStoreTransaction.h:
- Modules/indexeddb/server/MemoryIDBBackingStore.cpp:
(WebCore::IDBServer::MemoryIDBBackingStore::createObjectStore):
(WebCore::IDBServer::MemoryIDBBackingStore::deleteObjectStore):
(WebCore::IDBServer::MemoryIDBBackingStore::restoreObjectStoreForVersionChangeAbort):
(WebCore::IDBServer::MemoryIDBBackingStore::registerObjectStore):
(WebCore::IDBServer::MemoryIDBBackingStore::takeObjectStoreByName):
- Modules/indexeddb/server/MemoryIDBBackingStore.h:
- Modules/indexeddb/server/MemoryIndex.cpp:
(WebCore::IDBServer::MemoryIndex::create):
- Modules/indexeddb/server/MemoryIndex.h:
- Modules/indexeddb/server/MemoryObjectStore.cpp:
(WebCore::IDBServer::MemoryObjectStore::create):
(WebCore::IDBServer::MemoryObjectStore::createIndex):
(WebCore::IDBServer::MemoryObjectStore::maybeRestoreDeletedIndex):
(WebCore::IDBServer::MemoryObjectStore::takeIndexByName):
(WebCore::IDBServer::MemoryObjectStore::deleteIndex):
(WebCore::IDBServer::MemoryObjectStore::updateIndexesForDeleteRecord):
(WebCore::IDBServer::MemoryObjectStore::updateIndexesForPutRecord):
(WebCore::IDBServer::MemoryObjectStore::registerIndex):
- Modules/indexeddb/server/MemoryObjectStore.h:
- 9:25 AM Changeset in webkit [194856] by
-
- 8 edits1 add in trunk/Source/JavaScriptCore
Make it easier to introduce exotic instructions to Air
https://bugs.webkit.org/show_bug.cgi?id=152953
Reviewed by Benjamin Poulain.
Currently, you can define new "opcodes" in Air using either:
1) New opcode declared in AirOpcode.opcodes.
2) Patch opcode with a new implementation of Air::Special.
With (1), you are limited to fixed-argument-length instructions. There are other
restrictions as well, like that you can only use the roles that the AirOpcode syntax
supports.
With (2), you can do anything you like, but the instruction will be harder to match
since it will share the same opcode as any other Patch. Also, the instruction will have
the Special argument, which means more busy-work when creating the instruction and
validating it.
This introduces an in-between facility called "custom". This replaces what AirOpcode
previously called "special". A custom instruction is one whose behavior is defined by a
FooCustom struct with some static methods. Calls to those methods are emitted by
opcode_generator.rb.
The "custom" facility is powerful enough to be used to implement Patch, with the caveat
that we now treat the Patch instruction specially in a few places. Those places were
already effectively treating it specially by assuming that only Patch instructions have
a Special as their first argument.
This will let me implement the Shuffle instruction (bug 152952), which I think is needed
for performance work.
- JavaScriptCore.xcodeproj/project.pbxproj:
- b3/air/AirCustom.h: Added.
(JSC::B3::Air::PatchCustom::forEachArg):
(JSC::B3::Air::PatchCustom::isValidFormStatic):
(JSC::B3::Air::PatchCustom::isValidForm):
(JSC::B3::Air::PatchCustom::admitsStack):
(JSC::B3::Air::PatchCustom::hasNonArgNonControlEffects):
(JSC::B3::Air::PatchCustom::generate):
- b3/air/AirHandleCalleeSaves.cpp:
(JSC::B3::Air::handleCalleeSaves):
- b3/air/AirInst.h:
- b3/air/AirInstInlines.h:
(JSC::B3::Air::Inst::forEach):
(JSC::B3::Air::Inst::extraClobberedRegs):
(JSC::B3::Air::Inst::extraEarlyClobberedRegs):
(JSC::B3::Air::Inst::forEachDefWithExtraClobberedRegs):
(JSC::B3::Air::Inst::reportUsedRegisters):
(JSC::B3::Air::Inst::hasSpecial): Deleted.
- b3/air/AirOpcode.opcodes:
- b3/air/AirReportUsedRegisters.cpp:
(JSC::B3::Air::reportUsedRegisters):
- b3/air/opcode_generator.rb:
- 9:18 AM Changeset in webkit [194855] by
-
- 9 edits1 add in trunk/Source/JavaScriptCore
Turn Check(true) into Patchpoint() followed by Oops
https://bugs.webkit.org/show_bug.cgi?id=152968
Reviewed by Benjamin Poulain.
This is an obvious strength reduction to have, especially since if we discover that the
input to the Check is true after some amount of B3 optimization, then stubbing out the rest
of the basic block unlocks CFG simplification opportunities.
It's also a proof-of-concept for the Check->Patchpoint conversion that I'll use once I
implement sinking (bug 152162).
- b3/B3ControlValue.cpp:
(JSC::B3::ControlValue::convertToJump):
(JSC::B3::ControlValue::convertToOops):
(JSC::B3::ControlValue::dumpMeta):
- b3/B3ControlValue.h:
- b3/B3InsertionSet.h:
(JSC::B3::InsertionSet::insertValue):
- b3/B3InsertionSetInlines.h:
(JSC::B3::InsertionSet::insert):
- b3/B3ReduceStrength.cpp:
- b3/B3StackmapValue.h:
- b3/B3Value.h:
- tests/stress/ftl-force-osr-exit.js: Added.
- 8:55 AM Changeset in webkit [194854] by
-
- 2 edits in trunk/Source/WebCore
Fix other builds after my MSVC build fix. :-|
- css/StyleResolver.cpp:
- 8:42 AM Changeset in webkit [194853] by
-
- 2 edits70 adds in trunk/LayoutTests
[GTK] Update test expectations after r194845
Unreviewed gardening. Mark XHTML tests as passing now that we have patched shared-mime-info
to better detect XHTML. Add expectations for additional XHTML tests that were unskipped in
r194845.
- platform/gtk/TestExpectations:
- platform/gtk/css2.1/tables/table-anonymous-objects-015-expected.txt: Added.
- platform/gtk/css2.1/tables/table-anonymous-objects-016-expected.txt: Added.
- platform/gtk/css2.1/tables/table-anonymous-objects-023-expected.txt: Added.
- platform/gtk/css2.1/tables/table-anonymous-objects-024-expected.txt: Added.
- platform/gtk/css2.1/tables/table-anonymous-objects-035-expected.txt: Added.
- platform/gtk/css2.1/tables/table-anonymous-objects-036-expected.txt: Added.
- platform/gtk/css2.1/tables/table-anonymous-objects-037-expected.txt: Added.
- platform/gtk/css2.1/tables/table-anonymous-objects-038-expected.txt: Added.
- platform/gtk/css2.1/tables/table-anonymous-objects-045-expected.txt: Added.
- platform/gtk/css2.1/tables/table-anonymous-objects-046-expected.txt: Added.
- platform/gtk/css2.1/tables/table-anonymous-objects-047-expected.txt: Added.
- platform/gtk/css2.1/tables/table-anonymous-objects-048-expected.txt: Added.
- platform/gtk/css2.1/tables/table-anonymous-objects-049-expected.txt: Added.
- platform/gtk/css2.1/tables/table-anonymous-objects-050-expected.txt: Added.
- platform/gtk/css2.1/tables/table-anonymous-objects-055-expected.txt: Added.
- platform/gtk/css2.1/tables/table-anonymous-objects-056-expected.txt: Added.
- platform/gtk/css2.1/tables/table-anonymous-objects-091-expected.txt: Added.
- platform/gtk/css2.1/tables/table-anonymous-objects-092-expected.txt: Added.
- platform/gtk/css2.1/tables/table-anonymous-objects-099-expected.txt: Added.
- platform/gtk/css2.1/tables/table-anonymous-objects-100-expected.txt: Added.
- platform/gtk/css2.1/tables/table-anonymous-objects-103-expected.txt: Added.
- platform/gtk/css2.1/tables/table-anonymous-objects-104-expected.txt: Added.
- platform/gtk/css2.1/tables/table-anonymous-objects-105-expected.txt: Added.
- platform/gtk/css2.1/tables/table-anonymous-objects-106-expected.txt: Added.
- platform/gtk/css2.1/tables/table-anonymous-objects-107-expected.txt: Added.
- platform/gtk/css2.1/tables/table-anonymous-objects-108-expected.txt: Added.
- platform/gtk/css2.1/tables/table-anonymous-objects-109-expected.txt: Added.
- platform/gtk/css2.1/tables/table-anonymous-objects-110-expected.txt: Added.
- platform/gtk/css2.1/tables/table-anonymous-objects-111-expected.txt: Added.
- platform/gtk/css2.1/tables/table-anonymous-objects-112-expected.txt: Added.
- platform/gtk/css2.1/tables/table-anonymous-objects-113-expected.txt: Added.
- platform/gtk/css2.1/tables/table-anonymous-objects-114-expected.txt: Added.
- platform/gtk/css2.1/tables/table-anonymous-objects-115-expected.txt: Added.
- platform/gtk/css2.1/tables/table-anonymous-objects-116-expected.txt: Added.
- platform/gtk/css2.1/tables/table-anonymous-objects-117-expected.txt: Added.
- platform/gtk/css2.1/tables/table-anonymous-objects-118-expected.txt: Added.
- platform/gtk/css2.1/tables/table-anonymous-objects-119-expected.txt: Added.
- platform/gtk/css2.1/tables/table-anonymous-objects-120-expected.txt: Added.
- platform/gtk/css2.1/tables/table-anonymous-objects-121-expected.txt: Added.
- platform/gtk/css2.1/tables/table-anonymous-objects-122-expected.txt: Added.
- platform/gtk/css2.1/tables/table-anonymous-objects-123-expected.txt: Added.
- platform/gtk/css2.1/tables/table-anonymous-objects-124-expected.txt: Added.
- platform/gtk/css2.1/tables/table-anonymous-objects-139-expected.txt: Added.
- platform/gtk/css2.1/tables/table-anonymous-objects-140-expected.txt: Added.
- platform/gtk/css2.1/tables/table-anonymous-objects-149-expected.txt: Added.
- platform/gtk/css2.1/tables/table-anonymous-objects-150-expected.txt: Added.
- platform/gtk/css2.1/tables/table-anonymous-objects-155-expected.txt: Added.
- platform/gtk/css2.1/tables/table-anonymous-objects-156-expected.txt: Added.
- platform/gtk/css2.1/tables/table-anonymous-objects-159-expected.txt: Added.
- platform/gtk/css2.1/tables/table-anonymous-objects-160-expected.txt: Added.
- platform/gtk/css2.1/tables/table-anonymous-objects-165-expected.txt: Added.
- platform/gtk/css2.1/tables/table-anonymous-objects-166-expected.txt: Added.
- platform/gtk/css2.1/tables/table-anonymous-objects-177-expected.txt: Added.
- platform/gtk/css2.1/tables/table-anonymous-objects-178-expected.txt: Added.
- platform/gtk/css2.1/tables/table-anonymous-objects-179-expected.txt: Added.
- platform/gtk/css2.1/tables/table-anonymous-objects-180-expected.txt: Added.
- platform/gtk/css2.1/tables/table-anonymous-objects-181-expected.txt: Added.
- platform/gtk/css2.1/tables/table-anonymous-objects-189-expected.txt: Added.
- platform/gtk/css2.1/tables/table-anonymous-objects-190-expected.txt: Added.
- platform/gtk/css2.1/tables/table-anonymous-objects-191-expected.txt: Added.
- platform/gtk/css2.1/tables/table-anonymous-objects-192-expected.txt: Added.
- platform/gtk/css2.1/tables/table-anonymous-objects-193-expected.txt: Added.
- platform/gtk/css2.1/tables/table-anonymous-objects-194-expected.txt: Added.
- platform/gtk/css2.1/tables/table-anonymous-objects-195-expected.txt: Added.
- platform/gtk/css2.1/tables/table-anonymous-objects-196-expected.txt: Added.
- platform/gtk/css2.1/tables/table-anonymous-objects-205-expected.txt: Added.
- platform/gtk/css2.1/tables/table-anonymous-objects-206-expected.txt: Added.
- platform/gtk/css2.1/tables/table-anonymous-objects-207-expected.txt: Added.
- platform/gtk/css2.1/tables/table-anonymous-objects-208-expected.txt: Added.
- 8:39 AM WebKitGTK/Gardening/Calendar edited by
- (diff)
- 8:34 AM Changeset in webkit [194852] by
-
- 2 edits in trunk/LayoutTests
Skipping unsupported test pageoverlay/overlay-small-frame-mouse-events.html on ios-simulator
https://bugs.webkit.org/show_bug.cgi?id=152130
Unreviewed test gardening.
- platform/ios-simulator/TestExpectations:
- 8:33 AM Changeset in webkit [194851] by
-
- 7 edits in trunk/Source/WebCore
Fix MSVC build after r194848.
Since MSVC refuses to recognize the friendship between LazyNeverDestroyed
and some CSS*Value classes, make their constructors public in MSVC builds.
Added FIXME's to make it look extra gross.
- css/CSSInheritedValue.h:
(WebCore::CSSInheritedValue::create): Deleted.
- css/CSSInitialValue.h:
- css/CSSPrimitiveValue.h:
- css/CSSRevertValue.h:
(WebCore::CSSRevertValue::create): Deleted.
- css/CSSUnsetValue.h:
(WebCore::CSSUnsetValue::create): Deleted.
- css/StyleResolver.cpp:
(WebCore::StyleResolver::applyProperty):
- 8:21 AM Changeset in webkit [194850] by
-
- 3 edits in trunk/Source/JavaScriptCore
[JSC] When resolving Stack arguments, use addressing from SP when addressing from FP is invalid
https://bugs.webkit.org/show_bug.cgi?id=152840
Patch by Benjamin Poulain <bpoulain@apple.com> on 2016-01-11
Reviewed by Mark Lam.
ARM64 has two kinds of addressing with immediates:
-Signed 9bits direct (really only -256 to 255).
-Unsigned 12bits scaled by the load/store size.
When resolving the stack addresses, we easily run
past -256 bytes from FP. Addressing from SP gives us more
room to address the stack efficiently because we can
use unsigned immediates.
- b3/B3StackmapSpecial.cpp:
(JSC::B3::StackmapSpecial::repForArg):
- b3/air/AirAllocateStack.cpp:
(JSC::B3::Air::allocateStack):
- 7:01 AM Changeset in webkit [194849] by
-
- 2 edits in trunk/Tools
[webkitdirs] Use CMake to determine architecture on isCMakeBuild()
https://bugs.webkit.org/show_bug.cgi?id=152959
Patch by Konstantin Tokarev <Konstantin Tokarev> on 2016-01-11
Reviewed by Brent Fulgham.
- Scripts/webkitdirs.pm:
(determineArchitecture):
- 4:23 AM Changeset in webkit [194848] by
-
- 10 edits in trunk/Source
Source/WebCore:
CSSValuePool should use nonfragmented storage for eternal caches.
<https://webkit.org/b/152960>
Reviewed by Antti Koivisto.
Store all of the common cached CSS value objects in contiguous arrays
instead of lazily allocating them on the heap.
This reduces heap fragmentation (win) and removes indirection (win)
- css/CSSInheritedValue.h:
- css/CSSInitialValue.h:
- css/CSSPrimitiveValue.h:
- css/CSSRevertValue.h:
- css/CSSUnsetValue.h:
- css/CSSValuePool.cpp:
(WebCore::CSSValuePool::CSSValuePool):
(WebCore::CSSValuePool::createIdentifierValue):
(WebCore::CSSValuePool::createColorValue):
(WebCore::CSSValuePool::createValue):
(WebCore::CSSValuePool::drain): Deleted.
- css/CSSValuePool.h:
(WebCore::CSSValuePool::createInheritedValue):
(WebCore::CSSValuePool::createImplicitInitialValue):
(WebCore::CSSValuePool::createExplicitInitialValue):
(WebCore::CSSValuePool::createUnsetValue):
(WebCore::CSSValuePool::createRevertValue):
Source/WTF:
NeverDestroyed should relax adoption requirements on all RefCountedBase subclasses.
<https://webkit.org/b/152960>
Reviewed by Antti Koivisto.
Instead of relaxing on subclasses of RefCounted<T>, relax on subclasses of RefCountedBase.
This allows e.g NeverDestroyed<CSSPrimitiveValue> to relax its pointee despite the class
hierarchy starting with RefCounted<CSSValue> (not RefCounted<CSSPrimitiveValue>.)
- wtf/NeverDestroyed.h:
- 3:39 AM Changeset in webkit [194847] by
-
- 3 edits in trunk/Source/WebCore
[GTK] Cleanup RenderThemeGtk
https://bugs.webkit.org/show_bug.cgi?id=152888
Reviewed by Michael Catanzaro.
Use a common path for GTK+ 3.19 and previous versions, simplifying
the code and removing a lot of ifdefs.
- createStyleContext() now receives a theme part enum value, and an optional parent GtkStyleContext. It encapsulates all the differences between GTK+ 3.19 and previous version leaving the rendering code common and free of ifdefs.
- Stock icons support have been removed, simplifying the code that now always renders symbolic icons, updating the colors depending on the current state.
- Media button and colors have been removed, because they are unused now that we render the media controls with CSS.
- ComboBox separators support has also been removed. In GTK+ 3.19 combo boxes no longer have separators and most of the GTK+ themes don't use the either, so it's better to simple not render them anymore in WebKit either.
- Code to paint caps lock indicator has been removed too, since caps lock indicator is now shadow dom and automatically rendered by WebCore.
- rendering/RenderThemeGtk.cpp:
(WebCore::createStyleContext):
(WebCore::loadThemedIcon):
(WebCore::gtkIconStateFlags):
(WebCore::RenderThemeGtk::adjustRepaintRect):
(WebCore::setToggleSize):
(WebCore::paintToggle):
(WebCore::RenderThemeGtk::setCheckboxSize):
(WebCore::RenderThemeGtk::paintCheckbox):
(WebCore::RenderThemeGtk::setRadioSize):
(WebCore::RenderThemeGtk::paintRadio):
(WebCore::RenderThemeGtk::paintButton):
(WebCore::getComboBoxMetrics):
(WebCore::RenderThemeGtk::popupInternalPaddingLeft):
(WebCore::RenderThemeGtk::popupInternalPaddingRight):
(WebCore::RenderThemeGtk::popupInternalPaddingTop):
(WebCore::RenderThemeGtk::popupInternalPaddingBottom):
(WebCore::RenderThemeGtk::paintMenuList):
(WebCore::RenderThemeGtk::paintTextField):
(WebCore::adjustSearchFieldIconStyle):
(WebCore::RenderThemeGtk::adjustSearchFieldResultsDecorationPartStyle):
(WebCore::paintIcon):
(WebCore::paintEntryIcon):
(WebCore::RenderThemeGtk::paintSearchFieldResultsDecorationPart):
(WebCore::RenderThemeGtk::adjustSearchFieldCancelButtonStyle):
(WebCore::RenderThemeGtk::paintSearchFieldCancelButton):
(WebCore::RenderThemeGtk::shouldHaveCapsLockIndicator):
(WebCore::RenderThemeGtk::paintSliderTrack):
(WebCore::RenderThemeGtk::paintSliderThumb):
(WebCore::RenderThemeGtk::adjustSliderThumbSize):
(WebCore::RenderThemeGtk::paintProgressBar):
(WebCore::RenderThemeGtk::adjustInnerSpinButtonStyle):
(WebCore::paintSpinArrowButton):
(WebCore::RenderThemeGtk::paintInnerSpinButton):
(WebCore::styleColor):
(WebCore::RenderThemeGtk::platformActiveSelectionBackgroundColor):
(WebCore::RenderThemeGtk::platformInactiveSelectionBackgroundColor):
(WebCore::RenderThemeGtk::platformActiveSelectionForegroundColor):
(WebCore::RenderThemeGtk::platformInactiveSelectionForegroundColor):
(WebCore::RenderThemeGtk::platformActiveListBoxSelectionBackgroundColor):
(WebCore::RenderThemeGtk::platformInactiveListBoxSelectionBackgroundColor):
(WebCore::RenderThemeGtk::platformActiveListBoxSelectionForegroundColor):
(WebCore::RenderThemeGtk::platformInactiveListBoxSelectionForegroundColor):
(WebCore::RenderThemeGtk::systemColor):
(WebCore::RenderThemeGtk::paintMediaButton):
(WebCore::RenderThemeGtk::paintMediaFullscreenButton):
(WebCore::RenderThemeGtk::paintMediaMuteButton):
(WebCore::RenderThemeGtk::paintMediaPlayButton):
(WebCore::RenderThemeGtk::paintMediaSeekBackButton):
(WebCore::RenderThemeGtk::paintMediaSeekForwardButton):
(WebCore::RenderThemeGtk::paintMediaToggleClosedCaptionsButton):
- rendering/RenderThemeGtk.h:
- 3:37 AM WebKitGTK/2.10.x edited by
- (diff)
- 3:32 AM Changeset in webkit [194846] by
-
- 2 edits in trunk/Source/WebKit2
[WK2][GTK] Propagate motion-notify-event signals from the WebView
https://bugs.webkit.org/show_bug.cgi?id=152974
Reviewed by Carlos Garcia Campos.
Always propagate motion-notify-event signals, regardless of what the
web process does, so that we can listen for those events (which does
not act on specific targets inside the webview) from the container
widget too, and not just from the WebView itself.
- UIProcess/API/gtk/WebKitWebViewBase.cpp:
(webkitWebViewBaseMotionNotifyEvent): Ensure the signal gets propagated.
- 2:49 AM Changeset in webkit [194845] by
-
- 4 edits2 adds in trunk
[GTK] W3C CSS2.1 anonymous table tests are failing
https://bugs.webkit.org/show_bug.cgi?id=152455
Reviewed by Mario Sanchez Prada.
Tools:
Add shared-mime-info to the jhbuild environment, since it affects the results of layout
tests. Add upstream patches to fix detection of XHTML files.
- gtk/jhbuild.modules:
- gtk/patches/shared-mime-info-xht-glob.patch: Added.
- gtk/patches/shared-mime-info-xhtml-magic.patch: Added.
LayoutTests:
Unskip the anonymous table tests, so the bots can generate expected results. The expected
results will be committed separately.
- platform/gtk/TestExpectations:
- 2:40 AM Changeset in webkit [194844] by
-
- 3 edits in trunk/Source/WebCore
[GTK] Cleanup ScrollbarThemeGtk
https://bugs.webkit.org/show_bug.cgi?id=152830
Reviewed by Michael Catanzaro.
Use a common path for GTK+ 3.19 and previous versions, simplifying
the code and removing a lot of ifdefs. Use always a new
GtkStyleContext, but when painting cache the newly created one so
all paint methods use that one. We were also caching some theme
properties assuming they don't change unless the theme changes,
but some of them can have different values depending on the state,
for example, when hovered or pressed. Those properties are now
only cached when we create a new GtkStyleContext.
The method updateScrollbarsFrameThickness() has also been removed,
since the Scrollbar constructor already initializes the frame rect
using the scrollbarThickness(). This method was not doing anything
anyway, since that was called on the constructor of the theme,
when there were no scrollbars registered. This also means we no
longer need to track registered/unregistered scrollbars.
- platform/gtk/ScrollbarThemeGtk.cpp:
(WebCore::ScrollbarThemeGtk::backButtonRect): Use the cached
GtkStyleContext and properties or create a new.
(WebCore::ScrollbarThemeGtk::forwardButtonRect): Ditto.
(WebCore::ScrollbarThemeGtk::trackRect): Ditto.
(WebCore::orientationStyleClass):
(WebCore::ScrollbarThemeGtk::getOrCreateStyleContext): Create a
new GtkStyleContext for the scrollbar if there isn't a cached
one. Also initialize the properties that depend on the state.
(WebCore::createChildStyleContext): Create a new GtkStyleContext
from a parent one.
(WebCore::ScrollbarThemeGtk::updateThemeProperties): Get the
properties that can only change when the theme changes.
(WebCore::ScrollbarThemeGtk::thumbRect): Use the cached
GtkStyleContext and properties or create a new.
(WebCore::adjustRectAccordingToMargin): Use always the
GtkStyleContext state instead of receiving it and setting it again.
(WebCore::ScrollbarThemeGtk::paintTrackBackground): Get or create
a GtkStyleContext for the scrollbar and create a child one for the trough.
(WebCore::ScrollbarThemeGtk::paintScrollbarBackground): Use the
cached GtkStyleContext or create a new one.
(WebCore::ScrollbarThemeGtk::paintThumb): Get or create a
GtkStyleContext for the scrollbar and create a child ones for
trough and slider.
(WebCore::ScrollbarThemeGtk::paintButton): Get or create a
GtkStyleContext for the scrollbar and create a child one for the button.
(WebCore::ScrollbarThemeGtk::paint): Create a GtkStyleContext and
cache it temporarily using TemporaryChange until the method finishes.
(WebCore::ScrollbarThemeGtk::scrollbarThickness): Use the cached
GtkStyleContext and properties or create a new.
(WebCore::ScrollbarThemeGtk::buttonSize): Ditto.
- platform/gtk/ScrollbarThemeGtk.h:
Jan 10, 2016:
- 11:27 PM Changeset in webkit [194843] by
-
- 7 edits in tags/Safari-601.5.8.2/Source/WebCore
Merged r194719. rdar://problem/23769758
- 11:22 PM Changeset in webkit [194842] by
-
- 5 edits in tags/Safari-601.5.8.2/Source
Versioning.
- 11:19 PM Changeset in webkit [194841] by
-
- 1 copy in tags/Safari-601.5.8.2
New tag.
- 10:49 PM Changeset in webkit [194840] by
-
- 34 edits9 adds in trunk
Implement a sampling profiler
https://bugs.webkit.org/show_bug.cgi?id=151713
Reviewed by Filip Pizlo.
Source/JavaScriptCore:
This patch implements a sampling profiler for JavaScriptCore
that will be used in the Inspector UI. The implementation works as follows:
We queue the sampling profiler to run a task on a background
thread every 1ms. When the queued task executes, the sampling profiler
will pause the JSC execution thread and attempt to take a stack trace.
The sampling profiler does everything it can to be very careful
while taking this stack trace. Because it's reading arbitrary memory,
the sampling profiler must validate every pointer it reads from.
The sampling profiler tries to get an ExecutableBase for every call frame
it reads. It first tries to read the CodeBlock slot. It does this because
it can be 100% certain that a pointer is a CodeBlock while it's taking a
stack trace. But, not every call frame will have a CodeBlock. So we must read
the call frame's callee. For these stack traces where we read the callee, we
must verify the callee pointer, and the pointer traversal to an ExecutableBase,
on the main JSC execution thread, and not on the thread taking the stack
trace. We do this verification either before we run the marking phase in
GC, or when somebody asks the SamplingProfiler to materialize its data.
The SamplingProfiler must also be careful to not grab any locks while the JSC execution
thread is paused (this means it can't do anything that mallocs) because
that could cause a deadlock. Therefore, the sampling profiler grabs
locks for all data structures it consults before it pauses the JSC
execution thread.
- CMakeLists.txt:
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters:
- JavaScriptCore.xcodeproj/project.pbxproj:
- bytecode/CodeBlock.h:
(JSC::CodeBlock::clearVisitWeaklyHasBeenCalled):
(JSC::CodeBlockSet::mark):
- dfg/DFGNodeType.h:
- heap/CodeBlockSet.cpp:
(JSC::CodeBlockSet::add):
(JSC::CodeBlockSet::promoteYoungCodeBlocks):
(JSC::CodeBlockSet::clearMarksForFullCollection):
(JSC::CodeBlockSet::lastChanceToFinalize):
(JSC::CodeBlockSet::deleteUnmarkedAndUnreferenced):
(JSC::CodeBlockSet::contains):
(JSC::CodeBlockSet::writeBarrierCurrentlyExecutingCodeBlocks):
(JSC::CodeBlockSet::remove): Deleted.
- heap/CodeBlockSet.h:
(JSC::CodeBlockSet::getLock):
(JSC::CodeBlockSet::iterate):
The sampling pofiler uses the heap's CodeBlockSet to validate
CodeBlock pointers. This data structure must now be under a lock
because we must be certain we're not pausing the JSC execution thread
while it's manipulating this data structure.
- heap/ConservativeRoots.cpp:
(JSC::ConservativeRoots::ConservativeRoots):
(JSC::ConservativeRoots::grow):
(JSC::ConservativeRoots::genericAddPointer):
(JSC::ConservativeRoots::genericAddSpan):
(JSC::ConservativeRoots::add):
(JSC::CompositeMarkHook::CompositeMarkHook):
(JSC::CompositeMarkHook::mark):
- heap/ConservativeRoots.h:
- heap/Heap.cpp:
(JSC::Heap::markRoots):
(JSC::Heap::visitHandleStack):
(JSC::Heap::visitSamplingProfiler):
(JSC::Heap::traceCodeBlocksAndJITStubRoutines):
(JSC::Heap::snapshotMarkedSpace):
- heap/Heap.h:
(JSC::Heap::structureIDTable):
(JSC::Heap::codeBlockSet):
- heap/MachineStackMarker.cpp:
(pthreadSignalHandlerSuspendResume):
(JSC::getCurrentPlatformThread):
(JSC::MachineThreads::MachineThreads):
(JSC::MachineThreads::~MachineThreads):
(JSC::MachineThreads::Thread::createForCurrentThread):
(JSC::MachineThreads::Thread::operator==):
(JSC::isThreadInList):
(JSC::MachineThreads::addCurrentThread):
(JSC::MachineThreads::machineThreadForCurrentThread):
(JSC::MachineThreads::removeThread):
(JSC::MachineThreads::gatherFromCurrentThread):
(JSC::MachineThreads::Thread::Thread):
(JSC::MachineThreads::Thread::~Thread):
(JSC::MachineThreads::Thread::suspend):
(JSC::MachineThreads::Thread::resume):
(JSC::MachineThreads::Thread::getRegisters):
(JSC::MachineThreads::Thread::Registers::stackPointer):
(JSC::MachineThreads::Thread::Registers::framePointer):
(JSC::MachineThreads::Thread::Registers::instructionPointer):
(JSC::MachineThreads::Thread::freeRegisters):
(JSC::MachineThreads::tryCopyOtherThreadStacks):
(JSC::pthreadSignalHandlerSuspendResume): Deleted.
(JSC::MachineThreads::Thread::operator!=): Deleted.
- heap/MachineStackMarker.h:
(JSC::MachineThreads::Thread::operator!=):
(JSC::MachineThreads::getLock):
(JSC::MachineThreads::threadsListHead):
We can now ask a MachineThreads::Thread for its frame pointer
and program counter on darwin and windows platforms. efl
and gtk implementations will happen in another patch.
- heap/MarkedBlockSet.h:
(JSC::MarkedBlockSet::getLock):
(JSC::MarkedBlockSet::add):
(JSC::MarkedBlockSet::remove):
(JSC::MarkedBlockSet::recomputeFilter):
(JSC::MarkedBlockSet::filter):
(JSC::MarkedBlockSet::set):
- heap/MarkedSpace.cpp:
(JSC::Free::Free):
(JSC::Free::operator()):
(JSC::FreeOrShrink::FreeOrShrink):
(JSC::FreeOrShrink::operator()):
(JSC::MarkedSpace::~MarkedSpace):
(JSC::MarkedSpace::isPagedOut):
(JSC::MarkedSpace::freeBlock):
(JSC::MarkedSpace::freeOrShrinkBlock):
(JSC::MarkedSpace::shrink):
- heap/MarkedSpace.h:
(JSC::MarkedSpace::forEachLiveCell):
(JSC::MarkedSpace::forEachDeadCell):
- interpreter/CallFrame.h:
(JSC::ExecState::calleeAsValue):
(JSC::ExecState::callee):
(JSC::ExecState::unsafeCallee):
(JSC::ExecState::codeBlock):
(JSC::ExecState::scope):
- jit/ExecutableAllocator.cpp:
(JSC::ExecutableAllocator::dumpProfile):
(JSC::ExecutableAllocator::getLock):
(JSC::ExecutableAllocator::isValidExecutableMemory):
- jit/ExecutableAllocator.h:
- jit/ExecutableAllocatorFixedVMPool.cpp:
(JSC::ExecutableAllocator::allocate):
(JSC::ExecutableAllocator::isValidExecutableMemory):
(JSC::ExecutableAllocator::getLock):
(JSC::ExecutableAllocator::committedByteCount):
The sampling profiler consults the ExecutableAllocator to check
if the frame pointer it reads is in executable allocated memory.
- jsc.cpp:
(GlobalObject::finishCreation):
(functionCheckModuleSyntax):
(functionStartSamplingProfiler):
(functionSamplingProfilerStackTraces):
- llint/LLIntPCRanges.h: Added.
(JSC::LLInt::isLLIntPC):
- offlineasm/asm.rb:
I added the ability to test whether the PC is executing
LLInt code because this code is not part of the memory
our executable allocator allocates.
- runtime/Executable.h:
(JSC::ExecutableBase::isModuleProgramExecutable):
(JSC::ExecutableBase::isExecutableType):
(JSC::ExecutableBase::isHostFunction):
- runtime/JSLock.cpp:
(JSC::JSLock::didAcquireLock):
(JSC::JSLock::unlock):
- runtime/Options.h:
- runtime/SamplingProfiler.cpp: Added.
(JSC::reportStats):
(JSC::FrameWalker::FrameWalker):
(JSC::FrameWalker::walk):
(JSC::FrameWalker::wasValidWalk):
(JSC::FrameWalker::advanceToParentFrame):
(JSC::FrameWalker::isAtTop):
(JSC::FrameWalker::resetAtMachineFrame):
(JSC::FrameWalker::isValidFramePointer):
(JSC::FrameWalker::isValidCodeBlock):
(JSC::FrameWalker::tryToGetExecutableFromCallee):
The FrameWalker class is used to walk the stack in a safe
manner. It doesn't do anything that would deadlock, and it
validates all pointers that it sees.
(JSC::SamplingProfiler::SamplingProfiler):
(JSC::SamplingProfiler::~SamplingProfiler):
(JSC::SamplingProfiler::visit):
(JSC::SamplingProfiler::shutdown):
(JSC::SamplingProfiler::start):
(JSC::SamplingProfiler::stop):
(JSC::SamplingProfiler::pause):
(JSC::SamplingProfiler::noticeCurrentThreadAsJSCExecutionThread):
(JSC::SamplingProfiler::dispatchIfNecessary):
(JSC::SamplingProfiler::dispatchFunction):
(JSC::SamplingProfiler::noticeJSLockAcquisition):
(JSC::SamplingProfiler::noticeVMEntry):
(JSC::SamplingProfiler::observeStackTrace):
(JSC::SamplingProfiler::clearData):
(JSC::displayName):
(JSC::startLine):
(JSC::startColumn):
(JSC::sourceID):
(JSC::url):
(JSC::SamplingProfiler::stacktracesAsJSON):
- runtime/SamplingProfiler.h: Added.
(JSC::SamplingProfiler::getLock):
(JSC::SamplingProfiler::setTimingInterval):
(JSC::SamplingProfiler::stackTraces):
- runtime/VM.cpp:
(JSC::VM::VM):
(JSC::VM::~VM):
(JSC::VM::setLastStackTop):
(JSC::VM::createContextGroup):
(JSC::VM::ensureWatchdog):
(JSC::VM::ensureSamplingProfiler):
(JSC::thunkGeneratorForIntrinsic):
- runtime/VM.h:
(JSC::VM::watchdog):
(JSC::VM::isSafeToRecurse):
(JSC::VM::lastStackTop):
(JSC::VM::scratchBufferForSize):
(JSC::VM::samplingProfiler):
(JSC::VM::setShouldRewriteConstAsVar):
(JSC::VM::setLastStackTop): Deleted.
- runtime/VMEntryScope.cpp:
(JSC::VMEntryScope::VMEntryScope):
- tests/stress/sampling-profiler: Added.
- tests/stress/sampling-profiler-anonymous-function.js: Added.
(foo):
(baz):
- tests/stress/sampling-profiler-basic.js: Added.
(bar):
(foo):
(nothing):
(top):
(jaz):
(kaz):
(checkInlining):
- tests/stress/sampling-profiler-deep-stack.js: Added.
(foo):
(hellaDeep):
(start):
- tests/stress/sampling-profiler-microtasks.js: Added.
(testResults):
(loop.jaz):
(loop):
- tests/stress/sampling-profiler/samplingProfiler.js: Added.
(assert):
(let.nodePrototype.makeChildIfNeeded):
(makeNode):
(updateCallingContextTree):
(doesTreeHaveStackTrace):
(makeTree):
(runTest):
(dumpTree):
- tools/JSDollarVMPrototype.cpp:
(JSC::JSDollarVMPrototype::isInObjectSpace):
(JSC::JSDollarVMPrototype::isInStorageSpace):
- yarr/YarrJIT.cpp:
(JSC::Yarr::YarrGenerator::generateEnter):
(JSC::Yarr::YarrGenerator::generateReturn):
(JSC::Yarr::YarrGenerator::YarrGenerator):
(JSC::Yarr::YarrGenerator::compile):
(JSC::Yarr::jitCompile):
We now have a boolean that's set to true when
we're executing a RegExp, and to false otherwise.
The boolean lives off of VM.
- CMakeLists.txt:
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters:
- JavaScriptCore.xcodeproj/project.pbxproj:
- bytecode/CodeBlock.h:
(JSC::CodeBlock::clearVisitWeaklyHasBeenCalled):
(JSC::CodeBlockSet::mark):
- dfg/DFGNodeType.h:
- heap/CodeBlockSet.cpp:
(JSC::CodeBlockSet::add):
(JSC::CodeBlockSet::promoteYoungCodeBlocks):
(JSC::CodeBlockSet::clearMarksForFullCollection):
(JSC::CodeBlockSet::lastChanceToFinalize):
(JSC::CodeBlockSet::deleteUnmarkedAndUnreferenced):
(JSC::CodeBlockSet::contains):
(JSC::CodeBlockSet::writeBarrierCurrentlyExecutingCodeBlocks):
(JSC::CodeBlockSet::remove): Deleted.
- heap/CodeBlockSet.h:
(JSC::CodeBlockSet::getLock):
(JSC::CodeBlockSet::iterate):
- heap/ConservativeRoots.cpp:
(JSC::ConservativeRoots::ConservativeRoots):
(JSC::ConservativeRoots::genericAddPointer):
(JSC::ConservativeRoots::add):
(JSC::CompositeMarkHook::CompositeMarkHook):
(JSC::CompositeMarkHook::mark):
- heap/ConservativeRoots.h:
- heap/Heap.cpp:
(JSC::Heap::markRoots):
(JSC::Heap::visitHandleStack):
(JSC::Heap::visitSamplingProfiler):
(JSC::Heap::traceCodeBlocksAndJITStubRoutines):
- heap/Heap.h:
(JSC::Heap::structureIDTable):
(JSC::Heap::codeBlockSet):
- heap/HeapInlines.h:
(JSC::Heap::didFreeBlock):
(JSC::Heap::isPointerGCObject):
(JSC::Heap::isValueGCObject):
- heap/MachineStackMarker.cpp:
(pthreadSignalHandlerSuspendResume):
(JSC::getCurrentPlatformThread):
(JSC::MachineThreads::MachineThreads):
(JSC::MachineThreads::~MachineThreads):
(JSC::MachineThreads::Thread::createForCurrentThread):
(JSC::MachineThreads::Thread::operator==):
(JSC::isThreadInList):
(JSC::MachineThreads::addCurrentThread):
(JSC::MachineThreads::machineThreadForCurrentThread):
(JSC::MachineThreads::removeThread):
(JSC::MachineThreads::gatherFromCurrentThread):
(JSC::MachineThreads::Thread::Thread):
(JSC::MachineThreads::Thread::~Thread):
(JSC::MachineThreads::Thread::suspend):
(JSC::MachineThreads::Thread::resume):
(JSC::MachineThreads::Thread::getRegisters):
(JSC::MachineThreads::Thread::Registers::stackPointer):
(JSC::MachineThreads::Thread::Registers::framePointer):
(JSC::MachineThreads::Thread::Registers::instructionPointer):
(JSC::MachineThreads::Thread::freeRegisters):
(JSC::pthreadSignalHandlerSuspendResume): Deleted.
(JSC::MachineThreads::Thread::operator!=): Deleted.
- heap/MachineStackMarker.h:
(JSC::MachineThreads::Thread::operator!=):
(JSC::MachineThreads::getLock):
(JSC::MachineThreads::threadsListHead):
- heap/MarkedBlockSet.h:
- heap/MarkedSpace.cpp:
(JSC::Free::Free):
(JSC::Free::operator()):
(JSC::FreeOrShrink::FreeOrShrink):
(JSC::FreeOrShrink::operator()):
- interpreter/CallFrame.h:
(JSC::ExecState::calleeAsValue):
(JSC::ExecState::callee):
(JSC::ExecState::unsafeCallee):
(JSC::ExecState::codeBlock):
(JSC::ExecState::scope):
- jit/ExecutableAllocator.cpp:
(JSC::ExecutableAllocator::dumpProfile):
(JSC::ExecutableAllocator::getLock):
(JSC::ExecutableAllocator::isValidExecutableMemory):
- jit/ExecutableAllocator.h:
- jit/ExecutableAllocatorFixedVMPool.cpp:
(JSC::ExecutableAllocator::allocate):
(JSC::ExecutableAllocator::isValidExecutableMemory):
(JSC::ExecutableAllocator::getLock):
(JSC::ExecutableAllocator::committedByteCount):
- jsc.cpp:
(GlobalObject::finishCreation):
(functionCheckModuleSyntax):
(functionPlatformSupportsSamplingProfiler):
(functionStartSamplingProfiler):
(functionSamplingProfilerStackTraces):
- llint/LLIntPCRanges.h: Added.
(JSC::LLInt::isLLIntPC):
- offlineasm/asm.rb:
- runtime/Executable.h:
(JSC::ExecutableBase::isModuleProgramExecutable):
(JSC::ExecutableBase::isExecutableType):
(JSC::ExecutableBase::isHostFunction):
- runtime/JSLock.cpp:
(JSC::JSLock::didAcquireLock):
(JSC::JSLock::unlock):
- runtime/Options.h:
- runtime/SamplingProfiler.cpp: Added.
(JSC::reportStats):
(JSC::FrameWalker::FrameWalker):
(JSC::FrameWalker::walk):
(JSC::FrameWalker::wasValidWalk):
(JSC::FrameWalker::advanceToParentFrame):
(JSC::FrameWalker::isAtTop):
(JSC::FrameWalker::resetAtMachineFrame):
(JSC::FrameWalker::isValidFramePointer):
(JSC::FrameWalker::isValidCodeBlock):
(JSC::SamplingProfiler::SamplingProfiler):
(JSC::SamplingProfiler::~SamplingProfiler):
(JSC::SamplingProfiler::processUnverifiedStackTraces):
(JSC::SamplingProfiler::visit):
(JSC::SamplingProfiler::shutdown):
(JSC::SamplingProfiler::start):
(JSC::SamplingProfiler::stop):
(JSC::SamplingProfiler::pause):
(JSC::SamplingProfiler::noticeCurrentThreadAsJSCExecutionThread):
(JSC::SamplingProfiler::dispatchIfNecessary):
(JSC::SamplingProfiler::dispatchFunction):
(JSC::SamplingProfiler::noticeJSLockAcquisition):
(JSC::SamplingProfiler::noticeVMEntry):
(JSC::SamplingProfiler::clearData):
(JSC::displayName):
(JSC::SamplingProfiler::stacktracesAsJSON):
(WTF::printInternal):
- runtime/SamplingProfiler.h: Added.
(JSC::SamplingProfiler::StackFrame::StackFrame):
(JSC::SamplingProfiler::getLock):
(JSC::SamplingProfiler::setTimingInterval):
(JSC::SamplingProfiler::stackTraces):
- runtime/VM.cpp:
(JSC::VM::VM):
(JSC::VM::~VM):
(JSC::VM::setLastStackTop):
(JSC::VM::createContextGroup):
(JSC::VM::ensureWatchdog):
(JSC::VM::ensureSamplingProfiler):
(JSC::thunkGeneratorForIntrinsic):
- runtime/VM.h:
(JSC::VM::watchdog):
(JSC::VM::samplingProfiler):
(JSC::VM::isSafeToRecurse):
(JSC::VM::lastStackTop):
(JSC::VM::scratchBufferForSize):
(JSC::VM::setLastStackTop): Deleted.
- runtime/VMEntryScope.cpp:
(JSC::VMEntryScope::VMEntryScope):
- tests/stress/sampling-profiler: Added.
- tests/stress/sampling-profiler-anonymous-function.js: Added.
(platformSupportsSamplingProfiler.foo):
(platformSupportsSamplingProfiler.baz):
(platformSupportsSamplingProfiler):
- tests/stress/sampling-profiler-basic.js: Added.
(platformSupportsSamplingProfiler.bar):
(platformSupportsSamplingProfiler.foo):
(platformSupportsSamplingProfiler.nothing):
(platformSupportsSamplingProfiler.top):
(platformSupportsSamplingProfiler.jaz):
(platformSupportsSamplingProfiler.kaz):
(platformSupportsSamplingProfiler.checkInlining):
(platformSupportsSamplingProfiler):
- tests/stress/sampling-profiler-deep-stack.js: Added.
(platformSupportsSamplingProfiler.foo):
(platformSupportsSamplingProfiler.let.hellaDeep):
(platformSupportsSamplingProfiler.let.start):
(platformSupportsSamplingProfiler):
- tests/stress/sampling-profiler-microtasks.js: Added.
(platformSupportsSamplingProfiler.testResults):
(platformSupportsSamplingProfiler):
(platformSupportsSamplingProfiler.loop.jaz):
(platformSupportsSamplingProfiler.loop):
- tests/stress/sampling-profiler/samplingProfiler.js: Added.
(assert):
(let.nodePrototype.makeChildIfNeeded):
(makeNode):
(updateCallingContextTree):
(doesTreeHaveStackTrace):
(makeTree):
(runTest):
(dumpTree):
- yarr/YarrJIT.cpp:
(JSC::Yarr::YarrGenerator::generateEnter):
(JSC::Yarr::YarrGenerator::generateReturn):
(JSC::Yarr::YarrGenerator::YarrGenerator):
(JSC::Yarr::YarrGenerator::compile):
(JSC::Yarr::jitCompile):
Source/WTF:
- wtf/MetaAllocator.cpp:
(WTF::MetaAllocator::decrementPageOccupancy):
(WTF::MetaAllocator::isInAllocatedMemory):
(WTF::MetaAllocator::roundUp):
- wtf/MetaAllocator.h:
(WTF::MetaAllocator::getLock):
- wtf/Platform.h:
Tools:
- Scripts/run-jsc-stress-tests:
- 9:55 PM Changeset in webkit [194839] by
-
- 6 edits3 adds in trunk
[SVG -> OTF Converter] Parsing failures cause use of incomplete fonts
https://bugs.webkit.org/show_bug.cgi?id=152772
<rdar://problem/24043104>
Reviewed by Simon Fraser.
Source/WebCore:
Originally, if we fail to parse a glyph, we would simply skip the glyph. However, this means that
we will create an incomplete font without all the necessary glyphs. This causes very distressing
text where all the occurances of a particular letter are missing. Instead, we should treat the
entire font as invalid.
Test: fast/text/svg-font-invalid-glyph-path-failure.html
- css/CSSFontFaceSource.cpp:
(WebCore::CSSFontFaceSource::font):
- loader/cache/CachedSVGFont.cpp:
(WebCore::CachedSVGFont::ensureCustomFontData):
- svg/SVGToOTFFontConversion.cpp:
(WebCore::SVGToOTFFontConverter::error):
(WebCore::SVGToOTFFontConverter::transcodeGlyphPaths):
(WebCore::SVGToOTFFontConverter::processGlyphElement):
(WebCore::convertSVGToOTFFont):
- svg/SVGToOTFFontConversion.h:
LayoutTests:
Make sure the font renders as if its invalid.
- fast/text/resources/bustedfont.svg: Added.
- fast/text/svg-font-invalid-glyph-path-failure-expected.html: Added.
- fast/text/svg-font-invalid-glyph-path-failure.html: Added.
- 9:54 PM Changeset in webkit [194838] by
-
- 16 edits2 copies12 adds in trunk
[JSC] Iterating over a Set/Map is too slow
https://bugs.webkit.org/show_bug.cgi?id=152691
Reviewed by Saam Barati.
Source/JavaScriptCore:
Set#forEach and Set & for-of are very slow. There are 2 reasons.
- forEach is implemented in C++. And typically, taking JS callback and calling it from C++.
C++ to JS transition seems costly. perf result in Linux machine shows this.
Samples: 23K of event 'cycles', Event count (approx.): 21446074385
34.04% jsc libjavascriptcoregtk-4.0.so.18.3.1 . JSC::Interpreter::execute(JSC::CallFrameClosure&)
20.48% jsc libjavascriptcoregtk-4.0.so.18.3.1 . vmEntryToJavaScript
9.80% jsc libjavascriptcoregtk-4.0.so.18.3.1 . JSC::JITCode::execute(JSC::VM*, JSC::ProtoCallFrame*)
7.95% jsc libjavascriptcoregtk-4.0.so.18.3.1 . JSC::setProtoFuncForEach(JSC::ExecState*)
5.65% jsc perf-22854.map . 0x00007f5d2c204a6f
Writing forEach in JS eliminates this.
Samples: 23K of event 'cycles', Event count (approx.): 21255691651
62.91% jsc perf-22890.map . 0x00007fd117c0a3b9
24.89% jsc libjavascriptcoregtk-4.0.so.18.3.1 . JSC::privateFuncSetIteratorNext(JSC::ExecState*)
0.29% jsc libjavascriptcoregtk-4.0.so.18.3.1 . JSC::CodeBlock::updateAllPredictionsAndCountLiveness(unsigned int&, unsigned int&)
0.24% jsc [vdso] . 0x00000000000008e8
0.22% jsc libjavascriptcoregtk-4.0.so.18.3.1 . JSC::CodeBlock::predictedMachineCodeSize()
0.16% jsc libjavascriptcoregtk-4.0.so.18.3.1 . WTF::MetaAllocator::currentStatistics()
0.15% jsc libjavascriptcoregtk-4.0.so.18.3.1 . JSC::Lexer<unsigned char>::lex(JSC::JSToken*, unsigned int, bool)
- Iterator result object allocation is costly.
Iterator result object allocation is costly. Even if the (1) is solved, when executing Set & for-of, perf result shows very slow performance due to (2).
Samples: 108K of event 'cycles', Event count (approx.): 95529273748
18.02% jsc libjavascriptcoregtk-4.0.so.18.3.1 . JSC::createIteratorResultObject(JSC::ExecState*, JSC::JSValue, bool)
15.68% jsc jsc . JSC::JSObject::putDirect(JSC::VM&, JSC::PropertyName, JSC::JSValue, unsigned int)
14.18% jsc libjavascriptcoregtk-4.0.so.18.3.1 . JSC::PrototypeMap::emptyObjectStructureForPrototype(JSC::JSObject*, unsigned int)
13.40% jsc perf-25420.map . 0x00007fce158006a1
6.79% jsc libjavascriptcoregtk-4.0.so.18.3.1 . JSC::StructureTransitionTable::get(WTF::UniquedStringImpl*, unsigned int) const
In the long term, we should implement SetIterator#next in JS and make the iterator result object allocation written in JS to encourage object allocation elimination in FTL.
But seeing the perf result, we can find the easy to fix bottleneck in the current implementation.
Every time createIteratorResultObject creates the empty object and use putDirect to store properties.
The pre-baked Structure* withdoneandvalueproperties makes this implementation fast.
After these improvements, the micro benchmark[1] shows the following.
old:
Linked List x 212,776 ops/sec ±0.21% (162 runs sampled)
Array x 376,156 ops/sec ±0.20% (162 runs sampled)
Array forEach x 17,345 ops/sec ±0.99% (137 runs sampled)
Array for-of x 16,518 ops/sec ±0.58% (160 runs sampled)
Set forEach x 13,263 ops/sec ±0.20% (162 runs sampled)
Set for-of x 4,732 ops/sec ±0.34% (123 runs sampled)
new:
Linked List x 210,833 ops/sec ±0.28% (161 runs sampled)
Array x 371,347 ops/sec ±0.36% (162 runs sampled)
Array forEach x 17,460 ops/sec ±0.84% (136 runs sampled)
Array for-of x 16,188 ops/sec ±1.27% (158 runs sampled)
Set forEach x 23,684 ops/sec ±2.46% (139 runs sampled)
Set for-of x 12,176 ops/sec ±0.54% (157 runs sampled)
Set#forEach becomes comparable to Array#forEach. And Set#forEach and Set & for-of are improved (1.79x, and 2.57x).
After this optimizations, they are still much slower than linked list and array.
This should be optimized in the long term.
[1]: https://gist.github.com/Constellation/8db5f5b8f12fe7e283d0
- CMakeLists.txt:
- DerivedSources.make:
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters:
- JavaScriptCore.xcodeproj/project.pbxproj:
- builtins/MapPrototype.js: Copied from Source/JavaScriptCore/runtime/IteratorOperations.h.
(forEach):
- builtins/SetPrototype.js: Copied from Source/JavaScriptCore/runtime/IteratorOperations.h.
(forEach):
- runtime/CommonIdentifiers.h:
- runtime/IteratorOperations.cpp:
(JSC::createIteratorResultObjectStructure):
(JSC::createIteratorResultObject):
- runtime/IteratorOperations.h:
- runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::init):
(JSC::JSGlobalObject::visitChildren):
- runtime/JSGlobalObject.h:
(JSC::JSGlobalObject::iteratorResultObjectStructure):
(JSC::JSGlobalObject::iteratorResultStructure): Deleted.
(JSC::JSGlobalObject::iteratorResultStructureOffset): Deleted.
- runtime/MapPrototype.cpp:
(JSC::MapPrototype::getOwnPropertySlot):
(JSC::privateFuncIsMap):
(JSC::privateFuncMapIterator):
(JSC::privateFuncMapIteratorNext):
(JSC::MapPrototype::finishCreation): Deleted.
(JSC::mapProtoFuncForEach): Deleted.
- runtime/MapPrototype.h:
- runtime/SetPrototype.cpp:
(JSC::SetPrototype::getOwnPropertySlot):
(JSC::privateFuncIsSet):
(JSC::privateFuncSetIterator):
(JSC::privateFuncSetIteratorNext):
(JSC::SetPrototype::finishCreation): Deleted.
(JSC::setProtoFuncForEach): Deleted.
- runtime/SetPrototype.h:
LayoutTests:
Add regress tests.
- js/regress/map-for-each-expected.txt: Added.
- js/regress/map-for-each.html: Added.
- js/regress/map-for-of-expected.txt: Added.
- js/regress/map-for-of.html: Added.
- js/regress/script-tests/map-for-each.js: Added.
(createMap):
(i.map.forEach):
- js/regress/script-tests/map-for-of.js: Added.
(createMap):
- js/regress/script-tests/set-for-each.js: Added.
(set forEach):
(set createSet):
- js/regress/script-tests/set-for-of.js: Added.
- js/regress/set-for-each-expected.txt: Added.
- js/regress/set-for-each.html: Added.
- js/regress/set-for-of-expected.txt: Added.
- js/regress/set-for-of.html: Added.
- 7:44 PM Changeset in webkit [194837] by
-
- 2 edits in trunk/Source/JavaScriptCore
Unreviewed, fix ARM64 build.
- b3/air/AirOpcode.opcodes:
- 7:25 PM Changeset in webkit [194836] by
-
- 3 edits in trunk/Source/JavaScriptCore
B3 should reduce Trunc(BitOr(value, constant)) where !(constant & 0xffffffff) to Trunc(value)
https://bugs.webkit.org/show_bug.cgi?id=152955
Reviewed by Saam Barati.
This happens when we box an int32 and then immediately unbox it.
This makes an enormous difference on AsmBench/FloatMM. It's a 2x speed-up on that
benchmark. It's neutral elsewhere.
- b3/B3ReduceStrength.cpp:
- b3/testb3.cpp:
(JSC::B3::testPowDoubleByIntegerLoop):
(JSC::B3::testTruncOrHigh):
(JSC::B3::testTruncOrLow):
(JSC::B3::testBitAndOrHigh):
(JSC::B3::testBitAndOrLow):
(JSC::B3::zero):
(JSC::B3::run):
- 5:38 PM Changeset in webkit [194835] by
-
- 21 edits2 deletes in trunk/Source/JavaScriptCore
[ES6] Arrow function syntax. Get rid of JSArrowFunction and use standard JSFunction class
https://bugs.webkit.org/show_bug.cgi?id=149855
Patch by Skachkov Oleksandr <gskachkov@gmail.com> on 2016-01-10
Reviewed by Saam Barati.
JSArrowFunction.h/cpp were removed from JavaScriptCore, because now is used new approach for storing
'this', 'arguments' and 'super'
- CMakeLists.txt:
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters:
- JavaScriptCore.xcodeproj/project.pbxproj:
- dfg/DFGAbstractInterpreterInlines.h:
(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileNewFunction):
- dfg/DFGStructureRegistrationPhase.cpp:
(JSC::DFG::StructureRegistrationPhase::run):
- ftl/FTLAbstractHeapRepository.cpp:
- ftl/FTLAbstractHeapRepository.h:
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::DFG::LowerDFGToLLVM::compileNewFunction):
- interpreter/Interpreter.cpp:
- interpreter/Interpreter.h:
- jit/JITOpcodes.cpp:
- jit/JITOpcodes32_64.cpp:
- jit/JITOperations.cpp:
- jit/JITOperations.h:
- llint/LLIntOffsetsExtractor.cpp:
- llint/LLIntSlowPaths.cpp:
- runtime/JSArrowFunction.cpp: Removed.
- runtime/JSArrowFunction.h: Removed.
- runtime/JSGlobalObject.cpp:
- runtime/JSGlobalObject.h:
- 4:58 PM Changeset in webkit [194834] by
-
- 9 edits in trunk/Source
It should be possible to run liveness over registers without also tracking Tmps
https://bugs.webkit.org/show_bug.cgi?id=152963
Reviewed by Saam Barati.
Source/JavaScriptCore:
This adds a RegLivenessAdapter so that we can run Liveness over registers. This makes it
easier to write certain kinds of phases, like ReportUsedRegisters. I anticipate writing more
code like that for handling cold function calls. It also makes code like that somewhat more
scalable, since we're no longer using HashSets.
Currently, the way we track sets of registers is with a BitVector. Normally, we use the
RegisterSet class, which wraps BitVector, so that we can add()/contains() on Reg's. But in
the liveness analysis, everything gets turned into an index. So, we want to use BitVector
directly. To do that, I needed to make the BitVector API look a bit more like a set API. I
think that this is good, because the lack of set methods (add/remove/contains) has caused
bugs in the past. This makes BitVector have methods both for set operations on bits and array
operations on bits. I think that's good, since BitVector gets used in both contexts.
- b3/B3IndexSet.h:
(JSC::B3::IndexSet::Iterable::iterator::iterator):
(JSC::B3::IndexSet::Iterable::begin):
(JSC::B3::IndexSet::dump):
- b3/air/AirInstInlines.h:
(JSC::B3::Air::ForEach<Tmp>::forEach):
(JSC::B3::Air::ForEach<Arg>::forEach):
(JSC::B3::Air::ForEach<Reg>::forEach):
(JSC::B3::Air::Inst::forEach):
- b3/air/AirLiveness.h:
(JSC::B3::Air::RegLivenessAdapter::RegLivenessAdapter):
(JSC::B3::Air::RegLivenessAdapter::maxIndex):
(JSC::B3::Air::RegLivenessAdapter::acceptsType):
(JSC::B3::Air::RegLivenessAdapter::valueToIndex):
(JSC::B3::Air::RegLivenessAdapter::indexToValue):
- b3/air/AirReportUsedRegisters.cpp:
(JSC::B3::Air::reportUsedRegisters):
- jit/Reg.h:
(JSC::Reg::next):
(JSC::Reg::index):
(JSC::Reg::maxIndex):
(JSC::Reg::isSet):
(JSC::Reg::operator bool):
- jit/RegisterSet.h:
(JSC::RegisterSet::forEach):
Source/WTF:
Add set methods (add/contains/remove) to BitVector, since it gets used as a set in a lot of
places. This also makes BitVector a drop-in replacement for HashSet<unsigned> in a lot of
places.
Also made the iterator methods of BitVector live on BitVector directly rather than behind the
thing returned from setBits(). This makes sense since that makes BitVector even more of a
drop-in for HashSet. It's not harmful since we've never added any other mode of iterating a
BitVector other than this, so it doesn't make sense to make it harder to access.
- wtf/BitVector.h:
(WTF::BitVector::get):
(WTF::BitVector::contains):
(WTF::BitVector::set):
(WTF::BitVector::add):
(WTF::BitVector::ensureSizeAndSet):
(WTF::BitVector::clear):
(WTF::BitVector::remove):
(WTF::BitVector::hash):
(WTF::BitVector::iterator::iterator):
(WTF::BitVector::iterator::operator*):
(WTF::BitVector::iterator::operator++):
(WTF::BitVector::iterator::operator==):
(WTF::BitVector::iterator::operator!=):
(WTF::BitVector::begin):
(WTF::BitVector::end):
(WTF::BitVector::bitsInPointer):
(WTF::BitVector::SetBitsIterable::SetBitsIterable): Deleted.
(WTF::BitVector::SetBitsIterable::iterator::iterator): Deleted.
(WTF::BitVector::SetBitsIterable::iterator::operator*): Deleted.
(WTF::BitVector::SetBitsIterable::iterator::operator++): Deleted.
(WTF::BitVector::SetBitsIterable::iterator::operator==): Deleted.
(WTF::BitVector::SetBitsIterable::iterator::operator!=): Deleted.
(WTF::BitVector::SetBitsIterable::begin): Deleted.
(WTF::BitVector::SetBitsIterable::end): Deleted.
(WTF::BitVector::setBits): Deleted.
- 2:33 PM Changeset in webkit [194833] by
-
- 6 edits in trunk/Source/JavaScriptCore
[JSC] Make branchMul functional in ARM B3 and minor fixes
https://bugs.webkit.org/show_bug.cgi?id=152889
Patch by Benjamin Poulain <bpoulain@apple.com> on 2016-01-10
Reviewed by Mark Lam.
ARM64 does not have a "S" version of MUL setting the flags.
What we do is abstract that in the MacroAssembler. The problem
is that form requires scratch registers.
For simplicity, I just exposed the two scratch registers
for Air. Filip already added the concept of Scratch role,
all I needed was to expose it for opcodes.
- assembler/MacroAssemblerARM64.h:
(JSC::MacroAssemblerARM64::branchMul32):
(JSC::MacroAssemblerARM64::branchMul64):
Expose a version with the scratch registers as arguments.
- b3/B3LowerToAir.cpp:
(JSC::B3::Air::LowerToAir::lower):
Add the new form of CheckMul lowering.
- b3/air/AirOpcode.opcodes:
Expose the new BranchMuls.
Remove all the Test variants that use immediates
since Air can't handle those immediates correctly yet.
- b3/air/opcode_generator.rb:
Expose the Scratch role.
- b3/testb3.cpp:
(JSC::B3::testPatchpointLotsOfLateAnys):
Ooops, the scratch registers were not clobbered. We were just lucky
on x86.
- 1:56 PM Changeset in webkit [194832] by
-
- 2 edits in trunk/Tools
[webkitdirs] Try arch and uname commands on non-windows OS
https://bugs.webkit.org/show_bug.cgi?id=152958
Patch by Konstantin Tokarev <Konstantin Tokarev> on 2016-01-10
Reviewed by Michael Catanzaro.
Right now, determineArchitecture() uses
archanduname -m
commands to determine architecture in case of condition (isGtk() isAppleMacWebKit() isEfl()) is true. This should be !anyWindows() instead, because this code is applicable to any non-windows OS WebKit
supports (even Haiku which once was supported is moderately
POSIX-compliant and has uname command).
- Scripts/webkitdirs.pm:
(determineArchitecture):
- 1:42 PM Changeset in webkit [194831] by
-
- 2 edits in trunk/Source/JavaScriptCore
[JSC] B3 is unable to do function calls on ARM64
https://bugs.webkit.org/show_bug.cgi?id=152895
Patch by Benjamin Poulain <bpoulain@apple.com> on 2016-01-10
Reviewed by Mark Lam.
Apparently iOS does not follow the ARM64 ABI for function calls.
Instead of giving each value a 8 bytes slot, it must be packed
while preserving alignment.
This patch adds a #ifdef to make function calls functional.
- b3/B3LowerToAir.cpp:
(JSC::B3::Air::LowerToAir::marshallCCallArgument):
(JSC::B3::Air::LowerToAir::lower):
- 12:28 PM Changeset in webkit [194830] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Uncaught Exception selecting IndexedDB host folder in Storage tab
https://bugs.webkit.org/show_bug.cgi?id=152943
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-01-10
Reviewed by Brian Burg.
- UserInterface/Views/NavigationSidebarPanel.js:
(WebInspector.NavigationSidebarPanel.prototype._isTreeElementWithoutRepresentedObject):
Another type of specialized folder tree element.
- 12:25 PM Changeset in webkit [194829] by
-
- 2 edits in trunk/Source/WebInspectorUI
Uncaught Exception: TypeError: undefined is not an object (evaluating 'this._scopeChain[i].object.deprecatedGetAllProperties')
https://bugs.webkit.org/show_bug.cgi?id=152944
<rdar://problem/24119827>
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-01-10
Reviewed by Brian Burg.
- UserInterface/Models/CallFrame.js:
(WebInspector.CallFrame.prototype.collectScopeChainVariableNames):
Missed one place whereobjectneeded to change toobjects.
Here the list will always contain a single object, only UI
generated scopes for the sidebar may have multiple objects.
- 12:24 PM Changeset in webkit [194828] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Dashboard log message count doesn't include console.time messages
https://bugs.webkit.org/show_bug.cgi?id=151280
Patch by Johan K. Jensen <jj@johanjensen.dk> on 2016-01-10
Reviewed by Brian Burg.
- UserInterface/Models/DefaultDashboard.js:
(WebInspector.DefaultDashboard.prototype._incrementConsoleMessageType):
Make Info and Debug levels increment the log count.
- 10:51 AM Changeset in webkit [194827] by
-
- 2 edits in trunk/Source/WebKit2
[Cocoa] Disable header postprocessing when building for El Capitan
https://bugs.webkit.org/show_bug.cgi?id=152962
Reviewed by Anders Carlsson.
- Configurations/WebKit.xcconfig:
- 5:27 AM Changeset in webkit [194826] by
-
- 21 edits in trunk/Source
Use NeverDestroyed instead of DEPRECATED_DEFINE_STATIC_LOCAL cont'd
<https://webkit.org/b/152902>
Reviewed by Andy Estes.
Source/WebCore:
Convert some more of the remaining clients to use NeverDestroyed.
- html/track/VTTRegion.cpp:
(WebCore::VTTRegion::textTrackCueContainerShadowPseudoId):
(WebCore::VTTRegion::textTrackRegionShadowPseudoId):
- svg/properties/SVGAnimatedPropertyMacros.h:
Source/WebKit:
- Storage/StorageThread.cpp:
(WebCore::activeStorageThreads):
Source/WebKit/ios:
- WebCoreSupport/WebFixedPositionContent.mm:
(WebFixedPositionContentDataLock):
Source/WebKit/mac:
Convert some more of the remaining clients to use NeverDestroyed.
- History/WebBackForwardList.mm:
(backForwardLists):
- History/WebHistoryItem.mm:
(historyItemWrappers):
- Misc/WebNSPasteboardExtras.mm:
(+[NSPasteboard _web_writableTypesForURL]):
(_writableTypesForImageWithoutArchive):
(_writableTypesForImageWithArchive):
- Plugins/Hosted/NetscapePluginHostManager.mm:
(WebKit::NetscapePluginHostManager::singleton):
- Plugins/Hosted/NetscapePluginHostProxy.mm:
(WebKit::pluginProxyMap):
- Plugins/Hosted/NetscapePluginInstanceProxy.mm:
(WebKit::globalExceptionString):
- Plugins/Hosted/ProxyInstance.mm:
(WebKit::proxyClass):
- Plugins/WebNetscapePluginStream.mm:
(streams):
- Storage/WebDatabaseManager.mm:
(transactionBackgroundTaskIdentifierLock):
- WebCoreSupport/WebUserMediaClient.mm:
(userMediaCheckMap):
- WebView/WebHTMLRepresentation.mm:
(regExpForLabels):
- WebView/WebView.mm:
(aeDescFromJSValue):
Jan 9, 2016:
- 10:39 PM Changeset in webkit [194825] by
-
- 13 edits in trunk/Source/WebCore
Hook up display-list drawing in GraphicsLayerCA
https://bugs.webkit.org/show_bug.cgi?id=152946
Reviewed by Zalan Bujtas.
Have GraphicsLayerCA hold a DisplayList. If enabled, do a display-list record
in GraphicsLayerCA::recursiveCommitChanges(), and a playback in GraphicsLayerCA::platformCALayerPaintContents().
GraphicsLayerCA needs to maintain a m_hasEverPainted flag to know to do a full record
at first paint (when there are no dirty rects).
Plumb 'isUsingDisplayListDrawing' through to TileGrid via PlatformCALayer{Client}
so that we can decorate the tile paint counters with an outline.
Have RenderLayerCompositor push the displayListDrawingEnabled state down through
RenderLayerBackings to GraphicsLayers.
Convert RenderLayerCompositor to use initializers.
- platform/graphics/GraphicsLayer.cpp:
(WebCore::GraphicsLayer::GraphicsLayer):
- platform/graphics/GraphicsLayer.h:
(WebCore::GraphicsLayer::usesDisplayListDrawing):
(WebCore::GraphicsLayer::setUsesDisplayListDrawing):
- platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::GraphicsLayerCA):
(WebCore::GraphicsLayerCA::setUsesDisplayListDrawing):
(WebCore::GraphicsLayerCA::recursiveCommitChanges):
(WebCore::GraphicsLayerCA::platformCALayerPaintContents):
(WebCore::GraphicsLayerCA::updateDrawsContent):
(WebCore::GraphicsLayerCA::dumpAdditionalProperties):
- platform/graphics/ca/GraphicsLayerCA.h:
- platform/graphics/ca/PlatformCALayer.cpp:
(WebCore::PlatformCALayer::drawRepaintIndicator):
- platform/graphics/ca/PlatformCALayerClient.h:
(WebCore::PlatformCALayerClient::isUsingDisplayListDrawing):
- platform/graphics/ca/TileGrid.cpp:
(WebCore::TileGrid::platformCALayerShowRepaintCounter):
(WebCore::TileGrid::isUsingDisplayListDrawing):
- platform/graphics/ca/TileGrid.h:
- platform/graphics/displaylists/DisplayList.h: Sadly need to include DisplayListItems.h
to get things to compile. I wasn't able to avoid this even when making functions non-inline.
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::createGraphicsLayer):
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::RenderLayerCompositor):
(WebCore::RenderLayerCompositor::cacheAcceleratedCompositingFlags):
- rendering/RenderLayerCompositor.h:
- 8:15 PM Changeset in webkit [194824] by
-
- 4 edits in trunk/Source/JavaScriptCore
Air should support Branch64 with immediates
https://bugs.webkit.org/show_bug.cgi?id=152951
Reviewed by Oliver Hunt.
This doesn't significantly improve performance on any benchmarks, but it's great to get this
obvious omission out of the way.
- assembler/MacroAssemblerX86_64.h:
(JSC::MacroAssemblerX86_64::branch64):
- b3/air/AirOpcode.opcodes:
- b3/testb3.cpp:
(JSC::B3::testPowDoubleByIntegerLoop):
(JSC::B3::testBranch64Equal):
(JSC::B3::testBranch64EqualImm):
(JSC::B3::testBranch64EqualMem):
(JSC::B3::testBranch64EqualMemImm):
(JSC::B3::zero):
(JSC::B3::run):
- 4:38 PM Changeset in webkit [194823] by
-
- 3 edits2 adds in trunk
REGRESSION (r194426): First email field is not autofilled on amazon.com
https://bugs.webkit.org/show_bug.cgi?id=152945
<rdar://problem/24082914>
Reviewed by Simon Fraser.
r194426 missed marking the m_layoutRoot for layout while converting to full layout (it only marked the new layout root).
Source/WebCore:
Test: fast/forms/multiple-subtree-layout-failure.html
- page/FrameView.cpp:
(WebCore::FrameView::scheduleRelayoutOfSubtree):
LayoutTests:
- fast/forms/multiple-subtree-layout-failure-expected.html: Added.
- fast/forms/multiple-subtree-layout-failure.html: Added.
- 3:29 PM Changeset in webkit [194822] by
-
- 2 edits in trunk/Source/WebCore/platform/gtk/po
[l10n] Updated Turkish translation of WebKitGTK+
https://bugs.webkit.org/show_bug.cgi?id=152948
"Reviewed" by Michael Catanzaro.
Patch by Muhammet Kara <muhammetk@gmail.com> on 2016-01-09
- tr.po:
- 12:13 PM Changeset in webkit [194821] by
-
- 23 edits in trunk/Source
[Cocoa] Allow overriding the frameworks directory independently of using a staging install path
https://bugs.webkit.org/show_bug.cgi?id=152926
Reviewed by Tim Horton.
Introduce a new build setting, WK_OVERRIDE_FRAMEWORKS_DIR. When not empty, it determines
where the frameworks are installed. Setting USE_STAGING_INSTALL_PATH to YES sets
WK_OVERRIDE_FRAMEWORKS_DIR to $(SYSTEM_LIBRARY_DIR)/StagedFrameworks/Safari.
Account for the possibility of WK_OVERRIDE_FRAMEWORKS_DIR containing spaces.
Source/JavaScriptCore:
- Configurations/Base.xcconfig:
- Replace STAGED_FRAMEWORKS_SEARCH_PATH in FRAMEWORK_SEARCH_PATHS with WK_OVERRIDE_FRAMEWORKS_DIR and add quotes to account for spaces.
- Define JAVASCRIPTCORE_FRAMEWORKS_DIR based on WK_OVERRIDE_FRAMEWORKS_DIR.
- Configurations/JSC.xcconfig: Add quotes to account for spaces.
- Configurations/ToolExecutable.xcconfig: Ditto.
- postprocess-headers.sh: Ditto.
Source/ThirdParty:
- gtest/xcode/Config/General.xcconfig: Add quotes to account for spaces.
- gtest/xcode/Config/ProductionProject.xcconfig:
- Replace STAGED_FRAMEWORKS_SEARCH_PATH in FRAMEWORK_SEARCH_PATHS with WK_OVERRIDE_FRAMEWORKS_DIR and add quotes to account for spaces.
- Define WEBCORE_FRAMEWORKS_DIR based on WK_OVERRIDE_FRAMEWORKS_DIR.
Source/WebCore:
- Configurations/WebCore.xcconfig:
- Replace STAGED_FRAMEWORKS_SEARCH_PATH in FRAMEWORK_SEARCH_PATHS with WK_OVERRIDE_FRAMEWORKS_DIR and add quotes to account for spaces.
- Define WEBCORE_FRAMEWORKS_DIR and PRODUCTION_FRAMEWORKS_DIR based on WK_OVERRIDE_FRAMEWORKS_DIR.
- WebCore.xcodeproj/project.pbxproj: Work around make’s inability to handle spaces in paths by creating a symlink to JAVASCRIPTCORE_PRIVATE_HEADERS_DIR under BUILT_PRODUCTS_DIR and using the symlink as the value of JavaScriptCore_SCRIPTS_DIR.
Source/WebInspectorUI:
- Configurations/Base.xcconfig:
- Replace STAGED_FRAMEWORKS_SEARCH_PATH in FRAMEWORK_SEARCH_PATHS with WK_OVERRIDE_FRAMEWORKS_DIR and add quotes to account for spaces.
- Configurations/WebInspectorUIFramework.xcconfig:
- Define INSTALL_PATH and PRODUCTION_FRAMEWORKS_DIR based on WK_OVERRIDE_FRAMEWORKS_DIR.
Source/WebKit/mac:
- Configurations/WebKitLegacy.xcconfig:
- Replace STAGED_FRAMEWORKS_SEARCH_PATH in FRAMEWORK_SEARCH_PATHS with WK_OVERRIDE_FRAMEWORKS_DIR and add quotes to account for spaces.
- Define WEBKIT_LEGACY_FRAMEWORKS_DIR, PRODUCTION_FRAMEWORKS_DIR, and WEBCORE_PRIVATE_HEADERS_DIR based on WK_OVERRIDE_FRAMEWORKS_DIR.
- MigrateHeaders.make: Use a symlink under BUILT_PRODUCTS_DIR to the WebCore Private Headers. Use a BUILT_PRODUCTS_DIR-based path to the framework instead of a TARGET_BUILD_DIR-based one in order to avoid spaces.
- migrate-headers.sh: Make the symlink to WEBCORE_PRIVATE_HEADERS_DIR that the makefile now uses.
Source/WebKit2:
- Configurations/BaseTarget.xcconfig:
- Add quotes to account for spaces.
- Define WEBKIT_FRAMEWORKS_DIR and UMBRELLA_FRAMEWORKS_DIR based on WK_OVERRIDE_FRAMEWORKS_DIR.
- WebKit2.xcodeproj/project.pbxproj:
- In the Migrate WebKitLegacy Headers build phase, work around make’s inability to handle spaces in paths by creating a symlink to WEBKIT_LEGACY_PRIVATE_HEADERS_DIR under BUILT_PRODUCTS_DIR and using the symlink as the value of WEBKIT_LEGACY_PRIVATE_HEADERS_DIR.
- In the Postprocess WKBase.h and Postprocess WKFoundation.h build phases, add quotes to account for spaces.
- mac/MigrateHeadersFromWebKitLegacy.make: Use a BUILT_PRODUCTS_DIR-based path to the framework instead of a TARGET_BUILD_DIR-based one in order to avoid spaces.
- mac/postprocess-framework-headers.sh: Add quotes to account for spaces.
- 7:23 AM Changeset in webkit [194820] by
-
- 5 edits in trunk/Source/JavaScriptCore
The FTL allocated spill slots for BinaryOps is sometimes inaccurate.
https://bugs.webkit.org/show_bug.cgi?id=152918
Reviewed by Filip Pizlo and Saam Barati.
- ftl/FTLCompile.cpp:
- Updated a comment.
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::DFG::LowerDFGToLLVM::lower):
- The code to compute maxNumberOfCatchSpills was unnecessarily allocating an extra slot for BinaryOps that don't have Untyped operands, and failing to allocate that extra slot for some binary ops. This is now fixed.
- tests/stress/ftl-shr-exception.js:
- tests/stress/ftl-xor-exception.js:
- Un-skipped these tests. They now pass with this patch.
- 5:13 AM Changeset in webkit [194819] by
-
- 176 edits in trunk/Source
Use NeverDestroyed instead of DEPRECATED_DEFINE_STATIC_LOCAL
<https://webkit.org/b/152902>
Reviewed by Anders Carlsson.
Source/JavaScriptCore:
Mostly mechanical conversion to NeverDestroyed throughout JavaScriptCore.
- API/JSAPIWrapperObject.mm:
(jsAPIWrapperObjectHandleOwner):
- API/JSManagedValue.mm:
(managedValueHandleOwner):
- inspector/agents/InspectorDebuggerAgent.cpp:
(Inspector::objectGroupForBreakpointAction):
- jit/ExecutableAllocator.cpp:
(JSC::DemandExecutableAllocator::allocators):
Source/WebCore:
Mostly mechanical conversion to NeverDestroyed throughout WebCore.
- Modules/airplay/WebKitPlaybackTargetAvailabilityEvent.cpp:
(WebCore::stringForPlaybackTargetAvailability):
- Modules/indexeddb/IDBCursor.cpp:
(WebCore::IDBCursor::directionNext):
(WebCore::IDBCursor::directionNextUnique):
(WebCore::IDBCursor::directionPrev):
(WebCore::IDBCursor::directionPrevUnique):
- Modules/indexeddb/IDBTransaction.cpp:
(WebCore::IDBTransaction::modeReadOnly):
(WebCore::IDBTransaction::modeReadWrite):
(WebCore::IDBTransaction::modeVersionChange):
(WebCore::IDBTransaction::modeReadOnlyLegacy):
(WebCore::IDBTransaction::modeReadWriteLegacy):
- Modules/indexeddb/legacy/LegacyRequest.cpp:
(WebCore::LegacyRequest::readyState):
- Modules/mediacontrols/MediaControlsHost.cpp:
(WebCore::MediaControlsHost::automaticKeyword):
(WebCore::MediaControlsHost::forcedOnlyKeyword):
(WebCore::MediaControlsHost::alwaysOnKeyword):
(WebCore::MediaControlsHost::externalDeviceType):
- Modules/mediasource/MediaSource.cpp:
(WebCore::MediaSource::openKeyword):
(WebCore::MediaSource::closedKeyword):
(WebCore::MediaSource::endedKeyword):
(WebCore::MediaSource::streamEndedWithError):
- Modules/plugins/QuickTimePluginReplacement.mm:
(WebCore::quickTimePluginReplacementScript):
(WebCore::QuickTimePluginReplacement::supportsMimeType):
(WebCore::QuickTimePluginReplacement::supportsFileExtension):
- Modules/speech/SpeechSynthesis.cpp:
(WebCore::SpeechSynthesis::boundaryEventOccurred):
- bindings/js/JSCSSStyleDeclarationCustom.cpp:
(WebCore::cssPropertyIDForJSCSSPropertyName):
- bridge/c/c_instance.cpp:
(JSC::Bindings::globalExceptionString):
- css/MediaList.cpp:
(WebCore::addResolutionWarningMessageToConsole):
- css/StyleSheetContents.cpp:
(WebCore::StyleSheetContents::parseAuthorStyleSheet):
- dom/ChildListMutationScope.cpp:
(WebCore::accumulatorMap):
- dom/DOMImplementation.cpp:
(WebCore::isSupportedSVG10Feature):
(WebCore::isSupportedSVG11Feature):
- dom/Document.cpp:
(WebCore::Document::readyState):
- dom/Element.cpp:
(WebCore::Element::webkitRegionOverset):
- dom/EventDispatcher.cpp:
(WebCore::EventDispatcher::dispatchSimulatedClick):
- dom/InlineStyleSheetOwner.cpp:
(WebCore::isValidCSSContentType):
- dom/MutationObserver.cpp:
(WebCore::activeMutationObservers):
(WebCore::suspendedMutationObservers):
- dom/MutationRecord.cpp:
- dom/PseudoElement.cpp:
(WebCore::pseudoElementTagName):
(WebCore::PseudoElement::pseudoElementNameForEvents):
- dom/QualifiedName.cpp:
(WebCore::qualifiedNameCache):
(WebCore::nullQName):
- dom/ScriptElement.cpp:
(WebCore::isLegacySupportedJavaScriptLanguage):
(WebCore::ScriptElement::notifyFinished):
- editing/ApplyStyleCommand.cpp:
(WebCore::styleSpanClassString):
- editing/MarkupAccumulator.cpp:
(WebCore::MarkupAccumulator::shouldAddNamespaceElement):
- editing/ReplaceSelectionCommand.cpp:
(WebCore::isInterchangeNewlineNode):
(WebCore::isInterchangeConvertedSpaceSpan):
- editing/htmlediting.cpp:
(WebCore::nonBreakingSpaceString):
- editing/markup.cpp:
(WebCore::StyledMarkupAccumulator::styleNodeCloseTag):
(WebCore::createMarkupInternal):
- fileapi/Blob.cpp:
(WebCore::BlobURLRegistry::registry):
- html/BaseChooserOnlyDateAndTimeInputType.cpp:
(WebCore::BaseChooserOnlyDateAndTimeInputType::createShadowSubtree):
- html/DateInputType.cpp:
(WebCore::DateInputType::createStepRange):
- html/DateTimeInputType.cpp:
(WebCore::DateTimeInputType::createStepRange):
- html/DateTimeLocalInputType.cpp:
(WebCore::DateTimeLocalInputType::createStepRange):
- html/EmailInputType.cpp:
(WebCore::isValidEmailAddress):
- html/FormController.cpp:
(WebCore::FormKeyGenerator::formKey):
(WebCore::formStateSignature):
- html/HTMLAnchorElement.cpp:
(WebCore::rootEditableElementMap):
- html/HTMLButtonElement.cpp:
(WebCore::HTMLButtonElement::formControlType):
- html/HTMLFieldSetElement.cpp:
(WebCore::HTMLFieldSetElement::formControlType):
- html/HTMLFrameOwnerElement.h:
(WebCore::SubframeLoadingDisabler::disabledSubtreeRoots):
- html/HTMLKeygenElement.cpp:
(WebCore::HTMLKeygenElement::formControlType):
- html/HTMLLinkElement.cpp:
(WebCore::linkLoadEventSender):
- html/HTMLMediaElement.cpp:
(WebCore::documentToElementSetMap):
- html/HTMLObjectElement.cpp:
(WebCore::isRecognizedTagName):
- html/HTMLOptGroupElement.cpp:
(WebCore::HTMLOptGroupElement::formControlType):
- html/HTMLOutputElement.cpp:
(WebCore::HTMLOutputElement::formControlType):
- html/HTMLPlugInElement.cpp:
(WebCore::registeredPluginReplacements):
- html/HTMLPlugInImageElement.cpp:
(WebCore::titleText):
(WebCore::subtitleText):
(WebCore::HTMLPlugInImageElement::partOfSnapshotOverlay):
- html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::formControlType):
- html/HTMLStyleElement.cpp:
(WebCore::styleLoadEventSender):
- html/HTMLTextAreaElement.cpp:
(WebCore::HTMLTextAreaElement::formControlType):
- html/HTMLTextFormControlElement.cpp:
(WebCore::directionString):
- html/ImageInputType.cpp:
(WebCore::ImageInputType::appendFormData):
- html/InputTypeNames.cpp:
(WebCore::InputTypeNames::button):
(WebCore::InputTypeNames::checkbox):
(WebCore::InputTypeNames::color):
(WebCore::InputTypeNames::date):
(WebCore::InputTypeNames::datetime):
(WebCore::InputTypeNames::datetimelocal):
(WebCore::InputTypeNames::email):
(WebCore::InputTypeNames::file):
(WebCore::InputTypeNames::hidden):
(WebCore::InputTypeNames::image):
(WebCore::InputTypeNames::month):
(WebCore::InputTypeNames::number):
(WebCore::InputTypeNames::password):
(WebCore::InputTypeNames::radio):
(WebCore::InputTypeNames::range):
(WebCore::InputTypeNames::reset):
(WebCore::InputTypeNames::search):
(WebCore::InputTypeNames::submit):
(WebCore::InputTypeNames::telephone):
(WebCore::InputTypeNames::text):
(WebCore::InputTypeNames::time):
(WebCore::InputTypeNames::url):
(WebCore::InputTypeNames::week):
- html/MediaController.cpp:
(playbackStateWaiting):
(playbackStatePlaying):
(playbackStateEnded):
- html/MonthInputType.cpp:
(WebCore::MonthInputType::createStepRange):
- html/NumberInputType.cpp:
(WebCore::NumberInputType::createStepRange):
- html/RangeInputType.cpp:
(WebCore::RangeInputType::createStepRange):
- html/StepRange.cpp:
(WebCore::StepRange::acceptableError):
(WebCore::StepRange::alignValueForStep):
(WebCore::StepRange::stepMismatch):
- html/TimeInputType.cpp:
(WebCore::TimeInputType::createStepRange):
- html/WeekInputType.cpp:
(WebCore::WeekInputType::createStepRange):
- html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::getImageData):
- html/parser/XSSAuditor.cpp:
(WebCore::XSSAuditor::init):
(WebCore::XSSAuditor::eraseDangerousAttributesIfInjected):
- html/shadow/MediaControlElements.cpp:
(WebCore::MediaControlClosedCaptionsTrackListElement::updateDisplay):
(WebCore::getMediaControlTimeRemainingDisplayElementShadowPseudoId):
(WebCore::getMediaControlCurrentTimeDisplayElementShadowPseudoId):
- html/shadow/MeterShadowElement.cpp:
(WebCore::MeterInnerElement::MeterInnerElement):
(WebCore::MeterValueElement::valuePseudoId):
- html/shadow/MeterShadowElement.h:
- html/shadow/SliderThumbElement.cpp:
(WebCore::sliderThumbShadowPseudoId):
(WebCore::mediaSliderThumbShadowPseudoId):
(WebCore::SliderContainerElement::shadowPseudoId):
- html/track/AudioTrack.cpp:
(WebCore::AudioTrack::alternativeKeyword):
(WebCore::AudioTrack::descriptionKeyword):
(WebCore::AudioTrack::mainKeyword):
(WebCore::AudioTrack::mainDescKeyword):
(WebCore::AudioTrack::translationKeyword):
(WebCore::AudioTrack::commentaryKeyword):
- html/track/TextTrack.cpp:
(WebCore::TextTrack::subtitlesKeyword):
(WebCore::TextTrack::captionsKeyword):
(WebCore::TextTrack::descriptionsKeyword):
(WebCore::TextTrack::chaptersKeyword):
(WebCore::TextTrack::metadataKeyword):
(WebCore::TextTrack::forcedKeyword):
(WebCore::TextTrack::disabledKeyword):
(WebCore::TextTrack::hiddenKeyword):
(WebCore::TextTrack::showingKeyword):
- html/track/TextTrackCue.h:
(WebCore::TextTrackCue::cueShadowPseudoId):
- html/track/VTTCue.cpp:
(WebCore::startKeyword):
(WebCore::middleKeyword):
(WebCore::endKeyword):
(WebCore::leftKeyword):
(WebCore::rightKeyword):
(WebCore::verticalGrowingLeftKeyword):
(WebCore::verticalGrowingRightKeyword):
(WebCore::VTTCueBox::vttCueBoxShadowPseudoId):
(WebCore::VTTCue::cueBackdropShadowPseudoId):
(WebCore::VTTCue::determineTextDirection):
(WebCore::VTTCue::markFutureAndPastNodes):
- html/track/VTTRegion.cpp:
(WebCore::VTTRegion::scroll):
(WebCore::VTTRegion::setScroll):
(WebCore::VTTRegion::parseSettingValue):
(WebCore::VTTRegion::textTrackCueContainerScrollingClass):
- html/track/VideoTrack.cpp:
(WebCore::VideoTrack::alternativeKeyword):
(WebCore::VideoTrack::captionsKeyword):
(WebCore::VideoTrack::mainKeyword):
(WebCore::VideoTrack::signKeyword):
(WebCore::VideoTrack::subtitlesKeyword):
(WebCore::VideoTrack::commentaryKeyword):
- html/track/WebVTTElement.cpp:
(WebCore::nodeTypeToTagName):
- html/track/WebVTTElement.h:
- html/track/WebVTTParser.cpp:
(WebCore::WebVTTParser::collectMetadataHeader):
- inspector/InspectorCSSAgent.cpp:
(WebCore::computePseudoClassMask):
- inspector/InspectorPageAgent.cpp:
(WebCore::InspectorPageAgent::sourceMapURLForResource):
- inspector/InspectorStyleSheet.cpp:
(WebCore::selectorsFromSource):
- inspector/PageDebuggerAgent.cpp:
(WebCore::PageDebuggerAgent::sourceMapURLForScript):
- loader/ImageLoader.cpp:
(WebCore::ImageLoader::notifyFinished):
- loader/TextTrackLoader.cpp:
(WebCore::TextTrackLoader::corsPolicyPreventedLoad):
- loader/cache/CachedResourceRequest.cpp:
(WebCore::CachedResourceRequest::initiatorName):
- loader/icon/IconDatabase.cpp:
(WebCore::IconDatabase::defaultDatabaseFilename):
- page/CaptionUserPreferences.cpp:
(WebCore::CaptionUserPreferences::updateCaptionStyleSheetOveride):
- page/CaptionUserPreferencesMediaAF.cpp:
(WebCore::CaptionUserPreferencesMediaAF::captionsBackgroundCSS):
(WebCore::CaptionUserPreferencesMediaAF::captionsTextEdgeCSS):
- page/ContentSecurityPolicy.cpp:
(WebCore::CSPDirectiveList::allowJavaScriptURLs):
(WebCore::CSPDirectiveList::allowInlineEventHandlers):
(WebCore::CSPDirectiveList::allowInlineScript):
(WebCore::CSPDirectiveList::allowInlineStyle):
(WebCore::CSPDirectiveList::allowEval):
(WebCore::ContentSecurityPolicy::reportUnsupportedDirective):
- page/DOMWindow.cpp:
(WebCore::windowsWithUnloadEventListeners):
(WebCore::windowsWithBeforeUnloadEventListeners):
- page/EventHandler.cpp:
(WebCore::EventHandler::dragState):
(WebCore::focusDirectionForKey):
- page/Frame.cpp:
(WebCore::createRegExpForLabels):
- page/NavigatorBase.cpp:
(WebCore::NavigatorBase::platform):
- page/PageVisibilityState.cpp:
(WebCore::pageVisibilityStateString):
- page/SecurityPolicy.cpp:
(WebCore::originAccessMap):
- page/UserContentURLPattern.cpp:
(WebCore::UserContentURLPattern::parse):
- page/animation/CSSPropertyAnimation.cpp:
(WebCore::shadowForBlending):
- page/animation/CompositeAnimation.cpp:
(WebCore::CompositeAnimation::updateKeyframeAnimations):
- platform/Cursor.cpp:
(WebCore::pointerCursor):
(WebCore::crossCursor):
(WebCore::handCursor):
(WebCore::moveCursor):
(WebCore::verticalTextCursor):
(WebCore::cellCursor):
(WebCore::contextMenuCursor):
(WebCore::aliasCursor):
(WebCore::zoomInCursor):
(WebCore::zoomOutCursor):
(WebCore::copyCursor):
(WebCore::noneCursor):
(WebCore::progressCursor):
(WebCore::noDropCursor):
(WebCore::notAllowedCursor):
(WebCore::iBeamCursor):
(WebCore::waitCursor):
(WebCore::helpCursor):
(WebCore::eastResizeCursor):
(WebCore::northResizeCursor):
(WebCore::northEastResizeCursor):
(WebCore::northWestResizeCursor):
(WebCore::southResizeCursor):
(WebCore::southEastResizeCursor):
(WebCore::southWestResizeCursor):
(WebCore::westResizeCursor):
(WebCore::northSouthResizeCursor):
(WebCore::eastWestResizeCursor):
(WebCore::northEastSouthWestResizeCursor):
(WebCore::northWestSouthEastResizeCursor):
(WebCore::columnResizeCursor):
(WebCore::rowResizeCursor):
(WebCore::middlePanningCursor):
(WebCore::eastPanningCursor):
(WebCore::northPanningCursor):
(WebCore::northEastPanningCursor):
(WebCore::northWestPanningCursor):
(WebCore::southPanningCursor):
(WebCore::southEastPanningCursor):
(WebCore::southWestPanningCursor):
(WebCore::westPanningCursor):
(WebCore::grabCursor):
(WebCore::grabbingCursor):
- platform/Language.cpp:
(WebCore::preferredLanguagesOverride):
- platform/LocalizedStrings.cpp:
(WebCore::truncatedStringForLookupMenuItem):
- platform/MIMETypeRegistry.cpp:
(WebCore::mediaMIMETypeMap):
(WebCore::defaultMIMEType):
- platform/SchemeRegistry.cpp:
(WebCore::localURLSchemes):
(WebCore::displayIsolatedURLSchemes):
(WebCore::secureSchemes):
(WebCore::schemesWithUniqueOrigins):
(WebCore::emptyDocumentSchemes):
(WebCore::schemesForbiddenFromDomainRelaxation):
(WebCore::canDisplayOnlyIfCanRequestSchemes):
(WebCore::notAllowingJavascriptURLsSchemes):
(WebCore::schemesAllowingLocalStorageAccessInPrivateBrowsing):
(WebCore::schemesAllowingDatabaseAccessInPrivateBrowsing):
(WebCore::CORSEnabledSchemes):
(WebCore::ContentSecurityPolicyBypassingSchemes):
- platform/ScrollbarTheme.cpp:
(WebCore::ScrollbarTheme::theme):
- platform/URL.cpp:
(WebCore::blankURL):
- platform/animation/Animation.cpp:
(WebCore::Animation::initialName):
- platform/audio/AudioSession.cpp:
(WebCore::AudioSession::sharedSession):
- platform/audio/AudioSession.h:
- platform/audio/HRTFElevation.cpp:
(WebCore::getConcatenatedImpulseResponsesForSubject):
- platform/audio/ios/AudioDestinationIOS.cpp:
(WebCore::audioDestinations):
- platform/graphics/GraphicsLayer.cpp:
(WebCore::repaintRectMap):
- platform/graphics/ImageBuffer.cpp:
(WebCore::ImageBuffer::transformColorSpace):
- platform/graphics/MediaPlayer.cpp:
(WebCore::applicationOctetStream):
(WebCore::textPlain):
(WebCore::codecs):
- platform/graphics/ShadowBlur.cpp:
(WebCore::ScratchBuffer::singleton):
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::playerToPrivateMap):
- platform/graphics/filters/SourceAlpha.cpp:
(WebCore::SourceAlpha::effectName):
- platform/graphics/filters/SourceGraphic.cpp:
(WebCore::SourceGraphic::effectName):
- platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
(WebCore::mimeCommonTypesCache):
(WebCore::mimeModernTypesCache):
- platform/ios/CursorIOS.cpp:
(WebCore::cursor):
- platform/ios/TileControllerMemoryHandlerIOS.cpp:
(WebCore::tileControllerMemoryHandler):
- platform/ios/WebCoreMotionManager.mm:
(+[WebCoreMotionManager sharedManager]):
- platform/ios/WebVideoFullscreenModelVideoElement.mm:
(WebVideoFullscreenModelVideoElement::updateForEventName):
- platform/ios/wak/WKContentObservation.cpp:
(WebThreadGetObservedContentModifiers):
- platform/mac/DragImageMac.mm:
(WebCore::fontFromNSFont):
- platform/mac/ThemeMac.mm:
(WebCore::platformTheme):
- platform/mac/ThreadCheck.mm:
(WebCoreReportThreadViolation):
- platform/mediastream/mac/AVCaptureDeviceManager.h:
- platform/mediastream/mac/AVCaptureDeviceManager.mm:
(WebCore::AVCaptureDeviceManager::singleton):
- platform/mediastream/mac/RealtimeMediaSourceCenterMac.cpp:
(WebCore::RealtimeMediaSourceCenter::platformCenter):
- platform/mock/mediasource/MockBox.cpp:
(WebCore::MockTrackBox::type):
(WebCore::MockInitializationBox::type):
(WebCore::MockSampleBox::type):
- platform/network/HTTPParsers.cpp:
(WebCore::parseXSSProtectionHeader):
- platform/network/ResourceHandle.cpp:
(WebCore::builtinResourceHandleConstructorMap):
(WebCore::builtinResourceHandleSynchronousLoaderMap):
- platform/network/cf/ResourceHandleCFNet.cpp:
(WebCore::allowsAnyHTTPSCertificateHosts):
(WebCore::clientCerts):
- platform/text/AtomicStringKeyedMRUCache.h:
(WebCore::AtomicStringKeyedMRUCache::get):
- platform/text/cf/HyphenationCF.cpp:
(WebCore::cfLocaleCache):
- rendering/RenderBlock.cpp:
(WebCore::continuationOutlineTable):
- rendering/RenderCounter.cpp:
(WebCore::counterMaps):
- rendering/RenderDeprecatedFlexibleBox.cpp:
(WebCore::RenderDeprecatedFlexibleBox::applyLineClamp):
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::drawPlatformResizerImage):
- rendering/RenderScrollbarTheme.cpp:
(WebCore::RenderScrollbarTheme::renderScrollbarTheme):
- rendering/RenderTheme.cpp:
(WebCore::customFocusRingColor):
- rendering/RenderWidget.cpp:
(WebCore::WidgetHierarchyUpdatesSuspensionScope::widgetNewParentMap):
- rendering/shapes/ShapeOutsideInfo.h:
- rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::hyphenString):
(WebCore::RenderStyle::textEmphasisMarkString):
(WebCore::RenderStyle::initialDashboardRegions):
(WebCore::RenderStyle::noneDashboardRegions):
- rendering/style/RenderStyle.h:
- rendering/svg/RenderSVGPath.cpp:
(WebCore::RenderSVGPath::zeroLengthLinecapPath):
- rendering/svg/RenderSVGShape.cpp:
(WebCore::RenderSVGShape::nonScalingStrokePath):
- rendering/svg/SVGRenderingContext.cpp:
(WebCore::currentContentTransformation):
- rendering/svg/SVGResources.cpp:
(WebCore::clipperFilterMaskerTags):
(WebCore::markerTags):
(WebCore::fillAndStrokeTags):
(WebCore::chainableResourceTags):
- svg/SVGAngle.cpp:
(WebCore::SVGAngle::valueAsString):
- svg/SVGAnimateColorElement.cpp:
(WebCore::attributeValueIsCurrentColor):
- svg/SVGAnimateMotionElement.cpp:
(WebCore::SVGAnimateMotionElement::rotateMode):
- svg/SVGAnimationElement.cpp:
(WebCore::SVGAnimationElement::setCalcMode):
(WebCore::SVGAnimationElement::setAttributeType):
(WebCore::SVGAnimationElement::isAdditive):
(WebCore::SVGAnimationElement::isAccumulated):
(WebCore::inheritsFromProperty):
- svg/SVGFEConvolveMatrixElement.cpp:
(WebCore::SVGFEConvolveMatrixElement::kernelUnitLengthXIdentifier):
(WebCore::SVGFEConvolveMatrixElement::kernelUnitLengthYIdentifier):
(WebCore::SVGFEConvolveMatrixElement::orderXIdentifier):
(WebCore::SVGFEConvolveMatrixElement::orderYIdentifier):
- svg/SVGFEDiffuseLightingElement.cpp:
(WebCore::SVGFEDiffuseLightingElement::kernelUnitLengthXIdentifier):
(WebCore::SVGFEDiffuseLightingElement::kernelUnitLengthYIdentifier):
- svg/SVGFEDropShadowElement.cpp:
(WebCore::SVGFEDropShadowElement::stdDeviationXIdentifier):
(WebCore::SVGFEDropShadowElement::stdDeviationYIdentifier):
- svg/SVGFEGaussianBlurElement.cpp:
(WebCore::SVGFEGaussianBlurElement::stdDeviationXIdentifier):
(WebCore::SVGFEGaussianBlurElement::stdDeviationYIdentifier):
- svg/SVGFEMorphologyElement.cpp:
(WebCore::SVGFEMorphologyElement::radiusXIdentifier):
(WebCore::SVGFEMorphologyElement::radiusYIdentifier):
- svg/SVGFESpecularLightingElement.cpp:
(WebCore::SVGFESpecularLightingElement::kernelUnitLengthXIdentifier):
(WebCore::SVGFESpecularLightingElement::kernelUnitLengthYIdentifier):
- svg/SVGFETurbulenceElement.cpp:
(WebCore::SVGFETurbulenceElement::baseFrequencyXIdentifier):
(WebCore::SVGFETurbulenceElement::baseFrequencyYIdentifier):
- svg/SVGFilterElement.cpp:
(WebCore::SVGFilterElement::filterResXIdentifier):
(WebCore::SVGFilterElement::filterResYIdentifier):
- svg/SVGGlyphMap.h:
(WebCore::SVGGlyphMap::svgGlyphForGlyph):
- svg/SVGLangSpace.cpp:
(WebCore::SVGLangSpace::xmlspace):
(WebCore::SVGLangSpace::addSupportedAttributes):
- svg/SVGMarkerElement.cpp:
(WebCore::SVGMarkerElement::orientTypeIdentifier):
(WebCore::SVGMarkerElement::orientAngleIdentifier):
(WebCore::SVGMarkerElement::synchronizeOrientType):
- svg/SVGStyleElement.cpp:
(WebCore::SVGStyleElement::type):
(WebCore::SVGStyleElement::media):
- svg/SVGTransform.cpp:
(WebCore::SVGTransform::transformTypePrefixForParsing):
- svg/SVGViewSpec.cpp:
(WebCore::SVGViewSpec::viewBoxIdentifier):
(WebCore::SVGViewSpec::preserveAspectRatioIdentifier):
(WebCore::SVGViewSpec::transformIdentifier):
- svg/animation/SVGSMILElement.cpp:
(WebCore::SVGSMILElement::parseClockValue):
(WebCore::SVGSMILElement::isSupportedAttribute):
(WebCore::SVGSMILElement::restart):
(WebCore::SVGSMILElement::fill):
(WebCore::SVGSMILElement::repeatCount):
(WebCore::SVGSMILElement::notifyDependentsIntervalChanged):
Source/WTF:
Mostly mechanical conversion to NeverDestroyed throughout WTF.
- wtf/RunLoop.cpp:
(WTF::RunLoop::current):
- wtf/ThreadingPthreads.cpp:
(WTF::threadMapMutex):
(WTF::threadMap):
Jan 8, 2016:
- 10:32 PM Changeset in webkit [194818] by
-
- 6 edits in trunk/Source/WebInspectorUI
Web Inspector: Test Resources should not be included in Production builds unless FORCE_TOOL_INSTALL
https://bugs.webkit.org/show_bug.cgi?id=152941
<rdar://problem/24119013>
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-01-08
Reviewed by Dan Bernstein.
- Configurations/Base.xcconfig:
Combine inspector resources in production, but not test resources.
- Configurations/DebugRelease.xcconfig:
Do not combine inspector resources in Release/Debug. Combine test resources.
- Configurations/WebInspectorUIFramework.xcconfig:
Simplify by moving to other config files.
- Scripts/copy-user-interface-resources.pl:
Have FORCE_TOOL_INSTALL combine test resources as well.
- WebInspectorUI.vcxproj/build-webinspectorui.pl:
Only combine test resources in non-Production.
- 10:27 PM Changeset in webkit [194817] by
-
- 11 edits2 adds in trunk
Absolute positioning -webkit-search-cancel-button crashes Safari.
https://bugs.webkit.org/show_bug.cgi?id=152847
<rdar://problem/24112087>
Reviewed by Simon Fraser.
Do not call offsetFromContainer while resolving the painting position for the search/cancel button renderer.
It skips the static positioned parent input renderer, when the search/cancel renderer is absolute positioned.
This patch also fixes a rendering glitch when the margin-right is > 0.
Source/WebCore:
Test: fast/forms/absolute-positioned-custom-search-cancel-crash.html
- rendering/RenderTheme.h:
(WebCore::RenderTheme::paintSearchFieldCancelButton):
(WebCore::RenderTheme::paintSearchFieldResultsDecorationPart):
(WebCore::RenderTheme::paintSearchFieldResultsButton):
- rendering/RenderThemeMac.h:
- rendering/RenderThemeMac.mm:
(WebCore::convertToPaintingPosition):
(WebCore::RenderThemeMac::paintSearchFieldCancelButton):
(WebCore::RenderThemeMac::paintSearchFieldResultsDecorationPart):
(WebCore::RenderThemeMac::paintSearchFieldResultsButton):
(WebCore::RenderThemeMac::convertToPaintingRect): Deleted.
LayoutTests:
- fast/forms/absolute-positioned-custom-search-cancel-crash-expected.txt: Added.
- fast/forms/absolute-positioned-custom-search-cancel-crash.html: Added.
- 10:07 PM Changeset in webkit [194816] by
-
- 4 edits in trunk/Source/WebCore
Add display-list drawing hooks to platform-specific GraphicsContext files
https://bugs.webkit.org/show_bug.cgi?id=152940
Reviewed by Zalan Bujtas.
Call into the display list recorder for top-level entrypoints implemented in platform-specific
files.
The convention is that if a function begins with "platform", it's not a top-level
entry point, and should only be called when there's a platform context (i.e. not
recording, and not paintingDisabled).
A few instances are stubbed out until we have a more complete display list implementation.
- platform/graphics/GraphicsContext.cpp:
(WebCore::GraphicsContext::drawText):
- platform/graphics/cairo/GraphicsContextCairo.cpp:
(WebCore::GraphicsContext::getCTM):
(WebCore::GraphicsContext::savePlatformState):
(WebCore::GraphicsContext::restorePlatformState):
(WebCore::GraphicsContext::drawRect):
(WebCore::GraphicsContext::drawNativeImage):
(WebCore::GraphicsContext::drawLine):
(WebCore::GraphicsContext::drawEllipse):
(WebCore::GraphicsContext::drawConvexPolygon):
(WebCore::GraphicsContext::clipConvexPolygon):
(WebCore::GraphicsContext::fillPath):
(WebCore::GraphicsContext::strokePath):
(WebCore::GraphicsContext::fillRect):
(WebCore::GraphicsContext::clip):
(WebCore::GraphicsContext::clipPath):
(WebCore::GraphicsContext::clipBounds):
(WebCore::GraphicsContext::drawLinesForText):
(WebCore::GraphicsContext::roundToDevicePixels):
(WebCore::GraphicsContext::translate):
(WebCore::GraphicsContext::setPlatformStrokeThickness):
(WebCore::GraphicsContext::setPlatformStrokeStyle):
(WebCore::GraphicsContext::concatCTM):
(WebCore::GraphicsContext::setCTM):
(WebCore::GraphicsContext::beginPlatformTransparencyLayer):
(WebCore::GraphicsContext::endPlatformTransparencyLayer):
(WebCore::GraphicsContext::clearRect):
(WebCore::GraphicsContext::strokeRect):
(WebCore::GraphicsContext::setLineCap):
(WebCore::GraphicsContext::setLineDash):
(WebCore::GraphicsContext::setLineJoin):
(WebCore::GraphicsContext::clipOut):
(WebCore::GraphicsContext::rotate):
(WebCore::GraphicsContext::scale):
(WebCore::GraphicsContext::platformFillRoundedRect):
(WebCore::GraphicsContext::fillRectWithRoundedHole):
(WebCore::GraphicsContext::drawPattern):
(WebCore::GraphicsContext::setPlatformShouldAntialias):
(WebCore::GraphicsContext::setPlatformImageInterpolationQuality):
(WebCore::GraphicsContext::isAcceleratedContext):
- platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::GraphicsContext::savePlatformState):
(WebCore::GraphicsContext::restorePlatformState):
(WebCore::GraphicsContext::drawNativeImage):
(WebCore::GraphicsContext::drawPattern):
(WebCore::GraphicsContext::drawRect):
(WebCore::GraphicsContext::drawLine):
(WebCore::GraphicsContext::drawEllipse):
(WebCore::GraphicsContext::drawConvexPolygon):
(WebCore::GraphicsContext::clipConvexPolygon):
(WebCore::GraphicsContext::applyStrokePattern):
(WebCore::GraphicsContext::applyFillPattern):
(WebCore::GraphicsContext::drawPath):
(WebCore::GraphicsContext::fillPath):
(WebCore::GraphicsContext::strokePath):
(WebCore::GraphicsContext::fillRect):
(WebCore::GraphicsContext::platformFillRoundedRect):
(WebCore::GraphicsContext::fillRectWithRoundedHole):
(WebCore::GraphicsContext::clip):
(WebCore::GraphicsContext::clipOut):
(WebCore::GraphicsContext::clipPath):
(WebCore::GraphicsContext::clipBounds):
(WebCore::GraphicsContext::beginPlatformTransparencyLayer):
(WebCore::GraphicsContext::endPlatformTransparencyLayer):
(WebCore::GraphicsContext::setPlatformShadow):
(WebCore::GraphicsContext::setMiterLimit):
(WebCore::GraphicsContext::clearRect):
(WebCore::GraphicsContext::strokeRect):
(WebCore::GraphicsContext::setLineCap):
(WebCore::GraphicsContext::setLineDash):
(WebCore::GraphicsContext::setLineJoin):
(WebCore::GraphicsContext::scale):
(WebCore::GraphicsContext::rotate):
(WebCore::GraphicsContext::translate):
(WebCore::GraphicsContext::concatCTM):
(WebCore::GraphicsContext::setCTM):
(WebCore::GraphicsContext::getCTM):
(WebCore::GraphicsContext::roundToDevicePixels):
(WebCore::GraphicsContext::drawLinesForText):
(WebCore::GraphicsContext::setURLForRect):
(WebCore::GraphicsContext::setIsCALayerContext):
(WebCore::GraphicsContext::isCALayerContext):
(WebCore::GraphicsContext::setIsAcceleratedContext):
(WebCore::GraphicsContext::isAcceleratedContext):
(WebCore::GraphicsContext::setPlatformTextDrawingMode):
(WebCore::GraphicsContext::setPlatformStrokeColor):
(WebCore::GraphicsContext::setPlatformStrokeThickness):
(WebCore::GraphicsContext::setPlatformFillColor):
(WebCore::GraphicsContext::setPlatformShouldAntialias):
(WebCore::GraphicsContext::setPlatformShouldSmoothFonts):
(WebCore::GraphicsContext::setPlatformAlpha):
(WebCore::GraphicsContext::setPlatformCompositeOperation):
(WebCore::GraphicsContext::platformApplyDeviceScaleFactor):
(WebCore::GraphicsContext::platformFillEllipse):
(WebCore::GraphicsContext::platformStrokeEllipse):
- 5:57 PM Changeset in webkit [194815] by
-
- 4 edits in trunk/LayoutTests
Modern IDB: storage/indexeddb/setversion-blocked-by-versionchange-close.html fails.
https://bugs.webkit.org/show_bug.cgi?id=152936
Reviewed by Alex Christensen.
- platform/mac-wk1/TestExpectations:
- storage/indexeddb/resources/setversion-blocked-by-versionchange-close.js:
- storage/indexeddb/setversion-blocked-by-versionchange-close-expected.txt:
- 5:41 PM Changeset in webkit [194814] by
-
- 8 edits in trunk/Source/WebCore
Add DisplayList hooks into GraphicsContext
https://bugs.webkit.org/show_bug.cgi?id=152932
Reviewed by Zalan Bujtas.
Add the hooks into GraphicsContext that call into the DisplayListRecorder if there
is one.
Rename size() to something less ambiguous.
Out-of-line some DisplayList functions so that the header doesn't need to see
DisplayListItems.h.
- platform/graphics/GraphicsContext.cpp:
(WebCore::GraphicsContext::save):
(WebCore::GraphicsContext::restore):
(WebCore::GraphicsContext::setStrokeThickness):
(WebCore::GraphicsContext::setStrokeStyle):
(WebCore::GraphicsContext::setStrokeColor):
(WebCore::GraphicsContext::setShadow):
(WebCore::GraphicsContext::setLegacyShadow):
(WebCore::GraphicsContext::clearShadow):
(WebCore::GraphicsContext::setFillColor):
(WebCore::GraphicsContext::setShadowsIgnoreTransforms):
(WebCore::GraphicsContext::setShouldAntialias):
(WebCore::GraphicsContext::setShouldSmoothFonts):
(WebCore::GraphicsContext::setShouldSubpixelQuantizeFonts):
(WebCore::GraphicsContext::setImageInterpolationQuality):
(WebCore::GraphicsContext::setAntialiasedFontDilationEnabled):
(WebCore::GraphicsContext::setStrokePattern):
(WebCore::GraphicsContext::setFillPattern):
(WebCore::GraphicsContext::setStrokeGradient):
(WebCore::GraphicsContext::setFillRule):
(WebCore::GraphicsContext::setFillGradient):
(WebCore::GraphicsContext::beginTransparencyLayer):
(WebCore::GraphicsContext::endTransparencyLayer):
(WebCore::GraphicsContext::drawGlyphs):
(WebCore::GraphicsContext::drawImage):
(WebCore::GraphicsContext::drawTiledImage):
(WebCore::GraphicsContext::setTextDrawingMode):
(WebCore::GraphicsContext::fillRect):
(WebCore::GraphicsContext::fillRoundedRect):
(WebCore::GraphicsContext::setAlpha):
(WebCore::GraphicsContext::setCompositeOperation):
(WebCore::GraphicsContext::setDrawLuminanceMask):
(WebCore::GraphicsContext::applyDeviceScaleFactor):
(WebCore::GraphicsContext::applyState):
- platform/graphics/GraphicsContext.h:
(WebCore::GraphicsContext::setDisplayListRecorder):
(WebCore::GraphicsContext::isRecording):
(WebCore::GraphicsContext::setFillRule): Deleted.
(WebCore::GraphicsContext::setShadowsIgnoreTransforms): Deleted.
(WebCore::GraphicsContext::setShouldSubpixelQuantizeFonts): Deleted.
(WebCore::GraphicsContext::setDrawLuminanceMask): Deleted.
- platform/graphics/displaylists/DisplayList.cpp:
(WebCore::DisplayList::DisplayList::clear):
(WebCore::DisplayList::DisplayList::removeItemsFromIndex):
- platform/graphics/displaylists/DisplayList.h:
(WebCore::DisplayList::DisplayList::itemCount):
(WebCore::DisplayList::DisplayList::clear): Deleted.
(WebCore::DisplayList::DisplayList::size): Deleted.
(WebCore::DisplayList::DisplayList::removeItemsFromIndex): Deleted.
- platform/graphics/displaylists/DisplayListRecorder.cpp:
(WebCore::DisplayList::Recorder::save):
(WebCore::DisplayList::Recorder::restore):
- platform/graphics/displaylists/DisplayListRecorder.h:
(WebCore::DisplayList::Recorder::itemCount):
(WebCore::DisplayList::Recorder::size): Deleted.
- platform/graphics/displaylists/DisplayListReplayer.cpp:
(WebCore::DisplayList::Replayer::replay):
- 5:36 PM Changeset in webkit [194813] by
-
- 2 edits in tags/Safari-602.1.15.0.1
Merged r194809. rdar://problem/24116804
- 5:35 PM Changeset in webkit [194812] by
-
- 5 edits in tags/Safari-602.1.15.0.1/Source
Versioning.
- 5:33 PM Changeset in webkit [194811] by
-
- 1 copy in tags/Safari-602.1.15.0.1
New tag.
- 5:21 PM Changeset in webkit [194810] by
-
- 14 edits2 adds in trunk/Source/WebKit2
Implement download authentication with NetworkSession
https://bugs.webkit.org/show_bug.cgi?id=152878
Reviewed by Brady Eidson.
- DerivedSources.make:
- NetworkProcess/Downloads/Download.h:
- NetworkProcess/Downloads/DownloadManager.cpp:
(WebKit::DownloadManager::startDownload):
- NetworkProcess/Downloads/PendingDownload.cpp: Added.
(WebKit::PendingDownload::PendingDownload):
(WebKit::PendingDownload::willSendRedirectedRequest):
(WebKit::PendingDownload::continueWillSendRequest):
(WebKit::PendingDownload::canAuthenticateAgainstProtectionSpaceAsync):
(WebKit::PendingDownload::continueCanAuthenticateAgainstProtectionSpace):
(WebKit::PendingDownload::didConvertToDownload):
(WebKit::PendingDownload::messageSenderConnection):
(WebKit::PendingDownload::messageSenderDestinationID):
- NetworkProcess/Downloads/PendingDownload.h:
(WebKit::PendingDownload::PendingDownload): Deleted.
- NetworkProcess/Downloads/PendingDownload.messages.in: Added.
- NetworkProcess/NetworkLoad.cpp:
(WebKit::NetworkLoad::continueWillSendRequest):
The completion handler should always be called. If m_currentRequest is null, then the request will not proceed, which is the same as canceling it.
(WebKit::NetworkLoad::setPendingDownloadID):
(WebKit::NetworkLoad::setPendingDownload):
(WebKit::NetworkLoad::willPerformHTTPRedirection):
(WebKit::NetworkLoad::continueCanAuthenticateAgainstProtectionSpace):
If this load is going to become a download, then call the PendingDownload version of didReceiveAuthenticationChallenge to communicate with the
UI process directly because there wasn't necessarily a web process associated with this request that will become a download.
- NetworkProcess/NetworkLoad.h:
(WebKit::NetworkLoad::pendingDownloadID):
- NetworkProcess/NetworkSession.h:
(WebKit::NetworkDataTask::client):
(WebKit::NetworkDataTask::pendingDownloadID):
(WebKit::NetworkDataTask::pendingDownload):
(WebKit::NetworkDataTask::setPendingDownloadID):
(WebKit::NetworkDataTask::setPendingDownload):
- NetworkProcess/cocoa/NetworkSessionCocoa.mm:
- PlatformMac.cmake:
- Shared/Authentication/AuthenticationManager.cpp:
(WebKit::AuthenticationManager::didReceiveAuthenticationChallenge):
- Shared/Authentication/AuthenticationManager.h:
- WebKit2.xcodeproj/project.pbxproj:
- WebProcess/Network/WebResourceLoader.cpp:
(WebKit::WebResourceLoader::canAuthenticateAgainstProtectionSpace):
Removed unnecessary protection and move null check to before using the pointer it checks.
- 4:59 PM Changeset in webkit [194809] by
-
- 2 edits in trunk
Fix internal Windows build
https://bugs.webkit.org/show_bug.cgi?id=152937
Reviewed by Brent Fulgham.
- Source/cmake/WebKitCommon.cmake:
Try looking in the default cygwin installation directory for executables like bison, flex, gperf, and ruby.
This is needed on Windows builds that are not driven by cygwin, but need to use the cygwin installations of these tools.
This is the effective equivalent of this line in WebKitLibraries/win/tools/vsprops/common.props in the old build system:
set PATH=%SystemDrive%\cygwin\bin;%PATH%
- 4:50 PM Changeset in webkit [194808] by
-
- 2 edits in trunk/LayoutTests
Unreviewed test gardening.
- platform/mac-wk1/TestExpectations:
- 4:42 PM Changeset in webkit [194807] by
-
- 2 edits in trunk/LayoutTests
Marking fast/scrolling/scroll-position-on-reload-rtl.html as failing on ios-simulator
https://bugs.webkit.org/show_bug.cgi?id=152935
Unreviewed test gardening.
- platform/ios-simulator/TestExpectations:
- 4:41 PM Changeset in webkit [194806] by
-
- 2 edits in trunk/LayoutTests
Skipping two unsupported mouse event tests on ios-simulator
Unreviewed test gardening.
- platform/ios-simulator/TestExpectations:
- 4:37 PM Changeset in webkit [194805] by
-
- 2 edits in trunk/Source/JavaScriptCore
FTL B3 should do varargs tail calls and stack overflows
https://bugs.webkit.org/show_bug.cgi?id=152934
Reviewed by Saam Barati.
I was trying to get tail-call-varargs-no-stack-overflow.js.ftl-no-cjit-validate to work and
at first I hit the stack overflow issue and then I hit the varargs tail call issue. That's
why I have two fixes in one change. Now the test passes.
This reduces the number of failures from 13 to 0.
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::DFG::LowerDFGToLLVM::lower): Implement stack overflow handling.
(JSC::FTL::DFG::LowerDFGToLLVM::compileCallOrConstructVarargs): Varargs tail calls need to
append an Oops (i.e. "unreachable").
- 4:36 PM Changeset in webkit [194804] by
-
- 2 edits in trunk/LayoutTests
Unreviewed test gardening.
- platform/mac-wk1/TestExpectations:
- 4:24 PM Changeset in webkit [194803] by
-
- 2 edits in trunk/LayoutTests
Unreviewed test gardening.
- platform/mac-wk1/TestExpectations:
- 4:01 PM Changeset in webkit [194802] by
-
- 12 edits1 add in trunk/Source/JavaScriptCore
B3 needs Neg()
https://bugs.webkit.org/show_bug.cgi?id=152925
Reviewed by Mark Lam.
Previously we said that negation should be represented as Sub(0, x). That's wrong, since
for floats, Sub(0, 0) == 0 while Neg(0) == -0.
One way to solve this would be to say that anyone trying to say Neg(x) where x is a float
should instead say BitXor(x, -0). That's actually correct, but I think that it would be odd
to use bitops to represent floating point operations. Whatever cuteness this would have
bought us would be outweighed by the annoyance of having to write code that matches
Sub(0, x) for integer negation and BitXor(x, -0) for double negation. For example, this
would mean strictly more code for anyone implementing a Neg(Neg(x))=>x strength reduction.
Also, I suspect that the omission of Neg would cause others to make the mistake of using
Sub to represent floating point negation.
So, this introduces a proper Neg() opcode to B3. It's now the canonical way of saying
negation for both ints and floats. For ints, we canonicalize Sub(0, x) to Neg(x). For
floats, we lower it to BitXor(x, -0) on x86.
This reduces the number of failures from 13 to 12.
- assembler/MacroAssemblerX86Common.h:
(JSC::MacroAssemblerX86Common::andFloat):
(JSC::MacroAssemblerX86Common::xorDouble):
(JSC::MacroAssemblerX86Common::xorFloat):
(JSC::MacroAssemblerX86Common::convertInt32ToDouble):
- b3/B3LowerMacrosAfterOptimizations.cpp:
- b3/B3LowerToAir.cpp:
(JSC::B3::Air::LowerToAir::lower):
- b3/B3Opcode.cpp:
(WTF::printInternal):
- b3/B3Opcode.h:
- b3/B3ReduceStrength.cpp:
- b3/B3Validate.cpp:
- b3/B3Value.cpp:
(JSC::B3::Value::effects):
(JSC::B3::Value::key):
(JSC::B3::Value::typeFor):
- b3/air/AirOpcode.opcodes:
- ftl/FTLB3Output.cpp:
(JSC::FTL::Output::lockedStackSlot):
(JSC::FTL::Output::neg):
(JSC::FTL::Output::bitNot):
- ftl/FTLB3Output.h:
(JSC::FTL::Output::chillDiv):
(JSC::FTL::Output::mod):
(JSC::FTL::Output::chillMod):
(JSC::FTL::Output::doubleAdd):
(JSC::FTL::Output::doubleSub):
(JSC::FTL::Output::doubleMul):
(JSC::FTL::Output::doubleDiv):
(JSC::FTL::Output::doubleMod):
(JSC::FTL::Output::doubleNeg):
(JSC::FTL::Output::bitAnd):
(JSC::FTL::Output::bitOr):
(JSC::FTL::Output::neg): Deleted.
- tests/stress/ftl-negate-zero.js: Added. This was already covered by op_negate but since
it's such a glaring bug, I thought having a test for it specifically would be good.
- 3:50 PM Changeset in webkit [194801] by
-
- 2 edits in trunk/LayoutTests
Marking js/intl-collator.html as failing on ios-simulator
https://bugs.webkit.org/show_bug.cgi?id=152448
Unreviewed test gardening.
- platform/ios-simulator/TestExpectations:
- 3:41 PM Changeset in webkit [194800] by
-
- 4 edits in trunk
Modern IDB: imported/w3c/indexeddb/keyorder.htm times out.
https://bugs.webkit.org/show_bug.cgi?id=152929
Reviewed by Alex Christensen.
Source/WebCore:
No new tests (Existing test now runs in the test harness).
- Modules/indexeddb/client/IDBCursorImpl.cpp:
(WebCore::IDBClient::IDBCursor::setGetResult):
LayoutTests:
- platform/mac-wk1/TestExpectations:
- 3:36 PM Changeset in webkit [194799] by
-
- 2 edits in trunk/LayoutTests
Marking two css3/filters/composited-during-* tests as failing on ios-simulator.
https://bugs.webkit.org/show_bug.cgi?id=152282
Unreviewed test gardening.
- platform/ios-simulator/TestExpectations:
- 3:26 PM Changeset in webkit [194798] by
-
- 8 edits in trunk/Source/WebCore
Consider painting to be disabled on a GraphicsContext with no platform data, and make updatingControlTints() immutable state
https://bugs.webkit.org/show_bug.cgi?id=152927
Reviewed by Tim Horton.
GraphicsContext had setters for paintingDisabled and updatingControlTints, but neither
were changed dynamically.
We can eliminate paintingDisabled by simply considering a GraphicsContext that was
created with no platform context to be paint-disabled.
We make updatingControlTints immutable state by providing a constructor that takes
a "NonPaintingReasons" enum, and doesn't create platform data.
More functions in platform code were protected by if (paintingDisabled())...
- page/FrameView.cpp:
(WebCore::FrameView::paintControlTints):
- platform/graphics/GraphicsContext.cpp:
(WebCore::GraphicsContext::GraphicsContext):
(WebCore::GraphicsContext::fillRoundedRect):
(WebCore::GraphicsContext::setUpdatingControlTints): Deleted.
(WebCore::GraphicsContext::clip): Deleted.
- platform/graphics/GraphicsContext.h:
(WebCore::GraphicsContext::paintingDisabled):
(WebCore::GraphicsContext::updatingControlTints):
(WebCore::GraphicsContextState::GraphicsContextState): Deleted.
(WebCore::GraphicsContext::setPaintingDisabled): Deleted.
- platform/graphics/cairo/GraphicsContextCairo.cpp:
(WebCore::GraphicsContext::GraphicsContext):
(WebCore::GraphicsContext::platformInit):
- platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::GraphicsContext::platformInit):
(WebCore::GraphicsContext::savePlatformState):
(WebCore::GraphicsContext::restorePlatformState):
(WebCore::GraphicsContext::drawNativeImage):
(WebCore::GraphicsContext::drawPattern):
(WebCore::GraphicsContext::drawRect):
(WebCore::GraphicsContext::applyStrokePattern):
(WebCore::GraphicsContext::applyFillPattern):
(WebCore::GraphicsContext::clip):
(WebCore::GraphicsContext::clipBounds):
(WebCore::GraphicsContext::setLineDash):
(WebCore::GraphicsContext::roundToDevicePixels):
(WebCore::GraphicsContext::setPlatformImageInterpolationQuality):
(WebCore::GraphicsContext::setIsCALayerContext):
(WebCore::GraphicsContext::isCALayerContext):
(WebCore::GraphicsContext::setIsAcceleratedContext):
(WebCore::GraphicsContext::isAcceleratedContext):
(WebCore::GraphicsContext::platformApplyDeviceScaleFactor):
- platform/graphics/win/GraphicsContextCGWin.cpp:
(WebCore::GraphicsContext::platformInit):
(WebCore::GraphicsContext::GraphicsContext): Deleted.
- platform/graphics/win/GraphicsContextCairoWin.cpp:
(WebCore::GraphicsContext::platformInit):
(WebCore::GraphicsContext::GraphicsContext): Deleted.
- 3:25 PM Changeset in webkit [194797] by
-
- 2 edits in trunk/LayoutTests
Mark compositing/overflow/dynamic-composited-scrolling-status.html as failing on ios-simulator, remove duplicate
expectation added by previous commit.
Unreviewed test gardening.
- platform/ios-simulator/TestExpectations:
- 3:19 PM Changeset in webkit [194796] by
-
- 8 edits in trunk/Source/WebCore
InputType::findClosestTickMarkValue should return an Optional<Decimal>
https://bugs.webkit.org/show_bug.cgi?id=152931
Reviewed by Andreas Kling.
This will make it possible to get rid of the notion of infinity from Decimal, allowing for more code simplification.
- html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::findClosestTickMarkValue):
- html/HTMLInputElement.h:
- html/InputType.cpp:
(WebCore::InputType::findClosestTickMarkValue):
- html/InputType.h:
- html/RangeInputType.cpp:
(WebCore::RangeInputType::findClosestTickMarkValue):
- html/RangeInputType.h:
- html/shadow/SliderThumbElement.cpp:
(WebCore::SliderThumbElement::setPositionFromPoint):
- 3:19 PM Changeset in webkit [194795] by
-
- 2 edits in trunk/LayoutTests
Unreviewed test gardening.
- platform/mac-wk1/TestExpectations:
- 3:18 PM Changeset in webkit [194794] by
-
- 1 edit1 delete in trunk/LayoutTests
Removing WK2 specific results for this test.
Legacy IDB passes just the same as Modern IDB.
- platform/wk2/imported/w3c/indexeddb/keypath-expected.txt: Removed.
- 3:16 PM Changeset in webkit [194793] by
-
- 2 edits in trunk/LayoutTests
Marking two ios/scolling tests as failing on ios-simulator.
https://bugs.webkit.org/show_bug.cgi?id=152276
Unreviewed test gardening.
- platform/ios-simulator/TestExpectations:
- 3:12 PM Changeset in webkit [194792] by
-
- 2 edits1 add in trunk/LayoutTests
Rebaselining two compositing tests for ios-simulator
https://bugs.webkit.org/show_bug.cgi?id=152138
Unreviewed test gardening.
- platform/ios-simulator-wk2/compositing/contents-opaque/body-background-painted-expected.txt:
- platform/ios-simulator/compositing/contents-opaque/table-parts-expected.txt: Added.
- 2:51 PM Changeset in webkit [194791] by
-
- 1 edit1717 deletes in trunk/LayoutTests
Removing ios-simulator-wk1/ and ios-simulator-wk2/ expected.* files that are identical to the ones in ios-simulator/
https://bugs.webkit.org/show_bug.cgi?id=152130
Unreviewed test gardening.
- platform/ios-simulator-wk1/editing/deleting/delete-block-merge-contents-011-expected.txt: Removed.
- platform/ios-simulator-wk1/editing/deleting/delete-first-list-item-expected.txt: Removed.
- platform/ios-simulator-wk1/editing/deleting/merge-different-styles-expected.txt: Removed.
- +1714 more
- 2:29 PM Changeset in webkit [194790] by
-
- 2 edits in trunk/LayoutTests
Removing deleted test fast/mediastream/RTCPeerConnection-state.html from mac TestExpectations file
Unreviewed test gardening.
- platform/mac/TestExpectations:
- 2:21 PM Changeset in webkit [194789] by
-
- 9 edits in trunk
Modern IDB: IDBBindingUtilities chokes on unicode strings for get/set.
https://bugs.webkit.org/show_bug.cgi?id=152921
Reviewed by Alex Christensen.
LayoutTests/imported/w3c:
- indexeddb/keypath-expected.txt:
Source/WebCore:
No new tests (Covered by existing tests).
- bindings/js/IDBBindingUtilities.cpp:
(WebCore::get): Don't do a potentially lossy utf8() conversion on the string.
(WebCore::set): Ditto.
LayoutTests:
- platform/mac-wk1/TestExpectations:
- storage/indexeddb/objectstore-autoincrement-expected.txt:
- storage/indexeddb/objectstore-autoincrement.html:
- storage/indexeddb/resources/objectstore-autoincrement.js:
- 1:57 PM Changeset in webkit [194788] by
-
- 7 edits in trunk/Websites/perf.webkit.org
Make v3 UI analysis task page is hard to understand
https://bugs.webkit.org/show_bug.cgi?id=152917
Reviewed by Antti Koivisto.
Add a dark gray border around the selected block in the analysis results viewer instead of using darker
shades since that looks as if they were bigger regression/progression.
Explicitly show "Failed" as the label instead of omitting with "-" when all build requests in an A/B
testing group fails.
- public/v3/components/analysis-results-viewer.js:
(AnalysisResultsViewer.cssTemplate): Tweaked the style to underline text in the hovered blocks and the
selected blocks and show a dark gray border around the selected blocks.
(AnalysisResultsViewer.TestGroupStackingBlock):
(AnalysisResultsViewer.TestGroupStackingBlock.prototype.createStackingCell): Use this._title for title.
(AnalysisResultsViewer.TestGroupStackingBlock.prototype._computeTestGroupStatus):
(AnalysisResultsViewer.TestGroupStackingBlock.prototype._valuesForRootSet): Deleted.
- public/v3/components/results-table.js:
(ResultsTable.prototype.render):
(ResultsTable.prototype._createRevisionListCells): Extracted from ResultsTable.prototype.render.
(ResultsTable.cssTemplate): Tweaked the style.
(ResultsTableRow):
(ResultsTableRow.prototype.constructor): Added _labelForWholeRow to store the label for the entire row.
This is used to show the comparison result of two root sets (e.g. A vs B).
(ResultsTableRow.prototype.setLabelForWholeRow): Added.
(ResultsTableRow.prototype.labelForWholeRow): Added.
(ResultsTableRow.prototype.resultContent): Extracted from buildHeading. Creates a hyperlinked bar graph
used for each A/B testing result.
(ResultsTableRow.prototype.buildHeading): Deleted since we need to set colspan on the second table cell
when we're creating a row with _labelForWholeRow.
- public/v3/components/test-group-results-table.js:
(TestGroupResultsTable.prototype.buildRowGroups): Added rows to show relative differences and statistical
significance between root sets (e.g. A vs B).
- public/v3/models/build-request.js:
(BuildRequest.prototype.hasCompleted): Added.
- public/v3/models/test-group.js:
(TestGroup.prototype.compareTestResults): Extracted from AnalysisResultsViewer.TestGroupStackingBlock's
_computeTestGroupStatus and generalized to be reused in TestGroupResultsTable.
(TestGroup.prototype._valuesForRootSet): Moved from AnalysisResultsViewer.TestGroupStackingBlock.
- public/v3/pages/analysis-task-page.js:
(AnalysisTaskPage.cssTemplate): Tweaked the style.
- 1:42 PM Changeset in webkit [194787] by
-
- 2 edits in trunk/Source/WebCore
[WinCairo] Support more video formats.
https://bugs.webkit.org/show_bug.cgi?id=152890
Reviewed by Alex Christensen.
Use MediaFoundation api to detect all supported video/audio formats.
- platform/graphics/win/MediaPlayerPrivateMediaFoundation.cpp:
(WebCore::MediaPlayerPrivateMediaFoundation::getSupportedTypes):
(WebCore::MediaPlayerPrivateMediaFoundation::supportsType):
- 1:42 PM Changeset in webkit [194786] by
-
- 4 edits in trunk/Source/JavaScriptCore
FTL B3 compile() doesn't clear exception handlers before we add FTL-specific ones
https://bugs.webkit.org/show_bug.cgi?id=152922
Reviewed by Saam Barati.
FTL B3 was generating a handler table that first contained the old baseline handlers keyed
by baseline's bytecode indices and then the FTL handlers keyed by FTL callsite index. That's
wrong, since the FTL code block should not contain any baseline handlers. The fix is to
clear the handlers before generation, sort of like FTL LLVM does.
Also added some stuff to make it easier to inspect the handler table.
This reduces the numbe rof failures from 25 to 13.
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::dumpBytecode):
(JSC::CodeBlock::dumpExceptionHandlers):
(JSC::CodeBlock::beginDumpProfiling):
- bytecode/CodeBlock.h:
- ftl/FTLB3Compile.cpp:
(JSC::FTL::compile):
- 1:33 PM Changeset in webkit [194785] by
-
- 3 edits in trunk/Source/WebInspectorUI
Web Inspector: Initiated section of Resource Details Sidebar should not display as empty and should update as the list changes
https://bugs.webkit.org/show_bug.cgi?id=152907
<rdar://problem/24109927>
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-01-08
Reviewed by Timothy Hatcher.
- UserInterface/Models/Resource.js:
(WebInspector.Resource.prototype.addInitiatedResource):
Dispatch an event when the list of initiated resources changes.
- UserInterface/Views/ResourceDetailsSidebarPanel.js:
(WebInspector.ResourceDetailsSidebarPanel.prototype.set resource):
Add/remove event listeners for initiated resources changes to refresh
the related resources section.
(WebInspector.ResourceDetailsSidebarPanel.prototype.refresh):
(WebInspector.ResourceDetailsSidebarPanel.prototype._refreshURL):
(WebInspector.ResourceDetailsSidebarPanel.prototype._refreshRelatedResourcesSection):
Show/hide the related resources section depending on if we have something or not.
- 1:32 PM Changeset in webkit [194784] by
-
- 5 edits in trunk/Source/WTF
Nullopt and InPlace should be structs, not enum values
https://bugs.webkit.org/show_bug.cgi?id=152915
Reviewed by Andreas Kling.
Without this,
Optional<int> o = flag ? 1 : Nullopt;
would cause Nullopt to be treated as an integer, causing o to be initialized to 0,
instead of Nullopt. With this change, the above code now causes a compile error.
Also, get rid of the CONSTEXPR macro since all compilers support constexpr properly,
and add a WTF::makeOptional to match the current iteration of std::experimental::optional.
- wtf/Compiler.h:
- wtf/Forward.h:
- wtf/Optional.h:
(WTF::NulloptTag::NulloptTag):
(WTF::makeOptional):
- wtf/StdLibExtras.h:
(std::literals::chrono_literals::operator _s):
(std::literals::chrono_literals::operator _ms):
(std::move):
- 1:28 PM Changeset in webkit [194783] by
-
- 2 edits in branches/safari-601.1.46-branch/Source/WebCore
<rdar://problem/24094651> REGRESSION (193350): CrashTracer: [USER] com.apple.WebKit.WebContent at …: Inspector::CSSFrontendDispatcher::styleSheetRemoved + 768
Reviewed by Joseph Pecoraro.
- inspector/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::setActiveStyleSheetsForDocument):
Add null check before using m_frontendDispatcher.
- 1:23 PM Changeset in webkit [194782] by
-
- 2 edits in branches/safari-601-branch/Source/WebCore
<rdar://problem/24094651> REGRESSION (193350): CrashTracer: [USER] com.apple.WebKit.WebContent at …: Inspector::CSSFrontendDispatcher::styleSheetRemoved + 768
Reviewed by Joseph Pecoraro.
- inspector/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::setActiveStyleSheetsForDocument):
Add null check before using m_frontendDispatcher.
- 1:12 PM Changeset in webkit [194781] by
-
- 18 edits2 copies in trunk
Modern IDB: Blocked event can fire on a delete request even after the last open connection has closed.
https://bugs.webkit.org/show_bug.cgi?id=152896
Reviewed by Alex Christensen.
LayoutTests/imported/w3c:
- indexeddb/idbfactory_open12-expected.txt:
- indexeddb/idbversionchangeevent-expected.txt:
- indexeddb/transaction-lifetime-expected.txt:
Source/WebCore:
No new tests (Progression in many tests).
- Modules/indexeddb/client/IDBFactoryImpl.cpp:
(WebCore::IDBClient::IDBFactory::deleteDatabase):
- Modules/indexeddb/server/UniqueIDBDatabase.cpp:
(WebCore::IDBServer::UniqueIDBDatabase::performCurrentDeleteOperation): Allow for handling 2+ delete operations in a row.
(WebCore::IDBServer::UniqueIDBDatabase::didDeleteBackingStore): Ditto.
(WebCore::IDBServer::UniqueIDBDatabase::connectionClosedFromClient): Call "notifyCurrentRequestConnectionClosedOrFiredVersionChangeEvent"
after the connection is actually removed from the set of open connections.
- Modules/indexeddb/server/UniqueIDBDatabase.h:
LayoutTests:
- platform/mac-wk1/TestExpectations:
- platform/wk2/imported/w3c/indexeddb/idbfactory_open12-expected.txt: Copied from LayoutTests/imported/w3c/indexeddb/idbfactory_open12-expected.txt.
- platform/wk2/imported/w3c/indexeddb/idbversionchangeevent-expected.txt: Copied from LayoutTests/imported/w3c/indexeddb/idbversionchangeevent-expected.txt.
- storage/indexeddb/database-wrapper-expected.txt:
- storage/indexeddb/delete-in-upgradeneeded-close-in-versionchange-expected.txt:
- storage/indexeddb/deletedatabase-not-blocked-expected.txt:
- storage/indexeddb/intversion-upgrades-expected.txt:
- storage/indexeddb/resources/delete-in-upgradeneeded-close-in-versionchange.js:
- storage/indexeddb/resources/deletedatabase-not-blocked.js:
- storage/indexeddb/resources/setversion-not-blocked.js:
- storage/indexeddb/setversion-not-blocked-expected.txt:
- 1:05 PM WebKitGTK/Gardening/Calendar edited by
- (diff)
- 1:01 PM Changeset in webkit [194780] by
-
- 2 edits in trunk/Source/ThirdParty/ANGLE
[ANGLE] Correct UNREACHABLE runtime assertion for void constructors
https://bugs.webkit.org/show_bug.cgi?id=152900
<rdar://problem/24107501>
Reviewed by Alex Christensen.
Tested by Khronos WebGL 1.0.4 suite.
Merge a small part of ANGLE upstream commit r284735:
commit 01971113492d9aca386f2bca021b1f4b134fc277
author Dmitry Skiba <dskiba@google.com> Fri Jul 10 18:54:00 2015
committer Jamie Madill <jmadill@chromium.org> Fri Jul 10 19:03:34 2015
tree 47e42eac00f7d64cddb14b3cc21a4e605c189d20
This issue was found by <https://www.khronos.org/registry/webgl/sdk/tests/conformance/glsl/bugs/angle-constructor-invalid-parameters.html?webglVersion=1&quiet=0>
- src/compiler/translator/Types.cpp:
(TType::buildMangledName): Don't assert with UNREACHABLE here.
- 1:01 PM Changeset in webkit [194779] by
-
- 2 edits in trunk/LayoutTests
[GTK] Several animation tests fail with accelerated compositing enabled
Unreviewed gardening.
- platform/gtk/TestExpectations:
- 12:47 PM Changeset in webkit [194778] by
-
- 2 edits in trunk/LayoutTests
[GTK] pageoverlay tests are failing
Unreviewed gardening.
Patch by Lorenzo Tilve <ltilve@igalia.com> on 2016-01-08
- platform/gtk/TestExpectations:
- 12:14 PM Changeset in webkit [194777] by
-
- 2 edits in trunk/Source/JavaScriptCore
B3 incorrectly turns NotEqual(bool, 1) into Equal(bool, 1) instead of Equal(bool, 0)
https://bugs.webkit.org/show_bug.cgi?id=152916
Reviewed by Mark Lam.
This was causing a failure in an ancient DFG layout test. Thanks, ftl-eager-no-cjit!
This reduces the number of failures from 27 to 25.
- b3/B3ReduceStrength.cpp:
- 12:14 PM Changeset in webkit [194776] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Uncaught exception: TypeError: this._initiatorSourceCodeLocation.sourceCode.addInitiatedResource is not a function
https://bugs.webkit.org/show_bug.cgi?id=152905
<rdar://problem/24109809>
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-01-08
Reviewed by Brian Burg.
- UserInterface/Models/Resource.js:
(WebInspector.Resource):
(WebInspector.Resource.prototype.addInitiatedResource):
Only Resource has addInitiatedResource, so only call it if the
SourceCode in the SourceCodeLocation is a Resource.
- 12:05 PM Changeset in webkit [194775] by
-
- 6 edits2 adds in trunk
Hovering link on http://help.apple.com/appletv/#/ does not show text underline.
https://bugs.webkit.org/show_bug.cgi?id=152906
<rdar://problem/23339617>
Reviewed by Simon Fraser.
GraphicsContext::computeLineBoundsAndAntialiasingModeForText() always integral ceils the origin y position to offset underline text.
This additional visual overflow offset is not taken into account by visualOverflowForDecorations().
Unfortunately we can't compute the exact same offset value while collecting repaint rects, because
computeLineBoundsAndAntialiasingModeForText() uses CTM scaling before adjusting the offset position.
Use 1px (css) bottom offset to cover this underling overflow.
Source/WebCore:
Test: fast/css3-text/css3-text-decoration/text-underline-position/underline-visual-overflow-with-subpixel-position.html
- platform/graphics/GraphicsContext.cpp:
(WebCore::GraphicsContext::computeLineBoundsAndAntialiasingModeForText):
- rendering/SimpleLineLayoutResolver.cpp: Add visual overflow to simple line layout.
(WebCore::SimpleLineLayout::RunResolver::Run::rect):
(WebCore::SimpleLineLayout::RunResolver::RunResolver):
- rendering/SimpleLineLayoutResolver.h:
- style/InlineTextBoxStyle.cpp:
(WebCore::visualOverflowForDecorations):
LayoutTests:
- fast/css3-text/css3-text-decoration/text-underline-position/underline-visual-overflow-with-subpixel-position-expected.txt: Added.
- fast/css3-text/css3-text-decoration/text-underline-position/underline-visual-overflow-with-subpixel-position.html: Added.
- 11:37 AM Changeset in webkit [194774] by
-
- 2 edits in trunk/Source/JavaScriptCore
FTL B3 allocateCell() should not crash
https://bugs.webkit.org/show_bug.cgi?id=152909
Reviewed by Mark Lam.
This code was crashing in some tests that forced GC slow paths because it was stubbed out
due to the use of undef. B3 doesn't have undef. In this case, there's no good reason to use
undef. We can just use zero. Since the path is dead anyway in that case, we weren't gaining
any LLVM optimizations by using undef.
This reduces the number of failures from 35 to 27.
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::DFG::LowerDFGToLLVM::allocateCell):
- 11:02 AM Changeset in webkit [194773] by
-
- 2 edits in trunk/Source/JavaScriptCore
FTL B3 fails to realize that binary snippets might choose to omit their fast path
https://bugs.webkit.org/show_bug.cgi?id=152901
Reviewed by Mark Lam.
This reduces the number of failures from 99 to 35.
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::DFG::LowerDFGToLLVM::emitBinarySnippet):
- 10:49 AM Changeset in webkit [194772] by
-
- 5 edits in trunk/Source/JavaScriptCore
restoreCalleeSavesFromVMCalleeSavesBuffer should use the scratch register
https://bugs.webkit.org/show_bug.cgi?id=152879
Reviewed by Filip Pizlo.
We were clobbering a register we needed when picking
a scratch register inside an FTL OSR Exit.
- dfg/DFGThunks.cpp:
(JSC::DFG::osrEntryThunkGenerator):
- jit/AssemblyHelpers.cpp:
(JSC::AssemblyHelpers::emitRandomThunk):
(JSC::AssemblyHelpers::restoreCalleeSavesFromVMCalleeSavesBuffer):
- jit/AssemblyHelpers.h:
(JSC::AssemblyHelpers::copyCalleeSavesFromFrameOrRegisterToVMCalleeSavesBuffer):
(JSC::AssemblyHelpers::restoreCalleeSavesFromVMCalleeSavesBuffer): Deleted.
- tests/stress/ftl-put-by-id-setter-exception-interesting-live-state.js:
(foo):
- 10:48 AM Changeset in webkit [194771] by
-
- 7 edits2 copies in trunk
Modern IDB: imported/w3c/indexeddb/idbobjectstore_createIndex6-event_order.htm fails.
https://bugs.webkit.org/show_bug.cgi?id=152891
Reviewed by Alex Christensen.
LayoutTests/imported/w3c:
- indexeddb/idbobjectstore_createIndex6-event_order-expected.txt:
- indexeddb/idbobjectstore_createIndex7-event_order-expected.txt:
Source/WebCore:
No new tests (At least two failing tests now pass).
- Modules/indexeddb/client/IDBRequestImpl.cpp:
(WebCore::IDBClient::IDBRequest::dispatchEvent): Whenever we add the IDBTransaction as an event target,
also add the IDBDatabase.
LayoutTests:
- platform/mac-wk1/TestExpectations:
- platform/wk2/imported/w3c/indexeddb/idbobjectstore_createIndex6-event_order-expected.txt: Copied from LayoutTests/imported/w3c/indexeddb/idbobjectstore_createIndex6-event_order-expected.txt.
- platform/wk2/imported/w3c/indexeddb/idbobjectstore_createIndex7-event_order-expected.txt: Copied from LayoutTests/imported/w3c/indexeddb/idbobjectstore_createIndex7-event_order-expected.txt.
- 10:44 AM Changeset in webkit [194770] by
-
- 16 edits in trunk/Source/JavaScriptCore
Rolling out: Rename StringFromCharCode to StringFromSingleCharCode.
https://bugs.webkit.org/show_bug.cgi?id=152897
Not reviewed.
- dfg/DFGAbstractInterpreterInlines.h:
(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::handleIntrinsicCall):
- dfg/DFGClobberize.h:
(JSC::DFG::clobberize):
- dfg/DFGDoesGC.cpp:
(JSC::DFG::doesGC):
- dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
- dfg/DFGNodeType.h:
- dfg/DFGOperations.cpp:
- dfg/DFGOperations.h:
- dfg/DFGPredictionPropagationPhase.cpp:
(JSC::DFG::PredictionPropagationPhase::propagate):
- dfg/DFGSafeToExecute.h:
(JSC::DFG::safeToExecute):
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileFromCharCode):
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- runtime/StringConstructor.cpp:
(JSC::stringFromCharCode):
(JSC::stringFromSingleCharCode): Deleted.
- runtime/StringConstructor.h:
- 10:20 AM Changeset in webkit [194769] by
-
- 2 edits in trunk/Source/JavaScriptCore
[JSC] Use std::call_once instead of pthread_once when initializing LLVM.
https://bugs.webkit.org/show_bug.cgi?id=152893
Reviewed by Mark Lam.
Use std::call_once since pthreads is not present on all platforms.
- llvm/InitializeLLVM.cpp:
(JSC::initializeLLVMImpl):
(JSC::initializeLLVM):
- 10:20 AM Changeset in webkit [194768] by
-
- 2 edits in trunk/Tools
run-webkit-tests mis-counts totals when there are other crashes
https://bugs.webkit.org/show_bug.cgi?id=152894
<rdar://problem/24098697>
Reviewed by Alexey Proskuryakov.
- Scripts/webkitpy/layout_tests/models/test_run_results.py:
(TestRunResults.add): Do not update result counters for other crashes.
- 10:10 AM Changeset in webkit [194767] by
-
- 16 edits in trunk/Source/JavaScriptCore
Rename StringFromCharCode to StringFromSingleCharCode.
https://bugs.webkit.org/show_bug.cgi?id=152897
Reviewed by Daniel Bates.
StringFromSingleCharCode is a better name because the intrinsic it represents
only applies when we are converting from a single char code. This is purely
a refactoring patch. There is no semantic change.
- dfg/DFGAbstractInterpreterInlines.h:
(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::handleIntrinsicCall):
- dfg/DFGClobberize.h:
(JSC::DFG::clobberize):
- dfg/DFGDoesGC.cpp:
(JSC::DFG::doesGC):
- dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
- dfg/DFGNodeType.h:
- dfg/DFGOperations.cpp:
- dfg/DFGOperations.h:
- dfg/DFGPredictionPropagationPhase.cpp:
(JSC::DFG::PredictionPropagationPhase::propagate):
- dfg/DFGSafeToExecute.h:
(JSC::DFG::safeToExecute):
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileFromCharCode):
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- runtime/StringConstructor.cpp:
(JSC::stringFromCharCode):
(JSC::stringFromSingleCharCode):
- runtime/StringConstructor.h:
- 8:55 AM Changeset in webkit [194766] by
-
- 2 edits in trunk/Source/JavaScriptCore
[mips] Fixed unused parameter warnings
https://bugs.webkit.org/show_bug.cgi?id=152885
Patch by Konstantin Tokarev <Konstantin Tokarev> on 2016-01-08
Reviewed by Mark Lam.
- jit/CCallHelpers.h:
(JSC::CCallHelpers::setupArgumentsWithExecState):
- 8:51 AM Changeset in webkit [194765] by
-
- 2 edits in trunk/LayoutTests
Modern IDB: storage/indexeddb/dont-wedge.html is flaky.
https://bugs.webkit.org/show_bug.cgi?id=152892
Unreviewed.
- platform/mac-wk1/TestExpectations: Skip it for now.
- 8:37 AM Changeset in webkit [194764] by
-
- 2 edits in trunk/Source/JavaScriptCore
[mips] Max value of immediate arg of logical ops is 0xffff
https://bugs.webkit.org/show_bug.cgi?id=152884
Patch by Konstantin Tokarev <Konstantin Tokarev> on 2016-01-08
Reviewed by Michael Saboff.
Replaced imm.m_value < 65535 checks with imm.m_value <= 65535
- assembler/MacroAssemblerMIPS.h:
(JSC::MacroAssemblerMIPS::and32):
(JSC::MacroAssemblerMIPS::or32):
- 8:28 AM Changeset in webkit [194763] by
-
- 2 edits in trunk/Source/JavaScriptCore
[mips] Add new or32 implementation after r194613
https://bugs.webkit.org/show_bug.cgi?id=152865
Patch by Konstantin Tokarev <Konstantin Tokarev> on 2016-01-08
Reviewed by Michael Saboff.
- assembler/MacroAssemblerMIPS.h:
(JSC::MacroAssemblerMIPS::or32):
- 4:17 AM WebKitGTK/Gardening/Howto edited by
- (diff)
- 1:06 AM Changeset in webkit [194762] by
-
- 12 edits in trunk/Source/WebCore
Enable selector filtering for shadow trees
https://bugs.webkit.org/show_bug.cgi?id=152831
Reviewed by Simon Fraser.
Selector filtering doesn't currently work in shadow trees making style resolve for them slow.
This is because SelectorFilter is not in "consistent" state.
This patch moves SelectorFilter ownership from StyleResolver to TreeResolver and guarantees
it is always upadated consistently. It eliminates a bunch of now unnecessary consistency checks
and special cases.
- css/ElementRuleCollector.cpp:
(WebCore::ElementRuleCollector::ElementRuleCollector):
Assert for consistency instead of testing for it.
(WebCore::ElementRuleCollector::matchedResult):
(WebCore::ElementRuleCollector::collectMatchingRulesForList):
Selector filter can now be used if it exists.
- css/ElementRuleCollector.h:
(WebCore::ElementRuleCollector::ElementRuleCollector): Deleted.
- css/RuleSet.cpp:
(WebCore::RuleSet::addRule):
Disable selector filtering for custom shadow pseudo rules. They are resolved by shadow DOM resolver
but may contain components matching the normal DOM.
- css/RuleSet.h:
(WebCore::RuleData::descendantSelectorIdentifierHashes):
(WebCore::RuleData::disableSelectorFiltering):
(WebCore::RuleData::compilationStatus):
(WebCore::RuleData::compiledSelectorCodeRef):
- css/SelectorFilter.cpp:
(WebCore::collectElementIdentifierHashes):
(WebCore::SelectorFilter::parentStackIsConsistent):
New consistency conditions. This is now used for asserts only.
(WebCore::SelectorFilter::pushParentStackFrame):
(WebCore::SelectorFilter::popParentStackFrame):
Selector filter only filters the current tree context, replace parentOrShadowHostElement with parentElement.
(WebCore::SelectorFilter::setupParentStack): Deleted.
No longer needed.
(WebCore::SelectorFilter::pushParent):
Remove consistency check. These cases no longer happen.
- css/SelectorFilter.h:
(WebCore::SelectorFilter::popParent):
(WebCore::SelectorFilter::parentStackIsEmpty):
(WebCore::SelectorFilter::fastRejectSelector):
(WebCore::SelectorFilter::parentStackIsConsistent): Deleted.
- css/StyleInvalidationAnalysis.cpp:
(WebCore::StyleInvalidationAnalysis::invalidateIfNeeded):
(WebCore::StyleInvalidationAnalysis::invalidateStyle):
- css/StyleResolver.cpp:
(WebCore::StyleResolver::appendAuthorStyleSheets):
(WebCore::StyleResolver::addKeyframeStyle):
(WebCore::StyleResolver::initElement):
(WebCore::StyleResolver::State::initForStyleResolve):
We no longer owner the selector filter. Move it to State.
(WebCore::StyleResolver::styleSharingCandidateMatchesRuleSet):
(WebCore::isAtShadowBoundary):
(WebCore::StyleResolver::styleForElement):
(WebCore::StyleResolver::pseudoStyleForElement):
(WebCore::StyleResolver::pseudoStyleRulesForElement):
(WebCore::StyleResolver::pushParentElement): Deleted.
(WebCore::StyleResolver::popParentElement): Deleted.
No need for this logic.
- css/StyleResolver.h:
(WebCore::StyleResolver::ruleSets):
(WebCore::StyleResolver::mediaQueryEvaluator):
(WebCore::StyleResolver::State::document):
(WebCore::StyleResolver::State::setAuthorRollback):
(WebCore::StyleResolver::State::setUserRollback):
(WebCore::StyleResolver::State::selectorFilter):
(WebCore::StyleResolver::state):
(WebCore::checkRegionSelector):
(WebCore::StyleResolver::selectorFilter): Deleted.
(WebCore::StyleResolverParentPusher::StyleResolverParentPusher): Deleted.
(WebCore::StyleResolverParentPusher::push): Deleted.
(WebCore::StyleResolverParentPusher::~StyleResolverParentPusher): Deleted.
- style/StyleTreeResolver.cpp:
This now owns the selector filter for a tree context.
(WebCore::Style::SelectorFilterPusher::SelectorFilterPusher):
(WebCore::Style::SelectorFilterPusher::push):
(WebCore::Style::SelectorFilterPusher::~SelectorFilterPusher):
(WebCore::Style::TreeResolver::TreeResolver):
(WebCore::Style::TreeResolver::styleForElement):
(WebCore::Style::TreeResolver::createRenderTreeForSlotAssignees):
(WebCore::Style::TreeResolver::createRenderTreeRecursively):
(WebCore::Style::TreeResolver::resolveChildren):
(WebCore::Style::TreeResolver::resolveRecursively):
Push the filter in a few more places to keep it consistent in shadow trees.
- style/StyleTreeResolver.h:
- 12:36 AM Changeset in webkit [194761] by
-
- 8 edits1 add in trunk/Tools
webkit-patch build-and-test should have an option to iterate over new tests
https://bugs.webkit.org/show_bug.cgi?id=143093
Reviewed by Michael Catanzaro.
This patch introduces the --iterate-on-new-tests option to webkit-patch build-and-test.
It allows running run-webkit-tests on modified or new paths in LayoutTests.
Computation of new or modified tests is done by LayoutTestFinder.find_touched_tests
It implements the translation of -expected.* paths to their related tests.
It also implements the removal of skipped tests.
- Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
(LayoutTestFinder.find_touched_tests):
- Scripts/webkitpy/layout_tests/controllers/layout_test_finder_unittest.py: Added.
(MockPort):
(MockPort.init):
(MockPort.tests):
(LayoutTestFinderTests):
(LayoutTestFinderTests.touched_files):
(LayoutTestFinderTests.test_touched_test):
(LayoutTestFinderTests.test_expected_touched_test):
(LayoutTestFinderTests.test_platform_expected_touched_test):
(LayoutTestFinderTests.test_platform_duplicate_touched_test):
(LayoutTestFinderTests.test_touched_but_skipped_test):
- Scripts/webkitpy/port/base.py:
(Port.potential_test_names_from_expected_file):
- Scripts/webkitpy/tool/commands/download_unittest.py:
(DownloadCommandsTest._default_options):
- Scripts/webkitpy/tool/steps/options.py:
(Options):
- Scripts/webkitpy/tool/steps/runtests.py:
(RunTests.options):
(RunTests.run):
(RunTests):
(RunTests._new_or_modified_tests):
(RunTests._run_webkit_tests):
- Scripts/webkitpy/tool/steps/runtests_unittest.py:
(RunTestsTest.test_webkit_run_unit_tests):
- Scripts/webkitpy/tool/steps/steps_unittest.py:
(StepsTest._step_options):
Jan 7, 2016:
- 10:17 PM Changeset in webkit [194760] by
-
- 5 edits in branches/safari-601.1.46-branch/Source
Versioning.
- 10:17 PM Changeset in webkit [194759] by
-
- 5 edits in branches/safari-601-branch/Source
Versioning.
- 9:33 PM Changeset in webkit [194758] by
-
- 2 edits in trunk/LayoutTests
Unreviewed IndexedDB test gardening.
- platform/mac-wk1/TestExpectations:
- 8:56 PM Changeset in webkit [194757] by
-
- 6 edits in trunk/Source/WebCore
Move computeLineBoundsForText from GraphicsContext* to GraphicsContext.
https://bugs.webkit.org/show_bug.cgi?id=152882
Reviewed by Simon Fraser.
There is nothing platform specific about it.
No change in functionality.
- platform/graphics/GraphicsContext.cpp:
(WebCore::GraphicsContext::computeUnderlineBoundsForText): Rename to reflect its usage.
- platform/graphics/GraphicsContext.h:
- platform/graphics/cairo/GraphicsContextCairo.cpp:
(WebCore::GraphicsContext::computeLineBoundsForText): Deleted.
- platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::GraphicsContext::drawLinesForText):
(WebCore::GraphicsContext::computeLineBoundsForText): Deleted.
- rendering/TextDecorationPainter.cpp:
(WebCore::drawSkipInkUnderline):
- 8:29 PM Changeset in webkit [194756] by
-
- 5 edits in trunk/PerformanceTests
Fix new test.
- Animometer/resources/runner/tests.js: Wrong URL from an
old patch.
- Animometer/tests/master/particles.html:
- Animometer/tests/master/resources/dom-particles.js:
(Particle.call.reset): Figured out a simpler way to set up
the particles.
(this.move.reset): Deleted.
(this.move._applyAttributes): Deleted.
- Animometer/tests/master/resources/particles.js:
(Particle): Call move() after reset().
- 8:28 PM Changeset in webkit [194755] by
-
- 3 edits4 adds in trunk/PerformanceTests
Update benchmark test suite
https://bugs.webkit.org/show_bug.cgi?id=152679
Reviewed by Simon Fraser.
Add a new test. The test has a rotating background
gradient, and does a better job physically simulating
particles.
- Animometer/resources/extensions.js: Teach Point to take constants as well as other Points.
(Point.prototype.length): Added.
(Point.prototype.normalize): Added.
- Animometer/resources/runner/tests.js: Add the test to the master suite.
- Animometer/tests/master/particles.html: Added.
- Animometer/tests/master/resources/particles.js: Added. Parent class for different kinds of particles.
(Particle):
(Particle.prototype.reset): If the particle starts slowing down in terms of its animation,
reset it.
(Particle.prototype.animate): Bounce off the walls elastically, and include gravity.
(Particle.prototype.move): Subclasses should override.
(ParticlesStage): Stage includes a rotating gradient background.
- Animometer/tests/master/resources/dom-particles.js: Added. Creates a <div> and adds it to
the stage.
- Animometer/tests/resources/star.svg: Added.
- 8:08 PM Changeset in webkit [194754] by
-
- 6 edits in trunk
Modern IDB: Success-after-open event should only have the IDBOpenDBRequest as its target.
https://bugs.webkit.org/show_bug.cgi?id=152875
Reviewed by Alex Christensen.
Source/WebCore:
No new tests (At least 2 failing tests now pass).
- Modules/indexeddb/client/IDBOpenDBRequestImpl.cpp:
(WebCore::IDBClient::IDBOpenDBRequest::fireSuccessAfterVersionChangeCommit):
- Modules/indexeddb/client/IDBRequestImpl.cpp:
(WebCore::IDBClient::IDBRequest::dispatchEvent): Only add the transaction and database as potential
targets for this event if it is *not* the success-after-open event.
- Modules/indexeddb/client/IDBRequestImpl.h:
LayoutTests:
- platform/mac-wk1/TestExpectations:
- 7:58 PM Changeset in webkit [194753] by
-
- 20 edits3 moves in trunk/PerformanceTests
Update benchmark test suite
https://bugs.webkit.org/show_bug.cgi?id=152679
Reviewed by Simon Fraser.
Move algorithm.js and sampler.js to tests/ and benchmark-runner.js to runner/.
Needed by both harnesses.
- Animometer/resources/runner/benchmark-runner.js: Renamed from PerformanceTests/Animometer/resources/debug-runner/benchmark-runner.js.
- Animometer/developer.html:
- Animometer/index.html:
Needed only by the tests. Move to tests/. Statistics, in sampler.js, is used by ResultsDashboard, so move that
into extensions.js.
- Animometer/resources/extensions.js:
- Animometer/tests/resources/algorithm.js: Renamed from PerformanceTests/Animometer/resources/algorithm.js.
- Animometer/tests/resources/sampler.js: Renamed from PerformanceTests/Animometer/resources/sampler.js.
- Animometer/tests/bouncing-particles/bouncing-canvas-images.html:
- Animometer/tests/bouncing-particles/bouncing-canvas-shapes.html:
- Animometer/tests/bouncing-particles/bouncing-css-images.html:
- Animometer/tests/bouncing-particles/bouncing-css-shapes.html:
- Animometer/tests/bouncing-particles/bouncing-svg-images.html:
- Animometer/tests/bouncing-particles/bouncing-svg-shapes.html:
- Animometer/tests/master/canvas-stage.html:
- Animometer/tests/misc/canvas-electrons.html:
- Animometer/tests/misc/canvas-stars.html:
- Animometer/tests/misc/compositing-transforms.html:
- Animometer/tests/simple/simple-canvas-paths.html:
- Animometer/tests/template/template-canvas.html:
- Animometer/tests/template/template-css.html:
- Animometer/tests/template/template-svg.html:
- Animometer/tests/text/layering-text.html:
- Animometer/tests/text/text-boxes.html:
- 7:54 PM Changeset in webkit [194752] by
-
- 3 edits in trunk/PerformanceTests
Update benchmark test suite
https://bugs.webkit.org/show_bug.cgi?id=152679
Reviewed by Simon Fraser.
Fix tests for other browsers.
- Animometer/resources/extensions.js:
(Point.elementClientSize): Some browsers return 0 for SVG clientWidth and clientHeight.
Use getBoundingClientRect() instead.
- Animometer/tests/misc/resources/canvas-electrons.js:
(CanvasElectron.prototype._draw): Some browsers don't support ellipse.
- 6:51 PM Changeset in webkit [194751] by
-
- 4 edits in trunk/Source/WebCore
Correct missing EXT_sRGB Format Handling
https://bugs.webkit.org/show_bug.cgi?id=152876
<rdar://problem/23284389>
Reviewed by Alex Christensen.
Tested by WebGL 1.0.4 suite.
- platform/graphics/GraphicsContext3D.cpp:
(getDataFormat): Handle missing SRGB and SRGB_ALPHA cases.
- platform/graphics/GraphicsContext3D.h: Add missing SRGB_ALPHA value from the Khronos standard.
- platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:
(WebCore::GraphicsContext3D::texImage2D): Add an assertion that we are not being handed
an internal format to a method that works with normal formats.
- 6:33 PM Changeset in webkit [194750] by
-
- 5 edits in trunk/Source
Use an appropriate buffer format for swipe snapshots
https://bugs.webkit.org/show_bug.cgi?id=152880
rdar://problem/23728299
Reviewed by Tim Horton.
Source/WebCore:
Choose an appropriate buffer format for swipe snapshots, and avoid converting
them to YUV422.
- platform/graphics/cocoa/IOSurface.h:
- platform/graphics/cocoa/IOSurface.mm:
(IOSurface::allowConversionFromFormatToFormat):
Source/WebKit2:
Choose an appropriate buffer format for swipe snapshots, and avoid converting
them to YUV422.
- UIProcess/API/Cocoa/WKWebView.mm:
(WebKit::bufferFormat):
(-[WKWebView _takeViewSnapshot]):
- 6:18 PM Changeset in webkit [194749] by
-
- 2 edits1 add in trunk/Tools
prepare-ChangeLog should include radar number
https://bugs.webkit.org/show_bug.cgi?id=152839
<rdar://problem/24093563>
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-01-07
Reviewed by Daniel Bates.
When running
prepare-ChangeLog -b ###, check for a bugzilla comment that
starts with a "<rdar://problem/####>" URL. If found, include that radar URL
in the ChangeLog description after the bug URL.
- Scripts/prepare-ChangeLog:
(main): Update signatures.
(fetchBugXMLData): XML Data is now used for multiple reasons. Extract this to just get the data.
(fetchBugDescriptionFromBugXMLData): Search data for <short_desc>.
(fetchRadarURLFromBugXMLData): Search comment text for radar URL.
(generateNewChangeLogs): Include radar URL if we found one.
- Scripts/webkitperl/prepare-ChangeLog_unittest/fetchRadarURLFromBugXMLData.pl: Added.
Tests for the radar URL extraction.
- 5:52 PM Changeset in webkit [194748] by
-
- 2 edits1 add in trunk/Source/JavaScriptCore
FTL B3 lazy slow paths should do exceptions
https://bugs.webkit.org/show_bug.cgi?id=152853
Reviewed by Saam Barati.
This reduces the number of JSC test failures to 97.
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::DFG::LowerDFGToLLVM::lazySlowPath):
- tests/stress/ftl-new-negative-array-size.js: Added.
(foo):
- 5:38 PM Changeset in webkit [194747] by
-
- 3 edits in trunk/Source/JavaScriptCore
Unreviewed, skip more tests that fail.
- tests/stress/ftl-shr-exception.js:
(foo):
- tests/stress/ftl-xor-exception.js:
(foo):
- 5:10 PM Changeset in webkit [194746] by
-
- 2 edits3 adds in trunk/Source/JavaScriptCore
FTL B3 binary snippets should do exceptions
https://bugs.webkit.org/show_bug.cgi?id=152852
Reviewed by Saam Barati.
This reduces the number of JSC test failures to 110.
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::DFG::LowerDFGToLLVM::emitBinarySnippet):
(JSC::FTL::DFG::LowerDFGToLLVM::emitBinaryBitOpSnippet):
(JSC::FTL::DFG::LowerDFGToLLVM::emitRightShiftSnippet):
- tests/stress/ftl-shr-exception.js: Added.
(foo):
(result.foo.valueOf):
- tests/stress/ftl-sub-exception.js: Added.
(foo):
(result.foo.valueOf):
- tests/stress/ftl-xor-exception.js: Added.
(foo):
(result.foo.valueOf):
- 5:05 PM Changeset in webkit [194745] by
-
- 3 edits in trunk/Source/WebCore
[EME] Secure stop information not written to disk
https://bugs.webkit.org/show_bug.cgi?id=152855
Reviewed by Eric Carlson.
Two separate bugs for the two APIs provided by AVFoundation. For the AVStreamSession path,
we were not calling the lazy-creation function which creates the AVStreamSession, and were
rather accessing the ivar directly. For the AVContentKeySession, we were not creating the
intermediate paths containing the secure stop database.
- platform/graphics/avfoundation/objc/CDMSessionAVContentKeySession.mm:
(WebCore::CDMSessionAVContentKeySession::contentKeySession):
- platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::setCDMSession):
- 4:34 PM Changeset in webkit [194744] by
-
- 2 edits in trunk/Source/JavaScriptCore
Unreviewed, skipping this test. Looks like LLVM can't handle this one, either.
- tests/stress/ftl-call-varargs-bad-args-exception-interesting-live-state.js:
(foo):
- 4:10 PM Changeset in webkit [194743] by
-
- 4 edits in trunk/PerformanceTests
Add a waitUntilReady() step
https://bugs.webkit.org/show_bug.cgi?id=152862
Reviewed by Simon Fraser.
Add a waitUntilReady() callback that lets the benchmark complete
its setup before running the benchmark.
- Animometer/tests/resources/main.js:
(Benchmark.prototype.run): First call waitUntilReady, which returns
a promise. When the promise resolves, run everything that was in this
function.
(Benchmark.prototype.waitUntilReady): Default implementation returns
a resolved promise.
(Benchmark.prototype.resolveWhenFinished): Deleted.
- Animometer/tests/template/resources/template-canvas.js:
(new.TemplateCanvasStage.waitUntilReady): Example on how to override.
- 4:08 PM Changeset in webkit [194742] by
-
- 1 copy in tags/Safari-601.1.46.91
New Tag.
- 4:07 PM Changeset in webkit [194741] by
-
- 1 copy in tags/Safari-601.5.9
New Tag.
- 4:00 PM Changeset in webkit [194740] by
-
- 2 edits in trunk/Source/JavaScriptCore
Unreviewed, skipping this test. Looks like LLVM can't handle it.
- tests/stress/ftl-put-by-id-setter-exception-interesting-live-state.js:
(foo):
- 3:47 PM Changeset in webkit [194739] by
-
- 3 edits9 adds in trunk/Source/JavaScriptCore
FTL B3 JS calls should do exceptions
https://bugs.webkit.org/show_bug.cgi?id=152851
Reviewed by Geoffrey Garen.
This reduces the number of JSC test failures with FTL B3 to 111.
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::emitCall):
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::DFG::LowerDFGToLLVM::compileCallOrConstruct):
(JSC::FTL::DFG::LowerDFGToLLVM::compileTailCall):
(JSC::FTL::DFG::LowerDFGToLLVM::compileCallOrConstructVarargs):
- tests/stress/ftl-call-bad-args-exception-interesting-live-state.js: Added.
- tests/stress/ftl-call-bad-callee-exception-interesting-live-state.js: Added.
- tests/stress/ftl-call-exception-interesting-live-state.js: Added.
- tests/stress/ftl-call-exception-no-catch.js: Added.
- tests/stress/ftl-call-exception.js: Added.
- tests/stress/ftl-call-varargs-bad-callee-exception-interesting-live-state.js: Added.
- tests/stress/ftl-call-varargs-exception-interesting-live-state.js: Added.
- tests/stress/ftl-call-varargs-exception-no-catch.js: Added.
- tests/stress/ftl-call-varargs-exception.js: Added.
- 3:47 PM Changeset in webkit [194738] by
-
- 4 edits in trunk/Websites/perf.webkit.org
Perf dashboard should automatically add aggregators
https://bugs.webkit.org/show_bug.cgi?id=152818
Reviewed by Chris Dumez.
When an aggregator entry is missing in aggregators table, automatically insert it in /api/report.
In a very early version of the perf dashboard, we had the ability to define a custom aggregator
in an admin page. In practice, nobody used or needed this feature so we got rid of it even before
the dashboard was landed into WebKit repository. This patch cleans up that mess.
- run-tests.js:
(main): Added the filtering capability.
(TestEnvironment): Expose the config JSON in the test environment.
- public/include/report-processor.php:
(ReportProcessor): Renamed name_to_aggregator now that it only contains ID.
(ReportProcessor::construct): No longer fetches the aggregator table. An equivalent work is done
in newly added ensure_aggregators.
(ReportProcessor::process): Calls ensure_aggregators which populates name_to_aggregator_id.
(ReportProcessor::ensure_aggregators): Added. Add the builtin aggregators: Arithmetic, Geometric,
Harmonic, and Total.
(TestRunsGenerator): Renamed name_to_aggregator now that it only contains ID.
(TestRunsGenerator::construct):
(TestRunsGenerator::add_aggregated_metric): Don't include aggregator_definition here since it's
never used now that all the aggregations are done natively in PHP.
(TestRunsGenerator::$aggregators): Added. We don't include SquareSum since it's only used for
computing run_square_sum_cache in test_runs table and it's useless elsewhere.
(TestRunsGenerator::aggregate_values): Add a comment about that.
- tests/api-report.js: Updated a test case to reflect the change.
- 3:44 PM Changeset in webkit [194737] by
-
- 7 edits in trunk/Source/WebInspectorUI
Web Inspector: Add warnings to section that require specific values of other properties
https://bugs.webkit.org/show_bug.cgi?id=148254
Patch by Devin Rousso <Devin Rousso> on 2016-01-07
Reviewed by Timothy Hatcher.
Added a function to VisualStylePropertyEditor to allow dependencies to be set which,
whenever the editor is updated or changed, will be checked against the computed styles
of the element to see if all the necessary property values are set.
- Localizations/en.lproj/localizedStrings.js:
- UserInterface/Views/VisualStyleDetailsPanel.js:
(WebInspector.VisualStyleDetailsPanel):
(WebInspector.VisualStyleDetailsPanel.prototype.refresh):
(WebInspector.VisualStyleDetailsPanel.prototype._populatePositionSection):
(WebInspector.VisualStyleDetailsPanel.prototype._populateFlexboxSection):
(WebInspector.VisualStyleDetailsPanel.prototype._populateAlignmentSection):
(WebInspector.VisualStyleDetailsPanel.prototype._populateBorderSection):
(WebInspector.VisualStyleDetailsPanel.prototype._populateOutlineSection):
Added dependencies to relevant property editors.
(WebInspector.VisualStyleDetailsPanel.prototype._prepareForChange): Deleted.
No longer needed as the sidebar panel will refresh whenever triggered.
- UserInterface/Views/VisualStylePropertyEditor.css:
(.visual-style-property-container.layout-reversed > .visual-style-property-title):
(.visual-style-property-container > .visual-style-property-title > .property-reference-info):
(.visual-style-property-container > .visual-style-property-editor-warning):
(.visual-style-property-container.layout-reversed > .visual-style-property-editor-warning):
(.visual-style-property-container > .visual-style-property-editor-warning.missing-dependency):
(.visual-style-property-container > .visual-style-property-value-container):
(.visual-style-property-container.layout-reversed > .visual-style-property-value-container):
- UserInterface/Views/VisualStylePropertyEditor.js:
(WebInspector.VisualStylePropertyEditor):
(WebInspector.VisualStylePropertyEditor.prototype.updateEditorValues):
(WebInspector.VisualStylePropertyEditor.prototype.addDependency):
(WebInspector.VisualStylePropertyEditor.prototype._valueDidChange):
(WebInspector.VisualStylePropertyEditor.prototype._checkDependencies):
Looks at the computed style for the node to see if any dependent properties do not
have one of the required values.
- UserInterface/Views/VisualStyleSelectorSection.js:
(WebInspector.VisualStyleSelectorSection.prototype.update.createSelectorItem):
(WebInspector.VisualStyleSelectorSection.prototype._styleTextReset): Deleted.
- UserInterface/Views/VisualStyleSelectorTreeItem.js:
(WebInspector.VisualStyleSelectorTreeItem.prototype._handleContextMenuEvent):
- 3:33 PM Changeset in webkit [194736] by
-
- 2 edits in trunk/Source/WebCore
Use wavy offset for decoration painting when line style is TextDecorationStyleWavy.
https://bugs.webkit.org/show_bug.cgi?id=152856
Reviewed by Simon Fraser.
No change in functionality.
- rendering/TextDecorationPainter.cpp:
(WebCore::TextDecorationPainter::paintTextDecoration):
- 3:32 PM Changeset in webkit [194735] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Allow error items on Exception page to be selected
https://bugs.webkit.org/show_bug.cgi?id=152861
Patch by Devin Rousso <Devin Rousso> on 2016-01-07
Reviewed by Brian Burg.
- UserInterface/Debug/UncaughtExceptionReporter.css:
(.uncaught-exception-sheet li):
Allowed user-select on text.
- 3:32 PM Changeset in webkit [194734] by
-
- 2 edits in trunk/LayoutTests
Better test gardening. Only skip those tests that use touch events, not the whole
directory.
- platform/ios-simulator-wk2/TestExpectations:
- 3:30 PM Changeset in webkit [194733] by
-
- 4 edits in trunk
Modern IDB: Various imported/w3c/indexeddb tests fail due to expecting the wrong exception.
https://bugs.webkit.org/show_bug.cgi?id=152866
Reviewed by Alex Christensen.
Source/WebCore:
No new tests (5 skipped tests now pass).
- Modules/indexeddb/client/IDBObjectStoreImpl.cpp:
(WebCore::IDBClient::IDBObjectStore::putOrAdd): Reorder the exceptions, violating the spec but matching
a vast majority of browsers.
(WebCore::IDBClient::IDBObjectStore::deleteFunction): Ditto.
(WebCore::IDBClient::IDBObjectStore::clear): Ditto.
(WebCore::IDBClient::IDBObjectStore::doCount): Ditto.
LayoutTests:
- platform/mac-wk1/TestExpectations:
- 3:26 PM Changeset in webkit [194732] by
-
- 2 edits in trunk/LayoutTests
Test gardening.
- platform/ios-simulator-wk2/TestExpectations:
- 3:15 PM Changeset in webkit [194731] by
-
- 5 edits in trunk/Source/WebCore
Remove unused shouldAntialias parameter from GraphicsContext::computeLineBoundsAndAntialiasingModeForText()
https://bugs.webkit.org/show_bug.cgi?id=152859
Reviewed by Simon Fraser.
No change in functionality.
- platform/graphics/GraphicsContext.cpp:
(WebCore::GraphicsContext::computeLineBoundsAndAntialiasingModeForText):
- platform/graphics/GraphicsContext.h:
- platform/graphics/cairo/GraphicsContextCairo.cpp:
(WebCore::GraphicsContext::computeLineBoundsForText):
(WebCore::GraphicsContext::drawLinesForText):
- platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::GraphicsContext::computeLineBoundsForText):
(WebCore::GraphicsContext::drawLinesForText):
- 2:59 PM Changeset in webkit [194730] by
-
- 2 edits6 adds in trunk/Source/JavaScriptCore
FTL B3 PutById should do exceptions
https://bugs.webkit.org/show_bug.cgi?id=152850
Reviewed by Saam Barati.
Implemented PutById exception handling by following the idiom used in GetById. Reduces the
number of JSC test failures to 128.
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::DFG::LowerDFGToLLVM::compilePutById):
- tests/stress/ftl-put-by-id-setter-exception-interesting-live-state.js: Added.
- tests/stress/ftl-put-by-id-setter-exception-no-catch.js: Added.
- tests/stress/ftl-put-by-id-setter-exception.js: Added.
- tests/stress/ftl-put-by-id-slow-exception-interesting-live-state.js: Added.
- tests/stress/ftl-put-by-id-slow-exception-no-catch.js: Added.
- tests/stress/ftl-put-by-id-slow-exception.js: Added.
- 2:42 PM Changeset in webkit [194729] by
-
- 3 edits in trunk/Source/JavaScriptCore
Unreviewed, rolling out r194714.
https://bugs.webkit.org/show_bug.cgi?id=152864
it broke many JSC tests when FTL B3 is enabled (Requested by
pizlo on #webkit).
Reverted changeset:
"[JSC] When resolving Stack arguments, use addressing from SP
when addressing from FP is invalid"
https://bugs.webkit.org/show_bug.cgi?id=152840
http://trac.webkit.org/changeset/194714
- 2:36 PM Changeset in webkit [194728] by
-
- 10 edits in trunk/Source/WebInspectorUI
Web Inspector: Add border-image properties to Visual sidebar
https://bugs.webkit.org/show_bug.cgi?id=152755
Patch by Devin Rousso <Devin Rousso> on 2016-01-07
Reviewed by Timothy Hatcher.
- Localizations/en.lproj/localizedStrings.js:
- UserInterface/Main.html:
Switched the order of VisualStyleURLInput and VisualStyleUnitSlider
to be ordered alphabetically.
- UserInterface/Views/VisualStyleBackgroundPicker.js:
(WebInspector.VisualStyleBackgroundPicker.prototype._keywordSelectMouseDown):
- UserInterface/Views/VisualStyleDetailsPanel.css:
(.sidebar > .panel.details.css-style .visual > .details-section .details-section > .content > .group + .group > .row:first-child):
(.sidebar > .panel.details.css-style .visual > .details-section.background .details-section.border .visual-style-property-container.keyword-checkbox.border-image-slice):
Since the checkbox is so small, give it less room.
- UserInterface/Views/VisualStyleDetailsPanel.js:
(WebInspector.VisualStyleDetailsPanel.prototype._populateBorderSection.generateBorderImagePropertyEditors):
The three properties "border-image-width", "border-image-outset", and
"border-image-slice" all have the same syntax, so one function to generate
the layout for all three is much simpler.
(WebInspector.VisualStyleDetailsPanel.prototype._populateBorderSection):
Added the border image properties to a seperate group under Background > Border.
- UserInterface/Views/VisualStyleKeywordPicker.js:
(WebInspector.VisualStyleKeywordPicker.prototype._keywordSelectMouseDown):
- UserInterface/Views/VisualStyleNumberInputBox.js:
(WebInspector.VisualStyleNumberInputBox):
(WebInspector.VisualStyleNumberInputBox.prototype.set units):
Reordered logic to allow a value of ""/null to set the units to the "Number"
value if it is allowed for that editor.
(WebInspector.VisualStyleNumberInputBox.prototype.get synthesizedValue):
Instead of relying upon whether the editor has any units, just check to see if
the selected units are "Number" and, if not, add them to the value.
(WebInspector.VisualStyleNumberInputBox.prototype._unitsElementTextContent):
- UserInterface/Views/VisualStylePropertyCombiner.js:
(WebInspector.VisualStylePropertyCombiner):
Now has another argument that, when true, assumes the combiner has at least 4
numerical values and is of the form (can have units):
property-name: value1 [value2 [value3 [value4 [...]]]];
(WebInspector.VisualStylePropertyCombiner.prototype.get synthesizedValue):
(WebInspector.VisualStylePropertyCombiner.prototype.updateValuesFromText.updateEditor):
(WebInspector.VisualStylePropertyCombiner.prototype.updateValuesFromText.updateCompatibleEditor):
(WebInspector.VisualStylePropertyCombiner.prototype.updateValuesFromText):
If the new argument is true, assigns the existing values in the following way:
- If there is 1 value, assign it to all of the editors.
- If there are 2 values, assign the 1st one to editors 1 and 3 and the 2nd one
to editors 2 and 4.
- If there are 3 values, assign the 1st one to editor 1, the 2nd one to editors
2 and 4, and the 3rd one to editor 3.
- If there are 4 or more values, assign them normally.
- UserInterface/Views/VisualStylePropertyEditor.js:
(WebInspector.VisualStylePropertyEditor.prototype.valueIsSupportedKeyword):
(WebInspector.VisualStylePropertyEditor.prototype._valueIsSupportedAdvancedKeyword):
Removed call to this.value to prevent recursion from VisualStyleNumberInputBox.
(WebInspector.VisualStylePropertyEditor.prototype.valueIsSupportedUnit):
(WebInspector.VisualStylePropertyEditor.prototype._valueIsSupportedAdvancedUnit):
Removed call to this.units to prevent recursion from VisualStyleNumberInputBox.
- 2:31 PM Changeset in webkit [194727] by
-
- 2 edits in trunk/Source/WebKit/mac
Can't play inline video in a stock WK1 WebView on Mac
https://bugs.webkit.org/show_bug.cgi?id=152860
Rubber-stamped by Jer Noble.
- WebView/WebPreferences.mm:
(+[WebPreferences initialize]):
The default for this preference is supposed to be NO on Mac. It is in
Settings.in, and in WebKit2, but this one place got it wrong.
- 2:17 PM Changeset in webkit [194726] by
-
- 4 edits in trunk
Modern IDB: imported/w3c/indexeddb/idbcursor-continue.htm fails.
https://bugs.webkit.org/show_bug.cgi?id=152849
Reviewed by Alex Christensen.
Source/WebCore:
No new tests (At least one failing test now passes).
- Modules/indexeddb/server/MemoryIndexCursor.cpp:
(WebCore::IDBServer::MemoryIndexCursor::iterate): Don't allow returning an iterator outside of
the cursor's assigned range.
LayoutTests:
- platform/mac-wk1/TestExpectations:
- 2:13 PM Changeset in webkit [194725] by
-
- 2 edits in trunk/Source/JavaScriptCore
[mips] Lower immediates of logical operations.
https://bugs.webkit.org/show_bug.cgi?id=152693
On MIPS immediate operands of andi, ori, and xori are required to be 16-bit
non-negative numbers.
Patch by Konstantin Tokarev <Konstantin Tokarev> on 2016-01-07
Reviewed by Michael Saboff.
- offlineasm/mips.rb:
- 2:13 PM Changeset in webkit [194724] by
-
- 1 copy in tags/Safari-602.1.15
New tag.
- 2:11 PM Changeset in webkit [194723] by
-
- 3 edits in trunk/Source/WebInspectorUI
Web Inspector: Add indicator that element has pseudo-class in DOM tree
https://bugs.webkit.org/show_bug.cgi?id=152680
Patch by Devin Rousso <Devin Rousso> on 2016-01-07
Reviewed by Timothy Hatcher.
- UserInterface/Views/DOMTreeElement.js:
(WebInspector.DOMTreeElement):
(WebInspector.DOMTreeElement.prototype._nodePseudoClassesDidChange):
Added an event listener to the node for when pseudo-classes change.
- UserInterface/Views/DOMTreeOutline.css:
(.dom-tree-outline li.pseudo-class-enabled > .selection::before):
(.dom-tree-outline:focus li.selected.pseudo-class-enabled > .selection::before):
Used the hover/selected background style element to ensure that the indicator
is always positioned evenly with the first line of the opening tag.
(.dom-tree-outline li.hovered:not(.selected) .selection):
(.dom-tree-outline li .selection):
(.dom-tree-outline li.selected .selection):
(.dom-tree-outline li.elements-drag-over .selection):
Removed "display: none;" (as well as the "block" declarations) to allow
the ::before pseudo-element to display.
- 2:10 PM Changeset in webkit [194722] by
-
- 5 edits in trunk/Source
Versioning.
- 2:09 PM Changeset in webkit [194721] by
-
- 11 edits in trunk
testRunner.runUIScript crashes while running multiple tests in a row that invokes the same UIScript
https://bugs.webkit.org/show_bug.cgi?id=152390
<rdar://problem/23948321>
Reviewed by Simon Fraser.
Tools:
Fix two use-after-frees.
- WKPageCallAfterNextPresentationUpdate's callback has a pointer to TestInvocation,
but we may have already progressed to another test by the time the callback fires,
having destroyed the TestInvocation.
- UIScriptController is a RefCounted object, but it has a raw pointer to
UIScriptContext which has the same lifetime as a TestInvocation.
As a result, completion blocks of UIScriptController actions would use a destroyed
TestInvocation.
- WebKitTestRunner/TestInvocation.cpp:
(WTR::TestInvocation::~TestInvocation):
(WTR::TestInvocation::url):
(WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
(WTR::TestInvocation::runUISideScriptAfterUpdateCallback):
(WTR::TestInvocation::runUISideScript):
- WebKitTestRunner/TestInvocation.h:
- WebKitTestRunner/UIScriptContext/UIScriptContext.cpp:
(UIScriptContext::UIScriptContext):
(UIScriptContext::~UIScriptContext):
(UIScriptContext::runUIScript):
- WebKitTestRunner/UIScriptContext/UIScriptContext.h:
- WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
(WTR::UIScriptController::UIScriptController):
(WTR::UIScriptController::contextDestroyed):
(WTR::UIScriptController::makeWindowObject):
(WTR::UIScriptController::setWillBeginZoomingCallback):
(WTR::UIScriptController::willBeginZoomingCallback):
(WTR::UIScriptController::setDidEndZoomingCallback):
(WTR::UIScriptController::didEndZoomingCallback):
(WTR::UIScriptController::setDidEndScrollingCallback):
(WTR::UIScriptController::didEndScrollingCallback):
(WTR::UIScriptController::setDidShowKeyboardCallback):
(WTR::UIScriptController::didShowKeyboardCallback):
(WTR::UIScriptController::setDidHideKeyboardCallback):
(WTR::UIScriptController::didHideKeyboardCallback):
(WTR::UIScriptController::uiScriptComplete):
- WebKitTestRunner/UIScriptContext/UIScriptController.h:
(WTR::UIScriptController::create):
- WebKitTestRunner/ios/UIScriptControllerIOS.mm:
(WTR::UIScriptController::doAsyncTask):
(WTR::UIScriptController::zoomToScale):
(WTR::UIScriptController::singleTapAtPoint):
(WTR::UIScriptController::doubleTapAtPoint):
(WTR::UIScriptController::typeCharacterUsingHardwareKeyboard):
(WTR::UIScriptController::contentVisibleRect):
(WTR::UIScriptController::platformSetWillBeginZoomingCallback):
(WTR::UIScriptController::platformSetDidEndZoomingCallback):
(WTR::UIScriptController::platformSetDidShowKeyboardCallback):
(WTR::UIScriptController::platformSetDidHideKeyboardCallback):
(WTR::UIScriptController::platformSetDidEndScrollingCallback):
- WebKitTestRunner/mac/UIScriptControllerMac.mm:
(WTR::UIScriptController::doAsyncTask):
LayoutTests:
- platform/ios-simulator/TestExpectations: Unskipped tests that used to be affected.
- 2:02 PM Changeset in webkit [194720] by
-
- 2 edits in trunk/Source/JavaScriptCore
[JSC] Update testCheckSubBadImm() for ARM64
https://bugs.webkit.org/show_bug.cgi?id=152846
Patch by Benjamin Poulain <bpoulain@apple.com> on 2016-01-07
Reviewed by Mark Lam.
- b3/testb3.cpp:
(JSC::B3::testCheckSubBadImm):
The test was assuming the constant can always be used
as immediate. That's obviously not the case on ARM64.
- 1:56 PM Changeset in webkit [194719] by
-
- 7 edits in branches/safari-601-branch/Source/WebCore
Fix the Mavericks build after r194287. rdar://problem/23769758
- 1:28 PM Changeset in webkit [194718] by
-
- 10 edits1 add in trunk/Source/WebKit2
Progress towards implementing downloads with NetworkSession
https://bugs.webkit.org/show_bug.cgi?id=152760
Reviewed by Brady Eidson.
- NetworkProcess/Downloads/Download.cpp:
(WebKit::Download::Download):
There's no need to store the unused NetworkSession&.
(WebKit::Download::didStart):
(WebKit::Download::didReceiveAuthenticationChallenge):
Downloads with NetworkSession are NetworkLoads until the response is received, which is after authentication
challenges are handled by NetworkLoad's code.
(WebKit::Download::didReceiveResponse):
- NetworkProcess/Downloads/Download.h:
- NetworkProcess/Downloads/DownloadManager.cpp:
(WebKit::DownloadManager::startDownload):
Create a PendingDownload, which is basically a NetworkLoad that knows that it will become a Download
when the response is received, regardless of whether or not there is a Content-Disposition header.
(WebKit::DownloadManager::dataTaskBecameDownloadTask):
- NetworkProcess/Downloads/DownloadManager.h:
- NetworkProcess/Downloads/PendingDownload.h: Added.
(WebKit::PendingDownload::PendingDownload):
Added a new NetworkLoadClient for requests that will become downloads.
A PendingDownload contains a NetworkLoad so we can always keep them together
and so it can handle setting its pending download id.
- WebKit2.xcodeproj/project.pbxproj:
- NetworkProcess/NetworkLoad.cpp:
(WebKit::NetworkLoad::NetworkLoad):
Avoid dereferencing a pointer if the NetworkSession hadn't been created when a NetworkLoad starts.
This shouldn't be possible, but it's good to not assume that all pointers are non-null.
(WebKit::NetworkLoad::cancel):
Add a null check in case the constructor doesn't make m_task.
(WebKit::NetworkLoad::convertTaskToDownload):
(WebKit::NetworkLoad::setPendingDownloadID):
Added for downloads that start with startDownload. The pending DownloadID is used to indicate that
this request should always become a download, regardless of whether or not the response has a
Content-Disposition header.
(WebKit::NetworkLoad::willPerformHTTPRedirection):
(WebKit::NetworkLoad::didReceiveResponse):
- NetworkProcess/NetworkLoad.h:
There's no need to store a DownloadID here. It's stored in the NetworkDataTask (m_task).
- NetworkProcess/NetworkSession.h:
(WebKit::NetworkDataTask::client):
(WebKit::NetworkDataTask::pendingDownloadID):
(WebKit::NetworkDataTask::setPendingDownloadID):
(WebKit::NetworkDataTask::downloadID): Deleted.
(WebKit::NetworkDataTask::setDownloadID): Deleted.
Renamed downloadID and setDownloadID to pendingDownloadID and setPendingDownloadID, respectively,
to indicate their use. They are not the current downloadID, but they are the downloadID of the download
that will happen once the response is received and PolicyDownload will be returned in the completion handler.
- NetworkProcess/cocoa/NetworkSessionCocoa.mm:
(-[WKNetworkSessionDelegate URLSession:dataTask:didBecomeDownloadTask:]):
Call dataTaskBecameDownloadTask after didBecomeDownload because the networkDataTask is deleted by removing it
from m_pendingDownloads in dataTaskBecameDownloadTask.
- 1:27 PM Changeset in webkit [194717] by
-
- 10 edits in trunk/Source/WebInspectorUI
Web Inspector: Make creating new rules in the Styles sidebar simpler
https://bugs.webkit.org/show_bug.cgi?id=152726
Patch by Devin Rousso <Devin Rousso> on 2016-01-07
Reviewed by Timothy Hatcher.
When creating a new rules of any kind, first look to see if it already exists in
another rule that has no properties. If found, focus/select it instead of creating
a new rule. Otherwise, create the new rule like normal.
Also changed the way in which previously-focused sections/tree-items are saved
to rely upon the selector of the new rule and whether the section for that rule
is empty and an inspector rule.
- Localizations/en.lproj/localizedStrings.js:
- UserInterface/Models/CSSStyleDeclaration.js:
(WebInspector.CSSStyleDeclaration.prototype.isInspectorRule):
Returns true if the style is an inspector rule.
(WebInspector.CSSStyleDeclaration.prototype.hasProperties):
Returns true if the style has CSS properties.
- UserInterface/Models/DOMNodeStyles.js:
(WebInspector.DOMNodeStyles.prototype.rulesForSelector.ruleHasSelector):
(WebInspector.DOMNodeStyles.prototype.rulesForSelector):
Returns a list of CSSRule that match the given selector and are not
in media queries.
- UserInterface/Views/BoxModelDetailsSectionRow.js:
(WebInspector.BoxModelDetailsSectionRow.prototype._updateMetrics):
- UserInterface/Views/CSSStyleDeclarationSection.js:
(WebInspector.CSSStyleDeclarationSection.prototype._handleContextMenuEvent):
- UserInterface/Views/CSSStyleDeclarationTextEditor.js:
(WebInspector.CSSStyleDeclarationTextEditor.prototype.commentAllProperties):
- UserInterface/Views/RulesStyleDetailsPanel.js:
(WebInspector.RulesStyleDetailsPanel.prototype.refresh.appendStyleSection):
(WebInspector.RulesStyleDetailsPanel.prototype.refresh.cssStyleDeclarationSectionEditorFocused):
Now saves the newly focused section as the previously-focused section.
(WebInspector.RulesStyleDetailsPanel.prototype.cssStyleDeclarationSectionFocusNewInspectorRuleWithSelector):
Renamed from cssStyleDeclarationSectionFocusNextNewInspectorRule. Now needs
a selector argument.
(WebInspector.RulesStyleDetailsPanel.prototype.newRuleButtonClicked):
(WebInspector.RulesStyleDetailsPanel.prototype.sectionForStyle):
Returns the first section that has a style with matching selector.
(WebInspector.RulesStyleDetailsPanel.prototype.focusEmptySectionWithStyle):
Finds the section corresponding to the given style and, if empty, focuses it.
(WebInspector.RulesStyleDetailsPanel.prototype.nodeStylesRefreshed):
No longer clears the previously-focused section.
- UserInterface/Views/VisualStyleSelectorSection.js:
(WebInspector.VisualStyleSelectorSection):
(WebInspector.VisualStyleSelectorSection.prototype.update.createSelectorItem):
(WebInspector.VisualStyleSelectorSection.prototype.update):
(WebInspector.VisualStyleSelectorSection.prototype.treeItemForStyle):
Returns the first tree item that has a style with matching selector.
(WebInspector.VisualStyleSelectorSection.prototype.selectEmptyStyleTreeItem):
Finds the tree item corresponding to the given style and, if empty, selects it.
(WebInspector.VisualStyleSelectorSection.prototype._addNewRule):
- UserInterface/Views/VisualStyleSelectorTreeItem.js:
(WebInspector.VisualStyleSelectorTreeItem):
Now requires a delegate object.
(WebInspector.VisualStyleSelectorTreeItem.prototype._handleContextMenuEvent):
- 1:20 PM Changeset in webkit [194716] by
-
- 12 edits12 adds in trunk/Source/JavaScriptCore
FTL B3 getById() should do exceptions
https://bugs.webkit.org/show_bug.cgi?id=152810
Reviewed by Saam Barati.
This adds abstractions for doing exceptions from patchpoints, and uses them to implement
exceptions from GetById. This covers all of the following ways that a GetById might throw an
exceptions:
- Throw without try/catch from the vmCall() in a GetById(Untyped:)
- Throw with try/catch from the vmCall() in a GetById(Untyped:)
- Throw without try/catch from the callOperation() in the patchpoint of a GetById
- Throw with try/catch from the callOperation() in the patchpoint of a GetById
- Throw without try/catch from the Call IC generated in the patchpoint of a GetById
- Throw with try/catch from the Call IC generated in the patchpoint of a GetById
This requires having a default exception target in FTL-generated code, and ensuring that this
target is generated regardless of whether we have branches to the B3 basic block of the
default exception target. This also requires adding some extra arguments to a
PatchpointValue, and then knowing that the arguments are used for OSR exit and not anything
else. This also requires associating the CallSiteIndex of the patchpoint with the register
set used for exit and with the OSR exit label for the unwind exit.
All of the stuff that you have to worry about when wiring a patchpoint to exception handling
is covered by the new PatchpointExceptionHandle object. You create one by calling
preparePatchpointForExceptions(). This sets up the B3 IR representation of the patchpoint
with stackmap arguments for the exceptional exit, and creates a PatchpointExceptionHandle
object that can be used to create zero or more actual OSR exits. It can create both OSR exits
for operation calls and OSR exits for unwind. You call the
PatchpointExceptionHandle::scheduleExitCreationXXX() methods from the generator callback to
actually get OSR exits.
This API makes heavy use of Box<>, late paths, and link tasks. For example, you can use the
PatchpointExceptionHandle to get a Box<JumpList> that you can append exception jumps to. When
you use this API, it automatically registers a link task that will link the JumpList to the
actual OSR exit label.
This API is very flexible about how you get to the label of the OSR exit. You are encouraged
to use the Box<JumpList> approach, but if you really just need the label, you can also get
a RefPtr<ExceptionTarget> and rely on the fact that the ExceptionTarget object will be able
to vend you the OSR exit label at link-time.
This reduces the number of JSC test failures with FTL B3 from 186 to 133. It also adds a
bunch of new tests specifically for all of the ways you might throw from GetById, and B3
passes all of these new tests. Note that I'm not counting the new tests as part of the
previous 186 test failures (FTL B3 failed all of the new tests prior to this change).
After this change, it should be easy to make all of the other patchpoints also handle
exceptions by just following the preparePatchpointForExceptions() idiom.
- CMakeLists.txt:
- JavaScriptCore.xcodeproj/project.pbxproj:
- b3/B3StackmapValue.h:
- b3/B3ValueRep.cpp:
(JSC::B3::ValueRep::addUsedRegistersTo):
(JSC::B3::ValueRep::usedRegisters):
(JSC::B3::ValueRep::dump):
- b3/B3ValueRep.h:
(JSC::B3::ValueRep::doubleValue):
(JSC::B3::ValueRep::withOffset):
(JSC::B3::ValueRep::usedRegisters):
- ftl/FTLB3Compile.cpp:
(JSC::FTL::compile):
- ftl/FTLB3Output.h:
(JSC::FTL::Output::unreachable):
(JSC::FTL::Output::speculate):
- ftl/FTLExceptionTarget.cpp: Added.
(JSC::FTL::ExceptionTarget::~ExceptionTarget):
(JSC::FTL::ExceptionTarget::label):
(JSC::FTL::ExceptionTarget::jumps):
(JSC::FTL::ExceptionTarget::ExceptionTarget):
- ftl/FTLExceptionTarget.h: Added.
- ftl/FTLJITCode.cpp:
(JSC::FTL::JITCode::liveRegistersToPreserveAtExceptionHandlingCallSite):
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::DFG::LowerDFGToLLVM::lower):
(JSC::FTL::DFG::LowerDFGToLLVM::compileArithAddOrSub):
(JSC::FTL::DFG::LowerDFGToLLVM::compileArithMul):
(JSC::FTL::DFG::LowerDFGToLLVM::compilePutById):
(JSC::FTL::DFG::LowerDFGToLLVM::compileMakeRope):
(JSC::FTL::DFG::LowerDFGToLLVM::compileCallOrConstructVarargs):
(JSC::FTL::DFG::LowerDFGToLLVM::compileIn):
(JSC::FTL::DFG::LowerDFGToLLVM::getById):
(JSC::FTL::DFG::LowerDFGToLLVM::emitBinarySnippet):
(JSC::FTL::DFG::LowerDFGToLLVM::emitBinaryBitOpSnippet):
(JSC::FTL::DFG::LowerDFGToLLVM::emitRightShiftSnippet):
(JSC::FTL::DFG::LowerDFGToLLVM::callCheck):
(JSC::FTL::DFG::LowerDFGToLLVM::preparePatchpointForExceptions):
(JSC::FTL::DFG::LowerDFGToLLVM::appendOSRExitArgumentsForPatchpointIfWillCatchException):
(JSC::FTL::DFG::LowerDFGToLLVM::lowBlock):
(JSC::FTL::DFG::LowerDFGToLLVM::appendOSRExit):
(JSC::FTL::DFG::LowerDFGToLLVM::blessSpeculation):
- ftl/FTLPatchpointExceptionHandle.cpp: Added.
(JSC::FTL::PatchpointExceptionHandle::create):
(JSC::FTL::PatchpointExceptionHandle::defaultHandle):
(JSC::FTL::PatchpointExceptionHandle::~PatchpointExceptionHandle):
(JSC::FTL::PatchpointExceptionHandle::scheduleExitCreation):
(JSC::FTL::PatchpointExceptionHandle::scheduleExitCreationForUnwind):
(JSC::FTL::PatchpointExceptionHandle::PatchpointExceptionHandle):
(JSC::FTL::PatchpointExceptionHandle::createHandle):
- ftl/FTLPatchpointExceptionHandle.h: Added.
- ftl/FTLState.cpp:
- ftl/FTLState.h:
(JSC::FTL::verboseCompilationEnabled):
- tests/stress/ftl-get-by-id-getter-exception-interesting-live-state.js: Added.
- tests/stress/ftl-get-by-id-getter-exception-no-catch.js: Added.
- tests/stress/ftl-get-by-id-getter-exception.js: Added.
- tests/stress/ftl-get-by-id-slow-exception-interesting-live-state.js: Added.
- tests/stress/ftl-get-by-id-slow-exception-no-catch.js: Added.
- tests/stress/ftl-get-by-id-slow-exception.js: Added.
- tests/stress/ftl-operation-exception-interesting-live-state.js: Added.
- tests/stress/ftl-operation-exception-no-catch.js: Added.
- 1:17 PM Changeset in webkit [194715] by
-
- 2 edits in trunk/Source/JavaScriptCore
[mips] Implemented missing branch patching methods.
https://bugs.webkit.org/show_bug.cgi?id=152845
Patch by Konstantin Tokarev <Konstantin Tokarev> on 2016-01-07
Reviewed by Michael Saboff.
- assembler/MacroAssemblerMIPS.h:
(JSC::MacroAssemblerMIPS::canJumpReplacePatchableBranch32WithPatch):
(JSC::MacroAssemblerMIPS::startOfPatchableBranch32WithPatchOnAddress):
(JSC::MacroAssemblerMIPS::revertJumpReplacementToPatchableBranch32WithPatch):
- 1:16 PM Changeset in webkit [194714] by
-
- 3 edits in trunk/Source/JavaScriptCore
[JSC] When resolving Stack arguments, use addressing from SP when addressing from FP is invalid
https://bugs.webkit.org/show_bug.cgi?id=152840
Patch by Benjamin Poulain <bpoulain@apple.com> on 2016-01-07
Reviewed by Mark Lam.
ARM64 has two kinds of addressing with immediates:
-Signed 9bits direct (really only -256 to 255).
-Unsigned 12bits scaled by the load/store size.
When resolving the stack addresses, we easily run
past -256 bytes from FP. Addressing from SP gives us more
room to address the stack efficiently because we can
use unsigned immediates.
- b3/B3StackmapSpecial.cpp:
(JSC::B3::StackmapSpecial::repForArg):
- b3/air/AirAllocateStack.cpp:
(JSC::B3::Air::allocateStack):
- 1:13 PM Changeset in webkit [194713] by
-
- 2 edits in trunk/Source/JavaScriptCore
[mips] Make repatchCall public to fix compilation.
https://bugs.webkit.org/show_bug.cgi?id=152843
Patch by Konstantin Tokarev <Konstantin Tokarev> on 2016-01-07
Reviewed by Michael Saboff.
- assembler/MacroAssemblerMIPS.h:
(JSC::MacroAssemblerMIPS::repatchCall):
(JSC::MacroAssemblerMIPS::linkCall): Deleted.
- 12:43 PM Changeset in webkit [194712] by
-
- 2 edits in trunk/Source/JavaScriptCore
[mips] Replaced subi with addi in getHostCallReturnValue
https://bugs.webkit.org/show_bug.cgi?id=152841
Patch by Konstantin Tokarev <Konstantin Tokarev> on 2016-01-07
Reviewed by Michael Saboff.
MIPS architecture does not have subi instruction, addi with negative
number should be used instead.
- jit/JITOperations.cpp:
- 12:21 PM Changeset in webkit [194711] by
-
- 2 edits in trunk/Source/JavaScriptCore
ARMv7 or32(TrustedImm32, AbsoluteAddress) may have a bug with its use of dataTempRegister.
https://bugs.webkit.org/show_bug.cgi?id=152833
Reviewed by Michael Saboff.
Follow-up patch to fix illegal use of memoryTempRegister as the src for ARM64's
store32.
- assembler/MacroAssemblerARM64.h:
(JSC::MacroAssemblerARM64::or32):
(JSC::MacroAssemblerARM64::store):
- 12:01 PM Changeset in webkit [194710] by
-
- 3 edits4 adds in trunk
Incorrect position: fixed; rendering when child of position:relative/sticky.
https://bugs.webkit.org/show_bug.cgi?id=147284
Reviewed by Simon Fraser and David Hyatt.
Computing logical left for positioned objects should take the relative positioned ancestors' offset
into account.
Source/WebCore:
Tests: fast/block/positioning/fixed-container-with-relative-parent.html
fast/block/positioning/fixed-container-with-sticky-parent.html
- rendering/RenderBox.cpp:
(WebCore::computeInlineStaticDistance):
LayoutTests:
- fast/block/positioning/fixed-container-with-relative-parent-expected.html: Added.
- fast/block/positioning/fixed-container-with-relative-parent.html: Added.
- fast/block/positioning/fixed-container-with-sticky-parent-expected.html: Added.
- fast/block/positioning/fixed-container-with-sticky-parent.html: Added.
- 12:00 PM Changeset in webkit [194709] by
-
- 2 edits in trunk/Source/JavaScriptCore
[mips] GPRInfo::toArgumentRegister missing
https://bugs.webkit.org/show_bug.cgi?id=152838
Patch by Konstantin Tokarev <Konstantin Tokarev> on 2016-01-07
Reviewed by Michael Saboff.
- jit/GPRInfo.h:
(JSC::GPRInfo::toArgumentRegister):
- 11:53 AM Changeset in webkit [194708] by
-
- 6 edits9 adds in trunk/Source/WebCore
Initial implementation files for display-list recording and playback
https://bugs.webkit.org/show_bug.cgi?id=152816
Reviewed by Zalan Bujtas.
Add files for:
- DisplayList, a class that holds a vector of display items, and in the future will hold metadata on the list for optimizations etc.
- DisplayList::Recorder, the outward-facing recording API which GraphicsContext will call into.
- DisplayList::Replayer, which plays back a DisplayList, possibly applying optimizations.
- Various DisplayList::Items, one type for each display list operation. They cover most of the GraphicsContext functionality, other than clipping to an image buffer. Text drawing is stubbed out for now.
Added a "DisplayLists" log channel.
Added GraphicsContextState functions for tracking state deltas with change bits. It may
make sense to combine GraphicsContextStateChange and GraphicsContextState, and use the
dirty bits in non-display-list drawing as well.
- CMakeLists.txt:
- WebCore.xcodeproj/project.pbxproj:
- platform/Logging.h:
- platform/graphics/GraphicsContext.h:
- platform/graphics/displaylists/DisplayList.cpp: Added.
(WebCore::DisplayList::DisplayList::description):
(WebCore::DisplayList::DisplayList::dump):
(WebCore::operator<<):
- platform/graphics/displaylists/DisplayListItems.cpp: Added.
- platform/graphics/displaylists/DisplayListItems.h: Added.
- platform/graphics/displaylists/DisplayListRecorder.cpp: Added.
- platform/graphics/displaylists/DisplayListRecorder.h: Added.
- platform/graphics/displaylists/DisplayListReplayer.cpp: Added.
(WebCore::DisplayList::Replayer::Replayer):
(WebCore::DisplayList::Replayer::~Replayer):
(WebCore::DisplayList::Replayer::replay):
- platform/graphics/displaylists/DisplayListReplayer.h: Added.
- 11:42 AM Changeset in webkit [194707] by
-
- 4 edits in trunk/Source/JavaScriptCore
ARMv7 or32(TrustedImm32, AbsoluteAddress) may have a bug with its use of dataTempRegister.
https://bugs.webkit.org/show_bug.cgi?id=152833
Reviewed by Benjamin Poulain.
- assembler/MacroAssemblerARM.h:
(JSC::MacroAssemblerARM::or32):
- Added some assertions to make sure it is safe to use ARMRegisters::S0 as a temp.
- assembler/MacroAssemblerARM64.h:
(JSC::MacroAssemblerARM64::or32):
- Implement an optimization that avoids reloading the memoryTempRegister when the immediate is encodable as an instruction immediate.
- assembler/MacroAssemblerARMv7.h:
(JSC::MacroAssemblerARMv7::or32):
- Added an assertion to make sure it is safe to use the dataTempRegister as a temp.
- Implement an optimization that avoids reloading the memoryTempRegister when the immediate is encodable as an instruction immediate. In the event that we cannot encode the immediate, we'll use the addressTempRegister as a temp, and reload it later.
- 11:40 AM Changeset in webkit [194706] by
-
- 7 edits2 adds in trunk
Directly-composited animated GIFs never resume once scrolled offscreen
https://bugs.webkit.org/show_bug.cgi?id=152817
<rdar://problem/19982020>
Reviewed by Daniel Bates.
Source/WebCore:
Directly-composited animated GIFs would never resume once scrolled
offscreen. This is because calling repaint() in this case would not
cause BitmapImage::draw() to be called and the animation would thus
not be resumed. To address the problem,
repaintForPausedImageAnimationsIfNeeded() now calls
RenderBoxModelObject::contentChanged(ImageChanged) in addition to
repaint() to make sure the animation actually gets resumed, even in
the directly-composited animated GIF case.
Test: fast/images/composited-animated-gif-outside-viewport.html
- platform/graphics/BitmapImage.h:
Make currentFrame() public so it can be exposed via Internals for the
purpose of testing.
- rendering/RenderElement.cpp:
(WebCore::RenderElement::repaintForPausedImageAnimationsIfNeeded):
Call RenderBoxModelObject::contentChanged(ImageChanged) in addition to
calling repaint() to make sure the animation actually gets resumed in
the directly-composited animated GIFs case.
- testing/Internals.cpp:
(WebCore::Internals::imageFrameIndex):
- testing/Internals.h:
- testing/Internals.idl:
Expose new "unsigned long imageFrameIndex(Element)" operation on
Internals so layout tests can better check if an image is actually
animating. Previously, we would rely on the output of
internals.hasPausedImageAnimations(Element) but this is not sufficient
to cover this bug as our rendering code believed it has resumed the
animations but the GIF was not actually animating due to it being
directly-composited.
LayoutTests:
Add a layout test to check that directly-composited animated GIFs are
properly suspended / resumed based on visibility inside the viewport.
- fast/images/composited-animated-gif-outside-viewport-expected.txt: Added.
- fast/images/composited-animated-gif-outside-viewport.html: Added.
- 11:29 AM Changeset in webkit [194705] by
-
- 3 edits in trunk/Source/JavaScriptCore
[CMake] JSC shell sources should include JavaScriptCore_SYSTEM_INCLUDE_DIRECTORIES
https://bugs.webkit.org/show_bug.cgi?id=152664
Patch by Konstantin Tokarev <Konstantin Tokarev> on 2016-01-07
Reviewed by Alex Christensen.
- shell/CMakeLists.txt:
- 11:06 AM Changeset in webkit [194704] by
-
- 8 edits3 adds in trunk
Web Inspector: CRASH Attempting to pause on CSP violation not inside of script
https://bugs.webkit.org/show_bug.cgi?id=152825
<rdar://problem/24021276>
Reviewed by Timothy Hatcher.
Source/JavaScriptCore:
- debugger/Debugger.cpp:
(JSC::Debugger::breakProgram):
We cannot pause if we are not evaluating JavaScript, so bail.
Source/WebInspectorUI:
- UserInterface/Test/TestHarness.js:
(TestHarness.prototype.expectThat):
(TestHarness.prototype.pass):
(TestHarness.prototype.fail):
Add a simple way to output a standard pass/fail message. These are
often nicer than expectThat(true, ...) or assert(false, ...).
LayoutTests:
- http/tests/inspector/resources/inspector-test.js:
(TestPage.reportUncaughtException):
Allow a test to continue after uncaught exceptions.
- inspector/debugger/csp-exceptions-expected.txt: Added.
- inspector/debugger/csp-exceptions.html: Added.
- inspector/debugger/resources/csp-exception-iframe.html: Added.
Test a CSP exception that causes a pause and one outside of
script that does not pause (and does not crash).
- 10:57 AM Changeset in webkit [194703] by
-
- 2 edits in trunk/Source/JavaScriptCore
[JSC] Re-enable lea() in Air on ARM64
https://bugs.webkit.org/show_bug.cgi?id=152832
Patch by Benjamin Poulain <bpoulain@apple.com> on 2016-01-07
Reviewed by Michael Saboff.
Lea() on the MacroAssembler is not the full x86 Lea (the real one being
x86Lea32()). Instead, it is a addPtr() with SP and a constant.
The instruction is required to implement B3's StackSlot. It is not
safe for big offsets but none of the stack operations are at the moment.
- b3/air/AirOpcode.opcodes:
- 10:21 AM Changeset in webkit [194702] by
-
- 2 edits in trunk/LayoutTests
Unreviewed IndexedDB test gardening.
- platform/mac-wk1/TestExpectations:
- 10:13 AM Changeset in webkit [194701] by
-
- 3 edits2 adds in trunk/LayoutTests
Modern IDB: Add expectations for W3C tests that were missing them.
https://bugs.webkit.org/show_bug.cgi?id=152835
Reviewed by Daniel Bates.
LayoutTests/imported/w3c:
- indexeddb/idbfactory_open10-expected.txt: Added.
- indexeddb/key_valid-expected.txt: Added.
LayoutTests:
- platform/mac-wk1/TestExpectations:
- 10:07 AM Changeset in webkit [194700] by
-
- 28 edits22 copies in trunk/LayoutTests
Modern IDB: Update results for W3C tests marked as failures that actually pass.
https://bugs.webkit.org/show_bug.cgi?id=152827
Reviewed by Daniel Bates.
LayoutTests/imported/w3c:
Modern IDB passes the following tests with PASS results where we previous expected FAIL.
Let's update those, shall we?
- indexeddb/abort-in-initial-upgradeneeded-expected.txt:
- indexeddb/idbcursor-advance-expected.txt:
- indexeddb/idbcursor_advance_index5-expected.txt:
- indexeddb/idbcursor_advance_index9-expected.txt:
- indexeddb/idbcursor_advance_objectstore5-expected.txt:
- indexeddb/idbcursor_continue_index5-expected.txt:
- indexeddb/idbcursor_continue_index6-expected.txt:
- indexeddb/idbcursor_continue_index8-expected.txt:
- indexeddb/idbcursor_continue_invalid-expected.txt:
- indexeddb/idbcursor_continue_objectstore6-expected.txt:
- indexeddb/idbcursor_delete_index4-expected.txt:
- indexeddb/idbcursor_delete_objectstore4-expected.txt:
- indexeddb/idbdatabase_close2-expected.txt:
- indexeddb/idbdatabase_deleteObjectStore4-not_reused-expected.txt:
- indexeddb/idbfactory_deleteDatabase3-expected.txt:
- indexeddb/idbindex-multientry-big-expected.txt:
- indexeddb/idbindex_get3-expected.txt:
- indexeddb/idbobjectstore_add4-expected.txt:
- indexeddb/idbobjectstore_createIndex2-expected.txt:
- indexeddb/idbobjectstore_createIndex4-deleteIndex-event_order-expected.txt:
- indexeddb/idbobjectstore_put4-expected.txt:
- indexeddb/idbtransaction_abort-expected.txt:
- indexeddb/keygenerator-constrainterror-expected.txt:
- indexeddb/keygenerator-expected.txt:
- indexeddb/transaction-requestqueue-expected.txt:
LayoutTests:
- Update FAIL expectations to PASS expectations for Modern IDB.
- Copy the FAIL expectations over to platform/wk2 to keep testing Legacy IDB.
- platform/mac-wk1/TestExpectations:
- platform/wk2/imported/w3c/indexeddb/abort-in-initial-upgradeneeded-expected.txt: Copied from LayoutTests/imported/w3c/indexeddb/abort-in-initial-upgradeneeded-expected.txt.
- platform/wk2/imported/w3c/indexeddb/idbcursor-advance-expected.txt: Copied from LayoutTests/imported/w3c/indexeddb/idbcursor-advance-expected.txt.
- platform/wk2/imported/w3c/indexeddb/idbcursor_advance_index5-expected.txt: Copied from LayoutTests/imported/w3c/indexeddb/idbcursor_advance_index5-expected.txt.
- platform/wk2/imported/w3c/indexeddb/idbcursor_advance_index9-expected.txt: Copied from LayoutTests/imported/w3c/indexeddb/idbcursor_advance_index9-expected.txt.
- platform/wk2/imported/w3c/indexeddb/idbcursor_advance_objectstore5-expected.txt: Copied from LayoutTests/imported/w3c/indexeddb/idbcursor_advance_objectstore5-expected.txt.
- platform/wk2/imported/w3c/indexeddb/idbcursor_continue_index8-expected.txt: Copied from LayoutTests/imported/w3c/indexeddb/idbcursor_continue_index8-expected.txt.
- platform/wk2/imported/w3c/indexeddb/idbcursor_continue_objectstore6-expected.txt: Copied from LayoutTests/imported/w3c/indexeddb/idbcursor_continue_objectstore6-expected.txt.
- platform/wk2/imported/w3c/indexeddb/idbcursor_delete_index4-expected.txt: Copied from LayoutTests/imported/w3c/indexeddb/idbcursor_delete_index4-expected.txt.
- platform/wk2/imported/w3c/indexeddb/idbcursor_delete_objectstore4-expected.txt: Copied from LayoutTests/imported/w3c/indexeddb/idbcursor_delete_objectstore4-expected.txt.
- platform/wk2/imported/w3c/indexeddb/idbdatabase_close2-expected.txt: Copied from LayoutTests/imported/w3c/indexeddb/idbdatabase_close2-expected.txt.
- platform/wk2/imported/w3c/indexeddb/idbdatabase_deleteObjectStore4-not_reused-expected.txt: Copied from LayoutTests/imported/w3c/indexeddb/idbdatabase_deleteObjectStore4-not_reused-expected.txt.
- platform/wk2/imported/w3c/indexeddb/idbfactory_deleteDatabase3-expected.txt: Copied from LayoutTests/imported/w3c/indexeddb/idbfactory_deleteDatabase3-expected.txt.
- platform/wk2/imported/w3c/indexeddb/idbindex-multientry-big-expected.txt: Copied from LayoutTests/imported/w3c/indexeddb/idbindex-multientry-big-expected.txt.
- platform/wk2/imported/w3c/indexeddb/idbindex_get3-expected.txt: Copied from LayoutTests/imported/w3c/indexeddb/idbindex_get3-expected.txt.
- platform/wk2/imported/w3c/indexeddb/idbobjectstore_add4-expected.txt: Copied from LayoutTests/imported/w3c/indexeddb/idbobjectstore_add4-expected.txt.
- platform/wk2/imported/w3c/indexeddb/idbobjectstore_createIndex2-expected.txt: Copied from LayoutTests/imported/w3c/indexeddb/idbobjectstore_createIndex2-expected.txt.
- platform/wk2/imported/w3c/indexeddb/idbobjectstore_createIndex4-deleteIndex-event_order-expected.txt: Copied from LayoutTests/imported/w3c/indexeddb/idbobjectstore_createIndex4-deleteIndex-event_order-expected.txt.
- platform/wk2/imported/w3c/indexeddb/idbobjectstore_put4-expected.txt: Copied from LayoutTests/imported/w3c/indexeddb/idbobjectstore_put4-expected.txt.
- platform/wk2/imported/w3c/indexeddb/idbtransaction_abort-expected.txt: Copied from LayoutTests/imported/w3c/indexeddb/idbtransaction_abort-expected.txt.
- platform/wk2/imported/w3c/indexeddb/keygenerator-constrainterror-expected.txt: Copied from LayoutTests/imported/w3c/indexeddb/keygenerator-constrainterror-expected.txt.
- platform/wk2/imported/w3c/indexeddb/keygenerator-expected.txt: Copied from LayoutTests/imported/w3c/indexeddb/keygenerator-expected.txt.
- platform/wk2/imported/w3c/indexeddb/transaction-requestqueue-expected.txt: Copied from LayoutTests/imported/w3c/indexeddb/transaction-requestqueue-expected.txt.
- 9:06 AM Changeset in webkit [194699] by
-
- 2 edits in trunk/Source/JavaScriptCore
[mips] Add two missing abortWithReason implementations
https://bugs.webkit.org/show_bug.cgi?id=136753
Patch by Julien Brianceau <jbriance@cisco.com> on 2016-01-07
Reviewed by Benjamin Poulain.
- assembler/MacroAssemblerMIPS.h:
(JSC::MacroAssemblerMIPS::memoryFence):
(JSC::MacroAssemblerMIPS::abortWithReason):
(JSC::MacroAssemblerMIPS::readCallTarget):
- 7:31 AM Changeset in webkit [194698] by
-
- 2 edits in trunk/Source/JavaScriptCore
Add new or32 implementation to MacroAssemblerARM after r194613
https://bugs.webkit.org/show_bug.cgi?id=152784
Reviewed by Benjamin Poulain.
- assembler/MacroAssemblerARM.h:
(JSC::MacroAssemblerARM::or32):
- 7:00 AM Changeset in webkit [194697] by
-
- 2 edits in trunk/Source/WebCore
[SOUP] Consider reducing max simultaneous connections
https://bugs.webkit.org/show_bug.cgi?id=137282
Reviewed by Carlos Garcia Campos.
Reduce max simultaneous connections from 35 to 17, because (a) all major browsers except
Chrome use 17, and (b) Chrome uses 10. The only reason we previously used 35 was that other
browsers were using 35 at the time.
- platform/network/soup/SoupNetworkSession.cpp:
(WebCore::SoupNetworkSession::SoupNetworkSession):
- 6:00 AM Changeset in webkit [194696] by
-
- 4 edits1 add in trunk/Tools
[buildbot] clean-build script should remove untracked files and revert local changes too
https://bugs.webkit.org/show_bug.cgi?id=142400
Reviewed by Ryosuke Niwa.
This patch cleans the WebKit folder by reverting tracked files changes and deleting SCM untracked files, including SCM ignored files.
A helper routine SCM.discard_untracked_files is added for that purpose.
- BuildSlaveSupport/clean-build:
(main): Making call to Scripts/clean-webkit
- Scripts/clean-webkit: Added.
(main): Revert changes and delete untracked files.
- Scripts/webkitpy/common/checkout/scm/scm.py:
(SCM.discard_untracked_files): Helper function to discard untracked files or folders found by SCM.
- Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
(SCMTest._shared_test_discard_untracked_files):
(test_discard_untracked_files): Tests that untracked file and untracked folder get discarded correctly.
- 3:25 AM WebKitGTK/Gardening/Calendar edited by
- (diff)
- 12:17 AM Changeset in webkit [194695] by
-
- 2 edits in branches/safari-601.1.46-branch/Source/WebKit2
Merge r194557. rdar://problem/24042908
- 12:17 AM Changeset in webkit [194694] by
-
- 2 edits in branches/safari-601.1.46-branch/Source/WebKit2
Merge r194624. rdar://problem/24074336
- 12:16 AM Changeset in webkit [194693] by
-
- 2 edits in branches/safari-601.1.46-branch/Source/WebCore
Merge r194485. rdar://problem/23978916
- 12:16 AM Changeset in webkit [194692] by
-
- 2 edits in branches/safari-601.1.46-branch/Source/WebCore
Merge r194662. rdar://problem/24043055
- 12:16 AM Changeset in webkit [194691] by
-
- 12 edits2 moves in trunk/Source/WebCore
Factor free standing tree style resolve functions into a class
https://bugs.webkit.org/show_bug.cgi?id=152786
Reviewed by Simon Fraser.
Factor the free standing tree style resolve functions into a class that can keep state.
Style::TreeResolver instances resolve a single tree scope. It is instantiated for resolving
the document style and then recursively for each encountered shadow tree.
This will enable new features and optimizations later.
- dom/Document.cpp:
(WebCore::Document::recalcStyle):
Move the root style computation code back to Document. It fits better here and avoid some
awkwardness with style resolver construction order.
- style/StyleResolveTree.cpp:
(WebCore::Style::TreeResolver::TreeResolver):
TreeResolver knows the current tree context and the StyleResolver to use for it.
Switch the functions to use these instead of recomputing them repeatedly.
(WebCore::Style::shouldCreateRenderer):
(WebCore::Style::TreeResolver::styleForElement):
(WebCore::Style::moveToFlowThreadIfNeeded):
(WebCore::Style::TreeResolver::createRenderer):
(WebCore::Style::updateTextRendererAfterContentChange):
(WebCore::Style::TreeResolver::createRenderTreeForChildren):
(WebCore::Style::TreeResolver::createRenderTreeForShadowRoot):
(WebCore::Style::needsPseudoElement):
(WebCore::Style::TreeResolver::createRenderTreeForBeforeOrAfterPseudoElement):
(WebCore::Style::TreeResolver::createRenderTreeForSlotAssignees):
(WebCore::Style::TreeResolver::createRenderTreeRecursively):
Rename to reduce the use of confusing "attach" terminology.
(WebCore::Style::pseudoStyleCacheIsInvalid):
(WebCore::Style::TreeResolver::resolveLocally):
(WebCore::Style::resolveTextNode):
(WebCore::Style::TreeResolver::resolveChildAtShadowBoundary):
(WebCore::Style::TreeResolver::resolveShadowTree):
(WebCore::Style::TreeResolver::resolveBeforeOrAfterPseudoElement):
(WebCore::Style::TreeResolver::resolveChildren):
(WebCore::Style::TreeResolver::resolveSlotAssignees):
(WebCore::Style::TreeResolver::resolveRecursively):
(WebCore::Style::TreeResolver::resolve):
(WebCore::Style::detachRenderTree):
(WebCore::Style::styleForElement): Deleted.
(WebCore::Style::createRendererIfNeeded): Deleted.
(WebCore::Style::attachChildren): Deleted.
(WebCore::Style::attachShadowRoot): Deleted.
(WebCore::Style::attachBeforeOrAfterPseudoElementIfNeeded): Deleted.
(WebCore::Style::attachSlotAssignees): Deleted.
(WebCore::Style::attachRenderTree): Deleted.
(WebCore::Style::resolveLocal): Deleted.
(WebCore::Style::resolveChildAtShadowBoundary): Deleted.
(WebCore::Style::resolveShadowTree): Deleted.
(WebCore::Style::updateBeforeOrAfterPseudoElement): Deleted.
(WebCore::Style::resolveChildren): Deleted.
(WebCore::Style::resolveSlotAssignees): Deleted.
(WebCore::Style::resolveTree): Deleted.
- style/StyleResolveTree.h:
- 12:14 AM Changeset in webkit [194690] by
-
- 2 edits in trunk/Source/WebCore
AX: AXObjectCacheMac is passing WebCore enum values directly to VoiceOver
https://bugs.webkit.org/show_bug.cgi?id=151755
Patch by Doug Russell <d_russell@apple.com> on 2016-01-07
Reviewed by Chris Fleizach.
No new tests, covered by existing tests.
- accessibility/mac/AXObjectCacheMac.mm:
(platformChangeTypeForWebCoreChangeType):
(platformEditTypeForWebCoreEditType):
(platformDirectionForWebCoreDirection):
(platformGranularityForWebCoreGranularity):
(WebCore::AXObjectCache::postTextStateChangePlatformNotification):
(WebCore::textReplacementChangeDictionary):
(WebCore::AXObjectCache::postTextReplacementPlatformNotification):
Jan 6, 2016:
- 11:53 PM Changeset in webkit [194689] by
-
- 2 edits in trunk/LayoutTests
Modern IDB: Initial enabling of imported W3C IDB tests.
https://bugs.webkit.org/show_bug.cgi?id=152824
Reviewed by Daniel Bates.
- platform/mac-wk1/TestExpectations: Unskip the entire W3C IDB test directory, but add appropriate results for all the tests that don't yet pass.
- 6:41 PM Changeset in webkit [194688] by
-
- 3 edits in trunk/LayoutTests
Web Inspector: Add test for Color.canBeSerializedAsShortHex
https://bugs.webkit.org/show_bug.cgi?id=152809
Patch by Devin Rousso <Devin Rousso> on 2016-01-06
Reviewed by Brian Burg.
Added more specific tests for the canBeSerializedAsShortHex
method of Web Inspector model class Color.
- inspector/model/color-expected.txt:
- inspector/model/color.html:
- 6:09 PM Changeset in webkit [194687] by
-
- 3 edits in trunk/Source/WebCore
Modern IDB: Fix up IDBDatabaseIdentifier hash issues.
https://bugs.webkit.org/show_bug.cgi?id=152822
Reviewed by Alex Christensen.
No new tests (No explicitly testable behavior change, existing tests pass, flakiness will be reduced).
- Modules/indexeddb/IDBDatabaseIdentifier.h:
(WebCore::IDBDatabaseIdentifier::IDBDatabaseIdentifier):
(WebCore::IDBDatabaseIdentifier::isEmpty):
(WebCore::IDBDatabaseIdentifierHashTraits::isEmptyValue):
- page/SecurityOriginData.h:
- 5:44 PM Changeset in webkit [194686] by
-
- 3 edits in trunk/Source/WebInspectorUI
Web Inspector: DOMContentLoaded label in the Timeline tab should be "DOM Content Loaded"
https://bugs.webkit.org/show_bug.cgi?id=152746
Reviewed by Timothy Hatcher.
- Localizations/en.lproj/localizedStrings.js:
- UserInterface/Views/TimelineRuler.js:
(WebInspector.TimelineRuler.prototype.addMarker):
- 5:44 PM Changeset in webkit [194685] by
-
- 9 edits in trunk
Web Inspector: Scope chain shows too many scopes for functions (
letandvarin the same function are two scopes)
https://bugs.webkit.org/show_bug.cgi?id=152349
Reviewed by Timothy Hatcher.
Source/WebInspectorUI:
- Localizations/en.lproj/localizedStrings.js:
New "Closure Variables (%s)" string for including the function name alongside
the closure scope section.
- UserInterface/Models/ScopeChainNode.js:
(WebInspector.ScopeChainNode):
(WebInspector.ScopeChainNode.prototype.get objects):
(WebInspector.ScopeChainNode.prototype.get object): Deleted.
Allow a ScopeChainNode to hold onto multiple RemoteObjects (for multiple JSScopes).
- UserInterface/Controllers/DebuggerManager.js:
(WebInspector.DebuggerManager.prototype._scopeChainNodeFromPayload):
Simplify the legacy case and convert "Local" to "Closure". The UI will now
determine and display "Local" where appropriate in a backwards compatible way.
- UserInterface/Views/ScopeChainDetailsSidebarPanel.js:
(WebInspector.ScopeChainDetailsSidebarPanel.prototype._generateCallFramesSection):
Associate ScopeChain nodes with CallFrame frames so that we can better combine
variable sections and better label closure sections.
- UserInterface/Views/ScopeChainDetailsSidebarPanel.css:
(.scope-chain .details-section > .content > .group > .row.properties:not(.empty)):
(.scope-chain .details-section > .content > .group > .row.properties:not(.empty):last-child):
Styles for two object trees property sections next to eachother.
LayoutTests:
- inspector/debugger/breakpoint-scope.html:
- inspector/model/scope-chain-node.html:
The ScopeChainNode model object changed, so update tests.
- 5:43 PM Changeset in webkit [194684] by
-
- 2 edits in trunk/Source/WebCore
Sort the project file.
- WebCore.xcodeproj/project.pbxproj:
- 5:43 PM Changeset in webkit [194683] by
-
- 16 edits in trunk
Add a setting and preferences to enable display-list drawing. Does nothing yet.
https://bugs.webkit.org/show_bug.cgi?id=152807
Reviewed by Zalan Bujtas.
Source/WebCore:
Setting for display-list drawing.
- page/Settings.in:
Source/WebKit/mac:
WK1 pref for display-list drawing, defaults to off.
- WebView/WebPreferenceKeysPrivate.h:
- WebView/WebPreferences.mm:
(+[WebPreferences initialize]):
(-[WebPreferences displayListDrawingEnabled]):
(-[WebPreferences setDisplayListDrawingEnabled:]):
- WebView/WebPreferencesPrivate.h:
- WebView/WebView.mm:
(-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
(-[WebView _preferencesChanged:]):
Source/WebKit2:
WK2 debug pref for display-list drawing, defaults to off.
- Shared/WebPreferencesDefinitions.h:
- UIProcess/API/Cocoa/WKPreferences.mm:
(-[WKPreferences _displayListDrawingEnabled]):
(-[WKPreferences _setDisplayListDrawingEnabled:]):
- UIProcess/API/Cocoa/WKPreferencesPrivate.h:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences):
Tools:
Add an item to the Settings menu to toggle display-list drawing.
- MiniBrowser/mac/SettingsController.h:
- MiniBrowser/mac/SettingsController.m:
(-[SettingsController _populateMenu]):
(-[SettingsController validateMenuItem:]):
(-[SettingsController toggleDisplayListDrawingEnabled:]):
(-[SettingsController displayListDrawingEnabled]):
- MiniBrowser/mac/WK2BrowserWindowController.m:
(-[WK2BrowserWindowController didChangeSettings]):
- 5:39 PM Changeset in webkit [194682] by
-
- 2 edits in trunk/LayoutTests
[GTK] css-multicol-1 tests are failing
Unreviewed gardening.
- platform/gtk/TestExpectations:
- 5:37 PM WebKitGTK/Gardening/Calendar edited by
- (diff)
- 5:33 PM Changeset in webkit [194681] by
-
- 2 edits in trunk/LayoutTests
Rebaselining media/airplay-target-availability.html
hhttps://bugs.webkit.org/show_bug.cgi?id=152815
Unreviewed test gardening.
- media/airplay-target-availability-expected.txt:
- 5:17 PM WebKitGTK/Gardening/Calendar edited by
- (diff)
- 5:00 PM Changeset in webkit [194680] by
-
- 2 edits in trunk/Websites/perf.webkit.org
Perf dashboard JSON API should fail gracefully when postgres is down
https://bugs.webkit.org/show_bug.cgi?id=152812
Reviewed by Chris Dumez.
Even though all JSON APIs returned DatabaseConnectionFailure as the status when Database::connect
returned a falsy value, PHP was spitting out warnings and producing HTTP responses that cannot be
parsed as a JSON when pg_connect failed.
Fixed the bug by suppressing warning messages in pg_connect.
- public/include/db.php:
(Database::connect): Use '@' prefix to suppress warning messages.
- 4:57 PM Changeset in webkit [194679] by
-
- 3 edits1 add in trunk/Websites/perf.webkit.org
Perf dashboard should auto-generate manifest file when one is missing
https://bugs.webkit.org/show_bug.cgi?id=152813
Reviewed by Chris Dumez.
When /data/manifest.json is missing, fall back to newly added /api/manifest instead of
silently failing to show the UI. This will make the initial setup easier.
- public/api/manifest.php: Added.
(main):
- public/include/manifest.php:
(Manifest::manifest): Added.
- public/v3/main.js:
(fetchManifest):
(didFetchManifest): Extracted from fetchManifest.
- 3:54 PM Changeset in webkit [194678] by
-
- 3 edits in trunk/LayoutTests
Remove Debug Logging from some Inspector Tests
https://bugs.webkit.org/show_bug.cgi?id=152806
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-01-06
Reviewed by Brian Burg.
- inspector/debugger/scriptParsed.html:
- inspector/model/scope-chain-node.html:
- 3:50 PM Changeset in webkit [194677] by
-
- 13 edits2 adds in branches/safari-601-branch
Merge r194405. rdar://problem/23982006
- 3:50 PM Changeset in webkit [194676] by
-
- 4 edits2 adds in branches/safari-601-branch
Merge r194404. rdar://problem/23982006
- 3:50 PM Changeset in webkit [194675] by
-
- 11 edits in branches/safari-601-branch
Merge r194114. rdar://problem/23982010
- 3:50 PM Changeset in webkit [194674] by
-
- 2 edits in branches/safari-601-branch/Source/WebCore
Merge r188802. rdar://problem/23982009
- 3:46 PM Changeset in webkit [194673] by
-
- 5 edits3 adds in trunk/Source/WebInspectorUI
Web Inspector: Add basic Animation section to Visual Sidebar
https://bugs.webkit.org/show_bug.cgi?id=152692
Patch by Devin Rousso <Devin Rousso> on 2016-01-06
Reviewed by Timothy Hatcher.
Adds a non-autocompleting section to the "Effects" section (renamed from
"Animations") of the Visual sidebar for setting CSS Animation values.
- Scripts/copy-user-interface-resources.pl:
- Localizations/en.lproj/localizedStrings.js:
- UserInterface/Images/AnimationPlayStatePaused.svg: Added.
- UserInterface/Images/AnimationPlayStateRunning.svg: Added.
- UserInterface/Main.html:
- UserInterface/Views/VisualStyleBasicInput.js: Added.
(WebInspector.VisualStyleBasicInput):
(WebInspector.VisualStyleBasicInput.prototype.get value):
(WebInspector.VisualStyleBasicInput.prototype.set value):
(WebInspector.VisualStyleBasicInput.prototype.get synthesizedValue):
(WebInspector.VisualStyleBasicInput.prototype._handleInputElementInput):
Very basic editor that is just an input box with a given placeholder.
- UserInterface/Views/VisualStyleDetailsPanel.js:
(WebInspector.VisualStyleDetailsPanel):
(WebInspector.VisualStyleDetailsPanel.prototype._populateAnimationSection):
Creates the necessary property editors and adds them to their respective rows.
- 3:37 PM Changeset in webkit [194672] by
-
- 15 edits2 adds in trunk
AirPlay route availability event not always sent
https://bugs.webkit.org/show_bug.cgi?id=152802
Reviewed by Jer Noble.
Source/WebCore:
Test: media/airplay-target-availability.html
- Modules/mediasession/WebMediaSessionManager.cpp:
(WebCore::mediaProducerStateString): Log the new flags.
(WebCore::WebMediaSessionManager::clientStateDidChange): Schedule a client reconfiguration if
the 'requires monitoring', 'has listener', or 'has audio or video' flags have changed.
(WebCore::WebMediaSessionManager::configurePlaybackTargetMonitoring): Start monitoring if
at least one client has a listener and at least one has audio/video.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::mediaState): Set new flags.
- html/HTMLMediaElement.h:
- page/MediaProducer.h: Define new flags. Add new state enum.
- platform/graphics/MediaPlaybackTargetContext.h: Initial state is "Unknown".
- platform/mock/MediaPlaybackTargetMock.h:
- platform/mock/MediaPlaybackTargetPickerMock.cpp:
(WebCore::MediaPlaybackTargetPickerMock::externalOutputDeviceAvailable): Enums not bitfields.
(WebCore::MediaPlaybackTargetPickerMock::startingMonitoringPlaybackTargets): Ditto. Don't make
device change callback if the device state is "Unknown".
(WebCore::MediaPlaybackTargetPickerMock::setState): Ditto.
- platform/mock/MediaPlaybackTargetPickerMock.h:
- testing/Internals.cpp:
(WebCore::Internals::setMockMediaPlaybackTargetPickerState): Support new state.
LayoutTests:
- media/airplay-target-availability-expected.txt: Added.
- media/airplay-target-availability.html: Added.
- platform/mac/TestExpectations: Skip new test on Yosemite.
- platform/efl/TestExpectations: Skip new test.
- platform/gtk/TestExpectations: Ditto.
- platform/win/TestExpectations: Ditto.
- 2:34 PM Changeset in webkit [194671] by
-
- 5 edits in trunk
Modern IDB: storage/indexeddb/odd-strings.html is flaky.
https://bugs.webkit.org/show_bug.cgi?id=152800
Reviewed by Alex Christensen.
Source/WebCore:
No new tests (Existing flaky test is now rock solid and unskipped).
- Modules/indexeddb/client/IDBDatabaseImpl.cpp:
(WebCore::IDBClient::IDBDatabase::IDBDatabase):
(WebCore::IDBClient::IDBDatabase::maybeCloseInServer): Only refuse to close in the server if there
are active transactions. In the case of page navigation where stop() has been called on active DOM objects,
there will never be any active transactions.
- Modules/indexeddb/server/UniqueIDBDatabase.cpp:
(WebCore::IDBServer::UniqueIDBDatabase::commitTransaction):
LayoutTests:
- platform/mac-wk1/TestExpectations:
- 2:21 PM Changeset in webkit [194670] by
-
- 5 edits in trunk
Modern IDB: storage/indexeddb/intversion-gated-on-delete.html is flaky.
https://bugs.webkit.org/show_bug.cgi?id=152795
Reviewed by Alex Christensen.
Source/WebCore:
No new tests (At least one failing test now passes).
Change the HashSet of open connection into a ListHashSet.
This enforces a reliable order of event delivery, which this test relies on,
and which seems better in general.
- Modules/indexeddb/server/UniqueIDBDatabase.cpp:
(WebCore::IDBServer::UniqueIDBDatabase::connectionClosedFromClient):
- Modules/indexeddb/server/UniqueIDBDatabase.h:
LayoutTests:
- platform/mac-wk1/TestExpectations:
- 2:21 PM Changeset in webkit [194669] by
-
- 2 edits in trunk/Source/JavaScriptCore
REGRESSION(r194613): JITMulGenerator needs a scratch GPR on 32-bit too.
https://bugs.webkit.org/show_bug.cgi?id=152805
Reviewed by Michael Saboff.
There aren't enough registers on x86 32-bit to allocate the needed scratch GPR.
So, we'll continue to use one of the result registers as the scratch, and
re-compute the result at the end.
- jit/JITMulGenerator.cpp:
(JSC::JITMulGenerator::generateFastPath):
- 2:10 PM Changeset in webkit [194668] by
-
- 2 edits in trunk/Source/WebKit2
Use code signed identifier as part of user directory suffix
https://bugs.webkit.org/show_bug.cgi?id=152310
<rdar://problem/13352225>
As pointed out by Sam Weinig, the year is 2016! I inadvertently added the copyright year 2015 instead of 2016.
- Shared/mac/ChildProcessMac.mm:
- 2:08 PM Changeset in webkit [194667] by
-
- 11 edits in trunk
[iOS] Revert overflow:hidden on the body affecting viewport scale (r186786)
https://bugs.webkit.org/show_bug.cgi?id=152803
rdar://problem/22242515
Reviewed by Tim Horton.
Source/WebCore:
You can't assume that if an author uses overflow:hidden on the body, they have no
content outside the body that is important. Sites like Google Translate put
abspos elements outside the body.
So revert the change.
- page/FrameView.cpp:
(WebCore::FrameView::contentsSizeRespectingOverflow): Deleted.
- page/FrameView.h:
Source/WebKit/mac:
- WebView/WebView.mm:
(-[WebView _contentsSizeRespectingOverflow]): Keep this function which is used
by UIKit, but change the implementation to just return the document size.
Source/WebKit2:
You can't assume that if an author uses overflow:hidden on the body, they have no
content outside the body that is important. Sites like Google Translate put
abspos elements outside the body.
So revert the change.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::mainFrameDidLayout): Go back to using contents size.
LayoutTests:
Keep the tests, but update their expected results.
- platform/ios-simulator/fast/viewport/ios/width-is-device-width-overflowing-body-overflow-hidden-expected.txt:
- platform/ios-simulator/fast/viewport/ios/width-is-device-width-overflowing-body-overflow-hidden-tall-expected.txt:
- platform/ios-simulator/fast/viewport/ios/width-is-device-width-overflowing-expected.txt:
- 2:07 PM Changeset in webkit [194666] by
-
- 5 edits2 adds in trunk
Port blocking bypass issue using 307 redirect
https://bugs.webkit.org/show_bug.cgi?id=152801
<rdar://problem/24048554>
Reviewed by Anders Carlsson.
Source/WebCore:
Tested by http/tests/security/blocked-on-redirect.html.
Make sure that 307 redirects check the requested URL via 'portAllowed'.
- loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::willSendRequest): Confirm that the requested port
is valid, and block load if it is not.
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::reportBlockedPortFailed): Added.
(WebCore::FrameLoader::blockedError): Added.
- loader/FrameLoader.h:
LayoutTests:
- http/tests/security/blocked-on-redirect-expected.txt: Added.
- http/tests/security/blocked-on-redirect.html: Added.
- 1:50 PM Changeset in webkit [194665] by
-
- 7 edits1 add in trunk/Source
Add a smart block pointer
https://bugs.webkit.org/show_bug.cgi?id=152799
Reviewed by Tim Horton.
Source/JavaScriptCore:
Get rid of RemoteTargetBlock and replace it with WTF::BlockPtr<void ()>.
- inspector/remote/RemoteConnectionToTarget.h:
(Inspector::RemoteTargetBlock::RemoteTargetBlock): Deleted.
(Inspector::RemoteTargetBlock::~RemoteTargetBlock): Deleted.
(Inspector::RemoteTargetBlock::operator=): Deleted.
(Inspector::RemoteTargetBlock::operator()): Deleted.
- inspector/remote/RemoteConnectionToTarget.mm:
(Inspector::RemoteTargetQueueTaskOnGlobalQueue):
(Inspector::RemoteConnectionToTarget::queueTaskOnPrivateRunLoop):
Source/WebKit2:
Use WTF::BlockPtr.
- UIProcess/API/Cocoa/WKWebsiteDataStore.mm:
(-[WKWebsiteDataStore fetchDataRecordsOfTypes:completionHandler:]):
(-[WKWebsiteDataStore removeDataOfTypes:modifiedSince:completionHandler:]):
(-[WKWebsiteDataStore removeDataOfTypes:forDataRecords:completionHandler:]):
Source/WTF:
Introduce WTF::BlockPtr, a smart block pointer.
- WTF.xcodeproj/project.pbxproj:
- wtf/BlockPtr.h: Added.
(WTF::makeBlockPtr):
- 1:43 PM Changeset in webkit [194664] by
-
- 2 edits in trunk/Websites/perf.webkit.org
Commit another forgotten change, this time, for r194653.
- public/v3/models/measurement-set.js:
- 1:37 PM Changeset in webkit [194663] by
-
- 4 edits in trunk/Source/JavaScriptCore
[JSC] More B3 tests passing on ARM64
https://bugs.webkit.org/show_bug.cgi?id=152787
Patch by Benjamin Poulain <bpoulain@apple.com> on 2016-01-06
Reviewed by Michael Saboff.
Some more minor bugs.
- assembler/MacroAssemblerARM64.h:
(JSC::MacroAssemblerARM64::urshift64):
The offset was being truncated. That code was just copied
from the 32bits version of urshift.
- b3/B3LowerToAir.cpp:
(JSC::B3::Air::LowerToAir::createGenericCompare):
Very few instructions can encode -1 as immediate.
TST certainly can't. The fallback works for ARM.
- b3/air/AirOpcode.opcodes:
Bit instructions have very specific immediate encoding.
B3 cannot express that properly yet. I disabled those
forms for now. Immediates encoding is something we'll really
have to look into at some point for B3 ARM64.
- 1:32 PM Changeset in webkit [194662] by
-
- 2 edits in branches/safari-601-branch/Source/WebCore
Merge for rdar://problem/24043055.
- 1:16 PM Changeset in webkit [194661] by
-
- 2 edits in trunk/Websites/perf.webkit.org
The sampling of time series on v3 UI is too aggressive
https://bugs.webkit.org/show_bug.cgi?id=152804
Reviewed by Chris Dumez.
Fixed a bug that we were always halving the number of data points in _sampleTimeSeries
and increased the number of data points allowed to make the sampling less aggressive.
- public/v3/components/time-series-chart.js:
(TimeSeriesChart.prototype._ensureSampledTimeSeries): Increase the number of maximum points
to 2x the number of pixels divided by the radius of each point.
(TimeSeriesChart.prototype._sampleTimeSeries.findMedian): Changed the semantics of endIndex
to mean the index after the last point and renamed it to indexAfterEnd.
(TimeSeriesChart.prototype._sampleTimeSeries): Fixed a bug that this code always coerced two
data points into one sampled data point despite of the fact i and j are sufficiently apart
since data[j].time - data[i].time > timePerSample by definition.
- 1:15 PM Changeset in webkit [194660] by
-
- 2 edits in trunk/Source/WebKit2
Use code signed identifier as part of user directory suffix
https://bugs.webkit.org/show_bug.cgi?id=152310
<rdar://problem/13352225>
Reviewed by Brent Fulgham.
- Shared/mac/ChildProcessMac.mm:
(WebKit::findSecCodeForProcess): Added.
(WebKit::ChildProcess::initializeSandbox): Modified to use an identifier
from the code signature of the app/tool as part of the user directory suffix.
- 1:13 PM Changeset in webkit [194659] by
-
- 2 edits in trunk/Source/JavaScriptCore
Silence -Wtautological-compare
https://bugs.webkit.org/show_bug.cgi?id=152768
Reviewed by Saam Barati.
- runtime/Options.cpp:
(JSC::Options::setAliasedOption):
- 1:06 PM Changeset in webkit [194658] by
-
- 2 edits in trunk/LayoutTests
gi2016-01-06 Carlos Alberto Lopez Perez <clopez@igalia.com>
[GTK] Unreviewed gardening.
- platform/gtk/TestExpectations: report and mark new SVG failures
after r192138 and new media timeouts after r191948. Mark also the
RTSP test as skip because it was failing, and update the expectation
for a slow inspector test that now timeouts.
- 1:04 PM Changeset in webkit [194657] by
-
- 2 edits in trunk/Websites/perf.webkit.org
Commit the forgotten change for r194651.
- public/v3/pages/domain-control-toolbar.js:
(DomainControlToolbar.prototype.setStartTime):
- 12:53 PM Changeset in webkit [194656] by
-
- 2 edits in trunk/Source/WebCore
[Cocoa] Tiny cleanup in FontPlatformData::ctFont()
https://bugs.webkit.org/show_bug.cgi?id=152793
Reviewed by Zalan Bujtas.
No new tests because there is no behavior change.
- platform/graphics/cocoa/FontPlatformDataCocoa.mm:
(WebCore::FontPlatformData::ctFont):
- 12:49 PM Changeset in webkit [194655] by
-
- 2 edits1 add in trunk/Source/JavaScriptCore
Make sure that the basic throw-from-operation mode of throwing makes sense in FTL B3
https://bugs.webkit.org/show_bug.cgi?id=152798
Reviewed by Oliver Hunt.
This really just contains one change: we inline emitBranchToOSRExitIfWillCatchException()
into callCheck(), since that was its only caller. This makes it a bit more clear what is
going on.
It turns out that FTL B3 already handled this case properly. I added a test that I believe
illustrates this. Note that although the test uses GetById, which ordinarily throws
exceptions from inside a patchpoint, it uses it in such a way that the exception is thrown
from the operation call for the non-cell bypass path of a GetById(UntypedUse:).
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::DFG::LowerDFGToLLVM::callCheck):
(JSC::FTL::DFG::LowerDFGToLLVM::appendOSRExitArgumentsForPatchpointIfWillCatchException):
(JSC::FTL::DFG::LowerDFGToLLVM::lowBlock):
(JSC::FTL::DFG::LowerDFGToLLVM::emitBranchToOSRExitIfWillCatchException): Deleted.
- tests/stress/ftl-operation-exception.js: Added.
(foo):
- 12:31 PM Changeset in webkit [194654] by
-
- 2 edits in trunk/Websites/webkit.org
Fixed Individuals and Vendor Contact formatting.
https://bugs.webkit.org/show_bug.cgi?id=152714
Reviewed by Timothy Hatcher.
- security-policy.md:
- 12:31 PM Changeset in webkit [194653] by
-
- 3 edits in trunk/Websites/perf.webkit.org
The right hand side of main chart appears to be cut off as you zoom out on v3 UI
https://bugs.webkit.org/show_bug.cgi?id=152778
Reviewed by Antti Koivisto.
Add a padding on x-axis after the end time to make the main chart more easily interactive.
- public/v3/components/time-series-chart.js:
(TimeSeriesChart.prototype._computeHorizontalRenderingMetrics):
- public/v3/pages/page-with-charts.js:
(PageWithCharts.mainChartOptions): Add a padding of 5px at the end of x-axis.
- 12:27 PM Changeset in webkit [194652] by
-
- 3 edits in trunk/Websites/perf.webkit.org
v3 UI should use four sig-figs to label y-axis of the main charts
https://bugs.webkit.org/show_bug.cgi?id=152779
Reviewed by Antti Koivisto.
Increase the number of significant figures used in the main charts to four as done in v2 UI.
- public/v3/pages/chart-pane.js:
(ChartPane.constructor): Create a formatter with four significant figures.
- public/v3/pages/page-with-charts.js:
(PageWithCharts.mainChartOptions): Increase the width of y-axis labels.
- 12:26 PM Changeset in webkit [194651] by
-
- 2 edits in trunk/Websites/perf.webkit.org
v3 UI's time range slider is harder to use than that of v2 UI
https://bugs.webkit.org/show_bug.cgi?id=152780
Reviewed by Antti Koivisto.
Improved the time range slider by using a cubic mapping to time range and providing a text field
to directly edit the number of days to show.
Now an user can enter the text mode to directly edit the number of days to show by clicking on
the number of days (text field is always there with opacity=0).
- public/v3/pages/charts-toolbar.js:
(ChartsToolbar): Store the minimum and maximum number of days allowed. Also rename _inputElement
to _slider and added a new type=number text field as _editor.
(ChartsToolbar.prototype.render):
(ChartsToolbar.prototype.setStartTime): Exit the text mode when the number of days is changed by
an URL state transition (i.e. back/forward navigation).
(ChartsToolbar.prototype._setInputElementValue): Added. Updates the values of _slider and _editor.
(ChartsToolbar.prototype._enterTextMode): Added. Hide the elements used by the slider mode and
show the text field.
(ChartsToolbar.prototype._exitTextMode): Added. Does the opposite.
(ChartsToolbar.prototype._sliderValueMayHaveChanged): Renamed from _inputValueMayHaveChanged.
(ChartsToolbar.prototype._editorValueMayHaveChanged): Added. Similar to _sliderValueMayHaveChanged
but also corrects the value of _editor if needed.
(ChartsToolbar.prototype._callNumberOfDaysCallback): Extracted from _inputValueMayHaveChanged.
Also fixed a bug that we didn't update the URL state when the change event was fired without
modifying the effective number of days.
(ChartsToolbar.cssTemplate): Tweaked the style to support the new mode. Also set a fixed width on
the span showing the number of days in the slider mode.
- 12:06 PM Changeset in webkit [194650] by
-
- 2 edits in trunk/Source/JavaScriptCore
Web Inspector: Remove duplicate check
https://bugs.webkit.org/show_bug.cgi?id=152792
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-01-06
Reviewed by Timothy Hatcher.
- inspector/InjectedScriptSource.js:
(InjectedScript.RemoteObject.prototype._generatePreview): Deleted.
This method is only called from one place, and it does an equivalent
check before calling this function. Remove the duplicate check.
- 11:24 AM Changeset in webkit [194649] by
-
- 7 edits1 add in trunk
Modern IDB: storage/indexeddb/transaction-scope-sequencing.html fails
https://bugs.webkit.org/show_bug.cgi?id=152775
Reviewed by Alex Christensen.
Source/WebCore:
No new tests (At least one failing test now passes, plus changes to another existing test).
Any transaction enqueued after a read-write transaction whose scope overlaps with
that read-write transaction cannot run until after that read-write transaction runs.
Additionally, read-only transactions were actually sometimes running even though their scopes
overlapped with a running read-write transaction.
This patch fixes both of those issues.
- Modules/indexeddb/server/UniqueIDBDatabase.cpp:
(WebCore::IDBServer::UniqueIDBDatabase::operationAndTransactionTimerFired):
(WebCore::IDBServer::UniqueIDBDatabase::takeNextRunnableTransaction):
(WebCore::IDBServer::UniqueIDBDatabase::inProgressTransactionCompleted):
- Modules/indexeddb/server/UniqueIDBDatabase.h:
LayoutTests:
In addition to enabling the previously skipped test, this also completely rewrites transaction-scheduler-4,
which covered incorrect behavior, to cover newly implemented correct behavior.
- platform/mac-wk1/TestExpectations:
- storage/indexeddb/modern/resources/transaction-scheduler-4.js: Added.
- storage/indexeddb/modern/transaction-scheduler-4-expected.txt:
- storage/indexeddb/modern/transaction-scheduler-4.html:
- 11:17 AM Changeset in webkit [194648] by
-
- 2 edits in trunk/Websites/perf.webkit.org
Zooming button is broken on v3 UI
https://bugs.webkit.org/show_bug.cgi?id=152777
Reviewed by Chris Dumez.
Bring up the zoom button in z-index so that users can click it.
- public/v3/components/interactive-time-series-chart.js:
(InteractiveTimeSeriesChart.cssTemplate):
- 11:09 AM Changeset in webkit [194647] by
-
- 3 edits in trunk/Websites/perf.webkit.org
v3 UI doesn't preserve the time range when charts page is opened from a dashboard
https://bugs.webkit.org/show_bug.cgi?id=152776
Reviewed by Chris Dumez.
Fixed the bug by moving the construction of charts URL from DashboardPage.prototype.open to
DashboardPage.prototype.render and re-rendering the entire page upon an URL state transition.
- public/v3/pages/charts-page.js:
(ChartsPage.createStateForDashboardItem): Takes the start time for the charts page.
- public/v3/pages/dashboard-page.js:
(DashboardPage.prototype.updateFromSerializedState): Merged _numberOfDaysDidChange and
_updateChartsDomainFromToolbar into this function since they're not used elsewhere. Also re-render
the entire page when transition between different number of days to show.
(DashboardPage.prototype._numberOfDaysDidChange): Deleted.
(DashboardPage.prototype._updateChartsDomainFromToolbar): Deleted.
(DashboardPage.prototype.render): Construct URL for each charts here.
(DashboardPage.prototype._createChartForCell): Don't construct URL here since this function is
called once when the dashboard page is opened, and not when the time range is changed.
- 10:49 AM Changeset in webkit [194646] by
-
- 11 edits4 adds in trunk/Source
Add a WebKit SPI for registering an automation controller with RemoteInspector
https://bugs.webkit.org/show_bug.cgi?id=151576
Reviewed by Dan Bernstein and Joseph Pecoraro.
Source/JavaScriptCore:
Given a RemoteInspector endpoint that is instantiated in UIProcess, there
should be a way to delegate automation-related functionality and policy to
clients of WebKit.
This class adds a RemoteInspector::Client interface that serves a delegate.
This is ultimately delegated via _WKAutomationDelegate, which is an SPI
that allows clients to install an Objective-C delegate for automation.
The setting for whether remote automation is allowed is included in the
listing that RemoteInspector sends out. It is updated when RemoteInspector::Client
is assigned, or when the client signals that its capabilities have changed.
- inspector/remote/RemoteInspector.h:
- inspector/remote/RemoteInspector.mm:
(Inspector::RemoteInspector::setRemoteInspectorClient): Added.
(Inspector::RemoteInspector::pushListingsNow):
In the listing, include whether the application supports remote automation.
- inspector/remote/RemoteInspectorConstants.h: Add a constant.
Source/WebKit2:
_WKAutomationDelegate is a new SPI that allows WKProcessPool clients to decide
policy and implement actions for remote automation.
The SPI's implementation connects the client's delegate to RemoteInspector::Client.
This allows the delegate to handle some commands, such as requestAutomationSession,
that come over XPC from an external test runner but are not associated with a specific
automation target.
- PlatformMac.cmake:
- UIProcess/API/APIAutomationClient.h: Added. Boilerplate for WebKit::AutomationClient.
(API::AutomationClient::~AutomationClient):
(API::AutomationClient::allowsRemoteAutomation):
(API::AutomationClient::requestAutomationSession):
- UIProcess/API/Cocoa/WKProcessPool.mm:
(-[WKProcessPool _automationDelegate]): Added.
(-[WKProcessPool _setAutomationDelegate:]): Added.
(-[WKProcessPool _automationCapabilitiesDidChange]): Added.
- UIProcess/API/Cocoa/WKProcessPoolPrivate.h: Add delegate.
- UIProcess/API/Cocoa/_WKAutomationDelegate.h: Added.
This is a new delegate SPI of WKProcessPool; it corresponds to AutomationClient.
- UIProcess/Cocoa/AutomationClient.h: Added.
- UIProcess/Cocoa/AutomationClient.mm: Added.
This implements a bridge between RemoteInspector::Client and _WKAutomationDelegate.
Since the delegate can be called from JavaScriptCore, save the delegating
WKProcessPool and pass it as the self parameter to delegate methods.
(WebKit::AutomationClient::AutomationClient):
(WebKit::AutomationClient::~AutomationClient):
This client automatically registers and unregisters as a RemoteInspector::Client.
(WebKit::AutomationClient::remoteAutomationAllowed):
(WebKit::AutomationClient::requestAutomationSession):
Forward requests from RemoteInspector to the automation delegate.
- UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::WebProcessPool):
(WebKit::WebProcessPool::setAutomationClient): Added.
(WebKit::WebProcessPool::updateAutomationCapabilities): Added, it notifies RemoteInspector.
- UIProcess/WebProcessPool.h:
- WebKit2.xcodeproj/project.pbxproj:
- 10:34 AM Changeset in webkit [194645] by
-
- 3 edits2 adds in trunk
Float with media query positioned incorrectly after window resize.
https://bugs.webkit.org/show_bug.cgi?id=152558
Reviewed by Simon Fraser and David Hyatt.
This patch ensures that when a renderer becomes floated, it is moved
to the right containing block.
When this floated renderer's previous sibling is an anonymous block, it needs
to be reparented so that the float is positioned as if there was no anonymous block at all.
Source/WebCore:
Test: fast/block/float/float-with-anonymous-previous-sibling.html
- rendering/RenderElement.cpp:
(WebCore::RenderElement::styleDidChange):
LayoutTests:
- fast/block/float/float-with-anonymous-previous-sibling-expected.html: Added.
- fast/block/float/float-with-anonymous-previous-sibling.html: Added.
- 10:28 AM Changeset in webkit [194644] by
-
- 4 edits in trunk/Source/WebInspectorUI
Web Inspector: Add remaining background style properties to Visual sidebar
https://bugs.webkit.org/show_bug.cgi?id=152757
Patch by Devin Rousso <Devin Rousso> on 2016-01-06
Reviewed by Timothy Hatcher.
- Localizations/en.lproj/localizedStrings.js:
- UserInterface/Views/VisualStyleDetailsPanel.js:
(WebInspector.VisualStyleDetailsPanel.prototype._populateBackgroundStyleSection):
Added background-blend-mode and background-origin property editors.
- UserInterface/Views/VisualStyleSelectorSection.js:
(WebInspector.VisualStyleSelectorSection.prototype._handleMouseOver):
Unrelated error that occurred when the user was hovering over a selector item
before the tree outline was able to create the selected item.
- 10:25 AM Changeset in webkit [194643] by
-
- 8 edits1 add in trunk/Source/JavaScriptCore
[ES6] Boolean, Number, Map, RegExp, and Set should be subclassable
https://bugs.webkit.org/show_bug.cgi?id=152765
Reviewed by Michael Saboff.
This patch enables subclassing of five more builtins: Boolean, Number, Map, RegExp, and Set.
- runtime/BooleanConstructor.cpp:
(JSC::constructWithBooleanConstructor):
(JSC::constructBoolean): Deleted.
- runtime/BooleanConstructor.h:
- runtime/MapConstructor.cpp:
(JSC::constructMap):
- runtime/NumberConstructor.cpp:
(JSC::constructWithNumberConstructor):
- runtime/RegExpConstructor.cpp:
(JSC::getRegExpStructure):
(JSC::constructRegExp):
- runtime/SetConstructor.cpp:
(JSC::constructSet):
- tests/es6.yaml:
- tests/stress/class-subclassing-misc.js: Added.
(B):
(N):
(M):
(R):
(S):
(test):
- 10:23 AM Changeset in webkit [194642] by
-
- 2 edits in trunk/LayoutTests
Marking webarchive/adopt-attribute-styled-body-webarchive.html as flaky on mac-wk1
https://bugs.webkit.org/show_bug.cgi?id=152789
Unreviewed test gardening.
- platform/mac-wk1/TestExpectations:
- 10:10 AM Changeset in webkit [194641] by
-
- 2 edits in trunk/Source/JavaScriptCore
[mips] Fix branchTruncateDoubleToUint32 implementation in macro assembler
https://bugs.webkit.org/show_bug.cgi?id=152782
Patch by Julien Brianceau <jbriance@cisco.com> on 2016-01-06
Reviewed by Benjamin Poulain.
Already covered by LayoutTests/js/dfg-uint32array-overflow-values test.
- assembler/MacroAssemblerMIPS.h:
(JSC::MacroAssemblerMIPS::branchTruncateDoubleToUint32):
- 9:53 AM Changeset in webkit [194640] by
-
- 2 edits in trunk/Source/JavaScriptCore
[mips] Fix or32 implementation in macro assembler
https://bugs.webkit.org/show_bug.cgi?id=152781
Reviewed by Michael Saboff.
- assembler/MacroAssemblerMIPS.h:
(JSC::MacroAssemblerMIPS::or32):
- 9:50 AM Changeset in webkit [194639] by
-
- 2 edits in trunk/Source/JavaScriptCore
[mips] Add missing branchAdd32 implementation in macro assembler
https://bugs.webkit.org/show_bug.cgi?id=152785
Reviewed by Michael Saboff.
- assembler/MacroAssemblerMIPS.h:
(JSC::MacroAssemblerMIPS::branchAdd32):
- 8:57 AM Changeset in webkit [194638] by
-
- 4 edits2 adds in trunk
isAnonymousInlineBlock() should exclude any ruby content.
https://bugs.webkit.org/show_bug.cgi?id=152648
<rdar://problem/23872549>
Reviewed by David Hyatt.
isAnonymousInlineBlock is designed for the new Block-Inside-Inline Model
and all other anonymous inline-block renderers (including Ruby) should bail out of it.
(see webkit.org/b/143145)
Source/WebCore:
Test: fast/ruby/ruby-inline-margin-collapse-crash.html
- rendering/RenderObject.cpp:
(WebCore::RenderObject::isAnonymousInlineBlock):
- rendering/RenderObject.h:
(WebCore::RenderObject::isAnonymousInlineBlock): Deleted.
LayoutTests:
- fast/ruby/ruby-inline-margin-collapse-crash-expected.txt: Added.
- fast/ruby/ruby-inline-margin-collapse-crash.html: Added.
- 6:34 AM Changeset in webkit [194637] by
-
- 4 edits in trunk
[EFL] Set WebKit2 process output name
https://bugs.webkit.org/show_bug.cgi?id=152773
Reviewed by Benjamin Poulain.
If we add *WebKit* prefix to each WK2 process, it is more clear when checking what process is running.
So this patch sets wk2 process output name.
.:
- Source/cmake/OptionsEfl.cmake:
Source/WebKit2:
- PlatformEfl.cmake:
- 4:17 AM Changeset in webkit [194636] by
-
- 8 edits in trunk
[ES6] Date.prototype should be a plain object
https://bugs.webkit.org/show_bug.cgi?id=152574
Patch by Andy VanWagoner <thetalecrafter@gmail.com> on 2016-01-06
Reviewed by Benjamin Poulain.
Source/JavaScriptCore:
- runtime/DateConstructor.cpp:
(JSC::DateConstructor::finishCreation):
- runtime/DatePrototype.cpp:
(JSC::DatePrototype::DatePrototype):
- runtime/DatePrototype.h:
- tests/mozilla/mozilla-tests.yaml: Expect errors from old Date.prototype as Date instance tests.
LayoutTests:
Test that the non-generic Date.prototype methods throw when invoked
from the now generic object Date.prototype. Also test that this change
preserves correct instanceof behavior.
- js/date-proto-generic-invocation-expected.txt:
- js/script-tests/date-proto-generic-invocation.js:
- 2:43 AM Changeset in webkit [194635] by
-
- 9 edits1 add in trunk/Source/JavaScriptCore
[JSC] Get more of testb3 to pass on ARM64
https://bugs.webkit.org/show_bug.cgi?id=152737
Patch by Benjamin Poulain <bpoulain@apple.com> on 2016-01-06
Reviewed by Geoffrey Garen.
A bunch of minor bugs and missing function to make most of testb3
run on ARM64.
- JavaScriptCore.xcodeproj/project.pbxproj:
- assembler/ARM64Assembler.h:
(JSC::ARM64Assembler::canEncodePImmOffset):
(JSC::ARM64Assembler::canEncodeSImmOffset):
(JSC::isInt9): Deleted.
(JSC::isUInt12): Deleted.
- assembler/ARMv7Assembler.h:
- assembler/AssemblerCommon.h: Added.
(JSC::isInt9):
(JSC::isUInt12):
(JSC::isValidScaledUImm12):
(JSC::isValidSignedImm9):
- assembler/MacroAssemblerARM64.h:
(JSC::MacroAssemblerARM64::load16SignedExtendTo32):
(JSC::MacroAssemblerARM64::load8SignedExtendTo32):
(JSC::MacroAssemblerARM64::store16):
(JSC::MacroAssemblerARM64::absFloat):
(JSC::MacroAssemblerARM64::loadFloat):
(JSC::MacroAssemblerARM64::storeFloat):
(JSC::MacroAssemblerARM64::loadSignedAddressedByUnsignedImmediate):
(JSC::MacroAssemblerARM64::loadSignedAddressedByUnscaledImmediate):
(JSC::MacroAssemblerARM64::tryLoadSignedWithOffset):
(JSC::MacroAssemblerARM64::loadSignedAddressedByUnsignedImmediate<8>):
(JSC::MacroAssemblerARM64::loadSignedAddressedByUnsignedImmediate<16>):
(JSC::MacroAssemblerARM64::loadSignedAddressedByUnscaledImmediate<8>):
(JSC::MacroAssemblerARM64::loadSignedAddressedByUnscaledImmediate<16>):
- assembler/X86Assembler.h:
- b3/B3LowerToAir.cpp:
(JSC::B3::Air::LowerToAir::effectiveAddr):
(JSC::B3::Air::LowerToAir::lower):
- b3/air/AirArg.h:
(JSC::B3::Air::Arg::isValidImmForm):
(JSC::B3::Air::Arg::isValidAddrForm):
(JSC::B3::Air::Arg::isValidForm):
- b3/air/AirOpcode.opcodes:
- 2:15 AM Changeset in webkit [194634] by
-
- 3 edits in trunk/Tools
Python SCM should be able to retrieve untracked files - Add GIT support
https://bugs.webkit.org/show_bug.cgi?id=143135
Reviewed by Michael Catanzaro.
- Scripts/webkitpy/common/checkout/scm/git.py:
(Git.untracked_files): Adding support for git.
- Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
(GitTest.setUp):
(GitTest.test_untracked_files): Adding test.
- 2:13 AM WebKitGTK/Gardening/Calendar edited by
- (diff)
Jan 5, 2016:
- 11:17 PM Changeset in webkit [194633] by
-
- 6 edits in trunk
[CMake] Remove USE_UDIS86 variable
https://bugs.webkit.org/show_bug.cgi?id=152731
Reviewed by Gyuyoung Kim.
.:
Remove the USE_UDIS86 variable in CMake files. The specific build guard
is now enabled by default in Source/WTF/wtf/Platform.h, so the handling
in CMake isn't required anymore. The Udis86-specific files have to be
built unconditionally now, though.
- Source/cmake/OptionsEfl.cmake:
- Source/cmake/OptionsGTK.cmake:
- Source/cmake/OptionsMac.cmake:
Source/JavaScriptCore:
- CMakeLists.txt: Unconditionally build the Udis86-specific files.
- 10:05 PM Changeset in webkit [194632] by
-
- 2 edits in trunk/LayoutTests
Unreviewed IndexedDB test gardening
- platform/mac-wk1/TestExpectations: Update the current known status of a few tests.
- 10:00 PM Changeset in webkit [194631] by
-
- 2 edits in trunk/Source/WebCore
showRenderTree: add inline-block/inline/block column.
https://bugs.webkit.org/show_bug.cgi?id=152771
Reviewed by Simon Fraser.
The name of the renderer (RenderBlock etc) does not always reflect the associated display type.
No change in functionality.
- rendering/RenderObject.cpp:
(WebCore::showRenderTreeLegend):
(WebCore::RenderObject::showRenderObject):
- 8:12 PM Changeset in webkit [194630] by
-
- 9 edits in trunk/Source/WebCore
Move ImageBuffer::clip() code into GraphicsContext
https://bugs.webkit.org/show_bug.cgi?id=152769
Reviewed by Zalan Bujtas.
For CG, GraphicsContext had clipToNativeImage(PassNativeImagePtr...), which
was ugly and platform-specific.
Fix by moving code from ImageBuffer::clip() for CG and Cairo into the platform-specific
GraphicsContext implementations. This required some minor refactoring of scaleSizeToUserSpace()
in ImageBufferCG.
- platform/graphics/GraphicsContext.cpp:
(WebCore::GraphicsContext::clipToImageBuffer): Deleted.
- platform/graphics/ImageBuffer.cpp:
(WebCore::ImageBuffer::sizeForDestinationSize):
- platform/graphics/ImageBuffer.h:
- platform/graphics/cairo/GraphicsContextCairo.cpp:
(WebCore::GraphicsContext::clipToImageBuffer):
- platform/graphics/cairo/ImageBufferCairo.cpp:
(WebCore::ImageBuffer::clip): Deleted.
- platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::GraphicsContext::clipToImageBuffer):
(WebCore::GraphicsContext::clipToNativeImage): Deleted.
- platform/graphics/cg/ImageBufferCG.cpp:
(WebCore::ImageBuffer::ImageBuffer):
(WebCore::ImageBuffer::sizeForDestinationSize):
(WebCore::ImageBuffer::putByteArray):
(WebCore::ImageBuffer::toDataURL):
(WebCore::ImageBuffer::clip): Deleted.
- 8:12 PM Changeset in webkit [194629] by
-
- 4 edits in trunk/Source/WebCore
Remove GraphicsContext::drawJoinedLines()
https://bugs.webkit.org/show_bug.cgi?id=152764
Reviewed by Zalan Bujtas.
GraphicsContext::drawJoinedLines() was only used by iOS form-control drawing
and polluted GraphicsContext with platform-specific types.
Rewrite RenderThemeIOS::paintCheckboxDecorations() to use the CGContextRef directly.
- platform/graphics/GraphicsContext.h:
- platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::GraphicsContext::drawJoinedLines): Deleted.
- rendering/RenderThemeIOS.mm:
(WebCore::drawJoinedLines):
(WebCore::RenderThemeIOS::paintCheckboxDecorations):
- 7:43 PM Changeset in webkit [194628] by
-
- 7 edits in trunk/Source/JavaScriptCore
FTL B3 fails cdjs-tests.yaml/red_black_tree_test.js.ftl-eager-no-cjit
https://bugs.webkit.org/show_bug.cgi?id=152770
Reviewed by Mark Lam.
It turns out that liveness didn't know that the return value GPR or FPR is live at the
return. Consequently, we can end up with code that clobbers the return value register after
the move of the return value into that register. This could happen if we start with
something like:
Move 42(%tmp1), %tmp2
Move 50(%tmp1), %tmp3
Move %tmp3, 58(%tmp1)
Move %tmp2, %rax
Ret
Then we might coalesce %tmp2 with %rax:
Move 42(%tmp1), %rax
Move 50(%tmp1), %tmp3
Move %tmp3, 58(%tmp1)
Ret
But now there is no use of %rax after that first instruction, so %rax appears dead at the
other two Move's. So, the register allocator could then do this:
Move 42(%tmp1), %rax
Move 50(%tmp1), %rax
Move %rax, 58(%tmp1)
Ret
And that's clearly wrong. This patch solves this issue by replacing the old Ret instruction
with Ret32, Ret64, RetFloat, and RetDouble. These all take the return value register as an
argument. They also tell Air which parts of the return value register the caller will
observe. That's great for width analysis.
This resolves a test failure in the CDjs red_black_tree_test. This reduces the total number
of JSC test failures from 217 to 191.
- assembler/MacroAssembler.h:
(JSC::MacroAssembler::oops):
(JSC::MacroAssembler::ret32):
(JSC::MacroAssembler::ret64):
(JSC::MacroAssembler::retFloat):
(JSC::MacroAssembler::retDouble):
(JSC::MacroAssembler::shouldConsiderBlinding):
- b3/B3LowerToAir.cpp:
(JSC::B3::Air::LowerToAir::lower):
- b3/air/AirGenerate.cpp:
(JSC::B3::Air::generate):
- b3/air/AirHandleCalleeSaves.cpp:
(JSC::B3::Air::handleCalleeSaves):
- b3/air/AirOpcode.opcodes:
- b3/air/opcode_generator.rb:
- 7:27 PM Changeset in webkit [194627] by
-
- 2 edits in trunk/Websites/perf.webkit.org
Build fix for an old version of PHP after r194618.
- public/api/measurement-set.php:
- 6:36 PM Changeset in webkit [194626] by
-
- 4 edits in trunk/Source/WebKit2
Implement defersLoading with NetworkSession
https://bugs.webkit.org/show_bug.cgi?id=151818
Reviewed by Darin Adler.
- NetworkProcess/NetworkLoad.cpp:
(WebKit::NetworkLoad::NetworkLoad):
(WebKit::NetworkLoad::setDefersLoading):
- NetworkProcess/NetworkSession.h:
- NetworkProcess/cocoa/NetworkSessionCocoa.mm:
(WebKit::NetworkDataTask::resume):
(WebKit::NetworkDataTask::suspend):
- 6:08 PM Changeset in webkit [194625] by
-
- 10 edits in trunk
Modern IDB: storage/indexeddb/structured-clone.html crashes.
https://bugs.webkit.org/show_bug.cgi?id=152763
Reviewed by Alex Christensen.
Source/WebCore:
No new tests (At least one failing test now passes).
A lot of SerializedScriptValue code incorrectly assumed the global object is a JSDOMGlobalObject,
which doesn't have to be true for native Javascript types like typed arrays.
Fixing that fixes the test.
- Modules/indexeddb/client/IDBObjectStoreImpl.cpp:
(WebCore::IDBClient::IDBObjectStore::putOrAdd): If serializing the script value caused an exception,
clear that exception and return a better IDB specific exception.
- bindings/js/JSDOMBinding.h:
(WebCore::toJS): Add a ArrayBufferView specialization for toJS that skips the need for a JSDOMGlobalObject.
- bindings/js/SerializedScriptValue.cpp:
(WebCore::CloneDeserializer::readArrayBufferView): Call toJS directly instead of getJSValue, which
incorrectly assumes the existence of a JSDOMGlobalObject (vs a JSGlobalObject)
(WebCore::CloneDeserializer::readTerminal): Instead of getJSValue, call JSArrayBuffer::create directly.
LayoutTests:
- platform/mac-wk1/TestExpectations:
- storage/indexeddb/clone-exception-expected.txt:
- storage/indexeddb/exceptions-expected.txt:
- storage/indexeddb/objectstore-basics-expected.txt:
- storage/indexeddb/structured-clone-expected.txt:
- 5:56 PM Changeset in webkit [194624] by
-
- 2 edits in trunk/Source/WebKit2
REGRESSION (r192432): Keyboard repeat doesn't work anymore for arrow keys/spacebar
https://bugs.webkit.org/show_bug.cgi?id=152767
<rdar://problem/24017380>
Reviewed by Dan Bernstein.
- UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView _didHandleKeyEvent:eventWasHandled:]):
Instead of always bailing, call [super _handleKeyUIEvent:] if we aren't
in an editable area, because we won't have done so in _handleKeyUIEvent.
It's important that the event makes it to the root UIResponder (even if
we handled it!) for key repeat to function.
The double-scrolling case is still fixed because we notice the resent
event coming back in to us and bail if we've already seen it.
- 5:31 PM Changeset in webkit [194623] by
-
- 5 edits in tags/Safari-601.5.8.1/Source
Versioning.
- 5:28 PM Changeset in webkit [194622] by
-
- 1 copy in tags/Safari-601.5.8.1
New tag.
- 5:02 PM Changeset in webkit [194621] by
-
- 5 edits in tags/Safari-602.1.14.1/Source
Versioning.
- 4:43 PM Changeset in webkit [194620] by
-
- 1 copy in tags/Safari-601.1.46.90
New tag.
- 4:41 PM Changeset in webkit [194619] by
-
- 1 copy in tags/Safari-602.1.14.1
New tag.
- 4:13 PM Changeset in webkit [194618] by
-
- 13 edits9 adds in trunk/Websites/perf.webkit.org
A/B testing results should be visualized intuitively on v3 UI
https://bugs.webkit.org/show_bug.cgi?id=152496
Rubber-stamped by Chris Dumez.
Add the "stacking block" view of A/B testing results to the analysis task page on v3 UI.
The patch enhances JSON APIs at /api/analysis-task /api/measurement-set/ to reduce the number of
HTTP requests, and adds two UI components: TestGroupResultsTable and AnalysisResultsViewer both
of which inherits from an abstract superclass: ResultsTable.
ResultsTable provides a tabular presentation of measured values in regular measurement sets and
A/B testing results using groups of bar graphs created by BarGraphGroup. TestGroupResultsTable
inherits from this class to display A/B testing configurations and the averaged results for each
configuration, and AnalysisResultsViewer inherits from it to provide an intuitive visualization
of the outcomes of all A/B testing results associated with a given analysis task.
- public/api/analysis-tasks.php:
(main): Add the capability to find the analysis task based on its build request.
This allows /v3/#/analysis/task/?buildRequest=<id> to be hyperlinked on buildbot page.
- public/api/measurement-set.php:
(main): Removed the unused startTime and endTime, and added "analysisTask" to query parameters.
(AnalysisResultsFetcher): Added. Used to fetch measured data associated with every build request
on an analysis task.
(AnalysisResultsFetcher::construct):
(AnalysisResultsFetcher::fetch): Unlike MeasurementSetFetcher, we fetch the list of commits and
list of measurements separately since there will be a lot less builds and commits than measured
data (since we're fetching measured values for all tests and their metrics).
(AnalysisResultsFetcher::fetch_commits): Fetches commits.
(AnalysisResultsFetcher::format_measurement): Like MeasurementSetFetcher::format_measurement but
with config_type and config_metric since we're returning measured data for all metrics and test
configurations.
(AnalysisResultsFetcher::format_map): Similar to MeasurementSetFetcher::format_map.
- public/v3/components/analysis-results-viewer.js: Added.
(AnalysisResultsViewer): Added.
(AnalysisResultsViewer.prototype.didUpdateResults): This callback is called by AnalysisTaskPage
when A/B testing results become available.
(AnalysisResultsViewer.prototype.render): Overrides ResultsTable's render to highlight the block
representing the currently selected test group.
(AnalysisResultsViewer.prototype.buildRowGroups): Creates a list of rows with "stacking blocks"
that visualizes A/B testing results. The algorithm works as follows: 1. Create all table rows.
- Find which row is associated with each set in each test group. 3. Layout "blocks".
(AnalysisResultsViewer.prototype._collectRootSetsInTestGroups): Collects root sets from all data
in the measurement set as well as A/B testing requests (results may contain more repositories
than requested but they aren't interesting for the purpose of visualizing results for the entire
analysis task).
(AnalysisResultsViewer.prototype._buildRowsForPointsAndTestGroups): Create table rows. First,
create table rows for measurement set points that have a matching test group (i.e. either set A
or set B of an A/B testing uses the same root set as a point). Second, insert a new row for each
root set in each test group which didn't find a matching measurement set point. There is a little
subtlety that some A/B testing may specify revisions for a subset of repositories and/or some A/B
testing results may appear as if it goes back in time with respect to other A/B testing results.
For example, consider creating two A/B test groups for WebKit changes and OS changes separately.
There could be no coherent linearization of those two A/B testing in which both WebKit and OS
versions move forward.
(AnalysisResultsViewer.RootSetInTestGroup): Added. Represents a pair (test group, root set) since
a root set could be shared by multiple test groups.
(AnalysisResultsViewer.TestGroupStackingBlock): Added. A stacked block representing a test group.
(AnalysisResultsViewer.TestGroupStackingBlock.prototype.addRowIndex): Associates a row number with
either set A or set B.
(AnalysisResultsViewer.TestGroupStackingBlock.prototype.createStackingCell): Creates a table cell
for this block.
(AnalysisResultsViewer.TestGroupStackingBlock.prototype.isThin): Returns true if this test group
has failed and this block should look "thin" without any label.
(AnalysisResultsViewer.TestGroupStackingBlock.prototype._computeTestGroupStatus): Computes the
status for this test group.
(AnalysisResultsViewer.TestGroupStackingGrid): Added. AnalysisResultsViewer uses this class to
layout blocks representing test groups.
(AnalysisResultsViewer.TestGroupStackingGrid.prototype.insertBlockToColumn): Inserts a new block
to layout. We keep all test groups doing the same A/B test next to each other.
(AnalysisResultsViewer.TestGroupStackingGrid.prototype.layout): Layouts each block / test group
in the order they are created.
(AnalysisResultsViewer.TestGroupStackingGrid.prototype._layoutBlock): Places the block in the
left-most column that can accommodate it while avoiding columns of a different thin-ness. A column
is thin if its A/B testing has failed, and not thin otherwise.
(AnalysisResultsViewer.TestGroupStackingGrid.prototype.createCellsForRow): Creates table cells for
a given row. For each column, generate a table cell if we're in the first row and the first block
starts in a later row, a block starts in the current row, or the last block ended in the previous
row and the next block or the last row appears later.
- public/v3/components/bar-graph-group.js: Added. A component for showing a group of bar graphs.
(BarGraphGroup): Added. Creates a group of bar graphs with the same value range. It's used by
AnalysisResultsViewer and ResultsTable to show bar graphs to compare values.
(SingleBarGraph): A component created and collectively controlled by BarGraphGroup.
- public/v3/components/results-table.js: Added.
(ResultsTable): An abstract superclass for TestGroupResultsTable and AnalysisResultsViewer.
(ResultsTable.prototype.render): Renders the table. 1. Call "buildRowGroups()" implemented by
a subclass to obtain the list of rows. 2. Compute the list of repositories to show. 3. For each
cell in the table, compute the number of rows to show the same value (for rowspan). 4. Render the
table with an extra list of repositories if exists.
(ResultsTable.prototype._computeRepositoryList): Compute the list of repositories to list
revisions in the table. Omit repositories not present in any row or for which all rows have the
same revision. In the latter case, include it in the extra repositories listed below the table.
This minimizes the amount of redundant information presented to the user.
(ResultsTableRow): Added. Represents a single row in the table. ResultsTable constructs necessary
table cells to tabulate the associated root sets, and shows the associated result using a grouped
bar graph. Additional columns are used by AnalysisResultsViewer to show stacked blocks for A/B
testing groups.
- public/v3/components/test-group-results-table.js: Added.
(TestGroupResultsTable):
(TestGroupResultsTable.prototype.didUpdateResults):
(TestGroupResultsTable.prototype.setTestGroup):
(TestGroupResultsTable.prototype.heading):
(TestGroupResultsTable.prototype.render):
(TestGroupResultsTable.prototype.buildRowGroups):
- public/v3/index.html:
- public/v3/models/analysis-results.js: Added.
(AnalysisResults): Added. Like MeasurementSet, this class represents a set of measured values
associated with a given analysis task.
(AnalysisResults.prototype.find): Returns a measured valued for a given build and metric.
(AnalysisResults.prototype.add): Adds a new measured value. Used by AnalysisResults.fetch.
(AnalysisResults.fetch): Fetches data and creates AnalysisResults for a given analysis task.
- public/v3/models/analysis-task.js:
(AnalysisTask.prototype.startMeasurementId): Added.
(AnalysisTask.prototype.endMeasurementId): Added.
(AnalysisTask.fetchByBuildRequestId): Added.
(AnalysisTask._fetchSubset): Uses DataModelObject.cachedFetch.
- public/v3/models/build-request.js: Added.
(BuildRequest): Added. Represents a single A/B testing request associated with a test group.
- public/v3/models/builder.js:
(Build): Added. Represents a build associated with a given A/B testing result.
- public/v3/models/commit-log.js:
(CommitLog): Made this class inherit from DataModelObject.
(CommitLog.ensureSingleton): Added. Finds the singleton object created for a given revision
in the specified repository. This helps RootSet and other classes compare commits fast.
(CommitLog.prototype.repository): Added.
(CommitLog.fetchBetweenRevisions): Uses CommitLog.ensureSingleton.
- public/v3/models/data-model.js:
(DataModelObject):
(DataModelObject.namedStaticMap): Added.
(DataModelObject.ensureNamedStaticMap): Renamed from namedStaticMap instead of implicitly
assuming that the non-static version always creates the map.
(DataModelObject.prototype.namedStaticMap): Added.
(DataModelObject.cachedFetch): Extracted from AnalysisTask._fetchSubset so that TestGroup's
fetchByTask could also use it.
(LabeledObject):
- public/v3/models/measurement-adaptor.js: Added.
(MeasurementAdaptor): Extracted from MeasurementCluster. This class is responsible for
re-formatting the data received via /api/measurement-set JSON API inside the v3 UI.
(MeasurementAdaptor.prototype.extractId): Added.
(MeasurementAdaptor.prototype.adoptToAnalysisResults): Added. Used by AnalysisResults.
(MeasurementAdaptor.aggregateAnalysisResults): Added. Used by TestGroupResultsTable to
aggregate results for each test configuration; e.g. computing the average for set A.
(MeasurementAdaptor.prototype.adoptToSeries): Extracted from MeasurementCluster.addToSeries.
Added rootSet() to each point. This allows AnalysisResultsViewer to compare them against root
sets associated with A/B testing results.
(MeasurementAdaptor.computeConfidenceInterval): Moved from MeasurementCluster.
- public/v3/models/measurement-cluster.js:
(MeasurementCluster):
(MeasurementCluster.prototype.addToSeries):
- public/v3/models/repository.js:
(Repository.prototype.hasUrlForRevision): Added.
- public/v3/models/root-set.js: Added.
(RootSet): Added. Represents a set of commits in measured results.
(MeasurementRootSet): Added. Ditto for results associated with A/B testing.
- public/v3/models/test-group.js: Added.
(TestGroup): Added. Represents a A/B testing on analysis task.
(TestGroup.prototype.createdAt): Added.
(TestGroup.prototype.buildRequests): Returns the list of build requests associated with this
A/B testing.
(TestGroup.prototype.addBuildRequest): Added. Used by BuildRequest's constructor to associate
itself with this group.
(TestGroup.prototype.didSetResult): Added. Called by BuildRequest.setResult when measured
values are fetched and associated with a build request in this group.
- public/v3/models/test.js:
(Test):
- public/v3/pages/analysis-task-page.js:
(AnalysisTaskPage):
(AnalysisTaskPage.prototype.updateFromSerializedState): Fetch the analysis task, test groups
associated with it, and all A/B testing results based on the task id or the build request id
specified in the URL.
(AnalysisTaskPage.prototype._didFetchTask): Added. Start fetching the measured data. This is
the data on charts page for which this analysis task was created, not results of A/B testing.
(AnalysisTaskPage.prototype._didFetchMeasurement): Added. Display the fetched data in a table
inside AnalysisResultsViewer.
(AnalysisTaskPage.prototype._didFetchTestGroups): Added. Display the list of A/B test groups
as well as the results of the first A/B testing.
(AnalysisTaskPage.prototype._didFetchAnalysisResults): Added.
(AnalysisTaskPage.prototype._assignTestResultsIfPossible): Added. Once both the analysis task,
A/B test groups as well as their results are fetched, update build requests in each test group
with their results.
(AnalysisTaskPage.prototype.render): Show the list of test groups and highlight the currently
selected one.
(AnalysisTaskPage.prototype._showTestGroup): Added. A callback used by AnalysisResultsViewer
and TestGroupResultsTable to notify this class when the user selects a new test group.
(AnalysisTaskPage.htmlTemplate): Updated the template.
(AnalysisTaskPage.cssTemplate): Ditto.
- public/v3/pages/charts-page.js:
(ChartsPage.createStateForAnalysisTask): Added. Creates a URL state object for opening a chart
associated with an analysis task.
- 4:00 PM Changeset in webkit [194617] by
-
- 3 edits2 adds in trunk
Image should not be re-registered if m_form already exists. This leads to an assertion failure.
https://bugs.webkit.org/show_bug.cgi?id=152741
<rdar://problem/24030778>
Patch by Pranjal Jumde <pjumde@apple.com> on 2016-01-05
Reviewed by Brent Fulgham.
Source/WebCore:
- Source/WebCore/html/HTMLImageElement.cpp: Node::InsertionNotificationRequest HTMLImageElement::insertedInto(ContainerNode& insertionPoint)
LayoutTests:
- LayoutTests/fast/html/form-registerimg-multiple-crash-expected.txt: Added.
- LayoutTests/fast/html/form-registerimg-multiple-crash.html: Added.
- 3:53 PM Changeset in webkit [194616] by
-
- 2 edits in trunk/Source/JavaScriptCore
Unreviewed build fix. A symbol was being exported that should not have been.
- runtime/Structure.h:
- 3:45 PM Changeset in webkit [194615] by
-
- 7 edits in trunk
Unreviewed, rolling out r194603.
https://bugs.webkit.org/show_bug.cgi?id=152762
This change introduced JSC test failures (Requested by
ryanhaddad on #webkit).
Reverted changeset:
"[ES6] Date.prototype should be a plain object"
https://bugs.webkit.org/show_bug.cgi?id=152574
http://trac.webkit.org/changeset/194603
- 3:36 PM Changeset in webkit [194614] by
-
- 2 edits in trunk/Source/JavaScriptCore
stress/v8-crypto-strict.js.ftl-eager-no-cjit in FTL B3 fails with an assertion in the callframe shuffler
https://bugs.webkit.org/show_bug.cgi?id=152756
Reviewed by Saam Barati.
This fixes a really obvious and dumb tail call bug in FTL B3. I think that tail calls work
for real now. I have no idea why I got any tail call tests to pass before this fix.
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::DFG::LowerDFGToLLVM::compileTailCall):
- 3:08 PM Changeset in webkit [194613] by
-
- 16 edits in trunk/Source/JavaScriptCore
Profiling should detect when multiplication overflows but does not create negative zero.
https://bugs.webkit.org/show_bug.cgi?id=132470
Reviewed by Geoffrey Garen.
- assembler/MacroAssemblerARM64.h:
(JSC::MacroAssemblerARM64::or32):
- assembler/MacroAssemblerARMv7.h:
(JSC::MacroAssemblerARMv7::or32):
- New or32 emitter needed by the mul snippet.
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::resultProfileForBytecodeOffset):
(JSC::CodeBlock::updateResultProfileForBytecodeOffset): Deleted.
- bytecode/CodeBlock.h:
(JSC::CodeBlock::ensureResultProfile):
(JSC::CodeBlock::addResultProfile): Deleted.
(JSC::CodeBlock::likelyToTakeDeepestSlowCase): Deleted.
- Added a m_bytecodeOffsetToResultProfileIndexMap because we can now add result profiles in any order (based on runtime execution), not necessarily in bytecode order at baseline compilation time.
- bytecode/ValueProfile.cpp:
(WTF::printInternal):
- bytecode/ValueProfile.h:
(JSC::ResultProfile::didObserveInt52Overflow):
(JSC::ResultProfile::setObservedInt52Overflow):
- Add new Int52Overflow flags.
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::makeSafe):
- Now with more straightforward mapping of profiling info.
- dfg/DFGCommon.h:
- Fixed a typo in a comment.
- dfg/DFGNode.h:
(JSC::DFG::Node::arithNodeFlags):
(JSC::DFG::Node::mayHaveNonIntResult):
(JSC::DFG::Node::hasConstantBuffer):
- dfg/DFGNodeFlags.cpp:
(JSC::DFG::dumpNodeFlags):
- dfg/DFGNodeFlags.h:
(JSC::DFG::nodeMayOverflowInt52):
(JSC::DFG::nodeCanSpeculateInt52):
- dfg/DFGPredictionPropagationPhase.cpp:
(JSC::DFG::PredictionPropagationPhase::propagate):
- We now have profiling info for whether the result was ever seen to be a non-Int. Use this to make a better prediction.
- jit/JITArithmetic.cpp:
(JSC::JIT::emit_op_div):
(JSC::JIT::emit_op_mul):
- Switch to using CodeBlock::ensureResultProfile(). ResultProfiles can now be created at any time (including the slow path), not just in bytecode order during baseline compilation.
- jit/JITMulGenerator.cpp:
(JSC::JITMulGenerator::generateFastPath):
- Removed the fast path profiling code for NegZero because we'll go to the slow path anyway. Let the slow path do the profiling for us.
- Added profiling for NegZero and potential Int52 overflows in the fast path that does double math.
- runtime/CommonSlowPaths.cpp:
(JSC::updateResultProfileForBinaryArithOp):
- Removed the RETURN_WITH_RESULT_PROFILING macro (2 less macros), and just use the RETURN_WITH_PROFILING macro instead with a call to updateResultProfileForBinaryArithOp(). This makes it clear what we're doing to do profiling in each case, and also allows us to do custom profiling for each opcode if needed. However, so far, we always call updateResultProfileForBinaryArithOp().
- 2:49 PM Changeset in webkit [194612] by
-
- 8 edits1 add in trunk/Source/JavaScriptCore
[ES6] Arrays should be subclassable.
https://bugs.webkit.org/show_bug.cgi?id=152706
Reviewed by Benjamin Poulain.
This patch enables full subclassing of Arrays. We do this by fetching the new.target's prototype property
in the Array constructor and transitioning the old structure to have the new prototype. This method has
two downsides. The first is that we clobber the transition watchpoint on the base structure. The second,
which is currently very significant but should be fixed in a future patch, is that we allocate a new
structure for each new derived class we allocate.
- runtime/ArrayConstructor.cpp:
(JSC::constructArrayWithSizeQuirk):
(JSC::constructWithArrayConstructor):
(JSC::callArrayConstructor):
- runtime/ArrayConstructor.h:
- runtime/JSGlobalObject.h:
(JSC::JSGlobalObject::arrayStructureForIndexingTypeDuringAllocation):
(JSC::JSGlobalObject::arrayStructureForProfileDuringAllocation):
(JSC::constructEmptyArray):
(JSC::constructArray):
(JSC::constructArrayNegativeIndexed):
- runtime/PrototypeMap.h:
- runtime/Structure.h:
- runtime/StructureInlines.h:
(JSC::Structure::createSubclassStructure):
- tests/es6.yaml:
- tests/stress/class-subclassing-array.js: Added.
(A):
(B.prototype.get 1):
(B):
(C):
(test):
- 2:49 PM Changeset in webkit [194611] by
-
- 4 edits in trunk/Websites/perf.webkit.org
Analysis task page is slow to load
https://bugs.webkit.org/show_bug.cgi?id=152517
Reviewed by Andreas Kling.
The slowness comes from r194130 which made the JSON API at /api/analysis-tasks to report the start
and the end of each analysis task. This query was adding ~2s to the total JSON generation time.
Cache these values on analysis_task table since they never change once an analysis task is created.
- init-database.sql: Added columns task_start_run_time and task_end_run_time to analysis_task table.
Also added the missing drop statements at the top.
- public/api/analysis-tasks.php:
(fetch_and_push_bugs_to_tasks): Don't fetch the latest commit time of the start and the end.
(format_task): Report task_start_run_time and task_end_run_time as startRunTime and endRunTime.
- public/privileged-api/create-analysis-task.php:
(main): Set start_run_time and end_run_time when creating an analysis task.
(time_for_run): Added.
- 2:45 PM Changeset in webkit [194610] by
-
- 5 edits in tags/Safari-601.1.46.89.1/Source
Versioning.
- 2:41 PM Changeset in webkit [194609] by
-
- 1 copy in tags/Safari-601.1.46.89.1
New tag.
- 2:38 PM Changeset in webkit [194608] by
-
- 5 edits in trunk/Source/JavaScriptCore
regress/script-tests/deltablue-varargs.js.ftl-no-cjit-no-put-stack-validate on FTL B3 gets a B3 validation failure
https://bugs.webkit.org/show_bug.cgi?id=152754
Reviewed by Geoffrey Garen and Saam Barati.
It turns out that the FTL was creating orphans. Rather than making the FTL handle them by
itself, I gave B3 the power to eliminate them for you. I also made the dumper print them
since otherwise, you wouldn't know anything about the orphan when looking at a validation
failure or other kind of procedure dump.
- b3/B3IndexSet.h:
(JSC::B3::IndexSet::add):
(JSC::B3::IndexSet::addAll):
(JSC::B3::IndexSet::remove):
- b3/B3Procedure.cpp:
(JSC::B3::Procedure::dump):
(JSC::B3::Procedure::deleteValue):
(JSC::B3::Procedure::deleteOrphans):
(JSC::B3::Procedure::dominators):
- b3/B3Procedure.h:
(JSC::B3::Procedure::cfg):
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::DFG::LowerDFGToLLVM::lower):
- 2:09 PM Changeset in webkit [194607] by
-
- 14 edits in trunk
Adjust tile coverage with margin tiles, and tidy up the indicator
https://bugs.webkit.org/show_bug.cgi?id=152742
Reviewed by Beth Dakin.
Source/WebCore:
The tile coverage rect was unfeasibly large when margin tiles are present, and
could be bigger than the layer itself, making the indicator look odd.
Fix by improving the logic in TileController::adjustTileCoverageRect(): this
now first extends the visible rect for scrolling, and then constrains it
within the bounds with margin padding. It also unites with the passed-in
coverageRect, ensuring that we don't lose information about overhang for
margin tile coverage.
Second, update the tiled scrolling indicator when the visible rect changes,
and coalesce the map updates on a timer.
- platform/graphics/TiledBacking.h:
- platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::adjustCoverageRect):
- platform/graphics/ca/TileController.cpp:
(WebCore::TileController::setVisibleRect):
(WebCore::TileController::setTiledScrollingIndicatorPosition):
(WebCore::expandRectWithinRect):
(WebCore::TileController::adjustTileCoverageRect):
(WebCore::TileController::updateTileCoverageMap):
(WebCore::TileController::computeTileCoverageRect): Deleted.
- platform/graphics/ca/TileController.h:
- platform/graphics/ca/TileCoverageMap.cpp:
(WebCore::TileCoverageMap::TileCoverageMap):
(WebCore::TileCoverageMap::setNeedsUpdate):
(WebCore::TileCoverageMap::updateTimerFired):
- platform/graphics/ca/TileCoverageMap.h:
LayoutTests:
New baselines. simple-document-with-margin-tiles.html needs to wait for over 0.5s
for the FrameView::enableSpeculativeTilingIfNeeded() timer to fire before
dumping coverage (ouch).
- tiled-drawing/scrolling/fast-scroll-iframe-latched-iframe-expected.txt:
- tiled-drawing/scrolling/fast-scroll-iframe-latched-iframe-with-handler-expected.txt:
- tiled-drawing/scrolling/fast-scroll-iframe-latched-mainframe-expected.txt:
- tiled-drawing/scrolling/fast-scroll-iframe-latched-mainframe-with-handler-expected.txt:
- tiled-drawing/simple-document-with-margin-tiles.html:
- 2:04 PM Changeset in webkit [194606] by
-
- 4 edits in trunk/Source/JavaScriptCore
Re-landing: Add validation of JSC options to catch typos.
https://bugs.webkit.org/show_bug.cgi?id=152549
Reviewed by Benjamin Poulain.
- If a JSC_xxx option is found and xxx is not a valid option, we will now log an error message.
- If a --xxx jsc option is specified, but xxx is not a valid option, we will now log an error message.
- Added JSC_validateOptions, which if set to true will cause the VM to crash if an invalid option was seen during options parsing.
In this version for re-landing, I removed the change where I disallowed -- options
after the script name. Apparently, we have some test harnesses that do append the
-- options after the script name.
- jsc.cpp:
(CommandLine::parseArguments):
- runtime/Options.cpp:
(JSC::Options::initialize):
- runtime/Options.h:
- 1:30 PM Changeset in webkit [194605] by
-
- 2 edits in trunk/LayoutTests
IDB test gardening.
Rubberstamped by Alex Christensen.
- platform/mac-wk1/TestExpectations: Unskip a passing test, and move a test from "times out" to "fails"
- 1:25 PM Changeset in webkit [194604] by
-
- 2 edits in trunk/Source/JavaScriptCore
FTL B3 should do ArithNegate
https://bugs.webkit.org/show_bug.cgi?id=152745
Reviewed by Geoffrey Garen.
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::DFG::LowerDFGToLLVM::compileArithNegate):
- 1:19 PM Changeset in webkit [194603] by
-
- 7 edits in trunk
[ES6] Date.prototype should be a plain object
https://bugs.webkit.org/show_bug.cgi?id=152574
Patch by Andy VanWagoner <thetalecrafter@gmail.com> on 2016-01-05
Reviewed by Benjamin Poulain.
Source/JavaScriptCore:
- runtime/DateConstructor.cpp:
(JSC::DateConstructor::finishCreation):
- runtime/DatePrototype.cpp:
(JSC::DatePrototype::DatePrototype):
- runtime/DatePrototype.h:
LayoutTests:
Test that the non-generic Date.prototype methods throw when invoked
from the now generic object Date.prototype. Also test that this change
preserves correct instanceof behavior.
- js/date-proto-generic-invocation-expected.txt:
- js/script-tests/date-proto-generic-invocation.js:
- 1:11 PM Changeset in webkit [194602] by
-
- 2 edits in trunk/Source/WebInspectorUI
REGRESSION(r187929): Web Inspector: Forced Layout and Style Recalculation records do not show up in Layout & Rendering timeline DataGrid
https://bugs.webkit.org/show_bug.cgi?id=152747
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-01-05
Reviewed by Timothy Hatcher.
- UserInterface/Views/LayoutTimelineView.js:
(WebInspector.LayoutTimelineView.prototype._layoutTimelineRecordAdded):
We want top-level Layout records. Not necessarily Layout records that are
at the top of all records. Layout events such as style recalculation
and forced layout may be triggered by script and therefore not be at
the top of all records.
- 12:56 PM Changeset in webkit [194601] by
-
- 3 edits in trunk/Tools
Rename badly named JSC_timeout env var to JSCTEST_timeout.
https://bugs.webkit.org/show_bug.cgi?id=152748
Reviewed by Geoffrey Garen.
Now that we validate JSC options, the badly named JSC_timeout env var causes the
bots to have a bad time.
- Scripts/run-javascriptcore-tests:
- Scripts/run-jsc-stress-tests:
- 12:56 PM Changeset in webkit [194600] by
-
- 5 edits in branches/safari-601.1.46-branch/Source
Versioning.
- 12:39 PM Changeset in webkit [194599] by
-
- 4 edits in trunk/Source/JavaScriptCore
Unreviewed, rolling out r194590.
https://bugs.webkit.org/show_bug.cgi?id=152751
"Causes bot failures" (Requested by mlam on #webkit).
Reverted changeset:
"Add validation of JSC options to catch typos."
https://bugs.webkit.org/show_bug.cgi?id=152549
http://trac.webkit.org/changeset/194590
- 12:39 PM Changeset in webkit [194598] by
-
- 2 edits in trunk/Source/JavaScriptCore
FTL B3 should do In
https://bugs.webkit.org/show_bug.cgi?id=152744
Reviewed by Michael Saboff.
This was easy; I just used the same idiom that we already established for ICs in FTL B3.
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::DFG::LowerDFGToLLVM::compileIn):
- 12:38 PM Changeset in webkit [194597] by
-
- 10 edits in trunk/LayoutTests
Make ftl-polymorphic-xxx tests more polymorphic.
https://bugs.webkit.org/show_bug.cgi?id=152736
Reviewed by Saam Barati.
- Change the test driver to alternate inputs between numeric operands and an object with a valueOf() method.
- Changed busy work blob to use the operator being tested instead of always using the + operator.
- Updated test results.
With these change, the tests each triggers around 49000+ speculation failures when
run as a benchmark on the VM before the fix for https://webkit.org/b/152708
landed (in r194560: <http://trac.webkit.org/r194560>). After the fix, the
number of speculation failures is around 11 or lower.
The benchmark perf with these tests shows about a 10% gain on x86 (32-bit with no
FTL) and about 2x on x86_64 (64-bit with FTL).
- js/regress/script-tests/ftl-polymorphic-bitand.js:
- js/regress/script-tests/ftl-polymorphic-bitor.js:
- js/regress/script-tests/ftl-polymorphic-bitxor.js:
- js/regress/script-tests/ftl-polymorphic-div.js:
- js/regress/script-tests/ftl-polymorphic-lshift.js:
- js/regress/script-tests/ftl-polymorphic-mul.js:
- js/regress/script-tests/ftl-polymorphic-rshift.js:
- js/regress/script-tests/ftl-polymorphic-sub.js:
- js/regress/script-tests/ftl-polymorphic-urshift.js:
- 12:36 PM Changeset in webkit [194596] by
-
- 2 edits in trunk/Source/WebCore
Remove selector filter update calls from Element child parsing callbacks
https://bugs.webkit.org/show_bug.cgi?id=152749
Reviewed by Andreas Kling.
We haven't done style resolve during parsing for a while now. These calls do nothing useful.
- dom/Element.cpp:
(WebCore::Element::beginParsingChildren):
(WebCore::Element::finishParsingChildren):
- 11:57 AM Changeset in webkit [194595] by
-
- 11 edits in trunk
Modern IDB: Error message updates for two failing tests.
https://bugs.webkit.org/show_bug.cgi?id=152735
Reviewed by Alex Christensen.
Source/WebCore:
No new tests (Covered by existing tests).
Add error messages for various operations on deleted objects.
- Modules/indexeddb/client/IDBCursorImpl.cpp:
(WebCore::IDBClient::IDBCursor::update):
(WebCore::IDBClient::IDBCursor::advance):
(WebCore::IDBClient::IDBCursor::continueFunction):
(WebCore::IDBClient::IDBCursor::deleteFunction):
- Modules/indexeddb/client/IDBIndexImpl.cpp:
(WebCore::IDBClient::IDBIndex::openCursor):
(WebCore::IDBClient::IDBIndex::doCount):
(WebCore::IDBClient::IDBIndex::openKeyCursor):
(WebCore::IDBClient::IDBIndex::doGet):
(WebCore::IDBClient::IDBIndex::doGetKey):
- Modules/indexeddb/client/IDBObjectStoreImpl.cpp:
(WebCore::IDBClient::IDBObjectStore::openCursor):
(WebCore::IDBClient::IDBObjectStore::get):
(WebCore::IDBClient::IDBObjectStore::putOrAdd):
(WebCore::IDBClient::IDBObjectStore::deleteFunction):
(WebCore::IDBClient::IDBObjectStore::clear):
(WebCore::IDBClient::IDBObjectStore::createIndex):
(WebCore::IDBClient::IDBObjectStore::index):
(WebCore::IDBClient::IDBObjectStore::deleteIndex):
(WebCore::IDBClient::IDBObjectStore::doCount):
- bindings/js/JSIDBObjectStoreCustom.cpp:
(WebCore::JSIDBObjectStore::createIndex):
LayoutTests:
- Update results to accommodate new error messages.
- openKeyCursor on IDBObjectStore has been removed, so remove that from the results.
- "undefined" and "null" are invalid keys, so update the keypath-basics test to reflect this.
- platform/mac-wk1/TestExpectations:
- storage/indexeddb/deleted-objects-expected.txt:
- storage/indexeddb/keypath-basics-expected.txt:
- storage/indexeddb/resources/keypath-basics.js:
- storage/indexeddb/transaction-basics-expected.txt:
- 11:42 AM Changeset in webkit [194594] by
-
- 3 edits in trunk/Source/JavaScriptCore
Implement B3 version of FTL::Output::check()
https://bugs.webkit.org/show_bug.cgi?id=152743
Reviewed by Geoffrey Garen.
Turns out this was just like the LLVM version.
- ftl/FTLB3Output.cpp:
(JSC::FTL::Output::branch):
(JSC::FTL::Output::check):
- ftl/FTLB3Output.h:
(JSC::FTL::Output::switchInstruction):
(JSC::FTL::Output::check): Deleted.
- 11:38 AM Changeset in webkit [194593] by
-
- 2 edits in trunk/Source/WebKit2
[Mac] Exiting fullscreen via Mission Control leaves fullcreen window frontmost on desktop
https://bugs.webkit.org/show_bug.cgi?id=152733
Reviewed by Eric Carlson.
Rather than ignore -windowDidExitFullScreen: notifications when fullscreen exit was
not initiated by WebKit (and the -window:startCustomAnimationToEnterFullScreenWithDuration:
method was not called), continue to exit fullscreen normally.
- UIProcess/mac/WKFullScreenWindowController.mm:
(-[WKFullScreenWindowController finishedExitFullScreenAnimation:]):
- 11:24 AM Changeset in webkit [194592] by
-
- 6 edits in trunk/Source/WebKit2
Clean up download code
https://bugs.webkit.org/show_bug.cgi?id=152739
Reviewed by Brady Eidson.
- NetworkProcess/Downloads/DownloadManager.cpp:
(WebKit::DownloadManager::DownloadManager):
(WebKit::DownloadManager::didCreateDownload):
(WebKit::DownloadManager::didDestroyDownload):
(WebKit::DownloadManager::downloadProxyConnection):
(WebKit::DownloadManager::downloadsAuthenticationManager):
- NetworkProcess/Downloads/DownloadManager.h:
Keep a Client& instead of a Client*.
- NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::downloadManager):
- NetworkProcess/NetworkSession.h:
m_sessionID is not used. There is no need to store the sessionID if it is only used in the NetworkSession constructor.
- NetworkProcess/cocoa/NetworkSessionCocoa.mm:
(WebKit::NetworkSession::defaultSession):
(WebKit::NetworkSession::NetworkSession):
- 11:12 AM Changeset in webkit [194591] by
-
- 4 edits in trunk/Source/JavaScriptCore
Add support for aliasing JSC Options.
https://bugs.webkit.org/show_bug.cgi?id=152551
Reviewed by Filip Pizlo.
This allows us to use old options names as well. This is for the benefit of
third party tools which may have been built to rely on those old options. The
old option names will be mapped to the current option names in setOption().
For some options, the old option name specifies the inverse boolean value of the
current option name. setOption() will take care of inverting the value before
applying it to the option.
- jsc.cpp:
(CommandLine::parseArguments):
- Switch to dumping only overridden options here. Verbose dumping is too much for common usage.
- runtime/Options.cpp:
(JSC::overrideOptionWithHeuristic):
(JSC::Options::overrideAliasedOptionWithHeuristic):
(JSC::computeNumberOfWorkerThreads):
(JSC::Options::initialize):
(JSC::Options::setOptionWithoutAlias):
(JSC::invertBoolOptionValue):
(JSC::Options::setAliasedOption):
(JSC::Options::setOption):
(JSC::Options::dumpAllOptions):
- String.ascii() converts newline characters to '?', and this was messing up the printing of the options. Switched to using String.utf8() instead.
(JSC::Options::dumpOption):
- runtime/Options.h:
- 11:03 AM Changeset in webkit [194590] by
-
- 4 edits in trunk/Source/JavaScriptCore
Add validation of JSC options to catch typos.
https://bugs.webkit.org/show_bug.cgi?id=152549
Reviewed by Benjamin Poulain.
- If a JSC_xxx option is found and xxx is not a valid option, we will now log an error message.
- The jsc app is commonly used as follows:
$ jsc [jsc options] [scripts]
Previously, we'll continue to parse for [jsc options] after [scripts] is seen.
We won't do this anymore. Any --xxx jsc options must precede the [scripts]
arguments.
- If a --xxx jsc option is specified, but xxx is not a valid option, we will now log an error message.
- Added JSC_validateOptions, which if set to true will cause the VM to crash if an invalid option was seen during options parsing.
- jsc.cpp:
(CommandLine::parseArguments):
- runtime/Options.cpp:
(JSC::Options::initialize):
- runtime/Options.h:
- 9:58 AM Changeset in webkit [194589] by
-
- 2 edits in trunk/Source/WebCore
Avoid NULL deference in Page::updateIsPlayingMedia
https://bugs.webkit.org/show_bug.cgi?id=152732
No new tests, this fixes a rare crash that I am unable to reproduce.
Reviewed by David Kilzer.
- page/Page.cpp:
(WebCore::Page::updateIsPlayingMedia): frame->document() can return NULL.
- 9:55 AM Changeset in webkit [194588] by
-
- 2 edits in trunk/LayoutTests
IndexedDB TestExpectations gardening.
Reviewed by Alex Christensen.
- Enable 3 flakes that should now not be flakey.
- Unskip some previously crashing tests, but mark as text failures.
- Move some tests around with better comments.
- platform/mac-wk1/TestExpectations:
- 9:44 AM Changeset in webkit [194587] by
-
- 8 edits4 adds in trunk
Modern IDB: Transactions from a previous page can leak forward to the next.
https://bugs.webkit.org/show_bug.cgi?id=152698
Reviewed by Alex Christensen.
Source/WebCore:
Test: storage/indexeddb/modern/transactions-stop-on-navigation.html
This patch is mostly about actually implementing IDBDatabase::stop and IDBTransaction::stop.
Most of the rest of the scattered changes are about cleaning up now-incorrect ASSERTs.
- Modules/indexeddb/client/IDBDatabaseImpl.cpp:
(WebCore::IDBClient::IDBDatabase::close):
(WebCore::IDBClient::IDBDatabase::maybeCloseInServer):
(WebCore::IDBClient::IDBDatabase::stop):
(WebCore::IDBClient::IDBDatabase::startVersionChangeTransaction):
(WebCore::IDBClient::IDBDatabase::didAbortTransaction):
- Modules/indexeddb/client/IDBDatabaseImpl.h:
- Modules/indexeddb/client/IDBOpenDBRequestImpl.cpp:
(WebCore::IDBClient::IDBOpenDBRequest::requestCompleted):
- Modules/indexeddb/client/IDBRequestImpl.h:
- Modules/indexeddb/client/IDBTransactionImpl.cpp:
(WebCore::IDBClient::IDBTransaction::IDBTransaction):
(WebCore::IDBClient::IDBTransaction::stop):
(WebCore::IDBClient::IDBTransaction::abortOnServerAndCancelRequests):
- Modules/indexeddb/server/UniqueIDBDatabase.cpp:
(WebCore::IDBServer::UniqueIDBDatabase::performCurrentDeleteOperation):
(WebCore::IDBServer::UniqueIDBDatabase::didPerformAbortTransaction):
LayoutTests:
- storage/indexeddb/modern/resources/transactions-stop-on-navigation-2.html: Added.
- storage/indexeddb/modern/resources/transactions-stop-on-navigation.js: Added.
- storage/indexeddb/modern/transactions-stop-on-navigation-expected.txt: Added.
- storage/indexeddb/modern/transactions-stop-on-navigation.html: Added.
- 9:31 AM Changeset in webkit [194586] by
-
- 5 edits in trunk/Source/WebCore
Unreviewed. Attempting to fix the AppleWin build after r194577.
Add the ClipStack.cpp build target alongside the TextureMapperGL.cpp
one, since both include GraphicsContext3D.h and ANGLEWebKitBridge.h
indirectly, the latter requiring specific include flags.
- CMakeLists.txt:
- PlatformEfl.cmake:
- PlatformGTK.cmake:
- PlatformWinCairo.cmake:
- 9:14 AM Changeset in webkit [194585] by
-
- 4 edits in trunk/Source/ThirdParty
gtest should use the same SDK as other projects
https://bugs.webkit.org/show_bug.cgi?id=152718
rdar://problem/23566856
Reviewed by Alex Christensen.
gtest configuration attempted to use USE_INTERNAL_SDK without ever defining it.
- gtest/xcode/Config/DebugProject.xcconfig:
- gtest/xcode/Config/General.xcconfig:
- gtest/xcode/Config/ReleaseProject.xcconfig:
- 8:10 AM Changeset in webkit [194584] by
-
- 16 edits2 adds in trunk/Source/WebCore
Move StyleChange enum into a separate file
https://bugs.webkit.org/show_bug.cgi?id=152730
Reviewed by Andreas Kling.
Fewer whole-world rebuilds.
- CMakeLists.txt:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.xcodeproj/project.pbxproj:
- dom/CharacterData.cpp:
- dom/ContainerNode.cpp:
- dom/Document.cpp:
- dom/Document.h:
- dom/Element.cpp:
- dom/Element.h:
- style/StyleChange.h: Added.
- style/StyleResolveTree.cpp:
(WebCore::Style::shouldCreateRenderer):
(WebCore::Style::determineChange): Deleted.
- style/StyleResolveTree.h:
- 5:47 AM Changeset in webkit [194583] by
-
- 2 edits in trunk/LayoutTests
Marking imported/w3c/web-platform-tests/html/dom/dynamic-markup-insertion/opening-the-input-stream/010.html
as failing (before https://bugs.webkit.org/show_bug.cgi?id=151984 it was timing out)
Unreviewed.
- 4:44 AM Changeset in webkit [194582] by
-
- 4 edits105 adds1 delete in trunk/LayoutTests
Activate service-workers import
https://bugs.webkit.org/show_bug.cgi?id=152686
Reviewed by Daniel Bates.
LayoutTests/imported/w3c:
Importing service-workers tests, as some resource files are used by other test files.
These tests are skipped as WebKit does not support service worker.
Revision used is 5932fd48d519a83b4cca6ed69778547a4fdfc5ae as for all other WPT tests.
- resources/ImportExpectations: Activating import of service worker tests.
- web-platform-tests/service-workers/cache-storage/common.https.html: Added.
- web-platform-tests/service-workers/cache-storage/resources/blank.html: Added.
- web-platform-tests/service-workers/cache-storage/resources/common-worker.js: Added.
(self.onmessage):
- web-platform-tests/service-workers/cache-storage/resources/fetch-status.py: Added.
(main):
- web-platform-tests/service-workers/cache-storage/resources/iframe.html: Added.
- web-platform-tests/service-workers/cache-storage/resources/simple.txt: Added.
- web-platform-tests/service-workers/cache-storage/resources/test-helpers.js: Added.
(create_temporary_cache):
(cache_test):
- web-platform-tests/service-workers/cache-storage/resources/testharness-helpers.js: Added.
(assert_promise_rejects):
(assert_response_equals):
(assert_response_array_equivalent):
(assert_response_array_equals):
(assert_response_in_array):
- web-platform-tests/service-workers/cache-storage/resources/w3c-import.log: Added.
- web-platform-tests/service-workers/cache-storage/script-tests/cache-add.js: Added.
(cache_test):
- web-platform-tests/service-workers/cache-storage/script-tests/cache-delete.js: Added.
(new_test_request):
(new_test_response):
(cache_test):
(prepopulated_cache_test):
- web-platform-tests/service-workers/cache-storage/script-tests/cache-match.js: Added.
(response.new.Response):
(return.cache.matchAll.string_appeared_here.then):
(return.cache.match.string_appeared_here.then):
(return.cache.matchAll.entries.a.request.url.then):
(return.cache.match.entries.a.request.url.then):
(return.cache.matchAll.entries.a.request.then):
(return.cache.match.entries.a.request.then):
(return.cache.matchAll.new.Request.entries.a.request.url.then):
(return.cache.match.new.Request.entries.a.request.url.then):
(then):
(return.cache.matchAll.entries.cat.request.url.string_appeared_here.then):
(return.cache.match.entries.cat.request.url.string_appeared_here.then):
(cache_test):
(return.cache.match.request.then):
(prepopulated_cache_test):
- web-platform-tests/service-workers/cache-storage/script-tests/cache-put.js: Added.
(cache_test):
- web-platform-tests/service-workers/cache-storage/script-tests/cache-storage-keys.js: Added.
(promise_test):
- web-platform-tests/service-workers/cache-storage/script-tests/cache-storage-match.js: Added.
(create_unique_transaction):
(cache_test):
(promise_test):
- web-platform-tests/service-workers/cache-storage/script-tests/cache-storage.js: Added.
(promise_test):
(promise_test.):
- web-platform-tests/service-workers/cache-storage/script-tests/w3c-import.log: Added.
- web-platform-tests/service-workers/cache-storage/serviceworker/cache-add.https.html: Added.
- web-platform-tests/service-workers/cache-storage/serviceworker/cache-delete.https.html: Added.
- web-platform-tests/service-workers/cache-storage/serviceworker/cache-match.https.html: Added.
- web-platform-tests/service-workers/cache-storage/serviceworker/cache-put.https.html: Added.
- web-platform-tests/service-workers/cache-storage/serviceworker/cache-storage-keys.https.html: Added.
- web-platform-tests/service-workers/cache-storage/serviceworker/cache-storage-match.https.html: Added.
- web-platform-tests/service-workers/cache-storage/serviceworker/cache-storage.https.html: Added.
- web-platform-tests/service-workers/cache-storage/serviceworker/w3c-import.log: Added.
- web-platform-tests/service-workers/cache-storage/w3c-import.log: Copied from LayoutTests/imported/w3c/web-platform-tests/w3c-import.log.
- web-platform-tests/service-workers/cache-storage/window/cache-add.https.html: Added.
- web-platform-tests/service-workers/cache-storage/window/cache-delete.https.html: Added.
- web-platform-tests/service-workers/cache-storage/window/cache-match.https.html: Added.
- web-platform-tests/service-workers/cache-storage/window/cache-put.https.html: Added.
- web-platform-tests/service-workers/cache-storage/window/cache-storage-keys.https.html: Added.
- web-platform-tests/service-workers/cache-storage/window/cache-storage-match.https.html: Added.
- web-platform-tests/service-workers/cache-storage/window/cache-storage.https.html: Added.
- web-platform-tests/service-workers/cache-storage/window/sandboxed-iframes.https.html: Added.
- web-platform-tests/service-workers/cache-storage/window/w3c-import.log: Added.
- web-platform-tests/service-workers/cache-storage/worker/cache-add.https.html: Added.
- web-platform-tests/service-workers/cache-storage/worker/cache-delete.https.html: Added.
- web-platform-tests/service-workers/cache-storage/worker/cache-match.https.html: Added.
- web-platform-tests/service-workers/cache-storage/worker/cache-put.https.html: Added.
- web-platform-tests/service-workers/cache-storage/worker/cache-storage-keys.https.html: Added.
- web-platform-tests/service-workers/cache-storage/worker/cache-storage-match.https.html: Added.
- web-platform-tests/service-workers/cache-storage/worker/cache-storage.https.html: Added.
- web-platform-tests/service-workers/cache-storage/worker/w3c-import.log: Added.
- web-platform-tests/service-workers/service-workers/resources/w3c-import.log: Copied from LayoutTests/imported/w3c/web-platform-tests/w3c-import.log.
- web-platform-tests/service-workers/specgen.json: Added.
- web-platform-tests/service-workers/stub-3.1-service-worker-obj.html: Added.
- web-platform-tests/service-workers/stub-3.1.1-service-worker-scope.html: Added.
- web-platform-tests/service-workers/stub-3.1.2-service-worker-url.html: Added.
- web-platform-tests/service-workers/stub-3.1.3-service-worker-state.html: Added.
- web-platform-tests/service-workers/stub-3.1.4-service-worker-on-state-change.html: Added.
- web-platform-tests/service-workers/stub-3.2-navigator-service-worker.html: Added.
- web-platform-tests/service-workers/stub-3.2.1-navigator-service-worker-installing.html: Added.
- web-platform-tests/service-workers/stub-3.2.10-navigator-service-worker-oncontrollerchange.html: Added.
- web-platform-tests/service-workers/stub-3.2.11-navigator-service-worker-onreloadpage.html: Added.
- web-platform-tests/service-workers/stub-3.2.12-navigator-service-worker-onerror.html: Added.
- web-platform-tests/service-workers/stub-3.2.2-navigator-service-worker-waiting.html: Added.
- web-platform-tests/service-workers/stub-3.2.3-navigator-service-worker-active.html: Added.
- web-platform-tests/service-workers/stub-3.2.4-navigator-service-worker-controller.html: Added.
- web-platform-tests/service-workers/stub-3.2.5-navigator-service-worker-ready.html: Added.
- web-platform-tests/service-workers/stub-3.2.6-navigator-service-worker-getAll.html: Added.
- web-platform-tests/service-workers/stub-3.2.7-navigator-service-worker-register.html: Added.
- web-platform-tests/service-workers/stub-3.2.8-navigator-service-worker-unregister.html: Added.
- web-platform-tests/service-workers/stub-3.2.9-navigator-service-worker-onupdatefound.html: Added.
- web-platform-tests/service-workers/stub-4.1-service-worker-global-scope.html: Added.
- web-platform-tests/service-workers/stub-4.1.1-service-worker-global-scope-caches.html: Added.
- web-platform-tests/service-workers/stub-4.1.2-service-worker-global-scope-clients.html: Added.
- web-platform-tests/service-workers/stub-4.1.3-service-worker-global-scope-scope.html: Added.
- web-platform-tests/service-workers/stub-4.1.4-service-worker-global-scope-fetch.html: Added.
- web-platform-tests/service-workers/stub-4.1.5-service-worker-global-scope-update.html: Added.
- web-platform-tests/service-workers/stub-4.1.6-service-worker-global-scope-unregister.html: Added.
- web-platform-tests/service-workers/stub-4.1.7-service-worker-global-scope-onmessage.html: Added.
- web-platform-tests/service-workers/stub-4.2-client.html: Added.
- web-platform-tests/service-workers/stub-4.3-service-worker-clients.html: Added.
- web-platform-tests/service-workers/stub-4.3.1-get-serviced-method.html: Added.
- web-platform-tests/service-workers/stub-4.3.2-reloadall-method.html: Added.
- web-platform-tests/service-workers/stub-4.4-request-objects.html: Added.
- web-platform-tests/service-workers/stub-4.5-response-objects.html: Added.
- web-platform-tests/service-workers/stub-4.5.2-response.html: Added.
- web-platform-tests/service-workers/stub-4.5.4-opaque-response.html: Added.
- web-platform-tests/service-workers/stub-4.6-cache-objects.html: Added.
- web-platform-tests/service-workers/stub-4.6.1-cache-lifetimes.html: Added.
- web-platform-tests/service-workers/stub-4.6.2-cache.html: Added.
- web-platform-tests/service-workers/stub-4.6.3-cache-storage.html: Added.
- web-platform-tests/service-workers/stub-4.7.1-install-phase-event.html: Added.
- web-platform-tests/service-workers/stub-4.7.1.1-wait-until-method.html: Added.
- web-platform-tests/service-workers/stub-4.7.2-install-event.html: Added.
- web-platform-tests/service-workers/stub-4.7.2.1-install-event-section.html: Added.
- web-platform-tests/service-workers/stub-4.7.2.2-replace-method.html: Added.
- web-platform-tests/service-workers/stub-4.7.3-activate-event.html: Added.
- web-platform-tests/service-workers/stub-4.7.4.1-fetch-event-section.html: Added.
- web-platform-tests/service-workers/stub-4.7.4.2-respond-with-method.html: Added.
- web-platform-tests/service-workers/stub-4.7.4.3-default-method.html: Added.
- web-platform-tests/service-workers/stub-4.7.4.4-is-reload-attribute.html: Added.
- web-platform-tests/service-workers/stub-5.1-origin-relativity.html: Added.
- web-platform-tests/service-workers/stub-5.2-cross-origin-resources.html: Added.
- web-platform-tests/service-workers/tools/blink-import.py: Added.
(get_extra_files):
(resources_path):
(python_to_php):
(testharness_helpers):
(service_worker_path):
(server_names):
(source_paths):
(do_subs):
(get_head):
(get_changes):
(copy):
(copy_local_files):
(copy_extra_files):
(sub_changed_filenames):
(is_top_level_test):
(add_suffix):
(main):
- web-platform-tests/service-workers/tools/w3c-import.log: Copied from LayoutTests/imported/w3c/web-platform-tests/w3c-import.log.
- web-platform-tests/service-workers/w3c-import.log: Added.
LayoutTests:
- TestExpectations: Marking all service worker tests as skipped.
- 3:41 AM Changeset in webkit [194581] by
-
- 2 edits in trunk/Source/WebKit/win
[WinCairo] Download should use header values from provided request object.
https://bugs.webkit.org/show_bug.cgi?id=152694
Reviewed by Alex Christensen.
Copy header values from request object parameter.
- WebDownloadCurl.cpp:
(WebDownload::initWithRequest):
- 1:28 AM Changeset in webkit [194580] by
-
- 118 edits1 copy15 moves25 adds9 deletes in trunk/LayoutTests
Update web-platform-tests test suite
https://bugs.webkit.org/show_bug.cgi?id=151984
Reviewed by Daniel Bates.
LayoutTests/imported/w3c:
Bumping WPT test revision from dd553279c3 to 5932fd48d519a83b4cca6ed69778547a4fdfc5ae.
New revision includes test improvements, test renaming to ensure WebKit test expectations do not clash and XHR test clean-up.
- resources/ImportExpectations: Updated to not include new tests. Improved ordering.
- resources/TestRepositories: Updated revision.
- resources/web-platform-tests-modules.json: Updated revision.
- web-platform-tests/README.md:
- web-platform-tests/XMLHttpRequest/XMLHttpRequest-withCredentials-expected.txt:
- web-platform-tests/XMLHttpRequest/XMLHttpRequest-withCredentials.js:
- web-platform-tests/XMLHttpRequest/interfaces-expected.txt:
- web-platform-tests/XMLHttpRequest/open-url-worker-simple.htm:
- web-platform-tests/XMLHttpRequest/resources/empty-div-utf8-html.py: Added.
(main):
- web-platform-tests/XMLHttpRequest/resources/img-utf8-html.py: Added.
(main):
- web-platform-tests/XMLHttpRequest/resources/w3c-import.log:
- web-platform-tests/XMLHttpRequest/send-content-type-charset-expected.txt:
- web-platform-tests/XMLHttpRequest/send-content-type-charset.htm:
- web-platform-tests/XMLHttpRequest/send-content-type-string-expected.txt:
- web-platform-tests/XMLHttpRequest/send-content-type-string.htm:
- web-platform-tests/XMLHttpRequest/send-entity-body-document-expected.txt:
- web-platform-tests/XMLHttpRequest/send-entity-body-document.htm:
- web-platform-tests/XMLHttpRequest/xmlhttprequest-timeout-aborted.html:
- web-platform-tests/XMLHttpRequest/xmlhttprequest-timeout-abortedonmain.html:
- web-platform-tests/XMLHttpRequest/xmlhttprequest-timeout-overrides.html:
- web-platform-tests/XMLHttpRequest/xmlhttprequest-timeout-overridesexpires.html:
- web-platform-tests/XMLHttpRequest/xmlhttprequest-timeout-simple.html:
- web-platform-tests/XMLHttpRequest/xmlhttprequest-timeout-synconmain.html:
- web-platform-tests/XMLHttpRequest/xmlhttprequest-timeout-twice.html:
- web-platform-tests/XMLHttpRequest/xmlhttprequest-timeout-worker-aborted.html:
- web-platform-tests/XMLHttpRequest/xmlhttprequest-timeout-worker-overrides.html:
- web-platform-tests/XMLHttpRequest/xmlhttprequest-timeout-worker-overridesexpires.html:
- web-platform-tests/XMLHttpRequest/xmlhttprequest-timeout-worker-simple.html:
- web-platform-tests/XMLHttpRequest/xmlhttprequest-timeout-worker-synconworker.html:
- web-platform-tests/XMLHttpRequest/xmlhttprequest-timeout-worker-twice.html:
- web-platform-tests/dom/common.js:
(myExtractContents):
(myInsertNode):
- web-platform-tests/dom/interfaces-expected.txt:
- web-platform-tests/dom/lists/DOMTokenList-stringifier-expected.txt:
- web-platform-tests/dom/lists/DOMTokenList-stringifier.html:
- web-platform-tests/dom/nodes/Document-Element-getElementsByTagName.js:
(test_getElementsByTagName):
- web-platform-tests/dom/nodes/Document-createElement-namespace-expected.txt:
- web-platform-tests/dom/nodes/Document-createElement-namespace-tests/empty.html: Added.
- web-platform-tests/dom/nodes/Document-createElement-namespace-tests/empty.svg: Added.
- web-platform-tests/dom/nodes/Document-createElement-namespace-tests/empty.xhtml: Added.
- web-platform-tests/dom/nodes/Document-createElement-namespace-tests/empty.xml: Added.
- web-platform-tests/dom/nodes/Document-createElement-namespace.html:
- web-platform-tests/dom/nodes/Document-getElementsByTagName-expected.txt:
- web-platform-tests/dom/nodes/DocumentType-literal-xhtml-expected.txt: Added.
- web-platform-tests/dom/nodes/DocumentType-literal-xhtml.xhtml: Renamed from LayoutTests/imported/w3c/web-platform-tests/dom/nodes/DocumentType-literal.xhtml.
- web-platform-tests/dom/nodes/Element-childElementCount-dynamic-add-xhtml-expected.txt: Added.
- web-platform-tests/dom/nodes/Element-childElementCount-dynamic-add-xhtml.xhtml: Renamed from LayoutTests/imported/w3c/web-platform-tests/dom/nodes/Element-childElementCount-dynamic-add.xhtml.
- web-platform-tests/dom/nodes/Element-childElementCount-nochild-xhtml-expected.txt: Added.
- web-platform-tests/dom/nodes/Element-childElementCount-nochild-xhtml.xhtml: Renamed from LayoutTests/imported/w3c/web-platform-tests/dom/nodes/Element-childElementCount-nochild.xhtml.
- web-platform-tests/dom/nodes/Element-children-expected.txt:
- web-platform-tests/dom/nodes/Element-children.html:
- web-platform-tests/dom/nodes/Element-classlist-expected.txt:
- web-platform-tests/dom/nodes/Element-classlist.html:
- web-platform-tests/dom/nodes/Element-firstElementChild-xhtml-expected.txt: Added.
- web-platform-tests/dom/nodes/Element-firstElementChild-xhtml.xhtml: Renamed from LayoutTests/imported/w3c/web-platform-tests/dom/nodes/Element-firstElementChild.xhtml.
- web-platform-tests/dom/nodes/Element-getElementsByTagName-change-document-HTMLNess-expected.txt: Added.
- web-platform-tests/dom/nodes/Element-getElementsByTagName-change-document-HTMLNess-iframe-expected.txt: Added.
- web-platform-tests/dom/nodes/Element-getElementsByTagName-change-document-HTMLNess-iframe.xml: Added.
- web-platform-tests/dom/nodes/Element-getElementsByTagName-change-document-HTMLNess.html: Added.
- web-platform-tests/dom/nodes/Element-getElementsByTagName-expected.txt:
- web-platform-tests/dom/nodes/Element-matches-expected.txt:
- web-platform-tests/dom/nodes/Element-nextElementSibling-xhtml-expected.txt: Added.
- web-platform-tests/dom/nodes/Element-nextElementSibling-xhtml.xhtml: Renamed from LayoutTests/imported/w3c/web-platform-tests/dom/nodes/Element-nextElementSibling.xhtml.
- web-platform-tests/dom/nodes/Element-previousElementSibling-xhtml-expected.txt: Added.
- web-platform-tests/dom/nodes/Element-previousElementSibling-xhtml.xhtml: Renamed from LayoutTests/imported/w3c/web-platform-tests/dom/nodes/Element-previousElementSibling.xhtml.
- web-platform-tests/dom/nodes/MutationObserver-childList-expected.txt:
- web-platform-tests/dom/nodes/MutationObserver-childList.html:
- web-platform-tests/dom/nodes/MutationObserver-document-expected.txt:
- web-platform-tests/dom/nodes/MutationObserver-document.html:
- web-platform-tests/dom/nodes/Node-contains-xhtml-expected.txt: Removed.
- web-platform-tests/dom/nodes/Node-contains-xhtml.xhtml: Removed.
- web-platform-tests/dom/nodes/Node-isEqualNode-expected.txt:
- web-platform-tests/dom/nodes/Node-isEqualNode-iframe1-expected.txt: Added.
- web-platform-tests/dom/nodes/Node-isEqualNode-iframe1.xml: Added.
- web-platform-tests/dom/nodes/Node-isEqualNode-iframe2-expected.txt: Added.
- web-platform-tests/dom/nodes/Node-isEqualNode-iframe2.xml: Added.
- web-platform-tests/dom/nodes/Node-isEqualNode.xhtml:
- web-platform-tests/dom/nodes/Node-lookupNamespaceURI-expected.txt:
- web-platform-tests/dom/nodes/Node-lookupNamespaceURI.html:
- web-platform-tests/dom/nodes/ParentNode-querySelector-All-expected.txt:
- web-platform-tests/dom/nodes/ParentNode-querySelector-All-xht-expected.txt: Renamed from LayoutTests/imported/w3c/web-platform-tests/dom/nodes/ParentNode-querySelector-All-xhtml-expected.txt.
- web-platform-tests/dom/nodes/ParentNode-querySelector-All-xht.xht: Renamed from LayoutTests/imported/w3c/web-platform-tests/dom/nodes/ParentNode-querySelector-All-xhtml.xht.
- web-platform-tests/dom/nodes/attributes-expected.txt:
- web-platform-tests/dom/nodes/attributes.html:
- web-platform-tests/dom/nodes/getElementsByClassName-10.xml:
- web-platform-tests/dom/nodes/getElementsByClassName-11.xml:
- web-platform-tests/dom/nodes/resources/ParentNode-querySelector-All-content.xht: Removed.
- web-platform-tests/dom/nodes/selectors.js:
- web-platform-tests/dom/nodes/w3c-import.log:
- web-platform-tests/dom/ranges/Range-deleteContents-expected.txt:
- web-platform-tests/dom/ranges/Range-deleteContents.html:
- web-platform-tests/dom/ranges/Range-extractContents-expected.txt:
- web-platform-tests/dom/ranges/Range-insertNode-expected.txt:
- web-platform-tests/dom/ranges/Range-intersectsNode-expected.txt:
- web-platform-tests/dom/ranges/Range-intersectsNode.html:
- web-platform-tests/dom/ranges/Range-mutations.html:
- web-platform-tests/dom/ranges/Range-surroundContents-expected.txt:
- web-platform-tests/dom/ranges/Range-surroundContents.html:
- web-platform-tests/html/dom/documents/dom-tree-accessors/document.getElementsByName/document.getElementsByName-case-xhtml-expected.txt: Added.
- web-platform-tests/html/dom/documents/dom-tree-accessors/document.getElementsByName/document.getElementsByName-case-xhtml.xhtml: Renamed from LayoutTests/imported/w3c/web-platform-tests/html/dom/documents/dom-tree-accessors/document.getElementsByName/document.getElementsByName-case.xhtml.
- web-platform-tests/html/dom/documents/dom-tree-accessors/document.getElementsByName/document.getElementsByName-id-xhtml-expected.txt: Added.
- web-platform-tests/html/dom/documents/dom-tree-accessors/document.getElementsByName/document.getElementsByName-id-xhtml.xhtml: Renamed from LayoutTests/imported/w3c/web-platform-tests/html/dom/documents/dom-tree-accessors/document.getElementsByName/document.getElementsByName-id.xhtml.
- web-platform-tests/html/dom/documents/dom-tree-accessors/document.getElementsByName/document.getElementsByName-namespace-xhtml-expected.txt: Added.
- web-platform-tests/html/dom/documents/dom-tree-accessors/document.getElementsByName/document.getElementsByName-namespace-xhtml.xhtml: Renamed from LayoutTests/imported/w3c/web-platform-tests/html/dom/documents/dom-tree-accessors/document.getElementsByName/document.getElementsByName-namespace.xhtml.
- web-platform-tests/html/dom/documents/dom-tree-accessors/document.getElementsByName/document.getElementsByName-newelements-expected.txt:
- web-platform-tests/html/dom/documents/dom-tree-accessors/document.getElementsByName/document.getElementsByName-newelements-xhtml-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/html/dom/documents/dom-tree-accessors/document.getElementsByName/document.getElementsByName-newelements-expected.txt.
- web-platform-tests/html/dom/documents/dom-tree-accessors/document.getElementsByName/document.getElementsByName-newelements-xhtml.xhtml: Renamed from LayoutTests/imported/w3c/web-platform-tests/html/dom/documents/dom-tree-accessors/document.getElementsByName/document.getElementsByName-newelements.xhtml.
- web-platform-tests/html/dom/documents/dom-tree-accessors/document.getElementsByName/document.getElementsByName-newelements.html:
- web-platform-tests/html/dom/documents/dom-tree-accessors/document.getElementsByName/document.getElementsByName-null-undef-xhtml-expected.txt: Added.
- web-platform-tests/html/dom/documents/dom-tree-accessors/document.getElementsByName/document.getElementsByName-null-undef-xhtml.xhtml: Renamed from LayoutTests/imported/w3c/web-platform-tests/html/dom/documents/dom-tree-accessors/document.getElementsByName/document.getElementsByName-null-undef.xhtml.
- web-platform-tests/html/dom/documents/dom-tree-accessors/document.getElementsByName/document.getElementsByName-param-xhtml-expected.txt: Added.
- web-platform-tests/html/dom/documents/dom-tree-accessors/document.getElementsByName/document.getElementsByName-param-xhtml.xhtml: Renamed from LayoutTests/imported/w3c/web-platform-tests/html/dom/documents/dom-tree-accessors/document.getElementsByName/document.getElementsByName-param.xhtml.
- web-platform-tests/html/dom/documents/dom-tree-accessors/document.getElementsByName/w3c-import.log:
- web-platform-tests/html/dom/documents/dom-tree-accessors/document.title-03-expected.txt:
- web-platform-tests/html/dom/documents/dom-tree-accessors/document.title-03.html:
- web-platform-tests/html/dom/documents/dom-tree-accessors/document.title-09-expected.txt:
- web-platform-tests/html/dom/documents/dom-tree-accessors/document.title-09.html:
- web-platform-tests/html/dom/documents/dom-tree-accessors/nameditem-06-expected.txt:
- web-platform-tests/html/dom/documents/dom-tree-accessors/nameditem-06.html:
- web-platform-tests/html/dom/documents/resource-metadata-management/document-lastModified-01.html:
- web-platform-tests/html/dom/dynamic-markup-insertion/opening-the-input-stream/010-expected.txt:
- web-platform-tests/html/dom/elements-embedded.js:
- web-platform-tests/html/dom/elements-text.js:
- web-platform-tests/html/dom/elements/global-attributes/dir_auto-N-EN-ref-expected.html: Added.
- web-platform-tests/html/dom/elements/global-attributes/dir_auto-N-EN-ref.html: Added.
- web-platform-tests/html/dom/elements/global-attributes/dir_auto-textarea-script-N-between-Rs-ref-expected.html: Added.
- web-platform-tests/html/dom/elements/global-attributes/dir_auto-textarea-script-N-between-Rs-ref.html: Added.
- web-platform-tests/html/dom/elements/global-attributes/w3c-import.log:
- web-platform-tests/html/dom/interfaces-expected.txt:
- web-platform-tests/html/dom/interfaces.html:
- web-platform-tests/html/dom/reflection.js:
(ReflectionTests.doReflects):
- web-platform-tests/html/semantics/embedded-content/media-elements/loading-the-media-resource/resources/delayed-broken-video.py: Removed.
- web-platform-tests/html/semantics/embedded-content/media-elements/loading-the-media-resource/resources/w3c-import.log: Removed.
- web-platform-tests/html/semantics/embedded-content/media-elements/loading-the-media-resource/w3c-import.log: Removed.
- web-platform-tests/html/semantics/embedded-content/media-elements/location-of-the-media-resource/w3c-import.log: Removed.
- web-platform-tests/html/semantics/embedded-content/media-elements/ready-states/w3c-import.log: Removed.
- web-platform-tests/html/semantics/embedded-content/media-elements/seeking/w3c-import.log: Removed.
- web-platform-tests/html/semantics/embedded-content/media-elements/synchronising-multiple-media-elements/media-controllers/w3c-import.log: Removed.
- web-platform-tests/html/semantics/embedded-content/the-iframe-element/w3c-import.log: Removed.
- web-platform-tests/html/semantics/embedded-content/the-img-element/Image-constructor.html:
- web-platform-tests/html/semantics/embedded-content/the-img-element/current-pixel-density/basic-expected.txt:
- web-platform-tests/html/semantics/embedded-content/the-img-element/current-pixel-density/basic.html:
- web-platform-tests/html/semantics/forms/constraints/form-validation-checkValidity-expected.txt:
- web-platform-tests/html/semantics/forms/constraints/form-validation-validity-valid-expected.txt:
- web-platform-tests/html/semantics/forms/constraints/form-validation-validity-valueMissing-expected.txt:
- web-platform-tests/html/semantics/forms/constraints/form-validation-validity-valueMissing.html:
- web-platform-tests/html/semantics/forms/constraints/support/validator.js:
(validator.set_conditions):
(validator.set_dirty): Deleted.
(validator.pre_check): Deleted.
- web-platform-tests/html/semantics/forms/textfieldselection/selection.html:
- web-platform-tests/html/semantics/forms/the-form-element/form-autocomplete-expected.txt:
- web-platform-tests/html/semantics/forms/the-form-element/form-autocomplete.html:
- web-platform-tests/html/semantics/forms/the-label-element/label-attributes-expected.txt:
- web-platform-tests/html/semantics/forms/the-label-element/label-attributes.html:
- web-platform-tests/html/semantics/forms/the-label-element/labelable-elements-expected.txt:
- web-platform-tests/html/semantics/forms/the-label-element/labelable-elements.html:
- web-platform-tests/html/semantics/forms/the-option-element/option-text-recurse-expected.txt:
- web-platform-tests/html/semantics/forms/the-option-element/option-text-recurse.html:
- web-platform-tests/html/semantics/forms/the-select-element/common-HTMLOptionsCollection-namedItem-expected.txt:
- web-platform-tests/html/semantics/forms/the-select-element/common-HTMLOptionsCollection-namedItem.html:
- web-platform-tests/html/semantics/scripting-1/the-script-element/w3c-import.log:
- web-platform-tests/html/semantics/scripting-1/the-template-element/template-element/template-descendant-frameset.html:
- web-platform-tests/html/semantics/selectors/pseudo-classes/disabled-expected.txt:
- web-platform-tests/html/semantics/selectors/pseudo-classes/disabled.html:
- web-platform-tests/html/semantics/tabular-data/attributes-common-to-td-and-th-elements/cellIndex-expected.txt:
- web-platform-tests/html/semantics/tabular-data/attributes-common-to-td-and-th-elements/cellIndex.html:
- web-platform-tests/html/semantics/tabular-data/html-table-section-element.js: Added.
(testRowsAttribute):
- web-platform-tests/html/semantics/tabular-data/the-tbody-element/deleteRow-expected.txt:
- web-platform-tests/html/semantics/tabular-data/the-tbody-element/deleteRow.html:
- web-platform-tests/html/semantics/tabular-data/the-tbody-element/insertRow-expected.txt:
- web-platform-tests/html/semantics/tabular-data/the-tbody-element/insertRow.html:
- web-platform-tests/html/semantics/tabular-data/the-tr-element/deleteCell-expected.txt:
- web-platform-tests/html/semantics/tabular-data/the-tr-element/deleteCell.html:
- web-platform-tests/html/semantics/tabular-data/w3c-import.log: Renamed from LayoutTests/imported/w3c/web-platform-tests/html/semantics/document-metadata/styling/w3c-import.log.
- web-platform-tests/lint:
- web-platform-tests/lint.whitelist:
- web-platform-tests/media/2048x1360-random.jpg: Added.
- web-platform-tests/media/w3c-import.log: Added.
LayoutTests:
- TestExpectations: updated expectations for newly failing tests.
- 12:12 AM Changeset in webkit [194579] by
-
- 13 edits3 adds in trunk
[GTK] Allow to save and restore session
https://bugs.webkit.org/show_bug.cgi?id=115600
Reviewed by Michael Catanzaro.
Source/WebKit2:
Add new API to get and resore the web view session state.
- PlatformGTK.cmake: Add new files to compilation.
- UIProcess/API/gtk/WebKitWebView.cpp:
(webkit_web_view_get_session_state): Create a new
WebKitWebViewSessionState representing the current session state.
(webkit_web_view_restore_session_state): Restore the web view
session state from the given WebKitWebViewSessionState.
- UIProcess/API/gtk/WebKitWebView.h:
- UIProcess/API/gtk/WebKitWebViewSessionState.cpp: Added.
(_WebKitWebViewSessionState::_WebKitWebViewSessionState):
(toExternalURLsPolicy):
(toWebCoreExternalURLsPolicy):
(toHTMLBodyElementType):
(toHTTPBodyElementType):
(encodeHTTPBody):
(encodeFrameState):
(encodePageState):
(encodeBackForwardListItemState):
(encodeBackForwardListState):
(encodeSessionState):
(decodeHTTPBody):
(decodeFrameState):
(decodeBackForwardListItemState):
(decodeSessionState):
(webkitWebViewSessionStateCreate):
(webkitWebViewSessionStateGetSessionState):
(webkit_web_view_session_state_new): Create a
WebKitWebViewSessionState from serialized data.
(webkit_web_view_session_state_ref):
(webkit_web_view_session_state_unref):
(webkit_web_view_session_state_serialize): Serialize the WebKitWebViewSessionState.
- UIProcess/API/gtk/WebKitWebViewSessionState.h: Added.
- UIProcess/API/gtk/WebKitWebViewSessionStatePrivate.h: Added.
- UIProcess/API/gtk/docs/webkit2gtk-4.0-sections.txt: Add new symbols.
- UIProcess/API/gtk/docs/webkit2gtk-4.0.types: Add webkit_web_view_session_state_get_type.
- UIProcess/API/gtk/webkit2.h: Include WebKitWebViewSessionState.h.
Source/WTF:
Add GVariantIter specialization of GUniquePtr.
- wtf/glib/GTypedefs.h:
- wtf/glib/GUniquePtr.h:
Tools:
Add test case to check the new session API.
- TestWebKitAPI/Tests/WebKit2Gtk/TestBackForwardList.cpp:
(testWebKitWebViewSessionState):
(testWebKitWebViewSessionStateWithFormData):
(beforeAll):
