Timeline
Jun 6, 2016:
- 11:33 PM Changeset in webkit [201745] by
-
- 1 edit1 move in trunk/Source/JavaScriptCore
Fix typo in test name trailing-comma-in-function-paramters.js
https://bugs.webkit.org/show_bug.cgi?id=158462
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-06-06
Reviewed by Mark Lam.
- tests/stress/trailing-comma-in-function-parameters.js: Renamed from Source/JavaScriptCore/tests/stress/trailing-comma-in-function-paramters.js.
- 11:32 PM Changeset in webkit [201744] by
-
- 2 edits in trunk/LayoutTests
ASSERTION failed in get-by-pname.js when run with JSC_useLLINT=false and 2 other configurations
https://bugs.webkit.org/show_bug.cgi?id=138497
<rdar://problem/18909792>
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-06-06
Reviewed by Mark Lam.
- js/script-tests/get-by-pname.js:
Test is no longer failing. Lets unskip.
- 11:06 PM Changeset in webkit [201743] by
-
- 25 edits11 deletes in trunk
Unreviewed, rolling out r201735.
https://bugs.webkit.org/show_bug.cgi?id=158465
fast/events/AddEventListenerOptions-once-recursive.html fails
on all bots (Requested by ap on #webkit).
Reverted changeset:
"Implement EventListenerOptions argument to addEventListener"
https://bugs.webkit.org/show_bug.cgi?id=149466
http://trac.webkit.org/changeset/201735
- 11:05 PM Changeset in webkit [201742] by
-
- 22 edits14 deletes in trunk
Unreviewed, rolling out r201679.
https://bugs.webkit.org/show_bug.cgi?id=158464
http/tests/websocket/tests/hybi/upgrade-simple-ws.html is
flaky (Requested by ap on #webkit).
Reverted changeset:
"CSP: Content Security Policy directive, upgrade-insecure-
requests (UIR)"
https://bugs.webkit.org/show_bug.cgi?id=143653
http://trac.webkit.org/changeset/201679
- 10:54 PM Changeset in webkit [201741] by
-
- 6 edits in trunk/Source
REGRESSION(r197595): 2% JSBench regression on iPhone 5.
<https://webkit.org/b/158459>
Unreviewed rollout.
- runtime/VM.cpp:
(JSC::VM::deleteAllRegExpCode): Deleted.
- runtime/VM.h:
- 10:46 PM Changeset in webkit [201740] by
-
- 25 edits2 adds in trunk
URLs containing tabs or newlines are parsed incorrectly
https://bugs.webkit.org/show_bug.cgi?id=143381
<rdar://problem/26567214>
Reviewed by Brent Fulgham.
Source/WebCore:
- Strip any tabs and newlines in the URL input.
- Replace the original stripping URL leading and trailing white spaces logic with WTFString's
builtin, and move this logic to the very begining of the URL parser.
- Enhance the protocolIs method to ignore any leading whitespace/control characters, and
tabs/newlines of the examining url.
Test: fast/url/tab-and-newline-stripping.html
- platform/URL.cpp:
(WebCore::isTabNewline):
(WebCore::shouldTrimFromURL):
(WebCore::URL::init):
(WebCore::protocolIs):
LayoutTests:
- fast/dom/DOMURL/set-href-attribute-host-expected.txt:
- fast/dom/DOMURL/set-href-attribute-host.html:
- fast/dom/HTMLAnchorElement/script-tests/set-href-attribute-host.js:
- fast/dom/HTMLAnchorElement/set-href-attribute-host-expected.txt:
- fast/url/segments-expected.txt:
- fast/url/segments-from-data-url-expected.txt:
- fast/url/segments-from-data-url.html:
- fast/url/segments.html:
- fast/url/tab-and-newline-stripping-expected.txt: Added.
- fast/url/tab-and-newline-stripping.html: Added.
- http/tests/security/javascriptURL/javascriptURL-execution-context-frame-location-htmldom-expected.txt:
- http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-getAttribute-value-expected.txt:
- http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-htmldom-expected.txt:
- http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttribute-expected.txt:
- http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttributeNS-expected.txt:
- http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttributeNode-expected.txt:
- http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttributeNodeNS-expected.txt:
- http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-getAttribute-value-expected.txt:
- http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-htmldom-expected.txt:
- http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttribute-expected.txt:
- http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttributeNS-expected.txt:
- http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttributeNode-expected.txt:
- http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttributeNodeNS-expected.txt:
- http/tests/security/xssAuditor/javascript-link-control-char2-expected.txt:
- 9:02 PM Changeset in webkit [201739] by
-
- 27 edits in trunk
Update the list of elements attachShadow is allowed
https://bugs.webkit.org/show_bug.cgi?id=157706
Reviewed by Darin Adler.
Source/WebCore:
Update the list of elements on which attachShadow is allowed per the latest shadow DOM spec:
http://www.w3.org/TR/shadow-dom/#widl-Element-attachShadow-ShadowRoot-ShadowRootInit-shadowRootInitDict
which now only allows attachShadow on the following elements and custom elements:
button, details, input, marquee, meter, progress, select, textarea, keygen
In order to check that a given HTML element's local name is a valid custom element name,
this patch moves CustomElementDefinitions::checkName to Document::validateCustomElementName so that
it could be used when either SHADOW_DOM or CUSTOM_ELEMENTS build flag is turned on.
Also removed Element::canHaveUserAgentShadowRoot since it was only used in Element::attachShadow.
Test: fast/shadow-dom/Element-interface-attachShadow.html
- bindings/js/JSDocumentCustom.cpp:
(WebCore::JSDocument::defineElement):
- dom/CustomElementDefinitions.cpp:
(WebCore::CustomElementDefinitions::checkName): Moved to Document::validateCustomElementName.
- dom/CustomElementDefinitions.h:
- dom/Document.cpp:
(WebCore::createHTMLElementWithNameValidation):
(WebCore::createFallbackHTMLElement):
(WebCore::Document::validateCustomElementName): Moved from CustomElementDefinitions::checkName.
- dom/Document.h:
- dom/Element.cpp:
(WebCore::canAttachAuthorShadowRoot): Added.
(WebCore::Element::attachShadow):
- dom/Element.h:
- html/HTMLButtonElement.h:
- html/HTMLDetailsElement.h:
- html/HTMLInputElement.h:
- html/HTMLKeygenElement.h:
- html/HTMLMarqueeElement.h:
- html/HTMLMediaElement.h:
- html/HTMLMeterElement.h:
- html/HTMLPlugInElement.h:
- html/HTMLProgressElement.h:
- html/HTMLQuoteElement.h:
- html/HTMLSelectElement.h:
- html/HTMLSummaryElement.h:
- html/HTMLTagNames.in:
- html/HTMLTextAreaElement.h:
- html/HTMLUnknownElement.h:
- html/parser/HTMLConstructionSite.cpp:
(WebCore::HTMLConstructionSite::createHTMLElementOrFindCustomElementInterface):
LayoutTests:
Added more test cases for validating elements on which attachShadow is allowed and disallowed.
- fast/shadow-dom/Element-interface-attachShadow-expected.txt:
- fast/shadow-dom/Element-interface-attachShadow.html:
- 8:24 PM Changeset in webkit [201738] by
-
- 2 edits in trunk/Source/WTF
equal(StringView, StringView) for strings should have a fast path for pointer equality
https://bugs.webkit.org/show_bug.cgi?id=158452
Reviewed by Andreas Kling.
JSBench does a lot of StringView::operator== on StringViews that have
the same underlying characters pointer. This becomes hot inside JSBench
because JSBench heavily stresses JSC's UnlinkedCodeCache with a high
hit rate. This means that when we get a hit in the cache, we used to
do the long form of string compare. However, we were often comparing
two StringViews that had the same underlying buffer and length.
This patch speeds this case up to run in constant time instead of
linear time.
- wtf/text/StringCommon.h:
(WTF::equalCommon):
- wtf/text/StringImpl.h:
(WTF::StringImpl::StringImpl):
(WTF::StringImpl::data):
- wtf/text/StringView.h:
(WTF::StringView::data):
- 8:02 PM Changeset in webkit [201737] by
-
- 2 edits1 add in trunk/Source/JavaScriptCore
octal and binary parsing is wrong for some programs
https://bugs.webkit.org/show_bug.cgi?id=158437
Reviewed by Saam Barati.
When there is an error parsing an binary or octal literal, we need to clear the returnValue
of any residual value. This is because the processing of returnValue happens before the
syntax check for the extra character. Without clearing returnValue, we end trying to
categorize the value as an INTEGER or DOUBLE token. If the value happens to be an
impure NaN, we ASSERT.
- parser/Lexer.cpp:
(JSC::Lexer<T>::parseBinary):
(JSC::Lexer<T>::parseOctal):
- tests/stress/regress-158437.js: New test.
- 7:40 PM Changeset in webkit [201736] by
-
- 5 edits2 adds in trunk
Crash inside moveOutOfAllShadowRoots
https://bugs.webkit.org/show_bug.cgi?id=158378
Reviewed by Antti Koivisto.
Source/WebCore:
The bug was caused by InShadowTreeFlag not being cleared when a shadow host or its ancestor was removed
due to addChildNodesToDeletionQueue not invoking notifyChildNodeRemoved when a node was in a shadow tree
but not in a document.
Fixed the bug by invoking notifyChildNodeRemoved when the removed node is either in a shadow tree
or it's in a shadow tree. Also fixed a bug in VTTCue::~VTTCue that it was trying to remove the display
tree even when the owner document was being destroyed. This results in various assertions to be hit.
Test: fast/shadow-dom/shadow-host-removal-crash.html
- dom/ContainerNodeAlgorithms.cpp:
(WebCore::addChildNodesToDeletionQueue):
- html/track/VTTCue.cpp:
(WebCore::VTTCue::~VTTCue):
LayoutTests:
Added a regression test that reproduced the crash reliably at least on my machine.
- fast/shadow-dom/shadow-host-removal-crash-expected.txt: Added.
- fast/shadow-dom/shadow-host-removal-crash.html: Added.
- platform/ios-simulator/TestExpectations:
- 7:35 PM Changeset in webkit [201735] by
-
- 25 edits23 adds in trunk
Implement EventListenerOptions argument to addEventListener
https://bugs.webkit.org/show_bug.cgi?id=149466
<rdar://problem/22802031>
Reviewed by Dean Jackson.
LayoutTests/imported/w3c:
Import new test from W3C that covers EventListenerOptions.
- web-platform-tests/dom/events/EventListenerOptions-capture-expected.txt: Added.
- web-platform-tests/dom/events/EventListenerOptions-capture.html: Added.
Source/WebCore:
Implement AddEventListenerOptions dictionary argument to addEventListener()
and EventListenerOptions dictionary argument to removeEventListener(), as
per the latest DOM specification:
Firefox and Chrome already support this.
Support for AddEventListenerOptions in this patch is as follows:
- 'capture': fully supported.
- 'once': fully supported.
- 'passive': supported in the sense that preventDefault() will be ignored
for passive event listeners. There are however currently no
performance benefits from passing this flag. Those optimizations
will be implemented in follow-up patches (in particular for
Touch and Scroll events).
Tests: fast/events/AddEventListenerOptions-once-recursive.html
fast/events/AddEventListenerOptions-once.html
fast/events/AddEventListenerOptions-passive.html
fast/events/removeEventListener-EventListenerOptions-capture.html
imported/w3c/web-platform-tests/dom/events/EventListenerOptions-capture.html
- Modules/webaudio/AudioScheduledSourceNode.cpp:
(WebCore::AudioScheduledSourceNode::addEventListener):
(WebCore::AudioScheduledSourceNode::removeEventListener):
- Modules/webaudio/AudioScheduledSourceNode.h:
- Modules/webaudio/ScriptProcessorNode.cpp:
(WebCore::ScriptProcessorNode::addEventListener):
(WebCore::ScriptProcessorNode::removeEventListener):
- Modules/webaudio/ScriptProcessorNode.h:
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateParametersCheckExpression):
- dom/Event.h:
(WebCore::Event::preventDefault):
(WebCore::Event::setInPassiveListener):
- dom/EventListenerMap.cpp:
(WebCore::addListenerToVector):
(WebCore::EventListenerMap::add):
- dom/EventListenerMap.h:
- dom/EventTarget.cpp:
(WebCore::EventTarget::addEventListener):
(WebCore::EventTarget::addEventListenerForBindings):
(WebCore::EventTarget::removeEventListenerForBindings):
(WebCore::EventTarget::removeEventListener):
(WebCore::EventTarget::setAttributeEventListener):
(WebCore::EventTarget::fireEventListeners):
- dom/EventTarget.h:
(WebCore::EventTarget::ListenerOptions::ListenerOptions):
(WebCore::EventTarget::AddEventListenerOptions::AddEventListenerOptions):
(WebCore::EventTarget::addEventListener):
(WebCore::EventTarget::addEventListenerForBindings):
(WebCore::EventTarget::removeEventListenerForBindings):
- dom/EventTarget.idl:
- dom/MessagePort.cpp:
(WebCore::MessagePort::addEventListener):
- dom/MessagePort.h:
- dom/Node.cpp:
(WebCore::tryAddEventListener):
(WebCore::Node::addEventListener):
(WebCore::tryRemoveEventListener):
(WebCore::Node::removeEventListener):
- dom/Node.h:
- dom/RegisteredEventListener.h:
(WebCore::RegisteredEventListener::Options::Options):
(WebCore::RegisteredEventListener::RegisteredEventListener):
(WebCore::operator==):
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::addEventListener):
(WebCore::HTMLMediaElement::removeEventListener):
- html/HTMLMediaElement.h:
- page/DOMWindow.cpp:
(WebCore::DOMWindow::addEventListener):
(WebCore::DOMWindow::removeEventListener):
- page/DOMWindow.h:
- svg/SVGElement.cpp:
(WebCore::SVGElement::addEventListener):
(WebCore::SVGElement::removeEventListener):
- svg/SVGElement.h:
LayoutTests:
- fast/events/AddEventListenerOptions-once-expected.txt: Added.
- fast/events/AddEventListenerOptions-once-recursive-expected.txt: Added.
- fast/events/AddEventListenerOptions-once-recursive.html: Added.
- fast/events/AddEventListenerOptions-once.html: Added.
- fast/events/AddEventListenerOptions-passive-expected.txt: Added.
- fast/events/AddEventListenerOptions-passive.html: Added.
- fast/events/removeEventListener-EventListenerOptions-capture-expected.txt: Added.
- fast/events/removeEventListener-EventListenerOptions-capture.html: Added.
Add layout testing coverage for various aspects of the functionality.
- imported/blink/fast/events/eventlisteneroptions/capture_default-expected.txt: Added.
- imported/blink/fast/events/eventlisteneroptions/capture_default.html: Added.
- imported/blink/fast/events/eventlisteneroptions/capture_equality-expected.txt: Added.
- imported/blink/fast/events/eventlisteneroptions/capture_equality.html: Added.
- imported/blink/fast/events/eventlisteneroptions/capture_query-expected.txt: Added.
- imported/blink/fast/events/eventlisteneroptions/capture_query.html: Added.
- imported/blink/fast/events/eventlisteneroptions/passive_dispatch-expected.txt: Added.
- imported/blink/fast/events/eventlisteneroptions/passive_dispatch.html: Added.
- imported/blink/fast/events/eventlisteneroptions/passive_inequality-expected.txt: Added.
- imported/blink/fast/events/eventlisteneroptions/passive_inequality.html: Added.
- imported/blink/fast/events/eventlisteneroptions/passive_query-expected.txt: Added.
- imported/blink/fast/events/eventlisteneroptions/passive_query.html: Added.
Import blink tests for this functionality.
- 5:36 PM Changeset in webkit [201734] by
-
- 25 edits11 deletes in trunk
Unreviewed, rolling out r201730.
https://bugs.webkit.org/show_bug.cgi?id=158453
This change caused existing LayoutTests to crash (Requested by
ryanhaddad on #webkit).
Reverted changeset:
"Implement EventListenerOptions argument to addEventListener"
https://bugs.webkit.org/show_bug.cgi?id=149466
http://trac.webkit.org/changeset/201730
Patch by Commit Queue <commit-queue@webkit.org> on 2016-06-06
- 5:00 PM Changeset in webkit [201733] by
-
- 2 edits in trunk/Source/JavaScriptCore
32-bit JSC stress test failing: stress/recursive-try-catch.js.ftl-no-cjit-validate-sampling-profiler
https://bugs.webkit.org/show_bug.cgi?id=158362
Reviewed by Michael Saboff.
The test does infinite recursion until it overflows the stack. That means the
sampling profiler will have to capture excessively large samples, which in turn
makes it run very slowly. This is what causes the test time out.
The fix is to not run the test with the sampling profiler.
- tests/stress/recursive-try-catch.js:
- 4:38 PM Changeset in webkit [201732] by
-
- 2 edits in trunk/Source/JavaScriptCore
Don't reportAbandonedObjectGraph() after throwing out linked code or RegExps.
<https://webkit.org/b/158444>
Unreviewed.
This is a speculative change for iOS performance bots. The calls to reportAbandonedObjectGraph
were basically redundant, since mainframe navigation will cause GC acceleration anyway via
ScriptController.
This appears successful at recovering the ~0.7% regression I could reproduce locally on newer
hardware but it's a bit too noisy to say for sure.
- runtime/VM.cpp:
(JSC::VM::deleteAllLinkedCode):
(JSC::VM::deleteAllRegExpCode):
- 3:33 PM Changeset in webkit [201731] by
-
- 2 edits in trunk/LayoutTests
Marking http/tests/misc/slow-loading-animated-image.html as flaky on ios-simulator
https://bugs.webkit.org/show_bug.cgi?id=157916
Unreviewed test gardening.
- platform/ios-simulator/TestExpectations:
- 3:28 PM Changeset in webkit [201730] by
-
- 25 edits23 adds in trunk
Implement EventListenerOptions argument to addEventListener
https://bugs.webkit.org/show_bug.cgi?id=149466
<rdar://problem/22802031>
Reviewed by Dean Jackson.
LayoutTests/imported/w3c:
Import new test from W3C that covers EventListenerOptions.
- web-platform-tests/dom/events/EventListenerOptions-capture-expected.txt: Added.
- web-platform-tests/dom/events/EventListenerOptions-capture.html: Added.
Source/WebCore:
Implement AddEventListenerOptions dictionary argument to addEventListener()
and EventListenerOptions dictionary argument to removeEventListener(), as
per the latest DOM specification:
Firefox and Chrome already support this.
Support for AddEventListenerOptions in this patch is as follows:
- 'capture': fully supported.
- 'once': fully supported.
- 'passive': supported in the sense that preventDefault() will be ignored
for passive event listeners. There are however currently no
performance benefits from passing this flag. Those optimizations
will be implemented in follow-up patches (in particular for
Touch and Scroll events).
Tests: fast/events/AddEventListenerOptions-once-recursive.html
fast/events/AddEventListenerOptions-once.html
fast/events/AddEventListenerOptions-passive.html
fast/events/removeEventListener-EventListenerOptions-capture.html
imported/w3c/web-platform-tests/dom/events/EventListenerOptions-capture.html
- Modules/webaudio/AudioScheduledSourceNode.cpp:
(WebCore::AudioScheduledSourceNode::addEventListener):
(WebCore::AudioScheduledSourceNode::removeEventListener):
- Modules/webaudio/AudioScheduledSourceNode.h:
- Modules/webaudio/ScriptProcessorNode.cpp:
(WebCore::ScriptProcessorNode::addEventListener):
(WebCore::ScriptProcessorNode::removeEventListener):
- Modules/webaudio/ScriptProcessorNode.h:
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateParametersCheckExpression):
- dom/Event.h:
(WebCore::Event::preventDefault):
(WebCore::Event::setInPassiveListener):
- dom/EventListenerMap.cpp:
(WebCore::addListenerToVector):
(WebCore::EventListenerMap::add):
- dom/EventListenerMap.h:
- dom/EventTarget.cpp:
(WebCore::EventTarget::addEventListener):
(WebCore::EventTarget::addEventListenerForBindings):
(WebCore::EventTarget::removeEventListenerForBindings):
(WebCore::EventTarget::removeEventListener):
(WebCore::EventTarget::setAttributeEventListener):
(WebCore::EventTarget::fireEventListeners):
- dom/EventTarget.h:
(WebCore::EventTarget::ListenerOptions::ListenerOptions):
(WebCore::EventTarget::AddEventListenerOptions::AddEventListenerOptions):
(WebCore::EventTarget::addEventListener):
(WebCore::EventTarget::addEventListenerForBindings):
(WebCore::EventTarget::removeEventListenerForBindings):
- dom/EventTarget.idl:
- dom/MessagePort.cpp:
(WebCore::MessagePort::addEventListener):
- dom/MessagePort.h:
- dom/Node.cpp:
(WebCore::tryAddEventListener):
(WebCore::Node::addEventListener):
(WebCore::tryRemoveEventListener):
(WebCore::Node::removeEventListener):
- dom/Node.h:
- dom/RegisteredEventListener.h:
(WebCore::RegisteredEventListener::Options::Options):
(WebCore::RegisteredEventListener::RegisteredEventListener):
(WebCore::operator==):
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::addEventListener):
(WebCore::HTMLMediaElement::removeEventListener):
- html/HTMLMediaElement.h:
- page/DOMWindow.cpp:
(WebCore::DOMWindow::addEventListener):
(WebCore::DOMWindow::removeEventListener):
- page/DOMWindow.h:
- svg/SVGElement.cpp:
(WebCore::SVGElement::addEventListener):
(WebCore::SVGElement::removeEventListener):
- svg/SVGElement.h:
LayoutTests:
- fast/events/AddEventListenerOptions-once-expected.txt: Added.
- fast/events/AddEventListenerOptions-once-recursive-expected.txt: Added.
- fast/events/AddEventListenerOptions-once-recursive.html: Added.
- fast/events/AddEventListenerOptions-once.html: Added.
- fast/events/AddEventListenerOptions-passive-expected.txt: Added.
- fast/events/AddEventListenerOptions-passive.html: Added.
- fast/events/removeEventListener-EventListenerOptions-capture-expected.txt: Added.
- fast/events/removeEventListener-EventListenerOptions-capture.html: Added.
Add layout testing coverage for various aspects of the functionality.
- imported/blink/fast/events/eventlisteneroptions/capture_default-expected.txt: Added.
- imported/blink/fast/events/eventlisteneroptions/capture_default.html: Added.
- imported/blink/fast/events/eventlisteneroptions/capture_equality-expected.txt: Added.
- imported/blink/fast/events/eventlisteneroptions/capture_equality.html: Added.
- imported/blink/fast/events/eventlisteneroptions/capture_query-expected.txt: Added.
- imported/blink/fast/events/eventlisteneroptions/capture_query.html: Added.
- imported/blink/fast/events/eventlisteneroptions/passive_dispatch-expected.txt: Added.
- imported/blink/fast/events/eventlisteneroptions/passive_dispatch.html: Added.
- imported/blink/fast/events/eventlisteneroptions/passive_inequality-expected.txt: Added.
- imported/blink/fast/events/eventlisteneroptions/passive_inequality.html: Added.
- imported/blink/fast/events/eventlisteneroptions/passive_query-expected.txt: Added.
- imported/blink/fast/events/eventlisteneroptions/passive_query.html: Added.
Import blink tests for this functionality.
- 2:47 PM Changeset in webkit [201729] by
-
- 5 edits in trunk/Source/WebCore
Media elements should only be allowed to control controls manager during a user gesture.
https://bugs.webkit.org/show_bug.cgi?id=158432
Reviewed by Eric Carlson.
Add a new MediaElementSession behavior restriction for the controls manager
which is cleared on the first user gesture. Since canControlControlsManager()
may be called before the first layout, call updatePlaybackControlsManager()
since the main content check requires the laid-out size of the media element.
(WebCore::HTMLMediaElement::HTMLMediaElement):
(WebCore::HTMLMediaElement::layoutSizeChanged):
(WebCore::HTMLMediaElement::removeBehaviorsRestrictionsAfterFirstUserGesture):
- html/HTMLMediaElement.h:
- html/MediaElementSession.cpp:
(WebCore::MediaElementSession::canControlControlsManager):
- html/MediaElementSession.h:
- 2:40 PM Changeset in webkit [201728] by
-
- 11 edits1 add in trunk
WebRTC: Update MediaEndpointPeerConnection::createOffer() to use the transceiver set
https://bugs.webkit.org/show_bug.cgi?id=158203
Reviewed by Eric Carlson.
Source/WebCore:
Create an SDP offer based on the RTCPeerConnection object's set of RTCRtpTransceiver objects
(instead of RTCRtpSender objects).
Updated existing test: fast/mediastream/RTCPeerConnection-inspect-offer.html
- Modules/mediastream/MediaEndpointPeerConnection.cpp:
(WebCore::matchTransceiver):
(WebCore::matchTransceiverByMid):
(WebCore::MediaEndpointPeerConnection::createOfferTask):
- Modules/mediastream/MediaEndpointPeerConnection.h:
- Modules/mediastream/PeerConnectionBackend.h:
Remove getSenders() which is replaced by getTransceivers().
- Modules/mediastream/RTCPeerConnection.h:
- Modules/mediastream/SDPProcessor.cpp:
(WebCore::configurationFromJSON):
(WebCore::configurationToJSON):
- Modules/mediastream/sdp.js:
(SDP.parse):
(SDP.generate):
Add support for mid attribute.
- platform/mediastream/PeerMediaDescription.h:
(WebCore::PeerMediaDescription::mid):
(WebCore::PeerMediaDescription::setMid):
(WebCore::PeerMediaDescription::clone):
LayoutTests:
Updated existing test.
- fast/mediastream/RTCPeerConnection-inspect-offer-expected.txt:
- fast/mediastream/RTCPeerConnection-inspect-offer.html:
Add verification of mid attribute [1] (corresponds to the RTCRtpTransceiver mid attribute).
[1] https://tools.ietf.org/html/rfc5888
- fast/mediastream/resources/sdp-utils.js: Added.
(printComparableSessionDescription):
(verified):
(match):
Move the printComparableSessionDescription function to a separate file
to make it usable in other (future) tests.
- 1:58 PM Changeset in webkit [201727] by
-
- 4 edits6 adds in trunk
Position of WebGL <canvas> on iOS is incorrect with CSS borders
https://bugs.webkit.org/show_bug.cgi?id=156790
Patch by Antoine Quint <Antoine Quint> on 2016-06-06
Reviewed by Simon Fraser.
Source/WebKit2:
WebGL layers on iOS are hosted by a WKRemoteView, which applies a transform scaling
its content by the inverse of the device pixel ratio, which affects how positions are
applied to the WebGL layer. The container layer of the layer hosted by a WKRemoteView
then has an inverse transform applied to it in the PlatformCALayerRemoteCustom
constructor. However, the position of a CALayer is not affected by its transform.
The fix for <rdar://problem/18316542> should be specific to video, so we only apply the
scaling in the case of a LayerTypeAVPlayerLayer.
- UIProcess/ios/RemoteLayerTreeHostIOS.mm:
(-[WKRemoteView initWithFrame:contextID:]):
(WebKit::RemoteLayerTreeHost::createLayer):
(-[WKRemoteView initWithFrame:contextID:hostingDeviceScaleFactor:]): Deleted.
- WebProcess/WebPage/mac/PlatformCALayerRemoteCustom.mm:
(WebKit::PlatformCALayerRemoteCustom::PlatformCALayerRemoteCustom):
LayoutTests:
Adding new tests checking that CSS border, box-shadow and padding properties used on a
WebGL <canvas> element correctly affect the position of the WebGL content.
- webgl/webgl-border-expected.html: Added.
- webgl/webgl-border.html: Added.
- webgl/webgl-box-shadow-expected.html: Added.
- webgl/webgl-box-shadow.html: Added.
- webgl/webgl-padding-expected.html: Added.
- webgl/webgl-padding.html: Added.
- 1:34 PM Changeset in webkit [201726] by
-
- 2 edits1 add in trunk/Tools
REGRESSION(r201449) [GTK] ARMv7 build fails with libicudata.so.55: cannot open shared object file on gtkdoc-scangobj step.
https://bugs.webkit.org/show_bug.cgi?id=158417
Reviewed by Michael Catanzaro.
The toolchain on armhf (ARMv7) seems unable to properly handle
a shared library that doesn't link with anything.
And libicudata is built by default in this way because it only
contains static data.
That makes icu unusable on armhf because the linker will be
unable to resolve the libicudata dependencies.
Most (if not all) distributions workaround this by linking
libicudata with libc6, which is already a needed dependency for
any of the other icu shared libraries.
So import here the Debian patch fixing this issue. For further
details check https://bugs.debian.org/653457
- gtk/jhbuild.modules:
- gtk/patches/icudata-stdlibs.patch: Added.
- 1:33 PM Changeset in webkit [201725] by
-
- 6 edits1 add in trunk
Source/JavaScriptCore:
[ESNext] Trailing commas in function parameters.
https://bugs.webkit.org/show_bug.cgi?id=158020
Reviewed by Keith Miller.
ESNext allow to add trailing commas in function parameters and function arguments.
Link to spec - https://jeffmo.github.io/es-trailing-function-commas
Example of using - (function (a, b,) { return a + b; })(1,2,);
- parser/Parser.cpp:
(JSC::Parser<LexerType>::parseFormalParameters):
(JSC::Parser<LexerType>::parseArguments):
- tests/stress/trailing-comma-in-function-paramters.js: Added.
LayoutTests:
[ESNext] Support trailing commas in function param lists
https://bugs.webkit.org/show_bug.cgi?id=158020
Reviewed by Keith Miller.
- js/parser-syntax-check-expected.txt:
- js/script-tests/parser-syntax-check.js:
- sputnik/Conformance/13_Function_Definition/S13_A5.html:
- 1:30 PM Changeset in webkit [201724] by
-
- 16 edits21 adds in trunk
Support createPattern(HTMLVideoElement, const String& repetitionType)
https://bugs.webkit.org/show_bug.cgi?id=149984
<rdar://problem/23058823>
Patch by George Ruan <gruan@apple.com> on 2016-06-06
Reviewed by Dean Jackson.
Source/WebCore:
Support functionality for HTMLVideoElement argument for
CanvasRenderingContext2D::createPattern*()
Tests: fast/canvas/canvas-createPattern-video-invalid.html
fast/canvas/canvas-createPattern-video-loading.html
fast/canvas/canvas-createPattern-video-modify.html
http/tests/security/canvas-remote-read-remote-video-allowed-anonymous.html
http/tests/security/canvas-remote-read-remote-video-allowed-with-credentials.html
http/tests/security/canvas-remote-read-remote-video-blocked-no-crossorigin.html
http/tests/security/canvas-remote-read-remote-video-localhost.html
http/tests/security/canvas-remote-read-remote-video-redirect.html
media/video-canvas-createPattern.html
- html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::createPattern): Implement
functionality of description
- html/canvas/CanvasRenderingContext2D.h:
- html/canvas/CanvasRenderingContext2D.idl:
LayoutTests:
- fast/canvas/canvas-createPattern-video-invalid-expected.txt: Added.
- fast/canvas/canvas-createPattern-video-invalid.html: Added. Test
behavior when given invalid arguments.
- fast/canvas/canvas-createPattern-video-loading-expected.txt: Added.
- fast/canvas/canvas-createPattern-video-loading.html: Added. Tests
behavior before video loaded, right after it's loaded, and after being
played.
- fast/canvas/canvas-createPattern-video-modify-expected.txt: Added.
- fast/canvas/canvas-createPattern-video-modify.html: Added. Tests
that modifying the video after calling the createPattern() function
does not affect the pattern rendered or to be rendered.
*
http/tests/security/canvas-remote-read-remote-image-allowed-expected.txt:
Fix typo.
*
http/tests/security/canvas-remote-read-remote-image-allowed-with-credentials-expected.txt:
Fix typo.
*
http/tests/security/canvas-remote-read-remote-image-allowed-with-credentials.html:
Fix typo.
- http/tests/security/canvas-remote-read-remote-image-allowed.html:
Fix typo.
*
http/tests/security/canvas-remote-read-remote-image-blocked-no-crossorigin-expected.txt:
Fix typo.
*
http/tests/security/canvas-remote-read-remote-image-blocked-no-crossorigin.html:
Fix typo.
- http/tests/security/canvas-remote-read-remote-video-allowed-anonymous-expected.txt: Added.
*
http/tests/security/canvas-remote-read-remote-video-allowed-anonymous.html:
Added. This test will fail as CORS is not implemented for media yet.
Tests that data can be retrieved from canvas even when tainted if CORS
is enabled with anonymous.
- http/tests/security/canvas-remote-read-remote-video-allowed-with-credentials-expected.txt: Added.
*
http/tests/security/canvas-remote-read-remote-video-allowed-with-credentials.html:
Added. This test will fail as CORS is not implemented for media yet.
Tests that data can be retrieved from canvas even when tainted if CORS
is enabled with credentials.
- http/tests/security/canvas-remote-read-remote-video-blocked-no-crossorigin-expected.txt: Added.
*
http/tests/security/canvas-remote-read-remote-video-blocked-no-crossorigin.html:
Added. Ensures that data cannot be retrieved from a tainted canvas if
no cross origin is enabled.
- http/tests/security/canvas-remote-read-remote-video-localhost-expected.txt: Added.
- http/tests/security/canvas-remote-read-remote-video-localhost.html:
Added. Ensures that localhost is blocked like http.
- http/tests/security/canvas-remote-read-remote-video-redirect-expected.txt: Added.
- http/tests/security/canvas-remote-read-remote-video-redirect.html:
Added. Ensures that redirects are blocked.
- http/tests/security/resources/canvas-video-crossorigin.js: Added.
Includes common functions used to test the CORS of canvas for video.
*
http/tests/security/resources/video-cross-origin-allow-credentials.php:
Added. Script that serves test video for
canvas-remote-read-remote-video-allowed-with-credentials.html.
- media/video-canvas-createPattern-expected.txt: Added.
- media/video-canvas-createPattern.html: Added. Naive test that
ensures functionality of createPattern() with HTMLVideoElement
argument.
- platform/ios-simulator-wk1/TestExpectations: Added
canvas-remote-read-remote-video-allowed-anonymous.html and
canvas-remote-read-remote-video-allowed-with-credentials.html.
- platform/ios-simulator-wk2/TestExpectations: Same as wk1.
- platform/mac/TestExpectations: Same as wk1.
- platform/mac/media/video-canvas-createPattern-expected.png: Added.
- platform/win/TestExpectations: Same as wk1.
- platform/wk2/TestExpectations: Same as wk1.
- 1:19 PM Changeset in webkit [201723] by
-
- 2 edits in trunk/Source/WebCore
Fix the !ENABLE(SHADOW_DOM) && !ENABLE(DETAILS_ELEMENT) build
https://bugs.webkit.org/show_bug.cgi?id=158347
Reviewed by Chris Dumez.
- dom/ContainerNode.cpp:
(WebCore::destroyRenderTreeIfNeeded):
- 1:11 PM Changeset in webkit [201722] by
-
- 4 edits in trunk/Source/WebKit2
Fix build after r201717
Unreviewed.
- NetworkProcess/NetworkConnectionToWebProcess.cpp:
(WebKit::NetworkConnectionToWebProcess::writeBlobsToTemporaryFiles):
- NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::grantSandboxExtensionsToDatabaseProcessForBlobs):
- NetworkProcess/NetworkProcess.h:
- 12:23 PM Changeset in webkit [201721] by
-
- 5 edits in trunk/Source/WebCore
Remove unused ResourceResponse::platformResponseIsUpToDate
https://bugs.webkit.org/show_bug.cgi?id=158424
Reviewed by Brady Eidson.
No change in behavior, just removing unused code that was introduced in r145007.
- platform/network/cf/ResourceResponse.h:
(WebCore::ResourceResponse::ResourceResponse):
(WebCore::ResourceResponse::platformResponseIsUpToDate): Deleted.
- platform/network/cocoa/ResourceResponseCocoa.mm:
(WebCore::ResourceResponse::ResourceResponse):
- platform/network/curl/ResourceResponse.h:
(WebCore::ResourceResponse::cfURLResponse):
(WebCore::ResourceResponse::platformResponseIsUpToDate): Deleted.
- platform/network/soup/ResourceResponse.h:
(WebCore::ResourceResponse::soupMessageTLSErrors):
(WebCore::ResourceResponse::setSoupMessageTLSErrors):
(WebCore::ResourceResponse::decode):
(WebCore::ResourceResponse::platformResponseIsUpToDate): Deleted.
- 12:16 PM Changeset in webkit [201720] by
-
- 2 edits in trunk/Tools
REGRESSION (r104174): 500+ tests failing on Windows
https://bugs.webkit.org/show_bug.cgi?id=75965
Reviewed by Michael Catanzaro.
Reset WebView scale factors before running next test.
- DumpRenderTree/win/DumpRenderTree.cpp:
(resetWebViewToConsistentStateBeforeTesting):
- 12:11 PM Changeset in webkit [201719] by
-
- 17 edits in trunk/Source
Deprecate remaining uses of Lookup getStatic*, use HasStaticPropertyTable instead.
https://bugs.webkit.org/show_bug.cgi?id=158178
Reviewed by Darin Adler.
As of bug #158059 most JSC static table property access no longer requires getOwnPropertySlot to be
overridden. Port remaining calls to the getStatic* functions in Lookup.h over to the new mechanism.
Source/JavaScriptCore:
Deprecate getStatic* functions in Lookup.h
- runtime/Lookup.h:
(JSC::getStaticPropertySlot): Deleted.
(JSC::getStaticFunctionSlot): Deleted.
(JSC::getStaticValueSlot): Deleted.
- No longer required. Static table access now via JSObject.
Source/WebCore:
Switch WebCore DOM instance bindings to use HasStaticPropertyTable.
- bindings/js/JSPluginElementFunctions.h:
(WebCore::pluginElementCustomGetOwnPropertySlot):
- Switch call from getStaticValueSlot to Type::getOwnPropertySlot. For any element where Type::hasStaticPropertyTable is true the HasStaticPropertyTable structure flag will also be set, so Type::getOwnPropertySlot will do the same thing.
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateGetOwnPropertySlotBody):
- If we override getOwnPropertySlot, Base::getOwnPropertySlot will handle property storage & static property lookup.
(InstanceOverridesGetOwnPropertySlot):
- Instances only override getOwnPropertySlot if the really need to, not just for static property lookup.
(GenerateHeader):
- Set HasStaticPropertyTable in instance structureFlags, where appropriate.
(GenerateImplementation):
- GenerateGetOwnPropertySlotBody no longer needs to know if there are static properties.
- bindings/scripts/test/JS/JSTestActiveDOMObject.cpp:
- bindings/scripts/test/JS/JSTestActiveDOMObject.h:
- bindings/scripts/test/JS/JSTestException.cpp:
- bindings/scripts/test/JS/JSTestException.h:
- bindings/scripts/test/JS/JSTestObj.cpp:
- bindings/scripts/test/JS/JSTestObj.h:
- bindings/scripts/test/JS/JSTestTypedefs.cpp:
- bindings/scripts/test/JS/JSTestTypedefs.h:
- bindings/scripts/test/JS/JSattribute.cpp:
- bindings/scripts/test/JS/JSattribute.h:
- Updating bindings test results.
- 11:51 AM Changeset in webkit [201718] by
-
- 9 edits in trunk/Websites/perf.webkit.org
sync-buildbot.js should update the list of tests and platforms associated with a triggerable
https://bugs.webkit.org/show_bug.cgi?id=158406
<rdar://problem/26185737>
Reviewed by Darin Adler.
Added /api/update-triggerable to update the list of configurations (platform and test pairs)
associated with a given triggerable, and make sync-buildbot.js use this JSON API before each
syncing cycle so that the association gets updated automatically by simply updating the JSON.
- server-tests/api-manifest.js: Use const for imported modules.
- server-tests/api-report-commits-tests.js: Removed unnecessary importing of crypto.
- server-tests/resources/mock-data.js:
(MockData.someTestId): Added.
(MockData.somePlatformId): Added.
(MockData.addMockData):
- server-tests/tools-buildbot-triggerable-tests.js: Use const for imported modules. Also added
a test for BuildbotTriggerable's updateTriggerable.
- tools/js/buildbot-triggerable.js:
(BuildbotTriggerable.prototype.updateTriggerable): Added. Find the list of all configurations
associated with this triggeerable and post it to /api/update-triggerable.
- tools/js/database.js: Added triggerable_configurations to the list of tables.
- tools/js/remote.js:
(RemoteAPI.prototype.postJSON): Print the whole response when JSON parsing fails for debugging.
- tools/sync-buildbot.js:
(syncLoop): Call BuildbotTriggerable's updateTriggerable before syncing.
- 11:38 AM Changeset in webkit [201717] by
-
- 17 edits in trunk/Source
Modern IDB: Crash seen in IDBConnectionProxy::putOrAdd on GuardMalloc bot
https://bugs.webkit.org/show_bug.cgi?id=158124
Reviewed by Darin Adler.
Source/WebCore:
No new tests (Covered by existing test configurations).
- Modules/indexeddb/IDBTransaction.cpp:
(WebCore::IDBTransaction::putOrAddOnServer):
- Modules/indexeddb/client/IDBConnectionProxy.cpp:
(WebCore::IDBClient::IDBConnectionProxy::putOrAdd):
- Modules/indexeddb/client/IDBConnectionProxy.h:
(WebCore::IDBClient::IDBConnectionProxy::callConnectionOnMainThread):
- bindings/js/SerializedScriptValue.cpp:
(WebCore::SerializedScriptValue::writeBlobsToDiskForIndexedDB):
- bindings/js/SerializedScriptValue.h:
- platform/network/BlobRegistry.h:
- platform/network/BlobRegistryImpl.cpp:
(WebCore::BlobRegistryImpl::writeBlobsToTemporaryFiles):
- platform/network/BlobRegistryImpl.h:
Source/WebKit2:
- NetworkProcess/FileAPI/NetworkBlobRegistry.cpp:
(WebKit::NetworkBlobRegistry::writeBlobsToTemporaryFiles):
- NetworkProcess/FileAPI/NetworkBlobRegistry.h:
- WebProcess/FileAPI/BlobRegistryProxy.cpp:
(WebKit::BlobRegistryProxy::writeBlobsToTemporaryFiles):
- WebProcess/FileAPI/BlobRegistryProxy.h:
- WebProcess/Network/NetworkProcessConnection.cpp:
(WebKit::NetworkProcessConnection::didClose):
(WebKit::NetworkProcessConnection::writeBlobsToTemporaryFiles):
- WebProcess/Network/NetworkProcessConnection.h:
- 11:09 AM Changeset in webkit [201716] by
-
- 3 edits in trunk/Source/JavaScriptCore
[jsc][mips] Implement absDouble()
https://bugs.webkit.org/show_bug.cgi?id=158206
Patch by Guillaume Emont <guijemont@igalia.com> on 2016-06-06
Reviewed by Mark Lam.
Implement absDouble() for MIPS. This is needed because Math.pow() uses
it since r200208.
- assembler/MIPSAssembler.h:
(JSC::MIPSAssembler::absd):
- assembler/MacroAssemblerMIPS.h:
(JSC::MacroAssemblerMIPS::absDouble):
- 10:56 AM Changeset in webkit [201715] by
-
- 28 edits9 deletes in trunk
Unreviewed, rolling out r201706.
https://bugs.webkit.org/show_bug.cgi?id=158427
This change broke the Yosemite build and its LayoutTest is
failing on Mac and iOS testers (Requested by ryanhaddad on
#webkit).
Reverted changeset:
"Add experimental support for spring based CSS animations"
https://bugs.webkit.org/show_bug.cgi?id=158403
http://trac.webkit.org/changeset/201706
Patch by Commit Queue <commit-queue@webkit.org> on 2016-06-06
- 10:31 AM Changeset in webkit [201714] by
-
- 5 edits in trunk
RegExp unicode parsing reads an extra character before failing
https://bugs.webkit.org/show_bug.cgi?id=158376
Reviewed by Saam Barati.
Source/JavaScriptCore:
This was a probably harmless bug, but keeps triggering assertions
for me locally. Essentially we'd see a parse error, set the error
type, but then carry on parsing. In debug builds this asserts, in
release builds you are pretty safe unless you're exceptionally
unlucky with where the error occurs.
- yarr/YarrParser.h:
(JSC::Yarr::Parser::parseEscape):
LayoutTests:
Add a couple of tests.
- js/script-tests/regexp-unicode.js:
- 10:22 AM Changeset in webkit [201713] by
-
- 2 edits in trunk/Source/JavaScriptCore
[jsc][mips] fix JIT::emit_op_log_shadow_chicken_prologue/_tail
https://bugs.webkit.org/show_bug.cgi?id=158209
Patch by Guillaume Emont <guijemont@igalia.com> on 2016-06-06
Reviewed by Mark Lam.
On MIPS, changes GPRInfo::nonArgGPR0 to be regT4 instead of regT0,
since the code of JIT::emit_op_log_shadow_chicken_prologue/_tail()
expects nonArgGPR0 to be a different register from regT0 and regT2.
- jit/GPRInfo.h:
- 9:40 AM Changeset in webkit [201712] by
-
- 3 edits2 adds in trunk
Crash under JSObject::getOwnPropertyDescriptor()
https://bugs.webkit.org/show_bug.cgi?id=158382
<rdar://problem/26605004>
Reviewed by Mark Lam.
Source/JavaScriptCore:
- runtime/JSObject.h:
(JSC::JSObject::putDirectInternal):
We were crashing under getOwnPropertyDescriptor() because the
CustomAccessor was not properly reset on window.statusbar when
setting it to false (which is allowed because the property is
marked as [Replaceable] in the IDL). We now property reset the
CustomAccessor flag in putDirectInternal() when needed. This
fixes the crash.
LayoutTests:
Add layout test to cover the crash in JSObject::getOwnPropertyDescriptor().
- js/dom/getOwnPropertyDescriptor-crash-expected.txt: Added.
- js/dom/getOwnPropertyDescriptor-crash.html: Added.
- 7:31 AM Changeset in webkit [201711] by
-
- 2 edits in trunk/Source/JavaScriptCore
[EFL] Move efl include paths to JavaScriptCore_SYSTEM_INCLUDE_DIRECTORIES
https://bugs.webkit.org/show_bug.cgi?id=158418
Reviewed by Csaba Osztrogonác.
In Source/JavaScriptCore/PlatformEfl.cmake, we don't use JavaScriptCore_SYSTEM_INCLUDE_DIRECTORIES
for efl include paths.
- PlatformEfl.cmake:
- 6:00 AM Changeset in webkit [201710] by
-
- 2 edits in trunk
[EFL] Update ewebkit minor version
https://bugs.webkit.org/show_bug.cgi?id=158409
Reviewed by Csaba Osztrogonác.
EWebKit has used efl 1.17 version though, it still is stopped at version 1.14.
- Source/cmake/OptionsEfl.cmake: Bump minor version to 1.17.
- 5:11 AM Changeset in webkit [201709] by
-
- 3 edits2 adds in trunk
[css-grid] Horizontal scroll must account for grid container's height
https://bugs.webkit.org/show_bug.cgi?id=157971
Reviewed by Darin Adler.
Source/WebCore:
We don't consider the scrollbar when computing the grid container's
logical height at the beginning of the 'layoutBlock' logic. We must
do it because otherwise, contentLogicalHeight may return a negative
value.
Test: fast/css-grid-layout/grid-container-scroll-accounts-for-sizing.html
- rendering/RenderGrid.cpp:
(WebCore::RenderGrid::layoutBlock):
LayoutTests:
Test to verify we account horizontal scrollbar's size for grid container's
height computation.
- fast/css-grid-layout/grid-container-scroll-accounts-for-sizing-expected.html: Added.
- fast/css-grid-layout/grid-container-scroll-accounts-for-sizing.html: Added.
- 1:25 AM Changeset in webkit [201708] by
-
- 35 edits in trunk/Source
Reduce ResourceRequest copying in loading code
https://bugs.webkit.org/show_bug.cgi?id=158251
Patch by Alex Christensen <achristensen@webkit.org> on 2016-06-06
Reviewed by Darin Adler.
Source/WebCore:
No new tests. There should be no change in behavior except fewer unnecessary copies.
Before, we would pass a const ResourceRequest& around, and if we needed to modify it
we would copy the whole thing, modify the copy, and pass the copy along. This can be
accomplished with move semantics without the now-unnecessary copy.
The biggest conceptual change is that the synchronous ResourceHandleClient::willSendRequest
used to take a non-const ResourceRequest& and modify it, but now it returns a modified
ResourceRequest instead.
- loader/ResourceLoader.cpp:
(WebCore::ResourceLoader::cannotShowURLError):
(WebCore::ResourceLoader::willSendRequest):
(WebCore::ResourceLoader::didSendData):
- loader/ResourceLoader.h:
- platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
(ResourceHandleStreamingClient::getOrCreateReadBuffer):
(ResourceHandleStreamingClient::willSendRequest):
(ResourceHandleStreamingClient::didReceiveResponse):
- platform/network/ResourceHandle.h:
- platform/network/ResourceHandleClient.cpp:
(WebCore::ResourceHandleClient::~ResourceHandleClient):
(WebCore::ResourceHandleClient::willSendRequest):
(WebCore::ResourceHandleClient::willSendRequestAsync):
(WebCore::ResourceHandleClient::didReceiveResponseAsync):
- platform/network/ResourceHandleClient.h:
(WebCore::ResourceHandleClient::didSendData):
(WebCore::ResourceHandleClient::didReceiveResponse):
(WebCore::ResourceHandleClient::loadingSynchronousXHR):
(WebCore::ResourceHandleClient::willSendRequest): Deleted.
- platform/network/SynchronousLoaderClient.cpp:
(WebCore::SynchronousLoaderClient::~SynchronousLoaderClient):
(WebCore::SynchronousLoaderClient::willSendRequest):
(WebCore::SynchronousLoaderClient::shouldUseCredentialStorage):
- platform/network/SynchronousLoaderClient.h:
- platform/network/cf/ResourceHandleCFNet.cpp:
(WebCore::ResourceHandle::cancel):
(WebCore::ResourceHandle::willSendRequest):
- platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.cpp:
(WebCore::ResourceHandleCFURLConnectionDelegateWithOperationQueue::willSendRequest):
- platform/network/cf/SynchronousResourceHandleCFURLConnectionDelegate.cpp:
(WebCore::SynchronousResourceHandleCFURLConnectionDelegate::willSendRequest):
- platform/network/mac/ResourceHandleMac.mm:
(WebCore::ResourceHandle::platformLoadResourceSynchronously):
(WebCore::ResourceHandle::willSendRequest):
(WebCore::ResourceHandle::continueWillSendRequest):
- platform/network/mac/WebCoreResourceHandleAsDelegate.mm:
(-[WebCoreResourceHandleAsDelegate connection:willSendRequest:redirectResponse:]):
(-[WebCoreResourceHandleAsDelegate connectionShouldUseCredentialStorage:]):
- platform/network/mac/WebCoreResourceHandleAsOperationQueueDelegate.mm:
(-[WebCoreResourceHandleAsOperationQueueDelegate connection:willSendRequest:redirectResponse:]):
- platform/network/soup/ResourceHandleSoup.cpp:
(WebCore::shouldRedirectAsGET):
(WebCore::continueAfterWillSendRequest):
(WebCore::readCallback):
(WebCore::ResourceHandle::continueWillSendRequest):
(WebCore::ResourceHandle::continueDidReceiveResponse):
Source/WebKit2:
- NetworkProcess/Downloads/DownloadManager.cpp:
(WebKit::DownloadManager::continueCanAuthenticateAgainstProtectionSpace):
(WebKit::DownloadManager::continueWillSendRequest):
(WebKit::DownloadManager::willDecidePendingDownloadDestination):
- NetworkProcess/Downloads/DownloadManager.h:
- NetworkProcess/Downloads/PendingDownload.cpp:
(WebKit::PendingDownload::PendingDownload):
(WebKit::PendingDownload::willSendRedirectedRequest):
(WebKit::PendingDownload::continueWillSendRequest):
(WebKit::PendingDownload::canAuthenticateAgainstProtectionSpaceAsync):
- NetworkProcess/Downloads/PendingDownload.h:
- NetworkProcess/NetworkDataTask.h:
(WebKit::NetworkDataTask::firstRequest):
- NetworkProcess/NetworkLoad.cpp:
(WebKit::NetworkLoad::cancel):
(WebKit::NetworkLoad::continueWillSendRequest):
(WebKit::NetworkLoad::sharedDidReceiveResponse):
(WebKit::NetworkLoad::sharedWillSendRedirectedRequest):
(WebKit::NetworkLoad::setPendingDownload):
(WebKit::NetworkLoad::willPerformHTTPRedirection):
(WebKit::NetworkLoad::didReceiveChallenge):
(WebKit::NetworkLoad::didFail):
(WebKit::NetworkLoad::willSendRequestAsync):
- NetworkProcess/NetworkLoad.h:
(WebKit::NetworkLoad::currentRequest):
(WebKit::NetworkLoad::clearCurrentRequest):
(WebKit::NetworkLoad::pendingDownloadID):
- NetworkProcess/NetworkLoadClient.h:
- NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::continueCanAuthenticateAgainstProtectionSpace):
(WebKit::NetworkProcess::continueWillSendRequest):
(WebKit::NetworkProcess::pendingDownloadCanceled):
- NetworkProcess/NetworkProcess.h:
- NetworkProcess/NetworkResourceLoader.cpp:
(WebKit::NetworkResourceLoader::didFailLoading):
(WebKit::NetworkResourceLoader::willSendRedirectedRequest):
(WebKit::NetworkResourceLoader::continueWillSendRequest):
(WebKit::NetworkResourceLoader::continueDidReceiveResponse):
- NetworkProcess/NetworkResourceLoader.h:
- NetworkProcess/PingLoad.h:
(WebKit::PingLoad::PingLoad):
- NetworkProcess/cache/NetworkCacheSpeculativeLoad.cpp:
(WebKit::NetworkCache::SpeculativeLoad::~SpeculativeLoad):
(WebKit::NetworkCache::SpeculativeLoad::willSendRedirectedRequest):
- NetworkProcess/cache/NetworkCacheSpeculativeLoad.h:
- NetworkProcess/cocoa/NetworkDataTaskCocoa.mm:
(WebKit::NetworkDataTask::didBecomeDownload):
(WebKit::NetworkDataTask::willPerformHTTPRedirection):
- WebProcess/Network/WebResourceLoader.cpp:
(WebKit::WebResourceLoader::detachFromCoreLoader):
(WebKit::WebResourceLoader::willSendRequest):
- WebProcess/Network/WebResourceLoader.h:
Jun 5, 2016:
- 10:09 PM Changeset in webkit [201707] by
-
- 2 edits in trunk
[EFL] Sync EFL features with featureList.pm
https://bugs.webkit.org/show_bug.cgi?id=158410
Reviewed by Antonio Gomes.
In OptionsEfl, some features on/off status are different with
featureList.pm definitions. Sync with it.
- Source/cmake/OptionsEfl.cmake:
- 9:56 PM Changeset in webkit [201706] by
-
- 28 edits9 adds in trunk
Add experimental support for spring based CSS animations
https://bugs.webkit.org/show_bug.cgi?id=158403
Patch by Sam Weinig <sam@webkit.org> on 2016-06-05
Reviewed by Dean Jackson.
Source/WebCore:
Adds experimental support for a new CSS animation timing function that uses
spring to model the time function. To use it you replace your normal timing
function, be it cubic-bezier or steps, with a new function called spring().
For instance, for a transition you would write:
transition-timing-function: spring(1 100 10 0);
The parameters are, in order:
- Mass
- Stiffness
- Damping
- Initial Velocity
Tests: animations/spring-computed-style.html
animations/spring-function.html
animations/spring-parsing.html
- WebCore.xcodeproj/project.pbxproj:
Add new file.
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::createTimingFunctionValue):
Modernize and add support for the spring function.
- css/CSSParser.cpp:
(WebCore::CSSParserContext::CSSParserContext):
(WebCore::operator==):
(WebCore::CSSParser::CSSParser):
(WebCore::CSSParser::parseTransformOriginShorthand):
(WebCore::CSSParser::isSpringTimingFunctionEnabled):
(WebCore::CSSParser::parseCubicBezierTimingFunctionValue):
(WebCore::CSSParser::parseSpringTimingFunctionValue):
(WebCore::CSSParser::parseAnimationTimingFunction):
- css/CSSParser.h:
- css/CSSParserMode.h:
Add parsing support for the spring() function.
- css/CSSTimingFunctionValue.cpp:
(WebCore::CSSCubicBezierTimingFunctionValue::customCSSText):
(WebCore::CSSCubicBezierTimingFunctionValue::equals):
(WebCore::CSSStepsTimingFunctionValue::customCSSText):
(WebCore::CSSStepsTimingFunctionValue::equals):
(WebCore::CSSSpringTimingFunctionValue::customCSSText):
(WebCore::CSSSpringTimingFunctionValue::equals):
- css/CSSTimingFunctionValue.h:
(WebCore::CSSSpringTimingFunctionValue::create):
(WebCore::CSSSpringTimingFunctionValue::mass):
(WebCore::CSSSpringTimingFunctionValue::stiffness):
(WebCore::CSSSpringTimingFunctionValue::damping):
(WebCore::CSSSpringTimingFunctionValue::initialVelocity):
(WebCore::CSSSpringTimingFunctionValue::CSSSpringTimingFunctionValue):
Modernize and add support for the spring function.
- css/CSSToStyleMap.cpp:
(WebCore::CSSToStyleMap::mapAnimationTimingFunction):
Pipe the spring function into the animation.
- css/CSSValue.cpp:
(WebCore::CSSValue::equals):
(WebCore::CSSValue::cssText):
(WebCore::CSSValue::destroy):
- css/CSSValue.h:
(WebCore::CSSValue::isSpringTimingFunctionValue):
Add support for the spring function.
- page/Settings.in:
Add a setting to control if the spring function is enabled.
- page/animation/AnimationBase.cpp:
(WebCore::solveSpringFunction):
(WebCore::AnimationBase::progress):
Add support for solving the spring function. Since the spring requires time to be absolute,
get the real time by multiplying the ratio t, to the total duration.
- platform/animation/TimingFunction.cpp:
(WebCore::operator<<):
- platform/animation/TimingFunction.h:
(WebCore::TimingFunction::~TimingFunction):
(WebCore::TimingFunction::isSpringTimingFunction):
Add support for the spring timing function.
- platform/graphics/SpringSolver.h: Added.
(WebCore::SpringSolver::SpringSolver):
(WebCore::SpringSolver::solve):
Add a Spring solver that matches the one in CoreAnimation.
- platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::createAnimationFromKeyframes):
(WebCore::GraphicsLayerCA::appendToUncommittedAnimations):
(WebCore::GraphicsLayerCA::createBasicAnimation):
(WebCore::GraphicsLayerCA::createSpringAnimation):
(WebCore::GraphicsLayerCA::setupAnimation):
- platform/graphics/ca/GraphicsLayerCA.h:
Map animations with spring timing functions to CASpringAnimations.
- platform/graphics/ca/PlatformCAAnimation.cpp:
(WebCore::operator<<):
(WebCore::PlatformCAAnimation::isBasicAnimation):
- platform/graphics/ca/PlatformCAAnimation.h:
(WebCore::PlatformCAAnimation::setActualStartTimeIfNeeded):
(WebCore::PlatformCAAnimation::PlatformCAAnimation):
- platform/graphics/ca/cocoa/PlatformCAAnimationCocoa.mm:
(WebCore::toCAMediaTimingFunction):
(PlatformCAAnimationCocoa::PlatformCAAnimationCocoa):
(PlatformCAAnimationCocoa::setTimingFunction):
(PlatformCAAnimationCocoa::copyTimingFunctionFrom):
(PlatformCAAnimationCocoa::setFromValue):
(PlatformCAAnimationCocoa::copyFromValueFrom):
(PlatformCAAnimationCocoa::setToValue):
(PlatformCAAnimationCocoa::copyToValueFrom):
Add a new type of PlatformCAAnimation, Spring, which is a sub-type of Basic.
Source/WebKit2:
- Shared/WebCoreArgumentCoders.cpp:
(IPC::ArgumentCoder<StepsTimingFunction>::decode):
(IPC::ArgumentCoder<SpringTimingFunction>::encode):
(IPC::ArgumentCoder<SpringTimingFunction>::decode):
(IPC::ArgumentCoder<FloatPoint>::encode):
- Shared/WebCoreArgumentCoders.h:
- Shared/WebPreferencesDefinitions.h:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences):
- WebProcess/WebPage/mac/PlatformCAAnimationRemote.mm:
(WebKit::PlatformCAAnimationRemote::Properties::encode):
(WebKit::PlatformCAAnimationRemote::Properties::decode):
(WebKit::addAnimationToLayer):
Pipe through support for the Spring animation.
LayoutTests:
- animations/script-tests/spring-computed-style.js: Added.
- animations/script-tests/spring-parsing.js: Added.
- animations/spring-computed-style-expected.txt: Added.
- animations/spring-computed-style.html: Added.
- animations/spring-function-expected.txt: Added.
- animations/spring-function.html: Added.
- animations/spring-parsing-expected.txt: Added.
- animations/spring-parsing.html: Added.
Add tests for the spring timing function.
- 8:59 PM Changeset in webkit [201705] by
-
- 2 edits in trunk/LayoutTests
Unreviewed EFL gardening on June 6. Unskip passing tests and mark failing tests.
New bug is filed for new failing tests.
- platform/efl/TestExpectations:
- 8:19 PM Changeset in webkit [201704] by
-
- 7 edits in trunk/Source/WebCore
Addressing post-review comments on r201635.
Reviewed by Chris Dumez.
- rendering/RenderInline.h:
(WebCore::RenderInline::computeRectForRepaint):
- rendering/RenderObject.h:
(WebCore::RenderObject::RepaintContext::RepaintContext):
(WebCore::RenderObject::computeRectForRepaint):
- rendering/RenderTableCell.h:
- rendering/RenderView.h:
- rendering/svg/RenderSVGForeignObject.h:
- rendering/svg/RenderSVGText.h:
- 6:56 PM Changeset in webkit [201703] by
-
- 66 edits6 adds in trunk/Source
Change ProxyObject.Get not to use custom accessor
https://bugs.webkit.org/show_bug.cgi?id=157080
Reviewed by Darin Adler.
Source/JavaScriptCore:
This patch focuses on introducing the second part of the followings.
But to do so, first and third parts are necessary.
- Insert missing exception checks for getPropertySlot.
While getPropertySlot can perform user-observable behavior if the slot is not VMInquiry,
several places miss exeption checks. For example, ProxyObject's hasProperty already can
throw any errors. Looking through the code, we found several missing error checks after
hasProperty, but this will be fixed in the separated patch[1].
- Do not use custom accessor to implement ProxyObject's Get.
The caller already allows getOwnPropertySlot to throw an exception if the type
is not VMInquiry. So instead of using custom accessor, we simply implement it
directly in the ProxyObject's method.
- Strip slotBase from custom accessor.
The custom accessor should not be bound to the specific slot base[2], since it
is just an accessor. There is an alternative design: makeing this custom accessor
to custom value accessor and accept both the slot base and the receiver instead
of allowing throwing an error from getOwnPropertySlot. But we take the first design
that allows getPropertySlot to throw an error, since hasProperty (that does not call
getValue of the custom getters) can already throw any errors.
To query the property with the non-user-observable way, we already provided the way for that:
use VMInquiry and isTaintedByProxy() instead.
Tests just ensure that the current semantics works correctly after this patch.
And this patch is performance neutral.
Later, we will attempt to rename "thisValue" to "receiver"[3].
[1]: https://bugs.webkit.org/show_bug.cgi?id=158398
[2]: https://bugs.webkit.org/show_bug.cgi?id=157978
[3]: https://bugs.webkit.org/show_bug.cgi?id=158397
- API/JSCallbackObject.h:
- API/JSCallbackObjectFunctions.h:
(JSC::JSCallbackObject<Parent>::staticFunctionGetter):
(JSC::JSCallbackObject<Parent>::callbackGetter):
- bytecode/PolymorphicAccess.cpp:
(JSC::AccessCase::generateImpl):
- dfg/DFGOperations.cpp:
- interpreter/Interpreter.cpp:
(JSC::Interpreter::execute):
- jit/JITOperations.cpp:
- jsc.cpp:
(WTF::ImpureGetter::getOwnPropertySlot):
(WTF::CustomGetter::customGetter):
(WTF::RuntimeArray::lengthGetter):
(GlobalObject::finishCreation):
(GlobalObject::moduleLoaderFetch):
(functionGetGetterSetter):
(functionRun):
(functionLoad):
(functionLoadString):
(functionReadFile):
(functionCheckSyntax):
(functionLoadWebAssembly):
(functionLoadModule):
(functionCreateBuiltin):
(functionCheckModuleSyntax):
(dumpException):
(runWithScripts):
(runInteractive):
- llint/LLIntSlowPaths.cpp:
(JSC::LLInt::LLINT_SLOW_PATH_DECL):
- runtime/CommonSlowPaths.cpp:
(JSC::SLOW_PATH_DECL):
- runtime/JSBoundSlotBaseFunction.cpp:
(JSC::boundSlotBaseFunctionCall):
- runtime/JSCJSValue.h:
- runtime/JSCJSValueInlines.h:
(JSC::JSValue::getPropertySlot):
- runtime/JSCellInlines.h:
(JSC::ExecState::vm):
This change is super important for performance. We add severalexec->hadException()calls into the super hot path, like JSC::operationGetByIdOptimize.
Without this change, we call ExecState::vm() and it is not inlined. This causes 1 - 2% performance regression in Octane PDFJS.
- runtime/JSFunction.cpp:
(JSC::JSFunction::argumentsGetter):
(JSC::JSFunction::callerGetter):
- runtime/JSFunction.h:
- runtime/JSGenericTypedArrayViewConstructorInlines.h:
(JSC::constructGenericTypedArrayViewWithArguments):
- runtime/JSModuleNamespaceObject.cpp:
(JSC::callbackGetter):
- runtime/JSONObject.cpp:
(JSC::Stringifier::Holder::appendNextProperty):
Here's UNLIKELY is important for Kraken's json-stringify-tinderbox. Without it, we can observe 0.5% regression.
(JSC::Walker::walk):
- runtime/JSObject.h:
(JSC::JSObject::getPropertySlot):
- runtime/ObjectPrototype.cpp:
(JSC::objectProtoFuncToString):
- runtime/PropertySlot.cpp:
(JSC::PropertySlot::customGetter):
- runtime/PropertySlot.h:
(JSC::PropertySlot::thisValue):
- runtime/ProxyObject.cpp:
(JSC::performProxyGet):
(JSC::ProxyObject::performGet):
(JSC::ProxyObject::getOwnPropertySlotCommon):
- runtime/ProxyObject.h:
- runtime/RegExpConstructor.cpp:
(JSC::regExpConstructorDollar):
(JSC::regExpConstructorInput):
(JSC::regExpConstructorMultiline):
(JSC::regExpConstructorLastMatch):
(JSC::regExpConstructorLastParen):
(JSC::regExpConstructorLeftContext):
(JSC::regExpConstructorRightContext):
- tests/stress/get-from-scope-dynamic-onto-proxy.js: Added.
(shouldBe):
(shouldThrow.handler.has):
(handler.has):
(try.handler.has):
- tests/stress/operation-in-throw-error.js: Added.
(testCase.handler.has):
(testCase):
- tests/stress/proxy-and-json-stringify.js: Added.
(shouldThrow):
- tests/stress/proxy-and-typed-array.js: Added.
- tests/stress/proxy-json-path.js: Added.
- tests/stress/proxy-with-statement.js: Added.
Source/WebCore:
- bindings/js/JSCryptoAlgorithmDictionary.cpp:
(WebCore::getProperty):
- bindings/js/JSDOMBinding.h:
(WebCore::nonCachingStaticFunctionGetter):
- bindings/js/JSDOMWindowCustom.cpp:
(WebCore::jsDOMWindowWebKit):
- bindings/js/JSDictionary.cpp:
(WebCore::JSDictionary::tryGetProperty):
- bindings/js/JSPluginElementFunctions.cpp:
(WebCore::pluginElementPropertyGetter):
- bindings/js/JSPluginElementFunctions.h:
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateHeader):
(GenerateImplementation):
- bindings/scripts/test/JS/JSInterfaceName.cpp:
(WebCore::jsInterfaceNameConstructor):
- bindings/scripts/test/JS/JSTestActiveDOMObject.cpp:
(WebCore::jsTestActiveDOMObjectExcitingAttr):
(WebCore::jsTestActiveDOMObjectConstructor):
- bindings/scripts/test/JS/JSTestClassWithJSBuiltinConstructor.cpp:
(WebCore::jsTestClassWithJSBuiltinConstructorConstructor):
- bindings/scripts/test/JS/JSTestCustomConstructorWithNoInterfaceObject.cpp:
(WebCore::jsTestCustomConstructorWithNoInterfaceObjectConstructor):
- bindings/scripts/test/JS/JSTestCustomNamedGetter.cpp:
(WebCore::jsTestCustomNamedGetterConstructor):
- bindings/scripts/test/JS/JSTestEventConstructor.cpp:
(WebCore::jsTestEventConstructorAttr1):
(WebCore::jsTestEventConstructorAttr2):
(WebCore::jsTestEventConstructorAttr3):
(WebCore::jsTestEventConstructorConstructor):
- bindings/scripts/test/JS/JSTestEventTarget.cpp:
(WebCore::jsTestEventTargetConstructor):
- bindings/scripts/test/JS/JSTestException.cpp:
(WebCore::jsTestExceptionName):
(WebCore::jsTestExceptionConstructor):
- bindings/scripts/test/JS/JSTestGenerateIsReachable.cpp:
(WebCore::jsTestGenerateIsReachableConstructor):
- bindings/scripts/test/JS/JSTestGlobalObject.cpp:
(WebCore::jsTestGlobalObjectRegularAttribute):
(WebCore::jsTestGlobalObjectEnabledAtRuntimeAttribute):
(WebCore::jsTestGlobalObjectConstructor):
- bindings/scripts/test/JS/JSTestInterface.cpp:
(WebCore::jsTestInterfaceConstructorImplementsStaticReadOnlyAttr):
(WebCore::jsTestInterfaceConstructorImplementsStaticAttr):
(WebCore::jsTestInterfaceImplementsStr1):
(WebCore::jsTestInterfaceImplementsStr2):
(WebCore::jsTestInterfaceImplementsStr3):
(WebCore::jsTestInterfaceImplementsNode):
(WebCore::jsTestInterfaceConstructorSupplementalStaticReadOnlyAttr):
(WebCore::jsTestInterfaceConstructorSupplementalStaticAttr):
(WebCore::jsTestInterfaceSupplementalStr1):
(WebCore::jsTestInterfaceSupplementalStr2):
(WebCore::jsTestInterfaceSupplementalStr3):
(WebCore::jsTestInterfaceSupplementalNode):
(WebCore::jsTestInterfaceConstructor):
- bindings/scripts/test/JS/JSTestJSBuiltinConstructor.cpp:
(WebCore::jsTestJSBuiltinConstructorTestAttributeCustom):
(WebCore::jsTestJSBuiltinConstructorTestAttributeRWCustom):
(WebCore::jsTestJSBuiltinConstructorConstructor):
- bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:
(WebCore::jsTestMediaQueryListListenerConstructor):
- bindings/scripts/test/JS/JSTestNamedConstructor.cpp:
(WebCore::jsTestNamedConstructorConstructor):
- bindings/scripts/test/JS/JSTestNode.cpp:
(WebCore::jsTestNodeName):
(WebCore::jsTestNodeConstructor):
- bindings/scripts/test/JS/JSTestNondeterministic.cpp:
(WebCore::jsTestNondeterministicNondeterministicReadonlyAttr):
(WebCore::jsTestNondeterministicNondeterministicWriteableAttr):
(WebCore::jsTestNondeterministicNondeterministicExceptionAttr):
(WebCore::jsTestNondeterministicNondeterministicGetterExceptionAttr):
(WebCore::jsTestNondeterministicNondeterministicSetterExceptionAttr):
(WebCore::jsTestNondeterministicConstructor):
- bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::jsTestObjReadOnlyLongAttr):
(WebCore::jsTestObjReadOnlyStringAttr):
(WebCore::jsTestObjReadOnlyTestObjAttr):
(WebCore::jsTestObjConstructorStaticReadOnlyLongAttr):
(WebCore::jsTestObjConstructorStaticStringAttr):
(WebCore::jsTestObjConstructorTestSubObj):
(WebCore::jsTestObjTestSubObjEnabledBySettingConstructor):
(WebCore::jsTestObjEnumAttr):
(WebCore::jsTestObjByteAttr):
(WebCore::jsTestObjOctetAttr):
(WebCore::jsTestObjShortAttr):
(WebCore::jsTestObjClampedShortAttr):
(WebCore::jsTestObjEnforceRangeShortAttr):
(WebCore::jsTestObjUnsignedShortAttr):
(WebCore::jsTestObjLongAttr):
(WebCore::jsTestObjLongLongAttr):
(WebCore::jsTestObjUnsignedLongLongAttr):
(WebCore::jsTestObjStringAttr):
(WebCore::jsTestObjTestObjAttr):
(WebCore::jsTestObjTestNullableObjAttr):
(WebCore::jsTestObjLenientTestObjAttr):
(WebCore::jsTestObjUnforgeableAttr):
(WebCore::jsTestObjStringAttrTreatingNullAsEmptyString):
(WebCore::jsTestObjXMLObjAttr):
(WebCore::jsTestObjCreate):
(WebCore::jsTestObjReflectedStringAttr):
(WebCore::jsTestObjReflectedIntegralAttr):
(WebCore::jsTestObjReflectedUnsignedIntegralAttr):
(WebCore::jsTestObjReflectedBooleanAttr):
(WebCore::jsTestObjReflectedURLAttr):
(WebCore::jsTestObjReflectedCustomIntegralAttr):
(WebCore::jsTestObjReflectedCustomBooleanAttr):
(WebCore::jsTestObjReflectedCustomURLAttr):
(WebCore::jsTestObjEnabledAtRuntimeAttribute):
(WebCore::jsTestObjTypedArrayAttr):
(WebCore::jsTestObjAttrWithGetterException):
(WebCore::jsTestObjAttrWithGetterExceptionWithMessage):
(WebCore::jsTestObjAttrWithSetterException):
(WebCore::jsTestObjAttrWithSetterExceptionWithMessage):
(WebCore::jsTestObjStringAttrWithGetterException):
(WebCore::jsTestObjStringAttrWithSetterException):
(WebCore::jsTestObjStrictTypeCheckingAttribute):
(WebCore::jsTestObjCustomAttr):
(WebCore::jsTestObjOnfoo):
(WebCore::jsTestObjOnwebkitfoo):
(WebCore::jsTestObjWithScriptStateAttribute):
(WebCore::jsTestObjWithCallWithAndSetterCallWithAttribute):
(WebCore::jsTestObjWithScriptExecutionContextAttribute):
(WebCore::jsTestObjWithScriptStateAttributeRaises):
(WebCore::jsTestObjWithScriptExecutionContextAttributeRaises):
(WebCore::jsTestObjWithScriptExecutionContextAndScriptStateAttribute):
(WebCore::jsTestObjWithScriptExecutionContextAndScriptStateAttributeRaises):
(WebCore::jsTestObjWithScriptExecutionContextAndScriptStateWithSpacesAttribute):
(WebCore::jsTestObjWithScriptArgumentsAndCallStackAttribute):
(WebCore::jsTestObjConditionalAttr1):
(WebCore::jsTestObjConditionalAttr2):
(WebCore::jsTestObjConditionalAttr3):
(WebCore::jsTestObjConditionalAttr4Constructor):
(WebCore::jsTestObjConditionalAttr5Constructor):
(WebCore::jsTestObjConditionalAttr6Constructor):
(WebCore::jsTestObjCachedAttribute1):
(WebCore::jsTestObjCachedAttribute2):
(WebCore::jsTestObjAnyAttribute):
(WebCore::jsTestObjContentDocument):
(WebCore::jsTestObjMutablePoint):
(WebCore::jsTestObjImmutablePoint):
(WebCore::jsTestObjStrawberry):
(WebCore::jsTestObjStrictFloat):
(WebCore::jsTestObjDescription):
(WebCore::jsTestObjId):
(WebCore::jsTestObjHash):
(WebCore::jsTestObjReplaceableAttribute):
(WebCore::jsTestObjNullableDoubleAttribute):
(WebCore::jsTestObjNullableLongAttribute):
(WebCore::jsTestObjNullableBooleanAttribute):
(WebCore::jsTestObjNullableStringAttribute):
(WebCore::jsTestObjNullableLongSettableAttribute):
(WebCore::jsTestObjNullableStringSettableAttribute):
(WebCore::jsTestObjNullableStringValue):
(WebCore::jsTestObjAttribute):
(WebCore::jsTestObjAttributeWithReservedEnumType):
(WebCore::jsTestObjPutForwardsAttribute):
(WebCore::jsTestObjPutForwardsNullableAttribute):
(WebCore::jsTestObjConstructor):
- bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp:
(WebCore::jsTestOverloadedConstructorsConstructor):
- bindings/scripts/test/JS/JSTestOverrideBuiltins.cpp:
(WebCore::jsTestOverrideBuiltinsConstructor):
- bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:
(WebCore::jsTestSerializedScriptValueInterfaceValue):
(WebCore::jsTestSerializedScriptValueInterfaceReadonlyValue):
(WebCore::jsTestSerializedScriptValueInterfaceCachedValue):
(WebCore::jsTestSerializedScriptValueInterfacePorts):
(WebCore::jsTestSerializedScriptValueInterfaceCachedReadonlyValue):
(WebCore::jsTestSerializedScriptValueInterfaceConstructor):
- bindings/scripts/test/JS/JSTestTypedefs.cpp:
(WebCore::jsTestTypedefsUnsignedLongLongAttr):
(WebCore::jsTestTypedefsImmutableSerializedScriptValue):
(WebCore::jsTestTypedefsConstructorTestSubObj):
(WebCore::jsTestTypedefsAttrWithGetterException):
(WebCore::jsTestTypedefsAttrWithSetterException):
(WebCore::jsTestTypedefsStringAttrWithGetterException):
(WebCore::jsTestTypedefsStringAttrWithSetterException):
(WebCore::jsTestTypedefsConstructor):
- bindings/scripts/test/JS/JSattribute.cpp:
(WebCore::jsattributeReadonly):
(WebCore::jsattributeConstructor):
- bindings/scripts/test/JS/JSreadonly.cpp:
(WebCore::jsreadonlyConstructor):
- bridge/runtime_array.cpp:
(JSC::RuntimeArray::lengthGetter):
- bridge/runtime_array.h:
- bridge/runtime_method.cpp:
(JSC::RuntimeMethod::lengthGetter):
- bridge/runtime_method.h:
- bridge/runtime_object.cpp:
(JSC::Bindings::RuntimeObject::fallbackObjectGetter):
(JSC::Bindings::RuntimeObject::fieldGetter):
(JSC::Bindings::RuntimeObject::methodGetter):
- bridge/runtime_object.h:
Source/WebKit2:
- WebProcess/Plugins/Netscape/JSNPObject.cpp:
(WebKit::JSNPObject::propertyGetter):
(WebKit::JSNPObject::methodGetter):
- WebProcess/Plugins/Netscape/JSNPObject.h:
- 5:59 PM Changeset in webkit [201702] by
-
- 13 edits in trunk
Deprecate remaining uses of Lookup getStatic*, use HasStaticPropertyTable instead.
https://bugs.webkit.org/show_bug.cgi?id=158178
Reviewed by Darin Adler.
As of bug #158059 most JSC static table property access no longer requires getOwnPropertySlot to be
overridden. Port remaining calls to the getStatic* functions in Lookup.h over to the new mechanism.
Source/JavaScriptCore:
Part 1: Switch JSGlobalObject & JSDOMWindow to use HasStaticPropertyTable.
- runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::getOwnPropertySlot):
- Override is still required for symbol table, but regular property access is now via Base::getOwnPropertySlot.
- runtime/JSGlobalObject.h:
- add HasStaticPropertyTable to structureFlags.
Source/WebCore:
Part 1: Switch JSGlobalObject & JSDOMWindow to use HasStaticPropertyTable.
- bindings/js/JSDOMWindowCustom.cpp:
(WebCore::JSDOMWindow::getOwnPropertySlot):
- getStaticPropertySlot -> Base::getOwnPropertySlot.
- bindings/js/JSPluginElementFunctions.h:
(WebCore::pluginElementCustomGetOwnPropertySlot):
- Switch call from getStaticValueSlot to Type::getOwnPropertySlot. For any element where Type::hasStaticPropertyTable is true the HasStaticPropertyTable structure flag will also be set, so Type::getOwnPropertySlot will do the same thing.
- bindings/scripts/CodeGeneratorJS.pm:
(PrototypeHasStaticPropertyTable):
- Was PrototypeOverridesGetOwnPropertySlot; prototypes now never need override getOwnPropertySlot so renaming accordingly.
(GenerateImplementation):
- Removed generation of getOwnPropertySlot body for DOMGlobalObjects.
(GeneratePrototypeDeclaration):
- For DOMGlobalObjects, set HasStaticPropertyTable instead of OverridesGetOwnPropertySlot & removed getOwnPropertySlot declaration.
(PrototypeOverridesGetOwnPropertySlot): Deleted.
Renamed to PrototypeHasStaticPropertyTable.
- bindings/scripts/test/JS/JSTestGlobalObject.cpp:
- bindings/scripts/test/JS/JSTestGlobalObject.h:
- Updating bindings test results.
LayoutTests:
Switch JSGlobalObject & WebCore DOM instance bindings to use HasStaticPropertyTable.
- fast/dom/unforgeable-attributes-expected.txt:
- Progression, similar to the getOwnPropertyDescriptor test below. Previously we were reporting an error with a message appropriate to a disallowed value->value redefinition. This is actually a disallowed accessor->value reconfiguration, now reporting the correct error message for this.
- http/tests/security/cross-origin-window-property-access-expected.txt:
- Newly reporting previously missing CORS error.
- js/dom/getOwnPropertyDescriptor-expected.txt:
- js/resources/getOwnPropertyDescriptor.js:
- This test was previously incorrect - was expecting window.window property to reflect as a value decriptor. This now reflect as an accesor descriptor. New behaviour is correct per spec & matches Firefox.
- 12:48 PM Changeset in webkit [201701] by
-
- 9 edits2 adds in trunk
Source/WebCore:
Find on page finds too many matches
https://bugs.webkit.org/show_bug.cgi?id=158395
rdar://problem/7440637
Reviewed by Dan Bernstein and Darin Adler.
There is a long standing bug where in some cases WebKit may find non-visible text matches when doing find on page.
For example searching patch review view in bugs.webkit.org returns twice as many matches as there actually are
on the page. This happens because the text content is replicated in an invisible subframe.
Fix by making TextIterator ignore content in non-visible subframes in findPlainText.
Test: editing/text-iterator/count-matches-in-frames.html
- editing/TextIterator.cpp:
(WebCore::nextInPreOrderCrossingShadowBoundaries):
Remove support for an uninteresting assertion.
(WebCore::fullyClipsContents):
Elements without renderer clip their content (except for display:contents).
Test the content rect instead of the size rect for emptiness.
(WebCore::ignoresContainerClip):
(WebCore::pushFullyClippedState):
(WebCore::setUpFullyClippedStack):
(WebCore::isClippedByFrameAncestor):
Test if the frame owner element is clipped in any of the parent frames.
(WebCore::TextIterator::TextIterator):
If the frame is clipped by its ancestors the iterator is initialized to end state.
Clipped frame never renders anything so there is no need to maintain clip stack and traverse.
(WebCore::findPlainText):
Use TextIteratorClipsToFrameAncestors behavior. There might be other places where
this behavior should be used (or perhaps it should be used always?) but limit this to
text search for now.
(WebCore::depthCrossingShadowBoundaries): Deleted.
- editing/TextIterator.h:
- editing/TextIteratorBehavior.h:
Add TextIteratorClipsToFrameAncestors behavior.
- testing/Internals.cpp:
(WebCore::Internals::countMatchesForText):
(WebCore::Internals::countFindMatches):
(WebCore::Internals::numberOfLiveNodes):
- testing/Internals.h:
- testing/Internals.idl:
Testing support
LayoutTests:
TextIterator should ignore non-visible frames in findPlainText
https://bugs.webkit.org/show_bug.cgi?id=158395
Reviewed by Dan Bernstein and Darin Adler.
- editing/text-iterator/count-matches-in-frames-expected.txt: Added.
- editing/text-iterator/count-matches-in-frames.html: Added.
- imported/blink/fast/shapes/shape-outside-floats/shape-outside-negative-height-crash-width.html: Non-rendered whitespace change.
- 12:38 PM Changeset in webkit [201700] by
-
- 2 edits in trunk/Source/WebCore
Do not construct temporary copy of String from AtomicString.
https://bugs.webkit.org/show_bug.cgi?id=158400
Reviewed by Darin Adler.
No new tests needed.
- accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::ariaReadOnlyValue):
- 9:35 AM Changeset in webkit [201699] by
-
- 3 edits in trunk/Source/WebKit/mac
Attempt to fix plug-in hangs by adding back empty slots for the removed messages.
- Plugins/Hosted/WebKitPluginClient.defs:
- Plugins/Hosted/WebKitPluginHost.defs:
- 8:23 AM Changeset in webkit [201698] by
-
- 2 edits in trunk/Source/WebInspectorUI
REGRESSION (r201686): Web Inspector: Fix typo causing an internal error
https://bugs.webkit.org/show_bug.cgi?id=158392
<rdar://problem/26640467>
Reviewed by Joseph Pecoraro.
- UserInterface/Views/HeapAllocationsTimelineOverviewGraph.js:
Fixed typo.
- 8:20 AM Changeset in webkit [201697] by
-
- 2 edits in trunk/Source/WebCore
Give RuleFeatures::classesMatchingAncestors some inline capacity.
<https://webkit.org/b/158356>
Reviewed by Darin Adler.
Avoid 362'000 heap allocations on PLUM (1.3% of all transient fastMallocs) by giving
RuleFeatures::classesMatchingAncestors some inline capacity (32).
This class is only ever allocated on the stack anyway.
- css/RuleFeature.h:
- 7:54 AM Changeset in webkit [201696] by
-
- 9 edits in trunk/Source/WebCore
Unreviewed, rolling out r201693.
Can't fix right now
Reverted changeset:
"Modern IDB: Crash seen in IDBConnectionProxy::putOrAdd on
GuardMalloc bot"
https://bugs.webkit.org/show_bug.cgi?id=158124
http://trac.webkit.org/changeset/201693
- 7:53 AM Changeset in webkit [201695] by
-
- 7 edits in trunk/Source/WebKit2
Unreviewed, rolling out r201694.
201693
Reverted changeset:
"Fix the build after r201693."
https://bugs.webkit.org/show_bug.cgi?id=158394
http://trac.webkit.org/changeset/201694
- 7:45 AM Changeset in webkit [201694] by
-
- 7 edits in trunk/Source/WebKit2
Fix the build after r201693.
https://bugs.webkit.org/show_bug.cgi?id=158394
Reviewed by NOBODY (Build fix).
r201693 landed without the Source/WebKit2 changes, and I didn't have EWS/CQ available to check myself. *sigh*
- NetworkProcess/FileAPI/NetworkBlobRegistry.cpp:
(WebKit::NetworkBlobRegistry::writeBlobsToTemporaryFiles):
- NetworkProcess/FileAPI/NetworkBlobRegistry.h:
- WebProcess/FileAPI/BlobRegistryProxy.cpp:
(WebKit::BlobRegistryProxy::writeBlobsToTemporaryFiles):
- WebProcess/FileAPI/BlobRegistryProxy.h:
- WebProcess/Network/NetworkProcessConnection.cpp:
(WebKit::NetworkProcessConnection::didClose):
(WebKit::NetworkProcessConnection::writeBlobsToTemporaryFiles):
- WebProcess/Network/NetworkProcessConnection.h:
Jun 4, 2016:
- 8:46 PM Changeset in webkit [201693] by
-
- 9 edits in trunk/Source/WebCore
Modern IDB: Crash seen in IDBConnectionProxy::putOrAdd on GuardMalloc bot
https://bugs.webkit.org/show_bug.cgi?id=158124
Reviewed by Darin Adler.
No new tests (Covered by existing test configurations).
- Modules/indexeddb/IDBTransaction.cpp:
(WebCore::IDBTransaction::putOrAddOnServer):
- Modules/indexeddb/client/IDBConnectionProxy.cpp:
(WebCore::IDBClient::IDBConnectionProxy::putOrAdd):
- Modules/indexeddb/client/IDBConnectionProxy.h:
(WebCore::IDBClient::IDBConnectionProxy::callConnectionOnMainThread):
- bindings/js/SerializedScriptValue.cpp:
(WebCore::SerializedScriptValue::writeBlobsToDiskForIndexedDB):
- bindings/js/SerializedScriptValue.h:
- platform/network/BlobRegistry.h:
- platform/network/BlobRegistryImpl.cpp:
(WebCore::BlobRegistryImpl::writeBlobsToTemporaryFiles):
- platform/network/BlobRegistryImpl.h:
- 5:59 PM Changeset in webkit [201692] by
-
- 3 edits in trunk/Source/WebInspectorUI
Web Inspector: add a keyboard shortcut to open the new tab tab
https://bugs.webkit.org/show_bug.cgi?id=158365
<rdar://problem/26631897>
Reviewed by Timothy Hatcher.
Make Cmd-t show the new tab tab if it's not already open and
there is at least one tab type that's not currently in the tab bar.
- UserInterface/Base/Main.js:
(WebInspector.contentLoaded):
(WebInspector._updateNewTabButtonState):
(WebInspector.showNewTabTab):
(WebInspector.isNewTabWithTypeAllowed):
Clean up the code that decides whether we can show the new tab tab.
It is now a special case inside WebInspector.isNewTabWithTypeAllowed.
- UserInterface/Views/NewTabContentView.js:
(WebInspector.NewTabContentView.prototype._updateShownTabs):
Use Array.from.
- 5:36 PM Changeset in webkit [201691] by
-
- 2 edits in trunk/Source/WebCore
REGRESSION (r201474): Should set overflow: hidden on -webkit-media-controls when placeholder is showing
https://bugs.webkit.org/show_bug.cgi?id=158377
Reviewed by Darin Adler.
In r201474, we defer removing the hidden class from inlinePlaybackPlaceholder until
showInlinePlaybackPlaceholderWhenSafe(). We also need to move the code that adds the
placeholder-showing class to -webkit-media-controls to that method.
- Modules/mediacontrols/mediaControlsApple.js:
(Controller.prototype.showInlinePlaybackPlaceholderWhenSafe):
Add the "placeholder-showing" class to -webkit-media-controls when we show the placeholder.
(Controller.prototype.handlePresentationModeChange):
Remove the "placeholder-showing" class from -webkit-media-controls when we hide the
placeholder. Remove the old code that adds and removes that class.
- 4:02 PM Changeset in webkit [201690] by
-
- 3 edits in trunk/Source/WebCore
leaks seen in fast/css/variables tests
https://bugs.webkit.org/show_bug.cgi?id=150728
Reviewed by Anders Carlsson.
Fixes leaks seen running fast/css/variables tests with leak checking turned on.
- css/CSSPrimitiveValue.cpp:
(WebCore::isStringType): Added. For debugging purposes so we catch cases where we
are not treating strings consistently between construction and destruction.
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue): Assert isStringType returns true.
(WebCore::CSSPrimitiveValue::cleanup): Added CSS_DIMENSION and CSS_PARSER_IDENTIFIER
to the list of types that have to decrement the reference count of the string we own.
Both types are passed to the string constructor above.
- css/CSSValueList.cpp:
(WebCore::CSSValueList::buildParserValueListSubstitutingVariables): Restructured the
code so we destroy any CSSParserValue that we don't use. This is needed because of the
peculiar requirements of CSSParserValue: it has a be a struct without a destructor so
it can be used in the CSS grammar, so we have to destroy it explicitly. Ideally we would
minimize any use of it outside the CSSParser itself, but as long as we are using it, we
need to do this explicit destruction.
- 3:48 PM Changeset in webkit [201689] by
-
- 15 edits4 deletes in trunk/Source/WebKit
Remove NPSPI that is no longer used
https://bugs.webkit.org/show_bug.cgi?id=158384
Reviewed by Sam Weinig.
Source/WebKit:
- WebKit.xcodeproj/project.pbxproj:
Source/WebKit/mac:
- Configurations/WebKitLegacy.xcconfig:
- Plugins/Hosted/NetscapePluginHostProxy.mm:
(WKPCCheckIfAllowedToLoadURL): Deleted.
(WKPCCancelCheckIfAllowedToLoadURL): Deleted.
(WKPCResolveURL): Deleted.
- Plugins/Hosted/NetscapePluginInstanceProxy.h:
- Plugins/Hosted/NetscapePluginInstanceProxy.mm:
(WebKit::NetscapePluginInstanceProxy::NetscapePluginInstanceProxy): Deleted.
(WebKit::NetscapePluginInstanceProxy::checkIfAllowedToLoadURL): Deleted.
(WebKit::NetscapePluginInstanceProxy::cancelCheckIfAllowedToLoadURL): Deleted.
(WebKit::NetscapePluginInstanceProxy::checkIfAllowedToLoadURLResult): Deleted.
(WebKit::NetscapePluginInstanceProxy::resolveURL): Deleted.
- Plugins/Hosted/WebHostedNetscapePluginView.h:
- Plugins/Hosted/WebHostedNetscapePluginView.mm:
(-[WebHostedNetscapePluginView _webPluginContainerCancelCheckIfAllowedToLoadRequest:]): Deleted.
(-[WebHostedNetscapePluginView _containerCheckResult:contextInfo:]): Deleted.
- Plugins/Hosted/WebKitPluginClient.defs:
- Plugins/WebBaseNetscapePluginView.h:
- Plugins/WebBaseNetscapePluginView.mm:
(-[WebBaseNetscapePluginView resolvedURLStringForURL:target:]): Deleted.
- Plugins/WebNetscapeContainerCheckContextInfo.h: Removed.
- Plugins/WebNetscapeContainerCheckContextInfo.mm: Removed.
(-[WebNetscapeContainerCheckContextInfo initWithCheckRequestID:callbackFunc:context:]): Deleted.
(-[WebNetscapeContainerCheckContextInfo checkRequestID]): Deleted.
(-[WebNetscapeContainerCheckContextInfo callback]): Deleted.
(-[WebNetscapeContainerCheckContextInfo context]): Deleted.
- Plugins/WebNetscapeContainerCheckPrivate.h: Removed.
- Plugins/WebNetscapeContainerCheckPrivate.mm: Removed.
(browserContainerCheckFuncs): Deleted.
- Plugins/WebNetscapePluginView.h:
- Plugins/WebNetscapePluginView.mm:
(-[WebNetscapePluginView checkIfAllowedToLoadURL:frame:callbackFunc:context:]): Deleted.
(-[WebNetscapePluginView _containerCheckResult:contextInfo:]): Deleted.
(-[WebNetscapePluginView cancelCheckIfAllowedToLoadURL:]): Deleted.
(-[WebNetscapePluginView _webPluginContainerCancelCheckIfAllowedToLoadRequest:]): Deleted.
(-[WebNetscapePluginView fini]): Deleted.
(-[WebNetscapePluginView getVariable:value:]): Deleted.
(-[WebNetscapePluginView resolveURL:forTarget:]): Deleted.
- Plugins/npapi.mm:
(WKN_CheckIfAllowedToLoadURL): Deleted.
(WKN_CancelCheckIfAllowedToLoadURL): Deleted.
(WKN_ResolveURL): Deleted.
- 3:34 PM Changeset in webkit [201688] by
-
- 3 edits in trunk/Source/WebKit/mac
Temporary build fix. (This function is going away).
- Plugins/Hosted/NetscapePluginInstanceProxy.mm:
(WebKit::NetscapePluginInstanceProxy::checkIfAllowedToLoadURLResult): Deleted.
- Plugins/Hosted/WebKitPluginHost.defs:
- 2:28 PM Changeset in webkit [201687] by
-
- 2 edits in trunk/Source/WebCore
32-bit build fix
https://bugs.webkit.org/show_bug.cgi?id=158383
rdar://problem/26628125
Reviewed by Dan Bernstein.
Synthesize the webPlaybackSessionInterfaceMac property.
- platform/mac/WebPlaybackControlsManager.mm:
- 2:09 PM Changeset in webkit [201686] by
-
- 8 edits in trunk/Source/WebInspectorUI
Web Inspector: discontinuous recordings should have discontinuities in the timeline memory graph
https://bugs.webkit.org/show_bug.cgi?id=158052
<rdar://problem/26516695>
Reviewed by Joseph Pecoraro.
Add gaps to the overview and category line charts where discontinuities
exist in the timeline recording.
- UserInterface/Models/Timeline.js:
(WebInspector.Timeline.prototype.recordsInTimeRange):
Replaces_visibleRecordsmethods found in various views.
- UserInterface/Models/TimelineRecording.js:
(WebInspector.TimelineRecording.prototype.reset):
(WebInspector.TimelineRecording.prototype.addDiscontinuity):
(WebInspector.TimelineRecording.prototype.discontinuitiesInTimeRange):
Allow discontinuities to be added to the recording, and have a means to
look up gaps within a time range.
- UserInterface/Views/HeapAllocationsTimelineOverviewGraph.js:
(WebInspector.HeapAllocationsTimelineOverviewGraph.prototype._visibleRecords): Deleted.
Replaced by Timeline helper method.
- UserInterface/Views/MemoryTimelineOverviewGraph.js:
(WebInspector.MemoryTimelineOverviewGraph.prototype.layout.insertDiscontinuity):
(WebInspector.MemoryTimelineOverviewGraph.prototype.layout):
Insert zero-points into the chart at discontinuity boundaries to create
gaps. Data points for records immediately before or after a gap are extended
to the edge of the discontinuity.
(WebInspector.MemoryTimelineOverviewGraph.prototype._visibleRecords): Deleted.
Replaced by Timeline helper method.
- UserInterface/Views/MemoryTimelineView.js:
(WebInspector.MemoryTimelineView.prototype.layout):
Insert zero-points into each category chart at discontinuity boundaries
to create gaps.
Insert zero-points into the chart to create gaps.
(WebInspector.MemoryTimelineView.prototype._visibleRecords): Deleted.
Replaced by Timeline helper method.
- UserInterface/Views/TimelineOverview.js:
(WebInspector.TimelineOverview.prototype.discontinuitiesInTimeRange):
Forward to the TimelineRecording, which isn't exposed to clients.
- UserInterface/Views/TimelineRecordingContentView.js:
(WebInspector.TimelineRecordingContentView):
(WebInspector.TimelineRecordingContentView.prototype._capturingStarted):
(WebInspector.TimelineRecordingContentView.prototype._capturingStopped):
(WebInspector.TimelineRecordingContentView.prototype._recordingReset):
Track discontinuities (recording stop followed by a start) and add them
to the current recording.
- 1:59 PM Changeset in webkit [201685] by
-
- 3 edits2 copies4 adds in trunk/LayoutTests
Modern IDB: Add -private.html variants of crypto/subtle IndexedDB tests.
https://bugs.webkit.org/show_bug.cgi?id=153323
Reviewed by Darin Adler.
- crypto/subtle/resources/rsa-indexeddb-non-exportable.js: Copied from LayoutTests/crypto/subtle/rsa-indexeddb-non-exportable.html.
- crypto/subtle/resources/rsa-indexeddb.js: Copied from LayoutTests/crypto/subtle/rsa-indexeddb.html.
- crypto/subtle/rsa-indexeddb-non-exportable-private-expected.txt: Added.
- crypto/subtle/rsa-indexeddb-non-exportable-private.html: Added.
- crypto/subtle/rsa-indexeddb-non-exportable.html:
- crypto/subtle/rsa-indexeddb-private-expected.txt: Added.
- crypto/subtle/rsa-indexeddb-private.html: Added.
- crypto/subtle/rsa-indexeddb.html:
- 1:53 PM Changeset in webkit [201684] by
-
- 4 edits2 deletes in trunk/Source/WTF
Get rid of WorkItemWin
https://bugs.webkit.org/show_bug.cgi?id=158381
Reviewed by Sam Weinig.
- wtf/PlatformWin.cmake:
- wtf/WorkQueue.h:
- wtf/win/WorkItemWin.cpp: Removed.
(WTF::WorkItemWin::WorkItemWin): Deleted.
(WTF::WorkItemWin::create): Deleted.
(WTF::WorkItemWin::~WorkItemWin): Deleted.
- wtf/win/WorkItemWin.h: Removed.
(WTF::WorkItemWin::function): Deleted.
(WTF::WorkItemWin::queue): Deleted.
- wtf/win/WorkQueueWin.cpp:
(WTF::WorkQueue::performWorkOnRegisteredWorkThread):
(WTF::WorkQueue::dispatch):
- 12:26 PM Changeset in webkit [201683] by
-
- 5 edits in trunk/Source/WTF
Get rid of HANDLE registration code in WorkQueueWin
https://bugs.webkit.org/show_bug.cgi?id=158375
Reviewed by Darin Adler.
- wtf/WorkQueue.h:
- wtf/win/WorkItemWin.cpp:
(WTF::HandleWorkItem::HandleWorkItem): Deleted.
(WTF::HandleWorkItem::createByAdoptingHandle): Deleted.
(WTF::HandleWorkItem::~HandleWorkItem): Deleted.
- wtf/win/WorkItemWin.h:
(WTF::HandleWorkItem::setWaitHandle): Deleted.
(WTF::HandleWorkItem::waitHandle): Deleted.
- wtf/win/WorkQueueWin.cpp:
(WTF::WorkQueue::handleCallback): Deleted.
(WTF::WorkQueue::platformInvalidate): Deleted.
(WTF::WorkQueue::unregisterWaitAndDestroyItemSoon): Deleted.
(WTF::WorkQueue::unregisterWaitAndDestroyItemCallback): Deleted.
- 12:11 PM Changeset in webkit [201682] by
-
- 5 edits in trunk
REGRESSION (r201263): Some tests have become flaky timeouts.
https://bugs.webkit.org/show_bug.cgi?id=157990
Reviewed by Darin Adler.
Tools:
- WebKitTestRunner/TestInvocation.cpp: (WTR::TestInvocation::invoke):
It is somewhat legitimate for WebContent to not respond to messages after the test
is done; it can be e.g. re-doing a costly repaint. So, we should restart is silently,
without making the current test fail.
LayoutTests:
- platform/mac-wk2/TestExpectations:
- platform/mac/TestExpectations:
- 12:10 PM Changeset in webkit [201681] by
-
- 3 edits in trunk/Source/WebCore
Avoid redundant isUndefined() check for parameters that are both optional and nullable in overloads
https://bugs.webkit.org/show_bug.cgi?id=158380
Reviewed by Brady Eidson.
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateParametersCheckExpression):
- bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::jsTestObjPrototypeFunctionOverloadedMethodWithOptionalParameter):
- 11:58 AM Changeset in webkit [201680] by
-
- 3 edits6 adds in trunk
Add better basic isNaN test coverage
https://bugs.webkit.org/show_bug.cgi?id=158379
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-06-04
Reviewed by Benjamin Poulain.
- js/Number-isNaN-expected.txt: Added.
- js/Number-isNaN.html: Added.
- js/global-isNaN-expected.txt: Added.
- js/global-isNaN.html: Added.
- js/script-tests/Number-isNaN.js: Added.
(objectWithNumberValueOf.valueOf):
(objectWithNaNValueOf.valueOf):
(objectRecordConversionCalls.toString):
(objectRecordConversionCalls.valueOf):
- js/script-tests/global-isNaN.js: Added.
(objectConvertToString.toString):
(objectRecordToStringCall.toString):
(objectThrowOnToString.toString):
(objectWithValueOf.valueOf):
(objectThrowOnValueOf.valueOf):
(objectThrowOnValueOf.toString):
(objectRecordValueOfCall.valueOf):
(objectRecordConversionCalls.toString):
(objectRecordConversionCalls.valueOf):
- js/script-tests/math-clz32.js:
- 12:20 AM Changeset in webkit [201679] by
-
- 22 edits64 adds in trunk
CSP: Content Security Policy directive, upgrade-insecure-requests (UIR)
https://bugs.webkit.org/show_bug.cgi?id=143653
<rdar://problem/23032067>
Reviewed by Andy Estes.
Source/WebCore:
Modify our loading logic so that we recognize and upgrade insecure requests to secure
requests if the Content Security Policy directive 'upgrade-insecure-requests' is
present.
Add a static helper function to ContentSecurityPolicy to upgrade insecure URLs so
that we don't have to sprinkle the same code all over the loader system.
Tests: http/tests/security/contentSecurityPolicy/report-only-upgrade-insecure.php
http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/basic-upgrade-cors.https.html
http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/basic-upgrade.https.html
http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/form-upgrade.html
http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/https-header-auxiliary.html
http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/https-header-nested.html
http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/https-header-subresource.html
http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/https-header-top-level.html
http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/iframe-upgrade.https.html
http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/proper-nested-upgrades.html
http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/proper-open-window-upgrades.html
http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/upgrade-insecure-audio-video-in-main-frame.html
http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/upgrade-insecure-css-in-iframe.html
http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/upgrade-insecure-image-in-main-frame.html
http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/upgrade-simple-ws.html
http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/upgrade-insecure-xhr-in-main-frame.html
http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/upgrade-redirect-http-to-https-script-in-iframe.html
http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/upgrade-redirect-https-to-http-script-in-iframe.html
http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/upgrades-mixed-content.html
http/tests/ssl/iframe-upgrade.https.html
http/tests/ssl/upgrade-origin-usage.html
http/tests/websocket/tests/hybi/upgrade-simple-ws.html
- Modules/websockets/WebSocket.cpp:
(WebCore::WebSocket::connect): Upgrade insecure requests if the CSP
indicates we should.
- dom/Document.cpp:
(WebCore::Document::initSecurityContext): Populate new document CSP with sets of upgrade host and port combinations.
- dom/ScriptElement.cpp:
(WebCore::ScriptElement::requestScript): Upgrade insecure requests if
the CSP indicates we should.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::loadResource): Ditto.
- loader/DocumentWriter.cpp:
(WebCore::DocumentWriter::begin): Ditto.
- loader/FormSubmission.cpp:
(WebCore::FormSubmission::create): Ditto.
(WebCore::FormSubmission::populateFrameLoadRequest): Add "Upgrade-Insecure-Requests"
header to frame load requests.
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::addExtraFieldsToMainResourceRequest): Add the
'Update-Insecure-Requests' header field if necessary.
(WebCore::FrameLoader::addHTTPUpgradeInsecureRequestsIfNeeded): Added helper function.
(WebCore::FrameLoader::loadPostRequest): Upgrade insecure requests if the CSP
indicates we should.
(WebCore::FrameLoader::loadResourceSynchronously): Ditto.
(WebCore::FrameLoader::loadDifferentDocumentItem): If loading a form, add the
'Update-Insecure-Requests' header field if necessary.
(WebCore::createWindow): Upgrade insecure requests if the CSP
indicates we should.
- loader/FrameLoader.h:
- loader/PingLoader.cpp:
(WebCore::PingLoader::loadImage): Upgrade insecure requests if the CSP
indicates we should.
(WebCore::PingLoader::sendPing): Ditto.
(WebCore::PingLoader::sendViolationReport): Ditto.
- loader/ResourceLoader.cpp:
(WebCore::ResourceLoader::willSendRequestInternal): Ditto.
- loader/SubframeLoader.cpp:
(WebCore::SubframeLoader::requestFrame): Ditto.
(WebCore::SubframeLoader::requestObject): Ditto.
- loader/appcache/ApplicationCacheHost.cpp:
(WebCore::ApplicationCacheHost::shouldLoadResourceFromApplicationCache): Ditto.
- loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::requestImage): Ditto.
(WebCore::CachedResourceLoader::requestResource): Ditto.
- page/DOMWindow.cpp:
(WebCore::DOMWindow::createWindow): Add the 'Update-Insecure-Requests' header
field if necessary.
- page/csp/ContentSecurityPolicy.cpp:
(WebCore::ContentSecurityPolicy::copyStateFrom): Populate upgraded resource set
from other context.
(WebCore::ContentSecurityPolicy::upgradeInsecureRequestIfNeeded): Added helper function
to upgrade requests when the upgrade-insecure-requests CSP policy is present, or if
the host and port combination have previously been upgraded.
(WebCore::ContentSecurityPolicy::upgradeInsecureNavigationRequestIfNeeded): Added
helper function to upgrade requests that have been previously upgraded. Cross-site
navigations only get upgraded when they have been previously upgraded.
(WebCore::ContentSecurityPolicy::addInsecureNavigationRequestsToUpgrade): Added.
(WebCore::ContentSecurityPolicy::populateInsecureNavigationRequestsToUpgradeFromOther): Added.
- page/csp/ContentSecurityPolicy.h:
(WebCore::ContentSecurityPolicy::setUpgradeInsecureRequests): Added.
(WebCore::ContentSecurityPolicy::upgradeInsecureRequests): Added.
- page/csp/ContentSecurityPolicyDirectiveList.cpp:
(WebCore::ContentSecurityPolicyDirectiveList::ContentSecurityPolicyDirectiveList): Use
more C++11 initializations.
(WebCore::ContentSecurityPolicyDirectiveList::setUpgradeInsecureRequests): Added.
(WebCore::ContentSecurityPolicyDirectiveList::addDirective): Teach this function to
recognize the new directive.
- page/csp/ContentSecurityPolicyDirectiveList.h:
- page/csp/ContentSecurityPolicyDirectiveNames.cpp:
- page/csp/ContentSecurityPolicyDirectiveNames.h:
- platform/network/HTTPHeaderNames.in: Add new 'Upgrade-Insecure-Requests' header field.
- xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::open): Upgrade insecure requests if the CSP if needed.
LayoutTests:
Some of these tests are based on a set of Blink patches by Mike West <mkwst@chromium.org>.
<https://src.chromium.org/viewvc/blink?revision=192607&view=revision>,
<https://codereview.chromium.org/1178093002>, <https://codereview.chromium.org/1964303003>
The rest of them are based on our own mixedContent tests, revised for upgraded requests.
Note that WebSockets are not part of this testing at present due to https://bugs.webkit.org/show_bug.cgi?id=157884.
- http/tests/security/contentSecurityPolicy/report-only-upgrade-insecure.php: Added.
- http/tests/security/contentSecurityPolicy/upgrade-insecure-requests: Added.
- http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/basic-upgrade-cors.https-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/basic-upgrade-cors.https.html: Added.
- http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/basic-upgrade.https-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/basic-upgrade.https.html: Added.
- http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/form-upgrade-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/form-upgrade.html: Added.
- http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/https-header-auxiliary-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/https-header-auxiliary.html: Added.
- http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/https-header-nested-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/https-header-nested.html: Added.
- http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/https-header-subresource-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/https-header-subresource.html: Added.
- http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/https-header-top-level-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/https-header-top-level.html: Added.
- http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/iframe-upgrade.https-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/iframe-upgrade.https.html: Added.
- http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/proper-nested-upgrades-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/proper-nested-upgrades.html: Added.
- http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/proper-open-window-upgrades-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/proper-open-window-upgrades.html: Added.
- http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/resources: Added.
- http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/resources/basic-upgrade-cors.https.html: Added.
- http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/resources/check-https-header.pl: Added.
- http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/resources/echo-https-header.pl: Added.
- http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/resources/frame-with-insecure-audio-video.html: Added.
- http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/resources/frame-with-insecure-css.html: Added.
- http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/resources/frame-with-insecure-image.html: Added.
- http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/resources/frame-with-redirect-http-to-https-script.html: Added.
- http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/resources/frame-with-redirect-https-to-http-script.html: Added.
- http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/resources/insecure-xhr-in-main-frame-window.html: Added.
- http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/resources/mixed-content-with-upgrade.html: Added.
- http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/resources/post-https-header.pl: Added.
- http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/upgrade-insecure-audio-video-in-main-frame-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/upgrade-insecure-audio-video-in-main-frame.html: Added.
- http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/upgrade-insecure-css-in-iframe-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/upgrade-insecure-css-in-iframe.html: Added.
- http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/upgrade-insecure-image-in-main-frame-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/upgrade-insecure-image-in-main-frame.html: Added.
- http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/upgrade-insecure-xhr-in-main-frame-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/upgrade-insecure-xhr-in-main-frame.html: Added.
- http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/upgrade-redirect-http-to-https-script-in-iframe-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/upgrade-redirect-http-to-https-script-in-iframe.html: Added.
- http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/upgrade-redirect-https-to-http-script-in-iframe-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/upgrade-redirect-https-to-http-script-in-iframe.html: Added.
- http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/upgrades-mixed-content-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/upgrades-mixed-content.html: Added.
- http/tests/security/resources/post-origin-to-parent.html: Added.
- http/tests/ssl/iframe-upgrade.https-expected.txt: Added.
- http/tests/ssl/iframe-upgrade.https.html: Added.
- http/tests/ssl/upgrade-origin-usage-expected.txt: Added.
- http/tests/ssl/upgrade-origin-usage.html: Added.
- http/tests/ssl/resources/origin-usage-iframe-1.html: Added.
- http/tests/ssl/resources/origin-usage-iframe-1.manifest: Added.
- http/tests/ssl/resources/origin-usage-iframe-2.html: Added.
- http/tests/ssl/resources/origin-usage-iframe-2.manifest: Added.
- http/tests/websocket/tests/hybi/upgrade-simple-ws-expected.txt: Added.
- http/tests/websocket/tests/hybi/upgrade-simple-ws.html: Added.
- TestExpectations: Skip http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/upgrade-simple-ws.html since the
WebSocket server does not currently support wss sockets.
Jun 3, 2016:
- 8:28 PM Changeset in webkit [201678] by
-
- 2 edits1 add in trunk/Source/JavaScriptCore
Eager FTL failure for strict comparison of NaN with number check
https://bugs.webkit.org/show_bug.cgi?id=158368
Patch by Benjamin Poulain <bpoulain@apple.com> on 2016-06-03
Reviewed by Darin Adler.
DoupleRep with a RealNumberUse starts by handling double
then falls back to Int32 if the unboxed double is NaN.
Before handling integers, the code is checking if the input
is indeed an int32. The problem was that this check failed
to account for NaN as an original input of the DoubleRep.
The call to isNotInt32() filter the doubles checks because
that was handled by the previous block.
The problem is the previous block handles any double except NaN.
If the original input was NaN, the masking by "~SpecFullDouble"
filter that possibility and isNotInt32() fails to test that case.
This patch fixes the issue by changing the filter to SpecDoubleReal.
The type SpecDoubleReal does not include the NaN types.
- ftl/FTLLowerDFGToB3.cpp:
(JSC::FTL::DFG::LowerDFGToB3::compileDoubleRep):
- tests/stress/double-rep-real-number-use-on-nan.js: Added.
To ensure the isNotInt32() does not test anything, we want
proven numbers as input. The (+value) are there to enforce
a ToNumber() which in turn give us a proven Number type.
- 7:04 PM Changeset in webkit [201677] by
-
- 5 edits2 adds in trunk
Bopomofo ruby in Dictionary.app is written horizontally (when it should be written vertically)
https://bugs.webkit.org/show_bug.cgi?id=158245
<rdar://problem/25675318>
Reviewed by Darin Adler.
Source/WebCore:
With orthogonal flows, the inner element gets a logical width that is computed from two values:
- The containing block's available logical height
- The FrameView's visibleHeight
In Dictionary.app, the FrameView's height changes, but this element doesn't get relaid out.
This is because of our optimization where normal-flow elements don't get relaid out if their
parent's width doesn't change (which is the case here).
Therefore, this orthogonal writing mode element should be relaid out when the FrameView changes
size. Luckily, we already have machinery for doing this: percentage heights. In quirks mode, a
div with a percentage height may walk arbitrarily far up the DOM tree in order to determine which
element the percentage should be resolved against. Therefore, we have a map of percentage-sizing-
ancestors to percentage-sizing-descendants which speeds up this search. If a percentage-sizing-
ancestor gets relaid out, all the relevant percentage-sizing-descendants get relaid out too.
Therefore, we can simply mark the FrameView as a percentage-sizing-ancestor and the orthogonal
flow element as a percentage-sizing-descendant. The lifetime of this relationship is already
managed correctly - it gets reset when style changes and when the renderer is destroyed, and
is created during layout.
Unfortunately, this same treatment should also be done to the element which dictates the
containing block's logical height (which caused https://bugs.webkit.org/show_bug.cgi?id=158286).
Implementing this would require giving RenderBox::availableLogicalHeight() a second result
of the necessary element which dictates the return. In an effort to keep this patch small and
focused, I'll do this secondary (much larger) work in a patch on that bug. This patch,
therefore, is kept small and focused.
Test: fast/text/orthogonal-writing-mode-containing-block-frameView-resize-relayout.html
- rendering/RenderBox.cpp:
(WebCore::RenderBox::perpendicularContainingBlockLogicalHeight):
LayoutTests:
Rebaselined fast/table/border-collapsing/004-vertical.html to show a progression.
- fast/text/orthogonal-writing-mode-containing-block-frameView-resize-relayout-expected.html: Added.
- fast/text/orthogonal-writing-mode-containing-block-frameView-resize-relayout.html: Added.
- platform/mac/fast/table/border-collapsing/004-vertical-expected.png: Rebased
- platform/mac/fast/table/border-collapsing/004-vertical-expected.txt: Rebased
- 7:00 PM Changeset in webkit [201676] by
-
- 11 edits4 adds in trunk
Text not visible while external font downloading
https://bugs.webkit.org/show_bug.cgi?id=25207
<rdar://problem/15167413>
Reviewed by Dean Jackson.
Source/WebCore:
I already laid the groundwork for this when implementing the CSS Font Loading API.
We only have to create a timer and correctly respond to it timing out (by setting
state).
This patch also adds a new internal setting which puts us in a mode where font
loads never complete and the timeout occurs immediately. This is so we can test
the fallback behavior.
Test: fast/text/web-font-load-fallback-during-loading.html
- css/CSSFontFace.cpp:
(WebCore::CSSFontFace::CSSFontFace):
(WebCore::CSSFontFace::fontLoadEventOccurred):
(WebCore::CSSFontFace::timeoutFired):
(WebCore::CSSFontFace::setStatus):
(WebCore::CSSFontFace::fontLoaded):
(WebCore::CSSFontFace::webFontsShouldAlwaysFallBack):
(WebCore::CSSFontFace::pump):
(WebCore::CSSFontFace::font):
- css/CSSFontFace.h:
- css/CSSFontFaceSource.cpp:
(WebCore::CSSFontFaceSource::fontLoaded):
- css/FontFace.cpp:
(WebCore::FontFace::fontStateChanged):
- page/Settings.cpp:
(WebCore::Settings::Settings):
(WebCore::Settings::setWebFontsAlwaysFallBack):
- page/Settings.h:
(WebCore::Settings::webFontsAlwaysFallBack):
- testing/InternalSettings.cpp:
(WebCore::InternalSettings::Backup::Backup):
(WebCore::InternalSettings::Backup::restoreTo):
(WebCore::InternalSettings::setWebFontsAlwaysFallBack):
- testing/InternalSettings.h:
- testing/InternalSettings.idl:
LayoutTests:
- fast/text/web-font-load-fallback-during-loading-no-multiple-expected.txt: Added.
- fast/text/web-font-load-fallback-during-loading-no-multiple.html: Added.
- fast/text/web-font-load-fallback-during-loading-expected.html: Added.
- fast/text/web-font-load-fallback-during-loading.html: Added.
- 6:31 PM Changeset in webkit [201675] by
-
- 12 edits in trunk/Source
Modernize a few more lambda captures
https://bugs.webkit.org/show_bug.cgi?id=158370
Reviewed by Brady Eidson.
Source/WebCore:
- workers/DedicatedWorkerGlobalScope.cpp:
(WebCore::DedicatedWorkerGlobalScope::postMessage):
- workers/DedicatedWorkerGlobalScope.h:
- workers/Worker.cpp:
(WebCore::Worker::postMessage):
- workers/Worker.h:
- workers/WorkerEventQueue.cpp:
(WebCore::WorkerEventQueue::enqueueEvent):
- workers/WorkerGlobalScopeProxy.h:
- workers/WorkerMessagingProxy.cpp:
(WebCore::WorkerMessagingProxy::postMessageToWorkerObject):
(WebCore::WorkerMessagingProxy::postMessageToWorkerGlobalScope):
- workers/WorkerMessagingProxy.h:
- workers/WorkerObjectProxy.h:
Source/WebKit:
- Storage/StorageTracker.cpp:
(WebCore::StorageTracker::deleteOrigin):
- 6:08 PM Changeset in webkit [201674] by
-
- 5 edits3 adds in trunk
JSON.stringify replacer function calls with numeric array indices
https://bugs.webkit.org/show_bug.cgi?id=158262
Source/JavaScriptCore:
rdar://problem/26613876
Patch by Benjamin Poulain <bpoulain@apple.com> on 2016-06-03
Reviewed by Saam Barati.
The spec of SerializeJSONArray is pretty clear that the index
should be transformed into a string before calling SerializeJSONProperty.
See http://www.ecma-international.org/ecma-262/6.0/#sec-serializejsonarray
- runtime/JSONObject.cpp:
(JSC::PropertyNameForFunctionCall::value):
LayoutTests:
Patch by Benjamin Poulain <bpoulain@apple.com> on 2016-06-03
Reviewed by Saam Barati.
- js/JSON-stringify-exposes-array-indices-as-strings-expected.txt: Added.
- js/JSON-stringify-exposes-array-indices-as-strings.html: Added.
- js/script-tests/JSON-stringify-exposes-array-indices-as-strings.js: Added.
(replacer):
(testObject.toJSON):
(toJSONArrayHelper):
- js/resources/JSON-stringify.js:
- js/dom/JSON-stringify-expected.txt:
Update the test results for the native implementation.
- 5:56 PM Changeset in webkit [201673] by
-
- 55 edits1 move in trunk/Source
Unreviewed, rolling out r201663.
https://bugs.webkit.org/show_bug.cgi?id=158374
Broke the Windows build (Requested by andersca on #webkit).
Reverted changeset:
"Rename NoncopyableFunction to Function"
https://bugs.webkit.org/show_bug.cgi?id=158354
http://trac.webkit.org/changeset/201663
- 5:34 PM Changeset in webkit [201672] by
-
- 3 edits in trunk/Source/JavaScriptCore
Proxy.ownKeys should no longer throw an exception when duplicate keys are returned and the target is non-extensible
https://bugs.webkit.org/show_bug.cgi?id=158350
<rdar://problem/26626211>
Reviewed by Michael Saboff.
The spec was recently changes in Proxy OwnPropertyKeys
to allow for duplicate property names under certain circumstances.
This patch fixes our implementation to match the spec.
See: https://github.com/tc39/ecma262/pull/594
- runtime/ProxyObject.cpp:
(JSC::ProxyObject::performGetOwnPropertyNames):
- tests/stress/proxy-own-keys.js:
(i.catch):
(ownKeys):
(assert):
- 5:04 PM Changeset in webkit [201671] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: add a keyboard shortcut to close the current tab bar item
https://bugs.webkit.org/show_bug.cgi?id=158363
<rdar://problem/22677254>
Reviewed by Timothy Hatcher.
Make Cmd-w close the current tab. This matches Safari's keyboard shortcut.
- UserInterface/Views/TabBrowser.js:
(WebInspector.TabBrowser):
Don't do anything if the New Tab tab is the only tab bar item besides the
pinned "new tab" button.
- 4:51 PM Changeset in webkit [201670] by
-
- 2 edits in trunk/Source/JavaScriptCore
Some shadow chicken code is wrong when run on a big endian CPU
https://bugs.webkit.org/show_bug.cgi?id=158361
Reviewed by Mark Lam.
This code was wrong on a big endian CPU, and it was
also an anti-pattern in the file. The code was harmless
on a little endian CPU, but it's better to remove it.
- llint/LowLevelInterpreter64.asm:
- 4:27 PM Changeset in webkit [201669] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: setter for debugging flag InspectorBackend.dumpInspectorTimeStats does not work
https://bugs.webkit.org/show_bug.cgi?id=158366
Reviewed by Timothy Hatcher.
- UserInterface/Protocol/InspectorBackend.js:
(InspectorBackendClass.prototype.set dumpInspectorTimeStats):
Actually update the backing member when the setter is called.
- 4:06 PM Changeset in webkit [201668] by
-
- 26 edits1 add in trunk/Source/JavaScriptCore
Add argument_count bytecode for concat
https://bugs.webkit.org/show_bug.cgi?id=158358
Reviewed by Geoffrey Garen.
This patch adds a new argument count bytecode. Normally, we would
just make sure that the argument.length bytecode was fast enough
that we shouldn't need such an bytecode. However, for the case of
Array.prototype.concat the overhead of the arguments object
allocation in the LLInt was too high and caused regressions.
- bytecode/BytecodeIntrinsicRegistry.h:
- bytecode/BytecodeList.json:
- bytecode/BytecodeUseDef.h:
(JSC::computeUsesForBytecodeOffset):
(JSC::computeDefsForBytecodeOffset):
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::dumpBytecode):
- bytecompiler/NodesCodegen.cpp:
(JSC::BytecodeIntrinsicNode::emit_intrinsic_argumentCount):
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::getArgumentCount):
(JSC::DFG::ByteCodeParser::parseBlock):
- dfg/DFGCapabilities.cpp:
(JSC::DFG::capabilityLevel):
- jit/JIT.cpp:
(JSC::JIT::privateCompileMainPass):
- jit/JIT.h:
- jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_argument_count):
- llint/LowLevelInterpreter32_64.asm:
- llint/LowLevelInterpreter64.asm:
- tests/stress/argument-count-bytecode.js: Added.
(inlineCount):
(inlineCount1):
(inlineCount2):
(inlineCountVarArgs):
(assert):
- 4:01 PM Changeset in webkit [201667] by
-
- 7 edits2 adds in trunk
Crash under VisibleSelection::firstRange()
https://bugs.webkit.org/show_bug.cgi?id=158241
Reviewed by Enrica Casucci.
Source/WebCore:
The crash was commonly caused by parentAnchoredEquivalent returning null when the anchored node was a shadow root.
Fixed it by returning a shadow root in parentAnchoredEquivalent.
Also guard against other kinds of crashes by adding a null check in VisibleSelection::firstRange() since we've seen
a crash in the same code path outside of a shadow tree.
This patch also fixes other Position methods to stop using nonShadowBoundaryParentNode in place of parentNode as
that would cause a similar crash and/or a bug elsewhere.
Test: fast/shadow-dom/selection-at-shadow-root-crash.html
- accessibility/AXObjectCache.cpp:
(AXObjectCache::startCharacterOffsetOfParagraph): Fixed a bug uncovered by the assertion fix in Position::Position.
This code was sometimes creating a position inside a BR, which is wrong.
(AXObjectCache::endCharacterOffsetOfParagraph): Ditto.
- dom/Position.cpp:
(WebCore::Position::Position): Fixed an assertion which was checking that this constructor wasn't being called
with m_anchorNode set to an element editing ignores content of. ing it with isShadowRoot() made this assertion useless because it's true whenever m_anchorNode is not a shadow root.
(WebCore::Position::containerNode): Use parentNode() instead of findParent() which calls nonShadowBoundaryParentNode
since Position should
(WebCore::Position::parentAnchoredEquivalent): Fixed the bug by letting this function return a shadow root.
(WebCore::Position::previous): Use parentNode() instead of findParent().
(WebCore::Position::next): Ditto.
(WebCore::Position::atStartOfTree): Ditto.
(WebCore::Position::atEndOfTree): Ditto.
(WebCore::Position::findParent): Deleted.
- dom/Position.h:
- editing/VisibleSelection.cpp:
(VisibleSelection::firstRange): Added a null check.
LayoutTests:
Added a regression test.
- fast/shadow-dom/selection-at-shadow-root-crash-expected.txt: Added.
- fast/shadow-dom/selection-at-shadow-root-crash.html: Added.
- 3:47 PM Changeset in webkit [201666] by
-
- 3 edits2 adds in trunk
Incorrect rendering on boostmobile FAQ page
https://bugs.webkit.org/show_bug.cgi?id=158303
<rdar://problem/26603462>
Reviewed by Chris Dumez.
Initial value for background-color is 'transparent'. see https://drafts.csswg.org/css-backgrounds-3/#background-color
Source/WebCore:
Test: fast/selectors/non-visited-link-backround-color.html
- css/CSSPropertyNames.in:
LayoutTests:
- fast/selectors/non-visited-link-backround-color-expected.html: Added.
- fast/selectors/non-visited-link-backround-color.html: Added.
- 3:31 PM Changeset in webkit [201665] by
-
- 8 edits in trunk/Source/WebCore
More miscellaneous IDBBindingUtilities cleanup.
https://bugs.webkit.org/show_bug.cgi?id=158359
Reviewed by Tim Horton.
No new tests (Straight refactor, yo).
Replace more ScriptExecutionContext&s with ExecState&s.
Combine more unnecessarily separate functions.
Remove some cruft.
- Modules/indexeddb/IDBCursor.cpp:
(WebCore::IDBCursor::setGetResult):
- Modules/indexeddb/IDBRequest.cpp:
(WebCore::IDBRequest::setResult):
(WebCore::IDBRequest::setResultToStructuredClone):
- Modules/indexeddb/server/MemoryObjectStore.cpp:
(WebCore::IDBServer::MemoryObjectStore::updateIndexesForPutRecord):
(WebCore::IDBServer::MemoryObjectStore::populateIndexWithExistingRecords):
- Modules/indexeddb/server/SQLiteIDBBackingStore.cpp:
(WebCore::IDBServer::SQLiteIDBBackingStore::updateOneIndexForAddRecord):
(WebCore::IDBServer::SQLiteIDBBackingStore::updateAllIndexesForAddRecord):
- Modules/indexeddb/server/UniqueIDBDatabase.cpp:
(WebCore::IDBServer::UniqueIDBDatabase::performPutOrAdd):
- bindings/js/IDBBindingUtilities.cpp:
(WebCore::deserializeIDBValueToJSValue):
(WebCore::idbKeyDataToScriptValue):
(WebCore::deserializeIDBValueDataToJSValue): Deleted.
- bindings/js/IDBBindingUtilities.h:
- 3:26 PM Changeset in webkit [201664] by
-
- 10 edits in trunk
CanvasRenderingContext2D.createPattern() / putImageData() throw wrong exception type
https://bugs.webkit.org/show_bug.cgi?id=158322
Reviewed by Ryosuke Niwa.
LayoutTests/imported/w3c:
Rebaseline test now that it is passing.
- canvas/2d.pattern.image.undefined-expected.txt:
Source/WebCore:
CanvasRenderingContext2D.createPattern() / putImageData() were throwing the wrong
exception type when the first parameter was null. It should throw a TypeError
but it was throwing a legacy TYPE_MISMATCH_ERR:
- http://www.w3.org/TR/2dcontext/#canvasrenderingcontext2d
- http://www.w3.org/TR/2dcontext/#canvasimagesource
This patch aligns our behavior with the specification.
No new tests, covered by existing tests.
- html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::createPattern):
(WebCore::CanvasRenderingContext2D::putImageData):
(WebCore::CanvasRenderingContext2D::webkitPutImageDataHD):
(WebCore::CanvasRenderingContext2D::didDraw): Deleted.
(WebCore::CanvasRenderingContext2D::drawFocusIfNeeded): Deleted.
(WebCore::CanvasRenderingContext2D::drawFocusIfNeededInternal): Deleted.
(WebCore::CanvasRenderingContext2D::font): Deleted.
- html/canvas/CanvasRenderingContext2D.h:
- html/canvas/CanvasRenderingContext2D.idl:
LayoutTests:
Update several outdated layout tests.
- canvas/philip/tests/2d.imageData.put.null.html:
- canvas/philip/tests/2d.pattern.image.null.html:
- canvas/philip/tests/2d.pattern.image.undefined.html:
- 3:24 PM Changeset in webkit [201663] by
-
- 55 edits1 move in trunk/Source
Rename NoncopyableFunction to Function
https://bugs.webkit.org/show_bug.cgi?id=158354
Reviewed by Chris Dumez.
Source/WebCore:
- Modules/mediastream/MediaEndpointPeerConnection.cpp:
(WebCore::MediaEndpointPeerConnection::runTask):
- Modules/mediastream/MediaEndpointPeerConnection.h:
- Modules/webaudio/AudioDestinationNode.h:
(WebCore::AudioDestinationNode::resume):
(WebCore::AudioDestinationNode::suspend):
(WebCore::AudioDestinationNode::close):
- Modules/webaudio/DefaultAudioDestinationNode.cpp:
(WebCore::DefaultAudioDestinationNode::resume):
(WebCore::DefaultAudioDestinationNode::suspend):
(WebCore::DefaultAudioDestinationNode::close):
- Modules/webaudio/DefaultAudioDestinationNode.h:
- dom/ActiveDOMCallbackMicrotask.cpp:
(WebCore::ActiveDOMCallbackMicrotask::ActiveDOMCallbackMicrotask):
- dom/ActiveDOMCallbackMicrotask.h:
- dom/ScriptExecutionContext.h:
(WebCore::ScriptExecutionContext::Task::Task):
- fileapi/AsyncFileStream.cpp:
(WebCore::callOnFileThread):
(WebCore::AsyncFileStream::perform):
- fileapi/AsyncFileStream.h:
- page/FrameView.cpp:
(WebCore::FrameView::queuePostLayoutCallback):
(WebCore::FrameView::flushPostLayoutTasksQueue):
- page/FrameView.h:
- page/scrolling/ScrollingThread.cpp:
(WebCore::ScrollingThread::dispatch):
(WebCore::ScrollingThread::dispatchBarrier):
(WebCore::ScrollingThread::dispatchFunctionsFromScrollingThread):
- page/scrolling/ScrollingThread.h:
- platform/GenericTaskQueue.cpp:
(WebCore::TaskDispatcher<Timer>::postTask):
- platform/GenericTaskQueue.h:
(WebCore::TaskDispatcher::postTask):
- platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.h:
- platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm:
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::scheduleDeferredTask):
- platform/mediastream/MediaStreamPrivate.cpp:
(WebCore::MediaStreamPrivate::scheduleDeferredTask):
- platform/mediastream/MediaStreamPrivate.h:
- platform/mediastream/mac/AVMediaCaptureSource.h:
- platform/mediastream/mac/AVMediaCaptureSource.mm:
(WebCore::AVMediaCaptureSource::scheduleDeferredTask):
- style/StyleTreeResolver.cpp:
(WebCore::Style::postResolutionCallbackQueue):
(WebCore::Style::queuePostResolutionCallback):
- style/StyleTreeResolver.h:
Source/WebKit:
- Storage/StorageSyncManager.cpp:
(WebCore::StorageSyncManager::dispatch):
- Storage/StorageSyncManager.h:
- Storage/StorageThread.cpp:
(WebCore::StorageThread::dispatch):
(WebCore::StorageThread::terminate):
- Storage/StorageThread.h:
Source/WebKit2:
- NetworkProcess/NetworkProcess.cpp:
(WebKit::fetchDiskCacheEntries):
(WebKit::NetworkProcess::fetchWebsiteData):
(WebKit::clearDiskCacheEntries):
- NetworkProcess/NetworkProcess.h:
- NetworkProcess/cache/NetworkCache.cpp:
(WebKit::NetworkCache::Cache::traverse):
- NetworkProcess/cache/NetworkCache.h:
- NetworkProcess/cache/NetworkCacheIOChannelSoup.cpp:
(WebKit::NetworkCache::runTaskInQueue):
- NetworkProcess/cache/NetworkCacheStorage.h:
Source/WTF:
- WTF.xcodeproj/project.pbxproj:
- wtf/CrossThreadTask.h:
(WTF::CrossThreadTask::CrossThreadTask):
- wtf/Function.h: Renamed from Source/WTF/wtf/NoncopyableFunction.h.
- wtf/FunctionDispatcher.h:
- wtf/MainThread.cpp:
(WTF::functionQueue):
(WTF::dispatchFunctionsFromMainThread):
(WTF::callOnMainThread):
- wtf/MainThread.h:
- wtf/RunLoop.cpp:
(WTF::RunLoop::performWork):
(WTF::RunLoop::dispatch):
- wtf/RunLoop.h:
- wtf/WorkQueue.h:
- wtf/cocoa/WorkQueueCocoa.cpp:
(WTF::WorkQueue::dispatch):
(WTF::WorkQueue::dispatchAfter):
- wtf/efl/DispatchQueueWorkItemEfl.h:
(WorkItem::WorkItem):
(TimerWorkItem::create):
(TimerWorkItem::TimerWorkItem):
- wtf/efl/WorkQueueEfl.cpp:
(WTF::WorkQueue::dispatch):
(WTF::WorkQueue::dispatchAfter):
- wtf/generic/RunLoopGeneric.cpp:
(WTF::RunLoop::TimerBase::ScheduledTask::create):
(WTF::RunLoop::TimerBase::ScheduledTask::ScheduledTask):
(WTF::RunLoop::dispatchAfter):
- wtf/generic/WorkQueueGeneric.cpp:
(WorkQueue::dispatch):
(WorkQueue::dispatchAfter):
- wtf/glib/RunLoopGLib.cpp:
(WTF::DispatchAfterContext::DispatchAfterContext):
(WTF::RunLoop::dispatchAfter):
- wtf/win/WorkItemWin.cpp:
(WTF::WorkItemWin::WorkItemWin):
(WTF::WorkItemWin::create):
(WTF::HandleWorkItem::HandleWorkItem):
(WTF::HandleWorkItem::createByAdoptingHandle):
- wtf/win/WorkItemWin.h:
(WTF::WorkItemWin::function):
- wtf/win/WorkQueueWin.cpp:
(WTF::WorkQueue::dispatch):
(WTF::WorkQueue::dispatchAfter):
- 3:05 PM Changeset in webkit [201662] by
-
- 3 edits in trunk/LayoutTests
Marking fast/scrolling/scroll-container-horizontally.html as flaky on mac-wk2 and ios-simulator-wk1
https://bugs.webkit.org/show_bug.cgi?id=158237
Unreviewed test gardening.
- platform/ios-simulator-wk1/TestExpectations:
- platform/mac-wk2/TestExpectations:
- 2:59 PM Changeset in webkit [201661] by
-
- 2 edits in trunk/Source/WebCore
REGRESSION(r201474): Subtitles are not resizing in other fullscreen modes
https://bugs.webkit.org/show_bug.cgi?id=158355
Reviewed by Eric Carlson.
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::syncTextTrackBounds):
Set the text track representation layer's frame based on the active video layer.
- 2:42 PM Changeset in webkit [201660] by
-
- 10 edits in trunk/Source/WebCore
Miscellaneous IDBBindingUtilities cleanup.
https://bugs.webkit.org/show_bug.cgi?id=158353
Reviewed by Tim Horton.
No new tests (Straight refactor, yo).
Starting with removing a single form of scriptValueToIDBKey(), and making the return value be
Ref<IDBKey> instead of RefPtr<IDBKey>, update a whole bunch of code to understand that the ExecState
is non-null and the resulting key is non-null.
- Modules/indexeddb/IDBCursor.cpp:
(WebCore::IDBCursor::continueFunction):
- Modules/indexeddb/IDBFactory.cpp:
(WebCore::IDBFactory::cmp):
- Modules/indexeddb/IDBIndex.cpp:
(WebCore::IDBIndex::count):
(WebCore::IDBIndex::get):
(WebCore::IDBIndex::getKey):
- Modules/indexeddb/IDBKey.cpp:
(WebCore::IDBKey::compare):
(WebCore::IDBKey::isLessThan):
(WebCore::IDBKey::isEqual):
- Modules/indexeddb/IDBKey.h:
(WebCore::IDBKey::createMultiEntryArray):
- Modules/indexeddb/IDBKeyRange.cpp:
(WebCore::IDBKeyRange::only):
(WebCore::IDBKeyRange::lowerBound):
(WebCore::IDBKeyRange::upperBound):
(WebCore::IDBKeyRange::bound):
(WebCore::IDBKeyRange::isOnlyKey):
- Modules/indexeddb/IDBObjectStore.cpp:
(WebCore::IDBObjectStore::get):
(WebCore::IDBObjectStore::modernDelete):
(WebCore::IDBObjectStore::count):
- bindings/js/IDBBindingUtilities.cpp:
(WebCore::get):
(WebCore::set):
(WebCore::createIDBKeyFromValue):
(WebCore::getNthValueOnKeyPath):
(WebCore::internalCreateIDBKeyFromScriptValueAndKeyPath):
(WebCore::ensureNthValueOnKeyPath):
(WebCore::canInjectNthValueOnKeyPath):
(WebCore::injectIDBKeyIntoScriptValue):
(WebCore::maybeCreateIDBKeyFromScriptValueAndKeyPath):
(WebCore::canInjectIDBKeyIntoScriptValue):
(WebCore::deserializeIDBValueToJSValue):
(WebCore::scriptValueToIDBKey):
(WebCore::createKeyPathArray):
- bindings/js/IDBBindingUtilities.h:
- 2:36 PM Changeset in webkit [201659] by
-
- 8 edits2 moves in trunk/Source/WebCore
Rename CheckedRadioButtons into RadioButtonGroups
https://bugs.webkit.org/show_bug.cgi?id=158326
Reviewed by Alex Christensen.
CheckedRadioButtons handles the set of all the Radio Button Groups
for a particular form or document.
The name is wrong and apparently comes from former uses of this class
(see the comment above the class declaration).
This patch renames "CheckedRadioButtons" to "RadioButtonGroups" to reflect that it handles
all the Radio Button Group from a given context (form or document).
Internally it has a set of RadioButtonGroup but that is never explicitely
exposed.
- CMakeLists.txt:
- WebCore.xcodeproj/project.pbxproj:
- dom/CheckedRadioButtons.cpp:
(WebCore::RadioButtonGroup::isEmpty): Deleted.
(WebCore::RadioButtonGroup::isRequired): Deleted.
(WebCore::RadioButtonGroup::checkedButton): Deleted.
(WebCore::RadioButtonGroup::RadioButtonGroup): Deleted.
(WebCore::RadioButtonGroup::isValid): Deleted.
(WebCore::RadioButtonGroup::members): Deleted.
(WebCore::RadioButtonGroup::setCheckedButton): Deleted.
(WebCore::RadioButtonGroup::add): Deleted.
(WebCore::RadioButtonGroup::updateCheckedState): Deleted.
(WebCore::RadioButtonGroup::requiredAttributeChanged): Deleted.
(WebCore::RadioButtonGroup::remove): Deleted.
(WebCore::RadioButtonGroup::updateValidityForAllButtons): Deleted.
(WebCore::RadioButtonGroup::contains): Deleted.
(WebCore::CheckedRadioButtons::CheckedRadioButtons): Deleted.
(WebCore::CheckedRadioButtons::~CheckedRadioButtons): Deleted.
(WebCore::CheckedRadioButtons::addButton): Deleted.
(WebCore::CheckedRadioButtons::groupMembers): Deleted.
(WebCore::CheckedRadioButtons::updateCheckedState): Deleted.
(WebCore::CheckedRadioButtons::requiredAttributeChanged): Deleted.
(WebCore::CheckedRadioButtons::checkedButtonForGroup): Deleted.
(WebCore::CheckedRadioButtons::isInRequiredGroup): Deleted.
(WebCore::CheckedRadioButtons::removeButton): Deleted.
- dom/RadioButtonGroups.cpp: Renamed from Source/WebCore/dom/CheckedRadioButtons.cpp.
(WebCore::RadioButtonGroup::isEmpty):
(WebCore::RadioButtonGroup::isRequired):
(WebCore::RadioButtonGroup::checkedButton):
(WebCore::RadioButtonGroup::RadioButtonGroup):
(WebCore::RadioButtonGroup::isValid):
(WebCore::RadioButtonGroup::members):
(WebCore::RadioButtonGroup::setCheckedButton):
(WebCore::RadioButtonGroup::add):
(WebCore::RadioButtonGroup::updateCheckedState):
(WebCore::RadioButtonGroup::requiredAttributeChanged):
(WebCore::RadioButtonGroup::remove):
(WebCore::RadioButtonGroup::updateValidityForAllButtons):
(WebCore::RadioButtonGroup::contains):
(WebCore::RadioButtonGroups::RadioButtonGroups):
(WebCore::RadioButtonGroups::~RadioButtonGroups):
(WebCore::RadioButtonGroups::addButton):
(WebCore::RadioButtonGroups::groupMembers):
(WebCore::RadioButtonGroups::updateCheckedState):
(WebCore::RadioButtonGroups::requiredAttributeChanged):
(WebCore::RadioButtonGroups::checkedButtonForGroup):
(WebCore::RadioButtonGroups::isInRequiredGroup):
(WebCore::RadioButtonGroups::removeButton):
- dom/RadioButtonGroups.h: Renamed from Source/WebCore/dom/CheckedRadioButtons.h.
- html/FormController.h:
(WebCore::FormController::radioButtonGroups):
(WebCore::FormController::checkedRadioButtons): Deleted.
- html/HTMLFormElement.h:
- html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::~HTMLInputElement):
(WebCore::HTMLInputElement::setChecked):
(WebCore::HTMLInputElement::didMoveToNewDocument):
(WebCore::HTMLInputElement::requiredAttributeChanged):
(WebCore::HTMLInputElement::isInRequiredRadioButtonGroup):
(WebCore::HTMLInputElement::radioButtonGroup):
(WebCore::HTMLInputElement::checkedRadioButtonForGroup):
(WebCore::HTMLInputElement::radioButtonGroups):
(WebCore::HTMLInputElement::addToRadioButtonGroup):
(WebCore::HTMLInputElement::removeFromRadioButtonGroup):
(WebCore::HTMLInputElement::checkedRadioButtons): Deleted.
- html/HTMLInputElement.h:
- 2:35 PM Changeset in webkit [201658] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Remove unused WebInspector.CSSCompletions methods
https://bugs.webkit.org/show_bug.cgi?id=158352
Reviewed by Joseph Pecoraro.
- UserInterface/Models/CSSCompletions.js:
(WebInspector.CSSCompletions.prototype.firstStartsWith): Deleted.
(WebInspector.CSSCompletions.prototype.isLonghandPropertyName): Deleted.
(WebInspector.CSSCompletions.prototype.longhandsForShorthand): Deleted.
- 2:26 PM Changeset in webkit [201657] by
-
- 4 edits in trunk/Source/JavaScriptCore
Clients of PolymorphicAccess::addCases shouldn't have to malloc
https://bugs.webkit.org/show_bug.cgi?id=158357
Reviewed by Keith Miller.
We only ever have 1 or 2 cases, so we can use inline Vector capacity.
This shows up a little in the JSBench profile.
- bytecode/PolymorphicAccess.cpp:
(JSC::PolymorphicAccess::addCases):
(JSC::PolymorphicAccess::addCase):
- bytecode/PolymorphicAccess.h:
- bytecode/StructureStubInfo.cpp:
(JSC::StructureStubInfo::addAccessCase):
- 2:13 PM Changeset in webkit [201656] by
-
- 6 edits in trunk/Source/JavaScriptCore
Fix some more INFINITI->INFINITY typos
Unreviewed.
The tests were not covering the edge cases they were supposed to test.
Patch by Benjamin Poulain <bpoulain@apple.com> on 2016-06-03
- tests/stress/math-ceil-basics.js:
(testMathCeilOnConstants):
- tests/stress/math-clz32-basics.js:
(testMathClz32OnDoubles):
(testMathClz32OnConstants):
- tests/stress/math-floor-basics.js:
(testMathFloorOnConstants):
- tests/stress/math-round-basics.js:
(testMathRoundOnConstants):
- tests/stress/math-trunc-basics.js:
(testMathTruncOnConstants):
- 1:59 PM Changeset in webkit [201655] by
-
- 14 edits in trunk/Source
Unreviewed, roll out r196633 as it broke PageCache on iOS for WebKit.org
<rdar://problem/26521101>
Source/WebCore:
- dom/Document.cpp:
(WebCore::Document::setInPageCache): Deleted.
- history/CachedPage.cpp:
(WebCore::CachedPage::restore):
(WebCore::CachedPage::clear):
- history/CachedPage.h:
(WebCore::CachedPage::markForVisitedLinkStyleRecalc):
(WebCore::CachedPage::markForFullStyleRecalc):
- history/PageCache.cpp:
(WebCore::PageCache::markPagesForVisitedLinkStyleRecalc):
(WebCore::PageCache::markPagesForFullStyleRecalc):
- history/PageCache.h:
- page/Frame.cpp:
(WebCore::Frame::setPageAndTextZoomFactors):
- page/Page.cpp:
(WebCore::Page::setViewScaleFactor):
(WebCore::Page::setDeviceScaleFactor):
(WebCore::Page::setPagination):
(WebCore::Page::setPaginationLineGridEnabled):
(WebCore::Page::setVisitedLinkStore):
Source/WebKit/mac:
- WebCoreSupport/WebVisitedLinkStore.mm:
(WebVisitedLinkStore::removeAllVisitedLinks):
(WebVisitedLinkStore::removeVisitedLink):
(WebVisitedLinkStore::addVisitedLinkHash):
Source/WebKit/win:
- WebCoreSupport/WebVisitedLinkStore.cpp:
(WebVisitedLinkStore::removeAllVisitedLinks):
(WebVisitedLinkStore::addVisitedLinkHash):
Source/WebKit2:
- WebProcess/WebPage/VisitedLinkTableController.cpp:
(WebKit::VisitedLinkTableController::setVisitedLinkTable):
(WebKit::VisitedLinkTableController::visitedLinkStateChanged):
(WebKit::VisitedLinkTableController::allVisitedLinkStateChanged):
(WebKit::VisitedLinkTableController::removeAllVisitedLinks):
- 1:12 PM Changeset in webkit [201654] by
-
- 6 edits in trunk/Source/JavaScriptCore
JSGlobalObject::addFunction should call deleteProperty rather than removeDirect
https://bugs.webkit.org/show_bug.cgi?id=158295
Reviewed by Saam Barati.
When a function in declared in program code, this replaces any previosly existing
property from the global object. JSGlobalObject::addFunction is currently calling
removeDirect rather than deleteProperty to remove the existing property. This fails
to remove any properties from static tables.
We currently get away with this because (a) JSObject & JSGlobalObject don't currently
have any properties in static tables, and (b) the current quirky property precedence
means that the symbol table properties end up taking precedence over JSDOMWindow's
static table, so window object properties end up being shadowed.
As a part of bug #158178 the precedence of static tables will change, requiring this
to be fixed.
The deleteProperty function does what we want (has the ability to remove properties,
including those from the static tables). Normally deleteProperty will not remove
properties that are non-configurable (DontDelete) - we need to do so. The function
does already support this, through a flag on VM named 'isInDefineOwnProperty', which
causes configurability to be ignored. Generalize this mechanism for use outside of
defineOwnProperty, renaming & moving DefineOwnPropertyScope helper class out to VM.
- runtime/JSFunction.cpp:
(JSC::JSFunction::deleteProperty):
- isInDefineOwnProperty -> deletePropertyMode.
- runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::addFunction):
- removeDirect -> deleteProperty.
- runtime/JSObject.cpp:
(JSC::JSObject::deleteProperty):
- isInDefineOwnProperty -> deletePropertyMode.
(JSC::JSObject::defineOwnNonIndexProperty):
- DefineOwnPropertyScope -> VM::DeletePropertyModeScope.
(JSC::DefineOwnPropertyScope::DefineOwnPropertyScope): Deleted.
(JSC::DefineOwnPropertyScope::~DefineOwnPropertyScope): Deleted.
- DefineOwnPropertyScope -> VM::DeletePropertyModeScope.
- runtime/VM.cpp:
(JSC::VM::VM):
- removed m_inDefineOwnProperty.
- runtime/VM.h:
(JSC::VM::deletePropertyMode):
- isInDefineOwnProperty -> deletePropertyMode.
(JSC::VM::DeletePropertyModeScope::DeletePropertyModeScope):
(JSC::VM::DeletePropertyModeScope::~DeletePropertyModeScope):
- DefineOwnPropertyScope -> VM::DeletePropertyModeScope.
(JSC::VM::setInDefineOwnProperty): Deleted.
- Replaced with deletePropertyMode, can now only be set via VM::DeletePropertyModeScope.
(JSC::VM::isInDefineOwnProperty): Deleted.
- isInDefineOwnProperty -> deletePropertyMode.
- 12:54 PM Changeset in webkit [201653] by
-
- 2 edits in trunk/LayoutTests
LayoutTest imported/w3c/indexeddb/idbcursor-advance-continue-async.htm is flaky on Yosemite WK2
https://bugs.webkit.org/show_bug.cgi?id=154606
Reviewed by Alex Christensen.
- platform/mac-wk2/TestExpectations: Remove expectations. Test has been working great for quite awhile.
- 12:28 PM Changeset in webkit [201652] by
-
- 5 edits in trunk/LayoutTests
storage/indexeddb/intversion-open-in-upgradeneeded.html is flaky on mac.
https://bugs.webkit.org/show_bug.cgi?id=155050
Reviewed by Alex Christensen.
The test no longer crashes/times out, but it does have text failures.
Resolve them by removing a race in the test itself.
- platform/mac-wk2/TestExpectations:
- storage/indexeddb/intversion-open-in-upgradeneeded-expected.txt:
- storage/indexeddb/intversion-open-in-upgradeneeded-private-expected.txt:
- storage/indexeddb/resources/intversion-open-in-upgradeneeded.js:
- 11:42 AM Changeset in webkit [201651] by
-
- 2 edits in trunk/Source/JavaScriptCore
ARMv7 vstm and vldm instructions can only operate on a maximum of 16 registers.
https://bugs.webkit.org/show_bug.cgi?id=158349
Reviewed by Filip Pizlo.
According to the ARM Assembler Reference, the vstm and vldm instructions can only
operate on a maximum of 16 registers. See
http://infocenter.arm.com/help/index.jsp?topic=/com.arm.doc.dht0002a/ch01s03s02.html
and http://infocenter.arm.com/help/index.jsp?topic=/com.arm.doc.dht0002a/ch01s03s02.html.
The ARMv7 probe code was wrongly using these instructions to store and load all
32 'd' registers. This is now fixed.
- assembler/MacroAssemblerARMv7.cpp:
- 11:36 AM Changeset in webkit [201650] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Update NativeFunctionParameters (FontFaceSet, HTMLSlotElement, EventTarget)
https://bugs.webkit.org/show_bug.cgi?id=158333
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-06-03
Reviewed by Brian Burg.
- UserInterface/Models/NativeFunctionParameters.js:
Replace FontLoader with FontFaceSet. Add HTMLSlotElement API.
EventTarget is now actually in the prototype chain, so add it as
a first class citizen and keep mixing it in for legacy backends.
- 11:22 AM Changeset in webkit [201649] by
-
- 2 edits in trunk/Source/WebKit/win
[Win] Implement WebView::removeAllUserContentFromGroup
https://bugs.webkit.org/show_bug.cgi?id=158343
Reviewed by Brent Fulgham.
- WebView.cpp:
(WebView::removeAllUserContentFromGroup):
- 11:13 AM Changeset in webkit [201648] by
-
- 5 edits8 adds in trunk
Reflection of element does not respect backdrop-filter property
https://bugs.webkit.org/show_bug.cgi?id=158201
Patch by Antoine Quint <Antoine Quint> on 2016-06-03
Reviewed by Dean Jackson.
Source/WebCore:
We weren't cloning the PlatformCALayer for the backdrop so reflections would simply
not show their backdrops. We now follow the same pattern as other PlatformCALayers
owned by a GraphicsLayerCA and keep a list of backdrop layer clones that we add
to the structural layer when cloning to match the layer order of the original
and update the backdrop layer clone properties to match the original when the
backdrop filters or rectangle changes.
Tests: css3/filters/backdrop/backdrop-filter-with-reflection-add-backdrop.html
css3/filters/backdrop/backdrop-filter-with-reflection-remove-backdrop.html
css3/filters/backdrop/backdrop-filter-with-reflection-value-change.html
css3/filters/backdrop/backdrop-filter-with-reflection.html
- platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::updateBackdropFilters):
(WebCore::GraphicsLayerCA::updateBackdropFiltersRect):
Update backdrop layer clones to match new values set when the backdrop filter
configuration changes.
(WebCore::GraphicsLayerCA::ensureCloneLayers):
Create the backdrop layer clones map if needed and clone the existing backdrop layer.
(WebCore::GraphicsLayerCA::clearClones):
Clear the backdrop layer clones map.
(WebCore::GraphicsLayerCA::fetchCloneLayers):
Obtain a clone for the backdrop layer, and if we have a valid clone, add it to the
structural layer clone as its first child to match the operation in updateSublayerList().
- platform/graphics/ca/GraphicsLayerCA.h:
Modify the signature for ensureCloneLayers() to account for the new backdrop layer clone and
declare the backdrop layer clone map.
- platform/graphics/ca/cocoa/PlatformCALayerCocoa.mm:
(PlatformCALayerCocoa::clone):
Reflect the backdrop layer type when cloning a PlatformCALayer.
LayoutTests:
- css3/filters/backdrop/backdrop-filter-with-reflection-add-backdrop-expected.html: Added.
- css3/filters/backdrop/backdrop-filter-with-reflection-add-backdrop.html: Added.
Covers the case where a reflected element without a backdrop-filter initially has one added later.
- css3/filters/backdrop/backdrop-filter-with-reflection-expected.html: Added.
- css3/filters/backdrop/backdrop-filter-with-reflection-remove-backdrop-expected.html: Added.
Covers the case where a reflected element with a backdrop-filter initially has it removed later.
- css3/filters/backdrop/backdrop-filter-with-reflection-remove-backdrop.html: Added.
- css3/filters/backdrop/backdrop-filter-with-reflection-value-change-expected.html: Added.
Covers the case where a reflected element with a backdrop-filter has its backdrop-filter property changed later.
- css3/filters/backdrop/backdrop-filter-with-reflection-value-change.html: Added.
- css3/filters/backdrop/backdrop-filter-with-reflection.html: Added.
Covers the basic case of a reflected element with a backdrop-filter.
- 10:09 AM Changeset in webkit [201647] by
-
- 3 edits in trunk/Source/WebCore
ResourceResponseBase cleanup.
https://bugs.webkit.org/show_bug.cgi?id=158348
Reviewed by Chris Dumez.
No new tests (Refactor, no behavior change).
CrossThreadData can be noncopyable and WTFMove()'ed around, instead of
being in a unique_ptr.
- platform/network/ResourceResponseBase.cpp:
(WebCore::ResourceResponseBase::crossThreadData):
(WebCore::ResourceResponseBase::fromCrossThreadData):
- platform/network/ResourceResponseBase.h:
- 9:49 AM Changeset in webkit [201646] by
-
- 2 edits in trunk/Source/JavaScriptCore
Gardening: CLOOP build fix (needs a #include).
Not reviewed.
- interpreter/StackVisitor.h:
- 9:43 AM Changeset in webkit [201645] by
-
- 3 edits in trunk/Source/JavaScriptCore
Eliminate two large sources of temporary StringImpl objects.
<https://webkit.org/b/158336>
Reviewed by Anders Carlsson.
We were jumping through some inefficient hoops when creating Identifiers due to the
convenience of our String(const char*) constructor.
This patch avoids just over 1 million temporary StringImpl objects on the PLUM benchmark.
- runtime/JSObject.h:
(JSC::makeIdentifier): Add an overload for string literals so we can stop creating a temporary
String just for passing to Identifier::fromString().
- runtime/Lookup.h:
(JSC::reifyStaticProperties): Use the Identifier::fromString() that takes an LChar* and a length
instead of creating a temporary String.
- 9:32 AM Changeset in webkit [201644] by
-
- 2 edits in trunk
[Win] IndexedDB worker tests are failing.
https://bugs.webkit.org/show_bug.cgi?id=158341
Reviewed by Alex Christensen.
Enable IndexedDB in workers.
- Source/cmake/OptionsWin.cmake:
- 9:13 AM Changeset in webkit [201643] by
-
- 2 edits in trunk/Source/WebKit2
Fix the !ENABLE(INDEXED_DATABASE) build after r201575
https://bugs.webkit.org/show_bug.cgi?id=158346
Reviewed by Brady Eidson.
- DatabaseProcess/DatabaseProcess.cpp:
(WebKit::DatabaseProcess::fetchWebsiteData):
(WebKit::DatabaseProcess::deleteWebsiteData):
(WebKit::DatabaseProcess::deleteWebsiteDataForOrigins):
- 8:40 AM Changeset in webkit [201642] by
-
- 2 edits in trunk/Tools
[GTK] Update YouCompleteMe script to make all include paths absolute
https://bugs.webkit.org/show_bug.cgi?id=158301
Reviewed by Michael Catanzaro.
Before this patch, some include paths were not made absolute.
This could make YouCompleteMe plugin to fail extracting information or validating cpp files.
- gtk/ycm_extra_conf.py:
- 7:53 AM Changeset in webkit [201641] by
-
- 6 edits1 add in trunk/Source
Clean up how StackVisitor dumps its frames.
https://bugs.webkit.org/show_bug.cgi?id=158316
Reviewed by Keith Miller.
Source/JavaScriptCore:
- Updated to do dumping to a PrintStream.
- Added support for printing a prefix for each frame. This is currently used by JSDollarVMPrototype to print frame numbers.
- Fix the incrementing of the frame index in StackVisitor. It was initialized but never incremented before when iterating the frames.
- interpreter/StackVisitor.cpp:
(JSC::StackVisitor::gotoNextFrame):
(JSC::StackVisitor::Frame::codeType):
(JSC::StackVisitor::Frame::functionName):
(JSC::StackVisitor::Frame::sourceURL):
(JSC::StackVisitor::Frame::toString):
(JSC::StackVisitor::Frame::createArguments):
(JSC::StackVisitor::Frame::computeLineAndColumn):
(JSC::StackVisitor::Frame::retrieveExpressionInfo):
(JSC::StackVisitor::Frame::setToEnd):
(JSC::StackVisitor::Frame::dump):
(JSC::StackVisitor::Indent::dump):
(JSC::printIndents): Deleted.
(JSC::log): Deleted.
(JSC::logF): Deleted.
(JSC::StackVisitor::Frame::print): Deleted.
- interpreter/StackVisitor.h:
(JSC::StackVisitor::Indent::Indent):
(JSC::StackVisitor::Indent::operator++):
(JSC::StackVisitor::Indent::operator--):
(JSC::StackVisitor::Frame::isJSFrame):
(JSC::StackVisitor::Frame::isInlinedFrame):
(JSC::StackVisitor::Frame::vmEntryFrame):
(JSC::StackVisitor::Frame::callFrame):
(JSC::StackVisitor::Frame::Frame):
(JSC::StackVisitor::Frame::~Frame):
- tools/JSDollarVMPrototype.cpp:
(JSC::PrintFrameFunctor::operator()):
Source/WTF:
Added an Indenter class what works with dataLog.
- WTF.xcodeproj/project.pbxproj:
- wtf/Indenter.h: Added.
(WTF::Indenter::Indenter):
(WTF::Indenter::dump):
(WTF::Indenter::operator++):
(WTF::Indenter::operator--):
- 2:03 AM Changeset in webkit [201640] by
-
- 2 edits in trunk/Tools
Unreviewed: add myself to the committers list.
- Scripts/webkitpy/common/config/contributors.json:
- 12:52 AM Changeset in webkit [201639] by
-
- 4 edits in trunk
REGRESSION: WebGL doesn't show up in CSS reflections
https://bugs.webkit.org/show_bug.cgi?id=76489
Patch by Antoine Quint <Antoine Quint> on 2016-06-03
Reviewed by Dean Jackson.
Source/WebCore:
The WebGLLayer needs to notify its owning GraphicsLayer that it was displayed
such that its clones, in GraphicsLayerCA::layerDidDisplay, may have their contents
updated to match that layer's contents. The test at compositing/webgl/webgl-reflection.html
already covers this test and its expectation on Mac has been updated.
- platform/graphics/mac/WebGLLayer.mm:
(-[WebGLLayer display]):
LayoutTests:
Update the expected rendering to contain the reflected WebGL <canvas>.
- platform/mac/compositing/webgl/webgl-reflection-expected.png:
- 12:10 AM Changeset in webkit [201638] by
-
- 2 edits in trunk/Source/WebCore
Refactor showModalDialog handling in JSDOMWindowCustom
https://bugs.webkit.org/show_bug.cgi?id=158294
Reviewed by Ryosuke Niwa.
The showModalDialog property is currently implemented in a way that effectively
results in duplication of the tail of the function, but modified to call
Base::getOwnPropertySlot instead of getStaticPropertySlot. It does so based on the
assumption that Base::getOwnPropertySlot is not going to search the static tables
(containing the property we wish to omit).
However as a part of bug #158178 I plan to change it such that Base::getOwnPropertySlot
does also search the static tables. So, refactoring this code to no longer depend on
using a function that bypasses the static tables. Always perform a lookup that will
check both property storage & static tables. If the object does contain the property,
then check explicitly for the value we're intending to suppress.
Covered by exsiting tests.
- bindings/js/JSDOMWindowCustom.cpp:
(WebCore::JSDOMWindow::getOwnPropertySlot):
- Check result of getStaticPropertySlot for showModalDialog function.
Jun 2, 2016:
- 10:40 PM Changeset in webkit [201637] by
-
- 4 edits in trunk/Source/WebCore
Fix AtomicString regression caused by r201603.
https://bugs.webkit.org/show_bug.cgi?id=158338
Reviewed by Chris Dumez.
No new tests (Refactor, plus already caught by existing test configs).
- loader/WorkerThreadableLoader.cpp:
(WebCore::WorkerThreadableLoader::MainThreadBridge::didReceiveResponse):
- platform/network/ResourceResponseBase.cpp:
(WebCore::ResourceResponseBase::crossThreadData): Re-introduce the cross thread data concept,
but more modern and clean this time.
(WebCore::ResourceResponseBase::fromCrossThreadData):
(WebCore::ResourceResponseBase::isolatedCopy): Deleted.
- platform/network/ResourceResponseBase.h:
- 10:38 PM Changeset in webkit [201636] by
-
- 2 edits in trunk/Source/WebCore
Drop BlobRegistryContext class as it is no longer needed
https://bugs.webkit.org/show_bug.cgi?id=158328
Reviewed by Brady Eidson.
Drop BlobRegistryContext class as it is no longer needed. We can now
call isolatedCopy() as we capture in the lambda.
- fileapi/ThreadableBlobRegistry.cpp:
(WebCore::ThreadableBlobRegistry::registerFileBlobURL):
(WebCore::ThreadableBlobRegistry::registerBlobURL):
(WebCore::ThreadableBlobRegistry::registerBlobURLForSlice):
(WebCore::ThreadableBlobRegistry::blobSize):
(WebCore::ThreadableBlobRegistry::unregisterBlobURL):
(WebCore::BlobRegistryContext::BlobRegistryContext): Deleted.
- 10:27 PM Changeset in webkit [201635] by
-
- 18 edits2 adds in trunk
Repaint issue with vertical text in an out of flow container.
https://bugs.webkit.org/show_bug.cgi?id=102665
<rdar://problem/26605298>
Reviewed by David Hyatt.
Since the renderer’s offset for positioned objects is always physical, we only
need to flip the repaint rect(always logical) for writing root, when we see the first positioned object.
All subsequent writing root changes for positioned objects are okay and they don't need flipping.
Source/WebCore:
Test: fast/repaint/vertical-text-repaint.html
- rendering/RenderBox.cpp:
(WebCore::RenderBox::computeRectForRepaint):
- rendering/RenderBox.h:
(WebCore::RenderBox::computeRectForRepaint):
- rendering/RenderInline.cpp:
(WebCore::RenderInline::computeRectForRepaint):
- rendering/RenderInline.h:
(WebCore::RenderInline::computeRectForRepaint):
- rendering/RenderObject.cpp:
(WebCore::RenderObject::computeRectForRepaint):
- rendering/RenderObject.h:
(WebCore::RenderObject::computeAbsoluteRepaintRect):
(WebCore::RenderObject::computeRectForRepaint):
- rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::computeRectForRepaint):
- rendering/RenderTableCell.h:
- rendering/RenderView.cpp:
(WebCore::RenderView::computeRectForRepaint):
- rendering/RenderView.h:
- rendering/svg/RenderSVGForeignObject.cpp:
(WebCore::RenderSVGForeignObject::computeRectForRepaint):
- rendering/svg/RenderSVGForeignObject.h:
- rendering/svg/RenderSVGRoot.cpp:
(WebCore::RenderSVGRoot::computeFloatRectForRepaint):
- rendering/svg/RenderSVGText.cpp:
(WebCore::RenderSVGText::computeRectForRepaint):
- rendering/svg/RenderSVGText.h:
LayoutTests:
- fast/repaint/vertical-text-repaint-expected.txt: Added.
- fast/repaint/vertical-text-repaint.html: Added.
- 9:33 PM Changeset in webkit [201634] by
-
- 8 edits in trunk
[Win] Fetch API tests are failing.
https://bugs.webkit.org/show_bug.cgi?id=158296
Reviewed by Alex Christensen.
Source/WebKit/win:
Add preference for enabling Fetch API.
- Interfaces/IWebPreferencesPrivate.idl:
- WebPreferenceKeysPrivate.h:
- WebPreferences.cpp:
(WebPreferences::initializeDefaultSettings):
(WebPreferences::fetchAPIEnabled):
(WebPreferences::setFetchAPIEnabled):
- WebPreferences.h:
- WebView.cpp:
(WebView::notifyPreferencesChanged):
Tools:
Enable Fetch API when running tests.
- DumpRenderTree/win/DumpRenderTree.cpp:
(resetWebPreferencesToConsistentValues):
- 8:32 PM Changeset in webkit [201633] by
-
- 9 edits1 add in trunk/Source/WebCore
Fix build
https://bugs.webkit.org/show_bug.cgi?id=158337
rdar://problem/26429419
Reviewed by Dan Bernstein.
- WebCore.xcodeproj/project.pbxproj:
Add QTKitSPI.h header.
- platform/graphics/mac/MediaPlayerPrivateQTKit.h:
- platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
- platform/graphics/mac/MediaTimeQTKit.h:
- platform/graphics/mac/MediaTimeQTKit.mm:
- platform/mac/WebVideoFullscreenController.mm:
Include QTKitSPI.h.
- platform/spi/cocoa/QuartzCoreSPI.h:
- platform/spi/mac/AVFoundationSPI.h:
Use MAX_ALLOWED instead of MIN_REQUIRED.
- platform/spi/mac/QTKitSPI.h:
Add new QTKit header.
- 7:54 PM Changeset in webkit [201632] by
-
- 3 edits in trunk/LayoutTests
Fix a typo in the clz32() tests
Patch by Benjamin Poulain <bpoulain@apple.com> on 2016-06-02
Rubber-stamped by Joseph Pecoraro.
Joe found a bug in math-clz32.js: I typed INFINITI instead of INFINITY.
The tests was effectively checking "undefined" instead of infinity.
- js/math-clz32-expected.txt:
- js/script-tests/math-clz32.js:
(objectRecordConversionCalls.valueOf):
- 6:34 PM Changeset in webkit [201631] by
-
- 2 edits in trunk/Source/WebKit/ios
Fix typo in -[WebDefaultUIKitDelegate deleteFromInputwithFlags:]
<https://webkit.org/b/158323>
<rdar://problem/26549165>
Reviewed by Andy Estes.
- DefaultDelegates/WebDefaultUIKitDelegate.m:
(-[WebDefaultUIKitDelegate deleteFromInputwithFlags:]): Rename...
(-[WebDefaultUIKitDelegate deleteFromInputWithFlags:]): ...to this.
- 6:18 PM Changeset in webkit [201630] by
-
- 12 edits in trunk/Source/WebInspectorUI
Web Inspector: Modernize Array.prototype.every/some callsites to arrow functions
https://bugs.webkit.org/show_bug.cgi?id=158330
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-06-02
Reviewed by Brian Burg.
- UserInterface/Controllers/DOMTreeManager.js:
(WebInspector.DOMTreeManager.prototype._updateContentFlowFromPayload):
- UserInterface/Models/ProfileNode.js:
(WebInspector.ProfileNode):
- UserInterface/Models/ScopeChainNode.js:
(WebInspector.ScopeChainNode):
- UserInterface/Models/StackTrace.js:
(WebInspector.StackTrace):
- UserInterface/Models/StructureDescription.js:
(WebInspector.StructureDescription):
- UserInterface/Models/TypeDescription.js:
(WebInspector.TypeDescription):
- UserInterface/Protocol/InspectorBackend.js:
(InspectorBackend.Command.prototype.supports):
- UserInterface/Views/ContentViewContainer.js:
(WebInspector.ContentViewContainer.prototype.showContentView):
- UserInterface/Views/NavigationSidebarPanel.js:
(WebInspector.NavigationSidebarPanel.prototype._checkElementsForPendingViewStateCookie.treeElementMatchesCookie):
(WebInspector.NavigationSidebarPanel.prototype._checkElementsForPendingViewStateCookie):
- UserInterface/Views/ScopeBar.js:
(WebInspector.ScopeBar.prototype.get selectedItems):
(WebInspector.ScopeBar.prototype.hasNonDefaultItemSelected):
- UserInterface/Views/TabContentView.js:
(WebInspector.TabContentView):
(WebInspector.TabContentView.console.assert): Deleted.
- 5:39 PM Changeset in webkit [201629] by
-
- 15 edits in trunk/Source
[iOS] PDFDocumentImage should not create a cached image larger than 4M pixels
https://bugs.webkit.org/show_bug.cgi?id=157857
Patch by Said Abou-Hallawa <sabouhallawa@apple,com> on 2016-06-02
Reviewed by Darin Adler.
Source/WebCore:
On iOS, if the scaled size of the PDFDocumentImage cached image will exceed
the 4M pixels limit and the system physical memory is 1GB or less, do not
create it. PDFDocumentImage::draw() falls back peacefully if the cached image
couldn't be created for any reason. The PDF will be drawn directly to the
GraphicsContext without having to go through the cached image. This means
the whole PDF will be drawn multiple times; one time for each tile. I think
this is okay for zooming a large PDFDocumentImage on a low end device.
- html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::drawTextInternal): Call the static function
ImageBuffer::createCompatibleBuffer() without having to go through the GraphicsContext.
- platform/graphics/BitmapImage.cpp:
(WebCore::BitmapImage::drawPattern): Ditto.
- platform/graphics/FloatSize.h:
(WebCore::FloatSize::area): A helper function similar to IntSize::area().
(WebCore::operator*): Scale a FloatSize by another FloatSize and return the result.
- platform/graphics/GradientImage.cpp:
(WebCore::GradientImage::drawPattern): Call ImageBuffer::createCompatibleBuffer().
- platform/graphics/GraphicsContext.cpp:
(WebCore::GraphicsContext::scaleFactor):: Return the scaling part of the current CTM.
(WebCore::scalesMatch): Deleted.
(WebCore::GraphicsContext::createCompatibleBuffer): Deleted.
(WebCore::GraphicsContext::isCompatibleWithBuffer): Deleted.
- platform/graphics/GraphicsContext.h:
Move these image buffer functions to ImageBuffer.
- platform/graphics/ImageBuffer.cpp:
(WebCore::ImageBuffer::createCompatibleBuffer): Make createCompatibleBuffer
a static function of the ImageBuffer. There is no need to go through the
GraphicsContext just to get the GraphicsContext scaleFactor.
(WebCore::ImageBuffer::compatibleBufferSize): Scale the size of the cachedImage
by the scaleFactor of the context.
(WebCore::ImageBuffer::isCompatibleWithContext): Returns true if the drawing
context and the ImageBuffer context have the same scaleFactor.
- platform/graphics/ImageBuffer.h:
- platform/graphics/NamedImageGeneratedImage.cpp:
(WebCore::NamedImageGeneratedImage::drawPattern): Call ImageBuffer::createCompatibleBuffer().
- platform/graphics/cg/PDFDocumentImage.cpp:
(WebCore::PDFDocumentImage::updateCachedImageIfNeeded): On iOS, if the
physical memory is less than 1GB, do not allocate more than 16MB for the
PDF cachedImage.
- rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::paintFillLayerExtended): Call ImageBuffer::createCompatibleBuffer().
- rendering/svg/SVGRenderingContext.cpp:
(WebCore::SVGRenderingContext::bufferForeground): Ditto.
Source/WTF:
- wtf/StdLibExtras.h: Add a constant value for GB (230).
- 4:52 PM Changeset in webkit [201628] by
-
- 2 edits1 add in trunk/Source/JavaScriptCore
global lexical environment variables are not accessible through functions created using the function constructor
https://bugs.webkit.org/show_bug.cgi?id=158319
Reviewed by Filip Pizlo.
When creating a function using the Function constructor, we were
using the global object instead of the global lexical environment
as the function's scope. We should be using the global lexical environment.
- runtime/FunctionConstructor.cpp:
(JSC::constructFunctionSkippingEvalEnabledCheck):
- tests/stress/function-constructor-reading-from-global-lexical-environment.js: Added.
(assert):
(test):
(ClassTDZ):
- 4:45 PM Changeset in webkit [201627] by
-
- 7 edits in trunk
[WebIDL] 'undefined' should be an acceptable value for nullable parameters
https://bugs.webkit.org/show_bug.cgi?id=158321
Reviewed by Ryosuke Niwa.
LayoutTests/imported/w3c:
Rebaseline test. The test is failing because the first parameter to
createPattern is wrongly marked as nullable in our IDL and because our
implementation throws a legacy TYPE_MISMATCH_ERR instead of a standard
TypeError when getting null as first parameter. I will fix this bug
and this test via Bug 158322.
- canvas/2d.pattern.image.undefined-expected.txt:
Source/WebCore:
'undefined' should be an acceptable value for nullable parameters (and
should be converted to null):
Our bindings got most of the cases right but there was a bug in our
overload resolution code. This patch fixes it.
No new tests, already covered by existing tests.
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateParametersCheckExpression):
- bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethodWithOptionalParameter):
LayoutTests:
Rebaseline existing test that is now passing.
- canvas/philip/tests/2d.pattern.image.undefined-expected.txt:
- 4:33 PM Changeset in webkit [201626] by
-
- 5 edits in trunk/Tools
Really display failing JSC stress tests in buildbot dashboard
https://bugs.webkit.org/show_bug.cgi?id=158324
Patch by Srinivasan Vijayaraghavan <svijayaraghavan@apple.com> on 2016-06-02
Reviewed by Alexey Proskuryakov.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js:
(BuildbotCombinedQueueView.prototype.update): Correctly check for string membership in array.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
(BuildbotIteration.prototype._parseData): Correctly check for string membership in array.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
(BuildbotQueueView.prototype._popoverContentForJavaScriptCoreTestRegressions): Correctly check for string
membership in array.
(BuildbotQueueView.prototype._presentPopoverForJavaScriptCoreTestRegressions): Ensure that the correct URL is
generated after the first time.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
(BuildbotTesterQueueView.prototype.appendBuilderQueueStatus): Correctly check for string membership in array.
- 4:14 PM Changeset in webkit [201625] by
-
- 2 edits in trunk/Websites/webkit.org
Update the example for wider color gamut images.
- blog-files/color-gamut/index.html:
- 4:07 PM Changeset in webkit [201624] by
-
- 7 edits2 adds in trunk
JS parser incorrectly handles invalid utf8 in error messages.
https://bugs.webkit.org/show_bug.cgi?id=158128
Reviewed by Saam Barati.
Source/JavaScriptCore:
The bug here was caused by us using PrintStream's toString method
to produce the error message for a parse error, even though toString
may produce a null string in the event of invalid utf8 that causes
the error in first case. So when we try to create an error message
containing the invalid character code, we set m_errorMessage to the
null string, as that signals "no error" we don't stop parsing, and
everything goes down hill from there.
Now we use the new toStringWithLatin1Fallback so that we can always
produce an error message, even if it contains invalid unicode. We
also add an additional fallback so that we can guarantee an error
message is set even if we're given a null string. There's a debug
mode assertion to prevent anyone accidentally attempting to clear
the message via setErrorMessage.
- parser/Parser.cpp:
(JSC::Parser<LexerType>::logError):
- parser/Parser.h:
(JSC::Parser::setErrorMessage):
Source/WTF:
Add a new toStringWithLatin1Fallback that simply uses
String::fromUTF8WithLatin1Fallback, so we can avoid the
standard String::fromUTF8 null return.
- wtf/StringPrintStream.cpp:
(WTF::StringPrintStream::toStringWithLatin1Fallback):
- wtf/StringPrintStream.h:
LayoutTests:
Add a testcase.
- js/invalid-utf8-in-syntax-error-expected.txt: Added.
- js/script-tests/invalid-utf8-in-syntax-error.js: Added.
- 3:43 PM Changeset in webkit [201623] by
-
- 26 edits in trunk/Source/WebCore
Modernize how many platform/network classes do isolatedCopy().
https://bugs.webkit.org/show_bug.cgi?id=158313
Reviewed by Alex Christensen.
No new tests (Refactor, no behavior change).
- loader/WorkerThreadableLoader.h:
- platform/network/FormData.cpp:
(WebCore::FormData::isolatedCopy):
(WebCore::FormDataElement::isolatedCopy):
(WebCore::FormData::FormData): Deleted.
(WebCore::FormData::deepCopy): Deleted.
- platform/network/FormData.h:
- platform/network/HTTPHeaderMap.cpp:
(WebCore::HTTPHeaderMap::isolatedCopy):
(WebCore::HTTPHeaderMap::copyData): Deleted.
(WebCore::HTTPHeaderMap::adopt): Deleted.
- platform/network/HTTPHeaderMap.h:
- platform/network/ResourceErrorBase.cpp:
(WebCore::ResourceErrorBase::asResourceError):
(WebCore::ResourceErrorBase::isolatedCopy):
- platform/network/ResourceErrorBase.h:
(WebCore::ResourceErrorBase::platformCopy): Deleted.
- platform/network/ResourceLoadTiming.h:
(WebCore::ResourceLoadTiming::isolatedCopy): Not strictly needed for now, but makes it obvious
that changes will be needed if new members are added later.
- platform/network/ResourceRequestBase.cpp:
(WebCore::ResourceRequestBase::isolatedCopy):
(WebCore::ResourceRequestBase::setAsIsolatedCopy):
(WebCore::ResourceRequestBase::copyData): Deleted.
- platform/network/ResourceRequestBase.h:
- platform/network/ResourceResponseBase.cpp:
(WebCore::ResourceResponseBase::isolatedCopy):
(WebCore::ResourceResponseBase::copyData): Deleted.
- platform/network/ResourceResponseBase.h:
(WebCore::CrossThreadResourceResponseDataBase::CrossThreadResourceResponseDataBase): Deleted.
- platform/network/cf/ResourceError.h:
- platform/network/cf/ResourceErrorCF.cpp:
(WebCore::ResourceError::doPlatformIsolatedCopy):
(WebCore::ResourceError::platformCopy): Deleted.
- platform/network/cf/ResourceRequest.h:
- platform/network/cf/ResourceRequestCFNet.cpp:
(WebCore::ResourceRequest::doPlatformSetAsIsolatedCopy):
(WebCore::ResourceRequest::doPlatformCopyData): Deleted.
(WebCore::ResourceRequest::doPlatformAdopt): Deleted.
- platform/network/cf/ResourceResponse.h:
(WebCore::ResourceResponse::doPlatformCopyData): Deleted.
(WebCore::ResourceResponse::doPlatformAdopt): Deleted.
- platform/network/curl/ResourceError.h:
(WebCore::ResourceError::doPlatformIsolatedCopy):
- platform/network/curl/ResourceRequest.h:
(WebCore::ResourceRequest::doPlatformSetAsIsolatedCopy):
(WebCore::ResourceRequest::doPlatformCopyData): Deleted.
(WebCore::ResourceRequest::doPlatformAdopt): Deleted.
- platform/network/curl/ResourceResponse.h:
(WebCore::ResourceResponse::doPlatformCopyData): Deleted.
(WebCore::ResourceResponse::doPlatformAdopt): Deleted.
- platform/network/mac/ResourceErrorMac.mm:
(WebCore::ResourceError::doPlatformIsolatedCopy):
- platform/network/soup/ResourceError.h:
- platform/network/soup/ResourceErrorSoup.cpp:
(WebCore::ResourceError::doPlatformIsolatedCopy):
(WebCore::ResourceError::platformCopy): Deleted.
- platform/network/soup/ResourceRequest.h:
(WebCore::ResourceRequest::doPlatformSetAsIsolatedCopy):
(WebCore::ResourceRequest::doPlatformCopyData): Deleted.
(WebCore::ResourceRequest::doPlatformAdopt): Deleted.
- platform/network/soup/ResourceResponse.h:
(WebCore::ResourceResponse::doPlatformCopyData): Deleted.
(WebCore::ResourceResponse::doPlatformAdopt): Deleted.
- 3:18 PM Changeset in webkit [201622] by
-
- 3 edits1 add in trunk/Source/JavaScriptCore
Teach bytecode liveness about the debugger
https://bugs.webkit.org/show_bug.cgi?id=158288
Reviewed by Filip Pizlo.
There was a bug where we wouldn't always keep the scope register
on the stack when the debugger is enabled. The debugger always assumes
it can read from the scope. The bug happened in OSR exit from the FTL.
The FTL uses bytecode liveness for OSR exit. Bytecode liveness proved
that the scope register was dead, so the FTL OSR exit wroteundefined
into the scope's stack slot when OSR exiting to the baseline.
To fix this, I taught bytecode liveness' computeUsesForBytecodeOffset() that the
scope is used by every instruction except op_enter. This causes the
scope to be live-in at every instruction except op_enter.
- bytecode/BytecodeLivenessAnalysis.cpp:
(JSC::blockContainsBytecodeOffset):
(JSC::addAlwaysLiveLocals):
(JSC::findBasicBlockForBytecodeOffset):
(JSC::stepOverInstruction):
(JSC::computeLocalLivenessForBytecodeOffset):
(JSC::BytecodeLivenessAnalysis::runLivenessFixpoint):
- bytecode/UnlinkedCodeBlock.cpp:
(JSC::UnlinkedCodeBlock::UnlinkedCodeBlock):
- tests/stress/shadow-chicken-reading-from-scope-after-ftl-osr-exit-bytecode-liveness.js: Added.
(foo):
(catch):
- 3:15 PM Changeset in webkit [201621] by
-
- 1 edit10 adds in trunk/Websites/webkit.org
Adding some sample images for a blog post on color.
- blog-files/color-gamut/Flowers-AdobeRGB.jpg: Added.
- blog-files/color-gamut/Flowers-ProPhoto.jpg: Added.
- blog-files/color-gamut/Flowers-oog.jpg: Added.
- blog-files/color-gamut/Flowers-sRGB.jpg: Added.
- blog-files/color-gamut/Rose-AdobeRGB.jpg: Added.
- blog-files/color-gamut/Rose-ProPhoto.jpg: Added.
- blog-files/color-gamut/Rose-oog.jpg: Added.
- blog-files/color-gamut/Rose-sRGB.jpg: Added.
- blog-files/color-gamut/index.html: Added.
- 3:11 PM Changeset in webkit [201620] by
-
- 26 edits in trunk/Source/WebInspectorUI
Web Inspector: Modernize some function expressions that bind(this) to arrow functions
https://bugs.webkit.org/show_bug.cgi?id=158315
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-06-02
Reviewed by Brian Burg.
Convert a common "function(x) { ... }.bind(this)" pattern to use arrow
functions "(x) => { ... }", which lexically bindsthis, slightly faster,
and uses less memory.
- UserInterface/Base/Main.js:
(WebInspector._updateNewTabButtonState):
- UserInterface/Controllers/BreakpointPopoverController.js:
(WebInspector.BreakpointPopoverController.prototype._createPopoverContent):
- UserInterface/Controllers/TypeTokenAnnotator.js:
(WebInspector.TypeTokenAnnotator.prototype.insertAnnotations):
(WebInspector.TypeTokenAnnotator.prototype.insertAnnotations.): Deleted.
- UserInterface/Models/RenderingFrameTimelineRecord.js:
(WebInspector.RenderingFrameTimelineRecord.prototype._calculateDurationRemainder):
(WebInspector.RenderingFrameTimelineRecord):
- UserInterface/Models/Resource.js:
(WebInspector.Resource.prototype.requestContent):
- UserInterface/Models/Script.js:
(WebInspector.Script.prototype.requestScriptSyntaxTree):
(WebInspector.Script.prototype.requestScriptSyntaxTree.makeSyntaxTreeAndCallCallback): Deleted.
- UserInterface/Models/SourceCodeLocation.js:
(WebInspector.SourceCodeLocation.prototype.populateLiveDisplayLocationString):
- UserInterface/Models/WrappedPromise.js:
(WebInspector.WrappedPromise):
- UserInterface/Views/BreakpointActionView.js:
(WebInspector.BreakpointActionView.prototype._updateBody):
- UserInterface/Views/BreakpointTreeElement.js:
(WebInspector.BreakpointTreeElement.prototype._dataUpdated):
- UserInterface/Views/CSSStyleDeclarationTextEditor.js:
(WebInspector.CSSStyleDeclarationTextEditor.prototype._updateTextMarkers.update):
(WebInspector.CSSStyleDeclarationTextEditor.prototype._updateTextMarkers):
- UserInterface/Views/DefaultDashboardView.js:
(WebInspector.DefaultDashboardView.prototype._appendElementForNamedItem.set item):
(WebInspector.DefaultDashboardView.prototype._appendElementForNamedItem):
- UserInterface/Views/ErrorObjectView.js:
(WebInspector.ErrorObjectView.prototype.update):
- UserInterface/Views/GeneralTreeElement.js:
(WebInspector.GeneralTreeElement.prototype.onattach):
(WebInspector.GeneralTreeElement.prototype.onattach.this._boundContextMenuEventHandler): Deleted.
- UserInterface/Views/InlineSwatch.js:
(WebInspector.InlineSwatch.prototype._getNextValidHEXFormat):
(WebInspector.InlineSwatch):
- UserInterface/Views/LayerTreeDetailsSidebarPanel.js:
(WebInspector.LayerTreeDetailsSidebarPanel.prototype.refresh):
(WebInspector.LayerTreeDetailsSidebarPanel.prototype._showPopoverForSelectedNode):
(WebInspector.LayerTreeDetailsSidebarPanel.prototype._contentForPopover):
- UserInterface/Views/LogContentView.js:
(WebInspector.LogContentView.prototype._mouseup):
- UserInterface/Views/NavigationSidebarPanel.js:
(WebInspector.NavigationSidebarPanel.prototype._checkElementsForPendingViewStateCookie):
- UserInterface/Views/ObjectTreeBaseTreeElement.js:
(WebInspector.ObjectTreeBaseTreeElement.prototype.createGetterElement):
(WebInspector.ObjectTreeBaseTreeElement.prototype.createGetterElement.): Deleted.
- UserInterface/Views/ObjectTreePropertyTreeElement.js:
(WebInspector.ObjectTreePropertyTreeElement.prototype._updateEntries):
- UserInterface/Views/ObjectTreeView.js:
(WebInspector.ObjectTreeView.prototype._updateEntries):
- UserInterface/Views/ResourceDetailsSidebarPanel.js:
(WebInspector.ResourceDetailsSidebarPanel.prototype._refreshImageSizeSection):
- UserInterface/Views/ScopeChainDetailsSidebarPanel.js:
(WebInspector.ScopeChainDetailsSidebarPanel.prototype._addWatchExpressionButtonClicked):
(WebInspector.ScopeChainDetailsSidebarPanel.prototype._objectTreeElementAddContextMenuItems):
(WebInspector.ScopeChainDetailsSidebarPanel.prototype._addWatchExpressionButtonClicked.this._codeMirror.addKeyMap): Deleted.
- UserInterface/Views/TabBar.js:
- UserInterface/Views/VisualStylePropertyEditor.js:
(WebInspector.VisualStylePropertyEditor.prototype._checkDependencies):
- 3:01 PM Changeset in webkit [201619] by
-
- 16 edits3 adds in trunk
REGRESSION(r200694): %ThrowTypeError% is not unique
https://bugs.webkit.org/show_bug.cgi?id=158231
Reviewed by Joseph Pecoraro.
Source/JavaScriptCore:
The ES6 standard in section 9.2.7.1 states that %ThrowTypeError% is unique. This
change reverts the handling of TypeError before r200694 and then rolls in
throwTypeErrorGetterSetter() with the renamed throwTypeErrorArgumentsCalleeAndCallerGetterSetter().
- runtime/ClonedArguments.cpp:
(JSC::ClonedArguments::getOwnPropertySlot):
(JSC::ClonedArguments::materializeSpecials):
- runtime/JSBoundFunction.cpp:
(JSC::JSBoundFunction::finishCreation):
(JSC::JSBoundFunction::visitChildren):
- runtime/JSFunction.cpp:
(JSC::getThrowTypeErrorGetterSetter):
(JSC::JSFunction::callerGetter):
(JSC::JSFunction::defineOwnProperty):
- runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::init):
(JSC::JSGlobalObject::visitChildren):
- runtime/JSGlobalObject.h:
(JSC::JSGlobalObject::regExpProtoSymbolReplaceFunction):
(JSC::JSGlobalObject::regExpProtoGlobalGetter):
(JSC::JSGlobalObject::regExpProtoUnicodeGetter):
(JSC::JSGlobalObject::throwTypeErrorArgumentsCalleeAndCallerGetterSetter):
(JSC::JSGlobalObject::moduleLoader):
(JSC::JSGlobalObject::throwTypeErrorGetterSetter): Deleted.
(JSC::JSGlobalObject::throwTypeErrorCalleeAndCallerGetterSetter): Deleted.
(JSC::JSGlobalObject::throwTypeErrorArgumentsAndCallerInStrictModeGetterSetter): Deleted.
(JSC::JSGlobalObject::throwTypeErrorArgumentsAndCallerInClassContextGetterSetter): Deleted.
- runtime/JSGlobalObjectFunctions.cpp:
(JSC::globalFuncThrowTypeError):
(JSC::globalFuncThrowTypeErrorArgumentsCalleeAndCaller):
(JSC::globalFuncThrowTypeErrorCalleeAndCaller): Deleted.
(JSC::globalFuncThrowTypeErrorArgumentsAndCallerInStrictMode): Deleted.
(JSC::globalFuncThrowTypeErrorArgumentsAndCallerInClassContext): Deleted.
- runtime/JSGlobalObjectFunctions.h:
- tests/stress/reflect-set.js:
LayoutTests:
Rebased tests for the new TypeError messages.
Added a new test, throw-type-error-is-unique.html.
- inspector/runtime/getProperties-expected.txt:
- js/basic-strict-mode-expected.txt:
- js/caller-property-expected.txt:
- js/class-method-and-constructor-properties-expected.txt:
- js/script-tests/caller-property.js:
(strictCaller):
(strictTailCaller):
- js/script-tests/class-method-and-constructor-properties.js:
(F.prototype.getElement):
(F):
(G.prototype.get item):
(G):
(H.prototype.arguments):
(H):
- js/script-tests/throw-type-error-is-unique.js: Added.
(ThrowTypeErrorSource):
(ThrowTypeErrorSource.prototype.checkTypeErrorFunctions):
(A):
(strictArguments):
(test):
- js/throw-type-error-is-unique-expected.txt: Added.
- js/throw-type-error-is-unique.html: Added.
- 2:53 PM Changeset in webkit [201618] by
-
- 5 edits in trunk
[iOS]: Some JSC stress tests fail running out of executable memory when the LLInt is disabled
https://bugs.webkit.org/show_bug.cgi?id=158317
Reviewed by Saam Barati.
Source/JavaScriptCore:
Updated these test to not run the "no-llint" variant when running on ARM machines.
- tests/stress/arrowfunction-lexical-bind-superproperty.js: Skip no-llint for ARM
(testCase):
- tests/stress/proxy-revoke.js: Skipp no-lint for ARM and ARM64
(assert):
Tools:
Added defaultNoNoLLIntRun variant to run the default tests with the exception of the no-llint
variant.
- Scripts/run-jsc-stress-tests:
- 2:24 PM Changeset in webkit [201617] by
-
- 20 edits3 adds in trunk/Source
Unreviewed, reland r201532. The associated regressions have been fixed
by r201584.
- 1:48 PM Changeset in webkit [201616] by
-
- 5 edits in branches/safari-602.1.32-branch/Source
Versioning.
- 1:37 PM Changeset in webkit [201615] by
-
- 2 edits in trunk/Source/WebCore
Crash under CachedResource::addClientToSet()
https://bugs.webkit.org/show_bug.cgi?id=158310
<rdar://problem/23643359>
Reviewed by Eric Carlson.
Only call CachedResource::addClient() on the resource returned
by CachedResourceLoader::requestMedia() if the resource is
non-null. CachedResourceLoader::requestMedia() can return null
in some cases so we need to handle this properly.
No new tests, no known reproduction case.
- platform/graphics/avfoundation/objc/WebCoreAVFResourceLoader.mm:
(WebCore::WebCoreAVFResourceLoader::startLoading):
- 1:35 PM Changeset in webkit [201614] by
-
- 6 edits in trunk/Source/WebCore
ScriptExecutionContext::Task constructor should take a NoncopyableFunction<void ()> as parameter
https://bugs.webkit.org/show_bug.cgi?id=158309
Reviewed by Brady Eidson.
ScriptExecutionContext::Task constructor should take a NoncopyableFunction<void ()>
as parameter for consistency with the other constructor and because this can be
called cross-thread.
- Modules/webaudio/AudioContext.cpp:
(WebCore::AudioContext::suspend):
(WebCore::AudioContext::resume):
(WebCore::AudioContext::close):
(WebCore::AudioContext::suspendPlayback):
(WebCore::AudioContext::mayResumePlayback):
- Modules/webaudio/AudioDestinationNode.h:
(WebCore::AudioDestinationNode::resume):
(WebCore::AudioDestinationNode::suspend):
(WebCore::AudioDestinationNode::close):
- Modules/webaudio/DefaultAudioDestinationNode.cpp:
(WebCore::DefaultAudioDestinationNode::resume):
(WebCore::DefaultAudioDestinationNode::suspend):
(WebCore::DefaultAudioDestinationNode::close):
- Modules/webaudio/DefaultAudioDestinationNode.h:
- dom/ScriptExecutionContext.h:
(WebCore::ScriptExecutionContext::Task::Task):
- 1:05 PM Changeset in webkit [201613] by
-
- 4 edits in trunk/Websites/webkit.org
Fix typos and make some revisions to the B3 docs
https://bugs.webkit.org/show_bug.cgi?id=158311
Reviewed by Michael Saboff.
I found typos and fixed them. Also, I clarified some things:
- Is B3 IR platform-agnostic? Sort of. I tried to describe when it is (Values usually behave the same way regardless of CPU) and when it isn't (it lets you speak of registers if that's what you want to do, for example).
- How does isValidForm really get used? You don't really need to create an Inst to use it.
- Some other incremental improvements to make the docs clearer.
- docs/b3/assembly-intermediate-representation.html:
- docs/b3/index.html:
- docs/b3/intermediate-representation.html:
- 12:57 PM Changeset in webkit [201612] by
-
- 2 edits in trunk/Source/WebKit2
Crash under WebProcess::registerWithStateDumper()
https://bugs.webkit.org/show_bug.cgi?id=158304
<rdar://problem/25329276>
Reviewed by Anders Carlsson.
The issue is that the block in registerWithStateDumper() was executed in
a background thread and is iterating over m_pageMap HashMap. The crash
occurs when a page gets removed from the m_pageMap HashMap while the
block is iterating over this same HashMap in another thread.
The solution proposed is to execute the registerWithStateDumper()'s
block in the main thread.
- WebProcess/cocoa/WebProcessCocoa.mm:
(WebKit::WebProcess::registerWithStateDumper):
- 12:40 PM Changeset in webkit [201611] by
-
- 4 edits in trunk/Source
Use "= delete" for Locker(int)
Rubber stamped by Saam Barati.
Source/JavaScriptCore:
- runtime/ConcurrentJITLock.h:
(JSC::ConcurrentJITLocker::ConcurrentJITLocker):
Source/WTF:
See discussion: https://bugs.webkit.org/show_bug.cgi?id=158306#c8
- wtf/Locker.h:
(WTF::Locker::Locker):
(WTF::Locker::~Locker):
- 12:36 PM Changeset in webkit [201610] by
-
- 4 edits in trunk/Source/JavaScriptCore
ObjectPropertyCondition should have a isStillValidAssumingImpurePropertyWatchpoint function
https://bugs.webkit.org/show_bug.cgi?id=158308
Reviewed by Filip Pizlo.
Recently, structureEnsuresValidityAssumingImpurePropertyWatchpoint was converted to check
what should be isStillValidAssumingImpurePropertyWatchpoint. This patch fixes the API so
it should work as expected. This patch also changes generateConditions in
ObjectPropertyConditionSet to use isStillValidAssumingImpurePropertyWatchpoint.
- bytecode/ObjectPropertyCondition.cpp:
(JSC::ObjectPropertyCondition::structureEnsuresValidityAssumingImpurePropertyWatchpoint):
(JSC::ObjectPropertyCondition::isStillValidAssumingImpurePropertyWatchpoint):
- bytecode/ObjectPropertyCondition.h:
- bytecode/ObjectPropertyConditionSet.cpp:
- 12:21 PM Changeset in webkit [201609] by
-
- 4 edits in trunk/Source
Make it harder to accidentally pass an integer to a locker.
Rubber stamped by Keith Miller.
Source/JavaScriptCore:
- runtime/ConcurrentJITLock.h:
(JSC::ConcurrentJITLocker::ConcurrentJITLocker):
Source/WTF:
See here for the discussion: https://bugs.webkit.org/show_bug.cgi?id=158306#c3
- wtf/Locker.h:
(WTF::Locker::Locker):
(WTF::Locker::~Locker):
- 12:05 PM Changeset in webkit [201608] by
-
- 5 edits2 adds in trunk
Fix a couple of mistakes in CSSParserValue memory management
https://bugs.webkit.org/show_bug.cgi?id=158307
<rdar://problem/26127225>
Source/WebCore:
Patch by Darin Adler <Darin Adler> on 2016-06-02
Reviewed by Daniel Bates.
- css/CSSGrammar.y.in: Added a destructor for calc_func_term. This presumably
fixes some memory leaks in error cases. Removed an assertion about not needing
a call to destroy that was far too limited. Tweaked formatting of the percentage
ase in the key production. Indented calc_func_term to make it consistent with
other productions nearby.
- css/CSSParserValues.cpp:
(WebCore::CSSParserValueList::~CSSParserValueList): Use a modern for loop.
(WebCore::CSSParserValueList::deleteValueAt): Deleted. Unused function, and also
would have resulted in a memory leak unless the code already extracted the value
from the list.
(WebCore::CSSParserValueList::extend): Properly transfer ownership from one value
list to the other by setting the unit to 0 in the donor.
- css/CSSParserValues.h: Removed unused deleteValueAt function.
LayoutTests:
Reviewed by Darin Adler.
- fast/css/calc-with-two-variables-crash-expected.txt: Added.
- fast/css/calc-with-two-variables-crash.html: Added.
- 12:04 PM Changeset in webkit [201607] by
-
- 3 edits in trunk/Websites/perf.webkit.org
Build fix after r201564.
- public/v3/pages/analysis-category-page.js:
(AnalysisCategoryPage.prototype.updateFromSerializedState):
- public/v3/pages/create-analysis-task-page.js:
(CreateAnalysisTaskPage.prototype.updateFromSerializedState):
(CreateAnalysisTaskPage.prototype.render):
- 11:42 AM Changeset in webkit [201606] by
-
- 2 edits in trunk/Tools
LayoutTests time out intermittently due to alert about reopening Simulator after it unexpectedly quit
https://bugs.webkit.org/show_bug.cgi?id=158305
Reviewed by Alexey Proskuryakov.
- Scripts/webkitpy/port/ios.py:
(IOSSimulatorPort.clean_up_test_run): Delete simulator's savedState directories during cleanup.
- 11:41 AM Changeset in webkit [201605] by
-
- 5 edits in trunk/Source
Make it easier to use NoLockingNecessary
https://bugs.webkit.org/show_bug.cgi?id=158306
Reviewed by Keith Miller.
Source/JavaScriptCore:
Adapt to the new NoLockingNecessary API. More details in the WTF ChangeLog.
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::BytecodeGenerator):
(JSC::BytecodeGenerator::initializeArrowFunctionContextScopeIfNeeded):
(JSC::BytecodeGenerator::instantiateLexicalVariables):
(JSC::BytecodeGenerator::emitPrefillStackTDZVariables):
(JSC::BytecodeGenerator::initializeBlockScopedFunctions):
(JSC::BytecodeGenerator::hoistSloppyModeFunctionIfNecessary):
(JSC::BytecodeGenerator::popLexicalScopeInternal):
(JSC::BytecodeGenerator::prepareLexicalScopeForNextForLoopIteration):
(JSC::BytecodeGenerator::variable):
(JSC::BytecodeGenerator::createVariable):
(JSC::BytecodeGenerator::emitResolveScope):
(JSC::BytecodeGenerator::emitPushFunctionNameScope):
- runtime/ConcurrentJITLock.h:
(JSC::ConcurrentJITLockerBase::ConcurrentJITLockerBase):
(JSC::ConcurrentJITLocker::ConcurrentJITLocker):
Source/WTF:
An idiom that we borrowed from LLVM is that if a function requires a lock to be held, we
have it take a const Locker& as its first argument. This may not communicate which lock is
to be held, but it does help us to remember that some lock must be held. So far, it's been
relatively easy to then figure out which lock. We've had bugs where we forgot to hold a
lock but I don't remember the last time we had a bug where we grabbed the wrong lock.
But sometimes, we know at the point where we call such a method that we actually don't
need to hold any lock. This usually happens during object construction. If we're
constructing some object then we usually know that we have not escaped it yet, so we don't
need to waste time acquiring its lock. We could solve this by having a separate set of
methods that don't do or require locking. This would be cumbersome, since usually for
every variant that takes const Locker&, there is already one that doesn't, and that one
will grab the lock for you. So this means having a third variant, that also doesn't take a
const Locker&, but does no locking. That's pretty weird.
So, we introduced NoLockingNecessary for situations like this. The idiom went like so:
Locker<Whatever> locker(Locker<Whatever>::NoLockingNecessary)
stuff->foo(locker);
Usually though, there would be some distance between where the locker is defined and where
it's used, so when you just look at stuff->foo(locker) in isolation you don't know if this
is a real locker or a NoLockingNecessary cast. Also, requiring two lines for this just
adds code.
This change makes this easier. Now you can just do:
stuff->foo(NoLockingNecessary).
This is because NoLockingNecessary has been pulled out into the WTF namespace (and is
usinged from the global namespace) and the Locker<> constructor that takes
NoLockingNecessaryTag is now implicit.
The only possible downside of this change is that people might use this idiom more
frequently now that it's easier to use. I don't think that's a bad thing. I'm now
convinced that this is not a bad idiom. When I was fixing an unrelated bug, I almost went
the way of adding more locking to some core JSC data structures, and in the process, I
needed to use NoLockingNecessary. It's clear that this is a general-purpose idiom and we
should not impose artificial constraints on its use.
- wtf/Locker.h:
(WTF::Locker::Locker):
(WTF::Locker::~Locker):
- 11:40 AM Changeset in webkit [201604] by
-
- 3 edits2 adds in trunk
SVG content renders in incorrect vertical position when padding-left is not specified
https://bugs.webkit.org/show_bug.cgi?id=158234
Patch by Said Abou-Hallawa <sabouhallawa@apple.com> on 2016-06-02
Reviewed by Darin Adler.
Source/WebCore:
Fix the optimization in RenderSVGRoot::buildLocalToBorderBoxTransform().
Use LayoutSize::isZero() instead of LayoutSize::isEmpty() to decide whether
there is borderAndPadding applied or not.
Test: svg/custom/svg-root-padding-individual.html
- rendering/svg/RenderSVGRoot.cpp:
(WebCore::RenderSVGRoot::buildLocalToBorderBoxTransform):
LayoutTests:
Make sure the SVG root element is positioned correctly when either the sum
of its (leftPadding + rightPadding) or the sum of its (topPadding + bottomPadding)
is equal to zero.
- svg/custom/svg-root-padding-individual-expected.html: Added.
- svg/custom/svg-root-padding-individual.html: Added.
- 11:17 AM Changeset in webkit [201603] by
-
- 14 edits in trunk/Source
Overhaul cross-thread use of ResourceRequest, ResourceResponse, and ResourceError.
https://bugs.webkit.org/show_bug.cgi?id=158293
Reviewed by Darin Adler.
Source/WebCore:
No new tests (Refactor, no behavior change).
- loader/WorkerThreadableLoader.cpp:
(WebCore::WorkerThreadableLoader::MainThreadBridge::MainThreadBridge):
(WebCore::WorkerThreadableLoader::MainThreadBridge::didReceiveResponse):
(WebCore::WorkerThreadableLoader::MainThreadBridge::didFail):
(WebCore::WorkerThreadableLoader::MainThreadBridge::didFailAccessControlCheck):
- loader/cache/MemoryCache.cpp:
(WebCore::MemoryCache::removeRequestFromSessionCaches):
- platform/network/ResourceErrorBase.cpp:
(WebCore::ResourceErrorBase::isolatedCopy):
(WebCore::ResourceErrorBase::copy): Deleted.
- platform/network/ResourceErrorBase.h:
- platform/network/ResourceRequestBase.cpp:
(WebCore::ResourceRequestBase::isolatedCopy):
(WebCore::ResourceRequestBase::setAsIsolatedCopy):
(WebCore::ResourceRequestBase::adopt): Deleted.
Made copyData private, and made "adopt" be "isolatedCopy".
Rest of the changes are all re-indenting the file.
- platform/network/ResourceRequestBase.h:
(WebCore::ResourceRequestBase::responseContentDispositionEncodingFallbackArray):
(WebCore::ResourceRequestBase::reportUploadProgress):
(WebCore::ResourceRequestBase::setReportUploadProgress):
(WebCore::ResourceRequestBase::reportLoadTiming):
(WebCore::ResourceRequestBase::setReportLoadTiming):
(WebCore::ResourceRequestBase::reportRawHeaders):
(WebCore::ResourceRequestBase::setReportRawHeaders):
(WebCore::ResourceRequestBase::hiddenFromInspector):
(WebCore::ResourceRequestBase::setHiddenFromInspector):
(WebCore::ResourceRequestBase::requester):
(WebCore::ResourceRequestBase::setRequester):
(WebCore::ResourceRequestBase::encodingRequiresPlatformData):
(WebCore::ResourceRequestBase::ResourceRequestBase):
(WebCore::ResourceRequestBase::platformCompare):
(WebCore::operator==):
(WebCore::operator!=):
- platform/network/ResourceResponseBase.cpp:
(WebCore::ResourceResponseBase::isolatedCopy):
(WebCore::ResourceResponseBase::adopt): Deleted.
- platform/network/ResourceResponseBase.h:
- platform/network/cf/ResourceError.h:
(WebCore::ResourceError::isolatedCopy): Deleted.
Removed platform-specific isolatedCopy, and re-indented the header:
- platform/network/cf/ResourceRequest.h:
(WebCore::ResourceRequest::ResourceRequest):
(WebCore::ResourceRequest::encodingRequiresPlatformData):
(WebCore::ResourceRequest::cachePartition):
(WebCore::ResourceRequest::setCachePartition):
(WebCore::ResourceRequest::setDomainForCachePartition):
(WebCore::ResourceRequest::resourcePrioritiesEnabled):
(WebCore::ResourceRequest::isolatedCopy): Deleted.
- platform/network/cf/ResourceResponse.h:
(WebCore::ResourceResponse::isolatedCopy): Deleted.
Source/WebKit2:
- NetworkProcess/cache/NetworkCacheEntry.cpp:
(WebKit::NetworkCache::Entry::Entry):
- 10:59 AM Changeset in webkit [201602] by
-
- 12 edits in trunk/Source
Modernize various lambda captures
https://bugs.webkit.org/show_bug.cgi?id=158292
Reviewed by Brady Eidson.
Modernize various lambda captures, especially the ones unnecessarily
allocating objects on the heap and destroying them in the lambda.
Source/WebCore:
- Modules/websockets/ThreadableWebSocketChannelClientWrapper.cpp:
(WebCore::ThreadableWebSocketChannelClientWrapper::didConnect):
(WebCore::ThreadableWebSocketChannelClientWrapper::didReceiveMessage):
(WebCore::ThreadableWebSocketChannelClientWrapper::didReceiveBinaryData):
(WebCore::ThreadableWebSocketChannelClientWrapper::didUpdateBufferedAmount):
(WebCore::ThreadableWebSocketChannelClientWrapper::didStartClosingHandshake):
(WebCore::ThreadableWebSocketChannelClientWrapper::didClose):
(WebCore::ThreadableWebSocketChannelClientWrapper::didReceiveMessageError):
(WebCore::ThreadableWebSocketChannelClientWrapper::processPendingTasks):
(WebCore::ThreadableWebSocketChannelClientWrapper::resume): Deleted.
- Modules/websockets/WorkerThreadableWebSocketChannel.cpp:
(WebCore::WorkerThreadableWebSocketChannel::Bridge::disconnect):
- bindings/js/JSCallbackData.h:
(WebCore::DeleteCallbackDataTask::DeleteCallbackDataTask):
- loader/WorkerThreadableLoader.cpp:
(WebCore::WorkerThreadableLoader::MainThreadBridge::MainThreadBridge):
(WebCore::WorkerThreadableLoader::MainThreadBridge::destroy):
(WebCore::WorkerThreadableLoader::MainThreadBridge::didSendData):
(WebCore::WorkerThreadableLoader::MainThreadBridge::didReceiveResponse):
(WebCore::WorkerThreadableLoader::MainThreadBridge::didReceiveData):
(WebCore::WorkerThreadableLoader::MainThreadBridge::didFinishLoading):
(WebCore::WorkerThreadableLoader::MainThreadBridge::didFail):
(WebCore::WorkerThreadableLoader::MainThreadBridge::didFailAccessControlCheck):
(WebCore::WorkerThreadableLoader::MainThreadBridge::didFailRedirectCheck):
(WebCore::WorkerThreadableLoader::MainThreadBridge::cancel): Deleted.
Source/WebKit2:
- NetworkProcess/NetworkProcess.cpp:
(WebKit::fetchDiskCacheEntries):
(WebKit::clearDiskCacheEntries):
(WebKit::NetworkProcess::fetchWebsiteData): Deleted.
- NetworkProcess/cache/NetworkCache.cpp:
(WebKit::NetworkCache::Cache::traverse):
- NetworkProcess/cache/NetworkCache.h:
- NetworkProcess/cache/NetworkCacheStorage.cpp:
(WebKit::NetworkCache::Storage::TraverseOperation::TraverseOperation):
- NetworkProcess/cache/NetworkCacheStorage.h:
- 10:50 AM Changeset in webkit [201601] by
-
- 10 edits in trunk
WebRTC: Update RTCPeerConnection.addTrack() to create (or reuse) an RTCRtpTransceiver
https://bugs.webkit.org/show_bug.cgi?id=158191
Reviewed by Eric Carlson.
Source/WebCore:
Update RTCPeerConnection.addTrack to create an RTCRtpTranscevier, or reuse an existing
transceiver that has not been used to send [1].
A new RtpTransceiverSet type is added that wraps a vector of RTCRtpTransceiver objects
and internally maintains two lists for efficient access to RTCRtpSender and RTCRtpReceiver
objects.
[1] https://w3c.github.io/webrtc-pc/archives/20160513/webrtc.html#dom-rtcpeerconnection-addtrack
Updated existing test: fast/mediastream/RTCPeerConnection-add-removeTrack.html
- Modules/mediastream/PeerConnectionBackend.h:
- Modules/mediastream/RTCPeerConnection.cpp:
(WebCore::RTCPeerConnection::addTrack):
(WebCore::RTCPeerConnection::removeTrack):
(WebCore::RTCPeerConnection::completeAddTransceiver):
(WebCore::RTCPeerConnection::close):
- Modules/mediastream/RTCPeerConnection.h:
- Modules/mediastream/RTCRtpTransceiver.cpp:
(WebCore::RtpTransceiverSet::append):
- Modules/mediastream/RTCRtpTransceiver.h:
(WebCore::RtpTransceiverSet::list):
(WebCore::RtpTransceiverSet::getSenders):
(WebCore::RtpTransceiverSet::getReceivers):
LayoutTests:
Extend existing test to verify the created RTCRtpTransceiver object.
- fast/mediastream/RTCPeerConnection-add-removeTrack-expected.txt:
- fast/mediastream/RTCPeerConnection-add-removeTrack.html:
Add checks for bad argument lists and verify the created RTCRtpTransceiver.
- 9:40 AM Changeset in webkit [201600] by
-
- 3 edits in trunk/Source/WebKit2
Speculative revalidated request returns 200 instead of 304
https://bugs.webkit.org/show_bug.cgi?id=158256
Reviewed by Antti Koivisto and Carlos Garcia Campos.
Already conditional requests coming from WebCore should bypass the
SpeculativeLoadManager. This is because the validation is requested
by WebCore (usually the memory cache) and not our network cache. As
a result, we need to pipe the revalidation response (e.g. 304 status
code) back to WebCore instead of resolving it as disk cache level.
This should fix the /webkit2/WebKitWebResource/response unit test.
- NetworkProcess/cache/NetworkCache.cpp:
(WebKit::NetworkCache::Cache::retrieve):
- NetworkProcess/cache/NetworkCacheSpeculativeLoadManager.cpp:
(WebKit::NetworkCache::requestsHeadersMatch):
- 5:03 AM Changeset in webkit [201599] by
-
- 2 edits in trunk/LayoutTests
Unreviewed test gardening.
Unskip websocket tests passing after r201500.
- platform/win/TestExpectations:
- 3:33 AM Changeset in webkit [201598] by
-
- 2 edits in trunk/LayoutTests
Unreviewed test gardening.
The test storage/indexeddb/modern/blob-simple.html is passing.
- platform/win/TestExpectations:
- 2:48 AM WebKitGTK/Gardening/Calendar edited by
- (diff)
- 2:31 AM Changeset in webkit [201597] by
-
- 5 edits1 add in trunk/LayoutTests
Unreviewed GTK+ gardening Additional rebaseline after r201397.
Added reference files for pixel tests.
- fast/forms/search-input-rtl-expected.txt:
- platform/gtk/fast/css/text-overflow-input-expected.png:
- platform/gtk/fast/forms/placeholder-position-expected.png:
- platform/gtk/fast/forms/search-input-rtl-expected.png: Added.
- platform/gtk/fast/forms/search-rtl-expected.png:
- 1:45 AM Changeset in webkit [201596] by
-
- 32 edits in trunk/Source
Source/WebCore:
Use more references in ResourceLoader related code
https://bugs.webkit.org/show_bug.cgi?id=158222
Reviewed by Darin Adler.
No change of behavior.
- css/CSSFontFaceSource.cpp:
(WebCore::CSSFontFaceSource::load):
- css/CSSFontSelector.cpp:
(WebCore::CSSFontSelector::clearDocument):
(WebCore::CSSFontSelector::beginLoadingFontSoon):
(WebCore::CSSFontSelector::beginLoadTimerFired):
- css/CSSFontSelector.h:
- loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::scheduleArchiveLoad):
- loader/DocumentLoader.h:
- loader/LoaderStrategy.h:
- loader/NetscapePlugInStreamLoader.cpp:
(WebCore::NetscapePlugInStreamLoader::NetscapePlugInStreamLoader):
(WebCore::NetscapePlugInStreamLoader::create):
- loader/NetscapePlugInStreamLoader.h:
- loader/ResourceLoader.cpp:
(WebCore::ResourceLoader::ResourceLoader):
(WebCore::ResourceLoader::start):
- loader/ResourceLoader.h:
- loader/SubresourceLoader.cpp:
(WebCore::SubresourceLoader::RequestCountTracker::RequestCountTracker):
(WebCore::SubresourceLoader::SubresourceLoader):
(WebCore::SubresourceLoader::create):
(WebCore::SubresourceLoader::didReceiveResponse):
(WebCore::SubresourceLoader::notifyDone):
- loader/SubresourceLoader.h:
- loader/appcache/ApplicationCacheHost.cpp:
(WebCore::ApplicationCacheHost::maybeLoadResource):
- loader/appcache/ApplicationCacheHost.h:
- loader/cache/CachedResource.cpp:
(WebCore::CachedResource::load):
- loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::incrementRequestCount):
(WebCore::CachedResourceLoader::decrementRequestCount):
- loader/cache/CachedResourceLoader.h:
Source/WebKit:
Use more references in ResourceLoader related code
https://bugs.webkit.org/show_bug.cgi?id=158222
Reviewed by Darin Adler.
- WebCoreSupport/WebResourceLoadScheduler.cpp:
(WebResourceLoadScheduler::loadResource):
- WebCoreSupport/WebResourceLoadScheduler.h:
Source/WebKit/mac:
Add WebIDL special operation support: serializer
https://bugs.webkit.org/show_bug.cgi?id=156293
Reviewed by Darin Adler.
- Plugins/Hosted/HostedNetscapePluginStream.mm:
(WebKit::HostedNetscapePluginStream::start):
- Plugins/WebNetscapePluginStream.mm:
(WebNetscapePluginStream::start):
Source/WebKit/win:
Use more references in ResourceLoader related code
https://bugs.webkit.org/show_bug.cgi?id=158222
Reviewed by Darin Adler.
- Plugins/PluginStream.cpp:
(WebCore::PluginStream::start):
Source/WebKit2:
Use more references in ResourceLoader related code
https://bugs.webkit.org/show_bug.cgi?id=158222
Reviewed by Darin Adler.
- WebProcess/Network/WebLoaderStrategy.cpp:
(WebKit::WebLoaderStrategy::loadResource):
(WebKit::WebLoaderStrategy::schedulePluginStreamLoad):
(WebKit::WebLoaderStrategy::scheduleLoad):
(WebKit::WebLoaderStrategy::scheduleInternallyFailedLoad):
(WebKit::WebLoaderStrategy::startLocalLoad):
(WebKit::WebLoaderStrategy::networkProcessCrashed):
- WebProcess/Network/WebLoaderStrategy.h:
- WebProcess/Network/WebResourceLoader.cpp:
(WebKit::WebResourceLoader::create):
(WebKit::WebResourceLoader::WebResourceLoader):
- WebProcess/Network/WebResourceLoader.h:
- WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::Stream::start):
- 12:36 AM Changeset in webkit [201595] by
-
- 2 edits in trunk/Source/WebCore
[Wayland] PlatformDisplayWayland destructor is super crashy
https://bugs.webkit.org/show_bug.cgi?id=157973
Reviewed by Michael Catanzaro.
EGL registers two at exist callbacks one to finish the display and another one to unload drivers, the one to
finish the display happens first. When our destructor is called the _eglFiniDisplay callback has already been
called, so we have a valid pointer for an already finished display. Then eglTerminate tries to find the display
in the global display list, but fails and for some reason it crashes when trying to return an error.
If atexit is called after the global PlatformDisplay constructor, the atexit handler is called before the
destructor. The atexit callbacks are called in reverse order, so if we register an atexit handler after the
global instace has been created and after EGL has been initialized, we could terminate the EGL display before
the EGL atexit handlers and the global PlatformDisplay destructor.
- platform/graphics/PlatformDisplay.cpp:
(WebCore::PlatformDisplay::initializeEGLDisplay):
Jun 1, 2016:
- 10:47 PM Changeset in webkit [201594] by
-
- 10 edits in trunk/Source
Get rid of StringCapture.
https://bugs.webkit.org/show_bug.cgi?id=158285
Reviewed by Chris Dumez.
Source/WebCore:
No new tests (Refactor, no behavior change).
- dom/Document.cpp:
(WebCore::Document::addConsoleMessage):
(WebCore::Document::addMessage):
- dom/ScriptExecutionContext.h:
(WebCore::ScriptExecutionContext::AddConsoleMessageTask::AddConsoleMessageTask):
- loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::installContentFilterUnblockHandler):
- loader/WorkerThreadableLoader.cpp:
(WebCore::WorkerThreadableLoader::MainThreadBridge::MainThreadBridge):
- platform/ios/WebVideoFullscreenControllerAVKit.mm:
(WebVideoFullscreenControllerContext::setExternalPlayback):
- workers/WorkerGlobalScope.cpp:
(WebCore::WorkerGlobalScope::addConsoleMessage):
(WebCore::WorkerGlobalScope::addMessage):
- workers/WorkerMessagingProxy.cpp:
(WebCore::WorkerMessagingProxy::postExceptionToWorkerObject):
(WebCore::WorkerMessagingProxy::postConsoleMessageToWorkerObject):
Source/WTF:
- wtf/text/WTFString.h:
(WTF::StringCapture::StringCapture): Deleted.
(WTF::StringCapture::string): Deleted.
(WTF::StringCapture::releaseString): Deleted.
(WTF::StringCapture::operator=): Deleted.
- 10:39 PM Changeset in webkit [201593] by
-
- 2 edits in trunk/Source/WebKit2
Notify client immediately if network session doesn't exist for a synchronous XHR load.
https://bugs.webkit.org/show_bug.cgi?id=158239
<rdar://problem/26344251>
Patch by Yongjun Zhang <yongjun_zhang@apple.com> on 2016-06-01
Reviewed by Brady Eidson.
For a synchronous XHR load, if the network session doesn't exist, we should notify NetworkLoadClient.
Otherwise the Web process could hang when waiting for the synchronous load to finish.
- NetworkProcess/NetworkLoad.cpp:
(WebKit::NetworkLoad::NetworkLoad):
- 10:21 PM Changeset in webkit [201592] by
-
- 4 edits2 adds in trunk
REGRESSION(r191907): Can't enter combining diacritic marks in Web Inspector fields
https://bugs.webkit.org/show_bug.cgi?id=158227
<rdar://problem/26232464>
Source/WebKit2:
Reviewed by Darin Adler and Alexey Proskuryakov.
Web Inspector uses a WKWebView subclass for the inspector frontend interface.
Since r191907, WKWebView does not have an inner WKView, and instead shares
a WebViewImpl to implement the same methods as WKView. So, WKView is no longer
involved at all when delivering keystrokes to the Web Inspector interface.
This caused a subtle regression where some keystrokes were not being interpreted
in the same way by AppKit because WKWebView does not conform to NSTextInputClient
but WKView does. AppKit won't automatically create a NSTextInputContext for a NSView
unless the subclass is declared as conforming to NSTextInputClient. Thus, the keystroke
never goes through NSTextInputContext machinery which converts the keystroke into
a combining diacritic character.
This regression is covered by a new API test.
- UIProcess/API/Cocoa/WKWebView.mm: mark WKWebView as conforming to NSTextInputClient.
Tools:
Reviewed by Alexey Proskuryakov.
Add a regression test that runs on Mac only.
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewTextInput.mm: Added.
(-[DummyNavigationDelegate webView:didFinishNavigation:]):
(TEST):
- TestWebKitAPI/Tests/WebKit2Cocoa/editable-body.html: Added.
- 9:38 PM Changeset in webkit [201591] by
-
- 2 edits in trunk/Source/WebKit2
Try to fix ENABLE(IOS_TOUCH_EVENTS) builds.
- WebProcess/WebPage/EventDispatcher.cpp:
(WebKit::EventDispatcher::touchEvent):
- 9:26 PM Changeset in webkit [201590] by
-
- 3 edits in trunk/Source/JavaScriptCore
Structure::previousID() races with Structure::allocateRareData()
https://bugs.webkit.org/show_bug.cgi?id=158280
Reviewed by Mark Lam.
The problem is that previousID() would test hasRareData() and then either load the
previous Structure from the rare data, or load it directly. allocateRareData() would set
the hasRareData() bit separately from moving the Structure pointer into the rare data. So
we'd have a race that would cause previousID() to sometimes return the rarae data instead
of the previous Structure.
The fix is to get rid of the hasRareData bit. We can use the structureID of the
previousOrRareData cell to determine if it's the previousID or the RareData. This fixes the
race and it's probably not any slower.
- runtime/Structure.cpp:
(JSC::Structure::Structure):
(JSC::Structure::allocateRareData):
- runtime/Structure.h:
- 9:07 PM Changeset in webkit [201589] by
-
- 2 edits1 add in trunk/Source/JavaScriptCore
Runaway WebContent process CPU & memory @ foxnews.com
https://bugs.webkit.org/show_bug.cgi?id=158290
Reviewed by Mark Lam.
Clear the thrown value at the end of the catch block so that the stack scanner won't
find the value during GC.
Added a new stress test.
- bytecompiler/NodesCodegen.cpp:
(JSC::TryNode::emitBytecode):
- tests/stress/recursive-try-catch.js: Added.
(logError):
(tryCallingBadFunction):
(recurse):
(test):
- 9:01 PM Changeset in webkit [201588] by
-
- 52 edits in trunk/Source
Audit RenderObject casts and fix problems and style issues found
https://bugs.webkit.org/show_bug.cgi?id=158221
Reviewed by Chris Dumez.
Source/WebCore:
- bindings/objc/DOM.mm:
(-[DOMElement image]): Use auto to get more specific types in code getting
the renderer for an element instead of dumbing down the type to RenderObject.
- dom/Element.cpp:
(WebCore::Element::scrollByUnits): Call renderer only once. The comment in
Node advises we should do this since it has a branch in it.
(WebCore::Element::absoluteEventBounds): Call renderer only once. Also use
auto for a rect type to clarify that we are not changing the type of the
rect returned by the fucntion.
(WebCore::Element::webkitGetRegionFlowRanges): Call renderer only once.
- editing/CompositeEditCommand.cpp:
(WebCore::CompositeEditCommand::addBlockPlaceholderIfNeeded): Use auto
to get a mroe specific renderer type.
- editing/SimplifyMarkupCommand.cpp:
(WebCore::SimplifyMarkupCommand::doApply): Call renderer only once.
- editing/cocoa/HTMLConverter.mm:
(HTMLConverter::_addAttachmentForElement): Add an obviously missing
null check for something that is null checked elsewhere.
(fileWrapperForURL): Ditto.
(fileWrapperForElement): Changed argument type to HTMLImageElement& since
the call site already checks the type of the object. Use HTMLImageElement::src
instead of repeating the code here. Check the type of the renderer instead of
assuming it's a RenderImage.
(WebCore::editingAttributedStringFromRange): Pass a reference, not a pointer.
- html/HTMLAnchorElement.cpp:
(WebCore::appendServerMapMousePosition): Take a reference to an event rather
than a "known to be non-null" pointer. Call renderer only once. Round the
floating point values rather than truncating them.
(WebCore::HTMLAnchorElement::handleClick): Pass a reference.
- html/HTMLAttachmentElement.cpp:
(WebCore::HTMLAttachmentElement::setFile): Removed the now-unneeded cast since
the renderer function returns a pointer of a more specific type now.
(WebCore::HTMLAttachmentElement::parseAttribute): Ditto.
(WebCore::HTMLAttachmentElement::attachmentTitle): Use auto& to avoid a bit of
reference count churn.
- html/HTMLAttachmentElement.h: Override renderer to return a more specific type.
This follows the pattern that ContainerNode::renderer uses.
- html/HTMLButtonElement.h: Ditto.
- html/HTMLCanvasElement.cpp: Gave the constants at the top of the file more
normal names. Removed unneeded "static" from them. Moved the
defaultInterpolationQuality constant here from the header because it doesn't
need to be there.
(WebCore::HTMLCanvasElement::HTMLCanvasElement): Updated for name changes.
(WebCore::HTMLCanvasElement::createElementRenderer): Removed unneeded code to
set m_rendererIsCanvas to record renderer type; we can just check the type.
(WebCore::HTMLCanvasElement::setHeight): Updated for name changes.
(WebCore::HTMLCanvasElement::setWidth): Ditto.
(WebCore::HTMLCanvasElement::reset): Check the type of the renderer directly
instead of calling m_rendererIsCanvas. This helped make it clear we were
do extra unneeded checks since a renderer can't both be a RenderCanvas and
not be a RenderBox.
(WebCore::HTMLCanvasElement::createImageBuffer): Updated for name changes.
- html/HTMLCanvasElement.h: Moved DefaultInterpolationQuality into the cpp file.
Use nullptr instead of 0. Removed m_rendererIsCanvas.
- html/HTMLFieldSetElement.cpp:
(WebCore::HTMLFieldSetElement::HTMLFieldSetElement): Initialize m_documentVersion
in the class definition.
(WebCore::HTMLFieldSetElement::~HTMLFieldSetElement): Use m_hasDisabledAttribute.
(WebCore::updateFromControlElementsAncestorDisabledStateUnder): Fixed typo.
(WebCore::HTMLFieldSetElement::disabledAttributeChanged): Fixed mistake in this
function that would cause the number of disabled fieldset elements to be too high
if the disabled attribute's value was changed from one value to another. Use a
boolean to track the old value; can't think of a solution that works without that.
(WebCore::HTMLFieldSetElement::childrenChanged): Fixed typo.
(WebCore::HTMLFieldSetElement::didMoveToNewDocument): Use m_hasDisabledAttribute.
(WebCore::HTMLFieldSetElement::updateAssociatedElements): Changed name to make it
clearer what this function does. Tweaked a bit without changing behavior.
(WebCore::HTMLFieldSetElement::associatedElements): Updated for name change.
(WebCore::HTMLFieldSetElement::length): Changed to call associatedElements instead of
repeating that it does.
- html/HTMLFieldSetElement.h: Override renderer to return a more specific type.
Also updated for other changes mentioned above.
- html/HTMLFrameElement.cpp:
(WebCore::HTMLFrameElement::HTMLFrameElement): Initialize booleans in the class
definition rather than doing it here.
(WebCore::HTMLFrameElement::parseAttribute): Call renderer only once.
- html/HTMLFrameElement.h: Override renderer to return a more specific type.
Also initialize some booleans in the class definition.
- html/HTMLIFrameElement.h: Override renderer to return a more specific type.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::updateRenderer): Added. Helper for a common idiom.
(WebCore::HTMLMediaElement::didAttachRenderers): Use auto to get a more specific
type for the renderer.
(WebCore::HTMLMediaElement::willDetachRenderers): Call renderer only once.
(WebCore::HTMLMediaElement::didRecalcStyle): Use updateRenderer to call renderer
only once.
(WebCore::HTMLMediaElement::loadResource): Ditto.
(WebCore::HTMLMediaElement::waitForSourceChange): Ditto.
(WebCore::HTMLMediaElement::noneSupported): Ditto.
(WebCore::HTMLMediaElement::setReadyState): Ditto.
(WebCore::HTMLMediaElement::progressEventTimerFired): Ditto.
(WebCore::HTMLMediaElement::selectNextSourceChild): Renamed goto label to use a style
that fits WebKit coding style. Call renderer only once in MediaQuery code.
(WebCore::HTMLMediaElement::mediaPlayerRepaint): Call renderer only once.
(WebCore::HTMLMediaElement::mediaPlayerSizeChanged): Use updateRenderer to call
renderer only once.
(WebCore::HTMLMediaElement::mediaPlayerRenderingCanBeAccelerated): Call renderer
only once.
(WebCore::HTMLMediaElement::mediaPlayerGraphicsDeviceAdapter): Call page only once.
(WebCore::HTMLMediaElement::mediaEngineWasUpdated): Use updateRenderer to call
renderer only once.
(WebCore::HTMLMediaElement::mediaPlayerCharacteristicChanged): Ditto.
(WebCore::HTMLMediaElement::updatePlayState): Ditto.
(WebCore::HTMLMediaElement::stopWithoutDestroyingMediaPlayer): Ditto.
(WebCore::HTMLMediaElement::resume): Ditto.
(WebCore::HTMLMediaElement::mediaPlayerContentBoxRect): Call renderer only once.
(WebCore::mediaElementIsAllowedToAutoplay): Use auto to get a more specific type.
- html/HTMLMediaElement.h: Removed conditionals around forward declarations.
Tweaked formatting a bit. Added the updateRender function. Override renderer to
return a more specific type.
- html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::optionElementChildrenChanged): Don't use the renderer
just to get to the document for the AXObjectCache.
(WebCore::HTMLSelectElement::setLength): Use auto for the list items vector.
(WebCore::HTMLSelectElement::nextValidIndex): Ditto.
(WebCore::HTMLSelectElement::firstSelectableListIndex): Ditto.
(WebCore::HTMLSelectElement::nextSelectableListIndexPageAway): Ditto. Also add a
null check for the renderer.
(WebCore::HTMLSelectElement::updateListBoxSelection): Split an assertion with &&
in it into two separate assertions. Use auto for the list items vector and use
a reference for the list items.
(WebCore::HTMLSelectElement::listBoxOnChange): Use auto for the list items vector
and use a reference for the list items.
(WebCore::HTMLSelectElement::setRecalcListItems): Don't use the renderer
just to get to the document for the AXObjectCache.
(WebCore::HTMLSelectElement::selectOption): Use auto for the list items vector.
(WebCore::HTMLSelectElement::optionToListIndex): Ditto.
(WebCore::HTMLSelectElement::listToOptionIndex): Ditto.
(WebCore::HTMLSelectElement::searchOptionsForValue): Ditto.
(WebCore::HTMLSelectElement::restoreFormControlState): Ditto.
(WebCore::HTMLSelectElement::platformHandleKeydownEvent): Call renderer only once.
(WebCore::HTMLSelectElement::menuListDefaultEventHandler): Split an assertion with
&& in it into two separate assertions. Use auto for the list items vector. Call
renderer only once.
(WebCore::HTMLSelectElement::updateSelectedState): Use a reference for the list
item.
(WebCore::HTMLSelectElement::listBoxDefaultEventHandler): Use auto for the list
items vvector. Call renderer less often; could not quite get it down to once.
(WebCore::HTMLSelectElement::defaultEventHandler): Call renderer only once.
(WebCore::HTMLSelectElement::lastSelectedListIndex): Use auto for the list items
vector and use a reference for the list items.
(WebCore::HTMLSelectElement::optionAtIndex): Use a reference for the list item.
(WebCore::HTMLSelectElement::accessKeySetSelectedIndex): Use auto for the list
items vector and use a reference for the list items.
(WebCore::HTMLSelectElement::length): Use auto for the list items vector.
- html/HTMLTextAreaElement.h: Override renderer to return a more specific type.
- html/HTMLVideoElement.cpp:
(WebCore::HTMLVideoElement::didAttachRenderers): Call renderer only once and
don't downcast it. There was no obvious type check because the renderer has a
guaranteed type, but this is now clearer because it's the renderer function
that returns a more specific type.
(WebCore::HTMLVideoElement::parseAttribute): Ditto.
(WebCore::HTMLVideoElement::setDisplayMode): Ditto.
- html/HTMLVideoElement.h: Override renderer to return a more specific type.
- html/HTMLWBRElement.h: Ditto.
- html/MediaElementSession.cpp:
(WebCore::MediaElementSession::canControlControlsManager): Removed
unneeded typecast in code that null checks a renderer.
(WebCore::isMainContent): Remove now-unneeded downcast of a renderer
obtained from an HTMLMediaElement. Fixed awkward formatting by splitting
an if statement into two.
(WebCore::isElementLargeEnoughForMainContent): Remove now unneeded downcast
of a renderer obtained from an HTMLMediaElement.
- html/TextFieldInputType.cpp:
(WebCore::TextFieldInputType::forwardEvent): Call renderer only once.
Also use auto more in the code rather than writing out types.
- html/shadow/SliderThumbElement.cpp:
(WebCore::SliderThumbElement::setPositionFromPoint): Used the renderBox
function more consistently for all the renderers used here; before,
some had null checks and others did not.
- html/shadow/TextControlInnerElements.cpp:
(WebCore::SearchFieldResultsButtonElement::defaultEventHandler): Use auto
a bit more.
- page/EventHandler.cpp:
(WebCore::enclosingScrollableArea): Removed a redundant null check and
stopped using the name "element" for a local variable that was not
always an element.
- page/PrintContext.cpp:
(WebCore::enclosingBoxModelObject): Rewrote loop to be simpler and tighter.
Also marked this inline since it's used only one place.
(WebCore::PrintContext::pageNumberForElement): Use auto for the return
value rather than writing out the type.
- page/SpatialNavigation.cpp:
(WebCore::isScrollableNode): Tighten the code and use auto a bit.
- platform/ios/WebVideoFullscreenControllerAVKit.mm: Add an include of
RenderVideo.h since this gets at the renderer for a video.
- rendering/RenderAttachment.h:
(WebCore::HTMLAttachmentElement::renderer): Added. Function is here because
it can only be called by code that includes this header. This matches the
pattern of RenderElement.h and ContainerNode::renderer.
- rendering/RenderFrame.cpp: Added now-needed include.
- rendering/RenderFrame.h:
(WebCore::HTMLFrameElement::renderer): Added. Same logic as above.
- rendering/RenderLayerFilterInfo.cpp:
(WebCore::RenderLayer::FilterInfo::updateReferenceFilterClients): Use auto
a bit and call rendeer only once.
- rendering/RenderMedia.h:
(WebCore::HTMLMediaElement::renderer): Added. Same logic as above.
- rendering/RenderTextControlMultiLine.h:
(WebCore::HTMLTextAreaElement::renderer): Ditto.
- rendering/RenderVideo.cpp:
(WebCore::placeholder): Renamed. Tightened up argument type to match what
is passed at all the call sites. Use auto instead of RenderObject.
(WebCore::RenderVideo::offsetLeft): Use auto and the renamed function above.
(WebCore::RenderVideo::offsetTop): Ditto.
(WebCore::RenderVideo::offsetWidth): Ditto.
(WebCore::RenderVideo::offsetHeight): Ditto.
- rendering/RenderVideo.h:
(WebCore::HTMLVideoElement::renderer): Added. Same logic as above.
- svg/SVGGElement.cpp:
(WebCore::SVGGElement::createElementRenderer): Fixed typo.
- svg/SVGGraphicsElement.cpp:
(WebCore::SVGGraphicsElement::createElementRenderer): Removed
non-helpful oblique comment.
- svg/SVGPathElement.cpp:
(WebCore::SVGPathElement::createElementRenderer): Ditto.
Source/WebKit/mac:
- Misc/WebNSPasteboardExtras.mm:
(imageFromElement): Use auto and tighten the logic a bit.
(-[NSPasteboard _web_declareAndWriteDragImageForElement:URL:title:archive:source:]):
Use auto and added a comment about this not using imageFromElement.
- Plugins/WebBaseNetscapePluginView.mm:
(-[WebBaseNetscapePluginView _windowClipRect]): Consistently cast to
RenderEmbeddedObject, which is the class used for renderers for plug-ins.
(-[WebBaseNetscapePluginView inFlatteningPaint]): Ditto.
(-[WebBaseNetscapePluginView invalidatePluginContentRect:]): Ditto.
(-[WebBaseNetscapePluginView actualVisibleRectInWindow]): Ditto.
- WebCoreSupport/WebFrameLoaderClient.mm:
(WebFrameLoaderClient::createPlugin): Changed code so it does a null check
rather than assuming the renderer is non-null.
(WebFrameLoaderClient::createJavaAppletWidget): Ditto.
Source/WebKit2:
- Shared/WebRenderObject.cpp:
(WebKit::WebRenderObject::WebRenderObject): Tightened up the code that
builds the tree of objects; fewer local variables.
- WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::invalidateRect): Cast to RenderEmbeddedObject since
that is the class used for plug-ins.
(WebKit::PluginView::pluginProcessCrashed): Ditto.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::createPlugin): Ditto.
(WebKit::WebPage::plugInIsPrimarySize): Check the renderer for null here.
Did not change this to RenderEmbeddedObject, though, because I wasn't
absolute certain this is only called with that type of renderer.
- WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::rangeForWebSelectionAtPosition): Tweaked.
- 8:38 PM Changeset in webkit [201587] by
-
- 7 edits in trunk/Source/WebKit2
Modernize lambda usage for all callers of RunLoop::dispatch() (take 2).
https://bugs.webkit.org/show_bug.cgi?id=158277
Reviewed by Chris Dumez.
- NetworkProcess/cache/NetworkCache.cpp:
(WebKit::NetworkCache::Cache::deleteDumpFile):
- Platform/IPC/Connection.cpp:
(IPC::Connection::addWorkQueueMessageReceiver):
(IPC::Connection::removeWorkQueueMessageReceiver):
(IPC::Connection::invalidate):
(IPC::Connection::sendMessage):
(IPC::Connection::processIncomingMessage):
(IPC::Connection::postConnectionDidCloseOnConnectionWorkQueue):
- UIProcess/Storage/LocalStorageDatabaseTracker.cpp:
(WebKit::LocalStorageDatabaseTracker::LocalStorageDatabaseTracker):
- UIProcess/Storage/StorageManager.cpp:
(WebKit::StorageManager::createSessionStorageNamespace):
(WebKit::StorageManager::destroySessionStorageNamespace):
(WebKit::StorageManager::setAllowedSessionStorageNamespaceConnection):
(WebKit::StorageManager::cloneSessionStorageNamespace):
(WebKit::StorageManager::processDidCloseConnection):
- UIProcess/WebResourceLoadStatisticsStore.cpp:
(WebKit::WebResourceLoadStatisticsStore::readDataFromDiskIfNeeded):
- UIProcess/WebsiteData/WebsiteDataStore.cpp:
(WebKit::WebsiteDataStore::fetchData):
(WebKit::WebsiteDataStore::removeData):
- 8:34 PM Changeset in webkit [201586] by
-
- 5 edits3 adds in trunk
[JSC] Some setters for components of Date do not timeClip() their result
https://bugs.webkit.org/show_bug.cgi?id=158278
Source/JavaScriptCore:
rdar://problem/25131426
Patch by Benjamin Poulain <bpoulain@apple.com> on 2016-06-01
Reviewed by Geoffrey Garen.
Many of the setters where not doing timeClip() on the computed UTC
time since Epoch.
See http://www.ecma-international.org/ecma-262/6.0/#sec-date.prototype.setdate
and the following sections for the definition.
- runtime/DatePrototype.cpp:
(JSC::setNewValueFromTimeArgs):
(JSC::setNewValueFromDateArgs):
Source/WTF:
Unreviewed.
Patch by Benjamin Poulain <bpoulain@apple.com> on 2016-06-01
- wtf/DateMath.cpp:
(WTF::equivalentYearForDST): Deleted.
The assertion is bogus.
As the comments above explains, the function is completely wrong for years
outside [1900-2100].
The tests passing large values for years are failing (year <= maxYear).
The weird NaN test is a mystery. The old changelog does not explain it.
LayoutTests:
rdar://problem/25131426
Patch by Benjamin Poulain <bpoulain@apple.com> on 2016-06-01
Reviewed by Geoffrey Garen.
New test coverage for large values.
Note that some of those tests are still failing with this patch.
The reason is our code handling month and years is unable to deal
with values outside int32.
Changing that is a bit more complicated due to the number of users
of DateMath. I leave that for the future.
- js/date-timeClip-large-values-expected.txt: Added.
- js/date-timeClip-large-values.html: Added.
- js/script-tests/date-timeClip-large-values.js: Added.
- 8:19 PM Changeset in webkit [201585] by
-
- 2 edits in trunk/Source/WebCore
LayoutTest accessibility/ios-simulator/attributed-string-for-range.html failing on ios-simulator debug
https://bugs.webkit.org/show_bug.cgi?id=158279
Reviewed by Alexey Proskuryakov.
Just use the same description for debug and release. We're not getting any benefit from having two.
- accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:
(-[WebAccessibilityObjectWrapper description]):
- 8:18 PM Changeset in webkit [201584] by
-
- 6 edits in trunk/Source/JavaScriptCore
canOptimizeStringObjectAccess should use ObjectPropertyConditions rather than structure watchpoints
https://bugs.webkit.org/show_bug.cgi?id=158291
Reviewed by Benjamin Poulain.
The old StringObject primitive access code used structure watchpoints. This meant that
if you set a watchpoint on String.prototype prior to tiering up to the DFG then added
a new property to String.prototype then we would never use StringObject optimizations.
This made property caching in the LLInt bad because it meant we would watchpoint
String.prototype very early in the program, which hurt date-format-xpab.js since that
benchmark relies on the StringObject optimizations.
This patch also extends ObjectPropertyConditionSet to be able to handle a slotBase
equivalence condition. Since that makes the code for generating the DFG watchpoints
significantly cleaner.
- bytecode/ObjectPropertyCondition.cpp:
(JSC::ObjectPropertyCondition::structureEnsuresValidityAssumingImpurePropertyWatchpoint):
- bytecode/ObjectPropertyConditionSet.cpp:
(JSC::ObjectPropertyConditionSet::hasOneSlotBaseCondition):
(JSC::ObjectPropertyConditionSet::slotBaseCondition):
(JSC::generateConditionsForPrototypeEquivalenceConcurrently):
- bytecode/ObjectPropertyConditionSet.h:
- dfg/DFGGraph.cpp:
(JSC::DFG::Graph::isStringPrototypeMethodSane):
(JSC::DFG::Graph::canOptimizeStringObjectAccess):
- dfg/DFGGraph.h:
- 6:09 PM Changeset in webkit [201583] by
-
- 2 edits in trunk/Source/WebKit2
[iOS] Regression(r200972): Crash under WebKit::WebPage::selectTextWithGranularityAtPoint()
https://bugs.webkit.org/show_bug.cgi?id=158284
<rdar://problem/26573954>
Reviewed by Ryosuke Niwa.
range can be null but r200972 started dereferencing it without null
check. This patch adds a null check for range and uses the pre-r200972
code path if range is null.
- WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::selectTextWithGranularityAtPoint):
- 5:45 PM Changeset in webkit [201582] by
-
- 5 edits in branches/safari-601-branch/Source
Versioning.
- 5:43 PM Changeset in webkit [201581] by
-
- 5 edits in branches/safari-601.1.46-branch/Source
Versioning.
- 5:38 PM Changeset in webkit [201580] by
-
- 2 edits in tags/Safari-602.1.35/Source/WebCore
Merged r201576. rdar://problem/26584828
- 5:23 PM Changeset in webkit [201579] by
-
- 2 edits in trunk/Source/WebCore
Use HashMap::ensure() in DocumentOrderedMap::add()
https://bugs.webkit.org/show_bug.cgi?id=158283
Reviewed by Ryosuke Niwa.
Use HashMap::ensure() in DocumentOrderedMap::add() to avoid constructing
a MapEntry if the key is already present in the HashMap.
- dom/DocumentOrderedMap.cpp:
(WebCore::DocumentOrderedMap::add):
- 5:23 PM Changeset in webkit [201578] by
-
- 1 copy in tags/Safari-602.1.32.7
New tag.
- 5:22 PM Changeset in webkit [201577] by
-
- 1 copy in tags/Safari-601.1.46.144
New tag.
- 5:09 PM Changeset in webkit [201576] by
-
- 2 edits in trunk/Source/WebCore
Update QuartzCoreSPI.h for <rdar://problem/26584828>.
- platform/spi/cocoa/QuartzCoreSPI.h:
- 4:38 PM Changeset in webkit [201575] by
-
- 25 edits in trunk/Source
Modernize lambda usage for all callers of RunLoop::dispatch().
https://bugs.webkit.org/show_bug.cgi?id=158265
Reviewed by Chris Dumez.
Source/WebCore:
No new tests (Refactor, no behavior change).
- Modules/indexeddb/shared/InProcessIDBServer.cpp:
(WebCore::InProcessIDBServer::deleteDatabase):
(WebCore::InProcessIDBServer::didDeleteDatabase):
(WebCore::InProcessIDBServer::openDatabase):
(WebCore::InProcessIDBServer::didOpenDatabase):
(WebCore::InProcessIDBServer::didAbortTransaction):
(WebCore::InProcessIDBServer::didCommitTransaction):
(WebCore::InProcessIDBServer::didCreateObjectStore):
(WebCore::InProcessIDBServer::didDeleteObjectStore):
(WebCore::InProcessIDBServer::didClearObjectStore):
(WebCore::InProcessIDBServer::didCreateIndex):
(WebCore::InProcessIDBServer::didDeleteIndex):
(WebCore::InProcessIDBServer::didPutOrAdd):
(WebCore::InProcessIDBServer::didGetRecord):
(WebCore::InProcessIDBServer::didGetCount):
(WebCore::InProcessIDBServer::didDeleteRecord):
(WebCore::InProcessIDBServer::didOpenCursor):
(WebCore::InProcessIDBServer::didIterateCursor):
(WebCore::InProcessIDBServer::abortTransaction):
(WebCore::InProcessIDBServer::commitTransaction):
(WebCore::InProcessIDBServer::didFinishHandlingVersionChangeTransaction):
(WebCore::InProcessIDBServer::createObjectStore):
(WebCore::InProcessIDBServer::deleteObjectStore):
(WebCore::InProcessIDBServer::clearObjectStore):
(WebCore::InProcessIDBServer::createIndex):
(WebCore::InProcessIDBServer::deleteIndex):
(WebCore::InProcessIDBServer::putOrAdd):
(WebCore::InProcessIDBServer::getRecord):
(WebCore::InProcessIDBServer::getCount):
(WebCore::InProcessIDBServer::deleteRecord):
(WebCore::InProcessIDBServer::openCursor):
(WebCore::InProcessIDBServer::iterateCursor):
(WebCore::InProcessIDBServer::establishTransaction):
(WebCore::InProcessIDBServer::fireVersionChangeEvent):
(WebCore::InProcessIDBServer::didStartTransaction):
(WebCore::InProcessIDBServer::didCloseFromServer):
(WebCore::InProcessIDBServer::notifyOpenDBRequestBlocked):
(WebCore::InProcessIDBServer::databaseConnectionClosed):
(WebCore::InProcessIDBServer::abortOpenAndUpgradeNeeded):
(WebCore::InProcessIDBServer::didFireVersionChangeEvent):
(WebCore::InProcessIDBServer::openDBRequestCancelled):
(WebCore::InProcessIDBServer::confirmDidCloseFromServer):
(WebCore::InProcessIDBServer::getAllDatabaseNames):
(WebCore::InProcessIDBServer::didGetAllDatabaseNames):
- Modules/websockets/WebSocket.cpp:
(WebCore::WebSocket::connect):
- bindings/js/SerializedScriptValue.cpp:
(WebCore::SerializedScriptValue::writeBlobsToDiskForIndexedDBSynchronously):
- page/scrolling/ThreadedScrollingTree.cpp:
(WebCore::ThreadedScrollingTree::invalidate):
(WebCore::ThreadedScrollingTree::scrollingTreeNodeDidScroll):
(WebCore::ThreadedScrollingTree::currentSnapPointIndicesDidChange):
(WebCore::ThreadedScrollingTree::handleWheelEventPhase):
(WebCore::ThreadedScrollingTree::setActiveScrollSnapIndices):
(WebCore::ThreadedScrollingTree::deferTestsForReason):
(WebCore::ThreadedScrollingTree::removeTestDeferralForReason):
- platform/graphics/cocoa/FontCacheCoreText.cpp:
(WebCore::FontCache::platformPrecache):
- platform/graphics/mac/DisplayRefreshMonitorMac.cpp:
(WebCore::DisplayRefreshMonitorMac::displayLinkFired):
- platform/network/DataURLDecoder.cpp:
(WebCore::DataURLDecoder::createDecodeTask):
(WebCore::DataURLDecoder::decode):
Source/WebKit2:
- DatabaseProcess/DatabaseProcess.cpp:
(WebKit::DatabaseProcess::fetchWebsiteData):
(WebKit::DatabaseProcess::deleteWebsiteData):
(WebKit::DatabaseProcess::deleteWebsiteDataForOrigins):
- NetworkProcess/NetworkProcess.cpp:
(WebKit::fetchDiskCacheEntries):
(WebKit::NetworkProcess::fetchWebsiteData):
- NetworkProcess/cache/NetworkCacheStorage.cpp:
(WebKit::NetworkCache::Storage::remove):
(WebKit::NetworkCache::retrieveFromMemory):
- Platform/IPC/Connection.cpp:
(IPC::Connection::SyncMessageState::processIncomingMessage):
(IPC::Connection::processIncomingMessage):
(IPC::Connection::connectionDidClose):
(IPC::Connection::enqueueIncomingMessage):
- Platform/IPC/mac/ConnectionMac.mm:
(IPC::Connection::receiveSourceEventHandler):
- Shared/mac/CookieStorageShim.mm:
(-[WKNSURLSessionLocal _getCookieHeadersForTask:completionHandler:]):
- UIProcess/API/APIUserContentExtensionStore.cpp:
(API::UserContentExtensionStore::lookupContentExtension):
(API::UserContentExtensionStore::compileContentExtension):
(API::UserContentExtensionStore::removeContentExtension):
- UIProcess/Launcher/ProcessLauncher.cpp:
(WebKit::ProcessLauncher::ProcessLauncher):
- UIProcess/Launcher/mac/ProcessLauncherMac.mm:
(WebKit::connectToService):
- UIProcess/Storage/StorageManager.cpp:
(WebKit::StorageManager::getSessionStorageOrigins):
(WebKit::StorageManager::deleteSessionStorageOrigins):
(WebKit::StorageManager::deleteSessionStorageEntriesForOrigins):
(WebKit::StorageManager::getLocalStorageOrigins):
(WebKit::StorageManager::getLocalStorageOriginDetails):
(WebKit::StorageManager::deleteLocalStorageEntriesForOrigin):
(WebKit::StorageManager::deleteLocalStorageOriginsModifiedSince):
(WebKit::StorageManager::deleteLocalStorageEntriesForOrigins):
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::isWebProcessResponsive):
- UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::isResponsive):
- UIProcess/WebsiteData/WebsiteDataStore.cpp:
(WebKit::WebsiteDataStore::fetchData):
- WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
(WebKit::NetscapePlugin::pluginThreadAsyncCall):
- WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::unprotectPluginFromDestruction):
- WebProcess/WebPage/EventDispatcher.cpp:
(WebKit::EventDispatcher::wheelEvent):
(WebKit::EventDispatcher::gestureEvent):
(WebKit::EventDispatcher::touchEvent):
- WebProcess/WebPage/ViewUpdateDispatcher.cpp:
(WebKit::ViewUpdateDispatcher::visibleContentRectUpdate):
- 3:49 PM Changeset in webkit [201574] by
-
- 2 edits in trunk/Source/WebCore
REGRESSION(r201385) ASSERT in WebCore::HTMLMediaElement::updateActiveTextTrackCues + 5688
https://bugs.webkit.org/show_bug.cgi?id=158164
<rdar://problem/26498634>
Reviewed by Jer Noble.
No new tests, this prevents an assert in existing tests.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::~HTMLMediaElement): Call beginIgnoringTrackDisplayUpdateRequests
so we avoid doing unnecessary work triggered by destruction.
- 3:22 PM Changeset in webkit [201573] by
-
- 7 edits in trunk/Source/JavaScriptCore
Unreviewed, rolling in r201436.
https://bugs.webkit.org/show_bug.cgi?id=158143
r201562 should haved fixed the Dromaeo DOM core regression.
Restored changeset:
"REGRESSION: JSBench spends a lot of time transitioning
to/from dictionary"
https://bugs.webkit.org/show_bug.cgi?id=158045
http://trac.webkit.org/changeset/201436
- 2:43 PM Changeset in webkit [201572] by
-
- 2 edits in trunk/Source/WebCore
Fix iOS build.
- platform/spi/cg/CoreGraphicsSPI.h: No ColorSync on iOS.
- 2:43 PM Changeset in webkit [201571] by
-
- 2 edits in trunk/Source/WebCore
Crash under eventTargetRespectingTargetRules()
https://bugs.webkit.org/show_bug.cgi?id=158273
<rdar://problem/26343998>
Reviewed by Alex Christensen.
The code would call nodeOrHostIfPseudoElement(), which can return null
and then dereference it in eventTargetRespectingTargetRules() without
null check. This patch adds a null check. When the node is null, the
while loop after will do nothing and thus the target will not be used.
No new tests, we do not have a good reproduction case.
- dom/EventPath.cpp:
(WebCore::EventPath::EventPath):
- 2:40 PM Changeset in webkit [201570] by
-
- 14 edits in trunk/Source/WebCore
Unreviewed, rolling out r201551 and r201552.
https://bugs.webkit.org/show_bug.cgi?id=158275
This change caused 3 API tests to crash on ios-simulator
(Requested by ryanhaddad on #webkit).
Reverted changesets:
"Precache primary font in a secondary thread"
https://bugs.webkit.org/show_bug.cgi?id=158243
http://trac.webkit.org/changeset/201551
"Remove accidental fprintf."
http://trac.webkit.org/changeset/201552
Patch by Commit Queue <commit-queue@webkit.org> on 2016-06-01
- 2:31 PM Changeset in webkit [201569] by
-
- 2 edits in branches/safari-602.1.32-branch/Source/WebCore
Merge r201567. rdar://problem/25388848
- 2:27 PM Changeset in webkit [201568] by
-
- 6 edits2 adds in trunk
AX: iOS: VoiceOver can't access attachments in mail messages
https://bugs.webkit.org/show_bug.cgi?id=158198
Reviewed by Joanmarie Diggs.
Source/WebCore:
Replaced elements, like attachemnts, were not being exposed in the attributed string returned to VoiceOver.
Make sure they are exposed with the attachment character, pointing to the actual element.
Test: accessibility/ios-simulator/attributed-string-for-range.html
- accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:
(AccessibilityUnignoredAncestor):
(-[WebAccessibilityObjectWrapper _stringForRange:attributed:]):
Tools:
- DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
(AccessibilityUIElement::stringForRange):
(AccessibilityUIElement::attributedStringForRange):
(AccessibilityUIElement::attributedStringRangeIsMisspelled):
- WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
(WTR::AccessibilityUIElement::attributedStringForRange):
(WTR::AccessibilityUIElement::attributedStringRangeIsMisspelled):
LayoutTests:
- accessibility/ios-simulator/attributed-string-for-range.html: Added.
- 1:55 PM Changeset in webkit [201567] by
-
- 2 edits in trunk/Source/WebCore
setVideoFullscreenGravity() has no effect on the fullscreen video layer
https://bugs.webkit.org/show_bug.cgi?id=158267
Reviewed by Eric Carlson.
When we moved to a 2-AVPlayerLayer solution, we didn't update setVideoFullscreenGravity()
to change the correct layer's videoGravity property.
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::setVideoFullscreenGravity):
- 1:32 PM Changeset in webkit [201566] by
-
- 6 edits1 delete in trunk
Unreviewed, rolling out r201488.
https://bugs.webkit.org/show_bug.cgi?id=158268
Caused 23% regression on JetStream's crypto-md5 (Requested by
rniwa on #webkit).
Reverted changeset:
"[ESNext] Support trailing commas in function param lists"
https://bugs.webkit.org/show_bug.cgi?id=158020
http://trac.webkit.org/changeset/201488
- 1:15 PM Changeset in webkit [201565] by
-
- 4 edits in trunk/Source/WebCore
Fix null dereferencing in ResourceTimingInformation::addResourceTiming
https://bugs.webkit.org/show_bug.cgi?id=158266
rdar://problem/26528466
Patch by Alex Christensen <achristensen@webkit.org> on 2016-06-01
Reviewed by Chris Dumez.
This would crash sometimes in http/tests/security/cross-frame-access-custom.html
- loader/ResourceTimingInformation.cpp:
(WebCore::ResourceTimingInformation::addResourceTiming):
- loader/ResourceTimingInformation.h:
- loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::requestResource):
(WebCore::CachedResourceLoader::loadDone):
We would dereference a null pointer on the first instruction when calling
Document::parentDocument from ResourceTimingInformation::addResourceTiming,
which means the document was null. CachedResourceLoader::document even has
a comment saying it can be null, so we should check it before using it.
- 12:55 PM Changeset in webkit [201564] by
-
- 15 edits in trunk/Websites/perf.webkit.org
v3 UI should support marking and unmarking outliers as well as hiding them
https://bugs.webkit.org/show_bug.cgi?id=158248
Rubber-stamped by Chris Dumez.
Added the support for marking and unmarking a sequence of points as outliers. Unlike v2, we now support marking
multiple points as outliers in a single click. Also fixed a bug that outliers are never explicitly hidden in v3 UI.
This patch splits ChartStyles.createChartSourceList into two functions: resolveConfiguration and createSourceList
to separate the work of resolving platform and metric IDs to their respective model objects, and creating a source
list used by TimeSeriesChart to fetch measurement sets. createSourceList is called again when filtering options are
changed.
It also adds noCache option to TimeSeriesChart's fetchMeasurementSets, MeasurementSet's fetchBetween and
_fetchPrimaryCluster to update the measurement sets after marking or unmarking points as outliers. In addition, it
fixes a bug that the annotation bars for analysis tasks are not updated in charts page after creating an analysis
task by adding noCache option to ChartPaneBase's fetchAnalysisTasks, AnalysisTask's fetchByPlatformAndMetric and
_fetchSubset.
Finally, this patch splits ChartPane._makeAnchorToOpenPane into _makePopoverActionItem, _makePopoverOpenOnHover and
_setPopoverVisibility for clarity.
- public/v3/components/chart-pane-base.js:
(ChartPaneBase): Added _disableSampling and _showOutliers as instance variables.
(ChartPaneBase.prototype.configure):
(ChartPaneBase.prototype.isSamplingEnabled): Added.
(ChartPaneBase.prototype.setSamplingEnabled): Added. When a filtering option is updated, recreate the source list
so that TimeSeriesChart.setSourceList can re-fetch the measurement set JSONs.
(ChartPaneBase.prototype.isShowingOutliers): Added.
(ChartPaneBase.prototype.setShowOutliers): Added. Ditto for calling _updateSourceList.
(ChartPaneBase.prototype._updateSourceList): Added.
(ChartPaneBase.prototype.fetchAnalysisTasks): Renamed from _fetchAnalysisTasks. Now takes noCache as an argument
instead of platform and metric IDs since they're on instance variables.
- public/v3/components/chart-styles.js:
(ChartStyles.resolveConfiguration): Renamed from createChartSourceList. Just resolves platform and metric IDs.
(ChartStyles.createSourceList): Extracted from createChartSourceList since it needs to be called when a filtering
option is changed as well as when ChartPaneBase.prototype.configure is called.
(ChartStyles.baselineStyle): Now takes filtering options.
(ChartStyles.targetStyle): Ditto.
(ChartStyles.currentStyle): Ditto.
- public/v3/components/interactive-time-series-chart.js:
(InteractiveTimeSeriesChart.prototype.currentPoint): Find the point in _fetchedTimeSeries when
_sampledTimeSeriesData hasn't been computed yet as a fallback (e.g. when the chart hasn't been rendered yet).
(InteractiveTimeSeriesChart.prototype.selectedPoints): Added.
(InteractiveTimeSeriesChart.prototype.firstSelectedPoint): Added.
(InteractiveTimeSeriesChart.prototype.lockedIndicator): Added. Returns the current point if it's locked.
- public/v3/components/time-series-chart.js:
(TimeSeriesChart.prototype.setDomain):
(TimeSeriesChart.prototype.setSourceList): Added. Re-create _fetchedTimeSeries when filtering options have changed.
Don't re-fetch measurement set JSONs here since showing outliers can be done entirely in the front end.
(TimeSeriesChart.prototype.fetchMeasurementSets): Extracted out of setDomain. Now takes noCache as an argument.
ChartPane._markAsOutlier
(TimeSeriesChart.prototype.firstSampledPointBetweenTime): Added.
- public/v3/models/analysis-task.js:
(AnalysisTask.fetchByPlatformAndMetric): Added noCache as an argument.
(AnalysisTask._fetchSubset): Ditto.
- public/v3/models/measurement-adaptor.js:
(MeasurementAdaptor.prototype.isOutlier): Added.
(MeasurementAdaptor.prototype.applyToAnalysisResults): Add markedOutlier as a property on each point.
- public/v3/models/measurement-cluster.js:
(MeasurementCluster.prototype.addToSeries): Fixed the bug that filtering outliers was broken as _markedOutlierIndex
is undefined here. Use MeasurementAdaptor's isOutlier instead.
- public/v3/models/measurement-set.js:
(MeasurementSet.prototype.fetchBetween): Added noCache as an argument. Reset _primaryClusterPromise and _allFetches
when noCache is true since we need to re-fetch the primary cluster as well as all secondary clusters now.
(MeasurementSet.prototype._fetchPrimaryCluster): Added noCache as an argument. Directly invoke the JSON API at
/api/measurement-set to re-generate all clusters' JSON files instead of first fetching the cached version.
(MeasurementSet.prototype._fetchSecondaryCluster):
(MeasurementSet.prototype._didFetchJSON): Removed a bogus assertion since this function is called on secondary
clusters as well as primary clusters.
(MeasurementSet.prototype._addFetchedCluster): Reimplemented this function using an insertion sort. Also remove the
existing entry if the fetch cluster should replace it.
- public/v3/models/time-series.js:
(TimeSeries.prototype.dataBetweenPoints): Removed the dead code to filter out outliers. This is done in addToSeries
of MeasurementCluster instead.
- public/v3/pages/chart-pane.js:
(ChartPane): Renamed pane to popover since it was confusing to have a pane inside a pane class. As such, renamed
_paneOpenedByClick to _lockedPopover.
(ChartPane.prototype.serializeState): Added the code to serialize filtering options in the serialized state URL.
(ChartPane.prototype.updateFromSerializedState): Ditto for parsing.
(ChartPane.prototype._analyzeRange): Extracted out of render(). Also fixed a bug that the charts page don't show
the newly created analysis task by invoking fetchAnalysisTasks with noCache set to true.
(ChartPane.prototype._markAsOutlier): Added.
(ChartPane.prototype._renderActionToolbar): A bunch of changes due to pane -> popover rename. Also added a popover
for filtering options.
(ChartPane.prototype._makePopoverActionItem): Extracted from _makeAnchorToOpenPane.
(ChartPane.prototype._makePopoverOpenOnHover): Ditto.
(ChartPane.prototype._setPopoverVisibility): Ditto.
(ChartPane.prototype._renderFilteringPopover): Added.
(ChartPane.htmlTemplate): Added a popover for specifying filtering options. Also added .popover on each popover.
(ChartPane.cssTemplate): Updated the style to make use of .popover.
- public/v3/pages/charts-page.js:
(ChartsPage.prototype.graphOptionsDidChange): Added. Updates the URL state when a filtering option is modified.
- public/v3/pages/dashboard-page.js:
(DashboardPage.prototype._createChartForCell):
- public/v3/pages/page-router.js:
(PageRouter.prototype._serializeHashQueryValue): Serialize a set of strings as | separated tokens.
(PageRouter.prototype._deserializeHashQueryValue): Rewrote the function as the serialized URL can no longer be
parsed as a JSON as | separated tokens can't be converted into a valid JSON construct with a simple regex.
- unit-tests/measurement-set-tests.js: Added a test case for fetchBetween with noCache=true.
- 12:47 PM Changeset in webkit [201563] by
-
- 11 edits in branches/safari-601.1.46-branch/Source/WebCore
Merged r201561. rdar://problem/26475175
- 12:32 PM Changeset in webkit [201562] by
-
- 4 edits in trunk/Source/JavaScriptCore
Dictionary property access should be fast
https://bugs.webkit.org/show_bug.cgi?id=158250
Reviewed by Keith Miller.
We have some remnant code that unnecessarily takes a slow path for
dictionaries. This caused the Dromaeo regression in r201436. Let's fix
that.
- jit/Repatch.cpp:
(JSC::tryCacheGetByID): Attempt to flatten a dictionary if necessary, but
not too much. This is our idiom in other places.
(JSC::tryCachePutByID): See tryCacheGetByID.
- llint/LLIntSlowPaths.cpp:
(JSC::LLInt::setupGetByIdPrototypeCache): See tryCacheGetByID.
- runtime/JSObject.cpp:
(JSC::JSObject::fillGetterPropertySlot):
- runtime/JSObject.h:
(JSC::JSObject::fillCustomGetterPropertySlot): The rules for caching a
getter are the same as the rules for caching anything else: We're
allowed to cache even in dictionaries, as long as they're cacheable
dictionaries. Any transition that would change to/from getter/setter
or change other attributes requires a structure transition.
- 11:50 AM Changeset in webkit [201561] by
-
- 11 edits in trunk/Source/WebCore
SVGImage should report its memory cost to JS garbage collector
https://bugs.webkit.org/show_bug.cgi?id=158139
Patch by Said Abou-Hallawa <sabouhallawa@apple.com> on 2016-06-01
Reviewed by Geoffrey Garen.
Like what we do in HTMLImageLoader::notifyFinished() by reporting the memory
cost of the BitmapImage, we need to do something similar for the SVGImage. In
SVGImage::dataChange() and when allDataReceived is true, we can calculate
the size of all DOM nodes and their renderers. The size of the encoded data
has to be added as well to the total memory cost. An approximation for the
memory cost has to be used since it is costly to get an accurate number.
- bindings/js/JSDocumentCustom.cpp:
(WebCore::reportMemoryForDocumentIfFrameless): Use Node::approximateMemoryCost()
instead of sizeof(Node). A Node's descendant can override this function and
return a more accurate memory cost.
- dom/Node.h:
(WebCore::Node::approximateMemoryCost): Define this new virtual function in the
Node class. Its default value is sizeof(Node) but any descendant can return a
more accurate number.
- platform/graphics/Image.h:
(WebCore::Image::data): Define a const version of data() so it can be called
the const function SVGImage::reportApproximateMemoryCost().
- svg/SVGGraphicsElement.h: Override approximateMemoryCost() to return
sizeof(SVGGraphicsElement).
- svg/SVGPathElement.cpp:
(WebCore::SVGPathElement::approximateMemoryCost): Override this function to return
the memory cost of the points and the m_path of the renderer.
- svg/SVGPathElement.h:
- svg/SVGPolyElement.cpp:
(WebCore::SVGPolyElement::approximateMemoryCost): Override this function to return
the memory cost of the points and the m_path of the renderer.
- svg/SVGPolyElement.h:
- svg/graphics/SVGImage.cpp:
(WebCore::SVGImage::reportApproximateMemoryCost): Calculate the memory cost of the
nodes in the SVGDocument of an SVGImage. Then report this number to the JS garbage
collector.
(WebCore::SVGImage::dataChanged): After loading all the SVG encoded data and building
its DOM tree and the render tree, report the total memory cost to the JS garbage collector.
- svg/graphics/SVGImage.h:
- 11:36 AM BuildingGtk edited by
- (diff)
- 11:17 AM Changeset in webkit [201560] by
-
- 5 edits in branches/safari-601.1.46-branch/Source
Versioning.
- 11:14 AM Changeset in webkit [201559] by
-
- 6 edits in trunk/Source/WebCore
Use inline capacity for StylePropertyShorthand Vectors.
<https://webkit.org/b/158260>
Reviewed by Antti Koivisto.
Vector<StylePropertyShorthand> was a huge source of heap allocations,
just over 0.5% of all fastMalloc() bytes on PLUM. Giving it an inline capacity
of 4 turns all of it into stack allocations.
- css/CSSParser.cpp:
(WebCore::CSSParser::addProperty):
- css/CSSProperty.cpp:
(WebCore::StylePropertyMetadata::shorthandID):
- css/StylePropertyShorthand.cpp:
(WebCore::indexOfShorthandForLonghand):
- css/StylePropertyShorthand.h:
- css/makeprop.pl:
(constructShorthandsVector):
- 10:38 AM Changeset in webkit [201558] by
-
- 1 copy in tags/Safari-602.1.35
New tag.
- 10:14 AM Changeset in webkit [201557] by
-
- 8 edits2 adds in trunk
POST request on a blob resource should return a "network error" instead of HTTP 500 response
https://bugs.webkit.org/show_bug.cgi?id=158022
Patch by Nael Ouedraogo <nael.ouedraogo@crf.canon.fr> on 2016-06-01
Reviewed by Alex Christensen.
LayoutTests/imported/w3c:
Make sure request on blob resource is correct.
- web-platform-tests/fetch/api/basic/scheme-blob-expected.txt:
- web-platform-tests/fetch/api/basic/scheme-blob-worker-expected.txt:
- web-platform-tests/fetch/api/basic/scheme-blob.js: Add new tests with several HTTP methods.
Source/WebCore:
Not allowed HTTP method is notified as failed in BlobResourceHandle as per Fetch
specification (5.2 Basic fetch). This behavior is observable in fetch WPT tests.
The behavior of XHR is slightly changed for asynchronous request on a blob resource with not
allowed or invalid HTTP methods. The onError callback is called instead of throwing an
exception as per XHR specification (https://xhr.spec.whatwg.org/#request-error-steps).
WPT tests expected results have been updated for fetch tests on blob resources which are
now correct.
Test: fast/files/xhr-blob-request.html ensures XHR response to requests on a blob resource is
correct.
- platform/network/BlobResourceHandle.cpp:
(WebCore::BlobResourceHandle::doStart):
- xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::createRequest):
LayoutTests:
Make sure response to XHR request on blob is correct.
- fast/files/xhr-blob-request-expected.txt: Added.
- fast/files/xhr-blob-request.html: Added.
- 9:58 AM Changeset in webkit [201556] by
-
- 3 edits in trunk/Source/WebCore
Remove allocation of SubresourceLoader::m_requestCountTracker
https://bugs.webkit.org/show_bug.cgi?id=158255
Reviewed by Chris Dumez.
No change of behavior.
Making m_requestCountTracker an Optional in lieu of a unique_ptr.
This requires constructing m_requestCountTracker in place so that constructor and destructor are called only once.
- loader/SubresourceLoader.cpp:
(WebCore::SubresourceLoader::SubresourceLoader):
(WebCore::SubresourceLoader::didReceiveResponse):
(WebCore::SubresourceLoader::notifyDone):
- loader/SubresourceLoader.h:
- 9:22 AM Changeset in webkit [201555] by
-
- 2 edits in trunk/LayoutTests/imported/w3c
Close wptserve response file handles explicitly
https://bugs.webkit.org/show_bug.cgi?id=158253
Reviewed by Alexey Proskuryakov.
See https://github.com/youennf/wptserve/commit/fc902e97a21b8470dcdaab8c70691aea1fecbc12
- resources/web-platform-tests-modules.json: Updating wptserve module to close response file handles once written.
- 9:03 AM WebKitGTK/Gardening/Calendar edited by
- (diff)
- 8:53 AM Changeset in webkit [201554] by
-
- 4 edits1 add in trunk/LayoutTests
Unreviewed GTK+ gardening. Rebaseline several tests after r201397.
We correctly render search field's cancel and result button for RTL content.
- fast/forms/search-input-rtl-expected.txt: Added.
- platform/gtk/fast/css/text-overflow-input-expected.txt:
- platform/gtk/fast/forms/placeholder-position-expected.txt:
- platform/gtk/fast/forms/search-rtl-expected.txt:
- 8:39 AM Changeset in webkit [201553] by
-
- 5 edits in trunk/Source
Versioning.
- 8:11 AM Changeset in webkit [201552] by
-
- 2 edits in trunk/Source/WebCore
Remove accidental fprintf.
- platform/graphics/FontCache.cpp:
(WebCore::FontCache::precache):
- 7:29 AM Changeset in webkit [201551] by
-
- 14 edits in trunk/Source/WebCore
Precache primary font in a secondary thread
https://bugs.webkit.org/show_bug.cgi?id=158243
Reviewed by Andreas Kling.
We know the font families and descriptions to use on style resolution. The actual fonts are only needed for
layout. There is often time to load and cache fonts asynchronously before they are accessed. This can substantially
reduce font related workload in the main thread.
- css/CSSFontFace.cpp:
(WebCore::CSSFontFace::font):
(WebCore::CSSFontFace::resolveFamilies):
(WebCore::CSSFontFace::hasSVGFontFaceSource):
- css/CSSFontFace.h:
- css/CSSFontFaceSource.cpp:
(WebCore::CSSFontFaceSource::font):
(WebCore::CSSFontFaceSource::url):
(WebCore::CSSFontFaceSource::isSVGFontFaceSource):
- css/CSSFontFaceSource.h:
- css/CSSFontSelector.cpp:
(WebCore::CSSFontSelector::fallbackFontAt):
(WebCore::CSSFontSelector::resolveFamilies):
Add a function for resolving font families of a cascade to their final values.
- css/CSSFontSelector.h:
- css/CSSSegmentedFontFace.cpp:
(WebCore::CSSSegmentedFontFace::fontRanges):
(WebCore::CSSSegmentedFontFace::resolveFamilies):
- css/CSSSegmentedFontFace.h:
- platform/graphics/FontCache.cpp:
(WebCore::fontPlatformDataCache):
(WebCore::precacheTasksInProgress):
(WebCore::alternateFamilyName):
(WebCore::FontCache::getCachedFontPlatformData):
(WebCore::FontCache::invalidate):
(WebCore::FontCache::precache):
Precache fonts by trying to load them asyncronously one by one. On success the font is cached into font platform data cache.
(WebCore::FontCache::similarFont):
- platform/graphics/FontCache.h:
- platform/graphics/FontCascade.cpp:
(WebCore::pruneSystemFallbackFonts):
(WebCore::precachePrimaryFamily):
When initializing a new font cascade resolve any platform fonts to their actual names using FontSelector,
then precache the primary font for the cascade.
Web fonts are ignored for now.
(WebCore::retrieveOrAddCachedFonts):
- platform/graphics/FontSelector.h:
(WebCore::FontSelector::~FontSelector):
- platform/graphics/cocoa/FontCacheCoreText.cpp:
(WebCore::FontCache::setFontWhitelist):
(WebCore::fontWithFamily):
(WebCore::autoActivateFont):
(WebCore::createFontPlatformDataThreadSafe):
Factor thread safe part of createFontPlatformData to a function.
(WebCore::FontCache::createFontPlatformData):
Do the main thread only hash lookups here then call to createFontPlatformDataThreadSafe.
(WebCore::fallbackDedupSet):
(WebCore::FontCache::systemFallbackForCharacters):
(WebCore::FontCache::platformPrecache):
Try to initialize font asynchronously in a dispatch queue, call completion handler on success or failure.
(WebCore::FontCache::platformCancelPrecache):
Cancel ongoing precache operation.
(WebCore::platformFontLookupWithFamily): Deleted.
This was inlined to the only client, fontWithFamily.
- 4:57 AM Changeset in webkit [201550] by
-
- 2 edits in trunk/Tools
Unreviewed. Mark GTK+ test /webkit2/WebKitWebInspectorServer/test-open-debugging-session as slow.
It's timing out in the bots, but it seems to pass when running run-gtk-tests with no timeout. For GLib tests the
timeout is applied per tester program not per test case, so we need to mark the whole test
WebKit2Gtk/TestInspectorServer as slow.
- Scripts/run-gtk-tests:
(TestRunner):
(TestRunner._run_test_glib):
- 3:06 AM Changeset in webkit [201549] by
-
- 24 edits2 copies3 adds in trunk
WebRTC: Add RTCRtpTransceiver interface and RTCPeerConnection.addTransceiver()
https://bugs.webkit.org/show_bug.cgi?id=158189
Reviewed by Darin Adler.
Source/WebCore:
The RTCRtpTransceiver interface represents a combination of an RTCRtpSender and an
RTCRtpReceiver that share a common mid [1].
RTCPeerConnection.addTransceiver() [2] creates an RTCRtpTransceiver object, either directly
from a MediaStreamTrack [3], or with a specific media type (kind).
This change introduces the RTCRtpTransceiver object, follow-up patches will integrate it
into the offer/answer machinery.
[1] https://w3c.github.io/webrtc-pc/archives/20160513/webrtc.html#rtcrtptransceiver-interface
[2] https://w3c.github.io/webrtc-pc/archives/20160513/webrtc.html#dom-rtcpeerconnection-addtransceiver
[3] http://w3c.github.io/mediacapture-main/archives/20160513/getusermedia.html#mediastreamtrack
Test: fast/mediastream/RTCPeerConnection-addTransceiver.html
- CMakeLists.txt:
- Modules/mediastream/MediaEndpointPeerConnection.cpp:
(WebCore::MediaEndpointPeerConnection::createOfferTask):
(WebCore::MediaEndpointPeerConnection::createReceiver):
An RTCTransceiver always has a receiver (RTCRtpReceiver) with a track (MediaStreamTrack) that
can be rendered. Before that remote track is receiving data from the remote peer, it's muted.
createReceiver() uses MediaEndponit::createMutedRemoteSource() to create a source to represent
future incoming media.
- Modules/mediastream/MediaEndpointPeerConnection.h:
- Modules/mediastream/PeerConnectionBackend.h:
- Modules/mediastream/RTCPeerConnection.cpp:
(WebCore::RTCPeerConnection::addTransceiver):
(WebCore::RTCPeerConnection::completeAddTransceiver):
(WebCore::RTCPeerConnection::addReceiver): Deleted.
We now create the receiver explicitly with createReceiver.
- Modules/mediastream/RTCPeerConnection.h:
- Modules/mediastream/RTCPeerConnection.idl:
- Modules/mediastream/RTCRtpSender.cpp:
(WebCore::RTCRtpSender::create):
(WebCore::RTCRtpSender::RTCRtpSender):
(WebCore::RTCRtpSender::setTrack):
(WebCore::RTCRtpSender::replaceTrack):
- Modules/mediastream/RTCRtpSender.h:
(WebCore::RTCRtpSender::trackId):
(WebCore::RTCRtpSender::trackKind):
(WebCore::RTCRtpSender::setMediaStreamIds):
(WebCore::RTCRtpSender::isStopped):
(WebCore::RTCRtpSender::create): Deleted.
- Modules/mediastream/RTCRtpSenderReceiverBase.h:
(WebCore::RTCRtpSenderReceiverBase::track):
(WebCore::RTCRtpSenderReceiverBase::RTCRtpSenderReceiverBase):
- Modules/mediastream/RTCRtpTransceiver.cpp: Added.
(WebCore::RTCRtpTransceiver::create):
(WebCore::RTCRtpTransceiver::getNextMid):
(WebCore::RTCRtpTransceiver::RTCRtpTransceiver):
(WebCore::RTCRtpTransceiver::directionString):
(WebCore::RTCRtpTransceiver::hasSendingDirection):
(WebCore::RTCRtpTransceiver::enableSendingDirection):
(WebCore::RTCRtpTransceiver::disableSendingDirection):
- Modules/mediastream/RTCRtpTransceiver.h: Added.
(WebCore::RTCRtpTransceiver::~RTCRtpTransceiver):
(WebCore::RTCRtpTransceiver::direction):
(WebCore::RTCRtpTransceiver::setDirection):
(WebCore::RTCRtpTransceiver::provisionalMid):
(WebCore::RTCRtpTransceiver::setProvisionalMid):
(WebCore::RTCRtpTransceiver::mid):
(WebCore::RTCRtpTransceiver::setMid):
(WebCore::RTCRtpTransceiver::sender):
(WebCore::RTCRtpTransceiver::receiver):
(WebCore::RTCRtpTransceiver::stopped):
(WebCore::RTCRtpTransceiver::stop):
- Modules/mediastream/RTCRtpTransceiver.idl: Added.
- WebCore.xcodeproj/project.pbxproj:
- platform/mediastream/MediaEndpoint.h:
Added createMutedRemoteSource() that creates a muted remote source that will become unmuted
when media arrives from the remote peer.
- platform/mediastream/RealtimeMediaSource.cpp:
(WebCore::RealtimeMediaSource::RealtimeMediaSource): Deleted.
- platform/mediastream/RealtimeMediaSource.h:
- platform/mediastream/mac/MockRealtimeVideoSourceMac.mm:
(WebCore::MockRealtimeVideoSource::create):
Use Ref instead of RefPtr.
- platform/mock/MockMediaEndpoint.cpp:
(WebCore::MockMediaEndpoint::createMutedRemoteSource):
- platform/mock/MockMediaEndpoint.h:
- platform/mock/MockRealtimeAudioSource.cpp:
(WebCore::MockRealtimeAudioSource::create):
(WebCore::MockRealtimeAudioSource::createMuted):
(WebCore::MockRealtimeAudioSource::MockRealtimeAudioSource):
- platform/mock/MockRealtimeAudioSource.h:
- platform/mock/MockRealtimeVideoSource.cpp:
(WebCore::MockRealtimeVideoSource::create):
(WebCore::MockRealtimeVideoSource::createMuted):
(WebCore::MockRealtimeVideoSource::MockRealtimeVideoSource):
- platform/mock/MockRealtimeVideoSource.h:
LayoutTests:
Added test for RTCPeerConnection.addTransceiver().
- fast/mediastream/RTCPeerConnection-addTransceiver-expected.txt: Added.
- fast/mediastream/RTCPeerConnection-addTransceiver.html: Added.
Test creating several RTCRtpTransceivers with various configurations and inspect the result.
- platform/mac/TestExpectations:
Skip the new test since the Mac port currently doesn't build with WebRTC support.
- 2:56 AM Changeset in webkit [201548] by
-
- 2 edits in trunk/Tools
Unreviewed. Skip media permission request GTK+ unit tests.
They are timing out in the bots.
- Scripts/run-gtk-tests:
(TestRunner):
- 2:10 AM Changeset in webkit [201547] by
-
- 2 edits in trunk/Source/WebCore
[Win][IndexedDB] Crash when running blob test.
https://bugs.webkit.org/show_bug.cgi?id=158224
Reviewed by Brady Eidson.
Avoid calling WTFMove(x) before calling x->method().
- Modules/indexeddb/IDBTransaction.cpp:
(WebCore::IDBTransaction::putOrAddOnServer):
- 1:23 AM Changeset in webkit [201546] by
-
- 2 edits in trunk/Source/WebKit/win
[Win] Potential null pointer crash when setting cursor.
https://bugs.webkit.org/show_bug.cgi?id=158225
Reviewed by Alex Christensen.
Check return value of Cursor::platformCursor().
- WebCoreSupport/WebChromeClient.cpp:
(WebChromeClient::setCursor):
- 12:24 AM Changeset in webkit [201545] by
-
- 5 edits in trunk
[css-grid] Positioned items can be placed on the implicit grid
https://bugs.webkit.org/show_bug.cgi?id=158197
Reviewed by Sergio Villar Senin.
Source/WebCore:
The old code wrongly assumed that positioned items couldn't be placed
on the implicit grid. However, the spec doesn't mention anything about this.
The patch fixes this issue, so now positioned items can be actually
placed on the implicit tracks.
Test: fast/css-grid-layout/grid-positioned-items-within-grid-implicit-track.html
- rendering/RenderGrid.cpp:
(WebCore::RenderGrid::offsetAndBreadthForPositionedChild): Use the lines
of the implicit grid instead of the explicit one.
LayoutTests:
Updated the test to follow the expected behavior.
- fast/css-grid-layout/grid-positioned-items-within-grid-implicit-track-expected.txt:
- fast/css-grid-layout/grid-positioned-items-within-grid-implicit-track.html:
May 31, 2016:
- 10:05 PM Changeset in webkit [201544] by
-
- 2 edits in trunk/Source/JavaScriptCore
[JSC] Drop "replace" from JSC_COMMON_PRIVATE_IDENTIFIERS_EACH_WELL_KNOWN_SYMBOL_NOT_IMPLEMENTED_YET
https://bugs.webkit.org/show_bug.cgi?id=158223
Reviewed by Darin Adler.
This list maintains "not implemented yet" well-known symbols.
Symbol.replaceis already implemented.
- runtime/CommonIdentifiers.h:
- 9:49 PM Changeset in webkit [201543] by
-
- 4 edits in trunk/Source/WebCore
Modernize lambda captures in WorkerThreadableWebSocketChannel
https://bugs.webkit.org/show_bug.cgi?id=158246
Reviewed by Brady Eidson.
Modernize lambda captures in WorkerThreadableWebSocketChannel and drop
legacy URLCapture as it is no longer needed / used.
- Modules/websockets/WorkerThreadableWebSocketChannel.cpp:
(WebCore::WorkerThreadableWebSocketChannel::Peer::send):
(WebCore::WorkerThreadableWebSocketChannel::Peer::bufferedAmount):
(WebCore::WorkerThreadableWebSocketChannel::Peer::didConnect):
(WebCore::WorkerThreadableWebSocketChannel::Peer::didReceiveMessage):
(WebCore::WorkerThreadableWebSocketChannel::Peer::didReceiveBinaryData):
(WebCore::WorkerThreadableWebSocketChannel::Peer::didUpdateBufferedAmount):
(WebCore::WorkerThreadableWebSocketChannel::Peer::didStartClosingHandshake):
(WebCore::WorkerThreadableWebSocketChannel::Peer::didClose):
(WebCore::WorkerThreadableWebSocketChannel::Peer::didReceiveMessageError):
(WebCore::WorkerThreadableWebSocketChannel::Bridge::mainThreadInitialize):
(WebCore::WorkerThreadableWebSocketChannel::Bridge::initialize):
(WebCore::WorkerThreadableWebSocketChannel::Bridge::connect):
(WebCore::WorkerThreadableWebSocketChannel::Bridge::send):
(WebCore::WorkerThreadableWebSocketChannel::Bridge::bufferedAmount):
(WebCore::WorkerThreadableWebSocketChannel::Bridge::close):
(WebCore::WorkerThreadableWebSocketChannel::Bridge::fail):
(WebCore::WorkerThreadableWebSocketChannel::Bridge::disconnect):
(WebCore::WorkerThreadableWebSocketChannel::Bridge::suspend):
(WebCore::WorkerThreadableWebSocketChannel::Bridge::resume):
(WebCore::WorkerThreadableWebSocketChannel::Bridge::setMethodNotCompleted): Deleted.
(WebCore::WorkerThreadableWebSocketChannel::Bridge::waitForMethodCompletion): Deleted.
- Modules/websockets/WorkerThreadableWebSocketChannel.h:
- platform/URL.h:
(WebCore::operator==): Deleted.
- 9:30 PM Changeset in webkit [201542] by
-
- 54 edits15 deletes in trunk/Source
Unreviewed, roll out r201481, r201523: 0.3% regression in Octane code-load
https://bugs.webkit.org/show_bug.cgi?id=158249
Source/JavaScriptCore:
- API/JSScriptRef.cpp:
(parseScript):
- CMakeLists.txt:
- DerivedSources.make:
- JavaScriptCore.xcodeproj/project.pbxproj:
- builtins/AsyncFunctionPrototype.js: Removed.
(asyncFunctionResume): Deleted.
- builtins/BuiltinExecutables.cpp:
(JSC::BuiltinExecutables::createExecutable):
- bytecode/BytecodeList.json:
- bytecode/BytecodeUseDef.h:
(JSC::computeUsesForBytecodeOffset): Deleted.
(JSC::computeDefsForBytecodeOffset): Deleted.
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::finishCreation):
(JSC::CodeBlock::dumpBytecode): Deleted.
- bytecode/UnlinkedCodeBlock.h:
(JSC::UnlinkedCodeBlock::isArrowFunction):
(JSC::UnlinkedCodeBlock::isOrdinaryArrowFunction): Deleted.
(JSC::UnlinkedCodeBlock::isAsyncArrowFunction): Deleted.
- bytecode/UnlinkedFunctionExecutable.cpp:
(JSC::generateUnlinkedFunctionCodeBlock):
(JSC::UnlinkedFunctionExecutable::UnlinkedFunctionExecutable):
(JSC::UnlinkedFunctionExecutable::fromGlobalCode):
(JSC::UnlinkedFunctionExecutable::unlinkedCodeBlockFor):
- bytecode/UnlinkedFunctionExecutable.h:
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::BytecodeGenerator):
(JSC::BytecodeGenerator::emitNewArrowFunctionExpression):
(JSC::BytecodeGenerator::emitNewMethodDefinition):
(JSC::BytecodeGenerator::emitLoadArrowFunctionLexicalEnvironment):
(JSC::BytecodeGenerator::emitNewFunctionExpressionCommon): Deleted.
(JSC::BytecodeGenerator::emitNewFunction): Deleted.
- bytecompiler/BytecodeGenerator.h:
(JSC::BytecodeGenerator::makeFunction):
- bytecompiler/NodesCodegen.cpp:
(JSC::FunctionNode::emitBytecode): Deleted.
- inspector/agents/InspectorRuntimeAgent.cpp:
(Inspector::InspectorRuntimeAgent::parse):
- jit/JIT.cpp:
(JSC::JIT::privateCompileMainPass): Deleted.
- jit/JIT.h:
- jit/JITOpcodes.cpp:
(JSC::JIT::emitNewFuncCommon): Deleted.
(JSC::JIT::emit_op_new_async_func): Deleted.
(JSC::JIT::emitNewFuncExprCommon): Deleted.
(JSC::JIT::emit_op_new_async_func_exp): Deleted.
- jit/JITOperations.cpp:
- jit/JITOperations.h:
- jsc.cpp:
(runInteractive):
(printUsageStatement): Deleted.
- llint/LLIntSlowPaths.cpp:
(JSC::LLInt::LLINT_SLOW_PATH_DECL): Deleted.
- llint/LLIntSlowPaths.h:
- llint/LowLevelInterpreter.asm:
- parser/ASTBuilder.h:
(JSC::ASTBuilder::createAsyncFunctionBody): Deleted.
- parser/Keywords.table:
- parser/Parser.cpp:
(JSC::Parser<LexerType>::Parser):
(JSC::Parser<LexerType>::parseInner):
(JSC::Parser<LexerType>::isArrowFunctionParameters):
(JSC::Parser<LexerType>::parseStatementListItem):
(JSC::Parser<LexerType>::parseStatement):
(JSC::Parser<LexerType>::parseFunctionParameters):
(JSC::Parser<LexerType>::parseFunctionInfo):
(JSC::Parser<LexerType>::parseClass):
(JSC::Parser<LexerType>::parseImportClauseItem):
(JSC::Parser<LexerType>::parseImportDeclaration):
(JSC::Parser<LexerType>::parseExportDeclaration):
(JSC::Parser<LexerType>::parseAssignmentExpression):
(JSC::Parser<LexerType>::parseProperty):
(JSC::Parser<LexerType>::parsePropertyMethod):
(JSC::Parser<LexerType>::parsePrimaryExpression):
(JSC::Parser<LexerType>::parseMemberExpression):
(JSC::Parser<LexerType>::parseArrowFunctionExpression):
(JSC::Parser<LexerType>::printUnexpectedTokenText):
(JSC::Parser<LexerType>::parseAsyncFunctionSourceElements): Deleted.
(JSC::Parser<LexerType>::parseVariableDeclarationList): Deleted.
(JSC::Parser<LexerType>::parseDestructuringPattern): Deleted.
(JSC::Parser<LexerType>::parseFunctionDeclarationStatement): Deleted.
(JSC::Parser<LexerType>::parseFormalParameters): Deleted.
(JSC::stringForFunctionMode): Deleted.
(JSC::Parser<LexerType>::parseAsyncFunctionDeclaration): Deleted.
(JSC::Parser<LexerType>::parseExpressionOrLabelStatement): Deleted.
(JSC::Parser<LexerType>::parseAwaitExpression): Deleted.
(JSC::Parser<LexerType>::parseAsyncFunctionExpression): Deleted.
(JSC::Parser<LexerType>::parseUnaryExpression): Deleted.
- parser/Parser.h:
(JSC::Scope::Scope):
(JSC::Parser::ExpressionErrorClassifier::propagateExpressionErrorClass):
(JSC::Parser::closestParentOrdinaryFunctionNonLexicalScope):
(JSC::Parser::pushScope):
(JSC::Parser::popScopeInternal):
(JSC::Parser::matchSpecIdentifier):
(JSC::parse):
(JSC::Scope::setSourceParseMode): Deleted.
(JSC::Scope::isAsyncFunction): Deleted.
(JSC::Scope::isAsyncFunctionBoundary): Deleted.
(JSC::Scope::isModule): Deleted.
(JSC::Scope::setIsFunction): Deleted.
(JSC::Scope::setIsAsyncArrowFunction): Deleted.
(JSC::Scope::setIsAsyncFunction): Deleted.
(JSC::Scope::setIsAsyncFunctionBody): Deleted.
(JSC::Scope::setIsAsyncArrowFunctionBody): Deleted.
(JSC::Parser::ExpressionErrorClassifier::forceClassifyExpressionError): Deleted.
(JSC::Parser::ExpressionErrorClassifier::indicatesPossibleAsyncArrowFunction): Deleted.
(JSC::Parser::forceClassifyExpressionError): Deleted.
(JSC::Parser::declarationTypeToVariableKind): Deleted.
(JSC::Parser::upperScope): Deleted.
(JSC::Parser::isDisallowedIdentifierAwait): Deleted.
(JSC::Parser::disallowedIdentifierAwaitReason): Deleted.
- parser/ParserModes.h:
(JSC::isFunctionParseMode):
(JSC::isModuleParseMode):
(JSC::isProgramParseMode):
(JSC::SourceParseModeSet::SourceParseModeSet): Deleted.
(JSC::SourceParseModeSet::contains): Deleted.
(JSC::SourceParseModeSet::mergeSourceParseModes): Deleted.
(JSC::isAsyncFunctionParseMode): Deleted.
(JSC::isAsyncArrowFunctionParseMode): Deleted.
(JSC::isAsyncFunctionWrapperParseMode): Deleted.
(JSC::isAsyncFunctionBodyParseMode): Deleted.
(JSC::constructAbilityForParseMode): Deleted.
- parser/ParserTokens.h:
- parser/SourceCodeKey.h:
(JSC::SourceCodeKey::SourceCodeKey):
(JSC::SourceCodeKey::operator==):
(JSC::SourceCodeKey::runtimeFlags): Deleted.
- parser/SyntaxChecker.h:
(JSC::SyntaxChecker::createAsyncFunctionBody): Deleted.
- runtime/AsyncFunctionConstructor.cpp: Removed.
(JSC::AsyncFunctionConstructor::AsyncFunctionConstructor): Deleted.
(JSC::AsyncFunctionConstructor::finishCreation): Deleted.
(JSC::callAsyncFunctionConstructor): Deleted.
(JSC::constructAsyncFunctionConstructor): Deleted.
(JSC::AsyncFunctionConstructor::getCallData): Deleted.
(JSC::AsyncFunctionConstructor::getConstructData): Deleted.
- runtime/AsyncFunctionConstructor.h: Removed.
(JSC::AsyncFunctionConstructor::create): Deleted.
(JSC::AsyncFunctionConstructor::createStructure): Deleted.
- runtime/AsyncFunctionPrototype.cpp: Removed.
(JSC::AsyncFunctionPrototype::AsyncFunctionPrototype): Deleted.
(JSC::AsyncFunctionPrototype::finishCreation): Deleted.
- runtime/AsyncFunctionPrototype.h: Removed.
(JSC::AsyncFunctionPrototype::create): Deleted.
(JSC::AsyncFunctionPrototype::createStructure): Deleted.
- runtime/CodeCache.cpp:
(JSC::CodeCache::getGlobalCodeBlock):
(JSC::CodeCache::getProgramCodeBlock):
(JSC::CodeCache::getEvalCodeBlock):
(JSC::CodeCache::getModuleProgramCodeBlock):
(JSC::CodeCache::getFunctionExecutableFromGlobalCode):
- runtime/CodeCache.h:
- runtime/CommonIdentifiers.h:
- runtime/Completion.cpp:
(JSC::checkSyntax):
(JSC::checkModuleSyntax):
- runtime/Completion.h:
- runtime/Executable.cpp:
(JSC::ScriptExecutable::newCodeBlockFor):
(JSC::ProgramExecutable::checkSyntax):
- runtime/Executable.h:
- runtime/FunctionConstructor.cpp:
(JSC::constructFunctionSkippingEvalEnabledCheck):
- runtime/FunctionConstructor.h:
- runtime/JSAsyncFunction.cpp: Removed.
(JSC::JSAsyncFunction::JSAsyncFunction): Deleted.
(JSC::JSAsyncFunction::createImpl): Deleted.
(JSC::JSAsyncFunction::create): Deleted.
(JSC::JSAsyncFunction::createWithInvalidatedReallocationWatchpoint): Deleted.
- runtime/JSAsyncFunction.h: Removed.
(JSC::JSAsyncFunction::allocationSize): Deleted.
(JSC::JSAsyncFunction::createStructure): Deleted.
- runtime/JSFunction.cpp:
(JSC::JSFunction::getOwnPropertySlot):
- runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::createProgramCodeBlock):
(JSC::JSGlobalObject::createEvalCodeBlock):
(JSC::JSGlobalObject::createModuleProgramCodeBlock):
(JSC::JSGlobalObject::init): Deleted.
- runtime/JSGlobalObject.h:
(JSC::JSGlobalObject::asyncFunctionPrototype): Deleted.
(JSC::JSGlobalObject::asyncFunctionStructure): Deleted.
- runtime/ModuleLoaderObject.cpp:
(JSC::moduleLoaderObjectParseModule):
- runtime/RuntimeFlags.h:
(JSC::RuntimeFlags::operator==): Deleted.
(JSC::RuntimeFlags::operator!=): Deleted.
- tests/stress/async-await-basic.js: Removed.
(shouldBe): Deleted.
(shouldBeAsync): Deleted.
(shouldThrow): Deleted.
(shouldThrowAsync): Deleted.
(shouldThrowSyntaxError): Deleted.
(let.AsyncFunction.async): Deleted.
(async.asyncFunctionForProto): Deleted.
(Object.getPrototypeOf.async): Deleted.
(Object.getPrototypeOf.async.method): Deleted.
(async): Deleted.
(async.method): Deleted.
(async.asyncNonConstructorDecl): Deleted.
(shouldThrow.new.async): Deleted.
(shouldThrow.new.async.nonConstructor): Deleted.
(async.asyncDecl): Deleted.
(async.f): Deleted.
(MyError): Deleted.
(async.asyncDeclThrower): Deleted.
(shouldThrowAsync.async): Deleted.
(resolveLater): Deleted.
(rejectLater): Deleted.
(async.resumeAfterNormal): Deleted.
(O.async.resumeAfterNormal): Deleted.
(resumeAfterNormalArrow.async): Deleted.
(async.resumeAfterThrow): Deleted.
(O.async.resumeAfterThrow): Deleted.
(resumeAfterThrowArrow.async): Deleted.
(catch): Deleted.
- tests/stress/async-await-module-reserved-word.js: Removed.
(shouldThrow): Deleted.
(SyntaxError.Canstring_appeared_hereawait.checkModuleSyntaxError.String.raw.await): Deleted.
(checkModuleSyntaxError.String.raw.await): Deleted.
(checkModuleSyntaxError.String.raw.async.await): Deleted.
(SyntaxError.Cannot.declare.named): Deleted.
- tests/stress/async-await-mozilla.js: Removed.
(shouldBe): Deleted.
(shouldBeAsync): Deleted.
(shouldThrow): Deleted.
(shouldThrowAsync): Deleted.
(assert): Deleted.
(shouldThrowSyntaxError): Deleted.
(mozSemantics.async.empty): Deleted.
(mozSemantics.async.simpleReturn): Deleted.
(mozSemantics.async.simpleAwait): Deleted.
(mozSemantics.async.simpleAwaitAsync): Deleted.
(mozSemantics.async.returnOtherAsync): Deleted.
(mozSemantics.async.simpleThrower): Deleted.
(mozSemantics.async.delegatedThrower): Deleted.
(mozSemantics.async.tryCatch): Deleted.
(mozSemantics.async.tryCatchThrow): Deleted.
(mozSemantics.async.wellFinally): Deleted.
(mozSemantics.async.finallyMayFail): Deleted.
(mozSemantics.async.embedded.async.inner): Deleted.
(mozSemantics.async.embedded): Deleted.
(mozSemantics.async.fib): Deleted.
(mozSemantics.async.isOdd.async.isEven): Deleted.
(mozSemantics.async.isOdd): Deleted.
(mozSemantics.hardcoreFib.async.fib2): Deleted.
(mozSemantics.namedAsyncExpr.async.simple): Deleted.
(mozSemantics.async.executionOrder.async.first): Deleted.
(mozSemantics.async.executionOrder.async.second): Deleted.
(mozSemantics.async.executionOrder.async.third): Deleted.
(mozSemantics.async.executionOrder): Deleted.
(mozSemantics.async.miscellaneous): Deleted.
(mozSemantics.thrower): Deleted.
(mozSemantics.async.defaultArgs): Deleted.
(mozSemantics.shouldThrow): Deleted.
(mozSemantics): Deleted.
(mozMethods.X): Deleted.
(mozMethods.X.prototype.async.getValue): Deleted.
(mozMethods.X.prototype.setValue): Deleted.
(mozMethods.X.prototype.async.increment): Deleted.
(mozMethods.X.prototype.async.getBaseClassName): Deleted.
(mozMethods.X.async.getStaticValue): Deleted.
(mozMethods.Y.prototype.async.getBaseClassName): Deleted.
(mozMethods.Y): Deleted.
(mozFunctionNameInferrence.async.test): Deleted.
(mozSyntaxErrors): Deleted.
- tests/stress/async-await-reserved-word.js: Removed.
(assert): Deleted.
(shouldThrowSyntaxError): Deleted.
(AsyncFunction.async): Deleted.
- tests/stress/async_arrow_functions_lexical_arguments_binding.js: Removed.
(shouldBe): Deleted.
(shouldBeAsync): Deleted.
(shouldThrowAsync): Deleted.
(noArgumentsArrow2.async): Deleted.
- tests/stress/async_arrow_functions_lexical_new.target_binding.js: Removed.
(shouldBe): Deleted.
(shouldBeAsync): Deleted.
(shouldThrowAsync): Deleted.
(C1): Deleted.
(C2): Deleted.
(shouldThrowAsync.async): Deleted.
- tests/stress/async_arrow_functions_lexical_super_binding.js: Removed.
(shouldBe): Deleted.
(shouldBeAsync): Deleted.
(BaseClass.prototype.baseClassValue): Deleted.
(BaseClass.prototype.get property): Deleted.
(BaseClass): Deleted.
(ChildClass.prototype.asyncSuperProp): Deleted.
(ChildClass.prototype.asyncSuperProp2): Deleted.
(ChildClass): Deleted.
(ChildClass2): Deleted.
- tests/stress/async_arrow_functions_lexical_this_binding.js: Removed.
(shouldBe): Deleted.
(shouldBeAsync): Deleted.
(d.y): Deleted.
Source/WebKit/mac:
- WebView/WebPreferencesPrivate.h:
Source/WebKit/win:
- Interfaces/IWebPreferencesPrivate.idl:
Source/WebKit2:
- UIProcess/API/C/WKPreferencesRefPrivate.h:
- UIProcess/API/Cocoa/WKPreferencesPrivate.h:
- 5:45 PM Changeset in webkit [201541] by
-
- 2 edits9 adds in trunk/Source/WebCore
Web Inspector: ReportExtraMemoryCost IDL attribute should also be used to generate estimatedSize method
https://bugs.webkit.org/show_bug.cgi?id=158144
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-05-31
Reviewed by Darin Adler.
- bindings/scripts/CodeGeneratorJS.pm:
(InstanceNeedsEstimatedSize):
(GenerateHeader):
(GenerateImplementation):
When an interface includes ReportExtraMemoryCost, generate an estimatedSize
method which includes the Base::estimatedSize and the memoryCost().
- bindings/scripts/test/GObject/WebKitDOMInterfaceName.cpp: Added.
(WebKit::kit):
(WebKit::core):
(WebKit::wrapInterfaceName):
(webkit_dom_interface_name_finalize):
(webkit_dom_interface_name_constructor):
(webkit_dom_interface_name_class_init):
(webkit_dom_interface_name_init):
- bindings/scripts/test/GObject/WebKitDOMInterfaceName.h: Added.
- bindings/scripts/test/GObject/WebKitDOMInterfaceNamePrivate.h: Added.
- bindings/scripts/test/JS/JSInterfaceName.cpp: Added.
(WebCore::JSInterfaceNamePrototype::create):
(WebCore::JSInterfaceNamePrototype::createStructure):
(WebCore::JSInterfaceNamePrototype::JSInterfaceNamePrototype):
(WebCore::JSInterfaceNameConstructor::prototypeForStructure):
(WebCore::JSInterfaceNameConstructor::initializeProperties):
(WebCore::JSInterfaceNamePrototype::finishCreation):
(WebCore::JSInterfaceName::JSInterfaceName):
(WebCore::JSInterfaceName::createPrototype):
(WebCore::JSInterfaceName::prototype):
(WebCore::JSInterfaceName::destroy):
(WebCore::jsInterfaceNameConstructor):
(WebCore::setJSInterfaceNameConstructor):
(WebCore::JSInterfaceName::getConstructor):
(WebCore::JSInterfaceName::visitChildren):
(WebCore::JSInterfaceName::estimatedSize):
(WebCore::JSInterfaceNameOwner::isReachableFromOpaqueRoots):
(WebCore::JSInterfaceNameOwner::finalize):
(WebCore::toJSNewlyCreated):
(WebCore::toJS):
(WebCore::JSInterfaceName::toWrapped):
- bindings/scripts/test/JS/JSInterfaceName.h: Added.
(WebCore::JSInterfaceName::create):
(WebCore::JSInterfaceName::createStructure):
(WebCore::JSInterfaceName::finishCreation):
(WebCore::wrapperOwner):
(WebCore::wrapperKey):
(WebCore::toJS):
(WebCore::toJSNewlyCreated):
- bindings/scripts/test/ObjC/DOMInterfaceName.h: Added.
- bindings/scripts/test/ObjC/DOMInterfaceName.mm: Added.
(-[DOMInterfaceName dealloc]):
(core):
(kit):
- bindings/scripts/test/ObjC/DOMInterfaceNameInternal.h: Added.
- bindings/scripts/test/TestReportExtraMemoryCost.idl: Added.
Include a test for the ReportExtraMemoryCost attribute.
- 5:31 PM Changeset in webkit [201540] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Storage DataGrids have a half-pixel transparent/white border below the header
https://bugs.webkit.org/show_bug.cgi?id=156699
<rdar://problem/25778260>
Reviewed by Timothy Hatcher.
Increase the width of the border below the DataGrid's header to match the border in the left sidebar.
- UserInterface/Views/DataGrid.css:
(.data-grid > .header-wrapper):
- 5:28 PM Changeset in webkit [201539] by
-
- 2 edits in trunk/Source/WebCore
Fix assertion after r201447
https://bugs.webkit.org/show_bug.cgi?id=158244
Patch by Alex Christensen <achristensen@webkit.org> on 2016-05-31
Reviewed by Jer Noble.
- loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::loadResource):
If we are loading media using WebCoreNSURLSession, we could be making a request for a
resource we already have in the memory cache because we are ignoring all caches.
- 5:26 PM Changeset in webkit [201538] by
-
- 3 edits in trunk/Source/WebInspectorUI
Web Inspector: Snapshot List scroll bar occludes border of containing view in top-right
https://bugs.webkit.org/show_bug.cgi?id=158219
<rdar://problem/26545018>
Reviewed by Timothy Hatcher.
- UserInterface/Views/TimelineDataGrid.css:
(.data-grid.timeline th): Deleted.
- UserInterface/Views/TimelineRecordingContentView.css:
(.content-view.timeline-recording > .content-browser > .navigation-bar):
Make the border line span across the whole navigation bar, not just its table cells.
- 4:28 PM Changeset in webkit [201537] by
-
- 2 edits in trunk/Tools
Yet another unreviewed build fix; move the closing brace of the namespace declaration inside
the #if check.
- TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenTopContentInset.mm:
- 4:20 PM Changeset in webkit [201536] by
-
- 2 edits in trunk/Tools
Further unreviewed build fix; only run FullscreenTopContentInset test on Mac.
- TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenTopContentInset.mm:
- 3:52 PM Changeset in webkit [201535] by
-
- 2 edits in trunk/Source/WebKit2
Add two optional items to WebViewImplDelegate
https://bugs.webkit.org/show_bug.cgi?id=158242
-and corresponding-
rdar://problem/26473095
Reviewed by Tim Horton.
- UIProcess/Cocoa/WebViewImpl.h:
- 3:51 PM Changeset in webkit [201534] by
-
- 10 edits in trunk/Source/WebCore
Clean up / modernize iOS text autosizing code
https://bugs.webkit.org/show_bug.cgi?id=158217
Reviewed by Darin Adler.
Clean up / modernize iOS text autosizing code.
I think iOS text autosizing code is too intrusive inside the RenderStyle
class but I have not updated this part of the code yet to limit patch
size. This patch focuses on the TextAutoSizing.* and text autosizing
code in the Document class.
- WebCore.xcodeproj/project.pbxproj:
- dom/Document.cpp:
(WebCore::TextAutoSizingTraits::constructDeletedValue): Deleted.
(WebCore::TextAutoSizingTraits::isDeletedValue): Deleted.
Move TextAutoSizingTraits to the TextAutoSizing header to
promote reuse and make the text autosizing code a little less
intrusive.
(WebCore::Document::addAutoSizingNode):
- Drop local 'key' variable as it is only used once.
- Use std::make_unique<> to construct the TextAutoSizingValue as it is no longer ref-counted.
(WebCore::Document::validateAutoSizingNodes):
Iterate over the textAutosizedNodes HashMap only once instead
of twice. TextAutoSizingValue::adjustTextNodeSizes() was updated
to return an enum class so we know from that value if we can
remove the value from the HashSet or not, without having to rely
on TextAutoSizingValue::numNodes(), which I removed in this
patch.
(WebCore::Document::clearAutoSizingNodes):
Updated the TextAutoSizingValue destructor to call reset() so
we don't have to explicitly call reset() on each value before
clearing the textAutosizedNodes HashMap.
- dom/Document.h:
- Move TextAutoSizingTraits to the TextAutosizing header.
- Rename resetAutosizingNodes() to clearAutoSizingNodes() as the method now only clears the textAutosizedNodes HashMap and reset() is now an implementation detail for TextAutoSizingValue.
- rendering/RenderElement.cpp:
(WebCore::RenderElement::resetTextAutosizing):
Call clearAutoSizingNodes() as it was renamed.
- rendering/TextAutoSizing.cpp:
(WebCore::TextAutoSizingKey::TextAutoSizingKey):
- Use value of -1 for std::unique_ptr m_style member for distinguishing
a HashTable deleted value, instead of having an extra m_isDeleted
data member for this purpose.
- Take RenderStyle parameter by reference and drop the null check as the call site can never pass nullptr.
(WebCore::TextAutoSizingValue::addTextNode):
- Rename addNode() to addTextNode() for clarity.
(WebCore::TextAutoSizingValue::~TextAutoSizingValue):
Update destructor to call reset() so that the Document does not have to
call it explicitly and can instead just clear the HashMap, which will
destroy the TextAutoSizingValue objects.
(WebCore::TextAutoSizingValue::reset):
Rename text to renderer for clarity.
- rendering/TextAutoSizing.h:
- Make TextAutoSizingValue as fast allocated.
- Update TextAutoSizingValue to no longer be refcounted as ownership is never shared. The Document owns those.
- Drop the factory function for TextAutoSizingValue and make the constructor public now that the class is no longer refcounted.
- Make reset() method private now that it is called from the destructor and the Document is no longer expected to explicitly call it.
- Update adjustTextNodeSizes() to return a StillHasNodes enum class and the Document can rely on the determine if it can drop the TextAutoSizingValue from its HashMap (and therefore destroy the object).
- Drop numNodes() method as it is no longer needed.
- 3:44 PM Changeset in webkit [201533] by
-
- 2 edits in trunk/Tools
Unreviewed build fix; only run FullscreetTopContentInset test on platforms
where WK_API_ENABLED is set.
- TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenTopContentInset.mm:
- 3:35 PM Changeset in webkit [201532] by
-
- 20 edits3 deletes in trunk/Source
Unreviewed, rolling out r201363 and r201456.
https://bugs.webkit.org/show_bug.cgi?id=158240
"40% regression on date-format-xparb" (Requested by
keith_miller on #webkit).
Reverted changesets:
"LLInt should be able to cache prototype loads for values in
GetById"
https://bugs.webkit.org/show_bug.cgi?id=158032
http://trac.webkit.org/changeset/201363
"get_by_id should support caching unset properties in the
LLInt"
https://bugs.webkit.org/show_bug.cgi?id=158136
http://trac.webkit.org/changeset/201456
- 3:10 PM Changeset in webkit [201531] by
-
- 3 edits in trunk/Source/JavaScriptCore
Unreviewed, rolling out r201359.
https://bugs.webkit.org/show_bug.cgi?id=158238
"It was not a speedup on anything" (Requested by saamyjoon on
#webkit).
Reverted changeset:
"We can cache lookups to JSScope::abstractResolve inside
CodeBlock::finishCreation"
https://bugs.webkit.org/show_bug.cgi?id=158036
http://trac.webkit.org/changeset/201359
- 2:59 PM Changeset in webkit [201530] by
-
- 4 edits2 adds in trunk
REGRESSION (r201405): trailers.apple.com HUD is missing in fullscreen
https://bugs.webkit.org/show_bug.cgi?id=158156
<rdar://problem/26519589>
Reviewed by Darin Adler.
Source/WebKit2:
Only increase the frame of the webView (to account for top content inset) in one dimension.
- UIProcess/mac/WKFullScreenWindowController.mm:
(-[WKFullScreenWindowController enterFullScreen:]):
Tools:
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenTopContentInset.html: Added.
- TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenTopContentInset.mm: Added.
(-[FullscreenChangeMessageHandler userContentController:didReceiveScriptMessage:]):
(TestWebKitAPI::TEST):
- 2:57 PM Changeset in webkit [201529] by
-
- 4 edits2 adds in trunk
REGRESSION(r201040): Repainting of moving overflow:hidden objects is broken.
https://bugs.webkit.org/show_bug.cgi?id=158079
Reviewed by Zalan Bujtas.
Source/WebCore:
Added new test fast/repaint/overflow-hidden-movement.html
Change checkForRepaintDuringLayout() to only be true for self-painting layers
and not for all layers.
- rendering/RenderObject.cpp:
(WebCore::RenderObject::hasSelfPaintingLayer):
(WebCore::RenderObject::checkForRepaintDuringLayout):
- rendering/RenderObject.h:
(WebCore::RenderObject::hasSelfPaintingLayer):
LayoutTests:
- fast/repaint/overflow-hidden-movement-expected.txt: Added.
- fast/repaint/overflow-hidden-movement.html: Added.
- 2:56 PM Changeset in webkit [201528] by
-
- 2 edits in trunk/Source/WebCore
ShowRenderTree: Print location information for relative/sticky inlines.
https://bugs.webkit.org/show_bug.cgi?id=158235
Reviewed by David Hyatt.
- rendering/RenderObject.cpp:
(WebCore::RenderObject::showRenderObject):
- 2:47 PM Changeset in webkit [201527] by
-
- 2 edits in trunk/Websites/webkit.org
Unreviewed, fix an obvious typo: a missing comma.
- docs/b3/assembly-intermediate-representation.html:
- 2:44 PM Changeset in webkit [201526] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed build fix; use ASSERT_UNUSED rather than ASSERT to fix release builds.
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::removeSession):
- 2:40 PM Changeset in webkit [201525] by
-
- 2 edits in trunk/Websites/webkit.org
Air needs documentation
https://bugs.webkit.org/show_bug.cgi?id=153668
Reviewed by Mark Lam, Saam Barati, and Benjamin Poulain.
Write documentation for Air!
- docs/b3/assembly-intermediate-representation.html:
- 2:24 PM Changeset in webkit [201524] by
-
- 5 edits in trunk/Source/WebCore
[EME] Sound continues playing when video's src is changed
https://bugs.webkit.org/show_bug.cgi?id=158233
Reviewed by Eric Carlson.
When CDMSessionAVFoundation began listening for outputObscuredDueToInsufficientExternalProtection
KVO notifications, it retained the AVPlayer owned by MediaPlayerPrivateAVFoundationObjC, which
caused the AVPlayer to outlive its original owner, and to continue playing even after the
MediaPlayerPrivateAVFoundationObjC had been destroyed.
Rather than observe for outputObscuredDueToInsufficientExternalProtection changes in
CDMSessionAVFoundation, add a backreference from the media player to the session, listen for changes
in the player, and have the player notify the session when the value of that property changes.
- platform/graphics/avfoundation/objc/CDMSessionAVFoundationObjC.h:
(WebCore::CDMSessionAVFoundationObjC::createWeakPtr):
- platform/graphics/avfoundation/objc/CDMSessionAVFoundationObjC.mm:
(WebCore::CDMSessionAVFoundationObjC::CDMSessionAVFoundationObjC):
(-[WebCDMSessionAVFoundationObjCListener initWithParent:player:]): Deleted.
(-[WebCDMSessionAVFoundationObjCListener invalidate]): Deleted.
(-[WebCDMSessionAVFoundationObjCListener observeValueForKeyPath:ofObject:change:context:]): Deleted.
(WebCore::CDMSessionAVFoundationObjC::~CDMSessionAVFoundationObjC): Deleted.
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::removeSession):
(WebCore::MediaPlayerPrivateAVFoundationObjC::createSession):
(WebCore::MediaPlayerPrivateAVFoundationObjC::outputObscuredDueToInsufficientExternalProtectionChanged):
(WebCore::playerKVOProperties):
(-[WebCoreAVFMovieObserver observeValueForKeyPath:ofObject:change:context:]):
- 1:57 PM Changeset in webkit [201523] by
-
- 7 edits in trunk/Source/JavaScriptCore
[JSC] Recover parser performance regression by async support
https://bugs.webkit.org/show_bug.cgi?id=158228
Reviewed by Saam Barati.
This patch recovers parser performance regression caused in r201481.
Compared to the version that reverts r201481, still ~1% regression remains.
But compared to ToT, this patch significantly improves the code-load performance.
In Linux x64 JSCOnly port, with GCC 5.3.1.
reverted v.s. patched.
reverted patched
closure 0.61805+-0.00376 ? 0.62280+-0.00525 ?
jquery 8.03778+-0.02114 8.03453+-0.04646
<geometric> 2.22883+-0.00836 ? 2.23688+-0.00995 ? might be 1.0036x slower
ToT v.s. patched.
baseline patched
closure 0.65490+-0.00351 0.62473+-0.00363 definitely 1.0483x faster
jquery 8.25373+-0.06256 8.04701+-0.03455 definitely 1.0257x faster
<geometric> 2.32488+-0.00921 2.24210+-0.00592 definitely 1.0369x faster
- bytecode/UnlinkedFunctionExecutable.cpp:
(JSC::UnlinkedFunctionExecutable::UnlinkedFunctionExecutable):
- bytecode/UnlinkedFunctionExecutable.h:
Extend SourceParseMode.
- parser/Parser.cpp:
(JSC::Parser<LexerType>::parseInner):
(JSC::Parser<LexerType>::isArrowFunctionParameters):
Do not callmatchSpecIdentifier()as much as we can. This greatly improves the performance.
(JSC::Parser<LexerType>::parseStatementListItem):
(JSC::Parser<LexerType>::parseStatement):
(JSC::Parser<LexerType>::parseFunctionParameters):
(JSC::Parser<LexerType>::parseFunctionInfo):
Do not touchcurrentScope()->isGenerator()even if it is unnecessary in parseFunctionInfo.
And accidentalsyntaxChecker => contextchanges are fixed.
(JSC::Parser<LexerType>::parseClass):
(JSC::Parser<LexerType>::parseExpressionOrLabelStatement):
(JSC::Parser<LexerType>::parseImportClauseItem):
(JSC::Parser<LexerType>::parseExportDeclaration):
(JSC::Parser<LexerType>::parseAssignmentExpression):
Do not use matchSpecIdentifier() in the hot paths.
(JSC::Parser<LexerType>::parseProperty):
(JSC::Parser<LexerType>::parsePrimaryExpression):
(JSC::Parser<LexerType>::parseMemberExpression):
(JSC::Parser<LexerType>::parseUnaryExpression):
(JSC::Parser<LexerType>::printUnexpectedTokenText): Deleted.
- parser/Parser.h:
(JSC::isIdentifierOrKeyword):
AWAIT shoud be one of the keywords. This AWAIT check is unnecessary.
(JSC::Parser::upperScope):
(JSC::Parser::matchSpecIdentifier):
Touching currentScope() and its member causes significant performance degradation.
We carefully remove the above access in the hot paths.
(JSC::Parser::isDisallowedIdentifierAwait):
- parser/ParserModes.h:
(JSC::SourceParseModeSet::SourceParseModeSet):
(JSC::SourceParseModeSet::contains):
(JSC::SourceParseModeSet::mergeSourceParseModes):
(JSC::isFunctionParseMode):
(JSC::isAsyncFunctionParseMode):
(JSC::isAsyncArrowFunctionParseMode):
(JSC::isAsyncFunctionWrapperParseMode):
(JSC::isAsyncFunctionBodyParseMode):
(JSC::isModuleParseMode):
(JSC::isProgramParseMode):
(JSC::constructAbilityForParseMode):
The parser frequently checks SourceParseMode. And variety of SourceParseMode becomes many.
So using switch onto SourceParseMode degrades the performance. Instead, we use bit tests to guard against
many SourceParseModes. We expect that this will be efficiently compiled into test & jmp.
- parser/ParserTokens.h:
Change AWAIT to one of the keywords, as the same to YIELD / LET.
- 1:47 PM Changeset in webkit [201522] by
-
- 4 edits2 adds in trunk
[Mac] AirPlay route is sometimes reset when changing video.src
https://bugs.webkit.org/show_bug.cgi?id=158226
<rdar://problem/24197592>
Reviewed by Jer Noble.
Source/WebCore:
Test: media/airplay-autoplay.html
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::webkitShowPlaybackTargetPicker): Remove the gesture requirement
if currently processing a user gesture.
(WebCore::HTMLMediaElement::dispatchEvent): Set m_failedToPlayToWirelessTarget to false when
dispatching webkitcurrentplaybacktargetiswirelesschanged so an element can succeed after failing.
LayoutTests:
- media/airplay-autoplay-expected.txt: Added.
- media/airplay-autoplay.html: Added.
- 1:32 PM Changeset in webkit [201521] by
-
- 2 edits in trunk/Source/WebCore
Regression(r201482): Crash under dispatch_semaphore_wait
https://bugs.webkit.org/show_bug.cgi?id=158230
<rdar://problem/26534698>
Reviewed by Eric Carlson.
Stop moving hasSessionSemaphore in the lambda capture since it is used in
dispatch_semaphore_wait() call after the callOnMainThread() call.
No new tests, already covered by tests that are crashing on the bots.
- platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:
(-[WebAVStreamDataParserListener streamDataParser:didProvideContentKeyRequestInitializationData:forTrackID:]):
- 12:45 PM Changeset in webkit [201520] by
-
- 3 edits in trunk/Source/JavaScriptCore
Web Inspector: capturing with Allocations timeline causes GC to take 100x longer and cause frame drops
https://bugs.webkit.org/show_bug.cgi?id=158054
<rdar://problem/25280762>
Reviewed by Joseph Pecoraro.
HeapSnapshot::sweepCell was taking a long time on
http://bl.ocks.org/syntagmatic/6c149c08fc9cde682635
because it has to do a binary search to find if
an item is or is not in the list. 90% of the binary searches
would not find anything. This resulted in a lot of wasted time.
This patch adds a TinyBloomFilter member variable to HeapSnapshot.
We use this filter to try to bypass doing a binary search when the
filter tells us that a particular JSCell is definitely not in our
list. This is a 2x speedup on the steady state GC of the above
website.
- heap/HeapSnapshot.cpp:
(JSC::HeapSnapshot::appendNode):
(JSC::HeapSnapshot::sweepCell):
(JSC::HeapSnapshot::shrinkToFit):
(JSC::HeapSnapshot::nodeForCell):
- heap/HeapSnapshot.h:
- 12:35 PM Changeset in webkit [201519] by
-
- 4 edits in trunk/Source/WebKit2
[iOS] Better deal with WebProcess suspension due to screen locking
https://bugs.webkit.org/show_bug.cgi?id=158229
<rdar://problem/17665473>
<rdar://problem/26554699>
Reviewed by Tim Horton.
When locking the screen while MobileSafari is front-most, we would try keep
trying to mark IOSurfaces as volatile until the 30 seconds timeout was
reached. This patch deals more cleanly with this situation by only trying
to mark IOSurfaces as volatile once if the suspension is due to screen
locking. In such case, it is apparently expected that some IOSurfaces cannot
be marked as volatile so it is enough to try once and let ourselves get
suspended.
This patch also reduces the timeout from 30 seconds to ~3 seconds in the
other suspension cases (e.g. homing out of MobileSafari). If we fail to mark
them as purgeable for 3 seconds for a reason or another, it is no use in
retrying, it is simply not going to happen and there is no reason to delay
process suspension any further.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::callVolatilityCompletionHandlers):
(WebKit::WebPage::layerVolatilityTimerFired):
(WebKit::WebPage::markLayersVolatileImmediatelyIfPossible):
(WebKit::WebPage::markLayersVolatile):
- WebProcess/WebPage/WebPage.h:
(WebKit::WebPage::markLayersVolatile):
- WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::applicationDidEnterBackground):
(WebKit::WebPage::applicationWillEnterForeground):
- 12:33 PM Changeset in webkit [201518] by
-
- 15 edits1 add in trunk/Source
Make createCrossThreadTask() functions return on the stack instead of the heap.
https://bugs.webkit.org/show_bug.cgi?id=158215
Reviewed by Darin Adler.
Source/WebCore:
No new tests (Refactor, no change in behavior).
- Modules/indexeddb/client/IDBConnectionProxy.h:
- Modules/indexeddb/server/IDBServer.cpp:
(WebCore::IDBServer::IDBServer::postDatabaseTask):
(WebCore::IDBServer::IDBServer::postDatabaseTaskReply):
(WebCore::IDBServer::IDBServer::databaseRunLoop):
- Modules/indexeddb/server/IDBServer.h:
- Modules/indexeddb/server/UniqueIDBDatabase.cpp:
(WebCore::IDBServer::UniqueIDBDatabase::postDatabaseTask):
(WebCore::IDBServer::UniqueIDBDatabase::postDatabaseTaskReply):
- Modules/indexeddb/server/UniqueIDBDatabase.h:
- dom/ScriptExecutionContext.h:
(WebCore::ScriptExecutionContext::postCrossThreadTask):
- fileapi/ThreadableBlobRegistry.cpp:
(WebCore::threadableQueue):
Source/WebKit2:
- DatabaseProcess/DatabaseProcess.cpp:
(WebKit::DatabaseProcess::postDatabaseTask):
(WebKit::DatabaseProcess::performNextDatabaseTask):
(WebKit::DatabaseProcess::fetchWebsiteData):
- DatabaseProcess/DatabaseProcess.h:
Source/WTF:
- WTF.xcodeproj/project.pbxproj:
- wtf/CrossThreadCopier.cpp:
- wtf/CrossThreadQueue.h: Added. A lightweight of MessageQueue that deals directly in objects instead of in std::unique_ptrs.
(WTF::CrossThreadQueue::isKilled):
(WTF::CrossThreadQueue<DataType>::append):
(WTF::CrossThreadQueue<DataType>::waitForMessage):
(WTF::CrossThreadQueue<DataType>::tryGetMessage):
- wtf/CrossThreadTask.h:
(WTF::createCrossThreadTask):
(WTF::CrossThreadTask::CrossThreadTask): Deleted.
- 11:49 AM Changeset in webkit [201517] by
-
- 2 edits in trunk/Tools
Unreviewed: add myself to the reviewers list.
- Scripts/webkitpy/common/config/contributors.json:
- 11:42 AM Changeset in webkit [201516] by
-
- 4 edits3 adds in trunk
REGRESSION (r189567): Elements with aspect ratios not handled correctly inside flexbox.
https://bugs.webkit.org/show_bug.cgi?id=158040
Reviewed by Zalan Bujtas.
Source/WebCore:
Added new tests in fast/flexbox.
- rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::clientLogicalBottomAfterRepositioning):
(WebCore::RenderFlexibleBox::hasOrthogonalFlow):
(WebCore::RenderFlexibleBox::mainAxisContentExtent):
(WebCore::RenderFlexibleBox::computeMainAxisExtentForChild):
(WebCore::RenderFlexibleBox::mainAxisBorderAndPaddingExtentForChild):
(WebCore::RenderFlexibleBox::mainAxisLengthIsDefinite):
(WebCore::RenderFlexibleBox::mainAxisScrollbarExtentForChild):
(WebCore::RenderFlexibleBox::prepareOrderIteratorAndMargins):
(WebCore::RenderFlexibleBox::crossAxisLengthIsDefinite):
(WebCore::RenderFlexibleBox::computeMainSizeFromAspectRatioUsing):
(WebCore::RenderFlexibleBox::adjustChildSizeForAspectRatioCrossAxisMinAndMax):
(WebCore::RenderFlexibleBox::useChildAspectRatio):
(WebCore::RenderFlexibleBox::adjustChildSizeForMinAndMax):
(WebCore::RenderFlexibleBox::resetAutoMarginsAndLogicalTopInCrossAxis):
(WebCore::RenderFlexibleBox::mainAxisOverflowForChild):
(WebCore::RenderFlexibleBox::mainAxisExtentIsDefinite): Deleted.
(WebCore::RenderFlexibleBox::mainAxisLengthIsIndefinite): Deleted.
- rendering/RenderFlexibleBox.h:
(WebCore::RenderFlexibleBox::isFlexibleBoxImpl):
LayoutTests:
- fast/flexbox/aspect-ratio-intrinsic-adjust-expected.html: Added.
- fast/flexbox/aspect-ratio-intrinsic-adjust.html: Added.
- fast/flexbox/resources/subjects_sm.png: Added.
- 10:53 AM Changeset in webkit [201515] by
-
- 2 edits in trunk/Source/WebCore
Build fix after r201482.
- platform/network/curl/CurlDownload.cpp:
(WebCore::CurlDownload::didReceiveHeader):
header used to be capturedHeader, which was a StringCapture, which needed .string() to get the String.
Now it's a WTF::String, so we already have the String. Hooray for c++14!
- 8:58 AM Changeset in webkit [201514] by
-
- 23 edits in branches/safari-602.1.32-branch/Source
Merge r201474. rdar://problem/24476949
- 8:44 AM Changeset in webkit [201513] by
-
- 5 edits in branches/safari-602.1.32-branch/Source
Versioning.
- 8:42 AM Changeset in webkit [201512] by
-
- 5 edits in branches/safari-602.1.32.5-branch/Source
Versioning.
- 8:35 AM Changeset in webkit [201511] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed build fix.
- rendering/RenderGrid.cpp:
(WebCore::RenderGrid::computeUsedBreadthOfGridTracks):
(WebCore::RenderGrid::resolveContentBasedTrackSizingFunctions):
- 8:17 AM Changeset in webkit [201510] by
-
- 4 edits2 adds in trunk
[css-grid] Empty grid without explicit tracks shouldn't have any size
https://bugs.webkit.org/show_bug.cgi?id=155197
Reviewed by Darin Adler.
Source/WebCore:
The internal representation of the grid is a Vector of Vector representing rows and
columns. Because of that it was not possible to have columns without having at least one
row. That forced us to have a 1x1 internal representation of the grid even if it was
actually empty. That works for most of the cases except when the grid is actually empty.
By changing the way we compute the sizes we can overcome that implementation
restriction. This allowed us also to thighten the conditions under we could use the
GridIterator. From now on it won't be possible to use it on empty grids so callers should
enforce that restriction.
A new bool was added to verify that placeItemsOnGrid() has been already called. The previous
code was relying on the fact that there were items in the internal representation, which is
wrong, as there might be no items in the grid.
Test: fast/css-grid-layout/empty-grid.html
- rendering/RenderGrid.cpp:
(WebCore::RenderGrid::GridIterator::GridIterator): Added ASSERTs.
(WebCore::RenderGrid::GridIterator::nextGridItem): Ditto.
(WebCore::RenderGrid::GridIterator::isEmptyAreaEnough): Ditto.
(WebCore::RenderGrid::GridIterator::nextEmptyGridArea): Ditto.
(WebCore::RenderGrid::gridColumnCount): Use the style to resolve the number of columns if
the internal representation is empty.
(WebCore::RenderGrid::gridRowCount):
(WebCore::RenderGrid::guttersSize): Allow to pass 0 as span, this permits using the return
value of gridColumnCount|gridRowCount directly to call this method.
(WebCore::RenderGrid::computeIntrinsicLogicalWidths): Use m_gridIsDirty.
(WebCore::RenderGrid::computeUsedBreadthOfGridTracks): Do not examine the contents of grid
tracks if there are no items in the grid.
(WebCore::RenderGrid::resolveContentBasedTrackSizingFunctions): Ditto.
(WebCore::RenderGrid::placeItemsOnGrid): Set m_gridIsDirty to false.
(WebCore::RenderGrid::populateExplicitGridAndOrderIterator):
(WebCore::RenderGrid::clearGrid):
(WebCore::RenderGrid::populateGridPositionsForDirection):
- rendering/RenderGrid.h: Moved gridColumnCount/gridRowCount to cpp file.
LayoutTests:
Make sure that empty grids (and grids with one empty axis) are properly handled. Do also
verify that removing all the items from a grid also generates an correct empty grid.
- fast/css-grid-layout/empty-grid-expected.txt: Added.
- fast/css-grid-layout/empty-grid.html: Added.
- 3:34 AM Changeset in webkit [201509] by
-
- 2 edits in trunk/Tools
[GTK] Provide alternative mirror for the ICU tarball.
https://bugs.webkit.org/show_bug.cgi?id=154530
Unreviewed.
- gtk/jhbuild.modules: After r201449 the GTK+ ARM buildbot is having
a hard time trying to download the ICU tarball from download.icu-project.org
(which redirects to sourceforge and gives problems with something related to
SSL). Provide this alternative mirror to make things working back.
- 2:27 AM Changeset in webkit [201508] by
-
- 1 copy in releases/WebKitGTK/webkit-2.13.1
WebKitGTK+ 2.13.1
- 2:25 AM Changeset in webkit [201507] by
-
- 4 edits in trunk
Unreviewed. Update OptionsGTK.cmake and NEWS for 2.13.1 release.
.:
- Source/cmake/OptionsGTK.cmake: Bump version numbers.
Source/WebKit2:
- gtk/NEWS: Add release notes for 2.13.1.
- 12:51 AM Changeset in webkit [201506] by
-
- 2 edits in trunk/Source/WebKit2
Unreviewed. Fix GTK+ clean build after r201504.
- DatabaseProcess/DatabaseProcess.cpp: Add missing include.
- 12:22 AM Changeset in webkit [201505] by
-
- 2 edits in trunk/Tools
[GTK] Test /webkit2/WebKitWebView/geolocation-permission-requests is failing since r201423
https://bugs.webkit.org/show_bug.cgi?id=158200
Reviewed by Philippe Normand.
This is because geolocation is no longer allowed for non secure sites, like HTTP. In that case
POSITION_UNAVAILABLE is returned without asking the API layer.
- TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
(testWebViewGeolocationPermissionRequests): Keep the HTTP case to check that it indeed returns
POSITION_UNAVAILABLE and use HTTPS URLs to check permission requests are allowed or denied. Also stop using the
document title, and use user script messages that are more reliable instead.
May 30, 2016:
- 8:35 PM Changeset in webkit [201504] by
-
- 22 edits3 moves2 adds2 deletes in trunk/Source
Move CrossThreadCopier/CrossThreadTask to WTF.
https://bugs.webkit.org/show_bug.cgi?id=158207
Reviewed by Alex Christensen.
Source/WebCore:
No new tests (Refactor, no behavior change).
- CMakeLists.txt:
- WebCore.xcodeproj/project.pbxproj:
- Modules/indexeddb/IDBActiveDOMObject.h:
- Modules/indexeddb/IDBValue.cpp:
- Modules/indexeddb/client/IDBConnectionProxy.h:
- Modules/indexeddb/server/IDBServer.cpp:
- Modules/indexeddb/server/IDBServer.h:
- Modules/indexeddb/server/UniqueIDBDatabase.h:
- dom/ScriptExecutionContext.h:
- fileapi/ThreadableBlobRegistry.cpp:
- platform/WebCoreCrossThreadCopier.cpp: Added.
(WTF::WebCore::SessionID>::copy):
(WTF::WebCore::ThreadSafeDataBuffer>::copy):
- platform/WebCoreCrossThreadCopier.h: Added.
- platform/network/cf/ResourceError.h:
(WebCore::ResourceError::isolatedCopy):
- platform/network/cf/ResourceRequest.h:
(WebCore::ResourceRequest::isolatedCopy):
- platform/network/cf/ResourceResponse.h:
(WebCore::ResourceResponse::isolatedCopy):
Source/WebKit2:
- CMakeLists.txt:
- WebKit2.xcodeproj/project.pbxproj:
- DatabaseProcess/DatabaseProcess.cpp:
- DatabaseProcess/DatabaseProcess.h:
- Shared/WebCrossThreadCopier.cpp: Removed.
- Shared/WebCrossThreadCopier.h: Removed.
Source/WTF:
- WTF.xcodeproj/project.pbxproj:
- wtf/CMakeLists.txt:
- wtf/CrossThreadCopier.cpp: Renamed from Source/WebCore/platform/CrossThreadCopier.cpp.
- wtf/CrossThreadCopier.h: Renamed from Source/WebCore/platform/CrossThreadCopier.h.
(WTF::CrossThreadCopierPassThrough::copy):
- wtf/CrossThreadTask.h: Renamed from Source/WebCore/platform/CrossThreadTask.h.
(WTF::CrossThreadTask::CrossThreadTask):
(WTF::CrossThreadTask::performTask):
(WTF::createCrossThreadTask):
- 8:25 PM Changeset in webkit [201503] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Timelines: "-0.000ms" in Self Time
https://bugs.webkit.org/show_bug.cgi?id=158162
<rdar://problem/26523350>
Reviewed by Darin Adler.
Values such as -0.0000 and +0.00001 seem to indicate there is
some floating point error accumulating in profile node data.
Since the sampling profiler isn't accurate to that precision,
let's clean up the data so near-zero numbers are simply zero.
- UserInterface/Models/ProfileNode.js:
Round selfTime down to zero if it's less than the
smallest value we would show in the user interface.
- 1:26 PM Changeset in webkit [201502] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Uncaught exception page should pre-populate the bug's URL with the inspected page URL
https://bugs.webkit.org/show_bug.cgi?id=158055
<rdar://problem/26516693>
Reviewed by Saam Barati.
- UserInterface/Debug/UncaughtExceptionReporter.js:
Include the encoded URL in the query string if it is not empty.
- 12:03 PM Changeset in webkit [201501] by
-
- 2 edits in trunk/LayoutTests
Unreviewed test gardening.
After the crash fix in r201500, update the test expectations for
http/tests/websocket/tests/hybi/stop-on-resume-in-error-handler.html.
Patch by Per Arne Vollan <pvollan@apple.com> on 2016-05-30
- platform/win/TestExpectations:
- 11:44 AM Changeset in webkit [201500] by
-
- 2 edits in trunk/Source/WebCore
http/tests/websocket/tests/hybi/stop-on-resume-in-error-handler.html crashes on Windows almost all the time
https://bugs.webkit.org/show_bug.cgi?id=144057
Patch by Per Arne Vollan <pvollan@apple.com> on 2016-05-30
Reviewed by Brent Fulgham.
Protect SocketStreamHandle object before trying to access it on the main thread, and make sure
CFWriteStreamRef parameter is valid before calling CFWriteStreamCanAcceptBytes.
- platform/network/cf/SocketStreamHandleCFNet.cpp:
(WebCore::SocketStreamHandle::readStreamCallback):
(WebCore::SocketStreamHandle::writeStreamCallback):
- 9:56 AM Changeset in webkit [201499] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Right-clicking in Snapshot's DataGrid throws an exception
https://bugs.webkit.org/show_bug.cgi?id=157934
<rdar://problem/26380910>
Reviewed by Brian Burg.
Check that click event target is actually a cell, as it can be a row
when focusing the table after dismissing a popup menu.
- UserInterface/Views/DataGrid.js:
(WebInspector.DataGridNode.prototype.isEventWithinDisclosureTriangle):
- 1:14 AM Changeset in webkit [201498] by
-
- 28 edits2 adds in trunk
[CSS Box Alignment] New CSS Value 'normal' for Self Alignment
https://bugs.webkit.org/show_bug.cgi?id=156254
Reviewed by Darin Adler.
Source/WebCore:
The Box Alignment specification defines a new value 'normal' to be used
as default for the different layout models, which will define the
specific behavior for each case. This patch adds a new CSS value in the
parsing logic and adapts the Self Alignment properties to the new
value.
The 'auto' value is no longer valid for the 'align-items' property and
the Computed Value will be always the specified value. Hence, I removed
the StyleResolver logic because is not required now; the specific
behavior of the 'normal' value will be resolved at layout time.
Additionally, this patch updates the layout logic as well, for both
Flexbox and Grid layout models.
Test: css3/parse-alignment-of-root-elements.html
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::resolveLegacyJustifyItems): Added.
(WebCore::resolveJustifyItemsAuto): Added.
(WebCore::resolveJustifySelfAuto): Added.
(WebCore::resolveAlignSelfAuto): Added.
(WebCore::valueForItemPositionWithOverflowAlignment): Using a StyleSelfAlignmentData argument.
(WebCore::ComputedStyleExtractor::propertyValue): Using the new resolving functions.
- css/CSSParser.cpp:
(WebCore::CSSParser::parseItemPositionOverflowPosition): A new value 'normal' is now valid.
- css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue): Mappings for the new value 'normal'.
(WebCore::CSSPrimitiveValue::operator ItemPosition): Mappings for the new value 'normal'.
- css/CSSPropertyNames.in:
- css/StyleResolver.cpp:
(WebCore::StyleResolver::adjustRenderStyle): We don't need to resolve 'legacy" keyword.
- rendering/RenderBox.cpp:
(WebCore::flexItemHasStretchAlignment):
(WebCore::RenderBox::hasStretchedLogicalWidth):
- rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::styleDidChange):
(WebCore::RenderFlexibleBox::alignmentForChild):
(WebCore::contentAlignmentNormalBehaviorFlexibleBox):
(WebCore::RenderFlexibleBox::layoutAndPlaceChildren):
(WebCore::RenderFlexibleBox::layoutColumnReverse):
(WebCore::RenderFlexibleBox::alignFlexLines):
(WebCore::RenderFlexibleBox::alignChildren):
- rendering/RenderGrid.cpp:
(WebCore::defaultAlignmentChangedToStretchInRowAxis):
(WebCore::defaultAlignmentChangedFromStretchInRowAxis):
(WebCore::defaultAlignmentChangedFromStretchInColumnAxis):
(WebCore::selfAlignmentChangedToStretchInRowAxis):
(WebCore::selfAlignmentChangedFromStretchInRowAxis):
(WebCore::selfAlignmentChangedFromStretchInColumnAxis):
(WebCore::contentAlignmentNormalBehaviorGrid):
(WebCore::RenderGrid::applyStretchAlignmentToTracksIfNeeded):
(WebCore::RenderGrid::needToStretchChildLogicalHeight):
(WebCore::RenderGrid::applyStretchAlignmentToChildIfNeeded):
(WebCore::RenderGrid::columnAxisPositionForChild):
(WebCore::RenderGrid::rowAxisPositionForChild):
(WebCore::RenderGrid::columnAxisOffsetForChild):
(WebCore::RenderGrid::rowAxisOffsetForChild):
(WebCore::RenderGrid::computeContentPositionAndDistributionOffset):
- rendering/style/RenderStyle.cpp:
(WebCore::resolvedSelfAlignment):
(WebCore::RenderStyle::resolvedAlignItems):
(WebCore::RenderStyle::resolvedAlignSelf):
(WebCore::RenderStyle::resolvedJustifyItems):
(WebCore::RenderStyle::resolvedJustifySelf):
- rendering/style/RenderStyle.h:
- rendering/style/RenderStyleConstants.h:
- rendering/style/StyleRareNonInheritedData.cpp:
(WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData): align-items uses now a different initial function.
LayoutTests:
Changes in the already defined tests for the alignment properties to
consider the new CSS value 'normal', which is the default for align-items
and the value to resolve 'auto' when there is no parent.
Added a new test to verify the Self-Alignment properties work as expected
with root elements.
- css3/flexbox/css-properties-expected.txt:
- css3/flexbox/css-properties.html:
- css3/parse-align-items-expected.txt:
- css3/parse-align-items.html:
- css3/parse-align-self-expected.txt:
- css3/parse-align-self.html:
- css3/parse-alignment-of-root-elements-expected.txt: Added.
- css3/parse-alignment-of-root-elements.html: Added.
- fast/css/getComputedStyle/computed-style-expected.txt:
- fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
- fast/css/parse-justify-items-expected.txt:
- fast/css/parse-justify-items.html:
- fast/css/parse-justify-self-expected.txt:
- fast/css/parse-justify-self.html:
- fast/css/resources/alignment-parsing-utils.js:
- svg/css/getComputedStyle-basic-expected.txt:
(checkBadValues):
- svg/css/getComputedStyle-basic-expected.txt:
May 29, 2016:
- 11:53 PM Changeset in webkit [201497] by
-
- 10 edits in trunk/Source/WebCore
Transition various Task/Function queues from std::function to NoncopyableFunction.
https://bugs.webkit.org/show_bug.cgi?id=158196
Reviewed by Chris Dumez.
No new tests (Refactor, no behavior change).
- dom/ActiveDOMCallbackMicrotask.cpp:
(WebCore::ActiveDOMCallbackMicrotask::ActiveDOMCallbackMicrotask):
- dom/ActiveDOMCallbackMicrotask.h:
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::layoutSizeChanged):
- page/FrameView.cpp:
(WebCore::FrameView::queuePostLayoutCallback):
(WebCore::FrameView::flushPostLayoutTasksQueue):
- page/FrameView.h:
- platform/GenericTaskQueue.cpp:
(WebCore::TaskDispatcher<Timer>::postTask):
(WebCore::TaskDispatcher<Timer>::dispatchOneTask):
- platform/GenericTaskQueue.h:
(WebCore::TaskDispatcher::postTask):
(WebCore::GenericTaskQueue::enqueueTask):
- style/StyleTreeResolver.cpp:
(WebCore::Style::postResolutionCallbackQueue):
(WebCore::Style::queuePostResolutionCallback):
(WebCore::Style::suspendMemoryCacheClientCalls):
- style/StyleTreeResolver.h:
- 11:23 PM WebKitGTK/Gardening/Calendar edited by
- (diff)
- 9:30 PM Changeset in webkit [201496] by
-
- 7 edits in trunk/Source/WebCore
Make ScriptExecutionContext::Task work in terms of wtf::NoncopyableFunction instead of std::function.
https://bugs.webkit.org/show_bug.cgi?id=158187
Reviewed by Chris Dumez.
No new tests (Refactor, no behavior change).
Also make postTask take an rvalue reference.
- bindings/js/JSDOMGlobalObjectTask.cpp:
(WebCore::JSGlobalObjectTask::JSGlobalObjectTask):
- dom/Document.cpp:
(WebCore::Document::postTask):
- dom/Document.h:
- dom/ScriptExecutionContext.h:
(WebCore::ScriptExecutionContext::Task::Task):
- workers/WorkerGlobalScope.cpp:
(WebCore::WorkerGlobalScope::postTask):
- workers/WorkerGlobalScope.h:
- 12:01 PM Changeset in webkit [201495] by
-
- 9 edits1 add in trunk/Source/JavaScriptCore
Stack overflow crashes with deep or cyclic proxy prototype chains
https://bugs.webkit.org/show_bug.cgi?id=157087
Reviewed by Filip Pizlo and Mark Lam.
Because a Proxy can call back into the JS runtime in arbitrary
ways, we may have effectively cyclic prototype chains and property lookups
by using a Proxy. We may also have arbitrarily long Proxy chains
where we call into a C frame for each link in the Proxy chain.
This means that every Proxy hook must be aware that it can stack overflow.
Before, only certain hooks were aware of this fact. That was a bug,
all hooks must assume they can stack overflow.
Also, because we may have effectively cyclic prototype chains, we
compile ProxyObject.cpp with -fno-optimize-sibling-calls. This prevents
tail call optimization from happening on any of the calls from
ProxyObject.cpp. We do this because we rely on the machine stack
growing for throwing a stack overflow error. It's better for developers
to be able to see a stack overflow error than to have their program
infinite loop because the compiler performed TCO.
This patch also fixes a couple call sites of various methods
where we didn't check for an exception.
- CMakeLists.txt:
- JavaScriptCore.xcodeproj/project.pbxproj:
- interpreter/Interpreter.cpp:
(JSC::sizeOfVarargs):
- runtime/InternalFunction.cpp:
(JSC::InternalFunction::createSubclassStructure):
- runtime/JSArray.h:
(JSC::getLength):
- runtime/ObjectPrototype.cpp:
(JSC::objectProtoFuncToString):
- runtime/ProxyObject.cpp:
(JSC::performProxyGet):
(JSC::ProxyObject::performInternalMethodGetOwnProperty):
(JSC::ProxyObject::performHasProperty):
(JSC::ProxyObject::getOwnPropertySlotCommon):
(JSC::ProxyObject::performPut):
(JSC::performProxyCall):
(JSC::performProxyConstruct):
(JSC::ProxyObject::performDelete):
(JSC::ProxyObject::performPreventExtensions):
(JSC::ProxyObject::performIsExtensible):
(JSC::ProxyObject::performDefineOwnProperty):
(JSC::ProxyObject::performGetOwnPropertyNames):
(JSC::ProxyObject::getOwnPropertyNames):
(JSC::ProxyObject::getPropertyNames):
(JSC::ProxyObject::getOwnNonIndexPropertyNames):
(JSC::ProxyObject::performSetPrototype):
(JSC::ProxyObject::performGetPrototype):
- runtime/ProxyObject.h:
(JSC::ProxyObject::create):
- tests/stress/proxy-stack-overflow-exceptions.js: Added.
(shouldThrowStackOverflow):
(const.emptyFunction):
(makeLongProxyChain):
(shouldThrowStackOverflow.longProxyChain):
(shouldThrowStackOverflow.effecivelyCyclicProxyProtoChain1):
(shouldThrowStackOverflow.effecivelyCyclicProxyProtoChain2):
(shouldThrowStackOverflow.effecivelyCyclicProxyProtoChain3):
(shouldThrowStackOverflow.longProxyChainBind):
(shouldThrowStackOverflow.longProxyChainPropertyAccess):
(shouldThrowStackOverflow.longProxyChainReflectConstruct):
(shouldThrowStackOverflow.longProxyChainReflectSet):
(shouldThrowStackOverflow.longProxyChainReflectOwnKeys):
(shouldThrowStackOverflow.longProxyChainGetPrototypeOf):
(shouldThrowStackOverflow.longProxyChainSetPrototypeOf):
(shouldThrowStackOverflow.longProxyChainGetOwnPropertyDescriptor):
(shouldThrowStackOverflow.longProxyChainDefineProperty):
(shouldThrowStackOverflow.longProxyChainIsExtensible):
(shouldThrowStackOverflow.longProxyChainPreventExtensions):
(shouldThrowStackOverflow.longProxyChainDeleteProperty):
(shouldThrowStackOverflow.longProxyChainWithScope):
(shouldThrowStackOverflow.longProxyChainWithScope2):
(shouldThrowStackOverflow.longProxyChainWithScope3):
(shouldThrowStackOverflow.longProxyChainArrayPrototypePush):
(shouldThrowStackOverflow.longProxyChainWithScope4):
(shouldThrowStackOverflow.longProxyChainCall):
(shouldThrowStackOverflow.longProxyChainConstruct):
(shouldThrowStackOverflow.longProxyChainHas):
May 28, 2016:
- 9:47 PM Changeset in webkit [201494] by
-
- 3 edits in trunk/Source/JavaScriptCore
JSGlobalLexicalEnvironment leaks SegmentedVector due to lack of destructor.
<https://webkit.org/b/158186>
Reviewed by Saam Barati.
Give JSGlobalLexicalEnvironment a destroy() and set up a finalizer for it
like we do with JSGlobalObject. (This is needed because they don't inherit
from JSDestructibleObjects and thus can't use JSCell::needsDestruction to
ask for allocation in destructor space.)
This stops us from leaking all the SegmentedVector backing stores.
- runtime/JSGlobalLexicalEnvironment.cpp:
(JSC::JSGlobalLexicalEnvironment::destroy):
- runtime/JSGlobalLexicalEnvironment.h:
(JSC::JSGlobalLexicalEnvironment::create):
- 9:20 PM Changeset in webkit [201493] by
-
- 37 edits in trunk/Source
Templatize NoncopyableFunction class similarly to std::function
https://bugs.webkit.org/show_bug.cgi?id=158185
Reviewed by Darin Adler.
Templatize NoncopyableFunction class similarly to std::function, so
that it can be used as a std::function replacement in more places.
Previously, NoncopyableFunction could only support "void()" lambdas.
Source/WebCore:
- Modules/mediastream/MediaEndpointPeerConnection.cpp:
(WebCore::MediaEndpointPeerConnection::runTask):
- Modules/mediastream/MediaEndpointPeerConnection.h:
- fileapi/AsyncFileStream.cpp:
(WebCore::callOnFileThread):
(WebCore::AsyncFileStream::perform):
(WebCore::AsyncFileStream::getSize):
(WebCore::AsyncFileStream::openForRead):
(WebCore::AsyncFileStream::openForWrite):
(WebCore::AsyncFileStream::write):
- fileapi/AsyncFileStream.h:
- page/scrolling/ScrollingThread.cpp:
(WebCore::ScrollingThread::dispatch):
(WebCore::ScrollingThread::dispatchBarrier):
(WebCore::ScrollingThread::dispatchFunctionsFromScrollingThread):
- page/scrolling/ScrollingThread.h:
- platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.h:
- platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm:
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::scheduleDeferredTask):
- platform/mediastream/MediaStreamPrivate.cpp:
(WebCore::MediaStreamPrivate::scheduleDeferredTask):
- platform/mediastream/MediaStreamPrivate.h:
- platform/mediastream/mac/AVMediaCaptureSource.h:
- platform/mediastream/mac/AVMediaCaptureSource.mm:
(WebCore::AVMediaCaptureSource::scheduleDeferredTask):
Source/WebKit:
- Storage/StorageSyncManager.cpp:
(WebCore::StorageSyncManager::dispatch):
- Storage/StorageSyncManager.h:
- Storage/StorageThread.cpp:
(WebCore::StorageThread::dispatch):
(WebCore::StorageThread::terminate):
- Storage/StorageThread.h:
Source/WebKit2:
- NetworkProcess/cache/NetworkCacheIOChannelSoup.cpp:
(WebKit::NetworkCache::runTaskInQueue):
Source/WTF:
- wtf/FunctionDispatcher.h:
- wtf/MainThread.cpp:
(WTF::functionQueue):
(WTF::dispatchFunctionsFromMainThread):
(WTF::callOnMainThread):
- wtf/MainThread.h:
- wtf/NoncopyableFunction.h:
- wtf/RunLoop.cpp:
(WTF::RunLoop::performWork):
(WTF::RunLoop::dispatch):
- wtf/RunLoop.h:
- wtf/WorkQueue.h:
- wtf/cocoa/WorkQueueCocoa.cpp:
(WTF::WorkQueue::dispatch):
(WTF::WorkQueue::dispatchAfter):
- wtf/efl/DispatchQueueWorkItemEfl.h:
(WorkItem::WorkItem):
(TimerWorkItem::create):
(TimerWorkItem::TimerWorkItem):
- wtf/efl/WorkQueueEfl.cpp:
(WTF::WorkQueue::dispatch):
(WTF::WorkQueue::dispatchAfter):
- wtf/generic/RunLoopGeneric.cpp:
(WTF::RunLoop::TimerBase::ScheduledTask::create):
(WTF::RunLoop::TimerBase::ScheduledTask::ScheduledTask):
(WTF::RunLoop::dispatchAfter):
- wtf/generic/WorkQueueGeneric.cpp:
(WorkQueue::dispatch):
(WorkQueue::dispatchAfter):
- wtf/glib/RunLoopGLib.cpp:
(WTF::DispatchAfterContext::DispatchAfterContext):
(WTF::RunLoop::dispatchAfter):
- wtf/win/WorkItemWin.cpp:
(WTF::WorkItemWin::WorkItemWin):
(WTF::WorkItemWin::create):
(WTF::HandleWorkItem::HandleWorkItem):
(WTF::HandleWorkItem::createByAdoptingHandle):
- wtf/win/WorkItemWin.h:
(WTF::WorkItemWin::function):
- wtf/win/WorkQueueWin.cpp:
(WTF::WorkQueue::dispatch):
(WTF::WorkQueue::dispatchAfter):
- 4:16 PM Changeset in webkit [201492] by
-
- 8 edits in trunk/Source
Fix the build with newer clang and other custom configuration options
https://bugs.webkit.org/show_bug.cgi?id=158161
Reviewed by Dan Bernstein.
Source/WebCore:
- platform/mac/WebVideoFullscreenInterfaceMac.mm:
(WebCore::WebVideoFullscreenInterfaceMac::rateChanged): Added UNUSED_PARAMs for the
case where this function is unimplemented.
(WebCore::WebVideoFullscreenInterfaceMac::setExternalPlayback): Added a non-additions
version of this function.
- platform/spi/cf/CFNetworkSPI.h: Silence nullability-completeness (and other) warnings.
I doubt that it's practical to get these right for every SDK version at this time. Added
functions for overriding HTTPS certicate behavior that we used to declare in .m files.
- platform/spi/mac/AVFoundationSPI.h: Define AVAssetCache conditionally.
Source/WebKit2:
- NetworkProcess/ios/NetworkProcessIOS.mm: -setAllowsSpecificHTTPSCertificate:forHost:
is now in CFNetworkSPI.h
- NetworkProcess/mac/NetworkProcessMac.mm: Ditto.
- Shared/mac/CookieStorageShimLibrary.cpp:
(WebKit::WebKitCookieStorageShimInitialize): Use more portable std::call_once.
- 12:53 PM Changeset in webkit [201491] by
-
- 2 edits in trunk/LayoutTests/imported/w3c
Adding wptserve logging for 404 file-serving responses
https://bugs.webkit.org/show_bug.cgi?id=158183
Reviewed by Alexey Proskuryakov.
- resources/web-platform-tests-modules.json: Modifying wptserve module to log 404 FileHandler exceptions.
- 12:18 PM Changeset in webkit [201490] by
-
- 21 edits1 copy1 move3 adds in trunk
Autocorrection makes it hard to type "doesn't" and to type @ in email addresses
https://bugs.webkit.org/show_bug.cgi?id=158177
.:
Reviewed by Darin Adler.
Fixed manual tests for autocorrection panels and added a manual test for . Most of changes are fixing up the path to LayoutTests/editing/editing.js.
Also wrap many steps to type in a space or delete a character inside setTimeout since autocorrection happens on a timer
and the fact WebKit2 communicates with NSSpellChecker via IPC makes the behavior even more indeterministic.
- ManualTests/autocorrection/autocorrection-at-mark.html: Added.
- ManualTests/autocorrection/autocorrection-cancelled-by-ESC.html:
- ManualTests/autocorrection/autocorrection-cancelled-by-typing-1.html:
- ManualTests/autocorrection/autocorrection-contraction-2.html: Added.
- ManualTests/autocorrection/autocorrection-contraction.html:
- ManualTests/autocorrection/autocorrection-in-iframe.html:
- ManualTests/autocorrection/close-window-when-correction-is-shown.html:
- ManualTests/autocorrection/continue-typing-to-dismiss-reversion.html:
- ManualTests/autocorrection/delete-to-dismiss-reversion.html:
- ManualTests/autocorrection/delete-to-end-of-word-to-show-reversion.html:
- ManualTests/autocorrection/dismiss-multiple-guesses.html:
- ManualTests/autocorrection/document-for-iframe-test.html: Removed.
- ManualTests/autocorrection/move-to-end-of-word-to-show-reversion.html: Type a space and move care in setTimeout as
the reversion panel wouldn't show up otherwise.
- ManualTests/autocorrection/remove-misspelling-marker-after-appending-letter.html: Delay the typing of a space as well as
deleting letters since autocorrection panel wouldn't show up in time otherwise, and deleting character immediately would
reject the autocorrection instead of accepting it. Also removed the steps to add back the spellchecking marker and extracted
it as a separate test.
- ManualTests/autocorrection/removing-misspelling-marker-after-appending-letter-2.html: Copied. This test continues the full
scenario in the previous test by typing a space and deleting the character, thereby bringing up spellchecking marker.
- ManualTests/autocorrection/resources: Added.
- ManualTests/autocorrection/resources/document-for-iframe-test.html: Moved from ManualTests/autocorrection/.
- ManualTests/autocorrection/select-from-multiple-guesses.html: Added a missing instruction.
- ManualTests/autocorrection/spell-checking-after-reversion.html:
- ManualTests/autocorrection/type-whitespace-to-dismiss-reversion.html: Delay the typing of a space and moving the selection
since the reversion panel wouldn't show up otherwise.
- ManualTests/autocorrection/undo-autocorrection-2.html: Copied. Automated most of steps in the second test case.
- ManualTests/autocorrection/undo-autocorrection.html:
Source/WebCore:
<rdar://problem/20490862>
<rdar://problem/24707954>
Reviewed by Darin Adler.
When the user had typed "doesn'", some unified spellchecker may try to autocorrect it to "doesn't" or "does"
but we should ignore this for a moment until the next character is typed by the user. The code to deal with
this situation which checks the existence of an "ambiguous boundary character" was not robust when the
replacement text was longer than the corrected text.
Fixed this bug by fixing the logic to detect this case. Also added '@' as an ambiguous boundary character
since autocorrecting letters that appear right before '@' would not be useful in many cases.
Tests: ManualTests/autocorrection/autocorrection-at-mark.html
ManualTests/autocorrection/autocorrection-contraction-2.html
- editing/AlternativeTextController.cpp:
(WebCore::AlternativeTextController::timerFired): Fixed a bug that we can show an empty reversion panel.
- editing/Editor.cpp:
(WebCore::Editor::markAndReplaceFor): When the user had typed "doesn'" and our autocorrection result is
"doesn't", resultEndLocation (the end of "doesn't") is larger than selectionOffset (the end of "doesn'").
When the correction is "does", resultEndLocation (the end of "does") is one less than selectionOffset.
Updated the condition to deal with both of these conditions as well as cases where the correction result
contains more than one letter after '.
- editing/htmlediting.cpp:
(WebCore::isAmbiguousBoundaryCharacter): Moved from the header file since this is not a hot function and
doesn't need to be inlined everywhere. Added '@' as an ambiguous boundary character.
- editing/htmlediting.h:
(WebCore::isAmbiguousBoundaryCharacter): Moved to the cpp file.
- 11:27 AM Changeset in webkit [201489] by
-
- 2 edits in trunk/Tools
tests fail if display sleeps while run-webkit-tests is running
https://bugs.webkit.org/show_bug.cgi?id=153919
Reviewed by Darin Adler.
- DumpRenderTree/mac/LayoutTestHelper.m:
(addDisplaySleepAssertion): Use PreventUserIdleSystemSleep flag, same as set by caffeinate tool.
- 11:26 AM Changeset in webkit [201488] by
-
- 6 edits1 add in trunk
[Next] Trailing commas in function parameters.
https://bugs.webkit.org/show_bug.cgi?id=158020
Reviewed by Keith Miller.
ESNext allow to add trailing commas in function parameters and function arguments.
Link to spec - https://jeffmo.github.io/es-trailing-function-commas
Example of using - (function (a, b,) { return a + b; })(1,2,);
- parser/Parser.cpp:
(JSC::Parser<LexerType>::parseFormalParameters):
(JSC::Parser<LexerType>::parseArguments):
- tests/stress/trailing-comma-in-function-paramters.js: Added.
- 10:47 AM Changeset in webkit [201487] by
-
- 13 edits in trunk/Source/JavaScriptCore
[JSC] op_new_arrow_func_exp is no longer necessary
https://bugs.webkit.org/show_bug.cgi?id=158180
Reviewed by Saam Barati.
This patch removes op_new_arrow_func_exp bytecode since
what op_new_arrow_func_exp is doing is completely the same to op_new_func_exp.
- bytecode/BytecodeList.json:
- bytecode/BytecodeUseDef.h:
(JSC::computeUsesForBytecodeOffset): Deleted.
(JSC::computeDefsForBytecodeOffset): Deleted.
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::dumpBytecode): Deleted.
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::emitNewFunctionExpressionCommon):
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
- dfg/DFGCapabilities.cpp:
(JSC::DFG::capabilityLevel): Deleted.
- jit/JIT.cpp:
(JSC::JIT::privateCompileMainPass): Deleted.
- jit/JIT.h:
- jit/JITOpcodes.cpp:
(JSC::JIT::emitNewFuncExprCommon):
(JSC::JIT::emit_op_new_arrow_func_exp): Deleted.
- llint/LLIntSlowPaths.cpp:
(JSC::LLInt::LLINT_SLOW_PATH_DECL): Deleted.
- llint/LLIntSlowPaths.h:
- llint/LowLevelInterpreter.asm:
- 10:05 AM Changeset in webkit [201486] by
-
- 3 edits in trunk/Source/WebCore
FileSystem: use OS(WINDOWS) instead of PLATFORM(WIN).
https://bugs.webkit.org/show_bug.cgi?id=158168
Reviewed by Darin Adler.
No new tests needed.
- platform/FileSystem.cpp:
(WebCore::lastComponentOfPathIgnoringTrailingSlash):
(WebCore::MappedFileData::~MappedFileData):
(WebCore::MappedFileData::MappedFileData):
- platform/FileSystem.h: Removed unused PlatformFilePathSeparator
constant.
- 9:55 AM Changeset in webkit [201485] by
-
- 3 edits in trunk/Source/WebCore
Use COMPILER(MSVC) instead of PLATFORM(WIN) for MSVC-specific workaround
https://bugs.webkit.org/show_bug.cgi?id=158169
Reviewed by NOBODY (OOPS!).
No new tests needed.
- platform/PlatformMouseEvent.h:
- platform/win/PlatformMouseEventWin.cpp: Moved operators'
implementations to PlatformMouseEvent.h
- 9:54 AM Changeset in webkit [201484] by
-
- 7 edits in trunk/Source/WebKit2
Modernize lambda captures in the network disk cache implementation
https://bugs.webkit.org/show_bug.cgi?id=158179
Reviewed by Darin Adler.
Modernize lambda captures in the network disk cache implementation.
- NetworkProcess/cache/NetworkCache.cpp:
(WebKit::NetworkCache::Cache::retrieve):
(WebKit::NetworkCache::Cache::store):
(WebKit::NetworkCache::Cache::traverse):
- NetworkProcess/cache/NetworkCache.h:
- NetworkProcess/cache/NetworkCacheIOChannelSoup.cpp:
(WebKit::NetworkCache::inputStreamReadReadyCallback):
(WebKit::NetworkCache::outputStreamWriteReadyCallback):
- NetworkProcess/cache/NetworkCacheStatistics.cpp:
(WebKit::NetworkCache::Statistics::initialize):
(WebKit::NetworkCache::Statistics::shrinkIfNeeded):
(WebKit::NetworkCache::Statistics::queryWasEverRequested):
- NetworkProcess/cache/NetworkCacheStatistics.h:
- NetworkProcess/cache/NetworkCacheStorage.cpp:
(WebKit::NetworkCache::Storage::updateFileModificationTime):
(WebKit::NetworkCache::Storage::clear):
- 9:33 AM Changeset in webkit [201483] by
-
- 2 edits in trunk/Source/WTF
Build fix for projects that include MainThread.h without including FastMalloc.h.
- wtf/NoncopyableFunction.h: Include FastMalloc.h from here.
May 27, 2016:
- 10:51 PM Changeset in webkit [201482] by
-
- 60 edits1 copy in trunk/Source
callOnMainThread() should not copy captured lambda variables
https://bugs.webkit.org/show_bug.cgi?id=158166
Reviewed by Brady Eidson.
Source/WebCore:
callOnMainThread() should not copy captured lambda variables. This
function is usually called cross-thread with a lambda and copying
the lambda (and its captured variables) can lead to thread-safety
issues.
This patch updates callOnMainThread() to take a NoncopyableFunction&&
in parameter instead of a std::function. The call sites of
callOnMainThread() have also been updated to use C++14's lambda
capture with initializer.
- Modules/indexeddb/IDBTransaction.cpp:
(WebCore::IDBTransaction::putOrAddOnServer):
- Modules/mediastream/MediaDevicesRequest.cpp:
(WebCore::MediaDevicesRequest::didCompletePermissionCheck):
(WebCore::MediaDevicesRequest::didCompleteTrackSourceInfoRequest):
- Modules/mediastream/MediaEndpointPeerConnection.cpp:
(WebCore::MediaEndpointPeerConnection::runTask):
- Modules/mediastream/MediaEndpointPeerConnection.h:
- Modules/mediastream/UserMediaRequest.cpp:
(WebCore::UserMediaRequest::constraintsValidated):
(WebCore::UserMediaRequest::userMediaAccessGranted):
- Modules/webaudio/AudioContext.cpp:
(WebCore::AudioContext::scheduleNodeDeletion):
(WebCore::AudioContext::isPlayingAudioDidChange):
- dom/Document.cpp:
(WebCore::Document::postTask):
(WebCore::Document::pendingTasksTimerFired): Deleted.
- dom/ScriptElement.cpp:
(WebCore::ScriptElement::requestScript):
- fileapi/AsyncFileStream.cpp:
(WebCore::callOnFileThread):
(WebCore::AsyncFileStream::~AsyncFileStream):
(WebCore::AsyncFileStream::perform):
- fileapi/AsyncFileStream.h:
- fileapi/ThreadableBlobRegistry.cpp:
(WebCore::ThreadableBlobRegistry::registerFileBlobURL):
(WebCore::ThreadableBlobRegistry::registerBlobURL):
(WebCore::ThreadableBlobRegistry::registerBlobURLForSlice):
(WebCore::ThreadableBlobRegistry::blobSize):
(WebCore::ThreadableBlobRegistry::unregisterBlobURL):
(WebCore::ThreadableBlobRegistry::registerBlobURLOptionallyFileBacked): Deleted.
- loader/icon/IconDatabase.cpp:
(WebCore::IconDatabase::dispatchDidImportIconURLForPageURLOnMainThread):
(WebCore::IconDatabase::dispatchDidImportIconDataForPageURLOnMainThread):
- page/ResourceUsageThread.cpp:
(WebCore::ResourceUsageThread::notifyObservers):
(WebCore::ResourceUsageThread::threadBody):
- page/ResourceUsageThread.h:
- page/scrolling/ScrollingThread.cpp:
(WebCore::ScrollingThread::dispatch):
(WebCore::ScrollingThread::dispatchBarrier):
(WebCore::ScrollingThread::dispatchFunctionsFromScrollingThread):
- page/scrolling/ScrollingThread.h:
- page/scrolling/ios/ScrollingTreeIOS.cpp:
(WebCore::ScrollingTreeIOS::invalidate):
(WebCore::ScrollingTreeIOS::scrollingTreeNodeDidScroll):
(WebCore::ScrollingTreeIOS::currentSnapPointIndicesDidChange):
(WebCore::ScrollingTreeIOS::createScrollingTreeNode): Deleted.
- page/scrolling/mac/ScrollingTreeFrameScrollingNodeMac.mm:
(WebCore::ScrollingTreeFrameScrollingNodeMac::releaseReferencesToScrollerImpsOnTheMainThread):
- platform/MemoryPressureHandler.cpp:
(WebCore::MemoryPressureHandler::releaseMemory):
- platform/audio/ios/MediaSessionManagerIOS.mm:
(-[WebMediaSessionHelper dealloc]):
(-[WebMediaSessionHelper startMonitoringAirPlayRoutes]):
(-[WebMediaSessionHelper stopMonitoringAirPlayRoutes]):
- platform/graphics/avfoundation/AudioSourceProviderAVFObjC.mm:
(WebCore::AudioSourceProviderAVFObjC::prepare):
- platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
(WebCore::MediaPlayerPrivateAVFoundation::scheduleMainThreadNotification):
(WebCore::MediaPlayerPrivateAVFoundation::dispatchNotification):
- platform/graphics/avfoundation/objc/CDMSessionAVFoundationObjC.mm:
(-[WebCDMSessionAVFoundationObjCListener observeValueForKeyPath:ofObject:change:context:]):
- platform/graphics/avfoundation/objc/MediaPlaybackTargetPickerMac.mm:
(-[WebAVOutputDeviceMenuControllerHelper observeValueForKeyPath:ofObject:change:context:]):
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::createVideoLayer):
(-[WebCoreAVFMovieObserver legibleOutput:didOutputAttributedStrings:nativeSampleBuffers:forItemTime:]):
(-[WebCoreAVFMovieObserver outputSequenceWasFlushed:]):
(-[WebCoreAVFLoaderDelegate resourceLoader:shouldWaitForLoadingOfRequestedResource:]):
(-[WebCoreAVFLoaderDelegate resourceLoader:shouldWaitForResponseToAuthenticationChallenge:]):
(-[WebCoreAVFLoaderDelegate resourceLoader:didCancelLoadingRequest:]):
- platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:
(WebCore::CMTimebaseEffectiveRateChangedCallback):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::play):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::pause):
- platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.h:
- platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm:
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::scheduleDeferredTask):
- platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:
(-[WebAVStreamDataParserListener streamDataParser:didParseStreamDataAsAsset:]):
(-[WebAVStreamDataParserListener streamDataParser:didParseStreamDataAsAsset:withDiscontinuity:]):
(-[WebAVStreamDataParserListener streamDataParser:didFailToParseStreamDataWithError:]):
(-[WebAVStreamDataParserListener streamDataParser:didProvideMediaData:forTrackID:mediaType:flags:]):
(-[WebAVStreamDataParserListener streamDataParser:didReachEndOfTrackWithTrackID:mediaType:]):
(-[WebAVStreamDataParserListener streamDataParser:didProvideContentKeyRequestInitializationData:forTrackID:]):
(-[WebAVSampleBufferErrorListener observeValueForKeyPath:ofObject:change:context:]):
(-[WebAVSampleBufferErrorListener layerFailedToDecode:]):
- platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::patternReleaseCallback):
- platform/graphics/cg/PatternCG.cpp:
(WebCore::patternReleaseCallback):
- platform/graphics/win/MediaPlayerPrivateMediaFoundation.cpp:
(WebCore::MediaPlayerPrivateMediaFoundation::endCreatedMediaSource):
(WebCore::MediaPlayerPrivateMediaFoundation::endGetEvent):
(WebCore::MediaPlayerPrivateMediaFoundation::CustomVideoPresenter::processInputNotify):
- platform/mediastream/MediaStreamPrivate.cpp:
(WebCore::MediaStreamPrivate::scheduleDeferredTask):
- platform/mediastream/MediaStreamPrivate.h:
- platform/mediastream/mac/AVMediaCaptureSource.h:
- platform/mediastream/mac/AVMediaCaptureSource.mm:
(WebCore::AVMediaCaptureSource::scheduleDeferredTask):
- platform/mediastream/mac/RealtimeMediaSourceCenterMac.cpp:
(WebCore::RealtimeMediaSourceCenterMac::getMediaStreamTrackSources):
- platform/mediastream/mac/WebAudioSourceProviderAVFObjC.mm:
(WebCore::WebAudioSourceProviderAVFObjC::prepare):
- platform/mock/MockRealtimeMediaSourceCenter.cpp:
(WebCore::MockRealtimeMediaSourceCenter::getMediaStreamTrackSources):
- platform/network/BlobResourceHandle.cpp:
(WebCore::BlobResourceHandle::start):
(WebCore::BlobResourceHandle::notifyFinish):
- platform/network/DataURLDecoder.cpp:
(WebCore::DataURLDecoder::decode):
- platform/network/DataURLDecoder.h:
- platform/network/cocoa/WebCoreNSURLSession.mm:
(-[WebCoreNSURLSession dealloc]):
(-[WebCoreNSURLSessionDataTask cancel]):
(-[WebCoreNSURLSessionDataTask suspend]):
(-[WebCoreNSURLSessionDataTask resume]):
- platform/network/curl/CurlDownload.cpp:
(WebCore::CurlDownload::didReceiveHeader):
(WebCore::CurlDownload::didReceiveData): Deleted.
Source/WebKit:
callOnMainThread() should not copy captured lambda variables. This
function is usually called cross-thread with a lambda and copying
the lambda (and its captured variables) can lead to thread-safety
issues.
This patch updates callOnMainThread() to take a NoncopyableFunction&&
in parameter instead of a std::function. The call sites of
callOnMainThread() have also been updated to use C++14's lambda
capture with initializer.
- Storage/StorageAreaSync.cpp:
(WebCore::StorageAreaSync::deleteEmptyDatabase):
- Storage/StorageSyncManager.cpp:
(WebCore::StorageSyncManager::dispatch):
- Storage/StorageSyncManager.h:
- Storage/StorageThread.cpp:
(WebCore::StorageThread::dispatch):
(WebCore::StorageThread::terminate):
(WebCore::StorageThread::releaseFastMallocFreeMemoryInAllThreads):
- Storage/StorageThread.h:
- Storage/StorageTracker.cpp:
(WebCore::StorageTracker::syncFileSystemAndTrackerDatabase):
(WebCore::StorageTracker::setOriginDetails):
Source/WebKit/mac:
callOnMainThread() should not copy captured lambda variables. This
function is usually called cross-thread with a lambda and copying
the lambda (and its captured variables) can lead to thread-safety
issues.
This patch updates callOnMainThread() to take a NoncopyableFunction&&
in parameter instead of a std::function. The call sites of
callOnMainThread() have also been updated to use C++14's lambda
capture with initializer.
- Storage/WebDatabaseManagerClient.mm:
(DidModifyOriginData::dispatchToMainThread):
(DidModifyOriginData::DidModifyOriginData): Deleted.
- Storage/WebStorageTrackerClient.mm:
(WebStorageTrackerClient::dispatchDidModifyOrigin):
Source/WTF:
callOnMainThread() should not copy captured lambda variables. This
function is usually called cross-thread with a lambda and copying
the lambda (and its captured variables) can lead to thread-safety
issues.
This patch updates callOnMainThread() to take a NoncopyableFunction&&
in parameter instead of a std::function. The call sites of
callOnMainThread() have also been updated to use C++14's lambda
capture with initializer.
- WTF.xcodeproj/project.pbxproj:
- wtf/FunctionDispatcher.h:
- wtf/NoncopyableFunction.h:
- Moved NoncopyableFunction from FunctionDispatcher.h to NoncopyableFunction.h.
- Add a new operator=(nullptr_t) operator to NoncopyableFunction to match std::function, as one of the call sites needed it.
- wtf/MainThread.cpp:
(WTF::functionQueue):
(WTF::dispatchFunctionsFromMainThread):
(WTF::callOnMainThread):
- wtf/MainThread.h:
- 10:44 PM Changeset in webkit [201481] by
-
- 54 edits15 adds in trunk/Source
[JSC] implement async functions proposal
https://bugs.webkit.org/show_bug.cgi?id=156147
Reviewed by Yusuke Suzuki.
Source/JavaScriptCore:
Adds support for
asyncfunctions, proposed in https://tc39.github.io/ecmascript-asyncawait/.
On the front-end side, "await" becomes a contextual keyword when used within an async function,
which triggers parsing an AwaitExpression. "await" becomes an illegal identifier name within
these contexts. The bytecode generated from an "await" expression is identical to that generated
in a "yield" expression in a Generator, as AsyncFunction reuses generator's state machine mechanism.
There are numerous syntactic forms for language features, including a variation on ArrowFunctions,
requiring the keywordasyncto precede ArrowFormalParameters, and similarly, MethodDefinitions,
which are ordinary MethodDefinitions preceded by the keywordasync.
An async function desugars to the following:
`
async function asyncFn() {
}
becomes:
function asyncFn() {
let generator = {
@generatorNext: function(@generator, @generatorState, @generatorValue, @generatorResumeMode) {
generator state machine stuff here
},
@generatorState: 0,
@generatorThis: this,
@generatorFrame: null
};
return @asyncFunctionResume(generator, undefined, GeneratorResumeMode::NormalMode);
}
`
@asyncFunctionResume()is similar to@generatorResume, with the exception that it will wrap the
result of invoking@generatorNext()in a Promise, and will avoid allocating an iterator result
object.
If the generator has yielded (an AwaitExpression has occurred), resumption will occur automatically
once the await-expression operand is finished, via Promise chaining.
- API/JSScriptRef.cpp:
(parseScript):
- CMakeLists.txt:
- DerivedSources.make:
- JavaScriptCore.xcodeproj/project.pbxproj:
- builtins/AsyncFunctionPrototype.js: Added.
(asyncFunctionResume):
- builtins/BuiltinExecutables.cpp:
(JSC::BuiltinExecutables::createExecutable):
- bytecode/BytecodeList.json:
- bytecode/BytecodeUseDef.h:
(JSC::computeUsesForBytecodeOffset):
(JSC::computeDefsForBytecodeOffset):
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::dumpBytecode):
(JSC::CodeBlock::finishCreation):
- bytecode/UnlinkedCodeBlock.h:
(JSC::UnlinkedCodeBlock::isArrowFunction):
(JSC::UnlinkedCodeBlock::isOrdinaryArrowFunction):
(JSC::UnlinkedCodeBlock::isAsyncArrowFunction):
- bytecode/UnlinkedFunctionExecutable.cpp:
(JSC::generateUnlinkedFunctionCodeBlock):
(JSC::UnlinkedFunctionExecutable::fromGlobalCode):
(JSC::UnlinkedFunctionExecutable::unlinkedCodeBlockFor):
- bytecode/UnlinkedFunctionExecutable.h:
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::BytecodeGenerator):
(JSC::BytecodeGenerator::emitNewFunctionExpressionCommon):
(JSC::BytecodeGenerator::emitNewArrowFunctionExpression):
(JSC::BytecodeGenerator::emitNewMethodDefinition):
(JSC::BytecodeGenerator::emitNewFunction):
(JSC::BytecodeGenerator::emitLoadArrowFunctionLexicalEnvironment):
- bytecompiler/BytecodeGenerator.h:
(JSC::BytecodeGenerator::makeFunction):
- bytecompiler/NodesCodegen.cpp:
(JSC::FunctionNode::emitBytecode):
- inspector/agents/InspectorRuntimeAgent.cpp:
(Inspector::InspectorRuntimeAgent::parse):
- jit/JIT.cpp:
(JSC::JIT::privateCompileMainPass):
- jit/JIT.h:
- jit/JITOpcodes.cpp:
(JSC::JIT::emitNewFuncCommon):
(JSC::JIT::emit_op_new_async_func):
(JSC::JIT::emitNewFuncExprCommon):
(JSC::JIT::emit_op_new_async_func_exp):
- jit/JITOperations.cpp:
- jit/JITOperations.h:
- jsc.cpp:
(runInteractive):
(printUsageStatement):
- llint/LLIntSlowPaths.cpp:
(JSC::LLInt::LLINT_SLOW_PATH_DECL):
- llint/LLIntSlowPaths.h:
- llint/LowLevelInterpreter.asm:
- parser/ASTBuilder.h:
(JSC::ASTBuilder::createAsyncFunctionBody):
- parser/Keywords.table:
- parser/Parser.cpp:
(JSC::Parser<LexerType>::Parser):
(JSC::Parser<LexerType>::parseInner):
(JSC::Parser<LexerType>::isArrowFunctionParameters):
(JSC::Parser<LexerType>::parseAsyncFunctionSourceElements):
(JSC::Parser<LexerType>::parseStatementListItem):
(JSC::Parser<LexerType>::parseVariableDeclarationList):
(JSC::Parser<LexerType>::parseDestructuringPattern):
(JSC::Parser<LexerType>::parseStatement):
(JSC::Parser<LexerType>::parseFunctionDeclarationStatement):
(JSC::Parser<LexerType>::parseFormalParameters):
(JSC::stringForFunctionMode):
(JSC::Parser<LexerType>::parseFunctionParameters):
(JSC::Parser<LexerType>::parseFunctionInfo):
(JSC::Parser<LexerType>::parseAsyncFunctionDeclaration):
(JSC::Parser<LexerType>::parseClass):
(JSC::Parser<LexerType>::parseExpressionOrLabelStatement):
(JSC::Parser<LexerType>::parseImportClauseItem):
(JSC::Parser<LexerType>::parseImportDeclaration):
(JSC::Parser<LexerType>::parseExportDeclaration):
(JSC::Parser<LexerType>::parseAssignmentExpression):
(JSC::Parser<LexerType>::parseAwaitExpression):
(JSC::Parser<LexerType>::parseProperty):
(JSC::Parser<LexerType>::parsePropertyMethod):
(JSC::Parser<LexerType>::parseAsyncFunctionExpression):
(JSC::Parser<LexerType>::parsePrimaryExpression):
(JSC::Parser<LexerType>::parseMemberExpression):
(JSC::Parser<LexerType>::parseArrowFunctionExpression):
(JSC::Parser<LexerType>::parseUnaryExpression):
(JSC::Parser<LexerType>::printUnexpectedTokenText):
- parser/Parser.h:
(JSC::isIdentifierOrKeyword):
(JSC::Scope::Scope):
(JSC::Scope::setSourceParseMode):
(JSC::Scope::isAsyncFunction):
(JSC::Scope::isAsyncFunctionBoundary):
(JSC::Scope::isModule):
(JSC::Scope::setIsFunction):
(JSC::Scope::setIsAsyncArrowFunction):
(JSC::Scope::setIsAsyncFunction):
(JSC::Scope::setIsAsyncFunctionBody):
(JSC::Scope::setIsAsyncArrowFunctionBody):
(JSC::Parser::ExpressionErrorClassifier::forceClassifyExpressionError):
(JSC::Parser::ExpressionErrorClassifier::propagateExpressionErrorClass):
(JSC::Parser::ExpressionErrorClassifier::indicatesPossibleAsyncArrowFunction):
(JSC::Parser::forceClassifyExpressionError):
(JSC::Parser::declarationTypeToVariableKind):
(JSC::Parser::closestParentOrdinaryFunctionNonLexicalScope):
(JSC::Parser::pushScope):
(JSC::Parser::popScopeInternal):
(JSC::Parser::matchSpecIdentifier):
(JSC::Parser::isDisallowedIdentifierAwait):
(JSC::Parser::disallowedIdentifierAwaitReason):
(JSC::parse):
- parser/ParserModes.h:
(JSC::isFunctionParseMode):
(JSC::isAsyncFunctionParseMode):
(JSC::isAsyncArrowFunctionParseMode):
(JSC::isAsyncFunctionWrapperParseMode):
(JSC::isAsyncFunctionBodyParseMode):
(JSC::isModuleParseMode):
(JSC::isProgramParseMode):
(JSC::constructAbilityForParseMode):
- parser/ParserTokens.h:
- parser/SourceCodeKey.h:
(JSC::SourceCodeKey::SourceCodeKey):
(JSC::SourceCodeKey::runtimeFlags):
(JSC::SourceCodeKey::operator==):
- parser/SyntaxChecker.h:
(JSC::SyntaxChecker::createAsyncFunctionBody):
- runtime/AsyncFunctionConstructor.cpp: Added.
(JSC::AsyncFunctionConstructor::AsyncFunctionConstructor):
(JSC::AsyncFunctionConstructor::finishCreation):
(JSC::callAsyncFunctionConstructor):
(JSC::constructAsyncFunctionConstructor):
(JSC::AsyncFunctionConstructor::getCallData):
(JSC::AsyncFunctionConstructor::getConstructData):
- runtime/AsyncFunctionConstructor.h: Added.
(JSC::AsyncFunctionConstructor::create):
(JSC::AsyncFunctionConstructor::createStructure):
- runtime/AsyncFunctionPrototype.cpp: Added.
(JSC::AsyncFunctionPrototype::AsyncFunctionPrototype):
(JSC::AsyncFunctionPrototype::finishCreation):
- runtime/AsyncFunctionPrototype.h: Added.
(JSC::AsyncFunctionPrototype::create):
(JSC::AsyncFunctionPrototype::createStructure):
- runtime/CodeCache.cpp:
(JSC::CodeCache::getGlobalCodeBlock):
(JSC::CodeCache::getProgramCodeBlock):
(JSC::CodeCache::getEvalCodeBlock):
(JSC::CodeCache::getModuleProgramCodeBlock):
(JSC::CodeCache::getFunctionExecutableFromGlobalCode):
- runtime/CodeCache.h:
- runtime/CommonIdentifiers.h:
- runtime/Completion.cpp:
(JSC::checkSyntax):
(JSC::checkModuleSyntax):
- runtime/Completion.h:
- runtime/Executable.cpp:
(JSC::ScriptExecutable::newCodeBlockFor):
(JSC::ProgramExecutable::checkSyntax):
- runtime/Executable.h:
- runtime/FunctionConstructor.cpp:
(JSC::constructFunctionSkippingEvalEnabledCheck):
- runtime/FunctionConstructor.h:
- runtime/JSAsyncFunction.cpp: Added.
(JSC::JSAsyncFunction::JSAsyncFunction):
(JSC::JSAsyncFunction::createImpl):
(JSC::JSAsyncFunction::create):
(JSC::JSAsyncFunction::createWithInvalidatedReallocationWatchpoint):
- runtime/JSAsyncFunction.h: Added.
(JSC::JSAsyncFunction::allocationSize):
(JSC::JSAsyncFunction::createStructure):
- runtime/JSFunction.cpp:
(JSC::JSFunction::getOwnPropertySlot):
- runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::init):
(JSC::JSGlobalObject::createProgramCodeBlock):
(JSC::JSGlobalObject::createEvalCodeBlock):
(JSC::JSGlobalObject::createModuleProgramCodeBlock):
- runtime/JSGlobalObject.h:
(JSC::JSGlobalObject::asyncFunctionPrototype):
(JSC::JSGlobalObject::asyncFunctionStructure):
- runtime/ModuleLoaderObject.cpp:
(JSC::moduleLoaderObjectParseModule):
- runtime/RuntimeFlags.h:
(JSC::RuntimeFlags::operator==):
(JSC::RuntimeFlags::operator!=):
- tests/stress/async-await-basic.js: Added.
(shouldBe):
(shouldBeAsync):
(shouldThrow):
(shouldThrowAsync):
(let.AsyncFunction.async):
(async.asyncFunctionForProto):
(Object.getPrototypeOf.async):
(Object.getPrototypeOf.async.method):
(async):
(async.method):
(async.asyncNonConstructorDecl):
(shouldThrow.new.async):
(shouldThrow.new.async.nonConstructor):
(async.asyncDecl):
(async.f):
(MyError):
(async.asyncDeclThrower):
(shouldThrowAsync.async):
(resolveLater):
(rejectLater):
(async.resumeAfterNormal):
(O.async.resumeAfterNormal):
(resumeAfterNormalArrow.async):
(async.resumeAfterThrow):
(O.async.resumeAfterThrow):
(resumeAfterThrowArrow.async):
(catch):
- tests/stress/async-await-module-reserved-word.js: Added.
(shouldThrow):
(SyntaxError.Canstring_appeared_hereawait.checkModuleSyntaxError.String.raw.await):
(checkModuleSyntaxError.String.raw.await):
(checkModuleSyntaxError.String.raw.async.await):
(SyntaxError.Cannot.declare.named):
- tests/stress/async-await-mozilla.js: Added.
(shouldBe):
(shouldBeAsync):
(shouldThrow):
(shouldThrowAsync):
(assert):
(shouldThrowSyntaxError):
(mozSemantics.async.empty):
(mozSemantics.async.simpleReturn):
(mozSemantics.async.simpleAwait):
(mozSemantics.async.simpleAwaitAsync):
(mozSemantics.async.returnOtherAsync):
(mozSemantics.async.simpleThrower):
(mozSemantics.async.delegatedThrower):
(mozSemantics.async.tryCatch):
(mozSemantics.async.tryCatchThrow):
(mozSemantics.async.wellFinally):
(mozSemantics.async.finallyMayFail):
(mozSemantics.async.embedded.async.inner):
(mozSemantics.async.embedded):
(mozSemantics.async.fib):
(mozSemantics.async.isOdd.async.isEven):
(mozSemantics.async.isOdd):
(mozSemantics.hardcoreFib.async.fib2):
(mozSemantics.namedAsyncExpr.async.simple):
(mozSemantics.async.executionOrder.async.first):
(mozSemantics.async.executionOrder.async.second):
(mozSemantics.async.executionOrder.async.third):
(mozSemantics.async.executionOrder):
(mozSemantics.async.miscellaneous):
(mozSemantics.thrower):
(mozSemantics.async.defaultArgs):
(mozSemantics.shouldThrow):
(mozSemantics):
(mozMethods.X):
(mozMethods.X.prototype.async.getValue):
(mozMethods.X.prototype.setValue):
(mozMethods.X.prototype.async.increment):
(mozMethods.X.prototype.async.getBaseClassName):
(mozMethods.X.async.getStaticValue):
(mozMethods.Y.prototype.async.getBaseClassName):
(mozMethods.Y):
(mozFunctionNameInferrence.async.test):
(mozSyntaxErrors):
- tests/stress/async-await-reserved-word.js: Added.
(assert):
(shouldThrowSyntaxError):
(AsyncFunction.async):
- tests/stress/async_arrow_functions_lexical_arguments_binding.js: Added.
(shouldBe):
(shouldBeAsync):
(shouldThrowAsync):
(noArgumentsArrow2.async):
- tests/stress/async_arrow_functions_lexical_new.target_binding.js: Added.
(shouldBe):
(shouldBeAsync):
(shouldThrowAsync):
(C1):
(C2):
(shouldThrowAsync.async):
- tests/stress/async_arrow_functions_lexical_super_binding.js: Added.
(shouldBe):
(shouldBeAsync):
(BaseClass.prototype.baseClassValue):
(BaseClass):
(ChildClass.prototype.asyncSuperProp):
(ChildClass.prototype.asyncSuperProp2):
(ChildClass):
- tests/stress/async_arrow_functions_lexical_this_binding.js: Added.
(shouldBe):
(shouldBeAsync):
(d.y):
Source/WebKit/mac:
- WebView/WebPreferencesPrivate.h:
Source/WebKit/win:
- Interfaces/IWebPreferencesPrivate.idl:
Source/WebKit2:
- UIProcess/API/C/WKPreferencesRefPrivate.h:
- UIProcess/API/Cocoa/WKPreferencesPrivate.h:
- 9:48 PM Changeset in webkit [201480] by
-
- 2 edits in trunk/Source/WebKit2
Improve lambda capture in NetworkCache::Storage::synchronize()
https://bugs.webkit.org/show_bug.cgi?id=158176
Reviewed by Brady Eidson.
Improve lambda capture in NetworkCache::Storage::synchronize(). We can
now capture the std::unique_ptr<> variables directly thanks to:
- C++14's support for initializer's in lambda captures
- RunLoop::dispatch() now takes a NoncopyableFunction in instead of a std::function, allowing us to capture non-copyable variables.
- NetworkProcess/cache/NetworkCacheStorage.cpp:
(WebKit::NetworkCache::Storage::synchronize):
- 9:18 PM Changeset in webkit [201479] by
-
- 2 edits in trunk/Source/WTF
Unreviewed, build fix for JSCOnly port.
https://bugs.webkit.org/show_bug.cgi?id=158111
Use NoncopyableFunction instead of std::function<>.
- wtf/generic/RunLoopGeneric.cpp:
(WTF::RunLoop::TimerBase::ScheduledTask::create):
(WTF::RunLoop::TimerBase::ScheduledTask::ScheduledTask):
- 6:22 PM Changeset in webkit [201478] by
-
- 2 edits in trunk/Source/WebCore
REGRESSION (r190574): Swipe snapshots are always black on iPhone 5
https://bugs.webkit.org/show_bug.cgi?id=158171
<rdar://problem/24639709>
Reviewed by Beth Dakin.
- platform/graphics/cocoa/IOSurface.mm:
(optionsForBiplanarSurface):
(optionsFor32BitSurface):
(IOSurface::IOSurface):
(IOSurface::format):
We are supposed to be using bi-planar 422f, not yuvf. They're the same
size, but different formats, and 422f is supported in more places.
Clean up the IOSurface constructor so we don't have a switch inside an if
with random ASSERT_NOT_REACHED, making helper functions to build the
options dictionary for arbitrary-size biplanar and 32-bit single-planar
surfaces.
I don't know how to write a test because IOSurface is not supported
in the simulator.
- 5:44 PM Changeset in webkit [201477] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Not all transitively dominated nodes display their retained size
https://bugs.webkit.org/show_bug.cgi?id=158174
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-05-27
Reviewed by Timothy Hatcher.
- UserInterface/Views/HeapSnapshotInstanceDataGridNode.js:
(WebInspector.HeapSnapshotInstanceDataGridNode.prototype._isDominatedByNonBaseParent):
Use the parent reference changing in the loop instead of always using the same parent.
- 5:07 PM Changeset in webkit [201476] by
-
- 5 edits2 adds in trunk
EventHandler finds incorrect scrollable container.
https://bugs.webkit.org/show_bug.cgi?id=158132
<rdar://problem/26423126>
Reviewed by Brent Fulgham.
Fix the logic that checks whether we are at the beginning or at the end of the container (horizontally).
While scrolling to the right, deltaX has negative values. So in case of deltaX < 0, we need to check if
the container is not scrolled all the way to the right.
Source/WebCore:
Test: fast/scrolling/scroll-container-horizontally.html
- page/mac/EventHandlerMac.mm:
(WebCore::findEnclosingScrollableContainer):
LayoutTests:
- fast/scrolling/scroll-container-horizontally-expected.txt: Added.
- fast/scrolling/scroll-container-horizontally.html: Added.
- platform/ios-simulator/TestExpectations:
- platform/mac-wk1/TestExpectations:
- 5:06 PM Changeset in webkit [201475] by
-
- 10 edits2 copies1 add in trunk/Tools
Display failing JSC stress tests in buildbot dashboard
https://bugs.webkit.org/show_bug.cgi?id=156595
Patch by Srinivasan Vijayaraghavan <svijayaraghavan@apple.com> on 2016-05-27
Reviewed by Alexey Proskuryakov.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
(Buildbot.prototype.javaScriptCoreTestFailuresURLForIteration):
(Buildbot.prototype.javaScriptCoreTestStdioUrlForIteration):
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js:
(BuildbotCombinedQueueView.prototype.update):
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
(BuildbotIteration):
(BuildbotIteration.prototype._parseData):
(BuildbotIteration.prototype.loadLayoutTestResults):
(BuildbotIteration.prototype.):
(BuildbotIteration.prototype.loadJavaScriptCoreTestResults):
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
(BuildbotQueueView.prototype._createLoadingIndicator):
(BuildbotQueueView.prototype.):
(BuildbotQueueView.prototype._onPopoverCopy):
(BuildbotQueueView.prototype._popoverContentForJavaScriptCoreTestRegressions):
(BuildbotQueueView.prototype._presentPopoverForJavaScriptCoreTestRegressions):
(BuildbotQueueView.prototype._addIterationHeadingToPopover):
(BuildbotQueueView.prototype._testStepFailureDescription):
(BuildbotQueueView.prototype._testStepFailureDescriptionWithCount):
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
(BuildbotTestResults.prototype.addJavaScriptCoreTestFailures):
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
(BuildbotTesterQueueView.prototype.appendBuilderQueueStatus):
(BuildbotTesterQueueView.prototype.update):
(BuildbotTesterQueueView.prototype._popoverContentForLayoutTestRegressions):
(BuildbotTesterQueueView.prototype._presentPopoverForLayoutTestRegressions):
(BuildbotTesterQueueView.prototype._testStepFailureDescription): Deleted.
(BuildbotTesterQueueView.prototype._testStepFailureDescriptionWithCount): Deleted.
(BuildbotTesterQueueView.prototype.): Deleted.
(BuildbotTesterQueueView.prototype.content.oncopy): Deleted.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/index.html:
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/MockBuildbot.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/MockBuildbotQueue.js.
(MockBuildbot):
(MockBuildbot.prototype.buildPageURLForIteration):
(MockBuildbot.prototype.javaScriptCoreTestFailuresURLForIteration):
(MockBuildbot.prototype.javaScriptCoreTestStdioUrlForIteration):
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/MockBuildbotQueue.js:
(MockBuildbotQueue):
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/MockBuildbotTestResults.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/MockBuildbotQueue.js.
(MockBuildbotTestResults):
(MockBuildbotTestResults.prototype.addJavaScriptCoreTestFailures):
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/test-jsc-results.json: Added.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/tests.js:
- 4:58 PM Changeset in webkit [201474] by
-
- 23 edits in trunk/Source
Decrease flicker when changing video presentation mode.
https://bugs.webkit.org/show_bug.cgi?id=158148
rdar://problem/24476949
Patch by Jeremy Jones <jeremyj@apple.com> on 2016-05-27
Source/WebCore:
Reviewed by Jer Noble.
No new tests because there is no behavior change. This change is about the timing of
moving AVPlayerLayers between layers to prevent flicker.
1) Moving an AVPlayerLayer between CAContexts can flicker. So always keep two
AVPlayerLayers around and add and remove them from the inline and fullscreen contexts.
2) Wait to show the inline placeholder until the fullscreen video layer has been installed.
3) Wait to remove the fullscreen video layer until the placeholder has been removed.
- Modules/mediacontrols/MediaControlsHost.cpp:
(WebCore::MediaControlsHost::isVideoLayerInline): Expose isVideoLayerInline to the shadow DOM.
(WebCore::MediaControlsHost::setPreparedForInline): Expose setPreparedForInline to the shadow DOM.
- Modules/mediacontrols/MediaControlsHost.h: Add setPreparedForInline and isVideoLayerInline
- Modules/mediacontrols/MediaControlsHost.idl: Add setPreparedForInline and isVideoLayerInline
- Modules/mediacontrols/mediaControlsApple.js:
(Controller.prototype.showInlinePlaybackPlaceholderWhenSafe): Wait to show placeholder when entering fullscreen.
(Controller.prototype.handlePresentationModeChange): Wait to show placeholder, and notify when placeholder is removed.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::setPreparedForInline):
(WebCore::HTMLMediaElement::waitForPreparedForInlineThen): Used to delay fullscreen cleanup until placeholder is removed.
(WebCore::HTMLMediaElement::setVideoFullscreenLayer): Add a callback so we can wait until this completes before continuing.
- html/HTMLMediaElement.h:
(WebCore::HTMLMediaElement::isVideoLayerInline):
(WebCore::HTMLMediaElement::waitForPreparedForInlineThen):
(WebCore::HTMLMediaElement::setVideoFullscreenLayer): Add completionHandler.
- platform/cocoa/WebVideoFullscreenModelVideoElement.h:
(WebCore::WebVideoFullscreenModelVideoElement::setVideoFullscreenLayer): Add completionHandler.
(WebCore::WebVideoFullscreenModelVideoElement::waitForPreparedForInlineThen): Added.
- platform/cocoa/WebVideoFullscreenModelVideoElement.mm:
(WebVideoFullscreenModelVideoElement::setVideoFullscreenLayer): Add completionHandler.
(WebVideoFullscreenModelVideoElement::waitForPreparedForInlineThen):
- platform/graphics/MediaPlayer.cpp:
(WebCore::MediaPlayer::setVideoFullscreenLayer): Add completionHandler.
- platform/graphics/MediaPlayer.h:
(WebCore::MediaPlayer::setVideoFullscreenLayer): Add completionHandler.
- platform/graphics/MediaPlayerPrivate.h:
(WebCore::MediaPlayerPrivateInterface::setVideoFullscreenLayer): Add completionHandler.
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayerLayer): Create two video layers.
(WebCore::MediaPlayerPrivateAVFoundationObjC::destroyVideoLayer): Allow two video layers.
(WebCore::MediaPlayerPrivateAVFoundationObjC::setVideoFullscreenLayer): Add completionHandler.
(WebCore::MediaPlayerPrivateAVFoundationObjC::updateVideoLayerGravity): Allow two video layers.
- platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.h:
- platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::addDisplayLayer): Allow two video layers.
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::setVideoFullscreenLayer): Add completionHandler.
- platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.h:
- platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm:
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::createPreviewLayers): Allow two video layers.
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::setVideoFullscreenLayer): Add completionHandler.
- platform/graphics/avfoundation/objc/VideoFullscreenLayerManager.h:
- platform/graphics/avfoundation/objc/VideoFullscreenLayerManager.mm:
(WebCore::VideoFullscreenLayerManager::setVideoLayers): Allow two video layers.
(WebCore::VideoFullscreenLayerManager::setVideoFullscreenLayer): Add completionHandler.
(WebCore::VideoFullscreenLayerManager::setVideoFullscreenFrame): Allow two video layers.
(WebCore::VideoFullscreenLayerManager::didDestroyVideoLayer): Allow two video layers.
(WebCore::VideoFullscreenLayerManager::setVideoLayer): Deleted.
- platform/ios/WebVideoFullscreenControllerAVKit.mm:
(WebVideoFullscreenControllerContext::didSetupFullscreen): Use completionHandler.
(WebVideoFullscreenControllerContext::didExitFullscreen): Use completionHandler.
Source/WebKit2:
Reviewed by Tim Horton.
Prevent flicker by using setVideoFullscreenLayer with a completion handler to delay
enter fullscreen and cleanup fullscreen until the video layer has completely been
installed or removed.
- WebProcess/cocoa/WebVideoFullscreenManager.mm:
(WebKit::WebVideoFullscreenManager::didSetupFullscreen):
(WebKit::WebVideoFullscreenManager::didExitFullscreen):
- 4:42 PM Changeset in webkit [201473] by
-
- 3 edits3 adds in trunk
DebuggerCallFrame crashes when updated with the globalExec because neither ShadowChicken's algorithm nor StackVisitor's algorithm reasons about the globalExec
https://bugs.webkit.org/show_bug.cgi?id=158104
Reviewed by Filip Pizlo.
Source/JavaScriptCore:
I think globalExec is a special enough case that it should be handled
at the layers above ShadowChicken and StackVisitor. Those APIs should
deal with real stack frames on the machine stack, not a heap constructed frame.
This patch makes DebuggerCallFrame::create aware that it may be
created with the globalObject->globalExec() by having it construct
a single DebuggerCallFrame that wraps the globalExec.
This fixes a crasher because we will construct a DebuggerCallFrame
with the globalExec when the Inspector is set to pause on all uncaught
exceptions and the JS program has a syntax error. Because the program
hasn't begun execution, there is no machine JS stack frame yet. So
DebuggerCallFrame is created with globalExec, which will cause it
to hit an assertion that dictates that the stack have size greater
than zero.
- debugger/DebuggerCallFrame.cpp:
(JSC::DebuggerCallFrame::create):
LayoutTests:
- inspector/debugger/breakpoint-syntax-error-top-level-expected.txt: Added.
- inspector/debugger/breakpoint-syntax-error-top-level.html: Added.
- inspector/debugger/resources/file-with-syntax-error.js: Added.
- 4:34 PM Changeset in webkit [201472] by
-
- 2 edits in trunk/LayoutTests
Unreviewed test fix after r201468.
Correct output handling to reduce flakiness on test bots.
- http/tests/security/contentSecurityPolicy/frame-src-cross-origin-load.html:
- 3:31 PM Changeset in webkit [201471] by
-
- 15 edits2 adds in trunk
Crash in TreeScope::focusedElement
https://bugs.webkit.org/show_bug.cgi?id=158108
Reviewed by Enrica Casucci.
Source/WebCore:
The bug was caused by a flawed sequence of steps we took to remove an element. When an element is removed,
willRemoveChild and willRemoveChildren fire blur events on removed focused element and its ancestors and
unload event on any removed iframes. However, it was possible to focus an element on which we had fired blur
during an unload event, leaving m_focusedElement point to an element that's not in the document anymore.
Changing the order doesn't help because that would make it possible to insert the removed iframes back into
the document inside a event listener of the blur event, which was specifically fixed by r127534 four years ago.
Instead, fix the bug by not firing blur and change events on removed nodes. New behavior matches Firefox and HTML5
specification: https://html.spec.whatwg.org/multipage/interaction.html#focus-fixup-rule-one
Test: fast/shadow-dom/shadow-root-active-element-crash.html
- dom/ContainerNode.cpp:
(WebCore::willRemoveChild): Made this function static local since it didn't need to have access to any private
member variables. Call Document::nodeWillBeRemoved after disconnecting iframes since unload event handler could
allocate new Ranges just like mutation events.
(WebCore::willRemoveChildren): Ditto.
(WebCore::ContainerNode::removeChild): Removed the calls to removeFullScreenElementOfSubtree and
removeFocusedNodeOfSubtree as they're now called in Document::nodeWillBeRemoved.
(WebCore::ContainerNode::removeChildren): Ditto.
- dom/ContainerNode.h:
- dom/Document.cpp:
(WebCore::Document::removeFocusedNodeOfSubtree): Don't dispatch blur and change events when a node is removed.
(WebCore::Document::setFocusedElement): Added FocusRemovalEventsMode as the third argument. Avoid dispatching blur
and change events when FocusRemovalEventsMode::Dispatch is set.
(WebCore::Document::nodeChildrenWillBeRemoved): Added calls to removeFullScreenElementOfSubtree and
removeFocusedNodeOfSubtree. Also assert that no events are fired within this function. If we ever fire an event here,
"unloaded" iframes can be inserted back into a document before ContainerNode::removeChild actually removes them.
(WebCore::Document::nodeWillBeRemoved): Ditto.
- dom/Document.h:
- dom/TreeScope.cpp:
(WebCore::TreeScope::focusedElement): Added a release assertion to make sure the focused element is in the document
of the tree scope, and added an explicit type check just in case.
LayoutTests:
Added a regression test for accessing shadowRoot.activeElement after re-focusing an element
inside DOMNodeRemovedFromDocument event and unload events.
This patch also restores the expected result of fast/events/onblur-remove.html to that of when
the test was in r15720 and updated in r19014. The expected result was changed in r85495 as it was
converted to a eventSender test.
- fast/dom/Range/range-created-during-remove-children-expected.txt:
- fast/dom/Range/range-created-during-remove-children.html: Update the test to use unload event
of an iframe since we no longer fire blur event when removing a focused element.
- fast/dom/adopt-node-prevented-expected.txt:
- fast/dom/adopt-node-prevented.html: Ditto.
- fast/dom/remove-body-during-body-replacement2.html: Ditto. Use DOMNodeRemoved instead.
- fast/events/nested-event-remove-node-crash.html: Ditto. Use DOMNodeRemovedFromDocument instead.
- fast/events/onblur-remove-expected.txt:
- fast/events/onblur-remove.html: See above.
- fast/shadow-dom/shadow-root-active-element-crash-expected.txt: Added.
- fast/shadow-dom/shadow-root-active-element-crash.html: Added.
- 3:29 PM Changeset in webkit [201470] by
-
- 3 edits1 add in trunk/Source/JavaScriptCore
DFG::LazyJSValue::tryGetStringImpl() crashes for empty values
https://bugs.webkit.org/show_bug.cgi?id=158170
Reviewed by Michael Saboff.
The problem here is that jsDynamicCast<>() is evil! It avoids checking for the empty
value, presumably because this makes it soooper fast. In DFG IR, empty values can appear
anywhere because of TDZ.
This patch doesn't change jsDynamicCast<>(), but it hardens our wrappers for it in the DFG
and it has the affected code use one of those wrappers.
- dfg/DFGFrozenValue.h:
(JSC::DFG::FrozenValue::dynamicCast): Harden this.
(JSC::DFG::FrozenValue::cast):
- dfg/DFGLazyJSValue.cpp:
(JSC::DFG::LazyJSValue::tryGetStringImpl): Use the hardened wrapper.
- tests/stress/strcat-emtpy.js: Added. This used to crash every time.
(foo):
(i.catch):
- 2:42 PM Changeset in webkit [201469] by
-
- 5 edits in tags/Safari-602.1.34.1/Source
Versioning
- 1:50 PM Changeset in webkit [201468] by
-
- 6 edits in trunk
CSP: Fire 'load' events even when blocking loads via 'frame-src'.
https://bugs.webkit.org/show_bug.cgi?id=153150
<rdar://problem/24383162>
Reviewed by Daniel Bates.
Source/WebCore:
Always fire a load event, even when the load is blocked by CSP rules, so that
attackers cannot gain knowledge about the URL in the frame by blocking the
load and waiting long enough to be sure that a 'load' event would have
fired if the load wasn't blocked.
Inspired by Blink patch:
<https://src.chromium.org/viewvc/blink?view=rev&revision=165743>
Tests: http/tests/security/contentSecurityPolicy/frame-src-cross-origin-load.html
- loader/PolicyChecker.cpp:
(WebCore::PolicyChecker::checkNavigationPolicy):
LayoutTests:
- TestExpectations: Unskip the cross-origin load test.
- http/tests/security/contentSecurityPolicy/frame-src-cross-origin-load-expected.txt: Update to match
our message format.
- 1:45 PM Changeset in webkit [201467] by
-
- 3 edits2 adds in trunk/Source/JavaScriptCore
regExpProtoFuncSplitFast should OOM before it swaps
https://bugs.webkit.org/show_bug.cgi?id=158157
Reviewed by Mark Lam.
This is a huge speed-up on some jsfunfuzz test cases because it makes us realize much
sooner that running a regexp split will result in swapping. It uses the same basic
approach as http://trac.webkit.org/changeset/201451: if the result array crosses a certain
size threshold, we proceed with a dry run to see how big the array will get before
allocating anything else. This way, bogus uses of split that would have OOMed only after
killing the user's machine will now OOM before killing the user's machine.
This is an enormous speed-up on some jsfunfuzz tests: they go from running for a long
time to running instantly.
- runtime/RegExpPrototype.cpp:
(JSC::advanceStringIndex):
(JSC::genericSplit):
(JSC::regExpProtoFuncSplitFast):
- runtime/StringObject.h:
(JSC::jsStringWithReuse):
(JSC::jsSubstring):
- tests/stress/big-split-captures.js: Added.
- tests/stress/big-split.js: Added.
- 1:32 PM Changeset in webkit [201466] by
-
- 2 edits in trunk/Source/WebCore
Document abandons its EventTargetData.
<https://webkit.org/b/158158>
Reviewed by Darin Adler.
Node::willBeDeletedFrom() is called when destroying all Node types *except* Document.
If a Document had an associated EventTargetData, it would not get cleaned up.
This patch moves the EventTargetData cleanup to ~Node() where it's guaranteed to run.
- dom/Node.cpp:
(WebCore::Node::~Node):
(WebCore::Node::willBeDeletedFrom):
- 1:26 PM Changeset in webkit [201465] by
-
- 4 edits3 adds in trunk
ShadowChicken/DebuggerCallFrame don't properly handle when the entry stack frame is a tail deleted frame
https://bugs.webkit.org/show_bug.cgi?id=158131
Reviewed by Yusuke Suzuki.
Source/JavaScriptCore:
There were bugs both in DebuggerCallFrame and ShadowChicken when the entry stack
frame(s) are tail deleted.
DebuggerCallFrame had an assertion saying that the entry frame shouldn't be
tail deleted. This is clearly wrong. The following program proves that this assertion
was misguided:
`
"use strict";
setTimeout(function foo() { return bar(); }, 0);
`
ShadowChicken had a very subtle bug when creating the shadow stack when
the entry frames of the stack were tail deleted. Because it places frames into its shadow
stack by walking the machine frame and looking up entries in the log,
the machine frame doesn't have any notion of those tail deleted frames
at the entry of execution. ShadowChicken would never find those frames
because it would look for tail deleted frames *before* consulting the
current machine frame. This is wrong because if the entry frames
are tail deleted, then there is no machine frame for them because there
is no machine frame before them! Therefore, we must search for tail deleted
frames *after* consulting a machine frame. This is sound because we will always
have at least one machine frame on the stack (when we are using StackVisitor on a valid ExecState).
So when we consult the machine frame that is the entry frame on the machine stack,
we will search for tail deleted frames that come before it in the shadow stack.
This will allow us to find those tail deleted frames that are the entry frames
for the shadow stack.
- debugger/DebuggerCallFrame.cpp:
(JSC::DebuggerCallFrame::create):
- interpreter/ShadowChicken.cpp:
(JSC::ShadowChicken::Packet::dump):
(JSC::ShadowChicken::update):
(JSC::ShadowChicken::dump):
LayoutTests:
- inspector/debugger/resources/tail-deleted-frames-from-vm-entry.js: Added.
(timeout):
(bar):
- inspector/debugger/tail-deleted-frames-from-vm-entry-expected.txt: Added.
- inspector/debugger/tail-deleted-frames-from-vm-entry.html: Added.
- 1:22 PM Changeset in webkit [201464] by
-
- 26 edits in trunk
WorkQueue::dispatch() / RunLoop::dispatch() should not copy captured lambda variables
https://bugs.webkit.org/show_bug.cgi?id=158111
Reviewed by Darin Adler.
WorkQueue::dispatch() / RunLoop::dispatch() should not copy captured lambda variables.
These are often used cross-thread and copying the captured lambda variables can be
dangerous (e.g. we do not want to copy a String after calling isolatedCopy() upon
capture).
Source/JavaScriptCore:
- runtime/Watchdog.cpp:
(JSC::Watchdog::startTimer):
(JSC::Watchdog::Watchdog): Deleted.
(JSC::Watchdog::setTimeLimit): Deleted.
- runtime/Watchdog.h:
Source/WebKit2:
- NetworkProcess/NetworkProcess.cpp:
(WebKit::clearDiskCacheEntries):
- NetworkProcess/cache/NetworkCache.cpp:
(WebKit::NetworkCache::Cache::clear):
- NetworkProcess/cache/NetworkCacheIOChannelSoup.cpp:
(WebKit::NetworkCache::runTaskInQueue):
- Platform/IPC/Connection.cpp:
(IPC::Connection::processIncomingMessage):
- UIProcess/Storage/StorageManager.cpp:
(WebKit::StorageManager::getSessionStorageOrigins):
(WebKit::StorageManager::deleteSessionStorageOrigins):
(WebKit::StorageManager::deleteSessionStorageEntriesForOrigins):
(WebKit::StorageManager::getLocalStorageOrigins):
(WebKit::StorageManager::getLocalStorageOriginDetails):
(WebKit::StorageManager::deleteLocalStorageOriginsModifiedSince):
(WebKit::StorageManager::deleteLocalStorageEntriesForOrigins):
- UIProcess/Storage/StorageManager.h:
Source/WTF:
This patch introduces a new NoncopyableFunction type that behaves similarly to
std::function but guarantees that the passed-in lambda (and its captured variables)
cannot be copied. This new NoncopyableFunction type is now used for
WorkQueue / RunLoop's dispatch() / dispatchAfter() which are commonly used
cross-thread. This should now allow us to call WorkQueue::dispatch() with a lambda
that captures a String like so:
[str = str.isolatedCopy()]() { }
Also note that even though this is not leveraged in this patch, NoncopyableFunction
would allow us to capture move-only types such as std::unique_ptr as so:
[p = WTFMove(p)]() { }
This does not work if we convert the lambda into an std::function because
std::function requires the lambda to be copyable, NoncopyableFunction does not.
- wtf/FunctionDispatcher.h:
(WTF::CallableWrapperBase::~CallableWrapperBase):
(WTF::NoncopyableFunction::NoncopyableFunction):
(WTF::NoncopyableFunction::operator()):
(WTF::NoncopyableFunction::operator bool):
(WTF::NoncopyableFunction::operator=):
- wtf/RunLoop.cpp:
(WTF::RunLoop::performWork):
(WTF::RunLoop::dispatch):
- wtf/RunLoop.h:
- wtf/WorkQueue.h:
- wtf/cocoa/WorkQueueCocoa.cpp:
(WTF::WorkQueue::dispatch):
(WTF::WorkQueue::dispatchAfter):
- wtf/efl/DispatchQueueWorkItemEfl.h:
(WorkItem::WorkItem):
(TimerWorkItem::create):
(TimerWorkItem::TimerWorkItem):
- wtf/efl/WorkQueueEfl.cpp:
(WTF::WorkQueue::dispatch):
(WTF::WorkQueue::dispatchAfter):
- wtf/generic/RunLoopGeneric.cpp:
(WTF::RunLoop::dispatchAfter):
- wtf/generic/WorkQueueGeneric.cpp:
(WorkQueue::dispatch):
(WorkQueue::dispatchAfter):
- wtf/glib/RunLoopGLib.cpp:
(WTF::DispatchAfterContext::DispatchAfterContext):
(WTF::RunLoop::dispatchAfter):
- wtf/win/WorkItemWin.cpp:
(WTF::WorkItemWin::WorkItemWin):
(WTF::WorkItemWin::create):
(WTF::HandleWorkItem::HandleWorkItem):
(WTF::HandleWorkItem::createByAdoptingHandle):
- wtf/win/WorkItemWin.h:
(WTF::WorkItemWin::function):
- wtf/win/WorkQueueWin.cpp:
(WTF::WorkQueue::dispatch):
(WTF::WorkQueue::timerCallback):
(WTF::WorkQueue::dispatchAfter):
Tools:
- WebKitTestRunner/TestController.cpp:
(WTR::TestController::decidePolicyForNavigationAction):
- 1:14 PM Changeset in webkit [201463] by
-
- 3 edits in trunk/Source/WebCore
Attempt to fix the iOS build.
Unreviewed build fix.
- platform/graphics/cocoa/TextTrackRepresentationCocoa.mm:
- platform/ios/WebVideoFullscreenInterfaceAVKit.mm:
(-[WebAVPlayerLayer layoutSublayers]):
- 12:50 PM Changeset in webkit [201462] by
-
- 2 edits in trunk/Source/JavaScriptCore
Removed unused headers from ExecutableAllocatorFixedVMPool.cpp.
https://bugs.webkit.org/show_bug.cgi?id=158159
Reviewed by Darin Adler.
- jit/ExecutableAllocatorFixedVMPool.cpp:
- 12:45 PM Changeset in webkit [201461] by
-
- 5 edits3 adds in trunk
Modern IDB: After closing a Netflix video, trying to watch it again fails.
<rdar://problem/25092473> and https://bugs.webkit.org/show_bug.cgi?id=158160
Reviewed by Alex Christensen.
Source/WebCore:
New APITest: IndexedDB.WebProcessKillIDBCleanup
- Modules/indexeddb/IDBTransaction.cpp:
(WebCore::IDBTransaction::stop):
- Modules/indexeddb/server/UniqueIDBDatabase.cpp:
(WebCore::IDBServer::UniqueIDBDatabase::connectionClosedFromClient): All active transactions need to be aborted
(without callback, since there's no connection to callback to).
(WebCore::IDBServer::UniqueIDBDatabase::takeNextRunnableTransaction):
Tools:
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/WebKit2Cocoa/WebProcessKillIDBCleanup-1.html: Added.
- TestWebKitAPI/Tests/WebKit2Cocoa/WebProcessKillIDBCleanup-2.html: Added.
- TestWebKitAPI/Tests/WebKit2Cocoa/WebProcessKillIDBCleanup.mm: Added.
- 12:22 PM Changeset in webkit [201460] by
-
- 2 edits in tags/Safari-602.1.34.1/Source/WebKit2
Merge r201453. rdar://problem/26502712
- 12:08 PM Changeset in webkit [201459] by
-
- 1 copy in tags/Safari-602.1.34.1
New Tag.
- 12:08 PM Changeset in webkit [201458] by
-
- 5 edits in trunk
AX: [ATK] accessibility/gtk/no-notification-for-unrendered-iframe-children.html began failing after r201416
https://bugs.webkit.org/show_bug.cgi?id=158152
Reviewed by Chris Fleizach.
The failure is actually a bug fix because only one child is being added, but two
notifications were being emitted. Now there is only one notification. To verify
this was the case, we really should examine the child reportedly being added. That
child is the ATK event's any_data, so pass along that child to the listener.
Tools:
- WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
LayoutTests:
The failing test and associated expectations were modified to remove the duplicate
notification and include the title of the added child for the notification we get.
- accessibility/gtk/no-notification-for-unrendered-iframe-children.html: Updated.
- accessibility/gtk/no-notification-for-unrendered-iframe-children-expected.txt: Updated.
- 11:50 AM Changeset in webkit [201457] by
-
- 8 edits in trunk
Expose content extension failure error codes in SPI
https://bugs.webkit.org/show_bug.cgi?id=158095
rdar://problem/26475651
Reviewed by Anders Carlsson.
Source/WebKit2:
- UIProcess/API/APIUserContentExtensionStore.cpp:
(API::UserContentExtensionStore::synchronousRemoveAllContentExtensions):
(API::UserContentExtensionStore::invalidateContentExtensionVersion):
Added for testing.
(API::userContentExtensionStoreErrorCategory):
- UIProcess/API/APIUserContentExtensionStore.h:
- UIProcess/API/Cocoa/_WKUserContentExtensionStore.h:
Added the new enum, _WKUserContentExtensionStoreErrorCode.
- UIProcess/API/Cocoa/_WKUserContentExtensionStore.mm:
(-[_WKUserContentExtensionStore compileContentExtensionForIdentifier:encodedContentExtension:completionHandler:]):
Sometimes the error code returned by UserContentExtensionStore::compileContentExtension has the error code from compileRuleList.
When this happens, we want to get the message from the internal compiler error, but we want the NSError's code to always be CompileFailed.
(-[_WKUserContentExtensionStore lookupContentExtensionForIdentifier:completionHandler:]):
(-[_WKUserContentExtensionStore removeContentExtensionForIdentifier:completionHandler:]):
(-[_WKUserContentExtensionStore _removeAllContentExtensions]):
(-[_WKUserContentExtensionStore _invalidateContentExtensionVersionForIdentifier:]):
- UIProcess/API/Cocoa/_WKUserContentExtensionStorePrivate.h:
Added new invalidator for testing.
Tools:
- TestWebKitAPI/Tests/WebKit2Cocoa/_WKUserContentExtensionStore.mm:
(checkDomain):
(TEST_F):
Add tests that use the new enum.
- 11:36 AM Changeset in webkit [201456] by
-
- 12 edits in trunk/Source/JavaScriptCore
get_by_id should support caching unset properties in the LLInt
https://bugs.webkit.org/show_bug.cgi?id=158136
Reviewed by Benjamin Poulain.
Recently, we started supporting prototype load caching for get_by_id
in the LLInt. This patch extends that to caching unset properties.
While it is uncommon in general for a program to see a single structure
without a given property, the Array.prototype.concat function needs to
lookup the Symbol.isConcatSpreadable property. For any existing code
That property will never be set as it did not exist prior to ES6.
Similarly to the get_by_id_proto_load bytecode, this patch adds a new
bytecode, get_by_id_unset that checks the structureID of the base and
assigns undefined to the result.
There are no new tests here since we already have many tests that
incidentally cover this change.
- bytecode/BytecodeList.json:
- bytecode/BytecodeUseDef.h:
(JSC::computeUsesForBytecodeOffset):
(JSC::computeDefsForBytecodeOffset):
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::printGetByIdOp):
(JSC::CodeBlock::dumpBytecode):
(JSC::CodeBlock::finalizeLLIntInlineCaches):
- bytecode/GetByIdStatus.cpp:
(JSC::GetByIdStatus::computeFromLLInt):
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
- dfg/DFGCapabilities.cpp:
(JSC::DFG::capabilityLevel):
- jit/JIT.cpp:
(JSC::JIT::privateCompileMainPass):
(JSC::JIT::privateCompileSlowCases):
- llint/LLIntSlowPaths.cpp:
(JSC::LLInt::setupGetByIdPrototypeCache):
(JSC::LLInt::LLINT_SLOW_PATH_DECL):
- llint/LLIntSlowPaths.h:
- llint/LowLevelInterpreter32_64.asm:
- llint/LowLevelInterpreter64.asm:
- 11:35 AM Changeset in webkit [201455] by
-
- 9 edits1 add in trunk
WebRTC: Update RTCPeerConnection overloaded legacy operations to return a Promise
https://bugs.webkit.org/show_bug.cgi?id=158114
Reviewed by Eric Carlson.
Source/WebCore:
Update overloaded operations so that the legacy callback versions also return a promise
and never throw [1].
[1] https://w3c.github.io/webrtc-pc/archives/20160513/webrtc.html#legacy-interface-extensions
Updated existing tests.
- fast/mediastream/RTCPeerConnection-overloaded-operations-params.html
- fast/mediastream/RTCPeerConnection-overloaded-operations.html
- Modules/mediastream/RTCPeerConnection.idl:
Updated legacy signatures (just for documentation purposes)
- Modules/mediastream/RTCPeerConnection.js:
Implements the promise overload and the legacy callbacks overload (using the promise version)
as specified in [1] (above).
(createOffer):
(createAnswer):
(setLocalDescription):
(setRemoteDescription):
(addIceCandidate):
(getStats):
- Modules/mediastream/RTCPeerConnectionInternals.js:
Added helper functions objectAndCallbacksOverload and callbacksAndDictionaryOverload that
process an argument list and determine which overloaded version to use.
(callbacksAndDictionaryOverload):
(setLocalOrRemoteDescription): Deleted.
(extractCallbackArg): Deleted.
LayoutTests:
Updated existing tests (see below).
- fast/mediastream/RTCPeerConnection-overloaded-operations-expected.txt:
- fast/mediastream/RTCPeerConnection-overloaded-operations-params-expected.txt:
- fast/mediastream/RTCPeerConnection-overloaded-operations-params.html:
Test various combinations of good and bad arguments and verify that no errors are thrown.
- fast/mediastream/RTCPeerConnection-overloaded-operations.html:
Test that all overloaded versions return a promise.
- fast/mediastream/resources/promise-utils.js: Added.
Shared utils to make it easier to test async promise APIs.
(ensurePromise):
(promiseShouldReject):
(promiseShouldNotRejectWithTypeError.):
- 11:33 AM Changeset in webkit [201454] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Add indicators to show nesting levels inside DOM Tree
https://bugs.webkit.org/show_bug.cgi?id=157468
<rdar://problem/26162640>
Patch by Devin Rousso <Devin Rousso> on 2016-05-27
Reviewed by Timothy Hatcher.
Add CSS rules to give all expanded node children lists a small line on the
left border indicating that all items under the line are descendants.
- UserInterface/Views/DOMTreeOutline.css:
(.tree-outline.dom li .selection):
(.tree-outline.dom li > span):
(.tree-outline.dom ol):
(.tree-outline.dom .tree-outline.dom li:matches(.hovered, .selected) + ol.children.expanded):
(.tree-outline.dom li.selected + ol.children.expanded):
(.tree-outline.dom li.parent::before):
- 10:09 AM Changeset in webkit [201453] by
-
- 2 edits in trunk/Source/WebKit2
Regression(r200972): Webcore::Range::collectSelectionsRects() asserts in startContainer() while selecting text.
https://bugs.webkit.org/show_bug.cgi?id=158155
<rdar://problem/26502712>
Reviewed by Chris Dumez.
This patch ensures that we still have a valid paragraphRange after returning from enclosingTextUnitOfGranularity().
- WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::selectTextWithGranularityAtPoint):
- 9:05 AM Changeset in webkit [201452] by
-
- 2 edits2 deletes in trunk/Source/bmalloc
[cmake] Deduplicated bmalloc/Zone.cpp handling.
https://bugs.webkit.org/show_bug.cgi?id=158154
Reviewed by Alex Christensen.
File bmalloc/Zone.cpp is required on Darwin irrespectively from what
port is being built.
Also I removed WEBKIT_INCLUDE_CONFIG_FILES_IF_EXISTS() because it's
unlikely that bmalloc will ever need port-specific customizations (as
opposed to OS-specific customizations which should be done in
CMakeLists.txt).
- CMakeLists.txt: Added bmalloc/Zone.cpp for Darwin.
- PlatformGTK.cmake: Removed.
- PlatformMac.cmake: Removed.
- 7:59 AM Changeset in webkit [201451] by
-
- 7 edits2 adds in trunk/Source/JavaScriptCore
Bogus uses of regexp matching should realize that they will OOM before they start swapping
https://bugs.webkit.org/show_bug.cgi?id=158142
Reviewed by Michael Saboff.
Refactored the RegExpObject::matchGlobal() code so that there is less duplication. Took
advantage of this to make the code more resilient in case of absurd situations: if the
result array gets large, it proceeds with a dry run to detect how many matches there will
be. This allows it to OOM before it starts swapping.
This also improves the overall performance of the code by using lightweight substrings and
skipping the whole intermediate argument array.
This makes some jsfunfuzz tests run a lot faster and use a lot less memory.
- builtins/RegExpPrototype.js:
- CMakeLists.txt:
- JavaScriptCore.xcodeproj/project.pbxproj:
- runtime/MatchResult.cpp: Added.
(JSC::MatchResult::dump):
- runtime/MatchResult.h:
(JSC::MatchResult::empty):
(MatchResult::empty): Deleted.
- runtime/RegExpObject.cpp:
(JSC::RegExpObject::match):
(JSC::collectMatches):
(JSC::RegExpObject::matchGlobal):
- runtime/StringObject.h:
(JSC::jsStringWithReuse):
(JSC::jsSubstring):
- tests/stress/big-match.js: Added. Make sure that this optimization doesn't break big matches.
- 6:51 AM Changeset in webkit [201450] by
-
- 3 edits3 adds in trunk
Video play glyph not visible if initially invisible when contained in a "-webkit-overflow-scrolling: touch" container
https://bugs.webkit.org/show_bug.cgi?id=158146
<rdar://problem/25816307>
Patch by Antoine Quint <Antoine Quint> on 2016-05-27
Reviewed by Dean Jackson.
Source/WebCore:
We now force the <video> controls play glyph into being composited due to webkit.org/b/158147. In most scenarios,
this element gets composited anyway, this is just to ensure that this happens in all cases until we get the
general fix for webkit.org/b/158147.
Test: platform/ios-simulator/media/video-play-glyph-composited-outside-overflow-scrolling-touch-container.html
- Modules/mediacontrols/mediaControlsiOS.css:
(video::-webkit-media-controls-start-playback-button .webkit-media-controls-start-playback-glyph):
LayoutTests:
Testing that on iOS the play glyph for <video> controls when play button would be initially invisible when contained
in a scrollable container is indeed composited.
- platform/ios-simulator/media/video-play-glyph-composited-outside-overflow-scrolling-touch-container-expected.txt: Added.
- platform/ios-simulator/media/video-play-glyph-composited-outside-overflow-scrolling-touch-container.html: Added.
- 12:18 AM Changeset in webkit [201449] by
-
- 2 edits in trunk/Tools
New intl-numberformat.js test fails on many Linux platforms
https://bugs.webkit.org/show_bug.cgi?id=154530
Reviewed by Darin Adler.
The test is actually failing because of a bug in the icu version installed in the bots, using a newer version of
icu makes the tests pass and explains why it worked for some people. So, let's add icu 55.1 to the internal
jhbuild to ensure JSC tests pass in the bots no matter what the icu version installed is.
- gtk/jhbuild.modules:
- 12:09 AM Changeset in webkit [201448] by
-
- 68 edits in trunk/Source/JavaScriptCore
Static table property lookup should not require getOwnPropertySlot override.
https://bugs.webkit.org/show_bug.cgi?id=158059
Reviewed by Darin Adler.
Currently JSObject does not handle property lookup of entries in the static
table. Each subclass with static properties mut override getOwnPropertySlot,
and explicitly call the lookup functions. This has the following drawbacks:
- Performance: for any class with static properties, property acces becomes virtual (via method table).
- Poor encapsulation: implementation detail of static property access is spread throughout & cross projects, rather than being contained in JSObject.
- Code size: this results in a great many additional functions.
- Inconsistency: static table presence has to be be taken into account in many other operations, e.g. presence of read-only properties for put.
- Memory: in order to avoid the virtual lookup, DOM prototypes eagerly reify all properties. This is likely suboptimal.
Instead, JSObject::getPropertySlot / JSObject::getOwnPropertySlot should be
able to handle static properties.
This is actually a fairly small & simple change.
The common pattern is for subclasses of JObject to override getOwnPropertySlot
to first defer to JSObject for property storage lookup, and only if this fails
consult the static table. They just want the static tables to be consulted after
regular property storgae lookup. So just add a fast flag in TypeInfo for JSObject
to check, and where it is set, do so. Then it's just a question of switching
classes over to start setting this flag, and drop the override.
The new mechanism does change static table lookup order from oldest-ancestor
first to most-derived first. The new ordering makes more sense (means derived
class static tables can now override entries from parents), and shoudn't affect
any existing code (since overriding didn't previously work, there likely aren't
shadowing properties in more derived types).
This patch changes all classes in JavaScriptCore over to using the new mechanism,
except JSGlobalObject. I'll move classes in WebCore over as a separate patch
(this is also why I've not moved JSGlobalObject in this patch - doing so would
move JSDOMWindow, and I'd rather handle that separately).
- runtime/JSTypeInfo.h:
(JSC::TypeInfo::hasStaticPropertyTable):
- Add HasStaticPropertyTable flag.
- runtime/Lookup.cpp:
(JSC::setUpStaticFunctionSlot):
- Change setUpStaticFunctionSlot to take a VM&.
- runtime/Lookup.h:
(JSC::getStaticPropertySlotFromTable):
- Added helper function to perform static lookup alone.
(JSC::getStaticPropertySlot):
(JSC::getStaticFunctionSlot):
- setUpStaticFunctionSlot changed to take a VM&.
- runtime/JSObject.cpp:
(JSC::JSObject::getOwnStaticPropertySlot):
- Added, walks ClassInfo chain looking for static properties.
- runtime/JSObject.h:
(JSC::JSObject::getOwnNonIndexPropertySlot):
- getOwnNonIndexPropertySlot is used internally by getPropertySlot & getOwnPropertySlot. If property is not present in storage array then check the static table.
- runtime/ArrayConstructor.cpp:
(JSC::ArrayConstructor::finishCreation):
(JSC::constructArrayWithSizeQuirk):
(JSC::ArrayConstructor::getOwnPropertySlot): Deleted.
- runtime/ArrayConstructor.h:
(JSC::ArrayConstructor::create):
- runtime/ArrayIteratorPrototype.cpp:
(JSC::ArrayIteratorPrototype::finishCreation):
(JSC::ArrayIteratorPrototype::getOwnPropertySlot): Deleted.
- runtime/ArrayIteratorPrototype.h:
(JSC::ArrayIteratorPrototype::create):
(JSC::ArrayIteratorPrototype::ArrayIteratorPrototype):
- runtime/BooleanPrototype.cpp:
(JSC::BooleanPrototype::finishCreation):
(JSC::booleanProtoFuncToString):
(JSC::BooleanPrototype::getOwnPropertySlot): Deleted.
- runtime/BooleanPrototype.h:
(JSC::BooleanPrototype::create):
- runtime/DateConstructor.cpp:
(JSC::DateConstructor::finishCreation):
(JSC::millisecondsFromComponents):
(JSC::DateConstructor::getOwnPropertySlot): Deleted.
- runtime/DateConstructor.h:
(JSC::DateConstructor::create):
- runtime/DatePrototype.cpp:
(JSC::DatePrototype::finishCreation):
(JSC::dateProtoFuncToString):
(JSC::DatePrototype::getOwnPropertySlot): Deleted.
- runtime/DatePrototype.h:
(JSC::DatePrototype::create):
- runtime/ErrorPrototype.cpp:
(JSC::ErrorPrototype::finishCreation):
(JSC::ErrorPrototype::getOwnPropertySlot): Deleted.
- runtime/ErrorPrototype.h:
(JSC::ErrorPrototype::create):
- runtime/GeneratorPrototype.cpp:
(JSC::GeneratorPrototype::finishCreation):
(JSC::GeneratorPrototype::getOwnPropertySlot): Deleted.
- runtime/GeneratorPrototype.h:
(JSC::GeneratorPrototype::create):
(JSC::GeneratorPrototype::createStructure):
(JSC::GeneratorPrototype::GeneratorPrototype):
- runtime/InspectorInstrumentationObject.cpp:
(JSC::InspectorInstrumentationObject::finishCreation):
(JSC::InspectorInstrumentationObject::isEnabled):
(JSC::InspectorInstrumentationObject::getOwnPropertySlot): Deleted.
- runtime/InspectorInstrumentationObject.h:
(JSC::InspectorInstrumentationObject::create):
(JSC::InspectorInstrumentationObject::createStructure):
- runtime/IntlCollatorConstructor.cpp:
(JSC::IntlCollatorConstructor::getCallData):
(JSC::IntlCollatorConstructorFuncSupportedLocalesOf):
(JSC::IntlCollatorConstructor::getOwnPropertySlot): Deleted.
- runtime/IntlCollatorConstructor.h:
- runtime/IntlCollatorPrototype.cpp:
(JSC::IntlCollatorPrototype::finishCreation):
(JSC::IntlCollatorFuncCompare):
(JSC::IntlCollatorPrototype::getOwnPropertySlot): Deleted.
- runtime/IntlCollatorPrototype.h:
- runtime/IntlDateTimeFormatConstructor.cpp:
(JSC::IntlDateTimeFormatConstructor::getCallData):
(JSC::IntlDateTimeFormatConstructorFuncSupportedLocalesOf):
(JSC::IntlDateTimeFormatConstructor::getOwnPropertySlot): Deleted.
- runtime/IntlDateTimeFormatConstructor.h:
- runtime/IntlDateTimeFormatPrototype.cpp:
(JSC::IntlDateTimeFormatPrototype::finishCreation):
(JSC::IntlDateTimeFormatFuncFormatDateTime):
(JSC::IntlDateTimeFormatPrototype::getOwnPropertySlot): Deleted.
- runtime/IntlDateTimeFormatPrototype.h:
- runtime/IntlNumberFormatConstructor.cpp:
(JSC::IntlNumberFormatConstructor::getCallData):
(JSC::IntlNumberFormatConstructorFuncSupportedLocalesOf):
(JSC::IntlNumberFormatConstructor::getOwnPropertySlot): Deleted.
- runtime/IntlNumberFormatConstructor.h:
- runtime/IntlNumberFormatPrototype.cpp:
(JSC::IntlNumberFormatPrototype::finishCreation):
(JSC::IntlNumberFormatFuncFormatNumber):
(JSC::IntlNumberFormatPrototype::getOwnPropertySlot): Deleted.
- runtime/IntlNumberFormatPrototype.h:
- runtime/JSDataViewPrototype.cpp:
(JSC::JSDataViewPrototype::createStructure):
(JSC::getData):
(JSC::JSDataViewPrototype::getOwnPropertySlot): Deleted.
- runtime/JSDataViewPrototype.h:
- runtime/JSInternalPromiseConstructor.cpp:
(JSC::JSInternalPromiseConstructor::getCallData):
(JSC::JSInternalPromiseConstructor::getOwnPropertySlot): Deleted.
- runtime/JSInternalPromiseConstructor.h:
- runtime/JSONObject.cpp:
(JSC::Walker::Walker):
(JSC::JSONObject::getOwnPropertySlot): Deleted.
- runtime/JSONObject.h:
(JSC::JSONObject::create):
- runtime/JSPromiseConstructor.cpp:
(JSC::JSPromiseConstructor::getCallData):
(JSC::JSPromiseConstructor::getOwnPropertySlot): Deleted.
- runtime/JSPromiseConstructor.h:
- runtime/JSPromisePrototype.cpp:
(JSC::JSPromisePrototype::addOwnInternalSlots):
(JSC::JSPromisePrototype::getOwnPropertySlot): Deleted.
- runtime/JSPromisePrototype.h:
- runtime/MapPrototype.cpp:
(JSC::MapPrototype::finishCreation):
(JSC::getMap):
(JSC::MapPrototype::getOwnPropertySlot): Deleted.
- runtime/MapPrototype.h:
(JSC::MapPrototype::create):
(JSC::MapPrototype::MapPrototype):
- runtime/ModuleLoaderObject.cpp:
(JSC::ModuleLoaderObject::finishCreation):
(JSC::printableModuleKey):
(JSC::ModuleLoaderObject::getOwnPropertySlot): Deleted.
- runtime/ModuleLoaderObject.h:
- runtime/NumberPrototype.cpp:
(JSC::NumberPrototype::finishCreation):
(JSC::toThisNumber):
(JSC::NumberPrototype::getOwnPropertySlot): Deleted.
- runtime/NumberPrototype.h:
(JSC::NumberPrototype::create):
- runtime/ObjectConstructor.cpp:
(JSC::ObjectConstructor::addDefineProperty):
(JSC::constructObject):
(JSC::ObjectConstructor::getOwnPropertySlot): Deleted.
- runtime/ObjectConstructor.h:
(JSC::ObjectConstructor::create):
(JSC::ObjectConstructor::createStructure):
- runtime/ReflectObject.cpp:
(JSC::ReflectObject::finishCreation):
(JSC::ReflectObject::getOwnPropertySlot): Deleted.
- runtime/ReflectObject.h:
(JSC::ReflectObject::create):
(JSC::ReflectObject::createStructure):
- runtime/RegExpConstructor.cpp:
(JSC::RegExpConstructor::getRightContext):
(JSC::regExpConstructorDollar):
(JSC::RegExpConstructor::getOwnPropertySlot): Deleted.
- runtime/RegExpConstructor.h:
(JSC::RegExpConstructor::create):
(JSC::RegExpConstructor::createStructure):
- runtime/SetPrototype.cpp:
(JSC::SetPrototype::finishCreation):
(JSC::getSet):
(JSC::SetPrototype::getOwnPropertySlot): Deleted.
- runtime/SetPrototype.h:
(JSC::SetPrototype::create):
(JSC::SetPrototype::SetPrototype):
- runtime/StringConstructor.cpp:
(JSC::StringConstructor::finishCreation):
(JSC::stringFromCharCodeSlowCase):
(JSC::StringConstructor::getOwnPropertySlot): Deleted.
- runtime/StringConstructor.h:
(JSC::StringConstructor::create):
- runtime/StringIteratorPrototype.cpp:
(JSC::StringIteratorPrototype::finishCreation):
(JSC::StringIteratorPrototype::getOwnPropertySlot): Deleted.
- runtime/StringIteratorPrototype.h:
(JSC::StringIteratorPrototype::create):
(JSC::StringIteratorPrototype::StringIteratorPrototype):
- runtime/StringPrototype.cpp:
(JSC::StringPrototype::create):
(JSC::substituteBackreferencesSlow):
(JSC::StringPrototype::getOwnPropertySlot): Deleted.
- runtime/StringPrototype.h:
- runtime/SymbolConstructor.cpp:
(JSC::SymbolConstructor::finishCreation):
(JSC::callSymbol):
(JSC::SymbolConstructor::getOwnPropertySlot): Deleted.
- runtime/SymbolConstructor.h:
(JSC::SymbolConstructor::create):
- runtime/SymbolPrototype.cpp:
(JSC::SymbolPrototype::finishCreation):
(JSC::SymbolPrototype::getOwnPropertySlot): Deleted.
- runtime/SymbolPrototype.h:
(JSC::SymbolPrototype::create):
- remove getOwnPropertySlot, replace OverridesGetOwnPropertySlot flag with HasStaticPropertyTable.
May 26, 2016:
- 10:43 PM Changeset in webkit [201447] by
-
- 3 edits4 adds in trunk
Preload single download tests.
https://bugs.webkit.org/show_bug.cgi?id=157988
Reviewed by Alex Christensen.
Source/WebCore:
ResourceTiming entries for some subresource weren't registered as resource->response().isHTTP() was false, since
resource->response().url() was empty. I switched the check to use resource->resourceRequest().url() directly instead.
Test: http/tests/preload/single_download_preload_runner.html
- loader/ResourceTimingInformation.cpp:
(WebCore::ResourceTimingInformation::addResourceTiming):
LayoutTests:
Make sure preload is only downloading a single resource, which is properly reused.
- http/tests/preload/resources/single_download_preload.html: Added.
- http/tests/preload/single_download_preload_runner-expected.txt: Added.
- http/tests/preload/single_download_preload_runner.html: Added.
- 10:40 PM Changeset in webkit [201446] by
-
- 2 edits in trunk/LayoutTests
Unreviewed EFL gardening.
Release some passing tests which have been marked to Crash, Failure.
- platform/efl/TestExpectations:
- 8:31 PM Changeset in webkit [201445] by
-
- 7 edits in trunk/Source/JavaScriptCore
Unreviewed, rolling out r201436.
https://bugs.webkit.org/show_bug.cgi?id=158143
Caused 30% regression on Dromaeo DOM core tests (Requested by
rniwa on #webkit).
Reverted changeset:
"REGRESSION: JSBench spends a lot of time transitioning
to/from dictionary"
https://bugs.webkit.org/show_bug.cgi?id=158045
http://trac.webkit.org/changeset/201436
- 8:19 PM Changeset in webkit [201444] by
-
- 2 edits in trunk/Source/WebKit2
Certain NetworkResourceLoader callbacks can deref a null m_networkLoad.
https://bugs.webkit.org/show_bug.cgi?id=158134
Reviewed by Alex Christensen.
It's legit for m_networkLoad to be null in these callbacks.
We need null checks, just like we have in many other callbacks in this class.
- NetworkProcess/NetworkResourceLoader.cpp:
(WebKit::NetworkResourceLoader::continueWillSendRequest):
(WebKit::NetworkResourceLoader::continueCanAuthenticateAgainstProtectionSpace):
- 6:41 PM Changeset in webkit [201443] by
-
- 3 edits2 adds in trunk
AX: Wrong CharacterOffset from VisiblePosition with composed characters
https://bugs.webkit.org/show_bug.cgi?id=158138
Reviewed by Chris Fleizach.
Source/WebCore:
The conversion logic is not correct when the text node contains composed characters.
We should use VisiblePosition's offset directly for text nodes so we won't mess things up.
Test: accessibility/mac/character-offset-visible-position-conversion-with-emoji.html
- accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::visiblePositionFromCharacterOffset):
(WebCore::AXObjectCache::characterOffsetFromVisiblePosition):
LayoutTests:
- accessibility/mac/character-offset-visible-position-conversion-with-emoji-expected.txt: Added.
- accessibility/mac/character-offset-visible-position-conversion-with-emoji.html: Added.
- 5:40 PM Changeset in webkit [201442] by
-
- 29 edits in trunk
[JSC] Allow JSBench to use precise time
https://bugs.webkit.org/show_bug.cgi?id=158050
Reviewed by Geoffrey Garen.
PerformanceTests:
- JSBench/amazon-chrome-win/urem.js:
(else.window.performance.window.performance.now.currentTimeInMS):
(else.else.typeof.preciseTime.string_appeared_here.currentTimeInMS):
(else.else.currentTimeInMS):
(onload.cb):
(onload):
- JSBench/amazon-chrome/urem.js:
(else.window.performance.window.performance.now.currentTimeInMS):
(else.else.typeof.preciseTime.string_appeared_here.currentTimeInMS):
(else.else.currentTimeInMS):
(onload.cb):
(onload):
- JSBench/amazon-firefox-win/urm.js:
(else.window.performance.window.performance.now.currentTimeInMS):
(else.else.typeof.preciseTime.string_appeared_here.currentTimeInMS):
(else.else.currentTimeInMS):
(onload.cb):
(onload):
- JSBench/amazon-firefox/urm.js:
(else.window.performance.window.performance.now.currentTimeInMS):
(else.else.typeof.preciseTime.string_appeared_here.currentTimeInMS):
(else.else.currentTimeInMS):
(onload.cb):
(onload):
- JSBench/amazon-safari/urem.js:
(else.window.performance.window.performance.now.currentTimeInMS):
(else.else.typeof.preciseTime.string_appeared_here.currentTimeInMS):
(else.else.currentTimeInMS):
(onload.cb):
(onload):
- JSBench/facebook-chrome-win/urem.js:
(else.window.performance.window.performance.now.currentTimeInMS):
(else.else.typeof.preciseTime.string_appeared_here.currentTimeInMS):
(else.else.currentTimeInMS):
(onload.cb):
(onload):
- JSBench/facebook-chrome/urem.js:
(else.window.performance.window.performance.now.currentTimeInMS):
(else.else.typeof.preciseTime.string_appeared_here.currentTimeInMS):
(else.else.currentTimeInMS):
(onload.cb):
(onload):
- JSBench/facebook-firefox-win/urem.js:
(else.window.performance.window.performance.now.currentTimeInMS):
(else.else.typeof.preciseTime.string_appeared_here.currentTimeInMS):
(else.else.currentTimeInMS):
(onload.cb):
(onload):
- JSBench/facebook-firefox/urem.js:
(else.window.performance.window.performance.now.currentTimeInMS):
(else.else.typeof.preciseTime.string_appeared_here.currentTimeInMS):
(else.else.currentTimeInMS):
(onload.cb):
(onload):
- JSBench/facebook-safari/urem.js:
(else.window.performance.window.performance.now.currentTimeInMS):
(else.else.typeof.preciseTime.string_appeared_here.currentTimeInMS):
(else.else.currentTimeInMS):
(onload.cb):
(onload):
- JSBench/google-chrome-win/urem.js:
(else.window.performance.window.performance.now.currentTimeInMS):
(else.else.typeof.preciseTime.string_appeared_here.currentTimeInMS):
(else.else.currentTimeInMS):
(onload.cb):
(onload):
- JSBench/google-chrome/urem.js:
(else.window.performance.window.performance.now.currentTimeInMS):
(else.else.typeof.preciseTime.string_appeared_here.currentTimeInMS):
(else.else.currentTimeInMS):
(onload.cb):
(onload):
- JSBench/google-firefox-win/urem.js:
(else.window.performance.window.performance.now.currentTimeInMS):
(else.else.typeof.preciseTime.string_appeared_here.currentTimeInMS):
(else.else.currentTimeInMS):
(onload.cb):
(onload):
- JSBench/google-firefox/uem.js:
(else.window.performance.window.performance.now.currentTimeInMS):
(else.else.typeof.preciseTime.string_appeared_here.currentTimeInMS):
(else.else.currentTimeInMS):
(onload.cb):
(onload):
- JSBench/google-safari/urem.js:
(else.window.performance.window.performance.now.currentTimeInMS):
(else.else.typeof.preciseTime.string_appeared_here.currentTimeInMS):
(else.else.currentTimeInMS):
(onload.cb):
(onload):
- JSBench/harness.js:
(runBenchmark.window.currentTimeInMS):
(runBenchmark.else.window.currentTimeInMS):
- JSBench/twitter-chrome-win/rem.js:
(else.window.performance.window.performance.now.currentTimeInMS):
(else.else.typeof.preciseTime.string_appeared_here.currentTimeInMS):
(else.else.currentTimeInMS):
(onload.cb):
(onload):
- JSBench/twitter-chrome/urem.js:
(else.window.performance.window.performance.now.currentTimeInMS):
(else.else.typeof.preciseTime.string_appeared_here.currentTimeInMS):
(else.else.currentTimeInMS):
(onload.cb):
(onload):
- JSBench/twitter-firefox-win/urem.js:
(else.window.performance.window.performance.now.currentTimeInMS):
(else.else.typeof.preciseTime.string_appeared_here.currentTimeInMS):
(else.else.currentTimeInMS):
(onload.cb):
(onload):
- JSBench/twitter-firefox/urem.js:
(else.window.performance.window.performance.now.currentTimeInMS):
(else.else.typeof.preciseTime.string_appeared_here.currentTimeInMS):
(else.else.currentTimeInMS):
(onload.cb):
(onload):
- JSBench/twitter-safari/urem.js:
(else.window.performance.window.performance.now.currentTimeInMS):
(else.else.typeof.preciseTime.string_appeared_here.currentTimeInMS):
(else.else.currentTimeInMS):
(onload.cb):
(onload):
- JSBench/yahoo-chrome-win/urem.js:
(else.window.performance.window.performance.now.currentTimeInMS):
(else.else.typeof.preciseTime.string_appeared_here.currentTimeInMS):
(else.else.currentTimeInMS):
(onload.cb):
(onload):
- JSBench/yahoo-chrome/urem.js:
(else.window.performance.window.performance.now.currentTimeInMS):
(else.else.typeof.preciseTime.string_appeared_here.currentTimeInMS):
(else.else.currentTimeInMS):
(onload.cb):
(onload):
- JSBench/yahoo-firefox-win/urem.js:
(else.window.performance.window.performance.now.currentTimeInMS):
(else.else.typeof.preciseTime.string_appeared_here.currentTimeInMS):
(else.else.currentTimeInMS):
(onload.cb):
(onload):
- JSBench/yahoo-firefox/urem.js:
(else.window.performance.window.performance.now.currentTimeInMS):
(else.else.typeof.preciseTime.string_appeared_here.currentTimeInMS):
(else.else.currentTimeInMS):
(onload.cb):
(onload):
- JSBench/yahoo-safari/urem.js:
(else.window.performance.window.performance.now.currentTimeInMS):
(else.else.typeof.preciseTime.string_appeared_here.currentTimeInMS):
(else.else.currentTimeInMS):
(onload.cb):
(onload):
Tools:
JSBench use
new Date().getTime()without options and there is no way to use precise time.
This patch modifies the JSBench code to inject the code taking the precise time.
currentTimeInMSis given by the benchmerk harness and JSBench uses it.
run-jsc-benchmark switches this function's implementation betweenDate.now()and
testRunner's precise time one.
While this patch modifies the code of JSBench, the last release of JSBench is Jan 2013 and
the contents are not changed for a long time. As described in the original paper[1], the
tests can be generated by using JSBench's record & replay system, but in that case, we can
adopt this modification by changing the tool side.
We also add currentTimeInMS implementation in harness.js and u?rem.js directly.
u?rem.js implementation is required when it is executed in u?rem.html without harness.
And harness.js implementation is required when it is executed in the JSBench's harness.
In these implementation, we follow the JetStream's time measuring function: performance.now(),
preciseTime(), or Date.now().
[1]: http://dl.acm.org/citation.cfm?id=2048119
- Scripts/run-jsc-benchmarks:
- 5:05 PM Changeset in webkit [201441] by
-
- 59 edits in trunk/Source
Media queries and platform screen modernization and streamlining
https://bugs.webkit.org/show_bug.cgi?id=158067
Reviewed by Alex Christensen.
Source/WebCore:
- bindings/objc/DOM.mm:
(-[DOMHTMLLinkElement _mediaQueryMatches]): Use references, use fastGetAttribute,
pass a document instead of a frame to the media query evaluator and a reference instead
of a pointer.
- css/CSSGrammar.y.in: Use "expression" instead of "exp" for media query expressions.
Update vectors and arguments to move media query expressions instead of using unique_ptr.
- css/CSSImportRule.h: Use pragma once. Removed unneeded forward declarations.
Made more overrides private and marked them final.
- css/CSSParser.cpp:
(WebCore::CSSParser::SourceSize::SourceSize): Added missing WTFMove to avoid reference
count churn. Changed type of expression to no longer use unique_ptr.
(WebCore::CSSParser::sourceSize): Ditto.
- css/CSSParser.h: Changed SourceSize::expression to no longer use unique_ptr.
Also changed SourceSize::length to be Ref instead of RefPtr.
- css/DocumentRuleSets.cpp:
(WebCore::DocumentRuleSets::appendAuthorStyleSheets): Updated for changes to
MediaQueryEvaluator.
- css/MediaFeatureNames.cpp:
(WebCore::MediaFeatureNames::init): Streamlined a bit. Removed "MediaFeature" suffix from
names of media feature strings.
- css/MediaFeatureNames.h: Use pragma once. Changed media feature name globals
to use normal WebKit naming style instead of all lowercase with underscores.
Sorted alphabetically. Removed "MediaFeature" suffix from names of media feature strings.
- css/MediaList.cpp:
(WebCore::MediaQuerySet::MediaQuerySet): Simplified copy constructor since the queries
vector can now be copied normally.
(WebCore::parseMediaDescriptor): Normalized types and changed to use isASCIIAlphanumeric.
The old code was not handling '0' the way the comment said it did.
(WebCore::MediaQuerySet::internalParse): Added. Helper function to cut down on redundant
code in functions below.
(WebCore::MediaQuerySet::parse): Use stripLeadingAndTrailingHTMLSpaces instead of
stripWhiteSpace. Streamlined logic using helper function. Updated to use a vector of
queries instead of a vector of unique_ptr.
(WebCore::MediaQuerySet::add): Use internalParse.
(WebCore::MediaQuerySet::remove): Ditto.
(WebCore::MediaQuerySet::addMediaQuery): Changed argument type to not be unique_ptr.
(WebCore::MediaQuerySet::mediaText): Use modern for loop.
(WebCore::MediaList::MediaList): Initialize pointers to null in the class definition
rather than in these constructors.
(WebCore::MediaList::setMediaText): Removed unhelpful local variable.
(WebCore::MediaList::item): Updated since queries no longer use unique_ptr.
(WebCore::addResolutionWarningMessageToConsole): Changed argument types to references
instead of pointers with assertions.
(WebCore::reportMediaQueryWarningIfNeeded): Updated to modernize.
- css/MediaList.h: Use pragma once. Removed unneeded includes and forward declarations.
Changed vector to contain media queries instead of unique_ptr. Use nullptr instead of 0.
Initialize pointers to null here.
- css/MediaQuery.cpp: Deleted now-unneeded copy constructor and destructor. Both are
correctly generated without us writing them explicitly.
(WebCore::MediaQuery::serialize): Rewrote to streamline.
(WebCore::MediaQuery::MediaQuery): Updates since expressions are no longer unique_ptr.
(WebCore::MediaQuery::cssText): Changed return type to reference.
- css/MediaQuery.h: Use pragma once. Added include since this now includes media query
expressions, not just unique_ptr. Deleted the unneeded copy function.
- css/MediaQueryEvaluator.cpp:
(WebCore::isViewportDependent): Moved this here. It used to be a member function of
MediaQueryExp, but this file has a lot more functions about specific features and how
they are evaluated, so it really belongs here.
(WebCore::MediaQueryEvaluator::MediaQueryEvaluator): Changed constructor to take a
document instead of a frame. Initialize the fallback result in the class definition.
(WebCore::MediaQueryEvaluator::evaluate): Changed the argument type to a reference.
(WebCore::compareValue): Made both of the arguments separate template types. This
helps us compare an integer to a double without lots of type casts.
(WebCore::compareAspectRatioValue): Changed to use early return style and got rid of
the casts to int so we will do the work in double instead.
(WebCore::doubleValue): Replaced the old numberValue function with this. Since values
are stored as doubles, it's much better to use double rather than float.
(WebCore::zeroEvaluate): Added. Helpful for the many functions that just need to
evaluate as 0.
(WebCore::oneEvaluate): Ditto.
(WebCore::colorEvaluate): Renamed this and all the functions below. Simplified the logic
to use the new doubleValue function.
(WebCore::colorIndexEvaluate): Use zeroEvaluate.
(WebCore::colorGamutEvaluate): No longer use page just to get from the frame to the
main frame.
(WebCore::monochromeEvaluate): Simplify logic using zeroEvaluate.
(WebCore::invertedColorsEvaluate): Use auto for the keyword; easier to read.
(WebCore::orientationEvaluate): Use early return style.
(WebCore::aspectRatioEvaluate): Ditto.
(WebCore::deviceAspectRatioEvaluate): Simplified logic and removed type casts.
(WebCore::evaluateResolution): Added a couple null checks.
(WebCore::devicePixelRatioEvaluate): Renamed. Added missing type check.
(WebCore::resolutionEvaluate): Ditto.
(WebCore::gridEvaluate): Use zeroEvaluate.
(WebCore::computeLength): Added a null check.
(WebCore::deviceHeightEvaluate): Use early return.
(WebCore::deviceWidthEvaluate): Ditto.
(WebCore::heightEvaluate): Ditto.
(WebCore::widthEvaluate): Ditto.
(WebCore::minColorEvaluate): Updated name only.
(WebCore::maxColorEvaluate): Ditto.
(WebCore::minColorIndexEvaluate): Ditto.
(WebCore::maxColorIndexEvaluate): Ditto.
(WebCore::minMonochromeEvaluate): Ditto.
(WebCore::maxMonochromeEvaluate): Ditto.
(WebCore::minAspectRatioEvaluate): Ditto.
(WebCore::maxAspectRatioEvaluate): Ditto.
(WebCore::minDeviceAspectRatioEvaluate): Ditto.
(WebCore::maxDeviceAspectRatioEvaluate): Ditto.
(WebCore::minDevicePixelRatioEvaluate): Ditto.
(WebCore::maxDevicePixelRatioEvaluate): Ditto.
(WebCore::minHeightEvaluate): Ditto.
(WebCore::maxHeightEvaluate): Ditto.
(WebCore::minWidthEvaluate): Ditto.
(WebCore::maxWidthEvaluate): Ditto.
(WebCore::minDeviceHeightEvaluate): Ditto.
(WebCore::maxDeviceHeightEvaluate): Ditto.
(WebCore::minDeviceWidthEvaluate): Ditto.
(WebCore::maxDeviceWidthEvaluate): Ditto.
(WebCore::minResolutionEvaluate): Ditto.
(WebCore::maxResolutionEvaluate): Ditto.
(WebCore::animationEvaluate): Use oneEvaluate.
(WebCore::transitionEvaluate): Ditto.
(WebCore::transform2dEvaluate): Ditto.
(WebCore::transform3dEvaluate): Simplify using zeroEvaluate and oneEvaluate.
(WebCore::viewModeEvaluate): Simplified logic with fewer local variables and the name "keyword".
(WebCore::videoPlayableInlineEvaluate): Use reference.
(WebCore::hoverEvaluate): Simplify using keyword.
(WebCore::anyHoverEvaluate): Just updated name.
(WebCore::pointerEvaluate): Simplify using keyword.
(WebCore::anyPointerEvaluate): Just updated name.
(WebCore::add): Added. Helper for building up the media query function map.
(WebCore::MediaQueryEvaluator::evaluate): Moved code to build the function map in here in
a lambda, rather than having it in a separate global function.
- css/MediaQueryEvaluator.h: Use pragma once. Removed uneeded includes. Simplified comments and
modernized their style.
- css/MediaQueryExp.cpp:
(WebCore::isFeatureValidWithIdentifier): Renamed to make it clearer what this does. Updated
to take a reference and use te new feature names.
(WebCore::isFeatureValidWithNonNegativeLengthOrNumber): Ditto.
(WebCore::isFeatureValidWithDensity): Ditto.
(WebCore::isFeatureValidWithNonNegativeInteger): Ditto.
(WebCore::isFeatureValidWithNonNegativeNumber): Ditto.
(WebCore::isFeatureValidWithZeroOrOne): Ditto.
(WebCore::isAspectRatioFeature): Ditto.
(WebCore::isFeatureValidWithoutValue): Ditto.
(WebCore::isFeatureValidWithNumberWithUnit): Added. Helper that calls multiple functions above.
(WebCore::isFeatureValidWithNumber): Ditto.
(WebCore::isSlash): Added. Helper to make aspect ratio code below easier to read.
(WebCore::isPositiveIntegerValue): Ditto.
(WebCore::MediaQueryExpression::MediaQueryExpression): Rearranged code to be much less wordy and
to not use current/next.
- css/MediaQueryExp.h: Use pragma once. Renamed class to MediaQueryExpression. Removed
the isViewportDependent function, now part of MediaQueryEvaluator. Removed unneeded includes.
- css/MediaQueryList.cpp:
(WebCore::MediaQueryList::MediaQueryList): Marked this inline. Use a reference and a Ref&&
instead of PassRefPtr.
(WebCore::MediaQueryList::create): Updated argument types.
(WebCore::MediaQueryList::addListener): Updated argument type and use releaseNonNull.
(WebCore::MediaQueryList::removeListener): Updated argument types.
(WebCore::MediaQueryList::evaluate): Ditto.
(WebCore::MediaQueryList::matches): More of the same.
- css/MediaQueryList.h: Use pragma once. Changed types to use references, RefPtr&& and Ref&&.
- css/MediaQueryMatcher.cpp:
(WebCore::MediaQueryMatcher::MediaQueryMatcher): Take a reference.
(WebCore::MediaQueryMatcher::documentDestroyed): Use nullptr.
(WebCore::MediaQueryMatcher::documentElementUserAgentStyle): Use auto.
(WebCore::MediaQueryMatcher::evaluate): Take a reference. Updated for changes to MediaQueryEvaluator.
(WebCore::MediaQueryMatcher::matchMedia): Updated for above changes.
(WebCore::MediaQueryMatcher::addListener): Use Ref&& and reference for arguments. Simplify code.
(WebCore::MediaQueryMatcher::removeListener): Ditto.
(WebCore::MediaQueryMatcher::styleResolverChanged): Moved the logic for evaluating each query here.
Updated for changes to MediaQueryEvaluator.
- css/MediaQueryMatcher.h: Use pragma once. Changed create to take a reference. Tightened argument
types for addListener and removeListener. Made the private Listener a simple struct rather than a
class. Initialized m_evaluationRound.
- css/RuleSet.cpp:
(WebCore::RuleSet::addChildRules): Updated for changes to MediaQueryEvaluator.
(WebCore::RuleSet::addRulesFromSheet): Ditto.
- css/SourceSizeList.cpp:
(WebCore::match): Updated to use MediaQueryEvaluator in a simpler way.
(WebCore::defaultLength): Use a reference and simpler syntax.
(WebCore::computeLength): Ditto.
(WebCore::parseSizesAttribute): Changed arguments to take a Document instead of both a
RenderView and a Frame.
- css/SourceSizeList.h: Use #pragma once. Change parseSizesAttribute to take a Document.
- css/StyleMedia.cpp:
(WebCore::StyleMedia::matchMedium): Update for changes to MediaQueryEvaluator.
- css/StyleResolver.cpp:
(WebCore::StyleResolver::StyleResolver): Use a MediaQueryEvaluator instead of a unique_ptr
to one.
(WebCore::StyleResolver::appendAuthorStyleSheets): Ditto.
(WebCore::StyleResolver::styleForElement): Ditto.
(WebCore::StyleResolver::pseudoStyleForElement): Ditto.
(WebCore::StyleResolver::pseudoStyleRulesForElement): Ditto.
(WebCore::StyleResolver::addViewportDependentMediaQueryResult): Use references instead of
ponters, and use a vector of MediaQueryResult instead of unique_ptr.
(WebCore::StyleResolver::hasMediaQueriesAffectedByViewportChange): Use a modern for loop.
- css/StyleResolver.h: Use a MediaQueryEvaluator instead of a unique_ptr to one.
Use a vector of MediaQueryResult instead of a vector of unique_ptr.
- dom/Document.cpp:
(WebCore::Document::mediaQueryMatcher): Pass a reference instead of a pointer.
- dom/InlineStyleSheetOwner.cpp:
(WebCore::InlineStyleSheetOwner::createSheet): Updated for changes to MediaQueryEvaluator.
- editing/TextIterator.cpp:
(WebCore::SimplifiedBackwardsTextIterator::advance): Removed a stray space (unrelated to
the rest of the patch).
- html/HTMLImageElement.cpp:
(WebCore::HTMLImageElement::bestFitSourceFromPictureElement): Updated for changes to the
MediaQueryEvaluator class. Also use auto a bit more and eliminated a double hash table
lookup in code that used hasAttribute followed by fastGetAttribute.
(WebCore::HTMLImageElement::selectImageSource): Updated for changes to parseSizesAttribute.
- html/HTMLLinkElement.cpp:
(WebCore::HTMLLinkElement::process): Updated for changes to MediaQueryEvaluator.
(WebCore::HTMLLinkElement::setCSSStyleSheet): Use auto.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::selectNextSourceChild): Updated for changes to MediaQueryEvaluator.
- html/HTMLPictureElement.cpp:
(WebCore::HTMLPictureElement::viewportChangeAffectedPicture): Updated for changes to
MediaQueryEvaluator.
- html/HTMLPictureElement.h: Use #pragma once. Changed viewport dependent media query results
vector to be a vector of results, not of unique_ptr.
- html/parser/HTMLPreloadScanner.cpp:
(WebCore::TokenPreloadScanner::StartTagScanner::processAttributes): Updated for changes to
parseSizesAttribute.
(WebCore::TokenPreloadScanner::StartTagScanner::processAttribute): Updated for changes to
MediaQueryEvaluator.
- html/parser/HTMLResourcePreloader.cpp:
(WebCore::mediaAttributeMatches): Updated for changes to MediaQueryEvaluator.
(WebCore::HTMLResourcePreloader::preload): Ditto.
- page/DOMWindow.cpp: Removed unneeded include of PlatformScreen.h.
- page/mac/EventHandlerMac.mm:
(WebCore::EventHandler::effectiveMousePositionForSelectionAutoscroll): Simplified code and
updated for changes to PlatformScreenMac functions.
- platform/PlatformScreen.h: Use #pragma once. Use using instad of typedef. Put the typedef
for PlatformDisplayID inside the WebCore namespace. Removed the typedef for ColorProfile.
Renamed the functions that find a screen to just "screen".
- platform/graphics/DisplayRefreshMonitorClient.cpp:
(WebCore::DisplayRefreshMonitorClient::DisplayRefreshMonitorClient): Moved initialization
of booleans to the class definition.
- platform/graphics/DisplayRefreshMonitorClient.h: Use pragma once. Removed unneeded
forward declarations. Changed display ID data member to be an Optional instead of a boolean
paired with another data member.
- platform/graphics/GraphicsLayerUpdater.h: Use pragma once. Removed unneeded include of
PlatformScreen.h.
- platform/image-decoders/ImageDecoder.h: Use pragma once. Moved ColorProfile here from
PlatformScreen.h, since it's not used there. and is used here.
- platform/mac/PlatformEventFactoryMac.h: Use parma once. Changed reutrn type of the
globalPoint function to NSPoint. Tweaked comments and formatting a bit.
- platform/mac/PlatformEventFactoryMac.mm:
(WebCore::globalPoint): Changed return type to NSPoint and so removed the explicit
conversion to IntPoint.
(WebCore::globalPointForEvent): Changed return type to NSPoint.
(WebCore::PlatformMouseEventBuilder::PlatformMouseEventBuilder): Moved conversion to
IntPoint in here. Also got rid of special indenting style and just indented normally.
(WebCore::PlatformWheelEventBuilder::PlatformWheelEventBuilder): Ditto.
(WebCore::PlatformKeyboardEventBuilder::PlatformKeyboardEventBuilder): Ditto.
- platform/mac/PlatformScreenMac.mm:
(WebCore::displayID): Renamed from displayIDFromScreen and displayFromWidget since this
is C++ and we have overloading to determine the types of arguments. Added a null check
of the how dinwo pointer.
(WebCore::firstScreen): Added. Helper used below.
(WebCore::window): Added. Helper used below.
(WebCore::screen): Renamed from screenForWidget and screenFromWindow and removed the
unneeded window argument from the widget version.
(WebCore::screenDepth): Simplified, using new helpers.
(WebCore::screenDepthPerComponent): Ditto.
(WebCore::screenIsMonochrome): Tweaked comment.
(WebCore::screenHasInvertedColors): Ditto.
(WebCore::screenRect): Simplified using new elpers.
(WebCore::screenAvailableRect): Ditto.
(WebCore::screenSupportsExtendedColor): Streamlined using fewer local variables and
using auto for types of the results of adoptCF.
(WebCore::toUserSpace): Updated for function name changes.
(WebCore::toDeviceSpace): Ditto.
Source/WebKit/mac:
- WebView/WebFrame.mm:
(-[WebFrame _dragSourceEndedAt:operation:]): Updated to use the new version of
globalPoint, which returns an NSPoint.
Source/WebKit2:
- Shared/mac/WebEventFactory.mm:
(WebKit::screenForWindow): Deleted.
(WebKit::flipScreenPoint): Deleted.
(WebKit::globalPoint): Deleted.
(WebKit::globalPointForEvent): Use globalPoint function from WebCore so we don't need
copies of everything in here.
- UIProcess/Cocoa/WebViewImpl.mm:
(WebKit::WebViewImpl::windowDidChangeScreen): Removed unneeded type cast.
(WebKit::WebViewImpl::draggedImage): Added type cast since globalPoint now returns an
NSPoint rather than an IntPoint.
- UIProcess/WebPageProxy.h: Use pragma once. Add a WebCore prefix to a use of
PlatformDisplayID, since that is now inside the WebCore namespace.
- WebProcess/WebCoreSupport/WebChromeClient.h: Ditto.
- WebProcess/WebPage/Cocoa/RemoteLayerTreeDisplayRefreshMonitor.h: Ditto.
- WebProcess/WebPage/DrawingArea.h: Ditto.
- WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.h: Ditto.
- 4:53 PM Changeset in webkit [201440] by
-
- 10 edits in trunk/Source
Purge PassRefPtr in Modules/battery
https://bugs.webkit.org/show_bug.cgi?id=157062
Reviewed by Darin Adler.
Use RefPtr<>& to reduce uses of PassRefPtr in WebKit.
Source/WebCore:
- Modules/battery/BatteryClient.h:
- Modules/battery/BatteryController.cpp:
(WebCore::BatteryController::BatteryController):
(WebCore::BatteryController::~BatteryController):
(WebCore::BatteryController::addListener):
(WebCore::BatteryController::removeListener):
(WebCore::BatteryController::updateBatteryStatus):
(WebCore::BatteryController::didChangeBatteryStatus):
(WebCore::provideBatteryTo):
- Modules/battery/BatteryController.h:
- Modules/battery/BatteryManager.cpp:
(WebCore::BatteryManager::didChangeBatteryStatus):
(WebCore::BatteryManager::updateBatteryStatus):
- Modules/battery/BatteryManager.h:
- Modules/battery/BatteryStatus.h:
- testing/Internals.cpp:
(WebCore::Internals::setBatteryStatus):
Source/WebKit2:
- WebProcess/Battery/WebBatteryManager.cpp:
(WebKit::WebBatteryManager::didChangeBatteryStatus):
(WebKit::WebBatteryManager::updateBatteryStatus):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::m_shouldDispatchFakeMouseMoveEvents):
- 4:40 PM Changeset in webkit [201439] by
-
- 1 edit2 adds in trunk/LayoutTests
DOM mutation methods fail to re-check validity of node insertion after removing nodes from old parent
https://bugs.webkit.org/show_bug.cgi?id=81991
<rdar://problem/11120506>
Reviewed by Chris Dumez.
Add a test case for an old DOM mutation bug that was fixed long ago.
- fast/dom/circular-dom-tree-crash-expected.txt: Added.
- fast/dom/circular-dom-tree-crash.html: Added.
- 4:05 PM Changeset in webkit [201438] by
-
- 2 edits in trunk/Source/WebInspectorUI
Uncaught Exception: TypeError: undefined is not an object (evaluating 'records[endIndex].endTime')
https://bugs.webkit.org/show_bug.cgi?id=158057
Reviewed by Timothy Hatcher.
- UserInterface/Views/TimelineRecordingContentView.js:
(WebInspector.TimelineRecordingContentView.prototype._updateTimelineViewTimes):
When the entire recording is selected, rendering frames should use the
record count as its end time instead of the recording's end time.
- 4:03 PM Changeset in webkit [201437] by
-
- 2 edits in trunk/LayoutTests
Marking js/function-apply.html as a flaky timeout on mac debug wk2
https://bugs.webkit.org/show_bug.cgi?id=158133
Unreviewed test gardening.
- platform/mac-wk2/TestExpectations:
- 3:30 PM Changeset in webkit [201436] by
-
- 7 edits in trunk/Source/JavaScriptCore
REGRESSION: JSBench spends a lot of time transitioning to/from dictionary
https://bugs.webkit.org/show_bug.cgi?id=158045
Reviewed by Saam Barati.
15% speedup on jsbench-amazon-firefox, possibly 5% speedup overall on jsbench.
This regression seems to have two parts:
(1) Transitioning the window object to/from dictionary is more expensive
than it used to be to because the window object has lots more properties.
The window object has more properties because, for WebIDL compatibility,
we reify DOM APIs as properties when you delete.
(2) DOM prototypes transition to/from dictionary upon creation
because, once again for WebIDL compatibility, we reify their static
APIs eagerly.
The solution is to chill out a bit on dictionary transitions.
- bytecode/ObjectPropertyConditionSet.cpp: Don't flatten a dictionary
if we've already done so before. This avoids pathological churn, and it
is our idiom in other places.
- interpreter/Interpreter.cpp:
(JSC::Interpreter::execute): Do flatten the global object unconditionally
if it is an uncacheable dictionary because the global object is super
important.
- runtime/BatchedTransitionOptimizer.h:
(JSC::BatchedTransitionOptimizer::BatchedTransitionOptimizer):
(JSC::BatchedTransitionOptimizer::~BatchedTransitionOptimizer): Deleted.
Don't transition away from dictionary after a batched set of property
puts because normal dictionaries are cacheable and that's a perfectly
fine state to be in -- and the transition is expensive.
- runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::init): Do start the global object out as a cacheable
dictionary because it will inevitably have enough properties to become
a dictionary.
- runtime/Operations.h:
(JSC::normalizePrototypeChain): Same as ObjectPropertyConditionSet.cpp.
- 3:05 PM Changeset in webkit [201435] by
-
- 6 edits in trunk/Source/WebCore
Add WebKitAdditions extension point in HTMLMediaElement.
https://bugs.webkit.org/show_bug.cgi?id=158097
Reviewed by Eric Carlson.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::shouldOverrideBackgroundLoadingRestriction):
We need to load data in the background if playing to wireless playback target.
(WebCore::HTMLMediaElement::fullscreenModeChanged):
Moved from header file.
- html/HTMLMediaElement.h:
- platform/audio/PlatformMediaSession.cpp:
(WebCore::PlatformMediaSession::clientWillPausePlayback):
The code to start m_clientDataBufferingTimer is also in visibilityChanged().
Moved that code to PlatformMediaSession::scheduleClientDataBufferingCheck() and call
that method here.
(WebCore::PlatformMediaSession::visibilityChanged):
Call PlatformMediaSession::scheduleClientDataBufferingCheck().
(WebCore::PlatformMediaSession::scheduleClientDataBufferingCheck):
Start m_clientDataBufferingTimer if it's not already active.
(WebCore::PlatformMediaSession::shouldOverrideBackgroundLoadingRestriction):
Call the client.
- platform/audio/PlatformMediaSession.h:
(WebCore::PlatformMediaSessionClient::shouldOverrideBackgroundLoadingRestriction):
- platform/audio/PlatformMediaSessionManager.cpp:
(WebCore::PlatformMediaSessionManager::sessionCanLoadMedia):
Call the new PlatformMediaSession::shouldOverrideBackgroundLoadingRestriction().
- 3:03 PM Changeset in webkit [201434] by
-
- 2 edits in trunk/Tools
Unreviewed test fix after r201427.
https://bugs.webkit.org/show_bug.cgi?id=157423
<rdar://problem/23751632>
A debug assertion was firing during some test runs due to the Geolocation permission
being turned off during the test. The timer logic was originally written to assert
if the timer fired when permissions were disabled. But this is no longer valid,
because we expect the Geolocation system to be active and become deactivated if the
browsing context violates one of the security criteria.
- DumpRenderTree/mac/UIDelegate.mm:
(-[UIDelegate timerFired]): Remove invalid assertion.
- 2:58 PM Changeset in webkit [201433] by
-
- 7 edits1 add in trunk
ScopedLambda should have a lifetime story that makes sense to the compiler
https://bugs.webkit.org/show_bug.cgi?id=158118
Reviewed by Mark Lam.
Source/WTF:
Prior to this change, there were two lifetime bugs in ScopedLambda:
- scopedLambda(Functor&&) would bind Functor to const lambda&, so the resulting ScopedLambdaFunctor would hold a reference to the original lambda. This would have surprising behavior; for example it meant that this code was wrong:
auto l = scopedLambda<things>([&] ...);
The solution is to have explicit copy/move versions of scopedLambda() rather than rely on perfect
forwarding.
- ScopedLambdaFunctor did not override its copy or move operations, so if the compiler did not RVO scopedLambda(), it would return a ScopedLambdaFunctor whose m_arg points to a dead temporary ScopedLambdaFunctor instance. The solution is to have explicit copy/move constructors and operators, which preserve the invariant that ScopedLambda::m_arg points to this.
One nice side-effect of all of these constructors and operators being explicit is that we can rely
on WTFMove's excellent assertions, which helped catch the first issue.
This reverts ParkingLot to use ScopedLambda again.
- wtf/ParkingLot.cpp:
(WTF::ParkingLot::parkConditionallyImpl):
(WTF::ParkingLot::unparkOne):
(WTF::ParkingLot::unparkOneImpl):
- wtf/ParkingLot.h:
(WTF::ParkingLot::parkConditionally):
(WTF::ParkingLot::unparkOne):
- wtf/ScopedLambda.h:
(WTF::scopedLambda):
Tools:
Added a test case. This test crashes before the fix and now it passes.
- TestWebKitAPI/CMakeLists.txt:
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/WTF/ScopedLambda.cpp: Added.
(TestWebKitAPI::TEST):
- 2:57 PM Changeset in webkit [201432] by
-
- 3 edits in trunk/Source/WebCore
Use std::atomic<> rather than OSAtomicIncrement in CARingBuffer.cpp
https://bugs.webkit.org/show_bug.cgi?id=158129
Reviewed by Eric Carlson.
std::atomic is a more portable atomic primitive than OSAtomicIncrement.
- platform/audio/mac/CARingBuffer.cpp:
(WebCore::CARingBuffer::setCurrentFrameBounds):
(WebCore::CARingBuffer::getCurrentFrameBounds):
(WebCore::CARingBuffer::currentStartFrame):
(WebCore::CARingBuffer::currentEndFrame):
- platform/audio/mac/CARingBuffer.h:
- 2:24 PM Changeset in webkit [201431] by
-
- 3 edits in trunk/Tools
Build fix
Rubber stamped by Lucas Forschler.
- DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
- WebKitTestRunner/Configurations/DebugRelease.xcconfig:
- 2:21 PM Changeset in webkit [201430] by
-
- 4 edits in trunk/Source
Build fix
Rubber stamped by Lucas Forschler.
- Configurations/DebugRelease.xcconfig:
- 1:37 PM Changeset in webkit [201429] by
-
- 2 edits in trunk/Source/WebCore
Rebaseline bindings tests after r201428
Unreviewed test gardening.
- bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::setJSTestObjReplaceableAttribute):
- 12:51 PM Changeset in webkit [201428] by
-
- 7 edits in trunk
replaceable own properties seem to ignore replacement after property caching
https://bugs.webkit.org/show_bug.cgi?id=158091
Reviewed by Darin Adler.
PerformanceTests:
- MallocBench/MallocBench.xcodeproj/project.pbxproj:
- MallocBench/MallocBench/Benchmark.cpp:
- MallocBench/MallocBench/Interpreter.cpp:
(Interpreter::doMallocOp):
- MallocBench/MallocBench/Interpreter.h:
- MallocBench/MallocBench/fastMallocLog.63316.ops: Added.
- MallocBench/MallocBench/jetstream.cpp: Added.
(benchmark_jetstream):
- MallocBench/MallocBench/jetstream.h: Added.
Source/JavaScriptCore:
- runtime/Lookup.h:
(JSC::replaceStaticPropertySlot): New helper function for replacing a
static property with a direct property. We need to do an attribute changed
transition because client code might have cached our static property.
Source/WebCore:
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateImplementation): Use our new replacement helper if we're replacing
an own static property with an own direct property. Because we advertise
that our own static properties are cacheable, we need to do a structure
transition to indicate when they change. (Only own properties need this
special treatment because JSC considers it normal to shadow a prototype
property with an own property.)
LayoutTests:
- js/cached-window-properties.html: Augmneted this test to enter cacheable
dictionary mode in order to demonstrate a bug that is not visible otherwise.
Factored out a helper test function.
- 12:29 PM Changeset in webkit [201427] by
-
- 1 edit3 adds in trunk/LayoutTests
Sites served over insecure connections should not be allowed to use geolocation.
https://bugs.webkit.org/show_bug.cgi?id=157423
<rdar://problem/23751632>
Patch by Pranjal Jumde <pjumde@apple.com> on 2016-05-26
Reviewed by Brent Fulgham.
Add missing test content from r201423.
- http/tests/security/resources/geolocation-over-insecure-content.html: Added.
- http/tests/security/resources/geolocation-over-mixed-content-block.html: Added.
- http/tests/security/resources/geolocation-over-mixed-content.html: Added.
- 12:12 PM Changeset in webkit [201426] by
-
- 2 edits in trunk/LayoutTests
[Win] Update test expectation for imported blink test.
https://bugs.webkit.org/show_bug.cgi?id=158122
Patch by Per Arne Vollan <pvollan@apple.com> on 2016-05-26
Reviewed by Alex Christensen.
The crash on imported/blink/compositing/perspective-origin-overflow-hidden.html
was fixed in https://trac.webkit.org/changeset/192166.
- platform/win/TestExpectations:
- 12:06 PM Changeset in webkit [201425] by
-
- 1 edit2 moves5 adds1 delete in trunk/LayoutTests
Release JSC test test-observegc.js.layout failing.
https://bugs.webkit.org/show_bug.cgi?id=158126
Unreviewed.
Move this test to a directory that is less... "special"
- fast/misc/resources/test-observegc.js: Renamed from LayoutTests/js/script-tests/test-observegc.js.
- fast/misc/test-observegc-expected.txt: Renamed from LayoutTests/js/test-observegc-expected.txt.
- fast/misc/test-observegc.html: Added.
- js/test-observegc.html: Removed.
- 11:46 AM Changeset in webkit [201424] by
-
- 7 edits in trunk/Source/WebCore
BitmapImage::checkForSolidColor() cleanup
https://bugs.webkit.org/show_bug.cgi?id=157750
Patch by Said Abou-Hallawa <sabouhallawa@apple,com> on 2016-05-26
Reviewed by Darin Adler.
Have a single implementation for BitmapImage::checkForSolidColor(). Create
a new function named NativeImage::solidColor() and call it from the former
one. The goal is to have the platform files contain only the platform dependent
code rather than repeating the platform independent code multiple times.
- platform/graphics/BitmapImage.cpp:
(WebCore::BitmapImage::destroyMetadataAndNotify): Invalidate m_solidColor.
(WebCore::BitmapImage::singlePixelSolidColor): Combine mayFillWithSolidColor(),
checkForSolidColor() and solidColor() in one function to guarantee the validity
of the returned value. Before, if solidColor() is called without calling
mayFillWithSolidColor() or checkForSolidColor(), the returned value would be
incorrect.
(WebCore::BitmapImage::dump): Use the m_solidColor Optional and Color states.
(WebCore::BitmapImage::mayFillWithSolidColor): Deleted.
(WebCore::BitmapImage::solidColor): Deleted.
- platform/graphics/BitmapImage.h: Delete m_checkedForSolidColor and
m_isSolidColor and change m_solidColor to be Optional<Color>.
- platform/graphics/Image.cpp:
(WebCore::Image::drawTiled): Use singlePixelSolidColor() and check the returned
value to know whether the singe pixel solid color optimization applies or not.
- platform/graphics/Image.h:
(WebCore::Image::singlePixelSolidColor):
(WebCore::Image::mayFillWithSolidColor): Deleted.
(WebCore::Image::solidColor): Deleted.
Replace mayFillWithSolidColor() and solidColor() with a single function named
singlePixelSolidColor(). isValid() of the returned Color can be used to tell
whether the singe pixel solid color optimization applies or not.
- platform/graphics/cairo/BitmapImageCairo.cpp:
(WebCore::NativeImage::singlePixelSolidColor):
(WebCore::BitmapImage::draw):
(WebCore::BitmapImage::checkForSolidColor): Deleted.
Delete the platform dependent BitmapImage::checkForSolidColor() and add
the new platform dependent function NativeImage::singlePixelSolidColor() and
use to know whether the singe pixel solid color optimization applies or not.
- platform/graphics/cg/BitmapImageCG.cpp:
(WebCore::NativeImage::singlePixelSolidColor):
(WebCore::BitmapImage::draw):
(WebCore::BitmapImage::checkForSolidColor): Deleted.
Ditto.
- 11:19 AM Changeset in webkit [201423] by
-
- 8 edits6 adds in trunk
Sites served over insecure connections should not be allowed to use geolocation.
https://bugs.webkit.org/show_bug.cgi?id=157423
<rdar://problem/23751632>
Patch by Pranjal Jumde <pjumde@apple.com> on 2016-05-26
Reviewed by Brent Fulgham.
Source/WebCore:
Tests: http/tests/security/insecure-geolocation.html
http/tests/security/mixedcontent-geolocation-block-insecure-content.html
http/tests/security/mixedcontent-geolocation.html
- Modules/geolocation/Geolocation.cpp:
(WebCore::logError):
Logs an error to the console if geolocation is blocked.
(WebCore::Geolocation::startRequest):
Access to Geolocation will be blocked if site is not secure. An error will be logged when access to Geolocation is blocked.
(WebCore::Geolocation::shouldBlockGeolocationRequests)
Returns true if the access to geolocation should be blocked.
- Modules/geolocation/Geolocation.h:
- dom/SecurityContext.h:
(WebCore::SecurityContext::foundMixedContent):
Returns true if insecure content was accessed over secure connection.
(WebCore::SecurityContext::setFoundMixedContent):
Sets m_foundMixedContent to true if insecure content is accessed over secure connection.
(WebCore::SecurityContext::geolocationAccessed):
Returns true if geolocation was accessed
(WebCore::SecurityContext::setGeolocationAccessed):
Sets m_geolocationAccessed to true if geolocation was accessed.
- loader/MixedContentChecker.cpp:
(WebCore::MixedContentChecker::canDisplayInsecureContent):
Insecure content will be blocked if geolocation was accessed by the page. Updates document to keep track of mixed content.
(WebCore::MixedContentChecker::canRunInsecureContent):
Insecure content will be blocked if geolocation was accessed by the page. Updates document to keep track of mixed content.
LayoutTests:
- http/tests/security/geolocation-over-insecure-content.html: Added.
- http/tests/security/geolocation-over-mixed-content-block.html: Added.
- http/tests/security/geolocation-over-mixed-content.html: Added.
- http/tests/security/insecure-geolocation-expected.txt: Added.
- http/tests/security/insecure-geolocation.html: Added.
- http/tests/security/mixedcontent-geolocation-block-insecure-content-expected.txt: Added.
- http/tests/security/mixedcontent-geolocation-block-insecure-content.html: Added.
- http/tests/security/mixedcontent-geolocation-expected.txt: Added.
- http/tests/security/mixedcontent-geolocation.html: Added.
- http/tests/security/sandboxed-iframe-geolocation-watchPosition.html: iframe is loaded over secure connection to avoid geolocation failures
- http/tests/security/sandboxed-iframe-geolocation-getCurrentPosition.html: iframe is loaded over secure connection to avoid geolocation failures
- 10:23 AM Changeset in webkit [201422] by
-
- 8 edits6 adds in trunk
Implement internals.observeGC to get called back when a Javascript object is GC'ed.
https://bugs.webkit.org/show_bug.cgi?id=158093
Reviewed by Geoffrey Garen.
Source/WebCore:
Test: js/test-observegc.html
- CMakeLists.txt:
- DerivedSources.make:
- WebCore.xcodeproj/project.pbxproj:
- testing/GCObservation.cpp: Added.
(WebCore::GCObservation::GCObservation):
- testing/GCObservation.h: Added.
- testing/GCObservation.idl: Added.
- testing/Internals.cpp:
(WebCore::Internals::observeGC):
- testing/Internals.h:
- testing/Internals.idl:
LayoutTests:
- js/script-tests/test-observegc.js: Added.
- js/test-observegc-expected.txt: Added.
- js/test-observegc.html: Added.
- 10:08 AM Changeset in webkit [201421] by
-
- 3 edits2 adds in trunk
[Font Loading] Allow empty strings in FontFace constructor
https://bugs.webkit.org/show_bug.cgi?id=158112
Reviewed by Darin Adler.
Source/WebCore:
Other browsers accept empty strings and parse them as if they are omitted.
We should do the same. However, this is only true for the constructor. Setting
an attribute to an empty string should still throw an exception.
Test: fast/text/font-face-empty-string.html
- css/FontFace.cpp:
(WebCore::FontFace::create):
(WebCore::FontFace::setFamily):
(WebCore::FontFace::setStyle):
(WebCore::FontFace::setWeight):
(WebCore::FontFace::setUnicodeRange):
(WebCore::FontFace::setVariant):
(WebCore::FontFace::setFeatureSettings):
LayoutTests:
- fast/text/font-face-empty-string-expected.txt: Added.
- fast/text/font-face-empty-string.html: Added.
- 9:24 AM Changeset in webkit [201420] by
-
- 10 edits1 delete in trunk
WebRTC: RTCSessionDescription: Make attributes readonly (and remove custom binding)
https://bugs.webkit.org/show_bug.cgi?id=157858
Reviewed by Eric Carlson.
Source/WebCore:
Align RTCSessionDescription type with WebRTC 1.0 specification [1].
- Make constructor dictionary member mandatory
- Align constructor dictionary argument (RTCSessionDescriptionInit) with [1]
- Use RTCSdpType enum for the type attribute
- Remove custom binding
[1] https://w3c.github.io/webrtc-pc/archives/20160513/webrtc.html
Updated existing test.
- CMakeLists.txt:
- Modules/mediastream/MediaEndpointPeerConnection.cpp:
(WebCore::MediaEndpointPeerConnection::createOfferTask):
- Modules/mediastream/RTCSessionDescription.cpp:
(WebCore::parseTypeString):
(WebCore::RTCSessionDescription::create):
(WebCore::RTCSessionDescription::RTCSessionDescription):
(WebCore::verifyType): Deleted.
(WebCore::RTCSessionDescription::setType): Deleted.
- Modules/mediastream/RTCSessionDescription.h:
(WebCore::RTCSessionDescription::type):
- Modules/mediastream/RTCSessionDescription.idl:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSRTCSessionDescriptionCustom.cpp: Removed.
(WebCore::constructJSRTCSessionDescription): Deleted.
LayoutTests:
- fast/mediastream/RTCSessionDescription-expected.txt:
- fast/mediastream/RTCSessionDescription.html:
Add tests for mandatory constructor dictionary argument and required 'type' member (also
check its value). Verify that attributes are read-only.
- 9:10 AM Changeset in webkit [201419] by
-
- 4 edits in trunk/Source/WebCore
NativeToJSValue is harcoding the $thisValue in some strings
https://bugs.webkit.org/show_bug.cgi?id=158113
Patch by Alejandro G. Castro <alex@igalia.com> on 2016-05-26
Reviewed by Darin Adler.
Replaced the string with the variable value.
Updated the tests results in the bindings.
- bindings/scripts/CodeGeneratorJS.pm:
(NativeToJSValue): Replaced the hardcoded string with the variable
value.
- bindings/scripts/test/JS/JSTestCallback.cpp:
(WebCore::JSTestCallback::callbackWithSerializedScriptValueParam):
- bindings/scripts/test/JS/JSTestCallbackFunction.cpp:
(WebCore::JSTestCallbackFunction::callbackWithSerializedScriptValueParam):
- 7:28 AM WebKitGTK/2.12.x edited by
- Added r200371 for annulen who lacks edit privs (diff)
- 2:14 AM Changeset in webkit [201418] by
-
- 4 edits in trunk/Source/WebCore
Small improvements to RenderBox/LayoutUnit casting in MathML
https://bugs.webkit.org/show_bug.cgi?id=157943
Patch by Frederic Wang <fwang@igalia.com> on 2016-05-26
Reviewed by Darin Adler.
This is a small follow-up of the RenderMathMLRow/RenderMathMLUnderOver/RenderMathMLFraction
refactoring. Since these MathML renderers can only contain other MathML renderers, we can
just considerer RenderBox children and avoid unnecessary casts. Similarly, when the two
arguments of std::max are LayoutUnit's, we do not need to specialize to std::max<LayoutUnit>.
No new tests, behavior is not changed.
- rendering/mathml/RenderMathMLFraction.cpp:
(WebCore::RenderMathMLFraction::layoutBlock): Do not to specialize to std::max<LayoutUnit>.
- rendering/mathml/RenderMathMLRow.cpp:
(WebCore::RenderMathMLRow::updateOperatorProperties): Browse the list of RenderBox children
and use auto*.
(WebCore::RenderMathMLRow::computeLineVerticalStretch): Do not to specialize to std::max<LayoutUnit>.
- rendering/mathml/RenderMathMLUnderOver.cpp:
(WebCore::RenderMathMLUnderOver::unembellishedOperator): Get the RenderBox child and use auto*.
(WebCore::RenderMathMLUnderOver::computeOperatorsHorizontalStretch): Browse the list of
RenderBox children, use auto* and remove unnecessary casts. Do not to specialize to
std::max<LayoutUnit>.
- 12:54 AM Changeset in webkit [201417] by
-
- 3 edits in trunk/Source/WebCore
AX: crash at AccessibilityRenderObject::remoteSVGRootElement const
https://bugs.webkit.org/show_bug.cgi?id=158098
Reviewed by Joanmarie Diggs.
What looks like happens here is that when a document is torn down and we try to detach, we end up creating an accessibility element during detachment phase.
So instead of just clearing the callback pointer on an existing AXObject, we make a new object and access properties of an object being deallocated.
I tried very hard to make a test but it looks like this can really only be triggered during document tear down which also tears down the AXObjectCache. I didn't
have luck reproducing because of that.
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::remoteSVGElementHitTest):
(WebCore::AccessibilityRenderObject::isSVGImage):
(WebCore::AccessibilityRenderObject::detachRemoteSVGRoot):
(WebCore::AccessibilityRenderObject::remoteSVGRootElement):
(WebCore::AccessibilityRenderObject::addRemoteSVGChildren):
- accessibility/AccessibilityRenderObject.h:
May 25, 2016:
- 11:50 PM Changeset in webkit [201416] by
-
- 3 edits in trunk/Source/WebCore
Invalidate style for newly added nodes in Node::insertedInto
https://bugs.webkit.org/show_bug.cgi?id=158088
Reviewed by Darin Adler.
- dom/ContainerNode.cpp:
(WebCore::ContainerNode::parserInsertBefore):
(WebCore::ContainerNode::replaceChild):
(WebCore::ContainerNode::parserAppendChild):
(WebCore::ContainerNode::childrenChanged):
(WebCore::ContainerNode::updateTreeAfterInsertion):
- dom/Node.cpp:
(WebCore::Node::insertedInto):
Consolidate setNeedsStyleRecalc(ReconstructRenderTree) here.
This also now happens earliest possible time, right after inserting the node and can avoid
some unneeded style invalidation work in subclass insertion handlers.
- 10:34 PM Changeset in webkit [201415] by
-
- 4 edits4 adds in trunk
Fix ResourceTiming multiple entries per resource and test initiator
https://bugs.webkit.org/show_bug.cgi?id=158094
Reviewed by Alex Christensen.
Make sure that CachedResource that was needed by two different elements only adds one entry, with the right (first) initiatorType.
Source/WebCore:
Tests: http/tests/performance/performance-resource-timing-initiator-css.html
http/tests/performance/performance-resource-timing-initiator-no-override.html
- loader/ResourceTimingInformation.cpp:
(WebCore::ResourceTimingInformation::addResourceTiming): Don't remove CachedResource when entry is added, but
mark it as added. Only add new entries for non-added resources.
(WebCore::ResourceTimingInformation::storeResourceTimingInitiatorInformation): Initialize initiator info as NotYetAdded.
- loader/ResourceTimingInformation.h:
LayoutTests:
- http/tests/performance/performance-resource-timing-initiator-css.html: Added. Makes sure css has the right initiator type.
- http/tests/performance/performance-resource-timing-initiator-css-expected.txt: Added.
- http/tests/performance/performance-resource-timing-initiator-no-override.html: Added. Makes sure that only one entry is added and
that its initiator info doesn't get overriden.
- http/tests/performance/performance-resource-timing-initiator-no-override-expected.txt: Added.
- 10:33 PM Changeset in webkit [201414] by
-
- 6 edits1 copy1 add in trunk
Fix ResourceTiming XHR flakiness
https://bugs.webkit.org/show_bug.cgi?id=158019
Reviewed by Alex Christensen.
Source/WebCore:
Remove XHR specific ResourceTiming information store and addition as it is not needed.
Test: http/tests/performance/performance-resource-timing-xhr-single-entry.html
- loader/DocumentThreadableLoader.cpp:
(WebCore::DocumentThreadableLoader::loadRequest): Removed XHR-specific initiator info storage.
(WebCore::DocumentThreadableLoader::didFinishLoading): Removed XHR-specific RT entry addition.
- loader/DocumentThreadableLoader.h:
LayoutTests:
Test fixes and additions that make sure XHR tests are not run as part of XHR's onload event, as ResourceTiming entries are added
after it.
- TestExpectations:
- http/tests/performance/performance-resource-timing-cached-entries.html: Avoid running the tests as part of the XHR's load event.
- http/tests/performance/performance-resource-timing-xhr-single-entry-expected.txt: Added.
- http/tests/performance/performance-resource-timing-xhr-single-entry.html: Test that XHR fetch adds a single entry with correct initiatorType.
- 10:31 PM Changeset in webkit [201413] by
-
- 4 edits in trunk
[cmake] Deduplicate make-js-file-arrays usage and make it work on Windows.
https://bugs.webkit.org/show_bug.cgi?id=157997
Reviewed by Alex Christensen.
.:
- Source/cmake/WebKitMacros.cmake: Added MAKE_JS_FILE_ARRAYS macro.
Source/WebCore:
No new tests needed.
- CMakeLists.txt: Use new MAKE_JS_FILE_ARRAYS macro.
- 8:27 PM WebKitGTK/2.12.x edited by
- Update a11y proposed merges to point to new bugs with … (diff)
- 8:19 PM Changeset in webkit [201412] by
-
- 6 edits3 adds in trunk
[JSC] RegExp with deeply nested subexpressions overflow the stack in Yarr
https://bugs.webkit.org/show_bug.cgi?id=158011
rdar://problem/25946592
Reviewed by Saam Barati.
Source/JavaScriptCore:
When generating the meta-data required for compilation,
Yarr uses a recursive function over the various expression in the pattern.
If you have many nested expressions, you can run out of stack
and crash the WebProcess.
This patch changes that into a soft failure. The expression is just
considered invalid.
- runtime/RegExp.cpp:
(JSC::RegExp::finishCreation):
(JSC::RegExp::compile):
(JSC::RegExp::compileMatchOnly):
- yarr/YarrPattern.cpp:
(JSC::Yarr::YarrPatternConstructor::YarrPatternConstructor):
(JSC::Yarr::YarrPatternConstructor::setupOffsets):
(JSC::Yarr::YarrPatternConstructor::isSafeToRecurse):
(JSC::Yarr::YarrPattern::compile):
(JSC::Yarr::YarrPattern::YarrPattern):
(JSC::Yarr::YarrPatternConstructor::setupAlternativeOffsets): Deleted.
(JSC::Yarr::YarrPatternConstructor::setupDisjunctionOffsets): Deleted.
- yarr/YarrPattern.h:
LayoutTests:
- js/script-tests/stack-overflow-arrity-catch.js:
With the new failure, this test can fail on allocating
the RegExp for a valid reason.
The new expression should not have this issue.
- js/script-tests/stack-overflow-regexp.js: Added.
(shouldThrow.recursiveCall):
(shouldThrow):
(recursiveCall):
- js/stack-overflow-regexp-expected.txt: Added.
- js/stack-overflow-regexp.html: Added.
- 5:08 PM Changeset in webkit [201411] by
-
- 2 edits in trunk/LayoutTests
Marking imported/blink/http/tests/plugins/get-url-notify-on-removal.html as a flaky timeout
https://bugs.webkit.org/show_bug.cgi?id=158101
Unreviewed test gardening.
- platform/mac/TestExpectations:
- 4:35 PM Changeset in webkit [201410] by
-
- 2 edits in trunk/Source/WebCore
Use HashMap::add() instead of HashMap::set() in Node::ensureEventTargetData()
https://bugs.webkit.org/show_bug.cgi?id=158092
Reviewed by Ryosuke Niwa.
Use HashMap::add() instead of HashMap::set() in Node::ensureEventTargetData()
as we already checked that the key is not present in the HashMap.
- dom/Node.cpp:
(WebCore::Node::ensureEventTargetData):
- 4:18 PM Changeset in webkit [201409] by
-
- 2 edits in trunk/Source/WebCore
REGRESSION (r191531): Web Inspector: WebSQL databases are no longer shown when first opening Web Inspector
https://bugs.webkit.org/show_bug.cgi?id=158096
<rdar://problem/26454671>
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-05-25
Reviewed by Brian Burg.
- inspector/InspectorInstrumentation.h:
(WebCore::InspectorInstrumentation::didOpenDatabase):
Remove the fast return errantly added in r191531. InspectorDatabaseAgent
wants to track databases, even before a frontend may be open, so that
on first open it can inform the frontend about open databases.
- 4:11 PM Changeset in webkit [201408] by
-
- 3 edits in trunk/Source/WebInspectorUI
Web Inspector: Uncaught Exception: TypeError: undefined is not an object (evaluating 'collectionData.affectedSnapshots')
https://bugs.webkit.org/show_bug.cgi?id=158051
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-05-25
Reviewed by Brian Burg.
- UserInterface/Workers/HeapSnapshot/HeapSnapshot.js:
(HeapSnapshot.prototype.updateDeadNodesAndGatherCollectionData):
- UserInterface/Workers/HeapSnapshot/HeapSnapshotWorker.js:
(HeapSnapshotWorker.prototype.createSnapshot):
If by the time the timeout fires we had cleared our snapshot list, then
updateDeadNodesAndGatherCollectionData could bail. Handle gracefully.
- 4:01 PM Changeset in webkit [201407] by
-
- 3 edits2 adds in trunk
Setting overflow:hidden does not always repaint clipped content.
https://bugs.webkit.org/show_bug.cgi?id=116994
rdar://problem/26476697
Issue repaint for both layout and visual overflow rects when the container starts
clipping overflow content.
Reviewed by David Hyatt.
Source/WebCore:
Test: fast/repaint/overflow-hidden-repaint.html
- rendering/RenderBox.cpp:
(WebCore::RenderBox::updateFromStyle):
LayoutTests:
- fast/repaint/overflow-hidden-repaint-expected.html: Added.
- fast/repaint/overflow-hidden-repaint.html: Added.
- 3:56 PM Changeset in webkit [201406] by
-
- 9 edits2 deletes in trunk
Get rid of WTF/Functional.h
https://bugs.webkit.org/show_bug.cgi?id=158081
Reviewed by Chris Dumez.
Source/WebCore:
- Modules/mediastream/MediaStreamTrack.cpp:
Source/WTF:
This is no longer used, and removing it will free up the name for a new Functional.h implementation.
- WTF.xcodeproj/project.pbxproj:
- wtf/Functional.h: Removed.
(WTF::RefAndDeref::ref): Deleted.
(WTF::RefAndDeref::deref): Deleted.
(WTF::ParamStorageTraits::wrap): Deleted.
(WTF::ParamStorageTraits::unwrap): Deleted.
(WTF::ParamStorageTraits<PassRefPtr<T>>::wrap): Deleted.
(WTF::ParamStorageTraits<PassRefPtr<T>>::unwrap): Deleted.
(WTF::ParamStorageTraits<RefPtr<T>>::wrap): Deleted.
(WTF::ParamStorageTraits<RefPtr<T>>::unwrap): Deleted.
(WTF::ParamStorageTraits<RetainPtr<T>>::wrap): Deleted.
(WTF::ParamStorageTraits<RetainPtr<T>>::unwrap): Deleted.
(WTF::FunctionImplBase::~FunctionImplBase): Deleted.
(WTF::FunctionBase::isNull): Deleted.
(WTF::FunctionBase::FunctionBase): Deleted.
(WTF::FunctionBase::impl): Deleted.
(WTF::bind): Deleted.
- wtf/mac/DeprecatedSymbolsUsedBySafari.mm:
Tools:
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/WTF/Functional.cpp: Removed.
(TestWebKitAPI::returnFortyTwo): Deleted.
(TestWebKitAPI::TEST): Deleted.
(TestWebKitAPI::multiplyByTwo): Deleted.
(TestWebKitAPI::multiplyByOneAndAHalf): Deleted.
(TestWebKitAPI::multiply): Deleted.
(TestWebKitAPI::subtract): Deleted.
(TestWebKitAPI::A::A): Deleted.
(TestWebKitAPI::A::f): Deleted.
(TestWebKitAPI::A::addF): Deleted.
(TestWebKitAPI::B::B): Deleted.
(TestWebKitAPI::B::~B): Deleted.
(TestWebKitAPI::B::ref): Deleted.
(TestWebKitAPI::B::deref): Deleted.
(TestWebKitAPI::B::f): Deleted.
(TestWebKitAPI::B::g): Deleted.
(TestWebKitAPI::Number::create): Deleted.
(TestWebKitAPI::Number::~Number): Deleted.
(TestWebKitAPI::Number::value): Deleted.
(TestWebKitAPI::Number::Number): Deleted.
(TestWebKitAPI::multiplyNumberByTwo): Deleted.
- 3:07 PM Changeset in webkit [201405] by
-
- 4 edits in trunk/Source/WebKit2
Flashiness and jumpiness when entering fullscreen
https://bugs.webkit.org/show_bug.cgi?id=158087
Reviewed by Beth Dakin.
Multiple independant sources of jumpiness and flashiness are addressed here:
- Setting the top content inset on the WKView cause a vertical jump during fullscreen
transition. Instead of setting the content inset to 0, take the existing inset into account
when placing the WKView in the NSWindow.
- The enter fullscreen transition causes a white flash due to the NSWindow needing
display before ordering onscreen. Ensure the window has a backing by calling -displayIfNeeded
before entering fullscreen mode.
- The exit fullscreen transition causes a white background color flash for an unknown
reason, but is solved by not making the window's content view layer-backed. Rather than
directly animating the contentView's background color, create a specific background view
and animate it's background color instead.
- UIProcess/mac/WKFullScreenWindowController.h:
- UIProcess/mac/WKFullScreenWindowController.mm:
(-[WKFullScreenWindowController initWithWindow:webView:page:]):
(-[WKFullScreenWindowController enterFullScreen:]):
(-[WKFullScreenWindowController finishedEnterFullScreenAnimation:]):
(-[WKFullScreenWindowController finishedExitFullScreenAnimation:]):
(-[WKFullScreenWindowController _startEnterFullScreenAnimationWithDuration:]):
(-[WKFullScreenWindowController _startExitFullScreenAnimationWithDuration:]):
- WebProcess/FullScreen/WebFullScreenManager.cpp:
(WebKit::WebFullScreenManager::saveScrollPosition): Deleted.
(WebKit::WebFullScreenManager::restoreScrollPosition): Deleted.
- 2:58 PM Changeset in webkit [201404] by
-
- 22 edits2 adds in trunk
[WebSockets] No infrastructure for testing secure web sockets (wss)
https://bugs.webkit.org/show_bug.cgi?id=157884
<rdar://problem/26477197>
Reviewed by Andy Estes.
Source/WebCore:
Add a new test-only flag used to tell CFNetwork that we do not wish to
validate the SLL certificate chain. This allows us to use self-signed
certificates in test cases.
Tests: http/tests/websocket/tests/hybi/simple-wss.html
- page/Settings.cpp:
(WebCore::Settings::setAllowsAnySSLCertificate): Added.
(WebCore::Settings::allowsAnySSLCertificate): Added. This defaults
to False.
- page/Settings.h:
- platform/network/cf/SocketStreamHandleCFNet.cpp:
(WebCore::SocketStreamHandle::createStreams): When running under our
testing infrastructure, do not require full certificate validation.
- testing/js/WebCoreTestSupport.cpp:
(WebCoreTestSupport::setAllowsAnySSLCertificate): Added.
- testing/js/WebCoreTestSupport.h:
- testing/InternalSettings.cpp:
(WebCore::InternalSettings::setAllowsAnySSLCertificate): Added.
- testing/InternalSettings.h:
Tools:
Add support to webkitpy to start and stop a secure Web Socket server running on port 9323
using the certificate, private-key from file LayoutTests/http/conf/webkit-httpd.pem. Also
teaches run-webkit-httpd to start and stop the Web Socket servers.
Modify DumpRenderTree and WebKitTestRunner to understand a new testRunner method,
'setAllowsAnySSLCertificate', which allows us to use the same self-signed test certificate
we do for our HTTPS tests.
- DumpRenderTree/TestRunner.cpp:
(setAllowsAnySSLCertificateCallback):
(TestRunner::setAllowsAnySSLCertificate):
- DumpRenderTree/TestRunner.h:
- DumpRenderTree/mac/DumpRenderTree.mm:
(resetWebViewToConsistentStateBeforeTesting): Make sure we turn off the new flag between tests.
- Scripts/run-webkit-httpd:
(main): Start the websocket server at launch.
- Scripts/webkitpy/layout_tests/controllers/manager.py:
(Manager.init): Remove dead code.
- Scripts/webkitpy/layout_tests/servers/websocket_server.py:
(PyWebSocket.init): Cleanup code.
(PyWebSocket): Pass '--tls-client-ca' to start command.
(PyWebSocket._prepare_config): Cleanups.
- Scripts/webkitpy/port/base.py:
(Port.to.start_http_server):
(Port.to):
(Port.to._extract_certificate_from_pem): Added.
(Port.to._extract_private_key_from_pem): Added.
(Port.to.start_websocket_server): Start secure socket server.
(Port.to.stop_websocket_server): Stop secure socket server.
- WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl: Add new API.
- WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
(WTR::InjectedBundle::setAllowsAnySSLCertificate): Added.
- WebKitTestRunner/InjectedBundle/InjectedBundle.h:
- WebKitTestRunner/InjectedBundle/TestRunner.cpp:
(WTR::TestRunner::setAllowsAnySSLCertificate): Added.
- WebKitTestRunner/InjectedBundle/TestRunner.h:
LayoutTests:
- http/tests/websocket/tests/hybi/simple-wss-expected.txt: Added.
- http/tests/websocket/tests/hybi/simple-wss.html: Added.
- 2:57 PM Changeset in webkit [201403] by
-
- 2 edits in trunk/Source/WebCore
CRASH at WebCore::WebPlaybackSessionModelMediaElement::selectAudioMediaOption() + 104
https://bugs.webkit.org/show_bug.cgi?id=158090
<rdar://problem/26388936>
Reviewed by Eric Carlson.
Null-check m_mediaElement before using.
- platform/cocoa/WebPlaybackSessionModelMediaElement.mm:
(WebPlaybackSessionModelMediaElement::selectAudioMediaOption):
(WebPlaybackSessionModelMediaElement::selectLegibleMediaOption):
- 2:19 PM Changeset in webkit [201402] by
-
- 2 edits in trunk/Source/WebCore
Race condition calling back to an IDBOpenDBRequest during WorkerThread shutdown.
https://bugs.webkit.org/show_bug.cgi?id=158089
Reviewed by Alex Christensen.
No new tests (Only seen randomly under GuardMalloc).
Crash was seen once running under GuardMalloc. The error is obvious.
- Modules/indexeddb/client/IDBConnectionProxy.cpp:
(WebCore::IDBClient::IDBConnectionProxy::completeOpenDBRequest): Don't get a raw pointer out of the map.
Instead store off as a RefPtr, as the map might be cleared out from the worker thread.
- 2:13 PM Changeset in webkit [201401] by
-
- 5 edits in trunk/Source/WebCore
Simplify and inline minimumValueForLength()
https://bugs.webkit.org/show_bug.cgi?id=158084
Reviewed by Zalan Bujtas.
Simplify and inline minimumValueForLength(). Based on iOS PLT profiles,
we spend up to 0.7% of CPU time during page loads in this function.
The roundPercentages parameter has been dropped because it was false
for all call sites.
- css/LengthFunctions.cpp:
(WebCore::minimumIntValueForLength): Deleted.
(WebCore::minimumValueForLength): Deleted.
- css/LengthFunctions.h:
(WebCore::minimumValueForLength):
(WebCore::minimumIntValueForLength):
- rendering/RenderBoxModelObject.cpp:
(WebCore::resolveEdgeRelativeLength):
(WebCore::RenderBoxModelObject::calculateBackgroundImageGeometry):
- rendering/RenderElement.h:
(WebCore::RenderElement::minimumValueForLength):
- 2:02 PM Changeset in webkit [201400] by
-
- 2 edits in trunk/LayoutTests
Marking http/tests/css/shared-stylesheet-mutation.html as flaky
https://bugs.webkit.org/show_bug.cgi?id=158085
Unreviewed test gardening.
- 12:52 PM Changeset in webkit [201399] by
-
- 6 edits in trunk
[css-grid] Update <fixed-size> syntax
https://bugs.webkit.org/show_bug.cgi?id=158063
Reviewed by Darin Adler.
Source/WebCore:
The syntax for <fixed-size> has been updated on the spec:
https://drafts.csswg.org/css-grid/#typedef-fixed-size
New syntax is:
<fixed-size> =
<fixed-breadth> |
minmax( <fixed-breadth> , <track-breadth> ) |
minmax( <inflexible-breadth> , <fixed-breadth> )
This means that it's enough to have one <fixed-breadth>,
it doesn't matter if it's as minimum or maximum.
Before it was required that the minimum was fixed.
- css/CSSParser.cpp:
(WebCore::isGridTrackFixedSized):
- rendering/RenderGrid.cpp:
(WebCore::RenderGrid::computeAutoRepeatTracksCount):
LayoutTests:
Updated test to check the new expected behavior.
- fast/css-grid-layout/grid-element-auto-repeat-get-set-expected.txt:
- fast/css-grid-layout/grid-element-auto-repeat-get-set.html:
- 12:49 PM Changeset in webkit [201398] by
-
- 6 edits in trunk/Source
Fix CMake build.
- PlatformMac.cmake:
Source/WebCore:
c++14 is needed since r201255.
ColorSync (in ApplicationServices) is needed since r201065.
- 12:41 PM Changeset in webkit [201397] by
-
- 11 edits3 adds in trunk
Swap search field's cancel and result button for RTL content.
https://bugs.webkit.org/show_bug.cgi?id=158007
Reviewed by Dean Jackson.
Source/WebCore:
Test: fast/forms/search-input-rtl.html
- css/html.css:
(input[type="search"]::-webkit-textfield-decoration-container): Deleted.
- rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::paintSearchFieldCancelButton):
(WebCore::RenderThemeMac::paintSearchFieldResultsButton):
LayoutTests:
- fast/forms/resources/common.js:
(searchCancelButtonPositionRTL):
(searchCancelButtonPosition):
- fast/forms/search-input-rtl.html: Added.
- fast/forms/search-rtl.html:
- platform/ios-simulator-wk2/fast/forms/search-rtl-expected.txt:
- platform/ios-simulator/fast/css/text-overflow-input-expected.txt:
- platform/ios-simulator/fast/forms/search-input-rtl-expected.txt: Added.
- platform/mac/fast/css/text-overflow-input-expected.txt:
- platform/mac/fast/forms/placeholder-position-expected.txt:
- platform/mac/fast/forms/search-input-rtl-expected.png: Added.
- platform/mac/fast/forms/search-input-rtl-expected.txt: Added.
- platform/mac/fast/forms/search-rtl-expected.txt:
- 12:39 PM Changeset in webkit [201396] by
-
- 2 edits in trunk
[css-grid] Turn on ENABLE_CSS_GRID_LAYOUT by default
https://bugs.webkit.org/show_bug.cgi?id=158060
Reviewed by Darin Adler.
The runtime flag is disabled by default,
but we want to build CSS Grid Layout by default.
Otherwise the runtime flag would be useless.
- Source/cmake/WebKitFeatures.cmake:
- 12:17 PM Changeset in webkit [201395] by
-
- 5 edits in trunk/Source/WebKit2
Simplify a few lambda captures in the network cache code
https://bugs.webkit.org/show_bug.cgi?id=158076
Reviewed by Antti Koivisto.
Simplify a few lambda captures in the network cache code by WTFMoving
upon capture.
- NetworkProcess/cache/NetworkCacheSpeculativeLoadManager.cpp:
(WebKit::NetworkCache::SpeculativeLoadManager::retrieve):
(WebKit::NetworkCache::SpeculativeLoadManager::retrieveEntryFromStorage):
(WebKit::NetworkCache::SpeculativeLoadManager::retrieveSubresourcesEntry):
- NetworkProcess/cache/NetworkCacheSpeculativeLoadManager.h:
- NetworkProcess/cache/NetworkCacheStatistics.cpp:
(WebKit::NetworkCache::Statistics::bootstrapFromNetworkCache):
(WebKit::NetworkCache::Statistics::recordNotUsingCacheForRequest):
(WebKit::NetworkCache::Statistics::recordRetrievalFailure):
(WebKit::NetworkCache::Statistics::writeTimerFired):
(WebKit::NetworkCache::Statistics::addHashesToDatabase):
(WebKit::NetworkCache::Statistics::addStoreDecisionsToDatabase):
- NetworkProcess/cache/NetworkCacheStatistics.h:
- 12:08 PM Changeset in webkit [201394] by
-
- 5 edits2 adds in trunk
[Font Loading] ASSERT if calling FontFace.loaded twice with a garbage collection between them
https://bugs.webkit.org/show_bug.cgi?id=158015
Reviewed by Darin Adler.
Source/WebCore:
The following scenario may occur:
- We create a FontFace object
- We create an associated JSFontFace object
- We start loading the FontFace, which causes an extra ref to hang around until loading finishes
- Javascript calls the "loaded" attribute on the FontFace, which saves a promise inside the FontFace
- The FontFace goes out of scope in Javascript
- A garbage collection occurs, causing us to delete the JSFontFace object
- Javascript then encounters the FontFace object without first going through a reference to a JSFontFace.
It can do this via iterating through a FontFaceSet. We respond to this situation by creating a new
JSFontFace object and associating it with the existing FontFace.
- Javascript calls the "loaded" attribute
In this situation, the newer JSFontFace object is out of sync with the older FontFace object. In
particular, the FontFace has a saved promise, but the JSFontFace doesn't know about it. Therefore,
the JSFontFace should be flexible to the presence of this member.
Test: fast/text/font-face-crash-2.html
- bindings/js/JSDOMPromise.h:
(WebCore::DOMPromise::deferredWrapper):
- bindings/js/JSFontFaceCustom.cpp:
(WebCore::JSFontFace::loaded):
- css/FontFace.h:
LayoutTests:
- fast/text/font-face-crash-2-expected.txt: Added.
- fast/text/font-face-crash-2.html: Added.
- 12:04 PM Changeset in webkit [201393] by
-
- 4 edits2 adds in trunk
Source/WebCore:
Shadow DOM: RenderTreePosition miscomputed when display:contents value changes
https://bugs.webkit.org/show_bug.cgi?id=158072
rdar://problem/25766333
Reviewed by Darin Adler.
Test: fast/shadow-dom/slot-crash.html
- style/RenderTreePosition.h:
(WebCore::RenderTreePosition::invalidateNextSibling):
Add unconditional invalidation function.
- style/RenderTreeUpdater.cpp:
(WebCore::RenderTreeUpdater::updateElementRenderer):
With display:contents rendering siblings may be found from the subtree and the existing cached
position may become invalid.
If the display:contents value changes invalidate the current render tree position.
LayoutTests:
Shadow DOM: RenderTreePosition should determine if element has display:contents from new style
https://bugs.webkit.org/show_bug.cgi?id=158072
Reviewed by Darin Adler.
- fast/shadow-dom/slot-crash.html: Added.
- 12:01 PM WebKitGTK/2.12.x edited by
- (diff)
- 12:00 PM WebKitGTK/2.12.x edited by
- (diff)
- 11:59 AM Changeset in webkit [201392] by
-
- 2 edits in trunk/Source/JavaScriptCore
Fix Win64 build after r201335
https://bugs.webkit.org/show_bug.cgi?id=158078
Reviewed by Mark Lam.
- offlineasm/x86.rb:
Add intel implementations for loadbs and loadhs
- 11:31 AM Changeset in webkit [201391] by
-
- 2 edits in trunk/Tools
run-jsc-benchmarks should use the new JSBench rather than look for it in the config file.
https://bugs.webkit.org/show_bug.cgi?id=158077
Reviewed by Mark Lam.
Since we didn't have JSBench in the tree before we needed to lookup the path to it from
benchmark config file. That's no longer the case so we should just fix it in the script.
- Scripts/run-jsc-benchmarks:
- 11:20 AM Changeset in webkit [201390] by
-
- 6 edits in trunk/Source/WebCore
Modern IDB: IDB objects from a worker thread might be destroyed on the main thread.
https://bugs.webkit.org/show_bug.cgi?id=158004
Reviewed by Alex Christensen.
No new tests (Spuriously reproduces on the bots, but I've been unable to construct a reliable test).
- Modules/indexeddb/client/IDBConnectionProxy.cpp:
(WebCore::IDBClient::IDBConnectionProxy::completeOpenDBRequest):
(WebCore::IDBClient::IDBConnectionProxy::notifyOpenDBRequestBlocked):
(WebCore::IDBClient::IDBConnectionProxy::didCommitTransaction):
(WebCore::IDBClient::IDBConnectionProxy::didAbortTransaction):
(WebCore::IDBClient::IDBConnectionProxy::unregisterDatabaseConnection):
(WebCore::IDBClient::removeItemsMatchingCurrentThread):
(WebCore::IDBClient::IDBConnectionProxy::forgetActivityForCurrentThread): Clear out all objects that originated on this thread.
(WebCore::IDBClient::IDBConnectionProxy::takeIDBOpenDBRequest): Deleted.
- Modules/indexeddb/client/IDBConnectionProxy.h:
- workers/WorkerGlobalScope.cpp:
(WebCore::WorkerGlobalScope::stopIndexedDatabase):
- workers/WorkerGlobalScope.h:
- workers/WorkerThread.cpp:
(WebCore::WorkerThread::stop):
- 11:02 AM Changeset in webkit [201389] by
-
- 5 edits in trunk/Source
Versioning.
- 10:37 AM Changeset in webkit [201388] by
-
- 1 copy in tags/Safari-602.1.34
New tag.
- 9:43 AM Changeset in webkit [201387] by
-
- 14 edits in trunk/Source/WebCore
Remove unused slotBase parameter in bindings generator
https://bugs.webkit.org/show_bug.cgi?id=158068
Patch by Nael Ouedraogo <nael.ouedraogo@crf.canon.fr> on 2016-05-25
Reviewed by Darin Adler.
Remove unused slotBase parameter from attribute Getter functions.
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateImplementation):
- bindings/scripts/test/JS/JSTestActiveDOMObject.cpp:
- bindings/scripts/test/JS/JSTestEventConstructor.cpp:
- bindings/scripts/test/JS/JSTestException.cpp:
- bindings/scripts/test/JS/JSTestGlobalObject.cpp:
- bindings/scripts/test/JS/JSTestInterface.cpp:
- bindings/scripts/test/JS/JSTestJSBuiltinConstructor.cpp:
- bindings/scripts/test/JS/JSTestNode.cpp:
- bindings/scripts/test/JS/JSTestNondeterministic.cpp:
- bindings/scripts/test/JS/JSTestObj.cpp:
- bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:
- bindings/scripts/test/JS/JSTestTypedefs.cpp:
- bindings/scripts/test/JS/JSattribute.cpp:
- 9:39 AM Changeset in webkit [201386] by
-
- 4 edits in trunk/Source/WebCore
Include fewer headers from headers
https://bugs.webkit.org/show_bug.cgi?id=158043
Patch by Alex Christensen <achristensen@webkit.org> on 2016-05-25
Reviewed by Brady Eidson.
- platform/graphics/GraphicsContext.h:
- rendering/svg/RenderSVGResourceClipper.h:
(isType):
- rendering/svg/RenderSVGResourceMasker.h:
- 9:19 AM Changeset in webkit [201385] by
-
- 2 edits in trunk/Source/WebCore
ASSERT in WebCore::TextTrackList::remove when running media/track/track-remove-track.html
https://bugs.webkit.org/show_bug.cgi?id=158071
<rdar://problem/26432041>
Reviewed by Chris Dumez.
No new tests, this prevents media/track/track-remove-track.html from crashing.
- html/track/TextTrackList.cpp:
(TextTrackList::remove): Don't assert when the media element has been set to null.
- 9:01 AM Changeset in webkit [201384] by
-
- 2 edits in trunk/Source/WebCore
Addressing post-review comments on r200971.
Reviewed by Darin Adler.
- page/EventHandler.cpp:
(WebCore::EventHandler::hitTestResultAtPoint):
- 8:23 AM Changeset in webkit [201383] by
-
- 2 edits in trunk/Source/JavaScriptCore
REGRESSION(r201066): [GTK] Several intl tests started to fail in GTK+ bot after r201066
https://bugs.webkit.org/show_bug.cgi?id=158066
Reviewed by Darin Adler.
run-javascriptcore-tests does $ENV{LANG}="en_US.UTF-8"; but we are not actually honoring the environment
variables at all when using jsc binary. We are using setlocale() with a nullptr locale to get the current one, but
the current one is always "C", because to set the locale according to the environment variables we need to call
setlocale with an empty string as locale. That's done by gtk_init(), which is called by all our binaries (web
process, network process, etc.), but not by jsc (because jsc doesn't depend on GTK+). The reason why it has
always worked for EFL is because they call ecore_init() in jsc that calls setlocale.
- jsc.cpp:
(main): Call setlocale(LC_ALL, "") on GTK+.
- 7:44 AM Changeset in webkit [201382] by
-
- 3 edits in trunk/Source/WebCore
[css-grid] Simplify grid track sizes parsing
https://bugs.webkit.org/show_bug.cgi?id=158021
Reviewed by Sergio Villar Senin.
Previously once we saw an auto-repeat function,
we passed the "FixedSizeOnly" restriction to the rest of methods.
That way we were sure that all the tracks after the auto-repeat
had fixed sizes.
But we needed to call allTracksAreFixedSized() to be sure that
the tracks before the auto-repeat had fixed sizes too.
Now we're introducing a new boolean |allTracksAreFixedSized|,
to check in advance if the declaration contains any track not fixed.
If that's the case and we found an auto-repeat method,
we consider it invalid.
With this approach we avoid the loop to verify
that all the tracks (before and after the auto-repeat) are fixed.
It also allows us to simplify the code and avoid passing
the restriction to all the methods parsing the track size.
No new tests, no change of behavior.
- css/CSSParser.cpp:
(WebCore::isGridTrackFixedSized): New method to check if a grid track
size is fixed or not (based on old allTracksAreFixedSized()).
(WebCore::CSSParser::parseGridTrackList): Add new boolean to detect
if any track has not a fixed size.
(WebCore::CSSParser::parseGridTrackRepeatFunction): Ditto.
(WebCore::CSSParser::parseGridTrackSize): Remove usage of
TrackSizeRestriction enum.
Check here if |minTrackBreadth| is a flexible size.
(WebCore::CSSParser::parseGridBreadth): Remove usage of
TrackSizeRestriction enum.
(WebCore::allTracksAreFixedSized): Deleted.
- css/CSSParser.h: Remove TrackSizeRestriction enum and update headers.
- 6:18 AM Changeset in webkit [201381] by
-
- 3 edits in trunk/Source/WebKit2
[Unix] Potential buffer overrun of m_fileDescriptors in readBytesFromSocket of ConnectionUnix.cpp
https://bugs.webkit.org/show_bug.cgi?id=158058
Patch by Fujii Hironori <Fujii Hironori> on 2016-05-25
Reviewed by Carlos Garcia Campos.
Memcpy does not check the boundary of m_fileDescriptors in
readBytesFromSocket of ConnectionUnix.cpp. This is not a problem
in normal cases, but in the case when Web process is hijacked and
malicious IPC packets were sent. WTF::Vector already has two
members m_capacity and m_size. There is no need to have a
separate member m_fileDescriptorsSize to remember the number of
remaining data.
- Platform/IPC/Connection.h: Remove members m_readBufferSize and
m_fileDescriptorsSize.
- Platform/IPC/unix/ConnectionUnix.cpp:
(IPC::Connection::platformInitialize): Removed initialization of
m_readBufferSize and m_fileDescriptorsSize. Reserve initial
capacity for m_readBuffer and m_fileDescriptors.
(IPC::Connection::processMessage): Replace m_readBufferSize and
m_fileDescriptorsSize with m_readBuffer.size() and
m_fileDescriptors.size(). Use Vector::shrink() to reset the
number of remaining data in the buffers.
(IPC::readBytesFromSocket) : Change argument types to WTF::Vector
instead of pointers and sizes.
(IPC::Connection::readyReadHandler): Call new readBytesFromSocket
- 6:03 AM Changeset in webkit [201380] by
-
- 2 edits in trunk/Source/JavaScriptCore
[ARM] Fix the Wcast-align warning in LinkBuffer.cpp
https://bugs.webkit.org/show_bug.cgi?id=157889
Reviewed by Darin Adler.
- assembler/LinkBuffer.cpp:
(JSC::recordLinkOffsets):
- 4:32 AM Changeset in webkit [201379] by
-
- 3 edits in trunk/Source/WebCore
[css-grid] Refactor populateGridPositions()
https://bugs.webkit.org/show_bug.cgi?id=158065
Reviewed by Carlos Garcia Campos.
RenderGrid::populateGridPositions() was doing exactly the same thing for columns and rows
but using different data structures. That lead to a lot of duplicated code. It's easy to
refactor it in a new function that properly select the data structures to operate on based
on the direction.
No new tests as there is no change in behaviour.
- rendering/RenderGrid.cpp:
(WebCore::RenderGrid::layoutGridItems):
(WebCore::RenderGrid::populateGridPositionsForDirection): Refactored from
populateGridPositions().
(WebCore::RenderGrid::populateGridPositions): Deleted.
- rendering/RenderGrid.h:
- 4:17 AM Changeset in webkit [201378] by
-
- 3 edits in trunk/Source/WebCore
Unreviewed, rolling out r201373.
https://bugs.webkit.org/show_bug.cgi?id=158064
Several tests are hitting the ASSERT (Requested by rego on
#webkit).
Reverted changeset:
"[css-grid] Simplify grid track sizes parsing"
https://bugs.webkit.org/show_bug.cgi?id=158021
http://trac.webkit.org/changeset/201373
- 4:13 AM Changeset in webkit [201377] by
-
- 3 edits in trunk/Source/WebCore
Purge PassRefPtr from TouchList
https://bugs.webkit.org/show_bug.cgi?id=157985
Patch by Nael Ouedraogo <nael.ouedraogo@crf.canon.fr> on 2016-05-25
Reviewed by Darin Adler.
Use RefPtr&& argument instead of PassRefPtr in append()
- dom/TouchList.h:
(WebCore::TouchList::append):
- page/EventHandler.cpp:
(WebCore::EventHandler::handleTouchEvent):
- 3:59 AM Changeset in webkit [201376] by
-
- 3 edits in trunk/Source/WebKit2
Update constructRevalidationRequest() to stop returning a unique_ptr<ResourceRequest>
https://bugs.webkit.org/show_bug.cgi?id=158046
Reviewed by Darin Adler.
Update constructRevalidationRequest() to stop returning a unique_ptr<ResourceRequest>
and to return a ResourceRequest instead. There is no reason for it to return a
pointer.
- NetworkProcess/cache/NetworkCacheSpeculativeLoadManager.cpp:
(WebKit::NetworkCache::constructRevalidationRequest):
(WebKit::NetworkCache::SpeculativeLoadManager::PreloadedEntry::PreloadedEntry):
(WebKit::NetworkCache::SpeculativeLoadManager::PreloadedEntry::revalidationRequest):
(WebKit::NetworkCache::SpeculativeLoadManager::addPreloadedEntry):
(WebKit::NetworkCache::SpeculativeLoadManager::revalidateEntry):
- NetworkProcess/cache/NetworkCacheSpeculativeLoadManager.h:
- 3:58 AM Changeset in webkit [201375] by
-
- 2 edits in trunk/LayoutTests
Update dom/Window/messageevent-source-postmessage-reified.html after r201315
https://bugs.webkit.org/show_bug.cgi?id=158048
Reviewed by Darin Adler.
We need to delete a property that is part of the Window's static table
now in order to force the reification.
- fast/dom/Window/messageevent-source-postmessage-reified.html:
- 2:49 AM Changeset in webkit [201374] by
-
- 5 edits4 adds in trunk
Elements with backdrop-filter cannot be clipped with clip-path or mask
https://bugs.webkit.org/show_bug.cgi?id=142662
<rdar://problem/20150192>
Patch by Antoine Quint <Antoine Quint> on 2016-05-25
Reviewed by Dean Jackson.
Source/WebCore:
We used to only apply the mask to the layer contents but did not account
for the fact that a layer backdrop may exist. We now correctly mask the
backdrop layer as well as the layer contents.
Test: css3/filters/backdrop/backdrop-filter-with-clip-path.html
- platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::updateShape):
Ensure clones of a layer use the same shape path.
(WebCore::GraphicsLayerCA::updateMaskLayer):
If we have a backdrop layer, ensure that we apply a clone of the mask layer applied to
the layer contents.
Source/WebKit2:
Ensure layer clones are set up with the same shape path as their original layer.
- WebProcess/WebPage/mac/PlatformCALayerRemote.cpp:
(WebKit::PlatformCALayerRemote::updateClonedLayerProperties):
LayoutTests:
New test that checks that applying a backdrop-filter and a clip-path on a single
element has the same effect as applying a clip-path on a parent of a child with
a backdrop-filter.
- css3/filters/backdrop/backdrop-filter-with-clip-path-expected.txt: Added.
- css3/filters/backdrop/backdrop-filter-with-clip-path.html: Added.
- platform/ios-simulator/css3/filters/backdrop/backdrop-filter-with-clip-path-expected.html: Added.
- platform/mac/css3/filters/backdrop/backdrop-filter-with-clip-path-expected.png: Added.
- 2:22 AM Changeset in webkit [201373] by
-
- 3 edits in trunk/Source/WebCore
[css-grid] Simplify grid track sizes parsing
https://bugs.webkit.org/show_bug.cgi?id=158021
Reviewed by Sergio Villar Senin.
Previously once we saw an auto-repeat function,
we passed the "FixedSizeOnly" restriction to the rest of methods.
That way we were sure that all the tracks after the auto-repeat
had fixed sizes.
But we needed to call allTracksAreFixedSized() to be sure that
the tracks before the auto-repeat had fixed sizes too.
Now we're introducing a new boolean |allTracksAreFixedSized|,
to check in advance if the declaration contains any track not fixed.
If that's the case and we found an auto-repeat method,
we consider it invalid.
With this approach we avoid the loop to verify
that all the tracks (before and after the auto-repeat) are fixed.
It also allows us to simplify the code and avoid passing
the restriction to all the methods parsing the track size.
No new tests, no change of behavior.
- css/CSSParser.cpp:
(WebCore::isGridTrackFixedSized): New method to check if a grid track
size is fixed or not (based on old allTracksAreFixedSized()).
(WebCore::CSSParser::parseGridTrackList): Add new boolean to detect
if any track has not a fixed size.
(WebCore::CSSParser::parseGridTrackRepeatFunction): Ditto.
(WebCore::CSSParser::parseGridTrackSize): Remove usage of
TrackSizeRestriction enum.
Check here if |minTrackBreadth| is a flexible size.
(WebCore::CSSParser::parseGridBreadth): Remove usage of
TrackSizeRestriction enum.
(WebCore::allTracksAreFixedSized): Deleted.
- css/CSSParser.h: Remove TrackSizeRestriction enum and update headers.
- 2:05 AM Changeset in webkit [201372] by
-
- 2 edits in trunk/PerformanceTests
Unreviewed, add JSBench to the skipped list for now since it doesn't
work currently.
- Skipped:
May 24, 2016:
- 10:18 PM Changeset in webkit [201371] by
-
- 3 edits in trunk/Source/WebKit2
Simplify a couple of lambda captures in the network cache code
https://bugs.webkit.org/show_bug.cgi?id=158053
Reviewed by Brady Eidson.
- NetworkProcess/cache/NetworkCacheSpeculativeLoadManager.cpp:
(WebKit::NetworkCache::SpeculativeLoadManager::preloadEntry):
Just capture subResourceInfo instead of allocating a new copy
on the heap. There is no reason we cannot simply capture
subResourceInfo here.
- NetworkProcess/cache/NetworkCacheStorage.cpp:
(WebKit::NetworkCache::Storage::clear):
Use new C++14 capture with initialization to make the code a
bit nicer.
- 6:21 PM Changeset in webkit [201370] by
-
- 3 edits in trunk/Tools
Reorganize dashboard code: move code from _timeIntervalString to base class
https://bugs.webkit.org/show_bug.cgi?id=158047
rdar://problem/26457274
Reviewed by Alexey Proskuryakov and Dean Johnson.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueView.js:
(BubbleQueueView.prototype._timeIntervalString): Moved core logic to base class so as to make it re-usable.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/QueueView.js:
(QueueView.prototype._readableTimeString): Same.
- 5:55 PM Changeset in webkit [201369] by
-
- 1 copy in tags/Safari-602.1.32.5.1
New tag.
- 5:54 PM Changeset in webkit [201368] by
-
- 1 copy in tags/Safari-602.1.32.6
New tag.
- 5:54 PM Changeset in webkit [201367] by
-
- 1 copy in tags/Safari-601.7.4
New tag.
- 5:46 PM Changeset in webkit [201366] by
-
- 3 edits in trunk/Source/WebKit2
_WKThumbnailView should expose its snapshot size
https://bugs.webkit.org/show_bug.cgi?id=158049
Reviewed by Tim Horton.
- UIProcess/API/Cocoa/_WKThumbnailView.h:
- UIProcess/API/Cocoa/_WKThumbnailView.mm:
(-[_WKThumbnailView _didTakeSnapshot:]):
Update the new snapshotSize property in a KVO-compliant manner.
- 5:45 PM Changeset in webkit [201365] by
-
- 2 edits in trunk/Tools
[JSC][GTK][EFL] Allow run-jsc-benchmark to use WebKitTestRunner in EFL / GTK ports
https://bugs.webkit.org/show_bug.cgi?id=158016
Reviewed by Darin Adler.
This patch easily allows run-jsc-benchmark to run WebKitTestRunner-based tests in GTK / EFL ports.
This change encourages us to run tests with the browser-heap in nix environments.
Two things are modified.
- Add a fall-back to look up the library path in GTK / EFL / JSCOnly environment.
In GTK / EFL / JSCOnly ports, the hierarchy of the build directory is slightly different from Apple port.
For example, the jsc bin locate at "WebKitBuild/XXX/Release/bin/jsc" and the lib path is "WebKitBuild/XXX/Release/lib"
while the one of Apple port is "WebKitBuild/XXX/Release/jsc" and "WebKitBuild/XXX/Release/lib".
And based on this library path, we configure the required environment variables to run WebKitTestRunner in GTK / EFL ports.
- Add --dependencies option to add dependent library paths.
While Apple ports does not require any additional dependent library path, GTK and EFL ports require this path,
typically WebKitBuild/DependenciesGTK and WebKitBuild/DependenciesEFL respectively. So we need to add such paths to LD_LIBRARY_PATH.
Instead of adding platform options like --gtk / --efl, we add --dependencies option to add the additional dependent library paths.
The platform options still require the build path to look up the dependent library directory. So we pass it directly through --dependencies.
Multiple additional dependent library paths can be added by using --dependencies multiple times.
By using these change, we can run benchmarks that require WebKitTestRunner in GTK / EFL ports (If you would like to run them in a headless manner, you can use xvbuf.).
Example:
Tools/Scripts/run-jsc-benchmarks baseline:WebKitBuild/baseline/Release/bin/WebKitTestRunner patched:WebKitBuild/patched/Release/bin/WebKitTestRunner --dependencies WebKitBuild/DependenciesGTK/Root/lib --js-bench
- Scripts/run-jsc-benchmarks:
- 5:12 PM Changeset in webkit [201364] by
-
- 3 edits in trunk/Source/JavaScriptCore
TypedArray.prototype.slice should not throw if no arguments are provided
https://bugs.webkit.org/show_bug.cgi?id=158044
<rdar://problem/26433280>
Reviewed by Geoffrey Garen.
We were throwing an exception if the TypedArray.prototype.slice function
was not provided arguments. This was wrong. Instead we should just assume
the first argument was 0.
- runtime/JSGenericTypedArrayViewPrototypeFunctions.h:
(JSC::genericTypedArrayViewProtoFuncSlice): Deleted.
- tests/stress/typedarray-slice.js:
- 4:49 PM Changeset in webkit [201363] by
-
- 21 edits3 adds in trunk/Source
LLInt should be able to cache prototype loads for values in GetById
https://bugs.webkit.org/show_bug.cgi?id=158032
Reviewed by Filip Pizlo.
Source/JavaScriptCore:
This patch adds prototype value caching to the LLInt for op_get_by_id.
Two previously unused words in the op_get_by_id bytecode have been
repurposed to hold extra information for the cache. The first is a
counter that records the number of get_by_ids that hit a cacheable value
on a prototype. When the counter is decremented from one to zero we
attempt to cache the prototype load, which will be discussed further
below. The second word is used to hold the prototype object when we have
started caching.
When the counter is decremented to zero we first attempt to generate and
watch the property conditions needed to ensure the validity of prototype
load. If the watchpoints are successfully created and installed we
replace the op_get_by_id opcode with the new op_get_by_id_proto_load
opcode, which tells the LLInt to use the cache prototype object for the
load rather than the base value.
Prior to this patch there was not LLInt specific data onCodeBlocks.
Since the CodeBlock needs to own the Watchpoints for the cache, a weak
map from each base structure to a bag of Watchpoints created for that
structure by some op_get_by_id has been added to the CodeBlock. During
GC, if we find that the a structure in the map has not been marked we
free the associated bag on the CodeBlock.
- JavaScriptCore.xcodeproj/project.pbxproj:
- bytecode/BytecodeList.json:
- bytecode/BytecodeUseDef.h:
(JSC::computeUsesForBytecodeOffset):
(JSC::computeDefsForBytecodeOffset):
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::printGetByIdOp):
(JSC::CodeBlock::printGetByIdCacheStatus):
(JSC::CodeBlock::dumpBytecode):
(JSC::CodeBlock::finalizeLLIntInlineCaches):
- bytecode/CodeBlock.h:
(JSC::CodeBlock::llintGetByIdWatchpointMap):
(JSC::clearLLIntGetByIdCache):
- bytecode/GetByIdStatus.cpp:
(JSC::GetByIdStatus::computeFromLLInt):
- bytecode/LLIntPrototypeLoadAdaptiveStructureWatchpoint.cpp: Added.
(JSC::LLIntPrototypeLoadAdaptiveStructureWatchpoint::LLIntPrototypeLoadAdaptiveStructureWatchpoint):
(JSC::LLIntPrototypeLoadAdaptiveStructureWatchpoint::install):
(JSC::LLIntPrototypeLoadAdaptiveStructureWatchpoint::fireInternal):
- bytecode/LLIntPrototypeLoadAdaptiveStructureWatchpoint.h: Added.
- bytecode/ObjectPropertyConditionSet.cpp:
(JSC::ObjectPropertyConditionSet::isValidAndWatchable):
- bytecode/ObjectPropertyConditionSet.h:
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::emitGetById):
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
- dfg/DFGCapabilities.cpp:
(JSC::DFG::capabilityLevel):
- jit/JIT.cpp:
(JSC::JIT::privateCompileMainPass):
(JSC::JIT::privateCompileSlowCases):
- llint/LLIntSlowPaths.cpp:
(JSC::LLInt::setupGetByIdPrototypeCache):
(JSC::LLInt::LLINT_SLOW_PATH_DECL):
- llint/LLIntSlowPaths.h:
- llint/LowLevelInterpreter32_64.asm:
- llint/LowLevelInterpreter64.asm:
- runtime/Options.h:
- tests/stress/llint-get-by-id-cache-prototype-load-from-dictionary.js: Added.
(test):
Source/WTF:
Add move constructors/initializers to Bags.
- wtf/Bag.h:
(WTF::Bag::Bag):
(WTF::Bag::operator=):
- 4:09 PM Changeset in webkit [201362] by
-
- 5 adds in branches/safari-601-branch/LayoutTests/imported/blink
Merge missing layout test. rdar://problem/26228555
- 4:03 PM Changeset in webkit [201361] by
-
- 6 edits in trunk/Source/JavaScriptCore
We should be able to use the sampling profiler with DRT/WTR.
https://bugs.webkit.org/show_bug.cgi?id=158041
Reviewed by Saam Barati.
This patch makes the sampling profiler use a new option, samplingProfilerPath, which
specifies the path to a directory to output sampling profiler data when the program
terminates or the VM is destroyed. Additionally, it fixes some other issues with the
bytecode profiler that would cause crashes on debug builds.
- profiler/ProfilerDatabase.cpp:
(JSC::Profiler::Database::ensureBytecodesFor):
(JSC::Profiler::Database::performAtExitSave):
- runtime/Options.h:
- runtime/SamplingProfiler.cpp:
(JSC::SamplingProfiler::registerForReportAtExit):
(JSC::SamplingProfiler::reportDataToOptionFile):
(JSC::SamplingProfiler::reportTopFunctions):
(JSC::SamplingProfiler::reportTopBytecodes):
- runtime/SamplingProfiler.h:
- runtime/VM.cpp:
(JSC::VM::VM):
(JSC::VM::~VM):
- 4:02 PM Changeset in webkit [201360] by
-
- 4 edits in trunk/Source/WebKit/mac
Candidates should work with input methods
https://bugs.webkit.org/show_bug.cgi?id=158042
-and corresponding-
rdar://problem/26205228
Reviewed by Tim Horton.
- WebView/WebHTMLView.mm:
- WebView/WebView.mm:
(-[WebView candidateList]):
- WebView/WebViewInternal.h:
- 3:28 PM Changeset in webkit [201359] by
-
- 3 edits in trunk/Source/JavaScriptCore
We can cache lookups to JSScope::abstractResolve inside CodeBlock::finishCreation
https://bugs.webkit.org/show_bug.cgi?id=158036
Reviewed by Geoffrey Garen.
This patch implements a 1 item cache for JSScope::abstractResolve. I also tried
implementing the cache as a HashMap, but it seemed either less profitable on some
benchmarks or just as profitable on others. Therefore, it's cleaner to just
use a 1 item cache.
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::CodeBlock):
(JSC::AbstractResolveKey::AbstractResolveKey):
(JSC::AbstractResolveKey::operator==):
(JSC::AbstractResolveKey::isEmptyValue):
(JSC::CodeBlock::finishCreation):
- runtime/GetPutInfo.h:
(JSC::needsVarInjectionChecks):
(JSC::ResolveOp::ResolveOp):
- 3:04 PM Changeset in webkit [201358] by
-
- 3 edits2 adds in trunk
[Font Loading] Crash during font download failure after garbage collection
https://bugs.webkit.org/show_bug.cgi?id=158013
<rdar://problem/25148032>
Reviewed by Darin Adler.
Source/WebCore:
Usually, ownership during font loading is top-down - JavaScript owns a JSFontFace,
which owns a FontFace, which owns a CSSFontFace. However, when we receive the
asynchronous callback that a font finished loading, the call comes in from the
bottom - it is delivered from the CSSFontFaceSource to the CSSFontFace, and then
to the FontFace. If a garbage collection had previously run, we might remove
the last reference to ourself during this asynchronous callback. A simple guard
makes sure this doesn't happen.
Test: fast/text/font-face-crash.html
- css/CSSFontFace.cpp:
(WebCore::CSSFontFace::fontLoaded):
LayoutTests:
- fast/text/font-face-crash-expected.txt: Added.
- fast/text/font-face-crash.html: Added.
- 3:03 PM Changeset in webkit [201357] by
-
- 5 edits4 deletes in trunk
Source/WebCore:
Unreviewed, rolling out r201349.
This change caused compositing tests to assert on iOS
simulator
Reverted changeset:
"Elements with backdrop-filter cannot be clipped with clip-
path or mask"
https://bugs.webkit.org/show_bug.cgi?id=142662
http://trac.webkit.org/changeset/201349
Source/WebKit2:
Unreviewed, rolling out r201349.
This change caused compositing tests to assert on iOS
simulator
Reverted changeset:
"Elements with backdrop-filter cannot be clipped with clip-
path or mask"
https://bugs.webkit.org/show_bug.cgi?id=142662
http://trac.webkit.org/changeset/201349
LayoutTests:
201-05-24 Ryan Haddad <Ryan Haddad>
Unreviewed, rolling out r201349.
This change caused compositing tests to assert on iOS
simulator
Reverted changeset:
"Elements with backdrop-filter cannot be clipped with clip-
path or mask"
https://bugs.webkit.org/show_bug.cgi?id=142662
http://trac.webkit.org/changeset/201349
- 2:57 PM Changeset in webkit [201356] by
-
- 11 edits1 copy in trunk/Source/WebCore
Modern IDB: (Workers) Eliminate race in getting the ScriptExecutionContext and using it.
https://bugs.webkit.org/show_bug.cgi?id=158038
Reviewed by Alex Christensen.
No new tests (Resolves potential flakes in existing tests).
When the main thread is trying to post a task to a worker thread's ScriptExecutionContext, there is a race
between checking that the context still exists and actually using it.
The solution is to add a new class - IDBActiveDOMObject - which does a few things things:
1 - Remembers its origin thread.
2 - Guards clearing its ScriptExecutionContext with a Lock.
3 - Adds a templated "performCallbackOnOriginThread" that uses the same Lock to make sure posting the task to
the ScriptExecutionContext's RunLoop is safe.
Also, tons of ASSERTions are updated because each object with an originThread no longer keeps its idea in an
accessible member variable.
- Modules/indexeddb/IDBActiveDOMObject.h:
(WebCore::IDBActiveDOMObject::originThreadID):
(WebCore::IDBActiveDOMObject::performCallbackOnOriginThread):
(WebCore::IDBActiveDOMObject::IDBActiveDOMObject):
- Modules/indexeddb/IDBDatabase.cpp:
(WebCore::IDBDatabase::IDBDatabase):
(WebCore::IDBDatabase::~IDBDatabase):
(WebCore::IDBDatabase::hasPendingActivity):
(WebCore::IDBDatabase::name):
(WebCore::IDBDatabase::version):
(WebCore::IDBDatabase::objectStoreNames):
(WebCore::IDBDatabase::createObjectStore):
(WebCore::IDBDatabase::transaction):
(WebCore::IDBDatabase::deleteObjectStore):
(WebCore::IDBDatabase::close):
(WebCore::IDBDatabase::didCloseFromServer):
(WebCore::IDBDatabase::maybeCloseInServer):
(WebCore::IDBDatabase::activeDOMObjectName):
(WebCore::IDBDatabase::canSuspendForDocumentSuspension):
(WebCore::IDBDatabase::stop):
(WebCore::IDBDatabase::startVersionChangeTransaction):
(WebCore::IDBDatabase::didStartTransaction):
(WebCore::IDBDatabase::willCommitTransaction):
(WebCore::IDBDatabase::didCommitTransaction):
(WebCore::IDBDatabase::willAbortTransaction):
(WebCore::IDBDatabase::didAbortTransaction):
(WebCore::IDBDatabase::didCommitOrAbortTransaction):
(WebCore::IDBDatabase::fireVersionChangeEvent):
(WebCore::IDBDatabase::dispatchEvent):
(WebCore::IDBDatabase::didCreateIndexInfo):
(WebCore::IDBDatabase::didDeleteIndexInfo):
- Modules/indexeddb/IDBDatabase.h:
(WebCore::IDBDatabase::originThreadID): Deleted.
- Modules/indexeddb/IDBRequest.cpp:
(WebCore::IDBRequest::IDBRequest):
(WebCore::IDBRequest::~IDBRequest):
(WebCore::IDBRequest::errorCode):
(WebCore::IDBRequest::error):
(WebCore::IDBRequest::setSource):
(WebCore::IDBRequest::setVersionChangeTransaction):
(WebCore::IDBRequest::transaction):
(WebCore::IDBRequest::readyState):
(WebCore::IDBRequest::sourceObjectStoreIdentifier):
(WebCore::IDBRequest::sourceIndexIdentifier):
(WebCore::IDBRequest::requestedIndexRecordType):
(WebCore::IDBRequest::eventTargetInterface):
(WebCore::IDBRequest::activeDOMObjectName):
(WebCore::IDBRequest::canSuspendForDocumentSuspension):
(WebCore::IDBRequest::hasPendingActivity):
(WebCore::IDBRequest::stop):
(WebCore::IDBRequest::enqueueEvent):
(WebCore::IDBRequest::dispatchEvent):
(WebCore::IDBRequest::uncaughtExceptionInEventHandler):
(WebCore::IDBRequest::setResult):
(WebCore::IDBRequest::setResultToStructuredClone):
(WebCore::IDBRequest::clearResult):
(WebCore::IDBRequest::setResultToUndefined):
(WebCore::IDBRequest::resultCursor):
(WebCore::IDBRequest::willIterateCursor):
(WebCore::IDBRequest::didOpenOrIterateCursor):
(WebCore::IDBRequest::requestCompleted):
(WebCore::IDBRequest::onError):
(WebCore::IDBRequest::onSuccess):
- Modules/indexeddb/IDBRequest.h:
(WebCore::IDBRequest::originThreadID): Deleted.
- Modules/indexeddb/IDBTransaction.cpp:
(WebCore::IDBTransaction::IDBTransaction):
(WebCore::IDBTransaction::originThreadID): Deleted.
- Modules/indexeddb/IDBTransaction.h:
- Modules/indexeddb/client/IDBConnectionProxy.cpp:
(WebCore::IDBClient::IDBConnectionProxy::completeOpenDBRequest):
(WebCore::IDBClient::IDBConnectionProxy::completeOperation):
(WebCore::IDBClient::IDBConnectionProxy::fireVersionChangeEvent):
(WebCore::IDBClient::IDBConnectionProxy::notifyOpenDBRequestBlocked):
(WebCore::IDBClient::IDBConnectionProxy::didStartTransaction):
(WebCore::IDBClient::IDBConnectionProxy::didCommitTransaction):
(WebCore::IDBClient::IDBConnectionProxy::didAbortTransaction):
(WebCore::IDBClient::IDBConnectionProxy::didCloseFromServer):
(WebCore::IDBClient::performCallbackOnCorrectThread): Deleted.
- Modules/indexeddb/client/TransactionOperation.cpp:
(WebCore::IDBClient::TransactionOperation::scriptExecutionContext): Deleted.
- Modules/indexeddb/client/TransactionOperation.h:
(WebCore::IDBClient::TransactionOperation::performCompleteOnOriginThread):
- WebCore.xcodeproj/project.pbxproj:
- 2:48 PM Changeset in webkit [201355] by
-
- 8 edits3 adds in trunk
Only set overflow:hidden on -webkit-media-controls when the placeholder is showing.
https://bugs.webkit.org/show_bug.cgi?id=157975
Reviewed by Eric Carlson.
Source/WebCore:
Test: media/mac/controls-panel-not-clipped-out.html
overflow:hidden was added to clip out content contained in -webkit-media-controls
that sticks out of the bounds of that container when the inlinePlaybackPlaceholder
is showing. However, that style also clips out things that we want to show when the
inlinePlaybackPlaceholder is not showing. For example, the volume slider or the
controls panel when the video element's height is too short.
To fix that, we only set overflow:hidden on -webkit-media-controls when the
inlinePlaybackPlaceholder is visible.
- Modules/mediacontrols/mediaControlsApple.css:
(::-webkit-media-controls):
(::-webkit-media-controls.placeholder-showing):
Set overflow:hidden only when the placeholder is showing.
- Modules/mediacontrols/mediaControlsApple.js:
(Controller.prototype.handlePresentationModeChange):
Add the placeholderShowing class to -webkit-media-controls only when the
inlinePlaybackPlaceholder is not hidden.
LayoutTests:
This is a Mac only test. The media controls panel should still be visible
even if the media element's height is very short.
- TestExpectations:
- media/mac/controls-panel-not-clipped-out-expected.html: Added.
- media/mac/controls-panel-not-clipped-out.html: Added.
- platform/mac/TestExpectations:
- platform/mac/media/media-document-audio-repaint-expected.txt:
- platform/mac/media/video-zoom-controls-expected.txt:
Rebaseline tests.
- 2:38 PM Changeset in webkit [201354] by
-
- 13 edits in trunk/Source
Unreviewed, rolling out r201341.
This change may have caused LayoutTests to crash on Mac and
iOS
Reverted changeset:
"Use lambda capture with initializer instead of StringCapture"
https://bugs.webkit.org/show_bug.cgi?id=158010
http://trac.webkit.org/changeset/201341
- 2:30 PM Changeset in webkit [201353] by
-
- 2 edits in branches/safari-602.1.32.5-branch/Source/ThirdParty/ANGLE
Merge r201336. rdar://problem/26446679
- 2:30 PM Changeset in webkit [201352] by
-
- 12 edits in branches/safari-602.1.32.5-branch
Merge r200799. rdar://problem/25931513
- 2:12 PM Changeset in webkit [201351] by
-
- 2 edits in trunk/Source/WebKit2
Fix null pointer dereferencing in WebViewImpl::inputContext
https://bugs.webkit.org/show_bug.cgi?id=158026
rdar://problem/25994093
Patch by Alex Christensen <achristensen@webkit.org> on 2016-05-24
Reviewed by Tim Horton.
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView inputContext]):
this was null sometimes in WebViewImpl::inputContext.
- 2:03 PM Changeset in webkit [201350] by
-
- 6 edits in trunk
WebRTC: RTCIceCandidate: Make attributes readonly (and update constructor arg)
https://bugs.webkit.org/show_bug.cgi?id=157859
Reviewed by Eric Carlson.
Source/WebCore:
Make the RTCIceCandidate constructor argument mandatory and the attributes
read-only (in accordance with the WebRTC 1.0 specification [1]).
[1] https://w3c.github.io/webrtc-pc/archives/20160513/webrtc.html#rtcicecandidate-interface
Updated existing test.
- Modules/mediastream/RTCIceCandidate.h:
(WebCore::RTCIceCandidate::setCandidate): Deleted.
(WebCore::RTCIceCandidate::setSdpMid): Deleted.
(WebCore::RTCIceCandidate::setSdpMLineIndex): Deleted.
- Modules/mediastream/RTCIceCandidate.idl:
LayoutTests:
- fast/mediastream/RTCIceCandidate-expected.txt:
Small unrelated fix: s/a argument/an argument/ (test was previously broken).
- fast/mediastream/RTCIceCandidate.html:
Test without constructor arguments and writing to the read-only attributes.
- 2:02 PM Changeset in webkit [201349] by
-
- 5 edits4 adds in trunk
Elements with backdrop-filter cannot be clipped with clip-path or mask
https://bugs.webkit.org/show_bug.cgi?id=142662
<rdar://problem/20150192>
Patch by Antoine Quint <Antoine Quint> on 2016-05-24
Reviewed by Dean Jackson.
Source/WebCore:
We used to only apply the mask to the layer contents but did not account
for the fact that a layer backdrop may exist. We now correctly mask the
backdrop layer as well as the layer contents.
Test: css3/filters/backdrop/backdrop-filter-with-clip-path.html
- platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::updateShape):
Ensure clones of a layer use the same shape path.
(WebCore::GraphicsLayerCA::updateMaskLayer):
If we have a backdrop layer, ensure that we apply a clone of the mask layer applied to
the layer contents.
Source/WebKit2:
Ensure layer clones are set up with the same shape path as their original layer.
- WebProcess/WebPage/mac/PlatformCALayerRemote.cpp:
(WebKit::PlatformCALayerRemote::updateClonedLayerProperties):
LayoutTests:
New test that checks that applying a backdrop-filter and a clip-path on a single
element has the same effect as applying a clip-path on a parent of a child with
a backdrop-filter.
- css3/filters/backdrop/backdrop-filter-with-clip-path-expected.txt: Added.
- css3/filters/backdrop/backdrop-filter-with-clip-path.html: Added.
- platform/ios-simulator/css3/filters/backdrop/backdrop-filter-with-clip-path-expected.html: Added.
- platform/mac/css3/filters/backdrop/backdrop-filter-with-clip-path-expected.png: Added.
- 2:01 PM Changeset in webkit [201348] by
-
- 3 edits in trunk/LayoutTests
WebRTC: Update failing RTCPeerConnection and RTCRtpSender tests
https://bugs.webkit.org/show_bug.cgi?id=158023
Reviewed by Eric Carlson.
- fast/mediastream/RTCPeerConnection-add-removeTrack-expected.txt:
Update results with more specific TypeError.
- fast/mediastream/RTCRtpSender-replaceTrack-expected.txt:
Update test to match Promise rejections introduce in r201080.
- 1:22 PM Changeset in webkit [201347] by
-
- 3 edits in trunk/Source/WebKit2
[iOS] Allow clients to override the type of an input field
https://bugs.webkit.org/show_bug.cgi?id=157995
Patch by Chelsea Pugh <cpugh@apple.com> on 2016-05-24
Reviewed by Dan Bernstein.
- UIProcess/API/Cocoa/_WKFormInputSession.h:
- UIProcess/ios/WKContentViewInteraction.mm:
(-[WKFormInputSession textContentType]): Getter for textContentType.
(-[WKFormInputSession setTextContentType:]): Set the textContentType and reload
input views.
(contentTypeFromFieldName): Factor out switch statement to get text content type
from autofill field name into its own function.
(-[WKContentView textInputTraits]): If the client has set a text content type,
set the traits' content type to that. Otherwise, set the text content type if
there is one based on the assisted node information's autofill field name. If
neither the form input session nor the assisted node info yields a text content
type, set the text content type to nil, its default value.
- 1:02 PM Changeset in webkit [201346] by
-
- 9 edits in trunk
fast/table/neighboring-cells-when-collapsed-border-changes.html is flaky.
https://bugs.webkit.org/show_bug.cgi?id=158009
Reviewed by David Hyatt.
RenderTable::invalidateCollapsedBorders() early returns on m_collapsedEmptyBorderIsPresent
which prevents us from marking neighboring cells dirty when style changes.
Decouple the "invalidate the collapsed borders" and the "mark the neighboring cells dirty" logic.
Source/WebCore:
Covered by existing tests. (and now we agree with FF on cached-change-cell-border-width.html)
- rendering/RenderTable.cpp:
(WebCore::RenderTable::invalidateCollapsedBorders):
(WebCore::markCellDirtyWhenCollapsedBorderChanges): Deleted.
- rendering/RenderTableCell.cpp:
(WebCore::markCellDirtyWhenCollapsedBorderChanges):
(WebCore::RenderTableCell::styleDidChange):
LayoutTests:
- fast/table/border-collapsing/cached-change-cell-border-width-expected.txt: Progression. FF agrees.
- fast/table/neighboring-cells-when-collapsed-border-changes.html:
- platform/ios-simulator-wk1/fast/table/border-collapsing/cached-change-cell-border-width-expected.txt:
- platform/mac-wk1/TestExpectations:
- platform/mac/fast/table/border-collapsing/cached-change-cell-border-width-expected.txt:
- 1:01 PM Changeset in webkit [201345] by
-
- 3 edits in trunk/Source/WebCore
Fix use-after-free after r201318
https://bugs.webkit.org/show_bug.cgi?id=158037
rdar://problem/26446729
Reviewed by Brady Eidson.
This fixes a crash when running fast/dom/navigation-with-sideeffects.html with GuardMalloc.
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateImplementation):
- bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::setJSTestObjPutForwardsNullableAttribute):
Changing RefPtr<${type}> to auto caused the type to sometimes be a raw pointer, which does not keep the object alive.
In the case of JSDocument.cpp, forwardedImpl was what Document::location returned, which is a Location* and not a RefPtr<Location>.
- 12:56 PM Changeset in webkit [201344] by
-
- 2 edits in trunk/LayoutTests
Marking mathml/wbr-in-mroot-crash.html as flaky on ios-simulator-wk2
https://bugs.webkit.org/show_bug.cgi?id=157990
Unreviewed test gardening.
- platform/ios-simulator-wk2/TestExpectations:
- 12:48 PM Changeset in webkit [201343] by
-
- 1 edit4 deletes in trunk/LayoutTests
Unreviewed, rolling out r201323.
One of the LayoutTests added with this change fails on all
platforms. Rolling out until ResourceTiming flakiness fix is
landed
Reverted changeset:
"Add a few initiator tests to resource timing."
https://bugs.webkit.org/show_bug.cgi?id=157986
http://trac.webkit.org/changeset/201323
- 12:04 PM Changeset in webkit [201342] by
-
- 2 edits in trunk/Source/JavaScriptCore
Unreviwed, add a comment to describe the test's failure mode. Suggested by mlam.
- tests/stress/override-map-constructor.js:
(Map):
- 12:03 PM Changeset in webkit [201341] by
-
- 13 edits in trunk/Source
Use lambda capture with initializer instead of StringCapture
https://bugs.webkit.org/show_bug.cgi?id=158010
Reviewed by Antti Koivisto.
Source/WebCore:
Use lambda capture with initializer instead of StringCapture now that
we support C++14.
- fileapi/AsyncFileStream.cpp:
(WebCore::AsyncFileStream::getSize):
(WebCore::AsyncFileStream::openForRead):
(WebCore::AsyncFileStream::openForWrite):
- loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::installContentFilterUnblockHandler):
- loader/WorkerThreadableLoader.cpp:
(WebCore::WorkerThreadableLoader::MainThreadBridge::MainThreadBridge):
- platform/ios/WebVideoFullscreenControllerAVKit.mm:
(WebVideoFullscreenControllerContext::setExternalPlayback):
- platform/network/curl/CurlDownload.cpp:
(WebCore::CurlDownload::didReceiveHeader):
- workers/WorkerMessagingProxy.cpp:
(WebCore::WorkerMessagingProxy::postExceptionToWorkerObject):
(WebCore::WorkerMessagingProxy::postConsoleMessageToWorkerObject):
Source/WebKit2:
Use lambda capture with initializer instead of StringCapture now that
we support C++14.
- NetworkProcess/cache/NetworkCache.cpp:
(WebKit::NetworkCache::Cache::deleteDumpFile):
- NetworkProcess/cache/NetworkCacheStatistics.cpp:
(WebKit::NetworkCache::Statistics::initialize):
(WebKit::NetworkCache::Statistics::shrinkIfNeeded):
- NetworkProcess/cache/NetworkCacheStorage.cpp:
(WebKit::NetworkCache::Storage::updateFileModificationTime):
(WebKit::NetworkCache::Storage::clear):
- UIProcess/API/APIUserContentExtensionStore.cpp:
(API::UserContentExtensionStore::lookupContentExtension):
(API::UserContentExtensionStore::compileContentExtension):
(API::UserContentExtensionStore::removeContentExtension):
- UIProcess/WebsiteData/WebsiteDataStore.cpp:
(WebKit::WebsiteDataStore::fetchData):
(WebKit::WebsiteDataStore::removeData):
- 12:01 PM Changeset in webkit [201340] by
-
- 3 edits1 add in trunk/Source/JavaScriptCore
Map should not be in JSGlobalObject's static hashtable because it's initialized eagerly via FOR_EACH_SIMPLE_BUILTIN_TYPE_WITH_CONSTRUCTOR
https://bugs.webkit.org/show_bug.cgi?id=158031
rdar://problem/26353661
Reviewed by Geoffrey Garen.
We were listing Map as being a lazy class structure. It's not. m_mapStructure is a WriteBarrier<>
not a LazyClassStructure<> and there is nothing lazy about it.
- runtime/JSGlobalObject.cpp: The fix is to remove Map here.
- runtime/Lookup.cpp: Add some dumping on the assert path.
(JSC::setUpStaticFunctionSlot):
- tests/stress/override-map-constructor.js: Added. This test used to crash.
(Map):
- 12:00 PM Changeset in webkit [201339] by
-
- 3 edits82 adds in trunk
We should have JSBench in PerformanceTests
https://bugs.webkit.org/show_bug.cgi?id=157952
Rubber-stamped by Saam Barati.
PerformanceTests:
There are some slight changes to the layout of the test directory
to make it work nicely with run-jsc-benchmarks. Before JSBench
had each of the browser specific sub-tests in a sub-directory.
These have been flattened e.g. amazon/safari/ has become
amazon-safari/.
- JSBench/amazon-chrome-win/urem.html: Added.
- JSBench/amazon-chrome-win/urem.js: Added.
- JSBench/amazon-chrome/urem.html: Added.
- JSBench/amazon-chrome/urem.js: Added.
- JSBench/amazon-firefox-win/urm.html: Added.
- JSBench/amazon-firefox-win/urm.js: Added.
- JSBench/amazon-firefox/urm.html: Added.
- JSBench/amazon-firefox/urm.js: Added.
- JSBench/amazon-safari/urem.html: Added.
- JSBench/amazon-safari/urem.js: Added.
- JSBench/browsercheck.js: Added.
- JSBench/facebook-chrome-win/urem.html: Added.
- JSBench/facebook-chrome-win/urem.js: Added.
- JSBench/facebook-chrome/urem.html: Added.
- JSBench/facebook-chrome/urem.js: Added.
- JSBench/facebook-firefox-win/urem.html: Added.
- JSBench/facebook-firefox-win/urem.js: Added.
- JSBench/facebook-firefox/urem.html: Added.
- JSBench/facebook-firefox/urem.js: Added.
- JSBench/facebook-safari/urem.html: Added.
- JSBench/facebook-safari/urem.js: Added.
- JSBench/google-chrome-win/urem.html: Added.
- JSBench/google-chrome-win/urem.js: Added.
- JSBench/google-chrome/urem.html: Added.
- JSBench/google-chrome/urem.js: Added.
- JSBench/google-firefox-win/urem.html: Added.
- JSBench/google-firefox-win/urem.js: Added.
- JSBench/google-firefox/uem.html: Added.
- JSBench/google-firefox/uem.js: Added.
- JSBench/google-safari/urem.html: Added.
- JSBench/google-safari/urem.js: Added.
- JSBench/harness.html: Added.
- JSBench/harness.js: Added.
- JSBench/harness.py: Added.
- JSBench/index.html: Added.
- JSBench/reload.html: Added.
- JSBench/twitter-chrome-win/rem.html: Added.
- JSBench/twitter-chrome-win/rem.js: Added.
- JSBench/twitter-chrome/urem.html: Added.
- JSBench/twitter-chrome/urem.js: Added.
- JSBench/twitter-firefox-win/urem.html: Added.
- JSBench/twitter-firefox-win/urem.js: Added.
- JSBench/twitter-firefox/urem.html: Added.
- JSBench/twitter-firefox/urem.js: Added.
- JSBench/twitter-safari/urem.html: Added.
- JSBench/twitter-safari/urem.js: Added.
- JSBench/yahoo-chrome-win/urem.html: Added.
- JSBench/yahoo-chrome-win/urem.js: Added.
- JSBench/yahoo-chrome/urem.html: Added.
- JSBench/yahoo-chrome/urem.js: Added.
- JSBench/yahoo-firefox-win/urem.html: Added.
- JSBench/yahoo-firefox-win/urem.js: Added.
- JSBench/yahoo-firefox/urem.html: Added.
- JSBench/yahoo-firefox/urem.js: Added.
- JSBench/yahoo-safari/urem.html: Added.
- JSBench/yahoo-safari/urem.js: Added.
Tools:
This changes the runner to use the layout of the newest version of JSBench.
- Scripts/run-jsc-benchmarks:
- 11:45 AM Changeset in webkit [201338] by
-
- 2 edits in trunk/LayoutTests
Unskip passing test after r201336
https://bugs.webkit.org/show_bug.cgi?id=156812
- platform/ios-simulator/TestExpectations:
compositing/webgl/webgl-reflection.html passes now.
- 11:04 AM Changeset in webkit [201337] by
-
- 2 edits in trunk/Websites/perf.webkit.org
Another build fix after r201307.
- public/v3/pages/page-router.js:
(PageRouter.prototype._deserializeHashQueryValue):
(PageRouter.prototype._countOccurrences): Moved from _deserializeHashQueryValue.
- 10:36 AM Changeset in webkit [201336] by
-
- 2 edits in trunk/Source/ThirdParty/ANGLE
Fix iOS WebGL after r199738
https://bugs.webkit.org/show_bug.cgi?id=158024
rdar://problem/26446679
Reviewed by Myles Maxfield.
- ANGLE.xcodeproj/project.pbxproj:
iOS needs the ESSL translator.
- 10:08 AM Changeset in webkit [201335] by
-
- 9 edits3 adds in trunk
LLInt64 should have typed array fast paths for get_by_val
https://bugs.webkit.org/show_bug.cgi?id=157931
Reviewed by Keith Miller.
Source/JavaScriptCore:
I think that the LLInt should be able to access typed arrays more quickly than it does now.
Ideally we would have fast paths for every major typed array operation and we would use
inline cache optimizations. I don't want to do this all in one go, so my plan is to
incrementally add support for this as time allows.
This change just adds the easy typed array fast paths for get_by_val in the 64-bit version
of LLInt.
Another bug, https://bugs.webkit.org/show_bug.cgi?id=157922, tracks the overall task of
adding all typed array fast paths to both versions of the LLInt.
This is a 30% speed-up on typed array benchmarks in LLInt. This is not a speed-up when the
JITs are enabled.
- llint/LLIntData.cpp:
(JSC::LLInt::Data::performAssertions):
- llint/LLIntOffsetsExtractor.cpp:
- llint/LowLevelInterpreter.asm:
- llint/LowLevelInterpreter64.asm:
- offlineasm/backends.rb:
- runtime/JSArrayBufferView.h:
- runtime/JSType.h:
LayoutTests:
- js/regress/get_by_val-Int32Array-expected.txt: Added.
- js/regress/get_by_val-Int32Array.html: Added.
- js/regress/script-tests/get_by_val-Int32Array.js: Added.
- 9:59 AM Changeset in webkit [201334] by
-
- 2 edits in trunk/Source/WebCore
In accelerated drawing mode, ImageBuffer::putByteArray() should copy the bytes directly to the IOSurface backing store
https://bugs.webkit.org/show_bug.cgi?id=157966
Patch by Said Abou-Hallawa <sabouhallawa@apple.com> on 2016-05-24
Reviewed by Dean Jackson.
Roll out the the change of r106836 in ImageBuffer::putByteArray(). r106836
was using CG to draw the image data as a native image in the accelerated
drawing mode just to force invalidating the IOSurface cached image. Instead
of doing that, we can use a light-weight fix, for now, to force recreating
the IOSurface image if it is requested through CGIOSurfaceContextCreateImage().
- platform/graphics/cg/ImageBufferCG.cpp:
(WebCore::ImageBuffer::putByteArray):
- 9:50 AM Changeset in webkit [201333] by
-
- 47 edits in trunk
Use auto for some of our lambda function parameters
https://bugs.webkit.org/show_bug.cgi?id=158001
Reviewed by Darin Adler.
Use auto for some of our lambda function parameters now that we build with c++14.
Source/WebCore:
- Modules/mediasource/MediaSource.cpp:
(WebCore::MediaSource::buffered):
(WebCore::MediaSource::monitorSourceBuffers):
(WebCore::MediaSource::endOfStream):
- Modules/mediasource/SampleMap.cpp:
(WebCore::PresentationOrderSampleMap::findSamplesWithinPresentationRangeFromEnd):
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::ariaSelectedRows):
- bindings/js/SerializedScriptValue.cpp:
(WebCore::SerializedScriptValue::writeBlobsToDiskForIndexedDB):
- css/CSSValueList.cpp:
(WebCore::CSSValueList::removeAll):
- css/MediaList.cpp:
(WebCore::MediaQuerySet::remove):
- css/MediaQuery.cpp:
(WebCore::MediaQuery::MediaQuery):
- css/MediaQueryMatcher.cpp:
(WebCore::MediaQueryMatcher::removeListener):
- dom/Document.cpp:
(WebCore::Document::validateAutoSizingNodes):
- dom/Element.cpp:
(WebCore::Element::detachAttrNodeFromElementWithValue):
- dom/MutationObserver.cpp:
(WebCore::MutationObserver::deliverAllMutations):
- dom/Node.cpp:
(WebCore::Node::unregisterMutationObserver):
- html/LinkIconCollector.cpp:
- inspector/InspectorIndexedDBAgent.cpp:
(WebCore::InspectorIndexedDBAgent::requestDatabaseNames):
- loader/ResourceLoader.cpp:
(WebCore::ResourceLoader::loadDataURL):
- page/CaptionUserPreferences.cpp:
(WebCore::CaptionUserPreferences::sortedTrackListForMenu):
- page/CaptionUserPreferencesMediaAF.cpp:
(WebCore::CaptionUserPreferencesMediaAF::sortedTrackListForMenu):
- page/animation/AnimationController.cpp:
(WebCore::AnimationControllerPrivate::clear):
- platform/graphics/FontCascade.cpp:
(WebCore::pruneUnreferencedEntriesFromFontCascadeCache):
- platform/graphics/FontCascadeFonts.cpp:
(WebCore::FontCascadeFonts::pruneSystemFallbacks):
- platform/graphics/PathUtilities.cpp:
(WebCore::addIntersectionPoints):
- platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm:
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::updateTracks):
- platform/graphics/texmap/TextureMapperGL.cpp:
(WebCore::TextureMapperGLData::SharedGLData::~SharedGLData):
- platform/mac/HIDGamepad.cpp:
(WebCore::HIDGamepad::initElements):
- svg/SVGToOTFFontConversion.cpp:
(WebCore::SVGToOTFFontConverter::appendLigatureSubtable):
(WebCore::SVGToOTFFontConverter::finishAppendingKERNSubtable):
Source/WebKit2:
- DatabaseProcess/IndexedDB/WebIDBConnectionToClient.cpp:
(WebKit::WebIDBConnectionToClient::didGetRecord):
- NetworkProcess/NetworkConnectionToWebProcess.cpp:
(WebKit::NetworkConnectionToWebProcess::writeBlobsToTemporaryFiles):
- NetworkProcess/NetworkProcess.cpp:
(WebKit::fetchDiskCacheEntries):
(WebKit::NetworkProcess::fetchWebsiteData):
(WebKit::clearDiskCacheEntries):
- NetworkProcess/NetworkResourceLoader.cpp:
(WebKit::NetworkResourceLoader::retrieveCacheEntry):
(WebKit::NetworkResourceLoader::tryStoreAsCacheEntry):
- NetworkProcess/cache/NetworkCacheSpeculativeLoad.cpp:
(WebKit::NetworkCache::SpeculativeLoad::didFinishLoading):
- NetworkProcess/cache/NetworkCacheSpeculativeLoadManager.cpp:
(WebKit::NetworkCache::SpeculativeLoadManager::registerLoad):
(WebKit::NetworkCache::SpeculativeLoadManager::retrieveEntryFromStorage):
(WebKit::NetworkCache::SpeculativeLoadManager::revalidateEntry):
(WebKit::NetworkCache::SpeculativeLoadManager::preloadEntry):
(WebKit::NetworkCache::SpeculativeLoadManager::retrieveSubresourcesEntry):
- NetworkProcess/cache/NetworkCacheStorage.cpp:
(WebKit::NetworkCache::Storage::removeFromPendingWriteOperations):
- NetworkProcess/cocoa/NetworkSessionCocoa.mm:
(-[WKNetworkSessionDelegate URLSession:task:willPerformHTTPRedirection:newRequest:completionHandler:]):
(-[WKNetworkSessionDelegate URLSession:task:_schemeUpgraded:completionHandler:]):
- Shared/API/Cocoa/_WKRemoteObjectInterface.mm:
(-[_WKRemoteObjectInterface debugDescription]):
- UIProcess/API/C/WKApplicationCacheManager.cpp:
(WKApplicationCacheManagerGetApplicationCacheOrigins):
- UIProcess/API/C/WKKeyValueStorageManager.cpp:
(WKKeyValueStorageManagerGetKeyValueStorageOrigins):
(WKKeyValueStorageManagerGetStorageDetailsByOrigin):
- UIProcess/API/C/WKResourceCacheManager.cpp:
(WKResourceCacheManagerGetCacheOrigins):
- UIProcess/API/Cocoa/WKWebsiteDataStore.mm:
(-[WKWebsiteDataStore _fetchDataRecordsOfTypes:withOptions:completionHandler:]):
- UIProcess/UserContent/WebUserContentControllerProxy.cpp:
(WebKit::WebUserContentControllerProxy::removeAllUserScripts):
(WebKit::WebUserContentControllerProxy::removeAllUserStyleSheets):
(WebKit::WebUserContentControllerProxy::removeAllUserMessageHandlers):
- WebProcess/WebPage/mac/PlatformCALayerRemote.cpp:
(WebKit::PlatformCALayerRemote::removeAnimationForKey):
Source/WTF:
- wtf/BubbleSort.h:
(WTF::bubbleSort):
Tools:
- WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
(WTR::InjectedBundle::willDestroyPage):
- 9:46 AM Changeset in webkit [201332] by
-
- 2 edits in trunk/Source/WebCore
REGRESSION (r196629): Safari can get into a state where switching Reader theme doesn't apply to the webpage
https://bugs.webkit.org/show_bug.cgi?id=158018
<rdar://problem/24732776>
Reviewed by Darin Adler.
When a tab goes to background we clear the style resolver. It is recreated lazily when the tab is again active.
However style invalidation code tests if the style resolver exists and skips the invalidation if it doesn't.
With sufficiently simple document (like in Reader) we may never create one for other reasons and so style
invalidation doesn't work.
No test, don't know how to make one.
- dom/Element.cpp:
(WebCore::Element::needsStyleInvalidation):
Remove styleResolverIfExists() check and do the invalidation normally.
Instead check for forced style recalc. If there is one pending we don't need to bother with invalidation.
- 7:33 AM Changeset in webkit [201331] by
-
- 23 edits in trunk/Source/WebCore
Unreviewed, updating binding test results
https://bugs.webkit.org/show_bug.cgi?id=157080
- bindings/scripts/test/JS/JSTestActiveDOMObject.cpp:
(WebCore::jsTestActiveDOMObjectExcitingAttr):
(WebCore::jsTestActiveDOMObjectConstructor):
- bindings/scripts/test/JS/JSTestClassWithJSBuiltinConstructor.cpp:
(WebCore::jsTestClassWithJSBuiltinConstructorConstructor):
- bindings/scripts/test/JS/JSTestCustomConstructorWithNoInterfaceObject.cpp:
(WebCore::jsTestCustomConstructorWithNoInterfaceObjectConstructor):
- bindings/scripts/test/JS/JSTestCustomNamedGetter.cpp:
(WebCore::jsTestCustomNamedGetterConstructor):
- bindings/scripts/test/JS/JSTestEventConstructor.cpp:
(WebCore::jsTestEventConstructorAttr1):
(WebCore::jsTestEventConstructorAttr2):
(WebCore::jsTestEventConstructorAttr3):
(WebCore::jsTestEventConstructorConstructor):
- bindings/scripts/test/JS/JSTestEventTarget.cpp:
(WebCore::jsTestEventTargetConstructor):
- bindings/scripts/test/JS/JSTestException.cpp:
(WebCore::jsTestExceptionName):
(WebCore::jsTestExceptionConstructor):
- bindings/scripts/test/JS/JSTestGenerateIsReachable.cpp:
(WebCore::jsTestGenerateIsReachableConstructor):
- bindings/scripts/test/JS/JSTestGlobalObject.cpp:
(WebCore::jsTestGlobalObjectRegularAttribute):
(WebCore::jsTestGlobalObjectEnabledAtRuntimeAttribute):
(WebCore::jsTestGlobalObjectConstructor):
- bindings/scripts/test/JS/JSTestInterface.cpp:
(WebCore::jsTestInterfaceConstructorImplementsStaticReadOnlyAttr):
(WebCore::jsTestInterfaceConstructorImplementsStaticAttr):
(WebCore::jsTestInterfaceImplementsStr1):
(WebCore::jsTestInterfaceImplementsStr2):
(WebCore::jsTestInterfaceImplementsStr3):
(WebCore::jsTestInterfaceImplementsNode):
(WebCore::jsTestInterfaceConstructorSupplementalStaticReadOnlyAttr):
(WebCore::jsTestInterfaceConstructorSupplementalStaticAttr):
(WebCore::jsTestInterfaceSupplementalStr1):
(WebCore::jsTestInterfaceSupplementalStr2):
(WebCore::jsTestInterfaceSupplementalStr3):
(WebCore::jsTestInterfaceSupplementalNode):
(WebCore::jsTestInterfaceConstructor):
- bindings/scripts/test/JS/JSTestJSBuiltinConstructor.cpp:
(WebCore::jsTestJSBuiltinConstructorTestAttributeCustom):
(WebCore::jsTestJSBuiltinConstructorTestAttributeRWCustom):
(WebCore::jsTestJSBuiltinConstructorConstructor):
- bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:
(WebCore::jsTestMediaQueryListListenerConstructor):
- bindings/scripts/test/JS/JSTestNamedConstructor.cpp:
(WebCore::jsTestNamedConstructorConstructor):
- bindings/scripts/test/JS/JSTestNode.cpp:
(WebCore::jsTestNodeName):
(WebCore::jsTestNodeConstructor):
- bindings/scripts/test/JS/JSTestNondeterministic.cpp:
(WebCore::jsTestNondeterministicNondeterministicReadonlyAttr):
(WebCore::jsTestNondeterministicNondeterministicWriteableAttr):
(WebCore::jsTestNondeterministicNondeterministicExceptionAttr):
(WebCore::jsTestNondeterministicNondeterministicGetterExceptionAttr):
(WebCore::jsTestNondeterministicNondeterministicSetterExceptionAttr):
(WebCore::jsTestNondeterministicConstructor):
- bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::jsTestObjReadOnlyLongAttr):
(WebCore::jsTestObjReadOnlyStringAttr):
(WebCore::jsTestObjReadOnlyTestObjAttr):
(WebCore::jsTestObjConstructorStaticReadOnlyLongAttr):
(WebCore::jsTestObjConstructorStaticStringAttr):
(WebCore::jsTestObjConstructorTestSubObj):
(WebCore::jsTestObjTestSubObjEnabledBySettingConstructor):
(WebCore::jsTestObjEnumAttr):
(WebCore::jsTestObjByteAttr):
(WebCore::jsTestObjOctetAttr):
(WebCore::jsTestObjShortAttr):
(WebCore::jsTestObjClampedShortAttr):
(WebCore::jsTestObjEnforceRangeShortAttr):
(WebCore::jsTestObjUnsignedShortAttr):
(WebCore::jsTestObjLongAttr):
(WebCore::jsTestObjLongLongAttr):
(WebCore::jsTestObjUnsignedLongLongAttr):
(WebCore::jsTestObjStringAttr):
(WebCore::jsTestObjTestObjAttr):
(WebCore::jsTestObjTestNullableObjAttr):
(WebCore::jsTestObjLenientTestObjAttr):
(WebCore::jsTestObjUnforgeableAttr):
(WebCore::jsTestObjStringAttrTreatingNullAsEmptyString):
(WebCore::jsTestObjXMLObjAttr):
(WebCore::jsTestObjCreate):
(WebCore::jsTestObjReflectedStringAttr):
(WebCore::jsTestObjReflectedIntegralAttr):
(WebCore::jsTestObjReflectedUnsignedIntegralAttr):
(WebCore::jsTestObjReflectedBooleanAttr):
(WebCore::jsTestObjReflectedURLAttr):
(WebCore::jsTestObjReflectedCustomIntegralAttr):
(WebCore::jsTestObjReflectedCustomBooleanAttr):
(WebCore::jsTestObjReflectedCustomURLAttr):
(WebCore::jsTestObjEnabledAtRuntimeAttribute):
(WebCore::jsTestObjTypedArrayAttr):
(WebCore::jsTestObjAttrWithGetterException):
(WebCore::jsTestObjAttrWithGetterExceptionWithMessage):
(WebCore::jsTestObjAttrWithSetterException):
(WebCore::jsTestObjAttrWithSetterExceptionWithMessage):
(WebCore::jsTestObjStringAttrWithGetterException):
(WebCore::jsTestObjStringAttrWithSetterException):
(WebCore::jsTestObjStrictTypeCheckingAttribute):
(WebCore::jsTestObjCustomAttr):
(WebCore::jsTestObjOnfoo):
(WebCore::jsTestObjOnwebkitfoo):
(WebCore::jsTestObjWithScriptStateAttribute):
(WebCore::jsTestObjWithCallWithAndSetterCallWithAttribute):
(WebCore::jsTestObjWithScriptExecutionContextAttribute):
(WebCore::jsTestObjWithScriptStateAttributeRaises):
(WebCore::jsTestObjWithScriptExecutionContextAttributeRaises):
(WebCore::jsTestObjWithScriptExecutionContextAndScriptStateAttribute):
(WebCore::jsTestObjWithScriptExecutionContextAndScriptStateAttributeRaises):
(WebCore::jsTestObjWithScriptExecutionContextAndScriptStateWithSpacesAttribute):
(WebCore::jsTestObjWithScriptArgumentsAndCallStackAttribute):
(WebCore::jsTestObjConditionalAttr1):
(WebCore::jsTestObjConditionalAttr2):
(WebCore::jsTestObjConditionalAttr3):
(WebCore::jsTestObjConditionalAttr4Constructor):
(WebCore::jsTestObjConditionalAttr5Constructor):
(WebCore::jsTestObjConditionalAttr6Constructor):
(WebCore::jsTestObjCachedAttribute1):
(WebCore::jsTestObjCachedAttribute2):
(WebCore::jsTestObjAnyAttribute):
(WebCore::jsTestObjContentDocument):
(WebCore::jsTestObjMutablePoint):
(WebCore::jsTestObjImmutablePoint):
(WebCore::jsTestObjStrawberry):
(WebCore::jsTestObjStrictFloat):
(WebCore::jsTestObjDescription):
(WebCore::jsTestObjId):
(WebCore::jsTestObjHash):
(WebCore::jsTestObjReplaceableAttribute):
(WebCore::jsTestObjNullableDoubleAttribute):
(WebCore::jsTestObjNullableLongAttribute):
(WebCore::jsTestObjNullableBooleanAttribute):
(WebCore::jsTestObjNullableStringAttribute):
(WebCore::jsTestObjNullableLongSettableAttribute):
(WebCore::jsTestObjNullableStringSettableAttribute):
(WebCore::jsTestObjNullableStringValue):
(WebCore::jsTestObjAttribute):
(WebCore::jsTestObjAttributeWithReservedEnumType):
(WebCore::jsTestObjPutForwardsAttribute):
(WebCore::jsTestObjPutForwardsNullableAttribute):
(WebCore::jsTestObjConstructor):
- bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp:
(WebCore::jsTestOverloadedConstructorsConstructor):
- bindings/scripts/test/JS/JSTestOverrideBuiltins.cpp:
(WebCore::jsTestOverrideBuiltinsConstructor):
- bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:
(WebCore::jsTestSerializedScriptValueInterfaceValue):
(WebCore::jsTestSerializedScriptValueInterfaceReadonlyValue):
(WebCore::jsTestSerializedScriptValueInterfaceCachedValue):
(WebCore::jsTestSerializedScriptValueInterfacePorts):
(WebCore::jsTestSerializedScriptValueInterfaceCachedReadonlyValue):
(WebCore::jsTestSerializedScriptValueInterfaceConstructor):
- bindings/scripts/test/JS/JSTestTypedefs.cpp:
(WebCore::jsTestTypedefsUnsignedLongLongAttr):
(WebCore::jsTestTypedefsImmutableSerializedScriptValue):
(WebCore::jsTestTypedefsConstructorTestSubObj):
(WebCore::jsTestTypedefsAttrWithGetterException):
(WebCore::jsTestTypedefsAttrWithSetterException):
(WebCore::jsTestTypedefsStringAttrWithGetterException):
(WebCore::jsTestTypedefsStringAttrWithSetterException):
(WebCore::jsTestTypedefsConstructor):
- bindings/scripts/test/JS/JSattribute.cpp:
(WebCore::jsattributeReadonly):
(WebCore::jsattributeConstructor):
- bindings/scripts/test/JS/JSreadonly.cpp:
(WebCore::jsreadonlyConstructor):
- 6:12 AM Changeset in webkit [201330] by
-
- 7 edits in trunk/LayoutTests
Unreviewed GTK+ gardening. Rebaseline several tests after r200116.
We are now correctly positioning RTL scrollbars.
- platform/gtk/fast/block/float/026-expected.png:
- platform/gtk/fast/block/float/026-expected.txt:
- platform/gtk/fast/block/float/028-expected.png:
- platform/gtk/fast/block/float/028-expected.txt:
- platform/gtk/fast/overflow/unreachable-overflow-rtl-bug-expected.png:
- platform/gtk/fast/overflow/unreachable-overflow-rtl-bug-expected.txt:
- 5:58 AM Changeset in webkit [201329] by
-
- 2 edits in trunk/LayoutTests
Unreviewed GTK+ gardening. Fix wrong expectations of fast/harness/sample-fail-mismatch-reftest.html.
The test is flaky, but in this case Pass means it failed and ImageOnlyFailure that it passed.
- platform/gtk/TestExpectations:
- 5:04 AM Changeset in webkit [201328] by
-
- 20 edits1 add in trunk/Source/JavaScriptCore
ThisTDZMode is no longer needed
https://bugs.webkit.org/show_bug.cgi?id=157209
Reviewed by Saam Barati.
ThisTDZMode is no longer needed because we have ConstructorKind
and DerivedContextType. The value of ThisTDZMode is strictly less
expressive than the combination of those two values. We were
using those values anyways, and this patch just makes it official
by removing ThisTDZMode.
This patch also cleans up caching keys. We extract SourceCodeFlags
from SourceCodeKey and use it in EvalCodeCache. It correctly
contains needed cache attributes: EvalContextType, DerivedContextType,
etc. Here, we still use specialized keys for EvalCodeCache instead
of SourceCodeKey for performance; it does not include name String and
does not allocate SourceCode.
- bytecode/EvalCodeCache.h:
(JSC::EvalCodeCache::CacheKey::CacheKey):
(JSC::EvalCodeCache::CacheKey::operator==):
(JSC::EvalCodeCache::CacheKey::Hash::equal):
(JSC::EvalCodeCache::tryGet):
(JSC::EvalCodeCache::getSlow):
- bytecompiler/NodesCodegen.cpp:
(JSC::ThisNode::emitBytecode): Deleted.
- debugger/DebuggerCallFrame.cpp:
(JSC::DebuggerCallFrame::evaluateWithScopeExtension):
- interpreter/Interpreter.cpp:
(JSC::eval):
- parser/ASTBuilder.h:
(JSC::ASTBuilder::createThisExpr):
- parser/NodeConstructors.h:
(JSC::ThisNode::ThisNode):
- parser/Nodes.h:
- parser/Parser.cpp:
(JSC::Parser<LexerType>::Parser):
(JSC::Parser<LexerType>::parsePrimaryExpression):
- parser/Parser.h:
(JSC::parse):
- parser/ParserModes.h:
- parser/SourceCodeKey.h:
(JSC::SourceCodeFlags::SourceCodeFlags):
(JSC::SourceCodeFlags::operator==):
(JSC::SourceCodeKey::SourceCodeKey):
(JSC::SourceCodeKey::Hash::hash):
(JSC::SourceCodeKey::Hash::equal):
(JSC::SourceCodeKey::HashTraits::isEmptyValue):
(JSC::SourceCodeKeyHash::hash): Deleted.
(JSC::SourceCodeKeyHash::equal): Deleted.
(JSC::SourceCodeKeyHashTraits::isEmptyValue): Deleted.
- parser/SyntaxChecker.h:
(JSC::SyntaxChecker::createThisExpr):
- runtime/CodeCache.cpp:
(JSC::CodeCache::getGlobalCodeBlock):
(JSC::CodeCache::getProgramCodeBlock):
(JSC::CodeCache::getEvalCodeBlock):
(JSC::CodeCache::getModuleProgramCodeBlock):
(JSC::CodeCache::getFunctionExecutableFromGlobalCode):
- runtime/CodeCache.h:
- runtime/Executable.cpp:
(JSC::EvalExecutable::create):
- runtime/Executable.h:
- runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::createEvalCodeBlock):
- runtime/JSGlobalObject.h:
- runtime/JSGlobalObjectFunctions.cpp:
(JSC::globalFuncEval):
- tests/stress/code-cache-incorrect-caching.js: Added.
(shouldBe):
(hello):
(catch):
(shouldBe.test.hello):
(globalEval.ok):
(global.hello.hello):
- 2:32 AM WebKitGTK/2.12.x edited by
- (diff)
- 1:56 AM Changeset in webkit [201327] by
-
- 1 copy in releases/WebKitGTK/webkit-2.12.3
WebKitGTK+ 2.12.3
- 1:55 AM Changeset in webkit [201326] by
-
- 4 edits in releases/WebKitGTK/webkit-2.12
Unreviewed. Update OptionsGTK.cmake and NEWS for 2.12.3 release.
.:
- Source/cmake/OptionsGTK.cmake: Bump version numbers.
Source/WebKit2:
- gtk/NEWS: Add release notes for 2.12.3.
- 1:55 AM Changeset in webkit [201325] by
-
- 18 edits in trunk
[css-grid] Fix behavior of flexible track breadths
https://bugs.webkit.org/show_bug.cgi?id=157834
Reviewed by Sergio Villar Senin.
This patch is fixing 2 issues that are interrelated:
Source/WebCore:
1) Flex sizes are invalid as min track sizing function.
The syntax has been recently updated on the spec:
<track-size> =
<track-breadth> |
minmax( <inflexible-breadth> , <track-breadth> )
2) Flex sizes outside minmax() behave as auto minimum.
Flex sizes outside minmax() were previously behaving like
minimum and maximum (e.g. 1fr => minmax(1fr, 1fr)).
However the spec changed and now this would be invalid,
so they should behave like auto minimum (e.g. minmax(auto, 1fr)).
- css/CSSParser.cpp:
(WebCore::CSSParser::parseGridTrackSize): Call parseGridBreadth()
for min sizing function using "InflexibleSizeOnly" restriction
when needed.
(WebCore::CSSParser::parseGridBreadth): Add check for
"InflexibleSizeOnly" resctriction.
- css/CSSParser.h: Add new type of restriction "InflexibleSizeOnly".
- rendering/RenderGrid.cpp:
(WebCore::RenderGrid::gridTrackSize): Add new condition to make
|minTrackBreadth| auto if it was a flex size.
LayoutTests:
1) Flex sizes are invalid as min track sizing function.
2) Flex sizes outside minmax() behave as auto minimum.
The patch includes new test cases checking specifically these 2 issues.
In addition several tests results have been updated to reflect
the new behavior. Also, some cases that are now invalid and
were not testing anything new have been removed.
- fast/css-grid-layout/flex-and-content-sized-resolution-columns-expected.txt:
- fast/css-grid-layout/flex-and-content-sized-resolution-columns.html:
- fast/css-grid-layout/flex-content-resolution-columns-expected.txt:
- fast/css-grid-layout/flex-content-resolution-columns.html:
- fast/css-grid-layout/flex-content-resolution-rows-expected.txt:
- fast/css-grid-layout/flex-content-resolution-rows.html:
- fast/css-grid-layout/grid-columns-rows-get-set-expected.txt:
- fast/css-grid-layout/grid-gutters-and-flex-content-expected.txt:
- fast/css-grid-layout/grid-gutters-and-flex-content.html:
- fast/css-grid-layout/grid-preferred-logical-widths.html:
- fast/css-grid-layout/non-grid-columns-rows-get-set-expected.txt:
- fast/css-grid-layout/resources/grid-columns-rows-get-set.js:
- fast/css-grid-layout/resources/non-grid-columns-rows-get-set.js:
- 12:35 AM Changeset in webkit [201324] by
-
- 22 edits1 move4 adds in trunk
[Fetch API] Implement Fetch redirect mode
https://bugs.webkit.org/show_bug.cgi?id=157837
Reviewed by Alex Christensen.
LayoutTests/imported/w3c:
- web-platform-tests/fetch/api/redirect/redirect-location-expected.txt:
- web-platform-tests/fetch/api/redirect/redirect-location.js:
- web-platform-tests/fetch/api/redirect/redirect-method.js:
- web-platform-tests/fetch/api/redirect/redirect-method-expected.txt:
- web-platform-tests/fetch/api/redirect/redirect-mode-expected.txt:
Source/WebCore:
Implementing step 5 of https://fetch.spec.whatwg.org/#http-fetch.
Making ResourceLoaderOptions include FetchOptions.
This allows SubresourceLoader to follow or not redirections based on that option.
CachedResource is made responsible to handle the type of the response (opaqueredirect, opaque, cors, basic...).
If redirection is not to be followed, either an error is returned or an empty response is returned.
Moved Response type and redirected flag from FetchResponse to ResourceResponse.
This allows CachedResource to easily communicate that information to FetchResponse.
Made some clean-up refactoring in ThreadableLoaderOptions.
http/tests/fetch/caching-with-different-options.html ensures that
caching at CachedResourceLoader will not have bad effects on fetch.
Covered by updated and rebased tests.
- Modules/fetch/FetchLoader.cpp:
(WebCore::FetchLoader::start):
- Modules/fetch/FetchResponse.cpp:
(WebCore::FetchResponse::error):
(WebCore::FetchResponse::redirect):
(WebCore::FetchResponse::FetchResponse):
(WebCore::FetchResponse::clone):
(WebCore::FetchResponse::startFetching):
- Modules/fetch/FetchResponse.h:
- WebCore.xcodeproj/project.pbxproj:
- loader/FetchOptions.h: Moved from Source/WebCore/Modules/fetch/FetchOptions.h.
- loader/ResourceLoaderOptions.h:
(WebCore::ResourceLoaderOptions::fetchOptions):
(WebCore::ResourceLoaderOptions::setFetchOptions):
- loader/SubresourceLoader.cpp:
(WebCore::SubresourceLoader::willSendRequestInternal):
- loader/ThreadableLoader.cpp:
- loader/ThreadableLoader.h:
- loader/cache/CachedResource.cpp:
(WebCore::CachedResource::setResponse):
- loader/cache/CachedResource.h:
(WebCore::CachedResource::setOpaqueRedirect):
- platform/network/ResourceResponseBase.cpp:
(WebCore::ResourceResponseBase::adopt):
(WebCore::ResourceResponseBase::copyData):
- platform/network/ResourceResponseBase.h:
(WebCore::ResourceResponseBase::type):
(WebCore::ResourceResponseBase::setType):
(WebCore::ResourceResponseBase::encode):
(WebCore::ResourceResponseBase::decode):
LayoutTests:
- http/tests/fetch/caching-with-different-options-expected.txt: Added.
- http/tests/fetch/caching-with-different-options.html: Added.
- http/tests/fetch/resources/redirect-with-cache.php: Added.
- platform/gtk/imported/w3c/web-platform-tests/fetch/api/redirect/redirect-location-expected.txt:
- platform/gtk/imported/w3c/web-platform-tests/fetch/api/redirect/redirect-method-expected.txt:
May 23, 2016:
- 11:29 PM Changeset in webkit [201323] by
-
- 1 edit4 adds in trunk/LayoutTests
Add a few initiator tests to resource timing.
https://bugs.webkit.org/show_bug.cgi?id=157986
Reviewed by Darin Adler.
Adds tests that make sure that when a resource is requested multiple times by different
elements, its initiator type remain the first one that triggered the fetch.
- http/tests/performance/performance-resource-timing-initiator-css-expected.txt: Added.
- http/tests/performance/performance-resource-timing-initiator-css.html: Added.
- http/tests/performance/performance-resource-timing-initiator-no-override-expected.txt: Added.
- http/tests/performance/performance-resource-timing-initiator-no-override.html: Added.
- 11:24 PM Changeset in webkit [201322] by
-
- 30 edits1 add in trunk/Source
Assertion failure for Reflect.get with Proxy and primitive value as explicit receiver
https://bugs.webkit.org/show_bug.cgi?id=157080
Reviewed by Saam Barati.
Source/JavaScriptCore:
In custom accessor getter, the argument "thisValue" can be altered by using
Reflect.get.
In this patch, we add a new parameter, "slotBase". This represents the base value offering
this custom getter. And use it in ProxyObject's performGet custom accessor getter.
- API/JSCallbackObject.h:
- API/JSCallbackObjectFunctions.h:
(JSC::JSCallbackObject<Parent>::staticFunctionGetter):
(JSC::JSCallbackObject<Parent>::callbackGetter):
- bytecode/PolymorphicAccess.cpp:
(JSC::AccessCase::generateImpl):
In PolymorphicAccess case, the thisValue and the slotBase are always cells.
This is because IC is enabled in the case that the base value is a cell.
And slotBase is always on the prototype chain from this base value.
- jit/CCallHelpers.h:
(JSC::CCallHelpers::setupArgumentsWithExecState):
- jsc.cpp:
(WTF::CustomGetter::customGetter):
(WTF::RuntimeArray::lengthGetter):
- runtime/CustomGetterSetter.cpp:
(JSC::callCustomSetter):
- runtime/JSBoundSlotBaseFunction.cpp:
(JSC::boundSlotBaseFunctionCall):
- runtime/JSFunction.cpp:
(JSC::JSFunction::argumentsGetter):
(JSC::JSFunction::callerGetter):
- runtime/JSFunction.h:
- runtime/JSModuleNamespaceObject.cpp:
(JSC::callbackGetter):
- runtime/PropertySlot.cpp:
(JSC::PropertySlot::customGetter):
- runtime/PropertySlot.h:
- runtime/ProxyObject.cpp:
(JSC::performProxyGet):
- runtime/RegExpConstructor.cpp:
(JSC::regExpConstructorDollar):
(JSC::regExpConstructorInput):
(JSC::regExpConstructorMultiline):
(JSC::regExpConstructorLastMatch):
(JSC::regExpConstructorLastParen):
(JSC::regExpConstructorLeftContext):
(JSC::regExpConstructorRightContext):
(JSC::regExpConstructorDollar1): Deleted.
(JSC::regExpConstructorDollar2): Deleted.
(JSC::regExpConstructorDollar3): Deleted.
(JSC::regExpConstructorDollar4): Deleted.
(JSC::regExpConstructorDollar5): Deleted.
(JSC::regExpConstructorDollar6): Deleted.
(JSC::regExpConstructorDollar7): Deleted.
(JSC::regExpConstructorDollar8): Deleted.
(JSC::regExpConstructorDollar9): Deleted.
- tests/stress/proxy-get-with-primitive-receiver.js: Added.
(shouldBe):
Source/WebCore:
- bindings/js/JSDOMBinding.h:
(WebCore::nonCachingStaticFunctionGetter):
- bindings/js/JSDOMWindowCustom.cpp:
(WebCore::jsDOMWindowWebKit):
- bindings/js/JSPluginElementFunctions.cpp:
(WebCore::pluginElementPropertyGetter):
- bindings/js/JSPluginElementFunctions.h:
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateHeader):
(GenerateImplementation):
- bridge/runtime_array.cpp:
(JSC::RuntimeArray::lengthGetter):
- bridge/runtime_array.h:
- bridge/runtime_method.cpp:
(JSC::RuntimeMethod::lengthGetter):
- bridge/runtime_method.h:
- bridge/runtime_object.cpp:
(JSC::Bindings::RuntimeObject::fallbackObjectGetter):
(JSC::Bindings::RuntimeObject::fieldGetter):
(JSC::Bindings::RuntimeObject::methodGetter):
- bridge/runtime_object.h:
Source/WebKit2:
- WebProcess/Plugins/Netscape/JSNPObject.cpp:
(WebKit::JSNPObject::propertyGetter):
(WebKit::JSNPObject::methodGetter):
- WebProcess/Plugins/Netscape/JSNPObject.h:
- 11:15 PM Changeset in webkit [201321] by
-
- 3 edits in branches/safari-602.1.32-branch/Source/WebCore
Merge r200965. rdar://problem/26237934
- 10:58 PM Changeset in webkit [201320] by
-
- 5 edits in branches/safari-602.1.32.5-branch/Source
Versioning.
- 10:57 PM Changeset in webkit [201319] by
-
- 5 edits in branches/safari-602.1.32-branch/Source
Versioning.
- 10:34 PM Changeset in webkit [201318] by
-
- 23 edits in trunk/Source/WebCore
Modernize CSS code
https://bugs.webkit.org/show_bug.cgi?id=157875
Reviewed by Chris Dumez.
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateImplementation):
(GenerateParametersCheck):
- bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:
(WebCore::jsTestMediaQueryListListenerPrototypeFunctionMethod):
- bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::JSTestObjConstructor::construct):
(WebCore::setJSTestObjPutForwardsNullableAttribute):
(WebCore::jsTestObjPrototypeFunctionMethodWithCallbackArg):
(WebCore::jsTestObjPrototypeFunctionMethodWithNonCallbackArgAndCallbackArg):
(WebCore::jsTestObjPrototypeFunctionMethodWithCallbackFunctionArg):
(WebCore::jsTestObjPrototypeFunctionMethodWithNonCallbackArgAndCallbackFunctionArg):
(WebCore::jsTestObjConstructorFunctionStaticMethodWithCallbackArg):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod5):
- bindings/scripts/test/JS/JSTestTypedefs.cpp:
(WebCore::JSTestTypedefsConstructor::construct):
- css/CSSBasicShapes.cpp:
(WebCore::serializePositionOffset):
(WebCore::buildSerializablePositionOffset):
(WebCore::CSSBasicShapeCircle::cssText):
(WebCore::CSSBasicShapeEllipse::cssText):
- css/CSSCalculationValue.cpp:
(WebCore::determineCategory):
(WebCore::CSSCalcExpressionNodeParser::parseValue):
- css/CSSMediaRule.cpp:
(WebCore::CSSMediaRule::media):
- css/CSSMediaRule.h:
- css/CSSOMUtils.h:
- css/CSSParser.cpp:
(WebCore::CSSParser::createImportRule):
(WebCore::CSSParser::createMediaRule):
- css/CSSReflectValue.h:
- css/CSSStyleSheet.cpp:
(WebCore::CSSStyleSheet::setDisabled):
(WebCore::CSSStyleSheet::setMediaQueries):
(WebCore::CSSStyleSheet::insertRule):
(WebCore::CSSStyleSheet::deleteRule):
(WebCore::CSSStyleSheet::isLoading):
(WebCore::CSSStyleSheet::media):
(WebCore::CSSStyleSheet::parentStyleSheet):
(WebCore::CSSStyleSheet::ownerDocument):
(WebCore::CSSStyleSheet::clearChildRuleCSSOMWrappers):
(WebCore::CSSStyleSheet::RuleMutationScope::RuleMutationScope):
- css/CSSStyleSheet.h:
- css/PropertySetCSSStyleDeclaration.cpp:
- css/StyleRule.cpp:
(WebCore::StyleRuleBase::createCSSOMWrapper):
(WebCore::StyleRuleBase::destroy):
(WebCore::StyleRuleGroup::wrapperRemoveRule):
(WebCore::StyleRuleMedia::StyleRuleMedia):
- css/StyleRule.h:
(WebCore::StyleRuleBase::deref):
(WebCore::StyleRuleBase::StyleRuleBase):
(WebCore::StyleRuleMedia::create):
(WebCore::StyleRuleMedia::mediaQueries):
(WebCore::StyleRuleMedia::copy):
(isType):
- css/StyleRuleImport.cpp:
(WebCore::StyleRuleImport::create):
(WebCore::StyleRuleImport::StyleRuleImport):
- css/StyleRuleImport.h:
- css/StyleSheetContents.cpp:
(WebCore::StyleSheetContents::isCacheable):
(WebCore::StyleSheetContents::parserAppendRule):
(WebCore::StyleSheetContents::ruleAt):
(WebCore::StyleSheetContents::parserSetEncodingFromCharsetRule):
(WebCore::StyleSheetContents::wrapperInsertRule):
- css/StyleSheetContents.h:
(WebCore::StyleSheetContents::hasSyntacticallyValidCSSHeader):
(WebCore::StyleSheetContents::parserSetUsesRemUnits):
(WebCore::StyleSheetContents::parserSetUsesStyleBasedEditability):
(WebCore::StyleSheetContents::copy):
- dom/InlineStyleSheetOwner.cpp:
(WebCore::InlineStyleSheetOwner::createSheet):
- inspector/InspectorStyleSheet.cpp:
- 10:19 PM Changeset in webkit [201317] by
-
- 1 copy in branches/safari-602.1.32.5-branch
New Branch.
- 8:41 PM Changeset in webkit [201316] by
-
- 2 edits in trunk/LayoutTests
Skip fast/table/neighboring-cells-when-collapsed-border-changes on WK1 for now.
Unreviewed.
- platform/mac-wk1/TestExpectations:
- 8:27 PM Changeset in webkit [201315] by
-
- 2 edits in trunk/Source/JavaScriptCore
REGRESSION (196374): deleting a global property is expensive
https://bugs.webkit.org/show_bug.cgi?id=158005
Reviewed by Chris Dumez.
- runtime/JSObject.cpp:
(JSC::JSObject::deleteProperty): We only need to reify static properties
if the name being deleted matches a static property. Otherwise, we can
be sure that delete won't observe any static properties.
- 7:10 PM Changeset in webkit [201314] by
-
- 2 edits in trunk/Source/WTF
Speed up move of vectors of POD types that have an inline buffer
https://bugs.webkit.org/show_bug.cgi?id=158003
Reviewed by Benjamin Poulain.
When moving a vector of POD types that have an inline buffer, we would
call std::swap() on the inline buffers. This unnecessarily slow because:
- It does not consider the vector size, and therefore may end up doing more work than necessary when the inline buffer is not full.
- In the "move" case, the destination buffer is completely empty so we don't really want a swap. We merely want the move the content of the source's inline buffer into the destination's one.
Instead of calling std::swap(), we now call swapInlineBuffers() which
was already used for non-POD types. swapInlineBuffers() will do just
what we want in the "move" case because swapBound is going to be 0.
As a result, we will only move the content of the source buffer into
the destination one. Also swapInlineBuffers() is aware of the source
vector's size so it will only move what's strictly needed.
This seems to be a 2% progression on Dromaeo DOM attributes test.
- wtf/Vector.h:
(WTF::VectorBuffer::swapInlineBuffer):
- 6:54 PM Changeset in webkit [201313] by
-
- 2 edits in trunk/Source/ThirdParty
woff2_dec.cc triggers -Wsign-compare, -Wunused-but-set-variable
https://bugs.webkit.org/show_bug.cgi?id=157732
Reviewed by Darin Adler.
- woff2/CMakeLists.txt:
- 6:53 PM Changeset in webkit [201312] by
-
- 3 edits2 adds in trunk
Changing border color and size simultaneously fails to repaint.
https://bugs.webkit.org/show_bug.cgi?id=157967
<rdar://problem/26423918>
Reviewed by David Hyatt.
This patch ensures that the neighboring tables cells are dirtied when collapsed border change requires layout.
Source/WebCore:
Test: fast/table/neighboring-cells-when-collapsed-border-changes.html
- rendering/RenderTable.cpp:
(WebCore::markCellDirtyWhenCollapsedBorderChanges):
(WebCore::RenderTable::invalidateCollapsedBorders):
LayoutTests:
- fast/table/neighboring-cells-when-collapsed-border-changes-expected.html: Added.
- fast/table/neighboring-cells-when-collapsed-border-changes.html: Added.
- 6:50 PM Changeset in webkit [201311] by
-
- 2 edits in trunk/Source/WebCore
Avoid unnecessary call to Document::completeURL() in HTMLLinkElement::process()
https://bugs.webkit.org/show_bug.cgi?id=157993
Reviewed by Ryosuke Niwa.
Avoid unnecessary call to Document::completeURL() in HTMLLinkElement::process().
The call to getNonEmptyURLAttribute() already calls Document::completeURL()
internally so we can just reuse the returned URL.
- html/HTMLLinkElement.cpp:
(WebCore::HTMLLinkElement::process):
- 6:03 PM Changeset in webkit [201310] by
-
- 3 edits6 adds in trunk
Null popstate event fired when navigating back to a cached page with a stateless history entry
https://bugs.webkit.org/show_bug.cgi?id=157963
<rdar://problem/23414840>
Source/WebCore:
Popstate events are not fired when WebKit navigates back to a history entry that doesn't
have a state object if the entry's page is not cached. However, we fire popstate events
unconditionally if the page is cached. This results in inconsistent behavior between
initial navigations and cached navigations. Align the behavior of initial and cached
navigations so that we produce consistent events.
Reviewed by Brent Fulgham.
Tests: fast/loader/stateobjects/no-popstate-when-back-to-stateless-entry-with-page-cache.html
fast/loader/stateobjects/no-popstate-when-back-to-stateless-entry.html
- history/CachedFrame.cpp:
(WebCore::CachedFrameBase::restore):
LayoutTests:
Reviewed by Brent Fulgham.
- fast/loader/stateobjects/no-popstate-when-back-to-stateless-entry-expected.txt: Added.
- fast/loader/stateobjects/no-popstate-when-back-to-stateless-entry-with-page-cache-expected.txt: Added.
- fast/loader/stateobjects/no-popstate-when-back-to-stateless-entry-with-page-cache.html: Added.
- fast/loader/stateobjects/no-popstate-when-back-to-stateless-entry.html: Added.
- fast/loader/stateobjects/resources/no-popstate-when-back-to-stateless-entry-1.html: Added.
- fast/loader/stateobjects/resources/no-popstate-when-back-to-stateless-entry-2.html: Added.
- 5:50 PM Changeset in webkit [201309] by
-
- 2 edits in trunk/Websites/perf.webkit.org
Build fix after r201307.
- public/v3/pages/chart-pane.js:
(ChartPane.prototype.serializeState):
- 5:35 PM Changeset in webkit [201308] by
-
- 2 edits in trunk/LayoutTests
Marking inspector/console/console-time.html as a flaky timeout
https://bugs.webkit.org/show_bug.cgi?id=158006
Unreviewed test gardening.
- platform/mac/TestExpectations:
- 5:24 PM Changeset in webkit [201307] by
-
- 3 edits in trunk/Websites/perf.webkit.org
Some applications truncates the last closing parenthesis in perf dashboard URL
https://bugs.webkit.org/show_bug.cgi?id=157976
Reviewed by Tim Horton.
Unfortunately, different applications use different heuristics to determine the end of each URL. Two trailing
parentheses, for example, is just fine in Radar as well as Apple Mail if the URL is short enough. Using other
characters such as ] and } wouldn't work either because they would be %-escaped. At that point, we might as well
as %-escape everything.
Work around the bug by parsing the URL as if it had one extra ')' if the parsing had failed. Also shorten the charts
page's URL by avoid emitting "-null" for each pane when the pane doesn't have a currently selected point or selection.
This improves the odds of the entire URL being recognized by various applications.
We could, in theory, implement some sort of a URL shorter but that can wait until when we support real user accounts.
- public/v3/pages/chart-pane.js:
(ChartPane.prototype.serializeState): Don't serialize the selection or the current point if nothing is selected.
- public/v3/pages/page-router.js:
(PageRouter.prototype._deserializeHashQueryValue): Try parsing the value again with one extra ] at the end if
the JSON parsing had failed.
- 5:22 PM Changeset in webkit [201306] by
-
- 2 edits in trunk/LayoutTests
Marking mathml/wbr-in-mroot-crash.html as a timeout on mac release
https://bugs.webkit.org/show_bug.cgi?id=157990
Unreviewed test gardening.
- platform/mac/TestExpectations:
- 5:17 PM Changeset in webkit [201305] by
-
- 49 edits in trunk/Source
Generate bindings code for EventTarget.addEventListener() / removeEventListener()
https://bugs.webkit.org/show_bug.cgi?id=157882
Reviewed by Darin Adler.
Generate bindings code for EventTarget.addEventListener() / removeEventListener()
instead of hardcoding them in the bindings generator.
Source/WebCore:
No new tests, rebaselined existing test, no web-exposed behavior change.
- Modules/webaudio/AudioScheduledSourceNode.cpp:
(WebCore::AudioScheduledSourceNode::addEventListener):
(WebCore::AudioScheduledSourceNode::removeEventListener):
- Modules/webaudio/AudioScheduledSourceNode.h:
- Modules/webaudio/ScriptProcessorNode.cpp:
(WebCore::ScriptProcessorNode::addEventListener):
(WebCore::ScriptProcessorNode::removeEventListener):
- Modules/webaudio/ScriptProcessorNode.h:
- bindings/gobject/GObjectEventListener.cpp:
(WebCore::GObjectEventListener::operator==):
- bindings/gobject/GObjectEventListener.h:
- bindings/js/JSEventListener.cpp:
(WebCore::JSEventListener::operator==):
(WebCore::eventHandlerAttribute): Deleted.
- bindings/js/JSEventListener.h:
(WebCore::JSEventListener::create):
(WebCore::JSEventListener::cast): Deleted.
(WebCore::JSEventListener::jsFunction): Deleted.
- bindings/objc/ObjCEventListener.h:
- bindings/objc/ObjCEventListener.mm:
(WebCore::ObjCEventListener::operator==):
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateImplementation):
(JSValueToNative):
(GetParentClassName): Deleted.
(GetCallbackClassName): Deleted.
(GetJSCallbackDataType): Deleted.
- dom/EventListener.h:
- dom/EventListenerMap.cpp:
(WebCore::addListenerToVector):
(WebCore::EventListenerMap::add):
(WebCore::removeListenerFromVector):
(WebCore::EventListenerMap::remove):
(WebCore::copyListenersNotCreatedFromMarkupToTarget):
- dom/EventListenerMap.h:
- dom/EventTarget.cpp:
(WebCore::EventTarget::addEventListener):
(WebCore::EventTarget::addEventListenerForBindings):
(WebCore::EventTarget::removeEventListenerForBindings):
(WebCore::EventTarget::removeEventListener):
(WebCore::EventTarget::setAttributeEventListener):
(WebCore::EventTarget::clearAttributeEventListener):
- dom/EventTarget.h:
- dom/EventTarget.idl:
- dom/MessagePort.cpp:
(WebCore::MessagePort::addEventListener):
- dom/MessagePort.h:
- dom/Node.cpp:
(WebCore::tryAddEventListener):
(WebCore::Node::addEventListener):
(WebCore::tryRemoveEventListener):
(WebCore::Node::removeEventListener):
- dom/Node.h:
- dom/RegisteredEventListener.h:
(WebCore::RegisteredEventListener::RegisteredEventListener):
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::addEventListener):
(WebCore::HTMLMediaElement::removeEventListener):
- html/HTMLMediaElement.h:
- html/ImageDocument.cpp:
(WebCore::ImageDocument::createDocumentStructure):
(WebCore::ImageEventListener::operator==):
- html/shadow/MediaControlsApple.cpp:
(WebCore::MediaControlsApple::showClosedCaptionTrackList):
(WebCore::MediaControlsApple::hideClosedCaptionTrackList):
(WebCore::MediaControlsAppleEventListener::operator==):
- html/shadow/MediaControlsApple.h:
- inspector/InspectorIndexedDBAgent.cpp:
- page/DOMWindow.cpp:
(WebCore::DOMWindow::addEventListener):
(WebCore::DOMWindow::removeEventListener):
- page/DOMWindow.h:
- platform/cocoa/WebPlaybackSessionModelMediaElement.h:
- platform/cocoa/WebVideoFullscreenModelVideoElement.h:
- svg/SVGElement.cpp:
(WebCore::SVGElement::addEventListener):
(WebCore::SVGElement::removeEventListener):
- svg/SVGElement.h:
- svg/SVGTRefElement.cpp:
(WebCore::SVGTRefTargetEventListener::attach):
(WebCore::SVGTRefTargetEventListener::detach):
(WebCore::SVGTRefTargetEventListener::operator==):
- svg/animation/SVGSMILElement.cpp:
(WebCore::ConditionEventListener::operator==):
(WebCore::SVGSMILElement::connectConditions):
(WebCore::SVGSMILElement::disconnectConditions):
Source/WebKit/win:
- DOMEventsClasses.cpp:
(WebEventListener::operator==):
- DOMEventsClasses.h:
Source/WebKit2:
- WebProcess/Plugins/PDF/PDFPluginAnnotation.h:
- WebProcess/Plugins/PDF/PDFPluginAnnotation.mm:
(WebKit::PDFPluginAnnotation::attach):
(WebKit::PDFPluginAnnotation::~PDFPluginAnnotation):
- WebProcess/Plugins/PDF/PDFPluginPasswordField.mm:
(WebKit::PDFPluginPasswordField::~PDFPluginPasswordField):
(WebKit::PDFPluginPasswordField::createAnnotationElement):
- WebProcess/Plugins/PDF/PDFPluginTextAnnotation.mm:
(WebKit::PDFPluginTextAnnotation::~PDFPluginTextAnnotation):
(WebKit::PDFPluginTextAnnotation::createAnnotationElement):
- 4:33 PM Changeset in webkit [201304] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Split console navigation bar doesn't wrap as expected
https://bugs.webkit.org/show_bug.cgi?id=157950
<rdar://problem/26395573>
Reviewed by Timothy Hatcher.
- UserInterface/Views/Main.css:
(#split-content-browser > .navigation-bar .item):
Fix the split console and don't touch any other navigation bars.
- 4:19 PM Changeset in webkit [201303] by
-
- 2 edits in trunk/Source/WebCore
Fix undefined behavior introduced in r201290.
https://bugs.webkit.org/show_bug.cgi?id=157961
Reviewed by Alex Christensen.
The evaluation order of function arguments is undefined so it is unsafe to
copyRef() and WTFMove() the same parameter in a function call.
- css/CSSBasicShapes.h:
- 4:14 PM Changeset in webkit [201302] by
-
- 4 edits in trunk/Source/WebCore
Speculative fix for:
Modern IDB: Some blob tests ASSERT sometimes on the bots.
https://bugs.webkit.org/show_bug.cgi?id=157525
Reviewed by Alex Christensen.
No new tests (Should fix existing flakiness, not reproducibly testable).
For all of the lambdas involved in this operation, explicitly WTFMove all of the arguments around.
Critically, this includes the RefPtr<TransactionOperation> protector as well as the
std::function<void ()> completionHandler(s).
By doing so, this removes the possibility of a race between the background thread and the main thread
tearing down the TransactionOperation, guaranteeing that it is torn down on its original thread.
- Modules/indexeddb/IDBTransaction.cpp:
(WebCore::IDBTransaction::putOrAddOnServer):
- bindings/js/SerializedScriptValue.cpp:
(WebCore::SerializedScriptValue::writeBlobsToDiskForIndexedDB):
- platform/network/BlobRegistryImpl.cpp:
(WebCore::BlobRegistryImpl::writeBlobsToTemporaryFiles):
- 3:46 PM Changeset in webkit [201301] by
-
- 2 edits1 add in trunk/Source/JavaScriptCore
The baseline JIT crashes when compiling "(1,1)/1"
https://bugs.webkit.org/show_bug.cgi?id=157933
Reviewed by Benjamin Poulain.
op_div in the baseline JIT needed to better handle when both the lhs
and rhs are constants. It needs to make sure to load either the lhs or
the rhs into a register since the div generator can't handle both
the lhs and rhs being constants.
- jit/JITArithmetic.cpp:
(JSC::JIT::emit_op_div):
- tests/stress/jit-gracefully-handle-double-constants-in-math-operators.js: Added.
(assert):
(test):
- 3:37 PM Changeset in webkit [201300] by
-
- 3 edits2 deletes in trunk
Unreviewed, rolling out r201296.
https://bugs.webkit.org/show_bug.cgi?id=158002
The LayoutTest added with this change is failing on mac-wk1
(Requested by ryanhaddad on #webkit).
Reverted changeset:
"Changing border color and size simultaneously fails to
repaint."
https://bugs.webkit.org/show_bug.cgi?id=157967
http://trac.webkit.org/changeset/201296
Patch by Commit Queue <commit-queue@webkit.org> on 2016-05-23
- 3:07 PM Changeset in webkit [201299] by
-
- 2 edits in trunk/Source/WebCore
Missing/Incomplete timestamp for inline Audio player in ePub book
https://bugs.webkit.org/show_bug.cgi?id=157998
<rdar://problem/25858437>
Reviewed by Jon Lee and Tim Horton.
On iOS it is rare to apply a text-zoom (Safari does not provide
UI for it). However, iBooks uses text-zoom to increase the font
size. This causes the time displays in the media controls to
overflow their containers and be clipped.
The solution is to simply reset the text zoom for the media controls,
which means the time displays will always be a constant size.
- Modules/mediacontrols/mediaControlsiOS.css:
(audio::-webkit-media-controls-time-remaining-display):
- 3:06 PM Changeset in webkit [201298] by
-
- 12 edits in trunk/Source/WebKit2
Need SPI for clients to require a user action to get an editing controls
manager
https://bugs.webkit.org/show_bug.cgi?id=157992
-and corresponding-
rdar://problem/26379927
Reviewed by Tim Horton.
New SPI _setRequiresUserActionForEditingControlsManager. The SPI defaults to
False, which means that by default there is no user action requirement to
have an editing controls manager. The SPI is on WKViewPrivate and
WKWebViewConfigurationPrivate, and it’s implemented in WebViewImpl.
- UIProcess/API/Cocoa/WKViewPrivate.h:
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _initializeWithConfiguration:]):
- UIProcess/API/Cocoa/WKWebViewConfiguration.mm:
(-[WKWebViewConfiguration init]):
(-[WKWebViewConfiguration copyWithZone:]):
(-[WKWebViewConfiguration _requiresUserActionForEditingControlsManager]):
(-[WKWebViewConfiguration _setRequiresUserActionForEditingControlsManager:]):
- UIProcess/API/Cocoa/WKWebViewConfigurationPrivate.h:
- UIProcess/API/mac/WKView.mm:
(-[WKView _requiresUserActionForEditingControlsManager]):
(-[WKView _setRequiresUserActionForEditingControlsManager:]):
- UIProcess/Cocoa/WebViewImpl.h:
(WebKit::WebViewImpl::setRequiresUserActionForEditingControlsManager):
(WebKit::WebViewImpl::requiresUserActionForEditingControlsManager):
New message allows the WebProcess to tell the UI process whether the current
web page has had any selection changes based on user interaction.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::setHasHadSelectionChangesFromUserInteraction):
- UIProcess/WebPageProxy.h:
(WebKit::WebPageProxy::hasHadSelectionChangesFromUserInteraction):
- UIProcess/WebPageProxy.messages.in:
m_userIsInteracting m_hasFocusedDueToUserInteraction used to be iOS only, but
now we want to track them for Mac as well.
- WebProcess/WebPage/WebPage.cpp:
Handling mouse events and key events will toggle m_userIsInteracting.
(WebKit::WebPage::mouseEvent):
(WebKit::WebPage::keyEvent):
m_userIsInteracting is no longer iOS-only.
(WebKit::WebPage::setInitialFocus):
Send a message to the UI process on page transition to re-set
hasHadSelectionChangesFromUserInteraction to false.
(WebKit::WebPage::didStartPageTransition):
Send a message to the UI process if this is the first selection change to
happen as a result of a user action.
(WebKit::WebPage::didChangeSelection):
- WebProcess/WebPage/WebPage.h:
- 2:55 PM Changeset in webkit [201297] by
-
- 2 edits in trunk/LayoutTests
Marking inspector/unit-tests/heap-snapshot-collection-event.html as a flaky timeout.
https://bugs.webkit.org/show_bug.cgi?id=157999
Unreviewed test gardening.
- platform/mac/TestExpectations:
- 2:04 PM Changeset in webkit [201296] by
-
- 3 edits2 adds in trunk
Changing border color and size simultaneously fails to repaint.
https://bugs.webkit.org/show_bug.cgi?id=157967
<rdar://problem/26423918>
Reviewed by David Hyatt.
This patch ensures that the neighboring tables cells are dirtied when collapsed border change requires layout.
Source/WebCore:
Test: fast/table/neighboring-cells-when-collapsed-border-changes.html
- rendering/RenderTable.cpp:
(WebCore::markCellDirtyWhenCollapsedBorderChanges):
(WebCore::RenderTable::invalidateCollapsedBorders):
LayoutTests:
- fast/table/neighboring-cells-when-collapsed-border-changes-expected.html: Added.
- fast/table/neighboring-cells-when-collapsed-border-changes.html: Added.
- 1:54 PM Changeset in webkit [201295] by
-
- 4 edits in trunk/Source/WebKit2
Add logging for NSURLSession calls
https://bugs.webkit.org/show_bug.cgi?id=157996
Reviewed by Brady Eidson.
- NetworkProcess/cocoa/NetworkDataTaskCocoa.mm:
(WebKit::NetworkDataTask::NetworkDataTask):
- NetworkProcess/cocoa/NetworkSessionCocoa.mm:
(toNSURLSessionResponseDisposition):
(-[WKNetworkSessionDelegate URLSession:task:willPerformHTTPRedirection:newRequest:completionHandler:]):
(-[WKNetworkSessionDelegate URLSession:task:_schemeUpgraded:completionHandler:]):
(-[WKNetworkSessionDelegate URLSession:dataTask:willCacheResponse:completionHandler:]):
(-[WKNetworkSessionDelegate URLSession:task:didReceiveChallenge:completionHandler:]):
(-[WKNetworkSessionDelegate URLSession:task:didCompleteWithError:]):
(-[WKNetworkSessionDelegate URLSession:dataTask:didReceiveResponse:completionHandler:]):
(-[WKNetworkSessionDelegate URLSession:dataTask:didReceiveData:]):
- Platform/Logging.h:
- 1:44 PM Changeset in webkit [201294] by
-
- 8 edits4 adds in trunk
AX: iOS: when bringing focus to a text field we may zoom the page even if author wanted max scale = 1
https://bugs.webkit.org/show_bug.cgi?id=157771
Reviewed by Tim Horton.
Source/WebCore:
If the author requests scaling not to be enabled, we should not scale in when keyboard focus moves to a text field.
Scaling should only happen when the user performs a gesture to do so in this case.
Tests: fast/viewport/ios/user-scalable-does-not-scale-for-keyboard-focus-with-author-defined-scale.html
fast/viewport/ios/user-scalable-scales-for-keyboard-focus-with-no-author-defined-scale.html
- page/ViewportConfiguration.h:
(WebCore::ViewportConfiguration::maximumScale):
Source/WebKit2:
- Shared/AssistedNodeInformation.cpp:
(WebKit::AssistedNodeInformation::encode):
(WebKit::AssistedNodeInformation::decode):
- Shared/AssistedNodeInformation.h:
- UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView _displayFormNodeInputView]):
- WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::getAssistedNodeInformation):
- 1:27 PM Changeset in webkit [201293] by
-
- 2 edits1 add in trunk/Source/JavaScriptCore
String template don't handle let initialization properly inside eval
https://bugs.webkit.org/show_bug.cgi?id=157991
Reviewed by Oliver Hunt.
The fix is to make sure we emit TDZ checks.
- bytecompiler/NodesCodegen.cpp:
(JSC::TaggedTemplateNode::emitBytecode):
- tests/stress/tagged-template-tdz.js: Added.
(shouldThrowTDZ):
(test):
- 1:25 PM Changeset in webkit [201292] by
-
- 6 edits2 deletes in trunk
Unreviewed, rolling out r200414.
This change appears to have broken the 'write a reply' field
on Nextdoor.com
Reverted changeset:
"Clicks inside button elements are sometimes discarded when
the mouse moves"
https://bugs.webkit.org/show_bug.cgi?id=39620
http://trac.webkit.org/changeset/200414
- 1:14 PM Changeset in webkit [201291] by
-
- 2 edits in trunk/Websites/webkit.org
Add syntax highglighting for ES6 "let", "const" and "of" keywords.
https://bugs.webkit.org/show_bug.cgi?id=157994
Reviewed by Geoffrey Garen.
- wp-content/plugins/hyperlight/hyperlight/languages/javascript.php:
- 10:40 AM Changeset in webkit [201290] by
-
- 54 edits in trunk
Clean up / Modernize the CSS Parser
https://bugs.webkit.org/show_bug.cgi?id=157961
Reviewed by Alex Christensen.
Clean up / Modernize the CSS Parser.
- WebCore.xcodeproj/project.pbxproj:
- css/BasicShapeFunctions.cpp:
(WebCore::valueForBasicShape):
(WebCore::convertToLength):
(WebCore::convertToLengthSize):
(WebCore::basicShapeForValue):
- css/BasicShapeFunctions.h:
- css/CSSBasicShapes.cpp:
(WebCore::CSSBasicShapePolygon::cssText):
(WebCore::CSSBasicShapePolygon::equals):
- css/CSSBasicShapes.h:
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::valueForReflection):
(WebCore::ComputedStyleExtractor::valueForShadow):
(WebCore::specifiedValueForGridTrackSize):
- css/CSSCrossfadeValue.cpp:
(WebCore::subimageKnownToBeOpaque):
(WebCore::CSSCrossfadeValue::fixedSize):
(WebCore::CSSCrossfadeValue::isPending):
(WebCore::CSSCrossfadeValue::knownToBeOpaque):
(WebCore::CSSCrossfadeValue::loadSubimages):
(WebCore::CSSCrossfadeValue::image):
(WebCore::CSSCrossfadeValue::blend):
(WebCore::CSSCrossfadeValue::equals):
(WebCore::CSSCrossfadeValue::equalInputImages):
- css/CSSCrossfadeValue.h:
(WebCore::CSSCrossfadeValue::create):
(WebCore::CSSCrossfadeValue::CSSCrossfadeValue):
- css/CSSCustomPropertyValue.h:
(WebCore::CSSCustomPropertyValue::create):
(WebCore::CSSCustomPropertyValue::CSSCustomPropertyValue):
- css/CSSFilterImageValue.cpp:
(WebCore::CSSFilterImageValue::fixedSize):
(WebCore::CSSFilterImageValue::isPending):
(WebCore::CSSFilterImageValue::loadSubimages):
(WebCore::CSSFilterImageValue::image):
(WebCore::CSSFilterImageValue::createFilterOperations):
(WebCore::CSSFilterImageValue::equals):
(WebCore::CSSFilterImageValue::equalInputImages):
- css/CSSFilterImageValue.h:
(WebCore::CSSFilterImageValue::CSSFilterImageValue):
- css/CSSFontFaceSet.cpp:
(WebCore::CSSFontFaceSet::matchingFaces):
- css/CSSFunctionValue.cpp:
(WebCore::CSSFunctionValue::CSSFunctionValue):
- css/CSSFunctionValue.h:
(WebCore::CSSFunctionValue::create):
- css/CSSGradientValue.h:
(WebCore::CSSLinearGradientValue::setAngle):
- css/CSSGrammar.y.in:
- css/CSSImageGeneratorValue.cpp:
(WebCore::CSSImageGeneratorValue::subimageIsPending):
(WebCore::CSSImageGeneratorValue::cachedImageForCSSValue):
- css/CSSImageGeneratorValue.h:
- css/CSSImageValue.cpp:
(WebCore::CSSImageValue::cachedOrPendingImage):
- css/CSSImageValue.h:
- css/CSSKeyframesRule.cpp:
(WebCore::StyleRuleKeyframes::StyleRuleKeyframes):
(WebCore::StyleRuleKeyframes::parserAppendKeyframe):
(WebCore::StyleRuleKeyframes::wrapperAppendKeyframe):
(WebCore::CSSKeyframesRule::appendRule):
(WebCore::CSSKeyframesRule::findRule):
(WebCore::CSSKeyframesRule::item):
(WebCore::StyleRuleKeyframes::~StyleRuleKeyframes): Deleted.
- css/CSSKeyframesRule.h:
(WebCore::StyleRuleKeyframes::keyframes):
- css/CSSParser.cpp:
(WebCore::parseColorValue):
(WebCore::parseSimpleLengthValue):
(WebCore::parseKeywordValue):
(WebCore::parseTranslateTransformValue):
(WebCore::CSSParser::parseFontFaceValue):
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseCustomPropertyValue):
(WebCore::CSSParser::parseDeclaration):
(WebCore::CSSParser::SourceSize::SourceSize):
(WebCore::filterProperties):
(WebCore::CSSParser::clearProperties):
(WebCore::CSSParser::addExpandedPropertyForValue):
(WebCore::CSSParser::parseVariableDependentValue):
(WebCore::CSSParser::parseContentDistributionOverflowPosition):
(WebCore::CSSParser::parseItemPositionOverflowPosition):
(WebCore::CSSParser::parseNonElementSnapPoints):
(WebCore::CSSParser::parseScrollSnapDestination):
(WebCore::CSSParser::parseScrollSnapCoordinate):
(WebCore::CSSParser::parseFillShorthand):
(WebCore::CSSParser::addAnimationValue):
(WebCore::CSSParser::parseAnimationShorthand):
(WebCore::CSSParser::parseColumnWidth):
(WebCore::CSSParser::parseColumnCount):
(WebCore::CSSParser::parseColumnsShorthand):
(WebCore::CSSParser::parseTransitionShorthand):
(WebCore::CSSParser::parseSize):
(WebCore::CSSParser::parseQuotes):
(WebCore::CSSParser::parseAlt):
(WebCore::CSSParser::parseCustomPropertyDeclaration):
(WebCore::CSSParser::parseContent):
(WebCore::CSSParser::parseAttr):
(WebCore::CSSParser::parseBackgroundColor):
(WebCore::CSSParser::parseFillPositionComponent):
(WebCore::CSSParser::parse4ValuesFillPosition):
(WebCore::CSSParser::parse3ValuesFillPosition):
(WebCore::CSSParser::parseFillPosition):
(WebCore::CSSParser::parseFillSize):
(WebCore::CSSParser::parseFillProperty):
(WebCore::CSSParser::parseAnimationDelay):
(WebCore::CSSParser::parseAnimationDirection):
(WebCore::CSSParser::parseAnimationDuration):
(WebCore::CSSParser::parseAnimationFillMode):
(WebCore::CSSParser::parseAnimationIterationCount):
(WebCore::CSSParser::parseAnimationName):
(WebCore::CSSParser::parseAnimationPlayState):
(WebCore::CSSParser::parseAnimationTrigger):
(WebCore::CSSParser::parseAnimationProperty):
(WebCore::CSSParser::parseKeyframeSelector):
(WebCore::CSSParser::parseGridPosition):
(WebCore::gridMissingGridPositionValue):
(WebCore::CSSParser::parseGridItemPositionShorthand):
(WebCore::CSSParser::parseGridGapShorthand):
(WebCore::CSSParser::parseGridTemplateRowsAndAreasAndColumns):
(WebCore::CSSParser::parseGridTemplateShorthand):
(WebCore::CSSParser::parseGridShorthand):
(WebCore::CSSParser::parseGridAreaShorthand):
(WebCore::CSSParser::parseGridLineNames):
(WebCore::CSSParser::parseGridTrackList):
(WebCore::CSSParser::parseGridTrackRepeatFunction):
(WebCore::CSSParser::parseGridTrackSize):
(WebCore::CSSParser::parseGridAutoFlow):
(WebCore::skipCommaInDashboardRegion):
(WebCore::CSSParser::parseDashboardRegions):
(WebCore::parseGridTemplateAreasColumnNames):
(WebCore::CSSParser::parseCounterContent):
(WebCore::CSSParser::parseClipShape):
(WebCore::CSSParser::parseInsetRoundedCorners):
(WebCore::CSSParser::parseBasicShapeInset):
(WebCore::CSSParser::parseBasicShapeCircle):
(WebCore::CSSParser::parseBasicShapeEllipse):
(WebCore::CSSParser::parseBasicShapePolygon):
(WebCore::CSSParser::parseBasicShapePath):
(WebCore::CSSParser::parseBasicShapeAndOrBox):
(WebCore::CSSParser::parseFont):
(WebCore::CSSParser::parseFontFamily):
(WebCore::CSSParser::parseFontSynthesis):
(WebCore::CSSParser::parseFontFaceSrcURI):
(WebCore::CSSParser::parseFontFaceSrc):
(WebCore::CSSParser::parseFontFaceUnicodeRange):
(WebCore::parseAlphaValue):
(WebCore::ShadowParseContext::commitValue):
(WebCore::CSSParser::parseShadow):
(WebCore::CSSParser::parseReflect):
(WebCore::CSSParser::parseFlex):
(WebCore::BorderImageParseContext::commitImage):
(WebCore::BorderImageParseContext::commitImageSlice):
(WebCore::BorderImageParseContext::commitBorderWidth):
(WebCore::BorderImageParseContext::commitBorderOutset):
(WebCore::BorderImageParseContext::commitRepeat):
(WebCore::BorderImageParseContext::commitWebKitBorderImage):
(WebCore::BorderImageParseContext::commitBorderImageProperty):
(WebCore::CSSParser::parseBorderImage):
(WebCore::CSSParser::parseBorderImageRepeat):
(WebCore::BorderImageQuadParseContext::setTop):
(WebCore::CSSParser::parseCounter):
(WebCore::CSSParser::parseDeprecatedGradient):
(WebCore::CSSParser::parseDeprecatedLinearGradient):
(WebCore::CSSParser::parseDeprecatedRadialGradient):
(WebCore::CSSParser::parseLinearGradient):
(WebCore::CSSParser::parseRadialGradient):
(WebCore::CSSParser::parseFilterImage):
(WebCore::CSSParser::parseCrossfade):
(WebCore::CSSParser::parseImageResolution):
(WebCore::CSSParser::parseImageSet):
(WebCore::CSSParser::parseTransform):
(WebCore::CSSParser::parseTransformValue):
(WebCore::CSSParser::parseFilter):
(WebCore::CSSParser::parseTextDecoration):
(WebCore::CSSParser::parseTextEmphasisStyle):
(WebCore::CSSParser::parseTextEmphasisPosition):
(WebCore::CSSParser::parseTextIndent):
(WebCore::CSSParser::parseHangingPunctuation):
(WebCore::CSSParser::parseFontFeatureSettings):
(WebCore::CSSParser::parseWillChange):
(WebCore::CSSParser::createImportRule):
(WebCore::CSSParser::createMediaRule):
(WebCore::CSSParser::createEmptyMediaRule):
(WebCore::CSSParser::createSupportsRule):
(WebCore::CSSParser::markSupportsRuleHeaderStart):
(WebCore::CSSParser::popSupportsRuleData):
(WebCore::CSSParser::processAndAddNewRuleToSourceTreeIfNeeded):
(WebCore::CSSParser::addNewRuleToSourceTree):
(WebCore::CSSParser::popRuleData):
(WebCore::CSSParser::createKeyframesRule):
(WebCore::CSSParser::createStyleRule):
(WebCore::CSSParser::createFontFaceRule):
(WebCore::CSSParser::createPageRule):
(WebCore::CSSParser::createRegionRule):
(WebCore::CSSParser::endDeclarationsForMarginBox):
(WebCore::CSSParser::createKeyframe):
(WebCore::CSSParser::updateLastMediaLine):
(WebCore::fixUnparsedProperties):
(WebCore::CSSParser::fixUnparsedPropertyRanges):
(WebCore::CSSParser::parseViewportProperty):
(WebCore::cssPropertyNameIOSAliasing):
(WebCore::isAppleLegacyCssValueKeyword):
(WebCore::quoteCSSString):
(WebCore::AnimationParseContext::commitFirstAnimation): Deleted.
(WebCore::strictCSSParserContext): Deleted.
(WebCore::CSSParser::~CSSParser): Deleted.
(WebCore::convertToASCIILowercaseInPlace): Deleted.
(WebCore::CSSParserString::convertToASCIILowercaseInPlace): Deleted.
(WebCore::CSSParser::setupParser): Deleted.
(WebCore::isSimpleLengthPropertyID): Deleted.
(WebCore::isValidKeywordPropertyAndValue): Deleted.
(WebCore::parseTransformTranslateArguments): Deleted.
(WebCore::CSSParser::parseColor): Deleted.
(WebCore::CSSParser::parseMediaQuery): Deleted.
(WebCore::CSSParser::parseSizesAttribute): Deleted.
(WebCore::CSSParser::addProperty): Deleted.
(WebCore::CSSParser::validateCalculationUnit): Deleted.
(WebCore::isItemPositionKeyword): Deleted.
(WebCore::CSSParser::parseShorthand): Deleted.
(WebCore::CSSParser::parseSizeParameter): Deleted.
(WebCore::CSSParser::parseFillImage): Deleted.
(WebCore::CSSParser::parsePositionY): Deleted.
(WebCore::CSSParser::parse2ValuesFillPosition): Deleted.
(WebCore::CSSParser::parseTransformOriginShorthand): Deleted.
(WebCore::CSSParser::parseAnimationTimingFunction): Deleted.
(WebCore::CSSParser::parseGridTemplateColumns): Deleted.
(WebCore::CSSParser::parseSingleGridAreaLonghand): Deleted.
(WebCore::allTracksAreFixedSized): Deleted.
(WebCore::CSSParser::parseGridBreadth): Deleted.
(WebCore::CSSParser::parseGridTemplateAreasRow): Deleted.
(WebCore::completeBorderRadii): Deleted.
(WebCore::CSSParser::parseShapeRadius): Deleted.
(WebCore::isBoxValue): Deleted.
(WebCore::CSSParser::parseShapeProperty): Deleted.
(WebCore::CSSParser::parseClipPath): Deleted.
(WebCore::CSSParser::parseBasicShape): Deleted.
(WebCore::FontFamilyValueBuilder::commit): Deleted.
(WebCore::CSSParser::parseFontWeight): Deleted.
(WebCore::CSSParser::parseFontFaceSrcLocal): Deleted.
(WebCore::parseDouble): Deleted.
(WebCore::mightBeRGBA): Deleted.
(WebCore::mightBeRGB): Deleted.
(WebCore::ShadowParseContext::commitColor): Deleted.
(WebCore::BorderImageParseContext::BorderImageParseContext): Deleted.
(WebCore::BorderImageParseContext::commitForwardSlashOperator): Deleted.
(WebCore::BorderImageParseContext::commitBorderImage): Deleted.
(WebCore::isBorderImageRepeatKeyword): Deleted.
(WebCore::BorderImageSliceParseContext::commitBorderImageSlice): Deleted.
(WebCore::CSSParser::parseBorderImageQuad): Deleted.
(WebCore::parseDeprecatedGradientColorStop): Deleted.
(WebCore::valueFromSideKeyword): Deleted.
(WebCore::CSSParser::isGeneratedImageValue): Deleted.
(WebCore::CSSParser::parseCanvas): Deleted.
(WebCore::CSSParser::parseNamedImage): Deleted.
(WebCore::TransformOperationInfo::TransformOperationInfo): Deleted.
(WebCore::CSSParser::isBlendMode): Deleted.
(WebCore::filterInfoForName): Deleted.
(WebCore::CSSParser::parseFlowThread): Deleted.
(WebCore::CSSParser::parseRegionThread): Deleted.
(WebCore::CSSParser::parseLineBoxContain): Deleted.
(WebCore::CSSParser::parseFontFeatureTag): Deleted.
(WebCore::CSSParser::parseFontVariantLigatures): Deleted.
(WebCore::isCSSLetter): Deleted.
(WebCore::CSSParser::markSupportsRuleHeaderEnd): Deleted.
(WebCore::CSSParser::syntaxError): Deleted.
(WebCore::CSSParser::logError): Deleted.
(WebCore::CSSParser::rewriteSpecifiersWithElementName): Deleted.
(WebCore::CSSParser::rewriteSpecifiers): Deleted.
(WebCore::CSSParser::invalidBlockHit): Deleted.
(WebCore::CSSParser::markRuleHeaderStart): Deleted.
(WebCore::CSSParser::setRuleHeaderEnd): Deleted.
(WebCore::CSSParser::markRuleHeaderEnd): Deleted.
(WebCore::CSSParser::markRuleBodyStart): Deleted.
(WebCore::cssPropertyID): Deleted.
(WebCore::isCSSTokenizerIdentifier): Deleted.
- css/CSSParser.h:
(WebCore::CSSParser::ValueWithCalculation::setCalculation): Deleted.
- css/CSSPrimitiveValue.cpp:
(WebCore::CSSPrimitiveValue::cloneForCSSOM):
- css/CSSPrimitiveValue.h:
- css/CSSPropertySourceData.h:
- css/CSSReflectValue.cpp:
(WebCore::CSSReflectValue::equals):
- css/CSSReflectValue.h:
(WebCore::CSSReflectValue::create):
(WebCore::CSSReflectValue::direction):
(WebCore::CSSReflectValue::offset):
(WebCore::CSSReflectValue::CSSReflectValue):
- css/CSSShadowValue.cpp:
(WebCore::CSSShadowValue::CSSShadowValue):
(WebCore::CSSShadowValue::customCSSText): Deleted.
- css/CSSShadowValue.h:
(WebCore::CSSShadowValue::create):
- css/CSSValue.h:
(WebCore::compareCSSValueVector):
- css/CSSVariableDependentValue.cpp:
(WebCore::CSSVariableDependentValue::checkVariablesForCycles):
- css/CSSVariableDependentValue.h:
(WebCore::CSSVariableDependentValue::create):
(WebCore::CSSVariableDependentValue::customCSSText):
(WebCore::CSSVariableDependentValue::valueList):
(WebCore::CSSVariableDependentValue::CSSVariableDependentValue):
- css/CSSVariableValue.cpp:
(WebCore::CSSVariableValue::buildParserValueListSubstitutingVariables):
- css/Counter.h:
(WebCore::Counter::create):
(WebCore::Counter::identifier):
(WebCore::Counter::listStyle):
(WebCore::Counter::separator):
(WebCore::Counter::listStyleIdent):
(WebCore::Counter::setIdentifier):
(WebCore::Counter::setListStyle):
(WebCore::Counter::setSeparator):
(WebCore::Counter::cloneForCSSOM):
(WebCore::Counter::Counter):
- css/DOMCSSNamespace.cpp:
(WebCore::DOMCSSNamespace::supports):
- css/FontFace.cpp:
(WebCore::FontFace::parseString):
(WebCore::FontFace::setVariant):
- css/Rect.h:
(WebCore::RectBase::RectBase):
- css/SVGCSSParser.cpp:
(WebCore::CSSParser::parseSVGStrokeDasharray):
(WebCore::CSSParser::parseSVGPaint):
(WebCore::CSSParser::parseSVGColor):
(WebCore::CSSParser::parsePaintOrder):
- css/StyleBuilderConverter.h:
(WebCore::StyleBuilderConverter::convertReflection):
- css/StyleProperties.cpp:
(WebCore::MutableStyleProperties::setProperty):
(WebCore::MutableStyleProperties::setCustomProperty):
(WebCore::MutableStyleProperties::parseDeclaration):
- css/StyleResolver.cpp:
(WebCore::StyleResolver::keyframeStylesForAnimation):
(WebCore::StyleResolver::cachedOrPendingFromValue):
- css/StyleResolver.h:
- css/WebKitCSSMatrix.cpp:
(WebCore::WebKitCSSMatrix::setMatrixValue):
- html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::setFont):
- inspector/InspectorStyleSheet.cpp:
(flattenSourceData):
(ParsedStyleSheet::setSourceData):
(ParsedStyleSheet::ruleSourceDataAt):
(WebCore::InspectorStyleSheetForInlineStyle::getStyleAttributeRanges):
- page/PageSerializer.cpp:
(WebCore::PageSerializer::retrieveResourcesForProperties):
- page/animation/CSSPropertyAnimation.cpp:
(WebCore::crossfadeBlend):
- rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::checkVariablesInCustomProperties):
- 9:59 AM Changeset in webkit [201289] by
-
- 6 edits in trunk/LayoutTests
Marking fast/text-autosizing/ios/text-autosizing-after-back.html as a flaky timeout on Mac and iOS
https://bugs.webkit.org/show_bug.cgi?id=157589
Unreviewed test gardening.
- TestExpectations:
- platform/ios-simulator-wk1/TestExpectations:
- platform/ios-simulator-wk2/TestExpectations:
- platform/mac-wk1/TestExpectations:
- platform/mac-wk2/TestExpectations:
- 9:46 AM Changeset in webkit [201288] by
-
- 3 edits in trunk/Tools
check-webkit-style gets flags std::literals::chrono_literals as bad naming.
https://bugs.webkit.org/show_bug.cgi?id=157969
Reviewed by Alex Christensen.
- Scripts/webkitpy/style/checkers/cpp.py:
(check_identifier_name_in_declaration):
- Scripts/webkitpy/style/checkers/cpp_unittest.py:
(WebKitStyleTest.test_names):
- 9:41 AM Changeset in webkit [201287] by
-
- 2 edits in trunk/LayoutTests
Marking fast/frames/crash-during-iframe-load-stop.html as a flaky timeout
https://bugs.webkit.org/show_bug.cgi?id=157849
Unreviewed test gardening.
- 8:53 AM Changeset in webkit [201286] by
-
- 4 edits3 adds in releases/WebKitGTK/webkit-2.12
Merge r198592 - JavaScriptCore ArrayPrototype::join shouldn't cache butterfly when it makes effectful calls
https://bugs.webkit.org/show_bug.cgi?id=155776
Reviewed by Saam Barati.
Source/JavaScriptCore:
Array.join ends up calling toString, possibly on some object. Since these calls
could be effectful and could change the array itself, we can't hold the butterfly
pointer while making effectful calls. Changed the code to fall back to the general
case when an effectful toString() call might be made.
- runtime/ArrayPrototype.cpp:
(JSC::join):
- runtime/JSStringJoiner.h:
(JSC::JSStringJoiner::appendWithoutSideEffects): New helper that doesn't make effectful
toString() calls.
(JSC::JSStringJoiner::append): Built upon appendWithoutSideEffects.
LayoutTests:
New test.
- js/regress-155776-expected.txt: Added.
- js/regress-155776.html: Added.
- js/script-tests/regress-155776.js: Added.
(fillBigArrayViaToString):
(Function.prototype.toString):
- 8:52 AM Changeset in webkit [201285] by
-
- 1 edit in releases/WebKitGTK/webkit-2.12/Source/WebCore/ChangeLog
Some media tests are flaky.
https://bugs.webkit.org/show_bug.cgi?id=155614
Reviewed by Eric Carlson.
- html/track/TextTrack.cpp:
(WebCore::TextTrack::~TextTrack):
- 6:42 AM WebKitGTK/2.12.x edited by
- (diff)
- 6:41 AM Changeset in webkit [201284] by
-
- 4 edits in releases/WebKitGTK/webkit-2.12
Merge r197886 - [cmake] Fixed All-in-One build.
https://bugs.webkit.org/show_bug.cgi?id=155241
Patch by Konstantin Tokarev <Konstantin Tokarev> on 2016-03-09
Reviewed by Csaba Osztrogonác.
.:
- Source/cmake/WebKitMacros.cmake: Last item of WebCore_SOURCES was
not removed in PROCESS_ALLINONE_FILE.
Source/WebCore:
No new tests needed.
- bindings/js/JSBindingsAllInOne.cpp: Should not include generated
file.
- 6:37 AM Changeset in webkit [201283] by
-
- 4 edits in releases/WebKitGTK/webkit-2.12/Source/WebCore
Merge r201163 - [GStreamer] unrelated codecs required to play videos
https://bugs.webkit.org/show_bug.cgi?id=135972
Reviewed by Michael Catanzaro.
Instead of hard-coding the list of supported mime-types, check the
decoder and demuxer GStreamer elements available and dynamically
build the list of mime-types accordingly. This patch also removes
support for under-used and exotic mime-types.
Based on a patch by Mario Sanchez Prada.
No new tests, existing media tests cover this change.
- platform/graphics/gstreamer/GStreamerUtilities.cpp:
(WebCore::gstRegistryHasElementForMediaType): New function
checking the elements registered in the factories have a sink pad
matching the caps specified as second argument of the function.
- platform/graphics/gstreamer/GStreamerUtilities.h:
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::mimeTypeSet): Hard-coded list of mime-types replaced by
runtime-built list of mime-types that can be supported by the
GStreamer decoders and demuxers available on the host machine.
(WebCore::MediaPlayerPrivateGStreamer::getSupportedTypes):
mimeTypeCache renamed to mimeTypeSet.
(WebCore::MediaPlayerPrivateGStreamer::supportsType): Ditto.
- 6:34 AM Changeset in webkit [201282] by
-
- 2 edits in releases/WebKitGTK/webkit-2.12/Source/WebCore
Merge r201078 - [GStreamer] webaudio crash on ARM platforms
https://bugs.webkit.org/show_bug.cgi?id=157838
Reviewed by Michael Catanzaro.
- platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp:
(webKitWebAudioSrcConstructed): Explicitely cast the integer value
of the max-bytes property to guint64 which is the expected type of
this property. The compiler can't guess this on its own.
- 6:34 AM Changeset in webkit [201281] by
-
- 3 edits in releases/WebKitGTK/webkit-2.12/Source/WebCore
Merge r201077 - [GStreamer] webaudio playback improvements
https://bugs.webkit.org/show_bug.cgi?id=155228
Reviewed by Michael Catanzaro.
- platform/audio/gstreamer/AudioDestinationGStreamer.cpp:
(WebCore::autoAudioSinkChildAddedCallback): Fix sink buffer-time
to 100ms to reduce playback latency.
(WebCore::AudioDestinationGStreamer::AudioDestinationGStreamer):
Connect to child-added signal of autoaudiosink to be notified when
a real sink is added into the bin.
- platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp:
(webKitWebAudioSrcConstructed): Fine-tune blocksize of appsrc
according to the buffer size already configured on the src element.
- 6:22 AM Changeset in webkit [201280] by
-
- 3 edits3 adds in releases/WebKitGTK/webkit-2.12
Merge r201053 - REGRESSION(r192855): Math.random() always produces the same first 7 decimal points the first two invocations
https://bugs.webkit.org/show_bug.cgi?id=157805
<rdar://problem/26327851>
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-05-17
Reviewed by Geoffrey Garen.
Source/WTF:
- wtf/WeakRandom.h:
(WTF::WeakRandom::setSeed):
Advance once to randomize the 32bit seed across the 128bit state
and avoid re-using 64bits of state in the second advance.
LayoutTests:
- js/dom/math-random-initial-values-expected.txt: Added.
- js/dom/math-random-initial-values.html: Added.
- js/resources/math-random-initial-values-iframe.html: Added.
Test that less then 5% of the time, early Math.random invocations
produce very similiar values. Before this change we were failing
100%, but after we see similiar values mostly around 0-3%.
- 5:58 AM Changeset in webkit [201279] by
-
- 2 edits in releases/WebKitGTK/webkit-2.12/Source/bmalloc
Merge r201050 - REGRESSION: JetStream crashes on some iPhones
https://bugs.webkit.org/show_bug.cgi?id=157814
Reviewed by Michael Saboff.
- bmalloc/Sizes.h: Reduce smallMax to 32kB.
Previous justification for 64kB was:
- bmalloc/Sizes.h: Upped smallMax to 64kB. Upping to 32kB is pretty reasonable, since sizes between 16kB and 32kB share page sizes. I went all the way up to 64kB because the GC uses 64kB blocks, and also just for extra padding to ensure that large allocations are indeed rare.
It turns out that the bump to 64kB substantially increases our memory
high water mark on JetStream, leading to jetsam crashes. Also, there
doesn't seem to be a practical performance problem to putting objects in
the (32kB - 64kB) range in the large allocator.
- 5:52 AM Changeset in webkit [201278] by
-
- 2 edits in releases/WebKitGTK/webkit-2.12/Source/WebCore
Merge r201023 - Regression(r177786): GlyphMetricsMap<T>::locatePageSlowCase() fills existing pages with unknown metrics
https://bugs.webkit.org/show_bug.cgi?id=157749
Reviewed by Antti Koivisto.
After r177786, GlyphMetricsMap<T>::locatePageSlowCase() would unconditionally fill
pages with unknown metrics. This patch updates the code to do so only if the page
is new, thus restoring the pre-r177786 behavior.
- platform/graphics/GlyphMetricsMap.h:
(WebCore::GlyphMetricsMap::metricsForGlyph):
(WebCore::GlyphMetricsMap::setMetricsForGlyph):
(WebCore::GlyphMetricsMap::GlyphMetricsPage::GlyphMetricsPage):
(WebCore::GlyphMetricsMap::GlyphMetricsPage::fill):
(WebCore::GlyphMetricsMap::locatePage):
(WebCore::GlyphMetricsMap<T>::locatePageSlowCase):
(WebCore::GlyphMetricsMap::GlyphMetricsPage::metricsForGlyph): Deleted.
(WebCore::GlyphMetricsMap::GlyphMetricsPage::setMetricsForGlyph): Deleted.
(WebCore::GlyphMetricsMap::GlyphMetricsPage::setMetricsForIndex): Deleted.
(WebCore::GlyphMetricsMap<float>::unknownMetrics): Deleted.
(WebCore::GlyphMetricsMap<FloatRect>::unknownMetrics): Deleted.
- 5:36 AM Changeset in webkit [201277] by
-
- 3 edits4 adds in releases/WebKitGTK/webkit-2.12
Merge r200986 - heap use-after-free at WebCore::TimerBase::heapPopMin()
https://bugs.webkit.org/show_bug.cgi?id=157742
<rdar://problem/26236778>
Source/WebCore:
Reviewed by David Kilzer.
Tested by fast/frames/resources/crash-during-iframe-load-stop.html.
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::stopForUserCancel): Protect m_frame from destruction while it is still
being used by the current stack frame.
(WebCore::FrameLoader::frameDetached): Ditto.
(WebCore::FrameLoader::continueFragmentScrollAfterNavigationPolicy): Ditto.
LayoutTests:
Reviewed by Simon Fraser.
- fast/frames/crash-during-iframe-load-stop-expected.txt: Added.
- fast/frames/crash-during-iframe-load-stop.html: Added.
- fast/frames/resources/crash-during-iframe-load-stop-inner.html: Added.
- fast/frames/resources/crash-during-iframe-load-stop.html: Added.
- 5:33 AM Changeset in webkit [201276] by
-
- 2 edits in releases/WebKitGTK/webkit-2.12/Source/WebCore
Merge r200971 - RenderLayer::hitTestList could mutate the list of candidate layers.
https://bugs.webkit.org/show_bug.cgi?id=157718
<rdar://problem/22556046>
Reviewed by Simon Fraser.
This patch ensures that we always start hittesting a clean render tree at EventHandler::hitTestResultAtPoint.
Speculative fix.
- page/EventHandler.cpp:
(WebCore::EventHandler::hitTestResultAtPoint):
- 5:26 AM Changeset in webkit [201275] by
-
- 2 edits in trunk/Source/WebKit2
[ThreadedCompositor] Ensure that the BitmapTexture used by CoordinatedBackingStoreTile matches the opacity of the painted surface
https://bugs.webkit.org/show_bug.cgi?id=157942
Patch by Miguel Gomez <magomez@igalia.com> on 2016-05-23
Reviewed by Žan Doberšek.
- Shared/CoordinatedGraphics/CoordinatedBackingStore.cpp:
(WebKit::CoordinatedBackingStoreTile::swapBuffers):
Reset the BitmapTexture if it doesn't match the opacity required by the surface
that's being painted.
- 5:25 AM Changeset in webkit [201274] by
-
- 2 edits in releases/WebKitGTK/webkit-2.12/Source/WebCore
Merge r200940 - [Cairo] GraphicsContext3D::ImageExtractor should use the correct size for copying non-image surfaces
https://bugs.webkit.org/show_bug.cgi?id=157580
Reviewed by Darin Adler.
GraphicsContext3D::ImageExtractor::extractImage() shouldn't use m_imageWidth
and m_imageHeight members when copying the non-image-backed Cairo surface into
the image-based replacement simply because these two are not initialized until
later in this method.
Instead, the size of the to-be-copied image should be queried via the
cairoSurfaceSize() utility function which properly handles Cairo surfaces of
different types.
- platform/graphics/cairo/GraphicsContext3DCairo.cpp:
(WebCore::GraphicsContext3D::ImageExtractor::extractImage):
- 5:17 AM Changeset in webkit [201273] by
-
- 5 edits2 adds in releases/WebKitGTK/webkit-2.12
Merge r200923 - ToT WebKit doesn't show tooltip on perf dashboard's summary page
https://bugs.webkit.org/show_bug.cgi?id=157705
Reviewed by Darin Adler.
Source/WebCore:
The bug was caused by WebKit doesn't look for the title attribute across shadow boundaries.
Fixed it by using a newly added Node::parentNodeInComposedTree in HitTestResult::title.
Test: fast/shadow-dom/tooltip-on-composed-tree.html
- dom/Node.cpp:
(WebCore::Node::parentInComposedTree): Added.
- dom/Node.h:
- rendering/HitTestResult.cpp:
(WebCore::HitTestResult::title): Fixed the bug.
(WebCore::HitTestResult::innerTextIfTruncated): Fixed a related bug when ShowsToolTipOverTruncatedText
is enabled. Unfortunately, there is no machinery to test this feature yet.
LayoutTests:
Added a regression test for finding a tooltip across shadow boundaries.
- fast/shadow-dom/tooltip-on-composed-tree-expected.txt: Added.
- fast/shadow-dom/tooltip-on-composed-tree.html: Added.
- 4:15 AM Changeset in webkit [201272] by
-
- 2 edits in releases/WebKitGTK/webkit-2.12/Source/WebCore
Merge r200811 - VideoSinkGStreamer: plug a GstBuffer leak in webkitVideoSinkRequestRender()
https://bugs.webkit.org/show_bug.cgi?id=157617
Reviewed by Darin Adler.
Unref the newly-created GstBuffer object after creating the new GstSample
that's based on it. gst_sample_new() doesn't take the ownership of it.
Also, don't unref the GstBuffer object that's passed in to the
webkitVideoSinkRequestRender() function in case the allocation of the
replacement buffer fails. We don't have any ownership over that buffer
and it's not unreffed anywhere else in this function.
- platform/graphics/gstreamer/VideoSinkGStreamer.cpp:
(webkitVideoSinkRequestRender):
- 4:10 AM Changeset in webkit [201271] by
-
- 4 edits2 adds in releases/WebKitGTK/webkit-2.12
Merge r200736 - Absolute positioned element is not placed properly when parent becomes the containing block.
https://bugs.webkit.org/show_bug.cgi?id=157455
<rdar://problem/26212568>
Reviewed by Simon Fraser.
When a container becomes a containing block, we need to check if there are any positioned boxes in its subtree
in order to "re-parent" them. It basically means that we remove them from RenderBlock::positionedDescendants map
and they'll get re-inserted during the next layout correctly.
This patch fixes the case when a container becomes the containing block by setting the transform property and its positioned
child gets misplaced.
Source/WebCore:
Test: fast/block/containing-block-changes.html
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::removePositionedObjectsIfNeeded):
(WebCore::RenderBlock::styleWillChange):
- rendering/RenderBlock.h:
LayoutTests:
- fast/block/containing-block-changes-expected.html: Added.
- fast/block/containing-block-changes.html: Added.
- 4:03 AM Changeset in webkit [201270] by
-
- 19 edits1 copy2 moves in releases/WebKitGTK/webkit-2.12
Merge r200677 - [GTK] accessibility/aria-readonly.html is failing
https://bugs.webkit.org/show_bug.cgi?id=98357
Reviewed by Chris Fleizach.
Source/WebCore:
Add support for ATK_STATE_READ_ONLY and expose the value of aria-readonly
as an AtkObject attribute. In order to eliminate duplicate checks, remove
isReadOnly() and just use canSetAttributeValue(), moving all the logic into
AccessibilityNodeObject. Add AccessibilityObject::supportsARIAReadOnly() so
that we can explicitly expose the implicit value for aria-readonly on roles
which support this property. Also add support for ATK_STATE_CHECKABLE, both
because this state was missing and because it serves a similar function to
ATK_STATE_EDITABLE for the purpose of verifying exposure of toggle-able
elements that are not read-only.
Test: accessibility/form-control-value-settable.html
- accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::canSetValueAttribute):
(WebCore::AccessibilityNodeObject::isRequired): Deleted.
(WebCore::AccessibilityNodeObject::supportsRequiredAttribute): Deleted.
- accessibility/AccessibilityNodeObject.h:
- accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::supportsARIAReadOnly):
(WebCore::AccessibilityObject::ariaReadOnlyValue):
- accessibility/AccessibilityObject.h:
(WebCore::AccessibilityObject::isUnvisited): Deleted.
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::clickPoint):
(WebCore::AccessibilityRenderObject::isOffScreen): Deleted.
(WebCore::AccessibilityRenderObject::anchorElement): Deleted.
(WebCore::AccessibilityRenderObject::internalLinkElement): Deleted.
(WebCore::AccessibilityRenderObject::textChanged): Deleted.
(WebCore::AccessibilityRenderObject::clearChildren): Deleted.
(WebCore::AccessibilityRenderObject::addImageMapChildren): Deleted.
- accessibility/AccessibilityRenderObject.h:
- accessibility/atk/WebKitAccessibleInterfaceText.cpp:
(getAttributeSetForAccessibilityObject):
- accessibility/atk/WebKitAccessibleWrapperAtk.cpp:
(webkitAccessibleGetAttributes):
(setAtkStateSetFromCoreObject):
(getInterfaceMaskFromObject):
- inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::buildObjectForAccessibilityProperties):
Source/WebKit/win:
Call AccessibilityNode::canSetValueAttribute() to determine if STATE_SYSTEM_READONLY
should be added and if editable text should be supported.
- AccessibleBase.cpp:
(AccessibleBase::state):
- AccessibleTextImpl.cpp:
(AccessibleText::deleteText):
(AccessibleText::insertText):
(AccessibleText::cutText):
(AccessibleText::pasteText):
(AccessibleText::replaceText):
Tools:
Add checks to isAttributeSettable() for ATK_STATE_READ_ONLY and the 'readonly'
AtkObject attribute along with ATK_STATE_CHECKABLE for toggle-able elements,
ATK_STATE_SELECTABLE for select elements, and ATK_STATE_FOCUSABLE combined
with range verification for inputs which implement AtkValue. The latter two
additions are admittedly a heuristic workaround for platform accessibility
API differences. But they should be sufficient to facilitate cross-platform
testing of isAttributeSettable() for form elements which lack ARIA attributes.
Bump the minimum version of at-spi2-core and at-spi2-atk
to 2.15.4 (earliest version that supports STATE_READ_ONLY).
- WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
(WTR::AccessibilityUIElement::isAttributeSettable):
- gtk/jhbuild.modules:
LayoutTests:
As part of this change, a new AtkObject attribute and state are being exposed.
Update two tests accordingly. Also unskip the previously-failing test. Lastly,
move the Mac form-control-value-settable.html test to the shared test set,
with a minor tweak to check the platform for several elements' expectations.
- accessibility/form-control-value-settable.html: Moved to shared tests.
- accessibility/gtk/xml-roles-exposed-expected.txt: Updated.
- platform/gtk/TestExpectations: Unskipped previously-failing test.
- platform/gtk/accessibility/form-control-value-settable-expected.txt: Added.
- platform/gtk/accessibility/table-detection-expected.txt: Updated.
- platform/mac/accessibility/form-control-value-settable-expected.txt: Moved.
- 4:03 AM WebKitGTK/2.12.x edited by
- (diff)
- 4:02 AM Changeset in webkit [201269] by
-
- 11 edits2 adds in releases/WebKitGTK/webkit-2.12
Merge r200369 - [ATK] accessibility/content-editable-as-textarea.html fails
https://bugs.webkit.org/show_bug.cgi?id=155353
Reviewed by Darin Adler.
Source/WebCore:
The test was timing out because it expected an AXValueChanged notification.
In ATK, AXValueChanged notifications are made for widgets which implement
the AtkValue interface (sliders, progress bars, etc.). We should be listening
for AXTextChanged instead.
In addition, for contenteditable elements, we should emit the notification on
the element itself. Because we were handling the notification in the same way
as native text controls (where the notification we receive from WebCore is for
StaticTextRole children), we were attempting to emit the notification from
the parent of the contenteditable.
Lastly, ATK's AccessibilityUIElement support had a number of unimplemented
methods that are being used as part of the previously-failing test. Those
methods are now implemented so that the ATK results are much more similar
to those on the Mac.
No new tests needed. The previously-failing test now passes.
- accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::childrenChanged):
- accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::isNonNativeTextControl):
- accessibility/AccessibilityObject.h:
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::textChanged):
- accessibility/atk/AXObjectCacheAtk.cpp:
(WebCore::AXObjectCache::nodeTextChangePlatformNotification):
Tools:
The test was timing out because it expected an AXValueChanged notification.
In ATK, AXValueChanged notifications are made for widgets which implement
the AtkValue interface (sliders, progress bars, etc.). We should be listening
for AXTextChanged instead. AtkText's text-insert and text-remove have been
added to the AccessibilityNotificationHandler.
Also, ATK's AccessibilityUIElement support had a number of unimplemented
methods that are being used as part of the previously-failing test. Those
methods are now implemented so that the ATK results are much more similar
to those on the Mac.
- WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
(WTR::AccessibilityNotificationHandler::connectAccessibilityCallbacks):
- WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
(WTR::AccessibilityUIElement::stringAttributeValue):
(WTR::AccessibilityUIElement::rangeForLine):
(WTR::AccessibilityUIElement::boundsForRange):
(WTR::AccessibilityUIElement::attributedStringForRange):
LayoutTests:
Updated the test identified in the bug to listen for the appropriate
notification for ATK and created platform-specific expectations.
In addition, set-selected-text-range-contenteditable.html was timing out
due to the use of shouldBecomeEqual() with an assertion that is wrong for
ATK. Modifying the test so that it verifies the result appropriate for
each platform eliminates the timeout.
- accessibility/content-editable-as-textarea.html: Updated.
- accessibility/set-selected-text-range-contenteditable.html: Updated.
- platform/gtk/TestExpectations: Unskipped the failing tests.
- platform/gtk/accessibility/content-editable-as-textarea-expected.txt: Added.
- platform/gtk/accessibility/set-selected-text-range-contenteditable-expected.txt: Added.
- 3:45 AM Changeset in webkit [201268] by
-
- 5 edits2 adds in releases/WebKitGTK/webkit-2.12
Merge r200622 - REGRESSION (r193610): Drop down menu doesn’t expand at allofbach.com
https://bugs.webkit.org/show_bug.cgi?id=157445
Reviewed by Simon Fraser.
When we don't run transitions (becasuse of to/from 'auto' values) we should also not
report the 'from' value and behave as if we finished the transition already.
Source/WebCore:
Test: fast/animation/height-auto-transition-computed-value.html
- page/animation/KeyframeAnimation.cpp:
(WebCore::KeyframeAnimation::fetchIntervalEndpointsForProperty): This is a revert of
looping the 'to' value back to the first keyframe when reverse animation is at the start value (last keyframe).
- platform/Length.cpp:
(WebCore::blend):
LayoutTests:
- fast/animation/height-auto-transition-computed-value-expected.html: Added.
- fast/animation/height-auto-transition-computed-value.html: Added.
- imported/blink/transitions/transition-not-interpolable-expected.txt:
- 12:21 AM Changeset in webkit [201267] by
-
- 6 edits in trunk/Source/WebKit2
[GTK] Disk cache: enable speculative revalidation
https://bugs.webkit.org/show_bug.cgi?id=157125
Reviewed by Sergio Villar Senin.
- NetworkProcess/soup/NetworkProcessSoup.cpp:
(WebKit::NetworkProcess::platformInitializeNetworkProcess):
- UIProcess/API/gtk/WebKitWebContext.cpp:
(webkitWebContextConstructed):
- UIProcess/Cocoa/WebProcessPoolCocoa.mm:
(WebKit::WebProcessPool::platformInitializeNetworkProcess):
- UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::ensureNetworkProcess):
- config.h:
May 22, 2016:
- 9:02 PM Changeset in webkit [201266] by
-
- 2 edits in trunk/Source/JavaScriptCore
Unreviewed. Fixed debug assertion failures from r201235.
- runtime/JSScope.cpp:
(JSC::abstractAccess):
- 6:35 PM Changeset in webkit [201265] by
-
- 2 edits in trunk/Source/WTF
Added NSEventMaskMouseMoved to AppKitCompatibilityDeclarations.h.
Rubber-stamped by Anders Carlsson.
- wtf/mac/AppKitCompatibilityDeclarations.h:
- 4:29 PM Changeset in webkit [201264] by
-
- 1 copy in tags/Safari-602.1.32.5
New tag.
- 3:55 PM Changeset in webkit [201263] by
-
- 2 edits in trunk/Tools
RELEASE_ASSERT(TestController::singleton().isCurrentInvocation(testInvocation)) is sometimes hit when running tests
https://bugs.webkit.org/show_bug.cgi?id=157977
rdar://problem/20874156
Reviewed by David Kilzer.
- WebKitTestRunner/TestInvocation.cpp:
(WTR::TestInvocation::invoke): Be more certain to launch a new process when there was
a timeout detected. If we don't, there is a chance that the process is not quite frozen,
and will still send a response that we no longer expect.
(WTR::TestInvocation::dumpWebProcessUnresponsiveness): Print timeout details to stderr
too, as stdout is not available, at least not in the case that I was observing.
- 3:36 PM Changeset in webkit [201262] by
-
- 2 edits in trunk/Source/WTF
Another attempt to fix the GTK build after my previous changes.
- wtf/StdLibExtras.h:
- 3:31 PM Changeset in webkit [201261] by
-
- 2 edits in trunk/Source/WTF
Tried to fix the GTK build after r201257.
- wtf/StdLibExtras.h:
- 3:22 PM Changeset in webkit [201260] by
-
- 2 edits in trunk/Source/WTF
Additional fixes for non-C++14 Apple projects that use WTF.
- wtf/StdLibExtras.h:
(std::exchange):
- 3:21 PM Changeset in webkit [201259] by
-
- 2 edits in trunk/Source/JavaScriptCore
Attempted Yosemite build fix after http://trac.webkit.org/changeset/201255
Suggested by and reviewed by Anders Carlsson.
- b3/B3CCallValue.h: Initialize the effects member more conventionally.
- 3:19 PM Changeset in webkit [201258] by
-
- 2 edits in trunk/Source/WTF
Additional fixes for non-C++14 Apple projects that use WTF.
- wtf/StdLibExtras.h:
(std::make_unique):
(std::move):
- 3:04 PM Changeset in webkit [201257] by
-
- 2 edits in trunk/Source/WTF
Correct the previous build fix attempt.
- wtf/StdLibExtras.h:
- 2:10 PM Changeset in webkit [201256] by
-
- 2 edits in trunk/Source/WTF
Build fix for non-C++14 Apple projects that use WTF.
Rubber-stamped by Anders.
- wtf/StdLibExtras.h:
- 1:09 PM Changeset in webkit [201255] by
-
- 37 edits in trunk
Move to C++14.
https://bugs.webkit.org/show_bug.cgi?id=157948
Reviewed by Michael Catanzaro.
.:
- Source/cmake/OptionsCommon.cmake:
Source/bmalloc:
- Configurations/Base.xcconfig:
Source/JavaScriptCore:
- Configurations/Base.xcconfig:
Source/ThirdParty:
- gtest/xcode/Config/General.xcconfig:
Source/ThirdParty/ANGLE:
- Configurations/Base.xcconfig:
Source/WebCore:
No new tests (No change in behavior).
- Configurations/Base.xcconfig:
Replace time literal suffixes that have underscores to the forms without
(e.g. 0_ms becomes 0ms):
- page/mac/ServicesOverlayController.mm:
(WebCore::ServicesOverlayController::remainingTimeUntilHighlightShouldBeShown):
- platform/graphics/cg/IOSurfacePool.cpp:
Source/WebInspectorUI:
- Configurations/Base.xcconfig:
Source/WebKit/mac:
- Configurations/Base.xcconfig:
Source/WebKit2:
- Configurations/Base.xcconfig:
Replace time literal suffixes that have underscores to the forms without
(e.g. 0_ms becomes 0ms):
- NetworkProcess/NetworkResourceLoadParameters.cpp:
(WebKit::NetworkResourceLoadParameters::NetworkResourceLoadParameters):
- NetworkProcess/NetworkResourceLoader.cpp:
(WebKit::NetworkResourceLoader::startNetworkLoad):
- NetworkProcess/cache/NetworkCache.cpp:
(WebKit::NetworkCache::responseHasExpired):
(WebKit::NetworkCache::responseNeedsRevalidation):
(WebKit::NetworkCache::makeStoreDecision):
- NetworkProcess/cache/NetworkCacheSpeculativeLoadManager.cpp:
(WebKit::NetworkCache::responseNeedsRevalidation):
- NetworkProcess/cache/NetworkCacheStorage.cpp:
(WebKit::NetworkCache::Storage::dispatchReadOperation):
(WebKit::NetworkCache::Storage::store):
(WebKit::NetworkCache::computeRecordWorth):
- Shared/mac/RemoteLayerBackingStoreCollection.mm:
- UIProcess/ViewGestureController.cpp:
- WebProcess/Network/WebLoaderStrategy.cpp:
(WebKit::maximumBufferingTime):
- WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm:
(WebKit::RemoteLayerTreeDrawingArea::scheduleCompositingLayerFlushImmediately):
(WebKit::RemoteLayerTreeDrawingArea::scheduleCompositingLayerFlush):
Source/WTF:
- Configurations/Base.xcconfig:
Delete a lot of "stl additions until we can adopt C++14" code:
- wtf/StdLibExtras.h:
(std::make_unique): Deleted.
(std::index_sequence::size): Deleted.
(std::exchange): Deleted.
(std::literals::chrono_literals::operator _s): Deleted.
(std::literals::chrono_literals::operator _ms): Deleted.
Tools:
- DumpRenderTree/mac/Configurations/Base.xcconfig:
- MiniBrowser/Configurations/Base.xcconfig:
- TestWebKitAPI/Configurations/Base.xcconfig:
- WebKitTestRunner/Configurations/Base.xcconfig:
- 12:13 PM Changeset in webkit [201254] by
-
- 4 edits1 add in trunk
REGRESSION(r199075): String.prototype.replace fails after being used many times with different replace values
https://bugs.webkit.org/show_bug.cgi?id=157968
<rdar://problem/26404735>
Reviewed by Ryosuke Niwa and Filip Pizlo.
Source/JavaScriptCore:
There was a bug in the DFG where we were checking a condition
on the wrong variable.
- dfg/DFGStrengthReductionPhase.cpp:
(JSC::DFG::StrengthReductionPhase::handleNode):
LayoutTests:
- 10:27 AM Changeset in webkit [201253] by
-
- 22 edits in trunk/Source
Remove uses of PassRefPtr in JS bindings code
https://bugs.webkit.org/show_bug.cgi?id=157949
Reviewed by Andreas Kling.
Remove uses of PassRefPtr in JS bindings code.
Source/JavaScriptCore:
- runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::queueMicrotask):
- runtime/JSGlobalObject.h:
Source/WebCore:
- bindings/js/JSDOMBinding.cpp:
(WebCore::jsArray):
- bindings/js/JSDOMBinding.h:
- bindings/js/JSDOMGlobalObject.cpp:
(WebCore::JSDOMGlobalObject::JSDOMGlobalObject):
- bindings/js/JSDOMGlobalObject.h:
- bindings/js/JSDOMGlobalObjectTask.cpp:
(WebCore::JSGlobalObjectTask::JSGlobalObjectTask):
- bindings/js/JSDOMGlobalObjectTask.h:
- bindings/js/JSDOMWindowBase.cpp:
(WebCore::JSDOMWindowBase::JSDOMWindowBase):
(WebCore::JSDOMWindowMicrotaskCallback::create):
(WebCore::JSDOMWindowMicrotaskCallback::call):
(WebCore::JSDOMWindowMicrotaskCallback::JSDOMWindowMicrotaskCallback):
(WebCore::JSDOMWindowBase::queueTaskToEventLoop):
- bindings/js/JSDOMWindowBase.h:
- bindings/js/JSDOMWindowShell.cpp:
(WebCore::JSDOMWindowShell::finishCreation):
(WebCore::JSDOMWindowShell::setWindow):
- bindings/js/JSDOMWindowShell.h:
(WebCore::JSDOMWindowShell::create):
- bindings/js/JSWorkerGlobalScopeBase.cpp:
(WebCore::JSWorkerGlobalScopeBase::JSWorkerGlobalScopeBase):
(WebCore::JSWorkerGlobalScopeBase::queueTaskToEventLoop):
- bindings/js/JSWorkerGlobalScopeBase.h:
- bindings/objc/DOMCustomXPathNSResolver.h:
- bindings/scripts/CodeGeneratorJS.pm:
(GetNativeTypeForCallbacks):
- bindings/scripts/test/JS/JSTestCallback.cpp:
(WebCore::JSTestCallback::callbackWithSerializedScriptValueParam):
(WebCore::JSTestCallback::callbackWithStringList):
- bindings/scripts/test/JS/JSTestCallback.h:
- bindings/scripts/test/JS/JSTestCallbackFunction.cpp:
(WebCore::JSTestCallbackFunction::callbackWithSerializedScriptValueParam):
(WebCore::JSTestCallbackFunction::callbackWithStringList):
- bindings/scripts/test/JS/JSTestCallbackFunction.h:
- 9:51 AM Changeset in webkit [201252] by
-
- 3 edits in branches/safari-602.1.32-branch/Source/WebKit2
Merge r201246. rdar://problem/22524550
- 9:51 AM Changeset in webkit [201251] by
-
- 2 edits in branches/safari-602.1.32-branch/Source/WebCore
Merge r201241. rdar://problem/26396532
- 9:51 AM Changeset in webkit [201250] by
-
- 2 edits in branches/safari-602.1.32-branch/Source/WebCore
Merge r201229. rdar://problem/26396532
- 9:51 AM Changeset in webkit [201249] by
-
- 2 edits in branches/safari-602.1.32-branch/Source/WebCore
Merge r201233. rdar://problem/26397571
- 9:45 AM Changeset in webkit [201248] by
-
- 5 edits in branches/safari-602.1.32-branch/Source
Versioning.
- 3:58 AM Changeset in webkit [201247] by
-
- 2 edits in trunk
Suppress -Wmissing-field-initializers warnings with GCC 4.9
https://bugs.webkit.org/show_bug.cgi?id=157888
Reviewed by Michael Catanzaro.
- Source/cmake/WebKitHelpers.cmake:
May 21, 2016:
- 9:19 PM WebKitGTK/2.12.x edited by
- I'm in X, let's copy/paste (diff)
- 4:52 PM Changeset in webkit [201246] by
-
- 3 edits in trunk/Source/WebKit2
REGRESSION (r188642): All pages are blank when printing a webpage in iOS Safari
https://bugs.webkit.org/show_bug.cgi?id=157924
rdar://problem/22524550
Reviewed by Sam Weinig.
When UIPrintInteractionController asks WKWebView to print a webpage, it does so in several phases. First we're
asked to compute the page count, followed later by a series of messages asking us to draw each page into a
provided CGContext.
When asked for the page count, we send a message to the Web process instructing it to compute and
return the page count synchronously and then immediately start drawing the page for printing. If the drawing has
finished by the time we're asked to print the first page, then we can do so without waiting. But if it hasn't
then we block by calling Connection::waitForMessage(), passing std::chromo::milliseconds::max() as the relative
timeout.
Prior to r188642, Connection::waitForMessage() called std::condition_variable::wait_for(), which takes a
relative timeout value. r188642 replaced this with WTF::Condition::waitUntil(), which takes an absolute timeout
instead. To convert from relative to absolute, this line was added to Connection::waitForMessage():
Condition::Clock::time_point absoluteTimeout = Condition::Clock::now() + timeout;
std::chrono will convert both operands to a common duration type before performing the addition. When timeout
equals something very large, like milliseconds::max(), this conversion results in signed integer overflow,
giving absoluteTimeout a value less than Clock::now() and making waitForMessage time out immediately.
To fix this, compute how many milliseconds remain on our clock, and add the smaller of that and the timeout
value to Clock::now() to arrive at an absolute timeout.
- Platform/IPC/Connection.cpp:
(IPC::Connection::waitForMessage):
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _printedDocument]): Removed an unnecessary nanoseconds-to-milliseconds conversion.
- 12:21 PM Changeset in webkit [201245] by
-
- 14 edits in trunk/Source/WebInspectorUI
Web Inspector: Creating the CSSStyleDetailsSidebarPanel takes about 50ms (20%) of main load
https://bugs.webkit.org/show_bug.cgi?id=156707
<rdar://problem/25780404>
Reviewed by Timothy Hatcher.
This patch adds new View concepts,
initialLayoutandwidthDidChange,
making it possible for hidden views to postpone the creation of their
UI subtree until they are shown for the first time.
Sidebar panels get this performance improvement by virtue of SidebarPanel
and StyleDetailsPanel, which trigger a layout when shown. This can be
removed once <https://webkit.org/b/150741> is fixed, and this is done
automatically by View.
- UserInterface/Views/CSSStyleDeclarationTextEditor.js:
(WebInspector.CSSStyleDeclarationTextEditor):
Should subclass View.
(WebInspector.CSSStyleDeclarationTextEditor.prototype.layout):
(WebInspector.CSSStyleDeclarationTextEditor.prototype.get element): Deleted.
Handled in View base class.
(WebInspector.CSSStyleDeclarationTextEditor.prototype.updateLayout): Deleted.
Relocate tolayoutoverride, ignore unused parameterforce.
- UserInterface/Views/CSSStyleDetailsSidebarPanel.js:
(WebInspector.CSSStyleDetailsSidebarPanel):
Create the minimum required initial state and UI elements. Relocate
anything that can be lazy loaded toinitialLayout.
(WebInspector.CSSStyleDetailsSidebarPanel.prototype.initialLayout):
(WebInspector.CSSStyleDetailsSidebarPanel.prototype.sizeDidChange):
(WebInspector.CSSStyleDetailsSidebarPanel.prototype.widthDidChange): Deleted.
- UserInterface/Views/ComputedStyleDetailsPanel.js:
(WebInspector.ComputedStyleDetailsPanel):
Relocate anything that can be lazy loaded toinitialLayout.
(WebInspector.ComputedStyleDetailsPanel.prototype.initialLayout):
(WebInspector.ComputedStyleDetailsPanel.prototype.shown): Deleted.
(WebInspector.ComputedStyleDetailsPanel.prototype.widthDidChange): Deleted.
Handled in View base class.
- UserInterface/Views/DataGrid.js:
(WebInspector.DataGrid.prototype.layout):
Resize logic can be safely moved tosizeDidChange, since columns are
always initialized when the width changes.
(WebInspector.DataGrid.prototype.sizeDidChange):
Reposition headers, scrollbars.
(WebInspector.DataGrid.prototype._updateHeaderAndScrollbar):
Broke out header repositioning, which needs to be called whenever
column widths are initialized or the view size changes.
- UserInterface/Views/NavigationBar.js:
(WebInspector.NavigationBar.prototype.layout):
- UserInterface/Views/RulesStyleDetailsPanel.js:
(WebInspector.RulesStyleDetailsPanel.prototype.sizeDidChange):
(WebInspector.RulesStyleDetailsPanel.prototype.widthDidChange): Deleted.
- UserInterface/Views/Sidebar.js:
(WebInspector.Sidebar.prototype._recalculateWidth):
Width changes need to be coordinated by the View base class, since the
initial layout must have occurred before handling a width change.
Force a layout with a resize layout reason.
- UserInterface/Views/SidebarPanel.js:
(WebInspector.SidebarPanel.prototype.get displayName):
Drive-by style fix: add getter so that CSSStyleDetailsSidebarPanel
doesn't have to read the private property directly.
(WebInspector.SidebarPanel.prototype.shown):
Force a layout whenever the panel is shown.
(WebInspector.SidebarPanel.prototype.sizeDidChange):
(WebInspector.SidebarPanel):
(WebInspector.SidebarPanel.prototype.widthDidChange): Deleted.
- UserInterface/Views/StyleDetailsPanel.js:
(WebInspector.StyleDetailsPanel.prototype.shown):
Schedule a layout when shown. A forced layout isn't necessary.
Unlike SidebarPanels, the initial state of style panels doesn't depend
on its layout, and can be safely initialized by the next rAF.
(WebInspector.StyleDetailsPanel.prototype.hidden):
Cancel a pending layout if the panel is hidden before the next AF.
(WebInspector.StyleDetailsPanel.prototype.widthDidChange): Deleted.
Not needed, defined in View base class.
- UserInterface/Views/TimelineOverview.js:
(WebInspector.TimelineOverview.prototype.sizeDidChange):
(WebInspector.TimelineOverview.prototype.layout):
Moved resize logic tosizeDidChange.
- UserInterface/Views/TimelineRuler.js:
(WebInspector.TimelineRuler.prototype.sizeDidChange):
(WebInspector.TimelineRuler.prototype.layout):
Moved resize logic tosizeDidChange.
- UserInterface/Views/View.js:
(WebInspector.View):
(WebInspector.View.prototype.updateLayout):
(WebInspector.View.prototype.cancelLayout):
Allow a pending layout to be canceled. Useful when a view with a
pending layout is hidden before the layout occurs.
(WebInspector.View.prototype.get layoutReason):
Protected getter for subclasses that need to check the layout reason
outsidesizeDidChange.
(WebInspector.View.prototype.initialLayout):
Subclass hook to create UI subtree the first time a layout occurs.
Called only once during the lifetime of the View.
(WebInspector.View.prototype.layout):
Drive-by comment fix.
(WebInspector.View.prototype.sizeDidChange):
New layout cycle hook for subclasses.
(WebInspector.View.prototype._layoutSubtree):
Do an initial layout the first time layout is called.
Call thesizeDidChangehook so that subclasses can update state
which depends on size/position before doing layout.
- UserInterface/Views/VisualStyleDetailsPanel.js:
(WebInspector.VisualStyleDetailsPanel):
Create the minimum required initial state and UI elements. Relocate
anything that can be lazy loaded toinitialLayout.
(WebInspector.VisualStyleDetailsPanel.prototype.refresh):
No changes, shifting line numbers confused the diff.
(WebInspector.VisualStyleDetailsPanel.prototype.initialLayout):
(WebInspector.VisualStyleDetailsPanel.prototype.sizeDidChange):
(WebInspector.VisualStyleDetailsPanel.prototype.widthDidChange): Deleted.
- 12:21 PM Changeset in webkit [201244] by
-
- 2 edits in trunk/Tools
Simulator launch fails intermittently due to failure in checking simulator boot status
https://bugs.webkit.org/show_bug.cgi?id=157965
rdar://problem/26402404
Reviewed by Alexey Proskuryakov.
- Scripts/webkitpy/xcode/simulator.py:
(Simulator.wait_until_device_is_booted): Ignore CalledProcessError exception while checking
whether simulator has finished booting.
- 11:42 AM Changeset in webkit [201243] by
-
- 3 edits in trunk/Source/WebInspectorUI
Assertion Failed: StyleDetailsPanel.markAsNeedsRefresh() called with null domNode
https://bugs.webkit.org/show_bug.cgi?id=157955
<rdar://problem/26398943>
Reviewed by Timothy Hatcher.
CSSStyleDetailsSidebarPanel
visibleis true while the panel is being
removed from the details sidebar, even after callinghidden(). This
causes it to refresh its current StyleDetailsPanel with a null DOM node.
Unfortunately, SidebarPanel.visible isn't toggled by calling shown/hidden.
Since SidebarPanel.visible is only true if the panel is selected, we should
deselect panels before removing them.
- UserInterface/Views/Sidebar.js:
(WebInspector.Sidebar.prototype.removeSidebarPanel):
Deselect the panel being removed before calling visibiltyDidChange.
- UserInterface/Views/SidebarPanel.js:
(WebInspector.SidebarPanel.prototype.toggle): Deleted.
(WebInspector.SidebarPanel.prototype.willRemove): Deleted.
Drive-by update to remove some unused methods.
- 10:10 AM Changeset in webkit [201242] by
-
- 3 edits in trunk/Tools
Silence warnings from svn propget when using newer versions of Subversion.
https://bugs.webkit.org/show_bug.cgi?id=157879
Reviewed by Daniel Bates.
- Scripts/prepare-ChangeLog:
(attributeCommand): Redirect svn propget stderr to /dev/null.
- Scripts/svn-create-patch:
(findMimeType): Ditto.
May 20, 2016:
- 11:15 PM Changeset in webkit [201241] by
-
- 2 edits in trunk/Source/WebCore
Fixed USE(APPLE_INTERNAL_SDK) builds.
- platform/cocoa/ThemeCocoa.mm:
(WebCore::fitContextToBox):
- 10:22 PM Changeset in webkit [201240] by
-
- 2 edits in trunk/LayoutTests
Unreviewed test gardening after r201237 exposed an issue.
- 10:17 PM Changeset in webkit [201239] by
-
- 48 edits13 deletes in trunk/Source
Remove LegacyProfiler
https://bugs.webkit.org/show_bug.cgi?id=153565
Reviewed by Mark Lam.
Source/JavaScriptCore:
JavaScriptCore now provides a sampling profiler and it is enabled
by all ports. Web Inspector switched months ago to using the
sampling profiler and displaying its data. Remove the legacy
profiler, as it is no longer being used by anything other then
console.profile and tests. We will update console.profile's
behavior soon to have new behavior and use the sampling data.
- API/JSProfilerPrivate.cpp: Removed.
- API/JSProfilerPrivate.h: Removed.
- CMakeLists.txt:
- JavaScriptCore.xcodeproj/project.pbxproj:
- bytecode/BytecodeList.json:
- bytecode/BytecodeUseDef.h:
(JSC::computeUsesForBytecodeOffset): Deleted.
(JSC::computeDefsForBytecodeOffset): Deleted.
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::dumpBytecode): Deleted.
- bytecode/UnlinkedFunctionExecutable.cpp:
(JSC::generateUnlinkedFunctionCodeBlock):
(JSC::UnlinkedFunctionExecutable::unlinkedCodeBlockFor):
- bytecode/UnlinkedFunctionExecutable.h:
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::BytecodeGenerator):
(JSC::BytecodeGenerator::emitCall):
(JSC::BytecodeGenerator::emitCallVarargs):
(JSC::BytecodeGenerator::emitCallVarargsInTailPosition):
(JSC::BytecodeGenerator::emitConstructVarargs):
(JSC::BytecodeGenerator::emitConstruct):
- bytecompiler/BytecodeGenerator.h:
(JSC::CallArguments::profileHookRegister): Deleted.
(JSC::BytecodeGenerator::shouldEmitProfileHooks): Deleted.
- bytecompiler/NodesCodegen.cpp:
(JSC::CallFunctionCallDotNode::emitBytecode):
(JSC::ApplyFunctionCallDotNode::emitBytecode):
(JSC::CallArguments::CallArguments): Deleted.
- dfg/DFGAbstractInterpreterInlines.h:
(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects): Deleted.
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock): Deleted.
- dfg/DFGCapabilities.cpp:
(JSC::DFG::capabilityLevel): Deleted.
- dfg/DFGClobberize.h:
(JSC::DFG::clobberize): Deleted.
- dfg/DFGDoesGC.cpp:
(JSC::DFG::doesGC): Deleted.
- dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode): Deleted.
- dfg/DFGNodeType.h:
- dfg/DFGPredictionPropagationPhase.cpp:
- dfg/DFGSafeToExecute.h:
(JSC::DFG::safeToExecute): Deleted.
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile): Deleted.
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile): Deleted.
- inspector/InjectedScriptBase.cpp:
(Inspector::InjectedScriptBase::callFunctionWithEvalEnabled):
- interpreter/Interpreter.cpp:
(JSC::UnwindFunctor::operator()): Deleted.
(JSC::Interpreter::execute): Deleted.
(JSC::Interpreter::executeCall): Deleted.
(JSC::Interpreter::executeConstruct): Deleted.
- jit/JIT.cpp:
(JSC::JIT::privateCompileMainPass): Deleted.
- jit/JIT.h:
- jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_profile_will_call): Deleted.
(JSC::JIT::emit_op_profile_did_call): Deleted.
- jit/JITOpcodes32_64.cpp:
(JSC::JIT::emit_op_profile_will_call): Deleted.
(JSC::JIT::emit_op_profile_did_call): Deleted.
- jit/JITOperations.cpp:
- jit/JITOperations.h:
- llint/LLIntSlowPaths.cpp:
(JSC::LLInt::LLINT_SLOW_PATH_DECL): Deleted.
- llint/LLIntSlowPaths.h:
- llint/LowLevelInterpreter.asm:
- parser/ParserModes.h:
- profiler/CallIdentifier.h: Removed.
- profiler/LegacyProfiler.cpp: Removed.
- profiler/LegacyProfiler.h: Removed.
- profiler/Profile.cpp: Removed.
- profiler/Profile.h: Removed.
- profiler/ProfileGenerator.cpp: Removed.
- profiler/ProfileGenerator.h: Removed.
- profiler/ProfileNode.cpp: Removed.
- profiler/ProfileNode.h: Removed.
- profiler/ProfilerJettisonReason.cpp:
(WTF::printInternal): Deleted.
- profiler/ProfilerJettisonReason.h:
- runtime/CodeCache.cpp:
(JSC::CodeCache::getGlobalCodeBlock):
(JSC::CodeCache::getProgramCodeBlock):
(JSC::CodeCache::getEvalCodeBlock):
(JSC::CodeCache::getModuleProgramCodeBlock):
- runtime/CodeCache.h:
- runtime/Executable.cpp:
(JSC::ScriptExecutable::newCodeBlockFor):
- runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::createProgramCodeBlock):
(JSC::JSGlobalObject::createEvalCodeBlock):
(JSC::JSGlobalObject::createModuleProgramCodeBlock):
(JSC::JSGlobalObject::~JSGlobalObject): Deleted.
(JSC::JSGlobalObject::hasLegacyProfiler): Deleted.
- runtime/JSGlobalObject.h:
- runtime/Options.h:
- runtime/VM.cpp:
(JSC::VM::VM): Deleted.
(JSC::SetEnabledProfilerFunctor::operator()): Deleted.
(JSC::VM::setEnabledProfiler): Deleted.
- runtime/VM.h:
(JSC::VM::enabledProfiler): Deleted.
(JSC::VM::enabledProfilerAddress): Deleted.
Source/WebCore:
- ForwardingHeaders/profiler/Profile.h: Removed.
- ForwardingHeaders/profiler/ProfileNode.h: Removed.
- testing/js/WebCoreTestSupport.cpp:
- xml/XSLStyleSheetLibxslt.cpp:
- xml/XSLTProcessorLibxslt.cpp:
- 8:57 PM Changeset in webkit [201238] by
-
- 6 edits in trunk
run-benchmark's results should contain Animometer's debug output
https://bugs.webkit.org/show_bug.cgi?id=157941
Reviewed by Stephanie Lewis.
PerformanceTests:
Made developer.html support the JSON generated by run-benchmark which stores everything under debugOutput.
- Animometer/resources/debug-runner/animometer.js:
(Utilities.initialize): Unwrap debugOutput in the case run-benchmark's result JSON is used.
Tools:
Modified the Animometer patch to store debug output and made benchmark_runner extract them together as a single array.
The result can be dragged and dropped into Animometer's developer.html page.
- Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
(BenchmarkRunner._run_one_test): Parse JSON here instead of doing it in multiple call sites.
(BenchmarkRunner._run_benchmark): Strip debugOutput from individual test result, and merge them together separately.
- Scripts/webkitpy/benchmark_runner/data/patches/Animometer.patch:
Modified the patch to store the debug output.
- Scripts/webkitpy/benchmark_runner/http_server_driver/http_server/twisted_http_server.py:
(ServerControl.render_POST): Fixed a bug that POST to /report results in 500 because getvalue is not defined
when the request body is larger than a certain size on twisted.
- 7:00 PM Changeset in webkit [201237] by
-
- 51 edits8 deletes in trunk
Remove LegacyProfiler
https://bugs.webkit.org/show_bug.cgi?id=153565
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-05-20
Reviewed by Saam Barati.
.:
- ManualTests/inspector/profiler-test-call.html: Removed.
- ManualTests/inspector/profiler-test-many-calls-in-the-same-scope.html: Removed.
Source/JavaScriptCore:
- inspector/protocol/Timeline.json:
- jsc.cpp:
- runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::hasLegacyProfiler):
- runtime/JSGlobalObject.h:
(JSC::JSGlobalObject::supportsLegacyProfiling): Deleted.
Source/WebCore:
JavaScriptCore now provides a sampling profiler and it is enabled
by all ports. Web Inspector switched months ago to using the
sampling profiler and displaying its data. Remove the legacy
profiler, as it is no longer being used by anything other then
console.profile and tests. We will update console.profile's
behavior soon to have new behavior and use the sampling data.
- CMakeLists.txt:
- DerivedSources.cpp:
- DerivedSources.make:
- ForwardingHeaders/profiler/LegacyProfiler.h: Removed.
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSCustomXPathNSResolver.cpp:
- bindings/js/JSDOMWindowBase.cpp:
(WebCore::JSDOMWindowBase::supportsLegacyProfiling): Deleted.
(WebCore::JSDOMWindowBase::supportsRichSourceInfo): Deleted.
- bindings/js/JSDOMWindowBase.h:
- bindings/js/JSWorkerGlobalScopeBase.cpp:
(WebCore::JSWorkerGlobalScopeBase::supportsLegacyProfiling): Deleted.
- bindings/js/JSWorkerGlobalScopeBase.h:
- bindings/js/ScriptCachedFrameData.cpp:
- bindings/js/ScriptController.cpp:
(WebCore::ScriptController::clearWindowShell): Deleted.
- bindings/js/ScriptProfile.h: Removed.
- bindings/js/ScriptProfileNode.h: Removed.
- bindings/scripts/CodeGeneratorJS.pm:
(AddClassForwardIfNeeded): Deleted.
- bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::jsTestObjPrototypeFunctionMethodWithSequenceArg): Deleted.
(WebCore::jsTestObjPrototypeFunctionMethodReturningSequence): Deleted.
- bindings/scripts/test/TestObj.idl:
- css/CSSParser.cpp:
- dom/Document.cpp:
- inspector/InspectorConsoleInstrumentation.h:
(WebCore::InspectorInstrumentation::stopProfiling):
- inspector/InspectorController.cpp:
(WebCore::InspectorController::InspectorController):
(WebCore::InspectorController::legacyProfilerEnabled): Deleted.
(WebCore::InspectorController::setLegacyProfilerEnabled): Deleted.
- inspector/InspectorController.h:
- inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::stopProfilingImpl):
- inspector/InspectorInstrumentation.h:
- inspector/InspectorTimelineAgent.cpp:
(WebCore::InspectorTimelineAgent::startFromConsole):
(WebCore::InspectorTimelineAgent::stopFromConsole):
- inspector/InspectorTimelineAgent.h:
- inspector/PageDebuggerAgent.cpp:
- inspector/PageRuntimeAgent.cpp:
- inspector/ScriptProfile.idl: Removed.
- inspector/ScriptProfileNode.idl: Removed.
- inspector/TimelineRecordFactory.cpp:
(WebCore::buildAggregateCallInfoInspectorObject): Deleted.
(WebCore::buildInspectorObject): Deleted.
(WebCore::buildProfileInspectorObject): Deleted.
(WebCore::TimelineRecordFactory::appendProfile): Deleted.
- inspector/TimelineRecordFactory.h:
- page/DOMWindow.cpp:
- page/Page.cpp:
- page/PageConsoleClient.cpp:
(WebCore::PageConsoleClient::profileEnd):
(WebCore::PageConsoleClient::clearProfiles): Deleted.
- page/PageConsoleClient.h:
- testing/Internals.cpp:
(WebCore::Internals::resetToConsistentState): Deleted.
(WebCore::Internals::consoleProfiles): Deleted.
(WebCore::Internals::setLegacyJavaScriptProfilingEnabled): Deleted.
- testing/Internals.h:
- testing/Internals.idl:
Source/WebKit/win:
- Interfaces/IWebInspector.idl:
- WebCoreStatistics.cpp:
- WebInspector.cpp:
(WebInspector::isJavaScriptProfilingEnabled): Deleted.
(WebInspector::setJavaScriptProfilingEnabled): Deleted.
- WebInspector.h:
- WebView.cpp:
LayoutTests:
- fast/profiler/anonymous-event-handler-expected.txt: Removed.
- fast/profiler/anonymous-event-handler.html: Removed.
- fast/profiler/anonymous-function-called-from-different-contexts-expected.txt: Removed.
- fast/profiler/anonymous-function-called-from-different-contexts.html: Removed.
- fast/profiler/anonymous-function-calls-built-in-functions-expected.txt: Removed.
- fast/profiler/anonymous-function-calls-built-in-functions.html: Removed.
- fast/profiler/anonymous-function-calls-eval-expected.txt: Removed.
- fast/profiler/anonymous-function-calls-eval.html: Removed.
- fast/profiler/anonymous-functions-with-display-names-expected.txt: Removed.
- fast/profiler/anonymous-functions-with-display-names.html: Removed.
- fast/profiler/apply-expected.txt: Removed.
- fast/profiler/apply.html: Removed.
- fast/profiler/built-in-function-calls-anonymous-expected.txt: Removed.
- fast/profiler/built-in-function-calls-anonymous.html: Removed.
- fast/profiler/built-in-function-calls-user-defined-function-expected.txt: Removed.
- fast/profiler/built-in-function-calls-user-defined-function.html: Removed.
- fast/profiler/call-expected.txt: Removed.
- fast/profiler/call-register-leak-expected.txt: Removed.
- fast/profiler/call-register-leak.html: Removed.
- fast/profiler/call.html: Removed.
- fast/profiler/calling-the-function-that-started-the-profiler-from-another-scope-expected.txt: Removed.
- fast/profiler/calling-the-function-that-started-the-profiler-from-another-scope.html: Removed.
- fast/profiler/compare-multiple-profiles-expected.txt: Removed.
- fast/profiler/compare-multiple-profiles.html: Removed.
- fast/profiler/constructor-expected.txt: Removed.
- fast/profiler/constructor.html: Removed.
- fast/profiler/dead-time-expected.txt: Removed.
- fast/profiler/dead-time.html: Removed.
- fast/profiler/document-dot-write-expected.txt: Removed.
- fast/profiler/document-dot-write.html: Removed.
- fast/profiler/event-handler-expected.txt: Removed.
- fast/profiler/event-handler.html: Removed.
- fast/profiler/execution-context-and-eval-on-same-line-expected.txt: Removed.
- fast/profiler/execution-context-and-eval-on-same-line.html: Removed.
- fast/profiler/inline-event-handler-expected.txt: Removed.
- fast/profiler/inline-event-handler.html: Removed.
- fast/profiler/many-calls-in-the-same-scope-expected.txt: Removed.
- fast/profiler/many-calls-in-the-same-scope.html: Removed.
- fast/profiler/multiple-and-different-scoped-anonymous-function-calls-expected.txt: Removed.
- fast/profiler/multiple-and-different-scoped-anonymous-function-calls.html: Removed.
- fast/profiler/multiple-and-different-scoped-function-calls-expected.txt: Removed.
- fast/profiler/multiple-and-different-scoped-function-calls.html: Removed.
- fast/profiler/multiple-anonymous-functions-called-from-the-same-function-expected.txt: Removed.
- fast/profiler/multiple-anonymous-functions-called-from-the-same-function.html: Removed.
- fast/profiler/multiple-frames-expected.txt: Removed.
- fast/profiler/multiple-frames.html: Removed.
- fast/profiler/named-functions-with-display-names-expected.txt: Removed.
- fast/profiler/named-functions-with-display-names.html: Removed.
- fast/profiler/nested-anonymous-functon-expected.txt: Removed.
- fast/profiler/nested-anonymous-functon.html: Removed.
- fast/profiler/nested-start-and-stop-profiler-expected.txt: Removed.
- fast/profiler/nested-start-and-stop-profiler.html: Removed.
- fast/profiler/no-execution-context-expected.txt: Removed.
- fast/profiler/no-execution-context.html: Removed.
- fast/profiler/one-execution-context-expected.txt: Removed.
- fast/profiler/one-execution-context.html: Removed.
- fast/profiler/profile-calls-in-included-file-expected.txt: Removed.
- fast/profiler/profile-calls-in-included-file.html: Removed.
- fast/profiler/profile-with-no-title-expected.txt: Removed.
- fast/profiler/profile-with-no-title.html: Removed.
- fast/profiler/profiling-from-a-nested-location-but-stop-profiling-outside-the-nesting-expected.txt: Removed.
- fast/profiler/profiling-from-a-nested-location-but-stop-profiling-outside-the-nesting.html: Removed.
- fast/profiler/profiling-from-a-nested-location-expected.txt: Removed.
- fast/profiler/profiling-from-a-nested-location.html: Removed.
- fast/profiler/resources/other-frame.html: Removed.
- fast/profiler/resources/other-window.html: Removed.
- fast/profiler/resources/profiler-test-JS-resources.js: Removed.
- fast/profiler/simple-event-call-expected.txt: Removed.
- fast/profiler/simple-event-call.html: Removed.
- fast/profiler/simple-no-level-change-expected.txt: Removed.
- fast/profiler/simple-no-level-change.html: Removed.
- fast/profiler/start-and-stop-profiler-multiple-times-expected.txt: Removed.
- fast/profiler/start-and-stop-profiler-multiple-times.html: Removed.
- fast/profiler/start-and-stop-profiling-in-the-same-function-expected.txt: Removed.
- fast/profiler/start-and-stop-profiling-in-the-same-function.html: Removed.
- fast/profiler/start-but-dont-stop-profiling-expected.txt: Removed.
- fast/profiler/start-but-dont-stop-profiling.html: Removed.
- fast/profiler/stop-profiling-after-setTimeout-expected.txt: Removed.
- fast/profiler/stop-profiling-after-setTimeout.html: Removed.
- fast/profiler/stop-then-function-call-expected.txt: Removed.
- fast/profiler/stop-then-function-call.html: Removed.
- fast/profiler/throw-exception-from-eval-expected.txt: Removed.
- fast/profiler/throw-exception-from-eval.html-disabled: Removed.
- fast/profiler/two-execution-contexts-expected.txt: Removed.
- fast/profiler/two-execution-contexts.html: Removed.
- fast/profiler/user-defined-function-calls-built-in-functions-expected.txt: Removed.
- fast/profiler/user-defined-function-calls-built-in-functions.html: Removed.
- fast/profiler/window-dot-eval-expected.txt: Removed.
- fast/profiler/window-dot-eval.html: Removed.
- platform/efl/TestExpectations:
- platform/gtk/TestExpectations:
- platform/ios-simulator/TestExpectations:
- 6:17 PM Changeset in webkit [201236] by
-
- 1 copy in tags/Safari-602.1.32.4
New tag.
- 5:17 PM Changeset in webkit [201235] by
-
- 2 edits in trunk/Source/JavaScriptCore
JSScope::abstractAccess doesn't need to copy the SymbolTableEntry, it can use it by reference
https://bugs.webkit.org/show_bug.cgi?id=157956
Reviewed by Geoffrey Garen.
A SymbolTableEntry may be a FatEntry. Copying a FatEntry is slow because we have to
malloc memory for it, then free the malloced memory once the entry goes out of
scope. abstractAccess uses a SymbolTableEntry temporarily when performing scope
accesses during bytecode linking. It copies out the SymbolTableEntry every time
it does a SymbolTable lookup. This is not cheap when the entry happens to be a
FatEntry. We should really just be using a reference to the entry because
there is no need to copy it in such a scenario.
- runtime/JSScope.cpp:
(JSC::abstractAccess):
- 4:56 PM Changeset in webkit [201234] by
-
- 12 edits4 adds in trunk
width: 1%on nested table cell causes its table to hog horizontal space
https://bugs.webkit.org/show_bug.cgi?id=144696
<rdar://problem/20839572>
Reviewed by David Hyatt and Tim Horton.
This patch is based on https://chromium.googlesource.com/chromium/src/+/9428cfb16993a2329e87c65da096ca295132ef0f
Source/WebCore:
Tests: fast/table/inner-percent-width-affects-outer-floated-div.html
fast/table/inner-percent-width-doesnt-affect-ancestor-columns.html
- rendering/AutoTableLayout.cpp:
(WebCore::shouldScaleColumnsForParent):
(WebCore::shouldScaleColumnsForSelf):
(WebCore::AutoTableLayout::computeIntrinsicLogicalWidths):
(WebCore::shouldScaleColumns): Deleted.
- rendering/AutoTableLayout.h:
- rendering/RenderTable.cpp:
(WebCore::RenderTable::updateLogicalWidth):
- rendering/TableLayout.h:
(WebCore::TableLayout::scaledWidthFromPercentColumns):
LayoutTests:
- fast/table/inner-percent-width-affects-outer-floated-div-expected.html: Added.
- fast/table/inner-percent-width-affects-outer-floated-div.html: Added.
- fast/table/inner-percent-width-doesnt-affect-ancestor-columns-expected.html: Added.
- fast/table/inner-percent-width-doesnt-affect-ancestor-columns.html: Added.
- platform/mac/fast/table/border-collapsing/cached-change-row-border-width-expected.txt:
- platform/mac/fast/table/border-collapsing/cached-change-tbody-border-width-expected.txt:
- platform/mac/fast/table/max-width-integer-overflow-expected.txt:
- 4:46 PM Changeset in webkit [201233] by
-
- 2 edits in trunk/Source/WebCore
Inconsistent state in playback controls
https://bugs.webkit.org/show_bug.cgi?id=157962
<rdar://problem/26397571>
Reviewed by Beth Dakin.
Do not use the playbackSessionManager() as the model, that's what the model is for.
- platform/mac/WebPlaybackSessionInterfaceMac.mm:
(WebCore::WebPlaybackSessionInterfaceMac::setClient):
- 4:15 PM Changeset in webkit [201232] by
-
- 7 edits3 adds in trunk
Modern IDB: Properly handle blobs in Workers.
https://bugs.webkit.org/show_bug.cgi?id=157947
Reviewed by Alex Christensen.
Source/WebCore:
Test: storage/indexeddb/modern/blob-simple-workers.html
- Modules/indexeddb/IDBTransaction.cpp:
(WebCore::IDBTransaction::putOrAddOnServer): Use writeBlobsToDiskForIndexedDBSynchronously from
background threads instead of the asynchronous form.
Add ability to set an existing empty IDBValue to be an isolated copy of a different IDBValue:
- Modules/indexeddb/IDBValue.cpp:
(WebCore::IDBValue::setAsIsolatedCopy):
(WebCore::IDBValue::isolatedCopy):
- Modules/indexeddb/IDBValue.h:
Add a method - only to be called from a non-main thread - that synchronously writes blobs to disk:
- bindings/js/SerializedScriptValue.cpp:
(WebCore::SerializedScriptValue::writeBlobsToDiskForIndexedDBSynchronously):
- bindings/js/SerializedScriptValue.h:
LayoutTests:
- storage/indexeddb/modern/blob-simple-workers-expected.txt: Added.
- storage/indexeddb/modern/blob-simple-workers.html: Added.
- storage/indexeddb/modern/resources/blob-simple-workers.js: Added.
- 3:53 PM Changeset in webkit [201231] by
-
- 2 edits in trunk/Source/WebInspectorUI
REGRESSION(r200740): Web Inspector: TimelineRecordBar class lists not properly cleared, bleeding colors when zooming in and out
https://bugs.webkit.org/show_bug.cgi?id=157959
<rdar://problem/26393067>
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-05-20
Reviewed by Brian Burg.
- UserInterface/Views/TimelineRecordBar.js:
(WebInspector.TimelineRecordBar.prototype.set records):
When records are cleared, clear all classes.
- 3:31 PM Changeset in webkit [201230] by
-
- 7 edits2 adds in branches/safari-602.1.32-branch
Merge r201227. rdar://problem/24577706
- 3:28 PM Changeset in webkit [201229] by
-
- 2 edits in trunk/Source/WebCore
Allow named images on iOS
https://bugs.webkit.org/show_bug.cgi?id=157960
rdar://problem/26396532
Reviewed by Dean Jackson.
USE(NEW_THEME) is false on iOS so force named images to be drawn by checking PLATFORM(IOS) as well.
- platform/graphics/NamedImageGeneratedImage.cpp:
(WebCore::NamedImageGeneratedImage::draw):
- 3:10 PM Changeset in webkit [201228] by
-
- 4 edits3 adds in trunk
[Cocoa] REGRESSION(r184899): Ascent adjustments are applied to web fonts
https://bugs.webkit.org/show_bug.cgi?id=157954
<rdar://problem/24204349>
Reviewed by Dean Jackson.
Source/WebCore:
There are a few specific fonts which exist on Windows and Cocoa OSes, and we will adjust
the ascents of these fonts to better match their counterparts on Windows. However, in
r184899, we started applying this adjustment to web fonts too.
Test: fast/text/ascent-adjustment-webfont.html
- platform/graphics/cocoa/FontCocoa.mm:
(WebCore::Font::platformInit):
- svg/SVGToOTFFontConversion.cpp: We were reporting the length of font names wrong, so
it made the test pass without this patch even when it shouldn't have. Previously, we
were recording the number of characters in the font, not the number of bytes (each
character is 2 bytes).
LayoutTests:
- fast/text/ascent-adjustment-webfont-expected-mismatch.html: Added.
- fast/text/ascent-adjustment-webfont.html: Added.
- fast/text/resources/Helvetica-light.svg: Added.
- 3:05 PM Changeset in webkit [201227] by
-
- 7 edits2 adds in trunk
Drag cannot start if no drag data or custom data is available in the Pasteboard.
https://bugs.webkit.org/show_bug.cgi?id=157911
rdar://problem/24577706
Reviewed by Tim Horton.
Source/WebKit/mac:
We need to make sure there is always one item in common between source and target
of the drag and drop operation.
- WebView/WebHTMLView.mm:
(-[WebHTMLView dragImage:at:offset:event:pasteboard:source:slideBack:]):
Source/WebKit2:
We need to make sure there is always one item in common between source and target
of the drag and drop operation.
- UIProcess/Cocoa/WebViewImpl.mm:
(WebKit::WebViewImpl::dragImageForView):
LayoutTests:
- fast/events/draggable-div-customdata-expected.txt: Added.
- fast/events/draggable-div-customdata.html: Added.
- platform/ios-simulator/TestExpectations
- platform/mac-wk2/TestExpectations
- 2:47 PM Changeset in webkit [201226] by
-
- 3 edits1 add in trunk/Source/JavaScriptCore
Web Inspector: retained size for typed arrays does not count native backing store
https://bugs.webkit.org/show_bug.cgi?id=157945
<rdar://problem/26392238>
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-05-20
Reviewed by Geoffrey Garen.
- runtime/JSArrayBuffer.h:
- runtime/JSArrayBuffer.cpp:
(JSC::JSArrayBuffer::estimatedSize):
Include an estimatedSize implementation for JSArrayBuffer.
ArrayBuffer has a unique path, different from other data
stored in the Heap.
- tests/heapProfiler/typed-array-sizes.js: Added.
Test sizes of TypedArray with and without an ArrayBuffer.
When the TypedArray is a view wrapping an ArrayBuffer, the
ArrayBuffer has the size.
- 2:17 PM Changeset in webkit [201225] by
-
- 3 edits in trunk/Source/JavaScriptCore
reifyAllStaticProperties makes two copies of every string
https://bugs.webkit.org/show_bug.cgi?id=157953
Reviewed by Mark Lam.
Let's not do that.
- runtime/JSObject.cpp:
(JSC::JSObject::reifyAllStaticProperties): Pass our Identifier to
reifyStaticProperty so it doesn't have to make its own.
- runtime/Lookup.h:
(JSC::reifyStaticProperty): No need to null check because callers never
pass null anymore. No need to make an identifier because callers pass
us one.
(JSC::reifyStaticProperties): Honor new interface.
- 2:17 PM Changeset in webkit [201224] by
-
- 19 edits in trunk/Source
Remove unnecessary PageOverlay client function pageOverlayDestroyed
https://bugs.webkit.org/show_bug.cgi?id=157388
<rdar://problem/25471523>
Patch by John Wilander <wilander@apple.com> on 2016-05-20
Reviewed by Tim Horton.
Remove dead PageOverlay code. Almost all of these overrides were empty and
never called. In the case of WebPageOverlay it was never called but had a
function body, causing confusion. There was a fear of dangling pointers in
WebPageOverlay's static hash map between PageOverlays and WebPageOverlays.
Only WebPageOverlay's constructor creates its PageOverlay object and adds it
to the hash map. Its client object is kept in a unique pointer member which
is automatically deleted when the WebPageOverlay object itself is deleted.
This explains why PageOverlayClientImpl::pageOverlayDestroyed in
WKBundlePageOverlay can safely be removed. Finally, WebPageOverlay's
destructor clears the hash map entry for its PageOverlay object. Thus, there
is no need to call WebPageOverlay::pageOverlayDestroyed nor a need for
WebPageOverlay's destructor to call pageOverlayDestroyed on its client.
No new tests. I tried to come up with a WebKit API test for this but I
wasn't able to test presence/absence of WebPageOverlay's map entries since
the map is not exposed.
Source/WebCore:
- page/DebugPageOverlays.cpp:
(WebCore::RegionOverlay::pageOverlayDestroyed): Deleted.
- page/PageOverlay.h:
(WebCore::PageOverlay::Client::pageOverlayDestroyed): Deleted.
- page/ResourceUsageOverlay.h:
(WebCore::ResourceUsageOverlay::pageOverlayDestroyed): Deleted.
- page/mac/ServicesOverlayController.h:
- page/mac/ServicesOverlayController.mm:
(WebCore::ServicesOverlayController::pageOverlayDestroyed): Deleted.
- testing/MockPageOverlayClient.cpp:
- testing/MockPageOverlayClient.h:
(WebCore::MockPageOverlayClient::pageOverlayDestroyed): Deleted.
Source/WebKit2:
- WebProcess/InjectedBundle/API/c/WKBundlePageOverlay.cpp:
(WebKit::PageOverlayClientImpl::pageOverlayDestroyed): Deleted.
- WebProcess/Plugins/PDF/PDFPlugin.h:
- WebProcess/Plugins/PDF/PDFPlugin.mm:
(WebKit::PDFPlugin::HUD::pageOverlayDestroyed): Deleted.
- WebProcess/WebCoreSupport/WebInspectorClient.cpp:
- WebProcess/WebCoreSupport/WebInspectorClient.h:
(WebKit::WebInspectorClient::pageOverlayDestroyed): Deleted.
- WebProcess/WebPage/FindController.cpp:
- WebProcess/WebPage/FindController.h:
(WebKit::FindController::pageOverlayDestroyed): Deleted.
- WebProcess/WebPage/WebPageOverlay.cpp:
- WebProcess/WebPage/WebPageOverlay.h:
(WebKit::WebPageOverlay::pageOverlayDestroyed): Deleted.
- WebProcess/WebPage/ios/FindIndicatorOverlayClientIOS.h:
(WebKit::FindIndicatorOverlayClientIOS::pageOverlayDestroyed): Deleted.
- 1:43 PM Changeset in webkit [201223] by
-
- 6 edits2 adds in trunk
Fix null dereferencing in CSSAnimationTriggerScrollValue::equals
https://bugs.webkit.org/show_bug.cgi?id=157930
Patch by Alex Christensen <achristensen@webkit.org> on 2016-05-20
Reviewed by Dean Jackson.
Source/WebCore:
Test: fast/css/compare-animation-trigger.html
- css/CSSAnimationTriggerScrollValue.cpp:
(WebCore::CSSAnimationTriggerScrollValue::equals):
- css/CSSAnimationTriggerScrollValue.h:
(WebCore::CSSAnimationTriggerScrollValue::create):
(WebCore::CSSAnimationTriggerScrollValue::startValue):
(WebCore::CSSAnimationTriggerScrollValue::endValue):
(WebCore::CSSAnimationTriggerScrollValue::hasEndValue):
(WebCore::CSSAnimationTriggerScrollValue::operator==):
(WebCore::CSSAnimationTriggerScrollValue::CSSAnimationTriggerScrollValue):
- css/CSSToStyleMap.cpp:
(WebCore::CSSToStyleMap::mapAnimationTrigger):
- css/CSSValue.h:
(WebCore::CSSValue::operator==):
LayoutTests:
- fast/css/compare-animation-trigger-expected.txt: Added.
- fast/css/compare-animation-trigger.html: Added.
- 12:36 PM Changeset in webkit [201222] by
-
- 5 edits in trunk/Source/WebInspectorUI
Web Inspector: Split Console is auto opening all the time when using Inspect Element context menu
https://bugs.webkit.org/show_bug.cgi?id=157910
<rdar://problem/26374066>
Reviewed by Timothy Hatcher.
Currently, "synthetic" property is only used to decide whether adding a console message should
open the console or not. Replace it with "shouldRevealConsole".
- UserInterface/Controllers/DOMTreeManager.js:
(WebInspector.DOMTreeManager.prototype.inspectNodeObject.nodeAvailable):
(WebInspector.DOMTreeManager.prototype.inspectNodeObject):
- UserInterface/Controllers/JavaScriptLogViewController.js:
(WebInspector.JavaScriptLogViewController.prototype.appendImmediateExecutionWithResult.saveResultCallback):
(WebInspector.JavaScriptLogViewController.prototype.appendImmediateExecutionWithResult):
(WebInspector.JavaScriptLogViewController.prototype.consolePromptTextCommitted.printResult):
(WebInspector.JavaScriptLogViewController.prototype.consolePromptTextCommitted):
(WebInspector.JavaScriptLogViewController.prototype._appendConsoleMessageView):
- UserInterface/Models/ConsoleCommandResultMessage.js:
(WebInspector.ConsoleCommandResultMessage):
(WebInspector.ConsoleCommandResultMessage.prototype.get shouldRevealConsole):
(WebInspector.ConsoleCommandResultMessage.prototype.get synthetic): Deleted.
- UserInterface/Views/HeapSnapshotInstanceDataGridNode.js:
(WebInspector.HeapSnapshotInstanceDataGridNode.logHeapSnapshotNode.node.shortestGCRootPath.):
(WebInspector.HeapSnapshotInstanceDataGridNode.logHeapSnapshotNode):
- 12:13 PM Changeset in webkit [201221] by
-
- 2 edits in trunk/Source/JavaScriptCore
JSBench regression: CodeBlock linking always copies the symbol table
https://bugs.webkit.org/show_bug.cgi?id=157951
Reviewed by Saam Barati.
We always put a SymbolTable into the constant pool, even in simple
functions in which it won't be used -- i.e., there's on eval and there
are no captured variables and so on.
This is costly because linking must copy any provided symbol tables.
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::BytecodeGenerator):
(JSC::BytecodeGenerator::emitProfileType): Only add the symbol table
as a constant if we will use it at runtime.
- 12:07 PM Changeset in webkit [201220] by
-
- 2 edits in tags/Safari-602.1.33.1/Source/WebCore
Merged r201212. rdar://problem/26385907
- 12:06 PM Changeset in webkit [201219] by
-
- 5 edits in tags/Safari-602.1.33.1/Source
Versioning.
- 11:48 AM Changeset in webkit [201218] by
-
- 3 edits2 adds in trunk
Scrolling broken in iTunes connect pages
https://bugs.webkit.org/show_bug.cgi?id=157678
Reviewed by Zalan Bujtas.
Source/WebCore:
Added fast/flexbox/nested-columns-min-intrinsic-disabled.html
Turn off minimum intrinsic size adjustment for flexboxes. This violates the spec,
but until we can produce good results that is what we need to do. Blink has also
turned off nested columns intrinsic sizing as well, so we match them with this
change.
- rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::adjustChildSizeForMinAndMax):
LayoutTests:
- fast/flexbox/nested-column-intrinsic-min-disabled-expected.html: Added.
- fast/flexbox/nested-column-intrinsic-min-disabled.html: Added.
- 11:44 AM Changeset in webkit [201217] by
-
- 1 copy in tags/Safari-602.1.33.1
New tag.
- 11:34 AM Changeset in webkit [201216] by
-
- 60 edits1 move19 deletes in trunk/LayoutTests
AX: Layout tests related to text alternative computation need to be done differently
https://bugs.webkit.org/show_bug.cgi?id=157187
Create several utility methods to facilitate retrieval of platform-independent
attribute values from platform-specific attributes:
- platformValueForW3CName() and platformValueForW3CDescription() to retrieve a specific piece of text alternative information, stripping off the platform attribute name by default. These methods should make it possible to share tests and expectations files because the text alternative calculation defined by the W3C accessibility specifications should be the same for all platforms. (The differences are the result of the unique platform mappings.)
- platformTextAlternatives() to dump out all the text alternative attributes and values, preserving the platform-specific attribute name. This, along with the use of the platformValue* methods with attribute name enabled, should make it possible to have shared tests with platform-specific expectations without the need to check the platform in the test itself.
- platformRoleForComboBox() and platformRoleForStaticText() to eliminate the need for platform-specific expectations files simply because such an element happens to be included in the test file and verifying that element's role is desired.
Begin using these methods in the tests related to text alternative computation
which had platform-specific checks, update the expectations files when needed,
and remove now-obsolete platform-specific expectations files.
Reviewed by Chris Fleizach.
- accessibility/alt-tag-on-image-with-nonimage-role-expected.txt: Updated.
- accessibility/alt-tag-on-image-with-nonimage-role.html: Updated.
- accessibility/aria-help-expected.txt: Added.
- accessibility/aria-help.html: Updated.
- accessibility/aria-label-expected.txt: Updated.
- accessibility/aria-label.html: Updated.
- accessibility/aria-labeled-with-hidden-node-expected.txt: Updated.
- accessibility/aria-labeled-with-hidden-node.html: Updated.
- accessibility/aria-labelledby-on-input-expected.txt: Updated.
- accessibility/aria-labelledby-on-input.html: Updated.
- accessibility/aria-labelledby-overrides-aria-labeledby-expected.txt: Updated.
- accessibility/aria-labelledby-overrides-aria-labeledby.html: Updated.
- accessibility/aria-labelledby-overrides-label-expected.txt: Updated.
- accessibility/aria-labelledby-overrides-label.html: Updated.
- accessibility/aria-labelledby-stay-within-expected.txt: Updated.
- accessibility/aria-labelledby-stay-within.html: Updated.
- accessibility/aria-labelledby-with-descendants-expected.txt: Updated.
- accessibility/aria-labelledby-with-descendants.html: Updated.
- accessibility/aria-namefrom-author-expected.txt: Updated.
- accessibility/aria-namefrom-author.html: Updated.
- accessibility/aria-text-role-expected.txt: Updated.
- accessibility/aria-text-role.html: Updated.
- accessibility/canvas-description-and-role-expected.txt: Updated.
- accessibility/canvas-description-and-role.html: Updated.
- accessibility/canvas-fallback-content.html: Updated.
- accessibility/empty-image-with-title-expected.txt: Updated.
- accessibility/empty-image-with-title.html: Updated.
- accessibility/fieldset-element-expected.txt: Updated.
- accessibility/fieldset-element.html: Updated.
- accessibility/focusable-div-expected.txt: Updated.
- accessibility/focusable-div.html: Updated.
- accessibility/help-text.html: Updated.
- accessibility/img-alt-tag-only-whitespace-expected.txt: Updated.
- accessibility/img-alt-tag-only-whitespace.html: Updated.
- accessibility/img-aria-button-alt-tag-expected.txt: Updated.
- accessibility/img-aria-button-alt-tag.html: Updated.
- accessibility/img-fallsback-to-title.html: Updated.
- accessibility/input-image-alt-expected.txt: Updated.
- accessibility/input-image-alt.html: Updated.
- accessibility/loading-iframe-sends-notification.html: Updated.
- accessibility/self-referencing-aria-labelledby-expected.txt: Updated.
- accessibility/self-referencing-aria-labelledby.html: Updated.
- accessibility/svg-bounds.html: Updated.
- accessibility/svg-group-element-with-title-expected.txt: Updated.
- accessibility/svg-group-element-with-title.html: Updated.
- accessibility/svg-image-expected.txt: Updated.
- accessibility/svg-image.html: Updated.
- accessibility/svg-labelledby-expected.txt: Updated.
- accessibility/svg-labelledby.html: Updated.
- accessibility/svg-remote-element.html: Updated.
- accessibility/w3c-svg-description-calculation.html: Updated.
- accessibility/w3c-svg-name-calculation.html: Updated.
- platform/gtk/accessibility/alt-tag-on-image-with-nonimage-role-expected.txt: Removed.
- platform/gtk/accessibility/aria-labeled-with-hidden-node-expected.txt: Removed.
- platform/gtk/accessibility/aria-labelledby-on-input-expected.txt: Removed.
- platform/gtk/accessibility/aria-labelledby-overrides-aria-labeledby-expected.txt: Removed.
- platform/gtk/accessibility/aria-labelledby-overrides-label-expected.txt: Updated.
- platform/gtk/accessibility/aria-labelledby-with-descendants-expected.txt: Removed.
- platform/gtk/accessibility/aria-namefrom-author-expected.txt: Removed.
- platform/gtk/accessibility/aria-text-role-expected.txt: Removed.
- platform/gtk/accessibility/canvas-description-and-role-expected.txt: Updated.
- platform/gtk/accessibility/empty-image-with-title-expected.txt: Updated.
- platform/gtk/accessibility/fieldset-element-expected.txt: Removed.
- platform/gtk/accessibility/focusable-div-expected.txt: Removed.
- platform/gtk/accessibility/img-alt-tag-only-whitespace-expected.txt: Removed.
- platform/gtk/accessibility/img-aria-button-alt-tag-expected.txt: Removed.
- platform/gtk/accessibility/img-fallsback-to-title-expected.txt: Updated.
- platform/gtk/accessibility/input-image-alt-expected.txt: Removed.
- platform/gtk/accessibility/self-referencing-aria-labelledby-expected.txt: Removed.
- platform/gtk/accessibility/svg-group-element-with-title-expected.txt: Removed.
- platform/gtk/accessibility/svg-image-expected.txt: Removed.
- platform/gtk/accessibility/svg-labelledby-expected.txt: Removed.
- platform/mac/accessibility/aria-help-expected.txt: Removed.
- platform/mac/accessibility/aria-labelledby-overrides-label-expected.txt: Removed.
- platform/mac/accessibility/canvas-description-and-role-expected.txt: Updated.
- platform/mac/accessibility/fieldset-element-expected.txt: Removed.
- platform/mac/accessibility/img-fallsback-to-title-expected.txt: Updated.
- platform/win/accessibility/canvas-description-and-role-expected.txt: Updated.
- resources/accessibility-helper.js:
(platformValueForW3CName): Added.
(platformValueForW3CDescription): Added.
(platformTextAlternatives): Added.
(platformRoleForComboBox): Added.
(platformRoleForStaticText): Added.
- 10:09 AM Changeset in webkit [201215] by
-
- 2 edits in trunk/Tools
Use clearer names for JSON output of javascriptcore test results
https://bugs.webkit.org/show_bug.cgi?id=157921
Patch by Srinivasan Vijayaraghavan <svijayaraghavan@apple.com> on 2016-05-20
Reviewed by Alexey Proskuryakov.
"failures" and "apiTestResult" were somewhat ambiguous names.
- Scripts/run-javascriptcore-tests:
(runJSCStressTests): "failures" -> "stressFailures", "apiTestResult" -> "allApiTestsPassed".
- 10:02 AM Changeset in webkit [201214] by
-
- 2 edits in trunk/Tools
Unreviewed, fix API test introduced in r201213.
- TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
(TestWebKitAPI::TEST):
- 7:42 AM Changeset in webkit [201213] by
-
- 7 edits in trunk
Implement operator== for WeakPtr
https://bugs.webkit.org/show_bug.cgi?id=157883
Patch by Rawinder Singh <rawinder.singh-webkit@cisra.canon.com.au> on 2016-05-20
Reviewed by Chris Dumez.
Implement operator== and operator!= for WeakPtr and update code to use the operators.
Source/WebCore:
- page/EventHandler.cpp:
(WebCore::EventHandler::handleMousePressEvent):
(WebCore::EventHandler::updateLastScrollbarUnderMouse):
- page/mac/EventHandlerMac.mm:
(WebCore::EventHandler::platformCompleteWheelEvent):
Source/WTF:
- wtf/WeakPtr.h:
(WTF::operator==):
(WTF::operator!=):
Tools:
- TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
(TestWebKitAPI::TEST):
May 19, 2016:
- 11:35 PM Changeset in webkit [201212] by
-
- 2 edits in trunk/Source/WebCore
REGRESSION (r200638): -[DOMHTMLVideoElement play] disappeared from ObjC bindings
https://bugs.webkit.org/show_bug.cgi?id=157940
<rdar://problem/26385907>
Reviewed by Dan Bernstein.
- html/HTMLMediaElement.idl:
Drop the return value of play from the ObjC bindings, because the bindings
generator doesn't seem to know what to do with a Promise.
- 11:32 PM Changeset in webkit [201211] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Can't resume Debugger after breaking on exception in Promise
https://bugs.webkit.org/show_bug.cgi?id=157240
<rdar://problem/26030890>
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-05-19
Reviewed by Timothy Hatcher.
If we pause but have no source code to show we paused in purely internal
code. In such cases we were attempting to resume without actually
telling the backend to resume, so the backend and frontend were out of
sync. The frontend thinking it is "paused" without an activeCallFrame
and the backend actually being paused.
This change more gracefully handles this situation. It actually resumes
both the frontend and the backend.
- UserInterface/Controllers/DebuggerManager.js:
(WebInspector.DebuggerManager.prototype.debuggerDidPause):
Resume the backend and the frontend.
(WebInspector.DebuggerManager.prototype._didResumeInternal):
Don't look at the active call frame, look at the paused state.
This may issue a Resumed event without actually triggering a
Paused event if this was the only pause, but that is harmless.
- 11:31 PM Changeset in webkit [201210] by
-
- 3 edits in trunk/Source/WebInspectorUI
Web Inspector: Main Resource with <scripts> not showing up in debugger sidebar after reload
https://bugs.webkit.org/show_bug.cgi?id=157939
<rdar://problem/26385691>
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-05-19
Reviewed by Timothy Hatcher.
The order of events on a reload are:
- MainResourceChanged, add main resource
- ScriptsCleared, remove all elements
This change makes it so ScriptsCleared add the main resource (and
potentially other resources). This also avoids the work in
MainResourceChanged on reloads / navigations that would be wasted if
ScriptsCleared were to just remove it. However, this is still needed
for initial load where ScriptsCleared does not happen.
- UserInterface/Views/DebuggerSidebarPanel.js:
(WebInspector.DebuggerSidebarPanel.prototype._mainResourceDidChange):
Only add the main resource tree here when we are first loading.
(WebInspector.DebuggerSidebarPanel.prototype._scriptsCleared):
Add the main resource tree after we remove all children in navigations.
- UserInterface/Views/NavigationSidebarPanel.js:
(WebInspector.NavigationSidebarPanel.prototype._contentTreeOutlineTreeSelectionDidChange):
This was not gracefully handling if there was no selected tree element.
- 9:13 PM Changeset in webkit [201209] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Visual Style connectors are not always centered properly
https://bugs.webkit.org/show_bug.cgi?id=157932
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-05-19
Reviewed by Timothy Hatcher.
- UserInterface/Views/VisualStylePropertyEditorLink.css:
(.visual-style-property-editor-link):
Remove the 1px margin on @2x that would cause jitter at different
sidebar widths. It is however needed on @1x.
(.visual-style-property-editor-link:not(.link-all)):
Make the height 20 so these both move closer to the center of the
<select> elements they are next to. They are not perfectly centered
as that would require a half pixel.
(.visual-style-property-editor-link.link-vertical):
Move the top line up a pixel so it is "up 0.5" from center and
the bottom one is already "down 0.5" from the center.
- 7:44 PM Changeset in webkit [201208] by
-
- 21 edits in trunk/Source/JavaScriptCore
[JSC] Improve int->float conversion in FTL
https://bugs.webkit.org/show_bug.cgi?id=157936
Patch by Benjamin Poulain <bpoulain@apple.com> on 2016-05-19
Reviewed by Filip Pizlo.
The integer -> floating point lowering was very barebone.
For example, converting a constant integer to double
was doing:
mov #const, %eax
xor %xmm0, %xmm0
cvtsi2sd %eax, %xmm0
Conversion from integer to float was also missing.
We were always converting to double then rounding the double
to float.
This patch adds the basics:
-Constant folding.
-Integer to Float opcode.
-Reducing int->double to int->float when used by DoubleToFloat.
- assembler/MacroAssemblerX86Common.h:
(JSC::MacroAssemblerX86Common::convertInt32ToFloat):
- assembler/MacroAssemblerX86_64.h:
(JSC::MacroAssemblerX86_64::convertInt64ToDouble):
(JSC::MacroAssemblerX86_64::convertInt64ToFloat):
- assembler/X86Assembler.h:
(JSC::X86Assembler::cvtsi2ss_rr):
(JSC::X86Assembler::cvtsi2ssq_rr):
(JSC::X86Assembler::cvtsi2sdq_mr):
(JSC::X86Assembler::cvtsi2ssq_mr):
(JSC::X86Assembler::cvtsi2ss_mr):
- assembler/MacroAssemblerARM64.h:
- b3/B3Const32Value.cpp:
(JSC::B3::Const32Value::iToDConstant):
(JSC::B3::Const32Value::iToFConstant):
- b3/B3Const32Value.h:
- b3/B3Const64Value.cpp:
(JSC::B3::Const64Value::iToDConstant):
(JSC::B3::Const64Value::iToFConstant):
- b3/B3Const64Value.h:
- b3/B3LowerToAir.cpp:
(JSC::B3::Air::LowerToAir::lower):
- b3/B3Opcode.cpp:
(WTF::printInternal):
- b3/B3Opcode.h:
- b3/B3ReduceDoubleToFloat.cpp:
- b3/B3ReduceStrength.cpp:
- b3/B3Validate.cpp:
- b3/B3Value.cpp:
(JSC::B3::Value::iToDConstant):
(JSC::B3::Value::iToFConstant):
(JSC::B3::Value::isRounded):
(JSC::B3::Value::effects):
(JSC::B3::Value::key):
(JSC::B3::Value::typeFor):
- b3/B3Value.h:
- b3/B3ValueKey.cpp:
(JSC::B3::ValueKey::materialize):
- b3/air/AirFixPartialRegisterStalls.cpp:
- b3/air/AirOpcode.opcodes:
- b3/testb3.cpp:
(JSC::B3::int64Operands):
(JSC::B3::testIToD64Arg):
(JSC::B3::testIToF64Arg):
(JSC::B3::testIToD32Arg):
(JSC::B3::testIToF32Arg):
(JSC::B3::testIToD64Mem):
(JSC::B3::testIToF64Mem):
(JSC::B3::testIToD32Mem):
(JSC::B3::testIToF32Mem):
(JSC::B3::testIToD64Imm):
(JSC::B3::testIToF64Imm):
(JSC::B3::testIToD32Imm):
(JSC::B3::testIToF32Imm):
(JSC::B3::testIToDReducedToIToF64Arg):
(JSC::B3::testIToDReducedToIToF32Arg):
(JSC::B3::run):
- 7:37 PM Changeset in webkit [201207] by
-
- 4 edits in trunk/Source/JavaScriptCore
[JSC] FTL can crash on stack overflow
https://bugs.webkit.org/show_bug.cgi?id=157881
rdar://problem/24665964
Patch by Benjamin Poulain <bpoulain@apple.com> on 2016-05-19
Reviewed by Michael Saboff.
The VM's m_largestFTLStackSize was never set anywhere (updateFTLLargestStackSize()
was never called). We forgot to change that when implementing B3.
Even when it is set, we still have a problem on OSR Exit.
If the last frame is a FTL frame and it OSR Exits, the space required for
that frame becomes significantly larger. What happens is we crash in the OSR Exit
instead of the FTL frame (this is what happens in rdar://problem/24665964).
This patch changes the stack boundary checks in FTL to be the same as DFG:
we verify that we have enough space for the current optimized function but
also for the baseline version (including inlining) in case of exit.
- ftl/FTLLowerDFGToB3.cpp:
(JSC::FTL::DFG::LowerDFGToB3::lower):
(JSC::FTL::DFG::LowerDFGToB3::didOverflowStack): Deleted.
- runtime/VM.cpp:
(JSC::VM::VM): Deleted.
(JSC::VM::updateStackLimit): Deleted.
(JSC::VM::updateFTLLargestStackSize): Deleted.
- runtime/VM.h:
(JSC::VM::addressOfFTLStackLimit): Deleted.
- 7:25 PM Changeset in webkit [201206] by
-
- 2 edits in trunk/Tools
Add JSON results to 32-bit and CLoop JSC tests
https://bugs.webkit.org/show_bug.cgi?id=157929
Patch by Srinivasan Vijayaraghavan <svijayaraghavan@apple.com> on 2016-05-19
Reviewed by Alexey Proskuryakov.
- BuildSlaveSupport/build.webkit.org-config/master.cfg:
(RunLLINTCLoopTests): Change command-line parameters to run-javascriptcore-tests in order to get JSON output.
(Run32bitJSCTests): Change command-line parameters to run-javascriptcore-tests in order to get JSON output.
- 6:50 PM Changeset in webkit [201205] by
-
- 58 edits in trunk/Source
Improve compile-time assertions in is<>() / downcast<>()
https://bugs.webkit.org/show_bug.cgi?id=157817
Reviewed by Darin Adler.
Source/WebCore:
Add missing includes and drop unnecessary is<WebVTTElement>() check
in SharingResolver::canShareStyleWithElement() that was identified
by the new assertions. WebVTTElement inherits Element but the check
was done on a StyledElement.
- accessibility/AccessibilityRenderObject.cpp:
- accessibility/AccessibilitySVGElement.cpp:
- css/CSSDefaultStyleSheets.cpp:
- css/CSSParser.cpp:
- css/CSSStyleSheet.cpp:
- css/StyleResolver.cpp:
- cssjit/SelectorCompiler.cpp:
- dom/Document.cpp:
- dom/Element.cpp:
- dom/Node.cpp:
- dom/Position.cpp:
- editing/ApplyStyleCommand.cpp:
- editing/FrameSelection.cpp:
- editing/ReplaceSelectionCommand.cpp:
- editing/TextIterator.cpp:
- editing/VisiblePosition.cpp:
- editing/VisibleUnits.cpp:
- editing/cocoa/HTMLConverter.mm:
- editing/htmlediting.cpp:
- editing/markup.cpp:
- html/GenericCachedHTMLCollection.cpp:
- html/HTMLBodyElement.cpp:
- html/HTMLFormElement.cpp:
- html/HTMLLIElement.cpp:
- html/HTMLNameCollection.cpp:
- html/HTMLSelectElement.cpp:
- html/parser/HTMLTreeBuilder.cpp:
- inspector/InspectorDOMAgent.cpp:
- inspector/InspectorStyleSheet.cpp:
- loader/SubframeLoader.cpp:
- loader/archive/cf/LegacyWebArchive.cpp:
- mathml/MathMLElement.cpp:
- page/EventHandler.cpp:
- page/FrameView.cpp:
- page/PageSerializer.cpp:
- page/SpatialNavigation.cpp:
- page/mac/EventHandlerMac.mm:
- rendering/HitTestResult.cpp:
- rendering/RenderBlockFlow.cpp:
- rendering/RenderBox.cpp:
- rendering/RenderBoxModelObject.cpp:
- rendering/RenderElement.cpp:
- rendering/RenderFieldset.cpp:
- rendering/RenderLayer.cpp:
- rendering/svg/RenderSVGTransformableContainer.cpp:
- style/StyleSharingResolver.cpp:
(WebCore::Style::SharingResolver::canShareStyleWithElement):
- svg/SVGAnimationElement.cpp:
- svg/SVGFELightElement.cpp:
- svg/SVGTextPositioningElement.cpp:
Source/WebKit2:
Add missing includes.
- WebProcess/WebPage/WebFrame.cpp:
- WebProcess/WebPage/WebPage.cpp:
Source/WTF:
- wtf/Ref.h:
(WTF::is):
Add is<>() overloads taking a Ref<>() so that is<>() keeps working when
passing a Ref<>(), despite the new static assertions on the input type.
Some call sites were already leveraging this as it was working by
implicitly converting the Ref<T> into a T&.
- wtf/TypeCasts.h:
(WTF::is):
(WTF::downcast):
Make static assertions stricter in is<>() / downcast<>() to catch more
cases where those are either unnecessary or incorrect.
- 6:22 PM Changeset in webkit [201204] by
-
- 2 edits in trunk/LayoutTests
Test gardening after r201203
Unreviewed.
- platform/ios-simulator/TestExpectations:
- 5:59 PM Changeset in webkit [201203] by
-
- 2 edits3 adds in trunk/LayoutTests
Add John Daggett's font variant synthesis test
https://bugs.webkit.org/show_bug.cgi?id=157935
<rdar://problem/24133521>
Reviewed by Dean Jackson.
Make sure that we continue to synthesize correctly.
- css3/font-variant-synthesis-jdaggett-expected.html: Added.
- css3/font-variant-synthesis-jdaggett.html: Added.
- css3/resources/gsubtest-lookup3.otf: Added.
- platform/mac/TestExpectations:
- 5:20 PM Changeset in webkit [201202] by
-
- 2 edits in trunk/Source/WebKit2
Mail crashes under TiledCoreAnimationDrawingAreaProxy::createFenceForGeometryUpdate() when the Web process crashes
https://bugs.webkit.org/show_bug.cgi?id=157927
<rdar://problem/24793374>
Reviewed by Dean Jackson.
- UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.mm:
(WebKit::TiledCoreAnimationDrawingAreaProxy::createFence):
With just the right combination of layout mechanisms and Web Content process
crash timing, it is possible to get a frame change underneath WebPageProxy::processDidCrash,
before the DrawingArea has been nulled out but after the Connection has.
This can lead to a null dereference. I had a lot of trouble writing a API
test for this, though I'm certain it's possible.
- 4:54 PM Changeset in webkit [201201] by
-
- 6 edits in trunk/Source/WebCore
Cleanup RenderObject::container()
https://bugs.webkit.org/show_bug.cgi?id=157914
Reviewed by David Hyatt.
- Now we have a dedicated method for the optional, repaintContainerSkipped branch. The container finding
logic is moved to a static inline function so the compiler can optimize out the repaintContainerSkipped branches, when
container() is called instead of container(repaintContainer, isRepaintContainerSkipped).
- Use helper functions like canContainAbsolutelyPositionedObjects()
- Remove stale comments.
No behaviour change.
- rendering/RenderBox.cpp:
(WebCore::RenderBox::mapLocalToContainer):
(WebCore::RenderBox::pushMappingToContainer):
(WebCore::RenderBox::computeRectForRepaint):
- rendering/RenderInline.cpp:
(WebCore::RenderInline::computeRectForRepaint):
(WebCore::RenderInline::mapLocalToContainer):
(WebCore::RenderInline::pushMappingToContainer):
- rendering/RenderObject.cpp:
(WebCore::containerForElement):
(WebCore::RenderObject::container):
- rendering/RenderObject.h:
- rendering/RenderText.h:
- 4:48 PM Changeset in webkit [201200] by
-
- 19 edits2 adds in branches/safari-602.1.32-branch
Merge r201187. rdar://problem/25314776
- 4:32 PM Changeset in webkit [201199] by
-
- 6 edits in trunk/Source
No candidate punctuation when typing punctuation in WK2 text field.
https://bugs.webkit.org/show_bug.cgi?id=157773
rdar://problem/23084603
Reviewed by Sam Weinig.
Source/WebCore:
We need to keep the inputManagerHint as part of the platform key event
information. Adding a new initializer for the task and a property to retrieve
the stored hint.
- platform/ios/WebEvent.h:
- platform/ios/WebEvent.mm:
(-[WebEvent initWithKeyEventType:timeStamp:characters:charactersIgnoringModifiers:modifiers:isRepeating:withFlags:keyCode:isTabKey:characterSet:]):
(-[WebEvent initWithKeyEventType:timeStamp:characters:charactersIgnoringModifiers:modifiers:isRepeating:withFlags:withInputManagerHint:keyCode:isTabKey:]):
(-[WebEvent dealloc]):
(-[WebEvent inputManagerHint]):
Source/WebKit2:
We need to adopt the new addInputString:withFlags:withInputManagerHint function
for this to work propertly.
- Platform/spi/ios/UIKitSPI.h:
- UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView _interpretKeyEvent:isCharEvent:]):
- 3:58 PM Changeset in webkit [201198] by
-
- 11 edits2 adds in branches/safari-602.1.32-branch
Merge r201189. rdar://problem/24577706
- 3:58 PM Changeset in webkit [201197] by
-
- 3 edits in branches/safari-602.1.32-branch/Source/WebInspectorUI
Merge r201191. rdar://problem/26377366
- 3:58 PM Changeset in webkit [201196] by
-
- 12 edits2 adds in branches/safari-602.1.32-branch
Merge r201183. rdar://problem/26375866
- 3:58 PM Changeset in webkit [201195] by
-
- 8 edits3 adds in trunk
Finishing off: Modern IDB: Website data store management.
https://bugs.webkit.org/show_bug.cgi?id=157626
Reviewed by Alex Christensen.
Source/WebCore:
Test: storage/indexeddb/modern/new-database-after-user-delete.html
This patch does two primary things:
1 - Implements the actual "delete files on disk" code for unopened databases,
taken from existing WK2 code.
2 - When a UniqueIBDDatabase is told to close immediately for user delete, it also
queues up a "delete backing store unconditionally" operation in the database task queue.
That way, all of the open databases are deleted before the primary "delete all files"
pass, and they are also deleted before any future openDB requests are handled that might
recreate the files.
- Modules/indexeddb/server/IDBServer.cpp:
(WebCore::IDBServer::IDBServer::getOrCreateUniqueIDBDatabase):
(WebCore::IDBServer::IDBServer::deleteDatabase):
(WebCore::IDBServer::IDBServer::closeUniqueIDBDatabase):
(WebCore::IDBServer::IDBServer::openDBRequestCancelled):
(WebCore::IDBServer::removeAllDatabasesForOriginPath):
(WebCore::IDBServer::IDBServer::performCloseAndDeleteDatabasesModifiedSince):
(WebCore::IDBServer::IDBServer::performCloseAndDeleteDatabasesForOrigins):
- Modules/indexeddb/server/UniqueIDBDatabase.cpp:
(WebCore::IDBServer::UniqueIDBDatabase::performUnconditionalDeleteBackingStore):
(WebCore::IDBServer::UniqueIDBDatabase::doneWithHardClose):
(WebCore::IDBServer::UniqueIDBDatabase::immediateCloseForUserDelete):
- Modules/indexeddb/server/UniqueIDBDatabase.h:
Source/WebKit2:
- DatabaseProcess/DatabaseProcess.cpp:
(WebKit::DatabaseProcess::deleteWebsiteDataForOrigins):
(WebKit::removeAllDatabasesForOriginPath): Deleted.
(WebKit::DatabaseProcess::deleteIndexedDatabaseEntriesForOrigins): Deleted.
(WebKit::DatabaseProcess::deleteIndexedDatabaseEntriesModifiedSince): Deleted.
- DatabaseProcess/DatabaseProcess.h:
LayoutTests:
- storage/indexeddb/modern/new-database-after-user-delete-expected.txt: Added.
- storage/indexeddb/modern/new-database-after-user-delete.html: Added.
- storage/indexeddb/modern/resources/new-database-after-user-delete.js: Added.
- 3:55 PM Changeset in webkit [201194] by
-
- 3 edits in trunk/Source/WebKit2
[OS X][WK2] Expand sandbox for new mach endpoints
https://bugs.webkit.org/show_bug.cgi?id=157919
<rdar://problem/25238336>
Reviewed by Alexey Proskuryakov.
Grant the WebContent and Networking processes the mach lookup capability for
various Security-related mach endpoints..
- Resources/SandboxProfiles/ios/com.apple.WebKit.Networking.sb:
- Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:
- 3:41 PM Changeset in webkit [201193] by
-
- 4 edits in branches/safari-602.1.32-branch/Source/JavaScriptCore
Merge r201180. rdar://problem/26129156
- 3:27 PM Changeset in webkit [201192] by
-
- 2 edits in trunk/Source/WebInspectorUI
REGRESSION (r189385): Web Inspector: CSS properties modified via JS don't update in the Styles sidebar
https://bugs.webkit.org/show_bug.cgi?id=157918
Reviewed by Timothy Hatcher.
- UserInterface/Controllers/DOMTreeManager.js:
(WebInspector.DOMTreeManager):
(WebInspector.DOMTreeManager.prototype._inlineStyleInvalidated):
(WebInspector.DOMTreeManager.prototype._loadNodeAttributes):
Set the initial value of _loadNodeAttributesTimeout to be 0,
as setTimeout always returns a positive integer.
- 3:25 PM Changeset in webkit [201191] by
-
- 3 edits in trunk/Source/WebInspectorUI
Web Inspector: Heap Snapshots taken before timeline view has a zero time do not get shown
https://bugs.webkit.org/show_bug.cgi?id=157923
<rdar://problem/26377366>
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-05-19
Reviewed by Timothy Hatcher.
- UserInterface/Views/HeapAllocationsTimelineDataGridNode.js:
(WebInspector.HeapAllocationsTimelineDataGridNode):
(WebInspector.HeapAllocationsTimelineDataGridNode.prototype.createCellContent):
(WebInspector.HeapAllocationsTimelineDataGridNode.prototype.updateTimestamp):
Show emDash for the timestamp if we don't yet have a zero time.
Update when we get a zero time.
- UserInterface/Views/HeapAllocationsTimelineView.js:
(WebInspector.HeapAllocationsTimelineView):
(WebInspector.HeapAllocationsTimelineView.prototype.layout):
(WebInspector.HeapAllocationsTimelineView.prototype.reset):
Save a list of nodes pre-zero time and update them when we get a zero time.
- 3:20 PM Changeset in webkit [201190] by
-
- 2 edits in trunk/Source/WebKit2
Web Inspector: CRASH when closing a page while element selection mode is enabled via Develop menu
https://bugs.webkit.org/show_bug.cgi?id=157925
<rdar://problem/26259618>
Reviewed by Joseph Pecoraro.
- WebProcess/WebCoreSupport/WebInspectorClient.cpp:
(WebKit::WebInspectorClient::elementSelectionChanged):
Null-check m_page->inspector() since it will return nullptr if the page
is closed but not yet destructed. This is triggered by teardown code
in InspectorDOMAgent::willDestroyFrontendAndBackend.
- 3:19 PM Changeset in webkit [201189] by
-
- 11 edits2 adds in trunk
Drag cannot start if no drag data is available in the Pasteboard.
https://bugs.webkit.org/show_bug.cgi?id=157911
rdar://problem/24577706
Reviewed by Tim Horton.
Source/WebKit/mac:
- WebView/WebHTMLView.mm:
(+[WebHTMLView _dummyPasteboardType]):
(-[WebHTMLView dragImage:at:offset:event:pasteboard:source:slideBack:]):
- WebView/WebHTMLViewPrivate.h:
- WebView/WebView.mm:
(-[WebView _registerDraggedTypes]):
Source/WebKit2:
Setting dummy data to allow drag to start.
- Shared/mac/PasteboardTypes.h:
- Shared/mac/PasteboardTypes.mm:
- UIProcess/Cocoa/WebViewImpl.mm:
(WebKit::WebViewImpl::registerDraggedTypes):
(WebKit::WebViewImpl::dragImageForView):
LayoutTests:
- fast/events/draggable-div-nodata-expected.txt: Added.
- fast/events/draggable-div-nodata.html: Added.
- platform/ios-simulator/TestExpectations
- platform/mac-wk2/TestExpectations
- 3:11 PM Changeset in webkit [201188] by
-
- 2 edits in trunk/Source/WebCore
REGRESSION(201098) GuardMalloc / ASan crashes in WebCore::IDBServer::UniqueIDBDatabase::executeNextDatabaseTaskReply
https://bugs.webkit.org/show_bug.cgi?id=157917
Reviewed by Alex Christensen.
No new tests (Covered by all existing tests in Gmalloc/ASAN configs).
- Modules/indexeddb/server/UniqueIDBDatabase.cpp:
(WebCore::IDBServer::UniqueIDBDatabase::~UniqueIDBDatabase):
(WebCore::IDBServer::UniqueIDBDatabase::executeNextDatabaseTaskReply): Protect this from deletion before executing the task.
- 2:59 PM Changeset in webkit [201187] by
-
- 19 edits2 adds in trunk
[IOS] Add setting to allow playback to continue inline after exiting fullscreen.
https://bugs.webkit.org/show_bug.cgi?id=157912
Reviewed by Eric Carlson.
Source/WebCore:
Test: media/media-fullscreen-return-to-inline.html
Allow playback to continue when exiting fullscreen via settings.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::exitFullscreen):
- page/Settings.in:
Source/WebKit/mac:
Add a preference to control whether media should be allowed to continue playing inline when
exiting fullscreen.
- WebView/WebPreferenceKeysPrivate.h:
- WebView/WebPreferences.mm:
(+[WebPreferences initialize]):
(-[WebPreferences allowsInlineMediaPlaybackAfterFullscreen]):
(-[WebPreferences setAllowsInlineMediaPlaybackAfterFullscreen:]):
- WebView/WebPreferencesPrivate.h:
- WebView/WebView.mm:
(-[WebView _preferencesChanged:]):
Source/WebKit2:
Add a preference and configuration property to control whether media should be allowed to continue
playing inline when exiting fullscreen.
- Shared/WebPreferencesDefinitions.h:
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _initializeWithConfiguration:]):
- UIProcess/API/Cocoa/WKWebViewConfiguration.mm:
(-[WKWebViewConfiguration init]):
(-[WKWebViewConfiguration encodeWithCoder:]):
(-[WKWebViewConfiguration initWithCoder:]):
(-[WKWebViewConfiguration copyWithZone:]):
(-[WKWebViewConfiguration _allowsInlineMediaPlaybackAfterFullscreen]):
(-[WKWebViewConfiguration _setAllowsInlineMediaPlaybackAfterFullscreen:]):
- UIProcess/API/Cocoa/WKWebViewConfigurationPrivate.h:
- UIProcess/mac/WKFullScreenWindowController.mm:
(disableScreenUpdates):
(enableScreenUpdates):
(-[WKFullScreenWindowController enterFullScreen:]):
(-[WKFullScreenWindowController finishedEnterFullScreenAnimation:]):
(-[WKFullScreenWindowController exitFullScreen]):
(-[WKFullScreenWindowController beganExitFullScreenWithInitialFrame:finalFrame:]):
(-[WKFullScreenWindowController finishedExitFullScreenAnimation:]):
(-[WKFullScreenWindowController completeFinishExitFullScreenAnimationAfterRepaint]):
(-[WKFullScreenWindowController _startEnterFullScreenAnimationWithDuration:]):
(-[WKFullScreenWindowController _startExitFullScreenAnimationWithDuration:]):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences):
LayoutTests:
- media/media-fullscreen-return-to-inline-expected.txt: Added.
- media/media-fullscreen-return-to-inline.html: Added.
- media/video-test.js:
(runWithKeyDown.eventName.window.testRunner.eventSender.keyDown.string_appeared_here.string_appeared_here.thunk):
(runWithKeyDown):
- 2:51 PM Changeset in webkit [201186] by
-
- 2 edits in trunk/Source/WebCore
Fix childrenInline() check in markAllDescendantsWithFloatsForLayout()
https://bugs.webkit.org/show_bug.cgi?id=157866
Reviewed by Zalan Bujtas.
- rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::markAllDescendantsWithFloatsForLayout):
- 2:46 PM Changeset in webkit [201185] by
-
- 2 edits in trunk/Source/WTF
Unreviewed, fix all of the builds. I failed a second time.
- wtf/BackwardsGraph.h:
(WTF::BackwardsGraph::rootName):
- 2:44 PM Changeset in webkit [201184] by
-
- 2 edits in trunk/Source/WTF
Unreviewed, fix all of the builds. I had made an additional change that I did not mean to
commit. This fixes it.
- wtf/BackwardsGraph.h:
(WTF::BackwardsGraph::rootName):
(WTF::BackwardsGraph::Set::dump):
(WTF::BackwardsGraph::dump):
- 2:30 PM Changeset in webkit [201183] by
-
- 12 edits2 adds in trunk
Web Inspector: HeapSnapshot Instances view should remove dead objects
https://bugs.webkit.org/show_bug.cgi?id=157920
<rdar://problem/26375866>
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-05-19
Reviewed by Timothy Hatcher.
Source/WebInspectorUI:
- UserInterface/Workers/HeapSnapshot/HeapSnapshotWorker.js:
(HeapSnapshotWorker):
(HeapSnapshotWorker.prototype.clearSnapshots):
(HeapSnapshotWorker.prototype.createSnapshot):
Preserve a list of snapshots for this page's session. When
new snapshots come in we can determine which nodes have died
and update previous snapshots. Emit a CollectionEvent
containing the nodes that were deleted and affected snapshots.
- UserInterface/Workers/HeapSnapshot/HeapSnapshot.js:
(HeapSnapshot):
Stash the largest node identifier.
Create a byte-per-node list to mark it as dead or alive.
All snapshots start with all live nodes.
(HeapSnapshot.prototype.updateDeadNodesAndGatherCollectionData):
(HeapSnapshot.prototype._markDeadNodes):
When we get a new snapshot we can mark dead nodes in previous
snapshots. Determine the nodeIdentifiers of dead nodes, and
mark them as dead if they existed in previous snapshots.
(HeapSnapshot.buildCategories):
(HeapSnapshot.prototype.updateCategories):
(HeapSnapshotDiff.prototype.updateCategories):
Include a "deadCount" in category data. And provide a method
to return an updated category list.
(HeapSnapshot.prototype.serializeNode):
Include a "dead" property on nodes when they are first fetched.
- UserInterface/Proxies/HeapSnapshotDiffProxy.js:
(WebInspector.HeapSnapshotDiffProxy.prototype.updateForCollectionEvent):
(WebInspector.HeapSnapshotDiffProxy.prototype.updateCategories):
- UserInterface/Proxies/HeapSnapshotNodeProxy.js:
(WebInspector.HeapSnapshotNodeProxy):
(WebInspector.HeapSnapshotNodeProxy.deserialize):
- UserInterface/Proxies/HeapSnapshotProxy.js:
(WebInspector.HeapSnapshotProxy.prototype.updateForCollectionEvent):
(WebInspector.HeapSnapshotProxy.prototype.updateCategories):
Update snapshot proxies from a collection event by updating properties
and dispatching an event from the model object.
- UserInterface/Proxies/HeapSnapshotWorkerProxy.js:
(WebInspector.HeapSnapshotWorkerProxy):
(WebInspector.HeapSnapshotWorkerProxy.prototype.clearSnapshots):
(WebInspector.HeapSnapshotWorkerProxy.prototype._mainResourceDidChange):
Clear the session snapshot list when the main resource changes.
However we can't yet clear the HeapSnapshot objects on the worker
because we may still have UI that interact with them.
- UserInterface/Views/HeapAllocationsTimelineView.js:
(WebInspector.HeapAllocationsTimelineView):
(WebInspector.HeapAllocationsTimelineView.prototype.closed):
Register and unregister for HeapSnapshot collection events.
(WebInspector.HeapAllocationsTimelineView.prototype._heapSnapshotCollectionEvent.updateHeapSnapshotForEvent):
(WebInspector.HeapAllocationsTimelineView.prototype._heapSnapshotCollectionEvent):
Update all the snapshots we know about when a collection event happens.
- UserInterface/Views/HeapSnapshotClassDataGridNode.js:
(WebInspector.HeapSnapshotClassDataGridNode.prototype.removeCollectedNodes):
(WebInspector.HeapSnapshotClassDataGridNode.prototype.updateCount):
(WebInspector.HeapSnapshotClassDataGridNode.prototype._populate):
(WebInspector.HeapSnapshotClassDataGridNode.prototype._fetchBatch):
- UserInterface/Views/HeapSnapshotContentView.js:
(WebInspector.HeapSnapshotContentView.prototype._heapSnapshotDataGridTreeDidPopulate):
(WebInspector.HeapSnapshotContentView):
- UserInterface/Views/HeapSnapshotDataGridTree.js:
(WebInspector.HeapSnapshotDataGridTree):
(WebInspector.HeapSnapshotDataGridTree.prototype.removeChild):
(WebInspector.HeapSnapshotDataGridTree.prototype.removeCollectedNodes):
(WebInspector.HeapSnapshotDataGridTree.prototype._heapSnapshotCollectedNodes):
(WebInspector.HeapSnapshotInstancesDataGridTree.prototype.populateTopLevel):
(WebInspector.HeapSnapshotInstancesDataGridTree.prototype.removeCollectedNodes):
(WebInspector.HeapSnapshotInstancesDataGridTree):
Update the Instances DataGridTree UI when a collection event happens.
Remove any top level InstanceDataGridNodes that may be showing for collected nodes.
Update the category counts on the ClassDataGridNodes.
Update FetchMoreDataGridNodes to have updated counts (and replace removed nodes).
LayoutTests:
- inspector/unit-tests/heap-snapshot-collection-event-expected.txt: Added.
- inspector/unit-tests/heap-snapshot-collection-event.html: Added.
- 2:25 PM Changeset in webkit [201182] by
-
- 28 edits14 adds in trunk
DFG::LICMPhase shouldn't hoist type checks unless it knows that the check will succeed at the loop pre-header
https://bugs.webkit.org/show_bug.cgi?id=144527
Reviewed by Saam Barati.
Source/JavaScriptCore:
This adds a control flow equivalence analysis (called ControlEquivalenceAnalysis) based on
dominator analysis over the backwards CFG. Two basic blocks are control flow equivalent if
the execution of one implies that the other one must also execute. It means that the two
blocks' forward and backward dominance are reciprocated: (A dom B and B backdom A) or (B dom
A and A backdom B). LICM now uses it to become more conservative about hoisting checks, if
this has caused problems in the past. If we hoist something that may exit from a block that
was not control equivalent to the pre-header then it's possible that the node's speculation
will fail even though it wouldn't have if it wasn't hoisted. So, we flag these nodes'
origins as being "wasHoisted" and we track all of their exits as "HoistingFailed". LICM will
turn off such speculative hoisting if the CodeBlock from which we are hoisting had the
HoistingFailed exit kind.
Note that this deliberately still allows us to hoist things that may exit even if they are
not control equivalent to the pre-header. This is necessary because the profitability of
hoisting is so huge in all of the cases that we're aware of that it's worth giving it a
shot.
This is neutral on macrobenchmarks since none of the benchmarks we track have a hoistable
operation that would exit only if hoisted. I added microbenchmarks to illustrate the problem
and two of them speed up by ~40% while one of them is neutral (Int52 saves us from having
problems on that program even though LICM previously did the wrong thing).
- JavaScriptCore.xcodeproj/project.pbxproj:
- bytecode/ExitKind.cpp:
(JSC::exitKindToString):
- bytecode/ExitKind.h:
- dfg/DFGAtTailAbstractState.h:
(JSC::DFG::AtTailAbstractState::operator bool):
(JSC::DFG::AtTailAbstractState::initializeTo):
- dfg/DFGBackwardsCFG.h: Added.
(JSC::DFG::BackwardsCFG::BackwardsCFG):
- dfg/DFGBackwardsDominators.h: Added.
(JSC::DFG::BackwardsDominators::BackwardsDominators):
- dfg/DFGCommon.h:
(JSC::DFG::checkAndSet): Deleted.
- dfg/DFGControlEquivalenceAnalysis.h: Added.
(JSC::DFG::ControlEquivalenceAnalysis::ControlEquivalenceAnalysis):
(JSC::DFG::ControlEquivalenceAnalysis::dominatesEquivalently):
(JSC::DFG::ControlEquivalenceAnalysis::areEquivalent):
- dfg/DFGGraph.cpp:
(JSC::DFG::Graph::dump):
(JSC::DFG::Graph::dumpBlockHeader):
(JSC::DFG::Graph::invalidateCFG):
(JSC::DFG::Graph::substituteGetLocal):
(JSC::DFG::Graph::handleAssertionFailure):
(JSC::DFG::Graph::ensureDominators):
(JSC::DFG::Graph::ensurePrePostNumbering):
(JSC::DFG::Graph::ensureNaturalLoops):
(JSC::DFG::Graph::ensureBackwardsCFG):
(JSC::DFG::Graph::ensureBackwardsDominators):
(JSC::DFG::Graph::ensureControlEquivalenceAnalysis):
(JSC::DFG::Graph::methodOfGettingAValueProfileFor):
- dfg/DFGGraph.h:
(JSC::DFG::Graph::hasDebuggerEnabled):
- dfg/DFGInPlaceAbstractState.h:
(JSC::DFG::InPlaceAbstractState::operator bool):
(JSC::DFG::InPlaceAbstractState::createValueForNode):
(JSC::DFG::InPlaceAbstractState::forNode):
- dfg/DFGLICMPhase.cpp:
(JSC::DFG::LICMPhase::run):
(JSC::DFG::LICMPhase::attemptHoist):
- dfg/DFGMayExit.cpp:
(JSC::DFG::mayExit):
- dfg/DFGMayExit.h:
- dfg/DFGNode.h:
- dfg/DFGNodeOrigin.cpp:
(JSC::DFG::NodeOrigin::dump):
- dfg/DFGNodeOrigin.h:
(JSC::DFG::NodeOrigin::takeValidExit):
(JSC::DFG::NodeOrigin::withWasHoisted):
(JSC::DFG::NodeOrigin::forInsertingAfter):
- dfg/DFGNullAbstractState.h: Added.
(JSC::DFG::NullAbstractState::NullAbstractState):
(JSC::DFG::NullAbstractState::operator bool):
(JSC::DFG::NullAbstractState::forNode):
- dfg/DFGOSRExit.cpp:
(JSC::DFG::OSRExit::OSRExit):
- dfg/DFGOSRExitBase.cpp:
(JSC::DFG::OSRExitBase::considerAddingAsFrequentExitSiteSlow):
- dfg/DFGOSRExitBase.h:
(JSC::DFG::OSRExitBase::OSRExitBase):
- dfg/DFGTypeCheckHoistingPhase.cpp:
(JSC::DFG::TypeCheckHoistingPhase::run):
- ftl/FTLOSRExit.cpp:
(JSC::FTL::OSRExitDescriptor::prepareOSRExitHandle):
(JSC::FTL::OSRExit::OSRExit):
- ftl/FTLOSRExit.h:
Source/WTF:
This adds an adaptor for graphs called BackwardsGraph. The WTF graph framework is based on
passing around a Graph template argument that follows the protocol shared by DFG::CFG,
B3::CFG, and Air::CFG. These graphs always have a single root node but may have many leaf
nodes. This new BackwardsGraph adaptor reverses the graph by creating a synthetic return
node that it uses as the root in the inverted graph. This currently may resort to some
heuristics in programs that have an infinite loop, but other than that, it'll work well in
the general case.
This allows us to say Dominators<BackwardsGraph<some graph type>> as a way of computing
backwards dominators, which then allows us to easily answer control flow equivalence
queries.
- CMakeLists.txt:
- WTF.xcodeproj/project.pbxproj:
- wtf/BackwardsGraph.h: Added.
(WTF::BackwardsGraph::Node::Node):
(WTF::BackwardsGraph::Node::root):
(WTF::BackwardsGraph::Node::operator==):
(WTF::BackwardsGraph::Node::operator!=):
(WTF::BackwardsGraph::Node::operator bool):
(WTF::BackwardsGraph::Node::isRoot):
(WTF::BackwardsGraph::Node::node):
(WTF::BackwardsGraph::Set::Set):
(WTF::BackwardsGraph::Set::add):
(WTF::BackwardsGraph::Set::remove):
(WTF::BackwardsGraph::Set::contains):
(WTF::BackwardsGraph::Set::dump):
(WTF::BackwardsGraph::Map::Map):
(WTF::BackwardsGraph::Map::clear):
(WTF::BackwardsGraph::Map::size):
(WTF::BackwardsGraph::Map::operator[]):
(WTF::BackwardsGraph::BackwardsGraph):
(WTF::BackwardsGraph::root):
(WTF::BackwardsGraph::newMap):
(WTF::BackwardsGraph::successors):
(WTF::BackwardsGraph::predecessors):
(WTF::BackwardsGraph::index):
(WTF::BackwardsGraph::node):
(WTF::BackwardsGraph::numNodes):
(WTF::BackwardsGraph::dump):
- wtf/Dominators.h:
(WTF::Dominators::Dominators):
(WTF::Dominators::dump):
(WTF::Dominators::LengauerTarjan::computeDepthFirstPreNumbering):
- wtf/GraphNodeWorklist.h:
(WTF::GraphNodeWith::GraphNodeWith):
(WTF::GraphNodeWith::operator bool):
- wtf/StdLibExtras.h:
(WTF::callStatelessLambda):
(WTF::checkAndSet):
LayoutTests:
Add tests for LICM hoisting things that would only exit if hoisted.
- js/regress/licm-dragons-expected.txt: Added.
- js/regress/licm-dragons-out-of-bounds-expected.txt: Added.
- js/regress/licm-dragons-out-of-bounds.html: Added.
- js/regress/licm-dragons-overflow-expected.txt: Added.
- js/regress/licm-dragons-overflow.html: Added.
- js/regress/licm-dragons.html: Added.
- js/regress/script-tests/licm-dragons-out-of-bounds.js: Added.
(foo):
- js/regress/script-tests/licm-dragons-overflow.js: Added.
(foo):
- js/regress/script-tests/licm-dragons.js: Added.
(foo):
- 2:11 PM Changeset in webkit [201181] by
-
- 2 edits in trunk/LayoutTests
Web Inspector: use a consistent prefix for injected scripts
https://bugs.webkit.org/show_bug.cgi?id=157715
<rdar://problem/26287188>
Reviewed by Alexey Proskuryakov.
Follow-up fix to an affected test.
- inspector/debugger/scriptParsed.html:
Check whether the script is for CommandLineAPIModuleSource before
checking whether it is an InjectedScript. With the new naming scheme,
the latter is a subset of the former, so do the more specific check first.
- 2:02 PM Changeset in webkit [201180] by
-
- 4 edits in trunk/Source/JavaScriptCore
Code that null checks the VM pointer before any use should ref the VM.
https://bugs.webkit.org/show_bug.cgi?id=157864
Reviewed by Filip Pizlo and Keith Miller.
JSLock::willReleaseLock() and HeapTimer::timerDidFire() need to reference the VM
through a RefPtr. Otherwise, there's no guarantee that the VM won't be deleted
after their null checks.
- bytecode/CodeBlock.h:
(JSC::CodeBlock::vm):
(JSC::CodeBlock::setVM): Deleted.
- Not used, and suggests that it can be changed during the lifetime of the CodeBlock (which should not be).
- heap/HeapTimer.cpp:
(JSC::HeapTimer::timerDidFire):
- runtime/JSLock.cpp:
(JSC::JSLock::willReleaseLock):
- Store the VM pointer in a RefPtr first, and null check the RefPtr instead of the raw VM pointer. This makes the null check a strong guarantee that the VM pointer is valid while these functions are using it.
- 1:40 PM Changeset in webkit [201179] by
-
- 5 edits in branches/safari-602.1.32-branch/Source/WebInspectorUI
Merge r201177. rdar://problem/26373969
- 1:23 PM Changeset in webkit [201178] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: REGRESSION: Search magnifying glass shifted in Search tab input field
https://bugs.webkit.org/show_bug.cgi?id=157913
rdar://problem/26374424
Reviewed by Joseph Pecoraro.
- UserInterface/Views/SearchSidebarPanel.css:
(.sidebar > .panel.navigation.search > .search-bar > input[type="search"]): Removed padding-left.
(.sidebar > .panel.navigation.search > .search-bar > input[type="search"]::-webkit-search-results-button):
Added. Add margin-right here instead.
- 1:22 PM Changeset in webkit [201177] by
-
- 5 edits in trunk/Source/WebInspectorUI
Web Inspector: Timelines "Edit" button should be right-aligned
https://bugs.webkit.org/show_bug.cgi?id=157909
rdar://problem/26373969
Reviewed by Joseph Pecoraro.
- UserInterface/Views/ButtonNavigationItem.css:
(.navigation-bar .item.button.text-only): Deleted height: auto. Now inherited.
- UserInterface/Views/NavigationBar.css:
(.navigation-bar .item): Change height to auto to support any NavigationBar height.
This is needed since the Timelines tab has a shorter NavigationBar height, and
flexible items were overflowing.
- UserInterface/Views/TextNavigationItem.css:
(.navigation-bar .item.text): Deleted height: auto. Now inherited.
- UserInterface/Views/TimelineOverview.js:
(WebInspector.TimelineOverview): Add a FlexibleSpaceNavigationItem before the Edit button.
- 1:09 PM Changeset in webkit [201176] by
-
- 3 edits in trunk/Source/JavaScriptCore
arrow function lexical environment should reuse the same environment as the function's lexical environment where possible
https://bugs.webkit.org/show_bug.cgi?id=157908
Reviewed by Filip Pizlo.
We can safely combine these two environment when we have
a simple parameter list (no default parameters, no destructring parameters).
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::BytecodeGenerator):
(JSC::BytecodeGenerator::initializeDefaultParameterValuesAndSetupFunctionScopeStack):
(JSC::BytecodeGenerator::initializeArrowFunctionContextScopeIfNeeded):
- bytecompiler/BytecodeGenerator.h:
- 12:15 PM Changeset in webkit [201175] by
-
- 2 edits in trunk/Tools
Typo fix in import-test262-tests
https://bugs.webkit.org/show_bug.cgi?id=157902
Reviewed by Keith Miller.
- Scripts/import-test262-tests:
- 12:09 PM Changeset in webkit [201174] by
-
- 5 edits in trunk/Source/WebCore
Update RenderBlockFlow::adjustComputedFontSizes() to use RenderObjectTraversal
https://bugs.webkit.org/show_bug.cgi?id=157784
Reviewed by Zalan Bujtas.
Update RenderBlockFlow::adjustComputedFontSizes() to use RenderObjectTraversal
instead of having its own Renderer tree traversal API, specifically for iOS
text autosizing.
- rendering/RenderBlockFlow.cpp:
(WebCore::isVisibleRenderText):
(WebCore::resizeTextPermitted):
(WebCore::isNonBlocksOrNonFixedHeightListItems):
(WebCore::RenderBlockFlow::adjustComputedFontSizes):
- rendering/RenderIterator.h:
(WebCore::RenderObjectTraversal::nextSkippingChildren):
- rendering/RenderObject.cpp:
(WebCore::RenderObject::traverseNext): Deleted.
(WebCore::RenderObject::enclosingBox): Deleted.
(WebCore::RenderObject::enclosingBoxModelObject): Deleted.
(WebCore::RenderObject::fixedPositionedWithNamedFlowContainingBlock): Deleted.
(WebCore::hasFixedPosInNamedFlowContainingBlock): Deleted.
(WebCore::RenderObject::firstLineBlock): Deleted.
(WebCore::objectIsRelayoutBoundary): Deleted.
- rendering/RenderObject.h:
- 11:50 AM Changeset in webkit [201173] by
-
- 3 edits in trunk/Source/WebCore
Fix the build with GCC 4.9 in CSSParser.cpp
https://bugs.webkit.org/show_bug.cgi?id=157887
Reviewed by Chris Dumez.
- css/CSSParser.cpp:
(WebCore::CSSParser::createViewportRule):
- css/CSSParser.h:
- 11:39 AM Changeset in webkit [201172] by
-
- 2 edits in trunk/Source/JavaScriptCore
Unreviewed build fix.
Skipping this new test as it times out on the bots.
Issue tracked in https://bugs.webkit.org/show_bug.cgi?id=157903
- tests/stress/regress-157595.js:
(MyRegExp):
- 10:58 AM Changeset in webkit [201171] by
-
- 11 edits in trunk/Source
Web Inspector: timelines should not update via requestAnimationFrame unless Web Inspector is visible
https://bugs.webkit.org/show_bug.cgi?id=157897
<rdar://problem/26330802>
Reviewed by Timothy Hatcher.
Source/WebInspectorUI:
The timelines overview tries to animate using requestAnimationFrame, even if the
inspector frontend is not really visible. When it does this, requestAnimationFrame
simply stalls out until the inspector becomes visible. If a recording is started
while the inspector is not visible, then when it is shown again, the timeline will
start to animate from 0s instead of the current time. This happens because the
requestAnimationFrame was requested when the current time actually was 0, and it
finally executes some time later, when the current time is no longer accurate.
Since the timelines animate by calculating time elapsed since the previous frame
rather than using event timestamps, there is no way for the timelines to skip forward
in their animations in scenarios where the current time becomes arbitrarily skewed.
To fix this, consider the visibility state of the frontend as reported by the UIProcess.
Fire a global notification when visibility state changes, and start or stop updating
the current time as the frontend becomes visible or not shown.
This does not affect most other uses of requestAnimationFrame, which are used as
timers to call updateLayout at an appropriate time. The timelines case is different
because the current time is fixed prior to requesting an animation frame, and
later animation frames are only triggered by earlier requests, so there's nothing to
coalesce.
- UserInterface/Base/Main.js:
(WebInspector.loaded): Initialize WebInspector.visible.
- UserInterface/Base/Object.js: Add new event.
- UserInterface/Protocol/InspectorFrontendAPI.js:
(InspectorFrontendAPI.setIsVisible): Added.
- UserInterface/Test/Test.js:
(WebInspector.updateVisibilityState): Add a stub.
- UserInterface/Views/TimelineRecordingContentView.js:
(WebInspector.TimelineRecordingContentView):
(WebInspector.TimelineRecordingContentView.prototype._inspectorVisibilityStateChanged):
If visibility state changes while capturing, then start or stop updating the
current time as appropriate. Otherwise, refresh the timelines with updated
times so that they know about the recording's updated start/current/end time.
(WebInspector.TimelineRecordingContentView.prototype._startUpdatingCurrentTime):
Bail out if the Web Inspector frontend is not visible to the user and won't be
able to service requestAnimationFrames immediately.
Source/WebKit2:
The UIProcess needs to notify the Inspector frontend when it is truly visible.
The frontend can't use document.visibilityState because it doesn't seem to work
if the inspector frontend's WKWebView is created but not attached to a window.
- UIProcess/WebInspectorProxy.cpp:
(WebKit::WebInspectorProxy::open):
(WebKit::WebInspectorProxy::didClose):
Send visibility updates to the inspector process when the inspector becomes
"visible" or "not visible". It becomes visible if it is attached to the
inspected page's window, or gets its own native window.
- WebProcess/WebPage/WebInspectorUI.cpp:
(WebKit::WebInspectorUI::frontendLoaded):
(WebKit::WebInspectorUI::setDockingUnavailable):
(WebKit::WebInspectorUI::setIsVisible):
Call InspectorFrontendAPI.updateVisibilityState to let the frontend know.
- WebProcess/WebPage/WebInspectorUI.h:
- WebProcess/WebPage/WebInspectorUI.messages.in:
Add new message.
- 10:27 AM Changeset in webkit [201170] by
-
- 2 edits in trunk/Source/JavaScriptCore
JSC: DFG::SpeculativeJIT::compile special case for MIPS for PutByValWithThis
https://bugs.webkit.org/show_bug.cgi?id=157741
Patch by Guillaume Emont <guijemont@igalia.com> on 2016-05-19
Reviewed by Saam Barati.
The PutByValWithThis case needs a special case for MIPS because we
don't have enough registers. The special case needs to be different
from the x86 one because we have a different ABI.
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- 10:11 AM Changeset in webkit [201169] by
-
- 2 edits in trunk/Tools
[EFL] Fix the gst-libav build on ARM Thumb2 after r199649
https://bugs.webkit.org/show_bug.cgi?id=157893
Reviewed by Antonio Gomes.
- efl/patches/gst-libav.patch:
- 9:48 AM Changeset in webkit [201168] by
-
- 16 edits in trunk
Web Inspector: use a consistent prefix for injected scripts
https://bugs.webkit.org/show_bug.cgi?id=157715
<rdar://problem/26287188>
Reviewed by Timothy Hatcher.
Source/JavaScriptCore:
- CMakeLists.txt:
- DerivedSources.make:
- inspector/InjectedScriptSource.js:
Source/WebCore:
- CMakeLists.txt:
- DerivedSources.make:
- inspector/CommandLineAPIModuleSource.js:
Source/WebKit2:
- CMakeLists.txt:
- DerivedSources.make:
- WebProcess/Automation/WebAutomationSessionProxy.js:
LayoutTests:
Update how inspector tests check sourceURLs for internal scripts.
- inspector/debugger/scriptParsed.html:
- inspector/debugger/sourceURLs.html:
- 9:22 AM Changeset in webkit [201167] by
-
- 4 edits in trunk/Source/WebCore
Playback controls should not be active for muted media elements.
https://bugs.webkit.org/show_bug.cgi?id=157876
<rdar://problem/26007525>
Reviewed by Eric Carlson.
Consolidate calls to setUpPlaybackControlsManager() and clearUpPlaybackControlsManager()
into a new method, updatePlaybackControlsManager(), which checks with the MediaElementSession
whether the media element can currently control the playback controls manager, and call
one or the other method conditionally.
That means more logic needs to be moved into MediaElementSession::canControlControlsManager(),
such as whether the element is muted(), has ended(), or whether the element's document has
been suspended.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::~HTMLMediaElement):
(WebCore::HTMLMediaElement::setMuted):
(WebCore::HTMLMediaElement::updatePlayState):
(WebCore::HTMLMediaElement::clearMediaPlayer):
(WebCore::HTMLMediaElement::stopWithoutDestroyingMediaPlayer):
(WebCore::HTMLMediaElement::createMediaPlayer):
(WebCore::HTMLMediaElement::updatePlaybackControlsManager):
- html/HTMLMediaElement.h:
- html/MediaElementSession.cpp:
(WebCore::MediaElementSession::canControlControlsManager):
- 9:11 AM Changeset in webkit [201166] by
-
- 26 edits in trunk/Source/WebCore
Kill JSDOMBindings' createNewWrapper()
https://bugs.webkit.org/show_bug.cgi?id=157842
Reviewed by Youenn Fablet.
Kill JSDOMBindings' createNewWrapper() as it is identical to createWrapper().
- bindings/js/JSDOMBinding.h:
(WebCore::createNewWrapper): Deleted.
- bindings/js/JSDocumentFragmentCustom.cpp:
(WebCore::toJSNewlyCreated):
- bindings/js/JSNodeListCustom.cpp:
(WebCore::createWrapper):
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateImplementation):
- bindings/scripts/test/JS/JSTestActiveDOMObject.cpp:
(WebCore::toJSNewlyCreated):
- bindings/scripts/test/JS/JSTestClassWithJSBuiltinConstructor.cpp:
(WebCore::toJSNewlyCreated):
- bindings/scripts/test/JS/JSTestCustomConstructorWithNoInterfaceObject.cpp:
(WebCore::toJSNewlyCreated):
- bindings/scripts/test/JS/JSTestCustomNamedGetter.cpp:
(WebCore::toJSNewlyCreated):
- bindings/scripts/test/JS/JSTestEventConstructor.cpp:
(WebCore::toJSNewlyCreated):
- bindings/scripts/test/JS/JSTestEventTarget.cpp:
(WebCore::toJSNewlyCreated):
- bindings/scripts/test/JS/JSTestException.cpp:
(WebCore::toJSNewlyCreated):
- bindings/scripts/test/JS/JSTestGenerateIsReachable.cpp:
(WebCore::toJSNewlyCreated):
- bindings/scripts/test/JS/JSTestGlobalObject.cpp:
(WebCore::toJSNewlyCreated):
- bindings/scripts/test/JS/JSTestInterface.cpp:
(WebCore::toJSNewlyCreated):
- bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:
(WebCore::toJSNewlyCreated):
- bindings/scripts/test/JS/JSTestNamedConstructor.cpp:
(WebCore::toJSNewlyCreated):
- bindings/scripts/test/JS/JSTestNode.cpp:
(WebCore::toJSNewlyCreated):
- bindings/scripts/test/JS/JSTestNondeterministic.cpp:
(WebCore::toJSNewlyCreated):
- bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::toJSNewlyCreated):
- bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp:
(WebCore::toJSNewlyCreated):
- bindings/scripts/test/JS/JSTestOverrideBuiltins.cpp:
(WebCore::toJSNewlyCreated):
- bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:
(WebCore::toJSNewlyCreated):
- bindings/scripts/test/JS/JSTestTypedefs.cpp:
(WebCore::toJSNewlyCreated):
- bindings/scripts/test/JS/JSattribute.cpp:
(WebCore::toJSNewlyCreated):
- bindings/scripts/test/JS/JSreadonly.cpp:
(WebCore::toJSNewlyCreated):
- 9:07 AM Changeset in webkit [201165] by
-
- 2 edits in trunk/Tools
REGRESSION(r200951): VideoControlsManager API tests time out
https://bugs.webkit.org/show_bug.cgi?id=157896
<rdar://problem/26326293>
Reviewed by Eric Carlson.
Explicitly disable user gesture requirements for playback.
- TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
(TestWebKitAPI::TEST):
- 9:03 AM Changeset in webkit [201164] by
-
- 2 edits in trunk/Source/WebCore
Playback controls still valid after navigating back after watching YouTube video.
https://bugs.webkit.org/show_bug.cgi?id=157874
<rdar://problem/25993063>
Reviewed by Eric Carlson.
YouTube uses window.onpopstate to "navigate" backwards from a video page to the main page
(or other video page). This causes the playback controls to not be cleared (since no
navigation actually occured). Instead, clear the playback controls when we clear our
MediaPlayer due to load() being called, when the src= attribute is changed, or when a
<source> element is added to the <video>.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::clearMediaPlayer):
(WebCore::HTMLMediaElement::createMediaPlayer):
- 7:33 AM Changeset in webkit [201163] by
-
- 4 edits in trunk/Source/WebCore
[GStreamer] unrelated codecs required to play videos
https://bugs.webkit.org/show_bug.cgi?id=135972
Reviewed by Michael Catanzaro.
Instead of hard-coding the list of supported mime-types, check the
decoder and demuxer GStreamer elements available and dynamically
build the list of mime-types accordingly. This patch also removes
support for under-used and exotic mime-types.
Based on a patch by Mario Sanchez Prada.
No new tests, existing media tests cover this change.
- platform/graphics/gstreamer/GStreamerUtilities.cpp:
(WebCore::gstRegistryHasElementForMediaType): New function
checking the elements registered in the factories have a sink pad
matching the caps specified as second argument of the function.
- platform/graphics/gstreamer/GStreamerUtilities.h:
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::mimeTypeSet): Hard-coded list of mime-types replaced by
runtime-built list of mime-types that can be supported by the
GStreamer decoders and demuxers available on the host machine.
(WebCore::MediaPlayerPrivateGStreamer::getSupportedTypes):
mimeTypeCache renamed to mimeTypeSet.
(WebCore::MediaPlayerPrivateGStreamer::supportsType): Ditto.
- 7:19 AM Changeset in webkit [201162] by
-
- 2 edits in trunk/Source/WebCore
[ARM] Fix Wformat warning in MemoryPressureHandler.cpp
https://bugs.webkit.org/show_bug.cgi?id=157892
Reviewed by Michael Saboff.
- platform/MemoryPressureHandler.cpp:
(WebCore::MemoryPressureHandler::ReliefLogger::logMemoryUsageChange):
- 7:19 AM Changeset in webkit [201161] by
-
- 3 edits in trunk/Source/JavaScriptCore
[ARM] Remove redefined macro after r200606
https://bugs.webkit.org/show_bug.cgi?id=157890
Reviewed by Michael Saboff.
- bytecode/PolymorphicAccess.cpp:
- jit/CCallHelpers.h:
- 7:15 AM Changeset in webkit [201160] by
-
- 2 edits in trunk/Source/WebCore
Remove castDOMMobjectForWrapperCreation(T&)
https://bugs.webkit.org/show_bug.cgi?id=157886
Reviewed by Andreas Kling.
No change of behavior.
- bindings/js/JSDOMBinding.h:
(WebCore::castDOMObjectForWrapperCreation): Deleted.
- 6:22 AM Changeset in webkit [201159] by
-
- 7 edits in trunk
Style resolution for explicitly inherited properties is inefficient
https://bugs.webkit.org/show_bug.cgi?id=157860
Reviewed by Andreas Kling.
Source/WebCore:
We mark the parent style with hasExplicitlyInheritedProperties bit rather than the style that is actually
affected by inherited properties. This leads to various inefficiencies including unnecessarily wide style recalcs.
- css/StyleResolver.cpp:
(WebCore::isCacheableInMatchedPropertiesCache):
Check the style itself rather than the parent. This allows more caching.
(WebCore::StyleResolver::applyProperty):
Mark the style rather than the parent.
- style/StyleChange.cpp:
(WebCore::Style::determineChange):
Remove hasExplicitlyInheritedProperties test and just return NoInherit. Having explicitly inherited
properties doesn't make the children inherit them automatically.
This allows smaller style recalcs.
- style/StyleTreeResolver.cpp:
(WebCore::Style::TreeResolver::resolveElement):
This patch exposed a bug with appearance property in meter and progress elements.
They may construct different renderer based on appearance so we need to force
render tree reconstruction when it changes.
(WebCore::Style::TreeResolver::popParentsToDepth):
(WebCore::Style::shouldResolvePseudoElement):
Don't clear the style recalc bits here.
(WebCore::Style::shouldResolveElement):
Add a helper.
If the parent had a NoInherit style change, test if the element has existing style with
hasExplicitlyInheritedProperties bit. If so we need to re-resolve this element.
(WebCore::Style::clearNeedsStyleResolution):
Also clear pseudo elements.
(WebCore::Style::TreeResolver::resolveComposedTree):
LayoutTests:
- platform/ios-simulator/fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element-expected.txt:
- platform/mac/fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element-expected.txt:
This is a progression.
- 5:03 AM Changeset in webkit [201158] by
-
- 3 edits in trunk/Tools
Slow JSC stress tests times out in 32 bit debug mode
https://bugs.webkit.org/show_bug.cgi?id=154964
Reviewed by Michael Catanzaro.
- Scripts/run-javascriptcore-tests:
(runJSCStressTests): Pass through the --debug option.
- Scripts/run-jsc-stress-tests: Increase the timeout for debug builds.
- 2:36 AM Changeset in webkit [201157] by
-
- 3 edits in branches/safari-602.1.32-branch/Source/WebKit2
Merge r201110. rdar://problem/25730174
- 2:36 AM Changeset in webkit [201156] by
-
- 2 edits in branches/safari-602.1.32-branch/Source/WebKit2
Merge r201016. rdar://problem/25584201
- 2:36 AM Changeset in webkit [201155] by
-
- 2 edits in branches/safari-602.1.32-branch/Tools
Merge r200978. rdar://problem/25584201
- 2:35 AM Changeset in webkit [201154] by
-
- 10 edits in branches/safari-602.1.32-branch
Merge r200951. rdar://problem/25584201
- 1:41 AM Changeset in webkit [201153] by
-
- 4 edits in branches/safari-602.1.32-branch/Source/WebCore
Merge r201119. rdar://problem/26225793
- 1:41 AM Changeset in webkit [201152] by
-
- 2 edits in branches/safari-602.1.32-branch/Source/WebCore
Merge r201103. rdar://problem/26339922
- 1:41 AM Changeset in webkit [201151] by
-
- 3 edits in branches/safari-602.1.32-branch/Source/WebInspectorUI
Merge r201102. rdar://problem/26339922
- 1:41 AM Changeset in webkit [201150] by
-
- 2 edits in branches/safari-602.1.32-branch/Source/WebInspectorUI
Merge r201092. rdar://problem/26349229
- 1:41 AM Changeset in webkit [201149] by
-
- 2 edits in branches/safari-602.1.32-branch/Source/WebInspectorUI
Merge r200661.
- 1:41 AM Changeset in webkit [201148] by
-
- 11 edits2 adds in branches/safari-602.1.32-branch
Merge r200651. rdar://problem/26188642
- 1:40 AM Changeset in webkit [201147] by
-
- 14 edits3 adds in branches/safari-602.1.32-branch
Merge r201090. rdar://problem/26334636
- 1:40 AM Changeset in webkit [201146] by
-
- 4 edits in branches/safari-602.1.32-branch/Source/WebKit2
Merge r201079. rdar://problem/26334648
- 1:40 AM Changeset in webkit [201145] by
-
- 12 edits in branches/safari-602.1.32-branch
Merge r201065. rdar://problem/26333137
- 1:40 AM Changeset in webkit [201144] by
-
- 3 edits in branches/safari-602.1.32-branch/Source/WebCore
Merge r201043. rdar://problem/25835802
- 1:40 AM Changeset in webkit [201143] by
-
- 2 edits in branches/safari-602.1.32-branch/Source/WebKit2
Merge r200961. rdar://problem/25984480
- 1:40 AM Changeset in webkit [201142] by
-
- 6 edits in branches/safari-602.1.32-branch/Source/WebKit2
Merge r200959. rdar://problem/26298247
- 1:40 AM Changeset in webkit [201141] by
-
- 2 edits in branches/safari-602.1.32-branch/Source/WebKit2
Merge r200950. rdar://problem/26287306
- 1:40 AM Changeset in webkit [201140] by
-
- 2 edits in branches/safari-602.1.32-branch/Source/WebInspectorUI
Merge r200949. rdar://problem/26262219
- 1:40 AM Changeset in webkit [201139] by
-
- 11 edits in branches/safari-602.1.32-branch/Source/WebInspectorUI
Merge r200947. rdar://problem/26286090
- 1:40 AM Changeset in webkit [201138] by
-
- 8 edits in branches/safari-602.1.32-branch/Source/WebInspectorUI
Merge r200873. rdar://problem/26228605
- 1:40 AM Changeset in webkit [201137] by
-
- 2 edits in branches/safari-602.1.32-branch/Source/WebInspectorUI
Merge r200809. rdar://problem/26260709
- 1:40 AM Changeset in webkit [201136] by
-
- 2 edits in branches/safari-602.1.32-branch/Source/WebInspectorUI
Merge r200805. rdar://problem/26252938
- 1:40 AM Changeset in webkit [201135] by
-
- 2 edits in branches/safari-602.1.32-branch/Source/WebInspectorUI
Merge r200779. rdar://problem/26239051
- 1:40 AM Changeset in webkit [201134] by
-
- 7 edits1 add in branches/safari-602.1.32-branch/Source/WebInspectorUI
Merge r200767. rdar://problem/26231245
- 1:39 AM Changeset in webkit [201133] by
-
- 3 edits in branches/safari-602.1.32-branch/Source/WebInspectorUI
Merge r200716. rdar://problem/26232856
- 1:39 AM Changeset in webkit [201132] by
-
- 9 edits in branches/safari-602.1.32-branch/Source/WebKit2
Merge r200702. rdar://problem/26190121
- 1:39 AM Changeset in webkit [201131] by
-
- 4 edits in branches/safari-602.1.32-branch/Source/WebInspectorUI
Merge r200656. rdar://problem/25898256
- 1:08 AM Changeset in webkit [201130] by
-
- 4 edits in trunk/LayoutTests
REGRESSION (r200887): LayoutTest http/tests/performance/performance-resource-timing-cached-entries.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=157816
Reviewed by Alexey Proskuryakov.
Mark the test as flaky, and add console logs to try to figure out the cause for flakiness.
- TestExpectations: Mark the test as flaky.
- http/tests/performance/performance-resource-timing-cached-entries.html: Add prints to better identify the flakiness root cause.
- 12:32 AM Changeset in webkit [201129] by
-
- 46 edits in trunk/Source/WebCore
Refactor toJS functions to use toJSNewlyCreated
https://bugs.webkit.org/show_bug.cgi?id=157835
Reviewed by Chris Dumez.
Moving checks generated by binding generator from toJS to toJSNewlyCreated.
Changing wrap template function to use toJSNewlyCreated function.
This allows DOMClass toJS() to be equivalent to wrap template function.
Refactored custom binding code to take benefit of this.
Covered by existing tests.
- bindings/js/JSAnimationTimelineCustom.cpp:
(WebCore::toJSNewlyCreated):
(WebCore::toJS):
- bindings/js/JSBlobCustom.cpp:
(WebCore::toJSNewlyCreated):
(WebCore::toJS):
- bindings/js/JSCSSRuleCustom.cpp:
(WebCore::toJSNewlyCreated):
(WebCore::toJS):
- bindings/js/JSCSSValueCustom.cpp:
(WebCore::toJSNewlyCreated):
(WebCore::toJS):
- bindings/js/JSCanvasRenderingContextCustom.cpp:
(WebCore::toJSNewlyCreated):
(WebCore::toJS):
- bindings/js/JSDOMBinding.h:
(WebCore::wrap):
(WebCore::toJS):
- bindings/js/JSDocumentCustom.cpp:
(WebCore::toJS):
(WebCore::cachedDocumentWrapper): Deleted.
- bindings/js/JSDocumentFragmentCustom.cpp:
(WebCore::toJSNewlyCreated):
(WebCore::toJS):
- bindings/js/JSEventCustom.cpp:
(WebCore::toJSNewlyCreated):
(WebCore::toJS):
- bindings/js/JSHTMLCollectionCustom.cpp:
(WebCore::toJSNewlyCreated):
(WebCore::toJS):
- bindings/js/JSHTMLDocumentCustom.cpp:
(WebCore::toJSNewlyCreated):
(WebCore::toJS):
- bindings/js/JSHTMLTemplateElementCustom.cpp:
(WebCore::JSHTMLTemplateElement::content):
- bindings/js/JSIDBCursorCustom.cpp:
(WebCore::toJSNewlyCreated):
(WebCore::toJS):
- bindings/js/JSImageDataCustom.cpp:
(WebCore::toJSNewlyCreated):
(WebCore::toJS):
- bindings/js/JSMediaStreamCapabilitiesCustom.cpp:
(WebCore::toJSNewlyCreated):
(WebCore::toJS):
- bindings/js/JSNodeListCustom.h:
(WebCore::toJS):
- bindings/js/JSPerformanceEntryCustom.cpp:
(WebCore::toJSNewlyCreated):
(WebCore::toJS):
- bindings/js/JSSVGPathSegCustom.cpp:
(WebCore::toJSNewlyCreated):
(WebCore::toJS):
- bindings/js/JSStyleSheetCustom.cpp:
(WebCore::toJSNewlyCreated):
(WebCore::toJS):
- bindings/js/JSTextCustom.cpp:
(WebCore::toJSNewlyCreated):
(WebCore::toJS):
- bindings/js/JSTextTrackCueCustom.cpp:
(WebCore::toJSNewlyCreated):
(WebCore::toJS):
- bindings/js/JSTrackCustom.cpp:
(WebCore::toJS):
- bindings/js/JSXMLDocumentCustom.cpp:
(WebCore::toJSNewlyCreated):
(WebCore::toJS):
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateImplementation):
- bindings/scripts/test/JS/JSTestActiveDOMObject.cpp:
- bindings/scripts/test/JS/JSTestClassWithJSBuiltinConstructor.cpp:
- bindings/scripts/test/JS/JSTestCustomConstructorWithNoInterfaceObject.cpp:
- bindings/scripts/test/JS/JSTestCustomNamedGetter.cpp:
- bindings/scripts/test/JS/JSTestEventConstructor.cpp:
- bindings/scripts/test/JS/JSTestEventTarget.cpp:
- bindings/scripts/test/JS/JSTestException.cpp:
- bindings/scripts/test/JS/JSTestGenerateIsReachable.cpp:
- bindings/scripts/test/JS/JSTestGlobalObject.cpp:
- bindings/scripts/test/JS/JSTestInterface.cpp:
- bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:
- bindings/scripts/test/JS/JSTestNamedConstructor.cpp:
- bindings/scripts/test/JS/JSTestNondeterministic.cpp:
- bindings/scripts/test/JS/JSTestObj.cpp:
- bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp:
- bindings/scripts/test/JS/JSTestOverrideBuiltins.cpp:
- bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:
- bindings/scripts/test/JS/JSTestTypedefs.cpp:
- bindings/scripts/test/JS/JSattribute.cpp:
- bindings/scripts/test/JS/JSreadonly.cpp:
- 12:14 AM Changeset in webkit [201128] by
-
- 11 edits in trunk/Source/WebCore
Make binding DOM constructor use toJSNewlyCreated instead of toJS
https://bugs.webkit.org/show_bug.cgi?id=157832
Reviewed by Chris Dumez.
Using toJSNewlyCreated in generated constructors instead of toJS.
Enabling generation of toJS and toJSNewlyCreated for constructable DOM objects.
This ensures that toJSNewlyCreated call in constructor will compile properly.
Updating some custom code to implement toJSNewlyCreated.
Covered by existing tests.
- bindings/js/JSImageDataCustom.cpp:
(WebCore::toJSNewlyCreated):
(WebCore::toJS):
- bindings/js/JSTextTrackCueCustom.cpp:
(WebCore::toJSNewlyCreated):
(WebCore::toJS):
- bindings/scripts/CodeGeneratorJS.pm:
(ShouldGenerateToJSDeclaration):
(GenerateConstructorDefinition):
- bindings/scripts/test/JS/JSTestInterface.cpp:
(WebCore::JSTestInterfaceConstructor::construct):
- bindings/scripts/test/JS/JSTestNamedConstructor.cpp:
(WebCore::JSTestNamedConstructorNamedConstructor::construct):
- bindings/scripts/test/JS/JSTestNode.cpp:
(WebCore::JSTestNodeConstructor::construct):
(WebCore::toJSNewlyCreated):
(WebCore::toJS):
- bindings/scripts/test/JS/JSTestNode.h:
(WebCore::toJS):
(WebCore::toJSNewlyCreated):
- bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::JSTestObjConstructor::construct):
- bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp:
(WebCore::constructJSTestOverloadedConstructors1):
(WebCore::constructJSTestOverloadedConstructors2):
(WebCore::constructJSTestOverloadedConstructors3):
(WebCore::constructJSTestOverloadedConstructors4):
(WebCore::constructJSTestOverloadedConstructors5):
- bindings/scripts/test/JS/JSTestTypedefs.cpp:
(WebCore::JSTestTypedefsConstructor::construct):
May 18, 2016:
- 10:20 PM Changeset in webkit [201127] by
-
- 2 edits in trunk/Websites/perf.webkit.org
Perf dashboard "Add pane" should list first by test, then by machine
https://bugs.webkit.org/show_bug.cgi?id=157880
Reviewed by Stephanie Lewis.
Reversed the order which tests and platforms are selected. Also split .pane-selector-container into #tests and
#platform for the ease of DOM node manipulations.
- public/v3/components/pane-selector.js:
(PaneSelector):
(PaneSelector.prototype._renderPlatformList): Renamed from _renderPlatformLists since there is a single list
for platforms. This list now disappears while a non-metric item is selected in the collection of test lists.
e.g. "Speedometer" instead of its "Score" metric. Remember the last metric we rendered to avoid churning.
(PaneSelector.prototype._renderTestLists): Render the top level tests once. The index of lists have been
decreased by one since test lists are now inside #tests instead of appearing after the platform list.
(PaneSelector.prototype._buildTestList): Don't filter tests since platform is chosen after tests now.
(PaneSelector.prototype._replaceList):
(PaneSelector.prototype._selectedItem): Don't reset the test path (specifies which subtest or metric is picked)
when a platform is selected since it happens after a test metric is chosen now.
(PaneSelector.prototype._clickedItem): Add a pane when a platform is clicked, not when a metric is clicked.
(PaneSelector.cssTemplate):
- 9:57 PM Changeset in webkit [201126] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Classes toggle wraps in some localizations
https://bugs.webkit.org/show_bug.cgi?id=157878
rdar://problem/26108859
Reviewed by Brian Burg.
- UserInterface/Views/CSSStyleDetailsSidebarPanel.css:
(.sidebar > .panel.details.css-style > .content ~ .options-container > .toggle-class-toggle):
Add white-space: nowrap.
- 8:21 PM Changeset in webkit [201125] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: unable to switch between navigation tree outlines using up/down arrow keys
https://bugs.webkit.org/show_bug.cgi?id=157713
<rdar://problem/26287086>
Reviewed by Timothy Hatcher.
- UserInterface/Views/NavigationSidebarPanel.js:
(WebInspector.NavigationSidebarPanel.prototype.createContentTreeOutline):
Listen for TreeOutline focus changes, and associate trees and their DOM
elements for quick lookup when handling focus events.
(WebInspector.NavigationSidebarPanel.prototype._contentTreeOutlineDidFocus):
(WebInspector.NavigationSidebarPanel.prototype._contentTreeOutlineTreeSelectionDidChange):
When selecting a tree element causes an element in a different tree outline
to be deselected, remember the old selection so that it can be restored
the next time the tree outline get the focus.
- 8:11 PM Changeset in webkit [201124] by
-
- 3 edits in trunk/Source/WebCore
Make LayoutUnit::operator bool() explicit.
https://bugs.webkit.org/show_bug.cgi?id=157871
Reviewed by Simon Fraser.
This is in preparation for getting LayoutUnit::operator int() removed.
No behaviour change.
- platform/LayoutUnit.h:
(WebCore::LayoutUnit::operator bool):
- rendering/RenderView.cpp:
(WebCore::RenderView::initializeLayoutState): Negative page height is invalid.
- 7:39 PM Changeset in webkit [201123] by
-
- 5 edits in trunk/Websites/perf.webkit.org
Analysis task should look for a git commit based on abridged hashes
https://bugs.webkit.org/show_bug.cgi?id=157877
<rdar://problem/26254374>
Reviewed by Chris Dumez.
Made /privileged-api/associate-commit look for commits using LIKE instead of an exact match.
Associate the commit when there is exactly one match.
- public/include/commit-log-fetcher.php:
(CommitLogFetcher::fetch_between):
- public/include/db.php:
(Database::escape_for_like): Extracted from CommitLogFetcher::fetch_between.
- public/privileged-api/associate-commit.php:
(main): Look for the commits using LIKE. Reject whenever there are multiple commits. We limit the number of
matches to two for performance when the user specifies something that almost thousands of commits: e.g. "1".
- public/v3/pages/analysis-task-page.js:
(AnalysisTaskPage.prototype._associateCommit): Added human friendly error messages for mismatching commits.
- 6:27 PM Changeset in webkit [201122] by
-
- 4 edits1 add in trunk/Source/JavaScriptCore
Function with default parameter values that are arrow functions that capture this isn't working
https://bugs.webkit.org/show_bug.cgi?id=157786
<rdar://problem/26327329>
Reviewed by Geoffrey Garen.
To make the scopes ordered properly, I needed to initialize the arrow
function lexical environment before initializing default parameter values.
I also made the code easier to reason about by never reusing the function's
var lexical environment for the arrow function lexical environment. The
reason for this is that that code was wrong, and we just didn't have code to
that properly tested it. It was easy for that code to be wrong because
sometimes the function's lexical environment isn't the top-most scope
(namely, when a function's parameter list is non-simple) and sometimes
it is (when the function's parameter list is simple).
Also, because a function's default parameter values may capture the
'arguments' variable inside an arrow function, I needed to take care
to initialize the 'arguments' variable as part of whichever scope
is the top-most scope. It's either the function's var environment
if the parameter list is simple, or it's the function's parameter
environment if the parameter list is non-simple.
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::BytecodeGenerator):
(JSC::BytecodeGenerator::initializeDefaultParameterValuesAndSetupFunctionScopeStack):
(JSC::BytecodeGenerator::initializeArrowFunctionContextScopeIfNeeded):
(JSC::BytecodeGenerator::initializeParameters):
(JSC::BytecodeGenerator::initializeVarLexicalEnvironment):
(JSC::BytecodeGenerator::visibleNameForParameter):
- bytecompiler/BytecodeGenerator.h:
- tests/stress/arrow-functions-as-default-parameter-values.js: Added.
(assert):
(test):
(test.foo):
- tests/stress/op-push-name-scope-crashes-profiler.js:
(test):
- 6:01 PM Changeset in webkit [201121] by
-
- 2 edits in trunk/Source/WTF
StringBuilder::appendQuotedJSONString doesn't properly protect against the math it's doing. Make the math fit the assertion.
https://bugs.webkit.org/show_bug.cgi?id=157868
Reviewed by Benjamin Poulain.
appendQuotedJSONString was rounding up to the next power of two when resizing
its buffer. Lets call the allocation size X. If X > 231, then
roundUpToPowerOfTwo(X) == 0. This patch fixes this by making the
assertion reflect what the code is doing. We now allocate to a size
of X = std::max(maximumCapacityRequired , roundUpToPowerOfTwo(maximumCapacityRequired))
- wtf/text/StringBuilder.cpp:
(WTF::StringBuilder::appendQuotedJSONString):
- 5:45 PM Changeset in webkit [201120] by
-
- 2 edits in trunk/Websites/perf.webkit.org
Unreviewed build fix. Use --date-order so that every child commit appears after its parent.
Otherwise we'll hit a FailedToFindParentCommit error while submitting a commit that appears before its parent.
- tools/sync-commits.py:
(GitRepository._fetch_all_hashes):
- 5:20 PM Changeset in webkit [201119] by
-
- 4 edits in trunk/Source/WebCore
[iOS] Fullscreen video playback broken in WK1 apps
https://bugs.webkit.org/show_bug.cgi?id=157847
<rdar://problem/25879521>
Reviewed by Jer Noble.
- platform/cocoa/WebVideoFullscreenModelVideoElement.h:
(WebCore::WebVideoFullscreenModelVideoElement::playbackSessionModel): New, model accessor.
- platform/cocoa/WebVideoFullscreenModelVideoElement.mm:
(WebVideoFullscreenModelVideoElement::setWebVideoFullscreenInterface): Set model's playback interface.
(WebVideoFullscreenModelVideoElement::setVideoElement): Set model's video element.
- platform/ios/WebVideoFullscreenControllerAVKit.mm:
(WebVideoFullscreenControllerContext::didCleanupFullscreen): Clear m_sessionModel.
(WebVideoFullscreenControllerContext::setVideoDimensions): This is called from both the UI and
Web threads, so dispatch to the UI thread when necessary.
(WebVideoFullscreenControllerContext::play): Call the model's playback session on the Web thread.
(WebVideoFullscreenControllerContext::pause): Ditto.
(WebVideoFullscreenControllerContext::togglePlayState): Ditto.
(WebVideoFullscreenControllerContext::beginScrubbing): Ditto.
(WebVideoFullscreenControllerContext::endScrubbing): Ditto.
(WebVideoFullscreenControllerContext::seekToTime): Ditto.
(WebVideoFullscreenControllerContext::fastSeek): Ditto.
(WebVideoFullscreenControllerContext::beginScanningForward): Ditto.
(WebVideoFullscreenControllerContext::beginScanningBackward): Ditto.
(WebVideoFullscreenControllerContext::endScanning): Ditto.
(WebVideoFullscreenControllerContext::selectAudioMediaOption): Ditto.
(WebVideoFullscreenControllerContext::selectLegibleMediaOption): Ditto.
(WebVideoFullscreenControllerContext::setUpFullscreen): Create and configure a session model.
(WebVideoFullscreenSessionModel::play): Pass call back to the controller.
(WebVideoFullscreenSessionModel::pause): Ditto.
(WebVideoFullscreenSessionModel::togglePlayState): Ditto.
(WebVideoFullscreenSessionModel::beginScrubbing): Ditto.
(WebVideoFullscreenSessionModel::endScrubbing): Ditto.
(WebVideoFullscreenSessionModel::seekToTime): Ditto.
(WebVideoFullscreenSessionModel::fastSeek): Ditto.
(WebVideoFullscreenSessionModel::beginScanningForward): Ditto.
(WebVideoFullscreenSessionModel::beginScanningBackward): Ditto.
(WebVideoFullscreenSessionModel::endScanning): Ditto.
(WebVideoFullscreenSessionModel::selectAudioMediaOption): Ditto.
(WebVideoFullscreenSessionModel::selectLegibleMediaOption): Ditto.
- 5:04 PM Changeset in webkit [201118] by
-
- 3 edits in trunk/Source/WebKit2
Add WKPreferencesRef getter/setter pair to set RTL mode
https://bugs.webkit.org/show_bug.cgi?id=157873
rdar://problem/26329970
Reviewed by Tim Horton.
- UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesSetUserInterfaceDirectionPolicy):
(WKPreferencesGetUserInterfaceDirectionPolicy):
- UIProcess/API/C/WKPreferencesRef.h:
- 4:55 PM Changeset in webkit [201117] by
-
- 2 edits in trunk/Tools
Remove underline from Status Bubbles on dashboard
https://bugs.webkit.org/show_bug.cgi?id=157870
rdar://problem/26332321
Reviewed by Alexey Proskuryakov.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css: Reverted style
change made in http://trac.webkit.org/r200880
- 4:49 PM Changeset in webkit [201116] by
-
- 2 edits in trunk/Websites/perf.webkit.org
Removed the erroneously committed debug code.
- tools/sync-commits.py:
(GitRepository.fetch_commit):
- 4:42 PM Changeset in webkit [201115] by
-
- 2 edits1 add1 delete in trunk/Websites/perf.webkit.org
Perf dashboard should have a script to sync git commits
https://bugs.webkit.org/show_bug.cgi?id=157867
Reviewed by Chris Dumez.
Added the support to pull from a Git repo to pull-svn.py and renamed it to sync-commits.py.
Added two classes SVNRepository and GitRepository which inherits from an abstract class, Repository.
The code that fetches commit and format revision number / git hash is specialized in each.
- Install.md:
- tools/pull-svn.py: Removed.
- tools/sync-commits.py: Renamed from Websites/perf.webkit.org/tools/pull-svn.py.
(main): Renamed --svn-config-json to --repository-config-json. Also made it robust against exceptions
inside fetch_commits_and_submit of each Repository class.
(load_repository): A factory function for SVNRepository and GitRepository.
(Repository): Added.
(Repository.init): Added.
(Repository.fetch_commits_and_submit): Extracted from standalone fetch_commits_and_submit.
(Repository.fetch_commit): Added. Implemented by a subclass.
(Repository.format_revision): Ditto.
(Repository.determine_last_reported_revision): Extracted from alonealone
determine_first_revision_to_fetch. The fallback to use "oldest" has been moved to SVNRepository's
fetch_commit since it doesn't work in Git.
(Repository.fetch_revision_from_dasbhoard): Extracted from fetch_revision_from_dasbhoard.
(SVNRepository): Added.
(SVNRepository.init): Added.
(SVNRepository.fetch_commit): Extracted from standalone fetch_commit_and_resolve_author and fetch_commit.
(SVNRepository._resolve_author_name): Renamed from resolve_author_name_from_account.
(SVNRepository.format_revision): Added.
(GitRepository): Added.
(GitRepository.init):
(GitRepository.fetch_commit): Added. Fetches the list of all git hashes if needed, and finds the next hash.
(GitRepository._find_next_hash): Added. Finds the first commit that appears after the specified hash.
(GitRepository._fetch_all_hashes): Added. Gets the list of all git hashs chronologically (old to new).
(GitRepository._run_git_command): Added.
(GitRepository.format_revision): Added. Use the first 8 characters of the hash.
- 4:25 PM Changeset in webkit [201114] by
-
- 6 edits in trunk/Source
Remove LayoutUnit::operator unsigned().
https://bugs.webkit.org/show_bug.cgi?id=157856
Reviewed by Simon Fraser.
Converting LayoutUnit values to unsigned is lossy. We should avoid
such implicit conversions.
No behaviour change.
- html/ImageInputType.cpp:
(WebCore::ImageInputType::height):
(WebCore::ImageInputType::width):
- page/EventHandler.cpp:
(WebCore::EventHandler::hitTestResultAtPoint):
- platform/LayoutUnit.h:
(WebCore::LayoutUnit::operator unsigned): Deleted.
- rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::computeColumnCountAndWidth):
- 4:09 PM Changeset in webkit [201113] by
-
- 49 edits in trunk/Source
Clean up CSS code
https://bugs.webkit.org/show_bug.cgi?id=157808
Reviewed by Chris Dumez.
Source/WebCore:
No new tests. Just cleaning up and modernizing code.
- css/BasicShapeFunctions.cpp:
(WebCore::convertToCenterCoordinate):
(WebCore::cssValueToBasicShapeRadius):
(WebCore::basicShapeForValue):
- css/BasicShapeFunctions.h:
- css/CSSAnimationTriggerScrollValue.h:
(WebCore::CSSAnimationTriggerScrollValue::create):
(WebCore::CSSAnimationTriggerScrollValue::startValue):
(WebCore::CSSAnimationTriggerScrollValue::CSSAnimationTriggerScrollValue):
- css/CSSAspectRatioValue.h:
- css/CSSBasicShapes.h:
- css/CSSBorderImage.cpp:
(WebCore::createBorderImageValue):
- css/CSSBorderImage.h:
- css/CSSBorderImageSliceValue.h:
(WebCore::CSSBorderImageSliceValue::create):
- css/CSSCalculationValue.h:
- css/CSSCanvasValue.h:
(WebCore::CSSCanvasValue::CSSCanvasValue):
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::valueForNinePieceImageSlice):
(WebCore::valueForNinePieceImageQuad):
(WebCore::valueForNinePieceImage):
(WebCore::zoomAdjustedPixelValue):
- css/CSSComputedStyleDeclaration.h:
- css/CSSFontFaceLoadEvent.cpp:
(WebCore::CSSFontFaceLoadEvent::CSSFontFaceLoadEvent):
- css/CSSFontFaceLoadEvent.h:
- css/CSSFontValue.h:
- css/CSSFunctionValue.h:
- css/CSSGradientValue.h:
(WebCore::CSSGradientValue::setFirstX):
(WebCore::CSSGradientValue::setFirstY):
(WebCore::CSSGradientValue::setSecondX):
(WebCore::CSSGradientValue::setSecondY):
(WebCore::CSSGradientValue::addStop):
(WebCore::CSSLinearGradientValue::create):
(WebCore::CSSLinearGradientValue::setAngle):
(WebCore::CSSRadialGradientValue::setFirstRadius):
(WebCore::CSSRadialGradientValue::setSecondRadius):
(WebCore::CSSRadialGradientValue::setShape):
(WebCore::CSSRadialGradientValue::setSizingBehavior):
(WebCore::CSSRadialGradientValue::setEndHorizontalSize):
(WebCore::CSSRadialGradientValue::setEndVerticalSize):
- css/CSSGroupingRule.cpp:
(WebCore::CSSGroupingRule::item):
(WebCore::CSSGroupingRule::cssRules):
- css/CSSKeyframesRule.cpp:
(WebCore::CSSKeyframesRule::cssRules):
- css/CSSParser.cpp:
(WebCore::CSSParser::addProperty):
(WebCore::CSSParser::rollbackLastProperties):
(WebCore::CSSParser::parseDashboardRegions):
(WebCore::CSSParser::parseClipShape):
(WebCore::CSSParser::parseBasicShapeCircle):
(WebCore::BorderImageParseContext::commitWebKitBorderImage):
(WebCore::BorderImageParseContext::commitBorderImage):
(WebCore::BorderImageSliceParseContext::commitBorderImageSlice):
(WebCore::BorderImageQuadParseContext::commitBorderImageQuad):
(WebCore::CSSParser::parseDeprecatedRadialGradient):
(WebCore::CSSParser::parseRadialGradient):
- css/CSSParser.h:
(WebCore::cssyylex):
- css/CSSPrimitiveValue.h:
- css/CSSProperty.cpp:
- css/CSSProperty.h:
(WebCore::CSSProperty::CSSProperty):
- css/CSSRule.h:
- css/CSSRuleList.h:
- css/CSSSegmentedFontFace.h:
- css/Counter.h:
(WebCore::Counter::create):
(WebCore::Counter::identifier):
(WebCore::Counter::listStyleIdent):
(WebCore::Counter::setIdentifier):
(WebCore::Counter::setListStyle):
(WebCore::Counter::setSeparator):
(WebCore::Counter::equals):
(WebCore::Counter::cloneForCSSOM):
(WebCore::Counter::Counter):
- css/Pair.h:
- css/Rect.h:
(WebCore::RectBase::bottom):
(WebCore::RectBase::left):
(WebCore::RectBase::setTop):
(WebCore::RectBase::setRight):
(WebCore::RectBase::setBottom):
(WebCore::RectBase::setLeft):
(WebCore::RectBase::equals):
- css/SVGCSSComputedStyleDeclaration.cpp:
(WebCore::strokeDashArrayToCSSValueList):
(WebCore::ComputedStyleExtractor::adjustSVGPaintForCurrentColor):
- css/StyleBuilderConverter.h:
(WebCore::StyleBuilderConverter::convertClipPath):
(WebCore::StyleBuilderConverter::convertShapeValue):
- css/StyleProperties.cpp:
(WebCore::StyleProperties::borderPropertyValue):
(WebCore::StyleProperties::getPropertyCSSValue):
(WebCore::StyleProperties::getPropertyCSSValueInternal):
(WebCore::MutableStyleProperties::setCustomProperty):
(WebCore::MutableStyleProperties::setProperty):
- css/StyleProperties.h:
(WebCore::StyleProperties::isEmpty):
(isType):
- css/StylePropertyShorthand.cpp:
- css/StylePropertyShorthand.h:
(WebCore::StylePropertyShorthand::StylePropertyShorthand):
(WebCore::StylePropertyShorthand::id):
- css/StyleResolver.cpp:
(WebCore::StyleResolver::appendAuthorStyleSheets):
(WebCore::StyleResolver::addKeyframeStyle):
(WebCore::StyleResolver::~StyleResolver):
(WebCore::StyleResolver::resolvedVariableValue):
(WebCore::StyleResolver::styleImage):
(WebCore::StyleResolver::cachedOrPendingFromValue):
(WebCore::StyleResolver::generatedOrPendingFromValue):
(WebCore::StyleResolver::createFilterOperations):
(WebCore::StyleResolver::loadPendingImage):
- css/StyleResolver.h:
(WebCore::StyleResolver::hasViewportDependentMediaQueries):
(WebCore::StyleResolver::state):
(WebCore::checkRegionSelector):
- css/StyleSheetList.h:
- css/WebKitCSSFilterValue.cpp:
- css/WebKitCSSFilterValue.h:
- css/WebKitCSSTransformValue.cpp:
- css/WebKitCSSTransformValue.h:
- rendering/shapes/Shape.cpp:
Source/WebKit2:
- UIProcess/Cocoa/WebViewImpl.mm:
- 4:08 PM Changeset in webkit [201112] by
-
- 1 copy in tags/Safari-601.1.46.143
New tag.
- 4:01 PM Changeset in webkit [201111] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Checkbox disappears when unchecking CSS property with value containing a semicolon
https://bugs.webkit.org/show_bug.cgi?id=157862
<rdar://problem/16214480>
Reviewed by Timothy Hatcher.
- UserInterface/Views/CSSStyleDeclarationTextEditor.js:
(WebInspector.CSSStyleDeclarationTextEditor.prototype._createCommentedCheckboxMarker):
Modify regex to match CSS properties with url() and quoted values,
which can contain semicolons.
- 3:52 PM Changeset in webkit [201110] by
-
- 3 edits in trunk/Source/WebKit2
Disable default user gesture requirement for audio playback on Mac
https://bugs.webkit.org/show_bug.cgi?id=157820
Reviewed by Sam Weinig.
Disable the WebPreferences and matching WKWebViewConfiguration.mediaTypesRequiringUserActionForPlayback
settings on Mac (and other non-iOS ports).
- Shared/WebPreferencesDefinitions.h:
- UIProcess/API/Cocoa/WKWebViewConfiguration.mm:
(-[WKWebViewConfiguration init]):
- 3:49 PM Changeset in webkit [201109] by
-
- 3 edits2 adds in trunk
webkitEnterFullscreen() does not require a user gesture when RequireUserGestureForAudioRateChange is set.
https://bugs.webkit.org/show_bug.cgi?id=157803
Reviewed by Eric Carlson.
Source/WebCore:
Test: media/video-play-audio-require-user-gesture.html
Refactor the setting of restrictions in the HTMLMediaElement constructor, and in so doing, only
relax the RequireUserGestureForFullscreen restriction if both videoPlaybackRequiresUserGesture()
and audioPlaybackRequiresUserGesture() settings are not set.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::HTMLMediaElement):
LayoutTests:
- media/video-play-audio-require-user-gesture-expected.txt: Added.
- media/video-play-audio-require-user-gesture.html: Added.
- 3:45 PM Changeset in webkit [201108] by
-
- 2 edits in trunk/Source/WebKit2
Build fix when not using CredentialStorage with NetworkSession.
- NetworkProcess/cocoa/NetworkSessionCocoa.mm:
(WebKit::NetworkSession::clearCredentials):
- 3:40 PM Changeset in webkit [201107] by
-
- 2 edits in trunk/Source/WebKit2
Fix null-deref crash sporadically seen after http://trac.webkit.org/changeset/201098
No review.
- DatabaseProcess/DatabaseProcess.cpp:
(WebKit::DatabaseProcess::deleteWebsiteData): Don't access m_idbServer directly, as calling
the idbServer() accessor is how you actually get your IDBServer created for you.
- 3:40 PM Changeset in webkit [201106] by
-
- 2 edits in trunk/Source/WebCore
Playback session sends audio and text track lists when media does not have audio or text tracks.
https://bugs.webkit.org/show_bug.cgi?id=157865
<rdar://problem/25992750>
Reviewed by Beth Dakin.
Only send across the CaptionUserPreferences-generated list of audio and text tracks if those
text tracks exist in the first place. This matches the behavior of the built-in controls.
- platform/cocoa/WebPlaybackSessionModelMediaElement.mm:
(WebPlaybackSessionModelMediaElement::updateLegibleOptions):
- 3:36 PM Changeset in webkit [201105] by
-
- 4 edits1 add in trunk
r199812 broke test262
https://bugs.webkit.org/show_bug.cgi?id=157595
Reviewed by Filip Pizlo.
Source/JavaScriptCore:
Added a reasonable limit to the size of the match result array to catch possible
infinite loops when matching.
Added a new tests that creates an infinite loop in RegExp.prototype.[Symbol.match]
by creating a subclass of RegExp where the base RegExp's global flag is false and
the subclass overrides .global with a getter that always returns true.
- builtins/RegExpPrototype.js:
(match):
- tests/stress/regress-157595.js: Added.
(MyRegExp):
(MyRegExp.prototype.get global):
(test):
(catch):
Tools:
Added a new run type, runOneLargeHeap, for tests that use a large amount of memory.
This run type will not run with the --memory-limited option. Without that option,
we'll only the default test variant.
- Scripts/run-jsc-stress-tests:
- 3:27 PM Changeset in webkit [201104] by
-
- 6 edits in trunk/Source/WebCore
Clean up / Modernize TextAutoSizingValue::adjustNodeSizes()
https://bugs.webkit.org/show_bug.cgi?id=157861
Reviewed by Alex Christensen.
Clean up / Modernize TextAutoSizingValue::adjustNodeSizes(), and
use tighter typing for autosizing nodes.
- dom/Document.cpp:
(WebCore::Document::addAutoSizingNode):
- dom/Document.h:
- rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::adjustComputedFontSizes):
- rendering/TextAutoSizing.cpp:
(WebCore::TextAutoSizingValue::addNode):
(WebCore::TextAutoSizingValue::adjustNodeSizes):
(WebCore::TextAutoSizingValue::reset):
- rendering/TextAutoSizing.h:
- 3:25 PM Changeset in webkit [201103] by
-
- 2 edits in trunk/Source/WebCore
Remove logging inadvertently committed in r201090.
- css/CSSParser.cpp:
(WebCore::CSSParserContext::CSSParserContext): Deleted.
- 3:16 PM Changeset in webkit [201102] by
-
- 3 edits in trunk/Source/WebInspectorUI
Web Inspector: ugly gaps in Call Trees data grid when expanding more than one level
https://bugs.webkit.org/show_bug.cgi?id=157829
<rdar://problem/26339922>
Reviewed by Timothy Hatcher.
Make a more specific CSS selector to avoid style conflicts.
- UserInterface/Views/DataGrid.css:
(.data-grid:not(.variable-height-rows) > .data-container > table.data > tbody > tr > td > div): Deleted.
(.data-grid:not(.variable-height-rows) > .data-container > table.data > tbody > tr > td > .cell-content):
- UserInterface/Views/DataGrid.js:
(WebInspector.DataGridNode.prototype.createCell):
- 2:50 PM Changeset in webkit [201101] by
-
- 13 edits in trunk/Source
Web Inspector: InspectorFrontendAPI.setTimelineProfilingEnabled should not implicitly show Timelines tab
https://bugs.webkit.org/show_bug.cgi?id=157846
Reviewed by Timothy Hatcher.
Source/WebInspectorUI:
Currently, if the Web Inspector opens for an in-progress or finished automation session,
it will always show the Timelines tab, disregarding any previous user view state. This
is annoying and is a bad user experience when trying to debug the same test repeatedly.
- UserInterface/Protocol/InspectorFrontendAPI.js:
(InspectorFrontendAPI.setTimelineProfilingEnabled): Don't implicitly show Timelines tab.
(InspectorFrontendAPI.showTimelines): Added. This is called explicitly when desired.
Source/WebKit2:
Add a separate ShowTimelines message to WebInspector and WebInspectorUI. Have the
start/stop profiling methods in public APIs explicitly call showTimelines() rather than
relying on InspectorFrontendAPI to do it.
- UIProcess/API/C/WKInspector.cpp:
(WKInspectorTogglePageProfiling):
- UIProcess/WebInspectorProxy.cpp:
(WebKit::WebInspectorProxy::showTimelines):
- UIProcess/WebInspectorProxy.h:
- WebProcess/InjectedBundle/API/c/WKBundleInspector.cpp:
(WKBundleInspectorSetPageProfilingEnabled):
- WebProcess/WebPage/WebInspector.cpp:
(WebKit::WebInspector::showTimelines):
- WebProcess/WebPage/WebInspector.h:
- WebProcess/WebPage/WebInspector.messages.in:
- WebProcess/WebPage/WebInspectorUI.cpp:
(WebKit::WebInspectorUI::showTimelines):
- WebProcess/WebPage/WebInspectorUI.h:
- WebProcess/WebPage/WebInspectorUI.messages.in:
- 2:36 PM Changeset in webkit [201100] by
-
- 2 edits in trunk/LayoutTests
REGRESSION (r186569): media/restore-from-page-cache.html is very flaky
https://bugs.webkit.org/show_bug.cgi?id=147254
Unreviewed. Removing the flaky test expectation since the test is almost always passing now.
- platform/mac/TestExpectations:
- 2:04 PM Changeset in webkit [201099] by
-
- 3 edits in trunk/Source/WebInspectorUI
Web Inspector: DebuggerSidebarPanel doesn't need to help manage temporarily disabling breakpoints while capturing
https://bugs.webkit.org/show_bug.cgi?id=157854
Reviewed by Timothy Hatcher.
Duplicate the event listeners in DebuggerManager and move non-view-related
state updates out of DebuggerSidebarPanel's listeners into DebuggerManager's listeners.
This allows a test to exercise the temporary-disablement code paths during capturing.
- UserInterface/Controllers/DebuggerManager.js:
(WebInspector.DebuggerManager.prototype.get breakpointsDisabledTemporarily):
Use this to make the code a bit more readable.
(WebInspector.DebuggerManager.prototype._startDisablingBreakpointsTemporarily):
(WebInspector.DebuggerManager.prototype._stopDisablingBreakpointsTemporarily):
(WebInspector.DebuggerManager.prototype.startDisablingBreakpointsTemporarily): Deleted.
(WebInspector.DebuggerManager.prototype.stopDisablingBreakpointsTemporarily): Deleted.
Make this private since it's not used by other classes anymore.
(WebInspector.DebuggerManager.prototype._timelineCapturingWillStart): Added.
(WebInspector.DebuggerManager.prototype._timelineCapturingStopped): Added.
- UserInterface/Views/DebuggerSidebarPanel.js:
(WebInspector.DebuggerSidebarPanel.prototype._timelineRecordingWillStart): Deleted.
(WebInspector.DebuggerSidebarPanel.prototype._timelineRecordingStopped): Deleted.
(WebInspector.DebuggerSidebarPanel.prototype._timelineCapturingWillStart): Added.
(WebInspector.DebuggerSidebarPanel.prototype._timelineCapturingStopped): Added.
Make the listener names consistent with TimelineManager: timelineCapturing{WillStart,Stopped}.
- 1:42 PM Changeset in webkit [201098] by
-
- 35 edits3 adds in trunk
Modern IDB: Add support for server side closing of open database connections.
https://bugs.webkit.org/show_bug.cgi?id=157843
Reviewed by Alex Christensen.
Source/WebCore:
Test: storage/indexeddb/modern/handle-user-delete.html
In order to support deleting IndexedDB databases, the IDB server needs the ability to
"immediately" close a currently open IDB connection.
To do so cleanly, the server has to:
- Error out all requests it knows about
- Abort all transactions it knows about
- Tell the connection that it is being closed
- Wait for the connection to acknowledge that it was closed on the server
And then the client has to:
- Error out all requests it hasn't sent to the server
- Abort all transactions that haven't already been aborted by the server
- Send acknowledgement to the server that it has been closed.
Finally, because the status of a given request might be "in flight" somewhere between the
server and the client, some design assumptions change. This requires reworking some ASSERTS,
null checks, etc.
- Modules/indexeddb/IDBDatabase.cpp:
(WebCore::IDBDatabase::didCloseFromServer): Do the heavy lifting for the immediate close on
the client side.
- Modules/indexeddb/IDBDatabase.h:
- Modules/indexeddb/IDBDatabaseIdentifier.h:
(WebCore::IDBDatabaseIdentifier::isRelatedToOrigin):
- Modules/indexeddb/IDBTransaction.cpp:
(WebCore::IDBTransaction::connectionClosedFromServer): Error out all outstanding operations
and fire the abort error on itself.
- Modules/indexeddb/IDBTransaction.h:
- Modules/indexeddb/client/IDBConnectionProxy.cpp:
(WebCore::IDBClient::IDBConnectionProxy::completeOperation):
(WebCore::IDBClient::IDBConnectionProxy::didCloseFromServer):
(WebCore::IDBClient::IDBConnectionProxy::confirmDidCloseFromServer):
(WebCore::IDBClient::IDBConnectionProxy::forgetActiveOperations):
- Modules/indexeddb/client/IDBConnectionProxy.h:
- Modules/indexeddb/client/IDBConnectionToServer.cpp:
(WebCore::IDBClient::IDBConnectionToServer::didCloseFromServer):
(WebCore::IDBClient::IDBConnectionToServer::confirmDidCloseFromServer):
- Modules/indexeddb/client/IDBConnectionToServer.h:
- Modules/indexeddb/client/IDBConnectionToServerDelegate.h:
- Modules/indexeddb/server/IDBConnectionToClient.cpp:
(WebCore::IDBServer::IDBConnectionToClient::didCloseFromServer):
- Modules/indexeddb/server/IDBConnectionToClient.h:
- Modules/indexeddb/server/IDBConnectionToClientDelegate.h:
- Modules/indexeddb/server/IDBServer.cpp:
(WebCore::IDBServer::IDBServer::confirmDidCloseFromServer):
(WebCore::IDBServer::generateDeleteCallbackID):
(WebCore::IDBServer::IDBServer::closeAndDeleteDatabasesModifiedSince):
(WebCore::IDBServer::IDBServer::closeAndDeleteDatabasesForOrigins):
(WebCore::IDBServer::IDBServer::performCloseAndDeleteDatabasesModifiedSince):
(WebCore::IDBServer::IDBServer::performCloseAndDeleteDatabasesForOrigins):
(WebCore::IDBServer::IDBServer::didPerformCloseAndDeleteDatabases):
- Modules/indexeddb/server/IDBServer.h:
- Modules/indexeddb/server/UniqueIDBDatabase.cpp:
(WebCore::IDBServer::UniqueIDBDatabase::~UniqueIDBDatabase):
(WebCore::IDBServer::UniqueIDBDatabase::openDatabaseConnection):
(WebCore::IDBServer::UniqueIDBDatabase::didDeleteBackingStore):
(WebCore::IDBServer::UniqueIDBDatabase::handleDatabaseOperations):
(WebCore::IDBServer::UniqueIDBDatabase::handleCurrentOperation):
(WebCore::IDBServer::UniqueIDBDatabase::handleDelete):
(WebCore::IDBServer::UniqueIDBDatabase::createObjectStore):
(WebCore::IDBServer::UniqueIDBDatabase::deleteObjectStore):
(WebCore::IDBServer::UniqueIDBDatabase::clearObjectStore):
(WebCore::IDBServer::UniqueIDBDatabase::createIndex):
(WebCore::IDBServer::UniqueIDBDatabase::deleteIndex):
(WebCore::IDBServer::UniqueIDBDatabase::putOrAdd):
(WebCore::IDBServer::UniqueIDBDatabase::getRecord):
(WebCore::IDBServer::UniqueIDBDatabase::getCount):
(WebCore::IDBServer::UniqueIDBDatabase::deleteRecord):
(WebCore::IDBServer::UniqueIDBDatabase::openCursor):
(WebCore::IDBServer::UniqueIDBDatabase::iterateCursor):
(WebCore::IDBServer::UniqueIDBDatabase::commitTransaction):
(WebCore::IDBServer::UniqueIDBDatabase::abortTransaction):
(WebCore::IDBServer::UniqueIDBDatabase::connectionClosedFromClient):
(WebCore::IDBServer::UniqueIDBDatabase::connectionClosedFromServer):
(WebCore::IDBServer::UniqueIDBDatabase::confirmDidCloseFromServer):
(WebCore::IDBServer::UniqueIDBDatabase::enqueueTransaction):
(WebCore::IDBServer::UniqueIDBDatabase::isCurrentlyInUse):
(WebCore::IDBServer::UniqueIDBDatabase::invokeOperationAndTransactionTimer):
(WebCore::IDBServer::UniqueIDBDatabase::operationAndTransactionTimerFired):
(WebCore::IDBServer::UniqueIDBDatabase::activateTransactionInBackingStore):
(WebCore::IDBServer::UniqueIDBDatabase::transactionCompleted):
(WebCore::IDBServer::UniqueIDBDatabase::postDatabaseTask):
(WebCore::IDBServer::UniqueIDBDatabase::postDatabaseTaskReply):
(WebCore::IDBServer::UniqueIDBDatabase::executeNextDatabaseTask):
(WebCore::IDBServer::UniqueIDBDatabase::executeNextDatabaseTaskReply):
(WebCore::IDBServer::UniqueIDBDatabase::doneWithHardClose):
(WebCore::IDBServer::errorOpenDBRequestForUserDelete):
(WebCore::IDBServer::UniqueIDBDatabase::immediateCloseForUserDelete): Do the heavy lifting
for the immediate close on the server side.
(WebCore::IDBServer::UniqueIDBDatabase::performErrorCallback):
(WebCore::IDBServer::UniqueIDBDatabase::performKeyDataCallback):
(WebCore::IDBServer::UniqueIDBDatabase::performGetResultCallback):
(WebCore::IDBServer::UniqueIDBDatabase::performCountCallback):
(WebCore::IDBServer::UniqueIDBDatabase::storeCallback): Deleted.
(WebCore::IDBServer::UniqueIDBDatabase::storeCallbackOrFireError): If the database has been
hard stopped, immediately fire and error for the callback and return a 0-identifier to
reflect this.
- Modules/indexeddb/server/UniqueIDBDatabase.h:
- Modules/indexeddb/server/UniqueIDBDatabaseConnection.cpp:
(WebCore::IDBServer::UniqueIDBDatabaseConnection::confirmDidCloseFromServer):
- Modules/indexeddb/server/UniqueIDBDatabaseConnection.h:
- Modules/indexeddb/shared/IDBError.cpp:
(WebCore::IDBError::toDOMError):
- Modules/indexeddb/shared/IDBError.h:
(WebCore::IDBError::userDeleteError):
- Modules/indexeddb/shared/InProcessIDBServer.cpp:
(WebCore::InProcessIDBServer::didCloseFromServer):
(WebCore::InProcessIDBServer::confirmDidCloseFromServer):
- Modules/indexeddb/shared/InProcessIDBServer.h:
- platform/CrossThreadCopier.cpp:
(WebCore::std::chrono::system_clock::time_point>::copy):
- platform/CrossThreadCopier.h:
Source/WebKit2:
- Implement the required IDB delegate code.
- Make DatabaseProcess::deleteWebsiteData call the right method in IDB server.
- DatabaseProcess/DatabaseProcess.cpp:
(WebKit::DatabaseProcess::deleteWebsiteData):
- DatabaseProcess/IndexedDB/WebIDBConnectionToClient.cpp:
(WebKit::WebIDBConnectionToClient::didGetRecord):
(WebKit::WebIDBConnectionToClient::didCloseFromServer):
(WebKit::WebIDBConnectionToClient::confirmDidCloseFromServer):
- DatabaseProcess/IndexedDB/WebIDBConnectionToClient.h:
- DatabaseProcess/IndexedDB/WebIDBConnectionToClient.messages.in:
- WebProcess/Databases/IndexedDB/WebIDBConnectionToServer.cpp:
(WebKit::WebIDBConnectionToServer::confirmDidCloseFromServer):
(WebKit::WebIDBConnectionToServer::didStartTransaction):
(WebKit::WebIDBConnectionToServer::didCloseFromServer):
- WebProcess/Databases/IndexedDB/WebIDBConnectionToServer.h:
- WebProcess/Databases/IndexedDB/WebIDBConnectionToServer.messages.in:
LayoutTests:
- storage/indexeddb/modern/handle-user-delete-expected.txt: Added.
- storage/indexeddb/modern/handle-user-delete.html: Added.
- storage/indexeddb/modern/resources/handle-user-delete.js: Added.
- 1:25 PM WebKitGTK/2.12.x edited by
- (diff)
- 1:21 PM Changeset in webkit [201097] by
-
- 2 edits in trunk/Websites/bugs.webkit.org
CVE-2016-2803: [SECURITY] XSS vulnerability in dependency graphs via bug summary
<https://bugzilla.mozilla.org/show_bug.cgi?id=1253263>
Merge Bugzilla upstream master dd61903154fd363fb4e763d60aa155a507c2c3fc.
- showdependencygraph.cgi:
(CreateImagemap): Fix XSS vulnerability.
- 1:20 PM WebKitGTK/2.12.x edited by
- (diff)
- 1:01 PM Changeset in webkit [201096] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Improve console.takeHeapSnapshot documentation in console
https://bugs.webkit.org/show_bug.cgi?id=157853
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-05-18
Reviewed by Timothy Hatcher.
- UserInterface/Models/NativeFunctionParameters.js:
Mention optional label argument.
- 12:35 PM Changeset in webkit [201095] by
-
- 5 edits in trunk/Source
Versioning.
- 12:34 PM Changeset in webkit [201094] by
-
- 1 copy in tags/Safari-602.1.33
New tag.
- 12:32 PM Changeset in webkit [201093] by
-
- 2 edits in trunk/PerformanceTests
Make Animometer work in all browsers
https://bugs.webkit.org/show_bug.cgi?id=157855
rdar://problem/26338521
Reviewed by Jon Lee.
- Animometer/resources/runner/logo.svg: Use a symbol instead
of putting the id on the root svg. This works in all browsers.
- 12:29 PM Changeset in webkit [201092] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: race between frontend and backend both starting timeline recordings causes console assert
https://bugs.webkit.org/show_bug.cgi?id=157850
<rdar://problem/26349229>
Reviewed by Joseph Pecoraro.
If TimelineManager has created a fresh recording and the Timeline.autoCaptureStarted
event comes before Timeline.recordingStarted, then the manager will try to start the
same recording twice. In this scenario, the manager should just wait until the
Timeline.recordingStarted event comes, since it causes TimelineMangare to set up
the isCapturing flag and other state.
- UserInterface/Controllers/TimelineManager.js:
(WebInspector.TimelineManager):
(WebInspector.TimelineManager.prototype.startCapturing):
(WebInspector.TimelineManager.prototype.capturingStarted):
(WebInspector.TimelineManager.prototype.autoCaptureStarted):
Add a new flag, this._waitingForCapturingStartedEvent. If true, don't start the
recording in response to this event.
- 12:10 PM Changeset in webkit [201091] by
-
- 4 edits in trunk/LayoutTests
[OS X] Update platform/mac/fast/text/sticky-typesetting-features.html
https://bugs.webkit.org/show_bug.cgi?id=157851
Reviewed by Simon Fraser.
Kerning and ligatures are enabled by default now.
- platform/mac/fast/text/sticky-typesetting-features-expected.png:
- platform/mac/fast/text/sticky-typesetting-features-expected.txt:
- platform/mac/fast/text/sticky-typesetting-features.html:
- 12:06 PM Changeset in webkit [201090] by
-
- 14 edits3 adds in trunk
REGRESSION (r200534) Command-+ no longer zooms pages
https://bugs.webkit.org/show_bug.cgi?id=157826
rdar://problem/26334636
Reviewed by Dean Jackson.
Source/WebCore:
When text autosizing was enabled on Mac, we started to parse and respect
-webkit-text-size-adjust. Fix by cutting this off in CSSParser if the feature
is disabled.
Also fix InternalSettings to reset page and text zoom, since WebKit1 aliases
the zoom levels causing DRT to fail to reset them between tests.
Test: fast/text-autosizing/mac/text-size-adjust-text-zoom.html
- css/CSSParser.cpp:
(WebCore::CSSParserContext::CSSParserContext):
(WebCore::isValidKeywordPropertyAndValue):
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::isTextAutosizingEnabled):
- css/CSSParser.h:
- css/CSSParserMode.h:
- testing/InternalSettings.cpp:
(WebCore::InternalSettings::resetToConsistentState):
Tools:
- DumpRenderTree/mac/DumpRenderTree.mm:
(resetWebPreferencesToConsistentValues): Remove ENABLE() #ifdefs that do nothing (see http://webkit.org/b/157828).
LayoutTests:
Need to call internals.settings.setTextAutosizingEnabled(true) earlier in some tests.
- fast/text-autosizing/ios/line-height-text-autosizing.html:
- fast/text-autosizing/ios/percent-adjust-length-line-height.html:
- fast/text-autosizing/ios/percent-adjust-number-line-height.html:
- fast/text-autosizing/ios/percent-adjust-percent-line-height.html:
- fast/text-autosizing/mac/text-size-adjust-text-zoom-expected.html: Added.
- fast/text-autosizing/mac/text-size-adjust-text-zoom.html: Added.
- platform/mac-wk2/TestExpectations:
- platform/mac/TestExpectations:
- 12:03 PM Changeset in webkit [201089] by
-
- 2 edits in branches/safari-601.1.46-branch/Source/JavaScriptCore
Merge patch for rdar://problem/26350121.
- 11:59 AM Changeset in webkit [201088] by
-
- 2 edits in trunk/Source/WebCore
markAllDescendantsWithFloatsForLayout should not drill into blocks with
inline children. It was sufficient to mark ourselves as needing layout.
https://bugs.webkit.org/show_bug.cgi?id=157845
Reviewed by Simon Fraser.
- rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::markAllDescendantsWithFloatsForLayout):
- 11:57 AM Changeset in webkit [201087] by
-
- 16 edits in trunk
[GTK] accessibility/meter-element.html is failing
https://bugs.webkit.org/show_bug.cgi?id=115633
Reviewed by Chris Fleizach.
Source/WebCore:
The meter's value description should be exposed in the same fashion
as (we should have been exposing) aria-valuetext, namely through the
"valuetext" AtkObject attribute. This exposure is now in place. Also
implement AccessibilityProgressIndicator::valueDescription() so that
the ports do not have to special-case meter in the platform wrappers.
Map the meter element to the correct role (ATK_ROLE_LEVEL_BAR), and
ignore a previously-included accessible object resulting from the
use of the title attribute on a meter. Finally, do not expose the
meter's title as the accessible name because the HTML spec suggests
authors can supply the numeric unit as the value of title.
No new test file as the failure was identified by meter-element.html.
Seven new test cases were added for additional coverage. Also updated
the ATK expectations for spinbutton-value.html to reflect that we are now
exposing the value of aria-valuetext.
- accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::helpText):
(WebCore::AccessibilityNodeObject::accessibilityDescriptionForChildren):
(WebCore::AccessibilityNodeObject::visibleText):
- accessibility/AccessibilityNodeObject.h:
- accessibility/AccessibilityProgressIndicator.cpp:
(WebCore::AccessibilityProgressIndicator::valueDescription):
- accessibility/AccessibilityProgressIndicator.h:
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::computeAccessibilityIsIgnored):
- accessibility/atk/WebKitAccessibleWrapperAtk.cpp:
(webkitAccessibleGetAttributes):
(atkRole):
- accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):
Tools:
Implement AccessibilityUIElement::valueDescription() and add mapping
from ATK_ROLE_LEVEL_BAR to AXProgressIndicator.
- WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
(WTR::AccessibilityUIElement::valueDescription):
LayoutTests:
Seven new test cases were added to meter-element.html for additional
coverage. Also updated the ATK expectations for spinbutton-value.html
to reflect that we are now exposing the value of aria-valuetext.
- accessibility/meter-element.html: New test cases added.
- platform/gtk/TestExpectations: Unskip the previously-failing test.
- platform/gtk/accessibility/meter-element-expected.txt: Updated.
- platform/gtk/accessibility/spinbutton-value-expected.txt: Updated.
- platform/mac/accessibility/meter-element-expected.txt: Updated.
- 11:32 AM Changeset in webkit [201086] by
-
- 7 edits in trunk/Source/WebCore
Allow RenderStyles marked unique in matched properties cache
https://bugs.webkit.org/show_bug.cgi?id=157844
Reviewed by Andreas Kling.
Depending on content this can improve matched properties cache hit rate quite a bit and so reduce
time spent building styles.
- css/StyleBuilderCustom.h:
(WebCore::StyleBuilderCustom::applyValueContent):
Set the attr bit on render style.
- css/StyleResolver.cpp:
(WebCore::isCacheableInMatchedPropertiesCache):
Allow caching of styles marked "unique". It only means that they are not shareable by style
sharing code because there were some complex selectors in the rules used for building them. It
doesn't affect matched properties cache the cache how the properties were resolved.
We still need to test against "content: attr()" as that makes the style depend on the element
being matched. It now has a separate bit in RenderStyle.
- rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::setHasAttrContent):
Bit for "content: attr()". It also sets unique() to keep style sharing code happy.
(WebCore::requireTransformOrigin):
- rendering/style/RenderStyle.h:
(WebCore::RenderStyle::hasAttrContent):
- rendering/style/StyleRareNonInheritedData.cpp:
(WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
(WebCore::StyleRareNonInheritedData::operator==):
- rendering/style/StyleRareNonInheritedData.h:
- 10:46 AM Changeset in webkit [201085] by
-
- 5 edits4 adds in trunk/Source/JavaScriptCore
[ES6] Namespace object re-export should be handled as local export
https://bugs.webkit.org/show_bug.cgi?id=157806
Reviewed by Mark Lam.
We align the implementation of ExportEntry to the spec; remove Type::Namespace.
This Type::Namespace is used for re-exported namespace object binding. For example,
import * as namespace from "namespace.js"
export { namespace }
In the above case, we used ExportEntry(Type::Namespace). In this patch, we drop this
and use normal local export (Type::Local) instead because namespace object actually has
the local binding in the above module environment. And this handling strictly meets the
spec (Sec 15.2.1.16.1 step 11-a-ii-2-b).
And we also clean up the ExportEntry implementation; dropping unnecessary information.
This change fixes the test262/test/language/module-code/instn-star-equality.js crash.
- parser/ModuleAnalyzer.cpp:
(JSC::ModuleAnalyzer::exportVariable):
- runtime/JSModuleRecord.cpp:
(JSC::getExportedNames):
(JSC::JSModuleRecord::dump): Deleted.
- runtime/JSModuleRecord.h:
- tests/modules/namespace-re-export.js: Added.
- tests/modules/namespace-re-export/namespace-re-export-fixture.js: Added.
- tests/modules/namespace-re-export/namespace-re-export.js: Added.
- tests/modules/resources/assert.js:
(export.shouldNotBe):
- 10:25 AM Changeset in webkit [201084] by
-
- 2 edits in trunk/Source/WebCore
Fix the allinone-build on Linux in Source/WebCore/html/HTMLElementsAllInOne.cpp
https://bugs.webkit.org/show_bug.cgi?id=157800
Reviewed by Alex Christensen.
- html/HTMLElementsAllInOne.cpp:
- 10:19 AM Changeset in webkit [201083] by
-
- 2 edits in trunk/LayoutTests
Rebaseline inspector/debugger/command-line-api-exception.html after r201080
Unreviewed test gardening.
- inspector/debugger/command-line-api-exception-expected.txt:
- 9:33 AM Changeset in webkit [201082] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: REGRESSION(r197488): Incorrect start time in Rendering Frames timeline grid
https://bugs.webkit.org/show_bug.cgi?id=157840
<rdar://problem/26344937>
Reviewed by Brian Burg.
- UserInterface/Views/TimelineRecordingContentView.js:
(WebInspector.TimelineRecordingContentView.prototype._updateTimes):
The Rendering Frames timeline view needs a valid zero time.
(WebInspector.TimelineRecordingContentView.prototype._timeRangeSelectionChanged):
Adjust ruler selection path component values by the zero time unless
the current view is the Rendering Frames timeline view.
- 9:30 AM Changeset in webkit [201081] by
-
- 18 edits in trunk
Modern IDB: Make TestRunner.clearAllDatabases also delete IndexedDB databases (once doing so is supported).
https://bugs.webkit.org/show_bug.cgi?id=157823
Reviewed by Alex Christensen.
Source/WebCore:
No new tests (No current behavior change, will be tested with b/157626's resolution).
- Modules/indexeddb/server/IDBServer.cpp:
(WebCore::IDBServer::IDBServer::closeAndDeleteDatabasesModifiedSince): Stub this out for now.
- Modules/indexeddb/server/IDBServer.h:
- Modules/indexeddb/shared/InProcessIDBServer.h:
Source/WebKit:
- Storage/WebDatabaseProvider.cpp:
(WebDatabaseProvider::deleteAllDatabases):
- Storage/WebDatabaseProvider.h:
Source/WebKit/mac:
- Storage/WebDatabaseManager.mm:
(-[WebDatabaseManager deleteAllIndexedDatabases]):
- Storage/WebDatabaseManagerPrivate.h:
Source/WebKit2:
- CMakeLists.txt:
- UIProcess/API/C/WKWebsiteDataStoreRef.cpp:
(WKWebsiteDataStoreRemoveAllIndexedDatabases):
- UIProcess/API/C/WKWebsiteDataStoreRef.h:
Tools:
- DumpRenderTree/mac/TestRunnerMac.mm:
(TestRunner::clearAllDatabases):
- WebKitTestRunner/InjectedBundle/TestRunner.cpp:
(WTR::TestRunner::clearAllDatabases):
- WebKitTestRunner/TestInvocation.cpp:
(WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
- 8:22 AM Changeset in webkit [201080] by
-
- 51 edits3 deletes in trunk
Sync DOM exception types with WebIDL and update promise rejections
https://bugs.webkit.org/show_bug.cgi?id=157792
Reviewed by Eric Carlson.
Source/WebCore:
Updating ExceptionCode with WebIDL latest exception types.
Updating promise rejection code to use those types as per the latest specifications.
Updating getUserMedia error handling by removing NavigatorUserMediaError which no long exists.
Covered by rebased tests.
- CMakeLists.txt:
- DerivedSources.cpp:
- DerivedSources.make:
- Modules/mediastream/MediaDevices.h:
- Modules/mediastream/MediaEndpointPeerConnection.cpp:
(WebCore::MediaEndpointPeerConnection::createAnswer):
(WebCore::MediaEndpointPeerConnection::setLocalDescription):
(WebCore::MediaEndpointPeerConnection::setRemoteDescription):
(WebCore::MediaEndpointPeerConnection::addIceCandidate):
(WebCore::MediaEndpointPeerConnection::getStats):
(WebCore::MediaEndpointPeerConnection::replaceTrack):
- Modules/mediastream/NavigatorUserMediaError.cpp: Removed.
- Modules/mediastream/NavigatorUserMediaError.h: Removed.
- Modules/mediastream/NavigatorUserMediaError.idl: Removed.
- Modules/mediastream/RTCPeerConnection.cpp:
(WebCore::RTCPeerConnection::queuedCreateOffer):
(WebCore::RTCPeerConnection::queuedCreateAnswer):
(WebCore::RTCPeerConnection::queuedSetLocalDescription):
(WebCore::RTCPeerConnection::queuedSetRemoteDescription):
(WebCore::RTCPeerConnection::queuedAddIceCandidate):
- Modules/mediastream/RTCRtpSender.cpp:
(WebCore::RTCRtpSender::replaceTrack):
- Modules/mediastream/UserMediaRequest.cpp:
(WebCore::UserMediaRequest::failedToCreateStreamWithConstraintsError):
(WebCore::UserMediaRequest::failedToCreateStreamWithPermissionError):
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSDOMBinding.cpp:
(WebCore::createDOMException):
- bindings/js/JSDOMBinding.h:
- bindings/js/JSDOMPromise.cpp:
(WebCore::DeferredWrapper::reject):
- bindings/js/JSDOMPromise.h:
(WebCore::DeferredWrapper::reject):
(WebCore::DOMPromise::reject):
- css/FontFaceSet.cpp:
(WebCore::FontFaceSet::load):
(WebCore::FontFaceSet::faceFinished):
- dom/DOMCoreException.cpp:
- dom/ExceptionCode.h:
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::play):
LayoutTests:
- fast/dom/insertAdjacentHTML-DocumentFragment-crash-expected.txt:
- fast/inspector-support/uncaught-dom1-exception-expected.txt:
- fast/inspector-support/uncaught-dom3-exception-expected.txt:
- fast/inspector-support/uncaught-dom8-exception-expected.txt:
- fast/mediastream/MediaDevices-getUserMedia-expected.txt:
- fast/mediastream/MediaDevices-getUserMedia.html:
- fast/mediastream/delayed-permission-denied-expected.txt:
- fast/mediastream/delayed-permission-denied.html:
- fast/mediastream/error-expected.txt:
- fast/mediastream/error.html:
- fast/mediastream/getusermedia-expected.txt:
- fast/mediastream/mock-media-source-expected.txt:
- fast/regions/selection/crash-deselect-expected.txt:
- http/tests/media/media-stream/disconnected-frame-permission-denied-expected.txt:
- http/tests/media/media-stream/disconnected-frame-permission-denied.html:
- inspector/debugger/regress-133182-expected.txt:
- inspector/debugger/setPauseOnExceptions-all-expected.txt:
- inspector/debugger/setPauseOnExceptions-none-expected.txt:
- inspector/debugger/setPauseOnExceptions-uncaught-expected.txt:
- platform/efl/fast/dynamic/015-expected.txt:
- platform/gtk/fast/dynamic/015-expected.txt:
- platform/ios-simulator/fast/dynamic/015-expected.txt:
- platform/ios-simulator-wk2/editing/selection/caret-ltr-2-expected.txt:
- platform/ios-simulator-wk2/editing/selection/caret-ltr-2-left-expected.txt:
- platform/ios-simulator-wk2/editing/selection/caret-ltr-expected.txt:
- platform/ios-simulator-wk2/editing/selection/caret-ltr-right-expected.txt:
- platform/ios-simulator-wk2/editing/selection/caret-rtl-2-expected.txt:
- platform/ios-simulator-wk2/editing/selection/caret-rtl-2-left-expected.txt:
- platform/ios-simulator-wk2/editing/selection/caret-rtl-expected.txt:
- platform/ios-simulator-wk2/editing/selection/caret-rtl-right-expected.txt:
- platform/mac/fast/dynamic/015-expected.txt:
- platform/win/fast/dynamic/015-expected.txt:
- 7:52 AM Changeset in webkit [201079] by
-
- 4 edits in trunk/Source/WebKit2
REGRESSION(r200959): "Start Timeline Recording" menu item doesn't start recording
https://bugs.webkit.org/show_bug.cgi?id=157821
<rdar://problem/26335429>
Reviewed by Timothy Hatcher.
In r200959, WebInspectorProxy started sending start/stop profiling
messages directly to the frontend process to avoid the inspected page
process from implicitly showing the frontend. To compensate, the WebKit
API layer was changed to call show() in togglePageProfiling().
Unfortunately, this fix was not quite right, because the ordering of
the Show and StartPageProfiling messages is undefined. The latter has to bounce
from UI to inspected to inspector processes, so the frontend may try
to start profiling before the frontend is shown, causing it to be ignored.
This patch takes a different approach: just remove all implicit show()
calls in the inspected page processes, and bounce both the Show and
StartPageProfiling messages through the inspected page process to ensure
they are handled in order by the frontend process.
- UIProcess/WebInspectorProxy.cpp:
(WebKit::WebInspectorProxy::togglePageProfiling):
Revert to sending to the inspected page process.
- WebProcess/InjectedBundle/API/c/WKBundleInspector.cpp:
(WKBundleInspectorSetPageProfilingEnabled):
Add a call to show() now that the implementation doesn't do it implicitly.
- WebProcess/WebPage/WebInspector.cpp:
(WebKit::WebInspector::startPageProfiling):
(WebKit::WebInspector::stopPageProfiling):
Don't implicitly show the inspector. These methods are only called
through the WKBundleInspector API and via IPC from WebInspectorProxy.
- 7:48 AM Changeset in webkit [201078] by
-
- 2 edits in trunk/Source/WebCore
[GStreamer] webaudio crash on ARM platforms
https://bugs.webkit.org/show_bug.cgi?id=157838
Reviewed by Michael Catanzaro.
- platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp:
(webKitWebAudioSrcConstructed): Explicitely cast the integer value
of the max-bytes property to guint64 which is the expected type of
this property. The compiler can't guess this on its own.
- 7:39 AM Changeset in webkit [201077] by
-
- 3 edits in trunk/Source/WebCore
[GStreamer] webaudio playback improvements
https://bugs.webkit.org/show_bug.cgi?id=155228
Reviewed by Michael Catanzaro.
- platform/audio/gstreamer/AudioDestinationGStreamer.cpp:
(WebCore::autoAudioSinkChildAddedCallback): Fix sink buffer-time
to 100ms to reduce playback latency.
(WebCore::AudioDestinationGStreamer::AudioDestinationGStreamer):
Connect to child-added signal of autoaudiosink to be notified when
a real sink is added into the bin.
- platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp:
(webKitWebAudioSrcConstructed): Fine-tune blocksize of appsrc
according to the buffer size already configured on the src element.
- 7:30 AM Changeset in webkit [201076] by
-
- 5 edits in trunk
[GStreamer] Use FakeSink to get a decoded texture from a pipeline
https://bugs.webkit.org/show_bug.cgi?id=153641
Reviewed by Philippe Normand.
.:
- Source/cmake/FindGStreamer.cmake: Bump gst-gl version to 1.8.0
Source/WebCore:
Relying on GstGLImageSink to use GStreamerGL brings a lot of overheads such as
window handling, context switching and overlay handling which are not needed in
our case.
This patch replaces GstGLImageSink with a custom GstBin which has a
GstGLUpload, GstGLColorConvert, and GstFakeSink.
GstFakeSink sends decoded frames via handoff signal from the vqueue thread of
GStreamer. Previously, GstGLImageSink passes frames through GStreamer's GL
thread, which adds additional overhead.
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:
(WebCore::GstVideoFrameHolder::~GstVideoFrameHolder): Modified to
unmap GstVideoFrame without async call. GstGLMemory will unmap itself
in gl-thread.
(WebCore::MediaPlayerPrivateGStreamerBase::drawCallback):
(WebCore::MediaPlayerPrivateGStreamerBase::createVideoSinkGL): Split
out creating of the gst-gl video sink into the separte method.
(WebCore::MediaPlayerPrivateGStreamerBase::paint): Remove assertion
for the threaded compositor. It can be called by focusing event.
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.h:
- 7:21 AM Changeset in webkit [201075] by
-
- 2 edits in trunk/Source/WebCore
Resolve !important properties from different shadow trees in a single pass.
https://bugs.webkit.org/show_bug.cgi?id=157836
Reviewed by Andreas Kling.
- css/StyleResolver.cpp:
(WebCore::StyleResolver::CascadedProperties::addImportantMatches):
Instead of doing multiple passes over increasing tree context ordinals collect matches with
non-zero ordinals to a vector and sort it to ascending order.
- 6:30 AM WebKitGTK/2.12.x edited by
- (diff)
- 2:15 AM Changeset in webkit [201074] by
-
- 2 edits in trunk/Source/WebCore
Fix the allinone-build after r198669
https://bugs.webkit.org/show_bug.cgi?id=157798
Reviewed by Michael Catanzaro.
- CMakeLists.txt: Use DerivedSources.cpp only on Windows, it's broken everywhere else.
- 1:41 AM Changeset in webkit [201073] by
-
- 7 edits in trunk
Cascading order for !important properties in ::slotted and ::host rules is incorrect
https://bugs.webkit.org/show_bug.cgi?id=157789
<rdar://problem/26318781>
Reviewed by Andreas Kling.
LayoutTests/imported/w3c:
- csswg-test/css-scoping-1/shadow-cascade-order-001-expected.txt: This now passes.
Source/WebCore:
https://drafts.csswg.org/css-scoping-1/#shadow-cascading
"When comparing two declarations that have different tree contexts, then for normal rules the declaration earlier
in the shadow-including tree order wins, and for important rules the declaration coming later in the shadow-including
tree order wins."
- css/ElementRuleCollector.cpp:
(WebCore::MatchRequest::MatchRequest):
(WebCore::ElementRuleCollector::ElementRuleCollector):
(WebCore::ElementRuleCollector::matchedRuleList):
(WebCore::ElementRuleCollector::addMatchedRule):
(WebCore::ElementRuleCollector::clearMatchedRules):
(WebCore::ElementRuleCollector::addElementStyleProperties):
(WebCore::ElementRuleCollector::sortAndTransferMatchedRules):
Pass the tree context ordinal onwards so we can implement the order reversal semantics for !important properties.
(WebCore::ElementRuleCollector::matchAuthorRules):
(WebCore::ElementRuleCollector::matchHostPseudoClassRules):
(WebCore::ElementRuleCollector::matchSlottedPseudoElementRules):
Don't flush the matched rules immediately to get the right ordering. Instead compute tree context ordinal
that is then used as a sorting criteria.
(WebCore::ElementRuleCollector::collectSlottedPseudoElementRulesForSlot):
(WebCore::ElementRuleCollector::collectMatchingRulesForList):
(WebCore::compareRules):
Sort regular rules so that earlier shadow trees win.
(WebCore::ElementRuleCollector::sortMatchedRules):
- css/ElementRuleCollector.h:
- css/StyleResolver.cpp:
(WebCore::StyleResolver::State::clear):
(WebCore::StyleResolver::MatchResult::addMatchedProperties):
(WebCore::StyleResolver::CascadedProperties::addMatch): Added.
Add a helper.
(WebCore::StyleResolver::CascadedProperties::addNormalMatches):
Split normal and important to different functions for clarity.
(WebCore::StyleResolver::CascadedProperties::addImportantMatches):
For !important properties a later shadow tree wins. Do multiple passes to apply in correct order if needed.
- css/StyleResolver.h:
(WebCore::StyleResolver::MatchResult::matchedProperties):
- 12:12 AM Changeset in webkit [201072] by
-
- 45 edits1 copy19 adds in trunk
AX: [ATK] Use WebCore Accessibility's AccessibilityText for AtkObject name and description
https://bugs.webkit.org/show_bug.cgi?id=157822
Reviewed by Chris Fleizach.
Source/WebCore:
Remove the old code which was overriding WebCore Accessibility and always use
AccessibilityText.
If the AccessibilityText's textSource is HelpText or SummaryText, it should be exposed
as the AtkObject description. If the textSource is TitleTagText and there is no other
text alternative, the value should also be exposed in this fashion. Note that AtkObject's
description property is equivalent to AXAPI's AXHelp property.
If the AccessibilityText's textSource is anything other than the above, the first
non-empty value should be exposed as the AtkObject name. Depending on the source of
the name content, AtkObject's name property can be the equivalent of AXAPI's AXTitle.
However, most of the time, AtkObject's name property is equivalent to AXAPI's
AXDescription property.
By making these changes, what WebKit exposes for ATK is now extremely similar to what
WebKit exposes on the Mac (modulo the property names) and also with what is defined in
the HTML Accessibility and Accessible Name and Description Computation API mappings specs.
Now that the exposure is correct, the Layout Tests needed to be adjusted accordingly because
asking for the "AXDescription" gives you the AXDescription on the Mac and the AtkObject
description in GNU/Linux. But as indicated above, what ATK calls a "description" is what
the Mac calls "help."
Ultimately our Layout Tests and/or our platform TestRunner API should be modified to deal
with these differences more gracefully. (Bug https://bugs.webkit.org/show_bug.cgi?id=157187
has been opened for that task.) In the meantime, the existing tests have been given platform
checks to ask for the right property on each platform. This was done in such a way as to not
require other (non-ATK) platforms change their current expectations files.
- accessibility/atk/WebKitAccessibleWrapperAtk.cpp:
(webkitAccessibleGetName):
(webkitAccessibleGetDescription):
Tools:
Fix AccessibilityUIElement::helpText() so that it returns an empty string rather than
nullptr upon failure.
- WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
(WTR::AccessibilityUIElement::helpText):
LayoutTests:
Now that the exposure is correct, the Layout Tests needed to be adjusted accordingly because asking
for the "AXDescription" gives you the AXDescription on the Mac and the AtkObject description in
GNU/Linux. But what the Mac calls a "description" is what ATK calls a "name." What ATK calls a
"description" is what the Mac calls "help."
Ultimately our Layout Tests and/or our platform TestRunner API should be modified to deal with
with these differences more gracefully. (Bug https://bugs.webkit.org/show_bug.cgi?id=157187 has
been opened for that task.) In the meantime, the existing tests have been given platform checks
to ask for the right property on each platform. This was done in such a way as to not require
other (non-ATK) platforms change their current expectations files.
In addition to the above, three previously-failing tests were corrected and are now passing.
- accessibility/alt-tag-on-image-with-nonimage-role.html:
- accessibility/aria-help.html:
- accessibility/aria-label.html:
- accessibility/aria-labeled-with-hidden-node.html:
- accessibility/aria-labelledby-on-input.html:
- accessibility/aria-labelledby-overrides-aria-labeledby.html:
- accessibility/aria-labelledby-overrides-label.html:
- accessibility/aria-labelledby-stay-within.html:
- accessibility/aria-labelledby-with-descendants.html:
- accessibility/aria-namefrom-author.html:
- accessibility/aria-option-role.html:
- accessibility/canvas-description-and-role.html:
- accessibility/empty-image-with-title.html:
- accessibility/fieldset-element.html:
- accessibility/focusable-div.html:
- accessibility/gtk/no-notification-for-unrendered-iframe-children-expected.txt:
- accessibility/gtk/no-notification-for-unrendered-iframe-children.html:
- accessibility/gtk/title-and-alt-expected.txt:
- accessibility/gtk/title-and-alt.html:
- accessibility/help-text.html:
- accessibility/img-alt-tag-only-whitespace-expected.txt:
- accessibility/img-alt-tag-only-whitespace.html:
- accessibility/img-aria-button-alt-tag.html:
- accessibility/img-fallsback-to-title.html:
- accessibility/input-image-alt.html:
- accessibility/loading-iframe-sends-notification.html:
- accessibility/media-element.html:
- accessibility/radio-button-title-label.html:
- accessibility/self-referencing-aria-labelledby.html:
- accessibility/svg-bounds.html:
- platform/gtk/TestExpectations:
- platform/gtk/accessibility/alt-tag-on-image-with-nonimage-role-expected.txt: Added.
- platform/gtk/accessibility/aria-help-expected.txt:
- platform/gtk/accessibility/aria-hidden-negates-no-visibility-expected.txt: Added.
- platform/gtk/accessibility/aria-labeled-with-hidden-node-expected.txt: Added.
- platform/gtk/accessibility/aria-labelledby-on-input-expected.txt: Added.
- platform/gtk/accessibility/aria-labelledby-overrides-aria-label-expected.txt: Added.
- platform/gtk/accessibility/aria-labelledby-overrides-aria-labeledby-expected.txt: Added.
- platform/gtk/accessibility/aria-labelledby-overrides-label-expected.txt: Added.
- platform/gtk/accessibility/aria-labelledby-with-descendants-expected.txt: Added.
- platform/gtk/accessibility/aria-namefrom-author-expected.txt: Added.
- platform/gtk/accessibility/aria-option-role-expected.txt: Added.
- platform/gtk/accessibility/aria-switch-text-expected.txt:
- platform/gtk/accessibility/canvas-description-and-role-expected.txt: Added.
- platform/gtk/accessibility/empty-image-with-title-expected.txt: Added.
- platform/gtk/accessibility/fieldset-element-expected.txt: Added.
- platform/gtk/accessibility/focusable-div-expected.txt: Added.
- platform/gtk/accessibility/help-text-expected.txt: Added.
- platform/gtk/accessibility/image-link-expected.txt:
- platform/gtk/accessibility/image-map1-expected.txt:
- platform/gtk/accessibility/image-map2-expected.txt:
- platform/gtk/accessibility/image-with-alt-and-map-expected.txt:
- platform/gtk/accessibility/img-alt-tag-only-whitespace-expected.txt: Added.
- platform/gtk/accessibility/img-aria-button-alt-tag-expected.txt: Added.
- platform/gtk/accessibility/img-fallsback-to-title-expected.txt:
- platform/gtk/accessibility/input-image-alt-expected.txt: Added.
- platform/gtk/accessibility/media-element-expected.txt:
- platform/gtk/accessibility/radio-button-title-label-expected.txt:
- platform/gtk/accessibility/self-referencing-aria-labelledby-expected.txt: Added.
- platform/gtk/accessibility/svg-bounds-expected.txt: Added.
May 17, 2016:
- 8:39 PM Changeset in webkit [201071] by
-
- 3 edits in trunk/Source/WebCore
Add LayerListMutationDetector to hittesting.
https://bugs.webkit.org/show_bug.cgi?id=157758
Reviewed by Simon Fraser.
Hittesting is supposed to be readonly.
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::hitTestLayer):
- rendering/RenderLayer.h:
(WebCore::RenderLayer::clearZOrderLists):
- 8:29 PM Changeset in webkit [201070] by
-
- 10 edits in trunk/Source/WebCore
Remove toJS template methods taking const Ref and const RefPtr
https://bugs.webkit.org/show_bug.cgi?id=157791
Reviewed by Chris Dumez.
Updating toJS template method taking a const Ref<T>& to take a Ref<T>&&.
Updating toJS template method taking a const RefPtr<T>& to take a RefPtr<T>&&.
Updating binding generator to generate rvalue references.
Covered by existing tests.
- bindings/js/JSDOMBinding.h:
(WebCore::toJS):
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateConstructorDefinition):
- bindings/scripts/test/JS/JSTestInterface.cpp:
(WebCore::JSTestInterfaceConstructor::construct):
- bindings/scripts/test/JS/JSTestNamedConstructor.cpp:
(WebCore::JSTestNamedConstructorNamedConstructor::construct):
- bindings/scripts/test/JS/JSTestNode.cpp:
(WebCore::JSTestNodeConstructor::construct):
- bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::JSTestObjConstructor::construct):
- bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp:
(WebCore::constructJSTestOverloadedConstructors1):
(WebCore::constructJSTestOverloadedConstructors2):
(WebCore::constructJSTestOverloadedConstructors3):
(WebCore::constructJSTestOverloadedConstructors4):
(WebCore::constructJSTestOverloadedConstructors5):
- bindings/scripts/test/JS/JSTestTypedefs.cpp:
(WebCore::JSTestTypedefsConstructor::construct):
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::didAddUserAgentShadowRoot):
- 7:53 PM Changeset in webkit [201069] by
-
- 2 edits in trunk/LayoutTests
LayoutTest inspector/debugger/tail-recursion.html failing on WK2 debug
https://bugs.webkit.org/show_bug.cgi?id=157801
Rubber-stamped by Joseph Pecoraro.
- inspector/debugger/tail-recursion.html:
- 7:26 PM Changeset in webkit [201068] by
-
- 3 edits in trunk/Source/WebInspectorUI
Web Inspector: NavigationSidebarPanel should coordinate item selection between its tree outlines
https://bugs.webkit.org/show_bug.cgi?id=157813
<rdar://problem/26331779>
Reviewed by Timothy Hatcher.
- UserInterface/Views/DebuggerSidebarPanel.js:
(WebInspector.DebuggerSidebarPanel.prototype._treeSelectionDidChange):
Deselecting elements in other tree outlines is now done in the base class.
- UserInterface/Views/NavigationSidebarPanel.js:
(WebInspector.NavigationSidebarPanel.prototype.createContentTreeOutline):
Listen for selection changed events on all content tree outlines.
(WebInspector.NavigationSidebarPanel.prototype.treeElementAddedOrChanged):
Moved stub from the public section to the protected section.
(WebInspector.NavigationSidebarPanel.prototype._contentTreeOutlineTreeSelectionDidChange):
Deselect tree elements in any content tree outline that is not the
parent of the selected element.
(WebInspector.NavigationSidebarPanel.prototype._treeSelectionDidChange): Deleted.
Rename _contentTreeOutlineTreeSelectionDidChange, to prevent being
shadowed by subclasses with _treeSelectionDidChange event handlers.
- 7:14 PM Changeset in webkit [201067] by
-
- 3 edits2 adds in trunk
AX: Adding children incorrectly when there are nested inline continuations
https://bugs.webkit.org/show_bug.cgi?id=157818
Reviewed by Chris Fleizach.
Source/WebCore:
When getting the inline element continuation's next sibling, if we fall back on to the parent
case, we might end up adding the same node repeatedly. Fixed it by skipping this case.
Test: accessibility/mac/nested-inline-elements-children.html
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::nextSibling):
LayoutTests:
- accessibility/mac/nested-inline-elements-children-expected.txt: Added.
- accessibility/mac/nested-inline-elements-children.html: Added.
- 7:11 PM Changeset in webkit [201066] by
-
- 2 edits in trunk/Source/JavaScriptCore
JSC should detect the right default locale even when it's not embedded in WebCore
https://bugs.webkit.org/show_bug.cgi?id=157755
rdar://problem/24665424
Reviewed by Keith Miller.
This makes JSC try to use WTF's platform user preferred language detection if the DOM did
not register a defaultLanguage callback. The result is that when JSC runs standalone it
will detect the platform user preferred language almost the same way as when it's embedded
in WebCore. The only difference is that WebCore may have its own additional overrides via
the WK API. But in the absence of overrides, WebCore uses the same WTF logic that JSC falls
back to.
We first found this bug because on iOS, the intl tests would fail because ICU would report
a somewhat bogus locale on that platform. Prior to this change, standalone JSC would fall
back to ICU's locale detection. It turns out that the ICU default locale is also bogus on
OS X, just less so. For example, setting things to Poland did not result in the jsc shell
printing dates Polish-style. Now it will print them Polish-style if your system preferences
say so. Also, the tests don't fail on iOS anymore.
- runtime/IntlObject.cpp:
(JSC::defaultLocale):
- 7:07 PM Changeset in webkit [201065] by
-
- 12 edits in trunk
Add media query support for wide gamut displays on Mac
https://bugs.webkit.org/show_bug.cgi?id=157824
<rdar://problem/26333137>
Reviewed by Simon Fraser.
Source/WebCore:
Implement the Mac version of the color-gamut media query
by filling out the screenSupportsExtendedColor function.
On Yosemite, we always return false. On El Capitan, we
can check the ColorProfile via ColorSync to see if the
screen is wide gamut.
There is already a test in fast/media/mq-color-gamut.html
- css/MediaQueryEvaluator.cpp:
(WebCore::color_gamutMediaFeatureEval): Pass the mainFrame's view
to screenSupportsExtendedColor, so that it can fetch the NSScreen.
- platform/PlatformScreen.h: screenSupportsExtendedColor now takes
an optional Widget parameter.
- platform/ios/PlatformScreenIOS.mm:
(WebCore::screenSupportsExtendedColor): Add empty parameter.
- platform/mac/PlatformScreenMac.mm:
(WebCore::screenSupportsExtendedColor): Get the NSWindow, then the
NSScreen, then the ColorSpace, then the ColorSyncProfile, and
check if it is a wide gamut profile.
- platform/spi/cg/CoreGraphicsSPI.h: Add the SPI declarations.
LayoutTests:
Remove the check for sRGB, since it is confusingly false
on browsers that don't implement this query, and is likely
to be dropped from the specification.
Also, make the text readable.
- fast/media/mq-color-gamut-expected.html:
- fast/media/mq-color-gamut.html:
- 6:26 PM Changeset in webkit [201064] by
-
- 3 edits in trunk/Source/WebCore
Unreviewed, fix Darin's post-mortem review comments for r201052.
- rendering/RenderFieldset.cpp:
(WebCore::RenderFieldset::findLegend):
- rendering/svg/SVGRenderSupport.cpp:
(WebCore::SVGRenderSupport::layoutChildren):
- 6:05 PM Changeset in webkit [201063] by
-
- 5 edits in branches/safari-602.1.32-branch/Source
Versioning.
- 6:04 PM Changeset in webkit [201062] by
-
- 5 edits in branches/safari-601.1.46-branch/Source
Versioning.
- 6:04 PM Changeset in webkit [201061] by
-
- 5 edits in branches/safari-601-branch/Source
Versioning.
- 5:44 PM Changeset in webkit [201060] by
-
- 1 copy in tags/Safari-601.7.3
New tag.
- 5:43 PM Changeset in webkit [201059] by
-
- 1 copy in tags/Safari-601.1.46.142
New tag.
- 5:14 PM Changeset in webkit [201058] by
-
- 1 copy in tags/Safari-602.1.32.3
New tag.
- 5:13 PM Changeset in webkit [201057] by
-
- 1 edit1 delete in trunk/Source/WebInspectorUI
Web Inspector: Remove TimelineSidebarPanel.js as it's no longer referenced anywhere
https://bugs.webkit.org/show_bug.cgi?id=157819
Reviewed by Timothy Hatcher.
- UserInterface/Views/TimelineSidebarPanel.js: Removed.
Removed unused file.
- 4:24 PM Changeset in webkit [201056] by
-
- 12 edits2 adds in trunk
Make handleAcceptedCandidate a public function
https://bugs.webkit.org/show_bug.cgi?id=157763
-and corresponding-
rdar://problem/26206397
Reviewed by Tim Horton.
Source/WebCore:
Define handleAcceptedCandidateWithSoftSpaces on EditorClient so that it can
be invoked on any EditorClient.
- loader/EmptyClients.h:
- page/EditorClient.h:
(WebCore::EditorClient::handleAcceptedCandidateWithSoftSpaces):
Source/WebKit/mac:
This patch re-names handleAcceptedCandidate to
handleAcceptedCandidateWithSoftSpaces. The function now takes a
WebCore::TextCheckingResult instead of an NSTextCheckingResult and it can be
called from outside of WebEditorClient.
- WebCoreSupport/WebEditorClient.h:
- WebCoreSupport/WebEditorClient.mm:
(WebEditorClient::handleRequestedCandidates):
(WebEditorClient::handleAcceptedCandidateWithSoftSpaces):
(textCheckingResultFromNSTextCheckingResult): Deleted.
(WebEditorClient::handleAcceptedCandidate): Deleted.
Move showCandidates to WebViewPrivate so that it can be overridden by a test.
- WebView/WebViewInternal.h:
- WebView/WebViewPrivate.h:
Source/WebKit2:
This patch makes handleAcceptedCandidate a public member of WebViewImpl
instead of a private member.
- UIProcess/Cocoa/WebViewImpl.h:
(WebKit::WebViewImpl::createWeakPtr):
Tools:
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/WebKit2Cocoa/autofocused-text-input.html: Added.
- TestWebKitAPI/Tests/mac/ViewWithEditableAreaLeak.mm: Added.
(-[DoNotLeakWebView dealloc]):
(-[DoNotLeakWebView showCandidates:forString:inRect:forSelectedRange:view:completionHandler:]):
(-[DoNotLeakFrameLoadDelegate webView:didFinishLoadForFrame:]):
(TestWebKitAPI::TEST):
- 4:22 PM Changeset in webkit [201055] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed debug build fix after r201052.
- rendering/svg/RenderSVGText.cpp:
(WebCore::findPreviousAndNextAttributes): Deleted.
- 4:14 PM Changeset in webkit [201054] by
-
- 2 edits in branches/safari-602.1.32-branch/Source/WebKit/mac
Merge r200867. rdar://problem/26253396
- 3:52 PM Changeset in webkit [201053] by
-
- 3 edits3 adds in trunk
REGRESSION(r192855): Math.random() always produces the same first 7 decimal points the first two invocations
https://bugs.webkit.org/show_bug.cgi?id=157805
<rdar://problem/26327851>
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-05-17
Reviewed by Geoffrey Garen.
Source/WTF:
- wtf/WeakRandom.h:
(WTF::WeakRandom::setSeed):
Advance once to randomize the 32bit seed across the 128bit state
and avoid re-using 64bits of state in the second advance.
LayoutTests:
- js/dom/math-random-initial-values-expected.txt: Added.
- js/dom/math-random-initial-values.html: Added.
- js/resources/math-random-initial-values-iframe.html: Added.
Test that less then 5% of the time, early Math.random invocations
produce very similiar values. Before this change we were failing
100%, but after we see similiar values mostly around 0-3%.
- 3:39 PM Changeset in webkit [201052] by
-
- 22 edits in trunk/Source/WebCore
Use RenderChildIterator more for traversing a renderer's children
https://bugs.webkit.org/show_bug.cgi?id=157811
Reviewed by Antti Koivisto.
Use RenderChildIterator more for traversing a renderer's children.
- inspector/InspectorLayerTreeAgent.cpp:
(WebCore::InspectorLayerTreeAgent::layersForNode):
(WebCore::InspectorLayerTreeAgent::gatherLayersUsingRenderObjectHierarchy):
- inspector/InspectorLayerTreeAgent.h:
- rendering/AutoTableLayout.cpp:
(WebCore::AutoTableLayout::recalcColumn):
- rendering/InlineIterator.h:
(WebCore::isEmptyInline):
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::addFocusRingRects):
- rendering/RenderBox.cpp:
(WebCore::RenderBox::positionForPoint):
- rendering/RenderElement.cpp:
(WebCore::RenderElement::updateOutlineAutoAncestor):
- rendering/RenderElement.h:
- rendering/RenderFieldset.cpp:
(WebCore::RenderFieldset::findLegend):
- rendering/RenderFieldset.h:
- rendering/RenderInline.cpp:
(WebCore::RenderInline::generateCulledLineBoxRects):
(WebCore::RenderInline::culledInlineFirstLineBox):
(WebCore::RenderInline::culledInlineVisualOverflowBoundingBox):
(WebCore::RenderInline::dirtyLineBoxes):
- rendering/RenderListItem.cpp:
(WebCore::getParentOfFirstLineBox):
- rendering/RenderObject.cpp:
(WebCore::RenderObject::setFlowThreadStateIncludingDescendants):
(WebCore::RenderObject::addAbsoluteRectForLayer):
(WebCore::RenderObject::paintingRootRect):
(WebCore::RenderObject::removeFromRenderFlowThreadIncludingDescendants):
(WebCore::RenderObject::invalidateFlowThreadContainingBlockIncludingDescendants):
(WebCore::RenderObject::updateDragState):
- rendering/RenderTable.cpp:
(WebCore::RenderTable::firstColumn):
- rendering/RenderTableCol.cpp:
(WebCore::RenderTableCol::clearPreferredLogicalWidthsDirtyBits):
- rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::layoutRows):
- rendering/RenderTreeAsText.cpp:
(WebCore::write):
- rendering/svg/RenderSVGText.cpp:
(WebCore::findPreviousAndNextAttributes):
(WebCore::RenderSVGText::subtreeChildWasAdded):
(WebCore::RenderSVGText::subtreeChildWillBeRemoved):
- rendering/svg/SVGRenderSupport.cpp:
(WebCore::updateObjectBoundingBox):
(WebCore::SVGRenderSupport::computeContainerBoundingBoxes):
(WebCore::SVGRenderSupport::layoutChildren):
- rendering/svg/SVGTextLayoutAttributesBuilder.cpp:
(WebCore::SVGTextLayoutAttributesBuilder::collectTextPositioningElements):
- rendering/svg/SVGTextMetricsBuilder.cpp:
(WebCore::SVGTextMetricsBuilder::walkTree):
- 3:34 PM Changeset in webkit [201051] by
-
- 17 edits in trunk
Remove ES6_GENERATORS flag
https://bugs.webkit.org/show_bug.cgi?id=157815
<rdar://problem/26332894>
Reviewed by Geoffrey Garen.
This flag isn't needed. Generators are enabled everywhere and
part of a stable specification.
.:
- Source/cmake/OptionsWin.cmake:
- Source/cmake/WebKitFeatures.cmake:
- Source/cmake/tools/vsprops/FeatureDefines.props:
- Source/cmake/tools/vsprops/FeatureDefinesCairo.props:
Source/JavaScriptCore:
- Configurations/FeatureDefines.xcconfig:
- parser/Parser.cpp:
(JSC::Parser<LexerType>::parseFunctionDeclaration): Deleted.
(JSC::Parser<LexerType>::parseClass): Deleted.
(JSC::Parser<LexerType>::parseExportDeclaration): Deleted.
(JSC::Parser<LexerType>::parseAssignmentExpression): Deleted.
(JSC::Parser<LexerType>::parseProperty): Deleted.
(JSC::Parser<LexerType>::parseFunctionExpression): Deleted.
Source/WebCore:
- Configurations/FeatureDefines.xcconfig:
Source/WebKit/mac:
- Configurations/FeatureDefines.xcconfig:
Source/WebKit2:
- Configurations/FeatureDefines.xcconfig:
Source/WTF:
- wtf/FeatureDefines.h:
- 3:27 PM Changeset in webkit [201050] by
-
- 2 edits in trunk/Source/bmalloc
REGRESSION: JetStream crashes on some iPhones
https://bugs.webkit.org/show_bug.cgi?id=157814
Reviewed by Michael Saboff.
- bmalloc/Sizes.h: Reduce smallMax to 32kB.
Previous justification for 64kB was:
- bmalloc/Sizes.h: Upped smallMax to 64kB. Upping to 32kB is pretty reasonable, since sizes between 16kB and 32kB share page sizes. I went all the way up to 64kB because the GC uses 64kB blocks, and also just for extra padding to ensure that large allocations are indeed rare.
It turns out that the bump to 64kB substantially increases our memory
high water mark on JetStream, leading to jetsam crashes. Also, there
doesn't seem to be a practical performance problem to putting objects in
the (32kB - 64kB) range in the large allocator.
- 3:19 PM Changeset in webkit [201049] by
-
- 40 edits5 deletes in trunk
Rollout r200426 since it causes PLT regressions.
https://bugs.webkit.org/show_bug.cgi?id=157812
Unreviewed rollout of r200426 since the bots see a ~.6% PLT regression from the patch.
- 3:04 PM Changeset in webkit [201048] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: inspector tests should redirect and log console.trace() calls in test output
https://bugs.webkit.org/show_bug.cgi?id=157802
<rdar://problem/26325671>
Reviewed by Timothy Hatcher.
- UserInterface/Test/FrontendTestHarness.js:
(FrontendTestHarness.prototype.redirectConsoleToTestOutput.createProxyConsoleHandler):
Remove bind() that is now unnecessary. Also redirect console.warn.
(FrontendTestHarness.prototype.redirectConsoleToTestOutput):
For console.trace(), throw and catch a dummy Error to get a stack trace.
Do some post processing on it to remove useless frames and sanitize file paths.
- 2:38 PM Changeset in webkit [201047] by
-
- 5 edits3 adds in trunk
Web Inspector: Filtering huge data grids should yield occasionally so the UI remains responsive
https://bugs.webkit.org/show_bug.cgi?id=157702
<rdar://problem/26282898>
Based on a patch by Matt Baker <Matt Baker> on 2016-05-16
Reviewed by Timothy Hatcher.
Source/WebInspectorUI:
This patch adds a new class, YieldableTask, for processing large
data sets without starving the runloop. A yieldable task takes a delegate,
an iterator that produces the items to be processed by the delegate, and
the "work interval" time slice and "idle interval" to wait between time slices.
It works by usingyieldto suspend processing when the current time
slice is exceeded, and setting a timeout to wait out the idle interval.
The iterator is responsible for deciding a good traversal order for items,
and the delegate is responsible for processing each item in turn. Tasks
cannot be reused once cancelled or processing completes.
Change DataGrid to use a yieldable task for filtering data grid nodes.
When the filtering criteria changes, cancel the task and run a new task.
- UserInterface/Base/YieldableTask.js: Added.
(WebInspector.YieldableTask.prototype.get processing):
(WebInspector.YieldableTask.prototype.get cancelled):
(WebInspector.YieldableTask.prototype.get idleInterval):
(WebInspector.YieldableTask.prototype.get workInterval):
Add getters.
(WebInspector.YieldableTask.prototype.start.createIteratorForProcessingItems):
(WebInspector.YieldableTask.prototype.start):
Set up an iterator that cranks through items to be processed until the
time slice is exceeded. Check to see if the task is cancelled before and
after calling out to the delegate to perform processing on the item.
(WebInspector.YieldableTask.prototype.cancel):
Set the cancel flag. Tell the delegate the task is finished soon.
(WebInspector.YieldableTask.prototype._processPendingItems):
Request the next item from the cranking iterator so it tries to process
more items. If it yields but still has more items to process, set a timeout
and continue processing more items after the idle interval.
(WebInspector.YieldableTask.prototype._willYield): Notify the delegate.
(WebInspector.YieldableTask.prototype._didFinish): Clear state and notify.
(WebInspector.YieldableTask):
- UserInterface/Main.html:
- UserInterface/Test.html: Add new file.
- UserInterface/Views/DataGrid.js:
(WebInspector.DataGrid):
(WebInspector.DataGrid.prototype.filterDidChange):
Cancel the currently running filter task, if any exists.
(WebInspector.DataGrid.prototype._updateFilter.createIteratorForNodesToBeFiltered):
(WebInspector.DataGrid.prototype._updateFilter):
Set up and start a new filtering task when the filter updates.
(WebInspector.DataGrid.prototype.yieldableTaskWillProcessItem):
(WebInspector.DataGrid.prototype.yieldableTaskDidYield):
(WebInspector.DataGrid.prototype.yieldableTaskDidFinish):
Batch up notifications about filtered nodes changing since this can
cause a lot of unnecessary work by event listeners.
LayoutTests:
Add tests for new Inspector utility class YieldableTask.
- inspector/unit-tests/yieldable-task-expected.txt: Added.
- inspector/unit-tests/yieldable-task.html: Added.
- 2:35 PM Changeset in webkit [201046] by
-
- 4 edits in branches/safari-602.1.32-branch/Source/WebKit2
Merge r200631.
- 2:35 PM Changeset in webkit [201045] by
-
- 2 edits in branches/safari-602.1.32-branch/Source/WebKit2
Merge r200628.
- 2:35 PM Changeset in webkit [201044] by
-
- 2 edits in branches/safari-602.1.32-branch/Source/WebKit/mac
Merge r200800.
- 2:28 PM Changeset in webkit [201043] by
-
- 3 edits in trunk/Source/WebCore
BitmapImage::destroyDecodedDataIfNecessary() should only count frames with image data
https://bugs.webkit.org/show_bug.cgi?id=157779
Reviewed by Tim Horton.
BitmapImage::destroyDecodedDataIfNecessary() throws away all frames of an image if the
decoded frame size exceeds a threshold. However, it counts all frames, whether or not
they have an image (some frames may only have metadata, but m_frameBytes still returns
height*width*4).
Fix by only count m_frameBytes for frames that have an image.
- platform/graphics/BitmapImage.cpp:
(WebCore::BitmapImage::destroyDecodedDataIfNecessary):
- platform/graphics/BitmapImage.h:
(WebCore::FrameData::FrameData):
(WebCore::FrameData::usedFrameBytes):
- 2:24 PM Changeset in webkit [201042] by
-
- 2 edits in trunk/Source/WebKit2
Temporarily enable Experimental Features
https://bugs.webkit.org/show_bug.cgi?id=157810
<rdar://problem/26330804>
Reviewed by Anders Carlsson.
We currently don't have good UI for enabling these features,
which would mean Safari Technology Preview users would
never be able to turn them on… unless we enable them by
default temporarily.
- Shared/WebPreferencesDefinitions.h:
- 2:17 PM Changeset in webkit [201041] by
-
- 2 edits in trunk/Websites/perf.webkit.org
Add a subtitle under platform name in the summary page
https://bugs.webkit.org/show_bug.cgi?id=157809
Reviewed by Chris Dumez.
Add a description beneath the platform names.
- public/v3/pages/summary-page.js:
(SummaryPage.prototype._constructTable): Add a br and a span if subtitle is present.
(SummaryPage.cssTemplate): Added CSS rules for .subtitle.
- 2:02 PM Changeset in webkit [201040] by
-
- 23 edits in trunk/Source/WebCore
Optimize layer repaint rect computation and painting.
https://bugs.webkit.org/show_bug.cgi?id=157631
Reviewed by Zalan Bujtas.
This patch changes the computation of repaint rects to be for self-painting layers
only. In addition, hasBoxDecorations() has been changed to hasVisibleBoxDecorations(),
and it will no longer be set for transparent borders.
For scrolling layer position updating, visually empty layers have their repaint rects
cleared, and we don't compute repaint rects during the scroll. We would like to do this
all the time, but computeRepaintRects can be called at times when the visually empty
state is stale/unknown. For now we limit it to scrolling, since we know that the layer's
visually empty state is correct.
- rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::paintBoxDecorations):
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::paintObject):
- rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlockFlow::layoutRunsAndFloats):
- rendering/RenderBox.cpp:
(WebCore::RenderBox::updateFromStyle):
(WebCore::RenderBox::paintBoxDecorations):
- rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::willBeDestroyed):
(WebCore::RenderBoxModelObject::hasVisibleBoxDecorationStyle):
(WebCore::RenderBoxModelObject::updateFromStyle):
(WebCore::RenderBoxModelObject::hasBoxDecorationStyle): Deleted.
- rendering/RenderBoxModelObject.h:
- rendering/RenderElement.cpp:
(WebCore::RenderElement::styleWillChange):
(WebCore::mustRepaintBackgroundOrBorder):
- rendering/RenderImage.cpp:
(WebCore::RenderImage::imageChanged):
- rendering/RenderInline.cpp:
(WebCore::RenderInline::styleDidChange):
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::RenderLayer):
(WebCore::RenderLayer::updateLayerPositions):
(WebCore::RenderLayer::repaintRectIncludingNonCompositingDescendants):
(WebCore::RenderLayer::computeRepaintRects):
(WebCore::RenderLayer::clearRepaintRects):
(WebCore::RenderLayer::updateLayerPositionsAfterScroll):
(WebCore::RenderLayer::scrollTo):
(WebCore::RenderLayer::calculateClipRects):
- rendering/RenderLayer.h:
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateDrawsContent):
(WebCore::RenderLayerBacking::compositingOpacity):
(WebCore::hasVisibleBoxDecorations):
(WebCore::canCreateTiledImage):
(WebCore::hasVisibleBoxDecorationsOrBackgroundImage):
(WebCore::supportsDirectBoxDecorationsComposition):
(WebCore::RenderLayerBacking::isSimpleContainerCompositingLayer):
(WebCore::RenderLayerBacking::containsPaintedContent):
(WebCore::RenderLayerBacking::isDirectlyCompositedImage):
(WebCore::hasBoxDecorations): Deleted.
(WebCore::hasBoxDecorationsOrBackgroundImage): Deleted.
- rendering/RenderLayerModelObject.cpp:
(WebCore::RenderLayerModelObject::styleDidChange):
- rendering/RenderNamedFlowFragment.cpp:
(WebCore::RenderNamedFlowFragment::setObjectStyleInRegion):
- rendering/RenderObject.h:
(WebCore::RenderObject::hasVisibleBoxDecorations):
(WebCore::RenderObject::setFloating):
(WebCore::RenderObject::setInline):
(WebCore::RenderObject::computeBackgroundIsKnownToBeObscured):
(WebCore::RenderObject::setSelectionStateIfNeeded):
(WebCore::RenderObject::setHasVisibleBoxDecorations):
(WebCore::RenderObject::invalidateBackgroundObscurationStatus):
(WebCore::RenderObject::hasBoxDecorations): Deleted.
(WebCore::RenderObject::setHasBoxDecorations): Deleted.
- rendering/RenderReplaced.cpp:
(WebCore::RenderReplaced::paint):
- rendering/RenderTable.cpp:
(WebCore::RenderTable::paintObject):
(WebCore::RenderTable::paintBoxDecorations):
- rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::styleDidChange):
- rendering/RenderWidget.cpp:
(WebCore::RenderWidget::paint):
- rendering/style/BorderData.h:
(WebCore::BorderData::hasBorder):
(WebCore::BorderData::hasVisibleBorder):
(WebCore::BorderData::hasFill):
(WebCore::BorderData::hasBorderRadius):
- rendering/style/RenderStyle.h:
- rendering/svg/RenderSVGRoot.cpp:
(WebCore::RenderSVGRoot::layout):
(WebCore::RenderSVGRoot::styleDidChange):
- 1:38 PM Changeset in webkit [201039] by
-
- 4 edits1 add in trunk
Add test262 harness support code
https://bugs.webkit.org/show_bug.cgi?id=157797
Reviewed by Filip Pizlo.
Source/JavaScriptCore:
This patch adds some new tooling needed to run Test262 with the jsc
CLI. There were three options that needed to be added for Test262:
1) "--test262-async" This option overrides the print function in the test runner to look for
'Test262:AsyncTestComplete' instead of printing the passed text. If test262-async mode is on
and that string is not passed then the test is marked as failing.
2) "--strict-file=<file>" This option appends
"use strict";\nto the beginning of the
passed file before passing the source code to the VM. This option can, in theory, be passed
multiple times.
3) "--exception=<name>" This option asserts that at the end of the last script file passed
the VM has an uncaught exception with its name property equal to the passed name.
- jsc.cpp:
(Script::Script):
(fillBufferWithContentsOfFile):
(functionPrint):
(checkUncaughtException):
(runWithScripts):
(printUsageStatement):
(CommandLine::parseArguments):
(runJSC):
Tools:
The import-test262-tests script is used to generate the yaml file used to run test262. It
takes a path to the local copy of the Test262 repository as well as an optional path to file
containing a list of failures. This script currently just creates the yaml file used to run
the script. It does not relocate the test files into our tests directory. In the future I
plan to add that feature but it didn't seem essential for the first iteration. Since many
test262 tests need to be run in both strict and non-strict mode, import-test262-tests
creates two separate runs for those tests. This enables us to distinguish between failures
in only one of the two modes.
This patch also updates the run-jsc-stress-tests Script to run tests from Test262. In order
to do so two new run commands were needed runTest262 and prepareTest262Fixture. runTest262
takes an actual test file along with the metadata associated with it. prepareTest262Fixture
takes a fixture file (used by module tests for importing) and makes sure that file is
properly relocated to the test runner directory.
The proccess I used to import the tests was to first run import-test262-tests to create a
yaml for all the tests (import-test262-tests assumes all tests pass if to failures file is
passed). Then I ran the generated yaml file with "run-jsc-stress-tests -v -c 1" piping the
output to a file and collected all the lines with "FAIL" in it. Finally, I reran
import-test262-tests with the new failure file to create the final yaml.
- Scripts/import-test262-tests: Added.
- Scripts/run-jsc-stress-tests:
- 12:38 PM Changeset in webkit [201038] by
-
- 64 edits1 copy6 moves1 add in trunk/Source
WTF should know about Language
https://bugs.webkit.org/show_bug.cgi?id=157756
Source/JavaScriptCore:
Reviewed by Geoffrey Garen.
Teach our scripts that a ObjC class beginning with WTF is totally cool.
- JavaScriptCore.xcodeproj/project.pbxproj:
Source/WebCore:
Reviewed by Geoffrey Garen.
No new tests because this does not change behavior.
This change is all about moving some language functionality to WTF. Quoting the WTF
ChangeLog, this contains two changes:
- Move everything that WebCore's logic for getting the platform user preferred language depended on into WTF. This means CFBundleSPI.h and BlockObjCExceptions.h|cpp.
- Move WebCore::platformUserPreferredLanguages() to WTF::platformUserPreferredLanguages(). This is needed by https://bugs.webkit.org/show_bug.cgi?id=157755, which will make JSC use this to detect the platform user preferred language when running standalone.
The changes in WebCore are mostly about rewiring #includes and #imports and removing the
code that we moved to WTF. But there is one logic change: previously,
platformUserPreferredLanguages() would call WebCore::languageDidChange(). It can't do that
directly anymore, but WTF gives WebCore some API for registering the callback. So in
Language.cpp we now register languageDidChange anytime we do something that would
necessitate it, like calling platformUserPreferredLanguages(). This also registers the
callback inside addLanguageChangeObserver(), since it's possible for that to be called
after JSC had called platformUserPreferredLanguages() but before WebCore does so.
- PlatformEfl.cmake:
- PlatformGTK.cmake:
- PlatformMac.cmake:
- PlatformWin.cmake:
- WebCore.xcodeproj/project.pbxproj:
- bindings/objc/DOMCustomXPathNSResolver.mm:
- editing/ios/EditorIOS.mm:
- editing/mac/DictionaryLookup.mm:
- editing/mac/EditorMac.mm:
- page/CaptionUserPreferencesMediaAF.cpp:
- page/ios/EventHandlerIOS.mm:
- page/ios/FrameIOS.mm:
- page/mac/ChromeMac.mm:
- page/mac/EventHandlerMac.mm:
- platform/Language.cpp:
(WebCore::registerLanguageDidChangeCallbackIfNecessary):
(WebCore::observerMap):
(WebCore::addLanguageChangeObserver):
(WebCore::overrideUserPreferredLanguages):
(WebCore::userPreferredLanguages):
- platform/Language.h:
- platform/cocoa/ContentFilterUnblockHandlerCocoa.mm:
- platform/graphics/avfoundation/objc/InbandTextTrackPrivateAVFObjC.mm:
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
- platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:
- platform/graphics/ca/cocoa/PlatformCAFiltersCocoa.mm:
- platform/graphics/ca/cocoa/PlatformCALayerCocoa.mm:
- platform/graphics/cocoa/FontCocoa.mm:
- platform/graphics/mac/ColorMac.mm:
- platform/graphics/mac/GraphicsContext3DMac.mm:
- platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
- platform/ios/PlatformSpeechSynthesizerIOS.mm:
- platform/ios/ScrollViewIOS.mm:
- platform/ios/WidgetIOS.mm:
- platform/mac/BlockExceptions.h: Removed.
- platform/mac/BlockExceptions.mm: Removed.
- platform/mac/CursorMac.mm:
- platform/mac/Language.mm: Removed.
- platform/mac/ScrollAnimatorMac.mm:
- platform/mac/ScrollViewMac.mm:
- platform/mac/ScrollbarThemeMac.mm:
- platform/mac/ThemeMac.mm:
- platform/mac/WidgetMac.mm:
- platform/mediastream/mac/AVVideoCaptureSource.mm:
- platform/network/mac/CookieJarMac.mm:
- platform/network/mac/ResourceErrorMac.mm:
- platform/network/mac/ResourceHandleMac.mm:
- platform/spi/cf/CFBundleSPI.h: Removed.
- platform/unix/LanguageUnix.cpp: Removed.
- platform/win/LanguageWin.cpp: Removed.
Source/WebKit/mac:
Reviewed by Geoffrey Garen.
Rewires a bunch of includes/imports.
- WebCoreSupport/PopupMenuMac.mm:
- WebCoreSupport/WebChromeClient.mm:
- WebCoreSupport/WebFrameLoaderClient.mm:
- WebCoreSupport/WebGeolocationClient.mm:
- WebCoreSupport/WebNotificationClient.mm:
- WebCoreSupport/WebPlatformStrategies.mm:
- WebCoreSupport/WebUserMediaClient.mm:
- WebCoreSupport/WebVisitedLinkStore.mm:
- WebView/WebHTMLView.mm:
Source/WebKit2:
Reviewed by Geoffrey Garen and Alexey Proskuryakov.
Rewires a bunch of includes/imports.
- Shared/mac/RemoteLayerTreePropertyApplier.mm:
- UIProcess/Launcher/mac/ProcessLauncherMac.mm:
- UIProcess/Scrolling/ios/ScrollingTreeOverflowScrollingNodeIOS.mm:
- WebProcess/WebPage/mac/PlatformCAAnimationRemote.mm:
Source/WTF:
Reviewed by Geoffrey Garen.
This contains two changes:
- Move everything that WebCore's logic for getting the platform user preferred language depended on into WTF. This means CFBundleSPI.h and BlockObjCExceptions.h|cpp.
- Move WebCore::platformUserPreferredLanguages() to WTF::platformUserPreferredLanguages(). This is needed by https://bugs.webkit.org/show_bug.cgi?id=157755, which will make JSC use this to detect the platform user preferred language when running standalone.
Moving the dependencies accounts for a huge chunk of this change, since we have to rewire
all of the references to those headers in all of WebKit.
Moving platformUserPreferredLanguages() is mostly easy except for the weird callback.
That function would call languageDidChange(), which needs to stay in WebCore. So, this
gives WebCore the ability to register a languageDidChange callback. Other than this new
logic, the code being added to WTF is just being lifted out of WebCore.
- WTF.xcodeproj/project.pbxproj:
- wtf/BlockObjCExceptions.h: Added.
- wtf/BlockObjCExceptions.mm: Added.
(ReportBlockedObjCException):
- wtf/PlatformEfl.cmake:
- wtf/PlatformGTK.cmake:
- wtf/PlatformJSCOnly.cmake:
- wtf/PlatformMac.cmake:
- wtf/PlatformUserPreferredLanguages.h: Added.
- wtf/PlatformUserPreferredLanguagesMac.mm: Added.
(WTF::setPlatformUserPreferredLanguagesChangedCallback):
(WTF::preferredLanguages):
(+[WTFLanguageChangeObserver languagePreferencesDidChange:]):
(WTF::httpStyleLanguageCode):
(WTF::isValidICUCountryCode):
(WTF::platformUserPreferredLanguages):
- wtf/PlatformUserPreferredLanguagesUnix.cpp: Added.
(WTF::setPlatformUserPreferredLanguagesChangedCallback):
(WTF::platformLanguage):
(WTF::platformUserPreferredLanguages):
- wtf/PlatformUserPreferredLanguagesWin.cpp: Added.
(WTF::setPlatformUserPreferredLanguagesChangedCallback):
(WTF::localeInfo):
(WTF::platformLanguage):
(WTF::platformUserPreferredLanguages):
- wtf/PlatformWin.cmake:
- wtf/spi/cf: Added.
- wtf/spi/cf/CFBundleSPI.h: Added.
- 12:12 PM Changeset in webkit [201037] by
-
- 2 edits in branches/safari-602.1.32-branch/Source/WebKit2
Merge r200975. rdar://problem/24529203
- 12:04 PM Changeset in webkit [201036] by
-
- 2 edits in trunk/Source/WebCore
Tidy unused parameters with build flags in isValidKeywordPropertyAndValue
https://bugs.webkit.org/show_bug.cgi?id=157780
<rdar://problem/26327312>
Reviewed by Alex Christensen.
CSS_COMPOSITING and CSS_REGIONS aren't runtime flags any more, so
don't need a parser context. Meanwhile CSS_GRID_LAYOUT does, even
though it wasn't in the condition for the UNUSED_PARAM.
- css/CSSParser.cpp:
(WebCore::isValidKeywordPropertyAndValue):
- 11:57 AM WebInspectorDebugging edited by
- How to disable combining test resources. (diff)
- 11:49 AM Changeset in webkit [201035] by
-
- 2 edits in branches/safari-602.1.32-branch/Source/WebKit2
Merge r200974. rdar://problem/26304845
- 11:49 AM Changeset in webkit [201034] by
-
- 3 edits2 adds in branches/safari-602.1.32-branch
Merge r200976. rdar://problem/26231897
- 11:49 AM Changeset in webkit [201033] by
-
- 10 edits1 move3 adds in branches/safari-602.1.32-branch
Merge r200939. rdar://problem/26180740
- 11:49 AM Changeset in webkit [201032] by
-
- 2 edits in branches/safari-602.1.32-branch/Source/WebInspectorUI
Merge r200918. rdar://problem/26230168
- 11:49 AM Changeset in webkit [201031] by
-
- 8 edits2 adds in branches/safari-602.1.32-branch
Merge r200908. rdar://problem/26273173
- 11:49 AM Changeset in webkit [201030] by
-
- 13 edits in branches/safari-602.1.32-branch
Merge r200876. rdar://problem/26180300
- 11:49 AM Changeset in webkit [201029] by
-
- 2 edits in branches/safari-602.1.32-branch/Source/WebKit2
Merge r200891. rdar://problem/26269611
- 11:49 AM Changeset in webkit [201028] by
-
- 2 edits in branches/safari-602.1.32-branch/Source/WebKit2
Merge r200877. rdar://problem/26269611
- 11:49 AM Changeset in webkit [201027] by
-
- 9 edits in branches/safari-602.1.32-branch/Source
Merge r200874. rdar://problem/26269611
- 11:48 AM Changeset in webkit [201026] by
-
- 2 edits in branches/safari-602.1.32-branch/Tools
Merge r200670.
- 11:48 AM Changeset in webkit [201025] by
-
- 2 edits in branches/safari-602.1.32-branch/Tools
Merge r200669.
- 11:48 AM Changeset in webkit [201024] by
-
- 4 edits in branches/safari-602.1.32-branch/Source/WebKit2
Merge r200668.
- 11:31 AM Changeset in webkit [201023] by
-
- 2 edits in trunk/Source/WebCore
Regression(r177786): GlyphMetricsMap<T>::locatePageSlowCase() fills existing pages with unknown metrics
https://bugs.webkit.org/show_bug.cgi?id=157749
Reviewed by Antti Koivisto.
After r177786, GlyphMetricsMap<T>::locatePageSlowCase() would unconditionally fill
pages with unknown metrics. This patch updates the code to do so only if the page
is new, thus restoring the pre-r177786 behavior.
- platform/graphics/GlyphMetricsMap.h:
(WebCore::GlyphMetricsMap::metricsForGlyph):
(WebCore::GlyphMetricsMap::setMetricsForGlyph):
(WebCore::GlyphMetricsMap::GlyphMetricsPage::GlyphMetricsPage):
(WebCore::GlyphMetricsMap::GlyphMetricsPage::fill):
(WebCore::GlyphMetricsMap::locatePage):
(WebCore::GlyphMetricsMap<T>::locatePageSlowCase):
(WebCore::GlyphMetricsMap::GlyphMetricsPage::metricsForGlyph): Deleted.
(WebCore::GlyphMetricsMap::GlyphMetricsPage::setMetricsForGlyph): Deleted.
(WebCore::GlyphMetricsMap::GlyphMetricsPage::setMetricsForIndex): Deleted.
(WebCore::GlyphMetricsMap<float>::unknownMetrics): Deleted.
(WebCore::GlyphMetricsMap<FloatRect>::unknownMetrics): Deleted.
- 11:20 AM Changeset in webkit [201022] by
-
- 5 edits in trunk
console namespace breaks putting properties on console.proto
https://bugs.webkit.org/show_bug.cgi?id=157782
<rdar://problem/26250526>
Reviewed by Geoffrey Garen.
Source/JavaScriptCore:
Some websites currently depend on console.proto existing and being
a separate object from Object.prototype. This patch adds back a basic
console.proto object, but all the console functions are left on
the ConsoleObject itself.
- runtime/JSGlobalObject.cpp:
(JSC::createConsoleProperty):
LayoutTests:
- js/console-expected.txt:
- js/console.html:
- 11:00 AM WebInspectorDebugging edited by
- (diff)
- 10:58 AM Changeset in webkit [201021] by
-
- 17 edits in branches/safari-602.1.32-branch/Source
Merge r200819. rdar://problem/26235373
- 10:49 AM WebInspectorDebugging edited by
- Instructions about debug logging for WKTR (diff)
- 10:36 AM Changeset in webkit [201020] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, rolling out r201017.
https://bugs.webkit.org/show_bug.cgi?id=157799
Rebaselining the test was not the right solution. (Requested
by ryanhaddad on #webkit).
Reverted changeset:
"Rebaseline inspector/debugger/tail-recursion.html"
http://trac.webkit.org/changeset/201017
Patch by Commit Queue <commit-queue@webkit.org> on 2016-05-17
- 10:33 AM Changeset in webkit [201019] by
-
- 9 edits in trunk/Source/WebInspectorUI
Web Inspector: breakpoints in sourceURL named scripts are not persisted
https://bugs.webkit.org/show_bug.cgi?id=157714
<rdar://problem/26287099>
Reviewed by Joseph Pecoraro.
The Inspector frontend doesn't try to persist a breakpoint that
lacks a URL, even if the breakpoint has a sourceURL. Similarly, for
breakpoints without a URL, the frontend asks the backend to create
the breakpoint for a specific script identifier rather than a
URL-based breakpoint. This prevents breakpoints in injected scripts
from being resolved if the page is reloaded.
The Inspector backend knows how to resolve URL-based breakpoints
by matching against the script's URL or sourceURL, so we just need
to teach the frontend when either is appropriate to use.
This patch adds SourceCode.contentIdentifier, which is roughly
url || sourceURLfor content that is not emphemeral, such as
console evaluations. Change breakpoint and debugger code to use
contentIdentifierrather thanurl, and pass contentIdentifier
to the backend when setting a breakpoint by URL.
- UserInterface/Controllers/DebuggerManager.js:
(WebInspector.DebuggerManager.prototype.breakpointsForSourceCode):
(WebInspector.DebuggerManager.prototype.scriptsForURL):
(WebInspector.DebuggerManager.prototype.get searchableScripts):
(WebInspector.DebuggerManager.prototype.removeBreakpoint):
(WebInspector.DebuggerManager.prototype.reset):
(WebInspector.DebuggerManager.prototype.scriptDidParse):
(WebInspector.DebuggerManager.prototype._setBreakpoint):
(WebInspector.DebuggerManager.prototype._saveBreakpoints):
(WebInspector.DebuggerManager.prototype._associateBreakpointsWithSourceCode):
- UserInterface/Models/Breakpoint.js:
(WebInspector.Breakpoint):
(WebInspector.Breakpoint.prototype.get contentIdentifier):
(WebInspector.Breakpoint.prototype.get info):
(WebInspector.Breakpoint.prototype.saveIdentityToCookie):
(WebInspector.Breakpoint.prototype.get url): Deleted.
Replace uses of Breakpoint.prototype.get url with
contentIdentifier inside the class and at all callsites.
- UserInterface/Models/Script.js:
(WebInspector.Script.prototype.get contentIdentifier):
Added. Use the URL, or the sourceURL unless the script is
ephemeral and only run once, like as a console evaluation.
- UserInterface/Models/SourceCode.js:
(WebInspector.SourceCode.prototype.get url): Added.
All subclasses already override this getter. Add it here so that
the default implementation of contentIdentifier can use it.
(WebInspector.SourceCode.prototype.get contentIdentifier): Added.
- UserInterface/Views/BreakpointTreeElement.js:
(WebInspector.BreakpointTreeElement.prototype.get filterableData):
- UserInterface/Views/ProbeSetDetailsSection.js:
(WebInspector.ProbeSetDetailsSection.prototype._updateLinkElement):
- UserInterface/Views/SourceCodeTextEditor.js:
(WebInspector.SourceCodeTextEditor.prototype._matchesBreakpoint):
- UserInterface/Views/TextResourceContentView.js:
(WebInspector.TextResourceContentView.prototype.get supplementalRepresentedObjects):
- 10:07 AM Changeset in webkit [201018] by
-
- 5 edits in trunk/Source/WebCore
Fix the !ENABLE(WEB_TIMING) build after r200887
https://bugs.webkit.org/show_bug.cgi?id=157796
Reviewed by Chris Dumez.
- loader/DocumentThreadableLoader.cpp:
(WebCore::DocumentThreadableLoader::didFinishLoading):
(WebCore::DocumentThreadableLoader::loadRequest):
- loader/DocumentThreadableLoader.h:
- loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::requestResource):
(WebCore::CachedResourceLoader::revalidateResource):
(WebCore::CachedResourceLoader::loadResource):
- loader/cache/CachedResourceLoader.h:
- 10:03 AM Changeset in webkit [201017] by
-
- 2 edits in trunk/LayoutTests
Rebaseline inspector/debugger/tail-recursion.html
Unreviewed test gardening.
- inspector/debugger/tail-recursion-expected.txt:
- 9:40 AM Changeset in webkit [201016] by
-
- 2 edits in trunk/Source/WebKit2
Unreviewed GTK+ and EFL bulid fix; make the audio playback user gesture requirement
Cocoa-only.
- Shared/WebPreferencesDefinitions.h:
- 9:21 AM Changeset in webkit [201015] by
-
- 3 edits3 adds in trunk
REGRESSION(r54729): Line breaking in complex mixed-direction text is inconsistent across page refreshes
https://bugs.webkit.org/show_bug.cgi?id=157783
<rdar://problem/22908924>
Reviewed by Zalan Bujtas.
Source/WebCore:
mappedIndices is uninitialized.
Test: fast/text/complex-mixed-direction-line-breaking.html
- platform/graphics/mac/ComplexTextController.cpp:
(WebCore::ComplexTextController::ComplexTextRun::setIsNonMonotonic):
LayoutTests:
- fast/text/complex-mixed-direction-line-breaking-expected.html: Added.
- fast/text/complex-mixed-direction-line-breaking.html: Added.
- fast/text/resources/Gulf-regular.ttf: Added.
- 6:43 AM Changeset in webkit [201014] by
-
- 2 edits in trunk/Source/JavaScriptCore
Unreviewed, dump more information when math-pow-stable-results.js failed
https://bugs.webkit.org/show_bug.cgi?id=157168
- tests/stress/math-pow-stable-results.js:
- 4:54 AM WebKitGTK/2.12.x edited by
- (diff)
- 3:20 AM Changeset in webkit [201013] by
-
- 21 edits in trunk/Source
DOMPromise should only restrict the resolution type
https://bugs.webkit.org/show_bug.cgi?id=157307
Reviewed by Darin Adler.
Source/WebCore:
Removing from DOMPromise the rejection template parameter.
Supported rejection types are integers (Exception codes) and DOM objects (DOMError typically).
Updated DeferredWrapper to accept Ref<>&& and RefPtr<>&&.
Relanding without touching JSDOMBinding.h as this seemed to be impacting performances.
Changes also allow in most cases to remove the need for explictly declaring the
rejection/resolution type.
Minor refactoring of FontFaceSet promise handling to use DOMPromise in lieu of DeferredWrapper.
Covered by existing tests.
Changes should not be visible from user scripts.
- Modules/fetch/FetchBody.cpp:
(WebCore::FetchBody::consume):
(WebCore::FetchBody::consumeText):
(WebCore::blobFromArrayBuffer):
(WebCore::FetchBody::loadingFailed):
- Modules/fetch/FetchBody.h:
(WebCore::FetchBody::formData):
- Modules/fetch/FetchBodyOwner.cpp:
(WebCore::FetchBodyOwner::arrayBuffer):
(WebCore::FetchBodyOwner::blob):
(WebCore::FetchBodyOwner::formData):
(WebCore::FetchBodyOwner::json):
(WebCore::FetchBodyOwner::text):
- Modules/fetch/FetchResponse.cpp:
(WebCore::FetchResponse::BodyLoader::didReceiveResponse):
- Modules/fetch/FetchResponse.h:
- Modules/mediastream/MediaDevices.h:
- Modules/mediastream/PeerConnectionBackend.h:
- Modules/mediastream/UserMediaRequest.cpp:
(WebCore::UserMediaRequest::didCreateStream):
- Modules/streams/ReadableStreamSource.h:
- Modules/webaudio/AudioContext.h:
- bindings/js/JSDOMPromise.cpp:
(WebCore::fulfillPromiseWithJSON):
- bindings/js/JSDOMPromise.h:
(WebCore::TypeInspector::decltype):
(WebCore::TypeInspector::testIsVector):
(WebCore::TypeInspector::testIsRefOrRefPtr):
(WebCore::DeferredWrapper::resolve):
(WebCore::DeferredWrapper::reject):
(WebCore::DOMPromise::resolve):
(WebCore::DOMPromise::reject):
(WebCore::DeferredWrapper::resolveWithValue):
(WebCore::DeferredWrapper::rejectWithValue):
(WebCore::callPromiseFunction):
- bindings/js/JSSubtleCryptoCustom.cpp:
(WebCore::JSSubtleCrypto::importKey):
(WebCore::JSSubtleCrypto::unwrapKey):
- css/FontFace.h:
- css/FontFaceSet.cpp:
(WebCore::FontFaceSet::PendingPromise::PendingPromise):
(WebCore::FontFaceSet::load):
(WebCore::FontFaceSet::registerReady):
- css/FontFaceSet.h:
- html/HTMLMediaElement.h:
Source/WTF:
- wtf/Ref.h: Adding static constexpr to ease detection of Ref for templates.
- wtf/RefPtr.h: Ditto.
- 1:47 AM Changeset in webkit [201012] by
-
- 3 edits2 adds in branches/safari-602.1.32-branch
Merge r200872. rdar://problem/25993225
- 1:47 AM Changeset in webkit [201011] by
-
- 15 edits1 add1 delete in branches/safari-602.1.32-branch/Source
Merge r200866. rdar://problem/26253396
- 1:47 AM Changeset in webkit [201010] by
-
- 4 edits in branches/safari-602.1.32-branch/Source/WebInspectorUI
Merge r200793. rdar://problem/26251756
- 1:47 AM Changeset in webkit [201009] by
-
- 2 edits in branches/safari-602.1.32-branch/Source/WebInspectorUI
Merge r200792. rdar://problem/26253394
- 1:47 AM Changeset in webkit [201008] by
-
- 4 edits in branches/safari-602.1.32-branch/Source/WebCore
Merge r200788. rdar://problem/26143008
- 1:47 AM Changeset in webkit [201007] by
-
- 7 edits in branches/safari-602.1.32-branch/Source/WebInspectorUI
Merge r200708. rdar://problem/26228913
- 1:47 AM Changeset in webkit [201006] by
-
- 3 edits2 adds in branches/safari-602.1.32-branch
Merge r200688. rdar://problem/26013966
- 1:47 AM Changeset in webkit [201005] by
-
- 3 edits2 adds in branches/safari-602.1.32-branch
Merge r200803. rdar://problem/17779042
- 1:47 AM Changeset in webkit [201004] by
-
- 3 edits in branches/safari-602.1.32-branch/LayoutTests
Merge r200674. rdar://problem/17779042
- 1:46 AM Changeset in webkit [201003] by
-
- 2 edits in branches/safari-602.1.32-branch/LayoutTests
Merge r200646. rdar://problem/17779042
- 1:46 AM Changeset in webkit [201002] by
-
- 8 edits6 adds in branches/safari-602.1.32-branch
Merge r200601. rdar://problem/17779042
- 1:46 AM Changeset in webkit [201001] by
-
- 5 edits2 adds in branches/safari-602.1.32-branch
Merge r200778. rdar://problem/25840861
May 16, 2016:
- 11:36 PM Changeset in webkit [201000] by
-
- 3 edits in trunk/Source/WebCore
Modernize CSS Parser
https://bugs.webkit.org/show_bug.cgi?id=157772
Patch by Alex Christensen <achristensen@webkit.org> on 2016-05-16
Reviewed by Brady Eidson.
No new tests. This patch just replaces PassRefPtr with RefPtr&&.
- css/CSSParser.cpp:
(WebCore::CSSParser::parseDeclaration):
(WebCore::CSSParser::SourceSize::SourceSize):
(WebCore::CSSParser::createStyleProperties):
(WebCore::CSSParser::addProperty):
(WebCore::CSSParser::parseValidPrimitive):
(WebCore::CSSParser::addExpandedPropertyForValue):
(WebCore::CSSParser::parseVariableDependentValue):
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseColumnsShorthand):
(WebCore::CSSParser::parseGridItemPositionShorthand):
(WebCore::CSSParser::parseGridAreaShorthand):
(WebCore::CSSParser::parseInsetRoundedCorners):
(WebCore::CSSParser::parseBasicShapeInset):
(WebCore::ShadowParseContext::commitLength):
(WebCore::ShadowParseContext::commitColor):
(WebCore::BorderImageParseContext::requireWidth):
(WebCore::BorderImageParseContext::requireOutset):
(WebCore::BorderImageParseContext::commitImage):
(WebCore::BorderImageParseContext::commitImageSlice):
(WebCore::BorderImageParseContext::commitForwardSlashOperator):
(WebCore::BorderImageParseContext::commitBorderWidth):
(WebCore::BorderImageParseContext::commitBorderOutset):
(WebCore::BorderImageParseContext::commitRepeat):
(WebCore::BorderImageParseContext::commitWebKitBorderImage):
(WebCore::BorderImageParseContext::commitBorderImage):
(WebCore::BorderImageParseContext::commitBorderImageProperty):
(WebCore::BorderImageSliceParseContext::commitFill):
(WebCore::BorderImageSliceParseContext::commitBorderImageSlice):
(WebCore::BorderImageQuadParseContext::commitNumber):
(WebCore::BorderImageQuadParseContext::setAllowFinalCommit):
(WebCore::BorderImageQuadParseContext::setTop):
(WebCore::BorderImageQuadParseContext::commitBorderImageQuad):
(WebCore::CSSParser::parseCounter):
(WebCore::parseDeprecatedGradientPoint):
(WebCore::CSSParser::parseDeprecatedGradient):
(WebCore::valueFromSideKeyword):
(WebCore::parseGradientColorOrKeyword):
(WebCore::CSSParser::parsePerspectiveOrigin):
(WebCore::CSSParser::addTextDecorationProperty):
(WebCore::CSSParser::parseTextDecoration):
(WebCore::CSSParser::realLex):
(WebCore::CSSParser::createImportRule):
(WebCore::CSSParser::createMediaRule):
(WebCore::CSSParser::processAndAddNewRuleToSourceTreeIfNeeded):
(WebCore::CSSParser::addNewRuleToSourceTree):
- css/CSSParser.h:
(WebCore::CSSParser::hasProperties):
(WebCore::CSSParser::resetPropertyRange):
(WebCore::CSSParser::isExtractingSourceData):
- 10:37 PM Changeset in webkit [200999] by
-
- 3 edits4 copies in branches/safari-601.1.46-branch
Merged r200986. rdar://problem/26300489
- 10:35 PM Changeset in webkit [200998] by
-
- 3 edits4 copies in branches/safari-601-branch
Merged r200986. rdar://problem/26300514
- 10:31 PM Changeset in webkit [200997] by
-
- 4 edits3 adds in trunk
ShadowChicken crashes when reading a scope from the frame during a stack overflow exception
https://bugs.webkit.org/show_bug.cgi?id=157770
Reviewed by Filip Pizlo.
Source/JavaScriptCore:
ShadowChicken was reading the scope from a half formed
frame as it threw a stack overflow exception. The frame had
a valid CodeBlock pointer, but it did not have a valid scope.
The code in ShadowChicken's throw packet logging mechanism didn't
account for this. The fix is to respect whether genericUnwind wants
to unwind from the current frame or the caller's frame. For stack
overflow errors, we always unwind the caller's frame.
- jit/JITExceptions.cpp:
(JSC::genericUnwind):
LayoutTests:
- inspector/debugger/debugger-stack-overflow-expected.txt: Added.
- inspector/debugger/debugger-stack-overflow.html: Added.
- inspector/debugger/resources/stack-overflow.js: Added.
(foo):
(start):
- 9:36 PM Changeset in webkit [200996] by
-
- 3 edits in trunk/Source/JavaScriptCore
REGRESSION(r200208): It made 2 JSC stress tests fail on x86
https://bugs.webkit.org/show_bug.cgi?id=157168
Reviewed by Benjamin Poulain.
The fast path in operationMathPow produces different results between x87 and the other environments.
This is because x87 calculates the double value in 80bit precision.
The situation is the following: in x86 32bit environment, floating point operations are compiled to
x87 operations by default even if we can use SSE2. But in DFG environment, we aggressively use SSE2
if the cpuid reports SSE2 is available. As a result, the implementations differ between C runtime
and DFG JIT code. The C runtime uses x87 while DFG JIT code uses SSE2. This causes a precision
problem since x87 has 80bit precision while SSE2 has 64bit precision.
In this patch, in x86 32bit environment, we use
volatile doubleif the-mfpmath=sse and -msse2 (or later)
is not specified. This will round the x87 value into 64bit per multiplying. Note that this problem does not
occur in OS X clang 32bit environment. This is because-mfpmath=sseis enabled by default in OS X clang 32bit.
- b3/B3MathExtras.cpp:
(JSC::B3::powDoubleInt32):
- runtime/MathCommon.cpp:
(JSC::operationMathPow):
- 9:11 PM Changeset in webkit [200995] by
-
- 3 edits in trunk/Source/WebInspectorUI
Uncaught Exception: TypeError: null is not an object (evaluating 'event.data.pathComponent.domTreeElement')
https://bugs.webkit.org/show_bug.cgi?id=157759
<rdar://problem/26309427>
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-05-16
Reviewed by Timothy Hatcher.
- UserInterface/Views/DOMTreeContentView.js:
(WebInspector.DOMTreeContentView.prototype._pathComponentSelected):
Handle possible null path components.
- UserInterface/Views/HierarchicalPathComponent.js:
(WebInspector.HierarchicalPathComponent.prototype.get selectedPathComponent):
When there is a list of just one that is triggered, the Clicked
event should produce that one, to be consistent with clicking
on a list of multiple elements and selecting the same value.
- 9:11 PM Changeset in webkit [200994] by
-
- 3 edits1 add in trunk/Source/WebCore
Add RenderDescendantIterator to traverse a RenderObject's descendants
https://bugs.webkit.org/show_bug.cgi?id=157785
Reviewed by Zalan Bujtas.
Add RenderDescendantIterator to traverse a RenderObject's descendants. I
am planning to use it in the iOS Text Autosizing code (See Bug 157784).
- WebCore.xcodeproj/project.pbxproj:
- rendering/RenderDescendantIterator.h: Added.
(WebCore::RenderDescendantIterator<T>::RenderDescendantIterator):
(WebCore::RenderDescendantIterator<T>::operator):
(WebCore::RenderDescendantConstIterator<T>::RenderDescendantConstIterator):
(WebCore::RenderDescendantConstIterator<T>::operator):
(WebCore::RenderDescendantIteratorAdapter<T>::RenderDescendantIteratorAdapter):
(WebCore::RenderDescendantIteratorAdapter<T>::begin):
(WebCore::RenderDescendantIteratorAdapter<T>::end):
(WebCore::RenderDescendantConstIteratorAdapter<T>::RenderDescendantConstIteratorAdapter):
(WebCore::RenderDescendantConstIteratorAdapter<T>::begin):
(WebCore::RenderDescendantConstIteratorAdapter<T>::end):
(WebCore::descendantsOfType):
- rendering/RenderIterator.h:
(WebCore::RenderObjectTraversal::firstChild):
(WebCore::RenderObjectTraversal::nextAncestorSibling):
(WebCore::RenderObjectTraversal::next):
(WebCore::RenderTraversal::firstChild):
(WebCore::RenderTraversal::lastChild):
(WebCore::RenderTraversal::nextSibling):
(WebCore::RenderTraversal::previousSibling):
(WebCore::RenderTraversal::findAncestorOfType):
(WebCore::RenderTraversal::firstWithin):
(WebCore::RenderTraversal::next):
(WebCore::RenderIterator<T>::traverseNext):
(WebCore::RenderConstIterator<T>::traverseNext):
- 9:02 PM Changeset in webkit [200993] by
-
- 3 edits in trunk/Source/WTF
ARMV7K: Crash at JavaScriptCore: WTF::ScopedLambdaFunctor<bool
https://bugs.webkit.org/show_bug.cgi?id=157781
Reviewed by Filip Pizlo.
Replaced use of ScopedLambda in locking code with std::function much as it was
before change set 199760 to work around what appears to be a clang compiler issue.
- wtf/ParkingLot.cpp:
(WTF::ParkingLot::parkConditionallyImpl):
(WTF::ParkingLot::unparkOne):
(WTF::ParkingLot::unparkAll):
(WTF::ParkingLot::forEach):
(WTF::ParkingLot::unparkOneImpl): Deleted.
(WTF::ParkingLot::forEachImpl): Deleted.
- wtf/ParkingLot.h:
(WTF::ParkingLot::parkConditionally):
(WTF::ParkingLot::unparkOne): Deleted.
(WTF::ParkingLot::forEach): Deleted.
- 8:36 PM Changeset in webkit [200992] by
-
- 2 edits in trunk/Source/JavaScriptCore
[JSC] "return this" in a constructor does not need a branch on isObject(this)
https://bugs.webkit.org/show_bug.cgi?id=157775
Patch by Benjamin Poulain <bpoulain@apple.com> on 2016-05-16
Reviewed by Saam Barati and Ryosuke Niwa.
When returning "this" in a constructor, the bytecode generator was generating:
is_object locX, this
jtrue locX, 5(->second ret)
ret this
ret this
That code is eliminated in DFG but it is pretty costly lower tiers.
This patch changes bytecode generation to avoid the is_object test
when possible and not generate two ret if they encode the same thing.
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::emitReturn):
- 8:31 PM Changeset in webkit [200991] by
-
- 2 edits in trunk/Source/JavaScriptCore
[JSC] Remove the index check from op_get_by_val/op_put_by_val when the index is constant
https://bugs.webkit.org/show_bug.cgi?id=157766
Patch by Benjamin Poulain <bpoulain@apple.com> on 2016-05-16
Reviewed by Geoffrey Garen.
If the index is an integer constant, do not generate the index check.
- jit/JITPropertyAccess.cpp:
(JSC::JIT::emit_op_get_by_val):
(JSC::JIT::emitSlow_op_get_by_val):
(JSC::JIT::emit_op_put_by_val):
(JSC::JIT::emitSlow_op_put_by_val):
- 8:28 PM Changeset in webkit [200990] by
-
- 2 edits in trunk/Source/JavaScriptCore
[JSC][DFG] Fill spilled Int32 as Int32 instead of JSInt32
https://bugs.webkit.org/show_bug.cgi?id=157700
Patch by Benjamin Poulain <bpoulain@apple.com> on 2016-05-16
Reviewed by Michael Saboff.
In general, fillSpeculateInt32() originate from SpeculateInt32
and the user does not care about the tag.
This is particularily obvious on Sunspider's math-spectral-norm.js.
In that test, registers are frequently spilled because of x86's DIV.
When they are re-filled, they were always tagged.
Since the loops are small, all the tagging adds up.
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::fillSpeculateInt32Internal):
- 7:34 PM Changeset in webkit [200989] by
-
- 11 edits in branches/safari-602.1.32-branch/Source
Disable some features on safari-602.1.32-branch.
<rdar://problem/26080754>
Source/JavaScriptCore:
- Configurations/FeatureDefines.xcconfig:
Source/WebCore:
- Configurations/FeatureDefines.xcconfig:
Source/WebKit/mac:
- Configurations/FeatureDefines.xcconfig:
Source/WebKit2:
- Configurations/FeatureDefines.xcconfig:
Source/WTF:
- wtf/FeatureDefines.h:
- 6:30 PM Changeset in webkit [200988] by
-
- 2 edits in trunk/Source/WebCore
Remove YouTube site-specific hack
https://bugs.webkit.org/show_bug.cgi?id=157776
Patch by Alex Christensen <achristensen@webkit.org> on 2016-05-16
Reviewed by Eric Carlson.
No new tests. Youtube fullscreen seems to work without
http://trac.webkit.org/changeset/173533 now.
- dom/Document.cpp:
(WebCore::unwrapFullScreenRenderer):
(WebCore::Document::webkitWillEnterFullScreenForElement):
(WebCore::Document::webkitDidEnterFullScreenForElement):
(WebCore::Document::webkitWillExitFullScreenForElement):
(WebCore::Document::webkitDidExitFullScreenForElement):
(WebCore::Document::setFullScreenRenderer):
(WebCore::hostIsYouTube): Deleted.
- 6:17 PM Changeset in webkit [200987] by
-
- 2 edits in branches/safari-602.1.32-branch/Source/WebCore
Merge r200985. <rdar://problem/26312967>
- 6:09 PM Changeset in webkit [200986] by
-
- 3 edits4 adds in trunk
heap use-after-free at WebCore::TimerBase::heapPopMin()
https://bugs.webkit.org/show_bug.cgi?id=157742
<rdar://problem/26236778>
Source/WebCore:
Reviewed by David Kilzer.
Tested by fast/frames/resources/crash-during-iframe-load-stop.html.
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::stopForUserCancel): Protect m_frame from destruction while it is still
being used by the current stack frame.
(WebCore::FrameLoader::frameDetached): Ditto.
(WebCore::FrameLoader::continueFragmentScrollAfterNavigationPolicy): Ditto.
LayoutTests:
Reviewed by Simon Fraser.
- fast/frames/crash-during-iframe-load-stop-expected.txt: Added.
- fast/frames/crash-during-iframe-load-stop.html: Added.
- fast/frames/resources/crash-during-iframe-load-stop-inner.html: Added.
- fast/frames/resources/crash-during-iframe-load-stop.html: Added.
- 6:05 PM Changeset in webkit [200985] by
-
- 2 edits in trunk/Source/WebCore
WebCoreJSBuiltinInternals won't compile if some build flags are off
https://bugs.webkit.org/show_bug.cgi?id=157777
<rdar://problem/26312967>
Reviewed by Simon Fraser.
Allow this file to compile when some build flags are disabled.
- bindings/js/WebCoreJSBuiltinInternals.cpp:
(WebCore::JSBuiltinInternalFunctions::JSBuiltinInternalFunctions):
- 5:29 PM Changeset in webkit [200984] by
-
- 2 edits in trunk/Source/JavaScriptCore
Unreviewed Cloop build fix.
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::bytecodeOffsetFromCallSiteIndex):
- 5:15 PM Changeset in webkit [200983] by
-
- 4 edits in trunk/Source/bmalloc
REGRESSION (200035): changes in "WebKit Malloc" VM regions are causing 'leaks' to spew "Failed to map remote region" messages
https://bugs.webkit.org/show_bug.cgi?id=157764
Reviewed by Gavin Barraclough.
We need to allow for guard pages and only report unguarded pages to the
leaks tool -- otherwise, it will try to remote map our guarded pages,
and crash.
- bmalloc/VMHeap.cpp:
(bmalloc::VMHeap::tryAllocateLargeChunk):
(bmalloc::VMHeap::allocateSmallChunk): Adopt the new API for reporting
a range instead of a Chunk*, and report the unguarded range.
This also fixes a separate bug -- very large allocations would not
fully participate in pointer scanning because they would only report 2MB
(chunkSize) in size. This could cause false-positive leak reports.
- bmalloc/Zone.cpp:
(bmalloc::enumerator): Updated to scan ranges instead of fixed-sized
Chunk pointers.
- bmalloc/Zone.h:
(bmalloc::Zone::ranges):
(bmalloc::Zone::addRange): Store ranges instead of fixed-sized Chunk
pointers because our VM ranges have variable sizes -- both due to guard
pages and due to large allocations.
(bmalloc::Zone::chunks): Deleted.
(bmalloc::Zone::addChunk): Deleted.
- 4:49 PM Changeset in webkit [200982] by
-
- 3 edits in trunk/Source/WebCore
Modern IDB: Give each UniqueIDBDatabase its own task queues.
https://bugs.webkit.org/show_bug.cgi?id=157757
Reviewed by Alex Christensen.
No new tests (Refactor, no behavior change).
Each UniqueIDBDatabase now maintains its own databaseTask and databaseTaskReply queues.
Instead of posting the specific task(reply) with the IDBServer, it merely posts a task(reply) that says
"Handle your next task(reply)".
- Modules/indexeddb/server/UniqueIDBDatabase.cpp:
(WebCore::IDBServer::UniqueIDBDatabase::performCurrentOpenOperation):
(WebCore::IDBServer::UniqueIDBDatabase::performCurrentDeleteOperation):
(WebCore::IDBServer::UniqueIDBDatabase::deleteBackingStore):
(WebCore::IDBServer::UniqueIDBDatabase::startVersionChangeTransaction):
(WebCore::IDBServer::UniqueIDBDatabase::openBackingStore):
(WebCore::IDBServer::UniqueIDBDatabase::createObjectStore):
(WebCore::IDBServer::UniqueIDBDatabase::performCreateObjectStore):
(WebCore::IDBServer::UniqueIDBDatabase::deleteObjectStore):
(WebCore::IDBServer::UniqueIDBDatabase::performDeleteObjectStore):
(WebCore::IDBServer::UniqueIDBDatabase::clearObjectStore):
(WebCore::IDBServer::UniqueIDBDatabase::performClearObjectStore):
(WebCore::IDBServer::UniqueIDBDatabase::createIndex):
(WebCore::IDBServer::UniqueIDBDatabase::performCreateIndex):
(WebCore::IDBServer::UniqueIDBDatabase::deleteIndex):
(WebCore::IDBServer::UniqueIDBDatabase::performDeleteIndex):
(WebCore::IDBServer::UniqueIDBDatabase::putOrAdd):
(WebCore::IDBServer::UniqueIDBDatabase::performPutOrAdd):
(WebCore::IDBServer::UniqueIDBDatabase::getRecord):
(WebCore::IDBServer::UniqueIDBDatabase::performGetRecord):
(WebCore::IDBServer::UniqueIDBDatabase::performGetIndexRecord):
(WebCore::IDBServer::UniqueIDBDatabase::getCount):
(WebCore::IDBServer::UniqueIDBDatabase::performGetCount):
(WebCore::IDBServer::UniqueIDBDatabase::deleteRecord):
(WebCore::IDBServer::UniqueIDBDatabase::performDeleteRecord):
(WebCore::IDBServer::UniqueIDBDatabase::openCursor):
(WebCore::IDBServer::UniqueIDBDatabase::performOpenCursor):
(WebCore::IDBServer::UniqueIDBDatabase::iterateCursor):
(WebCore::IDBServer::UniqueIDBDatabase::performIterateCursor):
(WebCore::IDBServer::UniqueIDBDatabase::commitTransaction):
(WebCore::IDBServer::UniqueIDBDatabase::performCommitTransaction):
(WebCore::IDBServer::UniqueIDBDatabase::abortTransaction):
(WebCore::IDBServer::UniqueIDBDatabase::performAbortTransaction):
(WebCore::IDBServer::UniqueIDBDatabase::activateTransactionInBackingStore):
(WebCore::IDBServer::UniqueIDBDatabase::performActivateTransactionInBackingStore):
(WebCore::IDBServer::UniqueIDBDatabase::postDatabaseTask):
(WebCore::IDBServer::UniqueIDBDatabase::postDatabaseTaskReply):
(WebCore::IDBServer::UniqueIDBDatabase::executeNextDatabaseTask):
(WebCore::IDBServer::UniqueIDBDatabase::executeNextDatabaseTaskReply):
- Modules/indexeddb/server/UniqueIDBDatabase.h:
- 4:31 PM Changeset in webkit [200981] by
-
- 53 edits12 adds in trunk
Hook up ShadowChicken to the debugger to show tail deleted frames
https://bugs.webkit.org/show_bug.cgi?id=156685
<rdar://problem/25770521>
Reviewed by Filip Pizlo and Mark Lam and Joseph Pecoraro.
Source/JavaScriptCore:
The heart of this patch hooks up ShadowChicken to DebuggerCallFrame to
allow the Web Inspector to display the ShadowChicken's shadow stack.
This means the Web Inspector can now display tail deleted frames.
To make this work, I made the necessary changes to ShadowChicken and
DebuggerCallFrame to allow DebuggerCallFrame to keep the same API
when representing both machine frames and tail deleted frames.
- ShadowChicken prologue packets now log the current scope. Tail packets log the current scope, the 'this' value, the CodeBlock, and the CallSiteIndex. This allows the inspector to not only show the tail deleted frame, but also show exactly where the tail call happened (line and column numbers), with which scope it executed, and with which 'this' value. This patch also allows DebuggerCallFrame to execute console statements in a tail deleted frame.
- I changed ShadowChicken's stack resizing algorithm. ShadowChicken now only keeps a maximum number of tail deleted frames in its shadow stack. It will happily represent all machine frames without limit. Right now, the maximum number of tail deleted frames I chose to keep alive is 128. We will keep frames alive starting from the top of the stack. This allows us to have a strong defense against runaway memory usage. We will only keep around at most 128 "shadow" frames that wouldn't have naturally been kept alive by the executing program. We can play around with this number if we find that 128 is either too many or too few frames.
- DebuggerCallFrame is no longer a cheap class to create. When it is created, we will eagerly create the entire virtual debugger stack. So I modified the existing code to lazily create DebuggerCallFrames only when necessary. We used to eagerly create them at each op_debug statement even though we would just throw them away if we didn't hit a breakpoint.
- A valid DebuggerCallFrame will always have a valid CallFrame* pointer into the stack. This pointer won't always refer to the logical frame that the DebuggerCallFrame represents because a DebuggerCallFrame can now represent a tail deleted frame. To do this, DebuggerCallFrame now has a ShadowChicken::Frame member variable. This allows DebuggerCallFrame to know when it represents a tail deleted frame and gives DebuggerCallFrame a mechanism to ask the tail deleted frame for interesting information (like its 'this' value, scope, CodeBlock, etc). A tail deleted frame's machine frame pointer will be the machine caller of the tail deleted frame (or the machine caller of the first of a series of consecutive tail calls).
- I added a new flag to UnlinkedCodeBlock to indicate when it is compiled with debugging opcodes. I did this because ShadowChicken may read a JSScope from the machine stack. This is only safe if the machine CodeBlock was compiled with debugging opcodes. This is safer than asking if the CodeBlock's global object has an interactive debugger enabled because it's theoretically possible for the debugger to be enabled while code compiled without a debugger is still live on the stack. This field is also now used to indicate to the DFGGraph that the interactive debugger is enabled.
- Finally, this patch adds a new field to the Inspector's CallFrame protocol object called 'isTailDeleted' to allow the Inspector to know when a CallFrame represents a tail deleted frame.
- JavaScriptCore.xcodeproj/project.pbxproj:
- bytecode/BytecodeList.json:
- bytecode/BytecodeUseDef.h:
(JSC::computeUsesForBytecodeOffset):
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::dumpBytecode):
(JSC::CodeBlock::findPC):
(JSC::CodeBlock::bytecodeOffsetFromCallSiteIndex):
- bytecode/CodeBlock.h:
(JSC::CodeBlock::clearDebuggerRequests):
(JSC::CodeBlock::wasCompiledWithDebuggingOpcodes):
- bytecode/UnlinkedCodeBlock.cpp:
(JSC::UnlinkedCodeBlock::UnlinkedCodeBlock):
- bytecode/UnlinkedCodeBlock.h:
(JSC::UnlinkedCodeBlock::wasCompiledWithDebuggingOpcodes):
(JSC::UnlinkedCodeBlock::finishCreation):
(JSC::UnlinkedGlobalCodeBlock::UnlinkedGlobalCodeBlock):
- bytecode/UnlinkedFunctionExecutable.cpp:
(JSC::generateUnlinkedFunctionCodeBlock):
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::generate):
(JSC::BytecodeGenerator::BytecodeGenerator):
(JSC::BytecodeGenerator::emitEnter):
(JSC::BytecodeGenerator::emitLogShadowChickenPrologueIfNecessary):
(JSC::BytecodeGenerator::emitLogShadowChickenTailIfNecessary):
(JSC::BytecodeGenerator::emitCallDefineProperty):
- debugger/Debugger.cpp:
(JSC::DebuggerPausedScope::DebuggerPausedScope):
(JSC::DebuggerPausedScope::~DebuggerPausedScope):
(JSC::Debugger::didReachBreakpoint):
(JSC::Debugger::currentDebuggerCallFrame):
- debugger/Debugger.h:
- debugger/DebuggerCallFrame.cpp:
(JSC::LineAndColumnFunctor::operator()):
(JSC::DebuggerCallFrame::create):
(JSC::DebuggerCallFrame::DebuggerCallFrame):
(JSC::DebuggerCallFrame::callerFrame):
(JSC::DebuggerCallFrame::globalExec):
(JSC::DebuggerCallFrame::vmEntryGlobalObject):
(JSC::DebuggerCallFrame::sourceID):
(JSC::DebuggerCallFrame::functionName):
(JSC::DebuggerCallFrame::scope):
(JSC::DebuggerCallFrame::type):
(JSC::DebuggerCallFrame::thisValue):
(JSC::DebuggerCallFrame::evaluateWithScopeExtension):
(JSC::DebuggerCallFrame::invalidate):
(JSC::DebuggerCallFrame::currentPosition):
(JSC::DebuggerCallFrame::positionForCallFrame):
(JSC::DebuggerCallFrame::sourceIDForCallFrame):
(JSC::FindCallerMidStackFunctor::FindCallerMidStackFunctor): Deleted.
(JSC::FindCallerMidStackFunctor::operator()): Deleted.
(JSC::FindCallerMidStackFunctor::getCallerFrame): Deleted.
(JSC::DebuggerCallFrame::thisValueForCallFrame): Deleted.
- debugger/DebuggerCallFrame.h:
(JSC::DebuggerCallFrame::isValid):
(JSC::DebuggerCallFrame::isTailDeleted):
(JSC::DebuggerCallFrame::create): Deleted.
(JSC::DebuggerCallFrame::exec): Deleted.
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
- dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
- dfg/DFGGraph.cpp:
(JSC::DFG::Graph::Graph):
(JSC::DFG::Graph::~Graph):
- dfg/DFGJITCompiler.h:
(JSC::DFG::JITCompiler::addCallSite):
(JSC::DFG::JITCompiler::emitStoreCodeOrigin):
(JSC::DFG::JITCompiler::emitStoreCallSiteIndex):
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- ftl/FTLAbstractHeapRepository.h:
- ftl/FTLLowerDFGToB3.cpp:
(JSC::FTL::DFG::LowerDFGToB3::compileLogShadowChickenPrologue):
(JSC::FTL::DFG::LowerDFGToB3::compileLogShadowChickenTail):
(JSC::FTL::DFG::LowerDFGToB3::compileRecordRegExpCachedResult):
(JSC::FTL::DFG::LowerDFGToB3::allocateJSArray):
(JSC::FTL::DFG::LowerDFGToB3::ensureShadowChickenPacket):
(JSC::FTL::DFG::LowerDFGToB3::setupShadowChickenPacket): Deleted.
- inspector/InjectedScriptSource.js:
(InjectedScript.CallFrameProxy):
- inspector/JSJavaScriptCallFrame.cpp:
(Inspector::JSJavaScriptCallFrame::thisObject):
(Inspector::JSJavaScriptCallFrame::isTailDeleted):
(Inspector::JSJavaScriptCallFrame::type):
- inspector/JSJavaScriptCallFrame.h:
- inspector/JSJavaScriptCallFramePrototype.cpp:
(Inspector::JSJavaScriptCallFramePrototype::finishCreation):
(Inspector::jsJavaScriptCallFramePrototypeFunctionEvaluateWithScopeExtension):
(Inspector::jsJavaScriptCallFrameAttributeType):
(Inspector::jsJavaScriptCallFrameIsTailDeleted):
- inspector/JavaScriptCallFrame.h:
(Inspector::JavaScriptCallFrame::type):
(Inspector::JavaScriptCallFrame::scopeChain):
(Inspector::JavaScriptCallFrame::vmEntryGlobalObject):
(Inspector::JavaScriptCallFrame::isTailDeleted):
(Inspector::JavaScriptCallFrame::thisValue):
(Inspector::JavaScriptCallFrame::evaluateWithScopeExtension):
- inspector/ScriptDebugServer.cpp:
(Inspector::ScriptDebugServer::evaluateBreakpointAction):
- inspector/protocol/Debugger.json:
- interpreter/ShadowChicken.cpp:
(JSC::ShadowChicken::update):
(JSC::ShadowChicken::visitChildren):
(JSC::ShadowChicken::reset):
- interpreter/ShadowChicken.h:
(JSC::ShadowChicken::Packet::throwMarker):
(JSC::ShadowChicken::Packet::prologue):
(JSC::ShadowChicken::Packet::tail):
(JSC::ShadowChicken::Frame::Frame):
(JSC::ShadowChicken::Frame::operator==):
- jit/CCallHelpers.cpp:
(JSC::CCallHelpers::logShadowChickenProloguePacket):
(JSC::CCallHelpers::logShadowChickenTailPacket):
(JSC::CCallHelpers::ensureShadowChickenPacket):
(JSC::CCallHelpers::setupShadowChickenPacket): Deleted.
- jit/CCallHelpers.h:
- jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_profile_type):
(JSC::JIT::emit_op_log_shadow_chicken_prologue):
(JSC::JIT::emit_op_log_shadow_chicken_tail):
(JSC::JIT::emit_op_get_enumerable_length):
(JSC::JIT::emit_op_resume):
- jit/JITOpcodes32_64.cpp:
(JSC::JIT::emit_op_profile_type):
(JSC::JIT::emit_op_log_shadow_chicken_prologue):
(JSC::JIT::emit_op_log_shadow_chicken_tail):
- jit/RegisterSet.cpp:
(JSC::RegisterSet::webAssemblyCalleeSaveRegisters):
(JSC::RegisterSet::argumentGPRS):
(JSC::RegisterSet::registersToNotSaveForJSCall):
- jit/RegisterSet.h:
- llint/LLIntData.cpp:
(JSC::LLInt::Data::performAssertions):
- llint/LLIntSlowPaths.cpp:
(JSC::LLInt::LLINT_SLOW_PATH_DECL):
- llint/LowLevelInterpreter.asm:
- llint/LowLevelInterpreter32_64.asm:
- llint/LowLevelInterpreter64.asm:
- runtime/CodeCache.cpp:
(JSC::CodeCache::getGlobalCodeBlock):
- runtime/Options.h:
- tests/stress/shadow-chicken-enabled.js:
(test5a.foo):
(test5a):
(test5b.foo):
(test5b):
(test6.foo):
(test6):
Source/WebCore:
Tests: inspector/debugger/tail-deleted-frames-this-value.html
inspector/debugger/tail-deleted-frames.html
inspector/debugger/tail-recursion.html
- ForwardingHeaders/interpreter/ShadowChicken.h: Added.
Source/WebInspectorUI:
This patch makes the WebInspector display tail deleted frames.
We show tail deleted frames with a gray [f] instead of a green
[f]. We also put text in the tooltip to indicate that the frame
is tail deleted. Other than that, tail deleted frames behave like
normal frames. You can evaluate in them, inspect their scope, etc.
- Localizations/en.lproj/localizedStrings.js:
- UserInterface/Images/TailDeletedFunction.svg: Added.
- UserInterface/Images/gtk/TailDeletedFunction.svg: Added.
- UserInterface/Models/CallFrame.js:
- UserInterface/Views/CallFrameIcons.css:
- UserInterface/Views/CallFrameTreeElement.js:
- UserInterface/Views/CallFrameView.js:
LayoutTests:
- inspector/debugger/resources/tail-deleted-frames-this-value.js: Added.
(a):
(b):
- inspector/debugger/resources/tail-deleted-frames.js: Added.
(a):
(b):
(c):
(startABC):
- inspector/debugger/resources/tail-recursion.js: Added.
(recurse):
(startRecurse):
- inspector/debugger/tail-deleted-frames-expected.txt: Added.
- inspector/debugger/tail-deleted-frames-this-value-expected.txt: Added.
- inspector/debugger/tail-deleted-frames-this-value.html: Added.
- inspector/debugger/tail-deleted-frames.html: Added.
- inspector/debugger/tail-recursion-expected.txt: Added.
- inspector/debugger/tail-recursion.html: Added.
- 4:27 PM Changeset in webkit [200980] by
-
- 2 edits1 add in trunk/Source/JavaScriptCore
TypeSet/StructureShape have a flawed sense of JS prototype chains
https://bugs.webkit.org/show_bug.cgi?id=157760
Reviewed by Joseph Pecoraro.
There was an assumption that we would bottom out in "Object". This is
not true for many reasons. JS objects may not end in Object.prototype.
Also, our mechanism of grabbing an Object's class name may also not
bottom out in "Object". We were seeing this in the JS objects we use
in the InjectedScriptSource.js inspector script.
- runtime/TypeSet.cpp:
(JSC::StructureShape::leastCommonAncestor):
- tests/typeProfiler/weird-prototype-chain.js: Added.
(wrapper.foo):
(wrapper.let.o2):
(wrapper):
- 4:21 PM Changeset in webkit [200979] by
-
- 2 edits in trunk/Tools
build fix after r200968 and r200969
Unreviewed.
- DumpRenderTree/mac/EventSendingController.mm:
(-[EventSendingController keyDown:withModifiers:withLocation:]):
- 4:19 PM Changeset in webkit [200978] by
-
- 2 edits in trunk/Tools
API test WebKit2.MSEIsPlayingAudio timing out after r200951
https://bugs.webkit.org/show_bug.cgi?id=157748
Reviewed by Eric Carlson.
The file-with-mse.html testcase only calls play() once it's own XHR loading is complete; the
"user gesture" check fails at that point. Call play() up front; playback will begin as soon
as enough data is loaded.
- TestWebKitAPI/Tests/WebKit2/file-with-mse.html:
- 4:11 PM Changeset in webkit [200977] by
-
- 10 edits in trunk/Source/WebCore
Don't include CSSParser.h from other headers
https://bugs.webkit.org/show_bug.cgi?id=157765
Reviewed by Zalan Bujtas.
No change in behavior. This just makes it so touching CSSParser.h doesn't rebuild as many files.
- css/CSSCalculationValue.cpp:
- css/CSSParser.cpp:
(WebCore::CSSParser::sourceSize):
(WebCore::filterProperties):
- css/CSSParser.h:
(WebCore::CSSParser::ValueWithCalculation::ValueWithCalculation):
- css/CSSProperty.h:
(WebCore::prefixingVariantForPropertyId):
- css/FontFace.cpp:
- css/StyleProperties.cpp:
(WebCore::MutableStyleProperties::parseDeclaration):
(WebCore::MutableStyleProperties::addParsedProperties):
- css/StyleProperties.h:
- css/StyleResolver.h:
- rendering/style/RenderStyle.cpp:
- 4:08 PM Changeset in webkit [200976] by
-
- 3 edits2 adds in trunk
REGRESSION (r200441): Yahoo sports, finance and news pages automatically scroll
https://bugs.webkit.org/show_bug.cgi?id=157692
<rdar://problem/26231897>
Patch by Aaron Chu <aaron_chu@apple.com> on 2016-05-16
Reviewed by Eric Carlson.
Source/WebCore:
Test: media/video-controls-to-not-scroll-page-on-load.html
This bug was due to the fact that showControls button was shown and focused
when the video controls are hidden. The showControls button is used by FKA or
screen readers to make the video controls reappear after they have faded out.
When the showControls button is shown, a focus() is called on it to ensure that
the screen reader is focusing on the button instead of <body> or the video chrome.
To fix this bug, I added the shouldHaveControls() check before calling focus() on
the showControls button.
- Modules/mediacontrols/mediaControlsApple.js:
(Controller.prototype.showShowControlsButton):
LayoutTests:
Added Layout test to make sure that the page does not scroll automatically because
of the focus() on showControlsButton in the video shadow DOM.
- media/video-controls-to-not-scroll-page-on-load-expected.txt: Added.
- media/video-controls-to-not-scroll-page-on-load.html: Added.
- 3:53 PM Changeset in webkit [200975] by
-
- 2 edits in trunk/Source/WebKit2
Add a WKA extension point for WKPreferences SPI
https://bugs.webkit.org/show_bug.cgi?id=157762
rdar://problem/24529203
Reviewed by Sam Weinig.
- UIProcess/API/Cocoa/WKPreferences.mm:
- 3:44 PM Changeset in webkit [200974] by
-
- 2 edits in trunk/Source/WebKit2
Action sheets don’t work in presented view controllers
<https://webkit.org/b/157754>
<rdar://problem/26304845>
Reviewed by Anders Carlsson.
- UIProcess/ios/WKActionSheet.mm:
(-[WKActionSheet presentSheetFromRect:]):
(-[WKActionSheet willRotate]):
- Call SPI to get the presenting view controller, since it may not always be the root view controller.
- 3:31 PM Changeset in webkit [200973] by
-
- 95 edits7 copies104 adds in trunk
Unreviewed rollout r200924. Caused js/regress/string-replace-generic.html to fail.
.:
- ManualTests/inspector/profiler-test-call.html: Added.
- ManualTests/inspector/profiler-test-many-calls-in-the-same-scope.html: Added.
Source/JavaScriptCore:
- API/JSProfilerPrivate.cpp: Copied from Source/JavaScriptCore/profiler/ProfilerJettisonReason.h.
(JSStartProfiling):
(JSEndProfiling):
- API/JSProfilerPrivate.h: Copied from Source/JavaScriptCore/profiler/ProfilerJettisonReason.h.
- CMakeLists.txt:
- JavaScriptCore.xcodeproj/project.pbxproj:
- bytecode/BytecodeList.json:
- bytecode/BytecodeUseDef.h:
(JSC::computeUsesForBytecodeOffset):
(JSC::computeDefsForBytecodeOffset):
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::dumpBytecode):
- bytecode/UnlinkedFunctionExecutable.cpp:
(JSC::generateUnlinkedFunctionCodeBlock):
(JSC::UnlinkedFunctionExecutable::unlinkedCodeBlockFor):
- bytecode/UnlinkedFunctionExecutable.h:
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::BytecodeGenerator):
(JSC::BytecodeGenerator::emitCall):
(JSC::BytecodeGenerator::emitCallVarargs):
(JSC::BytecodeGenerator::emitCallVarargsInTailPosition):
(JSC::BytecodeGenerator::emitConstructVarargs):
(JSC::BytecodeGenerator::emitConstruct):
- bytecompiler/BytecodeGenerator.h:
(JSC::CallArguments::profileHookRegister):
(JSC::BytecodeGenerator::shouldEmitProfileHooks):
- bytecompiler/NodesCodegen.cpp:
(JSC::CallArguments::CallArguments):
(JSC::CallFunctionCallDotNode::emitBytecode):
(JSC::ApplyFunctionCallDotNode::emitBytecode):
- dfg/DFGAbstractInterpreterInlines.h:
(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
- dfg/DFGCapabilities.cpp:
(JSC::DFG::capabilityLevel):
- dfg/DFGClobberize.h:
(JSC::DFG::clobberize):
- dfg/DFGDoesGC.cpp:
(JSC::DFG::doesGC):
- dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
- dfg/DFGNodeType.h:
- dfg/DFGPredictionPropagationPhase.cpp:
- dfg/DFGSafeToExecute.h:
(JSC::DFG::safeToExecute):
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- inspector/InjectedScriptBase.cpp:
(Inspector::InjectedScriptBase::callFunctionWithEvalEnabled):
- inspector/protocol/Timeline.json:
- interpreter/Interpreter.cpp:
(JSC::UnwindFunctor::operator()):
(JSC::Interpreter::execute):
(JSC::Interpreter::executeCall):
(JSC::Interpreter::executeConstruct):
- jit/JIT.cpp:
(JSC::JIT::privateCompileMainPass):
- jit/JIT.h:
- jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_profile_will_call):
(JSC::JIT::emit_op_profile_did_call):
- jit/JITOpcodes32_64.cpp:
(JSC::JIT::emit_op_profile_will_call):
(JSC::JIT::emit_op_profile_did_call):
- jit/JITOperations.cpp:
- jit/JITOperations.h:
- jsc.cpp:
- llint/LLIntSlowPaths.cpp:
(JSC::LLInt::LLINT_SLOW_PATH_DECL):
- llint/LLIntSlowPaths.h:
- llint/LowLevelInterpreter.asm:
- parser/ParserModes.h:
- profiler/CallIdentifier.h: Added.
(JSC::CallIdentifier::CallIdentifier):
(JSC::CallIdentifier::functionName):
(JSC::CallIdentifier::url):
(JSC::CallIdentifier::lineNumber):
(JSC::CallIdentifier::columnNumber):
(JSC::CallIdentifier::operator==):
(JSC::CallIdentifier::operator!=):
(JSC::CallIdentifier::Hash::hash):
(JSC::CallIdentifier::Hash::equal):
(JSC::CallIdentifier::hash):
(JSC::CallIdentifier::operator const char*):
(JSC::CallIdentifier::c_str):
(WTF::HashTraits<JSC::CallIdentifier>::constructDeletedValue):
(WTF::HashTraits<JSC::CallIdentifier>::isDeletedValue):
- profiler/LegacyProfiler.cpp: Added.
(JSC::LegacyProfiler::profiler):
(JSC::LegacyProfiler::startProfiling):
(JSC::LegacyProfiler::stopProfiling):
(JSC::callFunctionForProfilesWithGroup):
(JSC::LegacyProfiler::suspendProfiling):
(JSC::LegacyProfiler::unsuspendProfiling):
(JSC::LegacyProfiler::willExecute):
(JSC::LegacyProfiler::didExecute):
(JSC::LegacyProfiler::exceptionUnwind):
(JSC::LegacyProfiler::createCallIdentifier):
(JSC::createCallIdentifierFromFunctionImp):
- profiler/LegacyProfiler.h: Added.
(JSC::LegacyProfiler::currentProfiles):
- profiler/Profile.cpp: Added.
(JSC::Profile::create):
(JSC::Profile::Profile):
(JSC::Profile::~Profile):
(JSC::Profile::debugPrint):
(JSC::functionNameCountPairComparator):
(JSC::Profile::debugPrintSampleStyle):
- profiler/Profile.h: Copied from Source/JavaScriptCore/profiler/ProfilerJettisonReason.h.
- profiler/ProfileGenerator.cpp: Added.
(JSC::ProfileGenerator::create):
(JSC::ProfileGenerator::ProfileGenerator):
(JSC::AddParentForConsoleStartFunctor::AddParentForConsoleStartFunctor):
(JSC::AddParentForConsoleStartFunctor::foundParent):
(JSC::AddParentForConsoleStartFunctor::operator()):
(JSC::ProfileGenerator::addParentForConsoleStart):
(JSC::ProfileGenerator::title):
(JSC::ProfileGenerator::beginCallEntry):
(JSC::ProfileGenerator::endCallEntry):
(JSC::ProfileGenerator::willExecute):
(JSC::ProfileGenerator::didExecute):
(JSC::ProfileGenerator::exceptionUnwind):
(JSC::ProfileGenerator::stopProfiling):
(JSC::ProfileGenerator::removeProfileStart):
(JSC::ProfileGenerator::removeProfileEnd):
- profiler/ProfileGenerator.h: Added.
(JSC::ProfileGenerator::profile):
(JSC::ProfileGenerator::origin):
(JSC::ProfileGenerator::profileGroup):
(JSC::ProfileGenerator::setIsSuspended):
- profiler/ProfileNode.cpp: Added.
(JSC::ProfileNode::ProfileNode):
(JSC::ProfileNode::addChild):
(JSC::ProfileNode::removeChild):
(JSC::ProfileNode::spliceNode):
(JSC::ProfileNode::traverseNextNodePostOrder):
(JSC::ProfileNode::debugPrint):
(JSC::ProfileNode::debugPrintSampleStyle):
(JSC::ProfileNode::debugPrintRecursively):
(JSC::ProfileNode::debugPrintSampleStyleRecursively):
- profiler/ProfileNode.h: Added.
(JSC::ProfileNode::create):
(JSC::ProfileNode::Call::Call):
(JSC::ProfileNode::Call::startTime):
(JSC::ProfileNode::Call::setStartTime):
(JSC::ProfileNode::Call::elapsedTime):
(JSC::ProfileNode::Call::setElapsedTime):
(JSC::ProfileNode::operator==):
(JSC::ProfileNode::callerCallFrame):
(JSC::ProfileNode::callIdentifier):
(JSC::ProfileNode::id):
(JSC::ProfileNode::functionName):
(JSC::ProfileNode::url):
(JSC::ProfileNode::lineNumber):
(JSC::ProfileNode::columnNumber):
(JSC::ProfileNode::parent):
(JSC::ProfileNode::setParent):
(JSC::ProfileNode::calls):
(JSC::ProfileNode::lastCall):
(JSC::ProfileNode::appendCall):
(JSC::ProfileNode::children):
(JSC::ProfileNode::firstChild):
(JSC::ProfileNode::lastChild):
(JSC::ProfileNode::nextSibling):
(JSC::ProfileNode::setNextSibling):
(JSC::ProfileNode::forEachNodePostorder):
(JSC::CalculateProfileSubtreeDataFunctor::operator()):
(JSC::CalculateProfileSubtreeDataFunctor::returnValue):
- profiler/ProfilerJettisonReason.cpp:
(WTF::printInternal):
- profiler/ProfilerJettisonReason.h:
- runtime/CodeCache.cpp:
(JSC::CodeCache::getGlobalCodeBlock):
(JSC::CodeCache::getProgramCodeBlock):
(JSC::CodeCache::getEvalCodeBlock):
(JSC::CodeCache::getModuleProgramCodeBlock):
- runtime/CodeCache.h:
- runtime/Executable.cpp:
(JSC::ScriptExecutable::newCodeBlockFor):
- runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::~JSGlobalObject):
(JSC::JSGlobalObject::hasLegacyProfiler):
(JSC::JSGlobalObject::createProgramCodeBlock):
(JSC::JSGlobalObject::createEvalCodeBlock):
(JSC::JSGlobalObject::createModuleProgramCodeBlock):
- runtime/JSGlobalObject.h:
(JSC::JSGlobalObject::supportsLegacyProfiling):
- runtime/Options.h:
- runtime/VM.cpp:
(JSC::VM::VM):
(JSC::SetEnabledProfilerFunctor::operator()):
(JSC::VM::setEnabledProfiler):
- runtime/VM.h:
(JSC::VM::enabledProfiler):
(JSC::VM::enabledProfilerAddress):
Source/WebCore:
Tests: fast/profiler/*
- CMakeLists.txt:
- DerivedSources.cpp:
- DerivedSources.make:
- ForwardingHeaders/profiler/LegacyProfiler.h: Added.
- ForwardingHeaders/profiler/Profile.h: Added.
- ForwardingHeaders/profiler/ProfileNode.h: Added.
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSCustomXPathNSResolver.cpp:
- bindings/js/JSDOMWindowBase.cpp:
(WebCore::JSDOMWindowBase::supportsLegacyProfiling):
(WebCore::JSDOMWindowBase::supportsRichSourceInfo):
- bindings/js/JSDOMWindowBase.h:
- bindings/js/JSWorkerGlobalScopeBase.cpp:
(WebCore::JSWorkerGlobalScopeBase::supportsLegacyProfiling):
- bindings/js/JSWorkerGlobalScopeBase.h:
- bindings/js/ScriptCachedFrameData.cpp:
- bindings/js/ScriptController.cpp:
(WebCore::ScriptController::clearWindowShell):
- bindings/js/ScriptProfile.h: Copied from Source/JavaScriptCore/profiler/ProfilerJettisonReason.h.
- bindings/js/ScriptProfileNode.h: Copied from Source/JavaScriptCore/profiler/ProfilerJettisonReason.h.
- bindings/scripts/CodeGeneratorJS.pm:
(AddClassForwardIfNeeded):
- bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::jsTestObjPrototypeFunctionMethodWithSequenceArg):
(WebCore::jsTestObjPrototypeFunctionMethodReturningSequence):
- bindings/scripts/test/TestObj.idl:
- css/CSSParser.cpp:
- dom/Document.cpp:
- inspector/InspectorConsoleInstrumentation.h:
(WebCore::InspectorInstrumentation::stopProfiling):
- inspector/InspectorController.cpp:
(WebCore::InspectorController::InspectorController):
(WebCore::InspectorController::legacyProfilerEnabled):
(WebCore::InspectorController::setLegacyProfilerEnabled):
- inspector/InspectorController.h:
- inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::stopProfilingImpl):
- inspector/InspectorInstrumentation.h:
- inspector/InspectorTimelineAgent.cpp:
(WebCore::InspectorTimelineAgent::startFromConsole):
(WebCore::InspectorTimelineAgent::stopFromConsole):
- inspector/InspectorTimelineAgent.h:
- inspector/PageDebuggerAgent.cpp:
- inspector/PageRuntimeAgent.cpp:
- inspector/ScriptProfile.idl: Copied from Source/JavaScriptCore/profiler/ProfilerJettisonReason.h.
- inspector/ScriptProfileNode.idl: Copied from Source/JavaScriptCore/profiler/ProfilerJettisonReason.h.
- inspector/TimelineRecordFactory.cpp:
(WebCore::buildAggregateCallInfoInspectorObject):
(WebCore::buildInspectorObject):
(WebCore::buildProfileInspectorObject):
(WebCore::TimelineRecordFactory::appendProfile):
- inspector/TimelineRecordFactory.h:
- page/DOMWindow.cpp:
- page/Page.cpp:
- page/PageConsoleClient.cpp:
(WebCore::PageConsoleClient::profileEnd):
(WebCore::PageConsoleClient::clearProfiles):
- page/PageConsoleClient.h:
- testing/Internals.cpp:
(WebCore::Internals::resetToConsistentState):
(WebCore::Internals::consoleProfiles):
(WebCore::Internals::setLegacyJavaScriptProfilingEnabled):
- testing/Internals.h:
- testing/Internals.idl:
- testing/js/WebCoreTestSupport.cpp:
- xml/XSLStyleSheetLibxslt.cpp:
- xml/XSLTProcessorLibxslt.cpp:
Source/WebKit/win:
- Interfaces/IWebInspector.idl:
- WebCoreStatistics.cpp:
- WebInspector.cpp:
(WebInspector::isJavaScriptProfilingEnabled):
(WebInspector::setJavaScriptProfilingEnabled):
- WebInspector.h:
- WebView.cpp:
LayoutTests:
- fast/profiler/anonymous-event-handler-expected.txt: Added.
- fast/profiler/anonymous-event-handler.html: Added.
- fast/profiler/anonymous-function-called-from-different-contexts-expected.txt: Added.
- fast/profiler/anonymous-function-called-from-different-contexts.html: Added.
- fast/profiler/anonymous-function-calls-built-in-functions-expected.txt: Added.
- fast/profiler/anonymous-function-calls-built-in-functions.html: Added.
- fast/profiler/anonymous-function-calls-eval-expected.txt: Added.
- fast/profiler/anonymous-function-calls-eval.html: Added.
- fast/profiler/anonymous-functions-with-display-names-expected.txt: Added.
- fast/profiler/anonymous-functions-with-display-names.html: Added.
- fast/profiler/apply-expected.txt: Added.
- fast/profiler/apply.html: Added.
- fast/profiler/built-in-function-calls-anonymous-expected.txt: Added.
- fast/profiler/built-in-function-calls-anonymous.html: Added.
- fast/profiler/built-in-function-calls-user-defined-function-expected.txt: Added.
- fast/profiler/built-in-function-calls-user-defined-function.html: Added.
- fast/profiler/call-expected.txt: Added.
- fast/profiler/call-register-leak-expected.txt: Added.
- fast/profiler/call-register-leak.html: Added.
- fast/profiler/call.html: Added.
- fast/profiler/calling-the-function-that-started-the-profiler-from-another-scope-expected.txt: Added.
- fast/profiler/calling-the-function-that-started-the-profiler-from-another-scope.html: Added.
- fast/profiler/compare-multiple-profiles-expected.txt: Added.
- fast/profiler/compare-multiple-profiles.html: Added.
- fast/profiler/constructor-expected.txt: Added.
- fast/profiler/constructor.html: Added.
- fast/profiler/dead-time-expected.txt: Added.
- fast/profiler/dead-time.html: Added.
- fast/profiler/document-dot-write-expected.txt: Added.
- fast/profiler/document-dot-write.html: Added.
- fast/profiler/event-handler-expected.txt: Added.
- fast/profiler/event-handler.html: Added.
- fast/profiler/execution-context-and-eval-on-same-line-expected.txt: Added.
- fast/profiler/execution-context-and-eval-on-same-line.html: Added.
- fast/profiler/inline-event-handler-expected.txt: Added.
- fast/profiler/inline-event-handler.html: Added.
- fast/profiler/many-calls-in-the-same-scope-expected.txt: Added.
- fast/profiler/many-calls-in-the-same-scope.html: Added.
- fast/profiler/multiple-and-different-scoped-anonymous-function-calls-expected.txt: Added.
- fast/profiler/multiple-and-different-scoped-anonymous-function-calls.html: Added.
- fast/profiler/multiple-and-different-scoped-function-calls-expected.txt: Added.
- fast/profiler/multiple-and-different-scoped-function-calls.html: Added.
- fast/profiler/multiple-anonymous-functions-called-from-the-same-function-expected.txt: Added.
- fast/profiler/multiple-anonymous-functions-called-from-the-same-function.html: Added.
- fast/profiler/multiple-frames-expected.txt: Added.
- fast/profiler/multiple-frames.html: Added.
- fast/profiler/named-functions-with-display-names-expected.txt: Added.
- fast/profiler/named-functions-with-display-names.html: Added.
- fast/profiler/nested-anonymous-functon-expected.txt: Added.
- fast/profiler/nested-anonymous-functon.html: Added.
- fast/profiler/nested-start-and-stop-profiler-expected.txt: Added.
- fast/profiler/nested-start-and-stop-profiler.html: Added.
- fast/profiler/no-execution-context-expected.txt: Added.
- fast/profiler/no-execution-context.html: Added.
- fast/profiler/one-execution-context-expected.txt: Added.
- fast/profiler/one-execution-context.html: Added.
- fast/profiler/profile-calls-in-included-file-expected.txt: Added.
- fast/profiler/profile-calls-in-included-file.html: Added.
- fast/profiler/profile-with-no-title-expected.txt: Added.
- fast/profiler/profile-with-no-title.html: Added.
- fast/profiler/profiling-from-a-nested-location-but-stop-profiling-outside-the-nesting-expected.txt: Added.
- fast/profiler/profiling-from-a-nested-location-but-stop-profiling-outside-the-nesting.html: Added.
- fast/profiler/profiling-from-a-nested-location-expected.txt: Added.
- fast/profiler/profiling-from-a-nested-location.html: Added.
- fast/profiler/resources/other-frame.html: Added.
- fast/profiler/resources/other-window.html: Added.
- fast/profiler/resources/profiler-test-JS-resources.js: Added.
(endTest):
(insertGivenText):
(insertNewText):
(arrayOperatorFunction):
(anonymousFunction):
(anotherAnonymousFunction):
(intermediaryFunction):
(isEqualToFive):
(startProfile):
(printHeavyProfilesDataWithoutTime):
(printProfilesDataWithoutTime):
(printProfileNodeWithoutTime):
- fast/profiler/simple-event-call-expected.txt: Added.
- fast/profiler/simple-event-call.html: Added.
- fast/profiler/simple-no-level-change-expected.txt: Added.
- fast/profiler/simple-no-level-change.html: Added.
- fast/profiler/start-and-stop-profiler-multiple-times-expected.txt: Added.
- fast/profiler/start-and-stop-profiler-multiple-times.html: Added.
- fast/profiler/start-and-stop-profiling-in-the-same-function-expected.txt: Added.
- fast/profiler/start-and-stop-profiling-in-the-same-function.html: Added.
- fast/profiler/start-but-dont-stop-profiling-expected.txt: Added.
- fast/profiler/start-but-dont-stop-profiling.html: Added.
- fast/profiler/stop-profiling-after-setTimeout-expected.txt: Added.
- fast/profiler/stop-profiling-after-setTimeout.html: Added.
- fast/profiler/stop-then-function-call-expected.txt: Added.
- fast/profiler/stop-then-function-call.html: Added.
- fast/profiler/throw-exception-from-eval-expected.txt: Added.
- fast/profiler/throw-exception-from-eval.html-disabled: Added.
- fast/profiler/two-execution-contexts-expected.txt: Added.
- fast/profiler/two-execution-contexts.html: Added.
- fast/profiler/user-defined-function-calls-built-in-functions-expected.txt: Added.
- fast/profiler/user-defined-function-calls-built-in-functions.html: Added.
- fast/profiler/window-dot-eval-expected.txt: Added.
- fast/profiler/window-dot-eval.html: Added.
- platform/efl/TestExpectations:
- platform/gtk/TestExpectations:
- platform/ios-simulator/TestExpectations:
- 3:20 PM Changeset in webkit [200972] by
-
- 2 edits in trunk/Source/WebKit2
Text selection is basically impossible on plain text pages.
https://bugs.webkit.org/show_bug.cgi?id=157681
rdar://problem/26065660
Reviewed by Darin Adler.
When dealing with a plain text file, the rules for deciding whether
a position is selectable should be different and we should never
switch to block selection.
- WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::shouldSwitchToBlockModeForHandle):
(WebKit::rectIsTooBigForSelection): Added helper function.
(WebKit::WebPage::selectTextWithGranularityAtPoint):
(WebKit::WebPage::getPositionInformation):
- 3:00 PM Changeset in webkit [200971] by
-
- 2 edits in trunk/Source/WebCore
RenderLayer::hitTestList could mutate the list of candidate layers.
https://bugs.webkit.org/show_bug.cgi?id=157718
<rdar://problem/22556046>
Reviewed by Simon Fraser.
This patch ensures that we always start hittesting a clean render tree at EventHandler::hitTestResultAtPoint.
Speculative fix.
- page/EventHandler.cpp:
(WebCore::EventHandler::hitTestResultAtPoint):
- 2:53 PM Changeset in webkit [200970] by
-
- 2 edits in trunk/Source/JavaScriptCore
Unreviewed, fixed typo in a comment.
- 2:42 PM Changeset in webkit [200969] by
-
- 2 edits in trunk/Source/WebKit/mac
Remove unused initializer for WebEvent on iOS.
https://bugs.webkit.org/show_bug.cgi?id=157689
Reviewed by Anders Carlsson.
Removing use of characterSet property.
- WebView/WebHTMLView.mm:
(-[WebHTMLView _handleEditingKeyEvent:]):
- 2:39 PM Changeset in webkit [200968] by
-
- 5 edits in trunk
Remove unused initializer for WebEvent on iOS.
https://bugs.webkit.org/show_bug.cgi?id=157689
Reviewed by Anders Carlsson.
Source/WebCore:
This is no longer used and can be removed.
The logic tied to isPopupVariant has been incorporated
in keyboard flags. The characterSet property is no longer needed too.
- platform/ios/WebEvent.h:
- platform/ios/WebEvent.mm:
(-[WebEvent initWithKeyEventType:timeStamp:characters:charactersIgnoringModifiers:modifiers:isRepeating:withFlags:keyCode:isTabKey:characterSet:]):
(-[WebEvent initWithKeyEventType:timeStamp:characters:charactersIgnoringModifiers:modifiers:isRepeating:isPopupVariant:keyCode:isTabKey:characterSet:]): Deleted.
(-[WebEvent _characterSetDescription]): Deleted.
(-[WebEvent isPopupVariant]): Deleted.
(-[WebEvent characterSet]): Deleted.
Tools:
Adopting different initializer for WebEvent to fix the build.
- DumpRenderTree/mac/EventSendingController.mm:
(-[EventSendingController keyDown:withModifiers:withLocation:]):
- 2:36 PM Changeset in webkit [200967] by
-
- 5 edits in trunk/Source/WebCore
Add a WebCore logging channel for images
https://bugs.webkit.org/show_bug.cgi?id=157752
Reviewed by Zalan Bujtas.
Create an Images log channel, and log various things related to decoding and drawing
images.
- platform/Logging.h:
- platform/graphics/BitmapImage.cpp:
(WebCore::BitmapImage::destroyDecodedDataIfNecessary):
(WebCore::BitmapImage::cacheFrame):
(WebCore::BitmapImage::startAnimation):
- platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::GraphicsContext::drawNativeImage):
- platform/graphics/cg/ImageDecoderCG.cpp:
(WebCore::ImageDecoder::createFrameImageAtIndex):
- 1:52 PM Changeset in webkit [200966] by
-
- 2 edits in trunk/Source/WebKit2
[iOS] Remove dispatch_after in -[WKFormInputSession setSuggestions:]
https://bugs.webkit.org/show_bug.cgi?id=157745
Patch by Chelsea Pugh <cpugh@apple.com> on 2016-05-16
Reviewed by Dan Bernstein.
- UIProcess/ios/WKContentViewInteraction.mm:
(-[WKFormInputSession setSuggestions:]): Remove the dispatch_after since
there is no longer a chance of keyboard suggestions replacing the
suggestions set here.
- 1:46 PM Changeset in webkit [200965] by
-
- 3 edits in trunk/Source/WebCore
Don't execute JavaScript within HTMLMediaElement::stop()
https://bugs.webkit.org/show_bug.cgi?id=157655
Reviewed by Chris Dumez.
- dom/ScriptExecutionContext.cpp:
(WebCore::ScriptExecutionContext::suspendActiveDOMObjects):
Move the setting of m_activeDOMObjectsAreSuspended to true earlier so we won't execute
any JS while suspending the objects.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::updateMediaControlsAfterPresentationModeChange):
Bail early if the controls script hasn't been injected yet or the DOM object has been
stopped or suspended.
- 1:26 PM Changeset in webkit [200964] by
-
- 9 edits4 adds in trunk
Focus ordering should respect slot elements
https://bugs.webkit.org/show_bug.cgi?id=151379
Reviewed by Antti Koivisto.
Source/WebCore:
Implemented the sequential focus navigation ordering as discussed on
https://github.com/w3c/webcomponents/issues/375
New behavior treats each shadow root and slot as a "focus scope". The focus navigation ordering
is defined within each "focus scope" using tabindex, treating any "focus scope owner"
(e.g. shadow host or a slot) as if it was having tabindex=0 if it wasn't itself focusable.
This patch modifies FocusNavigationScope to support a focus scope defined for a slot element in
addition to the one defined for a shadow tree and a document as previously supported.
Tests: fast/shadow-dom/focus-across-details-element.html
fast/shadow-dom/focus-navigation-across-slots.html
- dom/Node.cpp:
(WebCore::parentShadowRoot): Extracted from assignedSlot.
(WebCore::Node::assignedSlot):
(WebCore::Node::assignedSlotForBindings): Added.
- dom/Node.h:
- dom/NonDocumentTypeChildNode.idl:
- html/HTMLDetailsElement.h:
(HTMLDetailsElement::hasCustomFocusLogic): Added. Don't treat details element as a "focus scope".
- html/HTMLSummaryElement.h:
(HTMLSummaryElement::hasCustomFocusLogic): Ditto for summary element.
- page/FocusController.cpp:
(WebCore::hasCustomFocusLogic): Moved.
(WebCore::isFocusScopeOwner): Added. Returns true on a shadow host without a custom focus logic or
on a slot inside a shadow tree whose shadow host doesn't have a custom focus logic.
(WebCore::FocusNavigationScope::firstChildInScope): Now takes a reference. Call isFocusScopeOwner
to check for both slots and shadow roots instead of just the latter. This fixes a subtle bug that
focus may never get out of textarea in some cases due to its failure to check hasCustomFocusLogic.
(WebCore::FocusNavigationScope::lastChildInScope): Ditto.
(WebCore::FocusNavigationScope::parentInScope): Made this a member function since it needs to check
against m_slotElement inside the focus scope of a slot.
(WebCore::FocusNavigationScope::nextSiblingInScope): Added. Finds the next assigned node in a slot
in the focus scope defined for a slot. Just calls nextSibling() in the focus scope for shadow tree
and document.
(WebCore::FocusNavigationScope::previousSiblingInScope): Ditto for finding the previous sibling.
(WebCore::FocusNavigationScope::firstNodeInScope): Added. This function replaces rootNode() which
doesn't exist for the focus scope of a slot element.
(WebCore::FocusNavigationScope::lastNodeInScope): Ditto for the last node.
(WebCore::FocusNavigationScope::nextInScope):
(WebCore::FocusNavigationScope::previousInScope):
(WebCore::FocusNavigationScope::FocusNavigationScope): Added a variant that takes HTMLSlotElement.
(WebCore::FocusNavigationScope::owner): Added the support for slot elements.
(WebCore::FocusNavigationScope::scopeOf): Ditto.
(WebCore::FocusNavigationScope::scopeOwnedByScopeOwner): Ditto.
(WebCore::isFocusableElementOrScopeOwner): Added the support for slot elements and renamed from
isFocusableOrHasShadowTreeWithoutCustomFocusLogic.
(WebCore::isNonFocusableScopeOwner): Ditto. Renamed from isNonFocusableShadowHost.
(WebCore::isFocusableScopeOwner): Ditto. Renamed from isFocusableShadowHost.
(WebCore::shadowAdjustedTabIndex): Added the support for slot elements.
(WebCore::FocusController::findFocusableElementAcrossFocusScope):
(WebCore::FocusController::nextFocusableElementWithinScope):
(WebCore::FocusController::previousFocusableElementWithinScope):
(WebCore::FocusController::findElementWithExactTabIndex):
(WebCore::nextElementWithGreaterTabIndex): Call firstNodeInScope() instead of rootNode() here since
there is no root node for the focus scope defined for a slot element.
(WebCore::previousElementWithLowerTabIndex): Ditto for scope.lastNodeInScope().
(WebCore::FocusController::nextFocusableElementOrScopeOwner):
(WebCore::FocusController::previousFocusableElementOrScopeOwner):
(WebCore::parentInScope): Deleted.
(WebCore::FocusNavigationScope::rootNode): Deleted.
(WebCore::FocusNavigationScope::scopeOwnedByShadowHost): Deleted.
(WebCore::isNonFocusableShadowHost): Deleted.
(WebCore::isFocusableShadowHost): Deleted.
(WebCore::isFocusableOrHasShadowTreeWithoutCustomFocusLogic): Deleted.
LayoutTests:
Added regression tests for moving focus by tab and shift+tab across
user-defined shadow trees with slots and details element.
- fast/shadow-dom/focus-across-details-element-expected.txt: Added.
- fast/shadow-dom/focus-across-details-element.html: Added.
- fast/shadow-dom/focus-navigation-across-slots-expected.txt: Added.
- fast/shadow-dom/focus-navigation-across-slots.html: Added.
- 1:24 PM Changeset in webkit [200963] by
-
- 3 edits in trunk/Source/WebCore
Use WTF::Optional for ScrollView's m_deferredScrollDelta / m_deferredScrollOffsets
https://bugs.webkit.org/show_bug.cgi?id=157747
Reviewed by Zalan Bujtas.
Use WTF::Optional for ScrollView's m_deferredScrollDelta / m_deferredScrollOffsets
instead of std::unique_ptr as it is more suited for this purpose.
- platform/ScrollView.cpp:
(WebCore::ScrollView::scrollOffsetChangedViaPlatformWidget):
(WebCore::ScrollView::handleDeferredScrollUpdateAfterContentSizeChange):
(WebCore::ScrollView::scrollTo):
- platform/ScrollView.h:
- 1:19 PM Changeset in webkit [200962] by
-
- 3 edits in trunk/Source/WebInspectorUI
Web Inspector: Contents of Duration column are covered by always on (legacy) scroll bars
https://bugs.webkit.org/show_bug.cgi?id=157590
Reviewed by Timothy Hatcher.
Set the right padding of the DataGrid header to match the scrollbar width.
- UserInterface/Views/DataGrid.css:
(.data-grid .data-container):
(.data-grid.inline .data-container):
Don't show scrollbars for inline data grids.
(.data-grid > .header-wrapper):
(.data-grid.no-header > .header-wrapper > table.header):
(.data-grid.no-header > table.header): Deleted.
(.data-grid th): Deleted.
- UserInterface/Views/DataGrid.js:
(WebInspector.DataGrid):
We can't add padding-rigth to a table. Wrap the table in div.header-wrapper.
(WebInspector.DataGrid.prototype._updateScrollbarPadding):
(WebInspector.DataGrid.prototype.layout):
- 1:01 PM Changeset in webkit [200961] by
-
- 2 edits in trunk/Source/WebKit2
Crash simulating keystrokes at WebKit::WebAutomationSession::platformSimulateKeyStroke
https://bugs.webkit.org/show_bug.cgi?id=157737
<rdar://problem/26292946>
Reviewed by Timothy Hatcher.
- UIProcess/Cocoa/WebAutomationSessionCocoa.mm:
(WebKit::WebAutomationSession::platformSimulateKeyStroke):
AppKit expects characters passed to [NSEvent keyEventWithType:...]
to be non-nil even if there are no characters. Initialize characters
to the empty string @"". It will be overwritten if the keystroke should
produce any unicode characters.
- 12:57 PM Changeset in webkit [200960] by
-
- 3 edits in trunk/LayoutTests
Rebaseline tests for ios-simulator
Unreviewed test gardening.
- fast/events/touch/document-create-touch-list-ios-expected.txt:
- platform/ios-simulator/ios/touch/construct-TouchList-expected.txt:
- 12:53 PM Changeset in webkit [200959] by
-
- 6 edits in trunk/Source/WebKit2
Web Automation: Automation.inspectBrowsingContext should automatically start page profiling
https://bugs.webkit.org/show_bug.cgi?id=157739
Reviewed by Timothy Hatcher.
- UIProcess/API/C/WKInspector.cpp:
(WKInspectorTogglePageProfiling):
Implicitly show the Web Inspector in the C API command to preserve existing behavior.
- UIProcess/Automation/WebAutomationSession.cpp:
(WebKit::WebAutomationSession::inspectorFrontendLoaded):
If the frontend loaded, it was either because the user opened Web Inspector (and
turning on page profiling is harmless), or it was loaded but not shown by the
inspectBrowsingContext command. For the latter, we want to start page profiling
before processing any additional commands so subsequent execution is captured.
- UIProcess/WebInspectorProxy.cpp:
(WebKit::WebInspectorProxy::togglePageProfiling):
Send the start/stop profiling messages directly to the WebInspectorUI process instead of
bouncing through the inspected page's process, which does an implicit show() we don't want.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::inspector): Make it const.
- UIProcess/WebPageProxy.h:
- 12:41 PM Changeset in webkit [200958] by
-
- 3 edits21 adds in trunk
FixupPhase should be more eager to demote bit math to untyped
https://bugs.webkit.org/show_bug.cgi?id=157746
Reviewed by Mark Lam.
Source/JavaScriptCore:
This just makes the logic for how we fixup bit math match the way we do it in other places.
This doesn't affect performance on any major benchmark but it's a big win on new
microbenchmarks added in this change.
Details:
object-and 11.1610+-0.7602 4.8105+-0.1690 definitely 2.3201x faster
object-or 11.0845+-0.2487 4.7146+-0.0374 definitely 2.3511x faster
object-xor 10.2946+-0.9946 4.7278+-0.0814 definitely 2.1775x faster
object-lshift 10.4896+-1.0867 4.7699+-0.0721 definitely 2.1991x faster
object-rshift 11.1239+-0.5010 4.7194+-0.0445 definitely 2.3570x faster
object-urshift 10.9745+-0.1315 4.7848+-0.0479 definitely 2.2936x faster
- dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
LayoutTests:
- js/regress/object-and-expected.txt: Added.
- js/regress/object-and.html: Added.
- js/regress/object-int-and-array-expected.txt: Added.
- js/regress/object-int-and-array.html: Added.
- js/regress/object-lshift-expected.txt: Added.
- js/regress/object-lshift.html: Added.
- js/regress/object-or-expected.txt: Added.
- js/regress/object-or.html: Added.
- js/regress/object-rshift-expected.txt: Added.
- js/regress/object-rshift.html: Added.
- js/regress/object-urshift-expected.txt: Added.
- js/regress/object-urshift.html: Added.
- js/regress/object-xor-expected.txt: Added.
- js/regress/object-xor.html: Added.
- js/regress/script-tests/object-and.js: Added.
(o.valueOf):
- js/regress/script-tests/object-int-and-array.js: Added.
(i.o.valueOf):
- js/regress/script-tests/object-lshift.js: Added.
(o.valueOf):
- js/regress/script-tests/object-or.js: Added.
(o.valueOf):
- js/regress/script-tests/object-rshift.js: Added.
(o.valueOf):
- js/regress/script-tests/object-urshift.js: Added.
(o.valueOf):
- js/regress/script-tests/object-xor.js: Added.
(o.valueOf):
- 12:20 PM Changeset in webkit [200957] by
-
- 8 edits in trunk/Source/WebKit2
Fix some deprecation warnings.
- UIProcess/mac/WKPrintingView.mm:
(-[WKPrintingView _drawPDFDocument:page:atPoint:]):
- WebProcess/Plugins/PDF/DeprecatedPDFPlugin.mm:
(WebKit::PDFPlugin::setActiveAnnotation):
(WebKit::PDFPlugin::lookupTextAtLocation):
- WebProcess/Plugins/PDF/PDFPluginChoiceAnnotation.h:
- WebProcess/Plugins/PDF/PDFPluginChoiceAnnotation.mm:
(WebKit::PDFPluginChoiceAnnotation::createAnnotationElement):
- WebProcess/Plugins/PDF/PDFPluginTextAnnotation.h:
- WebProcess/Plugins/PDF/PDFPluginTextAnnotation.mm:
(WebKit::PDFPluginTextAnnotation::createAnnotationElement):
- WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::drawPDFPage):
- 11:57 AM Changeset in webkit [200956] by
-
- 3 edits in trunk/Tools
Add machine-readable results for JSC API tests to the Buildbot json log
https://bugs.webkit.org/show_bug.cgi?id=157642
Patch by Srinivasan Vijayaraghavan <svijayaraghavan@apple.com> on 2016-05-16
Reviewed by Geoffrey Garen.
- BuildSlaveSupport/build.webkit.org-config/master.cfg:
(RunJavaScriptCoreTests): Use --no-fail-fast option on run-javascriptcore-tests
- Scripts/run-javascriptcore-tests:
(runJSCStressTests): Abstracted out writing JSON to file (new function below)
(writeJsonDataIfApplicable): Added
- 11:54 AM Changeset in webkit [200955] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Background stripes don't span the width of Network sidebar
https://bugs.webkit.org/show_bug.cgi?id=157744
Reviewed by Timothy Hatcher.
- UserInterface/Views/NetworkSidebarPanel.css:
(.sidebar > .panel.navigation.network.network-grid-content-view-showing > .content):
- 11:47 AM Changeset in webkit [200954] by
-
- 2 edits in branches/safari-602.1.32-branch/Source/JavaScriptCore
Merged r200693. rdar://problem/25682844
- 11:44 AM Changeset in webkit [200953] by
-
- 9 edits in trunk/Source/WebCore
containingBlockFor*Position functions should take the renderer instead of the parent.
https://bugs.webkit.org/show_bug.cgi?id=157659
Reviewed by Simon Fraser.
containingBlockForFixedPosition, containingBlockForAbsolutePosition and containingBlockForObjectInFlow functions
expect the renderer's parent to be passed in (unless it is a RenderInline!). It is rather misleading and highly error-prone.
We should call them with the renderer itself instead.
- dom/Element.cpp:
(WebCore::layoutOverflowRectContainsAllDescendants): This expects ancestor containing block.
- rendering/LogicalSelectionOffsetCaches.h:
(WebCore::LogicalSelectionOffsetCaches::LogicalSelectionOffsetCaches):
- rendering/RenderElement.cpp:
(WebCore::containingBlockForFixedPosition):
(WebCore::containingBlockForAbsolutePosition):
(WebCore::containingBlockForObjectInFlow):
- rendering/RenderElement.h:
- rendering/RenderInline.cpp:
(WebCore::RenderInline::styleWillChange):
- rendering/RenderLineBreak.cpp:
(WebCore::RenderLineBreak::collectSelectionRects): Not a behaviour change.
- rendering/RenderObject.cpp:
(WebCore::RenderObject::containingBlock): RenderScrollbarPart renderer now returns
the containing block based on its owning renderer's style.
- 11:26 AM Changeset in webkit [200952] by
-
- 3 edits in trunk/Source/WebInspectorUI
Web Inspector: Computed style shows both prefixed and unprefixed variants of properties
https://bugs.webkit.org/show_bug.cgi?id=157674
<rdar://problem/24339756>
Patch by Antoine Quint <Antoine Quint> on 2016-05-16
Reviewed by Timothy Hatcher.
We make the CSSProperty
implicitproperty read-write, and in the case where a computed style
has a property marked as explicit, we also check that it's found in matching rules to consider
it non-implicit. This correctly filters out variants of properties set explicitly.
- UserInterface/Models/CSSProperty.js:
(WebInspector.CSSProperty.prototype.set implicit):
- UserInterface/Models/DOMNodeStyles.js:
(WebInspector.DOMNodeStyles.prototype.refresh.fetchedComputedStyle):
(WebInspector.DOMNodeStyles.prototype.refresh):
(WebInspector.DOMNodeStyles.prototype._isPropertyFoundInMatchingRules):
(WebInspector.DOMNodeStyles):
- 11:23 AM Changeset in webkit [200951] by
-
- 10 edits in trunk
[WK2] Add API to WKWebViewConfiguration to control autoplay policy.
https://bugs.webkit.org/show_bug.cgi?id=156312
Reviewed by Dan Bernstein.
Source/WebKit2:
Add a new API to WKWebViewConfiguration to allow fine-grained control over when media is allowed
to play without a user gesture, and simultaneously deprecate the existing, all-or-nothing API,
and deprecated the equivalent SPIs.
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _initializeWithConfiguration:]):
- UIProcess/API/Cocoa/WKWebViewConfiguration.h:
- UIProcess/API/Cocoa/WKWebViewConfiguration.mm:
(-[WKWebViewConfiguration init]):
(-[WKWebViewConfiguration encodeWithCoder:]):
(-[WKWebViewConfiguration initWithCoder:]):
(-[WKWebViewConfiguration copyWithZone:]):
(-[WKWebViewConfiguration _requiresUserActionForVideoPlayback]):
(-[WKWebViewConfiguration _setRequiresUserActionForVideoPlayback:]):
(-[WKWebViewConfiguration _requiresUserActionForAudioPlayback]):
(-[WKWebViewConfiguration _setRequiresUserActionForAudioPlayback:]):
(-[WKWebViewConfiguration requiresUserActionForMediaPlayback]):
(-[WKWebViewConfiguration setRequiresUserActionForMediaPlayback:]):
- UIProcess/API/Cocoa/WKWebViewConfigurationPrivate.h:
Tools:
- WebKitTestRunner/cocoa/TestControllerCocoa.mm:
(WTR::initializeWebViewConfiguration):
- TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm:
(TEST_F):
- 11:09 AM Changeset in webkit [200950] by
-
- 2 edits in trunk/Source/WebKit2
Web Automation: WebAutomationSessionProxy.js gets injected more than once sometimes
https://bugs.webkit.org/show_bug.cgi?id=157716
<rdar://problem/26287306>
Reviewed by Timothy Hatcher.
Whenever a script was injected into a non-normal world by a WebKit client,
the WebProcess's WebAutomationSessionProxy singleton would get a
notification that the window was cleared from the relevant frame.
This notification happens when creating the world's window shell for
the first time.
This code should ignore such notifications that originate from non-main world
contexts. Web Inspector's instrumentation already ignored this, but
the automation session notification comes in via a different WebKit2 layer.
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::dispatchDidClearWindowObjectInWorld):
- 11:04 AM Changeset in webkit [200949] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: DataGrid _updateVisibleRows dominates profiles of timeline recordings when data grid (Overview or TimelineDataGrids) is showing
https://bugs.webkit.org/show_bug.cgi?id=157664
rdar://problem/26262219
Reviewed by Joseph Pecoraro.
- UserInterface/Views/DataGrid.js:
(WebInspector.DataGrid): Added new members.
(WebInspector.DataGrid.prototype.layout): Reset _cachedScrollTop and _cachedScrollHeight on resize.
(WebInspector.DataGrid.prototype._noteScrollPositionChanged): Added.
(WebInspector.DataGrid.prototype._updateVisibleRows): Cache sizes and positions when possible.
(WebInspector.DataGridNode.prototype.set hidden): Added call to _noteRowsChanged.
(WebInspector.DataGridNode.prototype.collapse): Call _noteRowsChanged instead of needsLayout.
(WebInspector.DataGridNode.prototype.expand): Call _noteRowsChanged instead of needsLayout.
(WebInspector.DataGrid.prototype._updateFilter): Removed direct call to _updateVisibleRows, this is
better handled by DataGridNode's hidden setter.
- 10:47 AM Changeset in webkit [200948] by
-
- 2 edits in branches/safari-602.1.32-branch/Source/JavaScriptCore
Merged r200666. rdar://problem/26279421
- 10:41 AM Changeset in webkit [200947] by
-
- 11 edits in trunk/Source/WebInspectorUI
Web Inspector: Many DataGrid instances do not save/restore their scroll position
https://bugs.webkit.org/show_bug.cgi?id=157709
rdar://problem/26286090
Reviewed by Brian Burg.
- UserInterface/Models/BackForwardEntry.js:
(WebInspector.BackForwardEntry.prototype.makeCopy): Added.
- UserInterface/Views/ContentViewContainer.js:
(WebInspector.ContentViewContainer.prototype.showContentView): Copy the last entry for the view.
- UserInterface/Views/DOMStorageContentView.js:
(WebInspector.DOMStorageContentView.prototype.get scrollableElements): Added.
- UserInterface/Views/HeapSnapshotContentView.js:
(WebInspector.HeapSnapshotContentView.prototype.get scrollableElements): Added.
- UserInterface/Views/IndexedDatabaseObjectStoreContentView.js:
(WebInspector.IndexedDatabaseObjectStoreContentView.prototype.get scrollableElements): Added.
- UserInterface/Views/MemoryTimelineView.js:
(WebInspector.MemoryTimelineView.prototype.get scrollableElements): Added.
- UserInterface/Views/ProfileView.js:
(WebInspector.ProfileView.prototype.get scrollableElements): Added.
(WebInspector.ProfileView.prototype._repopulateDataGridFromTree): Removed unused skipRefresh argument.
- UserInterface/Views/ScriptClusterTimelineView.js:
(WebInspector.ScriptClusterTimelineView.prototype.get scrollableElements): Added.
- UserInterface/Views/ScriptProfileTimelineView.js:
(WebInspector.ScriptProfileTimelineView.prototype.get scrollableElements): Added.
- UserInterface/Views/TimelineView.js:
(WebInspector.TimelineView.prototype.get scrollableElements): Added.
- 10:40 AM Changeset in webkit [200946] by
-
- 5 edits in trunk
RegExp /y flag incorrect handling of mixed-length alternation
https://bugs.webkit.org/show_bug.cgi?id=157723
Reviewed by Filip Pizlo.
Source/JavaScriptCore:
Previously for sticky patterns, we were bailing out and exiting when backtracking
alternatives with dissimilar match lengths. Deleted that code. Instead, for
sticky patterns we need to process the backtracking except for advancing to the
next input index.
- yarr/YarrJIT.cpp:
(JSC::Yarr::YarrGenerator::backtrack):
LayoutTests:
Added tests for alternatives with shorter to longer lengths.
- js/regexp-sticky-expected.txt:
- js/script-tests/regexp-sticky.js:
- 10:35 AM Changeset in webkit [200945] by
-
- 21 edits21 adds in trunk
REGRESSION (r192098): Content missing after copy and paste to Notes App on retina displays
https://bugs.webkit.org/show_bug.cgi?id=157630
<rdar://problem/25277577>
Reviewed by Simon Fraser.
Source/WebCore:
Tested by http/tests/images/hidpi-srcset-copy.html
The code to create a WebArchive (or other representation) of a webpage was using the 'src' attribute of
the image element, which might be changed to reflect the optimal image dimensions for a specific
display. Instead, we should use the 'imageSourceURL' method of the Element class so we get the correct
'original' image URL in our cached resources.
- editing/cocoa/HTMLConverter.mm:
(HTMLConverter::_processElement): Use 'imageSourceURL', rather than getting the raw 'src' attribute.
- html/HTMLImageElement.cpp:
(WebCore::HTMLImageElement::addSubresourceAttributeURLs): Ditto.
Tools:
Update test infrastructure to support checking the number of images in the pasteboard.
- DumpRenderTree/TestRunner.cpp:
(imageCountInGeneralPasteboardCallback): Added.
(TestRunner::staticFunctions):
- DumpRenderTree/TestRunner.h:
- DumpRenderTree/mac/TestRunnerMac.mm:
(TestRunner::imageCountInGeneralPasteboard): Added.
- DumpRenderTree/win/TestRunnerWin.cpp:
(TestRunner::imageCountInGeneralPasteboard): Added stub method.
- WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
- WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
(WTR::InjectedBundle::imageCountInGeneralPasteboard): Added.
- WebKitTestRunner/InjectedBundle/InjectedBundle.h:
- WebKitTestRunner/InjectedBundle/TestRunner.cpp:
(WTR::TestRunner::imageCountInGeneralPasteboard): Added.
- WebKitTestRunner/InjectedBundle/TestRunner.h:
- WebKitTestRunner/TestController.cpp:
(WTR::TestController::imageCountInGeneralPasteboard): Added stub implementation.
- WebKitTestRunner/TestController.h:
- WebKitTestRunner/TestInvocation.cpp:
(WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle): Handle copy message.
- WebKitTestRunner/cocoa/TestControllerCocoa.mm:
(WTR::TestController::imageCountInGeneralPasteboard): Added.
LayoutTests:
- http/tests/images/hidpi-srcset-copy-expected.txt: Added.
- http/tests/images/hidpi-srcset-copy.html: Added.
- http/tests/resources/img-srcset: Added.
- http/tests/resources/img-srcset/image1-620x442.jpg: Added.
- http/tests/resources/img-srcset/image2-1024x731.jpg: Added.
- http/tests/resources/img-srcset/image2-1400x1000.jpg: Added.
- http/tests/resources/img-srcset/image2-300x214.jpg: Added.
- http/tests/resources/img-srcset/image2-620x442.jpg: Added.
- http/tests/resources/img-srcset/image2-840x600.jpg: Added.
- http/tests/resources/img-srcset/image3-250x178.jpg: Added.
- http/tests/resources/img-srcset/image3-615x438.jpg: Added.
- http/tests/resources/img-srcset/image3-620x440.jpg: Added.
- http/tests/resources/img-srcset/image3-700x498.jpg: Added.
- http/tests/resources/img-srcset/image3-840x598.jpg: Added.
- http/tests/resources/img-srcset/image3.jpg: Added.
- http/tests/resources/img-srcset/image4-1024x612.jpg: Added.
- http/tests/resources/img-srcset/image4-300x179.jpg: Added.
- http/tests/resources/img-srcset/image4-620x370.jpg: Added.
- http/tests/resources/img-srcset/image4-768x459.jpg: Added.
- http/tests/resources/img-srcset/image4-840x502.jpg: Added.
- http/tests/resources/img-srcset/image4-940x560.jpg: Added.
- platform/efl/TestExpectations: No pasteboard implementation. Skip.
- platform/gtk/TestExpectations: Ditto.
- platform/win/TestExpectations: Ditto.
- 10:22 AM Changeset in webkit [200944] by
-
- 2 edits in trunk/Source/WebCore
Random CachedFont.cpp cleanup.
https://bugs.webkit.org/show_bug.cgi?id=157740
Reviewed by Myles C. Maxfield.
No new tests (Refactor/cleanup, no behavior change)
- loader/cache/CachedFont.cpp:
(WebCore::CachedFont::ensureCustomFontData): Remove unneeded local RefPtr<>
(WebCore::CachedFont::createCustomFontData): Refactor to not require unnecessary Ref-churn in the common case.
- 9:37 AM Changeset in webkit [200943] by
-
- 26 edits in trunk/Source/WebCore
Modernize Track classes' code
https://bugs.webkit.org/show_bug.cgi?id=157735
Reviewed by Eric Carlson.
Modernize Track classes' code a bit.
- Modules/mediasource/MediaSource.cpp:
(WebCore::MediaSource::removeSourceBuffer):
- Modules/mediasource/SourceBuffer.cpp:
(WebCore::SourceBuffer::sourceBufferPrivateDidReceiveInitializationSegment):
- bindings/js/JSTrackCustom.cpp:
(WebCore::toTrack):
(WebCore::toJS):
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::audioTrackEnabledChanged):
(WebCore::HTMLMediaElement::textTrackModeChanged):
(WebCore::HTMLMediaElement::videoTrackSelectedChanged):
(WebCore::HTMLMediaElement::textTrackRemoveCues):
(WebCore::HTMLMediaElement::mediaPlayerDidAddTextTrack):
(WebCore::HTMLMediaElement::addAudioTrack):
(WebCore::HTMLMediaElement::addTextTrack):
(WebCore::HTMLMediaElement::addVideoTrack):
(WebCore::HTMLMediaElement::removeAudioTrack):
(WebCore::HTMLMediaElement::removeTextTrack):
(WebCore::HTMLMediaElement::removeVideoTrack):
(WebCore::HTMLMediaElement::forgetResourceSpecificTracks):
(WebCore::HTMLMediaElement::audioTracks):
(WebCore::HTMLMediaElement::textTracks):
(WebCore::HTMLMediaElement::videoTracks):
(WebCore::HTMLMediaElement::didAddTextTrack):
(WebCore::HTMLMediaElement::didRemoveTextTrack):
(WebCore::HTMLMediaElement::setSelectedTextTrack):
(WebCore::HTMLMediaElement::textTrackAddCues): Deleted.
(WebCore::HTMLMediaElement::closeCaptionTracksChanged): Deleted.
- html/HTMLMediaElement.h:
- html/shadow/MediaControlElements.cpp:
(WebCore::MediaControlClosedCaptionsTrackListElement::updateDisplay):
(WebCore::MediaControlClosedCaptionsTrackListElement::rebuildTrackListMenu):
- html/track/AudioTrack.cpp:
(WebCore::AudioTrack::~AudioTrack):
(WebCore::AudioTrack::setPrivate):
(WebCore::AudioTrack::isValidKind):
(WebCore::AudioTrack::willRemove):
(WebCore::AudioTrack::setEnabled): Deleted.
(WebCore::AudioTrack::updateKindFromPrivate): Deleted.
- html/track/AudioTrack.h:
(isType):
- html/track/AudioTrackList.cpp:
(AudioTrackList::append):
(AudioTrackList::item):
(AudioTrackList::getTrackById):
(AudioTrackList::eventTargetInterface): Deleted.
- html/track/AudioTrackList.h:
- html/track/InbandTextTrack.cpp:
(WebCore::InbandTextTrack::willRemove):
- html/track/TextTrack.cpp:
(WebCore::TextTrack::setKind):
(WebCore::TextTrack::trackIndex):
(WebCore::TextTrack::trackIndexRelativeToRenderedTracks):
(WebCore::TextTrack::setLanguage):
- html/track/TextTrack.h:
(isType):
- html/track/TextTrackList.cpp:
(TextTrackList::getTrackIndex):
(TextTrackList::getTrackIndexRelativeToRenderedTracks):
(TextTrackList::item):
(TextTrackList::getTrackById):
(TextTrackList::invalidateTrackIndexesAfterTrack):
(TextTrackList::append):
(TextTrackList::remove):
(TextTrackList::contains):
- html/track/TextTrackList.h:
- html/track/TrackBase.h:
- html/track/TrackEvent.cpp:
(WebCore::TrackEvent::TrackEvent):
- html/track/TrackEvent.h:
- html/track/TrackListBase.cpp:
(TrackListBase::remove):
(TrackListBase::contains):
(TrackListBase::scheduleTrackEvent):
(TrackListBase::scheduleAddTrackEvent):
(TrackListBase::scheduleRemoveTrackEvent):
- html/track/TrackListBase.h:
- html/track/VideoTrack.cpp:
(WebCore::VideoTrack::willRemove):
(WebCore::VideoTrack::setKind):
(WebCore::VideoTrack::setLanguage):
- html/track/VideoTrack.h:
(isType):
- html/track/VideoTrackList.cpp:
(VideoTrackList::append):
(VideoTrackList::item):
(VideoTrackList::getTrackById):
(VideoTrackList::selectedIndex):
- html/track/VideoTrackList.h:
- 9:04 AM WebKitGTK/2.12.x edited by
- Badly propose a couple merges (diff)
- 7:50 AM Changeset in webkit [200942] by
-
- 3 edits in trunk/LayoutTests
Unreviewed gardening
Re-mark a failing test as failing. Update the expectations file so
that it fails rather than passes unexpectedly.
- accessibility/gtk/title-and-alt-expected.txt:
- platform/gtk/TestExpectations:
- 7:40 AM Changeset in webkit [200941] by
-
- 2 edits in trunk/Source/WebCore
CSSParser.cpp triggers -Wunused-parameter
https://bugs.webkit.org/show_bug.cgi?id=157734
Reviewed by Csaba Osztrogonác.
- css/CSSParser.cpp:
(WebCore::isValidKeywordPropertyAndValue):
- 3:28 AM Changeset in webkit [200940] by
-
- 2 edits in trunk/Source/WebCore
[Cairo] GraphicsContext3D::ImageExtractor should use the correct size for copying non-image surfaces
https://bugs.webkit.org/show_bug.cgi?id=157580
Reviewed by Darin Adler.
GraphicsContext3D::ImageExtractor::extractImage() shouldn't use m_imageWidth
and m_imageHeight members when copying the non-image-backed Cairo surface into
the image-based replacement simply because these two are not initialized until
later in this method.
Instead, the size of the to-be-copied image should be queried via the
cairoSurfaceSize() utility function which properly handles Cairo surfaces of
different types.
- platform/graphics/cairo/GraphicsContext3DCairo.cpp:
(WebCore::GraphicsContext3D::ImageExtractor::extractImage):
- 1:05 AM Changeset in webkit [200939] by
-
- 10 edits1 move3 adds in trunk
REGRESSION (r199821): Large animated GIFs with slow network do not animate till the last frame
https://bugs.webkit.org/show_bug.cgi?id=157500
Source/WebCore:
Patch by Said Abou-Hallawa <sabouhallawa@apple.com> on 2016-05-16
Reviewed by Darin Adler.
r199821 relies on the assumption that the image frameCount can be retrieved
only once when the image size is available and it is not going to change. It
turned out this assumption is wrong for some animated GIFs. The frameCount
can change every time a new data block is decoded.
The fix is to invalidate the image cached metadata every time a new data
block is decoded.
Test: http/tests/misc/slow-loading-animated-image.html
- platform/graphics/BitmapImage.cpp:
(WebCore::BitmapImage::BitmapImage): Move the "fromImage" BitmapImage constructor
to BitmapImage.cpp. The ImageSource needs to be initialized differently for
this case from the decoder image case. Also get rid of the template constructor.
Most of the flags of the BitmapImage will be deleted with the asynchronous image
decoding work.
(WebCore::BitmapImage::cacheFrame): Delete unused flag m_hasUniformFrameSize.
It was added in r35761 and was mainly used by BitmapImage::currentFrameSize().
But this function itself was deleted in r172348.
(WebCore::BitmapImage::dataChanged): Invalidate the image metadata cache.
- platform/graphics/BitmapImage.h:
(WebCore::BitmapImage::BitmapImage): Deleted.
Delete unused flag m_hasUniformFrameSize. Also define new static functions in
FrameData to calculate platform dependent properties of an image.
- platform/graphics/ImageSource.cpp:
(WebCore::ImageSource::ImageSource): Add a new constructor for the "fromImage"
BitmapImage case. The purpose of this constructor is to keep m_needsUpdateMetadata
and m_maximumSubsamplingLevel be initialized as they are in the class definition.
This constructor will be used with the asynchronous image decoding work where the
ImageSource needs to cache the FrameData.
(WebCore::ImageSource::updateMetadata): If needsUpdateMetaData() is true, cache new metadata.
(WebCore::ImageSource::subsamplingLevelForScale): Call updateMetadata() with its new name.
(WebCore::ImageSource::frameCount): Ditto
(WebCore::ImageSource::cacheMetadata): Deleted.
- platform/graphics/ImageSource.h:
(WebCore::ImageSource::setNeedsUpdateMetadata): Invalidate the image cached metadata.
- platform/graphics/cairo/BitmapImageCairo.cpp:
(WebCore::NativeImage::size):
(WebCore::NativeImage::hasAlpha):
(WebCore::BitmapImage::BitmapImage): Deleted.
Delete the "fromImage" BitmapImage constructor from this file since it is now platform
independent and has been moved to BitmapImage.cpp. Also add the new NativeImage platform
dependent functions which are used by the new "fromImage" BitmapImage constructor.
- platform/graphics/cg/BitmapImageCG.cpp:
(WebCore::NativeImage::size):
(WebCore::NativeImage::hasAlpha):
(WebCore::BitmapImage::BitmapImage): Deleted.
Ditto.
LayoutTests:
Patch by Said Abou-Hallawa <sabouhallawa@apple.com> on 2016-05-16
Reviewed by Darin Adler.
Ensure the large animated gif will get the correct frameCount even if it
is loaded through a slow network.
- http/tests/misc/resources/large-animated.gif: Added.
This is a large animated GIF with 48 frames. The frameCount keeps changing
every time a new data block is decoded. Each frame except the last one lasts
for 20 ms. The last one lasts for 10 seconds which is similar to setting no-
loop to true. I created all the images myself. All the images except the last
one are rectangles filled with gradient color so their sizes can be large and
get the bug to repro.
- http/tests/misc/resources/slow-image-load.pl: Added.
- http/tests/misc/resources/slow-png-load.pl: Removed.
I wanted to use the slow-png-load.pl but only changing the image mimetype.
So I changed its name and I added a new query paramater called 'mimetype'.
- http/tests/misc/slow-loading-animated-image-expected.html: Added.
- http/tests/misc/slow-loading-animated-image.html: Added.
This test loads the animated image in 1 second. It waits for another 1 second
to ensure that all the frames are displayed. All we need is to capture the
last frame which is distinctly filled with solid green color.
- http/tests/misc/slow-loading-image-in-pattern.html:
- http/tests/misc/slow-loading-mask.html:
Use slow-image-load.pl and pass the image mime type.
- 12:03 AM MathML/Early_2016_Refactoring edited by
- (diff)
May 15, 2016:
- 11:23 PM Changeset in webkit [200938] by
-
- 3 edits in trunk/Source/WebCore
Small removal of useless code for MathML token elements
https://bugs.webkit.org/show_bug.cgi?id=157568
Patch by Frederic Wang <fwang@igalia.com> on 2016-05-15
Reviewed by Darin Adler.
We remove two pieces of code for MathML token elements with unclear purposes and that do not
have any effect on math rendering.
No new tests, behavior is unchanged.
- css/mathml.css:
(mtext): Deleted. This was probably a hack that is no longer needed with the latest math font
ascent/descent management.
- mathml/MathMLTextElement.cpp:
(WebCore::MathMLTextElement::createElementRenderer): Deleted. Removing this does not break
the mentioned test.
- 5:48 PM WebKitGTK/Gardening/Calendar edited by
- (diff)
- 5:47 PM Changeset in webkit [200937] by
-
- 2 edits in trunk/LayoutTests
[GTK] Fix some bogus expectations broken by the previous commit
- platform/gtk/TestExpectations:
- 5:45 PM WebKitGTK/Gardening/Calendar edited by
- (diff)
- 5:41 PM Changeset in webkit [200936] by
-
- 2 edits in trunk/LayoutTests
[GTK] More unreviewed test expectations gardening
- platform/gtk/TestExpectations:
- 5:12 PM WebKitGTK/Gardening/Calendar edited by
- (diff)
- 5:10 PM Changeset in webkit [200935] by
-
- 2 edits in trunk/LayoutTests
[GTK] More Unreviewed test expectations gardening
- platform/gtk/TestExpectations:
- 4:30 PM Changeset in webkit [200934] by
-
- 86 edits2 copies in trunk/Source
Use more references in JS wrappers related code
https://bugs.webkit.org/show_bug.cgi?id=157721
Reviewed by Darin Adler.
Source/WebCore:
- Use more references in JS wrappers related code.
- Avoid some refcounting churn when using toJSNewlyCreated() and in HTML/SVG elements factories by moving the Ref<> around.
- Add toJS() / toJSNewlyCreated() implementations for Text, XMLDocument and HTMLDocument. Now that toJSNewlyCreated() takes a Ref<>&& / RefPtr<>&& in, the compiler is no longer able to implicitly use the toJSNewlyCreated() implementation of a parent class for a subclass type (complains about calls being ambiguous). I thought about updating the bindings generator to always generate a toJSNewlyCreated() for all wrapper types (that would call the one on the parent class if the subclass does not have a proper implementation). However this would add some complexity to the bindings generator and it did not seem worth it because [NewObject] and therefore toJSNewlyCreated() is only used for a very limited set of subtypes. I have therefore decided to add the toJS() / toJSNewlyCreated() implementations for the subtypes in question. This also has the benefit of avoiding calling the more complex implementations on Node / Document.
- CMakeLists.txt:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSAnimationTimelineCustom.cpp:
(WebCore::toJS):
- bindings/js/JSAudioContextCustom.cpp:
(WebCore::constructJSAudioContext):
- bindings/js/JSBindingsAllInOne.cpp:
- bindings/js/JSBlobCustom.cpp:
(WebCore::constructJSBlob):
- bindings/js/JSCSSRuleCustom.cpp:
(WebCore::toJS):
- bindings/js/JSCSSValueCustom.cpp:
(WebCore::toJS):
- bindings/js/JSDOMBinding.h:
(WebCore::getCachedWrapper):
(WebCore::createWrapper):
(WebCore::wrap):
(WebCore::getExistingWrapper):
(WebCore::createNewWrapper):
(WebCore::toJS):
(WebCore::finiteInt32Value): Deleted.
- bindings/js/JSDocumentCustom.cpp:
(WebCore::createNewDocumentWrapper):
(WebCore::toJS):
(WebCore::cachedDocumentWrapper):
(WebCore::reportMemoryForFramelessDocument):
(WebCore::toJSNewlyCreated):
- bindings/js/JSDocumentCustom.h:
- bindings/js/JSDocumentFragmentCustom.cpp:
(WebCore::createNewDocumentFragmentWrapper):
(WebCore::toJSNewlyCreated):
(WebCore::toJS):
- bindings/js/JSElementCustom.cpp:
(WebCore::toJSNewlyCreated):
- bindings/js/JSElementCustom.h:
(WebCore::toJSNewlyCreated):
- bindings/js/JSEventCustom.cpp:
(WebCore::createNewEventWrapper):
(WebCore::toJS):
(WebCore::toJSNewlyCreated):
- bindings/js/JSFileCustom.cpp:
(WebCore::constructJSFile):
- bindings/js/JSHTMLCollectionCustom.cpp:
(WebCore::toJS):
- bindings/js/JSHTMLDocumentCustom.cpp:
(WebCore::createNewHTMLDocumentWrapper):
(WebCore::toJS):
(WebCore::toJSNewlyCreated):
- bindings/js/JSHTMLTemplateElementCustom.cpp:
(WebCore::JSHTMLTemplateElement::content):
- bindings/js/JSImageDataCustom.cpp:
(WebCore::toJS):
- bindings/js/JSNodeCustom.cpp:
(WebCore::createWrapperInline):
(WebCore::createWrapper):
(WebCore::toJSNewlyCreated):
(WebCore::getOutOfLineCachedWrapper):
- bindings/js/JSNodeCustom.h:
(WebCore::toJS):
- bindings/js/JSNodeListCustom.cpp:
(WebCore::createWrapper):
(WebCore::toJSNewlyCreated):
- bindings/js/JSNodeListCustom.h:
(WebCore::toJS):
- bindings/js/JSRTCPeerConnectionCustom.cpp:
(WebCore::constructJSRTCPeerConnection):
- bindings/js/JSRTCSessionDescriptionCustom.cpp:
(WebCore::constructJSRTCSessionDescription):
- bindings/js/JSSVGPathSegCustom.cpp:
(WebCore::toJS):
- bindings/js/JSStyleSheetCustom.cpp:
(WebCore::toJS):
- bindings/js/JSTextCustom.cpp: Copied from Source/WebCore/dom/XMLDocument.idl.
(WebCore::createNewTextWrapper):
(WebCore::toJS):
(WebCore::toJSNewlyCreated):
- bindings/js/JSTextTrackCueCustom.cpp:
(WebCore::toJS):
- bindings/js/JSTrackCustom.cpp:
(WebCore::toJS):
- bindings/js/JSXMLDocumentCustom.cpp: Copied from Source/WebCore/bindings/js/JSDocumentFragmentCustom.cpp.
(WebCore::createNewXMLDocumentWrapper):
(WebCore::toJS):
(WebCore::toJSNewlyCreated):
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateHeader):
(GenerateImplementation):
- bindings/scripts/test/JS/*: Rebaseline bindings tests.
- dom/Element.cpp:
(WebCore::Element::setInnerHTML):
- dom/Text.idl:
- dom/XMLDocument.idl:
- dom/make_names.pl:
(printWrapperFunctions):
(printWrapperFactoryCppFile):
(printWrapperFactoryHeaderFile):
- editing/MarkupAccumulator.cpp:
(WebCore::MarkupAccumulator::serializeNodesWithNamespaces):
- html/HTMLDocument.idl:
- html/HTMLTemplateElement.cpp:
(WebCore::HTMLTemplateElement::content):
(WebCore::HTMLTemplateElement::cloneNodeInternal):
- html/HTMLTemplateElement.h:
- html/parser/HTMLConstructionSite.cpp:
(WebCore::insert):
(WebCore::HTMLConstructionSite::insertTextNode):
(WebCore::HTMLConstructionSite::ownerDocumentForCurrentNode):
- inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::buildObjectForNode):
- xml/parser/XMLDocumentParserLibxml2.cpp:
(WebCore::XMLDocumentParser::startElementNs):
Source/WTF:
Add new static_reference_cast() overload that takes a Ref<U>&& in
in order to downcast Ref<> types without causing ref-counting
churn.
- wtf/Ref.h:
(WTF::static_reference_cast):
- 4:08 PM Changeset in webkit [200933] by
-
- 8 edits in trunk/Source/JavaScriptCore
DFG::Plan shouldn't read from its VM once it's been cancelled
https://bugs.webkit.org/show_bug.cgi?id=157726
Reviewed by Saam Barati.
Plan::vm was a reference, not a pointer, and so wasn't nulled by Plan::cancel(). So, a
cancelled plan may have a dangling pointer to a VM: we could delete the VM after cancelling
the plan.
Prior to http://trac.webkit.org/changeset/200705, this was probably fine because nobody
would read Plan::vm if the plan was cancelled. But r200705 changed that. It was a hard
regression to spot because usually a cancelled plan will still refer to a valid VM.
This change fixes the regression and makes it a lot easier to spot the regression in the
future. Plan::vm is now a pointer and we null it in Plan::cancel(). Now if you make this
mistake, you will get a crash anytime the Plan is cancelled, not just anytime the plan is
cancelled and the VM gets deleted. Also, it's now very clear what to do when you want to
use Plan::vm on the cancel path: you can null-check vm; if it's null, assume the worst.
Because we null the VM of a cancelled plan, we cannot have Safepoint::vm() return the
plan's VM anymore. That's because when we cancel a plan that is at a safepoint, we use the
safepoint's VM to determine whether this is one of our safepoints *after* the plan is
already cancelled. So, Safepoint now has its own copy of m_vm, and that copy gets nulled
when the Safepoint is cancelled. The Safepoint's m_vm will be nulled moments after Plan's
vm gets nulled (see Worklist::removeDeadPlans(), which has a cancel path for Plans in one
loop and a cancel path for Safepoints in the loop after it).
- dfg/DFGJITFinalizer.cpp:
(JSC::DFG::JITFinalizer::finalizeCommon):
- dfg/DFGPlan.cpp:
(JSC::DFG::Plan::Plan):
(JSC::DFG::Plan::computeCompileTimes):
(JSC::DFG::Plan::reportCompileTimes):
(JSC::DFG::Plan::compileInThreadImpl):
(JSC::DFG::Plan::reallyAdd):
(JSC::DFG::Plan::notifyCompiling):
(JSC::DFG::Plan::finalizeWithoutNotifyingCallback):
(JSC::DFG::Plan::cancel):
- dfg/DFGPlan.h:
(JSC::DFG::Plan::canTierUpAndOSREnter):
- dfg/DFGSafepoint.cpp:
(JSC::DFG::Safepoint::cancel):
(JSC::DFG::Safepoint::vm):
- dfg/DFGSafepoint.h:
- dfg/DFGWorklist.cpp:
(JSC::DFG::Worklist::isActiveForVM):
(JSC::DFG::Worklist::waitUntilAllPlansForVMAreReady):
(JSC::DFG::Worklist::removeAllReadyPlansForVM):
(JSC::DFG::Worklist::rememberCodeBlocks):
(JSC::DFG::Worklist::visitWeakReferences):
(JSC::DFG::Worklist::removeDeadPlans):
(JSC::DFG::Worklist::runThread):
- ftl/FTLJITFinalizer.cpp:
(JSC::FTL::JITFinalizer::finalizeFunction):
- 3:13 PM Changeset in webkit [200932] by
-
- 3 edits in trunk/Source/WebCore
Something tiny left out of the last patch.
- WebCore.xcodeproj/project.pbxproj: Allow Xcode to update this file.
- editing/ApplyStyleCommand.cpp:
(WebCore::ApplyStyleCommand::applyInlineStyleChange): Removed unneeded null check; all
code paths already have null checks.
- 3:12 PM WebKitGTK/Gardening/Calendar edited by
- (diff)
- 3:08 PM Changeset in webkit [200931] by
-
- 26 edits in trunk/Source
More CTTE and other cleanups for HTML editing header
https://bugs.webkit.org/show_bug.cgi?id=157722
Reviewed by Chris Dumez.
Source/WebCore:
These changes are mostly things Chris asked for in his review of my last patch
or other related style and small efficiency improvements.
- using nullptr instead of 0
- using is<Text> instead of isTextNode and is<> instead of hasTagName
- changing argument type of functions like editingIgnoresContent to a reference
- using { } instead of constructor calls for classes like Position
- using words like position intead of abbreviations like pos
- using auto rather than explicit types
- rename functions that return true for HTMLElement to express that in the function names
- dom/Position.cpp:
(WebCore::nextRenderedEditable): nullptr
(WebCore::previousRenderedEditable): nullptr
(WebCore::Position::Position): is<>, reference
(WebCore::Position::moveToPosition): reference
(WebCore::Position::offsetForPositionAfterAnchor): Added a null assertion and
null check that replaces the one that used to be in lastOffsetForEditing.
(WebCore::Position::parentAnchoredEquivalent): { }, reference
(WebCore::Position::computeNodeBeforePosition): nullptr
(WebCore::Position::computeNodeAfterPosition): nullptr
(WebCore::Position::anchorTypeForLegacyEditingPosition): reference
(WebCore::Position::previous): reference
(WebCore::Position::next): reference
(WebCore::Position::parentEditingBoundary): nullptr
(WebCore::Position::previousCharacterPosition): { }, pos -> position
(WebCore::Position::nextCharacterPosition): { }, pos -> position
(WebCore::endsOfNodeAreVisuallyDistinctPositions): reference
(WebCore::Position::upstream): { }, pos -> position
(WebCore::Position::downstream): { }, pos -> position
(WebCore::Position::rootUserSelectAllForNode): nullptr
(WebCore::Position::isCandidate): auto, reference, is<>
(WebCore::Position::rendersInDifferentPosition): pos -> position, auto, is<>
(WebCore::Position::leadingWhitespacePosition): { }, is<>
(WebCore::Position::trailingWhitespacePosition): { }
(WebCore::Position::getInlineBoxAndOffset): reference
(WebCore::Position::equals): reference, is<>
- dom/PositionIterator.cpp:
(WebCore::PositionIterator::operator Position): reference
(WebCore::PositionIterator::isCandidate): reference
- editing/ApplyStyleCommand.cpp:
(WebCore::ApplyStyleCommand::applyRelativeFontStyleChange): is<>
(WebCore::ApplyStyleCommand::applyInlineStyleToNodeRange): is<>, reference
(WebCore::ApplyStyleCommand::removeConflictingInlineStyleFromRun): reference
(WebCore::ApplyStyleCommand::removeInlineStyle): auto, is<>, reference
(WebCore::ApplyStyleCommand::nodeFullySelected): is<>
(WebCore::ApplyStyleCommand::nodeFullyUnselected): is<>
(WebCore::ApplyStyleCommand::splitTextAtStart): is<>
(WebCore::ApplyStyleCommand::splitTextElementAtStart): is<>
(WebCore::ApplyStyleCommand::splitTextElementAtEnd): is<>
(WebCore::ApplyStyleCommand::isValidCaretPositionInTextNode): is<>
(WebCore::ApplyStyleCommand::surroundNodeRangeWithElement): Removed unneeded
is<Element> calls before calling areIdenticalElements.
(WebCore::ApplyStyleCommand::positionToComputeInlineStyleChange): Tightened
up logic for the loop to avoid redundant checks.
(WebCore::ApplyStyleCommand::applyInlineStyleChange): auto
- editing/CompositeEditCommand.cpp:
(WebCore::CompositeEditCommand::insertNodeAt): reference
(WebCore::CompositeEditCommand::appendNode): reference
(WebCore::CompositeEditCommand::moveParagraphs): isListHTMLElement
- editing/DeleteSelectionCommand.cpp:
(WebCore::DeleteSelectionCommand::handleGeneralDelete): reference
- editing/FormatBlockCommand.cpp: Fixed order of includes.
(WebCore::enclosingBlockToSplitTreeTo): isListHTMLElement
- editing/InsertParagraphSeparatorCommand.cpp:
(WebCore::InsertParagraphSeparatorCommand::doApply): reference
- editing/ModifySelectionListLevel.cpp:
(WebCore::getStartEndListChildren): isListHTMLElement
(WebCore::IncreaseSelectionListLevelCommand::doApply):isListHTMLElement
(WebCore::canDecreaseListLevel):isListHTMLElement
- editing/RemoveNodeCommand.cpp: Removed unneeded include.
- editing/ReplaceNodeWithSpanCommand.cpp:
(WebCore::ReplaceNodeWithSpanCommand::doApply): Use HTMLSpanElement::create.
- editing/ReplaceSelectionCommand.cpp:
(WebCore::isInterchangeNewlineNode): is<>, downcast<>
(WebCore::isInterchangeConvertedSpaceSpan): is<>, downcast<>
(WebCore::positionAvoidingPrecedingNodes): pos -> position, reference
(WebCore::ReplaceSelectionCommand::doApply): isListHTMLElement
(WebCore::ReplaceSelectionCommand::insertAsListItems): isListHTMLElement
- editing/SpellChecker.cpp: Removed unneeded include.
- editing/TextIterator.cpp:
(WebCore::SimplifiedBackwardsTextIterator::advance): reference
- editing/VisibleSelection.cpp:
(WebCore::VisibleSelection::selectionFromContentsOfNode): reference
- editing/VisibleUnits.cpp:
(WebCore::previousLinePosition): reference
(WebCore::nextLinePosition): reference
(WebCore::findStartOfParagraph): reference
(WebCore::findEndOfParagraph): reference
- editing/htmlediting.cpp:
(WebCore::canHaveChildrenForEditing): Moved here from header file so we don't
have to include "Text.h". Not critical to inline this.
(WebCore::isAtomicNode): reference
(WebCore::lastOffsetForEditing): reference
(WebCore::stringWithRebalancedWhitespace): Changed to use StringBuilder instead
of Vector<UChar> so this won't turn 8-bit strings into 16-bit strings. Changed
to not use the StringBuilder at all until we encounter a character that needs
to be changed.
(WebCore::isSpecialHTMLElement): Renamed to make it clear that it only can return
true for a Node that is an HTMLElement.
(WebCore::firstInSpecialElement): isSpecialHTMLElement
(WebCore::lastInSpecialElement): isSpecialHTMLElement
(WebCore::isListHTMLElement): Renamed to make it clear that it can only return
true for a Node that is an HTMLElement.
(WebCore::isListItem): isListHTMLElement, is<>
(WebCore::enclosingNodeOfType): p -> position, nullptr
(WebCore::highestEnclosingNodeOfType): p -> position
(WebCore::enclosingListChild): isListHTMLElement, is<>
(WebCore::embeddedSublist): isListHTMLElement
(WebCore::appendedSublist):isListHTMLElement
(WebCore::caretMaxOffset): is<>
(WebCore::caretRendersInsideNode): changed to take a reference
(WebCore::rendererForCaretPainting): reference
- editing/htmlediting.h: Updated for name changes and type changes above.
- editing/markup.cpp:
(WebCore::StyledMarkupAccumulator::traverseNodesForSerialization): reference
(WebCore::highestAncestorToWrapMarkup): auto, reference, isListHTMLElement
- html/HTMLSpanElement.cpp:
(WebCore::HTMLSpanElement::create): Added overload that does not require a tag name.
- html/HTMLSpanElement.h: Ditto.
- page/DOMSelection.cpp: Removed unneeded includes.
- rendering/RenderBox.cpp:
(WebCore::RenderBox::localCaretRect): reference
Source/WebKit/ios:
- WebCoreSupport/WebFrameIOS.mm:
(-[WebFrame previousUnperturbedDictationResultBoundaryFromPosition:]): auto
(-[WebFrame nextUnperturbedDictationResultBoundaryFromPosition:]): auto
- 3:05 PM Changeset in webkit [200930] by
-
- 1 edit in trunk/LayoutTests/ChangeLog
[GTK] Unreviewed test expectations gardening
- TestExpectations:
- platform/gtk/TestExpectations:
- 3:05 PM Changeset in webkit [200929] by
-
- 3 edits in trunk/LayoutTests
[GTK] Unreviewed test expectations gardening
- TestExpectations:
- platform/gtk/TestExpectations:
- 2:11 PM Changeset in webkit [200928] by
-
- 13 edits2 adds in trunk/Source/JavaScriptCore
Modernize Intl constructors; using InternalFunction::createSubclassStructure
https://bugs.webkit.org/show_bug.cgi?id=157082
Reviewed by Darin Adler.
Previously, Intl constructors retrieve "prototype" to inherit the "new.target".
At that time, this mis-assumed that getDirect() always returns meaningful JS value.
Actually, it returns an empty value if a property does not exist.
Instead of fixing this assertion, we now use InternalFunction::createSubclassStructure
in Intl constructors. It is modern and preferable way since it can cache the derived
structures in InternalFunction.
This patch also cleans up the workaround in Intl.NumberFormat and Intl.DateTimeFormat.
Those code are largely duplicate. This is now extracted into
constructIntlInstanceWithWorkaroundForLegacyIntlConstructor. This clean up does not
have any behavior changes. They are already tested in LayoutTests/js/intl-datetimeformat
and LayoutTests/js/intl-numberformat.
- JavaScriptCore.xcodeproj/project.pbxproj:
- runtime/IntlCollator.cpp:
(JSC::IntlCollator::create):
- runtime/IntlCollator.h:
- runtime/IntlCollatorConstructor.cpp:
(JSC::constructIntlCollator):
(JSC::callIntlCollator):
- runtime/IntlDateTimeFormat.cpp:
(JSC::IntlDateTimeFormat::create):
- runtime/IntlDateTimeFormat.h:
- runtime/IntlDateTimeFormatConstructor.cpp:
(JSC::constructIntlDateTimeFormat):
(JSC::callIntlDateTimeFormat):
- runtime/IntlDateTimeFormatPrototype.cpp:
(JSC::IntlDateTimeFormatPrototypeGetterFormat):
(JSC::IntlDateTimeFormatPrototypeFuncResolvedOptions):
- runtime/IntlNumberFormat.cpp:
(JSC::IntlNumberFormat::create):
- runtime/IntlNumberFormat.h:
- runtime/IntlNumberFormatConstructor.cpp:
(JSC::constructIntlNumberFormat):
(JSC::callIntlNumberFormat):
- runtime/IntlNumberFormatPrototype.cpp:
(JSC::IntlNumberFormatPrototypeGetterFormat):
(JSC::IntlNumberFormatPrototypeFuncResolvedOptions):
- runtime/IntlObjectInlines.h: Added.
(JSC::constructIntlInstanceWithWorkaroundForLegacyIntlConstructor):
- tests/stress/intl-constructors-with-proxy.js: Added.
(shouldBe):
(throw.new.Error.Empty):
(throw.new.Error):
(shouldBe.Empty):
- 8:36 AM Changeset in webkit [200927] by
-
- 4 edits in trunk/Source/WebCore
Unreviewed, rolling out r200925.
https://bugs.webkit.org/show_bug.cgi?id=157725
Does not build if MEDIA_SESSION is enabled (Requested by
cdumez_ on #webkit).
Reverted changeset:
"Use new Web IDL dictionary support for
MediaSession.setMetadata()"
https://bugs.webkit.org/show_bug.cgi?id=157711
http://trac.webkit.org/changeset/200925
- 3:34 AM Changeset in webkit [200926] by
-
- 2 edits in trunk/Websites/planet.webkit.org
Remove Frédéric Wang's blog from the planet
https://bugs.webkit.org/show_bug.cgi?id=157724
Reviewed by Philippe Normand.
- config.ini: Remove my feed url since my homepage changed and it is included twice after r169566.
May 14, 2016:
- 4:52 PM Changeset in webkit [200925] by
-
- 4 edits in trunk/Source/WebCore
Use new Web IDL dictionary support for MediaSession.setMetadata()
https://bugs.webkit.org/show_bug.cgi?id=157711
Reviewed by Eric Carlson.
Use new Web IDL dictionary support for MediaSession.setMetadata().
No new tests, no intended Web-exposed behavior change.
- Modules/mediasession/MediaSession.cpp:
(WebCore::MediaSession::setMetadata):
(WebCore::MediaSession::deactivate): Deleted.
- Modules/mediasession/MediaSession.h:
- Modules/mediasession/MediaSession.idl:
- 3:17 PM Changeset in webkit [200924] by
-
- 95 edits21 deletes in trunk
Remove LegacyProfiler
https://bugs.webkit.org/show_bug.cgi?id=153565
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-05-14
Reviewed by Mark Lam.
.:
- ManualTests/inspector/profiler-test-call.html: Removed.
- ManualTests/inspector/profiler-test-many-calls-in-the-same-scope.html: Removed.
Source/JavaScriptCore:
JavaScriptCore now provides a sampling profiler and it is enabled
by all ports. Web Inspector switched months ago to using the
sampling profiler and displaying its data. Remove the legacy
profiler, as it is no longer being used by anything other then
console.profile and tests. We will update console.profile's
behavior soon to have new behavior and use the sampling data.
- API/JSProfilerPrivate.cpp: Removed.
- API/JSProfilerPrivate.h: Removed.
- CMakeLists.txt:
- JavaScriptCore.xcodeproj/project.pbxproj:
- bytecode/BytecodeList.json:
- bytecode/BytecodeUseDef.h:
(JSC::computeUsesForBytecodeOffset): Deleted.
(JSC::computeDefsForBytecodeOffset): Deleted.
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::dumpBytecode): Deleted.
- bytecode/UnlinkedFunctionExecutable.cpp:
(JSC::generateUnlinkedFunctionCodeBlock):
(JSC::UnlinkedFunctionExecutable::unlinkedCodeBlockFor):
- bytecode/UnlinkedFunctionExecutable.h:
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::BytecodeGenerator):
(JSC::BytecodeGenerator::emitCall):
(JSC::BytecodeGenerator::emitCallVarargs):
(JSC::BytecodeGenerator::emitCallVarargsInTailPosition):
(JSC::BytecodeGenerator::emitConstructVarargs):
(JSC::BytecodeGenerator::emitConstruct):
- bytecompiler/BytecodeGenerator.h:
(JSC::CallArguments::profileHookRegister): Deleted.
(JSC::BytecodeGenerator::shouldEmitProfileHooks): Deleted.
- bytecompiler/NodesCodegen.cpp:
(JSC::CallFunctionCallDotNode::emitBytecode):
(JSC::ApplyFunctionCallDotNode::emitBytecode):
(JSC::CallArguments::CallArguments): Deleted.
- dfg/DFGAbstractInterpreterInlines.h:
(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects): Deleted.
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock): Deleted.
- dfg/DFGCapabilities.cpp:
(JSC::DFG::capabilityLevel): Deleted.
- dfg/DFGClobberize.h:
(JSC::DFG::clobberize): Deleted.
- dfg/DFGDoesGC.cpp:
(JSC::DFG::doesGC): Deleted.
- dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode): Deleted.
- dfg/DFGNodeType.h:
- dfg/DFGPredictionPropagationPhase.cpp:
- dfg/DFGSafeToExecute.h:
(JSC::DFG::safeToExecute): Deleted.
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile): Deleted.
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile): Deleted.
- inspector/InjectedScriptBase.cpp:
(Inspector::InjectedScriptBase::callFunctionWithEvalEnabled):
- inspector/protocol/Timeline.json:
- interpreter/Interpreter.cpp:
(JSC::UnwindFunctor::operator()): Deleted.
(JSC::Interpreter::execute): Deleted.
(JSC::Interpreter::executeCall): Deleted.
(JSC::Interpreter::executeConstruct): Deleted.
- jit/JIT.cpp:
(JSC::JIT::privateCompileMainPass): Deleted.
- jit/JIT.h:
- jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_profile_will_call): Deleted.
(JSC::JIT::emit_op_profile_did_call): Deleted.
- jit/JITOpcodes32_64.cpp:
(JSC::JIT::emit_op_profile_will_call): Deleted.
(JSC::JIT::emit_op_profile_did_call): Deleted.
- jit/JITOperations.cpp:
- jit/JITOperations.h:
- jsc.cpp:
- llint/LLIntSlowPaths.cpp:
(JSC::LLInt::LLINT_SLOW_PATH_DECL): Deleted.
- llint/LLIntSlowPaths.h:
- llint/LowLevelInterpreter.asm:
- parser/ParserModes.h:
- profiler/CallIdentifier.h: Removed.
- profiler/LegacyProfiler.cpp: Removed.
- profiler/LegacyProfiler.h: Removed.
- profiler/Profile.cpp: Removed.
- profiler/Profile.h: Removed.
- profiler/ProfileGenerator.cpp: Removed.
- profiler/ProfileGenerator.h: Removed.
- profiler/ProfileNode.cpp: Removed.
- profiler/ProfileNode.h: Removed.
- profiler/ProfilerJettisonReason.cpp:
(WTF::printInternal): Deleted.
- profiler/ProfilerJettisonReason.h:
- runtime/CodeCache.cpp:
(JSC::CodeCache::getGlobalCodeBlock):
(JSC::CodeCache::getProgramCodeBlock):
(JSC::CodeCache::getEvalCodeBlock):
(JSC::CodeCache::getModuleProgramCodeBlock):
- runtime/CodeCache.h:
- runtime/Executable.cpp:
(JSC::ScriptExecutable::newCodeBlockFor):
- runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::createProgramCodeBlock):
(JSC::JSGlobalObject::createEvalCodeBlock):
(JSC::JSGlobalObject::createModuleProgramCodeBlock):
(JSC::JSGlobalObject::~JSGlobalObject): Deleted.
(JSC::JSGlobalObject::hasLegacyProfiler): Deleted.
- runtime/JSGlobalObject.h:
(JSC::JSGlobalObject::supportsLegacyProfiling): Deleted.
- runtime/Options.h:
- runtime/VM.cpp:
(JSC::VM::VM): Deleted.
(JSC::SetEnabledProfilerFunctor::operator()): Deleted.
(JSC::VM::setEnabledProfiler): Deleted.
- runtime/VM.h:
(JSC::VM::enabledProfiler): Deleted.
(JSC::VM::enabledProfilerAddress): Deleted.
Source/WebCore:
- CMakeLists.txt:
- DerivedSources.cpp:
- DerivedSources.make:
- ForwardingHeaders/profiler/LegacyProfiler.h: Removed.
- ForwardingHeaders/profiler/Profile.h: Removed.
- ForwardingHeaders/profiler/ProfileNode.h: Removed.
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSCustomXPathNSResolver.cpp:
- bindings/js/JSDOMWindowBase.cpp:
(WebCore::JSDOMWindowBase::supportsLegacyProfiling): Deleted.
(WebCore::JSDOMWindowBase::supportsRichSourceInfo): Deleted.
- bindings/js/JSDOMWindowBase.h:
- bindings/js/JSWorkerGlobalScopeBase.cpp:
(WebCore::JSWorkerGlobalScopeBase::supportsLegacyProfiling): Deleted.
- bindings/js/JSWorkerGlobalScopeBase.h:
- bindings/js/ScriptCachedFrameData.cpp:
- bindings/js/ScriptController.cpp:
(WebCore::ScriptController::clearWindowShell): Deleted.
- bindings/js/ScriptProfile.h: Removed.
- bindings/js/ScriptProfileNode.h: Removed.
- bindings/scripts/CodeGeneratorJS.pm:
(AddClassForwardIfNeeded): Deleted.
- bindings/scripts/test/JS/JSTestObj.cpp:
- bindings/scripts/test/TestObj.idl:
- css/CSSParser.cpp:
- dom/Document.cpp:
- inspector/InspectorConsoleInstrumentation.h:
(WebCore::InspectorInstrumentation::stopProfiling):
- inspector/InspectorController.cpp:
(WebCore::InspectorController::InspectorController):
(WebCore::InspectorController::legacyProfilerEnabled): Deleted.
(WebCore::InspectorController::setLegacyProfilerEnabled): Deleted.
- inspector/InspectorController.h:
- inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::stopProfilingImpl):
- inspector/InspectorInstrumentation.h:
- inspector/InspectorTimelineAgent.cpp:
(WebCore::InspectorTimelineAgent::startFromConsole):
(WebCore::InspectorTimelineAgent::stopFromConsole):
- inspector/InspectorTimelineAgent.h:
- inspector/PageDebuggerAgent.cpp:
- inspector/PageRuntimeAgent.cpp:
- inspector/ScriptProfile.idl: Removed.
- inspector/ScriptProfileNode.idl: Removed.
- inspector/TimelineRecordFactory.cpp:
(WebCore::buildAggregateCallInfoInspectorObject): Deleted.
(WebCore::buildInspectorObject): Deleted.
(WebCore::buildProfileInspectorObject): Deleted.
(WebCore::TimelineRecordFactory::appendProfile): Deleted.
- page/DOMWindow.cpp:
- page/Page.cpp:
- page/PageConsoleClient.cpp:
(WebCore::PageConsoleClient::profileEnd):
(WebCore::PageConsoleClient::clearProfiles): Deleted.
- page/PageConsoleClient.h:
- testing/Internals.cpp:
(WebCore::Internals::resetToConsistentState): Deleted.
(WebCore::Internals::consoleProfiles): Deleted.
(WebCore::Internals::setLegacyJavaScriptProfilingEnabled): Deleted.
- testing/Internals.h:
- testing/Internals.idl:
- testing/js/WebCoreTestSupport.cpp:
- xml/XSLStyleSheetLibxslt.cpp:
- xml/XSLTProcessorLibxslt.cpp:
Source/WebKit/win:
- Interfaces/IWebInspector.idl:
- WebView.cpp:
- WebInspector.cpp:
(WebInspector::isJavaScriptProfilingEnabled): Deleted.
(WebInspector::setJavaScriptProfilingEnabled): Deleted.
- WebInspector.h:
LayoutTests:
- fast/profiler/anonymous-event-handler-expected.txt: Removed.
- fast/profiler/anonymous-event-handler.html: Removed.
- fast/profiler/anonymous-function-called-from-different-contexts-expected.txt: Removed.
- fast/profiler/anonymous-function-called-from-different-contexts.html: Removed.
- fast/profiler/anonymous-function-calls-built-in-functions-expected.txt: Removed.
- fast/profiler/anonymous-function-calls-built-in-functions.html: Removed.
- fast/profiler/anonymous-function-calls-eval-expected.txt: Removed.
- fast/profiler/anonymous-function-calls-eval.html: Removed.
- fast/profiler/anonymous-functions-with-display-names-expected.txt: Removed.
- fast/profiler/anonymous-functions-with-display-names.html: Removed.
- fast/profiler/apply-expected.txt: Removed.
- fast/profiler/apply.html: Removed.
- fast/profiler/built-in-function-calls-anonymous-expected.txt: Removed.
- fast/profiler/built-in-function-calls-anonymous.html: Removed.
- fast/profiler/built-in-function-calls-user-defined-function-expected.txt: Removed.
- fast/profiler/built-in-function-calls-user-defined-function.html: Removed.
- fast/profiler/call-expected.txt: Removed.
- fast/profiler/call-register-leak-expected.txt: Removed.
- fast/profiler/call-register-leak.html: Removed.
- fast/profiler/call.html: Removed.
- fast/profiler/calling-the-function-that-started-the-profiler-from-another-scope-expected.txt: Removed.
- fast/profiler/calling-the-function-that-started-the-profiler-from-another-scope.html: Removed.
- fast/profiler/compare-multiple-profiles-expected.txt: Removed.
- fast/profiler/compare-multiple-profiles.html: Removed.
- fast/profiler/constructor-expected.txt: Removed.
- fast/profiler/constructor.html: Removed.
- fast/profiler/dead-time-expected.txt: Removed.
- fast/profiler/dead-time.html: Removed.
- fast/profiler/document-dot-write-expected.txt: Removed.
- fast/profiler/document-dot-write.html: Removed.
- fast/profiler/event-handler-expected.txt: Removed.
- fast/profiler/event-handler.html: Removed.
- fast/profiler/execution-context-and-eval-on-same-line-expected.txt: Removed.
- fast/profiler/execution-context-and-eval-on-same-line.html: Removed.
- fast/profiler/inline-event-handler-expected.txt: Removed.
- fast/profiler/inline-event-handler.html: Removed.
- fast/profiler/many-calls-in-the-same-scope-expected.txt: Removed.
- fast/profiler/many-calls-in-the-same-scope.html: Removed.
- fast/profiler/multiple-and-different-scoped-anonymous-function-calls-expected.txt: Removed.
- fast/profiler/multiple-and-different-scoped-anonymous-function-calls.html: Removed.
- fast/profiler/multiple-and-different-scoped-function-calls-expected.txt: Removed.
- fast/profiler/multiple-and-different-scoped-function-calls.html: Removed.
- fast/profiler/multiple-anonymous-functions-called-from-the-same-function-expected.txt: Removed.
- fast/profiler/multiple-anonymous-functions-called-from-the-same-function.html: Removed.
- fast/profiler/multiple-frames-expected.txt: Removed.
- fast/profiler/multiple-frames.html: Removed.
- fast/profiler/named-functions-with-display-names-expected.txt: Removed.
- fast/profiler/named-functions-with-display-names.html: Removed.
- fast/profiler/nested-anonymous-functon-expected.txt: Removed.
- fast/profiler/nested-anonymous-functon.html: Removed.
- fast/profiler/nested-start-and-stop-profiler-expected.txt: Removed.
- fast/profiler/nested-start-and-stop-profiler.html: Removed.
- fast/profiler/no-execution-context-expected.txt: Removed.
- fast/profiler/no-execution-context.html: Removed.
- fast/profiler/one-execution-context-expected.txt: Removed.
- fast/profiler/one-execution-context.html: Removed.
- fast/profiler/profile-calls-in-included-file-expected.txt: Removed.
- fast/profiler/profile-calls-in-included-file.html: Removed.
- fast/profiler/profile-with-no-title-expected.txt: Removed.
- fast/profiler/profile-with-no-title.html: Removed.
- fast/profiler/profiling-from-a-nested-location-but-stop-profiling-outside-the-nesting-expected.txt: Removed.
- fast/profiler/profiling-from-a-nested-location-but-stop-profiling-outside-the-nesting.html: Removed.
- fast/profiler/profiling-from-a-nested-location-expected.txt: Removed.
- fast/profiler/profiling-from-a-nested-location.html: Removed.
- fast/profiler/resources/other-frame.html: Removed.
- fast/profiler/resources/other-window.html: Removed.
- fast/profiler/resources/profiler-test-JS-resources.js: Removed.
- fast/profiler/simple-event-call-expected.txt: Removed.
- fast/profiler/simple-event-call.html: Removed.
- fast/profiler/simple-no-level-change-expected.txt: Removed.
- fast/profiler/simple-no-level-change.html: Removed.
- fast/profiler/start-and-stop-profiler-multiple-times-expected.txt: Removed.
- fast/profiler/start-and-stop-profiler-multiple-times.html: Removed.
- fast/profiler/start-and-stop-profiling-in-the-same-function-expected.txt: Removed.
- fast/profiler/start-and-stop-profiling-in-the-same-function.html: Removed.
- fast/profiler/start-but-dont-stop-profiling-expected.txt: Removed.
- fast/profiler/start-but-dont-stop-profiling.html: Removed.
- fast/profiler/stop-profiling-after-setTimeout-expected.txt: Removed.
- fast/profiler/stop-profiling-after-setTimeout.html: Removed.
- fast/profiler/stop-then-function-call-expected.txt: Removed.
- fast/profiler/stop-then-function-call.html: Removed.
- fast/profiler/throw-exception-from-eval-expected.txt: Removed.
- fast/profiler/throw-exception-from-eval.html-disabled: Removed.
- fast/profiler/two-execution-contexts-expected.txt: Removed.
- fast/profiler/two-execution-contexts.html: Removed.
- fast/profiler/user-defined-function-calls-built-in-functions-expected.txt: Removed.
- fast/profiler/user-defined-function-calls-built-in-functions.html: Removed.
- fast/profiler/window-dot-eval-expected.txt: Removed.
- fast/profiler/window-dot-eval.html: Removed.
- platform/efl/TestExpectations:
- platform/gtk/TestExpectations:
- platform/ios-simulator/TestExpectations:
- 2:07 PM Changeset in webkit [200923] by
-
- 5 edits2 adds in trunk
ToT WebKit doesn't show tooltip on perf dashboard's summary page
https://bugs.webkit.org/show_bug.cgi?id=157705
Reviewed by Darin Adler.
Source/WebCore:
The bug was caused by WebKit doesn't look for the title attribute across shadow boundaries.
Fixed it by using a newly added Node::parentNodeInComposedTree in HitTestResult::title.
Test: fast/shadow-dom/tooltip-on-composed-tree.html
- dom/Node.cpp:
(WebCore::Node::parentInComposedTree): Added.
- dom/Node.h:
- rendering/HitTestResult.cpp:
(WebCore::HitTestResult::title): Fixed the bug.
(WebCore::HitTestResult::innerTextIfTruncated): Fixed a related bug when ShowsToolTipOverTruncatedText
is enabled. Unfortunately, there is no machinery to test this feature yet.
LayoutTests:
Added a regression test for finding a tooltip across shadow boundaries.
- fast/shadow-dom/tooltip-on-composed-tree-expected.txt: Added.
- fast/shadow-dom/tooltip-on-composed-tree.html: Added.
- 1:09 PM Changeset in webkit [200922] by
-
- 34 edits in trunk/Source
CTTE for the HTML editing header
https://bugs.webkit.org/show_bug.cgi?id=157676
Reviewed by Chris Dumez.
Source/WebCore:
- accessibility/AXObjectCache.cpp:
(WebCore::AccessibilityReplacedText::postTextStateChangeNotification): Use auto so we have a
change to compile more efficient code using the more specific types returned, rather than
explicitly using a less specific type like Node.
(WebCore::AXObjectCache::startCharacterOffsetOfParagraph): Ditto.
- accessibility/atk/WebKitAccessibleInterfaceText.cpp: Update for deprecatedIsEditingWhitespace name.
- dom/Position.cpp:
(WebCore::Position::offsetForPositionAfterAnchor): Update to use a reference instead of a pointer.
(WebCore::Position::next): Ditto.
(WebCore::Position::atFirstEditingPositionForNode): Ditto.
(WebCore::Position::atLastEditingPositionForNode): Ditto.
(WebCore::Position::atStartOfTree): Ditto.
(WebCore::Position::atEndOfTree): Ditto.
(WebCore::Position::upstream): Ditto.
(WebCore::Position::downstream): Ditto.
(WebCore::Position::rendersInDifferentPosition): Ditto.
- dom/PositionIterator.cpp:
(WebCore::PositionIterator::increment): Ditto.
(WebCore::PositionIterator::decrement): Ditto.
(WebCore::PositionIterator::atEnd): Ditto.
(WebCore::PositionIterator::atEndOfNode): Ditto.
- editing/AlternativeTextController.cpp:
(WebCore::AlternativeTextController::markPrecedingWhitespaceForDeletedAutocorrectionAfterCommand):
Use new name, deprecatedIsEditingWhitespace.
- editing/ApplyBlockElementCommand.cpp:
(WebCore::ApplyBlockElementCommand::formatSelection): Use auto (see rationale above).
- editing/ApplyStyleCommand.cpp:
(WebCore::ApplyStyleCommand::applyBlockStyle): More of the same.
(WebCore::ApplyStyleCommand::applyRelativeFontStyleChange): Ditto.
(WebCore::ApplyStyleCommand::fixRangeAndApplyInlineStyle): Ditto.
(WebCore::ApplyStyleCommand::isValidCaretPositionInTextNode): Ditto.
(WebCore::ApplyStyleCommand::mergeStartWithPreviousIfIdentical): Ditto.
(WebCore::ApplyStyleCommand::mergeEndWithNextIfIdentical): Ditto.
(WebCore::ApplyStyleCommand::surroundNodeRangeWithElement): Ditto.
- editing/BreakBlockquoteCommand.cpp:
(WebCore::BreakBlockquoteCommand::doApply): Ditto.
- editing/CompositeEditCommand.cpp:
(WebCore::postTextStateChangeNotification): Ditto.
(WebCore::CompositeEditCommand::insertNodeAt): Ditto.
(WebCore::CompositeEditCommand::positionOutsideTabSpan): Ditto.
(WebCore::containsOnlyDeprecatedEditingWhitespace): Ditto.
(WebCore::CompositeEditCommand::shouldRebalanceLeadingWhitespaceFor): Ditto.
(WebCore::CompositeEditCommand::rebalanceWhitespaceAt): Ditto.
(WebCore::CompositeEditCommand::rebalanceWhitespaceOnTextSubstring): Ditto.
(WebCore::CompositeEditCommand::insertNewDefaultParagraphElementAt): Ditto.
(WebCore::CompositeEditCommand::moveParagraphWithClones): Ditto.
(WebCore::CompositeEditCommand::moveParagraphs): Ditto.
- editing/DeleteSelectionCommand.cpp:
(WebCore::DeleteSelectionCommand::initializeStartEnd): Ditto.
(WebCore::DeleteSelectionCommand::handleGeneralDelete): Ditto.
(WebCore::DeleteSelectionCommand::mergeParagraphs): Ditto.
(WebCore::DeleteSelectionCommand::doApply): Ditto.
- editing/EditCommand.cpp:
(WebCore::EditCommand::postTextStateChangeNotification): Ditto.
- editing/EditingStyle.cpp: Ditto.
- editing/Editor.cpp:
(WebCore::Editor::advanceToNextMisspelling): Ditto.
- editing/FormatBlockCommand.cpp:
(WebCore::FormatBlockCommand::formatRange): Ditto.
- editing/IndentOutdentCommand.cpp:
(WebCore::IndentOutdentCommand::outdentParagraph): Ditto.
- editing/InsertLineBreakCommand.cpp:
(WebCore::InsertLineBreakCommand::doApply): Ditto.
- editing/InsertListCommand.cpp:
(WebCore::InsertListCommand::fixOrphanedListChild): Ditto.
(WebCore::InsertListCommand::doApplyForSingleParagraph): Ditto.
(WebCore::InsertListCommand::unlistifyParagraph): Ditto.
(WebCore::InsertListCommand::listifyParagraph): Ditto.
- editing/InsertParagraphSeparatorCommand.cpp:
(WebCore::InsertParagraphSeparatorCommand::doApply): Ditto.
- editing/InsertTextCommand.cpp:
(WebCore::InsertTextCommand::insertTab): Ditto.
- editing/ModifySelectionListLevel.cpp:
(WebCore::IncreaseSelectionListLevelCommand::doApply): Ditto.
- editing/ReplaceSelectionCommand.cpp:
(WebCore::ReplacementFragment::removeUnrenderedNodes): Ditto.
(WebCore::ReplaceSelectionCommand::shouldMerge): Ditto.
(WebCore::ReplaceSelectionCommand::removeRedundantStylesAndKeepStyleSpanInline): Ditto.
(WebCore::ReplaceSelectionCommand::mergeEndIfNeeded): Ditto.
(WebCore::enclosingInline): Ditto.
(WebCore::ReplaceSelectionCommand::doApply): Ditto.
- editing/TextIterator.cpp:
(WebCore::maxOffsetIncludingCollapsedSpaces): Ditto.
- editing/TypingCommand.cpp:
(WebCore::TypingCommand::forwardDeleteKeyPressed): Ditto.
- editing/VisiblePosition.cpp:
(WebCore::VisiblePosition::honorEditingBoundaryAtOrBefore): Ditto.
(WebCore::VisiblePosition::honorEditingBoundaryAtOrAfter): Ditto.
- editing/VisibleSelection.cpp:
(WebCore::VisibleSelection::setStartAndEndFromBaseAndExtentRespectingGranularity): Ditto.
(WebCore::VisibleSelection::adjustSelectionToAvoidCrossingEditingBoundaries): Ditto.
- editing/VisibleUnits.cpp:
(WebCore::previousRootInlineBoxCandidatePosition): Ditto.
(WebCore::nextRootInlineBoxCandidatePosition): Ditto.
(WebCore::startOfParagraph): Ditto.
(WebCore::endOfParagraph): Ditto.
(WebCore::startOfEditableContent): Ditto.
(WebCore::endOfEditableContent): Ditto.
- editing/htmlediting.cpp:
(WebCore::highestEditableRoot): Changed return type to ContainerNode. Maybe later could
change it to Element.
(WebCore::lowestEditableAncestor): Changed return type to Element.
(WebCore::isEditableToAccessibility): Use auto.
(WebCore::isRichlyEditablePosition): Ditto.
(WebCore::editableRootForPosition): Ditto.
(WebCore::unsplittableElementForPosition):Ditto.
(WebCore::nextCandidate): Streamline.
(WebCore::nextVisuallyDistinctCandidate): Ditto.
(WebCore::previousCandidate): Ditto.
(WebCore::previousVisuallyDistinctCandidate): Ditto.
(WebCore::firstEditablePositionAfterPositionInRoot): Changed arugment type to
ContainerNode.
(WebCore::lastEditablePositionBeforePositionInRoot): Ditto.
(WebCore::lastOffsetForEditing): Changed argument type to reference.
(WebCore::stringWithRebalancedWhitespace): Optimized the case where the function does
not need to change the string, so it just returns the passed string rather than a copy.
(WebCore::isTableStructureNode): Use auto.
(WebCore::isSpecialElement): Made this function private to the file. Use auto.
(WebCore::firstInSpecialElement): Return an HTMLElement.
(WebCore::lastInSpecialElement): Ditto.
(WebCore::isFirstVisiblePositionInSpecialElement): Made this function private to the file.
(WebCore::positionBeforeContainingSpecialElement): Changed out argument to HTMLElement.
(WebCore::isLastVisiblePositionInSpecialElement): Ditto.
(WebCore::positionAfterContainingSpecialElement): Ditto.
(WebCore::positionOutsideContainingSpecialElement): Ditto.
(WebCore::isFirstPositionAfterTable): Changed return type to Element.
(WebCore::isLastPositionBeforeTable): Ditto.
(WebCore::visiblePositionBeforeNode): Changed argument type to reference.
(WebCore::visiblePositionAfterNode): Ditto.
(WebCore::enclosingElementWithTag): Use auto. Removed special case for null since the
algorithm already handles null correctly.
(WebCore::enclosingNodeOfType): Use auto.
(WebCore::highestEnclosingNodeOfType): Ditto.
(WebCore::highestNodeToRemoveInPruning): Ditto.
(WebCore::enclosingTableCell): Changed return type to Element.
(WebCore::enclosingAnchorElement): Removed special case for null since the algorithm
already handles null correctly.
(WebCore::enclosingList): Use auto.
(WebCore::enclosingListChild): Use auto.
(WebCore::enclosingEmptyListItem): Use auto.
(WebCore::outermostEnclosingList): Use auto.
(WebCore::canMergeLists): Use references and more specific type. Since both elements are
known to be HTMLElement, compare local names instead of using hasTagName.
(WebCore::isRenderedTable): Use auto.
(WebCore::isTableCell): Ditto.
(WebCore::isEmptyTableCell): Ditto.
(WebCore::createBreakElement): Deleted. Callers can use HTMLBRElement directly.
(WebCore::createOrderedListElement): Deleted. Callers can use HTMLOListElement directly.
(WebCore::createUnorderedListElement): Deleted. Callers can use HTMLUListElement directly.
(WebCore::createListItemElement): Deleted. Callers can use HTMLLIElement directly.
(WebCore::isTabSpanNode): Remove redundant checks and did more specific typecast.
(WebCore::isTabSpanTextNode): Removed redundant null checks.
(WebCore::tabSpanNode): Changed return type to HTMLSpanElement.
(WebCore::positionOutsideTabSpan): Deleted. Unused function.
(WebCore::createTabSpanElement): Made one of the overloads private to this file. Use auto.
Changed argument type since we don't need to support null. Moved createEditingTextNode code,
specific to the version without a string into that function rather than the helper function.
(WebCore::isNodeRendered): Changed argument type to a reference.
(WebCore::numEnclosingMailBlockquotes): Streamlined.
(WebCore::isMailBlockquote): Use downcast instead of static_cast.
(WebCore::caretMinOffset): Take a reference instead of a pointer.
(WebCore::caretMaxOffset): Ditto.
(WebCore::selectionForParagraphIteration): Use auto.
(WebCore::indexForVisiblePosition): Ditto.
(WebCore::visiblePositionForIndex): Ditto.
(WebCore::visiblePositionForIndexUsingCharacterIterator): Ditto.
(WebCore::isVisiblyAdjacent): Made this private to this file.
(WebCore::isNodeVisiblyContainedWithin): Changed argument type to a reference.
(WebCore::areIdenticalElements): Changed argument types to references.
(WebCore::adjustedSelectionStartForStyleComputation): Use auto.
(WebCore::isBlockFlowElement): Changed argument type to a reference. Use auto.
(WebCore::deprecatedEnclosingBlockFlowElement): Updated for reference changes.
(WebCore::rendererForCaretPainting): Use auto.
- editing/htmlediting.h: Use pragma once. Removed unneeded includes and forward declarations.
Removed various non-helpful comments (the sections still don't make sense; not really good to
group functions by their return types). Moved inline functoin bodies to the bottom of the file.
Renamed isWhitespace to deprecatedIsEditingWhitespace.
- editing/markup.cpp:
(WebCore::createFragmentFromText): Use HTMLBRElement.
- page/DOMSelection.cpp:
(WebCore::DOMSelection::extend): Updated since caretMaxOffset takes a reference.
Source/WebKit/ios:
- WebCoreSupport/WebFrameIOS.mm:
(-[WebFrame previousUnperturbedDictationResultBoundaryFromPosition:]): Update since
lastOffsetForEditing takes a reference now. Seems like this code should be in WebCore.
(-[WebFrame nextUnperturbedDictationResultBoundaryFromPosition:]): Ditto.
- 12:18 PM Changeset in webkit [200921] by
-
- 9 edits2 adds in trunk
Support ArrayBufferViews in the CSS Font Loading API
https://bugs.webkit.org/show_bug.cgi?id=157694
<rdar://problem/25554267>
Source/WebCore:
This patch adds a new mode to CSSFontFaceSource for immediate (ArrayBuffer) data.
Then, FontFace can simply be hooked up to this new mode.
Reviewed by Darin Adler.
Test: fast/text/css-font-loading-arraybuffer.html
- css/CSSFontFaceSource.cpp:
(WebCore::CSSFontFaceSource::CSSFontFaceSource):
(WebCore::CSSFontFaceSource::font):
- css/CSSFontFaceSource.h:
- css/FontFace.cpp:
(WebCore::FontFace::create):
- loader/cache/CachedFont.cpp:
(WebCore::CachedFont::ensureCustomFontData):
(WebCore::CachedFont::createCustomFontData):
(WebCore::CachedFont::createFont):
(WebCore::CachedFont::platformDataFromCustomData):
- loader/cache/CachedFont.h:
LayoutTests:
Reviewed by Darin Adler.
- fast/text/css-font-loading-arraybuffer-expected.txt: Added.
- fast/text/css-font-loading-arraybuffer.html: Added.
- 10:56 AM Changeset in webkit [200920] by
-
- 6 edits in trunk/Source/WebCore
[WebIDL] Add support for dictionary members of integer types
https://bugs.webkit.org/show_bug.cgi?id=157703
Reviewed by Darin Adler.
Add support for dictionary members of integer types, including support
for the [Clamp] and [EnforceRange] IDL extended attributes on such
members.
- bindings/js/JSDOMConvert.h:
(WebCore::convert):
(WebCore::convertOptional):
- Add the needed template specializations so we can use convertOptional() with integral types.
- Use std::enable_if so the template specializations meants to be used for floating point types or integral types can only be instantiated for such types.
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateConversionRuleWithLeadingComma):
(GetIntegerConversionConfiguration):
(JSValueToNative):
Generate the right IntegerConversionConfiguration parameter for convert()
and convertOptional() when converting dictionary members of integral
types
- bindings/scripts/IDLParser.pm:
(parseDictionaryMember):
Fix bug in the IDL parser where we weren't initializing the extended
attributes for dictionary members.
- bindings/scripts/test/JS/JSTestObj.cpp:
- bindings/scripts/test/TestObj.idl:
Add bindings tests coverage.
- 9:54 AM Changeset in webkit [200919] by
-
- 3 edits in trunk/Source/WebCore
Allocate MacGlyphToPathTranslator / CairoGlyphToPathTranslator on the stack
https://bugs.webkit.org/show_bug.cgi?id=157690
Reviewed by Myles C. Maxfield.
Allocate MacGlyphToPathTranslator / CairoGlyphToPathTranslator on the
stack. We also now use the subclass type for the local variable so it
will bypass the vtable for various virtual function calls (if the compiler
was not already smart enough to figure this out).
- platform/graphics/cairo/FontCairo.cpp:
(WebCore::FontCascade::dashesForIntersectionsWithRect):
- platform/graphics/cocoa/FontCascadeCocoa.mm:
(WebCore::FontCascade::dashesForIntersectionsWithRect):
- 7:59 AM Changeset in webkit [200918] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Empty line shows arrow when hovering over Animation Frame Requested in timeline recording
https://bugs.webkit.org/show_bug.cgi?id=157707
Reviewed by Timothy Hatcher.
- UserInterface/Views/DataGrid.css:
(.data-grid:not(.variable-height-rows) > .data-container > table.data > tbody > tr > td > div):
May 13, 2016:
- 11:31 PM Changeset in webkit [200917] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed attempt to fix the iOS build after the protector variables renaming.
- platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.cpp:
(WebCore::ResourceHandleCFURLConnectionDelegateWithOperationQueue::willSendRequest):
(WebCore::ResourceHandleCFURLConnectionDelegateWithOperationQueue::didReceiveResponse):
(WebCore::ResourceHandleCFURLConnectionDelegateWithOperationQueue::didReceiveData):
(WebCore::ResourceHandleCFURLConnectionDelegateWithOperationQueue::didFinishLoading):
(WebCore::ResourceHandleCFURLConnectionDelegateWithOperationQueue::didFail):
(WebCore::ResourceHandleCFURLConnectionDelegateWithOperationQueue::willCacheResponse):
(WebCore::ResourceHandleCFURLConnectionDelegateWithOperationQueue::didReceiveChallenge):
(WebCore::ResourceHandleCFURLConnectionDelegateWithOperationQueue::didSendBodyData):
(WebCore::ResourceHandleCFURLConnectionDelegateWithOperationQueue::canRespondToProtectionSpace):
(WebCore::ResourceHandleCFURLConnectionDelegateWithOperationQueue::didReceiveDataArray):
- 10:51 PM Changeset in webkit [200916] by
-
- 5 edits in trunk/Source/JavaScriptCore
jsc: samplingProfilerStackTraces() without starting sampling should not cause jsc to crash
https://bugs.webkit.org/show_bug.cgi?id=157704
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-05-13
Reviewed by Saam Barati.
- jsc.cpp:
(functionStartSamplingProfiler):
(functionSamplingProfilerStackTraces):
Throw an exception instead of crashing if we haven't started sampling.
- inspector/agents/InspectorScriptProfilerAgent.cpp:
(Inspector::InspectorScriptProfilerAgent::startTracking):
- runtime/VM.h:
- runtime/VM.cpp:
(JSC::VM::ensureSamplingProfiler):
Switch ensure to returning a reference, like most other ensures.
- 10:14 PM Changeset in webkit [200915] by
-
- 17 edits in trunk
All scrolling height/width values should be integral rounded.
https://bugs.webkit.org/show_bug.cgi?id=157687
Reviewed by Simon Fraser.
Both clientHeight(Width) and scrollHeight(width) need to be explicitly integral
rounded in order to ensure that scrollable content is computed properly.
This will evolve into subpixel snapping once we apply subpixel arithmetics on scrolling.
Source/WebCore:
Not testable.
- rendering/RenderBox.cpp:
(WebCore::RenderBox::scrollWidth):
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::scrollTo):
(WebCore::RenderLayer::horizontalScrollbarStart):
(WebCore::RenderLayer::scrollWidth):
(WebCore::RenderLayer::scrollHeight):
(WebCore::RenderLayer::computeScrollDimensions):
(WebCore::RenderLayer::updateScrollbarsAfterLayout):
- rendering/RenderLayer.h:
LayoutTests:
- platform/mac/fast/css/text-overflow-ellipsis-text-align-center-expected.txt:
- platform/mac/fast/css/text-overflow-ellipsis-text-align-justify-expected.txt:
- platform/mac/fast/css/text-overflow-ellipsis-text-align-left-expected.txt:
- platform/mac/fast/css/text-overflow-ellipsis-text-align-right-expected.txt:
- platform/mac/fast/css/text-overflow-input-expected.txt:
- platform/mac/fast/css/vertical-text-overflow-ellipsis-text-align-center-expected.txt:
- platform/mac/fast/css/vertical-text-overflow-ellipsis-text-align-justify-expected.txt:
- platform/mac/fast/css/vertical-text-overflow-ellipsis-text-align-left-expected.txt:
- platform/mac/fast/css/vertical-text-overflow-ellipsis-text-align-right-expected.txt:
- 9:58 PM Changeset in webkit [200914] by
-
- 3 edits in trunk/Tools
Fix JSBench which causes math domain error in run-benchmark script.
https://bugs.webkit.org/show_bug.cgi?id=157697
<rdar://problem/26279292>
Reviewed by Ryosuke Niwa.
Some tests of JSBench give time usage to be 0 ms which will causes error while calculating geometric mean.
Also fix a round-off error while calculating stdev.
- Scripts/webkitpy/benchmark_runner/benchmark_results.py:
(BenchmarkResults._format_values):
- Scripts/webkitpy/benchmark_runner/data/patches/JSBench.patch:
- 9:45 PM Changeset in webkit [200913] by
-
- 5 edits in trunk
Extend protector naming code style guideline to cover operator= assignment.
https://bugs.webkit.org/show_bug.cgi?id=157693
Reviewed by Darin Adler.
Tools:
- Scripts/webkitpy/style/checkers/cpp.py:
(check_identifier_name_in_declaration):
- Scripts/webkitpy/style/checkers/cpp_unittest.py:
(WebKitStyleTest.test_names):
Websites/webkit.org:
- code-style.md:
- 7:40 PM Changeset in webkit [200912] by
-
- 2 edits in trunk/Source/WebKit2
Fix iOS Build.
- Shared/AssistedNodeInformation.h:
(WebKit::OptionItem::OptionItem):
- 7:29 PM Changeset in webkit [200911] by
-
- 2 edits in trunk/Source/WebKit2
REGRESSION (r200463): Autofill Credit Card expected but got Autofill Contact
<rdar://problem/26251538>
https://bugs.webkit.org/show_bug.cgi?id=157701
Reviewed by Dan Bernstein.
- WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInFrame.mm:
(-[WKWebProcessPlugInFrame _certificateChain]):
We need to do a retain-autorelease here now because the CertificateInfo's that contain the
cached certificate chain, are being destroyed, and therefore destroying the chain, before this
function returns. This used to work when the chain wasn't just a cache, because there was still
a strong reference to it being held by the ResourceResponse's CertificateInfo copy, but now
there is none.
- 7:27 PM Changeset in webkit [200910] by
-
- 3 edits in trunk/Source/WebKit2
[iOS] <select> elements popover should render right-aligned when in RTL mode
https://bugs.webkit.org/show_bug.cgi?id=157699
<rdar://problem/26282319>
Reviewed by Simon Fraser.
Some follow-up changes as suggested by Darin in review.
- Shared/AssistedNodeInformation.h: Use initializers so we can
remove the constructors.
(WebKit::OptionItem::OptionItem): Deleted.
(WebKit::AssistedNodeInformation::AssistedNodeInformation): Deleted.
- UIProcess/ios/forms/WKFormSelectPopover.mm: Add a comment to explain
why we are explicitly setting the language.
(-[WKSelectTableViewController initWithView:hasGroups:]):
- 7:26 PM Changeset in webkit [200909] by
-
- 8 edits in trunk/Source
[NetworkCache] Avoid having to re-parse URLs after deserializing them
https://bugs.webkit.org/show_bug.cgi?id=157660
Reviewed by Darin Adler.
Source/WebCore:
Avoid having to re-parse URLs after deserializing them in the WebKit2
network cache storage implementation.
We previously serialized URLs as Strings, which meant that we had the
re-parse them upon deserialization. We now serialize all of the URL
data members to avoid having to parse the String again.
- platform/URL.h:
(WebCore::URL::encode):
(WebCore::URL::decode):
- platform/network/ResourceRequestBase.h:
(WebCore::ResourceRequestBase::encodeWithoutPlatformData):
(WebCore::ResourceRequestBase::decodeWithoutPlatformData):
- platform/network/ResourceResponseBase.h:
(WebCore::ResourceResponseBase::encode):
(WebCore::ResourceResponseBase::decode):
Source/WebKit2:
- NetworkProcess/cache/NetworkCacheCoders.cpp:
(WebKit::NetworkCache::Coder<WebCore::CertificateInfo>::encode): Deleted.
(WebKit::NetworkCache::Coder<WebCore::CertificateInfo>::decode): Deleted.
- NetworkProcess/cache/NetworkCacheCoders.h:
Drop template specializations used by our network cache for encoding
/ decoding URLs as Strings. This causes us to now rely on
URL::encode() / URL::decode() instead.
- Shared/WebCoreArgumentCoders.cpp:
(IPC::ArgumentCoder<BlobPart>::decode):
Fix bug in BlobPart encoding / decoding. It was encoding the url member
as a URL but decoding it as a String.
- 7:17 PM Changeset in webkit [200908] by
-
- 8 edits2 adds in trunk
ScriptController::processingUserGesture should propagate across postMessage boundaries
<rdar://problem/26273173>
https://bugs.webkit.org/show_bug.cgi?id=157686
Reviewed by Anders Carlsson.
Source/WebCore:
Test: fast/dom/Window/post-message-user-action.html
- dom/UserGestureIndicator.h:
Export processingUserGesture() for testing.
- page/DOMWindow.cpp:
(WebCore::PostMessageTimer::PostMessageTimer):
(WebCore::PostMessageTimer::event):
Maintain the processingUserGesture bit through postMessage.
- testing/Internals.cpp:
(WebCore::Internals::setResourceTimingSupport):
(WebCore::Internals::isProcessingUserGesture):
- testing/Internals.h:
- testing/Internals.idl:
Add new internals function to get the current state of the UseGestureIndicator for testing.
LayoutTests:
- fast/dom/Window/post-message-user-action-expected.txt: Added.
- fast/dom/Window/post-message-user-action.html: Added.
- 7:10 PM Changeset in webkit [200907] by
-
- 13 edits in trunk
Align window.scroll() / scrollTo() / scrollBy() with the CSSOM specification
https://bugs.webkit.org/show_bug.cgi?id=157666
Reviewed by Darin Adler.
Source/WebCore:
Align window.scroll() / scrollTo() / scrollBy() with Firefox and the CSSOM
specification:
https://drafts.csswg.org/cssom-view/#extensions-to-the-window-interface
In particular, the following changes were made:
- Make parameters to scroll() / scrollTo() / scrollBy() mandatory.
- Add overloads for scroll() / scrollTo() / scrollBy() that take an optional ScrollToOptions dictionary.
- Update API to use "unrestricted double" typing for x/y instead of "long". This matches the specification but it does not really change our behavior at this point because the values are still casted to int in our implementation.
Web-Exposed behavior changes:
- JS can now pass a dictionary to scroll() / scrollTo() / scrollBy(). This a new feature that Firefox already supports (Chrome does not).
- Passing only 1 parameter to scroll() / scrollTo() / scrollBy() that is not a dictionary will now throw a TypeError. The compatibility risky should be low because Firefox and Chrome already throw in this case (Chrome has been throwing for 2 years and a half).
- Calling scrollTo() / scroll() without any parameter no longer scrolls to 0. Instead we use the current viewport's x/y which means we don't scroll at all. The new behavior matches Firefox, Chrome and IE 11. This fixes scrolling on the following Website: https://members.chosun.com/cms_subscribe/application/index.jsp
No new tests, extended existing testing.
- bindings/js/JSDOMConvert.h:
(WebCore::convert):
(WebCore::convertOptional):
- bindings/scripts/CodeGeneratorJS.pm:
(ShouldAllowNonFiniteForFloatingPointType):
(GenerateConversionRuleWithLeadingComma):
(GenerateDictionaryImplementationContent):
(JSValueToNative):
- bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::convert<TestObj::Dictionary>):
- bindings/scripts/test/TestObj.idl:
- page/DOMWindow.cpp:
(WebCore::DOMWindow::scrollBy):
(WebCore::DOMWindow::scrollTo):
- page/DOMWindow.h:
- page/DOMWindow.idl:
LayoutTests:
Update / improve testing coverage for the API.
- fast/dom/Window/window-scroll-arguments-expected.txt:
- fast/dom/Window/window-scroll-arguments.html:
- fast/dom/non-numeric-values-numeric-parameters-expected.txt:
- fast/dom/script-tests/non-numeric-values-numeric-parameters.js:
- 7:03 PM Changeset in webkit [200906] by
-
- 3 edits in trunk/Source/JavaScriptCore
DFG/FTL have a few bugs in their reasoning about the scope
https://bugs.webkit.org/show_bug.cgi?id=157696
Reviewed by Benjamin Poulain.
- When the debugger is enabled, it is easier for the DFG to reason
about the scope register by simply claiming all nodes read the scope
register. This prevents us from ever entering the runtime where we
may take a stack trace but there isn't a scope on the stack.
- This patch fixes a bug where the FTL compilation wasn't properly
setting the CodeBlock register. It was only doing this when there
was inline data, but when the debugger is enabled, we never inline.
So this code just needed to be removed from that loop. It was never
right for it to be inside the loop.
- dfg/DFGClobberize.h:
(JSC::DFG::clobberize):
- ftl/FTLCompile.cpp:
(JSC::FTL::compile):
- 5:20 PM Changeset in webkit [200905] by
-
- 5 edits in branches/safari-601-branch/Source
Versioning.
- 5:19 PM Changeset in webkit [200904] by
-
- 5 edits in branches/safari-601.1.46-branch/Source
Versioning.
- 5:17 PM Changeset in webkit [200903] by
-
- 5 edits in branches/safari-602.1.32-branch/Source
Versioning.
- 5:12 PM Changeset in webkit [200902] by
-
- 5 edits in tags/Safari-602.1.32.2.1/Source
Versioning.
- 5:03 PM Changeset in webkit [200901] by
-
- 5 edits in trunk/Source
Unreviewed, rolling out r200894.
https://bugs.webkit.org/show_bug.cgi?id=157695
This change broke the iOS build (Requested by ryanhaddad on
#webkit).
Reverted changeset:
"Remove unused initializer for WebEvent on iOS."
https://bugs.webkit.org/show_bug.cgi?id=157689
http://trac.webkit.org/changeset/200894
Patch by Commit Queue <commit-queue@webkit.org> on 2016-05-13
- 5:01 PM Changeset in webkit [200900] by
-
- 3 edits1 add in trunk/Websites/perf.webkit.org
v3 UI shows full git hash instead of the first 8 characters for a blame range
https://bugs.webkit.org/show_bug.cgi?id=157691
Reviewed by Stephanie Lewis.
Fixed the bug that v3 UI shows the full 40 character git hash instead of the first 8 character as done in v2 UI.
- public/v3/models/commit-log.js:
(CommitLog.prototype.diff): Fixed the bug.
- tools/run-tests.py:
(main): Add the support for running a subset of tests as mocha does.
- unit-tests/commit-log-tests.js: Added.
- 4:53 PM Changeset in webkit [200899] by
-
- 2 edits in tags/Safari-602.1.32.2.1/Source/JavaScriptCore
Merge r200666.
- 4:45 PM Changeset in webkit [200898] by
-
- 2 edits in trunk/Source/JavaScriptCore
[JSC] SetLocal without exit do not need phantoms
https://bugs.webkit.org/show_bug.cgi?id=157653
Patch by Benjamin Poulain <bpoulain@apple.com> on 2016-05-13
Reviewed by Filip Pizlo.
I made a mistake in r200498.
If a SetLocal cannot possibly exit, we were not clearing
the source of the operand. As a result, we sometime kept
a value alive up to the end of the block.
That's uncommon because SetLocal typically appear
toward the end of blocks. That's probably why there was
no perf impact with that fix.
- dfg/DFGPhantomInsertionPhase.cpp:
- 4:45 PM Changeset in webkit [200897] by
-
- 4 edits in trunk/Source/JavaScriptCore
[JSC] Move the CheckTierUp function calls out of the main path
https://bugs.webkit.org/show_bug.cgi?id=157668
Patch by Benjamin Poulain <bpoulain@apple.com> on 2016-05-13
Reviewed by Mark Lam.
If you have a tiny tiny loop (for example, Sunspider's bits-in-byte),
the size of CheckTierUp is a problem.
On multi-issue CPUs, the node is so big that we do not
get to run anything from the loop in the instruction fetch.
On x86, having a bigger loop also pushes us out of the LSD.
This is a 6% improvement on bits-in-byte. Other Sunspider tests
only improves marginally.
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::addSlowPathGenerator):
(JSC::DFG::SpeculativeJIT::runSlowPathGenerators):
- dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::silentSpill):
(JSC::DFG::SpeculativeJIT::silentFill):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- 4:44 PM Changeset in webkit [200896] by
-
- 2 edits in trunk/Source/JavaScriptCore
[JSC] Emit the loads of emitLoadWithStructureCheck() in the order they are used
https://bugs.webkit.org/show_bug.cgi?id=157671
Patch by Benjamin Poulain <bpoulain@apple.com> on 2016-05-13
Reviewed by Mark Lam.
This improves the chances of having a value
when issuing the TEST.
- jit/JITPropertyAccess.cpp:
(JSC::JIT::emitLoadWithStructureCheck):
- 4:42 PM Changeset in webkit [200895] by
-
- 92 edits in trunk/Source/WebCore
Rename all protector variables that should be called
protectedThis
https://bugs.webkit.org/show_bug.cgi?id=157610
Reviewed by Alex Christensen.
No new tests (Renaming, no behavior change).
WebCore has so many instances of these protectors as well as so much variance in naming them,
that I think it deserved a new style pass.
- Modules/fetch/FetchResponse.cpp:
- Modules/geolocation/GeoNotifier.cpp:
- Modules/geolocation/Geolocation.cpp:
- Modules/indexeddb/IDBTransaction.cpp:
- Modules/indexeddb/client/TransactionOperation.h:
- Modules/indexeddb/server/UniqueIDBDatabase.cpp:
- Modules/indexeddb/server/UniqueIDBDatabaseConnection.cpp:
- Modules/indexeddb/server/UniqueIDBDatabaseTransaction.cpp:
- Modules/indexeddb/shared/InProcessIDBServer.cpp:
- Modules/mediastream/UserMediaRequest.cpp:
- Modules/notifications/NotificationCenter.cpp:
- Modules/webaudio/AudioContext.cpp:
- Modules/webdatabase/Database.cpp:
- Modules/websockets/WebSocket.cpp:
- Modules/websockets/WebSocketChannel.cpp:
- Modules/websockets/WorkerThreadableWebSocketChannel.cpp:
- accessibility/AccessibilityObject.cpp:
- accessibility/AccessibilityRenderObject.cpp:
- bindings/gobject/GObjectEventListener.cpp:
- bindings/js/JSCustomElementInterface.cpp:
- bindings/js/JSCustomSQLStatementErrorCallback.cpp:
- bindings/js/JSCustomXPathNSResolver.cpp:
- bindings/js/JSDOMGlobalObjectTask.cpp:
- bindings/js/JSDOMWindowBase.cpp:
- bindings/js/JSErrorHandler.cpp:
- bindings/js/JSEventListener.cpp:
- bindings/js/JSMutationCallback.cpp:
- bindings/js/JSNodeFilterCustom.cpp:
- bindings/js/SerializedScriptValue.cpp:
- bindings/scripts/CodeGeneratorJS.pm:
- bindings/scripts/test/JS/JSTestCallback.cpp:
- bindings/scripts/test/JS/JSTestCallbackFunction.cpp:
- bridge/runtime_root.cpp:
- css/CSSFontSelector.cpp:
- css/StyleSheetContents.cpp:
- dom/CharacterData.cpp:
- dom/ContainerNode.cpp:
- dom/Document.cpp:
- dom/EventTarget.cpp:
- dom/Node.cpp:
- dom/ScriptExecutionContext.cpp:
- dom/ScriptedAnimationController.cpp:
- dom/StringCallback.cpp:
- html/HTMLEmbedElement.cpp:
- html/HTMLFormControlElement.cpp:
- html/HTMLFormElement.cpp:
- html/HTMLInputElement.cpp:
- html/HTMLLinkElement.cpp:
- html/HTMLMediaElement.cpp:
- html/HTMLObjectElement.cpp:
- html/HTMLOptionElement.cpp:
- html/HTMLScriptElement.cpp:
- html/HTMLTableElement.cpp:
- html/HTMLTextAreaElement.cpp:
- html/HTMLTitleElement.cpp:
- html/parser/HTMLDocumentParser.cpp:
- html/shadow/SliderThumbElement.cpp:
- html/shadow/SpinButtonElement.cpp:
- inspector/InspectorFrontendClientLocal.cpp:
- loader/DocumentLoader.cpp:
- loader/DocumentThreadableLoader.cpp:
- loader/MediaResourceLoader.cpp:
- loader/NetscapePlugInStreamLoader.cpp:
- loader/ResourceLoader.cpp:
- loader/SubresourceLoader.cpp:
- loader/cache/CachedRawResource.cpp:
- loader/cf/SubresourceLoaderCF.cpp:
- loader/mac/ResourceLoaderMac.mm:
- page/DOMWindow.cpp:
- page/DOMWindowExtension.cpp:
- page/FrameView.cpp:
- page/animation/AnimationBase.cpp:
- page/scrolling/ThreadedScrollingTree.cpp:
- platform/ScrollView.cpp:
- platform/graphics/DisplayRefreshMonitor.cpp:
- platform/graphics/ca/win/CACFLayerTreeHost.cpp:
- platform/graphics/gstreamer/InbandTextTrackPrivateGStreamer.cpp:
- platform/ios/WebVideoFullscreenControllerAVKit.mm:
- platform/ios/WebVideoFullscreenInterfaceAVKit.mm:
- platform/mac/WidgetMac.mm:
- platform/network/BlobResourceHandle.cpp:
- platform/network/cf/ResourceHandleCFNet.cpp:
- platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.cpp:
- platform/network/curl/CurlDownload.cpp:
- platform/network/mac/ResourceHandleMac.mm:
- platform/network/soup/SocketStreamHandleSoup.cpp:
- platform/win/PopupMenuWin.cpp:
- workers/WorkerScriptLoader.cpp:
- xml/XMLHttpRequest.cpp:
- xml/parser/XMLDocumentParser.cpp:
- xml/parser/XMLDocumentParserLibxml2.cpp:
- 4:39 PM Changeset in webkit [200894] by
-
- 5 edits in trunk/Source
Remove unused initializer for WebEvent on iOS.
https://bugs.webkit.org/show_bug.cgi?id=157689
Reviewed by Anders Carlsson.
Source/WebCore:
This is no longer used and can be removed.
The logic tied to isPopupVariant has been incorporated
in keyboard flags. The characterSet property is no longer needed too.
- platform/ios/WebEvent.h:
- platform/ios/WebEvent.mm:
(-[WebEvent initWithKeyEventType:timeStamp:characters:charactersIgnoringModifiers:modifiers:isRepeating:withFlags:keyCode:isTabKey:characterSet:]):
(-[WebEvent initWithKeyEventType:timeStamp:characters:charactersIgnoringModifiers:modifiers:isRepeating:isPopupVariant:keyCode:isTabKey:characterSet:]): Deleted.
(-[WebEvent _characterSetDescription]): Deleted.
(-[WebEvent isPopupVariant]): Deleted.
(-[WebEvent characterSet]): Deleted.
Source/WebKit/mac:
Removing use of characterSet property.
- WebView/WebHTMLView.mm:
(-[WebHTMLView _handleEditingKeyEvent:]):
- 4:29 PM Changeset in webkit [200893] by
-
- 3 edits in trunk/Source/JavaScriptCore
Web Inspector: Inform augmenting client when inspector controller is destroyed
https://bugs.webkit.org/show_bug.cgi?id=157688
<rdar://problem/25832724>
Reviewed by Timothy Hatcher.
- inspector/JSGlobalObjectInspectorController.cpp:
(Inspector::JSGlobalObjectInspectorController::~JSGlobalObjectInspectorController):
- inspector/augmentable/AugmentableInspectorControllerClient.h:
There is a weak relationship between the InspectorController and the
AugmentingClient. Let the augmenting client know when the controller
is destroyed so it doesn't try to use us anymore.
- 4:28 PM Changeset in webkit [200892] by
-
- 1 copy in tags/Safari-602.1.32.2.1
New Tag.
- 4:26 PM Changeset in webkit [200891] by
-
- 2 edits in trunk/Source/WebKit2
Try to fix some non-iOS builds.
- mac/postprocess-framework-headers.sh:
- 4:15 PM Changeset in webkit [200890] by
-
- 4 edits in trunk/Websites/perf.webkit.org
Unreviewed. Added the missing executable bits.
- tools/bundle-v3-scripts.py: Added property svn:executable.
- tools/detect-changes.js: Added property svn:executable.
- tools/process-maintenance-backlog.py: Added property svn:executable.
- 3:40 PM Changeset in webkit [200889] by
-
- 4 edits2 adds3 deletes in trunk
cross-fade() rendering doesn't match expectation
https://bugs.webkit.org/show_bug.cgi?id=157665
rdar://problem/17917708
Reviewed by Dean Jackson.
Source/WebCore:
Cross-fading two opaque images would result in a non-opaque result in between the endpoints,
probably because r157045 caused both images to be drawn with srcOver, since drawImage()
clobbers the composite operation in the context.
Fix by passing the composite operation to the drawImage() calls for the non-transparency layer
code path.
Converted css3/images/cross-fade-blending.html into a ref test to test this.
- platform/graphics/CrossfadeGeneratedImage.cpp:
(WebCore::drawCrossfadeSubimage):
LayoutTests:
Make css3/images/cross-fade-blending.html a ref test.
- css3/images/cross-fade-blending-expected.html: Added.
- css3/images/cross-fade-blending-expected.png: Removed.
- css3/images/cross-fade-blending-expected.txt: Removed.
- css3/images/cross-fade-blending.html:
- platform/mac/css3/images/cross-fade-blending-expected.png: Removed.
- 3:40 PM Changeset in webkit [200888] by
-
- 18 edits in trunk
Unprefix -webkit-cross-fade()
https://bugs.webkit.org/show_bug.cgi?id=157632
Reviewed by Darin Adler.
Source/WebCore:
Support unprefixed cross-fade() in addition to the prefixed value when parsing,
and have computed style round-trip the correct one.
If computed style is queried during an image transition, return an unprefixed
cross-fade(). If blending cross-fade values, only return the prefixed function if
both inputs are prefixed.
Tested by modified and existing tests.
- css/CSSCrossfadeValue.cpp:
(WebCore::CSSCrossfadeValue::customCSSText):
(WebCore::CSSCrossfadeValue::blend):
- css/CSSCrossfadeValue.h:
(WebCore::CSSCrossfadeValue::create):
(WebCore::CSSCrossfadeValue::isPrefixed):
(WebCore::CSSCrossfadeValue::CSSCrossfadeValue):
- css/CSSParser.cpp:
(WebCore::CSSParser::isGeneratedImageValue):
(WebCore::CSSParser::parseGeneratedImage):
(WebCore::CSSParser::parseCrossfade):
- css/CSSParser.h:
Source/WebInspectorUI:
- UserInterface/Models/CSSKeywordCompletions.js:
LayoutTests:
- animations/cross-fade-background-image-expected.html:
- animations/cross-fade-background-image.html:
- animations/cross-fade-border-image-source.html:
- animations/cross-fade-list-style-image.html:
- animations/cross-fade-webkit-mask-box-image.html:
- animations/cross-fade-webkit-mask-image.html:
- animations/resources/animation-test-helpers.js:
(parseCSSImage):
(parseCrossFade):
(compareCSSImages):
- fast/css/getComputedStyle/computed-style-cross-fade-expected.txt:
- fast/css/getComputedStyle/computed-style-cross-fade.html:
- transitions/resources/transition-test-helpers.js:
(parseCrossFade):
- 3:34 PM Changeset in webkit [200887] by
-
- 8 edits4 adds in trunk
ResourceTiming entries for cached resources and XHR
https://bugs.webkit.org/show_bug.cgi?id=157669
Reviewed by Alex Christensen.
Source/WebCore:
- Moves the ResourceTiming storage and addition logic into its own class, so that it can be accessed by both CachedResourceLoader and DocumentThreadableLoader.
- Using the above, adds ResourceTiming collection into DocumentThreadableLoader, in order to support ResourceTiming entries for XHR based requests.
- Adds ResourceTiming entries for resources that are reused from the memory cache.
Test: http/tests/performance/performance-resource-timing-cached-entries.html
- CMakeLists.txt: Add ResourceTimingInformation.
- WebCore.xcodeproj/project.pbxproj: Add ResourceTimingInformation.
- loader/DocumentThreadableLoader.cpp:
(WebCore::DocumentThreadableLoader::didFinishLoading): Add a call to addResourceTiming.
(WebCore::DocumentThreadableLoader::loadRequest): Store the initiator information.
- loader/DocumentThreadableLoader.h:
- loader/ResourceTimingInformation.cpp: Added.
(WebCore::ResourceTimingInformation::addResourceTiming): Moved addResourceTiming logic from CachedResourceLoader.
(WebCore::ResourceTimingInformation::storeResourceTimingInitiatorInformation): Moved addResourceTiming logic from
CachedResourceLoader. Removed reliance on the committingFirstRealLoad bool when storing initiator info, as I don't
see why it is required, and it made no sense in the context of DocumentThreadableLoader.
- loader/ResourceTimingInformation.h: Added.
- loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::requestResource): Add a ResourceTiming entry when a resource is reused from MemoryCache.
(WebCore::CachedResourceLoader::revalidateResource): Use ResourceTimingInformation::storeResourceTimingInitiatorInformation.
(WebCore::CachedResourceLoader::loadResource): Use ResourceTimingInformation::storeResourceTimingInitiatorInformation.
(WebCore::CachedResourceLoader::loadDone): Use ResourceTimingInformation::addResourceTiming.
(WebCore::CachedResourceLoader::storeResourceTimingInitiatorInformation): Deleted.
- loader/cache/CachedResourceLoader.h:
LayoutTests:
These tests make sure that cacheable resources as well as XHR based resources
have ResourceTiming entries.
- http/tests/performance/performance-resource-timing-cached-entries-expected.txt: Added.
- http/tests/performance/performance-resource-timing-cached-entries.html: Added.
- 3:22 PM Changeset in webkit [200886] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Typing "layout" in filter for Layout and Rendering Timeline matches everything
https://bugs.webkit.org/show_bug.cgi?id=157684
<rdar://problem/26276588>
Reviewed by Joseph Pecoraro.
Hidden columns should not participate in built-in grid filtering
using DataGrid.filterText. Hidden columns can still be custom filtered,
which is how TimelineDataGrid filters scopebar columns.
- UserInterface/Views/DataGrid.js:
(WebInspector.DataGridNode.prototype.get filterableData):
Skip hidden columns.
- 2:40 PM Changeset in webkit [200885] by
-
- 2 edits in branches/safari-601-branch/LayoutTests
Merge r194403. rdar://problem/26274768
- 2:24 PM Changeset in webkit [200884] by
-
- 2 edits in trunk/Source/JavaScriptCore
Runaway malloc memory usage in this simple JSC program
https://bugs.webkit.org/show_bug.cgi?id=157682
Reviewed by Mark Lam.
- heap/WeakSet.cpp:
(JSC::WeakSet::sweep): Whenever we might add a block to
m_logicallyEmptyWeakBlocks, be sure also to sweep a block in
m_logicallyEmptyWeakBlocks. Otherwise, additions might outpace removals
even when all memory is freed.
We do this whenever we *might* add a block and not just whenever we *do*
add a block because we'd like to sweep the entries in
m_logicallyEmptyWeakBlocks promptly even when it's not growing, and this
is a reasonably rate-limited opportunity to do so.
- 2:22 PM Changeset in webkit [200883] by
-
- 1 copy in tags/Safari-601.7.2
New Tag.
- 2:21 PM Changeset in webkit [200882] by
-
- 1 copy in tags/Safari-601.1.46.141
New Tag.
- 1:47 PM Changeset in webkit [200881] by
-
- 1 copy in tags/Safari-602.1.32.2
New Tag.
- 1:35 PM Changeset in webkit [200880] by
-
- 9 edits in trunk/Tools
Dashboard code restructuring
https://bugs.webkit.org/show_bug.cgi?id=157680
<rdar://problem/14736888>
Reviewed by Alexey Proskuryakov.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueView.js:
(BubbleQueueView.prototype.addLinkToRow): Moved to base class.
(BubbleQueueView.prototype.addTextToRow): Moved to base class.
(BubbleQueueView.prototype._addDividerToPopover): Moved to base class.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
(BuildbotBuilderQueueView.prototype.update): Passing additional argument to _appendPendingRevisionCount.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js:
(BuildbotCombinedQueueView.prototype.update): Passing additional argument to _appendPendingRevisionCount.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
(BuildbotTesterQueueView.prototype.update): Passing additional argument to _appendPendingRevisionCount.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
(BuildbotQueueView.prototype._appendPendingRevisionCount): Moved to base class and modified to take
additional argument.
(BuildbotQueueView.prototype._popoverLinesForCommitRange): Moved to base class.
(BuildbotQueueView.prototype._presentPopoverForPendingCommits): Moved to base class.
(BuildbotQueueView.prototype._addDividerToPopover): Moved to base class.
(BuildbotQueueView.prototype._formatRevisionForDisplay): Moved to base class.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
(documentReady): Display any customView if available.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/QueueView.js:
(QueueView.prototype.addLinkToRow): Moved from child class, no changes.
(QueueView.prototype.addTextToRow): Moved from child class, no changes.
(QueueView.prototype._addDividerToPopover): Moved from child class, no changes.
(QueueView.prototype._appendPendingRevisionCount): Moved from child class, made it more generic
by taking latestIterationGetter method as an argument.
(QueueView.prototype._popoverLinesForCommitRange): Moved from child class, no changes.
(QueueView.prototype._presentPopoverForPendingCommits): Moved from child class, no changes.
(QueueView.prototype._formatRevisionForDisplay): Moved from child class, no changes.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
(a:hover:link): Underline only when there is a link.
- 1:16 PM Changeset in webkit [200879] by
-
- 29 edits in trunk
We should have one calleeSaveRegistersBuffer per VMEntryFrame, not one per VM.
https://bugs.webkit.org/show_bug.cgi?id=157537
<rdar://problem/24794845>
Reviewed by Michael Saboff.
Source/JavaScriptCore:
The pre-existing code behaves this way:
- When JS code throws an exception, it saves callee save registers in the VM calleeSaveRegistersBuffer. These values are meant to be restored to the callee save registers later either at the catch handler or at the uncaught exception handler.
- If the Inspector is enable, the VM will invoke inspector C++ code to inspect the exception. That C++ code can change the values of the callee save registers.
The inspector code in turn re-enters the VM to execute JS inspector code.
The JS inspector code can run hot enough that we do an enterOptimizationCheck
on it. The enterOptimizationCheck first saves all callee save registers
into the VM calleeSaveRegistersBuffer.
This effectively overwrites the values in the VM calleeSaveRegistersBuffer
from (1).
- Eventually, execution returns to the catch handler or the uncaught exception handler which restores the overwritten values in the VM calleeSaveRegistersBuffer to the callee save registers.
When execution returns to the C++ code that entered the VM before (1), the
values in the callee registers are not what that code expects, and badness
and/or crashes ensues.
This patch applies the following fix:
- Allocate space in the VMEntryFrame for the calleeSaveRegistersBuffer. This ensures that each VM entry session has its own buffer to use, and will not corrupt the one from the previous VM entry session.
Delete the VM calleeSaveRegistersBuffer.
- Change all locations that uses the VM calleeSaveRegistersBuffer to use the calleeSaveRegistersBuffer in the current VMEntryFrame.
- Renamed all uses of the term "VMCalleeSavesBuffer" to "VMEntryFrameCalleeSavesBuffer".
This fix has been tested on the following configurations:
- JSC and layout tests on a debug ASan build for 64-bit x86_64.
- JSC tests on a release ASan build for 32-bit x86.
- JSC tests on a release normal (non-ASan) build for ARM64.
- JSC tests on a release normal (non-ASan) build for ARMv7 and ARMv7s.
- JSC tests on a release ASan CLOOP build for x86_64.
These test runs did not produce any new crashes. The ASan CLOOP has some
pre-existing crashes which are not due to this patch.
This bug can be tested by running the inspector/debugger/regress-133182.html test
on an ASan build.
- bytecode/PolymorphicAccess.cpp:
(JSC::AccessGenerationState::emitExplicitExceptionHandler):
- dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::compileExceptionHandlers):
- dfg/DFGOSREntry.cpp:
(JSC::DFG::prepareOSREntry):
- dfg/DFGOSRExitCompiler.cpp:
- dfg/DFGOSRExitCompiler32_64.cpp:
(JSC::DFG::OSRExitCompiler::compileExit):
- dfg/DFGOSRExitCompiler64.cpp:
(JSC::DFG::OSRExitCompiler::compileExit):
- dfg/DFGThunks.cpp:
(JSC::DFG::osrEntryThunkGenerator):
- ftl/FTLCompile.cpp:
(JSC::FTL::compile):
- ftl/FTLLowerDFGToB3.cpp:
(JSC::FTL::DFG::LowerDFGToB3::lower):
- ftl/FTLOSRExitCompiler.cpp:
(JSC::FTL::compileStub):
- interpreter/Interpreter.cpp:
(JSC::UnwindFunctor::operator()):
(JSC::UnwindFunctor::copyCalleeSavesToVMEntryFrameCalleeSavesBuffer):
(JSC::UnwindFunctor::copyCalleeSavesToVMCalleeSavesBuffer): Deleted.
- interpreter/Interpreter.h:
(JSC::NativeCallFrameTracer::NativeCallFrameTracer):
- interpreter/VMEntryRecord.h:
(JSC::VMEntryRecord::calleeSaveRegistersBufferOffset):
(JSC::VMEntryRecord::prevTopCallFrame):
(JSC::VMEntryRecord::unsafePrevTopCallFrame):
(JSC::VMEntryFrame::vmEntryRecordOffset):
(JSC::VMEntryFrame::calleeSaveRegistersBufferOffset):
- jit/AssemblyHelpers.cpp:
(JSC::AssemblyHelpers::emitRandomThunk):
(JSC::AssemblyHelpers::restoreCalleeSavesFromVMEntryFrameCalleeSavesBuffer):
(JSC::AssemblyHelpers::restoreCalleeSavesFromVMCalleeSavesBuffer): Deleted.
- jit/AssemblyHelpers.h:
(JSC::AssemblyHelpers::emitRestoreSavedTagRegisters):
(JSC::AssemblyHelpers::copyCalleeSavesToVMEntryFrameCalleeSavesBuffer):
(JSC::AssemblyHelpers::copyCalleeSavesFromFrameOrRegisterToVMEntryFrameCalleeSavesBuffer):
(JSC::AssemblyHelpers::copyCalleeSavesToVMCalleeSavesBuffer): Deleted.
(JSC::AssemblyHelpers::copyCalleeSavesFromFrameOrRegisterToVMCalleeSavesBuffer): Deleted.
- jit/JIT.cpp:
(JSC::JIT::emitEnterOptimizationCheck):
(JSC::JIT::privateCompileExceptionHandlers):
- jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_throw):
(JSC::JIT::emit_op_catch):
(JSC::JIT::emitSlow_op_loop_hint):
- jit/JITOpcodes32_64.cpp:
(JSC::JIT::emit_op_throw):
(JSC::JIT::emit_op_catch):
- jit/ThunkGenerators.cpp:
(JSC::throwExceptionFromCallSlowPathGenerator):
(JSC::nativeForGenerator):
- llint/LLIntThunks.cpp:
(JSC::vmEntryRecord):
- llint/LowLevelInterpreter.asm:
- llint/LowLevelInterpreter32_64.asm:
- llint/LowLevelInterpreter64.asm:
- runtime/VM.h:
(JSC::VM::getCTIStub):
(JSC::VM::calleeSaveRegistersBufferOffset): Deleted.
- wasm/WASMFunctionCompiler.h:
(JSC::WASMFunctionCompiler::endFunction):
LayoutTests:
- inspector/debugger/regress-133182-expected.txt:
- Rebased test results to update line numbers.
- platform/mac/TestExpectations:
- Unskip the test.
- 12:42 PM Changeset in webkit [200878] by
-
- 2 edits in trunk/Websites/perf.webkit.org
Summary page doesn't report some missing platforms
https://bugs.webkit.org/show_bug.cgi?id=157670
Reviewed by Darin Adler.
This patch improves the warning text for missing platforms and fixes the bug that platforms that don't have
any data reported for a given test would not be reported as missing.
- public/v3/pages/summary-page.js:
(SummaryPage.prototype.render): Added instrumentations.
(SummaryPage.prototype._constructRatioGraph): Always create both the ratio bar graph and the spinner icon.
(SummaryPage.prototype._renderCell): Extracted from _constructRatioGraph. Toggle the displayed-ness of the
spinner and the ratio bar graph in the cell by CSS for better performance.
(SummaryPage.prototype._warningTextForGroup): Extracted from _constructRatioGraph. Rephrased warning text
for clarity and adopted new API of SummaryPageConfigurationGroup.
(SummaryPage.prototype._warningTextForGroup.mapAndSortByName): Added.
(SummaryPage.prototype._warningTextForGroup.pluralizeIfNeeded): Added.
(SummaryPage.cssTemplate): Added rules to toggle the visibility of spinner icons and bar graphs.
(SummaryPageConfigurationGroup): Replaced this._warnings by more explicitly named this._missingPlatforms
and this._platformsWithoutBaseline. Also add a platform to this._missingPlatforms if it didn't appear in
any metrics. Note that adding a platform whenever it doesn't in any one metric would be incorrect since
some tests uses a different test name on different platforms: e.g. PLT-Mac and PLT-iPhone.
(SummaryPageConfigurationGroup.prototype.missingPlatforms): Added.
(SummaryPageConfigurationGroup.prototype.platformsWithoutBaseline): Added.
(SummaryPageConfigurationGroup.prototype._fetchAndComputeRatio):
- 12:42 PM Changeset in webkit [200877] by
-
- 2 edits in trunk/Source/WebKit2
Attempt to fix the iOS build after r200874
Unreviewed build fix.
- UIProcess/API/Cocoa/WKWebViewConfiguration.h:
- 12:34 PM Changeset in webkit [200876] by
-
- 13 edits in trunk
AX: Regressions in undo/redo accessibility from Bug 153361
https://bugs.webkit.org/show_bug.cgi?id=157652
Reviewed by Darin Adler.
Use indexForVisiblePosition & visiblePositionForIndex to store selection data
so that AccessibilityUndoReplacedText can build valid selection ranges and
retrieve strings for AT notifications.
Source/WebCore:
Tests: accessibility/mac/value-change/value-change-user-info-contenteditable-expected.txt:
accessibility/mac/value-change/value-change-user-info-contenteditable.html:
accessibility/mac/value-change/value-change-user-info-textarea-expected.txt:
accessibility/mac/value-change/value-change-user-info-textarea.html:
accessibility/mac/value-change/value-change-user-info-textfield-expected.txt:
accessibility/mac/value-change/value-change-user-info-textfield.html:
- accessibility/AXObjectCache.cpp:
(WebCore::AccessibilityReplacedText::AccessibilityReplacedText):
(WebCore::AXObjectCache::postTextStateChangeNotification):
(WebCore::AXObjectCache::postTextReplacementNotification):
- editing/CompositeEditCommand.cpp:
(WebCore::AccessibilityUndoReplacedText::configureRangeDeletedByReapplyWithEndingSelection):
(WebCore::AccessibilityUndoReplacedText::configureRangeDeletedByReapplyWithStartingSelection):
(WebCore::AccessibilityUndoReplacedText::setRangeDeletedByUnapply):
(WebCore::AccessibilityUndoReplacedText::captureTextForUnapply):
(WebCore::AccessibilityUndoReplacedText::captureTextForReapply):
(WebCore::AccessibilityUndoReplacedText::textDeletedByUnapply):
(WebCore::AccessibilityUndoReplacedText::textDeletedByReapply):
(WebCore::AccessibilityUndoReplacedText::postTextStateChangeNotificationForUnapply):
(WebCore::AccessibilityUndoReplacedText::postTextStateChangeNotificationForReapply):
(WebCore::EditCommandComposition::EditCommandComposition):
(WebCore::EditCommandComposition::unapply):
(WebCore::EditCommandComposition::reapply):
(WebCore::EditCommandComposition::setStartingSelection):
(WebCore::EditCommandComposition::setEndingSelection):
(WebCore::EditCommandComposition::setRangeDeletedByUnapply):
(WebCore::AccessibilityUndoReplacedText::confgureTextToBeDeletedByUnapplyIndexesWithEditCommandEndingSelection): Deleted.
(WebCore::AccessibilityUndoReplacedText::confgureTextToBeDeletedByUnapplyStartIndexWithEditCommandStartingSelection): Deleted.
(WebCore::AccessibilityUndoReplacedText::setTextInsertedByUnapplyRange): Deleted.
(WebCore::AccessibilityUndoReplacedText::captureTextToBeDeletedByUnapply): Deleted.
(WebCore::AccessibilityUndoReplacedText::captureTextToBeDeletedByReapply): Deleted.
(WebCore::AccessibilityUndoReplacedText::textInsertedByUnapply): Deleted.
(WebCore::AccessibilityUndoReplacedText::textInsertedByReapply): Deleted.
(WebCore::EditCommandComposition::setTextInsertedByUnapplyRange): Deleted.
- editing/CompositeEditCommand.h:
- editing/Editor.cpp:
(WebCore::Editor::replaceSelectionWithFragment):
- editing/TypingCommand.cpp:
(WebCore::TypingCommand::postTextStateChangeNotificationForDeletion):
(WebCore::TypingCommand::insertTextAndNotifyAccessibility):
(WebCore::TypingCommand::insertLineBreakAndNotifyAccessibility):
(WebCore::TypingCommand::insertParagraphSeparatorAndNotifyAccessibility):
(WebCore::TypingCommand::insertParagraphSeparatorInQuotedContentAndNotifyAccessibility):
LayoutTests:
- accessibility/mac/value-change/value-change-user-info-contenteditable-expected.txt:
- accessibility/mac/value-change/value-change-user-info-contenteditable.html:
- accessibility/mac/value-change/value-change-user-info-textarea-expected.txt:
- accessibility/mac/value-change/value-change-user-info-textarea.html:
- accessibility/mac/value-change/value-change-user-info-textfield-expected.txt:
- accessibility/mac/value-change/value-change-user-info-textfield.html:
- 12:19 PM Changeset in webkit [200875] by
-
- 22 edits in trunk/Source
Unreviewed, rolling out r200837.
Seems to have regressed Speedometer and JetStream on iOS
Reverted changeset:
"DOMPromise should only restrict the resolution type"
https://bugs.webkit.org/show_bug.cgi?id=157307
http://trac.webkit.org/changeset/200837
- 12:14 PM Changeset in webkit [200874] by
-
- 9 edits in trunk/Source
Rename WKDataDetectorTypeSpotlightSuggestion to WKDataDetectorTypeLookupSuggestion
<rdar://problem/26269611>
Reviewed by Dan Bernstein and Enrica Casucci.
Source/WebCore:
- editing/cocoa/DataDetection.h:
- editing/cocoa/DataDetection.mm:
(WebCore::constructURLStringForResult):
(WebCore::DataDetection::detectContentInRange):
Source/WebKit2:
- Shared/API/Cocoa/WKFoundation.h:
- Shared/API/c/WKDeclarationSpecifiers.h:
- UIProcess/API/Cocoa/WKWebView.mm:
(fromWKDataDetectorTypes):
- UIProcess/API/Cocoa/WKWebViewConfiguration.h:
- mac/postprocess-framework-headers.sh:
- 12:01 PM Changeset in webkit [200873] by
-
- 8 edits in trunk/Source/WebInspectorUI
Web Inspector: Script ProfileViews should be searchable
https://bugs.webkit.org/show_bug.cgi?id=157581
<rdar://problem/26228530>
Reviewed by Joseph Pecoraro.
- UserInterface/Views/DataGrid.js:
(WebInspector.DataGrid.prototype.get filterText):
Make filterText readable.
- UserInterface/Views/ProfileDataGridNode.js:
(WebInspector.ProfileDataGridNode.prototype.get callingContextTreeNode):
(WebInspector.ProfileDataGridNode.prototype.filterableDataForColumn):
Add filterable data for the "function" column.
(WebInspector.ProfileDataGridNode.prototype._updateChildrenForModifiers):
(WebInspector.ProfileDataGridNode.prototype.get node): Deleted.
Renamed callingContextTreeNode to be less ambiguous.
- UserInterface/Views/ProfileDataGridTree.js:
(WebInspector.ProfileDataGridTree.prototype._updateCurrentFocusDetails):
- UserInterface/Views/ProfileView.js:
(WebInspector.ProfileView.prototype.get dataGrid):
Expose data grid for use in parent view.
- UserInterface/Views/ScriptClusterTimelineView.js:
(WebInspector.ScriptClusterTimelineView.prototype.selectRecord):
Drive-by fix: forward property to current child TimelineView.
- UserInterface/Views/ScriptProfileTimelineView.js:
(WebInspector.ScriptProfileTimelineView):
(WebInspector.ScriptProfileTimelineView.prototype._scopeBarSelectionDidChange):
(WebInspector.ScriptProfileTimelineView.prototype._showProfileViewForOrientation):
Helper function to switch profile views. Persist filter text when
switching to the new profile view.
(WebInspector.ScriptProfileTimelineView.prototype.get showsFilterBar): Deleted.
Remove FIXME and show filter bar.
- UserInterface/Views/TimelineView.js:
(WebInspector.TimelineView.prototype.setupDataGrid):
Support switching to a new data grid.
(WebInspector.TimelineView.prototype.dataGridMatchNodeAgainstCustomFilters):
Hooking up filtering causes data grid nodes to be filtered based on the
ruler selection. Although ScriptProfileTimelineView performs its own
time-based filtering, this is necessary to prevent an assert.
(WebInspector.TimelineView.prototype._timelineDataGridSelectedNodeChanged):
(WebInspector.TimelineView.prototype._timelineDataGridNodeWasFiltered):
Converted arrow functions to member functions to allow unregistering
event listeners on outgoing data grid when swapping grids.
- 11:57 AM Changeset in webkit [200872] by
-
- 3 edits2 adds in trunk
AX: Wrong CharacterOffset from an upstream VisiblePosition
https://bugs.webkit.org/show_bug.cgi?id=157644
Reviewed by Chris Fleizach.
Source/WebCore:
We should adjust the text marker's CharacterOffset if its corresponding
VisiblePosition has upstream affinity.
Test: accessibility/mac/character-offset-from-upstream-position.html
- accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::characterOffsetForTextMarkerData):
(WebCore::AXObjectCache::traverseToOffsetInRange):
(WebCore::AXObjectCache::localCaretRectForCharacterOffset):
LayoutTests:
- accessibility/mac/character-offset-from-upstream-position-expected.txt: Added.
- accessibility/mac/character-offset-from-upstream-position.html: Added.
- 11:56 AM Changeset in webkit [200871] by
-
- 3 edits1 add in branches/safari-601.1.46-branch/Source/JavaScriptCore
Merge r196490. rdar://problem/26270871
- 11:56 AM Changeset in webkit [200870] by
-
- 4 edits in branches/safari-601.1.46-branch/Source/JavaScriptCore
Merge r196240. rdar://problem/26271188
- 11:45 AM Changeset in webkit [200869] by
-
- 3 edits1 add in branches/safari-601-branch/Source/JavaScriptCore
Merge r196490. rdar://problem/26270811
- 11:45 AM Changeset in webkit [200868] by
-
- 4 edits in branches/safari-601-branch/Source/JavaScriptCore
Merge r196240. rdar://problem/26271108
- 11:45 AM Changeset in webkit [200867] by
-
- 2 edits in trunk/Source/WebKit/mac
Build fix.
- WebView/WebView.mm:
- 11:29 AM Changeset in webkit [200866] by
-
- 15 edits1 add1 delete in trunk/Source
Source/JavaScriptCore:
Add dyldSPI.h for linked on or after checks, and add one for link preview
https://bugs.webkit.org/show_bug.cgi?id=157401
-and corresponding-
rdar://problem/26253396
Reviewed by Darin Adler.
Import #import <wtf/spi/darwin/dyldSPI.h> which now declares all of the
needed dyld code.
- API/JSWrapperMap.mm:
Source/WebCore:
Add dyldSPI.h for linked on or after checks, and add one for link preview
https://bugs.webkit.org/show_bug.cgi?id=157401
-and corresponding-
rdar://problem/26253396
Reviewed by Darin Adler.
This patch removes DynamicLinkerSPI.h and replaces it with
wtf/spi/darwin/dyldSPI.h
- WebCore.xcodeproj/project.pbxproj:
- html/HTMLObjectElement.cpp:
- platform/graphics/ios/FontServicesIOS.mm:
- platform/spi/cocoa/DynamicLinkerSPI.h: Removed.
Source/WebKit/ios:
Add dyldSPI.h for linked on or after checks, and add one for link preview
https://bugs.webkit.org/show_bug.cgi?id=157401
-and corresponding-
rdar://problem/26253396
Reviewed by Darin Adler.
This patch removes DynamicLinkerSPI.h and replaces it with
wtf/spi/darwin/dyldSPI.h
- Misc/WebUIKitSupport.mm:
Source/WebKit/mac:
Add dyldSPI.h for linked on or after checks, and add one for link preview
https://bugs.webkit.org/show_bug.cgi?id=157401
-and corresponding-
rdar://problem/26253396
Reviewed by Darin Adler.
This patch removes DynamicLinkerSPI.h and replaces it with
wtf/spi/darwin/dyldSPI.h
- WebView/WebView.mm:
Source/WebKit2:
Add dyldSPI.h for linked on or after checks, and add one for link preview
https://bugs.webkit.org/show_bug.cgi?id=157401
Reviewed by Darin Adler.
Set _allowsLinkPreview to YES for programs linked on or after
firstSDKVersionWithLinkPreviewEnabledByDefault.
- UIProcess/API/Cocoa/WKWebView.h:
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _initializeWithConfiguration:]):
Source/WTF:
Add dyldSPI.h
https://bugs.webkit.org/show_bug.cgi?id=157401
-and corresponding-
rdar://problem/26253396
Reviewed by Darin Adler.
New header for dyld spi.
- WTF.xcodeproj/project.pbxproj:
- wtf/spi/darwin/dyldSPI.h: Added.
- 11:11 AM Changeset in webkit [200865] by
-
- 5 edits in branches/safari-601.1.46-branch/Source
Versioning.
- 11:11 AM Changeset in webkit [200864] by
-
- 5 edits in branches/safari-601-branch/Source
Versioning.
- 11:06 AM Changeset in webkit [200863] by
-
- 6 edits in trunk
Turn on WEB_TIMING for all ports
https://bugs.webkit.org/show_bug.cgi?id=157673
Reviewed by Alex Christensen.
.:
Turn on WEB_TIMING by default on the cmake Mac port, to match it with all other ports,
and make sure that the flag will be on by default for all ports.
- Source/cmake/OptionsGTK.cmake: Remove the specific private flag for WEB_TIMING.
- Source/cmake/OptionsMac.cmake: Remove the specific private flag for WEB_TIMING.
- Source/cmake/WebKitFeatures.cmake: Turn on WEB_TIMING for all ports by default.
Tools:
- Scripts/webkitperl/FeatureList.pm: Make sure that WEB_TIMING is on by default.
- 10:42 AM Changeset in webkit [200862] by
-
- 2 edits in trunk/Source/WebKit2
Fullscreen view attempts to resize when in 2-up mode
https://bugs.webkit.org/show_bug.cgi?id=157558
Reviewed by Darin Adler.
No need to react to NSApplicationDidChangeScreenParametersNotification to resize the
fullscreen window when the screen parameters change; the NSWindow fullscreen machinery
will do that on our behalf.
- UIProcess/mac/WKFullScreenWindowController.mm:
(-[WKFullScreenWindowController windowDidLoad]): Deleted.
(-[WKFullScreenWindowController applicationDidChangeScreenParameters:]): Deleted.
- 10:37 AM Changeset in webkit [200861] by
-
- 3 edits in trunk/Source/WebCore
Give CrossThreadCopier a default specialization for Vectors of objects.
https://bugs.webkit.org/show_bug.cgi?id=157675
Reviewed by Darin Adler.
No new tests (Refactor, no change in behavior).
- platform/CrossThreadCopier.cpp:
(WebCore::Vector<String>>::copy): Deleted.
- platform/CrossThreadCopier.h: Add a default specialization for Vector<T> where T is a type that is CrossThreadCopyable itself.
- 10:29 AM Changeset in webkit [200860] by
-
- 2 edits in trunk/LayoutTests
Marking fast/text-autosizing/ios/text-autosizing-after-back.html as a flaky timeout
https://bugs.webkit.org/show_bug.cgi?id=157589
Unreviewed test gardening.
- 9:16 AM Changeset in webkit [200859] by
-
- 5 edits in trunk
Protector Ref/RefPtrs should have a specified naming style.
https://bugs.webkit.org/show_bug.cgi?id=157591
Reviewed by Darin Adler.
Tools:
- Scripts/webkitpy/style/checkers/cpp.py:
(check_identifier_name_in_declaration):
(CppChecker):
- Scripts/webkitpy/style/checkers/cpp_unittest.py:
(WebKitStyleTest.test_names):
Websites/webkit.org:
- code-style.md:
- 9:06 AM Changeset in webkit [200858] by
-
- 5 edits in trunk/Source/WebKit2
[iOS] <select> elements popover should render right-aligned when in RTL mode
https://bugs.webkit.org/show_bug.cgi?id=157672
<rdar://problem/26193442>
Patch by Antoine Quint <Antoine Quint> on 2016-05-13
Reviewed by Darin Adler.
Add a new isRTL field to the AssistedNodeInformation as specified by the assisted
node's render style and account for it when displaying the table view shown in the
popover attached to the assisted node using the UIView semanticContentAttribute
property.
- Shared/AssistedNodeInformation.cpp:
(WebKit::AssistedNodeInformation::encode):
(WebKit::AssistedNodeInformation::decode):
- Shared/AssistedNodeInformation.h:
(WebKit::AssistedNodeInformation::AssistedNodeInformation):
- UIProcess/ios/forms/WKFormSelectPopover.mm:
(-[WKSelectTableViewController initWithView:hasGroups:]):
(-[WKSelectTableViewController tableView:cellForRowAtIndexPath:]):
- WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::getAssistedNodeInformation):
- 7:58 AM Changeset in webkit [200857] by
-
- 3 edits in trunk/Source/WebCore
Have the WorkerGlobalScope API return more references
https://bugs.webkit.org/show_bug.cgi?id=157663
Reviewed by Alexey Proskuryakov.
Have the WorkerGlobalScope API return more references instead of
pointers.
- workers/WorkerGlobalScope.cpp:
(WebCore::WorkerGlobalScope::location):
(WebCore::WorkerGlobalScope::navigator):
- workers/WorkerGlobalScope.h:
(WebCore::WorkerGlobalScope::self):
- 7:28 AM Changeset in webkit [200856] by
-
- 3 edits1 add in trunk/Source/JavaScriptCore
Assertion failure for direct eval in non-class method
https://bugs.webkit.org/show_bug.cgi?id=157138
Reviewed by Saam Barati.
This assertion was incorrect. In method definitions in object literals,
it can be sloppy mode, but its DerivedContextType may not be DerivedContextType::None.
- bytecode/EvalCodeCache.h:
(JSC::EvalCodeCache::CacheKey::CacheKey):
(JSC::EvalCodeCache::CacheKey::operator==):
(JSC::EvalCodeCache::CacheKey::Hash::equal):
(JSC::EvalCodeCache::tryGet):
(JSC::EvalCodeCache::getSlow):
- interpreter/Interpreter.cpp:
(JSC::eval):
- tests/stress/direct-eval-in-object-literal-methods.js: Added.
(shouldBe):
(throw.new.Error):
(shouldBe.Parent.prototype.l):
(shouldBe.Parent):
(shouldBe.Derived.prototype.m):
(shouldBe.Derived):
- 6:41 AM WebKitGTK/2.12.x edited by
- (diff)
- 6:41 AM Changeset in webkit [200855] by
-
- 5 edits in releases/WebKitGTK/webkit-2.12
Merge r200542 - REGRESSION(r196222): [AX][GTK] accessibility/gtk/caret-offsets.html failing
https://bugs.webkit.org/show_bug.cgi?id=153956
Reviewed by Chris Fleizach.
Source/WebCore:
The reason the test began failing is that it was checking the new caret offset
synchronously. For most of the test cases, this was not a problem. But when the
caret was moved out of a focused link, the focus change (and associated repainting)
delayed the caret-moved event long enough to cause the associated test case to fail.
The test now uses shouldBecomeEqualToString() instead of shouldBeEqualToString().
The test also had a supposedly-correct expectation which was wrong: When moving the
caret to a valid accessible offset, the caret-moved event should be for that offset.
This was not the case for the list item test case because emitTextSelectionChange()
was not adjusting the offset for the RenderListMarker, the text of which is exposed
as part of the ATK_ROLE_LIST_ITEM object. This bug was also fixed and the test case
updated accordingly.
No new tests are needed. The previously-failing test is now passing.
- editing/atk/FrameSelectionAtk.cpp:
(WebCore::emitTextSelectionChange):
LayoutTests:
Change the test to run asynchronously and update the expectations.
- accessibility/gtk/caret-offsets-expected.txt: Updated.
- accessibility/gtk/caret-offsets.html: Updated.
- platform/gtk/TestExpectations: Unskipped the previously-failing test.
- 6:35 AM Changeset in webkit [200854] by
-
- 6 edits2 adds in releases/WebKitGTK/webkit-2.12
Merge r200486 - Do not attempt to compute min/max width.
https://bugs.webkit.org/show_bug.cgi?id=157320
Reviewed by David Hyatt.
Replaced elements with no intrinsic size (only with ratio) should not call the containing
block to compute the min/max width when the containing block's min/max width
depends on the children's intrinsic size. It could lead to infinite recursion.
Source/WebCore:
Test: fast/replaced/before-content-intrinsic-crash.html
- rendering/RenderBox.cpp:
(WebCore::RenderBox::computeReplacedLogicalWidthRespectingMinMaxWidth): Unrelated code change.
- rendering/RenderImage.cpp: Unrelated code change.
(WebCore::RenderImage::RenderImage): Deleted.
- rendering/RenderImage.h:
- rendering/RenderReplaced.cpp:
(WebCore::RenderReplaced::computeReplacedLogicalWidth):
LayoutTests:
- fast/replaced/before-content-intrinsic-crash-expected.txt: Added.
- fast/replaced/before-content-intrinsic-crash.html: Added.
- 6:31 AM Changeset in webkit [200853] by
-
- 4 edits in releases/WebKitGTK/webkit-2.12/Source/WebCore
Merge r200455 - [GStreamer] Adaptive streaming issues
https://bugs.webkit.org/show_bug.cgi?id=144040
Reviewed by Philippe Normand.
In the case of adaptive streaming, the GST URI downloader object is creating the source object, in our case
WebKitWebSrc, without taking its ownership. This is breaking the lifetime of the WebKitWebSrc element. We are
using GRefPtr in WebKitWebSrc to ref/unref the object when sending notifications to the main thread, ensuring
that the object is not destroyed before the main thread dispatches the message. But our smart pointers are so
smart that in case of receiving a floating reference, it's converted to a full reference, so that the first time
we try to take a ref of a WebKitWebSrc having a floating reference we are actually taking the ownership
instead. When we try to release the reference, we are actuallty destroying the object, something that the actual
owner is not expecting and causing runtime critical warnings and very often web process crashes.
(WebKitWebProcess:6863): GStreamer-CRITICAL :
Trying to dispose element appsrc1, but it is in READY instead of the NULL state.
You need to explicitly set elements to the NULL state before
dropping the final reference, to allow them to clean up.
This problem may also be caused by a refcounting bug in the
application or some element.
(WebKitWebProcess:6863): GStreamer-CRITICAL : gst_uri_handler_get_uri: assertion 'GST_IS_URI_HANDLER(handler)' failed
(WebKitWebProcess:6863): GStreamer-CRITICAL : gst_uri_get_protocol: assertion 'uri != NULL' failed
This should be fixed in GST, but we can workaround it in WebKit while it's fixed in GST or to prevent this from
happening if other users make the same mistake. The idea is to add a ensureGRef() only available for GRefPtr
when using WebKitWebSrc objects that consumes the floating reference if needed before taking the actual reference.
- platform/graphics/gstreamer/GRefPtrGStreamer.cpp:
(WTF::ensureGRef): Consume the floating ref if needed.
- platform/graphics/gstreamer/GRefPtrGStreamer.h:
- platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
(webKitWebSrcChangeState): Use ensureGRef().
- 6:29 AM Changeset in webkit [200852] by
-
- 4 edits in releases/WebKitGTK/webkit-2.12
Merge r200445 - CSP: Perform case sensitive match against path portion of source expression URL that ends in '/'
https://bugs.webkit.org/show_bug.cgi?id=157275
Reviewed by Darin Adler.
Source/WebCore:
Merged from Blink:
<https://chromium.googlesource.com/chromium/src/+/7bd0a75e3f71a10e71ded31ea5905d5ee3d992eb>
Perform a case-sensitive prefix match of the path portion a source expression that ends in '/'
against the path portion of a request URL as per step 8.5.4 of section Does url match expression
in origin with redirect count of the Content Security Policy Level 3 spec., <https://w3c.github.io/webappsec-csp>
(Editor's Draft, 27 April 2016).
- page/csp/ContentSecurityPolicySource.cpp:
(WebCore::ContentSecurityPolicySource::pathMatches):
LayoutTests:
Add test to ensure that the path portion of a request URL is case-sensitively
matched against the path portion of a source expression that ends in '/'.
- http/tests/security/contentSecurityPolicy/source-list-parsing-paths-01-expected.txt:
- http/tests/security/contentSecurityPolicy/source-list-parsing-paths-01.html:
- 6:26 AM Changeset in webkit [200851] by
-
- 6 edits2 adds in releases/WebKitGTK/webkit-2.12
Merge r200414 - Clicks inside button elements are sometimes discarded when the mouse moves
https://bugs.webkit.org/show_bug.cgi?id=39620
Reviewed by Darin Adler.
Source/WebCore:
Test: fast/events/click-over-descendant-elements.html
- dom/Node.cpp:
(WebCore::ancestor):
(WebCore::commonAncestor): Method inspired from
http://src.chromium.org/viewvc/blink?view=revision&revision=162081.
(WebCore::commonAncestorCrossingShadowBoundary): Helper routine
that handles the case of nodes into a shadow node.
- dom/Node.h:
- page/EventHandler.cpp:
(WebCore::EventHandler::handleMouseReleaseEvent): Selecting click event
target node according commonAncestorOverShadowBoundary method.
(WebCore::EventHandler::targetNodeForClickEvent): Deleted.
LayoutTests:
Test coming from http://src.chromium.org/viewvc/blink?view=revision&revision=162081.
Modified to ensure click events do not end up being considered as double click events.
- fast/events/click-over-descendant-elements-expected.txt: Added.
- fast/events/click-over-descendant-elements.html: Added.
- platform/ios-simulator/TestExpectations: Marked new test as failing.
- 6:07 AM Changeset in webkit [200850] by
-
- 2 edits in releases/WebKitGTK/webkit-2.12/Source/WebCore
Merge r200410 - CrashTracer: [USER] com.apple.WebKit.WebContent at …ple.WebCore: WebCore::EditCommandComposition::unapply + 105
https://bugs.webkit.org/show_bug.cgi?id=157282
<rdar://problem/25391441>
Reviewed by Darin Adler.
A frame could be destroyed in the middle of executing undo/redo command.
Therefore, add an early return.
- editing/CompositeEditCommand.cpp:
(WebCore::EditCommandComposition::unapply):
(WebCore::EditCommandComposition::reapply):
- 5:59 AM Changeset in webkit [200849] by
-
- 4 edits2 adds in releases/WebKitGTK/webkit-2.12
Merge r200326 - Do not reuse cache entries with conditional headers
https://bugs.webkit.org/show_bug.cgi?id=157205
rdar://problem/25856933
Reviewed by Chris Dumez.
Source/WebCore:
Test: http/tests/xmlhttprequest/if-modified-since-0.html
- loader/cache/CachedRawResource.cpp:
(WebCore::CachedRawResource::canReuse):
CachedResourceLoader::determineRevalidationPolicy asserts that the request is not conditional,
which means that it does not have any headers like If-Modified-Since. They are usually different,
because we put the timestamp in the If-Modified-Since header, so it fails the canReuse test because
time has passed since the last If-Modified-Since header was sent. When a user sets the If-Modified-Since
manually to something that is constant, we reuse cache entries when we should not.
- platform/network/mac/WebCoreResourceHandleAsDelegate.mm:
(-[WebCoreResourceHandleAsDelegate connection:didReceiveResponse:]):
Set the source so we can use it in Internals.
LayoutTests:
- http/tests/xmlhttprequest/if-modified-since-0-expected.txt: Added.
- http/tests/xmlhttprequest/if-modified-since-0.html: Added.
- 5:33 AM Changeset in webkit [200848] by
-
- 4 edits2 adds in releases/WebKitGTK/webkit-2.12
Merge r200301 - Some content causes deep recursion.
https://bugs.webkit.org/show_bug.cgi?id=157230
<rdar://problem/7694756>
Reviewed by Antti Koivisto.
This patch sets a limit(512) on content nesting for the render tree. Elements injected over the limit
are still accessible through DOM APIs but
- we stop generating renderers for them -they behave like display: none.
- their layout related computed style values are set to default (e.g. window.computedStyle(document.elementById("over512").width -> auto)
Source/WebCore:
Test: fast/block/nested-renderers.html
- page/Settings.h:
- style/StyleTreeResolver.cpp: Skip renderer constructing and continue with the sibling node.
(WebCore::Style::TreeResolver::resolveComposedTree):
LayoutTests:
- fast/block/nested-renderers-expected.html: Added.
- fast/block/nested-renderers.html: Added.
- 5:26 AM Changeset in webkit [200847] by
-
- 3 edits2 adds in releases/WebKitGTK/webkit-2.12
Merge r200282 - REGRESSION(194502): overflow: scroll; direction: rtl; divs jump horizontally when scrolled vertically
https://bugs.webkit.org/show_bug.cgi?id=157201
Reviewed by Simon Fraser.
Source/WebCore:
ScrollableArea::scrollToOffsetWithoutAnimation() was mistakenly conflating scroll offsets with
scroll positions.
Test: fast/scrolling/rtl-drag-vertical-scroller.html
- platform/ScrollableArea.cpp:
(WebCore::ScrollableArea::scrollToOffsetWithoutAnimation):
LayoutTests:
- fast/scrolling/rtl-drag-vertical-scroller-expected.txt: Added.
- fast/scrolling/rtl-drag-vertical-scroller.html: Added.
- 5:18 AM Changeset in webkit [200846] by
-
- 3 edits2 adds in releases/WebKitGTK/webkit-2.12
Merge r200247 - Wheel Event Not Fired For
body,html { height:100% }
https://bugs.webkit.org/show_bug.cgi?id=148450
Reviewed by Brent Fulgham.
Source/WebCore:
EventHandler::handleWheelEvent() didn't pass the Active flag in the HitTestRequest,
which causes code in RenderLayer::hitTest() to fail to fall back to returning the
root layer if no other element is hit. "Active" is in the default flags,
so just create the HitTestRequest with the default flags.
Test: fast/events/wheel-event-outside-body.html
- page/EventHandler.cpp:
(WebCore::EventHandler::handleWheelEvent):
LayoutTests:
Testcase, skipped on iOS which doesn't support wheel events.
- fast/events/wheel-event-outside-body-expected.txt: Added.
- fast/events/wheel-event-outside-body.html: Added.
- platform/ios-simulator/TestExpectations:
- 5:14 AM Changeset in webkit [200845] by
-
- 7 edits2 adds in releases/WebKitGTK/webkit-2.12
Merge r200220 - Content disappears on mouse over.
https://bugs.webkit.org/show_bug.cgi?id=157073
<rdar://problem/24389168>
Reviewed by Simon Fraser.
When a redundant inlinebox is found after constructing the line, we remove it from the tree.
The remove operation marks the ancestor tree dirty (and this newly constructed line is supposed to be clean).
This patch resets this dirty flag on the boxes all the way up to the rootlinebox.
Previously we only cleared the rootinlinebox and we ended up with dirty inlineflowboxes.
Source/WebCore:
Test: fast/text/text-node-remains-dirty-after-calling-surroundContents.html
- rendering/BidiRun.h:
(WebCore::BidiRun::setBox):
- rendering/RenderBlockFlow.h:
- rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlockFlow::constructLine):
(WebCore::RenderBlockFlow::removeLineBoxIfNeeded):
(WebCore::RenderBlockFlow::computeBlockDirectionPositionsForLine):
- rendering/RenderBox.cpp:
(WebCore::RenderBox::positionLineBox): Deleted.
- rendering/RenderText.cpp:
(WebCore::RenderText::setText):
(WebCore::RenderText::positionLineBox): Deleted.
LayoutTests:
- fast/text/text-node-remains-dirty-after-calling-surroundContents-expected.html: Added.
- fast/text/text-node-remains-dirty-after-calling-surroundContents.html: Added.
- 4:52 AM WebKitGTK/2.12.x edited by
- (diff)
- 4:51 AM Changeset in webkit [200844] by
-
- 8 edits4 adds in releases/WebKitGTK/webkit-2.12
Merge r200188 - AX: [ATK] We need to be smarter about flattening and the accessible text implementation
https://bugs.webkit.org/show_bug.cgi?id=144639
Reviewed by Chris Fleizach.
Source/WebCore:
Defer to WebCore Accessibility more regarding when to include anonymous blocks in the
accessibility tree. Explicitly flatten menu items, headings, list items, and paragraphs
in order to preserve the expected platform behavior for backwards compatibility. Also
map anonymous table parts to DivRole rather than GroupRole for GTK and EFL because ATK
has separate roles for generic text block elements and other generic containers.
Tests: accessibility/gtk/nested-block-element-children.html
accessibility/gtk/spans-paragraphs-and-divs-tree.html
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::determineAccessibilityRole):
- accessibility/atk/AccessibilityObjectAtk.cpp:
(WebCore::AccessibilityObject::accessibilityPlatformIncludesObject):
LayoutTests:
Added two new tests and updated three existing tests to reflect the new behavior
regarding inclusion of elements in the accessibility tree and the text value of
included elements.
- accessibility/gtk/nested-block-element-children-expected.txt: Added.
- accessibility/gtk/nested-block-element-children.html: Added.
- accessibility/gtk/spans-paragraphs-and-divs-expected.txt: Updated for new behavior.
- accessibility/gtk/spans-paragraphs-and-divs-tree-expected.txt: Added.
- accessibility/gtk/spans-paragraphs-and-divs-tree.html: Added.
- accessibility/gtk/spans-paragraphs-and-divs.html: Updated for new behavior.
- platform/gtk/accessibility/generated-content-with-display-table-crash-expected.txt: Updated for new behavior.
- platform/gtk/accessibility/gtk/replaced-objects-in-anonymous-blocks-expected.txt: Updated for new behavior.
- 4:49 AM Changeset in webkit [200843] by
-
- 2 edits in releases/WebKitGTK/webkit-2.12/Source/WebCore
Merge r200184 - REGRESSION(r199659): Web Process crash when RenderTheme::adjustMenuListStyle is called with a null element
https://bugs.webkit.org/show_bug.cgi?id=157127
Reviewed by Sergio Villar Senin.
This happens for example with tests fast/css/appearance-with-pseudo-elements-in-quirks-mode.html and
fast/css/appearance-with-pseudo-elements.html.
- rendering/RenderThemeGtk.cpp:
(WebCore::RenderThemeGtk::adjustMenuListStyle): Do not change the style color if the given element is nullptr.
- 4:45 AM Changeset in webkit [200842] by
-
- 2 edits in releases/WebKitGTK/webkit-2.12/Source/WebKit2
Merge r200152 - Remove download message receiver when NetworkProcess crashes
https://bugs.webkit.org/show_bug.cgi?id=157102
<rdar://problem/25550106>
Reviewed by Anders Carlsson.
- UIProcess/Downloads/DownloadProxyMap.cpp:
(WebKit::DownloadProxyMap::processDidClose):
When the NetworkProcess crashes during a download, we want to remove the message receiver from the map
so we don't get an assertion in ~MessageReceiver in the UIProcess so we do not have a freed
message receiver in the map.
- 4:43 AM Changeset in webkit [200841] by
-
- 4 edits in releases/WebKitGTK/webkit-2.12
Merge r200126 - [EFL][GTK] Volume slider only changes volume when thumb is released, not while dragging
https://bugs.webkit.org/show_bug.cgi?id=156970
Reviewed by Xabier Rodriguez-Calvar.
Source/WebCore:
Volume slider have to change the volume while dragging the thumb.
Test: media/video-volume-slider-drag.html
- Modules/mediacontrols/mediaControlsBase.js:
(Controller.prototype.createControls): Use the 'input' event instead of the 'change' to
check the changed value correctly.
(Controller.prototype.handleMaxButtonClicked):
(Controller.prototype.handleVolumeSliderInput): Renamed from handleVolumeSliderChange.
(Controller.prototype.handleVolumeSliderChange): Deleted.
LayoutTests:
Removed the passed test.
- platform/efl/TestExpectations:
- platform/gtk/TestExpectations:
- 4:38 AM Changeset in webkit [200840] by
-
- 2 edits in releases/WebKitGTK/webkit-2.12/Source/WebCore
Merge r200091 - GuardMalloc crash in WebCore::HTMLFrameElementBase::marginHeight()
https://bugs.webkit.org/show_bug.cgi?id=157020
<rdar://problem/25148315>
Reviewed by Darin Adler.
Calls to setIntegralAttribute triggers event handling code, which can cause
the underlying m_frameOwnerElement member to be deleted. We could clone this
object, but since we only want the width and height we should just read them
while we know the object is in a good state, then execute the potentially
mutating methods.
Tested by imported/blink/fast/dom/HTMLBodyElement/body-inserting-iframe-crash.html.
- html/HTMLBodyElement.cpp:
(WebCore::HTMLBodyElement::insertedInto): Read margin width and height before
calling setIntegralAttribute.
- 4:36 AM Changeset in webkit [200839] by
-
- 4 edits in releases/WebKitGTK/webkit-2.12/Source
Merge r200068 - Heap corruption is detected when destructing JSGlobalObject
https://bugs.webkit.org/show_bug.cgi?id=156831
Patch by Fujii Hironori <Fujii Hironori> on 2016-04-25
Reviewed by Mark Lam.
WebKit uses CRT static library on Windows. Each copy of the CRT
library has its own heap manager, allocating memory in one CRT
library and passing the pointer across a DLL boundary to be freed
by a different copy of the CRT library is a potential cause for
heap corruption.
Potential Errors Passing CRT Objects Across DLL Boundaries
<https://msdn.microsoft.com/en-us/library/ms235460(v=vs.140).aspx>
JSGlobalObject::createRareDataIfNeeded is inlined but
JSGlobalObject::~JSGlobalObject is not. Then, the heap of
allocating JSGlobalObjectRareData is WebKit.dll, but deallocating
JavaScriptCore.dll. Adding WTF_MAKE_FAST_ALLOCATED to
JSGlobalObjectRareData ensures heap consistency of it. WTF::Lock
also needs WTF_MAKE_FAST_ALLOCATED because it is allocated from
the inlined constructor of JSGlobalObjectRareData.
Source/JavaScriptCore:
Test: fast/dom/insertedIntoDocument-iframe.html
- runtime/JSGlobalObject.h:
Add WTF_MAKE_FAST_ALLOCATED to JSGlobalObjectRareData.
Source/WTF:
- wtf/Lock.h: Add WTF_MAKE_FAST_ALLOCATED.
- 4:03 AM Changeset in webkit [200838] by
-
- 6 edits in releases/WebKitGTK/webkit-2.12
Merge r200056 - Add port 4190 (managesieve) to port blacklist
https://bugs.webkit.org/show_bug.cgi?id=156986
<rdar://problem/9119470>
Reviewed by Daniel Bates.
Source/WebCore:
Tested by security/block-test.html.
- platform/URL.cpp:
(WebCore::portAllowed): Add 4190 to the port blacklist.
LayoutTests:
- platform/mac/security/block-test-expected.txt
- security/block-test-expected.txt:
- security/block-test.html:
- 4:03 AM Changeset in webkit [200837] by
-
- 22 edits in trunk/Source
DOMPromise should only restrict the resolution type
https://bugs.webkit.org/show_bug.cgi?id=157307
Reviewed by Darin Adler.
Source/WebCore:
Removing from DOMPromise the rejection template parameter.
Supported rejection types are integers (Exception codes) and DOM objects (DOMError typically).
Updated toJS and DeferredWrapper to accept Ref<>&& and RefPtr<>&&.
Previously Ref<>&& were not accepted and only "const RefPtr<>&" was accepted.
This in turn created an unecessary churn count when calling toJS.
Changes also allow in most cases to remove the need for explictly declaring the
rejection/resolution type.
Minor refactoring of FontFaceSet promise handling to use DOMPromise in lieu of DeferredWrapper.
Covered by existing tests.
Changes should not be visible from user scripts.
- Modules/fetch/FetchBody.cpp:
(WebCore::FetchBody::consume):
(WebCore::FetchBody::consumeText):
(WebCore::blobFromArrayBuffer):
(WebCore::FetchBody::loadingFailed):
- Modules/fetch/FetchBody.h:
(WebCore::FetchBody::formData):
- Modules/fetch/FetchBodyOwner.cpp:
(WebCore::FetchBodyOwner::arrayBuffer):
(WebCore::FetchBodyOwner::blob):
(WebCore::FetchBodyOwner::formData):
(WebCore::FetchBodyOwner::json):
(WebCore::FetchBodyOwner::text):
- Modules/fetch/FetchResponse.cpp:
(WebCore::FetchResponse::BodyLoader::didReceiveResponse):
- Modules/fetch/FetchResponse.h:
- Modules/mediastream/MediaDevices.h:
- Modules/mediastream/PeerConnectionBackend.h:
- Modules/mediastream/UserMediaRequest.cpp:
(WebCore::UserMediaRequest::didCreateStream):
- Modules/streams/ReadableStreamSource.h:
- Modules/webaudio/AudioContext.h:
- bindings/js/JSDOMBinding.h:
(WebCore::toJS):
(WebCore::jsPair):
- bindings/js/JSDOMPromise.cpp:
(WebCore::fulfillPromiseWithJSON):
- bindings/js/JSDOMPromise.h:
(WebCore::TypeInspector::decltype):
(WebCore::TypeInspector::testIsVector):
(WebCore::TypeInspector::testIsRefOrRefPtr):
(WebCore::DeferredWrapper::resolve):
(WebCore::DeferredWrapper::reject):
(WebCore::DOMPromise::resolve):
(WebCore::DOMPromise::reject):
(WebCore::DeferredWrapper::resolveWithValue):
(WebCore::DeferredWrapper::rejectWithValue):
(WebCore::callPromiseFunction):
- bindings/js/JSSubtleCryptoCustom.cpp:
(WebCore::JSSubtleCrypto::importKey):
(WebCore::JSSubtleCrypto::unwrapKey):
- css/FontFace.h:
- css/FontFaceSet.cpp:
(WebCore::FontFaceSet::PendingPromise::PendingPromise):
(WebCore::FontFaceSet::load):
(WebCore::FontFaceSet::registerReady):
- css/FontFaceSet.h:
- html/HTMLMediaElement.h:
Source/WTF:
- wtf/Ref.h: Adding static constexpr to ease detection of Ref for templates.
- wtf/RefPtr.h: Ditto.
- 4:02 AM Changeset in webkit [200836] by
-
- 9 edits4 adds in releases/WebKitGTK/webkit-2.12
Merge r200047 - Toggling animation-play-state can re-start a finished animation
https://bugs.webkit.org/show_bug.cgi?id=156731
Reviewed by Dean Jackson.
Source/WebCore:
After an animation completed, CompositeAnimation::updateKeyframeAnimations() cleared
all state that the animation had run on the element, so changing the value of some
animation property triggered the animation to run again. This is wrong, since animation-name
still applied to the element.
Fix by keeping state for keyframe animations in the Done state in the m_keyframeAnimations
map. This allows for the removal of the index property on KeyframeAnimation.
Tests: animations/change-completed-animation-transform.html
animations/change-completed-animation.html
- page/animation/AnimationBase.cpp:
(WebCore::AnimationBase::timeToNextService):
- page/animation/AnimationBase.h:
(WebCore::AnimationBase::isAnimatingProperty):
- page/animation/CompositeAnimation.cpp: Add animations that should stick around to AnimationNameMap,
and swap with m_keyframeAnimations at the end.
(WebCore::CompositeAnimation::updateKeyframeAnimations):
- page/animation/KeyframeAnimation.cpp:
(WebCore::KeyframeAnimation::KeyframeAnimation):
(WebCore::KeyframeAnimation::getAnimatedStyle):
- page/animation/KeyframeAnimation.h:
LayoutTests:
- animations/animation-direction-reverse-expected.txt:
- animations/animation-direction-reverse.html: This is a progression. The test was detecting a
restarted animation.
- animations/change-completed-animation-expected.txt: Added.
- animations/change-completed-animation-transform-expected.html: Added.
- animations/change-completed-animation-transform.html: Added. Ref test that ensures that the final
state for normal and accelerated animations is correct.
- animations/change-completed-animation.html: Added. Tests that changing a property doesn't trigger
another animation, by detecting a second animationstart event.
- 4:01 AM Changeset in webkit [200835] by
-
- 8 edits2 adds in releases/WebKitGTK/webkit-2.12
Merge r200043 - play-state not parsed as part of animation shorthand
https://bugs.webkit.org/show_bug.cgi?id=156959
Reviewed by Darin Adler.
Source/WebCore:
We failed to parse animation-play-state as part of the animation shorthand, contrary
to the spec and other browsers.
Fix for both the prefixed and unprefixed properties. There is some compat risk here,
but only changing unprefixed behavior will probably lead to more author confusion.
Test: animations/play-state-in-shorthand.html
- css/CSSParser.cpp:
(WebCore::CSSParser::parseAnimationShorthand):
- css/CSSPropertyNames.in:
- css/StylePropertyShorthand.cpp:
(WebCore::animationShorthandForParsing): Remove the long comment which is no longer relevant
now that the behavior has been written into the spec.
LayoutTests:
- animations/animation-shorthand-expected.txt:
- animations/animation-shorthand.html:
- animations/play-state-in-shorthand-expected.txt: Added.
- animations/play-state-in-shorthand.html: Added.
- animations/resources/animation-test-helpers.js:
(getPropertyValue):
(comparePropertyValue):
- 3:41 AM Changeset in webkit [200834] by
-
- 4 edits2 adds in releases/WebKitGTK/webkit-2.12
Merge r200042 - Negative animation-delay is treated as 0s
https://bugs.webkit.org/show_bug.cgi?id=141008
Reviewed by Daniel Bates.
Source/WebCore:
Fix keyframe animations which start in the paused state.
Explicitly move such animations from the new to the paused state, and
set m_pauseTime to 0, rather than leaving it at -1. Fix getElapsedTime()
to compute a correct time elapsed time for such animations, which takes
negative delay into account correctly.
Fix assertions which need to account for the new transition of New -> PlayStatePaused.
Test: animations/play-state-start-paused.html
- page/animation/AnimationBase.cpp:
(WebCore::AnimationBase::updateStateMachine):
(WebCore::AnimationBase::getElapsedTime):
- page/animation/KeyframeAnimation.cpp:
(WebCore::KeyframeAnimation::animate):
LayoutTests:
Ref test that has an initially-paused animation on 'left' and with a
3d transform.
- animations/play-state-start-paused-expected.html: Added.
- animations/play-state-start-paused.html: Added.
- 3:39 AM Changeset in webkit [200833] by
-
- 2 edits in releases/WebKitGTK/webkit-2.12/Source/WebCore
Merge r200039 - Stop listening for "media can start" notifications when media player is cleared
https://bugs.webkit.org/show_bug.cgi?id=156985
<rdar://problem/23158505>
Reviewed by Jer Noble.
No new tests, I have not been able to create a test that reliably reproduces this.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::loadInternal): Add logging.
(WebCore::HTMLMediaElement::selectMediaResource): Assert and return early if there is
no media player.
(WebCore::HTMLMediaElement::clearMediaPlayer): Stop listening for can start notifications.
(WebCore::HTMLMediaElement::visibilityStateChanged): Add logging.
(WebCore::HTMLMediaElement::mediaCanStart): Ditto.
- 3:37 AM Changeset in webkit [200832] by
-
- 4 edits4 adds in releases/WebKitGTK/webkit-2.12
Merge r200030 - REGRESSION (r196012): Subresource may be blocked by Content Security Policy if it only matches 'self'
https://bugs.webkit.org/show_bug.cgi?id=156935
<rdar://problem/25351286>
Reviewed by Darin Adler.
Source/WebCore:
Fixes an issue where subresource load may be blocked by the Content Security Policy (CSP) if its URL only
matched 'self'. In particular, the load would be blocked if initiated from a document that inherited the
origin of its owner document (e.g. the document contained in <iframe src="about:blank"></iframe>).
Following r196012 we compute and cache 'self' and its protocol on instantiation of a ContentSecurityPolicy
object for use when matching a URL against it. These cached values become out-of-date if the document
subsequently inherits the origin of its owner document. Therefore matches against 'self' will fail and
CSP will block a load if its not otherwise allowed by the policy. Previously we would compute 'self' when
parsing the definition of a source list and compute the protocol for 'self' each time we tried to match a
URL against 'self'. So, 'self' would always be up-to-date with respect to the origin of the document.
Tests: http/tests/security/contentSecurityPolicy/iframe-blank-url-programmatically-add-external-script.html
http/tests/security/contentSecurityPolicy/iframe-srcdoc-external-script.html
- page/csp/ContentSecurityPolicy.cpp:
(WebCore::ContentSecurityPolicy::ContentSecurityPolicy): Extract out logic for computing and caching
'self' and its protocol into ContentSecurityPolicy::updateSourceSelf() and make use of this function.
(WebCore::ContentSecurityPolicy::updateSourceSelf): Computes and caches 'self' and its protocol with
respect to the specified SecurityOrigin.
(WebCore::ContentSecurityPolicy::applyPolicyToScriptExecutionContext): Call ContentSecurityPolicy::updateSourceSelf()
to ensure that we have an up-to-date representation for 'self' and the protocol of 'self' which can
become out-of-date if the document inherited the origin of its owner document.
- page/csp/ContentSecurityPolicy.h:
LayoutTests:
Add tests to ensure that we match 'self' correctly in an iframe with an about:blank document.
- http/tests/security/contentSecurityPolicy/iframe-blank-url-programmatically-add-external-script-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/iframe-blank-url-programmatically-add-external-script.html: Added.
- http/tests/security/contentSecurityPolicy/iframe-srcdoc-external-script-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/iframe-srcdoc-external-script.html: Added.
- 3:32 AM Changeset in webkit [200831] by
-
- 2 edits in releases/WebKitGTK/webkit-2.12/Source/WebCore/platform/gtk/po
Merge r199948 - Updated Hungarian translation
https://bugs.webkit.org/show_bug.cgi?id=156952
Patch by Gabor Kelemen <kelemeng@ubuntu.com> on 2016-04-23
Rubber-stamped by Michael Catanzaro.
- hu.po:
- 3:25 AM Changeset in webkit [200830] by
-
- 3 edits2 adds in releases/WebKitGTK/webkit-2.12
Merge r199895 - REGRESSION (r189567): The top of Facebook's messenger.com looks visually broken
https://bugs.webkit.org/show_bug.cgi?id=156869
<rdar://problem/23204668>
Reviewed by Zalan Bujtas.
Source/WebCore:
Added fast/block/min-content-with-box-sizing.html
- rendering/RenderBox.cpp:
(WebCore::RenderBox::computeIntrinsicLogicalContentHeightUsing):
LayoutTests:
- fast/block/min-content-box-sizing-expected.html: Added.
- fast/block/min-content-box-sizing.html: Added.
- 3:22 AM Changeset in webkit [200829] by
-
- 10 edits3 adds in releases/WebKitGTK/webkit-2.12
Merge r199881 - REGRESSION (r194898): Multi download of external SVG defs file by <use> xlinks:href (caching)
https://bugs.webkit.org/show_bug.cgi?id=156368
<rdar://problem/25611746>
Reviewed by Simon Fraser.
Source/WebCore:
We would load svg resources with fragment identifier again because the encoding never matched.
Test: http/tests/svg/svg-use-external.html
- loader/TextResourceDecoder.cpp:
(WebCore::TextResourceDecoder::setEncoding):
(WebCore::TextResourceDecoder::hasEqualEncodingForCharset):
Encoding can depend on mime type. Add a comparison function that takes this into account.
(WebCore::findXMLEncoding):
- loader/TextResourceDecoder.h:
(WebCore::TextResourceDecoder::encoding):
- loader/cache/CachedCSSStyleSheet.h:
- loader/cache/CachedResource.h:
(WebCore::CachedResource::textResourceDecoder):
Add a way to get the TextResourceDecoder from a cached resource.
- loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::determineRevalidationPolicy):
Use the new comparison function.
- loader/cache/CachedSVGDocument.h:
- loader/cache/CachedScript.h:
- loader/cache/CachedXSLStyleSheet.h:
LayoutTests:
- http/tests/svg/resources/symbol-defs.svg: Added.
- http/tests/svg/svg-use-external-expected.txt: Added.
- http/tests/svg/svg-use-external.html: Added.
- 3:02 AM Changeset in webkit [200828] by
-
- 2 edits in releases/WebKitGTK/webkit-2.12/Source/WebKit2
Merge r199875 - NetworkCacheIOChannelSoup: detach the newly-created IOChannel::readSync thread
https://bugs.webkit.org/show_bug.cgi?id=156907
Reviewed by Carlos Garcia Campos.
- NetworkProcess/cache/NetworkCacheIOChannelSoup.cpp:
(WebKit::NetworkCache::IOChannel::readSyncInThread): Detach the new thread,
ensuring the resources are released after the thread exits. Next step is
to set up a thread pool and use that, avoiding thread re-creation.
- 3:01 AM Changeset in webkit [200827] by
-
- 3 edits in releases/WebKitGTK/webkit-2.12/Source/WebCore
Merge r199856 - RenderVideo should always update the intrinsic size before layout.
https://bugs.webkit.org/show_bug.cgi?id=156878
Reviewed by Simon Fraser.
In order to layout video element properly we need to know the correct intrinsic size.
This patch also asserts if we end up updating the intrinsic size right after finishing video renderer layout.
This issues was discovered as part of webkit.org/b/156245. (hence covered by existing tests)
- rendering/RenderVideo.cpp:
(WebCore::RenderVideo::updateIntrinsicSize):
(WebCore::RenderVideo::layout):
(WebCore::RenderVideo::updatePlayer):
- rendering/RenderVideo.h:
- 2:57 AM Changeset in webkit [200826] by
-
- 2 edits in releases/WebKitGTK/webkit-2.12/Source/WebCore
Merge r199851 - Fix crashes when loading SVG images.
- loader/EmptyClients.cpp:
(WebCore::fillWithEmptyClients):
Give the SVG page its own application cache storage.
- 2:54 AM Changeset in webkit [200825] by
-
- 8 edits3 deletes in releases/WebKitGTK/webkit-2.12
Revert "Merge r197520 - DFG should be able to compile StringReplace"
This reverts commit 0c91f9b2c73ecc89dac9ece8b7fa6fd06330e451.
- 1:22 AM Changeset in webkit [200824] by
-
- 12 edits in trunk
Assertion failure for super() call in arrow function default parameters
https://bugs.webkit.org/show_bug.cgi?id=157079
Reviewed by Saam Barati.
Source/JavaScriptCore:
Root of the issue that in arrow function we load bounded variables this/super/new.target just after
input parameters were initialized, and did not covered case of default values for function parameters.
Current patch tried to fix issue and allow to load bounded variables earlier, before the input
parameters are assigned by default values.
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::BytecodeGenerator):
- tests/stress/arrowfunction-lexical-bind-this-2.js:
LayoutTests:
- js/arrowfunction-lexical-bind-arguments-non-strict-expected.txt:
- js/arrowfunction-lexical-bind-this-expected.txt:
- js/arrowfunction-supercall-expected.txt:
- js/arrowfunction-superproperty-expected.txt:
- js/script-tests/arrowfunction-lexical-bind-arguments-non-strict.js:
- js/script-tests/arrowfunction-lexical-bind-this.js:
- js/script-tests/arrowfunction-supercall.js:
- js/script-tests/arrowfunction-superproperty.js:
- 1:11 AM Changeset in webkit [200823] by
-
- 5 edits in tags/Safari-602.1.32.1.1/Source
Versioning.
- 12:50 AM Changeset in webkit [200822] by
-
- 1 copy in tags/Safari-602.1.32.1.1
New tag.
- 12:41 AM Changeset in webkit [200821] by
-
- 4 edits in trunk
[css-grid] Show auto-repeat line names in ComputedStyle
https://bugs.webkit.org/show_bug.cgi?id=157622
Reviewed by Darin Adler.
Source/WebCore:
Add the necessary machinery to show the named lines from auto-repeat tracks in
getComputedStyle(). A new class OrderedNamedLinesCollector was added to abstract the
retrieval of line names no matter where they come from (explicit or auto-repeat tracks).
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::OrderedNamedLinesCollector::OrderedNamedLinesCollector):
(WebCore::OrderedNamedLinesCollector::isEmpty): TRUE if we don't have named lines neither on
explicit nor auto-repeat tracks.
(WebCore::OrderedNamedLinesCollector::appendLines): Add the named lines found for a given
index to the CSSGridLineNamesValue.
(WebCore::OrderedNamedLinesCollector::collectLineNamesForIndex): Collects named lines found
for a given index.
(WebCore::addValuesForNamedGridLinesAtIndex): Use the collector to gather named lines.
(WebCore::valueForGridTrackList): Ditto.
LayoutTests:
- fast/css-grid-layout/grid-element-auto-repeat-get-set-expected.txt:
- 12:33 AM Changeset in webkit [200820] by
-
- 3 edits in trunk/Websites/perf.webkit.org
Always use v3 UI for dashboards and analysis task pages
https://bugs.webkit.org/show_bug.cgi?id=157647
Reviewed by Darin Adler.
Redirect dashboard pages from v1 and v2 to v3's summary page. Also redirect v1 UI's charts page and v2 UI's
analysis task pages to the corresponding v3 pages.
Keep v2's charts page accessible since some features such as segmentation is still only available on v2 UI.
- public/index.html:
(init.showCharts): Redirect to v3 UI once the chart list has been parsed.
(init.redirectChartsToV3): Added.
- public/v2/index.html:
- 12:31 AM Changeset in webkit [200819] by
-
- 17 edits in trunk/Source
Revert r199691.
https://bugs.webkit.org/show_bug.cgi?id=157645
<rdar://problem/26235373>
Patch by Tina Liu <iting_liu@apple.com> on 2016-05-13
Reviewed by Darin Adler.
Source/WebCore:
- plugins/PluginStrategy.h:
Source/WebKit/mac:
- WebCoreSupport/WebPlatformStrategies.h:
- WebCoreSupport/WebPlatformStrategies.mm:
(WebPlatformStrategies::setPrivateBrowsingPluginLoadClientPolicy): Deleted.
Source/WebKit2:
- Shared/WebProcessCreationParameters.cpp:
(WebKit::WebProcessCreationParameters::encode): Deleted.
(WebKit::WebProcessCreationParameters::decode): Deleted.
- Shared/WebProcessCreationParameters.h:
- UIProcess/API/C/mac/WKContextPrivateMac.h:
- UIProcess/API/C/mac/WKContextPrivateMac.mm:
(WKContextSetPrivateBrowsingPluginLoadClientPolicy): Deleted.
- UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::setPluginLoadClientPolicy):
(WebKit::WebProcessPool::createNewWebProcess): Deleted.
(WebKit::WebProcessPool::setPluginLoadClientPolicyForPrivateBrowsing): Deleted.
(WebKit::WebProcessPool::setPrivateBrowsingPluginLoadClientPolicy): Deleted.
(WebKit::WebProcessPool::clearPluginClientPolicies): Deleted.
- UIProcess/WebProcessPool.h:
- WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
(WebKit::WebPlatformStrategies::setPluginLoadClientPolicy):
(WebKit::WebPlatformStrategies::longestMatchedWildcardHostForHost):
(WebKit::WebPlatformStrategies::replaceHostWithMatchedWildcardHost):
(WebKit::WebPlatformStrategies::pluginLoadClientPolicyForHost):
(WebKit::WebPlatformStrategies::populatePluginCache):
(WebKit::WebPlatformStrategies::setPluginLoadClientPolicyForPrivateBrowsing): Deleted.
(WebKit::WebPlatformStrategies::setPrivateBrowsingPluginLoadClientPolicy): Deleted.
(WebKit::WebPlatformStrategies::clearPluginClientPolicies): Deleted.
(WebKit::WebPlatformStrategies::pluginLoadClientPolicyForHostForPrivateBrowsing): Deleted.
- WebProcess/WebCoreSupport/WebPlatformStrategies.h:
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::initializeWebProcess):
(WebKit::WebProcess::setPluginLoadClientPolicies): Deleted.
(WebKit::WebProcess::setPrivateBrowsingPluginLoadClientPolicy): Deleted.
- WebProcess/WebProcess.h:
- WebProcess/WebProcess.messages.in:
- 12:31 AM Changeset in webkit [200818] by
-
- 3 edits in trunk/Websites/perf.webkit.org
Show a spinner while fetching data on summary page
https://bugs.webkit.org/show_bug.cgi?id=157658
Reviewed by Darin Adler.
Show a spinner while fetching JSON files on the summary page.
- public/v3/components/base.js:
(ComponentBase.prototype.renderReplace): Added a new implementation that simply calls the static version.
(ComponentBase.renderReplace): Made this static.
- public/v3/pages/summary-page.js:
(SummaryPage.prototype._constructRatioGraph): Show a spinner icon when SummaryPageConfigurationGroup's
isFetching returns true.
(SummaryPage.cssTemplate): Force the height of each cell to be 2.5rem so that the height of cell doesn't
change when a spinner is replaced by a ratio bar graph.
(SummaryPageConfigurationGroup): Added this._isFetching as an instance variable.
(SummaryPageConfigurationGroup.prototype.isFetching): Added.
(SummaryPageConfigurationGroup.prototype.fetchAndComputeSummary): Set this._isFetching while waiting for
the promises to resolve after 50ms. We don't immediately set this._isFetching to avoid FOC when all JSON
files have been cached.
May 12, 2016:
- 11:38 PM Changeset in webkit [200817] by
-
- 2 edits in branches/safari-602.1.32-branch/Source/WebKit/mac
Merged r200664. rdar://problem/26262632
- 11:37 PM Changeset in webkit [200816] by
-
- 19 edits in branches/safari-602.1.32-branch/Source
Roll out r200463. rdar://problem/26260800
- 11:34 PM Changeset in webkit [200815] by
-
- 2 edits in branches/safari-602.1.32-branch/Source/WebCore
Roll out r200469. rdar://problem/26260800
- 11:28 PM Changeset in webkit [200814] by
-
- 3 edits in trunk/Source/WebCore
Drop WorkerGlobalScope's custom GetOwnPropertySlot() implementation
https://bugs.webkit.org/show_bug.cgi?id=157662
Reviewed by Darin Adler.
Drop WorkerGlobalScope's custom GetOwnPropertySlot() implementation as
it is no longer needed after <http://trac.webkit.org/changeset/196678>.
JSC::getStaticPropertySlot() now properly checks for overrides *before*
checking the static table.
No new tests, no web-exposed behavior change.
- bindings/js/JSWorkerGlobalScopeCustom.cpp:
(WebCore::JSWorkerGlobalScope::getOwnPropertySlotDelegate): Deleted.
- workers/WorkerGlobalScope.idl:
- 10:52 PM Changeset in webkit [200813] by
-
- 2 edits in trunk/Source/WebCore
CoordinatedGraphicsLayer::syncLayerState() should set the m_layerState.contentsOpaque flag
https://bugs.webkit.org/show_bug.cgi?id=157575
Reviewed by Darin Adler.
- platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:
(WebCore::CoordinatedGraphicsLayer::syncLayerState): The contentsOpaque flag in the
layer's CoordinatedGraphicsLayerState object should also be set to the current value
of the layer. This is the only flag in the union of 9 members that's not being updated
in this method.
- 10:48 PM Changeset in webkit [200812] by
-
- 3 edits in trunk/Source/WebCore
[TexMap] Handle TextureMapperShaderProgram objects through references
https://bugs.webkit.org/show_bug.cgi?id=157619
Reviewed by Antonio Gomes.
TextureMapper code always expects valid TextureMapperShaderProgram
objects to be created, so it doesn't make sense to access these
objects through raw pointers or RefPtr<>s.
- platform/graphics/texmap/TextureMapperGL.cpp:
(WebCore::TextureMapperGL::drawBorder):
(WebCore::prepareFilterProgram):
(WebCore::TextureMapperGL::drawTexture):
(WebCore::TextureMapperGL::drawSolidColor):
(WebCore::TextureMapperGL::drawEdgeTriangles):
(WebCore::TextureMapperGL::drawUnitRect):
(WebCore::TextureMapperGL::draw):
(WebCore::TextureMapperGL::drawTexturedQuadWithProgram):
(WebCore::TextureMapperGL::drawFiltered):
(WebCore::TextureMapperGL::beginClip):
- platform/graphics/texmap/TextureMapperGL.h:
- 10:46 PM Changeset in webkit [200811] by
-
- 2 edits in trunk/Source/WebCore
VideoSinkGStreamer: plug a GstBuffer leak in webkitVideoSinkRequestRender()
https://bugs.webkit.org/show_bug.cgi?id=157617
Reviewed by Darin Adler.
Unref the newly-created GstBuffer object after creating the new GstSample
that's based on it. gst_sample_new() doesn't take the ownership of it.
Also, don't unref the GstBuffer object that's passed in to the
webkitVideoSinkRequestRender() function in case the allocation of the
replacement buffer fails. We don't have any ownership over that buffer
and it's not unreffed anywhere else in this function.
- platform/graphics/gstreamer/VideoSinkGStreamer.cpp:
(webkitVideoSinkRequestRender):
- 9:20 PM Changeset in webkit [200810] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Remove "Extra Scripts" folder from Resources sidebar if all children removed
https://bugs.webkit.org/show_bug.cgi?id=157656
Reviewed by Timothy Hatcher.
- UserInterface/Views/ResourceSidebarPanel.js:
(WebInspector.ResourceSidebarPanel.prototype._scriptWasRemoved):
Remove parent folder after last script tree element removed.
- 9:19 PM Changeset in webkit [200809] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Can't filter Rendering Frames by duration
https://bugs.webkit.org/show_bug.cgi?id=157654
Reviewed by Timothy Hatcher.
- UserInterface/Views/RenderingFrameTimelineView.js:
(WebInspector.RenderingFrameTimelineView.prototype._scopeBarSelectionDidChange):
Call filterDidChange on the grid, not the base class.
TimelineView.filterDidChange exists to let TimelineViews perform
additional work when the grid filter changes (see LayoutTimelineView).
(WebInspector.RenderingFrameTimelineView):
- 9:15 PM Changeset in webkit [200808] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Deleting nodes in DOM Tree sometimes changes selection to parent instead of sibling
https://bugs.webkit.org/show_bug.cgi?id=157649
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-05-12
Reviewed by Timothy Hatcher.
- UserInterface/Views/DOMTreeElement.js:
(WebInspector.DOMTreeElement.prototype._updateChildren): Deleted.
When pressing delete, we remove the node via DOM.removeNode()
and remove the DOMTreeElement when we receive a successful response.
However, the backend could send a DOM.childNodeRemoved event before
the response from DOM.removeNode, and the frontend would have a race
between DOMTreeUpdater's timeout and the removeNode callback.
In DOMTreeUpdater's path, DOMTreeElement updateChildren would notice
a removed node and set the selection to the parent node.
In the DOM.removeNode path, TreeOutline would update the selection
based on availability of a previousSibling/nextSibling/parent.
Remove the custom code in DOMTreeElement updateChildren, so that it
can just do the normal TreeOutline behavior via removeChildAtIndex.
- 6:55 PM Changeset in webkit [200807] by
-
- 3 edits3 adds in trunk
Source/WebCore:
[Cocoa] Text shadow sometimes clipped unexpectedly
https://bugs.webkit.org/show_bug.cgi?id=108929
Reviewed by Dean Jackson.
CoreGraphics can only draw one text shadow at a time. We work around that by drawing
the text multiple times, one for each shadow. However, we want to make sure that the
original text isn't also drawn multiple times, so we bump up the shadow offsets so
the text and the shadow don't intersect, and then we clip out the original text (so
only the shadow remains).
Unfortunately, this clipping requires knowing where the visual extent of the text is,
which WebKit currently has trouble with. In particular, we often use layout extents
in lieu of visual extents, which is a problem when the glyphs draw outside of their
layout boxes. In this case, it causes us to think the text shadow is much smaller
than it really is, so our clipping operation clips to an area which is too small.
A quick solution to this is to inflate the clip rect by an amount proportional to the
font size, and offset the text shadow accordingly. If this amount is large enough,
this bug will occur on few enough sites that it is reasonable to consider this bug
fixed without the real solution of educating WebKit properly about the difference
between text layout rects and text visual extent rects.
Test: fast/text/multiple-text-shadow-overflow-layout-rect.html
- rendering/TextPainter.cpp:
(WebCore::ShadowApplier::ShadowApplier):
LayoutTests:
Text shadow sometimes clipped unexpectedly
https://bugs.webkit.org/show_bug.cgi?id=108929
Reviewed by Dean Jackson.
Add a font which draws dramatically far outside of its layout rect.
- fast/text/multiple-text-shadow-overflow-layout-rect-expected.html: Added.
- fast/text/multiple-text-shadow-overflow-layout-rect.html: Added.
- fast/text/resources/font-overflow-layout-rect.svg: Added.
- 6:24 PM Changeset in webkit [200806] by
-
- 2 edits in trunk/Source/WebInspectorUI
REGRESSION: Web Inspector: Fails to load sourceMappingURL with relative URL
https://bugs.webkit.org/show_bug.cgi?id=157650
<rdar://problem/26133763>
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-05-12
Reviewed by Timothy Hatcher.
- UserInterface/Controllers/SourceMapManager.js:
Wrong order of arguments. The intent was to pass the incoming
baseURL as the partialURL, because if it was not absolute by
that point we could make it relative to the main resource.
However we accidentally put the main resource as the partial
portion, which would just always return the main resource url.
Swap the order, so that if the incoming base is absolute
(such as a resource.url) that will be used, but if the
incoming base is relative (e.g. an incomplete sourceURL) we
can make it absolute with the main resource.
- 5:55 PM Changeset in webkit [200805] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Uncaught exception when removing selected Timeline instrument
https://bugs.webkit.org/show_bug.cgi?id=157639
<rdar://problem/26252938>
Reviewed by Timothy Hatcher.
- UserInterface/Views/TimelineOverview.js:
(WebInspector.TimelineOverview.prototype._instrumentRemoved):
Remove timeline tree element before modifying state. Removing the tree
element triggers a SelectionDidChange event, which can have side effects.
- 5:48 PM Changeset in webkit [200804] by
-
- 3 edits in trunk/LayoutTests
Marking inspector/debugger/command-line-api-exception-nested-catch.html as a flaky timeout on mac
https://bugs.webkit.org/show_bug.cgi?id=152487
Unreviewed test gardening.
- platform/mac-wk1/TestExpectations:
- platform/mac/TestExpectations:
- 5:24 PM Changeset in webkit [200803] by
-
- 3 edits2 adds in trunk
REGRESSION(r200601): Crash when using local() and unicode-range in @font-face blocks
https://bugs.webkit.org/show_bug.cgi?id=157646
Reviewed by Geoffrey Garen.
Source/WebCore:
I simply forgot a null check.
Test: fast/text/isLoading-crash-failed-font.html
- css/CSSSegmentedFontFace.cpp:
LayoutTests:
- fast/text/isLoading-crash-failed-font-expected.txt: Added.
- fast/text/isLoading-crash-failed-font.html: Added.
- 5:09 PM Changeset in webkit [200802] by
-
- 1 copy in tags/Safari-601.7.1
New Tag.
- 4:47 PM Changeset in webkit [200801] by
-
- 1 copy in tags/Safari-601.1.46.140
New Tag.
- 4:40 PM Changeset in webkit [200800] by
-
- 2 edits in trunk/Source/WebKit/mac
Unreviewed build fix for r200799.
- WebView/WebView.mm:
- 4:22 PM Changeset in webkit [200799] by
-
- 12 edits in trunk
REGRESSION (r199313): ICBC app: text field In the webview is not tappable
https://bugs.webkit.org/show_bug.cgi?id=157396
<rdar://problem/25931513>
Reviewed by David Kilzer.
Source/WebCore:
Add a quirk for WebKit1 apps.
- loader/SubframeLoader.cpp:
(WebCore::SubframeLoader::requestFrame):
Even though the HTML spec suggests that we should navigate to about:blank
for subframes/iframes, of which the src cannot be resolved to an valid URL,
many existing WebKit1 apps are relying on invalid URLs to bridge their WebView
codes and their native Objective-C codes. Therefore, a quirk is added to
escape the URL validation for existing WebKit1 apps.
(WebCore::SubframeLoader::shouldConvertInvalidURLsToBlank):
- loader/SubframeLoader.h:
- page/Settings.in:
Source/WebKit/mac:
Add a quirk for WebKit1 apps.
- WebView/WebView.mm:
(shouldConvertInvalidURLsToBlank):
(-[WebView _preferencesChanged:]):
LayoutTests:
The previous test is actually bogus, and therefore modify it to do the
real task.
- fast/loader/iframe-src-invalid-url-expected.txt:
- fast/loader/iframe-src-invalid-url.html:
- platform/ios-simulator-wk1/TestExpectations:
- platform/mac-wk1/TestExpectations:
- platform/win/TestExpectations:
- 4:11 PM Changeset in webkit [200798] by
-
- 5 edits in branches/safari-602.1.32-branch/Source
Versioning.
- 4:09 PM Changeset in webkit [200797] by
-
- 1 copy in tags/Safari-602.1.32.1
New tag.
- 3:55 PM Changeset in webkit [200796] by
-
- 2 edits in trunk/Source/JavaScriptCore
Baseline and DFG's JSC_report...CompileTimes needs CodeBlock hashes.
https://bugs.webkit.org/show_bug.cgi?id=157643
Reviewed by Keith Miller.
- runtime/Options.cpp:
(JSC::recomputeDependentOptions):
- 3:51 PM Changeset in webkit [200795] by
-
- 1 edit in trunk/Source/WebInspectorUI/ChangeLog
Unreviewed, fix ChangeLog title for r199634
- 3:13 PM Changeset in webkit [200794] by
-
- 2 edits in trunk/Source/WebCore
Prevent clicks in the placeholder from playing or pausing the video in a MediaDocument.
https://bugs.webkit.org/show_bug.cgi?id=157625
Reviewed by Jer Noble.
- Modules/mediacontrols/mediaControlsApple.js:
(Controller.prototype.createControls):
(Controller.prototype.handlePlaceholderClick):
- 3:09 PM Changeset in webkit [200793] by
-
- 4 edits in trunk/Source/WebInspectorUI
Web Inspector: Timeline Reset button only resets the one active Script TimelineView
https://bugs.webkit.org/show_bug.cgi?id=157638
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-05-12
Reviewed by Timothy Hatcher.
- UserInterface/Views/ScriptClusterTimelineView.js:
(WebInspector.ScriptClusterTimelineView.prototype.reset):
Reset should reset all the views.
(WebInspector.ScriptClusterTimelineView.prototype.get navigationSidebarTreeOutline): Deleted.
- UserInterface/Views/NetworkGridContentView.js:
(WebInspector.NetworkGridContentView.prototype.get navigationSidebarTreeOutline): Deleted.
- UserInterface/Views/TimelineView.js:
(WebInspector.TimelineView.prototype.get navigationSidebarTreeOutlineScopeBar): Deleted.
Remove dead code. Nobody calls these getters.
- 3:08 PM Changeset in webkit [200792] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Layout timeline popovers are inconsistently shown
https://bugs.webkit.org/show_bug.cgi?id=157640
<rdar://problem/26253394>
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-05-12
Reviewed by Timothy Hatcher.
- UserInterface/Views/TimelineDataGrid.js:
(WebInspector.TimelineDataGrid.prototype._showPopoverForSelectedNodeSoon):
Fix the bug by clearing _showPopoverTimeout when we show the popover.
(WebInspector.TimelineDataGrid.prototype._hidePopover):
Modernize the code to use arrow functions and avoid binds.
(WebInspector.TimelineDataGrid.prototype._updatePopoverForSelectedNode):
Updating with presentNewContentWithFrame animates the popover to the correct
position instead of jumping and ending up at the wrong location.
- 3:06 PM Changeset in webkit [200791] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Remove forced layouts caused by DOMTreeElement during Timeline recording
https://bugs.webkit.org/show_bug.cgi?id=157641
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-05-12
Reviewed by Timothy Hatcher.
- UserInterface/Views/DOMTreeElement.js:
(WebInspector.DOMTreeElement.prototype.updateSelection): Deleted.
This triggers forced layout and I could never actually get it to trigger anyways.
Its history is from the original import, so I don't know why it was added to begin with.
Just remove it.
- 2:52 PM Changeset in webkit [200790] by
-
- 3 edits in trunk/Source/WebInspectorUI
Unreviewed, rolling out r200718.
https://bugs.webkit.org/show_bug.cgi?id=157637
Data grid column dividers are misaligned (Requested by NVI on
#webkit).
Reverted changeset:
"Web Inspector: Contents of Duration column are covered by
always on (legacy) scroll bars"
https://bugs.webkit.org/show_bug.cgi?id=157590
http://trac.webkit.org/changeset/200718
- 2:13 PM Changeset in webkit [200789] by
-
- 30 edits in trunk/Source/WebCore
Drop toJS() overload taking a PassRefPtr<> parameter
https://bugs.webkit.org/show_bug.cgi?id=157627
Reviewed by Alex Christensen.
Update our implementation stop stop returning PassRefPtrs to the
JS bindings and drop the toJS() overload taking a PassRefPtr<>
parameter
- Modules/mediasource/SourceBuffer.cpp:
(WebCore::SourceBuffer::buffered):
- Modules/mediasource/SourceBuffer.h:
- Modules/webaudio/AudioBuffer.cpp:
(WebCore::AudioBuffer::getChannelData):
- Modules/webaudio/AudioBuffer.h:
- animation/DocumentTimeline.cpp:
(WebCore::DocumentTimeline::create):
- animation/DocumentTimeline.h:
- bindings/js/JSDOMBinding.h:
(WebCore::toJS): Deleted.
(WebCore::toJSNewlyCreated): Deleted.
- css/CSSPrimitiveValue.cpp:
(WebCore::CSSPrimitiveValue::getRGBColorValue):
- css/CSSPrimitiveValue.h:
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::error):
- html/HTMLMediaElement.h:
- html/LabelableElement.cpp:
(WebCore::LabelableElement::labels):
- html/LabelableElement.h:
- html/canvas/WebGLGetInfo.cpp:
(WebCore::WebGLGetInfo::getWebGLBuffer):
(WebCore::WebGLGetInfo::getWebGLFloatArray):
(WebCore::WebGLGetInfo::getWebGLFramebuffer):
(WebCore::WebGLGetInfo::getWebGLIntArray):
(WebCore::WebGLGetInfo::getWebGLProgram):
(WebCore::WebGLGetInfo::getWebGLRenderbuffer):
(WebCore::WebGLGetInfo::getWebGLTexture):
(WebCore::WebGLGetInfo::getWebGLUnsignedByteArray):
(WebCore::WebGLGetInfo::getWebGLUnsignedIntArray):
(WebCore::WebGLGetInfo::getWebGLVertexArrayObjectOES):
(WebCore::WebGLGetInfo::getWebGLVertexArrayObject):
- html/canvas/WebGLGetInfo.h:
- html/canvas/WebGLRenderingContextBase.cpp:
(WebCore::WebGLRenderingContextBase::paintRenderingResultsToImageData):
(WebCore::WebGLRenderingContextBase::createBuffer):
(WebCore::WebGLRenderingContextBase::createFramebuffer):
(WebCore::WebGLRenderingContextBase::createTexture):
(WebCore::WebGLRenderingContextBase::createProgram):
(WebCore::WebGLRenderingContextBase::createRenderbuffer):
(WebCore::WebGLRenderingContextBase::createShader):
(WebCore::WebGLRenderingContextBase::getActiveAttrib):
(WebCore::WebGLRenderingContextBase::getActiveUniform):
(WebCore::WebGLRenderingContextBase::getShaderPrecisionFormat):
(WebCore::WebGLRenderingContextBase::getUniformLocation):
(WebCore::WebGLRenderingContextBase::drawImageIntoBuffer):
(WebCore::WebGLRenderingContextBase::videoFrameToImage):
- html/canvas/WebGLRenderingContextBase.h:
- html/track/TextTrackCue.cpp:
(WebCore::TextTrackCue::create):
- html/track/TextTrackCue.h:
- html/track/VTTCue.cpp:
(WebCore::VTTCueBox::create):
- html/track/VTTCue.h:
- page/DOMSelection.cpp:
(WebCore::DOMSelection::getRangeAt):
- page/DOMSelection.h:
- page/DOMWindow.cpp:
(WebCore::DOMWindow::matchMedia):
(WebCore::DOMWindow::styleMedia):
(WebCore::DOMWindow::getComputedStyle):
(WebCore::DOMWindow::getMatchedCSSRules):
(WebCore::DOMWindow::webkitConvertPointFromNodeToPage):
(WebCore::DOMWindow::webkitConvertPointFromPageToNode):
(WebCore::DOMWindow::open):
- page/DOMWindow.h:
- page/Location.cpp:
(WebCore::Location::ancestorOrigins):
- page/Location.h:
- 12:54 PM Changeset in webkit [200788] by
-
- 4 edits in trunk/Source/WebCore
Touch.prototype is undefined on iOS
https://bugs.webkit.org/show_bug.cgi?id=157560
<rdar://problem/26143008>
Reviewed by Chris Dumez.
Remove Touch and TouchList attributes from DOMWindow.
These attributes should be exposed via generated binding code (JSDOMWindow.cpp).
- bindings/js/JSDOMWindowCustom.cpp:
(WebCore::JSDOMWindow::touch): Deleted.
(WebCore::JSDOMWindow::touchList): Deleted.
- bindings/js/ios/TouchConstructors.cpp:
- page/DOMWindow.idl:
- 12:51 PM Changeset in webkit [200787] by
-
- 7 edits in trunk
indexForVisiblePosition should use the root editable element as the scope
https://bugs.webkit.org/show_bug.cgi?id=157611
Reviewed by Darin Adler.
Source/WebCore:
Use the highest editing host instead of the document node as the scope in indexForVisiblePosition
when it's called inside an editable region. This refactoring is necessary to unblock the work to support
undo/redo in VoiceOver after r199030.
We have to workaround a bug in indexForVisiblePosition that it could return a slightly higher index than
the expected value because TextIterator emits an extra new line after a block element with a large margin
at the bottom. Unfortunately, fixing this requires a lot of code changes since the rest of the editing
code assumes this behavior and/or happens to cancel it out with some other quirks.
- editing/ApplyBlockElementCommand.cpp:
(WebCore::ApplyBlockElementCommand::doApply):
- editing/htmlediting.cpp:
(WebCore::indexForVisiblePosition):
LayoutTests:
Rebaselined tests with progressions.
- editing/execCommand/crash-indenting-list-item-expected.txt: Now preseves the selection at the beginning of
the editable region instead of moving it to the end.
- editing/execCommand/format-block-multiple-paragraphs-in-pre-expected.txt: Now preserves selection in more test
cases. This test is the one that required the workaround in ApplyBlockElementCommand::doApply. One of the test
cases would regress and clear the selection without it.
- editing/execCommand/indent-pre-list-expected.txt: Now preserves the selection instead of clearing it.
- 12:29 PM Changeset in webkit [200786] by
-
- 3 edits in trunk/Source/WebKit/mac
WebKitAdditions needs to be notified before the WebView is dealloc'd
https://bugs.webkit.org/show_bug.cgi?id=157633
-and corresponding-
rdar://problem/26134539
Reviewed by Anders Carlsson.
- WebView/WebView.mm:
(-[WebView dealloc]):
- WebView/WebViewInternal.h:
- 12:14 PM Changeset in webkit [200785] by
-
- 7 edits in trunk/Source
Use SecTask SPI to retrieve code signing identifier for user directory suffix
https://bugs.webkit.org/show_bug.cgi?id=157570
Source/WebKit2:
<rdar://problem/25706517>
Reviewed by Darin Adler.
It is sufficient to make use of the SecTask SPI to retrieve the code signing
identifier of the embedding client for use in the user directory suffix. This
avoids the need to allow Code Signing Services to have access to the bundle
of the embedding client.
- Shared/mac/ChildProcessMac.mm:
(WebKit::ChildProcess::initializeSandbox): Use the code signing identifier of the
embedding client as part of the user directory suffix if available.
- Shared/mac/CodeSigning.h: Update comment and include header wtf/spi/darwin/XPCSPI.h
for the definition of xpc_connection_t. Renamed codeSigningIdentifier() to codeSigningIdentifierForCurrentProcess()
to convey that it returns the code signing identifier for the current process. Repurposed
the name codeSigningIdentifier for the variant of this function that takes a xpc_connection_t.
- Shared/mac/CodeSigning.mm:
(WebKit::codeSigningIdentifier): Added. Uses the audit token associated with the specified
XPC connection to get the code signing identifier for the embedding client.
(WebKit::codeSigningIdentifierForCurrentProcess): Renamed; formerly named codeSigningIdentifier.
Implemented in terms of the SecTask API.
(WebKit::secCodeForCurrentProcess): Deleted.
(WebKit::secCodeForProcess): Deleted.
(WebKit::secCodeSigningInformation): Deleted.
(WebKit::appleSignedOrMacAppStoreSignedOrAppleDeveloperSignedRequirement): Deleted.
(WebKit::secCodeSigningIdentifier): Deleted.
(WebKit::codeSigningIdentifierForProcess): Deleted.
- UIProcess/Launcher/mac/ProcessLauncherMac.mm:
(WebKit::connectToService): Update code due to renaming.
Source/WTF:
Reviewed by Darin Adler.
<rdar://problem/25706517>
Forward declare SPI SecTaskCopySigningIdentifier().
- wtf/spi/cocoa/SecuritySPI.h:
- 12:13 PM Changeset in webkit [200784] by
-
- 2 edits in branches/safari-601-branch/Source/WebCore
Build fix after r195004/r200780.
- 11:57 AM Changeset in webkit [200783] by
-
- 2 edits1 copy in branches/safari-601.1.46-branch/Source/JavaScriptCore
Merge patch for r200387. rdar://problem/26131112
- 11:53 AM Changeset in webkit [200782] by
-
- 2 edits1 add in branches/safari-601-branch/Source/JavaScriptCore
Merge patch for r200387. rdar://problem/26131068
- 11:44 AM Changeset in webkit [200781] by
-
- 2 edits in trunk/Source/WebCore
Cleanup RenderObject::containingBlock.
https://bugs.webkit.org/show_bug.cgi?id=157628
Reviewed by Chris Dumez.
No change in functionality.
- rendering/RenderObject.cpp:
(WebCore::RenderObject::containingBlock):
- 11:09 AM Changeset in webkit [200780] by
-
- 8 edits in branches/safari-601-branch/Source/WebCore
Merged r195004. rdar://problem/26228562
- 10:57 AM Changeset in webkit [200779] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: 11% of time in TimelineRecording spent updating DataGrid that is not visible
https://bugs.webkit.org/show_bug.cgi?id=157612
<rdar://problem/26239051>
Reviewed by Timothy Hatcher.
During recording, a timeline view is constantly having its cached time
values updated. These updates should only trigger forced layouts if the
view supports live data.
- UserInterface/Views/TimelineView.js:
(WebInspector.TimelineView.prototype.set zeroTime):
Drive-by fix, add call to _filterTimesDidChange.
(WebInspector.TimelineView.prototype.set startTime):
(WebInspector.TimelineView.prototype.set endTime):
(WebInspector.TimelineView.prototype.set currentTime):
Don't update layout directly.
(WebInspector.TimelineView.prototype._timesDidChange):
Force a layout if the view supports live data. When not recording,
a layout is always performed.
(WebInspector.TimelineView):
(WebInspector.TimelineView.prototype._filterTimesDidChange.delayedWork): Deleted.
Changed to an arrow function.
(WebInspector.TimelineView.prototype._filterTimesDidChange): Deleted.
Renamed _timesDidChange, since the method now does more than throttle
a filterDidChange call.
- 10:53 AM Changeset in webkit [200778] by
-
- 5 edits2 adds in trunk
Adjust "main content" video heuristic
https://bugs.webkit.org/show_bug.cgi?id=157532
Source/WebCore:
<rdar://problem/25840861>
Reviewed by Darin Adler.
Test: media/video-main-content-autoplay.html, plus existing tests updated.
- html/MediaElementSession.cpp:
(WebCore::MediaElementSession::canControlControlsManager): Use isElementLargeEnoughForMainContent.
(WebCore::isMainContent): Ditto.
(WebCore::isElementLargeEnoughForMainContent): Check video area and aspect ratio.
(WebCore::MediaElementSession::mainContentCheckTimerFired): Call result.setToNonUserAgentShadowAncestor
so it doesn't hit test the video controls in the shadow DOM.
LayoutTests:
Reviewed by Darin Adler.
- media/video-main-content-allow.html:
- media/video-main-content-autoplay-expected.txt: Added.
- media/video-main-content-autoplay.html: Added.
- media/video-main-content-deny-too-small.html:
- 10:01 AM Changeset in webkit [200777] by
-
- 5 edits in branches/safari-601.1.46-branch/Source
Versioning.
- 9:21 AM Changeset in webkit [200776] by
-
- 4 edits in trunk/Source/WebCore
[curl] ASSERTION FAILED: isLocalFile() url == m_string in fast/dom/34176.html https://bugs.webkit.org/show_bug.cgi?id=157059
Patch by Fujii Hironori <Fujii Hironori> on 2016-05-12
Reviewed by Darin Adler.
Fix incorrect usage of URL constructor. CURLINFO_EFFECTIVE_URL
does not conform to URL's ParsedURLString. Created a new utility
function to convert CURLINFO_EFFECTIVE_URL to a URL, and replaced
all codes converting CURLINFO_EFFECTIVE_URL with it.
Test: fast/dom/34176.html
- platform/network/curl/CurlDownload.cpp:
(WebCore::CurlDownload::didReceiveHeader): Use getCurlEffectiveURL
- platform/network/curl/ResourceHandleManager.cpp:
(WebCore::getCurlEffectiveURL): Added.
(WebCore::handleLocalReceiveResponse): Use getCurlEffectiveURL
(WebCore::getProtectionSpace): Ditto.
(WebCore::headerCallback): Ditto.
(WebCore::ResourceHandleManager::downloadTimerCallback): Ditto.
- platform/network/curl/ResourceHandleManager.h: Add a declaration
of getCurlEffectiveURL.
- 9:07 AM Changeset in webkit [200775] by
-
- 104 edits in trunk/Source/WebCore
Avoid unnecessary null checks in toJS() when the implementation returns a reference or Ref<>
https://bugs.webkit.org/show_bug.cgi?id=157604
Reviewed by Darin Adler.
Avoid unnecessary null checks in toJS() when the implementation returns
a C++ reference or Ref<>. To achieve this, the following changes were
made:
- Have toJS() overload that takes a raw pointer call the one that takes in a C++ reference, instead of the other way around. This way, we only do the null check when passing a raw pointer in.
- Stop calling WTF::getPtr() on the value returned by the implementation because this causes us to call toJS() with a raw pointer every time.
- Add an toJS() overload in JSDOMBinding.h that takes a Ref<T> in and that calls toJS() with a C++ reference internally. This way, we bypass the null check if the implementation returns a Ref<T>.
Further refactoring could be done but I try to keep the size of this
patch as small as possible. toJS() should probably take the ExecState
and the globalObject by reference, for e.g.
- bindings/js/JSAnimationTimelineCustom.cpp:
(WebCore::toJS):
- bindings/js/JSBlobCustom.cpp:
(WebCore::toJS):
(WebCore::constructJSBlob): Deleted.
- bindings/js/JSCSSRuleCustom.cpp:
(WebCore::toJS):
- bindings/js/JSCSSStyleDeclarationCustom.cpp:
(WebCore::JSCSSStyleDeclaration::getPropertyCSSValue):
- bindings/js/JSCSSValueCustom.cpp:
(WebCore::toJS):
- bindings/js/JSCanvasRenderingContextCustom.cpp:
(WebCore::toJS):
- bindings/js/JSCustomElementInterface.cpp:
(WebCore::JSCustomElementInterface::attributeChanged):
- bindings/js/JSDOMBinding.h:
(WebCore::toJS):
(WebCore::toJSNewlyCreated):
- bindings/js/JSDOMFormDataCustom.cpp:
(WebCore::constructJSDOMFormData):
- bindings/js/JSDOMMimeTypeArrayCustom.cpp:
(WebCore::JSDOMMimeTypeArray::nameGetter):
- bindings/js/JSDOMNamedFlowCollectionCustom.cpp:
(WebCore::JSDOMNamedFlowCollection::nameGetter):
- bindings/js/JSDOMPluginArrayCustom.cpp:
(WebCore::JSDOMPluginArray::nameGetter):
- bindings/js/JSDOMPluginCustom.cpp:
(WebCore::JSDOMPlugin::nameGetter):
- bindings/js/JSDOMWindowBase.cpp:
(WebCore::toJS):
- bindings/js/JSDOMWindowBase.h:
(WebCore::toJS):
- bindings/js/JSDOMWindowCustom.cpp:
(WebCore::jsDOMWindowGetOwnPropertySlotNamedItemGetter):
- bindings/js/JSDocumentCustom.cpp:
(WebCore::toJS):
(WebCore::toJSNewlyCreated):
(WebCore::JSDocument::createTouchList):
(WebCore::JSDocument::prepend): Deleted.
- bindings/js/JSDocumentFragmentCustom.cpp:
(WebCore::toJSNewlyCreated):
(WebCore::toJS):
- bindings/js/JSEventCustom.cpp:
(WebCore::toJS):
(WebCore::toJSNewlyCreated):
- bindings/js/JSEventTargetCustom.cpp:
(WebCore::toJS):
- bindings/js/JSFileReaderCustom.cpp:
(WebCore::JSFileReader::result):
- bindings/js/JSHTMLAllCollectionCustom.cpp:
(WebCore::namedItems):
(WebCore::callHTMLAllCollection):
- bindings/js/JSHTMLCanvasElementCustom.cpp:
(WebCore::JSHTMLCanvasElement::getContext):
- bindings/js/JSHTMLCollectionCustom.cpp:
(WebCore::JSHTMLCollection::nameGetter):
(WebCore::toJS):
- bindings/js/JSHTMLDocumentCustom.cpp:
(WebCore::JSHTMLDocument::nameGetter):
- bindings/js/JSHTMLElementCustom.cpp:
(WebCore::constructJSHTMLElement):
(WebCore::JSHTMLElement::pushEventHandlerScope):
- bindings/js/JSHTMLFormControlsCollectionCustom.cpp:
(WebCore::namedItems):
- bindings/js/JSHTMLFormElementCustom.cpp:
(WebCore::JSHTMLFormElement::nameGetter):
- bindings/js/JSHTMLOptionsCollectionCustom.cpp:
(WebCore::JSHTMLOptionsCollection::nameGetter):
- bindings/js/JSIDBCursorCustom.cpp:
(WebCore::JSIDBCursor::source):
(WebCore::toJS):
- bindings/js/JSIDBDatabaseCustom.cpp:
(WebCore::JSIDBDatabase::createObjectStore):
(WebCore::JSIDBDatabase::transaction):
- bindings/js/JSIDBRequestCustom.cpp:
(WebCore::JSIDBRequest::result):
(WebCore::JSIDBRequest::source):
- bindings/js/JSImageConstructor.cpp:
(WebCore::JSImageConstructor::construct):
- bindings/js/JSImageDataCustom.cpp:
(WebCore::toJS):
- bindings/js/JSLazyEventListener.cpp:
(WebCore::JSLazyEventListener::initializeJSFunction):
- bindings/js/JSMediaSessionCustom.cpp:
(WebCore::constructJSMediaSession):
- bindings/js/JSMediaStreamCapabilitiesCustom.cpp:
(WebCore::toJS):
- bindings/js/JSNamedNodeMapCustom.cpp:
(WebCore::JSNamedNodeMap::nameGetter):
- bindings/js/JSNodeCustom.cpp:
(WebCore::createWrapperInline):
(WebCore::toJSNewlyCreated):
(WebCore::willCreatePossiblyOrphanedTreeByRemovalSlowCase):
(WebCore::getOutOfLineCachedWrapper): Deleted.
- bindings/js/JSNodeCustom.h:
(WebCore::toJS):
- bindings/js/JSNodeListCustom.cpp:
(WebCore::toJSNewlyCreated):
- bindings/js/JSNodeListCustom.h:
(WebCore::toJS):
- bindings/js/JSPerformanceEntryCustom.cpp:
(WebCore::toJS):
- bindings/js/JSPopStateEventCustom.cpp:
(WebCore::JSPopStateEvent::state):
- bindings/js/JSRTCStatsResponseCustom.cpp:
(WebCore::JSRTCStatsResponse::nameGetter):
- bindings/js/JSSVGPathSegCustom.cpp:
(WebCore::toJS):
- bindings/js/JSStyleSheetCustom.cpp:
(WebCore::toJS):
- bindings/js/JSTextTrackCueCustom.cpp:
(WebCore::toJS):
- bindings/js/JSTrackCustom.cpp:
(WebCore::toJS):
- bindings/js/JSTrackCustom.h:
- bindings/js/JSTrackEventCustom.cpp:
(WebCore::JSTrackEvent::track):
- bindings/js/JSUserMessageHandlersNamespaceCustom.cpp:
(WebCore::JSUserMessageHandlersNamespace::getOwnPropertySlotDelegate):
- bindings/js/JSWorkerCustom.cpp:
(WebCore::constructJSWorker):
- bindings/js/ReadableStreamController.cpp:
(WebCore::createReadableStream):
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateHeader):
(GenerateImplementation):
(GenerateCallbackHeader):
(GenerateCallbackImplementation):
(NativeToJSValue):
(GenerateConstructorDefinition):
(ceilingToPowerOf2): Deleted.
(ConstructorHasProperties): Deleted.
- bindings/scripts/test/JS/JSTestActiveDOMObject.cpp:
(WebCore::toJSNewlyCreated):
(WebCore::toJS):
(WebCore::JSTestActiveDOMObject::toWrapped): Deleted.
- bindings/scripts/test/JS/JSTestActiveDOMObject.h:
(WebCore::toJS):
(WebCore::toJSNewlyCreated):
- bindings/scripts/test/JS/JSTestCallback.cpp:
(WebCore::JSTestCallback::callbackWithArrayParam):
(WebCore::JSTestCallback::callbackWithStringList):
(WebCore::JSTestCallback::callbackRequiresThisToPass):
(WebCore::toJS):
- bindings/scripts/test/JS/JSTestCallback.h:
(WebCore::toJS):
- bindings/scripts/test/JS/JSTestCallbackFunction.cpp:
(WebCore::JSTestCallbackFunction::callbackWithArrayParam):
(WebCore::JSTestCallbackFunction::callbackWithStringList):
(WebCore::JSTestCallbackFunction::callbackRequiresThisToPass):
(WebCore::toJS):
- bindings/scripts/test/JS/JSTestCallbackFunction.h:
(WebCore::toJS):
- bindings/scripts/test/JS/JSTestClassWithJSBuiltinConstructor.cpp:
(WebCore::toJSNewlyCreated):
(WebCore::toJS):
(WebCore::JSTestClassWithJSBuiltinConstructor::toWrapped): Deleted.
- bindings/scripts/test/JS/JSTestClassWithJSBuiltinConstructor.h:
(WebCore::toJS):
(WebCore::toJSNewlyCreated):
- bindings/scripts/test/JS/JSTestCustomConstructorWithNoInterfaceObject.cpp:
(WebCore::toJSNewlyCreated):
(WebCore::toJS):
(WebCore::JSTestCustomConstructorWithNoInterfaceObject::toWrapped): Deleted.
- bindings/scripts/test/JS/JSTestCustomConstructorWithNoInterfaceObject.h:
(WebCore::toJS):
(WebCore::toJSNewlyCreated):
- bindings/scripts/test/JS/JSTestCustomNamedGetter.cpp:
(WebCore::toJSNewlyCreated):
(WebCore::toJS):
(WebCore::JSTestCustomNamedGetter::toWrapped): Deleted.
- bindings/scripts/test/JS/JSTestCustomNamedGetter.h:
(WebCore::toJS):
(WebCore::toJSNewlyCreated):
- bindings/scripts/test/JS/JSTestEventConstructor.cpp:
(WebCore::JSTestEventConstructorConstructor::construct):
(WebCore::toJSNewlyCreated):
(WebCore::toJS):
(WebCore::JSTestEventConstructor::toWrapped): Deleted.
- bindings/scripts/test/JS/JSTestEventConstructor.h:
(WebCore::toJS):
(WebCore::toJSNewlyCreated):
- bindings/scripts/test/JS/JSTestEventTarget.cpp:
(WebCore::jsTestEventTargetPrototypeFunctionItem):
(WebCore::toJSNewlyCreated):
(WebCore::toJS):
(WebCore::JSTestEventTarget::toWrapped): Deleted.
- bindings/scripts/test/JS/JSTestEventTarget.h:
(WebCore::toJS):
(WebCore::toJSNewlyCreated):
- bindings/scripts/test/JS/JSTestException.cpp:
(WebCore::toJSNewlyCreated):
(WebCore::toJS):
(WebCore::JSTestException::toWrapped): Deleted.
- bindings/scripts/test/JS/JSTestException.h:
(WebCore::toJS):
(WebCore::toJSNewlyCreated):
- bindings/scripts/test/JS/JSTestGenerateIsReachable.cpp:
(WebCore::toJSNewlyCreated):
(WebCore::toJS):
(WebCore::JSTestGenerateIsReachable::toWrapped): Deleted.
- bindings/scripts/test/JS/JSTestGenerateIsReachable.h:
(WebCore::toJS):
(WebCore::toJSNewlyCreated):
- bindings/scripts/test/JS/JSTestGlobalObject.cpp:
(WebCore::toJSNewlyCreated):
(WebCore::toJS):
(WebCore::JSTestGlobalObject::toWrapped): Deleted.
- bindings/scripts/test/JS/JSTestGlobalObject.h:
(WebCore::toJS):
(WebCore::toJSNewlyCreated):
- bindings/scripts/test/JS/JSTestInterface.cpp:
(WebCore::JSTestInterfaceConstructor::construct):
(WebCore::jsTestInterfaceImplementsNode):
(WebCore::jsTestInterfaceSupplementalNode):
(WebCore::jsTestInterfacePrototypeFunctionImplementsMethod2):
(WebCore::jsTestInterfacePrototypeFunctionSupplementalMethod2):
(WebCore::toJSNewlyCreated):
(WebCore::toJS):
(WebCore::JSTestInterface::toWrapped): Deleted.
- bindings/scripts/test/JS/JSTestInterface.h:
(WebCore::toJS):
(WebCore::toJSNewlyCreated):
- bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:
(WebCore::toJSNewlyCreated):
(WebCore::toJS):
(WebCore::JSTestMediaQueryListListener::toWrapped): Deleted.
- bindings/scripts/test/JS/JSTestMediaQueryListListener.h:
(WebCore::toJS):
(WebCore::toJSNewlyCreated):
- bindings/scripts/test/JS/JSTestNamedConstructor.cpp:
(WebCore::JSTestNamedConstructorNamedConstructor::construct):
(WebCore::toJSNewlyCreated):
(WebCore::toJS):
(WebCore::JSTestNamedConstructor::toWrapped): Deleted.
- bindings/scripts/test/JS/JSTestNamedConstructor.h:
(WebCore::toJS):
(WebCore::toJSNewlyCreated):
- bindings/scripts/test/JS/JSTestNode.cpp:
(WebCore::JSTestNodeConstructor::construct):
- bindings/scripts/test/JS/JSTestNondeterministic.cpp:
(WebCore::toJSNewlyCreated):
(WebCore::toJS):
(WebCore::JSTestNondeterministic::toWrapped): Deleted.
- bindings/scripts/test/JS/JSTestNondeterministic.h:
(WebCore::toJS):
(WebCore::toJSNewlyCreated):
- bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::JSTestObjConstructor::construct):
(WebCore::jsTestObjReadOnlyTestObjAttr):
(WebCore::jsTestObjTestObjAttr):
(WebCore::jsTestObjTestNullableObjAttr):
(WebCore::jsTestObjLenientTestObjAttr):
(WebCore::jsTestObjXMLObjAttr):
(WebCore::jsTestObjTypedArrayAttr):
(WebCore::jsTestObjStrictTypeCheckingAttribute):
(WebCore::jsTestObjWithScriptExecutionContextAttribute):
(WebCore::jsTestObjWithScriptStateAttributeRaises):
(WebCore::jsTestObjWithScriptExecutionContextAttributeRaises):
(WebCore::jsTestObjWithScriptExecutionContextAndScriptStateAttribute):
(WebCore::jsTestObjWithScriptExecutionContextAndScriptStateAttributeRaises):
(WebCore::jsTestObjWithScriptExecutionContextAndScriptStateWithSpacesAttribute):
(WebCore::jsTestObjWithScriptArgumentsAndCallStackAttribute):
(WebCore::jsTestObjContentDocument):
(WebCore::jsTestObjMutablePoint):
(WebCore::jsTestObjImmutablePoint):
(WebCore::jsTestObjPutForwardsAttribute):
(WebCore::jsTestObjPutForwardsNullableAttribute):
(WebCore::jsTestObjPrototypeFunctionObjMethod):
(WebCore::jsTestObjPrototypeFunctionObjMethodWithArgs):
(WebCore::jsTestObjPrototypeFunctionMethodThatRequiresAllArgsAndThrows):
(WebCore::jsTestObjPrototypeFunctionWithScriptStateObj):
(WebCore::jsTestObjPrototypeFunctionWithScriptStateObjException):
(WebCore::jsTestObjPrototypeFunctionWithScriptExecutionContextAndScriptStateObjException):
(WebCore::jsTestObjPrototypeFunctionWithScriptExecutionContextAndScriptStateWithSpaces):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod):
(WebCore::jsTestObjPrototypeFunctionDomStringListFunction):
(WebCore::jsTestObjPrototypeFunctionGetElementById):
(WebCore::jsTestObjPrototypeFunctionGetSVGDocument):
(WebCore::jsTestObjPrototypeFunctionMutablePointFunction):
(WebCore::jsTestObjPrototypeFunctionImmutablePointFunction):
(WebCore::toJSNewlyCreated):
(WebCore::toJS):
(WebCore::JSTestObj::toWrapped): Deleted.
- bindings/scripts/test/JS/JSTestObj.h:
(WebCore::toJS):
(WebCore::toJSNewlyCreated):
- bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp:
(WebCore::constructJSTestOverloadedConstructors1):
(WebCore::constructJSTestOverloadedConstructors2):
(WebCore::constructJSTestOverloadedConstructors3):
(WebCore::constructJSTestOverloadedConstructors4):
(WebCore::constructJSTestOverloadedConstructors5):
(WebCore::toJSNewlyCreated):
(WebCore::toJS):
(WebCore::JSTestOverloadedConstructors::toWrapped): Deleted.
- bindings/scripts/test/JS/JSTestOverloadedConstructors.h:
(WebCore::toJS):
(WebCore::toJSNewlyCreated):
- bindings/scripts/test/JS/JSTestOverrideBuiltins.cpp:
(WebCore::jsTestOverrideBuiltinsPrototypeFunctionNamedItem):
(WebCore::toJSNewlyCreated):
(WebCore::toJS):
(WebCore::JSTestOverrideBuiltins::toWrapped): Deleted.
- bindings/scripts/test/JS/JSTestOverrideBuiltins.h:
(WebCore::toJS):
(WebCore::toJSNewlyCreated):
- bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:
(WebCore::toJSNewlyCreated):
(WebCore::toJS):
(WebCore::JSTestSerializedScriptValueInterface::toWrapped): Deleted.
- bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.h:
(WebCore::toJS):
(WebCore::toJSNewlyCreated):
- bindings/scripts/test/JS/JSTestTypedefs.cpp:
(WebCore::JSTestTypedefsConstructor::construct):
(WebCore::jsTestTypedefsPrototypeFunctionImmutablePointFunction):
(WebCore::toJSNewlyCreated):
(WebCore::toJS):
(WebCore::JSTestTypedefs::toWrapped): Deleted.
- bindings/scripts/test/JS/JSTestTypedefs.h:
(WebCore::toJS):
(WebCore::toJSNewlyCreated):
- bindings/scripts/test/JS/JSattribute.cpp:
(WebCore::toJSNewlyCreated):
(WebCore::toJS):
(WebCore::JSattribute::toWrapped): Deleted.
- bindings/scripts/test/JS/JSattribute.h:
(WebCore::toJS):
(WebCore::toJSNewlyCreated):
- bindings/scripts/test/JS/JSreadonly.cpp:
(WebCore::toJSNewlyCreated):
(WebCore::toJS):
(WebCore::JSreadonly::toWrapped): Deleted.
- bindings/scripts/test/JS/JSreadonly.h:
(WebCore::toJS):
(WebCore::toJSNewlyCreated):
- html/HTMLMediaElement.cpp:
(WebCore::controllerJSValue):
(WebCore::HTMLMediaElement::didAddUserAgentShadowRoot):
- 8:47 AM Changeset in webkit [200774] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Windows Perl fails to run copy-user-interface-resources.pl
https://bugs.webkit.org/show_bug.cgi?id=157620
<rdar://problem/26241548>
Patch by Fujii Hironori <Fujii Hironori> on 2016-05-12
Reviewed by Timothy Hatcher.
There are two problems on Windows platform. 'cat' command is
missing and can not execute shebang.
- Scripts/copy-user-interface-resources.pl: Invoke Perl scripts
with explicitly specifying Perl command instead of relying on
shebang. Add a new subroutine 'appendFile' to concatenate files
instread of 'cat' command.
- 8:43 AM Changeset in webkit [200773] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: 3.8% of timeline recording spent in NavigationSidebarPanel _updateContentOverflowShadowVisibility for background tab
https://bugs.webkit.org/show_bug.cgi?id=157616
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-05-12
Reviewed by Timothy Hatcher.
- UserInterface/Views/NavigationSidebarPanel.js:
(WebInspector.NavigationSidebarPanel.prototype._updateContentOverflowShadowVisibility):
(WebInspector.NavigationSidebarPanel.prototype._treeElementAddedOrChanged):
Don't update or schedule and update if we aren't visible.
When we are shown we will force an update.
- 8:42 AM Changeset in webkit [200772] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Reduce rAF churn in DefaultDashboardView on pages with lots of resources
https://bugs.webkit.org/show_bug.cgi?id=157618
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-05-12
Reviewed by Timothy Hatcher.
- UserInterface/Views/DefaultDashboardView.js:
(WebInspector.DefaultDashboardView):
(WebInspector.DefaultDashboardView.prototype._updateDisplaySoon):
(WebInspector.DefaultDashboardView.prototype._updateDisplay):
Previously we were scheduling multiple rAFs that would all fire with
the same data, each time a resource was added. Coalesce into one.
- 8:25 AM Changeset in webkit [200771] by
-
- 3 edits in branches/safari-601.1.46-branch/Source/WebCore
Merged r200466. rdar://problem/26228860
- 7:48 AM Changeset in webkit [200770] by
-
- 14 edits in trunk/Source
Use reference instead of pointer in FrameLoaderClient::saveViewStateToItem.
https://bugs.webkit.org/show_bug.cgi?id=157624
Reviewed by Darin Adler.
Source/WebCore:
No new tests needed.
- loader/EmptyClients.h:
- loader/FrameLoaderClient.h:
- loader/HistoryController.cpp:
(WebCore::HistoryController::saveScrollPositionAndViewStateToItem):
Source/WebKit/mac:
- WebCoreSupport/WebFrameLoaderClient.h:
- WebCoreSupport/WebFrameLoaderClient.mm:
(WebFrameLoaderClient::saveViewStateToItem):
- WebView/WebFrame.mm:
(-[WebFrame _saveViewState]):
Source/WebKit/win:
- WebCoreSupport/WebFrameLoaderClient.cpp:
(WebFrameLoaderClient::saveViewStateToItem):
- WebCoreSupport/WebFrameLoaderClient.h:
Source/WebKit2:
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::saveViewStateToItem):
- WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
- 5:47 AM Changeset in webkit [200769] by
-
- 12 edits4 adds in trunk
Correctly handle prefixed and unprefixed variants in CSSStyleDeclaration
https://bugs.webkit.org/show_bug.cgi?id=157569
<rdar://problem/26223115>
Patch by Antoine Quint <Antoine Quint> on 2016-05-12
Reviewed by Dean Jackson.
Source/WebCore:
Tests: fast/css/prefixed-unprefixed-variant-style-declaration.html
fast/css/shorthand-omitted-initial-value-overrides-shorthand.html
We essentially revert the code added with https://bugs.webkit.org/show_bug.cgi?id=110011
which duplicated properties that had a prefixed or unprefixed variant. What we do now is
to return the value of the prefixed or unprefixed variant through a CSSStyleDeclaration,
but only return the properties specified by the author when reading from thecssTextproperty.
- css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseTransitionShorthand):
(WebCore::CSSParser::addPropertyWithPrefixingVariant): Deleted.
- css/CSSParser.h:
Remove all code adding duplicated properties for the prefixed or unprefixed
variant of properties that exist in both forms.
- css/CSSPropertyNames.in:
Treat transition properties as we do animation properties.
- css/PropertySetCSSStyleDeclaration.cpp:
(WebCore::PropertySetCSSStyleDeclaration::getPropertyCSSValue):
(WebCore::PropertySetCSSStyleDeclaration::getPropertyValue):
Make these two methods call into the matching getXXXInternal() variant instead
of going through the property set directly so that they would correctly pick up
on the prefixed or unprefixed variant should there be one when the specified property
is not specified directly.
(WebCore::PropertySetCSSStyleDeclaration::getPropertyCSSValueInternal):
(WebCore::PropertySetCSSStyleDeclaration::getPropertyValueInternal):
We used to simply return the value for the given property from the property set, which
we still do but now also check if there is prefixed or unprefixed variant for the provided
property in case it was absent.
- css/StyleProperties.cpp:
(WebCore::MutableStyleProperties::removeShorthandProperty):
Remove all code adding duplicated properties for the prefixed or unprefixed
variant of properties that exist in both forms.
(WebCore::StyleProperties::asText):
Drive-by fix to also handle the animation-play-state and -webkit-animation-play-state properties
when serializing to the shorthand.
(WebCore::MutableStyleProperties::removeProperty): Deleted.
(WebCore::MutableStyleProperties::removePrefixedOrUnprefixedProperty): Deleted.
(WebCore::MutableStyleProperties::setProperty): Deleted.
(WebCore::getIndexInShorthandVectorForPrefixingVariant): Deleted.
(WebCore::MutableStyleProperties::appendPrefixingVariantProperty): Deleted.
(WebCore::MutableStyleProperties::setPrefixingVariantProperty): Deleted.
- css/StyleProperties.h:
Remove all code adding duplicated properties for the prefixed or unprefixed
variant of properties that exist in both forms.
LayoutTests:
- animations/fill-mode-forwards-zero-duration.html:
- animations/play-state-start-paused.html:
These two tests incorrectly expected a shorthand property not to reset
longhand properties that it covers to their initial values even if left
out of the shorthand.
- animations/unprefixed-properties-expected.txt:
- animations/unprefixed-properties.html:
This test incorrectly expected that setting an unprefixed property only would
lead to reading the prefixed property through the CSSOM return the empty string,
rather than the value set on the unprefixed property.
- fast/css/prefixed-unprefixed-variant-style-declaration-expected.txt: Added.
- fast/css/prefixed-unprefixed-variant-style-declaration.html: Added.
New test checking that setting one of two of a property's unprefixed and prefixed
variants correctly allows to read the style through the CSS OM for both variants,
while only serializing the property that was set through cssText.
- fast/css/shorthand-omitted-initial-value-overrides-shorthand-expected.txt: Added.
- fast/css/shorthand-omitted-initial-value-overrides-shorthand.html: Added.
New test checking that setting a longhand property and then the shorthand for that
longhand correctly resets the initial values, even if they were omitted in the shorthand.
- 5:26 AM Changeset in webkit [200768] by
-
- 19 edits in trunk/Source/WebCore
Unreviewed, rolling out r200766.
https://bugs.webkit.org/show_bug.cgi?id=157623
it is breaking yosemite builds (Requested by youenn on
#webkit).
Reverted changeset:
"DOMPromise should only restrict the resolution type"
https://bugs.webkit.org/show_bug.cgi?id=157307
http://trac.webkit.org/changeset/200766
- 3:34 AM Changeset in webkit [200767] by
-
- 7 edits1 add in trunk/Source/WebInspectorUI
Web Inspector: Improve snapshot selection in heap allocations overview graph
https://bugs.webkit.org/show_bug.cgi?id=157588
<rdar://problem/26231245>
Reviewed by Joseph Pecoraro.
Heap snapshot icon selection now uses the built-in record selection
behavior provided by TimelineOverview/TimelineOverviewGraph. The marker
representing the selected heap snapshot now has a "selected" style, and
clicking an icon when the HeapAllocationsTimeline is not selected causes
the timeline to become selected.
- UserInterface/Images/HeapSnapshotSelected.svg: Added.
New art for selected snapshot icon.
- UserInterface/Views/HeapAllocationsTimelineOverviewGraph.css:
(.timeline-overview-graph.heap-allocations > img.snapshot.selected):
(.timeline-overview-graph.heap-allocations:not(.selected) > img.snapshot.selected):
Selected icon styles for selected/unselected overview graph.
- UserInterface/Views/HeapAllocationsTimelineOverviewGraph.js:
(WebInspector.HeapAllocationsTimelineOverviewGraph):
Track selected image element.
(WebInspector.HeapAllocationsTimelineOverviewGraph.prototype.layout):
Associate image elements with their snapshot record, and reuse image
elements between layouts. Image element click handler can just set the
selectedRecord in the TimelineOverviewGraph base class.
(WebInspector.HeapAllocationsTimelineOverviewGraph.prototype.updateSelectedRecord):
(WebInspector.HeapAllocationsTimelineOverviewGraph.prototype._updateSnapshotMarkers):
Refresh snapshot icon styles when selected record changes.
- UserInterface/Views/HeapAllocationsTimelineView.js:
(WebInspector.HeapAllocationsTimelineView.prototype.selectRecord):
Show snapshot list if no record selected.
(WebInspector.HeapAllocationsTimelineView.prototype.userSelectedRecordFromOverview): Deleted.
No longer needed.
- UserInterface/Views/RenderingFrameTimelineOverviewGraph.js:
(WebInspector.RenderingFrameTimelineOverviewGraph.prototype._updateFrameMarker):
No need to call dispatchSelectedRecordChangedEvent manually anymore,
method has been removed from base class.
- UserInterface/Views/TimelineOverviewGraph.js:
(WebInspector.TimelineOverviewGraph.prototype._needsSelectedRecordLayout):
(WebInspector.TimelineOverviewGraph):
(WebInspector.TimelineOverviewGraph.prototype.dispatchSelectedRecordChangedEvent): Deleted.
No longer needed. Event dispatched automatically by the rAF callback.
- UserInterface/Views/TimelineRecordingContentView.js:
(WebInspector.TimelineRecordingContentView.prototype._recordSelected):
Allow switching to another timeline, if the selected record does not
belong to the current timeline.
- 2:36 AM Changeset in webkit [200766] by
-
- 19 edits in trunk/Source/WebCore
DOMPromise should only restrict the resolution type
https://bugs.webkit.org/show_bug.cgi?id=157307
Reviewed by Darin Adler.
Removing from DOMPromise the rejection template parameter.
Supported rejection types are integers (Exception codes) and DOM objects (DOMError typically).
Updated toJS and DeferredWrapper to accept Ref<>&& and RefPtr<>&&.
Previously Ref<>&& were not accepted and only "const RefPtr<>&" was accepted.
This in turn created an unecessary churn count when calling toJS.
Changes also allow in most cases to remove the need for explictly declaring the
rejection/resolution type.
Minor refactoring of FontFaceSet promise handling to use DOMPromise in lieu of DeferredWrapper.
Covered by existing tests.
Changes should not be visible from user scripts.
- Modules/fetch/FetchBody.cpp:
(WebCore::FetchBody::consume):
(WebCore::FetchBody::consumeText):
(WebCore::blobFromArrayBuffer):
(WebCore::FetchBody::loadingFailed):
- Modules/fetch/FetchBody.h:
(WebCore::FetchBody::formData):
- Modules/fetch/FetchBodyOwner.cpp:
(WebCore::FetchBodyOwner::arrayBuffer):
(WebCore::FetchBodyOwner::blob):
(WebCore::FetchBodyOwner::formData):
(WebCore::FetchBodyOwner::json):
(WebCore::FetchBodyOwner::text):
- Modules/fetch/FetchResponse.cpp:
(WebCore::FetchResponse::BodyLoader::didReceiveResponse):
- Modules/fetch/FetchResponse.h:
- Modules/mediastream/MediaDevices.h:
- Modules/mediastream/PeerConnectionBackend.h:
- Modules/mediastream/UserMediaRequest.cpp:
(WebCore::UserMediaRequest::didCreateStream):
- Modules/streams/ReadableStreamSource.h:
- Modules/webaudio/AudioContext.h:
- bindings/js/JSDOMBinding.h:
(WebCore::toJS):
(WebCore::jsPair):
- bindings/js/JSDOMPromise.cpp:
(WebCore::fulfillPromiseWithJSON):
- bindings/js/JSDOMPromise.h:
(WebCore::TypeInspector::decltype):
(WebCore::TypeInspector::testIsVector):
(WebCore::TypeInspector::testIsRefOrRefPtr):
(WebCore::DeferredWrapper::resolve):
(WebCore::DeferredWrapper::reject):
(WebCore::DOMPromise::resolve):
(WebCore::DOMPromise::reject):
(WebCore::DeferredWrapper::resolveWithValue):
(WebCore::DeferredWrapper::rejectWithValue):
(WebCore::callPromiseFunction):
- bindings/js/JSSubtleCryptoCustom.cpp:
(WebCore::JSSubtleCrypto::importKey):
(WebCore::JSSubtleCrypto::unwrapKey):
- css/FontFace.h:
- css/FontFaceSet.cpp:
(WebCore::FontFaceSet::PendingPromise::PendingPromise):
(WebCore::FontFaceSet::load):
(WebCore::FontFaceSet::registerReady):
- css/FontFaceSet.h:
- html/HTMLMediaElement.h:
- 2:28 AM Changeset in webkit [200765] by
-
- 10 edits in branches/safari-601.1.46-branch/Source/WebCore
Merge r199351. rdar://problem/26228860
- 2:12 AM Changeset in webkit [200764] by
-
- 1 edit3 deletes in branches/safari-601.1.46-branch/LayoutTests
Merge r200378. rdar://problem/26064990
- 2:12 AM Changeset in webkit [200763] by
-
- 3 edits9 adds in branches/safari-601.1.46-branch
Merge r200375. rdar://problem/26064990
- 2:12 AM Changeset in webkit [200762] by
-
- 2 edits in branches/safari-601.1.46-branch/Source/WebCore
Merge r200091. rdar://problem/26228870
- 2:12 AM Changeset in webkit [200761] by
-
- 2 edits1 add in branches/safari-601.1.46-branch/Source/JavaScriptCore
Merge r199277. rdar://problem/26228815
- 2:12 AM Changeset in webkit [200760] by
-
- 2 edits in branches/safari-601.1.46-branch/Source/WebCore
Merge r199243. rdar://problem/26228921
- 2:12 AM Changeset in webkit [200759] by
-
- 4 edits2 adds in branches/safari-601.1.46-branch
Merge r199101. rdar://problem/26228884
- 2:12 AM Changeset in webkit [200758] by
-
- 5 edits in branches/safari-601.1.46-branch
Merge r198780. rdar://problem/26228892
- 2:12 AM Changeset in webkit [200757] by
-
- 6 edits in branches/safari-601.1.46-branch/Source/WebCore
Merge r198701. rdar://problem/26228887
- 2:12 AM Changeset in webkit [200756] by
-
- 5 edits in branches/safari-601.1.46-branch/Source
Merge r198143. rdar://problem/26228904
- 2:12 AM Changeset in webkit [200755] by
-
- 12 edits in trunk
[css-grid] Incorrect parsing when using just 'span" as grid-line value
https://bugs.webkit.org/show_bug.cgi?id=157615
Reviewed by Sergio Villar Senin.
Source/WebCore:
The spec is pretty clear about this:
https://drafts.csswg.org/css-grid/#typedef-grid-row-start-grid-line
The possible options when using "span" to reference a grid line are:
[ span && [ <integer> <custom-ident> ] ] Thus, "span" keyword alone produces an invalid declaration.
- css/CSSParser.cpp:
(WebCore::CSSParser::parseGridPosition):
LayoutTests:
Add new test case in grid-item-column-row-get-set.html.
Updated other tests that were using "span" alone, with 2 approaches:
- In some of them changing "span" by "span 1" making it valid.
- In other changing the expected result to "auto", as it's invalid now.
- fast/css-grid-layout/grid-item-area-get-set.html:
- fast/css-grid-layout/grid-item-bad-named-area-auto-placement.html:
- fast/css-grid-layout/grid-item-column-row-get-set-expected.txt:
- fast/css-grid-layout/grid-item-column-row-get-set.html:
- fast/css-grid-layout/grid-item-end-after-get-set-expected.txt:
- fast/css-grid-layout/grid-item-end-after-get-set.html:
- fast/css-grid-layout/grid-item-negative-position-resolution.html:
- fast/css-grid-layout/grid-item-start-before-get-set-expected.txt:
- fast/css-grid-layout/grid-item-start-before-get-set.html:
- 2:12 AM Changeset in webkit [200754] by
-
- 3 edits3 adds in branches/safari-601.1.46-branch
Merge r198050. rdar://problem/26228899
- 2:12 AM Changeset in webkit [200753] by
-
- 3 edits in branches/safari-601.1.46-branch/Source/JavaScriptCore
Merge r196524. rdar://problem/26228854
- 2:12 AM Changeset in webkit [200752] by
-
- 3 edits4 adds in branches/safari-601.1.46-branch
Merge r195724. rdar://problem/26228915
- 2:12 AM Changeset in webkit [200751] by
-
- 8 edits in branches/safari-601.1.46-branch/Source/WebCore
Merge r195004. rdar://problem/26228875
- 2:11 AM Changeset in webkit [200750] by
-
- 3 edits2 adds in branches/safari-601.1.46-branch
Merge r194399. rdar://problem/26228911
- 2:11 AM Changeset in webkit [200749] by
-
- 3 edits in branches/safari-601.1.46-branch/Source/WebCore
Merge r194290. rdar://problem/26228866
- 2:11 AM Changeset in webkit [200748] by
-
- 3 edits2 adds in branches/safari-601.1.46-branch
Merge r190820. rdar://problem/26228881
- 2:03 AM Changeset in webkit [200747] by
-
- 16 edits in trunk
Remove ENABLE(ES6_ARROWFUNCTION_SYNTAX) guards
https://bugs.webkit.org/show_bug.cgi?id=157564
Reviewed by Darin Adler.
.:
- Source/cmake/WebKitFeatures.cmake:
Source/JavaScriptCore:
- Configurations/FeatureDefines.xcconfig:
- parser/Parser.cpp:
Source/WebCore:
- Configurations/FeatureDefines.xcconfig:
Source/WebKit/mac:
- Configurations/FeatureDefines.xcconfig:
Source/WebKit2:
- Configurations/FeatureDefines.xcconfig:
Source/WTF:
- wtf/FeatureDefines.h:
Tools:
- Scripts/webkitperl/FeatureList.pm:
- TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
- 12:28 AM Changeset in webkit [200746] by
-
- 5 edits in trunk
Web Inspector: CRASH getting internal properties of function with no bound arguments causes
https://bugs.webkit.org/show_bug.cgi?id=157613
<rdar://problem/26238754>
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-05-12
Reviewed by Timothy Hatcher.
Source/JavaScriptCore:
- inspector/JSInjectedScriptHost.cpp:
(Inspector::JSInjectedScriptHost::getInternalProperties):
Gracefully handle a JSBoundFunction with no bound arguments.
In this case boundArgs is JSValue() which we don't want to
expose as the value of the internal property.
LayoutTests:
- inspector/runtime/getProperties-expected.txt:
- inspector/runtime/getProperties.html:
Include coverage for a bound function with no bound arguments.
- 12:23 AM Changeset in webkit [200745] by
-
- 4 edits in trunk/Source/WebInspectorUI
Web Inspector: 3.5% of time in toFixed in TimelineRecordBar updating element positions
https://bugs.webkit.org/show_bug.cgi?id=157608
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-05-12
Reviewed by Timothy Hatcher.
Avoid using toFixed to do an approximation comparison of two floating point numbers.
Instead keep in Numbers by just doing the approximation with Math.round(num * 100).
Since toFixed was doing stringification it was very expensive.
- UserInterface/Views/TimelineRecordBar.js:
(WebInspector.TimelineRecordBar.prototype._updateElementPosition):
(WebInspector.TimelineRecordBar):
- UserInterface/Views/TimelineRecordFrame.js:
(WebInspector.TimelineRecordFrame.prototype._updateElementPosition):
(WebInspector.TimelineRecordFrame):
- UserInterface/Views/TimelineRuler.js:
(WebInspector.TimelineRuler.prototype._updatePositionOfElement):
May 11, 2016:
- 11:47 PM Changeset in webkit [200744] by
-
- 4 edits1 delete in trunk/Source/WebCore
TextIteratorStopsOnFormControls is never used
https://bugs.webkit.org/show_bug.cgi?id=157609
Reviewed by Alex Christensen.
Removed SurroundingText.cpp and TextIteratorStopsOnFormControls from TextIterator as they're no longer used.
- editing/SurroundingText.cpp: Removed.
- editing/TextIterator.cpp:
(WebCore::TextIterator::advance):
(WebCore::TextIterator::exitNode):
(WebCore::SimplifiedBackwardsTextIterator::SimplifiedBackwardsTextIterator):
(WebCore::SimplifiedBackwardsTextIterator::advance):
(WebCore::characterSubrange):
(WebCore::BackwardsCharacterIterator::BackwardsCharacterIterator):
- editing/TextIterator.h:
(WebCore::SimplifiedBackwardsTextIterator::atEnd):
- editing/TextIteratorBehavior.h:
- 11:34 PM Changeset in webkit [200743] by
-
- 2 edits in trunk/Source/JavaScriptCore
[JSC] Make sure StringRange is passed to Vector by register
https://bugs.webkit.org/show_bug.cgi?id=157603
Patch by Benjamin Poulain <bpoulain@apple.com> on 2016-05-11
Reviewed by Darin Adler.
This is bizarre, but on my SDK, Vector::append(StringRange)
is passing the values on the stack.
The two integers are written to the stack, the address given
to append(), then append() reads it back and store it.
This patch changes the code to use constructAndAppend(), ensuring
the values are used directly.
On my machine, this helps Sunspider and Octane.
This might be something wrong with my SDK but the fix is so easy
that we might as well do this.
- runtime/StringPrototype.cpp:
(JSC::removeUsingRegExpSearch):
(JSC::replaceUsingRegExpSearch):
- 11:23 PM Changeset in webkit [200742] by
-
- 2 edits in trunk/Source/JavaScriptCore
ARMv7Assembler: suppress a -Wnarrowing warning when compiling with GCC
https://bugs.webkit.org/show_bug.cgi?id=157576
Patch by Zan Dobersek <zdobersek@igalia.com> on 2016-05-11
Reviewed by Csaba Osztrogonác.
- assembler/ARMv7Assembler.h:
(JSC::ARMv7Assembler::revertJumpTo_movT3movtcmpT2): Explicitly cast the
OP_CMP_reg_T2 | leftvalue to uint16_t, avoiding a narrowing conversion
warning that's being reported when compiling with GCC. The warning is sprung
due to RegisterID (which is the type ofleft) being an enum based on int,
even when the enum itself only declares 23 values.
- 9:35 PM Changeset in webkit [200741] by
-
- 3 edits in trunk/Source/WebCore
Kill Node::ancestorElement()
https://bugs.webkit.org/show_bug.cgi?id=157599
Reviewed by Darin Adler.
Kill Node::ancestorElement() and use Node::parentElement() instead. If
our parent is not an Element then none of our ancestors will be.
- dom/Node.cpp:
(WebCore::Node::isDefaultNamespace):
(WebCore::Node::lookupPrefix):
(WebCore::Node::lookupNamespaceURI):
(WebCore::Node::lookupNamespacePrefix):
(WebCore::Node::convertToPage):
(WebCore::Node::convertFromPage):
(WebCore::Node::ancestorElement): Deleted.
- dom/Node.h:
- 9:32 PM Changeset in webkit [200740] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: 4% of time in TimelineOverviewGraph adding/removing classList styles on TimelineRecordBar
https://bugs.webkit.org/show_bug.cgi?id=157607
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-05-11
Reviewed by Brian Burg.
This gets us down to about 0.5% of time.
- UserInterface/Views/TimelineRecordBar.js:
(WebInspector.TimelineRecordBar.prototype.set records):
Only modify the classLists when the record changes.
(WebInspector.TimelineRecordBar.prototype.refresh):
Set unfinished once for either the uses active or not uses active cases.
- 8:17 PM Changeset in webkit [200739] by
-
- 1 edit1 delete in branches/safari-601-branch/LayoutTests
- 7:56 PM Changeset in webkit [200738] by
-
- 6 edits in branches/safari-601-branch/Source/WebCore
Merge r198701. rdar://problem/26228577
- 7:13 PM Changeset in webkit [200737] by
-
- 2 edits in trunk/Source/JavaScriptCore
Web Inspector:
thisin Scope Chain Sidebar does not have preview, looks poor
https://bugs.webkit.org/show_bug.cgi?id=157602
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-05-11
Reviewed by Timothy Hatcher.
- inspector/InjectedScriptSource.js:
(InjectedScript.CallFrameProxy):
Include a preview when creating the RemoteObject forthis.
- 7:09 PM Changeset in webkit [200736] by
-
- 4 edits2 adds in trunk
Absolute positioned element is not placed properly when parent becomes the containing block.
https://bugs.webkit.org/show_bug.cgi?id=157455
<rdar://problem/26212568>
Reviewed by Simon Fraser.
When a container becomes a containing block, we need to check if there are any positioned boxes in its subtree
in order to "re-parent" them. It basically means that we remove them from RenderBlock::positionedDescendants map
and they'll get re-inserted during the next layout correctly.
This patch fixes the case when a container becomes the containing block by setting the transform property and its positioned
child gets misplaced.
Source/WebCore:
Test: fast/block/containing-block-changes.html
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::removePositionedObjectsIfNeeded):
(WebCore::RenderBlock::styleWillChange):
- rendering/RenderBlock.h:
LayoutTests:
- fast/block/containing-block-changes-expected.html: Added.
- fast/block/containing-block-changes.html: Added.
- 6:32 PM Changeset in webkit [200735] by
-
- 5 edits in branches/safari-601-branch/Source
Merge r198143. rdar://problem/26228593
- 6:32 PM Changeset in webkit [200734] by
-
- 2 edits1 add in branches/safari-601-branch/Source/JavaScriptCore
Merge r199277. rdar://problem/26228546
- 6:32 PM Changeset in webkit [200733] by
-
- 2 edits in branches/safari-601-branch/Source/WebCore
Merge r199243. rdar://problem/26228520
- 6:31 PM Changeset in webkit [200732] by
-
- 4 edits2 adds in branches/safari-601-branch
Merge r199101. rdar://problem/26228570
- 6:31 PM Changeset in webkit [200731] by
-
- 5 edits in branches/safari-601-branch
Merge r198780. rdar://problem/26228583
- 6:31 PM Changeset in webkit [200730] by
-
- 3 edits3 adds in branches/safari-601-branch
Merge r198050. rdar://problem/26228588
- 6:31 PM Changeset in webkit [200729] by
-
- 3 edits in branches/safari-601-branch/Source/JavaScriptCore
Merge r196524. rdar://problem/26228552
- 6:31 PM Changeset in webkit [200728] by
-
- 3 edits4 adds in branches/safari-601-branch
Merge r195724. rdar://problem/26228611
- 6:31 PM Changeset in webkit [200727] by
-
- 3 edits2 adds in branches/safari-601-branch
Merge r194399. rdar://problem/26228601
- 6:31 PM Changeset in webkit [200726] by
-
- 3 edits2 adds in branches/safari-601-branch
Merge r190820. rdar://problem/26228566
- 6:31 PM Changeset in webkit [200725] by
-
- 2 edits in branches/safari-601-branch/Source/WebCore
Merge r200091. rdar://problem/26228555
- 6:31 PM Changeset in webkit [200724] by
-
- 3 edits in branches/safari-601-branch/Source/WebCore
Merge r194290. rdar://problem/26053735
- 6:31 PM Changeset in webkit [200723] by
-
- 1 edit3 deletes in branches/safari-601-branch/LayoutTests
Merge r200378. rdar://problem/26066673
- 6:31 PM Changeset in webkit [200722] by
-
- 3 edits9 adds in branches/safari-601-branch
Merge r200375. rdar://problem/26066673
- 6:31 PM Changeset in webkit [200721] by
-
- 1 edit1 add in branches/safari-601-branch/LayoutTests
Merge r200376. rdar://problem/25991928
- 6:04 PM Changeset in webkit [200720] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Unexpected unread notification icon next to Log after clearing via clear()
https://bugs.webkit.org/show_bug.cgi?id=157598
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-05-11
Reviewed by Timothy Hatcher.
We always show ConsoleCommand and ConsoleCommandResult messages no matter
what the filter is. So it doesn't make sense to mark the "log" filter
as having an unread notification for a ConsoleCommandResult when we can
see the result.
- UserInterface/Views/LogContentView.js:
(WebInspector.LogContentView.prototype.didAppendConsoleMessageView):
(WebInspector.LogContentView.prototype._markScopeBarItemUnread):
- 5:49 PM Changeset in webkit [200719] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Console unread indicators should be cleared however the console clears
https://bugs.webkit.org/show_bug.cgi?id=157594
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-05-11
Reviewed by Timothy Hatcher.
- UserInterface/Views/LogContentView.js:
(WebInspector.LogContentView.prototype._logCleared):
(WebInspector.LogContentView.prototype._clearLog):
Move code that clears unread indicators from clearLog to logCleared
to handle all possible clear cases.
- 5:47 PM Changeset in webkit [200718] by
-
- 3 edits in trunk/Source/WebInspectorUI
Web Inspector: Contents of Duration column are covered by always on (legacy) scroll bars
https://bugs.webkit.org/show_bug.cgi?id=157590
Reviewed by Timothy Hatcher.
- UserInterface/Views/DataGrid.css:
(.data-grid .data-container):
Always show vertical scrollbars.
(.data-grid > .header-wrapper):
(.data-grid > .header-wrapper::-webkit-scrollbar):
Show invisible scrollbar for DataGrid's header to align the header table with the content.
(.data-grid.no-header > .header-wrapper > table.header):
(.data-grid.no-header > table.header): Deleted.
(.data-grid th): Deleted.
- UserInterface/Views/DataGrid.js:
(WebInspector.DataGrid):
overflow-y: scrolldoesn't work on a table element. Wrap table in a div.
- 5:31 PM Changeset in webkit [200717] by
-
- 4 edits in trunk/Source/WebCore
Unreviewed, rolling out r200700, r200703, and r200713.
https://bugs.webkit.org/show_bug.cgi?id=157601
Broke iOS builds (Requested by rniwa on #webkit).
Reverted changesets:
"Touch.prototype is undefined on iOS"
https://bugs.webkit.org/show_bug.cgi?id=157560
http://trac.webkit.org/changeset/200700
"iOS build fix attempt after r200700."
http://trac.webkit.org/changeset/200703
"iOS clean build fix after r200700."
http://trac.webkit.org/changeset/200713
Patch by Commit Queue <commit-queue@webkit.org> on 2016-05-11
- 5:01 PM Changeset in webkit [200716] by
-
- 3 edits in trunk/Source/WebInspectorUI
Web Inspector: Make it possible to do special styling on selected TimelineOverviewGraphs
https://bugs.webkit.org/show_bug.cgi?id=157593
<rdar://problem/26232886>
Reviewed by Timothy Hatcher.
- UserInterface/Views/TimelineOverview.js:
(WebInspector.TimelineOverview.prototype._timelinesTreeSelectionDidChange.updateGraphSelectedState):
(WebInspector.TimelineOverview.prototype._timelinesTreeSelectionDidChange):
Select the new overview graph and deselect the old one.
- UserInterface/Views/TimelineOverviewGraph.js:
(WebInspector.TimelineOverviewGraph):
(WebInspector.TimelineOverviewGraph.prototype.get selected):
(WebInspector.TimelineOverviewGraph.prototype.set selected):
New property, toggles "selected" class on the graph element.
- 4:36 PM Changeset in webkit [200715] by
-
- 2 edits in trunk/LayoutTests
Add a failing expectation on iOS for the test added in r200712
since there is no support for eventSender on iOS.
- platform/ios-simulator/TestExpectations:
- 4:25 PM Changeset in webkit [200714] by
-
- 1 edit in trunk/Source/JavaScriptCore/ChangeLog
Unreviewed, correct the title of the ChangeLog for r200667.
- 4:03 PM Changeset in webkit [200713] by
-
- 2 edits in trunk/Source/WebCore
iOS clean build fix after r200700.
- bindings/js/JSDOMWindowCustom.cpp:
- 3:42 PM Changeset in webkit [200712] by
-
- 5 edits2 adds in trunk
Moving focus by tab could erroneously focus a non-focusable shadow host
https://bugs.webkit.org/show_bug.cgi?id=157585
Reviewed by Antti Koivisto.
Source/WebCore:
The bug was caused by findFocusableElementDescendingDownIntoFrameDocument erroneously returning a shadow host
that contains a focusable element instead of traversing it through to find a focusable element within. Fixed
the bug calling findFocusableElementWithinScope which traverses shadow trees to find a focusable element unlike
findFocusableElementOrScopeOwner which returns a focusable element or a shadow host.
Also done some refactoring for clarity.
Test: fast/shadow-dom/focus-on-iframe.html
- page/FocusController.cpp:
(WebCore::FocusController::findFocusableElementDescendingDownIntoFrameDocument): See above.
(WebCore::FocusController::findFocusableElementAcrossFocusScope): Declare outerScope as late as possible.
(WebCore::nextElementWithGreaterTabIndex): Merged if conditions for clarity.
(WebCore::previousElementWithLowerTabIndex): Removed the check for isNonFocusableShadowHost since
isFocusableOrHasShadowTreeWithoutCustomFocusLogic returns true whenever isNonFocusableShadowHost returns true.
LayoutTests:
Added a regression test for moving focus across iframes.
Also expanded negative-tabindex-on-shadow-host.html to cover reverse traversal.
- fast/shadow-dom/focus-on-iframe-expected.txt: Added.
- fast/shadow-dom/focus-on-iframe.html: Added.
- fast/shadow-dom/negative-tabindex-on-shadow-host-expected.txt:
- fast/shadow-dom/negative-tabindex-on-shadow-host.html:
- 3:20 PM Changeset in webkit [200711] by
-
- 2 edits in trunk/Source/WebCore
Updating bindings tests results after r200699
Unreviewed test gardening.
- bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod):
- 3:11 PM Changeset in webkit [200710] by
-
- 2 edits in trunk/Source/JavaScriptCore
JSC test stress/reflect-set.js failing after 200694
https://bugs.webkit.org/show_bug.cgi?id=157586
Unreviewed test rebaseline.
- tests/stress/reflect-set.js:
Update the expected error message. We are in strict mode, so the
improved error message makes sense.
- 2:55 PM Changeset in webkit [200709] by
-
- 4 edits in trunk/Source/WebInspectorUI
Web Inspector: "Selected Element" is hard to read when searching for "Element"
https://bugs.webkit.org/show_bug.cgi?id=157542
<rdar://problem/26207464>
Reviewed by Timothy Hatcher.
Change the style of highlighted text to match Xcode.
- UserInterface/Views/LogContentView.css:
(.search-in-progress .console-item:not(.filtered-out-by-search).special-user-log .console-message-text .highlighted):
- UserInterface/Views/OpenResourceDialog.css:
(.open-resource-dialog > .tree-outline .item.selected .highlighted):
- UserInterface/Views/Variables.css:
(:root):
- 2:53 PM Changeset in webkit [200708] by
-
- 7 edits in trunk/Source/WebInspectorUI
Web Inspector: Hide filter bar in TimelineViews where it is not needed or not yet working
https://bugs.webkit.org/show_bug.cgi?id=157583
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-05-11
Reviewed by Timothy Hatcher.
- UserInterface/Views/HeapAllocationsTimelineView.js:
(WebInspector.HeapAllocationsTimelineView.prototype.get showsFilterBar):
(WebInspector.HeapAllocationsTimelineView.prototype.layout):
(WebInspector.HeapAllocationsTimelineView.prototype.updateFilter):
Filter bar not yet hooked up for HeapSnapshot views.
Make filtering work for the main timeline grid.
It doesn't use the normal TimelineView filter based on selected range.
This is intentional because it may be the case that a snapshot happens
outside the selected time range (via the navigation bar button) and
we want to show it. Otherwise a user might be confused why it is not
showing up in the list.
- UserInterface/Views/MemoryTimelineView.js:
(WebInspector.MemoryTimelineView.prototype.get showsFilterBar):
Filter bar not needed in the Memory timeline view.
- UserInterface/Views/ScriptClusterTimelineView.js:
(WebInspector.ScriptClusterTimelineView.prototype.get showsFilterBar):
Filter bar works for the Events timeline view.
- UserInterface/Views/ScriptProfileTimelineView.js:
(WebInspector.ScriptProfileTimelineView.prototype.get showsFilterBar):
Filter bar not yet hooked up for Profile views.
- UserInterface/Views/TimelineRecordingContentView.js:
(WebInspector.TimelineRecordingContentView.prototype._currentContentViewDidChange):
(WebInspector.TimelineRecordingContentView.prototype._contentViewSelectionPathComponentDidChange):
(WebInspector.TimelineRecordingContentView.prototype._updateFilterBar):
Update the filter bar when the selection path components change, since
that triggers when arbitrarily deep sub-content-views change.
- UserInterface/Views/TimelineView.js:
(WebInspector.TimelineView.prototype.get showsFilterBar):
Default is yes.
- 2:51 PM Changeset in webkit [200707] by
-
- 1 edit in trunk/Source/WebKit2/ChangeLog
Fix the ChangeLog.
- 2:49 PM Changeset in webkit [200706] by
-
- 2 edits in trunk/Source/WebKit2
We have two different types of contextual menus in iBooks
https://bugs.webkit.org/show_bug.cgi?id=157587
rdar://problem/25904169
Reviewed by Darin Adler.
- UIProcess/mac/WebContextMenuProxyMac.mm:
(WebKit::WebContextMenuProxyMac::showContextMenu):
- 2:41 PM Changeset in webkit [200705] by
-
- 6 edits in trunk/Source/JavaScriptCore
Beef up JSC profiler event log
https://bugs.webkit.org/show_bug.cgi?id=157584
Reviewed by Saam Barati.
Also log more about compilation.
- bytecode/ExecutionCounter.cpp: Changed the meaning of codeBlock to be the codeBlock that is doing the profiling. This will now get the baseline version if it needs it. This is needed for logging the threshold checking event.
(JSC::applyMemoryUsageHeuristics):
(JSC::ExecutionCounter<countingVariant>::hasCrossedThreshold):
- dfg/DFGJITCode.cpp: Pass the right codeBlock.
(JSC::DFG::JITCode::checkIfOptimizationThresholdReached):
(JSC::DFG::JITCode::optimizeNextInvocation):
(JSC::DFG::JITCode::dontOptimizeAnytimeSoon):
(JSC::DFG::JITCode::optimizeSoon):
(JSC::DFG::JITCode::forceOptimizationSlowPathConcurrently):
- dfg/DFGPlan.cpp: Log things about compile times and whether the compiler succeeded or failed.
(JSC::DFG::Plan::computeCompileTimes):
(JSC::DFG::Plan::reportCompileTimes):
(JSC::DFG::Plan::compileInThread):
(JSC::DFG::Plan::finalizeWithoutNotifyingCallback):
- jit/ExecutableAllocatorFixedVMPool.cpp: Make it possible to look at memory usage, though separately from the log, for now.
(JSC::ExecutableAllocator::allocate):
- runtime/Options.h:
- 2:15 PM Changeset in webkit [200704] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed attempt to fix the Windows build after r200699.
- bindings/js/JSIDBObjectStoreCustom.cpp:
- 2:07 PM Changeset in webkit [200703] by
-
- 2 edits in trunk/Source/WebCore
iOS build fix attempt after r200700.
- bindings/js/ios/TouchConstructors.cpp:
- 1:57 PM Changeset in webkit [200702] by
-
- 9 edits in trunk/Source/WebKit2
Web Automation: add command to asynchronously load the Web Inspector frontend in the background
https://bugs.webkit.org/show_bug.cgi?id=157509
Reviewed by Timothy Hatcher and Joseph Pecoraro.
In order to make it easier to debug code that executes as a result of an automation
command, this patch adds a new Automation command to asynchronously load the debugger
and Inspector frontend. It is designed for use by automation clients to implement an
auto-inspection feature to aid in debugging automation scripts.
- UIProcess/Automation/Automation.json: Add new command.
- UIProcess/Automation/WebAutomationSession.cpp:
(WebKit::WebAutomationSession::inspectBrowsingContext): Added.
(WebKit::WebAutomationSession::inspectorFrontendLoaded): Added.
This message is forwarded by WebInspectorProxy to the inspected page's session.
- UIProcess/Automation/WebAutomationSession.h:
- UIProcess/Cocoa/WebAutomationSessionCocoa.mm:
(WebKit::WebAutomationSession::sendSynthesizedEventsToPage):
Force the active automation window to become key and bring to front prior to
sending each NSEvent. This way, if the Inspector pauses while a command executes,
the automation window will get back focus when the Inspector unpauses just before
the next synthesized mouse or keyboard NSEvent is sent to its NSWindow.
- UIProcess/WebInspectorProxy.cpp:
(WebKit::WebInspectorProxy::frontendLoaded):
Forward to the inspected page's session.
- UIProcess/WebInspectorProxy.h:
- UIProcess/WebInspectorProxy.messages.in: Add notification of the frontend's load.
- WebProcess/WebPage/WebInspectorUI.cpp:
(WebKit::WebInspectorUI::frontendLoaded):
Kick off notifying the automation session in UIProcess that the inspector loaded.
(WebKit::WebInspectorUI::closeWindow):
In some circumstances, the Web Inspector can be loaded without showing
the window. If this hidden page closes, make sure the frontend host gets
a chance to disconnect its InspectorFrontendClient. Normally this happens
when the window closes, but unshown Inspectors do not get window instances.
- 1:54 PM Changeset in webkit [200701] by
-
- 9 edits in trunk/Source/JavaScriptCore
Air may decide to put the result register of an arithmetic snippet in the tag register
https://bugs.webkit.org/show_bug.cgi?id=157548
Reviewed by Filip Pizlo.
This patch adds a new ValueRep to B3 called LateRegister. The semantics
are similar to Register in that it can be used to pin an argument to
a particular register. It differs from ValueRep::Register in that the semantics of
LateRegister are that it is used after the result of the node its an argument to
is computed. This means that a LateRegister argument will interfere with the result
of a node. LateRegister is not a valid result ValueRep.
This was needed because there was a bug where B3/Air would assign the
result of a patchpoint to the TagTypeNumber register. This broke our
code when we would box a double into a JSValue in a snippet when the
result is the same as the TagTypeNumber register. To fix the issue,
we pass TagMaskRegister and TagTypeNumberRegister as ValueRep::LateRegister
arguments to various patchpoints.
- b3/B3LowerToAir.cpp:
(JSC::B3::Air::LowerToAir::fillStackmap):
- b3/B3PatchpointSpecial.cpp:
(JSC::B3::PatchpointSpecial::admitsStack):
- b3/B3StackmapSpecial.cpp:
(JSC::B3::StackmapSpecial::forEachArgImpl):
(JSC::B3::StackmapSpecial::isArgValidForRep):
- b3/B3Validate.cpp:
- b3/B3ValueRep.cpp:
(JSC::B3::ValueRep::addUsedRegistersTo):
(JSC::B3::ValueRep::dump):
(JSC::B3::ValueRep::emitRestore):
(JSC::B3::ValueRep::recoveryForJSValue):
(WTF::printInternal):
- b3/B3ValueRep.h:
(JSC::B3::ValueRep::reg):
(JSC::B3::ValueRep::lateReg):
(JSC::B3::ValueRep::stack):
(JSC::B3::ValueRep::operator==):
(JSC::B3::ValueRep::isSomeRegister):
(JSC::B3::ValueRep::isReg):
- b3/testb3.cpp:
(JSC::B3::testSpillUseLargerThanDef):
(JSC::B3::testLateRegister):
(JSC::B3::zero):
(JSC::B3::run):
- ftl/FTLLowerDFGToB3.cpp:
(JSC::FTL::DFG::LowerDFGToB3::lower):
(JSC::FTL::DFG::LowerDFGToB3::compileIn):
(JSC::FTL::DFG::LowerDFGToB3::getById):
(JSC::FTL::DFG::LowerDFGToB3::emitBinarySnippet):
(JSC::FTL::DFG::LowerDFGToB3::emitBinaryBitOpSnippet):
(JSC::FTL::DFG::LowerDFGToB3::emitRightShiftSnippet):
- 1:09 PM Changeset in webkit [200700] by
-
- 3 edits in trunk/Source/WebCore
Touch.prototype is undefined on iOS
https://bugs.webkit.org/show_bug.cgi?id=157560
<rdar://problem/26143008>
Reviewed by Chris Dumez.
Remove Touch and TouchList attributes from DOMWindow.
These attributes should be exposed via generated binding code (JSDOMWindow.cpp).
- bindings/js/JSDOMWindowCustom.cpp:
(WebCore::JSDOMWindow::touch): Deleted.
(WebCore::JSDOMWindow::touchList): Deleted.
- page/DOMWindow.idl:
- 1:04 PM Changeset in webkit [200699] by
-
- 24 edits in trunk
Change IDBObjectStore.createIndex to take an IDL dictionary
https://bugs.webkit.org/show_bug.cgi?id=157520
Reviewed by Chris Dumez.
Source/WebCore:
- Modules/indexeddb/IDBDatabase.cpp:
(WebCore::IDBDatabase::createObjectStore): Use IDBKeyPath::Type instead of
IndexedDB::KeyPathType.
- Modules/indexeddb/IDBKeyPath.cpp:
(WebCore::IDBKeyPath::IDBKeyPath): Ditto.
(WebCore::IDBKeyPath::isValid): Ditto.
(WebCore::IDBKeyPath::operator==): Ditto.
(WebCore::IDBKeyPath::encode): Ditto.
(WebCore::IDBKeyPath::decode): Ditto.
- Modules/indexeddb/IDBKeyPath.h: Use pragma once. Make constructors non-explicit so
we can just pass a string or vector and have it turn into an IDBKeyPath. Added an enum
class named Type here and use it instead of IndexedDB::KeyPathType.
- Modules/indexeddb/IDBObjectStore.cpp:
(WebCore::IDBObjectStore::openCursor): Remove unneeded local variable.
(WebCore::IDBObjectStore::get): Ditto.
(WebCore::IDBObjectStore::doDelete): Ditto.
(WebCore::IDBObjectStore::createIndex): Changed argument type to take IndexParameters
instead of two seaparate booleans. Also updated to use IDBKeyPath::Type.
- Modules/indexeddb/IDBObjectStore.h: Removed include of IndexedDB, using a forward
decalration instead. Marked the class final. Added an IndexParameters struct and used
it for the argument to createIndex.
- Modules/indexeddb/IDBObjectStore.idl: Stopped using Custom for put, add, and
createIndex functions. Stopped using Dictionary for createIndex, using IDBIndexParameters
instead as in the specification. Added IDBIndexParameters dictionary definition.
- Modules/indexeddb/IndexedDB.h: Use pragma once. Removed KeyPathType.
- bindings/js/IDBBindingUtilities.cpp:
(WebCore::injectIDBKeyIntoScriptValue): Use IDBKeyPath::Type instead of
IndexedDB::KeyPathType.
(WebCore::maybeCreateIDBKeyFromScriptValueAndKeyPath): Ditto.
(WebCore::canInjectIDBKeyIntoScriptValue): Ditto.
(WebCore::createKeyPathArray): Ditto.
(WebCore::toJS): Ditto.
- bindings/js/JSIDBObjectStoreCustom.cpp:
(WebCore::putOrAdd): Deleted.
(WebCore::JSIDBObjectStore::putFunction): Deleted.
(WebCore::JSIDBObjectStore::add): Deleted.
(WebCore::JSIDBObjectStore::createIndex): Deleted.
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateParametersCheckExpression): Fixed code that generates a type check for
wrappers to only check types is knows how to check: wrappers and arrays, including
typed arrays. This prevents it from trying to check dictionaries.
- inspector/InspectorIndexedDBAgent.cpp: Use IDBKeyPath::Type instead of
IndexedDB::KeyPathType.
LayoutTests:
- storage/indexeddb/deleteIndex-bug110792-expected.txt: Updated result.
Test is still marked as flaky, but this is the proper expectation now.
Discovered this when I accidentally reset results for the whole directory.
- storage/indexeddb/deleteIndex-bug110792-private-expected.txt: Ditto.
- storage/indexeddb/index-basics-expected.txt: Updated to expect the simpler
type error that is generated by the bindings code as opposed to the hand written
binding. If we want to make this fancier like this for all bindings we can do
that the future in the bindings script.
- storage/indexeddb/index-basics-private-expected.txt: Ditto.
- storage/indexeddb/index-basics-workers-expected.txt: Ditto.
- storage/indexeddb/keypath-basics-expected.txt: Updated for the change that
expects null and undefined the be legal key paths. See below.
- storage/indexeddb/keypath-basics-private-expected.txt: Ditto.
- storage/indexeddb/modern/create-index-failures-expected.txt: Removed
expected results that require that we forbid null for the name and key path.
See below.
- storage/indexeddb/modern/create-index-failures-private-expected.txt: Ditto.
- storage/indexeddb/modern/resources/create-index-failures.js: Removed the test
that expects failure when null is passed for the name and key path. In both
cases, the Web IDL and IDB specifications call for the null value to be converted
to the string "null", not an exception.
- storage/indexeddb/resources/keypath-basics.js:
(prepareDatabase): Added tests for both undefined and null. Both are legal values for
the key path argument to createIndex. The Web IDL and IDB specifications call for
them to be converted to the strings "undefined" and "null", not to trigger exceptions.
(testInvalidKeyPaths): Removed tests that expect exceptions when calling createIndex
with undefined and null.
- 12:59 PM Changeset in webkit [200698] by
-
- 2 edits in trunk/LayoutTests
Rebaseline inspector/dom/getAccessibilityPropertiesForNode.html after r200677
Unreviewed test gardening.
- inspector/dom/getAccessibilityPropertiesForNode-expected.txt:
- 12:58 PM Changeset in webkit [200697] by
-
- 5 edits in trunk
Modern IDB: WebWorker support.
https://bugs.webkit.org/show_bug.cgi?id=149953
Reviewed by Alex Christensen.
LayoutTests/imported/w3c:
- IndexedDB-private-browsing/idb_webworkers-expected.txt:
- web-platform-tests/IndexedDB/idb_webworkers-expected.txt:
Source/WebCore:
No new tests (Covered by changes to existing tests).
- bindings/generic/RuntimeEnabledFeatures.cpp:
(WebCore::RuntimeEnabledFeatures::RuntimeEnabledFeatures):
- 12:02 PM Changeset in webkit [200696] by
-
- 85 edits in trunk
Update Node::appendChild() / replaceChild() / removeChild() / insertBefore() to take references instead of pointers
https://bugs.webkit.org/show_bug.cgi?id=157556
Reviewed by Darin Adler.
Source/WebCore:
Update Node::appendChild() / replaceChild() / removeChild() / insertBefore()
to take references instead of pointers. Do the parameter null checks in the
bindings instead of doing it in the implementation on Node.
Also update the ContainerNode::appendChild() / replaceChild() /
insertBefore() to take C++ references instead of Ref<>&& to avoid
unnecessarily causing ref counting churns at some call sites (including
in the bindings since they are a raw pointer to the nodes). The
implementation on ContainerNode was not actually using WTFMove() on the
Ref<>&& anyway.
- Modules/plugins/YouTubePluginReplacement.cpp:
(WebCore::YouTubePluginReplacement::installReplacement):
- bindings/js/JSNodeCustom.cpp:
(WebCore::JSNode::insertBefore):
(WebCore::JSNode::replaceChild):
(WebCore::JSNode::removeChild):
(WebCore::JSNode::appendChild):
- dom/ContainerNode.cpp:
(WebCore::ContainerNode::insertBefore):
(WebCore::ContainerNode::parserInsertBefore):
(WebCore::ContainerNode::replaceChild):
(WebCore::ContainerNode::appendChild):
(WebCore::ContainerNode::parserAppendChild):
(WebCore::ContainerNode::cloneChildNodes):
(WebCore::ContainerNode::append):
(WebCore::ContainerNode::prepend):
- dom/ContainerNode.h:
- dom/DOMImplementation.cpp:
(WebCore::DOMImplementation::createDocument):
(WebCore::DOMImplementation::createHTMLDocument):
- dom/Document.cpp:
(WebCore::Document::setBodyOrFrameset):
- dom/Element.cpp:
(WebCore::Element::setOuterHTML):
- dom/Node.cpp:
(WebCore::Node::insertBefore):
(WebCore::Node::replaceChild):
(WebCore::Node::removeChild):
(WebCore::Node::appendChild):
(WebCore::Node::before):
(WebCore::Node::after):
(WebCore::Node::replaceWith):
(WebCore::nodeSetPreTransformedFromNodeOrStringVector): Deleted.
(WebCore::Node::normalize): Deleted.
- dom/Node.h:
- dom/Node.idl:
- dom/NodeOrString.cpp:
(WebCore::convertNodesOrStringsIntoNode):
- dom/Range.cpp:
(WebCore::Range::processContents):
(WebCore::Range::processContentsBetweenOffsets):
(WebCore::Range::processNodes):
(WebCore::Range::processAncestorsAndTheirSiblings):
(WebCore::Range::insertNode):
(WebCore::Range::surroundContents):
- dom/Range.h:
- dom/Text.cpp:
(WebCore::Text::splitText):
- editing/AppendNodeCommand.cpp:
(WebCore::AppendNodeCommand::doApply):
- editing/Editor.cpp:
(WebCore::Editor::setTextAsChildOfElement):
- editing/EditorCommand.cpp:
(WebCore::executeInsertNode):
- editing/MergeIdenticalElementsCommand.cpp:
(WebCore::MergeIdenticalElementsCommand::doApply):
(WebCore::MergeIdenticalElementsCommand::doUnapply):
- editing/RemoveNodeCommand.cpp:
(WebCore::RemoveNodeCommand::doUnapply):
- editing/ReplaceNodeWithSpanCommand.cpp:
(WebCore::swapInNodePreservingAttributesAndChildren):
- editing/ReplaceSelectionCommand.cpp:
(WebCore::ReplacementFragment::insertFragmentForTestRendering):
- editing/SplitElementCommand.cpp:
(WebCore::SplitElementCommand::executeApply):
(WebCore::SplitElementCommand::doUnapply):
- editing/WrapContentsInDummySpanCommand.cpp:
(WebCore::WrapContentsInDummySpanCommand::executeApply):
(WebCore::WrapContentsInDummySpanCommand::doUnapply):
- editing/cocoa/EditorCocoa.mm:
(WebCore::Editor::styleForSelectionStart):
- editing/htmlediting.cpp:
(WebCore::createTabSpanElement):
- editing/ios/EditorIOS.mm:
(WebCore::Editor::WebContentReader::readURL):
(WebCore::Editor::createFragmentForImageResourceAndAddResource):
- editing/mac/EditorMac.mm:
(WebCore::Editor::WebContentReader::readFilenames):
(WebCore::Editor::WebContentReader::readURL):
(WebCore::Editor::createFragmentForImageResourceAndAddResource):
- editing/markup.cpp:
(WebCore::fillContainerFromString):
(WebCore::createFragmentFromText):
(WebCore::replaceChildrenWithFragment):
(WebCore::replaceChildrenWithText):
- html/BaseChooserOnlyDateAndTimeInputType.cpp:
(WebCore::BaseChooserOnlyDateAndTimeInputType::createShadowSubtree):
- html/ColorInputType.cpp:
(WebCore::ColorInputType::createShadowSubtree):
- html/FTPDirectoryDocument.cpp:
(WebCore::FTPDirectoryDocumentParser::appendEntry):
(WebCore::FTPDirectoryDocumentParser::createTDForFilename):
(WebCore::FTPDirectoryDocumentParser::createBasicDocument):
- html/HTMLDetailsElement.cpp:
(WebCore::HTMLDetailsElement::didAddUserAgentShadowRoot):
- html/HTMLElement.cpp:
(WebCore::HTMLElement::setOuterText):
(WebCore::HTMLElement::insertAdjacent):
- html/HTMLImageElement.cpp:
(WebCore::HTMLImageElement::tryCreateImageControls):
- html/HTMLKeygenElement.cpp:
(WebCore::HTMLKeygenElement::HTMLKeygenElement):
- html/HTMLMeterElement.cpp:
(WebCore::HTMLMeterElement::didAddUserAgentShadowRoot):
- html/HTMLOptionElement.cpp:
(WebCore::HTMLOptionElement::createForJSConstructor):
- html/HTMLProgressElement.cpp:
(WebCore::HTMLProgressElement::didAddUserAgentShadowRoot):
- html/HTMLTableElement.cpp:
(WebCore::HTMLTableElement::createTBody):
(WebCore::HTMLTableElement::insertRow):
- html/HTMLTableRowElement.cpp:
(WebCore::HTMLTableRowElement::insertCell):
- html/ImageDocument.cpp:
(WebCore::ImageDocument::createDocumentStructure):
- html/MediaDocument.cpp:
(WebCore::MediaDocumentParser::createDocumentStructure):
- html/PluginDocument.cpp:
(WebCore::PluginDocumentParser::createDocumentStructure):
- html/RangeInputType.cpp:
(WebCore::RangeInputType::createShadowSubtree):
- html/SearchInputType.cpp:
(WebCore::SearchInputType::createShadowSubtree):
- html/ValidationMessage.cpp:
(WebCore::ValidationMessage::buildBubbleTree):
- html/shadow/MediaControlElements.cpp:
(WebCore::MediaControlClosedCaptionsTrackListElement::rebuildTrackListMenu):
- html/shadow/MediaControls.cpp:
(WebCore::MediaControls::createTextTrackDisplay):
- html/shadow/MediaControlsApple.cpp:
(WebCore::MediaControlsApple::tryCreateControls):
- html/shadow/mac/ImageControlsRootElementMac.cpp:
(WebCore::ImageControlsRootElement::tryCreate):
- html/track/VTTCue.cpp:
(WebCore::VTTCue::updateDisplayTree):
- html/track/WebVTTParser.cpp:
(WebCore::WebVTTTreeBuilder::constructTreeFromToken):
- inspector/DOMEditor.cpp:
(WebCore::DOMEditor::RemoveChildAction::RemoveChildAction):
(WebCore::DOMEditor::InsertBeforeAction::InsertBeforeAction):
(WebCore::DOMEditor::ReplaceChildNodeAction::ReplaceChildNodeAction):
(WebCore::DOMEditor::insertBefore):
(WebCore::DOMEditor::removeChild):
(WebCore::DOMEditor::replaceChild):
- inspector/DOMEditor.h:
- inspector/DOMPatchSupport.cpp:
(WebCore::DOMPatchSupport::patchNode):
(WebCore::DOMPatchSupport::innerPatchNode):
(WebCore::DOMPatchSupport::innerPatchChildren):
(WebCore::DOMPatchSupport::insertBeforeAndMarkAsUsed):
(WebCore::DOMPatchSupport::removeChildAndMoveToNew):
- inspector/DOMPatchSupport.h:
- inspector/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::createInspectorStyleSheetForDocument):
- inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::removeNode):
(WebCore::InspectorDOMAgent::setNodeName):
(WebCore::InspectorDOMAgent::moveTo):
- page/DragController.cpp:
(WebCore::documentFragmentFromDragData):
- page/ios/FrameIOS.mm:
(WebCore::Frame::initWithSimpleHTMLDocument):
- svg/SVGUseElement.cpp:
(WebCore::SVGUseElement::cloneTarget):
(WebCore::SVGUseElement::expandUseElementsInShadowTree):
(WebCore::SVGUseElement::expandSymbolElementsInShadowTree):
- xml/XMLErrors.cpp:
(WebCore::createXHTMLParserErrorHeader):
(WebCore::XMLErrors::insertErrorMessageBlock):
- xml/XMLTreeViewer.cpp:
(WebCore::XMLTreeViewer::transformDocumentToTreeView):
- xml/parser/XMLDocumentParserLibxml2.cpp:
(WebCore::XMLDocumentParser::startElementNs):
(WebCore::XMLDocumentParser::processingInstruction):
(WebCore::XMLDocumentParser::cdataBlock):
(WebCore::XMLDocumentParser::comment):
Source/WebKit/mac:
- WebView/WebFrame.mm:
(-[WebFrame _documentFragmentWithNodesAsParagraphs:]):
Source/WebKit/win:
- DOMCoreClasses.cpp:
(DOMNode::insertBefore):
(DOMNode::removeChild):
Source/WebKit2:
- WebProcess/InjectedBundle/API/mac/WKDOMNode.mm:
(-[WKDOMNode insertNode:before:]):
(-[WKDOMNode appendChild:]):
(-[WKDOMNode removeChild:]):
- WebProcess/Plugins/PDF/DeprecatedPDFPlugin.mm:
(WebKit::PDFPlugin::PDFPlugin):
- WebProcess/Plugins/PDF/PDFPluginChoiceAnnotation.mm:
(WebKit::PDFPluginChoiceAnnotation::createAnnotationElement):
LayoutTests:
Rebaseline several tests now that the Node API provides more useful
exception messages.
- fast/dom/Document/replaceChild-null-oldChild-expected.txt:
- fast/dom/Document/script-tests/replaceChild-null-oldChild.js:
- fast/dom/incompatible-operations-expected.txt:
- fast/dom/incompatible-operations.html:
- fast/dom/processing-instruction-appendChild-exceptions-expected.txt:
- fast/dom/processing-instruction-appendChild-exceptions.xhtml:
- fast/dom/timer-clear-interval-in-handler-and-generate-error-expected.txt:
- js/dom/dot-node-base-exception-expected.txt:
- js/dom/script-tests/dot-node-base-exception.js:
- 11:42 AM Changeset in webkit [200695] by
-
- 31 edits in trunk
Modern IDB: IDBOpenDBRequests that are stop()'ed don't notify the IDBServer of that fact.
https://bugs.webkit.org/show_bug.cgi?id=157448
Reviewed by Alex Christensen.
Source/WebCore:
No new tests (Previously skipped tests cover new behavior, and are now unskipped).
There's two main parts to this patch:
1 - When an IDBOpenDBRequest is stop()'ed due to page navigation or worker termination,
we now notify the IDBServer of that.
2 - Lot's of little tweaks to UniqueIDBDatabase to handle shutting down version change
transactions and/or connections related to the cancelled openDB request.
Fortunately the changes to UniqueIDBDatabase were all well covered by existing tests.
- Modules/indexeddb/IDBOpenDBRequest.cpp:
(WebCore::IDBOpenDBRequest::fireSuccessAfterVersionChangeCommit):
(WebCore::IDBOpenDBRequest::fireErrorAfterVersionChangeCompletion):
(WebCore::IDBOpenDBRequest::cancelForStop):
(WebCore::IDBOpenDBRequest::dispatchEvent):
- Modules/indexeddb/IDBOpenDBRequest.h:
- Modules/indexeddb/IDBRequest.cpp:
(WebCore::IDBRequest::stop):
(WebCore::IDBRequest::cancelForStop):
- Modules/indexeddb/IDBRequest.h:
- Modules/indexeddb/client/IDBConnectionProxy.cpp:
(WebCore::IDBClient::IDBConnectionProxy::openDBRequestCancelled):
(WebCore::IDBClient::IDBConnectionProxy::didFinishHandlingVersionChangeTransaction):
- Modules/indexeddb/client/IDBConnectionProxy.h:
- Modules/indexeddb/client/IDBConnectionToServer.cpp:
(WebCore::IDBClient::IDBConnectionToServer::didFinishHandlingVersionChangeTransaction):
(WebCore::IDBClient::IDBConnectionToServer::openDBRequestCancelled):
- Modules/indexeddb/client/IDBConnectionToServer.h:
- Modules/indexeddb/client/IDBConnectionToServerDelegate.h:
- Modules/indexeddb/server/IDBServer.cpp:
(WebCore::IDBServer::IDBServer::didFinishHandlingVersionChangeTransaction):
(WebCore::IDBServer::IDBServer::databaseConnectionClosed):
(WebCore::IDBServer::IDBServer::openDBRequestCancelled):
- Modules/indexeddb/server/IDBServer.h:
- Modules/indexeddb/server/UniqueIDBDatabase.cpp:
(WebCore::IDBServer::UniqueIDBDatabase::didDeleteBackingStore):
(WebCore::IDBServer::UniqueIDBDatabase::handleCurrentOperation):
(WebCore::IDBServer::UniqueIDBDatabase::openDBRequestCancelled):
(WebCore::IDBServer::UniqueIDBDatabase::commitTransaction):
(WebCore::IDBServer::UniqueIDBDatabase::performCommitTransaction):
(WebCore::IDBServer::UniqueIDBDatabase::didPerformCommitTransaction):
(WebCore::IDBServer::UniqueIDBDatabase::abortTransaction):
(WebCore::IDBServer::UniqueIDBDatabase::didFinishHandlingVersionChange):
(WebCore::IDBServer::UniqueIDBDatabase::performAbortTransaction):
(WebCore::IDBServer::UniqueIDBDatabase::didPerformAbortTransaction):
(WebCore::IDBServer::UniqueIDBDatabase::connectionClosedFromClient):
(WebCore::IDBServer::UniqueIDBDatabase::transactionCompleted):
(WebCore::IDBServer::UniqueIDBDatabase::forgetErrorCallback):
- Modules/indexeddb/server/UniqueIDBDatabase.h:
- Modules/indexeddb/server/UniqueIDBDatabaseConnection.cpp:
(WebCore::IDBServer::UniqueIDBDatabaseConnection::abortTransactionWithoutCallback):
(WebCore::IDBServer::UniqueIDBDatabaseConnection::didFinishHandlingVersionChange):
- Modules/indexeddb/server/UniqueIDBDatabaseConnection.h:
- Modules/indexeddb/server/UniqueIDBDatabaseTransaction.cpp:
(WebCore::IDBServer::UniqueIDBDatabaseTransaction::didFinishHandlingVersionChange): Deleted.
- Modules/indexeddb/server/UniqueIDBDatabaseTransaction.h:
- Modules/indexeddb/shared/InProcessIDBServer.cpp:
(WebCore::InProcessIDBServer::didFinishHandlingVersionChangeTransaction):
(WebCore::InProcessIDBServer::openDBRequestCancelled):
- Modules/indexeddb/shared/InProcessIDBServer.h:
Source/WebKit2:
- DatabaseProcess/IndexedDB/WebIDBConnectionToClient.cpp:
(WebKit::WebIDBConnectionToClient::didFinishHandlingVersionChangeTransaction):
(WebKit::WebIDBConnectionToClient::openDBRequestCancelled):
- DatabaseProcess/IndexedDB/WebIDBConnectionToClient.h:
- DatabaseProcess/IndexedDB/WebIDBConnectionToClient.messages.in:
- WebProcess/Databases/IndexedDB/WebIDBConnectionToServer.cpp:
(WebKit::WebIDBConnectionToServer::didFinishHandlingVersionChangeTransaction):
(WebKit::WebIDBConnectionToServer::openDBRequestCancelled):
- WebProcess/Databases/IndexedDB/WebIDBConnectionToServer.h:
LayoutTests:
- TestExpectations:
- storage/indexeddb/pending-version-change-stuck-private-expected.txt:
- storage/indexeddb/pending-version-change-stuck-works-with-terminate-expected.txt:
- storage/indexeddb/pending-version-change-stuck-works-with-terminate-private-expected.txt:
- 11:33 AM Changeset in webkit [200694] by
-
- 11 edits in trunk
Improve error messages for accessing arguments.callee and similar getters in strict mode
https://bugs.webkit.org/show_bug.cgi?id=157545
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-05-11
Reviewed by Mark Lam.
Source/JavaScriptCore:
- runtime/ClonedArguments.cpp:
(JSC::ClonedArguments::getOwnPropertySlot):
(JSC::ClonedArguments::materializeSpecials):
Provide better error GetterSetter in strict mode.
- runtime/JSFunction.cpp:
(JSC::getThrowTypeErrorGetterSetter):
(JSC::JSFunction::defineOwnProperty):
Provide better error GetterSetter in strict mode.
- runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::init):
(JSC::JSGlobalObject::visitChildren):
- runtime/JSGlobalObject.h:
(JSC::JSGlobalObject::throwTypeErrorGetterSetter):
(JSC::JSGlobalObject::throwTypeErrorCalleeAndCallerGetterSetter):
(JSC::JSGlobalObject::throwTypeErrorArgumentsAndCallerInStrictModeGetterSetter):
(JSC::JSGlobalObject::throwTypeErrorArgumentsAndCallerInClassContextGetterSetter):
(JSC::JSGlobalObject::throwTypeErrorArgumentsAndCallerGetterSetter): Deleted.
- runtime/JSGlobalObjectFunctions.cpp:
(JSC::globalFuncThrowTypeErrorCalleeAndCaller):
(JSC::globalFuncThrowTypeErrorArgumentsAndCallerInStrictMode):
(JSC::globalFuncThrowTypeErrorArgumentsAndCallerInClassContext):
(JSC::globalFuncThrowTypeErrorArgumentsAndCaller): Deleted.
- runtime/JSGlobalObjectFunctions.h:
Rename and expose new handles for new error getter setter native functions.
LayoutTests:
- js/basic-strict-mode-expected.txt:
- js/caller-property-expected.txt:
- js/script-tests/caller-property.js:
- 11:13 AM Changeset in webkit [200693] by
-
- 2 edits in trunk/Source/JavaScriptCore
Unreviewed, rolling out r200481.
https://bugs.webkit.org/show_bug.cgi?id=157573
it's bad news for asm.js (Requested by pizlo on #webkit).
Reverted changeset:
"Reduce maximum JIT pool size on X86_64."
http://trac.webkit.org/changeset/200481
- 11:06 AM Changeset in webkit [200692] by
-
- 2 edits in trunk/Source/WebKit2
Fix a typo in r200330
Unreviewed.
- UIProcess/API/Cocoa/WKWebViewConfiguration.h:
- 10:28 AM Changeset in webkit [200691] by
-
- 6 edits9 deletes in trunk
Unreviewed, rolling out r200686.
Caused a lot of layout test failures
Reverted changeset:
"Sites served over insecure connections should not be allowed
to use geolocation."
https://bugs.webkit.org/show_bug.cgi?id=157423
http://trac.webkit.org/changeset/200686
- 10:11 AM MathML/Early_2016_Refactoring edited by
- (diff)
- 9:25 AM Changeset in webkit [200690] by
-
- 2 edits in trunk/Source/WebCore
Optimize DataDetection's searchForLinkRemovingExistingDDLinks()
https://bugs.webkit.org/show_bug.cgi?id=157561
Reviewed by Ryosuke Niwa.
Optimize DataDetection's searchForLinkRemovingExistingDDLinks():
- The first loop was using Node::childNodes() to iterate over the child elements. Because of the recursive call, we may end up prepending children as we iterate over them. This is an issue because the childCount was cached before the loop and vector it would blow away the cache inside the NodeList. Switch to using ElementTraversal which should be both safer and more efficient. I don't believe we can use our nice ElementChildIterator here unfortunately as we would hit assertions due the the DOM mutations while iterating.
- The second loop was using again Node::childNodes() and kept calling item(0) to get the first child and move it to make it the previous sibling of its old parent. Again, using childNodes() here is super inefficient because we keep modifying the children and childNodes() returns a live NodeList. The call to NodeList::length() would cache all the children in a Vector, only to blow that cache away after removing the first child. Switch to using ContainerNode::firstChild().
- Drop the parentElement parameter as we can just get it from the child.
- Use tighter typing so we don't end up calling the implementations of insertBefore() / removeChild() that are on Node, thus unnecessarily doing a is<ContainerNode>() check every time.
- Pass element by reference instead of pointer as it cannot be null.
- editing/cocoa/DataDetection.mm:
(WebCore::removeResultLinksFromAnchor):
(WebCore::searchForLinkRemovingExistingDDLinks):
- 9:24 AM Changeset in webkit [200689] by
-
- 2 edits in trunk/Source/WebCore
preprocess-idls.pl not ignoring comments during processing
https://bugs.webkit.org/show_bug.cgi?id=157559
Patch by Rawinder Singh <rawinder.singh-webkit@cisra.canon.com.au> on 2016-05-11
Reviewed by Darin Adler.
Remove comments from IDL file before processing.
- bindings/scripts/preprocess-idls.pl:
(getInterfaceExtendedAttributesFromIDL):
- 9:20 AM Changeset in webkit [200688] by
-
- 3 edits2 adds in trunk
Videos allowed to play through the Main Content restriction should not pause when scrolled off-screen.
https://bugs.webkit.org/show_bug.cgi?id=157555
Reviewed by Eric Carlson.
Source/WebCore:
Test: media/video-main-content-allow-then-scroll.html
- html/MediaElementSession.cpp:
(WebCore::isMainContent):
LayoutTests:
- media/video-main-content-allow-then-scroll-expected.txt: Added.
- media/video-main-content-allow-then-scroll.html: Added.
- 9:18 AM Changeset in webkit [200687] by
-
- 2 edits in trunk/Source/WebCore
[curl] curl_easy_setopt(CURLOPT_CONNECT_ONLY) should take a long parameter
https://bugs.webkit.org/show_bug.cgi?id=157562
Patch by Fujii Hironori <Fujii Hironori> on 2016-05-11
Reviewed by Darin Adler.
The third argument of a calling curl_easy_setopt is missing.
- platform/network/curl/SocketStreamHandleCurl.cpp:
(WebCore::SocketStreamHandle::startThread): Give the third
argument of curl_easy_setopt.
- 8:52 AM Changeset in webkit [200686] by
-
- 6 edits9 adds in trunk
Sites served over insecure connections should not be allowed to use geolocation.
https://bugs.webkit.org/show_bug.cgi?id=157423
<rdar://problem/23751632>
Patch by Pranjal Jumde <pjumde@apple.com> on 2016-05-11
Reviewed by Brent Fulgham.
Source/WebCore:
Tests: http/tests/security/insecure-geolocation.html
http/tests/security/mixedcontent-geolocation-block-insecure-content.html
http/tests/security/mixedcontent-geolocation.html
- Modules/geolocation/Geolocation.cpp:
(WebCore::Geolocation::logError):
(WebCore::Geolocation::startRequest):
Access to Geolocation will be blocked if site is not secure. An error will be logged when access to Geolocation is blocked.
(WebCore::Geolocation::shouldBlockGeolocationRequests)
Returns true if the access to the geolocation should be blocked.
- Modules/geolocation/Geolocation.h:
- dom/SecurityContext.h:
(WebCore::SecurityContext::foundMixedContent):
Returns true if insecure content was accessed over secure connection.
(WebCore::SecurityContext::setFoundMixedContent):
Sets m_foundMixedContent to true if insecure content is accessed over secure connection.
(WebCore::SecurityContext::geolocationAccessed):
Returns true if geolocation was accessed
(WebCore::SecurityContext::setGeolocationAccessed):
Sets m_geolocationAccessed to true if geolocation was accessed.
- loader/MixedContentChecker.cpp:
(WebCore::MixedContentChecker::canDisplayInsecureContent):
Insecure content will be blocked if geolocation was accessed by the page. Updates document to keep track of mixed content.
(WebCore::MixedContentChecker::canRunInsecureContent):
Insecure content will be blocked if geolocation was accessed by the page. Updates document to keep track of mixed content.
LayoutTests:
- http/tests/security/geolocation-over-insecure-content.html: Added.
- http/tests/security/geolocation-over-mixed-content-block.html: Added.
- http/tests/security/geolocation-over-mixed-content.html: Added.
- http/tests/security/insecure-geolocation-expected.txt: Added.
- http/tests/security/insecure-geolocation.html: Added.
- http/tests/security/mixedcontent-geolocation-block-insecure-content-expected.txt: Added.
- http/tests/security/mixedcontent-geolocation-block-insecure-content.html: Added.
- http/tests/security/mixedcontent-geolocation-expected.txt: Added.
- http/tests/security/mixedcontent-geolocation.html: Added.
- 2:11 AM MathML/Early_2016_Refactoring edited by
- (diff)
- 2:05 AM MathML/Early_2016_Refactoring edited by
- (diff)
- 1:20 AM Changeset in webkit [200685] by
-
- 6 edits1 copy in branches/safari-602.1.32-branch
Merged r200659. rdar://problem/26125909
- 1:19 AM Changeset in webkit [200684] by
-
- 2 edits in branches/safari-602.1.32-branch/Source/WebInspectorUI
Merged r200649. rdar://problem/26207064
- 1:18 AM Changeset in webkit [200683] by
-
- 2 edits in branches/safari-602.1.32-branch/Source/WebInspectorUI
Merged r200644. rdar://problem/26204033
- 1:17 AM Changeset in webkit [200682] by
-
- 2 edits in branches/safari-602.1.32-branch/Source/WebInspectorUI
Merged r200643. rdar://problem/26178404
- 1:16 AM Changeset in webkit [200681] by
-
- 3 edits in branches/safari-602.1.32-branch/Source/WebInspectorUI
Merged r200608. rdar://problem/26177346
- 1:16 AM Changeset in webkit [200680] by
-
- 3 edits in branches/safari-602.1.32-branch/Source/WebInspectorUI
Merged r200600. rdar://problem/26176524
- 1:15 AM Changeset in webkit [200679] by
-
- 2 edits in branches/safari-602.1.32-branch/Source/WebInspectorUI
Merged r200594. rdar://problem/26178439
- 12:50 AM Changeset in webkit [200678] by
-
- 5 edits in trunk
Ensure DOM iterators remain done
https://bugs.webkit.org/show_bug.cgi?id=157453
Reviewed by Darin Adler.
Source/WebCore:
Covered by updated test.
Making DOMWrapped::Iterator an Optional.
Setting it to Nullopt on the first time Iterator is returning null.
For set iterators, incrementing a counter which value is used in forEach callbacks and entries iterators.
- bindings/js/JSDOMIterator.h:
(WebCore::JSDOMIterator<JSWrapper>::asJS):
(WebCore::appendForEachArguments):
(WebCore::iteratorForEach):
(WebCore::JSDOMIterator<JSWrapper>::next):
LayoutTests:
- fast/dom/nodeListIterator-expected.txt:
- fast/text/font-face-set-javascript-expected.txt:
- 12:14 AM Changeset in webkit [200677] by
-
- 20 edits1 copy2 moves in trunk
[GTK] accessibility/aria-readonly.html is failing
https://bugs.webkit.org/show_bug.cgi?id=98357
Reviewed by Chris Fleizach.
Source/WebCore:
Add support for ATK_STATE_READ_ONLY and expose the value of aria-readonly
as an AtkObject attribute. In order to eliminate duplicate checks, remove
isReadOnly() and just use canSetAttributeValue(), moving all the logic into
AccessibilityNodeObject. Add AccessibilityObject::supportsARIAReadOnly() so
that we can explicitly expose the implicit value for aria-readonly on roles
which support this property. Also add support for ATK_STATE_CHECKABLE, both
because this state was missing and because it serves a similar function to
ATK_STATE_EDITABLE for the purpose of verifying exposure of toggle-able
elements that are not read-only.
Test: accessibility/form-control-value-settable.html
- accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::canSetValueAttribute):
(WebCore::AccessibilityNodeObject::isRequired): Deleted.
(WebCore::AccessibilityNodeObject::supportsRequiredAttribute): Deleted.
- accessibility/AccessibilityNodeObject.h:
- accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::supportsARIAReadOnly):
(WebCore::AccessibilityObject::ariaReadOnlyValue):
- accessibility/AccessibilityObject.h:
(WebCore::AccessibilityObject::isUnvisited): Deleted.
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::clickPoint):
(WebCore::AccessibilityRenderObject::isOffScreen): Deleted.
(WebCore::AccessibilityRenderObject::anchorElement): Deleted.
(WebCore::AccessibilityRenderObject::internalLinkElement): Deleted.
(WebCore::AccessibilityRenderObject::textChanged): Deleted.
(WebCore::AccessibilityRenderObject::clearChildren): Deleted.
(WebCore::AccessibilityRenderObject::addImageMapChildren): Deleted.
- accessibility/AccessibilityRenderObject.h:
- accessibility/atk/WebKitAccessibleInterfaceText.cpp:
(getAttributeSetForAccessibilityObject):
- accessibility/atk/WebKitAccessibleWrapperAtk.cpp:
(webkitAccessibleGetAttributes):
(setAtkStateSetFromCoreObject):
(getInterfaceMaskFromObject):
- inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::buildObjectForAccessibilityProperties):
Source/WebKit/win:
Call AccessibilityNode::canSetValueAttribute() to determine if STATE_SYSTEM_READONLY
should be added and if editable text should be supported.
- AccessibleBase.cpp:
(AccessibleBase::state):
- AccessibleTextImpl.cpp:
(AccessibleText::deleteText):
(AccessibleText::insertText):
(AccessibleText::cutText):
(AccessibleText::pasteText):
(AccessibleText::replaceText):
Tools:
Add checks to isAttributeSettable() for ATK_STATE_READ_ONLY and the 'readonly'
AtkObject attribute along with ATK_STATE_CHECKABLE for toggle-able elements,
ATK_STATE_SELECTABLE for select elements, and ATK_STATE_FOCUSABLE combined
with range verification for inputs which implement AtkValue. The latter two
additions are admittedly a heuristic workaround for platform accessibility
API differences. But they should be sufficient to facilitate cross-platform
testing of isAttributeSettable() for form elements which lack ARIA attributes.
Bump the minimum version of at-spi2-core and at-spi2-atk
to 2.15.4 (earliest version that supports STATE_READ_ONLY).
- WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
(WTR::AccessibilityUIElement::isAttributeSettable):
- gtk/jhbuild.modules:
LayoutTests:
As part of this change, a new AtkObject attribute and state are being exposed.
Update two tests accordingly. Also unskip the previously-failing test. Lastly,
move the Mac form-control-value-settable.html test to the shared test set,
with a minor tweak to check the platform for several elements' expectations.
- accessibility/form-control-value-settable.html: Moved to shared tests.
- accessibility/gtk/xml-roles-exposed-expected.txt: Updated.
- platform/gtk/TestExpectations: Unskipped previously-failing test.
- platform/gtk/accessibility/form-control-value-settable-expected.txt: Added.
- platform/gtk/accessibility/table-detection-expected.txt: Updated.
- platform/mac/accessibility/form-control-value-settable-expected.txt: Moved.
May 10, 2016:
- 11:03 PM Changeset in webkit [200676] by
-
- 5 edits in branches/safari-602.1.32-branch/Source
Versioning.
- 10:40 PM Changeset in webkit [200675] by
-
- 2 edits in trunk/Source/WebCore
Don't update media duration at playback end while seeking.
https://bugs.webkit.org/show_bug.cgi?id=157557
Patch by Jeremy Jones <jeremyj@apple.com> on 2016-05-10
Reviewed by Jer Noble.
If JavaScript initiates a media element seek just as the media playback ends, don't update duration
to the current time as the current time is now the new seek time, not the time when playback ended.
- platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
(WebCore::MediaPlayerPrivateAVFoundation::didEnd):
- 10:10 PM Changeset in webkit [200674] by
-
- 3 edits in trunk/LayoutTests
Test gardening after r200646
Unreviewed.
- TestExpectations:
- fast/text/unicode-range-download.html:
- 10:03 PM Changeset in webkit [200673] by
-
- 4 edits in trunk/Source/WebCore
Fix typo CaptionUserPreferences::updateCaptionStyleSheetOveride
https://bugs.webkit.org/show_bug.cgi?id=157544
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-05-10
Reviewed by Darin Adler.
- page/CaptionUserPreferences.cpp:
(WebCore::CaptionUserPreferences::setCaptionsStyleSheetOverride):
(WebCore::CaptionUserPreferences::updateCaptionStyleSheetOverride):
(WebCore::CaptionUserPreferences::updateCaptionStyleSheetOveride): Deleted.
- page/CaptionUserPreferences.h:
- page/CaptionUserPreferencesMediaAF.cpp:
(WebCore::CaptionUserPreferencesMediaAF::updateTimerFired):
(WebCore::CaptionUserPreferencesMediaAF::captionPreferencesChanged):
- 9:52 PM Changeset in webkit [200672] by
-
- 2 edits in trunk/Source/WebKit/mac
[OS X] Compatible with gnu sed grammar due to compile error with gnu sed
https://bugs.webkit.org/show_bug.cgi?id=157526
Patch by Shaw rich <richshaw@126.com> on 2016-05-10
Reviewed by Darin Adler.
- MigrateHeaders.make:
- 9:48 PM Changeset in webkit [200671] by
-
- 16 edits in trunk/Source/WebCore
Remove scrolledContentOffset() from rendering code
https://bugs.webkit.org/show_bug.cgi?id=157552
Reviewed by Zalan Bujtas.
scrolledContentOffset() is misleading because it returns a scrollPosition().
Just use the name scrollPosition(), returning a ScrollPosition (IntPoint),
and fix callers that need to convert to layout size.
- editing/VisibleUnits.cpp:
(WebCore::absoluteLineDirectionPointToLocalPointInBlock):
- rendering/LayoutState.cpp:
(WebCore::LayoutState::LayoutState):
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::paintObject):
(WebCore::RenderBlock::selectionGapRectsForRepaint):
(WebCore::RenderBlock::paintSelection):
(WebCore::RenderBlock::nodeAtPoint):
(WebCore::RenderBlock::offsetForContents):
- rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::layoutBlock):
- rendering/RenderBox.cpp:
(WebCore::RenderBox::scrollPosition):
(WebCore::RenderBox::applyCachedClipAndScrollOffsetForRepaint):
(WebCore::isCandidateForOpaquenessTest):
(WebCore::RenderBox::offsetFromContainer):
(WebCore::RenderBox::layoutOverflowRectForPropagation):
(WebCore::RenderBox::scrolledContentOffset): Deleted.
- rendering/RenderBox.h:
- rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::paintFillLayerExtended):
- rendering/RenderInline.cpp:
(WebCore::RenderInline::offsetFromContainer):
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::updateLayerPosition):
(WebCore::RenderLayer::mapLayerClipRectsToFragmentationLayer):
(WebCore::RenderLayer::calculateClipRects):
- rendering/RenderLayer.h:
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateGeometry):
- rendering/RenderMultiColumnFlowThread.cpp:
(WebCore::RenderMultiColumnFlowThread::offsetFromContainer):
- rendering/RenderNamedFlowThread.cpp:
(WebCore::RenderNamedFlowThread::decorationsClipRectForBoxInNamedFlowFragment):
- rendering/RenderObject.cpp:
(WebCore::RenderObject::mapLocalToContainer):
(WebCore::RenderObject::pushMappingToContainer):
(WebCore::RenderObject::mapAbsoluteToLocalPoint):
(WebCore::RenderObject::offsetFromContainer):
- rendering/RenderTextControl.cpp:
(WebCore::RenderTextControl::hitInnerTextElement):
- 9:26 PM Changeset in webkit [200670] by
-
- 2 edits in trunk/Tools
Another attempt to fix the build after r200668.
Unreviewed build fix.
- TestWebKitAPI/Tests/WebKit2Cocoa/Coding.mm:
(TEST):
- 8:57 PM Changeset in webkit [200669] by
-
- 2 edits in trunk/Tools
Tried to fix the Mac build after r200668.
- WebKitTestRunner/cocoa/TestControllerCocoa.mm:
(WTR::TestController::platformCreateWebView):
- 8:37 PM Changeset in webkit [200668] by
-
- 4 edits in trunk/Source/WebKit2
Only expose WKDataDetectorTypes and -[WKWebViewConfiguration dataDetectorTypes] on iOS
for now, since we don't have it fully implemented on Mac.
Reviewed by Tim Horton.
- UIProcess/API/Cocoa/WKWebView.mm:
(fromWKDataDetectorTypes):
(-[WKWebView _initializeWithConfiguration:]):
- UIProcess/API/Cocoa/WKWebViewConfiguration.h:
- UIProcess/API/Cocoa/WKWebViewConfiguration.mm:
(-[WKWebViewConfiguration encodeWithCoder:]):
(-[WKWebViewConfiguration initWithCoder:]):
(-[WKWebViewConfiguration copyWithZone:]):
- 7:04 PM Changeset in webkit [200667] by
-
- 3 edits in trunk/Source/JavaScriptCore
TypedArray.prototype.slice should use the byteLength of passed array for memmove
https://bugs.webkit.org/show_bug.cgi?id=157551
<rdar://problem/26179914>
Reviewed by Michael Saboff.
The TypedArray.prototype.slice function would use the byteLength of the passed array
to determine the amount of data to copy. It should have been using the passed length
times the size of each element. This fixes a crash on JavaPoly.com
- runtime/JSGenericTypedArrayViewInlines.h:
(JSC::JSGenericTypedArrayView<Adaptor>::set):
- tests/stress/typedarray-slice.js:
- 6:56 PM Changeset in webkit [200666] by
-
- 2 edits in trunk/Source/JavaScriptCore
REGRESSION(r200447): Unable to build C_LOOP with clang version 800.0.12 or higher
https://bugs.webkit.org/show_bug.cgi?id=157549
Reviewed by Keith Miller.
Disable debug annotations for C_LOOP builds. They are inline assembly directives,
unnecessary and they cause syntax errors.
- offlineasm/asm.rb:
- 6:55 PM Changeset in webkit [200665] by
-
- 3 edits5 adds in trunk
Horizontally-scrollable items with a 3d transform are rendered incorrectly in RTL when container has -webkit-overflow-scroll: touch
https://bugs.webkit.org/show_bug.cgi?id=157482
rdar://problem/26204794
Reviewed by Zalan Bujtas.
Source/WebCore:
The compositing code was confused about scroll offsets vs. scroll positions, because
of the badly named scrolledContentOffset(); we used that in one place, and scrollOffset()
lower down. Change both to use scrollOffset().
Test: compositing/rtl/rtl-with-transformed-descendants.html
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateGeometry):
LayoutTests:
This can't be a ref test because on iOS ref test snapshots are doing by drawing, not by snapshotting layers.
- compositing/rtl/rtl-with-transformed-descendants-expected.txt: Added.
- compositing/rtl/rtl-with-transformed-descendants.html: Added.
- 6:55 PM Changeset in webkit [200664] by
-
- 2 edits in trunk/Source/WebKit/mac
[iOS WK1] text autosizing was on for all layout tests
https://bugs.webkit.org/show_bug.cgi?id=157541
Reviewed by Tim Horton.
Make sure that we transfer the WK1 text autosizing preference to Settings.
- WebView/WebView.mm:
(-[WebView _preferencesChanged:]):
- 6:49 PM Changeset in webkit [200663] by
-
- 2 edits5 adds in trunk/LayoutTests
Unreviewed EFL Gardening on 10th May.
Rebaseline missing results.
- platform/efl/TestExpectations: Removed non existing tests.
- platform/efl/accessibility/content-editable-as-textarea-expected.txt: Added.
- platform/efl/accessibility/generated-content-with-display-table-crash-expected.txt: Added.
- platform/efl/accessibility/w3c-svg-content-language-attribute-expected.txt: Added.
- platform/efl/fast/text/hyphenate-avoid-orphaned-word-expected.txt: Added.
- platform/efl/mathml/presentation/menclose-notation-values-expected.txt: Added.
- 6:11 PM Changeset in webkit [200662] by
-
- 3 edits in trunk/Source/WebKit2
Add SPI for Data Detectors to get ranges of text around an existing range.
<rdar://problem/26009749>
Reviewed by Enrica Casucci.
- WebProcess/InjectedBundle/API/mac/WKDOMRange.h:
- WebProcess/InjectedBundle/API/mac/WKDOMRange.mm:
(-[WKDOMRange rangeByExpandingToWordBoundaryByCharacters:inDirection:]):
- 5:56 PM Changeset in webkit [200661] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Avoid unnecessary timeout identifier churn in TimelineManager
https://bugs.webkit.org/show_bug.cgi?id=157535
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-05-10
Reviewed by Timothy Hatcher.
- UserInterface/Controllers/TimelineManager.js:
(WebInspector.TimelineManager):
(WebInspector.TimelineManager.prototype.capturingStarted):
(WebInspector.TimelineManager.prototype._resetAutoRecordingDeadTimeTimeout):
Don't re-tickle if we tickled in the last 10ms.
- 5:20 PM Changeset in webkit [200660] by
-
- 9 edits in trunk/Source
Numerous block selection issues on iOS.
https://bugs.webkit.org/show_bug.cgi?id=157490
rdar://problem/25717977
rdar://problem/23042215
Reviewed by Tim Horton.
Source/WebCore:
- rendering/style/RenderStyle.h:
Exporting method.
Source/WebKit2:
This patch fixes a number of issues with block selection on iOS.
We no longer eagerly choose block selection vs text selection and we
make sure we are capable of switching back to text selection from block
under every circumstance. The patch also fixes the logic used to decide
when to switch to block selection. It now computes the rectangle for the
paragraph containing the initial text selection to decide when we are
actually dragging outside the boundaries of the paragraph block.
- UIProcess/WebPageProxy.h:
- UIProcess/WebPageProxy.messages.in:
- UIProcess/ios/WKContentViewInteraction.mm:
(selectionChangedWithGesture):
(selectionChangedWithTouch):
(-[WKContentView changeSelectionWithTouchAt:withSelectionTouch:baseIsStart:]):
- UIProcess/ios/WebPageProxyIOS.mm:
(WebKit::WebPageProxy::gestureCallback):
(WebKit::WebPageProxy::touchesCallback):
(WebKit::WebPageProxy::autocorrectionDataCallback):
(WebKit::WebPageProxy::selectWithGesture):
(WebKit::WebPageProxy::updateSelectionWithTouches):
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::selectionBoxForRange):
(WebKit::canShrinkToTextSelection):
(WebKit::hasCustomLineHeight):
(WebKit::WebPage::rangeForWebSelectionAtPosition):
(WebKit::WebPage::contractedRangeFromHandle):
(WebKit::WebPage::updateBlockSelectionWithTouch):
(WebKit::WebPage::clearSelection):
(WebKit::WebPage::switchToBlockSelectionAtPoint):
(WebKit::WebPage::shouldSwitchToBlockModeForHandle):
(WebKit::WebPage::updateSelectionWithTouches):
(WebKit::WebPage::selectWithTwoTouches):
- 5:16 PM Changeset in webkit [200659] by
-
- 6 edits1 add in trunk
Tweak underline style for data detected links
https://bugs.webkit.org/show_bug.cgi?id=157546
Reviewed by Tim Horton.
Source/WebCore:
Added API Tests in Color.cpp.
- editing/cocoa/DataDetection.mm:
(WebCore::DataDetection::detectContentInRange):
Tweak the underline's opacity based on the text color. White-ish text gets
46% opacity, everything else gets 26% opacity.
- platform/graphics/Color.cpp:
(WebCore::Color::getHSV):
- platform/graphics/Color.h:
Add support for getting the HSV (also know as HSB) computation of the color
to help determine the "whiteness" of a color.
Tools:
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/WebCore/Color.cpp: Added.
(TestWebKitAPI::TEST):
Add tests for the new Color::getHSV() function.
- 5:08 PM Changeset in webkit [200658] by
-
- 27 edits4 adds in trunk
Internal JSC profiler should have a timestamped log of events for each code block
https://bugs.webkit.org/show_bug.cgi?id=157538
Reviewed by Benjamin Poulain.
Source/JavaScriptCore:
For example, in 3d-cube, I can query the events for MMulti and I get:
1462917476.17083 MMulti#DTZ7qc installCode
1462917476.179663 MMulti#DTZ7qc MMulti#DTZ7qc-1-Baseline installCode
1462917476.179664 MMulti#DTZ7qc MMulti#DTZ7qc-1-Baseline osrEntry at bc#49
1462917476.185651 MMulti#DTZ7qc MMulti#DTZ7qc-1-Baseline delayOptimizeToDFG counter = 1011.214233/1717.000000, -707
1462917476.187913 MMulti#DTZ7qc MMulti#DTZ7qc-2-DFG installCode
1462917476.187917 MMulti#DTZ7qc MMulti#DTZ7qc-2-DFG osrEntry at bc#49
1462917476.205365 MMulti#DTZ7qc MMulti#DTZ7qc-2-DFG jettison due to OSRExit, counting = true, detail = (null)
1462917476.205368 MMulti#DTZ7qc MMulti#DTZ7qc-1-Baseline frequentExit bc#65: BadCache/FromDFG
1462917476.205369 MMulti#DTZ7qc MMulti#DTZ7qc-1-Baseline installCode
1462917476.205482 MMulti#DTZ7qc MMulti#DTZ7qc-1-Baseline delayOptimizeToDFG counter = 1013.000000/3434.000000, -1000
1462917476.211547 MMulti#DTZ7qc MMulti#DTZ7qc-1-Baseline delayOptimizeToDFG counter = 2013.000000/3434.000000, -1000
1462917476.213721 MMulti#DTZ7qc MMulti#DTZ7qc-3-DFG installCode
1462917476.213726 MMulti#DTZ7qc MMulti#DTZ7qc-3-DFG osrEntry at bc#49
1462917476.223976 MMulti#DTZ7qc MMulti#DTZ7qc-3-DFG jettison due to OSRExit, counting = true, detail = (null)
1462917476.223981 MMulti#DTZ7qc MMulti#DTZ7qc-1-Baseline frequentExit bc#77: BadCache/FromDFG
1462917476.223982 MMulti#DTZ7qc MMulti#DTZ7qc-1-Baseline frequentExit bc#94: BadCache/FromDFG
1462917476.223982 MMulti#DTZ7qc MMulti#DTZ7qc-1-Baseline installCode
1462917476.224064 MMulti#DTZ7qc MMulti#DTZ7qc-1-Baseline delayOptimizeToDFG counter = 1013.000000/6868.000000, -1000
1462917476.224151 MMulti#DTZ7qc MMulti#DTZ7qc-1-Baseline delayOptimizeToDFG counter = 2013.000000/6868.000000, -1000
1462917476.224258 MMulti#DTZ7qc MMulti#DTZ7qc-1-Baseline delayOptimizeToDFG counter = 3013.000000/6868.000000, -1000
1462917476.224337 MMulti#DTZ7qc MMulti#DTZ7qc-1-Baseline delayOptimizeToDFG counter = 4023.000000/6868.000000, -1000
1462917476.224425 MMulti#DTZ7qc MMulti#DTZ7qc-1-Baseline delayOptimizeToDFG counter = 5023.000000/6868.000000, -1000
1462917476.224785 MMulti#DTZ7qc MMulti#DTZ7qc-1-Baseline delayOptimizeToDFG counter = 6023.396484/6868.000000, -862
1462917476.227669 MMulti#DTZ7qc MMulti#DTZ7qc-4-DFG installCode
1462917476.227675 MMulti#DTZ7qc MMulti#DTZ7qc-4-DFG osrEntry at bc#0
The output is ugly but useful. We can make it less ugly later.
- CMakeLists.txt:
- JavaScriptCore.xcodeproj/project.pbxproj:
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::jettison):
- bytecode/CodeBlock.h:
(JSC::ScriptExecutable::forEachCodeBlock):
- bytecode/DFGExitProfile.cpp:
(JSC::DFG::ExitProfile::add):
- dfg/DFGJITFinalizer.cpp:
(JSC::DFG::JITFinalizer::finalizeCommon):
- dfg/DFGOperations.cpp:
- ftl/FTLJITFinalizer.cpp:
(JSC::FTL::JITFinalizer::finalizeFunction):
- jit/JIT.cpp:
(JSC::JIT::privateCompile):
- jit/JITOperations.cpp:
- llint/LLIntSlowPaths.cpp:
(JSC::LLInt::jitCompileAndSetHeuristics):
(JSC::LLInt::entryOSR):
(JSC::LLInt::LLINT_SLOW_PATH_DECL):
- profiler/ProfilerCompilation.cpp:
(JSC::Profiler::Compilation::Compilation):
(JSC::Profiler::Compilation::setJettisonReason):
(JSC::Profiler::Compilation::dump):
(JSC::Profiler::Compilation::toJS):
- profiler/ProfilerCompilation.h:
(JSC::Profiler::Compilation::uid):
- profiler/ProfilerDatabase.cpp:
(JSC::Profiler::Database::ensureBytecodesFor):
(JSC::Profiler::Database::notifyDestruction):
(JSC::Profiler::Database::addCompilation):
(JSC::Profiler::Database::toJS):
(JSC::Profiler::Database::registerToSaveAtExit):
(JSC::Profiler::Database::logEvent):
(JSC::Profiler::Database::addDatabaseToAtExit):
- profiler/ProfilerDatabase.h:
- profiler/ProfilerEvent.cpp: Added.
(JSC::Profiler::Event::dump):
(JSC::Profiler::Event::toJS):
- profiler/ProfilerEvent.h: Added.
(JSC::Profiler::Event::Event):
(JSC::Profiler::Event::operator bool):
(JSC::Profiler::Event::time):
(JSC::Profiler::Event::bytecodes):
(JSC::Profiler::Event::compilation):
(JSC::Profiler::Event::summary):
(JSC::Profiler::Event::detail):
- profiler/ProfilerUID.cpp: Added.
(JSC::Profiler::UID::create):
(JSC::Profiler::UID::dump):
(JSC::Profiler::UID::toJS):
- profiler/ProfilerUID.h: Added.
(JSC::Profiler::UID::UID):
(JSC::Profiler::UID::fromInt):
(JSC::Profiler::UID::toInt):
(JSC::Profiler::UID::operator==):
(JSC::Profiler::UID::operator!=):
(JSC::Profiler::UID::operator bool):
(JSC::Profiler::UID::isHashTableDeletedValue):
(JSC::Profiler::UID::hash):
(JSC::Profiler::UIDHash::hash):
(JSC::Profiler::UIDHash::equal):
- runtime/CommonIdentifiers.h:
- runtime/Executable.cpp:
(JSC::ScriptExecutable::installCode):
- runtime/VM.h:
(JSC::VM::bytecodeIntrinsicRegistry):
(JSC::VM::shadowChicken):
- runtime/VMInlines.h:
(JSC::VM::shouldTriggerTermination):
(JSC::VM::logEvent):
Source/WTF:
- wtf/PrintStream.h:
(WTF::PrintStream::print):
Tools:
- Scripts/display-profiler-output:
- 5:02 PM Changeset in webkit [200657] by
-
- 1 copy in branches/safari-602.1.32-branch
New Branch.
- 4:51 PM Changeset in webkit [200656] by
-
- 4 edits in trunk/Source/WebInspectorUI
Web Inspector: Can't select record bar in Frames timeline
https://bugs.webkit.org/show_bug.cgi?id=156963
<rdar://problem/25898256>
Reviewed by Timothy Hatcher.
Sync record selection between the Rendering Frames grid and overview graph.
- UserInterface/Views/DataGrid.js:
(WebInspector.DataGridNode.prototype.hasAncestor):
Add helper function needed by TimelineView.
- UserInterface/Views/RenderingFrameTimelineOverviewGraph.js:
(WebInspector.RenderingFrameTimelineOverviewGraph.prototype._mouseClicked):
Don't deselect the selected record when clicked. Initially this seemed
like a good idea but it complicates the UI for no added value.
- UserInterface/Views/TimelineRecordingContentView.js:
(WebInspector.TimelineRecordingContentView.prototype._contentViewSelectionPathComponentDidChange):
Get path components from the current TimelineView instead of the
TimelineRecordingContentView, now that the selected record appears
in the bottom ContentBrowser's navigation bar.
- 4:49 PM Changeset in webkit [200655] by
-
- 7 edits in trunk/Source
Handle _schemeUpgraded delegate callbacks in NSURLSessionDataDelegate
https://bugs.webkit.org/show_bug.cgi?id=157354
rdar://problem/25842107
Reviewed by Darin Adler.
Source/WebCore:
No new tests. This cannot be tested with a self-signed certificate.
This needs to be tested once we use real ssl certificates for testing.
- platform/network/mac/WebCoreResourceHandleAsDelegate.mm:
(-[WebCoreResourceHandleAsDelegate connection:willSendRequest:redirectResponse:]):
- platform/network/mac/WebCoreResourceHandleAsOperationQueueDelegate.mm:
(-[WebCoreResourceHandleAsOperationQueueDelegate connection:willSendRequest:redirectResponse:]):
- platform/network/mac/WebCoreURLResponse.h:
- platform/network/mac/WebCoreURLResponse.mm:
(WebCore::synthesizeRedirectResponseIfNecessary):
Take the NSURLRequest instead of the NSURLConnection as a parameter so we can share this code with the NSURLSession loader,
which has an NSURLSessionDataTask. Both have the currentRequest, which is all we need in this function anyway.
Source/WebKit2:
- NetworkProcess/cocoa/NetworkSessionCocoa.mm:
(-[WKNetworkSessionDelegate URLSession:task:_schemeUpgraded:completionHandler:]):
When we make a request to a http url and CFNetwork determines that that url would have redirected to an HSTS site
and it is going to change the request to an https request, this delegate callback is called. We need to call the
redirection code to have the same behavior as the NSURLConnection-based loader.
- 4:47 PM Changeset in webkit [200654] by
-
- 2 edits in trunk/Source/bmalloc
bmalloc should automatically disable itself when ThreadSanitizer is used
<https://webkit.org/b/157527>
Reviewed by Michael Catanzaro.
- bmalloc/Environment.cpp:
(bmalloc::isASanEnabled): Rename to isSanitizerEnabled.
(bmalloc::isSanitizerEnabled): Rename from isASanEnabled. Add
support for detecting ThreadSanitizer.
(bmalloc::Environment::computeIsBmallocEnabled): Switch from
isASanEnabled to isSanitizerEnabled.
- 4:45 PM Changeset in webkit [200653] by
-
- 1 copy in tags/Safari-602.1.32
New tag.
- 4:38 PM Changeset in webkit [200652] by
-
- 2 edits in trunk/LayoutTests
iOS rebaseline after r200464.
- fast/shadow-dom/touch-event-ios-expected.txt:
- 4:38 PM Changeset in webkit [200651] by
-
- 11 edits2 adds in trunk
Web Inspector: Backend should initiate timeline recordings on page navigations to ensure nothing is missed
https://bugs.webkit.org/show_bug.cgi?id=157504
<rdar://problem/26188642>
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-05-10
Reviewed by Brian Burg.
Source/JavaScriptCore:
- inspector/protocol/Timeline.json:
Add protocol commands to enable/disable auto capture and list the
instruments that should be enabled when auto capture starts.
Add protocol event for when the backend starts an auto capture.
Source/WebCore:
Test: inspector/timeline/setAutoCaptureInstruments-errors.html
- inspector/InspectorController.cpp:
(WebCore::InspectorController::InspectorController):
Pass other agents into the TimelineAgent constructor.
- inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::frameStartedLoadingImpl):
Inform the TimelineAgent whenever the main frame starts a new load.
- inspector/InspectorTimelineAgent.h:
- inspector/InspectorTimelineAgent.cpp:
(WebCore::InspectorTimelineAgent::InspectorTimelineAgent):
Initialize new members.
(WebCore::InspectorTimelineAgent::willDestroyFrontendAndBackend):
Cleanup auto capture state when tearing down.
(WebCore::InspectorTimelineAgent::setAutoCaptureEnabled):
(WebCore::InspectorTimelineAgent::setAutoCaptureInstruments):
Set and validate new auto capture state from the frontend.
(WebCore::InspectorTimelineAgent::mainFrameStartedLoading):
When page navigates start an auto capture if needed.
Source/WebInspectorUI:
- UserInterface/Controllers/TimelineManager.js:
(WebInspector.TimelineManager):
(WebInspector.TimelineManager.prototype.set autoCaptureOnPageLoad):
(WebInspector.TimelineManager.prototype.set enabledTimelineTypes):
(WebInspector.TimelineManager.prototype._updateAutoCaptureInstruments):
For backends that support it, enable/disable auto capture and the instruments to use.
(WebInspector.TimelineManager.prototype.autoCaptureStarted):
New event, stop and start a new recording. Set a flag that we should
detect the auto capturing resource so we know when the stop the
auto capture.
(WebInspector.TimelineManager.prototype._loadNewRecording):
(WebInspector.TimelineManager.prototype._addRecord):
(WebInspector.TimelineManager.prototype._startAutoCapturing): Renamed.
(WebInspector.TimelineManager.prototype._attemptAutoCapturingForFrame):
(WebInspector.TimelineManager.prototype._legacyAttemptStartAutoCapturingForFrame):
(WebInspector.TimelineManager.prototype._stopAutoRecordingSoon):
(WebInspector.TimelineManager.prototype._resetAutoRecordingMaxTimeTimeout):
(WebInspector.TimelineManager.prototype._resetAutoRecordingDeadTimeTimeout):
(WebInspector.TimelineManager.prototype._mainResourceDidChange):
(WebInspector.TimelineManager.prototype._mergeScriptProfileRecords):
Factor out the new path, old path, and shared code for auto capturing.
Renamed _startAutoCapturing to _attemptAutoCapturingForFrame which
better matches what it tries to do.
- UserInterface/Protocol/TimelineObserver.js:
(WebInspector.TimelineObserver.prototype.autoCaptureStarted):
Inform TimelineManager.
LayoutTests:
- inspector/timeline/setAutoCaptureInstruments-errors-expected.txt: Added.
- inspector/timeline/setAutoCaptureInstruments-errors.html: Added.
- 4:21 PM Changeset in webkit [200650] by
-
- 5 edits in trunk/Source
Versioning.
- 4:18 PM Changeset in webkit [200649] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Debugger sidebar should refresh when Debug UI enabled/disabled
https://bugs.webkit.org/show_bug.cgi?id=157540
<rdar://problem/26207064>
Reviewed by Timothy Hatcher.
- UserInterface/Views/DebuggerSidebarPanel.js:
(WebInspector.DebuggerSidebarPanel.prototype._scriptRemoved.removeScript):
(WebInspector.DebuggerSidebarPanel.prototype._scriptRemoved):
Remove element from both tree outlines, if it exists.
- 4:11 PM Changeset in webkit [200648] by
-
- 5 edits in trunk/Source/JavaScriptCore
Make the different evaluateWithScopeExtension implementations more consistent
https://bugs.webkit.org/show_bug.cgi?id=157536
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-05-10
Reviewed by Timothy Hatcher.
- inspector/JSInjectedScriptHost.cpp:
(Inspector::JSInjectedScriptHost::evaluateWithScopeExtension):
Throw the exception consistent with JSJavaScriptCallFrame.
- inspector/JSJavaScriptCallFrame.cpp:
(Inspector::JSJavaScriptCallFrame::evaluateWithScopeExtension):
Better error message consistent with InjectedScriptHost.
- runtime/Completion.h:
- runtime/Completion.cpp:
(JSC::evaluateWithScopeExtension):
Give this an Exception out parameter like other evaluations
so the caller can decide what to do with it.
- 3:08 PM Changeset in webkit [200647] by
-
- 5 edits in branches/safari-601-branch/Source
Versioning.
- 2:43 PM Changeset in webkit [200646] by
-
- 2 edits in trunk/LayoutTests
Marking fast/text/unicode-range-download.html as flaky
https://bugs.webkit.org/show_bug.cgi?id=42154
Unreviewed test gardening.
- 2:35 PM Changeset in webkit [200645] by
-
- 2 edits1 add in trunk/Source/JavaScriptCore
[JSC] FTL can produce GetByVal nodes without proper bounds checking
https://bugs.webkit.org/show_bug.cgi?id=157502
rdar://problem/26027027
Patch by Benjamin Poulain <bpoulain@apple.com> on 2016-05-10
Reviewed by Filip Pizlo.
It was possible for FTL to generates GetByVal on arbitrary offsets
without any bounds checking.
The bug is caused by the order of optimization phases:
-First, the Integer Range Optimization proves that a CheckInBounds
test can never fail.
This proof is based on control flow or preceeding instructions
inside a loop.
-The Loop Invariant Code Motion phase finds that the GetByVal does not
depend on anything in the loop and hoist it out of the loop.
-> As a result, the conditions that were necessary to eliminate
the CheckInBounds are no longer met before the GetByVal.
This patch just moves the Integer Range Optimization phase after
Loop Invariant Code Motion to make sure no code is moved after
its integer ranges bounds proofs have been used.
- dfg/DFGPlan.cpp:
(JSC::DFG::Plan::compileInThreadImpl):
- tests/stress/bounds-check-not-eliminated-by-licm.js: Added.
(testInLoopTests):
- 2:30 PM Changeset in webkit [200644] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: TimelineOverview assertion failed: Missing overview graph for timeline type undefined
https://bugs.webkit.org/show_bug.cgi?id=157533
<rdar://problem/26204033>
Reviewed by Timothy Hatcher.
- UserInterface/Views/TimelineRecordingContentView.js:
(WebInspector.TimelineRecordingContentView.prototype._recordWasFiltered):
The OverviewTimelineView's represented object is the entire recording,
and TimelineOverview.recordWasFiltered expects a timeline. Return early
since no graph in the overview needs updating.
- 2:26 PM Changeset in webkit [200643] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Call Trees and Memory view blank
https://bugs.webkit.org/show_bug.cgi?id=157486
<rdar://problem/26178404>
Reviewed by Timothy Hatcher.
- UserInterface/Views/TimelineRecordingContentView.js:
(WebInspector.TimelineRecordingContentView.prototype._currentContentViewDidChange):
(WebInspector.TimelineRecordingContentView.prototype._updateTimes):
Setting current time now handled by _updateTimelineViewTimes.
(WebInspector.TimelineRecordingContentView.prototype._capturingStopped):
Update times for the current TimelineView when the recording ends.
This ensures that views that don't call TimelineView.setupDataGrid are
able to update state that depends on the ruler selection.
(WebInspector.TimelineRecordingContentView.prototype._timeRangeSelectionChanged):
(WebInspector.TimelineRecordingContentView.prototype._updateTimelineViewTimes):
Renamed from _updateTimelineViewSelection. Sets start, end, and current times.
- 1:45 PM Changeset in webkit [200642] by
-
- 2 edits in trunk/Source/WebCore
Fix the !ENABLE(SHADOW_DOM) && !ENABLE(DETAILS_ELEMENT) build
https://bugs.webkit.org/show_bug.cgi?id=157514
Reviewed by Ryosuke Niwa.
- dom/Element.cpp:
(WebCore::Element::insertedInto):
(WebCore::Element::removedFrom):
- 1:44 PM Changeset in webkit [200641] by
-
- 3 edits in trunk/Source/WebKit2
Fix the !ENABLE(VIDEO) build
https://bugs.webkit.org/show_bug.cgi?id=157518
Reviewed by Alex Christensen.
- UIProcess/WebsiteData/WebsiteDataStore.cpp:
(WebKit::WebsiteDataStore::fetchData):
(WebKit::WebsiteDataStore::removeData):
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::initializeWebProcess):
- 1:42 PM Changeset in webkit [200640] by
-
- 2 edits in trunk/Source/WebCore
Fix the !ENABLE(WEB_TIMING) build
https://bugs.webkit.org/show_bug.cgi?id=157515
Reviewed by Alex Christensen.
- loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::loadDone):
- 1:41 PM Changeset in webkit [200639] by
-
- 3 edits in trunk/Source/WebCore
Fix the !ENABLE(INDEXED_DATABASE) build
https://bugs.webkit.org/show_bug.cgi?id=157517
Reviewed by Alex Christensen.
- workers/WorkerGlobalScope.cpp:
(WebCore::WorkerGlobalScope::WorkerGlobalScope):
- workers/WorkerThread.cpp:
(WebCore::WorkerThread::WorkerThread):
- 1:32 PM Changeset in webkit [200638] by
-
- 12 edits15 adds in trunk
Return a Promise from HTMLMediaElement.play()
https://bugs.webkit.org/show_bug.cgi?id=157400
Reviewed by Eric Carlson.
LayoutTests/imported/w3c:
Rebaseline web-platform-tests/html/dom/interfaces-expected.txt with new (failing) result.
- web-platform-tests/html/dom/interfaces-expected.txt:
Source/WebCore:
Tests: media/media-play-promise-reject-error-notsupported.html
media/media-play-promise-reject-load-abort.html
media/media-play-promise-reject-pause-abort.html
media/media-play-promise-reject-play-notallowed.html
media/media-play-promise-reject-play-notsupported.html
media/media-play-promise-resolve-when-playing.html
media/media-play-promise-resolve.html
The HTML Living Standard Spec <https://html.spec.whatwg.org/multipage/embedded-content.html>
(5 May 2016) adds support for a Promise to be returned by the play() method, to be resolved
or rejected at defined points during loading and playback.
Add utility methods which encapsulate the definitions of the equivalent algorithms from the
HTML Spec. Add a new, overloaded play() method on HTMLMediaElement which takes a DeferredWrapper
reference.
After the change to use scheduleNotifyAboutPlaying() instead of enqueueing the "playing" event
directly, we must ensure that the notifyAboutPlaying() task does not get fired before the
"play" event preceeding it does. So re-implement GenericEventQueue (which previously used
a timer to dispatch events) to use a GenericTaskQueue instead. This ensures that all tasks and
events are interleaved in the order in which they were enqueued.
Additionally, the new pauseAfterDetachedTimerFired() event was firing out of microtask order, which
broke some W3C tests after the changes to GenericEventQueue. Move GenericEventQueue and
GenericTaskQueue to the same timing source (namely, a WebCore Timer) and interleave Events
and Tasks by having GenericEventQueue use GenericTaskQueue to issue its Events. Because
Document::postTask() cannot ensure ordering with Timer-based events, switch HTMLMediaElement
over to Timer-backed GenericTaskQueues.
Use a WeakPtr to track the destruction of TaskDispatcher<Timer> objects in pendingDispatchers().
- dom/GenericEventQueue.cpp:
(WebCore::GenericEventQueue::GenericEventQueue):
(WebCore::GenericEventQueue::enqueueEvent):
(WebCore::GenericEventQueue::close):
(WebCore::GenericEventQueue::cancelAllEvents):
(WebCore::GenericEventQueue::suspend):
(WebCore::GenericEventQueue::resume):
(WebCore::GenericEventQueue::sharedTimer): Deleted.
(WebCore::GenericEventQueue::sharedTimerFired): Deleted.
(WebCore::GenericEventQueue::pendingQueues): Deleted.
- dom/GenericEventQueue.h:
- platform/GenericTaskQueue.cpp: Added.
(WebCore::TaskDispatcher<Timer>::~TaskDispatcher):
(WebCore::TaskDispatcher<Timer>::postTask):
(WebCore::TaskDispatcher<Timer>::sharedTimer):
(WebCore::TaskDispatcher<Timer>::sharedTimerFired):
(WebCore::TaskDispatcher<Timer>::pendingDispatchers):
(WebCore::TaskDispatcher<Timer>::dispatchOneTask):
- platform/GenericTaskQueue.h:
(WebCore::TaskDispatcher<Timer>::TaskDispatcher): Deleted.
(WebCore::TaskDispatcher<Timer>::postTask): Deleted.
(WebCore::TaskDispatcher<Timer>::timerFired): Deleted.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::HTMLMediaElement):
(WebCore::HTMLMediaElement::~HTMLMediaElement):
(WebCore::HTMLMediaElement::scheduleResolvePendingPlayPromises):
(WebCore::HTMLMediaElement::rejectPendingPlayPromises):
(WebCore::HTMLMediaElement::resolvePendingPlayPromises):
(WebCore::HTMLMediaElement::scheduleNotifyAboutPlaying):
(WebCore::HTMLMediaElement::notifyAboutPlaying):
(WebCore::HTMLMediaElement::noneSupported):
(WebCore::HTMLMediaElement::cancelPendingEventsAndCallbacks):
(WebCore::HTMLMediaElement::setReadyState):
(WebCore::HTMLMediaElement::play):
(WebCore::HTMLMediaElement::playInternal):
(WebCore::HTMLMediaElement::pauseInternal):
(WebCore::HTMLMediaElement::contextDestroyed):
(WebCore::HTMLMediaElement::stop):
(WebCore::HTMLMediaElement::pauseAfterDetachedTask): Renamed from pauseAfterDetachedTimerFired.
(WebCore::HTMLMediaElement::removedFrom):
(WebCore::HTMLMediaElement::contextDestroyed):
- html/HTMLMediaElement.h:
- html/HTMLMediaElement.idl:
- CMakeLists.txt:
- WebCore.xcodeproj/project.pbxproj:
LayoutTests:
- media/media-play-promise-reject-error-notsupported-expected.txt: Added.
- media/media-play-promise-reject-error-notsupported.html: Added.
- media/media-play-promise-reject-load-abort-expected.txt: Added.
- media/media-play-promise-reject-load-abort.html: Added.
- media/media-play-promise-reject-pause-abort-expected.txt: Added.
- media/media-play-promise-reject-pause-abort.html: Added.
- media/media-play-promise-reject-play-notallowed-expected.txt: Added.
- media/media-play-promise-reject-play-notallowed.html: Added.
- media/media-play-promise-reject-play-notsupported-expected.txt: Added.
- media/media-play-promise-reject-play-notsupported.html: Added.
- media/media-play-promise-resolve-expected.txt: Added.
- media/media-play-promise-resolve-when-playing-expected.txt: Added.
- media/media-play-promise-resolve-when-playing.html: Added.
- media/media-play-promise-resolve.html: Added.
- 1:21 PM Changeset in webkit [200637] by
-
- 12 edits15 deletes in trunk
Unreviewed, rolling out r200627.
https://bugs.webkit.org/show_bug.cgi?id=157531
This change has caused crashes in existing LayoutTests
(Requested by ryanhaddad on #webkit).
Reverted changeset:
"Return a Promise from HTMLMediaElement.play()"
https://bugs.webkit.org/show_bug.cgi?id=157400
http://trac.webkit.org/changeset/200627
Patch by Commit Queue <commit-queue@webkit.org> on 2016-05-10
- 12:31 PM Changeset in webkit [200636] by
-
- 15 edits2 moves in trunk
Fix scrolling tree dumping
https://bugs.webkit.org/show_bug.cgi?id=157529
Reviewed by Tim Horton.
Source/WebCore:
Scrolling tree dumps cannot contain layerIDs because they are not stable between
runs. Fix by adding ScrollingStateTreeAsTextBehavior flags, and not dumping
the layerID for tests.
Sadly RemoteScrollingCoordinatorTransaction has a lot of duplicated code for dumping
the scrolling state tree, which should be converted to dumpProperties() at some point.
Fix the one test that suffered from this problem, and unskip it.
Test: fast/scrolling/ios/remove-scrolling-role.html
- page/scrolling/ScrollingStateFixedNode.cpp:
(WebCore::ScrollingStateFixedNode::dumpProperties):
- page/scrolling/ScrollingStateFixedNode.h:
- page/scrolling/ScrollingStateFrameScrollingNode.cpp:
(WebCore::ScrollingStateFrameScrollingNode::dumpProperties):
- page/scrolling/ScrollingStateFrameScrollingNode.h:
- page/scrolling/ScrollingStateNode.cpp:
(WebCore::ScrollingStateNode::dump):
(WebCore::ScrollingStateNode::scrollingStateTreeAsText):
- page/scrolling/ScrollingStateNode.h:
- page/scrolling/ScrollingStateOverflowScrollingNode.cpp:
(WebCore::ScrollingStateOverflowScrollingNode::dumpProperties):
- page/scrolling/ScrollingStateOverflowScrollingNode.h:
- page/scrolling/ScrollingStateScrollingNode.cpp:
(WebCore::ScrollingStateScrollingNode::dumpProperties):
- page/scrolling/ScrollingStateScrollingNode.h:
- page/scrolling/ScrollingStateStickyNode.cpp:
(WebCore::ScrollingStateStickyNode::dumpProperties):
- page/scrolling/ScrollingStateStickyNode.h:
LayoutTests:
- fast/scrolling/ios/remove-scrolling-role-expected.txt: Renamed from LayoutTests/platform/ios-simulator-wk2/scrolling/remove-scrolling-role-expected.txt.
- fast/scrolling/ios/remove-scrolling-role.html: Renamed from LayoutTests/platform/ios-simulator-wk2/scrolling/remove-scrolling-role.html.
- platform/ios-simulator-wk2/TestExpectations:
- 12:31 PM Changeset in webkit [200635] by
-
- 3 edits in trunk/LayoutTests
Mark fast/scrolling/ios/scroll-events-back-forward-after-pageshow.html as flakey.
- platform/ios-simulator-wk2/TestExpectations:
- platform/ios-simulator/TestExpectations:
- 12:16 PM Changeset in webkit [200634] by
-
- 11 edits2 adds in trunk
Web Inspector: Eliminate the crazy code for evaluateOnCallFrame
https://bugs.webkit.org/show_bug.cgi?id=157510
<rdar://problem/26191332>
Reviewed by Timothy Hatcher.
Source/JavaScriptCore:
- debugger/DebuggerCallFrame.cpp:
(JSC::DebuggerCallFrame::evaluateWithScopeExtension):
Set and clear an optional scope extension object.
- inspector/InjectedScriptSource.js:
(InjectedScript.prototype.evaluate):
(InjectedScript.prototype._evaluateOn):
(InjectedScript.prototype.evaluateOnCallFrame):
Unify the code to use the passed in evaluate function and object.
When evaluating on a call frame the evaluate function ends up being
DebuggerCallFrame::evaluateWithScopeExtension. When evaluating globally
this ends up being JSInjectedScriptHost::evaluateWithScopeExtension.
In both cases "object" is the preferred this object to use.
- debugger/DebuggerCallFrame.h:
- inspector/JSJavaScriptCallFrame.cpp:
(Inspector::JSJavaScriptCallFrame::evaluateWithScopeExtension):
(Inspector::JSJavaScriptCallFrame::evaluate): Deleted.
- inspector/JSJavaScriptCallFrame.h:
- inspector/JSJavaScriptCallFramePrototype.cpp:
(Inspector::JSJavaScriptCallFramePrototype::finishCreation):
(Inspector::jsJavaScriptCallFramePrototypeFunctionEvaluateWithScopeExtension):
- inspector/JavaScriptCallFrame.h:
(Inspector::JavaScriptCallFrame::evaluateWithScopeExtension):
(Inspector::JavaScriptCallFrame::evaluate): Deleted.
Pass through to DebuggerCallFrame with the proper arguments.
- debugger/Debugger.cpp:
(JSC::Debugger::hasBreakpoint):
- inspector/ScriptDebugServer.cpp:
(Inspector::ScriptDebugServer::evaluateBreakpointAction):
Use the new evaluate on call frame method name and no scope extension object.
LayoutTests:
- inspector/debugger/evaluateOnCallFrame-CommandLineAPI-expected.txt: Added.
- inspector/debugger/evaluateOnCallFrame-CommandLineAPI.html: Added.
- 12:08 PM Changeset in webkit [200633] by
-
- 2 edits in trunk/Source/WebCore
Fix the !ENABLE(CSS_REGIONS) build after r198990
https://bugs.webkit.org/show_bug.cgi?id=157516
Reviewed by Ryosuke Niwa.
- style/StyleTreeResolver.cpp:
(WebCore::Style::affectsRenderedSubtree):
- 11:56 AM Changeset in webkit [200632] by
-
- 2 edits in trunk/Source/JavaScriptCore
Make super-property-access.js test run for less time because it was timing out in debug builds.
Rubber stamped by Filip Pizlo.
- tests/stress/super-property-access.js:
(test):
(test.value):
(test.foo):
(test.B.prototype.bar):
(test.B):
- 11:34 AM Changeset in webkit [200631] by
-
- 4 edits in trunk/Source/WebKit2
Fix more deprecation warnings.
- NetworkProcess/EntryPoint/mac/XPCService/NetworkServiceEntryPoint.mm:
(NetworkServiceInitializer):
- PluginProcess/EntryPoint/mac/XPCService/PluginServiceEntryPoint.mm:
(PluginServiceInitializer):
- WebProcess/EntryPoint/mac/XPCService/WebContentServiceEntryPoint.mm:
(WebContentServiceInitializer):
- 10:45 AM Changeset in webkit [200630] by
-
- 2 edits in trunk/Source/WebKit2
[SpeculativeValidation] Do not start a preload if there is already one pending
https://bugs.webkit.org/show_bug.cgi?id=157522
<rdar://problem/26156083>
Reviewed by Alex Christensen.
Do not start a preload if there is already one pending. We failed to check in
SpeculativeLoadManager::preloadEntry() if there was already a pending preload.
As a result, we would sometimes cancel an already pending preload and start
one from scratch which is inefficient. It would also sometimes lead to hitting
an assertion in the SpeculativeLoad destructor because we could destroy the
SpeculativeLoad without finishing or cancelling the load.
- NetworkProcess/cache/NetworkCacheSpeculativeLoadManager.cpp:
(WebKit::NetworkCache::SpeculativeLoadManager::preloadEntry):
- 10:42 AM Changeset in webkit [200629] by
-
- 4 edits in trunk/Source/WebInspectorUI
Web Inspector: Cleanup super getter/setter now that underlying issue is fixed
https://bugs.webkit.org/show_bug.cgi?id=157488
<rdar://problem/26179120>
Patch by Devin Rousso <Devin Rousso> on 2016-05-10
Reviewed by Brian Burg.
Addressed FIXMEs for bug 147064:
<https://webkit.org/b/147064> Getter and setter on super are called with wrong "this" object
- UserInterface/Views/VisualStyleKeywordPicker.js:
(WebInspector.VisualStyleKeywordPicker.prototype.get value):
(WebInspector.VisualStyleKeywordPicker.prototype.set value):
(WebInspector.VisualStyleKeywordPicker.prototype.get synthesizedValue):
(WebInspector.VisualStyleKeywordPicker.prototype._getValue): Deleted.
(WebInspector.VisualStyleKeywordPicker.prototype._setValue): Deleted.
(WebInspector.VisualStyleKeywordPicker.prototype._generateSynthesizedValue): Deleted.
- UserInterface/Views/VisualStyleNumberInputBox.js:
(WebInspector.VisualStyleNumberInputBox.prototype.set specialPropertyPlaceholderElementText):
- UserInterface/Views/VisualStyleTimingEditor.js:
(WebInspector.VisualStyleTimingEditor.prototype.get value):
(WebInspector.VisualStyleTimingEditor.prototype.set value):
(WebInspector.VisualStyleTimingEditor.prototype.get synthesizedValue):
(WebInspector.VisualStyleTimingEditor.prototype._getValue): Deleted.
(WebInspector.VisualStyleTimingEditor.prototype._setValue): Deleted.
(WebInspector.VisualStyleTimingEditor.prototype._generateSynthesizedValue): Deleted.
- 10:32 AM Changeset in webkit [200628] by
-
- 2 edits in trunk/Source/WebKit2
Fix a deprecation warning.
- DatabaseProcess/EntryPoint/mac/XPCService/DatabaseServiceEntryPoint.mm:
(DatabaseServiceInitializer):
- 10:27 AM Changeset in webkit [200627] by
-
- 12 edits15 adds in trunk
Return a Promise from HTMLMediaElement.play()
https://bugs.webkit.org/show_bug.cgi?id=157400
Reviewed by Eric Carlson.
LayoutTests/imported/w3c:
Rebaseline web-platform-tests/html/dom/interfaces-expected.txt with new (failing) result.
- web-platform-tests/html/dom/interfaces-expected.txt:
Source/WebCore:
Tests: media/media-play-promise-reject-error-notsupported.html
media/media-play-promise-reject-load-abort.html
media/media-play-promise-reject-pause-abort.html
media/media-play-promise-reject-play-notallowed.html
media/media-play-promise-reject-play-notsupported.html
media/media-play-promise-resolve-when-playing.html
media/media-play-promise-resolve.html
The HTML Living Standard Spec <https://html.spec.whatwg.org/multipage/embedded-content.html>
(5 May 2016) adds support for a Promise to be returned by the play() method, to be resolved
or rejected at defined points during loading and playback.
Add utility methods which encapsulate the definitions of the equivalent algorithms from the
HTML Spec. Add a new, overloaded play() method on HTMLMediaElement which takes a DeferredWrapper
reference.
After the change to use scheduleNotifyAboutPlaying() instead of enqueueing the "playing" event
directly, we must ensure that the notifyAboutPlaying() task does not get fired before the
"play" event preceeding it does. So re-implement GenericEventQueue (which previously used
a timer to dispatch events) to use a GenericTaskQueue instead. This ensures that all tasks and
events are interleaved in the order in which they were enqueued.
Additionally, the new pauseAfterDetachedTimerFired() event was firing out of microtask order, which
broke some W3C tests after the changes to GenericEventQueue. Move GenericEventQueue and
GenericTaskQueue to the same timing source (namely, a WebCore Timer) and interleave Events
and Tasks by having GenericEventQueue use GenericTaskQueue to issue its Events. Because
Document::postTask() cannot ensure ordering with Timer-based events, switch HTMLMediaElement
over to Timer-backed GenericTaskQueues.
- dom/GenericEventQueue.cpp:
(WebCore::GenericEventQueue::GenericEventQueue):
(WebCore::GenericEventQueue::enqueueEvent):
(WebCore::GenericEventQueue::close):
(WebCore::GenericEventQueue::cancelAllEvents):
(WebCore::GenericEventQueue::suspend):
(WebCore::GenericEventQueue::resume):
(WebCore::GenericEventQueue::sharedTimer): Deleted.
(WebCore::GenericEventQueue::sharedTimerFired): Deleted.
(WebCore::GenericEventQueue::pendingQueues): Deleted.
- dom/GenericEventQueue.h:
- platform/GenericTaskQueue.cpp: Added.
(WebCore::TaskDispatcher<Timer>::~TaskDispatcher):
(WebCore::TaskDispatcher<Timer>::postTask):
(WebCore::TaskDispatcher<Timer>::sharedTimer):
(WebCore::TaskDispatcher<Timer>::sharedTimerFired):
(WebCore::TaskDispatcher<Timer>::pendingDispatchers):
(WebCore::TaskDispatcher<Timer>::dispatchOneTask):
- platform/GenericTaskQueue.h:
(WebCore::TaskDispatcher<Timer>::TaskDispatcher): Deleted.
(WebCore::TaskDispatcher<Timer>::postTask): Deleted.
(WebCore::TaskDispatcher<Timer>::timerFired): Deleted.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::HTMLMediaElement):
(WebCore::HTMLMediaElement::~HTMLMediaElement):
(WebCore::HTMLMediaElement::scheduleResolvePendingPlayPromises):
(WebCore::HTMLMediaElement::rejectPendingPlayPromises):
(WebCore::HTMLMediaElement::resolvePendingPlayPromises):
(WebCore::HTMLMediaElement::scheduleNotifyAboutPlaying):
(WebCore::HTMLMediaElement::notifyAboutPlaying):
(WebCore::HTMLMediaElement::noneSupported):
(WebCore::HTMLMediaElement::cancelPendingEventsAndCallbacks):
(WebCore::HTMLMediaElement::setReadyState):
(WebCore::HTMLMediaElement::play):
(WebCore::HTMLMediaElement::playInternal):
(WebCore::HTMLMediaElement::pauseInternal):
(WebCore::HTMLMediaElement::contextDestroyed):
(WebCore::HTMLMediaElement::stop):
(WebCore::HTMLMediaElement::pauseAfterDetachedTask): Renamed from pauseAfterDetachedTimerFired.
(WebCore::HTMLMediaElement::removedFrom):
(WebCore::HTMLMediaElement::contextDestroyed):
- html/HTMLMediaElement.h:
- html/HTMLMediaElement.idl:
- CMakeLists.txt:
- WebCore.xcodeproj/project.pbxproj:
LayoutTests:
- media/media-play-promise-reject-error-notsupported-expected.txt: Added.
- media/media-play-promise-reject-error-notsupported.html: Added.
- media/media-play-promise-reject-load-abort-expected.txt: Added.
- media/media-play-promise-reject-load-abort.html: Added.
- media/media-play-promise-reject-pause-abort-expected.txt: Added.
- media/media-play-promise-reject-pause-abort.html: Added.
- media/media-play-promise-reject-play-notallowed-expected.txt: Added.
- media/media-play-promise-reject-play-notallowed.html: Added.
- media/media-play-promise-reject-play-notsupported-expected.txt: Added.
- media/media-play-promise-reject-play-notsupported.html: Added.
- media/media-play-promise-resolve-expected.txt: Added.
- media/media-play-promise-resolve-when-playing-expected.txt: Added.
- media/media-play-promise-resolve-when-playing.html: Added.
- media/media-play-promise-resolve.html: Added.
- 10:23 AM Changeset in webkit [200626] by
-
- 90 edits in trunk/Source
Get rid of a lot of calls to RefPtr::release()
https://bugs.webkit.org/show_bug.cgi?id=157505
Reviewed by Alex Christensen.
Get rid of a lot of calls to RefPtr::release() and use WTFMove() instead.
Source/WebCore:
- Modules/encryptedmedia/MediaKeySession.cpp:
(WebCore::MediaKeySession::addKeyTimerFired):
(WebCore::MediaKeySession::sendMessage):
(WebCore::MediaKeySession::sendError):
- Modules/geolocation/Geolocation.cpp:
(WebCore::createGeoposition):
- Modules/indexeddb/DOMWindowIndexedDatabase.cpp:
(WebCore::DOMWindowIndexedDatabase::disconnectFrameForDocumentSuspension):
(WebCore::DOMWindowIndexedDatabase::reconnectFrameFromDocumentSuspension):
- Modules/indexeddb/IDBKey.h:
(WebCore::IDBKey::createMultiEntryArray):
- Modules/mediasource/MediaSource.cpp:
(WebCore::MediaSource::scheduleEvent):
- Modules/mediasource/SourceBuffer.cpp:
(WebCore::SourceBuffer::scheduleEvent):
- Modules/mediasource/SourceBufferList.cpp:
(WebCore::SourceBufferList::scheduleEvent):
- Modules/notifications/DOMWindowNotifications.cpp:
(WebCore::DOMWindowNotifications::disconnectFrameForDocumentSuspension):
(WebCore::DOMWindowNotifications::reconnectFrameFromDocumentSuspension):
- Modules/webdatabase/DatabaseManager.cpp:
(WebCore::DatabaseManager::openDatabaseBackend):
- Modules/webdatabase/DatabaseManager.h:
- Modules/webdatabase/SQLCallbackWrapper.h:
(WebCore::SQLCallbackWrapper::unwrap):
- Modules/websockets/WebSocketChannel.cpp:
(WebCore::WebSocketChannel::enqueueTextFrame):
(WebCore::WebSocketChannel::enqueueRawFrame):
(WebCore::WebSocketChannel::enqueueBlobFrame):
(WebCore::WebSocketChannel::processOutgoingFrameQueue):
- bindings/js/JSBlobCustom.cpp:
(WebCore::constructJSBlob):
- bindings/js/JSGeolocationCustom.cpp:
(WebCore::createPositionOptions):
(WebCore::JSGeolocation::getCurrentPosition):
(WebCore::JSGeolocation::watchPosition):
- bindings/js/JSMessagePortCustom.cpp:
(WebCore::fillMessagePortArray):
- bindings/js/JSSQLTransactionCustom.cpp:
(WebCore::JSSQLTransaction::executeSql):
- bindings/js/ScriptControllerMac.mm:
(WebCore::ScriptController::createScriptInstanceForWidget):
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateCallWith):
- crypto/mac/CryptoKeyRSAMac.cpp:
(WebCore::CryptoKeyRSA::generatePair):
- css/CSSBasicShapes.cpp:
(WebCore::buildSerializablePositionOffset):
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::valueForNinePieceImageRepeat):
(WebCore::counterToCSSValue):
(WebCore::ComputedStyleExtractor::propertyValue):
- css/CSSContentDistributionValue.cpp:
(WebCore::CSSContentDistributionValue::customCSSText):
- css/CSSFilterImageValue.cpp:
(WebCore::CSSFilterImageValue::image):
- css/CSSFilterImageValue.h:
- css/CSSGrammar.y.in:
- css/CSSNamedImageValue.cpp:
(WebCore::CSSNamedImageValue::image):
- css/CSSNamedImageValue.h:
- css/CSSParser.cpp:
(WebCore::CSSParser::parseFillProperty):
(WebCore::CSSParser::parseAnimationProperty):
(WebCore::CSSParser::parseInsetRoundedCorners):
(WebCore::ShadowParseContext::commitLength):
(WebCore::CSSParser::parseShadow):
(WebCore::BorderImageSliceParseContext::commitNumber):
(WebCore::BorderImageQuadParseContext::commitNumber):
(WebCore::CSSParser::parseBorderRadius):
(WebCore::CSSParser::parseCounter):
(WebCore::CSSParser::parseDeprecatedGradient):
(WebCore::CSSParser::parseDeprecatedLinearGradient):
(WebCore::CSSParser::parseDeprecatedRadialGradient):
(WebCore::CSSParser::parseLinearGradient):
(WebCore::CSSParser::parseRadialGradient):
(WebCore::CSSParser::parseTransformValue):
(WebCore::CSSParser::parseBuiltinFilterArguments):
(WebCore::CSSParser::parseTextIndent):
(WebCore::CSSParser::popRuleData):
(WebCore::CSSParser::markRuleHeaderStart):
(WebCore::CSSParser::createViewportRule):
- css/CSSParser.h:
- css/CSSParserValues.cpp:
(WebCore::CSSParserValue::createCSSValue):
- css/CSSParserValues.h:
- css/CSSValueList.cpp:
(WebCore::CSSValueList::copy):
- css/CSSValueList.h:
- css/SVGCSSComputedStyleDeclaration.cpp:
(WebCore::ComputedStyleExtractor::svgPropertyValue):
- css/StyleBuilderConverter.h:
(WebCore::StyleBuilderConverter::convertClipPath):
(WebCore::StyleBuilderConverter::convertReflection):
- css/StyleResolver.cpp:
(WebCore::StyleResolver::cachedOrPendingFromValue):
(WebCore::StyleResolver::setOrPendingFromValue):
(WebCore::StyleResolver::cursorOrPendingFromValue):
- css/StyleResolver.h:
- css/StyleRule.cpp:
(WebCore::StyleRuleBase::createCSSOMWrapper):
- css/StyleRule.h:
- dom/Attr.cpp:
(WebCore::Attr::create):
- dom/Attr.h:
- dom/ContainerNode.h:
(WebCore::ChildNodesLazySnapshot::nextNode):
- dom/Document.cpp:
(WebCore::Document::setFocusedElement):
(WebCore::Document::takeDOMWindowFrom):
(WebCore::Document::updateHoverActiveState):
- dom/Element.cpp:
(WebCore::Element::detachAttribute):
(WebCore::Element::setAttributeNodeNS):
(WebCore::Element::ensureAttr):
- dom/Element.h:
- dom/MessagePort.cpp:
(WebCore::MessagePort::dispatchMessages):
(WebCore::MessagePort::entanglePorts):
- dom/NodeIterator.cpp:
(WebCore::NodeIterator::nextNode):
(WebCore::NodeIterator::previousNode):
- dom/Range.cpp:
(WebCore::Range::processContentsBetweenOffsets):
- dom/StyledElement.cpp:
(WebCore::StyledElement::rebuildPresentationAttributeStyle):
- editing/ApplyBlockElementCommand.cpp:
(WebCore::ApplyBlockElementCommand::createBlockElement):
- editing/ApplyBlockElementCommand.h:
- editing/ApplyStyleCommand.cpp:
(WebCore::ApplyStyleCommand::applyRelativeFontStyleChange):
- editing/CompositeEditCommand.cpp:
(WebCore::CompositeEditCommand::applyCommandToComposite):
(WebCore::CompositeEditCommand::appendBlockPlaceholder):
(WebCore::CompositeEditCommand::insertBlockPlaceholder):
(WebCore::CompositeEditCommand::addBlockPlaceholderIfNeeded):
(WebCore::CompositeEditCommand::insertNewDefaultParagraphElementAt):
(WebCore::CompositeEditCommand::moveParagraphContentsToNewBlockIfNecessary):
(WebCore::CompositeEditCommand::cloneParagraphUnderNewElement):
(WebCore::CompositeEditCommand::moveParagraphs):
- editing/CompositeEditCommand.h:
- editing/EditingStyle.cpp:
(WebCore::EditingStyle::wrappingStyleForSerialization):
(WebCore::styleFromMatchedRulesForElement):
(WebCore::extractPropertiesNotIn):
(WebCore::backgroundColorInEffect):
- editing/EditingStyle.h:
- editing/Editor.cpp:
(WebCore::Editor::increaseSelectionListLevel):
(WebCore::Editor::increaseSelectionListLevelOrdered):
(WebCore::Editor::increaseSelectionListLevelUnordered):
(WebCore::Editor::findStringAndScrollToVisible):
(WebCore::Editor::rangeOfString):
- editing/Editor.h:
- editing/InsertParagraphSeparatorCommand.cpp:
(WebCore::InsertParagraphSeparatorCommand::cloneHierarchyUnderNewBlock):
- editing/InsertParagraphSeparatorCommand.h:
- editing/MergeIdenticalElementsCommand.cpp:
(WebCore::MergeIdenticalElementsCommand::doUnapply):
- editing/ModifySelectionListLevel.cpp:
(WebCore::IncreaseSelectionListLevelCommand::doApply):
(WebCore::IncreaseSelectionListLevelCommand::increaseSelectionListLevel):
- editing/ModifySelectionListLevel.h:
- editing/RemoveNodeCommand.cpp:
(WebCore::RemoveNodeCommand::doUnapply):
- editing/RemoveNodePreservingChildrenCommand.cpp:
(WebCore::RemoveNodePreservingChildrenCommand::doApply):
- editing/ReplaceSelectionCommand.cpp:
(WebCore::ReplacementFragment::insertFragmentForTestRendering):
- editing/SpellingCorrectionCommand.cpp:
(WebCore::SpellingCorrectionCommand::doApply):
- editing/mac/DictionaryLookup.h:
- editing/mac/DictionaryLookup.mm:
(WebCore::DictionaryLookup::rangeForSelection):
(WebCore::DictionaryLookup::rangeAtHitTestResult):
- html/HTMLFormElement.cpp:
(WebCore::HTMLFormElement::finishRequestAutocomplete):
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::scheduleEvent):
(WebCore::HTMLMediaElement::updateActiveTextTrackCues):
(WebCore::HTMLMediaElement::mediaPlayerKeyNeeded):
(WebCore::HTMLMediaElement::addTextTrack):
(WebCore::HTMLMediaElement::enqueuePlaybackTargetAvailabilityChangedEvent):
- html/HTMLMediaElement.h:
- html/canvas/OESVertexArrayObject.cpp:
(WebCore::OESVertexArrayObject::createVertexArrayOES):
- html/canvas/OESVertexArrayObject.h:
- html/canvas/WebGLRenderingContextBase.cpp:
(WebCore::WebGLRenderingContextBase::getContextAttributes):
- html/canvas/WebGLRenderingContextBase.h:
- html/track/VTTCue.cpp:
(WebCore::VTTCue::getCueAsHTML):
(WebCore::VTTCue::createCueRenderingTree):
- html/track/VTTCue.h:
- html/track/WebVTTElement.cpp:
(WebCore::WebVTTElement::createEquivalentHTMLElement):
- html/track/WebVTTElement.h:
- html/track/WebVTTParser.cpp:
(WebCore::WebVTTTreeBuilder::buildFromString):
(WebCore::WebVTTParser::createDocumentFragmentFromCueText):
- html/track/WebVTTParser.h:
Source/WTF:
- wtf/text/AtomicStringImpl.cpp:
(WTF::HashAndUTF8CharactersTranslator::translate):
- wtf/text/CString.cpp:
(WTF::CString::copyBufferIfNeeded):
- wtf/text/StringBuilder.cpp:
(WTF::StringBuilder::allocateBuffer):
(WTF::StringBuilder::allocateBufferUpConvert):
(WTF::StringBuilder::shrinkToFit):
- wtf/text/WTFString.cpp:
(WTF::String::append):
(WTF::String::insert):
(WTF::String::removeInternal):
- wtf/text/WTFString.h:
(WTF::String::String):
(WTF::String::operator=):
(WTF::String::releaseImpl):
(WTF::String::isNull): Deleted.
- 10:05 AM Changeset in webkit [200625] by
-
- 3 edits in trunk/Source/WebCore
Allow some leeway after page load before throttling, to allow post load events to complete.
https://bugs.webkit.org/show_bug.cgi?id=157499
Reviewed by Ryosuke Niwa
- page/PageThrottler.cpp:
(WebCore::PageThrottler::PageThrottler):
- m_pageLoadActivityCounter now affects activity state indirecty, via m_pageLoadActivityHysteresis.
(WebCore::PageThrottler::pageLoadActivityCounterChanged):
- counter updates hysteresis object, which in turn will affect activity state.
- page/PageThrottler.h:
- added m_pageLoadActivityHysteresis, pageLoadActivityCounterChanged.
- 10:05 AM Changeset in webkit [200624] by
-
- 2 edits in trunk/Source/WebKit2
Clicks do not work in Safari after pressing the Track package button in Gmail
https://bugs.webkit.org/show_bug.cgi?id=157508
<rdar://problem/22646404>
Reviewed by Anders Carlsson.
- UIProcess/Cocoa/WebViewImpl.mm:
(WebKit::WebViewImpl::viewDidMoveToWindow):
Explicitly cancel the force-click animation when we're removing the gesture
recognizer due to the WK*View being unparented. This works around a bug
where we don't get the cancellation callback in this situation, causing
Safari to be left in an inconsistent and unexpected state.
- 9:34 AM Changeset in webkit [200623] by
-
- 2 edits in trunk/Source/JavaScriptCore
[JSC] Fix the !ENABLE(DFG_JIT) build
https://bugs.webkit.org/show_bug.cgi?id=157512
Reviewed by Mark Lam.
- jit/Repatch.cpp:
- 8:27 AM Changeset in webkit [200622] by
-
- 6 edits2 adds in trunk
REGRESSION (r193610): Drop down menu doesn’t expand at allofbach.com
https://bugs.webkit.org/show_bug.cgi?id=157445
Reviewed by Simon Fraser.
When we don't run transitions (becasuse of to/from 'auto' values) we should also not
report the 'from' value and behave as if we finished the transition already.
Source/WebCore:
Test: fast/animation/height-auto-transition-computed-value.html
- page/animation/KeyframeAnimation.cpp:
(WebCore::KeyframeAnimation::fetchIntervalEndpointsForProperty): This is a revert of
looping the 'to' value back to the first keyframe when reverse animation is at the start value (last keyframe).
- platform/Length.cpp:
(WebCore::blend):
LayoutTests:
- fast/animation/height-auto-transition-computed-value-expected.html: Added.
- fast/animation/height-auto-transition-computed-value.html: Added.
- imported/blink/transitions/transition-not-interpolable-expected.txt:
- 7:56 AM Changeset in webkit [200621] by
-
- 20 edits7 deletes in trunk
[Linux] Remove seccomp filters support
https://bugs.webkit.org/show_bug.cgi?id=157380
Reviewed by Darin Adler.
.:
- Source/cmake/FindLibSeccomp.cmake: Removed.
- Source/cmake/OptionsEfl.cmake:
- Source/cmake/OptionsGTK.cmake:
- Source/cmake/WebKitFeatures.cmake:
Source/WebKit2:
- NetworkProcess/NetworkProcessCreationParameters.cpp:
(WebKit::NetworkProcessCreationParameters::encode): Deleted.
(WebKit::NetworkProcessCreationParameters::decode): Deleted.
- NetworkProcess/NetworkProcessCreationParameters.h:
- PlatformEfl.cmake:
- PlatformGTK.cmake:
- Shared/WebProcessCreationParameters.cpp:
(WebKit::WebProcessCreationParameters::encode): Deleted.
(WebKit::WebProcessCreationParameters::decode): Deleted.
- Shared/WebProcessCreationParameters.h:
- Shared/linux/SeccompFilters/OpenSyscall.cpp: Removed.
- Shared/linux/SeccompFilters/OpenSyscall.h: Removed.
- Shared/linux/SeccompFilters/SeccompBroker.cpp: Removed.
- Shared/linux/SeccompFilters/SeccompBroker.h: Removed.
- Shared/linux/SeccompFilters/SeccompFilters.cpp: Removed.
- Shared/linux/SeccompFilters/SeccompFilters.h: Removed.
- Shared/linux/SeccompFilters/SigactionSyscall.cpp: Removed.
- Shared/linux/SeccompFilters/SigactionSyscall.h: Removed.
- Shared/linux/SeccompFilters/SigprocmaskSyscall.cpp: Removed.
- Shared/linux/SeccompFilters/SigprocmaskSyscall.h: Removed.
- Shared/linux/SeccompFilters/Syscall.cpp: Removed.
- Shared/linux/SeccompFilters/Syscall.h: Removed.
- Shared/linux/SeccompFilters/SyscallPolicy.cpp: Removed.
- Shared/linux/SeccompFilters/SyscallPolicy.h: Removed.
- Shared/linux/SeccompFilters/XDGBaseDirectory.h: Removed.
- Shared/linux/SeccompFilters/XDGBaseDirectoryGLib.cpp: Removed.
- UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::ensureNetworkProcess): Deleted.
(WebKit::WebProcessPool::createNewWebProcess): Deleted.
(WebKit::WebProcessPool::cookieStorageDirectory): Deleted.
- UIProcess/WebProcessPool.h:
- WebProcess/efl/SeccompFiltersWebProcessEfl.cpp: Removed.
- WebProcess/efl/SeccompFiltersWebProcessEfl.h: Removed.
- WebProcess/gtk/SeccompFiltersWebProcessGtk.cpp: Removed.
- WebProcess/gtk/SeccompFiltersWebProcessGtk.h: Removed.
- WebProcess/soup/WebProcessSoup.cpp:
(WebKit::WebProcess::platformInitializeWebProcess): Deleted.
Tools:
- Scripts/webkitperl/FeatureList.pm:
- TestWebKitAPI/PlatformEfl.cmake:
- TestWebKitAPI/PlatformGTK.cmake:
- TestWebKitAPI/Tests/WebKit2/SeccompFilters.cpp: Removed.
- efl/jhbuild.modules:
- gtk/jhbuild.modules:
- 4:41 AM Changeset in webkit [200620] by
-
- 10 edits in trunk
[iOS] <select> elements should render right-aligned when in RTL mode
https://bugs.webkit.org/show_bug.cgi?id=157501
<rdar://problem/26187870>
Reviewed by Antoine Quint.
Source/WebCore:
This is the equivalent of http://webkit.org/b/157112 for iOS.
Handle <select> elements when we're in RTL mode. This means
drawing the button with the drop-down arrow on the left
side, and the button text right-aligned.
Test: fast/forms/select-non-native-rendering-direction.html
plus a bunch of other ones that needed rebaselining.
- rendering/RenderThemeIOS.mm: Rename MenuListButtonPaddingRight to MenuListButtonPaddingAfter.
(WebCore::RenderThemeIOS::popupInternalPaddingBox): Handle both directions.
(WebCore::adjustInputElementButtonStyle):
(WebCore::RenderThemeIOS::paintMenuListButtonDecorations): Handle drawing in
RTL mode.
LayoutTests:
Rebaseline now that iOS is doing the right thing.
- platform/ios-simulator/fast/forms/select-non-native-rendering-direction-expected.txt:
- platform/ios-simulator/fast/forms/listbox-bidi-align-expected.txt:
- platform/ios-simulator/fast/forms/select-writing-direction-natural-expected.txt:
- platform/ios-simulator/fast/text/international/bidi-listbox-atsui-expected.txt:
- platform/ios-simulator/fast/text/international/bidi-listbox-expected.txt:
- platform/ios-simulator/fast/text/international/bidi-menulist-expected.txt:
- platform/ios-simulator/fast/text/international/pop-up-button-text-alignment-and-direction-expected.txt:
- 2:47 AM Changeset in webkit [200619] by
-
- 17 edits2 adds in trunk
NodeList should be iterable
https://bugs.webkit.org/show_bug.cgi?id=131443
<rdar://problem/25731519>
Reviewed by Darin Adler.
Source/WebCore:
Test: fast/dom/nodeListIterator.html
Updating JSKeyValueIterator to support map and set iterators,
depending on the signature of the result type of DOMClass::Iterator::next method.
Symbol.iterator method is made the same as values method for set iterators.
Adding support for NodeList.
Updating FontFaceSet to take benefit of that.
- bindings/js/JSDOMBinding.h:
(WebCore::jsPair):.
- bindings/js/JSKeyValueIterator.h:
(WebCore::IteratorInspector::decltype): IteratorInspector detects whether the iterator is a set or map iterator.
(WebCore::IteratorInspector::test):
(WebCore::fillForEachArgumentsWithIteratorValue): Specializing according set/map iterator.
(WebCore::iteratorValueToJS): Ditto.
(WebCore::keyValueIteratorForEach):
(WebCore::JSKeyValueIterator<JSWrapper>::next):
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateImplementationIterableFunctions): Removed the line forbidding set iterators.
Making Symbol.iterator function equal to values for set iterators.
- bindings/scripts/test/JS/JSTestNode.cpp: Rebasing with set iterator functions.
- bindings/scripts/test/JS/JSTestObj.cpp: Rebasing according updated function names.
- bindings/scripts/test/TestNode.idl: Making TestNode set iterable.
- css/FontFaceSet.cpp:
(WebCore::FontFaceSet::Iterator::next): Refactoring to make it a set iterator.
- css/FontFaceSet.h:
- css/FontFaceSet.idl:
- dom/NodeList.h: Making NodeList iterable.
(WebCore::NodeList::Iterator::Iterator):
(WebCore::NodeList::Iterator::next):
(WebCore::NodeList::createIterator):
- dom/NodeList.idl:
LayoutTests:
- fast/dom/domListEnumeration-expected.txt:
- fast/dom/nodeListIterator-expected.txt: Added.
- fast/dom/nodeListIterator.html: Added.
- fast/dom/script-tests/domListEnumeration.js:
- fast/text/font-face-set-javascript-expected.txt:
- fast/text/font-face-set-javascript.html:
- 12:46 AM Changeset in webkit [200618] by
-
- 8 edits17 adds in trunk
[css-grid] Implement auto-repeat computation
https://bugs.webkit.org/show_bug.cgi?id=157473
Reviewed by Darin Adler.
Source/WebCore:
We added support for parsing and style for the new auto-repeat syntax. This patch actually
implements the feature by computing the number of auto-repeat tracks that will be part of
the explicit grid depending on the available size on the corresponding axis.
Note that we still do not drop the empty tracks, i.e., auto-fit will work exactly as
auto-fill until the empty track removal is implemented.
Some test results are not totally correct yet because we need to add the line names to the
computed style. As that requires a rather large piece of code it will be done in a follow up
patch. Track sizes are correct though.
Tests: fast/css-grid-layout/grid-auto-fill-columns.html
fast/css-grid-layout/grid-auto-fill-rows.html
fast/css-grid-layout/grid-change-auto-repeat-tracks.html
fast/css-grid-layout/mozilla/grid-repeat-auto-fill-fit-001.html
fast/css-grid-layout/mozilla/grid-repeat-auto-fill-fit-002.html
fast/css-grid-layout/mozilla/grid-repeat-auto-fill-fit-003.html
fast/css-grid-layout/mozilla/grid-repeat-auto-fill-fit-004.html
fast/css-grid-layout/mozilla/grid-repeat-auto-fill-fit-005.html
- css/CSSParser.cpp:
(WebCore::CSSParser::parseGridTrackRepeatFunction): Add the CSSAutoRepeatValue directly
instead of adding the track size.
- css/StyleBuilderCustom.h: Store the insertion point in style.
- rendering/RenderGrid.cpp:
(WebCore::RenderGrid::guttersSize): Replaced size_t by unsigned.
(WebCore::RenderGrid::rawGridTrackSize): New function which retrieves the track size from
either explicit (including auto-repeat tracks) or implicit tracks.
(WebCore::RenderGrid::gridTrackSize): Use rawGridTrackSize().
(WebCore::RenderGrid::computeAutoRepeatTracksCount): This is the core of the patch. This
method computes the number of auto-repeat tracks that fits on the available size for a given
axis (or 1 if that's indefinite).
- rendering/RenderGrid.h:
LayoutTests:
Apart from some home made tests I'm importing 5 patches from Mozilla's test suite as they
perfectly test the behavior of auto-repeat with positioned items. I've commented auto-fit
tests as that feature isn't implemented yet.
- fast/css-grid-layout/grid-auto-fill-columns-expected.txt: Added.
- fast/css-grid-layout/grid-auto-fill-columns.html: Added.
- fast/css-grid-layout/grid-auto-fill-rows-expected.txt: Added.
- fast/css-grid-layout/grid-auto-fill-rows.html: Added.
- fast/css-grid-layout/grid-change-auto-repeat-tracks-expected.txt: Added.
- fast/css-grid-layout/grid-change-auto-repeat-tracks.html: Added.
- fast/css-grid-layout/grid-element-auto-repeat-get-set-expected.txt:
- fast/css-grid-layout/grid-element-auto-repeat-get-set.html:
- fast/css-grid-layout/mozilla/grid-repeat-auto-fill-fit-001-expected.html: Added.
- fast/css-grid-layout/mozilla/grid-repeat-auto-fill-fit-001.html: Added.
- fast/css-grid-layout/mozilla/grid-repeat-auto-fill-fit-002-expected.html: Added.
- fast/css-grid-layout/mozilla/grid-repeat-auto-fill-fit-002.html: Added.
- fast/css-grid-layout/mozilla/grid-repeat-auto-fill-fit-003-expected.html: Added.
- fast/css-grid-layout/mozilla/grid-repeat-auto-fill-fit-003.html: Added.
- fast/css-grid-layout/mozilla/grid-repeat-auto-fill-fit-004-expected.html: Added.
- fast/css-grid-layout/mozilla/grid-repeat-auto-fill-fit-004.html: Added.
- fast/css-grid-layout/mozilla/grid-repeat-auto-fill-fit-005-expected.html: Added.
- fast/css-grid-layout/mozilla/grid-repeat-auto-fill-fit-005.html: Added.
May 9, 2016:
- 11:36 PM Changeset in webkit [200617] by
-
- 3 edits2 adds in trunk
Web Inspector: CRASH under JSC::DebuggerCallFrame::thisValue when hitting breakpoint
https://bugs.webkit.org/show_bug.cgi?id=157442
<rdar://problem/24172015>
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-05-09
Reviewed by Saam Barati.
Source/JavaScriptCore:
- debugger/DebuggerCallFrame.cpp:
(JSC::DebuggerCallFrame::thisValueForCallFrame):
When the thisValue is JSValue() return undefined and avoid calling
toThisValue which would lead to a crash. Havingthisbe an empty
JSValue could happen inside an ES6 class constructor, before
calling super.
LayoutTests:
- inspector/debugger/break-in-constructor-before-super-expected.txt: Added.
- inspector/debugger/break-in-constructor-before-super.html: Added.
- 11:07 PM Changeset in webkit [200616] by
-
- 1 copy in branches/safari-601.6-branch
New Branch.
- 11:03 PM Changeset in webkit [200615] by
-
- 1 copy in branches/safari-601.1.46.128-branch
New Branch.
- 10:04 PM Changeset in webkit [200614] by
-
- 2 edits in trunk/Source/WebCore
Fix GTK build after r200607
- Modules/notifications/Notification.h:
dir and replaceId are used in WebNotificationManager with NOTIFICATIONS and with LEGACY_NOTIFICATIONS
- 9:58 PM Changeset in webkit [200613] by
-
- 3 edits in trunk/Source/JavaScriptCore
Unreviewed, fix cloop.
- bytecode/ValueProfile.cpp:
(JSC::ResultProfile::emitDetectNumericness):
(JSC::ResultProfile::emitSetNonNumber):
- bytecode/ValueProfile.h:
(JSC::ResultProfile::addressOfFlags):
(JSC::ResultProfile::addressOfSpecialFastPathCount):
(JSC::ResultProfile::detectNumericness):
(JSC::ResultProfile::hasBits):
- 9:52 PM Changeset in webkit [200612] by
-
- 5 edits in trunk/Source/WebCore
Fix the Windows build after r200602, and do some minor tidyup.
- platform/graphics/ca/PlatformCALayer.h:
- platform/graphics/ca/cocoa/PlatformCALayerCocoa.mm:
(PlatformCALayerCocoa::contentsHidden):
- platform/graphics/ca/win/PlatformCALayerWin.cpp:
(PlatformCALayerWin::contentsHidden):
(PlatformCALayerWin::setContentsHidden):
- platform/graphics/ca/win/PlatformCALayerWin.h:
- 8:40 PM Changeset in webkit [200611] by
-
- 7 edits in trunk/Source/WebKit2
REGRESSION (r191922): Zoom in/Zoom Out is not working for PDFs
https://bugs.webkit.org/show_bug.cgi?id=157503
<rdar://problem/23736297>
Reviewed by Anders Carlsson.
- WebProcess/Plugins/PDF/DeprecatedPDFPlugin.h:
Restore a requiresUnifiedScaleFactor that was lost in r191922.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didCommitLoadForFrame):
(WebKit::WebPageProxy::mainFramePluginHandlesPageScaleGestureDidChange):
- UIProcess/WebPageProxy.h:
- UIProcess/WebPageProxy.messages.in:
- WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::didInitializePlugin):
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::dispatchDidCommitLoad):
Separate mainFramePluginHandlesPageScaleGesture changes out from didCommitLoadForFrame,
because the PluginView doesn't exist at this point, so it can't answer
the handlesPageScaleGesture question correctly (or at all).
Instead, we'll send the message when the main-frame PluginView is initialized.
- 8:22 PM Changeset in webkit [200610] by
-
- 2 edits in trunk/Source/JavaScriptCore
Crash beneath ObjCCallbackFunctionImpl::call
https://bugs.webkit.org/show_bug.cgi?id=157491
Reviewed by Saam Barati.
Clear any exceptions after the micro task runs.
Tried creating a test case, but I don't have source for the app.
I can't seem to find the right combination of Promises and ObjC code.
- runtime/JSJob.cpp:
(JSC::JSJobMicrotask::run):
- 7:55 PM Changeset in webkit [200609] by
-
- 6 edits7 copies41 moves6 adds in trunk/LayoutTests
iOS-scrolling test cleanup.
Move iOS scrolling tests from platform/ios-simulator/fast/scrolling/ios to fast/scrolling/ios/.
Rebaseline those that need it. Enable some in iOS WK1 if they pass.
Try to make fast/scrolling/ios/touch-scroll-visibility-hidden.html not flakey
- fast/scrolling/ios/clipping-ancestor-with-accelerated-scrolling-ancestor-expected.txt: Copied from LayoutTests/platform/ios-simulator/ios/scrolling/clipping-ancestor-with-accelerated-scrolling-ancestor-expected.txt.
- fast/scrolling/ios/clipping-ancestor-with-accelerated-scrolling-ancestor.html: Renamed from LayoutTests/platform/ios-simulator/ios/scrolling/clipping-ancestor-with-accelerated-scrolling-ancestor.html.
- fast/scrolling/ios/iframe-inside-overflow-clipping-expected.txt: Renamed from LayoutTests/platform/ios-simulator/ios/scrolling/iframe-inside-overflow-clipping-expected.txt.
- fast/scrolling/ios/iframe-inside-overflow-clipping.html: Renamed from LayoutTests/platform/ios-simulator/ios/scrolling/iframe-inside-overflow-clipping.html.
- fast/scrolling/ios/overflow-clip-with-accelerated-scrolling-ancestor-expected.html: Renamed from LayoutTests/platform/ios-simulator/ios/scrolling/overflow-clip-with-accelerated-scrolling-ancestor-expected.html.
- fast/scrolling/ios/overflow-clip-with-accelerated-scrolling-ancestor.html: Renamed from LayoutTests/platform/ios-simulator/ios/scrolling/overflow-clip-with-accelerated-scrolling-ancestor.html.
- fast/scrolling/ios/overflow-div-scrolling-expected.txt: Renamed from LayoutTests/platform/ios-simulator/ios/scrolling/overflow-div-scrolling-expected.txt.
- fast/scrolling/ios/overflow-div-scrolling.html: Renamed from LayoutTests/platform/ios-simulator/ios/scrolling/overflow-div-scrolling.html.
- fast/scrolling/ios/overflow-scroll-inherited-expected.txt: Renamed from LayoutTests/platform/ios-simulator/ios/scrolling/overflow-scroll-inherited-expected.txt.
- fast/scrolling/ios/overflow-scroll-inherited.html: Renamed from LayoutTests/platform/ios-simulator/ios/scrolling/overflow-scroll-inherited.html.
- fast/scrolling/ios/overflow-scroll-touch-expected.txt: Renamed from LayoutTests/platform/ios-simulator/ios/scrolling/overflow-scroll-touch-expected.txt.
- fast/scrolling/ios/overflow-scroll-touch.html: Renamed from LayoutTests/platform/ios-simulator/ios/scrolling/overflow-scroll-touch.html.
- fast/scrolling/ios/overflow-scrolling-ancestor-clip-expected.txt: Copied from LayoutTests/platform/ios-simulator/ios/scrolling/overflow-scrolling-ancestor-clip-expected.txt.
- fast/scrolling/ios/overflow-scrolling-ancestor-clip-size-expected.txt: Copied from LayoutTests/platform/ios-simulator/ios/scrolling/overflow-scrolling-ancestor-clip-size-expected.txt.
- fast/scrolling/ios/overflow-scrolling-ancestor-clip-size.html: Renamed from LayoutTests/platform/ios-simulator/ios/scrolling/overflow-scrolling-ancestor-clip-size.html.
- fast/scrolling/ios/overflow-scrolling-ancestor-clip.html: Renamed from LayoutTests/platform/ios-simulator/ios/scrolling/overflow-scrolling-ancestor-clip.html.
- fast/scrolling/ios/remove-overflow-crash-expected.txt: Renamed from LayoutTests/platform/ios-simulator/ios/scrolling/remove-overflow-crash-expected.txt.
- fast/scrolling/ios/remove-overflow-crash.html: Renamed from LayoutTests/platform/ios-simulator/ios/scrolling/remove-overflow-crash.html.
- fast/scrolling/ios/resources/jump-back.html: Renamed from LayoutTests/platform/ios-simulator/ios/scrolling/resources/jump-back.html.
- fast/scrolling/ios/script-tests/TEMPLATE.html: Renamed from LayoutTests/platform/ios-simulator/ios/scrolling/script-tests/TEMPLATE.html.
- fast/scrolling/ios/script-tests/overflow-div-scrolling.js: Renamed from LayoutTests/platform/ios-simulator/ios/scrolling/script-tests/overflow-div-scrolling.js.
(verifyScrollOffset):
- fast/scrolling/ios/scroll-event-from-scrollTo-expected.txt: Renamed from LayoutTests/platform/ios-simulator/ios/scrolling/scroll-event-from-scrollTo-expected.txt.
- fast/scrolling/ios/scroll-event-from-scrollTo.html: Renamed from LayoutTests/platform/ios-simulator/ios/scrolling/scroll-event-from-scrollTo.html.
- fast/scrolling/ios/scroll-events-back-forward-after-pageshow-expected.txt: Renamed from LayoutTests/platform/ios-simulator/ios/scrolling/scroll-events-back-forward-after-pageshow-expected.txt.
- fast/scrolling/ios/scroll-events-back-forward-after-pageshow.html: Renamed from LayoutTests/platform/ios-simulator/ios/scrolling/scroll-events-back-forward-after-pageshow.html.
- fast/scrolling/ios/scroll-events-back-forward-expected.txt: Renamed from LayoutTests/platform/ios-simulator/ios/scrolling/scroll-events-back-forward-expected.txt.
- fast/scrolling/ios/scroll-events-back-forward.html: Renamed from LayoutTests/platform/ios-simulator/ios/scrolling/scroll-events-back-forward.html.
- fast/scrolling/ios/scrollTo-at-page-load-expected.txt: Renamed from LayoutTests/platform/ios-simulator/ios/scrolling/scrollTo-at-page-load-expected.txt.
- fast/scrolling/ios/scrollTo-at-page-load.html: Renamed from LayoutTests/platform/ios-simulator/ios/scrolling/scrollTo-at-page-load.html.
- fast/scrolling/ios/scrollbar-hiding-expected.txt: Copied from LayoutTests/platform/ios-simulator/ios/scrolling/scrollbar-hiding-expected.txt.
- fast/scrolling/ios/scrollbar-hiding.html: Renamed from LayoutTests/platform/ios-simulator/ios/scrolling/scrollbar-hiding.html.
- fast/scrolling/ios/scrolling-content-clip-to-viewport-expected.txt: Copied from LayoutTests/platform/ios-simulator/ios/scrolling/scrolling-content-clip-to-viewport-expected.txt.
- fast/scrolling/ios/scrolling-content-clip-to-viewport.html: Renamed from LayoutTests/platform/ios-simulator/ios/scrolling/scrolling-content-clip-to-viewport.html.
- fast/scrolling/ios/table-cell-touch-scrolling-expected.txt: Renamed from LayoutTests/platform/ios-simulator/ios/scrolling/table-cell-touch-scrolling-expected.txt.
- fast/scrolling/ios/table-cell-touch-scrolling.html: Renamed from LayoutTests/platform/ios-simulator/ios/scrolling/table-cell-touch-scrolling.html.
- fast/scrolling/ios/textarea-scroll-touch-expected.txt: Copied from LayoutTests/platform/ios-simulator/ios/scrolling/textarea-scroll-touch-expected.txt.
- fast/scrolling/ios/textarea-scroll-touch.html: Renamed from LayoutTests/platform/ios-simulator/ios/scrolling/textarea-scroll-touch.html.
- fast/scrolling/ios/touch-scroll-back-forward-expected.txt: Renamed from LayoutTests/platform/ios-simulator/ios/scrolling/touch-scroll-back-forward-expected.txt.
- fast/scrolling/ios/touch-scroll-back-forward.html: Renamed from LayoutTests/platform/ios-simulator/ios/scrolling/touch-scroll-back-forward.html.
- fast/scrolling/ios/touch-scroll-visibility-hidden-expected.txt:
- fast/scrolling/ios/touch-scroll-visibility-hidden.html:
- fast/scrolling/ios/touch-stacking-expected.txt: Copied from LayoutTests/platform/ios-simulator/ios/scrolling/touch-stacking-expected.txt.
- fast/scrolling/ios/touch-stacking.html: Renamed from LayoutTests/platform/ios-simulator/ios/scrolling/touch-stacking.html.
- platform/ios-simulator-wk1/TestExpectations:
- platform/ios-simulator-wk2/TestExpectations:
- platform/ios-simulator/TestExpectations:
- platform/ios-simulator/fast/scrolling/ios/clipping-ancestor-with-accelerated-scrolling-ancestor-expected.png: Added.
- platform/ios-simulator/fast/scrolling/ios/clipping-ancestor-with-accelerated-scrolling-ancestor-expected.txt: Renamed from LayoutTests/platform/ios-simulator/ios/scrolling/clipping-ancestor-with-accelerated-scrolling-ancestor-expected.txt.
- platform/ios-simulator/fast/scrolling/ios/overflow-scrolling-ancestor-clip-expected.txt: Renamed from LayoutTests/platform/ios-simulator/ios/scrolling/overflow-scrolling-ancestor-clip-expected.txt.
- platform/ios-simulator/fast/scrolling/ios/overflow-scrolling-ancestor-clip-size-expected.txt: Renamed from LayoutTests/platform/ios-simulator/ios/scrolling/overflow-scrolling-ancestor-clip-size-expected.txt.
- platform/ios-simulator/fast/scrolling/ios/scrollbar-hiding-expected.png: Added.
- platform/ios-simulator/fast/scrolling/ios/scrollbar-hiding-expected.txt: Renamed from LayoutTests/platform/ios-simulator/ios/scrolling/scrollbar-hiding-expected.txt.
- platform/ios-simulator/fast/scrolling/ios/scrolling-content-clip-to-viewport-expected.txt: Renamed from LayoutTests/platform/ios-simulator/ios/scrolling/scrolling-content-clip-to-viewport-expected.txt.
- platform/ios-simulator/fast/scrolling/ios/textarea-scroll-touch-expected.txt: Renamed from LayoutTests/platform/ios-simulator/ios/scrolling/textarea-scroll-touch-expected.txt.
- platform/ios-simulator/fast/scrolling/ios/touch-stacking-expected.png: Added.
- platform/ios-simulator/fast/scrolling/ios/touch-stacking-expected.txt: Renamed from LayoutTests/platform/ios-simulator/ios/scrolling/touch-stacking-expected.txt.
- 7:45 PM Changeset in webkit [200608] by
-
- 3 edits in trunk/Source/WebInspectorUI
Web Inspector: Filtering by Errors/Warnings should not filter Breakpoints list
https://bugs.webkit.org/show_bug.cgi?id=157481
<rdar://problem/26177346>
Reviewed by Timothy Hatcher.
- Localizations/en.lproj/localizedStrings.js:
New UI strings.
- UserInterface/Views/DebuggerSidebarPanel.js:
(WebInspector.DebuggerSidebarPanel.showResourcesWithIssuesOnlyFilterFunction):
Only filter tree elements belonging to the scripts tree outline.
(WebInspector.DebuggerSidebarPanel):
Drive-by cleanup of Issues filter button tooltips.
- 7:31 PM Changeset in webkit [200607] by
-
- 14 edits in trunk/Source/WebCore
Change Notification constructor to take an IDL dictionary instead of a WebCore::Dictionary
https://bugs.webkit.org/show_bug.cgi?id=157466
Reviewed by Alex Christensen.
- Modules/notifications/Notification.cpp: Got rid of unneeded includes.
(WebCore::Notification::Notification): Deleted the unused default constructor. Changed
NotificationCenter argument to be reference rather than PassRefPtr. Changed one of the
ScriptExecutionContext arguments to be a Document since the code relies on that already.
Used the lambda form of timer creation instead of the class member form. Added a FIXME
about when m_notificationCenter can be null.
(WebCore::Notification::create): Changed NotificationCenter argument to be reference
rather than PassRefPtr. Changed options argument to be Options rather than Dictionary.
(WebCore::directionString): Added. Helper because the class still wants to store the
direction as a string, at least for now.
(WebCore::Notification::show): Streamlined the code a bit.
(WebCore::Notification::taskTimerFired): Deleted. Not needed now that we use a lambda
inside the constructor.
(WebCore::Notification::permission): Removed unneeded const from return type.
(WebCore::Notification::permissionString): Ditto.
- Modules/notifications/Notification.h: Used pragma once, updated for changes above.
Removed a number of unused functions, including cancel, setIconURL, setLang,
stopLoadingIcon, detachPresenter, setBody, startLoadingIcon, finishLoadingIcon, and
taskTimerFired.
- Modules/notifications/Notification.idl: Add NotificationOptions and pass it instead
of Dictionary to the constructor. Note that this is only a subset of what is
currently specified in the Notifications API document. The latest document specifies
a much more complex feature with lots more options.
- Modules/notifications/NotificationCenter.cpp:
(WebCore::NotificationCenter::createNotification): Pass a reference rather than a
pointer to this.
- Modules/notifications/NotificationClient.h: Use pragma once. Removed unneeded
includes and forward declarations. Fixed #if to be easier to read.
- bindings/js/JSDOMConvert.h: Reworked the convert functions to use Converter and
DefaultConverter structs so we can do partial specialization in the future and so
we can get custom types for optional values. Used this to make an optional String
just be a null String, so it won't try to use Optional<String> instead. Might get
more complex latter when we add support for nullable.
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateEnumerationImplementationContent): Generate a blank line to make the output
slightly clearer. Tweaked a comment.
(GenerateDefaultValue): Added. Converts the default syntax from IDL into the syntax
needed in C++ code.
(GenerateDefaultValueWithLeadingComma): Added. Helper for use below.
(GenerateDictionaryImplementationContent): Use GenerateDefaultValue and
GenerateDefaultValueWithLeadingComma to make default values.
(GenerateParametersCheck): Use GenerateDefaultValue here in the enumeration code
path. This is a step in the direction of being able to make the whole thing more
generic in the future.
- bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
- bindings/scripts/test/GObject/WebKitDOMTestObj.h:
- bindings/scripts/test/JS/JSTestObj.cpp:
- bindings/scripts/test/ObjC/DOMTestObj.h:
- bindings/scripts/test/ObjC/DOMTestObj.mm:
Regenerated.
- bindings/scripts/test/TestObj.idl: Simplified and extended some of the test cases
to cover more combinations of the dictionary and enumeration support.
- 7:01 PM Changeset in webkit [200606] by
-
- 42 edits17 adds in trunk
Polymorphic operands in operators coerces downstream values to double.
https://bugs.webkit.org/show_bug.cgi?id=151793
Reviewed by Mark Lam.
Source/JavaScriptCore:
Previously if an object flowed into arithmetic, the prediction propagation phase would either
assume that the output of the arithmetic had to be double or sometimes it would assume that it
couldn't be double. We want it to only assume that the output is double if it actually had been.
The first part of this patch is to roll out http://trac.webkit.org/changeset/200502. That removed
some of the machinery that we had in place to detect whether the output of an operation is int or
double. That changeset claimed that the machinery was "fundamentally broken". It actually wasn't.
The reason why it didn't work was that ByteCodeParser was ignoring it if likelyToTakeSlowCase was
false. I think this was a complete goof-up: the code in ByteCodeParser::makeSafe was structured
in a way that made it non-obvious that the method is a no-op if !likelyToTakeSlowCase. So, this
change rolls out r200502 and makes ResultProfile do its job by reshaping how makeSafe processes
it.
This also makes two other changes to shore up ResultProfile:
- OSR exit can now refine a ResultProfile the same way that it refines ValueProfile.
- Baseline JIT slow paths now set bits in ResultProfile.
Based on this stuff, the DFG now predicts int/double/string in op_add/op_sub/op_mul based on
ResultProfiles. To be conservative, we still only use the ResultProfiles if the incoming
prediction is not number-or-boolean. This ensures that we exactly retain our old behavior in
those cases for which it was tuned. But I hope to remove this soon. I believe that ResultProfile
is already strictly better than what prediction propagation was doing before.
This can be an enormous win. This patch adds some simple microbenchmarks that demonstrate the
problem of assuming that arithmetic on objects returns double. The most extreme of these speeds
up 8x with this change (object-int-add-array).
- CMakeLists.txt:
- JavaScriptCore.xcodeproj/project.pbxproj:
- bytecode/CodeBlock.h:
(JSC::CodeBlock::addFrequentExitSite):
(JSC::CodeBlock::hasExitSite):
- bytecode/DFGExitProfile.cpp:
(JSC::DFG::FrequentExitSite::dump):
(JSC::DFG::ExitProfile::ExitProfile):
(JSC::DFG::ExitProfile::~ExitProfile):
(JSC::DFG::ExitProfile::add):
- bytecode/DFGExitProfile.h:
(JSC::DFG::FrequentExitSite::isHashTableDeletedValue):
- bytecode/MethodOfGettingAValueProfile.cpp:
(JSC::MethodOfGettingAValueProfile::fromLazyOperand):
(JSC::MethodOfGettingAValueProfile::emitReportValue):
(JSC::MethodOfGettingAValueProfile::getSpecFailBucket): Deleted.
- bytecode/MethodOfGettingAValueProfile.h:
(JSC::MethodOfGettingAValueProfile::MethodOfGettingAValueProfile):
(JSC::MethodOfGettingAValueProfile::operator bool):
(JSC::MethodOfGettingAValueProfile::operator!): Deleted.
- bytecode/PolymorphicAccess.cpp:
(JSC::AccessCase::generateImpl):
- bytecode/ValueProfile.cpp:
(JSC::ResultProfile::emitDetectBitsLight):
(JSC::ResultProfile::emitSetDouble):
(JSC::ResultProfile::emitSetNonNumber):
(WTF::printInternal):
- bytecode/ValueProfile.h:
(JSC::ResultProfile::ResultProfile):
(JSC::ResultProfile::bytecodeOffset):
(JSC::ResultProfile::specialFastPathCount):
(JSC::ResultProfile::didObserveNonInt32):
(JSC::ResultProfile::didObserveDouble):
(JSC::ResultProfile::didObserveNonNegZeroDouble):
(JSC::ResultProfile::didObserveNegZeroDouble):
(JSC::ResultProfile::didObserveNonNumber):
(JSC::ResultProfile::didObserveInt32Overflow):
(JSC::ResultProfile::didObserveInt52Overflow):
(JSC::ResultProfile::setObservedNonNegZeroDouble):
(JSC::ResultProfile::setObservedNegZeroDouble):
(JSC::ResultProfile::setObservedNonNumber):
(JSC::ResultProfile::setObservedInt32Overflow):
(JSC::ResultProfile::addressOfFlags):
(JSC::ResultProfile::addressOfSpecialFastPathCount):
(JSC::ResultProfile::detectBitsLight):
(JSC::ResultProfile::hasBits):
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::makeSafe):
- dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
- dfg/DFGGraph.cpp:
(JSC::DFG::Graph::ensureNaturalLoops):
(JSC::DFG::Graph::methodOfGettingAValueProfileFor):
(JSC::DFG::Graph::valueProfileFor): Deleted.
- dfg/DFGGraph.h:
(JSC::DFG::Graph::hasExitSite):
(JSC::DFG::Graph::numBlocks):
- dfg/DFGNode.h:
(JSC::DFG::Node::arithNodeFlags):
(JSC::DFG::Node::mayHaveNonIntResult):
(JSC::DFG::Node::mayHaveDoubleResult):
(JSC::DFG::Node::mayHaveNonNumberResult):
(JSC::DFG::Node::hasConstantBuffer):
- dfg/DFGNodeFlags.cpp:
(JSC::DFG::dumpNodeFlags):
- dfg/DFGNodeFlags.h:
- dfg/DFGOSRExitCompiler32_64.cpp:
(JSC::DFG::OSRExitCompiler::compileExit):
- dfg/DFGOSRExitCompiler64.cpp:
(JSC::DFG::OSRExitCompiler::compileExit):
- dfg/DFGOperations.cpp:
- dfg/DFGOperations.h:
- dfg/DFGPredictionPropagationPhase.cpp:
- dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::callOperation):
- ftl/FTLOSRExitCompiler.cpp:
(JSC::FTL::compileStub):
- jit/AssemblyHelpers.h:
(JSC::AssemblyHelpers::branchIfEqual):
(JSC::AssemblyHelpers::branchIfNotCell):
(JSC::AssemblyHelpers::branchIfNotNumber):
(JSC::AssemblyHelpers::branchIfNotDoubleKnownNotInt32):
(JSC::AssemblyHelpers::branchIfBoolean):
(JSC::AssemblyHelpers::branchIfEmpty):
(JSC::AssemblyHelpers::branchStructure):
- jit/CCallHelpers.h:
(JSC::CCallHelpers::CCallHelpers):
(JSC::CCallHelpers::setupArguments):
(JSC::CCallHelpers::setupArgumentsWithExecState):
- jit/IntrinsicEmitter.cpp:
(JSC::AccessCase::emitIntrinsicGetter):
- jit/JIT.h:
- jit/JITAddGenerator.cpp:
(JSC::JITAddGenerator::generateFastPath):
- jit/JITAddGenerator.h:
(JSC::JITAddGenerator::JITAddGenerator):
- jit/JITArithmetic.cpp:
(JSC::JIT::emit_op_add):
(JSC::JIT::emitSlow_op_add):
(JSC::JIT::emit_op_div):
(JSC::JIT::emit_op_mul):
(JSC::JIT::emitSlow_op_mul):
(JSC::JIT::emit_op_sub):
(JSC::JIT::emitSlow_op_sub):
- jit/JITInlines.h:
(JSC::JIT::callOperation):
(JSC::JIT::callOperationNoExceptionCheck):
- jit/JITMulGenerator.cpp:
(JSC::JITMulGenerator::generateFastPath):
- jit/JITOperations.cpp:
- jit/JITOperations.h:
- jit/JITSubGenerator.cpp:
(JSC::JITSubGenerator::generateFastPath):
- jit/JITSubGenerator.h:
(JSC::JITSubGenerator::JITSubGenerator):
- jit/TagRegistersMode.cpp: Added.
(WTF::printInternal):
- jit/TagRegistersMode.h: Added.
- runtime/CommonSlowPaths.cpp:
(JSC::updateResultProfileForBinaryArithOp):
LayoutTests:
- js/regress/object-int-add-array-expected.txt: Added.
- js/regress/object-int-add-array.html: Added.
- js/regress/object-int-add-expected.txt: Added.
- js/regress/object-int-add.html: Added.
- js/regress/object-int-mul-array-expected.txt: Added.
- js/regress/object-int-mul-array.html: Added.
- js/regress/object-int-sub-array-expected.txt: Added.
- js/regress/object-int-sub-array.html: Added.
- js/regress/object-int-sub-expected.txt: Added.
- js/regress/object-int-sub.html: Added.
- js/regress/script-tests/object-int-add-array.js: Added.
(i.o.valueOf):
- js/regress/script-tests/object-int-add.js: Added.
(i.o.valueOf):
- js/regress/script-tests/object-int-mul-array.js: Added.
(i.o.valueOf):
- js/regress/script-tests/object-int-sub-array.js: Added.
(i.o.valueOf):
- js/regress/script-tests/object-int-sub.js: Added.
(i.o.valueOf):
- 6:40 PM Changeset in webkit [200605] by
-
- 4 edits in trunk/Source/WebInspectorUI
REGRESSION: Web Inspector: DOM path bar blinks when modifying inline styles
https://bugs.webkit.org/show_bug.cgi?id=149258
<rdar://problem/22737843>
Reviewed by Timothy Hatcher.
- UserInterface/Base/Utilities.js:
(Array.shallowEqual):
- UserInterface/Views/ContentBrowser.js:
(WebInspector.ContentBrowser.prototype._updateContentViewNavigationItems):
(WebInspector.ContentBrowser.prototype._removeAllNavigationItems):
Don't re-render the navigation bar when all new navigation items match the previous ones.
- UserInterface/Views/HierarchicalPathNavigationItem.js:
(WebInspector.HierarchicalPathNavigationItem.set components.let.componentsEqual):
(WebInspector.HierarchicalPathNavigationItem.prototype.set components):
Don't re-render HierarchicalPathComponent when all new path components match the previous ones.
- 6:35 PM Changeset in webkit [200604] by
-
- 2 edits in trunk/LayoutTests
Land correct result for a recently added test.
- fast/scrolling/ios/touch-scroll-visibility-hidden-expected.txt:
- 5:59 PM Changeset in webkit [200603] by
-
- 4 edits in trunk/Source/WebCore
Modern IDB: Have server database connections remember the OpenDB request that spawned them.
https://bugs.webkit.org/show_bug.cgi?id=157498
Reviewed by Tim Horton.
No new tests (No testable change in behavior, debug only for now).
- Modules/indexeddb/server/UniqueIDBDatabase.cpp:
(WebCore::IDBServer::UniqueIDBDatabase::performCurrentOpenOperation):
- Modules/indexeddb/server/UniqueIDBDatabaseConnection.cpp:
(WebCore::IDBServer::UniqueIDBDatabaseConnection::create):
(WebCore::IDBServer::UniqueIDBDatabaseConnection::UniqueIDBDatabaseConnection):
(WebCore::IDBServer::UniqueIDBDatabaseConnection::connectionClosedFromClient):
(WebCore::IDBServer::UniqueIDBDatabaseConnection::didFireVersionChangeEvent):
(WebCore::IDBServer::UniqueIDBDatabaseConnection::createVersionChangeTransaction):
(WebCore::IDBServer::UniqueIDBDatabaseConnection::establishTransaction):
(WebCore::IDBServer::UniqueIDBDatabaseConnection::didAbortTransaction):
(WebCore::IDBServer::UniqueIDBDatabaseConnection::didCommitTransaction):
- Modules/indexeddb/server/UniqueIDBDatabaseConnection.h:
(WebCore::IDBServer::UniqueIDBDatabaseConnection::openRequestIdentifier):
- 5:20 PM Changeset in webkit [200602] by
-
- 23 edits3 adds in trunk
[iOS] visibility:hidden -webkit-overflow-scrolling: touch divs can interfere with page scrolling
https://bugs.webkit.org/show_bug.cgi?id=157496
Source/WebCore:
Reviewed by Tim Horton.
UIScrollViews are constructed in the UI process for visibility:hidden scrollable elements
with -webkit-overflow-scrolling: touch, and these intercept user events when they should not.
Fix by propagating a "contentsHidden" flag from the web process which is used to turn off
user interaction on these views.
Test: fast/scrolling/ios/touch-scroll-visibility-hidden.html
- platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::updateContentsVisibility): We have to tell the scrolling layer
if we have visibility:hidden.
- platform/graphics/ca/PlatformCALayer.h:
- platform/graphics/ca/cocoa/PlatformCALayerCocoa.h:
- platform/graphics/ca/cocoa/PlatformCALayerCocoa.mm:
(PlatformCALayerCocoa::contentsHidden):
(PlatformCALayerCocoa::setContentsHidden):
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateAfterDescendants):
Source/WebKit2:
rdar://problem/22963278
Reviewed by Tim Horton.
UIScrollViews are constructed in the UI process for visibility:hidden scrollable elements
with -webkit-overflow-scrolling: touch, and these intercept user events when they should not.
Fix by propagating a "contentsHidden" flag from the web process which is used to turn off
user interaction on these views.
- Shared/mac/RemoteLayerTreePropertyApplier.mm:
(WebKit::RemoteLayerTreePropertyApplier::applyProperties):
- Shared/mac/RemoteLayerTreeTransaction.h:
- Shared/mac/RemoteLayerTreeTransaction.mm:
(WebKit::RemoteLayerTreeTransaction::LayerProperties::LayerProperties):
(WebKit::RemoteLayerTreeTransaction::LayerProperties::encode):
(WebKit::RemoteLayerTreeTransaction::LayerProperties::decode):
(WebKit::dumpChangedLayers):
- UIProcess/ios/RemoteLayerTreeHostIOS.mm:
(-[UIView _recursiveFindDescendantScrollViewAtPoint:withEvent:]): Our custom hit
test needs to take view.isUserInteractionEnabled into account.
- WebProcess/WebPage/mac/PlatformCALayerRemote.cpp:
(WebKit::PlatformCALayerRemote::setHidden):
(WebKit::PlatformCALayerRemote::contentsHidden):
(WebKit::PlatformCALayerRemote::setContentsHidden):
- WebProcess/WebPage/mac/PlatformCALayerRemote.h:
Tools:
rdar://problem/22963278
Reviewed by Tim Horton.
Enhance UIScriptController to generate a drag, which is useful for scrolling.
- WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl:
- WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
(WTR::UIScriptController::dragFromPointToPoint):
- WebKitTestRunner/UIScriptContext/UIScriptController.h:
- WebKitTestRunner/ios/HIDEventGenerator.h:
- WebKitTestRunner/ios/HIDEventGenerator.mm:
(-[HIDEventGenerator dragWithStartPoint:endPoint:duration:completionBlock:]):
- WebKitTestRunner/ios/UIScriptControllerIOS.mm:
(WTR::UIScriptController::dragFromPointToPoint):
LayoutTests:
rdar://problem/22963278
Reviewed by Tim Horton.
Add a fast/scrolling/ios directory, disable it everywhere except on iOS.
- TestExpectations:
- fast/scrolling/ios/touch-scroll-visibility-hidden-expected.txt: Added.
- fast/scrolling/ios/touch-scroll-visibility-hidden.html: Added.
- platform/ios-simulator-wk2/TestExpectations:
- 5:13 PM Changeset in webkit [200601] by
-
- 8 edits6 adds in trunk
Web Font is downloaded even when all the characters in the document are outside its unicode-range
https://bugs.webkit.org/show_bug.cgi?id=42154
<rdar://problem/17779042>
Reviewed by Darin Adler.
Source/WebCore:
Fonts are requested in two stages:
- For a given font family, all the relevant @font-face rules are consulted. We build up a
mapping of unicode-range -> Font object. This result is cached.
- Then, when we have the mapping, we look up the character we are trying to render to
find the appropriate Font object.
However, we are not supposed to create any Font objects (because that causes a download to
be triggered) until we consult with the character we're trying to render. Therefore, this
patch swaps out the Font objects with a FontAccessor. This FontAccessor is essentially a
lazily-created Font. When step 2 starts looking up the appropriate character, the
FontAccessor will be asked to start the download.
Test: fast/text/unicode-range-download.html
- css/CSSFontFace.cpp:
(WebCore::CSSFontFace::removeClient):
as a client from all its CSSFontFaces.
- css/CSSFontFaceSet.cpp:
(WebCore::CSSFontFaceSet::clear): Clearing the CSSFontFaceSet needs to remove itself as a
client from all its CSSFontFaces.
- css/CSSSegmentedFontFace.cpp:
(WebCore::CSSFontAccessor::create): The lazy Font object.
(WebCore::CSSFontAccessor::CSSFontAccessor): Ditto.
(WebCore::appendFontWithInvalidUnicodeRangeIfLoading): Appends a FontAccessor.
(WebCore::CSSSegmentedFontFace::fontRanges): Create the FontAccessor and use it instead.
- platform/graphics/FontCascadeFonts.cpp:
(WebCore::FontCascadeFonts::determinePitch): Use the fontForFirstRange() convenience
function.
(WebCore::glyphPageFromFontRanges): font() may now return nullptr. Update this function to
handle that.
- platform/graphics/FontRanges.cpp:
(WebCore::FontRanges::Range::font): Trigger the lazy initialization.
(WebCore::TrivialFontAccessor::create): Used in the case where there is only one font in
the Ranges object and it has a full unicode-range.
(WebCore::TrivialFontAccessor::TrivialFontAccessor):
(WebCore::FontRanges::FontRanges): Use TrivialFontAccessor.
(WebCore::FontRanges::glyphDataForCharacter): font() may now return nullptr. Update this
function to handle that. This is where the magic happens: this is where we trigger
downloads only if the character falls within the unicode-range.
(WebCore::FontRanges::fontForFirstRange): Add ASSERT.
(WebCore::FontRanges::isLoading): Update to use the new FontAccessor.
- platform/graphics/FontRanges.h: Ditto.
(WebCore::FontRanges::Range::Range):
(WebCore::FontRanges::Range::fontAccessor):
(WebCore::FontRanges::appendRange):
(WebCore::FontRanges::Range::font): Deleted.
- platform/graphics/FontSelector.h: The virtual base class of FontAccessor. This is
necessary because it must be shared between platform code and non-platform code.
(WebCore::FontAccessor::~FontAccessor):
LayoutTests:
- fast/text/unicode-range-download-expected.txt: Added.
- fast/text/unicode-range-download.html: Added.
- fast/text/resources/unicode-range-download-Ahem.otf: Added.
- fast/text/resources/unicode-range-download-Ahem.ttf: Added.
- fast/text/resources/unicode-range-download-Ahem.woff: Added.
- imported/blink/svg/custom/resources/graffiti.svg: Added.
imported/blink/svg/custom/svg-fonts-unloaded-segment.html requires this font.
- 5:02 PM Changeset in webkit [200600] by
-
- 3 edits in trunk/Source/WebInspectorUI
Web Inspector: Remove Global Breakpoints folder
https://bugs.webkit.org/show_bug.cgi?id=157478
<rdar://problem/26176524>
Reviewed by Timothy Hatcher.
- Localizations/en.lproj/localizedStrings.js:
Remove UI string.
- UserInterface/Views/DebuggerSidebarPanel.js:
(WebInspector.DebuggerSidebarPanel):
(WebInspector.DebuggerSidebarPanel.prototype._breakpointTreeOutlineContextMenuTreeElement):
(WebInspector.DebuggerSidebarPanel.prototype._treeSelectionDidChange):
Remove references to folder tree element.
(WebInspector.DebuggerSidebarPanel.prototype._compareTopLevelTreeElements.isSpecialBreakpoint):
(WebInspector.DebuggerSidebarPanel.prototype._compareTopLevelTreeElements):
Top level comparison should check for "special" breakpoints.
- 5:00 PM Changeset in webkit [200599] by
-
- 2 edits in trunk/Source/WebKit/mac
[WebKit1] Invoking a link preview on a complex link (e.g. an image) results in an empty TextIndicator
https://bugs.webkit.org/show_bug.cgi?id=157497
<rdar://problem/25872773>
Reviewed by Anders Carlsson.
- WebView/WebImmediateActionController.mm:
(-[WebImmediateActionController _defaultAnimationController]):
r198578 fixed this for WebKit2, but forgot about WebKit1.
- 4:59 PM Changeset in webkit [200598] by
-
- 3 edits in trunk/Source/WebCore
Modern IDB: Prevent the same transaction from being commited/aborted twice.
https://bugs.webkit.org/show_bug.cgi?id=157494
Reviewed by Tim Horton.
When a page navigates or a worker terminates, in rare cases with specific unfortunate timing, the IDBServer
might receive a request to commit/abort a transaction that is already in the process of committing/aborting.
By moving transactions that are finishing into their own map we can at least detect this situation and
return an error. This seems like an improvement over some mysterious ASSERTs/timeouts.
No new tests:
While apparent that this is at least partially to blame for some existing timeouts/ASSERTs, I could not nail
down a reliable way to reproduce this with a dedicated test.
- Modules/indexeddb/server/UniqueIDBDatabase.cpp:
(WebCore::IDBServer::UniqueIDBDatabase::~UniqueIDBDatabase):
(WebCore::IDBServer::UniqueIDBDatabase::performCurrentDeleteOperation):
(WebCore::IDBServer::UniqueIDBDatabase::didDeleteBackingStore):
(WebCore::IDBServer::UniqueIDBDatabase::prepareToFinishTransaction):
(WebCore::IDBServer::UniqueIDBDatabase::commitTransaction):
(WebCore::IDBServer::UniqueIDBDatabase::didPerformCommitTransaction):
(WebCore::IDBServer::UniqueIDBDatabase::abortTransaction):
(WebCore::IDBServer::UniqueIDBDatabase::didPerformAbortTransaction):
(WebCore::IDBServer::UniqueIDBDatabase::hasUnfinishedTransactions):
(WebCore::IDBServer::UniqueIDBDatabase::operationAndTransactionTimerFired):
(WebCore::IDBServer::UniqueIDBDatabase::takeNextRunnableTransaction):
(WebCore::IDBServer::UniqueIDBDatabase::transactionCompleted): Renamed from inProgressTransactionCompleted.
(WebCore::IDBServer::UniqueIDBDatabase::inProgressTransactionCompleted): Deleted.
- Modules/indexeddb/server/UniqueIDBDatabase.h:
- 4:51 PM Changeset in webkit [200597] by
-
- 2 edits1 add in trunk/Source/JavaScriptCore
CallObjectConstructor should not call operationToThis in the FTL
https://bugs.webkit.org/show_bug.cgi?id=157492
<rdar://problem/26149904>
Reviewed by Mark Lam.
At some point when I was working on intrinsifying the Object
constructor, I realized that the Object constructor was different
from the ToObject operation. I fixed the DFG but I guess I didn't
fix the FTL.
This patch fixes an issue with www.wunderground.com not loading
the 10-day forecast and local map.
- ftl/FTLLowerDFGToB3.cpp:
(JSC::FTL::DFG::LowerDFGToB3::compileCallObjectConstructor):
- tests/stress/call-object-constructor.js: Added.
(test):
(assert):
- 4:48 PM Changeset in webkit [200596] by
-
- 3 edits2 adds in trunk/Source/WebCore
Draw border and correct icon for placeholder attachments
https://bugs.webkit.org/show_bug.cgi?id=157495
rdar://problem/19982510
Reviewed by Anders Carlsson.
- Resources/AttachmentPlaceholder.png: Added.
- Resources/AttachmentPlaceholder@2x.png: Added.
- WebCore.xcodeproj/project.pbxproj:
- rendering/RenderThemeMac.mm:
(WebCore::attachmentPlaceholderBorderColor):
(WebCore::paintAttachmentIconPlaceholder):
(WebCore::paintAttachmentProgress):
(WebCore::paintAttachmentPlaceholderBorder):
(WebCore::RenderThemeMac::paintAttachment):
If progress is set, but set to 0, draw a dashed border around the attachment
and use the placeholder "download" artwork.
- 3:50 PM Changeset in webkit [200595] by
-
- 5 edits in trunk/Source
Introduce WebVideoFullscreenInterfaceMac::isPlayingVideoInEnhancedFullscreen() and use it in WebVideoFullscreenManagerProxy::isPlayingVideoInEnhancedFullscreen()
https://bugs.webkit.org/show_bug.cgi?id=157493
Reviewed by Dan Bernstein.
Source/WebCore:
- platform/mac/WebVideoFullscreenInterfaceMac.h:
- platform/mac/WebVideoFullscreenInterfaceMac.mm:
(WebCore::WebVideoFullscreenInterfaceMac::isPlayingVideoInEnhancedFullscreen):
Source/WebKit2:
- UIProcess/Cocoa/WebVideoFullscreenManagerProxy.mm:
(WebKit::WebVideoFullscreenManagerProxy::isPlayingVideoInEnhancedFullscreen):
- 3:01 PM Changeset in webkit [200594] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Heap Snapshot Timeline view can be live
https://bugs.webkit.org/show_bug.cgi?id=157487
<rdar://problem/26178439>
Reviewed by Joseph Pecoraro.
- UserInterface/Views/HeapAllocationsTimelineView.js:
(WebInspector.HeapAllocationsTimelineView.prototype.get showsLiveRecordingData): Deleted.
Don't override, should return true.
- 2:57 PM Changeset in webkit [200593] by
-
- 6 edits in trunk/Source/WebCore
Clean up iOS text autosizing code
https://bugs.webkit.org/show_bug.cgi?id=157489
Reviewed by Zalan Bujtas.
Change the TraverseNextInclusionFunction and HeightTypeTraverseNextInclusionFunction
to take references.
Use downcast<> more.
Whitespace cleanup.
- rendering/RenderBlockFlow.cpp:
(WebCore::isNonBlocksOrNonFixedHeightListItems):
- rendering/RenderElement.cpp:
(WebCore::includeNonFixedHeight):
- rendering/RenderObject.cpp:
(WebCore::RenderObject::traverseNext):
- rendering/RenderObject.h:
- rendering/TextAutoSizing.cpp:
(WebCore::TextAutoSizingValue::adjustNodeSizes):
(WebCore::TextAutoSizingValue::reset):
- 2:53 PM Changeset in webkit [200592] by
-
- 7 edits in trunk/Source/WebKit2
Add WKPageRef SPI to tell whether there's a video playing in enhanced fullscreen
https://bugs.webkit.org/show_bug.cgi?id=157434
Reviewed by Darin Adler.
- UIProcess/API/C/mac/WKPagePrivateMac.h:
- UIProcess/API/C/mac/WKPagePrivateMac.mm:
(WKPageIsPlayingVideoInEnhancedFullscreen):
- UIProcess/Cocoa/WebVideoFullscreenManagerProxy.h:
- UIProcess/Cocoa/WebVideoFullscreenManagerProxy.mm:
(WebKit::WebVideoFullscreenManagerProxy::isPlayingVideoInEnhancedFullscreen):
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::isPlayingVideoInEnhancedFullscreen):
- UIProcess/WebPageProxy.h:
- 1:41 PM Changeset in webkit [200591] by
-
- 11 edits2 copies1 add in trunk/Source
Add injected bundle SPI for getting favicon and touch icon URLs
https://bugs.webkit.org/show_bug.cgi?id=157435
Reviewed by Darin Adler.
Source/WebCore:
- CMakeLists.txt:
Add new files.
- WebCore.xcodeproj/project.pbxproj:
Add new files.
- html/HTMLLinkElement.cpp:
(WebCore::HTMLLinkElement::iconType):
- html/HTMLLinkElement.h:
Rename LinkRelAttribute::IconType to LinkIconType.
- html/LinkIconCollector.cpp: Added.
(WebCore::iconSize):
New helper function that returns the icon size for an icon.
(WebCore::compareIcons):
Icon comparison function, to be used by for sorting.
(LinkIconCollector::iconsOfTypes):
Gather the right icons, sort them (descending by size) and return them.
- html/LinkIconCollector.h:
Added.
- html/LinkIconType.h:
Move icon type declarations here and arrange them so we can use them in an OptionSet.
- html/LinkRelAttribute.cpp:
(WebCore::LinkRelAttribute::LinkRelAttribute):
- html/LinkRelAttribute.h:
- loader/icon/IconController.cpp:
(WebCore::iconFromLinkElements):
Rename IconType to LinkIconType.
Source/WebKit2:
- WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInFrame.h:
- WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInFrame.mm:
(collectIcons):
New helper function that calls into the WebCore LinkCollector.
(-[WKWebProcessPlugInFrame appleTouchIconURLs]):
Call collectIcons.
(-[WKWebProcessPlugInFrame faviconURLs]):
Ditto.
- 1:22 PM Changeset in webkit [200590] by
-
- 5 edits2 moves in trunk
Remove testRunner.setTextAutosizingEnabled and migrate the one test that uses it
https://bugs.webkit.org/show_bug.cgi?id=157480
Reviewed by Zalan Bujtas.
Migrate the one test that used testRunner.setTextAutosizingEnabled() to window.internals.settings.setTextAutosizingEnabled()
and move it next to the other iOS text autosizing tests.
Tools:
Remove testRunner.setTextAutosizingEnabled(), which was only implemented in DumpRenderTree.
- DumpRenderTree/TestRunner.cpp:
(setTextAutosizingEnabledCallback): Deleted.
(TestRunner::staticFunctions): Deleted.
- DumpRenderTree/mac/TestRunnerMac.mm:
(TestRunner::setTextAutosizingEnabled): Deleted.
LayoutTests:
- fast/text-autosizing/ios/textarea-auto-sizing-disable-expected.txt: Renamed from LayoutTests/platform/ios-simulator/ios/fast/html/textarea-auto-sizing-disable-expected.txt.
- fast/text-autosizing/ios/textarea-auto-sizing-disable.html: Renamed from LayoutTests/platform/ios-simulator/ios/fast/html/textarea-auto-sizing-disable.html.
- platform/ios-simulator/TestExpectations:
- 1:22 PM Changeset in webkit [200589] by
-
- 1 edit25 adds in trunk/LayoutTests
Upstream some iOS text autosizing tests.
- fast/text-autosizing/ios/anonymous-block.html: Added.
- fast/text-autosizing/ios/contenteditable.html: Added.
- fast/text-autosizing/ios/first-letter.html: Added.
- fast/text-autosizing/ios/font-family-case-insensitive-expected.txt: Added.
- fast/text-autosizing/ios/font-family-case-insensitive.html: Added.
- fast/text-autosizing/ios/lists.html: Added.
- fast/text-autosizing/ios/overflow.html: Added.
- fast/text-autosizing/ios/percent-adjust-length-line-height-expected.txt: Added.
- fast/text-autosizing/ios/percent-adjust-length-line-height.html: Added.
- fast/text-autosizing/ios/percent-adjust-number-line-height-expected.txt: Added.
- fast/text-autosizing/ios/percent-adjust-number-line-height.html: Added.
- fast/text-autosizing/ios/percent-adjust-percent-line-height-expected.txt: Added.
- fast/text-autosizing/ios/percent-adjust-percent-line-height.html: Added.
- platform/ios-simulator/fast/text-autosizing/ios/anonymous-block-expected.txt: Added.
- platform/ios-simulator/fast/text-autosizing/ios/contenteditable-expected.txt: Added.
- platform/ios-simulator/fast/text-autosizing/ios/first-letter-expected.txt: Added.
- platform/ios-simulator/fast/text-autosizing/ios/lists-expected.txt: Added.
- platform/ios-simulator/fast/text-autosizing/ios/overflow-expected.txt: Added.
- platform/mac/fast/text-autosizing/ios/anonymous-block-expected.txt: Added.
- platform/mac/fast/text-autosizing/ios/contenteditable-expected.txt: Added.
- platform/mac/fast/text-autosizing/ios/first-letter-expected.txt: Added.
- platform/mac/fast/text-autosizing/ios/lists-expected.txt: Added.
- platform/mac/fast/text-autosizing/ios/overflow-expected.txt: Added.
- 1:22 PM Changeset in webkit [200588] by
-
- 8 edits2 adds in trunk
[iOS WK2] Font size increases on some pages after navigating then going back
https://bugs.webkit.org/show_bug.cgi?id=157441
rdar://problem/22873240
Reviewed by Darin Adler.
Source/WebCore:
Sometimes I want to dump ViewportConfigurations from WebKit2 so export dump().
Test: fast/text-autosizing/ios/text-autosizing-after-back.html
- page/ViewportConfiguration.h:
Source/WebKit2:
There's an ordering dependency between setting the viewport configuration and doing
layouts when going back to a page from the page cache that is incorrectly handled.
In FrameLoader::commitProvisionalLoad(), CachedPage::restore() triggers a layout under
updateContentsSize(), but this happens before dispatchDidCommitLoad() which updates
the viewport arguments via ViewportConfiguration::setViewportArguments().
This issue is not addressed by the current commit. But a second problem is:
if the inputs to text autosizing change, we need to invalidate the autosizing state.
The relevant input here is the fixed layout width (which is determined from the viewport
configuration).
The current code invalidated text autosizing when m_viewportConfiguration.minimumLayoutSize()
changed, but the correct behavior is to invalidate based on fixed layout size changing.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::sendViewportAttributesChanged):
(WebKit::WebPage::setFixedLayoutSize):
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::resetTextAutosizing):
(WebKit::WebPage::dynamicViewportSizeUpdate):
(WebKit::WebPage::viewportConfigurationChanged):
(WebKit::WebPage::setViewportConfigurationMinimumLayoutSize): Deleted.
(WebKit::WebPage::resetTextAutosizingBeforeLayoutIfNeeded): Deleted.
LayoutTests:
- fast/text-autosizing/ios/text-autosizing-after-back-expected.html: Added.
- fast/text-autosizing/ios/text-autosizing-after-back.html: Added.
- 1:18 PM Changeset in webkit [200587] by
-
- 2 edits in trunk/Source/WebCore
"Main content" restrictions should not apply to media documents
https://bugs.webkit.org/show_bug.cgi?id=157479
<rdar://problem/25840861>
Reviewed by Jer Noble.
No new tests, this change only applies to media documents in a top level document so it
isn't possible to have a layout test.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::HTMLMediaElement): Don't apply restrictions to a media document.
- 1:17 PM Changeset in webkit [200586] by
-
- 35 edits3 adds in trunk/Source/JavaScriptCore
Getter and setter on super are called with wrong "this" object
https://bugs.webkit.org/show_bug.cgi?id=147064
<rdar://problem/21885916>
Reviewed by Filip Pizlo.
This patch implements calls to 'super' getters and setters.
The problem before is we were passing the 'super' (i.e, the prototype
object) as the this value to these getters/setters, which is wrong.
We should be passing the caller's this value.
To implement this behavior, I've introduced four new opcodes and their corresponding DFG nodes:
- op_get_by_id_with_this | GetByIdWithThis
- op_put_by_id_with_this | PutByIdWithThis
- op_get_by_val_with_this | GetByValWithThis
- op_put_by_val_with_this | PutByValWithThis
These are implemented with no optimizations. The future plan is
to unite them with the *by_id and *by_val opcodes and nodes:
https://bugs.webkit.org/show_bug.cgi?id=157215
- bytecode/BytecodeList.json:
- bytecode/BytecodeUseDef.h:
(JSC::computeUsesForBytecodeOffset):
(JSC::computeDefsForBytecodeOffset):
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::dumpBytecode):
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::emitGetById):
(JSC::BytecodeGenerator::emitPutById):
(JSC::BytecodeGenerator::emitDirectPutById):
(JSC::BytecodeGenerator::emitGetByVal):
(JSC::BytecodeGenerator::emitPutByVal):
(JSC::BytecodeGenerator::emitDirectPutByVal):
(JSC::BytecodeGenerator::emitLoadDerivedConstructorFromArrowFunctionLexicalEnvironment):
(JSC::BytecodeGenerator::ensureThis):
(JSC::BytecodeGenerator::isThisUsedInInnerArrowFunction):
- bytecompiler/BytecodeGenerator.h:
- bytecompiler/NodesCodegen.cpp:
(JSC::ThisNode::emitBytecode):
(JSC::emitHomeObjectForCallee):
(JSC::emitSuperBaseForCallee):
(JSC::emitGetSuperFunctionForConstruct):
(JSC::SuperNode::emitBytecode):
(JSC::NewTargetNode::emitBytecode):
(JSC::TaggedTemplateNode::emitBytecode):
(JSC::BracketAccessorNode::emitBytecode):
(JSC::DotAccessorNode::emitBytecode):
(JSC::FunctionCallValueNode::emitBytecode):
(JSC::FunctionCallBracketNode::emitBytecode):
(JSC::FunctionCallDotNode::emitBytecode):
(JSC::CallFunctionCallDotNode::emitBytecode):
(JSC::ApplyFunctionCallDotNode::emitBytecode):
(JSC::PostfixNode::emitBracket):
(JSC::PostfixNode::emitDot):
(JSC::PrefixNode::emitBracket):
(JSC::PrefixNode::emitDot):
(JSC::AssignDotNode::emitBytecode):
(JSC::ReadModifyDotNode::emitBytecode):
(JSC::AssignBracketNode::emitBytecode):
(JSC::ReadModifyBracketNode::emitBytecode):
(JSC::ForInNode::emitLoopHeader):
(JSC::ForOfNode::emitBytecode):
(JSC::AssignmentElementNode::bindValue):
- dfg/DFGAbstractInterpreterInlines.h:
(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
- dfg/DFGCapabilities.cpp:
(JSC::DFG::capabilityLevel):
- dfg/DFGClobberize.h:
(JSC::DFG::clobberize):
- dfg/DFGDoesGC.cpp:
(JSC::DFG::doesGC):
- dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
- dfg/DFGNode.h:
(JSC::DFG::Node::hasIdentifier):
- dfg/DFGNodeType.h:
- dfg/DFGOperations.cpp:
(JSC::DFG::newTypedArrayWithSize):
(JSC::DFG::putWithThis):
- dfg/DFGOperations.h:
- dfg/DFGPredictionPropagationPhase.cpp:
- dfg/DFGSafeToExecute.h:
(JSC::DFG::safeToExecute):
- dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::callOperation):
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- ftl/FTLCapabilities.cpp:
(JSC::FTL::canCompile):
- ftl/FTLLowerDFGToB3.cpp:
(JSC::FTL::DFG::LowerDFGToB3::compileNode):
(JSC::FTL::DFG::LowerDFGToB3::compileGetById):
(JSC::FTL::DFG::LowerDFGToB3::compileGetByIdWithThis):
(JSC::FTL::DFG::LowerDFGToB3::compileGetByValWithThis):
(JSC::FTL::DFG::LowerDFGToB3::compilePutByIdWithThis):
(JSC::FTL::DFG::LowerDFGToB3::compilePutByValWithThis):
(JSC::FTL::DFG::LowerDFGToB3::compilePutById):
- jit/CCallHelpers.cpp:
(JSC::CCallHelpers::setupShadowChickenPacket):
(JSC::CCallHelpers::setupFourStubArgsGPR):
- jit/CCallHelpers.h:
(JSC::CCallHelpers::setupArgumentsWithExecState):
(JSC::CCallHelpers::setupThreeStubArgsGPR):
(JSC::CCallHelpers::setupTwoStubArgsFPR):
(JSC::CCallHelpers::setupStubArguments134):
- jit/GPRInfo.h:
(JSC::argumentRegisterFor): Deleted.
- jit/JIT.cpp:
(JSC::JIT::privateCompileMainPass):
- jit/JIT.h:
- jit/JITOperations.h:
- jit/JITPropertyAccess.cpp:
(JSC::JIT::emit_op_put_by_val):
(JSC::JIT::emit_op_put_by_val_with_this):
(JSC::JIT::emitGenericContiguousPutByVal):
(JSC::JIT::emit_op_get_by_id):
(JSC::JIT::emit_op_get_by_id_with_this):
(JSC::JIT::emit_op_get_by_val_with_this):
(JSC::JIT::emitSlow_op_get_by_id):
(JSC::JIT::emit_op_put_by_id):
(JSC::JIT::emit_op_put_by_id_with_this):
(JSC::JIT::emitSlow_op_put_by_id):
- jit/JITPropertyAccess32_64.cpp:
(JSC::JIT::emit_op_put_to_arguments):
(JSC::JIT::emit_op_get_by_id_with_this):
(JSC::JIT::emit_op_get_by_val_with_this):
(JSC::JIT::emit_op_put_by_id_with_this):
(JSC::JIT::emit_op_put_by_val_with_this):
- llint/LowLevelInterpreter.asm:
- runtime/CommonSlowPaths.cpp:
(JSC::SLOW_PATH_DECL):
- runtime/CommonSlowPaths.h:
- tests/stress/super-property-access-exceptions.js: Added.
(assert):
(test):
(test.fooProp):
(test.A.prototype.get foo):
(test.A.prototype.get x):
(test.A):
(test.B):
(test.B.prototype.bar):
(test.B.prototype.baz):
(test.foo):
(test.func):
(test.A.prototype.set foo):
- tests/stress/super-property-access-tdz.js: Added.
(assert):
(test):
(shouldThrowTDZ):
(test.A.prototype.get foo):
(test.A.prototype.set foo):
(test.A):
(test.fooProp):
(test.B):
(test.C):
(test.D):
(test.E):
(test.F):
- tests/stress/super-property-access.js: Added.
(assert):
(test):
(func):
(test.A):
(test.A.prototype.set value):
(test.A.prototype.get value):
(test.B.prototype.set value):
(test.B.prototype.get value):
(test.B):
(test.value):
(test.A.prototype.get func):
(test.B.prototype.inc):
(test.B.prototype.dec):
(test.B.prototype.preInc):
(test.B.prototype.preDec):
(test.B.prototype.plusEq):
(test.B.prototype.minusEq):
(test.B.prototype.timesEq):
(test.B.prototype.divEq):
(test.B.prototype.funcDot):
(test.B.prototype.funcBracket):
(test.foo):
(test.B.prototype.baz):
(test.B.prototype.jaz):
(test.B.prototype.bar):
(test.B.prototype.index):
(test.):
(test.prototype.bar):
(test.A.prototype.set foo):
(test.A.prototype.get array):
(test.A.prototype.get foo):
(test.obj):
(test.A.prototype.get call):
(test.A.prototype.get apply):
(test.B.prototype.foo):
(test.A.prototype.get i):
- 1:10 PM Changeset in webkit [200585] by
-
- 4 edits in trunk/LayoutTests
Rebaseline failing LayoutTests after r200580
Unreviewed test gardening.
- fast/xmlhttprequest/xmlhttprequest-get-expected.txt:
- http/tests/workers/worker-importScriptsOnError-expected.txt:
- inspector/model/remote-object-get-properties-expected.txt:
- 1:07 PM Changeset in webkit [200584] by
-
- 2 edits in trunk/Source/WebCore
Update Picture-in-picture artwork
https://bugs.webkit.org/show_bug.cgi?id=157484
<rdar://problem/26177784>
Reviewed by Eric Carlson.
We have new artwork for the picture-in-picture presentation mode. I
also converted it to use SVG (and moved the button style to a
more consistent part of the file).
- Modules/mediacontrols/mediaControlsApple.css:
(video::-webkit-media-controls-panel .picture-in-picture-button):
(video::-webkit-media-controls-panel .picture-in-picture-button.return-from-picture-in-picture):
(video::-webkit-media-controls-panel .picture-in-picture-button:active):
(video::-webkit-media-controls-panel .picture-in-picture-button.return-from-picture-in-picture:active):
- 12:46 PM Changeset in webkit [200583] by
-
- 36 edits in trunk
Optimize [StrictTypeChecking] on IDL operations
https://bugs.webkit.org/show_bug.cgi?id=157467
Reviewed by Darin Adler.
Source/WebCore:
Optimize [StrictTypeChecking] on IDL operations so that:
- Only generate extra code for nullable parameters because for non-nullable parameters, JSXXX::toWrapped() will return null in case of a bad input type. We will then throw a TypeError when null-checking it already.
- After the JSValue::isNullOrUndefined() check, avoid calling JSXXX::toWrapped() and set nativeValue to nullptr directly.
- Drop the check for JSValue::inherits(JSXXX::info()) and just do a null check on the value returned by JSXXX::toWrapped(). toWrapped() already does a JSValue::inherits(JSXXX::info() check. Since we only call toWrapped() if the JSValue is not null/undefined, a null return value always indicates a bad input type.
Also update the TypeError message to be more useful when passing null
for non-nullable parameters or assigning null to a non-nullable
attribute. The message is now consistent with the one used for strict
type checking.
No new tests, rebaselined existing tests.
- bindings/js/JSDOMBinding.h:
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateImplementation):
(GenerateParametersCheck):
- bindings/scripts/test/JS/JSTestActiveDOMObject.cpp:
(WebCore::jsTestActiveDOMObjectPrototypeFunctionExcitingFunction):
- bindings/scripts/test/JS/JSTestInterface.cpp:
(WebCore::setJSTestInterfaceImplementsNode):
(WebCore::setJSTestInterfaceSupplementalNode):
(WebCore::jsTestInterfacePrototypeFunctionImplementsMethod2):
(WebCore::jsTestInterfacePrototypeFunctionSupplementalMethod2):
- bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::setJSTestObjTestObjAttr):
(WebCore::setJSTestObjLenientTestObjAttr):
(WebCore::setJSTestObjXMLObjAttr):
(WebCore::setJSTestObjTypedArrayAttr):
(WebCore::setJSTestObjWithScriptExecutionContextAttribute):
(WebCore::setJSTestObjWithScriptStateAttributeRaises):
(WebCore::setJSTestObjWithScriptExecutionContextAttributeRaises):
(WebCore::setJSTestObjWithScriptExecutionContextAndScriptStateAttribute):
(WebCore::setJSTestObjWithScriptExecutionContextAndScriptStateAttributeRaises):
(WebCore::setJSTestObjWithScriptExecutionContextAndScriptStateWithSpacesAttribute):
(WebCore::setJSTestObjWithScriptArgumentsAndCallStackAttribute):
(WebCore::jsTestObjPrototypeFunctionVoidMethodWithArgs):
(WebCore::jsTestObjPrototypeFunctionByteMethodWithArgs):
(WebCore::jsTestObjPrototypeFunctionOctetMethodWithArgs):
(WebCore::jsTestObjPrototypeFunctionLongMethodWithArgs):
(WebCore::jsTestObjPrototypeFunctionObjMethodWithArgs):
(WebCore::jsTestObjPrototypeFunctionMethodWithXPathNSResolverParameter):
(WebCore::jsTestObjPrototypeFunctionMethodThatRequiresAllArgsAndThrows):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod8):
(WebCore::jsTestObjPrototypeFunctionDomStringListFunction):
(WebCore::jsTestObjPrototypeFunctionConvert1):
(WebCore::jsTestObjPrototypeFunctionStrictFunctionWithSequence):
(WebCore::jsTestObjPrototypeFunctionStrictFunctionWithArray):
(WebCore::jsTestObjPrototypeFunctionVariadicNodeMethod):
(WebCore::jsTestObjPrototypeFunctionTestPromiseOverloadedFunction2Promise):
- bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp:
(WebCore::constructJSTestOverloadedConstructors1):
(WebCore::constructJSTestOverloadedConstructors2):
(WebCore::constructJSTestOverloadedConstructors3):
- bindings/scripts/test/TestObj.idl:
LayoutTests:
Rebaseline existing tests now that we provide a more useful exception
message when passing null for a non-nullable parameter and assigning
null to a non-nullable attribute.
- editing/selection/extend-expected.txt:
- fast/dom/Document/adoptNode-null-expected.txt:
- fast/dom/Document/adoptNode-null.html:
- fast/dom/Document/importNode-null-expected.txt:
- fast/dom/Document/importNode-null.html:
- fast/dom/Element/attr-param-typechecking-expected.txt:
- fast/dom/MutationObserver/observe-exceptions-expected.txt:
- fast/dom/NamedNodeMap-setNamedItem-crash-expected.txt:
- fast/dom/Range/range-intersectsNode-expected.txt:
- fast/dom/createNodeIterator-parameters-expected.txt:
- fast/dom/createNodeIterator-parameters.html:
- fast/dom/createTreeWalker-parameters-expected.txt:
- fast/dom/createTreeWalker-parameters.html:
- fast/dom/xmlserializer-serialize-to-string-exception-expected.txt:
- fast/dynamic/insertAdjacentElement-expected.txt:
- fast/mediastream/MediaStream-add-remove-null-undefined-tracks-expected.txt:
- fast/speechsynthesis/speech-synthesis-crash-on-bad-utterance-expected.txt:
- fast/text/font-face-set-javascript-expected.txt:
- fast/text/text-combine-crash-expected.txt:
- media/encrypted-media/encrypted-media-v2-syntax-expected.txt:
- media/encrypted-media/encrypted-media-v2-syntax.html:
- webaudio/createMediaStreamSource-null-expected.txt:
- webaudio/createMediaStreamSource-null.html:
- webaudio/decode-audio-data-basic-expected.txt:
- webaudio/decode-audio-data-basic.html:
- webaudio/mediaelementaudiosourcenode-expected.txt:
- webaudio/mediaelementaudiosourcenode.html:
- 11:05 AM Changeset in webkit [200582] by
-
- 2 edits in trunk/Source/WebCore
Download progress on attachment elements sometimes exceeds element bounds
https://bugs.webkit.org/show_bug.cgi?id=157440
<rdar://problem/25245440>
Reviewed by Darin Adler.
In the case of very large dynamic type sizes, we can overflow the
bounds of the attachment. It turns out that we used to limit to one
line in many cases anyway, so only wrap if we have only a title and/or icon.
This looks better when you have many of the other elements even in
non-large-type modes.
- rendering/RenderThemeIOS.mm:
(WebCore::AttachmentInfo::buildTitleLines):
(WebCore::AttachmentInfo::AttachmentInfo):
Limit the title to a single line if we have anything
other than a title and icon.
(WebCore::attachmentBorderPath):
(WebCore::paintAttachmentBorder):
(WebCore::RenderThemeIOS::paintAttachment):
Clip to the border, so that even if somehow we paint outside of
the bounds, we don't paint over other parts of the page.
- 10:48 AM Changeset in webkit [200581] by
-
- 1 edit2 adds in trunk/LayoutTests
Focusing a shadow host places the slot content after the shadow DOM content
https://bugs.webkit.org/show_bug.cgi?id=154770
<rdar://problem/24873102>
Reviewed by Antti Koivisto.
Add a regression test now that the bug has been fixed.
- fast/shadow-dom/shadow-layout-after-focus-expected.html: Added.
- fast/shadow-dom/shadow-layout-after-focus.html: Added.
- 10:47 AM Changeset in webkit [200580] by
-
- 8 edits in trunk
REGRESSION (198056): Unable to use edit buttons on WordPress
https://bugs.webkit.org/show_bug.cgi?id=157475
Reviewed by Antti Koivisto.
Source/WebCore:
Renamed Event.prototype.deepPath() to composedPath() per discussions on
https://github.com/whatwg/dom/issues/242 as the old name was not Web compatible.
Test: fast/shadow-dom/Extensions-to-Event-Interface.html
- dom/Event.cpp:
(WebCore::Event::composedPath): Renamed from deepPath.
- dom/Event.h:
- dom/Event.idl:
LayoutTests:
Updated the tests.
- fast/shadow-dom/Extensions-to-Event-Interface-expected.txt:
- fast/shadow-dom/Extensions-to-Event-Interface.html:
- fast/shadow-dom/resources/event-path-test-helpers.js:
(dispatchEventWithLog):
- 10:32 AM Changeset in webkit [200579] by
-
- 2 edits in trunk/LayoutTests
Removing timeout and adding failure expectation for storage/indexeddb/intversion-open-in-upgradeneeded.html
https://bugs.webkit.org/show_bug.cgi?id=155050
Unreviewed test gardening.
- platform/mac-wk2/TestExpectations:
- 9:54 AM Changeset in webkit [200578] by
-
- 9 edits in trunk/Source
Don't use DiskCache for media resource loads
https://bugs.webkit.org/show_bug.cgi?id=157405
Patch by Alex Christensen <achristensen@webkit.org> on 2016-05-09
Reviewed by Darin Adler.
Source/WebCore:
http/tests/security/video-cross-origin-caching.html was loading from the disk cache.
This patch adds an assertion that fires in that test without this fix.
- loader/MediaResourceLoader.cpp:
(WebCore::MediaResourceLoader::requestResource):
- platform/graphics/PlatformMediaResourceLoader.h:
- platform/network/ResourceRequestBase.h:
(WebCore::ResourceRequestBase::hiddenFromInspector):
(WebCore::ResourceRequestBase::setHiddenFromInspector):
(WebCore::ResourceRequestBase::requester):
(WebCore::ResourceRequestBase::setRequester):
- platform/network/cocoa/WebCoreNSURLSession.mm:
(-[WebCoreNSURLSessionDataTask _restart]):
(-[WebCoreNSURLSessionDataTask resource:receivedResponse:]):
Source/WebKit2:
- NetworkProcess/cache/NetworkCache.cpp:
(WebKit::NetworkCache::makeRetrieveDecision):
(WebKit::NetworkCache::makeStoreDecision):
- NetworkProcess/cache/NetworkCache.h:
- NetworkProcess/cache/NetworkCacheStatistics.cpp:
(WebKit::NetworkCache::retrieveDecisionToDiagnosticKey):
- 9:28 AM Changeset in webkit [200577] by
-
- 2 edits in trunk/Source/WebKit/win
[wincairo] web inspector failed to launch in MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=156184
<rdar://problem/25539297>
Patch by Fujii Hironori <Fujii Hironori> on 2016-05-09
Reviewed by Alex Christensen.
- WebCoreSupport/WebInspectorClient.cpp:
(WebInspectorClient::openLocalFrontend): Enable
AllowFileAccessFromFileURLs and AllowUniversalAccessFromFileURLs
of WebPreferences for Web Inspector.
- 9:20 AM Changeset in webkit [200576] by
-
- 3 edits in trunk/Source/WebCore
Refactor FocusController::findFocusableElementRecursively
https://bugs.webkit.org/show_bug.cgi?id=157415
Reviewed by Darin Adler.
Refactor FocusController::findFocusableElementRecursively and related functions. Extracted two functions:
nextFocusableElementWithinScope and previousFocusableElementWithinScope out of it since they didn't really share
any code other than calling findFocusableElement at the beginning.
Also renamed internal variant of nextFocusableElement and previousFocusableElement to nextFocusableElementOrScopeOwner
and previousFocusableElementOrScopeOwner. It was confusing to have these internal functions in addition to public
member functions that are used in Objective-C DOM API.
No new tests are added since there should be no behavioral change.
- page/FocusController.cpp:
(WebCore::FocusController::findFocusableElementDescendingDownIntoFrameDocument): Added a FIXME.
(WebCore::FocusController::advanceFocusInDocumentOrder): Use findFocusableElementAcrossFocusScope instead of manually
calling findFocusableElementRecursively and findFocusableElementDescendingDownIntoFrameDocument separately.
(WebCore::FocusController::findFocusableElementAcrossFocusScope): Now that findFocusableElementWithinScope calls
findFocusableElementDescendingDownIntoFrameDocument internally, there is no need to keep around "found" local variable.
Introduce a few early exists for a better clarity.
(WebCore::FocusController::findFocusableElementWithinScope): Renamed from findFocusableElementRecursively. Also call
findFocusableElementDescendingDownIntoFrameDocument here instead of findFocusableElementAcrossFocusScope.
(WebCore::FocusController::nextFocusableElementWithinScope): Extracted from findFocusableElementRecursively.
(WebCore::FocusController::previousFocusableElementWithinScope): Ditto.
(WebCore::FocusController::findFocusableElement):
(WebCore::FocusController::nextFocusableElement): Added a FIXME.
(WebCore::FocusController::previousFocusableElement): Ditto.
(WebCore::FocusController::findFocusableElementOrScopeOwner): Renamed from findFocusableElement for clarity.
(WebCore::FocusController::nextFocusableElementOrScopeOwner): Ditto from nextFocusableElement.
(WebCore::FocusController::previousFocusableElementOrScopeOwner): Ditto from nextFocusableElement.
- page/FocusController.h:
- 9:09 AM Changeset in webkit [200575] by
-
- 2 edits in trunk/Source/WebInspectorUI
[css-grid] Update Grid Layout properties in CSSKeywordCompletions.js
https://bugs.webkit.org/show_bug.cgi?id=157166
Reviewed by Timothy Hatcher.
The CSS Grid Layout properties have been changing on the spec,
however they haven't been updated in CSSKeywordCompletions for a long time.
Update them using the last spec draft:
https://drafts.csswg.org/css-grid/#property-index
- UserInterface/Models/CSSKeywordCompletions.js:
- 8:16 AM MathML/Early_2016_Refactoring edited by
- (diff)
- 7:59 AM Changeset in webkit [200574] by
-
- 3 edits in trunk/Source/WebInspectorUI
Web Inspector: Cleanup issue tree elements in the Debugger sidebar
https://bugs.webkit.org/show_bug.cgi?id=157469
<rdar://problem/26162999>
Reviewed by Timothy Hatcher.
- UserInterface/Views/DebuggerSidebarPanel.js:
(WebInspector.DebuggerSidebarPanel):
(WebInspector.DebuggerSidebarPanel.prototype._addIssue):
Don't add duplicate issue tree elements.
(WebInspector.DebuggerSidebarPanel.prototype._handleIssuesCleared):
Remove issues from the correct tree outline.
- UserInterface/Views/IssueTreeElement.css:
(.issue .icon):
(.issue.warning .icon):
(.issue.error .icon):
Match dashboard icons.
- 7:52 AM Changeset in webkit [200573] by
-
- 12 edits1 copy in trunk/Source/WebInspectorUI
Web Inspector: Show in progress message in Timeline views that do not show data until the recording finishes
https://bugs.webkit.org/show_bug.cgi?id=156761
<rdar://problem/25970771>
Reviewed by Timothy Hatcher.
- Localizations/en.lproj/localizedStrings.js:
New UI strings.
- UserInterface/Main.html:
New view class.
- UserInterface/Views/HeapAllocationsTimelineView.js:
(WebInspector.HeapAllocationsTimelineView.prototype.get showsLiveRecordingData):
- UserInterface/Views/RenderingFrameTimelineView.js:
(WebInspector.RenderingFrameTimelineView.prototype.get showsLiveRecordingData):
- UserInterface/Views/ScriptDetailsTimelineView.js:
(WebInspector.ScriptDetailsTimelineView.prototype.get showsLiveRecordingData):
- UserInterface/Views/ScriptProfileTimelineView.js:
(WebInspector.ScriptProfileTimelineView.prototype.get showsLiveRecordingData):
Don't show live recording data.
- UserInterface/Views/ScriptClusterTimelineView.js:
(WebInspector.ScriptClusterTimelineView.prototype.get showsLiveRecordingData):
Forward property to current child TimelineView.
- UserInterface/Views/TimelineRecordingContentView.css:
(.content-view.timeline-recording > .content-browser .recording-progress):
(.content-view.timeline-recording > .content-browser .recording-progress > .status):
(.content-view.timeline-recording > .content-browser .recording-progress > .status > .indeterminate-progress-spinner):
New progress view styles.
- UserInterface/Views/TimelineRecordingContentView.js:
(WebInspector.TimelineRecordingContentView):
(WebInspector.TimelineRecordingContentView.prototype._currentContentViewDidChange):
(WebInspector.TimelineRecordingContentView.prototype._capturingStarted):
(WebInspector.TimelineRecordingContentView.prototype._capturingStopped):
Refresh progress view visibility.
(WebInspector.TimelineRecordingContentView.prototype._updateProgressView):
Show the progress view if we're currently capturing, and showing a view
that doesn't support showing live data.
- UserInterface/Views/TimelineRecordingProgressView.js:
(WebInspector.TimelineRecordingProgressView):
(WebInspector.TimelineRecordingProgressView.prototype.get visible):
(WebInspector.TimelineRecordingProgressView.prototype.set visible):
Show a status message, indeterminate progress spinner, and Stop Recording
button while timeline data is being recorded.
- UserInterface/Views/TimelineView.js:
(WebInspector.TimelineView.prototype.get showsLiveRecordingData):
Implemented by TimelineViews that don't support showing data while recording.
- UserInterface/Views/Variables.css:
(:root):
Add --panel-background-color-light for the progress view.
- 3:17 AM Changeset in webkit [200572] by
-
- 11 edits in trunk
[css-grid] Fix static position for positioned grid items
https://bugs.webkit.org/show_bug.cgi?id=157417
Reviewed by Darin Adler.
Source/WebCore:
The spec was updated to define properly the static position
for positioned grid items, but we didn't update the implementation yet:
https://drafts.csswg.org/css-grid-1/issues-wd-20150108#issue-1
We were only setting the static position when the start line
was not auto. Otherwise we were using the default one
which includes the padding.
With the spec change we need to set it always,
even if the start line is auto.
- rendering/RenderGrid.cpp:
(WebCore::RenderGrid::layoutPositionedObject):
(WebCore::RenderGrid::offsetAndBreadthForPositionedChild):
LayoutTests:
Updated several tests to follow the new expected behavior.
- fast/css-grid-layout/absolute-positioning-grid-container-containing-block.html:
- fast/css-grid-layout/absolute-positioning-grid-container-parent.html:
- fast/css-grid-layout/grid-positioned-items-gaps-rtl.html:
- fast/css-grid-layout/grid-positioned-items-gaps.html:
- fast/css-grid-layout/grid-positioned-items-implicit-grid-line.html:
- fast/css-grid-layout/grid-positioned-items-implicit-grid.html:
- fast/css-grid-layout/grid-positioned-items-unknown-named-grid-line.html:
- fast/css-grid-layout/grid-sizing-positioned-items.html:
- 1:55 AM Changeset in webkit [200571] by
-
- 3 edits in trunk/LayoutTests
Fix wrong gardening in r200570
Unreviewed EFL gardening.
- TestExpectations: Move selection gap tests to EFL's one.
- platform/efl/TestExpectations:
- 1:51 AM Changeset in webkit [200570] by
-
- 2 edits in trunk/LayoutTests
[EFL] Skip tests of selection gap because EFL port disabled to paint the selection gap
Unreviewed EFL gardening.
May 8, 2016:
- 10:51 PM Changeset in webkit [200569] by
-
- 3 edits in trunk/Source/WebCore
RenderMathMLOperator: refactor management of stretchy data and italic correction
https://bugs.webkit.org/show_bug.cgi?id=156913
Patch by Frederic Wang <fwang@igalia.com> on 2016-05-08
Reviewed by Darin Adler.
No new tests, behavior is not changed.
The stretchy data uses a shared space to describe horizontal / vertical directions and
unstretched / size variant / glyph assembly. We use a simple struct with some unions to
represent it instead of the current implementation with a class.
We also modify the signature of some functions to retrieve display operator and stretchy
data to use that new structure and prepare the move to a separate MathOperator class.
Finally, we introduce some helper functions to easily set the stretchy data.
- rendering/mathml/RenderMathMLOperator.cpp:
(WebCore::RenderMathMLOperator::computePreferredLogicalWidths): Use the new data members and
function signatures.
(WebCore::RenderMathMLOperator::setSizeVariant): New helper function to set a size variant.
(WebCore::RenderMathMLOperator::setGlyphAssembly): New helper function to set a glyph
assembly.
(WebCore::RenderMathMLOperator::getGlyphAssemblyFallBack): We change the signature to use a
GlyphAssemblyData.
(WebCore::RenderMathMLOperator::findDisplayStyleLargeOperator): We rename the function and
change its signature to remove the return value. We now also set the italic correction when
a display operator is found.
(WebCore::RenderMathMLOperator::findStretchyData): We change the signature to introduce a
target size and remove the return value. This also does the early return when the base glyph
is large enough.
(WebCore::RenderMathMLOperator::updateStyle): We use the new data members and function
signatures. The check for the base glyph size is now done in findStretchyData, so we just
check whether m_stretchType is Unstretched to do an early return.
(WebCore::RenderMathMLOperator::firstLineBaseline): We use m_stretchType.
(WebCore::RenderMathMLOperator::computeLogicalHeight): Ditto.
(WebCore::RenderMathMLOperator::fillWithVerticalExtensionGlyph): Use the new class members.
(WebCore::RenderMathMLOperator::fillWithHorizontalExtensionGlyph): Ditto.
(WebCore::RenderMathMLOperator::paint): Ditto.
(WebCore::RenderMathMLOperator::paintVerticalGlyphAssembly): Ditto.
(WebCore::RenderMathMLOperator::paintHorizontalGlyphAssembly): Ditto.
(WebCore::RenderMathMLOperator::paintChildren): Ditto.
(WebCore::RenderMathMLOperator::trailingSpaceError): Ditto.
(WebCore::RenderMathMLOperator::italicCorrection): Moved to RenderMathMLOperator.h.
(WebCore::RenderMathMLOperator::getDisplayStyleLargeOperator): Deleted.
- rendering/mathml/RenderMathMLOperator.h:
(WebCore::RenderMathMLOperator::italicCorrection): We just return m_italicCorrection.
(WebCore::RenderMathMLOperator::GlyphAssemblyData::GlyphAssemblyData): New class to store an
assembly of GlyphData.
(WebCore::RenderMathMLOperator::StretchyData::mode): Deleted.
(WebCore::RenderMathMLOperator::StretchyData::variant): Deleted.
(WebCore::RenderMathMLOperator::StretchyData::top): Deleted.
(WebCore::RenderMathMLOperator::StretchyData::extension): Deleted.
(WebCore::RenderMathMLOperator::StretchyData::bottom): Deleted.
(WebCore::RenderMathMLOperator::StretchyData::middle): Deleted.
(WebCore::RenderMathMLOperator::StretchyData::left): Deleted.
(WebCore::RenderMathMLOperator::StretchyData::right): Deleted.
(WebCore::RenderMathMLOperator::StretchyData::setNormalMode): Deleted.
(WebCore::RenderMathMLOperator::StretchyData::setSizeVariantMode): Deleted.
(WebCore::RenderMathMLOperator::StretchyData::setGlyphAssemblyMode): Deleted.
(WebCore::RenderMathMLOperator::StretchyData::StretchyData): Deleted.
- 10:51 PM MathML/Early_2016_Refactoring edited by
- (diff)
- 9:55 PM Changeset in webkit [200568] by
-
- 9 edits2 deletes in trunk/Source
[COCOA] Disable HAVE_DTRACE at build time
https://bugs.webkit.org/show_bug.cgi?id=157433
<rdar://problem/26148841>
Reviewed by Mark Lam.
Source/JavaScriptCore:
Drop DTRACE-related code from JSC since it is very old and seems
unused.
- JavaScriptCore.xcodeproj/project.pbxproj:
- PlatformMac.cmake:
- heap/Heap.cpp:
(JSC::Heap::collectImpl): Deleted.
(JSC::Heap::didFinishCollection): Deleted.
- profiler/ProfileGenerator.cpp:
(JSC::ProfileGenerator::willExecute): Deleted.
(JSC::ProfileGenerator::didExecute): Deleted.
- runtime/Tracing.d: Removed.
- runtime/Tracing.h: Removed.
Source/WTF:
Disable HAVE_DTRACE on COCOA since it is mostly unused and has a performance
impact, at least on iOS.
- wtf/Platform.h:
- 7:37 PM Changeset in webkit [200567] by
-
- 3 edits2 adds in trunk
iOS selection: Use inflow containing block for positioned <br>.
https://bugs.webkit.org/show_bug.cgi?id=157115
<rdar://problem/25969295>
Reviewed by Ryosuke Niwa.
Similarly to RenderText, we should just use the inflow containing block for
selected <br> even when it is positioned out of flow. This visually matches Mac OS X
behaviour (selection painting does not get extended to the positioned <br>).
Source/WebCore:
Test: fast/text/fixed-positioned-br-crash.html
- rendering/RenderLineBreak.cpp:
(WebCore::RenderLineBreak::collectSelectionRects):
LayoutTests:
- fast/text/fixed-positioned-br-crash-expected.txt: Added.
- fast/text/fixed-positioned-br-crash.html: Added.
- 4:57 PM Changeset in webkit [200566] by
-
- 4 edits in trunk/Source/WebInspectorUI
Web Inspector: Add Breakpoints and Scripts folders to Debugger sidebar
https://bugs.webkit.org/show_bug.cgi?id=151119
<rdar://problem/23488916>
Reviewed by Timothy Hatcher.
Add a collapsible Sources section to the Debugger beneath the existing
Breakpoints section.
- UserInterface/Views/DebuggerSidebarPanel.css:
Remove unused CSS class names.
(.sidebar > .panel.navigation.debugger .details-section.scripts:not(.collapsed)):
Hide scripts section bottom border when expanded. As the last
section, a border only adds visual clutter.
(.sidebar > .panel.navigation.debugger .details-section.scripts): Deleted.
(.sidebar > .panel.navigation.debugger.paused .details-section.scripts): Deleted.
(.sidebar > .panel.navigation.debugger .details-section.scripts .header): Deleted.
(.sidebar > .panel.navigation.debugger.paused .details-section.scripts .header): Deleted.
(.sidebar > .panel.navigation.debugger .details-section.scripts.collapsed > .content): Deleted.
(.sidebar > .panel.navigation.debugger.paused .details-section.scripts.collapsed > .content): Deleted.
No longer needed.
- UserInterface/Views/DebuggerSidebarPanel.js:
(WebInspector.DebuggerSidebarPanel):
Create separate "Breakpoints" and "Sources" sections, and make filter
placeholder text generic. Remove unused class from breakpoints tree.
(WebInspector.DebuggerSidebarPanel.prototype.treeElementForRepresentedObject):
Check both breakpoint and scripts tree outlines.
(WebInspector.DebuggerSidebarPanel.prototype._addBreakpoint):
(WebInspector.DebuggerSidebarPanel.prototype._addTreeElementForSourceCodeToTreeOutline):
Make helper function generic.
(WebInspector.DebuggerSidebarPanel.prototype._addResource):
(WebInspector.DebuggerSidebarPanel.prototype._mainResourceDidChange):
(WebInspector.DebuggerSidebarPanel.prototype._addScript):
Add resources to the scripts tree.
(WebInspector.DebuggerSidebarPanel.prototype._scriptsCleared):
Clear the scripts tree.
(WebInspector.DebuggerSidebarPanel.prototype._removeDebuggerTreeElement):
Remove script element when last breakpoint is removed.
(WebInspector.DebuggerSidebarPanel.prototype._addIssue):
(WebInspector.DebuggerSidebarPanel.prototype._addTreeElementForSourceCodeToContentTreeOutline): Deleted.
Renamed _addTreeElementForSourceCodeToTreeOutline.
- 4:55 PM Changeset in webkit [200565] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: SourceCodeTextEditor issue widgets/line styles should reset when log is cleared
https://bugs.webkit.org/show_bug.cgi?id=157460
<rdar://problem/26159633>
Reviewed by Timothy Hatcher.
- UserInterface/Views/SourceCodeTextEditor.js:
(WebInspector.SourceCodeTextEditor):
(WebInspector.SourceCodeTextEditor.prototype._logCleared):
Clear issue widgets and CodeMirror line class names when log cleared.
- 4:03 PM Changeset in webkit [200564] by
-
- 2 edits in trunk/Source/WebCore
[iOS] Build fix after r200563
Unreviewed.
- editing/cocoa/HTMLConverter.mm:
(_font):
- 3:54 PM Changeset in webkit [200563] by
-
- 16 edits in trunk/Source
[OS X] Migrate our Font classes entirely off of NSFont
https://bugs.webkit.org/show_bug.cgi?id=157464
Reviewed by Darin Adler.
Source/WebCore:
Because NSFont and CTFont are toll-free-bridged, we don't need NSFont at all anywhere.
No new tests because there is no behavior change.
- accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(accessibilitySearchCriteriaForSearchPredicateParameterizedAttribute):
(textMarkerRangeFromRange):
(visiblePositionForStartOfTextMarkerRange):
(visiblePositionForEndOfTextMarkerRange):
(AXAttributedStringRangeIsValid):
(AXAttributeStringSetFont):
(CreateCGColorIfDifferent):
(AXAttributeStringSetStyle):
(textMarkerRangeFromVisiblePositions):
- bindings/objc/DOM.mm:
(-[DOMElement _font]):
- bindings/objc/DOMPrivate.h:
- editing/cocoa/HTMLConverter.mm:
(_font):
(WebCore::editingAttributedStringFromRange):
- editing/mac/EditorMac.mm:
(WebCore::Editor::fontAttributesForSelectionStart):
- platform/graphics/Font.h:
(WebCore::Font::getCTFont):
(WebCore::Font::getNSFont): Deleted.
- platform/graphics/FontPlatformData.h:
(WebCore::FontPlatformData::nsFont): Deleted.
- platform/graphics/cocoa/FontCocoa.mm:
(WebCore::Font::determinePitch):
(WebCore::advanceForColorBitmapFont):
(WebCore::Font::platformWidthForGlyph):
(WebCore::renderingStyle): Deleted.
- platform/graphics/cocoa/FontPlatformDataCocoa.mm:
Source/WebKit/mac:
- WebCoreSupport/PopupMenuMac.mm:
(PopupMenuMac::populate):
(PopupMenuMac::show):
- WebView/WebHTMLView.mm:
(fontNameForDescription):
(-[WebHTMLView _addToStyle:fontA:fontB:]):
Source/WebKit2:
- WebProcess/WebCoreSupport/mac/WebPopupMenuMac.mm:
(WebKit::WebPopupMenu::setUpPlatformData):
- WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::WebPage::fontAtSelection):
- 2:56 PM Changeset in webkit [200562] by
-
- 8 edits in trunk/Source
[Bindings] Simplify [RequiresExistingAtomicString] IDL extended attribute handling
https://bugs.webkit.org/show_bug.cgi?id=157465
Reviewed by Darin Adler.
Source/WebCore:
Simplify [RequiresExistingAtomicString] IDL extended attribute handling
in the bindings generator.
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateParametersCheck):
Drop code specific to [RequiresExistingAtomicString].
(JSValueToNative):
Deal with [RequiresExistingAtomicString] IDL extended attribute,
similarly to [AtomicString] and [TreatNullAs].
- bindings/scripts/test/JS/JSTestObj.cpp:
- bindings/scripts/test/TestObj.idl:
Add bindings test coverage.
- dom/DocumentFragment.cpp:
(WebCore::DocumentFragment::getElementById):
- svg/SVGSVGElement.cpp:
(WebCore::SVGSVGElement::getElementById):
Add null check for the id parameter. The generated bindings used to do
this null check for us but it is no longer the case (to make the bindings
generator a bit simpler). This extended attribute is not commonly used
and is meant as a micro-optimization for getElementById().
Source/WTF:
Add an AtomicString(RefPtr<AtomicStringImpl>&&) constructor that is now
used by the bindings when [RequiresExistingAtomicString] is used. This
is more efficient than using AtomicString(AtomicStringImpl*) as the
caller has a RefPtr<AtomicStringImpl> and is consistent with the
pre-existing String(RefPtr<AtomicStringImpl>&&) constructor.
- wtf/text/AtomicString.h:
(WTF::AtomicString::AtomicString):
- 12:11 PM Changeset in webkit [200561] by
-
- 2 edits in trunk/Source/WebCore
Roll out: ThreadSanitizer: Data race and thread leak in WebCore::ScrollingThread::createThreadIfNeeded
<https://webkit.org/b/157462>
This reverts commit r200554.
This doesn't fix the data race, and the thread leak is a
separate issue.
- page/scrolling/ScrollingThread.cpp:
(WebCore::ScrollingThread::createThreadIfNeeded): Roll out the
change.
- 12:05 PM Changeset in webkit [200560] by
-
- 2 edits in trunk/Source/WTF
- wtf/text/WTFString.h: Remove pragma once. Not working for some reason.
- 12:00 PM Changeset in webkit [200559] by
-
- 4 edits in trunk/Source
WTF:
Follow-up to that last patch (missed review comments).
- wtf/text/WTFString.h: Use nullptr instead of 0 as needed. Also use pragma once.
WebCore:
Follow-up to that last patch (missed review comments).
- page/EventSource.cpp:
(WebCore::EventSource::parseEventStream): Pre-increment, not post-increment.
(WebCore::EventSource::dispatchMessageEvent): More elegant form without explicit StringView.
- 11:46 AM Changeset in webkit [200558] by
-
- 8 edits in trunk/Source
Change EventSource constructor to take an IDL dictionary instead of a WebCore::Dictionary
https://bugs.webkit.org/show_bug.cgi?id=157459
Reviewed by Chris Dumez.
Source/WebCore:
Patch also includes some updating of EventSource class to modern idioms.
- page/EventSource.cpp:
(WebCore::EventSource::EventSource): Initialize based on Init.
(WebCore::EventSource::create): Take/pass Init instead of Dictionary.
- bindings/js/SerializedScriptValue.cpp:
(WebCore::CloneSerializer::serialize): Take a StringView instead of a string
so callers don't have to allocate a String just to use this.
(WebCore::SerializedScriptValue::create): Ditto.
- bindings/js/SerializedScriptValue.h: Ditto.
- page/EventSource.cpp: Changed defaultReconnectDelay to be a uint64_t
instead of an unsigned long long.
(WebCore::EventSource::EventSource): Changed constructor to take a struct
instead of a Dictionary for eventSourceInit. Also moved initialization of
data members to the header and used ASCIILiteral.
(WebCore::EventSource::create): Changed type to Init and streamlined code
a little bit using auto.
(WebCore::EventSource::connect): Used a reference instead of a pointer.
Also added a FIXME since I noticed that m_requestInFlight is probably not
needed, since it's basically the same thing as "is m_loader null".
(WebCore::EventSource::url): Moved to the header and made it inline.
(WebCore::EventSource::networkRequestEnded): Removed unneeded check that
is already done by all callers and turned it into an assertion.
(WebCore::EventSource::withCredentials): Ditto.
(WebCore::EventSource::readyState): Ditto.
(WebCore::EventSource::responseIsValid): Added. Helper function to make
the logic in didReceiveResponse easier to read. Fixed logic to compare
MIME type ignoring ASCII case, since that's how MIME types work.
(WebCore::EventSource::didReceiveResponse): Use the helper above, and also
move the m_eventStreamOrigin set up code into the valid response case,
since there is no point doing it if the response is not valid. Also use
the early return idiom.
(WebCore::EventSource::didReceiveData): Removed the unneeded explicit
conversion to StringView here. Also removed a FIXME that I fixed.
(WebCore::EventSource::didFinishLoading): Added code to flush the decoder
as mentioned in didReceiveData. Added FIXME about peculiar clearing code
that exists only here. Removed check for empty receive buffer and data
that is not needed since parseEventStream does sufficient checking.
(WebCore::EventSource::didFail): Added FIXME because of things that
didFinishLoading does that seem equally valuable here.
(WebCore::EventSource::parseEventStream): Tweaked types and names of local
variables, and changed to use Optional instead of magic number -1. Also
added a FIXME about how the buffer type is probably not right since we
keep moving the characters in the buffer as we consume the start of it.
(WebCore::EventSource::parseEventStreamLine): Refactor and reorganize so
this doesn't do so much string allocation and is easier to read
(WebCore::EventSource::canSuspendForDocumentSuspension): Tweaked comment.
(WebCore::EventSource::dispatchMessageEvent): Renamed this from
createMessageEvent, and moved more code in here. We now don't have to
allocate a temporary string just to pass it to SerializedScriptValue.
- page/EventSource.h: Updated for changes above. Use pragma once.
Define and use EventSource::Init struct. Other small cleanup.
- page/EventSource.idl: Define EventSourceInit dictionary and use it.
Other small cleanup.
- page/EventSource.idl: U
Source/WTF:
- wtf/text/WTFString.h: Export a symbol now used in WebCore.
- 11:35 AM Changeset in webkit [200557] by
-
- 4 edits in trunk/Source/WebCore
Change HTMLSlotElement::assignedNodes to take a IDL dictionary instead of a WebCore::Dictionary
https://bugs.webkit.org/show_bug.cgi?id=157457
Reviewed by Chris Dumez.
- html/HTMLSlotElement.cpp:
(WebCore::HTMLSlotElement::removedFrom): Fixed typo in comment.
(WebCore::HTMLSlotElement::assignedNodes): Renamed assignedNodesForBindings back to this
and changed the argument type to Optional<AssignedNodesOptions> instead of Dictionary.
Also streamlined the logic a bit.
(WebCore::HTMLSlotElement::enqueueSlotChangeEvent): Changed to use a pointer to the
enqueued event instead of a boolean. With only a boolean, we could end up clearing the
flag in cases where we don't really want to.
(WebCore::HTMLSlotElement::dispatchEvent): Ditto.
(WebCore::HTMLSlotElement::assignedNodesForBindings): Deleted.
- html/HTMLSlotElement.h: Use pragma once. Added AssignedNodeOptions. Changed for the
above, including changing the data member.
- html/HTMLSlotElement.idl: Removed use of ImplementedAs. Fixed the type of the options
dictionary.
- 11:29 AM Changeset in webkit [200556] by
-
- 22 edits in trunk/Source/WebCore
[Bindings] Add convert<>() template specializations for integer types
https://bugs.webkit.org/show_bug.cgi?id=157458
Reviewed by Darin Adler.
Add convert<>() template specializations for integer types and use them
in the JS bindings. Also, treat non-32bit types the same way as the
32bit ones, allowing the compiler to optimize out branching based on
the IntegerConversionConfiguration.
- bindings/js/JSCryptoAlgorithmDictionary.cpp:
- bindings/js/JSDOMBinding.cpp:
(WebCore::enforceRange):
(WebCore::toSmallerInt):
(WebCore::toSmallerUInt):
(WebCore::toInt8EnforceRange):
(WebCore::toUInt8EnforceRange):
(WebCore::toInt8Clamp):
(WebCore::toUInt8Clamp):
(WebCore::toInt8):
(WebCore::toUInt8):
(WebCore::toInt16EnforceRange):
(WebCore::toUInt16EnforceRange):
(WebCore::toInt16Clamp):
(WebCore::toUInt16Clamp):
(WebCore::toInt16):
(WebCore::toUInt16):
(WebCore::toInt32EnforceRange):
(WebCore::toInt32Clamp):
(WebCore::toUInt32Clamp):
(WebCore::toUInt32EnforceRange):
(WebCore::toInt64EnforceRange):
(WebCore::toUInt64EnforceRange):
(WebCore::toInt64Clamp):
(WebCore::toUInt64Clamp):
(WebCore::toInt64):
(WebCore::toUInt64):
- bindings/js/JSDOMBinding.h:
- Splt some integer conversion functions into 3 Normal / Clamp / Enforce versions, similarly to what was done for 32bit types already. This is so that these can be called from the inline functions in JSDOMConvert.h, allowing the compiler to optimize out the branches.
- Get rid of some unnecessary state.hadException() checks.
- bindings/js/JSDOMConvert.h:
Add convert<> specializations for integer types.
- bindings/js/JSNodeFilterCustom.cpp:
(WebCore::JSNodeFilter::acceptNode):
- bindings/scripts/CodeGenerator.pm:
- Add utility function to distinguish integer types.
- Have IsNumericType() using the integerType / floatingPointType hashes to avoid duplication.
- Stop int / unsigned int from integer types as those are not in Web IDL and they are not used.
- bindings/scripts/CodeGeneratorJS.pm:
(GetIntegerConversionType):
(JSValueToNative):
Use convert<>() for converting JSValue to integer types.
- bindings/scripts/IDLParser.pm:
Stop allowing int / unsigned int types as those are not in Web IDL.
- bindings/scripts/test/JS/JSTestEventTarget.cpp:
- bindings/scripts/test/JS/JSTestGlobalObject.cpp:
- bindings/scripts/test/JS/JSTestObj.cpp:
- bindings/scripts/test/JS/JSTestTypedefs.cpp:
Rebaseline bindings tests.
- 9:54 AM Changeset in webkit [200555] by
-
- 9 edits in trunk
Correct dictionary bindings handling of optional, null, and undefined
https://bugs.webkit.org/show_bug.cgi?id=157463
Reviewed by Chris Dumez.
Source/WebCore:
- bindings/js/JSDOMBinding.cpp:
(WebCore::propertyValue): Deleted.
- bindings/js/JSDOMBinding.h: Deleted propertyValue, not all that helpful for now.
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateDictionaryImplementationContent): Added a new early exit for convert to
a dictionary type when the value is undefined or null and all members are either
optional or have a default value. This returns the default values for everything
without raising an exception. Added checking that requires that the dictionary
argument is an object and not a regular expression, since that's also called for
in the latest draft of the Web IDL specification. This ends up speeding up the
code a bit since we now use JSObject::get for properties instead of JSValue::get.
(GenerateParametersCheck): Renamed some local variables. Taught the code that
optional dictionaries all have a default value; before it was doing that for the
type "Dictionary" but not the real dictionary types (IsDictionaryType).
- bindings/scripts/test/JS/JSTestObj.cpp: Regenerated.
- css/FontFace.cpp:
(WebCore::FontFace::create): Changed argument to be Descriptors instead of
Optional<Descriptors>. It would have compiled the other way, but there is now
no caller that will pass a null. Because the IDL dictionary support was new,
this was the only place that was doing it wrong. Good that we "nipped it in the bud"
before doing this in more places.
- css/FontFace.h: Ditto.
LayoutTests:
- fast/dom/MutationObserver/observe-exceptions-expected.txt: Reverted that
change to expect a more specific TypeError just as it was a day ago before
my last patch. The TypeError is back to being a problem with the specifics
of the arguments passed rather than a problem with null and undefined
themselves being invalid.
- 8:22 AM Changeset in webkit [200554] by
-
- 2 edits in trunk/Source/WebCore
ThreadSanitizer: Data race and thread leak in WebCore::ScrollingThread::createThreadIfNeeded
<https://webkit.org/b/157462>
Reviewed by Darin Adler.
Reproduced with multiple existing tests.
- page/scrolling/ScrollingThread.cpp:
(WebCore::ScrollingThread::createThreadIfNeeded): Use a
std::once_flag to initialize Scrolling Thread since this may be
called from background threads.
- 12:11 AM Changeset in webkit [200553] by
-
- 2 edits in trunk/Source/WebCore
Try to fix build without rolling out that last change.
- bindings/js/JSDOMConvert.h:
(WebCore::convert<Vector<String>>): Make this an inline. Just call toNativeArray.
May 7, 2016:
- 11:39 PM Changeset in webkit [200552] by
-
- 12 edits in trunk
Change MutationObserver::observe to take an IDL dictionary, rather than WebCore::Dictionary
https://bugs.webkit.org/show_bug.cgi?id=157456
Reviewed by Chris Dumez.
Source/WebCore:
- bindings/js/JSDOMConvert.h:
(WebCore::convertOptional): Use a specific Optional null rather than Nullopt so we
can compile the ternary operator.
(WebCore::convert<bool>): Added.
(WebCore::convert<Vector<String>>): Added. Later we probably need to change convert to use
a member function of a class template rather than a function template so we can make partial
specialization work and do this just once for all Vector<T>.
- bindings/js/JSMutationObserverCustom.cpp:
(WebCore::JSMutationObserverOwner::isReachableFromOpaqueRoots): Streamlined code and removed
some local variables. Changed to call the new observedNodes rather than getObservedNodes.
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateDictionaryImplementationContent): Fixed bug where we tried to call the version of
the convert function with a default value even when there was none.
- bindings/scripts/test/TestObj.idl: Added a test case basically identical to what's needed
in MutationObserver.idl.
- bindings/scripts/test/JS/JSTestObj.cpp: Regenerated.
- dom/MutationObserver.cpp:
(WebCore::MutationObserver::observe): Chagned function to take a MutationObserver::Init
instead of a Dictionary.
(WebCore::MutationObserver::observationStarted): Changed argument type to a reference.
(WebCore::MutationObserver::observationEnded): Ditto.
(WebCore::MutationObserverMicrotask): Removed unneeded explicit constructor and destructor.
(WebCore::queueMutationObserverCompoundMicrotask): Got rid of unnneeded local variable.
(WebCore::MutationObserver::observedNodes): Renamed to remove the "get" prefix.
- dom/MutationObserver.h: Reduced includes. Added MutationObserver::Init struct and
used it for the type of the argument to the observe function. Changed a few argument
types and removed unused forward declarations.
- dom/MutationObserver.idl: Added MutationObserverInit and used it instead of Dictionary.
- dom/MutationObserverRegistration.cpp:
(WebCore::MutationObserverRegistration::MutationObserverRegistration): Pass a reference.
(WebCore::MutationObserverRegistration::~MutationObserverRegistration): Ditto.
LayoutTests:
- fast/dom/MutationObserver/observe-exceptions-expected.txt: Updated to expect
the specific TypeError generated by the bindings code rather than the generic
TypeError we got before generated inside the C++ DOM.
- 9:57 PM Changeset in webkit [200551] by
-
- 2 edits in trunk/Websites/perf.webkit.org
Add horizontal between categories of tests
https://bugs.webkit.org/show_bug.cgi?id=157386
Reviewed by Darin Adler.
Wrap tests in each category by tbody and add a horizontal bar between each category.
- public/v3/pages/summary-page.js:
(SummaryPage.prototype._constructTable):
(SummaryPage.cssTemplate):
- 9:39 PM Changeset in webkit [200550] by
-
- 29 edits1 add in trunk/Source/WebCore
Reduce special handling of XPathNSResolver type in the bindings
https://bugs.webkit.org/show_bug.cgi?id=157454
Reviewed by Darin Adler.
Reduce special handling of XPathNSResolver type in the bindings.
- CMakeLists.txt:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSBindingsAllInOne.cpp:
Add new JSXPathNSResolverCustom.cpp file.
- bindings/js/JSDOMStringListCustom.cpp:
(WebCore::JSDOMStringList::toWrapped):
Take the ExecState by reference instead of pointer.
- bindings/js/JSDOMWindowCustom.cpp:
(WebCore::JSDOMWindow::toWrapped):
Update to take an ExecState& parameter. The bindings now pass
an ExecState to all custom toWrapped() methods for consistency
and flexibility.
- bindings/js/JSDictionary.cpp:
(WebCore::JSDictionary::convertValue):
Pass an ExecState now that those toWrapped() methods expect
it.
- bindings/js/JSEventTargetCustom.cpp:
(WebCore::JSEventTarget::toWrapped):
Update to take an ExecState& parameter.
- bindings/js/JSIDBDatabaseCustom.cpp:
(WebCore::JSIDBDatabase::transaction):
Pass ExecState by reference instead of pointer.
- bindings/js/JSMessageEventCustom.cpp:
(WebCore::handleInitMessageEvent):
Pass ExecState to JSDOMWindow::toWrapped().
- bindings/js/JSXPathNSResolverCustom.cpp: Added.
(WebCore::JSXPathNSResolver::toWrapped):
Provide a custom implementation of JSXPathNSResolver::toWrapped()
instead of having the custom code in the bindings generator.
- bindings/scripts/CodeGeneratorJS.pm:
(AddIncludesForType):
Drop special includes for XPathNSResolver as they are no longer needed.
(GenerateHeader):
Drop special casing of certain types for generating the toWrapped()
declaration by:
- Relying on GetNativeType() for the return value as certain types return a RefPtr instead of a raw pointer.
- Adding an extra ExecState parameter when a custom implementation of toWrapped() is provided, given that some of them need it.
(GenerateParametersCheck):
Drop custom code for XPathNSResolver and use the normal code path for
this type now. The custom code now resides in the custom implementation
of JSXPathNSResolver::toWrapped(), in custom bindings.
(JSValueToNative):
- Drop NodeFilter from the nativeType hash map as it was updated to be a callback interface a while back.
- Add XPathNSResolver to nativeType hash map so that we now to use a RefPtr<> instead of a raw pointer in the bindings. We should probably add an IDL extended attribute for this at some point.
- Drop special casing for DOMStringList which was outdated since there is no toDOMStringList() function. DOMStringList has a custom toWrapped() function instead nowadays so we now call this one instead. We apparently do not have any DOMStringList parameters outside our bindings tests at the moment, which is why no one noticed.
- Pass an ExecState to toWrapped() if the interface has the JSCustomToNativeObject IDL extended attribute.
- bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
- bindings/scripts/test/GObject/WebKitDOMTestObj.h:
- bindings/scripts/test/JS/JSTestObj.cpp:
- bindings/scripts/test/ObjC/DOMTestObj.h:
- bindings/scripts/test/ObjC/DOMTestObj.mm:
- bindings/scripts/test/TestObj.idl:
Add bindings test coverage for having an operation with an
XPathNSResolver parameter.
- dom/Document.idl:
- xml/XPathEvaluator.idl:
Drop some unnecessary default parameter values.
- xml/XPathNSResolver.idl:
Add JSCustomToNativeObject IDL extended attribute so that we can
provide our own custom implementation of JSXPathNSResolver::toWrapped(),
instead of having the custom code in the bindings generator.
- dom/Document.cpp:
(WebCore::Document::createExpression):
(WebCore::Document::evaluate):
- dom/Document.h:
- inspector/InspectorNodeFinder.cpp:
- xml/XPathEvaluator.cpp:
(WebCore::XPathEvaluator::createExpression):
(WebCore::XPathEvaluator::evaluate):
- xml/XPathEvaluator.h:
- xml/XPathExpression.cpp:
(WebCore::XPathExpression::createExpression):
- xml/XPathExpression.h:
- xml/XPathParser.cpp:
(WebCore::XPath::Parser::Parser):
(WebCore::XPath::Parser::parseStatement):
- xml/XPathParser.h:
Take XPathNSResolver parameter as a Ref<XPathNSResolver>&& as this is
what the generated bindings now provide us, given that this sometimes
have to create a wrapper around a JSObject.
- 3:29 PM Changeset in webkit [200549] by
-
- 2 edits in trunk/Source/WebCore
Fix crash introduced by the last patch.
Fix suggested by Chris Dumez.
- css/FontFace.cpp:
(WebCore::FontFace::FontFace): Roll out incorrect change. Things were getting
initialized in the wrong order in a change I had made to the FontFace constructor
that takes a CSSFontSelector.
- 2:36 PM Changeset in webkit [200548] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed, rebaseline bindings tests after r200547.
- bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::convert<TestObj::FontFaceDescriptors>):
- 2:14 PM Changeset in webkit [200547] by
-
- 18 edits1 move in trunk
Next step on dictionary bindings, along with other bindings refinements
https://bugs.webkit.org/show_bug.cgi?id=157451
Reviewed by Chris Dumez.
Source/WebCore:
Converted one dictionary, the one passed to the constructor in FontFace.
- WebCore.xcodeproj/project.pbxproj: Updated for name change of JSDOMBuild.h to
JSDOMConvert.h and also let Xcode update a file type.
- bindings/js/JSDOMBinding.cpp:
(WebCore::propertyValue): Added.
- bindings/js/JSDOMBinding.h: Use pragma once. Remove unnecessary forward declaration.
Move all declarations to the top of the file, separating them from definitions. This
is a small step toward better overview of what's in this file and paves the way for
future simplifications and improvements we can make after we observe patterns.
Also removed a couple unused functions.
- bindings/js/JSDOMConvert.h: Renamed from JSDOMBuild.h.
Renamed function templates from build to convert. Added convertOptional.
- bindings/js/ReadableStreamController.cpp:
(WebCore::callFunction): Use auto and remove some unneeded namespacing.
(WebCore::ReadableStreamController::invoke): Ditto. Also remove use of helper function
getPropertyFromObject, since this was the only call site and it was not very helpful.
(WebCore::ReadableStreamController::isControlledReadableStreamLocked): Ditto.
(WebCore::createReadableStream): Ditto.
(WebCore::getReadableStreamReader): Ditto.
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateEnumerationImplementationContent): Updated for name change from build to
convert and JSDOMBuild.h to JSDOMConvert.h.
(GenerateDictionaryImplementationContent): Ditto. Also added code to handle optional
and added explicit exception checking, using local variables. Not clear longer term
if the local variable approach is OK since this will unnecessarily change types like
const String& to String.
(GenerateParametersCheck): Removed local variable $optional and use $parameter->isOptional
directly consistently. This is slightly clearer because the old code used a mix of the
two, and also is a better pattern for when we refactor this into smaller functions.
Note that this function name is not good any more--this is a lot more then parameter checks.
(GetNativeType): Return appropriate name for dictionary types.
(JSValueToNative): Updated for name change from build to convert and JSDOMBuild.h to
JSDOMConvert.h.
- bindings/scripts/test/JS/JSTestObj.cpp:
- bindings/scripts/test/JS/JSTestTypedefs.cpp:
Regenerated results.
- bindings/scripts/test/TestObj.idl: Added another dictionary test case, just a copy
of the current state of the one in FontFace.idl.
- css/CSSFontFace.cpp:
(WebCore::CSSFontFace::setUnicodeRange): Update for simplified UnicodeRange struct.
(WebCore::CSSFontFace::setFeatureSettings): Fix to correctly handle being called
with "normal". Also fix so it doesn't call fontPropertyChanged if nothing changed.
Also got rid of return value, which had no real value: it was returning false for
some bad inputs, but others would just lead to assertions, and the real reason this
was OK is that this function is only passed known-valid values.
- css/CSSFontFace.h: Used prama once. Tweaked formatting. Removed return value from
the setFeatureSettings function. Changed UnicodeRange to be struct with public data
members instead a struct with a constructor and getter functions.
- css/CSSFontSelector.cpp:
(WebCore::CSSFontSelector::addFontFaceRule): Updated since setFeatureSettings no
longer has a boolean return value.
- css/CSSSegmentedFontFace.cpp:
(WebCore::appendFontWithInvalidUnicodeRangeIfLoading): Updated for simplified
UnicodeRange struct.
- css/FontFace.cpp:
(WebCore::valueFromDictionary): Deleted.
(WebCore::FontFace::create): Updated to take the descriptors as a struct instead of
a WebCore::Dictionary. Also made that argument optional as specified in the current
specification draft.
(WebCore::FontFace::setFeatureSettings): Updated since setFeatureSettings no longer
has a boolean return value.
(WebCore::FontFace::unicodeRange): Updated for simplified UnicodeRange struct.
- css/FontFace.h: Used pragma once. Removed unneeded includes and forward declarations.
Derived privately from CSSFontFace::Client. Added a FontFace::Descriptors struct and
used it as an argument to the create function as described above.
- css/FontFace.idl: Added FontFaceDescriptors and changed the argument to the
constructor to be an optional FontFaceDescriptors instead of a Dictionary.
Tools:
- Scripts/do-webcore-rename: Use this to rename JSDOMBuild.h to JSDOMConvert.h.
Also skip test expectations in a directory that this was modifying unnecessarily.
- 1:04 PM Changeset in webkit [200546] by
-
- 15 edits in trunk/Source/WebCore
Rework FontFace promise attribute handling
https://bugs.webkit.org/show_bug.cgi?id=157310
Reviewed by Myles C. Maxfield.
Making promise attributes cached attributes, so that they are created only once.
They are created in the custom binding code and passed to DOM class as needed.
Removed usage of ExecState& from DOM iterators.
No change should be visible from user scripts.
- Modules/fetch/FetchHeaders.cpp:
(WebCore::FetchHeaders::Iterator::next): Removing ExecState parameter.
- Modules/fetch/FetchHeaders.h:
- bindings/js/JSDOMIterator.h:
(WebCore::keyValueIteratorForEach):
(WebCore::JSDOMIterator<JSWrapper>::next): Ditto.
- bindings/js/JSDOMPromise.cpp:
(WebCore::DeferredWrapper::promise): Removed deferred() and added access to promise directly.
- bindings/js/JSDOMPromise.h:
- bindings/js/JSFontFaceCustom.cpp:
(WebCore::JSFontFace::loaded): Using cached attribute to call FontFace::loaded only once.
- bindings/js/JSFontFaceSetCustom.cpp:
(WebCore::JSFontFaceSet::ready): Using cached attribute to call FontFaceSet::ready only once.
- css/CSSFontFace.cpp:
(WebCore::CSSFontFace::wrapper): Removing ExecState parameter.
- css/CSSFontFace.h:
- css/FontFace.cpp:
(WebCore::FontFace::create): Ditto.
(WebCore::FontFace::FontFace): Ditto.
(WebCore::FontFace::fontStateChanged): Updating promise handling.
(WebCore::FontFace::registerLoaded): Resolving/rejecting promise if backing CSSFontFace loading is ended.
(WebCore::FontFace::load): Calling backing load.
- css/FontFace.h:
- css/FontFaceSet.cpp:
(WebCore::FontFaceSet::Iterator::next): Removing ExecState parameter.
(WebCore::FontFaceSet::load): Removing ExecState and ExceptionCode parameter.
(WebCore::FontFaceSet::registerReady): Resolving promise if ready otherwise storing it for resolving it later.
(WebCore::FontFaceSet::completedLoading): Resolving promise if any is stored.
(WebCore::FontFaceSet::create): Deleted.
- css/FontFaceSet.h:
- css/FontFaceSet.idl:
- 1:02 PM Changeset in webkit [200545] by
-
- 2 edits in trunk/Source/WebCore
Fix an incorrect usage of OS(DARWIN) with PLATFORM(COCOA)
https://bugs.webkit.org/show_bug.cgi?id=157167
Patch by Jeremy Huddleston Sequoia <jeremyhu@apple.com> on 2016-05-07
Reviewed by Myles C. Maxfield.
- platform/graphics/FontPlatformData.h:
(WebCore::FontPlatformData::hash):
- 9:51 AM Changeset in webkit [200544] by
-
- 7 edits3 adds in trunk/PerformanceTests
Update Animometer design
https://bugs.webkit.org/show_bug.cgi?id=157449
Reviewed by Darin Adler.
- Animometer/developer.html: Stop including runner/animometer.css.
- Animometer/index.html: Udpated elements to fit new styles.
- Animometer/resources/debug-runner/animometer.css:
Copy the old runner/animometer.css to here so the debug runner is unaffected.
- Animometer/resources/runner/animometer.css:
New styles for the design. Drop flex box for broad browser support.
- Animometer/resources/runner/animometer.js:
(ResultsTable.clear): Use textContent.
(window.sectionsManager.showSection): Add class to the body.
(window.sectionsManager.setSectionScore): Use textContent, not innerHTML.
- Animometer/resources/runner/crystal.svg: Added.
- Animometer/resources/runner/lines.svg: Added.
- Animometer/resources/runner/logo.svg: Added.
- Animometer/resources/runner/tests.js: Shorten test name and title case them.
- 9:20 AM Changeset in webkit [200543] by
-
- 6 edits2 moves in trunk/Source/JavaScriptCore
Add JSC options bytecodeRangeToJITCompile and jitWhitelist.
https://bugs.webkit.org/show_bug.cgi?id=157428
Reviewed by Michael Saboff.
- Added Options::bytecodeRangeToJITCompile and Options::jitWhitelist options.
- Moved DFGFunctionWhitelist* to FunctionWhitelist* and made it generic so that it can be used for more than one whitelist instance. In this case, we now have two: the dfgWhitelist and the jitWhitelist.
- Added "can compile" checks in LLInt::shouldJIT() to check Options::bytecodeRangeToJITCompile and Options::jitWhitelist.
- CMakeLists.txt:
- JavaScriptCore.xcodeproj/project.pbxproj:
- dfg/DFGDriver.cpp:
(JSC::DFG::getNumCompilations):
(JSC::DFG::ensureGlobalDFGWhitelist):
(JSC::DFG::compileImpl):
- dfg/DFGFunctionWhitelist.cpp: Removed.
- dfg/DFGFunctionWhitelist.h: Removed.
- llint/LLIntSlowPaths.cpp:
(JSC::LLInt::ensureGlobalJITWhitelist):
(JSC::LLInt::shouldJIT):
- runtime/Options.h:
- tools/FunctionWhitelist.cpp: Copied from Source/JavaScriptCore/dfg/DFGFunctionWhitelist.cpp.
(JSC::FunctionWhitelist::FunctionWhitelist):
(JSC::FunctionWhitelist::contains):
(JSC::DFG::FunctionWhitelist::ensureGlobalWhitelist): Deleted.
(JSC::DFG::FunctionWhitelist::FunctionWhitelist): Deleted.
(JSC::DFG::FunctionWhitelist::parseFunctionNamesInFile): Deleted.
(JSC::DFG::FunctionWhitelist::contains): Deleted.
- tools/FunctionWhitelist.h: Copied from Source/JavaScriptCore/dfg/DFGFunctionWhitelist.h.
- 6:03 AM Changeset in webkit [200542] by
-
- 6 edits in trunk
REGRESSION(r196222): [AX][GTK] accessibility/gtk/caret-offsets.html failing
https://bugs.webkit.org/show_bug.cgi?id=153956
Reviewed by Chris Fleizach.
Source/WebCore:
The reason the test began failing is that it was checking the new caret offset
synchronously. For most of the test cases, this was not a problem. But when the
caret was moved out of a focused link, the focus change (and associated repainting)
delayed the caret-moved event long enough to cause the associated test case to fail.
The test now uses shouldBecomeEqualToString() instead of shouldBeEqualToString().
The test also had a supposedly-correct expectation which was wrong: When moving the
caret to a valid accessible offset, the caret-moved event should be for that offset.
This was not the case for the list item test case because emitTextSelectionChange()
was not adjusting the offset for the RenderListMarker, the text of which is exposed
as part of the ATK_ROLE_LIST_ITEM object. This bug was also fixed and the test case
updated accordingly.
No new tests are needed. The previously-failing test is now passing.
- editing/atk/FrameSelectionAtk.cpp:
(WebCore::emitTextSelectionChange):
LayoutTests:
Change the test to run asynchronously and update the expectations.
- accessibility/gtk/caret-offsets-expected.txt: Updated.
- accessibility/gtk/caret-offsets.html: Updated.
- platform/gtk/TestExpectations: Unskipped the previously-failing test.
- 1:19 AM Changeset in webkit [200541] by
-
- 2 edits in trunk/Source/JavaScriptCore
[JSC][32bit] stress/tagged-templates-template-object.js fails in debug
https://bugs.webkit.org/show_bug.cgi?id=157436
Patch by Benjamin Poulain <bpoulain@apple.com> on 2016-05-07
Reviewed by Filip Pizlo.
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
The node OverridesHasInstance had a speculation after a jump.
