Timeline
May 13, 2010:
- 11:35 PM Changeset in webkit [59445] by
-
- 2 edits in trunk/WebKit/qt
Symbian build fix.
[Qt] Updated the def file with new exports.
- symbian/eabi/QtWebKitu.def: Add missing gc symbol for QtLauncher
- 11:18 PM Changeset in webkit [59444] by
-
- 1 edit1 add in trunk/LayoutTests
2010-05-13 Simon Fraser <Simon Fraser>
Fixing test failure.
Adding resource that should have been added in r59443.
- compositing/iframes/resources/subframe.html: Added.
- 10:32 PM Changeset in webkit [59443] by
-
- 3 edits4 adds in trunk
2010-05-13 Simon Fraser <Simon Fraser>
Reviewed by Dan Bernstein.
iframes in compositing layers don't redraw correctly on scrolling
https://bugs.webkit.org/show_bug.cgi?id=39096
When an iframe ends up in a compositing layer (that is painting to its backing store), we need
to turn off blitting on scrolling. RenderView::paintBoxDecorations() already has code to do this
for transformed frames, so do the same thing when the frame is enclosed in a compositing layer.
Test: compositing/iframes/iframe-copy-on-scroll.html
- rendering/RenderView.cpp: (WebCore::RenderView::paintBoxDecorations):
- 9:17 PM Changeset in webkit [59442] by
-
- 2 edits in trunk/WebKit/chromium
2010-05-13 Tony Chang <tony@chromium.org>
Reviewed by Kent Tamura.
[chromium] enable DRT build in chromium (for the last time)
https://bugs.webkit.org/show_bug.cgi?id=39109
- WebKit.gyp:
- 9:01 PM Changeset in webkit [59441] by
-
- 2 edits in trunk
Unreviewed. Move a ChangeLog entry inserted to a wrong file.
- 8:56 PM Changeset in webkit [59440] by
-
- 2 edits in trunk/LayoutTests
2010-05-13 Takeshi Yoshino <tyoshino@google.com>
Reviewed by Kent Tamura.
Update text_expectations.txt for Chromium
fast/forms/input-text-paste-maxlength.html is flaky on Linux Debug
See http://code.google.com/p/chromium/issues/detail?id=44150 for detail.
- platform/chromium/test_expectations.txt:
- 8:49 PM Changeset in webkit [59439] by
-
- 2 edits in trunk/LayoutTests
Update test_expectations.txt for Chromium.
fast/forms/implicit-submission.html is flaky on Linux.
See http://crbug.com/43890 for detail.
Patch by Takeshi Yoshino <tyoshino@google.com> on 2010-05-13
Reviewed by Shinichiro Hamaji.
- platform/chromium/test_expectations.txt:
- 7:25 PM Changeset in webkit [59438] by
-
- 1 edit in trunk/WebKit/win/ChangeLog
Update the bug number in the ChangeLog that I just committed.
- 7:10 PM Changeset in webkit [59437] by
-
- 5 edits in branches/safari-533-branch
Versioning.
- 7:09 PM Changeset in webkit [59436] by
-
- 2 edits in trunk/LayoutTests
2010-05-13 Martin Robinson <mrobinson@igalia.com>
No review.
[GTK] css1/color_and_background/background_attachment.html fails on the 32-bit debug bot
https://bugs.webkit.org/show_bug.cgi?id=39101
- platform/gtk/Skipped: Skip failing test.
- 7:09 PM Changeset in webkit [59435] by
-
- 1 copy in tags/Safari-533.9
New tag.
- 7:08 PM Changeset in webkit [59434] by
-
- 5 edits in trunk/WebKit/win
<rdar://problem/7975410>
Reviewed by Tim Hatcher.
Allow reporting exceptions that occur when using JavaScriptCore APIs to the Web Inspector.
- Interfaces/IWebViewPrivate.idl: Add a reportException function off of IWebViewPrivate.
- Interfaces/WebKit.idl: Touch WebKit.idl to make sure Interfaces rebuild.
- WebView.cpp:
(WebView::reportException): Make sure the function was called with a context from a WebView, and call
WebCore::reportException.
- WebView.h:
- 7:08 PM Changeset in webkit [59433] by
-
- 5 edits in branches/safari-533-branch
Versioning.
- 6:52 PM Changeset in webkit [59432] by
-
- 5 edits in branches/safari-533-branch
Merge r59418.
- 6:51 PM Changeset in webkit [59431] by
-
- 3 edits in branches/safari-533-branch/WebCore
Merge r59330.
- 6:51 PM Changeset in webkit [59430] by
-
- 4 edits in branches/safari-533-branch/WebCore
Merge r59387.
- 6:51 PM Changeset in webkit [59429] by
-
- 2 edits in branches/safari-533-branch/WebCore
Merge r59417.
- 6:06 PM Changeset in webkit [59428] by
-
- 2 edits56 adds in trunk/LayoutTests
2010-05-13 Martin Robinson <mrobinson@igalia.com>
No review. Finish adding css1 baselines for GTK+.
- platform/gtk/Skipped: Unskip tests which now have baselines.
- platform/gtk/css1/basic/class_as_selector-expected.txt:
- platform/gtk/css1/box_properties/width-expected.txt: Added.
- platform/gtk/css1/cascade/cascade_order-expected.txt: Added.
- platform/gtk/css1/cascade/important-expected.txt: Added.
- platform/gtk/css1/classification/display-expected.txt: Added.
- platform/gtk/css1/classification/list_style-expected.txt: Added.
- platform/gtk/css1/classification/list_style_image-expected.txt: Added.
- platform/gtk/css1/classification/list_style_position-expected.txt: Added.
- platform/gtk/css1/classification/list_style_type-expected.txt: Added.
- platform/gtk/css1/classification/white_space-expected.txt: Added.
- platform/gtk/css1/color_and_background/background-expected.txt: Added.
- platform/gtk/css1/color_and_background/background_attachment-expected.txt: Added.
- platform/gtk/css1/color_and_background/background_color-expected.txt: Added.
- platform/gtk/css1/color_and_background/background_image-expected.txt: Added.
- platform/gtk/css1/color_and_background/background_position-expected.txt: Added.
- platform/gtk/css1/color_and_background/background_repeat-expected.txt: Added.
- platform/gtk/css1/color_and_background/color-expected.txt: Added.
- platform/gtk/css1/conformance/forward_compatible_parsing-expected.txt: Added.
- platform/gtk/css1/font_properties/font-expected.txt: Added.
- platform/gtk/css1/font_properties/font_family-expected.txt: Added.
- platform/gtk/css1/font_properties/font_size-expected.txt: Added.
- platform/gtk/css1/font_properties/font_style-expected.txt: Added.
- platform/gtk/css1/font_properties/font_variant-expected.txt: Added.
- platform/gtk/css1/font_properties/font_weight-expected.txt: Added.
- platform/gtk/css1/formatting_model/canvas-expected.txt: Added.
- platform/gtk/css1/formatting_model/floating_elements-expected.txt: Added.
- platform/gtk/css1/formatting_model/height_of_lines-expected.txt: Added.
- platform/gtk/css1/formatting_model/horizontal_formatting-expected.txt: Added.
- platform/gtk/css1/formatting_model/inline_elements-expected.txt: Added.
- platform/gtk/css1/formatting_model/replaced_elements-expected.txt: Added.
- platform/gtk/css1/formatting_model/vertical_formatting-expected.txt: Added.
- platform/gtk/css1/pseudo/anchor-expected.txt: Added.
- platform/gtk/css1/pseudo/firstletter-expected.txt: Added.
- platform/gtk/css1/pseudo/firstline-expected.txt: Added.
- platform/gtk/css1/pseudo/multiple_pseudo_elements-expected.txt: Added.
- platform/gtk/css1/pseudo/pseudo_elements_in_selectors-expected.txt: Added.
- platform/gtk/css1/text_properties/letter_spacing-expected.txt: Added.
- platform/gtk/css1/text_properties/line_height-expected.txt: Added.
- platform/gtk/css1/text_properties/text_align-expected.txt: Added.
- platform/gtk/css1/text_properties/text_decoration-expected.txt: Added.
- platform/gtk/css1/text_properties/text_indent-expected.txt: Added.
- platform/gtk/css1/text_properties/text_transform-expected.txt: Added.
- platform/gtk/css1/text_properties/vertical_align-expected.txt: Added.
- platform/gtk/css1/text_properties/word_spacing-expected.txt: Added.
- platform/gtk/css1/units/color_units-expected.txt: Added.
- platform/gtk/css1/units/length_units-expected.txt: Added.
- platform/gtk/css1/units/percentage_units-expected.txt: Added.
- platform/gtk/css1/units/urls-expected.txt: Added.
- 6:03 PM Changeset in webkit [59427] by
-
- 13 edits in branches/safari-533-branch/WebCore
Merge r59281.
- 6:03 PM Changeset in webkit [59426] by
-
- 7 edits1 copy1 add in branches/safari-533-branch
Merge r59381.
- 6:03 PM Changeset in webkit [59425] by
-
- 4 edits in branches/safari-533-branch/WebCore
Merge r59372.
- 6:03 PM Changeset in webkit [59424] by
-
- 2 edits in branches/safari-533-branch/WebKit/mac
Merge r59391.
- 6:03 PM Changeset in webkit [59423] by
-
- 3 edits in branches/safari-533-branch/WebCore
Merge r59374.
- 6:02 PM Changeset in webkit [59422] by
-
- 6 edits2 adds in branches/safari-533-branch
Merge r59384.
- 6:02 PM Changeset in webkit [59421] by
-
- 3 edits2 adds in branches/safari-533-branch
Merge r59351.
- 6:02 PM Changeset in webkit [59420] by
-
- 2 edits in branches/safari-533-branch/JavaScriptCore
Merge r59337.
- 5:04 PM Changeset in webkit [59419] by
-
- 2 edits in trunk/LayoutTests
2010-05-13 Martin Robinson <mrobinson@igalia.com>
No review. Correcting baseline.
- platform/gtk/css1/basic/class_as_selector-expected.txt: Correct baseline.
- 5:01 PM Changeset in webkit [59418] by
-
- 5 edits in trunk
WebCore: Expose WebCore::reportException and WebCore::toJSDOMWindow symbols.
Reviewed by Sam Weinig.
- WebCore.base.exp: Expose reportException and toJSDOMWindow.
WebKit/mac: Allow reporting exceptions that occur when using JavaScriptCore APIs
to the Web Inspector.
<rdar://problem/7975410>
Reviewed by Sam Weinig.
- WebView/WebView.mm:
(+[WebView _reportException:inContext:]): Call WebCore::reportException after checking
that the global object is a DOMWindow.
- WebView/WebViewPrivate.h: Added _reportException:inContext:.
- 4:59 PM Changeset in webkit [59417] by
-
- 2 edits in trunk/WebCore
2010-05-13 Joseph Pecoraro <Joseph Pecoraro>
Reviewed by Timothy Hatcher.
Web Inspector: Clearing Breakpoints Too Often
https://bugs.webkit.org/show_bug.cgi?id=39094
Minor resets should preserve both workers and breakpoints.
- inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype.reset):
- 4:58 PM Changeset in webkit [59416] by
-
- 2 edits in trunk/WebKit/qt
Symbian build fix.
[Qt] Updated the def file with new exports.
- symbian/eabi/QtWebKitu.def:
- 4:46 PM Changeset in webkit [59415] by
-
- 2 edits in branches/safari-533-branch/WebCore
Merge r59025.
- 4:46 PM Changeset in webkit [59414] by
-
- 3 edits in branches/safari-533-branch/WebCore
Merge r58954.
- 4:46 PM Changeset in webkit [59413] by
-
- 13 edits4 adds in branches/safari-533-branch
Merge r59243.
- 4:46 PM Changeset in webkit [59412] by
-
- 2 edits in branches/safari-533-branch/WebCore
Merge r59210.
- 4:46 PM Changeset in webkit [59411] by
-
- 10 edits in branches/safari-533-branch
Merge r59232.
- 4:46 PM Changeset in webkit [59410] by
-
- 5 edits in branches/safari-533-branch/WebCore
Merge r59239.
- 4:46 PM Changeset in webkit [59409] by
-
- 6 edits in branches/safari-533-branch/WebCore
Merge r59189.
- 4:46 PM Changeset in webkit [59408] by
-
- 3 edits in branches/safari-533-branch/WebCore
Merge r59186.
- 4:45 PM Changeset in webkit [59407] by
-
- 3 edits4 adds in branches/safari-533-branch
Merge r59199.
- 4:45 PM Changeset in webkit [59406] by
-
- 2 edits1 add in branches/safari-533-branch/WebCore
Merge r59263.
- 4:45 PM Changeset in webkit [59405] by
-
- 1 edit in branches/safari-533-branch/WebCore/ChangeLog
Merge r59242.
- 4:45 PM Changeset in webkit [59404] by
-
- 5 edits2 adds in branches/safari-533-branch
Merge r59241.
- 4:45 PM Changeset in webkit [59403] by
-
- 2 edits in branches/safari-533-branch/WebCore
Merge r59247.
- 4:45 PM Changeset in webkit [59402] by
-
- 3 edits in branches/safari-533-branch/JavaScriptCore
Merge r59202.
- 4:45 PM Changeset in webkit [59401] by
-
- 8 edits in branches/safari-533-branch/JavaScriptCore
Merge r59196.
- 4:45 PM Changeset in webkit [59400] by
-
- 15 edits1 add in branches/safari-533-branch
Merge r59187.
- 4:44 PM Changeset in webkit [59399] by
-
- 7 edits in branches/safari-533-branch
Merge r59336.
- 4:41 PM Changeset in webkit [59398] by
-
- 2 edits in trunk/LayoutTests
2010-05-13 Martin Robinson <mrobinson@igalia.com>
No review needed.
[GTK] Some test results are one pixel different on x86_64
https://bugs.webkit.org/show_bug.cgi?id=39022
- platform/gtk/Skipped: Skipping this test because of single-pixel difference.
- 4:22 PM Changeset in webkit [59397] by
-
- 2 edits in trunk/LayoutTests
Unreviewed.
[Qt] Platform specific expected file updated after r59385.
Adding block elements to a block and removing them changes the height of the element.
https://bugs.webkit.org/show_bug.cgi?id=38874
- platform/qt/editing/deleting/5408255-expected.txt: updated.
- 4:14 PM Changeset in webkit [59396] by
-
- 14 edits1 copy2 adds in trunk
2010-05-13 Simon Fraser <Simon Fraser>
Reviewed by Dave Hyatt.
Fix scrolling in composited iframes
https://bugs.webkit.org/show_bug.cgi?id=39088
<rdar://problem/7980099>
When propagating compositing out of iframes, we have to update the position of the iframe content
layers on scrolling.
Test: compositing/iframes/scrolling-iframe.html
- page/FrameView.cpp: (WebCore::FrameView::scrollPositionChanged): Call updateContentLayerScrollPosition() when scrolling.
- rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::updateGraphicsLayerGeometry): Renamed setRootPlatformLayerClippingBox() to updateContentLayerOffset().
- rendering/RenderLayerCompositor.h:
- rendering/RenderLayerCompositor.cpp: Rename m_clippingLayer to m_clipLayer to go better with m_scrollLayer. (WebCore::RenderLayerCompositor::updateContentLayerOffset): Renamed from setRootPlatformLayerClippingBox().
Set the size of the clipping layer from the FrameView now, so that scrollbars are not clipped out.
Update the scroll layer position too.
(WebCore::RenderLayerCompositor::updateContentLayerScrollPosition): Set the position of the scroll layer
when the ScrollView is scrolled.
(WebCore::RenderLayerCompositor::rootPlatformLayer): m_clippingLayer rename.
(WebCore::RenderLayerCompositor::ensureRootPlatformLayer): m_clippingLayer rename. Also create m_scrollLayer at
the same time as the clip layer, and clean it up as necessary.
(WebCore::RenderLayerCompositor::destroyRootPlatformLayer): m_clippingLayer rename, and clean up the m_scrollLayer too.
(WebCore::RenderLayerCompositor::detachRootPlatformLayer): m_clippingLayer rename
- 4:14 PM Changeset in webkit [59395] by
-
- 2 edits62 adds in trunk/LayoutTests
2010-05-13 Martin Robinson <mrobinson@igalia.com>
No review. Adding baselines for many of the css1 tests. I've checked these manually.
- platform/gtk/Skipped: Unskipping tests.
- platform/gtk/css1/basic/class_as_selector-expected.txt: Added.
- platform/gtk/css1/basic/comments-expected.txt: Added.
- platform/gtk/css1/basic/containment-expected.txt: Added.
- platform/gtk/css1/basic/contextual_selectors-expected.txt: Added.
- platform/gtk/css1/basic/grouping-expected.txt: Added.
- platform/gtk/css1/basic/id_as_selector-expected.txt: Added.
- platform/gtk/css1/basic/inheritance-expected.txt: Added.
- platform/gtk/css1/box_properties/acid_test-expected.txt: Added.
- platform/gtk/css1/box_properties/border-expected.txt: Added.
- platform/gtk/css1/box_properties/border_bottom-expected.txt: Added.
- platform/gtk/css1/box_properties/border_bottom_inline-expected.txt: Added.
- platform/gtk/css1/box_properties/border_bottom_width-expected.txt: Added.
- platform/gtk/css1/box_properties/border_bottom_width_inline-expected.txt: Added.
- platform/gtk/css1/box_properties/border_color-expected.txt: Added.
- platform/gtk/css1/box_properties/border_color_inline-expected.txt: Added.
- platform/gtk/css1/box_properties/border_inline-expected.txt: Added.
- platform/gtk/css1/box_properties/border_left-expected.txt: Added.
- platform/gtk/css1/box_properties/border_left_inline-expected.txt: Added.
- platform/gtk/css1/box_properties/border_left_width-expected.txt: Added.
- platform/gtk/css1/box_properties/border_left_width_inline-expected.txt: Added.
- platform/gtk/css1/box_properties/border_right-expected.txt: Added.
- platform/gtk/css1/box_properties/border_right_inline-expected.txt: Added.
- platform/gtk/css1/box_properties/border_right_width-expected.txt: Added.
- platform/gtk/css1/box_properties/border_right_width_inline-expected.txt: Added.
- platform/gtk/css1/box_properties/border_style-expected.txt: Added.
- platform/gtk/css1/box_properties/border_style_inline-expected.txt: Added.
- platform/gtk/css1/box_properties/border_top-expected.txt: Added.
- platform/gtk/css1/box_properties/border_top_inline-expected.txt: Added.
- platform/gtk/css1/box_properties/border_top_width-expected.txt: Added.
- platform/gtk/css1/box_properties/border_top_width_inline-expected.txt: Added.
- platform/gtk/css1/box_properties/border_width-expected.txt: Added.
- platform/gtk/css1/box_properties/border_width_inline-expected.txt: Added.
- platform/gtk/css1/box_properties/clear-expected.txt: Added.
- platform/gtk/css1/box_properties/clear_float-expected.txt: Added.
- platform/gtk/css1/box_properties/float-expected.txt: Added.
- platform/gtk/css1/box_properties/float_elements_in_series-expected.txt: Added.
- platform/gtk/css1/box_properties/float_margin-expected.txt: Added.
- platform/gtk/css1/box_properties/float_on_text_elements-expected.txt: Added.
- platform/gtk/css1/box_properties/height-expected.txt: Added.
- platform/gtk/css1/box_properties/margin-expected.txt: Added.
- platform/gtk/css1/box_properties/margin_bottom-expected.txt: Added.
- platform/gtk/css1/box_properties/margin_bottom_inline-expected.txt: Added.
- platform/gtk/css1/box_properties/margin_inline-expected.txt: Added.
- platform/gtk/css1/box_properties/margin_left-expected.txt: Added.
- platform/gtk/css1/box_properties/margin_left_inline-expected.txt: Added.
- platform/gtk/css1/box_properties/margin_right-expected.txt: Added.
- platform/gtk/css1/box_properties/margin_right_inline-expected.txt: Added.
- platform/gtk/css1/box_properties/margin_top-expected.txt: Added.
- platform/gtk/css1/box_properties/margin_top_inline-expected.txt: Added.
- platform/gtk/css1/box_properties/padding-expected.txt: Added.
- platform/gtk/css1/box_properties/padding_bottom-expected.txt: Added.
- platform/gtk/css1/box_properties/padding_bottom_inline-expected.txt: Added.
- platform/gtk/css1/box_properties/padding_inline-expected.txt: Added.
- platform/gtk/css1/box_properties/padding_left-expected.txt: Added.
- platform/gtk/css1/box_properties/padding_left_inline-expected.txt: Added.
- platform/gtk/css1/box_properties/padding_right-expected.txt: Added.
- platform/gtk/css1/box_properties/padding_right_inline-expected.txt: Added.
- platform/gtk/css1/box_properties/padding_top-expected.txt: Added.
- platform/gtk/css1/box_properties/padding_top_inline-expected.txt: Added.
- 3:56 PM Changeset in webkit [59394] by
-
- 2 edits in trunk/WebCore
Follow up to:
Fix for https://bugs.webkit.org/show_bug.cgi?id=38221
Memory issues due to the changes in 36556 (increased CSSPrimitiveValue size).
Part of <rdar://problem/7921275>
Reviewed by Anders Carlsson.
Fix failing tests on Leopard.
Initialize m_hasCachedCSSText in CSSPrimitiveValue::init methods.
- css/CSSPrimitiveValue.cpp:
(WebCore::CSSPrimitiveValue::init):
(WebCore::CSSPrimitiveValue::cssText): Add extra assertion.
- 3:45 PM Changeset in webkit [59393] by
-
- 2 edits in trunk/LayoutTests
2010-05-13 Martin Robinson <mrobinson@igalia.com>
No review. Rebaselining test after r59385.
- platform/gtk/editing/deleting/delete-select-all-001-expected.txt: Rebaseline
- 3:39 PM Changeset in webkit [59392] by
-
- 3 edits in trunk/LayoutTests
Adding fast/loader/recursive-before-unload-crash-expected.html to the gtk skipped list
because it needs more logging in its DRT to pass:
- platform/gtk/Skipped:
Adding fast/loader/recursive-before-unload-crash-expected.html to the qt skipped list
because it's hanging:
- platform/qt/Skipped:
- 3:39 PM Changeset in webkit [59391] by
-
- 2 edits in trunk/WebKit/mac
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=39089
<rdar://problem/7974044> Domain names in Russian '.рф' domain are displayed as punycode
Add a custom check for this domain. Currently, this is the only non-ASCII TLD, we'll
investigate a more extensible solution when there are more, and we know what the
typical restictions are.
- Misc/WebNSURLExtras.mm: (allCharactersAllowedByTLDRules): (-[NSString _web_mapHostNameWithRange:encode:makeString:]):
- 3:33 PM Changeset in webkit [59390] by
-
- 3 edits2 adds in trunk
2010-05-13 Kent Tamura <tkent@chromium.org>
Reviewed by Darin Adler.
Can't submit a form with <input type=checkbox required>
https://bugs.webkit.org/show_bug.cgi?id=39065
- fast/forms/interactive-validation-required-checkbox-expected.txt: Added.
- fast/forms/interactive-validation-required-checkbox.html: Added.
2010-05-13 Kent Tamura <tkent@chromium.org>
Reviewed by Darin Adler.
Can't submit a form with <input type=checkbox required>
https://bugs.webkit.org/show_bug.cgi?id=39065
Test: fast/forms/interactive-validation-required-checkbox.html
- html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::setChecked): Update the validity cache when a checkbox state is changed.
- 3:12 PM Changeset in webkit [59389] by
-
- 1 edit1 copy in trunk/LayoutTests
https://bugs.webkit.org/show_bug.cgi?id=38928
Reviewed by NOBODY (Layout test fix)
Add Tiger specific results for my new test.
- platform/mac-tiger/fast/loader/recursive-before-unload-crash-expected.txt: Copied from fast/loader/recursive-before-unload-crash-expected.txt.
- 3:07 PM Changeset in webkit [59388] by
-
- 12 edits in trunk
2010-05-13 Kenneth Russell <kbr@google.com>
Reviewed by Dimitri Glazkov.
Alias WebGLArray type names to TypedArray type names
https://bugs.webkit.org/show_bug.cgi?id=39036
Exposed the existing WebGL<T>Array constructor functions on the
DOMWindow under the naming convention in the TypedArray spec. The
implementations will be renamed in a subsequent bug, and the
aliases to the WebGL<T>Array type names eventually removed. Ran
all layout tests (including WebGL) in Safari, and WebGL tests in
Chromium.
Test: revised array-unit-tests.html to test both type names.
Revised global prototype and constructor tests to ignore new types.
- bindings/generic/RuntimeEnabledFeatures.h: (WebCore::RuntimeEnabledFeatures::arrayBufferEnabled): (WebCore::RuntimeEnabledFeatures::int8ArrayEnabled): (WebCore::RuntimeEnabledFeatures::uint8ArrayEnabled): (WebCore::RuntimeEnabledFeatures::int16ArrayEnabled): (WebCore::RuntimeEnabledFeatures::uint16ArrayEnabled): (WebCore::RuntimeEnabledFeatures::int32ArrayEnabled): (WebCore::RuntimeEnabledFeatures::uint32ArrayEnabled): (WebCore::RuntimeEnabledFeatures::floatArrayEnabled):
- bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::arrayBuffer): (WebCore::JSDOMWindow::int8Array): (WebCore::JSDOMWindow::uint8Array): (WebCore::JSDOMWindow::int32Array): (WebCore::JSDOMWindow::uint32Array): (WebCore::JSDOMWindow::int16Array): (WebCore::JSDOMWindow::uint16Array): (WebCore::JSDOMWindow::floatArray):
- bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::V8DOMWindow::ArrayBufferAccessorGetter): (WebCore::V8DOMWindow::Int8ArrayAccessorGetter): (WebCore::V8DOMWindow::Uint8ArrayAccessorGetter): (WebCore::V8DOMWindow::Int16ArrayAccessorGetter): (WebCore::V8DOMWindow::Uint16ArrayAccessorGetter): (WebCore::V8DOMWindow::Int32ArrayAccessorGetter): (WebCore::V8DOMWindow::Uint32ArrayAccessorGetter): (WebCore::V8DOMWindow::FloatArrayAccessorGetter):
- page/DOMWindow.idl:
2010-05-13 Kenneth Russell <kbr@google.com>
Reviewed by Dimitri Glazkov.
Alias WebGLArray type names to TypedArray type names
https://bugs.webkit.org/show_bug.cgi?id=39036
Exposed the existing WebGL<T>Array constructor functions on the
DOMWindow under the naming convention in the TypedArray spec. The
implementations will be renamed in a subsequent bug, and the
aliases to the WebGL<T>Array type names eventually removed. Ran
all layout tests (including WebGL) in Safari, and WebGL tests in
Chromium.
Test: revised array-unit-tests.html to test both type names.
Revised global prototype and constructor tests to ignore new types.
- fast/canvas/webgl/array-unit-tests-expected.txt:
- fast/canvas/webgl/array-unit-tests.html:
- fast/dom/Window/script-tests/window-property-descriptors.js:
- fast/dom/Window/window-properties.html:
- fast/dom/script-tests/prototype-inheritance.js:
- fast/js/script-tests/global-constructors.js:
- 2:51 PM Changeset in webkit [59387] by
-
- 4 edits in trunk/WebCore
https://bugs.webkit.org/show_bug.cgi?id=39084
Reviewed by Anders Carlsson.
Improve :visited style resolution to reduce its memory footprint and to make some speed adjustments and
simplifications.
(1) Tie the caching of link state on CSSStyleSelector to the element. Just clear out the element when
style resolution finishes for the unvisited case to avoid caching across external calls. The internal
calls share the cache just fine by doing this.
(2) Delete the RenderStyle if the link is unvisited. This shouldn't take long enough to make us vulnerable
to timing attacks, and it makes sure the overall footprint stays the way it used to be for unvisited links.
(3) Limit the set of properties that can be applied to :visited links to only the colors it supports. This
stops images from being loadable from :visited rules.
- css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::init):
(WebCore::CSSStyleSelector::SelectorChecker::determineLinkState):
(WebCore::CSSStyleSelector::initElement):
(WebCore::CSSStyleSelector::canShareStyleWithElement):
(WebCore::CSSStyleSelector::styleForElement):
(WebCore::CSSStyleSelector::pseudoStyleForElement):
(WebCore::isValidVisitedLinkProperty):
(WebCore::CSSStyleSelector::applyProperty):
- css/CSSStyleSelector.h:
- rendering/style/RenderStyle.cpp:
(WebCore::colorIncludingFallback):
- 2:32 PM Changeset in webkit [59386] by
-
- 4 edits in trunk/WebCore
Fix for https://bugs.webkit.org/show_bug.cgi?id=38221
Memory issues due to the changes in 36556 (increased CSSPrimitiveValue size).
Part of <rdar://problem/7921275>
Reviewed by Darin Adler.
- Use an external cache to speedup cssText for CSSPrimitiveValue instead of an extra member variable.
- css/CSSPrimitiveValue.cpp:
(WebCore::cssTextCache):
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::cleanup):
(WebCore::CSSPrimitiveValue::cssText):
- css/CSSPrimitiveValue.h:
(WebCore::CSSPrimitiveValue::):
- css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
- 1:48 PM Changeset in webkit [59385] by
-
- 8 edits2 adds in trunk
Adding block elements to a block and removing them changes the height of the element.
https://bugs.webkit.org/show_bug.cgi?id=38874
Reviewed by Dave Hyatt.
WebCore:
The initial height of an empty editable block is different from the height of the same block after we add block elements
and remove them.
Test: editing/deleting/delete-block-contents-004.html
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::layoutBlock): resetting m_childrenInline flag to true when layout a block with no children.
LayoutTests:
The initial height of an empty editable block is different from the height of the same block after we add block elements
and remove them.
- editing/deleting/delete-block-contents-004-expected.txt: Added.
- editing/deleting/delete-block-contents-004.html: Added.
The following tests results have been updated to reflect the new renderer structure.
- editing/deleting/in-visibly-empty-root-expected.txt:
- platform/mac/editing/deleting/5408255-expected.txt:
- platform/mac/editing/deleting/delete-select-all-001-expected.txt:
- platform/mac/editing/selection/4895428-1-expected.txt:
- platform/mac/editing/selection/4895428-4-expected.txt:
- 1:31 PM Changeset in webkit [59384] by
-
- 6 edits2 adds in trunk
Repro crash at www.sears.com (infinite recursion in beforeunload handler)
<rdar://problem/7965182> and https://bugs.webkit.org/show_bug.cgi?id=38928
Reviewed by Darin Adler.
WebCore:
Test: fast/loader/recursive-before-unload-crash.html
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::shouldClose): Copied from Frame, with the pageDismissal flag set.
- loader/FrameLoader.h:
- page/Frame.cpp:
(WebCore::Frame::shouldClose): Forward to the new FrameLoader::shouldClose().
- page/Frame.h:
(WebCore::Frame::existingDOMWindow):
LayoutTests:
- fast/loader/recursive-before-unload-crash-expected.txt: Added.
- fast/loader/recursive-before-unload-crash.html: Added.
- 1:06 PM Changeset in webkit [59383] by
-
- 8 edits in trunk
2010-05-13 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r59376.
http://trac.webkit.org/changeset/59376
https://bugs.webkit.org/show_bug.cgi?id=39080
Broke window prototype tests (Requested by jamesr on #webkit).
- fast/canvas/webgl/array-unit-tests-expected.txt:
- fast/canvas/webgl/array-unit-tests.html:
2010-05-13 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r59376.
http://trac.webkit.org/changeset/59376
https://bugs.webkit.org/show_bug.cgi?id=39080
Broke window prototype tests (Requested by jamesr on #webkit).
- bindings/generic/RuntimeEnabledFeatures.h:
- bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::webGLFloatArray):
- bindings/v8/custom/V8DOMWindowCustom.cpp:
- page/DOMWindow.idl:
- 12:35 PM Changeset in webkit [59382] by
-
- 2 edits in trunk/WebKitTools
2010-05-13 Diego Gonzalez <diegohcg@webkit.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Improve QtLauncher user agent dialog resize
https://bugs.webkit.org/show_bug.cgi?id=39062
- QtLauncher/main.cpp: (LauncherWindow::showUserAgentDialog):
- 12:24 PM Changeset in webkit [59381] by
-
- 7 edits1 copy1 add in trunk
2010-05-13 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: A disabled style property cannot be deleted.
- inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::applyStyleText):
2010-05-13 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: A disabled style property cannot be deleted.
- inspector/elements-tests.js: (frontend_getSelectedElementStyles):
- inspector/styles-disable-then-delete-expected.txt: Added.
- inspector/styles-disable-then-delete.html: Added.
- inspector/styles-disable-then-enable.html:
- 12:15 PM Changeset in webkit [59380] by
-
- 2 edits in trunk/WebKit/qt
2010-05-11 Diego Gonzalez <diegohcg@webkit.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] tst_QWebPage::inputMethods failing on Maemo5
https://bugs.webkit.org/show_bug.cgi?id=38685
Check if the SIP (Software Input Panel) is triggered, which usually happens
in the case of a mobile platforms, an user input form receives a mouse click.
- tests/qwebpage/tst_qwebpage.cpp: (tst_QWebPage::inputMethods):
- 12:08 PM Changeset in webkit [59379] by
-
- 3 edits in trunk/WebKitTools
2010-05-13 Eric Seidel <eric@webkit.org>
Reviewed by Ojan Vafai.
Disable compositing/iframes tests on the commit-queue as a workaround for bug 38912
https://bugs.webkit.org/show_bug.cgi?id=39067
Fix yet another typo in my original hack.
I also added another unit test for this fix.
- Scripts/webkitpy/common/config/ports.py:
- Scripts/webkitpy/common/config/ports_unittest.py:
- 11:59 AM Changeset in webkit [59378] by
-
- 2 edits in trunk/WebKit/qt
[Qt] REGRESSION(r58497) tst_QGraphicsWebView::crashOnViewlessWebPages() is failing
https://bugs.webkit.org/show_bug.cgi?id=38655
Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2010-05-11
Reviewed by Laszlo Gombos.
Fix double free by moving the connect till after the resize.
The bug is causes by the fact that a resize of an empty page causes a
layout, thus deleting the qgraphicswebview before setHtml is called,
which then deletes it again, causing a double free.
- tests/qgraphicswebview/tst_qgraphicswebview.cpp:
(tst_QGraphicsWebView::crashOnViewlessWebPages):
- 11:54 AM Changeset in webkit [59377] by
-
- 2 edits in trunk/WebKit/qt
Regression(r59152): QGraphicsPageClient is not forwarding scroll and update events to view https://bugs.webkit.org/show_bug.cgi?id=39016
Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2010-05-12
Reviewed by Laszlo Gombos.
Some forward calls got lost during the refatory.
- WebCoreSupport/PageClientQt.cpp:
(WebCore::PageClientQGraphicsWidget::scroll):
(WebCore::PageClientQGraphicsWidget::update):
- 11:51 AM Changeset in webkit [59376] by
-
- 8 edits in trunk
2010-05-12 Kenneth Russell <kbr@google.com>
Reviewed by Dimitri Glazkov.
Alias WebGLArray type names to TypedArray type names
https://bugs.webkit.org/show_bug.cgi?id=39036
Exposed the existing WebGL<T>Array constructor functions on the
DOMWindow under the naming convention in the TypedArray spec. The
implementations will be renamed in a subsequent bug, and the
aliases to the WebGL<T>Array type names eventually removed. Ran
all WebGL layout tests in Safari and Chromium.
Test: revised array-unit-tests.html to test both type names.
- bindings/generic/RuntimeEnabledFeatures.h: (WebCore::RuntimeEnabledFeatures::arrayBufferEnabled): (WebCore::RuntimeEnabledFeatures::int8ArrayEnabled): (WebCore::RuntimeEnabledFeatures::uint8ArrayEnabled): (WebCore::RuntimeEnabledFeatures::int16ArrayEnabled): (WebCore::RuntimeEnabledFeatures::uint16ArrayEnabled): (WebCore::RuntimeEnabledFeatures::int32ArrayEnabled): (WebCore::RuntimeEnabledFeatures::uint32ArrayEnabled): (WebCore::RuntimeEnabledFeatures::floatArrayEnabled):
- bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::arrayBuffer): (WebCore::JSDOMWindow::int8Array): (WebCore::JSDOMWindow::uint8Array): (WebCore::JSDOMWindow::int32Array): (WebCore::JSDOMWindow::uint32Array): (WebCore::JSDOMWindow::int16Array): (WebCore::JSDOMWindow::uint16Array): (WebCore::JSDOMWindow::floatArray):
- bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::V8DOMWindow::ArrayBufferAccessorGetter): (WebCore::V8DOMWindow::Int8ArrayAccessorGetter): (WebCore::V8DOMWindow::Uint8ArrayAccessorGetter): (WebCore::V8DOMWindow::Int16ArrayAccessorGetter): (WebCore::V8DOMWindow::Uint16ArrayAccessorGetter): (WebCore::V8DOMWindow::Int32ArrayAccessorGetter): (WebCore::V8DOMWindow::Uint32ArrayAccessorGetter): (WebCore::V8DOMWindow::FloatArrayAccessorGetter):
- page/DOMWindow.idl:
2010-05-12 Kenneth Russell <kbr@google.com>
Reviewed by Dimitri Glazkov.
Alias WebGLArray type names to TypedArray type names
https://bugs.webkit.org/show_bug.cgi?id=39036
Exposed the existing WebGL<T>Array constructor functions on the
DOMWindow under the naming convention in the TypedArray spec. The
implementations will be renamed in a subsequent bug, and the
aliases to the WebGL<T>Array type names eventually removed. Ran
all WebGL layout tests in Safari and Chromium.
Test: revised array-unit-tests.html to test both type names.
- fast/canvas/webgl/array-unit-tests-expected.txt:
- fast/canvas/webgl/array-unit-tests.html:
- 11:44 AM BuildingQtOnLinux edited by
- Update the minimal verison of Qt required to compile WebKit (diff)
- 11:33 AM Changeset in webkit [59375] by
-
- 4 edits in trunk/WebKitTools
2010-05-13 Eric Seidel <eric@webkit.org>
Reviewed by Ojan Vafai.
Disable compositing/iframes tests on the commit-queue as a workaround for bug 38912
https://bugs.webkit.org/show_bug.cgi?id=39067
My previous (unreviewed) hack didn't actually work due to checking "mac" instead of "Mac".
This change fixes my hack, and unit tests it.
- Scripts/webkitpy/tool/mocktool.py:
- Make it possible to make run_command log too.
- Scripts/webkitpy/tool/steps/runtests.py:
- Fix my hack to actually work.
- Scripts/webkitpy/tool/steps/steps_unittest.py:
- Test my hack (and basic RunTests behavior as well).
- 11:17 AM Changeset in webkit [59374] by
-
- 3 edits in trunk/WebCore
Part of <rdar://problem/7965182> and https://bugs.webkit.org/show_bug.cgi?id=38928
Reviewed by John Sullivan.
No new tests. (No change in behavior)
m_unloadEventBeingDispatched was already overloaded to include both unload and pagehide events.
In general, these are "page dismissal" events, and might also include beforeunload, so let's rename
the flag!
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::FrameLoader):
(WebCore::FrameLoader::stopLoading):
(WebCore::FrameLoader::loadURL):
(WebCore::FrameLoader::loadWithDocumentLoader):
(WebCore::FrameLoader::stopAllLoaders):
(WebCore::FrameLoader::continueLoadAfterNavigationPolicy):
(WebCore::FrameLoader::pageHidden):
- loader/FrameLoader.h:
- 10:59 AM Changeset in webkit [59373] by
-
- 8 edits in trunk
2010-05-13 Antonio Gomes <tonikitoo@webkit.org>, Yi Shen <yi.4.shen@nokia.com>
Reviewed by Kenneth Christiansen.
[Qt] Add LayoutTestController interface: computedStyleIncludingVisitedInfo
https://bugs.webkit.org/show_bug.cgi?id=37759
WebKit/qt:
- WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::markerTextForListItem): (DumpRenderTreeSupportQt::computedStyleIncludingVisitedInfo):
- WebCoreSupport/DumpRenderTreeSupportQt.h:
WebKitTools:
- DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::computedStyleIncludingVisitedInfo):
- DumpRenderTree/qt/LayoutTestControllerQt.h:
LayoutTests:
- platform/qt/Skipped:
- 10:57 AM UsingGitWithWebKit edited by
- (diff)
- 10:55 AM UsingGitWithWebKit edited by
- (diff)
- 10:27 AM Changeset in webkit [59372] by
-
- 4 edits in trunk/WebCore
2010-05-13 Joseph Pecoraro <Joseph Pecoraro>
Reviewed by Pavel Feldman.
Web Inspector: Event Markers should be hidden in Resource's "Size" Graph
https://bugs.webkit.org/show_bug.cgi?id=39074
Added Show / Hide event dividers functionality to the timeline grid,
and included delegation functions in AbstractTimelinePanel.
- inspector/front-end/AbstractTimelinePanel.js: delegate to the inner grid (WebInspector.AbstractTimelinePanel.prototype.hideEventDividers): (WebInspector.AbstractTimelinePanel.prototype.showEventDividers):
- inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype.populateSidebar): save a reference to the size graph item to know when its selected (WebInspector.ResourcesPanel.prototype._graphSelected): if the size graph is selected hide the dividers, otherwise show them
- inspector/front-end/TimelineGrid.js: (WebInspector.TimelineGrid.prototype.hideEventDividers): set the container to display: none (WebInspector.TimelineGrid.prototype.showEventDividers): set the container to display: block
- 10:08 AM Changeset in webkit [59371] by
-
- 5 edits in trunk/WebKitTools
Convert status bar text to UTF-8 before logging it on Windows
We were previously logging the text using printf("%S", bstr). This
converts the UTF-16 BSTR to a multibyte string using wctomb, which
uses the codepage for the current locale to perform the conversion.
The conversion was failing, causing printf to bail and truncate the
string. By converting to UTF-8 manually before logging, we avoid this
issue (and also end up with UTF-8 output, which is what the expected
results contain). We may have to do this in other places in DRT,
eventually.
Fixes <http://webkit.org/b/38849> REGRESSION (r59016):
plugins/set-status.html fails on Windows
Reviewed by Alexey Proskuryakov.
- DumpRenderTree/win/DumpRenderTree.cpp:
(toUTF8): Moved this here from FrameLoadDelegate. Renamed from
BSTRtoString.
- DumpRenderTree/win/DumpRenderTreeWin.h: Added declaration of toUTF8.
- DumpRenderTree/win/FrameLoadDelegate.cpp: Removed BSTRtoString.
(descriptionSuitableForTestResult): Updated for rename.
- DumpRenderTree/win/UIDelegate.cpp:
(UIDelegate::setStatusText): Convert the status bar text to UTF-8
before logging it so that Windows won't try (and fail) to convert it
to the current locale's codepage.
- 10:07 AM Changeset in webkit [59370] by
-
- 2 edits in trunk/SunSpider
Fix typo in sunspider-compare-results.js that caused incorrect two-sample t statistics to be computed
Fixes <http://webkit.org/b/38768> SunSpider computes incorrect
two-sample t statistics
Reviewed by Darin Adler.
- resources/sunspider-compare-results.js:
(sunspiderCompareResults.resultLine): Fixed the calculation of the t
variable to match the definition of a two-sample t statistic. Looks
like this was just a simple typo.
- 8:35 AM Changeset in webkit [59369] by
-
- 2 edits in trunk/LayoutTests
2010-05-13 Martin Robinson <mrobinson@igalia.com>
Reviewed by Gustavo Noronha.
Events tests failing
https://bugs.webkit.org/show_bug.cgi?id=31436
Unskip these two test which are now passing.
- platform/gtk/Skipped: Unskip two tests.
- 8:34 AM Changeset in webkit [59368] by
-
- 2 edits in trunk/WebKit/chromium
2010-05-13 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: main inspector toolbar takes noticeable time to expand.
- src/js/DevTools.js: (devtools.domContentLoaded):
- 8:21 AM Changeset in webkit [59367] by
-
- 2 edits in trunk/LayoutTests
2010-05-13 Martin Robinson <mrobinson@igalia.com>
Reviewed by Gustavo Noronha.
Two forms tests failing
https://bugs.webkit.org/show_bug.cgi?id=31435
Unskip passing tests.
- platform/gtk/Skipped: Unskip these tests, because they are passing now.
- 7:56 AM Changeset in webkit [59366] by
-
- 2 edits in trunk/WebCore
2010-05-13 Chang Shu <chang.shu@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
Based on the spec and Philip Taylor's test suite, strokeStyle and fillStyle attributes
must initially have the string value #000000.
The link to the spec:
http://philip.html5.org/tests/canvas/suite/tests/spec.html#testrefs.2d.colours.default
The complete test suite is in the process of checking in.
https://bugs.webkit.org/show_bug.cgi?id=20553
- html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::State::State):
- 7:41 AM Changeset in webkit [59365] by
-
- 17 edits3 deletes in trunk/WebCore
2010-05-13 Yury Semikhatsky <yurys@chromium.org>
Unreviewed, rolling out r59360.
http://trac.webkit.org/changeset/59360
https://bugs.webkit.org/show_bug.cgi?id=38667
It broke Chromium Win build
- English.lproj/localizedStrings.js:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- inspector/front-end/CallStackSidebarPane.js: (WebInspector.CallStackSidebarPane): (WebInspector.CallStackSidebarPane.prototype._placardSelected):
- inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView):
- inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel):
- inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeOutline.prototype._keyDown):
- inspector/front-end/HelpScreen.js: Removed.
- inspector/front-end/KeyboardShortcut.js: (WebInspector.KeyboardShortcut._makeKeyFromCodeAndModifiers):
- inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel): (WebInspector.ScriptsPanel.prototype.elementsToRestoreScrollPositionsFor):
- inspector/front-end/ShortcutsHelp.js: Removed.
- inspector/front-end/SidebarPane.js: (WebInspector.SidebarPane.prototype._onTitleKeyDown):
- inspector/front-end/StylesSidebarPane.js: (WebInspector.StylesSidebarPane.prototype.removeSection):
- inspector/front-end/TextViewer.js: (WebInspector.TextViewer.prototype._handleKeyDown):
- inspector/front-end/WebKit.qrc:
- inspector/front-end/helpScreen.css: Removed.
- inspector/front-end/inspector.html:
- inspector/front-end/inspector.js: (WebInspector.loaded): (WebInspector.documentKeyDown): (WebInspector._searchKeyDown): (WebInspector.startEditing.keyDownEventListener): (WebInspector.startEditing):
- inspector/front-end/utilities.js:
- 7:39 AM Changeset in webkit [59364] by
-
- 3 edits in trunk/WebKitTools
2010-05-13 Eric Seidel <eric@webkit.org>
Unreviewed hack, attempting to get the commit-queue running again.
Disable compositing/iframes tests on the commit-queue as a workaround for bug 38912
https://bugs.webkit.org/show_bug.cgi?id=39067
I had this hack locally on the commit-queue, but it's fragile
and broke this morning. It will work much better if committed
to the repository. In either case it's temporary while we
work up a real fix for bug 38912.
- Scripts/webkitpy/common/config/ports.py:
- Expose an is_leopard() method.
- Scripts/webkitpy/tool/steps/runtests.py:
- Don't run compositing/iframes tests on the commit-queue under leopard.
- 7:35 AM Changeset in webkit [59363] by
-
- 2 edits in trunk/WebCore
https://bugs.webkit.org/show_bug.cgi?id=39063
[Qt] Tiled backing store checker pattern does not paint correctly when scaling factor is not 1
Reviewed by Kenneth Rohde Christiansen.
Use the dirty rect that has been adjusted for scaling instead of the original one.
- platform/graphics/TiledBackingStore.cpp:
(WebCore::TiledBackingStore::paint):
- 7:07 AM Changeset in webkit [59362] by
-
- 2 edits in trunk/WebCore
2010-05-13 Chang Shu <chang.shu@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
Based on Philip Taylor's test suite, resetting the canvas
state resets the current path.
https://bugs.webkit.org/show_bug.cgi?id=38934
The complete test suite is in the process of checking in.
https://bugs.webkit.org/show_bug.cgi?id=20553
- html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::reset):
- 6:48 AM Changeset in webkit [59361] by
-
- 8 edits1 delete in trunk/LayoutTests
2010-05-13 Yury Semikhatsky <yurys@chromium.org>
Unreviewed. Chromium build fix. Partially rever r59277 which updated Chromium's expectations
after r59270. r59270 was reverted, so we need to revert Chromium's expectations.
- platform/chromium-linux/editing/deleting/5408255-expected.checksum:
- platform/chromium-mac/editing/deleting/5408255-expected.checksum: Removed.
- platform/chromium-win/editing/deleting/5408255-expected.checksum:
- platform/chromium-win/editing/deleting/5408255-expected.txt:
- platform/chromium-win/editing/deleting/delete-select-all-001-expected.txt:
- platform/chromium-win/editing/selection/4895428-1-expected.txt:
- platform/chromium-win/editing/selection/4895428-4-expected.txt:
- platform/chromium-win/fast/events/mouseout-dead-node-expected.txt:
- 6:42 AM Changeset in webkit [59360] by
-
- 17 edits3 adds in trunk/WebCore
2010-05-13 Andrey Kosyakov <caseq@chromium.org>
Reviewed by Pavel Feldman.
Added help screen with keyboard shortcuts.
https://bugs.webkit.org/show_bug.cgi?id=38667
- English.lproj/localizedStrings.js:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- inspector/front-end/CallStackSidebarPane.js: (WebInspector.CallStackSidebarPane): (WebInspector.CallStackSidebarPane.prototype._placardSelected): (WebInspector.CallStackSidebarPane.prototype.registerShortcuts):
- inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView): (WebInspector.ConsoleView.prototype._registerShortcuts):
- inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel): (WebInspector.ElementsPanel.prototype._registerShortcuts):
- inspector/front-end/HelpScreen.js: Added.
- inspector/front-end/KeyboardShortcut.js: (WebInspector.KeyboardShortcut.makeDescriptor): (WebInspector.KeyboardShortcut.shortcutToString): (WebInspector.KeyboardShortcut._modifiersToString):
- inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel): (WebInspector.ScriptsPanel.prototype.elementsToRestoreScrollPositionsFor): (WebInspector.ScriptsPanel.prototype._registerShortcuts):
- inspector/front-end/ShortcutsHelp.js: Added.
- inspector/front-end/StylesSidebarPane.js: (WebInspector.StylesSidebarPane.prototype.removeSection): (WebInspector.StylesSidebarPane.prototype.registerShortcuts):
- inspector/front-end/WebKit.qrc:
- inspector/front-end/helpScreen.css: Added.
- 5:12 AM Changeset in webkit [59359] by
-
- 2 edits in trunk
2010-05-13 Takeshi Yoshino <tyoshino@google.com>
Reviewed by Shinichiro Hamaji.
Update test_expectations.txt for Chromium.
fast/forms/implicit-submission.html is flaky on Linux.
See http://crbug.com/43890 for detail.
- platform/chromium/test_expectations.txt:
- 5:05 AM Changeset in webkit [59358] by
-
- 2 edits in trunk/JavaScriptCore
No review, attempted build fix.
Try to fix Tiger build with some gratuitous initialization of
seemingly uninitialized variables.
- wtf/text/StringImpl.h:
(WebCore::StringImpl::tryCreateUninitialized):
- 2:43 AM Changeset in webkit [59357] by
-
- 3 edits2 adds in trunk
2010-05-13 Yoshiki Hayashi <yhayashi@google.com>
Reviewed by Darin Adler.
Fix a bug in handleRunInChild where only the first child run-in block
is inserted because removeChildNode clears next sibling.
https://bugs.webkit.org/show_bug.cgi?id=25047
- fast/css/run-in-children-expected.txt: Added.
- fast/css/run-in-children.html: Added.
2010-05-13 Yoshiki Hayashi <yhayashi@google.com>
Reviewed by Darin Adler.
Fix a bug in handleRunInChild where only the first child run-in block
is inserted because removeChildNode clears next sibling.
https://bugs.webkit.org/show_bug.cgi?id=25047
Test: fast/css/run-in-children.html
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::handleRunInChild):
- 2:37 AM Changeset in webkit [59356] by
-
- 2 edits in trunk/WebCore
2010-05-13 Alejandro G. Castro <alex@igalia.com>
Reviewed by Xan Lopez.
In case there is no expose event we render the theme in a pixmap
and copy it to the cairo context. This is slow but it is used just
in case we are printing nowadays.
[GTK] Theme does not render when printing
https://bugs.webkit.org/show_bug.cgi?id=38896
- platform/gtk/RenderThemeGtk.cpp: (WebCore::paintMozillaGtkWidget):
- 2:36 AM Changeset in webkit [59355] by
-
- 5 edits in trunk/JavaScriptCore
2010-05-13 Maciej Stachowiak <mjs@apple.com>
Reviewed by Mark Rowe.
Various JavaScript string optimizations
https://bugs.webkit.org/show_bug.cgi?id=39051
Approximately 1% SunSpider speedup.
- runtime/ArrayPrototype.cpp: (JSC::arrayProtoFuncJoin): Remove branches from the hot code path by moving the first pass outside the loop, and duplicating the hot loop to extract the loop-invariant branch.
- runtime/RegExp.cpp: (JSC::RegExp::match): resize ovector to 0 instead of clearing to avoid thrash in case of large matches.
- runtime/RegExpConstructor.h: (JSC::RegExpConstructor::performMatch): Mark ALWAYS_INLINE to make the compiler respect our authority.
- runtime/StringPrototype.cpp: (JSC::jsSpliceSubstringsWithSeparators): Inline. (JSC::stringProtoFuncSubstring): Rewrite boundary condition checks to reduce the number of floating point comparisons and branches.
- 1:52 AM Changeset in webkit [59354] by
-
- 3 edits in trunk
WebKitTools: Unreviewed fix. Revert previous change.
Even if with-statments are changed in websocket_server.py, it also claims syntax error for with statement in http_server.py.
Until python 2.5 is installed on tiger bot, skips websocket/tests on tiger.
- Scripts/webkitpy/layout_tests/port/websocket_server.py: use with statement
LayoutTests: Unreviewed.
Skip websocket/tests on tiger, until Python 2.5 is installed on tiger bot.
- platform/mac-tiger/Skipped: Add websocket/tests
- 1:52 AM Changeset in webkit [59353] by
-
- 2 edits in trunk/WebKitTools
WebSocket: pywebsocket 0.5
https://bugs.webkit.org/show_bug.cgi?id=38034
Reviewed by David Levin.
Remove pywebsocket from webkitpy/thirdparty.
Make pywebsocket autoinstalled.
- Scripts/new-run-webkit-websocketserver: Add --output-dir option.
- Scripts/old-run-webkit-tests: Use new-run-webkit-websocketserver, rather than directly run pywebsocket's standalone.py
- Scripts/run-webkit-websocketserver: Ditto.
- Scripts/webkitpy/layout_tests/port/websocket_server.py: Use autoinstalled pywebsocket.
- Scripts/webkitpy/thirdparty/init.py: Autoinstall pywebsocket
- Scripts/webkitpy/thirdparty/pywebsocket: Removed.
- 1:21 AM Changeset in webkit [59352] by
-
- 2 edits in trunk/WebKitTools
Unreviewed fix.
On tiger bot, it claims syntax error for with statement.
- Scripts/webkitpy/layout_tests/port/websocket_server.py: rewrite with statement with try-finally.
- 12:32 AM Changeset in webkit [59351] by
-
- 3 edits2 adds in trunk
2010-05-12 Yuzo Fujishima <yuzo@google.com>
Reviewed by Darin Adler.
Fix Bug 35014 - Modifying UA rules from page JS crashes
https://bugs.webkit.org/show_bug.cgi?id=35014
- fast/css/modify-ua-rules-from-javascript-expected.txt: Copied from LayoutTests/editing/selection/5136696-expected.txt.
- fast/css/modify-ua-rules-from-javascript.html: Added.
2010-05-12 Yuzo Fujishima <yuzo@google.com>
Reviewed by Darin Adler.
Fix Bug 35014 - Modifying UA rules from page JS crashes
Added a NULL check.
https://bugs.webkit.org/show_bug.cgi?id=35014
Test: fast/css/modify-ua-rules-from-javascript.html
- css/CSSMutableStyleDeclaration.cpp: (WebCore::CSSMutableStyleDeclaration::setNeedsStyleRecalc):
- 12:28 AM Changeset in webkit [59350] by
-
- 6 edits35 deletes in trunk/WebKitTools
2010-05-13 Fumitoshi Ukai <ukai@chromium.org>
Reviewed by David Levin.
WebSocket: pywebsocket 0.5
https://bugs.webkit.org/show_bug.cgi?id=38034
Remove pywebsocket from webkitpy/thirdparty.
Make pywebsocket autoinstalled.
- Scripts/new-run-webkit-websocketserver: Add --output-dir option.
- Scripts/old-run-webkit-tests: Use new-run-webkit-websocketserver, rather than directly run pywebsocket's standalone.py
- Scripts/run-webkit-websocketserver: Ditto.
- Scripts/webkitpy/layout_tests/port/websocket_server.py: Use autoinstalled pywebsocket.
- Scripts/webkitpy/thirdparty/init.py: Autoinstall pywebsocket
- Scripts/webkitpy/thirdparty/pywebsocket: Removed.
May 12, 2010:
- 11:44 PM Changeset in webkit [59349] by
-
- 6 edits2 adds in trunk/WebCore
Add the parent class for Database and DatabaseSync.
https://bugs.webkit.org/show_bug.cgi?id=39041
Reviewed by Adam Barth.
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- storage/AbstractDatabase.cpp: Added.
- storage/AbstractDatabase.h: Added.
- 11:39 PM Changeset in webkit [59348] by
-
- 3 edits in trunk/WebKit/chromium
2010-05-12 Hans Wennborg <hans@chromium.org>
Reviewed by Jeremy Orlow.
[Chromium] Remove transitional functions from WebStorageNamespace and WebViewClient.
https://bugs.webkit.org/show_bug.cgi?id=38985
These functions are no longer called as of Chromium revision 47020.
This is part of resolving http://crbug.com/42740
- public/WebStorageNamespace.h:
- public/WebViewClient.h: (WebKit::WebViewClient::createSessionStorageNamespace):
- 11:27 PM Changeset in webkit [59347] by
-
- 2 edits in trunk/WebCore
2010-05-12 Noam Rosenthal <noam.rosenthal@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] GraphicsLayer: depth-test causes flicker in certain situations
This patch removes the simplistic 2D depth test as it leads to flickering side effects.
https://bugs.webkit.org/show_bug.cgi?id=38370
Tested by http://webkit.org/blog-files/3d-transforms/morphing-cubes.html
- platform/graphics/qt/GraphicsLayerQt.cpp: (WebCore::GraphicsLayerQtImpl::updateTransform):
- 11:20 PM Changeset in webkit [59346] by
-
- 2 edits in trunk/WebKit/chromium
2010-05-12 Tony Chang <tony@chromium.org>
Reviewed by Kent Tamura.
[chromium] disable DRT in chromium again
https://bugs.webkit.org/show_bug.cgi?id=39049
- WebKit.gyp:
- 10:40 PM Changeset in webkit [59345] by
-
- 2 edits in trunk/LayoutTests
2010-05-12 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r59272.
http://trac.webkit.org/changeset/59272
https://bugs.webkit.org/show_bug.cgi?id=39047
Original change (59270) was rolled out (Requested by smfr on
#webkit).
- platform/qt/editing/deleting/5408255-expected.txt:
- 10:39 PM Changeset in webkit [59344] by
-
- 3 edits1 add in trunk/WebKitTools
Fixed a bug in svn-apply whereby the reviewer would not get set if
the portion of the patch for the ChangeLog contains "NOBODY (PS!)"
in the leading junk.
Reviewed by Daniel Bates.
https://bugs.webkit.org/show_bug.cgi?id=38998
- Scripts/VCSUtils.pm:
- Added the $changeLogTimeZone variable from svn-apply.
- Added setChangeLogDateAndReviewer() from svn-apply.
- Added a localTimeInProjectTimeZone() subroutine.
- In setChangeLogDateAndReviewer():
- Added an $epochTime parameter to make the subroutine more testable.
- Made the "NOBODY (PS!)" regular expression more specific so that it will not apply to text in the leading junk.
- Updated to call localTimeInProjectTimeZone().
- Scripts/svn-apply:
- Removed the $changeLogTimeZone file variable.
- Added an $epochTime file variable to represent the current time.
- Removed the setChangeLogDateAndReviewer() subroutine.
- Updated patch() to use the new setChangeLogDateAndReviewer() syntax.
- Scripts/webkitperl/VCSUtils_unittest/setChangeLogDateAndReviewer.pl: Added.
- Added unit tests.
- 10:38 PM Changeset in webkit [59343] by
-
- 2 edits in trunk/LayoutTests
2010-05-12 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r59276.
http://trac.webkit.org/changeset/59276
https://bugs.webkit.org/show_bug.cgi?id=39046
Original change (59270) was rolled out (Requested by smfr on
#webkit).
- platform/gtk/editing/deleting/delete-select-all-001-expected.txt:
- 10:28 PM Changeset in webkit [59342] by
-
- 13 edits5 deletes in trunk
2010-05-12 Simon Fraser <Simon Fraser>
Reviewed by Mark Rowe.
Fix layer dump to avoid spurious platform differences
https://bugs.webkit.org/show_bug.cgi?id=39045
Only dump the children transform on layers that are not the root layer.
The children transform on the root layer is used on Leopard to implement
geometry flipping, so avoid this supurious difference in test output.
- platform/graphics/GraphicsLayer.cpp: (WebCore::GraphicsLayer::dumpProperties):
- 9:45 PM Changeset in webkit [59341] by
-
- 9 edits2 deletes in trunk
2010-05-12 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r59270.
http://trac.webkit.org/changeset/59270
https://bugs.webkit.org/show_bug.cgi?id=39044
Caused a crash on some pages - bug 39042 (Requested by smfr on
#webkit).
- editing/deleting/delete-block-contents-004-expected.txt: Removed.
- editing/deleting/delete-block-contents-004.html: Removed.
- editing/deleting/in-visibly-empty-root-expected.txt:
- platform/mac/editing/deleting/5408255-expected.txt:
- platform/mac/editing/deleting/delete-select-all-001-expected.txt:
- platform/mac/editing/selection/4895428-1-expected.txt:
- platform/mac/editing/selection/4895428-4-expected.txt:
- platform/mac/fast/events/mouseout-dead-node-expected.txt:
2010-05-12 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r59270.
http://trac.webkit.org/changeset/59270
https://bugs.webkit.org/show_bug.cgi?id=39044
Caused a crash on some pages - bug 39042 (Requested by smfr on
#webkit).
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::removeChild):
- 9:12 PM Changeset in webkit [59340] by
-
- 2 edits in trunk/WebKitTools
2010-05-12 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
test-webkitpy fails on windows due to lack of readline module
https://bugs.webkit.org/show_bug.cgi?id=38884
Win32 Python does not have a readline module, so we should
not exit(1) if the import fails.
Also the failure message is mac-specific and doesn't need to be.
Only print the mac-specific install instructions on mac.
- Scripts/webkitpy/common/system/user.py:
- 9:01 PM Changeset in webkit [59339] by
-
- 22 edits in trunk/JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=39039
Provide support for separate bytecode/JIT code translations for call/construct usage
This will allow us to produce code generated specifically for use as a constructor, not for general function use.
Reviewed by Oliver Hunt.
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::CodeBlock):
(JSC::CodeBlock::unlinkCallers):
- bytecode/CodeBlock.h:
(JSC::CodeBlock::getBytecodeIndex):
(JSC::CodeBlock::getJITCode):
(JSC::CodeBlock::executablePool):
(JSC::GlobalCodeBlock::GlobalCodeBlock):
(JSC::FunctionCodeBlock::FunctionCodeBlock):
- interpreter/Interpreter.cpp:
(JSC::Interpreter::executeCall):
(JSC::Interpreter::executeConstruct):
(JSC::Interpreter::prepareForRepeatCall):
(JSC::Interpreter::execute):
(JSC::Interpreter::privateExecute):
- interpreter/Interpreter.h:
- jit/JIT.cpp:
(JSC::JIT::unlinkCallOrConstruct):
(JSC::JIT::linkConstruct):
- jit/JIT.h:
- jit/JITCall.cpp:
(JSC::JIT::compileOpCall):
(JSC::JIT::compileOpCallSlowCase):
- jit/JITOpcodes.cpp:
(JSC::JIT::privateCompileCTIMachineTrampolines):
- jit/JITOpcodes32_64.cpp:
(JSC::JIT::privateCompileCTIMachineTrampolines):
- jit/JITPropertyAccess.cpp:
(JSC::JIT::emitSlow_op_get_by_val):
- jit/JITPropertyAccess32_64.cpp:
(JSC::JIT::emitSlow_op_get_by_val):
- jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
- jit/JITStubs.h:
(JSC::JITThunks::ctiVirtualConstructLink):
(JSC::JITThunks::ctiVirtualConstruct):
(JSC::):
- jit/SpecializedThunkJIT.h:
(JSC::SpecializedThunkJIT::finalize):
- runtime/Arguments.h:
(JSC::JSActivation::copyRegisters):
- runtime/ArrayPrototype.cpp:
(JSC::isNumericCompareFunction):
- runtime/Executable.cpp:
(JSC::FunctionExecutable::~FunctionExecutable):
(JSC::FunctionExecutable::compileForCall):
(JSC::FunctionExecutable::compileForConstruct):
(JSC::EvalExecutable::generateJITCode):
(JSC::ProgramExecutable::generateJITCode):
(JSC::FunctionExecutable::generateJITCodeForCall):
(JSC::FunctionExecutable::generateJITCodeForConstruct):
(JSC::FunctionExecutable::markAggregate):
(JSC::FunctionExecutable::reparseExceptionInfo):
(JSC::EvalExecutable::reparseExceptionInfo):
(JSC::FunctionExecutable::recompile):
- runtime/Executable.h:
(JSC::ExecutableBase::ExecutableBase):
(JSC::ExecutableBase::isHostFunction):
(JSC::ExecutableBase::generatedJITCodeForCall):
(JSC::ExecutableBase::generatedJITCodeForConstruct):
(JSC::NativeExecutable::NativeExecutable):
(JSC::EvalExecutable::jitCode):
(JSC::ProgramExecutable::jitCode):
(JSC::FunctionExecutable::bytecodeForCall):
(JSC::FunctionExecutable::isGeneratedForCall):
(JSC::FunctionExecutable::generatedBytecodeForCall):
(JSC::FunctionExecutable::bytecodeForConstruct):
(JSC::FunctionExecutable::isGeneratedForConstruct):
(JSC::FunctionExecutable::generatedBytecodeForConstruct):
(JSC::FunctionExecutable::symbolTable):
(JSC::FunctionExecutable::FunctionExecutable):
(JSC::FunctionExecutable::jitCodeForCall):
(JSC::FunctionExecutable::jitCodeForConstruct):
- runtime/JSActivation.h:
(JSC::JSActivation::JSActivationData::JSActivationData):
- runtime/JSFunction.cpp:
(JSC::JSFunction::~JSFunction):
(JSC::JSFunction::call):
(JSC::JSFunction::construct):
- runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::numericCompareFunction):
- 8:27 PM Changeset in webkit [59338] by
-
- 10 edits4 adds in trunk
2010-05-12 Simon Fraser <Simon Fraser>
Reviewed by David Hyatt.
Composited plug-ins can cause missed painting
https://bugs.webkit.org/show_bug.cgi?id=39033
<rdar://problem/7972478>
Fixed missed painting (and assertions in debug builds) related to compositing
propagating out of iframes that contain plug-ins.
When an iframe enters or leaves compositing mode, RenderLayerCompositor uses
setNeedsStyleRecalc(SyntheticStyleChange) to trigger the parent document to re-evaluate
whether the iframe itself should be composited. However, for iframes containing plug-ins,
this can happen at inappropriate times. For example, when a browser tab is brought frontmost,
plug-ins are instantiated for the first time (via -viewDidMoveToWindow), which triggers a
setNeedsStyleRecalc() on the object element. Soon after, the -viewWillDraw machinery
does layout from the top down. During layout of the iframe, the iframe enters compositing mode,
and does a setNeedsStyleRecalc() on the iframe element in its parent document. This leaves the
FrameView as needsLayout(), so the FrameView::paintContents() asserts and bails.
The fix is to avoid doing a setNeedsStyleRecalc() on the root while inside a recalcStyle on
the iframe. We do this by switching the iframe into compositing mode eagerly as soon as we know
the plug-in needs it.
A secondary fix is to ensure that if a document has composited iframes, when that document becomes
composited, we connect compositing layers between the iframes and the parent document.
Tests: compositing/iframes/connect-compositing-iframe-delayed.html
compositing/iframes/iframe-src-change.html
- WebCore.base.exp: Export FrameView::enterCompositingMode()
- page/FrameView.h: New method, enterCompositingMode(), that we can call from WebKit plug-in code.
- page/FrameView.cpp: (WebCore::FrameView::enterCompositingMode):
- rendering/RenderLayerCompositor.h:
- rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::enableCompositingMode): When we switch into compositing mode, we
force a style recaclc on any iframes to get them into compositing layers, so they can hook up
with their content layers if necessary.
(WebCore::RenderLayerCompositor::didMoveOnscreen): Only call attachRootPlatformLayer() if we really need to.
(WebCore::RenderLayerCompositor::willMoveOffscreen): Only call detachRootPlatformLayer() if we really need to.
(WebCore::RenderLayerCompositor::detachRootPlatformLayer): Whitespace.
(WebCore::RenderLayerCompositor::notifyIFramesOfCompositingChange): Fetch iframe elements, and send a
synthetic style recalc on them.
- 8:20 PM Changeset in webkit [59337] by
-
- 2 edits in trunk/JavaScriptCore
Build fix
<rdar://problem/7977960> REGRESSION (r59282): Tiger PPC build broken
- 8:12 PM Changeset in webkit [59336] by
-
- 7 edits in trunk
2010-05-12 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
<rdar://7969718> Incorrect 32-bit codegen for op_jnlesseq
https://bugs.webkit.org/show_bug.cgi?id=39038
Correct the use of incorrect comparison operators.
- jit/JITArithmetic32_64.cpp: (JSC::JIT::emit_op_jlesseq): (JSC::JIT::emitBinaryDoubleOp):
2010-05-12 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
<rdar://7969718> Incorrect 32-bit codegen for op_jnlesseq
https://bugs.webkit.org/show_bug.cgi?id=39038
Add more tests for <=, <, >, and >=.
- fast/js/comparison-operators-greater-expected.txt:
- fast/js/comparison-operators-less-expected.txt:
- fast/js/script-tests/comparison-operators-greater.js:
- fast/js/script-tests/comparison-operators-less.js:
- 7:37 PM Changeset in webkit [59335] by
-
- 2 edits in trunk/WebKit/qt
2010-05-12 Joe Ligman <joseph.ligman@nokia.com>
Reviewed by Laszlo Gombos.
[Qt] Nested overflow div does not scroll
https://bugs.webkit.org/show_bug.cgi?id=38641
Modify qtwebkit_webframe_scrollOverflow, if the current node's render layer
does not scroll it will try and scroll the parent's render layer. Also export
qtwebkit_webframe_scrollOverflow so we can use it independently of
qtwebkit_webframe_scrollRecursively
- Api/qwebframe.cpp: (qtwebkit_webframe_scrollOverflow): (qtwebkit_webframe_scrollRecursively):
- 7:25 PM Changeset in webkit [59334] by
-
- 3 edits in trunk/JavaScriptCore
2010-05-12 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
Reviewed by Eric Seidel.
JavaScriptCore: fix build when some optimizations are disabled
https://bugs.webkit.org/show_bug.cgi?id=38800
Remove outdated UNUSED_PARAMs when using JIT but with
ENABLE_JIT_OPTIMIZE_CALL and ENABLE_JIT_OPTIMIZE_PROPERTY_ACCESS
disabled.
- jit/JITOpcodes.cpp:
- jit/JITOpcodes32_64.cpp:
- 6:26 PM Changeset in webkit [59333] by
-
- 2 edits in trunk/WebKitTools
2010-05-12 Kent Tamura <tkent@chromium.org>
Reviewed by Nate Chapin.
[DRT/Chromium] Add a missing Sans-serif font setting
https://bugs.webkit.org/show_bug.cgi?id=38981
- DumpRenderTree/chromium/TestShell.cpp: (TestShell::resetWebSettings): Set "Helvetica" for Sans-serif. It is the same as the default setting of test_shell.
- 5:46 PM Changeset in webkit [59332] by
-
- 2 edits in trunk/WebKit/chromium
2010-05-12 John Abd-El-Malek <jam@chromium.org>
Reviewed by Darin Fisher.
[chromium] Disable WebScrollbarImpl's scrollbar if it's not needed
https://bugs.webkit.org/show_bug.cgi?id=39025
- src/WebScrollbarImpl.cpp: (WebKit::WebScrollbarImpl::setLocation): (WebKit::WebScrollbarImpl::setDocumentSize):
- 5:41 PM Changeset in webkit [59331] by
-
- 5 edits in trunk
Versioning.
- 5:34 PM Changeset in webkit [59330] by
-
- 3 edits in trunk/WebCore
2010-05-12 Anders Carlsson <andersca@apple.com>
Reviewed by Simon Fraser.
Shrink the size of FillLayer by moving a member variable.
https://bugs.webkit.org/show_bug.cgi?id=39035
- rendering/style/FillLayer.cpp: (WebCore::FillLayer::FillLayer):
- rendering/style/FillLayer.h:
- 5:32 PM Changeset in webkit [59329] by
-
- 2 edits in branches/safari-533-branch/WebCore
Merge r59192.
- 5:32 PM Changeset in webkit [59328] by
-
- 2 edits in branches/safari-533-branch/WebCore
Merge r59190.
- 5:32 PM WebKit Team edited by
- (diff)
- 5:32 PM Changeset in webkit [59327] by
-
- 8 edits in branches/safari-533-branch/WebKit/win
Merge r59175.
- 5:32 PM Changeset in webkit [59326] by
-
- 11 edits in branches/safari-533-branch
Merge r59173.
- 5:31 PM Changeset in webkit [59325] by
-
- 4 edits in branches/safari-533-branch/WebCore
Merge r59155.
- 5:31 PM Changeset in webkit [59324] by
-
- 3 edits in branches/safari-533-branch/WebKit/mac
Merge r59125.
- 5:31 PM Changeset in webkit [59323] by
-
- 5 edits2 adds in branches/safari-533-branch
Merge r59109.
- 5:31 PM Changeset in webkit [59322] by
-
- 7 edits3 adds in branches/safari-533-branch
Merge r59100.
- 5:31 PM Changeset in webkit [59321] by
-
- 7 edits2 adds in branches/safari-533-branch
Merge r59098.
- 5:31 PM Changeset in webkit [59320] by
-
- 1 edit in branches/safari-533-branch/JavaScriptCore/jit/JITOpcodes.cpp
Merge r59065.
- 5:31 PM Changeset in webkit [59319] by
-
- 14 edits2 moves1 add1 delete in branches/safari-533-branch
Merge r59064.
- 5:30 PM Changeset in webkit [59318] by
-
- 5 edits in branches/safari-533-branch/WebCore
Merge r59058.
- 5:30 PM Changeset in webkit [59317] by
-
- 2 edits in branches/safari-533-branch/WebCore
Merge r59009.
- 5:30 PM Changeset in webkit [59316] by
-
- 2 edits in branches/safari-533-branch/WebCore/platform/graphics/win
Merge r59008.
- 5:30 PM Changeset in webkit [59315] by
-
- 1 edit in branches/safari-533-branch/WebCore/platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.h
Merge r59007.
- 5:30 PM Changeset in webkit [59314] by
-
- 1 edit in branches/safari-533-branch/WebCore/platform/graphics/win/QTMovieVisualContext.cpp
Merge r59003.
- 5:30 PM Changeset in webkit [59313] by
-
- 14 edits3 copies2 moves11 adds in branches/safari-533-branch
Merge r59001.
- 5:30 PM Changeset in webkit [59312] by
-
- 2 edits in branches/safari-533-branch/WebCore
Merge r58983.
- 5:30 PM Changeset in webkit [59311] by
-
- 4 edits1 add in branches/safari-533-branch/WebCore
Merge r58950.
- 5:29 PM Changeset in webkit [59310] by
-
- 3 edits3 adds in branches/safari-533-branch
Merge r58936.
- 5:29 PM Changeset in webkit [59309] by
-
- 4 edits5 adds in branches/safari-533-branch
Merge r59147.
- 5:29 PM Changeset in webkit [59308] by
-
- 9 edits in branches/safari-533-branch/WebCore
Merge r59116.
- 5:29 PM Changeset in webkit [59307] by
-
- 4 edits2 adds in branches/safari-533-branch
Merge r59111.
- 5:29 PM Changeset in webkit [59306] by
-
- 2 edits in branches/safari-533-branch/WebKit/mac
Merge r59093.
- 5:29 PM Changeset in webkit [59305] by
-
- 2 edits in branches/safari-533-branch/WebKit/mac
Merge r59086.
- 5:29 PM Changeset in webkit [59304] by
-
- 8 edits in branches/safari-533-branch/WebKit/mac
Merge r58982.
- 5:29 PM Changeset in webkit [59303] by
-
- 10 edits in branches/safari-533-branch
Merge r58965.
- 5:29 PM Changeset in webkit [59302] by
-
- 3 edits4 adds in branches/safari-533-branch
Merge r58961.
- 5:28 PM Changeset in webkit [59301] by
-
- 9 edits in branches/safari-533-branch
Merge r58960.
- 5:28 PM Changeset in webkit [59300] by
-
- 2 edits in branches/safari-533-branch/JavaScriptCore
Merge r59170.
- 5:28 PM Changeset in webkit [59299] by
-
- 7 edits in branches/safari-533-branch/JavaScriptCore
Merge r59161.
- 5:28 PM Changeset in webkit [59298] by
-
- 2 edits in branches/safari-533-branch/JavaScriptCore
Merge r59061.
- 5:28 PM Changeset in webkit [59297] by
-
- 7 edits in branches/safari-533-branch/JavaScriptCore
Merge r59056.
- 5:28 PM Changeset in webkit [59296] by
-
- 3 edits in branches/safari-533-branch/JavaScriptCore
Merge r59055.
- 5:28 PM Changeset in webkit [59295] by
-
- 7 edits1 add in branches/safari-533-branch/JavaScriptCore
Merge r59040.
- 5:28 PM Changeset in webkit [59294] by
-
- 3 edits3 adds in branches/safari-533-branch
Merge r58993.
- 5:28 PM Changeset in webkit [59293] by
-
- 2 edits in branches/safari-533-branch/JavaScriptCore
Merge r58991.
- 5:27 PM Changeset in webkit [59292] by
-
- 2 edits in branches/safari-533-branch/JavaScriptCore
Merge r58988.
- 5:27 PM Changeset in webkit [59291] by
-
- 2 edits in branches/safari-533-branch/JavaScriptCore
Merge r58987.
- 5:27 PM Changeset in webkit [59290] by
-
- 20 edits in branches/safari-533-branch/JavaScriptCore
Merge r58986.
- 5:27 PM Changeset in webkit [59289] by
-
- 2 edits in branches/safari-533-branch/JavaScriptCore
Merge r58974.
- 5:27 PM Changeset in webkit [59288] by
-
- 2 edits in branches/safari-533-branch/JavaScriptCore
Merge r58970.
- 5:27 PM Changeset in webkit [59287] by
-
- 2 edits in branches/safari-533-branch/JavaScriptCore
Merge r58964.
- 5:27 PM Changeset in webkit [59286] by
-
- 5 edits1 add in branches/safari-533-branch/JavaScriptCore
Merge r58935.
- 5:19 PM Changeset in webkit [59285] by
-
- 1 copy in branches/safari-533-branch
New branch.
- 4:55 PM Changeset in webkit [59284] by
-
- 5 edits in trunk/WebKitTools
2010-05-10 Ojan Vafai <ojan@chromium.org>
Reviewed by Adam Barth.
webkit-patch upload --fancy-review now uses the bugzilla bug ID as the rietveld ID
https://bugs.webkit.org/show_bug.cgi?id=38866
wkrietveld.appspot.com has already been updated to allow you to
pass --issue for the issue creation as well as subsequent uploads.
Also, remove the extra code for trying to read out the issue ID
from the changelog description since we just use the bugzilla ID now.
- Scripts/webkitpy/common/config/init.py:
- Scripts/webkitpy/common/net/rietveld.py:
- Scripts/webkitpy/tool/steps/postcodereview.py:
- Scripts/webkitpy/tool/steps/postdiff.py:
- 4:43 PM WebKit Team edited by
- (diff)
- 4:34 PM Changeset in webkit [59283] by
-
- 2 edits in trunk/WebKitTools
2010-05-12 Ojan Vafai <ojan@chromium.org>
No review needed.
Marking myself as a reviewer.
- Scripts/webkitpy/common/config/committers.py:
- 4:25 PM Changeset in webkit [59282] by
-
- 5 edits in trunk/JavaScriptCore
Work around GCC stupidity by either explicitly inlining or by
using ALWAYS_INLINE
Reviewed by Gaving Barraclough.
- runtime/StringPrototype.cpp:
(JSC::stringProtoFuncReplace):
- runtime/UString.h:
(JSC::UString::~UString):
- wtf/RefPtr.h:
(WTF::RefPtr::RefPtr):
(WTF::RefPtr::~RefPtr):
- wtf/text/StringImpl.h:
(WebCore::StringImpl::create):
(WebCore::StringImpl::tryCreateUninitialized):
- 4:21 PM Changeset in webkit [59281] by
-
- 13 edits in trunk/WebCore
A bunch of nice micro-optimizations for ~1% speedup on PLT.
- Add fastGetAttribute. The same as getAttribute except can only be called when it is known not to be style attribute or one of the SVG animatable attributes.
- Inline some functions from Font.
- Return the same string from deprecatedParseURL if there is nothing to strip.
- Use a member variable instead of a virtual function to determine whether a ScheduledNavigation is a location change.
Reviewed by Anders Carlsson.
- WebCore.base.exp:
- css/CSSHelper.cpp:
(WebCore::deprecatedParseURL):
- css/CSSStyleSelector.cpp:
(WebCore::linkAttribute):
(WebCore::CSSStyleSelector::canShareStyleWithElement):
(WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
- dom/Element.cpp:
(WebCore::Element::getAttribute):
- dom/Element.h:
(WebCore::Element::fastHasAttribute):
(WebCore::Element::fastGetAttribute):
- html/HTMLFormControlElement.cpp:
(WebCore::HTMLFormControlElement::formControlName):
- html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::value):
- loader/RedirectScheduler.cpp:
(WebCore::ScheduledNavigation::ScheduledNavigation):
(WebCore::ScheduledNavigation::isLocationChange):
(WebCore::ScheduledURLNavigation::ScheduledURLNavigation):
(WebCore::ScheduledRedirect::ScheduledRedirect):
(WebCore::ScheduledLocationChange::ScheduledLocationChange):
(WebCore::ScheduledRefresh::ScheduledRefresh):
(WebCore::ScheduledHistoryNavigation::ScheduledHistoryNavigation):
(WebCore::ScheduledFormSubmission::ScheduledFormSubmission):
(WebCore::RedirectScheduler::locationChangePending):
- platform/graphics/Font.cpp:
- platform/graphics/Font.h:
(WebCore::Font::~Font):
(WebCore::Font::primaryFont):
(WebCore::Font::fontDataAt):
(WebCore::Font::fontDataForCharacters):
(WebCore::Font::isFixedPitch):
(WebCore::Font::fontSelector):
- platform/graphics/FontFallbackList.h:
- rendering/RenderImage.cpp:
(WebCore::RenderImage::imageMap):
- 3:48 PM Changeset in webkit [59280] by
-
- 2 edits in trunk/LayoutTests
2010-05-12 Dirk Pranke <dpranke@chromium.org>
Unreviewed, build fix.
Change expectation from IMAGE to IMAGE+TEXT for Chromium Linux; I'm
not sure if this is flaky or not but it seems to be consistent on the
bot.
- platform/chromium/test_expectations.txt:
- 3:36 PM Changeset in webkit [59279] by
-
- 3 edits in trunk/WebKitTools
2010-05-12 Dirk Pranke <dpranke@chromium.org>
Reviewed by Eric Seidel.
new-run-webkit-tests: add a --print default option so that you can
easily get the default output plus something (e.g., you can say
'--print default,config' instead of '--print misc,one-line-progress,
one-line-summary,unexpected,unexpected-results,updates,config'.
Also, add more unit tests for --verbose, --print everything, etc.
- Scripts/webkitpy/layout_tests/layout_package/printing.py:
- Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
- 3:35 PM Changeset in webkit [59278] by
-
- 8 edits2 adds in trunk/LayoutTests
2010-05-12 Dirk Pranke <dpranke@chromium.org>
Reviewed by Nate Chapin.
Expectations fix and new chromium baselines resulting from the
input type=search change in r58313.
- platform/chromium-linux/fast/forms/placeholder-pseudo-style-expected.checksum:
- platform/chromium-linux/fast/forms/placeholder-pseudo-style-expected.png:
- platform/chromium-linux/fast/forms/search-vertical-alignment-expected.checksum:
- platform/chromium-linux/fast/forms/search-vertical-alignment-expected.png: Added.
- platform/chromium-win/fast/forms/search-vertical-alignment-expected.checksum:
- platform/chromium-win/fast/forms/search-vertical-alignment-expected.png: Added.
- platform/chromium/test_expectations.txt:
- platform/mac/fast/forms/search-zoomed-expected.checksum:
- platform/mac/fast/forms/search-zoomed-expected.png:
- 3:33 PM Changeset in webkit [59277] by
-
- 15 edits3 adds in trunk/LayoutTests
Unreviewed. Chromium: rebaseline layout tests.
- platform/chromium-linux/editing/deleting/5408255-expected.checksum:
- platform/chromium-linux/editing/deleting/5408255-expected.png:
- platform/chromium-linux/fast/css/pseudo-cache-stale-expected.checksum:
- platform/chromium-linux/fast/css/pseudo-cache-stale-expected.png:
- platform/chromium-mac/editing/deleting/5408255-expected.checksum: Added.
- platform/chromium-mac/editing/deleting/5408255-expected.png: Added.
- platform/chromium-mac/fast/css/pseudo-cache-stale-expected.checksum: Added.
- platform/chromium-win/editing/deleting/5408255-expected.checksum:
- platform/chromium-win/editing/deleting/5408255-expected.png:
- platform/chromium-win/editing/deleting/5408255-expected.txt:
- platform/chromium-win/editing/deleting/delete-select-all-001-expected.txt:
- platform/chromium-win/editing/selection/4895428-1-expected.txt:
- platform/chromium-win/editing/selection/4895428-4-expected.txt:
- platform/chromium-win/fast/css/pseudo-cache-stale-expected.checksum:
- platform/chromium-win/fast/css/pseudo-cache-stale-expected.png:
- platform/chromium-win/fast/css/pseudo-cache-stale-expected.txt:
- platform/chromium-win/fast/events/mouseout-dead-node-expected.txt:
- 3:31 PM Changeset in webkit [59276] by
-
- 2 edits in trunk/LayoutTests
2010-05-12 Martin Robinson <mrobinson@igalia.com>
No review. Updating the baseline for this test after r59270.
- platform/gtk/editing/deleting/delete-select-all-001-expected.txt:
- 3:10 PM Changeset in webkit [59275] by
-
- 3 edits in trunk/WebKitTools
Qt build failures cause SheriffBot false positives
https://bugs.webkit.org/show_bug.cgi?id=38969
Reviewed by Adam Barth.
Add Qt bots back to the core builders, because bug fixed by r59261.
- Scripts/webkitpy/common/net/buildbot.py:
- Scripts/webkitpy/common/net/buildbot_unittest.py:
- 3:07 PM Changeset in webkit [59274] by
-
- 23 edits1 delete in trunk/WebCore
Make InlineBoxes use an IntRect for dimensions, and eliminate the dynamic computation of height() every time.
Reviewed by Sam Weinig.
- WebCore.xcodeproj/project.pbxproj:
- editing/visible_units.cpp:
(WebCore::previousLinePosition):
(WebCore::nextLinePosition):
- rendering/EllipsisBox.cpp:
(WebCore::EllipsisBox::paint):
(WebCore::EllipsisBox::selectionRect):
(WebCore::EllipsisBox::paintSelection):
(WebCore::EllipsisBox::nodeAtPoint):
- rendering/EllipsisBox.h:
(WebCore::EllipsisBox::EllipsisBox):
- rendering/InlineBox.cpp:
(WebCore::InlineBox::adjustPosition):
(WebCore::InlineBox::canAccommodateEllipsis):
- rendering/InlineBox.h:
(WebCore::InlineBox::InlineBox):
(WebCore::InlineBox::isSVGRootInlineBox):
(WebCore::InlineBox::x):
(WebCore::InlineBox::y):
(WebCore::InlineBox::width):
(WebCore::InlineBox::height):
(WebCore::InlineBox::bottom):
(WebCore::InlineBox::right):
(WebCore::InlineBox::setX):
(WebCore::InlineBox::setY):
(WebCore::InlineBox::setWidth):
(WebCore::InlineBox::setHeight):
(WebCore::InlineBox::location):
(WebCore::InlineBox::size):
(WebCore::InlineBox::setLocation):
(WebCore::InlineBox::setSize):
(WebCore::InlineBox::move):
(WebCore::InlineBox::frameRect):
(WebCore::InlineBox::setFrameRect):
(WebCore::InlineBox::baselinePosition):
(WebCore::InlineBox::lineHeight):
- rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::placeBoxesVertically):
(WebCore::InlineFlowBox::computeVerticalOverflow):
(WebCore::InlineFlowBox::nodeAtPoint):
(WebCore::InlineFlowBox::paintBoxDecorations):
(WebCore::InlineFlowBox::paintMask):
(WebCore::InlineFlowBox::paintTextDecorations):
- rendering/InlineFlowBox.h:
(WebCore::InlineFlowBox::visibleOverflowRect):
(WebCore::InlineFlowBox::topLayoutOverflow):
(WebCore::InlineFlowBox::bottomLayoutOverflow):
(WebCore::InlineFlowBox::leftLayoutOverflow):
(WebCore::InlineFlowBox::rightLayoutOverflow):
(WebCore::InlineFlowBox::layoutOverflowRect):
(WebCore::InlineFlowBox::topVisualOverflow):
(WebCore::InlineFlowBox::bottomVisualOverflow):
(WebCore::InlineFlowBox::leftVisualOverflow):
(WebCore::InlineFlowBox::rightVisualOverflow):
(WebCore::InlineFlowBox::visualOverflowRect):
(WebCore::InlineFlowBox::setHorizontalOverflowPositions):
(WebCore::InlineFlowBox::setVerticalOverflowPositions):
- rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::selectionRect):
(WebCore::InlineTextBox::placeEllipsisBox):
(WebCore::InlineTextBox::nodeAtPoint):
(WebCore::InlineTextBox::paint):
(WebCore::InlineTextBox::paintSelection):
(WebCore::InlineTextBox::paintCompositionBackground):
(WebCore::InlineTextBox::paintDecoration):
(WebCore::InlineTextBox::paintSpellingOrGrammarMarker):
(WebCore::InlineTextBox::paintTextMatchMarker):
(WebCore::InlineTextBox::computeRectForReplacementMarker):
(WebCore::InlineTextBox::paintCompositionUnderline):
(WebCore::InlineTextBox::offsetForPosition):
(WebCore::InlineTextBox::positionForOffset):
- rendering/InlineTextBox.h:
(WebCore::InlineTextBox::setSpaceAdd):
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::positionForPointWithInlineChildren):
- rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::computeVerticalPositionsForLine):
(WebCore::RenderBlock::layoutInlineChildren):
- rendering/RenderSVGInline.cpp:
(WebCore::RenderSVGInline::createInlineFlowBox):
- rendering/RenderSVGInlineText.cpp:
(WebCore::RenderSVGInlineText::createTextBox):
- rendering/RenderSVGText.cpp:
(WebCore::RenderSVGText::createRootInlineBox):
- rendering/RenderText.cpp:
(WebCore::RenderText::positionForPoint):
(WebCore::RenderText::firstRunX):
(WebCore::RenderText::firstRunY):
- rendering/RenderTreeAsText.cpp:
(WebCore::writeTextRun):
- rendering/RootInlineBox.cpp:
(WebCore::RootInlineBox::placeEllipsis):
(WebCore::RootInlineBox::addHighlightOverflow):
(WebCore::RootInlineBox::closestLeafChildForXPos):
- rendering/SVGInlineFlowBox.h:
(WebCore::SVGInlineFlowBox::SVGInlineFlowBox):
- rendering/SVGInlineTextBox.h:
(WebCore::SVGInlineTextBox::selectionTop):
(WebCore::SVGInlineTextBox::selectionHeight):
- rendering/SVGRootInlineBox.h:
(WebCore::SVGRootInlineBox::SVGRootInlineBox):
(WebCore::SVGRootInlineBox::isSVGRootInlineBox):
- rendering/TrailingFloatsRootInlineBox.h: Removed.
- 2:52 PM Changeset in webkit [59273] by
-
- 6 edits in trunk
Removing the unnecessary dirfd parameter.
https://bugs.webkit.org/show_bug.cgi?id=38869
Reviewed by Dimitri Glazkov.
WebCore:
- platform/chromium/ChromiumBridge.h:
- platform/sql/chromium/SQLiteFileSystemChromiumPosix.cpp:
WebKit/chromium:
- public/WebKitClient.h:
(WebKit::WebKitClient::databaseOpenFile):
- src/ChromiumBridge.cpp:
(WebCore::ChromiumBridge::databaseOpenFile):
- 2:47 PM Changeset in webkit [59272] by
-
- 2 edits in trunk/LayoutTests
Unreviewed fix after r59270.
Update Qt specific expected result based on IRC discussing with Enrica Casucci.
- platform/qt/editing/deleting/5408255-expected.txt: updated.
- 2:34 PM Changeset in webkit [59271] by
-
- 2 edits1 copy in trunk/BugsSite
Hide the in-rietveld flag in the UI. It is only used only by tooling and shouldn't clutter the UI.
https://bugs.webkit.org/show_bug.cgi?id=39024
Reviewed by Ojan Vafai.
- template/en/custom/attachment/list.html.tmpl: Removes this flag entirely from the UI, not needed on this page.
- template/en/custom/flag/list.html.tmpl: Added. Copied from template/en/default/flag/list.html.tmpl with only changes inside the if WEBKIT_CHANGES section. Hides the flag rather than removing it completely, so tools can still interact with it.
- 2:24 PM Changeset in webkit [59270] by
-
- 9 edits2 adds in trunk
Adding block elements to a block and removing them changes the height of the element.
https://bugs.webkit.org/show_bug.cgi?id=38874
Reviewed by Dave Hyatt.
WebCore:
The initial height of an empty editable block is different from the height of the same block after we add block elements
and remove them.
Test: editing/deleting/delete-block-contents-004.html
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::removeChild): m_childrenInline was set to true only when the Renderer is created
and never reset to true when all the block elements contained are removed.
LayoutTests:
- editing/deleting/delete-block-contents-004-expected.txt: Added.
- editing/deleting/delete-block-contents-004.html: Added.
The following tests have new results because of the height change and because we now have one less renderer after the DOM changes.
- editing/deleting/in-visibly-empty-root-expected.txt:
- platform/mac/editing/deleting/5408255-expected.txt:
- platform/mac/editing/deleting/delete-select-all-001-expected.txt:
- platform/mac/editing/selection/4895428-1-expected.txt:
- platform/mac/editing/selection/4895428-4-expected.txt:
- platform/mac/fast/events/mouseout-dead-node-expected.txt
- 2:21 PM Changeset in webkit [59269] by
-
- 14 edits15 adds in trunk/LayoutTests
Unreviewed. Chromium: rebaseline layout tests and mark one failed layout test.
- platform/chromium-linux/fast/forms/placeholder-stripped-expected.checksum: Added.
- platform/chromium-linux/fast/forms/placeholder-stripped-expected.png: Added.
- platform/chromium-linux/svg/W3C-SVG-1.1/filters-diffuse-01-f-expected.checksum:
- platform/chromium-linux/svg/W3C-SVG-1.1/filters-diffuse-01-f-expected.png:
- platform/chromium-linux/svg/W3C-SVG-1.1/filters-light-01-f-expected.checksum:
- platform/chromium-linux/svg/W3C-SVG-1.1/filters-light-01-f-expected.png:
- platform/chromium-linux/svg/W3C-SVG-1.1/filters-specular-01-f-expected.checksum:
- platform/chromium-linux/svg/W3C-SVG-1.1/filters-specular-01-f-expected.png:
- platform/chromium-linux/svg/custom/svg-fonts-with-no-element-reference-expected.checksum: Added.
- platform/chromium-mac/fast/forms/placeholder-stripped-expected.checksum: Added.
- platform/chromium-mac/svg/W3C-SVG-1.1/filters-diffuse-01-f-expected.checksum: Added.
- platform/chromium-mac/svg/W3C-SVG-1.1/filters-diffuse-01-f-expected.png: Added.
- platform/chromium-mac/svg/W3C-SVG-1.1/filters-light-01-f-expected.checksum: Added.
- platform/chromium-mac/svg/W3C-SVG-1.1/filters-light-01-f-expected.png: Added.
- platform/chromium-mac/svg/W3C-SVG-1.1/filters-specular-01-f-expected.checksum: Added.
- platform/chromium-mac/svg/W3C-SVG-1.1/filters-specular-01-f-expected.png: Added.
- platform/chromium-win/fast/forms/placeholder-stripped-expected.checksum: Added.
- platform/chromium-win/fast/forms/placeholder-stripped-expected.png: Added.
- platform/chromium-win/fast/forms/placeholder-stripped-expected.txt: Added.
- platform/chromium-win/svg/W3C-SVG-1.1/filters-diffuse-01-f-expected.checksum:
- platform/chromium-win/svg/W3C-SVG-1.1/filters-diffuse-01-f-expected.png:
- platform/chromium-win/svg/W3C-SVG-1.1/filters-light-01-f-expected.checksum:
- platform/chromium-win/svg/W3C-SVG-1.1/filters-light-01-f-expected.png:
- platform/chromium-win/svg/W3C-SVG-1.1/filters-specular-01-f-expected.checksum:
- platform/chromium-win/svg/W3C-SVG-1.1/filters-specular-01-f-expected.png:
- platform/chromium-win/svg/custom/svg-fonts-with-no-element-reference-expected.checksum: Added.
- platform/chromium-win/svg/custom/svg-fonts-with-no-element-reference-expected.png: Added.
- platform/chromium/test_expectations.txt:
- 2:18 PM Changeset in webkit [59268] by
-
- 2 edits8 adds in trunk/LayoutTests
2010-05-12 Adam Langley <agl@chromium.org>
Expectations change. Unreviewed.
Add baselines for fast/css/font-face-woff.html.
- platform/chromium-linux/fast/css/font-face-woff-expected.checksum: Added.
- platform/chromium-linux/fast/css/font-face-woff-expected.png: Added.
- platform/chromium-mac/fast/css/font-face-woff-expected.checksum: Added.
- platform/chromium-mac/fast/css/font-face-woff-expected.png: Added.
- platform/chromium-mac/fast/css/font-face-woff-expected.txt: Added.
- platform/chromium-win/fast/css/font-face-woff-expected.checksum: Added.
- platform/chromium-win/fast/css/font-face-woff-expected.png: Added.
- platform/chromium-win/fast/css/font-face-woff-expected.txt: Added.
- 2:08 PM Changeset in webkit [59267] by
-
- 2 edits in trunk/WebCore
Do not check if a database needs to be vacuumed after a read-only transaction.
https://bugs.webkit.org/show_bug.cgi?id=38972
Reviewed by Dimitri Glazkov.
- storage/SQLTransaction.cpp:
(WebCore::SQLTransaction::postflightAndCommit):
- 2:04 PM Changeset in webkit [59266] by
-
- 2 edits in trunk
[Qt] Link error in debug mode without debug_and_release config
https://bugs.webkit.org/show_bug.cgi?id=39006
Reviewed by Kenneth Rohde Christiansen.
- WebKit.pri: Unnecessary build_pass guard removed.
- 1:57 PM Changeset in webkit [59265] by
-
- 4 edits1 add in trunk/BugsSite
Adds support for Rietveld reviews. When there is an associated
Rietveld id for a patch, adds a link to do a Rietveld review instead.
Reviewed by David Kilzer.
https://bugs.webkit.org/show_bug.cgi?id=38143
- attachment.cgi:
Added support for handling action=rietveldreview.
- template/en/custom/attachment/list.html.tmpl:
Adds a link to use rietveld review iff the in_rietveld flag is set.
- template/en/custom/attachment/reviewform.html.tmpl:
Detects if we are in rietveld review mode due to query string paramter,
and customizes the review form slightly:
- Changes text describing comment field.
- Comment field does not include quoted patch.
- Submit button fetches from Rietveld instead of just submitting.
- template/en/custom/attachment/rietveldreview.html.tmpl: Added.
New template for rietveldreview mode. Hosts the rietveld frame in the
top and the regular comments form in the bottom.
Uses postMessage to communicate with Rietveld frame.
- 1:56 PM Changeset in webkit [59264] by
-
- 9 edits in trunk
[Qt] Detect debug mode consistently
https://bugs.webkit.org/show_bug.cgi?id=38863
Patch by Laszlo Gombos <Laszlo Gombos> on 2010-05-12
Reviewed by Kenneth Rohde Christiansen.
.:
- WebKit.pri:
- JavaScriptCore.pri:
- JavaScriptCore.pro:
- jsc.pro:
- qt/api/QtScript.pro:
WebCore:
No new tests as there is no new functionality.
- WebCore.pro:
- 1:51 PM Changeset in webkit [59263] by
-
- 2 edits1 add in trunk/WebCore
2010-05-12 James Robinson <jamesr@chromium.org>
Patch by Dan Bernstein.
Reviewed by David Hyatt.
Fix marking the layout root's parent as needing layout
https://bugs.webkit.org/show_bug.cgi?id=37760
If an element gets marked as needing layout due to the recalcStyle()
call in FrameView::layout(), the m_layoutSchedulingEnabled flag will
be set to false. It's possible at this point that a parent of the
existing FrameView::m_layoutRoot will be marked as needing layout.
This patch updates FrameView::scheduleRelayoutOfSubtree to account
for this case.
Manual test only due to subtle timing issues.
- manual-tests/layoutroot_detach.xml: Added.
- page/FrameView.cpp: (WebCore::FrameView::scheduleRelayoutOfSubtree):
- 1:50 PM Changeset in webkit [59262] by
-
- 2 edits in trunk/LayoutTests
2010-05-12 Martin Robinson <mrobinson@igalia.com>
Not reviewed.
[GTK] svg/custom/svg-fonts-with-no-element-reference.html is one pixel different on x86_64
https://bugs.webkit.org/show_bug.cgi?id=39022
Skipping failing tests for GTK+.
- platform/gtk/Skipped:
- 1:32 PM Changeset in webkit [59261] by
-
- 2 edits in trunk/WebKitTools
[Qt] Slave losts cause build break on bots
https://bugs.webkit.org/show_bug.cgi?id=38980
Reviewed by Kenneth Rohde Christiansen.
- Scripts/build-webkit: Remove 0 byte sized files from productDir before build.
- 1:24 PM Changeset in webkit [59260] by
-
- 4 edits in branches/audio/WebCore/audio
Add noteGrainOn() to AudioBufferSourceNode
- this is a temporary name to get us going until final names determined
- 1:24 PM Changeset in webkit [59259] by
-
- 2 edits in branches/audio/WebCore
Add AudioPannerNode to DOMWindow so we can have panner constants
- 1:24 PM Changeset in webkit [59258] by
-
- 1 edit in branches/audio/WebCore/audio/EqualPowerPanner.cpp
Fix EqualPowerPanner to always process the correct number of frames
- 1:24 PM Changeset in webkit [59257] by
-
- 1 edit in branches/audio/.gitignore
Update .gitignore to ignore a gyp-generated file
- 1:10 PM Changeset in webkit [59256] by
-
- 8 edits2 deletes in trunk
2010-05-12 Eric Seidel <eric@webkit.org>
Unreviewed, rolling out r59245.
http://trac.webkit.org/changeset/59245
https://bugs.webkit.org/show_bug.cgi?id=38874
Broke at least one test on multiple platforms
- editing/deleting/delete-block-contents-004-expected.txt: Removed.
- editing/deleting/delete-block-contents-004.html: Removed.
- editing/deleting/in-visibly-empty-root-expected.txt:
- platform/mac/editing/deleting/5408255-expected.txt:
- platform/mac/editing/deleting/delete-select-all-001-expected.txt:
- platform/mac/editing/selection/4895428-1-expected.txt:
- platform/mac/editing/selection/4895428-4-expected.txt:
2010-05-12 Eric Seidel <eric@webkit.org>
Unreviewed, rolling out r59245.
http://trac.webkit.org/changeset/59245
https://bugs.webkit.org/show_bug.cgi?id=38874
Broke at least one test on multiple platforms
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::removeChild):
- 1:08 PM Changeset in webkit [59255] by
-
- 2 edits in trunk/WebKitTools
Unreviewed trivial fix after r59254.
- Scripts/old-run-webkit-tests:
- 1:01 PM Changeset in webkit [59254] by
-
- 2 edits in trunk/WebKitTools
run-webkit-tests --exit-after-N-failures should not count new tests as failures
https://bugs.webkit.org/show_bug.cgi?id=31829
Reviewed by Eric Seidel.
- Scripts/old-run-webkit-tests:
- 12:48 PM Changeset in webkit [59253] by
-
- 3 edits in trunk/LayoutTests
2010-05-12 Martin Robinson <mrobinson@igalia.com>
Not reviewed. Try number 3 to properly add new baselines and remove remaining
merge marker from this file.
- platform/gtk/fast/css/input-search-padding-expected.txt:
- platform/gtk/svg/custom/svg-fonts-with-no-element-reference-expected.txt:
- 12:41 PM Changeset in webkit [59252] by
-
- 1 edit in trunk/LayoutTests/ChangeLog
Fix LayoutTest/ChangeLog bad merge
- 12:36 PM Changeset in webkit [59251] by
-
- 3 edits in trunk/LayoutTests
2010-04-29 James Robinson <jamesr@chromium.org>
Reviewed by Simon Fraser.
Test that when a frame with fixed position elements is scrolled via the
keyboard that the correct repaints happen.
https://bugs.webkit.org/show_bug.cgi?id=38286
- fast/repaint/fixed-move-after-keyboard-scroll.html: Added.
- fast/repaint/resources/fixed-move-after-keyboard-scroll-iframe.html: Added.
- platform/chromium/test_expectations.txt:
- platform/mac/fast/repaint/fixed-move-after-keyboard-scroll-expected.checksum: Added.
- platform/mac/fast/repaint/fixed-move-after-keyboard-scroll-expected.png: Added.
- platform/mac/fast/repaint/fixed-move-after-keyboard-scroll-expected.txt: Added.
- 12:19 PM Changeset in webkit [59250] by
-
- 3 edits3 adds in trunk
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=38752
Strange behaviour after js insertion into a page pointing directly to an object (image, swf, etc)
Test: fast/images/extra-image-in-image-document.html
- loader/ImageLoader.cpp: (WebCore::ImageLoader::updateFromElement): Reset setAutoLoadImages after manually feeding an image - there may be more coming.
- 12:12 PM Changeset in webkit [59249] by
-
- 5 edits2 adds in trunk/LayoutTests
2010-05-12 Martin Robinson <Martin Robinson>
Not reviewed. Trying once more to generate baselines for GTK+.
- platform/gtk/fast/css/input-search-padding-expected.txt:
- platform/gtk/fast/forms/placeholder-stripped-expected.txt:
- platform/gtk/fast/frames/take-focus-from-iframe-expected.txt:
- platform/gtk/fast/images/svg-background-partial-redraw-expected.txt: Added.
- platform/gtk/fast/repaint/fixed-move-after-keyboard-scroll-expected.txt:
- platform/gtk/svg/custom/repaint-stroke-width-changes-expected.txt: Copied from LayoutTests/platform/mac/svg/custom/repaint-stroke-width-changes-expected.txt.
- 12:09 PM Changeset in webkit [59248] by
-
- 3 edits in trunk/WebCore
HTMLLabelElement::control() should return HTMLFormControlElement, not HTMLElement
https://bugs.webkit.org/show_bug.cgi?id=38991
Reviewed by Dan Bernstein.
No new tests since no new functionality was introduced.
- html/HTMLLabelElement.cpp:
(WebCore::HTMLLabelElement::control):
- html/HTMLLabelElement.h:
- 12:03 PM Changeset in webkit [59247] by
-
- 2 edits in trunk/WebCore
https://bugs.webkit.org/show_bug.cgi?id=38891
Reviewed by Darin Adler.
First-letter had a number of bugs that were exposed by my attempt to optimize the setting of styles when updating first-letter.
The code that drills down to find the first-letter child stopped if it hit an element that didn't need layout. This means it could
return random incorrect results (and cause the first-letter object to not be found).
In addition when the first-letter was floated/positioned, the text child was not correctly returned, but the container itself was
returned instead.
Finally, the updating code was leaving the box that wrapped the first letter text with a stale style. The old code happened to work because
it made new styles for the text elements instead of using the enclosing box style. The regression was caused by my change to make the
text children simply share style with their parent (thus making the bug that the parent had the wrong style become more prominent).
No new tests, since there's a timing component to reproducing the issue.
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::updateFirstLetter):
- 11:30 AM Changeset in webkit [59246] by
-
- 2 edits in trunk/WebKitTools
2010-05-12 James Robinson <jamesr@chromium.org>
Reviewed by Simon Fraser.
Disable smooth scrolling on OS X when running tests
https://bugs.webkit.org/show_bug.cgi?id=38964
Some tests (like fast/repaint/fixed-move-after-keyboard-scroll.html)
depend on smooth scrolling behavior. Since this is off by default
in Leopard and on by default in Snow Leopard, DRT should turn it
off always to ensure a consistent test environment.
- DumpRenderTree/mac/DumpRenderTree.mm: (resetDefaultsToConsistentValues):
- 11:29 AM Changeset in webkit [59245] by
-
- 8 edits2 adds in trunk
Adding block elements to a block and removing them changes the height of the element.
https://bugs.webkit.org/show_bug.cgi?id=38874
Reviewed by Dave Hyatt.
WebCore:
The initial height of an empty editable block is different from the height of the same block after we add block elements
and remove them.
Test: editing/deleting/delete-block-contents-004.html
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::removeChild): m_childrenInline was set to true only when the Renderer is created
and never reset to true when all the block elements contained are removed.
LayoutTests:
- editing/deleting/delete-block-contents-004-expected.txt: Added.
- editing/deleting/delete-block-contents-004.html: Added.
The following tests have new results because of the height change and because we now have one less renderer after the DOM changes.
- editing/deleting/in-visibly-empty-root-expected.txt:
- platform/mac/editing/deleting/5408255-expected.txt:
- platform/mac/editing/deleting/delete-select-all-001-expected.txt:
- platform/mac/editing/selection/4895428-1-expected.txt:
- platform/mac/editing/selection/4895428-4-expected.txt:
- 11:26 AM Changeset in webkit [59244] by
-
- 1 edit22 adds in trunk/LayoutTests
2010-05-12 Martin Robinson <mrobinson@igalia.com>
Not reviewed. Added baselines to these tests which are passing interactively.
- platform/gtk/fast/css-generated-content/after-duplicated-after-split-expected.txt: Added.
- platform/gtk/fast/css/input-search-padding-expected.txt: Added.
- platform/gtk/fast/forms/placeholder-stripped-expected.txt: Added.
- platform/gtk/fast/frames/take-focus-from-iframe-expected.txt: Added.
- platform/gtk/fast/repaint/fixed-child-move-after-scroll-expected.txt: Added.
- platform/gtk/fast/repaint/fixed-child-of-fixed-move-after-scroll-expected.txt: Added.
- platform/gtk/fast/repaint/fixed-child-of-transformed-move-after-scroll-expected.txt: Added.
- platform/gtk/fast/repaint/fixed-move-after-keyboard-scroll-expected.txt: Added.
- platform/gtk/fast/repaint/fixed-move-after-scroll-expected.txt: Added.
- platform/gtk/fast/repaint/fixed-tranformed-expected.txt: Added.
- platform/gtk/fast/text/format-control-expected.txt: Added.
- platform/gtk/fast/text/international/bold-bengali-expected.txt: Added.
- platform/gtk/svg/custom/svg-fonts-with-no-element-reference-expected.txt: Copied from LayoutTests/platform/mac/svg/custom/svg-fonts-with-no-element-reference-expected.txt.
- platform/gtk/svg/text/text-hkern-expected.txt: Copied from LayoutTests/platform/mac/svg/text/text-hkern-expected.txt.
- platform/gtk/svg/text/text-hkern-on-vertical-text-expected.txt: Copied from LayoutTests/platform/mac/svg/text/text-hkern-on-vertical-text-expected.txt.
- platform/gtk/svg/text/text-vkern-expected.txt: Copied from LayoutTests/platform/mac/svg/text/text-vkern-expected.txt.
- platform/gtk/svg/text/text-vkern-on-horizontal-text-expected.txt: Copied from LayoutTests/platform/mac/svg/text/text-vkern-on-horizontal-text-expected.txt.
- platform/gtk/transforms/svg-vs-css-expected.txt: Added.
- 11:24 AM Changeset in webkit [59243] by
-
- 13 edits4 adds in trunk
2010-05-12 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: disabling style property on container breaks styles inspection for given node.
Tests: inspector/styles-disable-inherited.html
inspector/styles-disable-then-enable.html
- inspector/front-end/StylesSidebarPane.js: (WebInspector.StylesSidebarPane.prototype._containsInherited): (WebInspector.StylesSidebarPane.prototype._arrayContainsInheritedProperty):
- 11:15 AM Changeset in webkit [59242] by
-
- 1 edit in trunk/WebCore/ChangeLog
HTML Entity Escape the contents of a textarea node when accessed
via the innerHTML and outerHTML node properties.
https://bugs.webkit.org/show_bug.cgi?id=38922
Patch by Abhishek Arya <inferno@chromium.org> on 2010-05-12
Reviewed by Darin Adler.
Test: fast/innerHTML/innerHTML-special-elements.html
- editing/markup.cpp:
(WebCore::appendStartMarkup):
- 11:13 AM Changeset in webkit [59241] by
-
- 5 edits2 adds in trunk
2010-05-12 Abhishek Arya <inferno@chromium.org>
Reviewed by Darin Adler.
HTML Entity Escape the contents of a textarea node when accessed via the innerHTML and outerHTML node properties.
https://bugs.webkit.org/show_bug.cgi?id=38922
Test: fast/encoding/textnode-XSS.html
- editing/markup.cpp: (WebCore::appendStartMarkup):
2010-05-12 Abhishek Arya <inferno@chromium.org>
Reviewed by Darin Adler.
Tests that accessing the innerHTML property of a text node encodes
entities properly. Update existing test to fix the innerHTML result.
https://bugs.webkit.org/show_bug.cgi?id=38922
- fast/innerHTML/innerHTML-special-elements-expected.txt: Added.
- fast/innerHTML/innerHTML-special-elements.html: Added.
- fast/parser/comment-in-textarea-expected.txt: Update test expectation.
- fast/parser/script-tests/comment-in-textarea.js: Update test by replacing with html entities of <, > chars in textarea innerHTML result.
- 10:11 AM Changeset in webkit [59240] by
-
- 6 edits in trunk/WebKit/gtk
2010-05-12 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[Gtk] Use GOwnPtr for code that needs it
https://bugs.webkit.org/show_bug.cgi?id=21594
Convert many uses of raw pointers to GRefPtr and GOwnPtr in WebKitWebView.
- WebCoreSupport/ContextMenuClientGtk.cpp: (WebKit::inputMethodsMenuItem):
- WebCoreSupport/EditorClientGtk.cpp: (WebKit::EditorClient::setInputMethodState): (WebKit::EditorClient::respondToChangedSelection): (WebKit::EditorClient::handleInputMethodKeydown): (WebKit::EditorClient::EditorClient): (WebKit::EditorClient::~EditorClient):
- WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::postCommitFrameViewSetup):
- webkit/webkitprivate.h:
- webkit/webkitwebview.cpp: (destroy_menu_cb): (webkit_web_view_forward_context_menu_event): (webkit_web_view_key_release_event): (webkit_web_view_button_release_event): (webkit_web_view_focus_in_event): (webkit_web_view_focus_out_event): (webkit_web_view_realize): (webkit_web_view_set_scroll_adjustments): (webkit_web_view_dispose): (webkit_web_view_finalize): (webViewGetDPI): (webkit_web_view_screen_changed): (webkit_web_view_query_tooltip): (webkit_web_view_get_im_context): (webkit_web_view_update_settings): (webkit_web_view_init): (webkit_web_view_set_settings): (webkit_web_view_get_settings): (webkit_web_view_get_inspector): (webkit_web_view_set_window_features): (webkit_web_view_get_window_features): (webkit_web_view_get_back_forward_list): (webkit_web_view_zoom_in): (webkit_web_view_zoom_out): (webkit_web_view_get_encoding): (webkit_web_view_get_custom_encoding): (webkit_web_view_add_resource): (webkit_web_view_get_resource): (webkit_web_view_get_main_resource): (webkit_web_view_clear_resources): (webkit_web_view_get_subresources): (webkit_web_view_set_tooltip_text): (webkit_web_view_get_icon_uri):
- 9:52 AM Changeset in webkit [59239] by
-
- 5 edits in trunk/WebCore
Fix for https://bugs.webkit.org/show_bug.cgi?id=38871 REGRESSION:
Crash clicking background NPR tab after few minutes of sitting idle
-and corresponding-
<rdar://problem/7941504>
Reviewed by Darin Adler.
Move m_mediaCanStartListeners HashSet to Document away from Page.
- dom/Document.cpp:
(WebCore::Document::Document):
(WebCore::Document::addMediaCanStartListener):
(WebCore::Document::removeMediaCanStartListener):
(WebCore::Document::takeAnyMediaCanStartListener):
- dom/Document.h:
- page/Page.cpp:
(WebCore::Page::takeAnyMediaCanStartListener):
- page/Page.h:
(WebCore::Page::canStartMedia):
- 9:44 AM Changeset in webkit [59238] by
-
- 5 edits in trunk/WebKit/chromium
2010-05-12 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Steve Block.
[Chromium] Pass the origin parameter for WebIndexedDatabase::open
https://bugs.webkit.org/show_bug.cgi?id=38983
- public/WebIndexedDatabase.h:
- src/IndexedDatabaseProxy.cpp: (WebCore::IndexedDatabaseProxy::open):
- src/WebIndexedDatabaseImpl.cpp: (WebKit::WebIndexedDatabaseImpl::open):
- src/WebIndexedDatabaseImpl.h:
- 9:10 AM Changeset in webkit [59237] by
-
- 11 edits in trunk
2010-05-11 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Pavel Feldman.
WebInspector: Sometimes ResourceRequest records aren't connected to the initiator.
https://bugs.webkit.org/show_bug.cgi?id=38925
- inspector/InspectorTimelineAgent.cpp: (WebCore::InspectorTimelineAgent::didScheduleResourceRequest):
- inspector/InspectorTimelineAgent.h: (WebCore::):
- inspector/TimelineRecordFactory.cpp: (WebCore::TimelineRecordFactory::createScheduleResourceRequestData):
- inspector/TimelineRecordFactory.h:
- inspector/front-end/TimelineAgent.js:
- inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel): (WebInspector.TimelinePanel.prototype.get _recordStyles): (WebInspector.TimelinePanel.prototype._findParentRecord): (WebInspector.TimelinePanel.prototype._innerAddRecordToTimeline): (WebInspector.TimelinePanel.prototype._clearPanel): (WebInspector.TimelinePanel.FormattedRecord): (WebInspector.TimelinePanel.FormattedRecord.prototype._generatePopupContent): (WebInspector.TimelinePanel.FormattedRecord.prototype._getRecordDetails):
- loader/loader.cpp: (WebCore::Loader::load):
2010-05-11 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Pavel Feldman.
WebInspector: Sometimes ResourceRequest records aren't connected to the initiator.
https://bugs.webkit.org/show_bug.cgi?id=38925
- inspector/timeline-enum-stability-expected.txt:
- 8:57 AM Changeset in webkit [59236] by
-
- 7 edits4 adds in trunk
2010-05-12 Kent Tamura <tkent@chromium.org>
Reviewed by Darin Adler.
placeholder text should be stripped from line breaks
https://bugs.webkit.org/show_bug.cgi?id=36291
Add a test for placeholder values with CR and LF.
- fast/forms/placeholder-stripped.html: Added.
- platform/mac/fast/forms/placeholder-stripped-expected.checksum: Added.
- platform/mac/fast/forms/placeholder-stripped-expected.png: Added.
- platform/mac/fast/forms/placeholder-stripped-expected.txt: Added.
2010-05-12 Kent Tamura <tkent@chromium.org>
Reviewed by Darin Adler.
placeholder text should be stripped from line breaks
https://bugs.webkit.org/show_bug.cgi?id=36291
According to http://dev.w3.org/html5/spec/forms.html#attr-input-placeholder ,
we need to remove CR and LF from the placeholder attribute values.
Introduce HTMLTextFormControlElement::strippedPlaceholder(), which
returns stripped value, and replace getAttribute(placeholderAttr) with it.
Test: fast/forms/placeholder-stripped.html
- html/HTMLFormControlElement.cpp: (WebCore::HTMLTextFormControlElement::strippedPlaceholder): (WebCore::HTMLTextFormControlElement::isPlaceholderEmpty): (WebCore::HTMLTextFormControlElement::placeholderShouldBeVisible): Use strippedPlaceholder().
- html/HTMLFormControlElement.h:
- platform/text/CharacterNames.h: Add carriageReturn.
- rendering/RenderTextControlMultiLine.cpp: (WebCore::RenderTextControlMultiLine::updateFromElement): Use strippedPlaceholder().
- rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::updateFromElement): Use strippedPlaceholder().
- 8:26 AM Changeset in webkit [59235] by
-
- 5 edits in trunk
Allows build-webkit script to receive an install prefix as parameter https://bugs.webkit.org/show_bug.cgi?id=26224
Reviewed by Kenneth Christiansen , Simon Hausmann and Gustavo Noronha.
Patch by Rodrigo Belem <rodrigo.belem@openbossa.org>
WebCore:
This patch adds the ability, in the QtWebkit build system, to change
the installation path.
- WebCore.pro:
WebKitTools:
Added more parameters to build-webkit script, the --prefix for gkt
and --install-libs, --install-headers for qt. Now it is possible
to change the install prefix for gtk and install path for qt.
- Scripts/build-webkit:
- Scripts/webkitdirs.pm:
- 8:05 AM Changeset in webkit [59234] by
-
- 2 edits in trunk/WebKit/qt
2010-05-12 Antonio Gomes <tonikitoo@webkit.org>
Reviewed by Kenneth Christiansen.
[Qt] Remove the unneeded check for QWidgetPageClient @QGraphicsWebView::detachCurrentPage
https://bugs.webkit.org/show_bug.cgi?id=38989
Reasons:
- There is no need to check for a QWidgetPageClient-based in QGraphicsWebView.
- The client has always to be deleted anyways.
- Api/qgraphicswebview.cpp: (QGraphicsWebViewPrivate::detachPage):
- 8:04 AM Changeset in webkit [59233] by
-
- 3 edits in trunk/WebKit/qt
[Qt] Implement a detachCurrentPage method for QGraphicsWebView and QWebView
https://bugs.webkit.org/show_bug.cgi?id=38939
Reviewed by Kenneth Christiansen.
Patch by Antonio Gomes <tonikitoo@webkit.org>
unsetPageIfExists method was renamed to detachCurrentPage method and is now responsible
for doing all the unset logic of page and pageClient references previously done by
the Q{Graphics}WebView destructor(s).
It is a code clean up, no behaviour change.
- Api/qgraphicswebview.cpp:
(QGraphicsWebViewPrivate::~QGraphicsWebViewPrivate):
(QGraphicsWebView::~QGraphicsWebView):
(QGraphicsWebViewPrivate::detachCurrentPage):
(QGraphicsWebView::setPage):
- Api/qwebview.cpp:
(QWebViewPrivate::~QWebViewPrivate):
(QWebView::~QWebView):
(QWebViewPrivate::detachCurrentPage):
(QWebView::setPage):
- 7:35 AM Changeset in webkit [59232] by
-
- 10 edits in trunk
2010-05-12 Jer Noble <jer.noble@apple.com>
Reviewed by Darin Adler.
Bug 38689: #34005 will break fullscreen video playback
https://bugs.webkit.org/show_bug.cgi?id=38689
Use the new definition of PlatformMedia to check the actual type
returned by MediaPlayer.
- FullscreenVideoController.cpp: (FullscreenVideoController::movie):
2010-05-12 Jer Noble <jer.noble@apple.com>
Reviewed by Darin Adler.
Bug 38689: #34005 will break fullscreen video playback
https://bugs.webkit.org/show_bug.cgi?id=38689
Use the new definition of PlatformMedia to check the actual type
returned by MediaPlayer.
- WebView/WebVideoFullscreenController.mm: (-[WebVideoFullscreenController windowDidLoad]):
2010-05-12 Jer Noble <jer.noble@apple.com>
Reviewed by Darin Adler.
Bug 38689: #34005 will break fullscreen video playback
https://bugs.webkit.org/show_bug.cgi?id=38689
The PlatformMedia struct now contains a type field indicating which type
it contains. The struct now contains a union of all possible return types,
allowing the type of media returned by MediaPlayerPrivate instances to be
determined at runtime.
- platform/graphics/MediaPlayer.h: (WebCore::PlatformMedia::): (WebCore::):
- platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::platformMedia):
- platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp: (WebCore::MediaPlayerPrivateQuickTimeVisualContext::platformMedia):
- platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp: (WebCore::MediaPlayerPrivate::platformMedia):
- 7:22 AM Changeset in webkit [59231] by
-
- 2 edits in trunk/WebKit/qt
Add a comment to explain the web inspector dynamic property url hook
and that it's there on purpose :)
Reviewed by Laszlo Gombos.
https://bugs.webkit.org/show_bug.cgi?id=35340
- WebCoreSupport/InspectorClientQt.cpp:
(WebCore::InspectorClientQt::openInspectorFrontend):
- 6:52 AM Changeset in webkit [59230] by
-
- 4 edits in trunk/WebCore
2010-05-12 Young Han Lee <joybro@company100.net>
Reviewed by Darin Adler.
Add missing ENABLE(SVG) guards.
https://bugs.webkit.org/show_bug.cgi?id=38892
- rendering/RenderSVGResourceClipper.cpp:
- rendering/RenderSVGResourceMarker.cpp:
- rendering/RenderSVGResourceMasker.cpp:
- 6:08 AM Changeset in webkit [59229] by
-
- 3 edits in trunk/WebCore
2010-05-12 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: align sidebar checkboxes on windows.
- inspector/front-end/StylesSidebarPane.js:
- inspector/front-end/inspector.css: (.sidebar-pane-subtitle): (body.platform-windows .sidebar-pane-subtitle):
- 6:05 AM Changeset in webkit [59228] by
-
- 2 edits in trunk/WebKitTools
2010-05-12 Philippe Normand <pnormand@igalia.com>
Unreviewed, added my IRC nickname.
- Scripts/webkitpy/common/config/committers.py:
- 6:02 AM Changeset in webkit [59227] by
-
- 10 edits10 adds in trunk
Support control attribute of HTMLLabelElement
https://bugs.webkit.org/show_bug.cgi?id=38688
Reviewed by Darin Adler.
WebCore:
Added support for the control attribute of HTMLLabelElement and changed the logic of determining
which control is associated with the label to conform to HTML5 spec.
Added a manual test for testing the logic of selecting the control to get focused, activated or hovered
when the label gets focused, activated or is hovered.
Test: fast/dom/HTMLLabelElement/click-label.html
Test: fast/dom/HTMLLabelElement/focus-label.html
Test: fast/dom/HTMLLabelElement/label-control.html
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::labelForElement):
(WebCore::AccessibilityRenderObject::correspondingControlForLabelElement):
- html/HTMLFormControlElement.cpp:
(WebCore::HTMLFormControlElement::isLabelable):
- html/HTMLFormControlElement.h:
- html/HTMLLabelElement.cpp:
(WebCore::nodeAsLabelableFormControl):
(WebCore::HTMLLabelElement::control):
(WebCore::HTMLLabelElement::setActive):
(WebCore::HTMLLabelElement::setHovered):
(WebCore::HTMLLabelElement::defaultEventHandler):
(WebCore::HTMLLabelElement::focus):
(WebCore::HTMLLabelElement::accessKeyAction):
- html/HTMLLabelElement.h:
- html/HTMLLabelElement.idl:
- manual-tests/dom/form-control-for-label.html: Added.
WebKit/chromium:
Renamed HTMLLabelElement::correspondingControl to HTMLLabelElement::control
- src/WebLabelElement.cpp:
(WebKit::WebLabelElement::correspondingControl):
LayoutTests:
- fast/dom/HTMLLabelElement/click-label-expected.txt: Added.
- fast/dom/HTMLLabelElement/click-label.html: Added.
- fast/dom/HTMLLabelElement/focus-label-expected.txt: Added.
- fast/dom/HTMLLabelElement/focus-label.html: Added.
- fast/dom/HTMLLabelElement/label-control-expected.txt: Added.
- fast/dom/HTMLLabelElement/label-control.html: Added.
- fast/dom/HTMLLabelElement/script-tests: Added.
- fast/dom/HTMLLabelElement/script-tests/TEMPLATE.html: Added.
- fast/dom/HTMLLabelElement/script-tests/label-control.js: Added.
- 5:51 AM Changeset in webkit [59226] by
-
- 3 edits in trunk/WebCore
2010-05-12 Steve Block <steveblock@google.com>
Reviewed by David Levin.
Android's writeToFile() is buggy
https://bugs.webkit.org/show_bug.cgi?id=38908
No new tests, build fix only.
- platform/android/FileSystemAndroid.cpp: Remove Android's version of writeToFile().
- platform/posix/FileSystemPOSIX.cpp: Use POSIX version of writeToFile() on Android. (WebCore::writeToFile):
- 5:21 AM Changeset in webkit [59225] by
-
- 2 edits in trunk/LayoutTests
Unreviewed.
Other tests make http/tests/xmlhttprequest/null-auth.php fail
https://bugs.webkit.org/show_bug.cgi?id=32961
http/tests/xmlhttprequest/basic-auth-default.html introduced in r59185,
and it made http/tests/xmlhttprequest/null-auth.php fail on Qt bot, as
http/tests/xmlhttprequest/failed-auth.html did it before.
- platform/qt/Skipped: http/tests/xmlhttprequest/basic-auth-default.html skipped until fix.
- 5:11 AM Changeset in webkit [59224] by
-
- 2 edits in trunk/WebCore
2010-05-10 Philippe Normand <pnormand@igalia.com>
Reviewed by David Levin.
[GStreamer] incoherent #ifdef in GOwnPtrGStreamer.h
https://bugs.webkit.org/show_bug.cgi?id=38839
Fixed #ifdef/curly braces coherence.
- platform/graphics/gstreamer/GOwnPtrGStreamer.cpp: (WTF::GstElement):
- 5:07 AM Changeset in webkit [59223] by
-
- 2 edits in trunk/WebCore
2010-05-10 Philippe Normand <pnormand@igalia.com>
Reviewed by Dirk Schulze.
[GStreamer] un-needed cairo.h include
https://bugs.webkit.org/show_bug.cgi?id=38837
Cairo not used in the sink anymore. So it's not needed to include
the header.
- platform/graphics/gstreamer/VideoSinkGStreamer.h:
- 4:49 AM Changeset in webkit [59222] by
-
- 2 edits in trunk/JavaScriptCore
2010-05-12 Peter Varga <pvarga@inf.u-szeged.hu>
Reviewed by Gavin Barraclough.
Remove a direct jump in generatePatternCharacterGreedy() and
generatePatternCharacterClassGreedy() functions if quantityCount of the term
is unlimited.
https://bugs.webkit.org/show_bug.cgi?id=38898
- yarr/RegexJIT.cpp: (JSC::Yarr::RegexGenerator::generatePatternCharacterGreedy): (JSC::Yarr::RegexGenerator::generateCharacterClassGreedy):
- 3:58 AM Changeset in webkit [59221] by
-
- 4 edits in trunk/WebCore
Build fix for Windows and Chromium builds.
Reviewed by Nikolas Zimmermann.
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- svg/graphics/filters/SVGFELighting.cpp:
(WebCore::FELighting::LightingData::upLeftPixelValue):
(WebCore::FELighting::LightingData::upPixelValue):
(WebCore::FELighting::LightingData::upRightPixelValue):
(WebCore::FELighting::LightingData::leftPixelValue):
(WebCore::FELighting::LightingData::centerPixelValue):
(WebCore::FELighting::LightingData::rightPixelValue):
(WebCore::FELighting::LightingData::downLeftPixelValue):
(WebCore::FELighting::LightingData::downPixelValue):
(WebCore::FELighting::LightingData::downRightPixelValue):
(WebCore::FELighting::setPixel):
- 3:18 AM Changeset in webkit [59220] by
-
- 23 edits2 adds in trunk
WebCore: Implementing SVG filters: feDiffuseLighting and feSpecularLighting
https://bugs.webkit.org/show_bug.cgi?id=32197
https://bugs.webkit.org/show_bug.cgi?id=32199
Reviewed by Nikolas Zimmermann.
The patch implements the SVG filters feDiffuseLighting and
feSpecularLighting including the impementation of their possible
light sources according to the Scalable Vector Graphics (SVG)
1.1 Specification. Only two features are missing: supporting images
with height or width set to 1, and kernelUnitLength other than (1,1).
Since the two lighting filters have a similar body, a common base
class called FELighting is introduced, and contains the code for
both filters. The implementation employs single precision floating
point arithmetic (fixed precision integer arithmetic seemed too difficult).
Indentation is removed of the modified header files in svg/graphics/filters
- GNUmakefile.am:
- WebCore.pro:
- WebCore.xcodeproj/project.pbxproj:
- platform/graphics/FloatPoint3D.cpp:
- platform/graphics/FloatPoint3D.h:
(WebCore::FloatPoint3D::FloatPoint3D): constructors changed to inline
(WebCore::operator*): dot product
- svg/SVGFESpotLightElement.cpp:
(WebCore::SVGFESpotLightElement::lightSource):
- svg/graphics/filters/SVGDistantLightSource.h:
(WebCore::DistantLightSource::create):
(WebCore::DistantLightSource::azimuth):
(WebCore::DistantLightSource::elevation):
(WebCore::DistantLightSource::DistantLightSource):
- svg/graphics/filters/SVGFEDiffuseLighting.cpp:
(WebCore::FEDiffuseLighting::FEDiffuseLighting):
(WebCore::FEDiffuseLighting::create):
- svg/graphics/filters/SVGFEDiffuseLighting.h:
- svg/graphics/filters/SVGFELighting.cpp: Added.
(WebCore::FELighting::FELighting):
(WebCore::FELighting::LightingData::upLeftPixelValue):
(WebCore::FELighting::LightingData::upPixelValue):
(WebCore::FELighting::LightingData::upRightPixelValue):
(WebCore::FELighting::LightingData::leftPixelValue):
(WebCore::FELighting::LightingData::centerPixelValue):
(WebCore::FELighting::LightingData::rightPixelValue):
(WebCore::FELighting::LightingData::downLeftPixelValue):
(WebCore::FELighting::LightingData::downPixelValue):
(WebCore::FELighting::LightingData::downRightPixelValue):
(WebCore::FELighting::setPixel):
(WebCore::FELighting::drawLighting):
(WebCore::FELighting::apply):
- svg/graphics/filters/SVGFELighting.h: Added.
(WebCore::FELighting::uniteChildEffectSubregions):
(WebCore::FELighting::):
- svg/graphics/filters/SVGFESpecularLighting.cpp:
(WebCore::FESpecularLighting::FESpecularLighting):
(WebCore::FESpecularLighting::create):
- svg/graphics/filters/SVGFESpecularLighting.h:
- svg/graphics/filters/SVGLightSource.cpp:
(WebCore::PointLightSource::initPaintingData):
(WebCore::PointLightSource::updatePaintingData):
(WebCore::SpotLightSource::initPaintingData):
(WebCore::SpotLightSource::updatePaintingData):
(WebCore::DistantLightSource::initPaintingData):
(WebCore::DistantLightSource::updatePaintingData):
- svg/graphics/filters/SVGLightSource.h:
(WebCore::):
(WebCore::LightSource::LightSource):
(WebCore::LightSource::~LightSource):
(WebCore::LightSource::type):
- svg/graphics/filters/SVGPointLightSource.h:
(WebCore::PointLightSource::create):
(WebCore::PointLightSource::position):
(WebCore::PointLightSource::PointLightSource):
- svg/graphics/filters/SVGSpotLightSource.h:
(WebCore::SpotLightSource::create):
(WebCore::SpotLightSource::position):
(WebCore::SpotLightSource::direction):
(WebCore::SpotLightSource::specularExponent):
(WebCore::SpotLightSource::limitingConeAngle):
(WebCore::SpotLightSource::SpotLightSource):
LayoutTests: Updating the pixel tests for feDiffuseLighting and feSpecularLighting
https://bugs.webkit.org/show_bug.cgi?id=32197
https://bugs.webkit.org/show_bug.cgi?id=32199
Reviewed by Nikolas Zimmermann.
No new test were added, since SVG expected values cover
the features of the implementation
- platform/mac/svg/W3C-SVG-1.1/filters-diffuse-01-f-expected.checksum:
- platform/mac/svg/W3C-SVG-1.1/filters-diffuse-01-f-expected.png:
- platform/mac/svg/W3C-SVG-1.1/filters-light-01-f-expected.checksum:
- platform/mac/svg/W3C-SVG-1.1/filters-light-01-f-expected.png:
- platform/mac/svg/W3C-SVG-1.1/filters-specular-01-f-expected.checksum:
- platform/mac/svg/W3C-SVG-1.1/filters-specular-01-f-expected.png:
- 2:35 AM Changeset in webkit [59219] by
-
- 2 edits in trunk/WebCore
2010-05-12 Xan Lopez <xlopez@igalia.com>
Reviewed by Nikolas Zimmermann.
Add missing AM_V_GEN directives to generation rules so that they
remain silent when requested.
- GNUmakefile.am:
- 2:12 AM Changeset in webkit [59218] by
-
- 2 edits in trunk/WebCore
2010-05-12 Lucas De Marchi <lucas.demarchi@profusion.mobi>
Reviewed by Jeremy Orlow.
[EFL] It does not make sense to use ScrollbarEfl::ScrollbarEfl, so
use ScrollbarEfl (GCC 4.5 seems to be pickier about this). Revision 59030
fixed cases for RenderThemeEfl, but missed this for ScrollbarEfl.
http://webkit.org/b/38904
No new tests required.
- platform/efl/ScrollbarEfl.cpp: (scrollbarEflEdjeMessage):
- 1:51 AM Changeset in webkit [59217] by
-
- 9 edits in trunk
2010-05-12 MORITA Hajime <morrita@google.com>
Reviewed by Kent Tamura.
[Chromium] Support HTML5 <progress> element on Windows.
https://bugs.webkit.org/show_bug.cgi?id=37308
Extended ChromiumBridge to handle progress bar painting,
and added delegations to it.
No new tests. Test cases should be shared with existing ones for
progress element. Expectaions will be added after PROGRESS_TAG is
enabled on Chromium tree.
- platform/chromium/ChromiumBridge.h:
- rendering/RenderProgress.cpp: (WebCore::RenderProgress::animationProgress): (WebCore::RenderProgress::isDeterminate):
- rendering/RenderProgress.h: (WebCore::RenderProgress::position):
- rendering/RenderThemeChromiumWin.cpp: (WebCore::RenderThemeChromiumWin::animationRepeatIntervalForProgressBar): (WebCore::RenderThemeChromiumWin::animationDurationForProgressBar): (WebCore::RenderThemeChromiumWin::adjustProgressBarStyle): (WebCore::RenderThemeChromiumWin::paintProgressBar):
- rendering/RenderThemeChromiumWin.h:
2010-05-12 MORITA Hajime <morrita@google.com>
Reviewed by Kent Tamura.
[Chromium] Support HTML5 <progress> element on Windows.
https://bugs.webkit.org/show_bug.cgi?id=37308
Extended ChromiumBridge to handle progress bar painting,
and added delegations to it.
No new tests. Test cases should be shared with existing ones for
progress element. Expectaions will be added after PROGRESS_TAG is
enabled on Chromium tree.
- public/WebThemeEngine.h: (WebKit::WebThemeEngine::paintProgressBar):
- src/ChromiumBridge.cpp: (WebCore::ChromiumBridge::paintProgressBar):
- 1:43 AM Changeset in webkit [59216] by
-
- 5 edits in trunk/WebCore
2010-05-12 Marcus Bulach <bulach@chromium.org>
Reviewed by Steve Block.
Removes Geolocation::setPosition and uses positionChanged() to capture lastPosition().
This brings CLIENT_BASED_GEOLOCATION more inline with the non-client based.
https://bugs.webkit.org/show_bug.cgi?id=38195
- page/Geolocation.cpp: (WebCore::Geolocation::lastPosition): (WebCore::Geolocation::requestPermission): (WebCore::Geolocation::positionChangedInternal): (WebCore::Geolocation::positionChanged): (WebCore::Geolocation::geolocationServicePositionChanged):
- page/Geolocation.h:
- page/GeolocationController.cpp: (WebCore::GeolocationController::positionChanged): (WebCore::GeolocationController::lastPosition):
- page/GeolocationController.h:
- 1:31 AM Changeset in webkit [59215] by
-
- 5 edits in trunk
2010-05-12 Marcus Bulach <bulach@chromium.org>
Reviewed by Steve Block.
Attaches the geolocation bridge later on startUpdating().
This prevents a page requesting permission when it has just accessed navigator.geolocation (without calling navigator.geolocation.getCurrentPosition/watchPosition).
Note: when Geolocation::haveSuitableCachedPosition(), WebGeolocationServiceBridgeImpl::startUpdating() is not called,
so we attach the bridge if needed at requestGeolocationPermissionForFrame().
https://bugs.webkit.org/show_bug.cgi?id=38323
http://crbug.com/42789
- platform/chromium/GeolocationServiceChromium.h:
2010-05-12 Marcus Bulach <bulach@chromium.org>
Reviewed by Steve Block.
Attaches the geolocation bridge later on startUpdating().
This prevents a page requesting permission when it has just accessed navigator.geolocation (without calling navigator.geolocation.getCurrentPosition/watchPosition).
Note: when Geolocation::haveSuitableCachedPosition(), WebGeolocationServiceBridgeImpl::startUpdating() is not called,
so we attach the bridge if needed at requestGeolocationPermissionForFrame().
https://bugs.webkit.org/show_bug.cgi?id=38323
http://crbug.com/42789
- src/ChromeClientImpl.cpp: (WebKit::ChromeClientImpl::requestGeolocationPermissionForFrame):
- src/WebGeolocationServiceBridgeImpl.cpp: (WebKit::WebGeolocationServiceBridgeImpl::attachBridgeIfNeeded): (WebKit::WebGeolocationServiceBridgeImpl::setLastPosition):
- 1:28 AM Changeset in webkit [59214] by
-
- 2 edits in trunk/LayoutTests
Unreviewed fix.
[Qt] Platform specific expected result updated after r59211.
- platform/qt/fast/css/pseudo-cache-stale-expected.txt: updated.
- 1:19 AM Changeset in webkit [59213] by
-
- 3 edits3 adds in trunk
2010-05-12 Robin Qiu <robin.qiu@torchmobile.com.cn>
Reviewed by Dirk Schulze.
Fix a bug in SVGPathSegList::getPathSegAtLength().
This bug is just a misktake: almost all of the code is OK, but the
parameter is not used at all, therefore, this function always returns
"1".
And make a modification to return the last path segment if the distance
exceeds the actual path length.
https://bugs.webkit.org/show_bug.cgi?id=37515
- svg/dom/svgpath-getPathSegAtLength-expected.txt: Added.
- svg/dom/svgpath-getPathSegAtLength.html: Added.
2010-05-12 Robin Qiu <robin.qiu@torchmobile.com.cn>
Reviewed by Dirk Schulze.
Fix a bug in SVGPathSegList::getPathSegAtLength().
This bug is just a misktake: almost all of the code is OK, but the
parameter is not used at all, therefore, this function always returns
"1".
And make a modification to return the last path segment if the distance
exceeds the actual path length.
https://bugs.webkit.org/show_bug.cgi?id=37515
Test: svg/dom/svgpath-getPathSegAtLength.html
- svg/SVGPathSegList.cpp: (WebCore::SVGPathSegList::getPathSegAtLength):
- 12:46 AM Changeset in webkit [59212] by
-
- 2 edits in trunk/WebKit/chromium
2010-05-12 Tony Chang <tony@chromium.org>
Reviewed by Kent Tamura.
[chromium] add DRT back to the chromium build
https://bugs.webkit.org/show_bug.cgi?id=38978
- WebKit.gyp:
- 12:01 AM Changeset in webkit [59211] by
-
- 3 edits in trunk
https://bugs.webkit.org/show_bug.cgi?id=38976, fast/css/pseudo-cache-stale.html has incorrect results.
Reviewed by Maciej Stachowiak.
Make sure to trigger a relayout of any objects whose first-line styles change dynamically.
- dom/Element.cpp:
(WebCore::Element::pseudoStyleCacheIsInvalid):
May 11, 2010:
- 10:50 PM Changeset in webkit [59210] by
-
- 2 edits in trunk/WebCore
2010-05-11 Joseph Pecoraro <Joseph Pecoraro>
Reviewed by Timothy Hatcher.
Web Inspector: Shorthand Properties Getting Deleted When Editing
https://bugs.webkit.org/show_bug.cgi?id=38958
- inspector/front-end/DOMAgent.js: (WebInspector.CSSStyleDeclaration.prototype.styleTextWithShorthands): was getting regular values instead of shorthand values
- 10:10 PM Changeset in webkit [59209] by
-
- 2 edits in trunk/WebKitTools
2010-05-11 Chris Jerdonek <Chris Jerdonek>
Reviewed by Eric Seidel.
Fixed two FIXME's in svn-apply: eliminated the unnecessary %copiedFiles
variable and changed gitKnowsOfFile() to use exitStatus().
- Scripts/svn-apply:
- 9:58 PM WebKit Team edited by
- (diff)
- 9:57 PM WebKit Team edited by
- (diff)
- 9:56 PM Changeset in webkit [59208] by
-
- 3 edits in trunk/WebKitTools
2010-05-11 Eric Seidel <eric@webkit.org>
Unreviewed, just fixing python typo.
EWS bots should poll more often than every 5 minutes
https://bugs.webkit.org/show_bug.cgi?id=38968
Typo in _now(), add a unittest to prove I fixed it.
- Scripts/webkitpy/tool/bot/queueengine.py:
- Scripts/webkitpy/tool/bot/queueengine_unittest.py:
- 9:44 PM Changeset in webkit [59207] by
-
- 3 edits in trunk/WebKitTools
2010-05-11 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Qt build failures cause SheriffBot false positives
https://bugs.webkit.org/show_bug.cgi?id=38969
The Qt buildbot randomly fails to compile occasionally because its
network connection causes SVn to leave zero-byte files around. These
compile failures confuse SheriffBot into thinking someone's patch
caused a build break.
In this patch, I've temporarily removed Qt from the list of core
builders. Ossy is working on a script to clean up the zero byte files.
Once that goes in, we can add Qt back to the core builders.
- Scripts/webkitpy/common/net/buildbot.py:
- Scripts/webkitpy/common/net/buildbot_unittest.py:
- 9:36 PM Changeset in webkit [59206] by
-
- 3 edits in trunk/WebKitTools
2010-05-11 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
sheriffbot is spammy.
https://bugs.webkit.org/show_bug.cgi?id=38936
Reduce sheriffbot spam by not warning about new blameworthy revisions
that can be explained by previously blamed revisions. This might cause
us to not warn about some real failures, but we're getting too much
spam from slow builders that have large blamelists (and we've already
poked the responsible folks using data from a fast builder).
- Scripts/webkitpy/tool/bot/sheriff_unittest.py:
- Removed unneeded import
- Scripts/webkitpy/tool/commands/sheriffbot.py:
- The logic change
- Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
- Tests of the change
- Scripts/webkitpy/tool/mocktool.py:
- Merged two declarations of MockBuilder
- 9:30 PM Changeset in webkit [59205] by
-
- 2 edits in trunk/JavaScriptCore
Slight simplification to the calling convention: read RegisterFile::end()
from an absolute address, instead of from a pointer to the RegisterFile
on the stack.
Reviewed by Gavin Barraclough.
SunSpider reports no change.
This should free us to remove the RegisterFile argument from the stack.
- jit/JIT.cpp:
(JSC::JIT::privateCompile):
- 9:20 PM Changeset in webkit [59204] by
-
- 5 edits in trunk/WebKitTools
2010-05-11 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
sheriffbot is spammy.
https://bugs.webkit.org/show_bug.cgi?id=38936
Reduce sheriffbot spam by not warning about new blameworthy revisions
that can be explained by previously blamed revisions. This might cause
us to not warn about some real failures, but we're getting too much
spam from slow builders that have large blamelists (and we've already
poked the responsible folks using data from a fast builder).
- Scripts/webkitpy/tool/bot/sheriff_unittest.py:
- Removed unneeded import
- Scripts/webkitpy/tool/commands/sheriffbot.py:
- The logic change
- Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
- Tests of the change
- Scripts/webkitpy/tool/mocktool.py:
- Merged two declarations of MockBuilder
- 8:53 PM Changeset in webkit [59203] by
-
- 4 edits in trunk
2010-05-11 Tony Chang <tony@chromium.org>
Reviewed by Darin Fisher.
[chromium] Remove subframe scrollbar routing (r58937)
https://bugs.webkit.org/show_bug.cgi?id=38894
- platform/win/Skipped: This test should pass on windows.
2010-05-11 Tony Chang <tony@chromium.org>
Reviewed by Darin Fisher.
[chromium] Remove subframe scrollbar routing (r58937)
https://bugs.webkit.org/show_bug.cgi?id=38894
- page/chromium/EventHandlerChromium.cpp: (WebCore::EventHandler::passMousePressEventToSubframe):
- 8:53 PM Changeset in webkit [59202] by
-
- 3 edits in trunk/JavaScriptCore
Possible Gtk build fix - use ALWAYS_INLINE on functions that were inlined.
- wtf/text/AtomicString.h:
(WebCore::AtomicString::add): Use ALWAYS_INLINE.
- wtf/text/WTFString.h:
(WebCore::String::length): Ditto.
(WebCore::String::isEmpty): Ditto.
- 8:51 PM Changeset in webkit [59201] by
-
- 2 edits in trunk/WebKitTools
2010-05-11 Tony Chang <tony@chromium.org>
Reviewed by David Levin.
[chromium] detect num processors to pass to make -j on Linux
https://bugs.webkit.org/show_bug.cgi?id=38833
- Scripts/webkitdirs.pm:
- 8:41 PM Changeset in webkit [59200] by
-
- 5 edits in trunk/WebKitTools
2010-05-11 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
commit-queue should commit rollouts without running tests
https://bugs.webkit.org/show_bug.cgi?id=38940
Most of this change is improving our test coverage for the commit-queue.
The only functional change is removing the --test flag when the commit-queue
is running in rollouts mode.
I added test coverage for status updates, and updated the commit-queue status
messages to distinguish rollout vs. normal landing mode in its empty queue
and land patch messages.
- Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
- Got rid of a bunch of copy/paste code using _default_expected_stderr
- Scripts/webkitpy/tool/commands/queues.py:
- Moved rollout patch filtering out of _validate_patches_in_commit_queue so that we only have to check if the builders are green in one place.
- Make the "empty queue" message note which queue it is referring to.
- Don't pass --text to land-attachment when in rollout mode.
- Scripts/webkitpy/tool/commands/queues_unittest.py:
- Update results now that we're testing status updates.
- Test _can_build_and_test since I made a typo in that call while writing this change and the unit tests failed to catch it!
- Scripts/webkitpy/tool/mocktool.py:
- Log status updates to make them testable in our unit tests.
- 8:25 PM Changeset in webkit [59199] by
-
- 3 edits4 adds in trunk
2010-05-11 Simon Fraser <Simon Fraser>
Reviewed by Maciej Stachowiak.
Body not redrawn, and filled with garbage on some composited pages
https://bugs.webkit.org/show_bug.cgi?id=38951
<rdar://problem/7891548>
When the root layer becomes composited (for example, because a negative z-index
descendant in its stacking context becomes composited), then it has to be made
large enough to fill the viewport, because the page background draws into it.
Test: compositing/geometry/composited-html-size.html
- rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::calculateCompositedBounds):
- 7:33 PM Changeset in webkit [59198] by
-
- 2 edits in trunk/JavaScriptCore
Add a compile time assert that sizeof(String) == sizeof(AtomicString).
Reviewed by Sam Weinig.
- wtf/text/AtomicString.cpp:
- 7:28 PM Changeset in webkit [59197] by
-
- 6 edits in trunk
2010-05-11 Anders Carlsson <andersca@apple.com>
Reviewed by Mark Rowe.
https://bugs.webkit.org/show_bug.cgi?id=38961
Move some member variables around to reduce class sizes.
Make AtomicString no longer inherit from FastAllocBase.
Since AtomicString's first (and only) member variable, a RefPtr, also inherits from FastAllocBase this
was causing the size of AtomicString to contain sizeof(void*) bytes of padding.
- wtf/text/AtomicString.h:
2010-05-11 Anders Carlsson <andersca@apple.com>
Reviewed by Mark Rowe.
https://bugs.webkit.org/show_bug.cgi?id=38961
Move some member variables around to reduce class sizes.
If a class inherits (directly or indirectly) from FastAllocBase, we don't want the first member variable
of that class to also inherit (directly or indirectly) from FastAllocBase as this will add padding to the class
and thus increasing its size.
- css/CSSParserValues.h:
- css/CSSSelector.h: (WebCore::CSSSelector::CSSSelector): (WebCore::CSSSelector::RareData::RareData):
- platform/graphics/FontCache.cpp: (WebCore::FontPlatformDataCacheKey::FontPlatformDataCacheKey):
- 7:25 PM Changeset in webkit [59196] by
-
- 8 edits in trunk/JavaScriptCore
Patch by Gavin Barraclough.
Reviewed by Maciej Stachowiak.
Rest of REGRESSION (r57900-57919): 3% PLT Regression from moving strings into WTF.
https://bugs.webkit.org/show_bug.cgi?id=38930
<rdar://problem/7937188>
Inline string functions that are commonly used in WTFString, CString, and AtomicString.
- JavaScriptCore.exp: Remove exports of inline functions.
- wtf/text/AtomicString.cpp:
(WebCore::AtomicString::addSlowCase): Rename add to addSlowCase, and inline the fast path
of add.
- wtf/text/AtomicString.h:
(WebCore::AtomicString::add): Inline the fast path of add.
- wtf/text/CString.cpp: Inline implementation of data and length in the header.
- wtf/text/CString.h:
(WTF::CString::data): Inline implementation of data.
(WTF::CString::length): Inline implementation of length.
- wtf/text/WTFString.cpp: Remove implementations of functions to be inlined.
- wtf/text/WTFString.h:
(WebCore::String::String): Inline implementation.
(WebCore::String::length): Ditto.
(WebCore::String::characters): Ditto.
(WebCore::String::operator[]): Ditto.
(WebCore::String::isEmpty): Ditto.
- 7:20 PM Changeset in webkit [59195] by
-
- 3 edits in trunk/WebCore
Adding a function needed by the V8 code generator to turn on/off
the binding for WorkerContext::openDatabaseSync().
https://bugs.webkit.org/show_bug.cgi?id=38960
Reviewed by Adam Barth.
- bindings/generic/RuntimeEnabledFeatures.cpp:
(WebCore::RuntimeEnabledFeatures::openDatabaseSyncEnabled):
- bindings/generic/RuntimeEnabledFeatures.h:
- 7:15 PM Changeset in webkit [59194] by
-
- 3 edits5 adds in trunk
2010-05-11 MORITA Hajime <morrita@google.com>
Reviewed by Dirk Schulze.
CSS SVG font doesn't recognize URL without element reference
https://bugs.webkit.org/show_bug.cgi?id=37144
- platform/mac/svg/custom/svg-fonts-with-no-element-reference-expected.checksum: Added.
- platform/mac/svg/custom/svg-fonts-with-no-element-reference-expected.png: Added.
- platform/mac/svg/custom/svg-fonts-with-no-element-reference-expected.txt: Added.
- svg/custom/resources/graffiti-with-empty-first-font.svg: Added.
- svg/custom/svg-fonts-with-no-element-reference.html: Added.
2010-05-11 MORITA Hajime <morrita@google.com>
Reviewed by Dirk Schulze.
CSS SVG font doesn't recognize URL without element reference
https://bugs.webkit.org/show_bug.cgi?id=37144
CachedFont::getSVGFontById() did assume that element reference (ID) is given.
So fixed to handle an empty or missing element reference. In which case,
the first font element is returned if available.
Test: svg/custom/svg-fonts-with-no-element-reference.html
- loader/CachedFont.cpp: (WebCore::CachedFont::getSVGFontById):
- 6:53 PM Changeset in webkit [59193] by
-
- 14 edits2 adds in trunk
2010-05-11 Kent Tamura <tkent@chromium.org>
Reviewed by Dimitri Glazkov.
[DRT/Chromium] Apply recent changes of test_shell to DRT
https://bugs.webkit.org/show_bug.cgi?id=38895
- DEPS: Update Chromium revision to use the recent webkit_support change.
- WebKit.gyp: Add JavaScriptCore/wtf to 'include' section.
- src/WebGraphicsContext3D.cpp: Remove ENABLE(3D_CANVAS) to provide an empty implementation of WebGraphicsContext3D::createDefault().
2010-05-11 Kent Tamura <tkent@chromium.org>
Reviewed by Dimitri Glazkov.
[DRT/Chromium] Apply recent changes of test_shell to DRT
https://bugs.webkit.org/show_bug.cgi?id=38895
Port the changes to test_shell during (r40492, r46810] of Chromium.
Highlights:
- Introduce NotificationPresenter
- Fix parameter mismatch of WebViewClient::startDragging()
This change fixes dozens of unexpected behaviors.
- DumpRenderTree/DumpRenderTree.gypi: Add NotificationPresenter.{cpp,h}
- DumpRenderTree/chromium/EventSender.cpp: (applyKeyModifier): (EventSender::EventSender): (EventSender::reset): (EventSender::webview): (EventSender::doDragDrop): (EventSender::keyDown): (EventSender::addTouchPoint): (EventSender::clearTouchPoints): (EventSender::releaseTouchPoint): (EventSender::setTouchModifier): (EventSender::updateTouchPoint): (EventSender::cancelTouchPoint): (EventSender::sendCurrentTouchEvent): (EventSender::touchEnd): (EventSender::touchMove): (EventSender::touchStart): (EventSender::touchCancel):
- DumpRenderTree/chromium/EventSender.h:
- DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): (LayoutTestController::reset): (LayoutTestController::showWebInspector): (LayoutTestController::setAuthorAndUserStylesEnabled): (LayoutTestController::setScrollbarPolicy): (LayoutTestController::setWillSendRequestClearHeader): (LayoutTestController::callShouldCloseOnWebView): (LayoutTestController::grantDesktopNotificationPermission): (LayoutTestController::removeOriginAccessWhitelistEntry): (LayoutTestController::addUserScript): (LayoutTestController::addUserStyleSheet):
- DumpRenderTree/chromium/LayoutTestController.h:
- DumpRenderTree/chromium/NotificationPresenter.cpp: Added.
- DumpRenderTree/chromium/NotificationPresenter.h: Added.
- DumpRenderTree/chromium/TestShell.cpp: (TestShell::TestShell): (TestShell::runFileTest): (TestShell::resetTestController):
- DumpRenderTree/chromium/TestShell.h: (TestShell::eventSender): (TestShell::notificationPresenter): (TestShell::showDevTools):
- DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::createView): (WebViewHost::createPopupMenu): (WebViewHost::startDragging): (WebViewHost::notificationPresenter): (WebViewHost::createApplicationCacheHost): (WebViewHost::willSendRequest): (WebViewHost::updateAddressBar): (WebViewHost::updateURL):
- DumpRenderTree/chromium/WebViewHost.h: (WebViewHost::addClearHeader): (WebViewHost::clearHeaders):
- 6:35 PM Changeset in webkit [59192] by
-
- 2 edits in trunk/WebCore
No Review.
Fix the Windows Debug Build: the correct VCProj variable to use when linking against
JavaScriptCore is $(WebKitDLLConfigSuffix), not $(WebKitConfigSuffix), which expands
to an empty string rather than "_debug".
- WebCore.vcproj/QTMovieWin.vcproj:
- 6:16 PM Changeset in webkit [59191] by
-
- 2 edits in trunk/WebKit/win
No Review.
Fix build error: The QTMovieWin project is dependent on the JavaScriptCore project.
- WebKit.vcproj/WebKit.sln:
- 5:41 PM Changeset in webkit [59190] by
-
- 2 edits in trunk/WebCore
2010-05-11 Jer Noble <jer.noble@apple.com>
Darin Adler.
19 media tests are crashing on Windows Release
https://bugs.webkit.org/show_bug.cgi?id=38950
rdar://problem/7971658
Link against JavaScriptCore.lib instead of WTF.lib, so the free and malloc used by
QTMovieWin is always the free and malloc in JavaScriptCore.dll.
- WebCore.vcproj/QTMovieWin.vcproj:
- 5:35 PM Changeset in webkit [59189] by
-
- 6 edits in trunk/WebCore
Another refactoring patch in preparation for a fix to
https://bugs.webkit.org/show_bug.cgi?id=38871
REGRESSION: Crash clicking background NPR tab after few minutes of sitting idle
Reviewed by Beth Dakin.
- dom/Document.cpp:
(WebCore::Document::addMediaCanStartListener): Added.
(WebCore::Document::removeMediaCanStartListener): Added.
- dom/Document.h: Added add/removeMediaCanStartListener.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::~HTMLMediaElement): Call removeMediaCanStartListener
on the document instead of the page.
(WebCore::HTMLMediaElement::willMoveToNewOwnerDocument): Call
removeMediaCanStartListener on the current document.
(WebCore::HTMLMediaElement::didMoveToNewOwnerDocument): Call
addMediaCanStartListener on the new document.
(WebCore::HTMLMediaElement::loadInternal): Call addMediaCanStartListener
on the document instead of the page.
- plugins/PluginView.cpp:
(WebCore::PluginView::startOrAddToUnstartedList): Call addMediaCanStartListener
on the document instead of the page.
(WebCore::PluginView::~PluginView): Call removeMediaCanStartListener
on the document instead of the page, and do it in line instead of calling
a function.
- plugins/PluginView.h: Removed unused removeFromUnstartedListIfNecessary.
- 5:26 PM Changeset in webkit [59188] by
-
- 2 edits in trunk/LayoutTests
Not reviewed.
https://bugs.webkit.org/show_bug.cgi?id=38956
[Gtk] http/tests/xmlhttprequest/basic-auth-default.html fails
- platform/gtk/Skipped: Skipping the new failing test on Gtk.
- 5:22 PM Changeset in webkit [59187] by
-
- 15 edits1 add in trunk
JavaScriptCore: Patch by Gavin Barraclough.
Reviewed by Steve Falkenburg and Jon Honeycutt.
REGRESSION (r57900-57919): 3% PLT Regression from moving strings into WTF.
https://bugs.webkit.org/show_bug.cgi?id=38930
<rdar://problem/7937188>
When the String classes were moved from WebCore to WTF, it meant that on Windows, all operations
on Strings in WebCore had to cross a DLL boundary (from WebKit.dll to JavaScript.dll).
We fix this by refactoring some of the WTF string code, so the code in AtomicString, StringImpl, and
WTFString can be built by both WebCore and WTF, and we don't need to talk across a DLL to do operations
on Strings.
- GNUmakefile.am: Add new file to build system.
- JavaScriptCore.gypi: Ditto.
- JavaScriptCore.pro: Ditto.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def: Remove string exports, because these are now
handled in WebCore.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Remove the post-build step that was added
here (the post build step is in JavaScriptCoreCommon.vsprops).
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreCommon.vsprops: Copy the three cpp files that need to be compiled
by WebCore into the WebKitOutputDir directory.
- JavaScriptCore.vcproj/WTF/WTF.vcproj: Add the StringStatics file.
- JavaScriptCore.vcproj/jsc/jsc.vcproj: Add the three WTF string cpp files to this project.
- JavaScriptCore.vcproj/jsc/jscCommon.vsprops: Remove the need to link against WTF.lib (since jsc links against JavaScriptCore).
- JavaScriptCore.xcodeproj/project.pbxproj: Add the StringStatics file.
- wtf/text/AtomicString.cpp: Moved code to StringStatics.
- wtf/text/StringImpl.cpp: Ditto.
- wtf/text/StringStatics.cpp: Added. Move functions in WTF Strings that define static variables to here, so
the rest of the files can be compiled in WebCore.
(WebCore::StringImpl::empty): Moved from StringImpl.cpp to here.
(WebCore::AtomicString::init): Moved from AtomicString.cpp to here.
WebCore: Patch by Gavin Barraclough.
Reviewed by Steve Falkenburg and Jon Honeycutt.
REGRESSION (r57900-57919): 3% PLT Regression from moving strings into WTF.
https://bugs.webkit.org/show_bug.cgi?id=38930
<rdar://problem/7937188>
Add the WTF strings into the WebCore vcproj, from their copied location in $(WebKitOutputDir).
No new tests because no change in behavior.
- WebCore.vcproj/WebCore.vcproj:
- 5:04 PM Changeset in webkit [59186] by
-
- 3 edits in trunk/WebCore
Small re-factoring patch in preparation for fixing https://
bugs.webkit.org/show_bug.cgi?id=38871 REGRESSION: Crash clicking
background NPR tab after few minutes of sitting idle
Reviewed by Darin Adler.
- page/Page.cpp:
(WebCore::Page::takeAnyMediaCanStartListener):
(WebCore::Page::setCanStartMedia):
- page/Page.h:
- 4:41 PM Changeset in webkit [59185] by
-
- 4 edits8 adds in trunk
Reviewed by Brady Eidson.
https://bugs.webkit.org/show_bug.cgi?id=37989
Safari (still) doesn't always send basic credentials preemptively
Test: http/tests/xmlhttprequest/basic-auth-default.html
After fetching credentials from WebCore storage, put them back right away. This will add
default credentials for the directory, since this may be the first time we learn about its
associated protection space.
- platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::ResourceHandle::didReceiveAuthenticationChallenge): (WebCore::WebCoreSynchronousLoader::didReceiveChallenge):
- platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::didReceiveAuthenticationChallenge): (-[WebCoreSynchronousLoader connection:didReceiveAuthenticationChallenge:]):
- 4:41 PM Changeset in webkit [59184] by
-
- 2 edits in trunk/WebKit/wx
Reviewed by Kevin Ollivier.
Load a blank page on creation to initialize WebCore objects properly.
https://bugs.webkit.org/show_bug.cgi?id=38932
- 4:39 PM Changeset in webkit [59183] by
-
- 4 edits in trunk/WebCore
Reviewed by Kevin Ollivier.
[wx] Create an NSFont on Mac builds that do not have built-in methods to do so.
https://bugs.webkit.org/show_bug.cgi?id=38931
- 4:22 PM Changeset in webkit [59182] by
-
- 3 edits in trunk/WebKitTools
2010-05-10 Dirk Pranke <dpranke@chromium.org>
Reviewed by Eric Seidel.
new-run-webkit-tests: fix a path-handling bug that was breaking the
dryrun ports on windows, and add a comment about why we don't run
the chromium dryrun tests by default on every port.
- Scripts/webkitpy/layout_tests/port/dryrun.py:
- Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
- 4:12 PM Changeset in webkit [59181] by
-
- 2 edits in trunk/WebKitTools
<http://webkit.org/b/38941> build-webkit shouldn't always override ENABLE_FOO Xcode configuration settings
Reviewed by Darin Adler.
- Scripts/build-webkit: Don't pass the ENABLE setting to xcodebuild if the value matches the default.
This will lead to xcodebuild picking up the settings from FeatureDefines.xcconfig, and will aid in
revealing problems that are due to inconsistent values for settings across projects.
- 4:11 PM Changeset in webkit [59180] by
-
- 1 edit1 delete in trunk/LayoutTests
Unreviewed. Remove unneeded rebaselined result for enter-clicks-buttons.html
- platform/chromium-win/fast/forms/enter-clicks-buttons-expected.txt: Removed.
- 4:04 PM Changeset in webkit [59179] by
-
- 6 edits in trunk
2010-05-11 Avi Drissman <avi@chromium.org>
Reviewed by Darin Fisher.
[Chromium] Pipe RTL info into WebPopupMenuInfo
https://bugs.webkit.org/show_bug.cgi?id=38749
- platform/chromium/PopupMenuChromium.cpp: (WebCore::PopupContainer::menuStyle):
- platform/chromium/PopupMenuChromium.h:
2010-05-11 Avi Drissman <avi@chromium.org>
Reviewed by Darin Fisher.
[Chromium] Pipe RTL info into WebPopupMenuInfo
https://bugs.webkit.org/show_bug.cgi?id=38749
- public/WebPopupMenuInfo.h:
- src/ChromeClientImpl.cpp: (WebKit::ChromeClientImpl::getPopupMenuInfo):
- 3:56 PM Changeset in webkit [59178] by
-
- 4 edits in trunk
Fix build error when enabling debugging block in WebKit win painting code
Rubber-stamped by Gavin Barraclough.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
WebKit/win:
- WebView.cpp:
(WebView::paintIntoBackingStore):
- 3:43 PM Changeset in webkit [59177] by
-
- 2 edits in trunk/WebKitTools
Build fix.
- DumpRenderTree/mac/LayoutTestControllerMac.mm:
- 3:39 PM Changeset in webkit [59176] by
-
- 3 edits in trunk/WebKit/chromium
2010-05-11 David Holloway <dhollowa@chromium.org>
Reviewed by Darin Fisher.
[chromium] Add size method to WebInputElement class, providing same data
as HTMLInputElement::size(). During form AutoFill Chromium needs to
access the input element's size attribute in aid of form matching and
filling heuristics.
- public/WebInputElement.h:
- src/WebInputElement.cpp: (WebKit::WebInputElement::size):
- 3:28 PM Changeset in webkit [59175] by
-
- 8 edits in trunk/WebKit/win
https://bugs.webkit.org/show_bug.cgi?id=38937
W7 window preview paints content at the wrong location
Reviewed by Steve Falkenburg.
- WebFrame.cpp:
(WebFrame::paintDocumentRectToContext): Revert r58895
(WebFrame::paintDocumentRectToContextAtPoint): Added
- Interfaces/IWebFramePrivate.idl: Added paintDocumentRectToContextAtPoint
- Interfaces/IWebViewPrivate.idl: ditto
- Interfaces/WebKit.idl: touch to rebuild
- WebFrame.h: ditto
- WebView.cpp: ditto
(WebView::paintDocumentRectToContextAtPoint): ditto
- WebView.h: ditto
- 3:19 PM Changeset in webkit [59174] by
-
- 8 edits in trunk
Fix the world.
In r59162 a change was made to WebCore's FeatureDefines.xcconfig that enabled FILE_READER and FILE_WRITER.
The author and reviewer of that patch ignored the carefully-worded warning at the top of that file asking
that changes to the file be kept in sync across JavaScriptCore, WebCore and WebKit, as well as being kept
in sync with build-webkit. This led to WebCore and WebKit having different views of Document's vtable
and results in crashes in Safari shortly after launch when virtual function calls resulted in the wrong
function in WebCore being called.
We fix this by bringing the FeatureDefines.xcconfig files in to sync. Based on the ChangeLog message and
other changes in r59162 it appears that enabling FILE_WRITER was unintentional so that particular change
has been reverted.
- Configurations/FeatureDefines.xcconfig:
WebCore:
- Configurations/FeatureDefines.xcconfig:
WebKit/mac:
- Configurations/FeatureDefines.xcconfig:
WebKit2:
- Configurations/FeatureDefines.xcconfig:
- 3:01 PM Changeset in webkit [59173] by
-
- 11 edits in trunk
2010-05-11 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Darin Adler.
REGRESSION(r58520): Implicit submission on forms with button type="submit" no longer works
https://bugs.webkit.org/show_bug.cgi?id=38913
Updated the test to include coverage of button elements.
- fast/forms/enter-clicks-buttons-expected.txt: Updated expectations to account for implicit
submission which now correctly happens from the right element (button).
- fast/forms/implicit-submission-expected.txt: Updated expectations with new test results.
- fast/forms/implicit-submission.html: Added tests and code to cover button elements.
2010-05-11 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Darin Adler.
REGRESSION(r58520): Implicit submission on forms with button type="submit" no longer works
https://bugs.webkit.org/show_bug.cgi?id=38913
- Widened the check for a successful submit button to include all HTMLFormControlElements.
- Clarified implicit submission code by:
- introducing HTMLFormControlElement::canTriggerImplicitSubmission flag,
- getting rid of static casting and checking for tag names.
- html/HTMLFormControlElement.h: (WebCore::HTMLFormControlElement::canTriggerImplicitSubmission): Added.
- html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::submitImplicitly): Renamed parameters for clarity, refactored code
to use canTriggerImplicitSubmission.
- html/HTMLFormElement.h: Renamed parameter for clarity.
- html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::defaultEventHandler): Used canTriggerImplicitSubmission()
instead of isTextField() for clarity.
- html/HTMLInputElement.h: (WebCore::HTMLInputElement::canTriggerImplicitSubmission): Added.
- html/HTMLIsIndexElement.h: (WebCore::HTMLIsIndexElement::canTriggerImplicitSubmission): Added.
- 2:35 PM Changeset in webkit [59172] by
-
- 12 edits1 delete in trunk
2010-05-11 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r59171.
http://trac.webkit.org/changeset/59171
https://bugs.webkit.org/show_bug.cgi?id=38933
"Broke the world" (Requested by bweinstein on #webkit).
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreCommon.vsprops:
- JavaScriptCore.vcproj/WTF/WTF.vcproj:
- JavaScriptCore.vcproj/jsc/jsc.vcproj:
- JavaScriptCore.vcproj/jsc/jscCommon.vsprops:
- JavaScriptCore.xcodeproj/project.pbxproj:
- wtf/text/AtomicString.cpp: (WebCore::AtomicString::init):
- wtf/text/StringImpl.cpp: (WebCore::StringImpl::empty):
- wtf/text/StringStatics.cpp: Removed.
2010-05-11 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r59171.
http://trac.webkit.org/changeset/59171
https://bugs.webkit.org/show_bug.cgi?id=38933
"Broke the world" (Requested by bweinstein on #webkit).
- WebCore.vcproj/WebCore.vcproj:
- 1:52 PM Changeset in webkit [59171] by
-
- 12 edits1 add in trunk
JavaScriptCore: Patch by Gavin Barraclough.
Reviewed by Steve Falkenburg.
REGRESSION (r57900-57919): 3% PLT Regression from moving strings into WTF.
https://bugs.webkit.org/show_bug.cgi?id=38930
<rdar://problem/7937188>
When the String classes were moved from WebCore to WTF, it meant that on Windows, all operations
on Strings in WebCore had to cross a DLL boundary (from WebKit.dll to JavaScript.dll).
We fix this by refactoring some of the WTF string code, so the code in AtomicString, StringImpl, and
WTFString can be built by both WebCore and WTF, and we don't need to talk across a DLL to do operations
on Strings.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def: Remove string exports, because these are now
handled in WebCore.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Remove the post-build step that was added
here (the post build step is in JavaScriptCoreCommon.vsprops).
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreCommon.vsprops: Copy the three cpp files that need to be compiled
by WebCore into the WebKitOutputDir directory.
- JavaScriptCore.vcproj/WTF/WTF.vcproj: Add the StringStatics file.
- JavaScriptCore.vcproj/jsc/jsc.vcproj: Add the three WTF string cpp files to this project.
- JavaScriptCore.vcproj/jsc/jscCommon.vsprops: Remove the need to link against WTF.lib (since jsc links against JavaScriptCore).
- JavaScriptCore.xcodeproj/project.pbxproj: Add the StringStatics file.
- wtf/text/AtomicString.cpp: Moved code to StringStatics.
- wtf/text/StringImpl.cpp: Ditto.
- wtf/text/StringStatics.cpp: Added. Move functions in WTF Strings that define static variables to here, so
the rest of the files can be compiled in WebCore.
(WebCore::StringImpl::empty): Moved from StringImpl.cpp to here.
(WebCore::AtomicString::init): Moved from AtomicString.cpp to here.
WebCore: Patch by Gavin Barraclough.
Reviewed by Steve Falkenburg.
REGRESSION (r57900-57919): 3% PLT Regression from moving strings into WTF.
https://bugs.webkit.org/show_bug.cgi?id=38930
<rdar://problem/7937188>
Add the WTF strings into the WebCore vcproj, from their copied location in $(WebKitOutputDir).
No new tests because no change in behavior.
- WebCore.vcproj/WebCore.vcproj:
- 1:38 PM Changeset in webkit [59170] by
-
- 2 edits in trunk/JavaScriptCore
Fixed test failures seen on SnowLeopard buildbot.
- runtime/JSString.cpp:
(JSC::JSString::replaceCharacter): Don't use size_t and wtf::notFound.
Instead, use the individual types and notFound values of the string APIs
we're using, since they're not necessarily the same in 64bit.
- 1:32 PM Changeset in webkit [59169] by
-
- 2 edits in trunk/WebKit/chromium
2010-05-11 Nate Chapin <Nate Chapin>
Reviewed by Adam Barth.
Crash fix in WebPageSerializerImpl::serialize().
The relevant test is a test_shell_test in src.chromium.org, because neither
DRT nor the Chromium webkit unit tests can currently cover the serializer
functionality.
- src/WebPageSerializerImpl.cpp: (WebKit::WebPageSerializerImpl::serialize): Check each frame's url before using it,
since they are not guaranteed to be valid (e.g., if the frame was treated as a download).
- 1:11 PM Changeset in webkit [59168] by
-
- 2 edits1 add in trunk/WebKitTools
2010-05-10 Ojan Vafai <ojan@chromium.org>
Reviewed by David Levin.
CheckStyle was eating script errors when there were local-commits and working copy changes
https://bugs.webkit.org/show_bug.cgi?id=38880
- Scripts/webkitpy/tool/steps/checkstyle.py:
- Scripts/webkitpy/tool/steps/checkstyle_unittest.py: Added.
- 12:58 PM Changeset in webkit [59167] by
-
- 2 edits in branches/audio/WebCore
Create a symlink in the built WebCore.framework/Resources to point to audio spatialization files
- which exist in WebKit/WebCore/audio/AudioSpatialization
- This is a temporary hack so that people can build WebKit "build-webkit" in my private "audio" branch and then
- run the "run-safari" script to test out the new audio features.
- 12:55 PM Changeset in webkit [59166] by
-
- 2 edits in trunk/WebCore
Unreviewed. Fix compiling erron on snow leopard.
- html/FileThreadTask.h:
(WebCore::createFileThreadTask):
- 12:48 PM Changeset in webkit [59165] by
-
- 3 edits in trunk/LayoutTests
[Qt] fast/frames/flattening/frameset-flattening-subframesets.html fails intermittently on Qt bot
https://bugs.webkit.org/show_bug.cgi?id=37334
Rubber-stamped by Kenneth Christiansen.
Patch by Antonio Gomes <tonikitoo@webkit.org>
Removing unneeded call to LayoutTestController.display(). It was originally intending
to force a layout, but a re-layout will happen regardless because document.body.offsetTop
is called afterwards
- fast/frames/flattening/frameset-flattening-subframe-resize.html:
- platform/qt/Skipped:
- 12:37 PM Changeset in webkit [59164] by
-
- 2 edits in trunk/LayoutTests
Unreviewed. Skip file-reader.html that is not enabled in chromium yet.
- platform/chromium/test_expectations.txt:
- 12:20 PM Changeset in webkit [59163] by
-
- 2 edits in trunk/WebKit/qt
[Qt] emit initialLayoutCompleted signal from FrameLoaderClientQt::dispatchDidFirstVisuallyNonEmptyLayout
https://bugs.webkit.org/show_bug.cgi?id=38921
Reviewed by Kenneth Christiansen.
Patch by Antonio Gomes <tonikitoo@webkit.org>
Emit initialLayoutCompleted signal from FrameLoaderClientQt::dispatchDidFirstVisuallyNonEmptyLayout
instead of FrameLoaderClientQt::dispatchDidFirstLayout , because the former ensures that a
visual content layed out on the frame.
It matches to QWebFrame::initialLayoutCompleted signal documentation at:
"... This is the first time you will see contents displayed on the frame ..."
- WebCoreSupport/FrameLoaderClientQt.cpp:
(WebCore::FrameLoaderClientQt::dispatchDidFirstLayout):
(WebCore::FrameLoaderClientQt::dispatchDidFirstVisuallyNonEmptyLayout):
- 12:04 PM Changeset in webkit [59162] by
-
- 28 edits1 copy10 adds in trunk
Expose FileReader interface.
https://bugs.webkit.org/show_bug.cgi?id=38609
Reviewed by Dmitry Titov.
WebCore:
Test: fast/files/file-reader.html
- Configurations/FeatureDefines.xcconfig:
- DerivedSources.cpp:
- DerivedSources.make:
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pri:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSEventTarget.cpp:
(WebCore::toJS):
- bindings/v8/V8DOMWrapper.cpp:
(WebCore::V8DOMWrapper::convertEventTargetToV8Object):
- html/FileError.idl:
- html/FileReader.idl: Added.
- page/DOMWindow.idl:
WebKit/chromium:
- features.gypi: turn on building FileReader for Chromium.
WebKitTools:
- Scripts/build-webkit: turn on building FileReader for Apple's WebKit.
LayoutTests:
Add a layout test to test basic FileReader operations.
Also update layout tests affected by adding the constructors to DOMWindow.
- fast/dom/Window/script-tests/window-property-descriptors.js:
- fast/dom/Window/window-properties.html:
- fast/dom/script-tests/constructed-objects-prototypes.js:
- fast/dom/script-tests/prototype-inheritance-2.js:
- fast/dom/script-tests/prototype-inheritance.js:
- fast/files/file-reader-expected.txt: Added.
- fast/files/file-reader.html: Added.
- fast/files/resources/UTF16BE-BOM.txt: Added.
- fast/files/resources/UTF16BE.txt: Added.
- fast/files/resources/UTF16LE-BOM.txt: Added.
- fast/files/resources/UTF8-BOM.txt: Added.
- fast/files/resources/UTF8.txt: Added.
- fast/files/resources/empty-file: Added.
- fast/js/script-tests/global-constructors.js:
- platform/chromium/test_expectations.txt:
- platform/gtk/Skipped: Skip the new test because eventSender.beginDragWithFiles is not supported in gtk platform.
- platform/qt/Skipped: Skip the new test because eventSender.beginDragWithFiles is not supported in qt platform.
- platform/win/Skipped: Skip the new test because eventSender.beginDragWithFiles is not supported in win platform.
- 11:42 AM Changeset in webkit [59161] by
-
- 7 edits in trunk/JavaScriptCore
Start using ropes in String.prototype.replace.
Reviewed by Oliver Hunt and Darin Adler.
1%-1.5% speedup on SunSpider.
- runtime/JSString.cpp:
(JSC::JSString::resolveRope): Updated for RopeImpl refactoring.
(JSC::JSString::replaceCharacter): Added a replaceCharacter function, which creates
a rope for the resulting replacement.
- runtime/JSString.h: A few changes here:
(JSC::):
(JSC::RopeBuilder::RopeIterator::RopeIterator):
(JSC::RopeBuilder::RopeIterator::operator++):
(JSC::RopeBuilder::RopeIterator::operator*):
(JSC::RopeBuilder::RopeIterator::operator!=):
(JSC::RopeBuilder::RopeIterator::WorkItem::WorkItem):
(JSC::RopeBuilder::RopeIterator::WorkItem::operator!=):
(JSC::RopeBuilder::RopeIterator::skipRopes): Created a RopeIterator abstraction.
We use this to do a substring find without having to resolve the rope.
(We could use this iterator when resolving ropes, too, but resolving
ropes backwards is usually more efficient.)
(JSC::RopeBuilder::JSString): Added constructors for 2 & 3 UStrings.
(JSC::RopeBuilder::appendValueInConstructAndIncrementLength):
(JSC::RopeBuilder::size): Updated for RopeImpl refactoring.
- runtime/Operations.h: Updated for RopeImpl refactoring.
(JSC::jsString): Added jsString functions for 2 & 3 UStrings.
- runtime/RopeImpl.cpp:
(JSC::RopeImpl::derefFibersNonRecursive):
- runtime/RopeImpl.h:
(JSC::RopeImpl::initializeFiber):
(JSC::RopeImpl::size):
(JSC::RopeImpl::fibers):
(JSC::RopeImpl::deref):
(JSC::RopeImpl::RopeImpl): A little refactoring to make this patch easier:
Moved statics to the top of the class; put multi-statement functions on
multiple lines; renamed "fiberCount" to "size" to match other collections;
changed the "fibers" accessor to return the fibers buffer, instead of an
item in the buffer, to make iteration easier.
- runtime/StringPrototype.cpp:
(JSC::stringProtoFuncReplace): Don't resolve a rope unless we need to. Do
use our new replaceCharacter function if possible. Do use a rope to
represent splicing three strings together.
- 11:35 AM Changeset in webkit [59160] by
-
- 2 edits in trunk/LayoutTests
Unreviewed.
[chromium] Mark flaky layout tests.
- platform/chromium/test_expectations.txt:
- 10:58 AM Changeset in webkit [59159] by
-
- 1 edit in trunk/WebKit/chromium/src/WebScrollbarImpl.cpp
[chromium] Fix build break on Chromium Mac
- 10:53 AM Changeset in webkit [59158] by
-
- 3 edits in trunk/WebKit/gtk
2010-05-11 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[Gtk] Doesn't support gtk-key-themes
https://bugs.webkit.org/show_bug.cgi?id=28257
Add support for GTK+ key themes.
- WebCoreSupport/EditorClientGtk.cpp: (WebKit::backspaceCallback): Added. (WebKit::cutClipboardCallback): Added. (WebKit::copyClipboardCallback): Added. (WebKit::pasteClipboardCallback): Added. (WebKit::selectAllCallback): Added. (WebKit::deleteFromCursorCallback): Added. (WebKit::moveCursorCallback): Added. (WebKit::EditorClient::generateEditorCommands): Added. (WebKit::EditorClient::executePendingEditorCommands): Added. (WebKit::EditorClient::handleKeyboardEvent): Derive editor commands both from internal text widget and a list of fallbacks. (WebKit::EditorClient::EditorClient): Add m_nativeWidget initializer.
- WebCoreSupport/EditorClientGtk.h: (WebKit::EditorClient::addPendingEditorCommand): Add m_nativeWidget member.
- 10:37 AM Changeset in webkit [59157] by
-
- 2 edits in trunk/WebCore
2010-05-11 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
[gtk] critical warning in soup_message_set_first_party() when cancelling a navigation
https://bugs.webkit.org/show_bug.cgi?id=38653
Check if willSendRequest cancelled the request before setting the
first party for the cookies in the message, otherwise we'll get a
critical warning.
- platform/network/soup/ResourceHandleSoup.cpp: (WebCore::restartedCallback):
- 10:11 AM Changeset in webkit [59156] by
-
- 1 edit in trunk/WebKit/chromium/WebKit.gyp
Check in gyp changes for r59110
- 9:47 AM Changeset in webkit [59155] by
-
- 4 edits in trunk/WebCore
REGRESSION (r59001): 11 media tests are failing on Windows (38847)
rdar://problem/7962997
https://bugs.webkit.org/show_bug.cgi?id=38847
Patch by Jer Noble <jer.noble@apple.com> on 2010-05-11
Reviewed by Adele Peterson.
QTMovieWin was too much refactored; the cacheMovieScale() function should have
been left in QTMovie (instead of being moved into QTMovieGWorld). This fixes the
video-size-intrinsic-scale test.
QTMovieTask::updateTaskTimer() was ignoring the maxInterval parameter unless
QTGetTimeUntilNextTask() returned an error, which caused the next timer to be
scheduled for extremely far in the future, breaking some of the layout tests.
QTMovieTask::fireTaskClients() now makes a local copy of the task list before
calling clients, in case one of them removes themselves from the task list and
invalidates our iterating pointer.
- platform/graphics/win/QTMovie.cpp:
(QTMoviePrivate::task):
(QTMoviePrivate::createMovieController):
(QTMoviePrivate::cacheMovieScale):
- platform/graphics/win/QTMovieGWorld.cpp:
(QTMovieGWorldPrivate::movieLoadStateChanged):
- platform/graphics/win/QTMovieTask.cpp:
(QTMovieTask::updateTaskTimer):
(QTMovieTask::fireTaskClients):
- 9:38 AM Changeset in webkit [59154] by
-
- 2 edits in trunk/WebCore
2010-05-11 Patrick Gansterer <paroga@paroga.com>
Reviewed by Adam Roben.
Port SharedBuffer to WinCE.
https://bugs.webkit.org/show_bug.cgi?id=37222
Use only functions which are available on Win32 and WinCE.
- platform/win/SharedBufferWin.cpp: (WebCore::SharedBuffer::createWithContentsOfFile):
- 9:14 AM Changeset in webkit [59153] by
-
- 1 edit2 adds6 deletes in trunk/LayoutTests
Merge some pseudo-valid-*.html tests into one.
https://bugs.webkit.org/show_bug.cgi?id=38846
Reviewed by Shinichiro Hamaji.
No additional test cases and no removed test cases.
- fast/css/pseudo-valid-003-expected.txt: Removed.
- fast/css/pseudo-valid-003.html: Removed.
- fast/css/pseudo-valid-005-expected.txt: Removed.
- fast/css/pseudo-valid-005.html: Removed.
- fast/css/pseudo-valid-006-expected.txt: Removed.
- fast/css/pseudo-valid-006.html: Removed.
- fast/css/pseudo-valid-unapplied-expected.txt: Added.
- fast/css/pseudo-valid-unapplied.html: Added.
- 8:45 AM Changeset in webkit [59152] by
-
- 4 edits in trunk/WebKit/qt
2010-05-11 Jesus Sanchez-Palencia <jesus@webkit.org>
Reviewed by Kenneth Rohde Christiansen.
Add PageClientQGraphicsWidget specific implementation.
QGraphicsWebViewPrivate doesn't inherit QWebPageClient anymore
and the needed functions were moved to this new PageClient class,
including Tiling and Accelerated Composite specific ones.
[Qt] PageClientQt specific implementation for QGraphicsWidget
https://bugs.webkit.org/show_bug.cgi?id=37866
- Api/qgraphicswebview.cpp: (QGraphicsWebViewPrivate::QGraphicsWebViewPrivate): (QGraphicsWebViewPrivate::~QGraphicsWebViewPrivate): (QGraphicsWebViewPrivate::syncLayers): (QGraphicsWebViewPrivate::_q_scaleChanged): (QGraphicsWebView::event): (QGraphicsWebView::setPage): (QGraphicsWebView::updateGeometry): (QGraphicsWebView::setGeometry): (QGraphicsWebView::setResizesToContents):
- WebCoreSupport/PageClientQt.cpp: (WebCore::PageClientQGraphicsWidget::~PageClientQGraphicsWidget): (WebCore::PageClientQGraphicsWidget::scroll): (WebCore::PageClientQGraphicsWidget::update): (WebCore::PageClientQGraphicsWidget::createOrDeleteOverlay): (WebCore::PageClientQGraphicsWidget::syncLayers): (WebCore::PageClientQGraphicsWidget::setRootGraphicsLayer): (WebCore::PageClientQGraphicsWidget::markForSync): (WebCore::PageClientQGraphicsWidget::updateCompositingScrollPosition): (WebCore::PageClientQGraphicsWidget::updateTiledBackingStoreScale): (WebCore::PageClientQGraphicsWidget::setInputMethodEnabled): (WebCore::PageClientQGraphicsWidget::inputMethodEnabled): (WebCore::PageClientQGraphicsWidget::setInputMethodHint): (WebCore::PageClientQGraphicsWidget::cursor): (WebCore::PageClientQGraphicsWidget::updateCursor): (WebCore::PageClientQGraphicsWidget::palette): (WebCore::PageClientQGraphicsWidget::screenNumber): (WebCore::PageClientQGraphicsWidget::ownerWidget): (WebCore::PageClientQGraphicsWidget::geometryRelativeToOwnerWidget): (WebCore::PageClientQGraphicsWidget::pluginParent): (WebCore::PageClientQGraphicsWidget::style):
- WebCoreSupport/PageClientQt.h: (WebCore::QGraphicsItemOverlay::page): (WebCore::QGraphicsItemOverlay::boundingRect): (WebCore::QGraphicsItemOverlay::paint): (WebCore::QGraphicsItemOverlay::prepareGraphicsItemGeometryChange): (WebCore::PageClientQGraphicsWidget::PageClientQGraphicsWidget): (WebCore::PageClientQGraphicsWidget::isQWidgetClient): (WebCore::PageClientQGraphicsWidget::allowsAcceleratedCompositing): (WebCore::PageClientQGraphicsWidget::):
- 8:18 AM QtWebKitTriageRoster edited by
- (diff)
- 8:15 AM Changeset in webkit [59151] by
-
- 4 edits in trunk
2010-05-11 Benjamin Poulain <benjamin.poulain@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] fast/text/find-hidden-text.html
https://bugs.webkit.org/show_bug.cgi?id=32922
Remove fast/text/find-hidden-text.html from the skipped list of Qt.
- platform/qt/Skipped:
2010-05-11 Benjamin Poulain <benjamin.poulain@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] fast/text/find-hidden-text.html
https://bugs.webkit.org/show_bug.cgi?id=32922
Use the real page step for populating the QStyleOption otherwhise
the size can be negative, which can break the QStyle used.
- platform/qt/ScrollbarThemeQt.cpp: (WebCore::styleOptionSlider):
- 7:15 AM Changeset in webkit [59150] by
-
- 10 edits in trunk
2010-05-11 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: make styles rendering more user-friendly.
- inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel):
- inspector/front-end/StylesSidebarPane.js: (WebInspector.StylesSidebarPane.prototype._update): (WebInspector.StylesSidebarPane.prototype._rebuildSectionsForStyleRules): (WebInspector.ComputedStyleSidebarPane): (WebInspector.StylePropertiesSection): (WebInspector.StylePropertiesSection.prototype.collapse): (WebInspector.StylePropertiesSection.prototype.startEditingSelector):
- inspector/front-end/inspector.css: (#elements-content): (#elements-sidebar): (.styles-sidebar-separator): (.styles-section): (.styles-section .header): (.styles-section .header .title): (.styles-section .header .subtitle): (.styles-section .header .subtitle a): (.styles-section .properties): (.styles-section.no-affect .properties li): (.styles-section.no-affect .properties li.editing): (.styles-section.expanded .properties): (.styles-section .properties li): (.styles-section .properties li.parent): (.styles-section .properties ol): (.styles-section .properties ol.expanded): (.styles-section .properties li.parent::before): (.styles-section .properties li.parent.expanded::before): (.styles-section .properties li .info): (.styles-section:hover .properties .enabled-button): (.styles-section .properties li.disabled .enabled-button): (.styles-section .properties .enabled-button): (.styles-section .properties .overloaded, .styles-section .properties .disabled): (.styles-section.computed-style .properties .disabled): (.styles-section .properties .implicit, .styles-section .properties .inherited): (.styles-section .properties .inherited): (.styles-section.show-inherited .properties .inherited):
- 6:09 AM Changeset in webkit [59149] by
-
- 3 edits7 adds in trunk/LayoutTests
2010-05-11 John Gregg <johnnyg@google.com>
[chromium] Unreviewed, test expectations.
- platform/chromium-mac/svg/filters/filteredImage-expected.checksum: Added.
- platform/chromium-win-xp/svg/batik/text/textFeatures-expected.txt:
- platform/chromium-win/svg/filters/filteredImage-expected.checksum: Added.
- platform/chromium-win/svg/filters/filteredImage-expected.png: Added.
- platform/chromium-win/svg/text/text-hkern-on-vertical-text-expected.checksum: Added.
- platform/chromium-win/svg/text/text-hkern-on-vertical-text-expected.png: Added.
- platform/chromium-win/svg/text/text-vkern-on-horizontal-text-expected.checksum: Added.
- platform/chromium-win/svg/text/text-vkern-on-horizontal-text-expected.png: Added.
- 5:11 AM Changeset in webkit [59148] by
-
- 13 edits10 adds in trunk
2010-05-11 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Dirk Schulze.
Move buildLayoutInformationForTextBox() from SVGRootInlineBox in SVGInlineTextBox where it belongs
https://bugs.webkit.org/show_bug.cgi?id=38799
Cleanup SVGRootInlineBox/SVGInlineTextBox. Move buildLayoutInformationForTextBox to SVGInlineTextBox.
Move lots of helper methods into new SVGTextLayoutUtilities class. Adapted all callsites.
Fixed bug in kerning handling, hkern was applyable to vertical text as well. Covered by two new tests.
Tests: svg/text/text-hkern-on-vertical-text.svg
svg/text/text-vkern-on-horizontal-text.svg
- Android.mk: Add SVGTextLayoutUtilities.cpp/h to build.
- GNUmakefile.am: Ditto.
- WebCore.gypi: Ditto.
- WebCore.pro: Ditto.
- WebCore.vcproj/WebCore.vcproj: Ditto.
- WebCore.xcodeproj/project.pbxproj: Ditto.
- rendering/SVGInlineTextBox.cpp: (WebCore::SVGInlineTextBox::calculateGlyphWidth): Use textRenderer()->characters() instead of textRenderer()->text()->characters() as shortcut. (WebCore::SVGInlineTextBox::svgCharacterHitsPosition): Fix style issue, no else if after a return branch. (WebCore::SVGInlineTextBox::paintSelection): Use !color.alpha() instead of color.alpha() == 0. (WebCore::SVGInlineTextBox::buildLayoutInformation): Moved from SVGRootInlineBox::buildLayoutInformationForTextBox.
- rendering/SVGInlineTextBox.h: Fix indention. (WebCore::SVGInlineTextBox::selectionTop): Inlined. (WebCore::SVGInlineTextBox::selectionHeight): Inlined.
- rendering/SVGRenderTreeAsText.cpp: Include SVGTextLayoutUtilities.h
- rendering/SVGRootInlineBox.cpp: Move almost all static text layout helper functions in SVGTextLayoutUtilities (WebCore::calculateTextLengthCorrectionForTextChunk): Fixed style issue in long if conditions spanning multiple lines. (WebCore::SVGRootInlineBox::computePerCharacterLayoutInformation): Use different topLeftPositionOfCharacterRange() taking start/end iterators. (WebCore::SVGRootInlineBox::buildLayoutInformation): Use the moved SVGInlineTextBox::buildLayoutInformation() method. (WebCore::SVGRootInlineBox::buildTextChunks): Fixed small style issue, remove unneeded parenthesis. (WebCore::SVGRootInlineBox::layoutTextChunks): Fix style issue in debugging code.
- rendering/SVGRootInlineBox.h: Rename 'LastGlyphInfo' to 'SVGLastGlyphInfo' and move to SVGTextLayoutUtilities. (WebCore::SVGRootInlineBox::svgTextChunks): Inlined for speed.
- rendering/SVGTextLayoutUtilities.cpp: Added. (WebCore::isVerticalWritingMode): (WebCore::dominantBaselineToShift): (WebCore::alignmentBaselineToShift): (WebCore::glyphOrientationToAngle): (WebCore::glyphOrientationIsMultiplyOf180Degrees): (WebCore::applyGlyphAdvanceAndShiftRespectingOrientation): (WebCore::topLeftPositionOfCharacterRange): (WebCore::cummulatedWidthOfInlineBoxCharacterRange): (WebCore::cummulatedHeightOfInlineBoxCharacterRange): (WebCore::svgTextRunForInlineTextBox): (WebCore::calculateCSSKerning): (WebCore::applySVGKerning):
- rendering/SVGTextLayoutUtilities.h: Added. (WebCore::): (WebCore::SVGTextPaintInfo::SVGTextPaintInfo): (WebCore::SVGLastGlyphInfo::SVGLastGlyphInfo):
2010-05-11 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Dirk Schulze.
Move buildLayoutInformationForTextBox() from SVGRootInlineBox in SVGInlineTextBox where it belongs
https://bugs.webkit.org/show_bug.cgi?id=38799
- platform/mac/svg/text/text-hkern-on-vertical-text-expected.checksum: Added.
- platform/mac/svg/text/text-hkern-on-vertical-text-expected.png: Added.
- platform/mac/svg/text/text-hkern-on-vertical-text-expected.txt: Added.
- platform/mac/svg/text/text-vkern-on-horizontal-text-expected.checksum: Added.
- platform/mac/svg/text/text-vkern-on-horizontal-text-expected.png: Added.
- platform/mac/svg/text/text-vkern-on-horizontal-text-expected.txt: Added.
- svg/text/text-hkern-on-vertical-text.svg: Added.
- svg/text/text-vkern-on-horizontal-text.svg: Added.
- 2:22 AM Changeset in webkit [59147] by
-
- 4 edits5 adds in trunk
WebCore: RenderSVGImage::imageChanged should invalidate the SVG filter cache
https://bugs.webkit.org/show_bug.cgi?id=38838
Reviewed by Dirk Schulze.
Test: svg/filters/filteredImage.svg
- rendering/RenderSVGImage.cpp:
(WebCore::RenderSVGImage::imageChanged):
LayoutTests: Test case for SVG filter cache invalidation, after an image resource arrives.
https://bugs.webkit.org/show_bug.cgi?id=38838
Reviewed by Dirk Schulze.
- platform/gtk/Skipped:
- platform/mac/svg/filters/filteredImage-expected.checksum: Added.
- platform/mac/svg/filters/filteredImage-expected.png: Added.
- platform/mac/svg/filters/filteredImage-expected.txt: Added.
- platform/qt/svg/filters/filteredImage-expected.txt: Added.
- svg/filters/filteredImage.svg: Added.
- 1:08 AM Changeset in webkit [59146] by
-
- 1 edit6 adds in trunk/LayoutTests
2010-05-11 Simon Fraser <Simon Fraser>
Test result fixes for Leopard.
Leopard needs custom results for tests that dump the layer tree, because Leopard
CA does not have geometry flipping, so we do that ourselves by setting a transform.
- platform/mac-leopard/compositing/iframes/composited-parent-iframe-expected.txt: Added.
- platform/mac-leopard/compositing/iframes/connect-compositing-iframe-expected.txt: Added.
- platform/mac-leopard/compositing/iframes/connect-compositing-iframe2-expected.txt: Added.
- platform/mac-leopard/compositing/iframes/connect-compositing-iframe3-expected.txt: Added.
- platform/mac-leopard/compositing/iframes/enter-compositing-iframe-expected.txt: Added.
- 12:24 AM Changeset in webkit [59145] by
-
- 2 edits in trunk/WebKit/chromium
2010-05-10 Tony Chang <tony@chromium.org>
Reviewed by Kent Tamura.
[chromium] don't build DRT in chromium checkouts due to a circular gyp dependency
https://bugs.webkit.org/show_bug.cgi?id=38889
- WebKit.gyp:
- 12:18 AM Changeset in webkit [59144] by
-
- 3 edits in trunk/LayoutTests
2010-05-11 John Gregg <johnnyg@google.com>
[chromium] Update win-vista version of the baseline recently updated for win-xp.
- platform/chromium-win-vista/svg/batik/text/textFeatures-expected.txt:
May 10, 2010:
- 11:43 PM Changeset in webkit [59143] by
-
- 2 edits in trunk/WebCore
2010-05-10 Simon Fraser <Simon Fraser>
Fix asserting GTK build.
r59137 changed the behavior of RenderObject::repaintUsingContainer(). I mistakenly
thought that non-compositing builds would always pass a 0 repaintContainer, but
actually the RenderView is passed in this case. So use this to repaint if
ACCELERATED_COMPOSITING is turned off.
- rendering/RenderObject.cpp: (WebCore::RenderObject::repaintUsingContainer):
- 11:32 PM Changeset in webkit [59142] by
-
- 2 edits in trunk/LayoutTests
2010-05-10 Simon Fraser <Simon Fraser>
Skip two new flakey tests:
# Tests are flakey: https://bugs.webkit.org/show_bug.cgi?id=38888
compositing/iframes/iframe-resize.html
compositing/iframes/overlapped-iframe.html
- platform/mac/Skipped:
- 11:22 PM Changeset in webkit [59141] by
-
- 3 edits in trunk/LayoutTests
2010-05-10 Simon Fraser <Simon Fraser>
No review; attempt to fix failing tests.
Increase the timeout to give compositing updates a chance to happen.
- compositing/iframes/iframe-resize.html:
- compositing/iframes/overlapped-iframe.html:
- 11:08 PM QtWebKitTriageRoster edited by
- (diff)
- 11:06 PM Changeset in webkit [59140] by
-
- 2 edits in trunk/WebCore
2010-05-10 Simon Fraser <Simon Fraser>
Fix warning on Windows about unreachable code.
- rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::shouldPropagateCompositingToEnclosingIFrame):
- 11:05 PM Changeset in webkit [59139] by
-
- 3 edits in trunk/LayoutTests
2010-05-10 Simon Fraser <Simon Fraser>
No review.
Reduce timeouts from 500 to 50ms to make the tests run more quickly.
- compositing/iframes/resources/enter-compositing-subframe.html:
- compositing/iframes/resources/leave-compositing-subframe.html:
- 10:47 PM Changeset in webkit [59138] by
-
- 2 edits in trunk/WebKit/mac
2010-05-10 Simon Fraser <Simon Fraser>
Reviewed by Anders Carlsson.
Allow compositing layers to be connected across iframe boundaries on Mac
https://bugs.webkit.org/show_bug.cgi?id=38856
When painting an iframe into a compositing layer, the "PaintBehaviorFlattenCompositingLayers"
flag was mistakenly set, because we'd detect that we were drawing into a bitmap. This caused
content to show up in both compositing layers, and the painted background inside the iframe.
Fix by taking the flattening state from the parent frame, if there is one. For the root
frame, we continue to look to see if we're painting into a bitmap.
- WebView/WebFrame.mm: (-[WebFrame _drawRect:contentsOnly:]):
- 10:47 PM Changeset in webkit [59137] by
-
- 2 edits in trunk/WebCore
2010-05-10 Simon Fraser <Simon Fraser>
Reviewed by Anders Carlsson
Allow compositing layers to be connected across iframe boundaries on Mac
https://bugs.webkit.org/show_bug.cgi?id=38856
RenderObject::repaintUsingContainer() incorrectly did a view-based
repaint if the repaint container was the RenderView. Instead, we need
to check to see if the RenderView's layer is composited, and, if so,
whether it's painting into the window or not. This can occur when iframes
are composited.
The bug is timing-sensitive, involving compositing in iframes, and I was not able to
concoct a good testcase.
- rendering/RenderObject.cpp: (WebCore::RenderObject::repaintUsingContainer):
- 10:44 PM Changeset in webkit [59136] by
-
- 16 edits3 copies4 adds1 delete in trunk
2010-05-10 Simon Fraser <Simon Fraser>
Reviewed by Anders Carlsson
Allow compositing layers to be connected across iframe boundaries on Mac
https://bugs.webkit.org/show_bug.cgi?id=38856
Changes to allow compositing layers for iframes to switch between being hosted
by the iframe's layer-backed NSView, and parented in the GraphicsLayer tree of the
enclosing document.
Tests: compositing/iframes/connect-compositing-iframe.html
compositing/iframes/connect-compositing-iframe2.html
compositing/iframes/connect-compositing-iframe3.html
- page/FrameView.h:
- page/FrameView.cpp: (WebCore::FrameView::hasCompositedContent): New convenience method. (WebCore::FrameView::setIsOverlapped): If we're composited, poke the owner document in case it
wants to re-evaluate compositing decisions.
(WebCore::FrameView::isOverlapped): Just expose the existing flag.
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::shouldBeNormalFlowOnly): (WebCore::RenderLayer::isSelfPaintingLayer):
- rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::updateGraphicsLayerConfiguration): If this is an iframe, we need
to ensure that the layers for the iframe content are hooked up.
(WebCore::RenderLayerBacking::updateDrawsContent): When an iframe toggles between different
attachments, the 'drawsContent' behavior of its root layer changes, so needs to be updated.
- rendering/RenderLayerCompositor.h: (WebCore::RenderLayerCompositor::updateCompositingLayers): Call destroyRootPlatformLayer()
instead of detachRootPlatformLayer() and manually zeroing out the OwnPtrs.
(WebCore::RenderLayerCompositor::updateBacking): If a RenderIFrame changes compositing mode,
we need to ensure that its content compositor attachment is updated.
(WebCore::RenderLayerCompositor::repaintOnCompositingChange): The existing code had a bug
that caused repaints for RenderViews (which have no parent) to bail. We only want to bail
for non-RenderViews that are not attached.
(WebCore::RenderLayerCompositor::rebuildCompositingLayerTree): Factored the iframe-connecting
code into a new method, parentIFrameContentLayers().
(WebCore::RenderLayerCompositor::parentIFrameContentLayers): New method to share the code that hooks
up the iframe's compositing layers to the parent.
(WebCore::RenderLayerCompositor::shouldPropagateCompositingToEnclosingIFrame): Add logic to propagate
compositing out of iframes on Mac in two situations: 1) when the FrameView is overlapped, and 2)
if the parent document is already composited.
(WebCore::RenderLayerCompositor::ensureRootPlatformLayer): Clean up the logic here to better deal
with dynamic changes of the attachment type.
(WebCore::RenderLayerCompositor::destroyRootPlatformLayer): Clean up and null out the clipping layer here.
(WebCore::RenderLayerCompositor::attachRootPlatformLayer): Call rootLayerAttachmentChanged().
(WebCore::RenderLayerCompositor::detachRootPlatformLayer): Ditto. Also unparent the clipping and platform layers.
(WebCore::RenderLayerCompositor::updateRootLayerAttachment): Call ensureRootPlatformLayer() to re-evaluate
the layer attachment.
(WebCore::RenderLayerCompositor::rootLayerAttachmentChanged): We need to update the drawsContent() status
of the RenderView's layer's backing, because it changes depending on the attachment.
- rendering/RenderWidget.cpp: (WebCore::RenderWidget::paint): Do overlap testing if the frameView can do fast repaints (as before),
but also now when the frameView has composited content.
- 10:37 PM Changeset in webkit [59135] by
-
- 1 edit6 adds in trunk/LayoutTests
Adding a test that makes sure openDatabaseSync() deals correctly with invalid inputs.
https://bugs.webkit.org/show_bug.cgi?id=34994
Reviewed by Brady Eidson.
- fast/workers/storage: Added.
- fast/workers/storage/open-database-sync-inputs-expected.txt: Added.
- fast/workers/storage/open-database-sync-inputs.html: Added.
- fast/workers/storage/resources: Added.
- fast/workers/storage/resources/open-database-sync-inputs.js: Added.
(notAString.toString):
- fast/workers/storage/resources/test-inputs-common.js: Added.
(log):
(finishTest):
(runTest.worker.onmessage):
(runTest):
- 10:34 PM Changeset in webkit [59134] by
-
- 4 edits in trunk/WebCore
2010-05-10 Simon Fraser <Simon Fraser>
Reviewed by Anders Carlsson
Allow compositing layers to be connected across iframe boundaries on Mac
https://bugs.webkit.org/show_bug.cgi?id=38856
Rename the static shouldPropagateCompositingToIFrameParent() to shouldPropagateCompositingToEnclosingIFrame(),
to pave the way for runtime switches in the propagation behavior. We have to make sure we call it on
the correct RenderLayerCompositor (that belonging to the iframe's content document).
- rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::paintingGoesToWindow): Now that we know the root layer attachment, we can simplify this method.
- rendering/RenderLayerCompositor.h:
- rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::enableCompositingMode): No need for the setNeedsStyleRecalc() here, because the ensureRootPlatformLayer() or destroyRootPlatformLayer() will have already done it.
(WebCore::RenderLayerCompositor::rebuildCompositingLayerTree): Use the root layer attachment to determine
whether to parent the iframe's layers.
(WebCore::RenderLayerCompositor::didMoveOnscreen): Method name change.
(WebCore::RenderLayerCompositor::shouldPropagateCompositingToEnclosingIFrame): Name change.
(WebCore::RenderLayerCompositor::requiresCompositingForIFrame): We need to consult the iframe contents
document's compositor to ask whether propagation is appropriate.
(WebCore::RenderLayerCompositor::ensureRootPlatformLayer): Name change.
- 10:33 PM Changeset in webkit [59133] by
-
- 3 edits in trunk/WebCore
2010-05-10 Simon Fraser <Simon Fraser>
Reviewed by Anders Carlsson
Allow compositing layers to be connected across iframe boundaries on Mac
https://bugs.webkit.org/show_bug.cgi?id=38856
Use an enum for the type of root layer attachment on a RenderLayerCompositor, so we can
determine if the attachment is via the ChromeClient, via an enclosing iframe, or unattached.
- rendering/RenderLayerCompositor.h: New RootLayerAttachment enum. (WebCore::RenderLayerCompositor::rootLayerAttachment): getter for the current attachment.
- rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::RenderLayerCompositor): Init m_rootLayerAttachment. (WebCore::RenderLayerCompositor::~RenderLayerCompositor): Assert that is unattached. (WebCore::RenderLayerCompositor::updateCompositingLayers): Call destroyRootPlatformLayer instead of willMoveOffscreen, when there are no layers left. Also clear out the clipping layer. (WebCore::RenderLayerCompositor::didMoveOnscreen): Call attachRootPlatformLayer. (WebCore::RenderLayerCompositor::willMoveOffscreen): Call ensureRootPlatformLayer with the appropriate attachment. (WebCore::RenderLayerCompositor::ensureRootPlatformLayer): Only create the m_rootPlatformLayer if we don't have one
already, but be sure to always set the root layer geometry orientation. Also only create the
m_clippingLayer if we need to.
(WebCore::RenderLayerCompositor::destroyRootPlatformLayer): Call detachRootPlatformLayer().
(WebCore::RenderLayerCompositor::attachRootPlatformLayer): Code moved from didMoveOnscreen, but switching on
attachment.
(WebCore::RenderLayerCompositor::detachRootPlatformLayer): Code moved from willMoveOffscreen, but switching on
attachment.
- 10:27 PM Changeset in webkit [59132] by
-
- 2 edits in trunk/WebCore
2010-05-10 Simon Fraser <Simon Fraser>
Reviewed by Anders Carlsson
Allow compositing layers to be connected across iframe boundaries on Mac
https://bugs.webkit.org/show_bug.cgi?id=38856
Clean up the geometry logic when propagating compositing out of iframes.
- rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::updateRootLayerPosition): Geometry on m_rootPlatformLayer no longer needs to be special when there's a clipping layer.
(WebCore::RenderLayerCompositor::ensureRootPlatformLayer): Don't set the clipping layer to have
flipped geometry ever, and only set the root layer to have flipped geometry if it is not
being hosted in an iframe. Also no need to set a custom anchor point on the clipping layer.
- 10:22 PM Changeset in webkit [59131] by
-
- 5 edits in trunk/LayoutTests
2010-05-10 Simon Fraser <Simon Fraser>
Fix up test results from last commit, which were generated with a build from before r59129.
- platform/win/compositing/iframes/composited-parent-iframe-expected.txt:
- platform/win/compositing/iframes/iframe-resize-expected.txt:
- platform/win/compositing/iframes/leave-compositing-iframe-expected.txt:
- platform/win/compositing/iframes/overlapped-iframe-expected.txt:
- 10:12 PM Changeset in webkit [59130] by
-
- 1 edit1 copy1 move11 adds1 delete in trunk/LayoutTests
2010-05-10 Simon Fraser <Simon Fraser>
Reviewed by Anders Carlsson.
https://bugs.webkit.org/show_bug.cgi?id=38856
Allow compositing layers to be connected across iframe boundaries on Mac
Add several more iframe-compositing-related tests. These tests:
- an iframe dynamically entering compositing mode
- an iframe dynamically leaving compositing mode
- an overlapped iframe
- a compositing iframe being resized
composited-iframe.html had no value and is removed.
- compositing/iframes/composited-iframe-expected.txt: Removed.
- compositing/iframes/composited-iframe.html: Removed.
- compositing/iframes/enter-compositing-iframe-expected.txt: Copied from LayoutTests/platform/mac/compositing/iframes/composited-iframe-expected.txt.
- compositing/iframes/enter-compositing-iframe.html: Added.
- compositing/iframes/iframe-resize-expected.txt: Copied from LayoutTests/platform/mac/compositing/iframes/composited-iframe-expected.txt.
- compositing/iframes/iframe-resize.html: Added.
- compositing/iframes/leave-compositing-iframe-expected.txt: Copied from LayoutTests/platform/mac/compositing/iframes/composited-iframe-expected.txt.
- compositing/iframes/leave-compositing-iframe.html: Added.
- compositing/iframes/overlapped-iframe-expected.txt: Copied from LayoutTests/platform/mac/compositing/iframes/composited-iframe-expected.txt.
- compositing/iframes/overlapped-iframe.html: Added.
- compositing/iframes/resources/enter-compositing-subframe.html: Added.
- compositing/iframes/resources/leave-compositing-subframe.html: Added.
- platform/win/compositing/iframes/iframe-resize-expected.txt: Added.
- platform/win/compositing/iframes/leave-compositing-iframe-expected.txt: Added.
- platform/win/compositing/iframes/overlapped-iframe-expected.txt: Added.
- 10:08 PM Changeset in webkit [59129] by
-
- 5 edits in trunk/WebCore
2010-05-10 Simon Fraser <Simon Fraser>
Reviewed by Anders Carlsson
Allow compositing layers to be connected across iframe boundaries on Mac
https://bugs.webkit.org/show_bug.cgi?id=38856
Clean up some methods related to composited iframes. No behavioral changes.
- rendering/RenderLayerBacking.h: Move innerRenderLayerCompositor() to be a static method:
RenderLayerCompositor::iframeContentsCompositor().
- rendering/RenderLayerBacking.cpp: Remove innerRenderLayerCompositor(). (WebCore::RenderLayerBacking::updateGraphicsLayerGeometry): Call iframeContentsCompositor().
- rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::enableCompositingMode): Call enclosingIFrameElement() (WebCore::RenderLayerCompositor::rebuildCompositingLayerTree): iframeContentsCompositor() is now a static method in this class. Also check that the iframe contents are in compositing mode (slightly clearer than relying on rootPlatformLayer() returning null). (WebCore::RenderLayerCompositor::iframeContentsCompositor): Moved from RenderLayerBacking. (WebCore::RenderLayerCompositor::didMoveOnscreen): Use enclosingIFrameElement() method. (WebCore::RenderLayerCompositor::willMoveOffscreen): Ditto. (WebCore::RenderLayerCompositor::enclosingIFrameElement): New method. (WebCore::RenderLayerCompositor::ensureRootPlatformLayer): Call enclosingIFrameElement().
- rendering/RenderLayerCompositor.h: New method, iframeContentsCompositor().
- 10:06 PM Changeset in webkit [59128] by
-
- 2 edits2 adds in trunk/LayoutTests
2010-05-10 John Gregg <johnnyg@google.com>
[chromium] Final set of baselines and expectations to green up the build.
- platform/chromium-mac/plugins/geturlnotify-during-document-teardown-expected.txt: Added.
- platform/chromium-win/plugins/geturlnotify-during-document-teardown-expected.txt: Added.
- platform/chromium/test_expectations.txt:
- 9:49 PM Changeset in webkit [59127] by
-
- 114 edits4 adds in trunk/LayoutTests
2010-05-10 John Gregg <johnnyg@google.com>
[chromium] rebaseline SVG test for windows after recent changes.
- platform/chromium-win/svg/W3C-SVG-1.1/filters-blend-01-b-expected.checksum:
- platform/chromium-win/svg/W3C-SVG-1.1/filters-blend-01-b-expected.png:
- platform/chromium-win/svg/W3C-SVG-1.1/filters-blend-01-b-expected.txt:
- platform/chromium-win/svg/W3C-SVG-1.1/filters-color-01-b-expected.checksum:
- platform/chromium-win/svg/W3C-SVG-1.1/filters-color-01-b-expected.png:
- platform/chromium-win/svg/W3C-SVG-1.1/filters-color-01-b-expected.txt:
- platform/chromium-win/svg/W3C-SVG-1.1/filters-composite-02-b-expected.checksum:
- platform/chromium-win/svg/W3C-SVG-1.1/filters-composite-02-b-expected.png:
- platform/chromium-win/svg/W3C-SVG-1.1/filters-composite-02-b-expected.txt:
- platform/chromium-win/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.checksum:
- platform/chromium-win/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.png:
- platform/chromium-win/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.txt:
- platform/chromium-win/svg/W3C-SVG-1.1/filters-diffuse-01-f-expected.txt:
- platform/chromium-win/svg/W3C-SVG-1.1/filters-displace-01-f-expected.checksum:
- platform/chromium-win/svg/W3C-SVG-1.1/filters-displace-01-f-expected.png:
- platform/chromium-win/svg/W3C-SVG-1.1/filters-displace-01-f-expected.txt:
- platform/chromium-win/svg/W3C-SVG-1.1/filters-example-01-b-expected.checksum:
- platform/chromium-win/svg/W3C-SVG-1.1/filters-example-01-b-expected.png:
- platform/chromium-win/svg/W3C-SVG-1.1/filters-example-01-b-expected.txt:
- platform/chromium-win/svg/W3C-SVG-1.1/filters-felem-01-b-expected.txt:
- platform/chromium-win/svg/W3C-SVG-1.1/filters-gauss-01-b-expected.checksum:
- platform/chromium-win/svg/W3C-SVG-1.1/filters-gauss-01-b-expected.png:
- platform/chromium-win/svg/W3C-SVG-1.1/filters-gauss-01-b-expected.txt:
- platform/chromium-win/svg/W3C-SVG-1.1/filters-image-01-b-expected.checksum:
- platform/chromium-win/svg/W3C-SVG-1.1/filters-image-01-b-expected.png:
- platform/chromium-win/svg/W3C-SVG-1.1/filters-image-01-b-expected.txt:
- platform/chromium-win/svg/W3C-SVG-1.1/filters-light-01-f-expected.txt:
- platform/chromium-win/svg/W3C-SVG-1.1/filters-morph-01-f-expected.checksum:
- platform/chromium-win/svg/W3C-SVG-1.1/filters-morph-01-f-expected.png:
- platform/chromium-win/svg/W3C-SVG-1.1/filters-morph-01-f-expected.txt:
- platform/chromium-win/svg/W3C-SVG-1.1/filters-offset-01-b-expected.checksum:
- platform/chromium-win/svg/W3C-SVG-1.1/filters-offset-01-b-expected.png:
- platform/chromium-win/svg/W3C-SVG-1.1/filters-offset-01-b-expected.txt:
- platform/chromium-win/svg/W3C-SVG-1.1/filters-specular-01-f-expected.txt:
- platform/chromium-win/svg/W3C-SVG-1.1/filters-tile-01-b-expected.checksum:
- platform/chromium-win/svg/W3C-SVG-1.1/filters-tile-01-b-expected.png:
- platform/chromium-win/svg/W3C-SVG-1.1/filters-tile-01-b-expected.txt:
- platform/chromium-win/svg/W3C-SVG-1.1/filters-turb-01-f-expected.txt:
- platform/chromium-win/svg/W3C-SVG-1.1/masking-intro-01-f-expected.txt:
- platform/chromium-win/svg/batik/filters/feTile-expected.checksum:
- platform/chromium-win/svg/batik/filters/feTile-expected.png:
- platform/chromium-win/svg/batik/filters/feTile-expected.txt:
- platform/chromium-win/svg/batik/filters/filterRegions-expected.checksum:
- platform/chromium-win/svg/batik/filters/filterRegions-expected.png:
- platform/chromium-win/svg/batik/filters/filterRegions-expected.txt:
- platform/chromium-win/svg/batik/masking/maskRegions-expected.txt:
- platform/chromium-win/svg/batik/text/textEffect-expected.checksum:
- platform/chromium-win/svg/batik/text/textEffect-expected.png: Added.
- platform/chromium-win/svg/batik/text/textEffect-expected.txt:
- platform/chromium-win/svg/batik/text/textEffect3-expected.checksum:
- platform/chromium-win/svg/batik/text/textEffect3-expected.png: Added.
- platform/chromium-win/svg/batik/text/textEffect3-expected.txt:
- platform/chromium-win/svg/batik/text/textFeatures-expected.txt:
- platform/chromium-win/svg/batik/text/textProperties-expected.txt:
- platform/chromium-win/svg/custom/empty-mask-expected.txt:
- platform/chromium-win/svg/custom/empty-merge-expected.checksum:
- platform/chromium-win/svg/custom/empty-merge-expected.png:
- platform/chromium-win/svg/custom/feComponentTransfer-Discrete-expected.checksum:
- platform/chromium-win/svg/custom/feComponentTransfer-Discrete-expected.png:
- platform/chromium-win/svg/custom/feComponentTransfer-Discrete-expected.txt:
- platform/chromium-win/svg/custom/feComponentTransfer-Gamma-expected.checksum:
- platform/chromium-win/svg/custom/feComponentTransfer-Gamma-expected.png:
- platform/chromium-win/svg/custom/feComponentTransfer-Gamma-expected.txt:
- platform/chromium-win/svg/custom/feComponentTransfer-Linear-expected.checksum:
- platform/chromium-win/svg/custom/feComponentTransfer-Linear-expected.png:
- platform/chromium-win/svg/custom/feComponentTransfer-Linear-expected.txt:
- platform/chromium-win/svg/custom/feComponentTransfer-Table-expected.checksum:
- platform/chromium-win/svg/custom/feComponentTransfer-Table-expected.png:
- platform/chromium-win/svg/custom/feComponentTransfer-Table-expected.txt:
- platform/chromium-win/svg/custom/feDisplacementMap-01-expected.checksum:
- platform/chromium-win/svg/custom/feDisplacementMap-01-expected.png:
- platform/chromium-win/svg/custom/image-with-transform-clip-filter-expected.checksum:
- platform/chromium-win/svg/custom/image-with-transform-clip-filter-expected.png:
- platform/chromium-win/svg/custom/image-with-transform-clip-filter-expected.txt:
- platform/chromium-win/svg/custom/invalid-css-expected.txt:
- platform/chromium-win/svg/custom/mask-invalidation-expected.txt:
- platform/chromium-win/svg/custom/non-opaque-filters-expected.txt:
- platform/chromium-win/svg/custom/resource-invalidate-on-target-update-expected.checksum:
- platform/chromium-win/svg/custom/resource-invalidate-on-target-update-expected.png:
- platform/chromium-win/svg/custom/text-filter-expected.checksum:
- platform/chromium-win/svg/custom/text-filter-expected.png:
- platform/chromium-win/svg/custom/text-filter-expected.txt:
- platform/chromium-win/svg/custom/visibility-override-filter-expected.checksum:
- platform/chromium-win/svg/custom/visibility-override-filter-expected.png:
- platform/chromium-win/svg/filters/big-sized-filter-2-expected.checksum:
- platform/chromium-win/svg/filters/big-sized-filter-2-expected.png:
- platform/chromium-win/svg/filters/big-sized-filter-expected.checksum:
- platform/chromium-win/svg/filters/big-sized-filter-expected.png:
- platform/chromium-win/svg/filters/feColorMatrix-values-expected.checksum:
- platform/chromium-win/svg/filters/feColorMatrix-values-expected.png:
- platform/chromium-win/svg/filters/feColorMatrix-values-expected.txt:
- platform/chromium-win/svg/filters/feComposite-expected.checksum:
- platform/chromium-win/svg/filters/feComposite-expected.png:
- platform/chromium-win/svg/filters/feComposite-expected.txt:
- platform/chromium-win/svg/filters/feGaussianBlur-expected.checksum:
- platform/chromium-win/svg/filters/feGaussianBlur-expected.png:
- platform/chromium-win/svg/filters/feMerge-expected.checksum:
- platform/chromium-win/svg/filters/feMerge-expected.png:
- platform/chromium-win/svg/filters/feOffset-expected.checksum:
- platform/chromium-win/svg/filters/feOffset-expected.png:
- platform/chromium-win/svg/filters/feTile-expected.checksum:
- platform/chromium-win/svg/filters/feTile-expected.png:
- platform/chromium-win/svg/filters/filter-on-tspan-expected.checksum:
- platform/chromium-win/svg/filters/filter-on-tspan-expected.png:
- platform/chromium-win/svg/filters/filter-on-tspan-expected.txt:
- platform/chromium-win/svg/filters/shadow-on-filter-expected.checksum:
- platform/chromium-win/svg/filters/shadow-on-filter-expected.png:
- platform/chromium-win/svg/filters/sourceAlpha-expected.txt:
- platform/chromium-win/svg/filters/subRegion-in-userSpace-expected.checksum:
- platform/chromium-win/svg/filters/subRegion-in-userSpace-expected.png:
- platform/chromium-win/svg/filters/subRegion-one-effect-expected.checksum:
- platform/chromium-win/svg/filters/subRegion-one-effect-expected.png:
- platform/chromium-win/svg/filters/subRegion-two-effects-expected.checksum:
- platform/chromium-win/svg/filters/subRegion-two-effects-expected.png:
- platform/chromium-win/svg/text/text-vkern-expected.checksum: Added.
- platform/chromium-win/svg/text/text-vkern-expected.png: Added.
- 9:12 PM Changeset in webkit [59126] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, fixing the expectations for Chromium.
- platform/chromium/http/tests/security/cross-frame-access-call-expected.txt:
- 8:51 PM Changeset in webkit [59125] by
-
- 3 edits in trunk/WebKit/mac
Fix a crash when closing a WebView while the Web Inspector is open.
<rdar://problem/7966830>
Reviewed by Mark Rowe.
- WebCoreSupport/WebInspectorClient.mm:
(-[WebInspectorWindowController destroyInspectorView]): Null check Page since it can be null.
- WebView/WebView.mm:
(-[WebView _close]): Null out _private->page before deleting the page, so code called
during destruction don't access a half deleted Page object.
- 8:45 PM Changeset in webkit [59124] by
-
- 6 edits1 add1 delete in trunk
2010-05-10 Tony Chang <tony@chromium.org>
Reviewed by Kent Tamura.
[chromium] Build DRT when running build-webkit --chromium
https://bugs.webkit.org/show_bug.cgi?id=38730
This allows DRT to use the same .o and .lib files when building
on Windows.
- WebKit.gyp: Move DRT.gyp targets into this file.
- gyp_webkit: DRT.gyp is gone
2010-05-10 Tony Chang <tony@chromium.org>
Reviewed by Kent Tamura.
[chromium] Build DRT when running build-webkit --chromium
https://bugs.webkit.org/show_bug.cgi?id=38730
- DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp: Removed.
- Scripts/build-dumprendertree: This does nothing now.
- 8:40 PM Changeset in webkit [59123] by
-
- 2 edits in trunk/LayoutTests
2010-05-10 Eric Seidel <eric@webkit.org>
Unreviewed, just removing newline from -expected.txt file
REGRESSION(r59100): "Added test is broken on many platforms." (Requested by eseidel on #webkit).
https://bugs.webkit.org/show_bug.cgi?id=38881
Looks like http://trac.webkit.org/changeset/59119
added an extra newline by mistake. Removing.
- plugins/geturlnotify-during-document-teardown-expected.txt:
- 7:54 PM Changeset in webkit [59122] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, fixing Qt's expectations.
- platform/qt/http/tests/security/cross-frame-access-call-expected.txt:
- 7:39 PM Changeset in webkit [59121] by
-
- 1 edit in trunk/WebCore/ChangeLog
Remove conflict markers from ChangeLog
- 7:35 PM Changeset in webkit [59120] by
-
- 3 edits in trunk/LayoutTests
REGRESSION(r59100): Added test is broken on many platforms.
https://bugs.webkit.org/show_bug.cgi?id=38881
Reviewed by Eric Seidel.
- platform/mac-snowleopard/Skipped:
Skipped, because we're not logging NPP_Destroy on Snow Leopard.
- platform/qt/Skipped:
Skipped due to lack of support for setCallCloseOnWebViews on
LayoutTestController.
- 7:35 PM Changeset in webkit [59119] by
-
- 4 edits in trunk
REGRESSION(r59100): Added test is broken on many platforms.
https://bugs.webkit.org/show_bug.cgi?id=38881
Reviewed by Eric Seidel.
WebKitTools:
- DumpRenderTree/win/TestNetscapePlugin/main.cpp:
(NPP_Destroy):
Use pluginLog, rather than printf, to match other platforms.
LayoutTests:
- plugins/geturlnotify-during-document-teardown-expected.txt:
Update the expected result.
- 7:06 PM Changeset in webkit [59118] by
-
- 7 edits1 move3 adds2 deletes in trunk
WebCore: Cleaning up and fixing the existing JSC DB bindings.
https://bugs.webkit.org/show_bug.cgi?id=34994
Reviewed by Brady Eidson.
- bindings/js/JSDOMWindowCustom.cpp:
(WebCore::JSDOMWindow::openDatabase):
- bindings/js/JSDatabaseCustom.cpp:
(WebCore::JSDatabase::changeVersion):
(WebCore::createTransaction):
(WebCore::JSDatabase::transaction):
(WebCore::JSDatabase::readTransaction):
- bindings/js/JSSQLTransactionCustom.cpp:
(WebCore::JSSQLTransaction::executeSql):
LayoutTests: Fixing the expectations for openDatabase() in cross-frame-access-call.html.
Related to changes in patches #6 and #7 at https://bugs.webkit.org/show_bug.cgi?id=34994.
Reviewed by Brady Eidson.
- http/tests/security/cross-frame-access-call-expected.txt:
- http/tests/security/cross-frame-access-call.html:
- platform/chromium-linux/http/tests/security/cross-frame-access-call-expected.txt: Removed.
- platform/chromium-mac/http/tests/security/cross-frame-access-call-expected.txt: Removed.
- platform/chromium-win/http/tests/security/cross-frame-access-call-expected.txt: Removed.
- platform/chromium/http: Added.
- platform/chromium/http/tests: Added.
- platform/chromium/http/tests/security: Added.
- platform/chromium/http/tests/security/cross-frame-access-call-expected.txt: Copied from LayoutTests/platform/chromium-win/http/tests/security/cross-frame-access-call-expected.txt.
- 6:52 PM Changeset in webkit [59117] by
-
- 2 edits in trunk/WebKitTools
2010-05-10 Dirk Pranke <dpranke@chromium.org>
Unreviewed, build fix.
Fix a build failure caused by assuming the default platform in
a unit test for new-run-webkit-tests instead of specifying
--platform test.
- Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
- 6:50 PM Changeset in webkit [59116] by
-
- 9 edits in trunk/WebCore
2010-05-10 Fumitoshi Ukai <ukai@chromium.org>
Reviewed by Alexey Proskuryakov.
WebSocket needs to suspend/resume as Active DOM object.
https://bugs.webkit.org/show_bug.cgi?id=38171
Implement suspend()/resume() in WebSocket and WebSocketChannel.
While WebSocketChannel is suspended, it only adds received data in m_buffer
or record the handle was closed, and report no event to WebSocket.
When resumed, it will process buffer or handle closing.
Since suspend/resume would be called while processing JavaScript event handler (e.g. before/after alert()), WebSocketChannel method that would fire an event need to be reentrant.
So, WebSocketChannel::processBuffer() call WebSocket to fire an event at most once and skips buffer before the calling,
so that next call of processBuffer() would process the next frame.
- websockets/ThreadableWebSocketChannel.h:
- websockets/ThreadableWebSocketChannelClientWrapper.h: (WebCore::ThreadableWebSocketChannelClientWrapper::didConnect): Mark channel is opened, and process pending events if not suspended. (WebCore::ThreadableWebSocketChannelClientWrapper::didReceiveMessage): Push message back in pending queue, and process pending events if not suspended. (WebCore::ThreadableWebSocketChannelClientWrapper::didClose): Mark channel is closed, and process pending events if not suspended. (WebCore::ThreadableWebSocketChannelClientWrapper::suspend): Mark suspended. (WebCore::ThreadableWebSocketChannelClientWrapper::resume): Unmark suspended, and process pending events. (WebCore::ThreadableWebSocketChannelClientWrapper::ThreadableWebSocketChannelClientWrapper): (WebCore::ThreadableWebSocketChannelClientWrapper::processPendingEvents):
- websockets/WebSocket.cpp: (WebCore::WebSocket::canSuspend): (WebCore::WebSocket::suspend): (WebCore::WebSocket::resume): (WebCore::WebSocket::didClose):
- websockets/WebSocket.h:
- websockets/WebSocketChannel.cpp: (WebCore::WebSocketChannel::WebSocketChannel): (WebCore::WebSocketChannel::connect): (WebCore::WebSocketChannel::send): (WebCore::WebSocketChannel::bufferedAmount): (WebCore::WebSocketChannel::close): (WebCore::WebSocketChannel::suspend): (WebCore::WebSocketChannel::resume): When resumed, it will process buffer and handle closing if handle was already closed while suspended. (WebCore::WebSocketChannel::didClose): If suspended, record unhandled bufferedAmount and set m_closed true, so that closing will be processed when resumed. (WebCore::WebSocketChannel::didReceiveData): Add received data in buffer and process buffer while it is not suspended. (WebCore::WebSocketChannel::processBuffer): Process handshake header or one frame message. Return true if there are more data to be processed. Return false otherwise (e.g. incomplete handshake header or incomplete frame).
- websockets/WebSocketChannel.h:
- websockets/WorkerThreadableWebSocketChannel.cpp: (WebCore::WorkerThreadableWebSocketChannel::suspend): (WebCore::WorkerThreadableWebSocketChannel::resume): (WebCore::WorkerThreadableWebSocketChannel::Peer::suspend): (WebCore::WorkerThreadableWebSocketChannel::Peer::resume): (WebCore::WorkerThreadableWebSocketChannel::mainThreadSuspend): (WebCore::WorkerThreadableWebSocketChannel::Bridge::suspend): (WebCore::WorkerThreadableWebSocketChannel::mainThreadResume): (WebCore::WorkerThreadableWebSocketChannel::Bridge::resume):
- websockets/WorkerThreadableWebSocketChannel.h:
- 6:45 PM Changeset in webkit [59115] by
-
- 2 edits in trunk/LayoutTests
2010-05-10 John Gregg <johnnyg@google.com>
[chromium] Fix sort order for expectations after previous change.
- platform/chromium/fast/dom/prototype-inheritance-expected.txt:
- 6:30 PM Changeset in webkit [59114] by
-
- 2 edits in trunk/WebKitTools
2010-05-10 Dirk Pranke <dpranke@chromium.org>
Unreviewed, build-fix
new-run-webkit-tests: fix test failure caused by me failing to update
the expected output. Also, run '--platform test' instead of
'platform dryrun' since the former is guaranteed to work and the
latter isn't.
- Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
- 6:18 PM Changeset in webkit [59113] by
-
- 4 edits in trunk/WebCore
Implement the JSC bindings for the sync DB API.
https://bugs.webkit.org/show_bug.cgi?id=34994
Reviewed by Brady Eidson.
- bindings/js/JSDatabaseSyncCustom.cpp:
(WebCore::JSDatabaseSync::changeVersion):
(WebCore::createTransaction):
- bindings/js/JSSQLTransactionSyncCustom.cpp:
(WebCore::JSSQLTransactionSync::executeSql):
- 6:07 PM Changeset in webkit [59112] by
-
- 2 edits in trunk/LayoutTests
2010-05-10 John Gregg <johnnyg@google.com>
[chromium] Unreviewed, test expectation change for Chromium following r59010.
- platform/chromium/fast/dom/prototype-inheritance-expected.txt:
- 5:44 PM Changeset in webkit [59111] by
-
- 4 edits2 adds in trunk
2010-05-10 Dean Jackson <dino@apple.com>
Reviewed by Simon Fraser.
https://bugs.webkit.org/show_bug.cgi?id=36566
The animation-fill-mode property was missing from
a few places where the animation shorthand is set up.
Test: animations/animation-shorthand-removed.html
- css/CSSMutableStyleDeclaration.cpp: (WebCore::CSSMutableStyleDeclaration::getPropertyValue): Make sure animation-fill-mode is included in the animation shorthand
- css/CSSPropertyLonghand.cpp: (WebCore::initShorthandMap):
- 5:10 PM Changeset in webkit [59110] by
-
- 5 edits4 adds in trunk/WebKit/chromium
2010-05-10 John Abd-El-Malek <jam@chromium.org>
Reviewed by Darin Fisher.
[chromium] Add WebKitScrollbar interface to allow Chromium code to reuse the scrollbar code
https://bugs.webkit.org/show_bug.cgi?id=38854
- public/WebScrollbar.h: Added. (WebKit::WebScrollbar::): (WebKit::WebScrollbar::~WebScrollbar):
- public/WebScrollbarClient.h: Added.
- public/WebThemeEngine.h:
- src/AssertMatchingEnums.cpp:
- src/WebScrollbarImpl.cpp: Added. (WebKit::WebScrollbar::create): (WebKit::WebScrollbar::defaultThickness): (WebKit::WebScrollbarImpl::WebScrollbarImpl): (WebKit::WebScrollbarImpl::~WebScrollbarImpl): (WebKit::WebScrollbarImpl::setLocation): (WebKit::WebScrollbarImpl::value): (WebKit::WebScrollbarImpl::setValue): (WebKit::WebScrollbarImpl::setDocumentSize): (WebKit::WebScrollbarImpl::scroll): (WebKit::WebScrollbarImpl::paint): (WebKit::WebScrollbarImpl::handleInputEvent): (WebKit::WebScrollbarImpl::onMouseDown): (WebKit::WebScrollbarImpl::onMouseUp): (WebKit::WebScrollbarImpl::onMouseMove): (WebKit::WebScrollbarImpl::onMouseLeave): (WebKit::WebScrollbarImpl::onMouseWheel): (WebKit::WebScrollbarImpl::onKeyDown): (WebKit::WebScrollbarImpl::valueChanged): (WebKit::WebScrollbarImpl::invalidateScrollbarRect): (WebKit::WebScrollbarImpl::isActive): (WebKit::WebScrollbarImpl::scrollbarCornerPresent): (WebKit::WebScrollbarImpl::getTickmarks):
- src/WebScrollbarImpl.h: Added.
- src/WebViewImpl.cpp: (WebKit::WebViewImpl::scrollViewWithKeyboard): (WebKit::WebViewImpl::mapKeyCodeForScroll):
- src/WebViewImpl.h:
- 5:08 PM Changeset in webkit [59109] by
-
- 5 edits2 adds in trunk
WebCore: Fix for https://bugs.webkit.org/show_bug.cgi?id=38583
<rdar://problem/7948784> Crash in Element::normalizeAttributes.
Reviewed by Darin Adler.
Test: fast/dom/Element/normalize-crash.html
- dom/Element.cpp:
(WebCore::Element::normalizeAttributes): Copy attributes to a vector
before iterating.
- dom/NamedAttrMap.cpp:
(WebCore::NamedNodeMap::copyAttributesToVector): Added.
- dom/NamedAttrMap.h:
LayoutTests: Test for https://bugs.webkit.org/show_bug.cgi?id=38583
<rdar://problem/7948784> Crash in Element::normalizeAttributes.
Reviewed by Darin Adler.
- fast/dom/Element/normalize-crash-expected.txt: Added.
- fast/dom/Element/normalize-crash.html: Added.
- 5:01 PM Changeset in webkit [59108] by
-
- 3 edits in trunk/WebKitTools
2010-05-10 Dirk Pranke <dpranke@chromium.org>
Reviewed by David Levin.
new-run-webkit-tests: looks like the unicode conversion broke
--print-last-failures and --retest-last-failures. Fixing.
- Scripts/webkitpy/layout_tests/run_webkit_tests.py:
- Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
- 5:00 PM Changeset in webkit [59107] by
-
- 12 edits1 copy2 adds in branches/audio/WebCore
Hook the realtime analyser into the modular routing API
- 5:00 PM Changeset in webkit [59106] by
-
- 6 edits in trunk/WebKitTools
2010-05-10 Dirk Pranke <dpranke@chromium.org>
Reviewed by David Levin.
Re-attempt to fix 38616 - newline handling in new-run-webkit-tests.
I didn't handle some cases correctly before and the solution was
confusing. The new patch assumes all calls to the printing module
don't have newlines, and will append newlines where necessary, just
like logging does.
- Scripts/webkitpy/layout_tests/layout_package/metered_stream.py:
- Scripts/webkitpy/layout_tests/layout_package/metered_stream_unittest.py:
- Scripts/webkitpy/layout_tests/layout_package/printing.py:
- Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
- Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
- 4:58 PM Changeset in webkit [59105] by
-
- 46 edits59 adds6 deletes in trunk/LayoutTests
2010-05-10 John Gregg <johnnyg@google.com>
[chromium] Unreviewed, svg test rebaselines after r59002 for linux.
- platform/chromium-linux/svg/W3C-SVG-1.1/filters-blend-01-b-expected.checksum:
- platform/chromium-linux/svg/W3C-SVG-1.1/filters-blend-01-b-expected.png:
- platform/chromium-linux/svg/W3C-SVG-1.1/filters-blend-01-b-expected.txt: Added.
- platform/chromium-linux/svg/W3C-SVG-1.1/filters-color-01-b-expected.checksum:
- platform/chromium-linux/svg/W3C-SVG-1.1/filters-color-01-b-expected.png:
- platform/chromium-linux/svg/W3C-SVG-1.1/filters-color-01-b-expected.txt: Added.
- platform/chromium-linux/svg/W3C-SVG-1.1/filters-composite-02-b-expected.checksum:
- platform/chromium-linux/svg/W3C-SVG-1.1/filters-composite-02-b-expected.png:
- platform/chromium-linux/svg/W3C-SVG-1.1/filters-composite-02-b-expected.txt: Added.
- platform/chromium-linux/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.checksum:
- platform/chromium-linux/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.png:
- platform/chromium-linux/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.txt: Added.
- platform/chromium-linux/svg/W3C-SVG-1.1/filters-diffuse-01-f-expected.txt: Added.
- platform/chromium-linux/svg/W3C-SVG-1.1/filters-displace-01-f-expected.checksum:
- platform/chromium-linux/svg/W3C-SVG-1.1/filters-displace-01-f-expected.png:
- platform/chromium-linux/svg/W3C-SVG-1.1/filters-displace-01-f-expected.txt: Added.
- platform/chromium-linux/svg/W3C-SVG-1.1/filters-example-01-b-expected.checksum:
- platform/chromium-linux/svg/W3C-SVG-1.1/filters-example-01-b-expected.png:
- platform/chromium-linux/svg/W3C-SVG-1.1/filters-example-01-b-expected.txt: Added.
- platform/chromium-linux/svg/W3C-SVG-1.1/filters-felem-01-b-expected.txt: Added.
- platform/chromium-linux/svg/W3C-SVG-1.1/filters-gauss-01-b-expected.checksum:
- platform/chromium-linux/svg/W3C-SVG-1.1/filters-gauss-01-b-expected.png:
- platform/chromium-linux/svg/W3C-SVG-1.1/filters-gauss-01-b-expected.txt: Added.
- platform/chromium-linux/svg/W3C-SVG-1.1/filters-image-01-b-expected.checksum:
- platform/chromium-linux/svg/W3C-SVG-1.1/filters-image-01-b-expected.png:
- platform/chromium-linux/svg/W3C-SVG-1.1/filters-image-01-b-expected.txt: Added.
- platform/chromium-linux/svg/W3C-SVG-1.1/filters-light-01-f-expected.txt: Added.
- platform/chromium-linux/svg/W3C-SVG-1.1/filters-morph-01-f-expected.checksum:
- platform/chromium-linux/svg/W3C-SVG-1.1/filters-morph-01-f-expected.png:
- platform/chromium-linux/svg/W3C-SVG-1.1/filters-morph-01-f-expected.txt: Added.
- platform/chromium-linux/svg/W3C-SVG-1.1/filters-offset-01-b-expected.checksum:
- platform/chromium-linux/svg/W3C-SVG-1.1/filters-offset-01-b-expected.png: Added.
- platform/chromium-linux/svg/W3C-SVG-1.1/filters-offset-01-b-expected.txt: Added.
- platform/chromium-linux/svg/W3C-SVG-1.1/filters-specular-01-f-expected.txt: Added.
- platform/chromium-linux/svg/W3C-SVG-1.1/filters-tile-01-b-expected.checksum:
- platform/chromium-linux/svg/W3C-SVG-1.1/filters-tile-01-b-expected.png:
- platform/chromium-linux/svg/W3C-SVG-1.1/filters-tile-01-b-expected.txt: Added.
- platform/chromium-linux/svg/W3C-SVG-1.1/filters-turb-01-f-expected.txt: Added.
- platform/chromium-linux/svg/W3C-SVG-1.1/masking-intro-01-f-expected.txt: Added.
- platform/chromium-linux/svg/batik/filters/feTile-expected.checksum:
- platform/chromium-linux/svg/batik/filters/feTile-expected.png:
- platform/chromium-linux/svg/batik/filters/feTile-expected.txt: Added.
- platform/chromium-linux/svg/batik/filters/filterRegions-expected.checksum:
- platform/chromium-linux/svg/batik/filters/filterRegions-expected.png:
- platform/chromium-linux/svg/batik/filters/filterRegions-expected.txt: Added.
- platform/chromium-linux/svg/batik/masking/maskRegions-expected.txt: Added.
- platform/chromium-linux/svg/batik/text/textEffect-expected.checksum:
- platform/chromium-linux/svg/batik/text/textEffect-expected.png: Added.
- platform/chromium-linux/svg/batik/text/textEffect-expected.txt: Added.
- platform/chromium-linux/svg/batik/text/textEffect3-expected.checksum:
- platform/chromium-linux/svg/batik/text/textEffect3-expected.png: Added.
- platform/chromium-linux/svg/batik/text/textEffect3-expected.txt: Added.
- platform/chromium-linux/svg/batik/text/textFeatures-expected.txt: Added.
- platform/chromium-linux/svg/batik/text/textProperties-expected.txt: Added.
- platform/chromium-linux/svg/custom/empty-mask-expected.txt: Added.
- platform/chromium-linux/svg/custom/empty-merge-expected.checksum:
- platform/chromium-linux/svg/custom/empty-merge-expected.png:
- platform/chromium-linux/svg/custom/feComponentTransfer-Discrete-expected.checksum:
- platform/chromium-linux/svg/custom/feComponentTransfer-Discrete-expected.png:
- platform/chromium-linux/svg/custom/feComponentTransfer-Discrete-expected.txt: Added.
- platform/chromium-linux/svg/custom/feComponentTransfer-Gamma-expected.checksum:
- platform/chromium-linux/svg/custom/feComponentTransfer-Gamma-expected.png:
- platform/chromium-linux/svg/custom/feComponentTransfer-Gamma-expected.txt: Added.
- platform/chromium-linux/svg/custom/feComponentTransfer-Linear-expected.checksum:
- platform/chromium-linux/svg/custom/feComponentTransfer-Linear-expected.png:
- platform/chromium-linux/svg/custom/feComponentTransfer-Linear-expected.txt: Added.
- platform/chromium-linux/svg/custom/feComponentTransfer-Table-expected.checksum:
- platform/chromium-linux/svg/custom/feComponentTransfer-Table-expected.png:
- platform/chromium-linux/svg/custom/feComponentTransfer-Table-expected.txt: Added.
- platform/chromium-linux/svg/custom/feDisplacementMap-01-expected.checksum:
- platform/chromium-linux/svg/custom/image-with-transform-clip-filter-expected.checksum:
- platform/chromium-linux/svg/custom/image-with-transform-clip-filter-expected.png: Removed.
- platform/chromium-linux/svg/custom/image-with-transform-clip-filter-expected.txt:
- platform/chromium-linux/svg/custom/invalid-css-expected.txt: Added.
- platform/chromium-linux/svg/custom/mask-invalidation-expected.txt: Added.
- platform/chromium-linux/svg/custom/non-opaque-filters-expected.txt: Added.
- platform/chromium-linux/svg/custom/text-filter-expected.checksum:
- platform/chromium-linux/svg/custom/text-filter-expected.png: Removed.
- platform/chromium-linux/svg/custom/text-filter-expected.txt: Added.
- platform/chromium-linux/svg/custom/visibility-override-filter-expected.checksum: Added.
- platform/chromium-linux/svg/filters/big-sized-filter-2-expected.checksum: Added.
- platform/chromium-linux/svg/filters/big-sized-filter-2-expected.png: Added.
- platform/chromium-linux/svg/filters/big-sized-filter-expected.checksum: Added.
- platform/chromium-linux/svg/filters/big-sized-filter-expected.png: Added.
- platform/chromium-linux/svg/filters/feColorMatrix-values-expected.checksum: Added.
- platform/chromium-linux/svg/filters/feColorMatrix-values-expected.png: Added.
- platform/chromium-linux/svg/filters/feColorMatrix-values-expected.txt: Added.
- platform/chromium-linux/svg/filters/feComposite-expected.checksum:
- platform/chromium-linux/svg/filters/feComposite-expected.png: Removed.
- platform/chromium-linux/svg/filters/feComposite-expected.txt: Added.
- platform/chromium-linux/svg/filters/feGaussianBlur-expected.checksum: Added.
- platform/chromium-linux/svg/filters/feMerge-expected.checksum: Added.
- platform/chromium-linux/svg/filters/feMerge-expected.png: Added.
- platform/chromium-linux/svg/filters/feOffset-expected.checksum: Added.
- platform/chromium-linux/svg/filters/feTile-expected.checksum: Added.
- platform/chromium-linux/svg/filters/feTile-expected.png: Added.
- platform/chromium-linux/svg/filters/filter-on-tspan-expected.checksum:
- platform/chromium-linux/svg/filters/filter-on-tspan-expected.png: Removed.
- platform/chromium-linux/svg/filters/filter-on-tspan-expected.txt: Added.
- platform/chromium-linux/svg/filters/sourceAlpha-expected.txt: Added.
- platform/chromium-linux/svg/filters/subRegion-in-userSpace-expected.checksum: Added.
- platform/chromium-linux/svg/filters/subRegion-in-userSpace-expected.png: Added.
- platform/chromium-linux/svg/filters/subRegion-one-effect-expected.checksum:
- platform/chromium-linux/svg/filters/subRegion-one-effect-expected.png: Removed.
- platform/chromium-linux/svg/filters/subRegion-two-effects-expected.checksum:
- platform/chromium-linux/svg/filters/subRegion-two-effects-expected.png: Removed.
- platform/chromium-linux/svg/text/text-vkern-expected.checksum: Added.
- platform/chromium-linux/svg/text/text-vkern-expected.png: Added.
- 4:38 PM Changeset in webkit [59104] by
-
- 5 edits in trunk/WebCore
[V8] Fix V8 code generator script to generate the correct code for
converting ScriptString.
https://bugs.webkit.org/show_bug.cgi?id=38873
Reviewed by Adam Barth.
Updated the bindings test result. Note that the result is also updated
to reflect other script generator changes not introduced by this patch.
- bindings/scripts/CodeGeneratorV8.pm:
- bindings/scripts/test/JS/JSTestCallback.cpp:
(WebCore::JSTestCallback::JSTestCallback):
(WebCore::JSTestCallback::~JSTestCallback):
- bindings/scripts/test/JS/JSTestCallback.h:
- bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::TestObjInternal::scriptStringAttrAttrGetter):
- 4:35 PM Changeset in webkit [59103] by
-
- 2 edits in trunk/LayoutTests
Add test to GTK skipped list.
Rubber-stamped by Mark Rowe.
- platform/gtk/Skipped:
- 4:14 PM Changeset in webkit [59102] by
-
- 2 edits in trunk/WebCore
Fix the 32-bit WebKit2 build.
- WebCore.base.exp:
- 4:13 PM WebKit Team edited by
- Move tkent to the reviewers section (diff)
- 4:02 PM Changeset in webkit [59101] by
-
- 2 edits in trunk/WebKitTools
2010-05-10 Kent Tamura <tkent@chromium.org>
Reviewed by Adam Barth.
Make tkent a reviewer
https://bugs.webkit.org/show_bug.cgi?id=38875
- Scripts/webkitpy/common/config/committers.py:
- 3:56 PM Changeset in webkit [59100] by
-
- 7 edits3 adds in trunk
Crash closing window containing Flash plug-in
https://bugs.webkit.org/show_bug.cgi?id=38797
<rdar://problem/7935266>
Reviewed by Eric Seidel.
WebCore:
Test: plugins/geturlnotify-during-document-teardown.html
- plugins/PluginView.cpp:
(WebCore::PluginView::load):
Null check the DocumentLoader; it's possible for this to be null while
the Document is being torn down and before the plug-in is destroyed.
WebKitTools:
- DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
(pluginAllocate):
Initialize new member to false.
- DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
Added a new member.
- DumpRenderTree/win/TestNetscapePlugin/main.cpp:
(NPP_New):
Check whether the element has the "testGetURLOnDestroy" attribute, and
record that.
(NPP_Destroy):
If "testGetURLOnDestroy" is set, perform a load while destroying the
plug-in.
LayoutTests:
- plugins/geturlnotify-during-document-teardown.html: Added.
- plugins/resources/geturlnotify-on-destroy.html: Added.
- 3:48 PM Changeset in webkit [59099] by
-
- 3 edits in trunk/WebKitTools
2010-05-10 Eric Seidel <eric@webkit.org>
Reviewed by David Levin.
Executive.kill_* do not work with windows python
https://bugs.webkit.org/show_bug.cgi?id=38872
http://trac.webkit.org/changeset/57444 is where the original
breakage occurred.
http://trac.webkit.org/changeset/58314 is where the regression
started affecting chromium.
I have since learned that sys.platform has no "windows" value.
"win32" is always the value, under 32 or 64 bit windows
The tests for this code are not run anywhere because
test-webkitpy does not yet work on "win32". Mostly due to
depending on unixisms like "cat" and "yes".
- Scripts/webkitpy/common/system/executive.py:
- Scripts/webkitpy/common/system/executive_unittest.py:
- 3:13 PM Changeset in webkit [59098] by
-
- 7 edits2 adds in trunk
Reviewed by Darin Adler.
Based on a patch by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=28697
<rdar://problem/7946578> WebKit crash on WebCore::Node::nodeIndex()
It's not OK to call ContainerNode::willRemoveChild() in a loop, because Range code assumes
that it can adjust start and end position to any node except for the one being removed -
so these notifications cannot be batched.
Test: fast/dom/Range/remove-all-children-crash.html
- dom/ContainerNode.cpp: (WebCore::willRemoveChild): Removed unused ExceptionCode. (WebCore::willRemoveChildren): New function, used in removeChildren() case. (WebCore::ContainerNode::removeChild): ExceptionCode return was always 0, don't bother with it. (WebCore::ContainerNode::removeChildren): Call willRemoveChildrenFromNode. (WebCore::dispatchChildRemovalEvents): Moved some logic out into willRemoveChildrenFromNode and willRemoveChild.
- dom/Document.cpp: (WebCore::Document::nodeChildrenWillBeRemoved): New function, used in removeChildren() case.
- dom/Document.h: (WebCore::Document::nodeChildrenWillBeRemoved): New function, used in removeChildren() case.
- dom/Range.h:
- dom/Range.cpp: (WebCore::boundaryNodeChildrenWillBeRemoved): New function, used in removeChildren() case. (WebCore::Range::nodeChildrenWillBeRemoved): Ditto.
- 2:44 PM Changeset in webkit [59097] by
-
- 6 edits1 add in branches/audio/WebCore
Add custom bindings for attributes which are custom JS objects to avoid compiler warnings/errors
- this is a problem which seems to only occur with the JS (not V8) bindings
- JSAudioMiscCustom.cpp may be temporary until these can be split out into separate files (if necessary)
- 2:34 PM Changeset in webkit [59096] by
-
- 4 edits in trunk/WebCore
Implement the V8 bindings for the sync DB API.
https://bugs.webkit.org.show_bug.cgi?id=34994
Reviewed by Adam Barth.
- bindings/v8/custom/V8DatabaseSyncCustom.cpp:
(WebCore::V8DatabaseSync::changeVersionCallback):
(WebCore::createTransaction):
- bindings/v8/custom/V8SQLTransactionSyncCustom.cpp:
(WebCore::V8SQLTransactionSync::executeSqlCallback):
- bindings/v8/custom/V8WorkerContextCustom.cpp:
(WebCore::V8WorkerContextCustom::openDatabaseSyncCallback):
- 1:46 PM Changeset in webkit [59095] by
-
- 4 edits in trunk/WebCore
Clean up and fix the existing V8 DB bindings.
https://bugs.webkit.org/show_bug.cgi?id=34994
Reviewed by Adam Barth.
- bindings/v8/custom/V8DOMWindowCustom.cpp:
(WebCore::V8DOMWindow::openDatabaseCallback):
- bindings/v8/custom/V8DatabaseCustom.cpp:
(WebCore::V8Database::changeVersionCallback):
(WebCore::createTransaction):
- bindings/v8/custom/V8SQLTransactionCustom.cpp:
(WebCore::V8SQLTransaction::executeSqlCallback):
- 1:03 PM Changeset in webkit [59094] by
-
- 3 edits in trunk/WebCore
[wx] Build fix for wx 2.8 after complex text changes.
- 12:59 PM Changeset in webkit [59093] by
-
- 2 edits in trunk/WebKit/mac
Unbreak the world. (Fix Mac builds).
- Plugins/Hosted/WebKitPluginHostTypes.h:
- 12:53 PM Changeset in webkit [59092] by
-
- 59 edits2 copies4 adds in trunk/LayoutTests
2010-05-07 Dirk Pranke <dpranke@chromium.org>
Reviewed by Eric Seidel.
Add a bunch of windows-specific chromium baselines for the different
versions of windows to update them from a skia change.
- platform/chromium/test_expectations.txt:
- 12:47 PM Changeset in webkit [59091] by
-
- 2 edits1 add in trunk/WebKitTools
2010-05-10 Dirk Pranke <dpranke@chromium.org>
Reviewed by Eric Seidel.
Fix a bug in rebaseline-chromium-webkit-tests where we would crash
instead of logging an error and exiting if it couldn't find either a
debug or a release build of the image diff binary.
- Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
- Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py: Added.
- 12:46 PM Changeset in webkit [59090] by
-
- 3 edits in trunk/WebKitTools
2010-05-10 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
new-run-webkit-tests fails when run under sys.platform == "windows" due to undefined signal.SIGKILL
https://bugs.webkit.org/show_bug.cgi?id=38861
- Scripts/webkitpy/common/system/executive.py:
- Scripts/webkitpy/common/system/executive_unittest.py:
- 12:36 PM Changeset in webkit [59089] by
-
- 2 edits in trunk/WebCore
2010-05-10 John Gregg <johnnyg@google.com>
[chromium] Try to fix the chromium build after r59085 by
including MathExtras.h before using isnan().
https://bugs.webkit.org/show_bug.cgi?id=38860
- html/canvas/WebGLIntegralTypedArrayBase.h:
- 11:59 AM Changeset in webkit [59088] by
-
- 2 edits in trunk/WebCore
[wx] Build fix for wx trunk after complex text changes.
- 11:14 AM Changeset in webkit [59087] by
-
- 15 edits1 add in trunk
2010-05-10 Tony Gentilcore <tonyg@chromium.org>
Reviewed by Adam Barth.
Provide mechanism to cache metadata for a resource
https://bugs.webkit.org/show_bug.cgi?id=37874
No new tests because no new functionality.
- WebCore.gypi:
- loader/CachedMetadata.h: Added. (WebCore::CachedMetadata::create): (WebCore::CachedMetadata::deserialize): (WebCore::CachedMetadata::serialize): (WebCore::CachedMetadata::~CachedMetadata): (WebCore::CachedMetadata::dataTypeID): (WebCore::CachedMetadata::data): (WebCore::CachedMetadata::size): (WebCore::CachedMetadata::readUnsigned): (WebCore::CachedMetadata::appendUnsigned): (WebCore::CachedMetadata::CachedMetadata):
- loader/CachedResource.cpp: (WebCore::CachedResource::setSerializedCachedMetadata): (WebCore::CachedResource::setCachedMetadata): (WebCore::CachedResource::cachedMetadata):
- loader/CachedResource.h:
- loader/ResourceLoader.h: (WebCore::ResourceLoader::didReceiveCachedMetadata):
- loader/SubresourceLoader.cpp: (WebCore::SubresourceLoader::didReceiveCachedMetadata):
- loader/SubresourceLoader.h:
- loader/SubresourceLoaderClient.h: (WebCore::SubresourceLoaderClient::didReceiveCachedMetadata):
- loader/loader.cpp: (WebCore::Loader::Host::didReceiveCachedMetadata):
- loader/loader.h:
- platform/network/ResourceHandle.cpp: (WebCore::ResourceHandle::cacheMetadata):
- platform/network/ResourceHandle.h:
- platform/network/ResourceHandleClient.h: (WebCore::ResourceHandleClient::didReceiveCachedMetadata):
2010-05-10 Tony Gentilcore <tonyg@chromium.org>
Reviewed by Adam Barth.
Provide mechanism to cache metadata for a resource
https://bugs.webkit.org/show_bug.cgi?id=37874
- src/ResourceHandle.cpp: (WebCore::ResourceHandle::cacheMetadata):
- 11:12 AM Changeset in webkit [59086] by
-
- 2 edits in trunk/WebKit/mac
Change the order of the RendererType enum values, so that old versions of WebKitPluginHost will
use accelerated compositing and not layer backed views.
Reviewed by Simon Fraser.
- Plugins/Hosted/WebKitPluginHostTypes.h:
- 10:53 AM Changeset in webkit [59085] by
-
- 18 edits2 adds in trunk/WebCore
2010-05-09 Kenneth Russell <kbr@google.com>
Reviewed by Dimitri Glazkov.
Refactor WebGLArray types to share more code
https://bugs.webkit.org/show_bug.cgi?id=37712
Refactored WebGLArray types for maximal code sharing. Added
WebGLTypedArrayBase and WebGLIntegralTypedArrayBase template
superclasses. Changed overridden virtuals to have minimal
visibility (private instead of public). Fixed const correctness of
a few methods. There are no changes to the public APIs of the
WebGLArray classes; the JavaScript bindings are unchanged.
No new tests; existing tests cover this functionality. Ran all
WebGL layout tests in Safari and Chromium on Mac OS X.
- WebCore.gypi:
- WebCore.xcodeproj/project.pbxproj:
- html/canvas/WebGLArray.h: (WebCore::WebGLArray::buffer): (WebCore::WebGLArray::baseAddress): (WebCore::WebGLArray::byteOffset):
- html/canvas/WebGLByteArray.cpp: (WebCore::WebGLByteArray::create): (WebCore::WebGLByteArray::WebGLByteArray): (WebCore::WebGLByteArray::slice):
- html/canvas/WebGLByteArray.h: (WebCore::WebGLByteArray::isByteArray):
- html/canvas/WebGLFloatArray.cpp: (WebCore::WebGLFloatArray::create): (WebCore::WebGLFloatArray::WebGLFloatArray): (WebCore::WebGLFloatArray::slice):
- html/canvas/WebGLFloatArray.h: (WebCore::WebGLFloatArray::set): (WebCore::WebGLFloatArray::item): (WebCore::WebGLFloatArray::isFloatArray):
- html/canvas/WebGLIntArray.cpp: (WebCore::WebGLIntArray::create): (WebCore::WebGLIntArray::WebGLIntArray): (WebCore::WebGLIntArray::slice):
- html/canvas/WebGLIntArray.h: (WebCore::WebGLIntArray::isIntArray):
- html/canvas/WebGLIntegralTypedArrayBase.h: Added. (WebCore::WebGLIntegralTypedArrayBase::set): (WebCore::WebGLIntegralTypedArrayBase::item): (WebCore::WebGLIntegralTypedArrayBase::WebGLIntegralTypedArrayBase):
- html/canvas/WebGLShortArray.cpp: (WebCore::WebGLShortArray::create): (WebCore::WebGLShortArray::WebGLShortArray): (WebCore::WebGLShortArray::slice):
- html/canvas/WebGLShortArray.h: (WebCore::WebGLShortArray::isShortArray):
- html/canvas/WebGLTypedArrayBase.h: Added. (WebCore::WebGLTypedArrayBase::data): (WebCore::WebGLTypedArrayBase::set): (WebCore::WebGLTypedArrayBase::length): (WebCore::WebGLTypedArrayBase::WebGLTypedArrayBase): (WebCore::WebGLTypedArrayBase::create): (WebCore::WebGLTypedArrayBase::sliceImpl): (WebCore::WebGLTypedArrayBase::byteLength):
- html/canvas/WebGLUnsignedByteArray.cpp: (WebCore::WebGLUnsignedByteArray::create): (WebCore::WebGLUnsignedByteArray::WebGLUnsignedByteArray): (WebCore::WebGLUnsignedByteArray::slice):
- html/canvas/WebGLUnsignedByteArray.h: (WebCore::WebGLUnsignedByteArray::isUnsignedByteArray):
- html/canvas/WebGLUnsignedIntArray.cpp: (WebCore::WebGLUnsignedIntArray::create): (WebCore::WebGLUnsignedIntArray::WebGLUnsignedIntArray): (WebCore::WebGLUnsignedIntArray::slice):
- html/canvas/WebGLUnsignedIntArray.h: (WebCore::WebGLUnsignedIntArray::isUnsignedIntArray):
- html/canvas/WebGLUnsignedShortArray.cpp: (WebCore::WebGLUnsignedShortArray::create): (WebCore::WebGLUnsignedShortArray::WebGLUnsignedShortArray): (WebCore::WebGLUnsignedShortArray::slice):
- html/canvas/WebGLUnsignedShortArray.h: (WebCore::WebGLUnsignedShortArray::isUnsignedShortArray):
- 10:25 AM Changeset in webkit [59084] by
-
- 2 edits in trunk/WebKitTools
Unreviewed.
Adding myself as a committer.
- Scripts/webkitpy/common/config/committers.py:
- 10:12 AM Changeset in webkit [59083] by
-
- 2 edits in trunk/WebCore
Build fix, not reviewed.
Correct post-build copy command for WinCairo port to make sure
cairo headers are available for WebKit.dll build.
- WebCore.vcproj/WebCore.vcproj:
- 9:23 AM Changeset in webkit [59082] by
-
- 7 edits in trunk/LayoutTests
2010-05-10 Dirk Schulze <krit@webkit.org>
Unreviewed.
Further optimization for SVG's repaintRect calculation
https://bugs.webkit.org/show_bug.cgi?id=38820
New baseline for Qt.
- platform/qt/svg/css/circle-in-mask-with-shadow-expected.txt:
- platform/qt/svg/css/mask-with-shadow-expected.txt:
- platform/qt/svg/custom/empty-mask-expected.txt:
- platform/qt/svg/custom/mask-invalidation-expected.txt:
- platform/qt/svg/custom/resource-invalidate-on-target-update-expected.txt:
- platform/qt/svg/custom/transformedMaskFails-expected.txt:
- 8:59 AM Changeset in webkit [59081] by
-
- 26 edits in trunk
2010-05-10 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
Further optimization for SVG's repaintRect calculation
https://bugs.webkit.org/show_bug.cgi?id=38820
This is a further optimization to get smaller repaintRects on SVG objects
in combination with masker or clipper resources.
Masker takes the unite of all stroke boundaries of it's childs.
Both, clipper and masker, store this union to avoid multiple calls of the childs
and the unite calculations now.
The unite rect can be transformed to any targets objectBoundingBox, if the content
unit of the resource is set to objectBoundingBoxMode.
This speeds up the use of resources with multiple target objects.
No behavior changes, the smaller repaintRects cause updates for DRT results.
- rendering/RenderSVGResource.h:
- rendering/RenderSVGResourceClipper.cpp: (WebCore::RenderSVGResourceClipper::invalidateClients): (WebCore::RenderSVGResourceClipper::calculateClipContentRepaintRect): (WebCore::RenderSVGResourceClipper::resourceBoundingBox):
- rendering/RenderSVGResourceClipper.h:
- rendering/RenderSVGResourceFilter.cpp: (WebCore::RenderSVGResourceFilter::resourceBoundingBox):
- rendering/RenderSVGResourceFilter.h:
- rendering/RenderSVGResourceGradient.h: (WebCore::RenderSVGResourceGradient::resourceBoundingBox):
- rendering/RenderSVGResourceMarker.h: (WebCore::RenderSVGResourceMarker::resourceBoundingBox):
- rendering/RenderSVGResourceMasker.cpp: (WebCore::RenderSVGResourceMasker::invalidateClients): (WebCore::RenderSVGResourceMasker::createMaskImage): (WebCore::RenderSVGResourceMasker::calculateMaskContentRepaintRect): (WebCore::RenderSVGResourceMasker::resourceBoundingBox):
- rendering/RenderSVGResourceMasker.h:
- rendering/RenderSVGResourcePattern.h: (WebCore::RenderSVGResourcePattern::resourceBoundingBox):
- rendering/RenderSVGResourceSolidColor.h: (WebCore::RenderSVGResourceSolidColor::resourceBoundingBox):
2010-05-10 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
Further optimization for SVG's repaintRect calculation
https://bugs.webkit.org/show_bug.cgi?id=38820
The repaintRect of SVG objects with masks got smaller. This made
updates of some results necessary.
- platform/mac/svg/W3C-SVG-1.1/masking-intro-01-f-expected.txt:
- platform/mac/svg/batik/masking/maskRegions-expected.txt:
- platform/mac/svg/clip-path/clip-path-with-invisibile-child-expected.txt:
- platform/mac/svg/css/circle-in-mask-with-shadow-expected.txt:
- platform/mac/svg/css/mask-with-shadow-expected.txt:
- platform/mac/svg/custom/empty-mask-expected.txt:
- platform/mac/svg/custom/mask-excessive-malloc-expected.txt:
- platform/mac/svg/custom/mask-inside-defs-expected.txt:
- platform/mac/svg/custom/mask-invalidation-expected.txt:
- platform/mac/svg/custom/mask-with-all-units-expected.txt:
- platform/mac/svg/custom/resource-invalidate-on-target-update-expected.txt:
- platform/mac/svg/custom/visibility-override-mask-expected.txt:
- svg/custom/transformedMaskFails-expected.txt:
- 8:21 AM Changeset in webkit [59080] by
-
- 3 edits in trunk/WebCore
2010-05-11 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Pavel Feldman.
WebInspector: Cosmetic changes.
1) Inner Function Call event of Timer Fire should be merged into parent even if it is not the only child.
2) Standard tooltips for resource links are clashing with Popover.
3) Recalculate Style caller info are duplicating in Details Popover (Caller and Details rows).
https://bugs.webkit.org/show_bug.cgi?id=38732
- inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel.prototype._innerAddRecordToTimeline): (WebInspector.TimelinePanel.FormattedRecord.prototype._generatePopupContent): (WebInspector.TimelinePanel.FormattedRecord.prototype._getRecordDetails):
- inspector/front-end/inspector.js: (WebInspector.linkifyURLAsNode):
- 7:48 AM Changeset in webkit [59079] by
-
- 3 edits in trunk/LayoutTests
2010-05-10 Hans Wennborg <hans@chromium.org>
Reviewed by Jeremy Orlow.
Layout test for Session Storage quota should only expect to fit 39 objects.
https://bugs.webkit.org/show_bug.cgi?id=38843
The script should be ready for the exception when inserting the 40th
element, as that is where it will be thrown if a quota is enforced.
This is the same change as in http://trac.webkit.org/changeset/50979.
- storage/domstorage/quota-expected.txt:
- storage/domstorage/script-tests/quota.js: (testNoQuota):
- 7:36 AM Changeset in webkit [59078] by
-
- 2 edits3 deletes in trunk/LayoutTests
2010-05-10 Adam Langley <agl@chromium.org>
Expectations change. Not reviewed.
Delete the current baselines for the WOFF test because they are
incomplete.
Remove the SKIP tag from test_expectations so that the builders
will run the test and then the rebaseline tool can be used to
checkin real baselines.
- platform/chromium-linux/fast/css/font-face-woff-expected.checksum: Removed.
- platform/chromium-win/fast/css/font-face-woff-expected.checksum: Removed.
- platform/chromium-win/fast/css/font-face-woff-expected.txt: Removed.
- platform/chromium/test_expectations.txt:
- 7:27 AM Changeset in webkit [59077] by
-
- 7 edits in trunk
2010-05-10 Hans Wennborg <hans@chromium.org>
Reviewed by Jeremy Orlow.
[Chromium] Add quota parameter to WebViewClient::createSessionStorageNamespace()
https://bugs.webkit.org/show_bug.cgi?id=38750
Put a per-origin quota on session storage since it is using memory in
the browser process, and should not be allowed to grow arbitrarily
large. See also http://trac.webkit.org/changeset/58828.
- public/WebStorageNamespace.h:
- public/WebViewClient.h: (WebKit::WebViewClient::createSessionStorageNamespace):
- src/StorageNamespaceProxy.cpp: (WebCore::StorageNamespace::sessionStorageNamespace):
2010-05-10 Hans Wennborg <hans@chromium.org>
Reviewed by Jeremy Orlow.
[Chromium] Add quota parameter to WebViewClient::createSessionStorageNamespace()
https://bugs.webkit.org/show_bug.cgi?id=38750
Put a per-origin quota on session storage since it is using memory in
the browser process, and should not be allowed to grow arbitrarily
large. See also http://trac.webkit.org/changeset/58828.
- DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::createSessionStorageNamespace):
- DumpRenderTree/chromium/WebViewHost.h:
- 7:03 AM Changeset in webkit [59076] by
-
- 7 edits1 delete in trunk
[Qt] Roll-out r59020 and r59021, because the Qt part of these changes
haven't been landed in Qt trunk yet. Should be rolled-in again after the merge.
Rubber-stamped by Simon Hausmann.
https://bugs.webkit.org/show_bug.cgi?id=32967
WebCore:
- platform/network/qt/ResourceRequestQt.cpp:
(WebCore::ResourceRequest::toNetworkRequest):
WebKitTools:
- DumpRenderTree/qt/DumpRenderTreeQt.cpp:
(WebCore::WebPage::WebPage):
(WebCore::DumpRenderTree::DumpRenderTree):
- DumpRenderTree/qt/DumpRenderTreeQt.h:
LayoutTests:
- platform/qt/Skipped:
- platform/qt/http/tests/xmlhttprequest/cross-origin-no-authorization-expected.txt: Removed.
- 6:48 AM BuildingQtOnWindows edited by
- add mingw-w64 howto (diff)
- 6:18 AM Changeset in webkit [59075] by
-
- 2 edits in trunk/WebCore
2010-05-10 Markus Goetz <Markus.Goetz@nokia.com>
Reviewed by Simon Hausmann.
Qt after 4.6.3 has its integrated DNS cache. Therefore some
code is not necessary anymore.
- platform/network/qt/DnsPrefetchHelper.h: (WebCore::DnsPrefetchHelper::lookup): (WebCore::DnsPrefetchHelper::lookedUp):
- 6:07 AM Changeset in webkit [59074] by
-
- 2 edits in trunk/JavaScriptCore
2010-05-10 Laszlo Gombos <Laszlo Gombos>
Reviewed by Darin Adler.
[Qt] Disable JIT support for mingw-w64
https://bugs.webkit.org/show_bug.cgi?id=38747
Disale JIT for mingw-w64 as it is reportedly
unstable.
Thanks for Vanboxem Rruben for the investigation.
- wtf/Platform.h:
- 4:53 AM Changeset in webkit [59073] by
-
- 3 edits in trunk/LayoutTests
2010-05-10 Dirk Schulze <krit@webkit.org>
Uneviewed.
SVG FilterEffects need more detailed DRT information
https://bugs.webkit.org/show_bug.cgi?id=38683
New baseline for Win. Only two tests needed an update.
- platform/win/svg/custom/image-with-transform-clip-filter-expected.txt:
- platform/win/svg/filters/feColorMatrix-values-expected.txt:
- 4:40 AM Changeset in webkit [59072] by
-
- 3 edits in trunk/WebCore
2010-05-10 Chris Jerdonek <Chris Jerdonek>
Reviewed by Darin Adler.
Asserted that Node::setDocument() is not being used to change
the document of a node.
- dom/Node.cpp: (WebCore::Node::setDocument): Added an ASSERT at the beginning of the function.
- dom/Node.h: Documented that Node::setDocument() should not be used to change the document of a node until after the node has been removed from its prior document.
- 4:37 AM Changeset in webkit [59071] by
-
- 2 edits in trunk/LayoutTests
2010-05-10 Dirk Schulze <krit@webkit.org>
Unreviewed.
SVG FilterEffects need more detailed DRT information
https://bugs.webkit.org/show_bug.cgi?id=38683
New baseline for Gtk. Just one test needed an update.
- platform/gtk/svg/filters/filter-on-tspan-expected.txt:
- 4:34 AM Changeset in webkit [59070] by
-
- 17 edits in trunk/LayoutTests
2010-05-10 Dirk Schulze <krit@webkit.org>
Unreviewed.
SVG FilterEffects need more detailed DRT information
https://bugs.webkit.org/show_bug.cgi?id=38683
New baseline for Qt.
- platform/qt/svg/custom/resource-invalidate-on-target-update-expected.txt:
- platform/qt/svg/filters/feColorMatrix-values-expected.txt:
- platform/qt/svg/filters/feComposite-expected.txt:
- platform/qt/svg/filters/feGaussianBlur-expected.txt:
- platform/qt/svg/filters/feMerge-expected.txt:
- platform/qt/svg/filters/feOffset-expected.txt:
- platform/qt/svg/filters/feTile-expected.txt:
- platform/qt/svg/filters/filter-clip-expected.txt:
- platform/qt/svg/filters/filter-on-tspan-expected.txt:
- platform/qt/svg/filters/filter-source-position-expected.txt:
- platform/qt/svg/filters/shadow-on-filter-expected.txt:
- platform/qt/svg/filters/shadow-on-rect-with-filter-expected.txt:
- platform/qt/svg/filters/sourceAlpha-expected.txt:
- platform/qt/svg/filters/subRegion-in-userSpace-expected.txt:
- platform/qt/svg/filters/subRegion-one-effect-expected.txt:
- platform/qt/svg/filters/subRegion-two-effects-expected.txt:
- 4:15 AM Changeset in webkit [59069] by
-
- 97 edits in trunk
2010-05-10 Dirk Schulze <krit@webkit.org>
Reviewed by Darin Adler.
SVG FilterEffects need more detailed DRT information
https://bugs.webkit.org/show_bug.cgi?id=38683
All SVG Filter effects get dumped now. The structure of the DRT output
changed. The last effect is shown first, followed by the previous effects.
No changed behaior, so no new test added.
- platform/graphics/filters/FEBlend.cpp: (WebCore::operator<<): (WebCore::FEBlend::externalRepresentation):
- platform/graphics/filters/FEBlend.h:
- platform/graphics/filters/FEColorMatrix.cpp: (WebCore::operator<<): (WebCore::FEColorMatrix::externalRepresentation):
- platform/graphics/filters/FEColorMatrix.h:
- platform/graphics/filters/FEComponentTransfer.cpp: (WebCore::operator<<): (WebCore::FEComponentTransfer::externalRepresentation):
- platform/graphics/filters/FEComponentTransfer.h:
- platform/graphics/filters/FEComposite.cpp: (WebCore::operator<<): (WebCore::FEComposite::externalRepresentation):
- platform/graphics/filters/FEComposite.h: (WebCore::): (WebCore::FEComposite::uniteChildEffectSubregions):
- platform/graphics/filters/FEGaussianBlur.cpp: (WebCore::FEGaussianBlur::externalRepresentation):
- platform/graphics/filters/FEGaussianBlur.h: (WebCore::FEGaussianBlur::uniteChildEffectSubregions):
- platform/graphics/filters/FilterEffect.cpp: (WebCore::FilterEffect::externalRepresentation):
- platform/graphics/filters/FilterEffect.h:
- platform/graphics/filters/SourceAlpha.cpp: (WebCore::SourceAlpha::externalRepresentation):
- platform/graphics/filters/SourceAlpha.h:
- platform/graphics/filters/SourceGraphic.cpp: (WebCore::SourceGraphic::externalRepresentation):
- platform/graphics/filters/SourceGraphic.h:
- rendering/RenderTreeAsText.cpp: (WebCore::writeIndent):
- rendering/RenderTreeAsText.h:
- rendering/SVGRenderTreeAsText.cpp: (WebCore::writeSVGResourceContainer):
- svg/graphics/filters/SVGFEConvolveMatrix.cpp: (WebCore::operator<<): (WebCore::FEConvolveMatrix::externalRepresentation):
- svg/graphics/filters/SVGFEConvolveMatrix.h:
- svg/graphics/filters/SVGFEDiffuseLighting.cpp: (WebCore::FEDiffuseLighting::externalRepresentation):
- svg/graphics/filters/SVGFEDiffuseLighting.h:
- svg/graphics/filters/SVGFEDisplacementMap.cpp: (WebCore::operator<<): (WebCore::FEDisplacementMap::externalRepresentation):
- svg/graphics/filters/SVGFEDisplacementMap.h:
- svg/graphics/filters/SVGFEFlood.cpp: (WebCore::FEFlood::externalRepresentation):
- svg/graphics/filters/SVGFEFlood.h:
- svg/graphics/filters/SVGFEImage.cpp: (WebCore::FEImage::externalRepresentation):
- svg/graphics/filters/SVGFEImage.h:
- svg/graphics/filters/SVGFEMerge.cpp: (WebCore::FEMerge::externalRepresentation):
- svg/graphics/filters/SVGFEMerge.h:
- svg/graphics/filters/SVGFEMorphology.cpp: (WebCore::operator<<): (WebCore::FEMorphology::externalRepresentation):
- svg/graphics/filters/SVGFEMorphology.h:
- svg/graphics/filters/SVGFEOffset.cpp: (WebCore::FEOffset::externalRepresentation):
- svg/graphics/filters/SVGFEOffset.h:
- svg/graphics/filters/SVGFESpecularLighting.cpp: (WebCore::FESpecularLighting::externalRepresentation):
- svg/graphics/filters/SVGFESpecularLighting.h:
- svg/graphics/filters/SVGFETile.cpp: (WebCore::FETile::externalRepresentation):
- svg/graphics/filters/SVGFETile.h:
- svg/graphics/filters/SVGFETurbulence.cpp: (WebCore::operator<<): (WebCore::FETurbulence::externalRepresentation):
- svg/graphics/filters/SVGFETurbulence.h:
2010-05-10 Dirk Schulze <krit@webkit.org>
Reviewed by Darin Adler.
SVG FilterEffects need more detailed DRT information
https://bugs.webkit.org/show_bug.cgi?id=38683
All SVG Filter effects get dumped now. The structure of the DRT output
changed. The last effect is shown first, followed by the previous effects.
- platform/mac/svg/W3C-SVG-1.1/filters-blend-01-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/filters-color-01-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/filters-composite-02-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/filters-conv-01-f-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/filters-diffuse-01-f-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/filters-displace-01-f-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/filters-example-01-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/filters-felem-01-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/filters-gauss-01-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/filters-image-01-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/filters-light-01-f-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/filters-morph-01-f-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/filters-offset-01-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/filters-specular-01-f-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/filters-tile-01-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/filters-turb-01-f-expected.txt:
- platform/mac/svg/batik/filters/feTile-expected.txt:
- platform/mac/svg/batik/filters/filterRegions-expected.txt:
- platform/mac/svg/batik/text/textEffect-expected.txt:
- platform/mac/svg/batik/text/textEffect3-expected.txt:
- platform/mac/svg/batik/text/textFeatures-expected.txt:
- platform/mac/svg/batik/text/textProperties-expected.txt:
- platform/mac/svg/custom/empty-merge-expected.txt:
- platform/mac/svg/custom/feComponentTransfer-Discrete-expected.txt:
- platform/mac/svg/custom/feComponentTransfer-Gamma-expected.txt:
- platform/mac/svg/custom/feComponentTransfer-Linear-expected.txt:
- platform/mac/svg/custom/feComponentTransfer-Table-expected.txt:
- platform/mac/svg/custom/feDisplacementMap-01-expected.txt:
- platform/mac/svg/custom/image-with-transform-clip-filter-expected.txt:
- platform/mac/svg/custom/invalid-css-expected.txt:
- platform/mac/svg/custom/non-opaque-filters-expected.txt:
- platform/mac/svg/custom/resource-invalidate-on-target-update-expected.txt:
- platform/mac/svg/custom/text-filter-expected.txt:
- platform/mac/svg/custom/visibility-override-filter-expected.txt:
- platform/mac/svg/filters/big-sized-filter-2-expected.txt:
- platform/mac/svg/filters/big-sized-filter-expected.txt:
- platform/mac/svg/filters/feColorMatrix-values-expected.txt:
- platform/mac/svg/filters/feComposite-expected.txt:
- platform/mac/svg/filters/feDisplacementMap-expected.txt:
- platform/mac/svg/filters/feGaussianBlur-expected.txt:
- platform/mac/svg/filters/feMerge-expected.txt:
- platform/mac/svg/filters/feOffset-expected.txt:
- platform/mac/svg/filters/feTile-expected.txt:
- platform/mac/svg/filters/filter-clip-expected.txt:
- platform/mac/svg/filters/filter-on-tspan-expected.txt:
- platform/mac/svg/filters/filter-source-position-expected.txt:
- platform/mac/svg/filters/filterRes-expected.txt:
- platform/mac/svg/filters/shadow-on-filter-expected.txt:
- platform/mac/svg/filters/shadow-on-rect-with-filter-expected.txt:
- platform/mac/svg/filters/sourceAlpha-expected.txt:
- platform/mac/svg/filters/subRegion-in-userSpace-expected.txt:
- platform/mac/svg/filters/subRegion-one-effect-expected.txt:
- platform/mac/svg/filters/subRegion-two-effects-expected.txt:
- 2:53 AM Changeset in webkit [59068] by
-
- 29 edits4 copies2 adds2 deletes in trunk
2010-05-10 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Nate Chapin.
Change IndexedDB to use events instead of callbacks
https://bugs.webkit.org/show_bug.cgi?id=38594
Switch IndexedDB over to an event based model to match what
Mozilla (and probably MS?) are doing. This also gets rid of
a lot of template mess at the expense of a little extra boiler
plate code (for each type that IDBResult.result could be).
This change also introduces JSC bindings that match the level of
functionality the V8 bindings have.
Still not testable, but that shoudl change shortly.
- DerivedSources.cpp:
- DerivedSources.make:
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pri:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSEventCustom.cpp:
- bindings/js/JSIDBRequestCustom.cpp: Added. (WebCore::JSIDBRequest::result):
- bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::convertEventTargetToV8Object):
- bindings/v8/custom/V8CustomIDBCallbacks.h: Removed.
- bindings/v8/custom/V8IDBRequestCustom.cpp: Added. (WebCore::V8IDBRequest::resultAccessorGetter):
- bindings/v8/custom/V8IndexedDatabaseRequestCustom.cpp: Removed.
- dom/EventTarget.cpp: (WebCore::EventTarget::toIDBRequest):
- dom/EventTarget.h:
- storage/IDBCallbacks.h:
- storage/IDBDatabaseRequest.h: (WebCore::IDBDatabaseRequest::createObjectStore):
- storage/IDBRequest.cpp: Added. (WebCore::IDBRequest::IDBRequest): (WebCore::IDBRequest::~IDBRequest): (WebCore::IDBRequest::idbDatabaseResult): (WebCore::IDBRequest::serializedScriptValueResult): (WebCore::IDBRequest::onError): (WebCore::IDBRequest::onSuccess): (WebCore::IDBRequest::abort): (WebCore::IDBRequest::scriptExecutionContext): (WebCore::IDBRequest::stop): (WebCore::IDBRequest::suspend): (WebCore::IDBRequest::resume): (WebCore::IDBRequest::eventTargetData): (WebCore::IDBRequest::ensureEventTargetData): (WebCore::IDBRequest::timerFired): (WebCore::IDBRequest::onEventCommon):
- storage/IDBRequest.h: Added. (WebCore::IDBRequest::create): (WebCore::IDBRequest::): (WebCore::IDBRequest::resultType): (WebCore::IDBRequest::readyState): (WebCore::IDBRequest::error): (WebCore::IDBRequest::toIDBRequest): (WebCore::IDBRequest::refEventTarget): (WebCore::IDBRequest::derefEventTarget):
- storage/IDBRequest.idl: Added.
- storage/IndexedDatabase.h:
- storage/IndexedDatabaseImpl.cpp: (WebCore::IndexedDatabaseImpl::open):
- storage/IndexedDatabaseImpl.h:
- storage/IndexedDatabaseRequest.cpp: (WebCore::IndexedDatabaseRequest::open):
- storage/IndexedDatabaseRequest.h:
- storage/IndexedDatabaseRequest.idl:
2010-05-10 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Nate Chapin.
Change IndexedDB to use events instead of callbacks
https://bugs.webkit.org/show_bug.cgi?id=38594
Change the glue here to match the changes I made in WebCore.
- WebKit.gyp:
- public/WebIDBCallbacks.h:
- public/WebIndexedDatabase.h:
- src/IDBCallbacksProxy.cpp: Added. (WebCore::IDBCallbacksProxy::IDBCallbacksProxy): (WebCore::IDBCallbacksProxy::~IDBCallbacksProxy): (WebCore::IDBCallbacksProxy::onError): (WebCore::IDBCallbacksProxy::onSuccess):
- src/IDBCallbacksProxy.h:
- src/IndexedDatabaseProxy.cpp: (WebCore::IndexedDatabaseProxy::open):
- src/IndexedDatabaseProxy.h:
- src/WebIndexedDatabaseImpl.cpp: (WebKit::WebIndexedDatabaseImpl::open):
- src/WebIndexedDatabaseImpl.h:
- 12:02 AM Changeset in webkit [59067] by
-
- 5 edits in trunk/JavaScriptCore
2010-05-09 Fumitoshi Ukai <ukai@chromium.org>
Reviewed by Eric Seidel.
JavaScriptCore/wtf/MD5.h: checksum should take a reference to output.
https://bugs.webkit.org/show_bug.cgi?id=38723
- JavaScriptCore.exp:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- wtf/MD5.cpp: (WTF::expectMD5): Fix for checksum change. (WTF::MD5::checksum): Take a reference to output, instead of returning the result by value, to reduce coping for performance.
- wtf/MD5.h:
May 9, 2010:
- 10:07 PM Changeset in webkit [59066] by
-
- 4 edits in trunk/LayoutTests
Unreviewed, test expectation update.
Update Chromium/Linux expectation for fast/forms/input-file-re-render.html.
http://crbug.com/40027
- platform/chromium-linux/fast/forms/input-file-re-render-expected.checksum:
- platform/chromium-linux/fast/forms/input-file-re-render-expected.png:
- platform/chromium/test_expectations.txt:
- 7:17 PM Changeset in webkit [59065] by
-
- 2 edits in trunk/JavaScriptCore
Fix accidental repeat addition of emit_op_new_regexp
- 6:41 PM Changeset in webkit [59064] by
-
- 14 edits2 moves1 add1 delete in trunk
2010-05-09 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Reserve a large-ish initial capacity for Lexer::m_buffer16.
SunSpider says 0.3% faster.
m_buffer16 is used when parsing complex strings -- for example, strings
with escape sequences in them. These kinds of strings can be really long,
and we want to avoid repeatedly copying as we grow m_buffer16.
The net memory cost is quite low, since it's proporitional to source
code we already have in memory, and we throw away m_buffer16 right when
we're done parsing.
- parser/Lexer.cpp: (JSC::Lexer::Lexer): No need to reserve initial capacity in our constructor, since setCode will be called before we're asked to lex anything. (JSC::Lexer::setCode): Reserve enough space to lex half the source code as a complex string without having to copy. (JSC::Lexer::clear): No need to reserve initial capacity here either, since setCode will be called before we're asked to lex anything.
2010-05-09 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
REGRESSION(r57955): RegExp literals should not actually be cached, so r57955 should be rolled out.
https://bugs.webkit.org/show_bug.cgi?id=38828
Replace incorrect test for caching regexp literals with ones that tests that they are not cached.
- fast/js/regexp-literals-are-constants-expected.txt: Removed.
- fast/js/regexp-literals-are-constants.html: Removed.
- fast/js/regexp-literals-arent-constants-expected.txt: Added.
- fast/js/regexp-literals-arent-constants.html: Added.
- fast/js/script-tests/regexp-literals-are-constants.js: Removed.
- fast/js/script-tests/regexp-literals-arent-constants.js: Added. (test1): (returnRegExpLiteral): (returnConditionalRegExpLiteral):
- 3:09 PM Changeset in webkit [59063] by
-
- 3 edits in trunk/WebCore
2010-05-10 Ilya Tikhonovsky <loislo@chromium.org>
Not reviewed: rollback the commit r59062
- inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel.prototype._innerAddRecordToTimeline): (WebInspector.TimelinePanel.FormattedRecord.prototype._generatePopupContent): (WebInspector.TimelinePanel.FormattedRecord.prototype._getRecordDetails):
- inspector/front-end/inspector.js: (WebInspector.linkifyURLAsNode):
- 2:38 PM Changeset in webkit [59062] by
-
- 3 edits in trunk/WebCore
2010-05-10 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Pavel Feldman.
WebInspector: Cosmetic changes.
1) Inner Function Call event of Timer Fire should be merged into parent even if it is not the only child.
2) Standard tooltips for resource links are clashing with Popover.
3) Recalculate Style caller info are duplicating in Details Popover (Caller and Details rows).
https://bugs.webkit.org/show_bug.cgi?id=38732
- inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel.prototype._innerAddRecordToTimeline): (WebInspector.TimelinePanel.FormattedRecord.prototype._generatePopupContent): (WebInspector.TimelinePanel.FormattedRecord.prototype._getRecordDetails):
- inspector/front-end/inspector.js: (WebInspector.linkifyURLAsNode):
- 2:16 PM Changeset in webkit [59061] by
-
- 2 edits in trunk/JavaScriptCore
Reserve a large-ish initial capacity for Lexer::m_buffer16.
Reviewed by Oliver Hunt.
SunSpider says 0.3% faster.
m_buffer16 is used when parsing complex strings -- for example, strings
with escape sequences in them. These kinds of strings can be really long,
and we want to avoid repeatedly copying as we grow m_buffer16.
The net memory cost is quite low, since it's proporitional to source
code we already have in memory, and we throw away m_buffer16 right when
we're done parsing.
- parser/Lexer.cpp:
(JSC::Lexer::Lexer): No need to reserve initial capacity in our constructor,
since setCode will be called before we're asked to lex anything.
(JSC::Lexer::setCode): Reserve enough space to lex half the source code
as a complex string without having to copy.
(JSC::Lexer::clear): No need to reserve initial capacity here either,
since setCode will be called before we're asked to lex anything.
- 2:11 PM Changeset in webkit [59060] by
-
- 2 edits in trunk/JavaScriptCore
2010-05-09 Laszlo Gombos <Laszlo Gombos>
Reviewed by Eric Seidel.
[Qt] Remove YARR configuration rules from Qt make system
https://bugs.webkit.org/show_bug.cgi?id=38819
Setting YARR based on JIT seeting is now in Platform.h
for all ports. This patch essentially reverses r49238.
- JavaScriptCore.pri:
- 1:58 PM Changeset in webkit [59059] by
-
- 2 edits in trunk/WebCore
2010-05-08 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Pavel Feldman.
WebInspector: If some record is not in visible area then it's expand element also is not
visible even if it has children in visible area.
https://bugs.webkit.org/show_bug.cgi?id=38643
- inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel): (WebInspector.TimelinePanel.prototype._refreshRecords):
- 1:34 PM Changeset in webkit [59058] by
-
- 5 edits in trunk/WebCore
Fix for https://bugs.webkit.org/show_bug.cgi?id=38557
r58526 introduced a ~30% regression on Dromaeo JS lib
Reviewed by Darin Adler.
This fix does two things.
- Don't use QualifiedName as the key to a HashMap, use a RefPtr<QualifiedNameImpl> instead. We should remove the HashTraits for QualifiedName and that will happen in a follow up patch.
- Only mark cached NodeLists on Documents instead of all Nodes. This is okay since the marking of NodeLists is an optimization to keep NodeList wrappers alive and is not mandated by any spec.
- bindings/js/JSDocumentCustom.cpp:
(WebCore::JSDocument::markChildren):
- bindings/js/JSNodeCustom.cpp:
(WebCore::JSNode::markChildren):
- dom/Node.cpp:
(WebCore::Node::removeCachedTagNodeList):
(WebCore::Node::getElementsByTagNameNS):
- dom/NodeRareData.h:
- 9:37 AM Changeset in webkit [59057] by
-
- 2 edits in trunk/WebKit/qt
2010-05-09 Noam Rosenthal <noam.rosenthal@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Crash in QGraphicsWebViewPrivate::~QGraphicsWebViewPrivate when animation were used
https://bugs.webkit.org/show_bug.cgi?id=38574
The fix uses a QWeakPointer for rootGraphicsLayer, protecting from a crash in case the layer is deleted before the QGraphicsWebView.
- Api/qgraphicswebview.cpp: (QGraphicsWebViewPrivate::QGraphicsWebViewPrivate): (QGraphicsWebViewPrivate::~QGraphicsWebViewPrivate): (QGraphicsWebViewPrivate::setRootGraphicsLayer): (QGraphicsWebViewPrivate::updateCompositingScrollPosition):
- 4:42 AM Changeset in webkit [59056] by
-
- 7 edits in trunk/JavaScriptCore
2010-05-09 Oliver Hunt <oliver@apple.com>
Reviewed by Maciej Stachowiak.
Improve string indexing performance
https://bugs.webkit.org/show_bug.cgi?id=38814
Add an assembly stub to do indexed loads from strings much
more cheaply than the current stub dispatch logic. We can
do this because we are able to make guarantees about the
register contents when entering the stub so the call overhead
is negligible.
- jit/JIT.h:
- jit/JITInlineMethods.h:
- jit/JITOpcodes.cpp:
- jit/JITPropertyAccess.cpp: (JSC::JIT::stringGetByValStubGenerator): (JSC::JIT::emitSlow_op_get_by_val):
Moved from JITOpcodes.cpp to keep the slowcase next to
the normal case codegen as we do for everything else.
- jit/JITPropertyAccess32_64.cpp: (JSC::JIT::stringGetByValStubGenerator): (JSC::JIT::emitSlow_op_get_by_val):
- jit/JSInterfaceJIT.h: (JSC::JSInterfaceJIT::emitFastArithImmToInt):
- 4:18 AM Changeset in webkit [59055] by
-
- 3 edits in trunk/JavaScriptCore
2010-05-09 Maciej Stachowiak <mjs@apple.com>
Fixed version of: "Optimized o[s] where o is a cell and s is a string"
https://bugs.webkit.org/show_bug.cgi?id=38815
Fixed the previous patch for this from Geoff Garen.
The two problems were a missing exception check and a PropertySlot
initialized improperly, leading to crashes and failures in the case
of getters accessed with bracket syntax.
Previous patch:
Optimized o[s] where o is a cell and s is a string, removing some old
code that wasn't really tuned for the JIT.
SunSpider says 0.8% faster.
- jit/JITStubs.cpp: (JSC::DEFINE_STUB_FUNCTION):
- runtime/JSCell.h:
- 3:24 AM Changeset in webkit [59054] by
-
- 1 edit1 delete in trunk/LayoutTests
2010-05-09 Robert Hogan <robert@webkit.org>
[Qt] Update expected results for unskipped editing/inserting tests
Unreviewed, remove platform-specific results for editing/inserting/6633727.html
- platform/qt/editing/inserting/6633727-expected.txt: Removed.
- 3:15 AM Changeset in webkit [59053] by
-
- 97 edits5 adds in trunk/LayoutTests
[Qt] Update expected results for unskipped editing/inserting tests
Unreviewed, add expected results for unskipped tests. Results are taken
from Qt bot.
- 2:52 AM Changeset in webkit [59052] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unskip editing/inserting tests that fail due to x/y differences
2010-05-03 Robert Hogan <robert@webkit.org>
Reviewed by Eric Seidel.
[Qt] Unskip editing/inserting tests that fail due to x/y differences
Unskip the following tests:
editing/inserting/12882.html
editing/inserting/4840662.html
editing/inserting/4875189-1.html
editing/inserting/4959067.html
editing/inserting/4960120-2.html
editing/inserting/5002441.html
editing/inserting/5058163-2.html
editing/inserting/5156401-2.html
editing/inserting/5418891.html
editing/inserting/5510537.html
editing/inserting/5549929-2.html
editing/inserting/5549929-3.html
editing/inserting/6633727.html
editing/inserting/6703873.html
editing/inserting/editable-inline-element.html
editing/inserting/insert-3654864-fix.html
editing/inserting/insert-3659587-fix.html
editing/inserting/insert-3775316-fix.html
editing/inserting/insert-3778059-fix.html
editing/inserting/insert-3786362-fix.html
editing/inserting/insert-3800346-fix.html
editing/inserting/insert-3851164-fix.html
editing/inserting/insert-3907422-fix.html
editing/inserting/insert-after-delete-001.html
editing/inserting/insert-at-end-01.html
editing/inserting/insert-at-end-02.html
editing/inserting/insert-before-link-1.html
editing/inserting/insert-br-001.html
editing/inserting/insert-br-002.html
editing/inserting/insert-br-003.html
editing/inserting/insert-br-004.html
editing/inserting/insert-br-005.html
editing/inserting/insert-br-006.html
editing/inserting/insert-br-007.html
editing/inserting/insert-br-008.html
editing/inserting/insert-br-009.html
editing/inserting/insert-br-at-tabspan-001.html
editing/inserting/insert-br-at-tabspan-002.html
editing/inserting/insert-br-at-tabspan-003.html
editing/inserting/insert-br-quoted-001.html
editing/inserting/insert-br-quoted-002.html
editing/inserting/insert-br-quoted-003.html
editing/inserting/insert-br-quoted-004.html
editing/inserting/insert-br-quoted-005.html
editing/inserting/insert-br-quoted-006.html
editing/inserting/insert-div-001.html
editing/inserting/insert-div-002.html
editing/inserting/insert-div-003.html
editing/inserting/insert-div-004.html
editing/inserting/insert-div-005.html
editing/inserting/insert-div-006.html
editing/inserting/insert-div-007.html
editing/inserting/insert-div-008.html
editing/inserting/insert-div-009.html
editing/inserting/insert-div-010.html
editing/inserting/insert-div-011.html
editing/inserting/insert-div-012.html
editing/inserting/insert-div-013.html
editing/inserting/insert-div-014.html
editing/inserting/insert-div-015.html
editing/inserting/insert-div-016.html
editing/inserting/insert-div-017.html
editing/inserting/insert-div-018.html
editing/inserting/insert-div-019.html
editing/inserting/insert-div-020.html
editing/inserting/insert-div-021.html
editing/inserting/insert-div-022.html
editing/inserting/insert-div-024.html
editing/inserting/insert-div-025.html
editing/inserting/insert-div-026.html
editing/inserting/insert-div-027.html
editing/inserting/insert-paragraph-01.html
editing/inserting/insert-paragraph-02.html
editing/inserting/insert-paragraph-03.html
editing/inserting/insert-paragraph-04.html
editing/inserting/insert-paragraph-05.html
editing/inserting/insert-space-in-empty-doc.html
editing/inserting/insert-tab-001.html
editing/inserting/insert-tab-002.html
editing/inserting/insert-tab-004.html
editing/inserting/insert-text-at-tabspan-001.html
editing/inserting/insert-text-at-tabspan-002.html
editing/inserting/insert-text-at-tabspan-003.html
editing/inserting/line-break.html
editing/inserting/paragraph-separator-01.html
editing/inserting/paragraph-separator-02.html
editing/inserting/paragraph-separator-in-table-1.html
editing/inserting/paragraph-separator-in-table-2.html
editing/inserting/redo.html
editing/inserting/return-key-with-selection-003.html
editing/inserting/typing-001.html
editing/inserting/typing-002.html
editing/inserting/typing-003.html
editing/inserting/typing-around-br-001.html
editing/inserting/typing-around-image-001.html
editing/inserting/5058163-1.html
editing/inserting/edited-whitespace-1.html
editing/inserting/paragraph-separator-03.html
editing/inserting/return-key-with-selection-001.html
editing/inserting/return-key-with-selection-002.html
editing/inserting/4875189-2.html
- platform/qt/Skipped:
- 2:50 AM Changeset in webkit [59051] by
-
- 2 edits in trunk/WebKitTools
2010-05-09 Daniel Bates <dbates@rim.com>
Reviewed by Chris Jerdonek.
Make the regular expressions for parsing the start of an SVN
and Git header global variables since they are used throughout
VCSUtils.pm.
- Scripts/VCSUtils.pm:
- 2:08 AM Changeset in webkit [59050] by
-
- 3 edits in trunk
2010-05-07 Daniel Bates <dbates@rim.com>
Unreviewed, change log fix.
Add back some entries inadvertently deleted in changeset 59000
<http://trac.webkit.org/changeset/59000> and not restored (as
intended) in changeset 59005 <http://trac.webkit.org/changeset/59005>.
- 1:42 AM Changeset in webkit [59049] by
-
- 1 edit in trunk/JavaScriptCore/ChangeLog
Add back some entries accidentally deleted in r59000 and not restored as intended in r59005.
- 12:21 AM Changeset in webkit [59048] by
-
- 7 edits in trunk/WebKitTools
2010-05-09 Chris Jerdonek <Chris Jerdonek>
Reviewed by Daniel Bates.
Finished moving the header-parsing logic from svn-apply and -unapply
to VCSUtils.pm's parsing methods.
- Scripts/VCSUtils.pm:
- Added to parseGitDiffHeader() the ability to parse and store whether a file is new or deleted.
- Also reordered in parseGitDiffHeader() some of the else statements to a more readable ordering.
- Added to parseSvnDiffHeader() the ability to parse and store whether a file is new.
- Scripts/svn-apply:
- Changed handleGitBinaryChange() to use the new "isNew" and "isDeletion" diffHash key-values.
- Changed patch() to use the new "isNew" diffHash key-value.
- Scripts/svn-unapply:
- Changed patch() to use the new "isNew" and "isDeletion" diffHash key-values.
- Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl:
- Added unit tests for new and deleted files.
- Scripts/webkitperl/VCSUtils_unittest/parseGitDiffHeader.pl:
- Updated the unit tests as necessary.
- Added a unit test for a deleted file.
- Scripts/webkitperl/VCSUtils_unittest/parseSvnDiffHeader.pl:
- Updated the unit tests as necessary.
