Timeline
Sep 26, 2010:
- 11:24 PM Changeset in webkit [68373] by
-
- 4 edits4 adds in trunk
2010-09-26 Jenn Braithwaite <jennb@chromium.org>
Reviewed by Adam Barth.
GTK client needs updating when live iframe element is moved
between pages.
https://bugs.webkit.org/show_bug.cgi?id=46300
This test case fails on mac (see related bug 44713), which will
be fixed in a separate patch.
- fast/frames/iframe-reparenting-adopt-node-expected.txt: Added.
- fast/frames/iframe-reparenting-adopt-node.html: Added.
- fast/frames/resources/iframe-reparenting-adopt-node-iframe-content.html: Added.
- fast/frames/resources/iframe-reparenting-adopt-node-new-page.html: Added.
- platform/mac/Skipped:
2010-09-26 Jenn Braithwaite <jennb@chromium.org>
Reviewed by Adam Barth.
GTK client needs updating when live iframe element is moved
between pages.
https://bugs.webkit.org/show_bug.cgi?id=46300
Test: fast/frames/iframe-reparenting-adopt-node.html
- WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::didTransferChildFrameToNewDocument): Update the webView for the frame to match the parent frame's webView.
- 11:11 PM Changeset in webkit [68372] by
-
- 3 edits2 deletes in trunk/LayoutTests
2010-09-26 Victor Wang <victorw@chromium.org>
Reviewed by Adam Barth.
Update layout test notification-replace.html to be platform independent.
This layout test fails on windows if it is not running from C drive.
This is caused by local icon urls used by the test and this makes the
test becomes platform dependent. Change the icon urls so that the test
results are same for all platforms.
- fast/notifications/notifications-replace-expected.txt:
- fast/notifications/notifications-replace.html:
- platform/chromium-linux/fast/notifications: Removed.
- platform/chromium-linux/fast/notifications/notifications-replace-expected.txt: Removed.
- platform/chromium-win/fast/notifications: Removed.
- platform/chromium-win/fast/notifications/notifications-replace-expected.txt: Removed.
- 11:05 PM Changeset in webkit [68371] by
-
- 4 edits1 delete in trunk/WebCore
2010-09-26 Patrick Gansterer <Patrick Gansterer>
Reviewed by Adam Barth.
Remove dead code and fix header includes in ResourceHandleWin
https://bugs.webkit.org/show_bug.cgi?id=46479
Also add missing member varibale from r68167.
- platform/network/ResourceHandle.h:
- platform/network/ResourceHandleInternal.h: (WebCore::ResourceHandleInternal::ResourceHandleInternal):
- platform/network/win/ResourceHandleWin.cpp: (WebCore::ResourceHandleInternal::~ResourceHandleInternal): (WebCore::ResourceHandle::~ResourceHandle): (WebCore::ResourceHandle::onRequestComplete):
- platform/network/win/ResourceHandleWin.h: Removed.
- 10:59 PM Changeset in webkit [68370] by
-
- 2 edits in trunk/LayoutTests
2010-09-26 Andrei Popescu <andreip@google.com>
Reviewed by Adam Barth.
[Chromium] storage/indexeddb/transaction-basics.html is expected to fail but actually passes.
https://bugs.webkit.org/show_bug.cgi?id=46484
- platform/chromium/test_expectations.txt:
- 10:28 PM Changeset in webkit [68369] by
-
- 5 edits in trunk
2010-09-26 Patrick Gansterer <Patrick Gansterer>
Reviewed by Adam Barth.
Add WTF::StringHasher::createBlobHash
https://bugs.webkit.org/show_bug.cgi?id=46514
Add this function for hashing FormElementKey and QualifiedNameComponents.
- wtf/StringHashFunctions.h: (WTF::StringHasher::createBlobHash):
2010-09-26 Patrick Gansterer <Patrick Gansterer>
Reviewed by Adam Barth.
Add WTF::StringHasher::createBlobHash
https://bugs.webkit.org/show_bug.cgi?id=46514
Add this function for hashing FormElementKey and QualifiedNameComponents.
- dom/Document.cpp: (WebCore::FormElementKeyHash::hash):
- dom/QualifiedName.h: (WebCore::hashComponents): (WebCore::QualifiedNameHash::hash):
- 10:09 PM Changeset in webkit [68368] by
-
- 2 edits in trunk/JavaScriptCore
2010-09-26 Patrick Gansterer <Patrick Gansterer>
Reviewed by Adam Barth.
REGRESSION (r68289): Assertion failure in StringHasher::addCharacter() (ch != invalidCharacterValue)
running websocket/tests/bad-sub-protocol-non-ascii.html
https://bugs.webkit.org/show_bug.cgi?id=46553
Because we use StringHasher for binary data too, so the check for invalid unicode input is wrong.
Add an additional member variable to indicate if we have an pending character
instead of only using an invalid character for this purpose.
- wtf/StringHashFunctions.h: (WTF::StringHasher::StringHasher): (WTF::StringHasher::addCharacters): (WTF::StringHasher::addCharacter): (WTF::StringHasher::hash):
- 9:56 PM Changeset in webkit [68367] by
-
- 2 edits in trunk/WebKit/chromium
2010-09-26 Mihai Parparita <mihaip@chromium.org>
Reviewed by Adam Barth.
[Chromium] Remove no longer used WebView member functions
https://bugs.webkit.org/show_bug.cgi?id=46515
With http://crrev.com/60526 there's no longer any Chromium code calling
the non-static versions of addUserScript and addUserStyleSheet.
- public/WebView.h:
- 9:35 PM Changeset in webkit [68366] by
-
- 2 edits in trunk/LayoutTests
2010-09-26 Shane Stephens <shanestephens@google.com>
Reviewed by Adam Barth.
[Chromium] Test expectations update to green canary bots.
https://bugs.webkit.org/show_bug.cgi?id=46604
https://bugs.webkit.org/show_bug.cgi?id=46596 and
https://bugs.webkit.org/show_bug.cgi?id=46597
- platform/chromium/test_expectations.txt:
- 7:58 PM Changeset in webkit [68365] by
-
- 3 edits in trunk/WebKitTools
2010-09-26 Mihai Parparita <mihaip@chromium.org>
Reviewed by Ojan Vafai.
new-run-webkit-httpd fails if Perl is not installed
https://bugs.webkit.org/show_bug.cgi?id=46602
Make Port._read_configuration catch all exceptions, since trying to run
perl (because of _webkit_build_directory) when it's not installed throws
a WindowsError or OSError, not an IOError (this became an issue after
r68268, since ChromiumPort ends up calling Port.default_configuration in
its constructor, which means that we're ending up on this codepath in
non-NRWT cases too, e.g. for the Chromium NaCl tests, which use
new-run-webkit-httpd).
- Scripts/webkitpy/layout_tests/port/base.py:
- Scripts/webkitpy/layout_tests/port/base_unittest.py:
- 7:53 PM Changeset in webkit [68364] by
-
- 3 edits in trunk/WebKit2
MiniBrowser crashes when opening main menu item
https://bugs.webkit.org/show_bug.cgi?id=46588
Reviewed by Simon Fraser.
- UIProcess/API/mac/PageClientImpl.mm:
(WebKit::PageClientImpl::setEditCommandState): Don't allow default
String -> NSString conversion to take place, and use the increasingly
misnamed nsStringFromWebCoreString instead.
- 7:43 PM Changeset in webkit [68363] by
-
- 5 edits in trunk
2010-09-26 Gyuyoung Kim <gyuyoung.kim@samsung.com>
Reviewed by Antonio Gomes.
[EFL] Add setting API to set a local storage database path.
https://bugs.webkit.org/show_bug.cgi?id=45446
Add a setting API to set local storage database path.
- ewk/ewk_view.cpp: (_ewk_view_priv_new): (_ewk_view_priv_del): (ewk_view_setting_local_storage_database_path_get): Added. (ewk_view_setting_local_storage_database_path_set): Added.
- ewk/ewk_view.h:
2010-09-26 Gyuyoung Kim <gyuyoung.kim@samsung.com>
Reviewed by Antonio Gomes.
[EFL] Add setting API to set a local storage database path.
https://bugs.webkit.org/show_bug.cgi?id=45446
Add a setting API to set local storage database path.
- EWebLauncher/main.c: (on_key_down): (browserCreate): (main):
- 7:09 PM Changeset in webkit [68362] by
-
- 13 edits in trunk
https://bugs.webkit.org/show_bug.cgi?id=46519
Reviewed by Sam Weinig.
Convert the implementation of computeLogicalWidth to work with block-flow.
WebCore:
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::determineHorizontalPosition):
Patched to call the new computeMarginsInContainingBlockInlineDirection. Eventually determineHorizontalPosition will
be placing children along the inline direction of the containing block, and those children may have mismatched
block flows. The new computeMarginsInContainingBlockInlineDirection function is designed to handle that.
- rendering/RenderBox.cpp:
(WebCore::RenderBox::marginStart):
(WebCore::RenderBox::marginStartUsing):
(WebCore::RenderBox::marginEnd):
(WebCore::RenderBox::marginEndUsing):
(WebCore::RenderBox::setMarginStart):
(WebCore::RenderBox::setMarginEnd):
(WebCore::RenderBox::setMarginStartUsing):
(WebCore::RenderBox::setMarginEndUsing):
Helpers that allow for marginStart/End access and that also allow for marginStart/End to be computed based off another
element's block-flow and direction (typically the containing block).
(WebCore::RenderBox::computeBorderBoxLogicalWidth):
(WebCore::RenderBox::computeBorderBoxLogicalHeight):
(WebCore::RenderBox::computeContentBoxLogicalWidth):
(WebCore::RenderBox::computeContentBoxLogicalHeight):
Patched to use logical border/padding widths and heights.
(WebCore::RenderBox::perpendicularContainingBlockLogicalHeight):
A function for returning the available logical height of a perpendicular containing block. If a child has vertical
text for example and its block-flow is "lr", its available logical width is determined by the logical
height of the containing block when that containing block is perpendicular, e.g. "tb".
(WebCore::RenderBox::computeLogicalWidth):
(WebCore::RenderBox::computeLogicalWidthUsing):
Patched to be block-flow-aware and to use logical width values everywhere.
(WebCore::RenderBox::sizesToIntrinsicLogicalWidth):
Patched to use logical widths.
(WebCore::RenderBox::computeMarginsInContainingBlockInlineDirection):
A new function that is directionally abstract and that can handle the computation of margins in the containing
block's inline direction. This function is written such that a perpendicular child block flow can still be
pushed to the center, left or right in the containing block's inline direction.
(WebCore::RenderBox::computePositionedLogicalWidth):
This function is still largely unpatched. A future patch will address positioend elements.
- rendering/RenderBox.h:
(WebCore::RenderBox::stretchesToMinIntrinsicLogicalWidth):
- rendering/RenderFieldset.h:
(WebCore::RenderFieldset::stretchesToMinIntrinsicLogicalWidth):
Renames.
- rendering/RenderTable.cpp:
(WebCore::RenderTable::computeLogicalWidth):
Renames, but not converted yet. Tables will happen in a future patch.
- rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::marginStartUsing):
(WebCore::RenderStyle::marginEndUsing):
- rendering/style/RenderStyle.h:
Added helpers for accessing marginStart and End using another style's direction and block flow (typically will
be the containing block's).
fast/block/basic/016.html changed, since centering now always awards the extra pixel for odd widths to the end margin
instead of the right margin. This is a progression.
fast/css/logical-property-values.html is now reporting garbage results, which is expected now that some of the core layout
functions have been patched.
Horizontal block flows are untestable still, since the normal layout process incorrectly blows away any computed height values.
LayoutTests:
- fast/css/logical-property-resolution-expected.txt:
- platform/mac/fast/block/basic/016-expected.checksum:
- platform/mac/fast/block/basic/016-expected.png:
- platform/mac/fast/block/basic/016-expected.txt:
- 6:56 PM Changeset in webkit [68361] by
-
- 2 edits in trunk/WebKit2
Another windows build fix windows attempt.
- win/WebKit2Common.vsprops:
- 6:47 PM Changeset in webkit [68360] by
-
- 2 edits in trunk/WebKit2
Another windows build fix windows attempt.
- win/WebKit2Generated.make:
- 6:34 PM Changeset in webkit [68359] by
-
- 2 edits in trunk/WebKit2
Attempt to fix windows build.
- win/WebKit2Common.vsprops:
- 6:31 PM Changeset in webkit [68358] by
-
- 2 edits in trunk/WebKit2
Attempt to fix Qt build.
- WebKit2.pro:
- 6:22 PM Changeset in webkit [68357] by
-
- 19 edits6 copies33 moves4 adds2 deletes in trunk
Move shared WebKit2 API (used by both bundle and main API) to WebKit2/Shared/API
https://bugs.webkit.org/show_bug.cgi?id=46587
Reviewed by Anders Carlsson.
WebKit2:
- Moves shared types (WKArrayRef, WKDictionaryRef, etc) to Shared/API/c.
- Removes WKBundleBase.h and moves all opaque type declarations to WKBase.h (which moves to Shared/API/c).
- Adds WKSharedAPICast.h which includes shared API casting logic and is included by both WKAPICast.h and WKBundleAPICast.h now. Moved to using macros for API mappings to reduce verbosity.
- Move windows c API files from UIProcess/API/win to UIProcess/API/C/win.
- Shared/API: Added.
- Shared/API/c: Added.
- Shared/API/c/WKArray.cpp: Copied from UIProcess/API/C/WKArray.cpp.
- Shared/API/c/WKArray.h: Copied from UIProcess/API/C/WKArray.h.
- Shared/API/c/WKBase.h: Copied from UIProcess/API/C/WKBase.h.
- Shared/API/c/WKCertificateInfo.cpp: Copied from UIProcess/API/C/WKCertificateInfo.cpp.
- Shared/API/c/WKCertificateInfo.h: Copied from UIProcess/API/C/WKCertificateInfo.h.
- Shared/API/c/WKData.cpp: Copied from UIProcess/API/C/WKData.cpp.
- Shared/API/c/WKData.h: Copied from UIProcess/API/C/WKData.h.
- Shared/API/c/WKDictionary.cpp: Copied from UIProcess/API/C/WKDictionary.cpp.
- Shared/API/c/WKDictionary.h: Copied from UIProcess/API/C/WKDictionary.h.
- Shared/API/c/WKError.cpp: Copied from UIProcess/API/C/WKError.cpp.
- Shared/API/c/WKError.h: Copied from UIProcess/API/C/WKError.h.
- Shared/API/c/WKMutableArray.cpp: Copied from UIProcess/API/C/WKMutableArray.cpp.
- Shared/API/c/WKMutableArray.h: Copied from UIProcess/API/C/WKMutableArray.h.
- Shared/API/c/WKMutableDictionary.cpp: Copied from UIProcess/API/C/WKMutableDictionary.cpp.
- Shared/API/c/WKMutableDictionary.h: Copied from UIProcess/API/C/WKMutableDictionary.h.
- Shared/API/c/WKNumber.cpp: Copied from UIProcess/API/C/WKNumber.cpp.
- Shared/API/c/WKNumber.h: Copied from UIProcess/API/C/WKNumber.h.
- Shared/API/c/WKSerializedScriptValue.cpp: Copied from UIProcess/API/C/WKSerializedScriptValue.cpp.
- Shared/API/c/WKSerializedScriptValue.h: Copied from UIProcess/API/C/WKSerializedScriptValue.h.
- Shared/API/c/WKSharedAPICast.h: Copied from UIProcess/API/C/WKAPICast.h.
- Shared/API/c/WKString.cpp: Copied from UIProcess/API/C/WKString.cpp.
- Shared/API/c/WKString.h: Copied from UIProcess/API/C/WKString.h.
- Shared/API/c/WKType.cpp: Copied from UIProcess/API/C/WKType.cpp.
- Shared/API/c/WKType.h: Copied from UIProcess/API/C/WKType.h.
- Shared/API/c/WKURL.cpp: Copied from UIProcess/API/C/WKURL.cpp.
- Shared/API/c/WKURL.h: Copied from UIProcess/API/C/WKURL.h.
- Shared/API/c/WKURLRequest.cpp: Copied from UIProcess/API/C/WKURLRequest.cpp.
- Shared/API/c/WKURLRequest.h: Copied from UIProcess/API/C/WKURLRequest.h.
- Shared/API/c/WKURLResponse.cpp: Copied from UIProcess/API/C/WKURLResponse.cpp.
- Shared/API/c/WKURLResponse.h: Copied from UIProcess/API/C/WKURLResponse.h.
- Shared/API/c/cf: Copied from UIProcess/API/C/cf.
- Shared/API/c/mac: Copied from UIProcess/API/C/mac.
- Shared/API/c/win: Added.
- Shared/API/c/win/WKBaseWin.h: Copied from UIProcess/API/win/WKBaseWin.h.
- Shared/API/c/win/WKCertificateInfoWin.cpp: Copied from UIProcess/API/C/win/WKCertificateInfoWin.cpp.
- Shared/API/c/win/WKCertificateInfoWin.h: Copied from UIProcess/API/C/win/WKCertificateInfoWin.h.
- UIProcess/API/C/WKAPICast.h: Replaced.
- UIProcess/API/C/WKArray.cpp: Removed.
- UIProcess/API/C/WKArray.h: Removed.
- UIProcess/API/C/WKBase.h: Removed.
- UIProcess/API/C/WKCertificateInfo.cpp: Removed.
- UIProcess/API/C/WKCertificateInfo.h: Removed.
- UIProcess/API/C/WKData.cpp: Removed.
- UIProcess/API/C/WKData.h: Removed.
- UIProcess/API/C/WKDictionary.cpp: Removed.
- UIProcess/API/C/WKDictionary.h: Removed.
- UIProcess/API/C/WKError.cpp: Removed.
- UIProcess/API/C/WKError.h: Removed.
- UIProcess/API/C/WKMutableArray.cpp: Removed.
- UIProcess/API/C/WKMutableArray.h: Removed.
- UIProcess/API/C/WKMutableDictionary.cpp: Removed.
- UIProcess/API/C/WKMutableDictionary.h: Removed.
- UIProcess/API/C/WKNumber.cpp: Removed.
- UIProcess/API/C/WKNumber.h: Removed.
- UIProcess/API/C/WKSerializedScriptValue.cpp: Removed.
- UIProcess/API/C/WKSerializedScriptValue.h: Removed.
- UIProcess/API/C/WKString.cpp: Removed.
- UIProcess/API/C/WKString.h: Removed.
- UIProcess/API/C/WKType.cpp: Removed.
- UIProcess/API/C/WKType.h: Removed.
- UIProcess/API/C/WKURL.cpp: Removed.
- UIProcess/API/C/WKURL.h: Removed.
- UIProcess/API/C/WKURLRequest.cpp: Removed.
- UIProcess/API/C/WKURLRequest.h: Removed.
- UIProcess/API/C/WKURLResponse.cpp: Removed.
- UIProcess/API/C/WKURLResponse.h: Removed.
- UIProcess/API/C/cf: Removed.
- UIProcess/API/C/cf/WKStringCF.cpp: Removed.
- UIProcess/API/C/cf/WKStringCF.h: Removed.
- UIProcess/API/C/cf/WKURLCF.cpp: Removed.
- UIProcess/API/C/cf/WKURLCF.h: Removed.
- UIProcess/API/C/cf/WKURLRequestCF.cpp: Removed.
- UIProcess/API/C/cf/WKURLRequestCF.h: Removed.
- UIProcess/API/C/cf/WKURLResponseCF.cpp: Removed.
- UIProcess/API/C/cf/WKURLResponseCF.h: Removed.
- UIProcess/API/C/mac: Removed.
- UIProcess/API/C/mac/WKCertificateInfoMac.h: Removed.
- UIProcess/API/C/mac/WKCertificateInfoMac.mm: Removed.
- UIProcess/API/C/mac/WKURLRequestNS.h: Removed.
- UIProcess/API/C/mac/WKURLRequestNS.mm: Removed.
- UIProcess/API/C/mac/WKURLResponseNS.h: Removed.
- UIProcess/API/C/mac/WKURLResponseNS.mm: Removed.
- UIProcess/API/C/win/WKAPICastWin.h: Copied from UIProcess/API/win/WKAPICastWin.h.
- UIProcess/API/C/win/WKBaseWin.h: Copied from UIProcess/API/win/WKBaseWin.h.
- UIProcess/API/C/win/WKCertificateInfoWin.cpp: Removed.
- UIProcess/API/C/win/WKCertificateInfoWin.h: Removed.
- UIProcess/API/C/win/WKView.cpp: Copied from UIProcess/API/win/WKView.cpp.
- UIProcess/API/C/win/WKView.h: Copied from UIProcess/API/win/WKView.h.
- UIProcess/API/win: Removed.
- UIProcess/API/win/WKAPICastWin.h: Removed.
- UIProcess/API/win/WKBaseWin.h: Removed.
- UIProcess/API/win/WKView.cpp: Removed.
- UIProcess/API/win/WKView.h: Removed.
- WebKit2.pro:
- WebKit2.xcodeproj/project.pbxproj:
- WebProcess/InjectedBundle/API/c/WKBundle.h:
- WebProcess/InjectedBundle/API/c/WKBundleAPICast.h:
- WebProcess/InjectedBundle/API/c/WKBundleBase.h: Removed.
- WebProcess/InjectedBundle/API/c/WKBundleFrame.h:
- WebProcess/InjectedBundle/API/c/WKBundleFramePrivate.h:
- WebProcess/InjectedBundle/API/c/WKBundleHitTestResult.h:
- WebProcess/InjectedBundle/API/c/WKBundleInitialize.h:
- WebProcess/InjectedBundle/API/c/WKBundleNodeHandle.h:
- WebProcess/InjectedBundle/API/c/WKBundlePage.h:
- WebProcess/InjectedBundle/API/c/WKBundlePagePrivate.h:
- WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:
- WebProcess/InjectedBundle/API/c/WKBundleRangeHandle.h:
- WebProcess/InjectedBundle/API/c/WKBundleScriptWorld.h:
- win/WebKit2.vcproj:
- win/WebKit2Generated.make:
WebKitTools:
- WebKitTestRunner/InjectedBundle/InjectedBundle.h:
- 5:23 PM Changeset in webkit [68356] by
-
- 16 edits in trunk
[Mac][DRT] Implement LayoutTestController::nodesFromRect
https://bugs.webkit.org/show_bug.cgi?id=46580
Patch by Antonio Gomes <agomes@rim.comg> on 2010-09-26
Reviewed by Kenneth Christiansen.
WebCore:
Symbol files updated.
- WebCore.exp.in: Added symbols to Document::nodesFromRect and bits of JSDocument now
needed in WebKit/mac.
- WebCore.xcodeproj/project.pbxproj: Set both JSDocument.h and JSNodeList as private headers
now that they are referred in WebKit/mac.
WebKit/mac:
Implement nodesFromRect as a private method to access non-exposed Document
methods, similarly to computedStyleIncludingVisitedInfo.
- WebView/WebView.mm: Added JSDocument.h and JSNodeList.h to the include list.
These headers makes it possible to:
1) Get a Document off of a JSDocument;
2) Call toJS function, defined in JSNodeList.cpp|h so we can convert RefPtr<NodeList>
gotten from Document::nodesFromRect to JS bindings.
(-[WebView _nodesFromRect:forDocument:x:y:hPadding:vPadding:ignoreClipping:]):
- WebView/WebViewPrivate.h: Added nodesFromRect method to access methods of the
Document class not exposed to JavaScript. It works similarly to computedStyleIncludingVisitedInfo.
WebKitTools:
Implements LayoutTestController::nodesFromRect for Mac DRT, and
adding stubs for GTK+ and Windows.
- DumpRenderTree/LayoutTestController.cpp:
(nodesFromRectCallback):
(LayoutTestController::staticFunctions):
- DumpRenderTree/LayoutTestController.h:
(LayoutTestController::LayoutTestController::nodesFromRect):
- DumpRenderTree/mac/LayoutTestControllerMac.mm:
(LayoutTestController::nodesFromRect):
LayoutTests:
Unskipping fast/dom/nodesFromRect-based.html on Mac, and changes it
so that it calls layoutTestController.nodesFromRect() instead of
document.nodesFromRect().
- fast/dom/resources/nodesFromRect.js:
(check):
- platform/mac/Skipped:
- 3:59 PM Changeset in webkit [68355] by
-
- 2 edits in trunk/LayoutTests
2010-09-26 Adam Barth <abarth@webkit.org>
Rebaseline Qt results.
- platform/qt/fast/dom/Window/window-properties-expected.txt:
- 3:22 PM Changeset in webkit [68354] by
-
- 11 edits4 adds in trunk
2010-09-26 Adam Barth <abarth@webkit.org>
Reviewed by Dimitri Glazkov.
Implement location.origin and HTMLAnchorElement.origin
https://bugs.webkit.org/show_bug.cgi?id=46558
Test the origin attribute of Location and HTMLAnchorElement.
- fast/dom/anchor-origin-expected.txt: Added.
- fast/dom/anchor-origin.html: Added.
- http/tests/misc/location-origin-expected.txt: Added.
- http/tests/misc/location-origin.html: Added.
2010-09-26 Adam Barth <abarth@webkit.org>
Reviewed by Dimitri Glazkov.
Implement location.origin and HTMLAnchorElement.origin
https://bugs.webkit.org/show_bug.cgi?id=46558
These attributes are part of my proposed URL API:
https://docs.google.com/document/edit?id=1r_VTFKApVOaNIkocrg0z-t7lZgzisTuGTXkdzAk4gLU&hl=en
Hixie thought we should implement as much of this API as makes sense on
Location and HTMLAnchorElement as well. I'm starting with the origin
attribute, because that seems like the biggest bang for the buck.
Tests: fast/dom/anchor-origin.html
http/tests/misc/location-origin.html
- WebCore.xcodeproj/project.pbxproj:
- html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::origin):
- html/HTMLAnchorElement.h:
- html/HTMLAnchorElement.idl:
- page/Location.cpp: (WebCore::Location::origin):
- page/Location.h:
- page/Location.idl:
- 3:11 PM Changeset in webkit [68353] by
-
- 3 edits in trunk/WebKit2
Fix non-Mac builds.
- Platform/SharedMemory.h:
- Platform/mac/SharedMemoryMac.cpp:
(WebKit::SharedMemory::Handle::isNull):
- 2:48 PM Changeset in webkit [68352] by
-
- 3 edits in trunk/WebKit2
Make it possible to encode null SharedMemory::Handle objects
https://bugs.webkit.org/show_bug.cgi?id=46585
Reviewed by Sam Weinig.
- Platform/SharedMemory.h:
(WebKit::SharedMemory::Handle::isNull):
Add isNull.
- Platform/mac/SharedMemoryMac.cpp:
(WebKit::SharedMemory::Handle::encode):
Remove asserts.
(WebKit::SharedMemory::create):
Bail if we see a null handle. Also work around a kernel bug where
mach_vm_map fails if the given address to map is already mapped, even if
VM_FLAG_ANYWHERE is set.
- 2:48 PM Changeset in webkit [68351] by
-
- 2 edits3 adds in trunk/WebKit2
Add BackingStore class
https://bugs.webkit.org/show_bug.cgi?id=46584
Reviewed by Sam Weinig.
- Shared/BackingStore.cpp: Added.
(WebKit::BackingStore::create):
Create a backing store backed by fastMalloc memory.
(WebKit::BackingStore::createSharable):
Create a backing store backed by shared memory.
(WebKit::BackingStore::createHandle):
Create a handle that can be sent over the wire.
(WebKit::BackingStore::resize):
Resize the backing store memory.
(WebKit::BackingStore::data):
Return the backing store data.
- Shared/mac/BackingStoreMac.mm: Added.
(WebKit::BackingStore::createGraphicsContext):
Create a graphics context that will paint into the backing store.
(WebKit::BackingStore::paint):
Paint the backing store in a graphics context.
- WebKit2.xcodeproj/project.pbxproj:
Add files.
- 2:48 PM Changeset in webkit [68350] by
-
- 11 edits in trunk/WebKit2
Establish a connection between the plug-in process and the web process
https://bugs.webkit.org/show_bug.cgi?id=46583
Reviewed by Sam Weinig.
- PluginProcess/PluginProcess.cpp:
(WebKit::PluginProcess::didReceiveMessage):
Call the auto-generated didReceivePluginProcessMessage.
- PluginProcess/PluginProcess.h:
Add didReceivePluginProcessMessage declaration.
- PluginProcess/PluginProcess.messages.in:
Add new "CreateWebProcessConnection" message.
- PluginProcess/WebProcessConnection.cpp:
(WebKit::WebProcessConnection::didReceiveMessage):
(WebKit::WebProcessConnection::didReceiveSyncMessage):
(WebKit::WebProcessConnection::didClose):
(WebKit::WebProcessConnection::didReceiveInvalidMessage):
Add stubbed out member functions.
- UIProcess/Plugins/PluginProcessManager.cpp:
(WebKit::PluginProcessManager::getPluginProcessConnection):
Ask the plug-in process proxy to create a connection.
- UIProcess/Plugins/PluginProcessProxy.cpp:
(WebKit::PluginProcessProxy::createWebProcessConnection):
Add the WebProcessProxy and the reply encoder to the queue of pending replies.
If the process is still launching, keep track of how many pending requests we have, otherwise
just send the request.
(WebKit::PluginProcessProxy::didReceiveMessage):
Call the auto-generated didReceivePluginProcessMessage.
(WebKit::PluginProcessProxy::didFinishLaunching):
Send all pending connection requests.
(WebKit::PluginProcessProxy::didCreateWebProcessConnection):
Get the first pending reply and send it with the mach port.
- WebKit2.xcodeproj/project.pbxproj:
Actually compile PluginProcessMessageReceiver.
- WebProcess/Plugins/PluginProcessConnection.cpp:
(WebKit::PluginProcessConnection::PluginProcessConnection):
Create a CoreIPC connection.
(WebKit::PluginProcessConnection::didReceiveMessage):
(WebKit::PluginProcessConnection::didClose):
(WebKit::PluginProcessConnection::didReceiveInvalidMessage):
Add stubbed out member functions.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::createPlugin):
Ask the plug-in process connection manager for a connection.
- 2:47 PM Changeset in webkit [68349] by
-
- 3 edits in trunk/WebKit2
Generated message handlers should include argument coder headers for some types
https://bugs.webkit.org/show_bug.cgi?id=46582
Reviewed by Sam Weinig.
- Scripts/webkit2/messages.py:
When determining which headers to use when generating a message handler, consider the
argument coder headers.
- Scripts/webkit2/messages_unittest.py:
Update test result.
- 2:38 PM Changeset in webkit [68348] by
-
- 5 edits in trunk
2010-09-26 Mark Hahnenberg <mhahnenb@gmail.com>
Reviewed by Oliver Hunt.
valueOf called in wrong order in atan2 and date constructors.
https://bugs.webkit.org/show_bug.cgi?id=26978
Fixed the bug where the arguments to atan2 were being evaluated
out of order.
- runtime/MathObject.cpp: (JSC::mathProtoFuncATan2):
2010-09-26 Mark Hahnenberg <mhahnenb@gmail.com>
Reviewed by Oliver Hunt.
valueOf called in wrong order in atan2 and date constructors.
https://bugs.webkit.org/show_bug.cgi?id=26978
Regression test for the issue where the arguments to atan2 were
evaluated out of order.
- fast/js/math-expected.txt:
- fast/js/script-tests/math.js: (v.valueOf): (w.valueOf):
- 2:26 PM Changeset in webkit [68347] by
-
- 5 edits in trunk
2010-09-26 Mark Hahnenberg <mhahnenb@gmail.com>
Reviewed by Oliver Hunt.
valueOf called in wrong order in atan2 and date constructors.
https://bugs.webkit.org/show_bug.cgi?id=26978
Fixed the issue where the parameters to the Date constructor
were being evaluated to numbers more than once.
- runtime/DateConstructor.cpp: (JSC::constructDate): (JSC::dateUTC):
2010-09-26 Mark Hahnenberg <mhahnenb@gmail.com>
Reviewed by Oliver Hunt.
valueOf called in wrong order in atan2 and date constructors.
https://bugs.webkit.org/show_bug.cgi?id=26978
Added regression test for the Date constructor issue.
- fast/js/date-constructor-expected.txt:
- fast/js/script-tests/date-constructor.js: (year.valueOf): (month.valueOf): (date.valueOf): (hours.valueOf): (minutes.valueOf): (seconds.valueOf): (ms.valueOf):
- 12:21 PM Changeset in webkit [68346] by
-
- 3 edits3 deletes in trunk
2010-09-26 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r68343.
http://trac.webkit.org/changeset/68343
https://bugs.webkit.org/show_bug.cgi?id=46581
broke GTK+ (Requested by kling on #webkit).
- html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::setFont):
2010-09-26 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r68343.
http://trac.webkit.org/changeset/68343
https://bugs.webkit.org/show_bug.cgi?id=46581
broke GTK+ (Requested by kling on #webkit).
- fast/canvas/canvas-font-ex-units-crash-expected.txt: Removed.
- fast/canvas/canvas-font-ex-units-crash.html: Removed.
- fast/canvas/script-tests/canvas-font-ex-units-crash.js: Removed.
- 12:00 PM Changeset in webkit [68345] by
-
- 9 edits in trunk
document.nodesFromRect() needs to be removed from Document.idl
https://bugs.webkit.org/show_bug.cgi?id=46492
Reviewed by Kenneth Christiansen and Andreas Kling.
Patch by Antonio Gomes <agomes@rim.com>
WebCore:
As discussed with Sam Weinig on IRC, it was decided to removed
nodesFromRect() from the Document.idl, and that way, not exposing
it to Web content.
Reason: there is no plan to make it standard at the moment, and at the
very least, the method should had been originally added with the "webkit"
prefix, which was not the case.
- dom/Document.idl:
LayoutTests:
Skip the tests relying on document.nodesFromRect in all platform for
the moment, and adjusting the expected results tests also accordingly.
- fast/dom/Window/window-properties-expected.txt:
- platform/gtk/Skipped:
- platform/mac/Skipped:
- platform/qt/Skipped:
- platform/qt/fast/dom/Window/window-properties-expected.txt:
- platform/win/Skipped:
- 10:45 AM Changeset in webkit [68344] by
-
- 4 edits30 adds in trunk
2010-09-26 Renata Hodovan <reni@inf.u-szeged.hu>
Reviewed by Dirk Schulze.
SVGFEBlendElement doesn't support dynamic invalidation, when attributes change.
https://bugs.webkit.org/show_bug.cgi?id=46464
Adding layout tests for feBlend dynamic changes.
- platform/mac/svg/dynamic-updates/SVGFEBlendElement-dom-in-attr-expected.checksum: Added.
- platform/mac/svg/dynamic-updates/SVGFEBlendElement-dom-in-attr-expected.png: Added.
- platform/mac/svg/dynamic-updates/SVGFEBlendElement-dom-in2-attr-expected.checksum: Added.
- platform/mac/svg/dynamic-updates/SVGFEBlendElement-dom-in2-attr-expected.png: Added.
- platform/mac/svg/dynamic-updates/SVGFEBlendElement-dom-mode-attr-expected.checksum: Added.
- platform/mac/svg/dynamic-updates/SVGFEBlendElement-dom-mode-attr-expected.png: Added.
- platform/mac/svg/dynamic-updates/SVGFEBlendElement-svgdom-in-prop-expected.checksum: Added.
- platform/mac/svg/dynamic-updates/SVGFEBlendElement-svgdom-in-prop-expected.png: Added.
- platform/mac/svg/dynamic-updates/SVGFEBlendElement-svgdom-in2-prop-expected.checksum: Added.
- platform/mac/svg/dynamic-updates/SVGFEBlendElement-svgdom-in2-prop-expected.png: Added.
- platform/mac/svg/dynamic-updates/SVGFEBlendElement-svgdom-mode-prop-expected.checksum: Added.
- platform/mac/svg/dynamic-updates/SVGFEBlendElement-svgdom-mode-prop-expected.png: Added.
- svg/dynamic-updates/SVGFEBlendElement-dom-in-attr-expected.txt: Added.
- svg/dynamic-updates/SVGFEBlendElement-dom-in-attr.html: Added.
- svg/dynamic-updates/SVGFEBlendElement-dom-in2-attr-expected.txt: Added.
- svg/dynamic-updates/SVGFEBlendElement-dom-in2-attr.html: Added.
- svg/dynamic-updates/SVGFEBlendElement-dom-mode-attr-expected.txt: Added.
- svg/dynamic-updates/SVGFEBlendElement-dom-mode-attr.html: Added.
- svg/dynamic-updates/SVGFEBlendElement-svgdom-in-prop-expected.txt: Added.
- svg/dynamic-updates/SVGFEBlendElement-svgdom-in-prop.html: Added.
- svg/dynamic-updates/SVGFEBlendElement-svgdom-in2-prop-expected.txt: Added.
- svg/dynamic-updates/SVGFEBlendElement-svgdom-in2-prop.html: Added.
- svg/dynamic-updates/SVGFEBlendElement-svgdom-mode-prop-expected.txt: Added.
- svg/dynamic-updates/SVGFEBlendElement-svgdom-mode-prop.html: Added.
- svg/dynamic-updates/script-tests/SVGFEBlendElement-dom-in-attr.js: Added. (executeTest):
- svg/dynamic-updates/script-tests/SVGFEBlendElement-dom-in2-attr.js: Added. (executeTest):
- svg/dynamic-updates/script-tests/SVGFEBlendElement-dom-mode-attr.js: Added. (executeTest):
- svg/dynamic-updates/script-tests/SVGFEBlendElement-svgdom-in-prop.js: Added. (executeTest):
- svg/dynamic-updates/script-tests/SVGFEBlendElement-svgdom-in2-prop.js: Added. (executeTest):
- svg/dynamic-updates/script-tests/SVGFEBlendElement-svgdom-mode-prop.js: Added. (executeTest):
2010-09-26 Renata Hodovan <reni@inf.u-szeged.hu>
Reviewed by Dirk Schulze.
SVGFEBlendElement doesn't support dynamic invalidation, when attributes change.
https://bugs.webkit.org/show_bug.cgi?id=46464
Tests: svg/dynamic-updates/SVGFEBlendElement-dom-in-attr.html
svg/dynamic-updates/SVGFEBlendElement-dom-in2-attr.html
svg/dynamic-updates/SVGFEBlendElement-dom-mode-attr.html
svg/dynamic-updates/SVGFEBlendElement-svgdom-in-prop.html
svg/dynamic-updates/SVGFEBlendElement-svgdom-in2-prop.html
svg/dynamic-updates/SVGFEBlendElement-svgdom-mode-prop.html
- svg/SVGFEBlendElement.cpp: (WebCore::SVGFEBlendElement::svgAttributeChanged):
- svg/SVGFEBlendElement.h:
- 10:39 AM Changeset in webkit [68343] by
-
- 3 edits3 adds in trunk
2010-09-26 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Dan Bernstein.
Canvas: Crash when setting a font with size in 'ex' units
https://bugs.webkit.org/show_bug.cgi?id=46538
update() the style's font after setting the style's font description.
Needed because CSSPrimitiveValue::computeLengthDouble() later assumes
that the style's font is properly initialized (for xHeight().)
Fixes crash on IE test center's canvas-text-font-002 test.
- html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::setFont):
2010-09-26 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Dan Bernstein.
Canvas: Crash when setting a font with size in 'ex' units
https://bugs.webkit.org/show_bug.cgi?id=46538
- fast/canvas/canvas-font-ex-units-crash-expected.txt: Added.
- fast/canvas/canvas-font-ex-units-crash.html: Added.
- fast/canvas/script-tests/canvas-font-ex-units-crash.js: Added.
- 10:25 AM Changeset in webkit [68342] by
-
- 2 edits in trunk/WebCore
2010-09-26 Kwang Yul Seo <skyul@company100.net>
Reviewed by Eric Seidel.
[BREWMP] Don't pass PassOwnPtr in makeAllDirectories
https://bugs.webkit.org/show_bug.cgi?id=42058
Change makeAllDirectories to take a raw FileMgr pointer
because it is not safe to pass PassOwnPtr recursively.
- platform/brew/FileSystemBrew.cpp: (WebCore::makeAllDirectories):
- 6:12 AM Changeset in webkit [68341] by
-
- 4 edits in trunk
2010-09-26 Robert Hogan <robert@webkit.org>
Reviewed by Andreas Kling.
[Qt] fix http/tests/uri/escaped-entity.html
Replace invalid encodings with the appropriate escaped entity.
- platform/qt/Skipped:
2010-09-26 Robert Hogan <robert@webkit.org>
Reviewed by Andreas Kling.
[Qt] fix http/tests/uri/escaped-entity.html
Replace invalid encodings with the appropriate escaped entity.
- platform/text/qt/TextCodecQt.cpp: (WebCore::TextCodecQt::encode):
Sep 25, 2010:
- 10:56 PM Changeset in webkit [68340] by
-
- 3 edits2 adds in trunk
2010-09-25 Abhishek Arya <inferno@chromium.org>
Reviewed by Nikolas Zimmermann.
Fix the macro to bail out after setting the SVG style to 'initial'. Check that color is
SVGColor before calling colorFromSVGColorCSSValue which makes sure we don't set invalid
color. Also, doing the static cast in the caller and keeping the function
colorFromSVGColorCSSValue clean to accept only take SVGColor objects.
Test: svg/css/invalid-color-crash.svg
- css/SVGCSSStyleSelector.cpp: (WebCore::colorFromSVGColorCSSValue): (WebCore::CSSStyleSelector::applySVGProperty):
2010-09-25 Abhishek Arya <inferno@chromium.org>
Reviewed by Nikolas Zimmermann.
Tests that we dont crash when setting color to initial for SVG.
https://bugs.webkit.org/show_bug.cgi?id=46471
- svg/css/invalid-color-crash-expected.txt: Added.
- svg/css/invalid-color-crash.svg: Added.
- 3:57 PM Changeset in webkit [68339] by
-
- 4 edits in trunk/JavaScriptCore
Relearning the lesson that last minute changes are bad.
- 2:42 PM Changeset in webkit [68338] by
-
- 11 edits in trunk/JavaScriptCore
2010-09-25 Oliver Hunt <oliver@apple.com>
Reviewed by Cameron Zwarich.
Avoid constructing arguments object when accessing length and index properties
https://bugs.webkit.org/show_bug.cgi?id=46572
Add opcodes to read argument length and properties, and then implement them.
Much like other lazy opcodes these opcodes take a fast path when the arguments
object has not been instantiated, and fall back on generic access mechanisms
if they are acting on an instantiated object.
3% win on v8-earleyboyer, no change elsewhere.
- bytecode/CodeBlock.cpp: (JSC::CodeBlock::dump):
- bytecode/Opcode.h:
- bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::emitGetArgumentsLength): (JSC::BytecodeGenerator::emitGetArgumentByVal):
- bytecompiler/BytecodeGenerator.h:
- bytecompiler/NodesCodegen.cpp: (JSC::BracketAccessorNode::emitBytecode): (JSC::DotAccessorNode::emitBytecode):
- interpreter/Interpreter.cpp: (JSC::Interpreter::privateExecute):
- jit/JIT.cpp: (JSC::JIT::privateCompileMainPass): (JSC::JIT::privateCompileSlowCases):
- jit/JIT.h:
- jit/JITOpcodes.cpp: (JSC::JIT::emit_op_get_arguments_length): (JSC::JIT::emitSlow_op_get_arguments_length): (JSC::JIT::emit_op_get_argument_by_val): (JSC::JIT::emitSlow_op_get_argument_by_val):
- jit/JITOpcodes32_64.cpp: (JSC::JIT::emit_op_get_arguments_length): (JSC::JIT::emitSlow_op_get_arguments_length): (JSC::JIT::emit_op_get_argument_by_val): (JSC::JIT::emitSlow_op_get_argument_by_val):
- 1:42 PM Changeset in webkit [68337] by
-
- 3 edits in trunk/WebCore
2010-09-25 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Tony Chang.
FormatBlockCommand's modifyRange and doApply should be merged
https://bugs.webkit.org/show_bug.cgi?id=46504
Isolated the code in doApply to insert and remove lists for single paragraph into doApplyForSingleParagraph.
Merged the code in modifyRange into doApply and cleaned up.
No new tests are added since this is a cleanup.
- editing/FormatBlockCommand.cpp: (WebCore::FormatBlockCommand::doApply): Merged with modifyRange; calls doApplyForSingleParagraph. (WebCore::FormatBlockCommand::doApplyForSingleParagraph): Added.
- editing/FormatBlockCommand.h:
- 11:09 AM Changeset in webkit [68336] by
-
- 2 edits in trunk/LayoutTests
2010-09-25 Mihai Parparita <mihaip@chromium.org>
Unreviewed Chromium drt_expectations.txt update.
Speech input appearance tests have image diffs on Linux too.
- platform/chromium/drt_expectations.txt:
- 10:34 AM Changeset in webkit [68335] by
-
- 3 edits2 adds in trunk
<rdar://problem/8478160> Null deref in InlineBox::height()
https://bugs.webkit.org/show_bug.cgi?id=45344
Reviewed by John Sullivan.
WebCore:
Test: fast/css/first-line-parent-style-different.html
- rendering/RenderObject.cpp:
(WebCore::RenderObject::firstLineStyleSlowCase): Set the pseudo style bit on the RenderStyle
which is going to supply the first-line style rather than on this object’s RenderStyle. The
styles may differ.
LayoutTests:
- fast/css/first-line-parent-style-different-expected.txt: Added.
- fast/css/first-line-parent-style-different.html: Added.
- 10:30 AM Changeset in webkit [68334] by
-
- 2 edits in trunk/WebCore
<rdar://problem/8478182> Make canHyphenate() return false for unsupported locales
Reviewed by John Sullivan.
No change in functionality, hence no new test.
- platform/text/cf/HyphenationCF.cpp:
(WebCore::::createValueForKey): Return 0 if hyphenation is not available for the locale.
(WebCore::cfLocaleCache): Moved the definition of the cache from lastHyphenLocation() to
this new getter to allow canHyphenate() to share it.
(WebCore::canHyphenate): Now returns true only if hyphenation is available.
(WebCore::lastHyphenLocation): Added an assertion.
- 10:01 AM Changeset in webkit [68333] by
-
- 2 edits in trunk/WebKit/chromium
2010-09-25 Nicolas Weber <thakis@chromium.org>
Reviewed by James Robinson.
[chromium] Fix clang warning/error.
https://bugs.webkit.org/show_bug.cgi?id=46552
- src/WorkerFileSystemCallbacksBridge.h:
- 9:17 AM Changeset in webkit [68332] by
-
- 2 edits in trunk/LayoutTests
2010-09-25 Andreas Kling <andreas.kling@nokia.com>
Unreviewed, Qt rebaseline after r68331 which fixed dash offset rendering.
- platform/qt/svg/custom/js-repaint-rect-on-path-with-stroke-expected.txt:
- 8:44 AM Changeset in webkit [68331] by
-
- 2 edits in trunk/WebCore
2010-09-25 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] GraphicsContext::setLineDash() should scale dashOffset to penWidth
https://bugs.webkit.org/show_bug.cgi?id=46548
Fixes incorrect rendering of <http://www.carto.net/svg/samples/animated_bustrack.shtml>
This is covered by existing layout tests which need to be rebaselined.
- platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::setLineDash):
- 2:07 AM Changeset in webkit [68330] by
-
- 2 edits in trunk/JavaScriptCore
2010-09-25 Patrick Gansterer <Patrick Gansterer>
Unreviewed.
Fix typo in StringHasher class
https://bugs.webkit.org/show_bug.cgi?id=45970
- wtf/StringHashFunctions.h: (WTF::StringHasher::createHash):
- 12:36 AM Changeset in webkit [68329] by
-
- 2 edits in trunk/WebKitTools
2010-09-25 Nicolas Weber <thakis@chromium.org>
Reviewed by Adam Barth.
https://bugs.webkit.org/show_bug.cgi?id=46555
Fix typo in prepare-ChangeLog's help output.
- Scripts/prepare-ChangeLog:
Sep 24, 2010:
- 11:53 PM Changeset in webkit [68328] by
-
- 3 edits in trunk/LayoutTests
2010-09-24 Mihai Parparita <mihaip@chromium.org>
Unreviewed Chromium test_expectations.txt and drt_expectations.txt update.
fast/canvas/webgl/null-object-behaviour.html and
fast/canvas/webgl/uniform-location.html were unskipped with r68187,
however, they still fail with the DRT (only on the bot, presumably due
to a Leopard-only issue), just like a lot of other WebGL tests.
fast/viewport/viewport-128.html is yet another viewport test that only
the Qt port supports.
animations/opacity-transform-animation.html hasn't passed since it was
committed with r68323.
- platform/chromium/drt_expectations.txt:
- platform/chromium/test_expectations.txt:
- 10:52 PM Changeset in webkit [68327] by
-
- 2 edits in trunk/WebKit/chromium
2010-09-24 Mihai Parparita <mihaip@chromium.org>
Reviewed by Darin Fisher.
[Chromium] Unnecessary blob dependency in WebKit.gyp
https://bugs.webkit.org/show_bug.cgi?id=46488
r66322 shouldn't have added a blob dependency by hand to targets in
WebKit.gyp, instead blob should be a dependency of webkit_support.
http://crrev.com/59406 did that, so we can now remove these deps.
- WebKit.gyp:
- 8:45 PM WebKit Team edited by
- (diff)
- 8:42 PM WebKit Team edited by
- (diff)
- 8:29 PM Changeset in webkit [68326] by
-
- 2 edits in trunk/WebCore
Fix accidental increase in the size of InlineBox by using a bit
field to indicate that a bool should only take up 1 bit.
Rubber-stamped by Dan Bernstein.
- rendering/InlineBox.h:
- 8:26 PM Changeset in webkit [68325] by
-
- 2 edits in trunk/WebKit2
Fix release build.
- WebProcess/InjectedBundle/API/c/WKBundlePage.h:
- 8:05 PM Changeset in webkit [68324] by
-
- 2 edits in trunk/WebKit2
One more build fix.
- UIProcess/API/qt/qwkpage.cpp:
(QWKPagePrivate::setEditCommandState):
- 7:52 PM Changeset in webkit [68323] by
-
- 4 edits4 adds in trunk
2010-09-24 Simon Fraser <Simon Fraser>
Reviewed by Sam Weinig.
Accelerated transitions do not suspend/resume properly.
https://bugs.webkit.org/show_bug.cgi?id=43792
(1) Fix regression from r68233, where if an animation affected two
properties, only one would animate. The testcase tests this.
(2) Fix a flash at the end of an animation or transition that has been
paused and resumed. The flash occurred because we used CAAnimation's
timeOffset when resuming to push the start of the animation into
the past. However, timeOffset does not play nicely with fill modes,
causing a single frame of animation with the element in its unanimated state.
Fixed this by offsetting the beginTime into the past, rather than setting
timeOffset. Normally we submit animations with beginTime == 0, and rely
on CA assigning a beginTime when the animation is committed. This beginTime
is then passed to AnimationController to sync hardware and software animations.
However, since the code now assigns beginTimes in the past (on resume),
we now have to denote whether we've done this, and send an appropriate
timestamp back to AnimationController.
(3) Finally, the patch removes PropertyAnimationPair and just uses LayerPropertyAnimation
instead. This is just cleanup.
Test: animations/opacity-transform-animation.html
- platform/graphics/mac/GraphicsLayerCA.h: Remove PropertyAnimationPair, and change AnimationsMap to store a vector of LayerPropertyAnimation. New method, animationDidStart(), is called from the -animationDidStart: callback.
- platform/graphics/mac/GraphicsLayerCA.mm: (-[WebAnimationDelegate animationDidStart:]): Just call m_graphicsLayer->animationDidStart() now. (WebCore::animationIdentifier): We need to pass in the property, to fix (1) (WebCore::GraphicsLayerCA::moveOrCopyAnimationsForProperty): Copy the WebKitAnimationBeginTimeSet value, if present. (WebCore::GraphicsLayerCA::animationDidStart): Call notifyAnimationStarted() on the client, after testing if we set a non-zero beginTime on this particular animation. (WebCore::GraphicsLayerCA::updateLayerAnimations): Change to use LayerPropertyAnimation. (WebCore::GraphicsLayerCA::setCAAnimationOnLayer): Set value for WebKitAnimationBeginTimeSetKey if we have a non-zero timeOffset. Make animationID an NSString, to avoid several conversions. (WebCore::GraphicsLayerCA::removeCAAnimationFromLayer): Make animationID an NSString, to avoid several conversions. (WebCore::copyAnimationProperties): Copy WebKitAnimationBeginTimeSetKey if present. (WebCore::GraphicsLayerCA::pauseCAAnimationOnLayer): Make animationID an NSString, to avoid several conversions.
- 7:32 PM Changeset in webkit [68322] by
-
- 23 edits4 adds in trunk
Implement WebKit2 callback equivalent to -[WebUIDelegate mouseDidMoveOverElement:modifierFlags:]
<rdar://problem/8359279>
https://bugs.webkit.org/show_bug.cgi?id=46546
Reviewed by Darin Adler.
WebKit2:
- Adds new WKBundleHitTestResultRef object to represent a content under a cursor.
- Adds new Bundle and UI level mouseDidMoveOverElement UIClient callbacks, with pass through userData to communicate context up to the UIProcess
- Shared/APIObject.h:
- Shared/CoreIPCSupport/WebPageProxyMessageKinds.h:
- UIProcess/API/C/WKPage.h:
- UIProcess/API/qt/qwkpage.cpp:
(QWKPage::QWKPage):
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didReceiveMessage):
(WebKit::WebPageProxy::mouseDidMoveOverElement):
- UIProcess/WebPageProxy.h:
- UIProcess/WebUIClient.cpp:
(WebKit::WebUIClient::mouseDidMoveOverElement):
- UIProcess/WebUIClient.h:
- WebKit2.pro:
- WebKit2.xcodeproj/project.pbxproj:
- WebProcess/InjectedBundle/API/c/WKBundleAPICast.h:
- WebProcess/InjectedBundle/API/c/WKBundleBase.h:
- WebProcess/InjectedBundle/API/c/WKBundleHitTestResult.cpp: Added.
(WKBundleHitTestResultGetTypeID):
(WKBundleHitTestResultGetNodeHandle):
(WKBundleHitTestResultGetFrame):
(WKBundleHitTestResultCopyAbsoluteLinkURL):
- WebProcess/InjectedBundle/API/c/WKBundleHitTestResult.h: Added.
- WebProcess/InjectedBundle/API/c/WKBundlePage.h:
- WebProcess/InjectedBundle/InjectedBundleHitTestResult.cpp: Added.
(WebKit::InjectedBundleHitTestResult::create):
(WebKit::InjectedBundleHitTestResult::nodeHandle):
(WebKit::InjectedBundleHitTestResult::webFrame):
(WebKit::InjectedBundleHitTestResult::absoluteLinkURL):
- WebProcess/InjectedBundle/InjectedBundleHitTestResult.h: Added.
(WebKit::InjectedBundleHitTestResult::coreHitTestResult):
(WebKit::InjectedBundleHitTestResult::InjectedBundleHitTestResult):
(WebKit::InjectedBundleHitTestResult::type):
- WebProcess/InjectedBundle/InjectedBundlePageUIClient.cpp:
(WebKit::InjectedBundlePageUIClient::mouseDidMoveOverElement):
- WebProcess/InjectedBundle/InjectedBundlePageUIClient.h:
- WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::mouseDidMoveOverElement):
- win/WebKit2.vcproj:
WebKitTools:
- MiniBrowser/mac/BrowserWindowController.m:
(mouseDidMoveOverElement):
(-[BrowserWindowController awakeFromNib]):
- MiniBrowser/win/BrowserView.cpp:
(mouseDidMoveOverElement):
(BrowserView::create):
- WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::InjectedBundlePage::InjectedBundlePage):
- WebKitTestRunner/TestController.cpp:
(WTR::createOtherPage):
(WTR::TestController::initialize):
- 6:57 PM Changeset in webkit [68321] by
-
- 2 edits in trunk/WebCore
2010-09-24 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
SVG: Avoid calling pow() in genericParseNumber() unless necessary
https://bugs.webkit.org/show_bug.cgi?id=46537
0.4% speedup on <http://themaninblue.com/experiment/AnimationBenchmark/svg/>
- svg/SVGParserUtilities.cpp: (WebCore::genericParseNumber): Only call pow() when we have an exponent.
- 6:50 PM Changeset in webkit [68320] by
-
- 4 edits in trunk/WebKit2
Build fix.
- UIProcess/API/qt/qwkpage_p.h:
- UIProcess/win/WebView.cpp:
(WebKit::WebView::setEditCommandState):
- UIProcess/win/WebView.h:
- 6:39 PM Changeset in webkit [68319] by
-
- 2 edits in trunk/WebKit/wx
2010-09-24 Kwang Yul Seo <skyul@company100.net>
Reviewed by Andreas Kling.
[wx] ChromeClientWx::scaleFactor must return 1.0
https://bugs.webkit.org/show_bug.cgi?id=46542
The default value of ChromeClientWx::scaleFactor must be 1.0.
Otherwise, canvas element won't be painted.
- WebKitSupport/ChromeClientWx.cpp: (WebCore::ChromeClientWx::scaleFactor):
- 6:36 PM Changeset in webkit [68318] by
-
- 14 edits in trunk/WebKit2
Maui: Pasteboard support (42317)
<rdar://problem/7660537>
https://bugs.webkit.org/show_bug.cgi?id=42317
Reviewed by Darin Adler.
This is the final piece of the pasteboard support for WebKit2.
The menu validation has been hooked up for Mac. The validation is
performed asynchronously and the menu entries updated while the menu
is visible. I've created a generic mechanism to call editing commands
that will make it easy to add new commands we will support in the future.
The commands supported now are copy, cut, paste, pasteAsPlainText, delete
and selectAll.
- Shared/CoreIPCSupport/WebPageProxyMessageKinds.h: Added DidValidateMenuItem.
- UIProcess/API/mac/PageClientImpl.h: Added setEditCommandState.
- UIProcess/API/mac/PageClientImpl.mm: Added setEditCommandState implementation.
(WebKit::PageClientImpl::setEditCommandState): Added.
- UIProcess/API/mac/WKView.mm:
(WebCore::MenuItemInfo::MenuItemInfo):
(-[WKView initWithFrame:pageNamespaceRef:]):
(createSelectorExceptionMap): Added.
(commandNameForSelector): Added.
(-[WKView validateUserInterfaceItem:]): Added implementation.
(-[WKView _setUserInterfaceItemState:enabled:state:]): Added.
- UIProcess/API/mac/WKViewInternal.h:
- UIProcess/PageClient.h:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::validateMenuItem):
(WebKit::WebPageProxy::executeEditCommand):
(WebKit::WebPageProxy::didReceiveMessage): Now processing also
DidValidateMenuItem.
- UIProcess/WebPageProxy.h:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::executeEditingCommand): Fixed.
(WebKit::WebPage::isEditingCommandEnabled): Fixed.
(WebKit::WebPage::validateMenuItem): Added.
(WebKit::WebPage::executeEditCommand): Added.
- WebProcess/WebPage/WebPage.h: Removed cut, copy, paste, selectAll.
Added validateMenuItem and executeEditCommand.
- WebProcess/WebPage/WebPage.messages.in: Added new messages.
- UIProcess/API/qt/qwkpage.cpp:
(WebKit::QWKPage::setEditCommandState): Added.
- UIProcess/API/qt/qwkpage_p.h: Added
- 6:36 PM Changeset in webkit [68317] by
-
- 4 edits in trunk/WebKitTools
2010-09-24 Mihai Parparita <mihaip@chromium.org>
Reviewed by Adam Barth.
Allow rebaselines for webkit-patch rebaseline to be chosen
https://bugs.webkit.org/show_bug.cgi?id=46407
Instead of always rebaselining all failing tests, allow a subset to be
chosen.
- Scripts/webkitpy/common/system/user.py:
- Scripts/webkitpy/tool/commands/rebaseline.py:
- 5:47 PM Changeset in webkit [68316] by
-
- 2 edits in trunk/WebKit2
Build fix.
- WebKit2.xcodeproj/project.pbxproj:
- 5:40 PM Changeset in webkit [68315] by
-
- 32 edits2 copies in branches/audio/WebCore
audio branch: changes in preparation for landing in trunk
- split BiquadProcessor files into BiquadProcessor and BiquadDSPKernel
- HRTFDatabase, HRTFDatabaseLoader, and HRTFPanner cleanup
- AudioPannerNode cleanup
- AudioBasicProcessorNode cleanup
- other misc. cleanup
- 4:36 PM Changeset in webkit [68314] by
-
- 3 edits in trunk/LayoutTests
2010-09-24 Mihai Parparita <mihaip@chromium.org>
Unreviewed Chromium test_expectations.txt and drt_expectations.txt update.
Userscript test now pass with both the Chromium DRT and test_shell
(as of http://crrev.com/60526).
- platform/chromium/drt_expectations.txt:
- platform/chromium/test_expectations.txt:
- 4:33 PM Changeset in webkit [68313] by
-
- 4 edits in trunk
2010-09-24 Martin Robinson <mrobinson@igalia.com>
Reviewed by Gustavo Noronha Silva.
[GTK] opening local files on win32
https://bugs.webkit.org/show_bug.cgi?id=31066
This is tested by changes to the testmimehandling API test.
- platform/network/soup/ResourceHandleSoup.cpp: Properly convert the GContentType of a file into a mime type. This is important for non-Unix platforms.
2010-09-24 Martin Robinson <mrobinson@igalia.com>
Reviewed by Gustavo Noronha Silva.
[GTK] opening local files on win32
https://bugs.webkit.org/show_bug.cgi?id=31066
Add tests that check the mime type returned by local files loaded via file URLs.
- tests/testmimehandling.c: (testRemoteMimeType): Added. (testLocalMimeType): Added. (main): Run tests by using g_test_add_data_func with either testRemoteMimeType or testLocalMimeType.
- 4:22 PM Changeset in webkit [68312] by
-
- 10 edits in trunk
2010-09-24 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Tony Chang.
[chromium] Implement TextInputController::firstRectForCharacterRange
https://bugs.webkit.org/show_bug.cgi?id=38100
The following test now passes on chromium DumpRenderTree:
platform/mac/editing/input/caret-primary-bidi.html
platform/mac/editing/input/firstrectforcharacterrange-plain.html
platform/mac/editing/input/range-for-empty-document.html
editing/inserting/caret-position.html
- platform/chromium/test_expectations.txt:
2010-09-24 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Tony Chang.
[chromium] Implement TextInputController::firstRectForCharacterRange
https://bugs.webkit.org/show_bug.cgi?id=38100
Implemented TextInputController::firstRectForCharacterRange for chromium platform.
Because the function needs to return an array of integers, added makeIntArray to WebBindings.
makeIntArray does not take Vector because WebBindings.h is included in plugin glue code
where it cannot find wtf/Vector.h.
No new tests are added since we need to implement the same feature in chromium side
in order to enable any tests that uses this function.
- public/WebBindings.h:
- public/WebFrame.h:
- src/WebBindings.cpp: (WebKit::makeIntArrayImpl): Added. (WebKit::WebBindings::makeIntArray): Added.
- src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::firstRectForCharacterRange): Added.
- src/WebFrameImpl.h:
2010-09-24 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Tony Chang.
[chromium] Implement TextInputController::firstRectForCharacterRange
https://bugs.webkit.org/show_bug.cgi?id=38100
Implemented TextInputController::firstRectForCharacterRange for chromium platform.
No new tests are added since we need to implement the same feature in chromium side
in order to enable any tests that uses this function.
- DumpRenderTree/chromium/TextInputController.cpp: (TextInputController::firstRectForCharacterRange): Added.
- 4:18 PM Changeset in webkit [68311] by
-
- 2 edits in trunk/LayoutTests
2010-09-24 Tony Chang <tony@chromium.org>
Reviewed by Dimitri Glazkov.
[chromium] add individual entries for repaint failures on mac
https://bugs.webkit.org/show_bug.cgi?id=46517
- platform/chromium/test_expectations.txt:
- 4:17 PM Changeset in webkit [68310] by
-
- 2 edits in trunk/WebCore
2010-09-24 Pawel Hajdan <phajdan.jr@chromium.org>
Reviewed by Dumitru Daniliuc.
Move the implementation of chromium_vfs to webkit for POSIX.
This allows us to link Chrome with system-provided SQLite on Linux.
See also http://code.google.com/p/chromium/issues/detail?id=22208.
https://bugs.webkit.org/show_bug.cgi?id=45416
No new tests.
- platform/sql/chromium/SQLiteFileSystemChromiumPosix.cpp: (sqliteErrorFromPosixError): (releaseLockInfo): (releaseOpenInfo): (findLockInfo): (chromiumCheckReservedLock): (rangeLock): (chromiumLock): (closePendingFds): (chromiumUnlock): (chromiumCloseNoLock): (chromiumClose): (chromiumCheckReservedLockNoop): (chromiumLockNoop): (chromiumUnlockNoop): (seekAndRead): (chromiumRead): (seekAndWrite): (chromiumWrite): (syncWrapper): (chromiumSync): (chromiumTruncate): (chromiumFileSize): (chromiumFileControl): (chromiumSectorSize): (chromiumDeviceCharacteristics): (fillInChromiumFile): (findReusableFd): (chromiumOpen): (chromiumDelete): (chromiumAccess): (chromiumFullPathname): (chromiumDlOpen): (chromiumDlError): (chromiumDlSym): (chromiumDlClose): (chromiumRandomness): (chromiumSleep): (chromiumCurrentTime): (chromiumGetLastError): (WebCore::SQLiteFileSystem::registerSQLiteVFS):
- 4:12 PM Changeset in webkit [68309] by
-
- 12 edits1 add in trunk/WebKit2
Fill in more of PluginProcess
https://bugs.webkit.org/show_bug.cgi?id=46534
Reviewed by Adam Roben.
- DerivedSources.make:
Add PluginProcessProxy.
- Platform/CoreIPC/MessageID.h:
Add a MessageClassPluginProcessProxy message class.
- PluginProcess/PluginProcess.cpp:
(WebKit::PluginProcess::PluginProcess):
Initialize the shutdown timer.
(WebKit::PluginProcess::initializeConnection):
Rename this to initializeConnection to avoid conflicts in the CoreIPC message handler.
(WebKit::PluginProcess::removeWebProcessConnection):
Remove the given web process connection from our vector.
(WebKit::PluginProcess::initialize):
Create the plug-in module.
(WebKit::PluginProcess::createWebProcessConnection):
Create a connection handle and send it to the UI process.
(WebKit::PluginProcess::shutdownTimerFired):
Quit.
- PluginProcess/mac/PluginProcessMainMac.mm:
(WebKit::PluginProcessMain):
Call initializeConnection.
- Scripts/webkit2/messages.py:
Add CoreIPC::MachPort as a special case.
- Scripts/webkit2/messages_unittest.py:
Add test case.
- UIProcess/Plugins/PluginProcessProxy.cpp:
(WebKit::PluginProcessProxy::didCreateWebProcessConnection):
Add empty function.
- UIProcess/Plugins/PluginProcessProxy.messages.in: Added.
- WebKit2.xcodeproj/project.pbxproj:
Add PluginProcessProxy.messages.in.
- WebKit2Prefix.h:
Add an ENABLE_PLUGIN_PROCESS #define which is 0 for now.
- 4:09 PM Changeset in webkit [68308] by
-
- 3 edits in trunk/WebKitTools
2010-09-24 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
commit-queue reports land failures as "PASS"
https://bugs.webkit.org/show_bug.cgi?id=46530
We were ignoring the return value of land instead of passing it back to
CommitQueue. Of course, this was the one case I forgot to test!
- Scripts/webkitpy/tool/bot/commitqueuetask.py:
- Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
- 3:57 PM Changeset in webkit [68307] by
-
- 3 edits3 adds in trunk
2010-09-24 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Dirk Schulze.
SVG: Make SVGLength's stringToLengthType() stricter and faster
https://bugs.webkit.org/show_bug.cgi?id=46066
Add test coverage for handling of invalid SVGLength units.
- svg/custom/invalid-length-units-expected.txt: Added.
- svg/custom/invalid-length-units.html: Added.
- svg/custom/script-tests/invalid-length-units.js: Added. (trySettingLength):
2010-09-24 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Dirk Schulze.
SVG: Make SVGLength's stringToLengthType() stricter and faster
https://bugs.webkit.org/show_bug.cgi?id=46066
Only accept unit names immediately following the numeric value.
This behavior matches Gecko.
Also, using String::endsWith("foo") caused a temporary WTF::String to be created.
Avoid this by comparing characters directly.
10.5% speedup on <http://data.xeoh.net/svg.benchmark/>
Test: svg/custom/invalid-length-units.html
- svg/SVGLength.cpp: (WebCore::stringToLengthType): (WebCore::SVGLength::setValueAsString):
- 3:48 PM Changeset in webkit [68306] by
-
- 3 edits2 deletes in trunk/LayoutTests
2010-09-24 Mihai Parparita <mihaip@chromium.org>
Reviewed by Adam Barth.
Layout test html5lib/runner.html failing on Chromium
https://bugs.webkit.org/show_bug.cgi?id=42845
Rebaseline html5lib tests (diffs from upstream are still only due to V8
differences).
- platform/chromium-mac/html5lib/runner-expected.txt: Removed.
- platform/chromium-win/html5lib/runner-expected.txt: Removed.
- platform/chromium/html5lib/runner-expected.txt:
- platform/chromium/test_expectations.txt:
- 3:47 PM Changeset in webkit [68305] by
-
- 1 edit2 copies in branches/chromium/517
Merge 67716
Review URL: http://codereview.chromium.org/3405033
- 3:31 PM Changeset in webkit [68304] by
-
- 5 edits in trunk
Versioning.
- 3:28 PM Changeset in webkit [68303] by
-
- 1 copy in tags/Safari-534.9
New tag.
- 3:26 PM Changeset in webkit [68302] by
-
- 1 edit in branches/chromium/517/WebCore/rendering/RenderObject.cpp
Merge 68278
Review URL: http://codereview.chromium.org/3497007
- 3:25 PM Changeset in webkit [68301] by
-
- 1 edit2 copies in branches/chromium/517
Merge 68158
Review URL: http://codereview.chromium.org/3404021
- 3:13 PM Changeset in webkit [68300] by
-
- 1 edit4 copies in branches/chromium/517
Merge 68062
Review URL: http://codereview.chromium.org/3471012
- 3:12 PM Changeset in webkit [68299] by
-
- 9 edits in trunk/WebKit2
Give windowed Netscape plugins their own window
The plugin window is a child of the WebView's window. The WebView's
window is in the UI process, and the plugin's window is in the web
process (though someday it will be in the plugin process), but Windows
mostly handles this just fine. Right now we move the plugin's window
in the web process, but we need to do it at paint time in the UI
process instead so that the plugin windows will stay in sync with the
web page's contents. There are also a whole bunch of plugin quirks
that WebKit1 supports that we don't support yet, but that's a task for
another day.
Fixes <http://webkit.org/b/44428> Get basic in-process windowed
plugins working in WebKit2 on Windows
Reviewed by Anders Carlsson.
- WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
(WebKit::NetscapePlugin::destroy):
(WebKit::NetscapePlugin::geometryDidChange):
Call the new platform-specific functions.
- WebProcess/Plugins/Netscape/NetscapePlugin.h: Added
platformDestroy/platformGeometryDidChange, and an m_window member on
Windows to hold our window.
- WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:
(WebKit::NetscapePlugin::platformDestroy):
(WebKit::NetscapePlugin::platformGeometryDidChange):
- WebProcess/Plugins/Netscape/qt/NetscapePluginQt.cpp:
(WebKit::NetscapePlugin::platformDestroy):
(WebKit::NetscapePlugin::platformGeometryDidChange):
Stubbed these out.
- WebProcess/Plugins/Netscape/win/NetscapePluginWin.cpp:
(WebKit::registerPluginView): Added. The code came from
WebCore's PluginViewWin.cpp, though I changed it to add one to
COLOR_WINDOW, since that's what MSDN says we should do.
(WebKit::NetscapePlugin::platformPostInitialize): If we're windowed,
create a window for the plugin and make it a child of the WebView's
window. If we're not windowed, just set m_window to 0.
(WebKit::NetscapePlugin::platformDestroy): Destroy our window if we
have one and it hasn't been destroyed already.
(WebKit::NetscapePlugin::platformGeometryDidChange): Update our
window's size and position.
- WebProcess/Plugins/PluginController.h:
- WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::nativeParentWindow):
- WebProcess/Plugins/PluginView.h:
Added nativeParentWindow on Windows to return the WebView's window.
- 3:12 PM Changeset in webkit [68298] by
-
- 9 edits in trunk/WebKit2
Pass the WebView's HWND over to the web process
The HWND is packaged up in the WebPageCreationParameters and stored in
the WebPage. It will eventually be used by windowed plugins.
Fixes <http://webkit.org/b/46512> WebPage needs access to its
corresponding HWND from the UI process
Reviewed by Anders Carlsson.
- Shared/WebPageCreationParameters.cpp:
(WebKit::WebPageCreationParameters::encode):
(WebKit::WebPageCreationParameters::decode):
Encode and decode the HWND as a uint64_t.
- Shared/WebPageCreationParameters.h: Added a nativeWindow member to
store the HWND.
- UIProcess/PageClient.h: Added a nativeWindow function on Windows.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::creationParameters): Store the HWND from the
page client in the struct to be sent to the web process.
- UIProcess/win/WebView.cpp:
(WebKit::WebView::WebView): Moved the call to initializeWebPage after
we've created our window so that our window will be ready when
WebPageProxy asks for it to send it to the web process.
(WebKit::WebView::nativeWindow): Added. Just returns our window.
- UIProcess/win/WebView.h: Added nativeWindow.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage): Store the HWND in the new m_nativeWindow
member.
- WebProcess/WebPage/WebPage.h:
(WebKit::WebPage::nativeWindow): Added this simple getter.
- 3:11 PM Changeset in webkit [68297] by
-
- 3 edits in trunk/WebKit2
Add WebPageProxy::creationParameters
Fixes <http://webkit.org/b/46510> WebPageProxy has a bunch of
duplicated WebPageCreationParameters code
Reviewed by Anders Carlsson.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::initializeWebPage):
(WebKit::WebPageProxy::reinitializeWebPage):
(WebKit::WebPageProxy::didReceiveSyncMessage):
Use creationParameters.
(WebKit::WebPageProxy::creationParameters):
- UIProcess/WebPageProxy.h:
Added creationParameters.
- 3:11 PM Changeset in webkit [68296] by
-
- 4 edits in trunk/WebKit2
Make WebPage::create take a WebPageCreationParameter struct
It only makes sense, after all.
Fixes <http://webkit.org/b/46502>.
Reviewed by Anders Carlsson.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::create):
(WebKit::WebPage::WebPage):
- WebProcess/WebPage/WebPage.h:
Changed to take a WebPageCreationParameters struct.
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::createWebPage): Changed to pass a
WebPageCreationParameters struct.
- 3:09 PM Changeset in webkit [68295] by
-
- 1 edit2 copies in branches/chromium/517
Merge 67967
Review URL: http://codereview.chromium.org/3389031
- 3:04 PM Changeset in webkit [68294] by
-
- 3 edits in trunk/WebKitTools
2010-09-24 Kenichi Ishibashi <bashi@google.com>
Reviewed by Eric Seidel.
new-run-webkit-tests prints out nothing when build-dumprendertree fails
https://bugs.webkit.org/show_bug.cgi?id=37563
Print error message when build-dumprendertree fails.
- Scripts/webkitpy/layout_tests/port/webkit.py:
- Scripts/webkitpy/layout_tests/run_webkit_tests.py:
- 3:04 PM Changeset in webkit [68293] by
-
- 1 edit in branches/chromium/517/WebCore/html/HTMLFrameOwnerElement.cpp
Merge 67659
Review URL: http://codereview.chromium.org/3427022
- 2:54 PM Changeset in webkit [68292] by
-
- 12 edits2 adds in trunk
2010-09-24 Luiz Agostini <luiz.agostini@openbossa.org>
Reviewed by Kenneth Rohde Christiansen.
Keep viewport information in Document
https://bugs.webkit.org/show_bug.cgi?id=46385
The viewport meta data (layout viewport, scale) needs to be set again when bringing
back a page from the page cache. As the viewport metadata is only retrieved while parsing
the document, we need to store it in the Document class.
- fast/viewport/viewport-128-expected.txt: Copied from LayoutTests/fast/viewport/viewport-19-expected.txt.
- fast/viewport/viewport-128.html: Added.
2010-09-24 Luiz Agostini <luiz.agostini@openbossa.org>
Reviewed by Kenneth Rohde Christiansen.
Keep viewport information in Document
https://bugs.webkit.org/show_bug.cgi?id=46385
The viewport meta data (layout viewport, scale) needs to be set again when bringing
back a page from the page cache. As the viewport metadata is only retrieved while parsing
the document, we need to store it in the Document class.
Test: fast/viewport/viewport-128.html
- WebCore.xcodeproj/project.pbxproj:
- dom/Document.cpp: (WebCore::Document::processViewport): (WebCore::Document::setInPageCache):
- dom/Document.h: (WebCore::Document::viewportArguments):
2010-09-24 Luiz Agostini <luiz.agostini@openbossa.org>
Reviewed by Kenneth Rohde Christiansen.
Keep viewport information in Document
https://bugs.webkit.org/show_bug.cgi?id=46385
The viewport meta data (layout viewport, scale) needs to be set again when bringing
back a page from the page cache. As the viewport metadata is only retrieved while parsing
the document, we need to store it in the Document class.
- Api/qwebframe.cpp: (QWebFramePrivate::viewportArguments):
- Api/qwebframe_p.h:
- Api/qwebpage.cpp: (QWebPage::viewportConfigurationForSize):
- WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::didReceiveViewportArguments):
- WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::viewportAsText):
- WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::dispatchDidCommitLoad):
- 2:47 PM Changeset in webkit [68291] by
-
- 5 edits in trunk/WebKit2
Expose all WebKit2 C API preferences via the Qt API.
Reviewed by Andreas Kling.
Also rename a wrongly named C method (was using Web instead of WK).
- UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesCopyStandardFontFamily):
- UIProcess/API/C/WKPreferences.h:
- UIProcess/API/qt/qwkpreferences.cpp:
(QWKPreferences::setFontFamily):
(QWKPreferences::fontFamily):
(QWKPreferences::testAttribute):
(QWKPreferences::setAttribute):
- UIProcess/API/qt/qwkpreferences.h:
- 2:47 PM BuildBot edited by
- (diff)
- 2:07 PM Changeset in webkit [68290] by
-
- 12 edits in branches/chromium/517
Merge 68061 - 2010-09-22 Matt Perry <mpcomplete@chromium.org>
Reviewed by Darin Fisher.
Trying to reland a version of r67749:
Have V8DOMWindowShell ask the embedder whether to run a V8 extension
in a particular script context.
https://bugs.webkit.org/show_bug.cgi?id=45721
- bindings/v8/V8DOMWindowShell.cpp: (WebCore::V8DOMWindowShell::createNewContext):
- bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::registerExtension):
- bindings/v8/V8Proxy.h:
- loader/EmptyClients.h: (WebCore::EmptyFrameLoaderClient::allowScriptExtension):
- loader/FrameLoaderClient.h:
2010-09-22 Matt Perry <mpcomplete@chromium.org>
Reviewed by Darin Fisher.
Trying to reland a version of r67749:
Have V8DOMWindowShell ask the embedder whether to run a V8 extension
in a particular script context.
https://bugs.webkit.org/show_bug.cgi?id=45721
- public/WebFrameClient.h: (WebKit::WebFrameClient::allowScriptExtension):
- public/WebScriptController.h:
- src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::allowScriptExtension):
- src/FrameLoaderClientImpl.h:
- src/WebScriptController.cpp: (WebKit::WebScriptController::registerExtension):
TBR=mpcomplete@chromium.org
Review URL: http://codereview.chromium.org/3453022
- 2:06 PM Changeset in webkit [68289] by
-
- 2 edits in trunk/JavaScriptCore
2010-09-24 Patrick Gansterer <paroga@paroga.com>
Reviewed by Gavin Barraclough.
Add WTF::StringHasher
https://bugs.webkit.org/show_bug.cgi?id=45970
StringHasher is a class for calculation stringHash out of character string.
This class will unify the different usages of the same algorithm.
- wtf/StringHashFunctions.h: (WTF::StringHasher::StringHasher): (WTF::StringHasher::addCharacters): (WTF::StringHasher::addCharacter): (WTF::StringHasher::hash): (WTF::StringHasher::createHash): (WTF::StringHasher::defaultCoverter): (WTF::StringHasher::addCharactersToHash): (WTF::stringHash):
- 1:54 PM Changeset in webkit [68288] by
-
- 2 edits in trunk/JavaScriptCore
2010-09-24 Oliver Hunt <oliver@apple.com>
Reviewed by Geoffrey Garen.
Variable declarations inside a catch scope don't get propogated to the parent scope
https://bugs.webkit.org/show_bug.cgi?id=46501
Add logic to make variable declaration look for a scope for the
new variable. This allows us to create a scope (eg. for catch)
and then seal it, so that additional variable declarations
contained are propogated to the correct target. Strangely this
comes out as a performance win, but I think it's mostly cache
effects.
- parser/JSParser.cpp: (JSC::JSParser::Scope::Scope): (JSC::JSParser::Scope::preventNewDecls): (JSC::JSParser::Scope::allowsNewDecls): (JSC::JSParser::declareVariable): (JSC::JSParser::parseVarDeclarationList): (JSC::JSParser::parseConstDeclarationList): (JSC::JSParser::parseTryStatement): (JSC::JSParser::parseFormalParameters): (JSC::JSParser::parseFunctionDeclaration):
- 1:47 PM Changeset in webkit [68287] by
-
- 2 edits in trunk/WebKit2
messages_unittest.py should compare the generated results against expected results
https://bugs.webkit.org/show_bug.cgi?id=46490
Reviewed by Adam Roben.
- Scripts/webkit2/messages_unittest.py:
- 1:22 PM Changeset in webkit [68286] by
-
- 8 edits in trunk/LayoutTests
2010-09-24 Stephen White <senorblanco@chromium.org>
Unreviewed; new test baselines and test_expectations update.
[CHROMIUM] Rebaseline some fast/speech test results for chromium-mac. Also mark svg/clip-path/clip-path-text-and-stroke.svg as crashing intermittently.
- platform/chromium-mac/fast/speech/input-appearance-numberandspeech-expected.checksum:
- platform/chromium-mac/fast/speech/input-appearance-numberandspeech-expected.png:
- platform/chromium-mac/fast/speech/input-appearance-searchandspeech-expected.checksum:
- platform/chromium-mac/fast/speech/input-appearance-searchandspeech-expected.png:
- platform/chromium-mac/fast/speech/input-appearance-speechbutton-expected.checksum:
- platform/chromium-mac/fast/speech/input-appearance-speechbutton-expected.png:
- platform/chromium/test_expectations.txt:
- 1:11 PM Changeset in webkit [68285] by
-
- 1 edit1 add in trunk/JavaScriptCore
2010-09-24 İsmail Dönmez <ismail@namtrac.org>
Reviewed by Csaba Osztrogonác.
Add a Windows compatible inttypes.h header to fix WinCE build.
https://bugs.webkit.org/show_bug.cgi?id=46463
- os-win32/inttypes.h: Added.
- 12:43 PM Changeset in webkit [68284] by
-
- 6 edits1 copy in trunk/WebKit2
Make it possible to get the page preferences for Qt WebKit2 port.
Reviewed by Antonio Gomes.
- UIProcess/API/qt/qwkpage.cpp:
(QWKPagePrivate::QWKPagePrivate):
(QWKPage::preferences):
- UIProcess/API/qt/qwkpage.h:
- UIProcess/API/qt/qwkpage_p.h:
- UIProcess/API/qt/qwkpreferences.cpp:
(QWKPreferencesPrivate::createPreferences):
(QWKPreferencesPrivate::createSharedPreferences):
(QWKPreferences::sharedPreferences):
(QWKPreferences::QWKPreferences):
- UIProcess/API/qt/qwkpreferences.h:
- 12:32 PM Changeset in webkit [68283] by
-
- 6 edits in trunk/WebCore
https://bugs.webkit.org/show_bug.cgi?id=46496, rename containingBlockWidthForContent to
containingBlockLogicalWidthForContent.
Reviewed by Sam Weinig.
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::localCaretRect):
- rendering/RenderBox.cpp:
(WebCore::RenderBox::containingBlockLogicalWidthForContent):
(WebCore::RenderBox::computeLogicalWidth):
(WebCore::RenderBox::computeReplacedWidthUsing):
- rendering/RenderBox.h:
- rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::relativePositionOffsetX):
(WebCore::RenderBoxModelObject::containingBlockLogicalWidthForContent):
- rendering/RenderBoxModelObject.h:
- 12:14 PM Changeset in webkit [68282] by
-
- 9 edits in trunk/WebCore
https://bugs.webkit.org/show_bug.cgi?id=46489, rename the lineWidth and left/RightOffset methods
to reflect that they will be logical.
Reviewed by Sam Weinig.
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::determineHorizontalPosition):
(WebCore::RenderBlock::leftSelectionOffset):
(WebCore::RenderBlock::rightSelectionOffset):
(WebCore::RenderBlock::positionNewFloats):
(WebCore::RenderBlock::logicalLeftOffsetForContent):
(WebCore::RenderBlock::logicalLeftOffsetForLine):
(WebCore::RenderBlock::logicalRightOffsetForContent):
(WebCore::RenderBlock::logicalRightOffsetForLine):
(WebCore::RenderBlock::availableLogicalWidthForLine):
(WebCore::RenderBlock::getClearDelta):
- rendering/RenderBlock.h:
(WebCore::RenderBlock::logicalRightOffsetForLine):
(WebCore::RenderBlock::logicalLeftOffsetForLine):
- rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::computeInlineDirectionPositionsForLine):
(WebCore::RenderBlock::layoutInlineChildren):
(WebCore::RenderBlock::skipTrailingWhitespace):
(WebCore::RenderBlock::skipLeadingWhitespace):
(WebCore::RenderBlock::fitBelowFloats):
(WebCore::RenderBlock::findNextLineBreak):
(WebCore::RenderBlock::checkLinesForTextOverflow):
- rendering/RenderBox.cpp:
(WebCore::RenderBox::containingBlockWidthForContent):
- rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::applyLineClamp):
- rendering/RenderListItem.cpp:
(WebCore::RenderListItem::positionListMarker):
- rendering/RenderTable.cpp:
(WebCore::RenderTable::computeLogicalWidth):
- rendering/RootInlineBox.cpp:
(WebCore::RootInlineBox::selectionTop):
- 12:06 PM Changeset in webkit [68281] by
-
- 11 edits in trunk/JavaScriptCore
REGRESSION(r68223): It broke 2-3 tests on bots (Requested by Ossy on #webkit).
https://bugs.webkit.org/show_bug.cgi?id=46448
Reviewed by Gavin Barraclough
Roll this back in, with additional logic to prevent us from delaying construction
of functions named "arguments"
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::dump):
- bytecode/Opcode.h:
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::BytecodeGenerator):
(JSC::BytecodeGenerator::emitInitLazyRegister):
(JSC::BytecodeGenerator::registerFor):
(JSC::BytecodeGenerator::createLazyRegisterIfNecessary):
(JSC::BytecodeGenerator::constRegisterFor):
(JSC::BytecodeGenerator::emitNewFunction):
(JSC::BytecodeGenerator::emitLazyNewFunction):
(JSC::BytecodeGenerator::emitNewFunctionInternal):
- bytecompiler/BytecodeGenerator.h:
- interpreter/Interpreter.cpp:
(JSC::Interpreter::privateExecute):
- jit/JIT.cpp:
(JSC::JIT::privateCompileMainPass):
- jit/JIT.h:
- jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_init_lazy_reg):
(JSC::JIT::emit_op_new_func):
- jit/JITOpcodes32_64.cpp:
(JSC::JIT::emit_op_init_lazy_reg):
- parser/Nodes.h:
(JSC::ScopeNode::needsActivationForMoreThanVariables):
- 11:55 AM Changeset in webkit [68280] by
-
- 2 edits in trunk/WebKit/mac
automaticSpellingCorrectionEnabled isn't updated.
https://bugs.webkit.org/show_bug.cgi?id=46486
<rdar://problem/8475212>
Patch by Jia Pu <jpu@apple.com> on 2010-09-24
Reviewed by Dan Bernstein.
- WebView/WebView.mm:
(+[WebView initialize]): Should update "automaticSpellingCorrectionEnabled"
instead of "automaticTextReplacementEnabled".
- 11:38 AM Changeset in webkit [68279] by
-
- 2 edits in trunk/WebKit/chromium
2010-09-24 Tony Chang <tony@chromium.org>
Unreviewed, fix chromium compile after r68276 which renamed
Render*::minPrefWidth to minPreferredLogicalWidth.
- src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::contentsPreferredWidth):
- 11:21 AM Changeset in webkit [68278] by
-
- 2 edits in trunk/WebCore
2010-09-24 Abhishek Arya <inferno@chromium.org>
Reviewed by Simon Fraser.
Comply with spec by generalizing container on which transforms can be applied.
https://bugs.webkit.org/show_bug.cgi?id=46485
Already covered by existing tests.
- rendering/RenderObject.cpp: (WebCore::RenderObject::getTransformFromContainer):
- 11:08 AM Changeset in webkit [68277] by
-
- 2 edits in trunk/LayoutTests
2010-09-24 Tony Chang <tony@chromium.org>
Unreviewed, updating test_expectations.txt.
Removing tests that are now passing in test_shell.
- platform/chromium/test_expectations.txt:
- 11:07 AM Changeset in webkit [68276] by
-
- 58 edits in trunk/WebCore
https://bugs.webkit.org/show_bug.cgi?id=46482, rename the various prefWidth functions to use
preferredLogicalWidth.
Reviewed by Simon Fraser.
- rendering/AutoTableLayout.cpp:
(WebCore::AutoTableLayout::recalcColumn):
(WebCore::AutoTableLayout::computePreferredLogicalWidths):
(WebCore::AutoTableLayout::calcEffectiveWidth):
- rendering/AutoTableLayout.h:
- rendering/FixedTableLayout.cpp:
(WebCore::FixedTableLayout::calcWidthArray):
(WebCore::FixedTableLayout::computePreferredLogicalWidths):
- rendering/FixedTableLayout.h:
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::layoutBlockChildren):
(WebCore::RenderBlock::layoutPositionedObjects):
(WebCore::RenderBlock::getClearDelta):
(WebCore::RenderBlock::computePreferredLogicalWidths):
(WebCore::RenderBlock::computeInlinePreferredLogicalWidths):
(WebCore::RenderBlock::computeBlockPreferredLogicalWidths):
- rendering/RenderBlock.h:
- rendering/RenderBlockLineLayout.cpp:
(WebCore::dirtyLineBoxesForRenderer):
(WebCore::RenderBlock::layoutInlineChildren):
- rendering/RenderBox.cpp:
(WebCore::RenderBox::RenderBox):
(WebCore::RenderBox::minPreferredLogicalWidth):
(WebCore::RenderBox::maxPreferredLogicalWidth):
(WebCore::RenderBox::computeLogicalWidth):
(WebCore::RenderBox::computeLogicalWidthUsing):
(WebCore::RenderBox::computePositionedLogicalWidth):
(WebCore::RenderBox::computePositionedLogicalWidthUsing):
- rendering/RenderBox.h:
(WebCore::RenderBox::computePreferredLogicalWidths):
- rendering/RenderCounter.cpp:
(WebCore::RenderCounter::computePreferredLogicalWidths):
- rendering/RenderCounter.h:
- rendering/RenderDataGrid.cpp:
(WebCore::RenderDataGrid::computePreferredLogicalWidths):
- rendering/RenderDataGrid.h:
- rendering/RenderFieldset.cpp:
(WebCore::RenderFieldset::computePreferredLogicalWidths):
- rendering/RenderFieldset.h:
- rendering/RenderFileUploadControl.cpp:
(WebCore::RenderFileUploadControl::computePreferredLogicalWidths):
- rendering/RenderFileUploadControl.h:
- rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::calcHorizontalPrefWidths):
(WebCore::RenderFlexibleBox::calcVerticalPrefWidths):
(WebCore::RenderFlexibleBox::computePreferredLogicalWidths):
(WebCore::RenderFlexibleBox::allowedChildFlex):
- rendering/RenderFlexibleBox.h:
- rendering/RenderFrameBase.cpp:
(WebCore::RenderFrameBase::layoutWithFlattening):
- rendering/RenderHTMLCanvas.cpp:
(WebCore::RenderHTMLCanvas::canvasSizeChanged):
- rendering/RenderImage.cpp:
(WebCore::RenderImage::imageChanged):
- rendering/RenderListBox.cpp:
(WebCore::RenderListBox::computePreferredLogicalWidths):
- rendering/RenderListBox.h:
- rendering/RenderListItem.cpp:
(WebCore::RenderListItem::updateMarkerLocation):
(WebCore::RenderListItem::computePreferredLogicalWidths):
- rendering/RenderListItem.h:
- rendering/RenderListMarker.cpp:
(WebCore::RenderListMarker::layout):
(WebCore::RenderListMarker::computePreferredLogicalWidths):
(WebCore::RenderListMarker::updateMargins):
- rendering/RenderListMarker.h:
- rendering/RenderMenuList.cpp:
(WebCore::RenderMenuList::computePreferredLogicalWidths):
- rendering/RenderMenuList.h:
- rendering/RenderObject.cpp:
(WebCore::RenderObject::RenderObject):
(WebCore::RenderObject::setPreferredLogicalWidthsDirty):
(WebCore::RenderObject::invalidateContainerPreferredLogicalWidths):
- rendering/RenderObject.h:
(WebCore::RenderObject::preferredLogicalWidthsDirty):
(WebCore::RenderObject::setNeedsLayoutAndPrefWidthsRecalc):
(WebCore::RenderObject::minPreferredLogicalWidth):
(WebCore::RenderObject::maxPreferredLogicalWidth):
- rendering/RenderReplaced.cpp:
(WebCore::RenderReplaced::computePreferredLogicalWidths):
- rendering/RenderReplaced.h:
- rendering/RenderReplica.cpp:
(WebCore::RenderReplica::computePreferredLogicalWidths):
- rendering/RenderReplica.h:
- rendering/RenderSVGRoot.cpp:
(WebCore::RenderSVGRoot::computePreferredLogicalWidths):
- rendering/RenderSVGRoot.h:
- rendering/RenderScrollbarPart.cpp:
(WebCore::RenderScrollbarPart::computePreferredLogicalWidths):
- rendering/RenderScrollbarPart.h:
- rendering/RenderSlider.cpp:
(WebCore::RenderSlider::computePreferredLogicalWidths):
- rendering/RenderSlider.h:
- rendering/RenderTable.cpp:
(WebCore::RenderTable::computeLogicalWidth):
(WebCore::RenderTable::computePreferredLogicalWidths):
- rendering/RenderTable.h:
- rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::computePreferredLogicalWidths):
- rendering/RenderTableCell.h:
- rendering/RenderTableCol.cpp:
(WebCore::RenderTableCol::computePreferredLogicalWidths):
- rendering/RenderTableCol.h:
- rendering/RenderText.cpp:
(WebCore::RenderText::trimmedPrefWidths):
(WebCore::RenderText::minPreferredLogicalWidth):
(WebCore::RenderText::maxPreferredLogicalWidth):
(WebCore::RenderText::computePreferredLogicalWidths):
(WebCore::RenderText::width):
- rendering/RenderText.h:
- rendering/RenderTextControl.cpp:
(WebCore::RenderTextControl::computePreferredLogicalWidths):
- rendering/RenderTextControl.h:
- rendering/RenderTextControlSingleLine.cpp:
(WebCore::RenderTextControlSingleLine::preferredContentWidth):
(WebCore::RenderTextControlSingleLine::preferredDecorationWidthRight):
- rendering/RenderVideo.cpp:
(WebCore::RenderVideo::updateIntrinsicSize):
- rendering/RenderView.cpp:
(WebCore::RenderView::RenderView):
(WebCore::RenderView::computePreferredLogicalWidths):
(WebCore::RenderView::layout):
- rendering/RenderView.h:
- rendering/TableLayout.h:
- 11:03 AM Changeset in webkit [68275] by
-
- 7 edits2 adds in trunk
DOMWindow::revokeBlobURL erroneously uses ParsedURLString.
https://bugs.webkit.org/show_bug.cgi?id=46434
Reviewed by Alexey Proskuryakov.
WebCore:
Test: fast/files/revoke-blob-url.html
- page/DOMWindow.cpp:
(WebCore::DOMWindow::revokeBlobURL):
LayoutTests:
Add a test. Also update Skipped files for those not-supported platforms.
- fast/files/revoke-blob-url-expected.txt: Added.
- fast/files/revoke-blob-url.html: Added.
- platform/gtk/Skipped:
- platform/mac-wk2/Skipped:
- platform/qt/Skipped:
- platform/win/Skipped:
- 11:00 AM Changeset in webkit [68274] by
-
- 8 edits in trunk/WebKit2
Add WebKit2 C API for setting/getting frame flattening and plugin settings.
http://webkit.org/b/46477
Reviewed by Sam Weinig.
NOTE: The plugin setting was partly done but there was no C API.
- Shared/WebPreferencesStore.cpp:
(WebKit::WebPreferencesStore::WebPreferencesStore):
(WebKit::WebPreferencesStore::encode):
(WebKit::WebPreferencesStore::decode):
- Shared/WebPreferencesStore.h:
- UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesSetFrameFlatteningEnabled):
(WKPreferencesGetFrameFlatteningEnabled):
(WKPreferencesSetPluginsEnabled):
(WKPreferencesGetPluginsEnabled):
- UIProcess/API/C/WKPreferences.h:
- UIProcess/WebPreferences.cpp:
(WebKit::WebPreferences::setFrameFlatteningEnabled):
(WebKit::WebPreferences::frameFlatteningEnabled):
(WebKit::WebPreferences::setPluginsEnabled):
(WebKit::WebPreferences::pluginsEnabled):
- UIProcess/WebPreferences.h:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage):
(WebKit::WebPage::preferencesDidChange):
- 10:51 AM Changeset in webkit [68273] by
-
- 2 edits in trunk/LayoutTests
2010-09-24 Zhenyao Mo <zmo@google.com>
Unreviewed.
Remove outdated WebGL linux entries from chromium/drt_expectations.txt.
- platform/chromium/drt_expectations.txt:
- 10:24 AM Changeset in webkit [68272] by
-
- 8 edits2 adds in trunk/WebKit2
Add WebPageCreationParameters
This struct is used in any messages that end up creating a WebPage.
Using a struct instead of individual parameters will make it easier to
add platform-specific data, such as an HWND on Windows.
Fixes <http://webkit.org/b/46470> Pass parameters for creating a
WebPage in a single struct
Reviewed by Anders Carlsson.
- Shared/WebPageCreationParameters.cpp: Added.
(WebKit::WebPageCreationParameters::encode):
(WebKit::WebPageCreationParameters::decode):
Simple encode/decode functions.
- Shared/WebPageCreationParameters.h: Added.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::initializeWebPage):
(WebKit::WebPageProxy::reinitializeWebPage):
(WebKit::WebPageProxy::didReceiveSyncMessage):
- WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::createWindow):
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::createWebPage):
(WebKit::WebProcess::didReceiveMessage):
- WebProcess/WebProcess.h:
Changed to use WebPageCreationParameters instead of passing the
values individually.
- WebKit2.pro:
- WebKit2.xcodeproj/project.pbxproj:
- win/WebKit2.vcproj:
Added WebPageCreationParameters.
- 10:23 AM Changeset in webkit [68271] by
-
- 7 edits1 delete in trunk/WebKit2
Stop pretending that we know how to encode a DrawingArea and just encode the DrawingAreaInfo directly
DrawingAreaBase and friends were trying to hide the fact that they
were just encoding/decoding a DrawingAreaInfo behind the scenes, but
everyone knew what was going on and it was getting embarassing.
Fixes <http://webkit.org/b/46469> Code to encode/decode a
DrawingAreaInfo is confusing
Reviewed by Anders Carlsson.
- Shared/DrawingAreaBase.cpp: Removed.
- Shared/DrawingAreaBase.h: Removed encode/decode.
- UIProcess/ChunkedUpdateDrawingAreaProxy.h: Removed encode override.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::initializeWebPage):
(WebKit::WebPageProxy::reinitializeWebPage):
(WebKit::WebPageProxy::didReceiveSyncMessage):
Changed to encode the DrawingAreaInfo directly.
- WebKit2.pro:
- WebKit2.xcodeproj/project.pbxproj:
- win/WebKit2.vcproj:
Removed DrawingAreaBase.cpp.
- 10:23 AM Changeset in webkit [68270] by
-
- 6 edits in trunk
https://bugs.webkit.org/show_bug.cgi?id=46474
Reviewed by Sam Weinig.
Patch computeWidthUsing to be block-flow-aware. Rename the WidthType enum to LogicalWidthType. Make computeLogicalWidthUsing
query the style for logical width properties instead of width properties.
fast/css/logical-property-resolution.html now fails and gives bad results. This is expected. It will become correct
again as more layout code gets patched.
WebCore:
- rendering/RenderBox.cpp:
(WebCore::RenderBox::computeLogicalWidth):
(WebCore::RenderBox::computeLogicalWidthUsing):
(WebCore::RenderBox::sizesToIntrinsicWidth):
- rendering/RenderBox.h:
LayoutTests:
- fast/css/logical-property-resolution-expected.txt:
- fast/css/logical-property-resolution.html:
- 10:23 AM Changeset in webkit [68269] by
-
- 9 edits in trunk/WebKit2
Expose a whole DrawingAreaInfo instead of its constituent parts from DrawingAreaBase
This is just a step toward cleaning up how drawing areas are
encoded/ecoded.
Fixes <http://webkit.org/b/46468> DrawingAreaInfo should be used in
more places
Reviewed by Anders Carlsson.
- Shared/DrawingAreaBase.cpp:
(WebKit::DrawingAreaBase::encode): Changed to use info().
- Shared/DrawingAreaBase.h:
(WebKit::DrawingAreaBase::info): Added. Replaces type() and id().
(WebKit::DrawingAreaBase::DrawingAreaBase): Changed to store a
DrawingAreaInfo instead of storing its constituent parts.
- UIProcess/API/mac/WKView.mm:
- UIProcess/ChunkedUpdateDrawingAreaProxy.cpp:
- UIProcess/LayerBackedDrawingAreaProxy.cpp:
- WebProcess/WebPage/ChunkedUpdateDrawingArea.cpp:
- WebProcess/WebPage/LayerBackedDrawingArea.cpp:
- WebProcess/WebPage/WebPage.cpp:
Updated to use info().
- 10:22 AM Changeset in webkit [68268] by
-
- 3 edits in trunk/WebKitTools
2010-09-24 Mihai Parparita <mihaip@chromium.org>
Reviewed by Tony Chang.
NRWT doesn't respect config set with set-webkit-configuration
https://bugs.webkit.org/show_bug.cgi?id=46278
Use Port.default_configuration() instead of hardcoding Release in
ChromiumPort configuration initialization, so that we still inherit the
configuration set by set-webkit-configuration.
- Scripts/webkitpy/layout_tests/port/chromium.py:
- Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
- 10:20 AM Changeset in webkit [68267] by
-
- 2 edits2 adds in trunk/WebKit2
Add WebProcessConnection class
https://bugs.webkit.org/show_bug.cgi?id=46478
Reviewed by Sam Weinig.
- PluginProcess/WebProcessConnection.cpp: Added.
- PluginProcess/WebProcessConnection.h: Added.
Add stubbed out WebProcessConnection class.
- WebKit2.xcodeproj/project.pbxproj:
Add files.
- 10:17 AM Changeset in webkit [68266] by
-
- 2 edits in trunk/WebKit/mac
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=46380
REGRESSION: Crash when downloading a file
Downloading cannot be tested in DRT.
- Misc/WebNSFileManagerExtras.m: (-[NSFileManager _webkit_setMetadataURL:referrer:atPath:]): Don't copy null strings.
- 10:03 AM Changeset in webkit [68265] by
-
- 2 edits5 deletes in trunk/LayoutTests
2010-09-24 Tony Chang <tony@chromium.org>
Reviewed by Kent Tamura.
[chromium] Remove a bad baseline and clean up a comment
https://bugs.webkit.org/show_bug.cgi?id=46446
- platform/chromium-linux/svg/filters/filterRes-expected.checksum: Removed.
- platform/chromium-linux/svg/filters/filterRes-expected.png: Removed.
- platform/chromium-win/svg/filters/filterRes-expected.checksum: Removed.
- platform/chromium-win/svg/filters/filterRes-expected.png: Removed.
- platform/chromium-win/svg/filters/filterRes-expected.txt: Removed.
- platform/chromium/test_expectations.txt:
- 10:03 AM Changeset in webkit [68264] by
-
- 4 edits2 copies in trunk/WebKit2
Add PluginProcess class
https://bugs.webkit.org/show_bug.cgi?id=46476
Reviewed by Sam Weinig.
- PluginProcess/PluginProcess.cpp: Added.
- PluginProcess/PluginProcess.h: Added.
Add stubbed out PluginProcess class.
- PluginProcess/mac/PluginProcessMainMac.mm:
(WebKit::PluginProcessMain):
Initialize the plug-in process.
- WebKit2.xcodeproj/project.pbxproj:
Add files.
- WebProcess/Plugins/PluginProcessConnection.h:
Add a comment about which connection this is.
- 9:51 AM Changeset in webkit [68263] by
-
- 2 edits in trunk/LayoutTests
2010-09-24 Nate Chapin <Nate Chapin>
Unreviewed, chromium expectations update.
http/tests/navigation/ping-* are passing now
that they have had their LayoutTestController patch.
- platform/chromium/test_expectations.txt:
- 9:37 AM Changeset in webkit [68262] by
-
- 2 edits in trunk/WebKit2
Fix windows build.
- Shared/win/PlatformCertificateInfo.cpp:
(WebKit::PlatformCertificateInfo::PlatformCertificateInfo):
- 9:17 AM Changeset in webkit [68261] by
-
- 2 edits in trunk/WebCore
2010-09-24 Andrey Kosyakov <caseq@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: Clicking "Select All" in audits panel has no effect when the checkbox is unchecked
Only add category event listeners to real categories, not to "Select All"
https://bugs.webkit.org/show_bug.cgi?id=46467
- inspector/front-end/AuditLauncherView.js: (WebInspector.AuditLauncherView.prototype._createCategoryElement):
- 9:10 AM Changeset in webkit [68260] by
-
- 5 edits3 adds in trunk/WebKit2
Add Windows implementation of PlatformCertificateInfo
Part of < rdar://problem/8350189>
https://bugs.webkit.org/show_bug.cgi?id=46450
Reviewed by Adam Roben.
- Shared/win/PlatformCertificateInfo.cpp: Added.
(WebKit::PlatformCertificateInfo::PlatformCertificateInfo):
(WebKit::PlatformCertificateInfo::~PlatformCertificateInfo):
(WebKit::PlatformCertificateInfo::encode):
(WebKit::PlatformCertificateInfo::decode):
(WebKit::organizationNameForCertificate):
- Shared/win/PlatformCertificateInfo.h:
(WebKit::PlatformCertificateInfo::certificateContext):
- UIProcess/API/C/win/WKCertificateInfoWin.cpp: Added.
(WKCertificateInfoGetCertificateContext):
- UIProcess/API/C/win/WKCertificateInfoWin.h: Added.
- win/WebKit2.vcproj:
- win/WebKit2Generated.make:
- 9:10 AM Changeset in webkit [68259] by
-
- 2 edits in trunk/WebKitTools
2010-09-24 Chang Shu <chang.shu@nokia.com>
Reviewed by Csaba Osztrogonác.
[Qt] Fix the code to check file existence.
https://bugs.webkit.org/show_bug.cgi?id=46465
- QtTestBrowser/main.cpp: (main):
- 9:01 AM Changeset in webkit [68258] by
-
- 6 edits in trunk/WebKit2
Add WebKit2 C API for setting the font families.
https://bugs.webkit.org/show_bug.cgi?id=46408
Reviewed by Sam Weinig.
- UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesSetStandardFontFamily):
(WebPreferencesCopyStandardFontFamily):
(WKPreferencesSetFixedFontFamily):
(WKPreferencesCopyFixedFontFamily):
(WKPreferencesSetSerifFontFamily):
(WKPreferencesCopySerifFontFamily):
(WKPreferencesSetSansSerifFontFamily):
(WKPreferencesCopySansSerifFontFamily):
(WKPreferencesSetCursiveFontFamily):
(WKPreferencesCopyCursiveFontFamily):
(WKPreferencesSetFantasyFontFamily):
(WKPreferencesCopyFantasyFontFamily):
- UIProcess/API/C/WKPreferences.h:
- UIProcess/WebPreferences.cpp:
(WebKit::WebPreferences::setStandardFontFamily):
(WebKit::WebPreferences::standardFontFamily):
(WebKit::WebPreferences::setFixedFontFamily):
(WebKit::WebPreferences::fixedFontFamily):
(WebKit::WebPreferences::setSerifFontFamily):
(WebKit::WebPreferences::serifFontFamily):
(WebKit::WebPreferences::setSansSerifFontFamily):
(WebKit::WebPreferences::sansSerifFontFamily):
(WebKit::WebPreferences::setCursiveFontFamily):
(WebKit::WebPreferences::cursiveFontFamily):
(WebKit::WebPreferences::setFantasyFontFamily):
(WebKit::WebPreferences::fantasyFontFamily):
- UIProcess/WebPreferences.h:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::preferencesDidChange):
- 8:58 AM Changeset in webkit [68257] by
-
- 3 edits in trunk/WebCore
2010-09-24 Hans Wennborg <hans@chromium.org>
Reviewed by Steve Block.
Remove unnecessary casts in DeviceOrientation V8 bindings
https://bugs.webkit.org/show_bug.cgi?id=46466
Remove unnecessary casts of v8::Value::NumberValue() to double from
the custom v8 bindings code for DeviceOrientation/Motion.
No new tests: just cleanup, no new functionality.
- bindings/v8/custom/V8DeviceMotionEventCustom.cpp: (WebCore::V8DeviceMotionEvent::initDeviceMotionEventCallback):
- bindings/v8/custom/V8DeviceOrientationEventCustom.cpp: (WebCore::V8DeviceOrientationEvent::initDeviceOrientationEventCallback):
- 8:45 AM Changeset in webkit [68256] by
-
- 6 edits in trunk/WebCore
2010-09-24 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: move searchingForNode flag in InspectorController under control of InspectorCookies.
Four functions from Inspector IDL go away.
Searching for node feature of Inspector keeps alive even after navigation.
- inspector/Inspector.idl:
- inspector/InspectorController.cpp: (WebCore::InspectorController::updateInspectorStateCookie): (WebCore::InspectorController::restoreInspectorStateFromCookie): (WebCore::InspectorController::setSearchingForNode): (WebCore::InspectorController::populateScriptObjects):
- inspector/InspectorController.h:
- inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel.prototype.hide): (WebInspector.ElementsPanel.prototype.updateFocusedNode): (WebInspector.ElementsPanel.prototype._setSearchingForNode): (WebInspector.ElementsPanel.prototype.setSearchingForNode): (WebInspector.ElementsPanel.prototype.toggleSearchingForNode):
- inspector/front-end/inspector.js: (WebInspector._updateFocusedNode):
- 8:42 AM Changeset in webkit [68255] by
-
- 2 edits in trunk/LayoutTests
2010-09-24 Satish Sampath <satish@chromium.org>
Unreviewed, updating the baseline for a speech input layout test.
- fast/speech/input-text-speechbutton-expected.txt:
- 8:23 AM Changeset in webkit [68254] by
-
- 2 edits in trunk/WebCore
2010-09-24 Andrei Popescu <andreip@google.com>
Reviewed by Jeremy Orlow.
IDBTransactionCoordinator incorrectly assumes that aborted transactions must have been started or running.
https://bugs.webkit.org/show_bug.cgi?id=46459
No new tests, storage/indexeddb/transaction-basics.html covers this.
Also fixes http://code.google.com/p/chromium/issues/detail?id=56732
- storage/IDBTransactionCoordinator.cpp: (WebCore::IDBTransactionCoordinator::didFinishTransaction):
- 8:08 AM Changeset in webkit [68253] by
-
- 2 edits in trunk/LayoutTests
2010-09-24 Satish Sampath <satish@chromium.org>
Reviewed by NOBODY (OOPS!).
Remove chromium test expectation entries for 3 tests which pass now.
https://bugs.webkit.org/show_bug.cgi?id=46457
These tests were marked as fail when the related images were being updated so removing the
entries now that the new images have landed.
- platform/chromium/test_expectations.txt:
- 7:38 AM Changeset in webkit [68252] by
-
- 13 edits in trunk
2010-09-24 Hans Wennborg <hans@chromium.org>
Reviewed by Steve Block.
Update DeviceMotionEvent to spec
https://bugs.webkit.org/show_bug.cgi?id=46344
- fast/dom/DeviceMotion/script-tests/create-event.js:
- fast/dom/DeviceMotion/create-event-expected.txt: Look for the new attributes.
- fast/dom/DeviceMotion/script-tests/optional-event-properties.js:
- fast/dom/DeviceMotion/optional-event-properties-expected.txt: Test the new attributes.
- fast/dom/script-tests/prototype-inheritance.js: DeviceMotionEvent is not implemented on all platforms, so it should be skipped in this test. This is necessary for platforms that enable the feature to pass the layout tests.
2010-09-24 Hans Wennborg <hans@chromium.org>
Reviewed by Steve Block.
Update DeviceMotionEvent to spec
https://bugs.webkit.org/show_bug.cgi?id=46344
The spec has changed: the DeviceMotionEvent attributes accelerationX,
accelerationY, etc. have been baked into an 'acceleration' attribute
which returns an object with x, y, and z values. Likewise for the
rotation rate. The 'accelerationIncludingGravity' attribute is new.
- WebCore.exp.in: The DeviceMotionData::create member function has changed. Also export create functions for DeviceMotionData::Acceleration and RotationRate.
- bindings/js/JSDeviceMotionEventCustom.cpp: (WebCore::JSDeviceMotionEvent::acceleration): (WebCore::JSDeviceMotionEvent::accelerationIncludingGravity): (WebCore::JSDeviceMotionEvent::rotationRate): (WebCore::JSDeviceMotionEvent::initDeviceMotionEvent): Manually create and return objects with the right attributes for acceleration, accelerationIncludingGravity, and rotationRate. When creating the DeviceMotionData object in initDeviceMotionEvent, accept any input objects that have the right attributes.
- bindings/v8/custom/V8DeviceMotionEventCustom.cpp: (WebCore::V8DeviceMotionEvent::accelerationAccessorGetter): (WebCore::V8DeviceMotionEvent::accelerationIncludingGravityAccessorGetter): (WebCore::V8DeviceMotionEvent::rotationRateAccessorGetter): (WebCore::V8DeviceMotionEvent::initDeviceMotionEventCallback): V8 counterpart to the JSC code above.
- dom/DeviceMotionData.cpp: (WebCore::DeviceMotionData::Acceleration::create): (WebCore::DeviceMotionData::Acceleration::Acceleration): (WebCore::DeviceMotionData::RotationRate::create): (WebCore::DeviceMotionData::RotationRate::RotationRate): (WebCore::DeviceMotionData::create): (WebCore::DeviceMotionData::DeviceMotionData):
- dom/DeviceMotionData.h: (WebCore::DeviceMotionData::Acceleration::canProvideX): (WebCore::DeviceMotionData::Acceleration::canProvideY): (WebCore::DeviceMotionData::Acceleration::canProvideZ): (WebCore::DeviceMotionData::Acceleration::x): (WebCore::DeviceMotionData::Acceleration::y): (WebCore::DeviceMotionData::Acceleration::z): (WebCore::DeviceMotionData::RotationRate::canProvideAlpha): (WebCore::DeviceMotionData::RotationRate::canProvideBeta): (WebCore::DeviceMotionData::RotationRate::canProvideGamma): (WebCore::DeviceMotionData::RotationRate::alpha): (WebCore::DeviceMotionData::RotationRate::beta): (WebCore::DeviceMotionData::RotationRate::gamma): (WebCore::DeviceMotionData::acceleration): (WebCore::DeviceMotionData::accelerationIncludingGravity): (WebCore::DeviceMotionData::rotationRate): Add member classes Acceleration and RotationRate to DeviceMotionData.
- dom/DeviceMotionEvent.idl: Update according to the spec. Acceleration and RotationRate need not be backed by native classes.
- 7:26 AM Changeset in webkit [68251] by
-
- 4 edits in trunk
[Qt] Fix the Wince build.
Patch by Romain Pokrzywka <romain@kdab.com> on 2010-09-24
Reviewed by Simon Hausmann.
.:
- WebKit.pri: Apply msvc flags to wince, too.
WebCore:
- WebCore.pro: Apply msvc flags to wince, too.
- 7:24 AM Changeset in webkit [68250] by
-
- 2 edits in trunk/WebCore
[Qt] Enable building Qt/Webkit with debug symbols
Patch by Anders Bakken <agbakken@gmail.com> on 2010-09-24
Reviewed by Simon Hausmann.
With this patch one can configure with -webkit-debug to build Webkit
with debug symbols without having to manually edit WebCore.pro.
- WebCore.pro:
- 6:46 AM Changeset in webkit [68249] by
-
- 2 edits in trunk/BugsSite
Support Unicode-strings in committers-autocomplete script
Reviewed by Csaba Osztrogonác.
- committers-autocomplete.js:
- 5:44 AM Changeset in webkit [68248] by
-
- 2 edits in trunk/WebCore
2010-09-24 Yael Aharon <yael.aharon@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Web Sockets are insecure with QtWebKit
https://bugs.webkit.org/show_bug.cgi?id=44769
Throw an error when the server certificate is not valid.
DRT currently does not support secure websocket connection,
so no new tests. This was tested with the server at
http://code.google.com/p/pywebsocket instead.
- platform/network/qt/SocketStreamHandleQt.cpp: (WebCore::SocketStreamHandlePrivate::socketSslErrors):
- 5:08 AM Changeset in webkit [68247] by
-
- 2 edits in trunk/WebKit/mac
2010-09-24 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: CRASH at node highlight on MAC Safari.
1) run-safari --debug
2) open inspector
3) open elements panel
4) hover mouse over elements panel items multiple times
5) CRASH
Looks like it is a race condition. WebNodeHighlightView doesn't check
the pointer to WebNodeHighligh object and it can be nil.
- WebInspector/WebNodeHighlightView.mm: (-[WebNodeHighlightView drawRect:]):
- 4:31 AM Changeset in webkit [68246] by
-
- 20 edits in trunk/LayoutTests
2010-09-24 Satish Sampath <satish@chromium.org>
Reviewed by Jeremy Orlow.
Update speech button image baselines for chromium port.
https://bugs.webkit.org/show_bug.cgi?id=46457
- platform/chromium-linux/fast/speech/input-appearance-numberandspeech-expected.checksum:
- platform/chromium-linux/fast/speech/input-appearance-numberandspeech-expected.png:
- platform/chromium-linux/fast/speech/input-appearance-searchandspeech-expected.checksum:
- platform/chromium-linux/fast/speech/input-appearance-searchandspeech-expected.png:
- platform/chromium-linux/fast/speech/input-appearance-speechbutton-expected.checksum:
- platform/chromium-linux/fast/speech/input-appearance-speechbutton-expected.png:
- platform/chromium-mac/fast/speech/input-appearance-numberandspeech-expected.checksum:
- platform/chromium-mac/fast/speech/input-appearance-numberandspeech-expected.png:
- platform/chromium-mac/fast/speech/input-appearance-searchandspeech-expected.checksum:
- platform/chromium-mac/fast/speech/input-appearance-searchandspeech-expected.png:
- platform/chromium-mac/fast/speech/input-appearance-speechbutton-expected.checksum:
- platform/chromium-mac/fast/speech/input-appearance-speechbutton-expected.png:
- platform/chromium-win/fast/speech/input-appearance-numberandspeech-expected.checksum:
- platform/chromium-win/fast/speech/input-appearance-numberandspeech-expected.png:
- platform/chromium-win/fast/speech/input-appearance-searchandspeech-expected.checksum:
- platform/chromium-win/fast/speech/input-appearance-searchandspeech-expected.png:
- platform/chromium-win/fast/speech/input-appearance-speechbutton-expected.checksum:
- platform/chromium-win/fast/speech/input-appearance-speechbutton-expected.png:
- platform/chromium/test_expectations.txt: Disables above tests, they will get enabled again after the chromium patch is submitted.
- 3:16 AM Changeset in webkit [68245] by
-
- 1 edit14 adds in trunk/LayoutTests
2010-09-24 Andrey Kosyakov <caseq@chromium.org>
Unreviewed test expectations update after new tests in 68233.
- platform/chromium-linux/animations/suspend-transform-animation-expected.png: Added.
- platform/chromium-linux/transitions/suspend-transform-transition-expected.png: Added.
- platform/chromium-mac/animations/suspend-transform-animation-expected.checksum: Added.
- platform/chromium-mac/animations/suspend-transform-animation-expected.png: Added.
- platform/chromium-mac/transitions/suspend-transform-transition-expected.checksum: Added.
- platform/chromium-mac/transitions/suspend-transform-transition-expected.png: Added.
- platform/chromium-win-xp/animations/suspend-transform-animation-expected.png: Added.
- platform/chromium-win-xp/transitions/suspend-transform-transition-expected.png: Added.
- platform/chromium-win/animations/suspend-transform-animation-expected.checksum: Added.
- platform/chromium-win/animations/suspend-transform-animation-expected.png: Added.
- platform/chromium-win/transitions/suspend-transform-transition-expected.checksum: Added.
- platform/chromium-win/transitions/suspend-transform-transition-expected.png: Added.
- 2:13 AM Changeset in webkit [68244] by
-
- 2 edits in trunk/LayoutTests
2010-09-24 James Kozianski <koz@chromium.org>
Reviewed by Ojan Vafai.
[chromium] Updated test expectations to match the bots using new auto-update script.
https://bugs.webkit.org/show_bug.cgi?id=46452
Updated expectations to match the bots using the new auto-update script.
- platform/chromium/test_expectations.txt:
- 1:44 AM Changeset in webkit [68243] by
-
- 4 edits in trunk/WebCore
2010-09-24 Jia Pu <jpu@apple.com>
Reviewed by Shinichiro Hamaji.
Need to remove autocorrection underlines in current line when newline is entered.
https://bugs.webkit.org/show_bug.cgi?id=45709
<rdar://problem/8335576>
This change affects only Mac OSX build.
- dom/DocumentMarker.h: Added "CorrectionIndicator" to indicate the words on which we need to draw autocorrection underline. We cannot use existing "Replacement" for this purpose, since it is not meant to be removed once it is added. But we need to remove all autocorrection underlines when a line break or paragraph separator is inserted, which is the behavior in NSTextView. Hence we need a separate marker value for drawing autocorrection underline.
- editing/Editor.cpp: (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges): Add "CorrectionIndicator" when autocorrection takes place. (WebCore::Editor::changeSelectionAfterCommand): Remove "CorrectionIndicator" markers if the command results in inserting paragraph separator.
- rendering/InlineTextBox.cpp: (WebCore::textCheckingLineStyleForMarkerType): Use "CorrectionIndicator" marker instead of "Replacement" to draw autocorrection underline. (WebCore::InlineTextBox::paintDocumentMarkers): Ditto.
- 1:15 AM Changeset in webkit [68242] by
-
- 8 edits in trunk
2010-09-24 Eric Uhrhane <ericu@chromium.org>
Reviewed by David Levin.
Remove unnecessary parameter from AsyncFileWriterClient::didTruncate
https://bugs.webkit.org/show_bug.cgi?id=46390
- fileapi/AsyncFileWriterClient.h:
Added state to FileWriter to replace the parameter.
- fileapi/FileWriter.h:
- fileapi/FileWriter.cpp: (WebCore::FileWriter::truncate): (WebCore::FileWriter::didTruncate):
2010-09-24 Eric Uhrhane <ericu@chromium.org>
Reviewed by David Levin.
Remove unnecessary parameter from AsyncFileWriterClient::didTruncate
https://bugs.webkit.org/show_bug.cgi?id=46390
- public/WebFileWriterClient.h:
- src/AsyncFileWriterChromium.cpp:
- src/AsyncFileWriterChromium.h:
- 1:02 AM Changeset in webkit [68241] by
-
- 13 edits in trunk
2010-09-24 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r68236.
http://trac.webkit.org/changeset/68236
https://bugs.webkit.org/show_bug.cgi?id=46449
compile fix didn't work (Requested by dino_ on #webkit).
- fast/dom/DeviceMotion/create-event-expected.txt:
- fast/dom/DeviceMotion/optional-event-properties-expected.txt:
- fast/dom/DeviceMotion/script-tests/create-event.js:
- fast/dom/DeviceMotion/script-tests/optional-event-properties.js:
- fast/dom/script-tests/prototype-inheritance.js:
2010-09-24 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r68236.
http://trac.webkit.org/changeset/68236
https://bugs.webkit.org/show_bug.cgi?id=46449
compile fix didn't work (Requested by dino_ on #webkit).
- WebCore.exp.in:
- bindings/js/JSDeviceMotionEventCustom.cpp: (WebCore::JSDeviceMotionEvent::xAcceleration): (WebCore::JSDeviceMotionEvent::yAcceleration): (WebCore::JSDeviceMotionEvent::zAcceleration): (WebCore::JSDeviceMotionEvent::xRotationRate): (WebCore::JSDeviceMotionEvent::yRotationRate): (WebCore::JSDeviceMotionEvent::zRotationRate): (WebCore::JSDeviceMotionEvent::initDeviceMotionEvent):
- bindings/v8/custom/V8DeviceMotionEventCustom.cpp: (WebCore::V8DeviceMotionEvent::xAccelerationAccessorGetter): (WebCore::V8DeviceMotionEvent::yAccelerationAccessorGetter): (WebCore::V8DeviceMotionEvent::zAccelerationAccessorGetter): (WebCore::V8DeviceMotionEvent::xRotationRateAccessorGetter): (WebCore::V8DeviceMotionEvent::yRotationRateAccessorGetter): (WebCore::V8DeviceMotionEvent::zRotationRateAccessorGetter): (WebCore::V8DeviceMotionEvent::initDeviceMotionEventCallback):
- dom/DeviceMotionData.cpp: (WebCore::DeviceMotionData::create): (WebCore::DeviceMotionData::DeviceMotionData):
- dom/DeviceMotionData.h: (WebCore::DeviceMotionData::xAcceleration): (WebCore::DeviceMotionData::yAcceleration): (WebCore::DeviceMotionData::zAcceleration): (WebCore::DeviceMotionData::xRotationRate): (WebCore::DeviceMotionData::yRotationRate): (WebCore::DeviceMotionData::zRotationRate): (WebCore::DeviceMotionData::canProvideXAcceleration): (WebCore::DeviceMotionData::canProvideYAcceleration): (WebCore::DeviceMotionData::canProvideZAcceleration): (WebCore::DeviceMotionData::canProvideXRotationRate): (WebCore::DeviceMotionData::canProvideYRotationRate): (WebCore::DeviceMotionData::canProvideZRotationRate):
- dom/DeviceMotionEvent.idl:
- 12:51 AM Changeset in webkit [68240] by
-
- 35 edits1 copy in trunk
2010-09-24 Chris Guillory <chris.guillory@google.com>
Reviewed by Chris Fleizach.
Send webkit accessibility notifications to Chromium.
https://bugs.webkit.org/show_bug.cgi?id=45156
- platform/chromium/accessibility/post-notification-ActiveDescendantChanged-expected.txt:
- platform/chromium/accessibility/post-notification-CheckedStateChanged-expected.txt:
- platform/chromium/accessibility/post-notification-ChildrenChanged-expected.txt:
- platform/chromium/accessibility/post-notification-FocusedUIElementChanged-expected.txt:
- platform/chromium/accessibility/post-notification-FocusedUIElementChanged.html:
- platform/chromium/accessibility/post-notification-LayoutComplete-expected.txt:
- platform/chromium/accessibility/post-notification-LayoutComplete.html:
- platform/chromium/accessibility/post-notification-LiveRegionChanged-expected.txt:
- platform/chromium/accessibility/post-notification-LoadComplete-expected.txt:
- platform/chromium/accessibility/post-notification-LoadComplete.html:
- platform/chromium/accessibility/post-notification-MenuListValueChanged-expected.txt:
- platform/chromium/accessibility/post-notification-RowCollapsed-expected.txt:
- platform/chromium/accessibility/post-notification-RowCountChanged-expected.txt:
- platform/chromium/accessibility/post-notification-RowExpanded-expected.txt:
- platform/chromium/accessibility/post-notification-ScrolledToAnchor-expected.txt:
- platform/chromium/accessibility/post-notification-ScrolledToAnchor.html:
- platform/chromium/accessibility/post-notification-SelectedChildrenChanged-expected.txt:
- platform/chromium/accessibility/post-notification-SelectedTextChanged-expected.txt:
- platform/chromium/accessibility/post-notification-SelectedTextChanged.html:
- platform/chromium/accessibility/post-notification-ValueChanged-expected.txt:
- platform/chromium/accessibility/post-notification.js: (test):
2010-09-24 Chris Guillory <chris.guillory@google.com>
Reviewed by Chris Fleizach.
Send webkit accessibility notifications to Chromium.
https://bugs.webkit.org/show_bug.cgi?id=45156
- WebCore.gypi:
- accessibility/chromium/AXObjectCacheChromium.cpp: (WebCore::AXObjectCache::postPlatformNotification): (WebCore::AXObjectCache::handleFocusedUIElementChanged): (WebCore::AXObjectCache::handleScrolledToAnchor):
- dom/Document.cpp: (WebCore::Document::implicitClose): (WebCore::Document::setFocusedNode):
- editing/SelectionController.h:
- page/ChromeClient.h: (WebCore::ChromeClient::postAccessibilityNotification):
- page/FrameView.cpp: (WebCore::FrameView::layout):
2010-09-24 Chris Guillory <chris.guillory@google.com>
Reviewed by Chris Fleizach.
Send webkit accessibility notifications to Chromium.
https://bugs.webkit.org/show_bug.cgi?id=45156
- public/WebAccessibilityCache.h:
- public/WebViewClient.h:
- src/ChromeClientImpl.cpp: (WebKit::ChromeClientImpl::focusedNodeChanged): (WebKit::ChromeClientImpl::getPopupMenuInfo):
- src/ChromeClientImpl.h:
- src/WebAccessibilityCache.cpp: (WebKit::WebAccessibilityCache::accessibilityEnabled):
- 12:26 AM Changeset in webkit [68239] by
-
- 24 edits in trunk/WebCore
https://bugs.webkit.org/show_bug.cgi?id=46454, rename a bunch of the width and height calculation methods.
Reviewed by Maciej Stachowiak.
calcReplacedWidth -> computeReplacedWidth
calcHorizontalMargins -> computeInlineDirectionMargins
calcVerticalMargins -> computeBlockDirectionMargins
calcWidthUsing -> computeLogicalWidthUsing
calcHeightUsing -> computeLogicalHeightUsing
calcReplacedHeight/HeightUsing -> computeReplacedHeight/HeightUsing
calcAbsoluteHorizontalValues -> computePositionedLogicalWidthUsing
calcAbsoluteVerticalValues -> computePositionedLogicalHeightUsing
calcAbsoluteHorizontal -> computePositionedLogicalWIdth
calcAbsoluteVertical -> computePositionedLogicalHeight
calcAbsoluteHorizontalReplaced -> computePositionedLogicalWidthReplaced
calcAbsoluteVerticalReplaced -> computePositionedLogicalHeightReplaced
calcBorderBoxWidth/Height -> computeBorderBoxLogicalWidth/LogicalHeight
calcContentBoxWidth/Height -> computeContentBoxLogicalWidth/LogicalHeight
shouldCalculateSizeAsReplaced -> shouldComputeSizeAsReplaced
calcPercentageHeight -> computePercentageLogicalHeight
- rendering/AutoTableLayout.cpp:
(WebCore::AutoTableLayout::recalcColumn):
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::adjustPositionedBlock):
(WebCore::RenderBlock::determineHorizontalPosition):
(WebCore::RenderBlock::layoutBlockChild):
(WebCore::RenderBlock::insertFloatingObject):
(WebCore::RenderBlock::calcPrefWidths):
- rendering/RenderBox.cpp:
(WebCore::RenderBox::computeBorderBoxLogicalWidth):
(WebCore::RenderBox::computeBorderBoxLogicalHeight):
(WebCore::RenderBox::computeContentBoxLogicalWidth):
(WebCore::RenderBox::computeContentBoxLogicalHeight):
(WebCore::RenderBox::computeLogicalWidth):
(WebCore::RenderBox::computeLogicalWidthUsing):
(WebCore::RenderBox::computeInlineDirectionMargins):
(WebCore::RenderBox::computeLogicalHeight):
(WebCore::RenderBox::computeLogicalHeightUsing):
(WebCore::RenderBox::computePercentageLogicalHeight):
(WebCore::RenderBox::computeReplacedWidth):
(WebCore::RenderBox::computeReplacedWidthUsing):
(WebCore::RenderBox::computeReplacedHeight):
(WebCore::RenderBox::computeReplacedHeightUsing):
(WebCore::RenderBox::availableHeightUsing):
(WebCore::RenderBox::computeBlockDirectionMargins):
(WebCore::RenderBox::computePositionedLogicalWidth):
(WebCore::RenderBox::computePositionedLogicalWidthUsing):
(WebCore::RenderBox::computePositionedLogicalHeight):
(WebCore::RenderBox::computePositionedLogicalHeightUsing):
(WebCore::RenderBox::computePositionedLogicalWidthReplaced):
(WebCore::RenderBox::computePositionedLogicalHeightReplaced):
- rendering/RenderBox.h:
(WebCore::RenderBox::shouldComputeSizeAsReplaced):
- rendering/RenderDataGrid.cpp:
(WebCore::RenderDataGrid::calcPrefWidths):
- rendering/RenderFileUploadControl.cpp:
(WebCore::RenderFileUploadControl::calcPrefWidths):
- rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::calcPrefWidths):
(WebCore::RenderFlexibleBox::layoutHorizontalBox):
(WebCore::RenderFlexibleBox::layoutVerticalBox):
- rendering/RenderImage.cpp:
(WebCore::RenderImage::computeReplacedWidth):
(WebCore::RenderImage::computeReplacedHeight):
(WebCore::RenderImage::calcAspectRatioWidth):
(WebCore::RenderImage::calcAspectRatioHeight):
- rendering/RenderImage.h:
- rendering/RenderListBox.cpp:
(WebCore::RenderListBox::calcPrefWidths):
- rendering/RenderMenuList.cpp:
(WebCore::RenderMenuList::calcPrefWidths):
- rendering/RenderObject.cpp:
(WebCore::RenderObject::container):
- rendering/RenderObject.h:
(WebCore::RenderObject::computeBlockDirectionMargins):
- rendering/RenderReplaced.cpp:
(WebCore::RenderReplaced::computeReplacedWidth):
(WebCore::RenderReplaced::computeReplacedHeight):
(WebCore::RenderReplaced::calcAspectRatioWidth):
(WebCore::RenderReplaced::calcAspectRatioHeight):
(WebCore::RenderReplaced::calcPrefWidths):
- rendering/RenderReplaced.h:
- rendering/RenderSVGRoot.cpp:
(WebCore::RenderSVGRoot::calcPrefWidths):
(WebCore::RenderSVGRoot::computeReplacedWidth):
(WebCore::RenderSVGRoot::computeReplacedHeight):
- rendering/RenderSVGRoot.h:
- rendering/RenderSlider.cpp:
(WebCore::RenderSlider::calcPrefWidths):
- rendering/RenderTable.cpp:
(WebCore::RenderTable::computeLogicalWidth):
(WebCore::RenderTable::layout):
- rendering/RenderTableRow.cpp:
(WebCore::RenderTableRow::layout):
- rendering/RenderTextControl.cpp:
(WebCore::RenderTextControl::calcPrefWidths):
- rendering/RenderVideo.cpp:
(WebCore::RenderVideo::computeReplacedWidth):
(WebCore::RenderVideo::computeReplacedHeight):
- rendering/RenderVideo.h:
Sep 23, 2010:
- 11:45 PM Changeset in webkit [68238] by
-
- 32 edits in trunk/WebCore
https://bugs.webkit.org/show_bug.cgi?id=46451
Reviewed by Sam Weinig.
Rename calcWidth to computeLogicalWidth. Rename calcHeight to computeLogicalHeight.
- rendering/RenderApplet.cpp:
(WebCore::RenderApplet::layout):
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::layoutBlock):
(WebCore::RenderBlock::insertFloatingObject):
(WebCore::RenderBlock::getClearDelta):
- rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::computeInlineDirectionPositionsForLine):
- rendering/RenderBox.cpp:
(WebCore::RenderBox::computeLogicalWidth):
(WebCore::RenderBox::computeLogicalHeight):
(WebCore::RenderBox::calcPercentageHeight):
(WebCore::RenderBox::calcReplacedHeightUsing):
(WebCore::RenderBox::availableHeightUsing):
(WebCore::RenderBox::calcAbsoluteHorizontal):
- rendering/RenderBox.h:
(WebCore::RenderBox::tryLayoutDoingPositionedMovementOnly):
- rendering/RenderEmbeddedObject.cpp:
(WebCore::RenderEmbeddedObject::layout):
- rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::layoutBlock):
(WebCore::RenderFlexibleBox::layoutHorizontalBox):
(WebCore::RenderFlexibleBox::layoutVerticalBox):
- rendering/RenderForeignObject.cpp:
(WebCore::RenderForeignObject::computeLogicalWidth):
(WebCore::RenderForeignObject::computeLogicalHeight):
- rendering/RenderForeignObject.h:
- rendering/RenderHTMLCanvas.cpp:
(WebCore::RenderHTMLCanvas::canvasSizeChanged):
- rendering/RenderIFrame.cpp:
(WebCore::RenderIFrame::computeLogicalHeight):
(WebCore::RenderIFrame::computeLogicalWidth):
(WebCore::RenderIFrame::layout):
- rendering/RenderIFrame.h:
- rendering/RenderImage.cpp:
(WebCore::RenderImage::imageChanged):
- rendering/RenderIndicator.cpp:
(WebCore::RenderIndicator::layout):
- rendering/RenderListBox.cpp:
(WebCore::RenderListBox::computeLogicalHeight):
- rendering/RenderListBox.h:
- rendering/RenderMeter.cpp:
(WebCore::RenderMeter::computeLogicalWidth):
(WebCore::RenderMeter::computeLogicalHeight):
- rendering/RenderMeter.h:
- rendering/RenderReplaced.cpp:
(WebCore::RenderReplaced::layout):
- rendering/RenderSVGRoot.cpp:
(WebCore::RenderSVGRoot::layout):
- rendering/RenderSlider.cpp:
(WebCore::RenderSlider::layout):
- rendering/RenderTable.cpp:
(WebCore::RenderTable::computeLogicalWidth):
(WebCore::RenderTable::layout):
- rendering/RenderTable.h:
- rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::computeLogicalWidth):
- rendering/RenderTableCell.h:
- rendering/RenderTextControl.cpp:
(WebCore::RenderTextControl::computeLogicalHeight):
- rendering/RenderTextControl.h:
- rendering/RenderTextControlSingleLine.cpp:
(WebCore::RenderTextControlSingleLine::layout):
(WebCore::RenderTextControlSingleLine::textBlockWidth):
(WebCore::RenderTextControlSingleLine::decorationWidthRight):
(WebCore::RenderTextControlSingleLine::preferredDecorationWidthRight):
(WebCore::RenderTextControlSingleLine::adjustControlHeightBasedOnLineHeight):
- rendering/RenderView.cpp:
(WebCore::RenderView::computeLogicalHeight):
(WebCore::RenderView::computeLogicalWidth):
- rendering/RenderView.h:
- svg/SVGSVGElement.cpp:
(WebCore::SVGSVGElement::svgAttributeChanged):
- 11:24 PM Changeset in webkit [68237] by
-
- 11 edits in trunk/JavaScriptCore
2010-09-23 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r68223.
http://trac.webkit.org/changeset/68223
https://bugs.webkit.org/show_bug.cgi?id=46448
It broke 2-3 tests on bots (Requested by Ossy on #webkit).
- bytecode/CodeBlock.cpp: (JSC::CodeBlock::dump):
- bytecode/Opcode.h:
- bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::BytecodeGenerator): (JSC::BytecodeGenerator::registerFor): (JSC::BytecodeGenerator::constRegisterFor): (JSC::BytecodeGenerator::emitNewFunction):
- bytecompiler/BytecodeGenerator.h:
- interpreter/Interpreter.cpp: (JSC::Interpreter::privateExecute):
- jit/JIT.cpp: (JSC::JIT::privateCompileMainPass):
- jit/JIT.h:
- jit/JITOpcodes.cpp: (JSC::JIT::emit_op_new_func): (JSC::JIT::emit_op_init_arguments):
- jit/JITOpcodes32_64.cpp: (JSC::JIT::emit_op_new_func): (JSC::JIT::emit_op_init_arguments):
- parser/Nodes.h:
- 11:05 PM Changeset in webkit [68236] by
-
- 13 edits in trunk
2010-09-23 Hans Wennborg <hans@chromium.org>
Reviewed by Simon Fraser.
Update DeviceMotionEvent to spec
https://bugs.webkit.org/show_bug.cgi?id=46344
The spec has changed: the DeviceMotionEvent attributes accelerationX,
accelerationY, etc. have been baked into an 'acceleration' attribute
which returns an object with x, y, and z values. Likewise for the
rotation rate. The 'accelerationIncludingGravity' attribute is new.
- WebCore.exp.in: The DeviceMotionData::create member function has changed. Also export create functions for DeviceMotionData::Acceleration and RotationRate.
- bindings/js/JSDeviceMotionEventCustom.cpp: (WebCore::JSDeviceMotionEvent::acceleration): (WebCore::JSDeviceMotionEvent::accelerationIncludingGravity): (WebCore::JSDeviceMotionEvent::rotationRate): (WebCore::JSDeviceMotionEvent::initDeviceMotionEvent): Manually create and return objects with the right attributes for acceleration, accelerationIncludingGravity, and rotationRate. When creating the DeviceMotionData object in initDeviceMotionEvent, accept any input objects that have the right attributes.
- bindings/v8/custom/V8DeviceMotionEventCustom.cpp: (WebCore::V8DeviceMotionEvent::accelerationAccessorGetter): (WebCore::V8DeviceMotionEvent::accelerationIncludingGravityAccessorGetter): (WebCore::V8DeviceMotionEvent::rotationRateAccessorGetter): (WebCore::V8DeviceMotionEvent::initDeviceMotionEventCallback): V8 counterpart to the JSC code above.
- dom/DeviceMotionData.cpp: (WebCore::DeviceMotionData::Acceleration::create): (WebCore::DeviceMotionData::Acceleration::Acceleration): (WebCore::DeviceMotionData::RotationRate::create): (WebCore::DeviceMotionData::RotationRate::RotationRate): (WebCore::DeviceMotionData::create): (WebCore::DeviceMotionData::DeviceMotionData):
- dom/DeviceMotionData.h: (WebCore::DeviceMotionData::Acceleration::canProvideX): (WebCore::DeviceMotionData::Acceleration::canProvideY): (WebCore::DeviceMotionData::Acceleration::canProvideZ): (WebCore::DeviceMotionData::Acceleration::x): (WebCore::DeviceMotionData::Acceleration::y): (WebCore::DeviceMotionData::Acceleration::z): (WebCore::DeviceMotionData::RotationRate::canProvideAlpha): (WebCore::DeviceMotionData::RotationRate::canProvideBeta): (WebCore::DeviceMotionData::RotationRate::canProvideGamma): (WebCore::DeviceMotionData::RotationRate::alpha): (WebCore::DeviceMotionData::RotationRate::beta): (WebCore::DeviceMotionData::RotationRate::gamma): (WebCore::DeviceMotionData::acceleration): (WebCore::DeviceMotionData::accelerationIncludingGravity): (WebCore::DeviceMotionData::rotationRate): Add member classes Acceleration and RotationRate to DeviceMotionData.
- dom/DeviceMotionEvent.idl: Update according to the spec. Acceleration and RotationRate need not be backed by native classes.
2010-09-23 Hans Wennborg <hans@chromium.org>
Reviewed by Simon Fraser.
Update DeviceMotionEvent to spec
https://bugs.webkit.org/show_bug.cgi?id=46344
- fast/dom/DeviceMotion/script-tests/create-event.js:
- fast/dom/DeviceMotion/create-event-expected.txt: Look for the new attributes.
- fast/dom/DeviceMotion/script-tests/optional-event-properties.js:
- fast/dom/DeviceMotion/optional-event-properties-expected.txt: Test the new attributes.
- fast/dom/script-tests/prototype-inheritance.js: DeviceMotionEvent is not implemented on all platforms, so it should be skipped in this test.
- 10:43 PM Changeset in webkit [68235] by
-
- 4 edits in trunk/WebKit2
Unreviewed buildfix after r68220 on WebKit2.
WebKit2 API: Need way to know when a frame is removed from the hierarchy
https://bugs.webkit.org/show_bug.cgi?id=46432
[Qt] qt_wk_didRemoveFrameFromHierarchy needs to be implemented
- UIProcess/API/qt/ClientImpl.cpp:
(qt_wk_didRemoveFrameFromHierarchy):
- UIProcess/API/qt/ClientImpl.h:
- UIProcess/API/qt/qwkpage.cpp:
(QWKPage::QWKPage):
- 9:28 PM Changeset in webkit [68234] by
-
- 2 edits in trunk/WebKitTools
2010-09-23 Tony Chang <tony@chromium.org>
Unreviewed, rolling out r68232.
http://trac.webkit.org/changeset/68232
Broken NRWT on the canary bots.
- Scripts/webkitpy/layout_tests/port/chromium.py:
- 9:17 PM Changeset in webkit [68233] by
-
- 11 edits8 adds in trunk
2010-09-23 Simon Fraser <Simon Fraser>
Reviewed by Dan Bernstein.
Accelerated transitions do not suspend/resume properly.
https://bugs.webkit.org/show_bug.cgi?id=43792
Fix suspending of accelerated transitions.
GraphicsLayer changes unify the handling of transitions and animations
in GraphicsLayer. Both are now identified by name, so the code
now refers to "animationName" rather than "keyframesName". Transitions
use a dummy name which is not a valid keyframe identifier.
Tests: animations/suspend-transform-animation.html
transitions/suspend-transform-transition.html
- page/animation/ImplicitAnimation.h:
- page/animation/ImplicitAnimation.cpp: (WebCore::ImplicitAnimation::pauseAnimation): Call down to the RenderLayerBacking to tell it that an accelerated transition was paused.
- platform/graphics/GraphicsLayer.h:
- platform/graphics/GraphicsLayer.cpp: (WebCore::GraphicsLayer::animationNameForTransition): Create a name for the transition of the given property. (WebCore::GraphicsLayer::addAnimation): Generalize "keyframe" to "animation" in the parameter names. (WebCore::GraphicsLayer::pauseAnimation): ditto (WebCore::GraphicsLayer::removeAnimation): ditto
- platform/graphics/mac/GraphicsLayerCA.h: Parameter renaming, and some method renames for clarity. (WebCore::GraphicsLayerCA::animationIsRunning): (WebCore::GraphicsLayerCA::LayerPropertyAnimation::LayerPropertyAnimation): struct rename for clarity.
- platform/graphics/mac/GraphicsLayerCA.mm: (WebCore::animationIdentifier): the animationName already has the property baked in. (WebCore::GraphicsLayerCA::moveOrCopyLayerAnimation): just deals with one animation now. (WebCore::GraphicsLayerCA::moveOrCopyAnimationsForProperty): we have to trawl through m_runningAnimations to get the identifiers for the animations that need to be copied. (WebCore::GraphicsLayerCA::addAnimation): rename parameters. (WebCore::GraphicsLayerCA::pauseAnimation): re-ordered methods here. member var renames. (WebCore::GraphicsLayerCA::removeAnimation): ditto. (WebCore::GraphicsLayerCA::updateLayerAnimations): no need to iterate over m_transitionPropertiesToRemove, and no more divergence between transitions and animations. (WebCore::GraphicsLayerCA::setCAAnimationOnLayer): renames for clarity. (WebCore::GraphicsLayerCA::removeCAAnimationFromLayer): ditto (WebCore::GraphicsLayerCA::pauseCAAnimationOnLayer): ditto (WebCore::GraphicsLayerCA::createAnimationFromKeyframes): renames (WebCore::GraphicsLayerCA::createTransformAnimationsFromKeyframes): renames (WebCore::GraphicsLayerCA::suspendAnimations): whitespace.
- rendering/RenderLayerBacking.h: Group the transition and animation methods together.
- rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::animationPaused): Re-ordered methods for clarity. (WebCore::RenderLayerBacking::animationFinished): ditto (WebCore::RenderLayerBacking::startTransition): Use animationNameForTransition() to generate the animation identifier. (WebCore::RenderLayerBacking::transitionPaused): Call pauseAnimation, using animationNameForTransition() to generate the animation identifier. (WebCore::RenderLayerBacking::transitionFinished): Call removeAnimation, using animationNameForTransition() to generate the animation identifier. (WebCore::RenderLayerBacking::notifyAnimationStarted): Moved. (WebCore::RenderLayerBacking::notifySyncRequired): Moved.
- 8:57 PM Changeset in webkit [68232] by
-
- 2 edits in trunk/WebKitTools
2010-09-23 Dirk Pranke <dpranke@chromium.org>
Unreviewed, build fix.
r68008 broke new-run-webkit-tests in that the chromium ports no
longer respect set-webkit-configuration. The correct fix for this
is being pursued in bug 46278 (along with a bunch of unit tests),
but in the meantime I'm reverting the particular lines that broke
things. This was tested by hand.
- Scripts/webkitpy/layout_tests/port/chromium.py:
- 8:54 PM Changeset in webkit [68231] by
-
- 1 edit1 delete in trunk/LayoutTests
2010-09-23 Tony Chang <tony@chromium.org>
Unreviewed. Removing a png that I didn't mean to check in. This
pixel result matches Windows so it doesn't need a png (and I forgot
the checksum file anyway).
- platform/chromium-linux/svg/custom/broken-internal-references-expected.png: Removed.
- 8:41 PM Changeset in webkit [68230] by
-
- 4 edits in trunk
2010-09-23 Kent Tamura <tkent@chromium.org>
Reviewed by Dimitri Glazkov.
[Chromium] Fix some IndexedDB tests for DRT
https://bugs.webkit.org/show_bug.cgi?id=46444
- platform/chromium/drt_expectations.txt:
2010-09-23 Kent Tamura <tkent@chromium.org>
Reviewed by Dimitri Glazkov.
[Chromium] Fix some IndexedDB tests for DRT
https://bugs.webkit.org/show_bug.cgi?id=46444
- DEPS: Roll Chromium revision to 60394, which added WebKitClient::createIDBKeysFromSerializedValuesAndKeyPath() implementation.
- 8:38 PM Changeset in webkit [68229] by
-
- 2 edits7 adds11 deletes in trunk/LayoutTests
2010-09-23 Tony Chang <tony@chromium.org>
Reviewed by Dimitri Glazkov.
[chromium] layout test rebaselines
https://bugs.webkit.org/show_bug.cgi?id=46440
These 2 tests were being skipped for an unknown reason. Remove the results
and mark as failing so we can see it on the flakiness dashboard.
- platform/chromium-linux/fast/images/svg-background-partial-redraw-expected.checksum: Removed.
- platform/chromium-linux/fast/images/svg-background-partial-redraw-expected.png: Removed.
- platform/chromium-win/fast/images/svg-background-partial-redraw-expected.checksum: Removed.
- platform/chromium-win/fast/images/svg-background-partial-redraw-expected.png: Removed.
- platform/chromium-win/fast/images/svg-background-partial-redraw-expected.txt: Removed.
- platform/chromium-win/svg/carto.net/tabgroup-expected.png: Removed.
Small antialiasing difference in borders and font metric differences.
- platform/chromium-linux/svg/custom/broken-internal-references-expected.png: Added.
- platform/chromium-linux/svg/custom/broken-internal-references-expected.txt: Added.
- platform/chromium-win/svg/custom/broken-internal-references-expected.checksum: Added.
- platform/chromium-win/svg/custom/broken-internal-references-expected.png: Added.
- platform/chromium-win/svg/custom/broken-internal-references-expected.txt: Added.
This test passes once these bad baselines are removed.
- platform/chromium-mac/svg/clip-path/clip-path-child-clipped-expected.txt: Removed.
- platform/chromium-win/svg/clip-path/clip-path-child-clipped-expected.txt: Removed.
I don't think this is correct, so I'm removing the baseline and I
updated test_expecations.txt with a note.
- platform/chromium-win/svg/custom/use-font-face-crash-expected.checksum: Removed.
- platform/chromium-win/svg/custom/use-font-face-crash-expected.png: Removed.
- platform/chromium-win/svg/custom/use-font-face-crash-expected.txt: Removed.
This is just a difference it error text between V8 and JSC.
- platform/chromium/fast/dom/Window/invalid-protocol-expected.txt: Added.
- platform/chromium/test_expectations.txt:
- 7:28 PM Changeset in webkit [68228] by
-
- 2 edits in trunk/WebKit/mac
2010-09-23 Andy Estes <aestes@apple.com>
Reviewed by Darin Adler.
REGRESSION (r61285): some Dashboard widgets are always invisible due to
HTML parser changes.
https://bugs.webkit.org/show_bug.cgi?id=46435
Enable pre-HTML5 parser quirks if Dashboard is in backward compatibility
mode.
- WebView/WebView.mm: (-[WebView _needsPreHTML5ParserQuirks]): Renamed from shouldUsePreHTML5ParserQuirks(). Return true if WebCore::Settings::usesDashboardCompatibilityMode() is true. (-[WebView _preferencesChangedNotification:]): (-[WebView _setDashboardBehavior:to:]): Enable pre-HTML5 parser quirks if Dashboard behavior is set to backward compatibility mode.
- 7:27 PM Changeset in webkit [68227] by
-
- 2 edits in trunk/WebCore
https://bugs.webkit.org/show_bug.cgi?id=46442
Reviewed by Sam Weinig.
Disallow the setting of block-flow to anything other than "tb" for all table-related display types
and flexible box display types. By disallowing block-flow on the subclasses of RenderBlock like tables
and flexible boxes, we ensure that alterations to the RenderBlock base class won't result in misrenderings
in tables and flexible boxes that try to specify other block flow values.
- css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::adjustRenderStyle):
- 7:12 PM Changeset in webkit [68226] by
-
- 4 edits in trunk/WebKit/chromium
2010-09-23 Kinuko Yasuda <kinuko@chromium.org>
Unreviewed, another attempt to fix build. The code didn't have proper if-defs.
- src/WebWorkerBase.cpp: (WebKit::WebWorkerBase::openFileSystem):
- src/WebWorkerBase.h:
- src/WorkerFileSystemCallbacksBridge.h:
- 6:54 PM Changeset in webkit [68225] by
-
- 3 edits in trunk/WebKit/chromium
2010-09-23 Kinuko Yasuda <kinuko@chromium.org>
Unreviewed; build fix attempt.
- src/WebWorkerBase.cpp: (WebKit::WebWorkerBase::openFileSystem):
- src/WorkerFileSystemCallbacksBridge.h:
- 6:09 PM Changeset in webkit [68224] by
-
- 2 edits in trunk/LayoutTests
2010-09-23 Tony Chang <tony@chromium.org>
Unreviewed. Fix a test expecatation for no-caret-repaint-in-non-content-editable-element.html (should be TEXT not TEXT+IMAGE).
- platform/chromium/test_expectations.txt:
- 5:52 PM Changeset in webkit [68223] by
-
- 11 edits in trunk/JavaScriptCore
2010-09-23 Oliver Hunt <oliver@apple.com>
Reviewed by Geoffrey Garen.
Delay construction of functions that aren't captured
https://bugs.webkit.org/show_bug.cgi?id=46433
If a function isn't captured by an activation there's no
way it can be accessed indirectly, so we can delay the
construction until it's used (similar to what we do with
arguments). We rename the existing op_init_arguments to
op_init_lazy_reg and removed its implicit handling of
the anonymous argument register, and make op_new_function
take a parameter to indicate whether it should null check
the target slot before creating the function object.
- bytecode/CodeBlock.cpp: (JSC::CodeBlock::dump):
- bytecode/Opcode.h:
- bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::BytecodeGenerator): (JSC::BytecodeGenerator::emitInitLazyRegister): (JSC::BytecodeGenerator::registerFor): (JSC::BytecodeGenerator::createLazyRegisterIfNecessary): (JSC::BytecodeGenerator::constRegisterFor): (JSC::BytecodeGenerator::emitNewFunction): (JSC::BytecodeGenerator::emitLazyNewFunction): (JSC::BytecodeGenerator::emitNewFunctionInternal):
- bytecompiler/BytecodeGenerator.h:
- interpreter/Interpreter.cpp: (JSC::Interpreter::privateExecute):
- jit/JIT.cpp: (JSC::JIT::privateCompileMainPass):
- jit/JIT.h:
- jit/JITOpcodes.cpp: (JSC::JIT::emit_op_init_lazy_reg): (JSC::JIT::emit_op_new_func):
- jit/JITOpcodes32_64.cpp: (JSC::JIT::emit_op_init_lazy_reg):
- parser/Nodes.h: (JSC::ScopeNode::needsActivationForMoreThanVariables):
- 5:46 PM Changeset in webkit [68222] by
-
- 24 edits2 adds in trunk
2010-09-23 Kinuko Yasuda <kinuko@chromium.org>
Reviewed by David Levin.
Add Worker support for FileSystem API
https://bugs.webkit.org/show_bug.cgi?id=45808
Added WebWorkerBase::openFileSystem and WebCommonWorkerClient::
openFileSystem to call in to the browser via Worker stub/proxy
in the chromium.
Also added WorkerFileSystemCallbacksBridge class that proxies
requests and callbacks between from/to worker thread to/from the
main thread.
- public/WebCommonWorkerClient.h: (WebKit::WebCommonWorkerClient::openFileSystem): Added.
- src/LocalFileSystemChromium.cpp: (WebCore::LocalFileSystem::localFileSystem): Added. (WebCore::LocalFileSystem::requestFileSystem): Added implementation for workers. In worker case this calls WebWorkerBase::openFileSystem.
- src/WebWorkerBase.cpp: (WebKit::WebWorkerBase::openFileSystem): Added. This is called from LocalFileSystem::requestFileSystem on the worker thread and creates a bridge to call WebCommonWorkerClient::openFileSystem on the main thread.
- src/WebWorkerBase.h:
- src/WebWorkerClientImpl.h: (WebKit::WebWorkerClientImpl::openFileSystem): Added.
- src/WorkerFileSystemCallbacksBridge.cpp: Added.
- src/WorkerFileSystemCallbacksBridge.h: Added.
2010-09-23 Kinuko Yasuda <kinuko@chromium.org>
Reviewed by David Levin.
Add Worker support for FileSystem API
https://bugs.webkit.org/show_bug.cgi?id=45808
Exposed requestFileSystem and Flags constructor on worker contexts.
Also changed how to get the base path for Web file systems (in
non-chromium ports) so that it works for workers too.
This patch assumes each port calls
LocalFileSystem::initializeLocalFileSystem() in its initialization
phase.
No new tests; tests will be added when we have complete implementation.
- bindings/generic/RuntimeEnabledFeatures.cpp: (WebCore::RuntimeEnabledFeatures::fileSystemEnabled): Changed to reflect AsyncFileSystem::isAvailable
- bindings/generic/RuntimeEnabledFeatures.h: Moved the implementation of fileSystemEnabled to .cpp.
- fileapi/LocalFileSystem.cpp: (WebCore::LocalFileSystem::initializeLocalFileSystem): Added. (WebCore::LocalFileSystem::localFileSystem): Added. (WebCore::LocalFileSystem::fileSystemBasePath): Added.
- fileapi/LocalFileSystem.h: (WebCore::LocalFileSystem::~LocalFileSystem): Removed. (As now it's going to be used as a singleton.)
- page/DOMWindow.cpp: (WebCore::DOMWindow::requestFileSystem): Changed to use a singleton instance of LocalFileSystem.
- page/SecurityOrigin.h: (WebCore::SecurityOrigin::canAccessFileSystem): Added.
- page/Settings.cpp: Removed fileSystemRootPath method.
- page/Settings.h: Removed fileSystemRootPath method.
- platform/AsyncFileSystem.cpp: (WebCore::AsyncFileSystem::isAvailable): Added.
- workers/WorkerContext.cpp: (WebCore::WorkerContext::requestFileSystem): Added to expose requestFileSystem method in worker contexts. (WebCore::WorkerContext::Observer): Added. (WebCore::WorkerContext::registerObserver): Added. (WebCore::WorkerContext::unregisterObserver): Added. (WebCore::WorkerContext::notifyObserversOfStop): Added.
- workers/WorkerContext.h:
- workers/WorkerContext.idl:
- workers/WorkerThread.cpp: (WebCore::WorkerThreadShutdownStartTask::performTask): Modified to call workerContext->notifyObserversOfStop to notify worker observers of the worker thread termination.
- 5:29 PM Changeset in webkit [68221] by
-
- 4 edits in trunk/WebCore
2010-09-23 Matthew Delaney <mdelaney@apple.com>
Reviewed by Oliver Hunt.
Lower the default canvas interpolation quality for platforms that use CG
https://bugs.webkit.org/show_bug.cgi?id=45722
Lowered the default image interpolation quality for platforms that
use CG down to low since this is as good as if not better than
other graphics platforms defaults (being bilinear interpolation).
- html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::createImageBuffer):
- html/HTMLCanvasElement.h: Moved in macros for default canvas interp quality.
- platform/graphics/GraphicsContext.h: Moved out macros for default canvas interp quality. It makes more sense for them to be housed where they're used.
- 5:21 PM Changeset in webkit [68220] by
-
- 15 edits in trunk
WebKit2 API: Need way to know when a frame is removed from the hierarchy
<rdar://problem/8414062>
https://bugs.webkit.org/show_bug.cgi?id=46432
Reviewed by Anders Carlsson.
WebKit2:
- Shared/CoreIPCSupport/WebPageProxyMessageKinds.h:
- UIProcess/API/C/WKPage.h:
- UIProcess/WebLoaderClient.cpp:
(WebKit::WebLoaderClient::didRemoveFrameFromHierarchy):
- UIProcess/WebLoaderClient.h:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didReceiveMessage):
(WebKit::WebPageProxy::didRemoveFrameFromHierarchy):
- UIProcess/WebPageProxy.h:
- WebProcess/InjectedBundle/API/c/WKBundlePage.h:
- WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.cpp:
(WebKit::InjectedBundlePageLoaderClient::didRemoveFrameFromHierarchy):
- WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.h:
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::detachedFromParent2):
(WebKit::WebFrameLoaderClient::didTransferChildFrameToNewDocument):
WebKitTools:
- MiniBrowser/mac/BrowserWindowController.m:
(didRemoveFrameFromHierarchy):
(-[BrowserWindowController awakeFromNib]):
- WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::InjectedBundlePage::InjectedBundlePage):
- WebKitTestRunner/TestController.cpp:
(WTR::TestController::initialize):
- 5:09 PM Changeset in webkit [68219] by
-
- 2 edits4 adds in trunk/WebKit2
Add PluginProcessConnection and PluginProcessConnectionManager
https://bugs.webkit.org/show_bug.cgi?id=46425
Reviewed by Sam Weinig.
- WebKit2.xcodeproj/project.pbxproj:
Add files.
- WebProcess/Plugins/PluginProcessConnection.cpp:
Add empty file for now.
- WebProcess/Plugins/PluginProcessConnection.h:
Add header.
- WebProcess/Plugins/PluginProcessConnectionManager.cpp: Added.
(WebKit::PluginProcessConnectionManager::getPluginProcessConnection):
Check for an existing plug-in process connection. If we don't have one, ask the
UI process to create one.
(WebKit::PluginProcessConnectionManager::removePluginProcessConnection):
Remove the connection from our global vector.
- 5:01 PM Changeset in webkit [68218] by
-
- 2 edits7 adds in trunk/LayoutTests
2010-09-23 Tony Chang <tony@chromium.org>
Reviewed by Dimitri Glazkov.
[chromium] add baselines for no-caret-repaint-in-non-content-editable-element.html
https://bugs.webkit.org/show_bug.cgi?id=46428
- platform/chromium-linux/fast/repaint/no-caret-repaint-in-non-content-editable-element-expected.checksum: Added.
- platform/chromium-linux/fast/repaint/no-caret-repaint-in-non-content-editable-element-expected.png: Added.
- platform/chromium-mac/fast/repaint/no-caret-repaint-in-non-content-editable-element-expected.checksum: Added.
- platform/chromium-mac/fast/repaint/no-caret-repaint-in-non-content-editable-element-expected.png: Added.
- platform/chromium-win/fast/repaint/no-caret-repaint-in-non-content-editable-element-expected.checksum: Added.
- platform/chromium-win/fast/repaint/no-caret-repaint-in-non-content-editable-element-expected.png: Added.
- platform/chromium-win/fast/repaint/no-caret-repaint-in-non-content-editable-element-expected.txt: Added.
- platform/chromium/test_expectations.txt:
- 4:58 PM Changeset in webkit [68217] by
-
- 3 edits1 add8 deletes in trunk/LayoutTests
2010-09-23 Mihai Parparita <mihaip@chromium.org>
Reviewed by Dimitri Glazkov.
Convert http/tests/navigation/error404-frames.html to dumpAsText
https://bugs.webkit.org/show_bug.cgi?id=46341
- http/tests/navigation/error404-frames-expected.txt: Added.
- http/tests/navigation/error404-frames.html:
- platform/chromium-linux/http/tests/navigation/error404-frames-expected.checksum: Removed.
- platform/chromium-linux/http/tests/navigation/error404-frames-expected.png: Removed.
- platform/chromium-win/http/tests/navigation/error404-frames-expected.checksum: Removed.
- platform/chromium-win/http/tests/navigation/error404-frames-expected.png: Removed.
- platform/chromium-win/http/tests/navigation/error404-frames-expected.txt: Removed.
- platform/chromium/test_expectations.txt:
- platform/mac/http/tests/navigation/error404-frames-expected.checksum: Removed.
- platform/mac/http/tests/navigation/error404-frames-expected.png: Removed.
- platform/mac/http/tests/navigation/error404-frames-expected.txt: Removed.
- 4:48 PM Changeset in webkit [68216] by
-
- 9 edits in trunk
2010-09-23 Tony Chang <tony@chromium.org>
Reviewed by Dimitri Glazkov.
[chromium] implement layoutTestController.sampleSVGAnimationForElementAtTime
https://bugs.webkit.org/show_bug.cgi?id=46426
- platform/chromium/test_expectations.txt: Mark 4 tests as passing.
2010-09-23 Tony Chang <tony@chromium.org>
Reviewed by Dimitri Glazkov.
[chromium] implement layoutTestController.sampleSVGAnimationForElementAtTime
https://bugs.webkit.org/show_bug.cgi?id=46426
- public/WebFrame.h:
- src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::pauseSVGAnimation):
- src/WebFrameImpl.h:
2010-09-23 Tony Chang <tony@chromium.org>
Reviewed by Dimitri Glazkov.
[chromium] implement layoutTestController.sampleSVGAnimationForElementAtTime
https://bugs.webkit.org/show_bug.cgi?id=46426
- DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): (LayoutTestController::sampleSVGAnimationForElementAtTime):
- DumpRenderTree/chromium/LayoutTestController.h:
- 4:41 PM Changeset in webkit [68215] by
-
- 2 edits2 adds in trunk/LayoutTests
Unreviewed chromium expectations update.
- platform/chromium-linux/svg/in-html/by-reference-expected.txt: Added.
- platform/chromium-win/svg/in-html/by-reference-expected.txt: Added.
- platform/chromium/test_expectations.txt:
- 4:39 PM Changeset in webkit [68214] by
-
- 3 edits1 add9 deletes in trunk/LayoutTests
2010-09-23 Mihai Parparita <mihaip@chromium.org>
Reviewed by Ojan Vafai.
[Chromium] convert clientWidthAfterDocumentIsRemoved to dumpAsText
https://bugs.webkit.org/show_bug.cgi?id=46397
As suggested in http://crbug.com/9613, this should just be a text-only
test.
- fast/dom/clientWidthAfterDocumentIsRemoved-expected.txt: Added.
- fast/dom/clientWidthAfterDocumentIsRemoved.html:
- platform/chromium-linux/fast/dom/clientWidthAfterDocumentIsRemoved-expected.checksum: Removed.
- platform/chromium-linux/fast/dom/clientWidthAfterDocumentIsRemoved-expected.png: Removed.
- platform/chromium-mac/fast/dom/clientWidthAfterDocumentIsRemoved-expected.txt: Removed.
- platform/chromium-win/fast/dom/clientWidthAfterDocumentIsRemoved-expected.checksum: Removed.
- platform/chromium-win/fast/dom/clientWidthAfterDocumentIsRemoved-expected.png: Removed.
- platform/chromium-win/fast/dom/clientWidthAfterDocumentIsRemoved-expected.txt: Removed.
- platform/chromium/test_expectations.txt:
- platform/mac/fast/dom/clientWidthAfterDocumentIsRemoved-expected.checksum: Removed.
- platform/mac/fast/dom/clientWidthAfterDocumentIsRemoved-expected.png: Removed.
- platform/mac/fast/dom/clientWidthAfterDocumentIsRemoved-expected.txt: Removed.
- 4:35 PM Changeset in webkit [68213] by
-
- 6 edits in trunk/LayoutTests
2010-09-23 Tony Chang <tony@chromium.org>
Reviewed by David Levin.
[chromium] make fast/events/standalone-image-drag-to-editable.html non-flakey
https://bugs.webkit.org/show_bug.cgi?id=46381
In chromium, the image that was dropped sometimes hasn't loaded when
the pixel results are taken. This results in a 0x0 image and makes
the test flakey. The fix is to wait for the image load event if it's
not already loaded.
- fast/events/resources/standalone-image-drag-to-editable-frame.html:
- fast/events/standalone-image-drag-to-editable.html:
- platform/chromium-linux/fast/events/standalone-image-drag-to-editable-expected.checksum: Image result with dropped image loaded.
- platform/chromium-linux/fast/events/standalone-image-drag-to-editable-expected.png:
- platform/chromium/test_expectations.txt:
- 4:11 PM Changeset in webkit [68212] by
-
- 2 edits in trunk/JavaScriptCore
<rdar://problem/8460731> ~9.9% speedup when compiling interpreter with llvm-gcc-4.2
https://bugs.webkit.org/show_bug.cgi?id=46423
Reviewed by Oliver Hunt.
- interpreter/Interpreter.cpp:
(JSC::Interpreter::privateExecute): Disable the gcc computed
goto hacks added in r55564 when compiling with llvm-gcc-4.2.
- 4:09 PM Changeset in webkit [68211] by
-
- 2 edits in trunk/WebKitTools
2010-09-23 Martin Robinson <mrobinson@igalia.com>
Reviewed by Nate Chapin.
[GTK] r68199 introduced two test failures
https://bugs.webkit.org/show_bug.cgi?id=46424
Fix a regression handling preference overrides that are attached to boolean properties.
- DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::overridePreference): g_strcasecmp returns 0 when strings match so we must check for that when converting a string to a boolean.
- 3:53 PM Changeset in webkit [68210] by
-
- 6 edits in trunk/WebKit2
Remove the DrawingAreaProxy parameter to WebPagProxy::initializeWebPage
Callers are now required to set the drawing area via
WebPageProxy::setDrawingArea before calling initializeWebPage. This
will allow us to delay calling initializeWebPage on Windows until
after we've created the WebView's HWND, which in turn will allow us to
send the HWND over to the web process when the page is created. (The
drawing area must be set before creating the HWND so that its size can
be updated, etc., as the window is created.)
Fixes <http://webkit.org/b/46409> DrawingAreaProxy parameter to
initializeWebPage is unnecessary, and causes problems on Windows
Reviewed by Anders Carlsson.
- UIProcess/API/mac/WKView.mm:
(-[WKView initWithFrame:pageNamespaceRef:]):
- UIProcess/API/qt/qwkpage.cpp:
(QWKPagePrivate::init):
- UIProcess/win/WebView.cpp:
(WebKit::WebView::WebView):
Added explicit calls to setDrawingArea.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::initializeWebPage):
- UIProcess/WebPageProxy.h:
Removed the DrawingAreaProxy parameter and a stray puts(), and added
an assertion.
- 3:46 PM Changeset in webkit [68209] by
-
- 2 edits in trunk/JavaScriptCore
2010-09-23 Lucas De Marchi <lucas.demarchi@profusion.mobi>
Reviewed by Darin Adler.
Fix usage of enum as if it was a define
https://bugs.webkit.org/show_bug.cgi?id=46355
pthread.h defines PTHREAD_MUTEX_DEFAULT and PTHREAD_MUTEX_NORMAL as an
enum. Hence, it cannot be used by the preprocessor which always
evaluates that condition as true. This was giving a warning when
compiling with gcc and "-Wundef" flag.
The second path, when PTHREAD_MUTEX_DEFAULT is not the same of
PTHREAD_MUTEX_NORMAL, is not slow. So, let's eliminate the first path
and get rid of that #if.
- wtf/ThreadingPthreads.cpp: Always call pthread_mutexattr_init() to set mutex type to PTHREAD_MUTEX_NORMAL. (WTF::Mutex::Mutex):
- 3:26 PM Changeset in webkit [68208] by
-
- 2 edits2 adds2 deletes in trunk/LayoutTests
2010-09-23 Mihai Parparita <mihaip@chromium.org>
Reviewed by Tony Chang.
[Chromium] traversal/node-iterator-prototype.html has incorrect baselines
https://bugs.webkit.org/show_bug.cgi?id=46413
Chromium/V8 actually gets this test right (unlike JSC), but had
incorrect baselines for it checked in by r58524.
- platform/chromium-mac/traversal/node-iterator-prototype-expected.txt: Removed.
- platform/chromium-win/traversal/node-iterator-prototype-expected.txt: Removed.
- platform/chromium/test_expectations.txt:
- platform/chromium/traversal/node-iterator-prototype-expected.txt: Added.
- 3:23 PM Changeset in webkit [68207] by
-
- 3 edits in trunk/JavaScriptCore
2010-09-23 Michael Saboff <msaboff@apple.com>
Reviewed by Geoffrey Garen.
Removed extraneous truncation of ovector on entry and error exit.
Changed the initialization to -1 of vector to only initialize
the start indecies, which is sufficient for the pattern/subpatterns.
Changed the JIT code to not clear the end index for subpatterns
as it isn't needed. These changes are worth ~2.7% on v8-regexp.
https://bugs.webkit.org/show_bug.cgi?id=46404
- runtime/RegExp.cpp: (JSC::RegExp::match):
- yarr/RegexJIT.cpp: (JSC::Yarr::RegexGenerator::generateParenthesesSingle):
- 3:21 PM Changeset in webkit [68206] by
-
- 8 edits in trunk/WebCore
https://bugs.webkit.org/show_bug.cgi?id=46414, rename line box methods that refer specifically to
"horizontal" and "vertical." Replace those terms with "inline direction" and "block direction."
Reviewed by Adele Peterson.
- rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::placeBoxesInInlineDirection):
(WebCore::InlineFlowBox::placeBoxesInBlockDirection):
(WebCore::InlineFlowBox::computeBlockDirectionOverflow):
- rendering/InlineFlowBox.h:
(WebCore::InlineFlowBox::setInlineDirectionOverflowPositions):
(WebCore::InlineFlowBox::setBlockDirectionOverflowPositions):
- rendering/RenderBlock.h:
- rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::computeInlineDirectionPositionsForLine):
(WebCore::RenderBlock::computeBlockDirectionPositionsForLine):
(WebCore::RenderBlock::layoutInlineChildren):
- rendering/RootInlineBox.cpp:
(WebCore::RootInlineBox::alignBoxesInBlockDirection):
- rendering/RootInlineBox.h:
- 3:20 PM Changeset in webkit [68205] by
-
- 6 edits in trunk/WebKit2
Implement handlers for the GetPluginProcessConnection message
https://bugs.webkit.org/show_bug.cgi?id=46415
Reviewed by Darin Adler.
- Shared/CoreIPCSupport/WebProcessProxyMessageKinds.h:
Add GetPluginProcessConnection message kind
- UIProcess/Plugins/PluginProcessManager.cpp:
(WebKit::PluginProcessManager::PluginProcessManager):
Add missing constructor.
- UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::getPluginProcessConnection):
Ask the plug-in process manager for a connection.
(WebKit::WebProcessProxy::didReceiveSyncMessage):
Call getPluginProcessConnection.
- UIProcess/WebProcessProxy.h:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::createPlugin):
Send the GetPluginProcessConnection message.
- 3:08 PM Changeset in webkit [68204] by
-
- 4 edits in trunk/WebKit/qt
2010-09-23 Ademar de Souza Reis Jr <Ademar Reis>
Reviewed by Kenneth Rohde Christiansen.
Fix QWebHapticFeedbackPlayer exposure via QWebKitPlatformPlugin
[Qt] QWebHapticFeedbackPlayer needs correct exposure through QWebKitPlatformPlugin
https://bugs.webkit.org/show_bug.cgi?id=46402
QWebHapticFeedbackPlayer is exported through
QWebKitPlatformPlugin::createExtension(), but
createHapticFeedbackPlayer() and the correct
inheritage are missing.
- Api/qwebkitplatformplugin.h:
- WebCoreSupport/QtPlatformPlugin.cpp: (WebCore::QtPlatformPlugin::createHapticFeedbackPlayer):
- WebCoreSupport/QtPlatformPlugin.h:
- 3:03 PM Changeset in webkit [68203] by
-
- 13 edits in trunk
Revert "2010-09-23 Hans Wennborg <hans@chromium.org>"
Revert r68197 because it breaks the chromium linux build.
https://bugs.webkit.org/show_bug.cgi?id=46344
- 2:56 PM Changeset in webkit [68202] by
-
- 2 edits in trunk/LayoutTests
2010-09-22 Dirk Pranke <dpranke@chromium.org>
Unreviewed, expectations change.
Update the comments to more accurately reflect which tests we expect
to run and pass.
- platform/chromium-gpu/test_expectations.txt:
- 2:49 PM Changeset in webkit [68201] by
-
- 2 edits in trunk/WebKitTools
2010-09-23 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by David Levin.
Fix a condition check in ServerProcess, which becomes relevant when reading binary data.
https://bugs.webkit.org/show_bug.cgi?id=46406
This breaks when the method is called with specified size of data (image data), and the
buffer hasn't yet reached this size.
- Scripts/webkitpy/layout_tests/port/server_process.py: Changed to check for values of index larger than 0.
- 2:47 PM Changeset in webkit [68200] by
-
- 6 edits in trunk/WebCore
https://bugs.webkit.org/show_bug.cgi?id=46403, convert the margin/border/padding accessors
to be logical.
Reviewed by Adele Peterson.
- rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::getFlowSpacingLogicalWidth):
(WebCore::InlineFlowBox::placeBoxesHorizontally):
(WebCore::InlineFlowBox::paintBoxShadow):
(WebCore::InlineFlowBox::paintBoxDecorations):
(WebCore::InlineFlowBox::paintTextDecorations):
- rendering/InlineFlowBox.h:
(WebCore::InlineFlowBox::InlineFlowBox):
(WebCore::InlineFlowBox::marginBorderPaddingLogicalLeft):
(WebCore::InlineFlowBox::marginBorderPaddingLogicalRight):
(WebCore::InlineFlowBox::marginLogicalLeft):
(WebCore::InlineFlowBox::marginLogicalRight):
(WebCore::InlineFlowBox::borderLogicalLeft):
(WebCore::InlineFlowBox::borderLogicalRight):
(WebCore::InlineFlowBox::paddingLogicalLeft):
(WebCore::InlineFlowBox::paddingLogicalRight):
(WebCore::InlineFlowBox::includeLogicalLeftEdge):
(WebCore::InlineFlowBox::includeLogicalRightEdge):
(WebCore::InlineFlowBox::setEdges):
- rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::computeHorizontalPositionsForLine):
- rendering/RenderBox.cpp:
(WebCore::RenderBox::containingBlockWidthForPositioned):
(WebCore::RenderBox::calcAbsoluteHorizontalValues):
(WebCore::RenderBox::calcAbsoluteHorizontalReplaced):
- rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::paintFillLayerExtended):
- 2:36 PM Changeset in webkit [68199] by
-
- 4 edits in trunk
2010-09-23 Martin Robinson <mrobinson@igalia.com>
Reviewed by Nate Chapin.
[GTK] Some tests from r68174 fail on the GTK+ bots
https://bugs.webkit.org/show_bug.cgi?id=46396
Fix since version number in this new WebKitWebSettings property.
- webkit/webkitwebsettings.cpp: (webkit_web_settings_class_init): Fix the since version number.
2010-09-23 Martin Robinson <mrobinson@igalia.com>
Reviewed by Nate Chapin.
[GTK] Some tests from r68174 fail on the GTK+ bots
https://bugs.webkit.org/show_bug.cgi?id=46396
Simplify LayoutTestController::overridePreference to make it easier for
people unfamiliar with the code to keep the list of preferences up to date.
Add the conversion for enable-hyperlink-auditing.
- DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::overridePreference): Use a simple if-else block to determine out the property name for overrridePreference. Also simplify the logic for setting string properties. Add the conversion for enable-hyperlink-auditing.
- 2:36 PM Changeset in webkit [68198] by
-
- 5 edits4 adds in trunk
2010-09-23 Jeff Schiller <jeffschiller@google.com>
Reviewed by David Hyatt.
Test to confirm that object/iframe/embed backgrounds are transparent for SVG documents
https://bugs.webkit.org/show_bug.cgi?id=10687
- platform/mac/svg/in-html/by-reference-expected.txt: Added.
- svg/in-html/by-reference-expected.checksum: Added.
- svg/in-html/by-reference-expected.png: Added.
- svg/in-html/by-reference.html: Added.
2010-09-23 Jeff Schiller <jeffschiller@google.com>
Reviewed by David Hyatt.
Ensure that SVG documents included by reference (object, iframe, embed) have transparent
backgrounds (not white). https://bugs.webkit.org/show_bug.cgi?id=10687
Test: svg/in-html/by-reference.html
- dom/Document.cpp: (WebCore::Document::hasSVGRootNode):
- dom/Document.h: (WebCore::Document::hasSVGRootNode):
- rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::paintFillLayerExtended):
- 2:31 PM Changeset in webkit [68197] by
-
- 13 edits in trunk
2010-09-23 Hans Wennborg <hans@chromium.org>
Reviewed by Simon Fraser.
Update DeviceMotionEvent to spec
https://bugs.webkit.org/show_bug.cgi?id=46344
- fast/dom/DeviceMotion/script-tests/create-event.js:
- fast/dom/DeviceMotion/create-event-expected.txt: Look for the new attributes.
- fast/dom/DeviceMotion/script-tests/optional-event-properties.js:
- fast/dom/DeviceMotion/optional-event-properties-expected.txt: Test the new attributes.
- fast/dom/script-tests/prototype-inheritance.js: DeviceMotionEvent is not implemented on all platforms, so it should be skipped in this test.
2010-09-23 Hans Wennborg <hans@chromium.org>
Reviewed by Simon Fraser.
Update DeviceMotionEvent to spec
https://bugs.webkit.org/show_bug.cgi?id=46344
The spec has changed: the DeviceMotionEvent attributes accelerationX,
accelerationY, etc. have been baked into an 'acceleration' attribute
which returns an object with x, y, and z values. Likewise for the
rotation rate. The 'accelerationIncludingGravity' attribute is new.
- WebCore.exp.in: The DeviceMotionData::create member function has changed. Also export create functions for DeviceMotionData::Acceleration and RotationRate.
- bindings/js/JSDeviceMotionEventCustom.cpp: (WebCore::JSDeviceMotionEvent::acceleration): (WebCore::JSDeviceMotionEvent::accelerationIncludingGravity): (WebCore::JSDeviceMotionEvent::rotationRate): (WebCore::JSDeviceMotionEvent::initDeviceMotionEvent): Manually create and return objects with the right attributes for acceleration, accelerationIncludingGravity, and rotationRate. When creating the DeviceMotionData object in initDeviceMotionEvent, accept any input objects that have the right attributes.
- bindings/v8/custom/V8DeviceMotionEventCustom.cpp: (WebCore::V8DeviceMotionEvent::accelerationAccessorGetter): (WebCore::V8DeviceMotionEvent::accelerationIncludingGravityAccessorGetter): (WebCore::V8DeviceMotionEvent::rotationRateAccessorGetter): (WebCore::V8DeviceMotionEvent::initDeviceMotionEventCallback): V8 counterpart to the JSC code above.
- dom/DeviceMotionData.cpp: (WebCore::DeviceMotionData::Acceleration::create): (WebCore::DeviceMotionData::Acceleration::Acceleration): (WebCore::DeviceMotionData::RotationRate::create): (WebCore::DeviceMotionData::RotationRate::RotationRate): (WebCore::DeviceMotionData::create): (WebCore::DeviceMotionData::DeviceMotionData):
- dom/DeviceMotionData.h: (WebCore::DeviceMotionData::Acceleration::canProvideX): (WebCore::DeviceMotionData::Acceleration::canProvideY): (WebCore::DeviceMotionData::Acceleration::canProvideZ): (WebCore::DeviceMotionData::Acceleration::x): (WebCore::DeviceMotionData::Acceleration::y): (WebCore::DeviceMotionData::Acceleration::z): (WebCore::DeviceMotionData::RotationRate::canProvideAlpha): (WebCore::DeviceMotionData::RotationRate::canProvideBeta): (WebCore::DeviceMotionData::RotationRate::canProvideGamma): (WebCore::DeviceMotionData::RotationRate::alpha): (WebCore::DeviceMotionData::RotationRate::beta): (WebCore::DeviceMotionData::RotationRate::gamma): (WebCore::DeviceMotionData::acceleration): (WebCore::DeviceMotionData::accelerationIncludingGravity): (WebCore::DeviceMotionData::rotationRate): Add member classes Acceleration and RotationRate to DeviceMotionData.
- dom/DeviceMotionEvent.idl: Update according to the spec. Acceleration and RotationRate need not be backed by native classes.
- 2:18 PM Changeset in webkit [68196] by
-
- 3 edits in trunk/WebCore
2010-09-23 Patrick Gansterer <Patrick Gansterer>
Reviewed by Adam Roben.
Set synchronous handle in ResourceHandleWin
https://bugs.webkit.org/show_bug.cgi?id=46395
When loading synchronous network resources, we need to use a synchronous internet handle.
- platform/network/ResourceHandle.h:
- platform/network/win/ResourceHandleWin.cpp: (WebCore::ResourceHandle::loadResourceSynchronously): (WebCore::ResourceHandle::setSynchronousInternetHandle):
- 2:09 PM Changeset in webkit [68195] by
-
- 4 edits2 adds in trunk
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=46326
Crash when trying to create a NodeIterator rooted at a document-less DocumentType node
Test: fast/dom/node-iterator-with-doctype-root.html
- dom/Document.cpp: (WebCore::Document::detachNodeIterator): Added a comment explaining that attach/detach may not always be paired.
- dom/NodeIterator.cpp: (WebCore::NodeIterator::NodeIterator): Don't try to register with the document if there is none. (WebCore::NodeIterator::~NodeIterator): Ditto. (WebCore::NodeIterator::detach): Ditto. (WebCore::NodeIterator::updateForNodeRemoval): There should be a document if we're getting a notification.
- 2:03 PM Changeset in webkit [68194] by
-
- 2 edits in trunk/LayoutTests
2010-09-23 Mihai Parparita <mihaip@chromium.org>
Unreviewed chromium text_expectations.txt change.
Unskip traversal/node-iterator-prototype.html on Chromium, so we can
get updated expectations for it from the bots.
- platform/chromium/test_expectations.txt:
- 1:56 PM Changeset in webkit [68193] by
-
- 1 edit12 adds in trunk/LayoutTests
Unreviewed chromium expectations update.
- platform/chromium-win/svg/dynamic-updates/SVGFEMorphologyElement-dom-in-attr-expected.checksum: Added.
- platform/chromium-win/svg/dynamic-updates/SVGFEMorphologyElement-dom-in-attr-expected.png: Added.
- platform/chromium-win/svg/dynamic-updates/SVGFEMorphologyElement-dom-operator-attr-expected.checksum: Added.
- platform/chromium-win/svg/dynamic-updates/SVGFEMorphologyElement-dom-operator-attr-expected.png: Added.
- platform/chromium-win/svg/dynamic-updates/SVGFEMorphologyElement-dom-radius-attr-expected.checksum: Added.
- platform/chromium-win/svg/dynamic-updates/SVGFEMorphologyElement-dom-radius-attr-expected.png: Added.
- platform/chromium-win/svg/dynamic-updates/SVGFEMorphologyElement-svgdom-in-prop-expected.checksum: Added.
- platform/chromium-win/svg/dynamic-updates/SVGFEMorphologyElement-svgdom-in-prop-expected.png: Added.
- platform/chromium-win/svg/dynamic-updates/SVGFEMorphologyElement-svgdom-operator-prop-expected.checksum: Added.
- platform/chromium-win/svg/dynamic-updates/SVGFEMorphologyElement-svgdom-operator-prop-expected.png: Added.
- platform/chromium-win/svg/dynamic-updates/SVGFEMorphologyElement-svgdom-radius-call-expected.checksum: Added.
- platform/chromium-win/svg/dynamic-updates/SVGFEMorphologyElement-svgdom-radius-call-expected.png: Added.
- 1:53 PM Changeset in webkit [68192] by
-
- 2 edits in trunk/WebCore
2010-09-23 Patrick Gansterer <Patrick Gansterer>
Reviewed by Adam Roben.
Add synchronous loading for local files to ResourceHandleWin
https://bugs.webkit.org/show_bug.cgi?id=46392
- platform/network/win/ResourceHandleWin.cpp: (WebCore::ResourceHandle::start):
- 1:52 PM Changeset in webkit [68191] by
-
- 8 edits in trunk
2010-09-23 Tony Chang <tony@chromium.org>
Reviewed by David Levin.
[chromium] add caretBrowsingEnabled to WebSettings and DRT
https://bugs.webkit.org/show_bug.cgi?id=46388
- public/WebSettings.h:
- src/WebSettingsImpl.cpp: (WebKit::WebSettingsImpl::setCaretBrowsingEnabled):
- src/WebSettingsImpl.h:
2010-09-23 Tony Chang <tony@chromium.org>
Reviewed by David Levin.
[chromium] add caretBrowsingEnabled to WebSettings and DRT
https://bugs.webkit.org/show_bug.cgi?id=46388
- DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::overridePreference):
- DumpRenderTree/chromium/WebPreferences.cpp: (WebPreferences::reset): (WebPreferences::applyTo):
- DumpRenderTree/chromium/WebPreferences.h:
- 1:45 PM Changeset in webkit [68190] by
-
- 3 edits in trunk/WebCore
2010-09-23 Patrick Gansterer <Patrick Gansterer>
Reviewed by Adam Roben.
Remove (has|set)ReceivedResponse() from public ResourceHandleWin API
https://bugs.webkit.org/show_bug.cgi?id=46391
There is no need for this functions to be public, so remove them.
- platform/network/ResourceHandle.h:
- platform/network/win/ResourceHandleWin.cpp: (WebCore::ResourceHandle::onRequestComplete):
- 1:41 PM Changeset in webkit [68189] by
-
- 2 edits in trunk/WebCore
https://bugs.webkit.org/show_bug.cgi?id=46400
Reviewed by Adele Peterson.
Add logicalLeft/Top getter/setters to line boxes.
- rendering/InlineBox.h:
(WebCore::InlineBox::logicalLeft):
(WebCore::InlineBox::setLogicalLeft):
(WebCore::InlineBox::logicalTop):
(WebCore::InlineBox::setLogicalTop):
- 1:35 PM Changeset in webkit [68188] by
-
- 8 edits in trunk
2010-09-23 Matthew Delaney <mdelaney@apple.com>
Reviewed by Simon Fraser.
Reduce minimum DOMTimer interval
https://bugs.webkit.org/show_bug.cgi?id=45362
Since the setInterval call is meant to reflect a global change for
all pages' DOMTimers, it's misleading to have it be a method on a
given page's settings' object. Thus, this patch changes the call to be static.
This simple change to using a static call instead of the page's setting's
method doesn't warrant a test.
- page/Settings.h: Changed the setInterval call to be static.
2010-09-23 Matthew Delaney <mdelaney@apple.com>
Reviewed by Simon Fraser.
Reduce minimum DOMTimer interval
https://bugs.webkit.org/show_bug.cgi?id=45362
- WebView/WebView.mm: Updating set interval call to use Settings' static version inside one time init block.
2010-09-23 Matthew Delaney <mdelaney@apple.com>
Reviewed by Simon Fraser.
Reduce minimum DOMTimer interval
https://bugs.webkit.org/show_bug.cgi?id=45362
- WebView.cpp: Updating set interval call to use Settings' static version inside one time init block.
2010-09-23 Matthew Delaney <mdelaney@apple.com>
Reviewed by Simon Fraser.
Reduce minimum DOMTimer interval
https://bugs.webkit.org/show_bug.cgi?id=45362
- WebProcess/WebPage/WebPage.cpp: Updating set interval call to use Settings' static version.
- 1:24 PM Changeset in webkit [68187] by
-
- 2 edits2 deletes in trunk/LayoutTests
2010-09-23 Mihai Parparita <mihaip@chromium.org>
Reviewed by David Levin.
[Chromium] remove incorrect baselines for two WebGL tests
https://bugs.webkit.org/show_bug.cgi?id=46372
As far as I can tell, these tests were not failing because of
"new-run-webkit-tests's diff trimming line ends", but because they had
chromium-mac baselines checked in with r56251, but then the test was
changed since then, with the chromium-mac baselines not being updated.
The test seems to pass on chromium-mac (both test_shell and DRT) with
the regular baselines.
- platform/chromium-mac/fast/canvas/webgl/null-object-behaviour-expected.txt: Removed.
- platform/chromium-mac/fast/canvas/webgl/uniform-location-expected.txt: Removed.
- platform/chromium/test_expectations.txt:
- 1:21 PM Changeset in webkit [68186] by
-
- 8 edits in trunk/WebCore
https://bugs.webkit.org/show_bug.cgi?id=46386, give line boxes a vertical bit so that it's easy to know
the overall direction of the line without having to ask the containing block.
Reviewed by Dan Bernstein.
Also couldn't resist some cleanup. Tightened up the type of the renderobject passed to RootInlineBox's
constructor to be a RenderBlock. Moved all the virtual logical height stuff outside of the SVG ifdef
since TrailingFloatsRootInlineBox uses it and should work without SVG enabled.
- rendering/EllipsisBox.h:
(WebCore::EllipsisBox::EllipsisBox):
- rendering/InlineBox.h:
(WebCore::InlineBox::InlineBox):
(WebCore::InlineBox::isVertical):
(WebCore::InlineBox::setIsVertical):
- rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::addToLine):
- rendering/RootInlineBox.cpp:
(WebCore::RootInlineBox::RootInlineBox):
(WebCore::RootInlineBox::placeEllipsis):
- rendering/RootInlineBox.h:
- rendering/SVGRootInlineBox.h:
(WebCore::SVGRootInlineBox::SVGRootInlineBox):
- rendering/TrailingFloatsRootInlineBox.h:
(WebCore::TrailingFloatsRootInlineBox::TrailingFloatsRootInlineBox):
- 1:10 PM Changeset in webkit [68185] by
-
- 2 edits in trunk/WebCore
2010-09-23 Patrick Gansterer <Patrick Gansterer>
Reviewed by Adam Roben.
Check for a valid ResourceHandleClient in ResourceHandleWin
https://bugs.webkit.org/show_bug.cgi?id=46389
- platform/network/win/ResourceHandleWin.cpp: (WebCore::ResourceHandle::onRequestComplete): Add checks to ensure client() is not 0.
- 12:55 PM Changeset in webkit [68184] by
-
- 2 edits in trunk/WebCore
2010-09-23 Patrick Gansterer <Patrick Gansterer>
Reviewed by Adam Roben.
Fix ResourceHandleWin::cancel() for network resources
https://bugs.webkit.org/show_bug.cgi?id=46383
- platform/network/win/ResourceHandleWin.cpp: (WebCore::ResourceHandle::onRequestComplete): Check it requestHandle is not 0. (WebCore::ResourceHandle::cancel): Set requestHandle to 0.
- 12:52 PM WebKit Team edited by
- (diff)
- 12:43 PM Changeset in webkit [68183] by
-
- 2 edits in trunk/WebCore
2010-09-23 Patrick Gansterer <Patrick Gansterer>
Reviewed by Adam Roben.
Add handling for form data and additional HTTP headers in ResourceHandleWin
https://bugs.webkit.org/show_bug.cgi?id=46369
- platform/network/win/ResourceHandleWin.cpp: (WebCore::ResourceHandle::start):
- 12:39 PM Changeset in webkit [68182] by
-
- 2 edits in trunk/WebKit2
Try to fix the Windows build
- win/WebKit2Common.vsprops: Add WebKit2/PluginProcess to the include
path.
- 12:37 PM Changeset in webkit [68181] by
-
- 4 edits in trunk
2010-09-23 Eric Carlson <eric.carlson@apple.com>
Reviewed by Simon Fraser
'seeking' event should always fire
https://bugs.webkit.org/show_bug.cgi?id=45694
Update seek algorithm to match current spec.
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::setReadyState): Don't need to fire 'seeking' event here. (WebCore::HTMLMediaElement::seek): Always fire 'seeking'. Update comments. (WebCore::HTMLMediaElement::finishSeek): Update comments. (WebCore::HTMLMediaElement::mediaPlayerTimeChanged): Ditto.
2010-09-23 Eric Carlson <eric.carlson@apple.com>
Reviewed by Simon Fraser
'seeking' event should always fire
https://bugs.webkit.org/show_bug.cgi?id=45694
- media/event-attributes-expected.txt: Update for changes.
- 12:33 PM Changeset in webkit [68180] by
-
- 13 edits1 move in trunk
2010-09-23 Eric Uhrhane <ericu@chromium.org>
Reviewed by David Levin.
Rename FileWriterClient to AsyncFileWriterClient.
https://bugs.webkit.org/show_bug.cgi?id=46325
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- fileapi/AsyncFileWriter.h:
- fileapi/AsyncFileWriterClient.h: Copied from WebCore/fileapi/FileWriterClient.h.
- fileapi/FileWriter.h:
- fileapi/FileWriterClient.h: Removed.
- platform/AsyncFileSystem.h:
2010-09-23 Eric Uhrhane <ericu@chromium.org>
Reviewed by David Levin.
Rename FileWriterClient to AsyncFileWriterClient.
https://bugs.webkit.org/show_bug.cgi?id=46325
- src/AsyncFileSystemChromium.cpp:
- src/AsyncFileSystemChromium.h:
- src/AsyncFileWriterChromium.cpp:
- src/AsyncFileWriterChromium.h:
- 12:24 PM Changeset in webkit [68179] by
-
- 5 edits in trunk/WebKit/win
2010-09-23 Nate Chapin <Nate Chapin>
Unreviewed, build fix.
Move hyperlinkAuditingEnabled to IWebPreferencesPrivate.idl
and touch WebKit.idl
- Interfaces/IWebPreferences.idl:
- Interfaces/IWebPreferencesPrivate.idl:
- Interfaces/WebKit.idl:
- WebView.cpp: (WebView::notifyPreferencesChanged):
- 12:17 PM Changeset in webkit [68178] by
-
- 1 edit12 adds in trunk/LayoutTests
Unreviewed chromium expecations update.
- platform/chromium-linux/svg/dynamic-updates/SVGFEMorphologyElement-dom-in-attr-expected.checksum: Added.
- platform/chromium-linux/svg/dynamic-updates/SVGFEMorphologyElement-dom-in-attr-expected.png: Added.
- platform/chromium-linux/svg/dynamic-updates/SVGFEMorphologyElement-dom-operator-attr-expected.checksum: Added.
- platform/chromium-linux/svg/dynamic-updates/SVGFEMorphologyElement-dom-operator-attr-expected.png: Added.
- platform/chromium-linux/svg/dynamic-updates/SVGFEMorphologyElement-dom-radius-attr-expected.checksum: Added.
- platform/chromium-linux/svg/dynamic-updates/SVGFEMorphologyElement-dom-radius-attr-expected.png: Added.
- platform/chromium-linux/svg/dynamic-updates/SVGFEMorphologyElement-svgdom-in-prop-expected.checksum: Added.
- platform/chromium-linux/svg/dynamic-updates/SVGFEMorphologyElement-svgdom-in-prop-expected.png: Added.
- platform/chromium-linux/svg/dynamic-updates/SVGFEMorphologyElement-svgdom-operator-prop-expected.checksum: Added.
- platform/chromium-linux/svg/dynamic-updates/SVGFEMorphologyElement-svgdom-operator-prop-expected.png: Added.
- platform/chromium-linux/svg/dynamic-updates/SVGFEMorphologyElement-svgdom-radius-call-expected.checksum: Added.
- platform/chromium-linux/svg/dynamic-updates/SVGFEMorphologyElement-svgdom-radius-call-expected.png: Added.
- 12:17 PM Changeset in webkit [68177] by
-
- 27 edits in trunk/WebCore
https://bugs.webkit.org/show_bug.cgi?id=46378, rename width/height on line boxes to logicalWidth/logicalHeight.
Reviewed by Dan Bernstein.
- editing/visible_units.cpp:
(WebCore::previousLinePosition):
(WebCore::nextLinePosition):
- rendering/EllipsisBox.cpp:
(WebCore::EllipsisBox::paint):
(WebCore::EllipsisBox::paintSelection):
(WebCore::EllipsisBox::nodeAtPoint):
- rendering/InlineBox.cpp:
(WebCore::InlineBox::logicalHeight):
(WebCore::InlineBox::canAccommodateEllipsis):
- rendering/InlineBox.h:
(WebCore::InlineBox::InlineBox):
(WebCore::InlineBox::hasVirtualLogicalHeight):
(WebCore::InlineBox::setHasVirtualLogicalHeight):
(WebCore::InlineBox::virtualLogicalHeight):
(WebCore::InlineBox::setLogicalWidth):
(WebCore::InlineBox::logicalWidth):
- rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::placeBoxesHorizontally):
(WebCore::InlineFlowBox::placeBoxesVertically):
(WebCore::InlineFlowBox::computeVerticalOverflow):
(WebCore::InlineFlowBox::nodeAtPoint):
(WebCore::InlineFlowBox::paintFillLayer):
(WebCore::InlineFlowBox::paintBoxDecorations):
(WebCore::InlineFlowBox::paintMask):
(WebCore::InlineFlowBox::paintTextDecorations):
(WebCore::InlineFlowBox::placeEllipsisBox):
- rendering/InlineFlowBox.h:
(WebCore::InlineFlowBox::visibleOverflowRect):
(WebCore::InlineFlowBox::bottomLayoutOverflow):
(WebCore::InlineFlowBox::rightLayoutOverflow):
(WebCore::InlineFlowBox::layoutOverflowRect):
(WebCore::InlineFlowBox::bottomVisualOverflow):
(WebCore::InlineFlowBox::rightVisualOverflow):
(WebCore::InlineFlowBox::visualOverflowRect):
(WebCore::InlineFlowBox::setHorizontalOverflowPositions):
(WebCore::InlineFlowBox::setVerticalOverflowPositions):
- rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::selectionRect):
(WebCore::InlineTextBox::placeEllipsisBox):
(WebCore::InlineTextBox::nodeAtPoint):
(WebCore::InlineTextBox::paint):
(WebCore::InlineTextBox::paintSelection):
(WebCore::InlineTextBox::paintCustomHighlight):
(WebCore::InlineTextBox::paintDecoration):
(WebCore::InlineTextBox::paintSpellingOrGrammarMarker):
(WebCore::InlineTextBox::paintTextMatchMarker):
(WebCore::InlineTextBox::paintCompositionUnderline):
- rendering/InlineTextBox.h:
(WebCore::InlineTextBox::calculateBoundaries):
(WebCore::InlineTextBox::setSpaceAdd):
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::paintEllipsisBoxes):
(WebCore::RenderBlock::rightmostPosition):
(WebCore::RenderBlock::adjustForBorderFit):
(WebCore::RenderBlock::addFocusRingRects):
- rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::computeHorizontalPositionsForLine):
(WebCore::RenderBlock::checkLinesForTextOverflow):
- rendering/RenderBox.cpp:
(WebCore::RenderBox::paintCustomHighlight):
(WebCore::RenderBox::containingBlockWidthForPositioned):
- rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::applyLineClamp):
- rendering/RenderInline.cpp:
(WebCore::RenderInline::absoluteRects):
(WebCore::RenderInline::absoluteQuads):
(WebCore::RenderInline::linesBoundingBox):
(WebCore::RenderInline::addFocusRingRects):
(WebCore::RenderInline::paintOutline):
- rendering/RenderSVGInline.cpp:
(WebCore::RenderSVGInline::createInlineFlowBox):
(WebCore::RenderSVGInline::absoluteQuads):
- rendering/RenderSVGInlineText.cpp:
(WebCore::RenderSVGInlineText::createTextBox):
- rendering/RenderSVGText.cpp:
(WebCore::RenderSVGText::createRootInlineBox):
- rendering/RenderText.cpp:
(WebCore::RenderText::absoluteRects):
(WebCore::RenderText::absoluteRectsForRange):
(WebCore::RenderText::absoluteQuadsForRange):
(WebCore::RenderText::positionForPoint):
(WebCore::RenderText::localCaretRect):
(WebCore::RenderText::linesBoundingBox):
- rendering/RenderTreeAsText.cpp:
(WebCore::writeTextRun):
- rendering/RootInlineBox.cpp:
(WebCore::RootInlineBox::canAccommodateEllipsis):
(WebCore::RootInlineBox::placeEllipsis):
(WebCore::RootInlineBox::addHighlightOverflow):
(WebCore::RootInlineBox::paintCustomHighlight):
(WebCore::RootInlineBox::fillLineSelectionGap):
(WebCore::RootInlineBox::closestLeafChildForXPos):
- rendering/SVGInlineFlowBox.h:
(WebCore::SVGInlineFlowBox::SVGInlineFlowBox):
(WebCore::SVGInlineFlowBox::virtualLogicalHeight):
(WebCore::SVGInlineFlowBox::setLogicalHeight):
- rendering/SVGInlineTextBox.cpp:
(WebCore::SVGInlineTextBox::SVGInlineTextBox):
- rendering/SVGInlineTextBox.h:
(WebCore::SVGInlineTextBox::virtualLogicalHeight):
(WebCore::SVGInlineTextBox::setLogicalHeight):
(WebCore::SVGInlineTextBox::selectionHeight):
- rendering/SVGRenderTreeAsText.cpp:
(WebCore::writeRenderSVGTextBox):
- rendering/SVGRootInlineBox.cpp:
(WebCore::SVGRootInlineBox::layoutChildBoxes):
(WebCore::SVGRootInlineBox::layoutRootBox):
- rendering/SVGRootInlineBox.h:
(WebCore::SVGRootInlineBox::SVGRootInlineBox):
(WebCore::SVGRootInlineBox::virtualLogicalHeight):
(WebCore::SVGRootInlineBox::setLogicalHeight):
- rendering/TrailingFloatsRootInlineBox.h:
(WebCore::TrailingFloatsRootInlineBox::TrailingFloatsRootInlineBox):
(WebCore::TrailingFloatsRootInlineBox::virtualLogicalHeight):
- 12:15 PM Changeset in webkit [68176] by
-
- 3 edits6 adds in trunk
2010-09-23 Matthew Delaney <mdelaney@apple.com>
Reviewed by Oliver Hunt.
context.drawImage with (source rect's height) = -(input image's native height) draws nothing
https://bugs.webkit.org/show_bug.cgi?id=46243
These test simply exercise using negative widths and heights for the source rect in ctx.drawImage calls.
- canvas/philip/tests/2d.drawImage.negativeSourceHeight-expected.txt: Added.
- canvas/philip/tests/2d.drawImage.negativeSourceHeight.html: Added.
- canvas/philip/tests/2d.drawImage.negativeSourceHeight2-expected.txt: Added.
- canvas/philip/tests/2d.drawImage.negativeSourceHeight2.html: Added.
- canvas/philip/tests/2d.drawImage.negativeSourceHeightAndWidth-expected.txt: Added.
- canvas/philip/tests/2d.drawImage.negativeSourceHeightAndWidth.html: Added.
2010-09-23 Matthew Delaney <mdelaney@apple.com>
Reviewed by Oliver Hunt.
context.drawImage with (source rect's height) = -(input image's native height) draws nothing
https://bugs.webkit.org/show_bug.cgi?id=46243
This patch changes canvasrenderingcontext2d's drawImage with an image element to
normalize the source and dest rects to acheive the desired canvas spec behavior
of allowing negative widths and heights that don't cause flipping and fix the
adverse behavior of specifying a source rect height of negative the source image's height
Tests: canvas/philip/tests/2d.drawImage.negativeSourceHeight.html
canvas/philip/tests/2d.drawImage.negativeSourceHeight2.html
canvas/philip/tests/2d.drawImage.negativeSourceHeightAndWidth.html
- html/canvas/CanvasRenderingContext2D.cpp: Normalize rects in drawImage before calling lower level draw calls.
- 12:14 PM Changeset in webkit [68175] by
-
- 6 edits in trunk
2010-09-22 Andy Estes <aestes@apple.com>
Reviewed by Darin Adler.
REGRESSION (r61285): Microsoft Entourage 2008 does not invoke My Day window
https://bugs.webkit.org/show_bug.cgi?id=46334
Microsoft My Day loads scripts using self-closing script tags, markup
which is incompatible with the HTML5 parser. Enable parser quirks for
this application.
- WebView/WebView.mm: (shouldUsePreHTML5ParserQuirks): Return true if the application is Microsoft My Day and was linked against a version of WebKit prior to the introduction of the HTML5 parser.
2010-09-23 Renata Hodovan <reni@inf.u-szeged.hu>
Reviewed by Dirk Schulze.
SVGFEMorphologyElement doesn't support dynamic invalidation, when attributes change.
https://bugs.webkit.org/show_bug.cgi?id=46363
The patch also implements the simple setRadius method.
Tests: svg/dynamic-updates/SVGFEMorphologyElement-dom-in-attr.html
svg/dynamic-updates/SVGFEMorphologyElement-dom-operator-attr.html
svg/dynamic-updates/SVGFEMorphologyElement-dom-radius-attr.html
svg/dynamic-updates/SVGFEMorphologyElement-svgdom-in-prop.html
svg/dynamic-updates/SVGFEMorphologyElement-svgdom-operator-prop.html
svg/dynamic-updates/SVGFEMorphologyElement-svgdom-radius-call.html
- svg/SVGFEMorphologyElement.cpp: (WebCore::SVGFEMorphologyElement::setRadius): (WebCore::SVGFEMorphologyElement::svgAttributeChanged):
- svg/SVGFEMorphologyElement.h:
- 12:06 PM Changeset in webkit [68174] by
-
- 2 edits in trunk/LayoutTests
2010-09-23 Nate Chapin <Nate Chapin>
Unreviewed, Chromium expectations tweak.
Temporarily add http/tests/navigation/ping-*.
- platform/chromium/test_expectations.txt:
- 11:59 AM Changeset in webkit [68173] by
-
- 3 edits3 adds in trunk/WebKit2
Add PluginProcessMain files
https://bugs.webkit.org/show_bug.cgi?id=46379
Reviewed by Sam Weinig.
- PluginProcess/PluginProcessMain.h: Added.
- PluginProcess/mac/PluginProcessMainMac.mm: Added.
- WebKit2.xcodeproj/project.pbxproj:
Add PluginProcessMain files. Remove PluginProcess.messages.in from the target so it
won't be installed in the WebKit2.framework bundle.
- WebProcess/WebKitMain.cpp:
(WebKitMain):
Call PluginProcessMain if the process type is ProcessLauncher::PluginProcess.
- 11:50 AM Changeset in webkit [68172] by
-
- 1 edit2 copies in trunk/WebKit/wince
2010-09-23 Patrick Gansterer <Patrick Gansterer>
Reviewed by Adam Roben.
Add PlatformStrategiesWinCE
https://bugs.webkit.org/show_bug.cgi?id=46371
- WebCoreSupport/PlatformStrategiesWinCE.cpp: Copied from WebKit/win/WebCoreSupport/WebPlatformStrategies.cpp.
- WebCoreSupport/PlatformStrategiesWinCE.h: Copied from WebKit/win/WebCoreSupport/WebPlatformStrategies.h.
- 11:49 AM Changeset in webkit [68171] by
-
- 9 edits in trunk/JavaScriptCore
Only copy captured variables into activation
https://bugs.webkit.org/show_bug.cgi?id=46330
Reviewed by Geoff Garen
We now track free variable information which means that
we no longer need to copy every variable defined in a
function. With this patch activations only retain those
variables needed for correctness. In order to interact
safely with the inspector this means that JSActivation
now provides its own lookup functions so it can avoid
trying to read or write to variables that have been
optimised out.
- bytecode/CodeBlock.h:
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::BytecodeGenerator):
- parser/Nodes.h:
(JSC::ScopeNode::capturedVariableCount):
(JSC::ScopeNode::captures):
- runtime/Arguments.h:
(JSC::JSActivation::copyRegisters):
- runtime/Executable.cpp:
(JSC::FunctionExecutable::FunctionExecutable):
(JSC::FunctionExecutable::compileForCallInternal):
(JSC::FunctionExecutable::compileForConstructInternal):
- runtime/Executable.h:
(JSC::FunctionExecutable::capturedVariableCount):
- runtime/JSActivation.cpp:
(JSC::JSActivation::markChildren):
(JSC::JSActivation::symbolTableGet):
(JSC::JSActivation::symbolTablePut):
(JSC::JSActivation::getOwnPropertyNames):
(JSC::JSActivation::symbolTablePutWithAttributes):
- runtime/JSActivation.h:
- 11:21 AM Changeset in webkit [68170] by
-
- 9 edits1 copy3 adds in trunk/WebKit2
Add PluginProcessProxy class
https://bugs.webkit.org/show_bug.cgi?id=46377
Reviewed by Sam Weinig.
- DerivedSources.make:
Add PluginProcess.
- Platform/CoreIPC/Connection.h:
(CoreIPC::Connection::send):
Add send overload that takes a message.
- Platform/CoreIPC/MessageID.h:
Add MessageClassPluginProcess message kind.
- PluginProcess/PluginProcess.messages.in: Added.
Add PluginProcess messages.
- UIProcess/Plugins/PluginInfoStore.cpp:
(WebKit::PluginInfoStore::infoForPluginWithPath):
- UIProcess/Plugins/PluginInfoStore.h:
New function that returns the plug-in info for a plug-in with the given path.
- UIProcess/Plugins/PluginProcessManager.cpp:
(WebKit::PluginProcessManager::getPluginProcessConnection):
Look for an existing plug-in process proxy.
- UIProcess/Plugins/PluginProcessProxy.cpp: Added.
(WebKit::PluginProcessProxy::create):
Launch the process.
(WebKit::PluginProcessProxy::didReceiveMessage):
(WebKit::PluginProcessProxy::didReceiveInvalidMessage):
Add stubbed out functions.
(WebKit::PluginProcessProxy::didClose):
Delete the plug-in process proxy.
(WebKit::PluginProcessProxy::didFinishLaunching):
Open a connection to the plug-in process proxy.
- UIProcess/Plugins/PluginProcessProxy.h: Added.
(WebKit::PluginProcessProxy::pluginInfo):
Return the plug-in info.
- UIProcess/WebProcessProxy.h:
(WebKit::WebProcessProxy::context):
Add a context getter.
- WebKit2.xcodeproj/project.pbxproj:
Add new files.
- 11:19 AM Changeset in webkit [68169] by
-
- 4 edits in trunk/WebKit
2010-09-23 Nate Chapin <Nate Chapin>
Unreviewed, build fix.
Look for hyperlinkAuditingEnabled in the right set of preferences.
- WebView.cpp: (WebView::notifyPreferencesChanged):
- 11:17 AM Changeset in webkit [68168] by
-
- 4 edits30 adds in trunk
2010-09-23 Renata Hodovan <reni@inf.u-szeged.hu>
Reviewed by Dirk Schulze.
SVGFEMorphologyElement doesn't support dynamic invalidation, when attributes change.
https://bugs.webkit.org/show_bug.cgi?id=46363
Adding layout tests for feMorphology dynamic changes.
- platform/mac/svg/dynamic-updates/SVGFEMorphologyElement-dom-in-attr-expected.checksum: Added.
- platform/mac/svg/dynamic-updates/SVGFEMorphologyElement-dom-in-attr-expected.png: Added.
- platform/mac/svg/dynamic-updates/SVGFEMorphologyElement-dom-operator-attr-expected.checksum: Added.
- platform/mac/svg/dynamic-updates/SVGFEMorphologyElement-dom-operator-attr-expected.png: Added.
- platform/mac/svg/dynamic-updates/SVGFEMorphologyElement-dom-radius-attr-expected.checksum: Added.
- platform/mac/svg/dynamic-updates/SVGFEMorphologyElement-dom-radius-attr-expected.png: Added.
- platform/mac/svg/dynamic-updates/SVGFEMorphologyElement-svgdom-in-prop-expected.checksum: Added.
- platform/mac/svg/dynamic-updates/SVGFEMorphologyElement-svgdom-in-prop-expected.png: Added.
- platform/mac/svg/dynamic-updates/SVGFEMorphologyElement-svgdom-operator-prop-expected.checksum: Added.
- platform/mac/svg/dynamic-updates/SVGFEMorphologyElement-svgdom-operator-prop-expected.png: Added.
- platform/mac/svg/dynamic-updates/SVGFEMorphologyElement-svgdom-radius-call-expected.checksum: Added.
- platform/mac/svg/dynamic-updates/SVGFEMorphologyElement-svgdom-radius-call-expected.png: Added.
- svg/dynamic-updates/SVGFEMorphologyElement-dom-in-attr-expected.txt: Added.
- svg/dynamic-updates/SVGFEMorphologyElement-dom-in-attr.html: Added.
- svg/dynamic-updates/SVGFEMorphologyElement-dom-operator-attr-expected.txt: Added.
- svg/dynamic-updates/SVGFEMorphologyElement-dom-operator-attr.html: Added.
- svg/dynamic-updates/SVGFEMorphologyElement-dom-radius-attr-expected.txt: Added.
- svg/dynamic-updates/SVGFEMorphologyElement-dom-radius-attr.html: Added.
- svg/dynamic-updates/SVGFEMorphologyElement-svgdom-in-prop-expected.txt: Added.
- svg/dynamic-updates/SVGFEMorphologyElement-svgdom-in-prop.html: Added.
- svg/dynamic-updates/SVGFEMorphologyElement-svgdom-operator-prop-expected.txt: Added.
- svg/dynamic-updates/SVGFEMorphologyElement-svgdom-operator-prop.html: Added.
- svg/dynamic-updates/SVGFEMorphologyElement-svgdom-radius-call-expected.txt: Added.
- svg/dynamic-updates/SVGFEMorphologyElement-svgdom-radius-call.html: Added.
- svg/dynamic-updates/script-tests/SVGFEMorphologyElement-dom-in-attr.js: Added. (executeTest):
- svg/dynamic-updates/script-tests/SVGFEMorphologyElement-dom-operator-attr.js: Added. (executeTest):
- svg/dynamic-updates/script-tests/SVGFEMorphologyElement-dom-radius-attr.js: Added. (executeTest):
- svg/dynamic-updates/script-tests/SVGFEMorphologyElement-svgdom-in-prop.js: Added. (executeTest):
- svg/dynamic-updates/script-tests/SVGFEMorphologyElement-svgdom-operator-prop.js: Added. (executeTest):
- svg/dynamic-updates/script-tests/SVGFEMorphologyElement-svgdom-radius-call.js: Added. (executeTest):
2010-09-23 Renata Hodovan <reni@inf.u-szeged.hu>
Reviewed by Dirk Schulze.
SVGFEMorphologyElement doesn't support dynamic invalidation, when attributes change.
https://bugs.webkit.org/show_bug.cgi?id=46363
The patch also implements the simple setRadius method.
Tests: svg/dynamic-updates/SVGFEMorphologyElement-dom-in-attr.html
svg/dynamic-updates/SVGFEMorphologyElement-dom-operator-attr.html
svg/dynamic-updates/SVGFEMorphologyElement-dom-radius-attr.html
svg/dynamic-updates/SVGFEMorphologyElement-svgdom-in-prop.html
svg/dynamic-updates/SVGFEMorphologyElement-svgdom-operator-prop.html
svg/dynamic-updates/SVGFEMorphologyElement-svgdom-radius-call.html
- svg/SVGFEMorphologyElement.cpp: (WebCore::SVGFEMorphologyElement::setRadius): (WebCore::SVGFEMorphologyElement::svgAttributeChanged):
- svg/SVGFEMorphologyElement.h:
- 11:08 AM Changeset in webkit [68167] by
-
- 3 edits in trunk/WebCore
2010-09-23 Patrick Gansterer <Patrick Gansterer>
Reviewed by Adam Roben.
Add synchronous loading for network resources to ResourceHandleWin
https://bugs.webkit.org/show_bug.cgi?id=46364
Use return value of onRequestComplete() to indicate that an additional
call to it is required for receiving remaining network data.
- platform/network/ResourceHandle.h:
- platform/network/win/ResourceHandleWin.cpp: (WebCore::ResourceHandle::onRequestComplete): (WebCore::ResourceHandle::start):
- 11:02 AM Changeset in webkit [68166] by
-
- 39 edits6 adds in trunk
2010-09-23 Nate Chapin <Nate Chapin>
Reviewed by Darin Fisher.
Implement <a ping> (disabled by default).
https://bugs.webkit.org/show_bug.cgi?id=30458
Tests: http/tests/navigation/ping-cross-origin-from-https.html
http/tests/navigation/ping-cross-origin.html
http/tests/navigation/ping-same-origin.html
- html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::defaultEventHandler): (WebCore::HTMLAnchorElement::sendPings):
- html/HTMLAnchorElement.h:
- html/HTMLAttributeNames.in:
- loader/PingLoader.cpp: (WebCore::PingLoader::sendPing): Set ping-specific headers. (WebCore::PingLoader::PingLoader):
- loader/PingLoader.h: (WebCore::PingLoader::timeout): Ensure pings eventually timeout, since
the normal cancel mechanism can't stop them.
- page/Settings.cpp:
- page/Settings.h: Add hyperlinkAuditingEnabled.
- 10:56 AM Changeset in webkit [68165] by
-
- 7 edits in trunk/WebCore
2010-09-23 Steve VanDeBogart <vandebo@chromium.org>
Reviewed by David Levin.
Use Skia's SkSafeRef/SkSafeUnref functions instead of safeRef/safeUnref.
- platform/graphics/chromium/FontLinux.cpp: (WebCore::Font::drawGlyphs):
- platform/graphics/chromium/FontPlatformDataLinux.cpp: (WebCore::FontPlatformData::FontPlatformData): (WebCore::FontPlatformData::~FontPlatformData):
- platform/graphics/skia/GradientSkia.cpp: (WebCore::Gradient::platformDestroy):
- platform/graphics/skia/PatternSkia.cpp: (WebCore::Pattern::platformDestroy):
- platform/graphics/skia/PlatformContextSkia.cpp: (WebCore::PlatformContextSkia::State::State): (WebCore::PlatformContextSkia::State::~State): (WebCore::PlatformContextSkia::drawRect): (WebCore::PlatformContextSkia::setStrokeShader): (WebCore::PlatformContextSkia::setFillShader): (WebCore::PlatformContextSkia::setDashPathEffect):
- platform/graphics/skia/SkiaFontWin.cpp: (WebCore::paintSkiaText):
- 10:52 AM Changeset in webkit [68164] by
-
- 2 edits in trunk/WebCore
2010-09-23 Lucas De Marchi <lucas.demarchi@profusion.mobi>
Reviewed by Csaba Osztrogonác.
Fix warnings regarding print format in 64 bits
https://bugs.webkit.org/show_bug.cgi?id=46357
Use inttypes.h in order to have portable print formats across 32 and
64 bits.
- platform/sql/SQLiteFileSystem.cpp: (WebCore::SQLiteFileSystem::getFileNameForNewDatabase):
- 10:49 AM Changeset in webkit [68163] by
-
- 1 edit3 adds in trunk/WebCore
2010-09-23 Chris Rogers <crogers@google.com>
Reviewed by Kenneth Russell.
Add AudioContext files
https://bugs.webkit.org/show_bug.cgi?id=44890
No new tests since audio API is not yet implemented.
- webaudio/AudioContext.cpp: Added. (WebCore::AudioContext::createAudioRequest): (WebCore::AudioContext::create): (WebCore::AudioContext::AudioContext): (WebCore::AudioContext::~AudioContext): (WebCore::AudioContext::lazyInitialize): (WebCore::AudioContext::uninitialize): (WebCore::AudioContext::isInitialized): (WebCore::AudioContext::isRunnable): (WebCore::AudioContext::stop): (WebCore::AudioContext::document): (WebCore::AudioContext::hasDocument): (WebCore::AudioContext::refBuffer): (WebCore::AudioContext::createBuffer): (WebCore::AudioContext::createBufferSource): (WebCore::AudioContext::createJavaScriptNode): (WebCore::AudioContext::createLowPass2Filter): (WebCore::AudioContext::createHighPass2Filter): (WebCore::AudioContext::createPanner): (WebCore::AudioContext::createConvolver): (WebCore::AudioContext::createAnalyser): (WebCore::AudioContext::createGainNode): (WebCore::AudioContext::createDelayNode): (WebCore::AudioContext::createChannelSplitter): (WebCore::AudioContext::createChannelMerger): (WebCore::AudioContext::notifyNodeFinishedProcessing): (WebCore::AudioContext::derefFinishedSourceNodes): (WebCore::AudioContext::refNode): (WebCore::AudioContext::derefNode): (WebCore::AudioContext::derefUnfinishedSourceNodes): (WebCore::AudioContext::lock): (WebCore::AudioContext::tryLock): (WebCore::AudioContext::unlock): (WebCore::AudioContext::isAudioThread): (WebCore::AudioContext::isGraphOwner): (WebCore::AudioContext::addDeferredFinishDeref): (WebCore::AudioContext::handlePostRenderTasks): (WebCore::AudioContext::handleDeferredFinishDerefs): (WebCore::AudioContext::markForDeletion): (WebCore::AudioContext::deleteMarkedNodes):
- webaudio/AudioContext.h: Added. (WebCore::AudioContext::destination): (WebCore::AudioContext::currentTime): (WebCore::AudioContext::sampleRate): (WebCore::AudioContext::listener): (WebCore::AudioContext::temporaryMonoBus): (WebCore::AudioContext::temporaryStereoBus): (WebCore::AudioContext::incrementConnectionCount): (WebCore::AudioContext::connectionCount): (WebCore::AudioContext::setAudioThread): (WebCore::AudioContext::audioThread): (WebCore::AudioContext::isAudioThreadFinished): (WebCore::AudioContext::AutoLocker::AutoLocker): (WebCore::AudioContext::AutoLocker::~AutoLocker): (WebCore::AudioContext::RefInfo::RefInfo):
- webaudio/AudioContext.idl: Added.
- 10:37 AM Changeset in webkit [68162] by
-
- 3 edits in trunk/WebKit2
Expose the BundlePage on the BundleFrame in the API.
https://bugs.webkit.org/show_bug.cgi?id=46366
Reviewed by Sam Weinig.
- WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:
(WKBundleFrameGetPage):
- WebProcess/InjectedBundle/API/c/WKBundleFrame.h:
- 10:32 AM Changeset in webkit [68161] by
-
- 5 edits in trunk
2010-09-23 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Steve Block.
IndexedDB shouldn't crash on invalid index names
https://bugs.webkit.org/show_bug.cgi?id=46362
- storage/indexeddb/objectstore-basics-expected.txt:
- storage/indexeddb/objectstore-basics.html:
2010-09-23 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Steve Block.
IndexedDB shouldn't crash on invalid index names
https://bugs.webkit.org/show_bug.cgi?id=46362
For now, return null. In a later patch, we'll do proper exception raising.
- storage/IDBObjectStore.cpp: (WebCore::IDBObjectStore::index):
- 10:29 AM Changeset in webkit [68160] by
-
- 3 edits2 adds in trunk
Reviewed by Anders Carlsson.
https://bugs.webkit.org/show_bug.cgi?id=43667
ASSERT failure in NetscapePluginInstanceProxy::disconnectStream
Test: plugins/get-javascript-url.html
- Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::evaluateJavaScript): Add the stream to m_streams, just like any other one.
- 10:27 AM Changeset in webkit [68159] by
-
- 3 edits in trunk/WebKit2
It should be possible to conditionally define an entire group of messages
https://bugs.webkit.org/show_bug.cgi?id=46368
Reviewed by Adam Roben.
- Scripts/webkit2/messages.py:
Check for a condition when parsing the "messages -> " string and set it as the
message receiver condition.
- Scripts/webkit2/messages_unittest.py:
Add test.
- 10:21 AM Changeset in webkit [68158] by
-
- 3 edits2 adds in trunk
2010-09-23 Abhishek Arya <inferno@chromium.org>
Reviewed by Dave Hyatt.
Fix the memory safety issue by checking containerObject is a RenderBox
before doing the transforms.
https://bugs.webkit.org/show_bug.cgi?id=46365
Test: compositing/overflow/get-transform-from-non-box-container.html
- rendering/RenderObject.cpp: (WebCore::RenderObject::getTransformFromContainer):
2010-09-23 Abhishek Arya <inferno@chromium.org>
Reviewed by Dave Hyatt.
Tests that we donot assert on object->isBox.
https://bugs.webkit.org/show_bug.cgi?id=46365
- compositing/overflow/get-transform-from-non-box-container-expected.txt: Added.
- compositing/overflow/get-transform-from-non-box-container.html: Added.
- 10:17 AM Changeset in webkit [68157] by
-
- 3 edits in trunk/WebCore
https://bugs.webkit.org/show_bug.cgi?id=46314.
Reviewed by Simon Fraser.
The RenderView's block-flow should match the root element's block-flow. When we create (or re-create) the style for the document, take
the block-flow from the document element's style and use it if it's available.
Also patch styleDidChange so that if the block-flow changes dynamically after we have already made the document style, we'll propagate
the change back up to the RenderView and have it do a relayout.
No tests possible yet, since you can't see the document's style anywhere, and block-flow isn't doing anything to affect layout
yet.
- css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::styleForDocument):
- rendering/RenderBox.cpp:
(WebCore::RenderBox::styleDidChange):
- 10:11 AM Changeset in webkit [68156] by
-
- 2 edits2 adds in trunk/WebKit2
Add a preference class for Qt for WebKit2.
Reviewed by Andreas Kling.
- UIProcess/API/qt/qwkpreferences.cpp: Added.
(QWKPreferences::globalPreferences):
(QWKPreferences::QWKPreferences):
(QWKPreferences::~QWKPreferences):
(QWKPreferences::testAttribute):
(QWKPreferences::setAttribute):
- UIProcess/API/qt/qwkpreferences.h: Added.
- WebKit2.pro:
- 10:10 AM Changeset in webkit [68155] by
-
- 2 edits in trunk/LayoutTests
2010-09-23 Dimitri Glazkov <Dimitri Glazkov>
Remove passing tests. These were failing because the bot was missing QuickTime.
- platform/chromium/drt_expectations.txt: Removed QuickTime-dependent tests after installing QuickTime on the build bot.
- 9:56 AM Changeset in webkit [68154] by
-
- 5 edits in trunk/WebKit/efl
2010-09-23 Lucas De Marchi <lucas.demarchi@profusion.mobi>
Reviewed by Csaba Osztrogonác.
[EFL] Fix warnings during build
https://bugs.webkit.org/show_bug.cgi?id=46354
- ewk/ewk_frame.cpp: (ewk_frame_text_matches_nth_pos_get): Change argument type because it's meant to be always positive.
- ewk/ewk_frame.h: Ditto.
- ewk/ewk_view.cpp: (ewk_view_exceeded_database_quota): Add missing "%" causing warning about number of arguments to printf-like function.
- ewk/ewk_view.h: Add missing initialization.
- 9:46 AM Changeset in webkit [68153] by
-
- 3 edits in trunk/WebKit2
Message autogeneration script should parse sync message syntax
https://bugs.webkit.org/show_bug.cgi?id=46359
Reviewed by Adam Roben.
- Scripts/webkit2/messages.py:
(MessageReceiver.parse): Expand the regular expression to handle sync messages.
(function_parameter_type): Use a const reference for all parameters except the known builtins.
(base_class): Returns the base class for a sync message reply struct.
(delayed_base_class): Returns the base class for a delayed sync message reply struct.
- Scripts/webkit2/messages_unittest.py:
Add unit tests for various sync messages.
- 9:45 AM Changeset in webkit [68152] by
-
- 2 edits in trunk/WebKit/chromium
2010-09-23 Andrey Kosyakov <caseq@chromium.org>
Unreviewed build fix ("WTF/" -> "wtf/" in include, broke Arm build)
- src/AsyncFileWriterChromium.h:
- 9:37 AM Changeset in webkit [68151] by
-
- 2 edits in trunk/WebCore
2010-09-23 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: source frame popups shouldn't disappear when hovered
https://bugs.webkit.org/show_bug.cgi?id=46358
- inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype._mouseMove):
- 9:21 AM Changeset in webkit [68150] by
-
- 2 edits in trunk
2010-09-23 Lucas De Marchi <lucas.demarchi@profusion.mobi>
Reviewed by Antonio Gomes.
[EFL] Enable warnings during build by default
https://bugs.webkit.org/show_bug.cgi?id=46351
Change default build to enable several warnings like other ports do.
We need to pay special attention to "-Wall" in order to produce better
code, so highlight this keyword, too.
- cmake/WebKitHelpers.cmake:
- 9:20 AM Changeset in webkit [68149] by
-
- 3 edits2 adds in trunk
2010-09-23 Mario Sanchez Prada <msanchez@igalia.com>
Reviewed by Chris Fleizach.
[Regression][Gtk] Left and Right Arrows no longer function when caret browsing is enabled
https://bugs.webkit.org/show_bug.cgi?id=45375
Added the following test to make sure key navigation across a
paragraph always work as expected, both with and without the shift
and ctrl modifiers.
- platform/gtk/editing/selection/caret-mode-paragraph-keys-navigation-expected.txt: Added.
- platform/gtk/editing/selection/caret-mode-paragraph-keys-navigation.html: Added.
2010-09-23 Mario Sanchez Prada <msanchez@igalia.com>
Reviewed by Chris Fleizach.
[Regression][Gtk] Left and Right Arrows no longer function when caret browsing is enabled
https://bugs.webkit.org/show_bug.cgi?id=45375
Consider caret browsing for Move commands.
Test: platform/gtk/editing/selection/caret-mode-left-right-arrows.html
- editing/EditorCommand.cpp: (WebCore::createCommandMap): Use "caret browsing aware functions" as isEnabled() function for those commands moving the caret forward and backward across characters, words, lines or paragraphs, not just left and right, as it was the case so far.
- 9:18 AM Changeset in webkit [68148] by
-
- 2 edits in trunk/WebCore
Address a remaining discrepancy in piecewise text measurement
https://bugs.webkit.org/show_bug.cgi?id=45796
Patch by Brad Moore <bradm@apple.com> on 2010-09-23
Reviewed by Dan Bernstein.
Don't include always-integral space widths in the floating point accumulator designed
to minimize precision loss. This brings whole-string measurement in line with piecewise
text measurement when dealing with fonts with fractional advances.
- platform/graphics/WidthIterator.cpp:
(WebCore::WidthIterator::advance): Change the associativity of width addition to minimize precision loss.
- 9:12 AM Changeset in webkit [68147] by
-
- 3 edits in trunk/WebCore
2010-09-23 Patrick Gansterer <Patrick Gansterer>
Reviewed by Adam Roben.
Cleanup network communication code in ResourceHandleWin
https://bugs.webkit.org/show_bug.cgi?id=46200
Add logic for request handling directly into ResourceHandle::start and fix style.
Use Unicode instead of ASCII Windows API functions.
- platform/network/ResourceHandleInternal.h: (WebCore::ResourceHandleInternal::ResourceHandleInternal):
- platform/network/win/ResourceHandleWin.cpp: (WebCore::ResourceHandle::onRequestComplete): (WebCore::ResourceHandle::start):
- 8:56 AM Changeset in webkit [68146] by
-
- 2 edits in trunk/WebCore
2010-09-23 Luiz Agostini <luiz.agostini@openbossa.org>
Reviewed by Andreas Kling.
Invalid assertion in ScriptCallback
https://bugs.webkit.org/show_bug.cgi?id=46348
Removing invalid ASSERT from method ScriptCallback::call().
- bindings/js/ScriptFunctionCall.cpp: (WebCore::ScriptCallback::call):
- 8:51 AM Changeset in webkit [68145] by
-
- 7 edits2 moves2 adds in trunk/WebCore
2010-09-23 Martin Robinson <mrobinson@igalia.com>
Reviewed by Ariya Hidayat.
[Cairo] Generalize ContextShadow from the Qt port and use it for shadow code
https://bugs.webkit.org/show_bug.cgi?id=45599
Make ContextShadow platform-independent and add a Cairo implementation. This is currently
disabled for Cairo, but will be enabled in a followup patch with new baselines.
No new tests as this does not change functionality.
- GNUmakefile.am: Update source lists.
- WebCore.pro: Update source lists.
- platform/graphics/ContextShadow.cpp: Added. A generalized version of Qt's ContextShadow. (WebCore::ContextShadow::ContextShadow): (WebCore::ContextShadow::clear): (WebCore::ContextShadow::blurLayerImage): (WebCore::ContextShadow::calculateMinimalLayerRect):
- platform/graphics/ContextShadow.h: Added. (WebCore::ContextShadow::offset):
- platform/graphics/cairo/CairoUtilities.cpp: Added. (WebCore::setSourceRGBAFromColor): A utility to set the source RGBA on a Cairo surface from a WebCore color.
- platform/graphics/cairo/CairoUtilities.h: Added.
- platform/graphics/cairo/ContextShadowCairo.cpp: Added. (WebCore::purgeScratchBuffer): Static function to purge the shadow buffer. (WebCore::PurgeScratchBufferTimer::fired): Timer callback. (WebCore::scheduleScratchBufferPurge): Schedule's a WebCore timer to purge the shadow buffer. (WebCore::getScratchBuffer): Create or reuse the scratch buffer. (WebCore::ContextShadow::beginShadowLayer): Added. (WebCore::ContextShadow::endShadowLayer): Added.
- platform/graphics/gtk/CairoUtilities.cpp: Removed.
- platform/graphics/gtk/CairoUtilities.h: Removed.
- platform/graphics/gtk/GdkCairoUtilities.cpp: Renamed from CairoUtilities.cpp. (getCairoSurfacePixel): (getGdkPixbufPixel): (cairoImageSurfaceToGdkPixbuf):
- platform/graphics/gtk/GdkCairoUtilities.h: Added.
- platform/graphics/gtk/ImageBufferGtk.cpp:
- platform/graphics/gtk/ImageGtk.cpp:
- platform/graphics/qt/ContextShadow.cpp: Removed.
- platform/graphics/qt/ContextShadow.h: Removed.
- platform/graphics/qt/ContextShadowQt.cpp: Added. Adapted from code originally in ContextShadow.cpp. (WebCore::ShadowBuffer::ShadowBuffer): (WebCore::ShadowBuffer::scratchImage): (WebCore::ShadowBuffer::schedulePurge): (WebCore::ShadowBuffer::timerEvent): (WebCore::ContextShadow::beginShadowLayer): (WebCore::ContextShadow::endShadowLayer):
- platform/graphics/qt/FontQt.cpp: (WebCore::drawTextCommon): Updated to reflect new ContextShadow members.
- platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContextPlatformPrivate::hasShadow): Updated to reflect new ContextShadow members. (WebCore::GraphicsContext::strokeArc): Ditto. (WebCore::GraphicsContext::drawConvexPolygon): Ditto. (WebCore::GraphicsContext::fillPath): Ditto. (WebCore::GraphicsContext::strokePath): Ditto. (WebCore::GraphicsContext::fillRect): Ditto. (WebCore::GraphicsContext::fillRoundedRect): Ditto. (WebCore::GraphicsContext::setPlatformShadow): Ditto.
- 8:39 AM Changeset in webkit [68144] by
-
- 4 edits in trunk/WebCore
2010-09-23 Patrick Gansterer <Patrick Gansterer>
Reviewed by Adam Roben.
Add internetStatusCallback to ResourceHandleWin.
https://bugs.webkit.org/show_bug.cgi?id=46187
Add callback for asynchronous network transfer.
- platform/network/ResourceHandle.h:
- platform/network/ResourceHandleInternal.h:
- platform/network/win/ResourceHandleWin.cpp: (WebCore::callOnRedirect): (WebCore::callOnRequestComplete): (WebCore::ResourceHandle::internetStatusCallback): (WebCore::ResourceHandle::onRedirect):
- 8:37 AM Changeset in webkit [68143] by
-
- 2 edits in trunk/WebCore
2010-09-23 Andrei Popescu <andreip@google.com>
Reviewed by Jeremy Orlow.
IDBTransactionCoordinator contains a broken assertion.
https://bugs.webkit.org/show_bug.cgi?id=46356
Remove the broken assertion.
- storage/IDBTransactionCoordinator.cpp: (WebCore::IDBTransactionCoordinator::processStartedTransactions):
- 8:29 AM Changeset in webkit [68142] by
-
- 2 edits in trunk/JavaScriptCore
2010-09-23 Ismail Donmez <ismail@namtrac.org>
Reviewed by Andreas Kling.
Fix jsc.exe build for Windows CE
- jsc.pro: Add mmtimer.lib for Windows CE.
- 8:29 AM Changeset in webkit [68141] by
-
- 5 edits2 adds in trunk/WebKit/chromium
2010-09-08 Tony Gentilcore <tonyg@chromium.org>
Reviewed by Darin Fisher.
[chromium] Add chromium port API for accessing Web Timing information
https://bugs.webkit.org/show_bug.cgi?id=45428
- WebKit.gyp:
- public/WebFrame.h:
- public/WebPerformance.h: Added. (WebKit::WebPerformance::WebPerformance):
- src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::performance):
- src/WebFrameImpl.h:
- src/WebPerformance.cpp: Added. (WebKit::WebPerformance::WebPerformance): (WebKit::WebPerformance::~WebPerformance): (WebKit::WebPerformance::operator=): (WebKit::WebPerformance::navigationType): (WebKit::WebPerformance::navigationStart): (WebKit::WebPerformance::unloadEventEnd): (WebKit::WebPerformance::redirectStart): (WebKit::WebPerformance::redirectEnd): (WebKit::WebPerformance::redirectCount): (WebKit::WebPerformance::fetchStart): (WebKit::WebPerformance::domainLookupStart): (WebKit::WebPerformance::domainLookupEnd): (WebKit::WebPerformance::connectStart): (WebKit::WebPerformance::connectEnd): (WebKit::WebPerformance::requestStart): (WebKit::WebPerformance::requestEnd): (WebKit::WebPerformance::responseStart): (WebKit::WebPerformance::responseEnd): (WebKit::WebPerformance::loadEventStart): (WebKit::WebPerformance::loadEventEnd): (WebKit::WebPerformance::operator PassRefPtr<Performance>):
- 8:20 AM Changeset in webkit [68140] by
-
- 3 edits in trunk/WebCore
2010-09-23 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: highlight DOM nodes when navigating the DOM with keyboard
https://bugs.webkit.org/show_bug.cgi?id=46346
- inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeElement.prototype.onselect):
- inspector/front-end/treeoutline.js: (TreeOutline.prototype._treeKeyDown): (TreeElement.prototype.selectOnMouseDown): (TreeElement.prototype.select):
- 8:13 AM Changeset in webkit [68139] by
-
- 3 edits in trunk/WebCore
2010-09-23 Andrei Popescu <andreip@google.com>
Reviewed by Jeremy Orlow.
[Chromium] Build broken due to missing include in IDBTransactionBackendImpl.h
https://bugs.webkit.org/show_bug.cgi?id=46352
No new tests needed, build fix.
- storage/IDBTransaction.cpp: (WebCore::IDBTransaction::objectStore):
- storage/IDBTransactionBackendImpl.h:
- 7:34 AM Changeset in webkit [68138] by
-
- 46 edits in trunk
2010-09-23 Andrei Popescu <andreip@google.com>
Reviewed by Jeremy Orlow.
IDBObjectStore::get should run in a transaction.
https://bugs.webkit.org/show_bug.cgi?id=44700
- storage/indexeddb/objectstore-basics-expected.txt:
- storage/indexeddb/objectstore-basics.html:
- storage/indexeddb/objectstore-removeobjectstore-expected.txt:
- storage/indexeddb/objectstore-removeobjectstore.html:
2010-09-23 Andrei Popescu <andreip@google.com>
Reviewed by Jeremy Orlow.
IDBObjectStore::get should run in a transaction.
https://bugs.webkit.org/show_bug.cgi?id=44700
Implements logic for running IDBObjectStore::get() in a transaction.
Refactors the pending transaction monitor and the transaction coordinator
to use pointers instead of transaction IDs.
- bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::didLeaveScriptContext):
- storage/IDBCursorBackendImpl.cpp:
- storage/IDBDatabase.cpp: (WebCore::IDBDatabase::objectStore):
- storage/IDBDatabaseBackendImpl.cpp: (WebCore::IDBDatabaseBackendImpl::objectStore):
- storage/IDBDatabaseBackendImpl.h: (WebCore::IDBDatabaseBackendImpl::transactionCoordinator):
- storage/IDBFactoryBackendImpl.cpp:
- storage/IDBFactoryBackendImpl.h:
- storage/IDBFactoryBackendInterface.h:
- storage/IDBObjectStore.cpp: (WebCore::IDBObjectStore::IDBObjectStore): (WebCore::IDBObjectStore::get):
- storage/IDBObjectStore.h: (WebCore::IDBObjectStore::create):
- storage/IDBObjectStoreBackendImpl.cpp: (WebCore::IDBTask::IDBTask): (WebCore::IDBTask::performTask): (WebCore::createTask): (WebCore::IDBObjectStoreBackendImpl::get): (WebCore::IDBObjectStoreBackendImpl::getInternal):
- storage/IDBObjectStoreBackendImpl.h:
- storage/IDBObjectStoreBackendInterface.h:
- storage/IDBPendingTransactionMonitor.cpp: (WebCore::IDBPendingTransactionMonitor::addPendingTransaction): (WebCore::IDBPendingTransactionMonitor::removePendingTransaction): (WebCore::IDBPendingTransactionMonitor::abortPendingTransactions):
- storage/IDBPendingTransactionMonitor.h:
- storage/IDBRequest.cpp: (WebCore::IDBRequest::IDBRequest): (WebCore::IDBRequest::~IDBRequest): (WebCore::IDBRequest::onSuccess): (WebCore::IDBRequest::timerFired):
- storage/IDBRequest.h: (WebCore::IDBRequest::create):
- storage/IDBTransaction.cpp: (WebCore::IDBTransaction::IDBTransaction): (WebCore::IDBTransaction::objectStore):
- storage/IDBTransactionBackendImpl.cpp: (WebCore::IDBTransactionBackendImpl::create): (WebCore::IDBTransactionBackendImpl::IDBTransactionBackendImpl): (WebCore::IDBTransactionBackendImpl::objectStore): (WebCore::IDBTransactionBackendImpl::scheduleTask): (WebCore::IDBTransactionBackendImpl::abort): (WebCore::IDBTransactionBackendImpl::didCompleteTaskEvents): (WebCore::IDBTransactionBackendImpl::run): (WebCore::IDBTransactionBackendImpl::start): (WebCore::IDBTransactionBackendImpl::commit): (WebCore::IDBTransactionBackendImpl::timerFired):
- storage/IDBTransactionBackendImpl.h: (WebCore::IDBTransactionBackendImpl::~IDBTransactionBackendImpl): (WebCore::IDBTransactionBackendImpl::isFinished):
- storage/IDBTransactionBackendInterface.h:
- storage/IDBTransactionCoordinator.cpp: (WebCore::IDBTransactionCoordinator::createTransaction): (WebCore::IDBTransactionCoordinator::didStartTransaction): (WebCore::IDBTransactionCoordinator::didFinishTransaction): (WebCore::IDBTransactionCoordinator::processStartedTransactions):
- storage/IDBTransactionCoordinator.h:
2010-09-23 Andrei Popescu <andreip@google.com>
Reviewed by Jeremy Orlow.
IDBObjectStore::get should run in a transaction.
https://bugs.webkit.org/show_bug.cgi?id=44700
- public/WebIDBFactory.h:
- public/WebIDBObjectStore.h:
- public/WebIDBTransaction.h: (WebKit::WebIDBTransaction::didCompleteTaskEvents): (WebKit::WebIDBTransaction::getIDBTransactionBackendInterface):
- src/IDBDatabaseProxy.h:
- src/IDBFactoryBackendProxy.cpp:
- src/IDBFactoryBackendProxy.h:
- src/IDBObjectStoreProxy.cpp: (WebCore::IDBObjectStoreProxy::get):
- src/IDBObjectStoreProxy.h:
- src/IDBTransactionBackendProxy.cpp: (WebCore::IDBTransactionBackendProxy::scheduleTask): (WebCore::IDBTransactionBackendProxy::didCompleteTaskEvents):
- src/IDBTransactionBackendProxy.h: (WebCore::IDBTransactionBackendProxy::getWebIDBTransaction):
- src/WebIDBFactoryImpl.cpp:
- src/WebIDBFactoryImpl.h:
- src/WebIDBObjectStoreImpl.cpp: (WebKit::WebIDBObjectStoreImpl::get):
- src/WebIDBObjectStoreImpl.h:
- src/WebIDBTransactionImpl.cpp: (WebKit::WebIDBTransactionImpl::didCompleteTaskEvents): (WebKit::WebIDBTransactionImpl::getIDBTransactionBackendInterface):
- src/WebIDBTransactionImpl.h:
- 7:24 AM Changeset in webkit [68137] by
-
- 1 edit2 adds in trunk/WebKit/wince
2010-09-23 Patrick Gansterer <Patrick Gansterer>
Reviewed by Adam Roben.
Add ChromeClientWinCE
https://bugs.webkit.org/show_bug.cgi?id=46294
- WebCoreSupport/ChromeClientWinCE.cpp: Added.
- WebCoreSupport/ChromeClientWinCE.h: Added.
- 7:24 AM Changeset in webkit [68136] by
-
- 6 edits in trunk/WebKitTools
2010-09-21 Stephen White <senorblanco@chromium.org>
Reviewed by David Levin.
Implement --enable-accelerated-2d-canvas flag in DumpRenderTree.
https://bugs.webkit.org/show_bug.cgi?id=46208
This flag allows the layout tests to be run with or without accelerated
2D canvas rendering.
- DumpRenderTree/chromium/DumpRenderTree.cpp: (main): Declare the new flag string, and check for it on startup.
- DumpRenderTree/chromium/TestShell.cpp: (TestShell::TestShell): Add a boolean for the new flag, in order to preserve its value over preferences reset. (TestShell::resetWebSettings): Set the new flag to the stored value on reset.
- DumpRenderTree/chromium/TestShell.h: (TestShell::setAccelerated2dCanvasEnabled): Add an accessor for the new flag.
- DumpRenderTree/chromium/WebPreferences.cpp: (WebPreferences::reset): Initialize the new flag to false. (WebPreferences::applyTo): Copy the flag's value to the WebSettings.
- DumpRenderTree/chromium/WebPreferences.h: Add the new flag.
- 7:22 AM Changeset in webkit [68135] by
-
- 3 edits in trunk/WebCore
2010-09-23 Patrick Gansterer <Patrick Gansterer>
Reviewed by Adam Roben.
[WINCE] Remove usage of MemoryManager
https://bugs.webkit.org/show_bug.cgi?id=46206
MemoryManager does not provide any extra value, so remove it.
- page/wince/FrameWinCE.cpp: (WebCore::imageFromSelection):
- platform/graphics/wince/PlatformPathWinCE.cpp: (WebCore::drawPolygons):
- 7:14 AM Changeset in webkit [68134] by
-
- 2 edits in trunk/JavaScriptCore
2010-09-23 Ismail Dönmez <ismail@namtrac.org>
Unreviewed.
JIT should be disabled on Windows CE. Broken in r64176.
- wtf/Platform.h:
- 6:47 AM QtWebKitRelease20 edited by
- (diff)
- 6:36 AM Changeset in webkit [68133] by
-
- 2 edits in trunk/WebKit/win
2010-09-23 Matthew Delaney <mdelaney@apple.com>
Reviewed by Adam Roben.
Create one time initialization block for WebView's initWithFrame
https://bugs.webkit.org/show_bug.cgi?id=46307
- WebView.cpp: Added one time initialization block for webview code that needs only be run once and not for each webview. This is just as the mac version WebView.mm does.
- 6:29 AM Changeset in webkit [68132] by
-
- 3 edits in trunk/WebKit/wince
2010-09-23 Patrick Gansterer <Patrick Gansterer>
Unreviewed.
Build fix for FrameLoaderClientWinCE.
- WebCoreSupport/FrameLoaderClientWinCE.cpp: (WebKit::FrameLoaderClientWinCE::canShowMIMETypeAsHTML): Add missing method.
- WebCoreSupport/FrameLoaderClientWinCE.h:
- 5:38 AM Changeset in webkit [68131] by
-
- 2 edits in trunk/WebKit/chromium
2010-09-23 Jeremy Orlow <jorlow@chromium.org>
Unreviewed small fix for my last patch.
- public/WebIDBTransaction.h: (WebKit::WebIDBTransaction::id):
- 4:24 AM Changeset in webkit [68130] by
-
- 1 add in trunk/WebKit/qt/examples/examples.pro
Fix Qt build by adding missing file
- 4:13 AM Changeset in webkit [68129] by
-
- 14 edits3 adds1 delete in trunk/LayoutTests
2010-09-23 Adam Barth <abarth@webkit.org>
Rubber-stamped by Eric Seidel.
Sync HTML5lib tests with upstream.
- html5lib/resources/comments01.dat:
- html5lib/resources/pending-spec-changes-plain-text-unsafe.dat: Added.
- html5lib/resources/pending-spec-changes.dat: Added.
- html5lib/resources/plain-text-unsafe.dat: Added.
- html5lib/resources/tests1.dat:
- html5lib/resources/tests10.dat:
- html5lib/resources/tests13.dat: Removed.
- html5lib/resources/tests14.dat:
- html5lib/resources/tests15.dat:
- html5lib/resources/tests17.dat:
- html5lib/resources/tests19.dat:
- html5lib/resources/tests20.dat:
- html5lib/resources/tests21.dat:
- html5lib/resources/tests9.dat:
- html5lib/resources/tests_innerHTML_1.dat:
- html5lib/runner-expected.txt:
- 3:53 AM Changeset in webkit [68128] by
-
- 9 edits in trunk
2010-09-23 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
Reviewed by Simon Hausmann.
[Qt] Refactor QtWebKitPlatformPlugin interface
Make it easier to keep source-compability for the
QtWebKitPlatformPlugin interface, and run qmake
on the example (but not build) for convenience.
- Api/qwebkitplatformplugin.h:
- WebCoreSupport/QtPlatformPlugin.cpp:
- examples/platformplugin/README:
- examples/platformplugin/WebPlugin.cpp:
- examples/platformplugin/WebPlugin.h:
- examples/platformplugin/qwebkitplatformplugin.h:
2010-09-23 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
Reviewed by Simon Hausmann.
[Qt] Refactor QtWebKitPlatformPlugin interface
Make it easier to keep source-compability for the
QtWebKitPlatformPlugin interface, and run qmake
on the example (but not build) for convenience.
- Scripts/webkitdirs.pm:
- 1:40 AM Changeset in webkit [68127] by
-
- 3 edits in trunk/JavaScriptCore
2010-09-23 Peter Varga <pvarga@inf.u-szeged.hu>
Reviewed by Gavin Barraclough.
Reduce the number of BOL checks in YARR Interpreter
https://bugs.webkit.org/show_bug.cgi?id=46260
Extend the YARR Interpreter with an optimization which reduces the number of
BOL assertion checks. If a "TypeBodyAlternative" byteTerm is followed by a
"TypeAssertionBOL" byteTerm it will be checked just one time.
- yarr/RegexInterpreter.cpp: (JSC::Yarr::Interpreter::matchDisjunction): (JSC::Yarr::ByteCompiler::compile): (JSC::Yarr::ByteCompiler::regexBegin): (JSC::Yarr::ByteCompiler::alternativeBodyDisjunction): (JSC::Yarr::ByteCompiler::emitDisjunction):
- yarr/RegexInterpreter.h: (JSC::Yarr::ByteTerm::BodyAlternativeBegin): (JSC::Yarr::ByteTerm::BodyAlternativeDisjunction): (JSC::Yarr::ByteTerm::BodyAlternativeEnd): (JSC::Yarr::ByteTerm::AlternativeBegin): (JSC::Yarr::ByteTerm::AlternativeDisjunction): (JSC::Yarr::ByteTerm::AlternativeEnd):
- 1:38 AM Changeset in webkit [68126] by
-
- 3 edits in trunk/WebCore
2010-09-23 Darin Adler <Darin Adler>
Reviewed by Chris Fleizach.
media/video-controls-with-mutation-event-handler.html crashing
https://bugs.webkit.org/show_bug.cgi?id=46169
- rendering/MediaControlElements.cpp: (WebCore::MediaControlInputElement::MediaControlInputElement): Don't take a type argument. We can't set the type until after the element is created beacuse of reference counting rules. (WebCore::MediaControlMuteButtonElement::MediaControlMuteButtonElement): Don't pass the type. (WebCore::MediaControlMuteButtonElement::create): Set the type. (WebCore::MediaControlPlayButtonElement::MediaControlPlayButtonElement): More of the same. (WebCore::MediaControlPlayButtonElement::create): Ditto. (WebCore::MediaControlSeekButtonElement::MediaControlSeekButtonElement): Ditto. (WebCore::MediaControlSeekButtonElement::create): Ditto. (WebCore::MediaControlRewindButtonElement::MediaControlRewindButtonElement): Ditto. (WebCore::MediaControlRewindButtonElement::create): Ditto. (WebCore::MediaControlReturnToRealtimeButtonElement::MediaControlReturnToRealtimeButtonElement): Ditto. (WebCore::MediaControlReturnToRealtimeButtonElement::create): Ditto. (WebCore::MediaControlToggleClosedCaptionsButtonElement::MediaControlToggleClosedCaptionsButtonElement): Ditto. (WebCore::MediaControlToggleClosedCaptionsButtonElement::create): Ditto. (WebCore::MediaControlTimelineElement::MediaControlTimelineElement): Ditto. (WebCore::MediaControlTimelineElement::create): Ditto. (WebCore::MediaControlVolumeSliderElement::MediaControlVolumeSliderElement): Ditto. (WebCore::MediaControlVolumeSliderElement::create): Ditto. (WebCore::MediaControlFullscreenButtonElement::MediaControlFullscreenButtonElement): Ditto. (WebCore::MediaControlFullscreenButtonElement::create): Ditto.
- rendering/MediaControlElements.h: Removed the type argument from the MediaControlInputElement constructor.
- 12:23 AM Changeset in webkit [68125] by
-
- 3 edits in trunk/WebKitTools
2010-09-23 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Tweak some status messages that Eric thought were confusing
https://bugs.webkit.org/show_bug.cgi?id=46342
- Scripts/webkitpy/tool/commands/queues.py:
- Scripts/webkitpy/tool/commands/queues_unittest.py:
Sep 22, 2010:
- 11:59 PM Changeset in webkit [68124] by
-
- 2 edits4 adds in trunk
2010-09-22 Luke Macpherson <macpherson@chromium.org>
Reviewed by Alexey Proskuryakov.
Don't allow empty strings as tokens in xmlhttprequest, as per rfc2616 section 2.2.
XMLHttpRequest: setRequestHeader() does not throw SYNTAX_ERR exception if the header field name is empty
https://bugs.webkit.org/show_bug.cgi?id=46151
Test: http/tests/xmlhttprequest/xmlhttprequest-setrequestheader-no-name.html
- xml/XMLHttpRequest.cpp: (WebCore::isValidToken):
- 10:15 PM Changeset in webkit [68123] by
-
- 3 edits2 adds in trunk/WebCore
2010-09-22 Kwang Yul Seo <skyul@company100.net>
Reviewed by Adam Barth.
[BREWMP] Enable touch events
https://bugs.webkit.org/show_bug.cgi?id=46321
Enable TOUCH_EVENTS by porting PlatformTouchEvent and PlatformTouchPoint.
Brew MP does not support multi touch, so enable only single touch for now.
- platform/PlatformTouchEvent.h:
- platform/PlatformTouchPoint.h:
- platform/brew/PlatformTouchEventBrew.cpp: Added. (WebCore::PlatformTouchEvent::PlatformTouchEvent):
- platform/brew/PlatformTouchPointBrew.cpp: Added. (WebCore::PlatformTouchPoint::PlatformTouchPoint):
- 9:55 PM Changeset in webkit [68122] by
-
- 3 edits in trunk/WebKitTools
2010-09-22 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Fix comm-queue typo
https://bugs.webkit.org/show_bug.cgi?id=46339
We were missing a "self". The real problem is that we didn't have an
integration test for the failure case.
- Scripts/webkitpy/tool/commands/queues.py:
- Scripts/webkitpy/tool/commands/queues_unittest.py:
- 9:33 PM Changeset in webkit [68121] by
-
- 6 edits26 adds in trunk/LayoutTests
2010-09-22 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Adam Barth.
Rebaseline a few repainting tests for Chromium.
https://bugs.webkit.org/show_bug.cgi?id=46337
- platform/chromium-linux/fast/repaint/block-layout-inline-children-float-positioned-expected.checksum: Added.
- platform/chromium-linux/fast/repaint/block-layout-inline-children-float-positioned-expected.png: Added.
- platform/chromium-linux/fast/repaint/block-layout-inline-children-float-positioned-expected.txt: Added.
- platform/chromium-linux/fast/repaint/block-layout-inline-children-replaced-expected.checksum: Added.
- platform/chromium-linux/fast/repaint/block-layout-inline-children-replaced-expected.png: Added.
- platform/chromium-linux/fast/repaint/block-layout-inline-children-replaced-expected.txt: Added.
- platform/chromium-linux/fast/repaint/list-marker-expected.checksum:
- platform/chromium-linux/fast/repaint/list-marker-expected.png:
- platform/chromium-mac/fast/repaint/background-misaligned-expected.checksum: Added.
- platform/chromium-mac/fast/repaint/background-misaligned-expected.png: Added.
- platform/chromium-mac/fast/repaint/block-layout-inline-children-float-positioned-expected.checksum: Added.
- platform/chromium-mac/fast/repaint/block-layout-inline-children-float-positioned-expected.png: Added.
- platform/chromium-mac/fast/repaint/block-layout-inline-children-replaced-expected.checksum: Added.
- platform/chromium-mac/fast/repaint/block-layout-inline-children-replaced-expected.png: Added.
- platform/chromium-mac/fast/repaint/continuation-after-outline-expected.checksum: Added.
- platform/chromium-mac/fast/repaint/continuation-after-outline-expected.png: Added.
- platform/chromium-mac/fast/repaint/inline-outline-repaint-expected.checksum: Added.
- platform/chromium-mac/fast/repaint/inline-outline-repaint-expected.png: Added.
- platform/chromium-mac/fast/repaint/opacity-change-on-overflow-float-expected.checksum: Added.
- platform/chromium-mac/fast/repaint/opacity-change-on-overflow-float-expected.png: Added.
- platform/chromium-mac/fast/repaint/subtree-root-clip-3-expected.checksum: Added.
- platform/chromium-mac/fast/repaint/subtree-root-clip-3-expected.png: Added.
- platform/chromium-win/fast/repaint/block-layout-inline-children-float-positioned-expected.checksum: Added.
- platform/chromium-win/fast/repaint/block-layout-inline-children-float-positioned-expected.png: Added.
- platform/chromium-win/fast/repaint/block-layout-inline-children-float-positioned-expected.txt: Added.
- platform/chromium-win/fast/repaint/block-layout-inline-children-replaced-expected.checksum: Added.
- platform/chromium-win/fast/repaint/block-layout-inline-children-replaced-expected.png: Added.
- platform/chromium-win/fast/repaint/block-layout-inline-children-replaced-expected.txt: Added.
- platform/chromium-win/fast/repaint/list-marker-expected.checksum:
- platform/chromium-win/fast/repaint/list-marker-expected.png:
- platform/chromium/test_expectations.txt: Updated, removed crazy comment.
- 9:19 PM Changeset in webkit [68120] by
-
- 3 edits in trunk/BugsSite
2010-09-22 Adam Barth <abarth@webkit.org>
Reviewed by John Sullivan.
New review-page design doesn't include name of reviewer
https://bugs.webkit.org/show_bug.cgi?id=46271
- PrettyPatch/PrettyPatch.rb:
- code-review.js:
- 8:46 PM Changeset in webkit [68119] by
-
- 2 edits in trunk/BugsSite
2010-09-22 Adam Barth <abarth@webkit.org>
Fix typo in CSS.
- PrettyPatch/PrettyPatch.rb:
- 8:42 PM Changeset in webkit [68118] by
-
- 3 edits in trunk/BugsSite
2010-09-22 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Add link to bug to review page
https://bugs.webkit.org/show_bug.cgi?id=46192
To make room for the link, I moved the help text to the top of the page
and tweaked the language to help folks discover that you can select
context using the line numbers.
Also, move more text to sans-serif since that fits in better with the
pretty-patch fonts.
- PrettyPatch/PrettyPatch.rb:
- code-review.js:
- 8:11 PM Changeset in webkit [68117] by
-
- 5 edits in trunk/WebKitTools
2010-09-22 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
commit-queue should log more detailed messages to the QueueStatusServer
https://bugs.webkit.org/show_bug.cgi?id=46333
When I created CommitQueueTask, I removed most of the previous logging.
This patch adds back more detailed logging so folks can see their patch
progress through the queue.
- Scripts/webkitpy/tool/bot/commitqueuetask.py:
- Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
- Scripts/webkitpy/tool/commands/queues.py:
- Scripts/webkitpy/tool/commands/queues_unittest.py:
- 7:57 PM Changeset in webkit [68116] by
-
- 2 edits in trunk/WebCore
Fix a typo and correct an inaccurate phrase in a comment.
Rubber-stamped by Darin Adler.
- html/parser/HTMLTreeBuilder.cpp:
(WebCore::HTMLTreeBuilder::processEndTag):
- 7:39 PM Changeset in webkit [68115] by
-
- 8 edits3 adds in trunk
2010-09-22 Andy Estes <aestes@apple.com>
Reviewed by Adam Barth.
REGRESSION (r61285): <script /> parses differently in HTML5
https://bugs.webkit.org/show_bug.cgi?id=42909
If pre-HTML5 parser quirks are enabled, the HTMLTreeBuilder should
handle self-closing script tags like the old parser did. Specifically,
"<script />" should be treated as "<script></script>".
- html/parser/HTMLDocumentParser.cpp: (WebCore::HTMLDocumentParser::HTMLDocumentParser): Instantiate HTMLTreeBuilder with the value of usePreHTML5ParserQuirks().
- html/parser/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::HTMLTreeBuilder): (WebCore::HTMLTreeBuilder::processEndTag): If the tokenizer is not currently in DataState, this means that the current end token is fake and was created by the tree builder to handle a self-closing script tag. Assert that pre-HTML5 quirks are enabled and set the tokenizer's state to DataState in this case. (WebCore::HTMLTreeBuilder::processStartTagForInHead): If pre-HTML5 parser quirks are enabled and the script tag is self-closing, create and procses a fake script end tag.
- html/parser/HTMLTreeBuilder.h: (WebCore::HTMLTreeBuilder::create):
2010-09-22 Andy Estes <aestes@apple.com>
Reviewed by Adam Barth.
REGRESSION (r61285): <script /> parses differently in HTML5
https://bugs.webkit.org/show_bug.cgi?id=42909
Add tests for the self-closing script tag quirk.
- fast/parser/pre-html5-parser-quirks-expected.txt:
- fast/parser/pre-html5-parser-quirks.html:
- fast/parser/resources/pre-html5-parser-quirk-document-fragment.html:
- fast/parser/resources/pre-html5-parser-quirk-self-closing-script-in-body.html: Added.
- fast/parser/resources/pre-html5-parser-quirk-self-closing-script-in-head.html: Added.
- fast/parser/resources/pre-html5-parser-quirk-self-closing-script.js: Added. (printToConsole):
- 7:08 PM Changeset in webkit [68114] by
-
- 15 edits2 deletes in trunk
2010-09-22 Mihai Parparita <mihaip@chromium.org>
Reviewed by Darin Fisher.
[Chromium] User style layout tests don't pass on Chromium
https://bugs.webkit.org/show_bug.cgi?id=46069
User style tests should now pass with the Chromium DRT since we now
apply the styles immediately, just like the other ports (once we also
remove some bad baselines for user-style-top-frame-only added by
r62958).
Tests still don't pass with test_shell until it starts to use
InjectInExistingDocuments too.
- platform/chromium-mac/userscripts/user-style-top-frame-only-expected.txt: Removed.
- platform/chromium-win/userscripts/user-style-top-frame-only-expected.txt: Removed.
- platform/chromium/drt_expectations.txt:
2010-09-22 Mihai Parparita <mihaip@chromium.org>
Reviewed by Darin Fisher.
[Chromium] User style layout tests don't pass on Chromium
https://bugs.webkit.org/show_bug.cgi?id=46069
Instead of making resetUserStyleCacheInAllFrames be a no-op for
Chromium, have it be controlled by a UserStyleInjectionTime enum.
Also move the UserStyleSheet::Level enum to be inside
UserStyleSheetTypes for consistency.
- WebCore.exp.in:
- dom/Document.cpp: (WebCore::Document::pageGroupUserSheets):
- page/PageGroup.cpp: (WebCore::PageGroup::addUserStyleSheetToWorld):
- page/PageGroup.h:
- page/UserStyleSheet.h: (WebCore::UserStyleSheet::UserStyleSheet): (WebCore::UserStyleSheet::level):
- page/UserStyleSheetTypes.h:
2010-09-22 Mihai Parparita <mihaip@chromium.org>
Reviewed by Darin Fisher.
[Chromium] User style layout tests don't pass on Chromium
https://bugs.webkit.org/show_bug.cgi?id=46069
Expose UserStyleInjectionTime in WebView.
- public/WebView.h:
- src/WebViewImpl.cpp: (WebKit::WebView::addUserStyleSheet):
2010-09-22 Mihai Parparita <mihaip@chromium.org>
Reviewed by Darin Fisher.
[Chromium] User style layout tests don't pass on Chromium
https://bugs.webkit.org/show_bug.cgi?id=46069
Fix a typo in LayoutTestController::addUserStyleSheet that was causing a
crash the Chromium DRT. Pass InjectInExistingDocuments to mimic DRT
behavior from other ports.
- DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::addUserStyleSheet):
- 7:02 PM Changeset in webkit [68113] by
-
- 2 edits in trunk/WebKit/chromium
2010-09-22 James Robinson <jamesr@chromium.org>
[chromium] Re-synchronizes features.gypi with upstream feature_overrides.gypi.
- features.gypi:
- 6:55 PM Changeset in webkit [68112] by
-
- 18 edits in trunk
2010-09-22 Ruben <chromium@hybridsource.org>
Reviewed by Tony Chang.
[chromium] added ifdefs for FreeBSD support
https://bugs.webkit.org/show_bug.cgi?id=46316
- bindings/js/JSInspectorFrontendHostCustom.cpp: (WebCore::JSInspectorFrontendHost::platform):
- bindings/v8/custom/V8InspectorFrontendHostCustom.cpp: (WebCore::V8InspectorFrontendHost::platformCallback):
- dom/SelectElement.cpp:
- loader/CachedFont.cpp:
- page/EventHandler.cpp:
- page/chromium/EventHandlerChromium.cpp:
- platform/Scrollbar.cpp:
- platform/chromium/ChromiumBridge.h:
- platform/graphics/chromium/FontPlatformData.h:
- platform/graphics/skia/FontCustomPlatformData.cpp: (WebCore::FontCustomPlatformData::~FontCustomPlatformData): (WebCore::FontCustomPlatformData::fontPlatformData): (WebCore::createFontCustomPlatformData):
- platform/graphics/skia/FontCustomPlatformData.h:
2010-09-22 Ruben <chromium@hybridsource.org>
Reviewed by Tony Chang.
[chromium] added ifdefs for FreeBSD support
https://bugs.webkit.org/show_bug.cgi?id=46316
- WebKit.gyp:
- features.gypi:
- src/ChromiumBridge.cpp:
- src/WebFrameImpl.cpp: (WebKit::ChromePrintContext::spoolPage):
- src/WebViewImpl.cpp: (WebKit::WebViewImpl::mouseDown): (WebKit::WebViewImpl::mouseUp): (WebKit::WebViewImpl::keyEvent): (WebKit::WebViewImpl::setScrollbarColors): (WebKit::WebViewImpl::setSelectionColors):
- 6:48 PM Changeset in webkit [68111] by
-
- 2 edits in trunk/WebKit/gtk
2010-09-22 Mario Sanchez Prada <msanchez@igalia.com>
Reviewed by Martin Robinson.
[GTK] Replace instances of g_timeout_add() with g_idle_add() in testatk.c
https://bugs.webkit.org/show_bug.cgi?id=46284
Use g_idle_add() whenever g_timeout_add() was being used.
This is desired because it's better to rely on the main loop to
decide when it's a good moment to execute the task (when idle)
than manually setting a timeout, which also sets a minimum amount
of time needed to get the function executed.
- tests/testatk.c: (testWekitAtkTextSelections): (testWebkitAtkGetExtents): (testWebkitAtkListsOfItems): (main):
- 6:31 PM Changeset in webkit [68110] by
-
- 3 edits in trunk/WebCore
2010-09-22 Rafael Antognolli <antognolli@profusion.mobi>
Unreviewed build fix.
[EFL] Fix build due to latest EFL (Edje) changes.
https://bugs.webkit.org/show_bug.cgi?id=46317
Make the change int -> Edje_Load_Error (enum).
No new functionality, so no new tests.
- platform/efl/RenderThemeEfl.cpp: (WebCore::RenderThemeEfl::themePartCacheEntryReset): (WebCore::RenderThemeEfl::createEdje): (WebCore::RenderThemeEfl::applyPartDescriptions):
- platform/efl/ScrollbarEfl.cpp: (ScrollbarEfl::setParent):
- 6:31 PM Changeset in webkit [68109] by
-
- 2 edits in trunk/LayoutTests
2010-09-22 Kinuko Yasuda <kinuko@chromium.org>
Unreviewed, temporarily disabling the new filesystem test on chromium.
- platform/chromium/test_expectations.txt:
- 6:27 PM Changeset in webkit [68108] by
-
- 3 edits2 adds in trunk
WebCore: AX: aria-hidden change doesn't update the ax tree
https://bugs.webkit.org/show_bug.cgi?id=45836
Reviewed by Darin Adler.
Test: accessibility/aria-hidden-update.html
- dom/Element.cpp:
(WebCore::Element::updateAfterAttributeChanged):
LayoutTests: [FileSystem] Fix Flags handling in DirectoryEntry custom binding code
https://bugs.webkit.org/show_bug.cgi?id=46028
Patch by Kinuko Yasuda <kinuko@chromium.org> on 2010-09-22
Reviewed by Dumitru Daniliuc.
- fast/filesystem/flags-passing-expected.txt: Added.
- fast/filesystem/flags-passing.html: Added.
- fast/filesystem/script-tests/TEMPLATE.html: Added.
- fast/filesystem/script-tests/flags-passing.js: Added.
- platform/gtk/Skipped: FileSystem API not supported on gtk.
- platform/mac/Skipped: FileSystem API not supported on mac.
- platform/qt/Skipped: FileSystem API not supported on qt.
- platform/win/Skipped: FileSystem API not supported on win.
- 6:20 PM Changeset in webkit [68107] by
-
- 6 edits2 adds in trunk
[WinCairo] Part 2: Update WebKitTestRunner and DumpRenderTree Build.
https://bugs.webkit.org/show_bug.cgi?id=46303.
Reviewed by Martin Robinson.
WebKit/win:
- WebKit.vcproj/WebKit.sln: Update overall Debug_Cairo and
Release_Cairo configurations to select appropriate build
targets for WebKitTestRunner and MiniBrowser.
WebKitTools:
- MiniBrowser/Configurations/MiniBrowserCFLite.vsprops: Added.
- MiniBrowser/Configurations/MiniBrowserCommon.vsprops: Moved
CoreFoundation-specific stuff to new MiniBrowserCoreFoundation
property sheet.
- MiniBrowser/Configurations/MiniBrowserCoreFoundation.vsprops: Added.
- MiniBrowser/MiniBrowser.vcproj: Updated configuration to use
appropriate property sheet for the build types.
- WebKitTestRunner/win/WebKitTestRunner.vcproj: Updated the
configuration to use appropriate property sheet for CoreFoundation
and CFLite-style builds.
- 6:18 PM Changeset in webkit [68106] by
-
- 2 edits in trunk
2010-09-22 Lucas De Marchi <lucas.demarchi@profusion.mobi>
Reviewed by Antonio Gomes.
[EFL] Fix build with GCC 4.4.x
https://bugs.webkit.org/show_bug.cgi?id=40826
Change the -fstrict-aliasing flag to -fno-strict-aliasing as other
ports like GTK and QT are using in their build systems. It was failing
to execute when compiled with GCC 4.4.x in Release mode.
Refactor the flags in order to be more readable.
- cmake/WebKitHelpers.cmake:
- 5:58 PM Changeset in webkit [68105] by
-
- 8 edits6 adds in trunk
2010-09-22 Kinuko Yasuda <kinuko@chromium.org>
Reviewed by Dumitru Daniliuc.
[FileSystem] Fix Flags handling in DirectoryEntry custom binding code
https://bugs.webkit.org/show_bug.cgi?id=46028
Do not use adoptRef to get RefPtr from a raw pointer that is already
adopted in toNative/toJS.
Test: fast/filesystem/flags-passing.html
- bindings/js/JSDirectoryEntryCustom.cpp: (WebCore::JSDirectoryEntry::getFile): (WebCore::JSDirectoryEntry::getDirectory):
- bindings/v8/custom/V8DirectoryEntryCustom.cpp: (WebCore::V8DirectoryEntry::getDirectoryCallback): (WebCore::V8DirectoryEntry::getFileCallback):
2010-09-22 Kinuko Yasuda <kinuko@chromium.org>
Reviewed by Dumitru Daniliuc.
[FileSystem] Fix Flags handling in DirectoryEntry custom binding code
https://bugs.webkit.org/show_bug.cgi?id=46028
- fast/filesystem/flags-passing-expected.txt: Added.
- fast/filesystem/flags-passing.html: Added.
- fast/filesystem/script-tests/TEMPLATE.html: Added.
- fast/filesystem/script-tests/flags-passing.js: Added.
- platform/gtk/Skipped: FileSystem API not supported on gtk.
- platform/mac/Skipped: FileSystem API not supported on mac.
- platform/qt/Skipped: FileSystem API not supported on qt.
- platform/win/Skipped: FileSystem API not supported on win.
- 5:45 PM Changeset in webkit [68104] by
-
- 2 edits3 adds in trunk/LayoutTests
2010-09-22 Tony Chang <tony@chromium.org>
Reviewed by David Levin.
[chromium] add baselines for xmlhttprequest tests for chromium
https://bugs.webkit.org/show_bug.cgi?id=46281
- platform/chromium/http/tests/xmlhttprequest/methods-async-expected.txt: Allow no content-length for non-get/post requests
- platform/chromium/http/tests/xmlhttprequest/methods-expected.txt: Allow no content-length for non-get/post requests
- platform/chromium/test_expectations.txt: Enable 3 tests on linux + mac
- 5:44 PM Changeset in webkit [68103] by
-
- 3 edits in trunk/WebCore
2010-09-22 Jia Pu <jpu@apple.com>
Reviewed by Dan Bernstein.
Need to stop autocorrection panel timer when selection changes.
https://bugs.webkit.org/show_bug.cgi?id=46201
<rdar://problem/8441042>
- editing/Editor.cpp: (WebCore::Editor::appliedEditing): Stop correction timer after editing. (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges): When text checking is done for showing autocorrection panel, we suppress all corrections that are not at the end of text checking range. So that we don't replace other words while showing correction panel for the last word. (WebCore::Editor::stopCorrectionPanelTimer): Stop correction timer.
- editing/Editor.h: Added stopCorrectionPanelTimer() method.
- 5:37 PM Changeset in webkit [68102] by
-
- 3 edits2 adds in trunk/WebKitTools
2010-09-22 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Optimize commit-queue performance for green trees
https://bugs.webkit.org/show_bug.cgi?id=46254
This patch redesigns the controller logic for the commit-queue. In the
new design, the controller exercises much finer-grained control over
the landing process. In particular:
- Patches that fail to apply now get rejected almost immediately.
- Patches that fail to build get rejects after two builds (instead of three builds and one test run).
- Patches that run into a flaky test now get accepted after one build and two test runs instead of three full build-and-test runs.
The main cost of these optimizations is that we don't find out the tree
has a failing test until the very end of the process, but if the tree
has a busted test, there's not much we can do anyway. We might as well
burn commit-queue resources spinning optimisticly.
- Scripts/webkitpy/tool/bot/commitqueuetask.py: Added.
- Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py: Added.
- Scripts/webkitpy/tool/commands/queues.py:
- 5:07 PM Changeset in webkit [68101] by
-
- 14 edits in trunk
2010-09-22 Eric Uhrhane <ericu@chromium.org>
Reviewed by Dumitru Daniliuc.
Add Chromium implementation for FileWriter
https://bugs.webkit.org/show_bug.cgi?id=44361
No new tests; the implementation's not yet far enough along for that.
This makes a chain of contruction-and-linking-up for various sorts of
FileWriter interfaces to call through to Chromium, and for various
sorts of FileWriterClients to call back, with object ownership always
pointing towards the Chromium API. That is, the DOM object owns an
AsyncFileWriter, which owns its implementation object, and the reverse
(client) direction is raw pointers.
File metadata is looked up before the FileWriter is returned, so that
we know the file exists and can cache its length.
The WebCore part of this is simple and generic enough to handle
Chromium, so it should be easy for me to put in a WebCore-only
implementation next.
- fileapi/AsyncFileWriter.h:
- fileapi/DOMFileSystem.cpp: (WebCore::DOMFileSystem::createWriter):
- fileapi/DOMFileSystem.h:
- fileapi/FileSystemCallbacks.cpp: (WebCore::FileSystemCallbacksBase::didCreateFileWriter): (WebCore::FileWriterCallbacks::FileWriterCallbacks): (WebCore::FileWriterCallbacks::didCreateFileWriter):
- fileapi/FileSystemCallbacks.h:
- platform/AsyncFileSystem.h:
- platform/AsyncFileSystemCallbacks.h:
2010-09-22 Eric Uhrhane <ericu@chromium.org>
Reviewed by Dumitru Daniliuc.
Add Chromium implementation for FileWriter
https://bugs.webkit.org/show_bug.cgi?id=44361
No new tests; the implementation's not yet far enough along for that.
This makes a chain of construction-and-linking-up for various sorts of
FileWriter interfaces to call through to Chromium, and for various
sorts of FileWriterClients to call back, with object ownership always
pointing towards the Chromium API. That is, the DOM object owns an
AsyncFileWriter, which owns its implementation object, and the reverse
(client) direction is raw pointers.
File metadata is looked up before the FileWriter is returned, so that
we know the file exists and can cache its length.
The WebKit/chromium interface here is modeled after that of the
FileSystem.
- public/WebFileInfo.h: (WebKit::WebFileInfo::WebFileInfo):
- src/AsyncFileSystemChromium.cpp: (WebCore::FileWriterHelperCallbacks::FileWriterHelperCallbacks): (WebCore::FileWriterHelperCallbacks::didSucceed): (WebCore::FileWriterHelperCallbacks::didReadMetadata): (WebCore::FileWriterHelperCallbacks::didReadDirectory): (WebCore::FileWriterHelperCallbacks::didOpenFileSystem): (WebCore::FileWriterHelperCallbacks::didCreateFileWriter): (WebCore::FileWriterHelperCallbacks::didFail): (WebCore::AsyncFileSystemChromium::createWriter):
- src/AsyncFileSystemChromium.h:
- src/AsyncFileWriterChromium.cpp: (WebCore::AsyncFileWriterChromium::setWebFileWriter): (WebCore::AsyncFileWriterChromium::write): (WebCore::AsyncFileWriterChromium::didFail):
- src/AsyncFileWriterChromium.h:
- src/WebFileSystemCallbacksImpl.h:
- 5:06 PM Changeset in webkit [68100] by
-
- 5 edits in trunk
2010-09-22 Michael Saboff <msaboff@apple.com>
Reviewed by Gavin Barraclough.
Fixed the cross over from alternatives executed once and
those that loop. This fixed the problem where the index
was getting messed up for looping alternatives causing an
infinite loop.
https://bugs.webkit.org/show_bug.cgi?id=46189
- yarr/RegexJIT.cpp: (JSC::Yarr::RegexGenerator::generateDisjunction):
2010-09-22 Michael Saboff <msaboff@apple.com>
Reviewed by Gavin Barraclough.
Updated tests to include patterns similar to what caused the problems
in https://bugs.webkit.org/show_bug.cgi?id=46189.
- fast/js/regexp-bol-expected.txt:
- fast/js/script-tests/regexp-bol.js:
- 4:40 PM Changeset in webkit [68099] by
-
- 2 edits in trunk/WebKit/qt
2010-09-22 Andras Becsi <abecsi@webkit.org>
Speculative build fix for the Qt Windows bots.
- Api/DerivedSources.pro:
- 4:34 PM Changeset in webkit [68098] by
-
- 6 edits2 adds in trunk
WebKit/win: [WinCairo] Update WebKitTestRunner and DumpRenderTree Build.rt
https://bugs.webkit.org/show_bug.cgi?id=46303.
Reviewed by Martin Robinson.
- WebKit.vcproj/WebKit.sln: Update overall Debug_Cairo and
Release_Cairo configurations to select appropriate build
targets for InjectionBundle.
WebKitTools: [WinCairo] Update WebKitTestRunner and DumpRenderTree Build.
https://bugs.webkit.org/show_bug.cgi?id=46303.
Reviewed by Martin Robinson.
- DumpRenderTree/win/DumpRenderTree.vcproj: Disable local MD5 sources
for Cairo build. Copy wtf MD5 header to ForwardingHeaders for the
WinCairo build.
- WebKitTestRunner/Configurations/InjectedBundleCFLite.vsprops: Added.
- WebKitTestRunner/win/InjectedBundle.vcproj: Update win new *_Cairo
build targets that use the new InjectedBundleCFLite.vsprops file.
- 4:20 PM Changeset in webkit [68097] by
-
- 3 edits in trunk/WebKit2
2010-09-22 Andras Becsi <abecsi@webkit.org>
Unreviewed build fix after r68079.
[Qt] Also generate WebPage's message-receiving code and message types
for the Qt port of WebKit2.
- DerivedSources.pro:
- WebKit2.pro:
- 4:12 PM Changeset in webkit [68096] by
-
- 6 edits2 adds in trunk
Reviewed by Adam Barth.
https://bugs.webkit.org/show_bug.cgi?id=46222
<rdar://problem/8461701> Document.getElementById() malfunctions if ID was changed via Attr node modification.
Test: fast/dom/Attr/change-id-via-attr-node-value.html
- dom/Attr.h:
- dom/Attr.cpp: (WebCore::Attr::setValue): Separated a version callable from WebCore from one avaiable to JS. Attr::setValue() can be called from Element::setAttribute(), and we don't want to update m_elementsById (or to call attributeChanged()) twice in that case. (WebCore::Attr::childrenChanged): If Attr's node children change, id changes.
- dom/Document.cpp: (WebCore::Document::removeElementById): Added an assertion that we are not trying to remove something that isn't there. If we are, we probably failed to update m_elementsById earlier.
- dom/Element.cpp: (WebCore::Element::setAttribute): If the attribute has an Attr node, its children should be updated to match attribute value.
- 4:06 PM Changeset in webkit [68095] by
-
- 2 edits in tags/Safari-534.8.1/JavaScriptCore
Merge r68092.
- 4:02 PM Changeset in webkit [68094] by
-
- 5 edits in tags/Safari-534.8.1
Versioning.
- 3:53 PM Changeset in webkit [68093] by
-
- 1 copy in tags/Safari-534.8.1
New tag.
- 3:49 PM Changeset in webkit [68092] by
-
- 2 edits in trunk/JavaScriptCore
Allow jsc.exe to be run against unversioned ICU.
Rubber stamped by Jon Honeycutt.
- JavaScriptCore.vcproj/jsc/jscCommon.vsprops:
- 3:40 PM Changeset in webkit [68091] by
-
- 4 edits2 adds in trunk/LayoutTests
2010-09-22 Tony Chang <tony@chromium.org>
Reviewed by Dimitri Glazkov.
[chromium] Rebaseline 3 tests on win/linux
https://bugs.webkit.org/show_bug.cgi?id=46315
- platform/chromium-linux/editing/selection/move-by-line-001-expected.checksum: Minor differences in how text and borders are anti-aliased.
- platform/chromium-linux/editing/selection/move-by-line-001-expected.png:
- platform/chromium-win/fast/dom/Element/getBoundingClientRect-expected.txt: This test is sensitive to font metrics. They appear correct visually, just positioned slightly different vertically.
- platform/chromium-win/fast/dom/Range/getBoundingClientRect-expected.txt: Same as above.
- platform/chromium/test_expectations.txt:
- 3:35 PM Changeset in webkit [68090] by
-
- 2 edits in trunk/LayoutTests
2010-09-22 Tony Chang <tony@chromium.org>
Reviewed by David Levin.
[chromium] remove commented out test failures from test_expectations.txt
https://bugs.webkit.org/show_bug.cgi?id=46313
- platform/chromium/test_expectations.txt:
- 3:11 PM Changeset in webkit [68089] by
-
- 4 edits in trunk/WebCore
https://bugs.webkit.org/show_bug.cgi?id=46311, lock form controls and replaced elements to vertical block flow.
Reviewed by Dan Bernstein.
Patch form controls that don't use RenderReplaced by hand in html.css. Patch all RenderReplaced elements
with an override of setStyle that forces the new style to have a vertical block flow. We have to do something like
this to cover the CSS3 content: url(img) method of image replacement.
- css/html.css:
(input, textarea, keygen, select, button, isindex, meter, progress):
- rendering/RenderReplaced.cpp:
(WebCore::RenderReplaced::setStyle):
- rendering/RenderReplaced.h:
- 3:07 PM Changeset in webkit [68088] by
-
- 2 edits2 adds in trunk/WebKit2
Stub out a PluginProcessManager class
https://bugs.webkit.org/show_bug.cgi?id=46305
Reviewed by Adam Roben.
- UIProcess/Plugins/PluginProcessManager.cpp: Added.
(WebKit::PluginProcessManager::shared):
(WebKit::PluginProcessManager::getPluginProcessConnection):
(WebKit::PluginProcessManager::removePluginProcessProxy):
- UIProcess/Plugins/PluginProcessManager.h: Added.
- WebKit2.xcodeproj/project.pbxproj:
- 3:05 PM Changeset in webkit [68087] by
-
- 3 edits in trunk/JavaScriptCore
2010-09-22 Kwang Yul Seo <skyul@company100.net>
Reviewed by Laszlo Gombos.
Use "typedef wchar_t JSChar" when compiled with RVCT
https://bugs.webkit.org/show_bug.cgi?id=40651
Use wchar_t for JSChar and UChar when compiled with RVCT.
Linux is the exception for this rule.
- API/JSStringRef.h:
- wtf/unicode/qt4/UnicodeQt4.h:
- 3:03 PM Changeset in webkit [68086] by
-
- 16 edits1 add2 deletes in trunk/LayoutTests
Unreviewed chromium test expectation changes.
- platform/chromium-linux/fast/multicol/span/span-as-immediate-child-property-removal-expected.checksum:
- platform/chromium-linux/fast/multicol/span/span-as-immediate-child-property-removal-expected.png:
- platform/chromium-linux/fast/multicol/span/span-as-immediate-child-property-removal-expected.txt:
- platform/chromium-linux/fast/multicol/span/span-as-immediate-columns-child-removal-expected.checksum:
- platform/chromium-linux/fast/multicol/span/span-as-immediate-columns-child-removal-expected.png:
- platform/chromium-linux/fast/multicol/span/span-as-immediate-columns-child-removal-expected.txt:
- platform/chromium-mac/fast/multicol/span/span-as-immediate-child-property-removal-expected.checksum:
- platform/chromium-mac/fast/multicol/span/span-as-immediate-child-property-removal-expected.png:
- platform/chromium-mac/fast/multicol/span/span-as-immediate-child-property-removal-expected.txt: Removed.
- platform/chromium-mac/fast/multicol/span/span-as-immediate-columns-child-removal-expected.checksum:
- platform/chromium-mac/fast/multicol/span/span-as-immediate-columns-child-removal-expected.png: Added.
- platform/chromium-mac/fast/multicol/span/span-as-immediate-columns-child-removal-expected.txt: Removed.
- platform/chromium-win/fast/multicol/span/span-as-immediate-child-property-removal-expected.checksum:
- platform/chromium-win/fast/multicol/span/span-as-immediate-child-property-removal-expected.png:
- platform/chromium-win/fast/multicol/span/span-as-immediate-child-property-removal-expected.txt:
- platform/chromium-win/fast/multicol/span/span-as-immediate-columns-child-removal-expected.checksum:
- platform/chromium-win/fast/multicol/span/span-as-immediate-columns-child-removal-expected.png:
- platform/chromium-win/fast/multicol/span/span-as-immediate-columns-child-removal-expected.txt:
- 2:56 PM Changeset in webkit [68085] by
-
- 2 edits in trunk/WebKitTools
2010-09-22 Dirk Pranke <dpranke@chromium.org>
Unreviewed, build fix.
Fix bustage of rebaseline-chromium-webkit-tests resulting from
r67974. Really need better unit tests for this tool :(
- Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
- 2:43 PM Changeset in webkit [68084] by
-
- 2 edits in trunk/WebKitTools
Unbreak test-webkitpy
- Scripts/webkitpy/test/main.py:
(Tester.run_tests): Add a line that mysteriously got deleted.
- 2:37 PM Changeset in webkit [68083] by
-
- 4 edits2 adds in trunk
https://bugs.webkit.org/show_bug.cgi?id=46304
Reviewed by Dan Bernstein.
display:inline should become display:inline-block when an object's block flow does not match its parent's block flow.
Added fast/blockflow/display-mutation.html
WebCore:
- css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::styleForElement):
(WebCore::CSSStyleSelector::pseudoStyleForElement):
(WebCore::CSSStyleSelector::adjustRenderStyle):
- css/CSSStyleSelector.h:
LayoutTests:
- fast/blockflow/display-mutation-expected.txt: Added.
- fast/blockflow/display-mutation.html: Added.
- 2:37 PM Changeset in webkit [68082] by
-
- 4 edits in trunk/WebKit2
Add a ViewportConfiguration class for the Qt WebKit2 API, which
currently calculated a fallback viewport configuration.
Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2010-09-22
Reviewed by Antonio Gomes.
- UIProcess/API/qt/qwkpage.cpp:
(QWKPage::ViewportConfiguration::ViewportConfiguration):
(QWKPage::ViewportConfiguration::~ViewportConfiguration):
(QWKPage::ViewportConfiguration::operator=):
(QWKPage::viewportConfigurationForSize):
- UIProcess/API/qt/qwkpage.h:
- UIProcess/API/qt/qwkpage_p.h:
(QtViewportConfigurationPrivate::QtViewportConfigurationPrivate):
- 2:14 PM Changeset in webkit [68081] by
-
- 2 edits in trunk/WebKit2
Windows build fix
- WebProcess/WebKitMain.cpp:
(WebKitMain): Fix typo
- 1:44 PM Changeset in webkit [68080] by
-
- 3 edits in trunk/WebKitTools
Make test-webkitpy test WebKit2's scripts
These scripts can't be in WebKitTools due to limitations of Apple's
build process. But that doesn't mean we can't test them!
Fixes <http://webkit.org/b/46297> test-webkitpy should test code in
WebKit2/Scripts
Reviewed by Adam Barth.
- Scripts/test-webkitpy:
(_clean_packages_with_test): Renamed from _clean_webkitpy_with_test.
Now takes an external_package_paths parameter and cleans both webkitpy
and any external packages.
(init): Added an external_package_paths parameter which we pass along
to _clean_packages_with_test.
(top level): Add WebKit2/Scripts/webkit2 as our only external package
and pass it along to init and Tester.run_tests.
- Scripts/webkitpy/test/main.py:
(Tester.run_tests): Added an optional external_package_paths
parameter. We modify sys.path so that the external packages can be
imported, and search for unittest files inside all external packages
in addition to inside webkitpy.
- 1:43 PM Changeset in webkit [68079] by
-
- 13 edits11 adds1 delete in trunk/WebKit2
Autogenerate WebPage's message-receiving code and message types
This patch encompasses several changes that allow message types and
receiving code to be generated by a script, and add some type-safety
as a bonus. Messages are now represented by structs instead of an ID +
ArgumentCoder. The struct contains the arguments and the ID together,
and has a constructor that enforces the use of correct types.
Correspondingly, a new overload of WebProcessProxy::send that takes a
message struct (instead of a message ID and separate arguments) has
been added. Eventually all callers should use this overload and the
old one can be removed.
This patch only touches WebPage's messages. We should transition other
message receivers over to this new system eventually.
Fixes <http://webkit.org/b/43636> <rdar://problem/8282462> Add a
type-safe IPC mechanism to WebKit2
Reviewed by Anders Carlsson.
- DerivedSources.make: Added. Calls generate-message-receiver.py and
generate-messages-header.py for each message receiver it knows about
(just WebPage for now).
- Platform/CoreIPC/Arguments.h: Added First/Second/ThirdArgumentType
typedefs for use in handleMessage.
- Platform/CoreIPC/HandleMessage.h: Added.
(CoreIPC::handleMessage): This overloaded function template decodes
arguments and passes them along to the specified function.
- Scripts/generate-message-receiver.py: Added.
- Scripts/generate-messages-header.py: Added.
These scripts just wrap functionality in messages.py.
- Scripts/webkit2/init.py: Added. This just exists so that Python
will treat this directory as a package.
- Scripts/webkit2/messages.py: Added. Contains the code to parse
messages files and generate .cpp/.h files from them.
(MessageReceiver.init): This class represents a single receiver of
messages.
(MessageReceiver.iterparameters): Returns a generator that can be used
to iterate over all the parameters of all the messages of this
receiver.
(MessageReceiver.parse): Reads a messages file from a file-like object
and parses it into a MessageReceiver object.
(Message.init): This class represents a single message.
(Message.id): Returns the ID name for this message.
(Parameter.init): This class represents a single parameter for a
message.
(messages_header_filename): Returns the name of the header that
defines the messages for a given receiver.
(surround_in_condition): Surrounds the given string in #if/#endif if
there is an associated condition.
(messages_to_kind_enum): Returns a string that defines the Kind enum
for these messages.
(function_parameter_type): Returns the type that should be used when
passing a value of the given type as a parameter to a function.
(base_class): Returns the base class for a message struct.
(message_to_struct_declaration): Returns a string that declares the
struct for this message.
(forward_declarations_for_namespace): Returns a string that contains
forward-declarations for a set of types in a given namespace.
(forward_declarations): Returns a string that contains all the
forward-declarations needed in order to declare all the message
structs for this receiver.
(generate_header_file): Returns a string containing the messages
header file for this receiver.
(handler_function): Returns the name of the function that handles a
given message for a given receiver.
(case_statement): Returns a string containing a case statement for
handling the given message.
(header_for_type): Returns the header needed to define a given type,
enclosed in quotes or angle brackets as needed.
(generate_message_handler): Returns a string containing the contents
of a .cpp file that defines a didReceive*Message function.
- Scripts/webkit2/messages_unittest.py: Added. Contains tests for
messages.py.
- Shared/CoreIPCSupport/WebPageMessageKinds.h: Removed. This has been
replaced by a generated WebPageMessages.h header.
- UIProcess/WebEditCommandProxy.cpp:
- UIProcess/WebPageProxy.cpp:
Updated to use the new message structs and WebProcessProxy::send
overload.
- UIProcess/WebProcessProxy.h:
(WebKit::WebProcessProxy::send): Added this new overload that takes a
message struct.
- WebKit2.xcodeproj/project.pbxproj: Added a Derived Sources shell
script target that invokes DerivedSources.make. Added "Derived
Sources" and "Scripts" groups that contain the various new files.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::didReceivePolicyDecision):
(WebKit::WebPage::getSourceForFrame):
Changed these functions to take the raw IPC types and do the necessary
translation themselves. This keeps the generated code from need to
know how to perform the translation.
(WebKit::WebPage::didReceiveMessage): Replaced handling of WebPage
messages with a call to didReceiveWebPageMessage, whose implementation
is generated by the scripts.
- WebProcess/WebPage/WebPage.h: Added didReceiveWebPageMessage.
- WebProcess/WebPage/WebPage.messages.in: Added. This file declares
all of the messages that WebPage receives, roughly grouped by
functionality.
- win/WebKit2.vcproj: Added "Derived Sources" and "Scripts" filters
that contain the various new files. Let VS resort some other files.
- win/WebKit2Common.vsprops: Added
$(WebKitOutputDir)\obj\$(ProjectName)\DerivedSources to the include
path so that the generated messages header can be found.
- win/WebKit2.make: Copy the generated source files to $(DSTROOT).
- win/WebKit2Generated.make: Added a call to build-generated-files.sh.
- win/WebKit2Generated.vcproj: Added build-generated-files.sh.
- win/build-generated-files.sh: Added. Invokes DerivedSources.make.
- 1:43 PM Changeset in webkit [68078] by
-
- 15 edits in trunk
2010-09-22 Mario Sanchez Prada <msanchez@igalia.com>
Reviewed by Martin Robinson.
[Gtk] object:text-changed events should be emitted for entries and password text
https://bugs.webkit.org/show_bug.cgi?id=25898
Implement proper 'text-changed' signal emission for the GTK port
Call deleteTextFromNode() when needed while removing text nodes.
Do it even when removeNode() is going to be called afterwards, in
order to allow accessibility to get properly notified about the
text being removed alongside with that node.
- editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::handleGeneralDelete):
New function in AXObjectCache to call when text changes in a node.
Added one new function to allow notifying something changed in a
text node through the associated RenderObject, making such a
function dependant on the platform-specific implementation,
provided through a protected function (provided a proper
implementation for the GTK port and a dummy one for the others).
- accessibility/AXObjectCache.cpp: (WebCore::AXObjectCache::nodeTextChangeNotification): New
- accessibility/AXObjectCache.h: (WebCore::AXObjectCache::AXTextChange): New enumeration (WebCore::AXObjectCache::nodeTextChangeNotification): New (WebCore::AXObjectCache::nodeTextChangePlatformNotification): New
- accessibility/AccessibilityRenderObject.h: (WebCore::toAccessibilityRenderObject):
- accessibility/chromium/AXObjectCacheChromium.cpp: (WebCore::AXObjectCache::nodeTextChangePlatformNotification): New
- accessibility/gtk/AXObjectCacheAtk.cpp: (WebCore::emitTextChanged): (WebCore::AXObjectCache::nodeTextChangePlatformNotification): New
- accessibility/mac/AXObjectCacheMac.mm: (WebCore::AXObjectCache::nodeTextChangePlatformNotification): New
- accessibility/win/AXObjectCacheWin.cpp: (WebCore::AXObjectCache::nodeTextChangePlatformNotification): New
Notify accessibility when something changes in a text node.
Call to AXObjectCache::nodeTextChangeNotification() to notify when
text was inserted/deleted when applying/unapplying a text edition
command, along with the offset in the original text where the
change took place and the number of characters that got affected.
- editing/AppendNodeCommand.cpp: (WebCore::sendAXTextChangedIgnoringLineBreaks): (WebCore::AppendNodeCommand::doApply): (WebCore::AppendNodeCommand::doUnapply):
- editing/DeleteFromTextNodeCommand.cpp: (WebCore::DeleteFromTextNodeCommand::doApply): (WebCore::DeleteFromTextNodeCommand::doUnapply):
- editing/InsertIntoTextNodeCommand.cpp: (WebCore::InsertIntoTextNodeCommand::doApply): (WebCore::InsertIntoTextNodeCommand::doUnapply):
- editing/InsertNodeBeforeCommand.cpp: (WebCore::InsertNodeBeforeCommand::doApply): (WebCore::InsertNodeBeforeCommand::doUnapply): (WebCore::DeleteSelectionCommand::handleGeneralDelete):
2010-09-22 Mario Sanchez Prada <msanchez@igalia.com>
Reviewed by Martin Robinson.
[Gtk] object:text-changed events should be emitted for entries and password text
https://bugs.webkit.org/show_bug.cgi?id=25898
New unit test to make sure text-changed signals are emitted
- tests/testatk.c: (textChangedCb): New. Signal handler for the text-changed::insert and text-changed::delete signals. (checkTextChangesAndBailOut): New. Source function to check the global result of the test and quit from the main loop. (testWebkitAtkTextChangedNotifications): New test. (main):
- 1:27 PM Changeset in webkit [68077] by
-
- 3 edits in trunk/WebCore
https://bugs.webkit.org/show_bug.cgi?id=46298, add logicalWidth/Height getters/setters to RenderBox.
Reviewed by Dan Bernstein.
- rendering/RenderBox.cpp:
(WebCore::RenderBox::logicalWidth):
(WebCore::RenderBox::logicalHeight):
(WebCore::RenderBox::setLogicalWidth):
(WebCore::RenderBox::setLogicalHeight):
- rendering/RenderBox.h:
- 1:24 PM Changeset in webkit [68076] by
-
- 2 edits in trunk/JavaScriptCore
2010-09-22 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
[INTERPRETER] Two tests fail with SputnikError: #1.1: if argArray is neither an array nor an arguments object (see 10.1.8), a TypeError exception is thrown
https://bugs.webkit.org/show_bug.cgi?id=44245
Remove incorrect code from op_load_varargs in the interpreter.
- interpreter/Interpreter.cpp: (JSC::Interpreter::privateExecute):
- 1:14 PM Changeset in webkit [68075] by
-
- 10 edits in trunk/WebKit2
Enhance ProcessLauncher to be able to launch plug-in processes
https://bugs.webkit.org/show_bug.cgi?id=46295
Reviewed by Darin Adler.
- UIProcess/Launcher/ProcessLauncher.cpp:
(WebKit::ProcessLauncher::ProcessLauncher):
Make the ProcessLauncher constructor take a LaunchOptions struct.
(WebKit::ProcessLauncher::processTypeAsString):
Given a process type, return its string representation.
(WebKit::ProcessLauncher::getProcessTypeFromString):
And vice versa.
- UIProcess/Launcher/mac/ProcessLauncherMac.mm:
(WebKit::ProcessLauncher::launchProcess):
Rename "mode" to "type" and pass the type as a string based on the LaunchOptions struct.
Also, set the launch architecture from the LaunchOptions struct.
- UIProcess/Launcher/win/ProcessLauncherWin.cpp:
(WebKit::ProcessLauncher::launchProcess):
Rename "mode" to "type."
- UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::connect):
Initialize a LaunchOptions struct.
- WebProcess/WebKitMain.cpp:
(WebKitMain):
Factor code that can be shared between the mac and windows WebKitMain code out into a
WebKitMain overload that takes a CommandLine.
- WebProcess/WebProcessMain.h:
- WebProcess/mac/WebProcessMainMac.mm:
(WebKit::WebProcessMain):
- WebProcess/win/WebProcessMainWin.cpp:
(WebKit::WebProcessMain):
Change WebProcessMain to take a const CommandLine reference instead of a pointer.
- 12:46 PM Changeset in webkit [68074] by
-
- 5 edits in trunk/WebCore
2010-09-22 Luiz Agostini <luiz.agostini@openbossa.org>
Reviewed by Oliver Hunt.
Script engine agnostic ScriptCallback class
https://bugs.webkit.org/show_bug.cgi?id=43216
Refactoring class ScriptFunctionCall to create a class (ScriptCallback) that
receives a script function as a ScriptValue and calls that function with provided parameters.
- bindings/js/ScriptFunctionCall.cpp: (WebCore::ScriptCallArgumentHandler::appendArgument): (WebCore::ScriptFunctionCall::ScriptFunctionCall): (WebCore::ScriptCallback::ScriptCallback): (WebCore::ScriptCallback::call):
- bindings/js/ScriptFunctionCall.h: (WebCore::ScriptCallArgumentHandler::ScriptCallArgumentHandler):
- bindings/v8/ScriptFunctionCall.cpp: (WebCore::ScriptCallArgumentHandler::appendArgument): (WebCore::ScriptFunctionCall::ScriptFunctionCall): (WebCore::ScriptCallback::ScriptCallback): (WebCore::ScriptCallback::call):
- bindings/v8/ScriptFunctionCall.h: (WebCore::ScriptCallArgumentHandler::ScriptCallArgumentHandler):
- 12:38 PM Changeset in webkit [68073] by
-
- 2 edits in trunk/WebKitTools
2010-09-22 Dirk Pranke <dpranke@chromium.org>
Reviewed by Tony Chang.
new-run-webkit-tests: r68063 broke linux python tests
Add a missing "from future import with_statement" to this
new file; the perils of testing only on the Mac and by review :(
- Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
- 12:38 PM Changeset in webkit [68072] by
-
- 2 edits in trunk/WebCore
Unreviewed.
Build fix for invalid assertion after r68059.
- editing/ApplyStyleCommand.cpp:
(WebCore::getPropertiesNotIn): Correct assertion target after
name change.
- 12:37 PM Changeset in webkit [68071] by
-
- 5 edits in trunk/LayoutTests
2010-09-22 Abhishek Arya <inferno@chromium.org>
Unreviewed.
Rebaseline multicol/span tests for GTK, QT platforms as part of r68062.
- platform/gtk/fast/multicol/span/span-as-immediate-child-property-removal-expected.txt:
- platform/gtk/fast/multicol/span/span-as-immediate-columns-child-removal-expected.txt:
- platform/qt/fast/multicol/span/span-as-immediate-child-property-removal-expected.txt:
- platform/qt/fast/multicol/span/span-as-immediate-columns-child-removal-expected.txt:
- 12:37 PM Changeset in webkit [68070] by
-
- 5 edits in trunk/WebKit2
Rename GetPluginHostConnection to GetPluginPath
https://bugs.webkit.org/show_bug.cgi?id=46292
Reviewed by Adam Roben.
Rename GetPluginHostConnection to GetPluginPath since this message will always get the
plug-in path. We'll add another message to actually get the connection.
- Shared/CoreIPCSupport/WebProcessProxyMessageKinds.h:
- UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::getPluginPath):
(WebKit::WebProcessProxy::didReceiveMessage):
(WebKit::WebProcessProxy::didReceiveSyncMessage):
- UIProcess/WebProcessProxy.h:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::createPlugin):
- 12:35 PM Changeset in webkit [68069] by
-
- 5 edits in trunk
https://bugs.webkit.org/show_bug.cgi?id=45957, fix regression in column rules stacking test.
Reviewed by Simon Fraser.
WebCore:
Rewrite how the pagination bit gets set in RenderLayers, since it was totally broken and not
accounting for whether or not the columns block was even in the layer's containing block
hierarchy.
- rendering/RenderLayer.cpp:
(WebCore::checkContainingBlockChainForPagination):
(WebCore::RenderLayer::updatePagination):
LayoutTests:
- platform/mac/fast/multicol/column-rules-stacking-expected.checksum:
- platform/mac/fast/multicol/column-rules-stacking-expected.png:
- 12:29 PM Changeset in webkit [68068] by
-
- 2 edits in trunk/WebKit/chromium
2010-09-22 Kenneth Russell <kbr@google.com>
Unreviewed, Chromium build fix. Fix build when accelerated
compositing is not enabled at compile time.
- src/WebViewImpl.cpp: (WebKit::WebViewImpl::resize):
- 12:18 PM Changeset in webkit [68067] by
-
- 2 edits in trunk
2010-09-22 No'am Rosenthal <noam.rosenthal@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Move the accelerated compositing build flag to the right place
https://bugs.webkit.org/show_bug.cgi?id=43882
- WebKit.pri: Removed the redundant version check.
- 12:17 PM Changeset in webkit [68066] by
-
- 2 edits in trunk/WebCore
Unreviewed.
[WinCairo] Build fix for platform/cairo stuff after r67981.
- WebCore.vcproj/WebCore.vcproj: Add new files needed by all cairo
ports.
- 12:12 PM Changeset in webkit [68065] by
-
- 4 edits in trunk/WebKit2
Move plug-in creation to WebPage::createPlugin
https://bugs.webkit.org/show_bug.cgi?id=46289
Reviewed by Adam Roben.
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::createPlugin):
Call WebPage::createPlugin.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::createPlugin):
Create the plug-in.
- 12:11 PM Changeset in webkit [68064] by
-
- 2 edits in trunk/WebCore
2010-09-22 Erik Arvidsson <arv@chromium.org>
Reviewed by Nate Chapin.
[Chromium] Fix memory model for dataset
https://bugs.webkit.org/show_bug.cgi?id=46280
This is covered by existing tests.
- bindings/v8/custom/V8DOMStringMapCustom.cpp: (WebCore::toV8):
- 12:06 PM Changeset in webkit [68063] by
-
- 8 edits10 adds in trunk
2010-09-22 Dirk Pranke <dpranke@chromium.org>
Reviewed by Tony Chang.
Adds platform/chromium-gpu-* directories for holding the
GPU-accelerated baselines and expectations for Chromium.
- platform/chromium-gpu/test_expectations.txt: Added.
- platform/chromium-gpu-mac/README.txt: Added.
- platform/chromium-gpu-win/README.txt: Added.
- platform/chromium-gpu-linux/README.txt: Added.
2010-09-22 Dirk Pranke <dpranke@chromium.org>
Reviewed by Tony Chang.
Add a 'chromium-gpu' set of ports that will test the accelerated
GPU paths. This patch adds:
- support for the '--accelerated-compositing' and 'accelerated-2d-canvas' flags to new-run-webkit-tests (and the 'no-' flags)
- adds a new set of Ports that will look under platform/chromium-gpu-$OS/ for baselines before looking in the regular chromium search path
- adds a new test_expectations.txt file in platform/chromium-gpu that skips all but the tests we actually want to run with acceleration.
This patch will allow us to run both with and without acceleration
and to change the defaults for both the regular and -gpu options
as the code evolves.
We plan to add both --chromium-$OS and --chromium-gpu-$OS runs to
each test bot.
- Scripts/webkitpy/layout_tests/port/chromium.py:
- Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
- Scripts/webkitpy/layout_tests/port/factory.py:
- Scripts/webkitpy/layout_tests/port/webkit.py:
- 12:03 PM Changeset in webkit [68062] by
-
- 9 edits4 adds in trunk
2010-09-22 Abhishek Arya <inferno@chromium.org>
Reviewed by Dave Hyatt.
Fix wrong casts for table cell since its parent is not a RenderBlock. Remove
the redundant destroy call for empty anonymous columns or column span block.
https://bugs.webkit.org/show_bug.cgi?id=46245
Tests: fast/table/table-anonymous-block-destroy-crash.html
fast/table/table-columns-blocks-calc-crash.html
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::addChildToAnonymousColumnBlocks): (WebCore::RenderBlock::columnsBlockForSpanningElement): (WebCore::RenderBlock::removeChild):
2010-09-22 Abhishek Arya <inferno@chromium.org>
Reviewed by Dave Hyatt.
Tests that removing an anonymous block from a table cell does not result in crash.
Also, tests that calculating columns block for a table cell does not result in crash.
Rebaseline existing multicol span tests since we don't explicitly remove an empty
anonymous columns or column span blocks.
https://bugs.webkit.org/show_bug.cgi?id=46245
- fast/table/table-anonymous-block-destroy-crash-expected.txt: Added.
- fast/table/table-anonymous-block-destroy-crash.html: Added.
- fast/table/table-columns-blocks-calc-crash-expected.txt: Added.
- fast/table/table-columns-blocks-calc-crash.html: Added.
- platform/mac/fast/multicol/span/span-as-immediate-child-property-removal-expected.checksum:
- platform/mac/fast/multicol/span/span-as-immediate-child-property-removal-expected.png:
- platform/mac/fast/multicol/span/span-as-immediate-child-property-removal-expected.txt:
- platform/mac/fast/multicol/span/span-as-immediate-columns-child-removal-expected.checksum:
- platform/mac/fast/multicol/span/span-as-immediate-columns-child-removal-expected.png:
- platform/mac/fast/multicol/span/span-as-immediate-columns-child-removal-expected.txt:
- 11:59 AM Changeset in webkit [68061] by
-
- 12 edits in trunk
2010-09-22 Matt Perry <mpcomplete@chromium.org>
Reviewed by Darin Fisher.
Trying to reland a version of r67749:
Have V8DOMWindowShell ask the embedder whether to run a V8 extension
in a particular script context.
https://bugs.webkit.org/show_bug.cgi?id=45721
- bindings/v8/V8DOMWindowShell.cpp: (WebCore::V8DOMWindowShell::createNewContext):
- bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::registerExtension):
- bindings/v8/V8Proxy.h:
- loader/EmptyClients.h: (WebCore::EmptyFrameLoaderClient::allowScriptExtension):
- loader/FrameLoaderClient.h:
2010-09-22 Matt Perry <mpcomplete@chromium.org>
Reviewed by Darin Fisher.
Trying to reland a version of r67749:
Have V8DOMWindowShell ask the embedder whether to run a V8 extension
in a particular script context.
https://bugs.webkit.org/show_bug.cgi?id=45721
- public/WebFrameClient.h: (WebKit::WebFrameClient::allowScriptExtension):
- public/WebScriptController.h:
- src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::allowScriptExtension):
- src/FrameLoaderClientImpl.h:
- src/WebScriptController.cpp: (WebKit::WebScriptController::registerExtension):
- 11:59 AM Changeset in webkit [68060] by
-
- 5 edits in trunk
2010-09-22 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
[JIT] fast/js/sputnik/Conformance/15_Native_Objects/15.3_Function/15.3.5/S15.3.5.3_A2_T6.html fails
https://bugs.webkit.org/show_bug.cgi?id=44246
JIT code generated for instanceof was not checking to ensure that the prototype property was
an object, this patch ensures that it does.
- jit/JITOpcodes.cpp: (JSC::JIT::emit_op_instanceof): (JSC::JIT::emitSlow_op_instanceof):
- jit/JITOpcodes32_64.cpp: (JSC::JIT::emit_op_instanceof): (JSC::JIT::emitSlow_op_instanceof):
2010-09-22 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
[JIT] fast/js/sputnik/Conformance/15_Native_Objects/15.3_Function/15.3.5/S15.3.5.3_A2_T6.html fails
https://bugs.webkit.org/show_bug.cgi?id=44246
Correct expected output from this test.
- fast/js/sputnik/Conformance/15_Native_Objects/15.3_Function/15.3.5/S15.3.5.3_A2_T6-expected.txt:
- 11:30 AM Changeset in webkit [68059] by
-
- 7 edits2 adds in trunk
2010-09-22 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Darin Adler.
queryCommandState returns false for Underline command when no selection is made
https://bugs.webkit.org/show_bug.cgi?id=17594
The bug was caused by selectionComputedStyle's adding -webkit-text-decorations-in-effect property
to a dummy span used to obtain the computed style when there is a typing style.
Since this property is for internal use only, the CSS parser always stripped the property.
As a result, we were always ignoring the text decorations set by the typing style.
Fixed the bug by making selectionComputedStyle directly merge the computed style of the current
caret position and the typing style. This also eliminates the need for a dummy span element.
Due to the merge, the return value of selectionComputedStyle had to be changed to CSSMutableStyleDeclaration
from CSSComputedStyleDeclaration.
Test: editing/execCommand/query-text-decoration-with-typing-style.html
- editing/ApplyStyleCommand.cpp: (WebCore::StyleChange::init): Calls getPropertiesNotIn. (WebCore::getPropertiesNotIn): Renamed from getPropertiesNotInComputedStyle since it takes CSSStyleDeclaration* instead of CSSComputedStyleDeclaration* for the second argument. (WebCore::ApplyStyleCommand::removeNonEditingProperties): Extracted from editingStyleAtPosition. (WebCore::ApplyStyleCommand::editingStyleAtPosition): Calls removeNonEditingProperties.
- editing/ApplyStyleCommand.h:
- editing/Editor.cpp: (WebCore::triStateOfStyle): Calls getPropertiesNotIn. Renamed from triStateOfStyleInComputedStyle since it no longer takes CSSComputedStyleDeclaration. (WebCore::Editor::selectionStartHasStyle): Calls selectionComputedStyle and triStateOfStyle. (WebCore::Editor::selectionHasStyle): Ditto. (WebCore::Editor::selectionStartCSSPropertyValue): Calls selectionComputedStyle. (WebCore::Editor::selectionComputedStyle): See above.
- editing/Editor.h:
- editing/EditorCommand.cpp: (WebCore::executeToggleStyleInList): Calls selectionComputedStyle.
2010-09-22 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Darin Adler.
queryCommandState returns false for Underline command when no selection is made
https://bugs.webkit.org/show_bug.cgi?id=17594
Added a test to ensure queryCommandValue('underline') and queryCommandValue('strikeThrough')
correctly incorporates the typing style.
- editing/execCommand/query-text-decoration-with-typing-style-expected.txt: Added.
- editing/execCommand/query-text-decoration-with-typing-style.html: Added.
- 11:14 AM Changeset in webkit [68058] by
-
- 6 edits in trunk/WebKit2
Random plug-in cleanups
https://bugs.webkit.org/show_bug.cgi?id=46279
Reviewed by Darin Adler.
- WebProcess/Plugins/Plugin.cpp:
(WebKit::Plugin::Parameters::encode):
(WebKit::Plugin::Parameters::decode):
Add CoreIPC coding support for the Plugin::Parameters struct.
- WebProcess/Plugins/PluginController.h:
Add pluginProcessCrashed pure virtual member function.
- WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::handleEvent):
handleEvent can be called when m_plugin is null.
(WebKit::PluginView::pluginProcessCrashed):
Ask the renderer to show the crashed plug-in indicator.
- 10:48 AM Changeset in webkit [68057] by
-
- 2 edits in trunk/WebKit2
Don't listen for some window notifications on all windows
https://bugs.webkit.org/show_bug.cgi?id=46277
Reviewed by John Sullivan.
Only listen for NSWindowDidBecomeKeyNotification and NSWindowDidResignKeyNotification notifications
on all windows; this matches old WebKit and fixes a crash where we would send notifications to views whose
underlying pages were invalid.
- UIProcess/API/mac/WKView.mm:
(-[WKView addWindowObserversForWindow:]):
(-[WKView removeWindowObservers]):
- 10:33 AM Changeset in webkit [68056] by
-
- 14 edits2 adds in trunk
2010-09-22 Jamey Hicks <jamey.hicks@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Web Inspector: Remote Web Inspector support for QtWebKit
https://bugs.webkit.org/show_bug.cgi?id=43988
Runs a web debug server on port specified by QtTestBrowser
argument -remote-inspector-port. Property
_q_webInspectorServerPort of the QWebPage instance will be set
according to the argument. All pages with that property set will
be remotely inspectable.
URL for remote inspection of first QWebPage is
http://localhost:9222/webkit/inspector/inspector.html?page=1
where 1 is the number of the QWebPage instance.
The base URL yields an index page with links to the individual inspectors:
- WebCore.pro
2010-09-22 Jamey Hicks <jamey.hicks@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Web Inspector: Remote Web Inspector support for QtWebKit
https://bugs.webkit.org/show_bug.cgi?id=43988
Runs a web debug server on port specified by QtTestBrowser
argument -remote-inspector-port. Property
_q_webInspectorServerPort of the QWebPage instance will be set
according to the argument. All pages with that property set will
be remotely inspectable.
URL for remote inspection of first QWebPage is
http://localhost:9222/webkit/inspector/inspector.html?page=1
where 1 is the number of the QWebPage instance.
The base URL yields an index page with links to the individual inspectors:
- Api/qwebinspector.cpp: (QWebInspectorPrivate::attachAndReplaceRemoteFrontend): (QWebInspectorPrivate::detachRemoteFrontend):
- Api/qwebinspector_p.h: (QWebInspectorPrivate::QWebInspectorPrivate):
- Api/qwebpage.cpp: (QWebPagePrivate::dynamicPropertyChangeEvent): (QWebPagePrivate::inspectorServerPort):
- Api/qwebpage.h:
- Api/qwebpage_p.h:
- WebCoreSupport/InspectorClientQt.cpp: (WebCore::InspectorClientQt::InspectorClientQt): (WebCore::InspectorClientQt::inspectorDestroyed): (WebCore::InspectorClientQt::openInspectorFrontend): (WebCore::InspectorClientQt::attachAndReplaceRemoteFrontend): (WebCore::InspectorClientQt::detachRemoteFrontend): (WebCore::InspectorClientQt::sendMessageToFrontend):
- WebCoreSupport/InspectorClientQt.h:
- WebCoreSupport/InspectorServerQt.cpp: Added. (WebCore::generateWebSocketChallengeResponse): (WebCore::parseWebSocketChallengeNumber): (WebCore::InspectorServerQt::server): (WebCore::InspectorServerQt::InspectorServerQt): (WebCore::InspectorServerQt::~InspectorServerQt): (WebCore::InspectorServerQt::listen): (WebCore::InspectorServerQt::close): (WebCore::InspectorServerQt::inspectorClientForPage): (WebCore::InspectorServerQt::registerClient): (WebCore::InspectorServerQt::unregisterClient): (WebCore::InspectorServerQt::newConnection): (WebCore::InspectorServerRequestHandlerQt::InspectorServerRequestHandlerQt): (WebCore::InspectorServerRequestHandlerQt::~InspectorServerRequestHandlerQt): (WebCore::InspectorServerRequestHandlerQt::tcpReadyRead): (WebCore::InspectorServerRequestHandlerQt::tcpConnectionDisconnected): (WebCore::InspectorServerRequestHandlerQt::webSocketSend): (WebCore::InspectorServerRequestHandlerQt::webSocketReadyRead): (WebCore::RemoteFrontendChannel::RemoteFrontendChannel): (WebCore::RemoteFrontendChannel::sendMessageToFrontend):
- WebCoreSupport/InspectorServerQt.h: Added.
2010-09-22 Jamey Hicks <jamey.hicks@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Web Inspector: Remote Web Inspector support for QtWebKit
https://bugs.webkit.org/show_bug.cgi?id=43988
Runs a web debug server on port specified by QtTestBrowser
argument -remote-inspector-port. Property
_q_webInspectorServerPort of the QWebPage instance will be set
according to the argument. All pages with that property set will
be remotely inspectable.
URL for remote inspection of first QWebPage is
http://localhost:9222/webkit/inspector/inspector.html?page=1
where 1 is the number of the QWebPage instance.
The base URL yields an index page with links to the individual inspectors:
- QtTestBrowser/launcherwindow.cpp: (LauncherWindow::init):
- QtTestBrowser/launcherwindow.h:
- QtTestBrowser/main.cpp: (LauncherApplication::handleUserOptions):
- 10:28 AM Changeset in webkit [68055] by
-
- 2 edits in trunk/JavaScriptCore
2010-09-22 Patrick Gansterer <Patrick Gansterer>
Reviewed by Darin Adler.
Inline UTF8SequenceLength
https://bugs.webkit.org/show_bug.cgi?id=45589
- wtf/unicode/UTF8.cpp: (WTF::Unicode::convertUTF8ToUTF16): Use inline version of UTF8SequenceLength to improve performance.
- 10:26 AM Changeset in webkit [68054] by
-
- 18 edits in trunk
2010-09-21 Darin Adler <Darin Adler>
Reviewed by Anders Carlsson.
Fix some Objective-C GC problems and use RetainPtr instead of HardRetain/Release
https://bugs.webkit.org/show_bug.cgi?id=46220
- Misc/WebNSFileManagerExtras.m: (setMetaData): Use CFRelease instead of HardRelease. (-[NSFileManager _webkit_setMetadataURL:referrer:atPath:]): Use CFStringCreateCopy instead of -[NSObject copy] combined with HardRetainWithNSRelease.
2010-09-21 Darin Adler <Darin Adler>
Reviewed by Anders Carlsson.
Fix some Objective-C GC problems and use RetainPtr instead of HardRetain/Release
https://bugs.webkit.org/show_bug.cgi?id=46220
- WebCore.exp.in: Updated.
- bindings/objc/ObjCEventListener.h: Use a RetainPtr for m_listener, since that will do a CFRetain, which is right for GC rather than an -[NSObject retain], which is not.
- bindings/objc/ObjCEventListener.mm: (WebCore::ObjCEventListener::ObjCEventListener): Removed explicit retain. (WebCore::ObjCEventListener::~ObjCEventListener): Removed explicit release and added get(). (WebCore::ObjCEventListener::handleEvent): Added get();
- bridge/objc/objc_instance.mm: (ObjcInstance::setGlobalException): Use copy/release instead of HardRetain/HardRelease. (ObjcInstance::moveGlobalExceptionToExecState): Ditto.
- platform/Cursor.h: Use RetainPtr for PlatformCursor on Mac.
- platform/Cursor.cpp: (WebCore::Cursor::platformCursor): Moved this to CursorMac for the Mac.
- platform/Widget.cpp: Removed retain/releasePlatformWidget and made them both inlines in the header file.
- platform/Widget.h: Fixed includes and added an include of RetainPtr. Made platformWidget and setPlatformWidget non-inline on the Mac platform. Made releasePlatformWidget and retainPlatformWidget empty inline functions for non-GTK platforms.
- platform/graphics/mac/ImageMac.mm: Removed unneeded FoundationExtras.h include.
- platform/mac/ClipboardMac.mm: (WebCore::cocoaTypeFromHTMLClipboardType): use RetainPtr for the return type. (WebCore::ClipboardMac::clearData): Use RetainPtr. (WebCore::ClipboardMac::getData): Ditto. (WebCore::ClipboardMac::setData): Ditto.
- platform/mac/CursorMac.mm: (WebCore::createCustomCursor): Use RetainPtr for the return type. (WebCore::Cursor::ensurePlatformCursor): Removed all the calls to HardRetain since m_platformCursor is now a RetainPtr. (WebCore::Cursor::Cursor): Ditto. (WebCore::Cursor::operator=): Ditto. Also HardRelease. (WebCore::Cursor::~Cursor): Ditto. (WebCore::Cursor::platformCursor): Use get here.
- platform/mac/FoundationExtras.h: Removed all the functions except for HardAutorelease. Later we can remove that one too.
- platform/mac/ThemeMac.mm: (WebCore::setUpButtonCell): Changed this function to have a return value. Otherwise we end up taking a pointer (actually a reference) to a global variable, which does not do the right thing for GC. (WebCore::nonDefaultButton): Added. (WebCore::defaultButton): Added. (WebCore::button): Changed to call two separate functions with two separate global variables to avoid the problem with pointers to globals.
- platform/mac/WidgetMac.mm: (WebCore::Widget::~Widget): Removed unneeded call to releasePlatformWidget. (WebCore::Widget::platformWidget): Non-inline so we can comipile the header plain non-Objective-C C++. (WebCore::Widget::setPlatformWidget): Ditto.
- platform/network/mac/WebCoreURLResponse.mm: (mimeTypeFromUTITree): Use RetainPtr for the return type. (-[NSURLResponse adjustMIMETypeIfNecessary]): Use RetainPtr.
- 10:18 AM Changeset in webkit [68053] by
-
- 3 edits in trunk/WebKitTools
Fix webkit-patch failure-reason now that build.webkit.org has been updated
Fixes <http://webkit.org/b/46273> webkit-patch failure-reason crashes
every time
Reviewed by Eric Seidel.
- Scripts/webkitpy/common/net/buildbot.py:
(BuildBot._file_cell_text): Added. Travels down the firstChild chain
looking for an element that contains text, then returns it.
(BuildBot._parse_twisted_file_row): Use _file_cell_text to get the
text out of the cells. This way it doesn't matter whether the cells
have <b> children (as for cells in directory rows) or not (as for
cells in file rows)
(BuildBot._parse_twisted_directory_listing): Look for rows that have
the "directory" or "file" class, rather than rows with any class,
since header rows now have a class attribute.
- Scripts/webkitpy/common/net/buildbot_unittest.py:
(BuildBotTest._example_directory_listing): Updated to more closely
match the markup that build.webkit.org is producing now.
- 10:00 AM Changeset in webkit [68052] by
-
- 3 edits in trunk/WebKit2
Crash when running plug-in layout tests
https://bugs.webkit.org/show_bug.cgi?id=46269
Reviewed by Adam Roben.
Store the web page directly in the PluginView class, instead of getting it from the frame
of the plug-in element; this fixes two crashes, one where the plug-in element had been deallocated
before the plug-in view, and another where the plug-in element's document did not have a frame.
This also makes things more robust since we're asserting in the WebPage destructor that no plug-ins have
an outstanding reference to it.
- WebProcess/Plugins/PluginView.cpp:
(WebKit::webPage):
(WebKit::PluginView::PluginView):
(WebKit::PluginView::~PluginView):
(WebKit::PluginView::initializePlugin):
- WebProcess/Plugins/PluginView.h:
- 9:57 AM Changeset in webkit [68051] by
-
- 7 edits in trunk/WebKit/chromium
2010-09-22 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Darin Fisher.
[Chromium] Change WebKit API for IDBTransaciton to new style
https://bugs.webkit.org/show_bug.cgi?id=46263
- public/WebIDBIndex.h: (WebKit::WebIDBIndex::openObjectCursor): (WebKit::WebIDBIndex::openCursor): (WebKit::WebIDBIndex::getObject): (WebKit::WebIDBIndex::get):
- public/WebIDBObjectStore.h: (WebKit::WebIDBObjectStore::get): (WebKit::WebIDBObjectStore::put): (WebKit::WebIDBObjectStore::remove): (WebKit::WebIDBObjectStore::openCursor):
- src/WebIDBIndexImpl.cpp: (WebKit::WebIDBIndexImpl::openCursor): (WebKit::WebIDBIndexImpl::openObjectCursor): (WebKit::WebIDBIndexImpl::getObject): (WebKit::WebIDBIndexImpl::get):
- src/WebIDBIndexImpl.h:
- src/WebIDBObjectStoreImpl.cpp: (WebKit::WebIDBObjectStoreImpl::get): (WebKit::WebIDBObjectStoreImpl::put): (WebKit::WebIDBObjectStoreImpl::remove): (WebKit::WebIDBObjectStoreImpl::openCursor):
- src/WebIDBObjectStoreImpl.h:
- 9:25 AM Changeset in webkit [68050] by
-
- 2 edits in trunk/WebCore
2010-09-22 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[GTK] r68027 caused many crashes on the bots
https://bugs.webkit.org/show_bug.cgi?id=46268
Add the appropriate OwnPtrCairo.h include which has the OwnPtr
specialization for Cairo paths. Without it, we will have memory
corruption.
- platform/graphics/cairo/PathCairo.cpp: Add OwnPtrCairo.h include.
- 9:06 AM Changeset in webkit [68049] by
-
- 16 edits in trunk
2010-09-22 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: implement pausing on XHR
https://bugs.webkit.org/show_bug.cgi?id=46086
- bindings/v8/custom/V8XMLHttpRequestCustom.cpp: (WebCore::V8XMLHttpRequest::sendCallback):
- inspector/Inspector.idl:
- inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController): (WebCore::InspectorController::setNativeBreakpoint): (WebCore::InspectorController::removeNativeBreakpoint): (WebCore::InspectorController::willInsertDOMNodeImpl): (WebCore::InspectorController::willRemoveDOMNodeImpl): (WebCore::InspectorController::willModifyDOMAttrImpl): (WebCore::InspectorController::instrumentWillSendXMLHttpRequestImpl):
- inspector/InspectorController.h: (WebCore::InspectorController::instrumentWillSendXMLHttpRequest): (WebCore::InspectorController::inspectorControllerForScriptExecutionContext): (WebCore::InspectorController::inspectorControllerForNode): (WebCore::InspectorController::inspectorControllerForDocument):
- inspector/InspectorDebuggerAgent.cpp: (WebCore::InspectorDebuggerAgent::InspectorDebuggerAgent): (WebCore::InspectorDebuggerAgent::didPause): (WebCore::InspectorDebuggerAgent::breakProgram):
- inspector/InspectorDebuggerAgent.h:
- inspector/InspectorTimelineAgent.h:
- inspector/front-end/CallStackSidebarPane.js: (WebInspector.CallStackSidebarPane.prototype.updateStatus):
- inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel): (WebInspector.ElementsPanel.prototype.reset):
- inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeElement.prototype._populateTagContextMenu):
- inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel): (WebInspector.ScriptsPanel.prototype.debuggerPaused): (WebInspector.ScriptsPanel.prototype.reset):
- inspector/front-end/Settings.js:
- xml/XMLHttpRequest.h: (WebCore::XMLHttpRequest::url):
2010-09-22 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: implement pausing on XHR
https://bugs.webkit.org/show_bug.cgi?id=46086
- src/js/DevTools.js: ():
- 8:57 AM Changeset in webkit [68048] by
-
- 9 edits in trunk/WebKit2
Change a bunch of Vector<char> to Vector<uint8_t> to better indicate that we're
dealing with raw bytes.
Reviewed by Adam Roben.
- WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:
(WebKit::parsePostBuffer):
(WebKit::NPN_GetURL):
(WebKit::NPN_PostURL):
(WebKit::NPN_GetURLNotify):
(WebKit::NPN_PostURLNotify):
- WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
(WebKit::NetscapePlugin::loadURL):
(WebKit::NetscapePlugin::initialize):
- WebProcess/Plugins/Netscape/NetscapePlugin.h:
- WebProcess/Plugins/Netscape/NetscapePluginStream.cpp:
(WebKit::NetscapePluginStream::deliverData):
(WebKit::NetscapePluginStream::deliverDataToPlugin):
- WebProcess/Plugins/Netscape/NetscapePluginStream.h:
- WebProcess/Plugins/PluginController.h:
- WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::loadURL):
- WebProcess/Plugins/PluginView.h:
- 8:46 AM Changeset in webkit [68047] by
-
- 6 edits in trunk/WebKit/chromium
2010-09-21 Brett Wilson <brettw@chromium.org>
Reviewed by Darin Fisher.
Add caps log and num lock toggle state to WebInputEvent.
https://bugs.webkit.org/show_bug.cgi?id=46229
- public/WebInputEvent.h:
- src/WebViewImpl.cpp: (WebKit::WebViewImpl::handleInputEvent):
- src/WebViewImpl.h:
- src/gtk/WebInputEventFactory.cpp: (WebKit::gdkStateToWebEventModifiers):
- src/win/WebInputEventFactory.cpp: (WebKit::SetToggleKeyState): (WebKit::WebInputEventFactory::keyboardEvent): (WebKit::WebInputEventFactory::mouseEvent): (WebKit::WebInputEventFactory::mouseWheelEvent):
- 8:37 AM Changeset in webkit [68046] by
-
- 2 edits in trunk/WebKit2
Assertion fails in [WKView _updateWindowFrame] when closing a WebKit2 window
https://bugs.webkit.org/show_bug.cgi?id=46264
<rdar://problem/8463534>
Reviewed by Adam Roben.
- UIProcess/API/mac/WKView.mm:
(-[WKView viewDidMoveToWindow]):
Only update window visibility and frame when we're moving to a window.
- 8:31 AM Changeset in webkit [68045] by
-
- 1 edit in trunk/WebCore/ChangeLog
2010-09-22 Kenneth Russell <kbr@google.com>
Reviewed by James Robinson.
Add local triangulation of cubic curve control points
https://bugs.webkit.org/show_bug.cgi?id=45252
Adding a localized triangulation algorithm which takes as input
the four control points of a cubic curve segment and provides both
triangles as well as the ability to walk the interior edges. The
latter will be used later to fill the interior of shapes bounded
by these cubic curves, quadratic curves and line segments.
- platform/graphics/gpu/LoopBlinnLocalTriangulator.cpp: Added. (WebCore::LoopBlinnLocalTriangulator::Triangle::contains): (WebCore::LoopBlinnLocalTriangulator::Triangle::nextVertex): (WebCore::LoopBlinnLocalTriangulator::Triangle::indexForVertex): (WebCore::LoopBlinnLocalTriangulator::Triangle::makeCounterClockwise): (WebCore::LoopBlinnLocalTriangulator::LoopBlinnLocalTriangulator): (WebCore::LoopBlinnLocalTriangulator::reset): (WebCore::LoopBlinnLocalTriangulator::triangulate): (WebCore::LoopBlinnLocalTriangulator::triangulateHelper): (WebCore::LoopBlinnLocalTriangulator::addTriangle): (WebCore::LoopBlinnLocalTriangulator::addInteriorVertex): (WebCore::LoopBlinnLocalTriangulator::isSharedEdge):
- platform/graphics/gpu/LoopBlinnLocalTriangulator.h: Added. (WebCore::LoopBlinnLocalTriangulator::Vertex::Vertex): (WebCore::LoopBlinnLocalTriangulator::Vertex::xyCoordinates): (WebCore::LoopBlinnLocalTriangulator::Vertex::klmCoordinates): (WebCore::LoopBlinnLocalTriangulator::Vertex::set): (WebCore::LoopBlinnLocalTriangulator::Vertex::end): (WebCore::LoopBlinnLocalTriangulator::Vertex::setEnd): (WebCore::LoopBlinnLocalTriangulator::Vertex::marked): (WebCore::LoopBlinnLocalTriangulator::Vertex::setMarked): (WebCore::LoopBlinnLocalTriangulator::Vertex::interior): (WebCore::LoopBlinnLocalTriangulator::Vertex::setInterior): (WebCore::LoopBlinnLocalTriangulator::Vertex::resetFlags): (WebCore::LoopBlinnLocalTriangulator::Triangle::Triangle): (WebCore::LoopBlinnLocalTriangulator::Triangle::getVertex): (WebCore::LoopBlinnLocalTriangulator::Triangle::setVertices): (WebCore::LoopBlinnLocalTriangulator::getVertex): (WebCore::LoopBlinnLocalTriangulator::numberOfTriangles): (WebCore::LoopBlinnLocalTriangulator::getTriangle): (WebCore::LoopBlinnLocalTriangulator::numberOfInteriorVertices): (WebCore::LoopBlinnLocalTriangulator::getInteriorVertex):
- 8:27 AM Changeset in webkit [68044] by
-
- 5 edits in trunk
2010-09-22 Lucas De Marchi <lucas.demarchi@profusion.mobi>
Unreviewed, EFL build fix.
- CMakeListsEfl.txt:
- platform/efl/ClipboardEfl.cpp: (WebCore::ClipboardEfl::ClipboardEfl):
2010-09-22 Lucas De Marchi <lucas.demarchi@profusion.mobi>
Unreviewed, EFL build fix.
- CMakeLists.txt:
- 8:18 AM Changeset in webkit [68043] by
-
- 2 edits in trunk/WebKit/gtk
2010-09-22 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
Added information about drop shadow improvements to the NEWS file.
- NEWS: Added information about drop shadow improvements.
- 8:03 AM Changeset in webkit [68042] by
-
- 2 edits in trunk/WebCore
2010-09-22 İsmail Dönmez <ismail@namtrac.org>
Reviewed by Andreas Kling.
[Qt] Build fix for WinCE
Add two missing stubs:
- privateBrowsingStateChanged(bool)
- bindingInstance()
- platform/qt/TemporaryLinkStubsQt.cpp: (PluginView::privateBrowsingStateChanged): (PluginView::bindingInstance):
- 8:01 AM Changeset in webkit [68041] by
-
- 3 edits in trunk/WebCore
2010-09-22 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[GTK] FontCustomPlatformData.cpp leaks FT_Faces
https://bugs.webkit.org/show_bug.cgi?id=16941
Attach lifetime of the FontCustomPlatformData FT_Face to the resulting cairo_font_face_t.
This will free the memory associated with the FT_Face once the cairo_font_face_t is
destroyed.
No new tests as functionality should not change.
- platform/graphics/cairo/FontCustomPlatformData.cpp: (WebCore::releaseCustomFontData): Moved this helper method to the top of the file and gave it a more descriptive name. (WebCore::FontCustomPlatformData::FontCustomPlatformData): Changed the constructor to take the FT_Face and the buffer, so to better encapsulate the creation of the cairo face. (WebCore::FontCustomPlatformData::~FontCustomPlatformData): Added a comment about the fate of the FT_Face to the destructor. (WebCore::createFontCustomPlatformData): Cleaned up the code here and moved some of the logic into the constructor.
- platform/graphics/cairo/FontCustomPlatformData.h: Updated method definitions.
- 7:40 AM Changeset in webkit [68040] by
-
- 13 edits in trunk/WebKit/gtk
2010-09-21 Xan Lopez <xlopez@igalia.com>
Reviewed by Martin Robinson.
[GTK] Fix transfer annotations for WebKitGTK+ static API
https://bugs.webkit.org/show_bug.cgi?id=46244
Deal with all the warnings related to transfer issues. Mostly the
problem was the transfer being missing, but there were also typos
in the function name or missing ':' at the end of the function
name in the gtk-doc.
- webkit/webkitdownload.cpp:
- webkit/webkitnetworkrequest.cpp:
- webkit/webkitnetworkresponse.cpp:
- webkit/webkitsecurityorigin.cpp:
- webkit/webkitwebdatabase.cpp:
- webkit/webkitwebdatasource.cpp:
- webkit/webkitwebframe.cpp:
- webkit/webkitwebhistoryitem.cpp:
- webkit/webkitwebinspector.cpp:
- webkit/webkitwebresource.cpp:
- webkit/webkitwebsettings.cpp:
- webkit/webkitwebview.cpp: (webkit_web_view_class_init): (webkit_web_view_get_main_frame):
- 7:25 AM Changeset in webkit [68039] by
-
- 6 edits in trunk
2010-09-22 Balazs Kelemen <kb@inf.u-szeged.hu>
Reviewed by Kenneth Rohde Christiansen.
[Qt] PluginStrategy implementation is broken
https://bugs.webkit.org/show_bug.cgi?id=46078
Remove the QWebPage* member from WebPlatformStrategies.
Get the originator QWebPage of the getPluginInfo call via
the Page* argument.
- Api/qwebpage.cpp: (QWebPagePrivate::QWebPagePrivate):
- WebCoreSupport/WebPlatformStrategies.cpp: (WebPlatformStrategies::initialize): (WebPlatformStrategies::WebPlatformStrategies): (WebPlatformStrategies::getPluginInfo): Use the ChromeClient for accessing the originator QWebPage.
- WebCoreSupport/WebPlatformStrategies.h:
2010-09-22 Balazs Kelemen <kb@inf.u-szeged.hu>
Reviewed by Kenneth Rohde Christiansen.
[Qt] PluginStrategy implementation is broken
https://bugs.webkit.org/show_bug.cgi?id=46078
- UIProcess/API/qt/qwkpage.cpp: (QWKPagePrivate::QWKPagePrivate): Initialize the WebPlatformStrategies at the UI side as well because we are using the LocalizationStrategy in the UI process. Added a FIXME since this should be fixed in the future.
- 7:17 AM Changeset in webkit [68038] by
-
- 12 edits in trunk
2010-09-22 Balazs Kelemen <kb@inf.u-szeged.hu>
Reviewed by Kenneth Rohde Christiansen.
PluginStrategy should satisfy the needs of Qt
https://bugs.webkit.org/show_bug.cgi?id=45857
No new functionality so no new tests.
- WebCoreSupport/WebPlatformStrategies.cpp: (WebPlatformStrategies::getPluginInfo):
- WebCoreSupport/WebPlatformStrategies.h:
2010-09-22 Balazs Kelemen <kb@inf.u-szeged.hu>
Reviewed by Kenneth Rohde Christiansen.
PluginStrategy should satisfy the needs of Qt
https://bugs.webkit.org/show_bug.cgi?id=45857
No new functionality so no new tests.
- WebCoreSupport/WebPlatformStrategies.h:
- WebCoreSupport/WebPlatformStrategies.mm: (WebPlatformStrategies::getPluginInfo):
2010-09-22 Balazs Kelemen <kb@inf.u-szeged.hu>
Reviewed by Kenneth Rohde Christiansen.
PluginStrategy should satisfy the needs of Qt
https://bugs.webkit.org/show_bug.cgi?id=45857
No new functionality so no new tests.
- plugins/PluginData.cpp: (WebCore::PluginData::initPlugins):
- plugins/PluginStrategy.h: Added a |const Page*| argument to getPluginInfo.
2010-09-22 Balazs Kelemen <kb@inf.u-szeged.hu>
Reviewed by Kenneth Rohde Christiansen.
PluginStrategy should satisfy the needs of Qt
https://bugs.webkit.org/show_bug.cgi?id=45857
No new functionality so no new tests.
- WebProcess/WebCoreSupport/WebPlatformStrategies.cpp: (WebKit::WebPlatformStrategies::getPluginInfo):
- WebProcess/WebCoreSupport/WebPlatformStrategies.h:
- 6:53 AM Changeset in webkit [68037] by
-
- 2 edits in trunk/WebKit/qt
2010-09-22 İsmail Dönmez <ismail@namtrac.org>
Reviewed by Andreas Kling.
[Qt] Buildfix for WinCE
- Api/DerivedSources.pro:
- 6:02 AM Changeset in webkit [68036] by
-
- 11 edits in trunk/WebCore
2010-09-22 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: Elements panel does not reflect changes to the text node values.
https://bugs.webkit.org/show_bug.cgi?id=46166
- dom/CharacterData.cpp: (WebCore::CharacterData::dispatchModifiedEvent):
- inspector/Inspector.idl:
- inspector/InspectorController.cpp: (WebCore::InspectorController::characterDataModifiedImpl):
- inspector/InspectorController.h: (WebCore::InspectorController::characterDataModified):
- inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::characterDataModified):
- inspector/InspectorDOMAgent.h: (WebCore::EventListenerInfo::EventListenerInfo): (WebCore::InspectorDOMAgent::create): (WebCore::InspectorDOMAgent::cast): (WebCore::InspectorDOMAgent::cssStore):
- inspector/front-end/DOMAgent.js: (WebInspector.DOMAgent.prototype._characterDataModified): (WebInspector.characterDataModified):
- inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel.prototype._characterDataModified):
- inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeElement.prototype._textNodeEditingCommitted):
- 5:10 AM Changeset in webkit [68035] by
-
- 2 edits in trunk/WebCore
[Qt] On Maemo platform, web style is missing for some inputs
https://bugs.webkit.org/show_bug.cgi?id=46182
Patch by Ragner Magalhaes <ragner.magalhaes@openbossa.org> on 2010-09-21
Reviewed by Kenneth Rohde Christiansen.
- css/themeQtMaemo5.css:
- 4:03 AM QtWebKitRelease20 edited by
- (diff)
- 3:31 AM WebKit Team edited by
- (diff)
- 3:26 AM Changeset in webkit [68034] by
-
- 1 edit4 adds in trunk/LayoutTests
2010-09-22 Adam Barth <abarth@webkit.org>
Reviewed by Alexey Proskuryakov.
REGRESSION: HTMLElement.localName returns lowercase, breaks Jira
https://bugs.webkit.org/show_bug.cgi?id=14114
Add tests from bug.
- fast/parser/localname-case-expected.txt: Added.
- fast/parser/localname-case-strict-expected.txt: Added.
- fast/parser/localname-case-strict.html: Added.
- fast/parser/localname-case.html: Added.
- 3:25 AM QtWebKitRelease20Deployment edited by
- (diff)
- 3:19 AM Changeset in webkit [68033] by
-
- 2 edits in trunk/WebCore
2010-09-22 Patrick Gansterer <Patrick Gansterer>
Unreviewed.
[WINCE] Build fix for ResourceHandleWin after r67291.
- platform/network/win/ResourceHandleWin.cpp: (WebCore::ResourceHandle::loadResourceSynchronously): Replace Frame* parameter with NetworkingContext*.
- 2:34 AM Changeset in webkit [68032] by
-
- 2 edits in trunk/WebKitSite
2010-09-22 Balazs Kelemen <kbalazs@webkit.org>
Unreviewed HTML syntax fix for my recent change in the coding-style.
- coding/coding-style.html: Change ">" and "<" to ">" and "<".
- 1:58 AM Changeset in webkit [68031] by
-
- 4 edits in trunk/WebCore
2010-09-22 Chris Guillory <chris.guillory@google.com>
Reviewed by Chris Fleizach.
Crash due to bad cast in AXObjectCacheChromium.cpp.
https://bugs.webkit.org/show_bug.cgi?id=46237
- accessibility/chromium/AXObjectCacheChromium.cpp: (WebCore::AXObjectCache::postPlatformNotification):
- page/ChromeClient.h: (WebCore::ChromeClient::postAccessibilityNotification): (WebCore::ChromeClient::didChangeAccessibilityObjectState): (WebCore::ChromeClient::didChangeAccessibilityObjectChildren):
- page/chromium/ChromeClientChromium.h:
- 1:55 AM Changeset in webkit [68030] by
-
- 2 edits in trunk/WebKitSite
2010-09-22 Balazs Kelemen <kb@inf.u-szeged.hu>
Reviewed by Darin Adler.
check-webkit-style and the coding style guidelines page are inconsistent
https://bugs.webkit.org/show_bug.cgi?id=46099
- coding/coding-style.html: Making clear that includes of system headers must come after includes of other headers.
- 1:45 AM QtWebKitRelease20 edited by
- (diff)
- 1:45 AM Changeset in webkit [68029] by
-
- 1 edit2 adds in trunk/WebCore
2010-09-22 Chris Rogers <crogers@google.com>
Reviewed by James Robinson.
Add HRTFElevation files
https://bugs.webkit.org/show_bug.cgi?id=45864
No new tests since audio API is not yet implemented.
- platform/audio/HRTFElevation.cpp: Added. (WebCore::HRTFElevation::calculateSymmetricKernelsForAzimuthElevation): (WebCore::HRTFElevation::calculateKernelsForAzimuthElevation): (WebCore::HRTFElevation::createForSubject): (WebCore::HRTFElevation::createByInterpolatingSlices): (WebCore::HRTFElevation::getKernelsFromAzimuth):
- platform/audio/HRTFElevation.h: Added. (WebCore::HRTFElevation::kernelListL): (WebCore::HRTFElevation::kernelListR): (WebCore::HRTFElevation::elevationAngle): (WebCore::HRTFElevation::numberOfAzimuths): (WebCore::HRTFElevation::sampleRate): (WebCore::HRTFElevation::HRTFElevation):
- 1:44 AM QtWebKitTableOfFeatures20 edited by
- (diff)
- 1:37 AM Changeset in webkit [68028] by
-
- 2 edits in trunk/WebKit/mac
2010-09-22 Paul Knight <pknight@apple.com>
Reviewed by Simon Fraser.
-[WebView _scheduleCompositingLayerSync] should wake the run loop
https://bugs.webkit.org/show_bug.cgi?id=46226
Call CFRunLoopWakeUp to make sure the run loop is not sleeping, which could delay layer painting.
- WebView/WebView.mm: (-[WebView _scheduleCompositingLayerSync]):
- 1:23 AM Changeset in webkit [68027] by
-
- 3 edits in trunk/WebCore
2010-09-22 Alejandro G. Castro <alex@igalia.com>
Reviewed by Martin Robinson.
[gtk] Use the smart pointers to handle cairo_path_t
https://bugs.webkit.org/show_bug.cgi?id=46212
Modified the code to use smart pointers with cairo_path_t
variables.
- platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::appendPathToCairoContext): (WebCore::GraphicsContext::clip): (WebCore::GraphicsContext::drawTiledShadow):
- platform/graphics/cairo/PathCairo.cpp: (WebCore::Path::Path): (WebCore::Path::operator=): (WebCore::Path::apply): (WebCore::Path::debugString):
- 1:11 AM Changeset in webkit [68026] by
-
- 1 edit1 add in trunk/WebCore
2010-09-22 Kwang Yul Seo <skyul@company100.net>
Reviewed by Kent Tamura.
[BREWMP] Implement Image::loadPlatformResource
https://bugs.webkit.org/show_bug.cgi?id=45873
Load images from the resource directory.
- platform/graphics/brew/ImageBrew.cpp: Added. (WebCore::Image::loadPlatformResource):
- 1:10 AM Changeset in webkit [68025] by
-
- 1 edit2 adds in trunk/WebCore
2010-09-22 Chris Rogers <crogers@google.com>
Reviewed by James Robinson.
Add HRTFKernel files
https://bugs.webkit.org/show_bug.cgi?id=45863
No new tests since audio API is not yet implemented.
- platform/audio/HRTFKernel.cpp: Added. (WebCore::extractAverageGroupDelay): (WebCore::HRTFKernel::HRTFKernel): (WebCore::HRTFKernel::createImpulseResponse): (WebCore::HRTFKernel::createInterpolatedKernel):
- platform/audio/HRTFKernel.h: Added. (WebCore::HRTFKernel::create): (WebCore::HRTFKernel::fftFrame): (WebCore::HRTFKernel::fftSize): (WebCore::HRTFKernel::frameDelay): (WebCore::HRTFKernel::sampleRate): (WebCore::HRTFKernel::nyquist): (WebCore::HRTFKernel::HRTFKernel):
- 1:09 AM Changeset in webkit [68024] by
-
- 4 edits2 adds in trunk
2010-09-22 Kent Tamura <tkent@chromium.org>
Reviewed by Chris Fleizach.
Support keyboard operations for <input type=range>.
https://bugs.webkit.org/show_bug.cgi?id=45803
- fast/forms/range-keyoperation-expected.txt: Added.
- fast/forms/range-keyoperation.html: Added.
2010-09-22 Kent Tamura <tkent@chromium.org>
Reviewed by Chris Fleizach.
Support keyboard operations for <input type=range>.
https://bugs.webkit.org/show_bug.cgi?id=45803
Increasing the value with Up/Right arrow keys by its step value,
and decreasing with Down/Left arrow keys. If an input element has
step=any attribute, increasing/decreasing by 1/100 of max-min.
Note: This change is not useful on Mac because users can't set
focus on range controls.
Test: fast/forms/range-keyoperation.html
- html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::defaultEventHandler): Calls handleKeyEventForRange() for RANGE and key events. (WebCore::HTMLInputElement::handleKeyEventForRange):
- html/HTMLInputElement.h: Add handleKeyEventForRange() declaration.
- 12:49 AM Changeset in webkit [68023] by
-
- 4 edits2 adds in trunk
2010-09-22 Mario Sanchez Prada <msanchez@igalia.com>
Reviewed by Chris Fleizach.
[Gtk] Incorrect exposure of list items whose children are elements
https://bugs.webkit.org/show_bug.cgi?id=45383
Check that list items will be always exposed like that for GTK
- platform/gtk/accessibility/list-items-always-exposed-expected.txt: Added.
- platform/gtk/accessibility/list-items-always-exposed.html: Added.
2010-09-22 Mario Sanchez Prada <msanchez@igalia.com>
Reviewed by Chris Fleizach.
[Gtk] Incorrect exposure of list items whose children are elements
https://bugs.webkit.org/show_bug.cgi?id=45383
Set ATK_ROLE_LIST_ITEM looking for the role of the parent object
Test: platform/gtk/accessibility/list-items-always-exposed.html
- accessibility/gtk/AccessibilityObjectAtk.cpp: (WebCore::AccessibilityObject::accessibilityPlatformIncludesObject): Always include objects with ListItemRole in accessibility for GTK.
- accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (getInterfaceMaskFromObject): Add some specific code to handle the special case of list markers by implementing AtkText when needed.
- 12:42 AM Changeset in webkit [68022] by
-
- 22 edits27 moves in trunk/WebCore
2010-09-22 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
Make FilterEffects independent of SVG
https://bugs.webkit.org/show_bug.cgi?id=46177
Moving all FilterEffects from svg/graphics/filters to platform/graphics/filters, now that they
are independent of SVG. Removed the SVG prefix of the files and updated the headers.
- Android.mk:
- CMakeLists.txt:
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- platform/graphics/filters/DistantLightSource.h: Copied from WebCore/svg/graphics/filters/SVGDistantLightSource.h.
- platform/graphics/filters/FEConvolveMatrix.cpp: Copied from WebCore/svg/graphics/filters/SVGFEConvolveMatrix.cpp.
- platform/graphics/filters/FEConvolveMatrix.h: Copied from WebCore/svg/graphics/filters/SVGFEConvolveMatrix.h.
- platform/graphics/filters/FEDiffuseLighting.cpp: Copied from WebCore/svg/graphics/filters/SVGFEDiffuseLighting.cpp.
- platform/graphics/filters/FEDiffuseLighting.h: Copied from WebCore/svg/graphics/filters/SVGFEDiffuseLighting.h.
- platform/graphics/filters/FEDisplacementMap.cpp: Copied from WebCore/svg/graphics/filters/SVGFEDisplacementMap.cpp.
- platform/graphics/filters/FEDisplacementMap.h: Copied from WebCore/svg/graphics/filters/SVGFEDisplacementMap.h.
- platform/graphics/filters/FEFlood.cpp: Copied from WebCore/svg/graphics/filters/SVGFEFlood.cpp.
- platform/graphics/filters/FEFlood.h: Copied from WebCore/svg/graphics/filters/SVGFEFlood.h.
- platform/graphics/filters/FELighting.cpp: Copied from WebCore/svg/graphics/filters/SVGFELighting.cpp.
- platform/graphics/filters/FELighting.h: Copied from WebCore/svg/graphics/filters/SVGFELighting.h.
- platform/graphics/filters/FEMerge.cpp: Copied from WebCore/svg/graphics/filters/SVGFEMerge.cpp.
- platform/graphics/filters/FEMerge.h: Copied from WebCore/svg/graphics/filters/SVGFEMerge.h.
- platform/graphics/filters/FEMorphology.cpp: Copied from WebCore/svg/graphics/filters/SVGFEMorphology.cpp.
- platform/graphics/filters/FEMorphology.h: Copied from WebCore/svg/graphics/filters/SVGFEMorphology.h.
- platform/graphics/filters/FEOffset.cpp: Copied from WebCore/svg/graphics/filters/SVGFEOffset.cpp.
- platform/graphics/filters/FEOffset.h: Copied from WebCore/svg/graphics/filters/SVGFEOffset.h.
- platform/graphics/filters/FESpecularLighting.cpp: Copied from WebCore/svg/graphics/filters/SVGFESpecularLighting.cpp.
- platform/graphics/filters/FESpecularLighting.h: Copied from WebCore/svg/graphics/filters/SVGFESpecularLighting.h.
- platform/graphics/filters/FETile.cpp: Copied from WebCore/svg/graphics/filters/SVGFETile.cpp.
- platform/graphics/filters/FETile.h: Copied from WebCore/svg/graphics/filters/SVGFETile.h.
- platform/graphics/filters/FETurbulence.cpp: Copied from WebCore/svg/graphics/filters/SVGFETurbulence.cpp.
- platform/graphics/filters/FETurbulence.h: Copied from WebCore/svg/graphics/filters/SVGFETurbulence.h.
- platform/graphics/filters/LightSource.cpp: Copied from WebCore/svg/graphics/filters/SVGLightSource.cpp.
- platform/graphics/filters/LightSource.h: Copied from WebCore/svg/graphics/filters/SVGLightSource.h.
- platform/graphics/filters/PointLightSource.h: Copied from WebCore/svg/graphics/filters/SVGPointLightSource.h.
- platform/graphics/filters/SpotLightSource.h: Copied from WebCore/svg/graphics/filters/SVGSpotLightSource.h.
- svg/SVGFEConvolveMatrixElement.h:
- svg/SVGFEDiffuseLightingElement.cpp:
- svg/SVGFEDisplacementMapElement.h:
- svg/SVGFEDistantLightElement.cpp:
- svg/SVGFEFloodElement.h:
- svg/SVGFELightElement.h:
- svg/SVGFEMergeElement.h:
- svg/SVGFEMorphologyElement.h:
- svg/SVGFEOffsetElement.h:
- svg/SVGFEPointLightElement.cpp:
- svg/SVGFESpecularLightingElement.h:
- svg/SVGFESpotLightElement.cpp:
- svg/SVGFETileElement.h:
- svg/SVGFETurbulenceElement.h:
- svg/graphics/filters/SVGDistantLightSource.h: Removed.
- svg/graphics/filters/SVGFEConvolveMatrix.cpp: Removed.
- svg/graphics/filters/SVGFEConvolveMatrix.h: Removed.
- svg/graphics/filters/SVGFEDiffuseLighting.cpp: Removed.
- svg/graphics/filters/SVGFEDiffuseLighting.h: Removed.
- svg/graphics/filters/SVGFEDisplacementMap.cpp: Removed.
- svg/graphics/filters/SVGFEDisplacementMap.h: Removed.
- svg/graphics/filters/SVGFEFlood.cpp: Removed.
- svg/graphics/filters/SVGFEFlood.h: Removed.
- svg/graphics/filters/SVGFELighting.cpp: Removed.
- svg/graphics/filters/SVGFELighting.h: Removed.
- svg/graphics/filters/SVGFEMerge.cpp: Removed.
- svg/graphics/filters/SVGFEMerge.h: Removed.
- svg/graphics/filters/SVGFEMorphology.cpp: Removed.
- svg/graphics/filters/SVGFEMorphology.h: Removed.
- svg/graphics/filters/SVGFEOffset.cpp: Removed.
- svg/graphics/filters/SVGFEOffset.h: Removed.
- svg/graphics/filters/SVGFESpecularLighting.cpp: Removed.
- svg/graphics/filters/SVGFESpecularLighting.h: Removed.
- svg/graphics/filters/SVGFETile.cpp: Removed.
- svg/graphics/filters/SVGFETile.h: Removed.
- svg/graphics/filters/SVGFETurbulence.cpp: Removed.
- svg/graphics/filters/SVGFETurbulence.h: Removed.
- svg/graphics/filters/SVGLightSource.cpp: Removed.
- svg/graphics/filters/SVGLightSource.h: Removed.
- svg/graphics/filters/SVGPointLightSource.h: Removed.
- svg/graphics/filters/SVGSpotLightSource.h: Removed.
- 12:40 AM Changeset in webkit [68021] by
-
- 1 edit3 adds in trunk/LayoutTests
2010-09-22 Michael Saboff <msaboff@apple.com>
Reviewed by Darin Adler.
New test for (BOL) anchored regular expressions. Some of the
tests inspired by https://bugs.webkit.org/show_bug.cgi?id=46049.
- fast/js/regexp-bol-expected.txt: Added.
- fast/js/regexp-bol.html: Added.
- fast/js/script-tests/regexp-bol.js: Added.
- 12:37 AM Changeset in webkit [68020] by
-
- 2 edits in trunk/WebCore
2010-09-22 Patrick Gansterer <Patrick Gansterer>
Reviewed by Adam Roben.
[WIN] Add internetHandle to WebCoreSynchronousLoader.
https://bugs.webkit.org/show_bug.cgi?id=46185
For loading content via network the WebCoreSynchronousLoader needs its own (synchronous) internetHandle.
This also adds asynchronousInternetHandle() to create a static asynchronous internetHandle.
- platform/network/win/ResourceHandleWin.cpp: (WebCore::createInternetHandle): (WebCore::asynchronousInternetHandle): (WebCore::WebCoreSynchronousLoader::internetHandle): (WebCore::WebCoreSynchronousLoader::WebCoreSynchronousLoader): Create synchronous internetHandle. (WebCore::WebCoreSynchronousLoader::~WebCoreSynchronousLoader): Delete synchronous internetHandle.
- 12:26 AM Changeset in webkit [68019] by
-
- 2 edits in trunk/WebCore
2010-09-22 Kwang Yul Seo <skyul@company100.net>
Reviewed by Chris Fleizach.
[chromium] Remove unused sys/types.h in VDMXParser.cpp
https://bugs.webkit.org/show_bug.cgi?id=46136
sys/types.h is not needed here.
- platform/graphics/chromium/VDMXParser.cpp:
- 12:25 AM Changeset in webkit [68018] by
-
- 2 edits in trunk/WebCore
2010-09-22 Kwang Yul Seo <skyul@company100.net>
Reviewed by Kent Tamura.
[BREWMP] Change the home directory path to the WebKit module directory
https://bugs.webkit.org/show_bug.cgi?id=45895
AEEFS_HOME_DIR denotes the currently running application's directory.
Change it to fs:/~<clsid> to use the WebKit module directory as home.
- platform/brew/FileSystemBrew.cpp: (WebCore::homeDirectoryPath):
- 12:12 AM Changeset in webkit [68017] by
-
- 1 edit1 add in trunk/WebCore
2010-09-22 Kwang Yul Seo <skyul@company100.net>
Reviewed by Kent Tamura.
[BREWMP] Add dummy Pasteboard
https://bugs.webkit.org/show_bug.cgi?id=46107
Pasteboard is not supported yet. Add dummy implementation to avoid link errors.
- platform/brew/PasteboardBrew.cpp: Added. (WebCore::Pasteboard::generalPasteboard): (WebCore::Pasteboard::Pasteboard): (WebCore::Pasteboard::clear): (WebCore::Pasteboard::writeSelection): (WebCore::Pasteboard::writePlainText): (WebCore::Pasteboard::writeURL): (WebCore::Pasteboard::writeImage): (WebCore::Pasteboard::canSmartReplace): (WebCore::Pasteboard::plainText): (WebCore::Pasteboard::documentFragment):
