Timeline



Sep 22, 2011:

11:59 PM Changeset in webkit [95786] by fpizlo@apple.com
  • 6 edits in trunk/Source/JavaScriptCore

GetScopedVar should have value profiling
​https://bugs.webkit.org/show_bug.cgi?id=68676

Reviewed by Oliver Hunt.

Added GetScopedVar value profiling and predictin propagation.
Added GetScopeChain to CSE.

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):

  • dfg/DFGGraph.h:

(JSC::DFG::Graph::predict):

  • dfg/DFGNode.h:

(JSC::DFG::Node::hasPrediction):

  • dfg/DFGPropagator.cpp:

(JSC::DFG::Propagator::propagateNodePredictions):
(JSC::DFG::Propagator::getScopeChainLoadElimination):
(JSC::DFG::Propagator::performNodeCSE):

  • jit/JITPropertyAccess.cpp:

(JSC::JIT::emit_op_get_scoped_var):

10:58 PM Changeset in webkit [95785] by Csaba Osztrogonác
  • 3 edits in trunk/LayoutTests

[Qt] Unreviewed gardening, update expected file after r95745.

  • platform/qt/editing/deleting/merge-whitespace-pre-expected.png:
  • platform/qt/editing/deleting/merge-whitespace-pre-expected.txt:
10:53 PM Changeset in webkit [95784] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

Unreviewed fix after r95764, update expected fail to expected pass.

  • ietestcenter/Javascript/15.3.4.5-0-2-expected.txt:
9:54 PM Changeset in webkit [95783] by tony@chromium.org
  • 5 edits
    3 adds in trunk

implement -webkit-flex-order
​https://bugs.webkit.org/show_bug.cgi?id=67432

Reviewed by Ojan Vafai.

Source/WebCore:

flex-order can be an int (including negative), but we disallow the two
smallest values so we can put the numbers into a hash set.

Also, create two iterators: one that goes in render tree order (we use
this for the first pass and to collect the possible flex order values)
and one that goes in flex order.

Test: css3/flexbox/flex-order.html

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):

  • rendering/RenderFlexibleBox.cpp:

(WebCore::FlexOrderHashTraits::emptyValue):
(WebCore::FlexOrderHashTraits::constructDeletedValue):
(WebCore::FlexOrderHashTraits::isDeletedValue):
(WebCore::RenderFlexibleBox::TreeOrderIterator::TreeOrderIterator): A simple iterator

that goes in render tree order.

(WebCore::RenderFlexibleBox::TreeOrderIterator::next):
(WebCore::RenderFlexibleBox::TreeOrderIterator::reset):
(WebCore::RenderFlexibleBox::TreeOrderIterator::flexOrderValues):
(WebCore::RenderFlexibleBox::FlexOrderIterator::FlexOrderIterator): An iterator that

goes in flex-order order. Creating this involves sorting, so only create it once
and pass it around.

(WebCore::RenderFlexibleBox::FlexOrderIterator::first):
(WebCore::RenderFlexibleBox::FlexOrderIterator::next):
(WebCore::RenderFlexibleBox::FlexOrderIterator::reset):
(WebCore::RenderFlexibleBox::layoutHorizontalBlock):
(WebCore::RenderFlexibleBox::computePreferredLogicalWidth):
(WebCore::RenderFlexibleBox::runFreeSpaceAllocationAlgorithmInlineDirection):
(WebCore::RenderFlexibleBox::layoutAndPlaceChildrenInlineDirection):

  • rendering/RenderFlexibleBox.h:

LayoutTests:

  • css3/flexbox/flex-order-expected.png: Added.
  • css3/flexbox/flex-order-expected.txt: Added.
  • css3/flexbox/flex-order.html: Added.
9:10 PM Changeset in webkit [95782] by Darin Adler
  • 2 edits in trunk/Source/WebCore

Use AffineTransform scale functions in ShadowBlur::adjustBlurRadius
​https://bugs.webkit.org/show_bug.cgi?id=68667

Reviewed by Simon Fraser.

  • platform/graphics/ShadowBlur.cpp:

(WebCore::ShadowBlur::adjustBlurRadius): Use AffineTransform::xScale and
AffineTransform::yScale instead of the custom code here that seems to do
the same thing.

9:00 PM Changeset in webkit [95781] by dpranke@chromium.org
  • 2 edits in trunk/Tools

enable NRWT for run-webkit-tests on Lion
​https://bugs.webkit.org/show_bug.cgi?id=68673

Reviewed by Eric Seidel.

  • Scripts/run-webkit-tests:

(useNewRunWebKitTests):

8:35 PM Changeset in webkit [95780] by commit-queue@webkit.org
  • 50 edits in trunk/LayoutTests

Rebaseline for bug 65583 (path based border radius drawing on skia) part 6
​https://bugs.webkit.org/show_bug.cgi?id=68671

Patch by Ben Wells <​benwells@chromium.org> on 2011-09-22
Reviewed by James Robinson.

  • platform/chromium-linux/tables/mozilla/marvin/: 9 changes
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/: 14 changes
  • platform/chromium-linux/transforms/svg-vs-css-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/: 9 changes
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/: 14 changes
  • platform/chromium-win/transforms/svg-vs-css-expected.png:
  • platform/chromium/test_expectations.txt:
8:27 PM Changeset in webkit [95779] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

PPC build fix, part 3.

  • runtime/Executable.cpp:

(JSC::FunctionExecutable::compileForConstructInternal):

8:21 PM Changeset in webkit [95778] by Darin Adler
  • 2 edits in trunk/Source/WebCore

Remove unneeded type conversion from background bleed code
​https://bugs.webkit.org/show_bug.cgi?id=68669

Reviewed by Geoffrey Garen.

  • rendering/RenderBoxModelObject.cpp:

(WebCore::backgroundRectAdjustedForBleedAvoidance): Use ceil instead of ceilf
and eliminate superflous conversion to float and use of FloatSize. Also added
a "why" comment.

8:00 PM Changeset in webkit [95777] by Darin Adler
  • 6 edits in trunk/Source/WebCore

Refactor checks for antialiasing lines to share a single function
​https://bugs.webkit.org/show_bug.cgi?id=68666

Reviewed by Dan Bernstein.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::paintColumnRules): Call shouldAntialiasLines.

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::paintBorder): Ditto.
(WebCore::RenderBoxModelObject::shouldAntialiasLines): Added.

  • rendering/RenderBoxModelObject.h: Added shouldAntialiasLines function.
  • rendering/RenderInline.cpp:

(WebCore::RenderInline::paintOutlineForLine): Call shouldAntialiasLines.

  • rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::paintCollapsedBorder): Ditto.

7:41 PM Changeset in webkit [95776] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Remove unused members from LayerChromium.
These members are never set, and never used.
Other members that are set but not used have been left (we may use them
later, e.g. m_opaque).
​https://bugs.webkit.org/show_bug.cgi?id=68297

Patch by Antoine Labour <​piman@chromium.org> on 2011-09-22
Reviewed by James Robinson.

No functional change, no new test needed.

  • platform/graphics/chromium/LayerChromium.cpp:

(WebCore::LayerChromium::LayerChromium):

  • platform/graphics/chromium/LayerChromium.h:
7:40 PM Changeset in webkit [95775] by annacc@chromium.org
  • 2 edits in trunk/LayoutTests

Adding testTracks() function to video-test.js
​https://bugs.webkit.org/show_bug.cgi?id=68643

Reviewed by Eric Carlson.

  • media/video-test.js:

(testTracks):

7:28 PM Changeset in webkit [95774] by commit-queue@webkit.org
  • 5 edits
    6 adds in trunk

Make XSSAuditor extract meaningful snippet from script blocks for comparison
against the URL when checking for reflection. Avoids getting caugh up in
trailing comments.
​https://bugs.webkit.org/show_bug.cgi?id=68094

Patch by Tom Sepez <​tsepez@chromium.org> on 2011-09-22
Reviewed by Adam Barth.

Source/WebCore:

Tests: http/tests/security/xssAuditor/script-tag-with-trailing-comment.html

http/tests/security/xssAuditor/script-tag-with-trailing-comment2.html
http/tests/security/xssAuditor/script-tag-with-trailing-comment3.html

  • html/parser/XSSAuditor.cpp:

(WebCore::XSSAuditor::filterTokenAfterScriptStartTag):
(WebCore::XSSAuditor::extractCodeFragment):

  • html/parser/XSSAuditor.h:

LayoutTests:

  • http/tests/security/xssAuditor/resources/echo-intertag.pl:
  • http/tests/security/xssAuditor/script-tag-with-trailing-comment-expected.txt: Added.
  • http/tests/security/xssAuditor/script-tag-with-trailing-comment.html: Added.
  • http/tests/security/xssAuditor/script-tag-with-trailing-comment2-expected.txt: Added.
  • http/tests/security/xssAuditor/script-tag-with-trailing-comment2.html: Added.
  • http/tests/security/xssAuditor/script-tag-with-trailing-comment3-expected.txt: Added.
  • http/tests/security/xssAuditor/script-tag-with-trailing-comment3.html: Added.
7:27 PM Changeset in webkit [95773] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[Qt] TouchWebView load test not running
​https://bugs.webkit.org/show_bug.cgi?id=68620

Patch by Gopal Raghavan <​gopal.1.raghavan@nokia.com> on 2011-09-22
Reviewed by Chang Shu.

Load test was not executed since it was missing in pro file. Added tst_load.qml to qmltests.pro

  • UIProcess/API/qt/tests/qmltests/qmltests.pro:
7:16 PM Changeset in webkit [95772] by fpizlo@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Another PPC build fix.

  • runtime/Executable.cpp:
  • runtime/Executable.h:
6:56 PM Changeset in webkit [95771] by commit-queue@webkit.org
  • 55 edits
    2 moves
    1 add in trunk/LayoutTests

Rebaseline for bug 65583 (path based border radius drawing on skia) part 5
​https://bugs.webkit.org/show_bug.cgi?id=68608

Patch by Ben Wells <​benwells@chromium.org> on 2011-09-22
Reviewed by James Robinson.

  • platform/chromium-linux/css2.1/: 14 changes
  • platform/chromium-linux/editing/execCommand/5138441-expected.png:
  • platform/chromium-linux/editing/inserting/editing-empty-divs-expected.png:
  • platform/chromium-linux/editing/selection/transformed-selection-rects-expected.png:
  • platform/chromium-linux/fast/: 9 changes
  • platform/chromium-win/css2.1/: 14 changes
  • platform/chromium-win/editing/execCommand/5138441-expected.png:
  • platform/chromium-win/editing/inserting/editing-empty-divs-expected.png:
  • platform/chromium-win/editing/selection/transformed-selection-rects-expected.png:
  • platform/chromium-win/fast/: 10 changes
  • platform/chromium/test_expectations.txt:
  • platform/win-xp/editing/selection/transformed-selection-rects-expected.txt: Renamed from LayoutTests/platform/win-wk2/editing/selection/transformed-selection-rects-expected.txt.
  • platform/win/editing/selection/transformed-selection-rects-expected.txt: Renamed from LayoutTests/platform/chromium-win/editing/selection/transformed-selection-rects-expected.txt.
6:42 PM Changeset in webkit [95770] by commit-queue@webkit.org
  • 3 edits
    1 add in trunk/Tools

Add unit test for existing StringBuilder
​https://bugs.webkit.org/show_bug.cgi?id=67080

Patch by Xianzhu Wang <​wangxianzhu@chromium.org> on 2011-09-22
Reviewed by Darin Adler.

  • TestWebKitAPI/TestWebKitAPI.gypi:
  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WTF/StringBuilder.cpp: Added.

(operator<<):
(TestWebKitAPI::expectBuilderContent):
(TestWebKitAPI::expectEmpty):
(TestWebKitAPI::TEST):

6:33 PM WebKit Team edited by dino@apple.com
Moving me around (diff)
6:33 PM AddingFeatures created by dino@apple.com
Figured it was worth documenting how to add a feature
6:29 PM Changeset in webkit [95769] by dslomov@google.com
  • 2 edits in trunk/LayoutTests

Updated expectations and filed WK68674.

  • platform/chromium/test_expectations.txt:
6:21 PM WikiStart edited by dino@apple.com
Adding link to new ENABLE page (diff)
6:12 PM Changeset in webkit [95768] by Nate Chapin
  • 16 edits in trunk/Source/WebCore

Remove didReceiveAuthenticationChallenge() from SubresourceLoaderClient.
Instead, add a load-specific policy for showing the user authentication
challenge down to ResourceLoaderOptions and enforce it in ResourceLoader.
​https://bugs.webkit.org/show_bug.cgi?id=65330

Reviewed by Alexey Proskuryakov.

No new tests, refactor only.

  • loader/DocumentThreadableLoader.cpp:
  • loader/DocumentThreadableLoader.h:
  • loader/MainResourceLoader.cpp:
  • loader/NetscapePlugInStreamLoader.cpp:
  • loader/ResourceLoadScheduler.h:
  • loader/ResourceLoader.cpp:

(WebCore::ResourceLoader::didReceiveAuthenticationChallenge):

For resource types that always send a challenge to the embedder,
this patch doesn't change anything. For those that don't, we will
always try to continue without credentials when they are forbidden
and the platform supports it.
When continuing without credentials was initially implemented in
DocumentThreadableLoader, we sent the ThreadableLoaderClient a didFail(),
then canceled the SubresourceLoader. This was necessary because of the
quirks of ThreadableLoader cancellation (we sever the client/loader connections
before the load actually cancels), but a simple didFail() should suffice at
the ResourceLoader layer.

  • loader/ResourceLoaderOptions.h:
  • loader/SubresourceLoader.cpp:
  • loader/SubresourceLoader.h:
  • loader/SubresourceLoaderClient.h:
  • loader/cache/CachedResource.cpp:
  • loader/cache/CachedResourceLoader.cpp:
  • loader/cache/CachedResourceLoader.h:
  • loader/icon/IconLoader.cpp: The ResourceLoader implementation of

didReceiveAuthenticationChallege means that IconLoader will now
try to continue with credentials on platforms that support it,
rather than just canceling outright. We still will never prompt
for authentication for icons.

  • loader/icon/IconLoader.h:
5:43 PM Changeset in webkit [95767] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[EFL] Use ewk_view to navigate in history instead of ewk_history.
​https://bugs.webkit.org/show_bug.cgi?id=68455

Patch by Raphael Kubo da Costa <​kubo@profusion.mobi> on 2011-09-22
Reviewed by Antonio Gomes.

BackForwardItem::invoke() was using ewk_history functions to navigate
in history; however, this will only call WebCore::BackForwardListImpl
and not move between pages at all. We now call ewk_view_navigate and
its siblings to make sure the navigation actually happens.

This should make tests like fast/dom/navigation-type-back-forward.html
stop timing out.

  • DumpRenderTree/efl/WorkQueueItemEfl.cpp:

(BackForwardItem::invoke):

5:38 PM Changeset in webkit [95766] by dino@apple.com
  • 13 edits in trunk

Add ENABLE_CSS_FILTERS
​https://bugs.webkit.org/show_bug.cgi?id=68652

Reviewed by Simon Fraser.

  • Source/JavaScriptCore/Configurations/FeatureDefines.xcconfig:
  • Source/WebCore/Configurations/FeatureDefines.xcconfig:
  • Source/WebKit/mac/Configurations/FeatureDefines.xcconfig:
  • Source/WebKit2/Configurations/FeatureDefines.xcconfig:
  • WebKitLibraries/win/tools/vsprops/FeatureDefines.vsprops:
  • WebKitLibraries/win/tools/vsprops/FeatureDefinesCairo.vsprops:
  • Tools/Scripts/build-webkit:
5:02 PM Changeset in webkit [95765] by andersca@apple.com
  • 2 edits in trunk/Source/WebCore

Make sure to update scrollbars in ScrollView::setFrameRect
​https://bugs.webkit.org/show_bug.cgi?id=68663

Reviewed by Sam Weinig.

Call updateScrollbars after setting the frame rect. This was previously done by the
call to setBoundsSize from RenderWidget::setWidgetGeometry but setBoundsSize was removed
completely in ​http://trac.webkit.org/changeset/95725.

  • platform/ScrollView.cpp:

(WebCore::ScrollView::setFrameRect):

4:57 PM Changeset in webkit [95764] by barraclough@apple.com
  • 5 edits in trunk

Function.prototype.bind.length shoudl be 1.

Rubber stamped by Olier Hunt.

Source/JavaScriptCore:

  • runtime/FunctionPrototype.cpp:

(JSC::FunctionPrototype::addFunctionProperties):

LayoutTests:

  • fast/js/function-bind-expected.txt:
  • fast/js/script-tests/function-bind.js:
4:24 PM Changeset in webkit [95763] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

PPC build fix.

  • bytecode/CodeBlock.h:
4:22 PM Changeset in webkit [95762] by barraclough@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Windows build fix pt. 2

4:05 PM Changeset in webkit [95761] by barraclough@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Windows build fix pt. 1

3:58 PM Changeset in webkit [95760] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt][Mac]Unreviewed gardening.

New Qt specific results were added by r95723, but they fail on Qt-Mac platform

  • platform/qt-mac/Skipped: Skip css3/selectors3 tests.
3:49 PM Changeset in webkit [95759] by Simon Fraser
  • 11 edits
    1 copy
    1 add in trunk/Source/WebKit2

Add APIObjects for Size, Point, Rect
​https://bugs.webkit.org/show_bug.cgi?id=68644

Reviewed by Sam Weinig.

Make APIObjects for size, point and rect so that they can be
used in WKArrayRefs.

Make some inline helper methods to create WKSize, WKPoint and WKRect
types.

  • GNUmakefile.am:
  • Shared/API/c/WKBase.h:
  • Shared/API/c/WKGeometry.cpp: Copied from Source/WebKit2/Shared/API/c/WKGeometry.h.

(WKSizeGetTypeID):
(WKPointGetTypeID):
(WKRectGetTypeID):
(WKPointCreate):
(WKSizeCreate):
(WKRectCreate):
(WKSizeGetValue):
(WKPointGetValue):
(WKRectGetValue):

  • Shared/API/c/WKGeometry.h:

(WKPoint::WKPointMake):
(WKPoint::WKSizeMake):
(WKPoint::WKRectMake):

  • Shared/API/c/WKSharedAPICast.h:
  • Shared/APIObject.h:
  • Shared/UserMessageCoders.h:

(WebKit::UserMessageEncoder::baseEncode):
(WebKit::UserMessageDecoder::baseDecode):

  • Shared/WebGeometry.h: Added.

(WebKit::WebSize::create):
(WebKit::WebSize::size):
(WebKit::WebSize::WebSize):
(WebKit::WebSize::type):
(WebKit::WebPoint::create):
(WebKit::WebPoint::point):
(WebKit::WebPoint::WebPoint):
(WebKit::WebPoint::type):
(WebKit::WebRect::create):
(WebKit::WebRect::rect):
(WebKit::WebRect::WebRect):
(WebKit::WebRect::type):

  • WebKit2.pro:
  • WebKit2.xcodeproj/project.pbxproj:
  • WebKit2API.pri:
  • win/WebKit2.vcproj:
3:42 PM Changeset in webkit [95758] by fpizlo@apple.com
  • 13 edits in trunk/Source/JavaScriptCore

DFG JIT does not support to_primitive or strcat
​https://bugs.webkit.org/show_bug.cgi?id=68582

Reviewed by Darin Adler.

This adds functional support for to_primitive and strcat. It focuses
on minimizing the amount of code emitted on to_primitive (if we know
that it is a primitive or can speculate cheaply, then we omit the
slow path) and on keeping the implementation of strcat simple while
leveraging whatever optimizations we have already. In particular,
unlike the Call and Construct nodes which require extending the size
of the DFG's callee registers, StrCat takes advantage of the fact
that no JS code can run while StrCat is in progress and uses a
scratch buffer, rather than the register file, to store the list of
values to concatenate. This was done mainly to keep the code simple,
but there are probably other benefits to keeping call frame sizes
down. Essentially, this patch ensures that the presence of an
op_strcat does not mess up any other optimizations we might do while
ensuring that if you do execute it, it'll work about as well as you'd
expect.

When combined with the previous patch for integer division, this is a
14% speed-up on Kraken. Without it, it would have been a 2% loss.

  • assembler/AbstractMacroAssembler.h:

(JSC::AbstractMacroAssembler::TrustedImmPtr::TrustedImmPtr):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):

  • dfg/DFGCapabilities.h:

(JSC::DFG::canCompileOpcode):

  • dfg/DFGJITCodeGenerator.h:

(JSC::DFG::JITCodeGenerator::callOperation):

  • dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::exitSpeculativeWithOSR):

  • dfg/DFGNode.h:
  • dfg/DFGOperations.cpp:
  • dfg/DFGOperations.h:
  • dfg/DFGPropagator.cpp:

(JSC::DFG::Propagator::propagateNodePredictions):
(JSC::DFG::Propagator::performNodeCSE):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::JSGlobalData):
(JSC::JSGlobalData::~JSGlobalData):

  • runtime/JSGlobalData.h:

(JSC::JSGlobalData::scratchBufferForSize):

3:35 PM Changeset in webkit [95757] by jonlee@apple.com
  • 4 edits in trunk/Source/WebCore

Progress control gets cropped on the bottom
​https://bugs.webkit.org/show_bug.cgi?id=68302
<rdar://problem/10069915>

Reviewed by Kent Tamura.

As it turns out the smaller control type does not get rendered either, so this patch
fixes both.

  • manual-tests/dom/progressbar.html: Altered to show both sizes of controls
  • rendering/RenderThemeMac.h:
  • rendering/RenderThemeMac.mm: Added methods to inflate the drawing rect

(WebCore::RenderThemeMac::progressBarSizes):
(WebCore::RenderThemeMac::progressBarMargins):
(WebCore::RenderThemeMac::minimumProgressBarHeight):
(WebCore::RenderThemeMac::paintProgressBar): Inflate the rect based on minimum desired
control height and glow margin.

3:28 PM Changeset in webkit [95756] by hyatt@apple.com
  • 5 edits
    3 adds in trunk

​https://bugs.webkit.org/show_bug.cgi?id=68658

Make matchedEndLine smart enough to not match lines that have moved to new
regions with different available content logical widths. When this happens, we go ahead and treat
the line as failing to match.

Reviewed by Anders Carlsson.

Source/WebCore:

Added new tests in fast/regions.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::lineWidthForPaginatedLineChanged):

  • rendering/RenderBlock.h:

Enhanced to take an optional delta, so that you can check a new position without having to move
the line box.

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::checkPaginationAndFloatsAtEndLine):
New function that refactors checking for line width changes from region movement as well as the
float checks. Since the float checks were duplicated twice, this is a nice refactoring.

(WebCore::RenderBlock::matchedEndLine):
Changed to call the new helper function that will check both floats and pagination.

LayoutTests:

  • fast/regions/webkit-flow-inlines-dynamic.html: Added.
  • platform/mac/fast/regions/webkit-flow-inlines-dynamic-expected.png: Added.
  • platform/mac/fast/regions/webkit-flow-inlines-dynamic-expected.txt: Added.
3:13 PM Changeset in webkit [95755] by andersca@apple.com
  • 2 edits in trunk/Tools

EventSenderProxy::mouseUp should call -[WKView mouseUp:] instead of -[WKView mouseDown:]
​https://bugs.webkit.org/show_bug.cgi?id=68660

Reviewed by Adam Barth.

  • WebKitTestRunner/mac/EventSenderProxy.mm:

(WTR::EventSenderProxy::mouseUp):

3:02 PM Changeset in webkit [95754] by fpizlo@apple.com
  • 7 edits in trunk/Source/JavaScriptCore

DFG JIT should support integer division
​https://bugs.webkit.org/show_bug.cgi?id=68597

Reviewed by Darin Adler.

This adds support for ArithDiv speculating integer, and speculating
that the result is integer (i.e. remainder = 0).

This is a 4% win on Kraken and a 1% loss on V8.

  • bytecode/CodeBlock.h:
  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::makeDivSafe):
(JSC::DFG::ByteCodeParser::parseBlock):

  • dfg/DFGNode.h:

(JSC::DFG::Node::hasArithNodeFlags):

  • dfg/DFGPropagator.cpp:

(JSC::DFG::Propagator::propagateArithNodeFlags):
(JSC::DFG::Propagator::propagateNodePredictions):
(JSC::DFG::Propagator::fixupNode):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • jit/JITArithmetic.cpp:

(JSC::JIT::emit_op_div):

2:55 PM Changeset in webkit [95753] by oliver@apple.com
  • 6 edits in trunk/Source/JavaScriptCore

Implement put_scoped_var in the DFG jit
​https://bugs.webkit.org/show_bug.cgi?id=68653

Reviewed by Gavin Barraclough.

Naive implementation of put_scoped_var. Same story as the
get_scoped_var implementation, although I've hoisted scope
object acquisition into a separate dfg node. Ideally in the
future we would reuse the resolved scope chain object, but
for now we don't.

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):

  • dfg/DFGCapabilities.h:

(JSC::DFG::canCompileOpcode):

  • dfg/DFGNode.h:

(JSC::DFG::Node::hasScopeChainDepth):
(JSC::DFG::Node::scopeChainDepth):

  • dfg/DFGPropagator.cpp:

(JSC::DFG::Propagator::propagateNodePredictions):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compile):

2:43 PM Changeset in webkit [95752] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

Skip test that need new baselines.

  • platform/mac/Skipped:
2:22 PM Changeset in webkit [95751] by barraclough@apple.com
  • 58 edits
    5 adds in trunk

Implement Function.prototype.bind
​https://bugs.webkit.org/show_bug.cgi?id=26382

Reviewed by Sam Weinig.

Source/JavaScriptCore:

This patch provides a basic functional implementation
for Function.bind. It should (hopefully!) be fully
functionally correct, and the bound functions can be
called to quickly (since they are a subclass of
JSFunction, not InternalFunction), but we'll probably
want to follow up with some optimization work to keep
bound calls in JIT code.

(JSC::JITThunks::hostFunctionStub):

  • jit/JITStubs.h:
  • jsc.cpp:

(GlobalObject::addFunction):

  • runtime/CommonIdentifiers.h:
  • runtime/ConstructData.h:
  • runtime/Executable.h:

(JSC::NativeExecutable::NativeExecutable):

  • runtime/FunctionPrototype.cpp:

(JSC::FunctionPrototype::addFunctionProperties):
(JSC::functionProtoFuncBind):

  • runtime/FunctionPrototype.h:
  • runtime/JSBoundFunction.cpp: Added.

(JSC::boundFunctionCall):
(JSC::boundFunctionConstruct):
(JSC::JSBoundFunction::create):
(JSC::JSBoundFunction::hasInstance):
(JSC::JSBoundFunction::getOwnPropertySlot):
(JSC::JSBoundFunction::getOwnPropertyDescriptor):
(JSC::JSBoundFunction::JSBoundFunction):
(JSC::JSBoundFunction::finishCreation):

  • runtime/JSBoundFunction.h: Added.

(JSC::JSBoundFunction::targetFunction):
(JSC::JSBoundFunction::boundThis):
(JSC::JSBoundFunction::boundArgs):
(JSC::JSBoundFunction::createStructure):

  • runtime/JSFunction.cpp:

(JSC::JSFunction::create):
(JSC::JSFunction::finishCreation):
(JSC::createDescriptorForThrowingProperty):
(JSC::JSFunction::getOwnPropertySlot):

  • runtime/JSFunction.h:
  • runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::getHostFunction):

  • runtime/JSGlobalData.h:
  • runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::reset):
(JSC::JSGlobalObject::visitChildren):

  • runtime/JSGlobalObject.h:

(JSC::JSGlobalObject::boundFunctionStructure):

  • runtime/Lookup.cpp:

(JSC::setUpStaticFunctionSlot):

Source/WebCore:

Test: fast/js/function-bind.html

  • bindings/js/JSDOMBinding.cpp:

(WebCore::objectToStringFunctionGetter):

  • bindings/js/JSDOMWindowCustom.cpp:

(WebCore::nonCachingStaticFunctionGetter):

  • bindings/js/JSHistoryCustom.cpp:

(WebCore::nonCachingStaticBackFunctionGetter):
(WebCore::nonCachingStaticForwardFunctionGetter):
(WebCore::nonCachingStaticGoFunctionGetter):

  • bindings/js/JSLocationCustom.cpp:

(WebCore::nonCachingStaticReplaceFunctionGetter):
(WebCore::nonCachingStaticReloadFunctionGetter):
(WebCore::nonCachingStaticAssignFunctionGetter):

  • Function::create no longer requires functionStructure() to be passed.

LayoutTests:

We now pass Function.bind tests.

  • fast/js/Object-getOwnPropertyNames-expected.txt:
  • fast/js/basic-strict-mode-expected.txt:
  • fast/js/function-bind-expected.txt: Added.
  • fast/js/function-bind.html: Added.
  • fast/js/mozilla/strict/15.3.4.5-expected.txt:
  • fast/js/script-tests/function-bind.js: Added.
  • ietestcenter/Javascript/15.2.3.3-4-38-expected.txt:
  • ietestcenter/Javascript/15.3.4.5-0-1-expected.txt:
  • ietestcenter/Javascript/15.3.4.5-0-2-expected.txt:
  • ietestcenter/Javascript/15.3.4.5-13.b-1-expected.txt:
  • ietestcenter/Javascript/15.3.4.5-13.b-2-expected.txt:
  • ietestcenter/Javascript/15.3.4.5-13.b-3-expected.txt:
  • ietestcenter/Javascript/15.3.4.5-13.b-4-expected.txt:
  • ietestcenter/Javascript/15.3.4.5-13.b-5-expected.txt:
  • ietestcenter/Javascript/15.3.4.5-15-1-expected.txt:
  • ietestcenter/Javascript/15.3.4.5-15-2-expected.txt:
  • ietestcenter/Javascript/15.3.4.5-16-1-expected.txt:
  • ietestcenter/Javascript/15.3.4.5-2-1-expected.txt:
  • ietestcenter/Javascript/15.3.4.5-2-2-expected.txt:
  • ietestcenter/Javascript/15.3.4.5-2-3-expected.txt:
  • ietestcenter/Javascript/15.3.4.5-2-4-expected.txt:
  • ietestcenter/Javascript/15.3.4.5-2-5-expected.txt:
  • ietestcenter/Javascript/15.3.4.5-2-6-expected.txt:
  • ietestcenter/Javascript/15.3.4.5-2-7-expected.txt:
  • ietestcenter/Javascript/15.3.4.5-2-8-expected.txt:
  • ietestcenter/Javascript/15.3.4.5-2-9-expected.txt:
  • ietestcenter/Javascript/15.3.4.5-8-1-expected.txt:
  • ietestcenter/Javascript/15.3.4.5-8-2-expected.txt:
  • ietestcenter/Javascript/15.3.4.5-9-1-expected.txt:
  • ietestcenter/Javascript/15.3.4.5-9-2-expected.txt:
1:50 PM Changeset in webkit [95750] by hyatt@apple.com
  • 11 edits
    1 add
    1 delete in trunk

​https://bugs.webkit.org/show_bug.cgi?id=68650

Make determineStartPosition smart enough to not skip over clean lines that have moved to a new
region with a different available content logical width. When this happens, we go ahead and treat
the line as dirty.

Reviewed by Sam Weinig.

Source/WebCore:

Covered by existing fast/regions tests.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::layoutBlock):
Disable region fitting if we detect that the regions all have uniform widths. In this case we know
the content width can't vary, so there's no reason to waste time worrying about it.

(WebCore::RenderBlock::computeLogicalLocationForFloat):
Pull the content width checking code into computeLogicalLocationForFloat, since we've incorporated
region fitting into the fixed offsets now rather than the line functions.

(WebCore::RenderBlock::positionNewFloats):
Changed because more code moved from here into computeLogicalLocationForFloat.

(WebCore::RenderBlock::adjustForRegionFittingIfNeeded):
No changes. Just moved the function above the left offset function.

(WebCore::RenderBlock::logicalLeftOffsetForContent):
(WebCore::RenderBlock::logicalRightOffsetForContent):
Added. These new functions give the fixed left and right offsets for lines in a particular region.
When no regions are present or when all the regions have a uniform width, they are identical
to the versions of the functions that take no arguments.

(WebCore::RenderBlock::logicalRightOffsetForLine):
Changed to no longer do region fitting, since that's built into logicalRightOffsetForContent now.

(WebCore::RenderBlock::lineWidthForPaginatedLineChanged):
New function that takes a root line box and compares its cached old content width with the width
available at the line's new location.

  • rendering/RenderBlock.h:

(WebCore::RenderBlock::logicalRightOffsetForLine):
(WebCore::RenderBlock::logicalLeftOffsetForLine):
Modified to call the logicalXXXOffsetForContent functions that take a block direction position.

(WebCore::RenderBlock::logicalRightOffsetForContent):
(WebCore::RenderBlock::logicalLeftOffsetForContent):
Added the new functions that take a position so that they can fit to the correct region.

(WebCore::RenderBlock::availableLogicalWidthForContent):
New helper function that calls right - left (similar to the corresponding line function that includes
floats).

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::determineStartPosition):
Patched to check if a line has moved to a place with a different available content width. If so, the line
is dirtied so that line layout can re-run.

  • rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::RootInlineBox):
(WebCore::RootInlineBox::alignBoxesInBlockDirection):
Sets the paginated line width from the current block logical height.

  • rendering/RootInlineBox.h:

(WebCore::RootInlineBox::paginationStrut):
(WebCore::RootInlineBox::setPaginationStrut):
Fixed paginationStrut to be LayoutUnit instead of int.

(WebCore::RootInlineBox::paginatedLineWidth):
(WebCore::RootInlineBox::setPaginatedLineWidth):
Added paginatedLineWidth getter/setter for caching the content width for a given root line.

LayoutTests:

  • platform/mac/fast/regions/webkit-flow-floats-inside-regions-bounds-expected.png:
  • platform/mac/fast/regions/webkit-flow-floats-inside-regions-bounds-expected.txt:
  • platform/mac/fast/regions/webkit-flow-inlines-inside-regions-bounds-expected.png:
  • platform/mac/fast/regions/webkit-flow-inlines-inside-regions-bounds-expected.txt:
1:37 PM Changeset in webkit [95749] by andersca@apple.com
  • 5 edits in trunk/Source/WebCore

Remove Widget::beforeMouseDown and Widget::afterMouseDown
​https://bugs.webkit.org/show_bug.cgi?id=68570

Reviewed by Darin Adler.

These two member functions were originally added to avoid crashes due to removing NSViews while they were
being tracked by AppKit. Since they were added, we've moved away from NSViews for form controls, and the bugs in
AppKit that lead to crashes have been fixed.

This patch was rolled out in r95743 because it broke a bunch of tests. The patch accidentally removed setting back
m_sendingEventToSubview to false.

  • page/mac/EventHandlerMac.mm:

(WebCore::EventHandler::passMouseDownEventToWidget):

  • platform/Widget.h:
  • platform/mac/WidgetMac.mm:

(WebCore::Widget::Widget):
(WebCore::Widget::removeFromSuperview):

  • rendering/RenderWidget.cpp:

Change widgetHierarchyUpdateSuspendCount to be an unsigned integer instead of a size_t.

12:59 PM Changeset in webkit [95748] by rniwa@webkit.org
  • 48 edits in branches/chromium/874

Revert 93001 - Apple-style-span class seems unnecessary
​https://bugs.webkit.org/show_bug.cgi?id=12248

Reviewed by Justin Garcia.

Source/WebCore:

Stop generating span or font elements with class="Apple-style-span" given WebKit's editing component
no longer depends on Apple-style-span since r92823 removed the dependency of copy and paste code on
style spans. WebKit continues to recognize Apple style spans to remove them.

Also renamed isSpanWithoutAttributesOrUnstyleStyleSpan to isSpanWithoutAttributesOrUnstyle*d*StyleSpan.

  • editing/ApplyStyleCommand.cpp:

(WebCore::isLegacyAppleStyleSpan): Renamed from isStyleSpan.
(WebCore::isSpanWithoutAttributesOrUnstyledStyleSpan): Renamed from isSpanWithoutAttributesOr*Unstyle*StyleSpan.
(WebCore::createFontElement): No longer adds class="Apple-style-span".
(WebCore::createStyleSpanElement): Ditto.
(WebCore::ApplyStyleCommand::applyRelativeFontStyleChange): Calls isSpanWithoutAttributesOrUnstyleStyleSpan
instead of isUnstyledStyleSpan since there won't be any Apple style spans.
(WebCore::dummySpanAncestorForNode):
(WebCore::ApplyStyleCommand::cleanupUnstyledAppleStyleSpans): Ditto.
(WebCore::ApplyStyleCommand::removeEmbeddingUpToEnclosingBlock): Ditto.
(WebCore::ApplyStyleCommand::removeImplicitlyStyledElement):
(WebCore::ApplyStyleCommand::removeCSSStyle):

  • editing/ApplyStyleCommand.h:
  • editing/EditingStyle.cpp:

(WebCore::EditingStyle::removeStyleFromRulesAndContext): Ditto.

  • editing/ReplaceSelectionCommand.cpp:

(WebCore::ReplaceSelectionCommand::removeRedundantStylesAndKeepStyleSpanInline): Calls isLegacyAppleStyleSpan instead
of isStyleSpan.
(WebCore::handleStyleSpansBeforeInsertion): Ditto.
(WebCore::ReplaceSelectionCommand::handleStyleSpans): Ditto.
(WebCore::ReplaceSelectionCommand::doApply): Ditto.

  • editing/markup.cpp:

(WebCore::StyledMarkupAccumulator::appendStyleNodeOpenTag): No longer adds class="Apple-style-span".

LayoutTests:

Rebaselined the tests because spans in these tests lost no longer have class="Apple-style-span".

  • editing/deleting/delete-br-012-expected.txt:
  • editing/deleting/delete-line-break-between-paragraphs-with-same-style-expected.txt:
  • editing/deleting/delete-select-all-001-expected.txt:
  • editing/execCommand/16049-expected.txt:
  • editing/execCommand/5685604-1.html:
  • editing/execCommand/delete-image-in-anchor-expected.txt:
  • editing/execCommand/hilitecolor-expected.txt:
  • editing/execCommand/modifyForeColorByCharacter-expected.txt:
  • editing/execCommand/query-font-size-expected.txt:
  • editing/execCommand/remove-format-multiple-elements-expected.txt:
  • editing/execCommand/script-tests/remove-format-multiple-elements.js:
  • editing/execCommand/script-tests/toggle-text-decorations.js:
  • editing/execCommand/script-tests/toggle-unlink.js:
  • editing/execCommand/toggle-style-2-expected.txt:
  • editing/execCommand/toggle-text-decorations-expected.txt:
  • editing/execCommand/toggle-unlink-expected.txt:
  • editing/inserting/5994480-2-expected.txt:
  • editing/pasteboard/5065605-expected.txt:
  • editing/pasteboard/copy-null-characters-expected.txt:
  • editing/pasteboard/copy-text-with-backgroundcolor-expected.txt:
  • editing/pasteboard/data-transfer-items-expected.txt:
  • editing/pasteboard/do-not-copy-unnecessary-styles-2-expected.txt:
  • editing/pasteboard/do-not-copy-unnecessary-styles-expected.txt:
  • editing/pasteboard/onpaste-text-html-expected.txt:
  • editing/pasteboard/paste-text-with-style-2-expected.txt:
  • editing/style/apply-font-size-to-multiple-nodes-expected.txt:
  • editing/style/block-style-004-expected.txt:
  • editing/style/block-style-005-expected.txt:
  • editing/style/block-style-006-expected.txt:
  • editing/style/fontsize-1-expected.txt:
  • editing/style/fore-color-by-name-expected.txt:
  • editing/style/highlight-insert-paragraph-expected.txt:
  • editing/style/inline-style-container-expected.txt:
  • editing/style/inline-style-extend-run-expected.txt:
  • editing/style/invalid-font-size-expected.txt:
  • editing/style/push-down-font-styles-expected.txt:
  • editing/style/script-tests/inline-style-container.js:
  • editing/style/script-tests/inline-style-extend-run.js:
  • editing/style/script-tests/push-down-font-styles.js:
  • editing/style/style-text-node-without-editable-parent-expected.txt:
  • fast/events/ondrop-text-html-expected.txt:
  • platform/chromium-win/editing/inserting/5994480-2-expected.txt:
  • platform/gtk/editing/inserting/5994480-2-expected.txt:

TBR=​rniwa@webkit.org
Review URL: ​http://codereview.chromium.org/7973008

12:41 PM Changeset in webkit [95747] by ap@apple.com
  • 8 edits in trunk/Source/WebKit2

[WK2] UIProcess should check that WebProcess isn't sending unexpected file: URLs to it
​https://bugs.webkit.org/show_bug.cgi?id=68573

Reviewed by Anders Carlsson.

Re-landing with a slightly less aggressive check.

12:38 PM Changeset in webkit [95746] by robert@webkit.org
  • 1 edit
    3 adds in trunk/LayoutTests

Platform-specific results for test introduced by r95726

  • platform/gtk/fast/inline/left-right-center-inline-alignment-in-ltr-and-rtl-blocks-expected.txt: Added.
  • platform/mac/fast/inline/left-right-center-inline-alignment-in-ltr-and-rtl-blocks-expected.txt: Added.
  • platform/qt/fast/inline/left-right-center-inline-alignment-in-ltr-and-rtl-blocks-expected.txt: Added.
12:25 PM Changeset in webkit [95745] by rniwa@webkit.org
  • 10 edits
    17 deletes in trunk

Unreviewed, rolling out r95335 and r95645.
​http://trac.webkit.org/changeset/95335
​http://trac.webkit.org/changeset/95645
​https://bugs.webkit.org/show_bug.cgi?id=68649

Wrong fix (Requested by rniwa on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2011-09-22

Source/WebCore:

  • editing/DeleteSelectionCommand.cpp:

(WebCore::DeleteSelectionCommand::saveTypingStyleState):

  • editing/EditingStyle.cpp:

(WebCore::EditingStyle::removeStyleAddedByNode):

  • editing/EditingStyle.h:
  • editing/ReplaceSelectionCommand.cpp:

(WebCore::ReplaceSelectionCommand::removeRedundantStylesAndKeepStyleSpanInline):

  • editing/markup.cpp:

(WebCore::StyledMarkupAccumulator::serializeNodes):
(WebCore::ancestorToRetainStructureAndAppearance):

  • editing/markup.h:

LayoutTests:

  • editing/deleting/merge-paragraph-from-address-expected.txt: Removed.
  • editing/deleting/merge-paragraph-from-address.html: Removed.
  • editing/deleting/merge-paragraph-from-h6-expected.txt: Removed.
  • editing/deleting/merge-paragraph-from-h6-with-style-expected.txt: Removed.
  • editing/deleting/merge-paragraph-from-h6-with-style.html: Removed.
  • editing/deleting/merge-paragraph-from-h6.html: Removed.
  • editing/deleting/merge-paragraph-from-listing-expected.txt: Removed.
  • editing/deleting/merge-paragraph-from-listing.html: Removed.
  • editing/deleting/merge-paragraph-from-p-with-style-expected.txt: Removed.
  • editing/deleting/merge-paragraph-from-p-with-style.html: Removed.
  • editing/deleting/merge-paragraph-into-h1-expected.txt: Removed.
  • editing/deleting/merge-paragraph-into-h1-style-expected.txt: Removed.
  • editing/deleting/merge-paragraph-into-h1-with-style-expected.txt: Removed.
  • editing/deleting/merge-paragraph-into-h1-with-style.html: Removed.
  • editing/deleting/merge-paragraph-into-h1.html: Removed.
  • editing/deleting/merge-paragraph-into-pre-expected.txt: Removed.
  • editing/deleting/merge-paragraph-into-pre.html: Removed.
  • platform/mac/editing/deleting/merge-whitespace-pre-expected.png:
  • platform/mac/editing/deleting/merge-whitespace-pre-expected.txt:
12:14 PM Changeset in webkit [95744] by robert@webkit.org
  • 7 edits in trunk/LayoutTests

Unreviewed, update expected results after r95726

  • platform/chromium-win/css2.1/20110323/abspos-non-replaced-width-margin-000-expected.png:
  • platform/chromium-win/css2.1/20110323/abspos-replaced-width-margin-000-expected.png:
  • platform/gtk/css2.1/20110323/abspos-non-replaced-width-margin-000-expected.txt:
  • platform/gtk/css2.1/20110323/abspos-replaced-width-margin-000-expected.txt:
  • platform/qt/css2.1/20110323/abspos-non-replaced-width-margin-000-expected.txt:
  • platform/qt/css2.1/20110323/abspos-replaced-width-margin-000-expected.txt:
12:12 PM QtWebKitSecurity edited by Ademar Reis
(diff)
12:11 PM QtWebKitSecurity edited by Ademar Reis
(diff)
12:11 PM QtWebKitSecurity edited by Ademar Reis
(diff)
11:55 AM Changeset in webkit [95743] by rniwa@webkit.org
  • 5 edits in trunk/Source/WebCore

Revert r95673 since it caused hundreds of tests to fail on Leopard / Snow Leopard.

  • page/mac/EventHandlerMac.mm:

(WebCore::EventHandler::passMouseDownEventToWidget):

  • platform/Widget.h:
  • platform/mac/WidgetMac.mm:

(WebCore::Widget::Widget):
(WebCore::Widget::removeFromSuperview):
(WebCore::Widget::beforeMouseDown):
(WebCore::Widget::afterMouseDown):

  • rendering/RenderWidget.cpp:
11:51 AM Changeset in webkit [95742] by oliver@apple.com
  • 6 edits in trunk/Source/JavaScriptCore

Implement get_scoped_var in the DFG
​https://bugs.webkit.org/show_bug.cgi?id=68640

Reviewed by Gavin Barraclough.

Naive implementation of get_scoped_var in the DFG. Essentially this
is the bare minimum required to get correct behaviour, so there's no
load/store coalescing or type profiling involved, even though these
would be wins. No impact on SunSpider or V8.

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):

  • dfg/DFGCapabilities.h:

(JSC::DFG::canCompileOpcode):

  • dfg/DFGNode.h:

(JSC::DFG::Node::hasVarNumber):
(JSC::DFG::Node::hasScopeChainDepth):
(JSC::DFG::Node::scopeChainDepth):

  • dfg/DFGPropagator.cpp:

(JSC::DFG::Propagator::propagateNodePredictions):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compile):

11:31 AM Changeset in webkit [95741] by hyatt@apple.com
  • 1 edit
    24 adds
    11 deletes in trunk/LayoutTests

​https://bugs.webkit.org/show_bug.cgi?id=68645

Fix the layout test fast/regions directory. Remove platform-specific results that were
incorrectly checked in to cross-platform locations and add missing pixel test results.

Reviewed by Beth Dakin.

  • fast/regions/content-flowed-into-regions-dynamically-inserted-expected.txt: Removed.
  • fast/regions/flows-dependency-dynamic-remove-expected.txt: Removed.
  • fast/regions/flows-dependency-same-flow-expected.txt: Removed.
  • fast/regions/render-region-renderer-expected.txt: Removed.
  • fast/regions/webkit-flow-floats-inside-regions-bounds-expected.txt: Removed.
  • fast/regions/webkit-flow-inlines-inside-regions-bounds-expected.txt: Removed.
  • fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-expected.txt: Removed.
  • fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-rl-expected.txt: Removed.
  • fast/regions/webkit-flow-renderer-expected.txt: Removed.
  • fast/regions/webkit-flow-renderer-layer-expected.txt: Removed.
  • fast/regions/webkit-flow-renderer-nested-expected.txt: Removed.
  • platform/mac/fast/regions/content-flowed-into-regions-dynamically-added-expected.png: Added.
  • platform/mac/fast/regions/content-flowed-into-regions-dynamically-inserted-expected.txt: Added.
  • platform/mac/fast/regions/content-flowed-into-regions-dynamically-removed-expected.png: Added.
  • platform/mac/fast/regions/content-flowed-into-regions-expected.png: Added.
  • platform/mac/fast/regions/content-flowed-into-regions-with-dyn-index-expected.png: Added.
  • platform/mac/fast/regions/content-flowed-into-regions-with-index-dom-expected.png: Added.
  • platform/mac/fast/regions/content-flowed-into-regions-with-index-expected.png: Added.
  • platform/mac/fast/regions/flows-dependency-dynamic-remove-expected.png: Added.
  • platform/mac/fast/regions/flows-dependency-dynamic-remove-expected.txt: Added.
  • platform/mac/fast/regions/flows-dependency-same-flow-expected.png: Added.
  • platform/mac/fast/regions/flows-dependency-same-flow-expected.txt: Added.
  • platform/mac/fast/regions/no-split-line-box-expected.png: Added.
  • platform/mac/fast/regions/render-region-renderer-expected.txt: Added.
  • platform/mac/fast/regions/webkit-flow-floats-inside-regions-bounds-expected.png: Added.
  • platform/mac/fast/regions/webkit-flow-floats-inside-regions-bounds-expected.txt: Added.
  • platform/mac/fast/regions/webkit-flow-inlines-inside-regions-bounds-expected.png: Added.
  • platform/mac/fast/regions/webkit-flow-inlines-inside-regions-bounds-expected.txt: Added.
  • platform/mac/fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-expected.png: Added.
  • platform/mac/fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-expected.txt: Added.
  • platform/mac/fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-rl-expected.png: Added.
  • platform/mac/fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-rl-expected.txt: Added.
  • platform/mac/fast/regions/webkit-flow-renderer-expected.txt: Added.
  • platform/mac/fast/regions/webkit-flow-renderer-layer-expected.txt: Added.
  • platform/mac/fast/regions/webkit-flow-renderer-nested-expected.txt: Added.
11:12 AM Changeset in webkit [95740] by hyatt@apple.com
  • 3 edits in trunk/Source/WebCore

​https://bugs.webkit.org/show_bug.cgi?id=68638

Make RenderFlowThread cache whether or not it has regions of varying widths. This will
be relevant for performance as we begin adding code to do custom block painting and
layout based off regions not having the same width.

Reviewed by Dan Bernstein and Adam Roben.

  • rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::RenderFlowThread):
(WebCore::RenderFlowThread::layout):

  • rendering/RenderFlowThread.h:
11:03 AM Changeset in webkit [95739] by nduca@chromium.org
  • 2 edits in branches/chromium/874/Source/WebCore

Merge 94587 - [chromium] REGRESSION(94353): requestAnimationFrame not throttled in compositing path
​https://bugs.webkit.org/show_bug.cgi?id=67621

CCSingleThreadProxy should not perform layout when called
via the compositeImmediately path. Doing so makes it look
like frame rate is unbounded.

Reviewed by James Robinson.

  • platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:

(WebCore::CCSingleThreadProxy::compositeAndReadback):
(WebCore::CCSingleThreadProxy::compositeImmediately):
(WebCore::CCSingleThreadProxy::commitIfNeeded):

  • platform/graphics/chromium/cc/CCSingleThreadProxy.h:

TBR=​nduca@chromium.org
Review URL: ​http://codereview.chromium.org/7995010

11:02 AM QtWebKitReleases edited by Ademar Reis
(diff)
11:02 AM QtWebKitRelease22 edited by Ademar Reis
(diff)
11:01 AM QtWebKitRelease22 edited by Ademar Reis
(diff)
11:01 AM Changeset in webkit [95738] by andersca@apple.com
  • 3 edits in trunk/Source/WebCore

FrameView::invalidateRect and FrameView::setFrameRect shouldn't take LayoutRects
​https://bugs.webkit.org/show_bug.cgi?id=68639

Reviewed by David Hyatt.

FrameView::invalidateRect and FrameView::setFrameRect override Widget and ScrollView
member functions that take IntRects, and Widget coordinates are currently defined in terms of
IntRects (and probably always should since we want them to be pixel-aligned).

  • page/FrameView.cpp:

(WebCore::FrameView::invalidateRect):
(WebCore::FrameView::setFrameRect):

  • page/FrameView.h:
10:56 AM QtWebKitPackaging edited by Ademar Reis
(diff)
10:54 AM QtWebKitReleases edited by Ademar Reis
(diff)
10:54 AM QtWebKitRelease21 edited by Ademar Reis
(diff)
10:53 AM QtWebKitRelease21 edited by Ademar Reis
(diff)
10:52 AM Changeset in webkit [95737] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebCore

Unreviewed build fix (fixes warning about too many parens).

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::computePositionedLogicalWidthReplaced):

10:51 AM Changeset in webkit [95736] by andersca@apple.com
  • 2 edits in trunk/Source/WebCore

Widget::frameRect shouldn't be virtual
​https://bugs.webkit.org/show_bug.cgi?id=68637

Reviewed by Sam Weinig.

Nobody overrides Widget::frameRect and nobody should.

  • platform/Widget.h:
10:48 AM Changeset in webkit [95735] by Adam Roben
  • 1 edit
    1 delete in trunk/Tools

Remove FindSafari

It isn't used or built anymore.

Fixes <​http://webkit.org/b/68628>

Reviewed by Darin Adler.

  • FindSafari: Removed this directory and its contents.
10:48 AM Changeset in webkit [95734] by Adam Roben
  • 7 edits in trunk

Remove FindSafari from all our .sln files

It isn't used anymore, so there's no point in building it.

Part of <​http://webkit.org/b/68628> Remove FindSafari

Reviewed by Steve Falkenburg.

Source/JavaScriptCore:

Source/WebKit/win:

  • WebKit.vcproj/WebKit.sln: Also relinearized the build order while I was at it.

Tools:

  • DumpRenderTree/DumpRenderTree.sln:
  • WebKitTestRunner/WebKitTestRunner.sln:
10:47 AM Changeset in webkit [95733] by Adam Roben
  • 3 edits
    1 delete in trunk/Tools

Remove all uses of FindSafari

It isn't really needed anymore.

Fixes <​http://webkit.org/b/68626>.

Reviewed by Darin Adler.

  • Scripts/old-run-webkit-tests: Moved read/writeRegistryString from here to webkitdirs.pm.
  • Scripts/run-webkit-nightly.cmd: Removed. This used to be used to launch nightly builds of

WebKit, but now we use WebKit.exe for that.

  • Scripts/webkitdirs.pm:

(installedSafariPath): Changed to use readRegistryString instead of invoking FindSafari to
do the same thing.

(readRegistryString):
(writeRegistryString):
Moved here from old-run-webkit-tests.

10:47 AM Changeset in webkit [95732] by Adam Roben
  • 2 edits in trunk/Tools

Use the "direct object" form of system() to run WebKit.exe

This prevents the shell from parsing (and possibly splitting, if it contains spaces) the
path to WebKit.exe.

Fixes <​http://webkit.org/b/68623> run-safari doesn't work if there are spaces in the path to
%WEBKITOUTPUTDIR%

Reviewed by Steve Falkenburg.

  • Scripts/webkitdirs.pm:

(runSafari):

10:46 AM Changeset in webkit [95731] by Adam Roben
  • 2 edits in trunk/Tools

Quote the WEBKITLIBRARIESDIR path before passing it to the shell/cygpath

Fixes <​http://webkit.org/b/68621> build-webkit goes totally haywire on Windows if there are
spaces in the path to the WebKit source tree

Reviewed by John Sullivan.

  • Scripts/webkitdirs.pm:

(setupCygwinEnv):

10:46 AM Changeset in webkit [95730] by Adam Roben
  • 2 edits in trunk/Source/WebKit/win

Add testRegExp.vcproj to WebKit.sln

Fixes <​http://webkit.org/b/68403> Windows bots don't build testRegExp.vcproj

Reviewed by Brian Weinstein.

  • WebKit.vcproj/WebKit.sln: Added testRegExp. Made it build just after jsc, just like it

does when built as part of JavaScriptCore.sln.

10:40 AM Changeset in webkit [95729] by vestbo@webkit.org
  • 23 edits in trunk

[Qt] Use same DPI for application font as rest of app in DRT and WTR

QApplication will initialize the default application font based
on the application DPI at construction time, but we then override
the application DPI using QX11Info (hard-coding it to 96 for
consistency). This hard-coding is not reflected in the application
font, so we explicitly have update the font ourselves.

The 6 test results that are updated were originally produced with
a DPI of 75, as this is the default fallback DPI when a QFont is
constructed before QApplication. This was wrong, and the results
are updated to match a DPI of 96.

Reviewed by Csaba Osztrogonác.

10:36 AM Changeset in webkit [95728] by commit-queue@webkit.org
  • 6 edits
    2 adds in trunk

Ref protect shaders in V8WebGLRenderingContext::getAttachedShadersCallback
​https://bugs.webkit.org/show_bug.cgi?id=68630

Patch by Sergey Glazunov <​serg.glazunov@gmail.com> on 2011-09-22
Reviewed by Adam Barth.

Source/WebCore:

Test: fast/canvas/webgl/shader-deleted-by-accessor.html

  • bindings/js/JSWebGLRenderingContextCustom.cpp:

(WebCore::JSWebGLRenderingContext::getAttachedShaders):

  • bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:

(WebCore::V8WebGLRenderingContext::getAttachedShadersCallback):

  • html/canvas/WebGLRenderingContext.cpp:

(WebCore::WebGLRenderingContext::getAttachedShaders):

  • html/canvas/WebGLRenderingContext.h:

LayoutTests:

  • fast/canvas/webgl/shader-deleted-by-accessor-expected.txt: Added.
  • fast/canvas/webgl/shader-deleted-by-accessor.html: Added.
10:30 AM Changeset in webkit [95727] by robert@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

Unreviewed, platform-specific results for r95721.

  • platform/mac/fast/css/outline-narrowLine-expected.txt: Added.
  • platform/gtk/fast/css/outline-narrowLine-expected.txt: Added.
10:16 AM Changeset in webkit [95726] by robert@webkit.org
  • 9 edits
    11 moves
    3 adds
    11 deletes in trunk

CSS 2.1 failure: abspos-non-replaced-width-margin-000, abspos-replaced-width-margin-000
​https://bugs.webkit.org/show_bug.cgi?id=47148

Reviewed by David Hyatt.

Source/WebCore:

  • rendering/RenderBlock.h:
  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::startOffsetForLine): Return offset from right, rather than offset from left + logicalwidth

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::startAlignedOffsetForLine):

Return the correct alignment for RTL blocks too. Looks like neither FF or Opera do this correctly.
Covered by new test left-right-center-inline-alignment-in-ltr-and-rtl-blocks.html

  • rendering/RenderBox.cpp:

(WebCore::computeInlineStaticDistance):

  • The CSS 2.1 tests now require UAs to use the parent block's direction (rather than the containing block's direction) when computing static distance. The container block's direction is still used in the other width and offset related calculations.
  • In the context of this function, the logicalRight value is just an element that will be used later to calculate the correct logicalLeft position for the RTL block. So whereas an LTR block can substract containerBlock->borderLogicalLeft() in this function directly, an RTL block has to add it here so that will be later subtracted from availableSpace to get logicalLeft in computePositionedLogicalWidthUsing().

(WebCore::RenderBox::computePositionedLogicalWidth):

  • Update comments and use the container block's direction except when calculating the static distance.
  • Remove the notion of a quirks mode in this function and for calculating the position of replaced and non-replaced blocks generally. This is in line with both FF4 and Opera - neither of which have a quirks mode for them.

(WebCore::RenderBox::computePositionedLogicalWidthUsing):

  • Update comments and use the container block's direction except when calculating the static distance.

(WebCore::RenderBox::computePositionedLogicalHeight):

  • Update comments.

(WebCore::RenderBox::computePositionedLogicalWidthReplaced):

  • Update comments and use the container block's direction except when calculating the static distance.
  • If the containing block is RTL, always assume that values are over-constrained.

(WebCore::RenderBox::computePositionedLogicalHeightReplaced):

  • Update comments.

LayoutTests:

  • platform/chromium-linux/css2.1/20110323/abspos-non-replaced-width-margin-000-expected.png:
  • platform/chromium-linux/css2.1/20110323/abspos-replaced-width-margin-000-expected.png: New results for CSS 2.1 reference tests. These match exactly the reference test results.
  • fast/inline/left-right-center-inline-alignment-in-ltr-and-rtl-blocks.html: Added.
  • platform/chromium-linux/fast/inline/left-right-center-inline-alignment-in-ltr-and-rtl-blocks-expected.png: Added.
  • platform/chromium-linux/fast/inline/left-right-center-inline-alignment-in-ltr-and-rtl-blocks-expected.txt: Added. New test for left,right and center alignment of inline LTR and RTL blocks. FF and Opera don't pass this test.
  • fast/block/positioning/absolute-position-direction-strict.html: Removed.
  • fast/block/positioning/absolute-position-direction.html: Renamed from LayoutTests/fast/block/positioning/absolute-position-direction-quirk.html.
  • platform/chromium-linux/fast/block/positioning/absolute-position-direction-expected.png: Renamed from LayoutTests/platform/chromium-linux/fast/block/positioning/absolute-position-direction-quirk-expected.png.
  • platform/chromium-linux/fast/block/positioning/absolute-position-direction-strict-expected.png: Removed.
  • platform/chromium-win/fast/block/positioning/absolute-position-direction-expected.png: Renamed from LayoutTests/platform/chromium-win/fast/block/positioning/absolute-position-direction-quirk-expected.png.
  • platform/chromium-win/fast/block/positioning/absolute-position-direction-expected.txt: Renamed from LayoutTests/platform/chromium-win/fast/block/positioning/absolute-position-direction-quirk-expected.txt.
  • platform/chromium-win/fast/block/positioning/absolute-position-direction-strict-expected.png: Removed.
  • platform/chromium-win/fast/block/positioning/absolute-position-direction-strict-expected.txt: Removed.
  • platform/gtk/fast/block/positioning/absolute-position-direction-expected.png: Renamed from LayoutTests/platform/gtk/fast/block/positioning/absolute-position-direction-quirk-expected.png.
  • platform/gtk/fast/block/positioning/absolute-position-direction-expected.txt: Renamed from LayoutTests/platform/gtk/fast/block/positioning/absolute-position-direction-quirk-expected.txt.
  • platform/gtk/fast/block/positioning/absolute-position-direction-strict-expected.png: Removed.
  • platform/gtk/fast/block/positioning/absolute-position-direction-strict-expected.txt: Removed.
  • platform/mac-leopard/fast/block/positioning/absolute-position-direction-expected.png: Renamed from LayoutTests/platform/mac-leopard/fast/block/positioning/absolute-position-direction-quirk-expected.png.
  • platform/mac-leopard/fast/block/positioning/absolute-position-direction-strict-expected.png: Removed.
  • platform/mac/css2.1/20110323/abspos-non-replaced-width-margin-000-expected.txt:
  • platform/mac/css2.1/20110323/abspos-replaced-width-margin-000-expected.txt:
  • platform/mac/fast/block/positioning/absolute-position-direction-expected.png: Renamed from LayoutTests/platform/mac/fast/block/positioning/absolute-position-direction-quirk-expected.png.
  • platform/mac/fast/block/positioning/absolute-position-direction-expected.txt: Renamed from LayoutTests/platform/mac/fast/block/positioning/absolute-position-direction-quirk-expected.txt.
  • platform/mac/fast/block/positioning/absolute-position-direction-strict-expected.png: Removed.
  • platform/mac/fast/block/positioning/absolute-position-direction-strict-expected.txt: Removed.
  • platform/qt/fast/block/positioning/absolute-position-direction-expected.png: Renamed from LayoutTests/platform/qt/fast/block/positioning/absolute-position-direction-quirk-expected.png.
  • platform/qt/fast/block/positioning/absolute-position-direction-expected.txt: Renamed from LayoutTests/platform/qt/fast/block/positioning/absolute-position-direction-quirk-expected.txt.
  • platform/qt/fast/block/positioning/absolute-position-direction-strict-expected.png: Removed.
  • platform/qt/fast/block/positioning/absolute-position-direction-strict-expected.txt: Removed. These tests are superseded by abspos-non-replaced-width-margin-000.htm. Using the parent() block's direction to compute static distance is now a strict requirement for CSS 2.1, rather than an IE quirk.
10:09 AM Changeset in webkit [95725] by andersca@apple.com
  • 16 edits in trunk/Source

Get rid of Widget::setBoundsSize
​https://bugs.webkit.org/show_bug.cgi?id=68491

Reviewed by Sam Weinig.

This basically reverts ​http://trac.webkit.org/changeset/79167 and ​http://trac.webkit.org/changeset/75897
which were added to make zoom gestures work with WebKit1, but since we don't support zoom gestures in WebKit1
anymore, it's better for code cleanliness to get rid of Widget::setBoundsSize and the associated code. While this
will unfortunately break transformed iframes in WebKit1, but Simon says that it's an acceptable tradeoff.

Source/WebCore:

  • WebCore.exp.in:
  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::open):

  • page/FrameView.cpp:

(WebCore::FrameView::create):

  • platform/ScrollView.cpp:

(WebCore::ScrollView::visibleContentRect):
(WebCore::ScrollView::updateScrollbars):
(WebCore::ScrollView::wheelEvent):

  • platform/ScrollView.h:
  • platform/Widget.cpp:
  • platform/Widget.h:

(WebCore::Widget::resize):

  • platform/chromium/PopupContainer.cpp:

(WebCore::PopupContainer::refresh):

  • platform/gtk/ScrollViewGtk.cpp:

(WebCore::ScrollView::visibleContentRect):

  • platform/mac/WidgetMac.mm:

(WebCore::Widget::paint):

  • rendering/RenderWidget.cpp:

(WebCore::RenderWidget::setWidgetGeometry):
(WebCore::RenderWidget::setWidget):
(WebCore::RenderWidget::updateWidgetPosition):

  • rendering/RenderWidget.h:

Source/WebKit/mac:

  • Plugins/Hosted/WebHostedNetscapePluginView.mm:

(-[WebHostedNetscapePluginView updateAndSetWindow]):

  • WebView/WebFrameView.mm:
9:33 AM Changeset in webkit [95724] by hyatt@apple.com
  • 5 edits in trunk

​https://bugs.webkit.org/show_bug.cgi?id=68590

Floats pushed to next page, column or region don't reposition properly if the amount of
available logical width at the new position changes. Refactor the code so that we can
run the float placement algorithm again when this happens.

Source/WebCore:

Covered by an existing regions test that exposes the issue.

Reviewed by Adam Roben.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::computeLogicalLocationForFloat):
(WebCore::RenderBlock::positionNewFloats):

  • rendering/RenderBlock.h:

LayoutTests:

Reviewed by Adam Roben.

  • fast/regions/webkit-flow-floats-inside-regions-bounds-expected.txt:
9:31 AM Changeset in webkit [95723] by Csaba Osztrogonác
  • 2 edits
    1532 adds in trunk/LayoutTests

[Qt] Unreviewed. Add Qt specific expected results for css3/selectors3 tests.
All of them pass, they are compared to mac png results manually.

  • platform/qt/Skipped:
  • platform/qt/css3/selectors3/ [...]: Added.
9:18 AM Changeset in webkit [95722] by leandrogracia@chromium.org
  • 5 edits
    2 adds in trunk

Source/WebCore: Fire TextInput events on speech input, but not set/add any inputMethod attribute.
​https://bugs.webkit.org/show_bug.cgi?id=60451

Reviewed by Ryosuke Niwa.

Introduce code to dispatch TextInput events when text is introduced via
the speech input feature. Handle also the cases where speech input is
started programmatically from the LayoutTestController.

Test: fast/speech/input-ontextinput-event.html

  • dom/TextEventInputType.h:
  • html/shadow/TextControlInnerElements.cpp:

(WebCore::InputFieldSpeechButtonElement::setRecognitionResult):

LayoutTests: Testing text events triggered by speech input.
​https://bugs.webkit.org/show_bug.cgi?id=60451

Reviewed by Ryosuke Niwa.

  • fast/speech/input-ontextinput-event-expected.txt: Added.
  • fast/speech/input-ontextinput-event.html: Added.
  • fast/speech/input-text-speechstart.html:
9:14 AM Changeset in webkit [95721] by robert@webkit.org
  • 3 edits
    5 adds in trunk

Patch by Jason Liu <​jason.liu@torchmobile.com.cn> on 2011-09-20
Reviewed by Simon Fraser.

CSS outline property on a narrow element has rabbit ear artifacts
​https://bugs.webkit.org/show_bug.cgi?id=36793

Patch by Jason Liu <​jason.liu@torchmobile.com.cn>
Patch updated by Robert Hogan <​robert@webkit.org>

Source/WebCore:

Test: fast/css/outline-narrowLine.html

  • rendering/RenderInline.cpp:

(WebCore::RenderInline::paintOutlineForLine):

LayoutTests:

  • fast/css/outline-narrowLine.html: Added.
  • platform/qt/fast/css/outline-narrowLine-expected.txt: Added.
  • platform/qt/fast/css/outline-narrowLine-expected.png: Added.
  • platform/chromium-linux/fast/css/outline-narrowLine-expected.txt: Added.
  • platform/chromium-linux/fast/css/outline-narrowLine-expected.png: Added.
9:08 AM Changeset in webkit [95720] by Martin Robinson
  • 2 edits in trunk/Source/WebCore

[GTK]Popup drop-down menu contains extra empty spaces at beginning and
occupies whole screen when items in popup reaches the height of display device.
​https://bugs.webkit.org/show_bug.cgi?id=68533

When implementing the GTK+ menu position function, set pushIn to false, which tell
GTK+ not create a menu that is as big as the entire screen.

Patch by Wajahat Siddiqui <​mdwajahatali.siddiqui@motorola.com> on 2011-09-22
Reviewed by Martin Robinson.

  • platform/gtk/GtkPopupMenu.cpp:

(WebCore::GtkPopupMenu::menuPositionFunction): Set pushIn to false in the menu position function.

8:42 AM Changeset in webkit [95719] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled DEPS.

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2011-09-22

  • DEPS:
7:48 AM Changeset in webkit [95718] by bulach@chromium.org
  • 1 edit
    4 adds in trunk/LayoutTests

[chromium] Rebaseline following r95715
​https://bugs.webkit.org/show_bug.cgi?id=68619

Unreviewed, rebaseline.

  • platform/chromium-cg-mac/fast/events/scale-and-scroll-iframe-body-expected.png: Added.
  • platform/chromium-cg-mac/fast/events/scale-and-scroll-iframe-window-expected.png: Added.
  • platform/chromium-mac/fast/events/scale-and-scroll-iframe-body-expected.png: Added.
  • platform/chromium-mac/fast/events/scale-and-scroll-iframe-window-expected.png: Added.
6:54 AM Changeset in webkit [95717] by hclam@chromium.org
  • 2 edits in trunk/Source/WebCore

Define export symbol correctly due to rename of pageScaleFactor to
frameScaleFactor.

Not reviewed. Build fix.

  • WebCore.exp.in:
6:43 AM Changeset in webkit [95716] by vsevik@chromium.org
  • 4 edits in trunk/Source/WebCore

Web Inspector: Console is always scrolled to the top
​https://bugs.webkit.org/show_bug.cgi?id=67483

Reviewed by Pavel Feldman.

  • inspector/front-end/ConsoleView.js:

(WebInspector.ConsoleView.prototype.wasShown):
(WebInspector.ConsoleView.prototype.storeScrollPositions):
(WebInspector.ConsoleView.prototype.restoreScrollPositions):
(WebInspector.ConsoleView.prototype.onResize):
(WebInspector.ConsoleView.prototype._immediatelyScrollIntoView):
(WebInspector.ConsoleView.prototype._cancelScheduledScrollIntoView):
(WebInspector.ConsoleView.prototype._consoleCleared):

  • inspector/front-end/Drawer.js:

(WebInspector.Drawer.prototype.hide):
(WebInspector.Drawer.prototype.resize):
(WebInspector.Drawer.prototype._startStatusBarDragging):
(WebInspector.Drawer.prototype._statusBarDragging):

  • inspector/front-end/inspector.js:

(WebInspector.animateStyle):
(WebInspector.animateStyle.forceComplete):

6:30 AM Changeset in webkit [95715] by hclam@chromium.org
  • 11 edits
    12 adds in trunk

Source/WebCore: ​https://bugs.webkit.org/show_bug.cgi?id=68081
Fix scroll in page scaling mode.

Reviewed by Simon Fraser.

The following things are done in this patch:

  1. Rename Frame::pageScaleFactor() to Frame::frameScaleFactor() to better reflect its purpose.
  2. Frame::frameScaleFactor() returns the scale factor of this frame with respect to the container. So for the main frame it'll return the scale factor of the page, inner frames will return 1.0
  3. scrollBy(), scrollX() and scrollY() to take into account of the frame scale factor, causing incorrect coordinates reported to Javascript.

Tests: fast/events/scale-and-scroll-body.html

fast/events/scale-and-scroll-iframe-body.html
fast/events/scale-and-scroll-iframe-window.html
fast/events/scale-and-scroll-window.html

  • html/HTMLBodyElement.cpp:

(WebCore::adjustForZoom):
(WebCore::HTMLBodyElement::setScrollLeft):
(WebCore::HTMLBodyElement::setScrollTop):

  • loader/HistoryController.cpp:

(WebCore::HistoryController::saveScrollPositionAndViewStateToItem):

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::scrollX):
(WebCore::DOMWindow::scrollY):
(WebCore::DOMWindow::scrollTo):

  • page/Frame.cpp:

(WebCore::Frame::frameScaleFactor): Return page's scale factor if this is

main frame, otherwise 1.0

  • page/Frame.h:
  • page/FrameView.cpp:

(WebCore::FrameView::applyOverflowToViewport):
(WebCore::FrameView::scrollXForFixedPosition):
(WebCore::FrameView::scrollYForFixedPosition):

Source/WebKit2: ​https://bugs.webkit.org/show_bug.cgi?id=68081
Fix scroll in page scaling mode.

Reviewed by Simon Fraser.

  • WebProcess/Plugins/PluginView.cpp: Rename pageScaleFactor to frameScaleFactor.

(WebKit::PluginView::handleEvent):
(WebKit::PluginView::viewGeometryDidChange):
(WebKit::PluginView::clipRectInWindowCoordinates):

LayoutTests: ​https://bugs.webkit.org/show_bug.cgi?id=68081
Add layout test for page scale and scrolling.

Reviewed by Simon Fraser.

Add tests to cover the following cases:

  1. Scale and scroll window
  2. Scale and scroll document.body
  3. Scale and scroll iframe's contentWindow
  4. Scale and scroll iframe's contentDocument.body
  • fast/events/scale-and-scroll-body-expected.png: Added.
  • fast/events/scale-and-scroll-body-expected.txt: Added.
  • fast/events/scale-and-scroll-body.html: Added.
  • fast/events/scale-and-scroll-iframe-body-expected.png: Added.
  • fast/events/scale-and-scroll-iframe-body-expected.txt: Added.
  • fast/events/scale-and-scroll-iframe-body.html: Added.
  • fast/events/scale-and-scroll-iframe-window-expected.png: Added.
  • fast/events/scale-and-scroll-iframe-window-expected.txt: Added.
  • fast/events/scale-and-scroll-iframe-window.html: Added.
  • fast/events/scale-and-scroll-window-expected.png: Added.
  • fast/events/scale-and-scroll-window-expected.txt: Added.
  • fast/events/scale-and-scroll-window.html: Added.
6:25 AM Changeset in webkit [95714] by commit-queue@webkit.org
  • 3 edits
    3 adds in trunk

CSS: Implement 'font' property in CSSComputedStyle.
​https://bugs.webkit.org/show_bug.cgi?id=66666

Patch by Andreas Kling <​kling@webkit.org> on 2011-09-22
Reviewed by Antti Koivisto.

Source/WebCore:

Test: fast/css/getComputedStyle/computed-style-font.html

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::fontFamilyFromStyle): Factored out of getPropertyCSSValue().
This function will always return a CSSValueList, as opposed to the previous
implementation which would return a CSSPrimitiveValue if there was only one family.
getCSSPropertyValue() will return the first element of the list for 1-element lists
to preserve the current behavior of getPropertyCSSValue('font-family').

(WebCore::lineHeightFromStyle): Factored out of getPropertyCSSValue().
(WebCore::fontSizeFromStyle): Ditto.
(WebCore::fontStyleFromStyle): Ditto.
(WebCore::fontVariantFromStyle): Ditto.
(WebCore::fontWeightFromStyle): Ditto.

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Added
implementation of the computed 'font' property (CSSPropertyFont.)

LayoutTests:

  • fast/css/getComputedStyle/computed-style-font-expected.txt: Added.
  • fast/css/getComputedStyle/computed-style-font.html: Added.
  • fast/css/getComputedStyle/script-tests/computed-style-font.js: Added.

(computedFont):
(computedFontCSSValue):

6:05 AM Changeset in webkit [95713] by kov@webkit.org
  • 2 edits in trunk/Source/WebKit/gtk

Remove useless empty WebKit namespace.

Patch by Gustavo Noronha Silva <​gustavo.noronha@collabora.com> on 2011-09-22
Reviewed by Xan Lopez.

  • webkit/webkitglobals.cpp:

(webkitInit):

6:01 AM Changeset in webkit [95712] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt][WK2] Unreivewed gardening.

  • platform/qt-wk2/Skipped: Skip new failing test introduced in r95645.
5:50 AM Changeset in webkit [95711] by Csaba Osztrogonác
  • 64 edits in trunk/LayoutTests

[Qt] 69 tests failing after ​http://trac.webkit.org/changeset/92375
​https://bugs.webkit.org/show_bug.cgi?id=65721

Unreviewed gardening. Update Qt 4.8 specific expected files after r95706.

  • platform/qt-4.8/ [...]: Updated.
5:43 AM Changeset in webkit [95710] by jesus@webkit.org
  • 4 edits in trunk/Source

[Qt] Redirection overflow errors have wrong error domain
​https://bugs.webkit.org/show_bug.cgi?id=68612

Reviewed by Andreas Kling.

Source/WebCore:

Redirection overflow currently puts the URL hostname in the errorDomain field.
Now redirection overflow errors will be classified as "HTTP" errors.

  • platform/network/qt/QNetworkReplyHandler.cpp:

(WebCore::QNetworkReplyHandler::redirect):

Source/WebKit2:

Redirection overflow currently puts the URL hostname in the errorDomain field
and therefore are treated as a QWebError::EngineError. From now on they
will be treated as QWebError::HttpError, since their error domain was modified
to "HTTP" in QNetworkReplyHandler::redirect().

  • UIProcess/API/qt/qweberror.cpp:

(QWebError::type):

5:23 AM Changeset in webkit [95709] by Csaba Osztrogonác
  • 1 edit
    2 adds in trunk/LayoutTests

[Qt] Unreviewed gardening. Add Qt specific expected files for new test introduced in r95671.

  • platform/qt/fast/table/quote-text-around-iframe-expected.png: Added.
  • platform/qt/fast/table/quote-text-around-iframe-expected.txt: Added.
4:50 AM Changeset in webkit [95708] by Csaba Osztrogonác
  • 8 edits in trunk/Source/WebKit2

REGRESSION(r95679): It broke everything.
​https://bugs.webkit.org/show_bug.cgi?id=68611

Unreviewed rolling out r95679 and r95690, because it broke everything.

  • UIProcess/API/mac/WKView.mm:

(maybeCreateSandboxExtensionFromPasteboard):
(-[WKView performDragOperation:]):

  • UIProcess/WebContext.cpp:

(WebKit::WebContext::didPerformClientRedirect):
(WebKit::WebContext::didPerformServerRedirect):
(WebKit::WebContext::didUpdateHistoryTitle):
(WebKit::WebContext::getPluginPath):

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::reattachToWebProcessWithItem):
(WebKit::WebPageProxy::initializeSandboxExtensionHandle):
(WebKit::WebPageProxy::loadURL):
(WebKit::WebPageProxy::loadURLRequest):
(WebKit::WebPageProxy::loadHTMLString):
(WebKit::WebPageProxy::loadAlternateHTMLString):
(WebKit::WebPageProxy::goForward):
(WebKit::WebPageProxy::goBack):
(WebKit::WebPageProxy::goToBackForwardItem):
(WebKit::WebPageProxy::didStartProvisionalLoadForFrame):
(WebKit::WebPageProxy::didReceiveServerRedirectForProvisionalLoadForFrame):
(WebKit::WebPageProxy::didSameDocumentNavigationForFrame):
(WebKit::WebPageProxy::decidePolicyForNavigationAction):
(WebKit::WebPageProxy::decidePolicyForNewWindowAction):
(WebKit::WebPageProxy::decidePolicyForResponse):
(WebKit::WebPageProxy::didInitiateLoadForResource):
(WebKit::WebPageProxy::didSendRequestForResource):
(WebKit::WebPageProxy::didReceiveResponseForResource):
(WebKit::WebPageProxy::missingPluginButtonClicked):

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::WebProcessProxy):
(WebKit::WebProcessProxy::addBackForwardItem):

  • UIProcess/WebProcessProxy.h:
  • UIProcess/cf/WebPageProxyCF.cpp:

(WebKit::WebPageProxy::restoreFromSessionStateData):

4:05 AM Changeset in webkit [95707] by Csaba Osztrogonác
  • 2 edits in trunk/Source/JavaScriptCore

32-bit call code clobbers the function cell tag
​https://bugs.webkit.org/show_bug.cgi?id=68606

Patch by Filip Pizlo <​fpizlo@apple.com> on 2011-09-22
Reviewed by Csaba Osztrogonác.

This is a minimalistic fix: it simply emits code to restore the
cell tag on the slow path, if we know that we failed due to
emitCallIfNotType.

  • jit/JITCall32_64.cpp:

(JSC::JIT::compileOpCallVarargsSlowCase):
(JSC::JIT::compileOpCallSlowCase):

3:23 AM Changeset in webkit [95706] by Csaba Osztrogonác
  • 134 edits
    2 adds in trunk/LayoutTests

[Qt] 69 tests failing after ​http://trac.webkit.org/changeset/92375
​https://bugs.webkit.org/show_bug.cgi?id=65721

Unreviewed gardening. Update Qt specific expected files.

3:17 AM Changeset in webkit [95705] by bulach@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Update test expectation following r95685
​https://bugs.webkit.org/show_bug.cgi?id=68604

Unreviewed, update test expectation.

  • platform/chromium/test_expectations.txt:
3:05 AM Changeset in webkit [95704] by Csaba Osztrogonác
  • 13 edits
    1 add in trunk/LayoutTests

[Qt] 11 tests failed after r95671 because the tests are updated.
​https://bugs.webkit.org/show_bug.cgi?id=68596

Update Qt specific expected files.

  • platform/qt/fast/css-generated-content/table-cell-before-content-expected.png:
  • platform/qt/fast/css-generated-content/table-cell-before-content-expected.txt:
  • platform/qt/fast/table/table-cell-after-child-in-block-expected.txt:
  • platform/qt/fast/table/table-cell-before-after-content-around-table-block-expected.txt:
  • platform/qt/fast/table/table-cell-before-after-content-around-table-expected.txt:
  • platform/qt/fast/table/table-cell-before-child-in-block-expected.txt:
  • platform/qt/fast/table/table-row-after-child-in-block-expected.txt:
  • platform/qt/fast/table/table-row-before-after-content-around-block-expected.txt:
  • platform/qt/fast/table/table-row-before-after-content-around-table-expected.txt:
  • platform/qt/fast/table/table-row-before-child-in-block-expected.txt:
  • platform/qt/fast/table/table-row-style-not-updated-with-after-content-expected.png: Added.
  • platform/qt/fast/table/table-row-style-not-updated-with-after-content-expected.txt:
2:29 AM Changeset in webkit [95703] by loki@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] 11 tests failed after r95671 because the tests are updated.
​https://bugs.webkit.org/show_bug.cgi?id=68596

Unreviewed gardening. Typo fixes.

Patch by Oliver Varga <​voliver@inf.u-szeged.hu> on 2011-09-22

  • platform/qt/Skipped:
12:53 AM Changeset in webkit [95702] by jamesr@google.com
  • 15 edits in trunk/Source

Unreviewed, rolling out r95699.
​http://trac.webkit.org/changeset/95699
​https://bugs.webkit.org/show_bug.cgi?id=67417

Makes many chromium compositor tests crash

Source/WebCore:

  • platform/CrossThreadCopier.h:
  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::~LayerRendererChromium):

  • platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:

(WebCore::CCHeadsUpDisplay::enabled):

  • platform/graphics/chromium/cc/CCLayerImpl.cpp:

(WebCore::CCLayerImpl::CCLayerImpl):
(WebCore::CCLayerImpl::~CCLayerImpl):

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::CCLayerTreeHost):
(WebCore::CCLayerTreeHost::commitTo):
(WebCore::CCLayerTreeHost::setNeedsRedraw):

  • platform/graphics/chromium/cc/CCLayerTreeHost.h:

(WebCore::CCSettings::CCSettings):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::CCLayerTreeHostImpl):
(WebCore::CCLayerTreeHostImpl::~CCLayerTreeHostImpl):

  • platform/graphics/chromium/cc/CCProxy.h:
  • platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:

(WebCore::CCSingleThreadProxy::finishAllRendering):
(WebCore::CCSingleThreadProxy::setNeedsCommit):
(WebCore::CCSingleThreadProxy::commitIfNeeded):

  • platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::CCThreadProxy):
(WebCore::CCThreadProxy::~CCThreadProxy):
(WebCore::CCThreadProxy::compositeAndReadback):
(WebCore::CCThreadProxy::finishAllRendering):
(WebCore::CCThreadProxy::isStarted):
(WebCore::CCThreadProxy::initializeLayerRenderer):
(WebCore::CCThreadProxy::setNeedsCommit):
(WebCore::CCThreadProxy::setNeedsCommitAndRedraw):
(WebCore::CCThreadProxy::setNeedsRedraw):
(WebCore::CCThreadProxy::start):
(WebCore::CCThreadProxy::stop):
(WebCore::CCThreadProxy::beginFrameAndCommitOnCCThread):
(WebCore::CCThreadProxy::beginFrameAndCommit):
(WebCore::CCThreadProxy::commitOnCCThread):
(WebCore::CCThreadProxy::drawLayersOnCCThread):
(WebCore::CCThreadProxy::setNeedsCommitOnCCThread):
(WebCore::CCThreadProxy::setNeedsCommitAndRedrawOnCCThread):
(WebCore::CCThreadProxy::setNeedsRedrawOnCCThread):

  • platform/graphics/chromium/cc/CCThreadProxy.h:

Source/WebKit/chromium:

  • tests/CCLayerTreeHostTest.cpp:

(WTF::CCLayerTreeHostTest::doBeginTest):
(WTF::TEST_F):

  • tests/TreeSynchronizerTest.cpp:

(WebCore::TEST):

12:40 AM Changeset in webkit [95701] by Philippe Normand
  • 11 edits
    2 adds in trunk/LayoutTests

Unreviewed, GTK rebaseline after r95671.

  • platform/gtk/fast/css-generated-content/table-cell-before-content-expected.txt:
  • platform/gtk/fast/table/quote-text-around-iframe-expected.png: Added.
  • platform/gtk/fast/table/quote-text-around-iframe-expected.txt: Added.
  • platform/gtk/fast/table/table-cell-after-child-in-block-expected.txt:
  • platform/gtk/fast/table/table-cell-before-after-content-around-table-block-expected.txt:
  • platform/gtk/fast/table/table-cell-before-after-content-around-table-expected.txt:
  • platform/gtk/fast/table/table-cell-before-child-in-block-expected.txt:
  • platform/gtk/fast/table/table-row-after-child-in-block-expected.txt:
  • platform/gtk/fast/table/table-row-before-after-content-around-block-expected.txt:
  • platform/gtk/fast/table/table-row-before-after-content-around-table-expected.txt:
  • platform/gtk/fast/table/table-row-before-child-in-block-expected.txt:
  • platform/gtk/fast/table/table-row-style-not-updated-with-after-content-expected.txt:
12:35 AM Changeset in webkit [95700] by reni@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] 11 tests failed after r95671.
​https://bugs.webkit.org/show_bug.cgi?id=68596

Unreviewed gardening.

Patch by Oliver Varga <​voliver@inf.u-szeged.hu> on 2011-09-22

  • platform/qt/Skipped:
12:22 AM Changeset in webkit [95699] by jamesr@google.com
  • 15 edits in trunk/Source

[chromium] Make CCThreadProxy draw
​https://bugs.webkit.org/show_bug.cgi?id=67417

Source/WebCore:

Update the CCThreadProxy to correctly implement the CCProxy
interface, do all the right committing and updating steps, and
draw a picture on the screen.

Patch by Nat Duca <​nduca@chromium.org> on 2011-09-22
Reviewed by James Robinson.

  • platform/graphics/IntRect.h:
  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::~LayerRendererChromium):

  • platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:

(WebCore::CCHeadsUpDisplay::enabled):

  • platform/graphics/chromium/cc/CCLayerImpl.cpp:

(WebCore::CCLayerImpl::CCLayerImpl):
(WebCore::CCLayerImpl::~CCLayerImpl):

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::CCLayerTreeHost):
(WebCore::CCLayerTreeHost::commitTo):
(WebCore::CCLayerTreeHost::commitComplete):
(WebCore::CCLayerTreeHost::setNeedsRedraw):

  • platform/graphics/chromium/cc/CCLayerTreeHost.h:
  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::CCLayerTreeHostImpl):
(WebCore::CCLayerTreeHostImpl::~CCLayerTreeHostImpl):

  • platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:

(WebCore::CCSingleThreadProxy::finishAllRendering):
(WebCore::CCSingleThreadProxy::setNeedsCommit):
(WebCore::CCSingleThreadProxy::commitIfNeeded):

  • platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::CCThreadProxy):
(WebCore::CCThreadProxy::~CCThreadProxy):
(WebCore::CCThreadProxy::compositeAndReadback):
(WebCore::CCThreadProxy::drawLayersAndReadbackOnCCThread):
(WebCore::CCThreadProxy::finishAllRendering):
(WebCore::CCThreadProxy::isStarted):
(WebCore::CCThreadProxy::setNeedsCommit):
(WebCore::CCThreadProxy::setNeedsCommitAndRedraw):
(WebCore::CCThreadProxy::setNeedsRedraw):
(WebCore::CCThreadProxy::start):
(WebCore::CCThreadProxy::stop):
(WebCore::CCThreadProxy::finishAllRenderingOnCCThread):
(WebCore::CCThreadProxy::createBeginFrameAndCommitTaskOnCCThread):
(WebCore::CCThreadProxy::beginFrameAndCommit):
(WebCore::CCThreadProxy::commitOnCCThread):
(WebCore::CCThreadProxy::scheduleDrawTaskOnCCThread):
(WebCore::CCThreadProxy::drawLayersAndPresentOnCCThread):
(WebCore::CCThreadProxy::drawLayersOnCCThread):
(WebCore::CCThreadProxy::updateSchedulerStateOnCCThread):

  • platform/graphics/chromium/cc/CCThreadProxy.h:

Source/WebKit/chromium:

Disable CCLayerTreeHostTest temporarily. Will re-enable
with ​https://bugs.webkit.org/show_bug.cgi?id=67418

Patch by Nat Duca <​nduca@chromium.org> on 2011-09-22
Reviewed by James Robinson.

  • tests/CCLayerTreeHostTest.cpp:

Sep 21, 2011:

9:06 PM Changeset in webkit [95698] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/chromium

Implement WebKit side of IDBFactory::getDatabaseNames
​https://bugs.webkit.org/show_bug.cgi?id=68037

Patch by Joshua Bell <​jsbell@chromium.org> on 2011-09-21
Reviewed by Tony Chang.

Interface changes and stub implementations for
new IndexedDB IDBFactory.getDatabaseNames. This is
part one of a two-sided patch.

  • public/WebIDBCallbacks.h:

(WebKit::WebIDBCallbacks::onSuccess):

  • public/WebIDBFactory.h:

(WebKit::WebIDBFactory::getDatabaseNames):

8:29 PM Changeset in webkit [95697] by Beth Dakin
  • 7 edits in trunk/Source/WebCore

​https://bugs.webkit.org/show_bug.cgi?id=67415
Text drawn via -webkit-background-clip:text is blurry at device scale factors >1.0
-and corresponding-
<rdar://problem/10060379>

Reviewed by Darin Adler.

New helper function RenderBoxModelObject scales the mask image by the
deviceScaleFactor to get an image of the appropriate resolution. It also scales
the image's GraphicsContext so that the clip is set up on the same scale. Back in
paintFillLayerExtended() we still clip the image to the original maskRect to get
everything scaled back to the appropriate size.

  • rendering/RenderBoxModelObject.cpp:

(WebCore::createDeviceScaledImageBuffer):
(WebCore::RenderBoxModelObject::paintFillLayerExtended):

Make the deviceScaleFactor convenience function just a namespace-level function in
Page rather than a static member or Page.

  • page/Page.cpp:

(WebCore::deviceScaleFactor):

  • page/Page.h:


Pre-existing callers of Page::deviceScaleFactor(Frame*) must now use
WebCore::deviceScaleFactor(Frame*)

  • editing/DeleteButtonController.cpp:

(WebCore::DeleteButtonController::createDeletionUI):

  • rendering/RenderImage.cpp:

(WebCore::RenderImage::imageSizeForError):
(WebCore::RenderImage::paintReplaced):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::drawPlatformResizerImage):

7:14 PM Changeset in webkit [95696] by inferno@chromium.org
  • 6 edits
    4 adds in trunk/LayoutTests

Unreviewed. Chromium rebaselines for r95671.

  • platform/chromium-linux/fast/table/quote-text-around-iframe-expected.png: Added.
  • platform/chromium-mac/fast/table/quote-text-around-iframe-expected.png: Added.
  • platform/chromium-win/fast/css-generated-content/table-cell-before-content-expected.txt:
  • platform/chromium-win/fast/table/quote-text-around-iframe-expected.png: Added.
  • platform/chromium-win/fast/table/quote-text-around-iframe-expected.txt: Added.
  • platform/chromium-win/fast/table/table-cell-after-child-in-block-expected.txt:
  • platform/chromium-win/fast/table/table-cell-before-child-in-block-expected.txt:
  • platform/chromium-win/fast/table/table-row-after-child-in-block-expected.txt:
  • platform/chromium-win/fast/table/table-row-before-child-in-block-expected.txt:
7:04 PM Changeset in webkit [95695] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebCore

[CG] ImageBufferData::getData has an invariant comparison in the inner part of a loop which doesn't get optimized out
​https://bugs.webkit.org/show_bug.cgi?id=68588
<rdar://problem/10164955>

Reviewed by Simon Fraser.

Factor the unmultiplied check out of the inner loop, resulting in a
speed bump in ImageBufferData::getData.

No new tests, performance improvement.

  • platform/graphics/cg/ImageBufferDataCG.cpp:

(WebCore::ImageBufferData::getData):

6:52 PM Changeset in webkit [95694] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

:hover selector fails when hovering over a child select element with size attribute
​https://bugs.webkit.org/show_bug.cgi?id=67594

Patch by Sameer Patil <​mkrp87@motorola.com> on 2011-09-21
Reviewed by Darin Adler.

Source/WebCore:

Test: fast/css/hover-affects-ancestor.html

This patch addresses the problem of deactivation of the ancestor element :hover rules
when hovered its contained elements.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::updateHoverActiveState):

LayoutTests:

  • fast/css/hover-affects-ancestor-expected.txt: Added.
  • fast/css/hover-affects-ancestor.html: Added.
6:46 PM Changeset in webkit [95693] by barraclough@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Add missing addPtr->add32 mapping for X86.

Rubber stamped by Sam Weinig.

  • assembler/MacroAssembler.h:

(JSC::MacroAssembler::addPtr):

6:10 PM Changeset in webkit [95692] by barraclough@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Add missing addDouble for AbsoluteAddress to X86

Rubber stamped by Geoff Garen.

  • assembler/MacroAssemblerX86.h:

(JSC::MacroAssemblerX86::addDouble):

  • assembler/X86Assembler.h:

(JSC::X86Assembler::addsd_mr):
(JSC::X86Assembler::cvtsi2sd_rr):
(JSC::X86Assembler::cvtsi2sd_mr):

6:06 PM Changeset in webkit [95691] by commit-queue@webkit.org
  • 34 edits
    12 adds in trunk/LayoutTests

Rebaseline for bug 65583 (path based border radius drawing on skia) part 4
​https://bugs.webkit.org/show_bug.cgi?id=68339

Patch by Ben Wells <​benwells@chromium.org> on 2011-09-21
Reviewed by James Robinson.

  • platform/chromium-linux/css1/box_properties/border_style-expected.png:
  • platform/chromium-linux/css1/box_properties/border_style_inline-expected.png:
  • platform/chromium-linux/css2.1/: 14 changes
  • platform/chromium-linux/fast/borders/border-radius-inset-outset-expected.png: Added.
  • platform/chromium-linux/fast/borders/border-styles-split-expected.png: Added.
  • platform/chromium-linux/fast/writing-mode/border-styles-vertical-lr-expected.png: Added.
  • platform/chromium-linux/fast/writing-mode/border-styles-vertical-rl-expected.png: Added.
  • platform/chromium-win/css1/box_properties/border_style-expected.png:
  • platform/chromium-win/css1/box_properties/border_style_inline-expected.png:
  • platform/chromium-win/css2.1/: 14 changes
  • platform/chromium-win/fast/borders/border-radius-inset-outset-expected.png: Added.
  • platform/chromium-win/fast/borders/border-radius-inset-outset-expected.txt: Added.
  • platform/chromium-win/fast/borders/border-styles-split-expected.png: Added.
  • platform/chromium-win/fast/borders/border-styles-split-expected.txt: Added.
  • platform/chromium-win/fast/writing-mode/border-styles-vertical-lr-expected.png: Added.
  • platform/chromium-win/fast/writing-mode/border-styles-vertical-lr-expected.txt: Added.
  • platform/chromium-win/fast/writing-mode/border-styles-vertical-rl-expected.png: Added.
  • platform/chromium-win/fast/writing-mode/border-styles-vertical-rl-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
6:01 PM Changeset in webkit [95690] by ap@apple.com
  • 2 edits in trunk/Source/WebKit2

[WK2] UIProcess should check that WebProcess isn't sending unexpected file: URLs to it
​https://bugs.webkit.org/show_bug.cgi?id=68573

Unreviewed follow-up fix.

  • UIProcess/WebProcessProxy.cpp: (WebKit::WebProcessProxy::checkURLReceivedFromWebProcess): Just like we allow null URLs, also allow empty strings.
5:17 PM Changeset in webkit [95689] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

[Chromium] Protect message ports from being deleted in V8MessageEvent::portsAccessorGetter
​https://bugs.webkit.org/show_bug.cgi?id=68584

Patch by Sergey Glazunov <​serg.glazunov@gmail.com> on 2011-09-21
Reviewed by Adam Barth.

Source/WebCore:

Test: fast/dom/message-port-deleted-by-accessor.html

  • bindings/v8/custom/V8MessageEventCustom.cpp:

(WebCore::V8MessageEvent::portsAccessorGetter):

LayoutTests:

  • fast/dom/message-port-deleted-by-accessor-expected.txt: Added.
  • fast/dom/message-port-deleted-by-accessor.html: Added.
5:05 PM Changeset in webkit [95688] by levin@chromium.org
  • 3 edits
    6 adds
    1 delete in trunk/LayoutTests

[chromium] Rebaselines for passing tests and expectation updates/narrowing.

  • platform/chromium-cg-mac-leopard/editing/inserting/editable-inline-element-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/t090204-display-change-01-b-ao-expected.png: Added.
  • platform/chromium-mac-leopard/editing/inserting/editable-inline-element-expected.png: Added.
  • platform/chromium-mac/css2.1/t090204-display-change-01-b-ao-expected.png:
  • platform/chromium-mac/css2.1/t090204-display-change-01-b-ao-expected.txt: Removed.
  • platform/chromium/test_expectations.txt:
5:04 PM Changeset in webkit [95687] by barraclough@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Build fix following fix for bug #68586.

  • jit/JIT.cpp:
  • jit/JITInlineMethods.h:
4:58 PM Changeset in webkit [95686] by andersca@apple.com
  • 2 edits in trunk/Source/WebCore

Add back protection against the NSView going away while handling mouseDown
​https://bugs.webkit.org/show_bug.cgi?id=68585

Reviewed by Darin Adler.

Add calls to RenderWidget::suspendWidgetHierarchyUpdates() and RenderWidget::resumeWidgetHierarchyUpdates(),
as a followup fix to ​https://bugs.webkit.org/show_bug.cgi?id=68570.

  • page/mac/EventHandlerMac.mm:

(WebCore::EventHandler::passMouseDownEventToWidget):

4:50 PM Changeset in webkit [95685] by jchaffraix@webkit.org
  • 21 edits
    10 adds in trunk

Crash in RenderBox::paintMaskImages when GraphicsContext's painting is disabled
​https://bugs.webkit.org/show_bug.cgi?id=68133

Reviewed by Darin Adler.

.:

  • Source/autotools/symbols.filter: Added the mangled symbols needed for window.internals

Source/WebCore:

Tests: fast/css/webkit-mask-crash-fieldset-legend.html

fast/css/webkit-mask-crash-figure.html
fast/css/webkit-mask-crash-table.html
fast/css/webkit-mask-crash-td-2.html
fast/css/webkit-mask-crash-td.html

GraphicsContext::getCTM crashes if called with a GraphicsContext that has painting
disabled. RenderBox::paintMaskImages would thus crash if called in this condition.

This change just modifies the different GraphicsContext::getCTM method to bail early
if painting is disabled on the GraphicsContext. The rest of the change is exposing
paintControlTints that exposes this.

  • WebCore.exp.in: Added symbols of the newly export window.internals function.
  • page/FrameView.cpp:

(WebCore::FrameView::updateControlTints): Split this function in 2 so that
I can expose the internal paintControlTints.

(WebCore::FrameView::paintControlTints):
This is the one exposed to Internals as we want to be testable regardless of
whether the platform supports control tints.

  • page/FrameView.h: Added paintControlTints.
  • testing/Internals.cpp:

(WebCore::Internals::paintControlTints):

  • testing/Internals.h:
  • testing/Internals.idl:

Added a way to force a fake painting so that we can easily reproduce the bugs.

  • platform/graphics/cairo/GraphicsContextCairo.cpp:

(WebCore::GraphicsContext::getCTM):

  • platform/graphics/cg/GraphicsContextCG.cpp:

(WebCore::GraphicsContext::getCTM):

  • platform/graphics/qt/GraphicsContextQt.cpp:

(WebCore::GraphicsContext::getCTM):

  • platform/graphics/skia/GraphicsContextSkia.cpp:

(WebCore::GraphicsContext::getCTM):

  • platform/graphics/wince/GraphicsContextWinCE.cpp:

(WebCore::GraphicsContext::getCTM):

  • platform/graphics/wx/GraphicsContextWx.cpp:

(WebCore::GraphicsContext::getCTM):
Fixed all our back-end to exit early if painting is disabled.

Source/WebKit2:

  • win/WebKit2.def:
  • win/WebKit2CFLite.def:

Exported the new FrameView::paintControlTints function.

LayoutTests:

Those tests checks that we do not crash when calling internals.paintControlTints.

  • platform/mac/Skipped: Skipped 2 tests as they are hitting an ASSERT unrelated to

this change on Mac.

  • fast/css/webkit-mask-crash-fieldset-legend-expected.txt: Added.
  • fast/css/webkit-mask-crash-fieldset-legend.html: Added.
  • fast/css/webkit-mask-crash-figure-expected.txt: Added.
  • fast/css/webkit-mask-crash-figure.html: Added.
  • fast/css/webkit-mask-crash-table-expected.txt: Added.
  • fast/css/webkit-mask-crash-table.html: Added.
  • fast/css/webkit-mask-crash-td-2-expected.txt: Added.
  • fast/css/webkit-mask-crash-td-2.html: Added.
  • fast/css/webkit-mask-crash-td-expected.txt: Added.
  • fast/css/webkit-mask-crash-td.html: Added.
4:49 PM Changeset in webkit [95684] by barraclough@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

DFG JIT should be able to compile op_throw
​https://bugs.webkit.org/show_bug.cgi?id=68571

Patch by Filip Pizlo <​fpizlo@apple.com> on 2011-09-21
Reviewed by Geoffrey Garen.

This compiles op_throw in the simplest way possible: it's an OSR
point back to the old JIT. This is a good step towards increasing
coverage, particularly on Kraken, but it's neutral because the
same functions that do throw also use some other unsupported
opcodes.

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):

  • dfg/DFGCapabilities.h:

(JSC::DFG::canCompileOpcode):

  • dfg/DFGNode.h:
  • dfg/DFGPropagator.cpp:

(JSC::DFG::Propagator::propagateNodePredictions):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compile):

4:46 PM Changeset in webkit [95683] by fpizlo@apple.com
  • 6 edits in trunk/Source/JavaScriptCore

DFG JIT should be able to compile op_throw
​https://bugs.webkit.org/show_bug.cgi?id=68571

Reviewed by Geoffrey Garen.

This compiles op_throw in the simplest way possible: it's an OSR
point back to the old JIT. This is a good step towards increasing
coverage, particularly on Kraken, but it's neutral because the
same functions that do throw also use some other unsupported
opcodes.

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):

  • dfg/DFGCapabilities.h:

(JSC::DFG::canCompileOpcode):

  • dfg/DFGNode.h:
  • dfg/DFGPropagator.cpp:

(JSC::DFG::Propagator::propagateNodePredictions):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compile):

4:44 PM Changeset in webkit [95682] by commit-queue@webkit.org
  • 4 edits in trunk

IndexedDB: compare strings without decoding
​https://bugs.webkit.org/show_bug.cgi?id=68554

Patch by Joshua Bell <​jsbell@chromium.org> on 2011-09-21
Reviewed by Tony Chang.

Resolves a FIXME in IndexedDB that was also identified as a hotspot
during profiling. Yields a small performance improvement.

  • Source/WebCore/storage/IDBLevelDBCoding.cpp:
  • Source/WebCore/storage/IDBLevelDBCoding.h:
  • Source/WebKit/chromium/tests/IDBLevelDBCodingTest.cpp:
4:36 PM Changeset in webkit [95681] by fpizlo@apple.com
  • 24 edits
    3 adds in trunk/Source/JavaScriptCore

DFG should support continuous optimization
​https://bugs.webkit.org/show_bug.cgi?id=68329

Reviewed by Geoffrey Garen.

This adds the ability to reoptimize a code block if speculation
failures happen frequently. 6% speed-up on Kraken, 1% slow-down
on V8, neutral on SunSpider.

(JSC::CodeBlock::CodeBlock):
(JSC::ProgramCodeBlock::jettison):
(JSC::EvalCodeBlock::jettison):
(JSC::FunctionCodeBlock::jettison):
(JSC::CodeBlock::shouldOptimizeNow):
(JSC::CodeBlock::dumpValueProfiles):

  • bytecode/CodeBlock.h:
  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::getStrongPrediction):

  • dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::exitSpeculativeWithOSR):
(JSC::DFG::JITCompiler::compileEntry):
(JSC::DFG::JITCompiler::compileBody):

  • dfg/DFGJITCompiler.h:

(JSC::DFG::JITCompiler::noticeOSREntry):

  • dfg/DFGOSREntry.cpp:

(JSC::DFG::prepareOSREntry):

  • dfg/DFGOSREntry.h:

(JSC::DFG::getOSREntryDataBytecodeIndex):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • heap/ConservativeRoots.cpp:

(JSC::ConservativeRoots::ConservativeRoots):
(JSC::ConservativeRoots::~ConservativeRoots):
(JSC::DummyMarkHook::mark):
(JSC::ConservativeRoots::genericAddPointer):
(JSC::ConservativeRoots::genericAddSpan):
(JSC::ConservativeRoots::add):

  • heap/ConservativeRoots.h:
  • heap/Heap.cpp:

(JSC::Heap::addJettisonCodeBlock):
(JSC::Heap::markRoots):

  • heap/Heap.h:
  • heap/JettisonedCodeBlocks.cpp: Added.

(JSC::JettisonedCodeBlocks::JettisonedCodeBlocks):
(JSC::JettisonedCodeBlocks::~JettisonedCodeBlocks):
(JSC::JettisonedCodeBlocks::addCodeBlock):
(JSC::JettisonedCodeBlocks::clearMarks):
(JSC::JettisonedCodeBlocks::deleteUnmarkedCodeBlocks):
(JSC::JettisonedCodeBlocks::traceCodeBlocks):

  • heap/JettisonedCodeBlocks.h: Added.

(JSC::JettisonedCodeBlocks::mark):

  • interpreter/RegisterFile.cpp:

(JSC::RegisterFile::gatherConservativeRoots):

  • interpreter/RegisterFile.h:
  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

  • runtime/Executable.cpp:

(JSC::jettisonCodeBlock):
(JSC::EvalExecutable::jettisonOptimizedCode):
(JSC::ProgramExecutable::jettisonOptimizedCode):
(JSC::FunctionExecutable::jettisonOptimizedCodeForCall):
(JSC::FunctionExecutable::jettisonOptimizedCodeForConstruct):

  • runtime/Executable.h:

(JSC::FunctionExecutable::jettisonOptimizedCodeFor):

  • wtf/BitVector.h: Added.

(WTF::BitVector::BitVector):
(WTF::BitVector::~BitVector):
(WTF::BitVector::operator=):
(WTF::BitVector::size):
(WTF::BitVector::ensureSize):
(WTF::BitVector::resize):
(WTF::BitVector::clearAll):
(WTF::BitVector::get):
(WTF::BitVector::set):
(WTF::BitVector::clear):
(WTF::BitVector::bitsInPointer):
(WTF::BitVector::maxInlineBits):
(WTF::BitVector::byteCount):
(WTF::BitVector::makeInlineBits):
(WTF::BitVector::OutOfLineBits::numBits):
(WTF::BitVector::OutOfLineBits::numWords):
(WTF::BitVector::OutOfLineBits::bits):
(WTF::BitVector::OutOfLineBits::create):
(WTF::BitVector::OutOfLineBits::destroy):
(WTF::BitVector::OutOfLineBits::OutOfLineBits):
(WTF::BitVector::isInline):
(WTF::BitVector::outOfLineBits):
(WTF::BitVector::resizeOutOfLine):
(WTF::BitVector::bits):

4:32 PM Changeset in webkit [95680] by annacc@chromium.org
  • 2 edits in trunk/Tools

Update committers.py with a new contributor contact
​https://bugs.webkit.org/show_bug.cgi?id=68565

Reviewed by Eric Carlson.

  • Scripts/webkitpy/common/config/committers.py:
4:25 PM Changeset in webkit [95679] by ap@apple.com
  • 8 edits in trunk/Source/WebKit2

[WK2] UIProcess should check that WebProcess isn't sending unexpected file: URLs to it
​https://bugs.webkit.org/show_bug.cgi?id=68573

Reviewed by Anders Carlsson.

  • UIProcess/API/mac/WKView.mm: (maybeCreateSandboxExtensionFromPasteboard): Return a boolean, telling the caller whether an extension actually needed to be created (-[WKView performDragOperation:]): Tell process proxy when the process is going to get universal file read sandbox extension.
  • UIProcess/WebContext.cpp: (WebKit::WebContext::didPerformClientRedirect): Check the URLs. (WebKit::WebContext::didPerformServerRedirect): Ditto. (WebKit::WebContext::didUpdateHistoryTitle): Ditto. (WebKit::WebContext::getPluginPath): Ditto. Also, properly parse the URL - we can never assume that a string coming from WebProcess is a ParsedURLString.
  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::reattachToWebProcessWithItem): Tell process proxy when the process is going to get universal file read sandbox extension. (WebKit::WebPageProxy::maybeInitializeSandboxExtensionHandle): Changed to return a boolean, telling the caller whether an extension actually needed to be created. (WebKit::WebPageProxy::loadURL): Tell process proxy about extension. (WebKit::WebPageProxy::loadURLRequest): Ditto. (WebKit::WebPageProxy::loadHTMLString): Tell process proxy if a file URL was used as a base one for a string. In this case, WebKit2 assumes that WebProcess has access to a subdirectory, (typically, one where error page resources live), and can load from it. (WebKit::WebPageProxy::loadAlternateHTMLString): Ditto. (WebKit::WebPageProxy::goForward): Tell process proxy about extension. (WebKit::WebPageProxy::goBack): Tell process proxy about extension. (WebKit::WebPageProxy::goToBackForwardItem): Tell process proxy about extension. (WebKit::WebPageProxy::didStartProvisionalLoadForFrame): Check the URL. (WebKit::WebPageProxy::didReceiveServerRedirectForProvisionalLoadForFrame): Ditto. (WebKit::WebPageProxy::didSameDocumentNavigationForFrame): Ditto. (WebKit::WebPageProxy::decidePolicyForNavigationAction): Ditto. (WebKit::WebPageProxy::decidePolicyForNewWindowAction): Ditto. (WebKit::WebPageProxy::decidePolicyForResponse): Ditto. (WebKit::WebPageProxy::didInitiateLoadForResource): Ditto. (WebKit::WebPageProxy::didSendRequestForResource): Ditto. (WebKit::WebPageProxy::didReceiveResponseForResource): Ditto. (WebKit::WebPageProxy::missingPluginButtonClicked): Ditto.
  • UIProcess/WebPageProxy.h: Changed initializeSandboxExtensionHandle() to return a bool, and renamed to maybeInitializeSandboxExtensionHandle (matching WKView counterpart).
  • UIProcess/WebProcessProxy.cpp: (WebKit::WebProcessProxy::WebProcessProxy): Initialize m_mayHaveUniversalFileReadSandboxExtension. It's going to be true if we ever granted an extension for "/". (WebKit::WebProcessProxy::willLoadHTMLStringWithBaseURL): Remember the path, we should expect that WebProcess will load subresources from it. (WebKit::WebProcessProxy::checkURLReceivedFromWebProcess): Check that it's reasonable to expect WebProcess send us a URL like this. (WebKit::WebProcessProxy::addBackForwardItem): Check the URLs.
  • UIProcess/WebProcessProxy.h: Added data members remembering what to expect from this process.
  • UIProcess/cf/WebPageProxyCF.cpp: (WebKit::WebPageProxy::restoreFromSessionStateData): Tell process proxy when the process is going to get universal file read sandbox extension.
4:06 PM Changeset in webkit [95678] by jer.noble@apple.com
  • 9 edits in trunk/Source

Add settings to control the availability of the Web Audio API to WebKit and WebKit2.
​https://bugs.webkit.org/show_bug.cgi?id=68382

Source/WebCore:

Reviewed by Darin Adler.

Only create a AudioContext object if the Web Audio feature is runtime-enabled in Settings.

No new tests, as this feature is not yet enabled by default.

  • bindings/js/JSDOMWindowCustom.cpp:

(WebCore::JSDOMWindow::webkitAudioContext):

Source/WebKit/mac:

Reviewed by Darin Adler.

Initialize the webAudioEnabled preference to NO by default.

  • WebView/WebPreferences.mm:

(+[WebPreferences initialize]):

Source/WebKit2:

Add support for the webAudioEnabled preference in WebKit2.

Reviewed by Darin Adler.

  • Shared/WebPreferencesStore.h: Add WebAudioEnabled getter and setter macro.
  • UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesSetWebAudioEnabled): Added.
(WKPreferencesGetWebAudioEnabled): Added.

  • UIProcess/API/C/WKPreferences.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences): Update the webAudioEnabled preference.

3:54 PM Changeset in webkit [95677] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] Code cleanup in gesture recognizer unit tests
​https://bugs.webkit.org/show_bug.cgi?id=68561

Fix some style nits in the gesture recognizer unit tests.

Patch by Robert Kroeger <​rjkroege@chromium.org> on 2011-09-21
Reviewed by David Levin.

  • tests/InnerGestureRecognizerTest.cpp:

(InspectableGestureRecognizerChromium::stubEdgeFunction):
(BuildablePlatformTouchPoint::BuildablePlatformTouchPoint):
(TEST_F):

3:43 PM Changeset in webkit [95676] by barraclough@apple.com
  • 7 edits in trunk/Source/JavaScriptCore

Should support value profiling on CPU(X86)
​https://bugs.webkit.org/show_bug.cgi?id=68575

Reviewed by Sam Weinig.

Fix verbose profiling in ToT (SlowCaseProfile had been
partially renamed to RareCaseProfile), add in-memory
bucket counter for CPU(X86), move JIT::m_canBeOptimized
out of the DFG_JIT ifdef.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::resetRareCaseProfiles):
(JSC::CodeBlock::dumpValueProfiles):

  • bytecode/CodeBlock.h:
  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::makeSafe):

  • jit/JIT.cpp:

(JSC::JIT::privateCompileSlowCases):
(JSC::JIT::privateCompile):

  • jit/JIT.h:
  • jit/JITInlineMethods.h:

(JSC::JIT::emitValueProfilingSite):

3:41 PM Changeset in webkit [95675] by andersca@apple.com
  • 7 edits in trunk/Source

Remove checks for Leopard-only Objective-C APIs
​https://bugs.webkit.org/show_bug.cgi?id=68579

Reviewed by Sam Weinig.

We can always assume that OBJC_API_VERSION is at least 2, it's been 2 since Leopard.

../WebCore:

  • bridge/objc/objc_class.mm:

(JSC::Bindings::ObjcClass::methodsNamed):
(JSC::Bindings::ObjcClass::fieldNamed):

  • bridge/objc/objc_instance.mm:

(allocateAutoReleasePool):

  • bridge/objc/objc_runtime.mm:

(JSC::Bindings::ObjcField::ObjcField):

  • page/mac/EventHandlerMac.mm:

../WebKit/mac:

  • Misc/WebNSObjectExtras.h:
3:33 PM Changeset in webkit [95674] by hyatt@apple.com
  • 1 edit in trunk/LayoutTests/ChangeLog

Fix resolve-Changelog's strange butchery of the LayoutTests/Changelog.

3:20 PM Changeset in webkit [95673] by andersca@apple.com
  • 5 edits in trunk/Source/WebCore

Remove Widget::beforeMouseDown and Widget::afterMouseDown
​https://bugs.webkit.org/show_bug.cgi?id=68570

Reviewed by Sam Weinig.

These two member functions were originally added to avoid crashes due to removing NSViews while they were
being tracked by AppKit. Since they were added, we've moved away from NSViews for form controls, and the bugs in
AppKit that lead to crashes have been fixed.

  • page/mac/EventHandlerMac.mm:

(WebCore::EventHandler::passMouseDownEventToWidget):

  • platform/Widget.h:
  • platform/mac/WidgetMac.mm:

(WebCore::Widget::Widget):
(WebCore::Widget::removeFromSuperview):

  • rendering/RenderWidget.cpp:

Change widgetHierarchyUpdateSuspendCount to be an unsigned integer instead of a size_t.

3:17 PM Changeset in webkit [95672] by fpizlo@apple.com
  • 10 edits in trunk/Source/JavaScriptCore

DFG does not support compiling functions as constructors
​https://bugs.webkit.org/show_bug.cgi?id=68500

Reviewed by Oliver Hunt.

This adds support for compiling constructors to the DFG. It's a
1% speed-up on V8, mostly due to a 6% speed-up on early-boyer.
It's also a 13% win on access-binary-trees, but it's neutral in
the SunSpider and Kraken averages.

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):

  • dfg/DFGCapabilities.h:

(JSC::DFG::mightCompileFunctionForConstruct):
(JSC::DFG::canCompileOpcode):

  • dfg/DFGNode.h:
  • dfg/DFGOperations.cpp:
  • dfg/DFGOperations.h:
  • dfg/DFGPropagator.cpp:

(JSC::DFG::Propagator::propagateNodePredictions):
(JSC::DFG::Propagator::performNodeCSE):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • runtime/Executable.cpp:

(JSC::FunctionExecutable::compileOptimizedForConstruct):
(JSC::FunctionExecutable::compileForConstructInternal):

  • runtime/Executable.h:

(JSC::FunctionExecutable::compileForConstruct):
(JSC::FunctionExecutable::compileFor):
(JSC::FunctionExecutable::compileOptimizedFor):

3:05 PM Changeset in webkit [95671] by inferno@chromium.org
  • 16 edits
    3 adds in trunk

Source/WebCore: Not use anonymousContainer on beforeChild calculation
and let later code handle it. Fix style update on block-level
anonymous objects.
​https://bugs.webkit.org/show_bug.cgi?id=67656

Reviewed by David Hyatt.

Test: fast/table/quote-text-around-iframe.html

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::addChild):

  • rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::styleDidChange):

  • rendering/RenderTableRow.cpp:

(WebCore::RenderTableRow::addChild):

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::propagateStyleToAnonymousChildren):

LayoutTests: Not use anonymousContainer on beforeChild calculation
and let later code handle it.
​https://bugs.webkit.org/show_bug.cgi?id=67656

Reviewed by David Hyatt.

  • fast/table/quote-text-around-iframe.html: Added.
  • fast/table/table-row-style-not-updated-with-after-content-expected.txt:
  • platform/mac/fast/table/quote-text-around-iframe-expected.png: Added.
  • platform/mac/fast/table/quote-text-around-iframe-expected.txt: Added.

and lot of style propagation rebaselines.

2:56 PM Changeset in webkit [95670] by hyatt@apple.com
  • 4 edits
    3 adds in trunk

Source/WebCore: ​https://bugs.webkit.org/show_bug.cgi?id=68562

Pagination struts don't update properly when collapsing margin estimates are wrong.

Refactor the pagination adjustments that happen during block layout to allow for
a 3-pass layout system instead of just a 2-pass layout system. The basic idea is
to come up with an estimate that includes collapsing, clearance and pagination.

If the estimate only with collapsing and clearance was wrong, then we lay out again
using the correct collapsing margin values and clearance before applying pagination breaks.

After this second layout, the normal code that runs when unpaginated compares estimates
and lays out a third time to account for adjustments as a result of pagination movement.

Reviewed by Sam Weinig.

Added fast/regions/text-regions-split-small-pagination.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::estimateLogicalTopPosition):
(WebCore::RenderBlock::layoutBlockChild):
(WebCore::RenderBlock::adjustBlockChildForPagination):

  • rendering/RenderBlock.h:

LayoutTests: ​https://bugs.webkit.org/show_bug.cgi?id=68562

Pagination struts don't update properly when collapsing margin estimates are wrong.

Add a new regions result to test the bug fix.

Reviewed by Sam Weinig.

  • fast/regions/text-region-split-small-pagination.html: Added.
  • platform/mac/fast/regions/text-region-split-small-pagination-expected.png: Added.
  • platform/mac/fast/regions/text-region-split-small-pagination-expected.txt: Added.
2:21 PM Changeset in webkit [95669] by aa@chromium.org
  • 3 edits in trunk/Source/WebKit/chromium

Remove old and busted context notification APIs
​https://bugs.webkit.org/show_bug.cgi?id=68381

Reviewed by David Levin.

  • public/WebFrameClient.h:
  • src/FrameLoaderClientImpl.cpp:

(WebKit::FrameLoaderClientImpl::didCreateScriptContext):
(WebKit::FrameLoaderClientImpl::willReleaseScriptContext):

1:39 PM Changeset in webkit [95668] by jamesr@google.com
  • 2 edits in trunk/Source/WebCore

[chromium] SharedGraphicsContext3D's context should not be destroyed during atexit
​https://bugs.webkit.org/show_bug.cgi?id=68558

Reviewed by Stephen White.

The SharedGraphicsContext3D's internal context is lazily created and then leaked intentionally, but since the
last ref is in a function-static RefPtr<> it ends up being destroyed at process exit time. This is bad, since
by the time we get this far in process shutdown we can't actually cleanly run the destruction logic and we
crash. Since we are explicitly leaking this for the lifetime of the process there's no point in keeping it in a
RefPtr<>

  • platform/graphics/gpu/SharedGraphicsContext3D.cpp:

(WebCore::SharedGraphicsContext3D::get):

1:13 PM Changeset in webkit [95667] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

[Chromium] Protect the Frame in V8HTMLDocument::openCallback
​https://bugs.webkit.org/show_bug.cgi?id=68555

Patch by Sergey Glazunov <​serg.glazunov@gmail.com> on 2011-09-21
Reviewed by Nate Chapin.

Source/WebCore:

Test: fast/dom/frame-deleted-in-document-open.html

  • bindings/v8/custom/V8HTMLDocumentCustom.cpp:

(WebCore::V8HTMLDocument::openCallback):

LayoutTests:

  • fast/dom/frame-deleted-in-document-open-expected.txt: Added.
  • fast/dom/frame-deleted-in-document-open.html: Added.
12:59 PM Changeset in webkit [95666] by barraclough@apple.com
  • 16 edits in trunk/Source/JavaScriptCore

Replace jsFunctionVPtr compares with a type check on the Structure.
​https://bugs.webkit.org/show_bug.cgi?id=68557

Reviewed by Oliver Hunt.

This will permit calls to still optimize to subclasses of JSFunction
that have the correct type (but a different C++ vptr).

This patch stops passing the globalData into numerous functions.

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):

  • dfg/DFGGraph.h:

(JSC::DFG::Graph::isFunctionConstant):
(JSC::DFG::Graph::valueOfFunctionConstant):

  • dfg/DFGJITCompiler.h:

(JSC::DFG::JITCompiler::isFunctionConstant):
(JSC::DFG::JITCompiler::valueOfFunctionConstant):

  • dfg/DFGOperations.cpp:
  • interpreter/Interpreter.cpp:

(JSC::Interpreter::privateExecute):

  • jit/JIT.h:
  • jit/JITCall.cpp:

(JSC::JIT::compileOpCallVarargs):
(JSC::JIT::compileOpCallSlowCase):

  • jit/JITCall32_64.cpp:

(JSC::JIT::compileOpCallVarargs):
(JSC::JIT::compileOpCallSlowCase):

  • jit/JITInlineMethods.h:

(JSC::JIT::emitJumpIfNotType):

  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

  • runtime/Executable.h:

(JSC::isHostFunction):

  • runtime/JSFunction.h:

(JSC::JSFunction::createStructure):

  • runtime/JSObject.cpp:

(JSC::JSObject::put):
(JSC::JSObject::putWithAttributes):

  • runtime/JSObject.h:

(JSC::getJSFunction):
(JSC::JSObject::putDirect):
(JSC::JSObject::putDirectWithoutTransition):

  • runtime/JSType.h:
12:49 PM Changeset in webkit [95665] by leandro@webkit.org
  • 3 edits in trunk

Unreviewed. Remove unused ENABLE_AS_IMAGE flag after r95234 from
Options{Efl,WinCE}.cmake.

  • Source/cmake/OptionsEfl.cmake:
  • Source/cmake/OptionsWinCE.cmake:
12:47 PM Changeset in webkit [95664] by adamk@chromium.org
  • 8 edits
    2 adds in trunk

Clean up CSS Counter code
​https://bugs.webkit.org/show_bug.cgi?id=68492

Reviewed by Tony Chang.

Source/WebCore:

Several cleanups/fixes:

  • Make Counter::listStyle() return the actual list style string, rather than empty string.
  • Handle a specified list style of "none" correctly when generating cssText and in Counter::listStyle().
  • Use StringBuilder when generating cssText.

Test: fast/css/counters/getCounterValue.html

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseCounterContent):
Simplify processing (moving conversion to CSSStyleSelector),
pass a CSS_IDENT as the listStyle to Counter::create.

  • css/CSSPrimitiveValue.cpp:

(WebCore::CSSPrimitiveValue::cssText):
Use StringBuilder.

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):
Convert from a CSS_IDENT to an EListStyleType.

  • css/Counter.h:

(WebCore::Counter::listStyleIdent):
Renamed from listStyleNumber to match its new functionality.

LayoutTests:

Added tests for setting the list style to "none"
as well as tests for getCounterValue.

  • fast/css/counters/counter-cssText-expected.txt:
  • fast/css/counters/counter-cssText.html:
  • fast/css/counters/getCounterValue-expected.txt: Added.
  • fast/css/counters/getCounterValue.html: Added.
12:34 PM Changeset in webkit [95663] by ggaren@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Removed WTFTHREADDATA_MULTITHREADED, making it always true
​https://bugs.webkit.org/show_bug.cgi?id=68549

Reviewed by Darin Adler.

Another part of making threads exist in WebKit.

  • wtf/WTFThreadData.cpp:
  • wtf/WTFThreadData.h:

(WTF::wtfThreadData):

12:33 PM Changeset in webkit [95662] by cmarrin@apple.com
  • 2 edits in trunk/Source/WebCore

2011-09-21 Chris Marrin <​cmarrin@apple.com>

Check in WebCore.vcproj file unchanged but written like MSDev likes it

Unreviewed.

  • WebCode.vcproj/WebCore.vcproj:
12:30 PM Changeset in webkit [95661] by mitz@apple.com
  • 8 edits in trunk/Source/WebKit2

Use the prefix "WK" instead of "Web" for Objective-C classes defined in WebKit2.

Reviewed by Anders Carlsson.

Renamed WebInspectorProxyObjCAdapter to WKWebInspectorProxyObjCAdapter.
Renamed WebInspectorWKView to WKWebInspectorWKView.
Renamed WebFindIndicatorWindowAnimation to WKFindIndicatorWindowAnimation.
Renamed WebFindIndicatorView to WKFindIndicatorView.
Renamed WebUserDataWrapper to WKUserDataWrapper.

Updated the build phase checking for inappropriate Objective-C class names to disallow the prefix
"Web" and only allow "WK".

  • UIProcess/API/mac/FindIndicatorWindow.h:
  • UIProcess/API/mac/FindIndicatorWindow.mm:

(WebKit::FindIndicatorWindow::setFindIndicator):
(WebKit::FindIndicatorWindow::startFadeOutTimerFired):

  • UIProcess/WebInspectorProxy.h:
  • UIProcess/mac/WebContextMenuProxyMac.mm:

(-[WKMenuTarget forwardContextMenuAction:]):
(WebKit::nsMenuItemVector):

  • UIProcess/mac/WebInspectorProxyMac.mm:

(WebKit::WebInspectorProxy::platformCreateInspectorPage):
(WebKit::WebInspectorProxy::platformOpen):

  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/FullScreen/mac/WebFullScreenManagerMac.mm:

(WebKit::WebFullScreenManagerMac::WebFullScreenManagerMac):

12:24 PM Changeset in webkit [95660] by commit-queue@webkit.org
  • 18 edits in trunk

[WK2] [Mac] Implement a more-complete MouseDown/MouseUp/MouseMoveTo functions for WebKit2 EventSender
​https://bugs.webkit.org/show_bug.cgi?id=68108

This patch implements the event sender mouse events through WebKit2 UIProcess which is
closer to the real simulation than a WebProcess-only approach. The patch only supports Mac
platform as the first step so the existing code is still kept for other platforms.

Source/WebKit2:

Patch by Chang Shu <​cshu@webkit.org> on 2011-09-21
Reviewed by Darin Adler.

  • UIProcess/API/C/WKPage.cpp:

(WKPageSetShouldSendEventsSynchronously):

  • UIProcess/API/C/WKPagePrivate.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::handleMouseEvent):
(WebKit::WebPageProxy::handleKeyboardEvent):

  • UIProcess/WebPageProxy.h:

(WebKit::WebPageProxy::setShouldSendEventsSynchronously):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::mouseEventSyncForTesting):

  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in:

Tools:

Patch by Chang Shu <​cshu@webkit.org> on 2011-09-21
Reviewed by Darin Adler.

  • WebKitTestRunner/EventSenderProxy.h:

(WTR::EventSenderProxy::EventSenderProxy):
(WTR::EventSenderProxy::leapForward):
(WTR::EventSenderProxy::currentEventTime):

  • WebKitTestRunner/InjectedBundle/EventSendingController.cpp:

(WTR::EventSendingController::EventSendingController):
(WTR::EventSendingController::mouseDown):
(WTR::EventSendingController::mouseUp):
(WTR::EventSendingController::mouseMoveTo):
(WTR::EventSendingController::leapForward):
(WTR::EventSendingController::keyDown):

  • WebKitTestRunner/InjectedBundle/EventSendingController.h:
  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):

  • WebKitTestRunner/mac/EventSenderProxy.mm:

(WTR::eventTypeForMouseButtonAndAction):
(WTR::operator==):
(WTR::EventSenderProxy::updateClickCountForButton):
(WTR::EventSenderProxy::mouseDown):
(WTR::EventSenderProxy::mouseUp):
(WTR::EventSenderProxy::mouseMoveTo):
(WTR::EventSenderProxy::keyDown):

  • WebKitTestRunner/qt/EventSenderProxyQt.cpp:

(WTR::EventSenderProxy::keyDown):
(WTR::EventSenderProxy::mouseDown):
(WTR::EventSenderProxy::mouseUp):
(WTR::EventSenderProxy::mouseMoveTo):

LayoutTests:

Unskip the passed tests.

Patch by Chang Shu <​cshu@webkit.org> on 2011-09-21
Reviewed by Darin Adler.

  • platform/mac-wk2/Skipped:
  • platform/wk2/Skipped:
12:17 PM Changeset in webkit [95659] by demarchi@webkit.org
  • 28 edits in trunk/Source/WebKit/efl

[EFL] Revert pointer operator coding style in ewk
​https://bugs.webkit.org/show_bug.cgi?id=68231

Reviewed by Antonio Gomes.

The WebKit coding style mandates that "(...) in C++ code - Both pointer
types and reference types should be written with no space between the
type name and the * or &.". Until now EFL port was using the
coding-style of the library for platform code instead of WebKit's.

We are now trying to be more compliant with WebKit coding-style so it's
easier for other reviewers to review EFL code. The first step in this
direction is to move the '*' and '&' of pointers and references to the
right place.

This patch was generated with 'uncrustify' with the configure file
attached to the respective but report. There was one fix that had to be
manually made in order to keep the 'check-webkit-style' happy: a
function definition with a meaningless name. Other functions like this
exist but they will be fixed by a later patch.

Some nice side-effects of using uncrustify:

  • Whitespace cleanup on comments
  • Function parameters are aligned to the open parenthesis
  • Remove tab characters
12:11 PM Changeset in webkit [95658] by senorblanco@chromium.org
  • 4 edits in trunk/Source/WebCore

[chromium] Optimize ImageBuffer constructor when accelerated
​https://bugs.webkit.org/show_bug.cgi?id=68501

If the accelerated rendering mode is passed in to ImageBuffer, instead
of creating a bitmap PlatformCanvas and subsequently replacing its
device with an SkGpuDevice, create an SkCanvas and SkGpuDevice first,
and fall back to raster creation only failure. This saves on system
RAM for the backing store (and possibly GDI resources).

Reviewed by James Robinson.

Covered by existing tests.

  • platform/graphics/gpu/SharedGraphicsContext3D.cpp:

(WebCore::SharedGraphicsContext3D::get):

  • platform/graphics/gpu/SharedGraphicsContext3D.h:

Rename "SharedGraphicsContext3D::create()" to "get()" to more
accurately reflect its function.

  • platform/graphics/skia/ImageBufferSkia.cpp:

(WebCore::createAcceleratedCanvas):
Refactor creation of accelerated ImageBuffer.
(WebCore::ImageBuffer::ImageBuffer):
Attempt creation of accelerated ImageBuffer first, and only fall back
to bitmap-backed canvas creation if it fails.

12:06 PM Changeset in webkit [95657] by dimich@chromium.org
  • 3 edits
    4 copies in branches/chromium/874

Merge 95471 - [Chromium] Crash after magic iframe transfer for Pepper/NaCl plugins.
​https://bugs.webkit.org/show_bug.cgi?id=68267
Make adoptNode() to not enable live iframe transfer when the iframe's subtree contains plugins.

Reviewed by Adam Barth.

Source/WebCore:

Test: fast/frames/iframe-reparenting-embed-elements.html

  • dom/Document.cpp:

(WebCore::Document::adoptNode):

  • html/HTMLFrameElementBase.cpp:

(WebCore::hasPluginElements):
(WebCore::HTMLFrameElementBase::canRemainAliveOnRemovalFromTree):

  • html/HTMLFrameElementBase.h:

LayoutTests:

  • fast/frames/iframe-reparenting-embed-elements-expected.txt: Added.
  • fast/frames/iframe-reparenting-embed-elements.html: Added.
  • fast/frames/resources/iframe-reparenting-embed-frame1.html: Added.
  • fast/frames/resources/iframe-reparenting-embed-iframe.html: Added.

TBR=​dimich@chromium.org
Review URL: ​http://codereview.chromium.org/7980042

11:59 AM Changeset in webkit [95656] by demarchi@webkit.org
  • 2 edits in trunk/Source/WebKit/efl

[EFL] Don't try to free user-provided list
​https://bugs.webkit.org/show_bug.cgi?id=68356

Reviewed by Antonio Gomes.

A coding-style cleanup revealed that we were using EINA_LIST_FREE in a
wrong manner. If we intended to free the data, we should call free()
(or whatever function is required to destroy it). However not only did
it use the wrong EFL api but it also introduced a change in behavior,
freeing user-provided data.

  • ewk/ewk_frame.cpp:

(ewk_frame_feed_touch_event): do not free user-provided data.

11:48 AM Changeset in webkit [95655] by mitz@apple.com
  • 9 edits
    1 copy in trunk

Source/JavaScriptCore: JavaScriptCore Part of: Prevent the WebKit frameworks from defining inappropriately-named Objective-C classes
​https://bugs.webkit.org/show_bug.cgi?id=68451

Reviewed by Darin Adler.

  • JavaScriptCore.xcodeproj/project.pbxproj: Added a script build phase that invokes

check-for-inappropriate-objc-class-names, allowing only class names prefixed with "JS".

Source/WebCore: WebCore part of: Prevent the WebKit frameworks from defining inappropriately-named Objective-C classes
​https://bugs.webkit.org/show_bug.cgi?id=68451

Reviewed by Darin Adler.

  • WebCore.xcodeproj/project.pbxproj: Added a script build phase that invokes

check-for-inappropriate-objc-class-names, allowing only class names prefixed with "DOM" or "Web".

Source/WebKit: WebKit part of: Prevent the WebKit frameworks from defining inappropriately-named Objective-C classes
​https://bugs.webkit.org/show_bug.cgi?id=68451

Reviewed by Darin Adler.

  • WebKit.xcodeproj/project.pbxproj: Added a script build phase that invokes

check-for-inappropriate-objc-class-names, allowing only class names prefixed with "Web" or "_Web".

Source/WebKit2: WebKit2 part of: Prevent the WebKit frameworks from defining inappropriately-named Objective-C classes
​https://bugs.webkit.org/show_bug.cgi?id=68451

Reviewed by Darin Adler.

  • WebKit2.xcodeproj/project.pbxproj: Added a script build phase that invokes

check-for-inappropriate-objc-class-names, allowing only class names prefixed with "WK" or "Web".

Tools: Tools part of: Prevent the WebKit frameworks from defining inappropriately-named Objective-C classes
​https://bugs.webkit.org/show_bug.cgi?id=68451

Reviewed by Darin Adler.

  • Scripts/check-for-inappropriate-objc-class-names: Added. Checks for

Objective-C classes with names not having one of a list of prefixes
passed on the command line.

11:45 AM Changeset in webkit [95654] by mitz@apple.com
  • 3 edits
    2 adds in trunk

<rdar://problem/9768483> REGRESSION: Crash in RenderBlock::removeFloatingObjectsBelow()
​https://bugs.webkit.org/show_bug.cgi?id=68550

Reviewed by Darin Adler.

Source/WebCore:

Test: fast/multicol/null-lastFloat-in-removeFloatingObjectsBelow.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::removeFloatingObjectsBelow): Break out of the while() loop when the
floating object set is empty, which can happen if there were no floats on previous lines
(in which case, lastFloat is 0).

LayoutTests:

  • fast/multicol/null-lastFloat-in-removeFloatingObjectsBelow-expected.txt: Added.
  • fast/multicol/null-lastFloat-in-removeFloatingObjectsBelow.html: Added.
11:38 AM Changeset in webkit [95653] by dslomov@google.com
  • 2 edits in trunk/LayoutTests

Fixed bug number in test expectations.

  • platform/chromium/test_expectations.txt:
11:33 AM Changeset in webkit [95652] by barraclough@apple.com
  • 8 edits in trunk/Source/JavaScriptCore

MacroAssembler fixes.
​https://bugs.webkit.org/show_bug.cgi?id=68494

Reviewed by Sam Weinig.

Add X86-64's 3 operand or32 to other MacroAssembler, fix load32's [const] void* mismatch

  • assembler/MacroAssembler.h:

(JSC::MacroAssembler::orPtr):
(JSC::MacroAssembler::loadPtr):

  • assembler/MacroAssemblerARM.h:

(JSC::MacroAssemblerARM::or32):

  • assembler/MacroAssemblerARMv7.h:

(JSC::MacroAssemblerARMv7::or32):

  • assembler/MacroAssemblerMIPS.h:

(JSC::MacroAssemblerMIPS::or32):

  • assembler/MacroAssemblerSH4.h:

(JSC::MacroAssemblerSH4::or32):
(JSC::MacroAssemblerSH4::load32):

  • assembler/MacroAssemblerX86.h:

(JSC::MacroAssemblerX86::load32):

  • assembler/MacroAssemblerX86_64.h:

(JSC::MacroAssemblerX86_64::load32):

11:18 AM Changeset in webkit [95651] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

[GTK] Fix build break when enabling webgl on r95593
​https://bugs.webkit.org/show_bug.cgi?id=68502

Patch by ChangSeok Oh <ChangSeok Oh> on 2011-09-21
Reviewed by Martin Robinson.

Add PassOwnPtr.h to GC3DPrivate.h and remove useless one from GC3DGtk.cpp & GC3DPrivate.cpp

No tests required.

  • platform/graphics/gtk/GraphicsContext3DGtk.cpp:
  • platform/graphics/gtk/GraphicsContext3DPrivate.cpp:
  • platform/graphics/gtk/GraphicsContext3DPrivate.h:
11:14 AM Changeset in webkit [95650] by sfalken@apple.com
  • 2 edits in trunk/Source/WebKit/win

Branch builds don't launch on Windows when run against trunk WebKit
​https://bugs.webkit.org/show_bug.cgi?id=68546

Reviewed by Darin Adler.

  • Interfaces/IWebPreferences.idl: Swap avFoundation and pictographicFontFamily

in IDL for binary compatibility between branch and trunk.

11:01 AM Changeset in webkit [95649] by vsevik@chromium.org
  • 3 edits
    2 adds in trunk

Web Inspector: clear resource agent resource cache upon resource agent's disable.
​https://bugs.webkit.org/show_bug.cgi?id=67995

Reviewed by Pavel Feldman.

Source/WebCore:

Test: http/tests/inspector/network/network-disabling-check-no-memory-leak.html

  • inspector/InspectorResourceAgent.cpp:

(WebCore::InspectorResourceAgent::disable):

LayoutTests:

  • http/tests/inspector/network/network-disabling-check-no-memory-leak-expected.txt: Added.
  • http/tests/inspector/network/network-disabling-check-no-memory-leak.html: Added.
10:58 AM Changeset in webkit [95648] by hyatt@apple.com
  • 9 edits
    2 adds in trunk

​https://bugs.webkit.org/show_bug.cgi?id=68543

Make sure that when regions change dimensions we recompute pagination slices.

Reviewed by Simon Fraser.

Source/WebCore:

Added new tests in fast/regions.

  • rendering/LayoutState.cpp:

(WebCore::LayoutState::LayoutState):

  • rendering/LayoutState.h:
  • rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::layout):
(WebCore::RenderFlowThread::renderRegionForLine):
(WebCore::RenderFlowThread::regionLogicalWidthForLine):

  • rendering/RenderRegion.cpp:

(WebCore::RenderRegion::layout):

  • rendering/RenderView.cpp:

(WebCore::RenderView::pushLayoutState):

  • rendering/RenderView.h:

(WebCore::LayoutStateMaintainer::LayoutStateMaintainer):
(WebCore::LayoutStateMaintainer::push):

LayoutTests:

  • fast/regions/text-region-split-after-resize-expected.txt: Added.
  • fast/regions/text-region-split-after-resize.html: Added.
  • fast/regions/webkit-flow-floats-inside-regions-bounds-expected.txt:
10:37 AM Changeset in webkit [95647] by commit-queue@webkit.org
  • 8 edits
    2 adds in trunk

Ensure TestWebKitAPI works on mac, win, chromium-mac and chromium-linux
​https://bugs.webkit.org/show_bug.cgi?id=68206

Patch by Xianzhu Wang <​wangxianzhu@chromium.org> on 2011-09-21
Reviewed by Tony Chang.

Source/WebCore:

Added two new wtf headers into ForwardingHeaders/wtf to make
#include <wtf/...h> cross-platform.
No new tests needed.

  • ForwardingHeaders/wtf/MetaAllocator.h: Added.
  • ForwardingHeaders/wtf/RedBlackTree.h: Added.

Source/WebKit/chromium:

  • WebKit.gyp:

Tools:

  • Scripts/webkitdirs.pm:

(determineBaseProductDir): add support for chromium-mac

  • TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
  • TestWebKitAPI/Tests/WTF/RedBlackTree.cpp:
10:10 AM Changeset in webkit [95646] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[WinCairo] IconDatabase::defaultIcon always fails for non-CAN_THEME_URL_ICON builds.
​https://bugs.webkit.org/show_bug.cgi?id=67469

Patch by David Delaune <​david.delaune@googlemail.com> on 2011-09-21
Reviewed by Brent Fulgham.

No new functionality added in this change.

  • loader/icon/IconDatabase.cpp: defining CAN_THEME_URL_ICON for the WIN_CAIRO
10:06 AM Changeset in webkit [95645] by rniwa@webkit.org
  • 10 edits
    2 adds in trunk

Span element gets produced using backspace/delete to merge header with paragraph
​https://bugs.webkit.org/show_bug.cgi?id=68413

Reviewed by Darin Adler.

Source/WebCore:

Add p element to the list of elements to retain appearance. Also modified removeStyleFromNode
(and renamed to removeStyleFromRules) not to remove inline style declarations because
inline styles need to stay on copy.

Test: editing/deleting/merge-paragraph-from-p-with-style.html

  • editing/DeleteSelectionCommand.cpp:

(WebCore::DeleteSelectionCommand::saveTypingStyleState):

  • editing/EditingStyle.cpp:

(WebCore::EditingStyle::removeStyleFromRules): Renamed from removeStyleFromNode.

  • editing/EditingStyle.h:
  • editing/markup.cpp:

(WebCore::isBlockNodeToRetainAppearance):
(WebCore::StyledMarkupAccumulator::serializeNodes):

LayoutTests:

Add a test to remove the line break before a p element. WebKit should not preserve
the font color from the style rule but should preserve the font style from inline style declaration.

Also fix merge-paragraph-from-h6* to actually h6 instead of h1.

  • editing/deleting/merge-paragraph-from-h6-expected.txt:
  • editing/deleting/merge-paragraph-from-h6-with-style-expected.txt:
  • editing/deleting/merge-paragraph-from-h6-with-style.html:
  • editing/deleting/merge-paragraph-from-h6.html:
  • editing/deleting/merge-paragraph-from-p-with-style-expected.txt: Added.
  • editing/deleting/merge-paragraph-from-p-with-style.html: Added.
10:00 AM Changeset in webkit [95644] by ojan@chromium.org
  • 7 edits in trunk/LayoutTests

[flexbox] rename classnames and methods in the tests to not assume horizontal
​https://bugs.webkit.org/show_bug.cgi?id=68498

Reviewed by Tony Chang.

  • css3/flexbox/001.html:
  • css3/flexbox/002.html:
  • css3/flexbox/003.html:
  • css3/flexbox/004.html:
  • css3/flexbox/resources/flexbox.js:

(checkFlexBoxen):

  • css3/flexbox/writing-modes.html:
  • platform/mac/Skipped:
9:51 AM Changeset in webkit [95643] by reed@google.com
  • 2 edits in trunk/LayoutTests

need rebaseline for gradient speedup in skia
​https://bugs.webkit.org/show_bug.cgi?id=68531

Reviewed by Stephen White.

  • platform/chromium/test_expectations.txt:
9:48 AM Changeset in webkit [95642] by Philippe Normand
  • 3 edits in trunk/LayoutTests

Unreviewed, move today's skipped flaky tests to test_expectations
as suggested by mrobinson.

  • platform/gtk/Skipped:
  • platform/gtk/test_expectations.txt:
9:45 AM Changeset in webkit [95641] by commit-queue@webkit.org
  • 5 edits
    2 adds in trunk

Report AXValueChanged when value changes in element with role=textbox.
​https://bugs.webkit.org/show_bug.cgi?id=68201

Patch by Alice Boxhall <​aboxhall@chromium.org> on 2011-09-21
Reviewed by Chris Fleizach.

Source/WebCore:

Test: platform/mac/accessibility/textbox-role-reports-notifications.html

  • accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::isARIATextControl):

  • accessibility/AccessibilityObject.h:
  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::contentChanged):
(WebCore::AccessibilityRenderObject::childrenChanged):

LayoutTests:

  • platform/mac/accessibility/textbox-role-reports-notifications-expected.txt: Added.
  • platform/mac/accessibility/textbox-role-reports-notifications.html: Added.
9:39 AM Changeset in webkit [95640] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

[chromium]ClearFocusedNode doesn't clear the cursor or selection in editable div element.
​https://bugs.webkit.org/show_bug.cgi?id=68351

Patch by chandra shekar vallala <​chandra.vallala@gmail.com> on 2011-09-21
Reviewed by Darin Fisher.

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::clearFocusedNode):

9:27 AM Changeset in webkit [95639] by annacc@chromium.org
  • 1 edit
    6 adds in trunk/LayoutTests

New layout tests for the JS bindings related to <track>:

e.g. TextTrack, TextTrackCue, TextTrackCueList, MutableTextTrack.

​https://bugs.webkit.org/show_bug.cgi?id=68194

Reviewed by Eric Carlson.

  • media/track/track-mutable-expected.txt: Added.
  • media/track/track-mutable.html: Added.
  • media/track/track-text-track-cue-list-expected.txt: Added.
  • media/track/track-text-track-cue-list.html: Added.
  • media/track/track-text-track-expected.txt: Added.
  • media/track/track-text-track.html: Added.
9:19 AM Changeset in webkit [95638] by kbalazs@webkit.org
  • 1 edit in trunk/LayoutTests/platform/qt-wk2/Skipped

Actually skip the test (forgot in the previous commit). Sorry for the noise.

9:15 AM Changeset in webkit [95637] by kbalazs@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt][WK2] plugins/mouse-click-iframe-to-plugin.html fails since enabled in r95626
​https://bugs.webkit.org/show_bug.cgi?id=68539

Unreviewed gardening.

  • platform/qt-wk2/Skipped: skip the test.
9:13 AM Changeset in webkit [95636] by pfeldman@chromium.org
  • 7 edits in trunk/Source/WebCore

Web Inspector: introduce Page.enable and Page.disable
​https://bugs.webkit.org/show_bug.cgi?id=68530

Otherwise protocol is violating the contract of not sending
notifications by default.

Reviewed by Yury Semikhatsky.

  • inspector/Inspector.json:
8:51 AM Changeset in webkit [95635] by caryclark@google.com
  • 2 edits in trunk/LayoutTests

Unreviewed; new baselines (Skia on Mac)

This separates test failures that are specific to CG Mac from failures
for Skia on Mac. Most of these changes are specific to Leopard, but a
handful add new fail flavors for all Mac variations.

  • LayoutTests/platform/chromium/test_expectations.txt:
8:39 AM Changeset in webkit [95634] by pfeldman@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: add minimal error handling to the DOM breakpoints.
​https://bugs.webkit.org/show_bug.cgi?id=68537

Reviewed by Yury Semikhatsky.

  • inspector/InspectorDOMAgent.h:
  • inspector/InspectorDOMDebuggerAgent.cpp:

(WebCore::domTypeForName):
(WebCore::InspectorDOMDebuggerAgent::setDOMBreakpoint):
(WebCore::InspectorDOMDebuggerAgent::removeDOMBreakpoint):

8:36 AM Changeset in webkit [95633] by Philippe Normand
  • 1 edit
    1 add in trunk/LayoutTests

Unreviewed, GTK baselines for
cross-origin-xsl-redirect-BLOCKED.html which were removed by mistake.

  • platform/gtk/http/tests/security/cross-origin-xsl-redirect-BLOCKED-expected.txt: Added.
8:19 AM Changeset in webkit [95632] by loislo@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: make WebInspector a bit more timeline friendly.
​https://bugs.webkit.org/show_bug.cgi?id=68534

I found that the maximum captured stack frame depth tracked by timeline is not
very convenient because the average depth of call stack considerably more than five.
Another useful trick is console.timeStamp for all backend calls.

Reviewed by Yury Semikhatsky.

  • inspector/CodeGeneratorInspector.pm:
  • inspector/front-end/TimelinePanel.js:

(WebInspector.TimelinePanel.prototype._toggleTimelineButtonClicked):

8:10 AM Changeset in webkit [95631] by commit-queue@webkit.org
  • 11 edits
    2 adds in trunk/Source

[Qt][WK2] Implement Download support in WebProcess
​https://bugs.webkit.org/show_bug.cgi?id=68153

Patch by Jesus Sanchez-Palencia <​jesus.palencia@openbossa.org> on 2011-09-21
Reviewed by Andreas Kling.

Source/WebCore:

Refactored QNetworkReplyHandler::finish() in order to add
and use the static function QNetworkReplyHandler::errorForReply().
This will be used by our Download implementation in WebKit2 (WebProcess)
when handling ResourceError.

  • platform/network/qt/QNetworkReplyHandler.cpp:

(WebCore::QNetworkReplyHandler::finish):
(WebCore::QNetworkReplyHandler::errorForReply):

  • platform/network/qt/QNetworkReplyHandler.h:
  • platform/network/qt/ResourceRequest.h:

Source/WebKit2:

We implement the necessary functions of Download.h, and our QtFileDownloader
to handle all network communication and call the necessary functions of Download.

We use the download policy for any MIME type not supported by WebKit. This
behaves like Qt non-WebKit2 except that we don't force download when
we encounter Content-Disposition: attachment. We still use the "filename="
field for file name suggestion though.

Based on original patches by: Kimmo Kinnunen <​kimmo.t.kinnunen@nokia.com>,
Jocelyn Turcotte <​jocelyn.turcotte@nokia.com>, Simon Hausmann <​simon.hausmann@nokia.com>
and Zalan Bujtas <​zalan.bujtas@nokia.com>.

  • UIProcess/API/qt/qweberror.cpp: Adding DownloadError

(QWebError::type):

  • UIProcess/API/qt/qweberror.h: Adding DownloadError
  • WebKit2.pro:
  • WebProcess/Downloads/Download.cpp: Adding QtFileDownloader, Qt platform specific

(WebKit::Download::Download):

  • WebProcess/Downloads/Download.h: Adding QtFileDownloader, Qt platform specific
  • WebProcess/Downloads/qt/DownloadQt.cpp:

(WebKit::Download::start):
(WebKit::Download::startWithHandle):
(WebKit::Download::cancel):
(WebKit::Download::platformInvalidate):
(WebKit::Download::didDecideDestination):

  • WebProcess/Downloads/qt/QtFileDownloader.cpp: Added.

(WebKit::QtFileDownloader::QtFileDownloader):
(WebKit::QtFileDownloader::~QtFileDownloader):
(WebKit::QtFileDownloader::determineFilename):
(WebKit::QtFileDownloader::decidedDestination):
(WebKit::QtFileDownloader::abortDownloadWritingAndEmitError):
(WebKit::QtFileDownloader::onReadyRead):
(WebKit::QtFileDownloader::onFinished):
(WebKit::QtFileDownloader::onError):
(WebKit::QtFileDownloader::cancel):

  • WebProcess/Downloads/qt/QtFileDownloader.h: Added.
7:59 AM Changeset in webkit [95630] by Philippe Normand
  • 2 edits in trunk/LayoutTests

Unreviewed, skip flaky media test on GTK.

  • platform/gtk/Skipped: Skip media/media-blocked-by-beforeload.html
7:58 AM Changeset in webkit [95629] by abarth@webkit.org
  • 2 edits in trunk/Tools

garden-o-matic command should explain that it is starting a local server
​https://bugs.webkit.org/show_bug.cgi?id=68486

Reviewed by Dimitri Glazkov.

In the user study, both participants didn't understand why the
garden-o-matic command appeared to hang. This patch adds an
explaination of what's going on. It also adds a confirmation prompt
before launching the browser to give the user a chance to read the
text. If that's too much of a speed bump, we can iterate.

  • Scripts/webkitpy/tool/commands/gardenomatic.py:
7:48 AM Changeset in webkit [95628] by Philippe Normand
  • 2 edits in trunk/LayoutTests

Syntax error in media/audio-delete-while-step-button-clicked.html
​https://bugs.webkit.org/show_bug.cgi?id=68507

Reviewed by Eric Carlson.

  • media/audio-delete-while-step-button-clicked.html: Some curly

braces were missing in a try/catch statement.

7:28 AM Changeset in webkit [95627] by gyuyoung.kim@samsung.com
  • 2 edits in trunk/Source/WebKit/efl

[EFL] Fix alphabetical sorting problem
​https://bugs.webkit.org/show_bug.cgi?id=68505

Reviewed by Philippe Normand.

  • ewk/ewk_util.cpp: Fix wrong alphabetical sorting problem.
7:20 AM Changeset in webkit [95626] by commit-queue@webkit.org
  • 7 edits
    1 add in trunk

[Qt] Implement KeyDown function for WebKit2 EventSender.
​https://bugs.webkit.org/show_bug.cgi?id=56485

Tools:

Implement the KeyDown function on Qt platform.

Patch by Chang Shu <​cshu@webkit.org> on 2011-09-21
Reviewed by Andreas Kling.

  • WebKitTestRunner/PlatformWebView.h:
  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::TestController):
(WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):

  • WebKitTestRunner/qt/EventSenderProxyQt.cpp: Added.

(WTR::getModifiers):
(WTR::EventSenderProxy::keyDown):
(buildModifierFlags):
(EventSenderProxy::keyDown):

  • WebKitTestRunner/qt/PlatformWebViewQt.cpp:

(WTR::PlatformWebView::sendEvent):

  • WebKitTestRunner/qt/WebKitTestRunner.pro:

LayoutTests:

Unskip passed tests.

Patch by Chang Shu <​cshu@webkit.org> on 2011-09-21
Reviewed by Andreas Kling.

  • platform/qt-wk2/Skipped:
7:06 AM Changeset in webkit [95625] by loislo@chromium.org
  • 1 edit
    1 add in trunk/LayoutTests

Web Inspector: UI performance test for Resource panel first open experience.
​https://bugs.webkit.org/show_bug.cgi?id=68527

Reviewed by Pavel Feldman.

  • inspector/performance/resources/first-open-resources.html: Added.
7:04 AM Changeset in webkit [95624] by loislo@chromium.org
  • 2 edits
    1 add in trunk/LayoutTests

Web Inspector: extend UI perf tests coverage. Elements panel opens first time.
​https://bugs.webkit.org/show_bug.cgi?id=68432

Reviewed by Pavel Feldman.

  • inspector/performance/resources/first-open-elements.html: Added.
  • inspector/performance/resources/performance-test.js:
6:53 AM Changeset in webkit [95623] by Philippe Normand
  • 2 edits in trunk/LayoutTests

Unreviewed, skip some more flaky SVG tests on GTK.

  • platform/gtk/Skipped:
6:34 AM Changeset in webkit [95622] by jochen@chromium.org
  • 3 edits
    4 copies
    2 moves
    5 adds
    1 delete in trunk/LayoutTests

Unreviewed, fix baselines for cross-origin-xsl-redirect-BLOCKED

  • http/tests/security/cross-origin-xsl-redirect-BLOCKED-expected.txt:
  • platform/chromium-cg-mac/http/tests/security/cross-origin-xsl-redirect-BLOCKED-expected.txt:
  • platform/chromium-mac/http/tests/security/cross-origin-xsl-redirect-BLOCKED-expected.txt:
  • platform/chromium-win/http/tests/security/cross-origin-xsl-redirect-BLOCKED-expected.txt:
  • platform/gtk/http/tests/security/cross-origin-xsl-redirect-BLOCKED-expected.txt: Removed
  • platform/mac-wk2/http/tests/security/cross-origin-xsl-redirect-BLOCKED-expected.txt:
  • platform/qt-wk2/Skipped:
  • platform/qt-wk2/http/tests/security/cross-origin-xsl-redirect-BLOCKED-expected.txt:
  • platform/qt/http/tests/security/cross-origin-xsl-redirect-BLOCKED-expected.png: Removed
  • platform/qt/http/tests/security/cross-origin-xsl-redirect-BLOCKED-expected.txt: Removed
  • platform/win-wk2/http/tests/security/cross-origin-xsl-redirect-BLOCKED-expected.txt:
6:33 AM Changeset in webkit [95621] by pfeldman@chromium.org
  • 9 edits in trunk/Source/WebCore

Web Inspector: paint box model colors in Metrics sidebar at all times, do not draw box outlines.
​https://bugs.webkit.org/show_bug.cgi?id=68240

Today we paint backgrounds in Metrics box model on hover only - should be painted at all
times for the reference. Outlining boxes is highlight is wrong since outlines are outside
the corresponding box regions. We've seen few reports on that + Firebug does not do borders
for that reason.

Reviewed by Yury Semikhatsky.

  • inspector/DOMNodeHighlighter.cpp:
  • inspector/DOMNodeHighlighter.h:
  • inspector/Inspector.json:
  • inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::setHighlightDataFromConfig):

  • inspector/front-end/Color.js:
  • inspector/front-end/MetricsSidebarPane.js:

(WebInspector.MetricsSidebarPane.prototype._highlightDOMNode):
(WebInspector.MetricsSidebarPane.prototype._updateMetrics):

  • inspector/front-end/inspector.css:

(.metrics .label):

  • inspector/front-end/inspector.js:

(WebInspector.buildHighlightConfig):

6:14 AM Changeset in webkit [95620] by keishi@webkit.org
  • 1 edit
    5 adds in trunk/LayoutTests

[chromium] rebaseline caused by r95567

  • platform/chromium-cg-mac-leopard/fast/clip/overflow-border-radius-fixed-position-expected.png: Added.
  • platform/chromium-mac-leopard: Added.
  • platform/chromium-mac-leopard/fast: Added.
  • platform/chromium-mac-leopard/fast/clip: Added.
  • platform/chromium-mac-leopard/fast/clip/overflow-border-radius-fixed-position-expected.png: Added.
6:08 AM Changeset in webkit [95619] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Protect against misuse of EventListenerIterator.
​https://bugs.webkit.org/show_bug.cgi?id=68364

Patch by Andreas Kling <​kling@webkit.org> on 2011-09-21
Reviewed by Darin Adler.

In debug mode, keep track of the number of active EventListenerIterators
on an EventListenerMap, and assert that there are no iterators when the
map is being modified.

  • dom/EventListenerMap.cpp:

(WebCore::EventListenerMap::EventListenerMap):
(WebCore::EventListenerMap::clear):
(WebCore::EventListenerMap::add):
(WebCore::EventListenerMap::remove):
(WebCore::EventListenerMap::find):
(WebCore::EventListenerMap::removeFirstEventListenerCreatedFromMarkup):
(WebCore::EventListenerMap::copyEventListenersNotCreatedFromMarkupToTarget):
(WebCore::EventListenerIterator::EventListenerIterator):
(WebCore::EventListenerIterator::~EventListenerIterator):

  • dom/EventListenerMap.h:
6:05 AM Changeset in webkit [95618] by keishi@webkit.org
  • 2 edits
    4 adds
    2 deletes in trunk/LayoutTests

[chromium] rebaseline caused by r95599

  • fast/dom/HTMLMeterElement/meter-element-repaint-on-update-value-expected.txt: Added.
  • platform/chromium-mac-leopard: Removed.
  • platform/chromium-mac/fast/dom/HTMLMeterElement/meter-element-repaint-on-update-value-expected.png: Added.
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-element-repaint-on-update-value-expected.png: Added.
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-element-repaint-on-update-value-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
  • platform/gtk/fast/dom/HTMLMeterElement/meter-element-repaint-on-update-value-expected.txt: Removed.
5:52 AM Changeset in webkit [95617] by Philippe Normand
  • 2 edits in trunk/LayoutTests

Unreviewed, skip 2 GTK flaky tests.

  • platform/gtk/Skipped: Skip

http/tests/websocket/tests/hixie76/error-detect.html and
svg/zoom/page/zoom-svg-through-object-with-auto-size.html

5:13 AM Changeset in webkit [95616] by alexis.menard@openbossa.org
  • 2 edits in trunk/LayoutTests

[Qt][WK2] Unskip some cookies related layout tests.
​https://bugs.webkit.org/show_bug.cgi?id=68484

Reviewed by Csaba Osztrogonác.

Unskip some cookies related layout tests as they seems to work fine with
--iterations 1000.

  • platform/qt-wk2/Skipped:
4:57 AM Changeset in webkit [95615] by rgabor@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt][Mac] Unreviewed gardening after r95601.

  • platform/qt-mac/Skipped: Paint the Qt-Mac bot green.
4:50 AM Changeset in webkit [95614] by pfeldman@chromium.org
  • 5 edits in trunk/Source/WebCore

Web Inspector: minor fixes in the DOM domain of the protocol.
​https://bugs.webkit.org/show_bug.cgi?id=68517

Reviewed by Yury Semikhatsky.

  • inspector/Inspector.json:
  • inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::setAttributesAsText):

  • inspector/InspectorDOMAgent.h:
  • inspector/front-end/DOMAgent.js:

(WebInspector.DOMNode.prototype.setAttribute):

4:45 AM Changeset in webkit [95613] by pfeldman@chromium.org
  • 6 edits in trunk/Source/WebCore

Web Inspector: limit the use of "Resource" term in the protocol.
​https://bugs.webkit.org/show_bug.cgi?id=68250

Reviewed by Yury Semikhatsky.

  • inspector/Inspector.json:
  • inspector/InspectorResourceAgent.cpp:

(WebCore::InspectorResourceAgent::markResourceAsCached):
(WebCore::InspectorResourceAgent::didLoadResourceFromMemoryCache):
(WebCore::InspectorResourceAgent::setExtraHTTPHeaders):
(WebCore::InspectorResourceAgent::getResponseBody):

  • inspector/InspectorResourceAgent.h:
  • inspector/front-end/ExtensionServer.js:

(WebInspector.ExtensionServer.prototype._onAddRequestHeaders):

  • inspector/front-end/NetworkManager.js:

(WebInspector.NetworkManager.prototype.requestContent):
(WebInspector.NetworkDispatcher.prototype.requestServedFromCache):
(WebInspector.NetworkDispatcher.prototype.requestServedFromMemoryCache):

4:39 AM Changeset in webkit [95612] by commit-queue@webkit.org
  • 8 edits
    12 deletes in trunk

Unreviewed, rolling out r95608.
​http://trac.webkit.org/changeset/95608
​https://bugs.webkit.org/show_bug.cgi?id=68521

breaks GTK and Windows builds. Please check EWS next time.
(Requested by philn-tp on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2011-09-21

Source/WebCore:

  • html/HTMLBodyElement.cpp:

(WebCore::adjustForZoom):
(WebCore::HTMLBodyElement::setScrollLeft):
(WebCore::HTMLBodyElement::setScrollTop):

  • loader/HistoryController.cpp:

(WebCore::HistoryController::saveScrollPositionAndViewStateToItem):

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::scrollX):
(WebCore::DOMWindow::scrollY):
(WebCore::DOMWindow::scrollTo):

  • page/Frame.cpp:

(WebCore::Frame::pageScaleFactor):

  • page/Frame.h:
  • page/FrameView.cpp:

(WebCore::FrameView::applyOverflowToViewport):
(WebCore::FrameView::scrollXForFixedPosition):
(WebCore::FrameView::scrollYForFixedPosition):

LayoutTests:

  • fast/events/scale-and-scroll-body-expected.png: Removed.
  • fast/events/scale-and-scroll-body-expected.txt: Removed.
  • fast/events/scale-and-scroll-body.html: Removed.
  • fast/events/scale-and-scroll-iframe-body-expected.png: Removed.
  • fast/events/scale-and-scroll-iframe-body-expected.txt: Removed.
  • fast/events/scale-and-scroll-iframe-body.html: Removed.
  • fast/events/scale-and-scroll-iframe-window-expected.png: Removed.
  • fast/events/scale-and-scroll-iframe-window-expected.txt: Removed.
  • fast/events/scale-and-scroll-iframe-window.html: Removed.
  • fast/events/scale-and-scroll-window-expected.png: Removed.
  • fast/events/scale-and-scroll-window-expected.txt: Removed.
  • fast/events/scale-and-scroll-window.html: Removed.
4:37 AM Changeset in webkit [95611] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: console panel's scroller is not properly aligned.
​https://bugs.webkit.org/show_bug.cgi?id=68448

Reviewed by Yury Semikhatsky.

  • inspector/front-end/inspector.css:

(#console-view):
(#console-messages):
(#drawer #console-messages):

4:25 AM Changeset in webkit [95610] by Philippe Normand
  • 2 edits
    4 adds in trunk/LayoutTests

Unreviewed, GTK baseslines for 2 new tests and skip a flaky svg test.

  • platform/gtk/Skipped: Skip svg/W3C-SVG-1.1-SE/filters-image-05-f.svg
  • platform/gtk/fast/clip/overflow-border-radius-fixed-position-expected.png: Added.
  • platform/gtk/fast/clip/overflow-border-radius-fixed-position-expected.txt: Added.
  • platform/gtk/fast/dom/HTMLMeterElement/meter-element-repaint-on-update-value-expected.png: Added.
  • platform/gtk/fast/dom/HTMLMeterElement/meter-element-repaint-on-update-value-expected.txt: Added.
4:16 AM Changeset in webkit [95609] by rgabor@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt][WK2] http/tests/security/cross-origin-xsl-redirect-BLOCKED.html fails
​https://bugs.webkit.org/show_bug.cgi?id=68515

  • platform/qt-wk2/Skipped: Skip http/tests/security/cross-origin-xsl-redirect-BLOCKED.html.
4:01 AM Changeset in webkit [95608] by hclam@chromium.org
  • 8 edits
    12 adds in trunk

Source/WebCore: ​https://bugs.webkit.org/show_bug.cgi?id=68081
Fix scroll in page scaling mode.

Reviewed by Simon Fraser.

The following things are done in this patch:

  1. Rename Frame::pageScaleFactor() to Frame::frameScaleFactor() to better reflect its purpose.
  2. Frame::frameScaleFactor() returns the scale factor of this frame with respect to the container. So for the main frame it'll return the scale factor of the page, inner frames will return 1.0
  3. scrollBy(), scrollX() and scrollY() to take into account of the frame scale factor, causing incorrect coordinates reported to Javascript.

Tests: fast/events/scale-and-scroll-body.html

fast/events/scale-and-scroll-iframe-body.html
fast/events/scale-and-scroll-iframe-window.html
fast/events/scale-and-scroll-window.html

  • html/HTMLBodyElement.cpp:

(WebCore::adjustForZoom):
(WebCore::HTMLBodyElement::setScrollLeft):
(WebCore::HTMLBodyElement::setScrollTop):

  • loader/HistoryController.cpp:

(WebCore::HistoryController::saveScrollPositionAndViewStateToItem):

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::scrollX):
(WebCore::DOMWindow::scrollY):
(WebCore::DOMWindow::scrollTo):

  • page/Frame.cpp:

(WebCore::Frame::frameScaleFactor): Return page's scale factor if this is

main frame, otherwise 1.0

  • page/Frame.h:
  • page/FrameView.cpp:

(WebCore::FrameView::applyOverflowToViewport):
(WebCore::FrameView::scrollXForFixedPosition):
(WebCore::FrameView::scrollYForFixedPosition):

LayoutTests: ​https://bugs.webkit.org/show_bug.cgi?id=68081
Add layout test for page scale and scrolling.

Reviewed by Simon Fraser.

Add tests to cover the following cases:

  1. Scale and scroll window
  2. Scale and scroll document.body
  3. Scale and scroll iframe's contentWindow
  4. Scale and scroll iframe's contentDocument.body
  • fast/events/scale-and-scroll-body-expected.png: Added.
  • fast/events/scale-and-scroll-body-expected.txt: Added.
  • fast/events/scale-and-scroll-body.html: Added.
  • fast/events/scale-and-scroll-iframe-body-expected.png: Added.
  • fast/events/scale-and-scroll-iframe-body-expected.txt: Added.
  • fast/events/scale-and-scroll-iframe-body.html: Added.
  • fast/events/scale-and-scroll-iframe-window-expected.png: Added.
  • fast/events/scale-and-scroll-iframe-window-expected.txt: Added.
  • fast/events/scale-and-scroll-iframe-window.html: Added.
  • fast/events/scale-and-scroll-window-expected.png: Added.
  • fast/events/scale-and-scroll-window-expected.txt: Added.
  • fast/events/scale-and-scroll-window.html: Added.
3:16 AM Changeset in webkit [95607] by mrowe@apple.com
  • 2 edits in trunk/Source/WebKit2

<rdar://problem/9890932> "Open PDF in Preview" on two PDFs of the same name does nothing the second time

The logic in PDFViewController::pathToPDFOnDisk that deals with constructing a unique
file name if a file of the suggested name already exists was incorrect. It was appending
the template used by mkstemps to the directory name component of the path rather than
using it as a prefix on the filename portion of the path. This resulted in a template path
like WebKitPDFs-ABCDEFXXXXXX-/foo.pdf where WebKitPDFs-ABCDEF/XXXXXX-foo.pdf was expected.

Reviewed by Jon Honeycutt.

  • UIProcess/API/mac/PDFViewController.mm:

(WebKit::PDFViewController::pathToPDFOnDisk): Append the template as a new path component,
then append the suggested file name to that component.

2:49 AM Changeset in webkit [95606] by Philippe Normand
  • 4 edits in trunk/LayoutTests

Unreviewed, GTK rebaseline, skip some flaky worker tests and 2
failing http tests.

  • platform/gtk/Skipped:
  • platform/gtk/editing/deleting/regional-indicators-expected.txt:
  • platform/gtk/fast/text/justify-ideograph-complex-expected.txt:
2:19 AM Changeset in webkit [95605] by Philippe Normand
  • 3 edits
    1 add in trunk/LayoutTests

Unreviewed, GTK rebaseline and skip and a11y failing test.

  • platform/gtk/Skipped: Skip accessibility/aria-hidden-updates-alldescendants.html
  • platform/gtk/editing/deleting/merge-whitespace-pre-expected.txt:

Rebaseline after r95335.

  • platform/gtk/http/tests/security/cross-origin-xsl-redirect-BLOCKED-expected.txt: Added.
1:59 AM Changeset in webkit [95604] by abecsi@webkit.org
  • 18 edits in trunk/Source

[Qt] Remove Qt specific code from css/SelectorChecker.cpp
​https://bugs.webkit.org/show_bug.cgi?id=67702

Reviewed by Csaba Osztrogonác.

Source/WebCore:

No new tests needed.

  • css/SelectorChecker.cpp: Move Qt-specific code to the Qt-specific WebPlatformStrategies.

(WebCore::SelectorChecker::determineLinkStateSlowCase):

  • platform/VisitedLinkStrategy.h:

Source/WebKit/mac:

  • WebCoreSupport/WebPlatformStrategies.h:
  • WebCoreSupport/WebPlatformStrategies.mm:

(WebPlatformStrategies::isLinkVisited):

Source/WebKit/qt:

  • WebCoreSupport/WebPlatformStrategies.cpp: Check the Qt global history here, instead of a platform independent file.

(WebPlatformStrategies::isLinkVisited):

  • WebCoreSupport/WebPlatformStrategies.h:

Source/WebKit/win:

  • WebCoreSupport/WebPlatformStrategies.cpp: Modify to match new prototype.

(WebPlatformStrategies::isLinkVisited):

  • WebCoreSupport/WebPlatformStrategies.h: Ditto.

Source/WebKit/wince:

  • WebCoreSupport/PlatformStrategiesWinCE.cpp:

(PlatformStrategiesWinCE::addVisitedLink):

  • WebCoreSupport/PlatformStrategiesWinCE.h:

Source/WebKit2:

  • WebProcess/WebCoreSupport/WebPlatformStrategies.cpp: Modify to match new prototype.

(WebKit::WebPlatformStrategies::isLinkVisited):
(WebKit::WebPlatformStrategies::addVisitedLink):

  • WebProcess/WebCoreSupport/WebPlatformStrategies.h: Ditto.
1:41 AM Changeset in webkit [95603] by Philippe Normand
  • 2 edits in trunk/LayoutTests

Unreviewed, GTK rebaseline after r95566.

  • platform/gtk/mathml/xHeight-expected.txt:
12:09 AM Changeset in webkit [95602] by morrita@google.com
  • 2 edits in trunk/LayoutTests

Unreviewed Skipped list update for meter-element-repaint-on-update-value.html,
which needs windows

  • platform/win/Skipped:
12:01 AM Changeset in webkit [95601] by Csaba Osztrogonác
  • 3 edits
    6 adds in trunk/LayoutTests

[Qt] Unreviewed gardening.

  • platform/qt-mac/Skipped:
  • platform/qt-wk2/Skipped:
  • platform/qt/fast/clip/overflow-border-radius-fixed-position-expected.png: Added.
  • platform/qt/fast/clip/overflow-border-radius-fixed-position-expected.txt: Added.
  • platform/qt/fast/dom/HTMLMeterElement/meter-element-repaint-on-update-value-expected.png: Added.
  • platform/qt/fast/dom/HTMLMeterElement/meter-element-repaint-on-update-value-expected.txt: Added.
  • platform/qt/http/tests/security/cross-origin-xsl-redirect-BLOCKED-expected.png: Added.
  • platform/qt/http/tests/security/cross-origin-xsl-redirect-BLOCKED-expected.txt: Added.

Sep 20, 2011:

11:31 PM WikiStart edited by larry3930@gmail.com
(diff)
10:58 PM Changeset in webkit [95600] by morrita@google.com
  • 4 edits in trunk/Source/WebCore

Style changes on forwarded shadow children should trigger shadow renderer reconstruction.
​https://bugs.webkit.org/show_bug.cgi?id=68228

Reviewed by Dimitri Glazkov.

Currently style changes on forwarded shadow child triggers
Node::reattach() only for the forwarded node. But it should
invalidate whole renderers on the shadow tree because
ShadowContentElement expects its inclusions to be attached and to
create renderers in the inclusion order. But single node
reattach() violates the expectation and possibly creates
inconsistent render tree.

This change makes NodeRenderingContext to go
AttachContentForwarded, where the ShadowContentElement::attach()
happens, only during ShadowRoot::attach(), not for style-change
triggered Node::attach() on the forwarded nodes.

Note that the altering phase AttachContentLight doesn't create
renderers for the forwarded nodes. Instead of that, it possibly
triggers shadow subtree reconstruction on
NodeRenderingContext::hostChildrenChanged().

No new tests. This is a defensive change. There is no visible
difference at this time.

  • dom/NodeRenderingContext.cpp:

(WebCore::NodeRenderingContext::NodeRenderingContext):

  • dom/ShadowRoot.cpp:

(WebCore::ShadowRoot::isInclusionSelectorActive):

  • dom/ShadowRoot.h:
10:41 PM Changeset in webkit [95599] by morrita@google.com
  • 7 edits
    3 adds in trunk

<meter> doesn't update rendering when its value is changed.
​https://bugs.webkit.org/show_bug.cgi?id=67614

Reviewed by Dimitri Glazkov.

Source/WebCore:

It lacks repaint() when the value is changed.

For non-native appearance it works because the indicator is
implemented in shadow DOM, for native appearance, repainting should be
handled explicitly.

Test: fast/dom/HTMLMeterElement/meter-element-repaint-on-update-value.html

  • html/HTMLMeterElement.cpp:

(WebCore::HTMLMeterElement::didElementStateChange):

  • rendering/RenderMeter.cpp:

(WebCore::RenderMeter::updateFromElement):

  • rendering/RenderMeter.h:
  • rendering/RenderProgress.cpp:

(WebCore::RenderProgress::updateAnimationState):

LayoutTests:

  • fast/dom/HTMLMeterElement/meter-element-repaint-on-update-value-expected.png: Added.
  • platform/chromium/test_expectations.txt:
  • platform/mac/dom/HTMLMeterElement/meter-element-repaint-on-update-value-expected.txt: Added.
  • platform/mac/dom/HTMLMeterElement/meter-element-repaint-on-update-value.html: Added.
10:38 PM Changeset in webkit [95598] by tkent@chromium.org
  • 3 edits in trunk/Source/WebCore

Move RenderObject::markContainingBlocksForLayout() to RenderObject.cpp.
​https://bugs.webkit.org/show_bug.cgi?id=67989

Reviewed by Ryosuke Niwa.

No new tests because of no behavior change.

  • rendering/RenderObject.cpp:

(WebCore::objectIsRelayoutBoundary): Moved from RenderObject.h.
(WebCore::RenderObject::markContainingBlocksForLayout): Moved from RenderObject.h

  • rendering/RenderObject.h:
10:23 PM Changeset in webkit [95597] by keishi@webkit.org
  • 2 edits in trunk/LayoutTests

[chromium] changed test expectations for zoom-svg-through-object-with-auto-size.html:wq

  • platform/chromium/test_expectations.txt:
9:19 PM Changeset in webkit [95596] by ggaren@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

Some Heap cleanup.

Reviewed by Beth Dakin.

  • heap/MarkedBlock.cpp:

(JSC::MarkedBlock::blessNewBlock): Removed blessNewBlockForSlowPath()
because it was unused; renamed blessNewBlockForFastPath() to blessNewBlock()
since there is only one now.

  • heap/MarkedBlock.h: Removed ownerSet-related stuff since it was unused.

Updated mark bit overhead calculation. Deployed atomsPerBlock in one
place where we were recalculating it.

  • heap/MarkedSpace.cpp:

(JSC::MarkedSpace::addBlock): Updated for rename.

8:37 PM Changeset in webkit [95595] by abarth@webkit.org
  • 5 edits in trunk/Tools

garden-o-matic unit test fail because Safari 5.1 doesn't enumerate dictionaries in the same order as V8
​https://bugs.webkit.org/show_bug.cgi?id=68496

Reviewed by Dimitri Glazkov.

This patch adds a bunch of sorting to make sure things happen in a
predictable order in both JavaScriptCore and V8. We've talked before
about whether these two JavaScript engines should enumerate
dictionaries in the same order, but the consensus has been that they
shouldn't. Personally, I disagree with that consensus, but such is life.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
7:22 PM Changeset in webkit [95594] by fpizlo@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

DFG JIT always speculates integer on modulo
​https://bugs.webkit.org/show_bug.cgi?id=68485

Reviewed by Oliver Hunt.

Added support for double modulo, which is a call to fmod().
Also added support for recording the old JIT's statistics
on op_mod and propagating them along the graph. Finally,
fixed a goof in the ArithNodeFlags propagation logic that
was made obvious when I started testing ArithMod.

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::makeSafe):
(JSC::DFG::ByteCodeParser::parseBlock):

  • dfg/DFGNode.h:

(JSC::DFG::Node::hasArithNodeFlags):

  • dfg/DFGPropagator.cpp:

(JSC::DFG::Propagator::propagateArithNodeFlags):
(JSC::DFG::Propagator::propagateNodePredictions):
(JSC::DFG::Propagator::fixupNode):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compile):

6:49 PM Changeset in webkit [95593] by commit-queue@webkit.org
  • 14 edits in trunk/Source/WebCore

Support for multiple <link rel="icon"> favicon elements.
​https://bugs.webkit.org/show_bug.cgi?id=65564

Patch by Rachel Blum <​groby@chromium.org> on 2011-09-20
Reviewed by Darin Fisher.

No tests - purely an API change. (And API is not exposed to LayoutTests)

  • dom/Document.cpp:

(WebCore::Document::iconURLs):
(WebCore::Document::addIconURL):

  • dom/Document.h:
  • dom/IconURL.cpp:

(WebCore::toIconIndex):

  • dom/IconURL.h:

(WebCore::IconURL::IconURL):

  • html/HTMLLinkElement.cpp:

(WebCore::HTMLLinkElement::process):

  • loader/LinkLoader.cpp:

(WebCore::LinkLoader::loadLink):

  • loader/LinkLoader.h:
  • loader/icon/IconController.cpp:

(WebCore::IconController::urlsForTypes):
(WebCore::IconController::appendToIconURLs):
(WebCore::IconController::defaultURL):

6:48 PM Changeset in webkit [95592] by abarth@webkit.org
  • 2 edits in trunk/Tools

garden-o-matic doesn't work in Safari 5.1 because Safari 5.1 lacks Function.prototype.bind
​https://bugs.webkit.org/show_bug.cgi?id=68495

Reviewed by Dimitri Glazkov.

This patch adds an implementation of Function.prototype.bind if the browser lacks one.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
6:30 PM Changeset in webkit [95591] by ojan@chromium.org
  • 3 edits in trunk/Source/WebCore

[css3-flexbox] cleanup padding width calculations
​https://bugs.webkit.org/show_bug.cgi?id=68490

Reviewed by Tony Chang.

No new tests. Existing tests cover the refactor.

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::logicalBorderAndPaddingWidthForChild):
(WebCore::RenderFlexibleBox::logicalScrollbarHeightForChild):
(WebCore::RenderFlexibleBox::preferredLogicalContentWidthForFlexItem):
(WebCore::RenderFlexibleBox::computePreferredLogicalWidth):
(WebCore::RenderFlexibleBox::layoutAndPlaceChildrenInlineDirection):

  • rendering/RenderFlexibleBox.h:
6:07 PM Changeset in webkit [95590] by jcivelli@chromium.org
  • 2 edits
    2 adds in trunk/Source/WebKit/chromium

This CL makes it possible to create a blob from Chromium.
​https://bugs.webkit.org/show_bug.cgi?id=68286

Reviewed by Darin Fisher.

  • WebKit.gyp:
  • public/WebBlob.h: Added.
  • src/WebBlob.cpp: Added.
6:04 PM Changeset in webkit [95589] by keishi@webkit.org
  • 1 edit
    5 adds
    1 delete in trunk/LayoutTests

[chromium] rebaseline caused by r95567

  • platform/chromium-cg-mac/fast/clip/overflow-border-radius-fixed-position-expected.png: Added.
  • platform/chromium-linux-x86/fast/clip: Removed.
  • platform/chromium-linux/fast/clip/overflow-border-radius-fixed-position-expected.png: Added.
  • platform/chromium-mac/fast/clip/overflow-border-radius-fixed-position-expected.png: Added.
  • platform/chromium-win/fast/clip/overflow-border-radius-fixed-position-expected.png: Added.
  • platform/chromium-win/fast/clip/overflow-border-radius-fixed-position-expected.txt: Added.
5:48 PM Changeset in webkit [95588] by eric@webkit.org
  • 4 edits in trunk

[NRWT] REGRESSION: Local loader tests are failing on machines that lost /tmp/LayoutTests symlink
​https://bugs.webkit.org/show_bug.cgi?id=65781

Reviewed by Ryosuke Niwa.

Instead of making NRWT create the symlink, I made DumpRenderTree smart enough
to resolve the passed in url relative to the absolute url for the test.
For http tests, since the test url is an http url, we can't resolve relative
to the test path, and thus use a new LOCAL_RESOURCE_ROOT environment variable
for resolving.

I believe this is a better approach than the on used in the Qt and Chromium DRT's
(which resolves the path relative to the built location of the DRT executable)
and we should move this new code into a shared location in a follow-up patch.

It turns out that there was a second use for pathToLocalResource, used by one
test (http/tests/plugins/post-url-file.html) used for getting a path to /tmp.
To support this test I made the new pathToLocalResource smart enough to map
/tmp to DUMPRENDERTREE_TEMP (which is already defined for all ports).

  • DumpRenderTree/mac/LayoutTestControllerMac.mm:

(LayoutTestController::pathToLocalResource):

  • Scripts/webkitpy/layout_tests/port/webkit.py: Set LOCAL_RESOURCE_ROOT for use by DRT.
5:34 PM Changeset in webkit [95587] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

Need to specify a django version, instead of using default
​https://bugs.webkit.org/show_bug.cgi?id=68398

Patch by Tom Zakrajsek <​tomz@codeaurora.org> on 2011-09-20
Reviewed by Eric Seidel.

  • QueueStatusServer/init.py:
  • QueueStatusServer/main.py:
5:16 PM Changeset in webkit [95586] by jer.noble@apple.com
  • 3 edits in trunk/Source/WebCore

Fix clang compile errors in Web Audio
​https://bugs.webkit.org/show_bug.cgi?id=68384

Reviewed by David Levin.

No new tests; no net change in functionality.

  • platform/graphics/MediaPlayer.h: Forward declare (instead of including directly)

AudioSourceProvider.

  • webaudio/AudioChannelMerger.cpp:

(WebCore::AudioChannelMerger::checkNumberOfChannelsForInput): Remove unused parameter name.

5:05 PM Changeset in webkit [95585] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit2

Get rid of PluginView::setBoundsSize from WebKit2
​https://bugs.webkit.org/show_bug.cgi?id=68489

Reviewed by Dan Bernstein.

Remove m_boundsSize and the setter since they aren't used anywhere.

  • WebProcess/Plugins/PluginView.cpp:
  • WebProcess/Plugins/PluginView.h:
5:04 PM Changeset in webkit [95584] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Update committers.py with a few more contributor contacts
​https://bugs.webkit.org/show_bug.cgi?id=68487

Patch by Tom Zakrajsek <​tomz@codeaurora.org> on 2011-09-20
Reviewed by Eric Seidel.

  • Scripts/webkitpy/common/config/committers.py:
4:53 PM Changeset in webkit [95583] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Fix webkitpy unit tests after 95547 and 95549
​https://bugs.webkit.org/show_bug.cgi?id=68483

Patch by Leandro Pereira <​leandro@profusion.mobi> on 2011-09-20
Reviewed by Adam Barth.

Fix tests for ChangeLog.touched_files() and ChangeLog.parse_entries_from_file().

  • Scripts/webkitpy/common/checkout/changelog_unittest.py: While testing

parse_entries_from_file(), use StringIO and entry.reviewer_text().
While testing parse_latest_entry_from_file(), expect the correct
touched_files() list.

4:49 PM Changeset in webkit [95582] by johnnyg@google.com
  • 4 edits in trunk

Directory Upload: parent path can truncate first char of the correct path
​https://bugs.webkit.org/show_bug.cgi?id=66695

Source/WebCore:

In some cases, if the parent path we compute ends with a separator
character like '/' or 'C:\', by adding one in an attempt to grab the
subsequent separator we actually grab a character of the real path,
which is incorrect.

Reviewed by Darin Fisher.

  • html/FileInputType.cpp:

(WebCore::FileInputType::setFileList):

LayoutTests:

Add a test case for when the parent path is '/'.

Reviewed by Darin Fisher.

  • fast/forms/input-file-directory-upload.html:
4:43 PM Changeset in webkit [95581] by abarth@webkit.org
  • 2 edits in trunk/Tools

garden-o-matic makes it hard to compare images when scroll bars appear
​https://bugs.webkit.org/show_bug.cgi?id=68482

Reviewed by Eric Seidel.

Because we autoscale image width, the images rescale if we overflow
vertically and get a scrollbar. That makes it hard to compare two sets
of images. This patch reserves space for the scrollbar so we won't
have the layout change.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/common.css:
4:31 PM Changeset in webkit [95580] by jochen@chromium.org
  • 6 edits
    3 adds in trunk

Invoke CachedResourceLoader::canRequest for all URLs in a redirect chain
​https://bugs.webkit.org/show_bug.cgi?id=68279

Reviewed by Adam Barth.

Source/WebCore:

  • loader/cache/CachedResourceLoader.h:
  • loader/cache/CachedResourceRequest.cpp:

(WebCore::CachedResourceRequest::willSendRequest):

LayoutTests:

  • http/tests/security/resources/cross-origin-xsl-redirect.xml:
  • http/tests/security/cross-origin-xsl-redirect-BLOCKED-expected.txt:
  • http/tests/security/cross-origin-xsl-redirect-BLOCKED.html:
  • platform/chromium/http/tests/permissionclient/image-permissions-expected.txt:
  • platform/chromium/http/tests/permissionclient/image-permissions.html:
4:17 PM Changeset in webkit [95579] by rniwa@webkit.org
  • 2 edits in trunk/Websites/webkit.org

Generate WebKit team's page out of committers.py
​https://bugs.webkit.org/show_bug.cgi?id=68045

Fix per Daniel's review comment since I had misunderstood the code.

  • team.html:
3:57 PM Changeset in webkit [95578] by rniwa@webkit.org
  • 1 edit
    1 add in trunk/Websites/webkit.org

Generate WebKit team's page out of committers.py
​https://bugs.webkit.org/show_bug.cgi?id=68045

Reviewed by Daniel Bates.

Add the initial implementation of team.html. This page automatically pulls data from committers.py
There are no areas of expertise but that'll be added once the bug 68061 is fixed.

  • team.html: Added.
3:46 PM Changeset in webkit [95577] by ojan@chromium.org
  • 7 edits
    2 adds in trunk

change RenderFlexibleBox to act on logical coordinates
​https://bugs.webkit.org/show_bug.cgi?id=68129

Reviewed by David Hyatt.

Source/WebCore:

This makes RenderFlexibleBox respect direction and writing-mode.
We now properly support the default flex-flow value of "row".

Test: css3/flexbox/writing-modes.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::setLogicalLocationForChild):

  • rendering/RenderBlock.h:
  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::layoutBlock):
(WebCore::RenderFlexibleBox::logicalBorderWidthForChild):
(WebCore::RenderFlexibleBox::logicalPaddingWidthForChild):
(WebCore::RenderFlexibleBox::logicalScrollbarHeightForChild):
(WebCore::RenderFlexibleBox::marginStartStyleForChild):
(WebCore::RenderFlexibleBox::marginEndStyleForChild):
(WebCore::RenderFlexibleBox::preferredLogicalContentWidthForFlexItem):
(WebCore::RenderFlexibleBox::layoutInlineDirection):
(WebCore::RenderFlexibleBox::logicalPositiveFlexForChild):
(WebCore::RenderFlexibleBox::logicalNegativeFlexForChild):
(WebCore::RenderFlexibleBox::computePreferredLogicalWidth):
(WebCore::RenderFlexibleBox::runFreeSpaceAllocationAlgorithmInlineDirection):
(WebCore::RenderFlexibleBox::setLogicalOverrideSize):
(WebCore::RenderFlexibleBox::layoutAndPlaceChildrenInlineDirection):

  • rendering/RenderFlexibleBox.h:

LayoutTests:

  • css3/flexbox/resources/flexbox.js:
  • css3/flexbox/writing-modes-expected.txt: Added.
  • css3/flexbox/writing-modes.html: Added.
3:39 PM Changeset in webkit [95576] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Use DEFINE_STATIC_LOCAL to intentionally leak the static RefCountedHFONT object returned from
FontPlatformData::hashTableDeletedFontValue() to avoid global destructor ordering problems.
​https://bugs.webkit.org/show_bug.cgi?id=67906

Patch by Marshall Greenblatt <​marshall@chromium.org> on 2011-09-20
Reviewed by Adam Barth.

  • platform/graphics/chromium/FontPlatformDataChromiumWin.cpp:
3:37 PM Changeset in webkit [95575] by jochen@chromium.org
  • 3 edits in trunk/Source/WebKit/chromium

[chromium] remove obsolete WebPermissionClient::allowImages method
​https://bugs.webkit.org/show_bug.cgi?id=68380

Reviewed by Darin Fisher.

  • DEPS:
  • public/WebPermissionClient.h:

(WebKit::WebPermissionClient::allowImage):

3:33 PM Changeset in webkit [95574] by rniwa@webkit.org
  • 3 edits
    4 adds in trunk

Hit testing on margins of body and head elements doesn't recur
​https://bugs.webkit.org/show_bug.cgi?id=40753

Reviewed by Darin Adler.

Source/WebCore:

The bug was caused by positionForPointRespectingEditingBoundaries's comparing the editability
of head/body and html elements when hit testing was done inside margins of head and body elements.

Fixed the bug by special-casing html element since margins of head and body elements are special.

Tests: editing/selection/click-on-body-margin.html

editing/selection/click-on-head-margin.html

  • rendering/RenderBlock.cpp:

(WebCore::positionForPointRespectingEditingBoundaries):

LayoutTests:

Add tests to click on margins of head and body elements. WebKit should not
(attempt to) place the caret after or before head and body elements.

  • editing/selection/click-on-body-margin-expected.txt: Added.
  • editing/selection/click-on-body-margin.html: Added.
  • editing/selection/click-on-head-margin-expected.txt: Added.
  • editing/selection/click-on-head-margin.html: Added.
3:23 PM Changeset in webkit [95573] by hyatt@apple.com
  • 9 edits in trunk/Source/WebCore

​https://bugs.webkit.org/show_bug.cgi?id=68480

De-virtualize containingBlock() and make RenderView return 0 instead
of itself to make the construction of normal loops that terminate via
a null-check possible.

Fix the only two places in the tree that needed null checks.

Eliminating RenderTableCell::containingBlock() is fine since the base class
does the same thing anyway.

Reviewed by Simon Fraser.

  • editing/VisiblePosition.cpp:

(WebCore::VisiblePosition::lineDirectionPointForBlockDirectionNavigation):

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::containingBlock):

  • rendering/RenderObject.h:
  • rendering/RenderTableCell.cpp:
  • rendering/RenderTableCell.h:
  • rendering/RenderTreeAsText.cpp:

(WebCore::RenderTreeAsText::writeRenderObject):

  • rendering/RenderView.cpp:
  • rendering/RenderView.h:
3:16 PM Changeset in webkit [95572] by commit-queue@webkit.org
  • 2 edits
    1 add in trunk/Source/WebKit2

[Qt] QTouchWebView missing signal tests for loadProgress
​https://bugs.webkit.org/show_bug.cgi?id=68442

Patch by Gopal Raghavan <​gopal.1.raghavan@nokia.com> on 2011-09-20
Reviewed by Chang Shu.

Added test case to check load progress signal for QTouchWebView

  • UIProcess/API/qt/tests/qmltests/TouchWebView/tst_loadProgressSignal.qml: Added.
  • UIProcess/API/qt/tests/qmltests/qmltests.pro:
2:59 PM Changeset in webkit [95571] by commit-queue@webkit.org
  • 2 edits
    2 adds in trunk/LayoutTests

[CSSRegions] Need test case for 66198 (sliced line box rendering)
​https://bugs.webkit.org/show_bug.cgi?id=68257

Patch by Alan Stearns <​stearns@adobe.com> on 2011-09-20
Reviewed by David Hyatt.

  • fast/regions/resources/helper.js:

(assertTopLeftMatch):
(sameTopLeft):

  • fast/regions/no-split-line-box-expected.txt: Added.
  • fast/regions/no-split-line-box.html: Added.
2:47 PM Changeset in webkit [95570] by andersca@apple.com
  • 7 edits in trunk/Source

Remove ScrollView::platformContentsSize
​https://bugs.webkit.org/show_bug.cgi?id=68188

Reviewed by Darin Adler.

../WebCore:

Since ScrollView keeps track of the contents size in ScrollView::m_contentsSize, we never
have to ask the underlying platform scroll view for contents size since it should always just
be equal to m_contentsSize.

  • platform/ScrollView.cpp:

(WebCore::ScrollView::contentsSize):
(WebCore::ScrollView::wheelEvent):

  • platform/ScrollView.h:
  • platform/mac/ScrollViewMac.mm:
  • platform/wx/ScrollViewWx.cpp:

../WebKit/mac:

When creating the document view, make sure it's zero sized which matches the initial size
of the ScrollView. This is fine to do early since DocumentWriter::begin sets the contents
size to a zero size anyway.

  • WebView/WebFrameView.mm:

(-[WebFrameView _makeDocumentViewForDataSource:]):

2:14 PM Changeset in webkit [95569] by commit-queue@webkit.org
  • 5 edits
    2 deletes in trunk

Unreviewed, rolling out r95565.
​http://trac.webkit.org/changeset/95565
​https://bugs.webkit.org/show_bug.cgi?id=68470

Broke builds (Requested by andersca on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2011-09-20

Source/WebKit2:

  • GNUmakefile.am:
  • Shared/API/c/WKHitTestResult.cpp: Removed.
  • Shared/API/c/WKHitTestResult.h: Removed.
  • UIProcess/API/C/WebKit2.h:

Tools:

  • MiniBrowser/gtk/BrowserWindow.c:

(mouseDidMoveOverElement):

2:08 PM Rebaseline edited by scottmg@chromium.org
example out of date (?) (diff)
2:01 PM Changeset in webkit [95568] by alexis.menard@openbossa.org
  • 9 edits
    1 add in trunk/Source

[Qt] [WK2] Implement a persistent cookie storage.
​https://bugs.webkit.org/show_bug.cgi?id=65309

Reviewed by Chang Shu.

Source/WebCore:

Implement a cookie storage for the Qt port on WebKit2.
The implementation is using a SQLite database to store the cookies
and restore them. It uses a static object as CookieJar is not an
object but a set of global functions. The actual saving/restoring is on
the WebProcess side where our network stack lives.

Existing tests cover the new implementation. Unfortunately there is one
case that we can't easily simulate : login in a website, make sure that the webprocess
is not running and then going back to this website and see that we are logged.

  • WebCore.pri:
  • WebCore.pro:
  • platform/qt/CookieJarQt.cpp:

(WebCore::getHostnamesWithCookies):
(WebCore::deleteCookiesForHostname):
(WebCore::deleteAllCookies):
(WebCore::SharedCookieJarQt::shared):
(WebCore::SharedCookieJarQt::create):
(WebCore::SharedCookieJarQt::destroy):
(WebCore::SharedCookieJarQt::getHostnamesWithCookies):
(WebCore::SharedCookieJarQt::deleteCookiesForHostname):
(WebCore::SharedCookieJarQt::deleteAllCookies):
(WebCore::SharedCookieJarQt::SharedCookieJarQt):
(WebCore::SharedCookieJarQt::~SharedCookieJarQt):
(WebCore::SharedCookieJarQt::setCookiesFromUrl):
(WebCore::SharedCookieJarQt::ensureDatabaseTable):
(WebCore::SharedCookieJarQt::loadCookies):

  • platform/qt/CookieJarQt.h: Added.

Source/WebKit2:

Add parameter to the WebProcess creation to specify where cookies should be saved.
It also use the new cookie storage implementation and set it to our network stack
so cookies are used when using it.

  • Shared/WebProcessCreationParameters.cpp:

(WebKit::WebProcessCreationParameters::encode):
(WebKit::WebProcessCreationParameters::decode):

  • Shared/WebProcessCreationParameters.h:
  • UIProcess/qt/WebContextQt.cpp:

(WebKit::WebContext::platformInitializeWebProcess):

  • WebProcess/qt/WebProcessQt.cpp:

(WebKit::WebProcess::platformInitializeWebProcess):
(WebKit::WebProcess::platformTerminate):

1:26 PM Changeset in webkit [95567] by hyatt@apple.com
  • 3 edits
    3 adds in trunk

Source/WebCore: ​https://bugs.webkit.org/show_bug.cgi?id=68314

Make sure that the containing block loop when clipping to border-radius
terminates by checking if you hit the RenderView. Null checking isn't sufficient
for stupid historical reasons that should be fixed (i.e., the RenderView returns itself
as its own containing block, even though this should just be changed).

Reviewed by Simon Fraser and Darin Adler.

Added new test in fast/clip.

  • rendering/RenderLayer.cpp:

(WebCore::inContainingBlockChain):

LayoutTests: ​https://bugs.webkit.org/show_bug.cgi?id=68314

Added some more clipping tests for overflow to make sure the right things happen
when border-radius is specified.

Reviewed by Simon Fraser and Darin Adler.

  • fast/clip/overflow-border-radius-fixed-position.html: Added.
  • platform/mac/fast/clip/overflow-border-radius-fixed-position-expected.png: Added.
  • platform/mac/fast/clip/overflow-border-radius-fixed-position-expected.txt: Added.
1:21 PM Changeset in webkit [95566] by mitz@apple.com
  • 38 edits in trunk

MathML renderers do not override RenderObject::renderName()
​https://bugs.webkit.org/show_bug.cgi?id=68461

Reviewed by Darin Adler.

Source/WebCore:

Added implementations of renderName() in MathML RenderObject subclasses.

  • rendering/mathml/RenderMathMLBlock.h:

(WebCore::RenderMathMLBlock::renderName):

  • rendering/mathml/RenderMathMLFenced.h:

(WebCore::RenderMathMLFenced::renderName):

  • rendering/mathml/RenderMathMLFraction.h:

(WebCore::RenderMathMLFraction::renderName):

  • rendering/mathml/RenderMathMLMath.h:

(WebCore::RenderMathMLMath::renderName):

  • rendering/mathml/RenderMathMLOperator.h:

(WebCore::RenderMathMLOperator::renderName):

  • rendering/mathml/RenderMathMLRoot.h:

(WebCore::RenderMathMLRoot::renderName):

  • rendering/mathml/RenderMathMLRow.h:

(WebCore::RenderMathMLRow::renderName):

  • rendering/mathml/RenderMathMLSquareRoot.h:

(WebCore::RenderMathMLSquareRoot::renderName):

  • rendering/mathml/RenderMathMLSubSup.h:

(WebCore::RenderMathMLSubSup::renderName):

  • rendering/mathml/RenderMathMLUnderOver.h:

(WebCore::RenderMathMLUnderOver::renderName):

LayoutTests:

  • platform/mac/mathml/presentation/attributes-expected.txt:
  • platform/mac/mathml/presentation/fenced-expected.txt:
  • platform/mac/mathml/presentation/fenced-mi-expected.txt:
  • platform/mac/mathml/presentation/fractions-expected.txt:
  • platform/mac/mathml/presentation/fractions-vertical-alignment-expected.txt:
  • platform/mac/mathml/presentation/mo-expected.txt:
  • platform/mac/mathml/presentation/msub-base-changed-expected.txt:
  • platform/mac/mathml/presentation/msub-sub-changed-expected.txt:
  • platform/mac/mathml/presentation/msubsup-base-changed-expected.txt:
  • platform/mac/mathml/presentation/msubsup-sub-changed-expected.txt:
  • platform/mac/mathml/presentation/msubsup-sup-changed-expected.txt:
  • platform/mac/mathml/presentation/msup-base-changed-expected.txt:
  • platform/mac/mathml/presentation/msup-sup-changed-expected.txt:
  • platform/mac/mathml/presentation/over-expected.txt:
  • platform/mac/mathml/presentation/roots-expected.txt:
  • platform/mac/mathml/presentation/row-alignment-expected.txt:
  • platform/mac/mathml/presentation/row-expected.txt:
  • platform/mac/mathml/presentation/style-expected.txt:
  • platform/mac/mathml/presentation/sub-expected.txt:
  • platform/mac/mathml/presentation/subsup-expected.txt:
  • platform/mac/mathml/presentation/sup-expected.txt:
  • platform/mac/mathml/presentation/tables-expected.txt:
  • platform/mac/mathml/presentation/tokenElements-expected.txt:
  • platform/mac/mathml/presentation/under-expected.txt:
  • platform/mac/mathml/presentation/underover-expected.txt:
  • platform/mac/mathml/xHeight-expected.txt:
1:16 PM Changeset in webkit [95565] by commit-queue@webkit.org
  • 5 edits
    2 copies in trunk

Source/WebKit2: Added WKHitTestResult API's.

WKHitTestResult API's are added. These API's can be used to
get the hover'ed link/image/media URL as well as link lable and
title.
​https://bugs.webkit.org/show_bug.cgi?id=68426

Patch by Nayan Kumar K <​nayankk@motorola.com> on 2011-09-20
Reviewed by Anders Carlsson.

  • GNUmakefile.am:
  • Shared/API/c/WKHitTestResult.cpp: Copied from Source/WebKit2/UIProcess/API/C/WebKit2.h.

(WKHitTestResultGetTypeID):
(WKHitTestResultCopyAbsoluteImageURL):
(WKHitTestResultCopyAbsoluteLinkURL):
(WKHitTestResultCopyAbsoluteMediaURL):
(WKHitTestResultCopyLinkLabel):
(WKHitTestResultCopyLinkTitle):

  • Shared/API/c/WKHitTestResult.h: Copied from Source/WebKit2/UIProcess/API/C/WebKit2.h.
  • UIProcess/API/C/WebKit2.h:

Tools: Get hover'ed element URL from HitTest.

mouseDidMoveOverElement now gets the hover'ed element link using
WKHitTestResult API's.
​https://bugs.webkit.org/show_bug.cgi?id=68426

Patch by Nayan Kumar K <​nayankk@motorola.com> on 2011-09-20
Reviewed by Anders Carlsson.

  • MiniBrowser/gtk/BrowserWindow.c:

(mouseDidMoveOverElement):

1:13 PM Changeset in webkit [95564] by commit-queue@webkit.org
  • 7 edits in trunk

[GTK] requestAnimationFrame support for gtk port
​https://bugs.webkit.org/show_bug.cgi?id=66280

Patch by ChangSeok Oh <ChangSeok Oh> on 2011-09-20
Reviewed by Martin Robinson.

.:

  • configure.ac: Add an option to enable requestAnimationFrame for gtk port.

Source/JavaScriptCore:

Let GTK port use REQUEST_ANIMATION_FRAME_TIMER.

  • wtf/Platform.h:

Source/WebCore:

Add some files to build-target & activate ENABLE_REQUEST_ANIMATION_FRAME flag
when enabling requestAnimationFrame option.

fast/animation/request-animation-frame-cancel.html
fast/animation/request-animation-frame-cancel2.html
fast/animation/request-animation-frame-display.html
fast/animation/request-animation-frame-during-modal.html
fast/animation/request-animation-frame-timestamps.html
fast/animation/request-animation-frame-within-callback.html
fast/animation/request-animation-frame.html

  • GNUmakefile.am:
  • GNUmakefile.list.am:
1:10 PM Changeset in webkit [95563] by fpizlo@apple.com
  • 8 edits in trunk/Source/JavaScriptCore

DFG JIT performs too many negative zero checks, and too many
overflow checks
​https://bugs.webkit.org/show_bug.cgi?id=68430

Reviewed by Oliver Hunt.

This adds comprehensive support for deciding how to perform an
arithmetic operations based on a combination of overflow profiling,
negative zero profiling, value profiling, and a static analysis of
how the results of these operations get used.

This is a 72% speed-up on stanford-crypto-sha256-iterative, and a
2.5% speed-up on the Kraken average, a 1.4% speed-up on the V8
geomean, and neutral on SunSpider. It's also an 8.5% speed-up on
V8-crypto, because apparenty everything we do speeds up crypto.

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::toInt32):
(JSC::DFG::ByteCodeParser::toNumber):
(JSC::DFG::ByteCodeParser::isSmallInt32Constant):
(JSC::DFG::ByteCodeParser::valueOfInt32Constant):
(JSC::DFG::ByteCodeParser::weaklyPredictInt32):
(JSC::DFG::ByteCodeParser::makeSafe):
(JSC::DFG::ByteCodeParser::handleMinMax):
(JSC::DFG::ByteCodeParser::handleIntrinsic):
(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::processPhiStack):
(JSC::DFG::ByteCodeParser::parse):

  • dfg/DFGGraph.cpp:

(JSC::DFG::Graph::dump):

  • dfg/DFGJITCodeGenerator.cpp:

(JSC::DFG::JITCodeGenerator::nonSpeculativeBasicArithOp):

  • dfg/DFGNode.h:

(JSC::DFG::nodeUsedAsNumber):
(JSC::DFG::nodeCanTruncateInteger):
(JSC::DFG::nodeCanIgnoreNegativeZero):
(JSC::DFG::nodeCanSpeculateInteger):
(JSC::DFG::arithNodeFlagsAsString):
(JSC::DFG::Node::Node):
(JSC::DFG::Node::hasArithNodeFlags):
(JSC::DFG::Node::rawArithNodeFlags):
(JSC::DFG::Node::arithNodeFlags):
(JSC::DFG::Node::arithNodeFlagsForCompare):
(JSC::DFG::Node::setArithNodeFlag):
(JSC::DFG::Node::mergeArithNodeFlags):

  • dfg/DFGPropagator.cpp:

(JSC::DFG::Propagator::fixpoint):
(JSC::DFG::Propagator::isNotNegZero):
(JSC::DFG::Propagator::isNotZero):
(JSC::DFG::Propagator::propagateArithNodeFlags):
(JSC::DFG::Propagator::propagateArithNodeFlagsForward):
(JSC::DFG::Propagator::propagateArithNodeFlagsBackward):
(JSC::DFG::Propagator::propagateNodePredictions):
(JSC::DFG::Propagator::propagatePredictionsForward):
(JSC::DFG::Propagator::propagatePredictionsBackward):
(JSC::DFG::Propagator::toDouble):
(JSC::DFG::Propagator::fixupNode):
(JSC::DFG::Propagator::fixup):
(JSC::DFG::Propagator::startIndexForChildren):
(JSC::DFG::Propagator::endIndexForPureCSE):
(JSC::DFG::Propagator::pureCSE):
(JSC::DFG::Propagator::clobbersWorld):
(JSC::DFG::Propagator::setReplacement):
(JSC::DFG::Propagator::performNodeCSE):
(JSC::DFG::Propagator::localCSE):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compile):
(JSC::DFG::SpeculativeJIT::computeValueRecoveryFor):

1:05 PM Changeset in webkit [95562] by caryclark@google.com
  • 2 edits in trunk/LayoutTests

Unreviewed; new baselines (Skia on Mac)

This separates test failures that are specific to CG Mac from failures
for Skia on Mac. Most of these changes are specific to Leopard, but a
handful add new fail flavors for all Mac variations.

  • LayoutTests/platform/chromium/test_expectations.txt:
12:05 PM Changeset in webkit [95561] by mihaip@chromium.org
  • 2 edits
    5 copies in branches/chromium/874/LayoutTests

Merge 95259 - Fragment navigations should interrupt a provisional load of a different document
​https://bugs.webkit.org/show_bug.cgi?id=64556

Source/WebCore:

Reviewed by Adam Barth.

Tests: http/tests/history/back-with-fragment-change.php

http/tests/navigation/navigation-interrupted-by-fragment.html

  • loader/FrameLoader.cpp: Stop provisional load if a fragment commits.
  • loader/HistoryController.cpp: Don't commit the wrong provisional item.

LayoutTests:

Reviewed by Adam Barth.

Required page-dismissal-modal-dialogs-iframe.html to be updated since
the dummy <a href="#"> link was clicked after the provisional load was
kicked off, thus causing it to to be aborted.

  • fast/loader/page-dismissal-modal-dialogs.html:
  • fast/loader/resources/page-dismissal-modal-dialogs-iframe.html:
  • http/tests/history/back-with-fragment-change-expected.txt: Added.
  • http/tests/history/back-with-fragment-change.php: Added.
  • http/tests/history/resources/back-with-fragment-change-target.html: Added.
  • http/tests/navigation/navigation-interrupted-by-fragment-expected.txt: Added.
  • http/tests/navigation/navigation-interrupted-by-fragment.html: Added.

TBR=​mihaip@chromium.org
Review URL: ​http://codereview.chromium.org/7983013

11:58 AM Changeset in webkit [95560] by aa@chromium.org
  • 11 edits
    2 adds in trunk/Source

Rework script context creation/release notifications
​https://bugs.webkit.org/show_bug.cgi?id=67828

Reviewed by Adam Barth.

Source/WebCore:

  • bindings/v8/V8DOMWindowShell.cpp:

(WebCore::V8DOMWindowShell::disposeContextHandles):
(WebCore::V8DOMWindowShell::initContextIfNeeded):

  • bindings/v8/V8IsolatedContext.cpp:

(WebCore::V8IsolatedContext::V8IsolatedContext):
(WebCore::V8IsolatedContext::destroy):

  • bindings/v8/V8IsolatedContext.h:
  • loader/EmptyClients.h:

(WebCore::EmptyFrameLoaderClient::didCreateScriptContext):
(WebCore::EmptyFrameLoaderClient::willReleaseScriptContext):

  • loader/FrameLoaderClient.h:

Source/WebKit/chromium:

  • public/WebFrameClient.h:

(WebKit::WebFrameClient::didCreateScriptContext):
(WebKit::WebFrameClient::didDestroyScriptContext):
(WebKit::WebFrameClient::willReleaseScriptContext):

  • src/FrameLoaderClientImpl.cpp:

(WebKit::FrameLoaderClientImpl::didCreateScriptContext):
(WebKit::FrameLoaderClientImpl::willReleaseScriptContext):

  • src/FrameLoaderClientImpl.h:
  • tests/WebFrameTest.cpp:

(WebKit::TEST_F):
(WebKit::ContextLifetimeTestWebFrameClient::Notification::Notification):
(WebKit::ContextLifetimeTestWebFrameClient::Notification::~Notification):
(WebKit::ContextLifetimeTestWebFrameClient::Notification::Equals):
(WebKit::ContextLifetimeTestWebFrameClient::~ContextLifetimeTestWebFrameClient):
(WebKit::ContextLifetimeTestWebFrameClient::reset):
(WebKit::ContextLifetimeTestWebFrameClient::didCreateScriptContext):
(WebKit::ContextLifetimeTestWebFrameClient::willReleaseScriptContext):

  • tests/data/context_notifications_test.html: Added.
  • tests/data/context_notifications_test_frame.html: Added.
11:31 AM Changeset in webkit [95559] by oliver@apple.com
  • 15 edits
    3 adds in trunk/Source

Refactor Heap allocation logic into separate AllocationSpace class
​https://bugs.webkit.org/show_bug.cgi?id=68409

Reviewed by Gavin Barraclough.

../../../../Volumes/Data/git/WebKit/OpenSource/Source/JavaScriptCore:

This patch hoists direct manipulation of the MarkedSpace and related
data out of Heap and into a separate class. This will allow us to
have multiple allocation spaces in future, so easing the way towards
having GC'd backing stores for objects.

(JSC::Debugger::recompileAllJSFunctions):

  • heap/AllocationSpace.cpp: Added.

(JSC::AllocationSpace::tryAllocate):
(JSC::AllocationSpace::allocateSlowCase):
(JSC::AllocationSpace::allocateBlock):
(JSC::AllocationSpace::freeBlocks):
(JSC::TakeIfEmpty::TakeIfEmpty):
(JSC::TakeIfEmpty::operator()):
(JSC::TakeIfEmpty::returnValue):
(JSC::AllocationSpace::shrink):

  • heap/AllocationSpace.h: Added.

(JSC::AllocationSpace::AllocationSpace):
(JSC::AllocationSpace::blocks):
(JSC::AllocationSpace::sizeClassFor):
(JSC::AllocationSpace::setHighWaterMark):
(JSC::AllocationSpace::highWaterMark):
(JSC::AllocationSpace::canonicalizeBlocks):
(JSC::AllocationSpace::resetAllocator):
(JSC::AllocationSpace::forEachCell):
(JSC::AllocationSpace::forEachBlock):
(JSC::AllocationSpace::allocate):

  • heap/Heap.cpp:

(JSC::Heap::Heap):
(JSC::Heap::reportExtraMemoryCostSlowCase):
(JSC::Heap::getConservativeRegisterRoots):
(JSC::Heap::markRoots):
(JSC::Heap::clearMarks):
(JSC::Heap::sweep):
(JSC::Heap::objectCount):
(JSC::Heap::size):
(JSC::Heap::capacity):
(JSC::Heap::globalObjectCount):
(JSC::Heap::objectTypeCounts):
(JSC::Heap::collect):
(JSC::Heap::canonicalizeBlocks):
(JSC::Heap::resetAllocator):
(JSC::Heap::freeBlocks):
(JSC::Heap::shrink):

  • heap/Heap.h:

(JSC::Heap::objectSpace):
(JSC::Heap::sizeClassForObject):
(JSC::Heap::allocate):

  • jit/JITInlineMethods.h:

(JSC::JIT::emitAllocateBasicJSObject):

  • runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::recompileAllJSFunctions):
(JSC::JSGlobalData::releaseExecutableMemory):

../../../../Volumes/Data/git/WebKit/OpenSource/Source/WebCore:

Adding a forwarding header.

  • ForwardingHeaders/heap/AllocationSpace.h: Added.
11:20 AM Changeset in webkit [95558] by ggaren@apple.com
  • 2 edits in trunk/Source/WebCore

Build fix.

  • WebCorePrefix.h: Removed stray text from accidental paste.
11:17 AM Changeset in webkit [95557] by pfeldman@chromium.org
  • 2 edits in trunk/LayoutTests

2011-09-20 Pavel Feldman <​pfeldman@google.com>

Not reviewed: one line inspector's script-formatter.html fix.

  • inspector/debugger/script-formatter.html:
11:09 AM Changeset in webkit [95556] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/efl

[EFL] Call FrameLoader::detachFromParent() when destroying a frame.
​https://bugs.webkit.org/show_bug.cgi?id=66855

Patch by Raphael Kubo da Costa <​kubo@profusion.mobi> on 2011-09-20
Reviewed by Antonio Gomes.

Most other ports call this method somewhere when the frame is being
removed, as it performs some destruction calls which, in our case, at
least makes sure onunload events get delivered properly in
fast/frames/iframe-reparenting-adopt-node.html.

  • ewk/ewk_frame.cpp:

(_ewk_frame_smart_del): Call FrameLoader::detachFromParent()

11:02 AM Changeset in webkit [95555] by ggaren@apple.com
  • 39 edits in trunk/Source

Removed BREWMP* platform #ifdefs
​https://bugs.webkit.org/show_bug.cgi?id=68425

BREWMP* has no maintainer, and this is dead code.

Reviewed by Darin Adler.

../JavaScriptCore:

  • heap/MarkStack.h:

(JSC::::shrinkAllocation):

  • jit/ExecutableAllocator.h:

(JSC::ExecutableAllocator::cacheFlush):

  • runtime/TimeoutChecker.cpp:

(JSC::getCPUTime):

  • wtf/Assertions.cpp:
  • wtf/Assertions.h:
  • wtf/CurrentTime.cpp:
  • wtf/DateMath.cpp:

(WTF::calculateUTCOffset):

  • wtf/FastMalloc.cpp:

(WTF::fastMalloc):
(WTF::fastCalloc):
(WTF::fastMallocSize):

  • wtf/FastMalloc.h:
  • wtf/MainThread.cpp:
  • wtf/MathExtras.h:
  • wtf/OwnPtrCommon.h:
  • wtf/Platform.h:
  • wtf/RandomNumber.cpp:

(WTF::randomNumber):

  • wtf/RandomNumberSeed.h:

(WTF::initializeRandomNumberGenerator):

  • wtf/text/WTFString.h:
  • wtf/unicode/Unicode.h:

../WebCore:

  • WebCorePrefix.h:
  • loader/cache/CachedFont.cpp:
  • platform/DragData.h:
  • platform/DragImage.h:
  • platform/FileSystem.h:
  • platform/PlatformKeyboardEvent.h:
  • platform/PlatformMouseEvent.h:
  • platform/PlatformTouchEvent.h:
  • platform/PlatformTouchPoint.h:

(WebCore::PlatformTouchPoint::PlatformTouchPoint):

  • platform/Widget.h:
  • platform/graphics/IntPoint.h:
  • platform/graphics/IntSize.h:
  • platform/graphics/WOFFFileFormat.cpp:
  • platform/graphics/skia/FontCustomPlatformData.cpp:

(WebCore::FontCustomPlatformData::~FontCustomPlatformData):
(WebCore::FontCustomPlatformData::fontPlatformData):
(WebCore::createFontCustomPlatformData):

  • platform/graphics/skia/FontCustomPlatformData.h:
  • platform/image-decoders/jpeg/JPEGImageDecoder.cpp:
  • platform/text/TextBoundaries.cpp:
  • platform/text/TextEncoding.cpp:

(WebCore::TextEncoding::encode):

  • platform/text/TextEncodingRegistry.cpp:
  • plugins/PluginViewNone.cpp:
10:47 AM Changeset in webkit [95554] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: Copy Stack Trace lacks newlines on Windows
​https://bugs.webkit.org/show_bug.cgi?id=68447

Reviewed by Joseph Pecoraro.

  • inspector/front-end/CallStackSidebarPane.js:

(WebInspector.CallStackSidebarPane.prototype._copyStackTrace):

10:44 AM Changeset in webkit [95553] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-09-20 Pavel Feldman <​pfeldman@google.com>

Not reviewed: inspector sanity test fix.

  • inspector/front-end/inspector.js: (WebInspector.showConsole):
10:15 AM Changeset in webkit [95552] by jamesr@google.com
  • 8 edits in branches/chromium/874/Source/WebCore

Merge 95506 - [chromium] ContentLayer's texture updater deleted during paint when compositing turns off in the middle of paint
​https://bugs.webkit.org/show_bug.cgi?id=68405

Patch by James Robinson <​jamesr@chromium.org> on 2011-09-19
Reviewed by Kenneth Russell.

Make TiledLayerChromium's textureUpdater refcounted and hold an explicit reference during paint in case
compositing is turned off halfway through a paint.

  • platform/graphics/chromium/ContentLayerChromium.h:
  • platform/graphics/chromium/ImageLayerChromium.cpp:

(WebCore::ImageLayerTextureUpdater::create):

  • platform/graphics/chromium/ImageLayerChromium.h:
  • platform/graphics/chromium/LayerTextureUpdater.h:
  • platform/graphics/chromium/LayerTextureUpdaterCanvas.cpp:

(WebCore::LayerTextureUpdaterBitmap::create):
(WebCore::LayerTextureUpdaterSkPicture::create):

  • platform/graphics/chromium/LayerTextureUpdaterCanvas.h:
  • platform/graphics/chromium/TiledLayerChromium.cpp:

(WebCore::TiledLayerChromium::prepareToUpdate):

TBR=​commit-queue@webkit.org
Review URL: ​http://codereview.chromium.org/7982004

10:08 AM Changeset in webkit [95551] by alexis.menard@openbossa.org
  • 6 edits
    4 adds in trunk/Source

[Qt][WK2] Add stubs for FULLSCREEN_API on Qt.
​https://bugs.webkit.org/show_bug.cgi?id=68444

Reviewed by Andreas Kling.

Create all the stubs necessary for enabling FULLSCREEN_API on the Qt port.

Source/WebCore:

No new tests : just stubs.

  • CodeGenerators.pri:
  • WebCore.pro:
  • features.pri:

Source/WebKit2:

  • UIProcess/qt/WebFullScreenManagerProxyQt.cpp: Added.

(WebKit::WebFullScreenManagerProxy::invalidate):
(WebKit::WebFullScreenManagerProxy::enterFullScreen):
(WebKit::WebFullScreenManagerProxy::exitFullScreen):
(WebKit::WebFullScreenManagerProxy::beganEnterFullScreenAnimation):
(WebKit::WebFullScreenManagerProxy::finishedEnterFullScreenAnimation):
(WebKit::WebFullScreenManagerProxy::beganExitFullScreenAnimation):
(WebKit::WebFullScreenManagerProxy::finishedExitFullScreenAnimation):
(WebKit::WebFullScreenManagerProxy::enterAcceleratedCompositingMode):
(WebKit::WebFullScreenManagerProxy::exitAcceleratedCompositingMode):
(WebKit::WebFullScreenManagerProxy::getFullScreenRect):

  • WebKit2.pro:
  • WebProcess/FullScreen/qt: Added.
  • WebProcess/FullScreen/qt/WebFullScreenManagerQt.cpp: Added.

(WebKit::WebFullScreenManagerQt::WebFullScreenManagerQt):
(WebKit::WebFullScreenManager::create):
(WebKit::WebFullScreenManagerQt::setRootFullScreenLayer):
(WebKit::WebFullScreenManagerQt::beginEnterFullScreenAnimation):
(WebKit::WebFullScreenManagerQt::beginExitFullScreenAnimation):

  • WebProcess/FullScreen/qt/WebFullScreenManagerQt.h: Added.
9:46 AM Changeset in webkit [95550] by commit-queue@webkit.org
  • 3 edits
    4 deletes in trunk

Unreviewed, rolling out r95509.
​http://trac.webkit.org/changeset/95509
​https://bugs.webkit.org/show_bug.cgi?id=68446

crashes chromium fast/repaint/japanese-rl-selection-repaint-
in-regions.html on Win and Linux (Requested by dslomov on
#webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2011-09-20

Source/WebCore:

  • rendering/RenderBlock.cpp:

(WebCore::positionForPointRespectingEditingBoundaries):

LayoutTests:

  • editing/selection/click-on-body-margin-expected.txt: Removed.
  • editing/selection/click-on-body-margin.html: Removed.
  • editing/selection/click-on-head-margin-expected.txt: Removed.
  • editing/selection/click-on-head-margin.html: Removed.
9:45 AM Changeset in webkit [95549] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

Changelog class should have a method to return all entries
​https://bugs.webkit.org/show_bug.cgi?id=68399

Implement ChangeLog.parse_entries_from_file(). This method returns a generator
of ChangeLogEntry objects, ordered from the latest to the oldest entry in the file.

Patch by Leandro Pereira <​leandro@profusion.mobi> on 2011-09-20
Reviewed by Ryosuke Niwa.

  • Scripts/webkitpy/common/checkout/changelog.py: Copy parse_latest_entry_from_file()

and adapt it to become a generator.

  • Scripts/webkitpy/common/checkout/changelog_unittest.py: Add test case.
9:41 AM Changeset in webkit [95548] by commit-queue@webkit.org
  • 10 edits
    8 adds in trunk

Source/WebCore: [Qt] Permit qrc resources to load in QWebSettings::setUserStyleSheetUrl()
​https://bugs.webkit.org/show_bug.cgi?id=51159

Permit any URL with a local scheme to set a user style sheet. Allow qrc
resource URLs as arguments to QWebSettings::setUserStyleSheetUrl().

Patch by Jarred Nicholls <​jarred@sencha.com> on 2011-09-20
Reviewed by Kenneth Rohde Christiansen.

  • page/Page.cpp:

(WebCore::Page::userStyleSheetLocationChanged):

  • platform/qt/KURLQt.cpp:

(WebCore::KURL::fileSystemPath):

Source/WebKit/qt: [Qt] Permit qrc resources to load in QWebSettings::setUserStyleSheetUrl()
​https://bugs.webkit.org/show_bug.cgi?id=51159

Permit any URL with a local scheme to set a user style sheet. Allow qrc
resource URLs as arguments to QWebSettings::setUserStyleSheetUrl().

New test case makes sure a qrc URL will properly load a user stylesheet.

Patch by Jarred Nicholls <​jarred@sencha.com> on 2011-09-20
Reviewed by Kenneth Rohde Christiansen.

(tst_QWebPage::userStyleSheetFromQrcUrl):

  • tests/qwebpage/tst_qwebpage.qrc:

Tools: [Qt] Permit qrc resources to load in QWebSettings::setUserStyleSheetUrl()
​https://bugs.webkit.org/show_bug.cgi?id=51159

Permit any URL with a local scheme to set a user style sheet. Allow qrc
resource URLs as arguments to QWebSettings::setUserStyleSheetUrl().

Add DRT/WKTR qrc resource to test loading user style sheets from a qrc URL.

Patch by Jarred Nicholls <​jarred@sencha.com> on 2011-09-20
Reviewed by Kenneth Rohde Christiansen.

  • DumpRenderTree/qt/DumpRenderTree.pro:
  • DumpRenderTree/qt/DumpRenderTree.qrc: Added.
  • DumpRenderTree/qt/resources/user.css: Added.

(body):

  • WebKitTestRunner/qt/WebKitTestRunner.pro:
  • WebKitTestRunner/qt/WebKitTestRunner.qrc: Added.
  • WebKitTestRunner/qt/resources/user.css: Added.

(body):

LayoutTests: [Qt] Permit qrc resources to load in QWebSettings::setUserStyleSheetUrl()
​https://bugs.webkit.org/show_bug.cgi?id=51159

Permit any URL with a local scheme to set a user style sheet. Allow qrc
resource URLs as arguments to QWebSettings::setUserStyleSheetUrl().

New platform layout test since user style sheet is testable from DRT.

Patch by Jarred Nicholls <​jarred@sencha.com> on 2011-09-20
Reviewed by Kenneth Rohde Christiansen.

  • platform/qt/fast/loader/user-stylesheet-qrc-path-expected.txt: Added.
  • platform/qt/fast/loader/user-stylesheet-qrc-path.html: Added.
9:31 AM Changeset in webkit [95547] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

ChangeLogEntry class should contain a list of touched files
​https://bugs.webkit.org/show_bug.cgi?id=68115

Patch by Leandro Pereira <​leandro@profusion.mobi> on 2011-09-20
Reviewed by Eric Seidel.

Add method to return the list of files touched in a ChangeLog entry.

  • Scripts/webkitpy/common/checkout/changelog.py: Add

touched_files_regexp and touched_files() method.

  • Scripts/webkitpy/common/checkout/changelog_unittest.py: Implement

unit tests for touched_files() method.

9:27 AM Changeset in webkit [95546] by dslomov@google.com
  • 2 edits in trunk/LayoutTests

[Chromium] Rebaseline expectationd and file WK68445.

  • platform/chromium/test_expectations.txt:
9:08 AM Changeset in webkit [95545] by alexis.menard@openbossa.org
  • 2 edits
    2 adds in trunk/Source/WebKit2

[Qt][WK2] Export QNetworkReply in the QtWebKit QML module.
​https://bugs.webkit.org/show_bug.cgi?id=68401

Reviewed by Simon Hausmann.

Add QNetworkReply in the QtWebKit module. We use the enum QNetworkReply::NetworkError
as the error code when the load fails. It is not used in the QtQuick module therefore
the QML team thinks it should belong here. Also added some auto-tests to cover the
loading errors.

  • UIProcess/API/qt/qmlplugin/plugin.cpp:

(WebKit2QmlPlugin::registerTypes):

  • UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_loadFail.qml: Added.
  • UIProcess/API/qt/tests/qmltests/TouchWebView/tst_loadFail.qml: Added.
8:46 AM Changeset in webkit [95544] by Csaba Osztrogonác
  • 3 edits in trunk/Tools

Unreviewed, rolling out r95526 and r95541.
​http://trac.webkit.org/changeset/95526
​http://trac.webkit.org/changeset/95541
​https://bugs.webkit.org/show_bug.cgi?id=68443

It broke 6 tests (Requested by ossy_ on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2011-09-20

  • DumpRenderTree/qt/main.cpp:

(main):

  • WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:

(WTR::activateFonts):

8:43 AM Changeset in webkit [95543] by commit-queue@webkit.org
  • 16 edits in trunk/Tools

Fix patch and bug numbering in the mocktool simulation code
​https://bugs.webkit.org/show_bug.cgi?id=68374

Patch by Tom Zakrajsek <​tomz@codeaurora.org> on 2011-09-20
Reviewed by Adam Barth.

  • Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
  • Scripts/webkitpy/tool/bot/feeders_unittest.py:
  • Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
  • Scripts/webkitpy/tool/bot/irc_command_unittest.py:
  • Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
  • Scripts/webkitpy/tool/bot/queueengine_unittest.py:
  • Scripts/webkitpy/tool/commands/download_unittest.py:
  • Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
  • Scripts/webkitpy/tool/commands/queries_unittest.py:
  • Scripts/webkitpy/tool/commands/queues_unittest.py:
  • Scripts/webkitpy/tool/commands/queuestest.py:
  • Scripts/webkitpy/tool/commands/upload_unittest.py:
  • Scripts/webkitpy/tool/mocktool.py:
  • Scripts/webkitpy/tool/steps/steps_unittest.py:
  • Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittest.py:
7:57 AM Changeset in webkit [95542] by Csaba Osztrogonác
  • 5 edits in trunk/Source

Source/WebCore: [Qt][Mac] Buildfix after r95513.
Forwarding headers for WebCore should be generated based on WebCore sources instead of WebKit2.

Rubber-stamped by Andras Becsi.

  • DerivedSources.pro:
  • WebCore.pro: Add platform/mac/DisplaySleepDisabler.cpp to SOURCES.

Source/WebKit2: [Qt][Mac] Buildfix after r95513.

Rubber-stamped by Andras Becsi.

  • Scripts/generate-forwarding-headers.pl: Add mm file supporting.
7:22 AM Changeset in webkit [95541] by vestbo@webkit.org
  • 3 edits in trunk/Tools

[Qt] Don't override default QApplication font for DRT and WTR

Revision 95526 moved the relevant code below the QApplication
constructor, to fix a potential crash, and that made the code
take effect, breaking 6 tests.

We should rely on the QWebSettings to set default fonts, and
this QApplication::setFont() is a relic from when we didn't
have that option, so we remove the code.

Reviewed by Csaba Osztrogonác.

  • DumpRenderTree/qt/main.cpp:
  • WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
7:08 AM Changeset in webkit [95540] by Adam Roben
  • 2 edits in trunk/Source/JavaScriptCore

Windows build fix after r95523

  • wtf/CheckedArithmetic.h: Added stdint.h so we can have int64_t defined.
7:03 AM Changeset in webkit [95539] by caryclark@google.com
  • 2 edits
    1 delete in trunk/LayoutTests

Unreviewed; new baselines (Skia on Mac)
Updated reference images.

  • LayoutTests/platform/chromium-mac/fast/ruby/overhang-horizontal-expected.png: Removed.
  • LayoutTests/platform/chromium-mac/fast/box-shadow/box-shadow-clipped-slices-expected.png:
7:00 AM Changeset in webkit [95538] by pfeldman@chromium.org
  • 13 edits in trunk

Web Inspector: document Debugger.paused, introduce types for ids in Debugger domain.
​https://bugs.webkit.org/show_bug.cgi?id=68363

Migrates from poorly documented "details" object to explicit parameters
containing break type and data.

Reviewed by Tony Gentilcore.

Source/WebCore:

  • inspector/InjectedScriptSource.js:

():

  • inspector/Inspector.json:
  • inspector/InspectorDOMDebuggerAgent.cpp:

(WebCore::InspectorDOMDebuggerAgent::didInvalidateStyleAttr):
(WebCore::InspectorDOMDebuggerAgent::willInsertDOMNode):
(WebCore::InspectorDOMDebuggerAgent::willRemoveDOMNode):
(WebCore::InspectorDOMDebuggerAgent::willModifyDOMAttr):
(WebCore::InspectorDOMDebuggerAgent::pauseOnNativeEventIfNeeded):
(WebCore::InspectorDOMDebuggerAgent::willSendXMLHttpRequest):

  • inspector/InspectorDebuggerAgent.cpp:

(WebCore::InspectorDebuggerAgent::InspectorDebuggerAgent):
(WebCore::InspectorDebuggerAgent::schedulePauseOnNextStatement):
(WebCore::InspectorDebuggerAgent::cancelPauseOnNextStatement):
(WebCore::InspectorDebuggerAgent::pause):
(WebCore::InspectorDebuggerAgent::didPause):
(WebCore::InspectorDebuggerAgent::didContinue):
(WebCore::InspectorDebuggerAgent::breakProgram):
(WebCore::InspectorDebuggerAgent::clear):
(WebCore::InspectorDebuggerAgent::clearBreakDetails):

  • inspector/InspectorDebuggerAgent.h:
  • inspector/front-end/DOMBreakpointsSidebarPane.js:

(WebInspector.DOMBreakpointsSidebarPane.prototype.createBreakpointHitStatusMessage.didPushNodeToFrontend):
(WebInspector.DOMBreakpointsSidebarPane.prototype.createBreakpointHitStatusMessage):
(WebInspector.DOMBreakpointsSidebarPane.prototype.highlightBreakpoint):

  • inspector/front-end/DebuggerModel.js:

(WebInspector.DebuggerModel.prototype._pausedScript):
(WebInspector.DebuggerDispatcher.prototype.paused):

  • inspector/front-end/DebuggerPresentationModel.js:

(WebInspector.PresentationCallFrame.prototype.evaluate):

  • inspector/front-end/ScopeChainSidebarPane.js:

(WebInspector.ScopeChainSidebarPane.prototype.update):

  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype._debuggerPaused.didCreateBreakpointHitStatusMessage):
(WebInspector.ScriptsPanel.prototype._debuggerPaused.else.didGetSourceLocation):
(WebInspector.ScriptsPanel.prototype._debuggerPaused):

LayoutTests:

  • http/tests/inspector/debugger-test.js:

(initialize_DebuggerTest):

6:58 AM Changeset in webkit [95537] by commit-queue@webkit.org
  • 2 edits
    2 adds in trunk/Source/WebKit2

[Qt] QDesktopWebView missing loadProgress tests
​https://bugs.webkit.org/show_bug.cgi?id=68280

Patch by Gopal Raghavan <​gopal.1.raghavan@nokia.com> on 2011-09-20
Reviewed by Andreas Kling.

Added test case to check load progress property and signal for QDesktopWebView

  • UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_loadProgress.qml: Added.
  • UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_loadProgressSignal.qml: Added.
  • UIProcess/API/qt/tests/qmltests/qmltests.pro:
6:51 AM Changeset in webkit [95536] by pfeldman@chromium.org
  • 9 edits in trunk

Source/WebCore: Web Inspector: refactor ConsoleView, Drawer, ConsolePanel trio. Remove animation
from drawer -> panel transition.
​https://bugs.webkit.org/show_bug.cgi?id=68155

ConsoleView, ConsolePanel and Drawer are all Views with custom show/hide implementations
and weird DOM element containment. As a result, we have a number of cases when switching
console from full panel to drawer mode and back result in UI glitches.
For the sake of code clarity and no glitches, I'd like to sacrifice the "grow into full
screen" console animation.

Reviewed by Tony Gentilcore.

  • inspector/front-end/ConsoleModel.js:

(WebInspector.ConsoleModel):

  • inspector/front-end/ConsolePanel.js:

(WebInspector.ConsolePanel):
(WebInspector.ConsolePanel.prototype.get statusBarItems):
(WebInspector.ConsolePanel.prototype.show):
(WebInspector.ConsolePanel.prototype.hide):

  • inspector/front-end/ConsoleView.js:

(WebInspector.ConsoleView):
(WebInspector.ConsoleView.createFilterElement):
(WebInspector.ConsoleView.get this):
(WebInspector.ConsoleView.prototype.get statusBarItems):
(WebInspector.ConsoleView.prototype.wasShown):

  • inspector/front-end/Drawer.js:

(WebInspector.Drawer):
(WebInspector.Drawer.prototype.get visible):
(WebInspector.Drawer.prototype._constrainHeight):
(WebInspector.Drawer.prototype.show.animationFinished):
(WebInspector.Drawer.prototype.show):
(WebInspector.Drawer.prototype.hide):
(WebInspector.Drawer.prototype.resize):
(WebInspector.Drawer.prototype._animationDuration):

  • inspector/front-end/inspector.html:
  • inspector/front-end/inspector.js:

(WebInspector._createGlobalStatusBarItems):
(WebInspector._toggleConsoleButtonClicked):
(WebInspector.set attached):
(WebInspector.windowResize):
(WebInspector.documentKeyDown):

LayoutTests: Web Inspector: refactor ConsoleView, Drawer, ConsolePanel trio.
​https://bugs.webkit.org/show_bug.cgi?id=68155

Reviewed by Tony Gentilcore.

  • inspector/console/console-dir.html:
6:46 AM Changeset in webkit [95535] by pfeldman@chromium.org
  • 14 edits
    1 add in trunk

Web Inspector: streamline Console's MessageType and MessageSource semantics.
​https://bugs.webkit.org/show_bug.cgi?id=68342

Source/WebCore:

This change fixes semantics of the MessageSource and MessageType:
MessageSource is now the source of the message (be it Network, HTML
parser or Console API). MessageType is only defined for the Console API
messages and contains the name of the API call (log, dir, dirxml, etc.).
Subsequent ​https://bugs.webkit.org/show_bug.cgi?id=66371 will make MessageType
private to the inspector.

Reviewed by Tony Gentilcore.

  • dom/Document.cpp:

(WebCore::Document::logExceptionToConsole):

  • inspector/ConsoleMessage.cpp:

(WebCore::messageSourceValue):
(WebCore::messageTypeValue):
(WebCore::ConsoleMessage::addToFrontend):

  • inspector/Inspector.json:
  • inspector/InspectorConsoleAgent.cpp:

(WebCore::InspectorConsoleAgent::didReceiveResponse):
(WebCore::InspectorConsoleAgent::didFailLoading):

  • inspector/front-end/ConsoleMessage.js:

(WebInspector.ConsoleMessage.createTextMessage):
(WebInspector.ConsoleMessage.prototype._formatMessage):
(WebInspector.ConsoleMessage.prototype.toString):

  • page/Console.cpp:

(WebCore::printMessageSourceAndLevelPrefix):
(WebCore::Console::addMessage):
(WebCore::Console::dir):
(WebCore::Console::dirxml):
(WebCore::Console::group):
(WebCore::Console::groupCollapsed):
(WebCore::Console::groupEnd):

  • page/ConsoleTypes.h:
  • websockets/WebSocketChannel.cpp:

(WebCore::WebSocketChannel::didFailSocketStream):

Source/WebKit/mac:

This change fixes semantics of the MessageSource and MessageType:
MessageSource is now the source of the message (be it Network, HTML
parser or Console API). MessageType is only defined for the Console API
messages and contains the name of the API call (log, dir, dirxml, etc.).
Subsequent ​https://bugs.webkit.org/show_bug.cgi?id=66371 will make MessageType
private to the inspector.

Reviewed by Tony Gentilcore.

  • WebCoreSupport/WebChromeClient.mm:

(stringForMessageSource):
(stringForMessageType):

  • WebView/WebUIDelegatePrivate.h:

LayoutTests:

This change fixes semantics of the MessageSource and MessageType:
MessageSource is now the source of the message (be it Network, HTML
parser or Console API). MessageType is only defined for the Console API
messages and contains the name of the API call (log, dir, dirxml, etc.).
Subsequent ​https://bugs.webkit.org/show_bug.cgi?id=66371 will make MessageType
private to the inspector.

Reviewed by Tony Gentilcore.

  • inspector/protocol/console-agent-expected.txt:
  • platform/chromium/http/tests/inspector/console-resource-errors-expected.txt: Added.
6:37 AM Changeset in webkit [95534] by timothy@apple.com
  • 3 edits in trunk/Source/WebKit/mac

Make WebViews in NSPopovers render as they would in active windows.

The NSWindowDid{Become,Resign}KeyNotifications are not fired when NSPopovers
are shown or hidden since they share key with the parent window. So WebView
and WebHTMLView need to also observe the will order on/off screen notifications.

​https://webkit.org/b/68402
rdar://problem/9754099

Reviewed by John Sullivan.

  • WebView/WebHTMLView.mm:

(-[WebHTMLView _removeWindowObservers]): Remove order on/off screen notification obversers.
(-[WebHTMLView addWindowObservers]): Add order on/off screen notification obversers.
(-[WebHTMLView windowWillOrderOnScreen:]): Check if the window is already a key window,
which can be the case for NSPopovers.
(-[WebHTMLView windowWillOrderOffScreen:]): Remove the mouse moved observer.

  • WebView/WebView.mm:

(-[WebView addWindowObserversForWindow:]): Add order off screen notification obverser.
(-[WebView removeWindowObservers]): Remove order off screen notification obverser.
(-[WebView _windowWillOrderOnScreen:]): Call _updateActiveState.
(-[WebView _windowWillOrderOffScreen:]): Ditto.

5:45 AM Changeset in webkit [95533] by Philippe Normand
  • 1 edit
    58 adds in trunk/LayoutTests

Unreviewed, GTK baselines for new tests.

  • platform/gtk/css3/bdi-element-expected.png: Added.
  • platform/gtk/css3/bdi-element-expected.txt: Added.
  • platform/gtk/css3/unicode-bidi-isolate-aharon-expected.png: Added.
  • platform/gtk/css3/unicode-bidi-isolate-aharon-expected.txt: Added.
  • platform/gtk/css3/unicode-bidi-isolate-basic-expected.png: Added.
  • platform/gtk/css3/unicode-bidi-isolate-basic-expected.txt: Added.
  • platform/gtk/fast/borders/block-mask-overlay-image-outset-expected.png: Added.
  • platform/gtk/fast/borders/block-mask-overlay-image-outset-expected.txt: Added.
  • platform/gtk/fast/borders/border-image-longhand-expected.png: Added.
  • platform/gtk/fast/borders/border-image-longhand-expected.txt: Added.
  • platform/gtk/fast/borders/border-image-massive-scale-expected.png: Added.
  • platform/gtk/fast/borders/border-image-massive-scale-expected.txt: Added.
  • platform/gtk/fast/borders/border-image-outset-expected.png: Added.
  • platform/gtk/fast/borders/border-image-outset-expected.txt: Added.
  • platform/gtk/fast/borders/border-image-outset-in-shorthand-expected.png: Added.
  • platform/gtk/fast/borders/border-image-outset-in-shorthand-expected.txt: Added.
  • platform/gtk/fast/borders/border-image-outset-split-inline-expected.png: Added.
  • platform/gtk/fast/borders/border-image-outset-split-inline-expected.txt: Added.
  • platform/gtk/fast/borders/border-image-outset-split-inline-vertical-lr-expected.png: Added.
  • platform/gtk/fast/borders/border-image-outset-split-inline-vertical-lr-expected.txt: Added.
  • platform/gtk/fast/borders/border-image-repeat-expected.png: Added.
  • platform/gtk/fast/borders/border-image-repeat-expected.txt: Added.
  • platform/gtk/fast/borders/border-image-scaled-expected.png: Added.
  • platform/gtk/fast/borders/border-image-scaled-expected.txt: Added.
  • platform/gtk/fast/borders/border-image-scaled-gradient-expected.png: Added.
  • platform/gtk/fast/borders/border-image-scaled-gradient-expected.txt: Added.
  • platform/gtk/fast/borders/border-image-scrambled-expected.png: Added.
  • platform/gtk/fast/borders/border-image-scrambled-expected.txt: Added.
  • platform/gtk/fast/borders/border-image-side-reduction-expected.png: Added.
  • platform/gtk/fast/borders/border-image-side-reduction-expected.txt: Added.
  • platform/gtk/fast/borders/border-image-slices-expected.png: Added.
  • platform/gtk/fast/borders/border-image-slices-expected.txt: Added.
  • platform/gtk/fast/borders/inline-mask-overlay-image-outset-expected.png: Added.
  • platform/gtk/fast/borders/inline-mask-overlay-image-outset-expected.txt: Added.
  • platform/gtk/fast/borders/inline-mask-overlay-image-outset-vertical-rl-expected.png: Added.
  • platform/gtk/fast/borders/inline-mask-overlay-image-outset-vertical-rl-expected.txt: Added.
  • platform/gtk/fast/clip/overflow-border-radius-combinations-expected.png: Added.
  • platform/gtk/fast/clip/overflow-border-radius-combinations-expected.txt: Added.
  • platform/gtk/fast/clip/overflow-border-radius-composited-expected.png: Added.
  • platform/gtk/fast/clip/overflow-border-radius-composited-expected.txt: Added.
  • platform/gtk/fast/clip/overflow-border-radius-transformed-expected.png: Added.
  • platform/gtk/fast/clip/overflow-border-radius-transformed-expected.txt: Added.
  • platform/gtk/fast/css/focus-ring-multiline-writingmode-vertical-expected.png: Added.
  • platform/gtk/fast/css/focus-ring-multiline-writingmode-vertical-expected.txt: Added.
  • platform/gtk/fast/css/line-after-floating-div-expected.png: Added.
  • platform/gtk/fast/css/line-after-floating-div-expected.txt: Added.
  • platform/gtk/fast/parser/innerhtml-with-prefixed-elements-expected.png: Added.
  • platform/gtk/fast/parser/innerhtml-with-prefixed-elements-expected.txt: Added.
  • platform/gtk/fast/reflections/reflection-masks-outset-expected.png: Added.
  • platform/gtk/fast/reflections/reflection-masks-outset-expected.txt: Added.
  • platform/gtk/fast/text/fallback-traits-fixup-expected.png: Added.
  • platform/gtk/fast/text/fallback-traits-fixup-expected.txt: Added.
  • platform/gtk/fast/text/hyphenate-limit-lines-expected.png: Added.
  • platform/gtk/fast/text/hyphenate-limit-lines-expected.txt: Added.
  • platform/gtk/svg/custom/pattern-rotate-gaps-expected.png: Added.
  • platform/gtk/svg/custom/pattern-rotate-gaps-expected.txt: Added.
  • platform/gtk/svg/custom/simple-text-double-shadow-expected.png: Added.
  • platform/gtk/svg/custom/simple-text-double-shadow-expected.txt: Added.
5:34 AM Changeset in webkit [95532] by vestbo@webkit.org
  • 2 edits in trunk/Tools

WebKitTestRunner: Provide usage if run without arguments

If WTR is run without either one or more filenames, or
a '-' to indicate server mode, we don't need to start
up the test machinery. Doing so might actually crash,
as we'll exit the application immedeatly after anyways.

Reviewed by Simon Hausmann.

5:25 AM Changeset in webkit [95531] by Philippe Normand
  • 1 edit
    2 adds in trunk/LayoutTests

Unreviewed, GTK baselines for tests added in r95489 and r95488.

  • platform/gtk/http/tests/security/document-all-expected.txt: Added.
  • platform/gtk/http/tests/security/window-named-proto-expected.txt: Added.
5:14 AM Changeset in webkit [95530] by Philippe Normand
  • 1 edit
    5 adds in trunk/LayoutTests

Unreviewed, GTK baselines for tests added in r95461.

  • platform/gtk/fast/table/table-cell-before-after-content-around-table-block-expected.txt: Added.
  • platform/gtk/fast/table/table-cell-before-after-content-around-table-expected.txt: Added.
  • platform/gtk/fast/table/table-cell-before-after-content-around-table-row-expected.txt: Added.
  • platform/gtk/fast/table/table-row-before-after-content-around-block-expected.txt: Added.
  • platform/gtk/fast/table/table-row-before-after-content-around-table-expected.txt: Added.
5:10 AM Changeset in webkit [95529] by reni@webkit.org
  • 2 edits
    2 adds in trunk/LayoutTests

[Qt] Rebase and unskip tests introduced in r95489 and r95488.

Unreviewed gardening.

  • platform/qt/Skipped:
  • platform/qt/http/tests/security/document-all-expected.txt: Added.
  • platform/qt/http/tests/security/window-named-proto-expected.txt: Added.
4:50 AM Changeset in webkit [95528] by Philippe Normand
  • 2 edits in trunk/LayoutTests

Unreviewed, skip failing fast/files/create-blob-url-crash.html on
GTK because of bug 66045.

  • platform/gtk/Skipped:
4:43 AM Changeset in webkit [95527] by Philippe Normand
  • 5 edits in trunk/LayoutTests

Unreviewed, GTK rebaseline after r95178 and r95362.

  • platform/gtk/fast/dom/Window/window-properties-expected.txt:
  • platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/gtk/fast/dom/call-a-constructor-as-a-function-expected.txt:
  • platform/gtk/fast/js/global-constructors-expected.txt:
4:36 AM Changeset in webkit [95526] by vestbo@webkit.org
  • 2 edits in trunk/Tools

[Qt] Don't use QFont before initializing QApplication

Could potentially result in crash.

Reviewed by Simon Hausmann.

3:41 AM Changeset in webkit [95525] by commit-queue@webkit.org
  • 4 edits in trunk/Source

[Qt] resizeToContent seems to trigger infinite resize on some pages
​https://bugs.webkit.org/show_bug.cgi?id=43852

Patch by Adenilson Cavalcanti <​adenilson.silva@openbossa.org> on 2011-09-20
Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

InnerHeight and InnerWidth are now calculated using ScrollView::visibleContentRect
including the scrollbars (if any) instead of using ScrollView::frameRect as before.

This makes no behavior change while not using the tiled backing
store and is compliant with the W3C definition stated in the CSSOM
View Module.

Plus it will return the correct values for tiled backing store,
thus fixing the original bug report by avoiding infinite resize
events caused by wrong innerHeight and innerWidth values.

Test: innerWidth/Height are covered by existing tests. The
non-infinite resizing is covered by a new Qt autotest at
test_qgraphicswebview::windowResizeEvent()

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::innerHeight): using ScrollView::visibleContentRect.
(WebCore::DOMWindow::innerWidth): using ScrollView::visibleContentRect.

Source/WebKit/qt:

Test by Luiz Agostini.

  • tests/qgraphicswebview/tst_qgraphicswebview.cpp:

(ResizeSpy::receiveResize):
(ResizeSpy::size):
(tst_QGraphicsWebView::windowResizeEvent):

3:22 AM Changeset in webkit [95524] by podivilov@chromium.org
  • 5 edits in trunk

Web Inspector: implement reverse mapping for compiler source maps.
​https://bugs.webkit.org/show_bug.cgi?id=67850

Source/WebCore:

Implement the mapping from source code to compiled code. It will be used for
setting breakpoints on source code.

Reviewed by Pavel Feldman.

  • inspector/front-end/CompilerSourceMapping.js:

(WebInspector.ClosureCompilerSourceMapping):
(WebInspector.ClosureCompilerSourceMapping.prototype.compiledLocationToSourceLocation):
(WebInspector.ClosureCompilerSourceMapping.prototype.sourceLocationToCompiledLocation):
(WebInspector.ClosureCompilerSourceMapping.prototype._parseMappings):

LayoutTests:

Reviewed by Pavel Feldman.

  • inspector/debugger/compiler-source-mapping.html:
2:41 AM Changeset in webkit [95523] by fpizlo@apple.com
  • 12 edits in trunk/Source/JavaScriptCore

DFG JIT does not speculate aggressively enough on GetById
​https://bugs.webkit.org/show_bug.cgi?id=68320

Reviewed by Oliver Hunt.

This adds the ability to access properties directly, by offset.
This optimization kicks in when at the time of DFG compilation,
it appears that the given get_by_id is self-cached by the old JIT.
Two new opcodes get introduced: CheckStructure and GetByOffset.
CheckStructure performs a speculation check on the object's
structure, and returns the storage pointer. GetByOffset performs
a direct read of the field from the storage pointer. Both
CheckStructure and GetByOffset can be CSE'd, so that we can
eliminate redundant structure checks, and redundant reads of the
same field.

This is a 4% speed-up on V8, a 2% slow-down on Kraken, and
neutral on SunSpider.

  • bytecode/PredictedType.cpp:

(JSC::predictionFromClassInfo):
(JSC::predictionFromStructure):
(JSC::predictionFromCell):

  • bytecode/PredictedType.h:
  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):

  • dfg/DFGGenerationInfo.h:

(JSC::DFG::dataFormatToString):
(JSC::DFG::needDataFormatConversion):
(JSC::DFG::GenerationInfo::initStorage):
(JSC::DFG::GenerationInfo::spill):
(JSC::DFG::GenerationInfo::fillStorage):

  • dfg/DFGGraph.h:

(JSC::DFG::Graph::predict):
(JSC::DFG::Graph::getPrediction):

  • dfg/DFGJITCodeGenerator.cpp:

(JSC::DFG::JITCodeGenerator::fillInteger):
(JSC::DFG::JITCodeGenerator::fillDouble):
(JSC::DFG::JITCodeGenerator::fillJSValue):
(JSC::DFG::JITCodeGenerator::fillStorage):
(JSC::DFG::GPRTemporary::GPRTemporary):

  • dfg/DFGJITCodeGenerator.h:

(JSC::DFG::JITCodeGenerator::silentSpillGPR):
(JSC::DFG::JITCodeGenerator::silentFillGPR):
(JSC::DFG::JITCodeGenerator::spill):
(JSC::DFG::JITCodeGenerator::storageResult):
(JSC::DFG::StorageOperand::StorageOperand):
(JSC::DFG::StorageOperand::~StorageOperand):
(JSC::DFG::StorageOperand::index):
(JSC::DFG::StorageOperand::gpr):
(JSC::DFG::StorageOperand::use):

  • dfg/DFGNode.h:

(JSC::DFG::OpInfo::OpInfo):
(JSC::DFG::Node::Node):
(JSC::DFG::Node::hasPrediction):
(JSC::DFG::Node::hasStructure):
(JSC::DFG::Node::structure):
(JSC::DFG::Node::hasStorageAccessData):
(JSC::DFG::Node::storageAccessDataIndex):

  • dfg/DFGPropagator.cpp:

(JSC::DFG::Propagator::propagateNode):
(JSC::DFG::Propagator::globalVarLoadElimination):
(JSC::DFG::Propagator::getMethodLoadElimination):
(JSC::DFG::Propagator::checkStructureLoadElimination):
(JSC::DFG::Propagator::getByOffsetLoadElimination):
(JSC::DFG::Propagator::performNodeCSE):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::fillSpeculateIntInternal):
(JSC::DFG::SpeculativeJIT::fillSpeculateDouble):
(JSC::DFG::SpeculativeJIT::fillSpeculateCell):
(JSC::DFG::SpeculativeJIT::fillSpeculateBoolean):
(JSC::DFG::SpeculativeJIT::compile):

  • wtf/StdLibExtras.h:

(WTF::safeCast):

2:28 AM Changeset in webkit [95522] by podivilov@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: extract RawSourceCode source mapping logic to helper classes.
​https://bugs.webkit.org/show_bug.cgi?id=67789

Reviewed by Pavel Feldman.

  • inspector/front-end/SourceFile.js:

(WebInspector.RawSourceCode.prototype.get uiSourceCode):
(WebInspector.RawSourceCode.prototype.rawLocationToUILocation):
(WebInspector.RawSourceCode.prototype.uiLocationToRawLocation):
(WebInspector.RawSourceCode.prototype._createSourceMapping.didRequestContent.didFormatContent):
(WebInspector.RawSourceCode.prototype._createSourceMapping.didRequestContent):
(WebInspector.RawSourceCode.prototype._createSourceMapping):
(WebInspector.RawSourceCode.prototype._saveSourceMapping):
(WebInspector.RawSourceCode.PlainSourceMapping):
(WebInspector.RawSourceCode.PlainSourceMapping.prototype.rawLocationToUILocation):
(WebInspector.RawSourceCode.PlainSourceMapping.prototype.uiLocationToRawLocation):
(WebInspector.RawSourceCode.PlainSourceMapping.prototype.get uiSourceCode):
(WebInspector.RawSourceCode.FormattedSourceMapping):
(WebInspector.RawSourceCode.FormattedSourceMapping.prototype.rawLocationToUILocation):
(WebInspector.RawSourceCode.FormattedSourceMapping.prototype.uiLocationToRawLocation):
(WebInspector.RawSourceCode.FormattedSourceMapping.prototype.get uiSourceCode):

1:58 AM Changeset in webkit [95521] by Carlos Garcia Campos
  • 11 edits
    2 adds in trunk/Source

[GTK] WebProcess shouldn't use the GTK+ API
​https://bugs.webkit.org/show_bug.cgi?id=68062

Reviewed by Martin Robinson.

Source/WebCore:

Move errors code that is common between webki1 and webkit2 to
WebCore so that it can be shared.

  • GNUmakefile.list.am: Add new files to compilation.
  • platform/gtk/ErrorsGtk.cpp: Added.

(WebCore::cancelledError):
(WebCore::blockedError):
(WebCore::cannotShowURLError):
(WebCore::interruptedForPolicyChangeError):
(WebCore::cannotShowMIMETypeError):
(WebCore::fileDoesNotExistError):
(WebCore::pluginWillHandleLoadError):

  • platform/gtk/ErrorsGtk.h: Added.

Source/WebKit/gtk:

Use WebCore API to create errors in frame loader.

  • WebCoreSupport/AssertMatchingEnums.cpp:
  • WebCoreSupport/FrameLoaderClientGtk.cpp:

(WebKit::FrameLoaderClient::cancelledError):
(WebKit::FrameLoaderClient::blockedError):
(WebKit::FrameLoaderClient::cannotShowURLError):
(WebKit::FrameLoaderClient::interruptedForPolicyChangeError):
(WebKit::FrameLoaderClient::cannotShowMIMETypeError):
(WebKit::FrameLoaderClient::fileDoesNotExistError):
(WebKit::FrameLoaderClient::pluginWillHandleLoadError):

  • webkit/webkiterror.cpp:

(webkit_network_error_quark):
(webkit_policy_error_quark):
(webkit_plugin_error_quark):

Source/WebKit/gtk/po:

  • POTFILES: Remove FrameLoaderGtk.cpp and add ErrorsGtk.cpp.

Source/WebKit2:

Use WebCore API to create errors in WebProcess.

  • GNUmakefile.am: Don't use webkit/webkierror.h.
  • WebProcess/WebCoreSupport/gtk/WebErrorsGtk.cpp:

(WebKit::cancelledError):
(WebKit::blockedError):
(WebKit::cannotShowURLError):
(WebKit::interruptedForPolicyChangeError):
(WebKit::cannotShowMIMETypeError):
(WebKit::fileDoesNotExistError):
(WebKit::pluginWillHandleLoadError):

1:36 AM Changeset in webkit [95520] by reni@webkit.org
  • 1 edit
    10 adds in trunk/LayoutTests

[Qt] Add Qt specific expecteds to new tests introduced in r95461.

Unreviewed gardening.

  • platform/qt/fast/table/table-cell-before-after-content-around-table-block-expected.png: Added.
  • platform/qt/fast/table/table-cell-before-after-content-around-table-block-expected.txt: Added.
  • platform/qt/fast/table/table-cell-before-after-content-around-table-expected.png: Added.
  • platform/qt/fast/table/table-cell-before-after-content-around-table-expected.txt: Added.
  • platform/qt/fast/table/table-cell-before-after-content-around-table-row-expected.png: Added.
  • platform/qt/fast/table/table-cell-before-after-content-around-table-row-expected.txt: Added.
  • platform/qt/fast/table/table-row-before-after-content-around-block-expected.png: Added.
  • platform/qt/fast/table/table-row-before-after-content-around-block-expected.txt: Added.
  • platform/qt/fast/table/table-row-before-after-content-around-table-expected.png: Added.
  • platform/qt/fast/table/table-row-before-after-content-around-table-expected.txt: Added.
1:05 AM Changeset in webkit [95519] by reni@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] Two tests fail after r95488 & r95489
​https://bugs.webkit.org/show_bug.cgi?id=68428

Skip the failing tests.

Unreviewed gardening.

  • platform/qt/Skipped:
12:57 AM Changeset in webkit [95518] by Carlos Garcia Campos
  • 4 edits in trunk

2011-09-20 Carlos Garcia Campos <​cgarcia@igalia.com>

[GTK] Update NEWS and configure.ac for 1.5.90 release

Reviewed by Martin Robinson.

  • configure.ac:

2011-09-20 Philippe Normand <​pnormand@igalia.com>

[GTK] Update NEWS and configure.ac for 1.5.90 release

Reviewed by Martin Robinson.

  • NEWS:

Sep 19, 2011:

11:33 PM Changeset in webkit [95517] by mrowe@apple.com
  • 3 edits in trunk/Source/WebCore

Attempt to fix the Leopard build.

  • platform/mac/DisplaySleepDisabler.cpp:

(WebCore::DisplaySleepDisabler::DisplaySleepDisabler):

  • platform/mac/DisplaySleepDisabler.h:
9:33 PM Changeset in webkit [95516] by mhahnenberg@apple.com
  • 8 edits in trunk/Source/JavaScriptCore

Remove toPrimitive from JSCell
​https://bugs.webkit.org/show_bug.cgi?id=67875

Reviewed by Darin Adler.

Part of the refactoring process to un-virtualize JSCell. We move
all of the implicit functionality provided by the virtual toPrimitive method
in JSCell to be explicit in JSValue::toPrimitive and JSCell:toPrimitive while
also de-virtualizing JSCell::toPrimitive.

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
  • runtime/JSCell.cpp:

(JSC::JSCell::toPrimitive):

  • runtime/JSCell.h:

We replace JSNotAnObject::toPrimitive with defaultValue, which it overrides from
JSObject. This pushes the virtual method further down, enabling us to get rid
of the virtual call in JSCell. Eventually we'll probably have to deal with this
again, but we'll cross that bridge when we come to it.

  • runtime/JSNotAnObject.cpp:

(JSC::JSNotAnObject::defaultValue):

  • runtime/JSNotAnObject.h:
  • runtime/JSObject.h:
  • runtime/JSString.h:
9:30 PM Changeset in webkit [95515] by ggaren@apple.com
  • 1 edit in trunk/Source/cmake/OptionsWinCE.cmake

Removing one last case of DENABLE_JSC_MULTIPLE_THREADS -- the cmake folder doesn't seem to have a ChangeLog

9:24 PM Changeset in webkit [95514] by ggaren@apple.com
  • 2 edits in trunk/Source/WebKit/chromium

Removed ENABLE_JSC_MULTIPLE_THREADS and related #ifdefs.
​https://bugs.webkit.org/show_bug.cgi?id=68422

Missed this one case before.

  • features.gypi:
9:14 PM Changeset in webkit [95513] by mrowe@apple.com
  • 11 edits
    2 copies in trunk/Source

<​http://webkit.org/b/68421> Stop calling UpdateSystemActivity in places where we hold power assertions that achieve the same effect

On SnowLeopard and newer it's not necessary to call UpdateSystemActivity to prevent the screensaver from kicking
in as the NoDisplaySleep assertion now has that effect. It's also not necessary to hold both a NoDisplaySleep and
a NoIdleSleep assertion as the latter is implied by the former.

Source/WebCore:

Since there were multiple copies of the same code to disable display sleep spread across WebCore, WebKit and WebKit2
this patch takes the approach of moving this functionality to a new DisplaySleepDisabler class that lives in WebCore.
A class is used as it makes it easier to reason about the lifetime of the assertions and to ensure that the assertions will
always be released when their owning objects go away.

Reviewed by Dan Bernstein.

  • WebCore.exp.in:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/mac/DisplaySleepDisabler.cpp:

(WebCore::DisplaySleepDisabler::DisplaySleepDisabler): Register for the NoDisplaySleep assertion, and start our
system activity timer when on Leopard.
(WebCore::DisplaySleepDisabler::~DisplaySleepDisabler): Unregister for the assertion.
(WebCore::DisplaySleepDisabler::systemActivityTimerFired): Call UpdateSystemActivity to prevent the screensaver from
triggering on Leopard.

  • platform/mac/DisplaySleepDisabler.h:

(WebCore::DisplaySleepDisabler::create):

  • platform/mac/WebVideoFullscreenController.h:
  • platform/mac/WebVideoFullscreenController.mm:

(-[WebVideoFullscreenController dealloc]):
(-[WebVideoFullscreenController setupVideoOverlay:]): Remove the now-unnecessary explicit use of the WebCore namespace.
(-[WebVideoFullscreenController mediaElement]): Ditto.
(-[WebVideoFullscreenController setMediaElement:]): Ditto.
(-[WebVideoFullscreenController windowDidExitFullscreen]): Ditto.
(-[WebVideoFullscreenController updatePowerAssertions]): Create a DisplaySleepDisabler instance when transitioning from permitting
display sleep to disabling display sleep. Clear out our reference when sleep should be permitted, destroying any
disabler that we own.

Source/WebKit/mac:

Adopt the DisplaySleepDisabler class that was added to WebCore and remove all of duplicated logic from WebFullScreenController.

Reviewed by Dan Bernstein.

  • WebView/WebFullScreenController.h:
  • WebView/WebFullScreenController.mm:

(-[WebFullScreenController dealloc]):
(-[WebFullScreenController _updatePowerAssertions]): Create a DisplaySleepDisabler instance when transitioning from permitting
display sleep to disabling display sleep. Clear out our reference when sleep should be permitted, destroying any
disabler that we own.

Source/WebKit2:

Adopt the DisplaySleepDisabler class that was added to WebCore and remove all of duplicated logic from WKFullScreenWindowController.

Reviewed by Dan Bernstein.

  • UIProcess/mac/WKFullScreenWindowController.h:
  • UIProcess/mac/WKFullScreenWindowController.mm:

(-[WKFullScreenWindowController _updatePowerAssertions]): Create a DisplaySleepDisabler instance when transitioning from permitting
display sleep to disabling display sleep. Clear out our reference when sleep should be permitted, destroying any
disabler that we own. Also adds a FIXME about an error that was noticed while working in this code.

9:05 PM Changeset in webkit [95512] by ggaren@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

Removed ENABLE_LAZY_BLOCK_FREEING and related #ifdefs
​https://bugs.webkit.org/show_bug.cgi?id=68424

As discussed on webkit-dev. All ports build with threads enabled in JSC now.

This may break WinCE and other ports that have not built and tested with
this configuration. I've filed bugs for port maintainers. It's time for
WebKit to move forward.

Reviewed by Mark Rowe.

  • heap/Heap.cpp:

(JSC::Heap::Heap):
(JSC::Heap::~Heap):
(JSC::Heap::destroy):
(JSC::Heap::blockFreeingThreadMain):
(JSC::Heap::allocateBlock):
(JSC::Heap::freeBlocks):
(JSC::Heap::releaseFreeBlocks):

  • heap/Heap.h:
  • wtf/Platform.h:
8:55 PM Changeset in webkit [95511] by ggaren@apple.com
  • 11 edits in trunk/Source/JavaScriptCore

Removed ENABLE_WTF_MULTIPLE_THREADS and related #ifdefs
​https://bugs.webkit.org/show_bug.cgi?id=68423

As discussed on webkit-dev. All ports build with threads enabled in WTF now.

This may break WinCE and other ports that have not built and tested with
this configuration. I've filed bugs for port maintainers. It's time for
WebKit to move forward.

Reviewed by Mark Rowe.

  • wtf/CryptographicallyRandomNumber.cpp:

(WTF::ARC4Stream::ARC4RandomNumberGenerator::randomNumber):
(WTF::ARC4Stream::ARC4RandomNumberGenerator::randomValues):

  • wtf/FastMalloc.cpp:
  • wtf/Platform.h:
  • wtf/RandomNumber.cpp:

(WTF::randomNumber):

  • wtf/RefCountedLeakCounter.cpp:

(WTF::RefCountedLeakCounter::increment):
(WTF::RefCountedLeakCounter::decrement):

  • wtf/ThreadingPthreads.cpp:

(WTF::initializeThreading):

  • wtf/ThreadingWin.cpp:

(WTF::initializeThreading):

  • wtf/dtoa.cpp:

(WTF::pow5mult):

  • wtf/gtk/ThreadingGtk.cpp:

(WTF::initializeThreading):

  • wtf/qt/ThreadingQt.cpp:

(WTF::initializeThreading):

8:35 PM Changeset in webkit [95510] by ggaren@apple.com
  • 11 edits in trunk/Source/JavaScriptCore

Removed ENABLE_JSC_MULTIPLE_THREADS and related #ifdefs.
​https://bugs.webkit.org/show_bug.cgi?id=68422

As discussed on webkit-dev. All ports build with threads enabled in JSC now.

This may break WinCE and other ports that have not built and tested with
this configuration. I've filed bugs for port maintainers. It's time for
WebKit to move forward.

Reviewed by Sam Weinig.

  • API/APIShims.h:

(JSC::APIEntryShimWithoutLock::APIEntryShimWithoutLock):

  • API/JSContextRef.cpp:
  • heap/MachineStackMarker.cpp:

(JSC::MachineThreads::MachineThreads):
(JSC::MachineThreads::~MachineThreads):
(JSC::MachineThreads::gatherConservativeRoots):

  • heap/MachineStackMarker.h:
  • runtime/InitializeThreading.cpp:

(JSC::initializeThreadingOnce):
(JSC::initializeThreading):

  • runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::sharedInstance):

  • runtime/JSGlobalData.h:

(JSC::JSGlobalData::makeUsableFromMultipleThreads):

  • runtime/JSLock.cpp:
  • runtime/Structure.cpp:
  • wtf/Platform.h:
7:48 PM Changeset in webkit [95509] by rniwa@webkit.org
  • 3 edits
    4 adds in trunk

Hit testing on margins of body and head elements doesn't recur
​https://bugs.webkit.org/show_bug.cgi?id=40753

Reviewed by Darin Adler.

Source/WebCore:

The bug was caused by positionForPointRespectingEditingBoundaries's comparing the editability
of head/body and html elements when hit testing was done inside margins of head and body elements.

Fixed the bug by special-casing html element (any immediate child of render view with a render layer)
since margins of head and body elements are special.

Tests: editing/selection/click-on-body-margin.html

editing/selection/click-on-head-margin.html

  • rendering/RenderBlock.cpp:

(WebCore::positionForPointRespectingEditingBoundaries):

LayoutTests:

Add tests to click on margins of head and body elements. WebKit should not
(attempt to) place the caret after or before head and body elements.

  • editing/selection/click-on-body-margin-expected.txt: Added.
  • editing/selection/click-on-body-margin.html: Added.
  • editing/selection/click-on-head-margin-expected.txt: Added.
  • editing/selection/click-on-head-margin.html: Added.
7:07 PM Changeset in webkit [95508] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit/chromium

Ask for audio hardware buffer size instead of using hardwired constants.
​https://bugs.webkit.org/show_bug.cgi?id=67952

Patch by Raymond Toy <Raymond Toy> on 2011-09-19
Reviewed by Kenneth Russell.

  • public/WebKitPlatformSupport.h:

(WebKit::WebKitPlatformSupport::audioHardwareBufferSize): Declare
new member function audioHardwareBufferSize.

  • src/AudioDestinationChromium.cpp:

(WebCore::AudioDestinationChromium::AudioDestinationChromium):
Call audioHardwareBufferSize() to get buffer size; update
m_callbackBuffersize and m_renderCountPerCallback appropriately.
Remove global variables callbackBufferSize and
renderCountPerCallback. Add constant for maximum
allowed buffer size and verify we don't exceed it.
(WebCore::AudioDestinationChromium::render): Use new member
variables instead of globals.

  • src/AudioDestinationChromium.h:

Define new member variables m_callbackBufferSize and
m_renderCountPerCallback

6:53 PM Changeset in webkit [95507] by commit-queue@webkit.org
  • 15 edits
    3 deletes in trunk/Source

Unreviewed, rolling out r95493 and r95496.
​http://trac.webkit.org/changeset/95493
​http://trac.webkit.org/changeset/95496
​https://bugs.webkit.org/show_bug.cgi?id=68418

Broke Windows build (Requested by rniwa on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2011-09-19

Source/JavaScriptCore:

(JSC::Debugger::recompileAllJSFunctions):

  • heap/AllocationSpace.cpp: Removed.
  • heap/AllocationSpace.h: Removed.
  • heap/Heap.cpp:

(JSC::CountFunctor::TakeIfEmpty::TakeIfEmpty):
(JSC::CountFunctor::TakeIfEmpty::operator()):
(JSC::CountFunctor::TakeIfEmpty::returnValue):
(JSC::Heap::Heap):
(JSC::Heap::reportExtraMemoryCostSlowCase):
(JSC::Heap::tryAllocate):
(JSC::Heap::allocateSlowCase):
(JSC::Heap::getConservativeRegisterRoots):
(JSC::Heap::markRoots):
(JSC::Heap::clearMarks):
(JSC::Heap::sweep):
(JSC::Heap::objectCount):
(JSC::Heap::size):
(JSC::Heap::capacity):
(JSC::Heap::globalObjectCount):
(JSC::Heap::objectTypeCounts):
(JSC::Heap::collect):
(JSC::Heap::canonicalizeBlocks):
(JSC::Heap::resetAllocator):
(JSC::Heap::allocateBlock):
(JSC::Heap::freeBlocks):
(JSC::Heap::shrink):

  • heap/Heap.h:

(JSC::Heap::markedSpace):
(JSC::Heap::forEachCell):
(JSC::Heap::forEachBlock):
(JSC::Heap::sizeClassFor):
(JSC::Heap::allocate):

  • jit/JITInlineMethods.h:

(JSC::JIT::emitAllocateBasicJSObject):

  • runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::recompileAllJSFunctions):
(JSC::JSGlobalData::releaseExecutableMemory):

Source/WebCore:

  • ForwardingHeaders/heap/AllocationSpace.h: Removed.
6:49 PM Changeset in webkit [95506] by commit-queue@webkit.org
  • 8 edits in trunk/Source/WebCore

[chromium] ContentLayer's texture updater deleted during paint when compositing turns off in the middle of paint
​https://bugs.webkit.org/show_bug.cgi?id=68405

Patch by James Robinson <​jamesr@chromium.org> on 2011-09-19
Reviewed by Kenneth Russell.

Make TiledLayerChromium's textureUpdater refcounted and hold an explicit reference during paint in case
compositing is turned off halfway through a paint.

  • platform/graphics/chromium/ContentLayerChromium.h:
  • platform/graphics/chromium/ImageLayerChromium.cpp:

(WebCore::ImageLayerTextureUpdater::create):

  • platform/graphics/chromium/ImageLayerChromium.h:
  • platform/graphics/chromium/LayerTextureUpdater.h:
  • platform/graphics/chromium/LayerTextureUpdaterCanvas.cpp:

(WebCore::LayerTextureUpdaterBitmap::create):
(WebCore::LayerTextureUpdaterSkPicture::create):

  • platform/graphics/chromium/LayerTextureUpdaterCanvas.h:
  • platform/graphics/chromium/TiledLayerChromium.cpp:

(WebCore::TiledLayerChromium::prepareToUpdate):

6:44 PM Changeset in webkit [95505] by barraclough@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Errrk, missed stylebot comments in last commit.

  • runtime/StringPrototype.cpp:

(JSC::stringProtoFuncSplit):

6:41 PM Changeset in webkit [95504] by barraclough@apple.com
  • 9 edits
    3 adds in trunk

String#split is buggy
​https://bugs.webkit.org/show_bug.cgi?id=68348

Reviewed by Sam Weinig.

Source/JavaScriptCore:

  • runtime/StringPrototype.cpp:

(JSC::jsStringWithReuse):

  • added helper function to reuse original JSString value.

(JSC::stringProtoFuncSplit):

  • Rewritten from the spec.
  • tests/mozilla/ecma/String/15.5.4.8-2.js:

(getTestCases):

  • This test is not ES5 compliant.

LayoutTests:

  • fast/js/script-tests/string-split-conformance.js: Added.
  • fast/js/string-split-conformance-expected.txt: Added.
  • fast/js/string-split-conformance.html: Added.
    • Added new Layout test based on:

​http://stevenlevithan.com/demo/split.cfm

  • sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.14_String.prototype.split/S15.5.4.14_A1_T6-expected.txt:
  • sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.14_String.prototype.split/S15.5.4.14_A1_T7-expected.txt:
  • sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.14_String.prototype.split/S15.5.4.14_A1_T8-expected.txt:
  • sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.14_String.prototype.split/S15.5.4.14_A1_T9-expected.txt:
  • sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.14_String.prototype.split/S15.5.4.14_A2_T7-expected.txt:
6:21 PM Changeset in webkit [95503] by ggaren@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

Removed lots of friend declarations from JSCell, so we can more
effectively make use of private and protected.

Reviewed by Sam Weinig.

  • runtime/JSCell.h: Removed MSVCBugWorkaround because it was a lot of

confusion for not much safety.
(JSC::JSCell::operator new): Made this public because it is used by a
few clients, and not really dangerous.

  • runtime/JSObject.cpp:

(JSC::JSObject::put):
(JSC::JSObject::deleteProperty):
(JSC::JSObject::defineGetter):
(JSC::JSObject::defineSetter):
(JSC::JSObject::getPropertySpecificValue):
(JSC::JSObject::getOwnPropertyNames):
(JSC::JSObject::seal):
(JSC::JSObject::freeze):
(JSC::JSObject::preventExtensions):
(JSC::JSObject::removeDirect):
(JSC::JSObject::createInheritorID):
(JSC::JSObject::allocatePropertyStorage):
(JSC::JSObject::getOwnPropertyDescriptor):

  • runtime/JSObject.h:

(JSC::JSObject::getDirect):
(JSC::JSObject::getDirectLocation):
(JSC::JSObject::hasCustomProperties):
(JSC::JSObject::hasGetterSetterProperties):
(JSC::JSObject::isSealed):
(JSC::JSObject::isFrozen):
(JSC::JSObject::isExtensible):
(JSC::JSObject::flattenDictionaryObject):
(JSC::JSObject::finishCreation):
(JSC::JSObject::prototype):
(JSC::JSObject::setPrototype):
(JSC::JSObject::inlineGetOwnPropertySlot):
(JSC::JSCell::fastGetOwnProperty):
(JSC::JSObject::putDirectInternal):
(JSC::JSObject::putDirectWithoutTransition):
(JSC::JSObject::transitionTo):
(JSC::JSObject::visitChildrenDirect): Changed all use of m_structure to
structure() / setStructure(), so we don't have to be a friend of JSCell.

  • runtime/Structure.h:

(JSC::JSCell::setStructure): Added, to avoid direct access by JSObject
to JSCell::m_structure.

6:20 PM Changeset in webkit [95502] by macpherson@chromium.org
  • 17 edits in trunk/Source/WebCore

Eliminate Length::undefinedLength = -1 and replace with Undefined LengthType.
​https://bugs.webkit.org/show_bug.cgi?id=68057

Reviewed by Darin Adler.

There appear to be many cases where -1 is actually a valid Length.
Encoding the validity of Length separately to the value is a natural solution.

No new tests / no behavioral changes.

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

  • css/CSSPrimitiveValue.cpp:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):

  • css/CSSStyleApplyProperty.cpp:

(WebCore::ApplyPropertyLength::applyValue):

  • platform/Length.h:

(WebCore::Length::Length):
(WebCore::Length::value):
(WebCore::Length::calcValue):
(WebCore::Length::calcMinValue):
(WebCore::Length::calcFloatValue):
(WebCore::Length::isUndefined):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::computePreferredLogicalWidths):

  • rendering/RenderDeprecatedFlexibleBox.cpp:

(WebCore::RenderDeprecatedFlexibleBox::computePreferredLogicalWidths):

  • rendering/RenderFileUploadControl.cpp:

(WebCore::RenderFileUploadControl::computePreferredLogicalWidths):

  • rendering/RenderImage.cpp:

(WebCore::RenderImage::isLogicalWidthSpecified):
(WebCore::RenderImage::isLogicalHeightSpecified):

  • rendering/RenderListBox.cpp:

(WebCore::RenderListBox::computePreferredLogicalWidths):

  • rendering/RenderMenuList.cpp:

(WebCore::RenderMenuList::computePreferredLogicalWidths):

  • rendering/RenderReplaced.cpp:

(WebCore::RenderReplaced::computePreferredLogicalWidths):

  • rendering/RenderSlider.cpp:

(WebCore::RenderSlider::computePreferredLogicalWidths):

  • rendering/RenderTextControl.cpp:

(WebCore::RenderTextControl::computePreferredLogicalWidths):

  • rendering/style/RenderStyle.h:

(WebCore::InheritedFlags::initialMaxSize):

  • rendering/svg/RenderSVGRoot.cpp:

(WebCore::RenderSVGRoot::computePreferredLogicalWidths):

6:04 PM Changeset in webkit [95501] by abarth@webkit.org
  • 33 edits in trunk

Always enable ENABLE(EVENTSOURCE)
​https://bugs.webkit.org/show_bug.cgi?id=68414

Reviewed by Eric Seidel.

.:

  • Source/cmake/OptionsEfl.cmake:
  • Source/cmake/OptionsWinCE.cmake:
  • Source/cmakeconfig.h.cmake:
  • configure.ac:

Source/JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig:

Source/WebCore:

EventSource seems to be here to stay. This patch makes WebKit more
hackable by removing this ENABLE macro, as discussed on webkit-dev.

  • Configurations/FeatureDefines.xcconfig:
  • GNUmakefile.am:
  • bindings/cpp/WebDOMEventTarget.cpp:

(toWebKit):

  • bindings/js/JSDOMWindowCustom.cpp:

(WebCore::JSDOMWindow::eventSource):

  • bindings/js/JSEventSourceCustom.cpp:
  • bindings/js/JSEventTarget.cpp:

(WebCore::toJS):
(WebCore::toEventTarget):

  • bindings/js/JSWorkerContextCustom.cpp:

(WebCore::JSWorkerContext::eventSource):

  • bindings/v8/V8DOMWrapper.cpp:

(WebCore::V8DOMWrapper::convertEventTargetToV8Object):

  • features.pri:
  • page/DOMWindow.idl:
  • page/EventSource.cpp:
  • page/EventSource.h:
  • page/EventSource.idl:
  • workers/WorkerContext.idl:

Source/WebKit/chromium:

  • features.gypi:

Source/WebKit/mac:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

  • Configurations/FeatureDefines.xcconfig:

Tools:

  • Scripts/build-webkit:

WebKitLibraries:

  • win/tools/vsprops/FeatureDefines.vsprops:
  • win/tools/vsprops/FeatureDefinesCairo.vsprops:
5:56 PM Changeset in webkit [95500] by levin@chromium.org
  • 4 edits in trunk/Tools

Sheriffbot rollout should be more intuitive.
​https://bugs.webkit.org/show_bug.cgi?id=68415

Reviewed by Adam Barth.

  • Scripts/webkitpy/tool/bot/irc_command.py: Add support for revert and comma separated args.
  • Scripts/webkitpy/tool/bot/irc_command_unittest.py: Add parsing tests for comma separated args and a few others cases.
  • Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py: Verify that revert works.
5:38 PM Changeset in webkit [95499] by levin@chromium.org
  • 3 edits in trunk/Tools

check-webkit-style generates bogus warning for StructuredExceptionHandlerSupressor.h
​https://bugs.webkit.org/show_bug.cgi?id=68391

Reviewed by Darin Adler.

  • Scripts/webkitpy/style/checkers/cpp.py: Skip asm lines when doing style checks on a line.
  • Scripts/webkitpy/style/checkers/cpp_unittest.py: Added a test for this.
5:35 PM Changeset in webkit [95498] by commit-queue@webkit.org
  • 3 edits in trunk/Source/JavaScriptCore

Enable JSC_MULTIPLE_THREADS for OS(QNX).
​https://bugs.webkit.org/show_bug.cgi?id=68047

Patch by Eli Fidler <​efidler@rim.com> on 2011-09-19
Reviewed by Daniel Bates.

SA_RESTART was required for SIGUSR2-based debugging, but is not
present on QNX. This debugging doesn't seem critical to
JSC_MULTIPLE_THREADS, so allow it to proceed.

  • heap/MachineStackMarker.cpp:

(JSC::MachineThreads::Thread::Thread):
(JSC::getPlatformThreadRegisters):
(JSC::otherThreadStackPointer):
(JSC::freePlatformThreadRegisters):

  • wtf/Platform.h: enable PTHREADS for OS(QNX)
5:19 PM Changeset in webkit [95497] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Fix a use-after-free: clear the fullscreen change event target queue at
detach time, rather than at destruction time. If this isn't done, it's
possible for the event target queue to be the only thing that
references the document. Then when the document is popped off the queue
and dereferenced in Document::fullScreenChangeDelayTimerFired, the
document is destroyed and the subsequent access to
m_fullScreenChangeEventTargetQueue.isEmpty() accesses free'd memory.
​https://bugs.webkit.org/show_bug.cgi?id=67960

Patch by Jeremy Apthorp <​jeremya@chromium.org> on 2011-09-19
Reviewed by Adam Barth.

  • dom/Document.cpp:

(WebCore::Document::~Document):
(WebCore::Document::detach):

4:50 PM Changeset in webkit [95496] by oliver@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Windows build fix.

4:49 PM Changeset in webkit [95495] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Suppress flakey test on windows in Chromium gesture recognizer
​https://bugs.webkit.org/show_bug.cgi?id=68408

Patch by Robert Kroeger <​rjkroege@chromium.org> on 2011-09-19
Reviewed by Adam Barth.

  • tests/InnerGestureRecognizerTest.cpp:

(TEST_F):

4:48 PM Changeset in webkit [95494] by commit-queue@webkit.org
  • 5 edits in trunk

Unreviewed, rolling out r95482.
​http://trac.webkit.org/changeset/95482
​https://bugs.webkit.org/show_bug.cgi?id=68410

Broke chromium webkit-tests (Requested by dslomov on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2011-09-19

Source/WebCore:

  • platform/image-encoders/skia/JPEGImageEncoder.cpp:

(WebCore::RGBAtoRGB):

LayoutTests:

  • fast/canvas/webgl/premultiplyalpha-test-expected.txt:
  • fast/canvas/webgl/premultiplyalpha-test.html:
4:15 PM Changeset in webkit [95493] by oliver@apple.com
  • 14 edits
    3 adds in trunk/Source

Refactor Heap allocation logic into separate AllocationSpace class
​https://bugs.webkit.org/show_bug.cgi?id=68409

Reviewed by Gavin Barraclough.

../../../../Volumes/Data/git/WebKit/OpenSource/Source/JavaScriptCore:

This patch hoists direct manipulation of the MarkedSpace and related
data out of Heap and into a separate class. This will allow us to
have multiple allocation spaces in future, so easing the way towards
having GC'd backing stores for objects.

(JSC::Debugger::recompileAllJSFunctions):

  • heap/AllocationSpace.cpp: Added.

(JSC::AllocationSpace::tryAllocate):
(JSC::AllocationSpace::allocateSlowCase):
(JSC::AllocationSpace::allocateBlock):
(JSC::AllocationSpace::freeBlocks):
(JSC::TakeIfEmpty::TakeIfEmpty):
(JSC::TakeIfEmpty::operator()):
(JSC::TakeIfEmpty::returnValue):
(JSC::AllocationSpace::shrink):

  • heap/AllocationSpace.h: Added.

(JSC::AllocationSpace::AllocationSpace):
(JSC::AllocationSpace::blocks):
(JSC::AllocationSpace::sizeClassFor):
(JSC::AllocationSpace::setHighWaterMark):
(JSC::AllocationSpace::highWaterMark):
(JSC::AllocationSpace::canonicalizeBlocks):
(JSC::AllocationSpace::resetAllocator):
(JSC::AllocationSpace::forEachCell):
(JSC::AllocationSpace::forEachBlock):
(JSC::AllocationSpace::allocate):

  • heap/Heap.cpp:

(JSC::Heap::Heap):
(JSC::Heap::reportExtraMemoryCostSlowCase):
(JSC::Heap::getConservativeRegisterRoots):
(JSC::Heap::markRoots):
(JSC::Heap::clearMarks):
(JSC::Heap::sweep):
(JSC::Heap::objectCount):
(JSC::Heap::size):
(JSC::Heap::capacity):
(JSC::Heap::globalObjectCount):
(JSC::Heap::objectTypeCounts):
(JSC::Heap::collect):
(JSC::Heap::canonicalizeBlocks):
(JSC::Heap::resetAllocator):
(JSC::Heap::freeBlocks):
(JSC::Heap::shrink):

  • heap/Heap.h:

(JSC::Heap::objectSpace):
(JSC::Heap::sizeClassForObject):
(JSC::Heap::allocate):

  • jit/JITInlineMethods.h:

(JSC::JIT::emitAllocateBasicJSObject):

  • runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::recompileAllJSFunctions):
(JSC::JSGlobalData::releaseExecutableMemory):

../../../../Volumes/Data/git/WebKit/OpenSource/Source/WebCore:

Adding a forwarding header.

  • ForwardingHeaders/heap/AllocationSpace.h: Added.
4:13 PM Changeset in webkit [95492] by alexis.menard@openbossa.org
  • 4 edits in trunk/Source/WebKit2

[Qt] Unreviewed coding style fix.

  • UIProcess/API/qt/qdesktopwebview.h:
  • UIProcess/API/qt/qtouchwebpage.h:
  • UIProcess/API/qt/qweberror.h:
4:04 PM Changeset in webkit [95491] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebKit/chromium

Expose AXObjectCache methods so that WebAccessibilityCache
can be deleted.
​https://bugs.webkit.org/show_bug.cgi?id=68225

Patch by Dominic Mazzoni <​dmazzoni@google.com> on 2011-09-19
Reviewed by Dimitri Glazkov.

This patch exposes the functionality needed from AXObjectCache
with new methods in WebAccessibilityObject and WebDocument.
Next, Chromium will be updated to use only these methods and
not WebAccessibilityCache. Then, WebAccessibilityCache can be
deleted from WebKit.

  • public/WebAccessibilityObject.h:
  • public/WebDocument.h:
  • src/WebAccessibilityObject.cpp:

(WebKit::WebAccessibilityObject::enableAccessibility):
(WebKit::WebAccessibilityObject::accessibilityEnabled):
(WebKit::WebAccessibilityObject::axID):

  • src/WebDocument.cpp:

(WebKit::WebDocument::accessibilityObject):
(WebKit::WebDocument::accessibilityObjectFromID):

4:02 PM Changeset in webkit [95490] by bbudge@chromium.org
  • 4 edits in trunk/Source/WebKit/chromium

Perform HTTP method and header validation in AssociatedURLLoader for
requests coming from untrusted code (eg. Native Client in Chrome). Use
the same code as XMLHttpRequest to reduce code duplication and have
behavior identical to XHR in Javascript. Add an 'untrustedHTTP' option
to WebURLLoaderOptions, which AssociatedURLLoader can use to determine
if it should check the request method and headers.
​https://bugs.webkit.org/show_bug.cgi?id=67655

Reviewed by Darin Fisher.

  • public/WebURLLoaderOptions.h:

(WebKit::WebURLLoaderOptions::WebURLLoaderOptions):

  • src/AssociatedURLLoader.cpp:

(WebKit::AssociatedURLLoader::ClientAdapter::setDelayedError):
(WebKit::AssociatedURLLoader::loadAsynchronously):

  • tests/AssociatedURLLoaderTest.cpp:

(WebKit::AssociatedURLLoaderTest::CheckMethodFails):
(WebKit::AssociatedURLLoaderTest::CheckHeaderFails):
(WebKit::AssociatedURLLoaderTest::CheckFails):
(WebKit::TEST_F):

3:57 PM Changeset in webkit [95489] by abarth@webkit.org
  • 8 edits
    2 adds in trunk

[V8] document.all gets confused about its prototype chain
​https://bugs.webkit.org/show_bug.cgi?id=68393

Reviewed by Eric Seidel.

Source/WebCore:

GetRealNamedPropertyInPrototypeChain doesn't call interceptors, so it's
not a good idea to use its return value. It turns out that all the
callers of the API only cared about whether it returns a null handle.

Test: http/tests/security/document-all.html

  • bindings/v8/V8Collection.h:

(WebCore::collectionNamedPropertyGetter):

  • bindings/v8/custom/V8DOMStringMapCustom.cpp:

(WebCore::V8DOMStringMap::namedPropertyDeleter):
(WebCore::V8DOMStringMap::namedPropertySetter):

  • bindings/v8/custom/V8HTMLAllCollectionCustom.cpp:

(WebCore::V8HTMLAllCollection::namedPropertyGetter):

  • bindings/v8/custom/V8HTMLCollectionCustom.cpp:

(WebCore::V8HTMLCollection::namedPropertyGetter):

  • bindings/v8/custom/V8NamedNodeMapCustom.cpp:

(WebCore::V8NamedNodeMap::namedPropertyGetter):

  • bindings/v8/custom/V8StorageCustom.cpp:

(WebCore::storageSetter):

LayoutTests:

Test how document.all behaves when you change its prototype chain.

  • http/tests/security/document-all-expected.txt: Added.
  • http/tests/security/document-all.html: Added.
3:56 PM Changeset in webkit [95488] by abarth@webkit.org
  • 3 edits
    3 adds in trunk

Named property confusion with proto
​https://bugs.webkit.org/show_bug.cgi?id=68221

Reviewed by Eric Seidel.

Source/WebCore:

The proto property is super magical because it's not a real named
property and it has higher precedence than even interceptors. This
confuses this check, which is meant to detech which names will get
handled by our interceptor.

Test: http/tests/security/window-named-proto.html

  • bindings/v8/custom/V8DOMWindowCustom.cpp:

(WebCore::V8DOMWindow::namedSecurityCheck):

LayoutTests:

  • http/tests/security/resources/innocent-victim-with-iframe.html: Added.
  • http/tests/security/window-named-proto-expected.txt: Added.
  • http/tests/security/window-named-proto.html: Added.
3:54 PM Changeset in webkit [95487] by abarth@webkit.org
  • 9 edits in trunk/Source

Rename ENABLE(OPENTYPE_SANITIZER) to USE(OPENTYPE_SANITIZER)
​https://bugs.webkit.org/show_bug.cgi?id=68292

Reviewed by Eric Seidel.

Source/WebCore:

OpenType Sanitizer is a library for sanitizing type and not a feature.
Therefore this macro should say that we USE the library.

  • platform/graphics/WOFFFileFormat.cpp:
  • platform/graphics/WOFFFileFormat.h:
  • platform/graphics/mac/FontCustomPlatformData.cpp:

(WebCore::createFontCustomPlatformData):

  • platform/graphics/opentype/OpenTypeSanitizer.cpp:
  • platform/graphics/opentype/OpenTypeSanitizer.h:
  • platform/graphics/skia/FontCustomPlatformData.cpp:

(WebCore::createFontCustomPlatformData):
(WebCore::FontCustomPlatformData::supportsFormat):

Source/WebKit/chromium:

  • features.gypi:
3:53 PM Changeset in webkit [95486] by abarth@webkit.org
  • 8 edits
    1 delete in trunk/Source/WebCore

Remove APPLICATION_CACHE_DYNAMIC_ENTRIES and associated code
​https://bugs.webkit.org/show_bug.cgi?id=68407

Reviewed by Eric Seidel.

As discussed on webkit-dev, no one appears to be using this code.

  • GNUmakefile.list.am:
  • UseJSC.cmake:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSBindingsAllInOne.cpp:
  • bindings/js/JSDOMApplicationCacheCustom.cpp: Removed.
3:32 PM Changeset in webkit [95485] by Adam Roben
  • 2 edits in trunk/Source/JavaScriptCore

Windows build fix after r95310

include\private\JavaScriptCore to the include path so DFGIntrinsic.h can be found.

3:27 PM Changeset in webkit [95484] by fpizlo@apple.com
  • 14 edits in trunk/Source/JavaScriptCore

DFG speculation failures should act as additional value profiles
​https://bugs.webkit.org/show_bug.cgi?id=68335

Reviewed by Oliver Hunt.

This adds slow-case counters to the old JIT. It also ensures that
negative zero in multiply is handled carefully. The old JIT
previously took slow path if the result of a multiply was zero,
which, without any changes, would cause the DFG to think that
every such multiply produced a double result.

This also fixes a bug in the old JIT's handling of decrements. It
would take the slow path if the result was zero, but not if it
underflowed.

By itself, this would be a 1% slow-down on V8 and Kraken. But then
I wrote optimizations in the DFG that take advantage of this new
information. It's no longer the case that every multiply needs to
do a check for negative zero; it only happens if the negative
zero is ignored.

This results in a 12% speed-up on v8-crypto, for a 1.4% geomean
speed-up in V8. It's mostly neutral on Kraken. I can see an
0.5% slow-down and it appears to be significant.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::resetRareCaseProfiles):
(JSC::CodeBlock::dumpValueProfiles):

  • bytecode/CodeBlock.h:
  • bytecode/ValueProfile.h:

(JSC::RareCaseProfile::RareCaseProfile):
(JSC::getRareCaseProfileBytecodeOffset):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::toInt32):
(JSC::DFG::ByteCodeParser::makeSafe):
(JSC::DFG::ByteCodeParser::parseBlock):

  • dfg/DFGJITCodeGenerator.cpp:

(JSC::DFG::GPRTemporary::GPRTemporary):

  • dfg/DFGJITCodeGenerator.h:
  • dfg/DFGNode.h:
  • dfg/DFGPropagator.cpp:

(JSC::DFG::Propagator::propagateNode):
(JSC::DFG::Propagator::fixupNode):
(JSC::DFG::Propagator::clobbersWorld):
(JSC::DFG::Propagator::performNodeCSE):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compile):
(JSC::DFG::SpeculativeJIT::computeValueRecoveryFor):

  • jit/JIT.cpp:

(JSC::JIT::privateCompileSlowCases):

  • jit/JIT.h:

(JSC::JIT::linkDummySlowCase):

  • jit/JITArithmetic.cpp:

(JSC::JIT::emit_op_post_dec):
(JSC::JIT::emit_op_pre_dec):
(JSC::JIT::compileBinaryArithOp):
(JSC::JIT::emit_op_add):
(JSC::JIT::emitSlow_op_add):

  • jit/JITInlineMethods.h:

(JSC::JIT::addSlowCase):

3:26 PM Changeset in webkit [95483] by commit-queue@webkit.org
  • 11 edits
    2 deletes in trunk/Source

Unreviewed, rolling out r95385 and r95457.
​http://trac.webkit.org/changeset/95385
​http://trac.webkit.org/changeset/95457
​https://bugs.webkit.org/show_bug.cgi?id=68395

Broke chromium browser_tests (Requested by dslomov on
#webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2011-09-19

Source/WebCore:

  • bindings/v8/V8DOMWindowShell.cpp:

(WebCore::V8DOMWindowShell::disposeContextHandles):
(WebCore::V8DOMWindowShell::initContextIfNeeded):

  • bindings/v8/V8IsolatedContext.cpp:

(WebCore::V8IsolatedContext::V8IsolatedContext):
(WebCore::V8IsolatedContext::destroy):

  • bindings/v8/V8IsolatedContext.h:
  • loader/EmptyClients.h:

(WebCore::EmptyFrameLoaderClient::didCreateScriptContextForFrame):
(WebCore::EmptyFrameLoaderClient::didDestroyScriptContextForFrame):
(WebCore::EmptyFrameLoaderClient::didCreateIsolatedScriptContext):

  • loader/FrameLoaderClient.h:

Source/WebKit/chromium:

  • public/WebFrameClient.h:

(WebKit::WebFrameClient::didCreateIsolatedScriptContext):

  • src/FrameLoaderClientImpl.cpp:

(WebKit::FrameLoaderClientImpl::didCreateScriptContextForFrame):
(WebKit::FrameLoaderClientImpl::didDestroyScriptContextForFrame):
(WebKit::FrameLoaderClientImpl::didCreateIsolatedScriptContext):

  • src/FrameLoaderClientImpl.h:
  • tests/WebFrameTest.cpp:

(WebKit::TEST_F):

  • tests/data/context_notifications_test.html: Removed.
  • tests/data/context_notifications_test_frame.html: Removed.
3:23 PM Changeset in webkit [95482] by commit-queue@webkit.org
  • 5 edits in trunk

Fix nonpremultiplied webgl toDataURL to jpeg
​https://bugs.webkit.org/show_bug.cgi?id=68366

Source/WebCore:

The canvas spec says that toDataURL to formats without an alpha must
be "composited onto a solid black background using the source-over
operator." Do that.

Patch by John Bauman <​jbauman@chromium.org> on 2011-09-19
Reviewed by Kenneth Russell.

  • platform/image-encoders/skia/JPEGImageEncoder.cpp:

(WebCore::RGBAtoRGB):

LayoutTests:

Update the premultiplyalpha-test from the WebGL conformance tests.

Patch by John Bauman <​jbauman@chromium.org> on 2011-09-19
Reviewed by Kenneth Russell.

  • fast/canvas/webgl/premultiplyalpha-test-expected.txt:
  • fast/canvas/webgl/premultiplyalpha-test.html:
3:20 PM Changeset in webkit [95481] by Adam Roben
  • 2 edits in trunk/Source/ThirdParty/ANGLE

Let Xcode 4 do its thang with ANGLE.xcodeproj

  • ANGLE.xcodeproj/project.pbxproj:
3:20 PM Changeset in webkit [95480] by Adam Roben
  • 2 edits in trunk/Source/JavaScriptCore

Windows build fix after r94575

  • JavaScriptCore.vcproj/JavaScriptCore.sln: Relinearized project dependencies. testRegExp

now builds just before FindSafari.

2:56 PM Changeset in webkit [95479] by cmarrin@apple.com
  • 4 edits
    1 add in trunk/Source/WebCore

2011-09-19 Chris Marrin <​cmarrin@apple.com>

Crash can occur when doing a PlatformCAAnimation::copy() with no valueFunction
​https://bugs.webkit.org/show_bug.cgi?id=67510

Reviewed by Adam Roben.


Another fix to take care of one last crash when running pause-crash.html.
CACF can't deal with null valueFunctions, so avoid setting it when it doesn't
exist.


This also adds logic to the Windows Hook in LayerChangesFlusher to prevent it
from catching the null pointer exception generated by the pause-crash.html test
before this bug was fixed. Windows was ignoring the exception, so the testcase
would appear to succeed, even though it should have crashed.

This is a resubmission of ​http://trac.webkit.org/changeset/95243 with a build fix.

  • WebCore.vcproj/WebCore.vcproj:
  • platform/graphics/ca/win/LayerChangesFlusher.cpp: (WebCore::LayerChangesFlusher::hookCallback):
  • platform/graphics/ca/win/PlatformCAAnimationWin.cpp: (PlatformCAAnimation::copy):
  • platform/win/StructuredExceptionHandlerSupressor.h: Added. (WebCore::StructuredExceptionHandlerSupressor::StructuredExceptionHandlerSupressor): (WebCore::StructuredExceptionHandlerSupressor::~StructuredExceptionHandlerSupressor):
2:51 PM Changeset in webkit [95478] by rniwa@webkit.org
  • 3 edits
    2 adds in trunk

Incorrect selection with absolutely positioned div
​https://bugs.webkit.org/show_bug.cgi?id=39503

Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

The bug was caused by a false assumption in RenderBlock::positionForPoint. Because the last child box
can be positioned, floated, invisible, etc..., we can't always trust last child's logicalTop to tell us
whether a given point is inside or below the last child box.

Fixed the bug by using the last hit-test candidate instead.

Test: editing/selection/block-with-positioned-lastchild.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::positionForPoint):

LayoutTests:

Added a regression test for placing the caret inside a block with multiple logical lines
with an absolutely positioned last child. WebKit should place the caret on the left of the first line
(instead of after the last line) when the user clicks on the left of the first line.

  • editing/selection/block-with-positioned-lastchild-expected.txt: Added.
  • editing/selection/block-with-positioned-lastchild.html: Added.
2:48 PM Changeset in webkit [95477] by inferno@chromium.org
  • 1 edit
    15 adds in trunk/LayoutTests

Unreviewed. Chromium Rebaselines for r95461.

  • platform/chromium-linux/fast/table/table-cell-before-after-content-around-table-block-expected.png: Added.
  • platform/chromium-linux/fast/table/table-cell-before-after-content-around-table-expected.png: Added.
  • platform/chromium-linux/fast/table/table-cell-before-after-content-around-table-row-expected.png: Added.
  • platform/chromium-linux/fast/table/table-row-before-after-content-around-block-expected.png: Added.
  • platform/chromium-linux/fast/table/table-row-before-after-content-around-table-expected.png: Added.
  • platform/chromium-mac/fast/table/table-cell-before-after-content-around-table-block-expected.png: Added.
  • platform/chromium-mac/fast/table/table-cell-before-after-content-around-table-expected.png: Added.
  • platform/chromium-mac/fast/table/table-cell-before-after-content-around-table-row-expected.png: Added.
  • platform/chromium-mac/fast/table/table-row-before-after-content-around-block-expected.png: Added.
  • platform/chromium-mac/fast/table/table-row-before-after-content-around-table-expected.png: Added.
  • platform/chromium-win/fast/table/table-cell-before-after-content-around-table-block-expected.png: Added.
  • platform/chromium-win/fast/table/table-cell-before-after-content-around-table-expected.png: Added.
  • platform/chromium-win/fast/table/table-cell-before-after-content-around-table-row-expected.png: Added.
  • platform/chromium-win/fast/table/table-row-before-after-content-around-block-expected.png: Added.
  • platform/chromium-win/fast/table/table-row-before-after-content-around-table-expected.png: Added.
2:47 PM Changeset in webkit [95476] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit/mac

Fix crashes when running WebKit1 tests.

-[WebView _mustDrawUnionedRect:singleRects:count:] was removed, so just put back the
equivalent code directly into -[WebHTMLView drawRect:].

  • WebView/WebHTMLView.mm:

(-[WebHTMLView drawRect:]):

  • WebView/WebViewInternal.h:
2:28 PM Changeset in webkit [95475] by commit-queue@webkit.org
  • 8 edits in trunk/Source/JavaScriptCore

Unreviewed, rolling out r95466.
​http://trac.webkit.org/changeset/95466
​https://bugs.webkit.org/show_bug.cgi?id=68389

Incorrect version of the patch. (Requested by mhahnenberg on
#webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2011-09-19

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
  • runtime/JSCell.cpp:

(JSC::JSCell::toPrimitive):

  • runtime/JSCell.h:

(JSC::JSCell::JSValue::toPrimitive):

  • runtime/JSNotAnObject.cpp:

(JSC::JSNotAnObject::toPrimitive):

  • runtime/JSNotAnObject.h:
  • runtime/JSObject.h:
  • runtime/JSString.h:
2:25 PM Changeset in webkit [95474] by andersca@apple.com
  • 5 edits in trunk/Source/WebKit/mac

Remove the last remains of viewless WebKit1
​https://bugs.webkit.org/show_bug.cgi?id=68388

Reviewed by Darin Adler.

  • WebCoreSupport/WebFrameLoaderClient.mm:

(WebFrameLoaderClient::forceLayoutForNonHTML):
Remove null check.

  • WebView/WebView.mm:

(-[WebView _commonInitializationWithFrameName:groupName:]):
Remove usesDocumentViews parameter and checks.

(-[WebView _initWithFrame:frameName:groupName:usesDocumentViews:]):
Add an assertion that usesDocumentViews is always true.

(-[WebView _isUsingAcceleratedCompositing]):
Remove usesDocumentViews check.

(-[WebView _isSoftwareRenderable]):
Remove usesDocumentViews check.

(-[WebView initWithFrame:frameName:groupName:]):
Remove usesDocumentViews parameter and always pass YES to the _initWithFrame method.

(-[WebView initWithCoder:]):
Remove usesDocumentViews parameter.

(-[WebView _frameViewAtWindowPoint:]):
Remove usesDocumentViews check.

  • WebView/WebViewData.h:

Remove usesDocumentViews ivar.

  • WebView/WebViewPrivate.h:

Remove usesDocumentViews parameters.

2:10 PM Changeset in webkit [95473] by inferno@chromium.org
  • 2 edits in branches/chromium/874/Source/WebCore/loader

Merge 95259 - Fragment navigations should interrupt a provisional load of a different document
BUG=86758
Review URL: ​http://codereview.chromium.org/7945015

2:09 PM Changeset in webkit [95472] by alexis.menard@openbossa.org
  • 12 edits in trunk/Source/WebKit2

[Qt][WK2] Make loading errors API easier to use.
​https://bugs.webkit.org/show_bug.cgi?id=68357

Reviewed by Tor Arne Vestbø.

Make the API to get loading errors easier to use. 95197 introduced
a QJSValue API that is a bit opaque for the client code. Rather than
using a dedicated object, we can just pass the needed information as
parameters of the slot.

  • UIProcess/API/qt/qdesktopwebview.cpp:

(QDesktopWebViewPrivate::loadDidFail):

  • UIProcess/API/qt/qdesktopwebview.h:
  • UIProcess/API/qt/qdesktopwebview_p.h:
  • UIProcess/API/qt/qtouchwebpage.h:
  • UIProcess/API/qt/tests/commonviewtests/tst_commonviewtests.cpp:

(tst_CommonViewTests::loadNonexistentFileUrl):

  • UIProcess/API/qt/tests/commonviewtests/webviewabstraction.cpp:

(WebViewAbstraction::WebViewAbstraction):
(WebViewAbstraction::touchViewLoadFailed):
(WebViewAbstraction::desktopViewLoadFailed):

  • UIProcess/API/qt/tests/commonviewtests/webviewabstraction.h:
  • UIProcess/qt/QtWebPageProxy.cpp:

(QtWebPageProxy::loadDidFail):

  • UIProcess/qt/TouchViewInterface.cpp:

(WebKit::TouchViewInterface::loadDidFail):

  • UIProcess/qt/TouchViewInterface.h:
  • UIProcess/qt/ViewInterface.h:
2:05 PM Changeset in webkit [95471] by dimich@chromium.org
  • 5 edits
    4 adds in trunk

[Chromium] Crash after magic iframe transfer for Pepper/NaCl plugins.
​https://bugs.webkit.org/show_bug.cgi?id=68267
Make adoptNode() to not enable live iframe transfer when the iframe's subtree contains plugins.

Reviewed by Adam Barth.

Source/WebCore:

Test: fast/frames/iframe-reparenting-embed-elements.html

  • dom/Document.cpp:

(WebCore::Document::adoptNode):

  • html/HTMLFrameElementBase.cpp:

(WebCore::hasPluginElements):
(WebCore::HTMLFrameElementBase::canRemainAliveOnRemovalFromTree):

  • html/HTMLFrameElementBase.h:

LayoutTests:

  • fast/frames/iframe-reparenting-embed-elements-expected.txt: Added.
  • fast/frames/iframe-reparenting-embed-elements.html: Added.
  • fast/frames/resources/iframe-reparenting-embed-frame1.html: Added.
  • fast/frames/resources/iframe-reparenting-embed-iframe.html: Added.
1:55 PM Changeset in webkit [95470] by andersca@apple.com
  • 6 edits
    1 delete in trunk/Source/WebKit

Remove WebViewEventHandling.mm
​https://bugs.webkit.org/show_bug.cgi?id=68387

Reviewed by Adam Roben.

../..:

Remove WebViewEventHandling.mm from the Xcode project.

  • WebKit.xcodeproj/project.pbxproj:

../../mac:

WebViewEventHandling.mm was all about event handling in viewless WebKit, so rip it out since
we're getting rid of viewless WebKit1.

  • WebView/WebView.mm:

(-[WebView _close]):

  • WebView/WebViewData.h:
  • WebView/WebViewEventHandling.mm: Removed.
  • WebView/WebViewInternal.h:
1:52 PM Changeset in webkit [95469] by inferno@chromium.org
  • 6 edits in branches/chromium/874/Source/WebCore/rendering

Merge 95461 - Child not placed correctly when beforeChild (table part)
has both :before, :after content.
BUG=95520
Review URL: ​http://codereview.chromium.org/7946014

1:48 PM Changeset in webkit [95468] by inferno@chromium.org
  • 3 edits in branches/chromium/874/Source/WebCore/rendering

Merge 95462 - Source/WebCore: Issues with merging ruby bases.
BUG=94809
Review URL: ​http://codereview.chromium.org/7941019

1:39 PM Changeset in webkit [95467] by andersca@apple.com
  • 6 edits in trunk/Source/WebKit/mac

Remove -[WebView _selectionChanged] and -[WebView _setTooltip:]
​https://bugs.webkit.org/show_bug.cgi?id=68385

Reviewed by Adam Roben.

Move these functions back into the respective clients and remove usesDocumentViews checks.

  • WebCoreSupport/WebChromeClient.mm:

(WebChromeClient::setToolTip):

  • WebCoreSupport/WebEditorClient.mm:

(WebEditorClient::respondToChangedSelection):

  • WebView/WebView.mm:
  • WebView/WebViewEventHandling.mm:
  • WebView/WebViewInternal.h:
1:32 PM Changeset in webkit [95466] by mhahnenberg@apple.com
  • 8 edits in trunk/Source/JavaScriptCore

Remove toPrimitive from JSCell
​https://bugs.webkit.org/show_bug.cgi?id=67875

Reviewed by Geoffrey Garen.

Part of the refactoring process to un-virtualize JSCell. We move
all of the implicit functionality provided by the virtual toPrimitive method
in JSCell to be explicit in JSValue::toPrimitive and JSCell:toPrimitive while
also de-virtualizing JSCell::toPrimitive.

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
  • runtime/JSCell.cpp:

(JSC::JSCell::toPrimitive):

  • runtime/JSCell.h:

We replace JSNotAnObject::toPrimitive with defaultValue, which it overrides from
JSObject. This pushes the virtual method further down, enabling us to get rid
of the virtual call in JSCell. Eventually we'll probably have to deal with this
again, but we'll cross that bridge when we come to it.

  • runtime/JSNotAnObject.cpp:

(JSC::JSNotAnObject::defaultValue):

  • runtime/JSNotAnObject.h:
  • runtime/JSObject.h:
  • runtime/JSString.h:

(JSC::JSValue::toPrimitive):

1:27 PM Changeset in webkit [95465] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit/mac

Begin removing -[WebView _usesDocumentCalls] from WebView.mm
​https://bugs.webkit.org/show_bug.cgi?id=68383

Reviewed by Adam Roben.

Remove checks and begin assuming that -[WebView _usesDocumentViews] always
returns true, since viewless WebKit1 has been abandoned.

  • WebView/WebView.mm:

(-[WebView selectedFrame]):
(-[WebView setHostWindow:]):
(-[WebView acceptsFirstResponder]):
(-[WebView becomeFirstResponder]):
(-[WebView _webcore_effectiveFirstResponder]):
(-[WebView setNextKeyView:]):
(-[WebView setHoverFeedbackSuspended:]):

1:22 PM Changeset in webkit [95464] by levin@chromium.org
  • 1 edit in branches/chromium/874/Source/WebKit/chromium/src/WorkerFileWriterCallbacksBridge.cpp

Merge 95012 - [chromium] Remove AllowCrossThreadAccess for WorkerFileWriterCallbacksBridge.
​https://bugs.webkit.org/show_bug.cgi?id=67943

Reviewed by Adam Barth.

  • src/WorkerFileWriterCallbacksBridge.cpp: Removed AllowCrossThreadAccess

allowing the automatic ref counting to work. This was previous needed when
the ref counting wasn't working but that was fixed in r94986. Note that the
design was to have ref counting since the methods take PassRefPtr and the
class is ThreadSafeRefCounted. (Ideally we have noticed this flaw when
adding in AllowCrossThreadAccess.)
(WebKit::WorkerFileWriterCallbacksBridge::postWriteToMainThread):
(WebKit::WorkerFileWriterCallbacksBridge::postTruncateToMainThread):
(WebKit::WorkerFileWriterCallbacksBridge::postAbortToMainThread):
(WebKit::WorkerFileWriterCallbacksBridge::didWrite):
(WebKit::WorkerFileWriterCallbacksBridge::didFail):
(WebKit::WorkerFileWriterCallbacksBridge::didTruncate):
(WebKit::WorkerFileWriterCallbacksBridge::postInitToMainThread):
(WebKit::WorkerFileWriterCallbacksBridge::dispatchTaskToMainThread):
(WebKit::WorkerFileWriterCallbacksBridge::dispatchTaskToWorkerThread):

TBR=​levin@chromium.org
Review URL: ​http://codereview.chromium.org/7942006

1:20 PM Changeset in webkit [95463] by levin@chromium.org
  • 2 edits in branches/chromium/874/Source/WebCore/platform

Merge 94986 - Make the ThreadSafeRefCounted support in CrossThreadCopier work for T*.
​https://bugs.webkit.org/show_bug.cgi?id=67947

Reviewed by Adam Barth.

The changes are tested by compiling and added compile asserts to do some verification as well.

  • platform/CrossThreadCopier.cpp:

Added some compile asserts to verify various match and non-matches for CrossThreadCopier.

  • platform/CrossThreadCopier.h:

Added a typedef to convert T* to T, just like the typedef's to remove RefPtr and PassRefPtr.
Added a compile assert to verify that only one of the typedefs did anything.
(CrossThreadCopierBase<false, true, T>::copy): Remove "get" as it is unnecessary.
It shouldn't have been here (PassRefPtr and RefPtr easily and sometimes more efficiently
convert to PassRefPtr without get). Also, a raw pointer doesn't have a get() method.

TBR=​levin@chromium.org
Review URL: ​http://codereview.chromium.org/7946013

1:20 PM Changeset in webkit [95462] by inferno@chromium.org
  • 5 edits
    2 adds in trunk

Source/WebCore: Issues with merging ruby bases.
​https://bugs.webkit.org/show_bug.cgi?id=67240

Reviewed by James Robinson.

1) Change fromBeforeChild to beforeChild to match
webkit rendering naming conventions.
2) Add assert to verify ruby base is indeed emptied
after collecting all children in a single base.
3) Fix condition in mergeBlockChildren to bail out only
when we have no children and there is no work to merge
children to toBase.

Test: fast/ruby/ruby-overhang-crash.html

  • rendering/RenderRubyBase.cpp:

(WebCore::RenderRubyBase::moveChildren):
(WebCore::RenderRubyBase::moveInlineChildren):
(WebCore::RenderRubyBase::moveBlockChildren):
(WebCore::RenderRubyBase::mergeBlockChildren):

  • rendering/RenderRubyBase.h:
  • rendering/RenderRubyRun.cpp:

(WebCore::RenderRubyRun::removeChild):

LayoutTests: Issues with merging ruby bases.
​https://bugs.webkit.org/show_bug.cgi?id=67240

Reviewed by James Robinson.

ASSERTION FAILED: !needsLayout() in RenderRubyRun::getOverhang.

  • fast/ruby/ruby-overhang-crash-expected.txt: Added.
  • fast/ruby/ruby-overhang-crash.html: Added.
1:17 PM Changeset in webkit [95461] by inferno@chromium.org
  • 8 edits
    15 adds in trunk

Child not placed correctly when beforeChild (table part)
has both :before, :after content.
​https://bugs.webkit.org/show_bug.cgi?id=67656

Reviewed by James Robinson.

Source/WebCore:

Tests: fast/table/table-cell-before-after-content-around-table-block.html

fast/table/table-cell-before-after-content-around-table-row.html
fast/table/table-cell-before-after-content-around-table.html
fast/table/table-row-before-after-content-around-block.html
fast/table/table-row-before-after-content-around-table.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::addChildIgnoringAnonymousColumnBlocks):

  1. Use the new helper functions findAfterContentRenderer, anonymousContainer.
  2. Rename anonymousChild to better name - beforeChildAnonymousContainer.
  • rendering/RenderObject.cpp:

(WebCore::RenderObject::addChild):
When adding a new child, if beforeChild is a table part(
Table/TableSection/TableRow), we need to check if both
:before, :after content are shoved in one of the anonymous child.
If yes, we need to split the :before, :after content before adding
newChild. Easiest approach is to destroy the :before content, then add
the newChild and then call updateBeforeAfterContent to recreate the
:before content.

  • rendering/RenderObject.h:

(WebCore::RenderObject::findBeforeContentRenderer): same as
beforePseudoElementRenderer, but ignores text childs since they are
sequentially added.
(WebCore::RenderObject::findAfterContentRenderer): same.
(WebCore::RenderObject::anonymousContainer):
(WebCore::objectIsRelayoutBoundary):

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::addChild): use the new helpers and functionally
correct functions - findAfterContentRenderer, anonymousContainer. previous
implementation was wrong since it would not go inside, if :after content
is embedded deeper than one level.

  • rendering/RenderTableRow.cpp:

(WebCore::RenderTableRow::addChild): same.

  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::addChild): same.

LayoutTests:

  • fast/table/table-cell-before-after-content-around-table-block-expected.png: Added.
  • fast/table/table-cell-before-after-content-around-table-block-expected.txt: Added.
  • fast/table/table-cell-before-after-content-around-table-block.html: Added.
  • fast/table/table-cell-before-after-content-around-table-expected.png: Added.
  • fast/table/table-cell-before-after-content-around-table-expected.txt: Added.
  • fast/table/table-cell-before-after-content-around-table-row-expected.png: Added.
  • fast/table/table-cell-before-after-content-around-table-row-expected.txt: Added.
  • fast/table/table-cell-before-after-content-around-table-row.html: Added.
  • fast/table/table-cell-before-after-content-around-table.html: Added.
  • fast/table/table-row-before-after-content-around-block-expected.png: Added.
  • fast/table/table-row-before-after-content-around-block-expected.txt: Added.
  • fast/table/table-row-before-after-content-around-block.html: Added.
  • fast/table/table-row-before-after-content-around-table-expected.png: Added.
  • fast/table/table-row-before-after-content-around-table-expected.txt: Added.
  • fast/table/table-row-before-after-content-around-table.html: Added.
1:09 PM Changeset in webkit [95460] by abarth@webkit.org
  • 1 edit in branches/chromium/874/Source/WebCore/loader/FrameLoader.cpp

Manual merge of 94902 to 874 branch.

1:07 PM Changeset in webkit [95459] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit/mac

Remove calls to -[WebView _usesDocumentViews] from WebFrameLoaderClient.mm
​https://bugs.webkit.org/show_bug.cgi?id=68379

Reviewed by Adam Roben.

Remove checks and begin assuming that -[WebView _usesDocumentViews] always
returns true, since viewless WebKit1 has been abandoned.

  • WebCoreSupport/WebFrameLoaderClient.mm:

(WebFrameLoaderClient::hasHTMLView):
(WebFrameLoaderClient::dispatchDidCommitLoad):
(WebFrameLoaderClient::transitionToCommittedForNewPage):
(WebFrameLoaderClient::createFrame):

  • WebView/WebFrame.mm:

(-[WebFrame _updateBackgroundAndUpdatesWhileOffscreen]):
(-[WebFrame _hasSelection]):
(-[WebFrame _clearSelection]):
(-[WebFrame _shouldFlattenCompositingLayers:]):
(-[WebFrame _dragSourceEndedAt:operation:]):
(-[WebFrame frameView]):

12:46 PM Changeset in webkit [95458] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit/mac

Remove calls to -[WebView _usesDocumentViews]
​https://bugs.webkit.org/show_bug.cgi?id=68377

Reviewed by Adam Roben.

Remove checks and begin assuming that -[WebView _usesDocumentViews] always
returns true, since viewless WebKit1 has been abandoned.

  • WebCoreSupport/WebChromeClient.mm:

(WebChromeClient::windowResizerRect):
(WebChromeClient::invalidateContentsAndWindow):
(WebChromeClient::screenToWindow):
(WebChromeClient::windowToScreen):
(WebChromeClient::platformPageClient):
(WebChromeClient::scrollRectIntoView):
(WebChromeClient::print):

  • WebView/WebDataSource.mm:

(-[WebDataSource _receivedData:]):

12:44 PM Changeset in webkit [95457] by aa@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

r95385 broke Chromium. Fix it.
​https://bugs.webkit.org/show_bug.cgi?id=68378

Unreviewed, build fix.

  • src/FrameLoaderClientImpl.cpp:

(WebKit::FrameLoaderClientImpl::didCreateScriptContext):
(WebKit::FrameLoaderClientImpl::willReleaseScriptContext):

12:38 PM Changeset in webkit [95456] by jochen@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed, build fix

It's not enough to disable clang plugins.

  • gyp_webkit:
12:33 PM Changeset in webkit [95455] by oliver@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Build fix.

12:19 PM Changeset in webkit [95454] by jochen@chromium.org
  • 3 edits in trunk/Source/WebKit/chromium

[chromium] Disable clang when building chromium in WebKit
​https://bugs.webkit.org/show_bug.cgi?id=68343

Reviewed by Adam Barth.

  • DEPS:
  • gyp_webkit:
12:14 PM Changeset in webkit [95453] by oliver@apple.com
  • 9 edits
    1 move
    1 add
    1 delete in trunk/Source/JavaScriptCore

Rename NewSpace.{h,cpp} to MarkedSpace.{h,cpp}
​https://bugs.webkit.org/show_bug.cgi?id=68376

Reviewed by Gavin Barraclough.

Renamed the the MarkedSpace files to match new name, and
updated the relevant references.

(JSC::MarkedSpace::MarkedSpace):
(JSC::MarkedSpace::addBlock):
(JSC::MarkedSpace::removeBlock):
(JSC::MarkedSpace::resetAllocator):
(JSC::MarkedSpace::canonicalizeBlocks):

  • heap/MarkedSpace.h: Renamed from Source/JavaScriptCore/heap/NewSpace.h.

(JSC::MarkedSpace::waterMark):
(JSC::MarkedSpace::highWaterMark):
(JSC::MarkedSpace::setHighWaterMark):
(JSC::MarkedSpace::sizeClassFor):
(JSC::MarkedSpace::allocate):
(JSC::MarkedSpace::forEachBlock):
(JSC::MarkedSpace::SizeClass::SizeClass):
(JSC::MarkedSpace::SizeClass::resetAllocator):
(JSC::MarkedSpace::SizeClass::canonicalizeBlock):

  • runtime/JSCell.h:
12:13 PM Changeset in webkit [95452] by commit-queue@webkit.org
  • 5 edits in trunk/Source

[chromium] Gesture recognizer fires taptype only every other touch
down/up sequence ​https://bugs.webkit.org/show_bug.cgi?id=68368

Patch by Robert Kroeger <​rjkroege@chromium.org> on 2011-09-19
Reviewed by Adam Barth.

Source/WebCore:

The addition of doubletap detection to the gesture recognizer missed some of the
outgoing edges in the recognizer state machine. This change simplifies the logic
and handles all outgoing edges.

  • platform/chromium/GestureRecognizerChromium.cpp:

(WebCore::GestureRecognizerChromium::GestureRecognizerChromium):
(WebCore::GestureRecognizerChromium::isInSecondClickTimeWindow):
(WebCore::GestureRecognizerChromium::updateValues):
(WebCore::GestureRecognizerChromium::touchDown):
(WebCore::GestureRecognizerChromium::click):

  • platform/chromium/GestureRecognizerChromium.h:

Source/WebKit/chromium:

The addition of doubletap detection to the gesture recognizer missed some of the
outgoing edges in the recognizer state machine. Thsi change simplifies the logic
and handles all outgoing edges.

  • tests/InnerGestureRecognizerTest.cpp:

Additional tests added to ensure that all edges in the state
machine are accounted for.
(BuildablePlatformTouchEvent::BuildablePlatformTouchEvent):
(SimulateAndTestFirstClick):
(TEST_F):

11:59 AM Changeset in webkit [95451] by commit-queue@webkit.org
  • 5 edits
    2 adds in trunk

Fix xssauditor bypass with unterminated closing tag by making the HTMLSourceTracker
and the HTMLParser interact more closely with each other. HTMLParser should be
setting the end range for the token itself to account for buffering that the
HTMLSourceTracker can't know about, but there are a lot of paths that would need
updating. First step is to cover this one path.
​https://bugs.webkit.org/show_bug.cgi?id=68281

Patch by Tom Sepez <​tsepez@chromium.org> on 2011-09-19
Reviewed by Adam Barth.

Source/WebCore:

Test: http/tests/security/xssAuditor/script-tag-with-invalid-closing-tag.html

  • html/parser/HTMLSourceTracker.cpp:

(WebCore::HTMLSourceTracker::end):

  • html/parser/HTMLTokenizer.cpp:

(WebCore::HTMLTokenizer::nextToken):

LayoutTests:

  • http/tests/security/xssAuditor/resources/echo-intertag.pl:
  • http/tests/security/xssAuditor/script-tag-with-invalid-closing-tag-expected.txt: Added.
  • http/tests/security/xssAuditor/script-tag-with-invalid-closing-tag.html: Added.
11:54 AM Changeset in webkit [95450] by oliver@apple.com
  • 8 edits in trunk/Source/JavaScriptCore

Rename NewSpace to MarkedSpace
​https://bugs.webkit.org/show_bug.cgi?id=68375

Reviewed by Gavin Barraclough.

Rename NewSpace to a more accurate name, and update all uses.
This patch doesn't rename the files themselves as that will
just make the patch appear bigger than it is.

(JSC::CountFunctor::TakeIfEmpty::TakeIfEmpty):
(JSC::CountFunctor::TakeIfEmpty::operator()):
(JSC::Heap::Heap):
(JSC::Heap::reportExtraMemoryCostSlowCase):
(JSC::Heap::tryAllocate):
(JSC::Heap::allocateSlowCase):
(JSC::Heap::collect):
(JSC::Heap::canonicalizeBlocks):
(JSC::Heap::resetAllocator):
(JSC::Heap::isValidAllocation):
(JSC::Heap::shrink):

  • heap/Heap.h:

(JSC::Heap::markedSpace):
(JSC::Heap::sizeClassFor):
(JSC::Heap::allocate):

  • heap/NewSpace.cpp:

(JSC::MarkedSpace::MarkedSpace):
(JSC::MarkedSpace::addBlock):
(JSC::MarkedSpace::removeBlock):
(JSC::MarkedSpace::resetAllocator):
(JSC::MarkedSpace::canonicalizeBlocks):

  • heap/NewSpace.h:

(JSC::MarkedSpace::waterMark):
(JSC::MarkedSpace::highWaterMark):
(JSC::MarkedSpace::setHighWaterMark):
(JSC::MarkedSpace::sizeClassFor):
(JSC::MarkedSpace::allocate):
(JSC::MarkedSpace::forEachBlock):
(JSC::MarkedSpace::SizeClass::SizeClass):
(JSC::MarkedSpace::SizeClass::resetAllocator):
(JSC::MarkedSpace::SizeClass::canonicalizeBlock):

  • jit/JITInlineMethods.h:

(JSC::JIT::emitAllocateBasicJSObject):

11:45 AM Changeset in webkit [95449] by commit-queue@webkit.org
  • 51 edits in trunk/Source

TextPosition refactoring: Merge ZeroBasedNumber and OneBasedNumber classes
​https://bugs.webkit.org/show_bug.cgi?id=63541

Patch by Peter Rybin <​peter.rybin@gmail.com> on 2011-09-19
Reviewed by Adam Barth.

Source/JavaScriptCore:

  • parser/SourceProvider.h:

(JSC::SourceProvider::startPosition):

  • wtf/text/TextPosition.h:

(WTF::OrdinalNumber::fromZeroBasedInt):
(WTF::OrdinalNumber::fromOneBasedInt):
(WTF::OrdinalNumber::OrdinalNumber):
(WTF::OrdinalNumber::zeroBasedInt):
(WTF::OrdinalNumber::oneBasedInt):
(WTF::OrdinalNumber::operator==):
(WTF::OrdinalNumber::operator!=):
(WTF::OrdinalNumber::first):
(WTF::OrdinalNumber::beforeFirst):
(WTF::TextPosition::TextPosition):
(WTF::TextPosition::minimumPosition):
(WTF::TextPosition::belowRangePosition):

Source/WebCore:

No new tests because this patch is not changing behavior.

  • bindings/js/JavaScriptCallFrame.cpp:

(WebCore::JavaScriptCallFrame::JavaScriptCallFrame):

  • bindings/js/JavaScriptCallFrame.h:

(WebCore::JavaScriptCallFrame::create):
(WebCore::JavaScriptCallFrame::position):
(WebCore::JavaScriptCallFrame::update):

  • bindings/js/ScriptController.cpp:

(WebCore::ScriptController::eventHandlerLineNumber):

  • bindings/js/ScriptDebugServer.cpp:

(WebCore::ScriptDebugServer::hasBreakpoint):
(WebCore::ScriptDebugServer::dispatchDidParseSource):
(WebCore::ScriptDebugServer::createCallFrameAndPauseIfNeeded):
(WebCore::ScriptDebugServer::updateCallFrameAndPauseIfNeeded):

  • bindings/js/ScriptDebugServer.h:
  • bindings/js/ScriptSourceCode.h:

(WebCore::ScriptSourceCode::ScriptSourceCode):

  • bindings/js/StringSourceProvider.h:

(WebCore::StringSourceProvider::create):
(WebCore::StringSourceProvider::startPosition):
(WebCore::StringSourceProvider::StringSourceProvider):

  • bindings/v8/ScheduledAction.cpp:

(WebCore::ScheduledAction::ScheduledAction):

  • bindings/v8/ScriptController.cpp:

(WebCore::ScriptController::eventHandlerPosition):

  • bindings/v8/ScriptController.h:
  • bindings/v8/ScriptEventListener.cpp:

(WebCore::createAttributeEventListener):

  • bindings/v8/ScriptSourceCode.h:

(WebCore::ScriptSourceCode::ScriptSourceCode):
(WebCore::ScriptSourceCode::startPosition):

  • bindings/v8/V8LazyEventListener.cpp:

(WebCore::V8LazyEventListener::V8LazyEventListener):

  • bindings/v8/V8LazyEventListener.h:

(WebCore::V8LazyEventListener::create):

  • bindings/v8/V8Proxy.cpp:

(WebCore::V8Proxy::compileScript):
(WebCore::V8Proxy::evaluate):
(WebCore::V8Proxy::runScript):

  • bindings/v8/V8Proxy.h:
  • bindings/v8/WorkerContextExecutionProxy.cpp:

(WebCore::WorkerContextExecutionProxy::evaluate):
(WebCore::WorkerContextExecutionProxy::runScript):

  • bindings/v8/WorkerContextExecutionProxy.h:
  • bindings/v8/WorkerScriptController.cpp:

(WebCore::WorkerScriptController::evaluate):

  • dom/PendingScript.cpp:

(WebCore::PendingScript::releaseElementAndClear):

  • dom/PendingScript.h:

(WebCore::PendingScript::PendingScript):
(WebCore::PendingScript::startingPosition):
(WebCore::PendingScript::setStartingPosition):

  • dom/ScriptElement.cpp:

(WebCore::ScriptElement::prepareScript):

  • dom/ScriptElement.h:
  • dom/ScriptableDocumentParser.h:
  • dom/ViewportArguments.cpp:

(WebCore::parserLineNumber):

  • html/parser/HTMLDocumentParser.cpp:

(WebCore::HTMLDocumentParser::runScriptsForPausedTreeBuilder):
(WebCore::HTMLDocumentParser::pumpTokenizer):
(WebCore::HTMLDocumentParser::lineNumber):
(WebCore::HTMLDocumentParser::textPosition):

  • html/parser/HTMLDocumentParser.h:
  • html/parser/HTMLInputStream.h:
  • html/parser/HTMLScriptRunner.cpp:

(WebCore::HTMLScriptRunner::execute):
(WebCore::HTMLScriptRunner::runScript):

  • html/parser/HTMLScriptRunner.h:
  • html/parser/HTMLTreeBuilder.cpp:

(WebCore::uninitializedPositionValue1):
(WebCore::HTMLTreeBuilder::HTMLTreeBuilder):
(WebCore::HTMLTreeBuilder::takeScriptToProcess):
(WebCore::HTMLTreeBuilder::processEndTag):
(WebCore::HTMLTreeBuilder::processScriptStartTag):

  • html/parser/HTMLTreeBuilder.h:
  • inspector/InspectorResourceAgent.cpp:

(WebCore::InspectorResourceAgent::buildInitiatorObject):

  • platform/text/SegmentedString.cpp:

(WebCore::SegmentedString::currentLine):
(WebCore::SegmentedString::currentColumn):
(WebCore::SegmentedString::setCurrentPosition):

  • platform/text/SegmentedString.h:
  • svg/SVGDocumentExtensions.cpp:

(WebCore::parserLineNumber):

  • xml/XMLErrors.cpp:

(WebCore::XMLErrors::XMLErrors):
(WebCore::XMLErrors::handleError):
(WebCore::XMLErrors::appendErrorMessage):

  • xml/XMLErrors.h:
  • xml/parser/MarkupTokenizerBase.h:

(WebCore::MarkupTokenizerBase::lineNumber):

  • xml/parser/NewXMLDocumentParser.cpp:

(WebCore::NewXMLDocumentParser::processScript):
(WebCore::NewXMLDocumentParser::textPosition):
(WebCore::NewXMLDocumentParser::lineNumber):

  • xml/parser/NewXMLDocumentParser.h:
  • xml/parser/XMLDocumentParser.cpp:

(WebCore::XMLDocumentParser::pushCurrentNode):
(WebCore::XMLDocumentParser::handleError):

  • xml/parser/XMLDocumentParser.h:
  • xml/parser/XMLDocumentParserLibxml2.cpp:

(WebCore::PendingCallbacks::appendErrorCallback):
(WebCore::XMLDocumentParser::XMLDocumentParser):
(WebCore::XMLDocumentParser::doWrite):
(WebCore::XMLDocumentParser::startElementNs):
(WebCore::XMLDocumentParser::error):
(WebCore::XMLDocumentParser::lineNumber):
(WebCore::XMLDocumentParser::columnNumber):
(WebCore::XMLDocumentParser::textPosition):

  • xml/parser/XMLDocumentParserQt.cpp:

(WebCore::XMLDocumentParser::XMLDocumentParser):
(WebCore::XMLDocumentParser::doWrite):
(WebCore::XMLDocumentParser::doEnd):
(WebCore::XMLDocumentParser::lineNumber):
(WebCore::XMLDocumentParser::columnNumber):
(WebCore::XMLDocumentParser::textPosition):
(WebCore::XMLDocumentParser::parse):
(WebCore::XMLDocumentParser::parseStartElement):

Source/WebKit/chromium:

  • src/WebFrameImpl.cpp:

(WebKit::WebFrameImpl::executeScript):
(WebKit::WebFrameImpl::executeScriptInIsolatedWorld):
(WebKit::WebFrameImpl::executeScriptAndReturnValue):

11:36 AM Changeset in webkit [95448] by mitz@apple.com
  • 28 edits
    6 moves
    1 add
    2 deletes in trunk/Source

Source/JavaScriptCore: JavaScriptCore part of [mac] WebKit contains Objective-C classes that are not prefixed with its standard prefixes
​https://bugs.webkit.org/show_bug.cgi?id=68323

Reviewed by Sam Weinig.

Renamed WTFMainThreadCaller to JSWTFMainThreadCaller.

  • wtf/mac/MainThreadMac.mm:

(WTF::initializeMainThreadPlatform):
(WTF::initializeMainThreadToProcessMainThreadPlatform):

Source/WebCore: WebCore part of [mac] WebKit contains Objective-C classes that are not prefixed with its standard prefixes
​https://bugs.webkit.org/show_bug.cgi?id=68323

Reviewed by Sam Weinig.

Renamed AccessibilityObjectWrapper to WebAccessibilityObjectWrapper.
Renamed CascadeList to WebCascadeList.
Renamed CookieStorageObjCAdapter to WebCookieStorageObjCAdapter.
Renamed LanguageChangeObserver to WebLanguageChangeObserver.
Renamed ScrollAnimationHelperDelegate to WebScrollAnimationHelperDelegate.
Renamed ScrollbarPainterControllerDelegate to WebScrollbarPainterControllerDelegate.
Renamed ScrollbarPainterDelegate to WebScrollbarPainterDelegate.
Renamed ScrollbarPartAnimation to WebScrollbarPartAnimation.
Renamed ScrollbarPrefsObserver to WebScrollbarPrefsObserver.

  • WebCore.gyp/WebCore.gyp: Updated for the renaming of CascadeList to WebCascadeList.
  • WebCore.xcodeproj/project.pbxproj:
  • accessibility/AccessibilityObject.h:
  • accessibility/mac/AXObjectCacheMac.mm:

(WebCore::AXObjectCache::attachWrapper):

  • accessibility/mac/AccessibilityObjectMac.mm:
  • accessibility/mac/AccessibilityObjectWrapper.h: Removed.
  • accessibility/mac/AccessibilityObjectWrapper.mm: Removed.
  • accessibility/mac/WebAccessibilityObjectWrapper.h: Copied from Source/WebCore/accessibility/mac/AccessibilityObjectWrapper.h.
  • accessibility/mac/WebAccessibilityObjectWrapper.mm: Copied from Source/WebCore/accessibility/mac/AccessibilityObjectWrapper.mm.

(convertToNSArray):
(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:forParameter:]):
(-[WebAccessibilityObjectWrapper accessibilityIndexOfChild:]):
(-[WebAccessibilityObjectWrapper accessibilityArrayAttributeValues:index:maxCount:]):

  • platform/graphics/mac/ComplexTextControllerCoreText.mm:

(WebCore::ComplexTextController::collectComplexTextRunsForCharactersCoreText):

  • platform/mac/Language.mm:

(WebCore::platformDefaultLanguage):

  • platform/mac/ScrollAnimatorMac.h:
  • platform/mac/ScrollAnimatorMac.mm:

(-[WebScrollbarPainterDelegate setUpAnimation:scrollerPainter:part:WebCore::animateAlphaTo:duration:]):
(WebCore::ScrollAnimatorMac::ScrollAnimatorMac):

  • platform/mac/ScrollbarThemeMac.mm:

(WebCore::ScrollbarThemeMac::ScrollbarThemeMac):

  • platform/network/mac/CookieStorageMac.mm:

(WebCore::startObservingCookieChanges):

Source/WebKit: WebKit part of [mac] WebKit contains Objective-C classes that are not prefixed with its standard prefixes
​https://bugs.webkit.org/show_bug.cgi?id=68323

Reviewed by Sam Weinig.

Updated for the renaming of NonBlockingPanel to WebNonBlockingPanel.

  • English.lproj/WebJavaScriptTextInputPanel.nib/classes.nib: Removed.
  • English.lproj/WebJavaScriptTextInputPanel.nib/designable.nib: Added.
  • English.lproj/WebJavaScriptTextInputPanel.nib/info.nib: Removed.
  • English.lproj/WebJavaScriptTextInputPanel.nib/keyedobjects.nib:

Source/WebKit/mac: WebKit part of [mac] WebKit contains Objective-C classes that are not prefixed with its standard prefixes
​https://bugs.webkit.org/show_bug.cgi?id=68323

Reviewed by Sam Weinig.

Renamed NonBlockingPanel to WebNonBlockingPanel.
Renamed ThreadEnabler to WebCocoaThreadingEnabler.
Renamed PDFPrefUpdatingProxy to WebPDFPrefUpdatingProxy.

  • Misc/WebIconDatabase.mm:

(+[WebCocoaThreadingEnabler enableThreading]):
(importToWebCoreFormat):

  • Panels/English.lproj/WebAuthenticationPanel.nib/designable.nib:
  • Panels/English.lproj/WebAuthenticationPanel.nib/keyedobjects.nib:
  • Panels/WebAuthenticationPanel.h:
  • Panels/WebAuthenticationPanel.m: Renamed NonBlockingPanel to

WebNonBlockingPanel. Because Safari 5.1 uses NonBlockingPanel, this will
cause nightly builds to log an error message when showing the Safari
HTTP authentication sheet and disable the Quit command while the sheet
is disaplyed.

  • WebView/WebPDFView.mm:

(-[WebPDFView initWithFrame:]):
(-[WebPDFView _updatePreferencesSoon]):

Source/WebKit2: WebKit2 part of [mac] WebKit contains Objective-C classes that are not prefixed with its standard prefixes
​https://bugs.webkit.org/show_bug.cgi?id=68323

Reviewed by Sam Weinig.

Renamed FullKeyboardAccessWatcher to WKFullKeyboardAccessWatcher.
Renamed AccessibilityWebPageObject to WKAccessibilityWebPageObject.

  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/mac/AccessibilityWebPageObject.h: Removed.
  • WebProcess/WebPage/mac/AccessibilityWebPageObject.mm: Removed.
  • WebProcess/WebPage/mac/WKAccessibilityWebPageObject.h: Copied from Source/WebKit2/WebProcess/WebPage/mac/AccessibilityWebPageObject.h.
  • WebProcess/WebPage/mac/WKAccessibilityWebPageObject.mm: Copied from Source/WebKit2/WebProcess/WebPage/mac/AccessibilityWebPageObject.mm.
  • WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::WebPage::platformInitialize):
(WebKit::WebPage::accessibilityRemoteObject):

  • WebProcess/mac/FullKeyboardAccessWatcher.h: Removed.
  • WebProcess/mac/FullKeyboardAccessWatcher.mm: Removed.
  • WebProcess/mac/WKFullKeyboardAccessWatcher.h: Copied from Source/WebKit2/WebProcess/mac/FullKeyboardAccessWatcher.h.
  • WebProcess/mac/WKFullKeyboardAccessWatcher.mm: Copied from Source/WebKit2/WebProcess/mac/FullKeyboardAccessWatcher.mm.

(+[WKFullKeyboardAccessWatcher fullKeyboardAccessEnabled]):

  • WebProcess/mac/WebProcessMac.mm:

(WebKit::WebProcess::fullKeyboardAccessEnabled):

11:30 AM Changeset in webkit [95447] by oliver@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

Remove direct property slot pointers from the instruction stream
​https://bugs.webkit.org/show_bug.cgi?id=68373

Reviewed by Gavin Barraclough.

Use an indirect load to access prototype properties rather than directly
storing the property address in the instruction stream. This should allow
further optimisations in future, and also provides a 0.5% win to sunspider.

  • dfg/DFGRepatch.cpp:

(JSC::DFG::generateProtoChainAccessStub):

  • jit/JITPropertyAccess.cpp:

(JSC::JIT::compileGetDirectOffset):

  • jit/JITPropertyAccess32_64.cpp:

(JSC::JIT::compileGetDirectOffset):

  • runtime/JSObject.h:

(JSC::JSObject::addressOfPropertyStorage):

11:29 AM Changeset in webkit [95446] by alexis.menard@openbossa.org
  • 3 edits in trunk/Tools

Style checker should not check public Qt WK2 API for parameter_name.
​https://bugs.webkit.org/show_bug.cgi?id=68359

Reviewed by Andreas Kling.

The public Qt WK2 APIs have different rules than WebKit for parameters of methods in h files.
Add an exception in the style checker to disable the check. Also added the test for it.

  • Scripts/webkitpy/style/checker.py:
  • Scripts/webkitpy/style/checker_unittest.py:
11:27 AM Changeset in webkit [95445] by caryclark@google.com
  • 3 edits in trunk/Source/WebCore

Move fontDataForCombiningCharacterSequence to fix Skia on Mac build
​https://bugs.webkit.org/show_bug.cgi?id=68358

Reviewed by Dan Bernstein.

No new tests.

  • platform/graphics/mac/FontMac.mm:
  • platform/graphics/mac/FontComplexTextMac.cpp:

(WebCore::Font::fontDataForCombiningCharacterSequence):
This moves the implementation from FontMac.mm to
FontComplexTextMac.cpp, so it is visible to the Skia on Mac
platform as well.

11:18 AM Changeset in webkit [95444] by commit-queue@webkit.org
  • 5 edits in trunk

GTK DRT leaks memory while comparing history items
​https://bugs.webkit.org/show_bug.cgi?id=68086

Source/WebKit/gtk:

Patch by Leandro Pereira <​leandro@profusion.mobi> on 2011-09-19
Reviewed by Martin Robinson.

webkit_web_history_item_get_target() function returns a g_strdup()'d
string, so it should return "gchar*" instead of "const gchar*".

  • webkit/webkitwebhistoryitem.cpp:

(webkit_web_history_item_get_target): Change return type to "gchar*".

  • webkit/webkitwebhistoryitemprivate.h: Ditto.

Tools:

Patch by Leandro Pereira <​leandro@profusion.mobi> on 2011-09-19
Reviewed by Martin Robinson.

webkit_web_history_item_get_target() returns a g_strdup()'d string,
so memory must be freed before compareHistoryItems() returns.

  • DumpRenderTree/gtk/DumpRenderTree.cpp:

(compareHistoryItems): Use GOwnPtr to manage memory automatically.

11:16 AM Changeset in webkit [95443] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/gtk/po

Fix paths used by update-po, and avoid changing directory
unnecessarily.

[GTK] make update-po is b0rked
​https://bugs.webkit.org/show_bug.cgi?id=68352

Patch by Gustavo Noronha Silva <Gustavo Noronha Silva> on 2011-09-19
Reviewed by Martin Robinson.

  • GNUmakefile.am:
11:12 AM Changeset in webkit [95442] by dslomov@google.com
  • 2 edits in trunk/LayoutTests

[Chromium] Rebaseline expectations and file WK68372.

  • platform/chromium/test_expectations.txt:
11:03 AM Changeset in webkit [95441] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

Buildbot marks a nrwt bot red when tests are missing results
​https://bugs.webkit.org/show_bug.cgi?id=64812

Patch by Kristóf Kosztyó <​kkristof@inf.u-szeged.hu> on 2011-09-19
Reviewed by Ryosuke Niwa.

  • Scripts/webkitpy/layout_tests/controllers/manager.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
11:00 AM Changeset in webkit [95440] by jberlin@webkit.org
  • 6 edits
    2 adds in trunk

Sites that use history pushState or replaceState are recorded in history in Private Browsing
mode.
​https://bugs.webkit.org/show_bug.cgi?id=68208

Reviewed by Brady Eidson.

Source/WebCore:

Test: TestWebKitAPI/Tests/WebKit2/PrivateBrowsingPushStateNoHistoryCallback.

Add the privateBrowsingEnabled check that is used in other places in HistoryController
before calling addVisitedLink and FrameLoaderClient::updateGlobalHistory.

  • loader/HistoryController.cpp:

(WebCore::HistoryController::pushState):
(WebCore::HistoryController::replaceState):

Tools:

Add a test that the WKContextDidNavigateWithNavigationDataCallback (which is invoked by
updateGlobalHistory) is not called in Private Browsing when the page does history.pushState.

  • TestWebKitAPI/Tests/WebKit2/PrivateBrowsingPushStateNoHistoryCallback.cpp: Added.

(TestWebKitAPI::didNavigateWithNavigationData):
This is a context history client callback, so it should not be called when in Private
Browsing. Add a call to FAIL().
(TestWebKitAPI::didSameDocumentNavigationForFrame):
This is a page load client callback that happens after the didNavigateWithNavigationData
callback. End the test.
(TestWebKitAPI::TEST):
Enable Private Browsing and load a page that uses history.pushState.

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:

Add PrivateBrowsingPushStateNoHistoryCallback.cpp and push-state.html.

  • TestWebKitAPI/Tests/WebKit2/push-state.html: Added.

Ditto.

  • TestWebKitAPI/win/TestWebKitAPI.vcproj:

Ditto.

  • TestWebKitAPI/win/copy-resources.cmd:

Ditto.

10:41 AM Changeset in webkit [95439] by oliver@apple.com
  • 8 edits in trunk/Source/JavaScriptCore

Remove bump allocator
​https://bugs.webkit.org/show_bug.cgi?id=68370

Reviewed by Sam Weinig.

Can't do anything with this allocator currently, and it's
increasing the complexity of the GC code. Slight progression
on SunSpider, slight regression (undoing the original progression)
in V8.

  • heap/Heap.cpp:

(JSC::Heap::collect):

  • heap/Heap.h:
  • heap/NewSpace.cpp:

(JSC::NewSpace::NewSpace):

  • heap/NewSpace.h:

(JSC::NewSpace::allocate):

  • runtime/JSObject.cpp:

(JSC::JSObject::allocatePropertyStorage):

  • runtime/JSObject.h:

(JSC::JSObject::~JSObject):
(JSC::JSObject::visitChildrenDirect):

  • runtime/StorageBarrier.h:

(JSC::StorageBarrier::set):

10:34 AM Changeset in webkit [95438] by dslomov@google.com
  • 1 edit
    1 delete in trunk/LayoutTests

[Chromium] Rebaseline expectations due to r95402.

  • platform/chromium-win-vista/fast/dom/navigator-detached-no-crash-expected.txt: Removed.
10:18 AM Changeset in webkit [95437] by leandro@webkit.org
  • 3 edits in trunk/Source/WebCore

Unreviewed: ScrollbarThemeMock.cpp is already referenced in the
global CMakeLists.txt.

  • CMakeListsEfl.txt: Remove reference to platform/mock/ScrollbarThemeMock.cpp.
  • CMakeListsWinCE.txt: Ditto.
10:14 AM Changeset in webkit [95436] by caio.oliveira@openbossa.org
  • 5 edits
    2 adds in trunk/Source/WebKit2

[Qt] [WK2] Implement popup menus in QDesktopWebView using QComboBox
​https://bugs.webkit.org/show_bug.cgi?id=67938

Reviewed by Andreas Kling.

Implement a WebPopupMenuProxy that uses QtWebComboBox (a QComboBox subclass we
have for WK1). Then use this WebPopupMenuProxy in QDesktopWebView. The implementation
explicitly avoids running a nested mainloop.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::showPopupMenu):
Since we don't run a nested mainloop, we need to keep the client pointer to call
valueChangedForPopupMenu().

  • UIProcess/qt/WebPopupMenuProxyQtDesktop.cpp: Added.

(WebKit::WebPopupMenuProxyQtDesktop::WebPopupMenuProxyQtDesktop):
(WebKit::WebPopupMenuProxyQtDesktop::~WebPopupMenuProxyQtDesktop):
(WebKit::WebPopupMenuProxyQtDesktop::showPopupMenu):
(WebKit::WebPopupMenuProxyQtDesktop::hidePopupMenu):
(WebKit::WebPopupMenuProxyQtDesktop::setSelectedIndex):
(WebKit::WebPopupMenuProxyQtDesktop::onPopupMenuHidden):
(WebKit::WebPopupMenuProxyQtDesktop::populate):

  • UIProcess/qt/WebPopupMenuProxyQtDesktop.h: Added.

(WebKit::WebPopupMenuProxyQtDesktop::create):

  • UIProcess/qt/qdesktopwebpageproxy.cpp:

(QDesktopWebPageProxy::createPopupMenuProxy):

  • UIProcess/qt/qdesktopwebpageproxy.h:
  • WebKit2.pro:
10:13 AM Changeset in webkit [95435] by inferno@chromium.org
  • 1 edit in branches/chromium/874/Source/WebCore/webaudio/OfflineAudioDestinationNode.cpp

Merge 95124
BUG=96150
Review URL: ​http://codereview.chromium.org/7945008

10:12 AM Changeset in webkit [95434] by inferno@chromium.org
  • 1 edit in branches/chromium/874/Source/WebCore/webaudio/OfflineAudioDestinationNode.cpp

Merge 94984
BUG=96150
Review URL: ​http://codereview.chromium.org/7944005

10:09 AM Changeset in webkit [95433] by inferno@chromium.org
  • 1 edit in branches/chromium/874/Source/WebCore/css/CSSPrimitiveValue.cpp

Merge 95071 - Fix cssText property of counter-valued CSSPrimitiveValue and avoid uninitialized read
BUG=60653
Review URL: ​http://codereview.chromium.org/7941005

10:07 AM Changeset in webkit [95432] by inferno@chromium.org
  • 2 edits in branches/chromium/874/Source/WebCore/accessibility

Merge 94716
BUG=84160
Review URL: ​http://codereview.chromium.org/7944004

10:05 AM Changeset in webkit [95431] by inferno@chromium.org
  • 1 edit in branches/chromium/874/Source/WebCore/accessibility/AccessibilityRenderObject.cpp

Merge 94864
BUG=84885
Review URL: ​http://codereview.chromium.org/7948002

10:02 AM Changeset in webkit [95430] by inferno@chromium.org
  • 2 edits in branches/chromium/874/Source/WebCore/rendering

Merge 95054
BUG=92226

9:58 AM Changeset in webkit [95429] by inferno@chromium.org
  • 6 edits in branches/chromium/874/Source/WebCore

Merge 94905
BUG=1092
Review URL: ​http://codereview.chromium.org/7942002

9:54 AM Changeset in webkit [95428] by inferno@chromium.org
  • 2 edits in branches/chromium/874/Source/WebCore/rendering

Merge 94991
BUG=94810
Review URL: ​http://codereview.chromium.org/7943004

9:52 AM Changeset in webkit [95427] by inferno@chromium.org
  • 2 edits
    2 copies in branches/chromium/874

Merge 95301
BUG=95072
Review URL: ​http://codereview.chromium.org/7947002

9:49 AM Changeset in webkit [95426] by inferno@chromium.org
  • 1 edit in branches/chromium/874/Source/WebCore/rendering/RenderObjectChildList.cpp

Merge 94857
BUG=95672
Review URL: ​http://codereview.chromium.org/7946005

9:47 AM Changeset in webkit [95425] by inferno@chromium.org
  • 2 edits
    2 copies in branches/chromium/874

Merge 95204
BUG=95761
Review URL: ​http://codereview.chromium.org/7950001

9:43 AM Changeset in webkit [95424] by inferno@chromium.org
  • 5 edits in branches/chromium/874/Source/WebCore

Merge 95093
BUG=96170
Review URL: ​http://codereview.chromium.org/7945005

9:42 AM Changeset in webkit [95423] by inferno@chromium.org
  • 1 edit
    2 copies in branches/chromium/874

Merge 95074
BUG=96444
Review URL: ​http://codereview.chromium.org/7945004

9:40 AM Changeset in webkit [95422] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed, rolling out r95416.
​http://trac.webkit.org/changeset/95416
​https://bugs.webkit.org/show_bug.cgi?id=68367

Broke chromium-mac (Requested by beverloo on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2011-09-19

  • DEPS:
9:38 AM Changeset in webkit [95421] by inferno@chromium.org
  • 2 edits in branches/chromium/874

Merge 95306
BUG=96665
Review URL: ​http://codereview.chromium.org/7948001

9:35 AM Changeset in webkit [95420] by inferno@chromium.org
  • 1 edit in branches/chromium/874/Source/WebCore/bindings/ScriptControllerBase.cpp

Merge 94820 - REGRESSION (r66874): Missing RefPtr in ScriptController
BUG=95669
Review URL: ​http://codereview.chromium.org/7946004

9:33 AM Changeset in webkit [95419] by inferno@chromium.org
  • 3 edits in branches/chromium/874/Source/WebCore

Merge 94608 - MediaElementAudioSourceNode destruction triggers ASSERTS
​https://bugs.webkit.org/show_bug.cgi?id=67665
BUG=94186
Review URL: ​http://codereview.chromium.org/7947001

9:26 AM Changeset in webkit [95418] by loislo@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed skip inspector/timeline/timeline-animation-frame.html on win platform.

  • platform/win/Skipped:
9:22 AM Changeset in webkit [95417] by commit-queue@webkit.org
  • 5 edits in trunk/Source

[GTK] Fix distcheck build
​https://bugs.webkit.org/show_bug.cgi?id=68346

Patch by Carlos Garcia Campos <​cgarcia@igalia.com> on 2011-09-19
Reviewed by Philippe Normand.

Source/JavaScriptCore:

  • GNUmakefile.list.am:

Source/WebKit/gtk:

  • tests/testmimehandling.c: Remove ogg tests, since the behavious

has changed in libsoup (​https://bugzilla.gnome.org/show_bug.cgi?id=648846#c8)
(server_callback):
(mime_type_policy_decision_requested_cb):
(main):

  • webkit/webkitwebplugin.cpp: Fix introspection annotation.
9:07 AM Changeset in webkit [95416] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled DEPS.

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2011-09-19

  • DEPS:
8:15 AM Changeset in webkit [95415] by loislo@chromium.org
  • 6 edits in trunk/LayoutTests

Unreviewed fix for flaky tests.

  • inspector/timeline/timeline-dom-content-loaded-event-expected.txt:
  • inspector/timeline/timeline-dom-content-loaded-event.html:
  • inspector/timeline/timeline-load-event-expected.txt:
  • inspector/timeline/timeline-load-event.html:
  • platform/qt/Skipped:
7:45 AM Changeset in webkit [95414] by kbalazs@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed Qt gardening.
​https://bugs.webkit.org/show_bug.cgi?id=68360

Patch by Zsolt Fehér <​feherzs@inf.u-szeged.hu> on 2011-09-19

  • platform/qt/Skipped:
7:23 AM Changeset in webkit [95413] by Ademar Reis
  • 2 edits in trunk/Source/WebCore

Unreviewed: dos2unix on bindings/js/JSExceptionBase.h

Visual Studio is choking on this file when generating packages for
Qt-4.8 on Windows:

"""
Source\WebCore\Bindings\js\JSExceptionBase.h:
error C4335: Mac file format detected: please convert the source file
to either DOS or UNIX format
"""

Since from all .cpp or .h files shared by all ports this is the only
one with CRLF line terminations, I'm assuming this was a mistake.

  • bindings/js/JSExceptionBase.h:
7:09 AM Changeset in webkit [95412] by kbalazs@webkit.org
  • 1 edit
    240 adds in trunk/LayoutTests

[Qt][WK2] Add some pixel baselines.

Unreviewed expectation update.

These baselines was produced in the same environment where the
Szeged WK2 bot runs. The validity of the results had been checked manually.

  • platform/qt-wk2/css1/box_properties/float_on_text_elements-expected.png: Added.
  • platform/qt-wk2/css2.1/t051202-c24-first-lttr-00-b-expected.png: Added.
  • platform/qt-wk2/css2.1/t051202-c26-psudo-nest-00-c-expected.png: Added.
  • platform/qt-wk2/css2.1/t060401-c32-cascading-00-b-expected.png: Added.
  • platform/qt-wk2/css2.1/t080301-c411-vt-mrgn-00-b-expected.png: Added.
  • platform/qt-wk2/css2.1/t0805-c5512-brdr-rw-00-b-expected.png: Added.
  • platform/qt-wk2/css2.1/t0805-c5514-brdr-lw-00-b-expected.png: Added.
  • platform/qt-wk2/css2.1/t0805-c5515-brdr-w-00-a-expected.png: Added.
  • platform/qt-wk2/css2.1/t0805-c5516-brdr-c-00-a-expected.png: Added.
  • platform/qt-wk2/css2.1/t0805-c5516-ibrdr-c-00-a-expected.png: Added.
  • platform/qt-wk2/css2.1/t0805-c5517-brdr-s-00-c-expected.png: Added.
  • platform/qt-wk2/css2.1/t0805-c5518-brdr-t-01-e-expected.png: Added.
  • platform/qt-wk2/css2.1/t0805-c5518-ibrdr-t-00-a-expected.png: Added.
  • platform/qt-wk2/css2.1/t0805-c5519-brdr-r-00-a-expected.png: Added.
  • platform/qt-wk2/css2.1/t0805-c5519-brdr-r-02-e-expected.png: Added.
  • platform/qt-wk2/css2.1/t0805-c5519-ibrdr-r-00-a-expected.png: Added.
  • platform/qt-wk2/css2.1/t0805-c5520-brdr-b-01-e-expected.png: Added.
  • platform/qt-wk2/css2.1/t0805-c5520-ibrdr-b-00-a-expected.png: Added.
  • platform/qt-wk2/css2.1/t0805-c5521-brdr-l-00-a-expected.png: Added.
  • platform/qt-wk2/css2.1/t0805-c5521-brdr-l-02-e-expected.png: Added.
  • platform/qt-wk2/css2.1/t0805-c5521-ibrdr-l-00-a-expected.png: Added.
  • platform/qt-wk2/css2.1/t0805-c5522-brdr-00-b-expected.png: Added.
  • platform/qt-wk2/css2.1/t0805-c5522-ibrdr-00-a-expected.png: Added.
  • platform/qt-wk2/css2.1/t090402-c42-ibx-pad-00-d-ag-expected.png: Added.
  • platform/qt-wk2/css2.1/t0905-c5525-fltmult-00-d-g-expected.png: Added.
  • platform/qt-wk2/css2.1/t0905-c5525-fltwidth-00-c-g-expected.png: Added.
  • platform/qt-wk2/css2.1/t0905-c5525-fltwrap-00-b-expected.png: Added.
  • platform/qt-wk2/css2.1/t090501-c414-flt-00-d-expected.png: Added.
  • platform/qt-wk2/css2.1/t090501-c414-flt-01-b-expected.png: Added.
  • platform/qt-wk2/css2.1/t090501-c414-flt-ln-00-d-expected.png: Added.
  • platform/qt-wk2/css2.1/t090501-c414-flt-ln-01-d-g-expected.png: Added.
  • platform/qt-wk2/css2.1/t090501-c414-flt-ln-02-d-expected.png: Added.
  • platform/qt-wk2/css2.1/t090501-c414-flt-ln-03-d-expected.png: Added.
  • platform/qt-wk2/css2.1/t090501-c5525-flt-l-00-b-g-expected.png: Added.
  • platform/qt-wk2/css2.1/t090501-c5525-flt-r-00-b-g-expected.png: Added.
  • platform/qt-wk2/css2.1/t1002-c5523-width-02-b-g-expected.png: Added.
  • platform/qt-wk2/css2.1/t100801-c544-valgn-00-a-ag-expected.png: Added.
  • platform/qt-wk2/css2.1/t100801-c544-valgn-02-d-agi-expected.png: Added.
  • platform/qt-wk2/css2.1/t100801-c544-valgn-03-d-agi-expected.png: Added.
  • platform/qt-wk2/css2.1/t100801-c544-valgn-04-d-agi-expected.png: Added.
  • platform/qt-wk2/css2.1/t1202-counter-08-b-expected.png: Added.
  • platform/qt-wk2/css2.1/t1202-counters-08-b-expected.png: Added.
  • platform/qt-wk2/css2.1/t1601-c547-indent-01-d-expected.png: Added.
  • platform/qt-wk2/css2.1/t1602-c546-txt-align-00-b-expected.png: Added.
  • platform/qt-wk2/css3/css3-modsel-33-expected.png: Added.
  • platform/qt-wk2/css3/css3-modsel-35-expected.png: Added.
  • platform/qt-wk2/fast/backgrounds/size/backgroundSize15-expected.png: Added.
  • platform/qt-wk2/fast/backgrounds/size/backgroundSize16-expected.png: Added.
  • platform/qt-wk2/fast/block/basic/014-expected.png: Added.
  • platform/qt-wk2/fast/block/basic/016-expected.png: Added.
  • platform/qt-wk2/fast/block/basic/white-space-pre-wraps-expected.png: Added.
  • platform/qt-wk2/fast/block/float/003-expected.png: Added.
  • platform/qt-wk2/fast/block/float/020-expected.png: Added.
  • platform/qt-wk2/fast/block/float/021-expected.png: Added.
  • platform/qt-wk2/fast/block/float/avoidance-percent-width-strict-expected.png: Added.
  • platform/qt-wk2/fast/block/float/nopaint-after-layer-destruction2-expected.png: Added.
  • platform/qt-wk2/fast/block/float/width-update-after-clear-expected.png: Added.
  • platform/qt-wk2/fast/block/margin-collapse/empty-clear-blocks-expected.png: Added.
  • platform/qt-wk2/fast/block/positioning/auto-height-with-top-and-bottom-expected.png: Added.
  • platform/qt-wk2/fast/block/positioning/auto/005-expected.png: Added.
  • platform/qt-wk2/fast/borders/block-mask-overlay-image-expected.png: Added.
  • platform/qt-wk2/fast/borders/border-fit-expected.png: Added.
  • platform/qt-wk2/fast/borders/border-image-scale-transform-expected.png: Added.
  • platform/qt-wk2/fast/borders/border-radius-inline-flow-expected.png: Added.
  • platform/qt-wk2/fast/borders/rtl-border-01-expected.png: Added.
  • platform/qt-wk2/fast/borders/rtl-border-02-expected.png: Added.
  • platform/qt-wk2/fast/borders/rtl-border-03-expected.png: Added.
  • platform/qt-wk2/fast/box-shadow/basic-shadows-expected.png: Added.
  • platform/qt-wk2/fast/canvas/arc360-expected.png: Added.
  • platform/qt-wk2/fast/canvas/canvas-before-css-expected.png: Added.
  • platform/qt-wk2/fast/canvas/canvas-text-alignment-expected.png: Added.
  • platform/qt-wk2/fast/canvas/canvas-zoom-expected.png: Added.
  • platform/qt-wk2/fast/canvas/canvasDrawingIntoSelf-expected.png: Added.
  • platform/qt-wk2/fast/canvas/drawImage-expected.png: Added.
  • platform/qt-wk2/fast/canvas/drawImage-with-globalAlpha-expected.png: Added.
  • platform/qt-wk2/fast/canvas/fillrect-gradient-zero-stops-expected.png: Added.
  • platform/qt-wk2/fast/canvas/fillrect_gradient-expected.png: Added.
  • platform/qt-wk2/fast/canvas/image-object-in-canvas-expected.png: Added.
  • platform/qt-wk2/fast/canvas/patternfill-repeat-expected.png: Added.
  • platform/qt-wk2/fast/canvas/setWidthResetAfterForcedRender-expected.png: Added.
  • platform/qt-wk2/fast/canvas/shadow-offset-1-expected.png: Added.
  • platform/qt-wk2/fast/canvas/shadow-offset-2-expected.png: Added.
  • platform/qt-wk2/fast/canvas/shadow-offset-3-expected.png: Added.
  • platform/qt-wk2/fast/canvas/shadow-offset-4-expected.png: Added.
  • platform/qt-wk2/fast/canvas/shadow-offset-5-expected.png: Added.
  • platform/qt-wk2/fast/canvas/shadow-offset-6-expected.png: Added.
  • platform/qt-wk2/fast/canvas/shadow-offset-7-expected.png: Added.
  • platform/qt-wk2/fast/css-generated-content/012-expected.png: Added.
  • platform/qt-wk2/fast/css-generated-content/013-expected.png: Added.
  • platform/qt-wk2/fast/css-generated-content/after-duplicated-after-split-expected.png: Added.
  • platform/qt-wk2/fast/css-generated-content/after-order-expected.png: Added.
  • platform/qt-wk2/fast/css-generated-content/hover-style-change-expected.png: Added.
  • platform/qt-wk2/fast/css/004-expected.png: Added.
  • platform/qt-wk2/fast/css/005-expected.png: Added.
  • platform/qt-wk2/fast/css/MarqueeLayoutTest-expected.png: Added.
  • platform/qt-wk2/fast/css/ZeroOpacityLayers-expected.png: Added.
  • platform/qt-wk2/fast/css/ZeroOpacityLayers2-expected.png: Added.
  • platform/qt-wk2/fast/css/absolute-poition-in-rtl-parent-expected.png: Added.
  • platform/qt-wk2/fast/css/begin-end-contain-selector-empty-value-expected.png: Added.
  • platform/qt-wk2/fast/css/css1_forward_compatible_parsing-expected.png: Added.
  • platform/qt-wk2/fast/css/css3-modsel-22-expected.png: Added.
  • platform/qt-wk2/fast/css/css3-nth-child-expected.png: Added.
  • platform/qt-wk2/fast/css/first-letter-detach-expected.png: Added.
  • platform/qt-wk2/fast/css/first-letter-hover-expected.png: Added.
  • platform/qt-wk2/fast/css/font-face-implicit-local-font-expected.png: Added.
  • platform/qt-wk2/fast/css/hsl-color-expected.png: Added.
  • platform/qt-wk2/fast/css/inline-properties-important-expected.png: Added.
  • platform/qt-wk2/fast/css/invalidation-errors-2-expected.png: Added.
  • platform/qt-wk2/fast/css/invalidation-errors-expected.png: Added.
  • platform/qt-wk2/fast/css/non-standard-checkbox-size-expected.png: Added.
  • platform/qt-wk2/fast/css/outline-auto-location-expected.png: Added.
  • platform/qt-wk2/fast/css/selector-set-attribute-expected.png: Added.
  • platform/qt-wk2/fast/css/text-align-expected.png: Added.
  • platform/qt-wk2/fast/css/textCapitalizeEdgeCases-expected.png: Added.
  • platform/qt-wk2/fast/css/zoom-font-size-expected.png: Added.
  • platform/qt-wk2/fast/dom/HTMLHeadElement/head-link-style-href-check-expected.png: Added.
  • platform/qt-wk2/fast/dom/HTMLTableElement/colSpan-expected.png: Added.
  • platform/qt-wk2/fast/dom/HTMLTableElement/createCaption-expected.png: Added.
  • platform/qt-wk2/fast/dom/children-nodes-expected.png: Added.
  • platform/qt-wk2/fast/dom/clone-node-dynamic-style-expected.png: Added.
  • platform/qt-wk2/fast/dom/css-rule-functions-expected.png: Added.
  • platform/qt-wk2/fast/dynamic/insert-before-table-part-in-continuation-expected.png: Added.
  • platform/qt-wk2/fast/dynamic/selection-highlight-adjust-expected.png: Added.
  • platform/qt-wk2/fast/dynamic/staticY-marking-parents-regression-expected.png: Added.
  • platform/qt-wk2/fast/forms/basic-selects-expected.png: Added.
  • platform/qt-wk2/fast/forms/basic-textareas-quirks-expected.png: Added.
  • platform/qt-wk2/fast/forms/input-placeholder-text-indent-expected.png: Added.
  • platform/qt-wk2/fast/forms/minWidthPercent-expected.png: Added.
  • platform/qt-wk2/fast/frames/frame-scrolling-attribute-expected.png: Added.
  • platform/qt-wk2/fast/gradients/radial-centered-expected.png: Added.
  • platform/qt-wk2/fast/html/details-writing-mode-expected.png: Added.
  • platform/qt-wk2/fast/inline/continuation-outlines-expected.png: Added.
  • platform/qt-wk2/fast/inline/continuation-outlines-with-layers-expected.png: Added.
  • platform/qt-wk2/fast/lists/001-vertical-expected.png: Added.
  • platform/qt-wk2/fast/lists/007-vertical-expected.png: Added.
  • platform/qt-wk2/fast/lists/008-vertical-expected.png: Added.
  • platform/qt-wk2/fast/media/mq-relative-constraints-08-expected.png: Added.
  • platform/qt-wk2/fast/multicol/client-rects-expected.png: Added.
  • platform/qt-wk2/fast/multicol/column-break-with-balancing-expected.png: Added.
  • platform/qt-wk2/fast/multicol/float-multicol-expected.png: Added.
  • platform/qt-wk2/fast/multicol/float-paginate-complex-expected.png: Added.
  • platform/qt-wk2/fast/multicol/float-paginate-expected.png: Added.
  • platform/qt-wk2/fast/multicol/layers-split-across-columns-expected.png: Added.
  • platform/qt-wk2/fast/multicol/margin-collapse-expected.png: Added.
  • platform/qt-wk2/fast/multicol/max-height-columns-block-expected.png: Added.
  • platform/qt-wk2/fast/multicol/nested-columns-expected.png: Added.
  • platform/qt-wk2/fast/multicol/paginate-block-replaced-expected.png: Added.
  • platform/qt-wk2/fast/multicol/positioned-with-constrained-height-expected.png: Added.
  • platform/qt-wk2/fast/multicol/scrolling-overflow-expected.png: Added.
  • platform/qt-wk2/fast/multicol/span/anonymous-before-child-parent-crash-expected.png: Added.
  • platform/qt-wk2/fast/multicol/span/anonymous-style-inheritance-expected.png: Added.
  • platform/qt-wk2/fast/multicol/span/span-as-immediate-child-complex-splitting-expected.png: Added.
  • platform/qt-wk2/fast/multicol/span/span-as-immediate-child-generated-content-expected.png: Added.
  • platform/qt-wk2/fast/multicol/span/span-as-immediate-child-property-removal-expected.png: Added.
  • platform/qt-wk2/fast/multicol/span/span-as-immediate-columns-child-dynamic-expected.png: Added.
  • platform/qt-wk2/fast/multicol/span/span-as-immediate-columns-child-expected.png: Added.
  • platform/qt-wk2/fast/multicol/span/span-as-immediate-columns-child-removal-expected.png: Added.
  • platform/qt-wk2/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.png: Added.
  • platform/qt-wk2/fast/multicol/span/span-as-nested-columns-child-expected.png: Added.
  • platform/qt-wk2/fast/multicol/span/span-margin-collapsing-expected.png: Added.
  • platform/qt-wk2/fast/multicol/table-margin-collapse-expected.png: Added.
  • platform/qt-wk2/fast/multicol/table-vertical-align-expected.png: Added.
  • platform/qt-wk2/fast/multicol/unsplittable-inline-block-expected.png: Added.
  • platform/qt-wk2/fast/multicol/vertical-lr/column-break-with-balancing-expected.png: Added.
  • platform/qt-wk2/fast/multicol/vertical-lr/column-rules-expected.png: Added.
  • platform/qt-wk2/fast/multicol/vertical-lr/float-avoidance-expected.png: Added.
  • platform/qt-wk2/fast/multicol/vertical-lr/float-multicol-expected.png: Added.
  • platform/qt-wk2/fast/multicol/vertical-lr/float-paginate-complex-expected.png: Added.
  • platform/qt-wk2/fast/multicol/vertical-lr/float-paginate-expected.png: Added.
  • platform/qt-wk2/fast/multicol/vertical-lr/nested-columns-expected.png: Added.
  • platform/qt-wk2/fast/multicol/vertical-lr/unsplittable-inline-block-expected.png: Added.
  • platform/qt-wk2/fast/multicol/vertical-rl/column-break-with-balancing-expected.png: Added.
  • platform/qt-wk2/fast/multicol/vertical-rl/column-rules-expected.png: Added.
  • platform/qt-wk2/fast/multicol/vertical-rl/float-avoidance-expected.png: Added.
  • platform/qt-wk2/fast/multicol/vertical-rl/float-multicol-expected.png: Added.
  • platform/qt-wk2/fast/multicol/vertical-rl/float-paginate-complex-expected.png: Added.
  • platform/qt-wk2/fast/multicol/vertical-rl/float-paginate-expected.png: Added.
  • platform/qt-wk2/fast/multicol/vertical-rl/nested-columns-expected.png: Added.
  • platform/qt-wk2/fast/multicol/vertical-rl/unsplittable-inline-block-expected.png: Added.
  • platform/qt-wk2/fast/overflow/line-clamp-expected.png: Added.
  • platform/qt-wk2/fast/overflow/overflow-rtl-vertical-expected.png: Added.
  • platform/qt-wk2/fast/overflow/table-overflow-float-expected.png: Added.
  • platform/qt-wk2/fast/reflections/opacity-reflection-transform-expected.png: Added.
  • platform/qt-wk2/fast/repaint/bugzilla-6278-expected.png: Added.
  • platform/qt-wk2/fast/repaint/line-flow-with-floats-1-expected.png: Added.
  • platform/qt-wk2/fast/repaint/line-flow-with-floats-10-expected.png: Added.
  • platform/qt-wk2/fast/repaint/line-flow-with-floats-2-expected.png: Added.
  • platform/qt-wk2/fast/repaint/line-flow-with-floats-3-expected.png: Added.
  • platform/qt-wk2/fast/repaint/line-flow-with-floats-4-expected.png: Added.
  • platform/qt-wk2/fast/repaint/line-flow-with-floats-5-expected.png: Added.
  • platform/qt-wk2/fast/repaint/line-flow-with-floats-6-expected.png: Added.
  • platform/qt-wk2/fast/repaint/line-flow-with-floats-7-expected.png: Added.
  • platform/qt-wk2/fast/repaint/line-flow-with-floats-8-expected.png: Added.
  • platform/qt-wk2/fast/repaint/line-flow-with-floats-9-expected.png: Added.
  • platform/qt-wk2/fast/repaint/multicol-repaint-expected.png: Added.
  • platform/qt-wk2/fast/repaint/outline-repaint-glitch-expected.png: Added.
  • platform/qt-wk2/fast/repaint/selected-replaced-expected.png: Added.
  • platform/qt-wk2/fast/repaint/selection-gap-overflow-scroll-2-expected.png: Added.
  • platform/qt-wk2/fast/repaint/stacked-diacritics-expected.png: Added.
  • platform/qt-wk2/fast/repaint/text-append-dirty-lines-expected.png: Added.
  • platform/qt-wk2/fast/replaced/001-expected.png: Added.
  • platform/qt-wk2/fast/replaced/002-expected.png: Added.
  • platform/qt-wk2/fast/replaced/003-expected.png: Added.
  • platform/qt-wk2/fast/replaced/005-expected.png: Added.
  • platform/qt-wk2/fast/replaced/absolute-image-sizing-expected.png: Added.
6:33 AM Changeset in webkit [95411] by loislo@chromium.org
  • 1 edit
    1 add in trunk/LayoutTests

Web Inspector: extend UI perf tests coverage. Elements Panel.
​https://bugs.webkit.org/show_bug.cgi?id=68263

Reviewed by Pavel Feldman.

  • inspector/performance/resources/show-panel-elements.html: Added.
6:32 AM Changeset in webkit [95410] by loislo@chromium.org
  • 5 edits
    4 adds in trunk

Web Inspector: didMarkDOMContentEvent() should send event of MarkDOMContent type.
​https://bugs.webkit.org/show_bug.cgi?id=67528

Reviewed by Pavel Feldman.

Source/WebCore:

Tests: inspector/timeline/timeline-dom-content-loaded-event.html

inspector/timeline/timeline-load-event.html

  • inspector/InspectorTimelineAgent.cpp:

(WebCore::InspectorTimelineAgent::didMarkDOMContentEvent):

LayoutTests:

  • inspector/timeline/timeline-animation-frame.html:
  • inspector/timeline/timeline-dom-content-loaded-event-expected.txt: Added.
  • inspector/timeline/timeline-dom-content-loaded-event.html: Added.
  • inspector/timeline/timeline-load-event-expected.txt: Added.
  • inspector/timeline/timeline-load-event.html: Added.
  • inspector/timeline/timeline-test.js:

(initialize_Timeline.InspectorTest.waitForRecordType.addRecord):
(initialize_Timeline.InspectorTest.waitForRecordType):

6:04 AM Changeset in webkit [95409] by kov@webkit.org
  • 2 edits in trunk/Source/WebKit/gtk/po

Ukrainian translation for WebKitGTK+
​https://bugs.webkit.org/show_bug.cgi?id=66543

Patch by Yuri Chornoivan <​yurchor@ukr.net> on 2011-08-31
Reviewed by Gustavo Noronha.

  • uk.po: updated.
6:04 AM Changeset in webkit [95408] by Csaba Osztrogonác
  • 3 edits in trunk/LayoutTests

[Qt] Unreviewed gardening.

  • platform/qt-arm/fast/dom/Window/window-property-descriptors-expected.txt: Updated.
  • platform/qt-mac/Skipped: Skip new failing tests to paint the bot green.
5:48 AM Changeset in webkit [95407] by rgabor@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] [ARMv5] fast/events/media-element-focus-tab.html fast/spatial-navigation/snav-media-elements.html fail
​https://bugs.webkit.org/show_bug.cgi?id=68341

Patch by Kristóf Kosztyó <​kkristof@inf.u-szeged.hu> on 2011-09-19

  • platform/qt-arm/Skipped: Skip the failing tests
2:19 AM Changeset in webkit [95406] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

Re-name LayerChromium border functions to reflect that
they are only for debug use.
​https://bugs.webkit.org/show_bug.cgi?id=68212

Patch by Shawn Singh <​shawnsingh@chromium.org> on 2011-09-19
Reviewed by James Robinson.

Code cleanup towards unit testing.

  • platform/graphics/chromium/GraphicsLayerChromium.cpp:

(WebCore::GraphicsLayerChromium::clearBackgroundColor):
(WebCore::GraphicsLayerChromium::setDebugBackgroundColor):
(WebCore::GraphicsLayerChromium::setDebugBorder):
(WebCore::GraphicsLayerChromium::updateLayerBackgroundColor):
(WebCore::GraphicsLayerChromium::setupContentsLayer):

  • platform/graphics/chromium/LayerChromium.cpp:

(WebCore::LayerChromium::setDebugBorderColor):
(WebCore::LayerChromium::setDebugBorderWidth):

  • platform/graphics/chromium/LayerChromium.h:
1:17 AM Changeset in webkit [95405] by loislo@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Web Inspector: extend timeline coverage.
​https://bugs.webkit.org/show_bug.cgi?id=68260

Another place with js function call from native.

Reviewed by Pavel Feldman.

  • src/WebDevToolsFrontendImpl.cpp:

(WebKit::WebDevToolsFrontendImpl::dispatchOnInspectorFrontend):

12:36 AM Changeset in webkit [95404] by loislo@chromium.org
  • 18 edits
    3 adds in trunk

2011-09-18 Ilya Tikhonovsky <​loislo@chromium.org>

Web Inspector: requestAnimationFrame callbacks don't show up in the timeline panel.
​https://bugs.webkit.org/show_bug.cgi?id=67986

Reviewed by Pavel Feldman.

Test: inspector/timeline/timeline-animation-frame.html

WebCore:

  • English.lproj/localizedStrings.js:
  • bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::callFunction): (WebCore::V8Proxy::callFunctionWithoutFrame): (WebCore::V8Proxy::instrumentedCallFunction):
  • bindings/v8/V8Proxy.h:
  • bindings/v8/custom/V8CustomVoidCallback.cpp: (WebCore::invokeCallback):
  • dom/ScriptedAnimationController.cpp: (WebCore::ScriptedAnimationController::registerCallback): (WebCore::ScriptedAnimationController::cancelCallback): (WebCore::ScriptedAnimationController::serviceScriptedAnimations):
  • inspector/InspectorInstrumentation.cpp: (WebCore::InspectorInstrumentation::didRegisterAnimationFrameCallbackImpl): (WebCore::InspectorInstrumentation::didCancelAnimationFrameCallbackImpl): (WebCore::InspectorInstrumentation::willFireAnimationFrameEventImpl): (WebCore::InspectorInstrumentation::didFireAnimationFrameEventImpl):
  • inspector/InspectorInstrumentation.h: (WebCore::InspectorInstrumentation::willCallFunction): (WebCore::InspectorInstrumentation::didRegisterAnimationFrameCallback): (WebCore::InspectorInstrumentation::didCancelAnimationFrameCallback): (WebCore::InspectorInstrumentation::willFireAnimationFrameEvent): (WebCore::InspectorInstrumentation::didFireAnimationFrameEvent):
  • inspector/InspectorTimelineAgent.cpp: (WebCore::InspectorTimelineAgent::didRegisterAnimationFrameCallback): (WebCore::InspectorTimelineAgent::didCancelAnimationFrameCallback): (WebCore::InspectorTimelineAgent::willFireAnimationFrameEvent): (WebCore::InspectorTimelineAgent::didFireAnimationFrameEvent):
  • inspector/InspectorTimelineAgent.h:
  • inspector/TimelineRecordFactory.cpp: (WebCore::TimelineRecordFactory::createAnimationFrameCallbackData):
  • inspector/TimelineRecordFactory.h:
  • inspector/front-end/TimelineAgent.js:
  • inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel): (WebInspector.TimelinePanel.prototype.get _recordStyles): (WebInspector.TimelinePanel.prototype._innerAddRecordToTimeline): (WebInspector.TimelinePanel.prototype._clearPanel): (WebInspector.TimelinePanel.FormattedRecord): (WebInspector.TimelinePanel.FormattedRecord.prototype._generatePopupContent): (WebInspector.TimelinePanel.FormattedRecord.prototype._getRecordDetails):

LayoutTests:

  • inspector/timeline/timeline-animation-frame-expected.txt: Added.
  • inspector/timeline/timeline-animation-frame.html: Added.
  • inspector/timeline/timeline-enum-stability-expected.txt:
  • platform/chromium/inspector/timeline/timeline-enum-stability-expected.txt:
  • platform/qt/Skipped: inspector/timeline/timeline-animation-frame.html was added to the skip list.
  • inspector/timeline/timeline-test.js:
12:31 AM Changeset in webkit [95403] by Carlos Garcia Campos
  • 6 edits in trunk/Source

[GTK] Fix distcheck build
​https://bugs.webkit.org/show_bug.cgi?id=68241

Reviewed by Martin Robinson.

Source/JavaScriptCore:

  • GNUmakefile.list.am:

Source/WebCore:

  • GNUmakefile.list.am:

Source/WebKit2:

  • GNUmakefile.am:

Sep 18, 2011:

11:50 PM Changeset in webkit [95402] by koz@chromium.org
  • 1 edit
    1 add in trunk/LayoutTests

Rebaseline navigator test for chromium-win-vista.
​https://bugs.webkit.org/show_bug.cgi?id=68334

Unreviewed. Rebaseline for navigator-detached-no-crash.

  • platform/chromium-win-vista/fast/dom/navigator-detached-no-crash-expected.txt: Added.
10:34 PM Changeset in webkit [95401] by loislo@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: chromium-win: "Save timeline data" does nothing.
​https://bugs.webkit.org/show_bug.cgi?id=68313

windows shell API function GetSaveFileName doesn't accept file names with ':' symbol.

Reviewed by Pavel Feldman.

  • inspector/front-end/TimelinePanel.js:

(WebInspector.TimelineModel.prototype._saveToFile):

6:29 PM Changeset in webkit [95400] by mitz@apple.com
  • 5 edits
    2 deletes in trunk/Source/JavaScriptCore

Removed ProfilerServer.

Reviewed by Mark Rowe.

  • JavaScriptCore.gypi:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • profiler/ProfilerServer.h: Removed.
  • profiler/ProfilerServer.mm: Removed.
  • runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::JSGlobalData):

  • wscript:
3:29 PM Changeset in webkit [95399] by fpizlo@apple.com
  • 9 edits in trunk/Source/JavaScriptCore

DFG JIT should inline Math.min, Math.max, and Math.sqrt
​https://bugs.webkit.org/show_bug.cgi?id=68318

Reviewed by Gavin Barraclough.

Adds Math.min, Math.max, and Math.sqrt intrinsics. Adds support for
a function to have an intrinsic but not a thunk generator. This is
a 7% speed-up on access-nbody, and neutral elsewhere, mainly because
we're still not DFG compiling the bulk of the hot code in Kraken audio
benchmarks.

  • create_hash_table:
  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::handleMinMax):
(JSC::DFG::ByteCodeParser::handleIntrinsic):

  • dfg/DFGIntrinsic.h:
  • dfg/DFGNode.h:
  • dfg/DFGPropagator.cpp:

(JSC::DFG::Propagator::propagateNode):
(JSC::DFG::Propagator::fixupNode):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • jit/JITStubs.cpp:

(JSC::JITThunks::hostFunctionStub):

  • runtime/Lookup.cpp:

(JSC::setUpStaticFunctionSlot):

2:35 PM Changeset in webkit [95398] by thakis@chromium.org
  • 2 edits in trunk/Source/JavaScriptCore

Remove two files from JavaScriptCore.gypi that were removed in r95240
​https://bugs.webkit.org/show_bug.cgi?id=68327

Unreviewed, build warning fix.

11:38 AM Changeset in webkit [95397] by oliver@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

Remove special case handling of inline storage from the JIT
​https://bugs.webkit.org/show_bug.cgi?id=68319

Reviewed by Gavin Barraclough.

Simplify logic used for reading and writing to property storage
by removing the special cases for inline storage. This has no
perf impact.

  • dfg/DFGRepatch.cpp:

(JSC::DFG::generateProtoChainAccessStub):
(JSC::DFG::tryBuildGetByIDList):

  • jit/JIT.h:
  • jit/JITPropertyAccess.cpp:

(JSC::JIT::compilePutDirectOffset):
(JSC::JIT::compileGetDirectOffset):
(JSC::JIT::privateCompilePutByIdTransition):
(JSC::JIT::privateCompileGetByIdSelfList):

  • jit/JITPropertyAccess32_64.cpp:

(JSC::JIT::compilePutDirectOffset):
(JSC::JIT::compileGetDirectOffset):
(JSC::JIT::privateCompilePutByIdTransition):
(JSC::JIT::privateCompileGetByIdSelfList):

11:18 AM Changeset in webkit [95396] by mitz@apple.com
  • 2 edits in trunk/Source/WebCore

Try to fix the Chromium Mac build after r95391.

  • WebCore.gyp/WebCore.gyp:
11:05 AM Changeset in webkit [95395] by mitz@apple.com
  • 2 edits in trunk/Source/WebCore

Try to fix the Chromium Mac build after r95391.

  • WebCore.gyp/WebCore.gyp:
10:27 AM Changeset in webkit [95394] by mitz@apple.com
  • 5 edits
    1 move in trunk/Source/WebCore

Try to fix the Chromium Mac build after r95391.

  • WebCore.gypi: Updated for the renaming of ComplexTextController.cpp.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • platform/graphics/Font.h: Changed #if directives to include the Chromium Mac port.
  • platform/graphics/SimpleFontData.h: Ditto.
  • platform/graphics/mac/ComplexTextControllerCoreText.cpp: Changed the filename extension of this

Objective-C++ file to .mm.

  • platform/graphics/mac/ComplexTextControllerCoreText.mm: Copied from Source/WebCore/platform/graphics/mac/ComplexTextControllerCoreText.cpp.
10:16 AM Changeset in webkit [95393] by mitz@apple.com
  • 2 edits in trunk/Source/WebCore

Snow Leopard build fix after r95391.

  • platform/graphics/mac/ComplexTextControllerCoreText.cpp:

(WebCore::ComplexTextController::collectComplexTextRunsForCharactersCoreText):

10:02 AM Changeset in webkit [95392] by mitz@apple.com
  • 2 edits in trunk/Source/WebCore

Leopard build fix after r95391.

  • platform/graphics/mac/ComplexTextControllerATSUI.cpp:

(WebCore::ComplexTextController::collectComplexTextRunsForCharactersATSUI):

9:52 AM Changeset in webkit [95391] by mitz@apple.com
  • 11 edits
    3 adds in trunk

Source/WebCore: Allow Core Text to choose the fallback font for rendering a combining character sequence

Fixes <rdar://problem/7860281> Decomposed text is displayed incorrectly when Verdana is specified
​https://bugs.webkit.org/show_bug.cgi?id=68287

Reviewed by Dave Hyatt.

Test: platform/mac/fast/text/combining-character-sequence-fallback.html

  • WebCore.xcodeproj/project.pbxproj: Compile ComplexTextControllerCoreText.cpp as Objective-C++.

I am going to rename this file in a followup patch.

  • platform/graphics/Font.h: Declared fontDataForCombiningCharacterSequence().
  • platform/graphics/SimpleFontData.h: Declared canRenderCombiningCharacterSequence() and added

a member variable to cache the results of calling this function.

  • platform/graphics/mac/ComplexTextController.cpp:

(WebCore::ComplexTextController::offsetForPosition): Fixed a typo in a comment.
(WebCore::advanceByCombiningCharacterSequence): Added this helper function, which iterates over
characters until the end of a sequence of combining characters, zero-width joiners and zero-width
non-joiners. A single base characater followed by such a (possibly-empty) sequence is known as
a combining character sequence. This stretches the definition a little because the base character
may be a combining character as well. Returns false if an invalid UTF-16 sequence is encountered,
true otherwise.
(WebCore::ComplexTextController::collectComplexTextRuns): - Replaced the glyphData and nextGlyphData
variables each with a pair of variables, a SimpleFontData* and a boolean indicating whether a
character mapped to the missing glyph. This clarifies that this function does not use glyph IDs.

  • Renamed the local variable newC to uppercaseCharacter.
  • Changed to use advanceByCombiningCharacterSequence().
  • Changed to use Font::fontDataForCombiningCharacterSequence() instead of Font::glyphDataForCharacter(). If there are combining marks and none of the fonts in the fallback list can render the sequence alone, use the systemFallbackFontData() constant to indicate to collectComplexTextRunsForCharactersCoreText() to allow Core Text to perform its own fallback.
  • Stopped checking isSmallCaps against nextIsSmallCaps. It was redundant, since the small caps FontData differs from the normal variant.

(WebCore::ComplexTextController::collectComplexTextRunsForCharacters): Moved the common logic to
handle the 0 fontData case from the ATSUI and Core Text continuations of this function into this function.

  • platform/graphics/mac/ComplexTextController.h:

(WebCore::ComplexTextController::systemFallbackFontData): Added. This constant is used to indicate to
collectComplexTextRunsForCharactersCoreText() that it should allow Core Text to perform its own font
fallback.

  • platform/graphics/mac/ComplexTextControllerATSUI.cpp:

(WebCore::ComplexTextController::collectComplexTextRunsForCharactersATSUI): Handle systemFallbackFontData()
by using the primary font data.

  • platform/graphics/mac/ComplexTextControllerCoreText.cpp:

(-[CascadeList initWithFont:WebCore::character:]): Added.
(-[CascadeList count]): Added.
(-[CascadeList objectAtIndex:]): Added. Returns an entry from a cascade list of CTFontDescriptorRef
objects based on the font’s fallback list for the character. The list is initialized lazily.
(WebCore::ComplexTextController::collectComplexTextRunsForCharactersCoreText): Handle systemFallbackFontData()
by allowing Core Text to perform font fallback, starting with a cascade list based on the font’s fallback
list and possibly continuing with system fallback.

  • platform/graphics/mac/FontMac.mm:

(WebCore::Font::fontDataForCombiningCharacterSequence): Added. If the sequence is only a base character,
calls through to glyphDataForCharacter(). Otherwise, iterates over the font’s fallback list for the
base character (and the system fallback font for that character), returning the first font that can
render the sequence, or 0 if there is none.

  • platform/graphics/mac/SimpleFontDataMac.mm:

(WebCore::provideStringAndAttributes): Added this Core Text callback.
(WebCore::SimpleFontData::canRenderCombiningCharacterSequence): Added. Checks if Core Text can render
the sequence using only this font. Caches the result.

LayoutTests: <rdar://problem/7860281> Decomposed text is displayed incorrectly when Verdana is specified
​https://bugs.webkit.org/show_bug.cgi?id=68287

Reviewed by Dave Hyatt.

  • platform/mac/fast/text/combining-character-sequence-fallback.html: Added.
  • platform/mac/platform/mac/fast/text/combining-character-sequence-fallback-expected.png: Added.
  • platform/mac/platform/mac/fast/text/combining-character-sequence-fallback-expected.txt: Added.
9:21 AM Changeset in webkit [95390] by mitz@apple.com
  • 3 edits in trunk/LayoutTests

Updated expected results for two tests after r95362.

  • platform/mac/fast/dom/Window/window-properties-expected.txt:
  • platform/mac/fast/dom/Window/window-property-descriptors-expected.txt:
Note: See TracTimeline for information about the timeline view.