Timeline



Feb 16, 2012:

11:52 PM Changeset in webkit [108044] by noel.gordon@gmail.com
  • 2 edits in trunk/LayoutTests

Unreviewed. Rollout r107952 removed fast/events/related-target-focusevent.html so
lint complains about it in test_expectations.txt, remove it's expectation line.

  • platform/chromium/test_expectations.txt:
11:47 PM Changeset in webkit [108043] by cdn@chromium.org
  • 2 edits in trunk/Source/WebCore

Correct a misleading comment regarding string delimiters in CSS parsing.
​https://bugs.webkit.org/show_bug.cgi?id=78521

Reviewed by Zoltan Herczeg.

  • css/CSSParser.cpp:

(WebCore::CSSParser::lex):

11:44 PM Changeset in webkit [108042] by noel.gordon@gmail.com
  • 2 edits in trunk/LayoutTests

Unreviewed. r107980 rolled-out, fast/js/stack-trace.html was removed so lint
complains about it in test_expectations.txt, remove it's expectation line.

  • platform/chromium/test_expectations.txt:
11:30 PM Changeset in webkit [108041] by Martin Robinson
  • 2 edits in trunk/Source/WebCore

Fix the TextureMapper build for GTK+.

No new tests. This is just a build fix.

  • GNUmakefile.list.am: Add missing files to the build and change spaces to tabs.
11:26 PM Changeset in webkit [108040] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebKit2

[GTK] Make sure print operation object is alive until printing finishes in WebKit2
​https://bugs.webkit.org/show_bug.cgi?id=78829

Reviewed by Martin Robinson.

  • UIProcess/API/gtk/WebKitPrintOperation.cpp:

(drawPagesForPrintingCompleted): Adopt the WebKitPrintOperation
reference so that it's released when the callback finishes.
(webkitPrintOperationRunDialogForFrame): Pass a reference of
WebKitPrintOperation to the printing callback.

11:23 PM Changeset in webkit [108039] by Carlos Garcia Campos
  • 2 edits in trunk/Tools

[GTK] Make install is broken when building without --enable-gtk-doc
​https://bugs.webkit.org/show_bug.cgi?id=78828

Reviewed by Martin Robinson.

  • gtk/generate-gtkdoc:

(rebase_installed_docs): Check documentation has been generated
before trying to rebase it.

11:20 PM Changeset in webkit [108038] by dbates@webkit.org
  • 2 edits in trunk/Source/WebCore

Add ENABLE(STYLE_SCOPED) around HTMLStyleElement::m_isRegisteredWithScopingNode

The instance variable HTMLStyleElement::m_isRegisteredWithScopingNode is only
referenced from within ENABLE(STYLE_SCOPED)-guarded code. We should add this
guard around its declaration.

  • html/HTMLStyleElement.h:

(HTMLStyleElement):

11:10 PM Changeset in webkit [108037] by yuqiang.xian@intel.com
  • 3 edits in trunk/Source/JavaScriptCore

Add JSC code profiling support on Linux x86
​https://bugs.webkit.org/show_bug.cgi?id=78871

Reviewed by Gavin Barraclough.

We don't unwind the stack for now as we cannot guarantee all the
libraries are compiled without -fomit-frame-pointer.

  • tools/CodeProfile.cpp:

(JSC::CodeProfile::sample):

  • tools/CodeProfiling.cpp:

(JSC):
(JSC::profilingTimer):
(JSC::CodeProfiling::begin):
(JSC::CodeProfiling::end):

10:44 PM WebKitIDL edited by haraken@chromium.org
(diff)
10:43 PM Changeset in webkit [108036] by Csaba Osztrogonác
  • 13 edits
    3 deletes in trunk

Unreviewed. Rolling out r107980, because it broke 32 bit platforms.

Source/JavaScriptCore:

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
  • interpreter/Interpreter.cpp:

(JSC::Interpreter::throwException):
(JSC::Interpreter::privateExecute):

  • interpreter/Interpreter.h:

(JSC):
(Interpreter):

  • jsc.cpp:

(GlobalObject::finishCreation):

  • parser/Nodes.h:

(JSC::FunctionBodyNode::setInferredName):

  • parser/Parser.h:

(JSC::::parse):

  • runtime/CommonIdentifiers.h:
  • runtime/Error.cpp:

(JSC::addErrorInfo):

  • runtime/Error.h:

(JSC):

LayoutTests:

  • fast/js/exception-properties-expected.txt:
  • fast/js/script-tests/exception-properties.js:
  • fast/js/script-tests/stack-trace.js: Removed.
  • fast/js/stack-trace-expected.txt: Removed.
  • fast/js/stack-trace.html: Removed.
10:42 PM Changeset in webkit [108035] by shinyak@chromium.org
  • 10 edits
    2 adds in trunk

[v8] v8 doesn't assume to do 'new WebKitShadowRoot(host)'
​https://bugs.webkit.org/show_bug.cgi?id=78875

Reviewed by Kentaro Hara.

Source/WebCore:

Since v8 does not assume that we do 'new WebkitShadowRoot(host)', a wrapper object for new WebKitShadowRoot(host)
was saved in DOMObject storage instead of DOMNode storage.

CodeGenerator should handle with DOMNode correctly to solve the problem.

Test: fast/dom/shadow/shadow-root-new.html

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateConstructorCallback):

LayoutTests:

Skip non-chromium ports since SHADOW_DOM flag is not enabled in their ports.

  • fast/dom/shadow/shadow-root-new.html: Added.
  • fast/dom/shadow/shadow-root-new-expected.txt: Added.
  • platform/efl/Skipped:
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
  • platform/wincairo/Skipped:
  • platform/wk2/Skipped:
10:35 PM Changeset in webkit [108034] by loislo@chromium.org
  • 22 edits
    5 deletes in trunk

Source/WebCore: Unreviewed rollout r107952 because it broke shadow-boundary-events.html and related-target-focusevent.html on mac.
see ​http://webkit.org/b/78832

  • CMakeLists.txt:
  • DerivedSources.cpp:
  • DerivedSources.make:
  • DerivedSources.pri:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/DOMAllInOne.cpp:
  • dom/EventDispatchMediator.cpp:

(WebCore::FocusEventDispatchMediator::create):
(WebCore):
(WebCore::FocusEventDispatchMediator::FocusEventDispatchMediator):
(WebCore::FocusEventDispatchMediator::dispatchEvent):
(WebCore::BlurEventDispatchMediator::create):
(WebCore::BlurEventDispatchMediator::BlurEventDispatchMediator):
(WebCore::BlurEventDispatchMediator::dispatchEvent):

  • dom/EventDispatchMediator.h:

(FocusEventDispatchMediator):
(WebCore):
(BlurEventDispatchMediator):

  • dom/EventFactory.in:
  • dom/FocusEvent.cpp: Removed.
  • dom/FocusEvent.h: Removed.
  • dom/FocusEvent.idl: Removed.
  • dom/Node.cpp:

(WebCore::Node::dispatchFocusInEvent):
(WebCore::Node::dispatchFocusOutEvent):

  • dom/UIEvent.cpp:

(WebCore::FocusInEventDispatchMediator::create):
(WebCore):
(WebCore::FocusInEventDispatchMediator::FocusInEventDispatchMediator):
(WebCore::FocusInEventDispatchMediator::dispatchEvent):
(WebCore::FocusOutEventDispatchMediator::create):
(WebCore::FocusOutEventDispatchMediator::FocusOutEventDispatchMediator):
(WebCore::FocusOutEventDispatchMediator::dispatchEvent):

  • dom/UIEvent.h:

(FocusInEventDispatchMediator):
(WebCore):
(FocusOutEventDispatchMediator):

  • page/DOMWindow.idl:

LayoutTests: Unreviewed rollout r107952 because it broke shadow-boundary-events.html and related-target-focusevent.html on mac.
see ​http://webkit.org/b/78832

  • fast/dom/shadow/shadow-boundary-events-expected.txt:
  • fast/dom/shadow/shadow-boundary-events.html:
  • fast/events/event-creation-expected.txt:
  • fast/events/event-creation.html:
  • fast/events/related-target-focusevent-expected.txt: Removed.
  • fast/events/related-target-focusevent.html: Removed.
10:21 PM Changeset in webkit [108033] by noel.gordon@gmail.com
  • 4 edits
    2 adds in trunk/LayoutTests

[chromium] Rebaseline JPEG image results after r107389
​https://bugs.webkit.org/show_bug.cgi?id=78454

Unreviewed. Rebaseline #29 of N. Chrome MAC differences under discussion in bug
BUGCR23473, retain IMAGE expectation on MAC therefore, update the pixel results.

  • platform/chromium-linux/fast/repaint/backgroundSizeRepaint-expected.png:
  • platform/chromium-mac-leopard/fast/repaint/backgroundSizeRepaint-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/repaint/backgroundSizeRepaint-expected.png: Added.
  • platform/chromium-win/fast/repaint/backgroundSizeRepaint-expected.png:
  • platform/chromium/test_expectations.txt:
10:20 PM Changeset in webkit [108032] by mhahnenberg@apple.com
  • 2 edits in trunk/Source/WebCore

Another fix for viewport tests

No new tests.

  • dom/ViewportArguments.cpp:

(WebCore::numericPrefix): When we don't parse a number, we could either be
trying to parse junk, which returns NaN, or we could get an empty string,
which returns 0, so we need to account for that in the assert.

9:58 PM Changeset in webkit [108031] by commit-queue@webkit.org
  • 6 edits in trunk/Source

[chromium] Bundle page scale factor and limits in CCLayerTreeHost
​https://bugs.webkit.org/show_bug.cgi?id=78762

Setting page scale factor and its limits in separate methods
may cause clamping bugs if one of them makes it to the
impl thread before the other. Change the API to bundle them together,
which matches the existing impl-side interface.

Patch by Alexandre Elias <​aelias@google.com> on 2012-02-16
Reviewed by James Robinson.

Source/WebCore:

No new tests (API change will disallow this type of bug).

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::CCLayerTreeHost):
(WebCore::CCLayerTreeHost::finishCommitOnImplThread):
(WebCore::CCLayerTreeHost::setPageScaleFactorAndLimits):

  • platform/graphics/chromium/cc/CCLayerTreeHost.h:

(CCLayerTreeHost):

Source/WebKit/chromium:

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::computePageScaleFactorLimits):
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
(WebKit::WebViewImpl::updateLayerTreeViewport):

  • tests/CCLayerTreeHostTest.cpp:

(WTF::CCLayerTreeHostTestStartPageScaleAnimation::applyScrollAndScale):

9:51 PM Changeset in webkit [108030] by noel.gordon@gmail.com
  • 2 edits
    1 add in trunk/LayoutTests

Rebaseline JPEG image results after r107389
​https://bugs.webkit.org/show_bug.cgi?id=78454

Unreviewed. Rebaseline #26 of N. Color profiles are not supported in chrome win/linux.
Retain the FAIL MISSING expectation, update the failing win/linux pixel result.

  • platform/chromium-win/fast/images/color-jpeg-with-color-profile-expected.png: Added.
  • platform/chromium/test_expectations.txt:
9:49 PM Changeset in webkit [108029] by noel.gordon@gmail.com
  • 6 edits
    4 adds in trunk/LayoutTests

[chromium] Rebaseline JPEG image results after r107389
​https://bugs.webkit.org/show_bug.cgi?id=78454

Unreviewed. Rebaseline #28 of N. Chrome MAC differences under discussion in bug
BUGCR23473, retain IMAGE expectation on MAC therefore, update the pixel results.

  • platform/chromium-linux/fast/repaint/clipped-relative-expected.png:
  • platform/chromium-linux/fast/repaint/selected-replaced-expected.png:
  • platform/chromium-mac-leopard/fast/repaint/clipped-relative-expected.png: Added.
  • platform/chromium-mac-leopard/fast/repaint/selected-replaced-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/repaint/clipped-relative-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/repaint/selected-replaced-expected.png: Added.
  • platform/chromium-win/fast/repaint/clipped-relative-expected.png:
  • platform/chromium-win/fast/repaint/selected-replaced-expected.png:
  • platform/chromium/test_expectations.txt:
9:34 PM Changeset in webkit [108028] by haraken@chromium.org
  • 5 edits in trunk/Source/WebCore

Unreviewed. Rebaselined run-bindings-tests results.

  • bindings/scripts/test/JS/JSTestEventConstructor.cpp:

(WebCore::JSTestEventConstructorConstructor::finishCreation):

  • bindings/scripts/test/JS/JSTestInterface.cpp:

(WebCore::JSTestInterfaceConstructor::finishCreation):

  • bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::JSTestObjConstructor::finishCreation):

  • bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:

(WebCore::JSTestSerializedScriptValueInterfaceConstructor::finishCreation):

9:33 PM Changeset in webkit [108027] by commit-queue@webkit.org
  • 4 edits
    1 add in trunk/Source/WebKit/chromium

[Chromium] Add method to WebViewImpl to extract zoom/scroll params for gesture events on touch devices
​https://bugs.webkit.org/show_bug.cgi?id=72909

Patch by Varun Jain <​varunjain@google.com> on 2012-02-16
Reviewed by James Robinson.

  • src/WebViewImpl.cpp:

(std):
(WebKit):
(WebKit::WebViewImpl::computeBlockBounds):
(WebKit::WebViewImpl::widenRectWithinPageBounds):
(WebKit::WebViewImpl::computeScaleAndScrollForHitRect):

  • src/WebViewImpl.h:

(WebViewImpl):

  • tests/WebFrameTest.cpp:

(WebKit):
(WebKit::TEST_F):

  • tests/data/get_scale_for_auto_zoom_into_div_test.html: Added.
9:26 PM Changeset in webkit [108026] by noel.gordon@gmail.com
  • 3 edits
    1 move
    1 add
    8 deletes in trunk/LayoutTests

[chromium] Rebaseline JPEG image results after r107389
​https://bugs.webkit.org/show_bug.cgi?id=78454

Unreviewed. Rebaseline #25 of N. Chrome MAC rendering was previously incorrect, and
still is incorrect/weird: update test_expectations.txt with IMAGE failure.

  • platform/chromium-linux/compositing/overflow/overflow-scaled-descendant-overlapping-expected.png: Removed.
  • platform/chromium-linux/compositing/overflow/overflow-scaled-descendant-overlapping-expected.txt: Removed.
  • platform/chromium-mac-leopard/compositing/overflow/overflow-scaled-descendant-overlapping-expected.png: Added.
  • platform/chromium-mac-snowleopard/compositing/overflow/overflow-scaled-descendant-overlapping-expected.png:
  • platform/chromium-mac-snowleopard/compositing/overflow/overflow-scaled-descendant-overlapping-expected.txt: Removed.
  • platform/chromium-win-vista/compositing/overflow/overflow-scaled-descendant-overlapping-expected.png: Removed.
  • platform/chromium-win-vista/compositing/overflow/overflow-scaled-descendant-overlapping-expected.txt: Removed.
  • platform/chromium-win-xp/compositing/overflow/overflow-scaled-descendant-overlapping-expected.png: Removed.
  • platform/chromium-win-xp/compositing/overflow/overflow-scaled-descendant-overlapping-expected.txt: Removed.
  • platform/chromium-win/compositing/overflow/overflow-scaled-descendant-overlapping-expected.txt: Removed.
  • platform/chromium/compositing/overflow/overflow-scaled-descendant-overlapping-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/compositing/overflow/overflow-scaled-descendant-overlapping-expected.txt.
  • platform/chromium/test_expectations.txt:
9:02 PM Changeset in webkit [108025] by commit-queue@webkit.org
  • 6 edits in trunk/Source

[chromium] LayerChromium::setNeedsDisplay does not apply contents scale correctly
​https://bugs.webkit.org/show_bug.cgi?id=77464

Source/WebCore:

Use bounds() instead of contentBounds() to calculate the region to mark
as needing painting in LayerChromium::setNeedsDisplay(). contentBounds()
includes contents scale, while bounds() does not.

Since this change also means that TiledLayerChromium::setNeedsDisplayRect() is
given an unscaled rectangle, modify that function to scale the rectangle before
using it to invalidate the underlying tiles.

Patch by Sami Kyostila <​skyostil@chromium.org> on 2012-02-16
Reviewed by James Robinson.

Tests: New tests added to LayerChromium and TiledLayerChromium unit tests.

  • platform/graphics/chromium/LayerChromium.h:

(WebCore::LayerChromium::setNeedsDisplay):

  • platform/graphics/chromium/TiledLayerChromium.cpp:

(WebCore::TiledLayerChromium::setNeedsDisplayRect):

Source/WebKit/chromium:

Added a new unit test for TiledLayerChromium to verify its invalidation behavior when
the contents scale changes. Also enhance and existing unit test for LayerChromium to
verify the paint rectangle dimensions instead just checking that it is not empty.

Patch by Sami Kyostila <​skyostil@chromium.org> on 2012-02-16
Reviewed by James Robinson.

  • tests/LayerChromiumTest.cpp:
  • tests/TiledLayerChromiumTest.cpp:

(WTF::FakeTiledLayerChromium::setNeedsDisplayRect):
(FakeTiledLayerChromium):
(WTF::FakeTiledLayerChromium::lastNeedsDisplayRect):
(WTF::TEST):
(WTF):

8:50 PM Changeset in webkit [108024] by noel.gordon@gmail.com
  • 6 edits in trunk/LayoutTests

[chromium] Rebaseline JPEG image results after r107389
​https://bugs.webkit.org/show_bug.cgi?id=78454

Unreviewed. Rebaseline #27 of N.

  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-39-t-expected.png:
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1/animate-elem-39-t-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-39-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-39-t-expected.png:
  • platform/chromium/test_expectations.txt:
8:46 PM Changeset in webkit [108023] by morrita@google.com
  • 3 edits in trunk/Source/WebKit/chromium

​https://bugs.webkit.org/show_bug.cgi?id=78065
[Chromium] Should eliminate WebTextCheckingResult legacy APIs

Reviewed by Kent Tamura.

Removed unused legacy members.

  • public/WebTextCheckingResult.h:

(WebKit::WebTextCheckingResult::WebTextCheckingResult):
(WebTextCheckingResult):

  • src/AssertMatchingEnums.cpp:
8:36 PM Changeset in webkit [108022] by commit-queue@webkit.org
  • 7 edits in trunk/Source/WebCore

Lazy init for DefaultAudioDestinationNode and OfflineAudioDestinationNode
​https://bugs.webkit.org/show_bug.cgi?id=76509

Patch by Raymond Liu <​raymond.liu@intel.com> on 2012-02-16
Reviewed by Eric Seidel.

No new tests required.

  • webaudio/AudioDestinationNode.h:
  • webaudio/AudioNode.h:

(WebCore::AudioNode::sampleRate):

  • webaudio/DefaultAudioDestinationNode.cpp:

(WebCore::DefaultAudioDestinationNode::DefaultAudioDestinationNode):

  • webaudio/DefaultAudioDestinationNode.h:
  • webaudio/OfflineAudioDestinationNode.cpp:

(WebCore::OfflineAudioDestinationNode::OfflineAudioDestinationNode):

  • webaudio/OfflineAudioDestinationNode.h:

(WebCore::OfflineAudioDestinationNode::sampleRate):

8:13 PM Changeset in webkit [108021] by shinyak@chromium.org
  • 3 edits in trunk/Source/WebCore

[Refactoring] Remove location from NodeRenderingContext.
​https://bugs.webkit.org/show_bug.cgi?id=78796

Reviewed by Hajime Morita.

This is a simple refactoring to remove m_location from NodeRenderingContext.
TreeLocation is merged into AttachPhase like the following.

LocationUndertermined -> Calculating
LocationNotInTree -> AttachingNotInTree
LocationLightChild -> AttachingStraight / AttachingNotDistributed / AttachingDistributed
LocationShadowChild -> AttachingStraight / AttachingShadowChild / AttachingFallback

We have renamed the enum items of AttachPhase, because not only <content> but also
<shadow> will use the phases. Basically these words are taken from Shadow DOM spec.
'Calculating' means NodeRenderingContext is used not for attaching but for calculating RenderObject.

No new tests, no change in behavior.

  • dom/NodeRenderingContext.cpp:

(WebCore::NodeRenderingContext::NodeRenderingContext):
(WebCore::NodeRenderingContext::nextRenderer):
(WebCore::NodeRenderingContext::previousRenderer):
(WebCore::NodeRenderingContext::parentRenderer):
(WebCore::NodeRenderingContext::shouldCreateRenderer):

  • dom/NodeRenderingContext.h:

(NodeRenderingContext):
(WebCore::NodeRenderingContext::parentNodeForRenderingAndStyle):

8:10 PM Changeset in webkit [108020] by fpizlo@apple.com
  • 18 edits in trunk/Source/JavaScriptCore

ENABLE_INTERPRETER should be ENABLE_CLASSIC_INTERPRETER
​https://bugs.webkit.org/show_bug.cgi?id=78791

Rubber stamped by Oliver Hunt.

Just a renaming, nothing more. Also renamed COMPUTED_GOTO_INTERPRETER to
COMPUTED_GOTO_CLASSIC_INTERPRETER.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::dump):
(JSC::CodeBlock::stronglyVisitStrongReferences):
(JSC):
(JSC::CodeBlock::shrinkToFit):

  • bytecode/CodeBlock.h:

(CodeBlock):

  • bytecode/Instruction.h:

(JSC::Instruction::Instruction):

  • bytecode/Opcode.h:

(JSC::padOpcodeName):

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::emitResolve):
(JSC::BytecodeGenerator::emitResolveWithBase):
(JSC::BytecodeGenerator::emitGetById):
(JSC::BytecodeGenerator::emitPutById):
(JSC::BytecodeGenerator::emitDirectPutById):

  • interpreter/AbstractPC.cpp:

(JSC::AbstractPC::AbstractPC):

  • interpreter/AbstractPC.h:

(AbstractPC):

  • interpreter/CallFrame.h:

(ExecState):

  • interpreter/Interpreter.cpp:

(JSC):
(JSC::Interpreter::initialize):
(JSC::Interpreter::isOpcode):
(JSC::Interpreter::unwindCallFrame):
(JSC::Interpreter::execute):
(JSC::Interpreter::privateExecute):
(JSC::Interpreter::retrieveLastCaller):

  • interpreter/Interpreter.h:

(JSC::Interpreter::getOpcode):
(JSC::Interpreter::getOpcodeID):
(Interpreter):

  • jit/ExecutableAllocatorFixedVMPool.cpp:

(JSC::FixedVMPoolExecutableAllocator::FixedVMPoolExecutableAllocator):

  • runtime/Executable.cpp:

(JSC::EvalExecutable::compileInternal):
(JSC::ProgramExecutable::compileInternal):
(JSC::FunctionExecutable::compileForCallInternal):
(JSC::FunctionExecutable::compileForConstructInternal):

  • runtime/Executable.h:

(NativeExecutable):

  • runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::JSGlobalData):
(JSC::JSGlobalData::getHostFunction):

  • runtime/JSGlobalData.h:

(JSGlobalData):

  • wtf/OSAllocatorPosix.cpp:

(WTF::OSAllocator::reserveAndCommit):

  • wtf/Platform.h:
7:50 PM Changeset in webkit [108019] by tkent@chromium.org
  • 2 edits in trunk/Source/WebCore

Run sort-Xcode-project-file.

  • WebCore.xcodeproj/project.pbxproj: Sorted.
7:46 PM Changeset in webkit [108018] by mhahnenberg@apple.com
  • 2 edits in trunk/Source/WebCore

Another build fix for viewport tests

No new tests.

  • dom/ViewportArguments.cpp:

(WebCore::numericPrefix): We now return NaN instead of 0 when we fail to
parse a number using charactersToFloatIgnoringJunk, so we need to assert that
we have NaN rather than 0.

7:32 PM Changeset in webkit [108017] by evan@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] pull third_party/gold to fix linux build
​https://bugs.webkit.org/show_bug.cgi?id=78842

Reviewed by Tony Chang.

The Chrome build now depends on third_party/gold also being checked out.

  • DEPS:
7:28 PM Changeset in webkit [108016] by noel.gordon@gmail.com
  • 4 edits in trunk/LayoutTests

[chromium] Rebaseline JPEG image results after r107389
​https://bugs.webkit.org/show_bug.cgi?id=78454

Unreviewed. Rebaseline #24 of N. Differences in rendered image extents on chrome
LINUX, WIN compared to chrome MAC. Retain that fact in test_expectations.txt.

  • platform/chromium-linux/tables/mozilla/bugs/bug101674-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug101674-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug101674-expected.txt:
  • platform/chromium/test_expectations.txt:
7:18 PM Changeset in webkit [108015] by Michael Nordman
  • 10 edits in trunk/Source

Source/WebCore: [chromium] Fix bugs in the implementation of WebDatabase::closeDatabaseImmediately.
​https://bugs.webkit.org/show_bug.cgi?id=78841

WebDatabase now delegates this function entirely to DatabaseTracker,
a new closeDatabasesImmediately() has been added for that purpose. That
method posts tasks to the appropiate context thread for each database
instance that should be closed immediately.

The DatabaseTracker getAllOpenDatabases() method has been removed from
the chromium impl because it's unsafe, refs cannot be safely taken on
AbstractDatabase instances in the tracker's collection of open databases.

Add a message to the console log when a database is forcibly closed.

Transactions initiated on a database instance that has been forcibly
closed complete with a transaction error callback.

This is part of resolving ​http://crbug.com/98939

Reviewed by David Levin.

No new layout tests, there is no common code way to closeImmediately.
We have coverage for this in py automation tests.

  • platform/sql/SQLiteDatabase.cpp:

The closeImmediately code path can result in the underlying sqlite3 handle being
closed earlier than usual and trip some assertions. Updated the assertions to no
longer trigger in this early close case.
(WebCore::SQLiteDatabase::close):
(WebCore::SQLiteDatabase::setMaximumSize):

  • platform/sql/SQLiteDatabase.h:

(WebCore::SQLiteDatabase::sqlite3Handle):

  • storage/Database.cpp:

(WebCore::Database::closeImmediately): Modified to only be called on the context thread and to log a console message.
(WebCore::Database::changeVersion): Use the private runTransaction helper method.
(WebCore::Database::transaction): Pass a new param required by the runTransaction helper.
(WebCore::Database::readTransaction): Ditto.
(WebCore::callTransactionErrorCallback): Used to defer invocation of the error callback.
(WebCore::Database::runTransaction): Modified to detect when the database has been closed, and
to invoke the error callback in that case. This also avoids creating a reference cycle between
a newly created transaction and the database that previously existed due to a transction being
added and never removed from the Q while in this state.

  • storage/Database.h:
  • storage/DatabaseSync.cpp:

(WebCore::DatabaseSync::closeImmediately): Modified to only be called on the context thread and to log a console message.

  • storage/DatabaseTracker.h:
  • storage/chromium/DatabaseTrackerChromium.cpp:

Posts tasks to the appropiate context thread for execution without bumping AbstractDatabase refcounts.
(DatabaseTracker::CloseOneDatabaseImmediatelyTask):
(WebCore::DatabaseTracker::CloseOneDatabaseImmediatelyTask::create):
(WebCore::DatabaseTracker::CloseOneDatabaseImmediatelyTask::performTask):
(WebCore::DatabaseTracker::CloseOneDatabaseImmediatelyTask::CloseOneDatabaseImmediatelyTask):
(WebCore::DatabaseTracker::closeDatabasesImmediately):
(WebCore::DatabaseTracker::closeOneDatabaseImmediately):

Source/WebKit/chromium: Fix bugs in the implementation of WebDatabase::closeDatabaseImmediately.
​https://bugs.webkit.org/show_bug.cgi?id=78841

WebDatabase now delegates this function entirely to DatabaseTracker.
This is part of resolving ​http://crbug.com/98939

Reviewed by David Levin.

  • src/WebDatabase.cpp:

(WebKit::WebDatabase::closeDatabaseImmediately):

6:41 PM Changeset in webkit [108014] by noel.gordon@gmail.com
  • 6 edits in trunk/LayoutTests

[chromium] Rebaseline JPEG image results after r107389
​https://bugs.webkit.org/show_bug.cgi?id=78454

Unreviewed. Rebaseline #23 of N.

  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-36-t-expected.png:
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1/animate-elem-36-t-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-36-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-36-t-expected.png:
  • platform/chromium/test_expectations.txt:
6:27 PM Changeset in webkit [108013] by commit-queue@webkit.org
  • 14 edits
    13 adds in trunk

[Chromium] Occlusion tracking with CSS filters
​https://bugs.webkit.org/show_bug.cgi?id=77498

Patch by Dana Jansens <​danakj@chromium.org> on 2012-02-16
Reviewed by James Robinson.

Source/WebCore:

The new CSS filter support within the compositor changes how
occlusion tracking needs to function. A filter can change the
alpha value of pixels, making an otherwise opaque pixel no
longer so. Secondly, a filter may move color values around
on a surface, which can cause otherwise occluded areas to
become visible and require painting.

New unit tests: CCLayerTreeHostTest.cpp

Tests: compositing/culling/filter-occlusion-alpha-large.html

compositing/culling/filter-occlusion-alpha.html
compositing/culling/filter-occlusion-blur-large.html
compositing/culling/filter-occlusion-blur.html

  • platform/graphics/chromium/RenderSurfaceChromium.cpp:

(WebCore::RenderSurfaceChromium::RenderSurfaceChromium):

  • platform/graphics/chromium/RenderSurfaceChromium.h:

(WebCore::RenderSurfaceChromium::setFilters):
(WebCore::RenderSurfaceChromium::filters):
(WebCore::RenderSurfaceChromium::setNearestAncestorThatMovesPixels):
(WebCore::RenderSurfaceChromium::nearestAncestorThatMovesPixels):
(RenderSurfaceChromium):

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::enterTargetRenderSurface):
(WebCore::CCLayerTreeHost::paintLayerContents):

  • platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:

(WebCore::subtreeShouldRenderToSeparateSurface):
(WebCore::calculateDrawTransformsAndVisibilityInternal):
(WebCore::CCLayerTreeHostCommon::calculateDrawTransformsAndVisibility):

  • platform/graphics/chromium/cc/CCRenderSurface.cpp:

(WebCore::CCRenderSurface::CCRenderSurface):

  • platform/graphics/chromium/cc/CCRenderSurface.h:

(WebCore::CCRenderSurface::setNearestAncestorThatMovesPixels):
(WebCore::CCRenderSurface::nearestAncestorThatMovesPixels):
(CCRenderSurface):

  • platform/graphics/filters/FilterOperation.h:

(FilterOperation):
(WebCore::FilterOperation::affectsOpacity):
(WebCore::FilterOperation::movesPixels):
(WebCore::ReferenceFilterOperation::affectsOpacity):
(WebCore::ReferenceFilterOperation::movesPixels):
(ReferenceFilterOperation):
(WebCore::BasicComponentTransferFilterOperation::affectsOpacity):
(BasicComponentTransferFilterOperation):
(WebCore::BlurFilterOperation::affectsOpacity):
(WebCore::BlurFilterOperation::movesPixels):
(BlurFilterOperation):
(WebCore::DropShadowFilterOperation::affectsOpacity):
(DropShadowFilterOperation):

  • platform/graphics/filters/FilterOperations.cpp:

(WebCore::FilterOperations::hasFilterThatAffectsOpacity):
(WebCore):
(WebCore::FilterOperations::hasFilterThatMovesPixels):

  • platform/graphics/filters/FilterOperations.h:

(WebCore::FilterOperations::isEmpty):
(FilterOperations):

Source/WebKit/chromium:

  • tests/CCLayerTreeHostTest.cpp:

(CCLayerTreeHostTestLayerOcclusionWithFilters):
(WTF::CCLayerTreeHostTestLayerOcclusionWithFilters::CCLayerTreeHostTestLayerOcclusionWithFilters):
(WTF::CCLayerTreeHostTestLayerOcclusionWithFilters::beginTest):
(WTF::CCLayerTreeHostTestLayerOcclusionWithFilters::afterTest):
(WTF):

LayoutTests:

  • compositing/culling/filter-occlusion-alpha-expected.png: Added.
  • compositing/culling/filter-occlusion-alpha-expected.txt: Added.
  • compositing/culling/filter-occlusion-alpha-large-expected.png: Added.
  • compositing/culling/filter-occlusion-alpha-large-expected.txt: Added.
  • compositing/culling/filter-occlusion-alpha-large.html: Added.
  • compositing/culling/filter-occlusion-alpha.html: Added.
  • compositing/culling/filter-occlusion-blur-expected.txt: Added.
  • compositing/culling/filter-occlusion-blur-large-expected.txt: Added.
  • compositing/culling/filter-occlusion-blur-large.html: Added.
  • compositing/culling/filter-occlusion-blur.html: Added.
  • platform/chromium/compositing/culling/filter-occlusion-blur-expected.png: Added.
  • platform/chromium/compositing/culling/filter-occlusion-blur-large-expected.png: Added.
  • platform/chromium/test_expectations.txt:
6:15 PM Changeset in webkit [108012] by noel.gordon@gmail.com
  • 6 edits in trunk/LayoutTests

[chromium] Rebaseline JPEG image results after r107389
​https://bugs.webkit.org/show_bug.cgi?id=78454

Unreviewed. Rebaseline #22 of N.

  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-40-t-expected.png:
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1/animate-elem-40-t-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-40-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-40-t-expected.png:
  • platform/chromium/test_expectations.txt:
6:08 PM Changeset in webkit [108011] by leo.yang@torchmobile.com.cn
  • 5 edits in trunk/Source

[BlackBerry] Adapt to the removal of WebStringIml.h
​https://bugs.webkit.org/show_bug.cgi?id=78784

Reviewed by Antonio Gomes.

Source/WebCore:

WebKit/blackberry/WebCoreSupport/WebStringImpl.h which hasn't been upstreamed
has been removed internally. We should adapt to this removal for the
upstreamed part of the BlackBerry port. Actually WebStringImpl is not necessary
because it just inherits from WTF::StringImpl but adding nothing.

No functionalities changed, no new tests.

  • platform/text/blackberry/StringBlackBerry.cpp:

(WTF::String::operator WebString):

Source/WebKit:

blackberry/WebCoreSupport/WebStringImpl.h which hasn't been upstreamed
has been removed internally. We should adapt to this removal for the
upstreamed part of the BlackBerry port. Actually WebStringImpl is not necessary
because it just inherits from WTF::StringImpl but adding nothing.

  • blackberry/Api/WebString.cpp:

(BlackBerry::WebKit::WebString::WebString):
(BlackBerry::WebKit::WebString::equalIgnoringCase):

  • blackberry/Api/WebString.h:

(WTF):

5:56 PM Changeset in webkit [108010] by ggaren@apple.com
  • 16 edits
    1 add in trunk/Source

Made Weak<T> single-owner, adding PassWeak<T>
​https://bugs.webkit.org/show_bug.cgi?id=78740

Reviewed by Sam Weinig.

Source/JavaScriptCore:

This works basically the same way as OwnPtr<T> and PassOwnPtr<T>.

This clarifies the semantics of finalizers: It's ambiguous and probably
a bug to copy a finalizer (i.e., it's a bug to run a C++ destructor
twice), so I've made Weak<T> non-copyable. Anywhere we used to copy a
Weak<T>, we now use PassWeak<T>.

This also makes Weak<T> HashMaps more efficient.

  • API/JSClassRef.cpp:

(OpaqueJSClass::prototype): Use PassWeak<T> instead of set(), since
set() is gone now.

  • heap/PassWeak.h: Added.

(JSC):
(PassWeak):
(JSC::PassWeak::PassWeak):
(JSC::PassWeak::~PassWeak):
(JSC::PassWeak::get):
(JSC::::leakHandle):
(JSC::adoptWeak):
(JSC::operator==):
(JSC::operator!=): This is the Weak<T> version of PassOwnPtr<T>.

  • heap/Weak.h:

(Weak):
(JSC::Weak::Weak):
(JSC::Weak::release):
(JSC::Weak::hashTableDeletedValue):
(JSC::=):
(JSC): Changed to be non-copyable, removing a lot of copying-related
APIs. Added hash traits so hash maps still work.

  • jit/JITStubs.cpp:

(JSC::JITThunks::hostFunctionStub):

  • runtime/RegExpCache.cpp:

(JSC::RegExpCache::lookupOrCreate): Use PassWeak<T>, as required by
our new hash map API.

Source/WebCore:

  • bindings/js/JSDOMBinding.cpp:

(WebCore::jsStringSlowCase): Use PassWeak<T>, as required by our new
hash map API.

  • bindings/js/JSDOMBinding.h:

(WebCore::getCachedWrapper):
(WebCore::cacheWrapper): Use PassWeak<T> and raw pointer, as required by
our new hash map API.

  • bindings/js/JSEventListener.h:

(WebCore::JSEventListener::setWrapper):

  • bindings/js/ScriptWrappable.h:

(WebCore::ScriptWrappable::setWrapper):

  • bridge/jsc/BridgeJSC.cpp:

(JSC::Bindings::Instance::createRuntimeObject):

  • bridge/runtime_root.cpp:

(JSC::Bindings::RootObject::addRuntimeObject): Use PassWeak<T>, as
required by our new hash map and Weak<T> APIs.

Source/WebKit2:

  • WebProcess/Plugins/Netscape/NPRuntimeObjectMap.cpp:

(WebKit::NPRuntimeObjectMap::getOrCreateJSObject): Use raw pointer and
PassWeak<T>, as required by our new hash map API.

5:43 PM Changeset in webkit [108009] by rniwa@webkit.org
  • 6 edits
    2 adds in trunk

Crash in visiblePositionForIndex
​https://bugs.webkit.org/show_bug.cgi?id=77683

Reviewed by Eric Seidel.

Source/WebCore:

Fixed the crash.

Test: editing/execCommand/applyblockelement-visiblepositionforindex-crash.html

  • editing/ApplyBlockElementCommand.cpp:

(WebCore::ApplyBlockElementCommand::doApply):

  • editing/InsertListCommand.cpp:

(WebCore::InsertListCommand::doApply):

  • editing/htmlediting.cpp:

(WebCore::indexForVisiblePosition):

  • editing/htmlediting.h:

(WebCore):

LayoutTests:

Add a regression test. It crashes Webkit with very high frequency.

  • editing/execCommand/applyblockelement-visiblepositionforindex-crash-expected.txt: Added.
  • editing/execCommand/applyblockelement-visiblepositionforindex-crash.html: Added.
5:40 PM Changeset in webkit [108008] by mdelaney@apple.com
  • 2 edits in trunk/Source/WebCore

ShadowBlur.cpp's cached content matching needs to consider m_layerSize changes
​https://bugs.webkit.org/show_bug.cgi?id=78765

Reviewed by Simon Fraser.

No new tests due to the flaky nature of reproducing the issue.

  • platform/graphics/ShadowBlur.cpp:

(WebCore::ScratchBuffer::getScratchBuffer): Make sure to call clearScratchBuffer()
when we create a new ImageBuffer in order to invalidate cached values.
(WebCore::ScratchBuffer::setCachedShadowValues): Roll together matching and setting
of cached values into one method to enforce them being the same.
(WebCore::ScratchBuffer::setCachedInsetShadowValues): Ditto.

Restructure to use new method described above.
(WebCore::ShadowBlur::drawRectShadowWithoutTiling):
(WebCore::ShadowBlur::drawInsetShadowWithoutTiling):
(WebCore::ShadowBlur::drawInsetShadowWithTiling):
(WebCore::ShadowBlur::drawRectShadowWithTiling):
(WebCore::ShadowBlur::beginShadowLayer):

5:30 PM Changeset in webkit [108007] by commit-queue@webkit.org
  • 3 edits
    3 adds in trunk

[chromium] Empty divs not transforming overflow correctly
​https://bugs.webkit.org/show_bug.cgi?id=78850

Patch by Dana Jansens <​danakj@chromium.org> on 2012-02-16
Reviewed by James Robinson.

Source/WebCore:

Test: compositing/overflow/transform-in-empty-container.html

  • platform/graphics/chromium/GraphicsLayerChromium.cpp:

(WebCore::GraphicsLayerChromium::setSize):

LayoutTests:

  • compositing/overflow/transform-in-empty-container-expected.png: Added.
  • compositing/overflow/transform-in-empty-container-expected.txt: Added.
  • compositing/overflow/transform-in-empty-container.html: Added.
5:16 PM Changeset in webkit [108006] by eae@chromium.org
  • 2 edits in trunk/Source/WebCore

Fix use of long long in FractionalLayoutUnit::setRawValue
​https://bugs.webkit.org/show_bug.cgi?id=78835

Reviewed by Eric Seidel.

Change setRawValue(long long) to compare against int min and max instead
of using abs as not all platforms we support implement a long long
version of abs or llabs.

No new tests.

  • platform/FractionalLayoutUnit.h:

(WebCore::FractionalLayoutUnit::setRawValue):
Compare against int min/max instead of just max with abs.

(WebCore::FractionalLayoutUnit::isInBounds):
Fix type mismatch warning.

(WebCore::operator==):
Fix typo.

(WebCore::operator*):
Use long long version of setRawValue.

5:11 PM Changeset in webkit [108005] by dpranke@chromium.org
  • 3 edits in trunk/Tools

nrwt: simplify worker interface
​https://bugs.webkit.org/show_bug.cgi?id=78181

Reviewed by Tony Chang.

This change moves code in name(), is_done(), run(), and cancel()
from Worker to AbstractWorker, since the logic is pretty much
boilerplate code that any implementation would want to use.

  • Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:

(get.should):
(AbstractWorker.init):
(AbstractWorker):
(AbstractWorker.name):
(AbstractWorker.stop_handling_messages):
(AbstractWorker.run):
(AbstractWorker.is_done):
(AbstractWorker.cancel):

  • Scripts/webkitpy/layout_tests/controllers/worker.py:

(Worker.init):
(Worker.run):
(Worker.handle_stop):

5:06 PM Changeset in webkit [108004] by jamesr@google.com
  • 2 edits in trunk/LayoutTests

[chromium] Unreviewed baseline update for compositing/scrollbar-painting.html

  • platform/chromium-mac-snowleopard/compositing/scrollbar-painting-expected.png:
4:57 PM Changeset in webkit [108003] by shinyak@chromium.org
  • 11 edits in trunk

Source/WebCore: Add an internal flag to accept multiple shadow roots for the purpose of tests.
​https://bugs.webkit.org/show_bug.cgi?id=78453

Reviewed by Hajime Morita.

This patch introduces a flag to enable multiple shadow subtrees.
This flag is intended to be used for testing purpose for a while.
We will remove it later.

No new tests, no change in behavior.

  • WebCore.exp.in:
  • bindings/generic/RuntimeEnabledFeatures.cpp:

(WebCore):

  • bindings/generic/RuntimeEnabledFeatures.h:

(RuntimeEnabledFeatures):
(WebCore::RuntimeEnabledFeatures::multipleShadowSubtreesEnabled):
(WebCore::RuntimeEnabledFeatures::setMultipleShadowSubtreesEnabled):

  • dom/ShadowRoot.cpp:

(WebCore::ShadowRoot::create):

  • dom/ShadowRootList.cpp:

(WebCore::ShadowRootList::pushShadowRoot):

  • testing/Internals.cpp:

(WebCore::Internals::setMultipleShadowSubtreesEnabled):
(WebCore):

  • testing/Internals.h:

(Internals):

  • testing/Internals.idl:

LayoutTests: Needs an internal flag to accept multiple shadow roots for the purpose of tests
​https://bugs.webkit.org/show_bug.cgi?id=78453

Reviewed by Hajime Morita.

  • fast/dom/shadow/shadow-root-js-api.html:
4:57 PM Changeset in webkit [108002] by tkent@chromium.org
  • 2 edits in trunk/Websites/webkit.org

Improve usability of coding-style.html
​https://bugs.webkit.org/show_bug.cgi?id=78470

Reviewed by Eric Seidel.

  • coding/coding-style.html:
  • Do not add a title attribute to each of LI elements
  • Do not add a click handler to each of them
  • Add a SPAN element in order to show [id-name] and provide smaller clickable area.
4:54 PM Changeset in webkit [108001] by mhahnenberg@apple.com
  • 9 edits in trunk

Fix the broken viewport tests
​https://bugs.webkit.org/show_bug.cgi?id=78774

Reviewed by Kenneth Rohde Christiansen.

Source/JavaScriptCore:

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
  • wtf/text/WTFString.cpp:

(WTF):
(WTF::toDoubleType): Template-ized to allow other functions to specify whether they
want to allow trailing junk or not when calling strtod.
(WTF::charactersToDouble):
(WTF::charactersToFloat):
(WTF::charactersToFloatIgnoringJunk): Created new version of charactersToFloat that allows
trailing junk.

  • wtf/text/WTFString.h:

(WTF):

Source/WebCore:

No new tests.

  • dom/ViewportArguments.cpp:

(WebCore::numericPrefix): Changed to use the new charactersToFloatWithJunk function(s).

LayoutTests:

  • platform/gtk/Skipped: Undoing tests skipped due to earlier breakage.
  • platform/qt/Skipped: Ditto.
4:49 PM Changeset in webkit [108000] by commit-queue@webkit.org
  • 23 edits in trunk/LayoutTests

[chromium] Disable mock scrollbars for rubber-banding tests
​https://bugs.webkit.org/show_bug.cgi?id=78370

Turning on mock scrollbars caused rubber-banding tests to fail
because the overhang is painted by the ScrollbarTheme, which
was replaced by the mock theme. Disable mock scrollbars for
these tests.

Patch by Alexei Svitkine <​asvitkine@chromium.org> on 2012-02-16
Reviewed by James Robinson.

  • platform/chromium/test_expectations.txt:
4:48 PM Changeset in webkit [107999] by cdn@chromium.org
  • 2 edits in trunk/Source/WebCore

Very large strings could cause the new quoted string to wrap.
​https://bugs.webkit.org/show_bug.cgi?id=78387

Reviewed by Eric Seidel.

  • css/CSSParser.cpp:

(WebCore::quoteCSSString):

4:46 PM Changeset in webkit [107998] by eric@webkit.org
  • 4 edits
    1 add in trunk/Source/WebCore

Add a themeChromiumAndroid.css file for android-specific default styles
​https://bugs.webkit.org/show_bug.cgi?id=78547

Reviewed by Adam Barth.

This includes the themeChromiumAndroid.css file from the Chromium-Android port
as well as some addidtional changes they had to html.css. I believe those
changes were made before themeChromiumAndroid was created, but it's now the better place for this CSS.

  • WebCore.gyp/WebCore.gyp:
  • css/themeChromiumAndroid.css: Added.

(select[size][multiple]):
(input[type="date"], input[type="datetime"], input[type="datetime-local"], input[type="time"], input[type="month"]):

  • rendering/RenderThemeChromiumAndroid.cpp:

(WebCore::RenderThemeChromiumAndroid::extraDefaultStyleSheet):
(WebCore):

  • rendering/RenderThemeChromiumAndroid.h:

(RenderThemeChromiumAndroid):
(WebCore::RenderThemeChromiumAndroid::delegatesMenuListRendering):
(WebCore::RenderThemeChromiumAndroid::platformTapHighlightColor):

4:46 PM Changeset in webkit [107997] by msaboff@apple.com
  • 4 edits
    2 adds in trunk

ENH: Add ability to run subset of JavaScript layout tests with JSC
​https://bugs.webkit.org/show_bug.cgi?id=78764

Reviewed by Gavin Barraclough.

Tools:

New simple test drive shell script that runs a defined
list of javascript tests using jsc and the standalone-{pre,post}.js
wrappers.

  • Scripts/run-fast-jsc: Added.

LayoutTests:

  • fast/js/jsc-test-list: Added. List of tests that can be run

using jsc. Used by new Tools/Scripts/run-fast-jsc script.

  • fast/js/resources/standalone-post.js: ~pdated to match changes

in js-test-post.js

  • fast/js/resources/standalone-pre.js: Updated to match changes

in js-test-pre.js

4:28 PM Changeset in webkit [107996] by jamesr@google.com
  • 2 edits in trunk/LayoutTests

[chromium] Unreviewed. Mark fast/js/stack.html as an expected failure, we aren't interesting in converging on
this in v8.

  • platform/chromium/test_expectations.txt:
4:26 PM Changeset in webkit [107995] by beidson@apple.com
  • 6 edits in trunk/Source

<rdar://problem/10616280> and ​https://bugs.webkit.org/show_bug.cgi?id=78767
REGRESSION (r90471) - iAd Producer 2.0.1 produces blank pages

Reviewed by Sam Weinig.

Source/WebCore:

No new tests. (Subtle API change attached to a specific application)

  • loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::isLoadingInAPISense): Return true if the app needs the quirk
and there are outstanding subresource loads.

  • page/Settings.cpp:

(WebCore::Settings::Settings):

  • page/Settings.h:

(WebCore::Settings::setNeedsIsLoadingInAPISenseQuirk):
(WebCore::Settings::needsIsLoadingInAPISenseQuirk):
(Settings):

Source/WebKit/mac:

  • WebView/WebView.mm:

(-[WebView _needsIsLoadingInAPISenseQuirk]):
(-[WebView _preferencesChanged:]):

4:10 PM Changeset in webkit [107994] by haraken@chromium.org
  • 19 edits in trunk

Remove [ConvertScriptString] from FileReaderSync.idl
​https://bugs.webkit.org/show_bug.cgi?id=78335

Reviewed by Eric Seidel.

Source/WebCore:

The spec says that FileReadSync should throw NOT_FOUND_ERR
if a given blob is invalid: ​http://www.w3.org/TR/FileAPI/#FileReaderSync

By this fix, we can completely remove [ConvertScriptString] from WebKit.

Tests: fast/files/workers/worker-read-blob-sync.html

fast/files/workers/worker-read-file-sync.html

  • fileapi/FileReaderSync.cpp: Modified to throw NOT_FOUND_ERR if a blob is invalid.

(WebCore::FileReaderSync::readAsArrayBuffer):
(WebCore::FileReaderSync::readAsBinaryString):
(WebCore::FileReaderSync::readAsText):
(WebCore::FileReaderSync::readAsDataURL):

  • fileapi/FileReaderSync.idl:
  • bindings/scripts/CodeGeneratorJS.pm: Removed [ConvertScriptString]

since no one is using it.
(NativeToJSValue):

  • bindings/scripts/CodeGeneratorV8.pm: Ditto.

(NativeToJSValue):

  • bindings/scripts/test/TestObj.idl: Removed a test case for [ConvertScriptString].
  • bindings/scripts/test/CPP/WebDOMTestObj.cpp: Updated run-bindings-tests results.
  • bindings/scripts/test/CPP/WebDOMTestObj.h:
  • bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:

(webkit_dom_test_obj_get_property):
(webkit_dom_test_obj_class_init):

  • bindings/scripts/test/GObject/WebKitDOMTestObj.h:
  • bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore):

  • bindings/scripts/test/JS/JSTestObj.h:

(WebCore):

  • bindings/scripts/test/ObjC/DOMTestObj.h:
  • bindings/scripts/test/ObjC/DOMTestObj.mm:
  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore):

LayoutTests:

The spec says that FileReadSync should throw NOT_FOUND_ERR
if a given blob is invalid: ​http://www.w3.org/TR/FileAPI/#FileReaderSync
This patch adds test cases for FileReaderSync with an invalid blob
to check that NOT_FOUND_ERR is thrown.

  • fast/files/resources/read-common.js:

(_readBlobAsArrayBufferSync):
(_readBlobAsBinaryStringSync):
(_readBlobAsTextSync):
(_readBlobAsDataURLSync):

  • fast/files/workers/worker-read-blob-sync-expected.txt:
  • fast/files/workers/worker-read-file-sync-expected.txt:
4:10 PM Changeset in webkit [107993] by jsbell@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

IndexedDB: Chromium WebKit API support for IDBObjectStore.delete(IDBKeyRange)
​https://bugs.webkit.org/show_bug.cgi?id=78619

Add an overload to WebIDBObjectStore::deleteFunction(). First part of a two-sided patch.

Reviewed by Darin Fisher.

  • public/WebIDBObjectStore.h:

(WebKit::WebIDBObjectStore::deleteFunction):

4:04 PM Changeset in webkit [107992] by tonikitoo@webkit.org
  • 3 edits in trunk/Source/WebKit/blackberry

2012-02-16 Antonio Gomes <​agomes@rim.com>

[BlackBerry] Implemented a way to defer client navigation change client notifications
​https://bugs.webkit.org/show_bug.cgi?id=78848

Reviewed by Rob Buis.

Currently we postpone touch_down till touch_up if user touches
the screen and an input field has the WebKit focus. This is done
so we can scroll the page without hidding the vkb needlessly.

However, it breaks the conversion of touch to mouse events
if an input field has the focus in the following scenario:
an <input type=text> is focused and an user grab and-drag
a <input type=range> knob/slide. It does not work until the
user unfocuses the currently focused edit field.

Patch introduces a way to unfocus a currently focused input field,
without requesting the client to show or hide the virtual keyboard
right way. Instead it gets a delayed notification of the vkb mode requested
at either touch_released/mouse_up or touch_cancel time.

For now, due to content side issues with major web sites,
only delay navigation mode notification changes if we are not dealing with
input modes.

  • WebKitSupport/InputHandler.cpp: (BlackBerry::WebKit::InputHandler::InputHandler): (BlackBerry::WebKit::InputHandler::nodeFocused): (BlackBerry::WebKit::InputHandler::setElementFocused): (BlackBerry::WebKit::InputHandler::setNavigationMode): (WebKit): (BlackBerry::WebKit::InputHandler::setDelayClientNotificationOfNavigationModeChange): (BlackBerry::WebKit::InputHandler::processPendingClientNavigationModeChangeNotification): (BlackBerry::WebKit::InputHandler::notifyClientOfNavigationModeChange): (BlackBerry::WebKit::InputHandler::willOpenPopupForNode): (BlackBerry::WebKit::InputHandler::setPopupListIndexes): (BlackBerry::WebKit::InputHandler::spannableTextInRange): (BlackBerry::WebKit::InputHandler::removeComposedText): (BlackBerry::WebKit::InputHandler::firstSpanInString): (BlackBerry::WebKit::InputHandler::setText): (BlackBerry::WebKit::InputHandler::setRelativeCursorPosition):
  • WebKitSupport/InputHandler.h: (InputHandler):
4:04 PM Changeset in webkit [107991] by tonikitoo@webkit.org
  • 3 edits in trunk/Source/WebKit/blackberry

2012-02-16 Antonio Gomes <​agomes@rim.com>

Crash @WebPagePrivate::enqueueRenderingOfClippedContentOfScrollableNodeAfterInRegionScrolling MKS_2986818
​https://bugs.webkit.org/show_bug.cgi?id=78845

Reviewed by Rob Buis.

We were trying to operate on a cached Node when its page/frame/document
were gone to PageCache already. To avoid such problems, lets clean up
any document data we have cached when the Frame goes into the cache.

  • WebCoreSupport/FrameLoaderClientBlackBerry.cpp: (WebCore::FrameLoaderClientBlackBerry::didSaveToPageCache): (WebCore):
  • WebCoreSupport/FrameLoaderClientBlackBerry.h: (FrameLoaderClientBlackBerry):
4:04 PM Changeset in webkit [107990] by tonikitoo@webkit.org
  • 1 edit
    2 adds in trunk/Source/WebKit/blackberry

2012-02-16 Antonio Gomes <​agomes@rim.com>

[BlackBerry] Upstream touch handling related classes (Part III: InRegionScrollableArea)
​https://bugs.webkit.org/show_bug.cgi?id=78509

Reviewed by Adam Treat and Rob Buis.

InRegionScrollableArea specializes the BlackBerry specific ScrollViewBase,
working as a read-only wrapper object for a scrollable areas in the page.
It is used in our client side to control in-region scrolling (scrollable boxes,
inner frames, etc).

Initial upstream.

  • WebKitSupport/InRegionScrollableArea.cpp: Added. (WebKit): (BlackBerry::WebKit::InRegionScrollableArea::InRegionScrollableArea): (BlackBerry::WebKit::InRegionScrollableArea::calculateMinimumScrollPosition): (BlackBerry::WebKit::InRegionScrollableArea::calculateMaximumScrollPosition): (BlackBerry::WebKit::InRegionScrollableArea::layer): (BlackBerry):
  • WebKitSupport/InRegionScrollableArea.h: Added. (WebCore): (WebKit): (InRegionScrollableArea):
3:59 PM Changeset in webkit [107989] by abarth@webkit.org
  • 2 edits in trunk/Source/WebKit/gtk

Attempt to fix the GTK build.

  • WebCoreSupport/GeolocationClientGtk.cpp:

(WebKit::GeolocationClient::requestPermission):
(WebKit::GeolocationClient::cancelPermissionRequest):

3:51 PM Changeset in webkit [107988] by commit-queue@webkit.org
  • 7 edits
    3 adds in trunk

[chromium] Clipping/Transforms applied in wrong order in opaque paint tracking
​https://bugs.webkit.org/show_bug.cgi?id=78775

Patch by Dana Jansens <​danakj@chromium.org> on 2012-02-16
Reviewed by Stephen White.

Source/WebCore:

The clip was being applied in device coordinates, before transforming the painted
rect into device coordinates. This made any translations get doubly represented,
and gave incorrect paint tracking results.

Test: compositing/culling/unscrolled-within-boxshadow.html

Unit test: PlatformContextSkiaTest.cpp

  • platform/graphics/skia/OpaqueRegionSkia.cpp:

(WebCore::OpaqueRegionSkia::didDraw):

Source/WebKit/chromium:

  • tests/PlatformContextSkiaTest.cpp:

(WebCore::TEST):

LayoutTests:

  • compositing/culling/unscrolled-within-boxshadow-expected.png: Added.
  • compositing/culling/unscrolled-within-boxshadow-expected.txt: Added.
  • compositing/culling/unscrolled-within-boxshadow.html: Added.
  • compositing/overflow/clip-content-under-overflow-controls-expected.png:
  • compositing/scrollbar-painting-expected.png:
3:35 PM Changeset in webkit [107987] by inferno@chromium.org
  • 3 edits
    2 adds in trunk

Crash with tables in multi-column layout.
​https://bugs.webkit.org/show_bug.cgi?id=78415

Reviewed by Julien Chaffraix.

Source/WebCore:

Multi-column code creates anonymous column blocks directly
under RenderTable, thereby violating table layout assumption.
E.g. Captions in this testcase gets reparented to these anonymous
column blocks and when they go away, they are not able to clear
themselves from table's m_captions list (since RenderTable::removeChild
is not called).

Test: fast/multicol/span/table-multi-column-crash.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::containingColumnsBlock):

LayoutTests:

  • fast/multicol/span/table-multi-column-crash-expected.txt: Added.
  • fast/multicol/span/table-multi-column-crash.html: Added.
3:32 PM Changeset in webkit [107986] by commit-queue@webkit.org
  • 4 edits
    2 adds in trunk/Source/WebCore

[GTK] File system api build is broken
​https://bugs.webkit.org/show_bug.cgi?id=78479

Patch by ChangSeok Oh <ChangSeok Oh> on 2012-02-16
Reviewed by Philippe Normand.

This patch is a small step to support FileSystem API for GTK port.
As I know, bug58443 also dealt with it, but it looks like the submitted patch
needs to be updated. To do that, I think I need to discuss with the original author.
So, I hope to just fix build break issue in this bug.

No new tests. Implementing the feature is not done yet.

  • GNUmakefile.list.am: Added some missing files.
  • bindings/js/JSDirectoryEntryCustom.cpp: Added Error.h to use its API.
  • platform/AsyncFileSystem.cpp:

(WebCore):
(WebCore::AsyncFileSystem::create): The arguments don't match the declaration in AsyncFileSystem.h.

  • platform/gtk/AsyncFileSystemGtk.cpp: Added.

(WebCore):
(WebCore::AsyncFileSystem::isAvailable):
(WebCore::AsyncFileSystem::isValidType):
(WebCore::AsyncFileSystem::create):
(WebCore::AsyncFileSystem::openFileSystem):
(WebCore::AsyncFileSystem::crackFileSystemURL):
(WebCore::AsyncFileSystemGtk::AsyncFileSystemGtk):
(WebCore::AsyncFileSystemGtk::~AsyncFileSystemGtk):
(WebCore::AsyncFileSystemGtk::toURL):
(WebCore::AsyncFileSystemGtk::move):
(WebCore::AsyncFileSystemGtk::copy):
(WebCore::AsyncFileSystemGtk::remove):
(WebCore::AsyncFileSystemGtk::removeRecursively):
(WebCore::AsyncFileSystemGtk::readMetadata):
(WebCore::AsyncFileSystemGtk::createFile):
(WebCore::AsyncFileSystemGtk::createDirectory):
(WebCore::AsyncFileSystemGtk::fileExists):
(WebCore::AsyncFileSystemGtk::directoryExists):
(WebCore::AsyncFileSystemGtk::readDirectory):
(WebCore::AsyncFileSystemGtk::createWriter):

  • platform/gtk/AsyncFileSystemGtk.h: Added.

(WebCore):
(AsyncFileSystemGtk):

3:30 PM Changeset in webkit [107985] by enne@google.com
  • 2 edits in trunk/Source/WebCore

Handle dirty descendant visibility status in RenderLayer::updateLayerPositionsAfterScroll
​https://bugs.webkit.org/show_bug.cgi?id=78286

Reviewed by Julien Chaffraix.

This is an unfortunate bandaid over a corner case where sometimes the
visible descendant status dirty flag is true when this function is
called from FrameView::repaintFixedElementsAfterScrolling. As it
should be cheap to refresh this flag when dirty in most cases (as it
early outs after finding any visible descendant), just lazily update
the dirty flag here to ensure correctness.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::updateLayerPositionsAfterScroll):

3:25 PM Changeset in webkit [107984] by jamesr@google.com
  • 3 edits
    2 moves in trunk/LayoutTests

[chromium] Update table pixel expectations. Unreviewed.

  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug27038-1-expected.png: Renamed from LayoutTests/platform/chromium-mac/tables/mozilla/bugs/bug27038-1-expected.png.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug27038-2-expected.png: Renamed from LayoutTests/platform/chromium-mac/tables/mozilla/bugs/bug27038-2-expected.png.
  • platform/chromium-win/tables/mozilla/bugs/bug27038-1-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug27038-2-expected.png:
2:54 PM Changeset in webkit [107983] by dcheng@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] Add WEBKIT_EXPORT to new WebDragData methods.
​https://bugs.webkit.org/show_bug.cgi?id=78843

Reviewed by Tony Chang.

  • public/platform/WebDragData.h:

(WebDragData):

2:50 PM Changeset in webkit [107982] by abarth@webkit.org
  • 4 edits in trunk/Source/WebCore

Chrome::*Geolocation* are just useless pass-throughs to ChromeClient and should be removed
​https://bugs.webkit.org/show_bug.cgi?id=78844

Reviewed by Eric Seidel.

These function serve no useful purpose and should be removed.

  • page/Chrome.cpp:

(WebCore):

  • page/Chrome.h:

(Chrome):

  • page/Geolocation.cpp:

(WebCore::Geolocation::reset):
(WebCore::Geolocation::requestPermission):

2:45 PM Changeset in webkit [107981] by inferno@chromium.org
  • 1 edit
    1 add in trunk/LayoutTests

Add a missing image for my commit r107965.

  • fast/multicol/span/clone-flexbox-expected.png: Added.
2:38 PM Changeset in webkit [107980] by oliver@apple.com
  • 13 edits
    3 adds in trunk

Implement Error.stack
​https://bugs.webkit.org/show_bug.cgi?id=66994

Reviewed by Gavin Barraclough.

Source/JavaScriptCore:

Implement support for stack traces on exception objects. This is a rewrite
of the core portion of the last stack walking logic, but the mechanical work
of adding the information to an exception comes from the original work by
Juan Carlos Montemayor Elosua.

  • interpreter/Interpreter.cpp:

(JSC::getCallerInfo):
(JSC):
(JSC::getSourceURLFromCallFrame):
(JSC::getStackFrameCodeType):
(JSC::Interpreter::getStackTrace):
(JSC::Interpreter::throwException):
(JSC::Interpreter::privateExecute):

  • interpreter/Interpreter.h:

(JSC):
(StackFrame):
(JSC::StackFrame::toString):
(Interpreter):

  • jsc.cpp:

(GlobalObject::finishCreation):
(functionJSCStack):

  • parser/Nodes.h:

(JSC::FunctionBodyNode::setInferredName):

  • parser/Parser.h:

(JSC::::parse):

  • runtime/CommonIdentifiers.h:
  • runtime/Error.cpp:

(JSC::addErrorInfo):

  • runtime/Error.h:

(JSC):

LayoutTests:

Add testcases for producing a stack trace on exception objects.

  • fast/js/exception-properties-expected.txt:
  • fast/js/script-tests/exception-properties.js:
  • fast/js/script-tests/stack-trace.js: Added.

(printStack):
(hostThrower):
(callbacker):
(outer):
(inner):
(evaler):
(normalOuter):
(normalInner):
(scripterInner):
(scripterOuter):
(selfRecursive1):
(selfRecursive2):
(selfRecursive3):
(throwError):
(object.get getter1.o.valueOf):
(object.get getter1):
(object.get getter2):
(object.get getter3.o2.valueOf):
(object.get getter3):
(object.nonInlineable.callCount):
(object.nonInlineable):
(object.inlineable):
(yetAnotherInlinedCall):
(makeInlinableCall):
(.try.g):
(h):
(mapTest):
(mapTestDriver):
(dfgFunction):
(try.f):

  • fast/js/stack-trace-expected.txt: Added.
  • fast/js/stack-trace.html: Added.
2:22 PM Changeset in webkit [107979] by leviw@chromium.org
  • 1 edit in branches/subpixellayout/Source/WebCore/platform/FractionalLayoutUnit.h

Changing the isInBounds asserts to use less than equals, instead of less than.

2:03 PM Changeset in webkit [107978] by tonikitoo@webkit.org
  • 1 edit
    2 adds in trunk/Source/WebKit/blackberry

2012-02-16 Antonio Gomes <​agomes@rim.com>

[BlackBerry] Upstream touch handling related classes (part II: FatFingers)
​https://bugs.webkit.org/show_bug.cgi?id=78509

Reviewed by Rob Buis.

FatFingers is the class responsible to the whole touch
accuracy of the BlackBerry port. Initial upstream.

  • WebKitSupport/FatFingers.cpp: Added. (WebKit): (BlackBerry::WebKit::FatFingers::fingerRectForPoint): (BlackBerry::WebKit::hasMousePressListener): (BlackBerry::WebKit::FatFingers::isElementClickable): (BlackBerry::WebKit::isFieldWithText): (BlackBerry::WebKit::distanceBetweenPoints): (BlackBerry::WebKit::compareDistanceBetweenPoints): (BlackBerry::WebKit::isValidFrameOwner): (BlackBerry::WebKit::FatFingers::FatFingers): (BlackBerry::WebKit::FatFingers::~FatFingers): (BlackBerry::WebKit::FatFingers::findBestPoint): (BlackBerry::WebKit::FatFingers::checkFingerIntersection): (BlackBerry::WebKit::FatFingers::findIntersectingRegions): (BlackBerry::WebKit::FatFingers::checkForClickableElement): (BlackBerry::WebKit::FatFingers::checkForText): (BlackBerry::WebKit::FatFingers::getPaddings): (BlackBerry::WebKit::FatFingers::nodesFromRect): (BlackBerry::WebKit::FatFingers::getRelevantInfoFromPoint): (BlackBerry::WebKit::FatFingers::setSuccessfulFatFingersResult):
  • WebKitSupport/FatFingers.h: Added. (WebCore): (WebKit): (FatFingersResult): (BlackBerry::WebKit::FatFingersResult::FatFingersResult): (BlackBerry::WebKit::FatFingersResult::reset): (BlackBerry::WebKit::FatFingersResult::originPosition): (BlackBerry::WebKit::FatFingersResult::adjustedPosition): (BlackBerry::WebKit::FatFingersResult::positionWasAdjusted): (BlackBerry::WebKit::FatFingersResult::isTextInput): (BlackBerry::WebKit::FatFingersResult::isValid): (BlackBerry::WebKit::FatFingersResult::validNode): (BlackBerry::WebKit::FatFingersResult::nodeAsElementIfApplicable): (FatFingers):
1:32 PM Changeset in webkit [107977] by jamesr@google.com
  • 2 edits
    3 adds in trunk/LayoutTests

[chromium] Unreviewed, update baselines for region repaint tests due to skia off-by-one.

  • platform/chromium-mac-snowleopard/fast/repaint/region-painting-invalidation-expected.png: Added.
  • platform/chromium-win/fast/repaint/region-painting-invalidation-expected.png: Added.
  • platform/chromium-win/fast/repaint/region-painting-invalidation-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
1:24 PM Changeset in webkit [107976] by tony@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Unreviewed, these regions tests pass after r107961.

  • platform/chromium/test_expectations.txt:
1:20 PM Changeset in webkit [107975] by jamesr@google.com
  • 50 edits
    5 copies
    10 moves
    1 add
    6 deletes in trunk/LayoutTests

[chromium] Unreviewed rebaselines and expectation updates.

  • platform/chromium-linux/fast/html/details-add-summary-1-and-click-expected.png:
  • platform/chromium-linux/fast/html/details-add-summary-10-and-click-expected.png:
  • platform/chromium-linux/fast/html/details-add-summary-2-and-click-expected.png:
  • platform/chromium-linux/fast/html/details-add-summary-3-and-click-expected.png:
  • platform/chromium-linux/fast/html/details-add-summary-4-and-click-expected.png:
  • platform/chromium-linux/fast/html/details-add-summary-5-and-click-expected.png:
  • platform/chromium-linux/fast/html/details-add-summary-6-and-click-expected.png:
  • platform/chromium-linux/fast/html/details-add-summary-7-and-click-expected.png:
  • platform/chromium-linux/fast/html/details-add-summary-8-and-click-expected.png:
  • platform/chromium-linux/fast/html/details-add-summary-9-and-click-expected.png:
  • platform/chromium-linux/fast/html/details-remove-summary-1-and-click-expected.png:
  • platform/chromium-linux/fast/html/details-remove-summary-2-and-click-expected.png:
  • platform/chromium-linux/fast/html/details-remove-summary-3-and-click-expected.png:
  • platform/chromium-linux/fast/html/details-remove-summary-4-and-click-expected.png:
  • platform/chromium-linux/fast/html/details-remove-summary-5-and-click-expected.png:
  • platform/chromium-linux/fast/html/details-remove-summary-6-and-click-expected.png:
  • platform/chromium-mac-leopard/fast/html/details-add-summary-1-and-click-expected.png:
  • platform/chromium-mac-leopard/fast/html/details-add-summary-10-and-click-expected.png:
  • platform/chromium-mac-leopard/fast/html/details-add-summary-2-and-click-expected.png:
  • platform/chromium-mac-leopard/fast/html/details-add-summary-3-and-click-expected.png:
  • platform/chromium-mac-leopard/fast/html/details-add-summary-4-and-click-expected.png:
  • platform/chromium-mac-leopard/fast/html/details-add-summary-5-and-click-expected.png:
  • platform/chromium-mac-leopard/fast/html/details-add-summary-6-and-click-expected.png:
  • platform/chromium-mac-leopard/fast/html/details-add-summary-7-and-click-expected.png:
  • platform/chromium-mac-leopard/fast/html/details-add-summary-8-and-click-expected.png:
  • platform/chromium-mac-leopard/fast/html/details-add-summary-9-and-click-expected.png:
  • platform/chromium-mac-leopard/fast/html/details-remove-summary-1-and-click-expected.png:
  • platform/chromium-mac-leopard/fast/html/details-remove-summary-2-and-click-expected.png:
  • platform/chromium-mac-leopard/fast/html/details-remove-summary-3-and-click-expected.png:
  • platform/chromium-mac-leopard/fast/html/details-remove-summary-4-and-click-expected.png:
  • platform/chromium-mac-leopard/fast/html/details-remove-summary-5-and-click-expected.png:
  • platform/chromium-mac-leopard/fast/html/details-remove-summary-6-and-click-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-add-summary-1-and-click-expected.png: Copied from LayoutTests/platform/chromium-mac-leopard/fast/html/details-add-summary-1-and-click-expected.png.
  • platform/chromium-mac-snowleopard/fast/html/details-add-summary-10-and-click-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-add-summary-10-and-click-expected.png.
  • platform/chromium-mac-snowleopard/fast/html/details-add-summary-2-and-click-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-add-summary-2-and-click-expected.png.
  • platform/chromium-mac-snowleopard/fast/html/details-add-summary-3-and-click-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-add-summary-8-and-click-expected.png.
  • platform/chromium-mac-snowleopard/fast/html/details-add-summary-4-and-click-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/html/details-add-summary-5-and-click-expected.png: Copied from LayoutTests/platform/chromium-mac-leopard/fast/html/details-add-summary-8-and-click-expected.png.
  • platform/chromium-mac-snowleopard/fast/html/details-add-summary-6-and-click-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-add-summary-6-and-click-expected.png.
  • platform/chromium-mac-snowleopard/fast/html/details-add-summary-7-and-click-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-add-summary-7-and-click-expected.png.
  • platform/chromium-mac-snowleopard/fast/html/details-add-summary-8-and-click-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-add-summary-9-and-click-expected.png.
  • platform/chromium-mac-snowleopard/fast/html/details-add-summary-9-and-click-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/html/details-remove-summary-1-and-click-expected.png.
  • platform/chromium-mac-snowleopard/fast/html/details-remove-summary-1-and-click-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-remove-summary-1-and-click-expected.png.
  • platform/chromium-mac-snowleopard/fast/html/details-remove-summary-2-and-click-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-remove-summary-2-and-click-expected.png.
  • platform/chromium-mac-snowleopard/fast/html/details-remove-summary-3-and-click-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/html/details-remove-summary-3-and-click-expected.png.
  • platform/chromium-mac-snowleopard/fast/html/details-remove-summary-4-and-click-expected.png: Copied from LayoutTests/platform/chromium-mac-leopard/fast/html/details-add-summary-9-and-click-expected.png.
  • platform/chromium-mac-snowleopard/fast/html/details-remove-summary-5-and-click-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-remove-summary-4-and-click-expected.png.
  • platform/chromium-mac-snowleopard/fast/html/details-remove-summary-6-and-click-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-remove-summary-3-and-click-expected.png.
  • platform/chromium-mac/fast/html/details-add-summary-1-and-click-expected.png: Removed.
  • platform/chromium-mac/fast/html/details-add-summary-3-and-click-expected.png: Removed.
  • platform/chromium-mac/fast/html/details-add-summary-4-and-click-expected.png: Removed.
  • platform/chromium-mac/fast/html/details-add-summary-5-and-click-expected.png: Removed.
  • platform/chromium-mac/fast/html/details-remove-summary-5-and-click-expected.png: Removed.
  • platform/chromium-mac/fast/html/details-remove-summary-6-and-click-expected.png: Removed.
  • platform/chromium-win/fast/html/details-add-summary-1-and-click-expected.png:
  • platform/chromium-win/fast/html/details-add-summary-10-and-click-expected.png:
  • platform/chromium-win/fast/html/details-add-summary-2-and-click-expected.png:
  • platform/chromium-win/fast/html/details-add-summary-3-and-click-expected.png:
  • platform/chromium-win/fast/html/details-add-summary-4-and-click-expected.png:
  • platform/chromium-win/fast/html/details-add-summary-5-and-click-expected.png:
  • platform/chromium-win/fast/html/details-add-summary-6-and-click-expected.png:
  • platform/chromium-win/fast/html/details-add-summary-7-and-click-expected.png:
  • platform/chromium-win/fast/html/details-add-summary-8-and-click-expected.png:
  • platform/chromium-win/fast/html/details-add-summary-9-and-click-expected.png:
  • platform/chromium-win/fast/html/details-remove-summary-1-and-click-expected.png:
  • platform/chromium-win/fast/html/details-remove-summary-2-and-click-expected.png:
  • platform/chromium-win/fast/html/details-remove-summary-3-and-click-expected.png:
  • platform/chromium-win/fast/html/details-remove-summary-4-and-click-expected.png:
  • platform/chromium-win/fast/html/details-remove-summary-5-and-click-expected.png:
  • platform/chromium-win/fast/html/details-remove-summary-6-and-click-expected.png:
  • platform/chromium/test_expectations.txt:
1:06 PM Changeset in webkit [107974] by Philippe Normand
  • 4 edits in trunk/LayoutTests

Unreviewed, GTK rebaseline after r107952.

  • platform/gtk/fast/dom/Window/window-properties-expected.txt:
  • platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/gtk/fast/js/global-constructors-expected.txt:
12:56 PM Changeset in webkit [107973] by sergio@webkit.org
  • 6 edits in trunk/Source

[soup] Move important SoupSession feature initialization to WebCore
​https://bugs.webkit.org/show_bug.cgi?id=68602

Reviewed by Martin Robinson.

Source/WebCore:

Moved content sniffer and decoder initialization from WebKit to
WebCore because network stuff will not work as expected without
them. Added also out-of-the-box proxy support to WebCore.

No new tests required as we're just moving stuff from WebKit to
WebCore.

  • platform/network/soup/ResourceHandleSoup.cpp:

(WebCore::ResourceHandle::defaultSession):

Source/WebKit/gtk:

Moved content sniffer and decoder initialization from WebKit to
WebCore because network stuff will not work as expected without
them.

No new tests required as we're just moving stuff from WebKit to
WebCore.

  • webkit/webkitglobals.cpp:

(webkitInit):

Source/WebKit2:

Moved content sniffer and decoder initialization from the
WebProcess to WebCore because network stuff will not work as
expected without them.

No new tests required as we're just moving stuff from the
WebProcess to WebCore.

  • WebProcess/gtk/WebProcessMainGtk.cpp:

(WebKit::WebProcessMainGtk):

12:55 PM Changeset in webkit [107972] by tonikitoo@webkit.org
  • 3 adds in trunk/Source/WebKit/blackberry

2012-02-16 Antonio Gomes <​agomes@rim.com>

[BlackBerry] Upstream touch handling related classes
​https://bugs.webkit.org/show_bug.cgi?id=78509

Reviewed by Rob Buis.

Initial upstream of the Blackberry specific single touch event
handler class.

  • blackberry/WebKitSupport/TouchEventHandler.cpp: Added. (WebKit): (BlackBerry::WebKit::hasMouseMoveListener): (BlackBerry::WebKit::hasTouchListener): (BlackBerry::WebKit::elementExpectsMouseEvents): (BlackBerry::WebKit::shouldConvertTouchToMouse): (BlackBerry::WebKit::TouchEventHandler::TouchEventHandler): (BlackBerry::WebKit::TouchEventHandler::~TouchEventHandler): (BlackBerry::WebKit::TouchEventHandler::shouldSuppressMouseDownOnTouchDown): (BlackBerry::WebKit::TouchEventHandler::touchEventCancel): (BlackBerry::WebKit::TouchEventHandler::touchHoldEvent): (BlackBerry::WebKit::TouchEventHandler::handleTouchPoint): (BlackBerry::WebKit::TouchEventHandler::spellCheck): (BlackBerry::WebKit::TouchEventHandler::handleFatFingerPressed): (BlackBerry::WebKit::elementForTapHighlight): (BlackBerry::WebKit::TouchEventHandler::drawTapHighlight):
  • blackberry/WebKitSupport/TouchEventHandler.h: Added. (WebCore): (WebKit): (TouchEventHandler): (BlackBerry::WebKit::TouchEventHandler::lastFatFingersResult): (BlackBerry::WebKit::TouchEventHandler::resetLastFatFingersResult):
12:50 PM Changeset in webkit [107971] by jchaffraix@webkit.org
  • 13 edits
    2 adds in trunk

thead in table without tbody causes table height doubling
​https://bugs.webkit.org/show_bug.cgi?id=37244

Reviewed by Ojan Vafai.

Source/WebCore:

Tests: fast/table/double-height-table-no-tbody-expected.html

fast/table/double-height-table-no-tbody.html

The bug is caused by the layout code would wrongly assuming that a
table without a <tbody> is an empty table. We would set the logical
height to the style's logical height wrongly before inflating the
logical height to account for the section(s). This would cause us
to increase past our needed size thus the bug.

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::layout):
A table is empty if it does not have any top section, not just a <tbody>.
The test uncovered an issue with height distribution in layoutRows where we
would distribute the extra height to the first <tbody> not section.

LayoutTests:

  • fast/table/double-height-table-no-tbody-expected.html: Added.
  • fast/table/double-height-table-no-tbody.html: Added.

Test that we properly lay out tables with only a <thead> or <tfoot>
exactly like a table with only a <tbody>.

  • platform/chromium-linux/tables/mozilla/bugs/bug27038-1-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug27038-2-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug27038-1-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug27038-2-expected.txt:

This is neither a progression nor a regression. We are not doing the right
thing as we don't distribute the extra logical height evenly over our sections.
Now we give the extra height to the <thead> (first section) instead of the <tbody>.

  • platform/chromium/test_expectations.txt:
  • platform/efl/test_expectations.txt:
  • platform/gtk/test_expectations.txt:
  • platform/mac/test_expectations.txt:
  • platform/qt/test_expectations.txt:
  • platform/win/test_expectations.txt:

Marked the previous tests as needing a new baseline.

12:40 PM Changeset in webkit [107970] by robert@webkit.org
  • 4 edits
    4 adds in trunk

CSS 2.1 failure: fixed-table-layout-013 and fixed-table-layout-015 fail
​https://bugs.webkit.org/show_bug.cgi?id=78027

Reviewed by Julien Chaffraix.

Source/WebCore:

Both of these test the (slightly implicit) rule that width set on column-groups cannot
affect the width of columns in a fixed layout table: ​http://www.w3.org/TR/CSS21/tables.html#fixed-table-layout
FF, Opera and IE all pass these two tests.

Tests: css2.1/20110323/fixed-table-layout-013.htm

css2.1/20110323/fixed-table-layout-015.htm

  • rendering/FixedTableLayout.cpp:

(WebCore::nextCol): A helper function for finding the next column along.
(WebCore::FixedTableLayout::calcWidthArray): Ignore width specified by column groups.

  • rendering/RenderTableCol.h:

(WebCore::RenderTableCol::isTableColGroup): Convenience function for identifying column groups.

LayoutTests:

  • css2.1/20110323/fixed-table-layout-013-expected.html: Added.
  • css2.1/20110323/fixed-table-layout-013.htm: Added.
  • css2.1/20110323/fixed-table-layout-015-expected.html: Added.
  • css2.1/20110323/fixed-table-layout-015.htm: Added.
12:32 PM Changeset in webkit [107969] by tony@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Unreviewed, tests passing after the fix in r107874.

  • platform/chromium/test_expectations.txt:
12:32 PM Changeset in webkit [107968] by Philippe Normand
  • 6 edits in trunk/Source

Unreviewed, rolling out r107941.
​http://trac.webkit.org/changeset/107941
​https://bugs.webkit.org/show_bug.cgi?id=68602

Broke 23 http tests on GTK

Source/WebCore:

  • platform/network/soup/ResourceHandleSoup.cpp:

(WebCore::ResourceHandle::defaultSession):

Source/WebKit/gtk:

  • webkit/webkitglobals.cpp:

(webkitInit):

Source/WebKit2:

  • WebProcess/gtk/WebProcessMainGtk.cpp:

(WebKit::WebProcessMainGtk):

12:30 PM Changeset in webkit [107967] by tsepez@chromium.org
  • 3 edits
    2 adds in trunk

XSS Auditor bypass with U+2028/2029
​https://bugs.webkit.org/show_bug.cgi?id=78732

Reviewed by Adam Barth.

Source/WebCore:

Test: http/tests/security/xssAuditor/script-tag-with-trailing-comment-U2028.html

  • html/parser/XSSAuditor.cpp:

(WebCore::isJSNewline):
(WebCore::XSSAuditor::snippetForJavaScript):

LayoutTests:

  • http/tests/security/xssAuditor/script-tag-with-trailing-comment-U2028-expected.txt: Added.
  • http/tests/security/xssAuditor/script-tag-with-trailing-comment-U2028.html: Added.
12:19 PM Changeset in webkit [107966] by mrowe@apple.com
  • 2 edits in trunk/Source/WebCore

NPN_GetValueForURL / NPNURLVProxy returns DIRECT when proxy configured via PAC
<​http://webkit.org/b/78766> / <rdar://problem/10729283>

Reviewed by Anders Carlsson.

  • platform/network/cf/ProxyServerCFNet.cpp:

(WebCore::proxyAutoConfigurationResultCallback): Stop the runloop, and then process
the results that we received.
(WebCore::processProxyServers): Processing of array of proxy configuration information
moved from addProxyServersForURL. Handling of proxy auto-configuration URLs is now handled
by calling CFNetworkExecuteProxyAutoConfigurationURL and waiting synchronously on the result
callback. Doing this synchronously is not great, but it's the best we can do without a lot
of restructuring of the code that calls this. We arbitrarily time out the execution after five
seconds to avoid permanently hanging.
(WebCore::addProxyServersForURL): Call in to our helper function.

12:16 PM Changeset in webkit [107965] by inferno@chromium.org
  • 3 edits
    2 adds in trunk

Fix clone() function to handle descendant classes of RenderBlock.
​https://bugs.webkit.org/show_bug.cgi?id=78273

Reviewed by Eric Seidel.

Source/WebCore:

Test: fast/multicol/span/clone-flexbox-crash.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::clone):

LayoutTests:

You should see two RenderFlexibleBox in the rendertree, indicating that
cloning was correct.

  • fast/multicol/span/clone-flexbox-expected.txt: Added.
  • fast/multicol/span/clone-flexbox.html: Added.
12:14 PM Changeset in webkit [107964] by alexis.menard@openbossa.org
  • 1 edit
    1 add in trunk/PerformanceTests

Add a perf test for the CSS parser.
​https://bugs.webkit.org/show_bug.cgi?id=78114

Reviewed by Ryosuke Niwa.

Add a perf test for the CSS parser. It load a big CSS chunk
which contains some snippets of the YUI library from Yahoo!.

  • Parser/css-parser-yui.html: Added.
12:00 PM Changeset in webkit [107963] by tsepez@chromium.org
  • 1 edit in trunk/Tools/Scripts/webkitpy/common/config/committers.py

Add to committers.py

11:57 AM Changeset in webkit [107962] by jamesr@google.com
  • 3 edits in trunk/LayoutTests

[chromium] Unreviewed gardening

  • platform/chromium/fast/js/property-getters-and-setters-expected.txt:
  • platform/chromium/test_expectations.txt:
11:39 AM Changeset in webkit [107961] by commit-queue@webkit.org
  • 7 edits in trunk

[CSSRegions]overflowRegion tests are flaky
​https://bugs.webkit.org/show_bug.cgi?id=78761

Patch by Raul Hudea <​rhudea@adobe.com> on 2012-02-16
Reviewed by Tony Chang.

Source/WebCore:

The overflowRegion tests were updated.

  • dom/Element.cpp:

(WebCore::Element::webkitRegionOverflow):

LayoutTests:

  • fast/regions/element-region-overflow-state-expected.txt:
  • fast/regions/element-region-overflow-state-vertical-rl-expected.txt:
  • fast/regions/element-region-overflow-state-vertical-rl.html:
  • fast/regions/element-region-overflow-state.html:
11:36 AM Changeset in webkit [107960] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit/chromium

[chromium] Add method to WebPluginContainer to check if a rectangle is topmost
​https://bugs.webkit.org/show_bug.cgi?id=78166

Patch by Viet-Trung Luu <​viettrungluu@chromium.org> on 2012-02-16
Reviewed by Darin Fisher.

  • public/WebPluginContainer.h:

(WebPluginContainer):

  • src/WebPluginContainerImpl.cpp:
  • src/WebPluginContainerImpl.h:

(WebPluginContainerImpl):

11:15 AM Changeset in webkit [107959] by commit-queue@webkit.org
  • 4 edits
    3 adds in trunk

[CSS Regions] Repaint issues when changing innerHTML of content
​https://bugs.webkit.org/show_bug.cgi?id=78787

Patch by Raul Hudea <​rhudea@adobe.com> on 2012-02-16
Reviewed by David Hyatt.

Source/WebCore:

The calculation of the clipping rectangle is based on the repaint rectangle,
so it needs to be clipped to the current region, because it might spread over multiple ones.

Test: fast/repaint/region-painting-invalidation.html

  • rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::repaintRectangleInRegions):

LayoutTests:

  • fast/repaint/region-painting-invalidation.html: Added.
  • platform/chromium/test_expectations.txt: Needs baseline
  • platform/mac/fast/repaint/region-painting-invalidation-expected.png: Added.
  • platform/mac/fast/repaint/region-painting-invalidation-expected.txt: Added.
11:12 AM Changeset in webkit [107958] by jamesr@google.com
  • 2 edits
    8 adds in trunk/LayoutTests

[chromium] Unreviewed chromium gardening

  • platform/chromium-linux/svg/text/tspan-dynamic-positioning-expected.png: Added.
  • platform/chromium-mac-leopard/compositing/plugins/composited-plugin-expected.png: Added.
  • platform/chromium-mac-leopard/compositing/plugins/composited-plugin-expected.txt: Added.
  • platform/chromium-mac-leopard/svg/text/tspan-dynamic-positioning-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/text/tspan-dynamic-positioning-expected.png: Added.
  • platform/chromium-win/svg/text/tspan-dynamic-positioning-expected.png: Added.
  • platform/chromium-win/svg/text/tspan-dynamic-positioning-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
11:08 AM Changeset in webkit [107957] by barraclough@apple.com
  • 2 edits in trunk

Numerous trivial bugs in Object.defineProperty
​https://bugs.webkit.org/show_bug.cgi?id=78777

Reviewed by Sam Weinig.

There are a handful of really trivial bugs, related to Object.defineProperty:

  • Redefining an accessor with different attributes changes the attributes, but not the get/set functions!
  • Calling an undefined setter should only throw in strict mode.
  • When redefining an accessor to a data decriptor, if writable is not specified we should default to false.
  • Any attempt to redefine a non-configurable property of an array as configurable should be rejected.
  • Object.defineProperties should call toObject on 'Properties' argument, rather than throwing if it is not an object.
  • If preventExtensions has been called on an array, subsequent assignment beyond array bounds should fail.
  • 'isFrozen' shouldn't be checking the ReadOnly bit for accessor descriptors (we presently always keep this bit as 'false').
  • Should be able to redefine an non-writable, non-configurable property, with the same value and attributes.
  • Should be able to define an non-configurable accessor.

These are mostly all one-line changes, e.g. inverted boolean checks, masking against wrong attribute.

Source/JavaScriptCore:

  • runtime/JSArray.cpp:

(JSC::SparseArrayValueMap::put):

  • Added ASSERT.
  • Calling an undefined setter should only throw in strict mode.

(JSC::JSArray::putDescriptor):

  • Should be able to define an non-configurable accessor.

(JSC::JSArray::defineOwnNumericProperty):

  • Any attempt to redefine a non-configurable property of an array as configurable should be rejected.

(JSC::JSArray::putByIndexBeyondVectorLength):

  • If preventExtensions has been called on an array, subsequent assignment beyond array bounds should fail.
  • runtime/JSArray.h:

(JSArray):

  • made enterDictionaryMode public, called from JSObject.
  • runtime/JSObject.cpp:

(JSC::JSObject::put):

  • Calling an undefined setter should only throw in strict mode.

(JSC::JSObject::preventExtensions):

  • Put array objects into dictionary mode to handle this!

(JSC::JSObject::defineOwnProperty):

  • Should be able to redefine an non-writable, non-configurable property, with the same value and attributes.
  • Redefining an accessor with different attributes changes the attributes, but not the get/set functions!
  • runtime/ObjectConstructor.cpp:

(JSC::objectConstructorDefineProperties):

  • Object.defineProperties should call toObject on 'Properties' argument, rather than throwing if it is not an object.
  • runtime/PropertyDescriptor.cpp:

(JSC::PropertyDescriptor::attributesWithOverride):

  • When redefining an accessor to a data decriptor, if writable is not specified we should default to false.

(JSC::PropertyDescriptor::attributesOverridingCurrent):

  • When redefining an accessor to a data decriptor, if writable is not specified we should default to false.
  • runtime/Structure.cpp:

(JSC::Structure::freezeTransition):

  • 'freezeTransition' shouldn't be setting the ReadOnly bit for accessor descriptors (we presently always keep this bit as 'false').

(JSC::Structure::isFrozen):

  • 'isFrozen' shouldn't be checking the ReadOnly bit for accessor descriptors (we presently always keep this bit as 'false').

LayoutTests:

  • fast/js/Object-defineProperties-expected.txt:
  • fast/js/Object-defineProperty-expected.txt:
  • fast/js/preventExtensions-expected.txt:
  • fast/js/property-getters-and-setters-expected.txt:
  • fast/js/script-tests/Object-defineProperty.js:
  • fast/js/script-tests/preventExtensions.js:
  • fast/js/script-tests/property-getters-and-setters.js:
    • Update result & add new test cases for all bugs fixed.
11:06 AM Changeset in webkit [107956] by barraclough@apple.com
  • 15 edits in trunk

Source/JavaScriptCore: <<<<<<< .mine

LayoutTests: <<<<<<< .mine

10:55 AM Changeset in webkit [107955] by leviw@chromium.org
  • 2 edits in branches/subpixellayout/Source/WebCore

Un-nesting the namespaces in FractionaLayoutUnit, and correcting use of max integers in RenderRubyRun with max LayoutUnits.

10:12 AM Changeset in webkit [107954] by Adam Roben
  • 16 edits
    5 deletes in trunk/Source/WebCore

Roll out r107887

It broke 32-bit builds due to truncation from "long long" to "int".

Original bug is <​http://webkit.org/b/76571> Add FractionalLayoutPoint/Size/Rect for
sub-pixel layout

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.order:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/FractionalLayoutUnit.h:

(WebCore::FractionalLayoutUnit::isInBounds):
(WebCore::operator==):
(WebCore::operator*):

  • platform/graphics/FloatPoint.cpp:
  • platform/graphics/FloatPoint.h:

(WebCore):
(FloatPoint):
(WebCore::FloatPoint::move):
(WebCore::FloatPoint::moveBy):

  • platform/graphics/FloatRect.cpp:
  • platform/graphics/FloatRect.h:

(WebCore):

  • platform/graphics/FloatSize.cpp:
  • platform/graphics/FloatSize.h:

(WebCore):

  • platform/graphics/FractionalLayoutPoint.h: Removed.
  • platform/graphics/FractionalLayoutRect.cpp: Removed.
  • platform/graphics/FractionalLayoutRect.h: Removed.
  • platform/graphics/FractionalLayoutSize.cpp: Removed.
  • platform/graphics/FractionalLayoutSize.h: Removed.
  • platform/graphics/IntRect.cpp:
  • platform/graphics/IntRect.h:

(WebCore):
(IntRect):

10:08 AM Changeset in webkit [107953] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: cache settings values
​https://bugs.webkit.org/show_bug.cgi?id=78815

Reviewed by Vsevolod Vlasov.

  • inspector/front-end/Settings.js:

(WebInspector.Setting.prototype.get if):
(WebInspector.Setting.prototype):
(WebInspector.Setting.prototype.):
(WebInspector.Setting.prototype.set this):

9:51 AM Changeset in webkit [107952] by commit-queue@webkit.org
  • 22 edits
    1 copy
    4 adds in trunk

WebKit does not support DOM 3 Events FocusEvent
​https://bugs.webkit.org/show_bug.cgi?id=76216

Source/WebCore:

Created a new FocusEvent class (extends UIEvent) with a relatedTarget attribute. Moved
the {Focus,Blur,FocusIn,FocusOut}EventDispatchMediator classes inside FocusEvent. Now when
focusin or focusout events are dispatched, a FocusEvent is created with the relatedTarget
attribute set accordingly. No other logic changes have been made besides adding the
FocusEvent class.

Patch by Terry Anderson <​tdanderson@chromium.org> on 2012-02-16
Reviewed by Eric Seidel.

Test: fast/events/related-target-focusevent.html

  • CMakeLists.txt:
  • DerivedSources.cpp:
  • DerivedSources.make:
  • DerivedSources.pri:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/DOMAllInOne.cpp:
    • Included mention of FocusEvent / JSFocusEvent in the above files to allow the patch to build on the different platforms
  • dom/EventDispatchMediator.cpp:
  • dom/EventDispatchMediator.h:
  • dom/EventFactory.in:
  • dom/FocusEvent.cpp: Added.

(WebCore):
(WebCore::FocusEvent::FocusEvent):
(WebCore::FocusEvent::~FocusEvent):
(WebCore::FocusEvent::initFocusEvent):
(WebCore::FocusEvent::interfaceName):
(WebCore::FocusInEventDispatchMediator::create):
(WebCore::FocusInEventDispatchMediator::FocusInEventDispatchMediator):
(WebCore::FocusInEventDispatchMediator::dispatchEvent):
(WebCore::FocusInEventDispatchMediator::event):
(WebCore::FocusOutEventDispatchMediator::create):
(WebCore::FocusOutEventDispatchMediator::FocusOutEventDispatchMediator):
(WebCore::FocusOutEventDispatchMediator::dispatchEvent):
(WebCore::FocusOutEventDispatchMediator::event):
(WebCore::FocusEventDispatchMediator::create):
(WebCore::FocusEventDispatchMediator::FocusEventDispatchMediator):
(WebCore::FocusEventDispatchMediator::dispatchEvent):
(WebCore::BlurEventDispatchMediator::create):
(WebCore::BlurEventDispatchMediator::BlurEventDispatchMediator):
(WebCore::BlurEventDispatchMediator::dispatchEvent):

  • dom/FocusEvent.h: Copied from Source/WebCore/dom/EventDispatchMediator.h.

(WebCore):
(FocusEvent):
(WebCore::FocusEvent::create):
(WebCore::FocusEvent::relatedTarget):
(WebCore::FocusEvent::setRelatedTarget):
(FocusInEventDispatchMediator):
(FocusOutEventDispatchMediator):
(FocusEventDispatchMediator):
(BlurEventDispatchMediator):

  • dom/FocusEvent.idl: Added.
  • dom/Node.cpp:

(WebCore::Node::dispatchFocusInEvent):
(WebCore::Node::dispatchFocusOutEvent):

  • dom/UIEvent.cpp:
  • dom/UIEvent.h:
  • page/DOMWindow.idl:

LayoutTests:

Patch by Terry Anderson <​tdanderson@chromium.org> on 2012-02-16
Reviewed by Eric Seidel.

  • fast/dom/shadow/shadow-boundary-events-expected.txt:
  • fast/dom/shadow/shadow-boundary-events.html:
    • Changed the focusin/focusout parts of this layout test to include the relatedTarget attribute, which is now set on FocusEvent objects
  • fast/events/event-creation-expected.txt:
  • fast/events/event-creation.html:
    • Added the creation of FocusEvents to this layout test
  • fast/events/related-target-focusevent-expected.txt: Added.
  • fast/events/related-target-focusevent.html: Added.
    • This is a new layout test I created specifically for this patch
9:48 AM Changeset in webkit [107951] by noam.rosenthal@nokia.com
  • 10 edits in trunk/Source

[Texmap] Improve the way we deal with BGRA extension
​https://bugs.webkit.org/show_bug.cgi?id=78822

Source/WebCore:

Swizzle the RGBA manually only in OpenGL ES, and only if the extension is not available.
Pass the pixel-format of the images when updating TextureMapperTiledBackingStore.

Reviewed by Kenneth Rohde Christiansen.

No new behavior.

  • platform/graphics/opengl/TextureMapperGL.cpp:

(WebCore):
(WebCore::hasExtension):
(WebCore::hasBgraExtension):
(WebCore::BitmapTextureGL::updateContents):

  • platform/graphics/texmap/TextureMapperBackingStore.cpp:

(WebCore::TextureMapperTile::updateContents):
(WebCore::TextureMapperTiledBackingStore::updateContentsFromImageIfNeeded):
(WebCore::TextureMapperTiledBackingStore::updateContents):

  • platform/graphics/texmap/TextureMapperBackingStore.h:

(TextureMapperTile):
(TextureMapperTiledBackingStore):
(WebCore::TextureMapperTiledBackingStore::updateContents):

  • platform/graphics/texmap/TextureMapperLayer.cpp:

(WebCore::TextureMapperLayer::updateBackingStore):

Source/WebKit2:

Get rid of swizzling in the web process. Instead, we moved swizzling back to
TextureMapperGL, as we're moving towards a setup where textures are uploaded
in the web process.

Reviewed by Kenneth Rohde Christiansen.

  • UIProcess/qt/LayerBackingStore.cpp:

(WebKit::LayerBackingStoreTile::swapBuffers):

  • UIProcess/qt/LayerTreeHostProxyQt.cpp:

(WebKit::LayerTreeHostProxy::createImage):

  • WebProcess/WebPage/TiledBackingStoreRemoteTile.cpp:

(WebKit::TiledBackingStoreRemoteTile::updateBackBuffer):

  • WebProcess/WebPage/qt/LayerTreeHostQt.cpp:

(WebKit::LayerTreeHostQt::adoptImageBackingStore):

9:45 AM Changeset in webkit [107950] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebKit2

Unreviewed. Fix WebKit2 GTK+ build after r107947.

  • UIProcess/API/gtk/WebKitPrintOperation.cpp:

(webkitPrintOperationRunDialogForFrame):

9:33 AM Changeset in webkit [107949] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[Qt] Fix linking in debug builds on Mac OS X
​https://bugs.webkit.org/show_bug.cgi?id=78811

Patch by Alexander Færøy <​ahf@0x90.dk> on 2012-02-16
Reviewed by Kenneth Rohde Christiansen.

  • UIProcess/API/qt/tests/bytearraytestdata.h:
9:16 AM Changeset in webkit [107948] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebKit2

[GTK] Page content is incorrectly translated whenh rendering pages for printing in WebKit2
​https://bugs.webkit.org/show_bug.cgi?id=78712

Reviewed by Martin Robinson.

  • WebProcess/WebPage/gtk/WebPrintOperationGtk.cpp:

(WebKit::WebPrintOperationGtk::enumeratePrintersFunction):
Simplify the code to select the printer.
(WebKit::WebPrintOperationGtk::renderPage): Call cairo_save()
before rendering the page and cairo_restore() when page has been
rendered.

9:10 AM Changeset in webkit [107947] by Carlos Garcia Campos
  • 11 edits
    4 adds in trunk/Source/WebKit2

[GTK] Add WebKitPrintOperation to WebKit2 GTK+ API
​https://bugs.webkit.org/show_bug.cgi?id=76448

Reviewed by Martin Robinson.

  • GNUmakefile.am: Add new files to compilation.
  • UIProcess/API/gtk/WebKitDefines.h:
  • UIProcess/API/gtk/WebKitPrintOperation.cpp: Added.

(webViewDestroyed): Delete the print operation when the view
widget associated is destroyed.
(webkitPrintOperationConstructed): Connect to destroy signal of
associated web view.
(webkitPrintOperationGetProperty):
(webkitPrintOperationSetProperty):
(webkit_print_operation_init):
(webkit_print_operation_class_init):
(webkitPrintOperationRunDialogUnix): Use GtkPrintUnixDialog to
show the printing dialog in UNIX platforms.
(webkitPrintOperationRunDialogWin32): Empty, not implemented yet.
(drawPagesForPrintingCompleted): Callback called when printing
operation has finished in the web process.
(webkitPrintOperationRunDialogForFrame): Run the printing dialog
and start printing the given frame.
(webkit_print_operation_new): Create a new print operation for the
given web view.
(webkit_print_operation_get_print_settings):
(webkit_print_operation_set_print_settings):
(webkit_print_operation_get_page_setup):
(webkit_print_operation_set_page_setup):
(webkit_print_operation_run_dialog): Run the print dialog to print
the web view main frame.

  • UIProcess/API/gtk/WebKitPrintOperation.h: Added.
  • UIProcess/API/gtk/WebKitPrintOperationPrivate.h: Added.
  • UIProcess/API/gtk/WebKitUIClient.cpp:

(printFrame): Call webkitWebViewPrintFrame.
(attachUIClientToView): Add implementation for
printFrame callback.

  • UIProcess/API/gtk/WebKitWebView.cpp:

(webkit_web_view_class_init): Add WebKitWebView::print-requested
signal.
(webkitWebViewPrintFrame): Emit print-requested and show the print
dialog to print the frame when not signal is not handled by user.

  • UIProcess/API/gtk/WebKitWebView.h:
  • UIProcess/API/gtk/WebKitWebViewPrivate.h:
  • UIProcess/API/gtk/docs/webkit2gtk-docs.sgml: Add new section for

WebKitPrintOperation.

  • UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Add new symbols.
  • UIProcess/API/gtk/tests/GNUmakefile.am:
  • UIProcess/API/gtk/tests/TestPrinting.cpp: Added.

(testPrintOperationPrintSettings):
(webViewPrintRequestedCallback):
(testWebViewPrintRequested):
(beforeAll):
(afterAll):

  • UIProcess/API/gtk/webkit2.h: Include WebKitPrintOperation.h.
9:09 AM Changeset in webkit [107946] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit

[BlackBerry] Style clean-up in WebPageCompositor
​https://bugs.webkit.org/show_bug.cgi?id=78738

Patch by Nima Ghanavatian <​nghanavatian@rim.com> on 2012-02-16
Reviewed by Rob Buis.

No new functionality, no new tests.

  • blackberry/WebKitSupport/WebPageCompositor.cpp:

(BlackBerry::WebKit::WebPageCompositor::drawLayers):

  • blackberry/WebKitSupport/WebPageCompositor.h:

(WebKit):

9:03 AM Changeset in webkit [107945] by commit-queue@webkit.org
  • 12 edits
    2 moves in trunk/Source

[Gtk][Efl][Qt] Move OpenGLShims out of cairo/ subdirectory
​https://bugs.webkit.org/show_bug.cgi?id=78800

Patch by Simon Hausmann <​simon.hausmann@nokia.com> on 2012-02-16
Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

The file is not specific to Cairo and used in other ports. Move it into
common space.

  • GNUmakefile.list.am:
  • PlatformEfl.cmake:
  • Target.pri:
  • platform/graphics/OpenGLShims.cpp: Renamed from Source/WebCore/platform/graphics/cairo/OpenGLShims.cpp.

(WebCore):
(WebCore::openGLFunctionTable):
(WebCore::getProcAddress):
(WebCore::lookupOpenGLFunctionAddress):
(WebCore::initializeOpenGLShims):

  • platform/graphics/OpenGLShims.h: Renamed from Source/WebCore/platform/graphics/cairo/OpenGLShims.h.

(WebCore):
(_OpenGLFunctionTable):

  • platform/graphics/opengl/Extensions3DOpenGL.cpp:
  • platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:
  • platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:
  • platform/graphics/opengl/TextureMapperGL.cpp:
  • platform/graphics/qt/Extensions3DQt.cpp:
  • platform/graphics/qt/GraphicsContext3DQt.cpp:

Source/WebKit2:

  • UIProcess/qt/LayerTreeHostProxyQt.cpp: Adjust to changed OpenGLShims.h

location - no more cairo prefix needed.

9:00 AM Changeset in webkit [107944] by Philippe Normand
  • 1 edit
    10 adds in trunk/LayoutTests

Unreviewed, GTK baselines for new SVG and fast/ tests.

  • platform/gtk/fast/css/font-face-synthetic-bold-italic-expected.txt: Added.
  • platform/gtk/fast/css/font-face-weight-matching-expected.txt: Added.
  • platform/gtk/fast/js/constructor-length-expected.txt: Added.
  • platform/gtk/svg/custom/glyph-selection-arabic-forms-expected.txt: Added.
  • platform/gtk/svg/custom/glyph-selection-bidi-mirror-expected.txt: Added.
  • platform/gtk/svg/custom/glyph-selection-non-bmp-expected.txt: Added.
  • platform/gtk/svg/text/ems-display-none-expected.txt: Added.
  • platform/gtk/svg/text/exs-display-none-expected.txt: Added.
  • platform/gtk/svg/text/text-fill-opacity-expected.txt: Added.
  • platform/gtk/svg/text/tspan-dynamic-positioning-expected.txt: Added.
8:53 AM Changeset in webkit [107943] by noam.rosenthal@nokia.com
  • 7 edits in trunk/Source

[Qt][WK2] Allow opaque tiles
​https://bugs.webkit.org/show_bug.cgi?id=78809

Source/WebCore:

Add a supportsAlpha property to TiledBackingStore.
We invalidate all the tiles if that property changes, because the buffers need to be
recreated in a different format.

Reviewed by Kenneth Rohde Christiansen.

No behavior changes.

  • platform/graphics/TiledBackingStore.cpp:

(WebCore::TiledBackingStore::TiledBackingStore):
(WebCore::TiledBackingStore::setSupportsAlpha):
(WebCore):

  • platform/graphics/TiledBackingStore.h:

(TiledBackingStore):
(WebCore::TiledBackingStore::supportsAlpha):

Source/WebKit2:

Set the supportsAlpha flag for TiledBackingStore when the layer has contentsOpaque enabled.
Use the flag for ShareableBitmaps created by TiledBackingStore.

For now this will not have impact on performance/memory, because we allocate the same type
of buffers for opaque and transparent tiles.

Reviewed by Kenneth Rohde Christiansen.

  • WebProcess/WebCoreSupport/WebGraphicsLayer.cpp:

(WebCore::WebGraphicsLayer::setContentsOpaque):
(WebCore::WebGraphicsLayer::setContentsScale):
(WebCore::WebGraphicsLayer::createBackingStore):
(WebCore):
(WebCore::WebGraphicsLayer::updateContentBuffers):

  • WebProcess/WebCoreSupport/WebGraphicsLayer.h:

(WebGraphicsLayer):

  • WebProcess/WebPage/TiledBackingStoreRemoteTile.cpp:

(WebKit::TiledBackingStoreRemoteTile::updateBackBuffer):

8:46 AM Changeset in webkit [107942] by Philippe Normand
  • 4 edits in trunk/LayoutTests

Unreviewed, GTK rebaseline.

  • platform/gtk/fast/table/027-expected.txt:
  • platform/gtk/fast/table/027-vertical-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug14929-expected.txt:
8:41 AM Changeset in webkit [107941] by sergio@webkit.org
  • 6 edits in trunk/Source

[soup] Move important SoupSession feature initialization to WebCore
​https://bugs.webkit.org/show_bug.cgi?id=68602

Reviewed by Martin Robinson.

Source/WebCore:

Moved content sniffer and decoder initialization from WebKit to
WebCore because network stuff will not work as expected without
them. Added also out-of-the-box proxy support to WebCore.

No new tests required as we're just moving stuff from WebKit to
WebCore.

  • platform/network/soup/ResourceHandleSoup.cpp:

(WebCore::ResourceHandle::defaultSession):

Source/WebKit/gtk:

Moved content sniffer and decoder initialization from WebKit to
WebCore because network stuff will not work as expected without
them.

No new tests required as we're just moving stuff from WebKit to
WebCore.

  • webkit/webkitglobals.cpp:

(webkitInit):

Source/WebKit2:

Moved content sniffer and decoder initialization from the
WebProcess to WebCore because network stuff will not work as
expected without them.

No new tests required as we're just moving stuff from the
WebProcess to WebCore.

  • WebProcess/gtk/WebProcessMainGtk.cpp:

(WebKit::WebProcessMainGtk):

8:37 AM Changeset in webkit [107940] by pfeldman@chromium.org
  • 3 edits
    1 delete in trunk

Web Inspector: remove free flow DOM editing experiment.
​https://bugs.webkit.org/show_bug.cgi?id=78813

Reviewed by Yury Semikhatsky.

  • inspector/front-end/DOMAgent.js:

(WebInspector.DOMAgent.prototype._markRevision):

8:32 AM Changeset in webkit [107939] by Philippe Normand
  • 2 edits
    1 add in trunk/LayoutTests

[GTK] fast/events/drag-dataTransfer-live-attributes.html fails
​https://bugs.webkit.org/show_bug.cgi?id=78818

Unreviewed, rebaseline the test and unskip, as advised by Daniel Cheng.

  • platform/gtk/Skipped:
  • platform/gtk/fast/events/drag-dataTransfer-live-attributes-expected.txt: Added.
8:15 AM Changeset in webkit [107938] by Philippe Normand
  • 3 edits in trunk/LayoutTests

Unreviewed, skipping 2 new test failures and unskipping some
needing rebaselining.

  • platform/gtk/Skipped:
  • platform/gtk/test_expectations.txt:
8:15 AM Changeset in webkit [107937] by Patrick Gansterer
  • 2 edits in trunk/Source/WebCore

WinCE build fix after r107453.

  • platform/FractionalLayoutUnit.h:

(WebCore::FractionalLayoutUnit::isInBounds): Use fabs() instead of abs().

7:48 AM Changeset in webkit [107936] by Philippe Normand
  • 5 edits in trunk/LayoutTests

Unreviewed, GTK rebaseline after r107869 and skip a failing test.

  • platform/gtk/Skipped:
  • platform/gtk/fast/dom/Window/window-properties-expected.txt:
  • platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/gtk/fast/js/global-constructors-expected.txt:
7:38 AM Changeset in webkit [107935] by pfeldman@chromium.org
  • 7 edits in trunk/Source/WebCore

Web Inspector: explicitly mark undoable state from the front-end.
​https://bugs.webkit.org/show_bug.cgi?id=78716

Reviewed by Vsevolod Vlasov.

  • inspector/InspectorCSSAgent.cpp:

(WebCore::InspectorCSSAgent::toggleProperty):
(WebCore::InspectorCSSAgent::setRuleSelector):
(WebCore::InspectorCSSAgent::addRule):

  • inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::setAttributeValue):
(WebCore::InspectorDOMAgent::setAttributesAsText):
(WebCore::InspectorDOMAgent::removeAttribute):
(WebCore::InspectorDOMAgent::removeNode):
(WebCore::InspectorDOMAgent::setNodeName):
(WebCore::InspectorDOMAgent::setOuterHTML):
(WebCore::InspectorDOMAgent::setNodeValue):
(WebCore::InspectorDOMAgent::moveTo):

  • inspector/InspectorHistory.cpp:

(WebCore::InspectorHistory::redo):

  • inspector/InspectorHistory.h:

(InspectorHistory):

  • inspector/front-end/CSSStyleModel.js:

(WebInspector.CSSStyleModel.prototype.setRuleSelector.callback):
(WebInspector.CSSStyleModel.prototype.setRuleSelector):
(WebInspector.CSSStyleModel.prototype.addRule.callback):
(WebInspector.CSSStyleModel.prototype.addRule):
(WebInspector.CSSStyleModel.prototype.setStyleSheetText):
(WebInspector.CSSProperty.prototype.setText.callback):
(WebInspector.CSSProperty.prototype.setText):
(WebInspector.CSSProperty.prototype.setDisabled.callback):
(WebInspector.CSSProperty.prototype.setDisabled):
(WebInspector.CSSStyleSheet.prototype.setText):

  • inspector/front-end/DOMAgent.js:

(WebInspector.DOMAgent.prototype._markRevision):
(WebInspector.DOMAgent.prototype.get markUndoableState):

7:36 AM Changeset in webkit [107934] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: revert 'modification of DOM upon single click for selected nodes'.
​https://bugs.webkit.org/show_bug.cgi?id=78717

Reviewed by Vsevolod Vlasov.

  • inspector/front-end/ElementsTreeOutline.js:

(WebInspector.ElementsTreeElement.prototype.onattach):

7:34 AM Changeset in webkit [107933] by pfeldman@chromium.org
  • 4 edits in trunk/Source/WebCore

Web Inspector: move style disable checkboxes to the left
​https://bugs.webkit.org/show_bug.cgi?id=78780

Reviewed by Vsevolod Vlasov.

  • inspector/front-end/StylesSidebarPane.js:

(WebInspector.StylePropertiesSection):
(WebInspector.StylePropertiesSection.prototype._handleSelectorDoubleClick):
(WebInspector.StylePropertyTreeElement.prototype):

  • inspector/front-end/elementsPanel.css:

(.styles-section.matched-styles .properties):
(.styles-section.matched-styles .properties li):
(.styles-section .properties li.parent::before):
(.styles-section .properties li.parent.expanded::before):
(.styles-section.matched-styles .properties li.parent .expand-element):
(.styles-section.matched-styles .properties li.parent.expanded .expand-element):
(.styles-section.computed-style .properties li.parent::before):
(.styles-section.computed-style .properties li.parent.expanded::before):
(.styles-section.matched-styles:not(.read-only):hover .properties .enabled-button):
(.styles-section.matched-styles:not(.read-only) .properties li.disabled .enabled-button):
(.styles-section .properties .enabled-button):
(.styles-section.matched-styles .properties ol.expanded):

  • inspector/front-end/treeoutline.js:

(TreeElement.treeElementDoubleClicked):

7:32 AM Changeset in webkit [107932] by yurys@chromium.org
  • 5 edits in trunk/Source/WebCore

Web Inspector: show memory counter graphics when switching to memory view
​https://bugs.webkit.org/show_bug.cgi?id=78808

Switching to memory view in timeline will display memory counters. Counter
graphics know show fair data without approximations between sampling points.

Reviewed by Pavel Feldman.

  • English.lproj/localizedStrings.js:
  • inspector/front-end/MemoryStatistics.js:

(WebInspector.MemoryStatistics.prototype._calculateVisibleIndexes):
(WebInspector.MemoryStatistics.prototype._calculateXValues):
(WebInspector.MemoryStatistics.prototype._drawPolyline):

  • inspector/front-end/TimelinePanel.js:

(WebInspector.TimelinePanel.prototype.get statusBarItems):
(WebInspector.TimelinePanel.prototype._createStatusbarButtons):
(WebInspector.TimelinePanel.prototype._timelinesOverviewItemSelected):
(WebInspector.TimelinePanel.prototype._memoryOverviewItemSelected):

7:16 AM Changeset in webkit [107931] by Csaba Osztrogonác
  • 2 edits in trunk/Tools

Add new Qt performance tester bot to build.webkit.org
​https://bugs.webkit.org/show_bug.cgi?id=78795

Reviewed by Adam Roben.

  • BuildSlaveSupport/build.webkit.org-config/config.json:
6:58 AM Changeset in webkit [107930] by vsevik@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed chromium expectations update.

  • platform/chromium/test_expectations.txt:
6:23 AM Changeset in webkit [107929] by loislo@chromium.org
  • 17 edits in trunk

Web Inspector: [heap snapshot] It could be useful to have access to the selected heap object from the console.
​https://bugs.webkit.org/show_bug.cgi?id=78496

Reviewed by Yury Semikhatsky.

Source/WebCore:

  • bindings/js/JSInjectedScriptHostCustom.cpp:

(WebCore::JSInjectedScriptHost::inspectedObject):

  • bindings/v8/custom/V8InjectedScriptHostCustom.cpp:

(WebCore::V8InjectedScriptHost::inspectedObjectCallback):

  • inspector/InjectedScriptHost.cpp:

(WebCore::InjectedScriptHost::InjectedScriptHost):
(WebCore::InjectedScriptHost::InspectableObject::get):
(WebCore):
(WebCore::InjectedScriptHost::addInspectedObject):
(WebCore::InjectedScriptHost::clearInspectedObjects):
(WebCore::InjectedScriptHost::inspectedObject):

  • inspector/InjectedScriptHost.h:

(InspectableObject):
(WebCore::InjectedScriptHost::InspectableObject::~InspectableObject):
(InjectedScriptHost):

  • inspector/InjectedScriptHost.idl:
  • inspector/InjectedScriptSource.js:

(.):

  • inspector/Inspector.json:
  • inspector/InspectorAgent.cpp:

(WebCore::InspectorAgent::domContentLoadedEventFired):

  • inspector/InspectorConsoleAgent.cpp:

(InspectableHeapObject):
(WebCore::InspectableHeapObject::InspectableHeapObject):
(WebCore::InspectableHeapObject::get):
(WebCore):
(WebCore::InspectorConsoleAgent::addInspectedHeapObject):

  • inspector/InspectorConsoleAgent.h:

(InspectorConsoleAgent):

  • inspector/InspectorProfilerAgent.cpp:

(WebCore::InspectorProfilerAgent::resetState):

  • inspector/PageConsoleAgent.cpp:

(InspectableNode):
(WebCore::InspectableNode::InspectableNode):
(WebCore::InspectableNode::get):
(WebCore):
(WebCore::PageConsoleAgent::addInspectedNode):

  • inspector/front-end/DetailedHeapshotView.js:

(WebInspector.DetailedHeapshotView.prototype._selectionChanged):
(WebInspector.DetailedHeapshotView.prototype._inspectedObjectChanged):

LayoutTests:

  • inspector/protocol/console-agent-expected.txt:
  • inspector/protocol/console-agent.html:
5:59 AM Changeset in webkit [107928] by loislo@chromium.org
  • 2 edits
    2 adds in trunk/LayoutTests

[chromium] Rebaseline after r107881

  • platform/chromium-mac-snowleopard/fast/css/getComputedStyle/computed-style-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/chromium-mac-snowleopard/svg/css/getComputedStyle-basic-expected.txt: Added.
5:48 AM Changeset in webkit [107927] by noel.gordon@gmail.com
  • 4 edits
    1 move
    8 deletes in trunk/LayoutTests

[chromium] Rebaseline JPEG image results after r107389
​https://bugs.webkit.org/show_bug.cgi?id=78454

Unreviewed. Rebaseline #21 of N.

  • platform/chromium-linux-x86/fast/images/color-jpeg-with-color-profile-expected.txt: Removed.
  • platform/chromium-linux/fast/images/color-jpeg-with-color-profile-expected.txt: Removed.
  • platform/chromium-mac-leopard/fast/images/color-jpeg-with-color-profile-expected.png:
  • platform/chromium-mac-snowleopard/fast/images/color-jpeg-with-color-profile-expected.png:
  • platform/chromium-mac/fast/images/color-jpeg-with-color-profile-expected.txt: Removed.
  • platform/chromium-win-vista/fast/images/color-jpeg-with-color-profile-expected.txt: Removed.
  • platform/chromium-win-xp/fast/images/color-jpeg-with-color-profile-expected.txt: Removed.
  • platform/chromium-win/fast/images/color-jpeg-with-color-profile-expected.txt: Removed.
  • platform/chromium/test_expectations.txt:
  • platform/gtk/fast/images/color-jpeg-with-color-profile-expected.txt: Removed.
  • platform/mac/fast/images/color-jpeg-with-color-profile-expected.png: Renamed from LayoutTests/fast/images/color-jpeg-with-color-profile-expected.png.
  • platform/qt/fast/images/color-jpeg-with-color-profile-expected.txt: Removed.
5:46 AM Changeset in webkit [107926] by commit-queue@webkit.org
  • 6 edits in trunk/Source/WebCore

Add support for unsigned long[] to idl bindings to JSC.
​https://bugs.webkit.org/show_bug.cgi?id=78210

Patch by Kihong Kwon <​kihong.kwon@samsung.com> on 2012-02-16
Reviewed by Kentaro Hara.

Add support for unsigned long[] parameter type in idl.
This patch adds support just for unsigned long[] parameter type.
(support for other types of array should be done in another patch.)

tests added to TestObj.idl.

  • bindings/js/JSDOMBinding.h:

(WebCore::jsUnsignedLongArrayToVector):

  • bindings/scripts/CodeGeneratorJS.pm:

(AddIncludesForType):
(JSValueToNative):
(NativeToJSValue):

  • bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore):
(WebCore::jsTestObjPrototypeFunctionMethodWithUnsignedLongArray):

  • bindings/scripts/test/JS/JSTestObj.h:

(WebCore):

  • bindings/scripts/test/TestObj.idl:
5:30 AM Changeset in webkit [107925] by vsevik@chromium.org
  • 15 edits
    7 adds in trunk

Web Inspector: [InspectorIndexedDB] Add IndexedDB TreeElement to resources panel.
​https://bugs.webkit.org/show_bug.cgi?id=78609

Reviewed by Yury Semikhatsky.

Source/WebCore:

Added IndexedDB tree element to resources panel (behind experimental setting).
Test is currently disabled, since we don't run tests with experiments enabled.

  • English.lproj/localizedStrings.js:
  • WebCore.gypi:
  • inspector/front-end/Images/indexedDB.png: Added.
  • inspector/front-end/Images/indexedDBIndex.png: Added.
  • inspector/front-end/Images/indexedDBObjectStore.png: Added.
  • inspector/front-end/IndexedDBModel.js:

(WebInspector.IndexedDBModel):
(WebInspector.IndexedDBModel.prototype.refreshDatabaseNames):
(WebInspector.IndexedDBModel.prototype.refreshDatabase):
(WebInspector.IndexedDBModel.prototype._reset):
(WebInspector.IndexedDBModel.prototype._originAddedToFrame):
(WebInspector.IndexedDBModel.prototype._originRemoved):
(WebInspector.IndexedDBModel.prototype._databaseAdded):
(WebInspector.IndexedDBModel.prototype._databaseRemoved):
(WebInspector.IndexedDBModel.prototype._loadDatabaseNamesForFrame):
(WebInspector.IndexedDBModel.prototype._loadDatabase.callback):
(WebInspector.IndexedDBModel.prototype._loadDatabase):
(WebInspector.IndexedDBModel.Frame):
(WebInspector.IndexedDBModel.DatabaseId):
(WebInspector.IndexedDBModel.DatabaseId.prototype.equals):
(WebInspector.IndexedDBModel.Database):
(WebInspector.IndexedDBModel.Index):

  • inspector/front-end/ResourcesPanel.js:

(WebInspector.IndexedDBTreeElement):
(WebInspector.IndexedDBTreeElement.prototype.onexpand):
(WebInspector.IndexedDBTreeElement.prototype._createIndexedDBModel):
(WebInspector.IndexedDBTreeElement.prototype.refreshIndexedDB):
(WebInspector.IndexedDBTreeElement.prototype._indexedDBAdded):
(WebInspector.IndexedDBTreeElement.prototype._indexedDBRemoved):
(WebInspector.IndexedDBTreeElement.prototype._indexedDBLoaded):
(WebInspector.IndexedDBTreeElement.prototype._idbDatabaseTreeElement):
(WebInspector.IDBDatabaseTreeElement):
(WebInspector.IDBDatabaseTreeElement.prototype.update):
(WebInspector.IDBDatabaseTreeElement.prototype.onselect):
(WebInspector.IDBObjectStoreTreeElement):
(WebInspector.IDBObjectStoreTreeElement.prototype.update):
(WebInspector.IDBIndexTreeElement):
(WebInspector.IDBIndexTreeElement.prototype.update):

  • inspector/front-end/Settings.js:

(WebInspector.ExperimentsSettings):

  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/resourcesPanel.css:

(.indexed-db-storage-tree-item .icon):
(.indexed-db-object-store-storage-tree-item .icon):
(.indexed-db-index-storage-tree-item .icon):

LayoutTests:

  • http/tests/inspector/indexeddb/database-data-expected.txt:
  • http/tests/inspector/indexeddb/database-data.html:
  • http/tests/inspector/indexeddb/database-names-expected.txt:
  • http/tests/inspector/indexeddb/database-structure-expected.txt:
  • http/tests/inspector/indexeddb/database-structure.html:
  • http/tests/inspector/indexeddb/indexeddb-test.js:

(initialize_IndexedDBTest.InspectorTest.dumpIndexedDBTree):
(initialize_IndexedDBTest.InspectorTest.evaluateWithCallback):
(initialize_IndexedDBTest.InspectorTest._installIndexedDBSniffer.consoleMessageOverride):
(initialize_IndexedDBTest.InspectorTest._installIndexedDBSniffer):
(createDatabase.closeDatabase):
(createDatabase):
(deleteDatabase):

  • http/tests/inspector/indexeddb/resources-panel-expected.txt: Added.
  • http/tests/inspector/indexeddb/resources-panel.html_disabled: Added.
  • http/tests/inspector/indexeddb/resources/without-indexed-db.html: Added.
5:07 AM Changeset in webkit [107924] by Nikolas Zimmermann
  • 2 edits
    2 adds in trunk/LayoutTests

2012-02-16 Nikolas Zimmermann <​nzimmermann@rim.com>

Not reviewed. Add missing results for Lion, and regenerate one test result with Lion,
so my baseline passes again with --tolerance 0 -p svg.

  • platform/mac/svg/text/text-fill-opacity-expected.png: Added.
  • platform/mac/svg/text/text-fill-opacity-expected.txt: Added.
  • platform/mac/svg/text/tspan-dynamic-positioning-expected.png:
4:58 AM Changeset in webkit [107923] by Nikolas Zimmermann
  • 4 edits
    6 adds in trunk

REGRESSION (Safari 5.0.5 - 5.1): No animation on svg-wow.org/text-effects/text-effects.xhtml
​https://bugs.webkit.org/show_bug.cgi?id=65072

Reviewed by Zoltan Herczeg.

Source/WebCore:

Fix EMS/EXS length resolving, when the target context has no renderer, eg.
<text display="none" dy="1em">ABC</text>, myText.dy.baseVal.getItem(0).value()
currently throws, even if <text> has a parent, we could use to resolve the length.

Always fall-back to parent context, to resolve EMS/EXS units, instead of ignoring it.
The current behaviour stays the same, if the target element is not in the document,
then we really can't resolve lengths like this.

Tests: svg/text/ems-display-none.svg

svg/text/exs-display-none.svg

  • svg/SVGLengthContext.cpp:

(WebCore::renderStyleForLengthResolving):
(WebCore::SVGLengthContext::convertValueFromUserUnitsToEMS):
(WebCore::SVGLengthContext::convertValueFromEMSToUserUnits):
(WebCore::SVGLengthContext::convertValueFromUserUnitsToEXS):
(WebCore::SVGLengthContext::convertValueFromEXSToUserUnits):

LayoutTests:

  • platform/chromium/test_expectations.txt:
  • platform/mac/svg/text/ems-display-none-expected.png: Added.
  • platform/mac/svg/text/ems-display-none-expected.txt: Added.
  • platform/mac/svg/text/exs-display-none-expected.png: Added.
  • platform/mac/svg/text/exs-display-none-expected.txt: Added.
  • svg/text/ems-display-none.svg: Added.
  • svg/text/exs-display-none.svg: Added.
4:46 AM Changeset in webkit [107922] by Simon Hausmann
  • 2 edits in trunk/Source/WebCore

Build fix for Qt 5 without QtWidgets.

Reviewed by Tor Arne Vestbø.

The reason why QGLContext is included in Extensions3DQt.cpp is to
achieve an implicit gl.h inclusion (needed for GL_FALSE). This patch
replaces the inclusion with the OpenGLShims.h inclusions, which has
the necessary #ifdefs in place to pull in gl.h with Qt 5 without QtWidgets.

  • platform/graphics/qt/Extensions3DQt.cpp:
4:15 AM Changeset in webkit [107921] by shawnsingh@chromium.org
  • 2 edits in trunk/Source/WebCore

[chromium] Refactor CCLayerTreeHostCommon: create helper function for complex boolean condition
​https://bugs.webkit.org/show_bug.cgi?id=78539

Reviewed by James Robinson.

This change should introduce no change in behavior, and its
expected behavior is already covered by existing tests.

In calculateDrawTransformsAndVisibility, there is a complex
boolean condition that indicates whether we should create a
RenderSurface or not. This patch pulls out that boolean logic,
and wraps it in a helper function for much better readability.

  • platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:

(WebCore::layerShouldBeSkipped):
(WebCore):
(WebCore::subtreeShouldRenderToSeparateSurface):
(WebCore::calculateDrawTransformsAndVisibilityInternal):

4:11 AM Changeset in webkit [107920] by caseq@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: [refactoring] move timeline overview sidebar creation to TimelineOverviewPane
​https://bugs.webkit.org/show_bug.cgi?id=78782

Reviewed by Vsevolod Vlasov.

  • inspector/front-end/TimelineOverviewPane.js:

(WebInspector.TimelineOverviewPane):
(WebInspector.TimelineOverviewPane.prototype.showTimelines):
(WebInspector.TimelineOverviewPane.prototype.showMemoryGraph):
(WebInspector.TimelineOverviewPane.prototype.sidebarResized):

  • inspector/front-end/TimelinePanel.js:

(WebInspector.TimelinePanel):
(WebInspector.TimelinePanel.prototype.sidebarResized):

3:59 AM SettingUpDevelopmentEnvironmentForN9 edited by vestbo@webkit.org
(diff)
3:58 AM SettingUpDevelopmentEnvironmentForN9 edited by vestbo@webkit.org
(diff)
3:56 AM SettingUpDevelopmentEnvironmentForN9 edited by vestbo@webkit.org
(diff)
3:51 AM BuildingQt5OnHarmattan edited by vestbo@webkit.org
(diff)
3:50 AM SettingUpDevelopmentEnvironmentForN9 edited by vestbo@webkit.org
(diff)
3:50 AM SettingUpDevelopmentEnvironmentForN9 edited by vestbo@webkit.org
(diff)
3:41 AM SettingUpDevelopmentEnvironmentForN9 edited by zarvai@inf.u-szeged.hu
(diff)
3:12 AM SettingUpDevelopmentEnvironmentForN9 edited by zarvai@inf.u-szeged.hu
(diff)
3:05 AM Changeset in webkit [107919] by kling@webkit.org
  • 6 edits in trunk/Source/WebCore

Share font-family CSS values through CSSValuePool.
<​http://webkit.org/b/78604>

Reviewed by Darin Adler.

Cache and share FontFamilyValue instances in the per-document CSSValuePool.
This reduces memory consumption by 248 kB on the Moz page cycler (64-bit)
and avoids a bunch of extra work.

This is a regression from the recent attribute style refactoring; previously
the mapped attribute declaration table would ensure that multiple 'font'
elements with the same 'face' value would share the same FontFamilyValue.

We're not yet sharing the entire CSSValueList returned by parseFontFamily()
but this is a step on the way there.

  • css/FontFamilyValue.cpp:
  • css/FontFamilyValue.h:

Removed appendSpaceSeparated(), making FontFamilyValue immutable.

  • css/CSSParser.cpp:

(FontFamilyValueBuilder):
(WebCore::FontFamilyValueBuilder::FontFamilyValueBuilder):
(WebCore::FontFamilyValueBuilder::add):
(WebCore::FontFamilyValueBuilder::commit):
(WebCore::CSSParser::parseFontFamily):

Refactor parseFontFamily() to defer creation of FontFamilyValue until
the whole family name is known. Added a little helper class to avoid
code duplication.

  • css/CSSValuePool.h:
  • css/CSSValuePool.cpp:

(WebCore::CSSValuePool::createFontFamilyValue):

Added a FontFamilyValue cache to CSSValuePool. All values are tied to
the lifetime of the pool.

2:53 AM SettingUpDevelopmentEnvironmentForN9 edited by vestbo@webkit.org
(diff)
2:50 AM SettingUpDevelopmentEnvironmentForN9 edited by vestbo@webkit.org
(diff)
2:47 AM Changeset in webkit [107918] by Simon Hausmann
  • 2 edits in trunk/Source/WebKit/qt

Unreviewed brown-paper bag build fix.

  • WebCoreSupport/WebEventConversion.cpp:

(WebCore::WebKitPlatformWheelEvent::WebKitPlatformWheelEvent):

2:46 AM Changeset in webkit [107917] by tkent@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Build Fix: R107894 breaks Chromium Linux Build.
​https://bugs.webkit.org/show_bug.cgi?id=78790

WebDragDataPrivate::types, inherited from ChromiumDataObject, returns PassRef<DOMStringList> since r107894. However, WebDragData expected to get old return value type HashSet<String>.

Patch by Yosifumi Inoue <​yosin@chromium.org> on 2012-02-16
Reviewed by Kent Tamura.

  • src/WebDragData.cpp:

(WebKit::WebDragData::items): Use RefPtr<DOMStringList> rather than HashSet<String> for value of m_private->types().

2:37 AM SettingUpDevelopmentEnvironmentForN9 edited by vestbo@webkit.org
No need to source, as build-sources does that (diff)
2:35 AM SettingUpDevelopmentEnvironmentForN9 edited by vestbo@webkit.org
Update instructions to use sysroot (diff)
2:34 AM Changeset in webkit [107916] by Csaba Osztrogonác
  • 5 edits in trunk/LayoutTests

[Qt] Unreviewed gardening.

  • platform/qt/Skipped: Skip new failing tests.
  • platform/qt/fast/dom/Window/window-properties-expected.txt: Updated after r107869.
  • platform/qt/fast/dom/Window/window-property-descriptors-expected.txt: Updated after r107869.
  • platform/qt/fast/js/global-constructors-expected.txt: Updated after r107869.
2:31 AM Changeset in webkit [107915] by Simon Hausmann
  • 9 edits
    2 adds in trunk

[Qt] Move event conversion functions from WebCore to WebKit
​https://bugs.webkit.org/show_bug.cgi?id=78788

Reviewed by Kenneth Rohde Christiansen.

.:

  • Source/api.pri: Add new files to the build.

Source/WebCore:

Move QtWidgets dependent mouse event constructors out of WebCore
into WebKit, similar to the web event conversions of WebKit2.

  • Target.pri:
  • platform/PlatformMouseEvent.h:

(PlatformMouseEvent):

  • platform/PlatformWheelEvent.h:

(PlatformWheelEvent):

Source/WebKit/qt:

Move QtWidgets dependent mouse event constructors out of WebCore
into WebKit, similar to the web event conversions of WebKit2.

  • Api/qwebpage.cpp:

(QWebPagePrivate::mouseMoveEvent):
(QWebPagePrivate::mousePressEvent):
(QWebPagePrivate::mouseDoubleClickEvent):
(QWebPagePrivate::mouseTripleClickEvent):
(QWebPagePrivate::mouseReleaseEvent):
(QWebPagePrivate::wheelEvent):
(QWebPage::swallowContextMenuEvent):

  • WebCoreSupport/FrameLoaderClientQt.cpp:

(WebCore::FrameLoaderClientQt::postProgressFinishedNotification):

  • WebCoreSupport/WebEventConversion.cpp: Added.

(WebCore):
(WebCore::mouseEventModifiersFromQtKeyboardModifiers):
(WebCore::mouseEventTypeAndMouseButtonFromQEvent):
(WebKitPlatformMouseEvent):
(WebCore::WebKitPlatformMouseEvent::WebKitPlatformMouseEvent):
(WebCore::convertMouseEvent):
(WebKitPlatformWheelEvent):
(WebCore::WebKitPlatformWheelEvent::applyDelta):
(WebCore::WebKitPlatformWheelEvent::WebKitPlatformWheelEvent):
(WebCore::convertWheelEvent):

  • WebCoreSupport/WebEventConversion.h: Added.

(WebCore):

2:28 AM Changeset in webkit [107914] by Simon Hausmann
  • 7 edits
    3 adds in trunk/Source

[Qt][WK2] Split QWebPermissionRequest into QWebSecurityOrigin
​https://bugs.webkit.org/show_bug.cgi?id=73215

Patch by Adenilson Cavalcanti <​cavalcantii@gmail.com> on 2012-02-16
Reviewed by Kenneth Rohde Christiansen.

Source/WebKit/qt:

Adding a class to access security information data
(e.g. port/scheme/etc),
while allowing it to be handled in QML side.

  • declarative/plugin.cpp:

(WebKitQmlPlugin::registerTypes):

Source/WebKit2:

Introducing a new class to expose security origin information
(port/scheme/etc), useful for inspecting the origin of permission
requests.

  • Target.pri:
  • UIProcess/API/qt/qtwebsecurityorigin.cpp: Added.

(QtWebSecurityOrigin::QtWebSecurityOrigin):
(QtWebSecurityOrigin::~QtWebSecurityOrigin):
(QtWebSecurityOrigin::host):
(QtWebSecurityOrigin::scheme):
(QtWebSecurityOrigin::path):
(QtWebSecurityOrigin::port):
(QtWebSecurityOrigin::setHost):
(QtWebSecurityOrigin::setScheme):
(QtWebSecurityOrigin::setPath):
(QtWebSecurityOrigin::setPort):

  • UIProcess/API/qt/qtwebsecurityorigin_p.h: Added.
  • UIProcess/API/qt/tests/qmltests/WebView/tst_origin.qml: Added.
  • UIProcess/API/qt/qwebpermissionrequest.cpp:

(QWebPermissionRequestPrivate::QWebPermissionRequestPrivate):
(QWebPermissionRequest::securityOrigin):

  • UIProcess/API/qt/qwebpermissionrequest_p.h:
  • UIProcess/API/qt/tests/qmltests/qmltests.pro:
2:06 AM Changeset in webkit [107913] by Simon Hausmann
  • 2 edits in trunk/Source/WebCore

Unreviewed prospective Qt 4.8/Mac build fix.

Cast the PlatformWidget from QObject* to QWidget* to gain access
to QWidget methods.

  • plugins/mac/PluginViewMac.mm:

(WebCore::nativeWindowFor):
(WebCore::cgHandleFor):
(WebCore::topLevelOffsetFor):
(WebCore::PluginView::setFocus):
(WebCore::PluginView::invalidateRect):

2:06 AM Changeset in webkit [107912] by fpizlo@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

DFG should not check the types of arguments that are dead
​https://bugs.webkit.org/show_bug.cgi?id=78518

Reviewed by Geoff Garen.

The argument checks are now elided if the corresponding SetArgument is dead,
and the abstract value of the argument is set to bottom (None, []). This is
performance neutral on the benchmarks we currently track.

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::initialize):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::checkArgumentTypes):

1:31 AM Changeset in webkit [107911] by rolandsteiner@chromium.org
  • 12 edits in trunk

<style scoped>: Implement scoped selector matching in the slow path
​https://bugs.webkit.org/show_bug.cgi?id=77528

Source/WebCore:

Added scope information to SelectorCheckingContext, SelectorChecker methods and CSSStyleSelector methods.
Added matchOptions struct to CSSStyleSelector similar to SelectorCheckingContext in SelectorChecker.
Adapted the calling sites.

Reviewed by Antti Koivisto.

No new tests. (extended existing tests)

  • css/CSSStyleSelector.cpp:

(RuleData):
(RuleSet):
(WebCore::CSSStyleSelector::determineScopingElement):
(WebCore::CSSStyleSelector::collectMatchingRules):
(WebCore::CSSStyleSelector::collectMatchingRulesForRegion):
(WebCore::CSSStyleSelector::matchScopedAuthorRules):
(WebCore::CSSStyleSelector::matchAuthorRules):
(WebCore::CSSStyleSelector::collectMatchingRulesForList):

  • css/CSSStyleSelector.h:

(CSSStyleSelector):
(MatchOptions):
(WebCore::CSSStyleSelector::MatchOptions::MatchOptions):

  • css/SelectorChecker.cpp:

(WebCore::SelectorChecker::checkSelector):

  • css/SelectorChecker.h:

(WebCore::SelectorChecker::SelectorCheckingContext::SelectorCheckingContext):
(SelectorCheckingContext):
(SelectorChecker):

LayoutTests:

Extended existing <style scoped> tests to also verify that selector matching doesn't exceed the scoping element.

Reviewed by Antti Koivisto.

  • fast/css/style-scoped/style-scoped-basic-expected.txt:
  • fast/css/style-scoped/style-scoped-basic.html:
  • fast/css/style-scoped/style-scoped-remove-scoped-expected.txt:
  • fast/css/style-scoped/style-scoped-remove-scoped.html:
  • fast/css/style-scoped/style-scoped-set-scoped-expected.txt:
  • fast/css/style-scoped/style-scoped-set-scoped.html:
1:15 AM Changeset in webkit [107910] by noel.gordon@gmail.com
  • 8 edits
    1 add
    2 deletes in trunk/LayoutTests

[chromium] Rebaseline JPEG image results after r107389
​https://bugs.webkit.org/show_bug.cgi?id=78454

Unreviewed. Rebaseline #20 of N.

  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug6933-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug85016-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/bugs/bug6933-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug6933-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug85016-expected.png:
  • platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug6933-expected.png: Removed.
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug6933-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug85016-expected.png:
  • platform/chromium/tables/mozilla_expected_failures/bugs/bug85016-expected.txt: Removed.
  • platform/chromium/test_expectations.txt:
12:50 AM Changeset in webkit [107909] by noel.gordon@gmail.com
  • 62 edits
    20 adds
    20 deletes in trunk/LayoutTests

[chromium] Rebaseline JPEG image results after r107389
​https://bugs.webkit.org/show_bug.cgi?id=78454

Unreviewed. Rebaseline #19 of N.

  • platform/chromium-linux/tables/mozilla/marvin/td_valign_baseline-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/td_valign_bottom-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/td_valign_middle-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/td_valign_top-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tfoot_valign_baseline-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tfoot_valign_bottom-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tfoot_valign_middle-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tfoot_valign_top-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/th_valign_baseline-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/th_valign_bottom-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/th_valign_middle-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/th_valign_top-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/thead_valign_baseline-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/thead_valign_bottom-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/thead_valign_middle-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/thead_valign_top-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tr_valign_baseline-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tr_valign_bottom-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tr_valign_middle-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tr_valign_top-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/marvin/td_valign_baseline-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/marvin/td_valign_bottom-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/marvin/td_valign_middle-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/marvin/td_valign_top-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/marvin/tfoot_valign_baseline-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/marvin/tfoot_valign_bottom-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/marvin/tfoot_valign_middle-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/marvin/tfoot_valign_top-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/marvin/th_valign_baseline-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/marvin/th_valign_bottom-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/marvin/th_valign_middle-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/marvin/th_valign_top-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/marvin/thead_valign_baseline-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/marvin/thead_valign_bottom-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/marvin/thead_valign_middle-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/marvin/thead_valign_top-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/marvin/tr_valign_baseline-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/marvin/tr_valign_bottom-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/marvin/tr_valign_middle-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/marvin/tr_valign_top-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/td_valign_baseline-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/td_valign_bottom-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/td_valign_middle-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/td_valign_top-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/tfoot_valign_baseline-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/tfoot_valign_bottom-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/tfoot_valign_middle-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/tfoot_valign_top-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/th_valign_baseline-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/th_valign_bottom-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/th_valign_middle-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/th_valign_top-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/thead_valign_baseline-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/thead_valign_bottom-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/thead_valign_middle-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/thead_valign_top-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/tr_valign_baseline-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/tr_valign_bottom-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/tr_valign_middle-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/tr_valign_top-expected.png: Added.
  • platform/chromium-mac/tables/mozilla/marvin/td_valign_baseline-expected.png: Removed.
  • platform/chromium-mac/tables/mozilla/marvin/td_valign_bottom-expected.png: Removed.
  • platform/chromium-mac/tables/mozilla/marvin/td_valign_middle-expected.png: Removed.
  • platform/chromium-mac/tables/mozilla/marvin/td_valign_top-expected.png: Removed.
  • platform/chromium-mac/tables/mozilla/marvin/tfoot_valign_baseline-expected.png: Removed.
  • platform/chromium-mac/tables/mozilla/marvin/tfoot_valign_bottom-expected.png: Removed.
  • platform/chromium-mac/tables/mozilla/marvin/tfoot_valign_middle-expected.png: Removed.
  • platform/chromium-mac/tables/mozilla/marvin/tfoot_valign_top-expected.png: Removed.
  • platform/chromium-mac/tables/mozilla/marvin/th_valign_baseline-expected.png: Removed.
  • platform/chromium-mac/tables/mozilla/marvin/th_valign_bottom-expected.png: Removed.
  • platform/chromium-mac/tables/mozilla/marvin/th_valign_middle-expected.png: Removed.
  • platform/chromium-mac/tables/mozilla/marvin/th_valign_top-expected.png: Removed.
  • platform/chromium-mac/tables/mozilla/marvin/thead_valign_baseline-expected.png: Removed.
  • platform/chromium-mac/tables/mozilla/marvin/thead_valign_bottom-expected.png: Removed.
  • platform/chromium-mac/tables/mozilla/marvin/thead_valign_middle-expected.png: Removed.
  • platform/chromium-mac/tables/mozilla/marvin/thead_valign_top-expected.png: Removed.
  • platform/chromium-mac/tables/mozilla/marvin/tr_valign_baseline-expected.png: Removed.
  • platform/chromium-mac/tables/mozilla/marvin/tr_valign_bottom-expected.png: Removed.
  • platform/chromium-mac/tables/mozilla/marvin/tr_valign_middle-expected.png: Removed.
  • platform/chromium-mac/tables/mozilla/marvin/tr_valign_top-expected.png: Removed.
  • platform/chromium-win/tables/mozilla/marvin/td_valign_baseline-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/td_valign_bottom-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/td_valign_middle-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/td_valign_top-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tfoot_valign_baseline-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tfoot_valign_bottom-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tfoot_valign_middle-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tfoot_valign_top-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/th_valign_baseline-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/th_valign_bottom-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/th_valign_middle-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/th_valign_top-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/thead_valign_baseline-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/thead_valign_bottom-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/thead_valign_middle-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/thead_valign_top-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tr_valign_baseline-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tr_valign_bottom-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tr_valign_middle-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tr_valign_top-expected.png:
  • platform/chromium/test_expectations.txt:
12:44 AM Changeset in webkit [107908] by Patrick Gansterer
  • 2 edits in trunk/Tools

Disable inspector on WinCE.

Avoid compiling InspectorBackendDispatcher.cpp, which causes an internal compiler error.

  • Scripts/build-webkit:
12:42 AM Changeset in webkit [107907] by Patrick Gansterer
  • 4 edits in trunk/Source

Source/WebKit: [CMake] Add missing include directories.

  • CMakeLists.txt:

Source/WebKit2: [CMake] Add missing include directories.

  • CMakeLists.txt:
12:40 AM Changeset in webkit [107906] by Patrick Gansterer
  • 2 edits in trunk/Tools

WinCE build fix after r107656.

Disable FTPDIR on WinCE, since it does not compile there.

  • Scripts/build-webkit:
12:31 AM Changeset in webkit [107905] by noel.gordon@gmail.com
  • 9 edits
    1 add
    2 deletes in trunk/LayoutTests

[chromium] Rebaseline JPEG image results after r107389
​https://bugs.webkit.org/show_bug.cgi?id=78454

Unreviewed. Rebaseline #18 of N.

  • platform/chromium-linux/tables/mozilla/core/col_widths_auto_autoFix-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/other/test4-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/core/col_widths_auto_autoFix-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/other/test4-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/core/col_widths_auto_autoFix-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/other/test4-expected.png:
  • platform/chromium-mac/tables/mozilla/core/col_widths_auto_autoFix-expected.png: Removed.
  • platform/chromium-win/tables/mozilla/core/col_widths_auto_autoFix-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/other/test4-expected.png:
  • platform/chromium/tables/mozilla_expected_failures/other/test4-expected.txt: Removed.
  • platform/chromium/test_expectations.txt:
12:27 AM WebKitIDL edited by haraken@chromium.org
(diff)
12:26 AM Changeset in webkit [107904] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebKit2

[GTK] Document that local paths in html loaded with loadHTML might cause the web process to terminate
​https://bugs.webkit.org/show_bug.cgi?id=78719

Reviewed by Martin Robinson.

  • UIProcess/API/gtk/WebKitWebView.cpp:
12:22 AM Changeset in webkit [107903] by noel.gordon@gmail.com
  • 14 edits
    4 adds
    4 deletes in trunk/LayoutTests

[chromium] Rebaseline JPEG image results after r107389
​https://bugs.webkit.org/show_bug.cgi?id=78454

Unreviewed. Rebaseline #17 of N.

  • platform/chromium-linux/tables/mozilla/marvin/tbody_valign_baseline-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tbody_valign_bottom-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tbody_valign_middle-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tbody_valign_top-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/marvin/tbody_valign_baseline-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/marvin/tbody_valign_bottom-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/marvin/tbody_valign_middle-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/marvin/tbody_valign_top-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/tbody_valign_baseline-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/tbody_valign_bottom-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/tbody_valign_middle-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/tbody_valign_top-expected.png: Added.
  • platform/chromium-mac/tables/mozilla/marvin/tbody_valign_baseline-expected.png: Removed.
  • platform/chromium-mac/tables/mozilla/marvin/tbody_valign_bottom-expected.png: Removed.
  • platform/chromium-mac/tables/mozilla/marvin/tbody_valign_middle-expected.png: Removed.
  • platform/chromium-mac/tables/mozilla/marvin/tbody_valign_top-expected.png: Removed.
  • platform/chromium-win/tables/mozilla/marvin/tbody_valign_baseline-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tbody_valign_bottom-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tbody_valign_middle-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tbody_valign_top-expected.png:
  • platform/chromium/test_expectations.txt:
12:13 AM Changeset in webkit [107902] by noel.gordon@gmail.com
  • 29 edits
    2 moves
    10 adds
    14 deletes in trunk/LayoutTests

[chromium] Rebaseline JPEG image results after r107389
​https://bugs.webkit.org/show_bug.cgi?id=78454

Unreviewed. Rebaseline #16 of N.

  • platform/chromium-linux/tables/mozilla/bugs/bug29314-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug2981-2-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug4093-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug4284-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug4427-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug56563-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug5797-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug625-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug6404-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug2981-2-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug4093-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug4284-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug4427-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug56563-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug5797-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug625-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug6404-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug29314-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug2981-2-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug4093-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug4284-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug4427-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug50695-2-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug56563-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug5797-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug625-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug6404-expected.png: Added.
  • platform/chromium-mac/tables/mozilla/bugs/bug29314-expected.png: Removed.
  • platform/chromium-mac/tables/mozilla/bugs/bug2981-2-expected.png: Removed.
  • platform/chromium-mac/tables/mozilla/bugs/bug4093-expected.png: Removed.
  • platform/chromium-mac/tables/mozilla/bugs/bug4284-expected.png: Removed.
  • platform/chromium-mac/tables/mozilla/bugs/bug4427-expected.png: Removed.
  • platform/chromium-mac/tables/mozilla/bugs/bug50695-2-expected.png: Removed.
  • platform/chromium-mac/tables/mozilla/bugs/bug56563-expected.png: Removed.
  • platform/chromium-mac/tables/mozilla/bugs/bug5797-expected.png: Removed.
  • platform/chromium-mac/tables/mozilla/bugs/bug625-expected.png: Removed.
  • platform/chromium-mac/tables/mozilla/bugs/bug6404-expected.png: Removed.
  • platform/chromium-win/tables/mozilla/bugs/bug29314-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug2981-2-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug4093-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug4284-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug4427-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug50695-2-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug56563-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug5797-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug625-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug6404-expected.png:
  • platform/chromium/tables/mozilla/bugs/bug56563-expected.txt: Removed.
  • platform/chromium/test_expectations.txt:
  • platform/mac/tables/mozilla/bugs/bug50695-2-expected.txt: Removed.
  • platform/qt/tables/mozilla/bugs/bug29314-expected.txt: Removed.
  • platform/qt/tables/mozilla/bugs/bug50695-2-expected.txt: Removed.
  • tables/mozilla/bugs/bug29314-expected.txt: Renamed from LayoutTests/platform/gtk/tables/mozilla/bugs/bug29314-expected.txt.
  • tables/mozilla/bugs/bug50695-2-expected.txt: Renamed from LayoutTests/platform/gtk/tables/mozilla/bugs/bug50695-2-expected.txt.
12:01 AM Changeset in webkit [107901] by noel.gordon@gmail.com
  • 13 edits
    2 moves
    5 adds
    9 deletes in trunk/LayoutTests

[chromium] Rebaseline JPEG image results after r107389
​https://bugs.webkit.org/show_bug.cgi?id=78454

Unreviewed. Rebaseline #15 of N.

  • platform/chromium-linux/tables/mozilla/bugs/bug12908-1-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug1296-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug1430-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug12908-1-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug1296-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug1430-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug1271-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug12908-1-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug1296-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug13169-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug1430-expected.png: Added.
  • platform/chromium-mac/tables/mozilla/bugs/bug1271-expected.png: Removed.
  • platform/chromium-mac/tables/mozilla/bugs/bug12908-1-expected.png: Removed.
  • platform/chromium-mac/tables/mozilla/bugs/bug1296-expected.png: Removed.
  • platform/chromium-mac/tables/mozilla/bugs/bug13169-expected.png: Removed.
  • platform/chromium-mac/tables/mozilla/bugs/bug1430-expected.png: Removed.
  • platform/chromium-win/tables/mozilla/bugs/bug1271-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug12908-1-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug1296-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug13169-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug1430-expected.png:
  • platform/chromium/test_expectations.txt:
  • platform/mac/tables/mozilla/bugs/bug1271-expected.txt: Removed.
  • platform/mac/tables/mozilla/bugs/bug13169-expected.txt: Removed.
  • platform/qt/tables/mozilla/bugs/bug1271-expected.txt: Removed.
  • platform/qt/tables/mozilla/bugs/bug13169-expected.txt: Removed.
  • tables/mozilla/bugs/bug1271-expected.txt: Renamed from LayoutTests/platform/gtk/tables/mozilla/bugs/bug1271-expected.txt.
  • tables/mozilla/bugs/bug13169-expected.txt: Renamed from LayoutTests/platform/gtk/tables/mozilla/bugs/bug13169-expected.txt.

Feb 15, 2012:

11:50 PM Changeset in webkit [107900] by Patrick Gansterer
  • 2 edits in trunk/Source/WebCore

Windows build fix for !ENABLE(CSS_FILTERS) after r106593.

  • platform/graphics/ca/win/PlatformCALayerWin.cpp:
11:39 PM Changeset in webkit [107899] by Antti Koivisto
  • 32 edits in trunk/Source/WebCore

Move the context invalidation code out from StylePropertySet
​https://bugs.webkit.org/show_bug.cgi?id=78589

Reviewed by Ryosuke Niwa.

StylePropertySet should be independent of its context so that they can in the future
be shared between documents. The context invalidation code should move to the CSSOM wrapper.

Parent rule and parent element pointers move to the CSSOM wrapper classes.

The wrapper is responsible of invalidating the element or document style on mutation.
In case of internal mutation of style attribute, StyledElement takes care of the
invalidation.

The StylePropertySet will still have a pointer to the context stylesheet so the patch
doesn't actually reduce memory usage. That pointer will be factored out later.

  • css/CSSFontFaceRule.cpp:

(WebCore::CSSFontFaceRule::~CSSFontFaceRule):

  • css/CSSFontFaceRule.h:

(WebCore::CSSFontFaceRule::style):

  • css/CSSPageRule.cpp:

(WebCore::CSSPageRule::~CSSPageRule):

  • css/CSSPageRule.h:

(WebCore::CSSPageRule::style):
(WebCore::CSSPageRule::setDeclaration):

  • css/CSSParser.cpp:

(WebCore::CSSParser::createStyleRule):
(WebCore::CSSParser::createFontFaceRule):
(WebCore::CSSParser::createPageRule):
(WebCore::CSSParser::createKeyframeRule):

  • css/CSSStyleRule.cpp:

(WebCore::CSSStyleRule::~CSSStyleRule):

  • css/CSSStyleRule.h:

(WebCore::CSSStyleRule::style):
(WebCore::CSSStyleRule::setDeclaration):

  • css/StylePropertySet.cpp:

(PropertySetCSSStyleDeclaration):
(WebCore::PropertySetCSSStyleDeclaration::parentElement):
(WebCore::PropertySetCSSStyleDeclaration::clearParentRule):
(WebCore::PropertySetCSSStyleDeclaration::clearParentElement):
(WebCore::PropertySetCSSStyleDeclaration::setNeedsStyleRecalc):
(RuleCSSStyleDeclaration):
(WebCore::RuleCSSStyleDeclaration::RuleCSSStyleDeclaration):
(WebCore::RuleCSSStyleDeclaration::parentRule):
(WebCore::RuleCSSStyleDeclaration::clearParentRule):
(WebCore):
(InlineCSSStyleDeclaration):
(WebCore::InlineCSSStyleDeclaration::InlineCSSStyleDeclaration):
(WebCore::InlineCSSStyleDeclaration::parentElement):
(WebCore::InlineCSSStyleDeclaration::clearParentElement):
(WebCore::StylePropertySet::StylePropertySet):
(WebCore::StylePropertySet::removeShorthandProperty):
(WebCore::StylePropertySet::removeProperty):
(WebCore::StylePropertySet::setProperty):
(WebCore::StylePropertySet::parseDeclaration):
(WebCore::StylePropertySet::addParsedProperties):
(WebCore::StylePropertySet::addParsedProperty):
(WebCore::StylePropertySet::merge):
(WebCore::StylePropertySet::removePropertiesInSet):
(WebCore::StylePropertySet::copy):
(WebCore::StylePropertySet::ensureCSSStyleDeclaration):
(WebCore::StylePropertySet::ensureRuleCSSStyleDeclaration):
(WebCore::StylePropertySet::ensureInlineCSSStyleDeclaration):
(WebCore::StylePropertySet::clearParentRule):
(WebCore::StylePropertySet::clearParentElement):
(WebCore::PropertySetCSSStyleDeclaration::setCssText):
(WebCore::PropertySetCSSStyleDeclaration::setProperty):
(WebCore::PropertySetCSSStyleDeclaration::removeProperty):
(WebCore::PropertySetCSSStyleDeclaration::setPropertyInternal):
(WebCore::RuleCSSStyleDeclaration::setNeedsStyleRecalc):
(WebCore::InlineCSSStyleDeclaration::setNeedsStyleRecalc):

  • css/StylePropertySet.h:

(WebCore::StylePropertySet::create):
(StylePropertySet):
(WebCore::StylePropertySet::useStrictParsing):
(WebCore::StylePropertySet::contextStyleSheet):
(WebCore::StylePropertySet::setContextStyleSheet):

  • css/WebKitCSSKeyframeRule.cpp:

(WebCore::WebKitCSSKeyframeRule::~WebKitCSSKeyframeRule):
(WebCore::WebKitCSSKeyframeRule::setDeclaration):

  • css/WebKitCSSKeyframeRule.h:

(WebCore::WebKitCSSKeyframeRule::style):

  • dom/ElementAttributeData.cpp:

(WebCore::ElementAttributeData::ensureInlineStyleDecl):
(WebCore::ElementAttributeData::destroyInlineStyleDecl):

  • dom/ElementAttributeData.h:

(ElementAttributeData):

  • dom/StyledElement.cpp:

(WebCore::StyledElement::insertedIntoDocument):
(WebCore):
(WebCore::StyledElement::removedFromDocument):
(WebCore::StyledElement::parseAttribute):
(WebCore::StyledElement::inlineStyleChanged):
(WebCore::StyledElement::setInlineStyleProperty):
(WebCore::StyledElement::removeInlineStyleProperty):
(WebCore::StyledElement::updateAttributeStyle):

  • dom/StyledElement.h:

(StyledElement):
(WebCore::StyledElement::destroyInlineStyleDecl):

  • editing/ApplyStyleCommand.cpp:

(WebCore::ApplyStyleCommand::applyRelativeFontStyleChange):

  • editing/DeleteButtonController.cpp:

(WebCore::DeleteButtonController::createDeletionUI):
(WebCore::DeleteButtonController::show):
(WebCore::DeleteButtonController::hide):

  • editing/Editor.cpp:

(WebCore::Editor::applyEditingStyleToElement):

  • editing/RemoveCSSPropertyCommand.cpp:

(WebCore::RemoveCSSPropertyCommand::doApply):
(WebCore::RemoveCSSPropertyCommand::doUnapply):

  • editing/ReplaceSelectionCommand.cpp:

(WebCore::ReplaceSelectionCommand::removeRedundantStylesAndKeepStyleSpanInline):

  • html/ColorInputType.cpp:

(WebCore::ColorInputType::updateColorSwatch):

  • html/HTMLTextFormControlElement.cpp:

(WebCore::HTMLTextFormControlElement::updatePlaceholderVisibility):

  • html/ImageDocument.cpp:

(WebCore::ImageDocument::resizeImageToFit):
(WebCore::ImageDocument::restoreImageSize):
(WebCore::ImageDocument::windowSizeChanged):

  • html/ValidationMessage.cpp:

(WebCore::adjustBubblePosition):
(WebCore::ValidationMessage::buildBubbleTree):

  • html/shadow/MediaControlElements.cpp:

(WebCore::MediaControlElement::show):
(WebCore::MediaControlElement::hide):
(WebCore::MediaControlPanelElement::setPosition):
(WebCore::MediaControlPanelElement::resetPosition):
(WebCore::MediaControlPanelElement::makeOpaque):
(WebCore::MediaControlPanelElement::makeTransparent):
(WebCore::MediaControlInputElement::show):
(WebCore::MediaControlInputElement::hide):
(WebCore::MediaControlTextTrackContainerElement::updateSizes):

  • html/shadow/MeterShadowElement.cpp:

(WebCore::MeterValueElement::setWidthPercentage):

  • html/shadow/ProgressShadowElement.cpp:

(WebCore::ProgressValueElement::setWidthPercentage):

  • html/shadow/SliderThumbElement.cpp:

(WebCore::TrackLimiterElement::create):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::resize):

  • rendering/RenderTextControlSingleLine.cpp:

(WebCore::RenderTextControlSingleLine::styleDidChange):

  • svg/SVGFontFaceElement.cpp:

(WebCore::SVGFontFaceElement::SVGFontFaceElement):
(WebCore::SVGFontFaceElement::insertedIntoDocument):
(WebCore::SVGFontFaceElement::removeFromMappedElementSheet):

11:39 PM Changeset in webkit [107898] by Csaba Osztrogonác
  • 21 edits in trunk/LayoutTests

[Qt] Unreviewed gardening after r107814.

  • platform/qt/css3/filters/effect-blur-hw-expected.png:
  • platform/qt/css3/filters/effect-blur-hw-expected.txt:
  • platform/qt/css3/filters/effect-combined-expected.png:
  • platform/qt/css3/filters/effect-combined-expected.txt:
  • platform/qt/css3/filters/effect-combined-hw-expected.png:
  • platform/qt/css3/filters/effect-combined-hw-expected.txt:
  • platform/qt/css3/filters/effect-drop-shadow-hw-expected.png:
  • platform/qt/css3/filters/effect-drop-shadow-hw-expected.txt:
  • platform/qt/css3/filters/effect-grayscale-hw-expected.png:
  • platform/qt/css3/filters/effect-grayscale-hw-expected.txt:
  • platform/qt/css3/filters/effect-hue-rotate-hw-expected.png:
  • platform/qt/css3/filters/effect-hue-rotate-hw-expected.txt:
  • platform/qt/css3/filters/effect-invert-hw-expected.png:
  • platform/qt/css3/filters/effect-invert-hw-expected.txt:
  • platform/qt/css3/filters/effect-opacity-hw-expected.png:
  • platform/qt/css3/filters/effect-opacity-hw-expected.txt:
  • platform/qt/css3/filters/effect-saturate-hw-expected.png:
  • platform/qt/css3/filters/effect-saturate-hw-expected.txt:
  • platform/qt/css3/filters/effect-sepia-hw-expected.png:
  • platform/qt/css3/filters/effect-sepia-hw-expected.txt:
11:38 PM Changeset in webkit [107897] by Csaba Osztrogonác
  • 2 edits in trunk

dataTransfer.types (HTML5 drag & drop) should return DOMStringList
​https://bugs.webkit.org/show_bug.cgi?id=30416

Reviewed by Eric Seidel.

Source/WebCore:

This change breaks backwards compatibility; however, since Firefox only supported
event.dataTransfer.types.contains, sites already needed to check whether to use contains or
indexOf. Therefore, the net compatibility effect of this change should be minimal.

Test: fast/events/drag-dataTransfer-live-attributes.html

  • bindings/js/JSClipboardCustom.cpp:

(WebCore):

  • bindings/v8/custom/V8ClipboardCustom.cpp:
  • dom/Clipboard.cpp:

(WebCore::Clipboard::hasStringOfType):

  • dom/Clipboard.h:

(WebCore):
(Clipboard):

  • dom/Clipboard.idl:
  • platform/blackberry/ClipboardBlackBerry.cpp:

(WebCore::ClipboardBlackBerry::types):

  • platform/blackberry/ClipboardBlackBerry.h:

(ClipboardBlackBerry):

  • platform/chromium/ChromiumDataObject.cpp:

(WebCore::ChromiumDataObject::types):

  • platform/chromium/ChromiumDataObject.h:

(ChromiumDataObject):

  • platform/chromium/ClipboardChromium.cpp:

(WebCore::ClipboardChromium::types):
(WebCore::ClipboardChromium::mayUpdateItems):

  • platform/chromium/ClipboardChromium.h:

(ClipboardChromium):

  • platform/chromium/DragDataChromium.cpp:

(WebCore::containsHTML):
(WebCore::DragData::containsURL):
(WebCore::DragData::asURL):
(WebCore::DragData::containsPlainText):
(WebCore::DragData::canSmartReplace):
(WebCore::DragData::asFragment):

  • platform/efl/ClipboardEfl.cpp:

(WebCore::ClipboardEfl::types):

  • platform/efl/ClipboardEfl.h:

(ClipboardEfl):

  • platform/gtk/ClipboardGtk.cpp:

(WebCore::ClipboardGtk::types):

  • platform/gtk/ClipboardGtk.h:

(ClipboardGtk):

  • platform/mac/ClipboardMac.h:

(ClipboardMac):

  • platform/mac/ClipboardMac.mm:

(WebCore::addHTMLClipboardTypesForCocoaType):
(WebCore::ClipboardMac::types):

  • platform/qt/ClipboardQt.cpp:

(WebCore::ClipboardQt::types):

  • platform/qt/ClipboardQt.h:

(ClipboardQt):

  • platform/win/ClipboardWin.cpp:

(WebCore::addMimeTypesForFormat):
(WebCore::ClipboardWin::types):

  • platform/win/ClipboardWin.h:

(ClipboardWin):

  • platform/wx/ClipboardWx.cpp:

(WebCore::ClipboardWx::types):

  • platform/wx/ClipboardWx.h:

(ClipboardWx):

LayoutTests:

Add a test to document the fact that many dataTransfer attributes aren't live and return a
different object each time they're accessed. Also update tests to use contains() instead of
indexOf().

  • editing/pasteboard/clipboard-customData.html:
  • editing/pasteboard/onpaste-text-html-types.html:
  • fast/events/drag-and-drop-dataTransfer-types-nocrash.html:
  • fast/events/drag-customData.html:
  • fast/events/drag-dataTransfer-live-attributes-expected.txt: Added.
  • fast/events/drag-dataTransfer-live-attributes.html: Copied from LayoutTests/fast/events/drag-customData.html.
  • http/tests/local/fileapi/resources/setup-file-input-element-for-drag.js:
  • http/tests/security/clipboard/script-tests/clipboard-file-access.js:

(checkForEventTransferType):

11:37 PM Changeset in webkit [107896] by Patrick Gansterer
  • 3 edits in trunk/Source/WebKit/wince

Unreviewed WinCE build fix after r107606.

  • WebCoreSupport/PlatformStrategiesWinCE.cpp:

(PlatformStrategiesWinCE::createPasteboardStrategy):

  • WebCoreSupport/PlatformStrategiesWinCE.h:

(PlatformStrategiesWinCE):

11:28 PM Changeset in webkit [107895] by Csaba Osztrogonác
  • 2 edits in trunk

Repaint issues on changing 'viewBox' of inner SVG
​https://bugs.webkit.org/show_bug.cgi?id=77903

Source/WebCore:

Patch by Bear Travis <​betravis@adobe.com> on 2012-02-15
Reviewed by Nikolas Zimmermann.

Do not update the child viewbox/viewport transform to its parent
coordinate system until after layout has stored the old bounds for
repainting purposes.

Test: svg/repaint/inner-svg-change-viewBox-contract.svg

  • rendering/svg/RenderSVGViewportContainer.cpp:

(WebCore::RenderSVGViewportContainer::RenderSVGViewportContainer):
(WebCore::RenderSVGViewportContainer::calcViewport):
(WebCore):
(WebCore::RenderSVGViewportContainer::calculateLocalTransform):
(WebCore::RenderSVGViewportContainer::localToParentTransform):

  • rendering/svg/RenderSVGViewportContainer.h:

(WebCore::RenderSVGViewportContainer::setNeedsTransformUpdate):
(RenderSVGViewportContainer):

  • svg/SVGSVGElement.cpp:

(WebCore::SVGSVGElement::svgAttributeChanged):

LayoutTests:

Adding test for 77903. When setting the viewbox on an inner svg
element causes the content to become smaller, make sure that the
area behind the content is redrawn.

Patch by Bear Travis <​betravis@adobe.com> on 2012-02-15
Reviewed by Nikolas Zimmermann.

  • platform/chromium/test_expectations.txt:
  • svg/repaint/inner-svg-change-viewBox-contract-expected.png: Added.
  • svg/repaint/inner-svg-change-viewBox-contract-expected.txt: Added.
  • svg/repaint/inner-svg-change-viewBox-contract.svg: Added.
11:26 PM Changeset in webkit [107894] by dcheng@chromium.org
  • 32 edits
    1 copy
    1 add in trunk

dataTransfer.types (HTML5 drag & drop) should return DOMStringList
​https://bugs.webkit.org/show_bug.cgi?id=30416

Reviewed by Eric Seidel.

Source/WebCore:

This change breaks backwards compatibility; however, since Firefox only supported
event.dataTransfer.types.contains, sites already needed to check whether to use contains or
indexOf. Therefore, the net compatibility effect of this change should be minimal.

Test: fast/events/drag-dataTransfer-live-attributes.html

  • bindings/js/JSClipboardCustom.cpp:

(WebCore):

  • bindings/v8/custom/V8ClipboardCustom.cpp:
  • dom/Clipboard.cpp:

(WebCore::Clipboard::hasStringOfType):

  • dom/Clipboard.h:

(WebCore):
(Clipboard):

  • dom/Clipboard.idl:
  • platform/blackberry/ClipboardBlackBerry.cpp:

(WebCore::ClipboardBlackBerry::types):

  • platform/blackberry/ClipboardBlackBerry.h:

(ClipboardBlackBerry):

  • platform/chromium/ChromiumDataObject.cpp:

(WebCore::ChromiumDataObject::types):

  • platform/chromium/ChromiumDataObject.h:

(ChromiumDataObject):

  • platform/chromium/ClipboardChromium.cpp:

(WebCore::ClipboardChromium::types):
(WebCore::ClipboardChromium::mayUpdateItems):

  • platform/chromium/ClipboardChromium.h:

(ClipboardChromium):

  • platform/chromium/DragDataChromium.cpp:

(WebCore::containsHTML):
(WebCore::DragData::containsURL):
(WebCore::DragData::asURL):
(WebCore::DragData::containsPlainText):
(WebCore::DragData::canSmartReplace):
(WebCore::DragData::asFragment):

  • platform/efl/ClipboardEfl.cpp:

(WebCore::ClipboardEfl::types):

  • platform/efl/ClipboardEfl.h:

(ClipboardEfl):

  • platform/gtk/ClipboardGtk.cpp:

(WebCore::ClipboardGtk::types):

  • platform/gtk/ClipboardGtk.h:

(ClipboardGtk):

  • platform/mac/ClipboardMac.h:

(ClipboardMac):

  • platform/mac/ClipboardMac.mm:

(WebCore::addHTMLClipboardTypesForCocoaType):
(WebCore::ClipboardMac::types):

  • platform/qt/ClipboardQt.cpp:

(WebCore::ClipboardQt::types):

  • platform/qt/ClipboardQt.h:

(ClipboardQt):

  • platform/win/ClipboardWin.cpp:

(WebCore::addMimeTypesForFormat):
(WebCore::ClipboardWin::types):

  • platform/win/ClipboardWin.h:

(ClipboardWin):

  • platform/wx/ClipboardWx.cpp:

(WebCore::ClipboardWx::types):

  • platform/wx/ClipboardWx.h:

(ClipboardWx):

LayoutTests:

Add a test to document the fact that many dataTransfer attributes aren't live and return a
different object each time they're accessed. Also update tests to use contains() instead of
indexOf().

  • editing/pasteboard/clipboard-customData.html:
  • editing/pasteboard/onpaste-text-html-types.html:
  • fast/events/drag-and-drop-dataTransfer-types-nocrash.html:
  • fast/events/drag-customData.html:
  • fast/events/drag-dataTransfer-live-attributes-expected.txt: Added.
  • fast/events/drag-dataTransfer-live-attributes.html: Copied from LayoutTests/fast/events/drag-customData.html.
  • http/tests/local/fileapi/resources/setup-file-input-element-for-drag.js:
  • http/tests/security/clipboard/script-tests/clipboard-file-access.js:

(checkForEventTransferType):

11:16 PM Changeset in webkit [107893] by commit-queue@webkit.org
  • 6 edits
    3 adds in trunk

Repaint issues on changing 'viewBox' of inner SVG
​https://bugs.webkit.org/show_bug.cgi?id=77903

Source/WebCore:

Patch by Bear Travis <​betravis@adobe.com> on 2012-02-15
Reviewed by Nikolas Zimmermann.

Do not update the child viewbox/viewport transform to its parent
coordinate system until after layout has stored the old bounds for
repainting purposes.

Test: svg/repaint/inner-svg-change-viewBox-contract.svg

  • rendering/svg/RenderSVGViewportContainer.cpp:

(WebCore::RenderSVGViewportContainer::RenderSVGViewportContainer):
(WebCore::RenderSVGViewportContainer::calcViewport):
(WebCore):
(WebCore::RenderSVGViewportContainer::calculateLocalTransform):
(WebCore::RenderSVGViewportContainer::localToParentTransform):

  • rendering/svg/RenderSVGViewportContainer.h:

(WebCore::RenderSVGViewportContainer::setNeedsTransformUpdate):
(RenderSVGViewportContainer):

  • svg/SVGSVGElement.cpp:

(WebCore::SVGSVGElement::svgAttributeChanged):

LayoutTests:

Adding test for 77903. When setting the viewbox on an inner svg
element causes the content to become smaller, make sure that the
area behind the content is redrawn.

Patch by Bear Travis <​betravis@adobe.com> on 2012-02-15
Reviewed by Nikolas Zimmermann.

  • platform/chromium/test_expectations.txt:
  • svg/repaint/inner-svg-change-viewBox-contract-expected.png: Added.
  • svg/repaint/inner-svg-change-viewBox-contract-expected.txt: Added.
  • svg/repaint/inner-svg-change-viewBox-contract.svg: Added.
11:14 PM Changeset in webkit [107892] by Csaba Osztrogonác
  • 5 edits in trunk/LayoutTests

[Qt] Unreviewed gardening after r107811.

  • platform/qt/platform/qt/plugins/qt-qwidget-plugin-expected.txt:
  • platform/qt/plugins/application-plugin-plugins-disabled-expected.txt:
  • platform/qt/plugins/iframe-plugin-bgcolor-expected.txt:
  • platform/qt/plugins/netscape-dom-access-expected.txt:
11:12 PM Changeset in webkit [107891] by andersca@apple.com
  • 3 edits in trunk/Source/WebCore

Fix unused parameter warnings.

  • platform/graphics/ca/mac/WebTileCacheLayer.mm:

(-[WebTileCacheLayer setContentsScale:]):

11:05 PM Changeset in webkit [107890] by leo.yang@torchmobile.com.cn
  • 2 edits in trunk/Source/WebKit

[BlackBerry] Remove ResourceHolderImpl.cpp from build system
​https://bugs.webkit.org/show_bug.cgi?id=78779

Reviewed by George Staikos.

blackberry/Api/ResourceHolderImpl.cpp which hasn't been upstreamed
has been removed internally. So remove it from the build system.

  • blackberry/CMakeListsBlackBerry.txt:
11:04 PM Changeset in webkit [107889] by eae@chromium.org
  • 3 edits in trunk/Source/WebCore

Convert RenderFrameSet to LayoutUnits in preparation for turning on subpixel layout
​https://bugs.webkit.org/show_bug.cgi?id=78526

Reviewed by Eric Seidel.

Revert paintColumnBorder and paintRowBorder to IntRect and pixel snap in
paint before calling them. This way the rounding logic is contained in a
single place (in paint).

No new tests, no new functionality.

  • rendering/RenderFrameSet.cpp:

(WebCore::RenderFrameSet::paintColumnBorder):
(WebCore::RenderFrameSet::paintRowBorder):
(WebCore::RenderFrameSet::paint):
(WebCore::RenderFrameSet::getCursor):

  • rendering/RenderFrameSet.h:

(RenderFrameSet):

10:47 PM Changeset in webkit [107888] by loislo@chromium.org
  • 9 edits
    4 adds
    2 deletes in trunk/LayoutTests

[chromium] Unreviewed rebaseline after r107864.

  • platform/chromium-mac-leopard/svg/batik/text/textDecoration-expected.png:
  • platform/chromium-mac-leopard/svg/css/text-shadow-multiple-expected.png:
  • platform/chromium-mac-leopard/svg/text/text-text-08-b-expected.png:
  • platform/chromium-mac-leopard/svg/wicd/test-scalable-background-image2-expected.png:
  • platform/chromium-mac-snowleopard/compositing/plugins/composited-plugin-expected.png: Added.
  • platform/chromium-mac-snowleopard/compositing/plugins/composited-plugin-expected.txt: Added.
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/text-text-08-b-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/batik/text/textDecoration-expected.png:
  • platform/chromium-mac-snowleopard/svg/css/text-shadow-multiple-expected.png:
  • platform/chromium-mac-snowleopard/svg/text/text-text-08-b-expected.png:
  • platform/chromium-mac-snowleopard/svg/wicd/test-scalable-background-image2-expected.png:
  • platform/chromium-mac/compositing/plugins/composited-plugin-expected.png: Removed.
  • platform/chromium-mac/svg/W3C-SVG-1.1/text-text-08-b-expected.png: Removed.
10:40 PM Changeset in webkit [107887] by leviw@chromium.org
  • 16 edits
    5 adds in trunk/Source/WebCore

Add FractionalLayoutPoint/Size/Rect for sub-pixel layout
​https://bugs.webkit.org/show_bug.cgi?id=76571

Reviewed by Eric Seidel.

Add fixed point versions of the Point, Size and Rect classes using
the new FractionalLayoutPoint type and.

FractionalLayoutPoint, FractionalLayoutSize and FractionalLayoutRect are
Point, Size and Rect implementations respectively using this new type.

No new tests.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.order:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/FractionalLayoutUnit.h:

Fixed a couple of typos and signed/unsigned bugs.

  • platform/graphics/FloatPoint.cpp:

(WebCore::FloatPoint::FloatPoint):
Add explicit FloatPoint(FractionalLayoutPoint) constructor.

(WebCore::FloatPoint::move):
Add move(FractionalLayoutSize) implementation.

(WebCore::FloatPoint::moveBy):
Add moveBy(FractionalLayoutPoint) implementation.

  • platform/graphics/FloatPoint.h:
  • platform/graphics/FloatRect.cpp:

(WebCore::FloatRect::FloatRect):
Add explicit FloatRectFractionalLayoutRect) constructor.

  • platform/graphics/FloatRect.h:

(WebCore):
(FloatRect):

  • platform/graphics/FloatSize.cpp:

(WebCore::FloatSize::FloatSize):
Add explicit FloatSize(FractionalLayoutSize) constructor.

  • platform/graphics/FloatSize.h:
  • platform/graphics/FractionalLayoutPoint.h: Added.
  • platform/graphics/FractionalLayoutRect.cpp: Added.
  • platform/graphics/FractionalLayoutRect.h: Added.
  • platform/graphics/FractionalLayoutSize.cpp: Added.
  • platform/graphics/FractionalLayoutSize.h: Added.
  • platform/graphics/IntRect.cpp:

(WebCore::IntRect::IntRect):
Add explicit IntRect(FractionalLayoutRect) constructor.

  • platform/graphics/IntRect.h:
10:34 PM WebKitIDL edited by haraken@chromium.org
(diff)
10:14 PM Changeset in webkit [107886] by haraken@chromium.org
  • 9 edits
    2 adds in trunk

[Mac] PasteboardMac.mm build fails
​https://bugs.webkit.org/show_bug.cgi?id=78655

Reviewed by Enrica Casucci.

Source/WebCore:

This patch fixes the code to make a plain text for pasted file names.
The code should return a string of concatenated file names.

Test: editing/pasteboard/drag-files-to-editable-element.html

  • platform/mac/PasteboardMac.mm:

(WebCore::Pasteboard::plainText):

LayoutTests:

The added test drops multiple files onto an editable element,
and checks if the filenames are inserted into the editable element.

  • editing/pasteboard/drag-files-to-editable-element-expected.txt: Added.
  • editing/pasteboard/drag-files-to-editable-element.html: Added.
  • platform/chromium/test_expectations.txt:
  • platform/efl/Skipped:
  • platform/gtk/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
  • platform/wk2/Skipped:
10:10 PM Changeset in webkit [107885] by andersca@apple.com
  • 2 edits in trunk/Source/WebCore

Another attempt at fixing the Snow Leopard build.

  • platform/graphics/ca/mac/TileCache.mm:

(WebCore::TileCache::setContentsScale):

9:57 PM Changeset in webkit [107884] by loislo@chromium.org
  • 1 edit
    1 move
    3 adds
    1 delete in trunk/LayoutTests

[chromium] Unreviewed rebaseline after r107864.

  • platform/chromium-mac-snowleopard/svg/text/text-fill-opacity-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/text/text-fill-opacity-expected.txt: Added.
  • platform/chromium-mac/fast/canvas/text-globalAlpha-expected.txt: Removed.
  • platform/chromium-win/svg/text/text-fill-opacity-expected.png: Added.
  • platform/chromium-win/svg/text/text-fill-opacity-expected.txt: Renamed from LayoutTests/platform/chromium-linux/svg/text/text-fill-opacity-expected.txt.
9:42 PM Changeset in webkit [107883] by commit-queue@webkit.org
  • 6 edits
    2 adds in trunk

Add support for the translate attribute in html elements.
​https://bugs.webkit.org/show_bug.cgi?id=78751

Patch by Pablo Flouret <​pablof@motorola.com> on 2012-02-15
Reviewed by Adam Barth.

The translate attribute is used to specify whether an element's
attribute values and the values of its Text node children are to be
translated when the page is localized, or whether to leave them
unchanged.

Details at ​http://www.whatwg.org/specs/web-apps/current-work/multipage/elements.html#attr-translate

Source/WebCore:

Test: fast/dom/HTMLElement/translate.html

  • html/HTMLAttributeNames.in:
  • html/HTMLElement.cpp:

(WebCore::HTMLElement::translateAttributeMode):
(WebCore):
(WebCore::HTMLElement::translate):
(WebCore::HTMLElement::setTranslate):

  • html/HTMLElement.h:

(HTMLElement):

  • html/HTMLElement.idl:

LayoutTests:

  • fast/dom/HTMLElement/translate-expected.txt: Added.
  • fast/dom/HTMLElement/translate.html: Added.
9:39 PM WebKitIDL edited by haraken@chromium.org
(diff)
9:29 PM Changeset in webkit [107882] by noel.gordon@gmail.com
  • 2 edits in trunk/LayoutTests

Unreviewed. compositing/culling/scrolled-within-boxshadow.html IMAGE failure.

  • platform/chromium/test_expectations.txt:
9:09 PM Changeset in webkit [107881] by commit-queue@webkit.org
  • 16 edits
    3 adds in trunk

Source/WebCore: Add -webkit-overflow-scrolling CSS property
​https://bugs.webkit.org/show_bug.cgi?id=78664

Patch by Sami Kyostila <​skyostil@google.com> on 2012-02-15
Reviewed by Eric Seidel.

Add a CSS property indicating that an element with overflow scrolling
should follow the platform's behavior for touch scrollable user
interface objects. For instance, this property could enable momentum
scrolling for the element if that is the platform convention.

The property has two possible values: auto (default) and touch. The
former does not alter overflow scrolling behavior, while the latter
activates touch scrolling.

As a side effect, enabling touch scrolling also causes an element to
gain a stacking context. This is to allow the implementation to promote
the scrolling contents into a render layer, which can be translated more
efficiently.

This property was introduced with iOS 5 WebKit. Another implementation
is in Chrome for Android.

Test: platform/chromium/compositing/overflow/overflow-scrolling-touch-stacking-context.html

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):

  • css/CSSProperty.cpp:

(WebCore::CSSProperty::isInheritedProperty):

  • css/CSSPropertyNames.in:
  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::adjustRenderStyle):
(WebCore::CSSStyleSelector::applyProperty):

  • css/CSSValueKeywords.in:
  • rendering/style/RenderStyle.h:
  • rendering/style/StyleRareInheritedData.cpp:

(WebCore::StyleRareInheritedData::StyleRareInheritedData):
(WebCore::StyleRareInheritedData::operator==):

  • rendering/style/StyleRareInheritedData.h:

(StyleRareInheritedData):

Source/WebKit/chromium: Enable -webkit-overflow-scrolling CSS property
​https://bugs.webkit.org/show_bug.cgi?id=78664

Patch by Sami Kyostila <​skyostil@google.com> on 2012-02-15
Reviewed by Eric Seidel.

  • features.gypi:

LayoutTests: Add stacking context test for -webkit-overflow-scrolling CSS property
​https://bugs.webkit.org/show_bug.cgi?id=78664

Patch by Sami Kyostila <​skyostil@google.com> on 2012-02-15
Reviewed by Eric Seidel.

Make sure a stacking context is created for elements with touch overflow scrolling.

  • platform/chromium-win/fast/css/getComputedStyle/computed-style-expected.txt: Added new property.
  • platform/chromium-win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: Ditto.
  • platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt: Ditto.
  • platform/chromium/compositing/overflow/overflow-scrolling-touch-stacking-context-expected.png: Added.
  • platform/chromium/compositing/overflow/overflow-scrolling-touch-stacking-context-expected.txt: Added.
  • platform/chromium/compositing/overflow/overflow-scrolling-touch-stacking-context.html: Added.
8:49 PM Changeset in webkit [107880] by leviw@chromium.org
  • 21 edits in trunk/Source/WebCore

Add zeroLayoutUnit constant.
​https://bugs.webkit.org/show_bug.cgi?id=78747

Reviewed by Eric Seidel.

Converting call sites where LayoutUnits and raw zeros are in ternary operations
and templatized function calls (like std::max and min) to use a new zeroLayoutUnit
constant instead of the raw zero.

No new tests. No change in behavior.

  • rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::placeBoxesInBlockDirection):
(WebCore::InlineFlowBox::addBorderOutsetVisualOverflow):
(WebCore::InlineFlowBox::paintFillLayer):
(WebCore::InlineFlowBox::paintBoxDecorations):
(WebCore::InlineFlowBox::paintMask):
(WebCore::InlineFlowBox::computeOverAnnotationAdjustment):

  • rendering/LayoutTypes.h:

(WebCore):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::MarginInfo::MarginInfo):
(WebCore::RenderBlock::adjustFloatingBlock):
(WebCore::RenderBlock::paintColumnRules):
(WebCore::RenderBlock::nextFloatLogicalBottomBelow):
(WebCore::RenderBlock::getClearDelta):
(WebCore::RenderBlock::computeInlinePreferredLogicalWidths):
(WebCore::getHeightForLineCount):
(WebCore::RenderBlock::adjustForUnsplittableChild):

  • rendering/RenderBlock.h:

(WebCore::RenderBlock::paginationStrut):
(WebCore::RenderBlock::pageLogicalOffset):

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::LineLayoutState::updateRepaintRangeFromBox):
(WebCore::RenderBlock::addOverflowFromInlineChildren):

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::positionForPoint):

  • rendering/RenderBox.h:

(WebCore::RenderBox::minYVisualOverflow):
(WebCore::RenderBox::minXVisualOverflow):
(RenderBox):

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::offsetLeft):
(WebCore::RenderBoxModelObject::offsetTop):
(WebCore::RenderBoxModelObject::paintFillLayerExtended):

  • rendering/RenderFieldset.cpp:

(WebCore::RenderFieldset::paintBoxDecorations):

  • rendering/RenderFileUploadControl.cpp:

(WebCore::nodeWidth):

  • rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::layout):
(WebCore::RenderFlowThread::computeLogicalWidth):

  • rendering/RenderInline.cpp:

(WebCore::RenderInline::paintOutlineForLine):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::resize):

  • rendering/RenderListBox.cpp:

(WebCore::RenderListBox::listIndexAtOffset):
(WebCore::RenderListBox::verticalScrollbarWidth):

  • rendering/RenderMarquee.cpp:

(WebCore::RenderMarquee::computePosition):

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::repaintAfterLayoutIfNeeded):

  • rendering/RenderReplaced.cpp:

(WebCore::RenderReplaced::computePreferredLogicalWidths):

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::convertStyleLogicalWidthToComputedWidth):
(WebCore::RenderTable::layout):

  • rendering/RenderTable.h:

(WebCore::RenderTable::bordersPaddingAndSpacingInRowDirection):

  • rendering/mathml/RenderMathMLSubSup.cpp:

(WebCore::RenderMathMLSubSup::layout):

8:18 PM Changeset in webkit [107879] by ap@apple.com
  • 10 edits
    2 adds in trunk

Crash after trying to use FileReader in a document with null origin string
​https://bugs.webkit.org/show_bug.cgi?id=78649

Reviewed by Enrica Casucci.

Source/WebCore:

Test: fast/files/null-origin-string.html

  • fileapi/FileReaderLoader.cpp: (WebCore::FileReaderLoader::~FileReaderLoader):

HashMaps don't like empty keys, and they don't like removing keys that have never been added.

LayoutTests:

  • fast/files/null-origin-string-expected.txt: Added.
  • fast/files/null-origin-string.html: Added.

Dragging files is only implemented on a few platforms. Brought some order to skipped files
for these tests:

  • platform/mac/Skipped: Bug 45576 has been fixed long ago; unskip the test.
  • platform/efl/Skipped:
  • platform/qt/Skipped:

Skipped the new tests.

  • platform/gtk-wk2/Skipped:
  • platform/mac-wk2/Skipped:
  • platform/win-wk2/Skipped:
  • platform/wk2/Skipped:

Skipped the new tests, and moved other tests using eventSender.beginDragWithFiles to a
central location. No WK2 port implements these yet, so we needn't maintain the lists
separately.

7:57 PM Changeset in webkit [107878] by andersca@apple.com
  • 3 edits in trunk/Source/WebCore

Attempt to fix the Snow Leopard build.

  • platform/graphics/ca/mac/TileCache.mm:

(WebCore::TileCache::createTileLayer):

  • platform/graphics/ca/mac/WebTileCacheLayer.mm:

(-[WebTileCacheLayer setContentsScale:]):

7:57 PM Changeset in webkit [107877] by leo.yang@torchmobile.com.cn
  • 2 edits in trunk/Tools

Build fix after r107863.

  • DumpRenderTree/blackberry/PixelDumpSupportBlackBerry.cpp:
7:53 PM Changeset in webkit [107876] by noel.gordon@gmail.com
  • 11 edits
    3 moves
    5 adds
    11 deletes in trunk/LayoutTests

[chromium] Rebaseline JPEG image results after r107389
​https://bugs.webkit.org/show_bug.cgi?id=78454

Unreviewed. Rebaseline #14 of N.

  • platform/chromium-linux/tables/mozilla/bugs/bug15544-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug17138-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug15544-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug17138-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug120107-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug12908-2-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug15544-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug17138-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug196870-expected.png: Added.
  • platform/chromium-mac/tables/mozilla/bugs/bug120107-expected.png: Removed.
  • platform/chromium-mac/tables/mozilla/bugs/bug12908-2-expected.png: Removed.
  • platform/chromium-mac/tables/mozilla/bugs/bug15544-expected.png: Removed.
  • platform/chromium-mac/tables/mozilla/bugs/bug17138-expected.png: Removed.
  • platform/chromium-mac/tables/mozilla/bugs/bug196870-expected.png: Removed.
  • platform/chromium-win/tables/mozilla/bugs/bug120107-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug12908-2-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug15544-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug17138-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug196870-expected.png:
  • platform/chromium/test_expectations.txt:
  • platform/mac/tables/mozilla/bugs/bug120107-expected.txt: Removed.
  • platform/mac/tables/mozilla/bugs/bug12908-2-expected.txt: Removed.
  • platform/mac/tables/mozilla/bugs/bug196870-expected.txt: Removed.
  • platform/qt/tables/mozilla/bugs/bug120107-expected.txt: Removed.
  • platform/qt/tables/mozilla/bugs/bug12908-2-expected.txt: Removed.
  • platform/qt/tables/mozilla/bugs/bug196870-expected.txt: Removed.
  • tables/mozilla/bugs/bug120107-expected.txt: Renamed from LayoutTests/platform/gtk/tables/mozilla/bugs/bug120107-expected.txt.
  • tables/mozilla/bugs/bug12908-2-expected.txt: Renamed from LayoutTests/platform/gtk/tables/mozilla/bugs/bug12908-2-expected.txt.
  • tables/mozilla/bugs/bug196870-expected.txt: Renamed from LayoutTests/platform/gtk/tables/mozilla/bugs/bug196870-expected.txt.
7:52 PM Changeset in webkit [107875] by tony@chromium.org
  • 3 edits in trunk/Tools

[chromium] add linux dbg back to garden-o-matic
​https://bugs.webkit.org/show_bug.cgi?id=78752

Reviewed by Adam Barth.

This reflects the current linux debug bot name (there's only one bot).
I'm also remove the mac clang builder since it doesn't exist (mac
always uses clang now).

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
  • Scripts/webkitpy/layout_tests/port/builders.py:
7:32 PM Changeset in webkit [107874] by mitz@apple.com
  • 7 edits in trunk/Source/WebCore

REGRESSION (r107836): fast/box-shadow/spread.html and fast/writing-mode/box-shadow-*.html tests failing
​https://bugs.webkit.org/show_bug.cgi?id=78759

Reviewed by Simon Fraser.

  • rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::boxShadowCanBeAppliedToBackground): Added. Returns false if
paintFillLayer() would push a clip before painting the layer, thus preventing it from casting
its own shadow.
(WebCore::InlineFlowBox::paintBoxDecorations): Pass this as an additional parameter to
boxShadowShouldBeAppliedToBackground().

  • rendering/InlineFlowBox.h:
  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::paintFillLayerExtended): Pass the InlineFlowBox along to
boxShadowShouldBeAppliedToBackground().
(WebCore::RenderBoxModelObject::boxShadowShouldBeAppliedToBackground): Added an InlineFlowBox
parameter. If non-0, check boxShadowCanBeAppliedToBackground(). Also check for shadow spread,
and for the case of border radius with a background image, in which paintFillLayerExtended uses
clipping. Finally, fixed a bug in the for() loop for finding the last background layer which
was noticed by Tony Chang.

  • rendering/RenderBoxModelObject.h:
  • rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::boxShadowShouldBeAppliedToBackground):

  • rendering/RenderTableCell.h:
7:27 PM Changeset in webkit [107873] by leo.yang@torchmobile.com.cn
  • 1 edit
    2 adds in trunk/Source/WebKit

[BlackBerry] Upstream WebPageGroupLoadDeferrer.{h, cpp}
​https://bugs.webkit.org/show_bug.cgi?id=78770

Reviewed by Rob Buis.

Initial upstreaming, no new tests.

  • blackberry/Api/WebPageGroupLoadDeferrer.cpp: Added.
  • blackberry/Api/WebPageGroupLoadDeferrer.h: Added.
7:18 PM Changeset in webkit [107872] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

Add style check for ctype functions that are generally frowned upon in WebKit
​https://bugs.webkit.org/show_bug.cgi?id=78748

Patch by Sam Weinig <​sam@webkit.org> on 2012-02-15
Reviewed by Anders Carlsson.

Not every platform has DisallowCType.h to check for uses of the ctype.h
functions, so add a style check for them as well.

  • Scripts/webkitpy/style/checkers/cpp.py:

(check_ctype_functions):
(check_style):
(CppChecker):
Add check.

  • Scripts/webkitpy/style/checkers/cpp_unittest.py:

(WebKitStyleTest.test_ctype_fucntion):
Add checker.

7:16 PM Changeset in webkit [107871] by commit-queue@webkit.org
  • 1 edit
    2 adds in trunk/Source/WebKit

[BlackBerry] Upstream BlackBerry specific Web Inspector resources
​https://bugs.webkit.org/show_bug.cgi?id=78727

Patch by Konrad Piascik <​kpiascik@rim.com> on 2012-02-15
Reviewed by Rob Buis.

  • blackberry/WebCoreSupport/inspectorBB.html: Added.
  • blackberry/WebCoreSupport/inspectorBB.js: Added.

():
(InspectorFrontendHost.copyText):

6:58 PM Changeset in webkit [107870] by commit-queue@webkit.org
  • 1 edit
    2 adds in trunk/Source/WebKit

Initial upstreaming of EditorClientBlackBerry
​https://bugs.webkit.org/show_bug.cgi?id=78730

Patch by Mike Fenton <​mifenton@rim.com> on 2012-02-15
Reviewed by Rob Buis.

Initial upstreaming, no new tests.

  • blackberry/WebCoreSupport/EditorClientBlackBerry.cpp: Added.

(WebCore):
(WebCore::EditorClientBlackBerry::EditorClientBlackBerry):
(WebCore::EditorClientBlackBerry::pageDestroyed):
(WebCore::EditorClientBlackBerry::shouldDeleteRange):
(WebCore::EditorClientBlackBerry::shouldShowDeleteInterface):
(WebCore::EditorClientBlackBerry::smartInsertDeleteEnabled):
(WebCore::EditorClientBlackBerry::isSelectTrailingWhitespaceEnabled):
(WebCore::EditorClientBlackBerry::enableSpellChecking):
(WebCore::EditorClientBlackBerry::shouldSpellCheckFocusedField):
(WebCore::EditorClientBlackBerry::isContinuousSpellCheckingEnabled):
(WebCore::EditorClientBlackBerry::toggleContinuousSpellChecking):
(WebCore::EditorClientBlackBerry::isGrammarCheckingEnabled):
(WebCore::EditorClientBlackBerry::toggleGrammarChecking):
(WebCore::EditorClientBlackBerry::spellCheckerDocumentTag):
(WebCore::EditorClientBlackBerry::shouldBeginEditing):
(WebCore::EditorClientBlackBerry::shouldEndEditing):
(WebCore::EditorClientBlackBerry::shouldInsertNode):
(WebCore::EditorClientBlackBerry::shouldInsertText):
(WebCore::EditorClientBlackBerry::shouldChangeSelectedRange):
(WebCore::EditorClientBlackBerry::shouldApplyStyle):
(WebCore::EditorClientBlackBerry::shouldMoveRangeAfterDelete):
(WebCore::EditorClientBlackBerry::didBeginEditing):
(WebCore::EditorClientBlackBerry::respondToChangedContents):
(WebCore::EditorClientBlackBerry::respondToChangedSelection):
(WebCore::EditorClientBlackBerry::didEndEditing):
(WebCore::EditorClientBlackBerry::respondToSelectionAppearanceChange):
(WebCore::EditorClientBlackBerry::didWriteSelectionToPasteboard):
(WebCore::EditorClientBlackBerry::didSetSelectionTypesForPasteboard):
(WebCore::EditorClientBlackBerry::registerCommandForUndo):
(WebCore::EditorClientBlackBerry::registerCommandForRedo):
(WebCore::EditorClientBlackBerry::clearUndoRedoOperations):
(WebCore::EditorClientBlackBerry::canUndo):
(WebCore::EditorClientBlackBerry::canRedo):
(WebCore::EditorClientBlackBerry::canCopyCut):
(WebCore::EditorClientBlackBerry::canPaste):
(WebCore::EditorClientBlackBerry::undo):
(WebCore::EditorClientBlackBerry::redo):
(KeyDownEntry):
(KeyPressEntry):
(WebCore::EditorClientBlackBerry::interpretKeyEvent):
(WebCore::EditorClientBlackBerry::handleKeyboardEvent):
(WebCore::EditorClientBlackBerry::handleInputMethodKeydown):
(WebCore::EditorClientBlackBerry::textFieldDidBeginEditing):
(WebCore::EditorClientBlackBerry::textFieldDidEndEditing):
(WebCore::EditorClientBlackBerry::textDidChangeInTextField):
(WebCore::EditorClientBlackBerry::doTextFieldCommandFromEvent):
(WebCore::EditorClientBlackBerry::textWillBeDeletedInTextField):
(WebCore::EditorClientBlackBerry::textDidChangeInTextArea):
(WebCore::EditorClientBlackBerry::ignoreWordInSpellDocument):
(WebCore::EditorClientBlackBerry::learnWord):
(WebCore::EditorClientBlackBerry::checkSpellingOfString):
(WebCore::EditorClientBlackBerry::getAutoCorrectSuggestionForMisspelledWord):
(WebCore::EditorClientBlackBerry::checkGrammarOfString):
(WebCore::EditorClientBlackBerry::requestCheckingOfString):
(WebCore::EditorClientBlackBerry::textChecker):
(WebCore::EditorClientBlackBerry::updateSpellingUIWithGrammarString):
(WebCore::EditorClientBlackBerry::updateSpellingUIWithMisspelledWord):
(WebCore::EditorClientBlackBerry::showSpellingUI):
(WebCore::EditorClientBlackBerry::spellingUIIsShowing):
(WebCore::EditorClientBlackBerry::getGuessesForWord):
(WebCore::EditorClientBlackBerry::willSetInputMethodState):
(WebCore::EditorClientBlackBerry::setInputMethodState):

  • blackberry/WebCoreSupport/EditorClientBlackBerry.h: Added.

(WebKit):
(WebCore):
(EditorClientBlackBerry):

6:47 PM Changeset in webkit [107869] by arv@chromium.org
  • 3 edits
    2 adds in trunk

Expose Window constructor
​https://bugs.webkit.org/show_bug.cgi?id=78722

Reviewed by Adam Barth.

Source/WebCore:

Test: fast/dom/Window/window-constructor-presence.html

  • page/DOMWindow.idl:

LayoutTests:

  • fast/dom/Window/window-constructor-presence-expected.txt: Added.
  • fast/dom/Window/window-constructor-presence.html: Added.
6:43 PM Changeset in webkit [107868] by commit-queue@webkit.org
  • 3 edits in trunk

[Qt][WK2] WebKitTestRunner should use 480x360 sized view for W3C SVG tests
​https://bugs.webkit.org/show_bug.cgi?id=76546

Patch by Szilard Ledan <​Ledan-Muntean.Szilard@stud.u-szeged.hu> on 2012-02-15
Reviewed by Simon Hausmann.

Resize the web view programatically because the declarative property binding
does not work. Seems like our qml environment is not initialized fully but it
needs more investigation.

  • WebKitTestRunner/qt/PlatformWebViewQt.cpp:

(WTR::WrapperWindow::handleStatusChanged):
(WTR::PlatformWebView::resizeTo):

6:41 PM Changeset in webkit [107867] by dpranke@chromium.org
  • 6 edits in trunk/Tools

webkitpy: add a worker_args concept to start_worker()
​https://bugs.webkit.org/show_bug.cgi?id=78572

Reviewed by Tony Chang.

This change replaces the three NRWT-specific arguments passed
through the broker to the worker with a generic WorkerArguments
wrapper class and a separate set_inline_arguments() call that can
be used to pass additional data to the worker when it is running
in the same process as the manager (this is needed for testing).
With the addition of set_inline_arguments() we also no longer
need to pass an optional argument to the worker.run() call.

Note that this method is *only* implemented on inline workers,
so calling this on a regular (child process) worker will result
in a runtime error.

  • Scripts/webkitpy/layout_tests/controllers/manager.py:

(Manager._run_tests):

  • Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:

(AbstractWorker.init):
(AbstractWorker.run):
(_ManagerConnection.start_worker):
(_InlineManager.start_worker):
(_InlineManager.set_inline_arguments):
(_InlineManager.run_message_loop):
(_MultiProcessManager.start_worker): Reworked signature.
(_WorkerConnection.init):
(_InlineWorkerConnection.init):
(_InlineWorkerConnection.set_inline_arguments): New method.
(_InlineWorkerConnection):
(_InlineWorkerConnection.run):
(_Process.run):
(_MultiProcessWorkerConnection.init):

  • Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:

(_TestWorker.init):
(_TestWorker.set_inline_arguments):
(_TestWorker.handle_test):
(_TestWorker.run):
(_TestsMixin.test_cancel):
(_TestsMixin.test_done):
(_TestsMixin.test_unknown_message):
(InlineBrokerTests): New class for more testing.
(InlineBrokerTests.setUp):
(InlineBrokerTests.test_inline_arguments): New test.
(InterfaceTest.test_managerconnection_is_abstract):
(InterfaceTest.test_workerconnection_is_abstract):

  • Scripts/webkitpy/layout_tests/controllers/worker.py:

(WorkerArguments):
(WorkerArguments.init):
(Worker.init):
(Worker.set_inline_arguments):
(Worker):
(Worker.run):

  • Scripts/webkitpy/layout_tests/controllers/worker_unittest.py:

(WorkerTest.test_default_platform_in_worker):

6:25 PM Changeset in webkit [107866] by eae@chromium.org
  • 1 edit in branches/subpixellayout/Source/WebCore/platform/FractionalLayoutUnit.h

Readd std constructs for FractionalLayoutUnit on branch, for now

6:24 PM Changeset in webkit [107865] by leviw@chromium.org
  • 1 edit in branches/subpixellayout/Source/WebCore/dom/ElementRareData.h

Fixing usages of INT_MAX with LayoutUnit max values.

6:23 PM WebKitIDL edited by haraken@chromium.org
(diff)
6:15 PM Changeset in webkit [107864] by knorton@google.com
  • 4 edits
    3 adds in trunk

fill-opacity does not render properly only on Chromium Mac.
​https://bugs.webkit.org/show_bug.cgi?id=78624

Reviewed by Stephen White.

Source/WebCore:

Test: svg/text/text-fill-opacity.svg

  • platform/graphics/skia/FontSkia.cpp:

(WebCore::Font::drawGlyphs):

LayoutTests:

  • platform/chromium-linux/svg/text/text-fill-opacity-expected.png: Added.
  • platform/chromium-linux/svg/text/text-fill-opacity-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
  • svg/text/text-fill-opacity.svg: Added.
6:02 PM Changeset in webkit [107863] by leo.yang@torchmobile.com.cn
  • 5 edits
    1 add in trunk/Source

[BlackBerry] Upstream WebPageClient.h
​https://bugs.webkit.org/show_bug.cgi?id=78660

Reviewed by Antonio Gomes.

Source/WebCore:

Header inclusion fix, no new test.

  • plugins/blackberry/PluginViewPrivateBlackBerry.h:

Add #include <BlackBerryPlatformIntRectRegion.h>
and #include <BlackBerryPlatformGraphics.h> because they
are being removed from WebKit/blackberry/Api/WebPageClient.h.

Source/WebKit:

Initial upstreaming, no new tests.

  • blackberry/Api/BackingStore.cpp: Add #include <BlackBerryPlatformWindow.h> because this inclusion

is being removed from WebPageClient.h.

  • blackberry/Api/WebPageClient.h: Added.
  • blackberry/WebCoreSupport/ChromeClientBlackBerry.cpp: Add #include <BlackBerryPlatformWindow.h>

because this inclusion is being removed from WebPageClient.h.

5:50 PM Changeset in webkit [107862] by timothy_horton@apple.com
  • 4 edits
    3 adds in trunk

REGRESSION(r105057): Dynamically changing <tspan> offsets is broken
​https://bugs.webkit.org/show_bug.cgi?id=78385
<rdar://problem/10832932>

Reviewed by Simon Fraser.

Don't short-circuit buildLayoutAttributesIfNeeded if m_textPositions is already full;
we can't skip rebuilding the layout attributes, just walking the tree to acquire the
positioning lists (invalidation of positioning lists is already covered by textDOMChanged).

Test: svg/text/tspan-dynamic-positioning.svg

  • rendering/svg/SVGTextLayoutAttributesBuilder.cpp:

(WebCore::SVGTextLayoutAttributesBuilder::buildLayoutAttributesIfNeeded):

Add a test ensuring that changing the offset of a <tspan> post-load results in correct layout.

  • platform/chromium/test_expectations.txt:
  • platform/mac/svg/text/tspan-dynamic-positioning-expected.png: Added.
  • platform/mac/svg/text/tspan-dynamic-positioning-expected.txt: Added.
  • svg/text/tspan-dynamic-positioning.svg: Added.
5:35 PM Changeset in webkit [107861] by tommyw@google.com
  • 9 edits in trunk/Source

MediaStream API: Removing SecurityContext from the embedder API
​https://bugs.webkit.org/show_bug.cgi?id=73816

Reviewed by Darin Fisher.

Source/WebCore:

Tests for the Media Stream API will be provided by the bug 56587, pending enough landed code.

  • mediastream/PeerConnection.cpp:

(WebCore::PeerConnection::PeerConnection):

  • platform/mediastream/PeerConnectionHandler.h:

(WebCore):
(PeerConnectionHandler):

  • platform/mediastream/gstreamer/PeerConnectionHandler.cpp:

(WebCore::PeerConnectionHandler::create):
(WebCore::PeerConnectionHandler::PeerConnectionHandler):

Source/WebKit/chromium:

  • bridge/PeerConnectionHandler.cpp:

(WebCore::PeerConnectionHandler::create):
(WebCore::PeerConnectionHandler::PeerConnectionHandler):

  • bridge/PeerConnectionHandlerInternal.cpp:

(WebCore::PeerConnectionHandlerInternal::PeerConnectionHandlerInternal):

  • bridge/PeerConnectionHandlerInternal.h:

(WebCore):
(PeerConnectionHandlerInternal):

  • public/platform/WebPeerConnectionHandler.h:

(WebPeerConnectionHandler):
(WebKit::WebPeerConnectionHandler::initialize):

5:29 PM Changeset in webkit [107860] by oliver@apple.com
  • 10 edits in trunk/Source/JavaScriptCore

Ensure that the DFG JIT always plants a CodeOrigin when making calls
​https://bugs.webkit.org/show_bug.cgi?id=78763

Reviewed by Gavin Barraclough.

Make all calls plant a CodeOrigin prior to the actual
call. Also clobbers the Interpreter with logic to ensure
that the interpreter always plants a bytecode offset.

  • dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::link):
(JSC::DFG::JITCompiler::compileFunction):

  • dfg/DFGJITCompiler.h:

(CallBeginToken):
(JSC::DFG::JITCompiler::beginJSCall):
(JSC::DFG::JITCompiler::beginCall):

  • dfg/DFGRepatch.cpp:

(JSC::DFG::tryBuildGetByIDList):

  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::appendCallWithExceptionCheck):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::emitCall):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::emitCall):

  • interpreter/AbstractPC.cpp:

(JSC::AbstractPC::AbstractPC):

  • interpreter/CallFrame.cpp:

(JSC::CallFrame::trueCallFrame):

  • interpreter/CallFrame.h:

(JSC::ExecState::bytecodeOffsetForNonDFGCode):
(ExecState):
(JSC::ExecState::setBytecodeOffsetForNonDFGCode):
(JSC::ExecState::codeOriginIndexForDFG):

5:19 PM Changeset in webkit [107859] by Nate Chapin
  • 5 edits in trunk

Source/WebCore: Fix test regressons from r107672.
​https://bugs.webkit.org/show_bug.cgi?id=76564

Move setting CachedRawResource::m_identifer from
data() to setResponse(). WorkerScriptLoader depends
on the identifier being set correctly during setResponse()
in order to correctly mark itself as a ScriptResource in
the inspector.

Reviewed by Adam Barth.

Fixes several worker script loading tests.

  • loader/cache/CachedRawResource.cpp:

(WebCore::CachedRawResource::data):
(WebCore::CachedRawResource::setResponse):

LayoutTests: Remove Skipped tests that were broken by r107672.
​https://bugs.webkit.org/show_bug.cgi?id=76564

Reviewed by Adam Barth.

  • platform/gtk/Skipped:
  • platform/qt/Skipped:
5:06 PM Changeset in webkit [107858] by adamk@chromium.org
  • 4 edits in trunk/Tools

Unreviewed, rolling out r107704.
​http://trac.webkit.org/changeset/107704
​https://bugs.webkit.org/show_bug.cgi?id=78486

Caused layout test crashes in debug builds.

Specific crashing tests:

fast/events/show-modal-dialog-onblur-onfocus.html
fast/harness/show-modal-dialog.html
inspector/console/console-long-eval-crash.html

  • DumpRenderTree/chromium/TestShell.cpp:

(TestShell::TestShell):

  • DumpRenderTree/chromium/TestShell.h:

(TestShell):

  • DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::runModal):

4:47 PM Changeset in webkit [107857] by tony@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Unreviewed. regionOverflow tests are flaky in debug.

  • platform/chromium/test_expectations.txt:
4:45 PM Changeset in webkit [107856] by enrica@apple.com
  • 2 edits in trunk/Source/WebCore

REGRESSION: "Copy image" fails...copies image URL instead.
​https://bugs.webkit.org/show_bug.cgi?id=78723
<rdar://problem/10869104>

During the refactoring of the Pasteboard class some code was lost.
When placing an NSImage in the NSPasteboard as NSTIFFPboardType, we need
to use the its TIFF representation.

Reviewed by Andy Estes.

  • platform/mac/PasteboardMac.mm:

(WebCore::Pasteboard::writeImage):

4:39 PM Changeset in webkit [107855] by rwlbuis@webkit.org
  • 1 edit
    1 move in trunk/Source/WebKit

[BlackBerry] Upstream remaining classes in Api
​https://bugs.webkit.org/show_bug.cgi?id=78644

Reviewed by Antonio Gomes.

No functionalities changed, no new tests.

  • blackberry/Api/ActiveNodeContext.h: Renamed from Source/WebKit/blackberry/Api/BlackBerryContext.h.
4:27 PM Changeset in webkit [107854] by kubo@profusion.mobi
  • 16 edits
    2 copies in trunk/Source

[soup] Add support for multiple SoupSessions.
​https://bugs.webkit.org/show_bug.cgi?id=77341

Source/WebCore:

Reviewed by Gustavo Noronha Silva.

Make the libsoup network backend support multiple SoupSessions. This is
accomplished by using the NetworkingContext classes, which now have a
`soupSession()' method when the libsoup backend is being used.

libsoup's ResourceHandle implementation now retrieves the SoupSession
via the NetworkingContext it receives instead of relying on
defaultSession(). defaultSession() is still used when a null
NetworkingContext is passed to ResourceHandle::start (for example, via
webkit_download_start).

The CookieJar implementation retrieves the SoupSession from the
NetworkingContext as much as possible as well -- the functions used by
WebKit2 could not be converted, though, as they seem to assume there is
only one shared cookie jar.

No new tests, covered by the existing ones.

  • platform/network/NetworkingContext.h:

(NetworkingContext): Add soupSession() method if USE(SOUP) is set.

  • platform/network/ResourceHandleInternal.h:

(ResourceHandleInternal):

  • platform/network/soup/CookieJarSoup.cpp:

(WebCore::cookieJarForDocument):
(WebCore):
(WebCore::defaultCookieJar):
(WebCore::setCookies):
(WebCore::cookies):
(WebCore::cookieRequestHeaderFieldValue):
(WebCore::cookiesEnabled):

  • platform/network/soup/ResourceHandleSoup.cpp:

(WebCore::ResourceHandleInternal::soupSession): Add method to retrieve
a SoupSession from a NetworkingContext and fallback to defaultSession()
if there's no valid NetworkingContext.
(WebCore):
(WebCore::ensureSessionIsInitialized): Only change or use the default
cookie jar if the SoupSession being changed is the default one.
(WebCore::sendRequestCallback):
(WebCore::startHTTPRequest):
(WebCore::ResourceHandle::cancel):
(WebCore::startNonHTTPRequest):

Source/WebKit/efl:

Add the necessary infrastructure to support multiple SoupSessions. Each
WebView now has a "session" property, which defaults to
ResourceHandle::defaultSession() and can be changed to another
SoupSession by the user.

Some API in ewk_network and ewk_view which required SoupSession to be a
valid type in the headers has now been moved inside #if USE(SOUP)
ifdefs so we can actually the required Soup header and avoid build
problems with duplicate typedefs.

  • CMakeListsEfl.txt:
  • WebCoreSupport/FrameLoaderClientEfl.cpp:

(WebCore::FrameLoaderClientEfl::createNetworkingContext):

  • WebCoreSupport/FrameNetworkingContextEfl.cpp: Copied from Source/WebKit/efl/WebCoreSupport/FrameNetworkingContextEfl.h.

(WebCore):
(WebCore::FrameNetworkingContextEfl::create):
(WebCore::FrameNetworkingContextEfl::FrameNetworkingContextEfl):
(WebCore::FrameNetworkingContextEfl::soupSession):

  • WebCoreSupport/FrameNetworkingContextEfl.h:

(FrameNetworkingContextEfl):

  • ewk/ewk_cookies.h: Mention this API is only valid with the

default SoupSession.

  • ewk/ewk_network.cpp:

(ewk_network_default_soup_session_get): Define only if USE(SOUP) is set.

  • ewk/ewk_network.h: Ditto, and mention this API is only valid with the

default SoupSession.

  • ewk/ewk_view.cpp:

(_Ewk_View_Private_Data):
(_ewk_view_priv_new):
(ewk_view_soup_session_get):
(ewk_view_soup_session_set):

  • ewk/ewk_view.h:

():

Source/WebKit/gtk:

Reviewed by Gustavo Noronha Silva.

Adapt to the changes to FrameNetworkingContext in WebCore.

  • GNUmakefile.am:
  • WebCoreSupport/FrameNetworkingContextGtk.cpp: Copied from Source/WebKit/gtk/WebCoreSupport/FrameNetworkingContextGtk.h.

(WebKit):
(WebKit::FrameNetworkingContextGtk::soupSession): Always return ResourceHandle::defaultSession().

  • WebCoreSupport/FrameNetworkingContextGtk.h:

(FrameNetworkingContextGtk):

4:08 PM Changeset in webkit [107853] by leviw@chromium.org
  • 1 edit in branches/subpixellayout/Source/WebCore/platform/ScrollView.h

Removing unused methods conversion methods from ScrollView.

4:01 PM Changeset in webkit [107852] by andersca@apple.com
  • 4 edits in trunk/Source/WebCore

The TileCache object should be deallocated on the main thread
​https://bugs.webkit.org/show_bug.cgi?id=78757
<rdar://problem/10866161>

Reviewed by Sam Weinig.

Since the WebTileCacheLayer can be deleted on the scrolling thread, we need to make sure that the underlying
TileCache object is actually destroyed on the main thread.

  • platform/graphics/ca/mac/TileCache.h:
  • platform/graphics/ca/mac/TileCache.mm:

(WebCore::TileCache::~TileCache):
Assert that this object is being destroyed on the main thread.

  • platform/graphics/ca/mac/WebTileCacheLayer.mm:

(-[WebTileCacheLayer dealloc]):
If dealloc is being called from a non-main thread, make sure to delete the tile cache object on the main thread.

3:58 PM Changeset in webkit [107851] by tony@chromium.org
  • 14 edits in trunk/LayoutTests

[chromium] Unreviewed, rebasing tests after r107836.

  • platform/chromium-linux-x86/fast/css/box-shadow-and-border-radius-expected.png:
  • platform/chromium-linux/fast/css/box-shadow-and-border-radius-expected.png:
  • platform/chromium-linux/fast/transforms/shadows-expected.png:
  • platform/chromium-mac-leopard/fast/css/box-shadow-and-border-radius-expected.png:
  • platform/chromium-mac-leopard/fast/transforms/shadows-expected.png:
  • platform/chromium-mac-snowleopard/fast/css/box-shadow-and-border-radius-expected.png:
  • platform/chromium-mac-snowleopard/fast/transforms/shadows-expected.png:
  • platform/chromium-win-vista/fast/css/box-shadow-and-border-radius-expected.png:
  • platform/chromium-win-xp/fast/css/box-shadow-and-border-radius-expected.png:
  • platform/chromium-win/fast/box-shadow/border-radius-big-expected.png:
  • platform/chromium-win/fast/css/box-shadow-and-border-radius-expected.png:
  • platform/chromium-win/fast/transforms/shadows-expected.png:
  • platform/chromium/test_expectations.txt:
3:54 PM Changeset in webkit [107850] by peter@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[Chromium] Roll DEPS to r122122
​https://bugs.webkit.org/show_bug.cgi?id=78754

Unreviewed DEPS roll.

  • DEPS:
3:47 PM Changeset in webkit [107849] by andersca@apple.com
  • 2 edits in trunk/Source/WebCore

Scrolling Coordinator must be deleted on the main thread
​https://bugs.webkit.org/show_bug.cgi?id=78756
<rdar://problem/10866167>

Reviewed by Sam Weinig.

ScrollingTree::invalidate will finish breaking the cycle between the scrolling coordinator and the
scrolling tree by dereffing the scrolling coordinator. We need to make sure that this happens on the main
thread because the scrolling coordinator expects to be destroyed from there.

  • page/scrolling/ScrollingTree.cpp:

(WebCore::derefScrollingCoordinator):
(WebCore):
(WebCore::ScrollingTree::invalidate):

3:45 PM SettingUpDevelopmentEnvironmentForN9 edited by vestbo@webkit.org
(diff)
3:37 PM Changeset in webkit [107848] by andersca@apple.com
  • 5 edits in trunk/Source/WebCore

Scrolling coordinator should handle pages being restored from the page cache
​https://bugs.webkit.org/show_bug.cgi?id=78753
<rdar://problem/10866171>

Reviewed by Sam Weinig.

Replace ScrollingCoordinator::frameViewScrollLayerDidChange with a new member function,
ScrollingCoordinator::frameViewRootLayerDidChange which is called whenever the root layer
of the frame view changes (which happens on back/forward navigation as well).

In this function, reset the scrolling tree state from the frame view.

  • page/scrolling/ScrollingCoordinator.cpp:

(WebCore::scrollLayerForFrameView):
Add a helper function.

(WebCore::ScrollingCoordinator::frameViewRootLayerDidChange):
Reset the entire scrolling tree state.

(WebCore::ScrollingCoordinator::updateMainFrameScrollPositionAndScrollLayerPosition):
Call the newly added helper function.

  • page/scrolling/ScrollingCoordinator.h:

(ScrollingCoordinator):

  • page/scrolling/mac/ScrollingCoordinatorMac.mm:

Remove frameViewScrollLayerDidChange.

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::ensureRootLayer):
Remove call to ScrollingCoordinator::frameViewScrollLayerDidChange.

(WebCore::RenderLayerCompositor::attachRootLayer):
Call ScrollingCoordinator::frameViewRootLayerDidChange.

3:36 PM Changeset in webkit [107847] by Lucas Forschler
  • 4 edits in branches/safari-534.54-branch/Source/WebKit2

Merge 10574154.

3:14 PM Changeset in webkit [107846] by dcheng@chromium.org
  • 3 edits in trunk/Source/WebKit/chromium

[chromium] Add setter/getter to expose drag data as a list of items
​https://bugs.webkit.org/show_bug.cgi?id=77125

This change supports the unification of the data store backing ChromiumDataObject and
DataTransferItemListChromium. ChromiumDataObject will represent dragging and clipboard data
as a list of data nodes to make it more straightforward to implement the HTML spec for
DataTransferItemList. Thus, we extend the abstraction to the webkit glue layer to
simplify the serialization/deserialization between platform-specific data and WebDragData.
The other setter/getter methods are deprecated and will be removed once the dependencies in
Chromium code are gone.

Reviewed by Darin Fisher.

  • public/platform/WebDragData.h:

(WebKit):
(WebDragData):

  • src/WebDragData.cpp:

(WebKit::WebDragData::items):
(WebKit):
(WebKit::WebDragData::setItems):
(WebKit::WebDragData::addItem):

3:10 PM Changeset in webkit [107845] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit2

Add TiledCoreAnimationDrawingArea::forceRepaint
​https://bugs.webkit.org/show_bug.cgi?id=78749
<rdar://problem/10866221>

Reviewed by Sam Weinig.

  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:
  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:

(WebKit::TiledCoreAnimationDrawingArea::forceRepaint):
Force a repaint and synchronize the layer tree to the UI process.

3:08 PM Changeset in webkit [107844] by enrica@apple.com
  • 21 edits in trunk/Source

Refactor ClipboardMac class to use PlatformStrategies.
​https://bugs.webkit.org/show_bug.cgi?id=78554

Reviewed by Anders Carlsson.

Source/WebCore:

No new tests. No change in behavior.

  • WebCore.exp.in: Added new exported methods of the PlatformPasteboard class
  • editing/mac/EditorMac.mm:

(WebCore::Editor::newGeneralClipboard): Use name based pasteboard references.

  • page/DragClient.h:

(WebCore::DragClient::declareAndWriteDragImage): Ditto.

  • page/mac/EventHandlerMac.mm:

(WebCore::EventHandler::createDraggingClipboard): Ditto.

  • platform/PasteboardStrategy.h: Added new methods to get a unique pasteboard name

and the pasteboard change count.

  • platform/PlatformPasteboard.h: Ditto.
  • platform/mac/ClipboardMac.h:

(WebCore::ClipboardMac::create): Using name based pasteboard.
(WebCore::ClipboardMac::pasteboardName): Replacing the old pasteboard() method.

  • platform/mac/ClipboardMac.mm: All the methods below have been modified to avoid

using Objective-C types and direct access to NSPasteboard object.
(WebCore::Clipboard::create):
(WebCore::ClipboardMac::ClipboardMac):
(WebCore::ClipboardMac::hasData):
(WebCore::cocoaTypeFromHTMLClipboardType):
(WebCore::utiTypeFromCocoaType):
(WebCore::addHTMLClipboardTypesForCocoaType):
(WebCore::ClipboardMac::clearData):
(WebCore::ClipboardMac::clearAllData):
(WebCore::absoluteURLsFromPasteboardFilenames):
(WebCore::absoluteURLsFromPasteboard):
(WebCore::ClipboardMac::getData):
(WebCore::ClipboardMac::setData):
(WebCore::ClipboardMac::types):
(WebCore::ClipboardMac::files):
(WebCore::ClipboardMac::setDragImage):
(WebCore::ClipboardMac::writeRange):
(WebCore::ClipboardMac::writePlainText):
(WebCore::ClipboardMac::writeURL):
(WebCore::ClipboardMac::declareAndWriteDragImage):

  • platform/mac/PasteboardMac.mm:

(WebCore::Pasteboard::writeClipboard): Using name based pasteboard reference.

  • platform/mac/PlatformPasteboardMac.mm:

(WebCore::PlatformPasteboard::getPathnamesForType): Fixed to support NSArray and NString content.
(WebCore::PlatformPasteboard::changeCount): Added.
(WebCore::PlatformPasteboard::uniqueName): Added.

Source/WebKit/mac:

  • WebCoreSupport/WebDragClient.h: Changed methods signature to use name based pasteboard.
  • WebCoreSupport/WebDragClient.mm: Ditto.

(WebDragClient::willPerformDragSourceAction):
(WebDragClient::startDrag):
(WebDragClient::declareAndWriteDragImage):

  • WebCoreSupport/WebPlatformStrategies.h: Added new methods.
  • WebCoreSupport/WebPlatformStrategies.mm:

(WebPlatformStrategies::changeCount):
(WebPlatformStrategies::uniqueName):

Source/WebKit2:

  • WebProcess/WebCoreSupport/WebDragClient.h: Changed method signature to reference

the pasteboard by name.

  • WebProcess/WebCoreSupport/WebPlatformStrategies.cpp: Added new methods.

(WebKit::WebPlatformStrategies::changeCount):
(WebKit::WebPlatformStrategies::uniqueName):

  • WebProcess/WebCoreSupport/WebPlatformStrategies.h: Ditto.
  • WebProcess/WebCoreSupport/mac/WebDragClientMac.mm:

(WebKit::WebDragClient::declareAndWriteDragImage): Changed method signature to reference
the pasteboard by name.

2:48 PM Changeset in webkit [107843] by andersca@apple.com
  • 4 edits in trunk/Source/WebCore

TileCache needs to support setting the contents scale
​https://bugs.webkit.org/show_bug.cgi?id=78741
<rdar://problem/10710773>

Reviewed by Sam Weinig.

  • platform/graphics/ca/mac/TileCache.h:
  • platform/graphics/ca/mac/TileCache.mm:

(WebCore::TileCache::setContentsScale):
Update the contents scale of all the tiles and then revalidate the tile cache since tiles
might have come and gone as a result of setting the contents scale.

(WebCore::TileCache::createTileLayer):
Set the contents scale of the tile layer.

  • platform/graphics/ca/mac/WebTileCacheLayer.mm:

(-[WebTileCacheLayer setContentsScale:]):
Call TileCache::setContentsScale.

2:36 PM Changeset in webkit [107842] by andersca@apple.com
  • 2 edits in trunk/Source/WebCore

Try to fix the Chromium build and remove a snarky comment in the process.

  • platform/chromium/PopupListBox.cpp:

(WebCore::PopupListBox::handleWheelEvent):

2:33 PM Changeset in webkit [107841] by eae@chromium.org
  • 4 edits in branches/subpixellayout/Source

Add LayoutUnit version of StylePropertySet::setProperty and change DeleteButtonController to use it.

2:14 PM Changeset in webkit [107840] by senorblanco@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening: mark a test as no longer MISSING.

  • platform/chromium/test_expectations.txt:
2:09 PM Changeset in webkit [107839] by tony@chromium.org
  • 6 edits in trunk/LayoutTests

Unreviewed gardening: Fix more results after r107833.

  • fast/css/getComputedStyle/computed-style-expected.txt:
  • fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/chromium-mac-snowleopard/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • svg/css/getComputedStyle-basic-expected.txt:
2:06 PM Changeset in webkit [107838] by andersca@apple.com
  • 7 edits in trunk/Source/WebCore

Wheel events should be re-dispatched to the scrolling thread
​https://bugs.webkit.org/show_bug.cgi?id=78731
<rdar://problem/10866144>

Reviewed by Sam Weinig.

When threaded scrolling is enabled, all the state is assumed to be kept in the scrolling tree,
on the scrolling thread. This means that even if we do end up processing an event on the main thread
(because of wheel event handlers for example), we still have to dispatch the wheel event back to the
scrolling thread.

  • page/FrameView.cpp:

(WebCore::FrameView::wheelEvent):
Move wheelEvent from ScrollView and ask the scrolling coordinator to handle the wheel event.

  • page/scrolling/ScrollingCoordinator.cpp:

(WebCore::ScrollingCoordinator::handleWheelEvent):
Dispatch the event to the scrolling thread, unless it will start a gesture. In that case we'll return false
so that information will be passed back to the UI process.

(ScrollingCoordinator):

  • platform/ScrollView.cpp:
  • platform/ScrollView.h:

Move wheelEvent to FrameView.

1:59 PM Changeset in webkit [107837] by mhahnenberg@apple.com
  • 2 edits in trunk/Source/WebCore

RootObject::finalize can cause a crash in object->invalidate()
​https://bugs.webkit.org/show_bug.cgi?id=78645

Reviewed by Geoffrey Garen.

No new tests.

  • bridge/runtime_root.cpp:

(JSC::Bindings::RootObject::finalize): Added a stack-allocated RefPtr to protect the RootObject
during the call to invalidate().

1:57 PM Changeset in webkit [107836] by mitz@apple.com
  • 10 edits in trunk/Source/WebCore

<rdar://problem/10870238> Box shadow drawing takes an unnecessarily slow code path in some single-shadow, opaque-background cases
​https://bugs.webkit.org/show_bug.cgi?id=78728

In some cases, when there is only one normal box shadow, and the box has an opaque background,
it is possible to draw the box shadow by having the background cast it directly. This appears
to be faster than the generic code path that uses a separate drawing pass to cast the shadow,
clipping out the border box and the shadow-casting box.

Reviewed by Dave Hyatt.

No new tests, because behavior is unchanged.

  • rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::paintBoxDecorations): Changed to not paint normal box shadows if
they are going to be cast by the background.

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::paintBoxDecorations): Ditto.

  • rendering/RenderBox.h: Made determineBackgroundBleedAvoidance() protected.
  • rendering/RenderBoxModelObject.cpp:

(WebCore::applyBoxShadowForBackground): Added this helper function, which applies the first
normal shadow from the given RenderStyle to the given GraphicsContext.
(WebCore::RenderBoxModelObject::paintFillLayerExtended): Added calls to
applyBoxShadowForBackground() before drawing the background color when needed.
(WebCore::RenderBoxModelObject::boxShadowShouldBeAppliedToBackground): Added. Returns true
in some of the cases where the box shadow can be cast by the background directly.

  • rendering/RenderBoxModelObject.h:
  • rendering/RenderFieldset.cpp:

(WebCore::RenderFieldset::paintBoxDecorations): Changed to not paint normal box shadows if
they are going to be cast by the background.

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::paintBoxDecorations): Ditto.

  • rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::boxShadowShouldBeAppliedToBackground): Added this override that
always returns false, because table cells sometimes apply a clip before drawing the background.

  • rendering/RenderTableCell.h:
1:02 PM Changeset in webkit [107835] by tony@chromium.org
  • 1 edit
    1 add in trunk/LayoutTests

[chromium] Unreviewed, adding the chromium-mac result for this test (test added in r107822).

  • platform/chromium-mac-snowleopard/css3/filters/multiple-filters-invalidation-expected.png: Added.
12:30 PM Changeset in webkit [107834] by adamk@chromium.org
  • 1 edit
    2 adds in trunk/LayoutTests

Add a test asserting that the second argument to MutationCallback is the observer
​https://bugs.webkit.org/show_bug.cgi?id=78653

Reviewed by Ryosuke Niwa.

This is specified in the spec text, so I wanted to make sure it was
properly exercised in a layout test.

  • fast/mutation/callback-second-argument-expected.txt: Added.
  • fast/mutation/callback-second-argument.html: Added.
12:26 PM Changeset in webkit [107833] by ojan@chromium.org
  • 7 edits in trunk

getComputedStyle of flex-item-align:auto should resolve to it's parent's flex-align value
​https://bugs.webkit.org/show_bug.cgi?id=76326

Reviewed by Tony Chang.

Source/WebCore:

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

LayoutTests:

  • css3/flexbox/css-properties-expected.txt:
  • platform/chromium-win/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/chromium-win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt:
12:21 PM Changeset in webkit [107832] by commit-queue@webkit.org
  • 30 edits in trunk/Source

Notify ChromeClient when touch-event handlers are installed/removed.
​https://bugs.webkit.org/show_bug.cgi?id=77440

Patch by Sadrul Habib Chowdhury <​sadrul@chromium.org> on 2012-02-15
Reviewed by Darin Fisher and Ryosuke Niwa.

Source/WebCore:

Keep a count of the number of touch-event handlers and notify the
embedder when the count changes. Depending on the count, the embedder
can decide whether or not to dispatch touch events to webkit.

  • dom/Document.cpp:

(WebCore::Document::Document):
(WebCore::Document::didAddTouchEventHandler):
(WebCore):
(WebCore::Document::didRemoveTouchEventHandler):

  • dom/Document.h:

(WebCore::Document::touchEventHandlerCount):
(Document):

  • dom/Node.cpp:

(WebCore::isTouchEventType):
(WebCore::tryAddEventListener):
(WebCore::tryRemoveEventListener):

  • loader/EmptyClients.h:

(WebCore::EmptyChromeClient::numTouchEventHandlersChanged):

  • page/ChromeClient.h:

(ChromeClient):

  • page/Frame.cpp:

(WebCore::Frame::notifyChromeClientWheelEventHandlerCountChanged):
(WebCore::Frame::notifyChromeClientTouchEventHandlerCountChanged):
(WebCore):

  • page/Frame.h:

(Frame):

Source/WebKit/chromium:

  • public/WebViewClient.h:

(WebKit::WebViewClient::numberOfTouchEventHandlersChanged):

  • src/ChromeClientImpl.cpp:

(WebKit::ChromeClientImpl::numTouchEventHandlersChanged):
(WebKit):

  • src/ChromeClientImpl.h:

(ChromeClientImpl):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::numberOfTouchEventHandlersChanged):
(WebKit):

  • src/WebViewImpl.h:

(WebViewImpl):

Source/WebKit/efl:

  • WebCoreSupport/ChromeClientEfl.h:

(WebCore::ChromeClientEfl::numTouchEventHandlersChanged):

Source/WebKit/gtk:

  • WebCoreSupport/ChromeClientGtk.h:

(WebKit::ChromeClient::numTouchEventHandlersChanged):

Source/WebKit/mac:

  • WebCoreSupport/WebChromeClient.h:

Source/WebKit/qt:

  • WebCoreSupport/ChromeClientQt.h:

(WebCore::ChromeClientQt::numTouchEventHandlersChanged):

Source/WebKit/win:

  • WebCoreSupport/WebChromeClient.h:

(WebChromeClient::numTouchEventHandlersChanged):

Source/WebKit/wince:

  • WebCoreSupport/ChromeClientWinCE.h:

(WebKit::ChromeClientWinCE::numTouchEventHandlersChanged):

Source/WebKit/wx:

  • WebKitSupport/ChromeClientWx.h:

(WebCore::ChromeClientWx::numTouchEventHandlersChanged):

Source/WebKit2:

  • UIProcess/WebPageProxy.h:

(WebKit::WebPageProxy::numTouchEventHandlersChanged):

  • WebProcess/WebCoreSupport/WebChromeClient.h:
12:03 PM Changeset in webkit [107831] by eric.carlson@apple.com
  • 5 edits
    2 adds in trunk

Unset the active flag when TextTrackCues go away
​https://bugs.webkit.org/show_bug.cgi?id=72552

Reviewed by Maciej Stachowiak.

Source/WebCore:

Test: media/track/track-active-cues.html

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::loadTimerFired): Configure new text tracks before preparing to load

so we know about all tracks when resource selection begins.

(WebCore::HTMLMediaElement::prepareForLoad): Call updateActiveTextTrackCues after setting

to m_readyState is HAVE_NOTHING so all cues get deactivated. Don't build list of
available text tracks because resource selection won't actually start until after the load timer fires.

(WebCore::HTMLMediaElement::loadInternal): Build list of non-disabled tracks.
(WebCore::HTMLMediaElement::updateActiveTextTrackCues): Clear the active flag on all cues

when m_readyState is HAVE_NOTHING or m_player is 0.

(WebCore::HTMLMediaElement::setReadyState): Don't update m_readyState when tracks which haven't

loaded yet will prevent events from firing. Call updateActiveTextTrackCues to ensure that the
first cue(s) are shown as soon as possible.

(WebCore::HTMLMediaElement::userCancelledLoad): Call updateActiveTextTrackCues when when m_readyState

is HAVE_NOTHING so all cues get deactivated.

LayoutTests:

  • media/track/track-active-cues-expected.txt: Added.
  • media/track/track-active-cues.html: Added.
  • track-cue-mutable-text.html: Update to not run test until track and video have

both loaded.

  • media/video-test.js:

(waitForEventsAndCall): New, call the specified function after the list of events

has been seen.

11:55 AM EFLWebKit edited by glima@profusion.mobi
Fix info on network backends. Cite unstable dependencies requirement. (diff)
11:52 AM Changeset in webkit [107830] by senorblanco@chromium.org
  • 1 edit
    1 add in trunk/LayoutTests

Unreviewed gardening.

Added baseline for new test multiple-filters-invalidation.html.

  • platform/chromium-win/css3/filters/multiple-filters-invalidation-expected.png: Added.
11:44 AM Changeset in webkit [107829] by adamk@chromium.org
  • 2 edits in trunk/LayoutTests

Stop skipping fast/filesystem/file-writer-gc-blob.html, as FileWriter is well-supported in DRT.

Unreviewed test expectations update.

  • platform/chromium/test_expectations.txt:
11:43 AM Changeset in webkit [107828] by tony@chromium.org
  • 13 edits
    4 adds
    5 deletes in trunk/LayoutTests

[chromium] Unreviewed, land chromium pixel results after r107797.

  • platform/chromium-linux/svg/dynamic-updates/SVGClipPath-influences-hitTesting-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGClipPathElement-css-transform-influences-hitTesting-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGClipPathElement-transform-influences-hitTesting-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-values-prop-expected.png:
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGClipPath-influences-hitTesting-expected.png:
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGClipPathElement-css-transform-influences-hitTesting-expected.png:
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGClipPathElement-transform-influences-hitTesting-expected.png:
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-values-prop-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGClipPath-influences-hitTesting-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGClipPathElement-css-transform-influences-hitTesting-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGClipPathElement-transform-influences-hitTesting-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-values-prop-expected.png: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGClipPath-influences-hitTesting-expected.png: Removed.
  • platform/chromium-mac/svg/dynamic-updates/SVGClipPathElement-transform-influences-hitTesting-expected.png: Removed.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-values-prop-expected.png: Removed.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-values-prop-expected.txt: Removed.
  • platform/chromium-win/svg/dynamic-updates/SVGClipPath-influences-hitTesting-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGClipPathElement-css-transform-influences-hitTesting-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGClipPathElement-transform-influences-hitTesting-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-values-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-values-prop-expected.txt: Removed.
11:37 AM Changeset in webkit [107827] by tony@chromium.org
  • 5 edits in trunk/LayoutTests

fast/regions/element-region-overflow-state.html is flaky
​https://bugs.webkit.org/show_bug.cgi?id=78654

Reviewed by Ojan Vafai.

Sometimes layout happens before test() is called (e.g., if one of the
script or other resources take a long time to load). In that case, we
get different results. Not waiting for the load event should always
be before layout.

  • fast/regions/element-region-overflow-state-expected.txt:
  • fast/regions/element-region-overflow-state.html:
  • fast/regions/element-region-overflow-state-vertical-rl-expected.txt
  • fast/regions/element-region-overflow-state-vertical-rl.html
11:16 AM Changeset in webkit [107826] by adamk@chromium.org
  • 2 edits in trunk/LayoutTests

Re-specify flakiness of http/tests/filesystem/workers as PASS TIMEOUT, since they never crash.

Unreviewed test expectations update.

  • platform/chromium/test_expectations.txt:
11:16 AM Changeset in webkit [107825] by enne@google.com
  • 2 edits in branches/chromium/963/Source/WebCore/rendering

Merge 107024 - Properly detect top level frames when propogating compositing
​https://bugs.webkit.org/show_bug.cgi?id=78033

Reviewed by James Robinson.

There's no need to enumerate all tag names when searching for a
top-level frame. If a render view's document has a frame, then that
frame is not the top-level one.

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::shouldPropagateCompositingToEnclosingFrame):

  • rendering/RenderLayerCompositor.h:

(RenderLayerCompositor):

TBR=​enne@google.com
Review URL: ​https://chromiumcodereview.appspot.com/9405017

10:57 AM Changeset in webkit [107824] by jberlin@webkit.org
  • 3 edits in trunk/Source/WebCore

WebCore build exceeds address space on 32-bit Windows builders (again).
​https://bugs.webkit.org/show_bug.cgi?id=78724

Reviewed by Jon Honeycutt.

Add the rest of the inspector .cpp files to the InspectorAllInOne.cpp file in Production and
Release builds.

  • WebCore.vcproj/WebCore.vcproj:

In the process, let VS have its way with this file.

  • inspector/InspectorAllInOne.cpp:
10:53 AM Changeset in webkit [107823] by andersca@apple.com
  • 12 edits in trunk/Source

Remove ScrollableArea::handleGestureEvent
​https://bugs.webkit.org/show_bug.cgi?id=78661

Reviewed by Adam Roben.

Source/WebCore:

ScrollableArea::handleGestureEvent ends up being a no-op so remove it and the related code.

  • page/EventHandler.cpp:

(WebCore::EventHandler::handleGestureEvent):

  • platform/ScrollAnimator.cpp:
  • platform/ScrollAnimator.h:

(ScrollAnimator):

  • platform/ScrollView.cpp:

(WebCore::ScrollView::wheelEvent):

  • platform/ScrollView.h:

(ScrollView):

  • platform/ScrollableArea.cpp:
  • platform/ScrollableArea.h:

(ScrollableArea):

Source/WebKit/chromium:

Update for WebCore changes.

  • src/WebPluginContainerImpl.cpp:
  • src/WebPluginContainerImpl.h:

(WebPluginContainerImpl):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::gestureEvent):

10:44 AM Changeset in webkit [107822] by senorblanco@chromium.org
  • 4 edits
    3 adds in trunk

Source/WebCore: Fix for incorrect/offset image in CSS filters (non-composited path)
​https://bugs.webkit.org/show_bug.cgi?id=78626

Reviewed by Darin Adler.

Test: css3/filters/multiple-filters-invalidation.html

  • rendering/FilterEffectRenderer.cpp:

(WebCore::FilterEffectRenderer::prepare):
When invalidating results, invalidate all intermediate filter
results, not just the last effect's result.

LayoutTests: New test to exercise invalidation of multiple CSS filters.
​https://bugs.webkit.org/show_bug.cgi?id=78626

Reviewed by Darin Adler.

  • css3/filters/multiple-filters-invalidation-expected.txt: Added.
  • css3/filters/multiple-filters-invalidation.html: Added.
  • platform/mac-snowleopard/css3/filters/multiple-filters-invalidation-expected.png: Added.
8:09 AM Changeset in webkit [107821] by apavlov@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: "Minus" (Delete) button disappears for hovered watch expression in Watches pane
​https://bugs.webkit.org/show_bug.cgi?id=78714

Reviewed by Pavel Feldman.

  • inspector/front-end/WatchExpressionsSidebarPane.js:

(WebInspector.WatchExpressionsSection.prototype._mouseOut):

8:01 AM Changeset in webkit [107820] by Patrick Gansterer
  • 5 edits in trunk/Source

[CMake] Move RunLoop to WebCore/platform
​https://bugs.webkit.org/show_bug.cgi?id=78504

Reviewed by Adam Roben.

Source/WebCore:

r105475 moved RunLoop.cpp from WebKit2 to WebCore, but missed the CMake based ports.

  • CMakeLists.txt:
  • PlatformWinCE.cmake:

Source/WebKit2:

  • CMakeLists.txt: Remove RunLoop.cpp from list of souces.
7:56 AM Changeset in webkit [107819] by Simon Hausmann
  • 2 edits in trunk/Source/WebKit/qt

Unreviewed Qt 4.x build fix.

  • WebCoreSupport/PageClientQt.cpp: Fix the QT_VERSION_CHECK pre-processor foo.
7:54 AM Changeset in webkit [107818] by zherczeg@webkit.org
  • 3 edits in trunk/Source/WebCore

Remove clipToImageBuffer from SourceAlpha and feComposite
​https://bugs.webkit.org/show_bug.cgi?id=78355

Reviewed by Nikolas Zimmermann.

The implementation of clipToImageBuffer is inefficient on
non-mac platforms, so we would benefit if remove it.

Existing tests cover this feature.

  • platform/graphics/filters/FEComposite.cpp:

(WebCore::FEComposite::platformApplySoftware):

  • platform/graphics/filters/SourceAlpha.cpp:

(WebCore::SourceAlpha::platformApplySoftware):

7:42 AM Changeset in webkit [107817] by Simon Hausmann
  • 7 edits in trunk/Source

[Qt] Replace use of QGLWidget/QGLContext with QOpenGLContext and QSurface for Qt 5
​https://bugs.webkit.org/show_bug.cgi?id=78694

Reviewed by Noam Rosenthal.

Source/WebCore:

Typedef PlatformGraphicsContext3D and PlatformGraphicsSurface3D to QOpenGLContext
and QSurface for Qt 5. Use these APIs to change the current context and get the
procedure addresses. Removed QGraphicsObject inheritance remainder while we're at it,
because that code path is obsolete.

  • platform/graphics/GraphicsContext3D.h:
  • platform/graphics/cairo/OpenGLShims.cpp:

(WebCore::getProcAddress):

  • platform/graphics/cairo/OpenGLShims.h:
  • platform/graphics/qt/GraphicsContext3DQt.cpp:

(WebCore::GraphicsContext3DPrivate::~GraphicsContext3DPrivate):
(WebCore::GraphicsContext3DPrivate::blitMultisampleFramebufferAndRestoreContext):
(WebCore::GraphicsContext3DPrivate::makeCurrentIfNeeded):
(WebCore::GraphicsContext3D::~GraphicsContext3D):

Source/WebKit/qt:

  • WebCoreSupport/PageClientQt.cpp:

(createPlatformGraphicsContext3DFromWidget): Return the QOpenGLContext and QSurface
from the QGLWidget when compiling with Qt 5, as that's what WebCore expects.

7:38 AM Changeset in webkit [107816] by commit-queue@webkit.org
  • 4 edits
    1 copy in trunk/Tools

[Qt] Add UI for HTTP authentication in the Qt MiniBrowser
​https://bugs.webkit.org/show_bug.cgi?id=76347

Patch by Michael Brüning <​michael.bruning@nokia.com> on 2012-02-15
Reviewed by Kenneth Rohde Christiansen.

  • MiniBrowser/qt/MiniBrowser.qrc:
  • MiniBrowser/qt/qml/AuthenticationDialog.qml: Added.
  • MiniBrowser/qt/qml/BrowserWindow.qml:
  • MiniBrowser/qt/qml/DialogLineInput.qml:
7:33 AM Changeset in webkit [107815] by Simon Hausmann
  • 7 edits in trunk/Source

[Qt] Move Qt platform specific GL Context/Surface creation out of WebCore into WebKit
​https://bugs.webkit.org/show_bug.cgi?id=78692

Reviewed by Noam Rosenthal.

Source/WebCore:

Replace the "glWidget" term in the GraphicsContext with "surface" and delegate
the context and surface creation to the page client.

  • platform/graphics/GraphicsContext3D.h:
  • platform/graphics/qt/GraphicsContext3DQt.cpp:

(GraphicsContext3DPrivate):
(WebCore::GraphicsContext3DPrivate::GraphicsContext3DPrivate):
(WebCore::GraphicsContext3DPrivate::~GraphicsContext3DPrivate):
(WebCore::GraphicsContext3DPrivate::blitMultisampleFramebufferAndRestoreContext):
(WebCore::GraphicsContext3DPrivate::makeCurrentIfNeeded):
(WebCore::GraphicsContext3D::GraphicsContext3D):
(WebCore::GraphicsContext3D::~GraphicsContext3D):
(WebCore::GraphicsContext3D::platformGraphicsContext3D):

  • platform/qt/QWebPageClient.h:

(QWebPageClient):

Source/WebKit/qt:

Implement GLWidget and GLContext creation from the page client interface.

  • WebCoreSupport/PageClientQt.cpp:

(createPlatformGraphicsContext3DFromWidget):
(WebCore):
(WebCore::PageClientQWidget::createPlatformGraphicsContext3D):
(WebCore::PageClientQGraphicsWidget::createPlatformGraphicsContext3D):

  • WebCoreSupport/PageClientQt.h:

(PageClientQWidget):
(PageClientQGraphicsWidget):

7:29 AM Changeset in webkit [107814] by noam.rosenthal@nokia.com
  • 12 edits
    20 adds in trunk

[Texmap] Support filters in TextureMapperImageBuffer
​https://bugs.webkit.org/show_bug.cgi?id=76026

Source/WebCore:

Implement GraphicsLayer::setFilters for TextureMapper, and pass the filters all the way
to BitmapTextureImageBuffer. This does not introduce a new filters implementation, but
rather uses the non-AC implementation. A complete implementation will be needed in
TextureMapperGL, which can use some of the glue in this code.

Reviewed by Kenneth Rohde Christiansen.

Unskipped 10 tests in css3/filters.

  • platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:

(WebCore):
(WebCore::GraphicsLayerTextureMapper::setFilters):

  • platform/graphics/texmap/GraphicsLayerTextureMapper.h:

(GraphicsLayerTextureMapper):

  • platform/graphics/texmap/TextureMapper.h:

(BitmapTexture):
(WebCore::BitmapTexture::applyFilters):

  • platform/graphics/texmap/TextureMapperImageBuffer.cpp:

(WebCore):
(WebCore::BitmapTextureImageBuffer::applyFilters):

  • platform/graphics/texmap/TextureMapperImageBuffer.h:

(BitmapTextureImageBuffer):

  • platform/graphics/texmap/TextureMapperLayer.cpp:

(WebCore::TextureMapperLayer::shouldPaintToIntermediateSurface):
(WebCore):
(WebCore::applyFilters):
(WebCore::TextureMapperLayer::paintRecursive):
(WebCore::TextureMapperLayer::syncCompositingStateSelf):

  • platform/graphics/texmap/TextureMapperLayer.h:

(State):

LayoutTests:

Unskipping hardware filter tests. They're still skipped in WebKit2.

Reviewed by Kenneth Rohde Christiansen.

  • platform/qt-5.0-wk2/Skipped:
  • platform/qt/Skipped:
  • platform/qt/css3/filters/crash-hw-sw-switch-expected.png:
  • platform/qt/css3/filters/effect-blur-hw-expected.png: Added.
  • platform/qt/css3/filters/effect-blur-hw-expected.txt: Added.
  • platform/qt/css3/filters/effect-combined-expected.png: Added.
  • platform/qt/css3/filters/effect-combined-expected.txt: Added.
  • platform/qt/css3/filters/effect-combined-hw-expected.png: Added.
  • platform/qt/css3/filters/effect-combined-hw-expected.txt: Added.
  • platform/qt/css3/filters/effect-drop-shadow-hw-expected.png: Added.
  • platform/qt/css3/filters/effect-drop-shadow-hw-expected.txt: Added.
  • platform/qt/css3/filters/effect-grayscale-hw-expected.png: Added.
  • platform/qt/css3/filters/effect-grayscale-hw-expected.txt: Added.
  • platform/qt/css3/filters/effect-hue-rotate-hw-expected.png: Added.
  • platform/qt/css3/filters/effect-hue-rotate-hw-expected.txt: Added.
  • platform/qt/css3/filters/effect-invert-hw-expected.png: Added.
  • platform/qt/css3/filters/effect-invert-hw-expected.txt: Added.
  • platform/qt/css3/filters/effect-opacity-hw-expected.png: Added.
  • platform/qt/css3/filters/effect-opacity-hw-expected.txt: Added.
  • platform/qt/css3/filters/effect-saturate-hw-expected.png: Added.
  • platform/qt/css3/filters/effect-saturate-hw-expected.txt: Added.
  • platform/qt/css3/filters/effect-sepia-hw-expected.png: Added.
  • platform/qt/css3/filters/effect-sepia-hw-expected.txt: Added.
7:26 AM Changeset in webkit [107813] by Simon Hausmann
  • 4 edits in trunk/Source/WebCore

[Qt] Clean up fallback rendering of GraphicsContext3D to Canvas
​https://bugs.webkit.org/show_bug.cgi?id=78690

Reviewed by Noam Rosenthal.

Use the common paintRenderingResultsToCanvas code to retrieve the
pixels from the FBO and use a Qt port specific paintToCanvas
implementation to wrap the pixels into a QImage and render it
into the graphics context, just like it's done for the other ports.

This removes the QGraphicsObject based paint, which is an now
obsolete method of rendering.

  • platform/graphics/GraphicsContext3D.h:
  • platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:

(WebCore::GraphicsContext3D::paintRenderingResultsToCanvas):

  • platform/graphics/qt/GraphicsContext3DQt.cpp:

(GraphicsContext3DPrivate):
(WebCore::GraphicsContext3D::paintToCanvas):

7:13 AM Changeset in webkit [107812] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/efl

[EFL] Add missing libsoup to (pkgconfig) dependency requirements
​https://bugs.webkit.org/show_bug.cgi?id=78702

Unreviewed build fix.

Patch by Gustavo Lima Chaves <​glima@profusion.mobi> on 2012-02-15

  • ewebkit.pc.in: Now that bug 77874 had its patch landed, we

always require libsoup as a dependency for the EFL port. The
'Require' session of this file has to contemplate that, otherwise
code linking with ewebkit will fail to lookup to libsoup's header
files.

6:14 AM Changeset in webkit [107811] by Simon Hausmann
  • 28 edits in trunk/Source

[Qt] Eliminate first set of QtWidgets dependencies from WebCore
​https://bugs.webkit.org/show_bug.cgi?id=78611

Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

  • bindings/js/ScriptControllerQt.cpp: Remove unused include.
  • page/qt/EventHandlerQt.cpp:

(WebCore::EventHandler::tabsToAllFormControls): Replace import
of private Qt(Widgets) variable with the default of Qt 5, where
it is also not configurable.

  • platform/ContextMenu.h: Remove unused include.
  • platform/ContextMenuItem.h: Ditto.
  • platform/Widget.h: Use QObject as type for PlatformWidget

instead of QWidget.

  • platform/graphics/Icon.h:

(Icon): Prefer QImage over QIcon for storage.

  • platform/graphics/gstreamer/PlatformVideoWindowPrivate.h:

(WebCore): Make it compile with QWindow for Qt 5 and QWidget for Qt 4.

  • platform/graphics/gstreamer/PlatformVideoWindowQt.cpp:

(FullScreenVideoWindow::FullScreenVideoWindow):
(FullScreenVideoWindow::keyPressEvent):
(FullScreenVideoWindow::event):
(FullScreenVideoWindow::showFullScreen):
(PlatformVideoWindow::PlatformVideoWindow):

  • platform/graphics/qt/IconQt.cpp: Revert the implementation of this class

back to notImplemented(). It was trying to load the actual file as QIcon
instead of trying to find a symbolic icon for the given file. We should
probably use the QMimeType API in Qt 5 once it becomes available.
(WebCore::Icon::createIconForFiles):
(WebCore::Icon::paint):

  • platform/graphics/qt/ImageQt.cpp:

(graphics): Remove use of QStyle for retrieving icons. Code moved to
WebCoreSupport instead.

  • platform/qt/ContextMenuQt.cpp: Removed unused include.
  • platform/qt/PlatformScreenQt.cpp: Add #ifdefs to use QScreen API

with Qt 5.
(WebCore::screenDepth):
(WebCore::screenDepthPerComponent):
(WebCore::screenIsMonochrome):
(WebCore::screenRect):
(WebCore::screenAvailableRect):

  • platform/qt/QWebPageClient.h: Add hook for showing/hiding widget.

(WebCore):
(QWebPageClient):

  • platform/qt/SoundQt.cpp:

(WebCore::systemBeep): Beep is not implemented in Qt 5 and its use is
questionable. Move back to notImplemented() until proper QPA API becomes
available in Qt 5 (if ever...).

  • platform/qt/WidgetQt.cpp: Delegate QWidget specific show/hide calls

to the PageClient, out of WebCore.
(WebCore::Widget::Widget):
(WebCore::Widget::show):
(WebCore::Widget::hide):

  • plugins/PluginView.h: Remove unused include.
  • rendering/RenderTreeAsText.cpp:

(WebCore::RenderTreeAsText::writeRenderObject): When dumping properties of
QWidget, use the QObject property API to retrieve the values instead of
QWidget specific API. Removed the mask from the dump as it's not available
as property and our layout tests don't seem to use it.

Source/WebKit/qt:

  • Api/qwebpage.cpp: Add missing includes.
  • WebCoreSupport/DumpRenderTreeSupportQt.cpp: Ditto.
  • WebCoreSupport/FrameLoaderClientQt.cpp: Make it compile by casting

the QObject based PlatformWidget back to QWidget before doing QWidget
specific function calls.

  • WebCoreSupport/InitWebCoreQt.cpp:

(WebCore::initializeWebCoreQt): Moved QStyle specific web-graphic initialization
here from WebCore.

  • WebCoreSupport/PageClientQt.cpp:

(WebCore::PageClientQWidget::setWidgetVisible): Implement show/hiding of widgets
through delegation to QWidget.
(WebCore):
(WebCore::PageClientQGraphicsWidget::setWidgetVisible): Provide empty widget
show/hide implementation, as it doesn't seem to make sense for graphicsviews.

  • WebCoreSupport/PageClientQt.h:

(PageClientQWidget):
(PageClientQGraphicsWidget):

Source/WebKit2:

  • UIProcess/qt/QtWebPageEventHandler.cpp: Add missing QCursor include

to fix compilation.

6:11 AM Changeset in webkit [107810] by apavlov@chromium.org
  • 9 edits in trunk/Source/WebCore

Web Inspector: Fix minor design issues in the Spectrum color picker
​https://bugs.webkit.org/show_bug.cgi?id=78693

Drive-by: frontend compilability fixes.

Reviewed by Pavel Feldman.

  • English.lproj/localizedStrings.js:
  • inspector/compile-front-end.sh:
  • inspector/front-end/ElementsPanel.js:
  • inspector/front-end/Popover.js:
  • inspector/front-end/Spectrum.js:

(WebInspector.Spectrum.rgbaToHSVA):
(WebInspector.Spectrum.prototype.set color):
(WebInspector.Spectrum.prototype.get isVisible):
(WebInspector.Spectrum.prototype.toggle):
(WebInspector.Spectrum.prototype.show):
(WebInspector.Spectrum.prototype.hide):

  • inspector/front-end/StylesSidebarPane.js:

(WebInspector.StylePropertyTreeElement.prototype.updateTitle.):

  • inspector/front-end/elementsPanel.css:

(.spectrum-container):
(.spectrum-top):
(.spectrum-color):
(.spectrum-hue):
(.spectrum-fill):
(.spectrum-range-container):
(.spectrum-range-container *):
(.spectrum-range-container label):
(.spectrum-range-container input):
(.swatch, .spectrum-dragger, .spectrum-slider):
(.spectrum-sat):
(.spectrum-val):
(.spectrum-dragger):
(.spectrum-slider):

  • inspector/front-end/inspector.css:

(.custom-popup-vertical-scroll ::-webkit-scrollbar-track-piece:vertical:increment):

6:09 AM Changeset in webkit [107809] by kubo@profusion.mobi
  • 2 edits in trunk

[CMake] Remove unused PkgConfig module import from FindCFLite.cmake.
​https://bugs.webkit.org/show_bug.cgi?id=78600

Reviewed by Adam Roben.

  • Source/cmake/FindCFLite.cmake:
6:05 AM Changeset in webkit [107808] by yurys@chromium.org
  • 3 edits in trunk/Source/WebCore

2012-02-15 Yury Semikhatsky <​yurys@chromium.org>

Unreviewed. Build fix after r107806

  • inspector/InjectedScript.cpp: (WebCore::InjectedScript::callFunctionWithEvalEnabled):
  • inspector/InjectedScript.h: (InjectedScript):
5:59 AM Changeset in webkit [107807] by noel.gordon@gmail.com
  • 12 edits
    2 adds
    2 deletes in trunk/LayoutTests

[chromium] Rebaseline JPEG image results after r107389
​https://bugs.webkit.org/show_bug.cgi?id=78454

Unreviewed. Rebaseline #13 of N.

  • platform/chromium-linux/tables/mozilla/bugs/bug10565-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug11026-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug1188-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug10565-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug11026-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug1188-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug10565-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug11026-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug1188-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug10565-expected.png: Removed.
  • platform/chromium-mac/tables/mozilla/bugs/bug11026-expected.png: Removed.
  • platform/chromium-win/tables/mozilla/bugs/bug10565-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug11026-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug1188-expected.png:
  • platform/chromium/test_expectations.txt:
5:55 AM Changeset in webkit [107806] by yurys@chromium.org
  • 4 edits
    2 adds in trunk

Web Inspector: crash when inspecting an element on a page with eval disabled by CSP
​https://bugs.webkit.org/show_bug.cgi?id=78705

Source/WebCore:

Inspector functions in injected script may use eval so we need to make sure
it is allowed for inspector code on pages where it is prohibited by CSP.

Reviewed by Pavel Feldman.

Test: inspector/elements/resolve-node-blocked.html

  • inspector/InjectedScript.cpp:

(WebCore::InjectedScript::nodeForObjectId):
(WebCore::InjectedScript::wrapCallFrames):
(WebCore::InjectedScript::wrapObject):
(WebCore::InjectedScript::releaseObjectGroup):
(WebCore::InjectedScript::callFunctionWithEvalEnabled):
(WebCore):
(WebCore::InjectedScript::makeCall):

  • inspector/InjectedScript.h:

(InjectedScript):

LayoutTests:

Reviewed by Pavel Feldman.

  • inspector/elements/resolve-node-blocked-expected.txt: Added.
  • inspector/elements/resolve-node-blocked.html: Added.
5:39 AM Changeset in webkit [107805] by tkent@chromium.org
  • 7 edits
    8 adds
    60 deletes in trunk/LayoutTests

Clean up radio button tests
​https://bugs.webkit.org/show_bug.cgi?id=78679

Reviewed by Kentaro Hara.

  • Split checkbox-radio-onchange.html into checkbox-onchange.html and radio/radio-onchange.html.
  • Convert the following rendering tests to text tests. radio-attr-order.html radio-nested-labels.html radio_checked.html radio_checked_dynamic.html

This change is a preparation of moving radio button tests to fast/forms/radio/.

  • fast/forms/checkbox-onchange-expected.txt: Added.
  • fast/forms/checkbox-onchange.html: Added.
  • fast/forms/checkbox-radio-onchange.html: Removed.
  • fast/forms/radio-attr-order-expected.txt: Added.
  • fast/forms/radio-attr-order.html:
  • fast/forms/radio-nested-labels-expected.txt: Added.
  • fast/forms/radio-nested-labels.html:
  • fast/forms/radio/radio-onchange-expected.txt: Added.
  • fast/forms/radio/radio-onchange.html: Added.
  • fast/forms/radio_checked-expected.txt: Added.
  • fast/forms/radio_checked.html:
  • fast/forms/radio_checked_dynamic-expected.txt: Added.
  • fast/forms/radio_checked_dynamic.html:
  • platform/chromium-linux/fast/forms/checkbox-radio-onchange-expected.png: Removed.
  • platform/chromium-linux/fast/forms/radio-attr-order-expected.png: Removed.
  • platform/chromium-linux/fast/forms/radio-nested-labels-expected.png: Removed.
  • platform/chromium-linux/fast/forms/radio_checked-expected.png: Removed.
  • platform/chromium-linux/fast/forms/radio_checked_dynamic-expected.png: Removed.
  • platform/chromium-win/fast/forms/checkbox-radio-onchange-expected.png: Removed.
  • platform/chromium-win/fast/forms/checkbox-radio-onchange-expected.txt: Removed.
  • platform/chromium-win/fast/forms/radio-attr-order-expected.png: Removed.
  • platform/chromium-win/fast/forms/radio-attr-order-expected.txt: Removed.
  • platform/chromium-win/fast/forms/radio-nested-labels-expected.png: Removed.
  • platform/chromium-win/fast/forms/radio-nested-labels-expected.txt: Removed.
  • platform/chromium-win/fast/forms/radio_checked-expected.png: Removed.
  • platform/chromium-win/fast/forms/radio_checked-expected.txt: Removed.
  • platform/chromium-win/fast/forms/radio_checked_dynamic-expected.png: Removed.
  • platform/chromium-win/fast/forms/radio_checked_dynamic-expected.txt: Removed.
  • platform/chromium/test_expectations.txt:
  • platform/efl/fast/forms/checkbox-radio-onchange-expected.png: Removed.
  • platform/efl/fast/forms/checkbox-radio-onchange-expected.txt: Removed.
  • platform/efl/fast/forms/radio-attr-order-expected.png: Removed.
  • platform/efl/fast/forms/radio-attr-order-expected.txt: Removed.
  • platform/efl/fast/forms/radio-nested-labels-expected.png: Removed.
  • platform/efl/fast/forms/radio-nested-labels-expected.txt: Removed.
  • platform/efl/fast/forms/radio_checked-expected.png: Removed.
  • platform/efl/fast/forms/radio_checked-expected.txt: Removed.
  • platform/efl/fast/forms/radio_checked_dynamic-expected.png: Removed.
  • platform/efl/fast/forms/radio_checked_dynamic-expected.txt: Removed.
  • platform/gtk/fast/forms/checkbox-radio-onchange-expected.png: Removed.
  • platform/gtk/fast/forms/checkbox-radio-onchange-expected.txt: Removed.
  • platform/gtk/fast/forms/radio-attr-order-expected.png: Removed.
  • platform/gtk/fast/forms/radio-attr-order-expected.txt: Removed.
  • platform/gtk/fast/forms/radio-nested-labels-expected.png: Removed.
  • platform/gtk/fast/forms/radio-nested-labels-expected.txt: Removed.
  • platform/gtk/fast/forms/radio_checked-expected.png: Removed.
  • platform/gtk/fast/forms/radio_checked-expected.txt: Removed.
  • platform/gtk/fast/forms/radio_checked_dynamic-expected.png: Removed.
  • platform/gtk/fast/forms/radio_checked_dynamic-expected.txt: Removed.
  • platform/mac-leopard/fast/forms/checkbox-radio-onchange-expected.png: Removed.
  • platform/mac-leopard/fast/forms/radio-attr-order-expected.png: Removed.
  • platform/mac-leopard/fast/forms/radio-nested-labels-expected.png: Removed.
  • platform/mac-leopard/fast/forms/radio_checked-expected.png: Removed.
  • platform/mac-leopard/fast/forms/radio_checked_dynamic-expected.png: Removed.
  • platform/mac-snowleopard/fast/forms/radio_checked-expected.png: Removed.
  • platform/mac-snowleopard/fast/forms/radio_checked-expected.txt: Removed.
  • platform/mac-snowleopard/fast/forms/radio_checked_dynamic-expected.png: Removed.
  • platform/mac-snowleopard/fast/forms/radio_checked_dynamic-expected.txt: Removed.
  • platform/mac/fast/forms/checkbox-radio-onchange-expected.png: Removed.
  • platform/mac/fast/forms/checkbox-radio-onchange-expected.txt: Removed.
  • platform/mac/fast/forms/radio-attr-order-expected.png: Removed.
  • platform/mac/fast/forms/radio-attr-order-expected.txt: Removed.
  • platform/mac/fast/forms/radio-nested-labels-expected.png: Removed.
  • platform/mac/fast/forms/radio-nested-labels-expected.txt: Removed.
  • platform/mac/fast/forms/radio_checked-expected.png: Removed.
  • platform/mac/fast/forms/radio_checked-expected.txt: Removed.
  • platform/mac/fast/forms/radio_checked_dynamic-expected.png: Removed.
  • platform/mac/fast/forms/radio_checked_dynamic-expected.txt: Removed.
  • platform/qt-mac/Skipped:
  • platform/qt/fast/forms/checkbox-radio-onchange-expected.txt: Removed.
  • platform/qt/fast/forms/radio-attr-order-expected.txt: Removed.
  • platform/qt/fast/forms/radio-nested-labels-expected.txt: Removed.
  • platform/qt/fast/forms/radio_checked-expected.txt: Removed.
  • platform/qt/fast/forms/radio_checked_dynamic-expected.txt: Removed.
5:18 AM Changeset in webkit [107804] by apavlov@chromium.org
  • 8 edits
    1 add in trunk/Source/WebCore

Web Inspector: Add colorpicker functionality to color swatches in Styles Sidebar
​https://bugs.webkit.org/show_bug.cgi?id=71262

Patch by Brian Grinstead <​briangrinstead@gmail.com> on 2012-02-13
Reviewed by Pavel Feldman.

  • English.lproj/localizedStrings.js:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/front-end/Settings.js:
  • inspector/front-end/Spectrum.js: Added.

(WebInspector.Spectrum.hueDrag):
(WebInspector.Spectrum.colorDrag):
(WebInspector.Spectrum.alphaDrag):
(WebInspector.Spectrum):
(WebInspector.Spectrum.hsvaToRGBA):
(WebInspector.Spectrum.rgbaToHSVA):
(WebInspector.Spectrum.draggable.prevent):
(WebInspector.Spectrum.draggable.move):
(WebInspector.Spectrum.draggable.start):
(WebInspector.Spectrum.draggable.stop):
(WebInspector.Spectrum.draggable):
(WebInspector.Spectrum.prototype.set color):
(WebInspector.Spectrum.prototype.get color):
(WebInspector.Spectrum.prototype.get outputColorFormat):
(WebInspector.Spectrum.prototype.get colorHueOnly):
(WebInspector.Spectrum.prototype.set displayText):
(WebInspector.Spectrum.prototype._onchange):
(WebInspector.Spectrum.prototype._updateHelperLocations):
(WebInspector.Spectrum.prototype._updateUI):
(WebInspector.Spectrum.prototype.toggle):
(WebInspector.Spectrum.prototype.show):
(WebInspector.Spectrum.prototype.reposition):
(WebInspector.Spectrum.prototype.hide):

  • inspector/front-end/StylesSidebarPane.js:

(WebInspector.StylesSidebarPane):
(WebInspector.StylePropertyTreeElement.prototype.updateTitle.):

  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.css:

(.swatch):
(.swatch-inner):
(.spectrum-container):
(.spectrum-top):
(.spectrum-color):
(.spectrum-hue):
(.spectrum-fill):
(.spectrum-range-container):
(.spectrum-range-container *):
(.spectrum-range-container label):
(.spectrum-range-container input):
(.swatch, .spectrum-dragger, .spectrum-slider):
(.spectrum-sat):
(.spectrum-val):
(.spectrum-dragger):
(.spectrum-slider):

  • inspector/front-end/inspector.html:
5:06 AM Changeset in webkit [107803] by Simon Hausmann
  • 5 edits in trunk/Source

Source/WebCore: [Qt] Be smarter with tile usages during tiling
​https://bugs.webkit.org/show_bug.cgi?id=78243

Patch by Kenneth Rohde Christiansen <​kenneth@webkit.org> on 2012-02-15
Reviewed by Simon Hausmann.

The keep rect used to know what existing tiles to keep around, is now a
padding (in tile dimensions) around the usual cover rect. With usual,
I mean to point out that we take our panning optimization into account.

We also do a good effort at keeping the amount of tiles steady, by not
simply intersecting our areas with the contentRect, but moving it
first into legal bounds and then expanding in opposite direction to
cover a similar amount of pixels.

In the future the cover area should be calculated given available
system memory.

  • platform/graphics/TiledBackingStore.cpp:

(WebCore):
(WebCore::TiledBackingStore::TiledBackingStore):
(WebCore::TiledBackingStore::createTiles):
(WebCore::TiledBackingStore::adjustForContentsRect):
(WebCore::TiledBackingStore::computeCoverAndKeepRect):
(WebCore::TiledBackingStore::tileRectForCoordinate):

  • platform/graphics/TiledBackingStore.h:

(TiledBackingStore):

Source/WebKit/qt: [Qt] Be smarted with tile usages during tiling
​https://bugs.webkit.org/show_bug.cgi?id=78243

Patch by Kenneth Rohde Christiansen <​kenneth@webkit.org> on 2012-02-15
Reviewed by Simon Hausmann.

Remove internal API used by Symbian.

  • Api/qwebpage.cpp:

(QWebPagePrivate::dynamicPropertyChangeEvent):

4:54 AM Changeset in webkit [107802] by Nikolas Zimmermann
  • 89 edits
    32 adds in trunk/LayoutTests

2012-02-15 Nikolas Zimmermann <​nzimmermann@rim.com>

Not reviewed. Update SnowLeopard SVG pixel test baseline - chunk 1.

  • platform/mac-snowleopard/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.png:
  • platform/mac-snowleopard/svg/W3C-SVG-1.1-SE/filters-image-05-f-expected.png:
  • platform/mac-snowleopard/svg/W3C-SVG-1.1-SE/painting-control-04-f-expected.png:
  • platform/mac-snowleopard/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.png: Added.
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-30-t-expected.png:
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-36-t-expected.png:
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-80-t-expected.png:
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/filters-blend-01-b-expected.png: Added.
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/filters-color-01-b-expected.png:
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/filters-composite-02-b-expected.png:
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.png:
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/filters-conv-01-f-expected.png:
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/filters-diffuse-01-f-expected.png:
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/filters-displace-01-f-expected.png:
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/filters-example-01-b-expected.png: Added.
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/filters-gauss-01-b-expected.png:
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/filters-image-01-b-expected.png:
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/filters-light-01-f-expected.png:
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/filters-light-04-f-expected.png:
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/filters-morph-01-f-expected.png:
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/filters-offset-01-b-expected.png:
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/filters-specular-01-f-expected.png:
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/filters-tile-01-b-expected.png:
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/filters-turb-01-f-expected.png:
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/filters-turb-02-f-expected.png:
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/render-groups-01-b-expected.png: Added.
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/render-groups-03-t-expected.png: Added.
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/struct-image-04-t-expected.png: Added.
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/struct-image-06-t-expected.png:
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/struct-image-07-t-expected.png: Added.
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/struct-image-08-t-expected.png: Added.
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/struct-use-01-t-expected.png: Added.
  • platform/mac-snowleopard/svg/as-background-image/svg-as-background-6-expected.png:
  • platform/mac-snowleopard/svg/as-border-image/svg-as-border-image-2-expected.png:
  • platform/mac-snowleopard/svg/as-border-image/svg-as-border-image-expected.png: Added.
  • platform/mac-snowleopard/svg/as-image/animated-svg-as-image-expected.png:
  • platform/mac-snowleopard/svg/as-image/animated-svg-as-image-no-fixed-intrinsic-size-expected.png:
  • platform/mac-snowleopard/svg/as-image/animated-svg-as-image-same-image-expected.png:
  • platform/mac-snowleopard/svg/as-image/svg-image-change-content-size-expected.png:
  • platform/mac-snowleopard/svg/as-object/embedded-svg-immediate-offsetWidth-query-expected.png:
  • platform/mac-snowleopard/svg/as-object/embedded-svg-size-changes-expected.png:
  • platform/mac-snowleopard/svg/as-object/nested-embedded-svg-size-changes-expected.png:
  • platform/mac-snowleopard/svg/batik/filters/feTile-expected.png:
  • platform/mac-snowleopard/svg/batik/filters/filterRegions-expected.png:
  • platform/mac-snowleopard/svg/batik/masking/maskRegions-expected.png:
  • platform/mac-snowleopard/svg/batik/text/smallFonts-expected.png:
  • platform/mac-snowleopard/svg/batik/text/textEffect-expected.png:
  • platform/mac-snowleopard/svg/batik/text/textEffect3-expected.png:
  • platform/mac-snowleopard/svg/carto.net/selectionlist-expected.png:
  • platform/mac-snowleopard/svg/carto.net/window-expected.png:
  • platform/mac-snowleopard/svg/css/path-gradient-stroke-shadow-expected.png: Added.
  • platform/mac-snowleopard/svg/css/rect-gradient-stroke-shadow-expected.png: Added.
  • platform/mac-snowleopard/svg/css/shadow-changes-expected.png:
  • platform/mac-snowleopard/svg/custom/absolute-sized-content-with-resources-expected.png:
  • platform/mac-snowleopard/svg/custom/circle-move-invalidation-expected.png:
  • platform/mac-snowleopard/svg/custom/convolution-crash-expected.png: Added.
  • platform/mac-snowleopard/svg/custom/createImageElement-expected.png: Added.
  • platform/mac-snowleopard/svg/custom/createImageElement2-expected.png:
  • platform/mac-snowleopard/svg/custom/empty-merge-expected.png: Added.
  • platform/mac-snowleopard/svg/custom/feComponentTransfer-Discrete-expected.png:
  • platform/mac-snowleopard/svg/custom/feComponentTransfer-Gamma-expected.png:
  • platform/mac-snowleopard/svg/custom/feComponentTransfer-Linear-expected.png:
  • platform/mac-snowleopard/svg/custom/feComponentTransfer-Table-expected.png:
  • platform/mac-snowleopard/svg/custom/feDisplacementMap-01-expected.png: Added.
  • platform/mac-snowleopard/svg/custom/focus-ring-expected.png:
  • platform/mac-snowleopard/svg/custom/foreignObject-crash-on-hover-expected.png:
  • platform/mac-snowleopard/svg/custom/getTransformToElement-expected.png:
  • platform/mac-snowleopard/svg/custom/grayscale-gradient-mask-2-expected.png: Added.
  • platform/mac-snowleopard/svg/custom/group-opacity-expected.png:
  • platform/mac-snowleopard/svg/custom/hit-test-unclosed-subpaths-expected.png:
  • platform/mac-snowleopard/svg/custom/hit-test-with-br-expected.png:
  • platform/mac-snowleopard/svg/custom/image-parent-translation-expected.png:
  • platform/mac-snowleopard/svg/custom/image-small-width-height-expected.png:
  • platform/mac-snowleopard/svg/custom/image-with-prefix-in-webarchive-expected.png: Added.
  • platform/mac-snowleopard/svg/custom/image-with-transform-clip-filter-expected.png:
  • platform/mac-snowleopard/svg/custom/inline-svg-in-xhtml-expected.png:
  • platform/mac-snowleopard/svg/custom/js-late-clipPath-and-object-creation-expected.png: Added.
  • platform/mac-snowleopard/svg/custom/js-update-image-and-display-expected.png: Added.
  • platform/mac-snowleopard/svg/custom/js-update-image-and-display2-expected.png: Added.
  • platform/mac-snowleopard/svg/custom/js-update-image-and-display3-expected.png: Added.
  • platform/mac-snowleopard/svg/custom/js-update-image-expected.png: Added.
  • platform/mac-snowleopard/svg/custom/js-update-stop-linked-gradient-expected.png:
  • platform/mac-snowleopard/svg/custom/mask-invalidation-expected.png:
  • platform/mac-snowleopard/svg/custom/mouse-move-on-svg-container-expected.png:
  • platform/mac-snowleopard/svg/custom/mouse-move-on-svg-container-standalone-expected.png:
  • platform/mac-snowleopard/svg/custom/mouse-move-on-svg-root-expected.png:
  • platform/mac-snowleopard/svg/custom/mouse-move-on-svg-root-standalone-expected.png:
  • platform/mac-snowleopard/svg/custom/non-opaque-filters-expected.png:
  • platform/mac-snowleopard/svg/custom/pattern-userSpaceOnUse-userToBaseTransform-expected.png: Added.
  • platform/mac-snowleopard/svg/custom/pointer-events-image-css-transform-expected.png:
  • platform/mac-snowleopard/svg/custom/pointer-events-image-expected.png:
  • platform/mac-snowleopard/svg/custom/recursive-filter-expected.png:
  • platform/mac-snowleopard/svg/custom/relative-sized-content-expected.png:
  • platform/mac-snowleopard/svg/custom/relative-sized-content-with-resources-expected.png:
  • platform/mac-snowleopard/svg/custom/relative-sized-deep-shadow-tree-content-expected.png:
  • platform/mac-snowleopard/svg/custom/relative-sized-image-expected.png: Added.
  • platform/mac-snowleopard/svg/custom/relative-sized-inner-svg-expected.png:
  • platform/mac-snowleopard/svg/custom/relative-sized-shadow-tree-content-expected.png:
  • platform/mac-snowleopard/svg/custom/relative-sized-shadow-tree-content-with-symbol-expected.png:
  • platform/mac-snowleopard/svg/custom/relative-sized-use-on-symbol-expected.png:
  • platform/mac-snowleopard/svg/custom/relative-sized-use-without-attributes-on-symbol-expected.png:
  • platform/mac-snowleopard/svg/custom/resource-invalidate-on-target-update-expected.png: Added.
  • platform/mac-snowleopard/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.png:
  • platform/mac-snowleopard/svg/custom/text-filter-expected.png: Added.
  • platform/mac-snowleopard/svg/custom/text-image-opacity-expected.png:
  • platform/mac-snowleopard/svg/custom/text-xy-updates-SVGList-expected.png:
  • platform/mac-snowleopard/svg/custom/transform-with-shadow-and-gradient-expected.png: Added.
  • platform/mac-snowleopard/svg/custom/use-clipped-hit-expected.png:
  • platform/mac-snowleopard/svg/custom/use-disappears-after-style-update-expected.png:
  • platform/mac-snowleopard/svg/custom/use-elementInstance-event-target-expected.png:
  • platform/mac-snowleopard/svg/custom/use-elementInstance-methods-expected.png:
  • platform/mac-snowleopard/svg/custom/use-event-handler-on-referenced-element-expected.png:
  • platform/mac-snowleopard/svg/custom/use-event-handler-on-use-element-expected.png:
  • platform/mac-snowleopard/svg/custom/use-instanceRoot-event-bubbling-expected.png: Added.
  • platform/mac-snowleopard/svg/custom/use-instanceRoot-event-listeners-expected.png: Added.
  • platform/mac-snowleopard/svg/custom/use-on-g-containing-foreignObject-and-image-expected.png: Added.
  • platform/mac-snowleopard/svg/custom/visibility-override-filter-expected.png: Added.
  • platform/mac-snowleopard/svg/dom/SVGPathSegList-segment-modification-expected.png:
  • platform/mac-snowleopard/svg/dom/SVGPathSegList-xml-dom-synchronization-expected.png:
  • platform/mac-snowleopard/svg/dom/SVGPathSegList-xml-dom-synchronization2-expected.png:
4:19 AM Changeset in webkit [107801] by vsevik@chromium.org
  • 16 edits
    2 adds in trunk

Web Inspector: [InspectorIndexedDB] Pass data entries from object stores and indexes to front-end.
​https://bugs.webkit.org/show_bug.cgi?id=78503

Reviewed by Yury Semikhatsky.

Source/WebCore:

Test: http/tests/inspector/indexeddb/database-data.html

  • bindings/js/SerializedScriptValue.cpp:

(WebCore::SerializedScriptValue::deserializeForInspector):
(WebCore):

  • bindings/js/SerializedScriptValue.h:

(SerializedScriptValue):

  • bindings/v8/SerializedScriptValue.cpp:

(WebCore::SerializedScriptValue::deserializeForInspector):
(WebCore):

  • bindings/v8/SerializedScriptValue.h:

(SerializedScriptValue):

  • inspector/InjectedScript.cpp:

(WebCore::InjectedScript::wrapObject):
(WebCore::InjectedScript::wrapSerializedObject):
(WebCore):
(WebCore::InjectedScript::canAccessInspectedWindow):

  • inspector/InjectedScript.h:

(InjectedScript):

  • inspector/Inspector.json:
  • inspector/InspectorController.cpp:

(WebCore::InspectorController::InspectorController):

  • inspector/InspectorIndexedDBAgent.cpp:

(WebCore):
(WebCore::InspectorIndexedDBAgent::InspectorIndexedDBAgent):
(WebCore::assertFrame):
(WebCore::assertDocument):
(WebCore::InspectorIndexedDBAgent::requestData):

  • inspector/InspectorIndexedDBAgent.h:

(WebCore):
(WebCore::InspectorIndexedDBAgent::create):
(InspectorIndexedDBAgent):

  • inspector/front-end/IndexedDBModel.js:

(WebInspector.IndexedDBModel.idbKeyFromKey):
(WebInspector.IndexedDBModel.keyFromIDBKey):
(WebInspector.IndexedDBModel.keyRangeFromIDBKeyRange):
(WebInspector.IndexedDBModel.prototype._loadDatabase):
(WebInspector.IndexedDBModel.prototype.loadObjectStoreData):
(WebInspector.IndexedDBModel.prototype.loadIndexData):
(WebInspector.IndexedDBModel.Entry):
(WebInspector.IndexedDBRequestManager):
(WebInspector.IndexedDBRequestManager.prototype._requestData.innerCallback):
(WebInspector.IndexedDBRequestManager.prototype._requestData):
(WebInspector.IndexedDBRequestManager.prototype.requestObjectStoreData):
(WebInspector.IndexedDBRequestManager.prototype._objectStoreDataLoaded):
(WebInspector.IndexedDBRequestManager.prototype.requestIndexData):
(WebInspector.IndexedDBRequestManager.prototype._indexDataLoaded):
(WebInspector.IndexedDBRequestManager.prototype._frameDetached):
(WebInspector.IndexedDBRequestManager.prototype._databaseRemoved):
(WebInspector.IndexedDBRequestManager.prototype._reset):
(WebInspector.IndexedDBRequestManager.DataRequest):
(WebInspector.IndexedDBDispatcher.prototype.databaseLoaded):
(WebInspector.IndexedDBDispatcher.prototype.objectStoreDataLoaded):
(WebInspector.IndexedDBDispatcher.prototype.indexDataLoaded):

LayoutTests:

  • http/tests/inspector/indexeddb/database-data-expected.txt: Added.
  • http/tests/inspector/indexeddb/database-data.html: Added.
  • http/tests/inspector/indexeddb/database-names-expected.txt:
  • http/tests/inspector/indexeddb/database-structure-expected.txt:
  • http/tests/inspector/indexeddb/indexeddb-test.js:

(initialize_IndexedDBTest.InspectorTest.evaluateWithCallback):
(initialize_IndexedDBTest.InspectorTest.addIDBValue):
(initialize_IndexedDBTest):
(doWithReadWriteTransaction.step2.innerCommitCallback):
(doWithReadWriteTransaction.step2):
(doWithReadWriteTransaction):
(addIDBValue.doWithReadWriteTransaction.withTransactionCallback):
(addIDBValue):

3:47 AM Changeset in webkit [107800] by Simon Hausmann
  • 2 edits in trunk/Tools

[Qt] Fix WebGL in QtTestBrowser

Reviewed by Tor Arne Vestbø.

  • QtTestBrowser/QtTestBrowser.pro: Set the OpenGL define so that when passing

the options for enabling GL we also pass them on properly.

3:37 AM Changeset in webkit [107799] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

REGRESSION(r107518): DeviceOrientationController doesn't remove registered DOMWindows
​https://bugs.webkit.org/show_bug.cgi?id=78683

Patch by Hajime Morrita <​morrita@chromium.org> on 2012-02-15
Reviewed by Kentaro Hara.

A copy-n-paste disaster. This change fixed it by calling correct methods.

No new tests. Needs browser side mocking for testing this.
A Chromium automated test covers this.

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::removeAllEventListeners):

  • page/Page.cpp:

(WebCore::Page::provideSupplement):
(WebCore::Page::requireSupplement):

  • page/Page.h: Fix typo.

(Page):

3:28 AM Changeset in webkit [107798] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

2012-02-15 Kent Tamura <​tkent@chromium.org>

Unreviewed, change the encoding of a test HTML.

  • fast/forms/radio-nested-labels.html: Convert from UTF-16 to UTF-8.
2:49 AM SettingUpDevelopmentEnvironmentForN9 edited by vestbo@webkit.org
(diff)
2:48 AM Changeset in webkit [107797] by Nikolas Zimmermann
  • 1095 edits
    1 delete in trunk/LayoutTests

Switch svg/dynamic-updates tests to repaint harness
​https://bugs.webkit.org/show_bug.cgi?id=78219

Make all tests that exercise repainting use the fast/repaint/resources/repaint.js harness.
This is the last step, all svg tests have been converted.

The only relevant change to look at is svg/dynamic-updates/resources/SVGTestCase.js, the rest is mechanic, done by a script.
Ran following magic in svg/dynamic-updates: (inject repaint.js in all *.html files in that folder, and register onload handler)
find . -type f -name "*.html" | xargs perl -pi -e "s/js-test-pre\.js\"><\/script\>/js-test-pre\.js\"><\/script\>\n\<script src=\"..\/..\/fast\/repaint\/resources\/repaint\.js\"\>\<\/script\>/"
find . -type f -name "*.html" | xargs perl -pi -e "s/<body>/<body onload=\"runRepaintTest()\">/"

And in svg/dynamic-updates/script-tests: (remove manual startTest function calls, and rename executeTest to repaintTest).
find . -type f -name "*.js" | xargs perl -pi -e "s/startTest\(.*\);\n"
find . -type f -name "*.js" | xargs perl -pi -e "s/function\ executeTest/function\ repaintTest/"

Only a few tests needed other adjustments.

  • platform/chromium/test_expectations.txt:
  • svg/animations/resources/SVGAnimationTestCase.js:

(runSMILTest):
...

  • platform/mac/svg/dynamic-updates/SVGCircleElement-dom-cx-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGCircleElement-dom-cy-attr-expected.png:

...

  • svg/dynamic-updates/SVG-dynamic-css-transform.html:
  • svg/dynamic-updates/SVGAElement-dom-href-attr.html:

...

  • svg/dynamic-updates/resources/SVGTestCase.js: Changed to utilize the repaint.js harness.

(createSVGTestCase):
(clickAt):

  • svg/dynamic-updates/resources/linkTarget.svg:
  • svg/dynamic-updates/script-tests/SVGAElement-dom-href-attr.js:

(repaintTest):

  • svg/dynamic-updates/script-tests/SVGAElement-dom-target-attr.js:

(repaintTest):
...

  • svg/dynamic-updates/script-tests/TEMPLATE.html: Removed.
2:30 AM Changeset in webkit [107796] by rolandsteiner@chromium.org
  • 2 edits in trunk/Source/WebCore

2012-02-15 Roland Steiner <​rolandsteiner@chromium.org>

Unreviewed, quick build fix for 107792

  • inspector/DOMEditor.cpp: (WebCore::DOMEditor::RemoveAttributeAction::redo):
1:52 AM Changeset in webkit [107795] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

2012-02-15 Kent Tamura <​tkent@chromium.org>

Unreviewed, correct svn:mime-type of a test.

  • fast/forms/radio-nested-labels.html: Modified property svn:mime-type from application/octet-stream to text/html.
1:24 AM Changeset in webkit [107794] by tonyg@chromium.org
  • 2 edits in trunk/Source/WebCore

[chromium] Don't use increased FontCache size on Android
​https://bugs.webkit.org/show_bug.cgi?id=78656

Reviewed by Adam Barth.

The chromium port uses a larger font cache size because it increases
performance on the intl1 and intl2 page cyclers. However, on Android
devices where resources are more constrained, it isn't desireable to
allow the FontCache to grow so big.

No new tests because no testable difference in functionality.

  • platform/graphics/FontCache.cpp:

(WebCore):

1:17 AM Changeset in webkit [107793] by rolandsteiner@chromium.org
  • 20 edits
    2 adds in trunk

<style scoped>: Allow <style scoped> as a direct child of a ShadowRoot
​https://bugs.webkit.org/show_bug.cgi?id=77853

.:

numberOfScopedHTMLStyleChildren got moved from Element into Node.

Reviewed by Dimitri Glazkov.

  • Source/autotools/symbols.filter:

Source/WebCore:

Moved registration code from Element to Node. updated Internals and build files accordingly.
Moved registration data members from ElementRareData to NodeRareData.
Forward willRemove() from host element into shadow DOM tree.

Reviewed by Dimitri Glazkov.

Test: fast/css/style-scoped/registering-shadowroot.html

  • WebCore.exp.in:
  • dom/Element.cpp:

(WebCore::Element::willRemove):

  • dom/Element.h:

(Element):

  • dom/ElementRareData.h:

(ElementRareData):
(WebCore::ElementRareData::ElementRareData):

  • dom/Node.cpp:

(WebCore):
(WebCore::Node::hasScopedHTMLStyleChild):
(WebCore::Node::numberOfScopedHTMLStyleChildren):
(WebCore::Node::registerScopedHTMLStyleChild):
(WebCore::Node::unregisterScopedHTMLStyleChild):

  • dom/Node.h:

(Node):

  • dom/NodeRareData.h:

(WebCore::NodeRareData::NodeRareData):
(NodeRareData):
(WebCore::NodeRareData::registerScopedHTMLStyleChild):
(WebCore::NodeRareData::unregisterScopedHTMLStyleChild):
(WebCore::NodeRareData::hasScopedHTMLStyleChild):
(WebCore::NodeRareData::numberOfScopedHTMLStyleChildren):

  • dom/ShadowRootList.cpp:

(WebCore::ShadowRootList::willRemove):
(WebCore):

  • dom/ShadowRootList.h:

(ShadowRootList):

  • html/HTMLStyleElement.cpp:

(WebCore::HTMLStyleElement::registerWithScopingNode):
(WebCore::HTMLStyleElement::unregisterWithScopingNode):

  • testing/Internals.cpp:

(WebCore::Internals::numberOfScopedHTMLStyleChildren):

  • testing/Internals.h:

(Internals):

  • testing/Internals.idl:

Source/WebKit2:

numberOfScopedHTMLStyleChildren got moved from Element into Node.

Reviewed by Dimitri Glazkov.

  • win/WebKit2.def:
  • win/WebKit2CFLite.def:

LayoutTests:

Test registration of <style scoped> as a direct child of a ShadowRoot.

Reviewed by Dimitri Glazkov.

  • fast/css/style-scoped/registering-shadowroot-expected.txt: Added.
  • fast/css/style-scoped/registering-shadowroot.html: Added.
1:12 AM Changeset in webkit [107792] by pfeldman@chromium.org
  • 25 edits in trunk

Web Inspector: implement redo for DOM actions.
​https://bugs.webkit.org/show_bug.cgi?id=78601

Patch by Pavel Feldman <​pfeldman@chromium.org> on 2012-02-14
Reviewed by Yury Semikhatsky.

Source/WebCore:

  • inspector/DOMEditor.cpp:

(WebCore::DOMEditor::RemoveChildAction::perform):
(WebCore::DOMEditor::RemoveChildAction::redo):
(DOMEditor::RemoveChildAction):
(WebCore::DOMEditor::InsertBeforeAction::redo):
(DOMEditor::InsertBeforeAction):
(WebCore::DOMEditor::RemoveAttributeAction::perform):
(WebCore::DOMEditor::RemoveAttributeAction::redo):
(DOMEditor::RemoveAttributeAction):
(WebCore::DOMEditor::SetAttributeAction::perform):
(WebCore::DOMEditor::SetAttributeAction::redo):
(DOMEditor::SetAttributeAction):
(WebCore::DOMEditor::SetOuterHTMLAction::redo):
(DOMEditor::SetOuterHTMLAction):
(WebCore::DOMEditor::ReplaceWholeTextAction::perform):
(WebCore::DOMEditor::ReplaceWholeTextAction::redo):
(DOMEditor::ReplaceWholeTextAction):
(WebCore::DOMEditor::ReplaceChildNodeAction::perform):
(WebCore::DOMEditor::ReplaceChildNodeAction::redo):
(DOMEditor::ReplaceChildNodeAction):
(WebCore::DOMEditor::SetNodeValueAction::perform):
(WebCore::DOMEditor::SetNodeValueAction::redo):
(DOMEditor::SetNodeValueAction):

  • inspector/Inspector.json:
  • inspector/InspectorCSSAgent.cpp:

(WebCore::InspectorCSSAgent::SetStyleSheetTextAction::perform):
(WebCore::InspectorCSSAgent::SetStyleSheetTextAction::undo):
(WebCore::InspectorCSSAgent::SetStyleSheetTextAction::redo):
(WebCore::InspectorCSSAgent::SetPropertyTextAction::perform):
(InspectorCSSAgent::SetPropertyTextAction):
(WebCore::InspectorCSSAgent::SetPropertyTextAction::undo):
(WebCore::InspectorCSSAgent::SetPropertyTextAction::redo):
(WebCore::InspectorCSSAgent::TogglePropertyAction::perform):
(WebCore::InspectorCSSAgent::TogglePropertyAction::redo):
(InspectorCSSAgent::TogglePropertyAction):
(WebCore::InspectorCSSAgent::SetRuleSelectorAction::perform):
(WebCore::InspectorCSSAgent::SetRuleSelectorAction::redo):
(InspectorCSSAgent::SetRuleSelectorAction):
(WebCore::InspectorCSSAgent::AddRuleAction::perform):
(WebCore::InspectorCSSAgent::AddRuleAction::redo):
(InspectorCSSAgent::AddRuleAction):

  • inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::setNodeValue):
(WebCore::InspectorDOMAgent::redo):
(WebCore):

  • inspector/InspectorDOMAgent.h:

(InspectorDOMAgent):

  • inspector/InspectorHistory.cpp:

(WebCore::InspectorHistory::InspectorHistory):
(WebCore::InspectorHistory::perform):
(WebCore::InspectorHistory::markUndoableState):
(WebCore::InspectorHistory::undo):
(WebCore::InspectorHistory::redo):
(WebCore):

  • inspector/InspectorHistory.h:

(Action):
(InspectorHistory):

  • inspector/front-end/CSSStyleModel.js:

(WebInspector.CSSStyleModel):
(WebInspector.CSSStyleModel.prototype._undoRedoRequested):
(WebInspector.CSSStyleModel.prototype._undoRedoCompleted):

  • inspector/front-end/DOMAgent.js:

(WebInspector.DOMAgent.prototype.get undo):
(WebInspector.DOMAgent.prototype.redo):

  • inspector/front-end/ElementsPanel.js:

(WebInspector.ElementsPanel.prototype.handleShortcut):

LayoutTests:

  • http/tests/inspector/elements-test.js:

(initialize_ElementTest.InspectorTest.generateUndoTest):

  • inspector/elements/undo-dom-edits-2-expected.txt:
  • inspector/elements/undo-dom-edits-expected.txt:
  • inspector/styles/undo-add-new-rule-expected.txt:
  • inspector/styles/undo-add-new-rule.html:
  • inspector/styles/undo-add-property-expected.txt:
  • inspector/styles/undo-add-property.html:
  • inspector/styles/undo-change-property-expected.txt:
  • inspector/styles/undo-change-property.html:
  • inspector/styles/undo-property-toggle-expected.txt:
  • inspector/styles/undo-property-toggle.html:
  • inspector/styles/undo-set-selector-text-expected.txt:
  • inspector/styles/undo-set-selector-text.html:
12:59 AM Changeset in webkit [107791] by Nikolas Zimmermann
  • 105 edits in trunk/LayoutTests

2012-02-14 Nikolas Zimmermann <​nzimmermann@rim.com>

Convert svg/animations to use SMIL methods for driving the timeline
​https://bugs.webkit.org/show_bug.cgi?id=78422

Rubber-stamped by Simon Hausmann.

Further cleanup of the svg/animation tests. Always use "0.001" as sampling time
for "just-after-anim-begin" instead of 0.1/0.01 variations. Use "3.999" as
"just-before-anim-end" time instead of 3.9/3.99 variations.

Use a default tolerance of 0.1, instead of the strict 0.01, to avoid having
to expect values like "199.98". Use "200" instead. That doesn't reduce the
value of any of the tests, but its likely to be more stable.

Changed some real-quick running animamtions to have a higher duration.
This minimizes the sampling time error when sampling the animation right after
it started (svg/animation/*nested-transforms*). This doesn't affect the runtime
of the tests at all, as we manually drive the timeline anyways.

Always use shouldBe() instead of shouldBeCloseEnough() if the sampling time
is an integer, like 2.0 for animations that eg. animate x from 0 to 200.
Sampling exactly at 2.0, yields 100, so there's no need to check for equal
with tolerance.

  • platform/chromium/test_expectations.txt:
  • svg/animations/animate-calcMode-spline-by-expected.txt:
  • svg/animations/animate-calcMode-spline-from-by-expected.txt:
  • svg/animations/animate-calcMode-spline-from-to-expected.txt:
  • svg/animations/animate-calcMode-spline-to-expected.txt:
  • svg/animations/animate-calcMode-spline-values-expected.txt:
  • svg/animations/animate-path-animation-Cc-Ss-expected.txt:
  • svg/animations/animate-path-animation-Ll-Vv-Hh-expected.txt:
  • svg/animations/animate-path-animation-cC-sS-inverse-expected.txt:
  • svg/animations/animate-path-animation-lL-vV-hH-inverse-expected.txt:
  • svg/animations/animate-path-nested-transforms-expected.txt:
  • svg/animations/animate-path-to-animation-expected.txt:
  • svg/animations/animate-text-nested-transforms-expected.txt:
  • svg/animations/resources/SVGAnimationTestCase.js: (shouldBeCloseEnough):
  • svg/animations/script-tests/animVal-basics.js: (sample3):
  • svg/animations/script-tests/animate-calcMode-spline-by.js: (sample2): (sample3):
  • svg/animations/script-tests/animate-calcMode-spline-from-by.js: (sample2): (sample3):
  • svg/animations/script-tests/animate-calcMode-spline-from-to.js: (sample2): (sample3):
  • svg/animations/script-tests/animate-calcMode-spline-to.js: (sample2): (sample3):
  • svg/animations/script-tests/animate-calcMode-spline-values.js: (sample2): (sample3):
  • svg/animations/script-tests/animate-color-rgba-calcMode-discrete.js: (executeTest):
  • svg/animations/script-tests/animate-dynamic-update-attributeName.js: (executeTest):
  • svg/animations/script-tests/animate-end-attribute.js: (sample3):
  • svg/animations/script-tests/animate-mpath-insert.js: (endSample): (executeTest):
  • svg/animations/script-tests/animate-path-animation-Cc-Ss.js: (sample2): (sample3): (sample4):
  • svg/animations/script-tests/animate-path-animation-Ll-Vv-Hh.js: (sample2): (sample3): (sample4):
  • svg/animations/script-tests/animate-path-animation-Qq-Tt.js: (sample2): (sample3): (sample4):
  • svg/animations/script-tests/animate-path-animation-cC-sS-inverse.js: (sample2): (sample3): (sample4):
  • svg/animations/script-tests/animate-path-animation-lL-vV-hH-inverse.js: (sample2): (sample3): (sample4):
  • svg/animations/script-tests/animate-path-animation-qQ-tT-inverse.js: (sample2): (sample3): (sample4):
  • svg/animations/script-tests/animate-path-nested-transforms.js: (endSample): (executeTest):
  • svg/animations/script-tests/animate-path-to-animation.js: (sample2): (sample3):
  • svg/animations/script-tests/animate-text-nested-transforms.js: (endSample): (executeTest):
  • svg/animations/script-tests/animateTransform-pattern-transform.js: (sample3):
  • svg/animations/script-tests/svgangle-animation-deg-to-grad.js: (sample2): (sample3):
  • svg/animations/script-tests/svgangle-animation-deg-to-rad.js: (sample2): (sample3):
  • svg/animations/script-tests/svgangle-animation-grad-to-deg.js: (sample2): (sample3):
  • svg/animations/script-tests/svgangle-animation-grad-to-rad.js: (sample2): (sample3):
  • svg/animations/script-tests/svgangle-animation-rad-to-deg.js: (sample2): (sample3):
  • svg/animations/script-tests/svgangle-animation-rad-to-grad.js: (sample2): (sample3):
  • svg/animations/script-tests/svginteger-animation-1.js: (sample3):
  • svg/animations/script-tests/svglength-animation-LengthModeHeight.js: (sample2): (sample3):
  • svg/animations/script-tests/svglength-animation-LengthModeOther.js: (sample2): (sample3):
  • svg/animations/script-tests/svglength-animation-LengthModeWidth.js: (sample2): (sample3):
  • svg/animations/script-tests/svglength-animation-number-to-number.js: (sample2): (sample3):
  • svg/animations/script-tests/svglength-animation-px-to-cm.js: (sample2): (sample3):
  • svg/animations/script-tests/svglength-animation-px-to-ems.js: (sample2): (sample3):
  • svg/animations/script-tests/svglength-animation-px-to-exs.js: (sample2): (sample3):
  • svg/animations/script-tests/svglength-animation-px-to-in.js: (sample2): (sample3):
  • svg/animations/script-tests/svglength-animation-px-to-number.js: (sample2): (sample3):
  • svg/animations/script-tests/svglength-animation-px-to-pc.js: (sample2): (sample3):
  • svg/animations/script-tests/svglength-animation-px-to-percentage.js: (sample2): (sample3):
  • svg/animations/script-tests/svglength-animation-px-to-pt.js: (sample2): (sample3):
  • svg/animations/script-tests/svglength-animation-px-to-px.js: (sample2): (sample3):
  • svg/animations/script-tests/svglength-animation-values.js: (sample2): (sample3): (sample4): (sample5):
  • svg/animations/script-tests/svglengthlist-animation-1.js: (sample3):
  • svg/animations/script-tests/svglengthlist-animation-2.js: (sample2): (sample3):
  • svg/animations/script-tests/svglengthlist-animation-3.js: (sample2): (sample3):
  • svg/animations/script-tests/svglengthlist-animation-4.js: (sample3):
  • svg/animations/script-tests/svglengthlist-animation-5.js: (sample3):
  • svg/animations/script-tests/svgnumber-animation-1.js: (sample3):
  • svg/animations/script-tests/svgnumber-animation-2.js: (sample3):
  • svg/animations/script-tests/svgnumberlist-animation-1.js: (sample2): (sample3):
  • svg/animations/script-tests/svgnumberlist-animation-2.js: (sample2): (sample3):
  • svg/animations/script-tests/svgnumberoptionalnumber-animation-1.js: (sample2): (sample3):
  • svg/animations/script-tests/svgnumberoptionalnumber-animation-2.js: (sample2): (sample3):
  • svg/animations/script-tests/svgnumberoptionalnumber-animation-3.js: (sample2): (sample3):
  • svg/animations/script-tests/svgnumberoptionalnumber-animation-4.js: (sample2): (sample3):
  • svg/animations/script-tests/svgpath-animation-1.js: (sample2): (sample3):
  • svg/animations/script-tests/svgpointlist-animation-1.js: (sample3):
  • svg/animations/script-tests/svgpointlist-animation-2.js: (sample3):
  • svg/animations/script-tests/svgrect-animation-1.js: (sample3):
  • svg/animations/script-tests/svgrect-animation-2.js: (sample3):
  • svg/animations/script-tests/svgtransform-animation-1.js: (sample1): (sample2): (sample3):
  • svg/animations/script-tests/svgtransform-animation-discrete.js: (sample1): (sample2): (sample3):
  • svg/animations/svgangle-animation-deg-to-grad-expected.txt:
  • svg/animations/svgangle-animation-deg-to-rad-expected.txt:
  • svg/animations/svgangle-animation-grad-to-deg-expected.txt:
  • svg/animations/svgangle-animation-grad-to-rad-expected.txt:
  • svg/animations/svgangle-animation-rad-to-deg-expected.txt:
  • svg/animations/svgangle-animation-rad-to-grad-expected.txt:
  • svg/animations/svglength-animation-LengthModeHeight-expected.txt:
  • svg/animations/svglength-animation-LengthModeOther-expected.txt:
  • svg/animations/svglength-animation-LengthModeWidth-expected.txt:
  • svg/animations/svglength-animation-number-to-number-expected.txt:
  • svg/animations/svglength-animation-px-to-cm-expected.txt:
  • svg/animations/svglength-animation-px-to-ems-expected.txt:
  • svg/animations/svglength-animation-px-to-exs-expected.txt:
  • svg/animations/svglength-animation-px-to-in-expected.txt:
  • svg/animations/svglength-animation-px-to-number-expected.txt:
  • svg/animations/svglength-animation-px-to-pc-expected.txt:
  • svg/animations/svglength-animation-px-to-percentage-expected.txt:
  • svg/animations/svglength-animation-px-to-pt-expected.txt:
  • svg/animations/svglength-animation-px-to-px-expected.txt:
  • svg/animations/svglength-animation-values-expected.txt:
  • svg/animations/svglengthlist-animation-2-expected.txt:
  • svg/animations/svgnumberlist-animation-1-expected.txt:
  • svg/animations/svgnumberlist-animation-2-expected.txt:
  • svg/animations/svgpath-animation-1-expected.txt:
  • svg/animations/svgpointlist-animation-1-expected.txt:
  • svg/animations/svgpointlist-animation-2-expected.txt:
  • svg/animations/svgrect-animation-1-expected.txt:
  • svg/animations/svgrect-animation-2-expected.txt:
  • svg/animations/svgtransform-animation-1-expected.txt:
12:53 AM Changeset in webkit [107790] by Philippe Normand
  • 5 edits in trunk/LayoutTests

Unreviewed, GTK rebaseline after r107785 and r107762. Also
skipping a new SVG failure.

  • platform/gtk/Skipped:
  • platform/gtk/fast/dom/Window/window-properties-expected.txt:
  • platform/gtk/media/video-controls-rendering-expected.txt:
  • platform/gtk/media/video-zoom-expected.txt:
12:45 AM Changeset in webkit [107789] by Csaba Osztrogonác
  • 2 edits
    1 add in trunk/LayoutTests

[Qt] Unreviewed morning gardening.

  • platform/qt/fast/dom/Range/surround-contents-font-face-crash-expected.txt: Added after r107749.
  • platform/qt/fast/dom/Window/window-properties-expected.txt: Updated after r107785.
12:43 AM Changeset in webkit [107788] by yutak@chromium.org
  • 5 edits
    4 adds in trunk

WebSocket: MessageEvent fired during send() on workers
​https://bugs.webkit.org/show_bug.cgi?id=76521

Reviewed by David Levin.

Source/WebCore:

WebSocket's message event should not be invoked while a synchronous operation
(send() and bufferedAmount) is in progress.

Test: http/tests/websocket/tests/hybi/workers/no-onmessage-in-sync-op.html

  • websockets/ThreadableWebSocketChannelClientWrapper.cpp:

Added #if ENABLE(WORKERS) because ThreadableWebSocketChannelClientWrapper is not used
if Web Workers is not available.
Changed access label because private members were declared as protected with no good reason.
(WebCore::ThreadableWebSocketChannelClientWrapper::ThreadableWebSocketChannelClientWrapper):
Receive ScriptExecutionContext so we can post a task that should be executed later.
(WebCore::ThreadableWebSocketChannelClientWrapper::create):
(WebCore::ThreadableWebSocketChannelClientWrapper::processPendingTasksCallback):
(WebCore::ThreadableWebSocketChannelClientWrapper::processPendingTasks):

  • websockets/ThreadableWebSocketChannelClientWrapper.h:
  • websockets/WorkerThreadableWebSocketChannel.cpp:

(WebCore::WorkerThreadableWebSocketChannel::WorkerThreadableWebSocketChannel):

LayoutTests:

  • http/tests/websocket/tests/hybi/workers/no-onmessage-in-sync-op-expected.txt: Added.
  • http/tests/websocket/tests/hybi/workers/no-onmessage-in-sync-op.html: Added.
  • http/tests/websocket/tests/hybi/workers/resources/no-onmessage-in-sync-op.js:

Added. The server sends messages immediately after the connection is established, but
these messages should not be delivered until the script exits the current cycle of
the event loop. The script calls a few synchronous operations to make sure we don't
fire MessageEvents while we are waiting for these operations to finish.

  • http/tests/websocket/tests/hybi/workers/resources/no-onmessage-in-sync-op_wsh.py: Added.
12:26 AM Changeset in webkit [107787] by noam.rosenthal@nokia.com
  • 17 edits
    2 moves in trunk/Source

[Texmap] Divide TextureMapperNode.cpp to 3 files.
​https://bugs.webkit.org/show_bug.cgi?id=76660

Source/WebCore:

Rename TextureMapperNode to TextureMapperLayer.

Reviewed by Kenneth Rohde Christiansen.

No new tests.

  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:

(WebCore::GraphicsLayerTextureMapper::GraphicsLayerTextureMapper):
(WebCore::GraphicsLayerTextureMapper::notifyChange):
(WebCore::GraphicsLayerTextureMapper::setNeedsDisplay):
(WebCore::GraphicsLayerTextureMapper::setContentsNeedsDisplay):
(WebCore::GraphicsLayerTextureMapper::setNeedsDisplayInRect):
(WebCore::GraphicsLayerTextureMapper::setParent):
(WebCore::GraphicsLayerTextureMapper::setChildren):
(WebCore::GraphicsLayerTextureMapper::addChild):
(WebCore::GraphicsLayerTextureMapper::addChildAtIndex):
(WebCore::GraphicsLayerTextureMapper::addChildAbove):
(WebCore::GraphicsLayerTextureMapper::addChildBelow):
(WebCore::GraphicsLayerTextureMapper::replaceChild):
(WebCore::GraphicsLayerTextureMapper::removeFromParent):
(WebCore::GraphicsLayerTextureMapper::setMaskLayer):
(WebCore::GraphicsLayerTextureMapper::setReplicatedByLayer):
(WebCore::GraphicsLayerTextureMapper::setPosition):
(WebCore::GraphicsLayerTextureMapper::setAnchorPoint):
(WebCore::GraphicsLayerTextureMapper::setSize):
(WebCore::GraphicsLayerTextureMapper::setTransform):
(WebCore::GraphicsLayerTextureMapper::setChildrenTransform):
(WebCore::GraphicsLayerTextureMapper::setPreserves3D):
(WebCore::GraphicsLayerTextureMapper::setMasksToBounds):
(WebCore::GraphicsLayerTextureMapper::setDrawsContent):
(WebCore::GraphicsLayerTextureMapper::setContentsOpaque):
(WebCore::GraphicsLayerTextureMapper::setBackfaceVisibility):
(WebCore::GraphicsLayerTextureMapper::setOpacity):
(WebCore::GraphicsLayerTextureMapper::setContentsRect):
(WebCore::GraphicsLayerTextureMapper::setContentsToImage):
(WebCore::GraphicsLayerTextureMapper::setContentsToMedia):
(WebCore::GraphicsLayerTextureMapper::syncCompositingStateForThisLayerOnly):
(WebCore::GraphicsLayerTextureMapper::syncCompositingState):
(WebCore::GraphicsLayerTextureMapper::addAnimation):

  • platform/graphics/texmap/GraphicsLayerTextureMapper.h:

(WebCore):
(GraphicsLayerTextureMapper):
(WebCore::GraphicsLayerTextureMapper::layer):

  • platform/graphics/texmap/TextureMapperLayer.cpp: Renamed from Source/WebCore/platform/graphics/texmap/TextureMapperNode.cpp.

(WebCore):
(WebCore::toTextureMapperLayer):
(WebCore::TextureMapperLayer::rootLayer):
(WebCore::TextureMapperLayer::setTransform):
(WebCore::TextureMapperLayer::clearBackingStoresRecursive):
(WebCore::TextureMapperLayer::computeTransformsRecursive):
(WebCore::TextureMapperLayer::updateBackingStore):
(WebCore::TextureMapperLayer::paint):
(WebCore::TextureMapperLayer::paintSelf):
(WebCore::TextureMapperLayer::compareGraphicsLayersZValue):
(WebCore::TextureMapperLayer::sortByZOrder):
(WebCore::TextureMapperLayer::paintSelfAndChildren):
(WebCore::TextureMapperLayer::intermediateSurfaceRect):
(WebCore::TextureMapperLayer::shouldPaintToIntermediateSurface):
(WebCore::TextureMapperLayer::isVisible):
(WebCore::TextureMapperLayer::paintSelfAndChildrenWithReplica):
(WebCore::TextureMapperLayer::paintRecursive):
(WebCore::TextureMapperLayer::~TextureMapperLayer):
(WebCore::TextureMapperLayer::syncCompositingState):
(WebCore::TextureMapperLayer::syncCompositingStateSelf):
(WebCore::TextureMapperLayer::descendantsOrSelfHaveRunningAnimations):
(WebCore::TextureMapperLayer::syncAnimations):
(WebCore::TextureMapperLayer::syncAnimationsRecursively):

  • platform/graphics/texmap/TextureMapperLayer.h: Renamed from Source/WebCore/platform/graphics/texmap/TextureMapperNode.h.

(WebCore):
(TextureMapperPaintOptions):
(WebCore::TextureMapperPaintOptions::TextureMapperPaintOptions):
(TextureMapperLayer):
(WebCore::TextureMapperLayer::TextureMapperLayer):
(WebCore::TextureMapperLayer::size):
(WebCore::TextureMapperLayer::setOpacity):
(WebCore::TextureMapperLayer::setTextureMapper):
(WebCore::TextureMapperLayer::setShouldUpdateBackingStoreFromLayer):
(WebCore::TextureMapperLayer::setBackingStore):
(WebCore::TextureMapperLayer::backingStore):
(WebCore::TextureMapperLayer::texture):
(WebCore::TextureMapperLayer::layerRect):
(State):
(WebCore::TextureMapperLayer::State::State):

Source/WebKit/gtk:

Rename TextureMapperNode to TextureMapperLayer.

Reviewed by Kenneth Rohde Christiansen.

  • WebCoreSupport/AcceleratedCompositingContext.h:

(AcceleratedCompositingContext):

  • WebCoreSupport/AcceleratedCompositingContextGL.cpp:

(WebKit::AcceleratedCompositingContext::AcceleratedCompositingContext):
(WebKit::AcceleratedCompositingContext::enabled):
(WebKit::AcceleratedCompositingContext::renderLayersToWindow):
(WebKit::AcceleratedCompositingContext::attachRootGraphicsLayer):
(WebKit::AcceleratedCompositingContext::syncLayersTimeout):

Source/WebKit/qt:

Rename TextureMapperNode to TextureMapperLayer.

Reviewed by Kenneth Rohde Christiansen.

  • Api/qwebframe.cpp:

(QWebFramePrivate::renderCompositedLayers):

  • Api/qwebframe.h:

(WebCore):

  • Api/qwebframe_p.h:

(WebCore):
(QWebFramePrivate::QWebFramePrivate):
(QWebFramePrivate):

  • WebCoreSupport/PageClientQt.cpp:

(WebCore::TextureMapperLayerClientQt::TextureMapperLayerClientQt):
(WebCore::TextureMapperLayerClientQt::setTextureMapper):
(WebCore::TextureMapperLayerClientQt::~TextureMapperLayerClientQt):
(WebCore::TextureMapperLayerClientQt::syncRootLayer):
(WebCore::TextureMapperLayerClientQt::rootLayer):
(WebCore::PageClientQWidget::setRootGraphicsLayer):
(WebCore::PageClientQWidget::syncLayers):
(WebCore::PageClientQGraphicsWidget::syncLayers):
(WebCore::PageClientQGraphicsWidget::setRootGraphicsLayer):

  • WebCoreSupport/PageClientQt.h:

(TextureMapperLayerClientQt):
(PageClientQWidget):
(PageClientQGraphicsWidget):

Source/WebKit2:

Rename TextureMapperNode to TextureMapperLayer.

Reviewed by Kenneth Rohde Christiansen.

  • UIProcess/qt/LayerTreeHostProxyQt.cpp:

(WebKit::LayerTreeHostProxy::createLayer):
(WebKit::LayerTreeHostProxy::paintToCurrentGLContext):
(WebKit::LayerTreeHostProxy::paintToGraphicsContext):
(WebKit::LayerTreeHostProxy::getBackingStore):
(WebKit::LayerTreeHostProxy::ensureRootLayer):
(WebKit::LayerTreeHostProxy::purgeGLResources):

12:21 AM Changeset in webkit [107786] by hayato@chromium.org
  • 3 edits in trunk/Source/WebCore

ShadowRoot: Remove a public static factory function which doesn't have any callers.
​https://bugs.webkit.org/show_bug.cgi?id=78668

Reviewed by Kent Tamura.

No tests. No change in behavior.

  • dom/ShadowRoot.cpp:

(WebCore::ShadowRoot::create):

  • dom/ShadowRoot.h:

(ShadowRoot):

12:04 AM Changeset in webkit [107785] by noel.gordon@gmail.com
  • 9 edits
    2 moves
    2 adds
    6 deletes in trunk/LayoutTests

[chromium] Rebaseline JPEG image results after r107389
​https://bugs.webkit.org/show_bug.cgi?id=78454

Unreviewed. Rebaseline #11 of N.

  • platform/chromium-linux/svg/custom/image-rescale-clip-expected.png:
  • platform/chromium-linux/svg/custom/image-rescale-clip-expected.txt: Removed.
  • platform/chromium-linux/svg/custom/image-rescale-scroll-expected.png:
  • platform/chromium-linux/svg/custom/image-rescale-scroll-expected.txt: Removed.
  • platform/chromium-mac-leopard/svg/custom/image-rescale-clip-expected.png:
  • platform/chromium-mac-leopard/svg/custom/image-rescale-scroll-expected.png:
  • platform/chromium-mac-snowleopard/svg/custom/image-rescale-clip-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/custom/image-rescale-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/custom/image-rescale-scroll-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/custom/image-rescale-scroll-expected.png.
  • platform/chromium-mac/svg/custom/image-rescale-clip-expected.png: Removed.
  • platform/chromium-mac/svg/custom/image-rescale-expected.png: Removed.
  • platform/chromium-win/svg/custom/image-rescale-clip-expected.png:
  • platform/chromium-win/svg/custom/image-rescale-expected.png:
  • platform/chromium-win/svg/custom/image-rescale-scroll-expected.png:
  • platform/chromium/test_expectations.txt:
  • platform/mac/svg/custom/image-rescale-expected.txt: Removed.
  • platform/qt/svg/custom/image-rescale-expected.txt: Removed.
  • svg/custom/image-rescale-expected.txt: Renamed from LayoutTests/platform/gtk/svg/custom/image-rescale-expected.txt.

Feb 14, 2012:

11:03 PM Changeset in webkit [107784] by commit-queue@webkit.org
  • 5 edits in trunk

Cleanup pending transaction queue in Database.
​https://bugs.webkit.org/show_bug.cgi?id=75048

Patch by Hao Zheng <​zhenghao@chromium.org> on 2012-02-14
Reviewed by David Levin.

Source/WebCore:

Each SQLTransaction has 3 SQLCallbackWrappers, and each of them
holds a ref to WorkerContext. As a result, if the worker thread is
stopped before all SQLTransactions are finished, the ASSERT of
m_workerContext->hasOneRef() in WorkerThread::workerThread() would fail.

No new tests.
REGRESSION(r103429) fast/workers/storage/use-same-database-in-page-and-workers.html asserts

  • storage/Database.cpp:

(WebCore::Database::close): Cleanup pending transaction queue in close().

  • storage/SQLCallbackWrapper.h:

(WebCore::SQLCallbackWrapper::clear):
(SafeReleaseTask): Make SafeReleaseTask a cleanup task, which is
necessary because at the time of SafeReleaseTask is performed,
WorkerRunLoop has been terminated and only runs cleanup tasks.
(WebCore::SQLCallbackWrapper::SafeReleaseTask::create):
(WebCore::SQLCallbackWrapper::SafeReleaseTask::performTask):
(WebCore::SQLCallbackWrapper::SafeReleaseTask::isCleanupTask):
(WebCore::SQLCallbackWrapper::SafeReleaseTask::SafeReleaseTask):

LayoutTests:

As crash is fixed, trun BUGWK75048 into BUGWK75111, so that we can
close 75048 and fix the timeout in 75111 for both DEBUG and RELEASE.

REGRESSION(r103429) fast/workers/storage/use-same-database-in-page-and-workers.html asserts

  • platform/chromium/test_expectations.txt:
10:58 PM Changeset in webkit [107783] by Antti Koivisto
  • 4 edits in trunk/Source/WebCore

​https://bugs.webkit.org/show_bug.cgi?id=78662
CSSStyleSelector should not rely on parent rule pointer in StylePropertySet

Reviewed by Andreas Kling.

Pass the rule pointer down to the style applying so we don't need to rely on
StylePropertySet having one.

To make this easier the patch also refactors the matched properties vector to
be part of MatchResult object instead of a member of CSSStyleSelector.

Rename Declaration -> Properties.

  • css/CSSFontSelector.cpp:

(WebCore::CSSFontSelector::dispatchInvalidationCallbacks):

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::CSSStyleSelector):
(WebCore::CSSStyleSelector::sweepMatchedPropertiesCache):
(WebCore::CSSStyleSelector::addMatchedProperties):
(WebCore::CSSStyleSelector::sortAndTransferMatchedRules):
(WebCore::CSSStyleSelector::matchScopedAuthorRules):
(WebCore::CSSStyleSelector::matchAuthorRules):
(WebCore::CSSStyleSelector::matchUserRules):
(WebCore::CSSStyleSelector::matchUARules):
(WebCore::CSSStyleSelector::collectMatchingRulesForList):
(WebCore::CSSStyleSelector::matchAllRules):
(WebCore):
(WebCore::CSSStyleSelector::initForStyleResolve):
(WebCore::CSSStyleSelector::matchesRuleSet):
(WebCore::CSSStyleSelector::styleForElement):
(WebCore::CSSStyleSelector::styleForKeyframe):
(WebCore::CSSStyleSelector::pseudoStyleForElement):
(WebCore::CSSStyleSelector::styleForPage):
(WebCore::CSSStyleSelector::pseudoStyleRulesForElement):
(WebCore::isInsideRegionRule):
(WebCore::CSSStyleSelector::applyProperties):
(WebCore::CSSStyleSelector::applyMatchedProperties):
(WebCore::CSSStyleSelector::computeMatchedPropertiesHash):
(WebCore::operator==):
(WebCore::operator!=):
(WebCore::CSSStyleSelector::findFromMatchedPropertiesCache):
(WebCore::CSSStyleSelector::addToMatchedPropertiesCache):
(WebCore::CSSStyleSelector::invalidateMatchedPropertiesCache):
(WebCore::isCacheableInMatchedPropertiesCache):
(WebCore::CSSStyleSelector::matchPageRules):

  • css/CSSStyleSelector.h:

(CSSStyleSelector):
(WebCore::CSSStyleSelector::addMatchedRule):
(WebCore::CSSStyleSelector::MatchedProperties::MatchedProperties):
(MatchedProperties):
(MatchResult):
(MatchedPropertiesCacheItem):

10:56 PM Changeset in webkit [107782] by toyoshim@chromium.org
  • 3 edits
    1 add in trunk/Source/WebKit/chromium

Provide SocketStreamHandleInternal::toWebSocketStreamHandle(SocketStreamHandle*).
​https://bugs.webkit.org/show_bug.cgi?id=78581

Reviewed by Kent Tamura.

Now, there is no way to convert SocketStreamHandle to
WebSocketStreamHandle. In subsequent changes, I'll use this function
in FrameLoaderClientImpl.

  • src/SocketStreamHandle.cpp: Remove SocketStreamHandleInternal class declaration.
  • src/SocketStreamHandleInternal.h: Move SocketStreamHandleInternal class declaration from SocketStreamHandle.cpp to expose, and add conversion function to WebSocketStreamHandle from SocketStreamHandle.

(WebKit):
(WebCore):
(SocketStreamHandleInternal):
(WebCore::SocketStreamHandleInternal::create):
(WebCore::SocketStreamHandleInternal::toWebSocketStreamHandle):

  • WebKit.gyp: Add SocketStreamHandleInternal.h entry.
10:56 PM Changeset in webkit [107781] by tkent@chromium.org
  • 62 edits
    64 deletes in trunk/LayoutTests

Stop using script-tests in LayoutTests/fast/forms
​https://bugs.webkit.org/show_bug.cgi?id=78667

Reviewed by Kentaro Hara.

  • fast/forms/ValidityState-patternMismatch-unsupported.html:
  • fast/forms/ValidityState-rangeOverflow.html:
  • fast/forms/ValidityState-rangeUnderflow.html:
  • fast/forms/ValidityState-stepMismatch.html:
  • fast/forms/ValidityState-tooLong-input.html:
  • fast/forms/ValidityState-tooLong-textarea.html:
  • fast/forms/ValidityState-typeMismatch-date-expected.txt: Removed.
  • fast/forms/ValidityState-typeMismatch-url.html:
  • fast/forms/ValidityState-valueMissing-radio.html:
  • fast/forms/checkValidity-cancel.html:
  • fast/forms/checkValidity-handler-updates-dom.html:
  • fast/forms/form-attribute-elements-order.html:
  • fast/forms/form-attribute-elements-order2.html:
  • fast/forms/form-attribute-elements.html:
  • fast/forms/form-attribute.html:
  • fast/forms/form-collection-elements-order.html:
  • fast/forms/form-collection-elements.html:
  • fast/forms/formnovalidate-attribute.html:
  • fast/forms/incremental-dom-property.html:
  • fast/forms/input-maxlength-ime-completed.html:
  • fast/forms/input-maxlength-ime-preedit.html:
  • fast/forms/input-maxlength-unsupported.html:
  • fast/forms/input-minmax.html:
  • fast/forms/input-pattern.html:
  • fast/forms/input-step.html:
  • fast/forms/input-stepup-stepdown.html:
  • fast/forms/input-type-change3.html:
  • fast/forms/input-valueasnumber-unsupported.html:
  • fast/forms/labels-add-htmlFor-label.html:
  • fast/forms/labels-add-parent-label.html:
  • fast/forms/labels-change-htmlFor-attribute.html:
  • fast/forms/labels-item-index.html:
  • fast/forms/labels-remove-htmlFor-attribute.html:
  • fast/forms/labels-remove-htmlFor-label.html:
  • fast/forms/labels-remove-parent-label.html:
  • fast/forms/labels-set-htmlFor-attribute.html:
  • fast/forms/listbox-deselect-scroll.html:
  • fast/forms/listbox-selection-2.html:
  • fast/forms/listbox-selection.html:
  • fast/forms/menulist-disabled-selected-option.html:
  • fast/forms/menulist-submit-without-selection.html:
  • fast/forms/novalidate-attribute.html:
  • fast/forms/output-reset-assertion-failed.html:
  • fast/forms/placeholder-dom-property.html:
  • fast/forms/script-tests/TEMPLATE.html: Removed.
  • fast/forms/script-tests/ValidityState-patternMismatch-unsupported.js: Removed.
  • fast/forms/script-tests/ValidityState-rangeOverflow.js: Removed.
  • fast/forms/script-tests/ValidityState-rangeUnderflow.js: Removed.
  • fast/forms/script-tests/ValidityState-stepMismatch.js: Removed.
  • fast/forms/script-tests/ValidityState-tooLong-input.js: Removed.
  • fast/forms/script-tests/ValidityState-tooLong-textarea.js: Removed.
  • fast/forms/script-tests/ValidityState-typeMismatch-date.js: Removed.
  • fast/forms/script-tests/ValidityState-typeMismatch-url.js: Removed.
  • fast/forms/script-tests/ValidityState-valueMissing-radio.js: Removed.
  • fast/forms/script-tests/checkValidity-cancel.js: Removed.
  • fast/forms/script-tests/checkValidity-handler-updates-dom.js: Removed.
  • fast/forms/script-tests/form-attribute-elements-order.js: Removed.
  • fast/forms/script-tests/form-attribute-elements-order2.js: Removed.
  • fast/forms/script-tests/form-attribute-elements.js: Removed.
  • fast/forms/script-tests/form-attribute.js: Removed.
  • fast/forms/script-tests/form-collection-elements-order.js: Removed.
  • fast/forms/script-tests/form-collection-elements.js: Removed.
  • fast/forms/script-tests/formnovalidate-attribute.js: Removed.
  • fast/forms/script-tests/incremental-dom-property.js: Removed.
  • fast/forms/script-tests/input-maxlength-ime-completed.js: Removed.
  • fast/forms/script-tests/input-maxlength-ime-preedit.js: Removed.
  • fast/forms/script-tests/input-maxlength-unsupported.js: Removed.
  • fast/forms/script-tests/input-minmax.js: Removed.
  • fast/forms/script-tests/input-pattern.js: Removed.
  • fast/forms/script-tests/input-step.js: Removed.
  • fast/forms/script-tests/input-stepup-stepdown.js: Removed.
  • fast/forms/script-tests/input-type-change3.js: Removed.
  • fast/forms/script-tests/input-valueasnumber-unsupported.js: Removed.
  • fast/forms/script-tests/labels-add-htmlFor-label.js: Removed.
  • fast/forms/script-tests/labels-add-parent-label.js: Removed.
  • fast/forms/script-tests/labels-change-htmlFor-attribute.js: Removed.
  • fast/forms/script-tests/labels-item-index.js: Removed.
  • fast/forms/script-tests/labels-remove-htmlFor-attribute.js: Removed.
  • fast/forms/script-tests/labels-remove-htmlFor-label.js: Removed.
  • fast/forms/script-tests/labels-remove-parent-label.js: Removed.
  • fast/forms/script-tests/labels-set-htmlFor-attribute.js: Removed.
  • fast/forms/script-tests/listbox-deselect-scroll.js: Removed.
  • fast/forms/script-tests/listbox-selection-2.js: Removed.
  • fast/forms/script-tests/listbox-selection.js: Removed.
  • fast/forms/script-tests/menulist-disabled-selected-option.js: Removed.
  • fast/forms/script-tests/menulist-submit-without-selection.js: Removed.
  • fast/forms/script-tests/novalidate-attribute.js: Removed.
  • fast/forms/script-tests/output-reset-assertion-failed.js: Removed.
  • fast/forms/script-tests/placeholder-dom-property.js: Removed.
  • fast/forms/script-tests/search-cancel-button-events.js: Removed.
  • fast/forms/script-tests/select-set-length-optgroup.js: Removed.
  • fast/forms/script-tests/select-set-length-with-mutation-remove.js: Removed.
  • fast/forms/script-tests/select-set-length-with-mutation-reorder.js: Removed.
  • fast/forms/script-tests/select-set-length-with-mutation-reparent.js: Removed.
  • fast/forms/script-tests/select-set-length-with-mutation.js: Removed.
  • fast/forms/script-tests/select-set-length.js: Removed.
  • fast/forms/script-tests/setCustomValidity-existence.js: Removed.
  • fast/forms/script-tests/shadow-tree-exposure.js: Removed.
  • fast/forms/script-tests/submit-form-attributes.js: Removed.
  • fast/forms/script-tests/text-control-intrinsic-widths.js: Removed.
  • fast/forms/script-tests/textarea-maxlength.js: Removed.
  • fast/forms/script-tests/textarea-metrics.js: Removed.
  • fast/forms/script-tests/textarea-placeholder-dom-property.js: Removed.
  • fast/forms/script-tests/textarea-rows-cols.js: Removed.
  • fast/forms/script-tests/textarea-textlength.js: Removed.
  • fast/forms/script-tests/validationMessage.js: Removed.
  • fast/forms/script-tests/willvalidate.js: Removed.
  • fast/forms/search-cancel-button-events.html:
  • fast/forms/select-set-length-optgroup.html:
  • fast/forms/select-set-length-with-mutation-remove.html:
  • fast/forms/select-set-length-with-mutation-reorder.html:
  • fast/forms/select-set-length-with-mutation-reparent.html:
  • fast/forms/select-set-length-with-mutation.html:
  • fast/forms/select-set-length.html:
  • fast/forms/setCustomValidity-existence.html:
  • fast/forms/shadow-tree-exposure.html:
  • fast/forms/submit-form-attributes.html:
  • fast/forms/text-control-intrinsic-widths.html:
  • fast/forms/textarea-maxlength.html:
  • fast/forms/textarea-metrics.html:
  • fast/forms/textarea-placeholder-dom-property.html:
  • fast/forms/textarea-rows-cols.html:
  • fast/forms/textarea-textlength.html:
  • fast/forms/validationMessage.html:
  • fast/forms/willvalidate.html:
10:39 PM Changeset in webkit [107780] by toyoshim@chromium.org
  • 5 edits in trunk/Source/WebCore

WebSocketChannel minor refactoring for code manageability
​https://bugs.webkit.org/show_bug.cgi?id=78576

Reviewed by Kent Tamura.

Change the first argument type of WebSocketChannel
from ScriptExecutionContext to Document.
WebSocketChannel always assume this ScriptExecutionContext must
inherit Document. Then, it results in many static cast.
It isn't readable and dangerous against future code changes.

  • websockets/ThreadableWebSocketChannel.cpp: Pass the first argument for WebSocketChannel as Document.

(WebCore::ThreadableWebSocketChannel::create):

  • websockets/WebSocketChannel.cpp: Replace all ScriptExecutionContext* m_context descriptions to Document* m_document.

(WebCore::WebSocketChannel::WebSocketChannel):
(WebCore::WebSocketChannel::connect):
(WebCore::WebSocketChannel::fail):
(WebCore::WebSocketChannel::disconnect):
(WebCore::WebSocketChannel::didOpenSocketStream):
(WebCore::WebSocketChannel::didCloseSocketStream):
(WebCore::WebSocketChannel::didReceiveSocketStreamData):
(WebCore::WebSocketChannel::didFailSocketStream):
(WebCore::WebSocketChannel::processBuffer):
(WebCore::WebSocketChannel::processOutgoingFrameQueue):

  • websockets/WebSocketChannel.h: Change the first argument for construction to Document and hold it as Document m_document.

(WebCore):
(WebCore::WebSocketChannel::create):
(WebSocketChannel):

  • websockets/WorkerThreadableWebSocketChannel.cpp: Pass the first argument for WebSocketChannel as Document.

(WebCore::WorkerThreadableWebSocketChannel::Peer::Peer):

10:00 PM Changeset in webkit [107779] by noel.gordon@gmail.com
  • 8 edits in trunk/Source/WebCore

Unreviewed, rolling out r107774.
​http://trac.webkit.org/changeset/107774
​https://bugs.webkit.org/show_bug.cgi?id=78661

Broke Chromium build

  • page/EventHandler.cpp:

(WebCore::EventHandler::handleGestureEvent):

  • platform/ScrollAnimator.cpp:

(WebCore):
(WebCore::ScrollAnimator::handleGestureEvent):

  • platform/ScrollAnimator.h:

(ScrollAnimator):

  • platform/ScrollView.cpp:

(WebCore::ScrollView::wheelEvent):

  • platform/ScrollView.h:

(ScrollView):

  • platform/ScrollableArea.cpp:

(WebCore):
(WebCore::ScrollableArea::handleGestureEvent):

  • platform/ScrollableArea.h:

(ScrollableArea):

9:19 PM Changeset in webkit [107778] by bashi@chromium.org
  • 7 edits
    3 deletes in trunk/Source

Unreviewed, rolling out r107766.
​http://trac.webkit.org/changeset/107766
​https://bugs.webkit.org/show_bug.cgi?id=78665

Breaks Chromium Win build (Requested by bashi1 on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-02-14

Source/WebCore:

  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • websockets/WebSocketDeflater.cpp: Removed.
  • websockets/WebSocketDeflater.h: Removed.

Source/WebKit/chromium:

  • WebKit.gypi:
  • tests/WebSocketDeflaterTest.cpp: Removed.
9:10 PM Changeset in webkit [107777] by noel.gordon@gmail.com
  • 9 edits
    2 adds
    2 deletes in trunk/LayoutTests

[chromium] Rebaseline JPEG image results after r107389
​https://bugs.webkit.org/show_bug.cgi?id=78454

Unreviewed. Rebaseline #10 of N.

  • platform/chromium-linux/svg/W3C-SVG-1.1/struct-image-01-t-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/struct-image-02-b-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/struct-image-04-t-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/struct-image-01-t-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/struct-image-02-b-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/struct-image-04-t-expected.png: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1/struct-image-01-t-expected.png: Removed.
  • platform/chromium-mac/svg/W3C-SVG-1.1/struct-image-04-t-expected.png: Removed.
  • platform/chromium-win/svg/W3C-SVG-1.1/struct-image-01-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/struct-image-02-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/struct-image-04-t-expected.png:
  • platform/chromium/test_expectations.txt:
8:13 PM Changeset in webkit [107776] by weinig@apple.com
  • 2 edits in trunk/Tools

Add #include of unistd.h on the mac for getcwd.

Reviewed by Anders Carlsson.

This is necessary when building with libc++.

  • WebKitTestRunner/TestInvocation.cpp:
8:10 PM Changeset in webkit [107775] by weinig@apple.com
  • 3 edits in trunk/Tools

In DRT, don't #define min or max on non-Windows platforms, it just isn't needed
​https://bugs.webkit.org/show_bug.cgi?id=78663

Reviewed by Anders Carlsson.

  • DumpRenderTree/DumpRenderTreePrefix.h:
  • DumpRenderTree/cg/ImageDiffCG.cpp:
7:56 PM Changeset in webkit [107774] by andersca@apple.com
  • 8 edits in trunk/Source/WebCore

Remove ScrollableArea::handleGestureEvent
​https://bugs.webkit.org/show_bug.cgi?id=78661

Reviewed by Sam Weinig.

ScrollableArea::handleGestureEvent ends up being a no-op so remove it and the related code.

  • page/EventHandler.cpp:

(WebCore::EventHandler::handleGestureEvent):

  • platform/ScrollAnimator.cpp:
  • platform/ScrollAnimator.h:

(ScrollAnimator):

  • platform/ScrollView.cpp:

(WebCore::ScrollView::wheelEvent):

  • platform/ScrollView.h:

(ScrollView):

  • platform/ScrollableArea.cpp:
  • platform/ScrollableArea.h:

(ScrollableArea):

7:42 PM Changeset in webkit [107773] by eae@chromium.org
  • 2758 edits
    1243 copies
    52 adds
    402 deletes in branches/subpixellayout

Merging trunk changes up until 107734 into subpixel branch.

7:22 PM Changeset in webkit [107772] by haraken@chromium.org
  • 9 edits
    2 adds in trunk

[JSC] Cache the number of non-custom constructor arguments
​https://bugs.webkit.org/show_bug.cgi?id=78195

Reviewed by Darin Adler.

Source/WebCore:

If [ConstructorParameters=] is specified, JSC caches the number of constructor
arguments for performance. However, at present, [ConstructorParameters=] is specified
on a small part of constructors (It appears that people have forgotten to
add [ConstructorParameters=]). Thus, for non-custom constructors, this patch modifies
CodeGeneratorJS.pm so that it caches the number of constructor arguments automatically
without [ConstructorParameters=] (CodeGeneratorJS.pm can know the number of arguments
by the [Constructor=...] signature).

Test: fast/js/constructor-length.html

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateConstructorDefinition):

LayoutTests:

The added tests check the length property of constructors.
The test fails for "flag-disabled" constructors.

  • fast/js/constructor-length.html: Added.
  • platform/mac/fast/js/constructor-length-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
  • platform/efl/Skipped:
  • platform/gtk/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
  • platform/wk2/Skipped:
7:04 PM Changeset in webkit [107771] by mrowe@apple.com
  • 2 edits in trunk/Source/WebCore

<​http://webkit.org/b/78658> platformUserPreferredLanguages is leaking all of the language codes

Reviewed by Darin Adler.

  • platform/mac/Language.mm:

(WebCore::httpStyleLanguageCode): Switch to using RetainPtr's for temporaries to make the ownership
more explicit. Switch to returning a WTF::String so that the caller doesn't have to worry about
ownership at all. Change the name to reflect the lack of transfer of ownership.
(WebCore::platformUserPreferredLanguages):

6:20 PM Changeset in webkit [107770] by haraken@chromium.org
  • 2 edits in trunk/Source/WebCore

[Mac] PasteboardMac.mm build fails
​https://bugs.webkit.org/show_bug.cgi?id=78655

Reviewed by Hajime Morita.

Although the bots have been working fine, PasteboardMac.mm build fails
in our local Mac environments due to an uninitialized variable:

/Users/haraken/WebKit/Source/WebCore/platform/mac/PasteboardMac.mm:322: warning: 'string' may be used uninitialized in this function

This patch initializes the 'string' to nil to fix the build failure.

No tests. No change in behavior.

  • platform/mac/PasteboardMac.mm:

(WebCore::Pasteboard::plainText):

6:11 PM Changeset in webkit [107769] by bashi@chromium.org
  • 16 edits in trunk/Source

[WebSocket] Add extension attribute support
​https://bugs.webkit.org/show_bug.cgi?id=78557

Source/WebCore:

Implement WebSocket "extensions" attribute that holds a list of
extension the server accepted. No change in behavior at this time
because we don't send any extension on handshake.

Reviewed by Kent Tamura.

No new tests. http/tests/websocket/tests/hybi/extensions.html checks the value of this attribute.

  • websockets/ThreadableWebSocketChannel.h: Add extensions().

(ThreadableWebSocketChannel):

  • websockets/ThreadableWebSocketChannelClientWrapper.cpp:

(WebCore::ThreadableWebSocketChannelClientWrapper::extensions): Added.
(WebCore):
(WebCore::ThreadableWebSocketChannelClientWrapper::setExtensions): Added.

  • websockets/ThreadableWebSocketChannelClientWrapper.h:

(ThreadableWebSocketChannelClientWrapper):

  • websockets/WebSocket.cpp: Added m_extensions member variable.

(WebCore::WebSocket::WebSocket):
(WebCore::WebSocket::extensions): Returns m_extensions.

  • websockets/WebSocket.h:
  • websockets/WebSocketChannel.cpp:

(WebCore::WebSocketChannel::extensions): Added.
(WebCore):

  • websockets/WebSocketChannel.h:

(WebSocketChannel):

  • websockets/WebSocketExtensionDispatcher.cpp:

(WebCore::WebSocketExtensionDispatcher::fail): Added.
(WebCore::WebSocketExtensionDispatcher::processHeaderValue): Stores accepted extensions.
(WebCore::WebSocketExtensionDispatcher::acceptedExtensions): Added.
(WebCore):
(WebCore::WebSocketExtensionDispatcher::acceptedExtensions): Added.

  • websockets/WebSocketExtensionDispatcher.h:

(WebSocketExtensionDispatcher):

  • websockets/WebSocketHandshake.cpp:

(WebCore::WebSocketHandshake::acceptedExtensions): Added.
(WebCore):

  • websockets/WebSocketHandshake.h:
  • websockets/WorkerThreadableWebSocketChannel.cpp:

(WebCore::WorkerThreadableWebSocketChannel::extensions): Added.
(WebCore):
(WebCore::workerContextDidConnect): Calls ThreadableWebSocketChannelClientWrapper::setExtensions().
(WebCore::WorkerThreadableWebSocketChannel::Peer::didConnect): Passes extensions as an argument.

  • websockets/WorkerThreadableWebSocketChannel.h:

(WorkerThreadableWebSocketChannel):

Source/WebKit/chromium:

Add WebSocketExtensionDispatcher::acceptedExtensions() checks.

Reviewed by Kent Tamura.

  • tests/WebSocketExtensionDispatcherTest.cpp:

(WebCore::TEST_F):

6:05 PM Changeset in webkit [107768] by haraken@chromium.org
  • 33 edits in trunk/Source/WebCore

Rename [JSGenerateToJS] to [JSGenerateToJSObject]
​https://bugs.webkit.org/show_bug.cgi?id=78490

Reviewed by Adam Barth.

This patch renames [JSGenerateToJS] to [JSGenerateToJSObject],
for naming consistency with [CustomToJSObject], [JSCustomToJSObject] and [V8CustomToJSObject].

No tests. No change in behavior.

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader):
(GenerateImplementation):

  • dom/WebKitNamedFlow.idl:
  • fileapi/DirectoryEntry.idl:
  • fileapi/DirectoryEntrySync.idl:
  • fileapi/File.idl:
  • fileapi/FileEntry.idl:
  • fileapi/FileEntrySync.idl:
  • html/DOMFormData.idl:
  • html/DOMSettableTokenList.idl:
  • html/DOMURL.idl:
  • html/MediaController.idl:
  • mediastream/LocalMediaStream.idl:
  • webaudio/AudioBufferCallback.idl:
  • webaudio/AudioBufferSourceNode.idl:
  • webaudio/AudioDestinationNode.idl:
  • webaudio/AudioGain.idl:
  • webaudio/AudioGainNode.idl:
  • webaudio/AudioPannerNode.idl:
  • webaudio/AudioProcessingEvent.idl:
  • webaudio/BiquadFilterNode.idl:
  • webaudio/ConvolverNode.idl:
  • webaudio/DelayNode.idl:
  • webaudio/DynamicsCompressorNode.idl:
  • webaudio/HighPass2FilterNode.idl:
  • webaudio/JavaScriptAudioNode.idl:
  • webaudio/LowPass2FilterNode.idl:
  • webaudio/MediaElementAudioSourceNode.idl:
  • webaudio/OfflineAudioCompletionEvent.idl:
  • webaudio/RealtimeAnalyserNode.idl:
  • webaudio/WaveShaperNode.idl:
  • workers/SharedWorker.idl:
  • workers/Worker.idl:
6:04 PM Changeset in webkit [107767] by noel.gordon@gmail.com
  • 13 edits
    1 move in trunk/LayoutTests

[chromium] Rebaseline JPEG image results after r107389
​https://bugs.webkit.org/show_bug.cgi?id=78454

Unreviewed. Rebaseline #9 of N.

  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-30-t-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/filters-image-01-b-expected.png:
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.png:
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1/filters-image-01-b-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-30-t-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.txt: Renamed from LayoutTests/platform/chromium/svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.txt.
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/filters-image-01-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-30-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-image-01-b-expected.png:
  • platform/chromium/test_expectations.txt:
6:02 PM Changeset in webkit [107766] by bashi@chromium.org
  • 7 edits
    3 adds in trunk/Source

Source/WebCore: [WebSocket] Add deflater/inflater classes
​https://bugs.webkit.org/show_bug.cgi?id=78449

Add WebSocketDeflater/WebSocketInflater classes which wrap zlib
functions. These classes are not used yet, but will be used for
supporting WebSocket deflate-frame extension.

Reviewed by Kent Tamura.

No new tests except for chromium port. Behavior is unchanged.

  • GNUmakefile.list.am: Added.WebSocketDeflater.(cpp|h).
  • WebCore.gypi: Ditto.
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • websockets/WebSocketDeflater.cpp: Added.

(WebCore):
(WebCore::WebSocketDeflater::create):
(WebCore::WebSocketDeflater::WebSocketDeflater):
(WebCore::WebSocketDeflater::initialize):
(WebCore::WebSocketDeflater::~WebSocketDeflater):
(WebCore::WebSocketDeflater::addBytes):
(WebCore::WebSocketDeflater::finish):
(WebCore::WebSocketDeflater::reset):
(WebCore::WebSocketInflater::create):
(WebCore::WebSocketInflater::WebSocketInflater):
(WebCore::WebSocketInflater::initialize):
(WebCore::WebSocketInflater::~WebSocketInflater):
(WebCore::WebSocketInflater::addBytes):
(WebCore::WebSocketInflater::finish):
(WebCore::WebSocketInflater::reset):

  • websockets/WebSocketDeflater.h: Added.

(WebCore):
(WebSocketDeflater):
(WebCore::WebSocketDeflater::data):
(WebCore::WebSocketDeflater::size):
(WebSocketInflater):
(WebCore::WebSocketInflater::data):
(WebCore::WebSocketInflater::size):

Source/WebKit/chromium: [WebSocket] Add deflater/inflater classes.
​https://bugs.webkit.org/show_bug.cgi?id=78449

Add tests which ensure WebSocketDeflater/WebSocketInflater can
compress/decompress data correctly.

Reviewed by Kent Tamura.

  • WebKit.gypi:
  • tests/WebSocketDeflaterTest.cpp: Added.

(WebCore):
(WebCore::TEST):

5:50 PM Changeset in webkit [107765] by leviw@chromium.org
  • 2 edits in branches/subpixellayout/Source/WebCore/rendering

Fixing up more border painting logic that should be integers instead of layout types.

5:47 PM Changeset in webkit [107764] by commit-queue@webkit.org
  • 1 edit
    3 adds in trunk/Source/WebKit

[BlackBerry] Upstreaming WebSettings code
​https://bugs.webkit.org/show_bug.cgi?id=78633

Patch by Nima Ghanavatian <​nghanavatian@rim.com> on 2012-02-14
Reviewed by Rob Buis.

Initial upstreaming, no new tests.

  • blackberry/Api/WebSettings.cpp: Added.
  • blackberry/Api/WebSettings.h: Added.
  • blackberry/Api/WebSettings_p.h: Added.
5:34 PM Changeset in webkit [107763] by commit-queue@webkit.org
  • 4 edits in trunk/Source

[chromium] Compare filters on impl thread when setting them, and test setting in unit tests
​https://bugs.webkit.org/show_bug.cgi?id=78643

Patch by Dana Jansens <​danakj@chromium.org> on 2012-02-14
Reviewed by James Robinson.

Source/WebCore:

Add setFilters() coverage to CCLayerImplTest.cpp

  • platform/graphics/chromium/cc/CCLayerImpl.cpp:

(WebCore::CCLayerImpl::setFilters):

Source/WebKit/chromium:

  • tests/CCLayerImplTest.cpp:

(WebCore::TEST):

5:34 PM Changeset in webkit [107762] by fischman@chromium.org
  • 16 edits in trunk/LayoutTests

Convert a couple of media layouttests to mock scrollbars & rebaseline
​https://bugs.webkit.org/show_bug.cgi?id=78634

Unreviewed layouttest rebaselining.

  • platform/chromium-gpu-linux/media/video-controls-rendering-expected.png:
  • platform/chromium-gpu-linux/media/video-zoom-expected.png:
  • platform/chromium-gpu-mac/media/video-controls-rendering-expected.png:
  • platform/chromium-gpu-mac/media/video-zoom-expected.png:
  • platform/chromium-gpu-win/media/video-controls-rendering-expected.png:
  • platform/chromium-gpu-win/media/video-zoom-expected.png:
  • platform/chromium-linux/media/video-controls-rendering-expected.png:
  • platform/chromium-linux/media/video-zoom-expected.png:
  • platform/chromium-mac-leopard/media/video-controls-rendering-expected.png:
  • platform/chromium-mac-leopard/media/video-zoom-expected.png:
  • platform/chromium-mac-snowleopard/media/video-controls-rendering-expected.png:
  • platform/chromium-mac-snowleopard/media/video-zoom-expected.png:
  • platform/chromium-win/media/video-controls-rendering-expected.png:
  • platform/chromium-win/media/video-zoom-expected.png:
  • platform/chromium/test_expectations.txt:
5:23 PM Changeset in webkit [107761] by rniwa@webkit.org
  • 3 edits
    2 adds in trunk

Crash in deleteInsignificantText
​https://bugs.webkit.org/show_bug.cgi?id=78567

Reviewed by Eric Seidel.

Source/WebCore:

Fix the crash. Also update layout at the beginning of each call to deleteInsignificantText
since the previous call may have mutated the DOM.

Test: editing/inserting/delete-insignificant-text-crash.html

  • editing/CompositeEditCommand.cpp:

(WebCore::CompositeEditCommand::deleteInsignificantText):

LayoutTests:

Add a regression test.

  • editing/inserting/delete-insignificant-text-crash.html: Added.
  • editing/inserting/delete-insignificant-text-crash.txt: Added.
5:20 PM Changeset in webkit [107760] by leviw@chromium.org
  • 6 edits in trunk/Source/WebCore

Prepare RenderLayerBacking and RenderLayerCompositor for subpixel layout
​https://bugs.webkit.org/show_bug.cgi?id=78630

Reviewed by Simon Fraser.

In our transition to subpixel layout in the render tree, we continue to pass RenderLayerBacking
and RenderLayerCompositor integer (pixel) sizes and positions. This patch moves nearly all
methods and members on these two classes back to integers, and applies pixel snapping logic to
LayoutUnits pulled in.

No new tests. No change in behavior.

  • rendering/RenderBox.h:

(WebCore::RenderBox::pixelSnappedLayoutOverflowRect): Convenience function for getting pixel
snapped overflow bounds.

  • rendering/RenderLayerBacking.cpp:

(WebCore):
(WebCore::RenderLayerBacking::updateCompositedBounds): Switch to integers and pixel snapping the
clipping bounds.
(WebCore::clipBox): Returns a pixel snapped rect.
(WebCore::RenderLayerBacking::updateGraphicsLayerGeometry): Using pixelSnappedLayerCoords. Removing
pixelSnappedIntRect calls to clipBox since this is now an IntRect.
(WebCore::RenderLayerBacking::computeTransformOrigin): Switching to operate on a pixel snapped rect.
(WebCore::RenderLayerBacking::computePerspectiveOrigin): Ditto.
(WebCore::RenderLayerBacking::contentOffsetInCompostingLayer): Returns a size based on m_compositingBounds,
which is now an IntSize.
(WebCore::RenderLayerBacking::contentsBox): Switching to use pixel snapped values from the render tree.
(WebCore::RenderLayerBacking::setContentsNeedDisplayInRect): This now takes in and outputs integers.
(WebCore::RenderLayerBacking::paintIntoLayer): Uses a pixel snapped rect for the dirty rect.
(WebCore::paintScrollbar): Scrollbars are Widgets & painted natively, so they should use integers.
(WebCore::RenderLayerBacking::paintContents): We now properly take in an integer clip rect, as it's
used for the scrollbars.
(WebCore::RenderLayerBacking::startAnimation): Using pixel snapped values for animations and transitions.
(WebCore::RenderLayerBacking::startTransition): Ditto.
(WebCore::RenderLayerBacking::compositedBounds): Composited bounds are now properly stored as integers.
(WebCore::RenderLayerBacking::setCompositedBounds): Ditto.

  • rendering/RenderLayerBacking.h:

(RenderLayerBacking):

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::calculateCompositedBounds): Composited bounds are pixel snapped, but
we use LayoutUnits up until we snap and return.
(WebCore::RenderLayerCompositor::addToOverlapMap): Overlap mapping uses our integer positions. Switching
it back to operating on them.
(WebCore::RenderLayerCompositor::addToOverlapMapRecursive): Ditto.
(WebCore::RenderLayerCompositor::overlapsCompositedLayers): Ditto.
(WebCore::RenderLayerCompositor::computeCompositingRequirements): Using integers.
(WebCore::RenderLayerCompositor::frameViewDidChangeLocation): FrameViews are on integer bounds. We now
properly use these as integers.
(WebCore::RenderLayerCompositor::frameViewDidScroll): Ditto.
(WebCore::RenderLayerCompositor::recursiveRepaintLayerRect): Switching to use integers and
pixelSnappedLayerCoords.
(WebCore::RenderLayerCompositor::repaintCompositedLayersAbsoluteRect): Ditto.
(WebCore::RenderLayerCompositor::updateRootLayerPosition): Using integer positions, which are what
the apis used already returned.
(WebCore::RenderLayerCompositor::requiresCompositingForPlugin): Using pixel snapped values.
(WebCore::RenderLayerCompositor::requiresCompositingForFrame): Ditto.
(WebCore::paintScrollbar): Scrollbars should always use integers.
(WebCore::RenderLayerCompositor::paintContents): Switching to use an integer clip rect.
(WebCore::RenderLayerCompositor::ensureRootLayer): Using values from new pixelSnappedLayoutOverflowRect
method on RenderBox to ensure we're using values that are pixel snapped to the proper location.
(WebCore::RenderLayerCompositor::destroyRootLayer): Properly calling scrollbar invalidation methods
with integers.

  • rendering/RenderLayerCompositor.h:

(RenderLayerCompositor):

5:16 PM Changeset in webkit [107759] by noel.gordon@gmail.com
  • 5 edits
    3 adds
    3 deletes in trunk/LayoutTests

[chromium] Rebaseline JPEG image results after r107389
​https://bugs.webkit.org/show_bug.cgi?id=78454

Unreviewed. Rebaseline #8 of N.

  • platform/chromium-mac-snowleopard/fast/writing-mode/background-horizontal-bt-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/writing-mode/background-vertical-lr-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/writing-mode/background-vertical-rl-expected.png: Added.
  • platform/chromium-mac/fast/writing-mode/background-horizontal-bt-expected.png: Removed.
  • platform/chromium-mac/fast/writing-mode/background-vertical-lr-expected.png: Removed.
  • platform/chromium-mac/fast/writing-mode/background-vertical-rl-expected.png: Removed.
  • platform/chromium-win/fast/writing-mode/background-horizontal-bt-expected.png:
  • platform/chromium-win/fast/writing-mode/background-vertical-lr-expected.png:
  • platform/chromium-win/fast/writing-mode/background-vertical-rl-expected.png:
  • platform/chromium/test_expectations.txt:
5:08 PM Changeset in webkit [107758] by andersca@apple.com
  • 8 edits in trunk/Source

Swipe gestures don't work if main frame has a horizontal scrollbar
​https://bugs.webkit.org/show_bug.cgi?id=78650
<rdar://problem/10864993>

Reviewed by Sam Weinig.

Source/WebCore:

Change ScrollingTree::tryToHandleWheelEvent so we can indicate that an event was
processed by the scrolling tree but that we should indicate back to WebKit that it wasn't handled.

  • page/scrolling/ScrollingTree.cpp:

(WebCore::ScrollingTree::ScrollingTree):
Initialize new member variables.

(WebCore::ScrollingTree::tryToHandleWheelEvent):
If the wheel event will start a swipe gesture, return DidNotHandleEvent.

(WebCore::ScrollingTree::updateBackForwardState):
This can now be called from any thread, so use a mutex.

(WebCore::ScrollingTree::setMainFramePinState):
New function that will set the current main frame pin state.

(WebCore::ScrollingTree::canGoBack):
(WebCore::ScrollingTree::canGoForward):
Put locks around these.

(WebCore::ScrollingTree::willWheelEventStartSwipeGesture):
Helper function that returns whether the given wheel event will start a swipe gesture
because the main frame is pinned to the left/right and we can go back/forward.

  • page/scrolling/mac/ScrollingTreeNodeMac.mm:

(WebCore::ScrollingTreeNodeMac::update):
Call updateMainFramePinState if the frame geometry changes.

(WebCore::ScrollingTreeNodeMac::setScrollPosition):
Call updateMainFramePinState.

(WebCore::ScrollingTreeNodeMac::updateMainFramePinState):
Compute the main frame pin state and set it on the scrolling tree.

Source/WebKit2:

  • WebProcess/WebPage/EventDispatcher.cpp:

(WebKit::EventDispatcher::wheelEvent):
ScrollingTree::tryToHandleWheelEvent now returns a tri-state enum so handle the extra case.

(WebKit::EventDispatcher::sendDidReceiveEvent):
Rename this now that it takes a parameter indicating whether the event was handled or not.

5:05 PM Changeset in webkit [107757] by bweinstein@apple.com
  • 13 edits in trunk/Source

Source/WebCore: Web Inspector: Add the ability to show the resources panel on launch
​https://bugs.webkit.org/show_bug.cgi?id=78641

Reviewed by Timothy Hatcher.

  • WebCore.exp.in: Add a new function to be exported.
  • inspector/InspectorFrontendClientLocal.cpp:

(WebCore::InspectorFrontendClientLocal::showResources): Call showResources on load.

  • inspector/InspectorFrontendClientLocal.h:

(InspectorFrontendClientLocal):

  • inspector/front-end/InspectorFrontendAPI.js:

(InspectorFrontendAPI.showResources): Show the resources panel.

Source/WebKit2: Web Inspector: Add the ability to show the resources panel on launch
​https://bugs.webkit.org/show_bug.cgi?id=78641

Add WebKit2 API for the ability to show the resources panel. This calls down
from the WK API all the way to InspectorFrontendClientLocal::showResources.

Reviewed by Timothy Hatcher.

  • UIProcess/API/C/WKInspector.cpp:

(WKInspectorShowResources): Call WebInspectorProxy::showResources.

  • UIProcess/API/C/WKInspector.h:
  • UIProcess/WebInspectorProxy.cpp:

(WebKit::WebInspectorProxy::showResources): Send a message to the web process.

  • UIProcess/WebInspectorProxy.h:
  • WebProcess/WebPage/WebInspector.cpp:

(WebKit::WebInspector::showResources): Call InspectorFrontendClientLocal::showResources.

  • WebProcess/WebPage/WebInspector.h:
  • WebProcess/WebPage/WebInspector.messages.in: Add a ShowResources message.
5:00 PM Changeset in webkit [107756] by abarth@webkit.org
  • 2 edits in trunk/Tools

Implement an adb-based driver for the ChromiumAndroidPort
​https://bugs.webkit.org/show_bug.cgi?id=78627

Reviewed by Eric Seidel.

This driver mostly just wires up the ChromiumDriver through adb. In
some cases, it translates protocol elements, such as URIs, so that the
rest of webkitpy is insulated from the "remoteness" of the target device.

  • Scripts/webkitpy/layout_tests/port/chromium_android.py:

(ChromiumAndroidPort.start_helper):
(ChromiumAndroidPort._driver_class):
(ChromiumAndroidPort._update_version):
(ChromiumAndroidPort._get_stderr):
(ChromiumAndroidPort):
(ChromiumAndroidPort._get_last_stacktrace):
(ChromiumAndroidPort._teardown_performance):
(ChromiumAndroidDriver):
(ChromiumAndroidDriver.init):
(ChromiumAndroidDriver._start):
(ChromiumAndroidDriver.run_test):
(ChromiumAndroidDriver.stop):
(ChromiumAndroidDriver._test_shell_command):
(ChromiumAndroidDriver._write_command_and_read_line):
(ChromiumAndroidDriver._output_image):
(ChromiumAndroidDriver._has_crash_hint):

4:57 PM Changeset in webkit [107755] by dpranke@chromium.org
  • 3 edits in trunk/Tools

webkitpy: the real_name() method in the Port class is no longer needed
​https://bugs.webkit.org/show_bug.cgi?id=78651

Reviewed by Eric Seidel.

The change in bug 78565 / r107718 made it no longer necessary
(we can use options.platform instead).

  • Scripts/webkitpy/layout_tests/port/base.py:

(Port.name):

  • Scripts/webkitpy/layout_tests/port/mock_drt.py:

(MockDRTPort.init):

4:36 PM Changeset in webkit [107754] by dpranke@chromium.org
  • 5 edits in trunk/Tools

webkitpy: clean up options, port handling in manager_worker_broker
​https://bugs.webkit.org/show_bug.cgi?id=78568

Reviewed by Tony Chang.

manager_worker_broker no longer needs options or port objects
directly, so we make them only be passed in start_worker().

  • Scripts/webkitpy/layout_tests/controllers/manager.py:

(Manager._run_tests):

  • Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:

(get):
(_ManagerConnection.init):
(_ManagerConnection.start_worker):
(_InlineManager.init):
(_InlineManager.start_worker):
(_InlineManager.run_message_loop):
(_MultiProcessManager.init):
(_MultiProcessManager):
(_MultiProcessManager.start_worker):
(_InlineWorkerConnection.init):
(_InlineWorkerConnection.run):
(_Process.init):
(_MultiProcessWorkerConnection.init):

  • Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:

(make_broker):
(_TestWorker.run):
(_TestsMixin.test_cancel):
(_TestsMixin.test_done):
(_TestsMixin.test_unknown_message):
(MultiProcessBrokerTests.setUp):
(InterfaceTest.test_managerconnection_is_abstract):

  • Scripts/webkitpy/layout_tests/controllers/message_broker.py:

(Broker.init):

4:35 PM Changeset in webkit [107753] by enrica@apple.com
  • 2 edits in trunk/Source/WebCore

REGRESSION (r107568-r107627): Crash when copying in WebCore::SharedBuffer::hasPlatformData().
​https://bugs.webkit.org/show_bug.cgi?id=78577

Reviewed by Dan Bernstein.

  • platform/mac/PlatformPasteboardMac.mm:

(WebCore::PlatformPasteboard::setBufferForType): Missing null check when
setting data to the NSPasteboard.

4:26 PM Changeset in webkit [107752] by oliver@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Fix Interpreter.

4:11 PM Changeset in webkit [107751] by dpranke@chromium.org
  • 1 edit
    1 add in trunk/Tools

nrwt: add a unit test for regression introduced in bug 78565
​https://bugs.webkit.org/show_bug.cgi?id=78646

Reviewed by Tony Chang.

  • Scripts/webkitpy/layout_tests/controllers/worker_unittest.py: Added.

(FakeConnection):
(FakeConnection.run_message_loop):
(FakeConnection.post_message):
(WorkerTest):
(WorkerTest.test_default_platform_in_worker):

4:11 PM Changeset in webkit [107750] by rwlbuis@webkit.org
  • 1 edit
    5 adds in trunk/Source/WebKit

[BlackBerry] Upstream remaining classes in Api
​https://bugs.webkit.org/show_bug.cgi?id=78644

Reviewed by Antonio Gomes.

Initial upstream, no new tests.

  • blackberry/Api/BlackBerryContext.h: Added.
  • blackberry/Api/BlackBerryGlobal.cpp: Added.
  • blackberry/Api/BlackBerryGlobal.h: Added.
  • blackberry/Api/Version.cpp: Added.
  • blackberry/Api/Version.h: Added.
3:54 PM Changeset in webkit [107749] by rniwa@webkit.org
  • 3 edits
    2 adds in trunk

Crash in WebCore::SVGElement::removedFromDocument
​https://bugs.webkit.org/show_bug.cgi?id=77270

Reviewed by Adam Barth.

Source/WebCore:

Add a protector before calling NodeRemovalDispatcher::dispatch since
NodeRemovalDispatcher::dispatch may remove the last RefPtr to this node.

Test: fast/dom/Range/surround-contents-font-face-crash.svg

  • dom/ContainerNodeAlgorithms.h:

(WebCore::Private::addChildNodesToDeletionQueue):

LayoutTests:

Add a regression test for the crash.

  • fast/dom/Range/surround-contents-font-face-crash-expected.txt: Added.
  • fast/dom/Range/surround-contents-font-face-crash.svg: Added.
3:40 PM Changeset in webkit [107748] by mlilek@apple.com
  • 8 edits in trunk/Source

Don't ENABLE_DASHBOARD_SUPPORT unconditionally on all Mac platforms
​https://bugs.webkit.org/show_bug.cgi?id=78629

Reviewed by David Kilzer.

Source/JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig:

Source/WebCore:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit/mac:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

  • Configurations/FeatureDefines.xcconfig:
3:26 PM Changeset in webkit [107747] by kubo@profusion.mobi
  • 6 edits
    1 delete in trunk

[CMake] Merge WebKitEfl.cmake into FindEFL.cmake.
​https://bugs.webkit.org/show_bug.cgi?id=78566

Reviewed by Daniel Bates.

.:

  • Source/cmake/FindEFL.cmake: Move the code to find edje_cc here from

WebKitEfl.cmake.

  • Source/cmake/WebKitEfl.cmake: Removed.

Source/WebKit/efl:

  • CMakeListsEfl.txt: Do not include WebKitEfl.cmake.

Source/WebKit2:

  • PlatformEfl.cmake: Do not include WebKitEfl.cmake.
3:20 PM Changeset in webkit [107746] by dpranke@chromium.org
  • 2 edits in trunk/Tools

NRWT is broken for the default port
​https://bugs.webkit.org/show_bug.cgi?id=78640

Reviewed by Tony Chang.

The change in r107718 (bug 78565) broke NRWT if you didn't
specify any sort of --platform flag or equivalent. I didn't
catch this because it's a full integration test (which we don't
have an automated test for) and I missed this command line
variant when testing interactively.

  • Scripts/webkitpy/layout_tests/controllers/worker.py:

(Worker.run):

3:16 PM Changeset in webkit [107745] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Avoid full style recalc when presentation attributes change.
<​http://webkit.org/b/78636>

Patch by Andreas Kling <​awesomekling@apple.com> on 2012-02-14
Reviewed by Antti Koivisto.

Use setNeedsStyleRecalc(InlineStyleChange) when a presentation attribute changes
to reduce the amount of work done in recalcStyle().

  • dom/StyledElement.cpp:

(WebCore::StyledElement::attributeChanged):

3:11 PM Changeset in webkit [107744] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed, build fix for non-DFG platforms.

  • assembler/MacroAssembler.h:

(MacroAssembler):

2:58 PM Changeset in webkit [107743] by commit-queue@webkit.org
  • 1 edit
    2 adds in trunk/Source/WebKit

[BlackBerry] Upstreaming DOMSupport files
​https://bugs.webkit.org/show_bug.cgi?id=78607

Patch by Nima Ghanavatian <​nghanavatian@rim.com> on 2012-02-14
Reviewed by Rob Buis.

Initial upstreaming, no new tests.

  • blackberry/WebKitSupport/DOMSupport.cpp: Added.
  • blackberry/WebKitSupport/DOMSupport.h: Added.
2:56 PM Changeset in webkit [107742] by fpizlo@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Unreviewed, fix build and configuration goof.

  • assembler/MacroAssembler.h:

(JSC::MacroAssembler::invert):

  • dfg/DFGCommon.h:
2:50 PM Changeset in webkit [107741] by fpizlo@apple.com
  • 8 edits in trunk/Source/JavaScriptCore

DFG should be able to emit code on control flow edges
​https://bugs.webkit.org/show_bug.cgi?id=78515

Reviewed by Gavin Barraclough.

This gets us a few steps closer to being able to perform global register allocation,
by allowing us to have landing pads on control flow edges. This will let us reshuffle
registers if it happens to be necessary due to different reg alloc decisions in
differen blocks.

This also introduces the notion of a landing pad for OSR entry, which will allow us
to emit code that places data into registers when we're entering into the DFG from
the old JIT.

Finally, this patch introduces a verification mode that checks that the landing pads
are actually emitted and do actually work as advertised. When verification is disabled,
this has no effect on behavior.

  • assembler/MacroAssembler.h:

(MacroAssembler):
(JSC::MacroAssembler::invert):
(JSC::MacroAssembler::isInvertible):

  • dfg/DFGCommon.h:
  • dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::compile):
(JSC::DFG::JITCompiler::compileFunction):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compilePeepHoleDoubleBranch):
(JSC::DFG::SpeculativeJIT::compilePeepHoleObjectEquality):
(JSC::DFG::SpeculativeJIT::compilePeepHoleIntegerBranch):
(JSC::DFG::SpeculativeJIT::compile):
(JSC::DFG::SpeculativeJIT::createOSREntries):
(DFG):
(JSC::DFG::SpeculativeJIT::linkOSREntries):
(JSC::DFG::SpeculativeJIT::compileStrictEqForConstant):

  • dfg/DFGSpeculativeJIT.h:

(SpeculativeJIT):
(JSC::DFG::SpeculativeJIT::branchDouble):
(JSC::DFG::SpeculativeJIT::branchDoubleNonZero):
(JSC::DFG::SpeculativeJIT::branch32):
(JSC::DFG::SpeculativeJIT::branchTest32):
(JSC::DFG::SpeculativeJIT::branchPtr):
(JSC::DFG::SpeculativeJIT::branchTestPtr):
(JSC::DFG::SpeculativeJIT::branchTest8):
(JSC::DFG::SpeculativeJIT::jump):
(JSC::DFG::SpeculativeJIT::haveEdgeCodeToEmit):
(JSC::DFG::SpeculativeJIT::emitEdgeCode):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeBranchNull):
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeBranch):
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeStrictEq):
(JSC::DFG::SpeculativeJIT::emitObjectOrOtherBranch):
(JSC::DFG::SpeculativeJIT::emitBranch):
(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeBranchNull):
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeBranch):
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeStrictEq):
(JSC::DFG::SpeculativeJIT::emitObjectOrOtherBranch):
(JSC::DFG::SpeculativeJIT::emitBranch):
(JSC::DFG::SpeculativeJIT::compile):

2:47 PM Changeset in webkit [107740] by fischman@chromium.org
  • 4 edits in trunk/LayoutTests

Convert a couple of media layouttests to mock scrollbars & rebaseline
​https://bugs.webkit.org/show_bug.cgi?id=78634

Unreviewed test maintenance.

  • media/video-controls-rendering.html:
  • media/video-zoom.html:
  • platform/chromium/test_expectations.txt:
2:35 PM Changeset in webkit [107739] by commit-queue@webkit.org
  • 7 edits in trunk

Last character display for passwords in Android.
​https://bugs.webkit.org/show_bug.cgi?id=78532

Patch by Ramya Chandrasekaran <​cramya@google.com> on 2012-02-14
Reviewed by Adam Barth.

Source/WebCore:

  • page/Settings.cpp:

(WebCore::Settings::Settings):

Source/WebKit/chromium:

  • public/WebSettings.h:
  • src/WebSettingsImpl.cpp:

(WebKit::WebSettingsImpl::setPasswordEchoEnabled):
(WebKit):
(WebKit::WebSettingsImpl::setPasswordEchoDurationInSeconds):

  • src/WebSettingsImpl.h:

(WebSettingsImpl):

Tools:

  • DumpRenderTree/chromium/WebPreferences.cpp:

(WebPreferences::applyTo):

2:31 PM Changeset in webkit [107738] by jsbell@chromium.org
  • 7 edits in trunk

IndexedDB: Invalid dates should not be valid keys
​https://bugs.webkit.org/show_bug.cgi?id=78622

Reviewed by Tony Chang.

Source/WebCore:

Tests: storage/indexeddb/invalid-keys.html

storage/indexeddb/factory-cmp.html

  • bindings/v8/IDBBindingUtilities.cpp: Special case for NaN Dates.

(WebCore::createIDBKeyFromValue):

LayoutTests:

  • storage/indexeddb/factory-cmp-expected.txt:
  • storage/indexeddb/factory-cmp.html:
  • storage/indexeddb/invalid-keys-expected.txt:
  • storage/indexeddb/invalid-keys.html:
2:30 PM Changeset in webkit [107737] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit

[BlackBerry] Remove OpenVG references
​https://bugs.webkit.org/show_bug.cgi?id=78623

Patch by Jeff Rogers <​jrogers@rim.com> on 2012-02-14
Reviewed by Rob Buis.

Removed references to USE(OPENVG) and the related code.

  • blackberry/Api/BackingStore.cpp:

(BlackBerry::WebKit::BackingStorePrivate::BackingStorePrivate):
(BlackBerry::WebKit::BackingStorePrivate::repaint):
(BlackBerry::WebKit::BackingStorePrivate::renderContents):
(BlackBerry::WebKit::BackingStore::createSurface):

  • blackberry/Api/BackingStore_p.h:
2:18 PM Changeset in webkit [107736] by commit-queue@webkit.org
  • 4 edits
    2 adds in trunk/Source/WebKit

Initial upstreaming for find-in-page for BlackBerry port
​https://bugs.webkit.org/show_bug.cgi?id=78615

Create a new class InPageSearchManager for find-in-page and
remove the functions in SelectionHandler

Patch by Andy Chen <​andchen@rim.com> on 2012-02-14
Reviewed by Rob Buis.

  • blackberry/CMakeListsBlackBerry.txt:
  • blackberry/WebKitSupport/InPageSearchManager.cpp: Added.

(BlackBerry::WebKit::InPageSearchManager::InPageSearchManager):
(BlackBerry::WebKit::InPageSearchManager::~InPageSearchManager):
(BlackBerry::WebKit::InPageSearchManager::findNextString):
(BlackBerry::WebKit::InPageSearchManager::clearTextMatches):
(BlackBerry::WebKit::InPageSearchManager::setMarkerActive):

  • blackberry/WebKitSupport/InPageSearchManager.h: Added.
  • blackberry/WebKitSupport/SelectionHandler.cpp:
  • blackberry/WebKitSupport/SelectionHandler.h:
2:12 PM Changeset in webkit [107735] by eae@chromium.org
  • 5 edits
    1 delete in branches/subpixellayout/Source

Cleaning up unused code/unnecessary conversions on branch.

2:09 PM Changeset in webkit [107734] by commit-queue@webkit.org
  • 1 edit
    2 adds in trunk/Source/WebKit

[BlackBerry] Upstream BlackBerry WebCoreSupport FrameLoaderClientBlackBerry class
​https://bugs.webkit.org/show_bug.cgi?id=78275

Patch by Jacky Jiang <​zhajiang@rim.com> on 2012-02-14
Reviewed by Rob Buis.

Initial upstream, no new tests.

  • blackberry/WebCoreSupport/FrameLoaderClientBlackBerry.cpp: Added.
  • blackberry/WebCoreSupport/FrameLoaderClientBlackBerry.h: Added.
2:02 PM Changeset in webkit [107733] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

Crash from line break iterators in counter content
​https://bugs.webkit.org/show_bug.cgi?id=72977

Patch by Ken Buchanan <​kenrb@chromium.org> on 2012-02-14
Reviewed by David Hyatt.

Source/WebCore:

Calculating the width of counter text can sometimes cause the
underlying text buffer to change. This patch causes the iterator
to reset appropriately when this happens.

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::LineBreaker::nextLineBreak):

LayoutTests:

Test that causes asterisk counters to change during layout
and potentially confuse iterators.

  • fast/css/counters/asterisk-counter-update-after-layout-crash-expected.txt: Added
  • fast/css/counters/asterisk-counter-update-after-layout-crash.html: Added
1:26 PM Changeset in webkit [107732] by fpizlo@apple.com
  • 4 edits
    3 adds in trunk

Assertion failure under JSC::DFG::AbstractState::execute loading economist.com
​https://bugs.webkit.org/show_bug.cgi?id=78153
<rdar://problem/10861712> <rdar://problem/10861947>

Reviewed by Oliver Hunt.

Source/JavaScriptCore:

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::execute):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileAdd):

LayoutTests:

  • fast/js/dfg-add-not-number-expected.txt: Added.
  • fast/js/dfg-add-not-number.html: Added.
  • fast/js/script-tests/dfg-add-not-number.js: Added.

(foo):

1:25 PM LayoutUnit edited by eae@chromium.org
(diff)
1:17 PM Changeset in webkit [107731] by leviw@chromium.org
  • 4 edits in trunk/Source/WebCore

Update usage of LayoutUnits in RenderLayer
​https://bugs.webkit.org/show_bug.cgi?id=78511

Reviewed by Simon Fraser.

Updating RenderLayer to properly use LayoutUnits. See descriptions below for the rationale behind all
the changes. Also adding a roundedIntSize method that takes a LayoutSize.

No new tests. No change in behavior.

  • rendering/LayoutTypes.h:

(WebCore::roundedIntSize): Inline method that currently does nothing, but will round a LayoutSize
to an IntSize.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::updateLayerPositions): Switching repaint and outline boxes to LayoutRects, as
it's important to keep the precision of these rects until handing off to the embedder (in FrameView).
(WebCore::RenderLayer::computeRepaintRects): Repaint rects should be preserved in subpixel units until
being passed to the embedding layer. This prevents needless repaints.
(WebCore::RenderLayer::convertToPixelSnappedLayerCoords): Convenience function to return pixel snapped rects
(WebCore):
(WebCore::RenderLayer::convertToLayerCoords): Fixing a style flaw.
(WebCore::RenderLayer::scrollRectToVisible): Pixel snapping the rect when handing off to the embedder.
(WebCore::RenderLayer::maximumScrollPosition): Scroll offsets are rounded.
(WebCore::RenderLayer::scrollCornerRect): Scrollbars are drawn natively and should be positioned on pixel
boundaries.
(WebCore::RenderLayer::scrollCornerAndResizerRect): Resize corner doesn't influence the size/position of
render objects. It is only painted and hit tested. Therefor it should use integers.
(WebCore::RenderLayer::offsetFromResizeCorner): Ditto.
(WebCore::RenderLayer::positionOverflowControls): Overflow controls are drawn natively and should be
positioned on integer boundaries.
(WebCore::RenderLayer::paintOverflowControls): Ditto.
(WebCore::RenderLayer::paintScrollCorner): Ditto.
(WebCore::RenderLayer::drawPlatformResizerImage): Ditto.
(WebCore::RenderLayer::paintResizer): Ditto.
(WebCore::RenderLayer::hitTestOverflowControls): Hit testing & overflow controls both use integers.
(WebCore::RenderLayer::clipToRect): Clipping to actual painted (pixel snapped) layer bounds in the
graphics context.
(WebCore::RenderLayer::paintLayerContents): Calling paintOverflowControls at pixel bounds.
(WebCore::RenderLayer::hitTest): Intersecting the hit test area with pixel snapped boundaries.
(WebCore::RenderLayer::setBackingNeedsRepaintInRect): Sending pixelSnapped rects to the backing
store, which only cares about pixels, and hence integers.

  • rendering/RenderLayer.h:

(WebCore::RenderLayer::scrolledContentOffset): RenderLayer's scroll offsets are used in platform
code, so we need to return them as integers. Rounding the scroll overflow before adding it to the
scroll offset, which was already stored in integers.
(RenderLayer):

1:16 PM Changeset in webkit [107730] by commit-queue@webkit.org
  • 4 edits
    2 adds in trunk/Source/WebKit

Separate mimetype and file extension mapping API from WebKit/blackberry/Api/WebKitTextCodec and complete it.
​https://bugs.webkit.org/show_bug.cgi?id=78605

Patch by Lianghui Chen <​liachen@rim.com> on 2012-02-14
Reviewed by Rob Buis.

Now the MIME type and file extension mapping API are in WebKitMIMETypeConverter.

  • blackberry/Api/WebKitMIMETypeConverter.cpp: Added.

(WebKit):
(BlackBerry::WebKit::getExtensionForMimeType):
(BlackBerry::WebKit::getMimeTypeForExtension):

  • blackberry/Api/WebKitMIMETypeConverter.h: Added.

(WebKit):

  • blackberry/Api/WebKitTextCodec.cpp:
  • blackberry/Api/WebKitTextCodec.h:
  • blackberry/CMakeListsBlackBerry.txt:
1:02 PM Changeset in webkit [107729] by inferno@chromium.org
  • 3 edits
    2 adds in trunk

Crash in NavigationScheduler::schedule.
​https://bugs.webkit.org/show_bug.cgi?id=78297

Reviewed by Adam Barth.

Source/WebCore:

Protect frame pointer and navigation scheduler when we stop the
load (when redirect is scheduled during a load). Also, dont fire
the navigation scheduler timer when we know that frameloader is
going away.

Test: http/tests/navigation/navigation-redirect-schedule-crash.html

  • loader/NavigationScheduler.cpp:

(WebCore::NavigationScheduler::schedule):

LayoutTests:

  • http/tests/navigation/navigation-redirect-schedule-crash-expected.txt: Added.
  • http/tests/navigation/navigation-redirect-schedule-crash.html: Added.
1:00 PM Changeset in webkit [107728] by alexis.menard@openbossa.org
  • 3 edits
    2 adds in trunk

font shorthand with inherit keyword incorrectly parsed and rendered
​https://bugs.webkit.org/show_bug.cgi?id=20181

Reviewed by Tony Chang.

Source/WebCore:

As stated in ​http://www.w3.org/TR/CSS21/changes.html#q142
if the inherit (and also by extension initial) is encountered in the
middle of the shorthand then the property becomes invalid.

Test: fast/css/font-shorthand-mix-inherit.html

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseFont):
(WebCore::CSSParser::parseFontFamily):

LayoutTests:

  • fast/css/font-shorthand-mix-inherit-expected.txt: Added.
  • fast/css/font-shorthand-mix-inherit.html: Added.
12:47 PM Changeset in webkit [107727] by leviw@chromium.org
  • 6 edits in branches/subpixellayout/Source/WebCore/rendering

Moving RenderLayerBacking and RenderLayerCompositor to integers, and ensuring pixel snapping occurs in all the right places.

12:45 PM Changeset in webkit [107726] by inferno@chromium.org
  • 3 edits
    2 adds in trunk

Crash due to incorrect firing of mutation event during class attribute parsing.
​https://bugs.webkit.org/show_bug.cgi?id=78537

Reviewed by Ryosuke Niwa.

Source/WebCore:

Test: fast/dom/class-attr-change-double-mutation-fire.html

  • dom/StyledElement.cpp:

(WebCore::StyledElement::classAttributeChanged):

LayoutTests:

  • fast/dom/class-attr-change-double-mutation-fire-expected.txt: Added.
  • fast/dom/class-attr-change-double-mutation-fire.html: Added.
12:29 PM Changeset in webkit [107725] by abarth@webkit.org
  • 2 edits in trunk/Tools

Finish implementing start_helper for ChromiumAndroidPort
​https://bugs.webkit.org/show_bug.cgi?id=78582

Reviewed by Eric Seidel.

This patch contains the remaining odds and ends for the start_helper function.

  • Scripts/webkitpy/layout_tests/port/chromium_android.py:

(ChromiumAndroidPort.start_helper):
(ChromiumAndroidPort._synchronize_datetime):
(ChromiumAndroidPort):
(ChromiumAndroidPort._check_version):
(ChromiumAndroidPort._run_adb_command):
(ChromiumAndroidPort._copy_device_file):

12:22 PM Changeset in webkit [107724] by mikelawther@chromium.org
  • 5 edits in trunk

CSS3 calc: add isZero implementations to catch divide by zero
​https://bugs.webkit.org/show_bug.cgi?id=78603

Reviewed by Ojan Vafai.

Source/WebCore:

  • css/CSSCalculationValue.cpp:

(WebCore::CSSCalcPrimitiveValue::isZero):
(CSSCalcPrimitiveValue):
(WebCore::CSSCalcBinaryOperation::isZero):
(CSSCalcBinaryOperation):

  • css/CSSCalculationValue.h:

(CSSCalcExpressionNode):

LayoutTests:

  • css3/calc/calc-errors-expected.txt:
12:15 PM Changeset in webkit [107723] by tony@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Unreviewed, marking a perf test as slow in debug and two
gpu tests as failing in debug (different scrollbar rendering).

  • platform/chromium/test_expectations.txt:
12:13 PM Changeset in webkit [107722] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/chromium

[Chromium] Expose perTilePainting setting through WebLayerTreeView::Settings interface.
​https://bugs.webkit.org/show_bug.cgi?id=76937

Patch by David Reveman <​reveman@chromium.org> on 2012-02-14
Reviewed by James Robinson.

Add perTilePainting to WebLayerTreeView::Settings.

  • public/platform/WebLayerTreeView.h:

(WebKit::WebLayerTreeView::Settings::Settings):
(Settings):

  • src/WebLayerTreeView.cpp:

(WebKit::WebLayerTreeView::Settings::operator CCSettings):

12:11 PM Changeset in webkit [107721] by fischman@chromium.org
  • 3 edits in trunk/LayoutTests

[chromium] Layout Test media/media-document-audio-repaint.html is flaky
​https://bugs.webkit.org/show_bug.cgi?id=76580

Reviewed by James Robinson.

Make sure to call layoutTestController.display() at a stable point
(namely when the media element is paused) so that any subsequent GPU
disabling doesn't cause a complete redraw (and the test to be
flaky).

  • media/media-document-audio-repaint.html:
  • platform/chromium/test_expectations.txt:
11:42 AM Changeset in webkit [107720] by timothy@apple.com
  • 1 edit
    6 deletes in trunk/LayoutTests

Remove inspector/protocol/page-agent.html since it is inherently flaky.

Filed ​https://webkit.org/b/78621 about devising a non-flaky test.

Unreviewed.

  • inspector/protocol/page-agent-expected.txt: Removed.
  • inspector/protocol/page-agent.html: Removed.
  • inspector/protocol/resources/dummy-iframe.html: Removed.
  • inspector/protocol/resources/empty.png: Removed.
  • inspector/protocol/resources/font1.ttf: Removed.
  • inspector/protocol/resources/font2.ttf: Removed.
11:39 AM Changeset in webkit [107719] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit

[BlackBerry] Dragging a selection handle outside of the content bounding box does not update the selection range correctly
​https://bugs.webkit.org/show_bug.cgi?id=78608

Ensure that when selection handles leave the content bounding box that
the handle not being dragged remains fixed. Do not applying padding to
a direction that would cause the selection to shrink when performing
the handle direction detection.

Patch by Ed Baker <​edbaker@rim.com> on 2012-02-14
Reviewed by Rob Buis.

  • blackberry/WebKitSupport/SelectionHandler.cpp:

(BlackBerry::WebKit::directionOfPointRelativeToRect):
(BlackBerry::WebKit::SelectionHandler::extendSelectionToFieldBoundary):
(BlackBerry::WebKit::SelectionHandler::clipPointToFocusNode):
(BlackBerry::WebKit::SelectionHandler::setSelection):

  • blackberry/WebKitSupport/SelectionHandler.h:
11:25 AM Changeset in webkit [107718] by dpranke@chromium.org
  • 4 edits in trunk/Tools

webkitpy: create ports in Workers, not in manager_worker_broker
​https://bugs.webkit.org/show_bug.cgi?id=78565

Reviewed by Tony Chang.

We will now create the Port object (if necessary) in the Worker
directly, so that the manager_worker_broker module doesn't need
all of this layout_test-specific logic. Part of the fixes for
bug 78171.

These changes are all well-tested by the existing tests in
run_webkit_tests_integrationtest.py.

  • Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:

(_Process.run):

  • Scripts/webkitpy/layout_tests/controllers/worker.py:

(Worker.init):
(Worker.safe_init):
(Worker.run):
(Worker.cleanup):

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:

(parse_args):
(main): Fix a minor bug where running the 'mock-test' port didn't work right.

11:18 AM Changeset in webkit [107717] by tony@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Unreviewed, mark some form tests as flaky.

  • platform/chromium/test_expectations.txt:
11:13 AM Changeset in webkit [107716] by rwlbuis@webkit.org
  • 1 edit
    6 adds in trunk/Source/WebKit

[BlackBerry] Upstream backing store related classes
​https://bugs.webkit.org/show_bug.cgi?id=78517

Reviewed by Antonio Gomes.

Initial upstream, no new tests.

  • blackberry/WebKitSupport/BackingStoreClient.cpp: Added.
  • blackberry/WebKitSupport/BackingStoreClient.h: Added.
  • blackberry/WebKitSupport/BackingStoreCompositingSurface.cpp: Added.
  • blackberry/WebKitSupport/BackingStoreCompositingSurface.h: Added.
  • blackberry/WebKitSupport/BackingStoreTile.cpp: Added.
  • blackberry/WebKitSupport/BackingStoreTile.h: Added.
10:44 AM Changeset in webkit [107715] by timothy@apple.com
  • 5 edits in trunk

Source/WebCore: Don't include CachedResources that haven't downloaded when populating the Web Inspector on load.

​https://webkit.org/b/78447
rdar://problem/10843542

Reviewed by Brian Weinstein.

Test: inspector/protocol/page-agent.html

  • inspector/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::cachedResourcesForFrame): Skip CachedFonts and CachedImages that
return true for stillNeedsLoad.

  • loader/cache/CachedFont.h:

(WebCore::CachedFont::stillNeedsLoad): Added.

LayoutTests: Updated test results to exclude CachedResources that haven't downloaded.

​https://webkit.org/b/78447
rdar://problem/10843542

Reviewed by Brian Weinstein.

  • inspector/protocol/page-agent-expected.txt: Updated. There is now only one font list

in the resources, when there was incorrectly two being listed. Only the font being used
is the one that downloaded and is listed now.

10:44 AM Changeset in webkit [107714] by timothy@apple.com
  • 5 edits
    7 adds in trunk

Source/WebCore: Web Inspector: include failed and canceled in FrameResourceTree.

​https://webkit.org/b/78445

Reviewed by Pavel Feldman.

Test: inspector/protocol/page-agent.html

  • WebCore.xcodeproj/project.pbxproj: Added Inspector.json, Inspector-0.1.json and Inspector-1.0.json

for quick access and easy editing.

  • inspector/Inspector.json: Added failed and canceled as optional properties to the object for resources in FrameResourceTree.
  • inspector/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::buildObjectForFrameTree): Set those properties.

LayoutTests: Test for Web Inspector: include failed and canceled in FrameResourceTree.

​https://webkit.org/b/78445

Reviewed by Pavel Feldman.

  • inspector/protocol/page-agent-expected.txt: Added.
  • inspector/protocol/page-agent.html: Added.
  • inspector/protocol/resources/dummy-iframe.html: Added.
  • inspector/protocol/resources/empty.png: Added.
  • inspector/protocol/resources/font1.ttf: Added.
  • inspector/protocol/resources/font2.ttf: Added.
9:39 AM Changeset in webkit [107713] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

[GTK] fast/forms/implicit-submission.html fails
​https://bugs.webkit.org/show_bug.cgi?id=76632

Patch by Kaustubh Atrawalkar <Kaustubh Atrawalkar> on 2012-02-14
Reviewed by Martin Robinson.

[Gtk] Rebaseline implicit-submission test expectations after r105253.

  • platform/gtk/Skipped:
  • platform/gtk/fast/forms/implicit-submission-expected.txt:
9:36 AM WinCE edited by Patrick Gansterer
(diff)
9:29 AM WinCE edited by Patrick Gansterer
Fixed build exmple after r101052 (diff)
8:12 AM Changeset in webkit [107712] by Philippe Normand
  • 3 edits in trunk/LayoutTests

Unreviewed, GTK rebaseline after r107688 and skipping some new
test failures.

  • platform/gtk/Skipped:
  • platform/gtk/css3/calc/getComputedStyle-margin-percentage-expected.txt:
7:42 AM Changeset in webkit [107711] by thakis@chromium.org
  • 26 edits in branches/chromium/1025

Merge 107094 - Chromium: Fix Mac rubber band overhang drawing on composited pages and re-enable tests.
​https://bugs.webkit.org/show_bug.cgi?id=78007

This got broken by: ​http://trac.webkit.org/changeset/105470
And the tests were accidentally(?) disabled in: ​http://trac.webkit.org/changeset/95191

There is still three tests that fail from the set, but the cause for these is different,
which I'm still investigating.

Patch by Alexei Svitkine <​asvitkine@chromium.org> on 2012-02-08
Reviewed by James Robinson.

Source/WebKit/chromium:

  • src/NonCompositedContentHost.cpp:

(WebKit::NonCompositedContentHost::NonCompositedContentHost):

LayoutTests:

  • platform/chromium/test_expectations.txt:

TBR=​commit-queue@webkit.org
Review URL: ​https://chromiumcodereview.appspot.com/9358057

6:28 AM Changeset in webkit [107710] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebCore

Typo fix after r107707.

  • platform/graphics/texmap/TextureMapperNode.cpp:

(WebCore::TextureMapperNode::updateBackingStore):

6:24 AM Changeset in webkit [107709] by caseq@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: [refactoring] extract TimelineOverviewWindow from TimelineOverviewPanel
​https://bugs.webkit.org/show_bug.cgi?id=78599

Reviewed by Pavel Feldman.

  • inspector/front-end/TimelineOverviewPane.js:

(WebInspector.TimelineOverviewPane):
(WebInspector.TimelineOverviewPane.prototype.reset):
(WebInspector.TimelineOverviewPane.prototype.scrollWindow):
(WebInspector.TimelineOverviewWindow):
(WebInspector.TimelineOverviewWindow.prototype.reset):
(WebInspector.TimelineOverviewWindow.prototype.scrollWindow):
(WebInspector.TimelineOverviewWindow.prototype._windowResizeDragging):
(WebInspector.TimelineOverviewWindow.prototype._dragWindow):
(WebInspector.TimelineOverviewWindow.prototype._windowSelectorDragging):
(WebInspector.TimelineOverviewWindow.prototype._endWindowSelectorDragging):
(WebInspector.TimelineOverviewWindow.prototype._windowDragging):
(WebInspector.TimelineOverviewWindow.prototype._resizeWindowRight):
(WebInspector.TimelineOverviewWindow.prototype._resizeWindowMaximum):
(WebInspector.TimelineOverviewWindow.prototype._setWindowPosition):
(WebInspector.TimelineOverviewWindow.prototype._endWindowDragging):
(WebInspector.TimelinePanel.WindowSelector):

5:34 AM SettingUpDevelopmentEnvironmentForN9 edited by vestbo@webkit.org
(diff)
5:33 AM SettingUpDevelopmentEnvironmentForN9 edited by vestbo@webkit.org
(diff)
4:55 AM Changeset in webkit [107708] by vsevik@chromium.org
  • 16 edits
    1 copy
    3 adds in trunk

Web Inspector: Make ScriptsNavigator default file selector.
​https://bugs.webkit.org/show_bug.cgi?id=78349

Reviewed by Pavel Feldman.

Source/WebCore:

Moved ScriptsNavigator out of experiments.
Introduced new setting "useScriptsNavigator" with true as default value.
Updated scripts panel tests related to file selector.

Tests: inspector/debugger/scripts-combobox-file-selector-history.html

inspector/debugger/scripts-file-selector.html

  • English.lproj/localizedStrings.js:
  • inspector/front-end/DebuggerPresentationModel.js:

(WebInspector.DebuggerPresentationModel.prototype.uiSourceCodes):

  • inspector/front-end/ScriptsNavigator.js:

(WebInspector.ScriptsNavigator.prototype._removeUISourceCode):
(WebInspector.ScriptsNavigator.prototype._showScriptFoldersSettingChanged):

  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype._uiSourceCodeAdded):
(WebInspector.ScriptsPanel.prototype._addUISourceCode):
(WebInspector.ScriptsPanel.prototype._updateExecutionLine):

  • inspector/front-end/Settings.js:

(WebInspector.ExperimentsSettings):

  • inspector/front-end/SettingsScreen.js:

(WebInspector.SettingsScreen):

Source/WebKit/chromium:

  • src/js/Tests.js:

(.TestSuite.prototype.testNoScriptDuplicatesOnPanelSwitch.checkNoDuplicates):
(.TestSuite.prototype.uiSourceCodesToString_):
(.TestSuite.prototype.nonAnonymousUISourceCodes_):
(.TestSuite.prototype._scriptsAreParsed):
(.TestSuite.prototype._waitUntilScriptsAreParsed.waitForAllScripts):
(.TestSuite.prototype._waitUntilScriptsAreParsed):

LayoutTests:

  • http/tests/inspector/debugger-test.js:

(initialize_DebuggerTest):
(initialize_DebuggerTest.):

  • inspector/debugger/scripts-combobox-file-selector-history-expected.txt: Added.
  • inspector/debugger/scripts-combobox-file-selector-history.html: Added.
  • inspector/debugger/scripts-file-selector-expected.txt: Copied from LayoutTests/inspector/debugger/scripts-panel-expected.txt.
  • inspector/debugger/scripts-file-selector.html: Added.
  • inspector/debugger/scripts-panel-expected.txt:
  • inspector/debugger/scripts-panel.html:
  • inspector/debugger/scripts-sorting-expected.txt:
  • inspector/debugger/scripts-sorting.html:
  • inspector/debugger/source-frame-count.html:
4:53 AM Changeset in webkit [107707] by noam.rosenthal@nokia.com
  • 17 edits
    4 adds in trunk/Source

[Qt][Texmap] Refactor backing-store code in TextureMapper
​https://bugs.webkit.org/show_bug.cgi?id=78305

Source/WebCore:

Instead of dealing with tiling inside of TextureMapperNode, we now deal with that in a new
TextureMapperBackingStore class. Since the class is abstract, WebKit2 can overload it to
support remotely-managed tiles.
The backing-store for directly composited images is handled separately, in a new class
TextureMapperCompositedImage. The TextureMapper implementation decides the dimension of
the tiles, for example 2000 in the case of OpenGL.
Also, directly composited content is now handled correctly, by painting it after the regular
content and not as part of the same texture.

To make this work, the functions in TextureMapperPlatformLayers had to become non-const,
thus the changes to that file and GraphicsContext3DQt.

Reviewed by Kenneth Rohde Christiansen.

No new functionality, no new tests.

  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • platform/graphics/opengl/TextureMapperGL.h:

(WebCore::TextureMapperGL::maxTextureDimension):

  • platform/graphics/qt/GraphicsContext3DQt.cpp:

(GraphicsContext3DPrivate):
(WebCore::GraphicsContext3DPrivate::paintToTextureMapper):

  • platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:

(WebCore::GraphicsLayerTextureMapper::GraphicsLayerTextureMapper):
(WebCore::GraphicsLayerTextureMapper::didSynchronize):
(WebCore::GraphicsLayerTextureMapper::setNeedsDisplay):
(WebCore::GraphicsLayerTextureMapper::setContentsNeedsDisplay):
(WebCore::GraphicsLayerTextureMapper::setNeedsDisplayInRect):
(WebCore::GraphicsLayerTextureMapper::addChildBelow):
(WebCore):
(WebCore::GraphicsLayerTextureMapper::getContentsLayer):
(WebCore::GraphicsLayerTextureMapper::setContentsToImage):
(WebCore::GraphicsLayerTextureMapper::setContentsToMedia):

  • platform/graphics/texmap/GraphicsLayerTextureMapper.h:

(GraphicsLayerTextureMapper):
(WebCore::GraphicsLayerTextureMapper::platformLayer):
(WebCore::GraphicsLayerTextureMapper::needsDisplay):
(WebCore::GraphicsLayerTextureMapper::needsDisplayRect):

  • platform/graphics/texmap/TextureMapper.cpp:
  • platform/graphics/texmap/TextureMapper.h:

(WebCore::TextureMapper::maxTextureDimension):
(TextureMapper):

  • platform/graphics/texmap/TextureMapperBackingStore.cpp: Added.
  • platform/graphics/texmap/TextureMapperBackingStore.h: Added.
  • platform/graphics/texmap/TextureMapperNode.cpp:

(WebCore::TextureMapperNode::backingStore):
(WebCore::TextureMapperNode::updateBackingStore):
(WebCore::TextureMapperNode::paint):
(WebCore::TextureMapperNode::paintSelf):
(WebCore::TextureMapperNode::intermediateSurfaceRect):
(WebCore::TextureMapperNode::paintRecursive):
(WebCore::TextureMapperNode::syncCompositingStateSelf):
(WebCore::TextureMapperNode::syncCompositingState):

  • platform/graphics/texmap/TextureMapperNode.h:

(TextureMapperPaintOptions):
(WebCore::TextureMapperPaintOptions::TextureMapperPaintOptions):
(WebCore::TextureMapperNode::TextureMapperNode):
(TextureMapperNode):
(WebCore::TextureMapperNode::setBackingStore):
(WebCore::TextureMapperNode::texture):
(WebCore::TextureMapperNode::layerRect):
(WebCore::TextureMapperNode::createBackingStore):
(State):
(WebCore::TextureMapperNode::State::State):

  • platform/graphics/texmap/TextureMapperPlatformLayer.h:

(TextureMapperPlatformLayer):
(WebCore::TextureMapperPlatformLayer::swapBuffers):

Source/WebKit2:

Move the backing-store code to LayerTreeBackingStore, implementing the virtual functions
in TextureMapperBackingStore.
We save the double-buffered tile in the backing-store, and then convert them to regular
tiles in updateContents, based on the order of painting.
Use TextureMapperCompositedImage for images instead of saving our own composited image
registry.

Reviewed by Kenneth Rohde Christiansen.

  • Target.pri:
  • UIProcess/LayerTreeHostProxy.h:

(WebKit):
(LayerTreeHostProxy):

  • UIProcess/qt/LayerBackingStore.cpp: Added.
  • UIProcess/qt/LayerBackingStore.h: Added.
  • UIProcess/qt/LayerTreeHostProxyQt.cpp:

(WebKit::LayerTreeHostProxy::createLayer):
(WebKit::LayerTreeHostProxy::syncLayerParameters):
(WebKit::LayerTreeHostProxy::getBackingStore):
(WebKit::LayerTreeHostProxy::createTile):
(WebKit::LayerTreeHostProxy::removeTile):
(WebKit::LayerTreeHostProxy::updateTile):
(WebKit::LayerTreeHostProxy::createImage):
(WebKit::LayerTreeHostProxy::assignImageToLayer):
(WebKit::LayerTreeHostProxy::purgeGLResources):

  • WebProcess.pro:
4:48 AM Changeset in webkit [107706] by commit-queue@webkit.org
  • 37 edits in trunk

Use youngestShadowRoot and oldestShadowRoot instead of Element::shadowRoot().
​https://bugs.webkit.org/show_bug.cgi?id=78455

Patch by Shinya Kawanaka <​shinyak@google.com> on 2012-02-14
Reviewed by Hajime Morita.

.:

Exports necessary symbols.

  • Source/autotools/symbols.filter:

Source/WebCore:

Element::shadowRoot() was used for these 3 purposes.

  1. checks a shadow root exists.
  2. gets author shadow root.
  3. gets user agent shadow root.

We have to distinguish them when implementing multiple shadow subtrees.

Calling for (1), (2), and (3) are convered to hasShadowRoot(),
ShadowRootList()->youngestShadowRoot(), and ShadowRootList()->oldestShadowRoot() respectively.

No new tests, no change in behavior.

  • WebCore.exp.in:
  • dom/Document.cpp:

(WebCore::Document::buildAccessKeyMap):

  • dom/Element.cpp:

(WebCore::Element::insertedIntoDocument):
(WebCore::Element::removedFromDocument):
(WebCore::Element::insertedIntoTree):
(WebCore::Element::removedFromTree):
(WebCore::Element::attach):
(WebCore::Element::detach):
(WebCore::Element::recalcStyle):
(WebCore::Element::ensureShadowRoot):
(WebCore::Element::childrenChanged):
(WebCore::Element::focus):

  • dom/Element.h:

(Element):

  • dom/EventDispatcher.cpp:

(WebCore::isShadowHost):

  • dom/Node.cpp:

(WebCore::shadowRoot):

  • dom/NodeRenderingContext.cpp:

(WebCore::NodeRenderingContext::NodeRenderingContext):

  • dom/ShadowRoot.cpp:

(WebCore::ShadowRoot::create):

  • dom/ShadowRootList.cpp:

(WebCore::ShadowRootList::insertedIntoDocument):
(WebCore):
(WebCore::ShadowRootList::removedFromDocument):
(WebCore::ShadowRootList::insertedIntoTree):
(WebCore::ShadowRootList::removedFromTree):
(WebCore::ShadowRootList::hostChildrenChanged):
(WebCore::ShadowRootList::attach):
(WebCore::ShadowRootList::detach):

  • dom/ShadowRootList.h:

(ShadowRootList):

  • dom/TreeScopeAdopter.cpp:

(WebCore::shadowRootFor):

  • html/FileInputType.cpp:

(WebCore::FileInputType::createShadowSubtree):
(WebCore::FileInputType::multipleAttributeChanged):

  • html/HTMLDetailsElement.cpp:

(WebCore::HTMLDetailsElement::createShadowSubtree):
(WebCore::HTMLDetailsElement::findMainSummary):

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::createShadowSubtree):

  • html/HTMLKeygenElement.cpp:

(WebCore::HTMLKeygenElement::HTMLKeygenElement):
(WebCore::HTMLKeygenElement::shadowSelect):

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::mediaControls):
(WebCore::HTMLMediaElement::hasMediaControls):

  • html/HTMLMeterElement.cpp:

(WebCore::HTMLMeterElement::createShadowSubtree):

  • html/HTMLProgressElement.cpp:

(WebCore::HTMLProgressElement::createShadowSubtree):

  • html/HTMLSummaryElement.cpp:

(WebCore::HTMLSummaryElement::createShadowSubtree):

  • html/HTMLTextAreaElement.cpp:

(WebCore::HTMLTextAreaElement::createShadowSubtree):
(WebCore::HTMLTextAreaElement::innerTextElement):
(WebCore::HTMLTextAreaElement::updatePlaceholderText):

  • html/InputType.cpp:

(WebCore::InputType::destroyShadowSubtree):

  • html/RangeInputType.cpp:

(WebCore::RangeInputType::handleMouseDownEvent):
(WebCore::RangeInputType::createShadowSubtree):

  • html/TextFieldInputType.cpp:

(WebCore::TextFieldInputType::createShadowSubtree):
(WebCore::TextFieldInputType::updatePlaceholderText):

  • html/ValidationMessage.cpp:

(WebCore::ValidationMessage::deleteBubbleTree):

  • html/shadow/SliderThumbElement.cpp:

(WebCore::sliderThumbElementOf):
(WebCore::RenderSliderContainer::layout):
(WebCore::trackLimiterElementOf):

  • page/FocusController.cpp:

(WebCore::shadowRoot):

  • rendering/RenderFileUploadControl.cpp:

(WebCore::RenderFileUploadControl::uploadButton):

  • svg/SVGTRefElement.cpp:

(WebCore::SVGTRefElement::updateReferencedText):

  • testing/Internals.cpp:

(WebCore::Internals::ensureShadowRoot):
(WebCore::Internals::shadowRoot):
(WebCore):
(WebCore::Internals::youngestShadowRoot):
(WebCore::Internals::oldestShadowRoot):

  • testing/Internals.h:

(Internals):

  • testing/Internals.idl:

Source/WebKit2:

Exports necesarry symbols.

  • win/WebKit2.def:
  • win/WebKit2CFLite.def:
4:45 AM Changeset in webkit [107705] by apavlov@chromium.org
  • 8 edits in trunk

Elements panel needs to be able to preview images
​https://bugs.webkit.org/show_bug.cgi?id=21570

Reviewed by Pavel Feldman.

Source/WebCore:

  • inspector/front-end/ElementsPanel.js:

(WebInspector.ElementsPanel):
(WebInspector.ElementsPanel.prototype.willHide):
(WebInspector.ElementsPanel.prototype._getPopoverAnchor):
(WebInspector.ElementsPanel.prototype._loadDimensionsForNode.resolvedNode.dimensions):
(WebInspector.ElementsPanel.prototype._loadDimensionsForNode.resolvedNode):
(WebInspector.ElementsPanel.prototype._loadDimensionsForNode):
(WebInspector.ElementsPanel.prototype._showPopover.dimensionsCallback):
(WebInspector.ElementsPanel.prototype._showPopover.showPopover):
(WebInspector.ElementsPanel.prototype._showPopover.buildPopoverContents):
(WebInspector.ElementsPanel.prototype._showPopover):

  • inspector/front-end/ElementsTreeOutline.js:

(WebInspector.ElementsTreeOutline.prototype._onmousemove):

  • inspector/front-end/StylesSidebarPane.js:

(WebInspector.StylePropertyTreeElement.prototype.updateTitle.get g):
(WebInspector.StylePropertyTreeElement.prototype.updateTitle):

  • inspector/front-end/elementsPanel.css:

(.image-preview-container):
(.image-preview-container img):

LayoutTests:

  • inspector/elements/elements-img-tooltip-expected.txt:
  • inspector/elements/elements-img-tooltip.html:
4:36 AM Changeset in webkit [107704] by jochen@chromium.org
  • 4 edits in trunk/Tools

[chromium] check that we're not running multiple modal dialogs at the same time
​https://bugs.webkit.org/show_bug.cgi?id=78486

Reviewed by Kent Tamura.

  • DumpRenderTree/chromium/TestShell.cpp:

(TestShell::TestShell):

  • DumpRenderTree/chromium/TestShell.h:

(TestShell::setIsDisplayingModalDialog):
(TestShell::isDisplayingModalDialog):
(TestShell):

  • DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::runModal):

4:05 AM WebKitIDL edited by haraken@chromium.org
(diff)
4:01 AM Changeset in webkit [107703] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: List expansion arrows is pointing down even
when the list of eventListeners are hidden in the Elements tab
​https://bugs.webkit.org/show_bug.cgi?id=78360

Reviewed by Timothy Hatcher.

  • inspector/front-end/elementsPanel.css:

(.section .event-bar .header):
(.section .event-bars .event-bar .header .title):
(.section .event-bar .header .subtitle):
(.section .event-bar .header::before):
(.section .event-bar.expanded .header::before):

3:42 AM Changeset in webkit [107702] by Csaba Osztrogonác
  • 3 edits in trunk/LayoutTests

[Qt] Unreviewed gardening.

  • platform/qt/Skipped: Typo fix, skip a new failing test.
  • platform/qt/css3/calc/getComputedStyle-margin-percentage-expected.txt: Updated after r107688.
3:37 AM Changeset in webkit [107701] by noel.gordon@gmail.com
  • 5 edits
    3 adds
    1 delete in trunk/LayoutTests

[chromium] Rebaseline JPEG image results after r107389
​https://bugs.webkit.org/show_bug.cgi?id=78454

Unreviewed. Rebaseline #7 of N.

  • platform/chromium-linux/fast/replaced/width100percent-image-expected.png:
  • platform/chromium-mac-leopard/fast/replaced/width100percent-image-expected.png:
  • platform/chromium-mac-snowleopard/fast/replaced/width100percent-image-expected.png: Added.
  • platform/chromium-mac-snowleopard/platform/chromium/compositing/img-layer-grow-expected.png: Added.
  • platform/chromium-mac/fast/replaced/width100percent-image-expected.png: Removed.
  • platform/chromium-win/fast/replaced/width100percent-image-expected.png:
  • platform/chromium-win/platform/chromium/compositing/img-layer-grow-expected.png: Added.
  • platform/chromium/test_expectations.txt:
3:32 AM Changeset in webkit [107700] by hayato@chromium.org
  • 23 edits in trunk

Make ShadowRoot.nodeType return DOCUMENT_FRAGMENT_NODE.
​https://bugs.webkit.org/show_bug.cgi?id=77514

Reviewed by Dimitri Glazkov.

NodeType.SHADOW_ROOT_NODE type is finally gone.

Source/WebCore:

  • bindings/js/JSNodeCustom.cpp:

(WebCore::createWrapperInline):

  • bindings/objc/DOM.mm:

(kitClass):

  • bindings/v8/custom/V8NodeCustom.cpp:

(WebCore::toV8Slow):

  • dom/ContainerNode.cpp:

(WebCore::collectTargetNodes):
(WebCore::ContainerNode::replaceChild):

  • dom/Document.cpp:

(WebCore::Document::importNode):
(WebCore::Document::childTypeAllowed):
(WebCore::Document::canReplaceChild):

  • dom/Node.cpp:

(WebCore::Node::dumpStatistics):
(WebCore::Node::isDefaultNamespace):
(WebCore::Node::lookupPrefix):
(WebCore::Node::lookupNamespaceURI):
(WebCore::appendTextContent):
(WebCore::Node::setTextContent):

  • dom/Node.h:
  • dom/Range.cpp:

(WebCore::lengthOfContentsInNode):
(WebCore::Range::processContentsBetweenOffsets):
(WebCore::Range::insertNode):
(WebCore::Range::checkNodeWOffset):
(WebCore::Range::checkNodeBA):
(WebCore::Range::selectNode):
(WebCore::Range::selectNodeContents):
(WebCore::Range::surroundContents):

  • dom/ShadowRoot.cpp:
  • dom/ShadowRoot.h:

(ShadowRoot):
(WebCore::toShadowRoot):

  • editing/FrameSelection.cpp:

(WebCore::nodeIsDetachedFromDocument):
(WebCore):
(WebCore::FrameSelection::textWillBeReplaced):

  • editing/MarkupAccumulator.cpp:

(WebCore::MarkupAccumulator::appendStartMarkup):

  • html/parser/HTMLElementStack.cpp:

(WebCore::HTMLNames::isRootNode):
(WebCore::HTMLElementStack::pushRootNode):

  • html/parser/HTMLElementStack.h:

(WebCore::isInHTMLNamespace):

  • inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::pushChildNodesToFrontend):
(WebCore::InspectorDOMAgent::buildObjectForNode):

  • xml/XPathUtil.cpp:

(WebCore::XPath::isValidContextNode):

Source/WebKit/chromium:

  • src/WebPageSerializerImpl.cpp:

(WebKit::WebPageSerializerImpl::buildContentForNode):

LayoutTests:

  • fast/dom/shadow/nodetype-expected.txt:
  • fast/dom/shadow/nodetype.html:
  • resources/dump-as-markup.js:

(Markup._get):

3:01 AM Changeset in webkit [107699] by kling@webkit.org
  • 2 edits in trunk/Source/WebCore

StylePropertySet: Try to find a CSSValuePool for identifier values.
<​http://webkit.org/b/78590>

Reviewed by Antti Koivisto.

For StylePropertySets with a parent element (inline and attribute style),
grab at the parentElement()->document() to locate a CSSValuePool.
This code will change soon in the CSSOM refactoring and moreso once we
figure out how to have a global CSSValuePool, but I'm hoping it will buy
us some perf back in the meantime.

  • css/StylePropertySet.cpp:

(WebCore::StylePropertySet::setProperty):

2:54 AM Changeset in webkit [107698] by Nikolas Zimmermann
  • 10 edits in trunk/LayoutTests

svg/hixie/perf has different repaint region in debug vs release
​https://bugs.webkit.org/show_bug.cgi?id=78516

Reviewed by Hajime Morita.

Based on patch by Tony Chang <​tony@chromium.org>.

The problem is the progress text in the lower right. It says,
"Test in progress... X of 10". Depending on how fast the test runs,
this text is never painted and the repaint region changes. Disable
painting of the intermediate text and only include the final text.

Extended Tonys original patch to cover all svg/hixie/perf tests that
suffered from this issue - also avoid using setTimeout between the
individual steps, as we're only interessted in the final repaint
region, not the intermediate ones.

  • platform/mac/svg/hixie/perf/001-expected.png:
  • platform/mac/svg/hixie/perf/002-expected.png:
  • platform/mac/svg/hixie/perf/003-expected.png:
  • svg/hixie/perf/001.xml:
  • svg/hixie/perf/002.xml:
  • svg/hixie/perf/003.xml:
  • svg/hixie/perf/004.xml:
  • svg/hixie/perf/005.xml:
  • svg/hixie/perf/006.xml:
2:41 AM Changeset in webkit [107697] by abarth@webkit.org
  • 2 edits in trunk/Tools

Enable the GPU codepath in the chromium-android port
​https://bugs.webkit.org/show_bug.cgi?id=78580

Reviewed by James Robinson.

Suprise! There is no ChromiumGpuAndroidPort! Instead, Chromium
Android always uses the GPU codepath, so we set the GPU flags on the
main chromium-android port instead.

  • Scripts/webkitpy/layout_tests/port/chromium_android.py:

(ChromiumAndroidPort.init):

2:38 AM Changeset in webkit [107696] by abarth@webkit.org
  • 2 edits in trunk/Tools

NRWT should expose --adb-args flag for Android
​https://bugs.webkit.org/show_bug.cgi?id=78579

Reviewed by Eric Seidel.

This flag is already wired up to the ChromiumAndroidPort.

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:

(parse_args):

2:35 AM Changeset in webkit [107695] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

[Chromium] Inconsistent initialization of CCSettings in WebLayerTreeView.
​https://bugs.webkit.org/show_bug.cgi?id=76927

Patch by David Reveman <​reveman@chromium.org> on 2012-02-14
Reviewed by James Robinson.

Remove unnecessary initialization and include maxPartialTextureUpdates
in FIXME comment.

  • src/WebLayerTreeView.cpp:

(WebKit::WebLayerTreeView::Settings::operator CCSettings):

2:29 AM WebKitIDL edited by haraken@chromium.org
(diff)
2:21 AM Changeset in webkit [107694] by Nikolas Zimmermann
  • 1 edit
    1 add in trunk/LayoutTests

2012-02-14 Nikolas Zimmermann <​nzimmermann@rim.com>

Not reviewed. Add mixing Lion pixel test result for a svg/carto.net test.

  • platform/mac/svg/carto.net/scrollbar-expected.png: Added.
2:19 AM Changeset in webkit [107693] by Nikolas Zimmermann
  • 5 edits in trunk/Source/WebCore

Convert svg/animations to use SMIL methods for driving the timeline
​https://bugs.webkit.org/show_bug.cgi?id=78422

Reviewed by Hajime Morita.

Fix last-minute typo in clearTimesWithDynamicOrigins, leading to assertions browsing the W3C SVG animation tests.
Covered by existing tests in svg/animations.

  • svg/SVGAnimationElement.cpp: Remove unused endedActiveInterval.
  • svg/SVGAnimationElement.h: Ditto.
  • svg/animation/SVGSMILElement.cpp:

(WebCore::clearTimesWithDynamicOrigins): Fix order of walking the times list.
(WebCore::SVGSMILElement::reset): Move calls to clearTimesWithDynamicOrigins into endedActiveInterval.
(WebCore::SVGSMILElement::endedActiveInterval):

  • svg/animation/SVGSMILElement.h:

(SVGSMILElement): Devirtualize endedActiveInterval.

2:04 AM Changeset in webkit [107692] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening, skip new failing tests.

  • platform/qt/Skipped:
1:55 AM Changeset in webkit [107691] by commit-queue@webkit.org
  • 23 edits in trunk

Unreviewed, rolling out r107661.
​http://trac.webkit.org/changeset/107661
​https://bugs.webkit.org/show_bug.cgi?id=78591

crash on lion/qt bots (Requested by hayato on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-02-14

Source/WebCore:

  • bindings/js/JSNodeCustom.cpp:

(WebCore::createWrapperInline):

  • bindings/objc/DOM.mm:

(kitClass):

  • bindings/v8/custom/V8NodeCustom.cpp:

(WebCore::toV8Slow):

  • dom/ContainerNode.cpp:

(WebCore::collectTargetNodes):
(WebCore::ContainerNode::replaceChild):

  • dom/Document.cpp:

(WebCore::Document::importNode):
(WebCore::Document::childTypeAllowed):
(WebCore::Document::canReplaceChild):

  • dom/Node.cpp:

(WebCore::Node::dumpStatistics):
(WebCore::Node::isDefaultNamespace):
(WebCore::Node::lookupPrefix):
(WebCore::Node::lookupNamespaceURI):
(WebCore::appendTextContent):
(WebCore::Node::setTextContent):

  • dom/Node.h:
  • dom/Range.cpp:

(WebCore::lengthOfContentsInNode):
(WebCore::Range::processContentsBetweenOffsets):
(WebCore::Range::insertNode):
(WebCore::Range::checkNodeWOffset):
(WebCore::Range::checkNodeBA):
(WebCore::Range::selectNode):
(WebCore::Range::selectNodeContents):
(WebCore::Range::surroundContents):

  • dom/ShadowRoot.cpp:

(WebCore::ShadowRoot::nodeType):
(WebCore):

  • dom/ShadowRoot.h:

(ShadowRoot):
(WebCore::toShadowRoot):

  • editing/FrameSelection.cpp:

(WebCore::FrameSelection::textWillBeReplaced):

  • editing/MarkupAccumulator.cpp:

(WebCore::MarkupAccumulator::appendStartMarkup):

  • html/parser/HTMLElementStack.cpp:

(WebCore::HTMLNames::isRootNode):
(WebCore::HTMLElementStack::pushRootNode):

  • html/parser/HTMLElementStack.h:

(WebCore::isInHTMLNamespace):

  • inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::pushChildNodesToFrontend):
(WebCore::InspectorDOMAgent::buildObjectForNode):

  • xml/XPathUtil.cpp:

(WebCore::XPath::isValidContextNode):

Source/WebKit/chromium:

  • src/WebPageSerializerImpl.cpp:

(WebKit::WebPageSerializerImpl::buildContentForNode):

LayoutTests:

  • fast/dom/shadow/nodetype-expected.txt:
  • fast/dom/shadow/nodetype.html:
  • resources/dump-as-markup.js:

(Markup._get):

1:52 AM Changeset in webkit [107690] by hayato@chromium.org
  • 6 edits in trunk/Source/WebCore

Fix typo. HTMLContentSeleciton -> HTMLContentSelection.
​https://bugs.webkit.org/show_bug.cgi?id=78571

Reviewed by Hajime Morita.

No tests. No change in behavior.

  • dom/NodeRenderingContext.cpp:

(WebCore::nextRendererOf):
(WebCore::previousRendererOf):
(WebCore::firstRendererOf):
(WebCore::lastRendererOf):

  • dom/ShadowRoot.cpp:

(WebCore::ShadowRoot::insertionPointFor):

  • html/shadow/HTMLContentElement.cpp:

(WebCore::HTMLContentElement::attach):

  • html/shadow/HTMLContentSelector.cpp:

(WebCore::HTMLContentSelection::append):
(WebCore::HTMLContentSelection::unlink):
(WebCore::HTMLContentSelectionList::find):
(WebCore::HTMLContentSelectionList::append):
(WebCore::HTMLContentSelector::select):
(WebCore::HTMLContentSelector::unselect):
(WebCore::HTMLContentSelector::findFor):

  • html/shadow/HTMLContentSelector.h:

(HTMLContentSelection):
(WebCore::HTMLContentSelection::next):
(WebCore::HTMLContentSelection::previous):
(WebCore::HTMLContentSelection::HTMLContentSelection):
(WebCore::HTMLContentSelection::create):
(WebCore::HTMLContentSelectionList::first):
(WebCore::HTMLContentSelectionList::last):
(HTMLContentSelectionList):
(WebCore::HTMLContentSelectionSet::add):
(WebCore::HTMLContentSelectionSet::remove):
(HTMLContentSelectionSet):
(WebCore::HTMLContentSelectionSet::Translator::equal):
(WebCore::HTMLContentSelectionSet::Hash::hash):
(WebCore::HTMLContentSelectionSet::Hash::equal):
(WebCore::HTMLContentSelectionSet::find):
(HTMLContentSelector):

1:50 AM Changeset in webkit [107689] by ap@apple.com
  • 73 edits in trunk

[Mac][Win][WK2] Switch to RFC 6455 protocol for WebSockets
​https://bugs.webkit.org/show_bug.cgi?id=78541
<rdar://problem/10036695>

Reviewed by Kent Tamura.

Source/WebKit/mac:

  • WebView/WebPreferences.mm: (+[WebPreferences initialize]): Changed default value of the

preference.

Source/WebKit/win:

  • WebPreferences.cpp: (WebPreferences::initializeDefaultSettings): Changed default value of

the preference

Source/WebKit2:

  • Shared/WebPreferencesStore.h: (WebKit): Changed default value of the preference.

Tools:

  • DumpRenderTree/mac/DumpRenderTree.mm: (resetDefaultsToConsistentValues):
  • DumpRenderTree/win/DumpRenderTree.cpp: (resetDefaultsToConsistentValues):

After each test, reset to using new protocol.

LayoutTests:

  • http/tests/websocket/tests/hixie76/alert-in-event-handler.html:
  • http/tests/websocket/tests/hixie76/bad-handshake-crash.html:
  • http/tests/websocket/tests/hixie76/bad-sub-protocol-control-chars.html:
  • http/tests/websocket/tests/hixie76/bad-sub-protocol-empty.html:
  • http/tests/websocket/tests/hixie76/bad-sub-protocol-non-ascii.html:
  • http/tests/websocket/tests/hixie76/bufferedAmount-after-close.html:
  • http/tests/websocket/tests/hixie76/client-close.html:
  • http/tests/websocket/tests/hixie76/close-before-open.html:
  • http/tests/websocket/tests/hixie76/close-event.html:
  • http/tests/websocket/tests/hixie76/close-on-navigate-new-location.html:
  • http/tests/websocket/tests/hixie76/close-on-unload-and-force-gc.html:
  • http/tests/websocket/tests/hixie76/close-on-unload-reference-in-parent.html:
  • http/tests/websocket/tests/hixie76/close-on-unload.html:
  • http/tests/websocket/tests/hixie76/close-unref-websocket.html:
  • http/tests/websocket/tests/hixie76/cross-origin.html:
  • http/tests/websocket/tests/hixie76/error-detect.html:
  • http/tests/websocket/tests/hixie76/frame-length-longer-than-buffer.html:
  • http/tests/websocket/tests/hixie76/frame-length-overflow.html:
  • http/tests/websocket/tests/hixie76/frame-length-skip.html:
  • http/tests/websocket/tests/hixie76/frame-lengths.html:
  • http/tests/websocket/tests/hixie76/handshake-challenge-randomness.html:
  • http/tests/websocket/tests/hixie76/handshake-error.html:
  • http/tests/websocket/tests/hixie76/handshake-fail-by-cross-origin.html:
  • http/tests/websocket/tests/hixie76/handshake-fail-by-maxlength.html:
  • http/tests/websocket/tests/hixie76/handshake-fail-by-no-connection-header.html:
  • http/tests/websocket/tests/hixie76/handshake-fail-by-no-cr.html:
  • http/tests/websocket/tests/hixie76/handshake-fail-by-no-upgrade-header.html:
  • http/tests/websocket/tests/hixie76/handshake-fail-by-prepended-null.html:
  • http/tests/websocket/tests/hixie76/handshake-fail-by-sub-protocol-mismatch.html:
  • http/tests/websocket/tests/hixie76/long-invalid-header.html:
  • http/tests/websocket/tests/hixie76/multiple-connections.html:
  • http/tests/websocket/tests/hixie76/null-character.html:
  • http/tests/websocket/tests/hixie76/reload-crash.html:
  • http/tests/websocket/tests/hixie76/send-after-close-on-unload.html:
  • http/tests/websocket/tests/hixie76/send-empty.html:
  • http/tests/websocket/tests/hixie76/send-object.html:
  • http/tests/websocket/tests/hixie76/send-throw.html:
  • http/tests/websocket/tests/hixie76/send.html:
  • http/tests/websocket/tests/hixie76/server-close.html:
  • http/tests/websocket/tests/hixie76/simple-stress.html:
  • http/tests/websocket/tests/hixie76/simple.html:
  • http/tests/websocket/tests/hixie76/split-binary-frame-header.html:
  • http/tests/websocket/tests/hixie76/sub-protocol-with-space.html:
  • http/tests/websocket/tests/hixie76/sub-protocol.html:
  • http/tests/websocket/tests/hixie76/undefined-attributes.html:
  • http/tests/websocket/tests/hixie76/unicode.html:
  • http/tests/websocket/tests/hixie76/url-attribute.html:
  • http/tests/websocket/tests/hixie76/url-no-trailing-slash.html:
  • http/tests/websocket/tests/hixie76/url-parsing.html:
  • http/tests/websocket/tests/hixie76/url-with-credential.html:
  • http/tests/websocket/tests/hixie76/url-with-empty-query.html:
  • http/tests/websocket/tests/hixie76/url-with-query-for-no-query.html:
  • http/tests/websocket/tests/hixie76/url-with-query.html:
  • http/tests/websocket/tests/hixie76/websocket-event-target.html:
  • http/tests/websocket/tests/hixie76/websocket-pending-activity.html:
  • http/tests/websocket/tests/hixie76/websocket-protocol-ignored.html:
  • http/tests/websocket/tests/hixie76/workers/close-in-onmessage-crash.html:
  • http/tests/websocket/tests/hixie76/workers/close-in-shared-worker.html:
  • http/tests/websocket/tests/hixie76/workers/close-in-worker.html:
  • http/tests/websocket/tests/hixie76/workers/shared-worker-simple.html:
  • http/tests/websocket/tests/hixie76/workers/worker-handshake-challenge-randomness.html:
  • http/tests/websocket/tests/hixie76/workers/worker-simple.html:

Added overridePreference calls, so that the tests don't depend on platform or DRT default.

1:46 AM Changeset in webkit [107688] by mikelawther@chromium.org
  • 20 edits
    3 moves in trunk

CSS3 calc: embed calc expressions in CSSPrimitiveValue
​https://bugs.webkit.org/show_bug.cgi?id=78446

Source/WebCore:

Reviewed by Ojan Vafai.

Adds calc expressions to CSSPrimitiveValue. This enables simple (ie no mixing of
percents with numbers/lengths) expressions to be evaluated on most properties.

Tests: css3/calc/block-mask-overlay-image-outset-expected.html

css3/calc/css3-radial-gradients-expected.html
css3/calc/gradient-color-stops-expected.html

  • css/CSSCalculationValue.cpp:

(WebCore::CSSCalcValue::computeLengthPx):
(WebCore):
(WebCore::CSSCalcPrimitiveValue::doubleValue):
(CSSCalcPrimitiveValue):
(WebCore::CSSCalcPrimitiveValue::computeLengthPx):
(CSSCalcBinaryOperation):
(WebCore::CSSCalcBinaryOperation::computeLengthPx):

  • css/CSSCalculationValue.h:

(CSSCalcExpressionNode):
(CSSCalcValue):

  • css/CSSParser.cpp:

(WebCore::CSSParser::createPrimitiveNumericValue):
(WebCore::CSSParser::parseValidPrimitive):

  • css/CSSPrimitiveValue.cpp:

(WebCore::isValidCSSUnitTypeForDoubleConversion):
(WebCore::CSSPrimitiveValue::primitiveType):
(WebCore::CSSPrimitiveValue::init):
(WebCore):
(WebCore::CSSPrimitiveValue::cleanup):
(WebCore::CSSPrimitiveValue::computeLengthDouble):
(WebCore::CSSPrimitiveValue::getDoubleValue):
(WebCore::CSSPrimitiveValue::getDoubleValueInternal):
(WebCore::CSSPrimitiveValue::customCssText):

  • css/CSSPrimitiveValue.h:

(WebCore):
(WebCore::CSSPrimitiveValue::isLength):
(WebCore::CSSPrimitiveValue::isNumber):
(WebCore::CSSPrimitiveValue::isPercentage):
(WebCore::CSSPrimitiveValue::isPx):
(WebCore::CSSPrimitiveValue::isCalculated):
(WebCore::CSSPrimitiveValue::isCalculatedPercentageNumber):
(WebCore::CSSPrimitiveValue::isCalculatedPercentageLength):
(CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::getValue):
(WebCore::CSSPrimitiveValue::cssCalcValue):

  • css/CSSStyleApplyProperty.cpp:

(WebCore::ApplyPropertyBorderRadius::applyValue):

LayoutTests:

Reviewed by Ojan Vafai.

  • css3/calc/block-mask-overlay-image-outset-expected.html: Renamed from LayoutTests/css3/calc/block-mask-overlay-image-outset-expected-mismatch.html.
  • css3/calc/border-expected.txt:
  • css3/calc/calc-errors-expected.txt:
  • css3/calc/css3-radial-gradients-expected.html: Renamed from LayoutTests/css3/calc/css3-radial-gradients-expected-mismatch.html.
  • css3/calc/font-expected.txt:
  • css3/calc/font-monospace-expected.txt:
  • css3/calc/font-size-expected.txt:
  • css3/calc/font-size-fractional-expected.txt:
  • css3/calc/getComputedStyle-margin-percentage-expected.txt:
  • css3/calc/gradient-color-stops-expected.html: Renamed from LayoutTests/css3/calc/gradient-color-stops-expected-mismatch.html.
  • css3/calc/line-height-expected.txt:
  • css3/calc/margin-expected.txt:
  • css3/calc/padding-expected.txt:
  • css3/calc/simple-calcs-expected.txt:
  • css3/calc/table-border-spacing-expected.txt:
1:24 AM Changeset in webkit [107687] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

Not reviewed: follow up to r107683: protect inspector sidebar from updating
while inserting new rule.

  • inspector/front-end/StylesSidebarPane.js:

(WebInspector.BlankStylePropertiesSection.prototype.editingSelectorCommitted.successCallback):
(WebInspector.BlankStylePropertiesSection.prototype.editingSelectorCommitted):

1:22 AM Changeset in webkit [107686] by Philippe Normand
  • 5 edits in trunk/LayoutTests

Unreviewed, GTK rebaseline after r107662.

  • platform/gtk/fast/dom/Window/window-properties-expected.txt:
  • platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/gtk/fast/dom/prototype-inheritance-2-expected.txt:
  • platform/gtk/fast/js/global-constructors-expected.txt:
1:13 AM Changeset in webkit [107685] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Extend Chromium V8 tracing to cover more cases
​https://bugs.webkit.org/show_bug.cgi?id=78507

Patch by Rick Byers <rbyers@.com> on 2012-02-14
Reviewed by Eric Seidel.

No tests modified because this affects only chrome tracing which we
currently don't try to validate with automated tests.

  • bindings/v8/V8EventListener.cpp:

(WebCore::V8EventListener::callListenerFunction):

  • bindings/v8/V8Proxy.cpp:

(WebCore::V8Proxy::instrumentedCallFunction):
(WebCore::V8Proxy::newInstance):

1:03 AM WebKitIDL edited by haraken@chromium.org
(diff)
12:55 AM Changeset in webkit [107684] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] Pepper plugins don't receive mouse movement information in
non-mouse-lock mode.
​https://bugs.webkit.org/show_bug.cgi?id=78014

This change makes WebMouseEventBuilder pass along mouse movement
information properly.

There isn't test for this change because:

  • the movement information added is only used by pepper, and there isn't any test for pepper at the WebKit side. (WebKit doesn't know about pepper.)
  • this change is trivial. It just copies two newly-added data fields from MouseEvent to WebMouseEventBuilder during conversion.

Patch by Yuzhu Shen <​yzshen@chromium.com> on 2012-02-14
Reviewed by Tony Chang.

  • src/WebInputEventConversion.cpp:

(WebKit::WebMouseEventBuilder::WebMouseEventBuilder):

12:50 AM Changeset in webkit [107683] by pfeldman@chromium.org
  • 18 edits in trunk

Web Inspector: fire stylesheet changed event upon CSS modifications.
​https://bugs.webkit.org/show_bug.cgi?id=78500

Patch by Pavel Feldman <​pfeldman@google.com> on 2012-02-14
Reviewed by Yury Semikhatsky.

Source/WebCore:

  • inspector/Inspector.json:
  • inspector/InspectorCSSAgent.cpp:

(WebCore::InspectorCSSAgent::SetStyleSheetTextAction::mergeId):
(InspectorCSSAgent::SetStyleSheetTextAction):
(WebCore::InspectorCSSAgent::SetStyleSheetTextAction::merge):
(WebCore::InspectorCSSAgent::setStyleSheetText):
(WebCore::InspectorCSSAgent::asInspectorStyleSheet):
(WebCore::InspectorCSSAgent::bindStyleSheet):
(WebCore::InspectorCSSAgent::viaInspectorStyleSheet):
(WebCore::InspectorCSSAgent::styleSheetChanged):
(WebCore):

  • inspector/InspectorCSSAgent.h:

(InspectorCSSAgent):

  • inspector/InspectorStyleSheet.cpp:

(WebCore::InspectorStyleSheet::create):
(WebCore::InspectorStyleSheet::InspectorStyleSheet):
(WebCore::InspectorStyleSheet::reparseStyleSheet):
(WebCore::InspectorStyleSheet::setRuleSelector):
(WebCore::InspectorStyleSheet::addRule):
(WebCore::InspectorStyleSheet::deleteRule):
(WebCore::InspectorStyleSheet::setPropertyText):
(WebCore::InspectorStyleSheet::toggleProperty):
(WebCore::InspectorStyleSheet::fireStyleSheetChanged):
(WebCore):
(WebCore::InspectorStyleSheetForInlineStyle::create):
(WebCore::InspectorStyleSheetForInlineStyle::InspectorStyleSheetForInlineStyle):

  • inspector/InspectorStyleSheet.h:

(WebCore::InspectorStyleSheet::Listener::~Listener):
(Listener):
(InspectorStyleSheet):
(InspectorStyleSheetForInlineStyle):

  • inspector/front-end/CSSStyleModel.js:

(WebInspector.CSSStyleModel):
(WebInspector.CSSStyleModel.prototype.setRuleSelector):
(WebInspector.CSSStyleModel.prototype.setRuleSelector.callback):
(WebInspector.CSSStyleModel.prototype.addRule):
(WebInspector.CSSStyleModel.prototype.addRule.callback):
(WebInspector.CSSStyleModel.prototype._fireStyleSheetChanged.callback):
(WebInspector.CSSStyleModel.prototype._fireStyleSheetChanged):
(WebInspector.CSSStyleModel.prototype.setStyleSheetText):
(WebInspector.CSSStyleModel.prototype._undoRequested):
(WebInspector.CSSStyleModel.prototype._undoCompleted):
(WebInspector.CSSStyleDeclaration.prototype.insertPropertyAt):
(WebInspector.CSSProperty.prototype.setText):
(WebInspector.CSSProperty.prototype.setText.callback):
(WebInspector.CSSProperty.prototype.setDisabled.callback):
(WebInspector.CSSProperty.prototype.setDisabled):
(WebInspector.CSSStyleSheet.prototype.setText):
(WebInspector.CSSDispatcher.prototype.mediaQueryResultChanged):
(WebInspector.CSSDispatcher.prototype.styleSheetChanged):

  • inspector/front-end/DOMAgent.js:

(WebInspector.DOMAgent.prototype._emulateTouchEventsChanged):
(WebInspector.DOMAgent.prototype.get undo):

  • inspector/front-end/ElementsPanel.js:

(WebInspector.ElementsPanel.prototype.handleShortcut):

LayoutTests:

  • http/tests/inspector/elements-test.js:

(initialize_ElementTest.InspectorTest.generateUndoTest):

  • inspector/elements/set-outer-html-test.js:

(initialize_SetOuterHTMLTest.InspectorTest.recordEvent):
(initialize_SetOuterHTMLTest.InspectorTest.setOuterHTMLUseUndo.bringBack):
(initialize_SetOuterHTMLTest.InspectorTest.setOuterHTMLUseUndo):

  • inspector/styles/styles-history.html:
  • inspector/styles/undo-add-new-rule.html:
  • inspector/styles/undo-add-property.html:
  • inspector/styles/undo-change-property.html:
  • inspector/styles/undo-property-toggle.html:
  • inspector/styles/undo-set-selector-text.html:
12:41 AM Changeset in webkit [107682] by Nikolas Zimmermann
  • 260 edits
    1 delete in trunk

Convert svg/animations to use SMIL methods for driving the timeline
​https://bugs.webkit.org/show_bug.cgi?id=78422

Reviewed by Dirk Schulze.

Source/WebCore:

Switch the svg/animations tests to use SVGSVGElement.setCurrentTime to drive the animation timeline.
This should fix all flakiness we previously had with these tests - and as nice side-effect we're now
using the standard SVG methods to drive the timeline, and thus have more coverage for these methods.
It already exposed several SMIL bugs, that had to be fixed, before this worked:

  • beginElement()/endElement() modify the begin/end times of a SVGSMILElement. When beginElement() is called a new begin time is added to the list - and the same happens for endElement() with the end list. Unfortunately the begin/end times never get removed again, leading to incorrect instance time resolving when begin/endElement is called repeatedly, combined with moving the timeline through setCurrentTime.

SMIL3 specifically demands that all 'dynamic' times in the begin/endTimes list, such that got inserted
via beginElement/endElement - get removed if the begin/endTimes list is updated. Why?
When calling beginElement, then endElement, then beginElement again, the begin/endTimes lists should be
identical, w/o leftovers from any previous begin/endElement call.

To keep track of that introduce SMILTimeWithOrigin, which holds a SMILTime and an Origin enum,
which determines whether this SMILTime was created by the parser or dynamically created via
beginElement/endElement.

  • SMILTimeContainer::setElapsed() (called by SVGSVGElement::setCurrentTime) forgot to update the animation state, when it was not paused.
  • document.getElementsByTagName('animateMotion')[0], always returned 'object SVGElement', instead of SVGAnimateMotion element making it impossible to query the animation start time, as the interfaces from SVGAnimationElement were not available. Fix that by removing the last hacks from svgtags.in, now that all IDLs are available.

Now that we use SVGSVGElement::setCurrentTime to drive the animation testing, we can remove
the DRT specific sampleSVGAnimationAtTime functionality, and its code springled all over WebCore.

Covered by all existing tests in svg/animations.

  • WebCore.exp.in: Remove sampleAnimationAtTime() symbols.
  • WebCore.order: Ditto.
  • svg/SVGAnimationElement.cpp: Add a flag to begin/endElement, SMILTimeWithOrigin::ScriptOrigin, to indicate that these are dynamic SMILTimes, added by a script.

(WebCore::SVGAnimationElement::beginElementAt):
(WebCore::SVGAnimationElement::endElementAt):

  • svg/SVGDocumentExtensions.cpp: Remove sampleAnimationAtTime.
  • svg/SVGDocumentExtensions.h: Ditto.
  • svg/animation/SMILTime.h: Add SMILTimeWithOrigin helper.

(SMILTimeWithOrigin): Needs a SMILTime and an Origin enum entry.
(WebCore::SMILTimeWithOrigin::SMILTimeWithOrigin):
(WebCore::SMILTimeWithOrigin::time): Returns the SMILTime.
(WebCore::SMILTimeWithOrigin::originIsScript): Determines if this SMILTime got added by a script.
(WebCore::operator<): Used by std::sort.

  • svg/animation/SMILTimeContainer.cpp:

(WebCore::SMILTimeContainer::setElapsed): Always call updateAnimations, even if the animation is not paused. Use the right elpased time value, to seek precisely to the desired position.
(WebCore::SMILTimeContainer::timerFired): Cleanup code, no need for a local variable 'elapsed'.
(WebCore::SMILTimeContainer::updateAnimations): Remove DRT specific sampling code, which is no longer needed.

  • svg/animation/SMILTimeContainer.h: Remove sampleAnimationAtTime.
  • svg/animation/SVGSMILElement.cpp:

(WebCore::SVGSMILElement::SVGSMILElement): Only call resolveFirstInterval, not reset, from the constructor - it wastes unnecessary time, as everything is already initialized.
(WebCore::clearTimesWithDynamicOrigins): Helper function to clear all SMILTimes from the begin/endTimes list, that are dynamic.
(WebCore::SVGSMILElement::reset): Clear begin/endTimes lists, on any reset() call (when driving the animation timeline through setElapsed).
(WebCore::SVGSMILElement::insertedIntoDocument): m_beginTimes now stores SMILTimeWithOrigins, adapt the code.
(WebCore::sortTimeList): Ditto.
(WebCore::SVGSMILElement::parseBeginOrEnd): Ditto.
(WebCore::SVGSMILElement::addBeginTime): Ditto.
(WebCore::SVGSMILElement::addEndTime): Ditto.
(WebCore::extractTimeFromVector): Ditto.
(WebCore::SVGSMILElement::findInstanceTime): Ditto.

  • svg/animation/SVGSMILElement.h:
  • svg/svgtags.in: Enable animateMotion/hkern/mpath JS interfaces, which were not enabled, despite their IDLs existed.

Source/WebKit/chromium:

Remove SVG animation sampling functionality provided for DRT, which no longer uses it.
Instead we switched the svg/animations tests to use SVGSVGElement.setCurrentTime.

  • public/WebFrame.h:

(WebFrame):

  • src/WebFrameImpl.cpp:
  • src/WebFrameImpl.h:

(WebFrameImpl):

Source/WebKit/efl:

Remove SVG animation sampling functionality provided for DRT, which no longer uses it.
Instead we switched the svg/animations tests to use SVGSVGElement.setCurrentTime.

  • WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
  • WebCoreSupport/DumpRenderTreeSupportEfl.h:

Source/WebKit/gtk:

Remove SVG animation sampling functionality provided for DRT, which no longer uses it.
Instead we switched the svg/animations tests to use SVGSVGElement.setCurrentTime.

  • WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
  • WebCoreSupport/DumpRenderTreeSupportGtk.h:

(DumpRenderTreeSupportGtk):

Source/WebKit/mac:

Remove SVG animation sampling functionality provided for DRT, which no longer uses it.
Instead we switched the svg/animations tests to use SVGSVGElement.setCurrentTime.

  • WebKit.order:
  • WebView/WebFrame.mm:
  • WebView/WebFramePrivate.h:

Source/WebKit/qt:

Remove SVG animation sampling functionality provided for DRT, which no longer uses it.
Instead we switched the svg/animations tests to use SVGSVGElement.setCurrentTime.

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp:
  • WebCoreSupport/DumpRenderTreeSupportQt.h:

Source/WebKit/win:

Remove SVG animation sampling functionality provided for DRT, which no longer uses it.
Instead we switched the svg/animations tests to use SVGSVGElement.setCurrentTime.

  • Interfaces/IWebFramePrivate.idl:
  • WebFrame.cpp:
  • WebFrame.h:

Tools:

Remove no longer needed SVG specific animation sampling functionality from DRT.
Instead we switched the svg/animations tests to use SVGSVGElement.setCurrentTime.

  • DumpRenderTree/LayoutTestController.cpp:

(LayoutTestController::staticFunctions):

  • DumpRenderTree/LayoutTestController.h:

(LayoutTestController):

  • DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
  • DumpRenderTree/chromium/LayoutTestController.cpp:

(LayoutTestController::LayoutTestController):

  • DumpRenderTree/chromium/LayoutTestController.h:

(LayoutTestController):

  • DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
  • DumpRenderTree/mac/LayoutTestControllerMac.mm:
  • DumpRenderTree/qt/LayoutTestControllerQt.cpp:
  • DumpRenderTree/qt/LayoutTestControllerQt.h:

(LayoutTestController):

  • DumpRenderTree/win/LayoutTestControllerWin.cpp:
  • DumpRenderTree/wx/LayoutTestControllerWx.cpp:

LayoutTests:

Switch the svg/animations tests to use SVGSVGElement.setCurrentTime to drive the animation timeline.
This should fix all flakiness we previously had with these tests - and as nice side-effect we're now
using the standard SVG methods to drive the timeline, and thus have more coverage for these methods.
It already exposed several SMIL bugs, that had to be fixed, before this worked.

This also unifies & cleans up the tests, to use the same formatting and the same shouldBeCloseEnough helpers.

  • svg/animations/animVal-basics-expected.txt:
  • svg/animations/animVal-basics.html:
  • svg/animations/animate-calcMode-spline-by-expected.txt:
  • svg/animations/animate-calcMode-spline-by.html:
  • svg/animations/animate-calcMode-spline-from-by-expected.txt:
  • svg/animations/animate-calcMode-spline-from-by.html:
  • svg/animations/animate-calcMode-spline-from-to-expected.txt:
  • svg/animations/animate-calcMode-spline-from-to.html:
  • svg/animations/animate-calcMode-spline-to-expected.txt:
  • svg/animations/animate-calcMode-spline-to.html:
  • svg/animations/animate-calcMode-spline-values-expected.txt:
  • svg/animations/animate-calcMode-spline-values.html:
  • svg/animations/animate-color-calcMode-discrete.html:
  • svg/animations/animate-color-fill-currentColor.html:
  • svg/animations/animate-color-fill-from-by.html:
  • svg/animations/animate-color-rgba-calcMode-discrete.html:
  • svg/animations/animate-color-transparent.html:
  • svg/animations/animate-currentColor.html:
  • svg/animations/animate-dynamic-update-attributeName.html:
  • svg/animations/animate-end-attribute-expected.txt:
  • svg/animations/animate-end-attribute.html:
  • svg/animations/animate-endElement-beginElement.html:
  • svg/animations/animate-from-to-keyTimes.html:
  • svg/animations/animate-gradient-transform.html:
  • svg/animations/animate-inherit-css-property.html:
  • svg/animations/animate-insert-begin.html:
  • svg/animations/animate-insert-no-begin.html:
  • svg/animations/animate-keySplines.html:
  • svg/animations/animate-mpath-insert.html:
  • svg/animations/animate-number-calcMode-discrete-expected.txt:
  • svg/animations/animate-number-calcMode-discrete-keyTimes.html:
  • svg/animations/animate-number-calcMode-discrete.html:
  • svg/animations/animate-path-animation-Cc-Ss-expected.txt:
  • svg/animations/animate-path-animation-Cc-Ss.html:
  • svg/animations/animate-path-animation-Ll-Vv-Hh-expected.txt:
  • svg/animations/animate-path-animation-Ll-Vv-Hh.html:
  • svg/animations/animate-path-animation-Qq-Tt.html:
  • svg/animations/animate-path-animation-cC-sS-inverse-expected.txt:
  • svg/animations/animate-path-animation-cC-sS-inverse.html:
  • svg/animations/animate-path-animation-lL-vV-hH-inverse-expected.txt:
  • svg/animations/animate-path-animation-lL-vV-hH-inverse.html:
  • svg/animations/animate-path-animation-qQ-tT-inverse.html:
  • svg/animations/animate-path-nested-transforms-expected.txt:
  • svg/animations/animate-path-nested-transforms.html:
  • svg/animations/animate-path-to-animation-expected.txt:
  • svg/animations/animate-path-to-animation.html:
  • svg/animations/animate-text-nested-transforms-expected.txt:
  • svg/animations/animate-text-nested-transforms.html:
  • svg/animations/animateTransform-pattern-transform.html:
  • svg/animations/resources/SVGAnimationTestCase.js:

(isCloseEnough):
(shouldBeCloseEnough):
(moveAnimationTimelineAndSample):
(sampleAnimation):
(runSMILTest):
(runAnimationTest):

  • svg/animations/script-tests/TEMPLATE.html: Removed.
  • svg/animations/script-tests/animVal-basics.js:

(sample3):
(executeTest):

  • svg/animations/script-tests/animate-calcMode-spline-by.js:

(sample2):
(sample3):
(executeTest):

  • svg/animations/script-tests/animate-calcMode-spline-from-by.js:

(sample2):
(sample3):
(executeTest):

  • svg/animations/script-tests/animate-calcMode-spline-from-to.js:

(sample2):
(sample3):
(executeTest):

  • svg/animations/script-tests/animate-calcMode-spline-to.js:

(sample2):
(sample3):
(executeTest):

  • svg/animations/script-tests/animate-calcMode-spline-values.js:

(sample2):
(sample3):
(executeTest):

  • svg/animations/script-tests/animate-color-calcMode-discrete.js:

(executeTest):

  • svg/animations/script-tests/animate-color-fill-currentColor.js:

(executeTest):

  • svg/animations/script-tests/animate-color-fill-from-by.js:

(executeTest):

  • svg/animations/script-tests/animate-color-rgba-calcMode-discrete.js:

(executeTest):

  • svg/animations/script-tests/animate-color-transparent.js:

(executeTest):

  • svg/animations/script-tests/animate-currentColor.js:

(executeTest):

  • svg/animations/script-tests/animate-dynamic-update-attributeName.js:

(executeTest):

  • svg/animations/script-tests/animate-end-attribute.js:

(sample1):
(sample2):
(sample3):
(executeTest):

  • svg/animations/script-tests/animate-endElement-beginElement.js:

(executeTest):
(end):
(begin):

  • svg/animations/script-tests/animate-from-to-keyTimes.js:

(executeTest):

  • svg/animations/script-tests/animate-gradient-transform.js:

(executeTest):

  • svg/animations/script-tests/animate-inherit-css-property.js:

(executeTest):

  • svg/animations/script-tests/animate-insert-begin.js:

(executeTest):

  • svg/animations/script-tests/animate-insert-no-begin.js:

(executeTest):

  • svg/animations/script-tests/animate-keySplines.js:

(executeTest):

  • svg/animations/script-tests/animate-mpath-insert.js:

(executeTest):

  • svg/animations/script-tests/animate-number-calcMode-discrete-keyTimes.js:

(executeTest):

  • svg/animations/script-tests/animate-number-calcMode-discrete.js:

(sample1):
(sample2):
(executeTest):

  • svg/animations/script-tests/animate-path-animation-Cc-Ss.js:

(sample4):
(executeTest):

  • svg/animations/script-tests/animate-path-animation-Ll-Vv-Hh.js:

(sample4):
(executeTest):

  • svg/animations/script-tests/animate-path-animation-Qq-Tt.js:

(executeTest):

  • svg/animations/script-tests/animate-path-animation-cC-sS-inverse.js:

(sample4):
(executeTest):

  • svg/animations/script-tests/animate-path-animation-lL-vV-hH-inverse.js:

(sample4):
(executeTest):

  • svg/animations/script-tests/animate-path-animation-qQ-tT-inverse.js:

(executeTest):

  • svg/animations/script-tests/animate-path-nested-transforms.js:

(g.setAttribute.rect.createSVGElement.rect.setAttribute.rect.setAttribute.rect.setAttribute.rect.setAttribute.rect.setAttribute.g.appendChild.animateMotion.createSVGElement.animateMotion.setAttribute.animateMotion.setAttribute.animateMotion.setAttribute.animateMotion.setAttribute.animateMotion.setAttribute.animateMotion.setAttribute.g.appendChild.rootSVGElement.appendChild.startSample):
(endSample):
(executeTest):

  • svg/animations/script-tests/animate-path-to-animation.js:

(sample2):
(sample3):
(executeTest):

  • svg/animations/script-tests/animate-text-nested-transforms.js:

(rootSVGElement.setAttribute.text.createSVGElement.text.setAttribute.text.textContent.string_appeared_here.text.setAttribute.animateMotion.createSVGElement.animateMotion.setAttribute.animateMotion.setAttribute.animateMotion.setAttribute.animateMotion.setAttribute.animateMotion.setAttribute.animateMotion.setAttribute.text.appendChild.rootSVGElement.appendChild.startSample):
(endSample):
(executeTest):

  • svg/animations/script-tests/animateTransform-pattern-transform.js:

(executeTest):

  • svg/animations/script-tests/svgPreserveAspectRatio-animation-1.js:

(sample1):
(sample2):
(sample3):
(executeTest):

  • svg/animations/script-tests/svgangle-animation-deg-to-grad.js:

(sample2):
(sample3):
(executeTest):

  • svg/animations/script-tests/svgangle-animation-deg-to-rad.js:

(sample2):
(sample3):
(executeTest):

  • svg/animations/script-tests/svgangle-animation-grad-to-deg.js:

(sample2):
(sample3):
(executeTest):

  • svg/animations/script-tests/svgangle-animation-grad-to-rad.js:

(sample2):
(sample3):
(executeTest):

  • svg/animations/script-tests/svgangle-animation-rad-to-deg.js:

(sample2):
(sample3):
(executeTest):

  • svg/animations/script-tests/svgangle-animation-rad-to-grad.js:

(sample2):
(sample3):
(executeTest):

  • svg/animations/script-tests/svgboolean-animation-1.js:

(sample1):
(sample2):
(sample3):
(executeTest):

  • svg/animations/script-tests/svginteger-animation-1.js:

(sample1):
(sample2):
(sample3):
(executeTest):

  • svg/animations/script-tests/svglength-animation-LengthModeHeight.js:

(sample3):
(executeTest):

  • svg/animations/script-tests/svglength-animation-LengthModeOther.js:

(sample3):
(executeTest):

  • svg/animations/script-tests/svglength-animation-LengthModeWidth.js:

(sample3):
(executeTest):

  • svg/animations/script-tests/svglength-animation-invalid-value-1.js:

(executeTest):

  • svg/animations/script-tests/svglength-animation-invalid-value-2.js:

(executeTest):

  • svg/animations/script-tests/svglength-animation-invalid-value-3.js:

(executeTest):

  • svg/animations/script-tests/svglength-animation-number-to-number.js:

(sample3):
(executeTest):

  • svg/animations/script-tests/svglength-animation-px-to-cm.js:

(sample3):
(executeTest):

  • svg/animations/script-tests/svglength-animation-px-to-ems.js:

(sample3):
(executeTest):

  • svg/animations/script-tests/svglength-animation-px-to-exs.js:

(sample3):
(executeTest):

  • svg/animations/script-tests/svglength-animation-px-to-in.js:

(sample3):
(executeTest):

  • svg/animations/script-tests/svglength-animation-px-to-number.js:

(sample3):
(executeTest):

  • svg/animations/script-tests/svglength-animation-px-to-pc.js:

(sample3):
(executeTest):

  • svg/animations/script-tests/svglength-animation-px-to-percentage.js:

(sample3):
(executeTest):

  • svg/animations/script-tests/svglength-animation-px-to-pt.js:

(sample3):
(executeTest):

  • svg/animations/script-tests/svglength-animation-px-to-px.js:

(sample3):
(executeTest):

  • svg/animations/script-tests/svglength-animation-unitType.js:

(executeTest):

  • svg/animations/script-tests/svglength-animation-values.js:

(sample5):
(executeTest):

  • svg/animations/script-tests/svglengthlist-animation-1.js:

(sample1):
(sample2):
(sample3):
(executeTest):

  • svg/animations/script-tests/svglengthlist-animation-2.js:

(sample3):
(executeTest):

  • svg/animations/script-tests/svglengthlist-animation-3.js:

(sample1):
(sample2):
(sample3):
(executeTest):

  • svg/animations/script-tests/svglengthlist-animation-4.js:

(sample1):
(sample2):
(sample3):
(executeTest):

  • svg/animations/script-tests/svglengthlist-animation-5.js:

(sample1):
(sample2):
(sample3):
(executeTest):

  • svg/animations/script-tests/svgnumber-animation-1.js:

(executeTest):

  • svg/animations/script-tests/svgnumber-animation-2.js:

(executeTest):

  • svg/animations/script-tests/svgnumber-animation-3.js:

(executeTest):

  • svg/animations/script-tests/svgnumberlist-animation-1.js:

(sample1):
(sample2):
(sample3):
(executeTest):

  • svg/animations/script-tests/svgnumberlist-animation-2.js:

(sample1):
(sample2):
(sample3):
(executeTest):

  • svg/animations/script-tests/svgnumberoptionalnumber-animation-1.js:

(sample1):
(sample2):
(sample3):
(executeTest):

  • svg/animations/script-tests/svgnumberoptionalnumber-animation-2.js:

(sample1):
(sample2):
(sample3):
(executeTest):

  • svg/animations/script-tests/svgnumberoptionalnumber-animation-3.js:

(sample1):
(sample2):
(sample3):
(executeTest):

  • svg/animations/script-tests/svgnumberoptionalnumber-animation-4.js:

(sample1):
(sample2):
(sample3):
(executeTest):

  • svg/animations/script-tests/svgpath-animation-1.js:

(sample3):
(executeTest):

  • svg/animations/script-tests/svgpointlist-animation-1.js:

(sample3):
(executeTest):

  • svg/animations/script-tests/svgpointlist-animation-2.js:

(sample3):
(executeTest):

  • svg/animations/script-tests/svgrect-animation-1.js:

(sample3):
(executeTest):

  • svg/animations/script-tests/svgrect-animation-2.js:

(sample3):
(executeTest):

  • svg/animations/script-tests/svgstring-animation-fallback-to-discrete.js:

(executeTest):

  • svg/animations/script-tests/svgtransform-animation-1.js:

(executeTest):

  • svg/animations/script-tests/svgtransform-animation-discrete.js:

(executeTest):

  • svg/animations/smil-element-not-removed-crash.html:
  • svg/animations/svgPreserveAspectRatio-animation-1.html:
  • svg/animations/svgangle-animation-deg-to-grad-expected.txt:
  • svg/animations/svgangle-animation-deg-to-grad.html:
  • svg/animations/svgangle-animation-deg-to-rad-expected.txt:
  • svg/animations/svgangle-animation-deg-to-rad.html:
  • svg/animations/svgangle-animation-grad-to-deg-expected.txt:
  • svg/animations/svgangle-animation-grad-to-deg.html:
  • svg/animations/svgangle-animation-grad-to-rad-expected.txt:
  • svg/animations/svgangle-animation-grad-to-rad.html:
  • svg/animations/svgangle-animation-rad-to-deg-expected.txt:
  • svg/animations/svgangle-animation-rad-to-deg.html:
  • svg/animations/svgangle-animation-rad-to-grad-expected.txt:
  • svg/animations/svgangle-animation-rad-to-grad.html:
  • svg/animations/svgboolean-animation-1.html:
  • svg/animations/svginteger-animation-1.html:
  • svg/animations/svglength-animation-LengthModeHeight-expected.txt:
  • svg/animations/svglength-animation-LengthModeHeight.html:
  • svg/animations/svglength-animation-LengthModeOther-expected.txt:
  • svg/animations/svglength-animation-LengthModeOther.html:
  • svg/animations/svglength-animation-LengthModeWidth-expected.txt:
  • svg/animations/svglength-animation-LengthModeWidth.html:
  • svg/animations/svglength-animation-invalid-value-1.html:
  • svg/animations/svglength-animation-invalid-value-2.html:
  • svg/animations/svglength-animation-invalid-value-3.html:
  • svg/animations/svglength-animation-number-to-number-expected.txt:
  • svg/animations/svglength-animation-number-to-number.html:
  • svg/animations/svglength-animation-px-to-cm-expected.txt:
  • svg/animations/svglength-animation-px-to-cm.html:
  • svg/animations/svglength-animation-px-to-ems-expected.txt:
  • svg/animations/svglength-animation-px-to-ems.html:
  • svg/animations/svglength-animation-px-to-exs-expected.txt:
  • svg/animations/svglength-animation-px-to-exs.html:
  • svg/animations/svglength-animation-px-to-in-expected.txt:
  • svg/animations/svglength-animation-px-to-in.html:
  • svg/animations/svglength-animation-px-to-number-expected.txt:
  • svg/animations/svglength-animation-px-to-number.html:
  • svg/animations/svglength-animation-px-to-pc-expected.txt:
  • svg/animations/svglength-animation-px-to-pc.html:
  • svg/animations/svglength-animation-px-to-percentage-expected.txt:
  • svg/animations/svglength-animation-px-to-percentage.html:
  • svg/animations/svglength-animation-px-to-pt-expected.txt:
  • svg/animations/svglength-animation-px-to-pt.html:
  • svg/animations/svglength-animation-px-to-px-expected.txt:
  • svg/animations/svglength-animation-px-to-px.html:
  • svg/animations/svglength-animation-unitType.html:
  • svg/animations/svglength-animation-values-expected.txt:
  • svg/animations/svglength-animation-values.html:
  • svg/animations/svglengthlist-animation-1.html:
  • svg/animations/svglengthlist-animation-2-expected.txt:
  • svg/animations/svglengthlist-animation-2.html:
  • svg/animations/svglengthlist-animation-3.html:
  • svg/animations/svglengthlist-animation-4.html:
  • svg/animations/svglengthlist-animation-5.html:
  • svg/animations/svgnumber-animation-1.html:
  • svg/animations/svgnumber-animation-2.html:
  • svg/animations/svgnumber-animation-3.html:
  • svg/animations/svgnumberlist-animation-1-expected.txt:
  • svg/animations/svgnumberlist-animation-1.html:
  • svg/animations/svgnumberlist-animation-2-expected.txt:
  • svg/animations/svgnumberlist-animation-2.html:
  • svg/animations/svgnumberoptionalnumber-animation-1.html:
  • svg/animations/svgnumberoptionalnumber-animation-2.html:
  • svg/animations/svgnumberoptionalnumber-animation-3.html:
  • svg/animations/svgnumberoptionalnumber-animation-4.html:
  • svg/animations/svgpath-animation-1-expected.txt:
  • svg/animations/svgpath-animation-1.html:
  • svg/animations/svgpointlist-animation-1-expected.txt:
  • svg/animations/svgpointlist-animation-1.html:
  • svg/animations/svgpointlist-animation-2-expected.txt:
  • svg/animations/svgpointlist-animation-2.html:
  • svg/animations/svgrect-animation-1-expected.txt:
  • svg/animations/svgrect-animation-1.html:
  • svg/animations/svgrect-animation-2-expected.txt:
  • svg/animations/svgrect-animation-2.html:
  • svg/animations/svgstring-animation-fallback-to-discrete-expected.txt:
  • svg/animations/svgstring-animation-fallback-to-discrete.html:
  • svg/animations/svgtransform-animation-1.html:
  • svg/animations/svgtransform-animation-discrete-expected.txt:
  • svg/animations/svgtransform-animation-discrete.html:
12:24 AM Changeset in webkit [107681] by pfeldman@chromium.org
  • 3 edits
    2 adds in trunk

Web Inspector: [REGRESSION] Copy Stack Trace is broken
​https://bugs.webkit.org/show_bug.cgi?id=78583

Reviewed by Yury Semikhatsky.

Source/WebCore:

Test: inspector/debugger/copy-stack-trace.html

  • inspector/front-end/CallStackSidebarPane.js:

(WebInspector.CallStackSidebarPane.prototype._copyStackTrace):

LayoutTests:

  • inspector/debugger/copy-stack-trace-expected.txt: Added.
  • inspector/debugger/copy-stack-trace.html: Added.
12:17 AM Changeset in webkit [107680] by noel.gordon@gmail.com
  • 12 edits
    1 move
    4 adds
    6 deletes in trunk/LayoutTests

[chromium] Rebaseline JPEG image results after r107389
​https://bugs.webkit.org/show_bug.cgi?id=78454

Unreviewed. Rebaseline #6 of N (visually re-inspecting as I go along, lest skia bite me).

  • fast/replaced/image-tag-expected.txt: Renamed from LayoutTests/platform/gtk/fast/replaced/image-tag-expected.txt.
  • platform/chromium-linux/fast/replaced/absolute-image-sizing-expected.png:
  • platform/chromium-linux/fast/replaced/image-onload-expected.png:
  • platform/chromium-linux/fast/replaced/image-sizing-expected.png:
  • platform/chromium-mac-leopard/fast/replaced/absolute-image-sizing-expected.png:
  • platform/chromium-mac-leopard/fast/replaced/image-onload-expected.png:
  • platform/chromium-mac-leopard/fast/replaced/image-sizing-expected.png:
  • platform/chromium-mac-snowleopard/fast/replaced/absolute-image-sizing-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/replaced/image-onload-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/replaced/image-sizing-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/replaced/image-tag-expected.png: Added.
  • platform/chromium-mac/fast/replaced/absolute-image-sizing-expected.png: Removed.
  • platform/chromium-mac/fast/replaced/image-onload-expected.png: Removed.
  • platform/chromium-mac/fast/replaced/image-sizing-expected.png: Removed.
  • platform/chromium-mac/fast/replaced/image-tag-expected.png: Removed.
  • platform/chromium-win/fast/replaced/absolute-image-sizing-expected.png:
  • platform/chromium-win/fast/replaced/image-onload-expected.png:
  • platform/chromium-win/fast/replaced/image-sizing-expected.png:
  • platform/chromium-win/fast/replaced/image-tag-expected.png:
  • platform/chromium/test_expectations.txt:
  • platform/mac/fast/replaced/image-tag-expected.txt: Removed.
  • platform/qt/fast/replaced/image-tag-expected.txt: Removed.
12:16 AM Changeset in webkit [107679] by eric@webkit.org
  • 2 edits in trunk/Source/WebCore

Upstream Android's support for SK_B32_SHIFT to JPEGImageEncoder
​https://bugs.webkit.org/show_bug.cgi?id=78540

Reviewed by Adam Barth.

  • platform/image-encoders/skia/JPEGImageEncoder.cpp:

(WebCore::encodePixels):

12:05 AM Changeset in webkit [107678] by eric@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Upstream Android's additions to Platform.h
​https://bugs.webkit.org/show_bug.cgi?id=78536

Reviewed by Adam Barth.

  • wtf/Platform.h:
12:01 AM Applications using WebKit edited by wesley
(diff)

Feb 13, 2012:

11:54 PM Changeset in webkit [107677] by mihaip@chromium.org
  • 3 edits
    2 deletes in trunk/Source/WebKit/chromium

[Chromium] Remove BoundObject
​https://bugs.webkit.org/show_bug.cgi?id=78531

Reviewed by Pavel Feldman.

Remove the BoundObject class, references to it were removed in r56999.

  • WebKit.gyp:
  • src/BoundObject.cpp: Removed.
  • src/BoundObject.h: Removed.
  • src/WebDevToolsFrontendImpl.cpp:
11:48 PM Changeset in webkit [107676] by pfeldman@chromium.org
  • 5 edits in trunk

[Qt] inspector/styles/undo-add-new-rule.html crashes
​https://bugs.webkit.org/show_bug.cgi?id=78502

Reviewed by Yury Semikhatsky.

Source/WebCore:

  • inspector/InspectorStyleSheet.cpp:

(WebCore::InspectorStyleSheet::deleteRule):

LayoutTests:

  • platform/chromium/test_expectations.txt:
  • platform/qt/Skipped:
11:38 PM Changeset in webkit [107675] by noel.gordon@gmail.com
  • 6 edits
    1 move
    2 adds
    2 deletes in trunk/LayoutTests

[chromium] Rebaseline JPEG image results after r107389
​https://bugs.webkit.org/show_bug.cgi?id=78454

Unreviewed. Rebaseline #5 of N

  • platform/chromium-linux/fast/images/gray-scale-jpeg-with-color-profile-expected.png:
  • platform/chromium-mac-snowleopard/fast/images/gray-scale-jpeg-with-color-profile-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/images/image-css3-content-data-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/images/ycbcr-with-cmyk-color-profile-expected.png:
  • platform/chromium-win/fast/images/gray-scale-jpeg-with-color-profile-expected.png:
  • platform/chromium-win/fast/images/image-css3-content-data-expected.png: Renamed from LayoutTests/platform/chromium/fast/images/image-css3-content-data-expected.png.
  • platform/chromium-win/fast/images/ycbcr-with-cmyk-color-profile-expected.png:
  • platform/chromium/fast/images/gray-scale-jpeg-with-color-profile-expected.png: Removed.
  • platform/chromium/test_expectations.txt:
  • platform/mac-snowleopard/fast/images/ycbcr-with-cmyk-color-profile-expected.png: Removed.
11:31 PM Changeset in webkit [107674] by commit-queue@webkit.org
  • 1 edit
    2 adds in trunk/Source/WebKit

Initial upstreaming of selection handling code for BlackBerry port
​https://bugs.webkit.org/show_bug.cgi?id=78136

Patch by Nima Ghanavatian <​nghanavatian@rim.com> on 2012-02-13
Reviewed by Rob Buis.

Initial upstreaming, no new tests.

  • blackberry/WebKitSupport/SelectionHandler.cpp: Added.
  • blackberry/WebKitSupport/SelectionHandler.h: Added.
11:22 PM Changeset in webkit [107673] by noel.gordon@gmail.com
  • 9 edits
    1 add
    1 delete in trunk/LayoutTests

[chromium] Rebaseline JPEG image results after r107389
​https://bugs.webkit.org/show_bug.cgi?id=78454

Unreviewed. Rebaseline #4 of N

  • platform/chromium-linux/fast/block/float/014-expected.png:
  • platform/chromium-linux/fast/repaint/block-layout-inline-children-replaced-expected.png:
  • platform/chromium-mac-leopard/fast/block/float/014-expected.png:
  • platform/chromium-mac-leopard/fast/repaint/block-layout-inline-children-replaced-expected.png:
  • platform/chromium-mac-snowleopard/fast/block/float/014-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/repaint/block-layout-inline-children-replaced-expected.png:
  • platform/chromium-mac/fast/block/float/014-expected.png: Removed.
  • platform/chromium-win/fast/block/float/014-expected.png:
  • platform/chromium-win/fast/repaint/block-layout-inline-children-replaced-expected.png:
  • platform/chromium/test_expectations.txt:
10:45 PM Changeset in webkit [107672] by Nate Chapin
  • 12 edits in trunk

Source/WebCore: Reuse CachedRawResources (e.g., XHRs) that are stored
in the MemoryCache when appropriate.
​https://bugs.webkit.org/show_bug.cgi?id=76564

Reviewed by Antti Koivisto.

No new tests, expected behavior covered by existing tests.

  • html/DOMURL.cpp:

(WebCore::DOMURL::revokeObjectURL): Objects shouldn't remain in the

MemoryCache if revokeObjectURL is called on them.

  • inspector/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::cachedResourceContent): Add CachedRawResource support.

  • inspector/InspectorResourceAgent.cpp:

(WebCore::InspectorResourceAgent::setCacheDisabled): Immediately

evict resources, rather than waiting for navigation, since XHRs
should hit the cache if it has been disabled.

  • loader/cache/CachedRawResource.cpp:

(CachedRawResourceCallback): Encapsulates the async callback for

a cache hit for CachedRawResources.

(WebCore::CachedRawResource::sendCallbacks): Do the work defered in didAddClient.
(WebCore::CachedRawResource::didAddClient): Scheduled a CachedRawResourceCallback if

we already have a response, since async XHRs may not play nicely with receiving
their data synchronously.

(WebCore::CachedRawResource::removeClient): Ensure we cancel a callback to a client if

it removes itself.

(WebCore::CachedRawResource::canReuse): Provide some basic rules for when a

CachedRawResource can be reused.

  • loader/cache/CachedRawResource.h:
  • loader/cache/CachedResource.h:
  • loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::determineRevalidationPolicy): Don't automatically reload

CachedRawResources, and add a check for whether this request has already been
made conditional.

  • xml/XMLHttpRequest.cpp:

LayoutTests: Test update for ​https://bugs.webkit.org/show_bug.cgi?id=76564.

Use sync XHRs instead of async in network-content-replacement-xhr.html,
since the inspector pulls async XHR data off of its CachedResource, instead
of a buffer it controls.

Reviewed by Antti Koivisto.

  • http/tests/inspector/network/network-content-replacement-xhr-expected.txt:
  • http/tests/inspector/network/network-content-replacement-xhr.html:
10:41 PM Changeset in webkit [107671] by noel.gordon@gmail.com
  • 4 edits
    2 moves
    2 adds
    6 deletes in trunk/LayoutTests

[chromium] Rebaseline JPEG image results after r107389
​https://bugs.webkit.org/show_bug.cgi?id=78454

Unreviewed. Rebaseline #3 of N

  • fast/backgrounds/size/backgroundSize21-expected.txt: Renamed from LayoutTests/platform/gtk/fast/backgrounds/size/backgroundSize21-expected.txt.
  • fast/backgrounds/size/backgroundSize22-expected.txt: Renamed from LayoutTests/platform/gtk/fast/backgrounds/size/backgroundSize22-expected.txt.
  • platform/chromium-mac-snowleopard/fast/backgrounds/size/backgroundSize21-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/backgrounds/size/backgroundSize22-expected.png: Added.
  • platform/chromium-mac/fast/backgrounds/size/backgroundSize21-expected.png: Removed.
  • platform/chromium-mac/fast/backgrounds/size/backgroundSize22-expected.png: Removed.
  • platform/chromium-win/fast/backgrounds/size/backgroundSize21-expected.png:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize22-expected.png:
  • platform/chromium/test_expectations.txt:
  • platform/mac/fast/backgrounds/size/backgroundSize21-expected.txt: Removed.
  • platform/mac/fast/backgrounds/size/backgroundSize22-expected.txt: Removed.
  • platform/qt/fast/backgrounds/size/backgroundSize21-expected.txt: Removed.
  • platform/qt/fast/backgrounds/size/backgroundSize22-expected.txt: Removed.
10:30 PM WebKitIDL edited by haraken@chromium.org
(diff)
10:25 PM Changeset in webkit [107670] by noel.gordon@gmail.com
  • 6 edits
    4 moves
    4 adds
    12 deletes in trunk/LayoutTests

[chromium] Rebaseline JPEG image results after r107389
​https://bugs.webkit.org/show_bug.cgi?id=78454

Unreviewed. Rebaseline #2 of N

  • fast/backgrounds/size/backgroundSize17-expected.txt: Renamed from LayoutTests/platform/gtk/fast/backgrounds/size/backgroundSize17-expected.txt.
  • fast/backgrounds/size/backgroundSize18-expected.txt: Renamed from LayoutTests/platform/gtk/fast/backgrounds/size/backgroundSize18-expected.txt.
  • fast/backgrounds/size/backgroundSize19-expected.txt: Renamed from LayoutTests/platform/gtk/fast/backgrounds/size/backgroundSize19-expected.txt.
  • fast/backgrounds/size/backgroundSize20-expected.txt: Renamed from LayoutTests/platform/gtk/fast/backgrounds/size/backgroundSize20-expected.txt.
  • platform/chromium-mac-snowleopard/fast/backgrounds/size/backgroundSize17-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/backgrounds/size/backgroundSize18-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/backgrounds/size/backgroundSize19-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/backgrounds/size/backgroundSize20-expected.png: Added.
  • platform/chromium-mac/fast/backgrounds/size/backgroundSize17-expected.png: Removed.
  • platform/chromium-mac/fast/backgrounds/size/backgroundSize18-expected.png: Removed.
  • platform/chromium-mac/fast/backgrounds/size/backgroundSize19-expected.png: Removed.
  • platform/chromium-mac/fast/backgrounds/size/backgroundSize20-expected.png: Removed.
  • platform/chromium-win/fast/backgrounds/size/backgroundSize17-expected.png:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize18-expected.png:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize19-expected.png:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize20-expected.png:
  • platform/chromium/test_expectations.txt:
  • platform/mac/fast/backgrounds/size/backgroundSize17-expected.txt: Removed.
  • platform/mac/fast/backgrounds/size/backgroundSize18-expected.txt: Removed.
  • platform/mac/fast/backgrounds/size/backgroundSize19-expected.txt: Removed.
  • platform/mac/fast/backgrounds/size/backgroundSize20-expected.txt: Removed.
  • platform/qt/fast/backgrounds/size/backgroundSize17-expected.txt: Removed.
  • platform/qt/fast/backgrounds/size/backgroundSize18-expected.txt: Removed.
  • platform/qt/fast/backgrounds/size/backgroundSize19-expected.txt: Removed.
  • platform/qt/fast/backgrounds/size/backgroundSize20-expected.txt: Removed.
9:57 PM Changeset in webkit [107669] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

[chromium] Set opaque flag on SkBitmap in per-tile layer updater
​https://bugs.webkit.org/show_bug.cgi?id=78498

Patch by Dana Jansens <​danakj@chromium.org> on 2012-02-13
Reviewed by Stephen White.

No new tests.

  • platform/graphics/chromium/BitmapSkPictureCanvasLayerTextureUpdater.cpp:

(WebCore::BitmapSkPictureCanvasLayerTextureUpdater::Texture::prepareRect):

  • platform/graphics/chromium/SkPictureCanvasLayerTextureUpdater.h:

(SkPictureCanvasLayerTextureUpdater):
(WebCore::SkPictureCanvasLayerTextureUpdater::layerIsOpaque):

9:28 PM Changeset in webkit [107668] by noel.gordon@gmail.com
  • 5 edits
    2 adds
    2 deletes in trunk/LayoutTests

Rebaseline JPEG image results after r107389
​https://bugs.webkit.org/show_bug.cgi?id=78454

Unreviewed. Rebaseline #1 of N

  • platform/chromium-linux/compositing/geometry/vertical-scroll-composited-expected.png:
  • platform/chromium-mac-snowleopard/compositing/geometry/horizontal-scroll-composited-expected.png: Added.
  • platform/chromium-mac-snowleopard/compositing/geometry/vertical-scroll-composited-expected.png: Added.
  • platform/chromium-win/compositing/geometry/horizontal-scroll-composited-expected.png:
  • platform/chromium-win/compositing/geometry/vertical-scroll-composited-expected.png:
  • platform/chromium/compositing/geometry/horizontal-scroll-composited-expected.png: Removed.
  • platform/chromium/compositing/geometry/vertical-scroll-composited-expected.png: Removed.
  • platform/chromium/test_expectations.txt:
9:19 PM Changeset in webkit [107667] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

Add Linux ChromiumOS test results to flakiness dashboard.
​https://bugs.webkit.org/show_bug.cgi?id=78495

Patch by Rob Flack <​flackr@chromium.org> on 2012-02-13
Reviewed by Ojan Vafai.

  • TestResultServer/static-dashboards/builders.js:
  • TestResultServer/static-dashboards/dashboard_base.js:
9:05 PM Changeset in webkit [107666] by noel.gordon@gmail.com
  • 2 edits in trunk/LayoutTests

[chromium] Unreviewed, remove svg/custom/grayscale-gradient-mask.svg CRASH expectation
​https://bugs.webkit.org/show_bug.cgi?id=78556

  • platform/chromium/test_expectations.txt:
8:41 PM Changeset in webkit [107665] by wjmaclean@chromium.org
  • 18 edits in trunk/Source

[chromium] Remove obsolete zoom animation pathway.
​https://bugs.webkit.org/show_bug.cgi?id=78359

Reviewed by James Robinson.

Source/WebCore:

Tests for existing pathways should not be broken. Tests for removed pathway removed previously.

This patch removes dead code from the previous incarnation of zoom animation for chromium.

  • page/EventHandler.cpp:

(WebCore::EventHandler::handleGestureEvent):

  • page/FrameView.cpp:
  • page/FrameView.h:

(FrameView):

  • platform/ScrollAnimator.cpp:

(WebCore::ScrollAnimator::ScrollAnimator):

  • platform/ScrollAnimator.h:

(ScrollAnimator):

  • platform/ScrollAnimatorNone.cpp:

(WebCore::ScrollAnimatorNone::ScrollAnimatorNone):
(WebCore::ScrollAnimatorNone::animationTimerFired):

  • platform/ScrollAnimatorNone.h:

(ScrollAnimatorNone):

  • platform/ScrollableArea.cpp:
  • platform/ScrollableArea.h:
  • testing/InternalSettings.cpp:
  • testing/InternalSettings.h:

(InternalSettings):

  • testing/InternalSettings.idl:
  • testing/Internals.cpp:

Source/WebKit/chromium:

This patch removes dead code from the previous incarnation of zoom animation for chromium.

  • src/WebViewImpl.cpp:

Source/WebKit2:

This patch removes dead code from the previous incarnation of zoom animation for chromium.

WebProcess/Plugins/PDF/BuiltInPDFView.h:
(BuiltInPDFView):

8:38 PM Changeset in webkit [107664] by noel.gordon@gmail.com
  • 2 edits in trunk/LayoutTests

fast/text/atsui-multiple-renderers.html and related report IMAGE failure on commit queue
​https://bugs.webkit.org/show_bug.cgi?id=78544

Unreviewed. Test expectations update: PASS locally on linux but IMAGE on the queue.

  • platform/chromium/test_expectations.txt: fast/text/atsui-multiple-renderers.html fast/text/international/danda-space.html fast/text/international/thai-baht-space.html fast/text/international/thai-line-breaks.html platform/chromium-linux/fast/text/international/complex-joining-using-gpos.html
8:19 PM Changeset in webkit [107663] by shinyak@chromium.org
  • 2 edits in trunk/Source/WebCore

[Regression] r107650 broke the windows build.
​https://bugs.webkit.org/show_bug.cgi?id=78569

Build fix, Unreviewed.

The variable defined in switch statement should not escape from the switch statement.

  • dom/Element.cpp:

(WebCore::Element::webkitRegionOverflow):

8:03 PM Changeset in webkit [107662] by commit-queue@webkit.org
  • 6 edits in trunk

[GTK] Mutation Observers build is broken
​https://bugs.webkit.org/show_bug.cgi?id=78433

Patch by ChangSeok Oh <ChangSeok Oh> on 2012-02-13
Reviewed by Martin Robinson.

Source/WebCore:

Added some files missed.

No new tests since no new feature.

  • GNUmakefile.list.am:

Tools:

Enabled mutation observers as a default feature for GTK port, too.

  • Scripts/build-webkit:

LayoutTests:

Removed fast/mutation, but added following 3 tests which are needed more time to pass.

GTK port DRT doesn't support some APIs like scheduleAsynchronousKeyDown.
I opened a new bug to deal with it. ​http://webkit.org/b/78481
And also see ​http://webkit.org/b/78290
fast/mutation/end-of-task-delivery.html
fast/mutation/inline-event-listener.html

Needed to enable FileSystem API at the same time.
fast/mutation/filesystem-callback-delivery.html

  • platform/gtk/Skipped:
7:49 PM WebKitIDL edited by haraken@chromium.org
(diff)
7:15 PM Changeset in webkit [107661] by hayato@chromium.org
  • 23 edits in trunk

Make ShadowRoot.nodeType return DOCUMENT_FRAGMENT_NODE.
​https://bugs.webkit.org/show_bug.cgi?id=77514

Reviewed by Dimitri Glazkov.

NodeType.SHADOW_ROOT_NODE type is finally gone.

Source/WebCore:

  • bindings/js/JSNodeCustom.cpp:

(WebCore::createWrapperInline):

  • bindings/objc/DOM.mm:

(kitClass):

  • bindings/v8/custom/V8NodeCustom.cpp:

(WebCore::toV8Slow):

  • dom/ContainerNode.cpp:

(WebCore::collectTargetNodes):
(WebCore::ContainerNode::replaceChild):

  • dom/Document.cpp:

(WebCore::Document::importNode):
(WebCore::Document::childTypeAllowed):
(WebCore::Document::canReplaceChild):

  • dom/Node.cpp:

(WebCore::Node::dumpStatistics):
(WebCore::Node::isDefaultNamespace):
(WebCore::Node::lookupPrefix):
(WebCore::Node::lookupNamespaceURI):
(WebCore::appendTextContent):
(WebCore::Node::setTextContent):

  • dom/Node.h:
  • dom/Range.cpp:

(WebCore::lengthOfContentsInNode):
(WebCore::Range::processContentsBetweenOffsets):
(WebCore::Range::insertNode):
(WebCore::Range::checkNodeWOffset):
(WebCore::Range::checkNodeBA):
(WebCore::Range::selectNode):
(WebCore::Range::selectNodeContents):
(WebCore::Range::surroundContents):

  • dom/ShadowRoot.cpp:
  • dom/ShadowRoot.h:

(ShadowRoot):
(WebCore::toShadowRoot):

  • editing/FrameSelection.cpp:

(WebCore::nodeIsDetachedFromDocument):
(WebCore):
(WebCore::FrameSelection::textWillBeReplaced):

  • editing/MarkupAccumulator.cpp:

(WebCore::MarkupAccumulator::appendStartMarkup):

  • html/parser/HTMLElementStack.cpp:

(WebCore::HTMLNames::isRootNode):
(WebCore::HTMLElementStack::pushRootNode):

  • html/parser/HTMLElementStack.h:

(WebCore::isInHTMLNamespace):

  • inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::pushChildNodesToFrontend):
(WebCore::InspectorDOMAgent::buildObjectForNode):

  • xml/XPathUtil.cpp:

(WebCore::XPath::isValidContextNode):

Source/WebKit/chromium:

  • src/WebPageSerializerImpl.cpp:

(WebKit::WebPageSerializerImpl::buildContentForNode):

LayoutTests:

  • fast/dom/shadow/nodetype-expected.txt:
  • fast/dom/shadow/nodetype.html:
  • resources/dump-as-markup.js:

(Markup._get):

6:50 PM Changeset in webkit [107660] by tony@chromium.org
  • 2 edits
    3 adds in trunk/LayoutTests

[chromium] Unreviewed gardening. Small cleanup after r107638.

  • platform/chromium-mac-leopard/css3/filters/crash-hw-sw-switch-expected.png: Added.
  • platform/chromium-mac-leopard/css3/filters/filter-empty-element-crash-expected.png: Added.
  • platform/chromium-mac-snowleopard/css3/filters/crash-hw-sw-switch-expected.png: Added.
  • platform/chromium/test_expectations.txt:
6:40 PM Changeset in webkit [107659] by ojan@chromium.org
  • 5 edits
    4 adds in trunk

Source/JavaScriptCore: Replace old strtod with new strtod
​https://bugs.webkit.org/show_bug.cgi?id=68044

Patch by Mark Hahnenberg <​mhahnenberg@apple.com> on 2012-02-12
Reviewed by Geoffrey Garen.

  • parser/Lexer.cpp: Added template argument. This version allows junk after numbers.

(JSC::::lex):

  • runtime/JSGlobalObjectFunctions.cpp: Ditto.

(JSC::parseInt):
(JSC::jsStrDecimalLiteral):

  • runtime/LiteralParser.cpp: Ditto.

(JSC::::Lexer::lexNumber):

  • wtf/dtoa.cpp: Replaced old strtod with a new version that uses the new StringToDoubleConverter.

It takes a template argument to allow clients to determine statically whether it should allow
junk after the numbers or not.
(WTF):
(WTF::strtod):

  • wtf/dtoa.h:

(WTF):

  • wtf/text/WTFString.cpp: Added template argument. This version does not allow junk after numbers.

(WTF::toDoubleType):

Source/WebCore: rtl + flex-direction:column is positioning elements incorrectly
​https://bugs.webkit.org/show_bug.cgi?id=78555

Reviewed by Tony Chang.

Do the y-axis flipping after we have adjusted the y-position for
flex-align instead of before.

Tests: css3/flexbox/flex-align-baseline.html

css3/flexbox/flex-align-end.html

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::alignChildren):
The amount we adjust by also needs to be flipped for rtl+column,
so the flipping needs to be done after we align the flex items.

LayoutTests: rtl + flex-direction:column is positioning elements incorrectly
​https://bugs.webkit.org/show_bug.cgi?id=78555

Reviewed by Tony Chang.

  • css3/flexbox/flex-align-baseline-expected.txt: Added.
  • css3/flexbox/flex-align-baseline.html: Added.
  • css3/flexbox/flex-align-end-expected.txt: Added.
  • css3/flexbox/flex-align-end.html: Added.
  • css3/flexbox/true-centering-expected.txt:
6:39 PM Changeset in webkit [107658] by bashi@chromium.org
  • 2 edits
    14 adds in trunk/LayoutTests

Unreviewed test expectations update.
Rebaselining font-face-synthetic-bold-italic.html and font-face-weight-matching.html.

  • platform/chromium-linux/fast/css/font-face-synthetic-bold-italic-expected.png: Added.
  • platform/chromium-linux/fast/css/font-face-synthetic-bold-italic-expected.txt: Added.
  • platform/chromium-linux/fast/css/font-face-weight-matching-expected.png: Added.
  • platform/chromium-linux/fast/css/font-face-weight-matching-expected.txt: Added.
  • platform/chromium-mac-leopard/fast/css/font-face-synthetic-bold-italic-expected.png: Added.
  • platform/chromium-mac-leopard/fast/css/font-face-weight-matching-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/css/font-face-synthetic-bold-italic-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/css/font-face-synthetic-bold-italic-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/css/font-face-weight-matching-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/css/font-face-weight-matching-expected.txt: Added.
  • platform/chromium-win/fast/css/font-face-synthetic-bold-italic-expected.png: Added.
  • platform/chromium-win/fast/css/font-face-synthetic-bold-italic-expected.txt: Added.
  • platform/chromium-win/fast/css/font-face-weight-matching-expected.png: Added.
  • platform/chromium-win/fast/css/font-face-weight-matching-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
6:36 PM Changeset in webkit [107657] by andersca@apple.com
  • 5 edits in trunk/Source/WebCore

The tile cache layer should have its background set to the page background
​https://bugs.webkit.org/show_bug.cgi?id=78560
<rdar://problem/10857472>

Reviewed by Sam Weinig.

  • page/FrameView.cpp:

(WebCore::FrameView::recalculateScrollbarOverlayStyle):
Inform the RenderLayerCompositor that the background color has changed.

  • platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::updateLayerBackgroundColor):
For tile cache layers we don't need a separate contents layer for the background color so
just set the background color on the layer directly.

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::documentBackgroundColorDidChange):
If the root render layer is using a tile cache layer, update its background color.

6:24 PM Changeset in webkit [107656] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

Allow to configure ENABLE_FTPDIR in build-webkit
​https://bugs.webkit.org/show_bug.cgi?id=65098

Patch by Loïc Yhuel <​loic.yhuel_ext@softathome.com> on 2012-02-13
Reviewed by Eric Seidel.

Allow to disable ENABLE_FTPDIR by command line.
Remove ENABLE_FTPDIR from --minimal build

  • Scripts/build-webkit: Add entries for ENABLE_FTPDIR (enabled by default)
  • qmake/mkspecs/features/features.prf: ENABLE_FTPDIR must be set to match Platform.h,

as, for Qt platform, build-webkit does not add on command line what it thinks to be default values

6:21 PM Changeset in webkit [107655] by shinyak@chromium.org
  • 2 edits in trunk/Tools

Add shinyak as committer

6:17 PM Changeset in webkit [107654] by eae@chromium.org
  • 6 edits in branches/subpixellayout/Source/WebCore

Remove explicit AppUnit::toFloat calls in places where it is not needed.

6:10 PM Changeset in webkit [107653] by abarth@webkit.org
  • 4 edits in trunk/Tools

Implement start/stop_helper for ChromiumAndroidPort
​https://bugs.webkit.org/show_bug.cgi?id=78558

Reviewed by Dirk Pranke.

These functions (and their dependencies) set up the Android device for
testing.

This patch also includes a few tweaks on the previous patch recommended
by dpranke.

  • Scripts/webkitpy/layout_tests/port/chromium_android.py:

(ChromiumAndroidPort.init):
(ChromiumAndroidPort.start_helper):
(ChromiumAndroidPort.stop_helper):
(ChromiumAndroidPort._shut_down_http_server):
(ChromiumAndroidPort):
(ChromiumAndroidPort._push_executable):
(ChromiumAndroidPort._push_fonts):
(ChromiumAndroidPort._restore_system_font):
(ChromiumAndroidPort._push_test_resources):
(ChromiumAndroidPort._push_to_device):
(ChromiumAndroidPort._pull_from_device):
(ChromiumAndroidPort._kill_device_process):
(ChromiumAndroidPort._setup_performance):
(ChromiumAndroidPort._teardown_performance):

  • Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:

(ChromiumAndroidPortTest):

  • Scripts/webkitpy/layout_tests/port/port_testcase.py:

(PortTestCase):
(PortTestCase.make_port):
(PortTestCase.test_default_worker_model):

5:40 PM Changeset in webkit [107652] by benjamin@webkit.org
  • 2 edits in trunk/Source/WebCore

Implement Element.webkitRegionOverflow

[CSSRegions][CSSOM] Implement Element.regionOverflow
​https://bugs.webkit.org/show_bug.cgi?id=77863

Patch by Raul Hudea <​rhudea@adobe.com> on 2012-02-13
Reviewed by David Hyatt.

On each layout, compute the overflowState for each region belonging to the flow thread

Tests: fast/regions/element-region-overflow-state-vertical-rl.html

fast/regions/element-region-overflow-state.html

  • dom/Element.cpp:

(WebCore::Element::webkitRegionOverflow):
(WebCore):

  • dom/Element.h:
  • dom/Element.idl:
  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::computeOverflow):

  • rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::computeOverflowStateForRegions):
(WebCore):

  • rendering/RenderFlowThread.h:
  • rendering/RenderRegion.cpp:

(WebCore::RenderRegion::RenderRegion):

  • rendering/RenderRegion.h:

(RenderRegion):
(WebCore::RenderRegion::regionState):
(WebCore::RenderRegion::setRegionState):

5:37 PM Changeset in webkit [107651] by mhahnenberg@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

More windows build fixing

5:34 PM Changeset in webkit [107650] by commit-queue@webkit.org
  • 10 edits
    4 adds in trunk

Implement Element.webkitRegionOverflow

[CSSRegions][CSSOM] Implement Element.regionOverflow
​https://bugs.webkit.org/show_bug.cgi?id=77863

Patch by Raul Hudea <​rhudea@adobe.com> on 2012-02-13
Reviewed by David Hyatt.

Source/WebCore:

On each layout, compute the overflowState for each region belonging to the flow thread

Tests: fast/regions/element-region-overflow-state-vertical-rl.html

fast/regions/element-region-overflow-state.html

  • dom/Element.cpp:

(WebCore::Element::webkitRegionOverflow):
(WebCore):

  • dom/Element.h:
  • dom/Element.idl:
  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::computeOverflow):

  • rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::computeOverflowStateForRegions):
(WebCore):

  • rendering/RenderFlowThread.h:
  • rendering/RenderRegion.cpp:

(WebCore::RenderRegion::RenderRegion):

  • rendering/RenderRegion.h:

(RenderRegion):
(WebCore::RenderRegion::regionState):
(WebCore::RenderRegion::setRegionState):

LayoutTests:

  • fast/regions/element-region-overflow-state-expected.txt: Added.
  • fast/regions/element-region-overflow-state-vertical-rl-expected.txt: Added.
  • fast/regions/element-region-overflow-state-vertical-rl.html: Added.
  • fast/regions/element-region-overflow-state.html: Added.
5:32 PM Changeset in webkit [107649] by ap@apple.com
  • 2 edits in trunk/Source/WebCore

File API IDLs are incorrect in Xcode project
​https://bugs.webkit.org/show_bug.cgi?id=78551

Rubber-stamped by Dan Bernstein.

  • WebCore.xcodeproj/project.pbxproj: Corrected paths, and added missing files.
5:27 PM Changeset in webkit [107648] by benjamin@webkit.org
  • 4 edits in trunk/Source/WebCore

SharedBuffer::getSomeData() must support m_dataArray if NETWORK_CFDATA_ARRAY_CALLBACK is defined
​https://bugs.webkit.org/show_bug.cgi?id=77718

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2012-02-13
Reviewed by David Kilzer.

Previously, the last part of SharedBuffer::getSomeData() was systematically accessing
the data from the segments. When NETWORK_CFDATA_ARRAY_CALLBACK is defined, there can
be data in m_dataArray past the segment.

The previous code was making invalid memory access pass the segment vector. This patch
adds support for getting the data out of m_dataArray to make SharedBuffer::getSomeData()
works with NETWORK_CFDATA_ARRAY_CALLBACK.

This is covered by existing tests when NETWORK_CFDATA_ARRAY_CALLBACK is defined.
The test 'fast/events/constructors/track-event-constructor.html' is a reliable test
for this.

  • platform/SharedBuffer.cpp:

(WebCore::SharedBuffer::getSomeData):

  • platform/SharedBuffer.h:

(SharedBuffer):

  • platform/cf/SharedBufferCF.cpp:

(WebCore):
(WebCore::SharedBuffer::copySomeDataFromDataArray):

5:10 PM Changeset in webkit [107647] by oliver@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Executing out of bounds in JSC::Yarr::YarrCodeBlock::execute / JSC::RegExp::match
​https://bugs.webkit.org/show_bug.cgi?id=76315

Reviewed by Gavin Barraclough.

Perform a 3 byte compare using two comparisons, rather than trying to perform the
operation with a four byte load.

  • yarr/YarrJIT.cpp:

(JSC::Yarr::YarrGenerator::generatePatternCharacterOnce):

5:07 PM Changeset in webkit [107646] by andersca@apple.com
  • 5 edits in trunk/Source/WebCore

Force slow-scrolling mode when there are position:fixed elements on a page
​https://bugs.webkit.org/show_bug.cgi?id=78553
<rdar://problem/10247934>

Reviewed by Dan Bernstein.

Eventually, the scrolling tree will know about fixed positioning layers so their position can be updated
when the scroll layer position is updated. For now we'll take the simple route however.

  • page/FrameView.cpp:

(WebCore::FrameView::addFixedObject):
(WebCore::FrameView::removeFixedObject):
Inform the scrolling coordinator when the number of fixed objects changes between 0 and 1.

  • page/FrameView.h:

(WebCore::FrameView::hasFixedObjects):
Make this public.

  • page/scrolling/ScrollingCoordinator.cpp:

(WebCore::ScrollingCoordinator::frameViewHasSlowRepaintObjectsDidChange):
Call updateShouldUpdateScrollLayerPositionOnMainThread.

(WebCore::ScrollingCoordinator::frameViewHasFixedObjectsDidChange):
Call updateShouldUpdateScrollLayerPositionOnMainThread.

(WebCore::ScrollingCoordinator::updateMainFrameScrollPositionAndScrollLayerPosition):
Make sure to update compositing layers here. Normally, they will be updated by layout but doing a layout
here is too intrusive since it could potentially change the size of the page.

(WebCore::ScrollingCoordinator::updateShouldUpdateScrollLayerPositionOnMainThread):
If we have fixed objects or slow repaint objects we need to update the scroll layer position on the main thread.

5:07 PM Changeset in webkit [107645] by enne@google.com
  • 5 edits in trunk/Source/WebCore

[chromium] Use HashMap<..., OwnPtr<Tile>> for compositor tilemap
​https://bugs.webkit.org/show_bug.cgi?id=74154

Reviewed by James Robinson.

Covered by the compositing/ layout tests.

  • platform/graphics/chromium/TiledLayerChromium.cpp:

(WebCore::UpdatableTile::create):
(WebCore::UpdatableTile::UpdatableTile):
(WebCore::TiledLayerChromium::createTile):

  • platform/graphics/chromium/cc/CCLayerTilingData.cpp:

(WebCore::CCLayerTilingData::addTile):
(WebCore::CCLayerTilingData::takeTile):
(WebCore::CCLayerTilingData::tileAt):

  • platform/graphics/chromium/cc/CCLayerTilingData.h:
  • platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:

(WebCore::DrawableTile::create):
(WebCore::DrawableTile::DrawableTile):
(WebCore::CCTiledLayerImpl::createTile):

4:59 PM Changeset in webkit [107644] by Lucas Forschler
  • 5 edits in branches/safari-534.54-branch/Source

Versioning.

4:57 PM Changeset in webkit [107643] by tony@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Unreviewed, removing some tests that have been passing
as far back as the flakiness dashboard's history goes.

  • platform/chromium/test_expectations.txt:
4:56 PM Changeset in webkit [107642] by mhahnenberg@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Windows build fix

4:55 PM Changeset in webkit [107641] by Lucas Forschler
  • 1 copy in tags/Safari-534.54.15

New tag.

4:53 PM Changeset in webkit [107640] by leviw@chromium.org
  • 5 edits in branches/subpixellayout/Source/WebCore/rendering

Converting drawLineForBoxSide to operate on integers (which makes sense). This mostly entails fixing the callers to use pixel snapping.

4:53 PM Changeset in webkit [107639] by jsbell@chromium.org
  • 3 edits
    2 copies in branches/chromium/1025

Merge 107278 - [Chromium] IndexedDB: IDBVersionChangeRequest V8 wrapper not generated as ActiveDOMObject
​https://bugs.webkit.org/show_bug.cgi?id=78167

Source/WebCore:

Add ActiveDOMObject annotation to IDBVersionChangeRequest.idl; it is not
automagically inherited from IDBRequest.idl.

Reviewed by Adam Barth.

Test: storage/indexeddb/versionchangerequest-activedomobject.html

  • storage/IDBVersionChangeRequest.idl:

LayoutTests:

Reviewed by Adam Barth.

  • storage/indexeddb/versionchangerequest-activedomobject-expected.txt: Added.
  • storage/indexeddb/versionchangerequest-activedomobject.html: Added.

TBR=​jsbell@chromium.org
Review URL: ​https://chromiumcodereview.appspot.com/9390031

4:48 PM Changeset in webkit [107638] by senorblanco@chromium.org
  • 2 edits
    154 adds
    8 deletes in trunk/LayoutTests

[chromium] New baselines for css3/filters tests (unreviewed).

  • platform/chromium-linux/css3/filters: Added.
  • platform/chromium-linux/css3/filters/crash-hw-sw-switch-expected.png: Added.
  • platform/chromium-linux/css3/filters/effect-blur-hw-expected.png: Added.
  • platform/chromium-linux/css3/filters/effect-brightness-expected.png: Added.
  • platform/chromium-linux/css3/filters/effect-brightness-hw-expected.png: Added.
  • platform/chromium-linux/css3/filters/effect-combined-hw-expected.png: Added.
  • platform/chromium-linux/css3/filters/effect-contrast-hw-expected.png: Added.
  • platform/chromium-linux/css3/filters/effect-saturate-hw-expected.png: Added.
  • platform/chromium-linux/css3/filters/effect-sepia-hw-expected.png: Added.
  • platform/chromium-linux/css3/filters/filter-empty-element-crash-expected.png: Added.
  • platform/chromium-linux/css3/filters/filter-with-transform-expected.png: Added.
  • platform/chromium-linux/css3/filters/nested-filter-expected.png: Added.
  • platform/chromium-mac-leopard/css3/filters: Added.
  • platform/chromium-mac-leopard/css3/filters/crash-filter-change-expected.png: Added.
  • platform/chromium-mac-leopard/css3/filters/effect-blur-expected.png: Added.
  • platform/chromium-mac-leopard/css3/filters/effect-blur-hw-expected.png: Added.
  • platform/chromium-mac-leopard/css3/filters/effect-brightness-expected.png: Added.
  • platform/chromium-mac-leopard/css3/filters/effect-brightness-hw-expected.png: Added.
  • platform/chromium-mac-leopard/css3/filters/effect-combined-expected.png: Added.
  • platform/chromium-mac-leopard/css3/filters/effect-combined-hw-expected.png: Added.
  • platform/chromium-mac-leopard/css3/filters/effect-contrast-expected.png: Added.
  • platform/chromium-mac-leopard/css3/filters/effect-contrast-hw-expected.png: Added.
  • platform/chromium-mac-leopard/css3/filters/effect-custom-combined-missing-expected.png: Added.
  • platform/chromium-mac-leopard/css3/filters/effect-custom-expected.png: Added.
  • platform/chromium-mac-leopard/css3/filters/effect-custom-parameters-expected.png: Added.
  • platform/chromium-mac-leopard/css3/filters/effect-drop-shadow-expected.png: Added.
  • platform/chromium-mac-leopard/css3/filters/effect-drop-shadow-hw-expected.png: Added.
  • platform/chromium-mac-leopard/css3/filters/effect-grayscale-expected.png: Added.
  • platform/chromium-mac-leopard/css3/filters/effect-grayscale-hw-expected.png: Added.
  • platform/chromium-mac-leopard/css3/filters/effect-hue-rotate-expected.png: Added.
  • platform/chromium-mac-leopard/css3/filters/effect-hue-rotate-hw-expected.png: Added.
  • platform/chromium-mac-leopard/css3/filters/effect-invert-expected.png: Added.
  • platform/chromium-mac-leopard/css3/filters/effect-invert-hw-expected.png: Added.
  • platform/chromium-mac-leopard/css3/filters/effect-opacity-expected.png: Added.
  • platform/chromium-mac-leopard/css3/filters/effect-opacity-hw-expected.png: Added.
  • platform/chromium-mac-leopard/css3/filters/effect-saturate-expected.png: Added.
  • platform/chromium-mac-leopard/css3/filters/effect-saturate-hw-expected.png: Added.
  • platform/chromium-mac-leopard/css3/filters/effect-sepia-expected.png: Added.
  • platform/chromium-mac-leopard/css3/filters/effect-sepia-hw-expected.png: Added.
  • platform/chromium-mac-leopard/css3/filters/regions-expanding-expected.png: Added.
  • platform/chromium-mac-snowleopard/css3/filters: Added.
  • platform/chromium-mac-snowleopard/css3/filters/add-filter-rendering-expected.png: Added.
  • platform/chromium-mac-snowleopard/css3/filters/crash-filter-change-expected.png: Added.
  • platform/chromium-mac-snowleopard/css3/filters/effect-blur-expected.png: Added.
  • platform/chromium-mac-snowleopard/css3/filters/effect-blur-expected.txt: Added.
  • platform/chromium-mac-snowleopard/css3/filters/effect-blur-hw-expected.png: Added.
  • platform/chromium-mac-snowleopard/css3/filters/effect-brightness-expected.png: Added.
  • platform/chromium-mac-snowleopard/css3/filters/effect-brightness-expected.txt: Added.
  • platform/chromium-mac-snowleopard/css3/filters/effect-brightness-hw-expected.png: Added.
  • platform/chromium-mac-snowleopard/css3/filters/effect-combined-expected.png: Added.
  • platform/chromium-mac-snowleopard/css3/filters/effect-combined-expected.txt: Added.
  • platform/chromium-mac-snowleopard/css3/filters/effect-combined-hw-expected.png: Added.
  • platform/chromium-mac-snowleopard/css3/filters/effect-contrast-expected.png: Added.
  • platform/chromium-mac-snowleopard/css3/filters/effect-contrast-expected.txt: Added.
  • platform/chromium-mac-snowleopard/css3/filters/effect-contrast-hw-expected.png: Added.
  • platform/chromium-mac-snowleopard/css3/filters/effect-custom-combined-missing-expected.png: Added.
  • platform/chromium-mac-snowleopard/css3/filters/effect-drop-shadow-expected.png: Added.
  • platform/chromium-mac-snowleopard/css3/filters/effect-drop-shadow-expected.txt: Added.
  • platform/chromium-mac-snowleopard/css3/filters/effect-drop-shadow-hw-expected.png: Added.
  • platform/chromium-mac-snowleopard/css3/filters/effect-grayscale-expected.png: Added.
  • platform/chromium-mac-snowleopard/css3/filters/effect-grayscale-expected.txt: Added.
  • platform/chromium-mac-snowleopard/css3/filters/effect-grayscale-hw-expected.png: Added.
  • platform/chromium-mac-snowleopard/css3/filters/effect-hue-rotate-expected.png: Added.
  • platform/chromium-mac-snowleopard/css3/filters/effect-hue-rotate-expected.txt: Added.
  • platform/chromium-mac-snowleopard/css3/filters/effect-hue-rotate-hw-expected.png: Added.
  • platform/chromium-mac-snowleopard/css3/filters/effect-invert-expected.png: Added.
  • platform/chromium-mac-snowleopard/css3/filters/effect-invert-expected.txt: Added.
  • platform/chromium-mac-snowleopard/css3/filters/effect-invert-hw-expected.png: Added.
  • platform/chromium-mac-snowleopard/css3/filters/effect-opacity-expected.png: Added.
  • platform/chromium-mac-snowleopard/css3/filters/effect-opacity-expected.txt: Added.
  • platform/chromium-mac-snowleopard/css3/filters/effect-opacity-hw-expected.png: Added.
  • platform/chromium-mac-snowleopard/css3/filters/effect-saturate-expected.png: Added.
  • platform/chromium-mac-snowleopard/css3/filters/effect-saturate-expected.txt: Added.
  • platform/chromium-mac-snowleopard/css3/filters/effect-saturate-hw-expected.png: Added.
  • platform/chromium-mac-snowleopard/css3/filters/effect-sepia-expected.png: Added.
  • platform/chromium-mac-snowleopard/css3/filters/effect-sepia-expected.txt: Added.
  • platform/chromium-mac-snowleopard/css3/filters/effect-sepia-hw-expected.png: Added.
  • platform/chromium-mac-snowleopard/css3/filters/filter-repaint-expected.png: Added.
  • platform/chromium-mac-snowleopard/css3/filters/filter-with-transform-expected.png: Added.
  • platform/chromium-mac-snowleopard/css3/filters/filtered-compositing-descendant-expected.png: Added.
  • platform/chromium-mac-snowleopard/css3/filters/filtered-inline-expected.png: Added.
  • platform/chromium-mac-snowleopard/css3/filters/nested-filter-expected.png: Added.
  • platform/chromium-mac-snowleopard/css3/filters/nested-filters-expected.png: Added.
  • platform/chromium-mac-snowleopard/css3/filters/regions-expanding-expected.png: Added.
  • platform/chromium-mac-snowleopard/css3/filters/simple-filter-rendering-expected.png: Added.
  • platform/chromium-win/css3/filters: Added.
  • platform/chromium-win/css3/filters/add-filter-rendering-expected.png: Added.
  • platform/chromium-win/css3/filters/crash-filter-change-expected.png: Added.
  • platform/chromium-win/css3/filters/effect-blur-expected.png: Added.
  • platform/chromium-win/css3/filters/effect-blur-expected.txt: Added.
  • platform/chromium-win/css3/filters/effect-blur-hw-expected.png: Added.
  • platform/chromium-win/css3/filters/effect-blur-hw-expected.txt: Added.
  • platform/chromium-win/css3/filters/effect-brightness-expected.png: Added.
  • platform/chromium-win/css3/filters/effect-brightness-expected.txt: Added.
  • platform/chromium-win/css3/filters/effect-brightness-hw-expected.png: Added.
  • platform/chromium-win/css3/filters/effect-brightness-hw-expected.txt: Added.
  • platform/chromium-win/css3/filters/effect-combined-expected.png: Added.
  • platform/chromium-win/css3/filters/effect-combined-expected.txt: Added.
  • platform/chromium-win/css3/filters/effect-combined-hw-expected.png: Added.
  • platform/chromium-win/css3/filters/effect-combined-hw-expected.txt: Added.
  • platform/chromium-win/css3/filters/effect-contrast-expected.png: Added.
  • platform/chromium-win/css3/filters/effect-contrast-expected.txt: Added.
  • platform/chromium-win/css3/filters/effect-contrast-hw-expected.png: Added.
  • platform/chromium-win/css3/filters/effect-contrast-hw-expected.txt: Added.
  • platform/chromium-win/css3/filters/effect-custom-combined-missing-expected.png: Added.
  • platform/chromium-win/css3/filters/effect-custom-expected.png: Added.
  • platform/chromium-win/css3/filters/effect-custom-parameters-expected.png: Added.
  • platform/chromium-win/css3/filters/effect-drop-shadow-expected.png: Added.
  • platform/chromium-win/css3/filters/effect-drop-shadow-expected.txt: Added.
  • platform/chromium-win/css3/filters/effect-drop-shadow-hw-expected.png: Added.
  • platform/chromium-win/css3/filters/effect-drop-shadow-hw-expected.txt: Added.
  • platform/chromium-win/css3/filters/effect-grayscale-expected.png: Added.
  • platform/chromium-win/css3/filters/effect-grayscale-expected.txt: Added.
  • platform/chromium-win/css3/filters/effect-grayscale-hw-expected.png: Added.
  • platform/chromium-win/css3/filters/effect-grayscale-hw-expected.txt: Added.
  • platform/chromium-win/css3/filters/effect-hue-rotate-expected.png: Added.
  • platform/chromium-win/css3/filters/effect-hue-rotate-expected.txt: Added.
  • platform/chromium-win/css3/filters/effect-hue-rotate-hw-expected.png: Added.
  • platform/chromium-win/css3/filters/effect-hue-rotate-hw-expected.txt: Added.
  • platform/chromium-win/css3/filters/effect-invert-expected.png: Added.
  • platform/chromium-win/css3/filters/effect-invert-expected.txt: Added.
  • platform/chromium-win/css3/filters/effect-invert-hw-expected.png: Added.
  • platform/chromium-win/css3/filters/effect-invert-hw-expected.txt: Added.
  • platform/chromium-win/css3/filters/effect-opacity-expected.png: Added.
  • platform/chromium-win/css3/filters/effect-opacity-expected.txt: Added.
  • platform/chromium-win/css3/filters/effect-opacity-hw-expected.png: Added.
  • platform/chromium-win/css3/filters/effect-opacity-hw-expected.txt: Added.
  • platform/chromium-win/css3/filters/effect-saturate-expected.png: Added.
  • platform/chromium-win/css3/filters/effect-saturate-expected.txt: Added.
  • platform/chromium-win/css3/filters/effect-saturate-hw-expected.png: Added.
  • platform/chromium-win/css3/filters/effect-saturate-hw-expected.txt: Added.
  • platform/chromium-win/css3/filters/effect-sepia-expected.png: Added.
  • platform/chromium-win/css3/filters/effect-sepia-expected.txt: Added.
  • platform/chromium-win/css3/filters/effect-sepia-hw-expected.png: Added.
  • platform/chromium-win/css3/filters/effect-sepia-hw-expected.txt: Added.
  • platform/chromium-win/css3/filters/filter-region-expected.png: Added.
  • platform/chromium-win/css3/filters/filter-repaint-expected.png: Added.
  • platform/chromium-win/css3/filters/filter-with-transform-expected.png: Added.
  • platform/chromium-win/css3/filters/filtered-compositing-descendant-expected.png: Added.
  • platform/chromium-win/css3/filters/filtered-compositing-descendant-expected.txt: Added.
  • platform/chromium-win/css3/filters/filtered-inline-expected.png: Added.
  • platform/chromium-win/css3/filters/nested-filter-expected.png: Added.
  • platform/chromium-win/css3/filters/nested-filters-expected.png: Added.
  • platform/chromium-win/css3/filters/regions-expanding-expected.png: Added.
  • platform/chromium-win/css3/filters/regions-expanding-expected.txt: Added.
  • platform/chromium-win/css3/filters/simple-filter-rendering-expected.png: Added.
  • platform/chromium/css3/filters: Added.
  • platform/chromium/css3/filters/effect-custom-combined-missing-expected.txt: Added.
  • platform/chromium/css3/filters/effect-custom-disabled-expected.txt: Added.
  • platform/chromium/css3/filters/effect-custom-expected.txt: Added.
  • platform/chromium/css3/filters/effect-custom-parameters-expected.txt: Added.
  • platform/chromium/css3/filters/filter-property-computed-style-expected.txt: Added.
  • platform/chromium/css3/filters/filter-property-parsing-expected.txt: Added.
  • platform/chromium/css3/filters/filter-repaint-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
  • platform/qt/css3/filters/add-filter-rendering-expected.txt: Removed.
  • platform/qt/css3/filters/crash-filter-change-expected.txt: Removed.
  • platform/qt/css3/filters/filter-region-expected.txt: Removed.
  • platform/qt/css3/filters/filter-with-transform-expected.txt: Removed.
  • platform/qt/css3/filters/filtered-inline-expected.txt: Removed.
  • platform/qt/css3/filters/nested-filter-expected.txt: Removed.
  • platform/qt/css3/filters/nested-filters-expected.txt: Removed.
  • platform/qt/css3/filters/simple-filter-rendering-expected.txt: Removed.
4:48 PM Changeset in webkit [107637] by abarth@webkit.org
  • 4 edits in trunk/Tools

Implement enough of ChromiumAndroidPort to make ChromiumAndroidPortTest pass
​https://bugs.webkit.org/show_bug.cgi?id=78550

Reviewed by Eric Seidel.

Much of this code just forwards to the "host" port, which seems like a
reasonable thing to do.

  • Scripts/webkitpy/layout_tests/port/chromium_android.py:

(ChromiumAndroidPort.init):
(ChromiumAndroidPort.stop_helper):
(ChromiumAndroidPort):
(ChromiumAndroidPort._build_path):
(ChromiumAndroidPort._path_to_apache):
(ChromiumAndroidPort._path_to_apache_config_file):
(ChromiumAndroidPort._path_to_driver):
(ChromiumAndroidPort._path_to_helper):
(ChromiumAndroidPort._path_to_image_diff):
(ChromiumAndroidPort._path_to_lighttpd):
(ChromiumAndroidPort._path_to_lighttpd_modules):
(ChromiumAndroidPort._path_to_lighttpd_php):
(ChromiumAndroidPort._path_to_wdiff):
(ChromiumAndroidPort._shut_down_http_server):

  • Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:

(ChromiumAndroidPortTest):

  • Scripts/webkitpy/layout_tests/port/port_testcase.py:

(PortTestCase):
(PortTestCase.make_port):
(PortTestCase.test_default_worker_model):

4:42 PM Changeset in webkit [107636] by haraken@chromium.org
  • 29 edits in trunk/Source/WebCore

Add [CustomToJSObject] to interfaces which have custom toJS() and toV8()
​https://bugs.webkit.org/show_bug.cgi?id=78489

Reviewed by Adam Barth.

This is the final step to remove hard-coding from HasCustomToV8Implementation()
in CodeGeneratorV8.pm. This patch replaces [JSCustomToJS] with [CustomToJSObject]
for interfaces which have custom toJS() and custom toV8().

No tests. No change in behavior.

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader):
(GenerateImplementation):

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateHeader):

  • bindings/scripts/test/TestTypedArray.idl:
  • css/CSSRule.idl:
  • css/CSSValue.idl:
  • css/StyleSheet.idl:
  • dom/Document.idl:
  • dom/Event.idl:
  • dom/Node.idl:
  • fileapi/Blob.idl:
  • fileapi/Entry.idl:
  • fileapi/EntrySync.idl:
  • html/HTMLCollection.idl:
  • html/ImageData.idl:
  • html/canvas/ArrayBufferView.idl:
  • html/canvas/DataView.idl:
  • html/canvas/Float32Array.idl:
  • html/canvas/Float64Array.idl:
  • html/canvas/Int16Array.idl:
  • html/canvas/Int32Array.idl:
  • html/canvas/Int8Array.idl:
  • html/canvas/Uint16Array.idl:
  • html/canvas/Uint32Array.idl:
  • html/canvas/Uint8Array.idl:
  • html/canvas/Uint8ClampedArray.idl:
  • storage/IDBAny.idl:
  • storage/IDBKey.idl:
  • svg/SVGPathSeg.idl:
4:27 PM Changeset in webkit [107635] by eae@chromium.org
  • 7 edits in branches/subpixellayout/Source/WebCore

Changed ScrollView::contentsWidth/Height to int avoiding unnecessary type conversions.

4:16 PM Changeset in webkit [107634] by abarth@webkit.org
  • 3 edits
    1 add in trunk/Tools

chromium_android.py should implement "virtual" methods from ChromiumPort
​https://bugs.webkit.org/show_bug.cgi?id=78545

Reviewed by Dirk Pranke.

This patch adds basic implementations that specialize a bunch of
functions from ChromiumPort.

  • Scripts/webkitpy/layout_tests/port/chromium_android.py:

(ChromiumAndroidPort):
(ChromiumAndroidPort.init):
(ChromiumAndroidPort.default_child_processes):
(ChromiumAndroidPort.baseline_search_path):
(ChromiumAndroidPort.check_build):
(ChromiumAndroidPort.check_sys_deps):
(ChromiumAndroidPort.default_worker_model):
(ChromiumAndroidPort.test_expectations):
(ChromiumAndroidPort.start_http_server):
(ChromiumAndroidPort.stop_http_server):
(ChromiumAndroidPort.start_helper):
(ChromiumAndroidPort.stop_helper):

4:09 PM Changeset in webkit [107633] by fischman@chromium.org
  • 6 edits
    1 delete in trunk/LayoutTests

[chromium] Unreviewed gardening. Rebaselining post skia change (from a long time ago).
​http://code.google.com/p/chromium/issues/detail?id=105305

  • platform/chromium-gpu-linux/media/audio-repaint-expected.png: Removed.
  • platform/chromium-linux/media/audio-repaint-expected.png:
  • platform/chromium-mac-leopard/media/audio-repaint-expected.png:
  • platform/chromium-mac-snowleopard/media/audio-repaint-expected.png:
  • platform/chromium-win/media/audio-repaint-expected.png:
  • platform/chromium/test_expectations.txt:
4:06 PM Changeset in webkit [107632] by commit-queue@webkit.org
  • 6 edits in trunk

Chrome crashes when attempting to add cue to track element
​https://bugs.webkit.org/show_bug.cgi?id=77951

Patch by Arun Patole <​bmf834@motorola.com> on 2012-02-13
Reviewed by Eric Carlson.

Source/WebCore:

Allocate text track's text track list of cues before using it.

  • html/TextTrack.cpp:

(WebCore::TextTrack::cues):
(WebCore::TextTrack::addCue):
(WebCore::TextTrack::removeCue): return if text track list of cues is not allocated.
(WebCore::TextTrack::ensureTextTrackCueList):Added.

  • html/TextTrack.h:

(TextTrack):

LayoutTests:

Updated add-remove-cue.html to handle adding a new cue to the text track created with addTextTrack.

  • media/track/track-add-remove-cue-expected.txt:
  • media/track/track-add-remove-cue.html:
3:57 PM Changeset in webkit [107631] by Lucas Forschler
  • 2 edits in branches/safari-534.54-branch/Source/WebKit2

Rollout 105763.

3:55 PM Changeset in webkit [107630] by bashi@chromium.org
  • 3 edits in trunk/LayoutTests

Fix font-face-weight-matching.html and font-face-synthetic-bold-italic.html
​https://bugs.webkit.org/show_bug.cgi?id=78492

Fix the URL of Ahem.ttf.

Reviewed by Eric Seidel.

  • fast/css/font-face-synthetic-bold-italic.html:
  • fast/css/font-face-weight-matching.html:
3:54 PM Changeset in webkit [107629] by aestes@apple.com
  • 2 edits in trunk/Source/WebCore

Fix the Windows build.

  • platform/PlatformPasteboard.h:

(PlatformPasteboard):

3:53 PM Changeset in webkit [107628] by Lucas Forschler
  • 3 edits
    3 copies in branches/safari-534.54-branch

Merged r107496.

3:46 PM Changeset in webkit [107627] by inferno@chromium.org
  • 3 edits
    2 adds in trunk

Crash with button in multi-column layout.
​https://bugs.webkit.org/show_bug.cgi?id=78378

Reviewed by David Hyatt.

Source/WebCore:

Button creates an anonymous wrapper and expects that new children
be added to its m_inner anonymous block. However, splitBlock code
incorrectly creates column blocks directly under the button.

Test: fast/multicol/span/split-flow-anonymous-wrapper-crash.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::containingColumnsBlock):
(WebCore::RenderBlock::columnsBlockForSpanningElement):

LayoutTests:

  • fast/multicol/span/split-flow-anonymous-wrapper-crash-expected.txt: Added.
  • fast/multicol/span/split-flow-anonymous-wrapper-crash.html: Added.
3:39 PM Changeset in webkit [107626] by aestes@apple.com
  • 3 edits in trunk/Source/WebKit/win

Fix the Windows build.

  • WebCoreSupport/WebPlatformStrategies.cpp:

(WebPlatformStrategies::createPasteboardStrategy):

  • WebCoreSupport/WebPlatformStrategies.h:

(WebPlatformStrategies):

3:38 PM Changeset in webkit [107625] by mhahnenberg@apple.com
  • 7 edits in trunk/Source/JavaScriptCore

Replace old strtod with new strtod
​https://bugs.webkit.org/show_bug.cgi?id=68044

Reviewed by Geoffrey Garen.

  • parser/Lexer.cpp: Added template argument. This version allows junk after numbers.

(JSC::::lex):

  • runtime/JSGlobalObjectFunctions.cpp: Ditto.

(JSC::parseInt):
(JSC::jsStrDecimalLiteral):

  • runtime/LiteralParser.cpp: Ditto.

(JSC::::Lexer::lexNumber):

  • wtf/dtoa.cpp: Replaced old strtod with a new version that uses the new StringToDoubleConverter.

It takes a template argument to allow clients to determine statically whether it should allow
junk after the numbers or not.
(WTF):
(WTF::strtod):

  • wtf/dtoa.h:

(WTF):

  • wtf/text/WTFString.cpp: Added template argument. This version does not allow junk after numbers.

(WTF::toDoubleType):

3:37 PM Changeset in webkit [107624] by ojan@chromium.org
  • 7 edits
    4 adds in trunk

nesting horizontal flexboxes is broken
​https://bugs.webkit.org/show_bug.cgi?id=76867

Reviewed by David Hyatt.

Source/WebCore:

This is copied from RenderDeprecatedFlexibleBox and updated
for RenderFlexibleBox and to handle vertical writing mode.

Tests: css3/flexbox/preferred-widths-orthogonal.html

css3/flexbox/preferred-widths.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::computePreferredLogicalWidths):

  • rendering/RenderFlexibleBox.cpp:

(WebCore::marginWidthForChild):
(WebCore):
(WebCore::RenderFlexibleBox::computePreferredLogicalWidths):

  • rendering/RenderFlexibleBox.h:

(RenderFlexibleBox):

LayoutTests:

  • css3/flexbox/floated-flexbox-expected.txt:
  • css3/flexbox/line-wrapping.html:

The old results here were wrong because they wrapped the contents of each flex item.

  • css3/flexbox/preferred-widths-expected.txt: Added.
  • css3/flexbox/preferred-widths-orthogonal-expected.txt: Added.
  • css3/flexbox/preferred-widths-orthogonal.html: Added.
  • css3/flexbox/preferred-widths.html: Added.
3:35 PM Changeset in webkit [107623] by Lucas Forschler
  • 4 edits in branches/safari-534.54-branch

Merge r106388.

3:28 PM Changeset in webkit [107622] by mihnea@adobe.com
  • 7 edits
    2 adds in trunk

Crash in RenderFlowThread::setRegionBoxesRegionStyle
​https://bugs.webkit.org/show_bug.cgi?id=78298

Reviewed by David Hyatt.

Source/WebCore:

Test: fast/regions/set-box-style-in-region-crash.html

We have to make sure that anonymous block objects get their information in RenderFlowThread
removed properly.

  • dom/Node.cpp:

(WebCore::Node::diff):
Correct a comment.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::collapseAnonymousBoxChild):
Remove the information for anonymous block from render flow thread.

  • rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::removeFlowChildInfo):
(WebCore):
(WebCore::RenderFlowThread::setRegionRangeForBox):
Do not set region range if the flow thread does not have regions.

  • rendering/RenderFlowThread.h:
  • rendering/RenderObject.cpp:

(WebCore::RenderObject::willBeDestroyed):
Add an assert to make sure that after we remove an object, there is no remaining info
in any render flow thread.

LayoutTests:

  • fast/regions/set-box-style-in-region-crash-expected.txt: Added.
  • fast/regions/set-box-style-in-region-crash.html: Added.
3:22 PM Changeset in webkit [107621] by tony@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Unreviewed, skip http/tests/navigation/https-in-page-cache.html
because we don't enable the page cache in chromium.

  • platform/chromium/test_expectations.txt:
3:17 PM Changeset in webkit [107620] by abarth@webkit.org
  • 4 edits
    1 add in trunk/Tools

Add a skeleton ChromiumAndroid port to webkitpy
​https://bugs.webkit.org/show_bug.cgi?id=78543

Reviewed by Eric Seidel.

This patch just adds an empty ChromiumAndroid port object to webkitpy
and wires it up to the factory objects. An actual implementation will
follow.

  • Scripts/webkitpy/layout_tests/port/chromium.py:

(ChromiumPort):

  • Scripts/webkitpy/layout_tests/port/chromium_android.py: Added.

(ChromiumAndroidPort):
(ChromiumAndroidPort.init):

  • Scripts/webkitpy/layout_tests/port/chromium_unittest.py:

(ChromiumPortTest.test_all_test_configurations):

  • Scripts/webkitpy/layout_tests/port/factory.py:

(PortFactory):

3:13 PM Changeset in webkit [107619] by tony@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Unreviewed, r107611 enabled layout tests in css3/filters,
but some are missing results.

  • platform/chromium/test_expectations.txt:
3:10 PM Changeset in webkit [107618] by thakis@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] Let WebKit::initialize call InitWebCoreSystemInterface on mac.
​https://bugs.webkit.org/show_bug.cgi?id=78246

This allows removing a bunch of code in chromium land (​https://chromiumcodereview.appspot.com/9374020/),
and helps with the component build on mac (InitWebCoreSystemInterface is not an
exported function, and it shouldn't be).

Source/WebKit/mac/WebCoreSupport/WebSystemInterface.mm early-returns when it's
called twice, so it's safe to land this change, and remove the calls in client
code in a later CL.

Reviewed by Darin Fisher.

  • src/WebKit.cpp:

(WebKit::initializeWithoutV8):

3:07 PM Changeset in webkit [107617] by tony@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Unreviewed gardening. We don't need to pass
platform/win/inverted-colors/non-composited.html.

  • platform/chromium/test_expectations.txt:
2:59 PM Changeset in webkit [107616] by fischman@chromium.org
  • 17 edits
    5 deletes in trunk/LayoutTests

[chromium] Unreviewed gardening. Rebaselining GPU results.

  • platform/chromium-gpu-linux/media/controls-after-reload-expected.png:
  • platform/chromium-gpu-linux/media/controls-strict-expected.png:
  • platform/chromium-gpu-linux/media/controls-styling-expected.png:
  • platform/chromium-gpu-linux/media/controls-without-preload-expected.png:
  • platform/chromium-gpu-linux/media/video-aspect-ratio-expected.png:
  • platform/chromium-gpu-linux/media/video-canvas-alpha-expected.png:
  • platform/chromium-gpu-linux/media/video-controls-rendering-expected.png:
  • platform/chromium-gpu-linux/media/video-display-toggle-expected.png:
  • platform/chromium-gpu-linux/media/video-layer-crash-expected.png:
  • platform/chromium-gpu-linux/media/video-playing-and-pause-expected.png:
  • platform/chromium-gpu-linux/media/video-transformed-expected.png:
  • platform/chromium-gpu-linux/media/video-volume-slider-expected.png:
  • platform/chromium-gpu-linux/media/video-zoom-controls-expected.png:
  • platform/chromium-gpu-linux/media/video-zoom-expected.png:
  • platform/chromium-gpu-mac/media/controls-after-reload-expected.txt: Removed.
  • platform/chromium-gpu-mac/media/video-controls-rendering-expected.png:
  • platform/chromium-gpu-mac/media/video-playing-and-pause-expected.txt: Removed.
  • platform/chromium-gpu-win/media/controls-strict-expected.txt: Removed.
  • platform/chromium-gpu-win/media/controls-styling-expected.txt: Removed.
  • platform/chromium-gpu-win/media/controls-without-preload-expected.txt: Removed.
  • platform/chromium-gpu-win/media/video-controls-rendering-expected.png:
2:55 PM Changeset in webkit [107615] by tony@chromium.org
  • 14 edits
    4 deletes in trunk

Unreviewed, rolling out r107582.
​http://trac.webkit.org/changeset/107582
​https://bugs.webkit.org/show_bug.cgi?id=78349

Broke three inspector interactive_ui_tests

Source/WebCore:

  • English.lproj/localizedStrings.js:
  • inspector/front-end/DebuggerPresentationModel.js:

(WebInspector.DebuggerPresentationModel.prototype.uiSourceCodes):

  • inspector/front-end/ScriptsNavigator.js:

(WebInspector.ScriptsNavigator.prototype._removeUISourceCode.get while):
(WebInspector.ScriptsNavigator.prototype._removeUISourceCode):
(WebInspector.ScriptsNavigator.prototype._showScriptFoldersSettingChanged):

  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype._uiSourceCodeAdded):
(WebInspector.ScriptsPanel.prototype._updateExecutionLine):

  • inspector/front-end/Settings.js:

(WebInspector.ExperimentsSettings):

  • inspector/front-end/SettingsScreen.js:

(WebInspector.SettingsScreen):

LayoutTests:

  • http/tests/inspector/debugger-test.js:

(initialize_DebuggerTest):

  • inspector/debugger/scripts-combobox-file-selector-history-expected.txt: Removed.
  • inspector/debugger/scripts-combobox-file-selector-history.html: Removed.
  • inspector/debugger/scripts-file-selector-expected.txt: Removed.
  • inspector/debugger/scripts-file-selector.html: Removed.
  • inspector/debugger/scripts-panel-expected.txt:
  • inspector/debugger/scripts-panel.html:
  • inspector/debugger/scripts-sorting-expected.txt:
  • inspector/debugger/scripts-sorting.html:
  • inspector/debugger/source-frame-count.html:
2:39 PM Changeset in webkit [107614] by abarth@webkit.org
  • 6 edits
    1 add in trunk/Tools

NRWT's HTTP servers should support additional directories for resources
​https://bugs.webkit.org/show_bug.cgi?id=78528

Reviewed by Eric Seidel.

This functionality will be used by the Chromium-Android port.

  • Scripts/webkitpy/layout_tests/port/base.py:

(Port.to.start_http_server):

  • Scripts/webkitpy/layout_tests/servers/apache_http_server.py:

(LayoutTestApacheHttpd.init):

  • Scripts/webkitpy/layout_tests/servers/http_server.py:

(Lighttpd.init):
(Lighttpd._prepare_config):

2:26 PM Changeset in webkit [107613] by inferno@chromium.org
  • 4 edits
    2 adds in trunk

Source/WebCore: Incorrect children placement in multi-column layout.
​https://bugs.webkit.org/show_bug.cgi?id=78160

Reviewed by David Hyatt.

Test: fast/multicol/span/clone-before-after-content-crash.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::clone): no longer need to take care of making
children noninline (remove fix r105769) since moveChild functions take
care of adding the child properly if type of children differ. this
function just makes sure to set the right value of childrenInline property.
(WebCore::RenderBlock::splitBlocks): similar to moveChild functions below.
(WebCore::RenderBlock::moveChildTo): when child is fullRemoveInsert (across
different parents, e.g clones), we should use addChild function to make sure
it handles the case of different type of children between fromBlock and
toBlock correctly (specifically making children non-inline/wrapping inline
children under anonymous blocks.).
(WebCore::RenderBlock::moveChildrenTo):

  • rendering/RenderBlock.h:

(RenderBlock):
(WebCore::RenderBlock::moveAllChildrenTo): Rename to->toBlock.
(WebCore::RenderBlock::moveChildrenTo): Rename to->toBlock.

LayoutTests: Incorrect children placement in multi-column layout.
​https://bugs.webkit.org/show_bug.cgi?id=78160

Reviewed by David Hyatt.

  • fast/multicol/span/clone-before-after-content-crash-expected.txt: Added.
  • fast/multicol/span/clone-before-after-content-crash.html: Added.
2:25 PM Changeset in webkit [107612] by eae@chromium.org
  • 1 edit in branches/subpixellayout/Source/WebCore/rendering/RenderInline.cpp

Fix rounding in RenderInline

2:22 PM Changeset in webkit [107611] by senorblanco@chromium.org
  • 4 edits in trunk

Source/WebCore: [chromium] Implement Brightness and Contrast filters on composited
layers. Fix Saturation filter.
​https://bugs.webkit.org/show_bug.cgi?id=78527

Reviewed by Kenneth Russell.

Will be covered by existing tests in css3/filters, when enabled.

  • platform/graphics/chromium/cc/CCRenderSurfaceFilters.cpp:

(WebCore::CCRenderSurfaceFilters::apply):

LayoutTests: Unskip the css3/filters tests, so we can get some baselines off the
bots.
​https://bugs.webkit.org/show_bug.cgi?id=78527

Reviewed by Kenneth Russell.

  • platform/chromium/test_expectations.txt:
2:21 PM Changeset in webkit [107610] by Lucas Forschler
  • 4 edits in branches/safari-534.54-branch/Source/JavaScriptCore

Merged r107338.

2:17 PM Changeset in webkit [107609] by andersca@apple.com
  • 2 edits in trunk/Source/WebCore

Turn off edge antialiasing for tile cache tile layers
​https://bugs.webkit.org/show_bug.cgi?id=78533
<rdar://problem/10710798>

Reviewed by Sam Weinig.

  • platform/graphics/ca/mac/TileCache.mm:

(WebCore::TileCache::createTileLayer):

2:15 PM Changeset in webkit [107608] by enrica@apple.com
  • 4 edits in trunk/Source

Build fix. Unreviewed.

Source/WebCore:

  • WebCore.xcodeproj/project.pbxproj:

Source/WebKit/qt:

  • WebCoreSupport/PlatformStrategiesQt.cpp:

(PlatformStrategiesQt::createPasteboardStrategy):

2:12 PM Changeset in webkit [107607] by beidson@apple.com
  • 3 edits
    5 adds in trunk

<rdar://problem/7196487> and ​https://bugs.webkit.org/show_bug.cgi?id=26777 Add https pages to the page cache in some cases

Reviewed by Anders Carlsson.

Source/WebCore:

Test: http/tests/navigation/https-in-page-cache.html

  • history/PageCache.cpp:

(WebCore::PageCache::canCachePageContainingThisFrame): Allow HTTPS pages that do not specify cache-control: no-cache

or cache-control: no-store into the page cache. This will match Firefox's behavior for HTTPS in their bfcache.

LayoutTests:

  • http/tests/navigation/https-in-page-cache.html: Added.
  • http/tests/navigation/https-in-page-cache-expected.txt: Added.
  • http/tests/navigation/resources/https-in-page-cache-1.php: Added.
  • http/tests/navigation/resources/https-in-page-cache-2.php: Added.
  • http/tests/navigation/resources/https-in-page-cache-3.html: Added.
2:08 PM LayoutUnit edited by leviw@chromium.org
(diff)
2:04 PM Changeset in webkit [107606] by enrica@apple.com
  • 17 edits
    3 adds in trunk/Source

Source/WebCore: Refactor Mac platform implementation of the Pasteboard class to use Platform Strategies.
​https://bugs.webkit.org/show_bug.cgi?id=78282

This patch removes any accesss to the NSPasteboard object from the Pasteboard class which
now makes use of a new pasteboardStrategy object that is implemented both in WebKit and
WebKit2. The actual access to NSPasteboard is now performed inside the PlatformPasteboard
class. Currently both WebKit and WebKit2 use the same implementation of the PasteboardStrategy
interface but this one more step in the direction of removing access to NSPasteboard from
the WebProcess.
As part of the refactoring the I've reduced to a minimum the use of OBJ-C classes.

Reviewed by Anders Carlsson.

No new tests. No change in behavior, just code refactoring.

  • WebCore.exp.in: Added exported class PlatformPasteboard.
  • WebCore.xcodeproj/project.pbxproj: Added new files to the build.
  • editing/mac/EditorMac.mm:

(WebCore::Editor::writeSelectionToPasteboard): New method signature that doesn't use OBJ-C types.

  • platform/Pasteboard.h:
  • platform/PasteboardStrategy.h: Added PasteboardStrategy abstract class.
  • platform/PlatformPasteboard.h: Added. This class implements access to NSPasteboard.
  • platform/PlatformStrategies.h:

(WebCore::PlatformStrategies::pasteboardStrategy): Added.

  • platform/mac/DragDataMac.mm:

(WebCore::DragData::canSmartReplace):
(WebCore::insertablePasteboardTypes):
(WebCore::DragData::asURL):

  • platform/mac/PasteboardMac.mm:

(WebCore::selectionPasteboardTypes): Changed to use Vector<String> instead of NSArray.
(WebCore::writableTypesForURL): Ditto.
(WebCore::createWritableTypesForImage): Ditto.
(WebCore::writableTypesForImage): Ditto.
(WebCore::Pasteboard::Pasteboard): Removed access to NSPasteboard.
(WebCore::Pasteboard::clear): Modified to use platformStrategies()->pasteboardStrategy().
(WebCore::Pasteboard::writeSelectionForTypes): Ditto.
(WebCore::Pasteboard::writePlainText): Ditto.
(WebCore::Pasteboard::writeSelection): Ditto.
(WebCore::writeURLForTypes): Ditto.
(WebCore::Pasteboard::writeURL): Ditto.
(WebCore::writeFileWrapperAsRTFDAttachment): Ditto.
(WebCore::Pasteboard::writeImage): Ditto.
(WebCore::Pasteboard::writeClipboard): Ditto.
(WebCore::Pasteboard::canSmartReplace): Ditto.
(WebCore::Pasteboard::plainText): Ditto.
(WebCore::documentFragmentWithRTF): Ditto.
(WebCore::Pasteboard::documentFragment): Ditto.

  • platform/mac/PlatformPasteboardMac.mm: Added.

(WebCore::PlatformPasteboard::PlatformPasteboard):
(WebCore::PlatformPasteboard::getTypes):
(WebCore::PlatformPasteboard::bufferForType):
(WebCore::PlatformPasteboard::getPathnamesForType):
(WebCore::PlatformPasteboard::stringForType):
(WebCore::PlatformPasteboard::copy):
(WebCore::PlatformPasteboard::setTypes):
(WebCore::PlatformPasteboard::setBufferForType):
(WebCore::PlatformPasteboard::setPathnamesForType):
(WebCore::PlatformPasteboard::setStringForType):

Source/WebKit/mac: Refactor Mac platform implementation of the Pasteboard class to use Platform Strategies.

​https://bugs.webkit.org/show_bug.cgi?id=78282


This patch removes any accesss to the NSPasteboard object from the Pasteboard class which
now makes use of a new pasteboardStrategy object that is implemented both in WebKit and
WebKit2. The actual access to NSPasteboard is now performed inside the PlatformPasteboard
class. Currently both WebKit and WebKit2 use the same implementation of the PasteboardStrategy
interface but this one more step in the direction of removing access to NSPasteboard from
the WebProcess.
As part of the refactoring the I've reduced to a minimum the use of OBJ-C classes.


Reviewed by Anders Carlsson.


  • WebCoreSupport/WebPlatformStrategies.h: Added PasteboardStrategy.
  • WebCoreSupport/WebPlatformStrategies.mm: Added implementation of PasteboardStrategy interface. (WebPlatformStrategies::createPasteboardStrategy): (WebPlatformStrategies::getTypes): (WebPlatformStrategies::bufferForType): (WebPlatformStrategies::getPathnamesForType): (WebPlatformStrategies::stringForType): (WebPlatformStrategies::copy): (WebPlatformStrategies::setTypes): (WebPlatformStrategies::setBufferForType): (WebPlatformStrategies::setPathnamesForType): (WebPlatformStrategies::setStringForType):

Source/WebKit/qt: Refactor Mac platform implementation of the Pasteboard class to use Platform Strategies.
​https://bugs.webkit.org/show_bug.cgi?id=78282

Build fix. Unreviewed.

  • WebCoreSupport/PlatformStrategiesQt.cpp:

(WebPlatformStrategies::createPasteboardStrategy):

  • WebCoreSupport/PlatformStrategiesQt.h:

(PlatformStrategiesQt):

Source/WebKit2: Refactor Mac platform implementation of the Pasteboard class to use Platform Strategies.
​https://bugs.webkit.org/show_bug.cgi?id=78282

This patch removes any accesss to the NSPasteboard object from the Pasteboard class which
now makes use of a new pasteboardStrategy object that is implemented both in WebKit and
WebKit2. The actual access to NSPasteboard is now performed inside the PlatformPasteboard
class. Currently both WebKit and WebKit2 use the same implementation of the PasteboardStrategy
interface but this one more step in the direction of removing access to NSPasteboard from
the WebProcess.
As part of the refactoring the I've reduced to a minimum the use of OBJ-C classes.

Reviewed by Anders Carlsson.

  • WebProcess/WebCoreSupport/WebPlatformStrategies.cpp: Added implementation of PasteboardStrategy

interface.
(WebKit::WebPlatformStrategies::createPasteboardStrategy):
(WebKit::WebPlatformStrategies::getTypes):
(WebKit::WebPlatformStrategies::bufferForType):
(WebKit::WebPlatformStrategies::getPathnamesForType):
(WebKit::WebPlatformStrategies::stringForType):
(WebKit::WebPlatformStrategies::copy):
(WebKit::WebPlatformStrategies::setTypes):
(WebKit::WebPlatformStrategies::setBufferForType):
(WebKit::WebPlatformStrategies::setPathnamesForType):
(WebKit::WebPlatformStrategies::setStringForType):

  • WebProcess/WebCoreSupport/WebPlatformStrategies.h: Added PasteboardStrategy.
2:02 PM Changeset in webkit [107605] by commit-queue@webkit.org
  • 5 edits
    2 adds in trunk

[CSS Regions] Inconsistent text selection behavior in regions
​https://bugs.webkit.org/show_bug.cgi?id=76456

Patch by Raul Hudea <​rhudea@adobe.com> on 2012-02-13
Reviewed by David Hyatt.

Source/WebCore:

Use the proper bounding rect when doing hit testing on flow threads.
Based on initial patch by Alexandru Chiculita.

Test: fast/regions/hit-test-region.html

  • rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::hitTestRegion):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::hitTest):

  • rendering/RenderRegion.cpp:

(WebCore::RenderRegion::nodeAtPoint):

LayoutTests:

  • fast/regions/hit-test-region-expected.txt: Added.
  • fast/regions/hit-test-region.html: Added.
2:01 PM Changeset in webkit [107604] by Lucas Forschler
  • 13 edits in branches/safari-534.54-branch/Source/WebKit2

Rollout r104070 and r105100.

1:59 PM Changeset in webkit [107603] by aestes@apple.com
  • 13 edits
    9 adds in trunk

[Windows] Add API to enable inverted color drawing on a WebView
​https://bugs.webkit.org/show_bug.cgi?id=77382

Reviewed by Adam Roben.

Source/WebCore:

Implement CACFLayerTreeHost::setShouldInvertColors(), which instructs
the layer tree host to render composited content with inverted colors.

Test: platform/win/inverted-colors/non-composited.html

  • platform/graphics/ca/win/CACFLayerTreeHost.cpp:

(WebCore::CACFLayerTreeHost::setShouldInvertColors):
(WebCore):

  • platform/graphics/ca/win/CACFLayerTreeHost.h:

(CACFLayerTreeHost):

  • platform/graphics/ca/win/WKCACFViewLayerTreeHost.cpp: Use

SOFT_LINK_OPTIONAL since WKCACFViewSetShouldInvertColors might not
exist in older versions of WebKitQuartzCoreAdditions.
(WebCore::WKCACFViewLayerTreeHost::setShouldInvertColors):
(WebCore):

  • platform/graphics/ca/win/WKCACFViewLayerTreeHost.h:

(WKCACFViewLayerTreeHost):

Source/WebKit/win:

Add a new private WebPreference key called "WebKitShouldInvertColors"
and add private cover methods to get and set the preference. When this
preference changes on a WebPreference object, all WebViews listening to
that object will repaint to reflect the new value.

  • Interfaces/IWebPreferencesPrivate.idl: Add [setS|s]houldInvertColors()

cover methods for WebKitShouldInvertColorsPreferenceKey.

  • WebPreferenceKeysPrivate.h: Add WebKitShouldInvertColorsPreferenceKey.
  • WebPreferences.cpp:

(WebPreferences::shouldInvertColors):
(WebPreferences::setShouldInvertColors):

  • WebPreferences.h:

(WebPreferences):

  • WebView.cpp:

(WebView::setShouldInvertColors): If m_shouldInvertColors changes,
update the value on the WebView and in m_layerTreeHost, then repaint
the view.
(WebView::notifyPreferencesChanged):
(WebView::setAcceleratedCompositing): When creating a new layer tree
host, tell it whether it should be inverting colors.

  • WebView.h:

LayoutTests:

Add a test for non-composited inverted drawing. Testing the composited
path is blocked on <​https://bugs.webkit.org/show_bug.cgi?id=78439>.

  • platform/win-wk2/platform/win/inverted-colors/non-composited-expected.png: Added.
  • platform/win-wk2/platform/win/inverted-colors/non-composited-expected.txt: Added.
  • platform/win/inverted-colors/non-composited-expected.png: Added.
  • platform/win/inverted-colors/non-composited-expected.txt: Added.
  • platform/win/inverted-colors/non-composited.html: Added.
  • platform/win/inverted-colors/resources/gradient.png: Added.
1:55 PM Changeset in webkit [107602] by tony@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Unreviewed gardening. Marking some debug tests as failing.

  • platform/chromium/test_expectations.txt:
1:45 PM Changeset in webkit [107601] by andersca@apple.com
  • 12 edits in trunk/Source

The scrolling tree needs to know about the back forward state of the page
​https://bugs.webkit.org/show_bug.cgi?id=78523
<rdar://problem/10756548>

Reviewed by Sam Weinig.

Source/WebCore:

In order to know if a page should rubber-band in the horizontal direction, the scrolling tree
needs to know about the back/forward state of the page.

  • WebCore.exp.in:

Export new symbols.

  • WebCore.xcodeproj/project.pbxproj:
  • page/scrolling/ScrollingTree.cpp:

(WebCore::ScrollingTree::ScrollingTree):
Initialize m_canGoBack and m_canGoForward.

(WebCore::ScrollingTree::updateBackForwardState):
Update m_canGoBack and m_canGoForward.

  • page/scrolling/ScrollingTree.h:

(WebCore::ScrollingTree::canGoBack):
(WebCore::ScrollingTree::canGoForward):
Add getters.

  • page/scrolling/mac/ScrollingTreeNodeMac.mm:

(WebCore::ScrollingTreeNodeMac::shouldRubberBandInDirection):
Implement this, using canGoBack and canGoForward.

Source/WebKit2:

Pass the back/forward state in the WheelEvent message. This is pretty hacky but works well.

  • Platform/CoreIPC/HandleMessage.h:

(CoreIPC):
(CoreIPC::callMemberFunction):

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::handleWheelEvent):
(WebKit::WebPageProxy::didReceiveEvent):

  • WebProcess/WebPage/EventDispatcher.cpp:

(WebKit::EventDispatcher::wheelEvent):

  • WebProcess/WebPage/EventDispatcher.h:

(EventDispatcher):

  • WebProcess/WebPage/EventDispatcher.messages.in:
1:34 PM Changeset in webkit [107600] by fischman@chromium.org
  • 5 edits
    2 moves
    1 add
    1 delete in trunk/LayoutTests

chromium gpu draws scrollbars slightly differently in debug vs. release modes on
​https://bugs.webkit.org/show_bug.cgi?id=58587

Unreviewed rebaseline (the scrollbar issue the bug is about was fixed previously).

  • platform/chromium-linux/media/video-controls-rendering-expected.png:
  • platform/chromium-mac-leopard/media/video-controls-rendering-expected.png:
  • platform/chromium-mac-snowleopard/media/video-controls-rendering-expected.png: Added.
  • platform/chromium-mac-snowleopard/media/video-controls-rendering-expected.txt: Renamed from LayoutTests/platform/chromium-mac/media/video-controls-rendering-expected.txt.
  • platform/chromium-mac/media/video-controls-rendering-expected.png: Removed.
  • platform/chromium-win/media/video-controls-rendering-expected.png:
  • platform/chromium/test_expectations.txt:
  • platform/mac-future/media/video-controls-rendering-expected.txt: Renamed from LayoutTests/platform/mac/media/video-controls-rendering-expected.txt.
1:24 PM Changeset in webkit [107599] by mitz@apple.com
  • 2 edits in trunk/Source/WebKit2

WebKit2 build emits a warning about not stripping code-signed PluginProcess.app when copying it into the framework
​https://bugs.webkit.org/show_bug.cgi?id=78451

Reviewed by Sam Weinig.

  • Configurations/Base.xcconfig: Set COPY_PHASE_STRIP to NO.
1:17 PM Changeset in webkit [107598] by fischman@chromium.org
  • 73 edits
    3 copies
    8 moves
    7 adds
    3 deletes in trunk/LayoutTests

Rebaseline media layouttests following keyframe addition to test.ogv
​https://bugs.webkit.org/show_bug.cgi?id=78367

Unreviewed chromium rebaselining.

  • platform/chromium-gpu-mac/media/controls-after-reload-expected.png:
  • platform/chromium-gpu-mac/media/controls-after-reload-expected.txt: Added.
  • platform/chromium-gpu-mac/media/controls-strict-expected.png:
  • platform/chromium-gpu-mac/media/controls-styling-expected.png:
  • platform/chromium-gpu-mac/media/controls-without-preload-expected.png:
  • platform/chromium-gpu-mac/media/video-aspect-ratio-expected.png:
  • platform/chromium-gpu-mac/media/video-display-toggle-expected.png:
  • platform/chromium-gpu-mac/media/video-layer-crash-expected.png:
  • platform/chromium-gpu-mac/media/video-playing-and-pause-expected.png:
  • platform/chromium-gpu-mac/media/video-playing-and-pause-expected.txt: Added.
  • platform/chromium-gpu-mac/media/video-transformed-expected.png:
  • platform/chromium-gpu-mac/media/video-volume-slider-expected.png:
  • platform/chromium-gpu-mac/media/video-zoom-controls-expected.png:
  • platform/chromium-gpu-mac/media/video-zoom-expected.png:
  • platform/chromium-gpu-win/media/controls-after-reload-expected.png:
  • platform/chromium-gpu-win/media/controls-strict-expected.png:
  • platform/chromium-gpu-win/media/controls-strict-expected.txt: Copied from LayoutTests/platform/chromium/media/controls-strict-expected.txt.
  • platform/chromium-gpu-win/media/controls-styling-expected.png:
  • platform/chromium-gpu-win/media/controls-styling-expected.txt: Copied from LayoutTests/platform/chromium/media/controls-styling-expected.txt.
  • platform/chromium-gpu-win/media/controls-without-preload-expected.png:
  • platform/chromium-gpu-win/media/controls-without-preload-expected.txt: Copied from LayoutTests/platform/chromium/media/controls-without-preload-expected.txt.
  • platform/chromium-gpu-win/media/video-aspect-ratio-expected.png:
  • platform/chromium-gpu-win/media/video-canvas-alpha-expected.png:
  • platform/chromium-gpu-win/media/video-display-toggle-expected.png:
  • platform/chromium-gpu-win/media/video-layer-crash-expected.png:
  • platform/chromium-gpu-win/media/video-playing-and-pause-expected.png:
  • platform/chromium-gpu-win/media/video-transformed-expected.png:
  • platform/chromium-gpu-win/media/video-volume-slider-expected.png:
  • platform/chromium-gpu-win/media/video-zoom-controls-expected.png:
  • platform/chromium-gpu-win/media/video-zoom-expected.png:
  • platform/chromium-linux-x86/media/video-display-toggle-expected.png: Added.
  • platform/chromium-linux/media/controls-after-reload-expected.png:
  • platform/chromium-linux/media/controls-strict-expected.png:
  • platform/chromium-linux/media/controls-styling-expected.png:
  • platform/chromium-linux/media/controls-without-preload-expected.png:
  • platform/chromium-linux/media/video-aspect-ratio-expected.png:
  • platform/chromium-linux/media/video-display-toggle-expected.png:
  • platform/chromium-linux/media/video-layer-crash-expected.png:
  • platform/chromium-linux/media/video-playing-and-pause-expected.png:
  • platform/chromium-linux/media/video-transformed-expected.png:
  • platform/chromium-linux/media/video-volume-slider-expected.png:
  • platform/chromium-linux/media/video-zoom-controls-expected.png:
  • platform/chromium-linux/media/video-zoom-expected.png:
  • platform/chromium-mac-leopard/media/controls-after-reload-expected.png:
  • platform/chromium-mac-leopard/media/controls-strict-expected.png:
  • platform/chromium-mac-leopard/media/controls-styling-expected.png:
  • platform/chromium-mac-leopard/media/controls-without-preload-expected.png:
  • platform/chromium-mac-leopard/media/video-aspect-ratio-expected.png:
  • platform/chromium-mac-leopard/media/video-display-toggle-expected.png:
  • platform/chromium-mac-leopard/media/video-layer-crash-expected.png:
  • platform/chromium-mac-leopard/media/video-playing-and-pause-expected.png:
  • platform/chromium-mac-leopard/media/video-transformed-expected.png:
  • platform/chromium-mac-leopard/media/video-volume-slider-expected.png:
  • platform/chromium-mac-leopard/media/video-zoom-expected.png:
  • platform/chromium-mac-snowleopard/media/controls-after-reload-expected.png:
  • platform/chromium-mac-snowleopard/media/controls-after-reload-expected.txt: Renamed from LayoutTests/platform/chromium/media/controls-after-reload-expected.txt.
  • platform/chromium-mac-snowleopard/media/controls-strict-expected.png:
  • platform/chromium-mac-snowleopard/media/controls-strict-expected.txt: Renamed from LayoutTests/platform/chromium/media/controls-strict-expected.txt.
  • platform/chromium-mac-snowleopard/media/controls-styling-expected.png:
  • platform/chromium-mac-snowleopard/media/controls-styling-expected.txt: Renamed from LayoutTests/platform/chromium/media/controls-styling-expected.txt.
  • platform/chromium-mac-snowleopard/media/controls-without-preload-expected.png:
  • platform/chromium-mac-snowleopard/media/controls-without-preload-expected.txt: Renamed from LayoutTests/platform/chromium/media/controls-without-preload-expected.txt.
  • platform/chromium-mac-snowleopard/media/video-aspect-ratio-expected.png: Added.
  • platform/chromium-mac-snowleopard/media/video-canvas-alpha-expected.png: Added.
  • platform/chromium-mac-snowleopard/media/video-display-toggle-expected.png:
  • platform/chromium-mac-snowleopard/media/video-layer-crash-expected.png:
  • platform/chromium-mac-snowleopard/media/video-playing-and-pause-expected.png:
  • platform/chromium-mac-snowleopard/media/video-playing-and-pause-expected.txt: Renamed from LayoutTests/platform/chromium/media/video-playing-and-pause-expected.txt.
  • platform/chromium-mac-snowleopard/media/video-transformed-expected.png:
  • platform/chromium-mac-snowleopard/media/video-volume-slider-expected.png:
  • platform/chromium-mac-snowleopard/media/video-volume-slider-expected.txt: Renamed from LayoutTests/platform/chromium/media/video-volume-slider-expected.txt.
  • platform/chromium-mac-snowleopard/media/video-zoom-controls-expected.png:
  • platform/chromium-mac-snowleopard/media/video-zoom-controls-expected.txt: Renamed from LayoutTests/platform/chromium/media/video-zoom-controls-expected.txt.
  • platform/chromium-mac-snowleopard/media/video-zoom-expected.png: Added.
  • platform/chromium-mac/media/video-aspect-ratio-expected.png: Removed.
  • platform/chromium-mac/media/video-canvas-alpha-expected.png: Removed.
  • platform/chromium-mac/media/video-zoom-expected.png: Removed.
  • platform/chromium-win/media/controls-after-reload-expected.png:
  • platform/chromium-win/media/controls-strict-expected.png:
  • platform/chromium-win/media/controls-styling-expected.png:
  • platform/chromium-win/media/controls-without-preload-expected.png:
  • platform/chromium-win/media/video-aspect-ratio-expected.png:
  • platform/chromium-win/media/video-canvas-alpha-expected.png:
  • platform/chromium-win/media/video-display-toggle-expected.png:
  • platform/chromium-win/media/video-layer-crash-expected.png:
  • platform/chromium-win/media/video-playing-and-pause-expected.png:
  • platform/chromium-win/media/video-transformed-expected.png:
  • platform/chromium-win/media/video-volume-slider-expected.png:
  • platform/chromium-win/media/video-zoom-controls-expected.png:
  • platform/chromium-win/media/video-zoom-expected.png:
  • platform/chromium/test_expectations.txt:
  • platform/mac-future/media/controls-strict-expected.txt: Renamed from LayoutTests/platform/mac/media/controls-strict-expected.txt.
1:16 PM Changeset in webkit [107597] by leviw@chromium.org
  • 4 edits in branches/subpixellayout/Source/WebCore

Renaming convertToRoundedLayerCoords to convertToPixelSnappedLayerCoords, which better describes what's being done. Also, adding const to AppUnit's abs, round, ceil, and floor methods.

1:07 PM Changeset in webkit [107596] by beidson@apple.com
  • 2 edits in trunk/Source/WebCore

​https://bugs.webkit.org/show_bug.cgi?id=78520 Cleanup PageCache::canCachePageContainingThisFrame readability

Reviewed by Anders Carlsson.

No new tests. (Code cleanup, no change in behavior)

  • history/PageCache.cpp:

(WebCore::PageCache::canCachePageContainingThisFrame): Store three commonly

getter-accessed variables in local variables for readability.

12:57 PM Changeset in webkit [107595] by weinig@apple.com
  • 8 edits
    1 add in trunk/Source/JavaScriptCore

Move JSC related assertions out of Assertions.h and into their own header
​https://bugs.webkit.org/show_bug.cgi?id=78508

Reviewed by Gavin Barraclough.

Add GCAssertions.h

  • heap/GCAssertions.h: Added.

Move assertions here.

  • runtime/WriteBarrier.h:

Add #include of GCAssertions.h

  • wtf/Assertions.h:

Remove JSC related assertions.

  • wtf/Compiler.h:

Add compiler check for has_trivial_destructor.

12:31 PM Changeset in webkit [107594] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Update MIPS patchOffsetGetByIdSlowCaseCall
​https://bugs.webkit.org/show_bug.cgi?id=78392

Patch by Chao-ying Fu <​fu@mips.com> on 2012-02-13
Reviewed by Gavin Barraclough.

  • jit/JIT.h:

(JIT):

12:14 PM Changeset in webkit [107593] by timothy@apple.com
  • 3 edits in trunk/Source/WebCore

Don't include a separator before the "Inspect Element" context menu item when the context menu is empty.

​https://webkit.org/b/78312

Reviewed by Brian Weinstein.

  • page/ContextMenuController.cpp:

(WebCore::ContextMenuController::addInspectElementItem): Check itemCount before appending the separator.

  • platform/gtk/ContextMenuGtk.cpp:

(WebCore::ContextMenu::itemCount): Added. Implement so this builds on GTK.

11:54 AM Changeset in webkit [107592] by Patrick Gansterer
  • 3 edits in trunk/Source/WebCore

[WIN] Define HWND_MESSAGE if not done already
​https://bugs.webkit.org/show_bug.cgi?id=78341

Reviewed by Adam Roben.

HWND_MESSAGE is not defined on WinCE.
Set it to 0 when not defined to avoid #ifdefs.

  • platform/win/PasteboardWin.cpp:

(WebCore::Pasteboard::Pasteboard):

  • platform/win/WindowsExtras.h:

(WebCore):

11:39 AM Changeset in webkit [107591] by fischman@chromium.org
  • 2 edits in trunk/Tools

Add fischman as committer.

Unreviewed

  • Scripts/webkitpy/common/config/committers.py:
11:32 AM Changeset in webkit [107590] by rniwa@webkit.org
  • 2 edits in trunk

Yet another perf-o-matic build fix. It turns out that a task of the same name can't be
queued for days after the first task is completed. So don't use it. Updating persistent
caches more often than necessary is better than never updating them.

  • Websites/webkit-perf.appspot.com/controller.py:

(schedule_manifest_update):
(schedule_dashboard_update):
(schedule_runs_update):

11:30 AM Changeset in webkit [107589] by Chris Fleizach
  • 5 edits
    2 adds in trunk

AX: <mark> element should be exposed through attributes
​https://bugs.webkit.org/show_bug.cgi?id=75727

Reviewed by Beth Dakin.

Source/WebCore:

Exposes an attribute indicating that an element has highlighting through attributedStringForRange.
Also allows the search mechanism to find elements with this style.

Test: platform/mac/accessibility/attributed-string-includes-highlighting.html

  • accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::isAccessibilityObjectSearchMatch):
(WebCore::AccessibilityObject::hasHighlighting):

  • accessibility/AccessibilityObject.h:
  • accessibility/mac/WebAccessibilityObjectWrapper.mm:

(createAccessibilitySearchKeyMap):
(AXAttributeStringSetStyle):

LayoutTests:

  • platform/mac/accessibility/attributed-string-includes-highlighting-expected.txt: Added.
  • platform/mac/accessibility/attributed-string-includes-highlighting.html: Added.
11:23 AM Changeset in webkit [107588] by Chris Fleizach
  • 4 edits
    2 adds in trunk

AX: the web area should report that focus can be set to itself
​https://bugs.webkit.org/show_bug.cgi?id=78272

Reviewed by Beth Dakin.

Source/WebCore:

Test: platform/mac/accessibility/webarea-can-set-focus.html

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::canSetFocusAttribute):

  • accessibility/AccessibilityTable.cpp:

(WebCore::AccessibilityTable::isDataTable):

Fixed erroneous comment.

LayoutTests:

  • platform/mac/accessibility/webarea-can-set-focus-expected.txt: Added.
  • platform/mac/accessibility/webarea-can-set-focus.html: Added.
11:05 AM Changeset in webkit [107587] by Patrick Gansterer
  • 2 edits in trunk/Source/JavaScriptCore

Remove obsolete #if from ThreadSpecific.h
​https://bugs.webkit.org/show_bug.cgi?id=78485

Reviewed by Adam Roben.

Since alle platform use either pthread or Win32 for threading,
we can remove all PLATFORM() preprocessor statements.

  • wtf/ThreadSpecific.h:

(ThreadSpecific):

10:54 AM Changeset in webkit [107586] by leviw@chromium.org
  • 1 edit in branches/subpixellayout/Source/WebCore/rendering/InlineFlowBox.cpp

We don't actually need to snap the top of inline flow boxes to pixel boundaries. This issue was solved upstream.

10:39 AM LayoutUnit edited by leviw@chromium.org
(diff)
10:08 AM Changeset in webkit [107585] by Patrick Gansterer
  • 2 edits in trunk/Source/WebCore

Port RunLoop to WinCE
​https://bugs.webkit.org/show_bug.cgi?id=76781

Reviewed by Adam Roben.

  • platform/win/RunLoopWin.cpp:

(WebCore::RunLoop::registerRunLoopMessageWindowClass):

10:06 AM Changeset in webkit [107584] by tony@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Unreviewed, update mac-snowleopard result. This matches
the Apple Mac (Lion) result except for minor antialias differences.

  • platform/chromium-mac-snowleopard/svg/custom/foreignObject-crash-on-hover-expected.png:
9:51 AM Changeset in webkit [107583] by jberlin@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Fix the Windows build.

9:50 AM Changeset in webkit [107582] by vsevik@chromium.org
  • 14 edits
    1 copy
    3 adds in trunk

Web Inspector: Make ScriptsNavigator default file selector.
​https://bugs.webkit.org/show_bug.cgi?id=78349

Reviewed by Pavel Feldman.

Source/WebCore:

Moved ScriptsNavigator out of experiments.
Introduced new setting "useScriptsNavigator" with true as default value.
Updated scripts panel tests related to file selector.

Tests: inspector/debugger/scripts-combobox-file-selector-history.html

inspector/debugger/scripts-file-selector.html

  • English.lproj/localizedStrings.js:
  • inspector/front-end/DebuggerPresentationModel.js:

(WebInspector.DebuggerPresentationModel.prototype.uiSourceCodes):

  • inspector/front-end/ScriptsNavigator.js:

(WebInspector.ScriptsNavigator.prototype._removeUISourceCode):
(WebInspector.ScriptsNavigator.prototype._showScriptFoldersSettingChanged):

  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype._uiSourceCodeAdded):
(WebInspector.ScriptsPanel.prototype._addUISourceCode):
(WebInspector.ScriptsPanel.prototype._updateExecutionLine):

  • inspector/front-end/Settings.js:

(WebInspector.ExperimentsSettings):

  • inspector/front-end/SettingsScreen.js:

(WebInspector.SettingsScreen):

LayoutTests:

  • http/tests/inspector/debugger-test.js:

(initialize_DebuggerTest):
(initialize_DebuggerTest.):

  • inspector/debugger/scripts-combobox-file-selector-history-expected.txt: Added.
  • inspector/debugger/scripts-combobox-file-selector-history.html: Added.
  • inspector/debugger/scripts-file-selector-expected.txt: Copied from LayoutTests/inspector/debugger/scripts-panel-expected.txt.
  • inspector/debugger/scripts-file-selector.html: Added.
  • inspector/debugger/scripts-panel-expected.txt:
  • inspector/debugger/scripts-panel.html:
  • inspector/debugger/scripts-sorting-expected.txt:
  • inspector/debugger/scripts-sorting.html:
  • inspector/debugger/source-frame-count.html:
9:47 AM Changeset in webkit [107581] by weinig@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Use C11's _Static_assert for COMPILE_ASSERT if it is available
​https://bugs.webkit.org/show_bug.cgi?id=78506

Rubber-stamped by Antti Koivisto.

Use C11's _Static_assert for COMPILE_ASSERT if it is available to give slightly
better error messages.

  • wtf/Assertions.h:

Use _Static_assert if it is available.

  • wtf/Compiler.h:

Add COMPILER_SUPPORTS support for _Static_assert when using the LLVM Compiler.

9:44 AM Changeset in webkit [107580] by kling@webkit.org
  • 3 edits in trunk/Source/WebCore

Make HTMLTableCaptionElement inherit from HTMLElement.
<​http://webkit.org/b/78505>

Reviewed by Antti Koivisto.

HTMLTableCaptionElement was already bypassing its base class (HTMLTablePartElement)
and calling up to HTMLElement in all its overrides. Just make it an HTMLElement
instead since it doesn't use anything from HTMLTablePartElement.
Remove parseAttribute() overload since it's no longer needed.

  • html/HTMLTableCaptionElement.cpp:

(WebCore::HTMLTableCaptionElement::HTMLTableCaptionElement):
(WebCore::HTMLTableCaptionElement::isPresentationAttribute):
(WebCore::HTMLTableCaptionElement::collectStyleForAttribute):

  • html/HTMLTableCaptionElement.h:
9:37 AM Changeset in webkit [107579] by kling@webkit.org
  • 3 edits in trunk/Source/WebCore

HTMLMarqueeElement: Don't cache presence of truespeed attribute.
<​http://webkit.org/b/78483>

Reviewed by Antti Koivisto.

Out-of-line minimumDelay() and look up the "truespeed" attribute there instead
of caching the minimum delay in parseAttribute().
Remove HTMLMarqueeElement::parseAttribute() as it's no longer needed.

  • html/HTMLMarqueeElement.cpp:

(WebCore::HTMLMarqueeElement::HTMLMarqueeElement):
(WebCore::HTMLMarqueeElement::minimumDelay):

  • html/HTMLMarqueeElement.h:

(HTMLMarqueeElement):

9:21 AM Changeset in webkit [107578] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening, skip a new failing test.

  • platform/qt/Skipped:
9:18 AM Changeset in webkit [107577] by weinig@apple.com
  • 2 edits in trunk/Source/WebKit2

Windows build fix.

  • UIProcess/win/WebPopupMenuProxyWin.cpp:

(WebKit::WebPopupMenuProxyWin::scrollToRevealSelection):

9:11 AM Changeset in webkit [107576] by caseq@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: [refactoring] factor common timeline UI state into TimelinePresentationModel
​https://bugs.webkit.org/show_bug.cgi?id=78501

Reviewed by Pavel Feldman.

  • inspector/front-end/TimelineOverviewPane.js:

(WebInspector.TimelineOverviewPane):
(WebInspector.TimelineOverviewPane.prototype._onCategoryVisibilityChanged):
(WebInspector.TimelineOverviewPane.prototype.update):
(WebInspector.TimelineOverviewPane.prototype.sidebarResized):
(WebInspector.TimelineOverviewPane.prototype._setWindowPosition):
(WebInspector.TimelineOverviewPane.prototype.scrollWindow):

  • inspector/front-end/TimelinePanel.js:

(WebInspector.TimelinePanel):
(WebInspector.TimelinePanel.prototype._createTopPane):
(WebInspector.TimelinePanel.prototype.get statusBarItems):
(WebInspector.TimelinePanel.prototype.get _recordStyles):
(WebInspector.TimelinePanel.prototype._createStatusbarButtons):
(WebInspector.TimelinePanel.prototype._createTimelineCategoryStatusBarCheckbox):
(WebInspector.TimelinePanel.prototype._onCategoryCheckboxClicked):
(WebInspector.TimelinePanel.prototype._innerAddRecordToTimeline):
(WebInspector.TimelinePanel.prototype.sidebarResized):
(WebInspector.TimelinePanel.prototype._updateBoundaries):
(WebInspector.TimelinePanel.prototype._showPopover):
(WebInspector.TimelinePresentationModel):
(WebInspector.TimelinePresentationModel.prototype.get categories):
(WebInspector.TimelinePresentationModel.prototype.addCategory):
(WebInspector.TimelinePresentationModel.prototype.setWindowPosition):
(WebInspector.TimelinePresentationModel.prototype.setCategoryVisibility):

8:39 AM Changeset in webkit [107575] by commit-queue@webkit.org
  • 8 edits
    1 add in trunk

Use requestAnimationFrame callbacks to pump CSS animations
​https://bugs.webkit.org/show_bug.cgi?id=64591

Patch by Joel Webber <​jgw@google.com> on 2012-02-13
Reviewed by James Robinson.

No new tests needed (covered by tests in animations/*).

  • page/FrameView.cpp:

(WebCore::FrameView::serviceScriptedAnimations):

  • page/animation/AnimationController.cpp:

(WebCore::AnimationControllerPrivate::updateAnimations):
(WebCore::AnimationControllerPrivate::updateAnimationTimer):
(WebCore::AnimationControllerPrivate::fireEventsAndUpdateStyle):
(WebCore::AnimationControllerPrivate::animationFrameCallbackFired):
(WebCore::AnimationController::updateAnimations):
(WebCore::AnimationController::serviceAnimations):

  • page/animation/AnimationController.h:
  • page/animation/AnimationControllerPrivate.h:
8:29 AM Changeset in webkit [107574] by Patrick Gansterer
  • 3 edits
    1 add in trunk/Source/WebCore

Add WindowsExtras.h
​https://bugs.webkit.org/show_bug.cgi?id=78340

Reviewed by Adam Roben.

Add a new file to share common code for Win32/WinCE differences.

  • platform/win/PopupMenuWin.cpp:

(WebCore::PopupMenuWin::PopupMenuWndProc):

  • platform/win/RunLoopWin.cpp:

(WebCore::RunLoop::RunLoopWndProc):

  • platform/win/WindowsExtras.h: Added.

(WebCore):
(WebCore::getWindowPointer):
(WebCore::setWindowPointer):

7:54 AM Changeset in webkit [107573] by kling@webkit.org
  • 2 edits in trunk/Source/WebCore

Don't mark element for style recalc when modifying its attribute style.
<​http://webkit.org/b/78497>

Reviewed by Antti Koivisto.

StylePropertySet::setNeedsStyleRecalc() shouldn't do anything for attribute styles.
Their invalidation is handled exclusively by StyledElement::attributeChanged().
Elements with presentation attributes were being marked for style recalc twice,
once when the attribute changed, and again during attribute style update, below the
call to collectStyleForAttribute().

  • css/StylePropertySet.cpp:

(WebCore::StylePropertySet::setNeedsStyleRecalc):

7:10 AM Changeset in webkit [107572] by podivilov@chromium.org
  • 3 edits in trunk/LayoutTests

Unreviewed, add new chromium baselines for font-face-multiple-faces.html.

  • platform/chromium-mac-snowleopard/fast/css/font-face-multiple-faces-expected.png:
  • platform/chromium-win/fast/css/font-face-multiple-faces-expected.png:
7:05 AM Changeset in webkit [107571] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit2

Manage ShareableBitmap object lifecycle properly, when QImage is created
using the shared data.
​https://bugs.webkit.org/show_bug.cgi?id=77546

Patch by Zalan Bujtas <​zbujtas@gmail.com> on 2012-02-13
Reviewed by Simon Hausmann.

  • Shared/ShareableBitmap.h:

(ShareableBitmap):

  • Shared/qt/ShareableBitmapQt.cpp:

(WebKit::ShareableBitmap::createQImage):
(WebKit):
(WebKit::ShareableBitmap::releaseSharedMemoryData):

7:02 AM Changeset in webkit [107570] by caio.oliveira@openbossa.org
  • 13 edits in trunk/Source/WebCore

Move attribute storage from NamedNodeMap to ElementAttributeData
​https://bugs.webkit.org/show_bug.cgi?id=77674

Reviewed by Andreas Kling.

Move m_attributes vector from NamedNodeMap to ElementAttributeData. Make the
remaining callsites interact with ElementAttributeData if possible. The parsing
code is still interacting with NamedNodeMap, so some functions remained as
wrappers there. A next change will it use ElementAttributeData instead.

The code for DOM exported functions remained in NamedNodeMap. This implementation
should move to Element in a next change, too.

  • dom/Attr.h:

(Attr):

  • dom/Element.cpp:

(WebCore::Element::setAttribute):
(WebCore::Element::setAttributeInternal):
(WebCore::Element::parserSetAttributeMap):
(WebCore::Element::removeAttribute):
(WebCore::Element::hasAttribute):
(WebCore::Element::hasAttributeNS):
(WebCore::Element::normalizeAttributes):

  • dom/Element.h:

(Element):
(WebCore::Element::ensureUpdatedAttributes):
(WebCore::Element::ensureAttributeData):
(WebCore):
(WebCore::Element::updatedAttributeData):
(WebCore::Element::ensureUpdatedAttributeData):
These *AttributeData functions are the correct correct way for callers to touch
the details of attribute storage. The "updated" variants will update invalid
attributes before return.

(WebCore::Element::setAttributesFromElement):

  • dom/ElementAttributeData.cpp:

(WebCore::ElementAttributeData::~ElementAttributeData):
(WebCore):
(WebCore::ElementAttributeData::ensureInlineStyleDecl):
(WebCore::ElementAttributeData::addAttribute):
(WebCore::ElementAttributeData::removeAttribute):
(WebCore::ElementAttributeData::detachAttributesFromElement):
(WebCore::ElementAttributeData::copyAttributesToVector):
(WebCore::ElementAttributeData::getAttributeItemIndexSlowCase):
(WebCore::ElementAttributeData::setAttributes): Make use of the assumption that
this will only be called with a valid Element, since the only call site is an
Element method.
(WebCore::ElementAttributeData::clearAttributes):
(WebCore::ElementAttributeData::replaceAttribute): Make use of the assumption
this will only be called with a valid Element, since the only call site return
early if there's no Element.

  • dom/ElementAttributeData.h:

(ElementAttributeData):
(WebCore::ElementAttributeData::length):
(WebCore::ElementAttributeData::isEmpty):
(WebCore::ElementAttributeData::attributeItem):
(WebCore::ElementAttributeData::removeAttribute):
(WebCore):
(WebCore::ElementAttributeData::getAttributeItem):
(WebCore::ElementAttributeData::getAttributeItemIndex):

  • dom/NamedNodeMap.cpp:

(WebCore::NamedNodeMap::getNamedItem):
(WebCore::NamedNodeMap::removeNamedItem):
(WebCore::NamedNodeMap::setNamedItem):
(WebCore::NamedNodeMap::item):
(WebCore::NamedNodeMap::detachFromElement):

  • dom/NamedNodeMap.h:

(WebCore::NamedNodeMap::length):
(WebCore::NamedNodeMap::isEmpty):
(WebCore::NamedNodeMap::attributeItem):
(WebCore::NamedNodeMap::getAttributeItem):
(WebCore::NamedNodeMap::getAttributeItemIndex):
(WebCore::NamedNodeMap::shrinkToLength):
(WebCore::NamedNodeMap::reserveInitialCapacity):
(WebCore::NamedNodeMap::addAttribute):
(WebCore::NamedNodeMap::removeAttribute):
(NamedNodeMap):

  • dom/StyledElement.cpp:

(WebCore::StyledElement::updateAttributeStyle):

  • dom/StyledElement.h:

(WebCore::StyledElement::ensureInlineStyleDecl):

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::updateType):

  • svg/properties/SVGAnimatedPropertySynchronizer.h:
  • xml/parser/XMLDocumentParserQt.cpp:

(WebCore::XMLDocumentParser::XMLDocumentParser):

6:50 AM Changeset in webkit [107569] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: wrong percent calculations for empty snapshot.
​https://bugs.webkit.org/show_bug.cgi?id=78329

Patch by Alexei Filippov <​alexeif@chromium.org> on 2012-02-13
Reviewed by Yury Semikhatsky.

  • inspector/front-end/DetailedHeapshotGridNodes.js:

(WebInspector.HeapSnapshotGridNode.prototype._createValueCell):

6:33 AM Changeset in webkit [107568] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

Web Inspector: add class filter to heap profiler.
​https://bugs.webkit.org/show_bug.cgi?id=78362

Patch by Alexei Filippov <​alexeif@chromium.org> on 2012-02-13
Reviewed by Yury Semikhatsky.

  • inspector/front-end/DataGrid.js:

(WebInspector.DataGrid.prototype.insertChild):

  • inspector/front-end/DetailedHeapshotView.js:

(WebInspector.HeapSnapshotSortableDataGrid.prototype._performSorting):
(WebInspector.HeapSnapshotConstructorsDataGrid):
(WebInspector.HeapSnapshotConstructorsDataGrid.prototype._nameFilterChanged):
(WebInspector.DetailedHeapshotView.prototype._changeNameFilter):

  • inspector/front-end/heapProfiler.css:

(.detailed-heapshot-view .constructors-view-grid):
(.detailed-heapshot-view .constructors-view-toolbar):
(.detailed-heapshot-view .constructors-view-toolbar input.constructors-view-filter):

6:27 AM Changeset in webkit [107567] by vsevik@chromium.org
  • 7 edits in trunk

Web Inspector: In Inspector.json PropertyDescriptor.writable should be declared optional
​https://bugs.webkit.org/show_bug.cgi?id=77917

Patch by Peter Rybin <​peter.rybin@gmail.com> on 2012-02-13
Reviewed by Pavel Feldman.

Source/WebCore:

Property descriptor is fixed in Inspector.json. Also retroactively in
0.1 and 1.0.
Injected script in instructed to never return null property values.

  • inspector/InjectedScriptSource.js:

(.):

  • inspector/Inspector-0.1.json:
  • inspector/Inspector-1.0.json:
  • inspector/Inspector.json:

LayoutTests:

"Undefined" getter and setter is now visible.

  • inspector/runtime/runtime-getProperties-expected.txt:
6:27 AM WebKitIDL edited by haraken@chromium.org
(diff)
6:24 AM WebKitIDL edited by haraken@chromium.org
(diff)
6:18 AM Changeset in webkit [107566] by mario@webkit.org
  • 6 edits in trunk/Source

[GTK] Add GSList to the list of GObject types in GOwnPtr
​https://bugs.webkit.org/show_bug.cgi?id=78487

Reviewed by Philippe Normand.

Source/JavaScriptCore:

Handle the GSList type in GOwnPtr, by calling g_slist_free in the
implementation of the freeOwnedGPtr template function.

  • wtf/gobject/GOwnPtr.cpp:

(WTF::GSList):
(WTF):

  • wtf/gobject/GOwnPtr.h:

(WTF):

  • wtf/gobject/GTypedefs.h:

Source/WebKit/gtk:

  • WebCoreSupport/ChromeClientGtk.cpp:

(WebKit::ChromeClient::runOpenPanel): Use GOwnPtr<GSList> for the
list of filenames returned by gtk_file_chooser_get_filenames().

6:16 AM Changeset in webkit [107565] by commit-queue@webkit.org
  • 5 edits in trunk

[GTK] Revise configuration for MHTML
​https://bugs.webkit.org/show_bug.cgi?id=78364

Patch by ChangSeok Oh <ChangSeok Oh> on 2012-02-13
Reviewed by Gustavo Noronha Silva.

.:

Added some lines to show checking messages, whether mhtml is enabled or not
during configuration and the configuration result for mhtml.
MHTML is a web page archive format used to combine resources
that are typically represented by external links (such as images, Flash animations,
Java applets, audio files) together with HTML code into a single file.
​http://en.wikipedia.org/wiki/MHTML

  • configure.ac:

Source/WebCore:

Added mhtml directory and removed target files duplicated to build when enabling mhtml.
Archive.cpp, ArchiveFactory.cpp & their headers are included at the above line.
This duplication has caused build-break if mhtml is enabled.

No new tests, since no new features.

  • GNUmakefile.am:
  • GNUmakefile.list.am:
6:15 AM WebKitIDL edited by haraken@chromium.org
(diff)
5:59 AM Changeset in webkit [107564] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening.

  • platform/qt/test_expectations.txt: Mark fast/js/dfg-inline-function-dot-caller.html as slow in debug mode.
5:42 AM Changeset in webkit [107563] by podivilov@chromium.org
  • 2 edits in trunk/LayoutTests

2012-02-13 Pavel Podivilov <​podivilov@chromium.org>

Unreviewed, add "IMAGE" to two svg/carto.net tests expectations.

  • platform/chromium/test_expectations.txt:
5:30 AM Changeset in webkit [107562] by kubo@profusion.mobi
  • 22 edits in trunk

[EFL] Drop support for the Curl network backend.
​https://bugs.webkit.org/show_bug.cgi?id=77874

Reviewed by Eric Seidel.

Nobody seems to be maintaining the Curl backend in WebCore, the
EFL port developers all seem to be using the Soup backend and the
port itself has many features which are only implemented for the
latter.

.:

  • Source/cmake/OptionsEfl.cmake: Remove network backend selection

checks and unconditionally require Glib and Libsoup, bump the
required LibSoup version to the same one the GTK+ port looks for,
since we share the same network backend.

Source/JavaScriptCore:

  • wtf/PlatformEfl.cmake: Always build the gobject-dependent source

files.

Source/WebCore:

No new tests, just some dependency plumbing.

  • PlatformEfl.cmake: Build the glib/soup source files

unconditionally.

  • platform/efl/FileSystemEfl.cpp: Remove ENABLE(GLIB_SUPPORT) check.

Source/WebKit/efl:

  • CMakeListsEfl.txt: Unconditionally build soup-dependent files

and always add the glib/soup include directories and libraries.

  • WebCoreSupport/FrameLoaderClientEfl.cpp:

(WebCore::FrameLoaderClientEfl::dispatchDidReceiveResponse):
Remove USE(SOUP) checks.

  • ewk/ewk_auth.cpp:

(ewk_auth_show_dialog_callback_set): Ditto.
(ewk_auth_credentials_set): Ditto.

  • ewk/ewk_cookies.cpp:

(ewk_cookies_file_set): Ditto.
(ewk_cookies_clear): Ditto.
(ewk_cookies_get_all): Ditto.
(ewk_cookies_cookie_del): Ditto.
(ewk_cookies_cookie_free): Ditto.
(ewk_cookies_policy_set): Ditto.
(ewk_cookies_policy_get): Ditto.

  • ewk/ewk_frame.cpp:

(ewk_frame_certificate_status_get): Ditto.

  • ewk/ewk_main.cpp:

(_ewk_init_body): Ditto.

  • ewk/ewk_network.cpp:

(ewk_network_proxy_uri_set): Ditto.
(ewk_network_proxy_uri_get): Ditto.
(ewk_network_tls_certificate_check_get): Ditto.
(ewk_network_tls_certificate_check_set): Ditto.
(ewk_network_tls_ca_certificates_path_get): Ditto.
(ewk_network_tls_ca_certificates_path_set): Ditto.
(ewk_network_default_soup_session_get): Ditto.

  • ewk/ewk_network.h: Update apidox for

ewk_network_default_soup_session_get() now that libsoup is the
only available backend.

Source/WebKit2:

  • PlatformEfl.cmake: Unconditionally build the glib/soup source

files and unconditionally add the required include directories and
libraries.

  • WebProcess/efl/WebProcessMainEfl.cpp:

(WebKit::WebProcessMainEfl): Remove USE(SOUP) check.

Tools:

  • DumpRenderTree/efl/CMakeLists.txt: Always link to glib/libsoup

and always add the required include directories.

  • EWebLauncher/CMakeLists.txt: Add the required glib/libsoup

include directories and link to them.

5:12 AM Changeset in webkit [107561] by pfeldman@chromium.org
  • 6 edits
    4 adds in trunk

Web Inspector: wrap settings selector text and adding a rule with undoable actions.
​https://bugs.webkit.org/show_bug.cgi?id=78482

Reviewed by Yury Semikhatsky.

Source/WebCore:

Tests: inspector/styles/undo-add-new-rule.html

inspector/styles/undo-set-selector-text.html

  • inspector/InspectorCSSAgent.cpp:

(WebCore::InspectorCSSAgent::StyleSheetAction::StyleSheetAction):
(InspectorCSSAgent::StyleSheetAction):
(WebCore::InspectorCSSAgent::SetStyleSheetTextAction::SetStyleSheetTextAction):
(WebCore::InspectorCSSAgent::SetStyleSheetTextAction::perform):
(WebCore::InspectorCSSAgent::SetStyleSheetTextAction::undo):
(WebCore::InspectorCSSAgent::SetPropertyTextAction::SetPropertyTextAction):
(WebCore::InspectorCSSAgent::SetPropertyTextAction::perform):
(WebCore::InspectorCSSAgent::SetPropertyTextAction::undo):
(WebCore::InspectorCSSAgent::SetPropertyTextAction::mergeId):
(WebCore::InspectorCSSAgent::TogglePropertyAction::TogglePropertyAction):
(WebCore::InspectorCSSAgent::TogglePropertyAction::perform):
(WebCore::InspectorCSSAgent::TogglePropertyAction::undo):
(InspectorCSSAgent::SetRuleSelectorAction):
(WebCore::InspectorCSSAgent::SetRuleSelectorAction::SetRuleSelectorAction):
(WebCore::InspectorCSSAgent::SetRuleSelectorAction::perform):
(WebCore::InspectorCSSAgent::SetRuleSelectorAction::undo):
(WebCore):
(InspectorCSSAgent::AddRuleAction):
(WebCore::InspectorCSSAgent::AddRuleAction::AddRuleAction):
(WebCore::InspectorCSSAgent::AddRuleAction::perform):
(WebCore::InspectorCSSAgent::AddRuleAction::undo):
(WebCore::InspectorCSSAgent::AddRuleAction::newRuleId):
(WebCore::InspectorCSSAgent::setStyleSheetText):
(WebCore::InspectorCSSAgent::setPropertyText):
(WebCore::InspectorCSSAgent::toggleProperty):
(WebCore::InspectorCSSAgent::setRuleSelector):
(WebCore::InspectorCSSAgent::addRule):
(WebCore::InspectorCSSAgent::asInspectorStyleSheet):
(WebCore::InspectorCSSAgent::bindStyleSheet):
(WebCore::InspectorCSSAgent::viaInspectorStyleSheet):
(WebCore::InspectorCSSAgent::styleSheetChanged):

  • inspector/InspectorCSSAgent.h:

(InspectorCSSAgent):

  • inspector/InspectorStyleSheet.cpp:

(WebCore::InspectorStyleSheet::create):
(WebCore::InspectorStyleSheet::InspectorStyleSheet):
(WebCore::InspectorStyleSheet::reparseStyleSheet):
(WebCore::InspectorStyleSheet::ruleSelector):
(WebCore):
(WebCore::InspectorStyleSheet::setRuleSelector):
(WebCore::InspectorStyleSheet::addRule):
(WebCore::InspectorStyleSheet::deleteRule):
(WebCore::InspectorStyleSheet::setPropertyText):
(WebCore::InspectorStyleSheet::toggleProperty):
(WebCore::InspectorStyleSheet::fireStyleSheetChanged):
(WebCore::InspectorStyleSheetForInlineStyle::create):
(WebCore::InspectorStyleSheetForInlineStyle::InspectorStyleSheetForInlineStyle):

  • inspector/InspectorStyleSheet.h:

(InspectorStyleSheet):
(WebCore::InspectorStyleSheet::styleId):
(InspectorStyleSheetForInlineStyle):

LayoutTests:

  • inspector/styles/undo-add-new-rule-expected.txt: Added.
  • inspector/styles/undo-add-new-rule.html: Added.
  • inspector/styles/undo-set-selector-text-expected.txt: Added.
  • inspector/styles/undo-set-selector-text.html: Added.
4:45 AM Changeset in webkit [107560] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening, unskip now passing tests.

  • platform/qt/Skipped:
4:45 AM Changeset in webkit [107559] by bashi@chromium.org
  • 2 edits in trunk/Tools

[WebSocket] Update pywebsocket to 0.7.1
​https://bugs.webkit.org/show_bug.cgi?id=78484

pywebsocket-0.7.1 follow the current draft of WebSocket deflate-frame extension.

Reviewed by Kent Tamura.

  • Scripts/webkitpy/thirdparty/init.py:

(AutoinstallImportHook._install_pywebsocket):

4:15 AM Changeset in webkit [107558] by hayato@chromium.org
  • 14 edits
    1 move
    1 add
    1 delete in trunk/Source/WebCore

Rename names defined in ContentInclutionSelector to more intuitive names.
​https://bugs.webkit.org/show_bug.cgi?id=78333

Reviewed by Hajime Morita.

This is just refactoring, renaming non-intuitive names to more intuitive names
so that they match the terms in the spec.

No tests. No change in behavior.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/NodeRenderingContext.cpp:

(WebCore::NodeRenderingContext::NodeRenderingContext):
(WebCore::nextRendererOf):
(WebCore::previousRendererOf):
(WebCore::firstRendererOf):
(WebCore::lastRendererOf):
(WebCore::NodeRenderingContext::nextRenderer):
(WebCore::NodeRenderingContext::previousRenderer):

  • dom/NodeRenderingContext.h:

(NodeRenderingContext):
(WebCore::NodeRenderingContext::insertionPoint):

  • dom/ShadowRoot.cpp:

(WebCore::ShadowRoot::insertionPointFor):
(WebCore::ShadowRoot::isSelectorActive):
(WebCore::ShadowRoot::attach):
(WebCore::ShadowRoot::selector):
(WebCore::ShadowRoot::ensureSelector):

  • dom/ShadowRoot.h:

(WebCore):
(ShadowRoot):

  • html/shadow/ContentInclusionSelector.h: Removed.
  • html/shadow/HTMLContentElement.cpp:

(WebCore::HTMLContentElement::HTMLContentElement):
(WebCore::HTMLContentElement::attach):
(WebCore::HTMLContentElement::detach):

  • html/shadow/HTMLContentElement.h:

(WebCore):
(WebCore::HTMLContentElement::selections):
(WebCore::HTMLContentElement::hasSelection):
(HTMLContentElement):

  • html/shadow/HTMLContentSelector.cpp: Renamed from Source/WebCore/html/shadow/ContentInclusionSelector.cpp.

(WebCore):
(WebCore::HTMLContentSeleciton::append):
(WebCore::HTMLContentSeleciton::unlink):
(WebCore::HTMLContentSelectionList::HTMLContentSelectionList):
(WebCore::HTMLContentSelectionList::~HTMLContentSelectionList):
(WebCore::HTMLContentSelectionList::find):
(WebCore::HTMLContentSelectionList::clear):
(WebCore::HTMLContentSelectionList::append):
(WebCore::HTMLContentSelector::HTMLContentSelector):
(WebCore::HTMLContentSelector::~HTMLContentSelector):
(WebCore::HTMLContentSelector::select):
(WebCore::HTMLContentSelector::unselect):
(WebCore::HTMLContentSelector::findFor):
(WebCore::HTMLContentSelector::didSelect):
(WebCore::HTMLContentSelector::willSelectOver):

  • html/shadow/HTMLContentSelector.h: Added.

(WebCore):
(HTMLContentSeleciton):
(WebCore::HTMLContentSeleciton::insertionPoint):
(WebCore::HTMLContentSeleciton::node):
(WebCore::HTMLContentSeleciton::next):
(WebCore::HTMLContentSeleciton::previous):
(WebCore::HTMLContentSeleciton::HTMLContentSeleciton):
(WebCore::HTMLContentSeleciton::create):
(HTMLContentSelectionList):
(WebCore::HTMLContentSelectionList::first):
(WebCore::HTMLContentSelectionList::last):
(WebCore::HTMLContentSelectionList::isEmpty):
(HTMLContentSelectionSet):
(WebCore::HTMLContentSelectionSet::add):
(WebCore::HTMLContentSelectionSet::remove):
(WebCore::HTMLContentSelectionSet::isEmpty):
(Translator):
(WebCore::HTMLContentSelectionSet::Translator::hash):
(WebCore::HTMLContentSelectionSet::Translator::equal):
(WebCore::HTMLContentSelectionSet::Hash::hash):
(WebCore::HTMLContentSelectionSet::Hash::equal):
(Hash):
(WebCore::HTMLContentSelectionSet::find):
(HTMLContentSelector):
(WebCore::HTMLContentSelector::hasCandidates):

  • testing/Internals.cpp:

(WebCore::Internals::includerFor):

4:08 AM Changeset in webkit [107557] by pfeldman@chromium.org
  • 6 edits in branches/chromium/1025

Merge 107242 - Web Inspector: fix setOuterHTML for the case that adds / removes duplicate.
​https://bugs.webkit.org/show_bug.cgi?id=78235

Reviewed by Yury Semikhatsky.

Source/WebCore:

  • inspector/DOMEditor.cpp:

(WebCore::DOMEditor::diff):
(WebCore::DOMEditor::innerPatchChildren):
(WebCore):
(WebCore::nodeName):
(WebCore::DOMEditor::dumpMap):

  • inspector/DOMEditor.h:

(DOMEditor):

LayoutTests:

  • inspector/elements/set-outer-html-2-expected.txt:
  • inspector/elements/set-outer-html-2.html:
  • inspector/elements/set-outer-html-expected.txt:
  • inspector/elements/set-outer-html.html:

TBR=​pfeldman@chromium.org
BUG=113388
Review URL: ​https://chromiumcodereview.appspot.com/9389003

4:02 AM WebKitIDL edited by haraken@chromium.org
(diff)
4:00 AM RegressionTestResearch edited by Csaba Osztrogonác
(diff)
4:00 AM WebKitIDL edited by haraken@chromium.org
(diff)
3:57 AM WebKitIDL edited by haraken@chromium.org
(diff)
3:57 AM Changeset in webkit [107556] by noam.rosenthal@nokia.com
  • 2 edits in trunk/Source/WebCore

[Texmap] morphing-cubes animation appears too close when clicking the button
​https://bugs.webkit.org/show_bug.cgi?id=78476

Fixed bug in TextureMapperAnimation that made transform animations that go to/from identity
to not work.

Reviewed by Simon Hausmann.

No behavior changes.

  • platform/graphics/texmap/TextureMapperAnimation.cpp:

(WebCore::applyTransformAnimation):

3:43 AM RegressionTestResearch created by beszedes@inf.u-szeged.hu
Adding regression test improvement pages
3:40 AM Top100Invariant created by beszedes@inf.u-szeged.hu
Adding regression test improvement pages
3:39 AM SelectiveTestEWS created by beszedes@inf.u-szeged.hu
3:36 AM SelectiveTestBuildBot created by beszedes@inf.u-szeged.hu
Adding regression test improvement pages
3:30 AM Improving Regression Tests edited by beszedes@inf.u-szeged.hu
(diff)
3:27 AM Improving Regression Tests created by beszedes@inf.u-szeged.hu
Adding regression test improvement pages
3:22 AM WikiStart edited by beszedes@inf.u-szeged.hu
Adding regression test improvement pages (diff)
3:01 AM Changeset in webkit [107555] by commit-queue@webkit.org
  • 28 edits in trunk/Source

[Forms] Use enum instead of bool for HTMLInputElement::setValue
​https://bugs.webkit.org/show_bug.cgi?id=75217

Patch by Yosifumi Inoue <​yosin@chromium.org> on 2012-02-13
Reviewed by Kent Tamura.

Source/WebCore:

Use TextFieldEventBehavior enum instead of sendChangeEvent bool
parameter for HTMLInputElement::setValue method. This new enum
parameter will be extended to dispatch input and change events
when user agent populates input field as specified in
"Common events behavior" of HTML5 standard.

This patch is required for fixing bug 75067 "[Forms] Spin buttons
of number input type should fire both input and change event."

No new tests. Existing tests cover this patch.

  • html/BaseButtonInputType.cpp:

(WebCore::BaseButtonInputType::setValue):

  • html/BaseButtonInputType.h:
  • html/BaseCheckableInputType.cpp:

(WebCore::BaseCheckableInputType::setValue):

  • html/BaseCheckableInputType.h:
  • html/BaseDateAndTimeInputType.cpp:

(WebCore::BaseDateAndTimeInputType::setValueAsNumber):

  • html/BaseDateAndTimeInputType.h:
  • html/CheckboxInputType.cpp:

(WebCore::CheckboxInputType::willDispatchClick):

  • html/ColorInputType.cpp:

(WebCore::ColorInputType::setValue):

  • html/ColorInputType.h:
  • html/FileInputType.cpp:

(WebCore::FileInputType::setValue):

  • html/FileInputType.h:
  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::applyStep):
(WebCore::HTMLInputElement::stepUp):
(WebCore::HTMLInputElement::stepDown):
(WebCore::HTMLInputElement::setChecked):
(WebCore::HTMLInputElement::setValueForUser):
(WebCore::HTMLInputElement::setValue):
(WebCore::HTMLInputElement::setValueInternal):
(WebCore::HTMLInputElement::setValueAsNumber):
(WebCore::HTMLInputElement::stepUpFromRenderer):

  • html/HTMLInputElement.h:
  • html/HTMLTextFormControlElement.h:
  • html/HiddenInputType.cpp:

(WebCore::HiddenInputType::setValue):

  • html/HiddenInputType.h:
  • html/InputType.cpp:

(WebCore::InputType::setValueAsNumber):
(WebCore::InputType::setValue):

  • html/InputType.h:
  • html/NumberInputType.cpp:

(WebCore::NumberInputType::setValueAsNumber):

  • html/NumberInputType.h:
  • html/RadioInputType.cpp:

(WebCore::RadioInputType::willDispatchClick):

  • html/RangeInputType.cpp:

(WebCore::RangeInputType::setValueAsNumber):
(WebCore::RangeInputType::handleKeydownEvent):
(WebCore::RangeInputType::setValue):

  • html/RangeInputType.h:
  • html/TextFieldInputType.cpp:

(WebCore::TextFieldInputType::setValue):

  • html/TextFieldInputType.h:

Source/WebKit/chromium:

  • src/WebInputElement.cpp:

(WebKit::WebInputElement::setValue): Use enum for HTMLInputElement::setValue

2:36 AM Changeset in webkit [107554] by kling@webkit.org
  • 67 edits in trunk/Source/WebCore

Move attribute style invalidation to attributeChanged().
<​http://webkit.org/b/78461>

Reviewed by Antti Koivisto.

Moved attribute style invalidation out of the parseAttribute() overloads
and added an "isPresentationAttribute(Attribute*) virtual to StyledElement.
Returning true for a given Attribute will cause attribute style invalidation
when that attribute passes through attributeChanged().

Removed a couple of parseAttribute() overloads whose only remaining purpose
was invalidating attribute style.

For form elements that deliberately don't map the "align" attribute, added
short-circuits in isPresentationAttribute instead of falling back to the
respective base class (which may othweise then map "align")

  • dom/StyledElement.cpp:

(WebCore::StyledElement::attributeChanged):

  • dom/StyledElement.h:

(WebCore::StyledElement::isPresentationAttribute):

  • html/HTMLBRElement.cpp:

(WebCore::HTMLBRElement::isPresentationAttribute):

  • html/HTMLBRElement.h:
  • html/HTMLBodyElement.cpp:

(WebCore::HTMLBodyElement::isPresentationAttribute):
(WebCore::HTMLBodyElement::collectStyleForAttribute):
(WebCore::HTMLBodyElement::parseAttribute):

  • html/HTMLBodyElement.h:
  • html/HTMLButtonElement.cpp:

(WebCore::HTMLButtonElement::isPresentationAttribute):
(WebCore::HTMLButtonElement::parseAttribute):

  • html/HTMLButtonElement.h:
  • html/HTMLDivElement.cpp:

(WebCore::HTMLDivElement::isPresentationAttribute):

  • html/HTMLDivElement.h:
  • html/HTMLElement.cpp:

(WebCore::HTMLElement::isPresentationAttribute):
(WebCore::HTMLElement::parseAttribute):

  • html/HTMLElement.h:
  • html/HTMLEmbedElement.cpp:

(WebCore::HTMLEmbedElement::isPresentationAttribute):
(WebCore::HTMLEmbedElement::parseAttribute):

  • html/HTMLEmbedElement.h:
  • html/HTMLFontElement.cpp:

(WebCore::HTMLFontElement::isPresentationAttribute):

  • html/HTMLFontElement.h:
  • html/HTMLFrameSetElement.cpp:

(WebCore::HTMLFrameSetElement::isPresentationAttribute):
(WebCore::HTMLFrameSetElement::parseAttribute):

  • html/HTMLFrameSetElement.h:
  • html/HTMLHRElement.cpp:

(WebCore::HTMLHRElement::isPresentationAttribute):
(WebCore::HTMLHRElement::collectStyleForAttribute):

  • html/HTMLHRElement.h:
  • html/HTMLIFrameElement.cpp:

(WebCore::HTMLIFrameElement::isPresentationAttribute):
(WebCore::HTMLIFrameElement::collectStyleForAttribute):
(WebCore::HTMLIFrameElement::parseAttribute):

  • html/HTMLIFrameElement.h:
  • html/HTMLImageElement.cpp:

(WebCore::HTMLImageElement::isPresentationAttribute):
(WebCore::HTMLImageElement::collectStyleForAttribute):
(WebCore::HTMLImageElement::parseAttribute):

  • html/HTMLImageElement.h:
  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::isPresentationAttribute):
(WebCore::HTMLInputElement::collectStyleForAttribute):
(WebCore::HTMLInputElement::parseAttribute):

  • html/HTMLInputElement.h:
  • html/HTMLLIElement.cpp:

(WebCore::HTMLLIElement::isPresentationAttribute):
(WebCore::HTMLLIElement::parseAttribute):

  • html/HTMLLIElement.h:
  • html/HTMLMarqueeElement.cpp:

(WebCore::HTMLMarqueeElement::isPresentationAttribute):
(WebCore::HTMLMarqueeElement::collectStyleForAttribute):
(WebCore::HTMLMarqueeElement::parseAttribute):

  • html/HTMLMarqueeElement.h:
  • html/HTMLOListElement.cpp:

(WebCore::HTMLOListElement::isPresentationAttribute):
(WebCore::HTMLOListElement::parseAttribute):

  • html/HTMLOListElement.h:
  • html/HTMLObjectElement.cpp:

(WebCore::HTMLObjectElement::isPresentationAttribute):
(WebCore::HTMLObjectElement::parseAttribute):

  • html/HTMLObjectElement.h:
  • html/HTMLParagraphElement.cpp:

(WebCore::HTMLParagraphElement::isPresentationAttribute):

  • html/HTMLParagraphElement.h:
  • html/HTMLPlugInElement.cpp:

(WebCore::HTMLPlugInElement::isPresentationAttribute):
(WebCore::HTMLPlugInElement::collectStyleForAttribute):

  • html/HTMLPlugInElement.h:
  • html/HTMLPreElement.cpp:

(WebCore::HTMLPreElement::isPresentationAttribute):
(WebCore::HTMLPreElement::collectStyleForAttribute):

  • html/HTMLPreElement.h:
  • html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::isPresentationAttribute):
(WebCore::HTMLSelectElement::parseAttribute):

  • html/HTMLSelectElement.h:
  • html/HTMLTableCaptionElement.cpp:

(WebCore::HTMLTableCaptionElement::isPresentationAttribute):
(WebCore::HTMLTableCaptionElement::parseAttribute):

  • html/HTMLTableCaptionElement.h:
  • html/HTMLTableCellElement.cpp:

(WebCore::HTMLTableCellElement::isPresentationAttribute):
(WebCore::HTMLTableCellElement::collectStyleForAttribute):
(WebCore::HTMLTableCellElement::parseAttribute):

  • html/HTMLTableCellElement.h:
  • html/HTMLTableColElement.cpp:

(WebCore::HTMLTableColElement::isPresentationAttribute):
(WebCore::HTMLTableColElement::parseAttribute):

  • html/HTMLTableColElement.h:
  • html/HTMLTableElement.cpp:

(WebCore::HTMLTableElement::isPresentationAttribute):
(WebCore::HTMLTableElement::parseAttribute):

  • html/HTMLTableElement.h:
  • html/HTMLTablePartElement.cpp:

(WebCore::HTMLTablePartElement::isPresentationAttribute):
(WebCore::HTMLTablePartElement::collectStyleForAttribute):

  • html/HTMLTablePartElement.h:
  • html/HTMLTextAreaElement.cpp:

(WebCore::HTMLTextAreaElement::isPresentationAttribute):
(WebCore::HTMLTextAreaElement::parseAttribute):

  • html/HTMLTextAreaElement.h:
  • html/HTMLUListElement.cpp:

(WebCore::HTMLUListElement::isPresentationAttribute):
(WebCore::HTMLUListElement::collectStyleForAttribute):

  • html/HTMLUListElement.h:
  • html/HTMLVideoElement.cpp:

(WebCore::HTMLVideoElement::isPresentationAttribute):
(WebCore::HTMLVideoElement::parseAttribute):

  • html/HTMLVideoElement.h:
  • mathml/MathMLElement.cpp:

(WebCore::MathMLElement::isPresentationAttribute):
(WebCore::MathMLElement::collectStyleForAttribute):

  • mathml/MathMLElement.h:
  • svg/SVGImageElement.cpp:

(WebCore::SVGImageElement::isPresentationAttribute):
(WebCore::SVGImageElement::parseAttribute):

  • svg/SVGImageElement.h:
  • svg/SVGStyledElement.cpp:

(WebCore::SVGStyledElement::isPresentationAttribute):
(WebCore::SVGStyledElement::parseAttribute):

  • svg/SVGStyledElement.h:
  • svg/SVGTextContentElement.cpp:

(WebCore::SVGTextContentElement::isPresentationAttribute):
(WebCore::SVGTextContentElement::parseAttribute):

  • svg/SVGTextContentElement.h:
2:24 AM Changeset in webkit [107553] by haraken@chromium.org
  • 5 edits in trunk/Source/WebCore

Add [JSCustomToJSObject] IDL attribute to interfaces that have
custom toJS() but do not have custom toV8()
​https://bugs.webkit.org/show_bug.cgi?id=78466

Reviewed by Adam Barth.

This is the second step to remove hard-coding in HasCustomToV8Implementation()
in CodeGeneratorV8.pm. This patch replaces [JSCustomToJS] with [JSCustomToJSObject]
for interfaces which have custom toJS() but do not have custom toV8().

No tests. No change in behavior.

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader):
(GenerateImplementation):

  • bindings/scripts/CodeGeneratorV8.pm:

(HasCustomToV8Implementation): I found that AbstractWorker and CanvasRenderingContext
are the only IDL files to which I need to add [JSCustomToJSObject].
Other IDL files which had been listed here do not have [JSCustomToJS].

  • html/canvas/CanvasRenderingContext.idl:
  • workers/AbstractWorker.idl:
2:23 AM Changeset in webkit [107552] by Csaba Osztrogonác
  • 4 edits in trunk/LayoutTests

Unreviewed gardening after r107544.

  • fast/dom/wrapper-classes-expected.txt:
  • platform/gtk/fast/dom/prototype-inheritance-2-expected.txt:
  • platform/qt/fast/dom/prototype-inheritance-2-expected.txt:
2:09 AM Changeset in webkit [107551] by kling@webkit.org
  • 2 edits in trunk/Source/WebCore

Avoid unnecessary work when evaluating style sharing candidates.
<​http://webkit.org/b/78220>

Reviewed by Antti Koivisto.

Do the cheap checks (bitfields, pointers) before calling virtuals and doing hash lookups.
Remove comparison of attributes that are reflected in the attribute styles (cellpadding.)
Moved comparison of "type" and "readonly" attributes into the more specific
canShareStyleWithControl() since they are only relevant for input elements. Don't bother
calling isFormControlElement() on both elements as they already have the same tagQName().

Altogether this knocks off ~8ms worth of samples per cycle of the "Moz" page cycler test.

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::canShareStyleWithControl):
(WebCore::CSSStyleSelector::canShareStyleWithElement):
(WebCore::isCommonAttributeSelectorAttribute):

2:08 AM Changeset in webkit [107550] by podivilov@chromium.org
  • 2 edits in trunk/LayoutTests

2012-02-13 Pavel Podivilov <​podivilov@chromium.org>

Unreviewed, mark dfg-put-by-id-prototype-check.html as failing in chromium (new test).

  • platform/chromium/test_expectations.txt:
2:08 AM Changeset in webkit [107549] by Patrick Gansterer
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed. Build fix for !ENABLE(JIT) after r107485.

  • bytecode/PolymorphicPutByIdList.cpp:
1:47 AM Changeset in webkit [107548] by commit-queue@webkit.org
  • 5 edits
    2 adds in trunk

<summary> is not keyboard accessible.
​https://bugs.webkit.org/show_bug.cgi?id=75478

Patch by Arko Saha <​arko@motorola.com> on 2012-02-13
Reviewed by Hajime Morita.

Source/WebCore:

Toggle the content of <details> element on pressing Enter or Spacebar
key on a focused <summary> element.

Test: fast/html/details-keyboard-show-hide.html

  • html/HTMLSummaryElement.cpp:

(WebCore::HTMLSummaryElement::supportsFocus):
(WebCore):
(WebCore::HTMLSummaryElement::defaultEventHandler):

  • html/HTMLSummaryElement.h:

(HTMLSummaryElement):

LayoutTests:

  • fast/html/details-keyboard-show-hide-expected.txt: Added.
  • fast/html/details-keyboard-show-hide.html: Added.
  • platform/chromium/test_expectations.txt: <summary> is now focusable and clicking

it draws a focus ring. So we need to rebase failed test cases.

1:37 AM Changeset in webkit [107547] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] REGRESSION(r107518): It broke many tests
​https://bugs.webkit.org/show_bug.cgi?id=78471

  • platform/qt/Skipped: Unreviewed gardening, skip failing tests.
1:31 AM Changeset in webkit [107546] by podivilov@chromium.org
  • 1 edit
    1 add in trunk/LayoutTests

2012-02-13 Pavel Podivilov <​podivilov@chromium.org>

Unreviewed, add new baseline for font-face-default-font.html on linux.

  • platform/chromium-linux/fast/css/font-face-default-font-expected.txt: Added.
1:30 AM Changeset in webkit [107545] by noel.gordon@gmail.com
  • 2 edits in trunk/LayoutTests

Rebaseline JPEG image results after r107389
​https://bugs.webkit.org/show_bug.cgi?id=78454

Unreviewed. Preparation for a bunch of rebaselines.

  • platform/chromium/test_expectations.txt: unskip tests to allow bots to cycle and

produce the new JPEG image results.

1:28 AM Changeset in webkit [107544] by barraclough@apple.com
  • 29 edits in trunk

​https://bugs.webkit.org/show_bug.cgi?id=78434
Unreviewed - temporarily reverting r107498 will I fix a couple of testcases.

Source/JavaScriptCore:

  • parser/Parser.cpp:

(JSC::::parseFunctionInfo):

  • runtime/ClassInfo.h:

(MethodTable):
(JSC):

  • runtime/JSCell.cpp:

(JSC):

  • runtime/JSCell.h:

(JSCell):

  • runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::reset):

  • runtime/JSGlobalObjectFunctions.cpp:

(JSC):

  • runtime/JSGlobalObjectFunctions.h:

(JSC):

  • runtime/JSObject.cpp:

(JSC::JSObject::put):
(JSC):
(JSC::JSObject::putDirectAccessor):
(JSC::JSObject::defineOwnProperty):

  • runtime/JSObject.h:

(JSC::JSObject::inlineGetOwnPropertySlot):
(JSC::JSValue::get):

  • runtime/JSString.cpp:

(JSC::JSString::getOwnPropertySlot):

  • runtime/JSValue.h:

(JSValue):

  • runtime/ObjectConstructor.cpp:

(JSC::objectConstructorGetPrototypeOf):

  • runtime/Structure.cpp:

(JSC::Structure::Structure):

  • runtime/Structure.h:

(JSC::Structure::setHasGetterSetterProperties):
(Structure):

Source/WebCore:

  • bindings/js/JSDOMWindowBase.cpp:

(WebCore):

  • bindings/js/JSDOMWindowBase.h:

(JSDOMWindowBase):

LayoutTests:

  • fast/js/Object-getOwnPropertyNames-expected.txt:
  • fast/js/cyclic-prototypes-expected.txt:
  • fast/js/parser-syntax-check-expected.txt:
  • fast/js/preventExtensions-expected.txt:
  • fast/js/prototypes-expected.txt:
  • fast/js/script-tests/Object-getOwnPropertyNames.js:
  • fast/js/script-tests/cyclic-prototypes.js:
  • fast/js/script-tests/parser-syntax-check.js:
  • fast/js/script-tests/preventExtensions.js:
  • fast/js/script-tests/prototypes.js:
1:22 AM WebKitIDL edited by haraken@chromium.org
(diff)
1:01 AM Changeset in webkit [107543] by podivilov@chromium.org
  • 2 edits in trunk/LayoutTests

2012-02-13 Pavel Podivilov <​podivilov@chromium.org>

Unreviewed, remove missing test from expectations.

  • platform/chromium/test_expectations.txt:
12:53 AM Changeset in webkit [107542] by loislo@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: get rid of cycles in containment view of an object.
​https://bugs.webkit.org/show_bug.cgi?id=78462

Reviewed by Yury Semikhatsky.

  • inspector/front-end/DetailedHeapshotGridNodes.js:

(WebInspector.HeapSnapshotObjectNode.prototype.updateHasChildren):
(WebInspector.HeapSnapshotObjectNode.prototype._prefixObjectCell):

12:48 AM WebKitIDL edited by haraken@chromium.org
(diff)
12:36 AM WebKitIDL edited by haraken@chromium.org
(diff)
12:18 AM Changeset in webkit [107541] by abarth@webkit.org
  • 6 edits
    3 adds in trunk/Source/WebCore

Remove ENABLE(MEDIA_STREAM) from Navigator.h
​https://bugs.webkit.org/show_bug.cgi?id=78467

Reviewed by Kentaro Hara.

Navigator.webkitGetUser media doesn't really have anything to do with
Navigator.cpp. This patch moves it into the mediastream directory and
removes the ENABLE(MEDIA_STREAM) ifdefs in Navigator.h and
Navigator.cpp.

  • GNUmakefile.list.am:
  • WebCore.gypi:
  • mediastream/NavigatorMediaStream.cpp: Added.

(WebCore):
(WebCore::NavigatorMediaStream::NavigatorMediaStream):
(WebCore::NavigatorMediaStream::~NavigatorMediaStream):
(WebCore::NavigatorMediaStream::webkitGetUserMedia):

  • mediastream/NavigatorMediaStream.h: Added.

(WebCore):
(NavigatorMediaStream):

  • mediastream/NavigatorMediaStream.idl: Added.
  • page/Navigator.cpp:

(WebCore):

  • page/Navigator.h:

(WebCore):
(Navigator):

  • page/Navigator.idl:
12:17 AM Changeset in webkit [107540] by abarth@webkit.org
  • 3 edits in trunk/LayoutTests

This test is testing the argument handling behavior of this API. Now
that we autogenerate this code, we now throw consistent exceptions with
the rest of the platform. There shouldn't be a compat issue here
because this API hasn't shipped in production releases yet.

  • fast/dom/MediaStream/argument-types-expected.txt:
  • fast/dom/MediaStream/script-tests/argument-types.js:
12:10 AM Changeset in webkit [107539] by commit-queue@webkit.org
  • 2 edits
    178 adds in trunk/LayoutTests

[EFL][DRT] Add new expected layout results come from bug 78091.
​https://bugs.webkit.org/show_bug.cgi?id=78188

Patch by Kangil Han <​kangil.han@samsung.com> on 2012-02-13
Reviewed by Ryosuke Niwa.

Implemented zoomPageIn, zoomPageOut, textZoomIn and textZoomOut events on EFL DRT.
This patch will activate around 1,900 test cases from skipped list in EFL port.

  • platform/efl/Skipped:
  • platform/efl/svg/css/composite-shadow-example-expected.txt: Added.
  • platform/efl/svg/css/composite-shadow-text-expected.txt: Added.
  • platform/efl/svg/css/composite-shadow-with-opacity-expected.txt: Added.
  • platform/efl/svg/css/css-box-min-width-expected.txt: Added.
  • platform/efl/svg/css/group-with-shadow-expected.txt: Added.
  • platform/efl/svg/css/mask-with-shadow-expected.txt: Added.
  • platform/efl/svg/css/path-gradient-stroke-shadow-expected.txt: Added.
  • platform/efl/svg/css/path-with-shadow-expected.txt: Added.
  • platform/efl/svg/css/shadow-and-opacity-expected.txt: Added.
  • platform/efl/svg/css/shadow-changes-expected.txt: Added.
  • platform/efl/svg/css/shadow-with-large-radius-expected.txt: Added.
  • platform/efl/svg/css/shadow-with-negative-offset-expected.txt: Added.
  • platform/efl/svg/css/stars-with-shadow-expected.txt: Added.
  • platform/efl/svg/css/text-gradient-shadow-expected.txt: Added.
  • platform/efl/svg/css/text-shadow-multiple-expected.txt: Added.
  • platform/efl/svg/dom/SVGPathSegList-segment-modification-expected.txt: Added.
  • platform/efl/svg/dom/SVGPathSegList-xml-dom-synchronization2-expected.txt: Added.
  • platform/efl/svg/foreignObject/disallowed-svg-nodes-as-direct-children-expected.txt: Added.
  • platform/efl/svg/foreignObject/no-crash-with-svg-content-in-html-document-expected.txt: Added.
  • platform/efl/svg/foreignObject/svg-document-as-direct-child-expected.txt: Added.
  • platform/efl/svg/foreignObject/svg-document-in-html-document-expected.txt: Added.
  • platform/efl/svg/hixie/cascade/001-broken-expected.txt: Added.
  • platform/efl/svg/hixie/cascade/002-expected.txt: Added.
  • platform/efl/svg/hixie/data-types/001-expected.txt: Added.
  • platform/efl/svg/hixie/data-types/002-expected.txt: Added.
  • platform/efl/svg/hixie/dynamic/002-expected.txt: Added.
  • platform/efl/svg/hixie/dynamic/003-expected.txt: Added.
  • platform/efl/svg/hixie/dynamic/004-expected.txt: Added.
  • platform/efl/svg/hixie/dynamic/005-expected.txt: Added.
  • platform/efl/svg/hixie/dynamic/006-expected.txt: Added.
  • platform/efl/svg/hixie/error/001-expected.txt: Added.
  • platform/efl/svg/hixie/error/002-expected.txt: Added.
  • platform/efl/svg/hixie/error/003-expected.txt: Added.
  • platform/efl/svg/hixie/error/006-expected.txt: Added.
  • platform/efl/svg/hixie/error/007-expected.txt: Added.
  • platform/efl/svg/hixie/error/008-expected.txt: Added.
  • platform/efl/svg/hixie/error/009-expected.txt: Added.
  • platform/efl/svg/hixie/error/010-expected.txt: Added.
  • platform/efl/svg/hixie/error/011-expected.txt: Added.
  • platform/efl/svg/hixie/error/012-expected.txt: Added.
  • platform/efl/svg/hixie/error/013-expected.txt: Added.
  • platform/efl/svg/hixie/error/014-expected.txt: Added.
  • platform/efl/svg/hixie/error/014-test-expected.txt: Added.
  • platform/efl/svg/hixie/error/015-expected.txt: Added.
  • platform/efl/svg/hixie/error/016-expected.txt: Added.
  • platform/efl/svg/hixie/error/017-expected.txt: Added.
  • platform/efl/svg/hixie/intrinsic/001-expected.txt: Added.
  • platform/efl/svg/hixie/intrinsic/002-expected.txt: Added.
  • platform/efl/svg/hixie/intrinsic/003-expected.txt: Added.
  • platform/efl/svg/hixie/links/002-expected.txt: Added.
  • platform/efl/svg/hixie/mixed/003-expected.txt: Added.
  • platform/efl/svg/hixie/mixed/004-expected.txt: Added.
  • platform/efl/svg/hixie/mixed/005-expected.txt: Added.
  • platform/efl/svg/hixie/mixed/006-expected.txt: Added.
  • platform/efl/svg/hixie/mixed/007-expected.txt: Added.
  • platform/efl/svg/hixie/mixed/008-expected.txt: Added.
  • platform/efl/svg/hixie/mixed/009-expected.txt: Added.
  • platform/efl/svg/hixie/mixed/010-expected.txt: Added.
  • platform/efl/svg/hixie/mixed/011-expected.txt: Added.
  • platform/efl/svg/hixie/painting/001-expected.txt: Added.
  • platform/efl/svg/hixie/perf/001-expected.txt: Added.
  • platform/efl/svg/hixie/perf/002-expected.txt: Added.
  • platform/efl/svg/hixie/perf/003-expected.txt: Added.
  • platform/efl/svg/hixie/perf/004-expected.txt: Added.
  • platform/efl/svg/hixie/perf/005-expected.txt: Added.
  • platform/efl/svg/hixie/perf/006-expected.txt: Added.
  • platform/efl/svg/hixie/perf/007-expected.txt: Added.
  • platform/efl/svg/hixie/processing-model/003-expected.txt: Added.
  • platform/efl/svg/hixie/processing-model/004-expected.txt: Added.
  • platform/efl/svg/hixie/processing-model/005-expected.txt: Added.
  • platform/efl/svg/hixie/rendering-model/001-expected.txt: Added.
  • platform/efl/svg/hixie/rendering-model/002-expected.txt: Added.
  • platform/efl/svg/hixie/rendering-model/003-expected.txt: Added.
  • platform/efl/svg/hixie/rendering-model/003a-expected.txt: Added.
  • platform/efl/svg/hixie/rendering-model/004-expected.txt: Added.
  • platform/efl/svg/hixie/shapes/path/001-expected.txt: Added.
  • platform/efl/svg/hixie/text/001-expected.txt: Added.
  • platform/efl/svg/hixie/text/002-expected.txt: Added.
  • platform/efl/svg/hixie/text/003-expected.txt: Added.
  • platform/efl/svg/hixie/text/003a-expected.txt: Added.
  • platform/efl/svg/hixie/text/003b-expected.txt: Added.
  • platform/efl/svg/hixie/transform/001-expected.txt: Added.
  • platform/efl/svg/hixie/use/001-expected.txt: Added.
  • platform/efl/svg/hixie/use/002-expected.txt: Added.
  • platform/efl/svg/hixie/use/002-test-expected.txt: Added.
  • platform/efl/svg/hixie/viewbox/001-expected.txt: Added.
  • platform/efl/svg/hixie/viewbox/004-expected.txt: Added.
  • platform/efl/svg/hixie/viewbox/preserveAspectRatio/001-expected.txt: Added.
  • platform/efl/svg/hixie/viewbox/preserveAspectRatio/002-expected.txt: Added.
  • platform/efl/svg/in-html/by-reference-expected.txt: Added.
  • platform/efl/svg/in-html/circle-expected.txt: Added.
  • platform/efl/svg/overflow/overflow-on-foreignObject-expected.txt: Added.
  • platform/efl/svg/overflow/overflow-on-inner-svg-element-defaults-expected.txt: Added.
  • platform/efl/svg/overflow/overflow-on-inner-svg-element-expected.txt: Added.
  • platform/efl/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-auto-expected.txt: Added.
  • platform/efl/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-defaults-expected.txt: Added.
  • platform/efl/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-hidden-expected.txt: Added.
  • platform/efl/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-scroll-expected.txt: Added.
  • platform/efl/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-visible-expected.txt: Added.
  • platform/efl/svg/repaint/filter-child-repaint-expected.txt: Added.
  • platform/efl/svg/repaint/filter-repaint-expected.txt: Added.
  • platform/efl/svg/stroke/zero-length-path-linecap-rendering-expected.txt: Added.
  • platform/efl/svg/stroke/zero-length-subpaths-linecap-rendering-expected.txt: Added.
  • platform/efl/svg/transforms/animated-path-inside-transformed-html-expected.txt: Added.
  • platform/efl/svg/transforms/svg-css-transforms-clip-path-expected.txt: Added.
  • platform/efl/svg/transforms/svg-css-transforms-expected.txt: Added.
  • platform/efl/svg/transforms/text-with-mask-with-svg-transform-expected.txt: Added.
  • platform/efl/svg/transforms/text-with-pattern-inside-transformed-html-expected.txt: Added.
  • platform/efl/svg/transforms/text-with-pattern-with-svg-transform-expected.txt: Added.
  • platform/efl/svg/wicd/rightsizing-grid-expected.txt: Added.
  • platform/efl/svg/wicd/sizing-flakiness-expected.txt: Added.
  • platform/efl/svg/wicd/test-rightsizing-a-expected.txt: Added.
  • platform/efl/svg/wicd/test-rightsizing-b-expected.txt: Added.
  • platform/efl/svg/wicd/test-scalable-background-image1-expected.txt: Added.
  • platform/efl/svg/wicd/test-scalable-background-image2-expected.txt: Added.
  • platform/efl/svg/zoom/page/absolute-sized-document-no-scrollbars-expected.txt: Added.
  • platform/efl/svg/zoom/page/absolute-sized-document-scrollbars-expected.txt: Added.
  • platform/efl/svg/zoom/page/zoom-background-image-tiled-expected.txt: Added.
  • platform/efl/svg/zoom/page/zoom-background-images-expected.txt: Added.
  • platform/efl/svg/zoom/page/zoom-coords-viewattr-01-b-expected.txt: Added.
  • platform/efl/svg/zoom/page/zoom-foreignObject-expected.txt: Added.
  • platform/efl/svg/zoom/page/zoom-hixie-mixed-008-expected.txt: Added.
  • platform/efl/svg/zoom/page/zoom-hixie-mixed-009-expected.txt: Added.
  • platform/efl/svg/zoom/page/zoom-hixie-rendering-model-004-expected.txt: Added.
  • platform/efl/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt: Added.
  • platform/efl/svg/zoom/page/zoom-mask-with-percentages-expected.txt: Added.
  • platform/efl/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt: Added.
  • platform/efl/svg/zoom/page/zoom-svg-as-background-with-relative-size-and-viewBox-expected.txt: Added.
  • platform/efl/svg/zoom/page/zoom-svg-as-background-with-relative-size-expected.txt: Added.
  • platform/efl/svg/zoom/page/zoom-svg-as-image-expected.txt: Added.
  • platform/efl/svg/zoom/page/zoom-svg-as-object-expected.txt: Added.
  • platform/efl/svg/zoom/page/zoom-svg-as-relative-image-expected.txt: Added.
  • platform/efl/svg/zoom/page/zoom-svg-float-border-padding-expected.txt: Added.
  • platform/efl/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.txt: Added.
  • platform/efl/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.txt: Added.
  • platform/efl/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.txt: Added.
  • platform/efl/svg/zoom/page/zoom-svg-through-object-with-huge-size-expected.txt: Added.
  • platform/efl/svg/zoom/page/zoom-svg-through-object-with-override-size-expected.txt: Added.
  • platform/efl/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt: Added.
  • platform/efl/svg/zoom/text/absolute-sized-document-no-scrollbars-expected.txt: Added.
  • platform/efl/svg/zoom/text/absolute-sized-document-scrollbars-expected.txt: Added.
  • platform/efl/svg/zoom/text/relative-sized-document-scrollbars-expected.txt: Added.
  • platform/efl/svg/zoom/text/zoom-coords-viewattr-01-b-expected.txt: Added.
  • platform/efl/svg/zoom/text/zoom-foreignObject-expected.txt: Added.
  • platform/efl/svg/zoom/text/zoom-hixie-mixed-008-expected.txt: Added.
  • platform/efl/svg/zoom/text/zoom-hixie-mixed-009-expected.txt: Added.
  • platform/efl/svg/zoom/text/zoom-hixie-rendering-model-004-expected.txt: Added.
  • platform/efl/svg/zoom/text/zoom-svg-float-border-padding-expected.txt: Added.

Feb 12, 2012:

11:59 PM Changeset in webkit [107538] by Philippe Normand
  • 2 edits in trunk/LayoutTests

Unreviewed, skipping 2 tests failing because of bug 78434.

  • platform/gtk/Skipped:
11:30 PM Changeset in webkit [107537] by abarth@webkit.org
  • 5 edits
    2 deletes in trunk/Source/WebCore

Navigator.webkitGetUserMedia doesn't need to be custom
​https://bugs.webkit.org/show_bug.cgi?id=78464

Reviewed by Eric Seidel.

The code generator has gotten smarter since this function was added.

  • GNUmakefile.list.am:
  • UseV8.cmake:
  • WebCore.gypi:
  • bindings/js/JSNavigatorCustom.cpp: Removed.
  • bindings/v8/custom/V8NavigatorCustom.cpp: Removed.
  • page/Navigator.idl:
11:03 PM Changeset in webkit [107536] by abarth@webkit.org
  • 14 edits
    2 adds in trunk/Source/WebCore

Move ENABLE(GAMEPAD) logic out of Navigator.h/cpp
​https://bugs.webkit.org/show_bug.cgi?id=78457

Reviewed by Hajime Morita.

This patch moves GAMEPAD-specific logic out of Navigator by introducing
the concept of a NavigatorSupplement, analogous to the recently
introduced PageSupplement.

  • Modules/gamepad/NavigatorGamepad.cpp:

(WebCore::NavigatorGamepad::from):
(WebCore):
(WebCore::NavigatorGamepad::webkitGamepads):
(WebCore::NavigatorGamepad::gamepads):

  • Modules/gamepad/NavigatorGamepad.h:

(NavigatorGamepad):

  • WebCore.gypi:
  • dom/DeviceMotionController.cpp:

(WebCore::DeviceMotionController::supplementName):

  • page/Navigator.cpp:

(WebCore::Navigator::provideSupplement):
(WebCore):
(WebCore::Navigator::requireSupplement):

  • page/Navigator.h:

(Navigator):

  • page/Page.h:

(Page):

  • page/PageSupplement.h:
    • This patch cleans up some nits in PageSupplement.

(WebCore):
(PageSupplement):

11:00 PM Changeset in webkit [107535] by rniwa@webkit.org
  • 2 edits in trunk

Another perf-o-matic build fix.

  • Websites/webkit-perf.appspot.com/report_process_handler.py:

(ReportProcessHandler._create_build_if_possible):

10:47 PM Changeset in webkit [107534] by bashi@chromium.org
  • 4 edits
    1 move
    3 adds
    1 delete in trunk/LayoutTests

Unreviewed test expectations update after r107516.

  • platform/chromium-mac-leopard/fast/css/font-face-default-font-expected.png: Added.
  • platform/chromium-mac-leopard/fast/css/font-face-multiple-faces-expected.png:
  • platform/chromium-mac-snowleopard/fast/css/font-face-default-font-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/css/font-face-default-font-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/css/font-face-multiple-faces-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/css/font-face-multiple-faces-expected.png.
  • platform/chromium-mac/fast/css/font-face-default-font-expected.png: Removed.
  • platform/chromium-win/fast/css/font-face-default-font-expected.png:
  • platform/chromium-win/fast/css/font-face-default-font-expected.txt:
10:41 PM Changeset in webkit [107533] by bashi@chromium.org
  • 1 edit
    18 deletes in trunk/LayoutTests

Remove fast/css/font-face-descriptor-multiple-values.html
​https://bugs.webkit.org/show_bug.cgi?id=78456

The test is no longer needed because WebKit now follow the current
draft(*1) and doesn't accept multiple font-weight descriptors.
(*1) ​http://dev.w3.org/csswg/css3-fonts/#descdef-font-weight

Reviewed by Hajime Morita.

  • fast/css/font-face-descriptor-multiple-values.html: Removed.
  • fast/css/resources/font-face-descriptor-multiple-values-parsing.js: Removed.
  • platform/chromium-linux/fast/css/font-face-descriptor-multiple-values-expected.png: Removed.
  • platform/chromium-mac-leopard/fast/css/font-face-descriptor-multiple-values-expected.png: Removed.
  • platform/chromium-mac/fast/css/font-face-descriptor-multiple-values-expected.png: Removed.
  • platform/chromium-mac/fast/css/font-face-descriptor-multiple-values-parsing-expected.txt: Removed.
  • platform/chromium-win/fast/css/font-face-descriptor-multiple-values-expected.png: Removed.
  • platform/chromium-win/fast/css/font-face-descriptor-multiple-values-expected.txt: Removed.
  • platform/chromium-win/fast/css/font-face-descriptor-multiple-values-parsing-expected.txt: Removed.
  • platform/efl/fast/css/font-face-descriptor-multiple-values-expected.png: Removed.
  • platform/efl/fast/css/font-face-descriptor-multiple-values-expected.txt: Removed.
  • platform/gtk/fast/css/font-face-descriptor-multiple-values-expected.png: Removed.
  • platform/gtk/fast/css/font-face-descriptor-multiple-values-expected.txt: Removed.
  • platform/mac-leopard/fast/css/font-face-descriptor-multiple-values-expected.png: Removed.
  • platform/mac/fast/css/font-face-descriptor-multiple-values-expected.png: Removed.
  • platform/mac/fast/css/font-face-descriptor-multiple-values-expected.txt: Removed.
  • platform/qt/fast/css/font-face-descriptor-multiple-values-expected.png: Removed.
  • platform/qt/fast/css/font-face-descriptor-multiple-values-expected.txt: Removed.
10:26 PM WebKitIDL edited by haraken@chromium.org
(diff)
10:25 PM WebKitIDL edited by haraken@chromium.org
(diff)
10:21 PM WebKitIDL edited by haraken@chromium.org
(diff)
10:20 PM WebKitIDL edited by haraken@chromium.org
(diff)
10:20 PM Changeset in webkit [107532] by rniwa@webkit.org
  • 2 edits in trunk

Perf-o-matic build fix.

  • Websites/webkit-perf.appspot.com/report_handler.py:

(ReportHandler.post):

9:45 PM Changeset in webkit [107531] by rniwa@webkit.org
  • 5 edits in trunk

REGRESSION: Perf-o-matic adds duplicated test results
​https://bugs.webkit.org/show_bug.cgi?id=78373

Reviewed by Hajime Morita.

Add TestResult inside a transaction. We use high replication databsae but this should prevent
the duplication in the most of the time.

Also fixed random bugs in Controller and ReportHandler.

  • Websites/webkit-perf.appspot.com/controller.py:

(get_persistent_cache):

  • Websites/webkit-perf.appspot.com/report_handler.py:

(ReportHandler.post):

  • Websites/webkit-perf.appspot.com/report_process_handler.py:

(ReportProcessHandler.post):
(ReportProcessHandler._add_test_if_needed):
(ReportProcessHandler):
(ReportProcessHandler._add_test_result_if_needed):
(ReportProcessHandler._add_test_result_if_needed._float_or_none):
(ReportProcessHandler._add_test_result_if_needed.execute):

9:35 PM Changeset in webkit [107530] by haraken@chromium.org
  • 17 edits in trunk/Source/WebCore

Add a [V8CustomToJSObject] IDL attribute
​https://bugs.webkit.org/show_bug.cgi?id=78450

Reviewed by Adam Barth.

This is the first step to remove hard-coding in HasCustomToV8Implementation()
in CodeGeneratorV8.pm. This patch adds [V8CustomToJSObject]
to interfaces which have custom toV8() but do not have custom toJS().

No tests. No change in behavior.

  • bindings/scripts/CodeGeneratorV8.pm: Replaced hard-coding with [V8CustomToJSObject].

(HasCustomToV8Implementation):

  • css/CSSStyleSheet.idl: Added [V8CustomToJSObject].
  • dom/DOMStringMap.idl:
  • dom/Element.idl:
  • dom/NamedNodeMap.idl:
  • html/DOMTokenList.idl:
  • html/HTMLDocument.idl:
  • html/HTMLElement.idl:
  • html/canvas/CanvasPixelArray.idl:
  • inspector/ScriptProfile.idl:
  • inspector/ScriptProfileNode.idl:
  • page/DOMWindow.idl:
  • page/Location.idl:
  • svg/SVGDocument.idl:
  • svg/SVGElement.idl:
  • workers/WorkerContext.idl:
9:26 PM Changeset in webkit [107529] by commit-queue@webkit.org
  • 3 edits
    161 adds in trunk

[EFL][DRT] Implement zoomPage{In,Out} and textZoom{In,Out} events.
​https://bugs.webkit.org/show_bug.cgi?id=78091

Patch by Kangil Han <​kangil.han@samsung.com> on 2012-02-12
Reviewed by Hajime Morita.

Implemented zoomPageIn, zoomPageOut, textZoomIn and textZoomOut events on EFL DRT.
This patch will activate around 1,900 test cases from skipped list in EFL port.

Tools:

  • DumpRenderTree/efl/EventSender.cpp:

(textZoom):
(pageZoom):
(textZoomInCallback):
(textZoomOutCallback):
(zoomPageInCallback):
(zoomPageOutCallback):

LayoutTests:

  • platform/efl/fast/css/ignore-text-zoom-expected.txt: Added.
  • platform/efl/fast/css/preserve-user-specified-zoom-level-on-reload-expected.txt: Added.
  • platform/efl/fast/images/imagemap-focus-ring-zoom-expected.txt: Added.
  • platform/efl/svg/W3C-I18N/g-dirLTR-ubNone-expected.txt: Added.
  • platform/efl/svg/W3C-I18N/g-dirLTR-ubOverride-expected.txt: Added.
  • platform/efl/svg/W3C-I18N/g-dirRTL-ubNone-expected.txt: Added.
  • platform/efl/svg/W3C-I18N/g-dirRTL-ubOverride-expected.txt: Added.
  • platform/efl/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.txt: Added.
  • platform/efl/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.txt: Added.
  • platform/efl/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.txt: Added.
  • platform/efl/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.txt: Added.
  • platform/efl/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.txt: Added.
  • platform/efl/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.txt: Added.
  • platform/efl/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.txt: Added.
  • platform/efl/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.txt: Added.
  • platform/efl/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.txt: Added.
  • platform/efl/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.txt: Added.
  • platform/efl/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.txt: Added.
  • platform/efl/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.txt: Added.
  • platform/efl/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.txt: Added.
  • platform/efl/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.txt: Added.
  • platform/efl/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.txt: Added.
  • platform/efl/svg/W3C-I18N/text-anchor-no-markup-expected.txt: Added.
  • platform/efl/svg/W3C-I18N/text-dirLTR-ubNone-expected.txt: Added.
  • platform/efl/svg/W3C-I18N/text-dirLTR-ubOverride-expected.txt: Added.
  • platform/efl/svg/W3C-I18N/text-dirRTL-ubNone-expected.txt: Added.
  • platform/efl/svg/W3C-I18N/text-dirRTL-ubOverride-expected.txt: Added.
  • platform/efl/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.txt: Added.
  • platform/efl/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.txt: Added.
  • platform/efl/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.txt: Added.
  • platform/efl/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.txt: Added.
  • platform/efl/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.txt: Added.
  • platform/efl/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.txt: Added.
  • platform/efl/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.txt: Added.
  • platform/efl/svg/W3C-I18N/tspan-dirNone-ubOverride-in-rtl-context-expected.txt: Added.
  • platform/efl/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-default-context-expected.txt: Added.
  • platform/efl/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-ltr-context-expected.txt: Added.
  • platform/efl/svg/W3C-I18N/tspan-dirRTL-ubNone-in-default-context-expected.txt: Added.
  • platform/efl/svg/W3C-I18N/tspan-dirRTL-ubNone-in-ltr-context-expected.txt: Added.
  • platform/efl/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context-expected.txt: Added.
  • platform/efl/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.txt: Added.
  • platform/efl/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.txt: Added.
  • platform/efl/svg/W3C-I18N/tspan-direction-ltr-expected.txt: Added.
  • platform/efl/svg/W3C-I18N/tspan-direction-rtl-expected.txt: Added.
  • platform/efl/svg/as-background-image/animated-svg-as-background-expected.txt: Added.
  • platform/efl/svg/as-background-image/background-image-preserveaspectRatio-support-expected.txt: Added.
  • platform/efl/svg/as-background-image/background-image-tiled-expected.txt: Added.
  • platform/efl/svg/as-background-image/same-image-two-instances-background-image-expected.txt: Added.
  • platform/efl/svg/as-background-image/svg-as-background-2-expected.txt: Added.
  • platform/efl/svg/as-background-image/svg-as-background-6-expected.txt: Added.
  • platform/efl/svg/as-background-image/svg-as-background-expected.txt: Added.
  • platform/efl/svg/as-background-image/svg-as-background-with-relative-size-expected.txt: Added.
  • platform/efl/svg/as-background-image/svg-as-background-with-viewBox-expected.txt: Added.
  • platform/efl/svg/as-background-image/svg-as-tiled-background-expected.txt: Added.
  • platform/efl/svg/as-background-image/svg-background-partial-redraw-expected.txt: Added.
  • platform/efl/svg/as-background-image/svg-width-100p-as-background-expected.txt: Added.
  • platform/efl/svg/as-border-image/svg-as-border-image-2-expected.txt: Added.
  • platform/efl/svg/as-border-image/svg-as-border-image-expected.txt: Added.
  • platform/efl/svg/as-image/animated-svg-as-image-expected.txt: Added.
  • platform/efl/svg/as-image/animated-svg-as-image-no-fixed-intrinsic-size-expected.txt: Added.
  • platform/efl/svg/as-image/animated-svg-as-image-same-image-expected.txt: Added.
  • platform/efl/svg/as-image/img-preserveAspectRatio-support-1-expected.txt: Added.
  • platform/efl/svg/as-image/img-preserveAspectRatio-support-2-expected.txt: Added.
  • platform/efl/svg/as-image/same-image-two-instances-expected.txt: Added.
  • platform/efl/svg/as-image/svg-as-image-expected.txt: Added.
  • platform/efl/svg/as-image/svg-as-relative-image-with-explicit-size-expected.txt: Added.
  • platform/efl/svg/as-image/svg-image-change-content-size-expected.txt: Added.
  • platform/efl/svg/batik/filters/feTile-expected.txt: Added.
  • platform/efl/svg/batik/filters/filterRegions-expected.txt: Added.
  • platform/efl/svg/batik/masking/maskRegions-expected.txt: Added.
  • platform/efl/svg/batik/paints/gradientLimit-expected.txt: Added.
  • platform/efl/svg/batik/paints/patternPreserveAspectRatioA-expected.txt: Added.
  • platform/efl/svg/batik/paints/patternRegionA-expected.txt: Added.
  • platform/efl/svg/batik/paints/patternRegions-expected.txt: Added.
  • platform/efl/svg/batik/paints/patternRegions-positioned-objects-expected.txt: Added.
  • platform/efl/svg/batik/text/longTextOnPath-expected.txt: Added.
  • platform/efl/svg/batik/text/smallFonts-expected.txt: Added.
  • platform/efl/svg/batik/text/textAnchor-expected.txt: Added.
  • platform/efl/svg/batik/text/textAnchor2-expected.txt: Added.
  • platform/efl/svg/batik/text/textAnchor3-expected.txt: Added.
  • platform/efl/svg/batik/text/textDecoration-expected.txt: Added.
  • platform/efl/svg/batik/text/textDecoration2-expected.txt: Added.
  • platform/efl/svg/batik/text/textEffect-expected.txt: Added.
  • platform/efl/svg/batik/text/textEffect2-expected.txt: Added.
  • platform/efl/svg/batik/text/textEffect3-expected.txt: Added.
  • platform/efl/svg/batik/text/textFeatures-expected.txt: Added.
  • platform/efl/svg/batik/text/textGlyphOrientationHorizontal-expected.txt: Added.
  • platform/efl/svg/batik/text/textLayout-expected.txt: Added.
  • platform/efl/svg/batik/text/textLayout2-expected.txt: Added.
  • platform/efl/svg/batik/text/textLength-expected.txt: Added.
  • platform/efl/svg/batik/text/textOnPath-expected.txt: Added.
  • platform/efl/svg/batik/text/textOnPath2-expected.txt: Added.
  • platform/efl/svg/batik/text/textOnPath3-expected.txt: Added.
  • platform/efl/svg/batik/text/textOnPathSpaces-expected.txt: Added.
  • platform/efl/svg/batik/text/textPCDATA-expected.txt: Added.
  • platform/efl/svg/batik/text/textPosition-expected.txt: Added.
  • platform/efl/svg/batik/text/textPosition2-expected.txt: Added.
  • platform/efl/svg/batik/text/textProperties-expected.txt: Added.
  • platform/efl/svg/batik/text/textProperties2-expected.txt: Added.
  • platform/efl/svg/batik/text/textStyles-expected.txt: Added.
  • platform/efl/svg/batik/text/verticalText-expected.txt: Added.
  • platform/efl/svg/batik/text/verticalTextOnPath-expected.txt: Added.
  • platform/efl/svg/batik/text/xmlSpace-expected.txt: Added.
  • platform/efl/svg/carto.net/button-expected.txt: Added.
  • platform/efl/svg/carto.net/colourpicker-expected.txt: Added.
  • platform/efl/svg/carto.net/combobox-expected.txt: Added.
  • platform/efl/svg/carto.net/scrollbar-expected.txt: Added.
  • platform/efl/svg/carto.net/selectionlist-expected.txt: Added.
  • platform/efl/svg/carto.net/slider-expected.txt: Added.
  • platform/efl/svg/carto.net/tabgroup-expected.txt: Added.
  • platform/efl/svg/carto.net/textbox-expected.txt: Added.
  • platform/efl/svg/carto.net/window-expected.txt: Added.
  • platform/efl/svg/clip-path/clip-in-clip-expected.txt: Added.
  • platform/efl/svg/clip-path/clip-in-mask-expected.txt: Added.
  • platform/efl/svg/clip-path/clip-path-child-clipped-expected.txt: Added.
  • platform/efl/svg/clip-path/clip-path-clipped-no-content-expected.txt: Added.
  • platform/efl/svg/clip-path/clip-path-css-transform-1-expected.txt: Added.
  • platform/efl/svg/clip-path/clip-path-css-transform-2-expected.txt: Added.
  • platform/efl/svg/clip-path/clip-path-evenodd-expected.txt: Added.
  • platform/efl/svg/clip-path/clip-path-evenodd-nonzero-expected.txt: Added.
  • platform/efl/svg/clip-path/clip-path-nonzero-evenodd-expected.txt: Added.
  • platform/efl/svg/clip-path/clip-path-nonzero-expected.txt: Added.
  • platform/efl/svg/clip-path/clip-path-pixelation-expected.txt: Added.
  • platform/efl/svg/clip-path/clip-path-recursive-call-by-child-expected.txt: Added.
  • platform/efl/svg/clip-path/clip-path-recursive-call-expected.txt: Added.
  • platform/efl/svg/clip-path/clip-path-text-and-shape-expected.txt: Added.
  • platform/efl/svg/clip-path/clip-path-text-and-stroke-expected.txt: Added.
  • platform/efl/svg/clip-path/clip-path-text-expected.txt: Added.
  • platform/efl/svg/clip-path/clip-path-transform-1-expected.txt: Added.
  • platform/efl/svg/clip-path/clip-path-tspan-and-stroke-expected.txt: Added.
  • platform/efl/svg/clip-path/clip-path-use-as-child2-expected.txt: Added.
  • platform/efl/svg/clip-path/clip-path-use-as-child3-expected.txt: Added.
  • platform/efl/svg/clip-path/clip-path-use-as-child4-expected.txt: Added.
  • platform/efl/svg/clip-path/clip-path-use-as-child5-expected.txt: Added.
  • platform/efl/svg/clip-path/clip-path-with-container-expected.txt: Added.
  • platform/efl/svg/clip-path/clip-path-with-different-unittypes-expected.txt: Added.
  • platform/efl/svg/clip-path/clip-path-with-different-unittypes2-expected.txt: Added.
  • platform/efl/svg/clip-path/clip-path-with-invisibile-child-expected.txt: Added.
  • platform/efl/svg/clip-path/clip-path-with-text-clipped-expected.txt: Added.
  • platform/efl/svg/clip-path/clipper-placement-issue-expected.txt: Added.
  • platform/efl/svg/clip-path/deep-nested-clip-in-mask-different-unitTypes-expected.txt: Added.
  • platform/efl/svg/clip-path/deep-nested-clip-in-mask-expected.txt: Added.
  • platform/efl/svg/clip-path/deep-nested-clip-in-mask-panning-expected.txt: Added.
  • platform/efl/svg/clip-path/nested-clip-in-mask-image-based-clipping-expected.txt: Added.
  • platform/efl/svg/clip-path/nested-clip-in-mask-path-and-image-based-clipping-expected.txt: Added.
  • platform/efl/svg/clip-path/nested-clip-in-mask-path-based-clipping-expected.txt: Added.
  • platform/efl/svg/css/arrow-with-shadow-expected.txt: Added.
  • platform/efl/svg/css/clippath-with-shadow-expected.txt: Added.
9:20 PM Applications using WebKit edited by wesley
(diff)
9:18 PM Applications using WebKit edited by wesley
(diff)
9:00 PM Changeset in webkit [107528] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

CSS3 currentColor on outline-color gets treated as inherit
​https://bugs.webkit.org/show_bug.cgi?id=73180

Patch by David Barr <​davidbarr@chromium.org> on 2012-02-12
Reviewed by Antti Koivisto.

Source/WebCore:

The CSS2 and CSS3 UI modules state that outline-color
is not inherited. Make it so.
​http://www.w3.org/TR/CSS2/ui.html#propdef-outline-color
​http://www.w3.org/TR/css3-ui/#outline-color

Test: fast/css/outline-currentcolor.html

  • css/CSSStyleApplyProperty.cpp:

(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):

LayoutTests:

Adapted fast/css/background-currentcolor.html dumpRenderTree test
for outline-color.

  • fast/css/outline-currentcolor-expected.txt: Added.
  • fast/css/outline-currentcolor.html: Added.
9:00 PM Changeset in webkit [107527] by commit-queue@webkit.org
  • 5 edits in trunk

KeywordLookupGenerator.py script fails in some cases
​https://bugs.webkit.org/show_bug.cgi?id=77886

Patch by Ashod Nakashian <​ashodnakashian@yahoo.com> on 2012-02-12
Reviewed by Benjamin Poulain.

Source/JavaScriptCore:

  • parser/Keywords.table: Converted to LF-only.

Tools:

  • Scripts/webkitpy/style/checker.py: New rule for Keywords.table to not have CR.
  • Scripts/webkitpy/style/checker_unittest.py: New UT for Keywords.table rule.

(GlobalVariablesTest.test_path_rules_specifier):

8:58 PM Changeset in webkit [107526] by Antti Koivisto
  • 8 edits in trunk/Source/WebCore

CSSPageRule should inherit from CSSRule instead of CSSStyleRule
​https://bugs.webkit.org/show_bug.cgi?id=78452

Reviewed by Anders Carlsson.

This matches CSSOM and eliminates the only subclass of CSSStyleRule, enabling further refactoring.

  • css/CSSPageRule.cpp:

(WebCore::CSSPageRule::CSSPageRule):
(WebCore::CSSPageRule::~CSSPageRule):
(WebCore):
(WebCore::CSSPageRule::selectorText):
(WebCore::CSSPageRule::setSelectorText):
(WebCore::CSSPageRule::cssText):

  • css/CSSPageRule.h:

(CSSPageRule):
(WebCore::CSSPageRule::style):
(WebCore::CSSPageRule::selector):
(WebCore::CSSPageRule::properties):
(WebCore::CSSPageRule::adoptSelectorVector):
(WebCore::CSSPageRule::setDeclaration):

  • css/CSSRule.cpp:

(WebCore::CSSRule::cssText):

  • css/CSSStyleRule.cpp:

(WebCore::CSSStyleRule::generateSelectorText):

  • css/CSSStyleSelector.cpp:

(WebCore::RuleSet::pageRules):
(RuleSet):
(WebCore::RuleSet::addPageRule):
(WebCore::comparePageRules):
(WebCore::CSSStyleSelector::matchPageRules):
(WebCore::CSSStyleSelector::matchPageRulesForList):

  • css/CSSStyleSelector.h:

(CSSStyleSelector):

8:15 PM Changeset in webkit [107525] by commit-queue@webkit.org
  • 14 edits
    2 adds in trunk/Source

Introduce ShadowRootList.
​https://bugs.webkit.org/show_bug.cgi?id=78069

Patch by Shinya Kawanaka <​shinyak@google.com> on 2012-02-12
Reviewed by Hajime Morita.

Source/JavaScriptCore:

DoublyLinkedList should have tail() method to take the last element.

  • wtf/DoublyLinkedList.h:

(DoublyLinkedList):
(WTF::::tail):
(WTF):

Source/WebCore:

This is a step to implement multiple shadow subtrees.

This patch introduces a shadow root list. ShadowRootList is a doubly linked list,
and each shadow root now has a younger shadow root and older shadow root,
which are a previous element and a next element respectively.
Since a visual tree traversal, which will be introduced in coming patches, will need a older shadow root,
we make a shadow root list a doubly linked list.

However, ShadowRootList does not have more than one shadow root now.
This will be changed in a series of coming patches.

Element::shadowRoot(), setShadowRoot(), ensureShadowRoot(), and removeShadowRoot() are
emulated using ShadowRootList for a while. These API will be replaced to ShadowRootList API later.

No new tests, no change in behavior.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/DOMAllInOne.cpp:
  • dom/Element.cpp:

(WebCore::Element::hasShadowRoot):

Retruns true if an element has a shadowRoot.

(WebCore::Element::shadowRootList):

Gets shadow root list if any.

(WebCore::Element::shadowRoot):

Gets the first shadow root from the shadow root list.

(WebCore::Element::setShadowRoot):

Sets the first shadow root to the shadow root list.

(WebCore::Element::removeShadowRoot):

Removes all the shadow roots in the shadow root list.

  • dom/Element.h:

(WebCore):
(Element):

  • dom/ElementRareData.h:

(ElementRareData):
(WebCore::ElementRareData::ElementRareData):

Has shadow root lists instead of shadow root.

(WebCore::ElementRareData::~ElementRareData):

  • dom/ShadowRoot.cpp:

(WebCore::ShadowRoot::ShadowRoot):
(WebCore::ShadowRoot::~ShadowRoot):

  • dom/ShadowRoot.h:

(ShadowRoot):
(WebCore::ShadowRoot::youngerShadowRoot):
(WebCore::ShadowRoot::olderShadowRoot):

  • dom/ShadowRootList.cpp: Added.

(WebCore):
(WebCore::ShadowRootList::ShadowRootList):
(WebCore::ShadowRootList::~ShadowRootList):
(WebCore::ShadowRootList::pushShadowRoot):

Adds a shadow root into the list. Currently we limit the list can have only one shadow root.

(WebCore::ShadowRootList::popShadowRoot):

Removes and returns the youngest shadow root if any.

  • dom/ShadowRootList.h: Added.

(WebCore):
(ShadowRootList):
(WebCore::ShadowRootList::hasShadowRoot):
(WebCore::ShadowRootList::youngestShadowRoot):
(WebCore::ShadowRootList::oldestShadowRoot):

7:53 PM Changeset in webkit [107524] by commit-queue@webkit.org
  • 9 edits
    2 adds in trunk

INPUT shouldn't create ShadowRoot dynamically.
​https://bugs.webkit.org/show_bug.cgi?id=77930

Patch by Shinya Kawanaka <​shinyak@google.com> on 2012-02-12
Reviewed by Dimitri Glazkov.

Source/WebCore:

When input type is changed, ShadowRoot was being re-created. This makes it difficult to
support multiple shadow subtrees. This patch makes input re-use the existing shadow root
instead of re-creating a shaow root. A shadow root should be created when an element is created.

Since media control elements are implemented using input elements, these elements should also
create a shadow root in their construction phase.

Test: fast/dom/shadow/input-shadow-nochange.html
Tests related to media controls should be covered by existing tests.

  • html/ColorInputType.cpp:

(WebCore::ColorInputType::createShadowSubtree):

  • html/FileInputType.cpp:

(WebCore::FileInputType::createShadowSubtree):
(WebCore::FileInputType::multipleAttributeChanged):

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::createShadowSubtree):

  • html/InputType.cpp:

(WebCore::InputType::destroyShadowSubtree):

  • html/RangeInputType.cpp:

(WebCore::RangeInputType::createShadowSubtree):

  • html/TextFieldInputType.cpp:

(WebCore::TextFieldInputType::createShadowSubtree):

  • html/shadow/MediaControlElements.cpp: Creates a shadow tree in the construction phase.

(WebCore::MediaControlPanelMuteButtonElement::create):
(WebCore::MediaControlVolumeSliderMuteButtonElement::create):
(WebCore::MediaControlPlayButtonElement::create):
(WebCore::MediaControlSeekForwardButtonElement::create):
(WebCore::MediaControlSeekBackButtonElement::create):
(WebCore::MediaControlRewindButtonElement::create):
(WebCore::MediaControlReturnToRealtimeButtonElement::create):
(WebCore::MediaControlToggleClosedCaptionsButtonElement::create):
(WebCore::MediaControlTimelineElement::create):
(WebCore::MediaControlVolumeSliderElement::create):
(WebCore::MediaControlFullscreenVolumeSliderElement::create):
(WebCore::MediaControlFullscreenButtonElement::create):
(WebCore::MediaControlFullscreenVolumeMinButtonElement::create):
(WebCore::MediaControlFullscreenVolumeMaxButtonElement::create):

LayoutTests:

Ensures cheaging input type does not cause shadow root recreation.

  • fast/dom/shadow/input-shadow-nochange.html: Added.
  • fast/dom/shadow/input-shadow-nochange-expected.txt: Added.
7:35 PM Changeset in webkit [107523] by commit-queue@webkit.org
  • 4 edits
    2 adds in trunk

SVGTRefElement shouldn't create a shadow root dynamically.
​https://bugs.webkit.org/show_bug.cgi?id=77938

Patch by Shinya Kawanaka <​shinyak@google.com> on 2012-02-12
Reviewed by Hajime Morita.

Source/WebCore:

SVGTRefElement creates a shadow root dynamically. This will cause a problem to support
multiple shadow subtrees. So it should be created in a constructor phase.

Test: svg/custom/tref-shadowdom.html

  • svg/SVGTRefElement.cpp:

(WebCore::SVGTRefElement::create):
(WebCore::SVGTRefElement::createShadowSubtree):
(WebCore):
(WebCore::SVGTRefElement::updateReferencedText):

  • svg/SVGTRefElement.h:

(SVGTRefElement):

LayoutTests:

Checks a shadow root exists of tref element in cases xlink:href is set and is not set.

  • svg/custom/tref-shadowdom-expected.txt: Added.
  • svg/custom/tref-shadowdom.html: Added.
7:15 PM Changeset in webkit [107522] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Add toText and isTextNode helpers in Text class.
​https://bugs.webkit.org/show_bug.cgi?id=78140

Unit test case for the new style checker introduced.

Patch by Joe Thomas <​joethomas@motorola.com> on 2012-02-12
Reviewed by Adam Barth.

  • Scripts/webkitpy/style/checkers/cpp_unittest.py:

(CppStyleTest):
(CppStyleTest.test_static_cast_readability): Added a unit test case.

6:15 PM Changeset in webkit [107521] by gyuyoung.kim@samsung.com
  • 2 edits in trunk/Tools

Enable features supported by EFL port in build-webkit.
​https://bugs.webkit.org/show_bug.cgi?id=78348

Reviewed by Ryosuke Niwa.

Sync build-webkit with OptionEfl.cmake, as some features enabled in
OptionEfl.cmake are not enabled in build-webkit.

  • Scripts/build-webkit:
6:12 PM Changeset in webkit [107520] by haraken@chromium.org
  • 20 edits in trunk/Source/WebCore

Unreviewed. Rebaselined run-bindings-tests results.

  • bindings/scripts/test/JS/JSFloat64Array.cpp:

(WebCore):

  • bindings/scripts/test/JS/JSTestActiveDOMObject.cpp:

(WebCore):
(WebCore::JSTestActiveDOMObject::destroy):
(WebCore::JSTestActiveDOMObject::~JSTestActiveDOMObject):

  • bindings/scripts/test/JS/JSTestActiveDOMObject.h:

(JSTestActiveDOMObject):

  • bindings/scripts/test/JS/JSTestCustomNamedGetter.cpp:

(WebCore):
(WebCore::JSTestCustomNamedGetter::destroy):
(WebCore::JSTestCustomNamedGetter::~JSTestCustomNamedGetter):

  • bindings/scripts/test/JS/JSTestCustomNamedGetter.h:

(JSTestCustomNamedGetter):

  • bindings/scripts/test/JS/JSTestEventConstructor.cpp:

(WebCore):
(WebCore::JSTestEventConstructor::destroy):
(WebCore::JSTestEventConstructor::~JSTestEventConstructor):

  • bindings/scripts/test/JS/JSTestEventConstructor.h:

(JSTestEventConstructor):

  • bindings/scripts/test/JS/JSTestEventTarget.cpp:

(WebCore):
(WebCore::JSTestEventTarget::destroy):
(WebCore::JSTestEventTarget::~JSTestEventTarget):

  • bindings/scripts/test/JS/JSTestEventTarget.h:

(JSTestEventTarget):

  • bindings/scripts/test/JS/JSTestInterface.cpp:

(WebCore):
(WebCore::JSTestInterface::destroy):
(WebCore::JSTestInterface::~JSTestInterface):

  • bindings/scripts/test/JS/JSTestInterface.h:

(JSTestInterface):

  • bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:

(WebCore):
(WebCore::JSTestMediaQueryListListener::destroy):
(WebCore::JSTestMediaQueryListListener::~JSTestMediaQueryListListener):

  • bindings/scripts/test/JS/JSTestMediaQueryListListener.h:

(JSTestMediaQueryListListener):

  • bindings/scripts/test/JS/JSTestNamedConstructor.cpp:

(WebCore):
(WebCore::JSTestNamedConstructor::destroy):
(WebCore::JSTestNamedConstructor::~JSTestNamedConstructor):

  • bindings/scripts/test/JS/JSTestNamedConstructor.h:

(JSTestNamedConstructor):

  • bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore):
(WebCore::JSTestObj::destroy):
(WebCore::JSTestObj::~JSTestObj):

  • bindings/scripts/test/JS/JSTestObj.h:

(JSTestObj):

  • bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:

(WebCore):
(WebCore::JSTestSerializedScriptValueInterface::destroy):
(WebCore::JSTestSerializedScriptValueInterface::~JSTestSerializedScriptValueInterface):

  • bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.h:

(JSTestSerializedScriptValueInterface):

5:59 PM Changeset in webkit [107519] by inferno@chromium.org
  • 3 edits
    3 adds in trunk

Regression (r104528): Crash when moving nodes across documents.
​https://bugs.webkit.org/show_bug.cgi?id=78432

Reviewed by Hajime Morita.

Source/WebCore:

Test: fast/dom/node-move-to-new-document-crash-main.html

  • dom/TreeScopeAdopter.cpp:

(WebCore::TreeScopeAdopter::moveTreeToNewScope):
(WebCore::TreeScopeAdopter::moveTreeToNewDocument):
(WebCore::TreeScopeAdopter::moveNodeToNewDocument):

LayoutTests:

  • fast/dom/node-move-to-new-document-crash-main-expected.txt: Added.
  • fast/dom/node-move-to-new-document-crash-main.html: Added.
  • fast/dom/resources/node-move-to-new-document-crash.svg: Added.
5:18 PM Changeset in webkit [107518] by commit-queue@webkit.org
  • 26 edits
    2 copies in trunk/Source

Page should have less intrusive way to associate API implementation objects.
​https://bugs.webkit.org/show_bug.cgi?id=78085

Patch by Hajime Morrita <​morrita@chromium.org> on 2012-02-12
Reviewed by Adam Barth.

Source/WebCore:

Introducing PageSupplement interface to attach behind-the-flag-ish
objects to Page instances.

This change aims to improve modularity of Modules/ entries. With
PageSupplement mechinary, we can eliminate ifdef conditionals from
Page.h/Page.cpp and are able to add Modules/ entries without
touching non-Module WebCore files. WebKit API classes like WebPage
can "provide" these objects dynamically during the Page setup phase.

In this change, DeviceMotionController and
DeviceOrientationController is updated to adopt PageSupplement
inteface for an illustrative purpose because they are going to
move into Modules/ shortly. Other Page associated API backing
objects also should be transformed to PageSupplement family.

Reviewed by Adam Barth.

No new tests. No behavior change.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/DeviceMotionClient.h:

(WebCore):

  • dom/DeviceMotionController.cpp:

(WebCore::DeviceMotionController::supplementName):
(WebCore):
(WebCore::DeviceMotionController::isActiveAt):
(WebCore::provideDeviceMotionTo):

  • dom/DeviceMotionController.h:

(DeviceMotionController):
(WebCore::DeviceMotionController::from):

  • dom/DeviceOrientationClient.h:

(WebCore):

  • dom/DeviceOrientationController.cpp:

(WebCore::DeviceOrientationController::supplementName):
(WebCore):
(WebCore::DeviceOrientationController::isActiveAt):
(WebCore::provideDeviceOrientationTo):

  • dom/DeviceOrientationController.h:

(DeviceOrientationController):
(WebCore::DeviceOrientationController::from):

  • dom/Document.cpp:

(WebCore::Document::suspendActiveDOMObjects):
(WebCore::Document::resumeActiveDOMObjects):

  • history/PageCache.cpp:

(WebCore::logCanCachePageDecision):
(WebCore::PageCache::canCache):

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::addEventListener):
(WebCore::DOMWindow::removeEventListener):
(WebCore::DOMWindow::removeAllEventListeners):

  • page/PageSupplement.cpp:

(WebCore::PageSupplement::~PageSupplement):
(WebCore::PageSupplement::provideTo):
(WebCore::PageSupplement::from):

  • page/PageSupplement.h:
  • page/Page.cpp:

(WebCore::Page::Page):
(WebCore::Page::~Page):
(WebCore::Page::provideSupplement):
(WebCore):
(WebCore::Page::requireSupplement):
(WebCore::Page::notifyDestroyedToSupplements):
(WebCore::Page::PageClients::PageClients):

  • page/Page.h:

(WebCore):
(PageClients):
(Page):

  • svg/graphics/SVGImage.cpp:

(WebCore::SVGImage::dataChanged):

Source/WebKit/chromium:

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::WebViewImpl):

Source/WebKit/mac:

  • WebView/WebView.mm:

(-[WebView _commonInitializationWithFrameName:groupName:]):

Source/WebKit/qt:

  • Api/qwebpage.cpp:

(QWebPagePrivate::QWebPagePrivate):

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp:

(DumpRenderTreeSupportQt::setMockDeviceOrientation):

5:01 PM Changeset in webkit [107517] by commit-queue@webkit.org
  • 2 edits
    1 delete in trunk/Source/WebCore

[chromium/mac] Change the type of webkit_system_interface from static_library to none
​https://bugs.webkit.org/show_bug.cgi?id=78441

This target exists only run an action and to add a dependency to the
action's output to targets depending on webkit_system_interface.
This is what target type 'none' is for. With this, no dummy source
file is needed, and no empty libwebkit_system_interface.a is created.
This also fixes this (harmless) libtool warning:

libtool: warning for library: libwebkit_system_interface.a the table
of contents is empty (no object file members in the library define
global symbols)

Patch by Nico Weber <​nicolasweber@gmx.de> on 2012-02-12
Reviewed by Adam Barth.

  • WebCore.gyp/WebCore.gyp:
  • WebCore.gyp/mac/Empty.cpp: Removed.
4:43 PM Changeset in webkit [107516] by bashi@chromium.org
  • 6 edits
    2 adds
    2 deletes in trunk

If @font-face does not provide an explicit italic/bold variant, regular is used.
​https://bugs.webkit.org/show_bug.cgi?id=34147

Reviewed by Dan Bernstein.

Source/WebCore:

Update @font-face handling code so that it matches @font-face behavior to the current draft of CSS3 Font spec. The original patch was written by ​yusukes@chromium.org.

  • Drops support for "bolder", "lighter", and "all" value. These are no longer allowed.
  • Only allows one value for font-style and font-weight.

Tests: fast/css/font-face-synthetic-bold-italic.html

fast/css/font-face-weight-matching.html

  • css/CSSFontSelector.cpp:

(WebCore::CSSFontSelector::addFontFaceRule): Removed "all", "lighter", "bolder" handling code.
(WebCore::compareFontFaces):Updated the weight matching algortihm.

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue): Replaced parseFontStyle() call with checking primitive values.
(WebCore::CSSParser::parseFontWeight): Changed to allow only primitive values.
(WebCore::CSSParser::createFontFaceRule): Removed checks for font-weight and font-style.
(WebCore::CSSParser::deleteFontFaceOnlyValues): Ditto.

  • css/CSSParser.h: Removed parseFontStyle().

LayoutTests:

Added two tests to make sure font matching algorithm matches the current draft of CSS Fonts Module Level 3, and removed a test which uses obsoleted 'all' value for font-weight and font-style.

  • fast/css/font-face-descriptor-multiple-values-parsing-expected.txt: Removed.
  • fast/css/font-face-descriptor-multiple-values-parsing.html: Removed.
  • fast/css/font-face-synthetic-bold-italic.html: Added.
  • fast/css/font-face-weight-matching.html: Added.
  • platform/chromium/test_expectations.txt: Needs rebaselines.
4:35 PM Writing Layout Tests for DumpRenderTree edited by pdr@google.com
Add missing parenthesis (diff)
3:53 PM Changeset in webkit [107515] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

[Chromium] Avoid unnecessary memset in per-tile layer updater.
​https://bugs.webkit.org/show_bug.cgi?id=78426

Patch by David Reveman <​reveman@chromium.org> on 2012-02-12
Reviewed by Stephen White.

Use our own SkBitmap and call SkBitmap::allocPixels() instead of
letting SkDevice construct a SkBitmap. This avoids an unnecessary
memset otherwise done by SkDevice.

No new tests.

  • platform/graphics/chromium/BitmapSkPictureCanvasLayerTextureUpdater.cpp:

(WebCore::BitmapSkPictureCanvasLayerTextureUpdater::Texture::prepareRect):
(WebCore::BitmapSkPictureCanvasLayerTextureUpdater::Texture::updateRect):

  • platform/graphics/chromium/BitmapSkPictureCanvasLayerTextureUpdater.h:

(Texture):

3:51 PM Changeset in webkit [107514] by kubo@profusion.mobi
  • 2 edits in trunk/Source/JavaScriptCore

[CMake] Move source files in WTF_HEADERS to WTF_SOURCES.
​https://bugs.webkit.org/show_bug.cgi?id=78436

Reviewed by Daniel Bates.

  • wtf/CMakeLists.txt: Move .cpp files from WTF_HEADERS to WTF_SOURCES,

and correctly sort the files which start with 'M'.

3:35 PM Changeset in webkit [107513] by weinig@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Move the NumberOfCores.h/cpp files into the WTF group of JavaScriptCore.xcodeproj.

Rubber-stamped by Anders Carlsson.

12:50 PM Changeset in webkit [107512] by kubo@profusion.mobi
  • 4 edits in trunk/Source/JavaScriptCore

[CMake] Remove unused or empty variable definitions.
​https://bugs.webkit.org/show_bug.cgi?id=78437

Reviewed by Daniel Bates.

  • CMakeLists.txt: Remove unused JavaScriptCore_HEADERS definition.
  • shell/CMakeLists.txt: Remove unused JSC_HEADERS definition.
  • wtf/CMakeLists.txt: Remove empty WTF_LIBRARIES definition, it will

be defined later by Platform*.cmake via LIST(APPEND WTF_LIBRARIES).

10:39 AM Changeset in webkit [107511] by Csaba Osztrogonác
  • 3 edits in trunk/LayoutTests

[Qt] Unreviewed weekend gardening. Update expected files.

  • platform/qt/fast/dom/Window/window-properties-expected.txt:
  • platform/qt/fast/dom/prototype-inheritance-2-expected.txt:
6:14 AM Changeset in webkit [107510] by Carlos Garcia Campos
  • 2 edits in trunk

Unreviewed. Fix GTK+ build after r107454.

  • configure.ac: Disable Mutation observers build on GTK+ until it

can actually build.

3:27 AM Changeset in webkit [107509] by commit-queue@webkit.org
  • 37 edits in trunk

Add toText and isTextNode helpers in Text class.
​https://bugs.webkit.org/show_bug.cgi?id=78140

Source/WebCore:

Added a new helper function toText() in dom/Text.h which does the type casting operation to Text object.
Modified the code to make use of this helper function.

Patch by Joe Thomas <​joethomas@motorola.com> on 2012-02-12
Reviewed by Adam Barth.

No new tests.

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::accessibleNameForNode):

  • bindings/v8/custom/V8NodeCustom.cpp:

(WebCore::toV8Slow):

  • css/SelectorChecker.cpp:

(WebCore::SelectorChecker::checkOneSelector):

  • dom/Attr.cpp:

(WebCore::Attr::childrenChanged):

  • dom/Element.cpp:

(WebCore::Element::recalcStyle):

  • dom/Node.cpp:

(WebCore::Node::normalize):

  • dom/Position.cpp:

(WebCore::Position::containerText):
(WebCore::Position::leadingWhitespacePosition):

  • dom/Range.cpp:

(WebCore::Range::insertNode):
(WebCore::Range::getBorderAndTextQuads):

  • dom/ScriptElement.cpp:

(WebCore::ScriptElement::scriptContent):

  • dom/ShadowRoot.cpp:

(WebCore::ShadowRoot::recalcShadowTreeStyle):

  • dom/Text.h: Added new helper function toText.

(WebCore::toText): new helper function which does the type casting operation to Text object.
(WebCore):

  • editing/ApplyBlockElementCommand.cpp:

(WebCore::isNewLineAtPosition):
(WebCore::ApplyBlockElementCommand::endOfNextParagrahSplittingTextNodesIfNeeded):

  • editing/ApplyStyleCommand.cpp:

(WebCore::ApplyStyleCommand::splitTextAtEnd):
(WebCore::ApplyStyleCommand::splitTextElementAtEnd):
(WebCore::ApplyStyleCommand::joinChildTextNodes):

  • editing/BreakBlockquoteCommand.cpp:

(WebCore::BreakBlockquoteCommand::doApply):

  • editing/CompositeEditCommand.cpp:

(WebCore::CompositeEditCommand::insertNodeAt):
(WebCore::CompositeEditCommand::positionOutsideTabSpan):
(WebCore::CompositeEditCommand::canRebalance):
(WebCore::CompositeEditCommand::rebalanceWhitespaceAt):
(WebCore::CompositeEditCommand::prepareWhitespaceAtPositionForSplit):
(WebCore::CompositeEditCommand::deleteInsignificantText):
(WebCore::CompositeEditCommand::removePlaceholderAt):
(WebCore::CompositeEditCommand::cleanupAfterDeletion):
(WebCore::CompositeEditCommand::breakOutOfEmptyMailBlockquotedParagraph):

  • editing/DeleteSelectionCommand.cpp:

(WebCore::DeleteSelectionCommand::handleGeneralDelete):
(WebCore::DeleteSelectionCommand::fixupWhitespace):

  • editing/Editor.cpp:

(WebCore::Editor::setComposition):

  • editing/InsertLineBreakCommand.cpp:

(WebCore::InsertLineBreakCommand::doApply):

  • editing/InsertParagraphSeparatorCommand.cpp:

(WebCore::InsertParagraphSeparatorCommand::doApply):

  • editing/InsertTextCommand.cpp:

(WebCore::InsertTextCommand::insertTab):

  • editing/MarkupAccumulator.cpp:

(WebCore::MarkupAccumulator::appendStartMarkup):

  • editing/ReplaceSelectionCommand.cpp:

(WebCore::ReplaceSelectionCommand::removeUnrenderedTextNodesAtEnds):
(WebCore::ReplaceSelectionCommand::addSpacesForSmartReplace):
(WebCore::ReplaceSelectionCommand::insertAsListItems):
(WebCore::ReplaceSelectionCommand::performTrivialReplace):

  • editing/htmlediting.cpp:

(WebCore::lineBreakExistsAtPosition):

  • editing/visible_units.cpp:

(WebCore::startPositionForLine):
(WebCore::endPositionForLine):
(WebCore::startOfParagraph):
(WebCore::endOfParagraph):

  • html/HTMLElement.cpp:

(WebCore::replaceChildrenWithFragment):
(WebCore::replaceChildrenWithText):
(WebCore::mergeWithNextTextNode):

  • html/HTMLObjectElement.cpp:

(WebCore::HTMLObjectElement::hasFallbackContent):
(WebCore::HTMLObjectElement::updateDocNamedItem):

  • html/HTMLOptionElement.cpp:

(WebCore::HTMLOptionElement::setText):

  • html/HTMLScriptElement.cpp:

(WebCore::HTMLScriptElement::setText):

  • html/HTMLTextAreaElement.cpp:

(WebCore::HTMLTextAreaElement::defaultValue):

  • html/HTMLTextFormControlElement.cpp:

(WebCore::HTMLTextFormControlElement::innerTextValue):
(WebCore::HTMLTextFormControlElement::valueWithHardLineBreaks):

  • html/HTMLTitleElement.cpp:

(WebCore::HTMLTitleElement::text):
(WebCore::HTMLTitleElement::setText):

  • inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::setNodeValue):

  • rendering/RenderText.cpp:

(WebCore::RenderText::originalText):

  • rendering/RenderTextFragment.cpp:

(WebCore::RenderTextFragment::originalText):
(WebCore::RenderTextFragment::previousCharacter):

Tools:

Added a style checker to use toText rather than static_cast<Text*>.

Patch by Joe Thomas <​joethomas@motorola.com> on 2012-02-12
Reviewed by Adam Barth.

  • Scripts/webkitpy/style/checkers/cpp.py:

(check_language): Style checker for static_cast<Text*>.

3:16 AM Changeset in webkit [107508] by haraken@chromium.org
  • 3 edits in trunk/Source/WebCore

Remove [CPPCustom] from CodeGeneratorCPP.pm
​https://bugs.webkit.org/show_bug.cgi?id=78342

Reviewed by Adam Barth.

This patch removes [CPPCustom].

[CPPCustom] has been used in DOMWindow.location only to indicate that
DOMWindow.location should be ignored in CPP. However, there are many
other attributes and methods that CPP does not support (e.g. [CallWith=...],
[CustomSetter], etc), and they are not yet marked with [CPPCustom].
CPP just generates "meaningless" code for those unsupported attributes
and methods. Ideally we can mark all unsupported attributes and methods
with [CPPCustom], but it would not be so practical. Otherwise, removing
[CPPCustom] would make sense. The side effect of removing [CPPCustom]
is just that CPP will generate "meaningless" code for DOMWindow.location.

No tests. No change in behavior.

  • bindings/scripts/CodeGeneratorCPP.pm:

(ShouldSkipType):

  • page/DOMWindow.idl:
2:53 AM Changeset in webkit [107507] by Philippe Normand
  • 4 edits in trunk/LayoutTests

Unreviewed, rebaseline after r107483 and r107498.

  • fast/dom/wrapper-classes-expected.txt:
  • platform/gtk/fast/dom/Window/window-properties-expected.txt:
  • platform/gtk/fast/dom/prototype-inheritance-2-expected.txt:
2:41 AM Changeset in webkit [107506] by haraken@chromium.org
  • 3 edits in trunk/Source/WebCore

Rename [JSCustomPrototypeDefineOwnProperty] to [JSCustomDefineOwnPropertyOnPrototype]
​https://bugs.webkit.org/show_bug.cgi?id=78354

Reviewed by Adam Barth.

This patch renames [JSCustomPrototypeDefineOwnProperty] to
[JSCustomDefineOwnPropertyOnPrototype], for naming consistency with
[JSCustomDefineOwnProperty] and [JSCustomNamedGetterOnPrototype].

No tests. No change in behavior.

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader):

  • page/Location.idl:
2:23 AM Changeset in webkit [107505] by Philippe Normand
  • 2 edits in trunk/LayoutTests

Unreviewed, skip mutation tests on GTK again after r107504.

  • platform/gtk/Skipped:
2:13 AM Changeset in webkit [107504] by Philippe Normand
  • 2 edits in trunk/Tools

Unreviewed, disable Mutation observers build on GTK until it can
actually build.

  • Scripts/build-webkit:
Note: See TracTimeline for information about the timeline view.