Timeline



Jan 25, 2015:

11:59 PM Changeset in webkit [179106] by ap@apple.com
  • 8 edits
    1 add in trunk/Tools

Would like leaks bot results at build.webkit.org/dashboard
​https://bugs.webkit.org/show_bug.cgi?id=122657

Reviewed by Darin Adler.

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:

Record links provided by buildbot steps. Currently, the dashboard hardcodes more links
than necessary, could use the ones from buildbot in more places.

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:

(BuildbotQueue): Reflect configuration option for leaks queues.

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:

Add leaks queues to performance column. First, leaks are about performance indeed,
and second, this is where we have some space to spare.

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:

(WebKitBuildbot): Added Yosemite Leaks queue, which was sitting neglected for at
least a year.

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:

(table.queue-grid td): Moved height from queue-view - we can now have more than one
queue view per cell. The heigt is needed to avoid ugly overlapping while loading
results - once the results are loaded, all rows are currently higher than that.

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/QueueView.css:

(.leaks-popover): Added.

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotLeaksQueueView.js:

Added.

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/index.html:

Load BuildbotLeaksQueueView.js.

11:10 PM Changeset in webkit [179105] by Chris Dumez
  • 2 edits in trunk/Source/WebCore

Remove 'font' shorthand property special casing
​https://bugs.webkit.org/show_bug.cgi?id=140577

Reviewed by Darin Adler.

Mark CSSPrimitiveValue::m_value.fontFamily as const as it is not
supposed to change. This also makes sure that m_value.fontFamily
gets copied instead of moved when constructing a clone in
CSSPrimitiveValue::cloneForCSSOM(). This was causing several tests
to fail on the bots.

  • css/CSSPrimitiveValue.h:
10:29 PM Changeset in webkit [179104] by dbates@webkit.org
  • 4 edits
    115 moves
    2518 adds in trunk/LayoutTests

[iOS] Update expected results and test expectations

  • platform/ios-simulator-wk1/TestExpectations:
  • platform/ios-simulator-wk2/TestExpectations:
  • platform/ios-simulator/TestExpectations:

[...]

9:01 PM Changeset in webkit [179103] by ap@apple.com
  • 6 edits in trunk/LayoutTests

fast/html/marquee-scrollamount.html is flaky
​https://bugs.webkit.org/show_bug.cgi?id=140851

Reviewed by Darin Adler.

Updated the test to not have a zero delay timer race. Added many comments, because
what is being tested here is quite subtle.

  • fast/html/marquee-scrollamount.html:
  • platform/efl/fast/html/marquee-scrollamount-expected.txt:
  • platform/gtk/fast/html/marquee-scrollamount-expected.txt:
  • platform/ios-simulator-wk2/fast/html/marquee-scrollamount-expected.txt:
  • platform/mac/fast/html/marquee-scrollamount-expected.txt:

The DOM changed slightly, because we now insert the marquee after load event.

8:04 PM Changeset in webkit [179102] by ap@apple.com
  • 3 edits
    2 adds in trunk

Setting HTMLMarqueeElement.trueSpeed doesn't work
​https://bugs.webkit.org/show_bug.cgi?id=140863

Reviewed by Darin Adler.

Source/WebCore:

Test: fast/html/marquee-set-truespeed.html

  • html/HTMLMarqueeElement.cpp: (WebCore::HTMLMarqueeElement::minimumDelay):

Check the boolean attribute properly - an empty value is true.

LayoutTests:

Verify that setting scrollDelay to a value under 60 actually works when trueSpeed is set.

  • fast/html/marquee-set-truespeed-expected.html: Added.
  • fast/html/marquee-set-truespeed.html: Added.
7:22 PM Changeset in webkit [179101] by Darin Adler
  • 7 edits in trunk/Source/WebCore

Streamline SVGUseElement shadow tree handling and make it use SVGElementInstance less
​https://bugs.webkit.org/show_bug.cgi?id=140875

Reviewed by Anders Carlsson.

Refactoring of code that is pretty well covered by existing tests, so
not adding new tests.

Inspired by work Rob Buis did in Blink:

​http://src.chromium.org/viewvc/blink?view=revision&revision=173273

Althgouh that is less than half of what ended up in this patch.

  • dom/ContainerNode.h: Fixed NoEventDispatchAssertion so it can be

copied without causing an underflow of NoEventDispatchAssertion::s_count.
Made the copy constructor call the default constructor. Also changed it
to be based on ASSERT_DISABLED rather than NDEBUG and tweaked it a bit.

  • dom/ElementIteratorAssertions.h: Removed an unnecessary include and

an unnecessary default constructor. Changed to use WTF::Optional instead
of WTF::OwnPtr to handle NoEventDispatchAssertion, which makes this class
copyable and assignable, which in turn makes the iterators based on this
copyable and assignable, which is what I needed in SVGUseElement code.
Also simplified code in a couple places.

  • dom/TypedElementDescendantIterator.h:

(WebCore::TypedElementDescendantIteratorAdapter<ElementType>::from):
Fixed an error where the arguments to Traversal::next were passed backwards.
This led to incomplete iteration in SVGUseElement code, and an immediate
assertion failure. Probably could use some unit test coverage, too.
(WebCore::TypedElementDescendantConstIteratorAdapter<ElementType>::from):
Ditto.

  • svg/SVGUseElement.cpp:

(WebCore::SVGUseElement::animatedInstanceRoot): Deleted.
(WebCore::SVGUseElement::transferSizeAttributesToShadowTreeTargetClone):
Removed the originalElement argument, since we can use the correspondingElement
to get back to it. Removed the useElement argument and changed this into a
member function.
(WebCore::SVGUseElement::svgAttributeChanged): Updated for above changes.
(WebCore::subtreeContainsDisallowedElement): Deleted this function, because
it was only used to optimize by not calling removeDisallowedElementsFromSubtree,
but that function is already similarly efficient when called to do nothing, so
the preflight was not useful.
(WebCore::SVGUseElement::clearResourceReferences): Call userAgentShadowRoot
instead of shadowRoot for clarity.
(WebCore::SVGUseElement::buildPendingResource): Pass a reference instead of
a pointer to buildShadowAndInstanceTree, since it's guaranteed to not be null.
(WebCore::SVGUseElement::shadowTreeTargetClone): Added. Returns the SVG element
inside the shadow tree that corresponds to the use element's target.
(WebCore::SVGUseElement::buildShadowAndInstanceTree): Changed argument type
to a reference instead of a pointer. Removed comments explaining why we have
an instance tree, since soon we will not have one. Removed many comments that
simply state the names of the functions they are commenting on and perhaps a tiny
bit more. Changed to not use m_targetElementInstance as much, dealing with the
shadow tree directly instead of through the instance tree.
(WebCore::SVGUseElement::toClipPath): Use shadowTreeTargetClone instead of
getting at the element through m_targetElementInstance.
(WebCore::SVGUseElement::rendererClipChild): Ditto.
(WebCore::removeDisallowedElementsFromSubtree): Removed the inline keyword,
since there's no good reason to inline thif function's body. Improved local
variable names and used a modern for loop. Also moved the comment about why
this function is used here inside the function instead of repeating it at
each call site.
(WebCore::SVGUseElement::buildShadowTree): Changed to take a reference
instead of a pointer. Moved the check to see if the target is disallowed
out of this function and into buildShadowAndInstanceTree, which needs to
handle that failure explicitly. Tightened up the code a bit, using Ref instead
of RefPtr, putting the comment about removeDisallowedElementsFromSubtree into
that function itself, and removing the unneeded subtreeContainsDisallowedElement
check entirely.
(WebCore::SVGUseElement::expandUseElementsInShadowTree): Removed the argument,
getting the shadow tree from the shadowTree function instead. Walk the tree
iteratively instead of recursively, using the descendantsOfType function.
Rearranged and streamlined the logic.
(WebCore::SVGUseElement::expandSymbolElementsInShadowTree): Ditto.
(WebCore::SVGUseElement::transferEventListenersToShadowTree): Ditto.
(WebCore::SVGUseElement::transferAttributesToShadowTreeReplacement): Renamed
this to avoid the term "replaced element", which is not a reasonable way to
refer to the <g> element in the shadow tree that replaces the <use> element.
Changed the argument type to SVGGElement to make it harder to misuse this
function by accident, and made the use element be "this" instead of passing
it as an argument.
(WebCore::SVGUseElement::selfHasRelativeLengths): Call hasRelativeLengths
on the target inside the shadow tree rather than the original target, which
makes more sense anyway, and is straightforward now that we have the
shadowTreeTargetClone function. Removes use of m_targetElementInstance here.

  • svg/SVGUseElement.h: Updated for above changes.
  • svg/SVGUseElement.idl: Removed animatedInstanceRoot and tweaked formatting.
6:11 PM Changeset in webkit [179100] by Chris Dumez
  • 22 edits
    5 adds in trunk

Remove 'font' shorthand property special casing
​https://bugs.webkit.org/show_bug.cgi?id=140577

Reviewed by Darin Adler.

Source/WebCore:

Expand system font values during 'font' property parsing. The 'font'
CSS property was the only shorthand that wasn't always expanded in
the CSS parser, so it needed a lot of special handling that we can
now get rid of.

This patch is inspired from the following Blink revision:
​https://src.chromium.org/viewvc/blink?view=rev&revision=184449

Tests:

  • fast/css/css2-system-fonts.html (existing)
  • fast/css/CSSPrimitiveValue-font-family-primitiveType.html (new)
  • fast/css/font-systemFontID-parsing.html (new)
  • fast/css/font-shorthand-line-height.html (rebased)
  • WebCore.xcodeproj/project.pbxproj:
  • css/CSSCalculationValue.cpp:

(WebCore::hasDoubleValue):
Handle CSS_FONT_FAMILY similarly to CSS_STRING in the switch.

  • css/CSSFontFamily.h: Added.

Introduce new CSSFontFamily class to store font families inside
CSSPrimitive, instead of using a simple String as previously. We need
an additional 'fromSystemFontID' flag in addition to the font family
name now that system font ID are expanded during parsing. This
information is needed later on by the StyleBuilder (see comment below).

  • css/CSSFontSelector.cpp:

(WebCore::CSSFontSelector::addFontFaceRule):
Update code dealing with font family CSSPrimitiveValues now that they
hold a CSSFontFamily internally instead of a String.

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseSystemFont):
Expand system font values for the 'font' property by asking the
RenderTheme for the system font and using it to set the 'font'
longhand properties.

  • css/CSSParserValues.cpp:

(WebCore::CSSParserValue::createCSSValue):
Handle CSS_FONT_FAMILY value in the switch.

  • css/CSSPrimitiveValue.cpp:

(WebCore::CSSPrimitiveValue::primitiveType):
Make sure we still expose font family CSSPrimitiveValues to the Web as
CSS_STRING, even though we are using a slightly different representation
internally. This is so that we don't change web-exposed behavior and I
added a new layout test to cover this.

(WebCore::isValidCSSUnitTypeForDoubleConversion):
(WebCore::CSSPrimitiveValue::cleanup):
(WebCore::CSSPrimitiveValue::getStringValue):
(WebCore::CSSPrimitiveValue::formatNumberForCustomCSSText):
(WebCore::CSSPrimitiveValue::cloneForCSSOM):
(WebCore::CSSPrimitiveValue::equals):
Handle CSS_FONT_FAMILY type in switches.

  • css/CSSPrimitiveValue.h:

(WebCore::CSSPrimitiveValue::isFontFamily):
Add method to test if a CSSPrimitiveValue holds a CSSFontFamily
internally.

(WebCore::CSSPrimitiveValue::fontFamily):
Add a getter to retrieve the internal CSSFontFamily object if the
primitive type is CSS_FONT_FAMILY.

  • css/CSSPropertyNames.in:

Treat 'font' as a regular shorthand property. Specify its longhand
properties so that makeprop.pl can generate the shorthand code for
us. Also demote 'font' to being a low-priority property as it is
now always expanded during parsing.

  • css/CSSValuePool.cpp:

(WebCore::CSSValuePool::createFontFamilyValue):

  • css/CSSValuePool.h:
  • css/StyleBuilderCustom.h:

(WebCore::StyleBuilderCustom::applyValueFontFamily):

  • Update the 'font-family' value setter in the StyleBuilder to reflect

the changes in the CSS parser. The CSSPrimitiveValues in the list now
have CSS_FONT_FAMILY type instead of CSS_STRING.

  • We also set the 'isGenericFamily' flag if the font-family was expanded from a system font ID (e.g. caption). The 'isGenericFamily' flag is used later on to property set the 'isSpecifiedFont' flag on the FontDescription object. If we don't do this, system font values will be treated as specified fonts, which means that we will no longer use the 'use backslash as Yen sign' hack for those. This is covered by the following layout tests:
    • fast/text/backslash-to-yen-sign-euc.html
    • editing/selection/find-yensign-and-backslash.html

(WebCore::StyleBuilderCustom::applyInitialFont): Deleted.
(WebCore::StyleBuilderCustom::applyInheritFont): Deleted.
(WebCore::StyleBuilderCustom::applyValueFont): Deleted.
Remove StyleBuilder code dealing with the 'font' property. Now that
the 'font' property is always expanded during parsing, this code can
never be reached.

  • css/StylePropertyShorthand.cpp:

(WebCore::isExpandedShorthand):
Stop returning false for 'font' as it is now expanded during parsing
as well. We should probably consider renaming this method to something
else now that all shorthands are expanded, maybe isCSSShorthand() or
isShorthandProperty().

(WebCore::fontShorthand): Deleted.

  • css/StylePropertyShorthand.h:

(WebCore::matchingCustomShorthandsForLonghand): Deleted.
Remove custom shorthand code for the 'font' property as it is now
generated by makeprop.pl, like other shorthands.

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::applyFont): Deleted.
This is unused now that the StyleBuilder code for 'font' has been
removed.

  • css/makeprop.pl:

Remove custom shorthand code for 'font' as it no longer requires any
special handling.

LayoutTests:

  • fast/css/CSSPrimitiveValue-font-family-primitiveType-expected.txt: Added.
  • fast/css/CSSPrimitiveValue-font-family-primitiveType.html: Added.

Add layout test to make sure that the font-family is still exposed to the
Web as a CSSValueList of CSSPrimitiveValues whose primitiveType is
CSS_STRING. This is useful because we now use a slightly different
representation internally.

  • fast/css/font-shorthand-line-height-expected.txt:
  • fast/css/font-shorthand-line-height.html:

Rebaseline the test. This is a progression. Setting the 'font' property
to a system font ID is supposed to reset the line-height property to
'normal'. It previously did not because system font IDs were not
expanded at parsing time. The new behavior is consistent with Chrome and
Firefox as well.

  • fast/css/font-systemFontID-parsing-expected.txt: Added.
  • fast/css/font-systemFontID-parsing.html: Added.

Add a layout test to make sure that the CSS parser is rejecting a 'font'
property with more than one system font id.

4:14 PM Changeset in webkit [179099] by ddkilzer@apple.com
  • 2 edits in branches/safari-600.1.4.15-branch/Source/WebCore

Merged r177449. rdar://problem/19419933

4:14 PM Changeset in webkit [179098] by ddkilzer@apple.com
  • 3 edits in branches/safari-600.1.4.15-branch/Source/WebCore

Merged r177444. rdar://problem/19419933

4:14 PM Changeset in webkit [179097] by ddkilzer@apple.com
  • 2 edits in branches/safari-600.1.4.15-branch/Source/WebKit2

Merged r177332. rdar://problem/19419933

4:14 PM Changeset in webkit [179096] by ddkilzer@apple.com
  • 2 edits in branches/safari-600.1.4.15-branch/Source/WebCore

Merged r177306. rdar://problem/19419933

4:14 PM Changeset in webkit [179095] by ddkilzer@apple.com
  • 18 edits in branches/safari-600.1.4.15-branch/Source

Merged r177301. rdar://problem/19419933

4:14 PM Changeset in webkit [179094] by ddkilzer@apple.com
  • 5 edits
    8 adds in branches/safari-600.1.4.15-branch

Merged r177050. rdar://problem/19419933

4:14 PM Changeset in webkit [179093] by ddkilzer@apple.com
  • 1 edit in branches/safari-600.1.4.15-branch/Source/WebCore/ChangeLog

Merged r177041. rdar://problem/19419933

4:14 PM Changeset in webkit [179092] by ddkilzer@apple.com
  • 29 edits in branches/safari-600.1.4.15-branch

Merged r177035. rdar://problem/19419933

11:40 AM Changeset in webkit [179091] by Brent Fulgham
  • 2 edits in trunk/LayoutTests

[Win] Unreviewed gardening.

Document a few more failures in the expectations file.

  • platform/win/TestExpectations:
11:28 AM Changeset in webkit [179090] by Brent Fulgham
  • 2 edits in trunk/LayoutTests

[Win] Document some Debug crashes in Accessibility code.

  • platform/win/TestExpectations:
10:37 AM Changeset in webkit [179089] by Brent Fulgham
  • 2 edits in trunk/LayoutTests

[Win] Unreviewed gardening.

Skip crashes and timeouts to speed up test runs.

  • platform/win/TestExpectations:
10:01 AM Changeset in webkit [179088] by commit-queue@webkit.org
  • 9 edits
    3 adds in trunk

[Win] Add WebKit message loop interface.
​https://bugs.webkit.org/show_bug.cgi?id=140857

Patch by ​peavo@outlook.com <​peavo@outlook.com> on 2015-01-25
Reviewed by Brent Fulgham.

Added message loop interface which will run the message loop,
and perform required tasks (like calling CFRunLoopRunInMode)
on each iteration of the loop.

Source/WebKit:

  • WebKit.vcxproj/WebKit/WebKit.vcxproj: Added new files to project.
  • WebKit.vcxproj/WebKit/WebKit.vcxproj.filters: Ditto.

Source/WebKit/win:

  • ForEachCoClass.h:
  • Interfaces/WebKit.idl:
  • Interfaces/WebKitMessageLoop.idl: Added.
  • WebKitClassFactory.cpp:
  • WebKitMessageLoop.cpp: Added.

(WebKitMessageLoop::WebKitMessageLoop):
(WebKitMessageLoop::~WebKitMessageLoop):
(WebKitMessageLoop::createInstance):
(WebKitMessageLoop::QueryInterface):
(WebKitMessageLoop::AddRef):
(WebKitMessageLoop::Release):
(WebKitMessageLoop::run):
(WebKitMessageLoop::performMessageLoopTasks):

  • WebKitMessageLoop.h: Added.

Tools:

  • WinLauncher/WinMain.cpp:

(wWinMain): Use new message loop interface.

12:20 AM Changeset in webkit [179087] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebKit2

Unresponsive Web processes sometimes throw ObjC exceptions under didPerformActionMenuHitTest:
​https://bugs.webkit.org/show_bug.cgi?id=140859
<rdar://problem/19571057>

Reviewed by Darin Adler.

  • UIProcess/mac/WKImmediateActionController.mm:

(-[WKImmediateActionController didPerformActionMenuHitTest:userData:]):
If we've already given up on this gesture (either because it was canceled or the
willBeginAnimation timeout expired), we shouldn't build a new animationController for it.
This is true both because it wouldn't look good to swap animationControllers out
from under the gesture, but also because AppKit throws an exception when you do this
and that breaks a lot of things.

12:17 AM Changeset in webkit [179086] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebCore

Long spins under Frame::rangeForPoint when doing Lookup on feedly.com
​https://bugs.webkit.org/show_bug.cgi?id=140862
<rdar://problem/19566089>

Reviewed by Dan Bernstein.

  • page/Frame.cpp:

(WebCore::Frame::rangeForPoint):
If there isn't a selectable text node at the given point, rangeForPoint
will eventually return null. However, we can make it fail much faster
by checking the initial position's text-ness and selectability.

12:02 AM Changeset in webkit [179085] by gyuyoung.kim@samsung.com
  • 2 edits in trunk/LayoutTests

Unreviewed, gardening for EFL port.

  • platform/efl/TestExpectations: media/media-fullscreen-inline.html has been passed since r19100.

Jan 24, 2015:

11:35 PM Changeset in webkit [179084] by Brent Fulgham
  • 16 edits
    13 adds in trunk/LayoutTests

[Win] More rebaselines. (Tables)

  • platform/win/tables/mozilla/bugs/bug1188-expected.png: Added.
  • platform/win/tables/mozilla/bugs/bug1188-expected.txt:
  • platform/win/tables/mozilla/bugs/bug18359-expected.png: Added.
  • platform/win/tables/mozilla/bugs/bug18359-expected.txt:
  • platform/win/tables/mozilla/bugs/bug2479-3-expected.png: Added.
  • platform/win/tables/mozilla/bugs/bug2479-3-expected.txt:
  • platform/win/tables/mozilla/bugs/bug2479-4-expected.png: Added.
  • platform/win/tables/mozilla/bugs/bug2479-4-expected.txt:
  • platform/win/tables/mozilla/bugs/bug29326-expected.png: Added.
  • platform/win/tables/mozilla/bugs/bug29326-expected.txt:
  • platform/win/tables/mozilla/bugs/bug33855-expected.png: Added.
  • platform/win/tables/mozilla/bugs/bug33855-expected.txt:
  • platform/win/tables/mozilla/bugs/bug4382-expected.png: Added.
  • platform/win/tables/mozilla/bugs/bug4382-expected.txt:
  • platform/win/tables/mozilla/bugs/bug4527-expected.txt:
  • platform/win/tables/mozilla/bugs/bug96334-expected.png: Added.
  • platform/win/tables/mozilla/bugs/bug96334-expected.txt:
  • platform/win/tables/mozilla/core/margins-expected.png: Added.
  • platform/win/tables/mozilla/core/margins-expected.txt:
  • platform/win/tables/mozilla/dom/tableDom-expected.png: Added.
  • platform/win/tables/mozilla/dom/tableDom-expected.txt:
  • platform/win/tables/mozilla/other/move_row-expected.txt:
  • platform/win/tables/mozilla_expected_failures/bugs/bug2479-5-expected.png: Added.
  • platform/win/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt:
  • platform/win/tables/mozilla_expected_failures/core/captions1-expected.png: Added.
  • platform/win/tables/mozilla_expected_failures/core/captions1-expected.txt:
  • platform/win/tables/mozilla_expected_failures/core/captions2-expected.png: Added.
  • platform/win/tables/mozilla_expected_failures/core/captions2-expected.txt:
11:14 PM Changeset in webkit [179083] by Brent Fulgham
  • 67 edits
    43 adds in trunk/LayoutTests

[Win] Unreviewed rebaselining.

Second batch: Fast

  • platform/win/fast/block/float/float-avoidance-expected.png: Added.
  • platform/win/fast/block/margin-collapse/103-expected.png: Added.
  • platform/win/fast/canvas/fallback-content-expected.txt:
  • platform/win/fast/css/non-standard-checkbox-size-expected.png: Added.
  • platform/win/fast/css/non-standard-checkbox-size-expected.txt:
  • platform/win/fast/dom/HTMLInputElement/input-slider-update-expected.txt:
  • platform/win/fast/forms/001-expected.png:
  • platform/win/fast/forms/001-expected.txt:
  • platform/win/fast/forms/003-expected.png: Added.
  • platform/win/fast/forms/003-expected.txt:
  • platform/win/fast/forms/004-expected.png: Added.
  • platform/win/fast/forms/004-expected.txt:
  • platform/win/fast/forms/HTMLOptionElement_label01-expected.png: Added.
  • platform/win/fast/forms/HTMLOptionElement_label01-expected.txt:
  • platform/win/fast/forms/HTMLOptionElement_label02-expected.png: Added.
  • platform/win/fast/forms/HTMLOptionElement_label02-expected.txt:
  • platform/win/fast/forms/HTMLOptionElement_label03-expected.png: Added.
  • platform/win/fast/forms/HTMLOptionElement_label03-expected.txt:
  • platform/win/fast/forms/HTMLOptionElement_label04-expected.png: Added.
  • platform/win/fast/forms/HTMLOptionElement_label04-expected.txt:
  • platform/win/fast/forms/HTMLOptionElement_label06-expected.txt:
  • platform/win/fast/forms/HTMLOptionElement_label07-expected.txt:
  • platform/win/fast/forms/basic-inputs-expected.png:
  • platform/win/fast/forms/basic-inputs-expected.txt:
  • platform/win/fast/forms/basic-selects-expected.png:
  • platform/win/fast/forms/basic-selects-expected.txt:
  • platform/win/fast/forms/basic-textareas-quirks-expected.png: Added.
  • platform/win/fast/forms/box-shadow-override-expected.png:
  • platform/win/fast/forms/box-shadow-override-expected.txt:
  • platform/win/fast/forms/control-clip-overflow-expected.png: Added.
  • platform/win/fast/forms/control-clip-overflow-expected.txt:
  • platform/win/fast/forms/control-restrict-line-height-expected.png: Added.
  • platform/win/fast/forms/control-restrict-line-height-expected.txt:
  • platform/win/fast/forms/disabled-select-change-index-expected.png: Added.
  • platform/win/fast/forms/disabled-select-change-index-expected.txt:
  • platform/win/fast/forms/file/file-input-disabled-expected.png:
  • platform/win/fast/forms/file/file-input-disabled-expected.txt:
  • platform/win/fast/forms/form-element-geometry-expected.png: Added.
  • platform/win/fast/forms/form-element-geometry-expected.txt:
  • platform/win/fast/forms/formmove-expected.png: Added.
  • platform/win/fast/forms/formmove-expected.txt:
  • platform/win/fast/forms/indeterminate-expected.png: Added.
  • platform/win/fast/forms/indeterminate-expected.txt:
  • platform/win/fast/forms/input-appearance-height-expected.png: Added.
  • platform/win/fast/forms/input-appearance-height-expected.txt:
  • platform/win/fast/forms/input-appearance-selection-expected.png: Added.
  • platform/win/fast/forms/input-appearance-selection-expected.txt: Added.
  • platform/win/fast/forms/menulist-deselect-update-expected.txt:
  • platform/win/fast/forms/menulist-no-overflow-expected.png: Added.
  • platform/win/fast/forms/menulist-no-overflow-expected.txt:
  • platform/win/fast/forms/menulist-restrict-line-height-expected.png: Added.
  • platform/win/fast/forms/menulist-restrict-line-height-expected.txt:
  • platform/win/fast/forms/menulist-separator-painting-expected.txt:
  • platform/win/fast/forms/menulist-style-color-expected.png:
  • platform/win/fast/forms/menulist-style-color-expected.txt:
  • platform/win/fast/forms/menulist-width-change-expected.txt:
  • platform/win/fast/forms/option-script-expected.txt:
  • platform/win/fast/forms/option-strip-whitespace-expected.png: Added.
  • platform/win/fast/forms/option-strip-whitespace-expected.txt:
  • platform/win/fast/forms/option-text-clip-expected.png:
  • platform/win/fast/forms/option-text-clip-expected.txt:
  • platform/win/fast/forms/range/input-appearance-range-expected.png: Added.
  • platform/win/fast/forms/range/input-appearance-range-expected.txt:
  • platform/win/fast/forms/range/slider-delete-while-dragging-thumb-expected.txt: Added.
  • platform/win/fast/forms/range/slider-mouse-events-expected.txt:
  • platform/win/fast/forms/range/slider-onchange-event-expected.txt: Added.
  • platform/win/fast/forms/range/slider-padding-expected.txt:
  • platform/win/fast/forms/range/slider-thumb-shared-style-expected.png: Added.
  • platform/win/fast/forms/range/slider-thumb-shared-style-expected.txt:
  • platform/win/fast/forms/range/slider-zoomed-expected.txt: Added.
  • platform/win/fast/forms/select-align-expected.png: Added.
  • platform/win/fast/forms/select-align-expected.txt:
  • platform/win/fast/forms/select-background-none-expected.txt:
  • platform/win/fast/forms/select-baseline-expected.png: Added.
  • platform/win/fast/forms/select-baseline-expected.txt:
  • platform/win/fast/forms/select-change-listbox-to-popup-expected.png: Added.
  • platform/win/fast/forms/select-change-listbox-to-popup-expected.txt:
  • platform/win/fast/forms/select-change-popup-to-listbox-expected.png: Added.
  • platform/win/fast/forms/select-change-popup-to-listbox-expected.txt: Added.
  • platform/win/fast/forms/select-disabled-appearance-expected.png: Added.
  • platform/win/fast/forms/select-disabled-appearance-expected.txt:
  • platform/win/fast/forms/select-initial-position-expected.png: Added.
  • platform/win/fast/forms/select-initial-position-expected.txt:
  • platform/win/fast/forms/select-selected-expected.png: Added.
  • platform/win/fast/forms/select-selected-expected.txt:
  • platform/win/fast/forms/select-size-expected.txt:
  • platform/win/fast/forms/select-style-expected.png: Added.
  • platform/win/fast/forms/select-style-expected.txt:
  • platform/win/fast/forms/select-visual-hebrew-expected.txt:
  • platform/win/fast/forms/select-writing-direction-natural-expected.png:
  • platform/win/fast/forms/select-writing-direction-natural-expected.txt:
  • platform/win/fast/forms/select/optgroup-rendering-expected.png:
  • platform/win/fast/forms/select/optgroup-rendering-expected.txt:
  • platform/win/fast/forms/selectlist-minsize-expected.txt:
  • platform/win/fast/forms/stuff-on-my-optgroup-expected.png: Added.
  • platform/win/fast/forms/stuff-on-my-optgroup-expected.txt:
  • platform/win/fast/invalid: Added.
  • platform/win/fast/invalid/014-expected.txt: Added.
  • platform/win/fast/multicol/pagination/RightToLeft-rl-hittest-expected.txt:
  • platform/win/fast/parser: Added.
  • platform/win/fast/parser/entity-comment-in-textarea-expected.txt: Added.
  • platform/win/fast/parser/open-comment-in-textarea-expected.txt: Added.
  • platform/win/fast/repaint/slider-thumb-drag-release-expected.txt:
  • platform/win/fast/replaced/three-selects-break-expected.txt:
  • platform/win/fast/text/international/bidi-menulist-expected.txt:
  • platform/win/fast/text/international/pop-up-button-text-alignment-and-direction-expected.txt:
  • platform/win/fast/text/textIteratorNilRenderer-expected.txt:
9:46 PM Changeset in webkit [179082] by Brent Fulgham
  • 22 edits in trunk/LayoutTests

[Win] Unreviewed baseline update.

First batch: CSS updates.

  • platform/win/css2.1/t09-c5526c-display-00-e-expected.txt:
  • platform/win/css3/selectors3/html/css3-modsel-161-expected.png:
  • platform/win/css3/selectors3/html/css3-modsel-161-expected.txt:
  • platform/win/css3/selectors3/html/css3-modsel-25-expected.png:
  • platform/win/css3/selectors3/html/css3-modsel-25-expected.txt:
  • platform/win/css3/selectors3/html/css3-modsel-70-expected.png:
  • platform/win/css3/selectors3/html/css3-modsel-70-expected.txt:
  • platform/win/css3/selectors3/xhtml/css3-modsel-161-expected.png:
  • platform/win/css3/selectors3/xhtml/css3-modsel-161-expected.txt:
  • platform/win/css3/selectors3/xhtml/css3-modsel-25-expected.png:
  • platform/win/css3/selectors3/xhtml/css3-modsel-25-expected.txt:
  • platform/win/css3/selectors3/xhtml/css3-modsel-70-expected.png:
  • platform/win/css3/selectors3/xhtml/css3-modsel-70-expected.txt:
  • platform/win/css3/selectors3/xml/css3-modsel-161-expected.png:
  • platform/win/css3/selectors3/xml/css3-modsel-161-expected.txt:
  • platform/win/css3/selectors3/xml/css3-modsel-25-expected.png:
  • platform/win/css3/selectors3/xml/css3-modsel-25-expected.txt:
  • platform/win/css3/selectors3/xml/css3-modsel-70-expected.png:
  • platform/win/css3/selectors3/xml/css3-modsel-70-expected.txt:
  • platform/win/fast/block/float/float-avoidance-expected.txt:
  • platform/win/fast/block/margin-collapse/103-expected.txt:
8:36 PM Changeset in webkit [179081] by mitz@apple.com
  • 2 edits in trunk/Tools

update-webkit’s --internal option is unused
​https://bugs.webkit.org/show_bug.cgi?id=140861

Reviewed by Anders Carlsson.

  • Scripts/update-webkit: Removed the option.
7:02 PM Changeset in webkit [179080] by Chris Dumez
  • 2 edits in trunk/Source/WebKit2

[WK2][Cocoa] Drop WKDiagnosticLoggingResultType defines
​https://bugs.webkit.org/show_bug.cgi?id=140838

Reviewed by Sam Weinig.

Drop WKDiagnosticLoggingResultType defines in _WKDiagnosticLoggingDelegate.h
header now that the client-side is correctly using
_WKDiagnosticLoggingResultType instead.

  • UIProcess/API/Cocoa/_WKDiagnosticLoggingDelegate.h:
6:55 PM Changeset in webkit [179079] by Brent Fulgham
  • 26 edits
    81 adds in trunk/LayoutTests

[Win] Unreviewed gardening. Reactivating tests.

Re-enable a series of tests that work properly on Windows. New baselines will be needed.

  • platform/win/TestExpectations:
  • platform/win/css1/box_properties/acid_test-expected.png: Added.
  • platform/win/css1/box_properties/acid_test-expected.txt:
  • platform/win/editing/input/caret-at-the-edge-of-input-expected.txt:
  • platform/win/fast/block/float/float-avoidance-expected.txt:
  • platform/win/fast/block/margin-collapse/103-expected.txt:
  • platform/win/fast/css/box-shadow-and-border-radius-expected.png:
  • platform/win/fast/dynamic/008-expected.txt: Added.
  • platform/win/fast/forms/001-expected.png: Added.
  • platform/win/fast/forms/001-expected.txt:
  • platform/win/fast/forms/003-expected.txt:
  • platform/win/fast/forms/004-expected.txt:
  • platform/win/fast/forms/006-expected.png: Added.
  • platform/win/fast/forms/007-expected.png: Added.
  • platform/win/fast/forms/HTMLOptionElement_label01-expected.txt: Added.
  • platform/win/fast/forms/HTMLOptionElement_label02-expected.txt: Added.
  • platform/win/fast/forms/HTMLOptionElement_label03-expected.txt: Added.
  • platform/win/fast/forms/HTMLOptionElement_label04-expected.txt: Added.
  • platform/win/fast/forms/HTMLOptionElement_label05-expected.txt: Added.
  • platform/win/fast/forms/HTMLOptionElement_label06-expected.txt: Removed property svn:executable.
  • platform/win/fast/forms/HTMLOptionElement_label07-expected.txt: Added.
  • platform/win/fast/forms/basic-buttons-expected.png: Added.
  • platform/win/fast/forms/basic-buttons-expected.txt: Added.
  • platform/win/fast/forms/basic-inputs-expected.png: Added.
  • platform/win/fast/forms/basic-selects-expected.txt:
  • platform/win/fast/forms/basic-textareas-expected.png: Added.
  • platform/win/fast/forms/box-shadow-override-expected.png: Added.
  • platform/win/fast/forms/box-shadow-override-expected.txt: Added.
  • platform/win/fast/forms/button-positioned-expected.txt: Added.
  • platform/win/fast/forms/button-sizes-expected.txt: Added.
  • platform/win/fast/forms/button-style-color-expected.txt: Added.
  • platform/win/fast/forms/button-text-transform-expected.txt: Added.
  • platform/win/fast/forms/control-clip-overflow-expected.txt: Added.
  • platform/win/fast/forms/control-restrict-line-height-expected.txt:
  • platform/win/fast/forms/disabled-select-change-index-expected.txt: Added.
  • platform/win/fast/forms/form-element-geometry-expected.txt: Added.
  • platform/win/fast/forms/hidden-listbox-expected.txt: Added.
  • platform/win/fast/forms/input-appearance-focus-expected.txt: Added.
  • platform/win/fast/forms/input-double-click-selection-gap-bug-expected.txt: Added.
  • platform/win/fast/forms/input-readonly-autoscroll-expected.txt: Added.
  • platform/win/fast/forms/input-text-double-click-expected.txt: Added.
  • platform/win/fast/forms/listbox-hit-test-zoomed-expected.txt: Added.
  • platform/win/fast/forms/listbox-scrollbar-incremental-load-expected.txt: Added.
  • platform/win/fast/forms/listbox-width-change-expected.txt: Added.
  • platform/win/fast/forms/menulist-deselect-update-expected.txt:
  • platform/win/fast/forms/menulist-no-overflow-expected.txt: Added.
  • platform/win/fast/forms/number/number-appearance-rtl-expected.txt: Added.
  • platform/win/fast/forms/number/number-appearance-spinbutton-disabled-readonly-expected.txt: Added.
  • platform/win/fast/forms/number/number-appearance-spinbutton-layer-expected.txt: Added.
  • platform/win/fast/forms/option-strip-whitespace-expected.txt: Added.
  • platform/win/fast/forms/plaintext-mode-2-expected.txt: Added.
  • platform/win/fast/forms/search: Added.
  • platform/win/fast/forms/search/search-size-with-decorations-expected.txt: Added.
  • platform/win/fast/forms/select-align-expected.txt: Added.
  • platform/win/fast/forms/select-baseline-expected.txt: Added.
  • platform/win/fast/forms/select-block-background-expected.txt: Added.
  • platform/win/fast/forms/select-change-listbox-size-expected.txt: Added.
  • platform/win/fast/forms/select-change-listbox-to-popup-expected.txt: Added.
  • platform/win/fast/forms/select-dirty-parent-pref-widths-expected.txt: Added.
  • platform/win/fast/forms/select-disabled-appearance-expected.txt: Added.
  • platform/win/fast/forms/select-initial-position-expected.txt: Added.
  • platform/win/fast/forms/select-item-background-clip-expected.txt: Added.
  • platform/win/fast/forms/select-list-box-with-height-expected.txt: Added.
  • platform/win/fast/forms/select-selected-expected.txt: Added.
  • platform/win/fast/forms/select/optgroup-rendering-expected.txt:
  • platform/win/fast/forms/tabbing-input-iframe-expected.txt: Added.
  • platform/win/fast/frames: Added.
  • platform/win/fast/frames/take-focus-from-iframe-expected.txt: Added.
  • platform/win/fast/multicol/pagination: Added.
  • platform/win/fast/multicol/pagination/LeftToRight-tb-hittest-expected.txt: Added.
  • platform/win/fast/multicol/pagination/RightToLeft-rl-hittest-expected.txt: Added.
  • platform/win/fast/overflow/entity-comment-in-textarea-expected.txt: Added.
  • platform/win/fast/overflow/open-comment-in-textarea-expected.txt: Added.
  • platform/win/fast/overflow/overflow-x-y-expected.txt: Added.
  • platform/win/fast/table/003-expected.txt: Added.
  • platform/win/fast/table/colspanMinWidth-expected.txt: Added.
  • platform/win/fast/table/colspanMinWidth-vertical-expected.txt: Added.
  • platform/win/tables/mozilla/bugs/bug103533-expected.txt: Added.
  • platform/win/tables/mozilla/bugs/bug1188-expected.txt: Added.
  • platform/win/tables/mozilla/bugs/bug12384-expected.txt: Added.
  • platform/win/tables/mozilla/bugs/bug1318-expected.txt: Added.
  • platform/win/tables/mozilla/bugs/bug18359-expected.txt:
  • platform/win/tables/mozilla/bugs/bug2479-2-expected.txt: Added.
  • platform/win/tables/mozilla/bugs/bug26178-expected.txt:
  • platform/win/tables/mozilla/bugs/bug28928-expected.txt:
  • platform/win/tables/mozilla/bugs/bug29326-expected.txt: Added.
  • platform/win/tables/mozilla/bugs/bug30559-expected.txt:
  • platform/win/tables/mozilla/bugs/bug30692-expected.txt: Added.
  • platform/win/tables/mozilla/bugs/bug33855-expected.txt:
  • platform/win/tables/mozilla/bugs/bug4382-expected.txt: Added.
  • platform/win/tables/mozilla/bugs/bug4429-expected.txt:
  • platform/win/tables/mozilla/bugs/bug44505-expected.txt: Added.
  • platform/win/tables/mozilla/bugs/bug51037-expected.txt:
  • platform/win/tables/mozilla/bugs/bug55545-expected.txt: Added.
  • platform/win/tables/mozilla/bugs/bug92647-2-expected.txt: Added.
  • platform/win/tables/mozilla/bugs/bug96334-expected.txt: Added.
  • platform/win/tables/mozilla/bugs/bug99948-expected.txt: Added.
  • platform/win/tables/mozilla/core: Added.
  • platform/win/tables/mozilla/core/bloomberg-expected.txt: Added.
  • platform/win/tables/mozilla/core/margins-expected.txt: Added.
  • platform/win/tables/mozilla/dom/tableDom-expected.txt:
  • platform/win/tables/mozilla/marvin/x_col_align_justify-expected.png: Added.
  • platform/win/tables/mozilla_expected_failures/bugs/bug1725-expected.txt:
  • platform/win/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt:
  • platform/win/tables/mozilla_expected_failures/bugs/bug45621-expected.txt: Added.
  • platform/win/tables/mozilla_expected_failures/bugs/bug58402-2-expected.txt:
5:28 PM Changeset in webkit [179078] by ddkilzer@apple.com
  • 2 edits in branches/safari-600.1.4.15-branch/Source/WebCore

Merged r176725. rdar://problem/19432746

5:28 PM Changeset in webkit [179077] by ddkilzer@apple.com
  • 5 edits in branches/safari-600.1.4.15-branch/Source/WebCore

Merged 'resolvedURL' changes from r176108. rdar://problem/19432746

4:54 PM Changeset in webkit [179076] by ddkilzer@apple.com
  • 2 edits in branches/safari-600.1.4.15-branch/Source/WebCore

Merged r176475. rdar://problem/19450119

4:54 PM Changeset in webkit [179075] by ddkilzer@apple.com
  • 2 edits in branches/safari-600.1.4.15-branch/Source/WebCore

Merged r175251. rdar://problem/19450119

4:08 PM Changeset in webkit [179074] by Brent Fulgham
  • 2 edits in trunk/Tools

DumpRenderTree needs to run with Windows native controls on Windows
​https://bugs.webkit.org/show_bug.cgi?id=25592

Reviewed by Anders Carlsson.

  • DumpRenderTree/win/DumpRenderTree.cpp:

(resetWebPreferencesToConsistentValues): Tell DRT to use native controls.
(prepareConsistentTestingEnvironment): Ditto.

12:36 PM Changeset in webkit [179073] by ddkilzer@apple.com
  • 4 edits in branches/safari-600.1.4.15-branch/Source/WebKit2

Merged r176382. rdar://problem/19419810

12:30 PM Changeset in webkit [179072] by ddkilzer@apple.com
  • 3 edits
    2 adds in branches/safari-600.1.4.15-branch

Merged r176321. rdar://problem/19369495

12:16 PM Changeset in webkit [179071] by ddkilzer@apple.com
  • 8 edits
    2 adds in branches/safari-600.1.4.15-branch

Merged r176262. rdar://problem/19432679

12:16 PM Changeset in webkit [179070] by ddkilzer@apple.com
  • 2 edits in branches/safari-600.1.4.15-branch/Source/WebCore

Merged r175260. rdar://problem/19432679

11:55 AM Changeset in webkit [179069] by Darin Adler
  • 7 edits
    6 adds in trunk

Move height/width implementation for use element from RenderSVGViewportContainer to SVGUseElement
​https://bugs.webkit.org/show_bug.cgi?id=140826

Reviewed by Anders Carlsson.

Source/WebCore:

Tests: svg/animations/use-animate-width-and-height.html

svg/custom/use-attribute-invalidations.html
svg/custom/use-dynamic-attribute-setting.html

This is an adaptation of work Rob Buis did in Blink:

​http://src.chromium.org/viewvc/blink?view=revision&revision=173258

The goal here is to reduce use of SVGElementInstance since we are going to
remove it. The tests Rob added to Blink (which I believe I improved a bit here)
meant we had to fix quite a few bugs in the implementation of the width/height
logic rather than just moving it. Even so, this could use even more test coverage
since there is separate logic for <symbol> and <svg>, three different code paths
(animation/attribute setting, initial creation, and one other), and also
distinct issues for attributes not set at all, attributes set to values that
can't be parsed, and attributes set with different units.

  • rendering/svg/RenderSVGViewportContainer.cpp:

(WebCore::RenderSVGViewportContainer::calcViewport): Removed the old logic.

  • svg/SVGSVGElement.cpp:

(WebCore::SVGSVGElement::SVGSVGElement): Use ASCIILiteral to more efficiently
create strings from ASCII literals here.
(WebCore::SVGSVGElement::parseAttribute): Default to 100%, not 0, when the
width or height property are either not set or not successfully parsed. Without
this change, one of the SVG tests starts failing.

  • svg/SVGUseElement.cpp:

(WebCore::updateWidthAndHeight): Added. The tricky part here is that we have
to copy width and height attributes only if they were successfully parsed, and
also we need to copy the current animating values, not the original attribute
strings. Kind of messy, but I wanted to adapt Rob's solution for the time being,
rather than inventing something new.
(WebCore::SVGUseElement::svgAttributeChanged): Call updateWidthAndHeight.
This is used both when actual attribute changes occur and also when animation
changes the current value.
(WebCore::SVGUseElement::buildShadowAndInstanceTree): Call updateWidthAndHeight.
This is used when the shadow elements are first created.
(WebCore::SVGUseElement::expandUseElementsInShadowTree): Call updateWidthAndHeight.
This was in Rob's patch, but I am not sure we have sufficient test coverage.

LayoutTests:

  • platform/mac/svg/custom/relative-sized-shadow-tree-content-with-symbol-expected.png: Old test

result was expecting failure. New one expects success.

  • platform/mac/svg/custom/relative-sized-shadow-tree-content-with-symbol-expected.txt: Ditto.
  • svg/animations/use-animate-width-and-height-expected.txt: Added.
  • svg/animations/use-animate-width-and-height.html: Added.
  • svg/custom/use-attribute-invalidations-expected.html: Added.
  • svg/custom/use-attribute-invalidations.html: Added.
  • svg/custom/use-dynamic-attribute-setting-expected.html: Added.
  • svg/custom/use-dynamic-attribute-setting.html: Added.
11:14 AM Changeset in webkit [179068] by ddkilzer@apple.com
  • 3 edits in branches/safari-600.1.4.15-branch/Source/WebCore

Merged r175976. rdar://problem/19420064

10:57 AM Changeset in webkit [179067] by ddkilzer@apple.com
  • 3 edits in branches/safari-600.1.4.15-branch/Source/WebCore

Merged r175585. rdar://problem/19419818

10:30 AM Changeset in webkit [179066] by ddkilzer@apple.com
  • 2 edits in branches/safari-600.1.4.15-branch/Source/WebKit2

Merged small change from r175549. rdar://problem/19433134

9:27 AM Changeset in webkit [179065] by ddkilzer@apple.com
  • 3 edits
    2 adds in branches/safari-600.1.4.15-branch

Merged r174860. rdar://problem/19419859

9:00 AM Changeset in webkit [179064] by ddkilzer@apple.com
  • 3 edits
    7 adds in branches/safari-600.1.4.15-branch

Merged r175085. rdar://problem/19419853

9:00 AM Changeset in webkit [179063] by ddkilzer@apple.com
  • 5 edits in branches/safari-600.1.4.15-branch/Source/WebCore

Merged r174356. rdar://problem/19419853

9:00 AM Changeset in webkit [179062] by ddkilzer@apple.com
  • 3 edits in branches/safari-600.1.4.15-branch/Source/WebCore

Merged branch-only patch (r0). rdar://problem/19564738

8:28 AM Changeset in webkit [179061] by Chris Dumez
  • 4 edits in trunk/Source

Provide implementation for WTF::DefaultHash<bool>
​https://bugs.webkit.org/show_bug.cgi?id=140848

Reviewed by Anders Carlsson.

Source/WebCore:

Use HashMap<std::pair<UChar32, bool>> type in Font.cpp for
CharacterFallbackMap instead of HashMap<std::pair<UChar32, unsigned>>.
It builds now that WTF::DefaultHash<bool> is defined in WTF.

  • platform/graphics/Font.cpp:

(WebCore::Font::removeFromSystemFallbackCache):

Source/WTF:

Provide implementation for WTF::DefaultHash<bool> so that we can use
HashMap<std::pair<XXX, bool>> in the code base. Right now, we need to
use some integer type to work around the issue.

  • wtf/HashFunctions.h:

Jan 23, 2015:

11:05 PM Changeset in webkit [179060] by Brent Fulgham
  • 1 edit
    1 add in trunk/LayoutTests

[Win] Unreviewed gardening. Add Windows baseline for
mouse-cursor-image-set.

  • platform/win/fast/events/mouse-cursor-image-set-expected.txt: Added.
11:04 PM Changeset in webkit [179059] by Brent Fulgham
  • 2 edits in trunk/Source/WebCore

[Win] Cursor assignment operator is skipping scale factor
​https://bugs.webkit.org/show_bug.cgi?id=140852

Reviewed by Chris Dumez.

Found by fast/events/mouse-cursor-image-set.html

  • platform/win/CursorWin.cpp:

(WebCore::Cursor::operator=): Make sure to also assign the
scale factor.

9:36 PM Changeset in webkit [179058] by ddkilzer@apple.com
  • 2 edits in trunk/Source/WebCore

[iOS] Attempt to fix the build after AVValueTiming.h moved

  • platform/spi/ios/AVKitSPI.h: The AVValueTiming.h header moved

to an unexpected location, so work around it by using local SPI
declarations.

9:33 PM Changeset in webkit [179057] by ap@apple.com
  • 2 edits in trunk/Source/WebCore

Try to fix the build after r179056.

  • platform/Cursor.h: (WebCore::Cursor::Cursor): Initialize dadat members in correct order.
9:26 PM Changeset in webkit [179056] by Brent Fulgham
  • 3 edits in trunk/Source/WebCore

[Win] Cursor copy constructor does not initialize scale factor
​https://bugs.webkit.org/show_bug.cgi?id=140849

Reviewed by Antti Koivisto.

Found by fast/events/mouse-cursor-image-set.html

Make sure the scale factor is captured during copy construction. Also make sure
it is properly initialized in the default constructor, since it it used in the
Windows port for some default cursors.

  • platform/CursorWin.h:
  • platform/win/CursorWin.cpp:

(WebCore::Cursor::Cursor): Make sure copy constructor captures
the scale factor.

8:15 PM Changeset in webkit [179055] by benjamin@webkit.org
  • 10 edits
    42 adds in trunk

Add pointer/hover media queries
​https://bugs.webkit.org/show_bug.cgi?id=134822

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2015-01-23
Reviewed by Antti Koivisto.

Source/WebCore:

Media Queries Level 4 introduces two types of Interaction Media Features:
"pointer" and "hover". Those media features are useful for adapting the design
to the type of input:

​http://dev.w3.org/csswg/mediaqueries-4/#mf-interaction

This implementation is trivial: just #ifdef the return value depending on
the support for touch events.
In the future we should move that to a client interface but let's start easy
for now.

Tests: fast/media/mq-any-hover-cssom.html

fast/media/mq-any-hover-invalid.html
fast/media/mq-any-hover-matchMedia.html
fast/media/mq-any-hover-styling.html
fast/media/mq-any-pointer-cssom.html
fast/media/mq-any-pointer-invalid.html
fast/media/mq-any-pointer-matchMedia.html
fast/media/mq-any-pointer-styling.html
fast/media/mq-hover-cssom.html
fast/media/mq-hover-invalid.html
fast/media/mq-hover-matchMedia.html
fast/media/mq-hover-styling.html
fast/media/mq-pointer-cssom.html
fast/media/mq-pointer-invalid.html
fast/media/mq-pointer-matchMedia.html
fast/media/mq-pointer-styling.html

  • css/CSSValueKeywords.in:
  • css/MediaFeatureNames.h:
  • css/MediaQueryEvaluator.cpp:

(WebCore::hoverMediaFeatureEval):
(WebCore::any_hoverMediaFeatureEval):
(WebCore::pointerMediaFeatureEval):
(WebCore::any_pointerMediaFeatureEval):
(WebCore::leastCapablePrimaryPointerDeviceType): Deleted.

  • css/MediaQueryExp.cpp:

(WebCore::featureWithCSSValueID):
(WebCore::featureWithZeroOrOne):
(WebCore::featureWithoutValue):

  • page/EventHandler.cpp:

(WebCore::EventHandler::dispatchFakeMouseMoveEventSoon):
(WebCore::EventHandler::fakeMouseMoveEventTimerFired):

  • page/Settings.in:

LayoutTests:

  • fast/media/mq-any-hover-cssom-expected.txt: Added.
  • fast/media/mq-any-hover-cssom.html: Added.
  • fast/media/mq-any-hover-invalid-expected.txt: Added.
  • fast/media/mq-any-hover-invalid.html: Added.
  • fast/media/mq-any-hover-matchMedia-expected.txt: Added.
  • fast/media/mq-any-hover-matchMedia.html: Added.
  • fast/media/mq-any-hover-styling-expected.txt: Added.
  • fast/media/mq-any-hover-styling.html: Added.
  • fast/media/mq-any-pointer-cssom-expected.txt: Added.
  • fast/media/mq-any-pointer-cssom.html: Added.
  • fast/media/mq-any-pointer-invalid-expected.txt: Added.
  • fast/media/mq-any-pointer-invalid.html: Added.
  • fast/media/mq-any-pointer-matchMedia-expected.txt: Added.
  • fast/media/mq-any-pointer-matchMedia.html: Added.
  • fast/media/mq-any-pointer-styling-expected.txt: Added.
  • fast/media/mq-any-pointer-styling.html: Added.
  • fast/media/mq-hover-cssom-expected.txt: Added.
  • fast/media/mq-hover-cssom.html: Added.
  • fast/media/mq-hover-invalid-expected.txt: Added.
  • fast/media/mq-hover-invalid.html: Added.
  • fast/media/mq-hover-matchMedia-expected.txt: Added.
  • fast/media/mq-hover-matchMedia.html: Added.
  • fast/media/mq-hover-styling-expected.txt: Added.
  • fast/media/mq-hover-styling.html: Added.
  • fast/media/mq-pointer-cssom-expected.txt: Added.
  • fast/media/mq-pointer-cssom.html: Added.
  • fast/media/mq-pointer-expected.txt:
  • fast/media/mq-pointer-invalid-expected.txt: Added.
  • fast/media/mq-pointer-invalid.html: Added.
  • fast/media/mq-pointer-matchMedia-expected.txt: Added.
  • fast/media/mq-pointer-matchMedia.html: Added.
  • fast/media/mq-pointer-styling-expected.txt: Added.
  • fast/media/mq-pointer-styling.html: Added.
  • fast/media/mq-pointer.html:
  • platform/ios-simulator/fast/media/mq-any-hover-matchMedia-expected.txt: Added.
  • platform/ios-simulator/fast/media/mq-any-hover-styling-expected.txt: Added.
  • platform/ios-simulator/fast/media/mq-any-pointer-matchMedia-expected.txt: Added.
  • platform/ios-simulator/fast/media/mq-any-pointer-styling-expected.txt: Added.
  • platform/ios-simulator/fast/media/mq-hover-matchMedia-expected.txt: Added.
  • platform/ios-simulator/fast/media/mq-hover-styling-expected.txt: Added.
  • platform/ios-simulator/fast/media/mq-pointer-expected.txt: Added.
  • platform/ios-simulator/fast/media/mq-pointer-matchMedia-expected.txt: Added.
  • platform/ios-simulator/fast/media/mq-pointer-styling-expected.txt: Added.
7:05 PM Changeset in webkit [179054] by commit-queue@webkit.org
  • 20 edits
    6 deletes in trunk

Unreviewed, rolling out r179051.
​https://bugs.webkit.org/show_bug.cgi?id=140850

broke the 32-bit build (Requested by thorton on #webkit).

Reverted changeset:

"[Mac][EME] Support ClearKey encryption with AES128-encrypted
HLS"
​https://bugs.webkit.org/show_bug.cgi?id=140825
​http://trac.webkit.org/changeset/179051

6:34 PM Changeset in webkit [179053] by commit-queue@webkit.org
  • 9 edits in trunk/Source

Web Inspector: Rename InjectedScriptHost::type to subtype
​https://bugs.webkit.org/show_bug.cgi?id=140841

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-01-23
Reviewed by Timothy Hatcher.

Source/JavaScriptCore:

We were using this to set the subtype of an "object" type RemoteObject
so we should clean up the name and call it subtype.

  • inspector/InjectedScriptHost.h:
  • inspector/InjectedScriptSource.js:
  • inspector/JSInjectedScriptHost.cpp:

(Inspector::JSInjectedScriptHost::subtype):
(Inspector::JSInjectedScriptHost::type): Deleted.

  • inspector/JSInjectedScriptHost.h:
  • inspector/JSInjectedScriptHostPrototype.cpp:

(Inspector::JSInjectedScriptHostPrototype::finishCreation):
(Inspector::jsInjectedScriptHostPrototypeFunctionSubtype):
(Inspector::jsInjectedScriptHostPrototypeFunctionType): Deleted.

Source/WebCore:

  • inspector/WebInjectedScriptHost.cpp:

(WebCore::WebInjectedScriptHost::subtype):
(WebCore::WebInjectedScriptHost::type): Deleted.

  • inspector/WebInjectedScriptHost.h:
6:27 PM Changeset in webkit [179052] by Antti Koivisto
  • 3 edits in trunk/Source/WebKit2

Implement cache size limit
​https://bugs.webkit.org/show_bug.cgi?id=140844

Reviewed by Andreas Kling.

Prevent the cache from growing without bounds. The simple scheme implemented here
estimates the cache size from number of entries. When the estimated size exceeds
the maximum size we randomly clear 1/4 of the entries.

  • NetworkProcess/cache/NetworkCacheStorage.h:
  • NetworkProcess/cache/NetworkCacheStorageCocoa.mm:

(WebKit::NetworkCacheStorage::NetworkCacheStorage):
(WebKit::NetworkCacheStorage::initialize):
(WebKit::NetworkCacheStorage::removeEntry):
(WebKit::NetworkCacheStorage::store):
(WebKit::NetworkCacheStorage::setMaximumSize):
(WebKit::NetworkCacheStorage::clear):
(WebKit::NetworkCacheStorage::shrinkIfNeeded):
(WebKit::NetworkCacheStorage::initializeKeyFilter): Deleted.

6:20 PM Changeset in webkit [179051] by jer.noble@apple.com
  • 20 edits
    3 copies
    10 adds in trunk

[Mac][EME] Support ClearKey encryption with AES128-encrypted HLS
​https://bugs.webkit.org/show_bug.cgi?id=140825

Reviewed by Eric Carlson.

Source/WebCore:

Test: http/tests/media/clearkey/clear-key-hls-aes128.html

Add support for ClearKey encryption when used with an AES-128 encrypted HLS stream.

  • Modules/encryptedmedia/CDM.cpp:

(WebCore::installedCDMFactories): Add the CDMPrivateClearKey factory.

  • Modules/encryptedmedia/CDMPrivateClearKey.cpp:

(WebCore::CDMPrivateClearKey::supportsKeySystem): Support the "org.w3c.clearkey" key system.
(WebCore::CDMPrivateClearKey::supportsKeySystemAndMimeType): Ditto.
(WebCore::CDMPrivateClearKey::supportsMIMEType): Ditto.
(WebCore::CDMPrivateClearKey::createSession): Create a CDMSessionClearKey.

  • Modules/encryptedmedia/CDMPrivateClearKey.h:

(WebCore::CDMPrivateClearKey::create): Simple factory.
(WebCore::CDMPrivateClearKey::~CDMPrivateClearKey): Virtual destructor.
(WebCore::CDMPrivateClearKey::CDMPrivateClearKey): Simple destructor.

  • Modules/encryptedmedia/CDMSessionClearKey.cpp: Added.

(WebCore::clearKeyVM): Static method returning the VM to be used by JSON parsing.
(WebCore::CDMSessionClearKey::CDMSessionClearKey): Simple constructor.
(WebCore::CDMSessionClearKey::~CDMSessionClearKey): Simple destructor.
(WebCore::CDMSessionClearKey::generateKeyRequest): Store the initData, ensure that it consists of a UTF8-encoded key

URI, and return same.

(WebCore::CDMSessionClearKey::releaseKeys): Purged all cached keys.
(WebCore::CDMSessionClearKey::update): Parse raw JSON-encoded JWK keys, rejecting non-AES, non-oct keys.
(WebCore::CDMSessionClearKey::cachedKeyForKeyID): Return cached keys.

  • Modules/encryptedmedia/CDMSessionClearKey.h:

Add support for the "org.w3c.clearkey" CDM to MediaPlayerPrivateAVFoundationObjC, and do so in a platform-agnostic
way by simply asking for raw key data from MediaPlayerClient when notified that a key has been added.

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::keySystemIsSupported):
(WebCore::MediaPlayerPrivateAVFoundationObjC::supportsType):
(WebCore::MediaPlayerPrivateAVFoundationObjC::supportsKeySystem):
(WebCore::fulfillRequestWithKeyData): Added utility method.
(WebCore::MediaPlayerPrivateAVFoundationObjC::shouldWaitForLoadingOfResource):
(WebCore::MediaPlayerPrivateAVFoundationObjC::keyAdded):

Pipe a keyAdded() notification down to MediaPlayer and a cachedKeyForKeyId() request up to CDMSessionClearKey:

  • Modules/encryptedmedia/MediaKeySession.cpp:

(WebCore::MediaKeySession::cachedKeyForKeyId):
(WebCore::MediaKeySession::addKeyTimerFired):

  • Modules/encryptedmedia/MediaKeySession.h:
  • Modules/encryptedmedia/MediaKeys.cpp:

(WebCore::MediaKeys::keyAdded):
(WebCore::MediaKeys::cachedKeyForKeyId):

  • Modules/encryptedmedia/MediaKeys.h:
  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::keyAdded):

  • html/HTMLMediaElement.h:
  • platform/graphics/CDMSession.h:

(WebCore::CDMSession::cachedKeyForKeyID):

  • platform/graphics/MediaPlayer.cpp:

(WebCore::MediaPlayer::keyAdded):
(WebCore::MediaPlayer::cachedKeyForKeyId):

  • platform/graphics/MediaPlayer.h:

(WebCore::MediaPlayerClient::mediaPlayerCachedKeyForKeyId):

  • platform/graphics/MediaPlayerPrivate.h:

(WebCore::MediaPlayerPrivateInterface::keyAdded):

Add new files to project:

  • WebCore.xcodeproj/project.pbxproj:
  • CMakeLists.txt:
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:

LayoutTests:

  • http/tests/media/clearkey/clear-key-hls-aes128-expected.txt: Added.
  • http/tests/media/clearkey/clear-key-hls-aes128.html: Added.
  • http/tests/media/clearkey/support.js: Added.

(stringToUInt8Array):
(uInt8ArrayToString):
(base64EncodeUint8Array):

  • http/tests/media/resources/hls/clearkey/crypt0.key: Added.
  • http/tests/media/resources/hls/clearkey/iframe_index.m3u8: Added.
  • http/tests/media/resources/hls/clearkey/main0.ts: Added.
  • http/tests/media/resources/hls/clearkey/prog_index.m3u8: Added.
  • media/video-test.js:

(waitForEventOnceOn):

5:41 PM Changeset in webkit [179050] by Chris Dumez
  • 15 edits in trunk/Source/WebCore

Implement system fonts FontDescription caching at RenderTheme level
​https://bugs.webkit.org/show_bug.cgi?id=140840

Reviewed by Andreas Kling.

Implement system fonts FontDescription caching at RenderTheme level
instead of duplicating the logic in its subclasses for each platform.
This reduces code / logic duplication and reduces the amount of
platform-specific code. This will also make the refactoring at
Bug 140577 a lot easier.

The caching logic remains in RenderThemeIOS class for iOS because:

  • It supports different system font values than all other platforms
  • It requires cache invalidation in some cases while other platforms do not.

This patch is inspired by the following Blink revision:
​https://src.chromium.org/viewvc/blink?view=rev&revision=184449

Test: fast/css/css2-system-fonts.html

5:38 PM Changeset in webkit [179049] by Brent Fulgham
  • 2 edits in trunk/LayoutTests

[Win] Unreviewed gardening: Correct some typos in Failure entries.

  • platform/win/TestExpectations:
5:13 PM Changeset in webkit [179048] by Alan Bujtas
  • 2 edits in trunk/Source/WebCore

Simple line layout: Refactor line wrapping logic.
​https://bugs.webkit.org/show_bug.cgi?id=140834

Reviewed by Antti Koivisto.

Use a more readable structure to deal with wrapping logic.

No change in functionality.

  • rendering/SimpleLineLayout.cpp:

(WebCore::SimpleLineLayout::createLineRuns):

5:12 PM Changeset in webkit [179047] by Alan Bujtas
  • 3 edits in trunk/Source/WebCore

Simple line layout: Use only FlowContents::nextTextFragment() to read fragments from the text flow.
​https://bugs.webkit.org/show_bug.cgi?id=140842

Reviewed by Antti Koivisto.

This is in preparation to make FlowContents a content iterator class.

No change in functionality.

  • rendering/SimpleLineLayout.cpp:

(WebCore::SimpleLineLayout::initializeNewLine):

  • rendering/SimpleLineLayoutFlowContents.h:
5:05 PM Changeset in webkit [179046] by ddkilzer@apple.com
  • 2 edits in trunk/Tools

test-webkitpy: webkitpy.tool.commands.earlywarningsystem_unittest.EarlyWarningSystemTest.test_ewses fails on EFL, GTK, Win ports
<​http://webkit.org/b/140787>

Reviewed by Daniel Bates.

  • Scripts/webkitpy/port/ios.py:

(IOSPort.determine_full_port_name): Instead of checking the type
of the current host, test if /usr/bin/xcrun exists before trying
to use it.

5:03 PM Changeset in webkit [179045] by Lucas Forschler
  • 4 edits in branches/safari-600.1.4.15-branch/Source/WebCore

Build fix after r179028, r179030, r179031, r179032.

Reviewed by Dana Burkart.

  • platform/graphics/WidthIterator.cpp:

(WebCore::WidthIterator::WidthIterator):

  • platform/graphics/mac/ComplexTextController.cpp:

(WebCore::ComplexTextController::ComplexTextController):

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlockFlow::computeInlineDirectionPositionsForSegment):

4:52 PM Changeset in webkit [179044] by commit-queue@webkit.org
  • 5 edits
    2 adds in trunk

[MSE] Implement Range Removal algorithm.
​https://bugs.webkit.org/show_bug.cgi?id=140622.

Patch by Bartlomiej Gajda <​b.gajda@samsung.com> on 2015-01-23
Reviewed by Jer Noble.

Source/WebCore:

This extract Range Removal algorithm (Editor's Draft version, bug:26316) from remove(),
to separate function to deal with old FIXME since bug in spec was resolved.
This should both guarantee good order of events, and prevent from switching to 'open' state
during end of stream.

Test: media/media-source/media-source-end-of-stream-readyState.html

  • Modules/mediasource/MediaSource.cpp:

(WebCore::MediaSource::setDurationInternal): update to use rangeRemoval(), not remove()
(WebCore::MediaSource::streamEndedWithError): remove FIXME, brigning back correct order of events.

  • Modules/mediasource/SourceBuffer.cpp:

(WebCore::SourceBuffer::remove): comments up to spec, extract rangeRemoval algorithm.
(WebCore::SourceBuffer::rangeRemoval):
(WebCore::SourceBuffer::removeTimerFired): comments up to spec.

  • Modules/mediasource/SourceBuffer.h:

LayoutTests:

Added short test to check whether endOfStream incorrectly switches back
to 'open' state.

  • media/media-source/media-source-end-of-stream-readyState.html: Added.
  • media/media-source/media-source-end-of-stream-readyState-expected.txt: Added.
4:49 PM Changeset in webkit [179043] by Csaba Osztrogonác
  • 2 edits in trunk/Tools

Fix the false positive build failures on the Windows buildbots
​https://bugs.webkit.org/show_bug.cgi?id=140819

Reviewed by Brent Fulgham.

Increase the build timeout (without producing output) to 2 hours for Windows bots,
the default 20 minutes is enough for others since they produce output during the build.

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:

(BuildFactory.init):

4:48 PM Changeset in webkit [179042] by dburkart@apple.com
  • 20 edits
    5 deletes in tags/Safari-600.5.3

Rollout r178466

4:45 PM Changeset in webkit [179041] by dburkart@apple.com
  • 12 edits
    8 deletes in tags/Safari-600.5.3

Rollout r178467

4:43 PM Changeset in webkit [179040] by dburkart@apple.com
  • 20 edits
    5 deletes in branches/safari-600.5-branch

Rollout r178466

4:38 PM Changeset in webkit [179039] by Brent Fulgham
  • 4 edits
    2 adds in trunk/LayoutTests

[Win] Test gardening. Mark a few failures after filing bugs.

Also rebaseline a few tests.

  • platform/win/TestExpectations:
  • platform/win/accessibility/parent-element-expected.txt:
  • platform/win/editing/input/caret-at-the-edge-of-input-expected.png: Added.
  • platform/win/editing/input/caret-at-the-edge-of-input-expected.txt: Added.
  • platform/win/js/dom/global-constructors-attributes-expected.txt:
4:32 PM Changeset in webkit [179038] by dburkart@apple.com
  • 12 edits
    8 deletes in branches/safari-600.5-branch

Rollout r178467

4:24 PM Changeset in webkit [179037] by rniwa@webkit.org
  • 2 edits in trunk/Websites/perf.webkit.org

Perf dashboard always assigns the result of A/B testing with build request 1
​https://bugs.webkit.org/show_bug.cgi?id=140382

Reviewed by Darin Adler.

The bug was caused by the expression array_get($report, 'jobId') or array_get($report, 'buildRequest')
which always evaluated to 1 when the report contained jobId. Fixed the bug by cascading array_get instead.

Also fixed a typo as well as a bug that reports were never associated with builds.

  • public/include/report-processor.php:

(ReportProcessor::process): Don't use "or" to find the non-null value since that always evaluates to 1
instead of the first non-null value.
(ReportProcessor::resolve_build_id): Fixed the typo by adding the missing "$this->".
(ReportProcessor::commit): Associate the report with the corresponding build as intended.

4:21 PM Changeset in webkit [179036] by rniwa@webkit.org
  • 2 edits in trunk/Websites/perf.webkit.org

Unreviewed typo fix. The prefix in triggerable_configurations is "trigconfig", not "trigrepo".

  • public/admin/tests.php:
3:48 PM Changeset in webkit [179035] by msaboff@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

LayoutTests/js/script-tests/reentrant-caching.js crashing on 32 bit builds
​https://bugs.webkit.org/show_bug.cgi?id=140843

Reviewed by Oliver Hunt.

When we are in vmEntryToJavaScript, we keep the stack pointer at an
alignment sutiable for pointing to a call frame header, which is the
alignment post making a call. We adjust the sp when calling to JS code,
but don't adjust it before calling the out of stack handler.

  • llint/LowLevelInterpreter32_64.asm:

Moved stack point down 8 bytes to get it aligned.

3:37 PM Changeset in webkit [179034] by dburkart@apple.com
  • 5 edits
    9 copies in branches/safari-600.5-branch

Merged r176354. <rdar://19451336>

3:34 PM Changeset in webkit [179033] by Brent Fulgham
  • 4 edits in trunk

Source/WebKit/win:
[Win] Teach WebKit to provide IAccessible2 'get_language'
​https://bugs.webkit.org/show_bug.cgi?id=140839

Reviewed by Dean Jackson.

  • AccessibleBase.cpp:

(AccessibleBase::get_locale): Wrap the Webore::AccessibleObject::language
result in an IA2Locale structure to statisfy the IAccessible2 specification.

Tools:
[Win] Teach WebKit to provide IAccessible2 'get_language' and access AXLanguage
​https://bugs.webkit.org/show_bug.cgi?id=140839

Reviewed by Dean Jackson.

  • DumpRenderTree/win/AccessibilityUIElementWin.cpp:

(AccessibilityUIElement::language): Retrieve the 'language' BSTR
from the IA2Locale structure and pass it to DRT.

3:09 PM Changeset in webkit [179032] by Lucas Forschler
  • 11 edits
    4 copies in branches/safari-600.1.4.15-branch

Merged r174489. rdar://problem/19434944

3:06 PM Changeset in webkit [179031] by Lucas Forschler
  • 2 edits in branches/safari-600.1.4.15-branch/Source/WebCore

Merged r174373. rdar://problem/19434944

3:05 PM Changeset in webkit [179030] by Lucas Forschler
  • 8 edits in branches/safari-600.1.4.15-branch/Source/WebCore

Merged r174297. rdar://problem/19434944

3:04 PM Changeset in webkit [179029] by dburkart@apple.com
  • 9 edits
    4 copies in branches/safari-600.5-branch

Merged r174489. <rdar://problem/19452129>

3:03 PM Changeset in webkit [179028] by Lucas Forschler
  • 42 edits
    1 copy in branches/safari-600.1.4.15-branch

Merged r174233. rdar://problem/19434944

2:16 PM Changeset in webkit [179027] by enrica@apple.com
  • 3 edits
    4 adds in trunk

Hit test returns incorrect results when performed in paginated content over the page gaps.
​https://bugs.webkit.org/show_bug.cgi?id=140837
rdar://problem/17494390

Reviewed by Dave Hyatt.

Source/WebCore:

Tests: fast/multicol/pagination/LeftToRight-tb-hittest.html

fast/multicol/pagination/RightToLeft-rl-hittest.html

When hittesting reaches the RenderView we need to check if we are
in paginated content and use the correct class to compute hittest results.

  • rendering/RenderView.cpp:

(WebCore::RenderView::updateHitTestResult):

LayoutTests:

  • fast/multicol/pagination/LeftToRight-tb-hittest-expected.txt: Added.
  • fast/multicol/pagination/LeftToRight-tb-hittest.html: Added.
  • fast/multicol/pagination/RightToLeft-rl-hittest-expected.txt: Added.
  • fast/multicol/pagination/RightToLeft-rl-hittest.html: Added.
1:57 PM Changeset in webkit [179026] by Brent Fulgham
  • 40 edits
    5 adds
    12 deletes in trunk/LayoutTests

[Win] Unreviewed gardening after landing r179024.

Update Windows-specific accessibility tests and test expectations after making Windows AX output match Mac.
This allows us to share more Mac results.

  • platform/win/TestExpectations:
  • platform/win/accessibility/adjacent-continuations-cause-assertion-failure-expected.txt:
  • platform/win/accessibility/aria-checkbox-text-expected.txt: Removed.
  • platform/win/accessibility/aria-combobox-expected.txt:
  • platform/win/accessibility/aria-fallback-roles-expected.txt: Removed.
  • platform/win/accessibility/aria-hidden-expected.txt: Removed.
  • platform/win/accessibility/aria-labelledby-on-input-expected.txt: Removed.
  • platform/win/accessibility/aria-labelledby-overrides-aria-label-expected.txt:
  • platform/win/accessibility/aria-labelledby-overrides-label-expected.txt: Removed.
  • platform/win/accessibility/aria-list-and-listitem-expected.txt:
  • platform/win/accessibility/aria-mappings-expected.txt: Added.
  • platform/win/accessibility/aria-menubar-menuitems-expected.txt:
  • platform/win/accessibility/aria-option-role-expected.txt:
  • platform/win/accessibility/aria-presentational-role-expected.txt: Removed.
  • platform/win/accessibility/aria-roles-expected.txt:
  • platform/win/accessibility/aria-tab-role-on-buttons-expected.txt:
  • platform/win/accessibility/aria-tab-roles-expected.txt:
  • platform/win/accessibility/aria-toggle-button-with-title-expected.txt: Removed.
  • platform/win/accessibility/canvas-description-and-role-expected.txt:
  • platform/win/accessibility/canvas-fallback-content-expected.txt:
  • platform/win/accessibility/css-content-attribute-expected.txt: Added.
  • platform/win/accessibility/deleting-iframe-destroys-axcache-expected.txt:
  • platform/win/accessibility/div-within-anchors-causes-crash-expected.txt:
  • platform/win/accessibility/document-enabled-state-expected.txt:
  • platform/win/accessibility/document-enabled-state.html:
  • platform/win/accessibility/document-role-expected.txt:
  • platform/win/accessibility/heading-elements-expected.txt:
  • platform/win/accessibility/heading-elements.html:
  • platform/win/accessibility/image-map1-expected.txt: Added.
  • platform/win/accessibility/image-with-alt-and-map-expected.txt: Added.
  • platform/win/accessibility/img-alt-attribute-expected.txt:
  • platform/win/accessibility/img-alt-attribute.html:
  • platform/win/accessibility/img-alt-tag-only-whitespace-expected.txt: Removed.
  • platform/win/accessibility/img-aria-button-alt-tag-expected.txt: Removed.
  • platform/win/accessibility/img-fallsback-to-title-expected.txt: Removed.
  • platform/win/accessibility/input-image-alt-expected.txt: Removed.
  • platform/win/accessibility/linked-elements-expected.txt:
  • platform/win/accessibility/linked-elements.html:
  • platform/win/accessibility/list-item-role-expected.txt:
  • platform/win/accessibility/list-item-role.html:
  • platform/win/accessibility/list-marker-role-expected.txt:
  • platform/win/accessibility/list-marker-role.html:
  • platform/win/accessibility/list-role-expected.txt:
  • platform/win/accessibility/list-role.html:
  • platform/win/accessibility/multiple-select-element-role-expected.txt:
  • platform/win/accessibility/multiple-select-element-role.html:
  • platform/win/accessibility/parent-element-expected.txt:
  • platform/win/accessibility/parent-element.html:
  • platform/win/accessibility/select-element-role-expected.txt:
  • platform/win/accessibility/select-element-role.html:
  • platform/win/accessibility/selection-and-focus-expected.txt:
  • platform/win/accessibility/selection-and-focus.html:
  • platform/win/accessibility/single-select-children.html:
  • platform/win/accessibility/svg-image-expected.txt: Removed.
  • platform/win/accessibility/text-role-expected.txt:
  • platform/win/aria-labelledby-overrides-aria-label-actual.txt: Added.
1:39 PM Changeset in webkit [179025] by akling@apple.com
  • 4 edits in trunk/Source/WebCore

Document should be a FontSelectorClient.
<​https://webkit.org/b/140833>

Reviewed by Antti Koivisto.

Make Document a FontSelectorClient so it can listen to the invalidation
callbacks from FontSelector instead of having code in FontSelector that
calls out to Document on invalidation.

  • css/CSSFontSelector.cpp:

(WebCore::CSSFontSelector::dispatchInvalidationCallbacks):

  • dom/Document.cpp:

(WebCore::Document::fontsNeedUpdate):
(WebCore::Document::fontSelector):
(WebCore::Document::clearStyleResolver):

  • dom/Document.h:
1:31 PM Changeset in webkit [179024] by Brent Fulgham
  • 2 edits in trunk/Tools

[Win] Update DRT Accessibility implementation to better match Mac.
​https://bugs.webkit.org/show_bug.cgi?id=140830

Reviewed by Dean Jackson.

  • DumpRenderTree/win/AccessibilityUIElementWin.cpp:

(AccessibilityUIElement::titleUIElement):
(AccessibilityUIElement::parentElement):
(convertToDRTLabel):
(AccessibilityUIElement::role):
(AccessibilityUIElement::title):
(AccessibilityUIElement::description):
(AccessibilityUIElement::stringValue):
(AccessibilityUIElement::helpText):
(AccessibilityUIElement::isFocused):

12:53 PM Changeset in webkit [179023] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebKit2

Fix the pre-Yosemite build.

  • UIProcess/API/mac/WKView.mm:

(-[WKView _dismissContentRelativeChildWindows]):

12:12 PM Changeset in webkit [179022] by bshafiei@apple.com
  • 1 copy in tags/Safari-600.1.4.15.2

New tag.

12:10 PM Changeset in webkit [179021] by bshafiei@apple.com
  • 1 copy in tags/Safari-600.5.3

New tag.

12:05 PM Changeset in webkit [179020] by bshafiei@apple.com
  • 5 edits in branches/safari-600.1.4.15-branch/Source

Versioning.

12:05 PM Changeset in webkit [179019] by Joseph Pecoraro
  • 15 edits
    2 adds in trunk

Web Inspector: Object Previews in the Console
​https://bugs.webkit.org/show_bug.cgi?id=129204

Reviewed by Timothy Hatcher.

Source/JavaScriptCore:

Update the very old, unused object preview code. Part of this comes from
the earlier WebKit legacy implementation, and the Blink implementation.

A RemoteObject may include a preview, if it is asked for, and if the
RemoteObject is an object. Previews are a shallow (single level) list
of a limited number of properties on the object. The previewed
properties are always stringified (even if primatives). Previews are
limited to just 5 properties or 100 indices. Previews are marked
as lossless if they are a complete snapshot of the object.

There is a path to make previews two levels deep, that is currently
unused but should soon be used for tables (e.g. IndexedDB).

  • inspector/InjectedScriptSource.js:
  • Move some code off of InjectedScript to be generic functions

usable by RemoteObject as well.

  • Update preview generation to use
  • inspector/protocol/Runtime.json:
  • Add a new type, "accessor" for preview objects. This represents

a getter / setter. We currently don't get the value.

Source/WebInspectorUI:

  • UserInterface/Controllers/JavaScriptLogViewController.js:

(WebInspector.JavaScriptLogViewController.prototype.consolePromptTextCommitted):

  • UserInterface/Controllers/JavaScriptRuntimeCompletionProvider.js:

(get WebInspector.JavaScriptRuntimeCompletionProvider.prototype.):
Update RuntimeManager callsites that do not need object previews.

  • UserInterface/Controllers/RuntimeManager.js:

(WebInspector.RuntimeManager.prototype.evalCallback):
(WebInspector.RuntimeManager.prototype.evaluateInInspectedWindow):
Update the main evaluate method to include a boolean parameter for
object previews. Most callers do not need them. Also, since previews
were not available on iOS 6, switch to invoke, to conditionally
include the command parameter.

  • UserInterface/Protocol/RemoteObject.js:

(WebInspector.RemoteObject):
(WebInspector.RemoteObject.fromPayload):
(WebInspector.RemoteObject.prototype.get preview):
Store the preview from the payload.

  • UserInterface/Views/ConsoleMessageImpl.js:

(WebInspector.ConsoleMessageImpl.prototype._format):
(WebInspector.ConsoleMessageImpl.prototype._formatParameter):
(WebInspector.ConsoleMessageImpl.prototype._formatParameterAsNode):
(WebInspector.ConsoleMessageImpl.prototype._formatParameterAsString):
(WebInspector.ConsoleMessageImpl.prototype._formatAsArrayEntry):
Pass an explicit false for most formatters to not use a preview if available.

(WebInspector.ConsoleMessageImpl.prototype._formatParameterAsArray):
(WebInspector.ConsoleMessageImpl.prototype._formatParameterAsObject):
Currently only object types are previewed. Though we request previews
for arrays, we don't use the preview because we show a better preview
by just immediately requesting for a full non-preview property list.

(WebInspector.ConsoleMessageImpl.prototype._appendObjectPreview):
Quickly output an object preview into the title element. The format
is "ClassName {prop: value...}". Elide the class name if it is "Object".
Also skip over certain preview properties that may not be useful
at a glance (like constructor, or accessors without values).

  • UserInterface/Views/LogContentView.css:

(.console-object-preview):
(.console-formatted-array .console-object-preview):
(.console-object-preview-lossless):
(.expanded .console-object-preview):
Show lossy previews in italics.
Show lossless previews and array previews without italics.
Do not show the class name in the preview in italics when expanded.

(.console-object-preview .name):
Give preview property names the same color as ObjectPropertiesSection property names.

(.expanded .console-object-preview > .console-object-preview-body):
When expanding an object, hide the preview.

(.console-object-preview > .console-object-preview-name.console-object-preview-name-Object):
(.expanded .console-object-preview > .console-object-preview-name.console-object-preview-name-Object):
For "Object" previews, hide the name "Object" when not expanded, and show it when expanded.

LayoutTests:

  • inspector/debugger/command-line-api-exception-nested-catch.html:
  • inspector/debugger/command-line-api-exception.html:
  • inspector/model/remote-object-get-properties.html:

Update RuntimeManager callsites to not ask for previews when evaluating.

  • inspector/model/remote-object-expected.txt: Added.
  • inspector/model/remote-object.html: Added.

Add a test specifically for Remote Object. This test can also be
opened in a browser. It attempts to run the gamut of all different
types of objects and shows the RemoteObject constructed for it.

12:03 PM Changeset in webkit [179018] by bshafiei@apple.com
  • 5 edits in branches/safari-600.5-branch/Source

Versioning.

12:01 PM Changeset in webkit [179017] by Chris Dumez
  • 2 edits in trunk/Source/WebCore

Leverage CSSValuePool's font family cache in CSSComputedStyleDeclaration
​https://bugs.webkit.org/show_bug.cgi?id=140829

Reviewed by Andreas Kling.

Leverage CSSValuePool's font family cache in CSSComputedStyleDeclaration
by calling CSSValuePool::createFontFamilyValue() to create the font
family CSSPrimitiveValue instead of cssValuePool().createValue().

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::valueForFamily):

11:57 AM Changeset in webkit [179016] by saambarati1@gmail.com
  • 3 edits in trunk/Source/WebInspectorUI

Web Inspector: Disable *Annotators on minified files that aren't pretty printed
​https://bugs.webkit.org/show_bug.cgi?id=140550

Reviewed by Timothy Hatcher.

When SourceCodeTextEditor speculates that a file is minified it
sets a flag on itself that the Annotators will notice when pretty
printing and turning on type profiling.

SourceCodeTextEditor enforces the following two behaviors:

  1. Always pretty print a file if we think it's minified while

viewing type annotations. So, while viewing a minified file,
if you press the type profiling button, the pretty printer will
first reformat the file, then the type profiler will insert type annotations.

  1. If the type profiler is enabled and we're viewing a pretty

printed file that we think originally was minified, and the
pretty printer is disabled via pressing the button, then the
type profiler will also be disabled.

These two behaviors maintain a good user experience because
it prevents a bad visual representation of profiler data and
also prevents bad performance.

  • UserInterface/Controllers/TypeTokenAnnotator.js:

(WebInspector.TypeTokenAnnotator.prototype.toggleTypeAnnotations): Deleted.

  • UserInterface/Views/SourceCodeTextEditor.js:

(WebInspector.SourceCodeTextEditor):
(WebInspector.SourceCodeTextEditor.prototype.shown):
(WebInspector.SourceCodeTextEditor.prototype.contentDidChange):
(WebInspector.SourceCodeTextEditor.prototype.toggleTypeAnnotations):
(WebInspector.SourceCodeTextEditor.prototype.prettyPrint):
(WebInspector.SourceCodeTextEditor.prototype._contentWillPopulate):
(WebInspector.SourceCodeTextEditor.prototype._populateWithContent):
(WebInspector.SourceCodeTextEditor.prototype._setTypeTokenAnnotatorEnabledState):

11:52 AM Changeset in webkit [179015] by msaboff@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

Immediate crash when setting JS breakpoint
​https://bugs.webkit.org/show_bug.cgi?id=140811

Reviewed by Mark Lam.

When the DFG stack layout phase doesn't allocate a register for the scope register,
it incorrectly sets the scope register in the code block to a bad value, one with
an offset of 0. Changed it so that we set the code block's scope register to the
invalid VirtualRegister instead.

No tests needed as adding the ASSERT in setScopeRegister() was used to find the bug.
We crash with that ASSERT in testapi and likely many other tests as well.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::CodeBlock):

  • bytecode/CodeBlock.h:

(JSC::CodeBlock::setScopeRegister):
(JSC::CodeBlock::scopeRegister):
Added ASSERTs to catch any future improper setting of the code block's scope register.

  • dfg/DFGStackLayoutPhase.cpp:

(JSC::DFG::StackLayoutPhase::run):

11:43 AM Changeset in webkit [179014] by timothy_horton@apple.com
  • 10 edits in trunk/Source

QLPreviewMenuItem popovers don't close when the page scrolls
​https://bugs.webkit.org/show_bug.cgi?id=140806
<rdar://problem/19555618>

Reviewed by Beth Dakin.

Now that QLPreviewMenuItem's popover doesn't eat scrolls, we need to dismiss it if the page scrolls.

  • WebView/WebHTMLView.mm:

(-[WebHTMLView scrollWheel:scrollWheel:]):
Send scrollWheel along to WebImmediateActionController.

  • WebView/WebImmediateActionController.h:
  • WebView/WebImmediateActionController.mm:

(-[WebImmediateActionController webView:didHandleScrollWheel:]):
(-[WebImmediateActionController _clearImmediateActionState]):
(-[WebImmediateActionController _defaultAnimationController]):
Keep track of the active QLPreviewMenuItem, and close it upon scroll.

  • UIProcess/API/mac/WKView.mm:

(-[WKView _dismissContentRelativeChildWindows]):
Send _dismissContentRelativeChildWindows on to WKImmediateActionController.

  • UIProcess/mac/WKImmediateActionController.h:
  • UIProcess/mac/WKImmediateActionController.mm:

(-[WKImmediateActionController _clearImmediateActionState]):
(-[WKImmediateActionController dismissContentRelativeChildWindows]):
(-[WKImmediateActionController _defaultAnimationController]):
Keep track of the active QLPreviewMenuItem, and close it upon scroll.

  • platform/spi/mac/QuickLookMacSPI.h:

Add some SPI.

11:42 AM Changeset in webkit [179013] by timothy_horton@apple.com
  • 4 edits in trunk/Source

Infinite recursion in _clearImmediateActionState
​https://bugs.webkit.org/show_bug.cgi?id=140807
<rdar://problem/19571601>

Reviewed by Anders Carlsson.

  • UIProcess/mac/WKImmediateActionController.mm:

(-[WKImmediateActionController _clearImmediateActionState]):
Clear _hasActivatedActionContext before calling didUseActions, because
didUseActions can call _clearImmediateActionState.

  • WebView/WebImmediateActionController.mm:

(-[WebImmediateActionController _clearImmediateActionState]):
Use this opportunity to bring identical code to WebKit1, to avoid
getting DataDetectors stuck when an immediate action is canceled.

10:44 AM Changeset in webkit [179012] by akling@apple.com
  • 18 edits in trunk/Source/WebCore

Hang CSSFontSelector off Document instead of StyleResolver.
<​https://webkit.org/b/140820>

Reviewed by Antti Koivisto.

Move the CSSFontSelector from StyleResolver to Document. This is the first
step towards making the CSSFontSelector be able to survive full style recalc.

Clearing a Document's StyleResolver will still nuke the CSSFontSelector,
though that is done in Document::clearStyleResolver() now.

  • css/CSSFontSelector.cpp:

(WebCore::CSSFontSelector::CSSFontSelector):

  • css/CSSFontSelector.h:

Modernize CSSFontSelector construction a bit by having create() return
a Ref and the constructor take a Document& instead of a Document*.
Also made the constructor explicit.

(WebCore::StyleResolver::~StyleResolver):

  • dom/Document.cpp:

(WebCore::Document::clearStyleResolver):

Nuke the current CSSFontSelector in clearStyleResolver() instead of
in ~StyleResolver. It's a minor change, but shows the way forward.
Added a FIXME about how CSSFontSelector should eventually survive
this operation.

(WebCore::Document::fontSelector):

  • css/FontLoader.cpp:

(WebCore::FontLoader::loadFont):
(WebCore::FontLoader::checkFont):
(WebCore::FontLoader::resolveFontStyle):

  • css/RuleSet.cpp:

(WebCore::RuleSet::addChildRules):

  • css/StyleResolver.h:

(WebCore::StyleResolver::fontSelector): Deleted.

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::StyleResolver):
(WebCore::StyleResolver::appendAuthorStyleSheets):
(WebCore::StyleResolver::styleForElement):
(WebCore::StyleResolver::defaultStyleForElement):
(WebCore::StyleResolver::updateFont):

  • dom/Document.h:
  • html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::setFont):

  • rendering/RenderListBox.cpp:

(WebCore::RenderListBox::updateFromElement):
(WebCore::RenderListBox::paintItemForeground):

  • rendering/RenderMenuList.cpp:

(RenderMenuList::fontSelector):

  • rendering/RenderSearchField.cpp:

(WebCore::RenderSearchField::fontSelector):

  • rendering/TextAutoSizing.cpp:

(WebCore::TextAutoSizingValue::adjustNodeSizes):
(WebCore::TextAutoSizingValue::reset):

  • rendering/svg/RenderSVGInlineText.cpp:

(WebCore::RenderSVGInlineText::computeNewScaledFontForStyle):

  • style/StyleResolveForDocument.cpp:

(WebCore::Style::resolveForDocument):

  • style/StyleResolveTree.cpp:

(WebCore::Style::resolveTree):

Move CSSFontSelector ownership from StyleResolver to Document.

10:28 AM Changeset in webkit [179011] by eric.carlson@apple.com
  • 2 edits in trunk/LayoutTests

Create a "load and stall" cgi that support byte ranges.
​https://bugs.webkit.org/show_bug.cgi?id=140628

Reviewed by Jer Noble.

  • http/tests/media/resources/serve-video.php: Add support for "stallOffset", "stallDuration",

and "chunkSize" parameters.

10:27 AM Changeset in webkit [179010] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebCore

Layout Test http/tests/media/track-in-band-hls-metadata.html is flaky
​https://bugs.webkit.org/show_bug.cgi?id=140827

Reviewed by Eric Carlson.

Create the m_metadataTrack by calling prepareMetadataTrack() before deref-ing it.

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::metadataDidArrive):

8:33 AM Changeset in webkit [179009] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WTF

[GTK] Add missing null check in some derefGPtr implementations
​https://bugs.webkit.org/show_bug.cgi?id=140822

Reviewed by Sergio Villar Senin.

It's missing in GHashTable and GVariant implementations.

  • wtf/gobject/GRefPtr.cpp:

(WTF::derefGPtr):

6:56 AM Changeset in webkit [179008] by svillar@igalia.com
  • 3 edits in trunk/Tools

REGRESSION: run-perf-tests --profiler= seems to have broken
​https://bugs.webkit.org/show_bug.cgi?id=113528

Reviewed by Daniel Bates.

The problem is that "perf --record" (or the equivalent call for
other profilers) is never called whenever there is a wrapper
option in the port. We should inject the profiler call first
(should it exists) and then use the port wrapper.

  • Scripts/webkitpy/port/driver.py:

(Driver._command_wrapper):

  • Scripts/webkitpy/port/driver_unittest.py:

(DriverTest.test_profiler_and_wrapper): New unit test.

6:30 AM Changeset in webkit [179007] by Carlos Garcia Campos
  • 19 edits
    12 adds in trunk

[GTK] Add initial database process support
​https://bugs.webkit.org/show_bug.cgi?id=139491

Reviewed by Sergio Villar Senin.

.:

  • Source/cmake/OptionsGTK.cmake: Set WebKit2_DatabaseProcess_OUTPUT_NAME.

Source/WebCore:

  • platform/sql/SQLiteFileSystem.cpp:

(WebCore::SQLiteFileSystem::openDatabase): Use
WebCore::fileSystemRepresentation() for the database filename,
otherwise sqlite3_open() fails when the filename contains "%2E".

Source/WebKit2:

Add initial support for DatabaseProcess, disabled by default for
now.

  • CMakeLists.txt: Add required files to compilation.
  • DatabaseProcess/DatabaseProcess.cpp:

(WebKit::DatabaseProcess::createDatabaseToWebProcessConnection):
Add the unix domain sockets implementation.

  • DatabaseProcess/EntryPoint/unix/DatabaseProcessMain.cpp: Added.

(main):

  • DatabaseProcess/gtk/DatabaseProcessMainGtk.cpp: Added.

(WebKit::DatabaseProcessMainUnix):

  • DatabaseProcess/unix/DatabaseProcessMainUnix.h: Added.
  • PlatformGTK.cmake: Add required files to compilation.
  • Shared/ProcessExecutablePath.h:
  • Shared/gtk/KeyedDecoder.cpp: Added.

(WebKit::KeyedDecoder::KeyedDecoder):
(WebKit::KeyedDecoder::~KeyedDecoder):
(WebKit::KeyedDecoder::buildDictionaryFromGVariant):
(WebKit::KeyedDecoder::decodeBytes):
(WebKit::KeyedDecoder::decodeBool):
(WebKit::KeyedDecoder::decodeUInt32):
(WebKit::KeyedDecoder::decodeInt32):
(WebKit::KeyedDecoder::decodeInt64):
(WebKit::KeyedDecoder::decodeFloat):
(WebKit::KeyedDecoder::decodeDouble):
(WebKit::KeyedDecoder::decodeString):
(WebKit::KeyedDecoder::beginObject):
(WebKit::KeyedDecoder::endObject):
(WebKit::KeyedDecoder::beginArray):
(WebKit::KeyedDecoder::beginArrayElement):
(WebKit::KeyedDecoder::endArrayElement):
(WebKit::KeyedDecoder::endArray):

  • Shared/gtk/KeyedDecoder.h: Added.
  • Shared/gtk/KeyedEncoder.cpp: Added.

(WebKit::KeyedEncoder::KeyedEncoder):
(WebKit::KeyedEncoder::~KeyedEncoder):
(WebKit::KeyedEncoder::encodeBytes):
(WebKit::KeyedEncoder::encodeBool):
(WebKit::KeyedEncoder::encodeUInt32):
(WebKit::KeyedEncoder::encodeInt32):
(WebKit::KeyedEncoder::encodeInt64):
(WebKit::KeyedEncoder::encodeFloat):
(WebKit::KeyedEncoder::encodeDouble):
(WebKit::KeyedEncoder::encodeString):
(WebKit::KeyedEncoder::beginObject):
(WebKit::KeyedEncoder::endObject):
(WebKit::KeyedEncoder::beginArray):
(WebKit::KeyedEncoder::beginArrayElement):
(WebKit::KeyedEncoder::endArrayElement):
(WebKit::KeyedEncoder::endArray):
(WebKit::KeyedEncoder::finishEncoding):

  • Shared/gtk/KeyedEncoder.h: Added.
  • Shared/gtk/ProcessExecutablePathGtk.cpp:

(WebKit::executablePathOfDatabaseProcess):

  • UIProcess/Databases/DatabaseProcessProxy.cpp:

(WebKit::DatabaseProcessProxy::didCreateDatabaseToWebProcessConnection):
Add the unix domain sockets implementation.

  • UIProcess/Launcher/gtk/ProcessLauncherGtk.cpp:

(WebKit::ProcessLauncher::launchProcess): Handle the
DatabaseProcess too.

  • UIProcess/gtk/WebContextGtk.cpp:

(WebKit::WebContext::platformDefaultIndexedDBDatabaseDirectory):

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::ensureWebToDatabaseProcessConnection): Add
the unix domain sockets implementation.

Source/WTF:

Add support for using GRefPtr with GVariantBuilder.

  • wtf/gobject/GRefPtr.cpp:

(WTF::refGPtr):
(WTF::derefGPtr):

  • wtf/gobject/GRefPtr.h:
  • wtf/gobject/GTypedefs.h:
2:33 AM Changeset in webkit [179006] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Initialization for some member variable of FontPlatformData
​https://bugs.webkit.org/show_bug.cgi?id=136327

Patch by Byeongha Cho <​byeongha.cho@samsung.com> on 2015-01-23
Reviewed by Myles C. Maxfield.

No new tests. There's no functional change.

  • platform/graphics/freetype/FontPlatformDataFreeType.cpp:

(WebCore::FontPlatformData::FontPlatformData):
(WebCore::FontPlatformData::operator=):
(WebCore::FontPlatformData::~FontPlatformData):

2:05 AM Changeset in webkit [179005] by ddkilzer@apple.com
  • 2 edits in branches/safari-600.1.4.15-branch/Source/WebKit2

Merged r175608. rdar://problem/19395075

2:05 AM Changeset in webkit [179004] by ddkilzer@apple.com
  • 2 edits in branches/safari-600.1.4.15-branch/Source/WebKit2

Merged r175607. rdar://problem/19395075

2:05 AM Changeset in webkit [179003] by ddkilzer@apple.com
  • 5 edits in branches/safari-600.1.4.15-branch/Source/WebKit2

Merged r175595. rdar://problem/19395075

2:04 AM Changeset in webkit [179002] by ddkilzer@apple.com
  • 6 edits in branches/safari-600.1.4.15-branch/Source/WebKit2

Merged r175577. rdar://problem/19395075

2:04 AM Changeset in webkit [179001] by ddkilzer@apple.com
  • 9 edits in branches/safari-600.1.4.15-branch/Source/WebKit2

Merged r174885. rdar://problem/19395075

2:04 AM Changeset in webkit [179000] by ddkilzer@apple.com
  • 2 edits in branches/safari-600.1.4.15-branch/Source/WebKit2

Merged r174286. rdar://problem/19395075

2:04 AM Changeset in webkit [178999] by ddkilzer@apple.com
  • 4 edits
    3 adds in branches/safari-600.1.4.15-branch/Source

Merged r174250. rdar://problem/19395075

2:04 AM Changeset in webkit [178998] by ddkilzer@apple.com
  • 9 edits in branches/safari-600.1.4.15-branch/Source/WebKit2

Merged r174232. rdar://problem/19395075

2:04 AM Changeset in webkit [178997] by ddkilzer@apple.com
  • 8 edits in branches/safari-600.1.4.15-branch/Source/WebKit2

Merged r174072. rdar://problem/19395075

2:04 AM Changeset in webkit [178996] by ddkilzer@apple.com
  • 9 edits in branches/safari-600.1.4.15-branch/Source/WebKit2

Merged r172966. rdar://problem/19395075

2:04 AM Changeset in webkit [178995] by ddkilzer@apple.com
  • 3 edits in branches/safari-600.1.4.15-branch/Source/WebKit2

Merged r173762. rdar://problem/19420088

2:04 AM Changeset in webkit [178994] by ddkilzer@apple.com
  • 10 edits in branches/safari-600.1.4.15-branch/Source

Merged r173741. rdar://problem/19420088

1:18 AM Changeset in webkit [178993] by bshafiei@apple.com
  • 2 edits in branches/safari-600.5-branch/Source/WebKit/mac

Merged r178680. rdar://problem/19489593

1:17 AM Changeset in webkit [178992] by bshafiei@apple.com
  • 2 edits in branches/safari-600.5-branch/Source/WebKit/mac

Merged r178676. rdar://problem/19489593

1:16 AM Changeset in webkit [178991] by bshafiei@apple.com
  • 2 edits in branches/safari-600.5-branch/Source/WebKit/mac

Merged r178605. rdar://problem/19490114

1:14 AM Changeset in webkit [178990] by bshafiei@apple.com
  • 2 edits in branches/safari-600.5-branch/Source/WebKit2

Merged r178595. rdar://problem/19490114

12:52 AM Changeset in webkit [178989] by ap@apple.com
  • 2 edits in trunk/LayoutTests

svg-resource-fragment-identifier-img-src.html is a hidpi reftest, but its -expected.html
counterpart isn't hidpi
​https://bugs.webkit.org/show_bug.cgi?id=140815

Reviewed by Simon Fraser.

  • svg/css/svg-resource-fragment-identifier-img-src-expected.html: Make the expectation

match its test.

12:49 AM Changeset in webkit [178988] by g.czajkowski@samsung.com
  • 2 edits in trunk/Source/WebCore

Rename ChildNodeRemovalNotifier::m_insertionPoint to m_removalPoint
​https://bugs.webkit.org/show_bug.cgi?id=140766

Reviewed by Andreas Kling.

ChildNodeRemovalNotifier::ChildNodeRemovalNotifier(...) should take
a node as removal point.
It's probably Copy/Paste from ChildNodeInsertionNotifier::m_insertionPoint.

No new tests. No behavior change.

  • dom/ContainerNodeAlgorithms.h:

(WebCore::ChildNodeRemovalNotifier::ChildNodeRemovalNotifier):
(WebCore::ChildNodeRemovalNotifier::notifyNodeRemovedFromDocument):
(WebCore::ChildNodeRemovalNotifier::notifyNodeRemovedFromTree):

12:25 AM Changeset in webkit [178987] by Chris Dumez
  • 5 edits
    7 deletes in trunk/LayoutTests

Rewrite the fast/css/css2-system-fonts.html test to be more useful on all platforms
​https://bugs.webkit.org/show_bug.cgi?id=140810

Reviewed by Andreas Kling.

Make the fast/css/css2-system-fonts.html explicit about the font styles
expected on each platform instead of just Mac.

It also converts the test to be text only as the style information is
now displayed in text format.

This change is in preparation for a refactor of system font handling.

This change is based on the following Blink revision by
<​alancutter@chromium.org>:
​http://src.chromium.org/viewvc/blink?view=revision&revision=169612

  • fast/css/css2-system-fonts.html:
  • platform/efl/fast/css/css2-system-fonts-expected.png: Removed.
  • platform/efl/fast/css/css2-system-fonts-expected.txt: Removed.
  • platform/gtk/fast/css/css2-system-fonts-expected.png: Removed.
  • platform/gtk/fast/css/css2-system-fonts-expected.txt: Removed.
  • platform/ios-simulator-wk2/fast/css/css2-system-fonts-expected.txt:
  • platform/mac-mavericks/fast/css/css2-system-fonts-expected.png: Removed.
  • platform/mac-mavericks/fast/css/css2-system-fonts-expected.txt:
  • platform/mac-mountainlion/fast/css/css2-system-fonts-expected.txt: Removed.
  • platform/mac/fast/css/css2-system-fonts-expected.png: Removed.
  • platform/mac/fast/css/css2-system-fonts-expected.txt:
12:19 AM Changeset in webkit [178986] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[GTK] Fix debug build after r178940
​https://bugs.webkit.org/show_bug.cgi?id=140814

Patch by Hunseop Jeong <Hunseop Jeong> on 2015-01-23
Reviewed by Carlos Garcia Campos.

  • platform/graphics/opentype/OpenTypeVerticalData.cpp:

(WebCore::OpenTypeVerticalData::substituteWithVerticalGlyphs):

Jan 22, 2015:

11:31 PM Changeset in webkit [178985] by bshafiei@apple.com
  • 5 edits in branches/safari-600.4-branch/Source

Versioning.

11:04 PM Changeset in webkit [178984] by mhahnenb@gmail.com
  • 4 edits in trunk/Source/JavaScriptCore

EdenCollections unnecessarily visit SmallStrings
​https://bugs.webkit.org/show_bug.cgi?id=140762

Reviewed by Geoffrey Garen.

  • heap/Heap.cpp:

(JSC::Heap::copyBackingStores): Also added a GCPhase for copying
backing stores, which is a significant portion of garbage collection.
(JSC::Heap::visitSmallStrings): Check to see if we need to visit
SmallStrings based on the collection type.

  • runtime/SmallStrings.cpp:

(JSC::SmallStrings::SmallStrings):
(JSC::SmallStrings::visitStrongReferences): Set the fact that we have
visited the SmallStrings since the last modification.

  • runtime/SmallStrings.h:

(JSC::SmallStrings::needsToBeVisited): If we're doing a
FullCollection, we need to visit. Otherwise, it depends on whether
we've been visited since the last modification/allocation.

10:26 PM Changeset in webkit [178983] by Alan Bujtas
  • 3 edits in trunk/Source/WebCore

Simple line layout: Move leading whitespace handling from removeTrailingWhitespace() to initializeNewLine().
​https://bugs.webkit.org/show_bug.cgi?id=140757

Reviewed by Antti Koivisto.

Checking if overflowed pre-wrap whitespace needs to be ignored should not be part of the trailing whitespace handling.
Move it to initializeNewLine().

No change in functionality.

  • rendering/SimpleLineLayout.cpp:

(WebCore::SimpleLineLayout::preWrap):
(WebCore::SimpleLineLayout::removeTrailingWhitespace):
(WebCore::SimpleLineLayout::initializeNewLine):

  • rendering/SimpleLineLayoutFlowContents.h:

(WebCore::SimpleLineLayout::FlowContents::isLineBreak):

9:38 PM Changeset in webkit [178982] by matthew_hanson@apple.com
  • 6 edits in branches/safari-600.5-branch/Source

Merge r174708. rdar://problem/19451256

9:38 PM Changeset in webkit [178981] by matthew_hanson@apple.com
  • 1 edit
    3 adds in branches/safari-600.5-branch/LayoutTests

Merge r175264. rdar://problem/19451378

8:17 PM Changeset in webkit [178980] by benjamin@webkit.org
  • 10 edits in trunk/Source/WebKit2

[iOS][WK2] Ignore synthetic click initiated on a previous page
​https://bugs.webkit.org/show_bug.cgi?id=139556
rdar://problem/18586008

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2015-01-22
Reviewed by David Kilzer.

Under the right accumulation of bad luck, a synthetic click could be generated
on a page that never asked for it.

What happened was:
1) Page Foo listen to touch event.
2) In response to touch events, Foo decides to navigate to page Bar

*but* it does not cancel the native gesture recognizers with preventDefault().

3) Page Bar loads.
4) The native gesture recognizer ask us to click, we forward that to the WebProcess

and generate a synthetic mouse event.

-> Bar receives a click.
If you are unlucky enough, it looks like a single tap does a double click.

There are two ways this patch avoids the problem:

First, in the UIProcess, we just cancel the HighlightLongPressGestureRecognizer
on didCommitLoadForMainFrame. This prevents "fast clicks" from accidentally going through.
This is not bullet proof because we get didCommitLoadForMainFrame asynchronously but
killing the timer and gesture seems like a good idea.

Second, we skip any tap command at the WebProcess level when it was issued for
the previous page. This is using the same principle we used for VisibleContentRect:
any input generated before the current layer tree commit is useless for the current page.

We track the commit ID in the UIProcess when we decide to do the tracking or not.
Note that we keep the ID regardless of the tracking state, it does not matter if we have sent
touch events, what matters is what content was on screen when the touch events were handled.

If the user interaction result in a tap, we send the commit ID along the tap commands.
In the WebProcess, we know the actual layer tree commit associated with the current page.
If the tap was generated with a layer ID preceding the current page, we fail the command.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::handleTouchEventSynchronously):
(WebKit::WebPageProxy::resetState):

  • UIProcess/WebPageProxy.h:
  • UIProcess/ios/WKContentView.mm:

(-[WKContentView _didCommitLoadForMainFrame]):

  • UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView _attemptClickAtLocation:]):

  • UIProcess/ios/WebPageProxyIOS.mm:

(WebKit::WebPageProxy::commitPotentialTap):
(WebKit::WebPageProxy::handleTap):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::didCommitLoad):

  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in:
  • WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::handleTap):
(WebKit::WebPage::commitPotentialTap):

8:06 PM Changeset in webkit [178979] by ddkilzer@apple.com
  • 2 edits in trunk/Tools

configure-xcode-for-ios-development needs to import webkitdirs.pm
<​http://webkit.org/b/140704>

Fixes the following runtime error:

Undefined subroutine &main::exitStatus called at ./Tools/Scripts/configure-xcode-for-ios-development line 167.

  • Scripts/configure-xcode-for-ios-development: Add back code to

import webkitdirs.pm for the exitStatus() method. Not sure why
I removed it before patch review.

7:32 PM Changeset in webkit [178978] by akling@apple.com
  • 3 edits
    2 deletes in trunk/Source/WebKit

Remove unused class EmojiFallbackFontSelector.
<​https://webkit.org/b/140809>

Reviewed by Antti Koivisto.

Source/WebKit:

  • WebKit.xcodeproj/project.pbxproj:

Source/WebKit/ios:

This class no longer has any clients.

  • Misc/EmojiFallbackFontSelector.cpp: Removed.
  • Misc/EmojiFallbackFontSelector.h: Removed.
6:21 PM Changeset in webkit [178977] by dburkart@apple.com
  • 6 edits in branches/safari-600.5-branch/Source/WebCore

Merged r178967. <rdar://19572776>

6:17 PM Changeset in webkit [178976] by Chris Dumez
  • 1 edit
    2 adds in trunk/LayoutTests

Import fast/css/font-shorthand-line-height.html layout test from Blink
​https://bugs.webkit.org/show_bug.cgi?id=140801

Reviewed by Andreas Kling.

Import fast/css/font-shorthand-line-height.html layout test from Blink
to get better test coverage for 'line-height' font shorthands cascades:
​https://src.chromium.org/viewvc/blink?view=rev&revision=184346

I am working on expanding the font shorthand at parsing time (like
other shorthands) via Bug 140577 and I want to make sure I don't break
line-height in the process.

  • fast/css/font-shorthand-line-height-expected.txt: Added.
  • fast/css/font-shorthand-line-height.html: Added.
5:57 PM Changeset in webkit [178975] by Chris Dumez
  • 3 edits in trunk/Source/WebKit2

[WK2][Cocoa] Drop WKWebViewConfiguration._featureCounterEnabled SPI.
​https://bugs.webkit.org/show_bug.cgi?id=140799

Reviewed by Dan Bernstein.

Drop WKWebViewConfiguration._featureCounterEnabled SPI now that the
client-side has been updated.

  • UIProcess/API/Cocoa/WKWebViewConfiguration.mm:

(-[WKWebViewConfiguration _setAllowsAlternateFullscreen:]):
(-[WKWebViewConfiguration _featureCounterEnabled]): Deleted.
(-[WKWebViewConfiguration _setFeatureCounterEnabled:]): Deleted.

  • UIProcess/API/Cocoa/WKWebViewConfigurationPrivate.h:
5:28 PM Changeset in webkit [178974] by bshafiei@apple.com
  • 1 copy in tags/Safari-600.4.3

New tag.

5:19 PM Changeset in webkit [178973] by Antti Koivisto
  • 2 edits in trunk/Source/WebKit2

Fix ENABLE(NETWORK_CACHE) build

  • NetworkProcess/NetworkResourceLoader.cpp:

(WebKit::NetworkResourceLoader::didFinishLoading):

5:16 PM Changeset in webkit [178972] by Brent Fulgham
  • 2 edits in trunk/Source/WebKit/win

[Win] Unreviewed test fix after r178965.

  • WebView.cpp: Supply missing implementation of 'setEditable'. It

currently asserts, causing all debug tests to fail.

4:47 PM Changeset in webkit [178971] by timothy_horton@apple.com
  • 2 edits in trunk/Tools

REGRESSION (r178847): Yosemite 32-bit bot isn't doing any work
​https://bugs.webkit.org/show_bug.cgi?id=140795

Reviewed by Jon Honeycutt.

  • BuildSlaveSupport/build.webkit.org-config/config.json:

r178847 accidentally remove the scheduler for this bot. Re-add it to the
Yosemite scheduler.

4:44 PM Changeset in webkit [178970] by jonowells@apple.com
  • 7 edits in trunk/Source/WebInspectorUI

Web Inspector: ResourceContentView.js incorrectly contains call to WebInspector.UIString with a variable parameter
​https://bugs.webkit.org/show_bug.cgi?id=140268

Reviewed by Timothy Hatcher.

UIString no longer incorrectly used around variables. Drive-by fixes to prototype inheritance style.
Use of Promises corrected such that requesting content for a resource resolves rather than rejects if
a resource can't be found or has another error that isn't a web inspector error.

  • Localizations/en.lproj/localizedStrings.js: Updated.
  • UserInterface/Models/Resource.js: Change reject to resolve.
  • UserInterface/Models/Script.js:

(WebInspector.Script.prototype.requestContentFromBackend): Proper use of Error object.

  • UserInterface/Models/SourceCode.js: Use correct inheritance style.
  • UserInterface/Views/ResourceContentView.js:

(WebInspector.ResourceContentView.prototype._contentAvailable): Handle error now that promise resolves.
(WebInspector.ResourceContentView.prototype._contentError): Remove incorrect use of UIString.

  • UserInterface/Views/SourceCodeTextEditor.js:

(WebInspector.SourceCodeTextEditor.prototype._contentAvailable): Handle error now that promise resolves.

4:31 PM Changeset in webkit [178969] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebCore

[iOS] Media controls disappear when loading a HLS live stream
​https://bugs.webkit.org/show_bug.cgi?id=140792
rdar://problem/19491658

Reviewed by Dean Jackson.

Overload reconnectControls to reconnect the "start playback" button
if the control type has been set to "StartPlaybackButton".

  • Modules/mediacontrols/mediaControlsiOS.js:

(ControllerIOS.prototype.reconnectControls):

4:18 PM Changeset in webkit [178968] by commit-queue@webkit.org
  • 5 edits in trunk/Source

[Win] No plugin content on some sites.
​https://bugs.webkit.org/show_bug.cgi?id=140780

Patch by ​peavo@outlook.com <​peavo@outlook.com> on 2015-01-22
Reviewed by Anders Carlsson.

Source/WebCore:

Return script instance from ScriptController::createScriptInstanceForWidget(),
instead of always returning null.

  • bindings/js/ScriptController.cpp:

(WebCore::ScriptController::createScriptInstanceForWidget):

  • plugins/PluginViewBase.h:

(WebCore::PluginViewBase::bindingInstance):

Source/WebKit/win:

Add override modifier to bindingInstance method.

  • Plugins/PluginView.h:
4:17 PM Changeset in webkit [178967] by jer.noble@apple.com
  • 6 edits in trunk/Source/WebCore

[Mac][EME] Adopt changes to AVStreamSession class methods
​https://bugs.webkit.org/show_bug.cgi?id=140778
rdar://problem/19458200

Reviewed by Eric Carlson.

AVStreamSession class methods have added a "storageDirectoryAtURL:" parameter so as to be able to
read and modify records stored at non-default storage locations.

  • Modules/encryptedmedia/MediaKeySession.cpp:

(WebCore::MediaKeySession::mediaKeysStorageDirectory): Implement client method by querying document and settings.

  • Modules/encryptedmedia/MediaKeySession.h:
  • platform/graphics/CDMSession.h:
  • platform/graphics/avfoundation/objc/CDMSessionMediaSourceAVFObjC.h:
  • platform/graphics/avfoundation/objc/CDMSessionMediaSourceAVFObjC.mm:

(WebCore::CDMSessionMediaSourceAVFObjC::releaseKeys): Check whether the AVStreamSession class responds to new selector before calling.
(WebCore::CDMSessionMediaSourceAVFObjC::update): Ditto.
(WebCore::CDMSessionMediaSourceAVFObjC::generateKeyReleaseMessage): Ditto.
(WebCore::CDMSessionMediaSourceAVFObjC::storagePath): Fetch the storage path from the client.

4:15 PM Changeset in webkit [178966] by msaboff@apple.com
  • 3 edits
    2 adds in trunk

REGRESSION (174847): can't view NHK(Japan's national public broadcasting organization)’s news pages
​https://bugs.webkit.org/show_bug.cgi?id=140794

Reviewed by Anders Carlsson.

Source/WebCore:

If a document.open has been set, return it instead of always returning a new,
non-cached instance of jsHTMLDocumentPrototypeFunctionOpen.

Test: js/dom/document-overwrite-open.html

  • bindings/js/JSHTMLDocumentCustom.cpp:

(WebCore::JSHTMLDocument::getOwnPropertySlot):

LayoutTests:

  • js/dom/document-overwrite-open-expected.txt: Added.
  • js/dom/document-overwrite-open.html: Added.
3:46 PM Changeset in webkit [178965] by Brent Fulgham
  • 11 edits in trunk

[Win] Expose missing editing features through WebView interface
​https://bugs.webkit.org/show_bug.cgi?id=140773
<rdar://problem/19565421>

Reviewed by Dean Jackson.

Connect the various WebView editing delegate methods to our
test infrastructure. Also prefer _bstr_t to raw BSTR types
to simplify life cycle management.

Source/WebKit/win:

  • DOMCoreClasses.cpp: Flesh out the DOMRange object.

(DOMElement::createInstance):
(DOMRange::QueryInterface):
(DOMRange::DOMRange):
(DOMRange::~DOMRange):
(DOMRange::createInstance):
(DOMRange::startContainer):
(DOMRange::startOffset):
(DOMRange::endContainer):
(DOMRange::endOffset):
(DOMRange::collapsed):
(DOMRange::commonAncestorContainer):
(DOMRange::setStart):
(DOMRange::setEnd):
(DOMRange::setStartBefore):
(DOMRange::setStartAfter):
(DOMRange::setEndBefore):
(DOMRange::setEndAfter):
(DOMRange::collapse):
(DOMRange::selectNode):
(DOMRange::selectNodeContents):
(DOMRange::compareBoundaryPoints):
(DOMRange::deleteContents):
(DOMRange::extractContents):
(DOMRange::cloneContents):
(DOMRange::insertNode):
(DOMRange::surroundContents):
(DOMRange::cloneRange):
(DOMRange::toString):
(DOMRange::detach):

  • DOMCoreClasses.h:

(DOMRange::AddRef):
(DOMRange::Release):
(DOMRange::throwException):
(DOMRange::callWebScriptMethod):
(DOMRange::evaluateWebScript):
(DOMRange::removeWebScriptKey):
(DOMRange::stringRepresentation):
(DOMRange::webScriptValueAtIndex):
(DOMRange::setWebScriptValueAtIndex):
(DOMRange::setException):

  • Interfaces/IWebEditingDelegate.idl:
  • Interfaces/IWebView.idl:
  • WebCoreSupport/WebEditorClient.cpp: Connect more methods

to actual editing features in WebCore.
(WebEditorClient::shouldBeginEditing):
(WebEditorClient::shouldEndEditing):
(WebEditorClient::didBeginEditing):
(WebEditorClient::respondToChangedContents):
(WebEditorClient::respondToChangedSelection):
(WebEditorClient::didEndEditing):
(WebEditorClient::shouldDeleteRange):
(WebEditorClient::shouldInsertNode):
(WebEditorClient::shouldInsertText):
(WebEditorClient::shouldChangeSelectedRange):
(WebEditorClient::webViewDidChangeTypingStyle):
(WebEditorClient::webViewDidChangeSelection):
(WebEditorClient::isSelectTrailingWhitespaceEnabled):

  • WebView.cpp:

(WebView::setEditingDelegate): Added.

Tools:

  • DumpRenderTree/win/DumpRenderTree.cpp:

(resetWebViewToConsistentStateBeforeTesting):

  • DumpRenderTree/win/EditingDelegate.cpp:

(EditingDelegate::QueryInterface):
(dumpPath):
(dump):
(EditingDelegate::shouldBeginEditingInDOMRange):
(EditingDelegate::shouldEndEditingInDOMRange):
(EditingDelegate::shouldInsertNode):
(EditingDelegate::shouldInsertText):
(EditingDelegate::shouldDeleteDOMRange):
(EditingDelegate::shouldChangeSelectedDOMRange):
(EditingDelegate::shouldApplyStyle):
(EditingDelegate::shouldChangeTypingStyle):
(EditingDelegate::doPlatformCommand):
(EditingDelegate::webViewDidBeginEditing):
(EditingDelegate::webViewDidChange):
(EditingDelegate::webViewDidEndEditing):
(EditingDelegate::webViewDidChangeTypingStyle):
(EditingDelegate::webViewDidChangeSelection):
(EditingDelegate::checkSpellingOfString):
(EditingDelegate::onNotify):

  • DumpRenderTree/win/EditingDelegate.h:
3:42 PM Changeset in webkit [178964] by Alan Bujtas
  • 2 edits in trunk/Source/WebCore

Simple line layout: Reset LineState when starting a new line.
​https://bugs.webkit.org/show_bug.cgi?id=140789

Reviewed by Antti Koivisto.

Reset LineState when starting a new line to ensure we always
start with a clean state.

No change in functionality.

  • rendering/SimpleLineLayout.cpp:

(WebCore::SimpleLineLayout::updateLineConstrains):
(WebCore::SimpleLineLayout::initializeNewLine):
(WebCore::SimpleLineLayout::splitFragmentToFitLine):
(WebCore::SimpleLineLayout::createTextRuns):

3:35 PM Changeset in webkit [178963] by roger_fong@apple.com
  • 12 edits
    15 adds in trunk

[WebGL2] Create empty interface files for new WebGL2 objects.
​https://bugs.webkit.org/show_bug.cgi?id=140779.
<rdar://problem/15002288>

Reviewed by Dean Jackson.

  • CMakeLists.txt:
  • DerivedSources.cpp:
  • DerivedSources.make:
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:
  • WebCore.xcodeproj/project.pbxproj:
  • html/canvas/WebGLQuery.cpp: Added.

(WebCore::WebGLQuery::create):
(WebCore::WebGLQuery::~WebGLQuery):
(WebCore::WebGLQuery::WebGLQuery):
(WebCore::WebGLQuery::deleteObjectImpl):

  • html/canvas/WebGLQuery.h: Added.
  • html/canvas/WebGLQuery.idl: Added.
  • html/canvas/WebGLSampler.cpp: Added.

(WebCore::WebGLSampler::create):
(WebCore::WebGLSampler::~WebGLSampler):
(WebCore::WebGLSampler::WebGLSampler):
(WebCore::WebGLSampler::deleteObjectImpl):

  • html/canvas/WebGLSampler.h: Added.
  • html/canvas/WebGLSampler.idl: Added.
  • html/canvas/WebGLSharedObject.h:

(WebCore::WebGLSharedObject::isQuery):
(WebCore::WebGLSharedObject::isSampler):
(WebCore::WebGLSharedObject::isSync):
(WebCore::WebGLSharedObject::isTransformFeedback):
(WebCore::WebGLSharedObject::isVertexArrayObject):

  • html/canvas/WebGLSync.cpp: Added.

(WebCore::WebGLSync::create):
(WebCore::WebGLSync::~WebGLSync):
(WebCore::WebGLSync::WebGLSync):
(WebCore::WebGLSync::deleteObjectImpl):

  • html/canvas/WebGLSync.h: Added.
  • html/canvas/WebGLSync.idl: Added.
  • html/canvas/WebGLTransformFeedback.cpp: Added.

(WebCore::WebGLTransformFeedback::create):
(WebCore::WebGLTransformFeedback::~WebGLTransformFeedback):
(WebCore::WebGLTransformFeedback::WebGLTransformFeedback):
(WebCore::WebGLTransformFeedback::deleteObjectImpl):

  • html/canvas/WebGLTransformFeedback.h: Added.
  • html/canvas/WebGLTransformFeedback.idl: Added.
  • html/canvas/WebGLVertexArrayObject.cpp: Added.

(WebCore::WebGLVertexArrayObject::create):
(WebCore::WebGLVertexArrayObject::~WebGLVertexArrayObject):
(WebCore::WebGLVertexArrayObject::WebGLVertexArrayObject):
(WebCore::WebGLVertexArrayObject::deleteObjectImpl):

  • html/canvas/WebGLVertexArrayObject.h: Added.
  • html/canvas/WebGLVertexArrayObject.idl: Added.
  • platform/mac-mavericks/js/dom/global-constructors-attributes-expected.txt:
  • platform/mac-mountainlion/js/dom/global-constructors-attributes-expected.txt:
  • platform/mac/js/dom/global-constructors-attributes-expected.txt:
3:35 PM Changeset in webkit [178962] by bshafiei@apple.com
  • 2 edits in tags/Safari-601.1.15.1/Source/WebKit2

Merged r178958. rdar://problem/19438402

3:34 PM Changeset in webkit [178961] by ddkilzer@apple.com
  • 2 edits in trunk/WebKitLibraries

[iOS] Fix build for external iphoneos SDK

Reviewed by Daniel Bates.

  • WebKitSystemInterface.h: Remove import of the

<IOSurface/IOSurface.h> header, and add a typedef for
IOSurfaceRef in its place.

3:32 PM Changeset in webkit [178960] by bshafiei@apple.com
  • 5 edits in tags/Safari-601.1.15.1/Source

Versioning.

3:30 PM Changeset in webkit [178959] by bshafiei@apple.com
  • 1 copy in tags/Safari-601.1.15.1

New tag.

3:21 PM Changeset in webkit [178958] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebKit2

UserData decoding of WKTypeRefWrapper always fails
​https://bugs.webkit.org/show_bug.cgi?id=140791
<rdar://problem/19438402>

Reviewed by Anders Carlsson.

  • Shared/mac/ObjCObjectGraph.mm:

(WebKit::ObjCObjectGraph::decode):
Add a missing break.

3:20 PM Changeset in webkit [178957] by ap@apple.com
  • 2 edits in trunk/LayoutTests

Skip another copy of oes-vertex-array-object test, because it has the same problems
as the old one.

  • platform/mac/TestExpectations:
3:16 PM Changeset in webkit [178956] by Brent Fulgham
  • 18 edits
    12 adds
    1 delete in trunk/LayoutTests

[Win] Unreviewed test gardening.

Clean up editing-related tests and rebaseline some output.

  • platform/win/TestExpectations:
  • platform/win/editing/input/reveal-caret-of-multiline-contenteditable-expected.txt:
  • platform/win/editing/input/reveal-caret-of-multiline-input-expected.txt:
  • platform/win/editing/inserting/4960120-1-expected.txt:
  • platform/win/editing/inserting/break-blockquote-after-delete-expected.txt:
  • platform/win/editing/inserting/insert-3907422-fix-expected.txt: Removed.
  • platform/win/editing/pasteboard/4641033-expected.txt: Added.
  • platform/win/editing/pasteboard/4944770-1-expected.txt: Added.
  • platform/win/editing/pasteboard/4944770-2-expected.txt: Added.
  • platform/win/editing/pasteboard/drop-text-without-selection-expected.txt: Added.
  • platform/win/editing/selection/3690703-2-expected.txt:
  • platform/win/editing/selection/3690703-expected.txt:
  • platform/win/editing/selection/3690719-expected.txt:
  • platform/win/editing/selection/4975120-expected.txt: Added.
  • platform/win/editing/selection/5240265-expected.txt:
  • platform/win/editing/selection/caret-before-select-expected.txt: Added.
  • platform/win/editing/selection/caret-rtl-2-expected.txt: Added.
  • platform/win/editing/selection/caret-rtl-2-left-expected.txt:
  • platform/win/editing/selection/caret-rtl-expected.txt: Added.
  • platform/win/editing/selection/caret-rtl-right-expected.txt:
  • platform/win/editing/selection/drag-select-1-expected.txt: Added.
  • platform/win/editing/selection/mixed-editability-10-expected.txt:
  • platform/win/editing/selection/replaced-boundaries-3-expected.txt: Added.
  • platform/win/editing/selection/select-box-expected.txt: Added.
  • platform/win/editing/selection/select-element-paragraph-boundary-expected.txt: Added.
  • platform/win/editing/selection/select-from-textfield-outwards-expected.txt:
  • platform/win/editing/selection/selection-button-text-expected.txt:
  • platform/win/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.txt:
  • platform/win/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.txt:
  • platform/win/editing/selection/vertical-rl-rtl-extend-line-backward-br-expected.txt:
3:13 PM Changeset in webkit [178955] by Chris Dumez
  • 2 edits in trunk/Source/WebCore

Fix remaining multiple targets per rule issues in DerivedSources.make
​https://bugs.webkit.org/show_bug.cgi?id=140790

Reviewed by David Kilzer.

Fix remaining multiple target per rule issues in DerivedSources.make,
similarly to Bug 140784 and Bug 140756.

This was causing us to run scripts several times to generate the same
files and may lead to malformed files in case of concurrency.

  • DerivedSources.make:
3:12 PM Changeset in webkit [178954] by rniwa@webkit.org
  • 17 edits in trunk

Add a build flag for ES6 class syntax
​https://bugs.webkit.org/show_bug.cgi?id=140760

Reviewed by Michael Saboff.

.:

  • Source/cmake/WebKitFeatures.cmake:
  • Source/cmakeconfig.h.cmake:

Source/JavaScriptCore:

Added ES6_CLASS_SYNTAX build flag and used it in tokenizer to recognize
"class", "extends", "static" and "super" keywords.

  • Configurations/FeatureDefines.xcconfig:
  • parser/Keywords.table:
  • parser/ParserTokens.h:

Source/WebCore:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit/mac:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

  • Configurations/FeatureDefines.xcconfig:

Source/WTF:

  • wtf/FeatureDefines.h:

Tools:

  • Scripts/webkitperl/FeatureList.pm:
3:09 PM Changeset in webkit [178953] by Joseph Pecoraro
  • 2 edits in trunk/LayoutTests

Unreviewed, skip flakey inspector test.

2:23 PM Changeset in webkit [178952] by Chris Dumez
  • 2 edits in trunk/Source/WebCore

SVGNames.cpp and HTMLNames.cpp are sometimes malformed
​https://bugs.webkit.org/show_bug.cgi?id=140784
<rdar://problem/17701233>

Reviewed by David Kilzer.

Due to bad rules in DerivedSources.make, make_names.pl was called
several times with the same arguments during build. This is because
SVG/HTML/MathML each had several targets associated to the same
command. This would cause the command (make_names.pl) to be called
once per target. However, make_names.pl only needs to be executed
once to generate all of the files currently marked as target.

Calling make_names.pl several times for the same files is not only
wasteful, but it can also lead to malformed generated files if the
scripts instances are executed in parallel as they will read / write
from / to the same files.

This patch uses INTERMEDIATE targets instead so that we can still
indicate which files are generated by make_names.pl but only run
the script once.

This is a similar fix as for Bug 140756. There may several other
similar issues in DerivedSources.make but this patch focuses on
make_names.pl. I will take care of other in follow-ups if needed.

  • DerivedSources.make:
2:21 PM Changeset in webkit [178951] by Chris Dumez
  • 4 edits in trunk/Source/WebCore

Have Counter::create() return a Ref<Counter>
​https://bugs.webkit.org/show_bug.cgi?id=140777

Reviewed by Andreas Kling.

Have Counter::create() return a Ref<Counter> instead of a PassRefPtr.

The CSSPrimitiveValue class needed some updates as well to support
constructing a CSSPrimitiveValue object from a Ref<>.

  • css/CSSPrimitiveValue.cpp:

(WebCore::CSSPrimitiveValue::init):

  • css/CSSPrimitiveValue.h:

(WebCore::CSSPrimitiveValue::create):
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):

  • css/Counter.h:

(WebCore::Counter::create):
(WebCore::Counter::cloneForCSSOM):

2:20 PM Changeset in webkit [178950] by matthew_hanson@apple.com
  • 3 edits
    2 adds in branches/safari-600.5-branch

Merge r178426. rdar://problem/19526069

2:19 PM Changeset in webkit [178949] by Chris Dumez
  • 21 edits
    4 deletes in trunk/Source

Drop the legacy FeatureCounter class
​https://bugs.webkit.org/show_bug.cgi?id=140749

Reviewed by Andreas Kling.

Drop the legacy FeatureCounter class and use DiagnosticLoggingClient
instead.

Source/WebCore:

  • CMakeLists.txt:
  • Configurations/WebCore.xcconfig:
  • WebCore.exp.in:
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:
  • WebCore.xcodeproj/project.pbxproj:
  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::parseAttribute):

  • loader/SubresourceLoader.cpp:

(WebCore::SubresourceLoader::willSendRequest):
(WebCore::SubresourceLoader::didReceiveResponse):

  • loader/cache/CachedResource.cpp:

(WebCore::CachedResource::mustRevalidateDueToCacheHeaders):

  • loader/cache/CachedResourceLoader.cpp:

(WebCore::logMemoryCacheResourceRequest):
(WebCore::CachedResourceLoader::requestResource):
(WebCore::CachedResourceLoader::determineRevalidationPolicy):

  • page/DiagnosticLoggingKeys.cpp:

(WebCore::DiagnosticLoggingKeys::mustRevalidateIsExpiredKey):
(WebCore::DiagnosticLoggingKeys::playedKey):
(WebCore::DiagnosticLoggingKeys::noCacheKey):
(WebCore::DiagnosticLoggingKeys::noStoreKey):
(WebCore::DiagnosticLoggingKeys::notInMemoryCacheKey):
(WebCore::DiagnosticLoggingKeys::mediaKey):
(WebCore::DiagnosticLoggingKeys::isExpiredKey):
(WebCore::DiagnosticLoggingKeys::loadingKey):
(WebCore::DiagnosticLoggingKeys::inMemoryCacheKey):
(WebCore::DiagnosticLoggingKeys::reasonKey):
(WebCore::DiagnosticLoggingKeys::audioKey):
(WebCore::DiagnosticLoggingKeys::cachedResourceRevalidationKey):
(WebCore::DiagnosticLoggingKeys::resourceRequestKey):
(WebCore::DiagnosticLoggingKeys::revalidatingKey):
(WebCore::DiagnosticLoggingKeys::unusedKey):
(WebCore::DiagnosticLoggingKeys::unusedReasonCredentialSettingsKey):
(WebCore::DiagnosticLoggingKeys::unusedReasonErrorKey):
(WebCore::DiagnosticLoggingKeys::unusedReasonMustRevalidateNoValidatorKey):
(WebCore::DiagnosticLoggingKeys::unusedReasonNoStoreKey):
(WebCore::DiagnosticLoggingKeys::unusedReasonRedirectChainKey):
(WebCore::DiagnosticLoggingKeys::unusedReasonReloadKey):
(WebCore::DiagnosticLoggingKeys::unusedReasonTypeMismatchKey):
(WebCore::DiagnosticLoggingKeys::usedKey):
(WebCore::DiagnosticLoggingKeys::userKey):
(WebCore::DiagnosticLoggingKeys::videoKey):
(WebCore::DiagnosticLoggingKeys::webViewKey):
(WebCore::DiagnosticLoggingKeys::zoomedKey):

  • page/DiagnosticLoggingKeys.h:
  • page/Settings.in:
  • platform/FeatureCounter.cpp: Removed.
  • platform/FeatureCounter.h: Removed.
  • platform/FeatureCounterKeys.h: Removed.
  • platform/ios/FeatureCounter.mm: Removed.

Source/WebKit2:

  • Shared/WebPreferencesDefinitions.h:
  • UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView initWithFrame:configuration:]):

  • UIProcess/API/Cocoa/WKWebViewConfiguration.mm:

(-[WKWebViewConfiguration init]):
(-[WKWebViewConfiguration copyWithZone:]):
(-[WKWebViewConfiguration _featureCounterEnabled]):
(-[WKWebViewConfiguration _setFeatureCounterEnabled:]):

  • UIProcess/API/Cocoa/WKWebViewConfigurationPrivate.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences):

  • WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::willStartUserTriggeredZooming):

2:17 PM Changeset in webkit [178948] by benjamin@webkit.org
  • 2 edits in trunk/Source/WebCore

When extending the fallback transitions with their closure, we are modifying the Set while iterating it
​https://bugs.webkit.org/show_bug.cgi?id=140785

Reviewed by Andreas Kling.

  • contentextensions/NFAToDFA.cpp:

(WebCore::ContentExtensions::populateTransitions):
Make that in two steps: accumulate the fallback transitions then add the closure
of every element.

2:16 PM Changeset in webkit [178947] by matthew_hanson@apple.com
  • 5 edits
    5 adds in branches/safari-600.5-branch

Merge r178038. rdar://problem/19451263

2:16 PM Changeset in webkit [178946] by matthew_hanson@apple.com
  • 2 edits in branches/safari-600.5-branch/Source/WebKit/mac

Merge r177611. rdar://problem/19451361

2:16 PM Changeset in webkit [178945] by matthew_hanson@apple.com
  • 1 edit
    5 adds in branches/safari-600.5-branch/LayoutTests

Merge r177408. rdar://problem/19451330

2:16 PM Changeset in webkit [178944] by matthew_hanson@apple.com
  • 3 edits
    2 adds in branches/safari-600.5-branch

Merge r177360. rdar://problem/19451319

2:13 PM Changeset in webkit [178943] by ap@apple.com
  • 2 edits in trunk/LayoutTests

​https://bugs.webkit.org/show_bug.cgi?id=140755
rdar://problem/7881290

  • http/tests/appcache/404-resource-with-slow-main-resource.php: Try updating the

tiemout, as it's not sufficient for appcache load to fail on some bots.

  • http/tests/appcache/404-resource-with-slow-main-resource.php:
2:02 PM Changeset in webkit [178942] by matthew_hanson@apple.com
  • 3 edits
    5 adds in branches/safari-600.5-branch

Merge r177292. rdar://problem/19452139

2:02 PM Changeset in webkit [178941] by matthew_hanson@apple.com
  • 18 edits in branches/safari-600.5-branch/Source

Merge r177152. rdar://problem/19451288

1:57 PM Changeset in webkit [178940] by Antti Koivisto
  • 118 edits
    2 moves in trunk/Source

Rename SimpleFontData to Font
​https://bugs.webkit.org/show_bug.cgi?id=140496

Reviewed by Zalan Bujtas.

The fallback supporting Font type was renamed FontCascade.
We can now rename SimpleFontData to Font matching the usual definition.

1:54 PM Changeset in webkit [178939] by Alan Bujtas
  • 2 edits in trunk/Source/WebCore

Simple line layout: Make trailing whitespace handling more explicit.
​https://bugs.webkit.org/show_bug.cgi?id=140776

Reviewed by Antti Koivisto.

Differentiate between committed and uncommitted trailing whitespace.
This enables further cleanup in removeTrailingWhitespace().

No change in functionality.

  • rendering/SimpleLineLayout.cpp:

(WebCore::SimpleLineLayout::LineState::commitAndCreateRun):
(WebCore::SimpleLineLayout::LineState::addUncommitted):
(WebCore::SimpleLineLayout::LineState::hasWhitespaceOnly):
(WebCore::SimpleLineLayout::LineState::removeTrailingWhitespace):
(WebCore::SimpleLineLayout::removeTrailingWhitespace):
(WebCore::SimpleLineLayout::LineState::LineState): Deleted.
(WebCore::SimpleLineLayout::LineState::removeCommittedTrailingWhitespace): Deleted.
(WebCore::SimpleLineLayout::LineState::resetTrailingWhitespace): Deleted.

1:40 PM Changeset in webkit [178938] by Beth Dakin
  • 6 edits in trunk/Source

ibtoold crash below -[WebView close]
​https://bugs.webkit.org/show_bug.cgi?id=140782
-and corresponding-
rdar://problem/19558472

Reviewed by Tim Horton.

Retain the NSImmediateActionGestureRecognizer. This should not be necessary, but
Source/WebKit/mac:

it is because interface builder is messing with our views.

  • WebView/WebImmediateActionController.h:
  • WebView/WebImmediateActionController.mm:

(-[WebImmediateActionController webViewClosed]):
(-[WebImmediateActionController _cancelImmediateAction]):
(-[WebImmediateActionController immediateActionRecognizerWillPrepare:]):
(-[WebImmediateActionController _updateImmediateActionItem]):

Source/WebKit2:

it is because interface builder can mess with our views.

  • UIProcess/mac/WKImmediateActionController.h:
  • UIProcess/mac/WKImmediateActionController.mm:

(-[WKImmediateActionController willDestroyView:]):
(-[WKImmediateActionController _cancelImmediateAction]):
(-[WKImmediateActionController _cancelImmediateActionIfNeeded]):
(-[WKImmediateActionController _updateImmediateActionItem]):

1:04 PM Changeset in webkit [178937] by ap@apple.com
  • 6 edits
    2 adds in trunk

Crash in URL::protocol() after appcache load fails
​https://bugs.webkit.org/show_bug.cgi?id=140755
rdar://problem/7881290

Reviewed by Dan Bates.

Source/WebCore:

Test: http/tests/appcache/404-resource-with-slow-main-resource.php

Not every cache that isn't being updated is complete. It could also be in a zombie
state after failing to load. We get rid of the cache once the main resource finishes
loading, but while it's being loaded, the zombie still looks like a regular
candidate application cache.

  • loader/appcache/ApplicationCache.cpp: (WebCore::ApplicationCache::isComplete):
  • loader/appcache/ApplicationCache.h:

Removed const from isComplete(), because otherwise we couldn't use ApplicationCacheGroup::m_caches.contains().
Constness doesn't make a lot of sense for these objects anyway.

  • loader/appcache/ApplicationCacheGroup.cpp:

(WebCore::ApplicationCacheGroup::failedLoadingMainResource): Toned down an assertion.
We can fail a main resource load when the document has a zombie appcache, too.

  • loader/appcache/ApplicationCacheGroup.h:

(WebCore::ApplicationCacheGroup::cacheIsComplete):
(WebCore::ApplicationCacheGroup::cacheIsBeingUpdated): Deleted.
These functions are only used in ApplicationCache::isComplete().

LayoutTests:

  • http/tests/appcache/404-resource-with-slow-main-resource-expected.txt: Added.
  • http/tests/appcache/404-resource-with-slow-main-resource.php: Added.
12:35 PM Changeset in webkit [178936] by matthew_hanson@apple.com
  • 3 edits
    5 adds in branches/safari-600.5-branch

Merge r177033. rdar://problem/19451244

12:34 PM Changeset in webkit [178935] by matthew_hanson@apple.com
  • 2 edits in branches/safari-600.5-branch/Source/WebKit/mac

Merge r177011. rdar://problem/19451253

12:34 PM Changeset in webkit [178934] by matthew_hanson@apple.com
  • 2 edits in branches/safari-600.5-branch/Source/WTF

Merge r176982. rdar://problem/19452174

12:34 PM Changeset in webkit [178933] by matthew_hanson@apple.com
  • 3 edits
    2 adds in branches/safari-600.5-branch

Merge r176971. rdar://problem/19452174

12:34 PM Changeset in webkit [178932] by matthew_hanson@apple.com
  • 3 edits
    2 adds in branches/safari-600.5-branch

Merge r176768. rdar://problem/19451369

12:03 PM Changeset in webkit [178931] by matthew_hanson@apple.com
  • 3 edits
    2 adds in branches/safari-600.5-branch

Merge r176285. rdar://problem/19452164

12:01 PM Changeset in webkit [178930] by g.czajkowski@samsung.com
  • 2 edits in trunk/Source/WebCore

Avoid defining always empty Vector<TextCheckingResult>
​https://bugs.webkit.org/show_bug.cgi?id=140765

Reviewed by Alexey Proskuryakov.

Pass an empty vector direclty instead.

No new tests. No behavior change.

  • editing/SpellChecker.cpp:

(WebCore::SpellChecker::didCheckCancel):

11:38 AM Changeset in webkit [178929] by Chris Dumez
  • 2 edits in trunk/Source/WebCore

makeprop.pl script is called too many times during build
​https://bugs.webkit.org/show_bug.cgi?id=140756
<rdar://problem/19467942>

Reviewed by David Kilzer.

The makeprop.pl script was called 4 times (instead of once) during
build due to a bad Makefile rule in DerivedSources.make. makeprop.pl
had 4 associated targets and thus was called 4 times (with the same
parameter). Calling it once is sufficient to generate all 4 files
that were marked as target. This patch uses an INTERMEDIATE target
instead so that we can indicate that several files are generated
by the same command.

I believe this may be the reason for the sporatic build failures
that look like:
"""
CSSPropertyNames.gperf: No keywords in input file!
calling gperf failed: 256 at WebCore/css/makeprop.pl line 1036.
"""
The makeprop.pl script is generating gperf's input file and calling the
gperf executable on this file. If the script is executed several times
in parallel, it would explain the build failures as several instances
of makeprop.pl may be writing / reading from the same
CSSPropertyNames.gperf file.

  • DerivedSources.make:
11:34 AM Changeset in webkit [178928] by commit-queue@webkit.org
  • 31 edits
    3 deletes in trunk

Unreviewed, rolling out r178894.
​https://bugs.webkit.org/show_bug.cgi?id=140775

Broke JSC and bindings tests (Requested by ap_ on #webkit).

Reverted changeset:

"put_by_val_direct need to check the property is index or not
for using putDirect / putDirectIndex"
​https://bugs.webkit.org/show_bug.cgi?id=140426
​http://trac.webkit.org/changeset/178894

11:27 AM Changeset in webkit [178927] by ddkilzer@apple.com
  • 9 edits
    2 copies
    1 add in trunk/Source

[iOS] Fix iphoneos SDK builds for ios-ews queue
<​http://webkit.org/b/140748>

Reviewed by Daniel Bates.

Source/WebCore:

  • WebCore.xcodeproj/project.pbxproj: Add new SPI headers.
  • platform/graphics/cg/ImageBufferCG.cpp: Switch to using

"IOSurfaceSPI.h" from <IOSurface/IOSurface.h>.

  • platform/graphics/cg/ImageBufferDataCG.cpp: Ditto.
  • platform/graphics/cocoa/IOSurface.mm: Ditto. Move definitions

in <IOSurface/IOSurfacePrivate.h> into "IOSurfaceSPI.h".

  • platform/spi/cg/CoreGraphicsSPI.h: Switch to

WTF_EXTERN_C_{BEGIN,END}. Add
CGContextGetFontAntialiasingStyle() and
CGContextSetFontAntialiasingStyle().

  • platform/spi/cocoa/IOPMLibSPI.h: Switch to use IOReturnSPI.h.
  • platform/spi/cocoa/IOReturnSPI.h: Add.
  • platform/spi/cocoa/IOSurfaceSPI.h: Add.
  • platform/spi/cocoa/IOTypesSPI.h: Add.

Source/WebKit2:

  • Platform/spi/ios/BKSProcessAssertionSPI.h: Add -invalidate

definition. Sort @property to the top of BKSProcessAssertion.

11:05 AM Changeset in webkit [178926] by mark.lam@apple.com
  • 5 edits
    3 adds in trunk

BytecodeGenerator::initializeCapturedVariable() sets a misleading value for the 5th operand of op_put_to_scope.
<​https://webkit.org/b/140743>

Reviewed by Oliver Hunt.

Source/JavaScriptCore:

BytecodeGenerator::initializeCapturedVariable() was setting the 5th operand to
op_put_to_scope to an inappropriate value (i.e. 0). As a result, the execution
of put_to_scope could store a wrong inferred value into the VariableWatchpointSet
for which ever captured variable is at local index 0. In practice, this turns
out to be the local for the Arguments object. In this reproduction case in the
bug, the wrong inferred value written there is the boolean true.

Subsequently, DFG compilation occurs and CreateArguments is emitted to first do
a check of the local for the Arguments object. But because that local has a
wrong inferred value, the check always discovers a non-null value and we never
actually create the Arguments object. Immediately after this, an OSR exit
occurs leaving the Arguments object local uninitialized. Later on at arguments
tear off, we run into a boolean true where we had expected to find an Arguments
object, which in turn, leads to the crash.

The fix is to:

  1. In the case where the resolveModeType is LocalClosureVar, change the 5th operand of op_put_to_scope to be a boolean. True means that the local var is watchable. False means it is not watchable. We no longer pass the local index (instead of true) and UINT_MAX (instead of false).

This allows us to express more clearer in the code what that value means,
as well as remove the redundant way of getting the local's identifier.
The identifier is always the one passed in the 2nd operand.

  1. Previously, though intuitively, we know that the watchable variable identifier should be the same as the one that is passed in operand 2, this relationship was not clear in the code. By code analysis, I confirmed that the callers of BytecodeGenerator::emitPutToScope() always use the same identifier for operand 2 and for filling out the ResolveScopeInfo from which we get the watchable variable identifier later. I've changed the code to make this clear now by always using the identifier passed in operand 2.
  1. In the case where the resolveModeType is LocalClosureVar, initializeCapturedVariable() and emitPutToScope() will now query hasWatchableVariable() to determine if the local is watchable or not. Accordingly, we pass the boolean result of hasWatchableVariable() as operand 5 of op_put_to_scope.

Also added some assertions.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::CodeBlock):

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::initializeCapturedVariable):
(JSC::BytecodeGenerator::hasConstant):
(JSC::BytecodeGenerator::emitPutToScope):

  • bytecompiler/BytecodeGenerator.h:

(JSC::BytecodeGenerator::hasWatchableVariable):
(JSC::BytecodeGenerator::watchableVariableIdentifier):
(JSC::BytecodeGenerator::watchableVariable): Deleted.

LayoutTests:

  • js/dfg-osr-exit-between-create-and-tearoff-arguments-expected.txt: Added.
  • js/dfg-osr-exit-between-create-and-tearoff-arguments.html: Added.
  • js/script-tests/dfg-osr-exit-between-create-and-tearoff-arguments.js: Added.

(foo):

10:51 AM Changeset in webkit [178925] by dbates@webkit.org
  • 2 edits in trunk/Tools

[iOS] run-webkit-tests --ios-sim dies with an error; fails to parse Apple Internal
runtime in simctl output
​https://bugs.webkit.org/show_bug.cgi?id=140751

Reviewed by David Kilzer.

Following the fix for <rdar://problem/19444383>, run-webkit-tests --ios-sim dies
with an error because it does not know how to parse the output of the simctl tool
to identify an Apple Internal runtime.

  • Scripts/webkitpy/xcode/simulator.py:

(Runtime.init): Add parameter is_internal_runtime (defaults to False).
(Runtime.eq): Take is_internal_runtime when comparing two Runtime objects for equality.
(Runtime.repr): Update printable representation of Runtime object to indicate whether
the runtime is an internal runtime.
(Simulator): Update regular expressions runtime_re and version_re to match an internal runtime.
(Simulator._parse_runtimes): Pass is_internal_runtime to the Runtime constructor with the
appropriate value.
(Simulator._parse_devices): Pass argument is_internal_runtime to Simulator.runtime() so that
it updates the appropriate Runtime object.
(Simulator.runtime): Added optional parameter, is_internal_runtime. Modified to support
looking up a Runtime object for an internal runtime.

10:47 AM Changeset in webkit [178924] by matthew_hanson@apple.com
  • 2 edits in branches/safari-600.5-branch/Source/WebCore

Merge r175771. rdar://problem/19451238

10:47 AM Changeset in webkit [178923] by matthew_hanson@apple.com
  • 7 edits in branches/safari-600.5-branch/Source/WebKit2

Merge r175759. rdar://problem/19450899

10:47 AM Changeset in webkit [178922] by matthew_hanson@apple.com
  • 4 edits
    2 adds in branches/safari-600.5-branch

Merge r175131. rdar://problem/19452187

10:46 AM Changeset in webkit [178921] by matthew_hanson@apple.com
  • 3 edits
    2 adds in branches/safari-600.5-branch

Merge r174716. rdar://problem/19451273

10:46 AM Changeset in webkit [178920] by matthew_hanson@apple.com
  • 3 edits in branches/safari-600.5-branch

Merge r174698. rdar://problem/19451342

10:25 AM Changeset in webkit [178919] by Brent Fulgham
  • 8 edits
    5 adds in trunk/LayoutTests

[Win] More unskips and rebaselines.

  • platform/win/TestExpectations:
  • platform/win/fast/repaint/repaint-across-writing-mode-boundary-expected.png:
  • platform/win/fast/repaint/repaint-across-writing-mode-boundary-expected.txt:
  • platform/win/inspector-protocol: Added.
  • platform/win/inspector-protocol/debugger: Added.
  • platform/win/inspector-protocol/debugger/breakpoint-eval-with-exception-expected.txt: Added.
  • platform/win/inspector-protocol/debugger/setBreakpoint-actions-expected.txt: Added.
  • platform/win/inspector-protocol/debugger/setBreakpoint-dfg-callee-and-examine-dfg-local-expected.txt: Added.
  • platform/win/svg/text/kerning-expected.txt:
  • platform/win/svg/text/multichar-glyph-expected.txt:
  • platform/win/svg/transforms/text-with-mask-with-svg-transform-expected.png:
  • platform/win/svg/transforms/text-with-mask-with-svg-transform-expected.txt:
10:07 AM Changeset in webkit [178918] by rniwa@webkit.org
  • 3 edits in trunk/Source/JavaScriptCore

PropertyListNode::emitNode duplicates the code to put a constant property
​https://bugs.webkit.org/show_bug.cgi?id=140761

Reviewed by Geoffrey Garen.

Extracted PropertyListNode::emitPutConstantProperty to share the code.

Also made PropertyListNode::emitBytecode private since nobody is calling this function directly.

  • bytecompiler/NodesCodegen.cpp:

(JSC::PropertyListNode::emitBytecode):
(JSC::PropertyListNode::emitPutConstantProperty): Added.

  • parser/Nodes.h:
9:59 AM Changeset in webkit [178917] by ap@apple.com
  • 2 edits in trunk/Tools

LeaksViewer doesn't show recent builds if there are less than 10
​https://bugs.webkit.org/show_bug.cgi?id=140716

Reviewed by Tim Horton.

  • BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:
9:21 AM Changeset in webkit [178916] by Brent Fulgham
  • 3 edits in trunk/WebKitLibraries

[Win] Unreviewed gardening.

Activate ENABLE(MOUSE_CURSOR_SCALE). This works on Windows and causes more tests to pass.

  • win/tools/vsprops/FeatureDefines.props:
  • win/tools/vsprops/FeatureDefinesCairo.props:
5:46 AM Changeset in webkit [178915] by Lucas Forschler
  • 1 edit in trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json

Fix up slave distribution for Apple bots.

5:14 AM Changeset in webkit [178914] by Lucas Forschler
  • 1 edit in trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json

Fix json.

5:12 AM Changeset in webkit [178913] by Lucas Forschler
  • 2 edits in trunk/Tools

Add Apple build slaves.
Fixed text alignment for slave list.

Unreviewed.

  • BuildSlaveSupport/build.webkit.org-config/config.json:
4:22 AM Changeset in webkit [178912] by commit-queue@webkit.org
  • 4 edits
    2 adds in trunk/LayoutTests

AX: [ATK] Mark accessibility/list-detection.html as a suitable test for EFL and GTK.
​https://bugs.webkit.org/show_bug.cgi?id=140721

Patch by Andrzej Badowski <​a.badowski@samsung.com> on 2015-01-22
Reviewed by Chris Fleizach.

The test checks the heuristic to determine if a 'list' is really a list.
In the area of ATK a role for description list has been separated from the role AXList.
This made the test stopped giving positive results for ports EFL and GTK.
The proposed amendment restores test for these ports.

  • accessibility/list-detection.html:
  • platform/efl/TestExpectations:
  • platform/efl/accessibility/list-detection-expected.txt: Added.
  • platform/gtk/TestExpectations:
  • platform/gtk/accessibility/list-detection-expected.txt: Added.
2:35 AM WebKitGTK/Roadmap edited by Carlos Garcia Campos
(diff)
2:23 AM Changeset in webkit [178911] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Expected gutter highlight when selecting console input line, just like output line
​https://bugs.webkit.org/show_bug.cgi?id=140696

Patch by Nikita Vasilyev <Nikita Vasilyev> on 2015-01-22
Reviewed by Timothy Hatcher.

  • UserInterface/Views/LogContentView.css:
2:21 AM Changeset in webkit [178910] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebKit2

Fix build warning in WebKit2/UIProcess module
​https://bugs.webkit.org/show_bug.cgi?id=140758

Patch by Shivakumar JM <​shiva.jm@samsung.com> on 2015-01-22
Reviewed by Csaba Osztrogonác.

Fix build warnings by using UNUSED_PARAM macro

  • UIProcess/API/C/WKPageGroup.cpp:

(WKPageGroupAddUserContentFilter):
(WKPageGroupRemoveAllUserContentFilters):

2:18 AM WebKitGTK/Roadmap edited by Carlos Garcia Campos
(diff)
2:09 AM Changeset in webkit [178909] by matthew_hanson@apple.com
  • 2 edits in branches/safari-600.5-branch/Source/JavaScriptCore

Merge r174381. rdar://problem/19450841

2:08 AM Changeset in webkit [178908] by matthew_hanson@apple.com
  • 2 edits in branches/safari-600.5-branch/Source/WTF

Merge r174377. rdar://problem/19451247

2:08 AM Changeset in webkit [178907] by matthew_hanson@apple.com
  • 8 edits in branches/safari-600.5-branch/Source/JavaScriptCore

Merge r174371. rdar://problem/19450845

2:08 AM Changeset in webkit [178906] by matthew_hanson@apple.com
  • 3 edits in branches/safari-600.5-branch/Source/WebCore

Merge r174345. rdar://problem/19451258

2:08 AM Changeset in webkit [178905] by matthew_hanson@apple.com
  • 3 edits in branches/safari-600.5-branch/Source/WebCore

Merge r173790. rdar://problem/19451354

2:04 AM WebKitGTK/Roadmap edited by philn@igalia.com
(diff)
1:32 AM Changeset in webkit [178904] by matthew_hanson@apple.com
  • 3 edits
    2 adds in branches/safari-600.5-branch

Merge r173688. rdar://problem/19451277

1:31 AM Changeset in webkit [178903] by matthew_hanson@apple.com
  • 4 edits
    32 adds in branches/safari-600.5-branch

Merge r172797. rdar://problem/19451324

1:31 AM Changeset in webkit [178902] by matthew_hanson@apple.com
  • 2 edits in branches/safari-600.5-branch/Source/WebKit

Merge r172509. rdar://problem/19451367

1:31 AM Changeset in webkit [178901] by matthew_hanson@apple.com
  • 6 edits
    2 adds in branches/safari-600.5-branch

Merge r172504. rdar://problem/19451367

1:31 AM Changeset in webkit [178900] by matthew_hanson@apple.com
  • 3 edits
    2 adds in branches/safari-600.5-branch

Merge r172326. rdar://problem/19452126

1:11 AM Changeset in webkit [178899] by matthew_hanson@apple.com
  • 2 edits in branches/safari-600.5-branch/Source/WebCore

Merge r171404. rdar://problem/19451349

1:11 AM Changeset in webkit [178898] by matthew_hanson@apple.com
  • 2 edits in branches/safari-600.5-branch/Source/WebCore

Merge r171392. rdar://problem/19451349

1:11 AM Changeset in webkit [178897] by matthew_hanson@apple.com
  • 2 edits in branches/safari-600.5-branch/Source/WebCore

Merge r171388. rdar://problem/19451349

1:11 AM Changeset in webkit [178896] by matthew_hanson@apple.com
  • 2 edits in branches/safari-600.5-branch/Source/WebCore

Merge r171385. rdar://problem/19451349

12:56 AM Changeset in webkit [178895] by svillar@igalia.com
  • 4 edits
    2 adds in trunk

[CSS Grid Layout] Skip items spanning flex tracks when sizing content based tracks
​https://bugs.webkit.org/show_bug.cgi?id=140720

Reviewed by David Hyatt.

Source/WebCore:

Section "11.5. Resolve Intrinsic Track Sizes" of the specs forces
us to ignore items spanning tracks with flex sizing functions when
resolving the content-based track sizing functions. Items with
span < 2 are not affected by this rule (as they will belong to a
single track). This way the algorithm ensures that min-content and
max-content restrictions are fulfilled before distributing the
extra space.

Test: fast/css-grid-layout/flex-and-content-sized-resolution-columns.html

  • rendering/RenderGrid.cpp:

(WebCore::RenderGrid::spanningItemCrossesFlexibleSizedTracks):
(WebCore::integerSpanForDirection):
(WebCore::RenderGrid::resolveContentBasedTrackSizingFunctions):

  • rendering/RenderGrid.h:

LayoutTests:

  • fast/css-grid-layout/flex-and-content-sized-resolution-columns-expected.txt: Added.
  • fast/css-grid-layout/flex-and-content-sized-resolution-columns.html: Added.
12:54 AM Changeset in webkit [178894] by Yusuke Suzuki
  • 31 edits
    3 adds in trunk

put_by_val_direct need to check the property is index or not for using putDirect / putDirectIndex
​https://bugs.webkit.org/show_bug.cgi?id=140426

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

In the put_by_val_direct operation, we use JSObject::putDirect.
However, it only accepts non-index property. For index property, we need to use JSObject::putDirectIndex.
This patch changes Identifier::asIndex() to return Optional<uint32_t>.
It forces callers to check the value is index or not explicitly.
Additionally, it checks toString-ed Identifier is index or not to choose putDirect / putDirectIndex.

  • bytecode/GetByIdStatus.cpp:

(JSC::GetByIdStatus::computeFor):

  • bytecode/PutByIdStatus.cpp:

(JSC::PutByIdStatus::computeFor):

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::emitDirectPutById):

  • dfg/DFGOperations.cpp:

(JSC::DFG::operationPutByValInternal):

  • jit/JITOperations.cpp:
  • jit/Repatch.cpp:

(JSC::emitPutTransitionStubAndGetOldStructure):

  • jsc.cpp:
  • llint/LLIntSlowPaths.cpp:

(JSC::LLInt::LLINT_SLOW_PATH_DECL):

  • runtime/Arguments.cpp:

(JSC::Arguments::getOwnPropertySlot):
(JSC::Arguments::put):
(JSC::Arguments::deleteProperty):
(JSC::Arguments::defineOwnProperty):

  • runtime/ArrayPrototype.cpp:

(JSC::arrayProtoFuncSort):

  • runtime/JSArray.cpp:

(JSC::JSArray::defineOwnProperty):

  • runtime/JSCJSValue.cpp:

(JSC::JSValue::putToPrimitive):

  • runtime/JSGenericTypedArrayViewInlines.h:

(JSC::JSGenericTypedArrayView<Adaptor>::getOwnPropertySlot):
(JSC::JSGenericTypedArrayView<Adaptor>::put):
(JSC::JSGenericTypedArrayView<Adaptor>::defineOwnProperty):
(JSC::JSGenericTypedArrayView<Adaptor>::deleteProperty):

  • runtime/JSObject.cpp:

(JSC::JSObject::put):
(JSC::JSObject::putDirectAccessor):
(JSC::JSObject::putDirectCustomAccessor):
(JSC::JSObject::deleteProperty):
(JSC::JSObject::putDirectMayBeIndex):
(JSC::JSObject::defineOwnProperty):

  • runtime/JSObject.h:

(JSC::JSObject::getOwnPropertySlot):
(JSC::JSObject::getPropertySlot):
(JSC::JSObject::putDirectInternal):

  • runtime/JSString.cpp:

(JSC::JSString::getStringPropertyDescriptor):

  • runtime/JSString.h:

(JSC::JSString::getStringPropertySlot):

  • runtime/LiteralParser.cpp:

(JSC::LiteralParser<CharType>::parse):

  • runtime/PropertyName.h:

(JSC::toUInt32FromCharacters):
(JSC::toUInt32FromStringImpl):
(JSC::PropertyName::asIndex):

  • runtime/PropertyNameArray.cpp:

(JSC::PropertyNameArray::add):

  • runtime/StringObject.cpp:

(JSC::StringObject::deleteProperty):

  • runtime/Structure.cpp:

(JSC::Structure::prototypeChainMayInterceptStoreTo):

Source/WebCore:

Test: js/dfg-put-by-val-direct-with-edge-numbers.html

  • bindings/js/JSDOMWindowCustom.cpp:

(WebCore::JSDOMWindow::getOwnPropertySlot):

  • bindings/js/JSHTMLAllCollectionCustom.cpp:

(WebCore::callHTMLAllCollection):
(WebCore::JSHTMLAllCollection::item):

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateGetOwnPropertySlotBody):
(GenerateImplementation):

  • bindings/scripts/test/JS/JSFloat64Array.cpp:

(WebCore::JSFloat64Array::getOwnPropertySlot):
(WebCore::JSFloat64Array::getOwnPropertyDescriptor):
(WebCore::JSFloat64Array::put):

  • bindings/scripts/test/JS/JSTestEventTarget.cpp:

(WebCore::JSTestEventTarget::getOwnPropertySlot):

  • bridge/runtime_array.cpp:

(JSC::RuntimeArray::getOwnPropertySlot):
(JSC::RuntimeArray::put):

LayoutTests:

  • js/dfg-put-by-val-direct-with-edge-numbers-expected.txt: Added.
  • js/dfg-put-by-val-direct-with-edge-numbers.html: Added.
  • js/script-tests/dfg-put-by-val-direct-with-edge-numbers.js: Added.

(lookupWithKey):
(dfgShouldThrow):
(lookupWithKey2):
(toStringThrowsError.toString):

12:36 AM Changeset in webkit [178893] by svillar@igalia.com
  • 6 edits in trunk

[CSS Grid Layout] Size tracks using a list of all items sorted by span
​https://bugs.webkit.org/show_bug.cgi?id=140615

Reviewed by Andreas Kling.

Source/WebCore:

In r173620 we fixed
RenderGrid::resolveContentBasedTrackSizingFunctions() so that it
now collects all items spanning content-sized tracks and process
them one by one after sorting them by ascending span.

The problem is that it was incorrectly implemented, it has two
important bugs. First one is that the hash table that collects
items is regenerated after processing each track, so it's actually
doing nothing. Secondly we're only sorting the items on each
track, instead of all the items in the grid.

  • rendering/RenderGrid.cpp:

(WebCore::RenderGrid::resolveContentBasedTrackSizingFunctions):

LayoutTests:

  • fast/css-grid-layout/grid-content-sized-columns-resolution-expected.txt:

Added tons of new test cases.

  • fast/css-grid-layout/grid-content-sized-columns-resolution.html: Ditto.
  • fast/css-grid-layout/grid-preferred-logical-widths.html:

Adjusted results.

12:30 AM Changeset in webkit [178892] by Carlos Garcia Campos
  • 11 edits in trunk/Source/WebKit2

[GTK] Use API::ContextMenuClient and API::InjectedBundle::PageContextMenuClient classes
​https://bugs.webkit.org/show_bug.cgi?id=138467

Reviewed by Gustavo Noronha Silva.

  • UIProcess/API/gtk/WebKitContextMenu.cpp:

(webkitContextMenuPopulate): Add a version that receives a Vector<WebContextMenuItemData>&.
(webkitContextMenuCreate): Change it to receive a const
Vector<WebContextMenuItemData>& instead of a API::Array* and also
add a another version that receives const Vector<ContextMenuItem>&.

  • UIProcess/API/gtk/WebKitContextMenuClient.cpp:

(attachContextMenuClientToView): Use a class derived from
API::ContextMenuClient to implement the context menu client.
(getContextMenuFromProposedMenu): Deleted.

  • UIProcess/API/gtk/WebKitContextMenuItem.cpp:

(webkitContextMenuItemCreate): Change it to receive a const
WebContextMenuItemData& and added another version that receives a
const ContextMenuItem&.

  • UIProcess/API/gtk/WebKitContextMenuItemPrivate.h:
  • UIProcess/API/gtk/WebKitContextMenuPrivate.h:
  • UIProcess/API/gtk/WebKitWebView.cpp:

(webkitWebViewPopulateContextMenu): Remove the creation of a
WebHitTestResult::Data, since it receives it now as parameter.

  • UIProcess/API/gtk/WebKitWebViewPrivate.h:
  • WebProcess/InjectedBundle/API/gtk/WebKitWebHitTestResult.cpp:

(webkitWebHitTestResultCreate): Change it to receive a const
HitTestResult& instead of const InjectedBundleHitTestResult&.

  • WebProcess/InjectedBundle/API/gtk/WebKitWebHitTestResultPrivate.h:
  • WebProcess/InjectedBundle/API/gtk/WebKitWebPage.cpp:

(webkitWebPageCreate): Use a class derived from
API::InjectedBundle::PageContextMenuClient to implement the
context menu client.
(getContextMenuFromDefaultMenu): Deleted.

12:05 AM Changeset in webkit [178891] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebKit2

Unreviewed. Try to fix Debug build after r178889.

  • UIProcess/API/C/WKPage.cpp: Include Logging.h.
12:02 AM Changeset in webkit [178890] by matthew_hanson@apple.com
  • 3 edits in branches/safari-600.5-branch/Source/WebCore

Merge r171357. rdar://problem/19451349

Jan 21, 2015:

11:53 PM Changeset in webkit [178889] by Carlos Garcia Campos
  • 13 edits
    1 copy
    1 move
    1 delete in trunk/Source/WebKit2

Add API::ContextMenuClient and API::InjectedBundle::PageContextMenuClient classes
​https://bugs.webkit.org/show_bug.cgi?id=138466

Reviewed by Anders Carlsson.

Move ContextMenuClient to use API classes in both UI and Injected
Bundle APIs.

  • CMakeLists.txt: Remove WebPageContextMenuClient.cpp.
  • UIProcess/API/APIContextMenuClient.h: Renamed from Source/WebKit2/UIProcess/WebPageContextMenuClient.h.

(API::ContextMenuClient::~ContextMenuClient):
(API::ContextMenuClient::getContextMenuFromProposedMenu):
(API::ContextMenuClient::customContextMenuItemSelected):
(API::ContextMenuClient::contextMenuDismissed):
(API::ContextMenuClient::showContextMenu):
(API::ContextMenuClient::hideContextMenu):

  • UIProcess/API/C/WKPage.cpp:

(WKPageSetPageContextMenuClient):

  • UIProcess/WebPageContextMenuClient.cpp: Removed.
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::setContextMenuClient):
(WebKit::WebPageProxy::close):
(WebKit::WebPageProxy::internalShowContextMenu):
(WebKit::WebPageProxy::contextMenuItemSelected):
(WebKit::WebPageProxy::initializeContextMenuClient): Deleted.

  • UIProcess/WebPageProxy.h:
  • WebKit2.xcodeproj/project.pbxproj: Remove deleted files and add

new files to compilation.

  • WebProcess/InjectedBundle/API/APIInjectedBundlePageContextMenuClient.h: Copied from Source/WebKit2/WebProcess/InjectedBundle/InjectedBundlePageContextMenuClient.h.

(API::InjectedBundle::PageContextMenuClient::~PageContextMenuClient):
(API::InjectedBundle::PageContextMenuClient::getCustomMenuFromDefaultItems):
(API::InjectedBundle::PageContextMenuClient::prepareForActionMenu):

  • WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:

(WKBundlePageSetContextMenuClient):

  • WebProcess/InjectedBundle/InjectedBundlePageContextMenuClient.cpp:

(WebKit::InjectedBundlePageContextMenuClient::InjectedBundlePageContextMenuClient):
(WebKit::InjectedBundlePageContextMenuClient::getCustomMenuFromDefaultItems):
(WebKit::InjectedBundlePageContextMenuClient::prepareForActionMenu):

  • WebProcess/InjectedBundle/InjectedBundlePageContextMenuClient.h:
  • WebProcess/WebPage/WebContextMenu.cpp:

(WebKit::WebContextMenu::menuItemsWithUserData):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::WebPage):
(WebKit::WebPage::setInjectedBundleContextMenuClient):
(WebKit::WebPage::close):
(WebKit::WebPage::initializeInjectedBundleContextMenuClient): Deleted.

  • WebProcess/WebPage/WebPage.h:

(WebKit::WebPage::injectedBundleContextMenuClient):

  • WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::WebPage::performActionMenuHitTestAtLocation):

10:39 PM Changeset in webkit [178888] by rniwa@webkit.org
  • 6 edits
    1 add in trunk/Source/JavaScriptCore

Consolidate out arguments of parseFunctionInfo into a struct
​https://bugs.webkit.org/show_bug.cgi?id=140754

Reviewed by Oliver Hunt.

Introduced ParserFunctionInfo for storing out arguments of parseFunctionInfo.

(JSC::ASTBuilder::createFunctionExpr):
(JSC::ASTBuilder::createGetterOrSetterProperty): This one takes a property name in addition to
ParserFunctionInfo since the property name and the function name could differ.
(JSC::ASTBuilder::createFuncDeclStatement):

  • parser/Parser.cpp:

(JSC::Parser<LexerType>::parseFunctionInfo):
(JSC::Parser<LexerType>::parseFunctionDeclaration):
(JSC::Parser<LexerType>::parseProperty):
(JSC::Parser<LexerType>::parseMemberExpression):

  • parser/Parser.h:
  • parser/ParserFunctionInfo.h: Added.
  • parser/SyntaxChecker.h:

(JSC::SyntaxChecker::createFunctionExpr):
(JSC::SyntaxChecker::createFuncDeclStatement):
(JSC::SyntaxChecker::createClassDeclStatement):
(JSC::SyntaxChecker::createGetterOrSetterProperty):

10:01 PM Changeset in webkit [178887] by Brent Fulgham
  • 14 edits
    4 adds in trunk/LayoutTests

[Win] Rebaseline SVG results from test machine.

  • platform/win/css2.1/20110323/c543-txt-decor-000-expected.png: Added.
  • platform/win/css2.1/20110323/c543-txt-decor-000-expected.txt: Added.
  • platform/win/css2.1/20110323/replaced-elements-001-expected.png: Added.
  • platform/win/css2.1/20110323/replaced-elements-001-expected.txt: Added.
  • platform/win/svg/W3C-SVG-1.1-SE/styling-css-04-f-expected.txt:
  • platform/win/svg/W3C-SVG-1.1/filters-light-04-f-expected.txt:
  • platform/win/svg/W3C-SVG-1.1/fonts-elem-05-t-expected.txt:
  • platform/win/svg/W3C-SVG-1.1/fonts-elem-06-t-expected.txt:
  • platform/win/svg/W3C-SVG-1.1/fonts-kern-01-t-expected.txt:
  • platform/win/svg/W3C-SVG-1.1/masking-mask-01-b-expected.txt:
  • platform/win/svg/W3C-SVG-1.1/render-elems-06-t-expected.txt:
  • platform/win/svg/W3C-SVG-1.1/render-elems-07-t-expected.txt:
  • platform/win/svg/W3C-SVG-1.1/render-elems-08-t-expected.txt:
  • platform/win/svg/W3C-SVG-1.1/render-groups-01-b-expected.txt:
  • platform/win/svg/W3C-SVG-1.1/render-groups-03-t-expected.txt:
  • platform/win/svg/W3C-SVG-1.1/text-align-08-b-expected.txt:
  • platform/win/svg/W3C-SVG-1.1/text-tselect-02-f-expected.txt:
9:31 PM Changeset in webkit [178886] by Brent Fulgham
  • 2 edits in trunk/LayoutTests

[Win] Update expectations file for failures on test machine.

  • platform/win/TestExpectations:
8:57 PM Changeset in webkit [178885] by Brent Fulgham
  • 2 edits
    2 adds in trunk/LayoutTests

[Win] Add more tests and baselines.

Stop skipping a number of tests that are fully functional. Add some
Windows baselines.

  • platform/win/TestExpectations:
  • platform/win/printing/setPrinting-expected.txt: Added.
  • platform/win/printing/width-overflow-expected.txt: Added.
6:56 PM Changeset in webkit [178884] by mhahnenb@gmail.com
  • 4 edits in trunk/Source/JavaScriptCore

Change Heap::m_compiledCode to use a Vector
​https://bugs.webkit.org/show_bug.cgi?id=140717

Reviewed by Andreas Kling.

Right now it's a DoublyLinkedList, which is iterated during each
collection. This contributes to some of the longish Eden pause times.
A Vector would be more appropriate and would also allow ExecutableBase
to be 2 pointers smaller.

  • heap/Heap.cpp:

(JSC::Heap::deleteAllCompiledCode):
(JSC::Heap::deleteAllUnlinkedFunctionCode):
(JSC::Heap::clearUnmarkedExecutables):

  • heap/Heap.h:
  • runtime/Executable.h: No longer need to inherit from DoublyLinkedListNode.
6:08 PM Changeset in webkit [178883] by Brent Fulgham
  • 2 edits in trunk/LayoutTests

[Win] More gardening.

Unskip the flexbox tests. These have been functional in Windows for YEARS!

  • platform/win/TestExpectations:
6:06 PM Changeset in webkit [178882] by rniwa@webkit.org
  • 4 edits in trunk/Source/JavaScriptCore

BytecodeGenerator shouldn't expose all of its member variables
​https://bugs.webkit.org/show_bug.cgi?id=140752

Reviewed by Mark Lam.

Added "private:" and removed unused data members as detected by clang.

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::BytecodeGenerator):

  • bytecompiler/BytecodeGenerator.h:

(JSC::BytecodeGenerator::lastOpcodeID): Added. Used in BinaryOpNode::emitBytecode.

  • bytecompiler/NodesCodegen.cpp:

(JSC::BinaryOpNode::emitBytecode):

6:06 PM Changeset in webkit [178881] by Lucas Forschler
  • 2 edits in trunk/Tools

Teach build.webkit.org about bot308 and bot309.

Unreviewed.

  • BuildSlaveSupport/build.webkit.org-config/config.json:
5:31 PM Changeset in webkit [178880] by Brent Fulgham
  • 2 edits in trunk/LayoutTests

[Win] Gardening pass over file.

Convert Skips to Failure wherever possible. Try to delete unnecessary skips/failures.

  • platform/win/TestExpectations:
5:21 PM Changeset in webkit [178879] by bshafiei@apple.com
  • 2 edits in branches/safari-600.1.4.15-branch/Source/WebCore

Merged r178072. rdar://problem/19395123

5:20 PM Changeset in webkit [178878] by bshafiei@apple.com
  • 2 edits in branches/safari-600.1.4.15-branch/Source/WebKit2

Merged r177329. rdar://problem/19419784

5:19 PM Changeset in webkit [178877] by bshafiei@apple.com
  • 3 edits
    1 copy in branches/safari-600.1.4.15-branch

Merged r177115. rdar://problem/19420090

5:10 PM Changeset in webkit [178876] by timothy_horton@apple.com
  • 2 edits in trunk/LayoutTests

After updating tests to use kerning, ligatures, and printer fonts, some tests fail
​https://bugs.webkit.org/show_bug.cgi?id=139968

  • platform/mac/TestExpectations:

Mark svg/custom/svg-fonts-without-missing-glyph.xhtml as flaky.

5:03 PM Changeset in webkit [178875] by commit-queue@webkit.org
  • 4 edits in trunk

Web Inspector: ASSERT expanding objects in console PrimitiveBindingTraits<T>::assertValueHasExpectedType
​https://bugs.webkit.org/show_bug.cgi?id=140746

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-01-21
Reviewed by Timothy Hatcher.

Source/JavaScriptCore:

  • inspector/InjectedScriptSource.js:

Do not add impure properties to the descriptor object that will
eventually be sent to the frontend.

LayoutTests:

Unskip the test now that is doesn't ASSERT in debug builds.

4:50 PM Changeset in webkit [178874] by dbates@webkit.org
  • 2 edits in trunk/Source/WebCore

Fix the iOS release build after <​http://trac.webkit.org/changeset/178868>
(​https://bugs.webkit.org/show_bug.cgi?id=140742)

Substitute ASSERT_UNUSED() for ASSERT() since the parameter layer is used only in the assertion expression.

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::needsIOSDumpRenderTreeMainFrameRenderViewLayerIsAlwaysOpaqueHack):

4:22 PM Changeset in webkit [178873] by Lucas Forschler
  • 2 edits in trunk/Tools

Add two Apple Mavericks slaves.

Unreviewed.

  • BuildSlaveSupport/build.webkit.org-config/config.json:
4:04 PM Changeset in webkit [178872] by dbates@webkit.org
  • 3 edits
    90 deletes in trunk/LayoutTests

Update iOS WebKit2 expected results for compositing tests

Following the patch for bug #140742, <​https://bugs.webkit.org/show_bug.cgi?id=140742>, we can remove
all iOS WebKit2-specific expected results that are identical to the platform-independent results.

  • platform/ios-simulator-wk2/TestExpectations: Add WebKit2-specific failures: compositing/reflections/nested-reflection-on-overflow.html

and compositing/repaint/invalidations-on-composited-layers.html.

  • platform/ios-simulator-wk2/compositing/absolute-inside-out-of-view-fixed-expected.txt: Removed.

[...]

  • platform/ios-simulator-wk2/compositing/tiling/rotated-tiled-preserve3d-clamped-expected.txt: Removed.
  • platform/ios-simulator-wk2/compositing/visibility/layer-visible-content-expected.txt: Removed.
  • platform/ios-simulator-wk2/compositing/visible-rect/3d-transform-style-expected.txt: Removed.
  • platform/ios-simulator/TestExpectations: Remove tests that now pass in both iOS WebKit1 and WebKit2.
3:56 PM WebKitGTK/Roadmap edited by Adrian Perez de Castro
Add link to long-tap context-menu bug (diff)
3:52 PM Changeset in webkit [178871] by dbates@webkit.org
  • 3 edits in trunk/LayoutTests

Update iOS WebKit test expectations for compositing tests

  • platform/ios-simulator-wk1/TestExpectations:
  • platform/ios-simulator/TestExpectations:
3:47 PM WebKitGTK/Roadmap edited by Adrian Perez de Castro
Add link to Python web-extension bug (diff)
3:47 PM Changeset in webkit [178870] by jhoneycutt@apple.com
  • 7 edits in trunk/Source/WebKit2

[iOS] WebKitTestRunner: Tests fail due to incorrect web view size

<​https://bugs.webkit.org/show_bug.cgi?id=139736>
<rdar://problem/19282196>

This starts happening after we fail to reset the test controller to
consistent values in TestInvocation::invoke(). When we terminate the
web process and relaunch it, the new WebPage object created in the web
process is using the default ViewportConfiguration with dimensions of
1024x768.

The PageClient on iOS currently notifies the WKWebView and the
WKContentView when the web process is relaunched. This patch extends
that to also notify the WKView.

Reviewed by Benjamin Poulain.

  • UIProcess/API/Cocoa/WKViewPrivate.h:

Declare -_didRelaunchProcess.

  • UIProcess/API/ios/WKViewIOS.mm:

(-[WKView _commonInitializationWithContextRef:pageGroupRef:relatedToPage:]):
Call the new method that accepts a WKView.
(-[WKView _didRelaunchProcess]):
Call -_frameOrBoundsChanged to update the web process's size to the
size of the WKView.

  • UIProcess/ios/PageClientImplIOS.h:

Add a constructor that takes a WKView, and add a member var to hold it.

  • UIProcess/ios/PageClientImplIOS.mm:

(WebKit::PageClientImpl::PageClientImpl):
Implement the constructor that takes a WKView.
(WebKit::PageClientImpl::didRelaunchProcess):
Tell the WKView that the web process relaunched.

  • UIProcess/ios/WKContentView.h:

Declare an initializer that takes a WKView.

  • UIProcess/ios/WKContentView.mm:

(-[WKContentView _commonInitializationWithProcessPool:configuration:]):
Split out from -[WKContentView initWithFrame:processPool:configuration:webView:].
(-[WKContentView initWithFrame:processPool:configuration:webView:]):
Perform some initialization, including creating the PageClient, and
call the common initializer.
(-[WKContentView initWithFrame:processPool:configuration:wkView:]):
Ditto.

3:44 PM Changeset in webkit [178869] by weinig@apple.com
  • 10 edits in trunk/Source/WebKit2

Add WKPageGroupRef SPI for user content filters
​https://bugs.webkit.org/show_bug.cgi?id=140728

Reviewed by Anders Carlsson.

While Safari is transitioning to WKUserContentController, it is useful
for them to have access to have access to content filters on the page group
where they currently have user content related functionality.

  • Shared/WebPageGroupData.cpp:

(WebKit::WebPageGroupData::encode):
(WebKit::WebPageGroupData::decode):

  • Shared/WebPageGroupData.h:
  • UIProcess/API/C/WKPageGroup.cpp:

(WKPageGroupAddUserContentFilter):
(WKPageGroupRemoveAllUserContentFilters):

  • UIProcess/API/C/WKPageGroup.h:
  • UIProcess/WebPageGroup.cpp:

(WebKit::WebPageGroup::addUserContentFilter):
(WebKit::WebPageGroup::removeAllUserContentFilters):

  • UIProcess/WebPageGroup.h:
  • WebProcess/WebPage/WebPageGroupProxy.cpp:

(WebKit::WebPageGroupProxy::WebPageGroupProxy):
(WebKit::WebPageGroupProxy::addUserContentFilter):
(WebKit::WebPageGroupProxy::removeAllUserContentFilters):

  • WebProcess/WebPage/WebPageGroupProxy.h:
  • WebProcess/WebPage/WebPageGroupProxy.messages.in:
3:42 PM Changeset in webkit [178868] by dbates@webkit.org
  • 8 edits
    1 delete in trunk

[iOS] Many compositing tests fail in DumpRenderTree due to contentsOpaque difference
​https://bugs.webkit.org/show_bug.cgi?id=140742

Reviewed by Simon Fraser.

Source/WebCore:

Make RenderLayerBacking::layerTreeAsText() (including internals.layerTreeAsText()) always
report that the main frame's RenderView layer is opaque when running iOS DumpRenderTree to
avoid test failures and the need to maintain for iOS WebKit1 an almost identical copy of the
platform-independent compositing test results.

The main frame's RenderView layer is always transparent in iOS WebKit1 since it does
not make use of a tiled cache layer and defers to UIKit to handle the final compositing
of the web view, including applying the page scale factor.

  • platform/RuntimeApplicationChecksIOS.mm:

(WebCore::applicationIsDumpRenderTree): The app bundle identifier of DumpRenderTree has
the form org.webkit.DumpRenderTreeX where X is some non-negative integer.

  • platform/graphics/GraphicsLayer.cpp:

(WebCore::GraphicsLayer::dumpProperties): Modified to report that a layer is opaque when
GraphicsLayerClient::needsIOSDumpRenderTreeMainFrameRenderViewLayerIsAlwaysOpaqueHack() returns true.

  • platform/graphics/GraphicsLayerClient.h:

(WebCore::GraphicsLayerClient::needsIOSDumpRenderTreeMainFrameRenderViewLayerIsAlwaysOpaqueHack): Added
default implementation (returns false).

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::needsIOSDumpRenderTreeMainFrameRenderViewLayerIsAlwaysOpaqueHack): Added;
returns true when running in DumpRenderTree and the passed GraphicsLayer corresponds to the main frame's
RenderView layer.

  • rendering/RenderLayerBacking.h:

LayoutTests:

Update test expectations and remove an unnecessary test result.

  • platform/ios-simulator/TestExpectations:
  • platform/ios-simulator/compositing/backing/backface-visibility-flip-expected.txt: Removed.
3:29 PM Changeset in webkit [178867] by dbates@webkit.org
  • 4 edits
    2 adds in trunk

Add iOS WebKit1 TestExpectation file
​https://bugs.webkit.org/show_bug.cgi?id=140739

Reviewed by David Kilzer.

Tools:

Teach run-webkit-tests to look for iOS WebKit1-specific test results and
expectations in directory LayoutTests/platform/ios-simulator-wk1.

  • Scripts/webkitpy/port/ios.py:

(IOSSimulatorPort.default_baseline_search_path):

LayoutTests:

iOS WebKit1 is different enough from iOS WebKit2 that it would benefit from having its
own TestExpectation file. We can work to reduce such differences over time.

  • platform/ios-simulator-wk1/TestExpectations: Added.
  • platform/ios-simulator/TestExpectations: Move iOS WebKit1-specific test expectation from here

to file LayoutTests/platform/ios-simulator-wk1/TestExpectations.

3:21 PM Changeset in webkit [178866] by ddkilzer@apple.com
  • 2 edits in trunk/Tools

[iOS] Update configure-xcode-for-ios-development to copy missing headers to iphoneos SDK
<​http://webkit.org/b/140704>

Reviewed by Daniel Bates.

  • Scripts/configure-xcode-for-ios-development:
  • Update copyright.
  • Remove FIXME addressed by r178709.
  • Call copyMissingHeadersToIPhoneOSSDKIfNeeded().

(copyMissingHeadersToIPhoneOSSDKIfNeeded): Add method to copy
missing headers from iphonesimulator SDK to iphoneos SDK.
(sdkDirectory): Add method that returns SDK directory.
(sdkPlatformDirectory): Extract method from
xcodeSDKSpecificationsPath() that returns SDK platform
directory.
(xcodeSDKSpecificationsPath): Update to use
sdkPlatformDirectory().

3:14 PM Changeset in webkit [178865] by roger_fong@apple.com
  • 2 edits in trunk/Source/WebCore

WebGL2 (spec section 3.1): Add new types to WebGL2 API.
​https://bugs.webkit.org/show_bug.cgi?id=140741.
<rdar://problem/19552962>

Reviewed by Dean Jackson.

  • html/canvas/WebGL2RenderingContext.idl:
3:04 PM Changeset in webkit [178864] by saambarati1@gmail.com
  • 5 edits in trunk/Source/WebInspectorUI

Web Inspector: Change Annotator's isActive getter into an isActive() function.
​https://bugs.webkit.org/show_bug.cgi?id=140729

Reviewed by Timothy Hatcher.

This patch also makes the child classes of Annotator use
the function instead of accessing the property directly.

  • UserInterface/Controllers/Annotator.js:

(WebInspector.Annotator.prototype.isActive):
(WebInspector.Annotator.prototype.get isActive): Deleted.

  • UserInterface/Controllers/BasicBlockAnnotator.js:

(WebInspector.BasicBlockAnnotator.prototype.insertAnnotations):

  • UserInterface/Controllers/TypeTokenAnnotator.js:

(WebInspector.TypeTokenAnnotator.prototype.toggleTypeAnnotations):

  • UserInterface/Views/SourceCodeTextEditor.js:

(WebInspector.SourceCodeTextEditor.prototype.toggleTypeAnnotations):
(WebInspector.SourceCodeTextEditor.prototype.prettyPrint):
(WebInspector.SourceCodeTextEditor.prototype._debuggerDidPause):
(WebInspector.SourceCodeTextEditor.prototype._debuggerDidResume):
(WebInspector.SourceCodeTextEditor.prototype._updateTokenTrackingControllerState):

2:51 PM Changeset in webkit [178863] by saambarati1@gmail.com
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Don't allow the BasicBlockAnnotator to highlight a section if it's only a closing brace
​https://bugs.webkit.org/show_bug.cgi?id=140727

Reviewed by Timothy Hatcher.

  • UserInterface/Controllers/BasicBlockAnnotator.js:

(WebInspector.BasicBlockAnnotator.prototype.set _highlightTextForBasicBlock):
(WebInspector.BasicBlockAnnotator.prototype._isTextRangeOnlyClosingBrace):
BasicBlockAnnotator tries to no longer highlight a basic block if it is only
whitespace and a closing brace. These ranges are often after statements
that make these basic blocks unreachable, such as a return/break/continue
statement occurring inside a if/else/while/for block. This check won't
match every highlighted empty closing brace, but catches most of them
because it only does intra block analysis instead of inter block analysis.

2:51 PM Changeset in webkit [178862] by Alan Bujtas
  • 4 edits in trunk/Source/WebCore

Simple line layout: Move nextTextFragment() to FlowContents class.
​https://bugs.webkit.org/show_bug.cgi?id=140738

Reviewed by Antti Koivisto.

This is in preparation to make FlowContents an iterator class.

No change in functionality.

  • rendering/SimpleLineLayout.cpp:

(WebCore::SimpleLineLayout::LineState::addUncommitted):
(WebCore::SimpleLineLayout::LineState::addUncommittedWhitespace):
(WebCore::SimpleLineLayout::removeTrailingWhitespace):
(WebCore::SimpleLineLayout::initializeNewLine):
(WebCore::SimpleLineLayout::splitFragmentToFitLine):
(WebCore::SimpleLineLayout::createLineRuns):
(WebCore::SimpleLineLayout::TextFragment::TextFragment): Deleted.
(WebCore::SimpleLineLayout::TextFragment::isEmpty): Deleted.
(WebCore::SimpleLineLayout::nextFragment): Deleted.

  • rendering/SimpleLineLayoutFlowContents.cpp:

(WebCore::SimpleLineLayout::FlowContents::nextTextFragment):

  • rendering/SimpleLineLayoutFlowContents.h:

(WebCore::SimpleLineLayout::FlowContents::TextFragment::TextFragment):
(WebCore::SimpleLineLayout::FlowContents::TextFragment::isEmpty):

2:49 PM Changeset in webkit [178861] by ggaren@apple.com
  • 14 edits
    2 adds in trunk

bmalloc: support aligned allocation
​https://bugs.webkit.org/show_bug.cgi?id=140732

Reviewed by Andreas Kling.

PerformanceTests:

  • MallocBench/MallocBench.xcodeproj/project.pbxproj:
  • MallocBench/MallocBench/Benchmark.cpp:
  • MallocBench/MallocBench/memalign.cpp:

(test):
(benchmark_memalign): Added a test for specific interesting memalign values.

  • MallocBench/MallocBench/stress_aligned.cpp: Added.

(benchmark_stress_aligned):

  • MallocBench/MallocBench/stress_aligned.h: Added. Added a stress test

for arbitrary memalign values.

Source/bmalloc:

  • bmalloc/Allocator.cpp:

(bmalloc::Allocator::allocate): New function for aligned allocation.

Small and medium requests just allocate and free until they find an
aligned pointer. This is slightly inefficient in the worst case, but
still constant-time with little-to-no space overhead.

Large requests use a new API that requires the client to specify both
its ideal size and alignment, and the worst-case size you would have to
allocate in order to produce some interior pointer of the requested size
and alignment. We put the burden of this calculation on the client
because it simplifies things if we guarantee that allocation won't fail.

XLarge requests are easy: we just forward them to vmAllocate, which
already supported aligned requests.

  • bmalloc/BoundaryTag.h:
  • bmalloc/BoundaryTagInlines.h:

(bmalloc::BoundaryTag::mergeLeft):
(bmalloc::BoundaryTag::mergeRight):
(bmalloc::BoundaryTag::merge):
(bmalloc::BoundaryTag::deallocate):
(bmalloc::BoundaryTag::split):
(bmalloc::BoundaryTag::allocate): No behavior change here. I just
refactored the interface to remove some reference out parameters in
order to clarify what changes and what doesn't.

  • bmalloc/Heap.cpp:

(bmalloc::Heap::allocateXLarge): Added an alignment API.

(bmalloc::Heap::allocateLarge):

  • bmalloc/Heap.h: Added an alignment API. I split out allocateLarge into

a few variants, so aligned and unaligned allocation could share some code.

  • bmalloc/SegregatedFreeList.cpp:

(bmalloc::SegregatedFreeList::take):

  • bmalloc/SegregatedFreeList.h: Changed to use a separate, explicit API

for aligned allocation. It turns out that the aligned path is pretty
different, since it ends up searching for two potential ways to satisfy
an allocation: either large enough and aligned, or large enough to split
into something not aligned and something large enough and aligned.

  • bmalloc/VMAllocate.h:

(bmalloc::vmAllocate): Switched alignment to come before size because
that's how the memalign API specifies it.

  • bmalloc/VMHeap.h:

(bmalloc::VMHeap::allocateLargeRange): Added an alignment API.

2:43 PM Changeset in webkit [178860] by mmirman@apple.com
  • 2 edits
    1 add in trunk/Source/JavaScriptCore

Updated split such that it does not include the empty end of input string match.
​https://bugs.webkit.org/show_bug.cgi?id=138129
<rdar://problem/18807403>

Reviewed by Filip Pizlo.

  • runtime/StringPrototype.cpp:

(JSC::stringProtoFuncSplit):

  • tests/stress/empty_eos_regex_split.js: Added.
2:33 PM Changeset in webkit [178859] by akling@apple.com
  • 13 edits in trunk/Source/WebCore

DocumentLoader::timing() should return a reference.
<​https://webkit.org/b/128272>

Reviewed by Antti Koivisto.

There is always a DocumentLoadTiming object, so return it by
reference since it can never be null.

  • Modules/gamepad/NavigatorGamepad.cpp:

(WebCore::NavigatorGamepad::from):

  • dom/ScriptedAnimationController.cpp:

(WebCore::ScriptedAnimationController::serviceScriptedAnimations):

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::parseAttribute):

  • inspector/InspectorResourceAgent.cpp:

(WebCore::buildObjectForTiming):

  • loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::finishedLoading):
(WebCore::DocumentLoader::willSendRequest):
(WebCore::DocumentLoader::continueAfterNavigationPolicy):
(WebCore::DocumentLoader::startLoadingMainResource):

  • loader/DocumentLoader.h:

(WebCore::DocumentLoader::timing):

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::stopLoading):
(WebCore::FrameLoader::commitProvisionalLoad):
(WebCore::FrameLoader::loadProvisionalItemFromCachedPage):

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::dispatchLoadEvent):

  • page/Performance.cpp:

(WebCore::Performance::now):

  • page/PerformanceNavigation.cpp:

(WebCore::PerformanceNavigation::redirectCount):

  • page/PerformanceResourceTiming.cpp:

(WebCore::monotonicTimeToDocumentMilliseconds):
(WebCore::PerformanceResourceTiming::resourceTimeToDocumentMilliseconds):

  • page/PerformanceTiming.cpp:

(WebCore::PerformanceTiming::documentLoadTiming):

2:30 PM Changeset in webkit [178858] by Beth Dakin
  • 4 edits in trunk/Source

Crash in QuickLook preview delegate method
​https://bugs.webkit.org/show_bug.cgi?id=140740
-and corresponding-
rdar://problem/19540806

Reviewed by Tim Horton.

Clear out the delegate.
Source/WebKit/mac:

  • WebView/WebImmediateActionController.mm:

(-[WebImmediateActionController webViewClosed]):

Source/WebKit2:

  • UIProcess/mac/WKImmediateActionController.mm:

(-[WKImmediateActionController willDestroyView:]):

1:56 PM Changeset in webkit [178857] by benjamin@webkit.org
  • 8 edits in trunk/Source/WebCore

Handle the transition on any character as a separate type of transition
​https://bugs.webkit.org/show_bug.cgi?id=140711

Reviewed by Andreas Kling.

Instead of considering the universal transition as 127 transitions, it is now
handled as a separate type of transition.

The goal is to reduce the number of exit edge to consider for each node. Instead
of having 127 for any partition containing one universal transition, we have
as few exit edges as necessary + one universal transition.

In the NFA, the universal transition is stored directly on NFANode in a new
HashSet (transitionsOnAnyCharacter).
The target nodes are made exclusive between "transitionsOnAnyCharacter" and "transitions"
by construction. That is not strictly needed but it simplify debugging at the moment.

When converting a NFA to a DFA, we first find all the node that transition on any character.
Then, when we iterate over "real" transition, we also augment that set with the set on
any character.

When creating the DFA node, we first consider each "real" transition, then we have a single
"fallback" transition for any character that has not been handled yet.

When matching, we first search for any real transition. If there is none but a fallback exists,
we take the fallback.

  • contentextensions/DFA.cpp:

(WebCore::ContentExtensions::DFA::nextState):
(WebCore::ContentExtensions::printTransitions):
(WebCore::ContentExtensions::DFA::debugPrintDot):
(WebCore::ContentExtensions::printTransition): Deleted.

  • contentextensions/DFANode.h:
  • contentextensions/NFA.cpp:

(WebCore::ContentExtensions::NFA::addTransition):
(WebCore::ContentExtensions::NFA::addTransitionsOnAnyCharacter):
(WebCore::ContentExtensions::printTransitions):
(WebCore::ContentExtensions::NFA::debugPrintDot):
(WebCore::ContentExtensions::printTransition): Deleted.

  • contentextensions/NFA.h:
  • contentextensions/NFANode.h:
  • contentextensions/NFAToDFA.cpp:

(WebCore::ContentExtensions::populateTransitions):
(WebCore::ContentExtensions::getOrCreateDFANode):
(WebCore::ContentExtensions::NFAToDFA::convert):

  • contentextensions/URLFilterParser.cpp:

(WebCore::ContentExtensions::GraphBuilder::generateTransition):

1:43 PM Changeset in webkit [178856] by msaboff@apple.com
  • 22 edits in trunk/Source/JavaScriptCore

Eliminate Scope slot from JavaScript CallFrame
​https://bugs.webkit.org/show_bug.cgi?id=136724

Reviewed by Geoffrey Garen.

This finishes the removal of the scope chain slot from the call frame header.

  • dfg/DFGOSRExitCompilerCommon.cpp:

(JSC::DFG::reifyInlinedCallFrames):

  • dfg/DFGPreciseLocalClobberize.h:

(JSC::DFG::PreciseLocalClobberizeAdaptor::readTop):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::emitCall):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::emitCall):

  • ftl/FTLJSCall.cpp:

(JSC::FTL::JSCall::emit):

  • ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::compileNativeCallOrConstruct):
(JSC::FTL::LowerDFGToLLVM::compileCallOrConstruct):

  • interpreter/JSStack.h:
  • interpreter/VMInspector.cpp:

(JSC::VMInspector::dumpFrame):

  • jit/JITCall.cpp:

(JSC::JIT::compileOpCall):

  • jit/JITCall32_64.cpp:

(JSC::JIT::compileOpCall):

  • jit/JITOpcodes32_64.cpp:

(JSC::JIT::privateCompileCTINativeCall):

  • jit/Repatch.cpp:

(JSC::generateByIdStub):
(JSC::linkClosureCall):

  • jit/ThunkGenerators.cpp:

(JSC::virtualForThunkGenerator):
(JSC::nativeForGenerator):
Deleted ScopeChain slot from JSStack. Removed all code where ScopeChain was being
read or set. In most cases this was where we make JS calls.

  • interpreter/CallFrameClosure.h:

(JSC::CallFrameClosure::setArgument):
(JSC::CallFrameClosure::resetCallFrame): Deleted.

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::execute):
(JSC::Interpreter::executeCall):
(JSC::Interpreter::executeConstruct):
(JSC::Interpreter::prepareForRepeatCall):

  • interpreter/ProtoCallFrame.cpp:

(JSC::ProtoCallFrame::init):

  • interpreter/ProtoCallFrame.h:

(JSC::ProtoCallFrame::scope): Deleted.
(JSC::ProtoCallFrame::setScope): Deleted.

  • llint/LLIntData.cpp:

(JSC::LLInt::Data::performAssertions):

  • llint/LowLevelInterpreter.asm:
  • llint/LowLevelInterpreter64.asm:

Removed the related scopeChainValue member from ProtoCallFrame. Reduced the number of
registers that needed to be copied from the ProtoCallFrame to a callee's frame
from 5 to 4.

  • llint/LowLevelInterpreter32_64.asm:

In addition to the prior changes, also deleted the unused macro getDeBruijnScope.

11:46 AM Changeset in webkit [178855] by msaboff@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Eliminate construct methods from NullGetterFunction and NullSetterFunction classes
​https://bugs.webkit.org/show_bug.cgi?id=140708

Reviewed by Mark Lam.

Eliminated construct methods and change getConstructData() for both classes to return
ConstructTypeNone as they can never be called.

  • runtime/NullGetterFunction.cpp:

(JSC::NullGetterFunction::getConstructData):
(JSC::constructReturnUndefined): Deleted.

  • runtime/NullSetterFunction.cpp:

(JSC::NullSetterFunction::getConstructData):
(JSC::constructReturnUndefined): Deleted.

11:35 AM Changeset in webkit [178854] by commit-queue@webkit.org
  • 470 edits
    20 moves
    1 add in trunk/LayoutTests/imported/w3c

Move w3c/canvas/resources/ common resources to w3c/resources/.
​https://bugs.webkit.org/show_bug.cgi?id=140712.

Patch by Said Abou-Hallawa <​sabouhallawa@apple.com> on 2015-01-21
Reviewed by Alexey Proskuryakov.

Move the w3c common resources from w3c/canvas/resources/ to w3c/resources/. All
the paths to the common resources from the w3c/canvas and w3c/common should be
../resources/<file name> instead of resources/<file name>

  • canvas/2d.clearRect.basic.html:
  • canvas/2d.clearRect.clip.html:
  • canvas/2d.clearRect.globalalpha.html:
  • canvas/2d.clearRect.globalcomposite.html:
  • canvas/2d.clearRect.negative.html:
  • canvas/2d.clearRect.nonfinite.html:
  • canvas/2d.clearRect.path.html:
  • canvas/2d.clearRect.shadow.html:
  • canvas/2d.clearRect.transform.html:
  • canvas/2d.clearRect.zero.html:
  • canvas/2d.composite.canvas.copy.html:
  • canvas/2d.composite.canvas.destination-atop.html:
  • canvas/2d.composite.canvas.destination-in.html:
  • canvas/2d.composite.canvas.destination-out.html:
  • canvas/2d.composite.canvas.destination-over.html:
  • canvas/2d.composite.canvas.lighter.html:
  • canvas/2d.composite.canvas.source-atop.html:
  • canvas/2d.composite.canvas.source-in.html:
  • canvas/2d.composite.canvas.source-out.html:
  • canvas/2d.composite.canvas.source-over.html:
  • canvas/2d.composite.canvas.xor.html:
  • canvas/2d.composite.clip.copy.html:
  • canvas/2d.composite.clip.destination-atop.html:
  • canvas/2d.composite.clip.destination-in.html:
  • canvas/2d.composite.clip.destination-out.html:
  • canvas/2d.composite.clip.destination-over.html:
  • canvas/2d.composite.clip.lighter.html:
  • canvas/2d.composite.clip.source-atop.html:
  • canvas/2d.composite.clip.source-in.html:
  • canvas/2d.composite.clip.source-out.html:
  • canvas/2d.composite.clip.source-over.html:
  • canvas/2d.composite.clip.xor.html:
  • canvas/2d.composite.globalAlpha.canvas.html:
  • canvas/2d.composite.globalAlpha.canvaspattern.html:
  • canvas/2d.composite.globalAlpha.fill.html:
  • canvas/2d.composite.globalAlpha.image.html:
  • canvas/2d.composite.globalAlpha.imagepattern.html:
  • canvas/2d.composite.image.copy.html:
  • canvas/2d.composite.image.destination-atop.html:
  • canvas/2d.composite.image.destination-in.html:
  • canvas/2d.composite.image.destination-out.html:
  • canvas/2d.composite.image.destination-over.html:
  • canvas/2d.composite.image.lighter.html:
  • canvas/2d.composite.image.source-atop.html:
  • canvas/2d.composite.image.source-in.html:
  • canvas/2d.composite.image.source-out.html:
  • canvas/2d.composite.image.source-over.html:
  • canvas/2d.composite.image.xor.html:
  • canvas/2d.composite.uncovered.image.copy.html:
  • canvas/2d.composite.uncovered.image.destination-atop.html:
  • canvas/2d.composite.uncovered.image.destination-in.html:
  • canvas/2d.composite.uncovered.image.source-in.html:
  • canvas/2d.composite.uncovered.image.source-out.html:
  • canvas/2d.composite.uncovered.pattern.copy.html:
  • canvas/2d.composite.uncovered.pattern.destination-atop.html:
  • canvas/2d.composite.uncovered.pattern.destination-in.html:
  • canvas/2d.composite.uncovered.pattern.source-in.html:
  • canvas/2d.composite.uncovered.pattern.source-out.html:
  • canvas/2d.drawImage.3arg.html:
  • canvas/2d.drawImage.5arg.html:
  • canvas/2d.drawImage.9arg.basic.html:
  • canvas/2d.drawImage.9arg.destpos.html:
  • canvas/2d.drawImage.9arg.destsize.html:
  • canvas/2d.drawImage.9arg.sourcepos.html:
  • canvas/2d.drawImage.9arg.sourcesize.html:
  • canvas/2d.drawImage.alpha.html:
  • canvas/2d.drawImage.animated.apng.html:
  • canvas/2d.drawImage.animated.gif.html:
  • canvas/2d.drawImage.animated.poster.html:
  • canvas/2d.drawImage.broken.html:
  • canvas/2d.drawImage.canvas.html:
  • canvas/2d.drawImage.clip.html:
  • canvas/2d.drawImage.composite.html:
  • canvas/2d.drawImage.floatsource.html:
  • canvas/2d.drawImage.image.incomplete.empty.html:
  • canvas/2d.drawImage.image.incomplete.omitted.html:
  • canvas/2d.drawImage.incomplete.html:
  • canvas/2d.drawImage.negativedest.html:
  • canvas/2d.drawImage.negativedir.html:
  • canvas/2d.drawImage.negativesource.html:
  • canvas/2d.drawImage.nonfinite.html:
  • canvas/2d.drawImage.nowrap.html:
  • canvas/2d.drawImage.path.html:
  • canvas/2d.drawImage.self.1.html:
  • canvas/2d.drawImage.self.2.html:
  • canvas/2d.drawImage.transform.html:
  • canvas/2d.drawImage.zerocanvas.html:
  • canvas/2d.drawImage.zerosource.html:
  • canvas/2d.fillRect.basic.html:
  • canvas/2d.fillRect.clip.html:
  • canvas/2d.fillRect.negative.html:
  • canvas/2d.fillRect.nonfinite.html:
  • canvas/2d.fillRect.path.html:
  • canvas/2d.fillRect.shadow.html:
  • canvas/2d.fillRect.transform.html:
  • canvas/2d.fillRect.zero.html:
  • canvas/2d.fillStyle.invalidstring.html:
  • canvas/2d.fillStyle.invalidtype.html:
  • canvas/2d.fillStyle.parse.current.basic.html:
  • canvas/2d.fillStyle.parse.current.changed.html:
  • canvas/2d.fillStyle.parse.invalid.hex1.html:
  • canvas/2d.fillStyle.parse.invalid.hex2.html:
  • canvas/2d.fillStyle.parse.invalid.hex3.html:
  • canvas/2d.fillStyle.parse.invalid.hex4.html:
  • canvas/2d.fillStyle.parse.invalid.hex5.html:
  • canvas/2d.fillStyle.parse.invalid.hex6.html:
  • canvas/2d.fillStyle.parse.invalid.hex7.html:
  • canvas/2d.fillStyle.parse.invalid.hex8.html:
  • canvas/2d.fillStyle.parse.invalid.hsl-1.html:
  • canvas/2d.fillStyle.parse.invalid.hsl-2.html:
  • canvas/2d.fillStyle.parse.invalid.hsl-3.html:
  • canvas/2d.fillStyle.parse.invalid.hsl-4.html:
  • canvas/2d.fillStyle.parse.invalid.hsl-5.html:
  • canvas/2d.fillStyle.parse.invalid.hsl-6.html:
  • canvas/2d.fillStyle.parse.invalid.hsla-1.html:
  • canvas/2d.fillStyle.parse.invalid.hsla-2.html:
  • canvas/2d.fillStyle.parse.invalid.name-1.html:
  • canvas/2d.fillStyle.parse.invalid.name-2.html:
  • canvas/2d.fillStyle.parse.invalid.name-3.html:
  • canvas/2d.fillStyle.parse.invalid.name-4.html:
  • canvas/2d.fillStyle.parse.invalid.name-5.html:
  • canvas/2d.fillStyle.parse.invalid.rgb-1.html:
  • canvas/2d.fillStyle.parse.invalid.rgb-2.html:
  • canvas/2d.fillStyle.parse.invalid.rgb-3.html:
  • canvas/2d.fillStyle.parse.invalid.rgb-4.html:
  • canvas/2d.fillStyle.parse.invalid.rgb-5.html:
  • canvas/2d.fillStyle.parse.invalid.rgb-6.html:
  • canvas/2d.fillStyle.parse.invalid.rgb-7.html:
  • canvas/2d.fillStyle.parse.invalid.rgba-1.html:
  • canvas/2d.fillStyle.parse.invalid.rgba-2.html:
  • canvas/2d.fillStyle.parse.invalid.rgba-3.html:
  • canvas/2d.fillStyle.parse.invalid.rgba-4.html:
  • canvas/2d.fillStyle.parse.invalid.rgba-5.html:
  • canvas/2d.fillStyle.parse.invalid.rgba-6.html:
  • canvas/2d.fillStyle.parse.invalid.rgba-7.html:
  • canvas/2d.getcontext.shared.html:
  • canvas/2d.gradient.empty.html:
  • canvas/2d.gradient.interpolate.outside.html:
  • canvas/2d.gradient.interpolate.overlap2.html:
  • canvas/2d.gradient.interpolate.solid.html:
  • canvas/2d.gradient.interpolate.zerosize.fill.html:
  • canvas/2d.gradient.interpolate.zerosize.fillRect.html:
  • canvas/2d.gradient.interpolate.zerosize.fillText.html:
  • canvas/2d.gradient.interpolate.zerosize.html:
  • canvas/2d.gradient.interpolate.zerosize.stroke.html:
  • canvas/2d.gradient.interpolate.zerosize.strokeRect.html:
  • canvas/2d.gradient.interpolate.zerosize.strokeText.html:
  • canvas/2d.gradient.linear.transform.1.html:
  • canvas/2d.gradient.linear.transform.2.html:
  • canvas/2d.gradient.linear.transform.3.html:
  • canvas/2d.gradient.object.crosscanvas.html:
  • canvas/2d.gradient.object.update.html:
  • canvas/2d.gradient.radial.cone.behind.html:
  • canvas/2d.gradient.radial.cone.beside.html:
  • canvas/2d.gradient.radial.cone.bottom.html:
  • canvas/2d.gradient.radial.cone.cylinder.html:
  • canvas/2d.gradient.radial.cone.front.html:
  • canvas/2d.gradient.radial.cone.shape1.html:
  • canvas/2d.gradient.radial.cone.shape2.html:
  • canvas/2d.gradient.radial.cone.top.html:
  • canvas/2d.gradient.radial.equal.html:
  • canvas/2d.gradient.radial.inside1.html:
  • canvas/2d.gradient.radial.inside2.html:
  • canvas/2d.gradient.radial.inside3.html:
  • canvas/2d.gradient.radial.outside1.html:
  • canvas/2d.gradient.radial.outside2.html:
  • canvas/2d.gradient.radial.outside3.html:
  • canvas/2d.gradient.radial.touch1.html:
  • canvas/2d.gradient.radial.touch2.html:
  • canvas/2d.gradient.radial.touch3.html:
  • canvas/2d.gradient.radial.transform.1.html:
  • canvas/2d.gradient.radial.transform.2.html:
  • canvas/2d.gradient.radial.transform.3.html:
  • canvas/2d.imageData.get.unaffected.html:
  • canvas/2d.imageData.put.basic.html:
  • canvas/2d.imageData.put.clip.html:
  • canvas/2d.imageData.put.created.html:
  • canvas/2d.imageData.put.cross.html:
  • canvas/2d.imageData.put.dirty.negative.html:
  • canvas/2d.imageData.put.dirty.outside.html:
  • canvas/2d.imageData.put.dirty.rect1.html:
  • canvas/2d.imageData.put.dirty.rect2.html:
  • canvas/2d.imageData.put.dirty.zero.html:
  • canvas/2d.imageData.put.modified.html:
  • canvas/2d.imageData.put.path.html:
  • canvas/2d.imageData.put.unaffected.html:
  • canvas/2d.imageData.put.wrongtype.html:
  • canvas/2d.line.cap.butt.html:
  • canvas/2d.line.cap.closed.html:
  • canvas/2d.line.cap.open.html:
  • canvas/2d.line.cap.round.html:
  • canvas/2d.line.cap.square.html:
  • canvas/2d.line.cross.html:
  • canvas/2d.line.join.bevel.html:
  • canvas/2d.line.join.closed.html:
  • canvas/2d.line.join.miter.html:
  • canvas/2d.line.join.open.html:
  • canvas/2d.line.join.parallel.html:
  • canvas/2d.line.join.round.html:
  • canvas/2d.line.miter.acute.html:
  • canvas/2d.line.miter.exceeded.html:
  • canvas/2d.line.miter.lineedge.html:
  • canvas/2d.line.miter.obtuse.html:
  • canvas/2d.line.miter.rightangle.html:
  • canvas/2d.line.miter.within.html:
  • canvas/2d.line.union.html:
  • canvas/2d.line.width.basic.html:
  • canvas/2d.line.width.scaledefault.html:
  • canvas/2d.line.width.transformed.html:
  • canvas/2d.path.arc.angle.1.html:
  • canvas/2d.path.arc.angle.2.html:
  • canvas/2d.path.arc.angle.3.html:
  • canvas/2d.path.arc.angle.4.html:
  • canvas/2d.path.arc.angle.5.html:
  • canvas/2d.path.arc.angle.6.html:
  • canvas/2d.path.arc.default.html:
  • canvas/2d.path.arc.empty.html:
  • canvas/2d.path.arc.end.html:
  • canvas/2d.path.arc.nonempty.html:
  • canvas/2d.path.arc.nonfinite.html:
  • canvas/2d.path.arc.scale.1.html:
  • canvas/2d.path.arc.scale.2.html:
  • canvas/2d.path.arc.selfintersect.1.html:
  • canvas/2d.path.arc.selfintersect.2.html:
  • canvas/2d.path.arc.shape.1.html:
  • canvas/2d.path.arc.shape.2.html:
  • canvas/2d.path.arc.shape.3.html:
  • canvas/2d.path.arc.shape.4.html:
  • canvas/2d.path.arc.shape.5.html:
  • canvas/2d.path.arc.twopie.1.html:
  • canvas/2d.path.arc.twopie.2.html:
  • canvas/2d.path.arc.twopie.3.html:
  • canvas/2d.path.arc.twopie.4.html:
  • canvas/2d.path.arc.zero.1.html:
  • canvas/2d.path.arc.zero.2.html:
  • canvas/2d.path.arc.zeroradius.html:
  • canvas/2d.path.arcTo.coincide.1.html:
  • canvas/2d.path.arcTo.coincide.2.html:
  • canvas/2d.path.arcTo.collinear.1.html:
  • canvas/2d.path.arcTo.collinear.2.html:
  • canvas/2d.path.arcTo.collinear.3.html:
  • canvas/2d.path.arcTo.ensuresubpath.1.html:
  • canvas/2d.path.arcTo.ensuresubpath.2.html:
  • canvas/2d.path.arcTo.nonfinite.html:
  • canvas/2d.path.arcTo.scale.html:
  • canvas/2d.path.arcTo.shape.curve1.html:
  • canvas/2d.path.arcTo.shape.curve2.html:
  • canvas/2d.path.arcTo.shape.end.html:
  • canvas/2d.path.arcTo.shape.start.html:
  • canvas/2d.path.arcTo.transformation.html:
  • canvas/2d.path.arcTo.zero.1.html:
  • canvas/2d.path.arcTo.zero.2.html:
  • canvas/2d.path.beginPath.html:
  • canvas/2d.path.bezierCurveTo.basic.html:
  • canvas/2d.path.bezierCurveTo.ensuresubpath.1.html:
  • canvas/2d.path.bezierCurveTo.ensuresubpath.2.html:
  • canvas/2d.path.bezierCurveTo.nonfinite.html:
  • canvas/2d.path.bezierCurveTo.scaled.html:
  • canvas/2d.path.bezierCurveTo.shape.html:
  • canvas/2d.path.clip.basic.1.html:
  • canvas/2d.path.clip.basic.2.html:
  • canvas/2d.path.clip.empty.html:
  • canvas/2d.path.clip.intersect.html:
  • canvas/2d.path.clip.unaffected.html:
  • canvas/2d.path.clip.winding.1.html:
  • canvas/2d.path.clip.winding.2.html:
  • canvas/2d.path.closePath.empty.html:
  • canvas/2d.path.closePath.newline.html:
  • canvas/2d.path.closePath.nextpoint.html:
  • canvas/2d.path.fill.closed.basic.html:
  • canvas/2d.path.fill.closed.unaffected.html:
  • canvas/2d.path.fill.winding.add.html:
  • canvas/2d.path.fill.winding.subtract.1.html:
  • canvas/2d.path.fill.winding.subtract.2.html:
  • canvas/2d.path.fill.winding.subtract.3.html:
  • canvas/2d.path.initial.html:
  • canvas/2d.path.lineTo.basic.html:
  • canvas/2d.path.lineTo.ensuresubpath.1.html:
  • canvas/2d.path.lineTo.ensuresubpath.2.html:
  • canvas/2d.path.lineTo.nextpoint.html:
  • canvas/2d.path.lineTo.nonfinite.html:
  • canvas/2d.path.moveTo.basic.html:
  • canvas/2d.path.moveTo.multiple.html:
  • canvas/2d.path.moveTo.newsubpath.html:
  • canvas/2d.path.moveTo.nonfinite.html:
  • canvas/2d.path.quadraticCurveTo.basic.html:
  • canvas/2d.path.quadraticCurveTo.ensuresubpath.1.html:
  • canvas/2d.path.quadraticCurveTo.ensuresubpath.2.html:
  • canvas/2d.path.quadraticCurveTo.nonfinite.html:
  • canvas/2d.path.quadraticCurveTo.scaled.html:
  • canvas/2d.path.quadraticCurveTo.shape.html:
  • canvas/2d.path.rect.basic.html:
  • canvas/2d.path.rect.closed.html:
  • canvas/2d.path.rect.end.1.html:
  • canvas/2d.path.rect.end.2.html:
  • canvas/2d.path.rect.newsubpath.html:
  • canvas/2d.path.rect.nonfinite.html:
  • canvas/2d.path.rect.selfintersect.html:
  • canvas/2d.path.rect.zero.1.html:
  • canvas/2d.path.rect.zero.2.html:
  • canvas/2d.path.rect.zero.3.html:
  • canvas/2d.path.rect.zero.4.html:
  • canvas/2d.path.rect.zero.5.html:
  • canvas/2d.path.rect.zero.6.html:
  • canvas/2d.path.stroke.empty.html:
  • canvas/2d.path.stroke.prune.arc.html:
  • canvas/2d.path.stroke.prune.closed.html:
  • canvas/2d.path.stroke.prune.corner.html:
  • canvas/2d.path.stroke.prune.curve.html:
  • canvas/2d.path.stroke.prune.line.html:
  • canvas/2d.path.stroke.prune.rect.html:
  • canvas/2d.path.stroke.scale1.html:
  • canvas/2d.path.stroke.scale2.html:
  • canvas/2d.path.stroke.skew.html:
  • canvas/2d.path.stroke.unaffected.html:
  • canvas/2d.path.stroke.union.html:
  • canvas/2d.path.transformation.basic.html:
  • canvas/2d.path.transformation.changing.html:
  • canvas/2d.path.transformation.multiple.html:
  • canvas/2d.pattern.animated.gif.html:
  • canvas/2d.pattern.basic.canvas.html:
  • canvas/2d.pattern.basic.image.html:
  • canvas/2d.pattern.basic.nocontext.html:
  • canvas/2d.pattern.basic.type.html:
  • canvas/2d.pattern.crosscanvas.html:
  • canvas/2d.pattern.image.incomplete.empty.html:
  • canvas/2d.pattern.image.incomplete.omitted.html:
  • canvas/2d.pattern.modify.canvas1.html:
  • canvas/2d.pattern.modify.canvas2.html:
  • canvas/2d.pattern.modify.image1.html:
  • canvas/2d.pattern.modify.image2.html:
  • canvas/2d.pattern.paint.norepeat.basic.html:
  • canvas/2d.pattern.paint.norepeat.coord1.html:
  • canvas/2d.pattern.paint.norepeat.coord2.html:
  • canvas/2d.pattern.paint.norepeat.coord3.html:
  • canvas/2d.pattern.paint.norepeat.outside.html:
  • canvas/2d.pattern.paint.orientation.canvas.html:
  • canvas/2d.pattern.paint.orientation.image.html:
  • canvas/2d.pattern.paint.repeat.basic.html:
  • canvas/2d.pattern.paint.repeat.coord1.html:
  • canvas/2d.pattern.paint.repeat.coord2.html:
  • canvas/2d.pattern.paint.repeat.coord3.html:
  • canvas/2d.pattern.paint.repeat.outside.html:
  • canvas/2d.pattern.paint.repeatx.basic.html:
  • canvas/2d.pattern.paint.repeatx.coord1.html:
  • canvas/2d.pattern.paint.repeatx.outside.html:
  • canvas/2d.pattern.paint.repeaty.basic.html:
  • canvas/2d.pattern.paint.repeaty.coord1.html:
  • canvas/2d.pattern.paint.repeaty.outside.html:
  • canvas/2d.pattern.repeat.empty.html:
  • canvas/2d.pattern.repeat.null.html:
  • canvas/2d.shadow.alpha.1.html:
  • canvas/2d.shadow.canvas.alpha.html:
  • canvas/2d.shadow.canvas.basic.html:
  • canvas/2d.shadow.canvas.transparent.1.html:
  • canvas/2d.shadow.canvas.transparent.2.html:
  • canvas/2d.shadow.clip.1.html:
  • canvas/2d.shadow.clip.2.html:
  • canvas/2d.shadow.clip.3.html:
  • canvas/2d.shadow.composite.1.html:
  • canvas/2d.shadow.composite.2.html:
  • canvas/2d.shadow.composite.3.html:
  • canvas/2d.shadow.enable.blur.html:
  • canvas/2d.shadow.enable.off.1.html:
  • canvas/2d.shadow.enable.off.2.html:
  • canvas/2d.shadow.enable.x.html:
  • canvas/2d.shadow.enable.y.html:
  • canvas/2d.shadow.gradient.basic.html:
  • canvas/2d.shadow.gradient.transparent.1.html:
  • canvas/2d.shadow.gradient.transparent.2.html:
  • canvas/2d.shadow.image.alpha.html:
  • canvas/2d.shadow.image.basic.html:
  • canvas/2d.shadow.image.scale.html:
  • canvas/2d.shadow.image.section.html:
  • canvas/2d.shadow.image.transparent.1.html:
  • canvas/2d.shadow.image.transparent.2.html:
  • canvas/2d.shadow.offset.negativeX.html:
  • canvas/2d.shadow.offset.negativeY.html:
  • canvas/2d.shadow.offset.positiveX.html:
  • canvas/2d.shadow.offset.positiveY.html:
  • canvas/2d.shadow.outside.html:
  • canvas/2d.shadow.pattern.alpha.html:
  • canvas/2d.shadow.pattern.basic.html:
  • canvas/2d.shadow.pattern.transparent.1.html:
  • canvas/2d.shadow.pattern.transparent.2.html:
  • canvas/2d.shadow.stroke.basic.html:
  • canvas/2d.shadow.stroke.cap.1.html:
  • canvas/2d.shadow.stroke.cap.2.html:
  • canvas/2d.shadow.stroke.join.1.html:
  • canvas/2d.shadow.stroke.join.2.html:
  • canvas/2d.shadow.stroke.join.3.html:
  • canvas/2d.shadow.transform.1.html:
  • canvas/2d.shadow.transform.2.html:
  • canvas/2d.state.saverestore.bitmap.html:
  • canvas/2d.state.saverestore.clip.html:
  • canvas/2d.state.saverestore.path.html:
  • canvas/2d.state.saverestore.transformation.html:
  • canvas/2d.strokeRect.basic.html:
  • canvas/2d.strokeRect.clip.html:
  • canvas/2d.strokeRect.globalalpha.html:
  • canvas/2d.strokeRect.globalcomposite.html:
  • canvas/2d.strokeRect.negative.html:
  • canvas/2d.strokeRect.nonfinite.html:
  • canvas/2d.strokeRect.path.html:
  • canvas/2d.strokeRect.shadow.html:
  • canvas/2d.strokeRect.transform.html:
  • canvas/2d.strokeRect.zero.1.html:
  • canvas/2d.strokeRect.zero.2.html:
  • canvas/2d.strokeRect.zero.3.html:
  • canvas/2d.strokeRect.zero.5.html:
  • canvas/2d.text.draw.align.center.html:
  • canvas/2d.text.draw.align.end.ltr.html:
  • canvas/2d.text.draw.align.end.rtl.html:
  • canvas/2d.text.draw.align.left.html:
  • canvas/2d.text.draw.align.right.html:
  • canvas/2d.text.draw.align.start.ltr.html:
  • canvas/2d.text.draw.align.start.rtl.html:
  • canvas/2d.text.draw.baseline.alphabetic.html:
  • canvas/2d.text.draw.fill.maxWidth.bound.html:
  • canvas/2d.text.draw.fill.maxWidth.fontface.html:
  • canvas/2d.text.draw.fill.maxWidth.negative.html:
  • canvas/2d.text.draw.fill.maxWidth.small.html:
  • canvas/2d.text.draw.fill.maxWidth.zero.html:
  • canvas/2d.text.draw.fill.unaffected.html:
  • canvas/2d.text.draw.fontface.html:
  • canvas/2d.text.draw.fontface.notinpage.html:
  • canvas/2d.text.draw.fontface.repeat.html:
  • canvas/2d.text.draw.kern.consistent.html:
  • canvas/2d.text.draw.space.basic.html:
  • canvas/2d.text.draw.space.collapse.nonspace.html:
  • canvas/2d.text.draw.stroke.unaffected.html:
  • canvas/2d.transformation.order.html:
  • canvas/2d.transformation.rotate.direction.html:
  • canvas/2d.transformation.rotate.nonfinite.html:
  • canvas/2d.transformation.rotate.radians.html:
  • canvas/2d.transformation.rotate.wrap.html:
  • canvas/2d.transformation.rotate.wrapnegative.html:
  • canvas/2d.transformation.rotate.zero.html:
  • canvas/2d.transformation.scale.basic.html:
  • canvas/2d.transformation.scale.large.html:
  • canvas/2d.transformation.scale.multiple.html:
  • canvas/2d.transformation.scale.negative.html:
  • canvas/2d.transformation.scale.nonfinite.html:
  • canvas/2d.transformation.scale.zero.html:
  • canvas/2d.transformation.setTransform.multiple.html:
  • canvas/2d.transformation.setTransform.nonfinite.html:
  • canvas/2d.transformation.setTransform.skewed.html:
  • canvas/2d.transformation.transform.identity.html:
  • canvas/2d.transformation.transform.multiply.html:
  • canvas/2d.transformation.transform.nonfinite.html:
  • canvas/2d.transformation.transform.skewed.html:
  • canvas/2d.transformation.translate.basic.html:
  • canvas/2d.transformation.translate.nonfinite.html:
  • canvas/2d.voidreturn.html:
  • canvas/initial.reset.clip.html:
  • canvas/initial.reset.gradient.html:
  • canvas/initial.reset.pattern.html:
  • canvas/initial.reset.transform.html:
  • canvas/resources/anim-gr.gif: Removed.
  • canvas/resources/anim-gr.png: Removed.
  • canvas/resources/anim-poster-gr.png: Removed.
  • canvas/resources/background.png: Removed.
  • canvas/resources/broken.png: Removed.
  • canvas/resources/clear-100x50.png: Removed.
  • canvas/resources/ggrr-256x256.png: Removed.
  • canvas/resources/green-100x50.png: Removed.
  • canvas/resources/green-16x16.png: Removed.
  • canvas/resources/green-1x1.png: Removed.
  • canvas/resources/green.png: Removed.
  • canvas/resources/red-16x16.png: Removed.
  • canvas/resources/red.png: Removed.
  • canvas/resources/redtransparent.png: Removed.
  • canvas/resources/rgrg-256x256.png: Removed.
  • canvas/resources/rrgg-256x256.png: Removed.
  • canvas/resources/transparent.png: Removed.
  • canvas/resources/transparent50.png: Removed.
  • canvas/resources/yellow.png: Removed.
  • canvas/resources/yellow75.png: Removed.
  • canvas/security.dataURI.html:
  • canvas/security.drawImage.canvas.html:
  • canvas/security.drawImage.image.html:
  • canvas/security.pattern.canvas.fillStyle.html:
  • canvas/security.pattern.canvas.strokeStyle.html:
  • canvas/security.pattern.canvas.timing.html:
  • canvas/security.pattern.create.html:
  • canvas/security.pattern.cross.html:
  • canvas/security.pattern.image.fillStyle.html:
  • canvas/security.pattern.image.strokeStyle.html:
  • canvas/security.reset.html:
  • resources: Added.
  • resources/anim-gr.gif: Added.
  • resources/anim-gr.png: Added.
  • resources/anim-poster-gr.png: Added.
  • resources/background.png: Added.
  • resources/broken.png: Added.
  • resources/clear-100x50.png: Added.
  • resources/ggrr-256x256.png: Added.
  • resources/green-100x50.png: Added.
  • resources/green-16x16.png: Added.
  • resources/green-1x1.png: Added.
  • resources/green.png: Added.
  • resources/red-16x16.png: Added.
  • resources/red.png: Added.
  • resources/redtransparent.png: Added.
  • resources/rgrg-256x256.png: Added.
  • resources/rrgg-256x256.png: Added.
  • resources/transparent.png: Added.
  • resources/transparent50.png: Added.
  • resources/yellow.png: Added.
  • resources/yellow75.png: Added.
11:33 AM Changeset in webkit [178853] by Antti Koivisto
  • 6 edits in trunk/Source/WebCore

REGRESSION(r178180): Membuster regressed ~4%
​https://bugs.webkit.org/show_bug.cgi?id=140495

Reviewed by Andreas Kling.

After r178180 we keep system fallback fonts that are used on glyph pages alive.
Previously we would traverse the glyph pages and remove entries referencing system fallbacks.

  • platform/graphics/FontCache.cpp:

(WebCore::FontCache::purgeInactiveFontData):

  • platform/graphics/FontCascade.cpp:

(WebCore::pruneUnreferencedEntriesFromFontGlyphsCache):
(WebCore::pruneSystemFallbackFonts):

  • platform/graphics/FontCascade.h:
  • platform/graphics/FontGlyphs.cpp:

(WebCore::FontGlyphs::pruneSystemFallbacks):

When clearing the font cache also remove the cached glyph pages that may contain system fallback fonts
and release the fallbacks.

  • platform/graphics/FontGlyphs.h:
11:31 AM Changeset in webkit [178852] by ap@apple.com
  • 2 edits in trunk/Tools

​https://build.webkit.org/dashboard/metrics.html fails because of ios-ews
​https://bugs.webkit.org/show_bug.cgi?id=140731

Reviewed by Tim Horton.

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js:

(Analyzer.prototype._analyzeAllBubblesPerformance): Corrected a typo.

11:27 AM Changeset in webkit [178851] by Brent Fulgham
  • 5 edits in trunk/LayoutTests

[Win] Unreviewed gardening based on TestBot runs.

Update a few failure cass with bug reports. Rebaseline a handful of tests.

  • platform/win/TestExpectations: Update based on bug reports.
  • platform/win/fast/regions/text-region-split-small-pagination-expected.txt:
  • platform/win/svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.txt:
  • platform/win/svg/W3C-SVG-1.1-SE/styling-css-04-f-expected.txt:
11:13 AM Changeset in webkit [178850] by zandobersek@gmail.com
  • 4 edits in trunk/Source/WebKit2

AsyncRequestImpl casting in AsyncRequest::completeRequest() is incorrect
​https://bugs.webkit.org/show_bug.cgi?id=139724

Reviewed by Darin Adler.

AsyncRequestImpl casting in AsyncRequest::completeRequest() relies on
the parameter pack to properly determine the type of the AsyncRequestImpl
object. The casting result can be incorrect when an argument is passed
by reference while the original object was constructed with a callback
that expects an argument that's passed by value.

To avoid this the AsyncRequestImpl template is now instantiated with
raw types, with callback parameters remaining raw types in case
of being integral (enforcing passing-by-value these arguments when
dispatching), and const references being used otherwise (enforcing
passing-by-reference).

This enables casting AsyncRequest objects to the correct AsyncRequestImpl<>
by running the parameter pack through std::decay.

  • DatabaseProcess/IndexedDB/UniqueIDBDatabase.cpp:

(WebKit::UniqueIDBDatabase::putRecord):
(WebKit::UniqueIDBDatabase::getRecord):
(WebKit::UniqueIDBDatabase::openCursor):
(WebKit::UniqueIDBDatabase::cursorAdvance):
(WebKit::UniqueIDBDatabase::cursorIterate):
(WebKit::UniqueIDBDatabase::count):
(WebKit::UniqueIDBDatabase::deleteRange):

  • Shared/AsyncRequest.h:

(WebKit::AsyncRequest::completeRequest):

  • WebProcess/Databases/IndexedDB/WebIDBServerConnection.cpp:

(WebKit::WebIDBServerConnection::getOrEstablishIDBDatabaseMetadata):
(WebKit::WebIDBServerConnection::get):

10:59 AM Changeset in webkit [178849] by Brent Fulgham
  • 8 edits in trunk

[Win] eventSender does not support scalePageBy
​https://bugs.webkit.org/show_bug.cgi?id=140726
<rdar://problem/19549865>

Reviewed by Dean Jackson.

Source/WebKit/win:

  • Interfaces/IWebViewPrivate.idl: Add scaleWebView API.
  • WebView.cpp:

(WebView::scaleWebView):
Connect WebCore implementation to the Windows COM interface.

  • WebView.h:

Tools:

  • DumpRenderTree/win/EventSender.cpp:

(scalePageByCallback): Provide implementation using new WebView method.

LayoutTests:

  • platform/win/TestExpectations: Unskip test.
10:55 AM Changeset in webkit [178848] by Chris Dumez
  • 3 edits in trunk/Source/WebKit2

[WK2] Stop using WKDiagnosticLoggingResultType.h C API header in Cocoa API
​https://bugs.webkit.org/show_bug.cgi?id=140655

Reviewed by Anders Carlsson.

Stop using WKDiagnosticLoggingResultType.h C API header in Cocoa API.
Instead, introduce a new _WKDiagnosticLoggingResultType enum in
_WKDiagnosticLoggingDelegate.h.

A few defines mapping WKDiagnosticLoggingResultType enum and its values
to the new _WKDiagnosticLoggingResultType are temporarily added until
the client-side is transitioned.

  • UIProcess/API/Cocoa/_WKDiagnosticLoggingDelegate.h:
  • UIProcess/Cocoa/DiagnosticLoggingClient.mm:

(WebKit::toWKDiagnosticLoggingResultType):
(WebKit::DiagnosticLoggingClient::logDiagnosticMessageWithResult):

10:52 AM Changeset in webkit [178847] by Lucas Forschler
  • 2 edits in trunk/Tools

Remove Apple Mountain Lion Build & Test slaves.

Unreviewed.

  • BuildSlaveSupport/build.webkit.org-config/config.json:
10:47 AM Changeset in webkit [178846] by bshafiei@apple.com
  • 1 edit
    1 copy
    1 delete in branches/safari-600.1.4.15-branch

Merged r177088. rdar://problem/19339033

10:46 AM Changeset in webkit [178845] by bshafiei@apple.com
  • 6 edits
    1 copy in branches/safari-600.1.4.15-branch

Merged r177000. rdar://problem/19339033

10:44 AM Changeset in webkit [178844] by bshafiei@apple.com
  • 2 edits in branches/safari-600.1.4.15-branch/Source/WebCore

Merged r176977. rdar://problem/19420073

10:43 AM Changeset in webkit [178843] by bshafiei@apple.com
  • 3 edits
    3 copies in branches/safari-600.1.4.15-branch

Merged r176972. rdar://problem/19450085

10:42 AM Changeset in webkit [178842] by bshafiei@apple.com
  • 2 edits in branches/safari-600.1.4.15-branch/Source/WTF

Merged r176982. rdar://problem/19419996

10:41 AM Changeset in webkit [178841] by bshafiei@apple.com
  • 3 edits
    2 copies in branches/safari-600.1.4.15-branch

Merged r176971. rdar://problem/19419996

10:40 AM Changeset in webkit [178840] by bshafiei@apple.com
  • 2 edits in branches/safari-600.1.4.15-branch/Source/WebKit2

Merged r176969. rdar://problem/19302738

10:39 AM Changeset in webkit [178839] by bshafiei@apple.com
  • 4 edits in branches/safari-600.1.4.15-branch/Source/WebCore

Merged r176948. rdar://problem/19419766

10:38 AM Changeset in webkit [178838] by bshafiei@apple.com
  • 9 edits in branches/safari-600.1.4.15-branch

Merged r176904. rdar://problem/19419865

10:32 AM Changeset in webkit [178837] by bshafiei@apple.com
  • 3 edits
    2 copies in branches/safari-600.1.4.15-branch

Merged r176768. rdar://problem/19450126

10:31 AM Changeset in webkit [178836] by bshafiei@apple.com
  • 2 edits in branches/safari-600.1.4.15-branch/Source/WebCore

Merged r176734. rdar://problem/19420067

10:30 AM Changeset in webkit [178835] by bshafiei@apple.com
  • 2 edits in branches/safari-600.1.4.15-branch/Source/WebKit2

Merged r176701. rdar://problem/19419925

10:30 AM Changeset in webkit [178834] by bshafiei@apple.com
  • 2 edits in branches/safari-600.1.4.15-branch/Source/WebCore

Merged r176484. rdar://problem/19419988

10:29 AM Changeset in webkit [178833] by bshafiei@apple.com
  • 2 edits in branches/safari-600.1.4.15-branch/Source/WebCore

Merged r176471. rdar://problem/19419820

10:28 AM Changeset in webkit [178832] by bshafiei@apple.com
  • 4 edits
    2 copies in branches/safari-600.1.4.15-branch

Merged r176447. rdar://problem/19419828

10:25 AM Changeset in webkit [178831] by bshafiei@apple.com
  • 4 edits
    3 copies in branches/safari-600.1.4.15-branch

Merged r176372. rdar://problem/19419916

10:24 AM Changeset in webkit [178830] by bshafiei@apple.com
  • 5 edits
    9 copies in branches/safari-600.1.4.15-branch

Merged r176354. rdar://problem/19432696

10:20 AM Changeset in webkit [178829] by bshafiei@apple.com
  • 7 edits in branches/safari-600.1.4.15-branch

Merged r176318. rdar://problem/19339000

10:06 AM Changeset in webkit [178828] by bshafiei@apple.com
  • 3 edits in branches/safari-600.1.4.15-branch/Source/WebKit2

Merged r176305. rdar://problem/19395081

10:05 AM Changeset in webkit [178827] by bshafiei@apple.com
  • 3 edits
    2 copies in branches/safari-600.1.4.15-branch

Merged r176285. rdar://problem/19420011

9:02 AM Changeset in webkit [178826] by Brent Fulgham
  • 2 edits in trunk/LayoutTests

[Win] Unreviewed gardening after reactivating some tests.

  • platform/win/TestExpectations: Add failure entries for a few tests with bug reports.
9:00 AM Changeset in webkit [178825] by zandobersek@gmail.com
  • 4 edits in trunk/Source/WebKit2

[WK2] Use C++ lambdas in ProcessLauncher class
​https://bugs.webkit.org/show_bug.cgi?id=138186

Reviewed by Darin Adler.

Replace uses of WTF::bind() in the ProcessLauncher class with C++ lambdas.

  • UIProcess/Launcher/efl/ProcessLauncherEfl.cpp:

(WebKit::ProcessLauncher::launchProcess):

  • UIProcess/Launcher/gtk/ProcessLauncherGtk.cpp:

(WebKit::ProcessLauncher::launchProcess):

  • UIProcess/Launcher/mac/ProcessLauncherMac.mm:

(WebKit::connectToService):
(WebKit::tryPreexistingProcess):
(WebKit::createProcess):

8:55 AM Changeset in webkit [178824] by zandobersek@gmail.com
  • 2 edits in trunk/Source/WebKit2

Clean up ViewUpdateDispatcher
​https://bugs.webkit.org/show_bug.cgi?id=140619

Reviewed by Darin Adler.

  • WebProcess/WebPage/ViewUpdateDispatcher.cpp:

(WebKit::ViewUpdateDispatcher::visibleContentRectUpdate):
Replace WTF::bind() with a C++ lambda.
(WebKit::ViewUpdateDispatcher::dispatchVisibleContentRectUpdate):
Use WTF::move() to move the HashMap member into the local variable.

2:20 AM Changeset in webkit [178823] by Csaba Osztrogonác
  • 2 edits in trunk

[EFL][WK2] EFL MiniBrowser doesn't run because shared library is not found
​https://bugs.webkit.org/show_bug.cgi?id=140049

Reviewed by Gyuyoung Kim.

  • Source/cmake/OptionsCommon.cmake:
2:02 AM Changeset in webkit [178822] by Manuel Rego Casasnovas
  • 7 edits
    4 adds in trunk

first-letter pseudo-element from ancestors is not being ignored in grids and flexboxes
​https://bugs.webkit.org/show_bug.cgi?id=138424

Reviewed by Benjamin Poulain.

Source/WebCore:

Source/WebCore:

According to the grid and flexbox specs:
"::first-letter pseudo-element do not apply to grid/flex containers".
​http://dev.w3.org/csswg/css-grid/#grid-containers
​http://dev.w3.org/csswg/css-flexbox/#flex-containers

Check also the CSS WG mailing list discussion:
​http://lists.w3.org/Archives/Public/www-style/2014Dec/0305.html

This was almost working right, except in the case that an ancestor was
setting the ::first-letter pseudo-element.

Added a few more cases to the current tests in order to check this
behavior.
Also created some new tests to increase coverage

Tests: fast/css/first-letter-from-ancestors-not-apply-inline-elements.html

fast/css/first-letter-ignores-display-property.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::getFirstLetter): Go to the next sibling when
looking for the first text child if you reach a grid or flexbox.

LayoutTests:

Modified current tests to check that first-letter from ancestors is
ignored too.
Added 2 new tests to increase coverage.

  • css3/flexbox/flexbox-ignore-container-firstLetter-expected.txt:
  • css3/flexbox/flexbox-ignore-container-firstLetter.html:
  • fast/css-grid-layout/grid-container-ignore-first-letter-expected.txt:
  • fast/css-grid-layout/grid-container-ignore-first-letter.html:
  • fast/css/first-letter-from-ancestors-not-apply-inline-elements-expected.html: Added.
  • fast/css/first-letter-from-ancestors-not-apply-inline-elements.html: Added.
  • fast/css/first-letter-ignores-display-property-expected.html: Added.
  • fast/css/first-letter-ignores-display-property.html: Added.
1:52 AM WebKitGTK/Roadmap edited by philn@igalia.com
(diff)
1:51 AM WebKitGTK/Roadmap edited by philn@igalia.com
(diff)
12:46 AM Changeset in webkit [178821] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebCore

Fix cast-align warning in Source/WebCore/platform/efl/EflScreenUtilities.cpp
​https://bugs.webkit.org/show_bug.cgi?id=140670

Reviewed by Darin Adler.

  • platform/efl/EflScreenUtilities.cpp:

(WebCore::createCustomCursor):

12:45 AM Changeset in webkit [178820] by Csaba Osztrogonác
  • 262 edits in trunk

Remove ENABLE(INSPECTOR) ifdef guards
​https://bugs.webkit.org/show_bug.cgi?id=140668

Reviewed by Darin Adler.

.:

  • Source/PlatformEfl.cmake:
  • Source/cmake/OptionsEfl.cmake:
  • Source/cmake/OptionsGTK.cmake:
  • Source/cmake/OptionsMac.cmake:
  • Source/cmake/WebKitFeatures.cmake:
  • Source/cmakeconfig.h.cmake:

Source/JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig:
  • bindings/ScriptValue.cpp:

(Deprecated::ScriptValue::toInspectorValue):

  • bindings/ScriptValue.h:
  • inspector/ConsoleMessage.cpp:
  • inspector/ConsoleMessage.h:
  • inspector/ContentSearchUtilities.cpp:
  • inspector/ContentSearchUtilities.h:
  • inspector/IdentifiersFactory.cpp:
  • inspector/IdentifiersFactory.h:
  • inspector/InjectedScript.cpp:
  • inspector/InjectedScript.h:
  • inspector/InjectedScriptBase.cpp:
  • inspector/InjectedScriptBase.h:
  • inspector/InjectedScriptHost.cpp:
  • inspector/InjectedScriptHost.h:
  • inspector/InjectedScriptManager.cpp:
  • inspector/InjectedScriptManager.h:
  • inspector/InjectedScriptModule.cpp:
  • inspector/InjectedScriptModule.h:
  • inspector/InspectorAgentRegistry.cpp:
  • inspector/InspectorBackendDispatcher.cpp:
  • inspector/InspectorBackendDispatcher.h:
  • inspector/InspectorProtocolTypes.h:
  • inspector/JSGlobalObjectConsoleClient.cpp:
  • inspector/JSGlobalObjectInspectorController.cpp:
  • inspector/JSGlobalObjectInspectorController.h:
  • inspector/JSGlobalObjectScriptDebugServer.cpp:
  • inspector/JSGlobalObjectScriptDebugServer.h:
  • inspector/JSInjectedScriptHost.cpp:
  • inspector/JSInjectedScriptHost.h:
  • inspector/JSInjectedScriptHostPrototype.cpp:
  • inspector/JSInjectedScriptHostPrototype.h:
  • inspector/JSJavaScriptCallFrame.cpp:
  • inspector/JSJavaScriptCallFrame.h:
  • inspector/JSJavaScriptCallFramePrototype.cpp:
  • inspector/JSJavaScriptCallFramePrototype.h:
  • inspector/JavaScriptCallFrame.cpp:
  • inspector/JavaScriptCallFrame.h:
  • inspector/ScriptCallFrame.cpp:

(Inspector::ScriptCallFrame::buildInspectorObject):

  • inspector/ScriptCallFrame.h:
  • inspector/ScriptCallStack.cpp:

(Inspector::ScriptCallStack::buildInspectorArray):

  • inspector/ScriptCallStack.h:
  • inspector/ScriptDebugServer.cpp:
  • inspector/agents/InspectorAgent.cpp:
  • inspector/agents/InspectorAgent.h:
  • inspector/agents/InspectorConsoleAgent.cpp:
  • inspector/agents/InspectorConsoleAgent.h:
  • inspector/agents/InspectorDebuggerAgent.cpp:
  • inspector/agents/InspectorDebuggerAgent.h:
  • inspector/agents/InspectorRuntimeAgent.cpp:
  • inspector/agents/InspectorRuntimeAgent.h:
  • inspector/agents/JSGlobalObjectConsoleAgent.cpp:
  • inspector/agents/JSGlobalObjectConsoleAgent.h:
  • inspector/agents/JSGlobalObjectDebuggerAgent.cpp:
  • inspector/agents/JSGlobalObjectDebuggerAgent.h:
  • inspector/agents/JSGlobalObjectRuntimeAgent.cpp:
  • inspector/agents/JSGlobalObjectRuntimeAgent.h:
  • inspector/scripts/codegen/cpp_generator_templates.py:

(CppGeneratorTemplates):

  • inspector/scripts/tests/expected/commands-with-async-attribute.json-result:
  • inspector/scripts/tests/expected/commands-with-optional-call-return-parameters.json-result:
  • inspector/scripts/tests/expected/domains-with-varying-command-sizes.json-result:
  • inspector/scripts/tests/expected/enum-values.json-result:
  • inspector/scripts/tests/expected/events-with-optional-parameters.json-result:
  • inspector/scripts/tests/expected/generate-domains-with-feature-guards.json-result:
  • inspector/scripts/tests/expected/same-type-id-different-domain.json-result:
  • inspector/scripts/tests/expected/shadowed-optional-type-setters.json-result:
  • inspector/scripts/tests/expected/type-declaration-aliased-primitive-type.json-result:
  • inspector/scripts/tests/expected/type-declaration-array-type.json-result:
  • inspector/scripts/tests/expected/type-declaration-enum-type.json-result:
  • inspector/scripts/tests/expected/type-declaration-object-type.json-result:
  • inspector/scripts/tests/expected/type-requiring-runtime-casts.json-result:
  • runtime/TypeSet.cpp:

(JSC::TypeSet::inspectorTypeSet):
(JSC::StructureShape::inspectorRepresentation):

Source/WebCore:

  • Configurations/FeatureDefines.xcconfig:
  • WebCore.exp.in:
  • bindings/js/JSCommandLineAPIHostCustom.cpp:
  • bindings/js/JSDOMWindowBase.cpp:

(WebCore::JSDOMWindowBase::supportsProfiling):
(WebCore::JSDOMWindowBase::supportsRichSourceInfo):

  • bindings/js/JSInspectorFrontendHostCustom.cpp:
  • bindings/js/ScriptController.cpp:

(WebCore::ScriptController::collectIsolatedContexts):

  • bindings/js/ScriptController.h:
  • bindings/js/ScriptGlobalObject.cpp:

(WebCore::ScriptGlobalObject::set):

  • bindings/js/ScriptGlobalObject.h:
  • bindings/js/WorkerScriptDebugServer.cpp:
  • bindings/js/WorkerScriptDebugServer.h:
  • dom/Node.cpp:

(WebCore::Node::inspect):

  • inspector/CommandLineAPIHost.cpp:
  • inspector/CommandLineAPIHost.idl:
  • inspector/CommandLineAPIModule.cpp:
  • inspector/CommandLineAPIModule.h:
  • inspector/DOMEditor.cpp:
  • inspector/DOMEditor.h:
  • inspector/DOMPatchSupport.cpp:
  • inspector/DOMPatchSupport.h:
  • inspector/InspectorApplicationCacheAgent.cpp:
  • inspector/InspectorApplicationCacheAgent.h:
  • inspector/InspectorCSSAgent.cpp:
  • inspector/InspectorCSSAgent.h:
  • inspector/InspectorClient.cpp:
  • inspector/InspectorConsoleInstrumentation.h:

(WebCore::InspectorInstrumentation::addMessageToConsole):
(WebCore::InspectorInstrumentation::consoleCount):
(WebCore::InspectorInstrumentation::startConsoleTiming):
(WebCore::InspectorInstrumentation::stopConsoleTiming):
(WebCore::InspectorInstrumentation::consoleTimeStamp):
(WebCore::InspectorInstrumentation::startProfiling):
(WebCore::InspectorInstrumentation::stopProfiling):

  • inspector/InspectorController.cpp:
  • inspector/InspectorController.h:
  • inspector/InspectorDOMAgent.cpp:
  • inspector/InspectorDOMAgent.h:
  • inspector/InspectorDOMDebuggerAgent.cpp:
  • inspector/InspectorDOMDebuggerAgent.h:
  • inspector/InspectorDOMStorageAgent.cpp:
  • inspector/InspectorDatabaseAgent.cpp:
  • inspector/InspectorDatabaseAgent.h:
  • inspector/InspectorDatabaseInstrumentation.h:

(WebCore::InspectorInstrumentation::didOpenDatabase):

  • inspector/InspectorDatabaseResource.cpp:
  • inspector/InspectorDatabaseResource.h:
  • inspector/InspectorFrontendClientLocal.cpp:
  • inspector/InspectorFrontendHost.cpp:
  • inspector/InspectorFrontendHost.idl:
  • inspector/InspectorHistory.cpp:
  • inspector/InspectorHistory.h:
  • inspector/InspectorIndexedDBAgent.cpp:
  • inspector/InspectorIndexedDBAgent.h:
  • inspector/InspectorInstrumentation.cpp:
  • inspector/InspectorInstrumentation.h:

(WebCore::InspectorInstrumentation::didClearWindowObjectInWorld):
(WebCore::InspectorInstrumentation::isDebuggerPaused):
(WebCore::InspectorInstrumentation::willInsertDOMNode):
(WebCore::InspectorInstrumentation::didInsertDOMNode):
(WebCore::InspectorInstrumentation::willRemoveDOMNode):
(WebCore::InspectorInstrumentation::didRemoveDOMNode):
(WebCore::InspectorInstrumentation::willModifyDOMAttr):
(WebCore::InspectorInstrumentation::didModifyDOMAttr):
(WebCore::InspectorInstrumentation::didRemoveDOMAttr):
(WebCore::InspectorInstrumentation::didInvalidateStyleAttr):
(WebCore::InspectorInstrumentation::frameWindowDiscarded):
(WebCore::InspectorInstrumentation::mediaQueryResultChanged):
(WebCore::InspectorInstrumentation::didPushShadowRoot):
(WebCore::InspectorInstrumentation::willPopShadowRoot):
(WebCore::InspectorInstrumentation::didCreateNamedFlow):
(WebCore::InspectorInstrumentation::willRemoveNamedFlow):
(WebCore::InspectorInstrumentation::didChangeRegionOverset):
(WebCore::InspectorInstrumentation::didRegisterNamedFlowContentElement):
(WebCore::InspectorInstrumentation::didUnregisterNamedFlowContentElement):
(WebCore::InspectorInstrumentation::mouseDidMoveOverElement):
(WebCore::InspectorInstrumentation::handleTouchEvent):
(WebCore::InspectorInstrumentation::handleMousePress):
(WebCore::InspectorInstrumentation::forcePseudoState):
(WebCore::InspectorInstrumentation::characterDataModified):
(WebCore::InspectorInstrumentation::willSendXMLHttpRequest):
(WebCore::InspectorInstrumentation::didInstallTimer):
(WebCore::InspectorInstrumentation::didRemoveTimer):
(WebCore::InspectorInstrumentation::willCallFunction):
(WebCore::InspectorInstrumentation::didCallFunction):
(WebCore::InspectorInstrumentation::willDispatchXHRReadyStateChangeEvent):
(WebCore::InspectorInstrumentation::didDispatchXHRReadyStateChangeEvent):
(WebCore::InspectorInstrumentation::willDispatchEvent):
(WebCore::InspectorInstrumentation::didDispatchEvent):
(WebCore::InspectorInstrumentation::willHandleEvent):
(WebCore::InspectorInstrumentation::didHandleEvent):
(WebCore::InspectorInstrumentation::willDispatchEventOnWindow):
(WebCore::InspectorInstrumentation::didDispatchEventOnWindow):
(WebCore::InspectorInstrumentation::willEvaluateScript):
(WebCore::InspectorInstrumentation::didEvaluateScript):
(WebCore::InspectorInstrumentation::scriptsEnabled):
(WebCore::InspectorInstrumentation::willFireTimer):
(WebCore::InspectorInstrumentation::didFireTimer):
(WebCore::InspectorInstrumentation::didInvalidateLayout):
(WebCore::InspectorInstrumentation::willLayout):
(WebCore::InspectorInstrumentation::didLayout):
(WebCore::InspectorInstrumentation::didScroll):
(WebCore::InspectorInstrumentation::willDispatchXHRLoadEvent):
(WebCore::InspectorInstrumentation::didDispatchXHRLoadEvent):
(WebCore::InspectorInstrumentation::willPaint):
(WebCore::InspectorInstrumentation::didPaint):
(WebCore::InspectorInstrumentation::willScrollLayer):
(WebCore::InspectorInstrumentation::didScrollLayer):
(WebCore::InspectorInstrumentation::willRecalculateStyle):
(WebCore::InspectorInstrumentation::didRecalculateStyle):
(WebCore::InspectorInstrumentation::didScheduleStyleRecalculation):
(WebCore::InspectorInstrumentation::applyEmulatedMedia):
(WebCore::InspectorInstrumentation::willSendRequest):
(WebCore::InspectorInstrumentation::continueAfterPingLoader):
(WebCore::InspectorInstrumentation::markResourceAsCached):
(WebCore::InspectorInstrumentation::didLoadResourceFromMemoryCache):
(WebCore::InspectorInstrumentation::willReceiveResourceResponse):
(WebCore::InspectorInstrumentation::didReceiveResourceResponse):
(WebCore::InspectorInstrumentation::continueAfterXFrameOptionsDenied):
(WebCore::InspectorInstrumentation::continueWithPolicyDownload):
(WebCore::InspectorInstrumentation::continueWithPolicyIgnore):
(WebCore::InspectorInstrumentation::didReceiveData):
(WebCore::InspectorInstrumentation::didFinishLoading):
(WebCore::InspectorInstrumentation::didFailLoading):
(WebCore::InspectorInstrumentation::documentThreadableLoaderStartedLoadingForClient):
(WebCore::InspectorInstrumentation::willLoadXHR):
(WebCore::InspectorInstrumentation::didFailXHRLoading):
(WebCore::InspectorInstrumentation::didFinishXHRLoading):
(WebCore::InspectorInstrumentation::didReceiveXHRResponse):
(WebCore::InspectorInstrumentation::willLoadXHRSynchronously):
(WebCore::InspectorInstrumentation::didLoadXHRSynchronously):
(WebCore::InspectorInstrumentation::scriptImported):
(WebCore::InspectorInstrumentation::scriptExecutionBlockedByCSP):
(WebCore::InspectorInstrumentation::didReceiveScriptResponse):
(WebCore::InspectorInstrumentation::domContentLoadedEventFired):
(WebCore::InspectorInstrumentation::loadEventFired):
(WebCore::InspectorInstrumentation::frameDetachedFromParent):
(WebCore::InspectorInstrumentation::didCommitLoad):
(WebCore::InspectorInstrumentation::frameDocumentUpdated):
(WebCore::InspectorInstrumentation::loaderDetachedFromFrame):
(WebCore::InspectorInstrumentation::frameStartedLoading):
(WebCore::InspectorInstrumentation::frameStoppedLoading):
(WebCore::InspectorInstrumentation::frameScheduledNavigation):
(WebCore::InspectorInstrumentation::frameClearedScheduledNavigation):
(WebCore::InspectorInstrumentation::willRunJavaScriptDialog):
(WebCore::InspectorInstrumentation::didRunJavaScriptDialog):
(WebCore::InspectorInstrumentation::willDestroyCachedResource):
(WebCore::InspectorInstrumentation::willWriteHTML):
(WebCore::InspectorInstrumentation::didWriteHTML):
(WebCore::InspectorInstrumentation::didDispatchDOMStorageEvent):
(WebCore::InspectorInstrumentation::shouldPauseDedicatedWorkerOnStart):
(WebCore::InspectorInstrumentation::didStartWorkerGlobalScope):
(WebCore::InspectorInstrumentation::workerGlobalScopeTerminated):
(WebCore::InspectorInstrumentation::didCreateWebSocket):
(WebCore::InspectorInstrumentation::willSendWebSocketHandshakeRequest):
(WebCore::InspectorInstrumentation::didReceiveWebSocketHandshakeResponse):
(WebCore::InspectorInstrumentation::didCloseWebSocket):
(WebCore::InspectorInstrumentation::didReceiveWebSocketFrame):
(WebCore::InspectorInstrumentation::didReceiveWebSocketFrameError):
(WebCore::InspectorInstrumentation::didSendWebSocketFrame):
(WebCore::InspectorInstrumentation::sessionCreated):
(WebCore::InspectorInstrumentation::sessionLoaded):
(WebCore::InspectorInstrumentation::sessionModified):
(WebCore::InspectorInstrumentation::segmentCreated):
(WebCore::InspectorInstrumentation::segmentCompleted):
(WebCore::InspectorInstrumentation::segmentLoaded):
(WebCore::InspectorInstrumentation::segmentUnloaded):
(WebCore::InspectorInstrumentation::captureStarted):
(WebCore::InspectorInstrumentation::captureStopped):
(WebCore::InspectorInstrumentation::playbackStarted):
(WebCore::InspectorInstrumentation::playbackPaused):
(WebCore::InspectorInstrumentation::playbackFinished):
(WebCore::InspectorInstrumentation::playbackHitPosition):
(WebCore::InspectorInstrumentation::networkStateChanged):
(WebCore::InspectorInstrumentation::updateApplicationCacheStatus):
(WebCore::InspectorInstrumentation::didRequestAnimationFrame):
(WebCore::InspectorInstrumentation::didCancelAnimationFrame):
(WebCore::InspectorInstrumentation::willFireAnimationFrame):
(WebCore::InspectorInstrumentation::didFireAnimationFrame):
(WebCore::InspectorInstrumentation::layerTreeDidChange):
(WebCore::InspectorInstrumentation::renderLayerDestroyed):
(WebCore::InspectorInstrumentation::pseudoElementDestroyed):
(WebCore::InspectorInstrumentation::instrumentingAgentsForDocument):
(WebCore::InspectorInstrumentation::hasFrontends): Deleted.
(WebCore::InspectorInstrumentation::consoleAgentEnabled): Deleted.
(WebCore::InspectorInstrumentation::runtimeAgentEnabled): Deleted.
(WebCore::InspectorInstrumentation::timelineAgentEnabled): Deleted.
(WebCore::InspectorInstrumentation::replayAgentEnabled): Deleted.

  • inspector/InspectorLayerTreeAgent.cpp:
  • inspector/InspectorLayerTreeAgent.h:
  • inspector/InspectorOverlay.cpp:
  • inspector/InspectorPageAgent.cpp:
  • inspector/InspectorPageAgent.h:
  • inspector/InspectorReplayAgent.cpp:
  • inspector/InspectorReplayAgent.h:
  • inspector/InspectorResourceAgent.cpp:
  • inspector/InspectorResourceAgent.h:
  • inspector/InspectorStyleSheet.cpp:
  • inspector/InspectorStyleSheet.h:
  • inspector/InspectorStyleTextEditor.cpp:
  • inspector/InspectorStyleTextEditor.h:
  • inspector/InspectorTimelineAgent.cpp:
  • inspector/InspectorTimelineAgent.h:
  • inspector/InspectorWorkerAgent.cpp:
  • inspector/InspectorWorkerResource.h:
  • inspector/InstrumentingAgents.cpp:
  • inspector/NetworkResourcesData.cpp:
  • inspector/NetworkResourcesData.h:
  • inspector/PageConsoleAgent.cpp:
  • inspector/PageConsoleAgent.h:
  • inspector/PageDebuggerAgent.cpp:
  • inspector/PageDebuggerAgent.h:
  • inspector/PageRuntimeAgent.cpp:
  • inspector/PageRuntimeAgent.h:
  • inspector/PageScriptDebugServer.cpp:
  • inspector/PageScriptDebugServer.h:
  • inspector/TimelineRecordFactory.cpp:
  • inspector/WebConsoleAgent.cpp:
  • inspector/WebConsoleAgent.h:
  • inspector/WebDebuggerAgent.cpp:
  • inspector/WebDebuggerAgent.h:
  • inspector/WebInjectedScriptHost.cpp:
  • inspector/WebInjectedScriptHost.h:
  • inspector/WebInjectedScriptManager.cpp:
  • inspector/WebInjectedScriptManager.h:
  • inspector/WorkerConsoleAgent.cpp:
  • inspector/WorkerConsoleAgent.h:
  • inspector/WorkerDebuggerAgent.cpp:
  • inspector/WorkerDebuggerAgent.h:
  • inspector/WorkerInspectorController.cpp:
  • inspector/WorkerInspectorController.h:
  • inspector/WorkerRuntimeAgent.cpp:
  • inspector/WorkerRuntimeAgent.h:
  • loader/DocumentThreadableLoader.cpp:

(WebCore::DocumentThreadableLoader::didReceiveResponse):
(WebCore::DocumentThreadableLoader::loadRequest):

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::continueLoadAfterNavigationPolicy):
(WebCore::FrameLoader::dispatchDidClearWindowObjectInWorld):

  • loader/appcache/ApplicationCacheGroup.cpp:

(WebCore::ApplicationCacheGroup::createResourceHandle):
(WebCore::ApplicationCacheGroup::didReceiveResponse):

  • loader/appcache/ApplicationCacheHost.cpp:

(WebCore::ApplicationCacheHost::applicationCacheInfo):

  • loader/appcache/ApplicationCacheHost.h:
  • loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::shouldContinueAfterNotifyingLoadedFromMemoryCache):

  • page/ContextMenuController.cpp:

(WebCore::ContextMenuController::showContextMenu):
(WebCore::ContextMenuController::contextMenuItemSelected):
(WebCore::ContextMenuController::populate):
(WebCore::ContextMenuController::addInspectElementItem):
(WebCore::ContextMenuController::checkOrEnableIfNeeded):

  • page/FrameView.cpp:

(WebCore::FrameView::sendResizeEventIfNeeded):

  • page/Page.cpp:

(WebCore::Page::Page):
(WebCore::Page::~Page):

  • page/Page.h:
  • platform/ContextMenuItem.h:
  • platform/efl/EflInspectorUtilities.cpp:
  • platform/efl/EflInspectorUtilities.h:
  • platform/network/ResourceRequestBase.h:

(WebCore::ResourceRequestBase::ResourceRequestBase):

  • platform/network/cf/ResourceRequestCFNet.cpp:

(WebCore::ResourceRequest::updateFromDelegatePreservingOldProperties):

  • platform/network/cocoa/ResourceRequestCocoa.mm:

(WebCore::ResourceRequest::updateFromDelegatePreservingOldProperties):

  • testing/Internals.cpp:

(WebCore::InspectorFrontendChannelDummy::sendMessageToFrontend):
(WebCore::Internals::resetToConsistentState):
(WebCore::Internals::inspectorHighlightRects):
(WebCore::Internals::inspectorHighlightObject):
(WebCore::Internals::setInspectorIsUnderTest):

  • testing/Internals.h:
  • testing/Internals.idl:
  • workers/WorkerGlobalScope.cpp:

(WebCore::WorkerGlobalScope::WorkerGlobalScope):

  • workers/WorkerGlobalScope.h:
  • workers/WorkerGlobalScopeProxy.h:
  • workers/WorkerMessagingProxy.cpp:

(WebCore::WorkerMessagingProxy::WorkerMessagingProxy):
(WebCore::WorkerMessagingProxy::sendMessageToInspector):
(WebCore::WorkerMessagingProxy::postMessageToPageInspector):

  • workers/WorkerMessagingProxy.h:
  • workers/WorkerReportingProxy.h:
  • workers/WorkerThread.cpp:

(WebCore::WorkerThread::workerThread):

Source/WebKit:

  • WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:

Source/WebKit/mac:

  • Configurations/FeatureDefines.xcconfig:
  • WebCoreSupport/WebFrameLoaderClient.mm:

(WebFrameLoaderClient::dispatchWillSendRequest):

Source/WebKit/win:

  • WebCoreSupport/WebInspectorClient.cpp:

(registerWindowClass):

(WebInspector::setTimelineProfilingEnabled):

  • WebNodeHighlight.cpp:

(WebNodeHighlight::WebNodeHighlight):
(WebNodeHighlight::update):

  • WebNodeHighlight.h:
  • WebView.cpp:

(WebView::WebView):
(WebView::close):
(WebView::initWithFrame):
(WebView::inspector):

  • WebView.h:

Source/WebKit2:

  • Configurations/FeatureDefines.xcconfig:
  • Shared/API/c/WKSharedAPICast.h:

(WebKit::toAPI):
(WebKit::toImpl):

  • Shared/WebCoreArgumentCoders.cpp:

(IPC::ArgumentCoder<ResourceRequest>::encode):
(IPC::ArgumentCoder<ResourceRequest>::decode):

  • UIProcess/API/C/WKInspector.cpp:

(WKInspectorGetTypeID):
(WKInspectorGetPage):
(WKInspectorIsConnected):
(WKInspectorIsVisible):
(WKInspectorIsFront):
(WKInspectorConnect):
(WKInspectorShow):
(WKInspectorHide):
(WKInspectorClose):
(WKInspectorShowConsole):
(WKInspectorShowResources):
(WKInspectorShowMainResourceForFrame):
(WKInspectorIsAttached):
(WKInspectorAttach):
(WKInspectorDetach):
(WKInspectorIsProfilingPage):
(WKInspectorTogglePageProfiling):

  • UIProcess/API/C/WKPage.cpp:

(WKPageGetInspector):

  • UIProcess/API/efl/ewk_view.cpp:

(ewk_view_inspector_show):
(ewk_view_inspector_close):

  • UIProcess/API/efl/tests/test_ewk2_view.cpp:

(TEST_F):

  • UIProcess/PageClient.h:
  • UIProcess/WebInspectorProxy.cpp:
  • UIProcess/WebInspectorProxy.h:
  • UIProcess/WebInspectorProxy.messages.in:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::reattachToWebProcess):
(WebKit::WebPageProxy::maybeInitializeSandboxExtensionHandle):
(WebKit::WebPageProxy::resetState):

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::getLaunchOptions):

  • UIProcess/efl/WebInspectorProxyEfl.cpp:
  • UIProcess/gtk/WebInspectorProxyGtk.cpp:
  • UIProcess/ios/PageClientImplIOS.h:
  • UIProcess/ios/PageClientImplIOS.mm:

(WebKit::PageClientImpl::disableInspectorNodeSearch):

  • UIProcess/ios/WebInspectorProxyIOS.mm:
  • UIProcess/ios/WebPageProxyIOS.mm:

(WebKit::WebPageProxy::disableInspectorNodeSearch):

  • UIProcess/mac/WebInspectorProxyMac.mm:
  • WebProcess/InjectedBundle/API/c/WKBundleInspector.cpp:

(WKBundleInspectorGetTypeID):
(WKBundleInspectorShow):
(WKBundleInspectorClose):
(WKBundleInspectorEvaluateScriptForTest):
(WKBundleInspectorSetPageProfilingEnabled):

  • WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:

(WKBundlePageGetInspector):

  • WebProcess/WebCoreSupport/WebInspectorClient.cpp:
  • WebProcess/WebCoreSupport/WebInspectorClient.h:
  • WebProcess/WebCoreSupport/WebInspectorFrontendClient.h:
  • WebProcess/WebPage/WebInspector.cpp:
  • WebProcess/WebPage/WebInspector.h:
  • WebProcess/WebPage/WebInspector.messages.in:
  • WebProcess/WebPage/WebInspectorUI.cpp:
  • WebProcess/WebPage/WebInspectorUI.h:
  • WebProcess/WebPage/WebInspectorUI.messages.in:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::WebPage):
(WebKit::WebPage::~WebPage):
(WebKit::WebPage::close):
(WebKit::WebPage::inspectorUI):
(WebKit::WebPage::didReceiveMessage):

  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/efl/WebInspectorEfl.cpp:
  • WebProcess/WebPage/efl/WebInspectorUIEfl.cpp:
  • WebProcess/WebPage/gtk/WebInspectorGtk.cpp:
  • WebProcess/WebPage/gtk/WebInspectorUIGtk.cpp:
  • WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::disableInspectorNodeSearch):

  • WebProcess/WebPage/mac/WebInspectorMac.mm:
  • WebProcess/WebPage/mac/WebInspectorUIMac.mm:
  • config.h:

Source/WTF:

  • wtf/FeatureDefines.h:

Tools:

  • DumpRenderTree/mac/TestRunnerMac.mm:

(TestRunner::showWebInspector):
(TestRunner::closeWebInspector):
(TestRunner::evaluateInWebInspector):

  • Scripts/webkitperl/FeatureList.pm:
  • WebKitTestRunner/InjectedBundle/TestRunner.cpp:

(WTR::TestRunner::showWebInspector):
(WTR::TestRunner::closeWebInspector):
(WTR::TestRunner::evaluateInWebInspector):

  • WebKitTestRunner/TestInvocation.cpp:

(WTR::TestInvocation::invoke):

12:20 AM Changeset in webkit [178819] by bshafiei@apple.com
  • 3 edits in branches/safari-600.1.4.15-branch/Source/WebCore

Merged r175818. rdar://problem/19419835

12:18 AM Changeset in webkit [178818] by bshafiei@apple.com
  • 2 edits in branches/safari-600.1.4.15-branch/Source/WebCore

Merged r175812. rdar://problem/19420081

12:17 AM Changeset in webkit [178817] by bshafiei@apple.com
  • 2 edits in branches/safari-600.1.4.15-branch/Source/WebCore

Merged r175771. rdar://problem/19450090

12:16 AM Changeset in webkit [178816] by bshafiei@apple.com
  • 2 edits in branches/safari-600.1.4.15-branch/Source/WebCore

Merged r175718. rdar://problem/19395083

12:15 AM Changeset in webkit [178815] by bshafiei@apple.com
  • 6 edits
    2 copies in branches/safari-600.1.4.15-branch/Source/WebKit2

Merged r175698. rdar://problem/19419806

12:13 AM Changeset in webkit [178814] by bshafiei@apple.com
  • 2 edits in branches/safari-600.1.4.15-branch/Source/WebKit2

Merged r175636. rdar://problem/19419798

12:12 AM Changeset in webkit [178813] by bshafiei@apple.com
  • 2 edits in branches/safari-600.1.4.15-branch/Source/WebKit2

Merged r175334. rdar://problem/19302743

12:11 AM Changeset in webkit [178812] by bshafiei@apple.com
  • 2 edits in branches/safari-600.1.4.15-branch/Source/WebCore

Merged r175277. rdar://problem/19419795

12:10 AM Changeset in webkit [178811] by bshafiei@apple.com
  • 2 edits in branches/safari-600.1.4.15-branch/Source/WebKit2

Merged r175266. rdar://problem/19420035

12:06 AM Changeset in webkit [178810] by bshafiei@apple.com
  • 4 edits
    3 copies in branches/safari-600.1.4.15-branch

Merged r175236. rdar://problem/19432709

Note: See TracTimeline for information about the timeline view.