Timeline



May 15, 2010:

11:57 PM Changeset in webkit [59567] by eric@webkit.org
  • 3 edits
    3 deletes in trunk

2010-05-15 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r59565.
​http://trac.webkit.org/changeset/59565
​https://bugs.webkit.org/show_bug.cgi?id=39173

Broke GTK (Requested by abarth on #webkit).

  • fast/canvas/canvas-toDataURL-case-insensitive-mimetype-expected.txt: Removed.
  • fast/canvas/canvas-toDataURL-case-insensitive-mimetype.html: Removed.
  • fast/canvas/script-tests/canvas-toDataURL-case-insensitive-mimetype.js: Removed.

2010-05-15 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r59565.
​http://trac.webkit.org/changeset/59565
​https://bugs.webkit.org/show_bug.cgi?id=39173

Broke GTK (Requested by abarth on #webkit).

  • dom/CanvasSurface.cpp: (WebCore::CanvasSurface::toDataURL):
8:50 PM Changeset in webkit [59566] by dbates@webkit.org
  • 2 edits
    1 add in trunk/WebKitTools

2010-05-15 Daniel Bates <​dbates@rim.com>

Reviewed by Chris Jerdonek.

​https://bugs.webkit.org/show_bug.cgi?id=39170

Add function parseSvnPropertyValue to parse single-line and multi-line
property values of an SVN property change.

  • Scripts/VCSUtils.pm:

Added function parseSvnPropertyValue. We will use this as part of
Bug #38885 <​https://bugs.webkit.org/show_bug.cgi?id=38885>.

  • Scripts/webkitperl/VCSUtils_unittest/parseSvnPropertyValue.pl: Added.
8:15 PM Changeset in webkit [59565] by eric@webkit.org
  • 3 edits
    3 adds in trunk

2010-05-15 Andreas Kling <​andreas.kling@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

Add a test to verify that Canvas's toDataURL() is case insensitive wrt the mimeType argument.
​https://bugs.webkit.org/show_bug.cgi?id=39153

Spec link:
​http://www.whatwg.org/specs/web-apps/current-work/#dom-canvas-todataurl

  • fast/canvas/canvas-toDataURL-case-insensitive-mimetype-expected.txt: Added.
  • fast/canvas/canvas-toDataURL-case-insensitive-mimetype.html: Added.
  • fast/canvas/script-tests/canvas-toDataURL-case-insensitive-mimetype.js: Added. (tryMimeType):

2010-05-15 Andreas Kling <​andreas.kling@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

Canvas's toDataURL() should be case insensitive wrt the mimeType argument.
​https://bugs.webkit.org/show_bug.cgi?id=39153

Spec link:
​http://www.whatwg.org/specs/web-apps/current-work/#dom-canvas-todataurl

Test: fast/canvas/canvas-toDataURL-case-insensitive-mimetype.html

  • dom/CanvasSurface.cpp: (WebCore::CanvasSurface::toDataURL):
8:03 PM Changeset in webkit [59564] by eric@webkit.org
  • 3 edits in trunk/WebCore

2010-05-15 Anders Bakken <​agbakken@gmail.com>

Reviewed by Kenneth Rohde Christiansen.

QObject::objectName() returns a QString and QtField::name()
creates a temporary QByteArray object and returns constData() from it.
This is not safe.

This patch changes the signature of the function to return a
QByteArray instead of const char *.

​https://bugs.webkit.org/show_bug.cgi?id=39010

  • bridge/qt/qt_instance.cpp: (JSC::Bindings::QtInstance::getPropertyNames): (JSC::Bindings::QtField::name):
  • bridge/qt/qt_runtime.h:
7:52 PM Changeset in webkit [59563] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-05-15 Anders Bakken <​agbakken@gmail.com>

Reviewed by Kenneth Rohde Christiansen.

Don't unnecessarily copy data when searching for methods in QtClass.

[Qt] JSValue QtClass::fallbackObject can be optimized
​https://bugs.webkit.org/show_bug.cgi?id=37684

  • bridge/qt/qt_class.cpp: (JSC::Bindings::QtClass::fallbackObject):
7:34 PM Changeset in webkit [59562] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-05-15 Anders Bakken <​agbakken@gmail.com>

Reviewed by Kenneth Rohde Christiansen.

Identifier::ascii() is not threadsafe and shouldn't be used for
converting to and from QString/QByteArray.

​https://bugs.webkit.org/show_bug.cgi?id=39009

  • bridge/qt/qt_class.cpp: (JSC::Bindings::QtClass::fallbackObject): (JSC::Bindings::QtClass::fieldNamed):
7:22 PM Changeset in webkit [59561] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-05-15 Chang Shu <​chang.shu@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

Based on the spec and Philip Taylor's test suite, createImageData() should throw
an INDEX_SIZE_ERR exception if either the sw or sh arguments are zero.
The link to the spec:
​http://philip.html5.org/tests/canvas/suite/tests/spec.html#testrefs.2d.imageData.getcreate.zero

​https://bugs.webkit.org/show_bug.cgi?id=39166

The complete test suite is in the process of checking in.
​https://bugs.webkit.org/show_bug.cgi?id=20553

  • html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::createImageData):
7:08 PM Changeset in webkit [59560] by eric@webkit.org
  • 4 edits in trunk/WebKit/chromium

2010-05-15 Darin Fisher <​darin@chromium.org>

Reviewed by Adam Barth.

[chromium] Expose element accessor on WebPluginContainer
​https://bugs.webkit.org/show_bug.cgi?id=39152

  • public/WebPluginContainer.h:
  • src/WebPluginContainerImpl.cpp: (WebKit::WebPluginContainerImpl::element):
  • src/WebPluginContainerImpl.h:
6:43 PM Changeset in webkit [59559] by eric@webkit.org
  • 4 edits in trunk/WebCore

2010-05-15 Adam Barth <​abarth@webkit.org>

Reviewed by Darin Adler.

XMLHttpRequest.getResponseHeader doesn't need to be custom
​https://bugs.webkit.org/show_bug.cgi?id=39125

I don't see any reason this method needs to be custom. No new tests
because there's no behavior change.

  • bindings/js/JSXMLHttpRequestCustom.cpp:
  • bindings/v8/custom/V8XMLHttpRequestCustom.cpp:
  • xml/XMLHttpRequest.idl:
5:30 PM Changeset in webkit [59558] by abarth@webkit.org
  • 3 edits in trunk/LayoutTests

2010-05-15 Adam Barth <​abarth@webkit.org>

Reviewed by David Hyatt.

Rebaseline client-rects.html on Qt
​https://bugs.webkit.org/show_bug.cgi?id=39169

  • platform/qt/Skipped:
  • platform/qt/fast/multicol/client-rects-expected.txt:
5:19 PM Changeset in webkit [59557] by eric@webkit.org
  • 14 edits in trunk/WebCore

2010-05-15 Adam Barth <​abarth@webkit.org>

Reviewed by Darin Adler.

XMLHttpRequest.setRequestHeader shouldn't be custom
​https://bugs.webkit.org/show_bug.cgi?id=39124

I don't see any reason why this method needs to be custom. No tests
because no behavior change.

  • bindings/js/JSXMLHttpRequestCustom.cpp:
  • bindings/scripts/CodeGeneratorJS.pm:
  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/scripts/test/GObject/WebKitDOMTestObj.cpp: (webkit_dom_test_obj_method_that_requires_all_args): (webkit_dom_test_obj_method_that_requires_all_args_and_throws):
  • bindings/scripts/test/GObject/WebKitDOMTestObj.h:
  • bindings/scripts/test/JS/JSTestObj.cpp: (WebCore::): (WebCore::jsTestObjPrototypeFunctionMethodThatRequiresAllArgs): (WebCore::jsTestObjPrototypeFunctionMethodThatRequiresAllArgsAndThrows):
  • bindings/scripts/test/JS/JSTestObj.h:
  • bindings/scripts/test/ObjC/DOMTestObj.h:
  • bindings/scripts/test/ObjC/DOMTestObj.mm: (-[DOMTestObj methodThatRequiresAllArgs:objArg:]): (-[DOMTestObj methodThatRequiresAllArgsAndThrows:objArg:]):
  • bindings/scripts/test/TestObj.idl:
  • bindings/scripts/test/V8/V8TestObj.cpp: (WebCore::TestObjInternal::methodThatRequiresAllArgsCallback): (WebCore::TestObjInternal::methodThatRequiresAllArgsAndThrowsCallback): (WebCore::ConfigureV8TestObjTemplate):
  • bindings/v8/custom/V8XMLHttpRequestCustom.cpp:
  • xml/XMLHttpRequest.idl:
3:33 PM Changeset in webkit [59556] by ap@apple.com
  • 3 edits
    2 adds in trunk

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=39048
<rdar://problem/7978384> REGRESSION (r55802): XML errors on Google maps ("Entity 'nbsp' not
defined") with JavaScript disabled

Google Maps goes into mobile mode if JavaScript is disabled for some reason, and sends XHTML
content with XHTML Mobile DOCTYPE. We want to handle it whether XHTMLMP is enabled or not.

Test: fast/doctypes/xhtml-with-xhtmlmp-doctype.xhtml

  • dom/XMLTokenizerLibxml2.cpp: (WebCore::externalSubsetHandler): Restore pre-55802 behavior for builds that don't have XHTMLMP enabled. Given that r55802 negated the condition without breaking XHTMLMP, this line is actually always needed.
3:29 PM Changeset in webkit [59555] by eric@webkit.org
  • 8 edits in trunk

2010-05-15 Jochen Eisinger <​jochen@chromium.org>

Reviewed by Dmitry Titov.

Implement canEstablishDatabase call for workers.
​https://bugs.webkit.org/show_bug.cgi?id=38742

  • public/WebCommonWorkerClient.h:
  • src/DatabaseObserver.cpp: (WebCore::DatabaseObserver::canEstablishDatabase):
  • src/WebWorkerBase.cpp: (WebKit::WebWorkerBase::allowDatabase): (WebKit::WebWorkerBase::allowDatabaseTask): (WebKit::WebWorkerBase::AllowDatabaseMainThreadBridge::AllowDatabaseMainThreadBridge): (WebKit::WebWorkerBase::AllowDatabaseMainThreadBridge::cancel): (WebKit::WebWorkerBase::AllowDatabaseMainThreadBridge::result): (WebKit::WebWorkerBase::AllowDatabaseMainThreadBridge::signalCompleted): (WebKit::WebWorkerBase::AllowDatabaseMainThreadBridge::didComplete):
  • src/WebWorkerBase.h:
  • src/WebWorkerClientImpl.h: (WebKit::WebWorkerClientImpl::allowDatabase):

2010-05-15 Jochen Eisinger <​jochen@chromium.org>

Reviewed by Dmitry Titov.

Add allowDatabase method to TestWebWorker.
​https://bugs.webkit.org/show_bug.cgi?id=38742

  • DumpRenderTree/chromium/TestWebWorker.h: (TestWebWorker::allowDatabase):
3:19 PM Changeset in webkit [59554] by eric@webkit.org
  • 3 edits in trunk/WebCore

2010-05-15 Vangelis Kokkevis <​vangelis@chromium.org>

Reviewed by Darin Fisher.

Fixing LayerChromium hierarchy updates where due to mixed ownership
handling, sublayer updates didn't always properly update parent-to-child
and child-to-parent pointers in sync.
​https://bugs.webkit.org/show_bug.cgi?id=39138

  • platform/graphics/chromium/LayerChromium.cpp: (WebCore::LayerChromium::~LayerChromium): (WebCore::LayerChromium::setNeedsCommit): Typo fix. (WebCore::LayerChromium::insertSublayer): (WebCore::LayerChromium::removeFromSuperlayer): (WebCore::LayerChromium::removeSublayer): (WebCore::LayerChromium::replaceSublayer): (WebCore::LayerChromium::removeAllSublayers): (WebCore::LayerChromium::setSublayers):
  • platform/graphics/chromium/LayerChromium.h: (WebCore::LayerChromium::setSuperlayer):
3:08 PM Changeset in webkit [59553] by eric@webkit.org
  • 3 edits in trunk/WebCore

2010-05-15 Andrey Kosyakov <​caseq@chromium.org>

Reviewed by Timothy Hatcher.

Got rid of absolute positioning in favor of flex boxes where possible.
Added shadow for help window.
Changed window style names to more comprehensible.
​https://bugs.webkit.org/show_bug.cgi?id=39120

  • inspector/front-end/HelpScreen.js: (WebInspector.HelpScreen):
  • inspector/front-end/helpScreen.css: (.help-window-outer): (body.attached .help-window-outer): (.help-window-main): (body.attached .help-window-main): (.help-window-caption): (body.attached .help-window-caption): (.help-window-title): (.help-scrollable): (.help-close-button): (body.platform-mac .help-close-button): (body:not(.platform-mac) .help-close-button):
1:29 PM Changeset in webkit [59552] by Simon Hausmann
  • 1 edit
    19 deletes in trunk/WebKitTools

[Qt] Rename QtLauncher to QtTestBrowser
​https://bugs.webkit.org/show_bug.cgi?id=37665

Rubber-stamped by Antti Koivisto.

Forgot to remove the original directory after the rename.

  • QtLauncher: Removed.
1:23 PM Changeset in webkit [59551] by eric@webkit.org
  • 4 edits in trunk/WebCore

2010-05-15 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r59549.
​http://trac.webkit.org/changeset/59549
​https://bugs.webkit.org/show_bug.cgi?id=39167

Broke Chromium build (Requested by abarth on #webkit).

  • bindings/scripts/CodeGeneratorV8.pm:
  • storage/IDBRequest.cpp: (WebCore::IDBRequest::suspend): (WebCore::IDBRequest::resume): (WebCore::IDBRequest::timerFired): (WebCore::IDBRequest::onEventCommon):
  • storage/IDBRequest.h:
1:03 PM Changeset in webkit [59550] by eric@webkit.org
  • 5 edits in trunk/WebCore

2010-05-15 Vangelis Kokkevis <​vangelis@chromium.org>

Reviewed by Darin Fisher.

Adding code path for composited layers (LayerChromium) containing only
an Image element.
​https://bugs.webkit.org/show_bug.cgi?id=39142

No new tests, covered under the existing tests for composited layers.

  • platform/graphics/chromium/GraphicsLayerChromium.cpp: (WebCore::GraphicsLayerChromium::setContentsToImage): (WebCore::GraphicsLayerChromium::updateContentsImage):
  • platform/graphics/chromium/GraphicsLayerChromium.h:
  • platform/graphics/chromium/LayerChromium.cpp: (WebCore::LayerChromium::LayerChromium): (WebCore::LayerChromium::setContents):
  • platform/graphics/chromium/LayerChromium.h: (WebCore::LayerChromium::contents):
12:53 PM Changeset in webkit [59549] by eric@webkit.org
  • 4 edits in trunk/WebCore

2010-05-15 Andrei Popescu <​andreip@google.com>

Reviewed by Jeremy Orlow.

IDBRequest is not a proper ActiveDomObject
​https://bugs.webkit.org/show_bug.cgi?id=39001

Add IDBRequest interface to the IsActiveDomType
routine of the CodeGeneratorV8.pm.

Rename IDBRequest::m_stopped to m_suspended and reset
the flag when resume() is called.

No new tests, Indexed Database isn't yet testable.

  • bindings/scripts/CodeGeneratorV8.pm:
  • storage/IDBRequest.cpp: (WebCore::IDBRequest::suspend): (WebCore::IDBRequest::resume): (WebCore::IDBRequest::timerFired): (WebCore::IDBRequest::onEventCommon):
  • storage/IDBRequest.h:
12:41 PM Changeset in webkit [59548] by eric@webkit.org
  • 3 edits in trunk/WebCore

2010-05-15 Andrei Bucur <​abucur@adobe.com>

Reviewed by Gustavo Noronha Silva.

Functions using the cairo_pattern_t object returned by
Pattern::createPlatformPattern sould destroy it after the painting
operation. Failing to do so causes memory leaks.

Test: No test was added because the patch adds no new functionality.
It just completes the normal life cycle of a cairo_pattern_t object.

  • platform/graphics/cairo/FontCairo.cpp: (WebCore::Font::drawGlyphs):
  • platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::setPlatformFill): (WebCore::setPlatformStroke):
12:22 PM Changeset in webkit [59547] by oliver@apple.com
  • 7 edits in trunk

2010-05-15 Oliver Hunt <​oliver@apple.com>

Reviewed by Maciej Stachowiak.

Incorrect codegen for slowcase of < in 64-bit
​https://bugs.webkit.org/show_bug.cgi?id=39151

Call the correct stud for the slowcases of the < operator.

  • jit/JITArithmetic.cpp: (JSC::JIT::emitSlow_op_jnless): (JSC::JIT::emitSlow_op_jless):

2010-05-15 Oliver Hunt <​oliver@apple.com>

Reviewed by Maciej Stachowiak.

Incorrect codegen for slowcase of < in 64-bit
​https://bugs.webkit.org/show_bug.cgi?id=39151

Add yet more tests for the < operator when comparing integer strings.

  • fast/js/comparison-operators-greater-expected.txt:
  • fast/js/comparison-operators-less-expected.txt:
  • fast/js/script-tests/comparison-operators-greater.js:
  • fast/js/script-tests/comparison-operators-less.js:
11:56 AM Changeset in webkit [59546] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-05-15 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r59544.
​http://trac.webkit.org/changeset/59544
​https://bugs.webkit.org/show_bug.cgi?id=39165

Cased LayoutTest to start crashing (Requested by abarth on
#webkit).

  • Scripts/old-run-webkit-tests:
11:38 AM Changeset in webkit [59545] by eric@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-05-15 Leo Yang <​leo.yang@torchmobile.com.cn>

Reviewed by Darin Adler.

Fix bug ​https://bugs.webkit.org/show_bug.cgi?id=38890

  • runtime/DatePrototype.cpp: (JSC::formatLocaleDate):
11:26 AM Changeset in webkit [59544] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-05-15 Mario Sanchez Prada <​msanchez@igalia.com>

Reviewed by Xan Lopez.

Ensure DRT loads GAIL (Gtk+ module), for a11y tests
​https://bugs.webkit.org/show_bug.cgi?id=38648

Add the GTK_MODULES envvar (set to "gail") to the clean
environment when running DRT for the Gtk+ port

  • Scripts/old-run-webkit-tests:
10:34 AM Changeset in webkit [59543] by eric@webkit.org
  • 3 edits in trunk/WebKit/chromium

2010-05-15 Jay Civelli <​jcivelli@chromium.org>

Reviewed by Darin Fisher.

[chromium] Adding a notification on WebViewClient when a new
node gets focused.
​https://bugs.webkit.org/show_bug.cgi?id=38508

  • public/WebViewClient.h: (WebKit::WebViewClient::focusedNodeChanged):
  • src/ChromeClientImpl.cpp: (WebKit::ChromeClientImpl::focusedNodeChanged):
10:01 AM Changeset in webkit [59542] by yael.aharon@nokia.com
  • 5 edits in trunk/LayoutTests

Unreviewed.

Update expected results after 59541

  • platform/qt/fast/dom/Window/window-properties-expected.txt:
  • platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/qt/fast/dom/prototype-inheritance-expected.txt:
  • platform/qt/fast/js/global-constructors-expected.txt:
9:41 AM Changeset in webkit [59541] by yael.aharon@nokia.com
  • 26 edits
    16 adds in trunk

Initial support for HTMLMeterElement
​https://bugs.webkit.org/show_bug.cgi?id=38140

Reviewed by Kent Tamura.

WebCore:

This patch adds support for HTMLMeterElement, including default rendering
of the meter element. That is because some platforms do not have a native gauge.
The feature is turned on only for the Qt platform.

Tests: fast/dom/HTMLMeterElement/meter-element.html

fast/dom/HTMLMeterElement/set-meter-properties.html

  • DerivedSources.cpp:
  • DerivedSources.make:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pri:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):

  • css/CSSValueKeywords.in:
  • css/html.css:

(meter):
(meter::-webkit-meter):

  • html/HTMLAttributeNames.in:
  • html/HTMLElement.cpp:

(WebCore::inlineTagList):

  • html/HTMLElementsAllInOne.cpp:
  • html/HTMLMeterElement.cpp: Added.

(WebCore::HTMLMeterElement::HTMLMeterElement):
(WebCore::HTMLMeterElement::create):
(WebCore::HTMLMeterElement::createRenderer):
(WebCore::HTMLMeterElement::formControlType):
(WebCore::HTMLMeterElement::parseMappedAttribute):
(WebCore::HTMLMeterElement::min):
(WebCore::HTMLMeterElement::setMin):
(WebCore::HTMLMeterElement::max):
(WebCore::HTMLMeterElement::setMax):
(WebCore::HTMLMeterElement::value):
(WebCore::HTMLMeterElement::setValue):
(WebCore::HTMLMeterElement::low):
(WebCore::HTMLMeterElement::setLow):
(WebCore::HTMLMeterElement::high):
(WebCore::HTMLMeterElement::setHigh):
(WebCore::HTMLMeterElement::optimum):
(WebCore::HTMLMeterElement::setOptimum):

  • html/HTMLMeterElement.h: Added.

(WebCore::HTMLMeterElement::recalcWillValidate):

  • html/HTMLMeterElement.idl: Added.
  • html/HTMLTagNames.in:
  • page/DOMWindow.idl:
  • platform/ThemeTypes.h:
  • rendering/RenderMeter.cpp: Added.

(WebCore::RenderMeter::RenderMeter):
(WebCore::RenderMeter::layout):
(WebCore::RenderMeter::updateFromElement):

  • rendering/RenderMeter.h: Added.

(WebCore::RenderMeter::renderName):
(WebCore::RenderMeter::isMeter):
(WebCore::toRenderMeter):

  • rendering/RenderObject.h:

(WebCore::RenderObject::isMeter):

  • rendering/RenderTheme.cpp:

(WebCore::RenderTheme::adjustStyle):
(WebCore::RenderTheme::paint):
(WebCore::RenderTheme::paintBorderOnly):
(WebCore::RenderTheme::paintDecorations):
(WebCore::RenderTheme::adjustMeterStyle):
(WebCore::RenderTheme::paintMeter):

  • rendering/RenderTheme.h:

LayoutTests:

  • fast/dom/HTMLMeterElement: Added.
  • fast/dom/HTMLMeterElement/meter-element.html: Added.
  • fast/dom/HTMLMeterElement/script-tests: Added.
  • fast/dom/HTMLMeterElement/script-tests/TEMPLATE.html: Added.
  • fast/dom/HTMLMeterElement/script-tests/set-meter-properties.js: Added.
  • fast/dom/HTMLMeterElement/set-meter-properties-expected.txt: Added.
  • fast/dom/HTMLMeterElement/set-meter-properties.html: Added.
  • platform/chromium/test_expectations.txt:
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/fast/dom/HTMLMeterElement: Added.
  • platform/qt/fast/dom/HTMLMeterElement/meter-element-expected.checksum: Added.
  • platform/qt/fast/dom/HTMLMeterElement/meter-element-expected.png: Added.
  • platform/qt/fast/dom/HTMLMeterElement/meter-element-expected.txt: Added.
  • platform/win/Skipped:
9:36 AM Changeset in webkit [59540] by eric@webkit.org
  • 10 edits
    3 copies
    5 adds in trunk

2010-05-15 Eric Uhrhane <​ericu@chromium.org>

Reviewed by Dmitry Titov.

Add bindings for async DB API in Workers.
​https://bugs.webkit.org/show_bug.cgi?id=34992

  • storage/change-version-handle-reuse.html: Refactored to share code with the worker version of the test.
  • storage/change-version-handle-reuse-expected.html: Removed reference to reloading, which this test doesn't do.
  • storage/change-version-handle-reuse.js: This is the extracted shared core of the test.
  • storage/execute-sql-args.html: Refactored to share code with the worker version of the test.
  • storage/execute-sql-args.js: This is the extracted shared core of the test.

These are the worker versions of the tests; they're tiny shims around shared code.

  • fast/workers/storage/execute-sql-args-worker-expected.txt: Added.
  • fast/workers/storage/execute-sql-args-worker.html: Added.
  • fast/workers/storage/change-version-handle-reuse-worker-expected.txt: Added.
  • fast/workers/storage/change-version-handle-reuse-worker.html: Added. This file gets included from worker database tests; it does all the boilerplate that's needed on the DOM side.
  • fast/workers/storage/resources/database-worker-controller.js: Added. This file is the boilerplate for the worker side of the database tests. It will import and run the actual test on command, and will report back completion and exceptions.
  • fast/workers/storage/resources/database-worker.js: Added.

2010-05-15 Eric Uhrhane <​ericu@chromium.org>

Reviewed by Dmitry Titov.

Add bindings for async DB API in Workers.
​https://bugs.webkit.org/show_bug.cgi?id=34992

Tests: storage/change-version-handle-reuse-worker.html

storage/execute-sql-args-worker.html

  • bindings/js/JSWorkerContextCustom.cpp: Add openDatabase binding. (WebCore::JSWorkerContext::openDatabase):
  • bindings/v8/custom/V8WorkerContextCustom.cpp: Add openDatabase stub; Chromium will need work both in V8 and in the browser process before we can turn this on there. (WebCore::V8WorkerContext::openDatabaseCallback):

Add NoStaticTables flags to all objects now shared with workers.

  • storage/Database.idl:
  • storage/SQLError.idl:
  • storage/SQLResultSet.idl:
  • storage/SQLResultSetRowList.idl:
  • storage/SQLTransaction.idl:
  • workers/WorkerContext.h: Add databaseExceededQuota.
  • workers/WorkerContext.cpp: (WebCore::WorkerContext::databaseExceededQuota): Add stub implementation for testing; you just get 5MB for now. (WebCore::WorkerContext::openDatabase): Remove invalid assertion.

Add the IDL for the call to openDatabase.

  • workers/WorkerContext.idl:
7:00 AM Changeset in webkit [59539] by eric@webkit.org
  • 3 edits in trunk/WebKit/qt

2010-05-15 Charles Wei <​charles.wei@torchmobile.com.cn>

Reviewed by Simon Hausmann.

This patch fixes the build failure of WebKit on Linux for Qt4.5
​https://bugs.webkig.org/show_bug.cgi?id=39108

  • Api/qgraphicswebview.cpp: (QGraphicsWebViewPrivate::syncLayers):
  • WebCoreSupport/QtPlatformPlugin.cpp:
6:49 AM Changeset in webkit [59538] by eric@webkit.org
  • 1 edit
    1 add in trunk/WebKitTools

2010-05-15 Eric Seidel <​eric@webkit.org>

Reviewed by Maciej Stachowiak.

Add script to check for minimum python version and install if missing on Tiger
​https://bugs.webkit.org/show_bug.cgi?id=38886

Per Maciej's request on webkit-dev:
​https://lists.webkit.org/pipermail/webkit-dev/2010-May/012785.html
provide a script which can automatically install Python on Tiger where
the system provided version is too old to be of use.

Note this uses the official Mac Python installer from python.org.
This installs a copy of Python in /Library/Frameworks/Python.framework.
It also makes symlinks from /usr/local/bin to the Python.framework/bin.

I have tested this script on Leopard and it worked fine. I have not
tested it on Tiger as I do not have access to a Tiger machine. In
either case this should provide a great starting point for someone
wishing to upgrade their copy of Python on Tiger.

Future patches can make our scripts depend on a success return from this
script and then they can either skip tests/sections for which python is
insufficient, or they can fail themselves.

  • Scripts/ensure-valid-python: Added.
6:37 AM Changeset in webkit [59537] by eric@webkit.org
  • 6 edits
    36 adds in trunk

2010-05-15 Leandro Pereira <​leandro@profusion.mobi>

Reviewed by Adam Treat.

[EFL] Add build system for the EFL port.
​http://webkit.org/b/37945

  • CMakeLists.txt: Added.
  • cmake/FindCFLite.cmake: Added.
  • cmake/FindCairo.cmake: Added.
  • cmake/FindEFL.cmake: Added.
  • cmake/FindFreetype.cmake: Added.
  • cmake/FindGDK-PixBuf.cmake: Added.
  • cmake/FindGDK.cmake: Added.
  • cmake/FindGIO.cmake: Added.
  • cmake/FindGlib.cmake: Added.
  • cmake/FindICU.cmake: Added.
  • cmake/FindLibSoup2.cmake: Added.
  • cmake/FindLibXlst.cmake: Added.
  • cmake/FindPango.cmake: Added.
  • cmake/FindSqlite.cmake: Added.
  • cmake/LibFindMacros.cmake: Added.
  • cmake/OptionsCommon.cmake: Added.
  • cmake/OptionsEfl.cmake: Added.
  • cmake/WebKitEfl.cmake: Added.
  • cmake/WebKitFS.cmake: Added.
  • cmake/WebKitFeatures.cmake: Added.
  • cmake/WebKitGenerators.cmake: Added.
  • cmake/WebKitHelpers.cmake: Added.
  • cmake/WebKitMacros.cmake: Added.
  • cmakeconfig.h.cmake: Added.

2010-05-15 Leandro Pereira <​leandro@profusion.mobi>

Reviewed by Adam Treat.

[EFL] Add build system for the EFL port.
​http://webkit.org/b/37945

  • CMakeLists.txt: Added.
  • CMakeListsEfl.txt: Added.
  • config.h: Add conditional to look for cmakeconfig.h.
  • jsc/CMakeLists.txt: Added.
  • jsc/CMakeListsEfl.txt: Added.
  • wtf/CMakeLists.txt: Added.
  • wtf/CMakeListsEfl.txt: Added.

2010-05-15 Leandro Pereira <​leandro@profusion.mobi>

Reviewed by Adam Treat.

[EFL] Add build system for the EFL port.
​http://webkit.org/b/37945

  • CMakeLists.txt: Added.
  • CMakeListsEfl.txt: Added.
  • config.h: Add conditional to look for cmakeconfig.h.

2010-05-15 Leandro Pereira <​leandro@profusion.mobi>

Reviewed by Adam Treat.

[EFL] Add build system for the EFL port.
​http://webkit.org/b/37945

  • CMakeLists.txt: Added.
  • CMakeListsEfl.txt: Added.
6:14 AM Changeset in webkit [59536] by eric@webkit.org
  • 4 edits in trunk/WebCore

2010-05-15 Adam Barth <​abarth@webkit.org>

Reviewed by Darin Adler.

Clipboard.setData doesn't need to be custom
​https://bugs.webkit.org/show_bug.cgi?id=39133

The implementation of the custom binding for this function was a bit
different than its declaration in the IDL file. I've updated the IDL
to match the implementation, but we probably should check whether our
behavior is correct with respect to the specification.

No tests because I've maintained our current behavior.

  • bindings/js/JSClipboardCustom.cpp:
  • bindings/v8/custom/V8ClipboardCustom.cpp:
  • dom/Clipboard.idl:
5:09 AM Changeset in webkit [59535] by xan@webkit.org
  • 2 edits in trunk/LayoutTests

2010-05-15 Xan Lopez <​xlopez@igalia.com>

Skip failing test, it depends on one patch still in the commit
queue.

  • platform/gtk/Skipped:
3:42 AM Changeset in webkit [59534] by eric@webkit.org
  • 9 edits
    2 copies
    1 add in trunk/WebKitTools

2010-05-15 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Display queue position inside EWS bubbles
​https://bugs.webkit.org/show_bug.cgi?id=38979

This ended up being a lot of clean-up to our status server code.

Added a new WorkItems model, a form with which to fill it,
and taught the Attachment class how to calculate the current queue
postion for an attachment using the data in WorkItems.

I also finally made statusbubble.* and dashboard.* not use copy-paste code.

The Attachment class has this summary() method which is very
controller/view-like and does not belong in a model class.
This patch got rid of all direct uses of summary().

  • QueueStatusServer/handlers/dashboard.py:
    • Build row objects to hand off to the view instead of handing off a summary object and expecting the view to process it directly.
  • QueueStatusServer/handlers/statusbubble.py:
    • Build bubble object and hand them off to the view.
  • QueueStatusServer/handlers/updatestatus.py:
    • Code cleanup. Just move some code into _queue_status_from_request to make the main put() handler easier to read.
  • QueueStatusServer/handlers/updateworkitems.py: Added.
    • Controller to handle storing WorkItems model objects.
  • QueueStatusServer/main.py:
    • Add route for /update-work-items
  • QueueStatusServer/model/attachment.py:
    • Add new methods to replace direct summary() access.
    • Teach attachment how to calculate queue positions from WorkItems data.
  • QueueStatusServer/model/queues.py:
    • Move name_with_underscores here for easier re-use.
  • QueueStatusServer/model/workitems.py: Added.
    • New model for storing what items are currently queue for any bot.
  • QueueStatusServer/templates/dashboard.html:
    • Kill the copy/paste code!
  • QueueStatusServer/templates/statusbubble.html:
    • Kill the copy/paste code!
  • QueueStatusServer/templates/updateworkitems.html: Added.
    • Simple form for updating a queue's current work items.
3:14 AM Changeset in webkit [59533] by eric@webkit.org
  • 7 edits in trunk/WebCore

2010-05-15 Yaar Schnitman <​yaar@chromium.org>

Reviewed by Adam Barth.

V8 overload support ported to JSC. Unforking of overloaded declarations in WebGL & Canvas will be done in subsequent patches.
​https://bugs.webkit.org/show_bug.cgi?id=38920

Note that JSTestCallback.cpp/h include minor irrelevant changes too since somebody forgot to update them after changing the JS generator.

  • bindings/scripts/CodeGenerator.pm:
  • bindings/scripts/CodeGeneratorJS.pm:
  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/scripts/test/JS/JSTestCallback.cpp: (WebCore::JSTestCallback::JSTestCallback): (WebCore::JSTestCallback::~JSTestCallback):
  • bindings/scripts/test/JS/JSTestCallback.h:
  • bindings/scripts/test/JS/JSTestObj.cpp: (WebCore::): (WebCore::jsTestObjPrototypeFunctionOverloadedMethod1): (WebCore::jsTestObjPrototypeFunctionOverloadedMethod2): (WebCore::jsTestObjPrototypeFunctionOverloadedMethod3): (WebCore::jsTestObjPrototypeFunctionOverloadedMethod4): (WebCore::testObjPrototypeFunctionOverloadedMethod):
  • bindings/scripts/test/JS/JSTestObj.h:
  • bindings/scripts/test/TestObj.idl:
2:55 AM Changeset in webkit [59532] by eric@webkit.org
  • 5 edits
    2 adds in trunk

2010-05-15 Joanmarie Diggs <​joanmarie.diggs@gmail.com>

Reviewed by Xan Lopez.

​https://bugs.webkit.org/show_bug.cgi?id=30500
[Gtk] Find a way for WebKit to "announce" itself so that ATs can readily distinguish it from true Gtk/Gail

The "announcement" is now made in the form of an object attribute
associated with the AtkObject.

  • platform/gtk/accessibility/object-attributes.html: Added.
  • platform/gtk/accessibility/object-attributes-expected.txt: Added.

2010-05-15 Joanmarie Diggs <​joanmarie.diggs@gmail.com>

Reviewed by Xan Lopez.

​https://bugs.webkit.org/show_bug.cgi?id=30500
[Gtk] Find a way for WebKit to "announce" itself so that ATs can readily distinguish it from true Gtk/Gail

The "announcement" is now made in the form of an object attribute
associated with the AtkObject.

  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (webkit_accessible_get_attributes):

2010-05-15 Joanmarie Diggs <​joanmarie.diggs@gmail.com>

Reviewed by Xan Lopez.

​https://bugs.webkit.org/show_bug.cgi?id=30500
[Gtk] Find a way for WebKit to "announce" itself so that ATs can readily distinguish it from true Gtk/Gail

The "announcement" is now made in the form of an object attribute
associated with the AtkObject.

  • DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: (AccessibilityUIElement::allAttributes): (attributeSetToString):
2:44 AM Changeset in webkit [59531] by eric@webkit.org
  • 4 edits in trunk

2010-05-15 Mario Sanchez Prada <​msanchez@igalia.com>

Reviewed by Xan Lopez.

Accessibility: Implement isSelected in DRT for GTK
​https://bugs.webkit.org/show_bug.cgi?id=31018

Do not skip aria-controls-with-tabs.html anymore

  • platform/gtk/Skipped:

2010-05-15 Mario Sanchez Prada <​msanchez@igalia.com>

Reviewed by Xan Lopez.

Accessibility: Implement isSelected in DRT for GTK
​https://bugs.webkit.org/show_bug.cgi?id=31018

Implement AccessibilityUIElement::isSelected() for Gtk

  • DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: (AccessibilityUIElement::isSelected):
2:33 AM Changeset in webkit [59530] by eric@webkit.org
  • 4 edits in trunk/LayoutTests

2010-05-15 Yael Aharon <​yael.aharon@nokia.com>

Reviewed by Darin Adler.

Update notifications test results
​https://bugs.webkit.org/show_bug.cgi?id=39126
Add missing line endings.

  • fast/notifications/notifications-replace-expected.txt:
  • fast/notifications/notifications-request-permission-expected.txt:
  • fast/notifications/notifications-rtl-expected.txt:
2:21 AM Changeset in webkit [59529] by eric@webkit.org
  • 3 edits in trunk/WebKit/chromium

2010-05-15 Evan Stade <​estade@chromium.org>

Reviewed by Adam Barth.

[chromium] "Check spelling in this field" context menu item always checked
​https://bugs.webkit.org/show_bug.cgi?id=39018

Initialize all POD members of WebContextMenuData in a default
constructor.

No tests because this code would need some major refactoring to unit
test, and AFAICT it's not testable via layout tests. See note at top
of getCustomMenuFromDefaultItems.

  • public/WebContextMenuData.h: (WebKit::WebContextMenuData::WebContextMenuData):
  • src/ContextMenuClientImpl.cpp: (WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems):
2:10 AM Changeset in webkit [59528] by eric@webkit.org
  • 6 edits in trunk

2010-05-15 Adam Barth <​abarth@webkit.org>

Reviewed by Darin Adler.

Show a console message when X-Frame-Options blocks a load
​https://bugs.webkit.org/show_bug.cgi?id=39087

Update expected results to show the console message.

  • http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-expected.txt:
  • http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body-expected.txt:
  • http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny-expected.txt:

2010-05-15 Adam Barth <​abarth@webkit.org>

Reviewed by Darin Adler.

Show a console message when X-Frame-Options blocks a load
​https://bugs.webkit.org/show_bug.cgi?id=39087

The blank page confuses people when X-Frame-Options blocks a load. The
console message should at least give them a hint as to what's going on.

  • dom/Document.cpp: (WebCore::Document::processHttpEquiv):
1:58 AM Changeset in webkit [59527] by eric@webkit.org
  • 4 edits in trunk/JavaScriptCore

2010-05-15 Chao-ying Fu <​fu@mips.com>

Reviewed by Oliver Hunt.

Update MIPS JIT for unsigned right shift, Math.sqrt, load16
​https://bugs.webkit.org/show_bug.cgi?id=38412

Fixed MIPS build failure.

  • assembler/MIPSAssembler.h: (JSC::MIPSAssembler::srl): (JSC::MIPSAssembler::srlv): (JSC::MIPSAssembler::sqrtd):
  • assembler/MacroAssemblerMIPS.h: (JSC::MacroAssemblerMIPS::urshift32): (JSC::MacroAssemblerMIPS::sqrtDouble): (JSC::MacroAssemblerMIPS::load16): (JSC::MacroAssemblerMIPS::supportsFloatingPointSqrt):
  • jit/JSInterfaceJIT.h:
1:46 AM Changeset in webkit [59526] by eric@webkit.org
  • 11 edits
    1 copy in trunk

2010-05-15 Ilya Tikhonovsky <​loislo@chromium.org>

Reviewed by Geoffrey Garen.

WebInspector: JSC Should provide heap size info for Timeline panel.
​https://bugs.webkit.org/show_bug.cgi?id=38420

  • JavaScriptCore.exp:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
  • runtime/Collector.cpp: (JSC::Heap::size):
  • runtime/Collector.h:

2010-05-15 Ilya Tikhonovsky <​loislo@chromium.org>

Reviewed by Geoffrey Garen.

WebInspector: JSC Should provide heap size info for Timeline panel.
​https://bugs.webkit.org/show_bug.cgi?id=38420

  • GNUmakefile.am:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/ScriptGCEvent.cpp: Added. (WebCore::ScriptGCEvent::getHeapSize):
  • bindings/js/ScriptGCEvent.h:
1:25 AM Changeset in webkit [59525] by eric@webkit.org
  • 6 edits in trunk

2010-05-15 Dave Tapuska <​dtapuska@rim.com>

Reviewed by Darin Adler.

Add a new define for we need strict arena alignment. ARMv5 with
double word instructions set this value.

  • wtf/Platform.h:

2010-05-15 Dave Tapuska <​dtapuska@rim.com>

Reviewed by Darin Adler.

Fix alignment faults on ARMv5TE architectures.

In debug mode the RenderAreaDebugHeader was 12 bytes which
caused an alignment failure for RenderObjects because they
would start on a 4 byte boundary. Align the RenderArenaDebugHeader
using the ARENA_ALIGN macro.

In NDEBUG mode the RenderArena objects come from a pool which
has 4 byte alignment. Allow the alignment to be based on the
AllocAlignmentInteger. This define will be activated for ARMv5TE.

​https://bugs.webkit.org/show_bug.cgi?id=19946

May 14, 2010:

11:50 PM Changeset in webkit [59524] by darin@chromium.org
  • 18 edits in trunk/WebKit/chromium

2010-05-14 Darin Fisher <​darin@chromium.org>

Reviewed by Dimitri Glazkov.

[chromium] Remove temporary relative include paths
​https://bugs.webkit.org/show_bug.cgi?id=38776

  • public/WebPasswordAutocompleteListener.h:
  • src/FrameLoaderClientImpl.h:
  • src/PlatformMessagePortChannel.h:
  • src/WebAnimationControllerImpl.h:
  • src/WebBindings.cpp:
  • src/WebDataSourceImpl.h:
  • src/WebDevToolsAgentPrivate.h:
  • src/WebFileChooserCompletionImpl.h:
  • src/WebFrameImpl.h:
  • src/WebInputEventConversion.h:
  • src/WebPluginContainerImpl.h:
  • src/WebPluginLoadObserver.h:
  • src/WebPopupMenuImpl.h:
  • src/WebSettingsImpl.h:
  • src/WebViewImpl.h:
  • src/WebWorkerClientImpl.h:
  • src/WrappedResourceRequest.h:
  • src/WrappedResourceResponse.h:
11:32 PM Changeset in webkit [59523] by abarth@webkit.org
  • 4 edits in trunk/WebCore

2010-05-14 Adam Barth <​abarth@webkit.org>

Reviewed by Darin Adler.

XMLHttpRequest.overrideMimeType doesn't need to be custom
​https://bugs.webkit.org/show_bug.cgi?id=39127

I don't see any reason why this method should be custom. No tests
because no behavior change.

  • bindings/js/JSXMLHttpRequestCustom.cpp:
  • bindings/v8/custom/V8XMLHttpRequestCustom.cpp:
  • xml/XMLHttpRequest.idl:
11:28 PM Changeset in webkit [59522] by abarth@webkit.org
  • 2 edits in trunk/WebKitTools

2010-05-14 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

scm.py should use self.run instead of run_command
​https://bugs.webkit.org/show_bug.cgi?id=38957

We've wanted to do this for a while, but it's a prerequiste for running
SVN from the cwd instead of the checkout_root.

  • Scripts/webkitpy/common/checkout/scm.py:
11:27 PM Changeset in webkit [59521] by sfalken@apple.com
  • 5 edits in tags/Safari-533.9.3

Versioning.

11:11 PM Changeset in webkit [59520] by sfalken@apple.com
  • 2 edits in tags/Safari-533.9.3/WebCore

Merge r59515.

11:07 PM Changeset in webkit [59519] by sfalken@apple.com
  • 1 copy in tags/Safari-533.9.3

New tag.

11:05 PM Changeset in webkit [59518] by sfalken@apple.com
  • 2 edits in branches/safari-533-branch/WebCore

Merge r59515.

10:32 PM Changeset in webkit [59517] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

2010-05-14 Adam Barth <​abarth@webkit.org>

Unreviewed.

Skip new test that fails on Qt. I'm sure skipping is the wrong thing
but no one is around to help me figure out what the right thing to do
is and I don't want to leave the bot red all weekend.

  • platform/qt/Skipped:
9:46 PM Changeset in webkit [59516] by adele@apple.com
  • 3 edits
    2 adds in trunk

WebCore: Fix for ​https://bugs.webkit.org/show_bug.cgi?id=39095
<rdar://problem/7984158> REGRESSION (r53085): Infinite recursion in Position::getInlineBoxAndOffset when changing writing direction to right-to-left

Reviewed by Dave Hyatt.

Test: editing/selection/applystyle-to-inline-inside-block.html

  • dom/Position.cpp: (WebCore::Position::getInlineBoxAndOffset): Now that this function correctly goes in and out of editable areas by calling

downstreamIgnoringEditingBoundaries and upstreamIgnoringEditingBoundaries for blocks (added in r58665), we no longer need a special case to
jump out to the parent when we hit an inline (which was added in r53085 when this issue was introduced).

LayoutTests: Test for ​https://bugs.webkit.org/show_bug.cgi?id=39095
<rdar://problem/7984158> REGRESSION (r53085): Infinite recursion in Position::getInlineBoxAndOffset when changing writing direction to right-to-left

Reviewed by Dave Hyatt.

  • editing/selection/applystyle-to-inline-in-block-expected.txt: Added.
  • editing/selection/applystyle-to-inline-in-block.html: Added.
8:49 PM Changeset in webkit [59515] by bweinstein@apple.com
  • 2 edits in trunk/WebCore

Hopefully a last fix for the build. Call -mkdir instead of mkdir, so we don't bail if the mkdir call fails. Additionally,
use the %Env% syntax instead of $(Env), which is what we need if we are referring to Windows environment variables instead
of nmake variables.

Reviewed by Mark Rowe.

  • WebCore.vcproj/WebCore.make:
8:40 PM Changeset in webkit [59514] by Stephanie Lewis
  • 6 edits in trunk

Update order files.

Rubber-stamped by Mark Rowe.

JavaScriptCore:

WebCore:

  • WebCore.order:

WebKit/mac:

  • WebKit.order:
8:17 PM Changeset in webkit [59513] by hyatt@apple.com
  • 16 edits
    2 adds in trunk

​https://bugs.webkit.org/show_bug.cgi?id=39137

Reviewed by Simon Fraser.

WebCore:

Make RenderLayers position properly inside multicolumn layout.

(1) Create RenderLayers when column properties are specified. This allows descendant layers to easily
know they are inside a multicolumn layout when positioning.

(2) Patch updateLayerPosition to offset the layer into the first column that contains the layer. Splitting
of a layer across columns still does not work, but the layer will now at least appear in the first column in
which it occurs.

(3) Fix pagination bugs caused by the fact that visual overflow doesn't propagate up the line box tree when layers
are involved. Make sure to use lineTop and lineBottom in this case (it's not perfect, but it gets most cases
working properly). With this change elements like <video> will paginate properly and not get split across pages.

(4) Make column repainting and layer positioning work with RTL columns by fixing adjustForColumns to
account for RTL.

(5) Fix RTL pagination by making sure the column pagination rects are the content width of the whole block and not just
the width of one column.

Added fast/multicol/layers-in-multicol.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::layoutColumns):
(WebCore::RenderBlock::adjustForColumns):

  • rendering/RenderBox.h:

(WebCore::RenderBox::locationOffset):

  • rendering/RenderBoxModelObject.h:

(WebCore::RenderBoxModelObject::requiresLayer):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::updateLayerPosition):
(WebCore::RenderLayer::convertToLayerCoords):
(WebCore::RenderLayer::shouldBeNormalFlowOnly):

  • rendering/RenderLineBoxList.cpp:

(WebCore::RenderLineBoxList::paint):

  • rendering/RenderView.cpp:

(WebCore::RenderView::RenderView):

  • rendering/RenderView.h:

(WebCore::RenderView::requiresLayer):

  • rendering/style/RenderStyle.h:

(WebCore::InheritedFlags::specifiesColumns):

LayoutTests:

Reset all multicolumn test results now that columns create RenderLayers.

  • fast/multicol/client-rects-expected.txt:
  • fast/multicol/layers-in-multicol.html: Added.
  • fast/multicol/single-line-expected.txt:
  • platform/mac/fast/multicol/column-rules-expected.txt:
  • platform/mac/fast/multicol/columns-shorthand-parsing-expected.txt:
  • platform/mac/fast/multicol/float-avoidance-expected.txt:
  • platform/mac/fast/multicol/float-multicol-expected.txt:


Add a layout test for various types of RenderLayers inside multicol layouts.

  • platform/mac/fast/multicol/layers-in-multicol-expected.txt: Added.
7:54 PM Changeset in webkit [59512] by eric@webkit.org
  • 5 edits in trunk

2010-05-14 Anton Muhin <​antonm@chromium.org>

Reviewed by Darin Fisher.

[Chromium] Consider implementing addOriginAccessWhitelistEntry method
​https://bugs.webkit.org/show_bug.cgi?id=37578

Remove deprecated methods.

  • public/WebSecurityPolicy.h:
  • src/WebSecurityPolicy.cpp:

2010-05-14 Anton Muhin <​antonm@chromium.org>

Reviewed by Darin Fisher.

[Chromium] Consider implementing addOriginAccessWhitelistEntry method
​https://bugs.webkit.org/show_bug.cgi?id=37578

Remove deprecated methods.

  • DumpRenderTree/chromium/LayoutTestController.cpp
  • DumpRenderTree/chromium/LayoutTestController.h
6:57 PM Changeset in webkit [59511] by eric@webkit.org
  • 4 edits in trunk/WebCore

2010-05-14 Leon Clarke <​leonclarke@google.com>

Reviewed by Steve Block.

Refactor signature of tokenizeRelAttribute and the variables it refers to so that new features don't keep changing the signature, and make m_disabledState into an enum.
​https://bugs.webkit.org/show_bug.cgi?id=38900

No new tests. Refactoring only.

  • html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::HTMLLinkElement): (WebCore::HTMLLinkElement::setDisabledState): (WebCore::HTMLLinkElement::parseMappedAttribute): (WebCore::HTMLLinkElement::tokenizeRelAttribute): (WebCore::HTMLLinkElement::process): (WebCore::HTMLLinkElement::addSubresourceAttributeURLs):
  • html/HTMLLinkElement.h: (WebCore::HTMLLinkElement::RelAttribute::RelAttribute): (WebCore::HTMLLinkElement::isAlternate): (WebCore::HTMLLinkElement::isDisabled): (WebCore::HTMLLinkElement::isEnabledViaScript): (WebCore::HTMLLinkElement::isIcon): (WebCore::HTMLLinkElement::):
  • html/PreloadScanner.cpp: (WebCore::PreloadScanner::processAttribute):
6:43 PM Changeset in webkit [59510] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-05-14 Noam Rosenthal <​noam.rosenthal@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] GraphicsLayer caches directly composited images
​https://bugs.webkit.org/show_bug.cgi?id=38444

Directly-composited images and solid fills shouldn't be cached, as that cache
is never used (see GraphicsLayerQtImpl::paint). Cache is only relevant for HTML content,
but we were missing that test.
The fix makes sure we only cache HTML content.

No new tests: this is a minor optimization.

  • platform/graphics/qt/GraphicsLayerQt.cpp: (WebCore::GraphicsLayerQtImpl::flushChanges):
6:18 PM Changeset in webkit [59509] by mrowe@apple.com
  • 5 edits in tags/Safari-533.9.2

Versioning.

6:08 PM Changeset in webkit [59508] by mrowe@apple.com
  • 2 edits in tags/Safari-533.9.2/WebCore

Merge r59505.

5:56 PM Changeset in webkit [59507] by mrowe@apple.com
  • 1 copy in tags/Safari-533.9.2

New tag.

5:55 PM Changeset in webkit [59506] by mrowe@apple.com
  • 2 edits in branches/safari-533-branch/WebCore

Merge r59505.

5:45 PM Changeset in webkit [59505] by bweinstein@apple.com
  • 2 edits in trunk/WebCore

Build fix. Had the environment variables wrong for source and destination of the copy operation
that was added.

Reviewed by Mark Rowe.

  • WebCore.vcproj/WebCore.make:
5:29 PM Changeset in webkit [59504] by ap@apple.com
  • 2 edits
    4 moves in trunk/LayoutTests

Inspired by Simon Fraser, rubber-stamped by Geoff Garen.

Disabled Sputnik tests that take over 10 seconds in debug builds on my MacBook Pro.

  • platform/mac-tiger/Skipped: These tests were alrady skipped on Tiger, no need to skip explicitly any more.
  • fast/js/sputnik/Conformance/15_Native_Objects/15.1_The_Global_Object/15.1.3/15.1.3.1_decodeURI/S15.1.3.1_A2.5_T1.html: Removed.
  • fast/js/sputnik/Conformance/15_Native_Objects/15.1_The_Global_Object/15.1.3/15.1.3.1_decodeURI/S15.1.3.1_A2.5_T1.html-disabled: Copied from fast/js/sputnik/Conformance/15_Native_Objects/15.1_The_Global_Object/15.1.3/15.1.3.1_decodeURI/S15.1.3.1_A2.5_T1.html.
  • fast/js/sputnik/Conformance/15_Native_Objects/15.1_The_Global_Object/15.1.3/15.1.3.2_decodeURIComponent/S15.1.3.2_A2.5_T1.html: Removed.
  • fast/js/sputnik/Conformance/15_Native_Objects/15.1_The_Global_Object/15.1.3/15.1.3.2_decodeURIComponent/S15.1.3.2_A2.5_T1.html-disabled: Copied from fast/js/sputnik/Conformance/15_Native_Objects/15.1_The_Global_Object/15.1.3/15.1.3.2_decodeURIComponent/S15.1.3.2_A2.5_T1.html.
  • fast/js/sputnik/Unicode/Unicode_218/S7.6_A3.1.html: Removed.
  • fast/js/sputnik/Unicode/Unicode_218/S7.6_A3.1.html-disabled: Copied from fast/js/sputnik/Unicode/Unicode_218/S7.6_A3.1.html.
  • fast/js/sputnik/Unicode/Unicode_218/S7.6_A3.2.html: Removed.
  • fast/js/sputnik/Unicode/Unicode_218/S7.6_A3.2.html-disabled: Copied from fast/js/sputnik/Unicode/Unicode_218/S7.6_A3.2.html.
5:08 PM Changeset in webkit [59503] by eric@webkit.org
  • 9 edits in trunk/JavaScriptCore

2010-05-14 Jedrzej Nowacki <​jedrzej.nowacki@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

Implementation of QtScript API that provide method to convert a value to an object.

[Qt] QtScript is missing toObject API
​https://bugs.webkit.org/show_bug.cgi?id=36594

  • qt/api/qscriptengine.cpp: (QScriptEngine::toObject):
  • qt/api/qscriptengine.h:
  • qt/api/qscriptvalue.cpp: (QScriptValue::toObject):
  • qt/api/qscriptvalue.h:
  • qt/api/qscriptvalue_p.h: (QScriptValuePrivate::toObject):
  • qt/tests/qscriptengine/tst_qscriptengine.cpp: (tst_QScriptEngine::toObject): (tst_QScriptEngine::toObjectTwoEngines):
  • qt/tests/qscriptvalue/tst_qscriptvalue.cpp: (tst_QScriptValue::toObjectSimple):
  • qt/tests/qscriptvalue/tst_qscriptvalue.h:
4:34 PM Changeset in webkit [59502] by abarth@webkit.org
  • 7 edits in trunk/WebCore

2010-05-14 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Remove custom bindings for HTMLInputElement
​https://bugs.webkit.org/show_bug.cgi?id=38344

Fix a bug in the TestObj.idl file and update expected results. This
was originally part of a larger change reviewed by Eric, but I'm
landing it separately to help me understand the more interesting bits
of the patch clearly.

  • bindings/scripts/test/GObject/WebKitDOMTestObj.cpp: (webkit_dom_test_obj_get_attr_with_setter_exception): (webkit_dom_test_obj_set_attr_with_setter_exception): (webkit_dom_test_obj_set_attr_with_getter_exception): (webkit_dom_test_obj_set_property): (webkit_dom_test_obj_get_property):
  • bindings/scripts/test/GObject/WebKitDOMTestObj.h:
  • bindings/scripts/test/JS/JSTestObj.cpp: (WebCore::jsTestObjAttrWithSetterException): (WebCore::setJSTestObjAttrWithSetterException): (WebCore::setJSTestObjAttrWithGetterException):
  • bindings/scripts/test/ObjC/DOMTestObj.mm: (-[DOMTestObj attrWithSetterException]): (-[DOMTestObj setAttrWithSetterException:]): (-[DOMTestObj setAttrWithGetterException:]):
  • bindings/scripts/test/TestObj.idl:
  • bindings/scripts/test/V8/V8TestObj.cpp: (WebCore::TestObjInternal::attrWithSetterExceptionAttrGetter): (WebCore::TestObjInternal::attrWithSetterExceptionAttrSetter): (WebCore::TestObjInternal::attrWithGetterExceptionAttrSetter):
4:12 PM Changeset in webkit [59501] by jparent@chromium.org
  • 2 edits in trunk/BugsSite

Bugzilla: Only show "Rietveld Review" link when in-rietveld is set to +.

Reviewed by Ojan Vafai.

​https://bugs.webkit.org/show_bug.cgi?id=39141

  • template/en/custom/attachment/list.html.tmpl:
3:54 PM Changeset in webkit [59500] by jparent@chromium.org
  • 2 edits in trunk/BugsSite

Bugzilla: Don't send mail if the only change is to the in-rietveld flag.

Reviewed by David Kilzer.

​https://bugs.webkit.org/show_bug.cgi?id=39090

  • Bugzilla/BugMail.pm:
3:52 PM EFLWebKit edited by leandro@profusion.mobi
(diff)
3:52 PM EFLWebKit edited by leandro@profusion.mobi
(diff)
3:50 PM EFLWebKit edited by leandro@profusion.mobi
(diff)
3:50 PM EFLWebKit edited by leandro@profusion.mobi
(diff)
3:37 PM Changeset in webkit [59499] by kbr@google.com
  • 30 edits
    64 moves in trunk

2010-05-14 Kenneth Russell <​kbr@google.com>

Reviewed by Darin Adler.

Rename WebGLArray types to TypedArray types
​https://bugs.webkit.org/show_bug.cgi?id=39091

Extended functionality of do-webcore-rename script and used it to
rename the WebGLArray types to the TypedArray naming convention.
The only source files which were touched by hand, and which are
being manually reviewed, are:

WebCore/page/DOMWindow.idl
WebCore/bindings/generic/RuntimeEnabledFeatures.h (script's changes undone)
WebKit/WebCore/bindings/js/JSDOMWindowCustom.cpp
WebKit/WebCore/bindings/v8/custom/V8DOMWindowCustom.cpp

These only needed to be touched to update the aliases between the
WebGLArray and TypedArray names introduced in bug 39036. (It was
not feasible to have do-webcore-rename handle this as it would
introduce circular renamings.) These aliases will be removed in
roughly a month once existing WebGL content has been updated.

No new tests; covered under existing WebGL tests. Updated
constructed-objects-prototypes and prototype-inheritance-2 tests.
Ran all layout tests in Safari and all WebGL tests in Chromium.

  • src/GraphicsContext3D.cpp: (WebCore::GraphicsContext3DInternal::bufferData): (WebCore::GraphicsContext3DInternal::bufferSubData):

2010-05-14 Kenneth Russell <​kbr@google.com>

Reviewed by Darin Adler.

Rename WebGLArray types to TypedArray types
​https://bugs.webkit.org/show_bug.cgi?id=39091

Extended functionality of do-webcore-rename script and used it to
rename the WebGLArray types to the TypedArray naming convention.
The only source files which were touched by hand, and which are
being manually reviewed, are:

WebCore/page/DOMWindow.idl
WebCore/bindings/generic/RuntimeEnabledFeatures.h (script's changes undone)
WebKit/WebCore/bindings/js/JSDOMWindowCustom.cpp
WebKit/WebCore/bindings/v8/custom/V8DOMWindowCustom.cpp

These only needed to be touched to update the aliases between the
WebGLArray and TypedArray names introduced in bug 39036. (It was
not feasible to have do-webcore-rename handle this as it would
introduce circular renamings.) These aliases will be removed in
roughly a month once existing WebGL content has been updated.

No new tests; covered under existing WebGL tests. Updated
constructed-objects-prototypes and prototype-inheritance-2 tests.
Ran all layout tests in Safari and all WebGL tests in Chromium.

  • DerivedSources.make:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pri:
  • WebCore.pro:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSArrayBufferConstructor.cpp: Copied from WebCore/bindings/js/JSWebGLArrayBufferConstructor.cpp. (WebCore::): (WebCore::JSArrayBufferConstructor::JSArrayBufferConstructor): (WebCore::constructCanvasArrayBuffer): (WebCore::JSArrayBufferConstructor::getConstructData):
  • bindings/js/JSArrayBufferConstructor.h: Copied from WebCore/bindings/js/JSWebGLArrayBufferConstructor.h. (WebCore::construct):
  • bindings/js/JSArrayBufferViewCustom.cpp: Copied from WebCore/bindings/js/JSWebGLArrayCustom.cpp. (WebCore::toJS): (WebCore::JSArrayBufferView::slice):
  • bindings/js/JSArrayBufferViewHelper.h: Copied from WebCore/bindings/js/JSWebGLArrayHelper.h.
  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::arrayBuffer): (WebCore::JSDOMWindow::int8Array): (WebCore::JSDOMWindow::uint8Array): (WebCore::JSDOMWindow::int32Array): (WebCore::JSDOMWindow::uint32Array): (WebCore::JSDOMWindow::int16Array): (WebCore::JSDOMWindow::uint16Array): (WebCore::JSDOMWindow::floatArray): (WebCore::JSDOMWindow::webGLArrayBuffer): (WebCore::JSDOMWindow::webGLByteArray): (WebCore::JSDOMWindow::webGLUnsignedByteArray): (WebCore::JSDOMWindow::webGLIntArray): (WebCore::JSDOMWindow::webGLUnsignedIntArray): (WebCore::JSDOMWindow::webGLShortArray): (WebCore::JSDOMWindow::webGLUnsignedShortArray): (WebCore::JSDOMWindow::webGLFloatArray):
  • bindings/js/JSFloatArrayConstructor.cpp: Copied from WebCore/bindings/js/JSWebGLFloatArrayConstructor.cpp. (WebCore::): (WebCore::JSFloatArrayConstructor::JSFloatArrayConstructor): (WebCore::constructCanvasFloatArray): (WebCore::JSFloatArrayConstructor::getConstructData):
  • bindings/js/JSFloatArrayConstructor.h: Copied from WebCore/bindings/js/JSWebGLFloatArrayConstructor.h.
  • bindings/js/JSFloatArrayCustom.cpp: Copied from WebCore/bindings/js/JSWebGLFloatArrayCustom.cpp. (WebCore::JSFloatArray::indexSetter): (WebCore::toJS): (WebCore::JSFloatArray::set):
  • bindings/js/JSInt16ArrayConstructor.cpp: Copied from WebCore/bindings/js/JSWebGLShortArrayConstructor.cpp. (WebCore::): (WebCore::JSInt16ArrayConstructor::JSInt16ArrayConstructor): (WebCore::constructCanvasShortArray): (WebCore::JSInt16ArrayConstructor::getConstructData):
  • bindings/js/JSInt16ArrayConstructor.h: Copied from WebCore/bindings/js/JSWebGLShortArrayConstructor.h.
  • bindings/js/JSInt16ArrayCustom.cpp: Copied from WebCore/bindings/js/JSWebGLShortArrayCustom.cpp. (WebCore::JSInt16Array::indexSetter): (WebCore::toJS): (WebCore::JSInt16Array::set):
  • bindings/js/JSInt32ArrayConstructor.cpp: Copied from WebCore/bindings/js/JSWebGLIntArrayConstructor.cpp. (WebCore::): (WebCore::JSInt32ArrayConstructor::JSInt32ArrayConstructor): (WebCore::constructCanvasIntArray): (WebCore::JSInt32ArrayConstructor::getConstructData):
  • bindings/js/JSInt32ArrayConstructor.h: Copied from WebCore/bindings/js/JSWebGLIntArrayConstructor.h.
  • bindings/js/JSInt32ArrayCustom.cpp: Copied from WebCore/bindings/js/JSWebGLIntArrayCustom.cpp. (WebCore::JSInt32Array::indexSetter): (WebCore::toJS): (WebCore::JSInt32Array::set):
  • bindings/js/JSInt8ArrayConstructor.cpp: Copied from WebCore/bindings/js/JSWebGLByteArrayConstructor.cpp. (WebCore::): (WebCore::JSInt8ArrayConstructor::JSInt8ArrayConstructor): (WebCore::constructCanvasByteArray): (WebCore::JSInt8ArrayConstructor::getConstructData):
  • bindings/js/JSInt8ArrayConstructor.h: Copied from WebCore/bindings/js/JSWebGLByteArrayConstructor.h.
  • bindings/js/JSInt8ArrayCustom.cpp: Copied from WebCore/bindings/js/JSWebGLByteArrayCustom.cpp. (WebCore::JSInt8Array::indexSetter): (WebCore::toJS): (WebCore::JSInt8Array::set):
  • bindings/js/JSUint16ArrayConstructor.cpp: Copied from WebCore/bindings/js/JSWebGLUnsignedShortArrayConstructor.cpp. (WebCore::): (WebCore::JSUint16ArrayConstructor::JSUint16ArrayConstructor): (WebCore::constructCanvasUnsignedShortArray): (WebCore::JSUint16ArrayConstructor::getConstructData):
  • bindings/js/JSUint16ArrayConstructor.h: Copied from WebCore/bindings/js/JSWebGLUnsignedShortArrayConstructor.h.
  • bindings/js/JSUint16ArrayCustom.cpp: Copied from WebCore/bindings/js/JSWebGLUnsignedShortArrayCustom.cpp. (WebCore::JSUint16Array::indexSetter): (WebCore::toJS): (WebCore::JSUint16Array::set):
  • bindings/js/JSUint32ArrayConstructor.cpp: Copied from WebCore/bindings/js/JSWebGLUnsignedIntArrayConstructor.cpp. (WebCore::): (WebCore::JSUint32ArrayConstructor::JSUint32ArrayConstructor): (WebCore::constructCanvasUnsignedIntArray): (WebCore::JSUint32ArrayConstructor::getConstructData):
  • bindings/js/JSUint32ArrayConstructor.h: Copied from WebCore/bindings/js/JSWebGLUnsignedIntArrayConstructor.h.
  • bindings/js/JSUint32ArrayCustom.cpp: Copied from WebCore/bindings/js/JSWebGLUnsignedIntArrayCustom.cpp. (WebCore::JSUint32Array::indexSetter): (WebCore::toJS): (WebCore::JSUint32Array::set):
  • bindings/js/JSUint8ArrayConstructor.cpp: Copied from WebCore/bindings/js/JSWebGLUnsignedByteArrayConstructor.cpp. (WebCore::): (WebCore::JSUint8ArrayConstructor::JSUint8ArrayConstructor): (WebCore::constructCanvasUnsignedByteArray): (WebCore::JSUint8ArrayConstructor::getConstructData):
  • bindings/js/JSUint8ArrayConstructor.h: Copied from WebCore/bindings/js/JSWebGLUnsignedByteArrayConstructor.h.
  • bindings/js/JSUint8ArrayCustom.cpp: Copied from WebCore/bindings/js/JSWebGLUnsignedByteArrayCustom.cpp. (WebCore::JSUint8Array::indexSetter): (WebCore::toJS): (WebCore::JSUint8Array::set):
  • bindings/js/JSWebGLArrayBufferConstructor.cpp: Removed.
  • bindings/js/JSWebGLArrayBufferConstructor.h: Removed.
  • bindings/js/JSWebGLArrayCustom.cpp: Removed.
  • bindings/js/JSWebGLArrayHelper.h: Removed.
  • bindings/js/JSWebGLByteArrayConstructor.cpp: Removed.
  • bindings/js/JSWebGLByteArrayConstructor.h: Removed.
  • bindings/js/JSWebGLByteArrayCustom.cpp: Removed.
  • bindings/js/JSWebGLFloatArrayConstructor.cpp: Removed.
  • bindings/js/JSWebGLFloatArrayConstructor.h: Removed.
  • bindings/js/JSWebGLFloatArrayCustom.cpp: Removed.
  • bindings/js/JSWebGLIntArrayConstructor.cpp: Removed.
  • bindings/js/JSWebGLIntArrayConstructor.h: Removed.
  • bindings/js/JSWebGLIntArrayCustom.cpp: Removed.
  • bindings/js/JSWebGLRenderingContextCustom.cpp: (WebCore::JSWebGLRenderingContext::bufferData): (WebCore::JSWebGLRenderingContext::bufferSubData): (WebCore::JSWebGLRenderingContext::texImage2D): (WebCore::JSWebGLRenderingContext::texSubImage2D): (WebCore::dataFunctionf): (WebCore::dataFunctioni): (WebCore::dataFunctionMatrix):
  • bindings/js/JSWebGLShortArrayConstructor.cpp: Removed.
  • bindings/js/JSWebGLShortArrayConstructor.h: Removed.
  • bindings/js/JSWebGLShortArrayCustom.cpp: Removed.
  • bindings/js/JSWebGLUnsignedByteArrayConstructor.cpp: Removed.
  • bindings/js/JSWebGLUnsignedByteArrayConstructor.h: Removed.
  • bindings/js/JSWebGLUnsignedByteArrayCustom.cpp: Removed.
  • bindings/js/JSWebGLUnsignedIntArrayConstructor.cpp: Removed.
  • bindings/js/JSWebGLUnsignedIntArrayConstructor.h: Removed.
  • bindings/js/JSWebGLUnsignedIntArrayCustom.cpp: Removed.
  • bindings/js/JSWebGLUnsignedShortArrayConstructor.cpp: Removed.
  • bindings/js/JSWebGLUnsignedShortArrayConstructor.h: Removed.
  • bindings/js/JSWebGLUnsignedShortArrayCustom.cpp: Removed.
  • bindings/v8/V8DOMWrapper.cpp:
  • bindings/v8/custom/V8ArrayBufferCustom.cpp: Copied from WebCore/bindings/v8/custom/V8WebGLArrayBufferCustom.cpp. (WebCore::V8ArrayBuffer::constructorCallback):
  • bindings/v8/custom/V8ArrayBufferViewCustom.cpp: Copied from WebCore/bindings/v8/custom/V8WebGLArrayCustom.cpp. (WebCore::toV8): (WebCore::V8ArrayBufferView::sliceCallback):
  • bindings/v8/custom/V8ArrayBufferViewCustom.h: Copied from WebCore/bindings/v8/custom/V8WebGLArrayCustom.h. (WebCore::constructWebGLArray):
  • bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::V8DOMWindow::WebGLArrayBufferAccessorGetter): (WebCore::V8DOMWindow::WebGLByteArrayAccessorGetter): (WebCore::V8DOMWindow::WebGLUnsignedByteArrayAccessorGetter): (WebCore::V8DOMWindow::WebGLShortArrayAccessorGetter): (WebCore::V8DOMWindow::WebGLUnsignedShortArrayAccessorGetter): (WebCore::V8DOMWindow::WebGLIntArrayAccessorGetter): (WebCore::V8DOMWindow::WebGLUnsignedIntArrayAccessorGetter): (WebCore::V8DOMWindow::WebGLFloatArrayAccessorGetter):
  • bindings/v8/custom/V8FloatArrayCustom.cpp: Copied from WebCore/bindings/v8/custom/V8WebGLFloatArrayCustom.cpp. (WebCore::V8FloatArray::constructorCallback): (WebCore::V8FloatArray::setCallback): (WebCore::toV8):
  • bindings/v8/custom/V8Int16ArrayCustom.cpp: Copied from WebCore/bindings/v8/custom/V8WebGLShortArrayCustom.cpp. (WebCore::V8Int16Array::constructorCallback): (WebCore::V8Int16Array::setCallback): (WebCore::toV8):
  • bindings/v8/custom/V8Int32ArrayCustom.cpp: Copied from WebCore/bindings/v8/custom/V8WebGLIntArrayCustom.cpp. (WebCore::V8Int32Array::constructorCallback): (WebCore::V8Int32Array::setCallback): (WebCore::toV8):
  • bindings/v8/custom/V8Int8ArrayCustom.cpp: Copied from WebCore/bindings/v8/custom/V8WebGLByteArrayCustom.cpp. (WebCore::V8Int8Array::constructorCallback): (WebCore::V8Int8Array::setCallback): (WebCore::toV8):
  • bindings/v8/custom/V8Uint16ArrayCustom.cpp: Copied from WebCore/bindings/v8/custom/V8WebGLUnsignedShortArrayCustom.cpp. (WebCore::V8Uint16Array::constructorCallback): (WebCore::V8Uint16Array::setCallback): (WebCore::toV8):
  • bindings/v8/custom/V8Uint32ArrayCustom.cpp: Copied from WebCore/bindings/v8/custom/V8WebGLUnsignedIntArrayCustom.cpp. (WebCore::V8Uint32Array::constructorCallback): (WebCore::V8Uint32Array::setCallback): (WebCore::toV8):
  • bindings/v8/custom/V8Uint8ArrayCustom.cpp: Copied from WebCore/bindings/v8/custom/V8WebGLUnsignedByteArrayCustom.cpp. (WebCore::V8Uint8Array::constructorCallback): (WebCore::V8Uint8Array::setCallback): (WebCore::toV8):
  • bindings/v8/custom/V8WebGLArrayBufferCustom.cpp: Removed.
  • bindings/v8/custom/V8WebGLArrayCustom.cpp: Removed.
  • bindings/v8/custom/V8WebGLArrayCustom.h: Removed.
  • bindings/v8/custom/V8WebGLByteArrayCustom.cpp: Removed.
  • bindings/v8/custom/V8WebGLFloatArrayCustom.cpp: Removed.
  • bindings/v8/custom/V8WebGLIntArrayCustom.cpp: Removed.
  • bindings/v8/custom/V8WebGLRenderingContextCustom.cpp: (WebCore::vertexAttribAndUniformHelperf): (WebCore::uniformHelperi): (WebCore::uniformMatrixHelper):
  • bindings/v8/custom/V8WebGLShortArrayCustom.cpp: Removed.
  • bindings/v8/custom/V8WebGLUnsignedByteArrayCustom.cpp: Removed.
  • bindings/v8/custom/V8WebGLUnsignedIntArrayCustom.cpp: Removed.
  • bindings/v8/custom/V8WebGLUnsignedShortArrayCustom.cpp: Removed.
  • html/canvas/ArrayBuffer.cpp: Copied from WebCore/html/canvas/WebGLArrayBuffer.cpp. (WebCore::ArrayBuffer::create): (WebCore::ArrayBuffer::ArrayBuffer): (WebCore::ArrayBuffer::data): (WebCore::ArrayBuffer::byteLength): (WebCore::ArrayBuffer::~ArrayBuffer): (WebCore::ArrayBuffer::tryAllocate):
  • html/canvas/ArrayBuffer.h: Copied from WebCore/html/canvas/WebGLArrayBuffer.h.
  • html/canvas/ArrayBuffer.idl: Copied from WebCore/html/canvas/WebGLArrayBuffer.idl.
  • html/canvas/ArrayBufferView.cpp: Copied from WebCore/html/canvas/WebGLArray.cpp. (WebCore::ArrayBufferView::ArrayBufferView): (WebCore::ArrayBufferView::~ArrayBufferView): (WebCore::ArrayBufferView::setImpl): (WebCore::ArrayBufferView::calculateOffsetAndLength):
  • html/canvas/ArrayBufferView.h: Copied from WebCore/html/canvas/WebGLArray.h. (WebCore::ArrayBufferView::buffer): (WebCore::ArrayBufferView::verifySubRange): (WebCore::ArrayBufferView::clampOffsetAndNumElements):
  • html/canvas/ArrayBufferView.idl: Copied from WebCore/html/canvas/WebGLArray.idl.
  • html/canvas/FloatArray.cpp: Copied from WebCore/html/canvas/WebGLFloatArray.cpp. (WebCore::FloatArray::create): (WebCore::FloatArray::FloatArray): (WebCore::FloatArray::slice):
  • html/canvas/FloatArray.h: Copied from WebCore/html/canvas/WebGLFloatArray.h. (WebCore::FloatArray::set): (WebCore::FloatArray::item):
  • html/canvas/FloatArray.idl: Copied from WebCore/html/canvas/WebGLFloatArray.idl.
  • html/canvas/Int16Array.cpp: Copied from WebCore/html/canvas/WebGLShortArray.cpp. (WebCore::Int16Array::create): (WebCore::Int16Array::Int16Array): (WebCore::Int16Array::slice):
  • html/canvas/Int16Array.h: Copied from WebCore/html/canvas/WebGLShortArray.h.
  • html/canvas/Int16Array.idl: Copied from WebCore/html/canvas/WebGLShortArray.idl.
  • html/canvas/Int32Array.cpp: Copied from WebCore/html/canvas/WebGLIntArray.cpp. (WebCore::Int32Array::create): (WebCore::Int32Array::Int32Array): (WebCore::Int32Array::slice):
  • html/canvas/Int32Array.h: Copied from WebCore/html/canvas/WebGLIntArray.h.
  • html/canvas/Int32Array.idl: Copied from WebCore/html/canvas/WebGLIntArray.idl.
  • html/canvas/Int8Array.cpp: Copied from WebCore/html/canvas/WebGLByteArray.cpp. (WebCore::Int8Array::create): (WebCore::Int8Array::Int8Array): (WebCore::Int8Array::slice):
  • html/canvas/Int8Array.h: Copied from WebCore/html/canvas/WebGLByteArray.h.
  • html/canvas/Int8Array.idl: Copied from WebCore/html/canvas/WebGLByteArray.idl.
  • html/canvas/IntegralTypedArrayBase.h: Copied from WebCore/html/canvas/WebGLIntegralTypedArrayBase.h. (WebCore::IntegralTypedArrayBase::set): (WebCore::IntegralTypedArrayBase::item): (WebCore::IntegralTypedArrayBase::IntegralTypedArrayBase):
  • html/canvas/TypedArrayBase.h: Copied from WebCore/html/canvas/WebGLTypedArrayBase.h. (WebCore::TypedArrayBase::set): (WebCore::TypedArrayBase::TypedArrayBase): (WebCore::TypedArrayBase::create):
  • html/canvas/Uint16Array.cpp: Copied from WebCore/html/canvas/WebGLUnsignedShortArray.cpp. (WebCore::Uint16Array::create): (WebCore::Uint16Array::Uint16Array): (WebCore::Uint16Array::slice):
  • html/canvas/Uint16Array.h: Copied from WebCore/html/canvas/WebGLUnsignedShortArray.h.
  • html/canvas/Uint16Array.idl: Copied from WebCore/html/canvas/WebGLUnsignedShortArray.idl.
  • html/canvas/Uint32Array.cpp: Copied from WebCore/html/canvas/WebGLUnsignedIntArray.cpp. (WebCore::Uint32Array::create): (WebCore::Uint32Array::Uint32Array): (WebCore::Uint32Array::slice):
  • html/canvas/Uint32Array.h: Copied from WebCore/html/canvas/WebGLUnsignedIntArray.h.
  • html/canvas/Uint32Array.idl: Copied from WebCore/html/canvas/WebGLUnsignedIntArray.idl.
  • html/canvas/Uint8Array.cpp: Copied from WebCore/html/canvas/WebGLUnsignedByteArray.cpp. (WebCore::Uint8Array::create): (WebCore::Uint8Array::Uint8Array): (WebCore::Uint8Array::slice):
  • html/canvas/Uint8Array.h: Copied from WebCore/html/canvas/WebGLUnsignedByteArray.h.
  • html/canvas/Uint8Array.idl: Copied from WebCore/html/canvas/WebGLUnsignedByteArray.idl.
  • html/canvas/WebGLArray.cpp: Removed.
  • html/canvas/WebGLArray.h: Removed.
  • html/canvas/WebGLArray.idl: Removed.
  • html/canvas/WebGLArrayBuffer.cpp: Removed.
  • html/canvas/WebGLArrayBuffer.h: Removed.
  • html/canvas/WebGLArrayBuffer.idl: Removed.
  • html/canvas/WebGLBuffer.cpp: (WebCore::WebGLBuffer::associateBufferData): (WebCore::WebGLBuffer::associateBufferSubData):
  • html/canvas/WebGLBuffer.h: (WebCore::WebGLBuffer::elementArrayBuffer):
  • html/canvas/WebGLByteArray.cpp: Removed.
  • html/canvas/WebGLByteArray.h: Removed.
  • html/canvas/WebGLByteArray.idl: Removed.
  • html/canvas/WebGLFloatArray.cpp: Removed.
  • html/canvas/WebGLFloatArray.h: Removed.
  • html/canvas/WebGLFloatArray.idl: Removed.
  • html/canvas/WebGLGetInfo.cpp: (WebCore::WebGLGetInfo::WebGLGetInfo): (WebCore::WebGLGetInfo::getWebGLFloatArray): (WebCore::WebGLGetInfo::getWebGLIntArray): (WebCore::WebGLGetInfo::getWebGLUnsignedByteArray):
  • html/canvas/WebGLGetInfo.h:
  • html/canvas/WebGLIntArray.cpp: Removed.
  • html/canvas/WebGLIntArray.h: Removed.
  • html/canvas/WebGLIntArray.idl: Removed.
  • html/canvas/WebGLIntegralTypedArrayBase.h: Removed.
  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::bufferData): (WebCore::WebGLRenderingContext::bufferSubData): (WebCore::WebGLRenderingContext::getUniform): (WebCore::WebGLRenderingContext::getVertexAttrib): (WebCore::WebGLRenderingContext::readPixels): (WebCore::WebGLRenderingContext::texImage2D): (WebCore::WebGLRenderingContext::texSubImage2D): (WebCore::WebGLRenderingContext::uniform1fv): (WebCore::WebGLRenderingContext::uniform1iv): (WebCore::WebGLRenderingContext::uniform2fv): (WebCore::WebGLRenderingContext::uniform2iv): (WebCore::WebGLRenderingContext::uniform3fv): (WebCore::WebGLRenderingContext::uniform3iv): (WebCore::WebGLRenderingContext::uniform4fv): (WebCore::WebGLRenderingContext::uniform4iv): (WebCore::WebGLRenderingContext::uniformMatrix2fv): (WebCore::WebGLRenderingContext::uniformMatrix3fv): (WebCore::WebGLRenderingContext::uniformMatrix4fv): (WebCore::WebGLRenderingContext::vertexAttrib1fv): (WebCore::WebGLRenderingContext::vertexAttrib2fv): (WebCore::WebGLRenderingContext::vertexAttrib3fv): (WebCore::WebGLRenderingContext::vertexAttrib4fv): (WebCore::WebGLRenderingContext::getWebGLFloatArrayParameter): (WebCore::WebGLRenderingContext::getWebGLIntArrayParameter): (WebCore::WebGLRenderingContext::getWebGLUnsignedByteArrayParameter):
  • html/canvas/WebGLRenderingContext.h:
  • html/canvas/WebGLRenderingContext.idl:
  • html/canvas/WebGLShortArray.cpp: Removed.
  • html/canvas/WebGLShortArray.h: Removed.
  • html/canvas/WebGLShortArray.idl: Removed.
  • html/canvas/WebGLTypedArrayBase.h: Removed.
  • html/canvas/WebGLUnsignedByteArray.cpp: Removed.
  • html/canvas/WebGLUnsignedByteArray.h: Removed.
  • html/canvas/WebGLUnsignedByteArray.idl: Removed.
  • html/canvas/WebGLUnsignedIntArray.cpp: Removed.
  • html/canvas/WebGLUnsignedIntArray.h: Removed.
  • html/canvas/WebGLUnsignedIntArray.idl: Removed.
  • html/canvas/WebGLUnsignedShortArray.cpp: Removed.
  • html/canvas/WebGLUnsignedShortArray.h: Removed.
  • html/canvas/WebGLUnsignedShortArray.idl: Removed.
  • page/DOMWindow.idl:
  • platform/graphics/GraphicsContext3D.h:
  • platform/graphics/mac/GraphicsContext3DMac.cpp: (WebCore::GraphicsContext3D::bufferData): (WebCore::GraphicsContext3D::bufferSubData):
  • platform/graphics/qt/GraphicsContext3DQt.cpp: (WebCore::GraphicsContext3D::bufferData): (WebCore::GraphicsContext3D::bufferSubData):

2010-05-14 Kenneth Russell <​kbr@google.com>

Reviewed by Darin Adler.

Rename WebGLArray types to TypedArray types
​https://bugs.webkit.org/show_bug.cgi?id=39091

Extended functionality of do-webcore-rename script and used it to
rename the WebGLArray types to the TypedArray naming convention.
The only source files which were touched by hand, and which are
being manually reviewed, are:

WebCore/page/DOMWindow.idl
WebCore/bindings/generic/RuntimeEnabledFeatures.h (script's changes undone)
WebKit/WebCore/bindings/js/JSDOMWindowCustom.cpp
WebKit/WebCore/bindings/v8/custom/V8DOMWindowCustom.cpp

These only needed to be touched to update the aliases between the
WebGLArray and TypedArray names introduced in bug 39036. (It was
not feasible to have do-webcore-rename handle this as it would
introduce circular renamings.) These aliases will be removed in
roughly a month once existing WebGL content has been updated.

No new tests; covered under existing WebGL tests. Updated
constructed-objects-prototypes and prototype-inheritance-2 tests.
Ran all layout tests in Safari and all WebGL tests in Chromium.

  • fast/dom/script-tests/constructed-objects-prototypes.js: (constructorPropertiesOnWindow):
  • fast/dom/script-tests/prototype-inheritance-2.js: (constructorNamesForWindow):

2010-05-14 Kenneth Russell <​kbr@google.com>

Reviewed by Darin Adler.

Rename WebGLArray types to TypedArray types
​https://bugs.webkit.org/show_bug.cgi?id=39091

Extended functionality of do-webcore-rename script and used it to
rename the WebGLArray types to the TypedArray naming convention.
The only source files which were touched by hand, and which are
being manually reviewed, are:

WebCore/page/DOMWindow.idl
WebCore/bindings/generic/RuntimeEnabledFeatures.h (script's changes undone)
WebKit/WebCore/bindings/js/JSDOMWindowCustom.cpp
WebKit/WebCore/bindings/v8/custom/V8DOMWindowCustom.cpp

These only needed to be touched to update the aliases between the
WebGLArray and TypedArray names introduced in bug 39036. (It was
not feasible to have do-webcore-rename handle this as it would
introduce circular renamings.) These aliases will be removed in
roughly a month once existing WebGL content has been updated.

No new tests; covered under existing WebGL tests. Updated
constructed-objects-prototypes and prototype-inheritance-2 tests.
Ran all layout tests in Safari and all WebGL tests in Chromium.

  • Scripts/do-webcore-rename: Handle the case where some renames are substrings of others. Support renaming files containing custom JS bindings. If isDOMTypeRename is non-zero, expand the regexp which rewrites the file's contents in order to support custom JS bindings.
3:32 PM Changeset in webkit [59498] by sfalken@apple.com
  • 2 edits in trunk/WebCore

<rdar://problem/7985864> Connection properties dictionary should use standard callbacks for keys, values
​https://bugs.webkit.org/show_bug.cgi?id=39132

Reviewed by Sam Weinig.

  • platform/network/cf/ResourceHandleCFNet.cpp:

(WebCore::createConnectionProperties):

3:27 PM Changeset in webkit [59497] by mrowe@apple.com
  • 1 edit in branches/safari-533-branch/WebKit/win/ChangeLog

Merge r59438.

3:27 PM Changeset in webkit [59496] by mrowe@apple.com
  • 5 edits in branches/safari-533-branch/WebKit/win

Merge r59434.

3:14 PM Changeset in webkit [59495] by eric@webkit.org
  • 3 edits
    2 adds in trunk

2010-05-14 Abhishek Arya <​inferno@chromium.org>

Reviewed by David Hyatt.

Tests that large colspan in a fixed table layout does not result in crash.
​https://bugs.webkit.org/show_bug.cgi?id=38261

  • fast/table/fixed-table-layout-large-colspan-crash-expected.txt: Added.
  • fast/table/fixed-table-layout-large-colspan-crash.html: Added.

2010-05-14 Abhishek Arya <​inferno@chromium.org>

Reviewed by David Hyatt.

Move the m_width(Length) and m_columns(RenderTable::ColumnStruct)
vector out-of-bounds check out of the ASSERT into the main code.
​https://bugs.webkit.org/show_bug.cgi?id=38261

Test: fast/table/fixed-table-layout-large-colspan-crash.html

  • rendering/FixedTableLayout.cpp: (WebCore::FixedTableLayout::calcWidthArray):
3:08 PM Changeset in webkit [59494] by mrowe@apple.com
  • 5 edits in tags/Safari-533.9.1

Versioning.

3:04 PM Changeset in webkit [59493] by mrowe@apple.com
  • 2 edits in tags/Safari-533.9.1/WebCore

Merge r59481.

2:54 PM Changeset in webkit [59492] by mrowe@apple.com
  • 1 copy in tags/Safari-533.9.1

New tag.

2:54 PM Changeset in webkit [59491] by mrowe@apple.com
  • 2 edits in branches/safari-533-branch/WebCore

Merge r59481.

2:14 PM Changeset in webkit [59490] by eric@webkit.org
  • 28 edits in trunk

2010-05-14 Eric Seidel <​eric@webkit.org>

Unreviewed, rolling out r59489.
​http://trac.webkit.org/changeset/59489
​https://bugs.webkit.org/show_bug.cgi?id=37815

abarth broke the known universe and then some.

  • http/tests/security/xss-DENIED-iframe-src-alias-expected.txt:
  • http/tests/security/xss-DENIED-iframe-src-alias.html:

2010-05-14 Eric Seidel <​eric@webkit.org>

Unreviewed, rolling out r59489.
​http://trac.webkit.org/changeset/59489
​https://bugs.webkit.org/show_bug.cgi?id=37815

abarth broke the known universe and then some.

  • Android.jscbindings.mk:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSBindingsAllInOne.cpp:
  • bindings/js/JSCallbackData.cpp: (WebCore::JSCallbackData::invokeCallback):
  • bindings/js/JSEventListener.cpp: (WebCore::JSEventListener::handleEvent):
  • bindings/js/JSInjectedScriptHostCustom.cpp: (WebCore::InjectedScriptHost::createInjectedScript):
  • bindings/js/ScheduledAction.cpp: (WebCore::ScheduledAction::executeFunctionInContext): (WebCore::ScheduledAction::execute):
  • bindings/js/ScheduledAction.h:
  • bindings/js/ScriptController.cpp: (WebCore::ScriptController::evaluateInWorld):
  • bindings/js/ScriptController.h:
  • bindings/js/ScriptFunctionCall.cpp: (WebCore::ScriptFunctionCall::call):
  • bindings/objc/ObjCEventListener.mm: (WebCore::ObjCEventListener::handleEvent):
  • bindings/objc/WebScriptObject.mm: (-[WebScriptObject callWebScriptMethod:withArguments:]): (-[WebScriptObject evaluateWebScript:]):
  • bindings/scripts/CodeGeneratorObjC.pm:
  • bindings/scripts/test/ObjC/DOMTestCallback.mm: (-[DOMTestCallback callbackWithClass1Param:]): (-[DOMTestCallback callbackWithClass2Param:strArg:]): (-[DOMTestCallback callbackWithNonBoolReturnType:]): (-[DOMTestCallback customCallback:class6Param:]):
  • bindings/scripts/test/ObjC/DOMTestInterface.mm:
  • bindings/scripts/test/ObjC/DOMTestObj.mm: (-[DOMTestObj readOnlyIntAttr]): (-[DOMTestObj readOnlyStringAttr]): (-[DOMTestObj readOnlyTestObjAttr]): (-[DOMTestObj intAttr]): (-[DOMTestObj setIntAttr:]): (-[DOMTestObj longLongAttr]): (-[DOMTestObj setLongLongAttr:]): (-[DOMTestObj unsignedLongLongAttr]): (-[DOMTestObj setUnsignedLongLongAttr:]): (-[DOMTestObj stringAttr]): (-[DOMTestObj setStringAttr:]): (-[DOMTestObj testObjAttr]): (-[DOMTestObj setTestObjAttr:]): (-[DOMTestObj attrWithException]): (-[DOMTestObj setAttrWithException:]): (-[DOMTestObj attrWithSetterException]): (-[DOMTestObj setAttrWithSetterException:]): (-[DOMTestObj attrWithGetterException]): (-[DOMTestObj setAttrWithGetterException:]): (-[DOMTestObj customAttr]): (-[DOMTestObj setCustomAttr:]): (-[DOMTestObj scriptStringAttr]): (-[DOMTestObj voidMethod]): (-[DOMTestObj voidMethodWithArgs:strArg:objArg:]): (-[DOMTestObj intMethod]): (-[DOMTestObj intMethodWithArgs:strArg:objArg:]): (-[DOMTestObj objMethod]): (-[DOMTestObj objMethodWithArgs:strArg:objArg:]): (-[DOMTestObj serializedValue:]): (-[DOMTestObj methodWithException]): (-[DOMTestObj customMethod]): (-[DOMTestObj customMethodWithArgs:strArg:objArg:]): (-[DOMTestObj customArgsAndException:]): (-[DOMTestObj addEventListener:listener:useCapture:]): (-[DOMTestObj removeEventListener:listener:useCapture:]): (-[DOMTestObj withDynamicFrame]): (-[DOMTestObj withDynamicFrameAndArg:]): (-[DOMTestObj withDynamicFrameAndOptionalArg:optionalArg:]): (-[DOMTestObj withDynamicFrameAndUserGesture:]): (-[DOMTestObj withDynamicFrameAndUserGestureASAD:optionalArg:]): (-[DOMTestObj withScriptStateVoid]): (-[DOMTestObj withScriptStateObj]): (-[DOMTestObj withScriptStateVoidException]): (-[DOMTestObj withScriptStateObjException]): (-[DOMTestObj methodWithOptionalArg:]): (-[DOMTestObj methodWithNonOptionalArgAndOptionalArg:opt:]): (-[DOMTestObj methodWithNonOptionalArgAndTwoOptionalArgs:opt1:opt2:]):
  • bindings/v8/ScriptController.cpp:
  • bindings/v8/ScriptController.h:
  • html/HTMLFrameElementBase.cpp: (WebCore::HTMLFrameElementBase::isURLAllowed):
1:52 PM Changeset in webkit [59489] by abarth@webkit.org
  • 28 edits in trunk

2010-05-14 Justin Schuh <​jschuh@chromium.org>

Reviewed by Adam Barth.

Moving frame.src checks out of the bindings
​https://bugs.webkit.org/show_bug.cgi?id=37815

Moved JavaScript frame.src checks out of bindings and into
HTMLFrameElementBase. Added main thread state stack to JavaScriptCore
so ExecState is available inside core DOM. Updated affected bindings
(except for GObject, which will need to be updated to avoid origin
failures inside native code).

  • Android.jscbindings.mk:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSBindingsAllInOne.cpp:
  • bindings/js/JSCallbackData.cpp: (WebCore::JSCallbackData::invokeCallback):
  • bindings/js/JSEventListener.cpp: (WebCore::JSEventListener::handleEvent):
  • bindings/js/JSInjectedScriptHostCustom.cpp: (WebCore::InjectedScriptHost::createInjectedScript):
  • bindings/js/ScheduledAction.cpp: (WebCore::ScheduledAction::executeFunctionInContext): (WebCore::ScheduledAction::execute):
  • bindings/js/ScheduledAction.h:
  • bindings/js/ScriptController.cpp: (WebCore::ScriptController::evaluateInWorld): (WebCore::ScriptController::canAccessFromCurrentOrigin):
  • bindings/js/ScriptController.h:
  • bindings/js/ScriptFunctionCall.cpp: (WebCore::ScriptFunctionCall::call):
  • bindings/objc/ObjCEventListener.mm: (WebCore::ObjCEventListener::handleEvent):
  • bindings/objc/WebScriptObject.mm: (-[WebScriptObject callWebScriptMethod:withArguments:]): (-[WebScriptObject evaluateWebScript:]):
  • bindings/scripts/CodeGeneratorObjC.pm:
  • bindings/scripts/test/ObjC/DOMTestCallback.mm: (-[DOMTestCallback callbackWithClass1Param:]): (-[DOMTestCallback callbackWithClass2Param:strArg:]): (-[DOMTestCallback callbackWithNonBoolReturnType:]): (-[DOMTestCallback customCallback:class6Param:]):
  • bindings/scripts/test/ObjC/DOMTestInterface.mm:
  • bindings/scripts/test/ObjC/DOMTestObj.mm: (-[DOMTestObj readOnlyIntAttr]): (-[DOMTestObj readOnlyStringAttr]): (-[DOMTestObj readOnlyTestObjAttr]): (-[DOMTestObj intAttr]): (-[DOMTestObj setIntAttr:]): (-[DOMTestObj longLongAttr]): (-[DOMTestObj setLongLongAttr:]): (-[DOMTestObj unsignedLongLongAttr]): (-[DOMTestObj setUnsignedLongLongAttr:]): (-[DOMTestObj stringAttr]): (-[DOMTestObj setStringAttr:]): (-[DOMTestObj testObjAttr]): (-[DOMTestObj setTestObjAttr:]): (-[DOMTestObj attrWithException]): (-[DOMTestObj setAttrWithException:]): (-[DOMTestObj attrWithSetterException]): (-[DOMTestObj setAttrWithSetterException:]): (-[DOMTestObj attrWithGetterException]): (-[DOMTestObj setAttrWithGetterException:]): (-[DOMTestObj customAttr]): (-[DOMTestObj setCustomAttr:]): (-[DOMTestObj scriptStringAttr]): (-[DOMTestObj voidMethod]): (-[DOMTestObj voidMethodWithArgs:strArg:objArg:]): (-[DOMTestObj intMethod]): (-[DOMTestObj intMethodWithArgs:strArg:objArg:]): (-[DOMTestObj objMethod]): (-[DOMTestObj objMethodWithArgs:strArg:objArg:]): (-[DOMTestObj serializedValue:]): (-[DOMTestObj methodWithException]): (-[DOMTestObj customMethod]): (-[DOMTestObj customMethodWithArgs:strArg:objArg:]): (-[DOMTestObj customArgsAndException:]): (-[DOMTestObj addEventListener:listener:useCapture:]): (-[DOMTestObj removeEventListener:listener:useCapture:]): (-[DOMTestObj withDynamicFrame]): (-[DOMTestObj withDynamicFrameAndArg:]): (-[DOMTestObj withDynamicFrameAndOptionalArg:optionalArg:]): (-[DOMTestObj withDynamicFrameAndUserGesture:]): (-[DOMTestObj withDynamicFrameAndUserGestureASAD:optionalArg:]): (-[DOMTestObj withScriptStateVoid]): (-[DOMTestObj withScriptStateObj]): (-[DOMTestObj withScriptStateVoidException]): (-[DOMTestObj withScriptStateObjException]): (-[DOMTestObj methodWithOptionalArg:]): (-[DOMTestObj methodWithNonOptionalArgAndOptionalArg:opt:]): (-[DOMTestObj methodWithNonOptionalArgAndTwoOptionalArgs:opt1:opt2:]):
  • bindings/v8/ScriptController.cpp: (WebCore::ScriptController::canAccessFromCurrentOrigin):
  • bindings/v8/ScriptController.h:
  • html/HTMLFrameElementBase.cpp: (WebCore::HTMLFrameElementBase::isURLAllowed):

2010-05-14 Justin Schuh <​jschuh@chromium.org>

Reviewed by Adam Barth.

Moving frame.src checks out of the bindings
​https://bugs.webkit.org/show_bug.cgi?id=37815

  • http/tests/security/xss-DENIED-iframe-src-alias-expected.txt:
  • http/tests/security/xss-DENIED-iframe-src-alias.html:
1:49 PM Changeset in webkit [59488] by eric@webkit.org
  • 2 edits in trunk/WebKitSite

2010-05-14 Eric Seidel <​eric@webkit.org>

Reviewed by Maciej Stachowiak.

Update tools.html to mention that Tiger users require a newer Python
​https://bugs.webkit.org/show_bug.cgi?id=38822

Also updated the instructions that only Tiger users need
to install a subversion client. Newer OSes already have
subversion included in the install.

  • building/tools.html:
1:36 PM Changeset in webkit [59487] by dimich@chromium.org
  • 2 edits in trunk/WebCore

Adding resized image caching for Skia.
​https://bugs.webkit.org/show_bug.cgi?id=39085

Patch by Sergey Ulanov <​sergeyu@chromium.org> on 2010-05-14
Reviewed by Dmitry Titov and Brett Wilson.

Tests: HTML5 video on YouTube.

  • platform/graphics/skia/ImageSkia.cpp:

(WebCore::Image::drawPattern): Use bitmap->resizedBitmap() to cache resized image when possible.

1:32 PM Changeset in webkit [59486] by ap@apple.com
  • 3 edits
    2 adds in trunk

Reviewed by Brady Eidson.

​https://bugs.webkit.org/show_bug.cgi?id=39008
<rdar://problem/7976142> REGRESSION (r58950): Webkit crashes on clicking back button when in Hotmail

Test: fast/parser/tokenizer-close-during-document-write.html

  • dom/Document.cpp: (WebCore::Document::write): Check that the tokenizer is still around after calling write(). It can become null (as it happens in regression test), and I don't see any guarantee that it would never be replaced with a different one (but I can't make a test for that).
1:31 PM Changeset in webkit [59485] by jianli@chromium.org
  • 2 edits in trunk/WebCore

Fix the code indentation inside a namespace to be consistent with the
style guide.

Rubber-stamped by Dmitry Titov.

  • workers/GenericWorkerTask.h:
1:24 PM Changeset in webkit [59484] by jianli@chromium.org
  • 2 edits in trunk/WebCore

Remove the ENABLE(WORKERS) guard from GenericWorkerTask.h and rename
all occurrences of GenericWorkerTask* to GenericTask* in this file.
​https://bugs.webkit.org/show_bug.cgi?id=39129

Reviewed by Dmitry Titov.

I will have another patch to rename the file and move it to the right
place.

  • workers/GenericWorkerTask.h:

(WebCore::):
(WebCore::GenericTask1::create):
(WebCore::GenericTask1::GenericTask1):
(WebCore::GenericTask2::create):
(WebCore::GenericTask2::GenericTask2):
(WebCore::GenericTask3::create):
(WebCore::GenericTask3::GenericTask3):
(WebCore::GenericTask4::create):
(WebCore::GenericTask4::GenericTask4):
(WebCore::GenericTask5::create):
(WebCore::GenericTask5::GenericTask5):
(WebCore::GenericTask6::create):
(WebCore::GenericTask6::GenericTask6):
(WebCore::GenericTask7::create):
(WebCore::GenericTask7::GenericTask7):
(WebCore::GenericTask8::create):
(WebCore::GenericTask8::GenericTask8):
(WebCore::createCallbackTask):

1:16 PM Changeset in webkit [59483] by eric@webkit.org
  • 3 edits in trunk/WebCore

2010-05-14 Evan Martin <​evan@chromium.org>

Reviewed by David Levin.

[chromium] don't call fontconfig twice in complex text path
​https://bugs.webkit.org/show_bug.cgi?id=38701

Previously getFontDataForCharacters would call fontconfig once to
resolve a font name, then pass that name to getCachedFontPlatformData
to load the font. This would be two trips through fontconfig (including
IPCs). With this change, we completely load the font in the first pass.

This patch is actually the same code as in r58341, which was reverted
because of a performance problem; a performance improvement has now
been committed, and with that change in place this change improves
the Chromium intl2 page cycler performance by another 5%.

See also ​https://bugs.webkit.org/show_bug.cgi?id=37904 .

Test: fast/text/international/bold-bengali.html
(Was checked in as part of the first attempt at this change, continues
to pass after this change.)

  • platform/chromium/ChromiumBridge.h:
  • platform/graphics/chromium/FontCacheLinux.cpp: (WebCore::FontCache::getFontDataForCharacters):
12:49 PM Changeset in webkit [59482] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-05-14 Young Han Lee <​joybro@company100.net>

Reviewed by Darin Adler.

Don't include RetainPtr.h unless PLATFORM(CF) is set.
The RetainPtr is only used for CF platform in this class.
​https://bugs.webkit.org/show_bug.cgi?id=39043

No new tests, there is no new functionality.

  • platform/network/curl/ResourceHandleManager.cpp:
12:21 PM Changeset in webkit [59481] by bweinstein@apple.com
  • 2 edits in trunk/WebCore

Build fix, we need to copy over the files in $(WebKitOutputDir)/include/JavaScriptCore/private before
WebCore builds. This is because we are building a couple WTF files in WebCore and JavaScriptCore.

Reviewed by Adam Roben.

  • WebCore.vcproj/WebCore.make:
12:18 PM Changeset in webkit [59480] by eric@webkit.org
  • 3 edits in trunk/WebKitTools

2010-05-14 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

webkit-patch rollout throws exception if bug is already open
​https://bugs.webkit.org/show_bug.cgi?id=38803

This was caused by someone incorrectly wrapping the code. :p
I'm going to have to start demanding unit tests for wrapping changes...

I also fixed the code to be able to reopen bugs which were never confirmed.
Before it regressed, the code would just log in that case. Now it actually
will reopen the bug, but there is a FIXME about how the logic is a bit backwards.

  • Scripts/webkitpy/common/net/bugzilla.py:
  • Scripts/webkitpy/common/net/bugzilla_unittest.py:
    • Yay testing!
11:59 AM Changeset in webkit [59479] by eric@webkit.org
  • 3 edits in trunk/LayoutTests

2010-05-14 Zhenyao Mo <​zmo@google.com>

Reviewed by Eric Seidel.

Temporarily remove a few test cases that failed on leopard bot.
​https://bugs.webkit.org/show_bug.cgi?id=33805

  • fast/canvas/webgl/texture-npot-expected.txt: Removed failed test cases.
  • fast/canvas/webgl/texture-npot.html: Ditto.
11:49 AM Changeset in webkit [59478] by yurys@chromium.org
  • 2 edits in trunk/LayoutTests

2010-05-14 Yury Semikhatsky <​yurys@chromium.org>

Unreviewed. Chromium: update test expectations.

  • platform/chromium-linux/fast/loader/recursive-before-unload-crash-expected.txt:
9:55 AM Changeset in webkit [59477] by hamaji@chromium.org
  • 2 edits in trunk/WebCore

2010-05-14 Shinichiro Hamaji <​hamaji@chromium.org>

Unreviewed. Attempt to fix chromium's memory bot error.

More :visited link optimizations to reduce memory usage
​https://bugs.webkit.org/show_bug.cgi?id=39084

The original change (r59386) adds check for m_element in initElement.
As don't initialize m_element in the constructor of CSSStyleSelector,
valgrind complains.

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::CSSStyleSelector):
9:33 AM Changeset in webkit [59476] by jorlow@chromium.org
  • 2 edits
    2 deletes in trunk/LayoutTests

2010-05-14 Jeremy Orlow <​jorlow@chromium.org>

Reviewed by Dimitri Glazkov.

Instead of rebaslining prototype-inheritance for Chromium, add indexedDB to its exceptions
​https://bugs.webkit.org/show_bug.cgi?id=39122

The test has a way to name properties that shouldn't be tested (used when they're not enabled
by most ports). Use this feature rather than creating custom baselines.

  • fast/dom/script-tests/prototype-inheritance.js:
  • platform/chromium-mac/fast/dom/prototype-inheritance-expected.txt: Removed.
  • platform/chromium-win/fast/dom/prototype-inheritance-expected.txt: Removed.
9:03 AM Changeset in webkit [59475] by jorlow@chromium.org
  • 1 edit
    2 adds in trunk/LayoutTests

2010-05-14 Jeremy Orlow <​jorlow@chromium.org>

Reviewed by Nate Chapin.

[Chromium] Rebaseline prototype-inheritance
​https://bugs.webkit.org/show_bug.cgi?id=39116

IndexedDB is now turned on for Chromium's test shell. I'm not sure
if this is the correct behavior or not (can someone confirm which it is?)
but we should get this test running again so we can catch real regressions.
And, before taking this out from behind a flag, we should be sure to fix it.

  • platform/chromium-mac/fast/dom/prototype-inheritance-expected.txt: Added.
  • platform/chromium-win/fast/dom/prototype-inheritance-expected.txt: Added.
8:59 AM QtWebKitBugs edited by Simon Hausmann
(diff)
8:24 AM Changeset in webkit [59474] by Simon Hausmann
  • 5 edits
    3 copies
    2 deletes in trunk

.: [Qt] Rename QtLauncher to QtTestBrowser
​https://bugs.webkit.org/show_bug.cgi?id=37665

Rubber-stamped by Antti Koivisto.

  • WebKit.pro:

WebKitTools: [Qt] Rename QtLauncher to QtTestBrowser

Rubber-stamped by Antti Koivisto.

  • QtTestBrowser: Copied from WebKitTools/QtLauncher.
  • QtTestBrowser/QtLauncher.pro: Removed.
  • QtTestBrowser/QtLauncher.qrc: Removed.
  • QtTestBrowser/QtTestBrowser.pro: Copied from WebKitTools/QtLauncher/QtLauncher.pro.
  • QtTestBrowser/QtTestBrowser.qrc: Copied from WebKitTools/QtLauncher/QtLauncher.qrc.
  • Scripts/run-launcher:
  • Scripts/webkitdirs.pm:
8:12 AM QtWebKitTriageRoster edited by jesus@webkit.org
(diff)
8:11 AM QtWebKitBugs edited by jesus@webkit.org
(diff)
7:47 AM Changeset in webkit [59473] by eric@webkit.org
  • 4 edits in trunk/WebCore

2010-05-14 Andreas Kling <​andreas.kling@nokia.com>

Reviewed by Darin Adler.

CSSParser::parseColor() shouldn't alter 'color' unless passed a valid color string.
​https://bugs.webkit.org/show_bug.cgi?id=39031

  • css/CSSParser.cpp: (WebCore::CSSParser::parseColor):
  • editing/ApplyStyleCommand.cpp: (WebCore::StyleChange::extractTextStyles): Don't depend on old behavior.
  • html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::setShadow): Remove dead code.
7:16 AM Changeset in webkit [59472] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-05-14 Jens Alfke <​snej@chromium.org>

Reviewed by John Sullivan.

Don't clear yellow autofill highlight from text fields until the user edits them.
​https://bugs.webkit.org/show_bug.cgi?id=39032
No new tests (Couldn't find any autofill tests. The flag doesn't seem to be exposed to JS.)

  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::handleFocusEvent): Don't clear the autofilled flag. (WebCore::HTMLInputElement::setValueFromRenderer): Clear the autofilled flag.
5:57 AM Changeset in webkit [59471] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

Unreviewed, unskip passing tests.

[Qt] animations/dynamic-stylesheet-loading.html fails with accelerated compositing
​https://bugs.webkit.org/show_bug.cgi?id=37381

  • platform/qt/Skipped:
    • animations/simultaneous-start-left.html unskipped.
    • animations/dynamic-stylesheet-loading.html unskipped.
5:52 AM Changeset in webkit [59470] by eric@webkit.org
  • 6 edits
    2 adds in trunk

2010-05-14 Zhenyao Mo <​zmo@google.com>

Reviewed by Dimitri Glazkov.

Must implement OpenGL ES 2.0 semantics for NPOT textures
​https://bugs.webkit.org/show_bug.cgi?id=33805

  • fast/canvas/webgl/texture-npot-expected.txt: Added.
  • fast/canvas/webgl/texture-npot.html: Added.

2010-05-14 Zhenyao Mo <​zmo@google.com>

Reviewed by Dimitri Glazkov.

Must implement OpenGL ES 2.0 semantics for NPOT textures
​https://bugs.webkit.org/show_bug.cgi?id=33805

Test: fast/canvas/webgl/texture-npot.html

  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::WebGLRenderingContext): Create black 1x1 textures. (WebCore::WebGLRenderingContext::bindTexture): Set texture dimensionality. (WebCore::WebGLRenderingContext::copyTexImage2D): Error check, set texture size. (WebCore::WebGLRenderingContext::drawArrays): Bind to black textures if needed. (WebCore::WebGLRenderingContext::drawElements): Bind to black textures if needed. (WebCore::WebGLRenderingContext::generateMipmap): Error check. (WebCore::WebGLRenderingContext::texImage2DBase): Error check, set texture size. (WebCore::WebGLRenderingContext::texParameterf): Set texture parameter. (WebCore::WebGLRenderingContext::texParameteri): Ditto. (WebCore::WebGLRenderingContext::handleNPOTTextures): Bind to black textures if needed before draw, and bind back to original textures after draw.
  • html/canvas/WebGLRenderingContext.h: Add black 1x1 textures.
  • html/canvas/WebGLTexture.cpp: Add support to track NPOT textures. (WebCore::WebGLTexture::createBlackTexture1x1): Create a black 1x1 texture. (WebCore::WebGLTexture::WebGLTexture): Initialize parameters and states. (WebCore::WebGLTexture::setDimensionality): Set dimensionality. (WebCore::WebGLTexture::setParameteri): Set parameter. (WebCore::WebGLTexture::setParameterf): Ditto. (WebCore::WebGLTexture::setSize): Set level 0 texture size. (WebCore::WebGLTexture::isNPOT): Whether the texture is NPOT. (WebCore::WebGLTexture::updateNPOTStates): Calculate NPOT and NeedToUseBlackTexture states.
  • html/canvas/WebGLTexture.h: Add support to track NPOT textures. (WebCore::WebGLTexture::isNPOT): (WebCore::WebGLTexture::needToUseBlackTexture):
5:39 AM Changeset in webkit [59469] by eric@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-05-14 Chao-ying Fu <​fu@mips.com>

Reviewed by Oliver Hunt.

String Indexing Failure on JSVALUE32 targets
​https://bugs.webkit.org/show_bug.cgi?id=39034

Remove zero-extend/shift-right code on regT1, because we already have
it in emit_op_get_by_val().

  • jit/JITPropertyAccess.cpp: (JSC::JIT::stringGetByValStubGenerator):
5:36 AM Changeset in webkit [59468] by pfeldman@chromium.org
  • 17 edits
    3 adds in trunk/WebCore

2010-05-14 Andrey Kosyakov <​caseq@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: add help on keyboard shortcuts (take 2).

​https://bugs.webkit.org/show_bug.cgi?id=38667

  • English.lproj/localizedStrings.js:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/front-end/CallStackSidebarPane.js: (WebInspector.CallStackSidebarPane): (WebInspector.CallStackSidebarPane.prototype._placardSelected): (WebInspector.CallStackSidebarPane.prototype.registerShortcuts):
  • inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView): (WebInspector.ConsoleView.prototype._registerShortcuts):
  • inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel): (WebInspector.ElementsPanel.prototype._registerShortcuts):
  • inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeOutline.prototype._keyDown):
  • inspector/front-end/HelpScreen.js: Added.
  • inspector/front-end/KeyboardShortcut.js:
  • inspector/front-end/ScriptsPanel.js:
5:32 AM QtWebKitTriageRoster edited by Csaba Osztrogonác
(diff)
5:28 AM Changeset in webkit [59467] by eric@webkit.org
  • 2 edits in trunk/WebKit/chromium

2010-05-14 Jochen Eisinger <​jochen@chromium.org>

Reviewed by Eric Seidel.

Make ImageDiff depend on webkit (again).
​https://bugs.webkit.org/show_bug.cgi?id=39000

  • WebKit.gyp:
5:16 AM Changeset in webkit [59466] by eric@webkit.org
  • 4 edits in trunk/WebKit/chromium

2010-05-14 James Simonsen <​simonjam+webkit@google.com>

Reviewed by Darin Fisher.

[chromium] Expose volume through WebMediaPlayerClient
​https://bugs.webkit.org/show_bug.cgi?id=38947

  • public/WebMediaPlayerClient.h:
  • src/WebMediaPlayerClientImpl.cpp: (WebKit::WebMediaPlayerClientImpl::volume):
  • src/WebMediaPlayerClientImpl.h:
5:03 AM QtWebKitJournal edited by Simon Hausmann
(diff)
4:55 AM Changeset in webkit [59465] by eric@webkit.org
  • 10 edits in trunk

2010-05-14 Tony Gentilcore <​tonyg@chromium.org>

Reviewed by Darin Fisher.

[chromium] Update chromium port to send/receive cached metadata
​https://bugs.webkit.org/show_bug.cgi?id=38665

No new tests because no new functionality.

  • platform/chromium/ChromiumBridge.h:
  • platform/network/chromium/ResourceResponse.h: (WebCore::ResourceResponse::ResourceResponse): (WebCore::ResourceResponse::responseTime): (WebCore::ResourceResponse::setResponseTime):

2010-05-14 Tony Gentilcore <​tonyg@chromium.org>

Reviewed by Darin Fisher.

[chromium] Update chromium port to send/receive cached metadata
​https://bugs.webkit.org/show_bug.cgi?id=38665

  • public/WebKitClient.h: (WebKit::WebKitClient::cacheMetadata):
  • public/WebURLLoaderClient.h: (WebKit::WebURLLoaderClient::didReceiveCachedMetadata):
  • public/WebURLResponse.h:
  • src/ChromiumBridge.cpp: (WebCore::ChromiumBridge::cacheMetadata):
  • src/ResourceHandle.cpp: (WebCore::ResourceHandleInternal::didReceiveCachedMetadata): (WebCore::ResourceHandle::cacheMetadata):
  • src/WebURLResponse.cpp: (WebKit::WebURLResponse::responseTime): (WebKit::WebURLResponse::setResponseTime):
4:32 AM Changeset in webkit [59464] by eric@webkit.org
  • 3 edits in trunk/WebKitTools

2010-05-14 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Stop CCing webkit-bot-watchers
​https://bugs.webkit.org/show_bug.cgi?id=39020

webkit-bot-watchers is somewhat of a failed experiment. No one
subscribed to the list (not even me). Removing it from the code
because wms says it bounces email sometimes.

  • Scripts/webkitpy/tool/commands/queues.py:
  • Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
4:24 AM Changeset in webkit [59463] by jocelyn.turcotte@nokia.com
  • 2 edits in trunk/JavaScriptCore

Fix a VS2010 assert in std::copy
​https://bugs.webkit.org/show_bug.cgi?id=38630

Reviewed by Alexey Proskuryakov.

The assert complains that the output iterator is null.

  • wtf/Vector.h:

(WTF::::operator):

4:21 AM Changeset in webkit [59462] by eric@webkit.org
  • 5 edits in trunk/WebCore

2010-05-14 Chris Evans <​cevans@chromium.org>

Reviewed by Adam Barth.

Chromium-specific fix to prevent zombie infobars.

​https://bugs.webkit.org/show_bug.cgi?id=38948

  • bindings/v8/ScriptController.cpp (WebCore::ScriptController::processingUserGesture): Require a more definite "no" signal.
  • loader/RedirectScheduler.cpp: (WebCore::ScheduledFormSubmission::fire): Use a very strong yes / no signal; no need for "possible" here.
  • dom/UserGestureIndicator.h:
  • dom/UserGestureIndicator.cpp: Adapt to tri-state: definitely yes; definitely no; not sure.
3:55 AM Changeset in webkit [59461] by eric@webkit.org
  • 3 edits in trunk/WebKitTools

2010-05-14 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

REGRESSION: webkit-patch commit-message throws exception
​https://bugs.webkit.org/show_bug.cgi?id=38997

  • Scripts/webkitpy/tool/commands/upload.py:
    • Fix to respect and pass the --squash and --git-commit options.
  • Scripts/webkitpy/tool/commands/upload_unittest.py:
    • Fix the unit test to use the central MockCheckout instead of its own custom Mock which didn't require enough parameters.
2:58 AM Changeset in webkit [59460] by Simon Hausmann
  • 3 edits in trunk/WebCore

[Qt] JavaScript unable to invoke methods declared in QML
​https://bugs.webkit.org/show_bug.cgi?id=38949

Patch by Aaron Kennedy <​tffeeb@gmail.com> on 2010-05-14
Reviewed by Simon Hausmann.

JavaScript code executed by webkit cannot call into QML declared
methods, as it does not check for dynamic meta objects.

  • bridge/qt/qt_instance.cpp:

(JSC::Bindings::QtInstance::stringValue): Use QMetaObject::metacall.

  • bridge/qt/qt_runtime.cpp:

(JSC::Bindings::QtRuntimeMetaMethod::call): Ditto.

2:50 AM Changeset in webkit [59459] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-05-14 Ben Murdoch <​benm@google.com>

Reviewed by Darin Fisher.

Touch events are disabled by default when using V8.
​https://bugs.webkit.org/show_bug.cgi?id=38990

Touch events are protected by a compile time guard, so it's safe to
assume that the runtime flag should be enabled by default when this
guard is present.

No new tests, build fix for Android.

  • bindings/generic/RuntimeEnabledFeatures.cpp: enable touch events by default.
2:29 AM Changeset in webkit [59458] by mrowe@apple.com
  • 10 edits in branches/safari-533-branch

<rdar://problem/7677994> Disable WebGL

JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig:

WebCore:

  • Configurations/FeatureDefines.xcconfig:

WebKit/mac:

  • Configurations/FeatureDefines.xcconfig:

WebKit2:

  • Configurations/FeatureDefines.xcconfig:

WebKitTools:

  • Scripts/build-webkit:
2:23 AM Changeset in webkit [59457] by jorlow@chromium.org
  • 1 edit
    2 adds in trunk/LayoutTests

2010-05-14 Hans Wennborg <​hans@chromium.org>

Reviewed by Jeremy Orlow.

[Chromium] Rebaseline storage/domstorage/quota.html
​https://bugs.webkit.org/show_bug.cgi?id=38996

Chromium enforces quota on session storage and thus expects to "fail"
the first part of this test.

  • platform/chromium-mac/storage/domstorage/quota-expected.txt: Added.
  • platform/chromium-win/storage/domstorage/quota-expected.txt: Added.
2:14 AM Changeset in webkit [59456] by Simon Hausmann
  • 15 edits in trunk/WebKit/qt

[Qt] Merge overhaul of the QtWebKit API documentation

Patch by Kent Hansen <​kent.hansen@nokia.com>, Jocelyn Turcotte <​jocelyn.turcotte@nokia.com>, Tor Arne Vestbø <​tor.arne.vestbo@nokia.com>, Henry Haverinen <Henry Haverinen>, Jedrzej Nowacki <​jedrzej.nowacki@nokia.com>, Andreas Kling <​andreas.kling@nokia.com> on 2010-05-14
Reviewed by Simon Hausmann.

Numerous improvements in wording, qdoc warning fixes and
clarifications, done in a team work effort.

No functional changes.

  • Api/qwebdatabase.cpp:
  • Api/qwebelement.cpp:
  • Api/qwebframe.cpp:
  • Api/qwebhistoryinterface.cpp:
  • Api/qwebinspector.cpp:
  • Api/qwebkitversion.cpp:
  • Api/qwebpage.cpp:
  • Api/qwebpluginfactory.cpp:
  • Api/qwebsecurityorigin.cpp:
  • Api/qwebsettings.cpp:
  • Api/qwebsettings.h:
  • docs/qtwebkit.qdoc:
  • docs/webkitsnippets/qtwebkit_qwebinspector_snippet.cpp:

(wrapInFunction):

  • docs/webkitsnippets/webelement/main.cpp:

(findButtonAndClick):
(autocomplete1):
(autocomplete2):
(main):

2:04 AM Changeset in webkit [59455] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

Documentation: Fix overview grouping.

Patch by Martin Smith <​msmith@trolltech.com> on 2010-05-14
Reviewed by Simon Hausmann.

  • docs/qtwebkit.qdoc:
1:49 AM Changeset in webkit [59454] by yurys@chromium.org
  • 7 edits
    2 adds in trunk/LayoutTests

2010-05-14 Yury Semikhatsky <​yurys@chromium.org>

Unreviewed. Chromium: update test expectations.

  • platform/chromium-linux/editing/deleting/5408255-expected.checksum:
  • platform/chromium-linux/fast/loader/recursive-before-unload-crash-expected.txt: Added.
  • platform/chromium-mac/editing/deleting/5408255-expected.checksum: Added.
  • platform/chromium-win/editing/deleting/5408255-expected.checksum:
  • platform/chromium-win/editing/deleting/5408255-expected.txt:
  • platform/chromium-win/editing/deleting/delete-select-all-001-expected.txt:
  • platform/chromium-win/editing/selection/4895428-1-expected.txt:
  • platform/chromium-win/editing/selection/4895428-4-expected.txt:
1:44 AM Changeset in webkit [59453] by eric@webkit.org
  • 2 edits in trunk/WebKit

2010-05-14 Lucas De Marchi <​lucas.demarchi@profusion.mobi>

Reviewed by David Levin.

[EF] Include missing header.
​http://webkit.org/b/38905

  • efl/ewk/ewk_main.cpp: Include PageGroup.h
1:43 AM Changeset in webkit [59452] by mrowe@apple.com
  • 2 edits in branches/safari-533-branch/WebKitTools

Merge r59177.

1:32 AM Changeset in webkit [59451] by eric@webkit.org
  • 2 edits in trunk/WebKit/qt

2010-05-14 Benjamin Poulain <​benjamin.poulain@nokia.com>

Reviewed by Laszlo Gombos.

[QT] Update the Symbian version for the user agent
​https://bugs.webkit.org/show_bug.cgi?id=38389

Update the user agent for Symbian2 to Symbian4

  • Api/qwebpage.cpp: (QWebPage::userAgentForUrl):
1:23 AM Changeset in webkit [59450] by mrowe@apple.com
  • 4 edits in branches/safari-533-branch/WebCore

Disable the Audits panel and Workers sidebar in the Web Inspector.

Patch by Timothy Hatcher <​timothy@apple.com> on 2010-05-13
<rdar://problem/7947035>

Reviewed by Ada Chan.

  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel): Don't make a workers sidebar pane.
(WebInspector.ScriptsPanel.prototype.reset): Null check workers sidebar pane.

  • inspector/front-end/Settings.js: Set auditsPanelEnabled to false.
  • inspector/front-end/WorkersSidebarPane.js:

(WebInspector.didCreateWorker): Null check workers sidebar pane.
(WebInspector.didDestroyWorker): Ditto.

1:21 AM Changeset in webkit [59449] by eric@webkit.org
  • 2 edits in trunk/WebKit/qt

2010-05-14 Dawit Alemayehu <​adawit@kde.org>

Reviewed by Simon Hausmann.

Implemented createJavaAppletWidget to activate Java applet support.

​https://bugs.webkit.org/show_bug.cgi?id=33044

  • WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::createJavaAppletWidget):
1:09 AM Changeset in webkit [59448] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-05-14 George Wright <​gwright@rim.com>

Reviewed by George Staikos.

​https://bugs.webkit.org/show_bug.cgi?id=38909

Update JSDataGridColumnListCustom.cpp to call identifierToAtomicString()
on the property name.

  • bindings/js/JSDataGridColumnListCustom.cpp: (WebCore::JSDataGridColumnList::canGetItemsForName): (WebCore::JSDataGridColumnList::nameGetter):
12:43 AM Changeset in webkit [59447] by eric@webkit.org
  • 3 edits
    3 adds in trunk

2010-05-14 Andreas Kling <​andreas.kling@nokia.com>

Reviewed by Darin Adler.

Add test to check that setting various CanvasRenderingContext2D properties
to invalid values is ignored.

​https://bugs.webkit.org/show_bug.cgi?id=38841

  • fast/canvas/canvas-invalid-values-expected.txt: Added.
  • fast/canvas/canvas-invalid-values.html: Added.
  • fast/canvas/script-tests/canvas-invalid-values.js: Added. (trySettingMiterLimit): (trySettingLineWidth): (trySettingShadowBlur): (trySettingShadowOffsetX): (trySettingShadowOffsetY):

2010-05-14 Andreas Kling <​andreas.kling@nokia.com>

Reviewed by Darin Adler.

Ignore invalid values for various CanvasRenderingContext2D properties
(lineWidth, miterLimit, shadowOffsetX, shadowOffsetY and shadowBlur)

​https://bugs.webkit.org/show_bug.cgi?id=38841

Test: fast/canvas/canvas-invalid-values.html

  • html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::setLineWidth): (WebCore::CanvasRenderingContext2D::setMiterLimit): (WebCore::CanvasRenderingContext2D::setShadowOffsetX): (WebCore::CanvasRenderingContext2D::setShadowOffsetY): (WebCore::CanvasRenderingContext2D::setShadowBlur):
12:08 AM Changeset in webkit [59446] by tkent@chromium.org
  • 1 edit in trunk/LayoutTests/platform/chromium/test_expectations.txt

Unreviewed, test expectation update.

deleted-host-in-resource-load-delegate-callback.html sometimes crashes on Windows Release.

May 13, 2010:

11:35 PM Changeset in webkit [59445] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

Symbian build fix.

[Qt] Updated the def file with new exports.

  • symbian/eabi/QtWebKitu.def: Add missing gc symbol for QtLauncher
11:18 PM Changeset in webkit [59444] by Simon Fraser
  • 1 edit
    1 add in trunk/LayoutTests

2010-05-13 Simon Fraser <Simon Fraser>

Fixing test failure.

Adding resource that should have been added in r59443.

  • compositing/iframes/resources/subframe.html: Added.
10:32 PM Changeset in webkit [59443] by Simon Fraser
  • 3 edits
    4 adds in trunk

2010-05-13 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein.

iframes in compositing layers don't redraw correctly on scrolling
​https://bugs.webkit.org/show_bug.cgi?id=39096

When an iframe ends up in a compositing layer (that is painting to its backing store), we need
to turn off blitting on scrolling. RenderView::paintBoxDecorations() already has code to do this
for transformed frames, so do the same thing when the frame is enclosed in a compositing layer.

Test: compositing/iframes/iframe-copy-on-scroll.html

  • rendering/RenderView.cpp: (WebCore::RenderView::paintBoxDecorations):
9:17 PM Changeset in webkit [59442] by tony@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-05-13 Tony Chang <​tony@chromium.org>

Reviewed by Kent Tamura.

[chromium] enable DRT build in chromium (for the last time)
​https://bugs.webkit.org/show_bug.cgi?id=39109

  • WebKit.gyp:
9:01 PM Changeset in webkit [59441] by tkent@chromium.org
  • 2 edits in trunk

Unreviewed. Move a ChangeLog entry inserted to a wrong file.

8:56 PM Changeset in webkit [59440] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

2010-05-13 Takeshi Yoshino <​tyoshino@google.com>

Reviewed by Kent Tamura.

Update text_expectations.txt for Chromium
fast/forms/input-text-paste-maxlength.html is flaky on Linux Debug
See ​http://code.google.com/p/chromium/issues/detail?id=44150 for detail.

  • platform/chromium/test_expectations.txt:
8:49 PM Changeset in webkit [59439] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

Update test_expectations.txt for Chromium.
fast/forms/implicit-submission.html is flaky on Linux.
See ​http://crbug.com/43890 for detail.

Patch by Takeshi Yoshino <​tyoshino@google.com> on 2010-05-13
Reviewed by Shinichiro Hamaji.

  • platform/chromium/test_expectations.txt:
7:25 PM Changeset in webkit [59438] by bweinstein@apple.com
  • 1 edit in trunk/WebKit/win/ChangeLog

Update the bug number in the ChangeLog that I just committed.

7:10 PM Changeset in webkit [59437] by mrowe@apple.com
  • 5 edits in branches/safari-533-branch

Versioning.

7:09 PM Changeset in webkit [59436] by Martin Robinson
  • 2 edits in trunk/LayoutTests

2010-05-13 Martin Robinson <​mrobinson@igalia.com>

No review.

[GTK] css1/color_and_background/background_attachment.html fails on the 32-bit debug bot
​https://bugs.webkit.org/show_bug.cgi?id=39101

  • platform/gtk/Skipped: Skip failing test.
7:09 PM Changeset in webkit [59435] by mrowe@apple.com
  • 1 copy in tags/Safari-533.9

New tag.

7:08 PM Changeset in webkit [59434] by bweinstein@apple.com
  • 5 edits in trunk/WebKit/win

<rdar://problem/7975410>

Reviewed by Tim Hatcher.

Allow reporting exceptions that occur when using JavaScriptCore APIs to the Web Inspector.

  • Interfaces/IWebViewPrivate.idl: Add a reportException function off of IWebViewPrivate.
  • Interfaces/WebKit.idl: Touch WebKit.idl to make sure Interfaces rebuild.
  • WebView.cpp:

(WebView::reportException): Make sure the function was called with a context from a WebView, and call

WebCore::reportException.

  • WebView.h:
7:08 PM Changeset in webkit [59433] by mrowe@apple.com
  • 5 edits in branches/safari-533-branch

Versioning.

6:52 PM Changeset in webkit [59432] by mrowe@apple.com
  • 5 edits in branches/safari-533-branch

Merge r59418.

6:51 PM Changeset in webkit [59431] by mrowe@apple.com
  • 3 edits in branches/safari-533-branch/WebCore

Merge r59330.

6:51 PM Changeset in webkit [59430] by mrowe@apple.com
  • 4 edits in branches/safari-533-branch/WebCore

Merge r59387.

6:51 PM Changeset in webkit [59429] by mrowe@apple.com
  • 2 edits in branches/safari-533-branch/WebCore

Merge r59417.

6:06 PM Changeset in webkit [59428] by Martin Robinson
  • 2 edits
    56 adds in trunk/LayoutTests

2010-05-13 Martin Robinson <​mrobinson@igalia.com>

No review. Finish adding css1 baselines for GTK+.

  • platform/gtk/Skipped: Unskip tests which now have baselines.
  • platform/gtk/css1/basic/class_as_selector-expected.txt:
  • platform/gtk/css1/box_properties/width-expected.txt: Added.
  • platform/gtk/css1/cascade/cascade_order-expected.txt: Added.
  • platform/gtk/css1/cascade/important-expected.txt: Added.
  • platform/gtk/css1/classification/display-expected.txt: Added.
  • platform/gtk/css1/classification/list_style-expected.txt: Added.
  • platform/gtk/css1/classification/list_style_image-expected.txt: Added.
  • platform/gtk/css1/classification/list_style_position-expected.txt: Added.
  • platform/gtk/css1/classification/list_style_type-expected.txt: Added.
  • platform/gtk/css1/classification/white_space-expected.txt: Added.
  • platform/gtk/css1/color_and_background/background-expected.txt: Added.
  • platform/gtk/css1/color_and_background/background_attachment-expected.txt: Added.
  • platform/gtk/css1/color_and_background/background_color-expected.txt: Added.
  • platform/gtk/css1/color_and_background/background_image-expected.txt: Added.
  • platform/gtk/css1/color_and_background/background_position-expected.txt: Added.
  • platform/gtk/css1/color_and_background/background_repeat-expected.txt: Added.
  • platform/gtk/css1/color_and_background/color-expected.txt: Added.
  • platform/gtk/css1/conformance/forward_compatible_parsing-expected.txt: Added.
  • platform/gtk/css1/font_properties/font-expected.txt: Added.
  • platform/gtk/css1/font_properties/font_family-expected.txt: Added.
  • platform/gtk/css1/font_properties/font_size-expected.txt: Added.
  • platform/gtk/css1/font_properties/font_style-expected.txt: Added.
  • platform/gtk/css1/font_properties/font_variant-expected.txt: Added.
  • platform/gtk/css1/font_properties/font_weight-expected.txt: Added.
  • platform/gtk/css1/formatting_model/canvas-expected.txt: Added.
  • platform/gtk/css1/formatting_model/floating_elements-expected.txt: Added.
  • platform/gtk/css1/formatting_model/height_of_lines-expected.txt: Added.
  • platform/gtk/css1/formatting_model/horizontal_formatting-expected.txt: Added.
  • platform/gtk/css1/formatting_model/inline_elements-expected.txt: Added.
  • platform/gtk/css1/formatting_model/replaced_elements-expected.txt: Added.
  • platform/gtk/css1/formatting_model/vertical_formatting-expected.txt: Added.
  • platform/gtk/css1/pseudo/anchor-expected.txt: Added.
  • platform/gtk/css1/pseudo/firstletter-expected.txt: Added.
  • platform/gtk/css1/pseudo/firstline-expected.txt: Added.
  • platform/gtk/css1/pseudo/multiple_pseudo_elements-expected.txt: Added.
  • platform/gtk/css1/pseudo/pseudo_elements_in_selectors-expected.txt: Added.
  • platform/gtk/css1/text_properties/letter_spacing-expected.txt: Added.
  • platform/gtk/css1/text_properties/line_height-expected.txt: Added.
  • platform/gtk/css1/text_properties/text_align-expected.txt: Added.
  • platform/gtk/css1/text_properties/text_decoration-expected.txt: Added.
  • platform/gtk/css1/text_properties/text_indent-expected.txt: Added.
  • platform/gtk/css1/text_properties/text_transform-expected.txt: Added.
  • platform/gtk/css1/text_properties/vertical_align-expected.txt: Added.
  • platform/gtk/css1/text_properties/word_spacing-expected.txt: Added.
  • platform/gtk/css1/units/color_units-expected.txt: Added.
  • platform/gtk/css1/units/length_units-expected.txt: Added.
  • platform/gtk/css1/units/percentage_units-expected.txt: Added.
  • platform/gtk/css1/units/urls-expected.txt: Added.
6:03 PM Changeset in webkit [59427] by mrowe@apple.com
  • 13 edits in branches/safari-533-branch/WebCore

Merge r59281.

6:03 PM Changeset in webkit [59426] by mrowe@apple.com
  • 7 edits
    1 copy
    1 add in branches/safari-533-branch

Merge r59381.

6:03 PM Changeset in webkit [59425] by mrowe@apple.com
  • 4 edits in branches/safari-533-branch/WebCore

Merge r59372.

6:03 PM Changeset in webkit [59424] by mrowe@apple.com
  • 2 edits in branches/safari-533-branch/WebKit/mac

Merge r59391.

6:03 PM Changeset in webkit [59423] by mrowe@apple.com
  • 3 edits in branches/safari-533-branch/WebCore

Merge r59374.

6:02 PM Changeset in webkit [59422] by mrowe@apple.com
  • 6 edits
    2 adds in branches/safari-533-branch

Merge r59384.

6:02 PM Changeset in webkit [59421] by mrowe@apple.com
  • 3 edits
    2 adds in branches/safari-533-branch

Merge r59351.

6:02 PM Changeset in webkit [59420] by mrowe@apple.com
  • 2 edits in branches/safari-533-branch/JavaScriptCore

Merge r59337.

5:04 PM Changeset in webkit [59419] by Martin Robinson
  • 2 edits in trunk/LayoutTests

2010-05-13 Martin Robinson <​mrobinson@igalia.com>

No review. Correcting baseline.

  • platform/gtk/css1/basic/class_as_selector-expected.txt: Correct baseline.
5:01 PM Changeset in webkit [59418] by timothy@apple.com
  • 5 edits in trunk

WebCore: Expose WebCore::reportException and WebCore::toJSDOMWindow symbols.

Reviewed by Sam Weinig.

  • WebCore.base.exp: Expose reportException and toJSDOMWindow.

WebKit/mac: Allow reporting exceptions that occur when using JavaScriptCore APIs
to the Web Inspector.

<rdar://problem/7975410>

Reviewed by Sam Weinig.

  • WebView/WebView.mm:

(+[WebView _reportException:inContext:]): Call WebCore::reportException after checking
that the global object is a DOMWindow.

  • WebView/WebViewPrivate.h: Added _reportException:inContext:.
4:59 PM Changeset in webkit [59417] by Joseph Pecoraro
  • 2 edits in trunk/WebCore

2010-05-13 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by Timothy Hatcher.

Web Inspector: Clearing Breakpoints Too Often
​https://bugs.webkit.org/show_bug.cgi?id=39094

Minor resets should preserve both workers and breakpoints.

  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype.reset):
4:58 PM Changeset in webkit [59416] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

Symbian build fix.

[Qt] Updated the def file with new exports.

  • symbian/eabi/QtWebKitu.def:
4:46 PM Changeset in webkit [59415] by mrowe@apple.com
  • 2 edits in branches/safari-533-branch/WebCore

Merge r59025.

4:46 PM Changeset in webkit [59414] by mrowe@apple.com
  • 3 edits in branches/safari-533-branch/WebCore

Merge r58954.

4:46 PM Changeset in webkit [59413] by mrowe@apple.com
  • 13 edits
    4 adds in branches/safari-533-branch

Merge r59243.

4:46 PM Changeset in webkit [59412] by mrowe@apple.com
  • 2 edits in branches/safari-533-branch/WebCore

Merge r59210.

4:46 PM Changeset in webkit [59411] by mrowe@apple.com
  • 10 edits in branches/safari-533-branch

Merge r59232.

4:46 PM Changeset in webkit [59410] by mrowe@apple.com
  • 5 edits in branches/safari-533-branch/WebCore

Merge r59239.

4:46 PM Changeset in webkit [59409] by mrowe@apple.com
  • 6 edits in branches/safari-533-branch/WebCore

Merge r59189.

4:46 PM Changeset in webkit [59408] by mrowe@apple.com
  • 3 edits in branches/safari-533-branch/WebCore

Merge r59186.

4:45 PM Changeset in webkit [59407] by mrowe@apple.com
  • 3 edits
    4 adds in branches/safari-533-branch

Merge r59199.

4:45 PM Changeset in webkit [59406] by mrowe@apple.com
  • 2 edits
    1 add in branches/safari-533-branch/WebCore

Merge r59263.

4:45 PM Changeset in webkit [59405] by mrowe@apple.com
  • 1 edit in branches/safari-533-branch/WebCore/ChangeLog

Merge r59242.

4:45 PM Changeset in webkit [59404] by mrowe@apple.com
  • 5 edits
    2 adds in branches/safari-533-branch

Merge r59241.

4:45 PM Changeset in webkit [59403] by mrowe@apple.com
  • 2 edits in branches/safari-533-branch/WebCore

Merge r59247.

4:45 PM Changeset in webkit [59402] by mrowe@apple.com
  • 3 edits in branches/safari-533-branch/JavaScriptCore

Merge r59202.

4:45 PM Changeset in webkit [59401] by mrowe@apple.com
  • 8 edits in branches/safari-533-branch/JavaScriptCore

Merge r59196.

4:45 PM Changeset in webkit [59400] by mrowe@apple.com
  • 15 edits
    1 add in branches/safari-533-branch

Merge r59187.

4:44 PM Changeset in webkit [59399] by mrowe@apple.com
  • 7 edits in branches/safari-533-branch

Merge r59336.

4:41 PM Changeset in webkit [59398] by Martin Robinson
  • 2 edits in trunk/LayoutTests

2010-05-13 Martin Robinson <​mrobinson@igalia.com>

No review needed.

[GTK] Some test results are one pixel different on x86_64
​https://bugs.webkit.org/show_bug.cgi?id=39022

  • platform/gtk/Skipped: Skipping this test because of single-pixel difference.
4:22 PM Changeset in webkit [59397] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

Unreviewed.

[Qt] Platform specific expected file updated after r59385.

Adding block elements to a block and removing them changes the height of the element.
​https://bugs.webkit.org/show_bug.cgi?id=38874

  • platform/qt/editing/deleting/5408255-expected.txt: updated.
4:14 PM Changeset in webkit [59396] by Simon Fraser
  • 14 edits
    1 copy
    2 adds in trunk

2010-05-13 Simon Fraser <Simon Fraser>

Reviewed by Dave Hyatt.

Fix scrolling in composited iframes
​https://bugs.webkit.org/show_bug.cgi?id=39088
<rdar://problem/7980099>

When propagating compositing out of iframes, we have to update the position of the iframe content
layers on scrolling.

Test: compositing/iframes/scrolling-iframe.html

  • page/FrameView.cpp: (WebCore::FrameView::scrollPositionChanged): Call updateContentLayerScrollPosition() when scrolling.
  • rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::updateGraphicsLayerGeometry): Renamed setRootPlatformLayerClippingBox() to updateContentLayerOffset().
  • rendering/RenderLayerCompositor.h:
  • rendering/RenderLayerCompositor.cpp: Rename m_clippingLayer to m_clipLayer to go better with m_scrollLayer. (WebCore::RenderLayerCompositor::updateContentLayerOffset): Renamed from setRootPlatformLayerClippingBox().

Set the size of the clipping layer from the FrameView now, so that scrollbars are not clipped out.
Update the scroll layer position too.

(WebCore::RenderLayerCompositor::updateContentLayerScrollPosition): Set the position of the scroll layer

when the ScrollView is scrolled.

(WebCore::RenderLayerCompositor::rootPlatformLayer): m_clippingLayer rename.
(WebCore::RenderLayerCompositor::ensureRootPlatformLayer): m_clippingLayer rename. Also create m_scrollLayer at

the same time as the clip layer, and clean it up as necessary.

(WebCore::RenderLayerCompositor::destroyRootPlatformLayer): m_clippingLayer rename, and clean up the m_scrollLayer too.
(WebCore::RenderLayerCompositor::detachRootPlatformLayer): m_clippingLayer rename

4:14 PM Changeset in webkit [59395] by Martin Robinson
  • 2 edits
    62 adds in trunk/LayoutTests

2010-05-13 Martin Robinson <​mrobinson@igalia.com>

No review. Adding baselines for many of the css1 tests. I've checked these manually.

  • platform/gtk/Skipped: Unskipping tests.
  • platform/gtk/css1/basic/class_as_selector-expected.txt: Added.
  • platform/gtk/css1/basic/comments-expected.txt: Added.
  • platform/gtk/css1/basic/containment-expected.txt: Added.
  • platform/gtk/css1/basic/contextual_selectors-expected.txt: Added.
  • platform/gtk/css1/basic/grouping-expected.txt: Added.
  • platform/gtk/css1/basic/id_as_selector-expected.txt: Added.
  • platform/gtk/css1/basic/inheritance-expected.txt: Added.
  • platform/gtk/css1/box_properties/acid_test-expected.txt: Added.
  • platform/gtk/css1/box_properties/border-expected.txt: Added.
  • platform/gtk/css1/box_properties/border_bottom-expected.txt: Added.
  • platform/gtk/css1/box_properties/border_bottom_inline-expected.txt: Added.
  • platform/gtk/css1/box_properties/border_bottom_width-expected.txt: Added.
  • platform/gtk/css1/box_properties/border_bottom_width_inline-expected.txt: Added.
  • platform/gtk/css1/box_properties/border_color-expected.txt: Added.
  • platform/gtk/css1/box_properties/border_color_inline-expected.txt: Added.
  • platform/gtk/css1/box_properties/border_inline-expected.txt: Added.
  • platform/gtk/css1/box_properties/border_left-expected.txt: Added.
  • platform/gtk/css1/box_properties/border_left_inline-expected.txt: Added.
  • platform/gtk/css1/box_properties/border_left_width-expected.txt: Added.
  • platform/gtk/css1/box_properties/border_left_width_inline-expected.txt: Added.
  • platform/gtk/css1/box_properties/border_right-expected.txt: Added.
  • platform/gtk/css1/box_properties/border_right_inline-expected.txt: Added.
  • platform/gtk/css1/box_properties/border_right_width-expected.txt: Added.
  • platform/gtk/css1/box_properties/border_right_width_inline-expected.txt: Added.
  • platform/gtk/css1/box_properties/border_style-expected.txt: Added.
  • platform/gtk/css1/box_properties/border_style_inline-expected.txt: Added.
  • platform/gtk/css1/box_properties/border_top-expected.txt: Added.
  • platform/gtk/css1/box_properties/border_top_inline-expected.txt: Added.
  • platform/gtk/css1/box_properties/border_top_width-expected.txt: Added.
  • platform/gtk/css1/box_properties/border_top_width_inline-expected.txt: Added.
  • platform/gtk/css1/box_properties/border_width-expected.txt: Added.
  • platform/gtk/css1/box_properties/border_width_inline-expected.txt: Added.
  • platform/gtk/css1/box_properties/clear-expected.txt: Added.
  • platform/gtk/css1/box_properties/clear_float-expected.txt: Added.
  • platform/gtk/css1/box_properties/float-expected.txt: Added.
  • platform/gtk/css1/box_properties/float_elements_in_series-expected.txt: Added.
  • platform/gtk/css1/box_properties/float_margin-expected.txt: Added.
  • platform/gtk/css1/box_properties/float_on_text_elements-expected.txt: Added.
  • platform/gtk/css1/box_properties/height-expected.txt: Added.
  • platform/gtk/css1/box_properties/margin-expected.txt: Added.
  • platform/gtk/css1/box_properties/margin_bottom-expected.txt: Added.
  • platform/gtk/css1/box_properties/margin_bottom_inline-expected.txt: Added.
  • platform/gtk/css1/box_properties/margin_inline-expected.txt: Added.
  • platform/gtk/css1/box_properties/margin_left-expected.txt: Added.
  • platform/gtk/css1/box_properties/margin_left_inline-expected.txt: Added.
  • platform/gtk/css1/box_properties/margin_right-expected.txt: Added.
  • platform/gtk/css1/box_properties/margin_right_inline-expected.txt: Added.
  • platform/gtk/css1/box_properties/margin_top-expected.txt: Added.
  • platform/gtk/css1/box_properties/margin_top_inline-expected.txt: Added.
  • platform/gtk/css1/box_properties/padding-expected.txt: Added.
  • platform/gtk/css1/box_properties/padding_bottom-expected.txt: Added.
  • platform/gtk/css1/box_properties/padding_bottom_inline-expected.txt: Added.
  • platform/gtk/css1/box_properties/padding_inline-expected.txt: Added.
  • platform/gtk/css1/box_properties/padding_left-expected.txt: Added.
  • platform/gtk/css1/box_properties/padding_left_inline-expected.txt: Added.
  • platform/gtk/css1/box_properties/padding_right-expected.txt: Added.
  • platform/gtk/css1/box_properties/padding_right_inline-expected.txt: Added.
  • platform/gtk/css1/box_properties/padding_top-expected.txt: Added.
  • platform/gtk/css1/box_properties/padding_top_inline-expected.txt: Added.
3:56 PM Changeset in webkit [59394] by weinig@apple.com
  • 2 edits in trunk/WebCore

Follow up to:
Fix for ​https://bugs.webkit.org/show_bug.cgi?id=38221
Memory issues due to the changes in 36556 (increased CSSPrimitiveValue size).
Part of <rdar://problem/7921275>

Reviewed by Anders Carlsson.

Fix failing tests on Leopard.

Initialize m_hasCachedCSSText in CSSPrimitiveValue::init methods.

  • css/CSSPrimitiveValue.cpp:

(WebCore::CSSPrimitiveValue::init):
(WebCore::CSSPrimitiveValue::cssText): Add extra assertion.

3:45 PM Changeset in webkit [59393] by Martin Robinson
  • 2 edits in trunk/LayoutTests

2010-05-13 Martin Robinson <​mrobinson@igalia.com>

No review. Rebaselining test after r59385.

  • platform/gtk/editing/deleting/delete-select-all-001-expected.txt: Rebaseline
3:39 PM Changeset in webkit [59392] by beidson@apple.com
  • 3 edits in trunk/LayoutTests

Adding fast/loader/recursive-before-unload-crash-expected.html to the gtk skipped list
because it needs more logging in its DRT to pass:

  • platform/gtk/Skipped:

Adding fast/loader/recursive-before-unload-crash-expected.html to the qt skipped list
because it's hanging:

  • platform/qt/Skipped:
3:39 PM Changeset in webkit [59391] by ap@apple.com
  • 2 edits in trunk/WebKit/mac

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=39089
<rdar://problem/7974044> Domain names in Russian '.рф' domain are displayed as punycode

Add a custom check for this domain. Currently, this is the only non-ASCII TLD, we'll
investigate a more extensible solution when there are more, and we know what the
typical restictions are.

  • Misc/WebNSURLExtras.mm: (allCharactersAllowedByTLDRules): (-[NSString _web_mapHostNameWithRange:encode:makeString:]):
3:33 PM Changeset in webkit [59390] by tkent@chromium.org
  • 3 edits
    2 adds in trunk

2010-05-13 Kent Tamura <​tkent@chromium.org>

Reviewed by Darin Adler.

Can't submit a form with <input type=checkbox required>
​https://bugs.webkit.org/show_bug.cgi?id=39065

  • fast/forms/interactive-validation-required-checkbox-expected.txt: Added.
  • fast/forms/interactive-validation-required-checkbox.html: Added.

2010-05-13 Kent Tamura <​tkent@chromium.org>

Reviewed by Darin Adler.

Can't submit a form with <input type=checkbox required>
​https://bugs.webkit.org/show_bug.cgi?id=39065

Test: fast/forms/interactive-validation-required-checkbox.html

  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::setChecked): Update the validity cache when a checkbox state is changed.
3:12 PM Changeset in webkit [59389] by beidson@apple.com
  • 1 edit
    1 copy in trunk/LayoutTests

​https://bugs.webkit.org/show_bug.cgi?id=38928

Reviewed by NOBODY (Layout test fix)

Add Tiger specific results for my new test.

  • platform/mac-tiger/fast/loader/recursive-before-unload-crash-expected.txt: Copied from fast/loader/recursive-before-unload-crash-expected.txt.
3:07 PM Changeset in webkit [59388] by kbr@google.com
  • 12 edits in trunk

2010-05-13 Kenneth Russell <​kbr@google.com>

Reviewed by Dimitri Glazkov.

Alias WebGLArray type names to TypedArray type names
​https://bugs.webkit.org/show_bug.cgi?id=39036

Exposed the existing WebGL<T>Array constructor functions on the
DOMWindow under the naming convention in the TypedArray spec. The
implementations will be renamed in a subsequent bug, and the
aliases to the WebGL<T>Array type names eventually removed. Ran
all layout tests (including WebGL) in Safari, and WebGL tests in
Chromium.

Test: revised array-unit-tests.html to test both type names.
Revised global prototype and constructor tests to ignore new types.

  • bindings/generic/RuntimeEnabledFeatures.h: (WebCore::RuntimeEnabledFeatures::arrayBufferEnabled): (WebCore::RuntimeEnabledFeatures::int8ArrayEnabled): (WebCore::RuntimeEnabledFeatures::uint8ArrayEnabled): (WebCore::RuntimeEnabledFeatures::int16ArrayEnabled): (WebCore::RuntimeEnabledFeatures::uint16ArrayEnabled): (WebCore::RuntimeEnabledFeatures::int32ArrayEnabled): (WebCore::RuntimeEnabledFeatures::uint32ArrayEnabled): (WebCore::RuntimeEnabledFeatures::floatArrayEnabled):
  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::arrayBuffer): (WebCore::JSDOMWindow::int8Array): (WebCore::JSDOMWindow::uint8Array): (WebCore::JSDOMWindow::int32Array): (WebCore::JSDOMWindow::uint32Array): (WebCore::JSDOMWindow::int16Array): (WebCore::JSDOMWindow::uint16Array): (WebCore::JSDOMWindow::floatArray):
  • bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::V8DOMWindow::ArrayBufferAccessorGetter): (WebCore::V8DOMWindow::Int8ArrayAccessorGetter): (WebCore::V8DOMWindow::Uint8ArrayAccessorGetter): (WebCore::V8DOMWindow::Int16ArrayAccessorGetter): (WebCore::V8DOMWindow::Uint16ArrayAccessorGetter): (WebCore::V8DOMWindow::Int32ArrayAccessorGetter): (WebCore::V8DOMWindow::Uint32ArrayAccessorGetter): (WebCore::V8DOMWindow::FloatArrayAccessorGetter):
  • page/DOMWindow.idl:

2010-05-13 Kenneth Russell <​kbr@google.com>

Reviewed by Dimitri Glazkov.

Alias WebGLArray type names to TypedArray type names
​https://bugs.webkit.org/show_bug.cgi?id=39036

Exposed the existing WebGL<T>Array constructor functions on the
DOMWindow under the naming convention in the TypedArray spec. The
implementations will be renamed in a subsequent bug, and the
aliases to the WebGL<T>Array type names eventually removed. Ran
all layout tests (including WebGL) in Safari, and WebGL tests in
Chromium.

Test: revised array-unit-tests.html to test both type names.
Revised global prototype and constructor tests to ignore new types.

  • fast/canvas/webgl/array-unit-tests-expected.txt:
  • fast/canvas/webgl/array-unit-tests.html:
  • fast/dom/Window/script-tests/window-property-descriptors.js:
  • fast/dom/Window/window-properties.html:
  • fast/dom/script-tests/prototype-inheritance.js:
  • fast/js/script-tests/global-constructors.js:
2:51 PM Changeset in webkit [59387] by hyatt@apple.com
  • 4 edits in trunk/WebCore

​https://bugs.webkit.org/show_bug.cgi?id=39084

Reviewed by Anders Carlsson.

Improve :visited style resolution to reduce its memory footprint and to make some speed adjustments and
simplifications.

(1) Tie the caching of link state on CSSStyleSelector to the element. Just clear out the element when
style resolution finishes for the unvisited case to avoid caching across external calls. The internal
calls share the cache just fine by doing this.

(2) Delete the RenderStyle if the link is unvisited. This shouldn't take long enough to make us vulnerable
to timing attacks, and it makes sure the overall footprint stays the way it used to be for unvisited links.

(3) Limit the set of properties that can be applied to :visited links to only the colors it supports. This
stops images from being loadable from :visited rules.

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::init):
(WebCore::CSSStyleSelector::SelectorChecker::determineLinkState):
(WebCore::CSSStyleSelector::initElement):
(WebCore::CSSStyleSelector::canShareStyleWithElement):
(WebCore::CSSStyleSelector::styleForElement):
(WebCore::CSSStyleSelector::pseudoStyleForElement):
(WebCore::isValidVisitedLinkProperty):
(WebCore::CSSStyleSelector::applyProperty):

  • css/CSSStyleSelector.h:
  • rendering/style/RenderStyle.cpp:

(WebCore::colorIncludingFallback):

2:32 PM Changeset in webkit [59386] by weinig@apple.com
  • 4 edits in trunk/WebCore

Fix for ​https://bugs.webkit.org/show_bug.cgi?id=38221
Memory issues due to the changes in 36556 (increased CSSPrimitiveValue size).
Part of <rdar://problem/7921275>

Reviewed by Darin Adler.

  • Use an external cache to speedup cssText for CSSPrimitiveValue instead of an extra member variable.
  • css/CSSPrimitiveValue.cpp:

(WebCore::cssTextCache):
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::cleanup):
(WebCore::CSSPrimitiveValue::cssText):

  • css/CSSPrimitiveValue.h:

(WebCore::CSSPrimitiveValue::):

  • css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):

1:48 PM Changeset in webkit [59385] by enrica@apple.com
  • 8 edits
    2 adds in trunk

Adding block elements to a block and removing them changes the height of the element.
​https://bugs.webkit.org/show_bug.cgi?id=38874

Reviewed by Dave Hyatt.

WebCore:

The initial height of an empty editable block is different from the height of the same block after we add block elements
and remove them.

Test: editing/deleting/delete-block-contents-004.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::layoutBlock): resetting m_childrenInline flag to true when layout a block with no children.

LayoutTests:

The initial height of an empty editable block is different from the height of the same block after we add block elements
and remove them.

  • editing/deleting/delete-block-contents-004-expected.txt: Added.
  • editing/deleting/delete-block-contents-004.html: Added.

The following tests results have been updated to reflect the new renderer structure.

  • editing/deleting/in-visibly-empty-root-expected.txt:
  • platform/mac/editing/deleting/5408255-expected.txt:
  • platform/mac/editing/deleting/delete-select-all-001-expected.txt:
  • platform/mac/editing/selection/4895428-1-expected.txt:
  • platform/mac/editing/selection/4895428-4-expected.txt:
1:31 PM Changeset in webkit [59384] by beidson@apple.com
  • 6 edits
    2 adds in trunk

Repro crash at www.sears.com (infinite recursion in beforeunload handler)
<rdar://problem/7965182> and ​https://bugs.webkit.org/show_bug.cgi?id=38928

Reviewed by Darin Adler.

WebCore:

Test: fast/loader/recursive-before-unload-crash.html

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::shouldClose): Copied from Frame, with the pageDismissal flag set.

  • loader/FrameLoader.h:
  • page/Frame.cpp:

(WebCore::Frame::shouldClose): Forward to the new FrameLoader::shouldClose().

  • page/Frame.h:

(WebCore::Frame::existingDOMWindow):

LayoutTests:

  • fast/loader/recursive-before-unload-crash-expected.txt: Added.
  • fast/loader/recursive-before-unload-crash.html: Added.
1:06 PM Changeset in webkit [59383] by eric@webkit.org
  • 8 edits in trunk

2010-05-13 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r59376.
​http://trac.webkit.org/changeset/59376
​https://bugs.webkit.org/show_bug.cgi?id=39080

Broke window prototype tests (Requested by jamesr on #webkit).

  • fast/canvas/webgl/array-unit-tests-expected.txt:
  • fast/canvas/webgl/array-unit-tests.html:

2010-05-13 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r59376.
​http://trac.webkit.org/changeset/59376
​https://bugs.webkit.org/show_bug.cgi?id=39080

Broke window prototype tests (Requested by jamesr on #webkit).

  • bindings/generic/RuntimeEnabledFeatures.h:
  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::webGLFloatArray):
  • bindings/v8/custom/V8DOMWindowCustom.cpp:
  • page/DOMWindow.idl:
12:35 PM Changeset in webkit [59382] by diegohcg@webkit.org
  • 2 edits in trunk/WebKitTools

2010-05-13 Diego Gonzalez <​diegohcg@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Improve QtLauncher user agent dialog resize
​https://bugs.webkit.org/show_bug.cgi?id=39062

  • QtLauncher/main.cpp: (LauncherWindow::showUserAgentDialog):
12:24 PM Changeset in webkit [59381] by pfeldman@chromium.org
  • 7 edits
    1 copy
    1 add in trunk

2010-05-13 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: A disabled style property cannot be deleted.

​https://bugs.webkit.org/show_bug.cgi?id=39057

  • inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::applyStyleText):

2010-05-13 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: A disabled style property cannot be deleted.

​https://bugs.webkit.org/show_bug.cgi?id=39057

  • inspector/elements-tests.js: (frontend_getSelectedElementStyles):
  • inspector/styles-disable-then-delete-expected.txt: Added.
  • inspector/styles-disable-then-delete.html: Added.
  • inspector/styles-disable-then-enable.html:
12:15 PM Changeset in webkit [59380] by diegohcg@webkit.org
  • 2 edits in trunk/WebKit/qt

2010-05-11 Diego Gonzalez <​diegohcg@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] tst_QWebPage::inputMethods failing on Maemo5
​https://bugs.webkit.org/show_bug.cgi?id=38685

Check if the SIP (Software Input Panel) is triggered, which usually happens
in the case of a mobile platforms, an user input form receives a mouse click.

  • tests/qwebpage/tst_qwebpage.cpp: (tst_QWebPage::inputMethods):
12:08 PM Changeset in webkit [59379] by eric@webkit.org
  • 3 edits in trunk/WebKitTools

2010-05-13 Eric Seidel <​eric@webkit.org>

Reviewed by Ojan Vafai.

Disable compositing/iframes tests on the commit-queue as a workaround for bug 38912
​https://bugs.webkit.org/show_bug.cgi?id=39067

Fix yet another typo in my original hack.
I also added another unit test for this fix.

  • Scripts/webkitpy/common/config/ports.py:
  • Scripts/webkitpy/common/config/ports_unittest.py:
11:59 AM Changeset in webkit [59378] by tonikitoo@webkit.org
  • 2 edits in trunk/WebKit/qt

[Qt] REGRESSION(r58497) tst_QGraphicsWebView::crashOnViewlessWebPages() is failing
​https://bugs.webkit.org/show_bug.cgi?id=38655

Patch by Kenneth Rohde Christiansen <​kenneth@webkit.org> on 2010-05-11
Reviewed by Laszlo Gombos.

Fix double free by moving the connect till after the resize.

The bug is causes by the fact that a resize of an empty page causes a
layout, thus deleting the qgraphicswebview before setHtml is called,
which then deletes it again, causing a double free.

  • tests/qgraphicswebview/tst_qgraphicswebview.cpp:

(tst_QGraphicsWebView::crashOnViewlessWebPages):

11:54 AM Changeset in webkit [59377] by tonikitoo@webkit.org
  • 2 edits in trunk/WebKit/qt

Regression(r59152): QGraphicsPageClient is not forwarding scroll and update events to view ​https://bugs.webkit.org/show_bug.cgi?id=39016

Patch by Kenneth Rohde Christiansen <​kenneth@webkit.org> on 2010-05-12
Reviewed by Laszlo Gombos.

Some forward calls got lost during the refatory.

  • WebCoreSupport/PageClientQt.cpp:

(WebCore::PageClientQGraphicsWidget::scroll):
(WebCore::PageClientQGraphicsWidget::update):

11:51 AM Changeset in webkit [59376] by kbr@google.com
  • 8 edits in trunk

2010-05-12 Kenneth Russell <​kbr@google.com>

Reviewed by Dimitri Glazkov.

Alias WebGLArray type names to TypedArray type names
​https://bugs.webkit.org/show_bug.cgi?id=39036

Exposed the existing WebGL<T>Array constructor functions on the
DOMWindow under the naming convention in the TypedArray spec. The
implementations will be renamed in a subsequent bug, and the
aliases to the WebGL<T>Array type names eventually removed. Ran
all WebGL layout tests in Safari and Chromium.

Test: revised array-unit-tests.html to test both type names.

  • bindings/generic/RuntimeEnabledFeatures.h: (WebCore::RuntimeEnabledFeatures::arrayBufferEnabled): (WebCore::RuntimeEnabledFeatures::int8ArrayEnabled): (WebCore::RuntimeEnabledFeatures::uint8ArrayEnabled): (WebCore::RuntimeEnabledFeatures::int16ArrayEnabled): (WebCore::RuntimeEnabledFeatures::uint16ArrayEnabled): (WebCore::RuntimeEnabledFeatures::int32ArrayEnabled): (WebCore::RuntimeEnabledFeatures::uint32ArrayEnabled): (WebCore::RuntimeEnabledFeatures::floatArrayEnabled):
  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::arrayBuffer): (WebCore::JSDOMWindow::int8Array): (WebCore::JSDOMWindow::uint8Array): (WebCore::JSDOMWindow::int32Array): (WebCore::JSDOMWindow::uint32Array): (WebCore::JSDOMWindow::int16Array): (WebCore::JSDOMWindow::uint16Array): (WebCore::JSDOMWindow::floatArray):
  • bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::V8DOMWindow::ArrayBufferAccessorGetter): (WebCore::V8DOMWindow::Int8ArrayAccessorGetter): (WebCore::V8DOMWindow::Uint8ArrayAccessorGetter): (WebCore::V8DOMWindow::Int16ArrayAccessorGetter): (WebCore::V8DOMWindow::Uint16ArrayAccessorGetter): (WebCore::V8DOMWindow::Int32ArrayAccessorGetter): (WebCore::V8DOMWindow::Uint32ArrayAccessorGetter): (WebCore::V8DOMWindow::FloatArrayAccessorGetter):
  • page/DOMWindow.idl:

2010-05-12 Kenneth Russell <​kbr@google.com>

Reviewed by Dimitri Glazkov.

Alias WebGLArray type names to TypedArray type names
​https://bugs.webkit.org/show_bug.cgi?id=39036

Exposed the existing WebGL<T>Array constructor functions on the
DOMWindow under the naming convention in the TypedArray spec. The
implementations will be renamed in a subsequent bug, and the
aliases to the WebGL<T>Array type names eventually removed. Ran
all WebGL layout tests in Safari and Chromium.

Test: revised array-unit-tests.html to test both type names.

  • fast/canvas/webgl/array-unit-tests-expected.txt:
  • fast/canvas/webgl/array-unit-tests.html:
11:44 AM BuildingQtOnLinux edited by ikipou@gmail.com
Update the minimal verison of Qt required to compile WebKit (diff)
11:33 AM Changeset in webkit [59375] by eric@webkit.org
  • 4 edits in trunk/WebKitTools

2010-05-13 Eric Seidel <​eric@webkit.org>

Reviewed by Ojan Vafai.

Disable compositing/iframes tests on the commit-queue as a workaround for bug 38912
​https://bugs.webkit.org/show_bug.cgi?id=39067

My previous (unreviewed) hack didn't actually work due to checking "mac" instead of "Mac".
This change fixes my hack, and unit tests it.

  • Scripts/webkitpy/tool/mocktool.py:
    • Make it possible to make run_command log too.
  • Scripts/webkitpy/tool/steps/runtests.py:
    • Fix my hack to actually work.
  • Scripts/webkitpy/tool/steps/steps_unittest.py:
    • Test my hack (and basic RunTests behavior as well).
11:17 AM Changeset in webkit [59374] by beidson@apple.com
  • 3 edits in trunk/WebCore

Part of <rdar://problem/7965182> and ​https://bugs.webkit.org/show_bug.cgi?id=38928

Reviewed by John Sullivan.

No new tests. (No change in behavior)

m_unloadEventBeingDispatched was already overloaded to include both unload and pagehide events.
In general, these are "page dismissal" events, and might also include beforeunload, so let's rename
the flag!

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::FrameLoader):
(WebCore::FrameLoader::stopLoading):
(WebCore::FrameLoader::loadURL):
(WebCore::FrameLoader::loadWithDocumentLoader):
(WebCore::FrameLoader::stopAllLoaders):
(WebCore::FrameLoader::continueLoadAfterNavigationPolicy):
(WebCore::FrameLoader::pageHidden):

  • loader/FrameLoader.h:
10:59 AM Changeset in webkit [59373] by tonikitoo@webkit.org
  • 8 edits in trunk

2010-05-13 Antonio Gomes <​tonikitoo@webkit.org>, Yi Shen <​yi.4.shen@nokia.com>

Reviewed by Kenneth Christiansen.

[Qt] Add LayoutTestController interface: computedStyleIncludingVisitedInfo
​https://bugs.webkit.org/show_bug.cgi?id=37759

WebKit/qt:

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::markerTextForListItem): (DumpRenderTreeSupportQt::computedStyleIncludingVisitedInfo):
  • WebCoreSupport/DumpRenderTreeSupportQt.h:

WebKitTools:

  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::computedStyleIncludingVisitedInfo):
  • DumpRenderTree/qt/LayoutTestControllerQt.h:

LayoutTests:

  • platform/qt/Skipped:
10:57 AM UsingGitWithWebKit edited by ojan@chromium.org
(diff)
10:55 AM UsingGitWithWebKit edited by ojan@chromium.org
(diff)
10:27 AM Changeset in webkit [59372] by Joseph Pecoraro
  • 4 edits in trunk/WebCore

2010-05-13 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by Pavel Feldman.

Web Inspector: Event Markers should be hidden in Resource's "Size" Graph
​https://bugs.webkit.org/show_bug.cgi?id=39074

Added Show / Hide event dividers functionality to the timeline grid,
and included delegation functions in AbstractTimelinePanel.

  • inspector/front-end/AbstractTimelinePanel.js: delegate to the inner grid (WebInspector.AbstractTimelinePanel.prototype.hideEventDividers): (WebInspector.AbstractTimelinePanel.prototype.showEventDividers):
  • inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype.populateSidebar): save a reference to the size graph item to know when its selected (WebInspector.ResourcesPanel.prototype._graphSelected): if the size graph is selected hide the dividers, otherwise show them
  • inspector/front-end/TimelineGrid.js: (WebInspector.TimelineGrid.prototype.hideEventDividers): set the container to display: none (WebInspector.TimelineGrid.prototype.showEventDividers): set the container to display: block
10:08 AM Changeset in webkit [59371] by Adam Roben
  • 5 edits in trunk/WebKitTools

Convert status bar text to UTF-8 before logging it on Windows

We were previously logging the text using printf("%S", bstr). This
converts the UTF-16 BSTR to a multibyte string using wctomb, which
uses the codepage for the current locale to perform the conversion.
The conversion was failing, causing printf to bail and truncate the
string. By converting to UTF-8 manually before logging, we avoid this
issue (and also end up with UTF-8 output, which is what the expected
results contain). We may have to do this in other places in DRT,
eventually.

Fixes <​http://webkit.org/b/38849> REGRESSION (r59016):
plugins/set-status.html fails on Windows

Reviewed by Alexey Proskuryakov.

  • DumpRenderTree/win/DumpRenderTree.cpp:

(toUTF8): Moved this here from FrameLoadDelegate. Renamed from
BSTRtoString.

  • DumpRenderTree/win/DumpRenderTreeWin.h: Added declaration of toUTF8.
  • DumpRenderTree/win/FrameLoadDelegate.cpp: Removed BSTRtoString.

(descriptionSuitableForTestResult): Updated for rename.

  • DumpRenderTree/win/UIDelegate.cpp:

(UIDelegate::setStatusText): Convert the status bar text to UTF-8
before logging it so that Windows won't try (and fail) to convert it
to the current locale's codepage.

10:07 AM Changeset in webkit [59370] by Adam Roben
  • 2 edits in trunk/SunSpider

Fix typo in sunspider-compare-results.js that caused incorrect two-sample t statistics to be computed

Fixes <​http://webkit.org/b/38768> SunSpider computes incorrect
two-sample t statistics

Reviewed by Darin Adler.

  • resources/sunspider-compare-results.js:

(sunspiderCompareResults.resultLine): Fixed the calculation of the t
variable to match the definition of a two-sample t statistic. Looks
like this was just a simple typo.

8:35 AM Changeset in webkit [59369] by Martin Robinson
  • 2 edits in trunk/LayoutTests

2010-05-13 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Gustavo Noronha.

Events tests failing
​https://bugs.webkit.org/show_bug.cgi?id=31436

Unskip these two test which are now passing.

  • platform/gtk/Skipped: Unskip two tests.
8:34 AM Changeset in webkit [59368] by pfeldman@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-05-13 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: main inspector toolbar takes noticeable time to expand.

​https://bugs.webkit.org/show_bug.cgi?id=39013

  • src/js/DevTools.js: (devtools.domContentLoaded):
8:21 AM Changeset in webkit [59367] by Martin Robinson
  • 2 edits in trunk/LayoutTests

2010-05-13 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Gustavo Noronha.

Two forms tests failing
​https://bugs.webkit.org/show_bug.cgi?id=31435

Unskip passing tests.

  • platform/gtk/Skipped: Unskip these tests, because they are passing now.
7:56 AM Changeset in webkit [59366] by chang.shu@nokia.com
  • 2 edits in trunk/WebCore

2010-05-13 Chang Shu <​chang.shu@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

Based on the spec and Philip Taylor's test suite, strokeStyle and fillStyle attributes
must initially have the string value #000000.
The link to the spec:
​http://philip.html5.org/tests/canvas/suite/tests/spec.html#testrefs.2d.colours.default

​https://bugs.webkit.org/show_bug.cgi?id=39068

The complete test suite is in the process of checking in.
​https://bugs.webkit.org/show_bug.cgi?id=20553

  • html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::State::State):
7:41 AM Changeset in webkit [59365] by yurys@chromium.org
  • 17 edits
    3 deletes in trunk/WebCore

2010-05-13 Yury Semikhatsky <​yurys@chromium.org>

Unreviewed, rolling out r59360.
​http://trac.webkit.org/changeset/59360
​https://bugs.webkit.org/show_bug.cgi?id=38667

It broke Chromium Win build

  • English.lproj/localizedStrings.js:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/front-end/CallStackSidebarPane.js: (WebInspector.CallStackSidebarPane): (WebInspector.CallStackSidebarPane.prototype._placardSelected):
  • inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView):
  • inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel):
  • inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeOutline.prototype._keyDown):
  • inspector/front-end/HelpScreen.js: Removed.
  • inspector/front-end/KeyboardShortcut.js: (WebInspector.KeyboardShortcut._makeKeyFromCodeAndModifiers):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel): (WebInspector.ScriptsPanel.prototype.elementsToRestoreScrollPositionsFor):
  • inspector/front-end/ShortcutsHelp.js: Removed.
  • inspector/front-end/SidebarPane.js: (WebInspector.SidebarPane.prototype._onTitleKeyDown):
  • inspector/front-end/StylesSidebarPane.js: (WebInspector.StylesSidebarPane.prototype.removeSection):
  • inspector/front-end/TextViewer.js: (WebInspector.TextViewer.prototype._handleKeyDown):
  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/helpScreen.css: Removed.
  • inspector/front-end/inspector.html:
  • inspector/front-end/inspector.js: (WebInspector.loaded): (WebInspector.documentKeyDown): (WebInspector._searchKeyDown): (WebInspector.startEditing.keyDownEventListener): (WebInspector.startEditing):
  • inspector/front-end/utilities.js:
7:39 AM Changeset in webkit [59364] by eric@webkit.org
  • 3 edits in trunk/WebKitTools

2010-05-13 Eric Seidel <​eric@webkit.org>

Unreviewed hack, attempting to get the commit-queue running again.

Disable compositing/iframes tests on the commit-queue as a workaround for bug 38912
​https://bugs.webkit.org/show_bug.cgi?id=39067

I had this hack locally on the commit-queue, but it's fragile
and broke this morning. It will work much better if committed
to the repository. In either case it's temporary while we
work up a real fix for bug 38912.

  • Scripts/webkitpy/common/config/ports.py:
    • Expose an is_leopard() method.
  • Scripts/webkitpy/tool/steps/runtests.py:
    • Don't run compositing/iframes tests on the commit-queue under leopard.
7:35 AM Changeset in webkit [59363] by antti.j.koivisto@nokia.com
  • 2 edits in trunk/WebCore

​https://bugs.webkit.org/show_bug.cgi?id=39063
[Qt] Tiled backing store checker pattern does not paint correctly when scaling factor is not 1

Reviewed by Kenneth Rohde Christiansen.

Use the dirty rect that has been adjusted for scaling instead of the original one.

  • platform/graphics/TiledBackingStore.cpp:

(WebCore::TiledBackingStore::paint):

7:07 AM Changeset in webkit [59362] by chang.shu@nokia.com
  • 2 edits in trunk/WebCore

2010-05-13 Chang Shu <​chang.shu@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

Based on Philip Taylor's test suite, resetting the canvas
state resets the current path.
​https://bugs.webkit.org/show_bug.cgi?id=38934

The complete test suite is in the process of checking in.
​https://bugs.webkit.org/show_bug.cgi?id=20553

  • html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::reset):
6:48 AM Changeset in webkit [59361] by yurys@chromium.org
  • 8 edits
    1 delete in trunk/LayoutTests

2010-05-13 Yury Semikhatsky <​yurys@chromium.org>

Unreviewed. Chromium build fix. Partially rever r59277 which updated Chromium's expectations
after r59270. r59270 was reverted, so we need to revert Chromium's expectations.

  • platform/chromium-linux/editing/deleting/5408255-expected.checksum:
  • platform/chromium-mac/editing/deleting/5408255-expected.checksum: Removed.
  • platform/chromium-win/editing/deleting/5408255-expected.checksum:
  • platform/chromium-win/editing/deleting/5408255-expected.txt:
  • platform/chromium-win/editing/deleting/delete-select-all-001-expected.txt:
  • platform/chromium-win/editing/selection/4895428-1-expected.txt:
  • platform/chromium-win/editing/selection/4895428-4-expected.txt:
  • platform/chromium-win/fast/events/mouseout-dead-node-expected.txt:
6:42 AM Changeset in webkit [59360] by pfeldman@chromium.org
  • 17 edits
    3 adds in trunk/WebCore

2010-05-13 Andrey Kosyakov <​caseq@chromium.org>

Reviewed by Pavel Feldman.

Added help screen with keyboard shortcuts.
​https://bugs.webkit.org/show_bug.cgi?id=38667

  • English.lproj/localizedStrings.js:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/front-end/CallStackSidebarPane.js: (WebInspector.CallStackSidebarPane): (WebInspector.CallStackSidebarPane.prototype._placardSelected): (WebInspector.CallStackSidebarPane.prototype.registerShortcuts):
  • inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView): (WebInspector.ConsoleView.prototype._registerShortcuts):
  • inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel): (WebInspector.ElementsPanel.prototype._registerShortcuts):
  • inspector/front-end/HelpScreen.js: Added.
  • inspector/front-end/KeyboardShortcut.js: (WebInspector.KeyboardShortcut.makeDescriptor): (WebInspector.KeyboardShortcut.shortcutToString): (WebInspector.KeyboardShortcut._modifiersToString):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel): (WebInspector.ScriptsPanel.prototype.elementsToRestoreScrollPositionsFor): (WebInspector.ScriptsPanel.prototype._registerShortcuts):
  • inspector/front-end/ShortcutsHelp.js: Added.
  • inspector/front-end/StylesSidebarPane.js: (WebInspector.StylesSidebarPane.prototype.removeSection): (WebInspector.StylesSidebarPane.prototype.registerShortcuts):
  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/helpScreen.css: Added.
5:12 AM Changeset in webkit [59359] by hamaji@chromium.org
  • 2 edits in trunk

2010-05-13 Takeshi Yoshino <​tyoshino@google.com>

Reviewed by Shinichiro Hamaji.

Update test_expectations.txt for Chromium.
fast/forms/implicit-submission.html is flaky on Linux.
See ​http://crbug.com/43890 for detail.

  • platform/chromium/test_expectations.txt:
5:05 AM Changeset in webkit [59358] by mjs@apple.com
  • 2 edits in trunk/JavaScriptCore

No review, attempted build fix.

Try to fix Tiger build with some gratuitous initialization of
seemingly uninitialized variables.

  • wtf/text/StringImpl.h:

(WebCore::StringImpl::tryCreateUninitialized):

2:43 AM Changeset in webkit [59357] by hamaji@chromium.org
  • 3 edits
    2 adds in trunk

2010-05-13 Yoshiki Hayashi <​yhayashi@google.com>

Reviewed by Darin Adler.

Fix a bug in handleRunInChild where only the first child run-in block
is inserted because removeChildNode clears next sibling.
​https://bugs.webkit.org/show_bug.cgi?id=25047

  • fast/css/run-in-children-expected.txt: Added.
  • fast/css/run-in-children.html: Added.

2010-05-13 Yoshiki Hayashi <​yhayashi@google.com>

Reviewed by Darin Adler.

Fix a bug in handleRunInChild where only the first child run-in block
is inserted because removeChildNode clears next sibling.
​https://bugs.webkit.org/show_bug.cgi?id=25047

Test: fast/css/run-in-children.html

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::handleRunInChild):
2:37 AM Changeset in webkit [59356] by alex
  • 2 edits in trunk/WebCore

2010-05-13 Alejandro G. Castro <​alex@igalia.com>

Reviewed by Xan Lopez.

In case there is no expose event we render the theme in a pixmap
and copy it to the cairo context. This is slow but it is used just
in case we are printing nowadays.

[GTK] Theme does not render when printing
​https://bugs.webkit.org/show_bug.cgi?id=38896

  • platform/gtk/RenderThemeGtk.cpp: (WebCore::paintMozillaGtkWidget):
2:36 AM Changeset in webkit [59355] by mjs@apple.com
  • 5 edits in trunk/JavaScriptCore

2010-05-13 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Mark Rowe.

Various JavaScript string optimizations
​https://bugs.webkit.org/show_bug.cgi?id=39051

Approximately 1% SunSpider speedup.


  • runtime/ArrayPrototype.cpp: (JSC::arrayProtoFuncJoin): Remove branches from the hot code path by moving the first pass outside the loop, and duplicating the hot loop to extract the loop-invariant branch.
  • runtime/RegExp.cpp: (JSC::RegExp::match): resize ovector to 0 instead of clearing to avoid thrash in case of large matches.
  • runtime/RegExpConstructor.h: (JSC::RegExpConstructor::performMatch): Mark ALWAYS_INLINE to make the compiler respect our authority.
  • runtime/StringPrototype.cpp: (JSC::jsSpliceSubstringsWithSeparators): Inline. (JSC::stringProtoFuncSubstring): Rewrite boundary condition checks to reduce the number of floating point comparisons and branches.
1:52 AM Changeset in webkit [59354] by ukai@chromium.org
  • 3 edits in trunk

WebKitTools: Unreviewed fix. Revert previous change.

Even if with-statments are changed in websocket_server.py, it also claims syntax error for with statement in http_server.py.
Until python 2.5 is installed on tiger bot, skips websocket/tests on tiger.

  • Scripts/webkitpy/layout_tests/port/websocket_server.py: use with statement

LayoutTests: Unreviewed.

Skip websocket/tests on tiger, until Python 2.5 is installed on tiger bot.

  • platform/mac-tiger/Skipped: Add websocket/tests
1:52 AM Changeset in webkit [59353] by ukai@chromium.org
  • 2 edits in trunk/WebKitTools

WebSocket: pywebsocket 0.5
​https://bugs.webkit.org/show_bug.cgi?id=38034

Reviewed by David Levin.

Remove pywebsocket from webkitpy/thirdparty.
Make pywebsocket autoinstalled.

  • Scripts/new-run-webkit-websocketserver: Add --output-dir option.
  • Scripts/old-run-webkit-tests: Use new-run-webkit-websocketserver, rather than directly run pywebsocket's standalone.py
  • Scripts/run-webkit-websocketserver: Ditto.
  • Scripts/webkitpy/layout_tests/port/websocket_server.py: Use autoinstalled pywebsocket.
  • Scripts/webkitpy/thirdparty/init.py: Autoinstall pywebsocket
  • Scripts/webkitpy/thirdparty/pywebsocket: Removed.
1:21 AM Changeset in webkit [59352] by ukai@chromium.org
  • 2 edits in trunk/WebKitTools

Unreviewed fix.

On tiger bot, it claims syntax error for with statement.

  • Scripts/webkitpy/layout_tests/port/websocket_server.py: rewrite with statement with try-finally.
12:32 AM Changeset in webkit [59351] by yuzo@google.com
  • 3 edits
    2 adds in trunk

2010-05-12 Yuzo Fujishima <​yuzo@google.com>

Reviewed by Darin Adler.

Fix Bug 35014 - Modifying UA rules from page JS crashes
​https://bugs.webkit.org/show_bug.cgi?id=35014

  • fast/css/modify-ua-rules-from-javascript-expected.txt: Copied from LayoutTests/editing/selection/5136696-expected.txt.
  • fast/css/modify-ua-rules-from-javascript.html: Added.

2010-05-12 Yuzo Fujishima <​yuzo@google.com>

Reviewed by Darin Adler.

Fix Bug 35014 - Modifying UA rules from page JS crashes
Added a NULL check.
​https://bugs.webkit.org/show_bug.cgi?id=35014

Test: fast/css/modify-ua-rules-from-javascript.html

  • css/CSSMutableStyleDeclaration.cpp: (WebCore::CSSMutableStyleDeclaration::setNeedsStyleRecalc):
12:28 AM Changeset in webkit [59350] by ukai@chromium.org
  • 6 edits
    35 deletes in trunk/WebKitTools

2010-05-13 Fumitoshi Ukai <​ukai@chromium.org>

Reviewed by David Levin.

WebSocket: pywebsocket 0.5
​https://bugs.webkit.org/show_bug.cgi?id=38034

Remove pywebsocket from webkitpy/thirdparty.
Make pywebsocket autoinstalled.

  • Scripts/new-run-webkit-websocketserver: Add --output-dir option.
  • Scripts/old-run-webkit-tests: Use new-run-webkit-websocketserver, rather than directly run pywebsocket's standalone.py
  • Scripts/run-webkit-websocketserver: Ditto.
  • Scripts/webkitpy/layout_tests/port/websocket_server.py: Use autoinstalled pywebsocket.
  • Scripts/webkitpy/thirdparty/init.py: Autoinstall pywebsocket
  • Scripts/webkitpy/thirdparty/pywebsocket: Removed.

May 12, 2010:

11:44 PM Changeset in webkit [59349] by dumi@chromium.org
  • 6 edits
    2 adds in trunk/WebCore

Add the parent class for Database and DatabaseSync.
​https://bugs.webkit.org/show_bug.cgi?id=39041

Reviewed by Adam Barth.

  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • storage/AbstractDatabase.cpp: Added.
  • storage/AbstractDatabase.h: Added.
11:39 PM Changeset in webkit [59348] by eric@webkit.org
  • 3 edits in trunk/WebKit/chromium

2010-05-12 Hans Wennborg <​hans@chromium.org>

Reviewed by Jeremy Orlow.

[Chromium] Remove transitional functions from WebStorageNamespace and WebViewClient.
​https://bugs.webkit.org/show_bug.cgi?id=38985

These functions are no longer called as of Chromium revision 47020.
This is part of resolving ​http://crbug.com/42740

  • public/WebStorageNamespace.h:
  • public/WebViewClient.h: (WebKit::WebViewClient::createSessionStorageNamespace):
11:27 PM Changeset in webkit [59347] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-05-12 Noam Rosenthal <​noam.rosenthal@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] GraphicsLayer: depth-test causes flicker in certain situations

This patch removes the simplistic 2D depth test as it leads to flickering side effects.
​https://bugs.webkit.org/show_bug.cgi?id=38370

Tested by ​http://webkit.org/blog-files/3d-transforms/morphing-cubes.html

  • platform/graphics/qt/GraphicsLayerQt.cpp: (WebCore::GraphicsLayerQtImpl::updateTransform):
11:20 PM Changeset in webkit [59346] by tony@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-05-12 Tony Chang <​tony@chromium.org>

Reviewed by Kent Tamura.

[chromium] disable DRT in chromium again
​https://bugs.webkit.org/show_bug.cgi?id=39049

  • WebKit.gyp:
10:40 PM Changeset in webkit [59345] by eric@webkit.org
  • 2 edits in trunk/LayoutTests

2010-05-12 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r59272.
​http://trac.webkit.org/changeset/59272
​https://bugs.webkit.org/show_bug.cgi?id=39047

Original change (59270) was rolled out (Requested by smfr on
#webkit).

  • platform/qt/editing/deleting/5408255-expected.txt:
10:39 PM Changeset in webkit [59344] by Chris Jerdonek
  • 3 edits
    1 add in trunk/WebKitTools

Fixed a bug in svn-apply whereby the reviewer would not get set if
the portion of the patch for the ChangeLog contains "NOBODY (PS!)"
in the leading junk.

Reviewed by Daniel Bates.

​https://bugs.webkit.org/show_bug.cgi?id=38998

  • Scripts/VCSUtils.pm:
    • Added the $changeLogTimeZone variable from svn-apply.
    • Added setChangeLogDateAndReviewer() from svn-apply.
    • Added a localTimeInProjectTimeZone() subroutine.
    • In setChangeLogDateAndReviewer():
      • Added an $epochTime parameter to make the subroutine more testable.
      • Made the "NOBODY (PS!)" regular expression more specific so that it will not apply to text in the leading junk.
      • Updated to call localTimeInProjectTimeZone().
  • Scripts/svn-apply:
    • Removed the $changeLogTimeZone file variable.
    • Added an $epochTime file variable to represent the current time.
    • Removed the setChangeLogDateAndReviewer() subroutine.
    • Updated patch() to use the new setChangeLogDateAndReviewer() syntax.
  • Scripts/webkitperl/VCSUtils_unittest/setChangeLogDateAndReviewer.pl: Added.
    • Added unit tests.
10:38 PM Changeset in webkit [59343] by eric@webkit.org
  • 2 edits in trunk/LayoutTests

2010-05-12 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r59276.
​http://trac.webkit.org/changeset/59276
​https://bugs.webkit.org/show_bug.cgi?id=39046

Original change (59270) was rolled out (Requested by smfr on
#webkit).

  • platform/gtk/editing/deleting/delete-select-all-001-expected.txt:
10:28 PM Changeset in webkit [59342] by Simon Fraser
  • 13 edits
    5 deletes in trunk

2010-05-12 Simon Fraser <Simon Fraser>

Reviewed by Mark Rowe.

Fix layer dump to avoid spurious platform differences
​https://bugs.webkit.org/show_bug.cgi?id=39045

Only dump the children transform on layers that are not the root layer.
The children transform on the root layer is used on Leopard to implement
geometry flipping, so avoid this supurious difference in test output.

  • platform/graphics/GraphicsLayer.cpp: (WebCore::GraphicsLayer::dumpProperties):
9:45 PM Changeset in webkit [59341] by Simon Fraser
  • 9 edits
    2 deletes in trunk

2010-05-12 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r59270.
​http://trac.webkit.org/changeset/59270
​https://bugs.webkit.org/show_bug.cgi?id=39044

Caused a crash on some pages - bug 39042 (Requested by smfr on
#webkit).

  • editing/deleting/delete-block-contents-004-expected.txt: Removed.
  • editing/deleting/delete-block-contents-004.html: Removed.
  • editing/deleting/in-visibly-empty-root-expected.txt:
  • platform/mac/editing/deleting/5408255-expected.txt:
  • platform/mac/editing/deleting/delete-select-all-001-expected.txt:
  • platform/mac/editing/selection/4895428-1-expected.txt:
  • platform/mac/editing/selection/4895428-4-expected.txt:
  • platform/mac/fast/events/mouseout-dead-node-expected.txt:

2010-05-12 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r59270.
​http://trac.webkit.org/changeset/59270
​https://bugs.webkit.org/show_bug.cgi?id=39044

Caused a crash on some pages - bug 39042 (Requested by smfr on
#webkit).

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::removeChild):
9:12 PM Changeset in webkit [59340] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-05-12 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

test-webkitpy fails on windows due to lack of readline module
​https://bugs.webkit.org/show_bug.cgi?id=38884

Win32 Python does not have a readline module, so we should
not exit(1) if the import fails.

Also the failure message is mac-specific and doesn't need to be.
Only print the mac-specific install instructions on mac.

  • Scripts/webkitpy/common/system/user.py:
9:01 PM Changeset in webkit [59339] by barraclough@apple.com
  • 22 edits in trunk/JavaScriptCore

​https://bugs.webkit.org/show_bug.cgi?id=39039
Provide support for separate bytecode/JIT code translations for call/construct usage
This will allow us to produce code generated specifically for use as a constructor, not for general function use.

Reviewed by Oliver Hunt.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::CodeBlock):
(JSC::CodeBlock::unlinkCallers):

  • bytecode/CodeBlock.h:

(JSC::CodeBlock::getBytecodeIndex):
(JSC::CodeBlock::getJITCode):
(JSC::CodeBlock::executablePool):
(JSC::GlobalCodeBlock::GlobalCodeBlock):
(JSC::FunctionCodeBlock::FunctionCodeBlock):

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::executeCall):
(JSC::Interpreter::executeConstruct):
(JSC::Interpreter::prepareForRepeatCall):
(JSC::Interpreter::execute):
(JSC::Interpreter::privateExecute):

  • interpreter/Interpreter.h:
  • jit/JIT.cpp:

(JSC::JIT::unlinkCallOrConstruct):
(JSC::JIT::linkConstruct):

  • jit/JIT.h:
  • jit/JITCall.cpp:

(JSC::JIT::compileOpCall):
(JSC::JIT::compileOpCallSlowCase):

  • jit/JITOpcodes.cpp:

(JSC::JIT::privateCompileCTIMachineTrampolines):

  • jit/JITOpcodes32_64.cpp:

(JSC::JIT::privateCompileCTIMachineTrampolines):

  • jit/JITPropertyAccess.cpp:

(JSC::JIT::emitSlow_op_get_by_val):

  • jit/JITPropertyAccess32_64.cpp:

(JSC::JIT::emitSlow_op_get_by_val):

  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

  • jit/JITStubs.h:

(JSC::JITThunks::ctiVirtualConstructLink):
(JSC::JITThunks::ctiVirtualConstruct):
(JSC::):

  • jit/SpecializedThunkJIT.h:

(JSC::SpecializedThunkJIT::finalize):

  • runtime/Arguments.h:

(JSC::JSActivation::copyRegisters):

  • runtime/ArrayPrototype.cpp:

(JSC::isNumericCompareFunction):

  • runtime/Executable.cpp:

(JSC::FunctionExecutable::~FunctionExecutable):
(JSC::FunctionExecutable::compileForCall):
(JSC::FunctionExecutable::compileForConstruct):
(JSC::EvalExecutable::generateJITCode):
(JSC::ProgramExecutable::generateJITCode):
(JSC::FunctionExecutable::generateJITCodeForCall):
(JSC::FunctionExecutable::generateJITCodeForConstruct):
(JSC::FunctionExecutable::markAggregate):
(JSC::FunctionExecutable::reparseExceptionInfo):
(JSC::EvalExecutable::reparseExceptionInfo):
(JSC::FunctionExecutable::recompile):

  • runtime/Executable.h:

(JSC::ExecutableBase::ExecutableBase):
(JSC::ExecutableBase::isHostFunction):
(JSC::ExecutableBase::generatedJITCodeForCall):
(JSC::ExecutableBase::generatedJITCodeForConstruct):
(JSC::NativeExecutable::NativeExecutable):
(JSC::EvalExecutable::jitCode):
(JSC::ProgramExecutable::jitCode):
(JSC::FunctionExecutable::bytecodeForCall):
(JSC::FunctionExecutable::isGeneratedForCall):
(JSC::FunctionExecutable::generatedBytecodeForCall):
(JSC::FunctionExecutable::bytecodeForConstruct):
(JSC::FunctionExecutable::isGeneratedForConstruct):
(JSC::FunctionExecutable::generatedBytecodeForConstruct):
(JSC::FunctionExecutable::symbolTable):
(JSC::FunctionExecutable::FunctionExecutable):
(JSC::FunctionExecutable::jitCodeForCall):
(JSC::FunctionExecutable::jitCodeForConstruct):

  • runtime/JSActivation.h:

(JSC::JSActivation::JSActivationData::JSActivationData):

  • runtime/JSFunction.cpp:

(JSC::JSFunction::~JSFunction):
(JSC::JSFunction::call):
(JSC::JSFunction::construct):

  • runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::numericCompareFunction):

8:27 PM Changeset in webkit [59338] by Simon Fraser
  • 10 edits
    4 adds in trunk

2010-05-12 Simon Fraser <Simon Fraser>

Reviewed by David Hyatt.

Composited plug-ins can cause missed painting
​https://bugs.webkit.org/show_bug.cgi?id=39033
<rdar://problem/7972478>

Fixed missed painting (and assertions in debug builds) related to compositing
propagating out of iframes that contain plug-ins.

When an iframe enters or leaves compositing mode, RenderLayerCompositor uses
setNeedsStyleRecalc(SyntheticStyleChange) to trigger the parent document to re-evaluate
whether the iframe itself should be composited. However, for iframes containing plug-ins,
this can happen at inappropriate times. For example, when a browser tab is brought frontmost,
plug-ins are instantiated for the first time (via -viewDidMoveToWindow), which triggers a
setNeedsStyleRecalc() on the object element. Soon after, the -viewWillDraw machinery
does layout from the top down. During layout of the iframe, the iframe enters compositing mode,
and does a setNeedsStyleRecalc() on the iframe element in its parent document. This leaves the
FrameView as needsLayout(), so the FrameView::paintContents() asserts and bails.

The fix is to avoid doing a setNeedsStyleRecalc() on the root while inside a recalcStyle on
the iframe. We do this by switching the iframe into compositing mode eagerly as soon as we know
the plug-in needs it.

A secondary fix is to ensure that if a document has composited iframes, when that document becomes
composited, we connect compositing layers between the iframes and the parent document.

Tests: compositing/iframes/connect-compositing-iframe-delayed.html

compositing/iframes/iframe-src-change.html

  • WebCore.base.exp: Export FrameView::enterCompositingMode()
  • page/FrameView.h: New method, enterCompositingMode(), that we can call from WebKit plug-in code.
  • page/FrameView.cpp: (WebCore::FrameView::enterCompositingMode):
  • rendering/RenderLayerCompositor.h:
  • rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::enableCompositingMode): When we switch into compositing mode, we

force a style recaclc on any iframes to get them into compositing layers, so they can hook up
with their content layers if necessary.

(WebCore::RenderLayerCompositor::didMoveOnscreen): Only call attachRootPlatformLayer() if we really need to.
(WebCore::RenderLayerCompositor::willMoveOffscreen): Only call detachRootPlatformLayer() if we really need to.
(WebCore::RenderLayerCompositor::detachRootPlatformLayer): Whitespace.
(WebCore::RenderLayerCompositor::notifyIFramesOfCompositingChange): Fetch iframe elements, and send a

synthetic style recalc on them.

8:20 PM Changeset in webkit [59337] by oliver@apple.com
  • 2 edits in trunk/JavaScriptCore

Build fix

<rdar://problem/7977960> REGRESSION (r59282): Tiger PPC build broken

8:12 PM Changeset in webkit [59336] by oliver@apple.com
  • 7 edits in trunk

2010-05-12 Oliver Hunt <​oliver@apple.com>

Reviewed by Gavin Barraclough.

<rdar://7969718> Incorrect 32-bit codegen for op_jnlesseq
​https://bugs.webkit.org/show_bug.cgi?id=39038

Correct the use of incorrect comparison operators.

  • jit/JITArithmetic32_64.cpp: (JSC::JIT::emit_op_jlesseq): (JSC::JIT::emitBinaryDoubleOp):

2010-05-12 Oliver Hunt <​oliver@apple.com>

Reviewed by Gavin Barraclough.

<rdar://7969718> Incorrect 32-bit codegen for op_jnlesseq
​https://bugs.webkit.org/show_bug.cgi?id=39038

Add more tests for <=, <, >, and >=.

  • fast/js/comparison-operators-greater-expected.txt:
  • fast/js/comparison-operators-less-expected.txt:
  • fast/js/script-tests/comparison-operators-greater.js:
  • fast/js/script-tests/comparison-operators-less.js:
7:37 PM Changeset in webkit [59335] by eric@webkit.org
  • 2 edits in trunk/WebKit/qt

2010-05-12 Joe Ligman <​joseph.ligman@nokia.com>

Reviewed by Laszlo Gombos.

[Qt] Nested overflow div does not scroll
​https://bugs.webkit.org/show_bug.cgi?id=38641

Modify qtwebkit_webframe_scrollOverflow, if the current node's render layer
does not scroll it will try and scroll the parent's render layer. Also export
qtwebkit_webframe_scrollOverflow so we can use it independently of
qtwebkit_webframe_scrollRecursively

  • Api/qwebframe.cpp: (qtwebkit_webframe_scrollOverflow): (qtwebkit_webframe_scrollRecursively):
7:25 PM Changeset in webkit [59334] by eric@webkit.org
  • 3 edits in trunk/JavaScriptCore

2010-05-12 Caio Marcelo de Oliveira Filho <​caio.oliveira@openbossa.org>

Reviewed by Eric Seidel.

JavaScriptCore: fix build when some optimizations are disabled
​https://bugs.webkit.org/show_bug.cgi?id=38800

Remove outdated UNUSED_PARAMs when using JIT but with
ENABLE_JIT_OPTIMIZE_CALL and ENABLE_JIT_OPTIMIZE_PROPERTY_ACCESS
disabled.

  • jit/JITOpcodes.cpp:
  • jit/JITOpcodes32_64.cpp:
6:26 PM Changeset in webkit [59333] by tkent@chromium.org
  • 2 edits in trunk/WebKitTools

2010-05-12 Kent Tamura <​tkent@chromium.org>

Reviewed by Nate Chapin.

[DRT/Chromium] Add a missing Sans-serif font setting
​https://bugs.webkit.org/show_bug.cgi?id=38981

  • DumpRenderTree/chromium/TestShell.cpp: (TestShell::resetWebSettings): Set "Helvetica" for Sans-serif. It is the same as the default setting of test_shell.
5:46 PM Changeset in webkit [59332] by jam@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-05-12 John Abd-El-Malek <​jam@chromium.org>

Reviewed by Darin Fisher.

[chromium] Disable WebScrollbarImpl's scrollbar if it's not needed
​https://bugs.webkit.org/show_bug.cgi?id=39025

  • src/WebScrollbarImpl.cpp: (WebKit::WebScrollbarImpl::setLocation): (WebKit::WebScrollbarImpl::setDocumentSize):
5:41 PM Changeset in webkit [59331] by mrowe@apple.com
  • 5 edits in trunk

Versioning.

5:34 PM Changeset in webkit [59330] by andersca@apple.com
  • 3 edits in trunk/WebCore

2010-05-12 Anders Carlsson <​andersca@apple.com>

Reviewed by Simon Fraser.

Shrink the size of FillLayer by moving a member variable.
​https://bugs.webkit.org/show_bug.cgi?id=39035

  • rendering/style/FillLayer.cpp: (WebCore::FillLayer::FillLayer):
  • rendering/style/FillLayer.h:
5:32 PM Changeset in webkit [59329] by mrowe@apple.com
  • 2 edits in branches/safari-533-branch/WebCore

Merge r59192.

5:32 PM Changeset in webkit [59328] by mrowe@apple.com
  • 2 edits in branches/safari-533-branch/WebCore

Merge r59190.

5:32 PM WebKit Team edited by morrita@google.com
(diff)
5:32 PM Changeset in webkit [59327] by mrowe@apple.com
  • 8 edits in branches/safari-533-branch/WebKit/win

Merge r59175.

5:32 PM Changeset in webkit [59326] by mrowe@apple.com
  • 11 edits in branches/safari-533-branch

Merge r59173.

5:31 PM Changeset in webkit [59325] by mrowe@apple.com
  • 4 edits in branches/safari-533-branch/WebCore

Merge r59155.

5:31 PM Changeset in webkit [59324] by mrowe@apple.com
  • 3 edits in branches/safari-533-branch/WebKit/mac

Merge r59125.

5:31 PM Changeset in webkit [59323] by mrowe@apple.com
  • 5 edits
    2 adds in branches/safari-533-branch

Merge r59109.

5:31 PM Changeset in webkit [59322] by mrowe@apple.com
  • 7 edits
    3 adds in branches/safari-533-branch

Merge r59100.

5:31 PM Changeset in webkit [59321] by mrowe@apple.com
  • 7 edits
    2 adds in branches/safari-533-branch

Merge r59098.

5:31 PM Changeset in webkit [59320] by mrowe@apple.com
  • 1 edit in branches/safari-533-branch/JavaScriptCore/jit/JITOpcodes.cpp

Merge r59065.

5:31 PM Changeset in webkit [59319] by mrowe@apple.com
  • 14 edits
    2 moves
    1 add
    1 delete in branches/safari-533-branch

Merge r59064.

5:30 PM Changeset in webkit [59318] by mrowe@apple.com
  • 5 edits in branches/safari-533-branch/WebCore

Merge r59058.

5:30 PM Changeset in webkit [59317] by mrowe@apple.com
  • 2 edits in branches/safari-533-branch/WebCore

Merge r59009.

5:30 PM Changeset in webkit [59316] by mrowe@apple.com
  • 2 edits in branches/safari-533-branch/WebCore/platform/graphics/win

Merge r59008.

5:30 PM Changeset in webkit [59315] by mrowe@apple.com
  • 1 edit in branches/safari-533-branch/WebCore/platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.h

Merge r59007.

5:30 PM Changeset in webkit [59314] by mrowe@apple.com
  • 1 edit in branches/safari-533-branch/WebCore/platform/graphics/win/QTMovieVisualContext.cpp

Merge r59003.

5:30 PM Changeset in webkit [59313] by mrowe@apple.com
  • 14 edits
    3 copies
    2 moves
    11 adds in branches/safari-533-branch

Merge r59001.

5:30 PM Changeset in webkit [59312] by mrowe@apple.com
  • 2 edits in branches/safari-533-branch/WebCore

Merge r58983.

5:30 PM Changeset in webkit [59311] by mrowe@apple.com
  • 4 edits
    1 add in branches/safari-533-branch/WebCore

Merge r58950.

5:29 PM Changeset in webkit [59310] by mrowe@apple.com
  • 3 edits
    3 adds in branches/safari-533-branch

Merge r58936.

5:29 PM Changeset in webkit [59309] by mrowe@apple.com
  • 4 edits
    5 adds in branches/safari-533-branch

Merge r59147.

5:29 PM Changeset in webkit [59308] by mrowe@apple.com
  • 9 edits in branches/safari-533-branch/WebCore

Merge r59116.

5:29 PM Changeset in webkit [59307] by mrowe@apple.com
  • 4 edits
    2 adds in branches/safari-533-branch

Merge r59111.

5:29 PM Changeset in webkit [59306] by mrowe@apple.com
  • 2 edits in branches/safari-533-branch/WebKit/mac

Merge r59093.

5:29 PM Changeset in webkit [59305] by mrowe@apple.com
  • 2 edits in branches/safari-533-branch/WebKit/mac

Merge r59086.

5:29 PM Changeset in webkit [59304] by mrowe@apple.com
  • 8 edits in branches/safari-533-branch/WebKit/mac

Merge r58982.

5:29 PM Changeset in webkit [59303] by mrowe@apple.com
  • 10 edits in branches/safari-533-branch

Merge r58965.

5:29 PM Changeset in webkit [59302] by mrowe@apple.com
  • 3 edits
    4 adds in branches/safari-533-branch

Merge r58961.

5:28 PM Changeset in webkit [59301] by mrowe@apple.com
  • 9 edits in branches/safari-533-branch

Merge r58960.

5:28 PM Changeset in webkit [59300] by mrowe@apple.com
  • 2 edits in branches/safari-533-branch/JavaScriptCore

Merge r59170.

5:28 PM Changeset in webkit [59299] by mrowe@apple.com
  • 7 edits in branches/safari-533-branch/JavaScriptCore

Merge r59161.

5:28 PM Changeset in webkit [59298] by mrowe@apple.com
  • 2 edits in branches/safari-533-branch/JavaScriptCore

Merge r59061.

5:28 PM Changeset in webkit [59297] by mrowe@apple.com
  • 7 edits in branches/safari-533-branch/JavaScriptCore

Merge r59056.

5:28 PM Changeset in webkit [59296] by mrowe@apple.com
  • 3 edits in branches/safari-533-branch/JavaScriptCore

Merge r59055.

5:28 PM Changeset in webkit [59295] by mrowe@apple.com
  • 7 edits
    1 add in branches/safari-533-branch/JavaScriptCore

Merge r59040.

5:28 PM Changeset in webkit [59294] by mrowe@apple.com
  • 3 edits
    3 adds in branches/safari-533-branch

Merge r58993.

5:28 PM Changeset in webkit [59293] by mrowe@apple.com
  • 2 edits in branches/safari-533-branch/JavaScriptCore

Merge r58991.

5:27 PM Changeset in webkit [59292] by mrowe@apple.com
  • 2 edits in branches/safari-533-branch/JavaScriptCore

Merge r58988.

5:27 PM Changeset in webkit [59291] by mrowe@apple.com
  • 2 edits in branches/safari-533-branch/JavaScriptCore

Merge r58987.

5:27 PM Changeset in webkit [59290] by mrowe@apple.com
  • 20 edits in branches/safari-533-branch/JavaScriptCore

Merge r58986.

5:27 PM Changeset in webkit [59289] by mrowe@apple.com
  • 2 edits in branches/safari-533-branch/JavaScriptCore

Merge r58974.

5:27 PM Changeset in webkit [59288] by mrowe@apple.com
  • 2 edits in branches/safari-533-branch/JavaScriptCore

Merge r58970.

5:27 PM Changeset in webkit [59287] by mrowe@apple.com
  • 2 edits in branches/safari-533-branch/JavaScriptCore

Merge r58964.

5:27 PM Changeset in webkit [59286] by mrowe@apple.com
  • 5 edits
    1 add in branches/safari-533-branch/JavaScriptCore

Merge r58935.

5:19 PM Changeset in webkit [59285] by mrowe@apple.com
  • 1 copy in branches/safari-533-branch

New branch.

4:55 PM Changeset in webkit [59284] by ojan@chromium.org
  • 5 edits in trunk/WebKitTools

2010-05-10 Ojan Vafai <​ojan@chromium.org>

Reviewed by Adam Barth.

webkit-patch upload --fancy-review now uses the bugzilla bug ID as the rietveld ID
​https://bugs.webkit.org/show_bug.cgi?id=38866

wkrietveld.appspot.com has already been updated to allow you to
pass --issue for the issue creation as well as subsequent uploads.

Also, remove the extra code for trying to read out the issue ID
from the changelog description since we just use the bugzilla ID now.

  • Scripts/webkitpy/common/config/init.py:
  • Scripts/webkitpy/common/net/rietveld.py:
  • Scripts/webkitpy/tool/steps/postcodereview.py:
  • Scripts/webkitpy/tool/steps/postdiff.py:
4:43 PM WebKit Team edited by ojan@chromium.org
(diff)
4:34 PM Changeset in webkit [59283] by ojan@chromium.org
  • 2 edits in trunk/WebKitTools

2010-05-12 Ojan Vafai <​ojan@chromium.org>

No review needed.

Marking myself as a reviewer.

  • Scripts/webkitpy/common/config/committers.py:
4:25 PM Changeset in webkit [59282] by oliver@apple.com
  • 5 edits in trunk/JavaScriptCore

Work around GCC stupidity by either explicitly inlining or by
using ALWAYS_INLINE

Reviewed by Gaving Barraclough.

  • runtime/StringPrototype.cpp:

(JSC::stringProtoFuncReplace):

  • runtime/UString.h:

(JSC::UString::~UString):

  • wtf/RefPtr.h:

(WTF::RefPtr::RefPtr):
(WTF::RefPtr::~RefPtr):

  • wtf/text/StringImpl.h:

(WebCore::StringImpl::create):
(WebCore::StringImpl::tryCreateUninitialized):

4:21 PM Changeset in webkit [59281] by weinig@apple.com
  • 13 edits in trunk/WebCore

A bunch of nice micro-optimizations for ~1% speedup on PLT.

  • Add fastGetAttribute. The same as getAttribute except can only be called when it is known not to be style attribute or one of the SVG animatable attributes.
  • Inline some functions from Font.
  • Return the same string from deprecatedParseURL if there is nothing to strip.
  • Use a member variable instead of a virtual function to determine whether a ScheduledNavigation is a location change.

Reviewed by Anders Carlsson.

  • WebCore.base.exp:
  • css/CSSHelper.cpp:

(WebCore::deprecatedParseURL):

  • css/CSSStyleSelector.cpp:

(WebCore::linkAttribute):
(WebCore::CSSStyleSelector::canShareStyleWithElement):
(WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):

  • dom/Element.cpp:

(WebCore::Element::getAttribute):

  • dom/Element.h:

(WebCore::Element::fastHasAttribute):
(WebCore::Element::fastGetAttribute):

  • html/HTMLFormControlElement.cpp:

(WebCore::HTMLFormControlElement::formControlName):

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::value):

  • loader/RedirectScheduler.cpp:

(WebCore::ScheduledNavigation::ScheduledNavigation):
(WebCore::ScheduledNavigation::isLocationChange):
(WebCore::ScheduledURLNavigation::ScheduledURLNavigation):
(WebCore::ScheduledRedirect::ScheduledRedirect):
(WebCore::ScheduledLocationChange::ScheduledLocationChange):
(WebCore::ScheduledRefresh::ScheduledRefresh):
(WebCore::ScheduledHistoryNavigation::ScheduledHistoryNavigation):
(WebCore::ScheduledFormSubmission::ScheduledFormSubmission):
(WebCore::RedirectScheduler::locationChangePending):

  • platform/graphics/Font.cpp:
  • platform/graphics/Font.h:

(WebCore::Font::~Font):
(WebCore::Font::primaryFont):
(WebCore::Font::fontDataAt):
(WebCore::Font::fontDataForCharacters):
(WebCore::Font::isFixedPitch):
(WebCore::Font::fontSelector):

  • platform/graphics/FontFallbackList.h:
  • rendering/RenderImage.cpp:

(WebCore::RenderImage::imageMap):

3:48 PM Changeset in webkit [59280] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

2010-05-12 Dirk Pranke <​dpranke@chromium.org>

Unreviewed, build fix.

Change expectation from IMAGE to IMAGE+TEXT for Chromium Linux; I'm
not sure if this is flaky or not but it seems to be consistent on the
bot.

  • platform/chromium/test_expectations.txt:
3:36 PM Changeset in webkit [59279] by dpranke@chromium.org
  • 3 edits in trunk/WebKitTools

2010-05-12 Dirk Pranke <​dpranke@chromium.org>

Reviewed by Eric Seidel.

new-run-webkit-tests: add a --print default option so that you can
easily get the default output plus something (e.g., you can say
'--print default,config' instead of '--print misc,one-line-progress,
one-line-summary,unexpected,unexpected-results,updates,config'.

Also, add more unit tests for --verbose, --print everything, etc.

​https://bugs.webkit.org/show_bug.cgi?id=38877

  • Scripts/webkitpy/layout_tests/layout_package/printing.py:
  • Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
3:35 PM Changeset in webkit [59278] by dpranke@chromium.org
  • 8 edits
    2 adds in trunk/LayoutTests

2010-05-12 Dirk Pranke <​dpranke@chromium.org>

Reviewed by Nate Chapin.

Expectations fix and new chromium baselines resulting from the
input type=search change in r58313.

​https://bugs.webkit.org/show_bug.cgi?id=38965

  • platform/chromium-linux/fast/forms/placeholder-pseudo-style-expected.checksum:
  • platform/chromium-linux/fast/forms/placeholder-pseudo-style-expected.png:
  • platform/chromium-linux/fast/forms/search-vertical-alignment-expected.checksum:
  • platform/chromium-linux/fast/forms/search-vertical-alignment-expected.png: Added.
  • platform/chromium-win/fast/forms/search-vertical-alignment-expected.checksum:
  • platform/chromium-win/fast/forms/search-vertical-alignment-expected.png: Added.
  • platform/chromium/test_expectations.txt:
  • platform/mac/fast/forms/search-zoomed-expected.checksum:
  • platform/mac/fast/forms/search-zoomed-expected.png:
3:33 PM Changeset in webkit [59277] by jianli@chromium.org
  • 15 edits
    3 adds in trunk/LayoutTests

Unreviewed. Chromium: rebaseline layout tests.

  • platform/chromium-linux/editing/deleting/5408255-expected.checksum:
  • platform/chromium-linux/editing/deleting/5408255-expected.png:
  • platform/chromium-linux/fast/css/pseudo-cache-stale-expected.checksum:
  • platform/chromium-linux/fast/css/pseudo-cache-stale-expected.png:
  • platform/chromium-mac/editing/deleting/5408255-expected.checksum: Added.
  • platform/chromium-mac/editing/deleting/5408255-expected.png: Added.
  • platform/chromium-mac/fast/css/pseudo-cache-stale-expected.checksum: Added.
  • platform/chromium-win/editing/deleting/5408255-expected.checksum:
  • platform/chromium-win/editing/deleting/5408255-expected.png:
  • platform/chromium-win/editing/deleting/5408255-expected.txt:
  • platform/chromium-win/editing/deleting/delete-select-all-001-expected.txt:
  • platform/chromium-win/editing/selection/4895428-1-expected.txt:
  • platform/chromium-win/editing/selection/4895428-4-expected.txt:
  • platform/chromium-win/fast/css/pseudo-cache-stale-expected.checksum:
  • platform/chromium-win/fast/css/pseudo-cache-stale-expected.png:
  • platform/chromium-win/fast/css/pseudo-cache-stale-expected.txt:
  • platform/chromium-win/fast/events/mouseout-dead-node-expected.txt:
3:31 PM Changeset in webkit [59276] by Martin Robinson
  • 2 edits in trunk/LayoutTests

2010-05-12 Martin Robinson <​mrobinson@igalia.com>

No review. Updating the baseline for this test after r59270.

  • platform/gtk/editing/deleting/delete-select-all-001-expected.txt:
3:10 PM Changeset in webkit [59275] by Csaba Osztrogonác
  • 3 edits in trunk/WebKitTools

Qt build failures cause SheriffBot false positives
​https://bugs.webkit.org/show_bug.cgi?id=38969

Reviewed by Adam Barth.

Add Qt bots back to the core builders, because bug fixed by r59261.

  • Scripts/webkitpy/common/net/buildbot.py:
  • Scripts/webkitpy/common/net/buildbot_unittest.py:
3:07 PM Changeset in webkit [59274] by hyatt@apple.com
  • 23 edits
    1 delete in trunk/WebCore

Make InlineBoxes use an IntRect for dimensions, and eliminate the dynamic computation of height() every time.

Reviewed by Sam Weinig.

  • WebCore.xcodeproj/project.pbxproj:
  • editing/visible_units.cpp:

(WebCore::previousLinePosition):
(WebCore::nextLinePosition):

  • rendering/EllipsisBox.cpp:

(WebCore::EllipsisBox::paint):
(WebCore::EllipsisBox::selectionRect):
(WebCore::EllipsisBox::paintSelection):
(WebCore::EllipsisBox::nodeAtPoint):

  • rendering/EllipsisBox.h:

(WebCore::EllipsisBox::EllipsisBox):

  • rendering/InlineBox.cpp:

(WebCore::InlineBox::adjustPosition):
(WebCore::InlineBox::canAccommodateEllipsis):

  • rendering/InlineBox.h:

(WebCore::InlineBox::InlineBox):
(WebCore::InlineBox::isSVGRootInlineBox):
(WebCore::InlineBox::x):
(WebCore::InlineBox::y):
(WebCore::InlineBox::width):
(WebCore::InlineBox::height):
(WebCore::InlineBox::bottom):
(WebCore::InlineBox::right):
(WebCore::InlineBox::setX):
(WebCore::InlineBox::setY):
(WebCore::InlineBox::setWidth):
(WebCore::InlineBox::setHeight):
(WebCore::InlineBox::location):
(WebCore::InlineBox::size):
(WebCore::InlineBox::setLocation):
(WebCore::InlineBox::setSize):
(WebCore::InlineBox::move):
(WebCore::InlineBox::frameRect):
(WebCore::InlineBox::setFrameRect):
(WebCore::InlineBox::baselinePosition):
(WebCore::InlineBox::lineHeight):

  • rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::placeBoxesVertically):
(WebCore::InlineFlowBox::computeVerticalOverflow):
(WebCore::InlineFlowBox::nodeAtPoint):
(WebCore::InlineFlowBox::paintBoxDecorations):
(WebCore::InlineFlowBox::paintMask):
(WebCore::InlineFlowBox::paintTextDecorations):

  • rendering/InlineFlowBox.h:

(WebCore::InlineFlowBox::visibleOverflowRect):
(WebCore::InlineFlowBox::topLayoutOverflow):
(WebCore::InlineFlowBox::bottomLayoutOverflow):
(WebCore::InlineFlowBox::leftLayoutOverflow):
(WebCore::InlineFlowBox::rightLayoutOverflow):
(WebCore::InlineFlowBox::layoutOverflowRect):
(WebCore::InlineFlowBox::topVisualOverflow):
(WebCore::InlineFlowBox::bottomVisualOverflow):
(WebCore::InlineFlowBox::leftVisualOverflow):
(WebCore::InlineFlowBox::rightVisualOverflow):
(WebCore::InlineFlowBox::visualOverflowRect):
(WebCore::InlineFlowBox::setHorizontalOverflowPositions):
(WebCore::InlineFlowBox::setVerticalOverflowPositions):

  • rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::selectionRect):
(WebCore::InlineTextBox::placeEllipsisBox):
(WebCore::InlineTextBox::nodeAtPoint):
(WebCore::InlineTextBox::paint):
(WebCore::InlineTextBox::paintSelection):
(WebCore::InlineTextBox::paintCompositionBackground):
(WebCore::InlineTextBox::paintDecoration):
(WebCore::InlineTextBox::paintSpellingOrGrammarMarker):
(WebCore::InlineTextBox::paintTextMatchMarker):
(WebCore::InlineTextBox::computeRectForReplacementMarker):
(WebCore::InlineTextBox::paintCompositionUnderline):
(WebCore::InlineTextBox::offsetForPosition):
(WebCore::InlineTextBox::positionForOffset):

  • rendering/InlineTextBox.h:

(WebCore::InlineTextBox::setSpaceAdd):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::positionForPointWithInlineChildren):

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::computeVerticalPositionsForLine):
(WebCore::RenderBlock::layoutInlineChildren):

  • rendering/RenderSVGInline.cpp:

(WebCore::RenderSVGInline::createInlineFlowBox):

  • rendering/RenderSVGInlineText.cpp:

(WebCore::RenderSVGInlineText::createTextBox):

  • rendering/RenderSVGText.cpp:

(WebCore::RenderSVGText::createRootInlineBox):

  • rendering/RenderText.cpp:

(WebCore::RenderText::positionForPoint):
(WebCore::RenderText::firstRunX):
(WebCore::RenderText::firstRunY):

  • rendering/RenderTreeAsText.cpp:

(WebCore::writeTextRun):

  • rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::placeEllipsis):
(WebCore::RootInlineBox::addHighlightOverflow):
(WebCore::RootInlineBox::closestLeafChildForXPos):

  • rendering/SVGInlineFlowBox.h:

(WebCore::SVGInlineFlowBox::SVGInlineFlowBox):

  • rendering/SVGInlineTextBox.h:

(WebCore::SVGInlineTextBox::selectionTop):
(WebCore::SVGInlineTextBox::selectionHeight):

  • rendering/SVGRootInlineBox.h:

(WebCore::SVGRootInlineBox::SVGRootInlineBox):
(WebCore::SVGRootInlineBox::isSVGRootInlineBox):

  • rendering/TrailingFloatsRootInlineBox.h: Removed.
2:52 PM Changeset in webkit [59273] by dumi@chromium.org
  • 6 edits in trunk

Removing the unnecessary dirfd parameter.
​https://bugs.webkit.org/show_bug.cgi?id=38869

Reviewed by Dimitri Glazkov.

WebCore:

  • platform/chromium/ChromiumBridge.h:
  • platform/sql/chromium/SQLiteFileSystemChromiumPosix.cpp:

WebKit/chromium:

  • public/WebKitClient.h:

(WebKit::WebKitClient::databaseOpenFile):

  • src/ChromiumBridge.cpp:

(WebCore::ChromiumBridge::databaseOpenFile):

2:47 PM Changeset in webkit [59272] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

Unreviewed fix after r59270.
Update Qt specific expected result based on IRC discussing with Enrica Casucci.

  • platform/qt/editing/deleting/5408255-expected.txt: updated.
2:34 PM Changeset in webkit [59271] by jparent@chromium.org
  • 2 edits
    1 copy in trunk/BugsSite

Hide the in-rietveld flag in the UI. It is only used only by tooling and shouldn't clutter the UI.
​https://bugs.webkit.org/show_bug.cgi?id=39024

Reviewed by Ojan Vafai.

  • template/en/custom/attachment/list.html.tmpl: Removes this flag entirely from the UI, not needed on this page.
  • template/en/custom/flag/list.html.tmpl: Added. Copied from template/en/default/flag/list.html.tmpl with only changes inside the if WEBKIT_CHANGES section. Hides the flag rather than removing it completely, so tools can still interact with it.
2:24 PM Changeset in webkit [59270] by enrica@apple.com
  • 9 edits
    2 adds in trunk

Adding block elements to a block and removing them changes the height of the element.
​https://bugs.webkit.org/show_bug.cgi?id=38874

Reviewed by Dave Hyatt.

WebCore:

The initial height of an empty editable block is different from the height of the same block after we add block elements
and remove them.

Test: editing/deleting/delete-block-contents-004.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::removeChild): m_childrenInline was set to true only when the Renderer is created
and never reset to true when all the block elements contained are removed.

LayoutTests:

  • editing/deleting/delete-block-contents-004-expected.txt: Added.
  • editing/deleting/delete-block-contents-004.html: Added.

The following tests have new results because of the height change and because we now have one less renderer after the DOM changes.

  • editing/deleting/in-visibly-empty-root-expected.txt:
  • platform/mac/editing/deleting/5408255-expected.txt:
  • platform/mac/editing/deleting/delete-select-all-001-expected.txt:
  • platform/mac/editing/selection/4895428-1-expected.txt:
  • platform/mac/editing/selection/4895428-4-expected.txt:
  • platform/mac/fast/events/mouseout-dead-node-expected.txt
2:21 PM Changeset in webkit [59269] by jianli@chromium.org
  • 14 edits
    15 adds in trunk/LayoutTests

Unreviewed. Chromium: rebaseline layout tests and mark one failed layout test.

  • platform/chromium-linux/fast/forms/placeholder-stripped-expected.checksum: Added.
  • platform/chromium-linux/fast/forms/placeholder-stripped-expected.png: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/filters-diffuse-01-f-expected.checksum:
  • platform/chromium-linux/svg/W3C-SVG-1.1/filters-diffuse-01-f-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/filters-light-01-f-expected.checksum:
  • platform/chromium-linux/svg/W3C-SVG-1.1/filters-light-01-f-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/filters-specular-01-f-expected.checksum:
  • platform/chromium-linux/svg/W3C-SVG-1.1/filters-specular-01-f-expected.png:
  • platform/chromium-linux/svg/custom/svg-fonts-with-no-element-reference-expected.checksum: Added.
  • platform/chromium-mac/fast/forms/placeholder-stripped-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1/filters-diffuse-01-f-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1/filters-diffuse-01-f-expected.png: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1/filters-light-01-f-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1/filters-light-01-f-expected.png: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1/filters-specular-01-f-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1/filters-specular-01-f-expected.png: Added.
  • platform/chromium-win/fast/forms/placeholder-stripped-expected.checksum: Added.
  • platform/chromium-win/fast/forms/placeholder-stripped-expected.png: Added.
  • platform/chromium-win/fast/forms/placeholder-stripped-expected.txt: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-diffuse-01-f-expected.checksum:
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-diffuse-01-f-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-light-01-f-expected.checksum:
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-light-01-f-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-specular-01-f-expected.checksum:
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-specular-01-f-expected.png:
  • platform/chromium-win/svg/custom/svg-fonts-with-no-element-reference-expected.checksum: Added.
  • platform/chromium-win/svg/custom/svg-fonts-with-no-element-reference-expected.png: Added.
  • platform/chromium/test_expectations.txt:
2:18 PM Changeset in webkit [59268] by agl@chromium.org
  • 2 edits
    8 adds in trunk/LayoutTests

2010-05-12 Adam Langley <​agl@chromium.org>

Expectations change. Unreviewed.

Add baselines for fast/css/font-face-woff.html.

  • platform/chromium-linux/fast/css/font-face-woff-expected.checksum: Added.
  • platform/chromium-linux/fast/css/font-face-woff-expected.png: Added.
  • platform/chromium-mac/fast/css/font-face-woff-expected.checksum: Added.
  • platform/chromium-mac/fast/css/font-face-woff-expected.png: Added.
  • platform/chromium-mac/fast/css/font-face-woff-expected.txt: Added.
  • platform/chromium-win/fast/css/font-face-woff-expected.checksum: Added.
  • platform/chromium-win/fast/css/font-face-woff-expected.png: Added.
  • platform/chromium-win/fast/css/font-face-woff-expected.txt: Added.
2:08 PM Changeset in webkit [59267] by dumi@chromium.org
  • 2 edits in trunk/WebCore

Do not check if a database needs to be vacuumed after a read-only transaction.
​https://bugs.webkit.org/show_bug.cgi?id=38972

Reviewed by Dimitri Glazkov.

  • storage/SQLTransaction.cpp:

(WebCore::SQLTransaction::postflightAndCommit):

2:04 PM Changeset in webkit [59266] by Csaba Osztrogonác
  • 2 edits in trunk

[Qt] Link error in debug mode without debug_and_release config
​https://bugs.webkit.org/show_bug.cgi?id=39006

Reviewed by Kenneth Rohde Christiansen.

  • WebKit.pri: Unnecessary build_pass guard removed.
1:57 PM Changeset in webkit [59265] by jparent@chromium.org
  • 4 edits
    1 add in trunk/BugsSite

Adds support for Rietveld reviews. When there is an associated
Rietveld id for a patch, adds a link to do a Rietveld review instead.

Reviewed by David Kilzer.

​https://bugs.webkit.org/show_bug.cgi?id=38143

  • attachment.cgi:

Added support for handling action=rietveldreview.

  • template/en/custom/attachment/list.html.tmpl:

Adds a link to use rietveld review iff the in_rietveld flag is set.

  • template/en/custom/attachment/reviewform.html.tmpl:

Detects if we are in rietveld review mode due to query string paramter,
and customizes the review form slightly:

  • Changes text describing comment field.
  • Comment field does not include quoted patch.
  • Submit button fetches from Rietveld instead of just submitting.
  • template/en/custom/attachment/rietveldreview.html.tmpl: Added.

New template for rietveldreview mode. Hosts the rietveld frame in the
top and the regular comments form in the bottom.
Uses postMessage to communicate with Rietveld frame.

1:56 PM Changeset in webkit [59264] by Csaba Osztrogonác
  • 9 edits in trunk

[Qt] Detect debug mode consistently
​https://bugs.webkit.org/show_bug.cgi?id=38863

Patch by Laszlo Gombos <Laszlo Gombos> on 2010-05-12
Reviewed by Kenneth Rohde Christiansen.

.:

  • WebKit.pri:

JavaScriptCore:

WebCore:

No new tests as there is no new functionality.

  • WebCore.pro:
1:51 PM Changeset in webkit [59263] by jamesr@google.com
  • 2 edits
    1 add in trunk/WebCore

2010-05-12 James Robinson <​jamesr@chromium.org>

Patch by Dan Bernstein.

Reviewed by David Hyatt.

Fix marking the layout root's parent as needing layout
​https://bugs.webkit.org/show_bug.cgi?id=37760

If an element gets marked as needing layout due to the recalcStyle()
call in FrameView::layout(), the m_layoutSchedulingEnabled flag will
be set to false. It's possible at this point that a parent of the
existing FrameView::m_layoutRoot will be marked as needing layout.

This patch updates FrameView::scheduleRelayoutOfSubtree to account
for this case.

Manual test only due to subtle timing issues.

  • manual-tests/layoutroot_detach.xml: Added.
  • page/FrameView.cpp: (WebCore::FrameView::scheduleRelayoutOfSubtree):
1:50 PM Changeset in webkit [59262] by Martin Robinson
  • 2 edits in trunk/LayoutTests

2010-05-12 Martin Robinson <​mrobinson@igalia.com>

Not reviewed.

[GTK] svg/custom/svg-fonts-with-no-element-reference.html is one pixel different on x86_64
​https://bugs.webkit.org/show_bug.cgi?id=39022

Skipping failing tests for GTK+.

  • platform/gtk/Skipped:
1:32 PM Changeset in webkit [59261] by Csaba Osztrogonác
  • 2 edits in trunk/WebKitTools

[Qt] Slave losts cause build break on bots
​https://bugs.webkit.org/show_bug.cgi?id=38980

Reviewed by Kenneth Rohde Christiansen.

  • Scripts/build-webkit: Remove 0 byte sized files from productDir before build.
1:24 PM Changeset in webkit [59260] by crogers@google.com
  • 4 edits in branches/audio/WebCore/audio

Add noteGrainOn() to AudioBufferSourceNode

  • this is a temporary name to get us going until final names determined
1:24 PM Changeset in webkit [59259] by crogers@google.com
  • 2 edits in branches/audio/WebCore

Add AudioPannerNode to DOMWindow so we can have panner constants

1:24 PM Changeset in webkit [59258] by crogers@google.com
  • 1 edit in branches/audio/WebCore/audio/EqualPowerPanner.cpp

Fix EqualPowerPanner to always process the correct number of frames

1:24 PM Changeset in webkit [59257] by crogers@google.com
  • 1 edit in branches/audio/.gitignore

Update .gitignore to ignore a gyp-generated file

1:10 PM Changeset in webkit [59256] by eric@webkit.org
  • 8 edits
    2 deletes in trunk

2010-05-12 Eric Seidel <​eric@webkit.org>

Unreviewed, rolling out r59245.
​http://trac.webkit.org/changeset/59245
​https://bugs.webkit.org/show_bug.cgi?id=38874

Broke at least one test on multiple platforms

  • editing/deleting/delete-block-contents-004-expected.txt: Removed.
  • editing/deleting/delete-block-contents-004.html: Removed.
  • editing/deleting/in-visibly-empty-root-expected.txt:
  • platform/mac/editing/deleting/5408255-expected.txt:
  • platform/mac/editing/deleting/delete-select-all-001-expected.txt:
  • platform/mac/editing/selection/4895428-1-expected.txt:
  • platform/mac/editing/selection/4895428-4-expected.txt:

2010-05-12 Eric Seidel <​eric@webkit.org>

Unreviewed, rolling out r59245.
​http://trac.webkit.org/changeset/59245
​https://bugs.webkit.org/show_bug.cgi?id=38874

Broke at least one test on multiple platforms

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::removeChild):
1:08 PM Changeset in webkit [59255] by Csaba Osztrogonác
  • 2 edits in trunk/WebKitTools

Unreviewed trivial fix after r59254.

  • Scripts/old-run-webkit-tests:
1:01 PM Changeset in webkit [59254] by Csaba Osztrogonác
  • 2 edits in trunk/WebKitTools

run-webkit-tests --exit-after-N-failures should not count new tests as failures
​https://bugs.webkit.org/show_bug.cgi?id=31829

Reviewed by Eric Seidel.

  • Scripts/old-run-webkit-tests:
12:48 PM Changeset in webkit [59253] by Martin Robinson
  • 3 edits in trunk/LayoutTests

2010-05-12 Martin Robinson <​mrobinson@igalia.com>

Not reviewed. Try number 3 to properly add new baselines and remove remaining
merge marker from this file.

  • platform/gtk/fast/css/input-search-padding-expected.txt:
  • platform/gtk/svg/custom/svg-fonts-with-no-element-reference-expected.txt:
12:41 PM Changeset in webkit [59252] by jamesr@google.com
  • 1 edit in trunk/LayoutTests/ChangeLog

Fix LayoutTest/ChangeLog bad merge

12:36 PM Changeset in webkit [59251] by jamesr@google.com
  • 3 edits in trunk/LayoutTests

2010-04-29 James Robinson <​jamesr@chromium.org>

Reviewed by Simon Fraser.

Test that when a frame with fixed position elements is scrolled via the
keyboard that the correct repaints happen.
​https://bugs.webkit.org/show_bug.cgi?id=38286


  • fast/repaint/fixed-move-after-keyboard-scroll.html: Added.
  • fast/repaint/resources/fixed-move-after-keyboard-scroll-iframe.html: Added.
  • platform/chromium/test_expectations.txt:
  • platform/mac/fast/repaint/fixed-move-after-keyboard-scroll-expected.checksum: Added.
  • platform/mac/fast/repaint/fixed-move-after-keyboard-scroll-expected.png: Added.
  • platform/mac/fast/repaint/fixed-move-after-keyboard-scroll-expected.txt: Added.
12:19 PM Changeset in webkit [59250] by ap@apple.com
  • 3 edits
    3 adds in trunk

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=38752
Strange behaviour after js insertion into a page pointing directly to an object (image, swf, etc)

Test: fast/images/extra-image-in-image-document.html

  • loader/ImageLoader.cpp: (WebCore::ImageLoader::updateFromElement): Reset setAutoLoadImages after manually feeding an image - there may be more coming.
12:12 PM Changeset in webkit [59249] by Martin Robinson
  • 5 edits
    2 adds in trunk/LayoutTests

2010-05-12 Martin Robinson <Martin Robinson>

Not reviewed. Trying once more to generate baselines for GTK+.

  • platform/gtk/fast/css/input-search-padding-expected.txt:
  • platform/gtk/fast/forms/placeholder-stripped-expected.txt:
  • platform/gtk/fast/frames/take-focus-from-iframe-expected.txt:
  • platform/gtk/fast/images/svg-background-partial-redraw-expected.txt: Added.
  • platform/gtk/fast/repaint/fixed-move-after-keyboard-scroll-expected.txt:
  • platform/gtk/svg/custom/repaint-stroke-width-changes-expected.txt: Copied from LayoutTests/platform/mac/svg/custom/repaint-stroke-width-changes-expected.txt.
12:09 PM Changeset in webkit [59248] by yael.aharon@nokia.com
  • 3 edits in trunk/WebCore

HTMLLabelElement::control() should return HTMLFormControlElement, not HTMLElement
​https://bugs.webkit.org/show_bug.cgi?id=38991

Reviewed by Dan Bernstein.

No new tests since no new functionality was introduced.

  • html/HTMLLabelElement.cpp:

(WebCore::HTMLLabelElement::control):

  • html/HTMLLabelElement.h:
12:03 PM Changeset in webkit [59247] by hyatt@apple.com
  • 2 edits in trunk/WebCore

​https://bugs.webkit.org/show_bug.cgi?id=38891

Reviewed by Darin Adler.

First-letter had a number of bugs that were exposed by my attempt to optimize the setting of styles when updating first-letter.
The code that drills down to find the first-letter child stopped if it hit an element that didn't need layout. This means it could
return random incorrect results (and cause the first-letter object to not be found).

In addition when the first-letter was floated/positioned, the text child was not correctly returned, but the container itself was
returned instead.

Finally, the updating code was leaving the box that wrapped the first letter text with a stale style. The old code happened to work because
it made new styles for the text elements instead of using the enclosing box style. The regression was caused by my change to make the
text children simply share style with their parent (thus making the bug that the parent had the wrong style become more prominent).

No new tests, since there's a timing component to reproducing the issue.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::updateFirstLetter):

11:30 AM Changeset in webkit [59246] by jamesr@google.com
  • 2 edits in trunk/WebKitTools

2010-05-12 James Robinson <​jamesr@chromium.org>

Reviewed by Simon Fraser.

Disable smooth scrolling on OS X when running tests
​https://bugs.webkit.org/show_bug.cgi?id=38964

Some tests (like fast/repaint/fixed-move-after-keyboard-scroll.html)
depend on smooth scrolling behavior. Since this is off by default
in Leopard and on by default in Snow Leopard, DRT should turn it
off always to ensure a consistent test environment.

  • DumpRenderTree/mac/DumpRenderTree.mm: (resetDefaultsToConsistentValues):
11:29 AM Changeset in webkit [59245] by enrica@apple.com
  • 8 edits
    2 adds in trunk

Adding block elements to a block and removing them changes the height of the element.
​https://bugs.webkit.org/show_bug.cgi?id=38874

Reviewed by Dave Hyatt.

WebCore:

The initial height of an empty editable block is different from the height of the same block after we add block elements
and remove them.

Test: editing/deleting/delete-block-contents-004.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::removeChild): m_childrenInline was set to true only when the Renderer is created
and never reset to true when all the block elements contained are removed.

LayoutTests:

  • editing/deleting/delete-block-contents-004-expected.txt: Added.
  • editing/deleting/delete-block-contents-004.html: Added.

The following tests have new results because of the height change and because we now have one less renderer after the DOM changes.

  • editing/deleting/in-visibly-empty-root-expected.txt:
  • platform/mac/editing/deleting/5408255-expected.txt:
  • platform/mac/editing/deleting/delete-select-all-001-expected.txt:
  • platform/mac/editing/selection/4895428-1-expected.txt:
  • platform/mac/editing/selection/4895428-4-expected.txt:
11:26 AM Changeset in webkit [59244] by Martin Robinson
  • 1 edit
    22 adds in trunk/LayoutTests

2010-05-12 Martin Robinson <​mrobinson@igalia.com>

Not reviewed. Added baselines to these tests which are passing interactively.

  • platform/gtk/fast/css-generated-content/after-duplicated-after-split-expected.txt: Added.
  • platform/gtk/fast/css/input-search-padding-expected.txt: Added.
  • platform/gtk/fast/forms/placeholder-stripped-expected.txt: Added.
  • platform/gtk/fast/frames/take-focus-from-iframe-expected.txt: Added.
  • platform/gtk/fast/repaint/fixed-child-move-after-scroll-expected.txt: Added.
  • platform/gtk/fast/repaint/fixed-child-of-fixed-move-after-scroll-expected.txt: Added.
  • platform/gtk/fast/repaint/fixed-child-of-transformed-move-after-scroll-expected.txt: Added.
  • platform/gtk/fast/repaint/fixed-move-after-keyboard-scroll-expected.txt: Added.
  • platform/gtk/fast/repaint/fixed-move-after-scroll-expected.txt: Added.
  • platform/gtk/fast/repaint/fixed-tranformed-expected.txt: Added.
  • platform/gtk/fast/text/format-control-expected.txt: Added.
  • platform/gtk/fast/text/international/bold-bengali-expected.txt: Added.
  • platform/gtk/svg/custom/svg-fonts-with-no-element-reference-expected.txt: Copied from LayoutTests/platform/mac/svg/custom/svg-fonts-with-no-element-reference-expected.txt.
  • platform/gtk/svg/text/text-hkern-expected.txt: Copied from LayoutTests/platform/mac/svg/text/text-hkern-expected.txt.
  • platform/gtk/svg/text/text-hkern-on-vertical-text-expected.txt: Copied from LayoutTests/platform/mac/svg/text/text-hkern-on-vertical-text-expected.txt.
  • platform/gtk/svg/text/text-vkern-expected.txt: Copied from LayoutTests/platform/mac/svg/text/text-vkern-expected.txt.
  • platform/gtk/svg/text/text-vkern-on-horizontal-text-expected.txt: Copied from LayoutTests/platform/mac/svg/text/text-vkern-on-horizontal-text-expected.txt.
  • platform/gtk/transforms/svg-vs-css-expected.txt: Added.
11:24 AM Changeset in webkit [59243] by pfeldman@chromium.org
  • 13 edits
    4 adds in trunk

2010-05-12 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: disabling style property on container breaks styles inspection for given node.

​https://bugs.webkit.org/show_bug.cgi?id=39005

Tests: inspector/styles-disable-inherited.html

inspector/styles-disable-then-enable.html

  • inspector/front-end/StylesSidebarPane.js: (WebInspector.StylesSidebarPane.prototype._containsInherited): (WebInspector.StylesSidebarPane.prototype._arrayContainsInheritedProperty):
11:15 AM Changeset in webkit [59242] by Darin Adler
  • 1 edit in trunk/WebCore/ChangeLog

HTML Entity Escape the contents of a textarea node when accessed
via the innerHTML and outerHTML node properties.
​https://bugs.webkit.org/show_bug.cgi?id=38922

Patch by Abhishek Arya <​inferno@chromium.org> on 2010-05-12
Reviewed by Darin Adler.

Test: fast/innerHTML/innerHTML-special-elements.html

  • editing/markup.cpp:

(WebCore::appendStartMarkup):

11:13 AM Changeset in webkit [59241] by Darin Adler
  • 5 edits
    2 adds in trunk

2010-05-12 Abhishek Arya <​inferno@chromium.org>

Reviewed by Darin Adler.

HTML Entity Escape the contents of a textarea node when accessed via the innerHTML and outerHTML node properties.
​https://bugs.webkit.org/show_bug.cgi?id=38922

Test: fast/encoding/textnode-XSS.html

  • editing/markup.cpp: (WebCore::appendStartMarkup):

2010-05-12 Abhishek Arya <​inferno@chromium.org>

Reviewed by Darin Adler.

Tests that accessing the innerHTML property of a text node encodes
entities properly. Update existing test to fix the innerHTML result.
​https://bugs.webkit.org/show_bug.cgi?id=38922

  • fast/innerHTML/innerHTML-special-elements-expected.txt: Added.
  • fast/innerHTML/innerHTML-special-elements.html: Added.
  • fast/parser/comment-in-textarea-expected.txt: Update test expectation.
  • fast/parser/script-tests/comment-in-textarea.js: Update test by replacing with html entities of <, > chars in textarea innerHTML result.
10:11 AM Changeset in webkit [59240] by Martin Robinson
  • 6 edits in trunk/WebKit/gtk

2010-05-12 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Xan Lopez.

[Gtk] Use GOwnPtr for code that needs it
​https://bugs.webkit.org/show_bug.cgi?id=21594

Convert many uses of raw pointers to GRefPtr and GOwnPtr in WebKitWebView.

  • WebCoreSupport/ContextMenuClientGtk.cpp: (WebKit::inputMethodsMenuItem):
  • WebCoreSupport/EditorClientGtk.cpp: (WebKit::EditorClient::setInputMethodState): (WebKit::EditorClient::respondToChangedSelection): (WebKit::EditorClient::handleInputMethodKeydown): (WebKit::EditorClient::EditorClient): (WebKit::EditorClient::~EditorClient):
  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::postCommitFrameViewSetup):
  • webkit/webkitprivate.h:
  • webkit/webkitwebview.cpp: (destroy_menu_cb): (webkit_web_view_forward_context_menu_event): (webkit_web_view_key_release_event): (webkit_web_view_button_release_event): (webkit_web_view_focus_in_event): (webkit_web_view_focus_out_event): (webkit_web_view_realize): (webkit_web_view_set_scroll_adjustments): (webkit_web_view_dispose): (webkit_web_view_finalize): (webViewGetDPI): (webkit_web_view_screen_changed): (webkit_web_view_query_tooltip): (webkit_web_view_get_im_context): (webkit_web_view_update_settings): (webkit_web_view_init): (webkit_web_view_set_settings): (webkit_web_view_get_settings): (webkit_web_view_get_inspector): (webkit_web_view_set_window_features): (webkit_web_view_get_window_features): (webkit_web_view_get_back_forward_list): (webkit_web_view_zoom_in): (webkit_web_view_zoom_out): (webkit_web_view_get_encoding): (webkit_web_view_get_custom_encoding): (webkit_web_view_add_resource): (webkit_web_view_get_resource): (webkit_web_view_get_main_resource): (webkit_web_view_clear_resources): (webkit_web_view_get_subresources): (webkit_web_view_set_tooltip_text): (webkit_web_view_get_icon_uri):
9:52 AM Changeset in webkit [59239] by Beth Dakin
  • 5 edits in trunk/WebCore

Fix for ​https://bugs.webkit.org/show_bug.cgi?id=38871 REGRESSION:
Crash clicking background NPR tab after few minutes of sitting idle
-and corresponding-
<rdar://problem/7941504>

Reviewed by Darin Adler.

Move m_mediaCanStartListeners HashSet to Document away from Page.

  • dom/Document.cpp:

(WebCore::Document::Document):
(WebCore::Document::addMediaCanStartListener):
(WebCore::Document::removeMediaCanStartListener):
(WebCore::Document::takeAnyMediaCanStartListener):

  • dom/Document.h:
  • page/Page.cpp:

(WebCore::Page::takeAnyMediaCanStartListener):

  • page/Page.h:

(WebCore::Page::canStartMedia):

9:44 AM Changeset in webkit [59238] by jorlow@chromium.org
  • 5 edits in trunk/WebKit/chromium

2010-05-12 Jeremy Orlow <​jorlow@chromium.org>

Reviewed by Steve Block.

[Chromium] Pass the origin parameter for WebIndexedDatabase::open
​https://bugs.webkit.org/show_bug.cgi?id=38983

  • public/WebIndexedDatabase.h:
  • src/IndexedDatabaseProxy.cpp: (WebCore::IndexedDatabaseProxy::open):
  • src/WebIndexedDatabaseImpl.cpp: (WebKit::WebIndexedDatabaseImpl::open):
  • src/WebIndexedDatabaseImpl.h:
9:10 AM Changeset in webkit [59237] by loislo@chromium.org
  • 11 edits in trunk

2010-05-11 Ilya Tikhonovsky <​loislo@chromium.org>

Reviewed by Pavel Feldman.

WebInspector: Sometimes ResourceRequest records aren't connected to the initiator.
​https://bugs.webkit.org/show_bug.cgi?id=38925

  • inspector/InspectorTimelineAgent.cpp: (WebCore::InspectorTimelineAgent::didScheduleResourceRequest):
  • inspector/InspectorTimelineAgent.h: (WebCore::):
  • inspector/TimelineRecordFactory.cpp: (WebCore::TimelineRecordFactory::createScheduleResourceRequestData):
  • inspector/TimelineRecordFactory.h:
  • inspector/front-end/TimelineAgent.js:
  • inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel): (WebInspector.TimelinePanel.prototype.get _recordStyles): (WebInspector.TimelinePanel.prototype._findParentRecord): (WebInspector.TimelinePanel.prototype._innerAddRecordToTimeline): (WebInspector.TimelinePanel.prototype._clearPanel): (WebInspector.TimelinePanel.FormattedRecord): (WebInspector.TimelinePanel.FormattedRecord.prototype._generatePopupContent): (WebInspector.TimelinePanel.FormattedRecord.prototype._getRecordDetails):
  • loader/loader.cpp: (WebCore::Loader::load):

2010-05-11 Ilya Tikhonovsky <​loislo@chromium.org>

Reviewed by Pavel Feldman.

WebInspector: Sometimes ResourceRequest records aren't connected to the initiator.
​https://bugs.webkit.org/show_bug.cgi?id=38925

  • inspector/timeline-enum-stability-expected.txt:
8:57 AM Changeset in webkit [59236] by tkent@chromium.org
  • 7 edits
    4 adds in trunk

2010-05-12 Kent Tamura <​tkent@chromium.org>

Reviewed by Darin Adler.

placeholder text should be stripped from line breaks
​https://bugs.webkit.org/show_bug.cgi?id=36291

Add a test for placeholder values with CR and LF.

  • fast/forms/placeholder-stripped.html: Added.
  • platform/mac/fast/forms/placeholder-stripped-expected.checksum: Added.
  • platform/mac/fast/forms/placeholder-stripped-expected.png: Added.
  • platform/mac/fast/forms/placeholder-stripped-expected.txt: Added.

2010-05-12 Kent Tamura <​tkent@chromium.org>

Reviewed by Darin Adler.

placeholder text should be stripped from line breaks
​https://bugs.webkit.org/show_bug.cgi?id=36291

According to ​http://dev.w3.org/html5/spec/forms.html#attr-input-placeholder ,
we need to remove CR and LF from the placeholder attribute values.
Introduce HTMLTextFormControlElement::strippedPlaceholder(), which
returns stripped value, and replace getAttribute(placeholderAttr) with it.

Test: fast/forms/placeholder-stripped.html

  • html/HTMLFormControlElement.cpp: (WebCore::HTMLTextFormControlElement::strippedPlaceholder): (WebCore::HTMLTextFormControlElement::isPlaceholderEmpty): (WebCore::HTMLTextFormControlElement::placeholderShouldBeVisible): Use strippedPlaceholder().
  • html/HTMLFormControlElement.h:
  • platform/text/CharacterNames.h: Add carriageReturn.
  • rendering/RenderTextControlMultiLine.cpp: (WebCore::RenderTextControlMultiLine::updateFromElement): Use strippedPlaceholder().
  • rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::updateFromElement): Use strippedPlaceholder().
8:26 AM Changeset in webkit [59235] by tonikitoo@webkit.org
  • 5 edits in trunk

Allows build-webkit script to receive an install prefix as parameter ​https://bugs.webkit.org/show_bug.cgi?id=26224

Reviewed by Kenneth Christiansen , Simon Hausmann and Gustavo Noronha.
Patch by Rodrigo Belem <​rodrigo.belem@openbossa.org>

WebCore:

This patch adds the ability, in the QtWebkit build system, to change
the installation path.

  • WebCore.pro:

WebKitTools:

Added more parameters to build-webkit script, the --prefix for gkt
and --install-libs, --install-headers for qt. Now it is possible
to change the install prefix for gtk and install path for qt.

  • Scripts/build-webkit:
  • Scripts/webkitdirs.pm:
8:05 AM Changeset in webkit [59234] by tonikitoo@webkit.org
  • 2 edits in trunk/WebKit/qt

2010-05-12 Antonio Gomes <​tonikitoo@webkit.org>

Reviewed by Kenneth Christiansen.

[Qt] Remove the unneeded check for QWidgetPageClient @QGraphicsWebView::detachCurrentPage
​https://bugs.webkit.org/show_bug.cgi?id=38989

Reasons:

  • There is no need to check for a QWidgetPageClient-based in QGraphicsWebView.
  • The client has always to be deleted anyways.
  • Api/qgraphicswebview.cpp: (QGraphicsWebViewPrivate::detachPage):
8:04 AM Changeset in webkit [59233] by tonikitoo@webkit.org
  • 3 edits in trunk/WebKit/qt

[Qt] Implement a detachCurrentPage method for QGraphicsWebView and QWebView
​https://bugs.webkit.org/show_bug.cgi?id=38939

Reviewed by Kenneth Christiansen.
Patch by Antonio Gomes <​tonikitoo@webkit.org>

unsetPageIfExists method was renamed to detachCurrentPage method and is now responsible
for doing all the unset logic of page and pageClient references previously done by
the Q{Graphics}WebView destructor(s).

It is a code clean up, no behaviour change.

  • Api/qgraphicswebview.cpp:

(QGraphicsWebViewPrivate::~QGraphicsWebViewPrivate):
(QGraphicsWebView::~QGraphicsWebView):
(QGraphicsWebViewPrivate::detachCurrentPage):
(QGraphicsWebView::setPage):

  • Api/qwebview.cpp:

(QWebViewPrivate::~QWebViewPrivate):
(QWebView::~QWebView):
(QWebViewPrivate::detachCurrentPage):
(QWebView::setPage):

7:35 AM Changeset in webkit [59232] by jer.noble@apple.com
  • 10 edits in trunk

2010-05-12 Jer Noble <​jer.noble@apple.com>

Reviewed by Darin Adler.

Bug 38689: #34005 will break fullscreen video playback
​https://bugs.webkit.org/show_bug.cgi?id=38689

Use the new definition of PlatformMedia to check the actual type
returned by MediaPlayer.

  • FullscreenVideoController.cpp: (FullscreenVideoController::movie):

2010-05-12 Jer Noble <​jer.noble@apple.com>

Reviewed by Darin Adler.

Bug 38689: #34005 will break fullscreen video playback
​https://bugs.webkit.org/show_bug.cgi?id=38689

Use the new definition of PlatformMedia to check the actual type
returned by MediaPlayer.


  • WebView/WebVideoFullscreenController.mm: (-[WebVideoFullscreenController windowDidLoad]):

2010-05-12 Jer Noble <​jer.noble@apple.com>

Reviewed by Darin Adler.


Bug 38689: #34005 will break fullscreen video playback
​https://bugs.webkit.org/show_bug.cgi?id=38689


The PlatformMedia struct now contains a type field indicating which type
it contains. The struct now contains a union of all possible return types,
allowing the type of media returned by MediaPlayerPrivate instances to be
determined at runtime.

  • platform/graphics/MediaPlayer.h: (WebCore::PlatformMedia::): (WebCore::):
  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::platformMedia):
  • platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp: (WebCore::MediaPlayerPrivateQuickTimeVisualContext::platformMedia):
  • platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp: (WebCore::MediaPlayerPrivate::platformMedia):
7:22 AM Changeset in webkit [59231] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

Add a comment to explain the web inspector dynamic property url hook
and that it's there on purpose :)

Reviewed by Laszlo Gombos.

​https://bugs.webkit.org/show_bug.cgi?id=35340

  • WebCoreSupport/InspectorClientQt.cpp:

(WebCore::InspectorClientQt::openInspectorFrontend):

6:52 AM Changeset in webkit [59230] by eric@webkit.org
  • 4 edits in trunk/WebCore

2010-05-12 Young Han Lee <​joybro@company100.net>

Reviewed by Darin Adler.

Add missing ENABLE(SVG) guards.
​https://bugs.webkit.org/show_bug.cgi?id=38892

  • rendering/RenderSVGResourceClipper.cpp:
  • rendering/RenderSVGResourceMarker.cpp:
  • rendering/RenderSVGResourceMasker.cpp:
6:08 AM Changeset in webkit [59229] by pfeldman@chromium.org
  • 3 edits in trunk/WebCore

2010-05-12 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: align sidebar checkboxes on windows.

​https://bugs.webkit.org/show_bug.cgi?id=38986

  • inspector/front-end/StylesSidebarPane.js:
  • inspector/front-end/inspector.css: (.sidebar-pane-subtitle): (body.platform-windows .sidebar-pane-subtitle):
6:05 AM Changeset in webkit [59228] by Philippe Normand
  • 2 edits in trunk/WebKitTools

2010-05-12 Philippe Normand <​pnormand@igalia.com>

Unreviewed, added my IRC nickname.

  • Scripts/webkitpy/common/config/committers.py:
6:02 AM Changeset in webkit [59227] by yael.aharon@nokia.com
  • 10 edits
    10 adds in trunk

Support control attribute of HTMLLabelElement
​https://bugs.webkit.org/show_bug.cgi?id=38688

Reviewed by Darin Adler.

WebCore:

Added support for the control attribute of HTMLLabelElement and changed the logic of determining
which control is associated with the label to conform to HTML5 spec.
Added a manual test for testing the logic of selecting the control to get focused, activated or hovered
when the label gets focused, activated or is hovered.

Test: fast/dom/HTMLLabelElement/click-label.html
Test: fast/dom/HTMLLabelElement/focus-label.html
Test: fast/dom/HTMLLabelElement/label-control.html

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::labelForElement):
(WebCore::AccessibilityRenderObject::correspondingControlForLabelElement):

  • html/HTMLFormControlElement.cpp:

(WebCore::HTMLFormControlElement::isLabelable):

  • html/HTMLFormControlElement.h:
  • html/HTMLLabelElement.cpp:

(WebCore::nodeAsLabelableFormControl):
(WebCore::HTMLLabelElement::control):
(WebCore::HTMLLabelElement::setActive):
(WebCore::HTMLLabelElement::setHovered):
(WebCore::HTMLLabelElement::defaultEventHandler):
(WebCore::HTMLLabelElement::focus):
(WebCore::HTMLLabelElement::accessKeyAction):

  • html/HTMLLabelElement.h:
  • html/HTMLLabelElement.idl:
  • manual-tests/dom/form-control-for-label.html: Added.

WebKit/chromium:

Renamed HTMLLabelElement::correspondingControl to HTMLLabelElement::control

  • src/WebLabelElement.cpp:

(WebKit::WebLabelElement::correspondingControl):

LayoutTests:

  • fast/dom/HTMLLabelElement/click-label-expected.txt: Added.
  • fast/dom/HTMLLabelElement/click-label.html: Added.
  • fast/dom/HTMLLabelElement/focus-label-expected.txt: Added.
  • fast/dom/HTMLLabelElement/focus-label.html: Added.
  • fast/dom/HTMLLabelElement/label-control-expected.txt: Added.
  • fast/dom/HTMLLabelElement/label-control.html: Added.
  • fast/dom/HTMLLabelElement/script-tests: Added.
  • fast/dom/HTMLLabelElement/script-tests/TEMPLATE.html: Added.
  • fast/dom/HTMLLabelElement/script-tests/label-control.js: Added.
5:51 AM Changeset in webkit [59226] by eric@webkit.org
  • 3 edits in trunk/WebCore

2010-05-12 Steve Block <​steveblock@google.com>

Reviewed by David Levin.

Android's writeToFile() is buggy
​https://bugs.webkit.org/show_bug.cgi?id=38908

No new tests, build fix only.

  • platform/android/FileSystemAndroid.cpp: Remove Android's version of writeToFile().
  • platform/posix/FileSystemPOSIX.cpp: Use POSIX version of writeToFile() on Android. (WebCore::writeToFile):
5:21 AM Changeset in webkit [59225] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

Unreviewed.

Other tests make http/tests/xmlhttprequest/null-auth.php fail
​https://bugs.webkit.org/show_bug.cgi?id=32961

http/tests/xmlhttprequest/basic-auth-default.html introduced in r59185,
and it made http/tests/xmlhttprequest/null-auth.php fail on Qt bot, as
http/tests/xmlhttprequest/failed-auth.html did it before.

  • platform/qt/Skipped: http/tests/xmlhttprequest/basic-auth-default.html skipped until fix.
5:11 AM Changeset in webkit [59224] by Philippe Normand
  • 2 edits in trunk/WebCore

2010-05-10 Philippe Normand <​pnormand@igalia.com>

Reviewed by David Levin.

[GStreamer] incoherent #ifdef in GOwnPtrGStreamer.h
​https://bugs.webkit.org/show_bug.cgi?id=38839

Fixed #ifdef/curly braces coherence.

  • platform/graphics/gstreamer/GOwnPtrGStreamer.cpp: (WTF::GstElement):
5:07 AM Changeset in webkit [59223] by Philippe Normand
  • 2 edits in trunk/WebCore

2010-05-10 Philippe Normand <​pnormand@igalia.com>

Reviewed by Dirk Schulze.

[GStreamer] un-needed cairo.h include
​https://bugs.webkit.org/show_bug.cgi?id=38837

Cairo not used in the sink anymore. So it's not needed to include
the header.

  • platform/graphics/gstreamer/VideoSinkGStreamer.h:
4:49 AM Changeset in webkit [59222] by zoltan@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-05-12 Peter Varga <​pvarga@inf.u-szeged.hu>

Reviewed by Gavin Barraclough.

Remove a direct jump in generatePatternCharacterGreedy() and
generatePatternCharacterClassGreedy() functions if quantityCount of the term
is unlimited.
​https://bugs.webkit.org/show_bug.cgi?id=38898

  • yarr/RegexJIT.cpp: (JSC::Yarr::RegexGenerator::generatePatternCharacterGreedy): (JSC::Yarr::RegexGenerator::generateCharacterClassGreedy):
3:58 AM Changeset in webkit [59221] by zherczeg@webkit.org
  • 4 edits in trunk/WebCore

Build fix for Windows and Chromium builds.

Reviewed by Nikolas Zimmermann.

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • svg/graphics/filters/SVGFELighting.cpp:

(WebCore::FELighting::LightingData::upLeftPixelValue):
(WebCore::FELighting::LightingData::upPixelValue):
(WebCore::FELighting::LightingData::upRightPixelValue):
(WebCore::FELighting::LightingData::leftPixelValue):
(WebCore::FELighting::LightingData::centerPixelValue):
(WebCore::FELighting::LightingData::rightPixelValue):
(WebCore::FELighting::LightingData::downLeftPixelValue):
(WebCore::FELighting::LightingData::downPixelValue):
(WebCore::FELighting::LightingData::downRightPixelValue):
(WebCore::FELighting::setPixel):

3:18 AM Changeset in webkit [59220] by zherczeg@webkit.org
  • 23 edits
    2 adds in trunk

WebCore: Implementing SVG filters: feDiffuseLighting and feSpecularLighting
​https://bugs.webkit.org/show_bug.cgi?id=32197
​https://bugs.webkit.org/show_bug.cgi?id=32199

Reviewed by Nikolas Zimmermann.

The patch implements the SVG filters feDiffuseLighting and
feSpecularLighting including the impementation of their possible
light sources according to the Scalable Vector Graphics (SVG)
1.1 Specification. Only two features are missing: supporting images
with height or width set to 1, and kernelUnitLength other than (1,1).
Since the two lighting filters have a similar body, a common base
class called FELighting is introduced, and contains the code for
both filters. The implementation employs single precision floating
point arithmetic (fixed precision integer arithmetic seemed too difficult).

Indentation is removed of the modified header files in svg/graphics/filters

  • GNUmakefile.am:
  • WebCore.pro:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/graphics/FloatPoint3D.cpp:
  • platform/graphics/FloatPoint3D.h:

(WebCore::FloatPoint3D::FloatPoint3D): constructors changed to inline
(WebCore::operator*): dot product

  • svg/SVGFESpotLightElement.cpp:

(WebCore::SVGFESpotLightElement::lightSource):

  • svg/graphics/filters/SVGDistantLightSource.h:

(WebCore::DistantLightSource::create):
(WebCore::DistantLightSource::azimuth):
(WebCore::DistantLightSource::elevation):
(WebCore::DistantLightSource::DistantLightSource):

  • svg/graphics/filters/SVGFEDiffuseLighting.cpp:

(WebCore::FEDiffuseLighting::FEDiffuseLighting):
(WebCore::FEDiffuseLighting::create):

  • svg/graphics/filters/SVGFEDiffuseLighting.h:
  • svg/graphics/filters/SVGFELighting.cpp: Added.

(WebCore::FELighting::FELighting):
(WebCore::FELighting::LightingData::upLeftPixelValue):
(WebCore::FELighting::LightingData::upPixelValue):
(WebCore::FELighting::LightingData::upRightPixelValue):
(WebCore::FELighting::LightingData::leftPixelValue):
(WebCore::FELighting::LightingData::centerPixelValue):
(WebCore::FELighting::LightingData::rightPixelValue):
(WebCore::FELighting::LightingData::downLeftPixelValue):
(WebCore::FELighting::LightingData::downPixelValue):
(WebCore::FELighting::LightingData::downRightPixelValue):
(WebCore::FELighting::setPixel):
(WebCore::FELighting::drawLighting):
(WebCore::FELighting::apply):

  • svg/graphics/filters/SVGFELighting.h: Added.

(WebCore::FELighting::uniteChildEffectSubregions):
(WebCore::FELighting::):

  • svg/graphics/filters/SVGFESpecularLighting.cpp:

(WebCore::FESpecularLighting::FESpecularLighting):
(WebCore::FESpecularLighting::create):

  • svg/graphics/filters/SVGFESpecularLighting.h:
  • svg/graphics/filters/SVGLightSource.cpp:

(WebCore::PointLightSource::initPaintingData):
(WebCore::PointLightSource::updatePaintingData):
(WebCore::SpotLightSource::initPaintingData):
(WebCore::SpotLightSource::updatePaintingData):
(WebCore::DistantLightSource::initPaintingData):
(WebCore::DistantLightSource::updatePaintingData):

  • svg/graphics/filters/SVGLightSource.h:

(WebCore::):
(WebCore::LightSource::LightSource):
(WebCore::LightSource::~LightSource):
(WebCore::LightSource::type):

  • svg/graphics/filters/SVGPointLightSource.h:

(WebCore::PointLightSource::create):
(WebCore::PointLightSource::position):
(WebCore::PointLightSource::PointLightSource):

  • svg/graphics/filters/SVGSpotLightSource.h:

(WebCore::SpotLightSource::create):
(WebCore::SpotLightSource::position):
(WebCore::SpotLightSource::direction):
(WebCore::SpotLightSource::specularExponent):
(WebCore::SpotLightSource::limitingConeAngle):
(WebCore::SpotLightSource::SpotLightSource):

LayoutTests: Updating the pixel tests for feDiffuseLighting and feSpecularLighting
​https://bugs.webkit.org/show_bug.cgi?id=32197
​https://bugs.webkit.org/show_bug.cgi?id=32199

Reviewed by Nikolas Zimmermann.

No new test were added, since SVG expected values cover
the features of the implementation

  • platform/mac/svg/W3C-SVG-1.1/filters-diffuse-01-f-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/filters-diffuse-01-f-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/filters-light-01-f-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/filters-light-01-f-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/filters-specular-01-f-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/filters-specular-01-f-expected.png:
2:35 AM Changeset in webkit [59219] by xan@webkit.org
  • 2 edits in trunk/WebCore

2010-05-12 Xan Lopez <​xlopez@igalia.com>

Reviewed by Nikolas Zimmermann.

Add missing AM_V_GEN directives to generation rules so that they
remain silent when requested.

  • GNUmakefile.am:
2:12 AM Changeset in webkit [59218] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-05-12 Lucas De Marchi <​lucas.demarchi@profusion.mobi>

Reviewed by Jeremy Orlow.

[EFL] It does not make sense to use ScrollbarEfl::ScrollbarEfl, so
use ScrollbarEfl (GCC 4.5 seems to be pickier about this). Revision 59030
fixed cases for RenderThemeEfl, but missed this for ScrollbarEfl.
​http://webkit.org/b/38904

No new tests required.

  • platform/efl/ScrollbarEfl.cpp: (scrollbarEflEdjeMessage):
1:51 AM Changeset in webkit [59217] by morrita@google.com
  • 9 edits in trunk

2010-05-12 MORITA Hajime <​morrita@google.com>

Reviewed by Kent Tamura.

[Chromium] Support HTML5 <progress> element on Windows.
​https://bugs.webkit.org/show_bug.cgi?id=37308

Extended ChromiumBridge to handle progress bar painting,
and added delegations to it.

No new tests. Test cases should be shared with existing ones for
progress element. Expectaions will be added after PROGRESS_TAG is
enabled on Chromium tree.

  • platform/chromium/ChromiumBridge.h:
  • rendering/RenderProgress.cpp: (WebCore::RenderProgress::animationProgress): (WebCore::RenderProgress::isDeterminate):
  • rendering/RenderProgress.h: (WebCore::RenderProgress::position):
  • rendering/RenderThemeChromiumWin.cpp: (WebCore::RenderThemeChromiumWin::animationRepeatIntervalForProgressBar): (WebCore::RenderThemeChromiumWin::animationDurationForProgressBar): (WebCore::RenderThemeChromiumWin::adjustProgressBarStyle): (WebCore::RenderThemeChromiumWin::paintProgressBar):
  • rendering/RenderThemeChromiumWin.h:

2010-05-12 MORITA Hajime <​morrita@google.com>

Reviewed by Kent Tamura.

[Chromium] Support HTML5 <progress> element on Windows.
​https://bugs.webkit.org/show_bug.cgi?id=37308

Extended ChromiumBridge to handle progress bar painting,
and added delegations to it.

No new tests. Test cases should be shared with existing ones for
progress element. Expectaions will be added after PROGRESS_TAG is
enabled on Chromium tree.

  • public/WebThemeEngine.h: (WebKit::WebThemeEngine::paintProgressBar):
  • src/ChromiumBridge.cpp: (WebCore::ChromiumBridge::paintProgressBar):
1:43 AM Changeset in webkit [59216] by eric@webkit.org
  • 5 edits in trunk/WebCore

2010-05-12 Marcus Bulach <​bulach@chromium.org>

Reviewed by Steve Block.

Removes Geolocation::setPosition and uses positionChanged() to capture lastPosition().
This brings CLIENT_BASED_GEOLOCATION more inline with the non-client based.
​https://bugs.webkit.org/show_bug.cgi?id=38195

  • page/Geolocation.cpp: (WebCore::Geolocation::lastPosition): (WebCore::Geolocation::requestPermission): (WebCore::Geolocation::positionChangedInternal): (WebCore::Geolocation::positionChanged): (WebCore::Geolocation::geolocationServicePositionChanged):
  • page/Geolocation.h:
  • page/GeolocationController.cpp: (WebCore::GeolocationController::positionChanged): (WebCore::GeolocationController::lastPosition):
  • page/GeolocationController.h:
1:31 AM Changeset in webkit [59215] by eric@webkit.org
  • 5 edits in trunk

2010-05-12 Marcus Bulach <​bulach@chromium.org>

Reviewed by Steve Block.

Attaches the geolocation bridge later on startUpdating().
This prevents a page requesting permission when it has just accessed navigator.geolocation (without calling navigator.geolocation.getCurrentPosition/watchPosition).
Note: when Geolocation::haveSuitableCachedPosition(), WebGeolocationServiceBridgeImpl::startUpdating() is not called,
so we attach the bridge if needed at requestGeolocationPermissionForFrame().
​https://bugs.webkit.org/show_bug.cgi?id=38323
​http://crbug.com/42789

  • platform/chromium/GeolocationServiceChromium.h:

2010-05-12 Marcus Bulach <​bulach@chromium.org>

Reviewed by Steve Block.

Attaches the geolocation bridge later on startUpdating().
This prevents a page requesting permission when it has just accessed navigator.geolocation (without calling navigator.geolocation.getCurrentPosition/watchPosition).
Note: when Geolocation::haveSuitableCachedPosition(), WebGeolocationServiceBridgeImpl::startUpdating() is not called,
so we attach the bridge if needed at requestGeolocationPermissionForFrame().
​https://bugs.webkit.org/show_bug.cgi?id=38323
​http://crbug.com/42789

  • src/ChromeClientImpl.cpp: (WebKit::ChromeClientImpl::requestGeolocationPermissionForFrame):
  • src/WebGeolocationServiceBridgeImpl.cpp: (WebKit::WebGeolocationServiceBridgeImpl::attachBridgeIfNeeded): (WebKit::WebGeolocationServiceBridgeImpl::setLastPosition):
1:28 AM Changeset in webkit [59214] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

Unreviewed fix.

[Qt] Platform specific expected result updated after r59211.

  • platform/qt/fast/css/pseudo-cache-stale-expected.txt: updated.
1:19 AM Changeset in webkit [59213] by eric@webkit.org
  • 3 edits
    3 adds in trunk

2010-05-12 Robin Qiu <​robin.qiu@torchmobile.com.cn>

Reviewed by Dirk Schulze.

Fix a bug in SVGPathSegList::getPathSegAtLength().
This bug is just a misktake: almost all of the code is OK, but the
parameter is not used at all, therefore, this function always returns
"1".
And make a modification to return the last path segment if the distance
exceeds the actual path length.
​https://bugs.webkit.org/show_bug.cgi?id=37515

  • svg/dom/svgpath-getPathSegAtLength-expected.txt: Added.
  • svg/dom/svgpath-getPathSegAtLength.html: Added.

2010-05-12 Robin Qiu <​robin.qiu@torchmobile.com.cn>

Reviewed by Dirk Schulze.

Fix a bug in SVGPathSegList::getPathSegAtLength().
This bug is just a misktake: almost all of the code is OK, but the
parameter is not used at all, therefore, this function always returns
"1".
And make a modification to return the last path segment if the distance
exceeds the actual path length.
​https://bugs.webkit.org/show_bug.cgi?id=37515

Test: svg/dom/svgpath-getPathSegAtLength.html

  • svg/SVGPathSegList.cpp: (WebCore::SVGPathSegList::getPathSegAtLength):
12:46 AM Changeset in webkit [59212] by tony@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-05-12 Tony Chang <​tony@chromium.org>

Reviewed by Kent Tamura.

[chromium] add DRT back to the chromium build
​https://bugs.webkit.org/show_bug.cgi?id=38978

  • WebKit.gyp:
12:01 AM Changeset in webkit [59211] by hyatt@apple.com
  • 3 edits in trunk

​https://bugs.webkit.org/show_bug.cgi?id=38976, fast/css/pseudo-cache-stale.html has incorrect results.

Reviewed by Maciej Stachowiak.

Make sure to trigger a relayout of any objects whose first-line styles change dynamically.

  • dom/Element.cpp:

(WebCore::Element::pseudoStyleCacheIsInvalid):

May 11, 2010:

10:50 PM Changeset in webkit [59210] by Joseph Pecoraro
  • 2 edits in trunk/WebCore

2010-05-11 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by Timothy Hatcher.

Web Inspector: Shorthand Properties Getting Deleted When Editing
​https://bugs.webkit.org/show_bug.cgi?id=38958

  • inspector/front-end/DOMAgent.js: (WebInspector.CSSStyleDeclaration.prototype.styleTextWithShorthands): was getting regular values instead of shorthand values
10:10 PM Changeset in webkit [59209] by Chris Jerdonek
  • 2 edits in trunk/WebKitTools

2010-05-11 Chris Jerdonek <Chris Jerdonek>

Reviewed by Eric Seidel.

Fixed two FIXME's in svn-apply: eliminated the unnecessary %copiedFiles
variable and changed gitKnowsOfFile() to use exitStatus().

​https://bugs.webkit.org/show_bug.cgi?id=38862

  • Scripts/svn-apply:
9:58 PM WebKit Team edited by andreas.kling@nokia.com
(diff)
9:57 PM WebKit Team edited by andreas.kling@nokia.com
(diff)
9:56 PM Changeset in webkit [59208] by eric@webkit.org
  • 3 edits in trunk/WebKitTools

2010-05-11 Eric Seidel <​eric@webkit.org>

Unreviewed, just fixing python typo.

EWS bots should poll more often than every 5 minutes
​https://bugs.webkit.org/show_bug.cgi?id=38968

Typo in _now(), add a unittest to prove I fixed it.

  • Scripts/webkitpy/tool/bot/queueengine.py:
  • Scripts/webkitpy/tool/bot/queueengine_unittest.py:
9:44 PM Changeset in webkit [59207] by abarth@webkit.org
  • 3 edits in trunk/WebKitTools

2010-05-11 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Qt build failures cause SheriffBot false positives
​https://bugs.webkit.org/show_bug.cgi?id=38969

The Qt buildbot randomly fails to compile occasionally because its
network connection causes SVn to leave zero-byte files around. These
compile failures confuse SheriffBot into thinking someone's patch
caused a build break.

In this patch, I've temporarily removed Qt from the list of core
builders. Ossy is working on a script to clean up the zero byte files.
Once that goes in, we can add Qt back to the core builders.

  • Scripts/webkitpy/common/net/buildbot.py:
  • Scripts/webkitpy/common/net/buildbot_unittest.py:
9:36 PM Changeset in webkit [59206] by eric@webkit.org
  • 3 edits in trunk/WebKitTools

2010-05-11 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

sheriffbot is spammy.
​https://bugs.webkit.org/show_bug.cgi?id=38936

Reduce sheriffbot spam by not warning about new blameworthy revisions
that can be explained by previously blamed revisions. This might cause
us to not warn about some real failures, but we're getting too much
spam from slow builders that have large blamelists (and we've already
poked the responsible folks using data from a fast builder).

  • Scripts/webkitpy/tool/bot/sheriff_unittest.py:
    • Removed unneeded import
  • Scripts/webkitpy/tool/commands/sheriffbot.py:
    • The logic change
  • Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
    • Tests of the change
  • Scripts/webkitpy/tool/mocktool.py:
    • Merged two declarations of MockBuilder
9:30 PM Changeset in webkit [59205] by ggaren@apple.com
  • 2 edits in trunk/JavaScriptCore

Slight simplification to the calling convention: read RegisterFile::end()
from an absolute address, instead of from a pointer to the RegisterFile
on the stack.

Reviewed by Gavin Barraclough.

SunSpider reports no change.

This should free us to remove the RegisterFile argument from the stack.

  • jit/JIT.cpp:

(JSC::JIT::privateCompile):

9:20 PM Changeset in webkit [59204] by abarth@webkit.org
  • 5 edits in trunk/WebKitTools

2010-05-11 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

sheriffbot is spammy.
​https://bugs.webkit.org/show_bug.cgi?id=38936

Reduce sheriffbot spam by not warning about new blameworthy revisions
that can be explained by previously blamed revisions. This might cause
us to not warn about some real failures, but we're getting too much
spam from slow builders that have large blamelists (and we've already
poked the responsible folks using data from a fast builder).

  • Scripts/webkitpy/tool/bot/sheriff_unittest.py:
    • Removed unneeded import
  • Scripts/webkitpy/tool/commands/sheriffbot.py:
    • The logic change
  • Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
    • Tests of the change
  • Scripts/webkitpy/tool/mocktool.py:
    • Merged two declarations of MockBuilder
8:53 PM Changeset in webkit [59203] by tony@chromium.org
  • 4 edits in trunk

2010-05-11 Tony Chang <​tony@chromium.org>

Reviewed by Darin Fisher.

[chromium] Remove subframe scrollbar routing (r58937)
​https://bugs.webkit.org/show_bug.cgi?id=38894

  • platform/win/Skipped: This test should pass on windows.

2010-05-11 Tony Chang <​tony@chromium.org>

Reviewed by Darin Fisher.

[chromium] Remove subframe scrollbar routing (r58937)
​https://bugs.webkit.org/show_bug.cgi?id=38894

  • page/chromium/EventHandlerChromium.cpp: (WebCore::EventHandler::passMousePressEventToSubframe):
8:53 PM Changeset in webkit [59202] by bweinstein@apple.com
  • 3 edits in trunk/JavaScriptCore

Possible Gtk build fix - use ALWAYS_INLINE on functions that were inlined.

  • wtf/text/AtomicString.h:

(WebCore::AtomicString::add): Use ALWAYS_INLINE.

  • wtf/text/WTFString.h:

(WebCore::String::length): Ditto.
(WebCore::String::isEmpty): Ditto.

8:51 PM Changeset in webkit [59201] by tony@chromium.org
  • 2 edits in trunk/WebKitTools

2010-05-11 Tony Chang <​tony@chromium.org>

Reviewed by David Levin.

[chromium] detect num processors to pass to make -j on Linux
​https://bugs.webkit.org/show_bug.cgi?id=38833

  • Scripts/webkitdirs.pm:
8:41 PM Changeset in webkit [59200] by eric@webkit.org
  • 5 edits in trunk/WebKitTools

2010-05-11 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

commit-queue should commit rollouts without running tests
​https://bugs.webkit.org/show_bug.cgi?id=38940

Most of this change is improving our test coverage for the commit-queue.
The only functional change is removing the --test flag when the commit-queue
is running in rollouts mode.

I added test coverage for status updates, and updated the commit-queue status
messages to distinguish rollout vs. normal landing mode in its empty queue
and land patch messages.

  • Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
    • Got rid of a bunch of copy/paste code using _default_expected_stderr
  • Scripts/webkitpy/tool/commands/queues.py:
    • Moved rollout patch filtering out of _validate_patches_in_commit_queue so that we only have to check if the builders are green in one place.
    • Make the "empty queue" message note which queue it is referring to.
    • Don't pass --text to land-attachment when in rollout mode.
  • Scripts/webkitpy/tool/commands/queues_unittest.py:
    • Update results now that we're testing status updates.
    • Test _can_build_and_test since I made a typo in that call while writing this change and the unit tests failed to catch it!
  • Scripts/webkitpy/tool/mocktool.py:
    • Log status updates to make them testable in our unit tests.
8:25 PM Changeset in webkit [59199] by Simon Fraser
  • 3 edits
    4 adds in trunk

2010-05-11 Simon Fraser <Simon Fraser>

Reviewed by Maciej Stachowiak.

Body not redrawn, and filled with garbage on some composited pages
​https://bugs.webkit.org/show_bug.cgi?id=38951
<rdar://problem/7891548>

When the root layer becomes composited (for example, because a negative z-index
descendant in its stacking context becomes composited), then it has to be made
large enough to fill the viewport, because the page background draws into it.

Test: compositing/geometry/composited-html-size.html

  • rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::calculateCompositedBounds):
7:33 PM Changeset in webkit [59198] by andersca@apple.com
  • 2 edits in trunk/JavaScriptCore

Add a compile time assert that sizeof(String) == sizeof(AtomicString).

Reviewed by Sam Weinig.

  • wtf/text/AtomicString.cpp:
7:28 PM Changeset in webkit [59197] by andersca@apple.com
  • 6 edits in trunk

2010-05-11 Anders Carlsson <​andersca@apple.com>

Reviewed by Mark Rowe.

​https://bugs.webkit.org/show_bug.cgi?id=38961
Move some member variables around to reduce class sizes.


Make AtomicString no longer inherit from FastAllocBase.

Since AtomicString's first (and only) member variable, a RefPtr, also inherits from FastAllocBase this
was causing the size of AtomicString to contain sizeof(void*) bytes of padding.

  • wtf/text/AtomicString.h:

2010-05-11 Anders Carlsson <​andersca@apple.com>

Reviewed by Mark Rowe.

​https://bugs.webkit.org/show_bug.cgi?id=38961
Move some member variables around to reduce class sizes.

If a class inherits (directly or indirectly) from FastAllocBase, we don't want the first member variable
of that class to also inherit (directly or indirectly) from FastAllocBase as this will add padding to the class
and thus increasing its size.

  • css/CSSParserValues.h:
  • css/CSSSelector.h: (WebCore::CSSSelector::CSSSelector): (WebCore::CSSSelector::RareData::RareData):
  • platform/graphics/FontCache.cpp: (WebCore::FontPlatformDataCacheKey::FontPlatformDataCacheKey):
7:25 PM Changeset in webkit [59196] by bweinstein@apple.com
  • 8 edits in trunk/JavaScriptCore

Patch by Gavin Barraclough.

Reviewed by Maciej Stachowiak.

Rest of REGRESSION (r57900-57919): 3% PLT Regression from moving strings into WTF.
​https://bugs.webkit.org/show_bug.cgi?id=38930
<rdar://problem/7937188>

Inline string functions that are commonly used in WTFString, CString, and AtomicString.

  • JavaScriptCore.exp: Remove exports of inline functions.
  • wtf/text/AtomicString.cpp:

(WebCore::AtomicString::addSlowCase): Rename add to addSlowCase, and inline the fast path

of add.

  • wtf/text/AtomicString.h:

(WebCore::AtomicString::add): Inline the fast path of add.

  • wtf/text/CString.cpp: Inline implementation of data and length in the header.
  • wtf/text/CString.h:

(WTF::CString::data): Inline implementation of data.
(WTF::CString::length): Inline implementation of length.

  • wtf/text/WTFString.cpp: Remove implementations of functions to be inlined.
  • wtf/text/WTFString.h:

(WebCore::String::String): Inline implementation.
(WebCore::String::length): Ditto.
(WebCore::String::characters): Ditto.
(WebCore::String::operator[]): Ditto.
(WebCore::String::isEmpty): Ditto.

7:20 PM Changeset in webkit [59195] by dumi@chromium.org
  • 3 edits in trunk/WebCore

Adding a function needed by the V8 code generator to turn on/off
the binding for WorkerContext::openDatabaseSync().
​https://bugs.webkit.org/show_bug.cgi?id=38960

Reviewed by Adam Barth.

  • bindings/generic/RuntimeEnabledFeatures.cpp:

(WebCore::RuntimeEnabledFeatures::openDatabaseSyncEnabled):

  • bindings/generic/RuntimeEnabledFeatures.h:
7:15 PM Changeset in webkit [59194] by morrita@google.com
  • 3 edits
    5 adds in trunk

2010-05-11 MORITA Hajime <​morrita@google.com>

Reviewed by Dirk Schulze.

CSS SVG font doesn't recognize URL without element reference
​https://bugs.webkit.org/show_bug.cgi?id=37144

  • platform/mac/svg/custom/svg-fonts-with-no-element-reference-expected.checksum: Added.
  • platform/mac/svg/custom/svg-fonts-with-no-element-reference-expected.png: Added.
  • platform/mac/svg/custom/svg-fonts-with-no-element-reference-expected.txt: Added.
  • svg/custom/resources/graffiti-with-empty-first-font.svg: Added.
  • svg/custom/svg-fonts-with-no-element-reference.html: Added.

2010-05-11 MORITA Hajime <​morrita@google.com>

Reviewed by Dirk Schulze.

CSS SVG font doesn't recognize URL without element reference
​https://bugs.webkit.org/show_bug.cgi?id=37144

CachedFont::getSVGFontById() did assume that element reference (ID) is given.
So fixed to handle an empty or missing element reference. In which case,
the first font element is returned if available.

Test: svg/custom/svg-fonts-with-no-element-reference.html

  • loader/CachedFont.cpp: (WebCore::CachedFont::getSVGFontById):
6:53 PM Changeset in webkit [59193] by tkent@chromium.org
  • 14 edits
    2 adds in trunk

2010-05-11 Kent Tamura <​tkent@chromium.org>

Reviewed by Dimitri Glazkov.

[DRT/Chromium] Apply recent changes of test_shell to DRT
​https://bugs.webkit.org/show_bug.cgi?id=38895

  • DEPS: Update Chromium revision to use the recent webkit_support change.
  • WebKit.gyp: Add JavaScriptCore/wtf to 'include' section.
  • src/WebGraphicsContext3D.cpp: Remove ENABLE(3D_CANVAS) to provide an empty implementation of WebGraphicsContext3D::createDefault().

2010-05-11 Kent Tamura <​tkent@chromium.org>

Reviewed by Dimitri Glazkov.

[DRT/Chromium] Apply recent changes of test_shell to DRT
​https://bugs.webkit.org/show_bug.cgi?id=38895

Port the changes to test_shell during (r40492, r46810] of Chromium.
Highlights:

  • Introduce NotificationPresenter
  • Fix parameter mismatch of WebViewClient::startDragging()

This change fixes dozens of unexpected behaviors.

  • DumpRenderTree/DumpRenderTree.gypi: Add NotificationPresenter.{cpp,h}
  • DumpRenderTree/chromium/EventSender.cpp: (applyKeyModifier): (EventSender::EventSender): (EventSender::reset): (EventSender::webview): (EventSender::doDragDrop): (EventSender::keyDown): (EventSender::addTouchPoint): (EventSender::clearTouchPoints): (EventSender::releaseTouchPoint): (EventSender::setTouchModifier): (EventSender::updateTouchPoint): (EventSender::cancelTouchPoint): (EventSender::sendCurrentTouchEvent): (EventSender::touchEnd): (EventSender::touchMove): (EventSender::touchStart): (EventSender::touchCancel):
  • DumpRenderTree/chromium/EventSender.h:
  • DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): (LayoutTestController::reset): (LayoutTestController::showWebInspector): (LayoutTestController::setAuthorAndUserStylesEnabled): (LayoutTestController::setScrollbarPolicy): (LayoutTestController::setWillSendRequestClearHeader): (LayoutTestController::callShouldCloseOnWebView): (LayoutTestController::grantDesktopNotificationPermission): (LayoutTestController::removeOriginAccessWhitelistEntry): (LayoutTestController::addUserScript): (LayoutTestController::addUserStyleSheet):
  • DumpRenderTree/chromium/LayoutTestController.h:
  • DumpRenderTree/chromium/NotificationPresenter.cpp: Added.
  • DumpRenderTree/chromium/NotificationPresenter.h: Added.
  • DumpRenderTree/chromium/TestShell.cpp: (TestShell::TestShell): (TestShell::runFileTest): (TestShell::resetTestController):
  • DumpRenderTree/chromium/TestShell.h: (TestShell::eventSender): (TestShell::notificationPresenter): (TestShell::showDevTools):
  • DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::createView): (WebViewHost::createPopupMenu): (WebViewHost::startDragging): (WebViewHost::notificationPresenter): (WebViewHost::createApplicationCacheHost): (WebViewHost::willSendRequest): (WebViewHost::updateAddressBar): (WebViewHost::updateURL):
  • DumpRenderTree/chromium/WebViewHost.h: (WebViewHost::addClearHeader): (WebViewHost::clearHeaders):
6:35 PM Changeset in webkit [59192] by jer.noble@apple.com
  • 2 edits in trunk/WebCore

No Review.

Fix the Windows Debug Build: the correct VCProj variable to use when linking against
JavaScriptCore is $(WebKitDLLConfigSuffix), not $(WebKitConfigSuffix), which expands
to an empty string rather than "_debug".

  • WebCore.vcproj/QTMovieWin.vcproj:
6:16 PM Changeset in webkit [59191] by jer.noble@apple.com
  • 2 edits in trunk/WebKit/win

No Review.

Fix build error: The QTMovieWin project is dependent on the JavaScriptCore project.

  • WebKit.vcproj/WebKit.sln:
5:41 PM Changeset in webkit [59190] by jer.noble@apple.com
  • 2 edits in trunk/WebCore

2010-05-11 Jer Noble <​jer.noble@apple.com>

Darin Adler.

19 media tests are crashing on Windows Release
​https://bugs.webkit.org/show_bug.cgi?id=38950
rdar://problem/7971658

Link against JavaScriptCore.lib instead of WTF.lib, so the free and malloc used by
QTMovieWin is always the free and malloc in JavaScriptCore.dll.


  • WebCore.vcproj/QTMovieWin.vcproj:
5:35 PM Changeset in webkit [59189] by Darin Adler
  • 6 edits in trunk/WebCore

Another refactoring patch in preparation for a fix to
​https://bugs.webkit.org/show_bug.cgi?id=38871
REGRESSION: Crash clicking background NPR tab after few minutes of sitting idle

Reviewed by Beth Dakin.

  • dom/Document.cpp:

(WebCore::Document::addMediaCanStartListener): Added.
(WebCore::Document::removeMediaCanStartListener): Added.

  • dom/Document.h: Added add/removeMediaCanStartListener.
  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::~HTMLMediaElement): Call removeMediaCanStartListener
on the document instead of the page.
(WebCore::HTMLMediaElement::willMoveToNewOwnerDocument): Call
removeMediaCanStartListener on the current document.
(WebCore::HTMLMediaElement::didMoveToNewOwnerDocument): Call
addMediaCanStartListener on the new document.
(WebCore::HTMLMediaElement::loadInternal): Call addMediaCanStartListener
on the document instead of the page.

  • plugins/PluginView.cpp:

(WebCore::PluginView::startOrAddToUnstartedList): Call addMediaCanStartListener
on the document instead of the page.
(WebCore::PluginView::~PluginView): Call removeMediaCanStartListener
on the document instead of the page, and do it in line instead of calling
a function.

  • plugins/PluginView.h: Removed unused removeFromUnstartedListIfNecessary.
5:26 PM Changeset in webkit [59188] by ap@apple.com
  • 2 edits in trunk/LayoutTests

Not reviewed.

​https://bugs.webkit.org/show_bug.cgi?id=38956
[Gtk] http/tests/xmlhttprequest/basic-auth-default.html fails

  • platform/gtk/Skipped: Skipping the new failing test on Gtk.
5:22 PM Changeset in webkit [59187] by bweinstein@apple.com
  • 15 edits
    1 add in trunk

JavaScriptCore: Patch by Gavin Barraclough.

Reviewed by Steve Falkenburg and Jon Honeycutt.

REGRESSION (r57900-57919): 3% PLT Regression from moving strings into WTF.
​https://bugs.webkit.org/show_bug.cgi?id=38930
<rdar://problem/7937188>

When the String classes were moved from WebCore to WTF, it meant that on Windows, all operations
on Strings in WebCore had to cross a DLL boundary (from WebKit.dll to JavaScript.dll).

We fix this by refactoring some of the WTF string code, so the code in AtomicString, StringImpl, and
WTFString can be built by both WebCore and WTF, and we don't need to talk across a DLL to do operations
on Strings.

handled in WebCore.

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Remove the post-build step that was added

here (the post build step is in JavaScriptCoreCommon.vsprops).

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreCommon.vsprops: Copy the three cpp files that need to be compiled

by WebCore into the WebKitOutputDir directory.

  • JavaScriptCore.vcproj/WTF/WTF.vcproj: Add the StringStatics file.
  • JavaScriptCore.vcproj/jsc/jsc.vcproj: Add the three WTF string cpp files to this project.
  • JavaScriptCore.vcproj/jsc/jscCommon.vsprops: Remove the need to link against WTF.lib (since jsc links against JavaScriptCore).
  • JavaScriptCore.xcodeproj/project.pbxproj: Add the StringStatics file.
  • wtf/text/AtomicString.cpp: Moved code to StringStatics.
  • wtf/text/StringImpl.cpp: Ditto.
  • wtf/text/StringStatics.cpp: Added. Move functions in WTF Strings that define static variables to here, so

the rest of the files can be compiled in WebCore.

(WebCore::StringImpl::empty): Moved from StringImpl.cpp to here.
(WebCore::AtomicString::init): Moved from AtomicString.cpp to here.

WebCore: Patch by Gavin Barraclough.

Reviewed by Steve Falkenburg and Jon Honeycutt.

REGRESSION (r57900-57919): 3% PLT Regression from moving strings into WTF.
​https://bugs.webkit.org/show_bug.cgi?id=38930
<rdar://problem/7937188>

Add the WTF strings into the WebCore vcproj, from their copied location in $(WebKitOutputDir).

No new tests because no change in behavior.

  • WebCore.vcproj/WebCore.vcproj:
5:04 PM Changeset in webkit [59186] by Beth Dakin
  • 3 edits in trunk/WebCore

Small re-factoring patch in preparation for fixing ​https://
bugs.webkit.org/show_bug.cgi?id=38871 REGRESSION: Crash clicking
background NPR tab after few minutes of sitting idle

Reviewed by Darin Adler.

  • page/Page.cpp:

(WebCore::Page::takeAnyMediaCanStartListener):
(WebCore::Page::setCanStartMedia):

  • page/Page.h:
4:41 PM Changeset in webkit [59185] by ap@apple.com
  • 4 edits
    8 adds in trunk

Reviewed by Brady Eidson.

​https://bugs.webkit.org/show_bug.cgi?id=37989
Safari (still) doesn't always send basic credentials preemptively

Test: http/tests/xmlhttprequest/basic-auth-default.html

After fetching credentials from WebCore storage, put them back right away. This will add
default credentials for the directory, since this may be the first time we learn about its
associated protection space.

  • platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::ResourceHandle::didReceiveAuthenticationChallenge): (WebCore::WebCoreSynchronousLoader::didReceiveChallenge):
  • platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::didReceiveAuthenticationChallenge): (-[WebCoreSynchronousLoader connection:didReceiveAuthenticationChallenge:]):
4:41 PM Changeset in webkit [59184] by kevino@webkit.org
  • 2 edits in trunk/WebKit/wx

Reviewed by Kevin Ollivier.

Load a blank page on creation to initialize WebCore objects properly.
​https://bugs.webkit.org/show_bug.cgi?id=38932

4:39 PM Changeset in webkit [59183] by kevino@webkit.org
  • 4 edits in trunk/WebCore

Reviewed by Kevin Ollivier.

[wx] Create an NSFont on Mac builds that do not have built-in methods to do so.
​https://bugs.webkit.org/show_bug.cgi?id=38931

4:22 PM Changeset in webkit [59182] by dpranke@chromium.org
  • 3 edits in trunk/WebKitTools

2010-05-10 Dirk Pranke <​dpranke@chromium.org>

Reviewed by Eric Seidel.

new-run-webkit-tests: fix a path-handling bug that was breaking the
dryrun ports on windows, and add a comment about why we don't run
the chromium dryrun tests by default on every port.

​https://bugs.webkit.org/show_bug.cgi?id=38796

  • Scripts/webkitpy/layout_tests/port/dryrun.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
4:12 PM Changeset in webkit [59181] by mrowe@apple.com
  • 2 edits in trunk/WebKitTools

<​http://webkit.org/b/38941> build-webkit shouldn't always override ENABLE_FOO Xcode configuration settings

Reviewed by Darin Adler.

  • Scripts/build-webkit: Don't pass the ENABLE setting to xcodebuild if the value matches the default.

This will lead to xcodebuild picking up the settings from FeatureDefines.xcconfig, and will aid in
revealing problems that are due to inconsistent values for settings across projects.

4:11 PM Changeset in webkit [59180] by jianli@chromium.org
  • 1 edit
    1 delete in trunk/LayoutTests

Unreviewed. Remove unneeded rebaselined result for enter-clicks-buttons.html

  • platform/chromium-win/fast/forms/enter-clicks-buttons-expected.txt: Removed.
4:04 PM Changeset in webkit [59179] by eric@webkit.org
  • 6 edits in trunk

2010-05-11 Avi Drissman <​avi@chromium.org>

Reviewed by Darin Fisher.

[Chromium] Pipe RTL info into WebPopupMenuInfo
​https://bugs.webkit.org/show_bug.cgi?id=38749

  • platform/chromium/PopupMenuChromium.cpp: (WebCore::PopupContainer::menuStyle):
  • platform/chromium/PopupMenuChromium.h:

2010-05-11 Avi Drissman <​avi@chromium.org>

Reviewed by Darin Fisher.

[Chromium] Pipe RTL info into WebPopupMenuInfo
​https://bugs.webkit.org/show_bug.cgi?id=38749

  • public/WebPopupMenuInfo.h:
  • src/ChromeClientImpl.cpp: (WebKit::ChromeClientImpl::getPopupMenuInfo):
3:56 PM Changeset in webkit [59178] by alice.liu@apple.com
  • 4 edits in trunk

Fix build error when enabling debugging block in WebKit win painting code

Rubber-stamped by Gavin Barraclough.

JavaScriptCore:

WebKit/win:

  • WebView.cpp:

(WebView::paintIntoBackingStore):

3:43 PM Changeset in webkit [59177] by mrowe@apple.com
  • 2 edits in trunk/WebKitTools

Build fix.

  • DumpRenderTree/mac/LayoutTestControllerMac.mm:
3:39 PM Changeset in webkit [59176] by eric@webkit.org
  • 3 edits in trunk/WebKit/chromium

2010-05-11 David Holloway <​dhollowa@chromium.org>

Reviewed by Darin Fisher.

[chromium] Add size method to WebInputElement class, providing same data
as HTMLInputElement::size(). During form AutoFill Chromium needs to
access the input element's size attribute in aid of form matching and
filling heuristics.

​https://bugs.webkit.org/show_bug.cgi?id=38825

  • public/WebInputElement.h:
  • src/WebInputElement.cpp: (WebKit::WebInputElement::size):
3:28 PM Changeset in webkit [59175] by alice.liu@apple.com
  • 8 edits in trunk/WebKit/win

​https://bugs.webkit.org/show_bug.cgi?id=38937
W7 window preview paints content at the wrong location

Reviewed by Steve Falkenburg.

  • WebFrame.cpp:

(WebFrame::paintDocumentRectToContext): Revert r58895
(WebFrame::paintDocumentRectToContextAtPoint): Added

  • Interfaces/IWebFramePrivate.idl: Added paintDocumentRectToContextAtPoint
  • Interfaces/IWebViewPrivate.idl: ditto
  • Interfaces/WebKit.idl: touch to rebuild
  • WebFrame.h: ditto
  • WebView.cpp: ditto

(WebView::paintDocumentRectToContextAtPoint): ditto

  • WebView.h: ditto
3:19 PM Changeset in webkit [59174] by mrowe@apple.com
  • 8 edits in trunk

Fix the world.

In r59162 a change was made to WebCore's FeatureDefines.xcconfig that enabled FILE_READER and FILE_WRITER.
The author and reviewer of that patch ignored the carefully-worded warning at the top of that file asking
that changes to the file be kept in sync across JavaScriptCore, WebCore and WebKit, as well as being kept
in sync with build-webkit. This led to WebCore and WebKit having different views of Document's vtable
and results in crashes in Safari shortly after launch when virtual function calls resulted in the wrong
function in WebCore being called.

We fix this by bringing the FeatureDefines.xcconfig files in to sync. Based on the ChangeLog message and
other changes in r59162 it appears that enabling FILE_WRITER was unintentional so that particular change
has been reverted.

JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig:

WebCore:

  • Configurations/FeatureDefines.xcconfig:

WebKit/mac:

  • Configurations/FeatureDefines.xcconfig:

WebKit2:

  • Configurations/FeatureDefines.xcconfig:
3:01 PM Changeset in webkit [59173] by Dimitri Glazkov
  • 11 edits in trunk

2010-05-11 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Darin Adler.

REGRESSION(r58520): Implicit submission on forms with button type="submit" no longer works
​https://bugs.webkit.org/show_bug.cgi?id=38913

Updated the test to include coverage of button elements.

  • fast/forms/enter-clicks-buttons-expected.txt: Updated expectations to account for implicit

submission which now correctly happens from the right element (button).

  • fast/forms/implicit-submission-expected.txt: Updated expectations with new test results.
  • fast/forms/implicit-submission.html: Added tests and code to cover button elements.

2010-05-11 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Darin Adler.

REGRESSION(r58520): Implicit submission on forms with button type="submit" no longer works
​https://bugs.webkit.org/show_bug.cgi?id=38913

  • Widened the check for a successful submit button to include all HTMLFormControlElements.
  • Clarified implicit submission code by:
    • introducing HTMLFormControlElement::canTriggerImplicitSubmission flag,
    • getting rid of static casting and checking for tag names.
  • html/HTMLFormControlElement.h: (WebCore::HTMLFormControlElement::canTriggerImplicitSubmission): Added.
  • html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::submitImplicitly): Renamed parameters for clarity, refactored code

to use canTriggerImplicitSubmission.

  • html/HTMLFormElement.h: Renamed parameter for clarity.
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::defaultEventHandler): Used canTriggerImplicitSubmission()

instead of isTextField() for clarity.

  • html/HTMLInputElement.h: (WebCore::HTMLInputElement::canTriggerImplicitSubmission): Added.
  • html/HTMLIsIndexElement.h: (WebCore::HTMLIsIndexElement::canTriggerImplicitSubmission): Added.
2:35 PM Changeset in webkit [59172] by eric@webkit.org
  • 12 edits
    1 delete in trunk

2010-05-11 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r59171.
​http://trac.webkit.org/changeset/59171
​https://bugs.webkit.org/show_bug.cgi?id=38933

"Broke the world" (Requested by bweinstein on #webkit).

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreCommon.vsprops:
  • JavaScriptCore.vcproj/WTF/WTF.vcproj:
  • JavaScriptCore.vcproj/jsc/jsc.vcproj:
  • JavaScriptCore.vcproj/jsc/jscCommon.vsprops:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • wtf/text/AtomicString.cpp: (WebCore::AtomicString::init):
  • wtf/text/StringImpl.cpp: (WebCore::StringImpl::empty):
  • wtf/text/StringStatics.cpp: Removed.

2010-05-11 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r59171.
​http://trac.webkit.org/changeset/59171
​https://bugs.webkit.org/show_bug.cgi?id=38933

"Broke the world" (Requested by bweinstein on #webkit).

  • WebCore.vcproj/WebCore.vcproj:
1:52 PM Changeset in webkit [59171] by bweinstein@apple.com
  • 12 edits
    1 add in trunk

JavaScriptCore: Patch by Gavin Barraclough.

Reviewed by Steve Falkenburg.

REGRESSION (r57900-57919): 3% PLT Regression from moving strings into WTF.
​https://bugs.webkit.org/show_bug.cgi?id=38930
<rdar://problem/7937188>

When the String classes were moved from WebCore to WTF, it meant that on Windows, all operations
on Strings in WebCore had to cross a DLL boundary (from WebKit.dll to JavaScript.dll).

We fix this by refactoring some of the WTF string code, so the code in AtomicString, StringImpl, and
WTFString can be built by both WebCore and WTF, and we don't need to talk across a DLL to do operations
on Strings.

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def: Remove string exports, because these are now

handled in WebCore.

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Remove the post-build step that was added

here (the post build step is in JavaScriptCoreCommon.vsprops).

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreCommon.vsprops: Copy the three cpp files that need to be compiled

by WebCore into the WebKitOutputDir directory.

  • JavaScriptCore.vcproj/WTF/WTF.vcproj: Add the StringStatics file.
  • JavaScriptCore.vcproj/jsc/jsc.vcproj: Add the three WTF string cpp files to this project.
  • JavaScriptCore.vcproj/jsc/jscCommon.vsprops: Remove the need to link against WTF.lib (since jsc links against JavaScriptCore).
  • JavaScriptCore.xcodeproj/project.pbxproj: Add the StringStatics file.
  • wtf/text/AtomicString.cpp: Moved code to StringStatics.
  • wtf/text/StringImpl.cpp: Ditto.
  • wtf/text/StringStatics.cpp: Added. Move functions in WTF Strings that define static variables to here, so

the rest of the files can be compiled in WebCore.

(WebCore::StringImpl::empty): Moved from StringImpl.cpp to here.
(WebCore::AtomicString::init): Moved from AtomicString.cpp to here.

WebCore: Patch by Gavin Barraclough.

Reviewed by Steve Falkenburg.

REGRESSION (r57900-57919): 3% PLT Regression from moving strings into WTF.
​https://bugs.webkit.org/show_bug.cgi?id=38930
<rdar://problem/7937188>

Add the WTF strings into the WebCore vcproj, from their copied location in $(WebKitOutputDir).

No new tests because no change in behavior.

  • WebCore.vcproj/WebCore.vcproj:
1:38 PM Changeset in webkit [59170] by ggaren@apple.com
  • 2 edits in trunk/JavaScriptCore

Fixed test failures seen on SnowLeopard buildbot.

  • runtime/JSString.cpp:

(JSC::JSString::replaceCharacter): Don't use size_t and wtf::notFound.
Instead, use the individual types and notFound values of the string APIs
we're using, since they're not necessarily the same in 64bit.

1:32 PM Changeset in webkit [59169] by Nate Chapin
  • 2 edits in trunk/WebKit/chromium

2010-05-11 Nate Chapin <Nate Chapin>

Reviewed by Adam Barth.

Crash fix in WebPageSerializerImpl::serialize().

​https://bugs.webkit.org/show_bug.cgi?id=38543

The relevant test is a test_shell_test in src.chromium.org, because neither
DRT nor the Chromium webkit unit tests can currently cover the serializer
functionality.

  • src/WebPageSerializerImpl.cpp: (WebKit::WebPageSerializerImpl::serialize): Check each frame's url before using it,

since they are not guaranteed to be valid (e.g., if the frame was treated as a download).

1:11 PM Changeset in webkit [59168] by ojan@chromium.org
  • 2 edits
    1 add in trunk/WebKitTools

2010-05-10 Ojan Vafai <​ojan@chromium.org>

Reviewed by David Levin.

CheckStyle was eating script errors when there were local-commits and working copy changes
​https://bugs.webkit.org/show_bug.cgi?id=38880

  • Scripts/webkitpy/tool/steps/checkstyle.py:
  • Scripts/webkitpy/tool/steps/checkstyle_unittest.py: Added.
12:58 PM Changeset in webkit [59167] by crogers@google.com
  • 2 edits in branches/audio/WebCore

Create a symlink in the built WebCore.framework/Resources to point to audio spatialization files

  • which exist in WebKit/WebCore/audio/AudioSpatialization
  • This is a temporary hack so that people can build WebKit "build-webkit" in my private "audio" branch and then
  • run the "run-safari" script to test out the new audio features.
12:55 PM Changeset in webkit [59166] by jianli@chromium.org
  • 2 edits in trunk/WebCore

Unreviewed. Fix compiling erron on snow leopard.

  • html/FileThreadTask.h:

(WebCore::createFileThreadTask):

12:48 PM Changeset in webkit [59165] by tonikitoo@webkit.org
  • 3 edits in trunk/LayoutTests

[Qt] fast/frames/flattening/frameset-flattening-subframesets.html fails intermittently on Qt bot
​https://bugs.webkit.org/show_bug.cgi?id=37334

Rubber-stamped by Kenneth Christiansen.
Patch by Antonio Gomes <​tonikitoo@webkit.org>

Removing unneeded call to LayoutTestController.display(). It was originally intending
to force a layout, but a re-layout will happen regardless because document.body.offsetTop
is called afterwards

  • fast/frames/flattening/frameset-flattening-subframe-resize.html:
  • platform/qt/Skipped:
12:37 PM Changeset in webkit [59164] by jianli@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed. Skip file-reader.html that is not enabled in chromium yet.

  • platform/chromium/test_expectations.txt:
12:20 PM Changeset in webkit [59163] by tonikitoo@webkit.org
  • 2 edits in trunk/WebKit/qt

[Qt] emit initialLayoutCompleted signal from FrameLoaderClientQt::dispatchDidFirstVisuallyNonEmptyLayout
​https://bugs.webkit.org/show_bug.cgi?id=38921

Reviewed by Kenneth Christiansen.
Patch by Antonio Gomes <​tonikitoo@webkit.org>

Emit initialLayoutCompleted signal from FrameLoaderClientQt::dispatchDidFirstVisuallyNonEmptyLayout
instead of FrameLoaderClientQt::dispatchDidFirstLayout , because the former ensures that a
visual content layed out on the frame.

It matches to QWebFrame::initialLayoutCompleted signal documentation at:

"... This is the first time you will see contents displayed on the frame ..."

  • WebCoreSupport/FrameLoaderClientQt.cpp:

(WebCore::FrameLoaderClientQt::dispatchDidFirstLayout):
(WebCore::FrameLoaderClientQt::dispatchDidFirstVisuallyNonEmptyLayout):

12:04 PM Changeset in webkit [59162] by jianli@chromium.org
  • 28 edits
    1 copy
    10 adds in trunk

Expose FileReader interface.
​https://bugs.webkit.org/show_bug.cgi?id=38609

Reviewed by Dmitry Titov.

WebCore:

Test: fast/files/file-reader.html

  • Configurations/FeatureDefines.xcconfig:
  • DerivedSources.cpp:
  • DerivedSources.make:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pri:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSEventTarget.cpp:

(WebCore::toJS):

  • bindings/v8/V8DOMWrapper.cpp:

(WebCore::V8DOMWrapper::convertEventTargetToV8Object):

  • html/FileError.idl:
  • html/FileReader.idl: Added.
  • page/DOMWindow.idl:

WebKit/chromium:

  • features.gypi: turn on building FileReader for Chromium.

WebKitTools:

  • Scripts/build-webkit: turn on building FileReader for Apple's WebKit.

LayoutTests:

Add a layout test to test basic FileReader operations.
Also update layout tests affected by adding the constructors to DOMWindow.

  • fast/dom/Window/script-tests/window-property-descriptors.js:
  • fast/dom/Window/window-properties.html:
  • fast/dom/script-tests/constructed-objects-prototypes.js:
  • fast/dom/script-tests/prototype-inheritance-2.js:
  • fast/dom/script-tests/prototype-inheritance.js:
  • fast/files/file-reader-expected.txt: Added.
  • fast/files/file-reader.html: Added.
  • fast/files/resources/UTF16BE-BOM.txt: Added.
  • fast/files/resources/UTF16BE.txt: Added.
  • fast/files/resources/UTF16LE-BOM.txt: Added.
  • fast/files/resources/UTF8-BOM.txt: Added.
  • fast/files/resources/UTF8.txt: Added.
  • fast/files/resources/empty-file: Added.
  • fast/js/script-tests/global-constructors.js:
  • platform/chromium/test_expectations.txt:
  • platform/gtk/Skipped: Skip the new test because eventSender.beginDragWithFiles is not supported in gtk platform.
  • platform/qt/Skipped: Skip the new test because eventSender.beginDragWithFiles is not supported in qt platform.
  • platform/win/Skipped: Skip the new test because eventSender.beginDragWithFiles is not supported in win platform.
11:42 AM Changeset in webkit [59161] by ggaren@apple.com
  • 7 edits in trunk/JavaScriptCore

Start using ropes in String.prototype.replace.

Reviewed by Oliver Hunt and Darin Adler.

1%-1.5% speedup on SunSpider.

  • runtime/JSString.cpp:

(JSC::JSString::resolveRope): Updated for RopeImpl refactoring.

(JSC::JSString::replaceCharacter): Added a replaceCharacter function, which creates
a rope for the resulting replacement.

  • runtime/JSString.h: A few changes here:

(JSC::):
(JSC::RopeBuilder::RopeIterator::RopeIterator):
(JSC::RopeBuilder::RopeIterator::operator++):
(JSC::RopeBuilder::RopeIterator::operator*):
(JSC::RopeBuilder::RopeIterator::operator!=):
(JSC::RopeBuilder::RopeIterator::WorkItem::WorkItem):
(JSC::RopeBuilder::RopeIterator::WorkItem::operator!=):
(JSC::RopeBuilder::RopeIterator::skipRopes): Created a RopeIterator abstraction.
We use this to do a substring find without having to resolve the rope.
(We could use this iterator when resolving ropes, too, but resolving
ropes backwards is usually more efficient.)

(JSC::RopeBuilder::JSString): Added constructors for 2 & 3 UStrings.

(JSC::RopeBuilder::appendValueInConstructAndIncrementLength):
(JSC::RopeBuilder::size): Updated for RopeImpl refactoring.

  • runtime/Operations.h: Updated for RopeImpl refactoring.

(JSC::jsString): Added jsString functions for 2 & 3 UStrings.

  • runtime/RopeImpl.cpp:

(JSC::RopeImpl::derefFibersNonRecursive):

  • runtime/RopeImpl.h:

(JSC::RopeImpl::initializeFiber):
(JSC::RopeImpl::size):
(JSC::RopeImpl::fibers):
(JSC::RopeImpl::deref):
(JSC::RopeImpl::RopeImpl): A little refactoring to make this patch easier:
Moved statics to the top of the class; put multi-statement functions on
multiple lines; renamed "fiberCount" to "size" to match other collections;
changed the "fibers" accessor to return the fibers buffer, instead of an
item in the buffer, to make iteration easier.

  • runtime/StringPrototype.cpp:

(JSC::stringProtoFuncReplace): Don't resolve a rope unless we need to. Do
use our new replaceCharacter function if possible. Do use a rope to
represent splicing three strings together.

11:35 AM Changeset in webkit [59160] by jianli@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed.

[chromium] Mark flaky layout tests.

  • platform/chromium/test_expectations.txt:
10:58 AM Changeset in webkit [59159] by jam@chromium.org
  • 1 edit in trunk/WebKit/chromium/src/WebScrollbarImpl.cpp

[chromium] Fix build break on Chromium Mac

10:53 AM Changeset in webkit [59158] by Martin Robinson
  • 3 edits in trunk/WebKit/gtk

2010-05-11 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Xan Lopez.

[Gtk] Doesn't support gtk-key-themes
​https://bugs.webkit.org/show_bug.cgi?id=28257

Add support for GTK+ key themes.

  • WebCoreSupport/EditorClientGtk.cpp: (WebKit::backspaceCallback): Added. (WebKit::cutClipboardCallback): Added. (WebKit::copyClipboardCallback): Added. (WebKit::pasteClipboardCallback): Added. (WebKit::selectAllCallback): Added. (WebKit::deleteFromCursorCallback): Added. (WebKit::moveCursorCallback): Added. (WebKit::EditorClient::generateEditorCommands): Added. (WebKit::EditorClient::executePendingEditorCommands): Added. (WebKit::EditorClient::handleKeyboardEvent): Derive editor commands both from internal text widget and a list of fallbacks. (WebKit::EditorClient::EditorClient): Add m_nativeWidget initializer.
  • WebCoreSupport/EditorClientGtk.h: (WebKit::EditorClient::addPendingEditorCommand): Add m_nativeWidget member.
10:37 AM Changeset in webkit [59157] by xan@webkit.org
  • 2 edits in trunk/WebCore

2010-05-11 Xan Lopez <​xlopez@igalia.com>

Reviewed by Gustavo Noronha.

[gtk] critical warning in soup_message_set_first_party() when cancelling a navigation
​https://bugs.webkit.org/show_bug.cgi?id=38653

Check if willSendRequest cancelled the request before setting the
first party for the cookies in the message, otherwise we'll get a
critical warning.

  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::restartedCallback):
10:11 AM Changeset in webkit [59156] by jam@chromium.org
  • 1 edit in trunk/WebKit/chromium/WebKit.gyp

Check in gyp changes for r59110

9:47 AM Changeset in webkit [59155] by weinig@apple.com
  • 4 edits in trunk/WebCore

REGRESSION (r59001): 11 media tests are failing on Windows (38847)
rdar://problem/7962997
​https://bugs.webkit.org/show_bug.cgi?id=38847

Patch by Jer Noble <​jer.noble@apple.com> on 2010-05-11
Reviewed by Adele Peterson.

QTMovieWin was too much refactored; the cacheMovieScale() function should have
been left in QTMovie (instead of being moved into QTMovieGWorld). This fixes the
video-size-intrinsic-scale test.

QTMovieTask::updateTaskTimer() was ignoring the maxInterval parameter unless
QTGetTimeUntilNextTask() returned an error, which caused the next timer to be
scheduled for extremely far in the future, breaking some of the layout tests.

QTMovieTask::fireTaskClients() now makes a local copy of the task list before
calling clients, in case one of them removes themselves from the task list and
invalidates our iterating pointer.

  • platform/graphics/win/QTMovie.cpp:

(QTMoviePrivate::task):
(QTMoviePrivate::createMovieController):
(QTMoviePrivate::cacheMovieScale):

  • platform/graphics/win/QTMovieGWorld.cpp:

(QTMovieGWorldPrivate::movieLoadStateChanged):

  • platform/graphics/win/QTMovieTask.cpp:

(QTMovieTask::updateTaskTimer):
(QTMovieTask::fireTaskClients):

9:38 AM Changeset in webkit [59154] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-05-11 Patrick Gansterer <​paroga@paroga.com>

Reviewed by Adam Roben.

Port SharedBuffer to WinCE.
​https://bugs.webkit.org/show_bug.cgi?id=37222

Use only functions which are available on Win32 and WinCE.

  • platform/win/SharedBufferWin.cpp: (WebCore::SharedBuffer::createWithContentsOfFile):
9:14 AM Changeset in webkit [59153] by tkent@chromium.org
  • 1 edit
    2 adds
    6 deletes in trunk/LayoutTests

Merge some pseudo-valid-*.html tests into one.
​https://bugs.webkit.org/show_bug.cgi?id=38846

Reviewed by Shinichiro Hamaji.

No additional test cases and no removed test cases.

  • fast/css/pseudo-valid-003-expected.txt: Removed.
  • fast/css/pseudo-valid-003.html: Removed.
  • fast/css/pseudo-valid-005-expected.txt: Removed.
  • fast/css/pseudo-valid-005.html: Removed.
  • fast/css/pseudo-valid-006-expected.txt: Removed.
  • fast/css/pseudo-valid-006.html: Removed.
  • fast/css/pseudo-valid-unapplied-expected.txt: Added.
  • fast/css/pseudo-valid-unapplied.html: Added.
8:45 AM Changeset in webkit [59152] by eric@webkit.org
  • 4 edits in trunk/WebKit/qt

2010-05-11 Jesus Sanchez-Palencia <​jesus@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

Add PageClientQGraphicsWidget specific implementation.
QGraphicsWebViewPrivate doesn't inherit QWebPageClient anymore
and the needed functions were moved to this new PageClient class,
including Tiling and Accelerated Composite specific ones.

[Qt] PageClientQt specific implementation for QGraphicsWidget
​https://bugs.webkit.org/show_bug.cgi?id=37866

  • Api/qgraphicswebview.cpp: (QGraphicsWebViewPrivate::QGraphicsWebViewPrivate): (QGraphicsWebViewPrivate::~QGraphicsWebViewPrivate): (QGraphicsWebViewPrivate::syncLayers): (QGraphicsWebViewPrivate::_q_scaleChanged): (QGraphicsWebView::event): (QGraphicsWebView::setPage): (QGraphicsWebView::updateGeometry): (QGraphicsWebView::setGeometry): (QGraphicsWebView::setResizesToContents):
  • WebCoreSupport/PageClientQt.cpp: (WebCore::PageClientQGraphicsWidget::~PageClientQGraphicsWidget): (WebCore::PageClientQGraphicsWidget::scroll): (WebCore::PageClientQGraphicsWidget::update): (WebCore::PageClientQGraphicsWidget::createOrDeleteOverlay): (WebCore::PageClientQGraphicsWidget::syncLayers): (WebCore::PageClientQGraphicsWidget::setRootGraphicsLayer): (WebCore::PageClientQGraphicsWidget::markForSync): (WebCore::PageClientQGraphicsWidget::updateCompositingScrollPosition): (WebCore::PageClientQGraphicsWidget::updateTiledBackingStoreScale): (WebCore::PageClientQGraphicsWidget::setInputMethodEnabled): (WebCore::PageClientQGraphicsWidget::inputMethodEnabled): (WebCore::PageClientQGraphicsWidget::setInputMethodHint): (WebCore::PageClientQGraphicsWidget::cursor): (WebCore::PageClientQGraphicsWidget::updateCursor): (WebCore::PageClientQGraphicsWidget::palette): (WebCore::PageClientQGraphicsWidget::screenNumber): (WebCore::PageClientQGraphicsWidget::ownerWidget): (WebCore::PageClientQGraphicsWidget::geometryRelativeToOwnerWidget): (WebCore::PageClientQGraphicsWidget::pluginParent): (WebCore::PageClientQGraphicsWidget::style):
  • WebCoreSupport/PageClientQt.h: (WebCore::QGraphicsItemOverlay::page): (WebCore::QGraphicsItemOverlay::boundingRect): (WebCore::QGraphicsItemOverlay::paint): (WebCore::QGraphicsItemOverlay::prepareGraphicsItemGeometryChange): (WebCore::PageClientQGraphicsWidget::PageClientQGraphicsWidget): (WebCore::PageClientQGraphicsWidget::isQWidgetClient): (WebCore::PageClientQGraphicsWidget::allowsAcceleratedCompositing): (WebCore::PageClientQGraphicsWidget::):
8:18 AM QtWebKitTriageRoster edited by Laszlo Gombos
(diff)
8:15 AM Changeset in webkit [59151] by eric@webkit.org
  • 4 edits in trunk

2010-05-11 Benjamin Poulain <​benjamin.poulain@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] fast/text/find-hidden-text.html
​https://bugs.webkit.org/show_bug.cgi?id=32922

Remove fast/text/find-hidden-text.html from the skipped list of Qt.

  • platform/qt/Skipped:

2010-05-11 Benjamin Poulain <​benjamin.poulain@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] fast/text/find-hidden-text.html
​https://bugs.webkit.org/show_bug.cgi?id=32922

Use the real page step for populating the QStyleOption otherwhise
the size can be negative, which can break the QStyle used.

  • platform/qt/ScrollbarThemeQt.cpp: (WebCore::styleOptionSlider):
7:15 AM Changeset in webkit [59150] by pfeldman@chromium.org
  • 10 edits in trunk

2010-05-11 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: make styles rendering more user-friendly.

​https://bugs.webkit.org/show_bug.cgi?id=36747

  • inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel):
  • inspector/front-end/StylesSidebarPane.js: (WebInspector.StylesSidebarPane.prototype._update): (WebInspector.StylesSidebarPane.prototype._rebuildSectionsForStyleRules): (WebInspector.ComputedStyleSidebarPane): (WebInspector.StylePropertiesSection): (WebInspector.StylePropertiesSection.prototype.collapse): (WebInspector.StylePropertiesSection.prototype.startEditingSelector):
  • inspector/front-end/inspector.css: (#elements-content): (#elements-sidebar): (.styles-sidebar-separator): (.styles-section): (.styles-section .header): (.styles-section .header .title): (.styles-section .header .subtitle): (.styles-section .header .subtitle a): (.styles-section .properties): (.styles-section.no-affect .properties li): (.styles-section.no-affect .properties li.editing): (.styles-section.expanded .properties): (.styles-section .properties li): (.styles-section .properties li.parent): (.styles-section .properties ol): (.styles-section .properties ol.expanded): (.styles-section .properties li.parent::before): (.styles-section .properties li.parent.expanded::before): (.styles-section .properties li .info): (.styles-section:hover .properties .enabled-button): (.styles-section .properties li.disabled .enabled-button): (.styles-section .properties .enabled-button): (.styles-section .properties .overloaded, .styles-section .properties .disabled): (.styles-section.computed-style .properties .disabled): (.styles-section .properties .implicit, .styles-section .properties .inherited): (.styles-section .properties .inherited): (.styles-section.show-inherited .properties .inherited):
6:09 AM Changeset in webkit [59149] by johnnyg@google.com
  • 3 edits
    7 adds in trunk/LayoutTests

2010-05-11 John Gregg <​johnnyg@google.com>

[chromium] Unreviewed, test expectations.

  • platform/chromium-mac/svg/filters/filteredImage-expected.checksum: Added.
  • platform/chromium-win-xp/svg/batik/text/textFeatures-expected.txt:
  • platform/chromium-win/svg/filters/filteredImage-expected.checksum: Added.
  • platform/chromium-win/svg/filters/filteredImage-expected.png: Added.
  • platform/chromium-win/svg/text/text-hkern-on-vertical-text-expected.checksum: Added.
  • platform/chromium-win/svg/text/text-hkern-on-vertical-text-expected.png: Added.
  • platform/chromium-win/svg/text/text-vkern-on-horizontal-text-expected.checksum: Added.
  • platform/chromium-win/svg/text/text-vkern-on-horizontal-text-expected.png: Added.
5:11 AM Changeset in webkit [59148] by Nikolas Zimmermann
  • 13 edits
    10 adds in trunk

2010-05-11 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Dirk Schulze.

Move buildLayoutInformationForTextBox() from SVGRootInlineBox in SVGInlineTextBox where it belongs
​https://bugs.webkit.org/show_bug.cgi?id=38799

Cleanup SVGRootInlineBox/SVGInlineTextBox. Move buildLayoutInformationForTextBox to SVGInlineTextBox.
Move lots of helper methods into new SVGTextLayoutUtilities class. Adapted all callsites.

Fixed bug in kerning handling, hkern was applyable to vertical text as well. Covered by two new tests.

Tests: svg/text/text-hkern-on-vertical-text.svg

svg/text/text-vkern-on-horizontal-text.svg

  • Android.mk: Add SVGTextLayoutUtilities.cpp/h to build.
  • GNUmakefile.am: Ditto.
  • WebCore.gypi: Ditto.
  • WebCore.pro: Ditto.
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • rendering/SVGInlineTextBox.cpp: (WebCore::SVGInlineTextBox::calculateGlyphWidth): Use textRenderer()->characters() instead of textRenderer()->text()->characters() as shortcut. (WebCore::SVGInlineTextBox::svgCharacterHitsPosition): Fix style issue, no else if after a return branch. (WebCore::SVGInlineTextBox::paintSelection): Use !color.alpha() instead of color.alpha() == 0. (WebCore::SVGInlineTextBox::buildLayoutInformation): Moved from SVGRootInlineBox::buildLayoutInformationForTextBox.
  • rendering/SVGInlineTextBox.h: Fix indention. (WebCore::SVGInlineTextBox::selectionTop): Inlined. (WebCore::SVGInlineTextBox::selectionHeight): Inlined.
  • rendering/SVGRenderTreeAsText.cpp: Include SVGTextLayoutUtilities.h
  • rendering/SVGRootInlineBox.cpp: Move almost all static text layout helper functions in SVGTextLayoutUtilities (WebCore::calculateTextLengthCorrectionForTextChunk): Fixed style issue in long if conditions spanning multiple lines. (WebCore::SVGRootInlineBox::computePerCharacterLayoutInformation): Use different topLeftPositionOfCharacterRange() taking start/end iterators. (WebCore::SVGRootInlineBox::buildLayoutInformation): Use the moved SVGInlineTextBox::buildLayoutInformation() method. (WebCore::SVGRootInlineBox::buildTextChunks): Fixed small style issue, remove unneeded parenthesis. (WebCore::SVGRootInlineBox::layoutTextChunks): Fix style issue in debugging code.
  • rendering/SVGRootInlineBox.h: Rename 'LastGlyphInfo' to 'SVGLastGlyphInfo' and move to SVGTextLayoutUtilities. (WebCore::SVGRootInlineBox::svgTextChunks): Inlined for speed.
  • rendering/SVGTextLayoutUtilities.cpp: Added. (WebCore::isVerticalWritingMode): (WebCore::dominantBaselineToShift): (WebCore::alignmentBaselineToShift): (WebCore::glyphOrientationToAngle): (WebCore::glyphOrientationIsMultiplyOf180Degrees): (WebCore::applyGlyphAdvanceAndShiftRespectingOrientation): (WebCore::topLeftPositionOfCharacterRange): (WebCore::cummulatedWidthOfInlineBoxCharacterRange): (WebCore::cummulatedHeightOfInlineBoxCharacterRange): (WebCore::svgTextRunForInlineTextBox): (WebCore::calculateCSSKerning): (WebCore::applySVGKerning):
  • rendering/SVGTextLayoutUtilities.h: Added. (WebCore::): (WebCore::SVGTextPaintInfo::SVGTextPaintInfo): (WebCore::SVGLastGlyphInfo::SVGLastGlyphInfo):

2010-05-11 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Dirk Schulze.

Move buildLayoutInformationForTextBox() from SVGRootInlineBox in SVGInlineTextBox where it belongs
​https://bugs.webkit.org/show_bug.cgi?id=38799

  • platform/mac/svg/text/text-hkern-on-vertical-text-expected.checksum: Added.
  • platform/mac/svg/text/text-hkern-on-vertical-text-expected.png: Added.
  • platform/mac/svg/text/text-hkern-on-vertical-text-expected.txt: Added.
  • platform/mac/svg/text/text-vkern-on-horizontal-text-expected.checksum: Added.
  • platform/mac/svg/text/text-vkern-on-horizontal-text-expected.png: Added.
  • platform/mac/svg/text/text-vkern-on-horizontal-text-expected.txt: Added.
  • svg/text/text-hkern-on-vertical-text.svg: Added.
  • svg/text/text-vkern-on-horizontal-text.svg: Added.
2:22 AM Changeset in webkit [59147] by zherczeg@webkit.org
  • 4 edits
    5 adds in trunk

WebCore: RenderSVGImage::imageChanged should invalidate the SVG filter cache
​https://bugs.webkit.org/show_bug.cgi?id=38838

Reviewed by Dirk Schulze.

Test: svg/filters/filteredImage.svg

  • rendering/RenderSVGImage.cpp:

(WebCore::RenderSVGImage::imageChanged):

LayoutTests: Test case for SVG filter cache invalidation, after an image resource arrives.
​https://bugs.webkit.org/show_bug.cgi?id=38838

Reviewed by Dirk Schulze.

  • platform/gtk/Skipped:
  • platform/mac/svg/filters/filteredImage-expected.checksum: Added.
  • platform/mac/svg/filters/filteredImage-expected.png: Added.
  • platform/mac/svg/filters/filteredImage-expected.txt: Added.
  • platform/qt/svg/filters/filteredImage-expected.txt: Added.
  • svg/filters/filteredImage.svg: Added.
1:08 AM Changeset in webkit [59146] by Simon Fraser
  • 1 edit
    6 adds in trunk/LayoutTests

2010-05-11 Simon Fraser <Simon Fraser>

Test result fixes for Leopard.

Leopard needs custom results for tests that dump the layer tree, because Leopard
CA does not have geometry flipping, so we do that ourselves by setting a transform.

  • platform/mac-leopard/compositing/iframes/composited-parent-iframe-expected.txt: Added.
  • platform/mac-leopard/compositing/iframes/connect-compositing-iframe-expected.txt: Added.
  • platform/mac-leopard/compositing/iframes/connect-compositing-iframe2-expected.txt: Added.
  • platform/mac-leopard/compositing/iframes/connect-compositing-iframe3-expected.txt: Added.
  • platform/mac-leopard/compositing/iframes/enter-compositing-iframe-expected.txt: Added.
12:24 AM Changeset in webkit [59145] by tony@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-05-10 Tony Chang <​tony@chromium.org>

Reviewed by Kent Tamura.

[chromium] don't build DRT in chromium checkouts due to a circular gyp dependency
​https://bugs.webkit.org/show_bug.cgi?id=38889

  • WebKit.gyp:
12:18 AM Changeset in webkit [59144] by johnnyg@google.com
  • 3 edits in trunk/LayoutTests

2010-05-11 John Gregg <​johnnyg@google.com>

[chromium] Update win-vista version of the baseline recently updated for win-xp.

  • platform/chromium-win-vista/svg/batik/text/textFeatures-expected.txt:
Note: See TracTimeline for information about the timeline view.