Timeline



Sep 27, 2010:

11:39 PM Changeset in webkit [68493] by dbates@webkit.org
  • 11 edits in trunk/WebKitTools

2010-09-27 Daniel Bates <dbates@rim.com>

Reviewed by Adam Barth.

sheriffbot can't roll out security patches
https://bugs.webkit.org/show_bug.cgi?id=39136

Make SheriffBot determine if it's authorized to view a bug
whose change it wants to rollout before it tries to rollout
the change.

Moreover, make both webkit-patch and Sheriffbot provide human-
readable error messages when they are not authorized to view
a bug and when a bug number is invalid.

Currently, Sheriffbot does not parse Bugzilla bugs for
<bug error="...">, which indicates an error when retrieving
a bug. In particular, error="NotPermitted" if a person (or bot)
is not authorized to view a bug. For such error="NotPermitted" bugs,
Sheriffbot raises an exception when parsing the bug report and
this exception does not explicitly indicate Sheriffbot's lack
of authorization. Instead, Sheriffbot should explicitly check
for the presence <bug error="..."> before operating on a bug
and error with a human-readable message if it's not permitted
to view it.

  • Scripts/webkitpy/common/net/bugzilla.py: Added BugzillaError class.
  • Scripts/webkitpy/common/net/bugzilla_unittest.py:
    • Added unit test test_bug_parsing_for_bugzilla_not_permitted_error().
    • Added unit test test_bug_parsing_for_bugzilla_not_found_error().
    • Added unit test test_bug_parsing_for_bugzilla_invalid_bug_id_error().
  • Scripts/webkitpy/tool/bot/sheriff.py: Modified to catch BugzillaError.
  • Scripts/webkitpy/tool/commands/download.py: Ditto.
  • Scripts/webkitpy/tool/commands/queues.py: Ditto.
  • Scripts/webkitpy/tool/commands/upload.py: Ditto.
  • Scripts/webkitpy/tool/steps/closebug.py: Ditto.
  • Scripts/webkitpy/tool/steps/obsoletepatches.py: Ditto.
  • Scripts/webkitpy/tool/steps/preparechangelog.py: Ditto.
  • Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py: Ditto.
11:22 PM Changeset in webkit [68492] by abarth@webkit.org
  • 4 edits
    1 add in trunk/WebKitTools

2010-09-27 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Expose more more failure information from Buildbot to SheriffBot
https://bugs.webkit.org/show_bug.cgi?id=46697

This patch moves the information about what tests failured closer to
SheriffBot. There are still a couple more patches to go before
SheriffBot can post this information to bugs, but this is a step in
that direction. Yay for unit tests, which caught some bugs in earlier
versions of this patch.

  • Scripts/webkitpy/common/net/buildbot.py:
  • Scripts/webkitpy/common/net/buildbot_unittest.py:
  • Scripts/webkitpy/common/net/regressionwindow.py: Added.
  • Scripts/webkitpy/tool/commands/queries.py:
11:04 PM Changeset in webkit [68491] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-09-27 Eric Seidel <eric@webkit.org>

Unreviewed. Fixing 500 error seen in the status server.

It turns out that a = b = []; b.append(1); then a[0] will be 1!
This should have been obvious to me, I guess, but it was not what I was expecting.

  • QueueStatusServer/model/activeworkitems.py:
11:04 PM Changeset in webkit [68490] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

Unreviewed fix after r68460.

  • platform/qt/Skipped: Add http/tests/canvas/webgl/origin-clean-conformance.html, because 3D canvas is disabled by default.
10:42 PM Changeset in webkit [68489] by Csaba Osztrogonác
  • 1 edit
    1 copy in trunk/LayoutTests

Unreviewed fix after r68444. Add Qt specific expected files.

  • platform/qt/fast/repaint/repaint-svg-after-style-change-expected.txt: Copied from LayoutTests/fast/repaint/repaint-svg-after-style-change-expected.txt.
10:36 PM Changeset in webkit [68488] by Csaba Osztrogonác
  • 5 edits in trunk/LayoutTests

Unreviewed fix after r68440. Update Qt specific expected files.

  • platform/qt/fast/dom/Window/window-properties-expected.txt:
  • platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/qt/fast/dom/prototype-inheritance-expected.txt:
  • platform/qt/fast/js/global-constructors-expected.txt:
10:29 PM Changeset in webkit [68487] by morrita@google.com
  • 3 edits in trunk/LayoutTests

2010-09-27 MORITA Hajime <morrita@google.com>

Unreviewed, added an expectation.

  • platform/chromium/fast/dom/prototype-inheritance-expected.txt:
  • platform/chromium/test_expectations.txt:
10:18 PM Changeset in webkit [68486] by mihaip@chromium.org
  • 9 edits in branches/chromium/517

Merge 68345 - document.nodesFromRect() needs to be removed from Document.idl
https://bugs.webkit.org/show_bug.cgi?id=46492

Reviewed by Kenneth Christiansen and Andreas Kling.
Patch by Antonio Gomes <agomes@rim.com>

WebCore:

As discussed with Sam Weinig on IRC, it was decided to removed
nodesFromRect() from the Document.idl, and that way, not exposing
it to Web content.

Reason: there is no plan to make it standard at the moment, and at the
very least, the method should had been originally added with the "webkit"
prefix, which was not the case.

  • dom/Document.idl:

LayoutTests:

Skip the tests relying on document.nodesFromRect in all platform for
the moment, and adjusting the expected results tests also accordingly.

  • fast/dom/Window/window-properties-expected.txt:
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/qt/fast/dom/Window/window-properties-expected.txt:
  • platform/win/Skipped:

TBR=jamesr@chromium.org
BUG=57110
Review URL: http://codereview.chromium.org/3509008

10:01 PM Changeset in webkit [68485] by inferno@chromium.org
  • 3 edits
    2 adds in trunk

2010-09-27 Abhishek Arya <inferno@chromium.org>

Reviewed by Dan Bernstein.

When the block RunIn is destroyed, its line box tree is not deleted. As a result, it
gets later used during dirtying of inline text boxes step where this deleted parent is
accessed. The fix is to delete the line box tree before destroying the runin block.

https://bugs.webkit.org/show_bug.cgi?id=46376

Test: fast/text/dirty-inline-textbox-crash.html

  • rendering/RenderText.cpp: (WebCore::RenderText::dirtyLineBoxes):

2010-09-27 Abhishek Arya <inferno@chromium.org>

Reviewed by Dan Bernstein.

Tests we do not crash on ASSERT(!m_hasBadParent) when dirtying
the inline textboxes.
https://bugs.webkit.org/show_bug.cgi?id=46376

  • fast/text/dirty-inline-textbox-crash-expected.txt: Added.
  • fast/text/dirty-inline-textbox-crash.html: Added.
9:45 PM Changeset in webkit [68484] by abarth@webkit.org
  • 3 edits in trunk/WebKitTools

2010-09-27 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

commit-queue should reject patches that fail to land
https://bugs.webkit.org/show_bug.cgi?id=46694

This can happen, for example, if there's no reviewer. Without this
patch, we'll keep retrying the patch.

  • Scripts/webkitpy/tool/bot/commitqueuetask.py:
  • Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
9:28 PM Changeset in webkit [68483] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-09-27 Eric Uhrhane <ericu@chromium.org>

Reviewed by David Levin.

Fix event sequencing in FileWriter
https://bugs.webkit.org/show_bug.cgi?id=46544

Only set readyState to DONE when we're about to send the last progress
event associated with an operation. Make sure all progress events come
from backend calls, and aren't ever fired synchronously in response to
user JS method calls.

No new tests, as none of this is fully implemented yet.

  • fileapi/FileWriter.cpp: (WebCore::FileWriter::write): (WebCore::FileWriter::truncate): (WebCore::FileWriter::abort): (WebCore::FileWriter::didWrite): (WebCore::FileWriter::didTruncate): (WebCore::FileWriter::didFail):
8:49 PM Changeset in webkit [68482] by morrita@google.com
  • 1 edit
    1 add in trunk/LayoutTests

2010-09-27 MORITA Hajime <morrita@google.com>

Unreviewed, added an expectation.

  • platform/chromium-mac/fast/forms/input-button-sizes-expected.checksum: Added.
8:27 PM Changeset in webkit [68481] by crogers@google.com
  • 1 edit
    2 adds in trunk/WebCore

2010-09-27 Chris Rogers <crogers@google.com>

Reviewed by James Robinson.

Add HRTFDatabase files
https://bugs.webkit.org/show_bug.cgi?id=46233

No new tests since audio API is not yet implemented.

  • platform/audio/HRTFDatabase.cpp: Added. (WebCore::HRTFDatabase::create): (WebCore::HRTFDatabase::HRTFDatabase): (WebCore::HRTFDatabase::getKernelsFromAzimuthElevation): (WebCore::HRTFDatabase::indexFromElevationAngle):
  • platform/audio/HRTFDatabase.h: Added. (WebCore::HRTFDatabase::numberOfAzimuths): (WebCore::HRTFDatabase::sampleRate):
8:22 PM Changeset in webkit [68480] by morrita@google.com
  • 2 edits in trunk/LayoutTests

2010-09-27 MORITA Hajime <morrita@google.com>

Unreviewed, added an expectation.

  • platform/chromium/test_expectations.txt:
8:11 PM WebKit Team edited by webkit@mattlilek.com
(diff)
8:03 PM Changeset in webkit [68479] by Simon Fraser
  • 1 edit
    5 adds in trunk/WebKitTools

2010-09-27 Simon Fraser <Simon Fraser>

Rubber-stamped by Adele Peterson.

Add a harness for running the CSS 2.1 test suite.

This harness assumes that you've got a local a copy of the suite
adjacent to the 'harness' directory.

The harness lets you go through the tests in chapter order,
denoting pass/fail/skipped for each test.

It uses a client-side database to store the results of testing.

  • CSSTestSuiteHarness/harness/harness.css: Added.
  • CSSTestSuiteHarness/harness/harness.html: Added.
  • CSSTestSuiteHarness/harness/harness.js: Added.
7:53 PM Changeset in webkit [68478] by hclam@chromium.org
  • 2 edits in trunk/WebKit/chromium

Build fix. Not reviewed.

Use if instead of switch to avoid compilation error.

  • src/VideoFrameChromiumImpl.cpp:

(WebKit::VideoFrameChromiumImpl::requiredTextureSize):

7:37 PM Changeset in webkit [68477] by hclam@chromium.org
  • 4 edits in trunk

Build fix. Not reviewed.

WebCore:

Move constant definitions to VideoLayerChromium.cpp.
A proper fix should come later.

  • platform/graphics/chromium/VideoLayerChromium.cpp:

WebKit/chromium:

Remove constant definitions from this file.

  • src/VideoFrameChromiumImpl.cpp:
7:37 PM Changeset in webkit [68476] by morrita@google.com
  • 2 edits in trunk/LayoutTests

2010-09-27 MORITA Hajime <morrita@google.com>

Unreviewed, added an expectation.

  • platform/chromium/test_expectations.txt:
7:28 PM Changeset in webkit [68475] by tonikitoo@webkit.org
  • 22 edits in trunk

Make Document::nodesFromRect more flexible
https://bugs.webkit.org/show_bug.cgi?id=46336

Patch by Antonio Gomes <agomes@rim.com> on 2010-09-23
Reviewed by Kenneth Christiansen.

The patch changes the API for the Document::nodesFromRect() method as follows:

from

  • RefPtf<NodeList> nodesFromRect(int x, int y, unsigned horizontalPadding, unsigned verticalPadding, bool ignoreClipping)

to

  • RefPtf<NodeList> nodesFromRect(int x, int y, unsigned topPadding, unsigned rightPadding, unsigned bottomPadding,

unsigned leftPadding, bool ignoreClipping)

Previously the method was receiving as parameter horizontal and vertical padding values.
In practice, the horizontal padding was being used to expand a given center point in both
right and left directions, while vertical padding was expanding it to the top and bottom directions.

Although this design makes it possible to improve the touch experience on mobile devices
(Document::nodesFromRect exposes the rect based hit testing system), empirical experiments
showed that, specially in capacitive touch screens, users tend to tap below elements. So
for even more accurate results (which means here the possibility of pleasant tapping experience),
it makes sense to use a region that is offset more above the touch point, favoring elements
above the touch point.

The patch basically implements that, increasing the API flexible and power by making it possible
to specify different padding values for each direction in a given orientation.

Changes were made accordingly to the HitTestResult, RenderLayer, RenderImage and RenderLineBoxList
classes.

WebCore:

  • WebCore.exp.in:
  • dom/Document.cpp:

(WebCore::Document::nodesFromRect):

  • dom/Document.h:
  • page/EventHandler.cpp:

(WebCore::EventHandler::hitTestResultAtPoint): For simplicity, I did not change the signature

but the way the padding value passed in as parameter is being used to construct a HitTestResult.

  • rendering/HitTestResult.cpp: Changed the rect-based bits from using IntSize (padding) to separated paddings

for each direction.

(WebCore::HitTestResult::HitTestResult): Ditto.
(WebCore::HitTestResult::operator=): Ditto.
(WebCore::HitTestResult::rectFromPoint): Ditton.

  • rendering/HitTestResult.h:

(WebCore::HitTestResult::topPadding): getter for the top padding.
(WebCore::HitTestResult::rightPadding): getter for the right padding.
(WebCore::HitTestResult::bottomPadding): getter for the bottom padding.
(WebCore::HitTestResult::leftPadding): getter for the left padding.
(WebCore::HitTestResult::rectFromPoint): Added a static method that given a center point and padding values for

each direction, returns the rect that is going to be used in WebCore's hit testing processing.

  • rendering/RenderImage.cpp: Changed the rect-based bits from using IntSize (padding) to separated paddings for each direction.

(WebCore::RenderImage::nodeAtPoint): Ditto.

  • rendering/RenderLayer.cpp: Ditto.

(WebCore::RenderLayer::hitTestLayer): Ditto.
(WebCore::RenderLayer::hitTestList): Ditto.

  • rendering/RenderLineBoxList.cpp: Ditto.

(WebCore::RenderLineBoxList::hitTest): Ditto.

LayoutTests:

  • fast/dom/nodesFromRect-basic-expected.txt:
  • fast/dom/nodesFromRect-basic.html:
  • fast/dom/resources/nodesFromRect.js:

(check):

7:21 PM Changeset in webkit [68474] by eric@webkit.org
  • 4 edits in trunk/WebKitTools

2010-09-27 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Patch locks should expire if a patch is marked for retry
https://bugs.webkit.org/show_bug.cgi?id=46682

This was part Adam's original CommitQueueTask design,
but support for it was missing from the server.
I added the support, but triggering lock-release based on this
special "retry" status feels a bit strange so I added a FIXME.

I also changed the text in queuestatus.html to say "Lock Acquired"
since "Last Activity" isn't really true. We only update the lock
date when the patch is started, not on every status update.

I also noticed an exception in next-patch, which I fixed by re-writing
the unzip logic in activeworkitems.py again.

  • QueueStatusServer/handlers/updatestatus.py:
  • QueueStatusServer/model/activeworkitems.py:
  • QueueStatusServer/templates/queuestatus.html:
7:20 PM Changeset in webkit [68473] by morrita@google.com
  • 1 edit
    6 adds in trunk/LayoutTests

2010-09-27 MORITA Hajime <morrita@google.com>

Unreviewed, added missing expectations.

[Chromium] fast/forms/input-button-sizes.html failing since r68459
https://bugs.webkit.org/show_bug.cgi?id=46686

  • platform/chromium-linux/fast/forms/input-button-sizes-expected.checksum: Added.
  • platform/chromium-linux/fast/forms/input-button-sizes-expected.png: Added.
  • platform/chromium-linux/fast/forms/input-button-sizes-expected.txt: Added.
  • platform/chromium-win/fast/forms/input-button-sizes-expected.checksum: Added.
  • platform/chromium-win/fast/forms/input-button-sizes-expected.png: Added.
  • platform/chromium-win/fast/forms/input-button-sizes-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
7:17 PM Changeset in webkit [68472] by hclam@chromium.org
  • 2 edits in trunk/WebKit/chromium

Build fix. Not reviewed.

Fix warnings again.

  • src/VideoFrameChromiumImpl.cpp:

(WebKit::VideoFrameChromiumImpl::requiredTextureSize):

7:15 PM Changeset in webkit [68471] by beidson@apple.com
  • 3 edits in trunk/WebKit2

https://bugs.webkit.org/show_bug.cgi?id=46688 - Add an API to get the WKBackForwardItem at an arbitrary index.

Reviewed by Sam Weinig.

  • UIProcess/API/C/WKBackForwardList.cpp:

(WKBackForwardListGetItemAtIndex):

  • UIProcess/API/C/WKBackForwardList.h:
7:08 PM Changeset in webkit [68470] by crogers@google.com
  • 1 edit
    2 adds in trunk/WebCore

2010-09-27 Chris Rogers <crogers@google.com>

Reviewed by James Robinson.

Add HRTFDatabaseLoader files
https://bugs.webkit.org/show_bug.cgi?id=46234

No new tests since audio API is not yet implemented.

  • platform/audio/HRTFDatabaseLoader.cpp: Added. (WebCore::HRTFDatabaseLoader::createAndLoadAsynchronouslyIfNecessary): (WebCore::HRTFDatabaseLoader::HRTFDatabaseLoader): (WebCore::HRTFDatabaseLoader::~HRTFDatabaseLoader): (WebCore::databaseLoaderEntry): (WebCore::HRTFDatabaseLoader::load): (WebCore::HRTFDatabaseLoader::loadAsynchronously): (WebCore::HRTFDatabaseLoader::isLoaded): (WebCore::HRTFDatabaseLoader::defaultHRTFDatabase):
  • platform/audio/HRTFDatabaseLoader.h: Added. (WebCore::HRTFDatabaseLoader::database): (WebCore::HRTFDatabaseLoader::databaseSampleRate):
6:52 PM Changeset in webkit [68469] by msaboff@apple.com
  • 2 edits in trunk/JavaScriptCore

2010-09-27 Michael Saboff <msaboff@apple.com>

Reviewed by Geoffrey Garen.

Changed the initialization of JSArray objects to have space for
3 elements for the constructor that takes a ArgList argument.
This improves v8-deltablue performance by about 2.8% by reducing
the number of realloc() calls.
https://bugs.webkit.org/show_bug.cgi?id=46664

  • runtime/JSArray.cpp: (JSC::JSArray::JSArray):
6:50 PM Changeset in webkit [68468] by hclam@chromium.org
  • 2 edits in trunk/WebKit/chromium

Build fix. Not reviewed.

Add a default for unhandled cases for switch statement.

  • src/VideoFrameChromiumImpl.cpp:

(WebKit::VideoFrameChromiumImpl::requiredTextureSize):

6:44 PM Changeset in webkit [68467] by morrita@google.com
  • 2 edits in trunk/LayoutTests

2010-09-27 MORITA Hajime <morrita@google.com>

Unreviewed, add an expectation.

  • platform/chromium/test_expectations.txt:
6:40 PM Changeset in webkit [68466] by tony@chromium.org
  • 2 edits in trunk/WebKitTools

2010-09-27 Tony Chang <tony@chromium.org>

Reviewed by David Levin.

[chromium] fix a warning when compiling DRT on 32-bit linux
https://bugs.webkit.org/show_bug.cgi?id=46641

  • DumpRenderTree/chromium/TestEventPrinter.cpp: (DRTPrinter::handleImage):
6:22 PM Changeset in webkit [68465] by rniwa@webkit.org
  • 4 edits
    3 adds in trunk

2010-09-27 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Darin Adler.

queryCommandState with justifyCenter, justifyLeft, and justifyRight always return false
https://bugs.webkit.org/show_bug.cgi?id=45910

Implemented queryCommandState for justifyCenter, justifyLeft, and justifyRight commands.
Added getTextAlignment to convert -webkit-center, -webkit-left, and -webkit-right to
center, left, and right respectively because they can be treated equally for editing purposes.

Test: editing/execCommand/query-text-alignment.html

  • editing/ApplyStyleCommand.cpp: (WebCore::getTextAlignment): Added. (WebCore::getPropertiesNotIn): Uses getTextAlignment.
  • editing/EditorCommand.cpp: (WebCore::stateJustifyCenter): Added. (WebCore::stateJustifyLeft): Added. (WebCore::stateJustifyRight): Added. (WebCore::createCommandMap): Refers to stateJustifyCenter, stateJustifyLeft, and stateJustifyRight.

2010-09-27 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Darin Adler.

queryCommandState with justifyCenter, justifyLeft, and justifyRight always return false
https://bugs.webkit.org/show_bug.cgi?id=45910

Added tests for queryCommandState with justifyCenter, justifyLeft, and justifyRight commands.

  • editing/execCommand/query-text-alignment-expected.txt: Added.
  • editing/execCommand/query-text-alignment.html: Added.
  • editing/execCommand/script-tests/query-text-alignment.js: Added. (queryTextAlignment): (selectFirstPosition): (selectMiddleOfHelloWorld): (runRangeTests):
6:18 PM Changeset in webkit [68464] by hclam@chromium.org
  • 3 edits in trunk/WebCore

Unreviewed. Build fix.

Reorder member declarations and fix other warnings.

  • platform/graphics/chromium/VideoLayerChromium.cpp:

(WebCore::VideoLayerChromium::VideoLayerChromium):
(WebCore::VideoLayerChromium::~VideoLayerChromium):
(WebCore::VideoLayerChromium::updateContents):
(WebCore::VideoLayerChromium::determineTextureFormat):
(WebCore::VideoLayerChromium::allocateTexturesIfNeeded):

  • platform/graphics/chromium/VideoLayerChromium.h:
6:18 PM Changeset in webkit [68463] by jamesr@google.com
  • 2 edits
    1 copy
    1 add in trunk/LayoutTests

2010-09-27 James Robinson <jamesr@chromium.org>

Update baselines for fast/repaint/repaint-svg-after-style-change.html

  • fast/repaint/repaint-svg-after-style-change-expected.txt:
  • platform/chromium/fast/repaint/repaint-svg-after-style-change-expected.txt: Added.
6:00 PM Changeset in webkit [68462] by kbr@google.com
  • 2 edits in trunk/WebCore

2010-09-27 Kenneth Russell <kbr@google.com>

Unreviewed, Qt build fix. Stub out CanvasRenderingContext::checkOrigin(const HTMLVideoElement*)
on platforms that don't support video after r68460.

  • html/canvas/CanvasRenderingContext.cpp: (WebCore::CanvasRenderingContext::checkOrigin):
5:43 PM Changeset in webkit [68461] by Chris Fleizach
  • 4 edits
    2 adds in trunk

CrashTracer: 1,803 crashes in Safari at com.apple.WebCore: -[AccessibilityObjectWrapper accessibilityIsIgnored] + 56
https://bugs.webkit.org/show_bug.cgi?id=46662

Reviewed by Beth Dakin.

WebCore:

Before calling updateBackingStore(), the wrapper object needs to be retained, lest it be invalidated during
the updateBackingStore call. This consolidates all calls to updateBackingStore().

Test: platform/mac/accessibility/removing-textarea-after-edit-crash.html

  • accessibility/mac/AXObjectCacheMac.mm:

(WebCore::AXObjectCache::postPlatformNotification):

Use an ASSERT here to catch the crash because DRT won't cause AppKit to post notifications.

  • accessibility/mac/AccessibilityObjectWrapper.mm:

(-[AccessibilityObjectWrapper prepareAccessibilityMethod]):
(-[AccessibilityObjectWrapper accessibilityActionNames]):
(-[AccessibilityObjectWrapper accessibilityAttributeNames]):
(-[AccessibilityObjectWrapper accessibilityAttributeValue:]):
(-[AccessibilityObjectWrapper accessibilityFocusedUIElement]):
(-[AccessibilityObjectWrapper accessibilityHitTest:]):
(-[AccessibilityObjectWrapper accessibilityIsAttributeSettable:]):
(-[AccessibilityObjectWrapper accessibilityIsIgnored]):
(-[AccessibilityObjectWrapper accessibilityParameterizedAttributeNames]):
(-[AccessibilityObjectWrapper accessibilityPerformPressAction]):
(-[AccessibilityObjectWrapper accessibilityPerformIncrementAction]):
(-[AccessibilityObjectWrapper accessibilityPerformDecrementAction]):
(-[AccessibilityObjectWrapper accessibilityPerformAction:]):
(-[AccessibilityObjectWrapper accessibilitySetValue:forAttribute:]):
(-[AccessibilityObjectWrapper accessibilityAttributeValue:forParameter:]):
(-[AccessibilityObjectWrapper accessibilityIndexOfChild:]):
(-[AccessibilityObjectWrapper accessibilityArrayAttributeCount:]):
(-[AccessibilityObjectWrapper accessibilityArrayAttributeValues:index:maxCount:]):

LayoutTests:

  • platform/mac/accessibility/removing-textarea-after-edit-crash-expected.txt: Added.
  • platform/mac/accessibility/removing-textarea-after-edit-crash.html: Added.
5:41 PM Changeset in webkit [68460] by kbr@google.com
  • 9 edits
    3 adds in trunk

2010-09-27 Adrienne Walker <enne@google.com>

Reviewed by Adam Barth.

WebGL's readPixels doesn't respect origin-clean flag

Push CanvasRenderingContext2D checkOrigin logic into base class so it can be shared between different kinds of canvas contexts.
https://bugs.webkit.org/show_bug.cgi?id=45718

Test: LayoutTests/http/tests/canvas/webgl/origin-clean-conformance.html

  • html/canvas/CanvasRenderingContext.cpp: (WebCore::CanvasRenderingContext::checkOrigin):
  • html/canvas/CanvasRenderingContext.h: (WebCore::CanvasRenderingContext::~CanvasRenderingContext): (WebCore::CanvasRenderingContext::canvas): (WebCore::CanvasRenderingContext::is2d): (WebCore::CanvasRenderingContext::is3d): (WebCore::CanvasRenderingContext::isAccelerated): (WebCore::CanvasRenderingContext::paintRenderingResultsToCanvas): (WebCore::CanvasRenderingContext::paintsIntoCanvasBuffer): (WebCore::CanvasRenderingContext::platformLayer):
  • html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::setStrokeStyle): (WebCore::CanvasRenderingContext2D::setFillStyle): (WebCore::CanvasRenderingContext2D::drawImage): (WebCore::CanvasRenderingContext2D::drawImageFromRect):
  • html/canvas/CanvasRenderingContext2D.h:
  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::readPixels): (WebCore::WebGLRenderingContext::texImage2D): (WebCore::WebGLRenderingContext::videoFrameToImage): (WebCore::WebGLRenderingContext::texSubImage2D):
  • html/canvas/WebGLRenderingContext.h:
  • html/canvas/WebGLRenderingContext.idl:

2010-09-27 Adrienne Walker <enne@google.com>

Reviewed by Adam Barth.

WebGL's readPixels doesn't respect origin-clean flag

Add new test by converting Khronos conformance test to be able to run within LayoutTests/http.
https://bugs.webkit.org/show_bug.cgi?id=45718

  • http/tests/canvas/webgl/origin-clean-conformance-expected.txt: Added.
  • http/tests/canvas/webgl/origin-clean-conformance.html: Added.
5:40 PM Changeset in webkit [68459] by Darin Adler
  • 3 edits
    1 copy
    7 adds in trunk

2010-09-27 Darin Adler <Darin Adler>

Reviewed by Dan Bernstein.

REGRESSION (r68054): Buttons no longer render at correct sizes
https://bugs.webkit.org/show_bug.cgi?id=46513

Test: fast/forms/input-button-sizes.html

The setUpButtonCell function was running only once, but needed to run every time
through the button function.

  • platform/mac/ThemeMac.mm: (WebCore::leakButtonCell): Added. Separate one-time initialization code. (WebCore::setUpButtonCell): Removed the first-time initialization part of this function. (WebCore::button): Merged the three functions back into one.

2010-09-27 Darin Adler <Darin Adler>

Reviewed by Dan Bernstein.

REGRESSION (r68054): Buttons no longer render at correct sizes
https://bugs.webkit.org/show_bug.cgi?id=46513

  • fast/forms/input-button-sizes.html: Copied from LayoutTests/fast/forms/button-sizes.html. Turned into a distinct test of <input type=button>; old test was for <button>.
  • platform/mac/fast/forms/input-button-sizes-expected.checksum: Added.
  • platform/mac/fast/forms/input-button-sizes-expected.png: Added.
  • platform/mac/fast/forms/input-button-sizes-expected.txt: Added.
  • platform/mac/fast/forms/disabled-select-change-index-expected.checksum: Added.
  • platform/mac/fast/forms/disabled-select-change-index-expected.png: Added.
  • platform/mac/fast/forms/file-input-disabled-expected.checksum: Added.
  • platform/mac/fast/forms/file-input-disabled-expected.png: Added.
5:31 PM Changeset in webkit [68458] by zmo@google.com
  • 2 edits in trunk/LayoutTests

2010-09-27 Zhenyao Mo <zmo@google.com>

Unreviewed, fix a typo.

  • platform/chromium/test_expectations.txt:
5:31 PM Changeset in webkit [68457] by kenneth@webkit.org
  • 6 edits in trunk/WebKit/qt

[Qt] Remove setDeviceSize methods
https://bugs.webkit.org/show_bug.cgi?id=46347

Reviewed by Antonio Gomes.

Remove our setDeviceHeight() API and obtain it automatically from the
system. Also for testing purposes, make it possible to override the
values via two newly introduced environment variables.

  • Api/qgraphicswebview.cpp:
  • Api/qgraphicswebview.h:
  • Api/qwebpage.cpp:

(getintenv):
(queryDeviceSizeForScreenContainingWidget):
(QWebPage::viewportConfigurationForSize):

  • WebCoreSupport/PageClientQt.cpp:

(WebCore::PageClientQGraphicsWidget::windowRect):

  • symbian/eabi/QtWebKitu.def:
5:27 PM Changeset in webkit [68456] by andersca@apple.com
  • 2 edits in trunk/WebKit2

Turns out people other than me might want to build this thing.

  • WebKit2.xcodeproj/project.pbxproj:
5:25 PM Changeset in webkit [68455] by barraclough@apple.com
  • 2 edits in trunk/JavaScriptCore

Bug 46680 - Inlining string concatenation can regress interpreter performance
<rdar://problem/8362752> REGRESSION: ~6.4% sunspider regression in interpreter
Do not inline calls to string concatenation in the interpret loop.

Reviewed by Darin Adler.

  • interpreter/Interpreter.cpp:

(JSC::concatenateStrings):
(JSC::Interpreter::privateExecute):

5:16 PM Changeset in webkit [68454] by Darin Adler
  • 2 edits in trunk/WebKit2
  • Scripts/webkit2: Added property svn:ignore.
5:14 PM Changeset in webkit [68453] by eric@webkit.org
  • 4 edits in trunk/WebKitTools

2010-09-27 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

queue-status should report when the patch was last locked to a queue
https://bugs.webkit.org/show_bug.cgi?id=46674

This isn't necessarily the best way to expose this information
but having this accessible via the web interface is very
useful until we come up with a nicer way to display this.

I also cleaned up the code in activeworkitems.py a little
to use list comprehensions and to have the code work with
pairs instead of two lists at once. Eventually I think those
item/time pairs need to be their own little helper class.

  • QueueStatusServer/handlers/queuestatus.py:
  • QueueStatusServer/model/activeworkitems.py:
  • QueueStatusServer/templates/queuestatus.html:
5:14 PM Changeset in webkit [68452] by andersca@apple.com
  • 8 edits in trunk/WebKit2
  • Platform/CoreIPC/Connection.h:

(CoreIPC::Connection::sendSync):
Add new sendSync overload that takes a message struct.

Reviewed by Sam Weinig.

  • PluginProcess/WebProcessConnection.cpp:

(WebKit::WebProcessConnection::didReceiveSyncMessage):
Call didReceiveSyncWebProcessConnectionMessage.

  • WebProcess/Plugins/PluginProcessConnection.cpp:

(WebKit::PluginProcessConnection::addPluginProxy):
Add the plug-in proxy to the map.

(WebKit::PluginProcessConnection::removePluginProxy):
Remove the plug-in proxy from the map. If the map is empty, disconnect from the
plug-in process.

  • WebProcess/Plugins/PluginProxy.cpp:

(WebKit::generatePluginInstanceID):
Generate a unique plug-in instance ID.

(WebKit::PluginProxy::PluginProxy):
Add the plug-in proxy to the map.

(WebKit::PluginProxy::~PluginProxy):
Remove the plug-in proxy from the map.

(WebKit::PluginProxy::initialize):
Ask the plug-in process to create a plug-in.

5:04 PM Changeset in webkit [68451] by tony@chromium.org
  • 2 edits in trunk/WebKitTools

2010-09-27 Tony Chang <tony@chromium.org>

Reviewed by David Levin.

[chromium] fix detection of missing fonts on DRT
https://bugs.webkit.org/show_bug.cgi?id=46651

  • DumpRenderTree/chromium/TestShellGtk.cpp: (setupFontconfig): Only print an error message if lohit isn't found in both locations.
5:01 PM Changeset in webkit [68450] by tony@chromium.org
  • 3 edits in trunk/WebKitTools

2010-09-27 Tony Chang <tony@chromium.org>

Reviewed by Dimitri Glazkov.

add webkit unit tests to the chromium testers
https://bugs.webkit.org/show_bug.cgi?id=46669

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:
  • Scripts/run-chromium-webkit-unit-tests: Fix a bug where we weren't using the right configuration.
4:55 PM Changeset in webkit [68449] by kseo@webkit.org
  • 2 edits in trunk/WebKitTools

Unreviewed.

Adding myself to the committers list.

  • Scripts/webkitpy/common/config/committers.py:
4:52 PM Changeset in webkit [68448] by zmo@google.com
  • 2 edits in trunk/LayoutTests

2010-09-27 Zhenyao Mo <zmo@google.com>

Unreviewed. Three webgl tests TIMEOUT after hooking up ANGLE with in-process-webgl port.

  • platform/chromium/test_expectations.txt:
4:47 PM Changeset in webkit [68447] by commit-queue@webkit.org
  • 9 edits in trunk

2010-09-27 Victoria Kirst <vrk@google.com>

Reviewed by James Robinson.

Modifies VideoLayerChromium to do YUV to RGB color conversion in the
GPU. Also adds support for RGBA video frame formats, though this code
path is currently never run because the video frames are in YV12
format.
https://bugs.webkit.org/show_bug.cgi?id=45069

  • platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::initializeSharedObjects): (WebCore::LayerRendererChromium::cleanupSharedObjects):
  • platform/graphics/chromium/LayerRendererChromium.h: (WebCore::LayerRendererChromium::videoLayerSharedValues):
  • platform/graphics/chromium/VideoLayerChromium.cpp: (WebCore::VideoLayerChromium::SharedValues::SharedValues): (WebCore::VideoLayerChromium::SharedValues::~SharedValues): (WebCore::VideoLayerChromium::VideoLayerChromium): (WebCore::VideoLayerChromium::~VideoLayerChromium): (WebCore::VideoLayerChromium::updateContents): (WebCore::VideoLayerChromium::updateYUVContents): (WebCore::VideoLayerChromium::allocateYUVTextures): (WebCore::VideoLayerChromium::updateYUVTextures): (WebCore::VideoLayerChromium::updateRGBAContents): (WebCore::VideoLayerChromium::allocateTexture): (WebCore::VideoLayerChromium::updateTexture): (WebCore::VideoLayerChromium::updateContentsCompleted): (WebCore::VideoLayerChromium::draw): (WebCore::VideoLayerChromium::drawYUV): (WebCore::VideoLayerChromium::drawRGBA):
  • platform/graphics/chromium/VideoLayerChromium.h: (WebCore::VideoLayerChromium::drawsContent): (WebCore::VideoLayerChromium::SharedValues::yuvShaderProgram): (WebCore::VideoLayerChromium::SharedValues::rgbaShaderProgram): (WebCore::VideoLayerChromium::SharedValues::yuvShaderMatrixLocation): (WebCore::VideoLayerChromium::SharedValues::rgbaShaderMatrixLocation): (WebCore::VideoLayerChromium::SharedValues::yuvWidthScaleFactorLocation): (WebCore::VideoLayerChromium::SharedValues::rgbaWidthScaleFactorLocation): (WebCore::VideoLayerChromium::SharedValues::yTextureLocation): (WebCore::VideoLayerChromium::SharedValues::uTextureLocation): (WebCore::VideoLayerChromium::SharedValues::vTextureLocation): (WebCore::VideoLayerChromium::SharedValues::yuvAlphaLocation): (WebCore::VideoLayerChromium::SharedValues::rgbaTextureLocation): (WebCore::VideoLayerChromium::SharedValues::ccMatrixLocation): (WebCore::VideoLayerChromium::SharedValues::initialized):

2010-09-27 Victoria Kirst <vrk@google.com>

Reviewed by James Robinson.

Fixing constants in VideoFrameChromiumImpl so that it overloads the
VideoFrameChromium const declarations. Also adding logic such that a
VideoFrameChromium understands what size its texture should be based
on frame format.
https://bugs.webkit.org/show_bug.cgi?id=45069

  • src/VideoFrameChromiumImpl.cpp:
4:44 PM Changeset in webkit [68446] by pkasting@chromium.org
  • 7 edits
    3 adds in trunk

WebCore: ImageDecoderSkia.cpp needs to check for allocator failure when copying
bitmaps.
https://bugs.webkit.org/show_bug.cgi?id=46437

Reviewed by James Robinson.

  • manual-tests/large-size-image-crash.html: Added.
  • manual-tests/resources/large-size-image-crash.gif: Added.
  • platform/image-decoders/ImageDecoder.cpp:

(WebCore::RGBA32Buffer::copyBitmapData):

  • platform/image-decoders/ImageDecoder.h:
  • platform/image-decoders/gif/GIFImageDecoder.cpp:

(WebCore::GIFImageDecoder::initFrameBuffer):

  • platform/image-decoders/qt/RGBA32BufferQt.cpp:

(WebCore::RGBA32Buffer::copyBitmapData):

  • platform/image-decoders/skia/ImageDecoderSkia.cpp:

(WebCore::RGBA32Buffer::copyBitmapData):

LayoutTests: This resource should have been in r62399; without it the test no-ops.
https://bugs.webkit.org/show_bug.cgi?id=41487

Reviewed by James Robinson.

  • fast/images/resources/large-size-image-crash.jpeg: Added.
4:38 PM Changeset in webkit [68445] by andersca@apple.com
  • 9 edits
    1 add in trunk/WebKit2

Add WebProcessConnection CreatePlugin message
https://bugs.webkit.org/show_bug.cgi?id=46668

Reviewed by Adam Roben.

  • DerivedSources.make:

Add WebProcessConnection.

  • Platform/CoreIPC/HandleMessage.h:

Add handleMessage overload for a sync message with two input parameters
and one output parameter.

(CoreIPC::handleMessage):

  • Platform/CoreIPC/MessageID.h:

Add MessageClassWebProcessConnection.

  • PluginProcess/WebProcessConnection.cpp:

(WebKit::WebProcessConnection::createPlugin):
Add stub.

  • PluginProcess/WebProcessConnection.messages.in: Added.
  • Scripts/webkit2/messages.py:

Include headers directly for types that we believe are nested structs.

  • Scripts/webkit2/messages_unittest.py:

Update expected results.

  • WebKit2.xcodeproj/project.pbxproj:

Add new files.

4:38 PM Changeset in webkit [68444] by jamesr@google.com
  • 8 edits
    4 adds in trunk

2010-09-27 James Robinson <jamesr@chromium.org>

Reviewed by Simon Fraser.

Repaint test for dynamically changing an SVG element's style attribute
https://bugs.webkit.org/show_bug.cgi?id=46499

  • fast/repaint/repaint-svg-after-style-change-expected.checksum: Added.
  • fast/repaint/repaint-svg-after-style-change-expected.png: Added.
  • fast/repaint/repaint-svg-after-style-change-expected.txt: Added.
  • fast/repaint/repaint-svg-after-style-change.html: Added.

2010-09-27 James Robinson <jamesr@chromium.org>

Reviewed by Simon Fraser.

Revert r63307, it broke repainting dynamically changed SVG content
https://bugs.webkit.org/show_bug.cgi?id=46499

This patch reverts r63307 and adds a regression test for what broke.

Test: fast/repaint/repaint-svg-after-style-change.html

  • rendering/RenderForeignObject.cpp: (WebCore::RenderForeignObject::layout):
  • rendering/RenderPath.cpp: (WebCore::RenderPath::layout):
  • rendering/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::layout):
  • rendering/RenderSVGImage.cpp: (WebCore::RenderSVGImage::layout):
  • rendering/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::layout):
  • rendering/RenderSVGText.cpp: (WebCore::RenderSVGText::layout):
4:35 PM Changeset in webkit [68443] by Martin Robinson
  • 2 edits
    1 add in trunk/LayoutTests

2010-09-27 Martin Robinson <mrobinson@igalia.com>

Unskip a test that just needed a platform-specific baseline and add a baseline for it.

  • platform/gtk/Skipped: Unskip test with new baseline.
  • platform/gtk/editing/selection/extend-selection-expected.txt: Added.
4:35 PM Changeset in webkit [68442] by vangelis@chromium.org
  • 10 edits in trunk

2010-09-27 Vangelis Kokkevis <vangelis@chromium.org>

Reviewed by James Robinson.

[chromium] WebViewImpl now holds a ref counted pointer to the LayerRendererChromium
to ensure that the compositor does not get destroyed before the layers used
by it do. This was done to ensure that layers properly clean up their texture
resources on destruction.
https://bugs.webkit.org/show_bug.cgi?id=46139

  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
  • src/WebViewImpl.h:

2010-09-27 Vangelis Kokkevis <vangelis@chromium.org>

Reviewed by James Robinson.

[chromium] Making LayerChromium's destructor virtual so that the appropriate
derived class destructors get called when the layer tree is taken down.
ContentLayerChromium and its derived types (ImageLayerChromium for now) will
free up the texture allocated for their contents upon destruction. To avoid
having the LayerRendererChromium destructor getting called before the layers
are destroyed and thus leaving their textures orphaned, the layers now hold
a ref counted pointer to the renderer that uses them.
https://bugs.webkit.org/show_bug.cgi?id=46139

  • platform/graphics/chromium/ContentLayerChromium.cpp: (WebCore::ContentLayerChromium::~ContentLayerChromium): (WebCore::ContentLayerChromium::setLayerRenderer): (WebCore::ContentLayerChromium::cleanupResources):
  • platform/graphics/chromium/ContentLayerChromium.h:
  • platform/graphics/chromium/LayerChromium.cpp: (WebCore::LayerChromium::setLayerRenderer):
  • platform/graphics/chromium/LayerChromium.h: (WebCore::LayerChromium::layerRenderer):
  • platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::create): (WebCore::LayerRendererChromium::deleteLayerTexture): (WebCore::LayerRendererChromium::cleanupSharedObjects):
  • platform/graphics/chromium/LayerRendererChromium.h:
4:28 PM Changeset in webkit [68441] by commit-queue@webkit.org
  • 1 edit
    4 adds in trunk/LayoutTests

2010-09-27 Alexey Marinichev <amarinichev@chromium.org>

Reviewed by David Levin.

Test that scrolls a checkerboard pattern. If the hardware compositor
miscalculates texture coordinates, corruption is very likely to occur.

  • compositing/checkerboard.html: Added.
  • compositing/checkerboard-expected.checksum: Added.
  • compositing/checkerboard-expected.png: Added.
  • compositing/checkerboard-expected.txt: Added.
4:12 PM Changeset in webkit [68440] by arv@chromium.org
  • 32 edits
    14 adds in trunk

2010-09-27 Erik Arvidsson <arv@chromium.org>

Reviewed by Darin Adler.

Implement HTML 5's HTMLElement.classList property
https://bugs.webkit.org/show_bug.cgi?id=20709

  • fast/dom/HTMLElement/class-list-expected.txt: Added.
  • fast/dom/HTMLElement/class-list-gc-expected.txt: Added.
  • fast/dom/HTMLElement/class-list-gc.html: Added.
  • fast/dom/HTMLElement/class-list-quirks-expected.txt: Added.
  • fast/dom/HTMLElement/class-list-quirks.html: Added.
  • fast/dom/HTMLElement/class-list.html: Added.
  • fast/dom/HTMLElement/script-tests/class-list-gc.js: Added. (gc):
  • fast/dom/HTMLElement/script-tests/class-list.js: Added. (createElement):
  • fast/dom/Window/window-properties-expected.txt:
  • fast/dom/Window/window-property-descriptors-expected.txt:
  • fast/dom/prototype-inheritance-2-expected.txt:
  • fast/dom/prototype-inheritance-expected.txt:
  • fast/js/global-constructors-expected.txt:
  • perf/class-list-remove-expected.txt: Added.
  • perf/class-list-remove.html: Added.

2010-09-27 Erik Arvidsson <arv@chromium.org>

Reviewed by Darin Adler.

Implement HTML 5's HTMLElement.classList property
https://bugs.webkit.org/show_bug.cgi?id=20709

This adds a DOMTokenList class that is used for the classList property. DOMTokenList uses a SpaceSplitString for fast
contains check. In standards mode the existing classNames is used but in quirks mode we use an internal SpaceSplitString
because classList is always case sensitive.

Tests: fast/dom/HTMLElement/class-list-gc.html

fast/dom/HTMLElement/class-list-quirks.html
fast/dom/HTMLElement/class-list.html
perf/class-list-remove.html

  • Android.derived.jscbindings.mk:
  • Android.derived.v8bindings.mk:
  • Android.jscbindings.mk:
  • CMakeLists.txt:
  • DerivedSources.cpp:
  • DerivedSources.make:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pri:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/gobject/GNUmakefile.am:
  • bindings/js/JSElementCustom.cpp: (WebCore::JSElement::markChildren): Make sure that we keep the wrapper while the element is alive.
  • bindings/scripts/CodeGeneratorJS.pm: DOMTokenList has a string indexed getter.
  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/v8/custom/V8DOMTokenListCustom.cpp: Added. (WebCore::toV8):
  • dom/Element.cpp: (WebCore::Element::classList): (WebCore::Element::optionalClassList):
  • dom/Element.h:
  • dom/ElementRareData.h: This now has an OwnPtr to a ClassList if the Element::classList is ever called.
  • dom/SpaceSplitString.h: (WebCore::SpaceSplitString::isNull):
  • dom/StyledElement.cpp: (WebCore::StyledElement::classAttributeChanged): Update the classList if it exists.
  • dom/StyledElement.h:
  • html/DOMTokenList.cpp: Added. (WebCore::validateToken): (WebCore::DOMTokenList::DOMTokenList): (WebCore::DOMTokenList::ref): (WebCore::DOMTokenList::deref): (WebCore::DOMTokenList::length): (WebCore::DOMTokenList::item): (WebCore::DOMTokenList::contains): (WebCore::DOMTokenList::containsInternal): The internal methods do no validation of the token. (WebCore::DOMTokenList::add): (WebCore::DOMTokenList::addInternal): (WebCore::DOMTokenList::remove): (WebCore::DOMTokenList::removeInternal): (WebCore::DOMTokenList::toggle): (WebCore::DOMTokenList::toString): (WebCore::DOMTokenList::reset): (WebCore::DOMTokenList::classNames):
  • html/DOMTokenList.h: Added. (WebCore::DOMTokenList::create): (WebCore::DOMTokenList::element):
  • html/DOMTokenList.idl: Added.
  • html/HTMLElement.idl:
  • page/DOMWindow.cpp:
  • page/DOMWindow.idl:
4:07 PM Changeset in webkit [68439] by kbr@google.com
  • 1 edit
    2 adds in trunk/WebCore

2010-09-27 Kenneth Russell <kbr@google.com>

Reviewed by James Robinson.

Add local triangulation of cubic curve control points
https://bugs.webkit.org/show_bug.cgi?id=45252

(Re-landing; I neglected to actually add the new files in
http://trac.webkit.org/changeset/68045 .)

Adding a localized triangulation algorithm which takes as input
the four control points of a cubic curve segment and provides both
triangles as well as the ability to walk the interior edges. The
latter will be used later to fill the interior of shapes bounded
by these cubic curves, quadratic curves and line segments.

  • platform/graphics/gpu/LoopBlinnLocalTriangulator.cpp: Added. (WebCore::LoopBlinnLocalTriangulator::Triangle::contains): (WebCore::LoopBlinnLocalTriangulator::Triangle::nextVertex): (WebCore::LoopBlinnLocalTriangulator::Triangle::indexForVertex): (WebCore::LoopBlinnLocalTriangulator::Triangle::makeCounterClockwise): (WebCore::LoopBlinnLocalTriangulator::LoopBlinnLocalTriangulator): (WebCore::LoopBlinnLocalTriangulator::reset): (WebCore::LoopBlinnLocalTriangulator::triangulate): (WebCore::LoopBlinnLocalTriangulator::triangulateHelper): (WebCore::LoopBlinnLocalTriangulator::addTriangle): (WebCore::LoopBlinnLocalTriangulator::addInteriorVertex): (WebCore::LoopBlinnLocalTriangulator::isSharedEdge):
  • platform/graphics/gpu/LoopBlinnLocalTriangulator.h: Added. (WebCore::LoopBlinnLocalTriangulator::Vertex::Vertex): (WebCore::LoopBlinnLocalTriangulator::Vertex::xyCoordinates): (WebCore::LoopBlinnLocalTriangulator::Vertex::klmCoordinates): (WebCore::LoopBlinnLocalTriangulator::Vertex::set): (WebCore::LoopBlinnLocalTriangulator::Vertex::end): (WebCore::LoopBlinnLocalTriangulator::Vertex::setEnd): (WebCore::LoopBlinnLocalTriangulator::Vertex::marked): (WebCore::LoopBlinnLocalTriangulator::Vertex::setMarked): (WebCore::LoopBlinnLocalTriangulator::Vertex::interior): (WebCore::LoopBlinnLocalTriangulator::Vertex::setInterior): (WebCore::LoopBlinnLocalTriangulator::Vertex::resetFlags): (WebCore::LoopBlinnLocalTriangulator::Triangle::Triangle): (WebCore::LoopBlinnLocalTriangulator::Triangle::getVertex): (WebCore::LoopBlinnLocalTriangulator::Triangle::setVertices): (WebCore::LoopBlinnLocalTriangulator::getVertex): (WebCore::LoopBlinnLocalTriangulator::numberOfTriangles): (WebCore::LoopBlinnLocalTriangulator::getTriangle): (WebCore::LoopBlinnLocalTriangulator::numberOfInteriorVertices): (WebCore::LoopBlinnLocalTriangulator::getInteriorVertex):
4:00 PM Changeset in webkit [68438] by crogers@google.com
  • 1 edit
    3 adds in trunk/WebCore

2010-09-27 Chris Rogers <crogers@google.com>

Reviewed by Kenneth Russell.

Add AudioNode files
https://bugs.webkit.org/show_bug.cgi?id=45571

No new tests since audio API is not yet implemented.

  • webaudio/AudioNode.cpp: Added. (WebCore::AudioNode::AudioNode): (WebCore::AudioNode::~AudioNode): (WebCore::AudioNode::setType): (WebCore::AudioNode::lazyInitialize): (WebCore::AudioNode::addInput): (WebCore::AudioNode::addOutput): (WebCore::AudioNode::input): (WebCore::AudioNode::output): (WebCore::AudioNode::connect): (WebCore::AudioNode::disconnect): (WebCore::AudioNode::processIfNecessary): (WebCore::AudioNode::pullInputs): (WebCore::AudioNode::ref): (WebCore::AudioNode::deref): (WebCore::AudioNode::finishDeref): (WebCore::AudioNode::printNodeCounts):
  • webaudio/AudioNode.h: Added. (WebCore::AudioNode::context): (WebCore::AudioNode::type): (WebCore::AudioNode::isInitialized): (WebCore::AudioNode::numberOfInputs): (WebCore::AudioNode::numberOfOutputs): (WebCore::AudioNode::sampleRate): (WebCore::AudioNode::checkNumberOfChannelsForInput):
  • webaudio/AudioNode.idl: Added.
3:58 PM Changeset in webkit [68437] by mrowe@apple.com
  • 5 edits in branches/safari-533.19-branch

Versioning.

3:58 PM Changeset in webkit [68436] by hyatt@apple.com
  • 4 edits
    5 adds in trunk

https://bugs.webkit.org/show_bug.cgi?id=46665

Reviewed by Sam Weinig.

Patch RenderView's layout and computeLogicalWidth/Height methods to be block-flow-aware.

Added fast/root-lr-basic.html

WebCore:

  • rendering/RenderView.cpp:

(WebCore::RenderView::computeLogicalHeight):
(WebCore::RenderView::computeLogicalWidth):
(WebCore::RenderView::layout):

  • rendering/RenderView.h:

(WebCore::RenderView::viewLogicalWidth):
(WebCore::RenderView::viewLogicalHeight):

LayoutTests:

  • fast/blockflow/root-lr-basic.html: Added.
  • platform/mac/fast/blockflow: Added.
  • platform/mac/fast/blockflow/root-lr-basic-expected.checksum: Added.
  • platform/mac/fast/blockflow/root-lr-basic-expected.png: Added.
  • platform/mac/fast/blockflow/root-lr-basic-expected.txt: Added.
3:55 PM Changeset in webkit [68435] by weinig@apple.com
  • 8 edits in trunk/WebKit2

Add remaining event handlers to WKView.

Reviewed by Anders Carlsson.

Also fixes <rdar://problem/8467058>
Does not get decidePolicyForNavigationAction callback when middle clicking a link

  • Adds otherButton and rightButton NSResponder event handlers to WKView.
  • Renames WebPageProxy event handlers to use the handle prefix.
  • Uses a macro to reduce duplicate code for WKView event handlers.
  • Add view parameter to WebEventFactory::createWebKeyboardEvent on the mac for uniformity.
  • Shared/mac/WebEventFactory.h:
  • Shared/mac/WebEventFactory.mm:

(WebKit::WebEventFactory::createWebKeyboardEvent):

  • UIProcess/API/mac/WKView.mm:
  • UIProcess/API/qt/qwkpage.cpp:

(QWKPagePrivate::keyPressEvent):
(QWKPagePrivate::keyReleaseEvent):
(QWKPagePrivate::mouseMoveEvent):
(QWKPagePrivate::mousePressEvent):
(QWKPagePrivate::mouseReleaseEvent):
(QWKPagePrivate::mouseDoubleClickEvent):
(QWKPagePrivate::wheelEvent):
(QWKPagePrivate::touchEvent):

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::handleMouseEvent):
(WebKit::WebPageProxy::handleWheelEvent):
(WebKit::WebPageProxy::handleKeyboardEvent):
(WebKit::WebPageProxy::handleTouchEvent):

  • UIProcess/WebPageProxy.h:
  • UIProcess/win/WebView.cpp:

(WebKit::WebView::onMouseEvent):
(WebKit::WebView::onWheelEvent):
(WebKit::WebView::onKeyEvent):

3:51 PM Changeset in webkit [68434] by zmo@google.com
  • 6 edits in trunk

2010-09-24 Zhenyao Mo <zmo@google.com>

Reviewed by Kenneth Russell.

Hook up ANGLE with chromium --in-process-webgl port
https://bugs.webkit.org/show_bug.cgi?id=44309

  • WebKit.gyp: Add angle dependency.
  • src/WebGraphicsContext3DDefaultImpl.cpp: Using angle for shader validation and translation. (WebKit::WebGraphicsContext3DDefaultImpl::WebGraphicsContext3DDefaultImpl): (WebKit::WebGraphicsContext3DDefaultImpl::~WebGraphicsContext3DDefaultImpl): (WebKit::WebGraphicsContext3DDefaultImpl::initialize): (WebKit::WebGraphicsContext3DDefaultImpl::compileShader): (WebKit::WebGraphicsContext3DDefaultImpl::getIntegerv): Using defined const instead. (WebKit::WebGraphicsContext3DDefaultImpl::getShaderiv): (WebKit::WebGraphicsContext3DDefaultImpl::getShaderInfoLog): (WebKit::WebGraphicsContext3DDefaultImpl::getShaderSource): (WebKit::WebGraphicsContext3DDefaultImpl::shaderSource): (WebKit::WebGraphicsContext3DDefaultImpl::createShader): (WebKit::WebGraphicsContext3DDefaultImpl::deleteShader): (WebKit::WebGraphicsContext3DDefaultImpl::angleCreateCompilers): (WebKit::WebGraphicsContext3DDefaultImpl::angleDestroyCompilers): (WebKit::WebGraphicsContext3DDefaultImpl::angleValidateShaderSource):
  • src/WebGraphicsContext3DDefaultImpl.h: Add necessary data and functions for angle stuff. (WebKit::WebGraphicsContext3DDefaultImpl::ShaderSourceEntry::ShaderSourceEntry): (WebKit::WebGraphicsContext3DDefaultImpl::ShaderSourceEntry::~ShaderSourceEntry):

2010-09-24 Zhenyao Mo <zmo@google.com>

Reviewed by Kenneth Russell.

Hook up ANGLE with chromium --in-process-webgl port
https://bugs.webkit.org/show_bug.cgi?id=44309

  • platform/graphics/GraphicsContext3D.h: Move Angle stuff inside MAC only section.
3:47 PM Changeset in webkit [68433] by mrowe@apple.com
  • 1 copy in branches/safari-533.19-branch

New branch.

3:42 PM Changeset in webkit [68432] by mihaip@chromium.org
  • 2 edits in trunk/WebKitTools

2010-09-27 Mihai Parparita <mihaip@chromium.org>

Reviewed by Eric Seidel.

webkitpy.common.system.user_unittest.UserTest.test_prompt_with_list spams the console
https://bugs.webkit.org/show_bug.cgi?id=46634

Use OutputCapture to prevent console spam (and also check for expected
output).

  • Scripts/webkitpy/common/system/user_unittest.py:
3:41 PM Changeset in webkit [68431] by zmo@google.com
  • 2 edits in trunk/LayoutTests

2010-09-27 Zhenyao Mo <zmo@google.com>

Unreviewed, add fast/canvas/webgl/object-deletion-behaviour.html to test_expectations.txt (failing on Win/Linux).

  • platform/chromium/test_expectations.txt:
3:32 PM Changeset in webkit [68430] by hyatt@apple.com
  • 2 edits in trunk/WebCore

https://bugs.webkit.org/show_bug.cgi?id=46659

Reviewed by Sam Weinig.

Patch the width/height/x/y calls in layoutBlock() to be their logical equivalents instead.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::layoutBlock):

3:10 PM Changeset in webkit [68429] by mrowe@apple.com
  • 2 edits in trunk/WebKit2

<rdar://problem/8348990> / <http://webkit.org/b/46633> Make it possible to disable sandboxing of
web process via runtime flag.

Patch by Ivan Krstić <ike@apple.com> on 2010-09-27
Reviewed by Mark Rowe.

Enable sandboxing of the web process only if the DisableSandbox user default is not set for the
web process.

  • WebProcess/mac/WebProcessMainMac.mm:

(WebKit::WebProcessMain):

3:01 PM Changeset in webkit [68428] by andersca@apple.com
  • 3 edits in trunk/WebKit2

Add support for autogenerating synchronous message handlers
https://bugs.webkit.org/show_bug.cgi?id=46654

Reviewed by Adam Roben.

  • Scripts/webkit2/messages.py:

(reply_type): Renamed from reply_base_class.
(delayed_reply_type): Renamed from delayed_reply_base_class.
(message_to_struct_declaration): Add a Reply type typedef.
(async_case_statement): Rename from case_statement.
(generate_message_handler): Generate a sync message handler as well.

  • Scripts/webkit2/messages_unittest.py:

Update expected results.

2:56 PM Changeset in webkit [68427] by hyatt@apple.com
  • 12 edits in trunk

https://bugs.webkit.org/show_bug.cgi?id=46649, fix failing layout tests.

Reviewed by Sam Weinig.

The implementation of setting the before/after margins was wrong and poking the wrong margin values.

Once I made them set the correct values, it revealed that one of the new block flow tests wasn't
actually working. In order to fix it, I had to make the block direction margin computation actually
use the containing block's block-flow in order to return the right answer. This involved cleaning
up computeBlockDirectionMargins to be more like computeInlineDirectionMargins.

fast/css/logical-property-resolution.html also caught the bug. Its results are now correct.

WebCore:

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::adjustPositionedBlock):
(WebCore::RenderBlock::determineHorizontalPosition):
(WebCore::RenderBlock::layoutBlockChild):
(WebCore::RenderBlock::insertFloatingObject):

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::setMarginBeforeUsing):
(WebCore::RenderBox::setMarginAfterUsing):
(WebCore::RenderBox::computeLogicalWidth):
(WebCore::RenderBox::computeInlineDirectionMargins):
(WebCore::RenderBox::computeLogicalHeight):
(WebCore::RenderBox::computeBlockDirectionMargins):

  • rendering/RenderBox.h:
  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::layoutHorizontalBox):
(WebCore::RenderFlexibleBox::layoutVerticalBox):

  • rendering/RenderObject.h:
  • rendering/RenderTable.cpp:

(WebCore::RenderTable::computeLogicalWidth):

  • rendering/RenderTableRow.cpp:

(WebCore::RenderTableRow::layout):

  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::marginBeforeUsing):
(WebCore::RenderStyle::marginAfterUsing):

  • rendering/style/RenderStyle.h:

LayoutTests:

  • fast/css/logical-property-resolution-expected.txt:
2:54 PM Changeset in webkit [68426] by andersca@apple.com
  • 2 edits in trunk/JavaScriptCore

Fix thinko.

  • runtime/JSCell.h:
2:48 PM Changeset in webkit [68425] by andersca@apple.com
  • 2 edits in trunk/JavaScriptCore

Try to fix Windows build.

Reviewed by Adam Roben.

  • runtime/JSCell.h:

(JSC::MSVCBugWorkaround::MSVCBugWorkaround):
(JSC::MSVCBugWorkaround::~MSVCBugWorkaround):

2:27 PM Changeset in webkit [68424] by zmo@google.com
  • 12 edits
    2 adds in trunk

2010-09-14 Zhenyao Mo <zmo@google.com>

Reviewed by Kenneth Russell.

Textures and renderbuffers should be detached first before deletion if they are attached to framebuffers
https://bugs.webkit.org/show_bug.cgi?id=43942

Test: fast/canvas/webgl/object-deletion-behaviour.html

  • html/canvas/WebGLBuffer.cpp: (WebCore::WebGLBuffer::deleteObjectImpl): Delete the object only once.
  • html/canvas/WebGLFramebuffer.cpp: Use RefPtr for attachment WebGLObjects. (WebCore::WebGLFramebuffer::WebGLFramebuffer): (WebCore::WebGLFramebuffer::removeAttachment): Remove an attachment data ref. (WebCore::WebGLFramebuffer::onAttachedObjectChange): (WebCore::WebGLFramebuffer::getColorBufferFormat): (WebCore::WebGLFramebuffer::deleteObjectImpl): (WebCore::WebGLFramebuffer::initializeRenderbuffers):
  • html/canvas/WebGLFramebuffer.h: Declare removeAttachment().
  • html/canvas/WebGLObject.cpp: (WebCore::WebGLObject::setObject): Make it protected and can only be called when initializing.
  • html/canvas/WebGLObject.h: (WebCore::WebGLObject::onDetached): Fix a bug. (WebCore::WebGLObject::isDeleted): Expose the delete flag.
  • html/canvas/WebGLProgram.cpp: (WebCore::WebGLProgram::deleteObjectImpl): Detach shaders when deleting a program.
  • html/canvas/WebGLRenderbuffer.cpp: (WebCore::WebGLRenderbuffer::deleteObjectImpl): Delete the object only once.
  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::deleteFramebuffer): Bind to internal fbo when deleting the currently-bound fbo. (WebCore::WebGLRenderingContext::deleteRenderbuffer): Remove renderbuffer from currently-bound fbo upon deletion. (WebCore::WebGLRenderingContext::deleteTexture): Remove texture from currently-bound fbo upon deletion. (WebCore::WebGLRenderingContext::useProgram): Fix a condition.
  • html/canvas/WebGLShader.cpp: (WebCore::WebGLShader::deleteObjectImpl): Delete the object only once.
  • html/canvas/WebGLTexture.cpp: (WebCore::WebGLTexture::deleteObjectImpl): Ditto.

2010-09-14 Zhenyao Mo <zmo@google.com>

Reviewed by Kenneth Russell.

Textures and renderbuffers should be detached first before deletion if they are attached to framebuffers
https://bugs.webkit.org/show_bug.cgi?id=43942

  • fast/canvas/webgl/object-deletion-behaviour-expected.txt: Added.
  • fast/canvas/webgl/object-deletion-behaviour.html: Added.
2:10 PM Changeset in webkit [68423] by rniwa@webkit.org
  • 4 edits
    3 adds in trunk

2010-09-27 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Antonio Gomes.

stateStyle (@EditorCommand.cpp) should ask EditingBehavior for platform specific behavior
https://bugs.webkit.org/show_bug.cgi?id=41989

queryCommandState returns true even when in the mixed state
https://bugs.webkit.org/show_bug.cgi?id=46382

Fixed stateStyle so that it calls selectionStartHasStyle when shouldToggleStyleBasedOnStartOfSelection
is true (Mac platforms) and calls selectionHasStyle otherwise (non-Mac platforms).

Also fixed queryCommandState so that it only returns true when the state is TrueTriState
as supposed to returning true whenever the state is not FalseTriState. New behavior matches that of
other browsers such as Firefox and Internet Explorer.

  • dom/Document.cpp: (WebCore::Document::queryCommandState):
  • editing/EditorCommand.cpp: (WebCore::executeToggleStyle): (WebCore::stateStyle):

2010-09-27 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Antonio Gomes.

stateStyle (@EditorCommand.cpp) should ask EditingBehavior for platform specific behavior
https://bugs.webkit.org/show_bug.cgi?id=41989

Added a test to ensure queryCommandState returns correct values on Mac and Windows.

  • editing/execCommand/query-command-state-expected.txt: Added.
  • editing/execCommand/script-tests/query-command-state.js: Added. (testQueryCommandState): (selectAll): (selectSecondWord): (selectFirstTwoWords): (runTests):
1:43 PM Changeset in webkit [68422] by arv@chromium.org
  • 4 edits in trunk/JavaScriptCore

2010-09-27 Erik Arvidsson <arv@chromium.org>

Reviewed by Darin Adler.

Add operator == for AtomicString and Vector<Uchar>
https://bugs.webkit.org/show_bug.cgi?id=46509

  • JavaScriptCore.exp:
  • wtf/text/AtomicString.cpp: (WTF::operator==):
  • wtf/text/AtomicString.h: (WTF::operator==): (WTF::operator!=):
1:21 PM Changeset in webkit [68421] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-09-27 Eric Seidel <eric@webkit.org>

Reviewed by James Robinson.

start-commit-queue should abort any rebases in progress
https://bugs.webkit.org/show_bug.cgi?id=46640

webkit-patch commit-queue would do this itself, but this just
helps ensure that the commit-queue script is properly updated
before we run it (in the case where a previous rebase is in
progress the git svn rebase would not work before we run the
commit-queue).

  • EWSTools/start-commit-queue.sh:
1:16 PM Changeset in webkit [68420] by hyatt@apple.com
  • 3 edits in trunk/WebCore

https://bugs.webkit.org/show_bug.cgi?id=46647, add getters/setters for the logical position of a box.

Reviewed by Dan Bernstein.

Also made all of the logicalWidth/Height getters/setters inline for performance.

  • rendering/RenderBox.cpp:
  • rendering/RenderBox.h:

(WebCore::RenderBox::logicalLeft):
(WebCore::RenderBox::logicalTop):
(WebCore::RenderBox::logicalWidth):
(WebCore::RenderBox::logicalHeight):
(WebCore::RenderBox::setLogicalLeft):
(WebCore::RenderBox::setLogicalTop):
(WebCore::RenderBox::setLogicalWidth):
(WebCore::RenderBox::setLogicalHeight):
(WebCore::RenderBox::setLogicalLocation):

1:02 PM Changeset in webkit [68419] by andersca@apple.com
  • 2 edits in trunk/JavaScriptCore

Try to fix the Windows build.

  • wtf/Noncopyable.h:
12:46 PM Changeset in webkit [68418] by Martin Robinson
  • 18 edits in trunk/LayoutTests

2010-09-27 Martin Robinson <mrobinson@igalia.com>

Rebaseline some tests where results differ between my machines
and the bots. Also skip two tests which, combined with r68406
exposed existing bugs.

  • platform/gtk/Skipped: Skip two tests with recently exposed bugs.
  • platform/gtk/fast/events/keydown-1-expected.txt:
  • platform/gtk/fast/frames/onlyCommentInIFrame-expected.txt:
  • platform/gtk/media/audio-controls-rendering-expected.txt:
  • platform/gtk/media/audio-no-installed-engines-expected.txt:
  • platform/gtk/media/controls-after-reload-expected.txt:
  • platform/gtk/media/controls-strict-expected.txt:
  • platform/gtk/media/video-display-toggle-expected.txt:
  • platform/gtk/media/video-empty-source-expected.txt:
  • platform/gtk/media/video-no-audio-expected.txt:
  • platform/gtk/media/video-replaces-poster-expected.txt:
  • platform/gtk/media/video-zoom-expected.txt:
  • platform/gtk/svg/batik/paints/patternRegions-positioned-objects-expected.txt:
  • platform/gtk/svg/custom/relative-sized-inner-svg-expected.txt:
  • platform/gtk/svg/custom/relative-sized-use-without-attributes-on-symbol-expected.txt:
  • platform/gtk/svg/zoom/page/zoom-coords-viewattr-01-b-expected.txt:
  • platform/gtk/svg/zoom/text/zoom-coords-viewattr-01-b-expected.txt:
12:42 PM Changeset in webkit [68417] by hyatt@apple.com
  • 11 edits
    6 adds in trunk

https://bugs.webkit.org/show_bug.cgi?id=46639, make computeLogicalHeight block-flow-aware.

Reviewed by Sam Weinig.

This patch does the following:

(1) Makes computeLogicalHeight block-flow-aware (patching all helper functions as needed to make this work).
(2) Makes block flow roots (blocks whose parent has a different block-flow directionality) establish new block formatting contexts.
(This causes them to not collapse their margins with their children and to avoid floats).
(3) Patch all occurrences of setHeight in block and line layout to setLogicalHeight so that height doesn't get incorrectly
overwritten for lr/rl block-flow. This is necessary to write tests that examine the width/height of the blocks.


Added multiple new tests in fast/blockflow.
fast/css/logical-property-resolution gives the correct results now.

WebCore:

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::MarginInfo::MarginInfo):
(WebCore::RenderBlock::layoutBlock):
(WebCore::RenderBlock::expandsToEncloseOverhangingFloats):
(WebCore::RenderBlock::adjustFloatingBlock):
(WebCore::RenderBlock::collapseMargins):
(WebCore::RenderBlock::clearFloatsIfNeeded):
(WebCore::RenderBlock::determineHorizontalPosition):
(WebCore::RenderBlock::handleBottomOfBlock):
(WebCore::RenderBlock::layoutBlockChildren):
(WebCore::RenderBlock::layoutBlockChild):
(WebCore::RenderBlock::positionNewFloatOnLine):
(WebCore::RenderBlock::newLine):
(WebCore::RenderBlock::logicalLeftOffsetForLine):
(WebCore::RenderBlock::logicalRightOffsetForContent):
(WebCore::RenderBlock::logicalRightOffsetForLine):
(WebCore::RenderBlock::getClearDelta):
(WebCore::RenderBlock::layoutColumns):

  • rendering/RenderBlock.h:
  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::computeBlockDirectionPositionsForLine):
(WebCore::RenderBlock::layoutInlineChildren):
(WebCore::RenderBlock::determineStartPosition):
(WebCore::RenderBlock::fitBelowFloats):

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::marginBefore):
(WebCore::RenderBox::marginBeforeUsing):
(WebCore::RenderBox::marginAfter):
(WebCore::RenderBox::marginAfterUsing):
(WebCore::RenderBox::setMarginBefore):
(WebCore::RenderBox::setMarginAfter):
(WebCore::RenderBox::setMarginBeforeUsing):
(WebCore::RenderBox::setMarginAfterUsing):
(WebCore::RenderBox::computeLogicalHeight):
(WebCore::RenderBox::computeLogicalHeightUsing):
(WebCore::RenderBox::computePercentageLogicalHeight):
(WebCore::RenderBox::computeReplacedHeightUsing):
(WebCore::RenderBox::availableLogicalHeight):
(WebCore::RenderBox::availableLogicalHeightUsing):
(WebCore::RenderBox::computeBlockDirectionMargins):
(WebCore::RenderBox::avoidsFloats):

  • rendering/RenderBox.h:

(WebCore::RenderBox::contentLogicalWidth):
(WebCore::RenderBox::contentLogicalHeight):
(WebCore::RenderBox::stretchesToViewHeight):
(WebCore::RenderBox::availableLogicalWidth):
(WebCore::RenderBox::availableWidth):
(WebCore::RenderBox::availableHeight):
(WebCore::RenderBox::isBlockFlowRoot):

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::computeLogicalWidth):

LayoutTests:

  • fast/blockflow/auto-margins-across-boundaries-expected.txt: Added.
  • fast/blockflow/auto-margins-across-boundaries.html: Added.
  • fast/blockflow/block-formatting-context-expected.txt: Added.
  • fast/blockflow/block-formatting-context.html: Added.
  • fast/blockflow/percentage-padding.html:
  • fast/blockflow/relative-positioning-percentages-expected.txt: Added.
  • fast/blockflow/relative-positioning-percentages.html: Added.
  • fast/css/logical-property-resolution-expected.txt:
12:41 PM Changeset in webkit [68416] by kinuko@chromium.org
  • 2 edits in trunk/LayoutTests

2010-09-27 Kinuko Yasuda <kinuko@chromium.org>

Unreviewed, updating chromium test_expectations for passing tests.

  • platform/chromium/test_expectations.txt:
12:35 PM Changeset in webkit [68415] by commit-queue@webkit.org
  • 8 edits in trunk

2010-09-27 Mario Sanchez Prada <msanchez@igalia.com>

Reviewed by Chris Fleizach.

[Gtk] Adjust atk_text_get_text_at_offset to account for bullets/numbers in list items
https://bugs.webkit.org/show_bug.cgi?id=45381

Ensure list markers are consistently used in the Atk wrapper.

This patch does two things (both needed to fix the bug): It
improves the way list items markers are exposed through the Atk
Wrapper (by exposing the exact text in the marker, including the
marker suffix, if any) and makes sure the marker is consistently
considered and treated in those methods of the AtkText interface
that would need it (like atk_text_get_character_count or
atk_text_get_run_attributes, for instance).

  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (textForObject):

Append/prepend list marker when needed.

(webkit_accessible_text_get_text):

Use the new function markerTextWithSuffix() to expose a more
accurate value.

(accessibilityObjectLength):

Consider list items marker to return the length of an object,
if needed. Also, added some extra checks.

(webkit_accessible_text_get_character_count):

Just delegate on accessibilityObjectLength, to make it
cleaner and more consistent.

  • rendering/RenderListItem.cpp: (WebCore::RenderListItem::markerTextWithSuffix):

New public function to return a single string with the
marker associated to the item and its suffix, considering
text direction (LTR or RTL).

  • rendering/RenderListItem.h:
  • rendering/RenderListMarker.cpp: (WebCore::RenderListMarker::suffix):

New public function to return a String with the suffix
associated to the marker.

  • rendering/RenderListMarker.h:

2010-09-27 Mario Sanchez Prada <msanchez@igalia.com>

Reviewed by Chris Fleizach.

[Gtk] Adjust atk_text_get_text_at_offset to account for bullets/numbers in list items
https://bugs.webkit.org/show_bug.cgi?id=45381

Updated test to match the new exposure of list item markers.

Also, added some extra assertions in that test to make sure the
accessible objects associated to the items implement AtkText.

  • tests/testatk.c: (testWebkitAtkListsOfItems): (main):
12:18 PM Changeset in webkit [68414] by andersca@apple.com
  • 4 edits in trunk/JavaScriptCore

Add WTF_MAKE_NONCOPYABLE macro
https://bugs.webkit.org/show_bug.cgi?id=46589

Reviewed by Alexey Proskuryakov and Adam Barth.

Going forward, we'd like to get rid of the Noncopyable and FastAllocBase classes. The
reason for this is that the Itanium C++ ABI states that no empty classes of the same type
can be laid out at the same offset in the class. This can result in objects getting larger
which leads to memory regressions. (One example of this is the String class which grew by
sizeof(void*) when both its base class and its first member variable inherited indirectly
from FastAllocBase).

  • wtf/Noncopyable.h:

Add a WTF_MAKE_NONCOPYABLE macro and get rid of NoncopyableCustomAllocated.

  • runtime/JSCell.h:
  • wtf/RefCounted.h:

Don't inherit from NoncopyableCustomAllocated. Instead, use WTF_MAKE_NONCOPYABLE.

12:17 PM Changeset in webkit [68413] by andersca@apple.com
  • 3 edits
    2 adds in trunk/WebKit2

Add PluginProxy class
https://bugs.webkit.org/show_bug.cgi?id=46586

Reviewed by Sam Weinig.

  • WebKit2.xcodeproj/project.pbxproj:

Add files.

  • WebProcess/Plugins/PluginProxy.cpp: Added.
  • WebProcess/Plugins/PluginProxy.h: Added.
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::createPlugin):
Create a PluginProxy wrapper.

12:16 PM Changeset in webkit [68412] by commit-queue@webkit.org
  • 3 edits in trunk/WebCore

2010-09-27 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r68389.
http://trac.webkit.org/changeset/68389
https://bugs.webkit.org/show_bug.cgi?id=46637

test_shell is crashing on chromium Win (Requested by loislo on
#webkit).

  • inspector/InspectorTimelineAgent.cpp: (WebCore::InspectorTimelineAgent::InspectorTimelineAgent): (WebCore::InspectorTimelineAgent::pushGCEventRecords): (WebCore::InspectorTimelineAgent::didGC): (WebCore::InspectorTimelineAgent::~InspectorTimelineAgent): (WebCore::InspectorTimelineAgent::willCallFunction): (WebCore::InspectorTimelineAgent::didCallFunction): (WebCore::InspectorTimelineAgent::willDispatchEvent): (WebCore::InspectorTimelineAgent::didDispatchEvent): (WebCore::InspectorTimelineAgent::willLayout): (WebCore::InspectorTimelineAgent::didLayout): (WebCore::InspectorTimelineAgent::willRecalculateStyle): (WebCore::InspectorTimelineAgent::didRecalculateStyle): (WebCore::InspectorTimelineAgent::willPaint): (WebCore::InspectorTimelineAgent::didPaint): (WebCore::InspectorTimelineAgent::willWriteHTML): (WebCore::InspectorTimelineAgent::didWriteHTML): (WebCore::InspectorTimelineAgent::didInstallTimer): (WebCore::InspectorTimelineAgent::didRemoveTimer): (WebCore::InspectorTimelineAgent::willFireTimer): (WebCore::InspectorTimelineAgent::didFireTimer): (WebCore::InspectorTimelineAgent::willChangeXHRReadyState): (WebCore::InspectorTimelineAgent::didChangeXHRReadyState): (WebCore::InspectorTimelineAgent::willLoadXHR): (WebCore::InspectorTimelineAgent::didLoadXHR): (WebCore::InspectorTimelineAgent::willEvaluateScript): (WebCore::InspectorTimelineAgent::didEvaluateScript): (WebCore::InspectorTimelineAgent::didScheduleResourceRequest): (WebCore::InspectorTimelineAgent::willSendResourceRequest): (WebCore::InspectorTimelineAgent::willReceiveResourceData): (WebCore::InspectorTimelineAgent::didReceiveResourceData): (WebCore::InspectorTimelineAgent::willReceiveResourceResponse): (WebCore::InspectorTimelineAgent::didReceiveResourceResponse): (WebCore::InspectorTimelineAgent::didFinishLoadingResource): (WebCore::InspectorTimelineAgent::didMarkTimeline): (WebCore::InspectorTimelineAgent::didMarkDOMContentEvent): (WebCore::InspectorTimelineAgent::didMarkLoadEvent): (WebCore::InspectorTimelineAgent::reset): (WebCore::InspectorTimelineAgent::resetFrontendProxyObject): (WebCore::InspectorTimelineAgent::addRecordToTimeline): (WebCore::InspectorTimelineAgent::setHeapSizeStatistic): (WebCore::InspectorTimelineAgent::didCompleteCurrentRecord): (WebCore::InspectorTimelineAgent::pushCurrentRecord):
  • inspector/InspectorTimelineAgent.h: (WebCore::InspectorTimelineAgent::TimelineRecordEntry::TimelineRecordEntry): (WebCore::InspectorTimelineAgent::GCEvent::GCEvent):
12:05 PM Changeset in webkit [68411] by kinuko@chromium.org
  • 10 edits in trunk

2010-09-27 Kinuko Yasuda <kinuko@chromium.org>

Reviewed by Adam Barth.

[Cleanup] Add create method to FileSystemCallbacks to get rid of naked new's
https://bugs.webkit.org/show_bug.cgi?id=46561

Also cleanup the callbacks layering to pass AsyncFileSystemCallbacks
object to LocalFileSystem::requestFileSystem (rather than
FileSystemCallback and ErrorCallback) so that all the callbacks class
we pass from WebCore to WebKit/chromium/src will be
AsyncFileSystemCallbacks.

  • src/LocalFileSystemChromium.cpp: (WebCore::LocalFileSystem::requestFileSystem): Changed to take AsyncFileSystemCallbacks as (a) callback argument(s).

2010-09-27 Kinuko Yasuda <kinuko@google.com>

Reviewed by Adam Barth.

[Cleanup] Add create method to FileSystemCallbacks to get rid of naked new's
https://bugs.webkit.org/show_bug.cgi?id=46561

Also cleanup the callbacks layering to pass AsyncFileSystemCallbacks
object to LocalFileSystem::requestFileSystem (rather than
FileSystemCallback and ErrorCallback) so that all the callbacks class
we pass from WebCore to WebKit/chromium/src will be
AsyncFileSystemCallbacks.

No new tests; this patch is only for cleanup and there should be no functionality changes.

  • fileapi/DOMFileSystem.cpp: (WebCore::DOMFileSystem::getMetadata): (WebCore::DOMFileSystem::move): (WebCore::DOMFileSystem::copy): (WebCore::DOMFileSystem::remove): (WebCore::DOMFileSystem::getParent): (WebCore::DOMFileSystem::getFile): (WebCore::DOMFileSystem::getDirectory): (WebCore::DOMFileSystem::createWriter): (WebCore::DOMFileSystem::readDirectory):
  • fileapi/FileSystemCallbacks.cpp: (WebCore::EntryCallbacks::create): Added. (WebCore::EntriesCallbacks::create): Added. (WebCore::FileSystemCallbacks::create): Added. (WebCore::MetadataCallbacks::create): Added. (WebCore::FileWriterCallbacks::create): Added. (WebCore::VoidCallbacks::create): Added.
  • fileapi/FileSystemCallbacks.h:
  • fileapi/LocalFileSystem.cpp: (WebCore::openFileSystem): (WebCore::LocalFileSystem::requestFileSystem): Changed to take AsyncFileSystemCallbacks as (a) callback argument(s).
  • fileapi/LocalFileSystem.h:
  • page/DOMWindow.cpp: (WebCore::DOMWindow::requestFileSystem): Made a corresponding change to LocalFileSystem::requestFileSystem.
  • workers/WorkerContext.cpp: (WebCore::WorkerContext::requestFileSystem): Made a corresponding change to LocalFileSystem::requestFileSystem.
11:48 AM Changeset in webkit [68410] by tony@chromium.org
  • 2 edits
    2 deletes in trunk/WebKit/chromium

2010-09-24 Tony Chang <tony@chromium.org>

Reviewed by Kent Tamura.

[chromium] remove unused gtk WebScreenInfoFactory
https://bugs.webkit.org/show_bug.cgi?id=46526

AFAICT these files aren't referenced in code or by gyp.

  • WebKit.gyp: Remove duplicate filename.
  • public/gtk/WebScreenInfoFactory.h: Removed.
  • src/gtk/WebScreenInfoFactory.cpp: Removed.
11:26 AM Changeset in webkit [68409] by Csaba Osztrogonác
  • 2 edits in trunk/WebKit2

2010-09-27 Andras Becsi <abecsi@webkit.org>

Reviewed by Csaba Osztrogonác.

[Qt] Make generate-forwarding-headers.pl aware of moved headers
https://bugs.webkit.org/show_bug.cgi?id=46621

  • generate-forwarding-headers.pl:
11:18 AM Changeset in webkit [68408] by inferno@chromium.org
  • 4 edits
    2 adds in trunk

2010-09-27 Abhishek Arya <inferno@chromium.org>

Reviewed by Dave Hyatt.

Fix memory safety issue during positioning list marker as a result of assuming
that list item's parent can always be casted to a RenderBox. The display of the parent
can be manipluated using css as Inline which causes a bad cast.

https://bugs.webkit.org/show_bug.cgi?id=46384

Test: fast/lists/parent-box-not-box-crash.html

  • rendering/RenderListItem.cpp: (WebCore::RenderListItem::positionListMarker):
  • rendering/RenderListMarker.cpp: (WebCore::RenderListMarker::layout):

2010-09-27 Abhishek Arya <inferno@chromium.org>

Reviewed by Dave Hyatt.

Tests that positioning the list marker whose parent (child div) is not
a box (inline because of the run-in style) does not result in crash.
https://bugs.webkit.org/show_bug.cgi?id=46384

  • fast/lists/parent-box-not-box-crash-expected.txt: Added.
  • fast/lists/parent-box-not-box-crash.html: Added.
11:11 AM Changeset in webkit [68407] by caseq@chromium.org
  • 2 edits in trunk/LayoutTests

2010-09-27 Andrey Kosyakov <caseq@chromium.org>

Unreviewed.
Marked svg/custom/clip-path-referencing-use2.svg & svg/custom/circular-marker-reference-4.svg flaky under linux.

  • platform/chromium/test_expectations.txt:
11:00 AM Changeset in webkit [68406] by Martin Robinson
  • 737 edits
    5 adds in trunk

2010-09-27 Martin Robinson <mrobinson@igalia.com>

Reviewed by Gustavo Noronha Silva.

[GTK] Wrong font instantiated from an unknown font family
https://bugs.webkit.org/show_bug.cgi?id=36548

Rebaseline tests which have new results now that they use different fonts.

  • platform/gtk/animations/animation-drt-api-expected.txt:
  • platform/gtk/animations/animation-drt-api-multiple-keyframes-expected.txt:
  • platform/gtk/animations/state-at-end-event-expected.txt:
  • platform/gtk/css1/basic/class_as_selector-expected.txt:
  • platform/gtk/css1/basic/comments-expected.txt:
  • platform/gtk/css1/basic/containment-expected.txt:
  • platform/gtk/css1/basic/contextual_selectors-expected.txt:
  • platform/gtk/css1/basic/grouping-expected.txt:
  • platform/gtk/css1/basic/id_as_selector-expected.txt:
  • platform/gtk/css1/basic/inheritance-expected.txt:
  • platform/gtk/css1/box_properties/border-expected.txt:
  • platform/gtk/css1/box_properties/border_bottom-expected.txt:
  • platform/gtk/css1/box_properties/border_bottom_inline-expected.txt:
  • platform/gtk/css1/box_properties/border_bottom_width-expected.txt:
  • platform/gtk/css1/box_properties/border_bottom_width_inline-expected.txt:
  • platform/gtk/css1/box_properties/border_color-expected.txt:
  • platform/gtk/css1/box_properties/border_color_inline-expected.txt:
  • platform/gtk/css1/box_properties/border_inline-expected.txt:
  • platform/gtk/css1/box_properties/border_left-expected.txt:
  • platform/gtk/css1/box_properties/border_left_inline-expected.txt:
  • platform/gtk/css1/box_properties/border_left_width-expected.txt:
  • platform/gtk/css1/box_properties/border_left_width_inline-expected.txt:
  • platform/gtk/css1/box_properties/border_right-expected.txt:
  • platform/gtk/css1/box_properties/border_right_inline-expected.txt:
  • platform/gtk/css1/box_properties/border_right_width-expected.txt:
  • platform/gtk/css1/box_properties/border_right_width_inline-expected.txt:
  • platform/gtk/css1/box_properties/border_style-expected.txt:
  • platform/gtk/css1/box_properties/border_style_inline-expected.txt:
  • platform/gtk/css1/box_properties/border_top-expected.txt:
  • platform/gtk/css1/box_properties/border_top_inline-expected.txt:
  • platform/gtk/css1/box_properties/border_top_width-expected.txt:
  • platform/gtk/css1/box_properties/border_top_width_inline-expected.txt:
  • platform/gtk/css1/box_properties/border_width-expected.txt:
  • platform/gtk/css1/box_properties/border_width_inline-expected.txt:
  • platform/gtk/css1/box_properties/clear-expected.txt:
  • platform/gtk/css1/box_properties/clear_float-expected.txt:
  • platform/gtk/css1/box_properties/float-expected.txt:
  • platform/gtk/css1/box_properties/float_elements_in_series-expected.txt:
  • platform/gtk/css1/box_properties/float_margin-expected.txt:
  • platform/gtk/css1/box_properties/float_on_text_elements-expected.txt:
  • platform/gtk/css1/box_properties/height-expected.txt:
  • platform/gtk/css1/box_properties/margin-expected.txt:
  • platform/gtk/css1/box_properties/margin_bottom-expected.txt:
  • platform/gtk/css1/box_properties/margin_bottom_inline-expected.txt:
  • platform/gtk/css1/box_properties/margin_inline-expected.txt:
  • platform/gtk/css1/box_properties/margin_left-expected.txt:
  • platform/gtk/css1/box_properties/margin_left_inline-expected.txt:
  • platform/gtk/css1/box_properties/margin_right-expected.txt:
  • platform/gtk/css1/box_properties/margin_right_inline-expected.txt:
  • platform/gtk/css1/box_properties/margin_top-expected.txt:
  • platform/gtk/css1/box_properties/margin_top_inline-expected.txt:
  • platform/gtk/css1/box_properties/padding-expected.txt:
  • platform/gtk/css1/box_properties/padding_bottom-expected.txt:
  • platform/gtk/css1/box_properties/padding_bottom_inline-expected.txt:
  • platform/gtk/css1/box_properties/padding_inline-expected.txt:
  • platform/gtk/css1/box_properties/padding_left-expected.txt:
  • platform/gtk/css1/box_properties/padding_left_inline-expected.txt:
  • platform/gtk/css1/box_properties/padding_right-expected.txt:
  • platform/gtk/css1/box_properties/padding_right_inline-expected.txt:
  • platform/gtk/css1/box_properties/padding_top-expected.txt:
  • platform/gtk/css1/box_properties/padding_top_inline-expected.txt:
  • platform/gtk/css1/box_properties/width-expected.txt:
  • platform/gtk/css1/cascade/cascade_order-expected.txt:
  • platform/gtk/css1/cascade/important-expected.txt:
  • platform/gtk/css1/classification/display-expected.txt:
  • platform/gtk/css1/classification/list_style-expected.txt:
  • platform/gtk/css1/classification/list_style_image-expected.txt:
  • platform/gtk/css1/classification/list_style_position-expected.txt:
  • platform/gtk/css1/classification/list_style_type-expected.txt:
  • platform/gtk/css1/classification/white_space-expected.txt:
  • platform/gtk/css1/color_and_background/background-expected.txt:
  • platform/gtk/css1/color_and_background/background_attachment-expected.txt:
  • platform/gtk/css1/color_and_background/background_color-expected.txt:
  • platform/gtk/css1/color_and_background/background_image-expected.txt:
  • platform/gtk/css1/color_and_background/background_position-expected.txt:
  • platform/gtk/css1/color_and_background/background_repeat-expected.txt:
  • platform/gtk/css1/color_and_background/color-expected.txt:
  • platform/gtk/css1/conformance/forward_compatible_parsing-expected.txt:
  • platform/gtk/css1/font_properties/font-expected.txt:
  • platform/gtk/css1/font_properties/font_family-expected.txt:
  • platform/gtk/css1/font_properties/font_size-expected.txt:
  • platform/gtk/css1/font_properties/font_style-expected.txt:
  • platform/gtk/css1/font_properties/font_variant-expected.txt:
  • platform/gtk/css1/font_properties/font_weight-expected.txt:
  • platform/gtk/css1/formatting_model/canvas-expected.txt:
  • platform/gtk/css1/formatting_model/floating_elements-expected.txt:
  • platform/gtk/css1/formatting_model/height_of_lines-expected.txt:
  • platform/gtk/css1/formatting_model/horizontal_formatting-expected.txt:
  • platform/gtk/css1/formatting_model/inline_elements-expected.txt:
  • platform/gtk/css1/formatting_model/replaced_elements-expected.txt:
  • platform/gtk/css1/formatting_model/vertical_formatting-expected.txt:
  • platform/gtk/css1/pseudo/anchor-expected.txt:
  • platform/gtk/css1/pseudo/firstletter-expected.txt:
  • platform/gtk/css1/pseudo/firstline-expected.txt:
  • platform/gtk/css1/pseudo/multiple_pseudo_elements-expected.txt:
  • platform/gtk/css1/pseudo/pseudo_elements_in_selectors-expected.txt:
  • platform/gtk/css1/text_properties/letter_spacing-expected.txt:
  • platform/gtk/css1/text_properties/line_height-expected.txt:
  • platform/gtk/css1/text_properties/text_align-expected.txt:
  • platform/gtk/css1/text_properties/text_decoration-expected.txt:
  • platform/gtk/css1/text_properties/text_indent-expected.txt:
  • platform/gtk/css1/text_properties/text_transform-expected.txt:
  • platform/gtk/css1/text_properties/vertical_align-expected.txt:
  • platform/gtk/css1/text_properties/word_spacing-expected.txt:
  • platform/gtk/css1/units/color_units-expected.txt:
  • platform/gtk/css1/units/length_units-expected.txt:
  • platform/gtk/css1/units/percentage_units-expected.txt:
  • platform/gtk/css1/units/urls-expected.txt:
  • platform/gtk/css3/css3-modsel-33-expected.txt:
  • platform/gtk/css3/css3-modsel-35-expected.txt:
  • platform/gtk/css3/css3-modsel-36-expected.txt:
  • platform/gtk/css3/css3-modsel-37-expected.txt:
  • platform/gtk/dom/xhtml/level3/core/documentgetinputencoding03-expected.txt:
  • platform/gtk/dom/xhtml/level3/core/entitygetinputencoding02-expected.txt:
  • platform/gtk/dom/xhtml/level3/core/entitygetxmlversion02-expected.txt:
  • platform/gtk/dom/xhtml/level3/core/nodegetbaseuri05-expected.txt:
  • platform/gtk/dom/xhtml/level3/core/nodegetbaseuri07-expected.txt:
  • platform/gtk/dom/xhtml/level3/core/nodegetbaseuri09-expected.txt:
  • platform/gtk/dom/xhtml/level3/core/nodegetbaseuri10-expected.txt:
  • platform/gtk/dom/xhtml/level3/core/nodegetbaseuri11-expected.txt:
  • platform/gtk/dom/xhtml/level3/core/nodegetbaseuri15-expected.txt:
  • platform/gtk/dom/xhtml/level3/core/nodegetbaseuri17-expected.txt:
  • platform/gtk/dom/xhtml/level3/core/nodegetbaseuri18-expected.txt:
  • platform/gtk/dom/xhtml/level3/core/nodelookupnamespaceuri01-expected.txt:
  • platform/gtk/dom/xhtml/level3/core/nodelookupprefix19-expected.txt:
  • platform/gtk/editing/deleting/4922367-expected.txt:
  • platform/gtk/editing/deleting/5026848-1-expected.txt:
  • platform/gtk/editing/deleting/5026848-2-expected.txt:
  • platform/gtk/editing/deleting/5026848-3-expected.txt:
  • platform/gtk/editing/deleting/5032066-expected.txt:
  • platform/gtk/editing/deleting/5091898-expected.txt:
  • platform/gtk/editing/deleting/5099303-expected.txt:
  • platform/gtk/editing/deleting/5115601-expected.txt:
  • platform/gtk/editing/deleting/5126166-expected.txt:
  • platform/gtk/editing/deleting/5156801-2-expected.txt:
  • platform/gtk/editing/deleting/5206311-1-expected.txt:
  • platform/gtk/editing/deleting/5206311-2-expected.txt:
  • platform/gtk/editing/deleting/5272440-expected.txt:
  • platform/gtk/editing/deleting/5300379-expected.txt:
  • platform/gtk/editing/deleting/5369009-expected.txt:
  • platform/gtk/editing/deleting/5390681-2-expected.txt:
  • platform/gtk/editing/deleting/5390681-expected.txt:
  • platform/gtk/editing/deleting/5433862-2-expected.txt:
  • platform/gtk/editing/deleting/5483370-expected.txt:
  • platform/gtk/editing/deleting/collapse-whitespace-3587601-fix-expected.txt:
  • platform/gtk/editing/deleting/delete-3608430-fix-expected.txt:
  • platform/gtk/editing/deleting/delete-3608445-fix-expected.txt:
  • platform/gtk/editing/deleting/delete-3608462-fix-expected.txt:
  • platform/gtk/editing/deleting/delete-3775172-fix-expected.txt:
  • platform/gtk/editing/deleting/delete-3800834-fix-expected.txt:
  • platform/gtk/editing/deleting/delete-3959464-fix-expected.txt:
  • platform/gtk/editing/deleting/delete-and-undo-expected.txt:
  • platform/gtk/editing/deleting/delete-block-contents-001-expected.txt:
  • platform/gtk/editing/deleting/delete-block-contents-002-expected.txt:
  • platform/gtk/editing/deleting/delete-block-contents-003-expected.txt:
  • platform/gtk/editing/deleting/delete-block-merge-contents-010-expected.txt:
  • platform/gtk/editing/deleting/delete-block-merge-contents-012-expected.txt:
  • platform/gtk/editing/deleting/delete-block-merge-contents-013-expected.txt:
  • platform/gtk/editing/deleting/delete-block-merge-contents-014-expected.txt:
  • platform/gtk/editing/deleting/delete-block-merge-contents-015-expected.txt:
  • platform/gtk/editing/deleting/delete-block-merge-contents-016-expected.txt:
  • platform/gtk/editing/deleting/delete-block-merge-contents-017-expected.txt:
  • platform/gtk/editing/deleting/delete-br-001-expected.txt:
  • platform/gtk/editing/deleting/delete-br-002-expected.txt:
  • platform/gtk/editing/deleting/delete-br-003-expected.txt:
  • platform/gtk/editing/deleting/delete-br-004-expected.txt:
  • platform/gtk/editing/deleting/delete-br-005-expected.txt:
  • platform/gtk/editing/deleting/delete-br-006-expected.txt:
  • platform/gtk/editing/deleting/delete-br-007-expected.txt:
  • platform/gtk/editing/deleting/delete-br-010-expected.txt:
  • platform/gtk/editing/deleting/delete-br-013-expected.txt:
  • platform/gtk/editing/deleting/delete-by-word-001-expected.txt:
  • platform/gtk/editing/deleting/delete-contiguous-ws-001-expected.txt:
  • platform/gtk/editing/deleting/delete-image-004-expected.txt:
  • platform/gtk/editing/deleting/delete-leading-ws-001-expected.txt:
  • platform/gtk/editing/deleting/delete-line-001-expected.txt:
  • platform/gtk/editing/deleting/delete-line-002-expected.txt:
  • platform/gtk/editing/deleting/delete-line-005-expected.txt:
  • platform/gtk/editing/deleting/delete-line-006-expected.txt:
  • platform/gtk/editing/deleting/delete-line-007-expected.txt:
  • platform/gtk/editing/deleting/delete-line-008-expected.txt:
  • platform/gtk/editing/deleting/delete-line-009-expected.txt:
  • platform/gtk/editing/deleting/delete-line-010-expected.txt:
  • platform/gtk/editing/deleting/delete-line-011-expected.txt:
  • platform/gtk/editing/deleting/delete-line-012-expected.txt:
  • platform/gtk/editing/deleting/delete-line-013-expected.txt:
  • platform/gtk/editing/deleting/delete-line-014-expected.txt:
  • platform/gtk/editing/deleting/delete-line-end-ws-001-expected.txt:
  • platform/gtk/editing/deleting/delete-line-end-ws-002-expected.txt:
  • platform/gtk/editing/deleting/delete-listitem-001-expected.txt:
  • platform/gtk/editing/deleting/delete-listitem-002-expected.txt:
  • platform/gtk/editing/deleting/delete-select-all-002-expected.txt:
  • platform/gtk/editing/deleting/delete-tab-002-expected.txt:
  • platform/gtk/editing/deleting/delete-tab-004-expected.txt:
  • platform/gtk/editing/deleting/delete-to-end-of-paragraph-expected.txt:
  • platform/gtk/editing/deleting/delete-to-select-table-expected.txt:
  • platform/gtk/editing/deleting/delete-trailing-ws-002-expected.txt:
  • platform/gtk/editing/deleting/delete-ws-fixup-001-expected.txt:
  • platform/gtk/editing/deleting/delete-ws-fixup-002-expected.txt:
  • platform/gtk/editing/deleting/forward-delete-expected.txt:
  • platform/gtk/editing/deleting/merge-whitespace-pre-expected.txt:
  • platform/gtk/editing/deleting/move-nodes-001-expected.txt:
  • platform/gtk/editing/deleting/smart-delete-003-expected.txt:
  • platform/gtk/editing/deleting/smart-delete-004-expected.txt:
  • platform/gtk/editing/deleting/type-delete-after-quote-expected.txt:
  • platform/gtk/editing/execCommand/4580583-1-expected.txt:
  • platform/gtk/editing/execCommand/4580583-2-expected.txt:
  • platform/gtk/editing/execCommand/4747450-expected.txt:
  • platform/gtk/editing/execCommand/4786404-1-expected.txt:
  • platform/gtk/editing/execCommand/4786404-2-expected.txt:
  • platform/gtk/editing/execCommand/4916402-expected.txt:
  • platform/gtk/editing/execCommand/4916541-expected.txt:
  • platform/gtk/editing/execCommand/4920488-expected.txt:
  • platform/gtk/editing/execCommand/4920742-1-expected.txt:
  • platform/gtk/editing/execCommand/4924441-expected.txt:
  • platform/gtk/editing/execCommand/5049671-expected.txt:
  • platform/gtk/editing/execCommand/5080333-1-expected.txt:
  • platform/gtk/editing/execCommand/5080333-2-expected.txt:
  • platform/gtk/editing/execCommand/5136770-expected.txt:
  • platform/gtk/editing/execCommand/5138441-expected.txt:
  • platform/gtk/editing/execCommand/5142012-1-expected.txt:
  • platform/gtk/editing/execCommand/5142012-2-expected.txt:
  • platform/gtk/editing/execCommand/5190926-expected.txt:
  • platform/gtk/editing/execCommand/5481523-expected.txt:
  • platform/gtk/editing/execCommand/5482023-expected.txt:
  • platform/gtk/editing/execCommand/5569741-expected.txt:
  • platform/gtk/editing/execCommand/5573879-expected.txt:
  • platform/gtk/editing/inserting/12882-expected.txt:
  • platform/gtk/editing/inserting/4840662-expected.txt:
  • platform/gtk/editing/inserting/4875189-1-expected.txt:
  • platform/gtk/editing/inserting/4875189-2-expected.txt:
  • platform/gtk/editing/inserting/4959067-expected.txt:
  • platform/gtk/editing/inserting/4960120-2-expected.txt:
  • platform/gtk/editing/inserting/5002441-expected.txt:
  • platform/gtk/editing/inserting/5058163-1-expected.txt:
  • platform/gtk/editing/inserting/5058163-2-expected.txt:
  • platform/gtk/editing/inserting/5156401-2-expected.txt:
  • platform/gtk/editing/inserting/5418891-expected.txt:
  • platform/gtk/editing/inserting/5510537-expected.txt:
  • platform/gtk/editing/inserting/5549929-2-expected.txt:
  • platform/gtk/editing/inserting/5549929-3-expected.txt:
  • platform/gtk/editing/inserting/6703873-expected.txt:
  • platform/gtk/editing/inserting/editable-inline-element-expected.txt:
  • platform/gtk/editing/inserting/edited-whitespace-1-expected.txt:
  • platform/gtk/editing/inserting/insert-3654864-fix-expected.txt:
  • platform/gtk/editing/inserting/insert-3775316-fix-expected.txt:
  • platform/gtk/editing/inserting/insert-3800346-fix-expected.txt:
  • platform/gtk/editing/inserting/insert-3851164-fix-expected.txt:
  • platform/gtk/editing/inserting/insert-3907422-fix-expected.txt:
  • platform/gtk/editing/inserting/insert-after-delete-001-expected.txt:
  • platform/gtk/editing/inserting/insert-br-005-expected.txt:
  • platform/gtk/editing/inserting/insert-div-001-expected.txt:
  • platform/gtk/editing/inserting/insert-div-002-expected.txt:
  • platform/gtk/editing/inserting/insert-div-003-expected.txt:
  • platform/gtk/editing/inserting/insert-div-004-expected.txt:
  • platform/gtk/editing/inserting/insert-div-005-expected.txt:
  • platform/gtk/editing/inserting/insert-div-009-expected.txt:
  • platform/gtk/editing/inserting/insert-div-024-expected.txt:
  • platform/gtk/editing/inserting/insert-space-in-empty-doc-expected.txt:
  • platform/gtk/editing/inserting/insert-text-with-newlines-expected.txt:
  • platform/gtk/editing/inserting/redo-expected.txt:
  • platform/gtk/editing/inserting/typing-001-expected.txt:
  • platform/gtk/editing/inserting/typing-002-expected.txt:
  • platform/gtk/editing/inserting/typing-003-expected.txt:
  • platform/gtk/editing/inserting/typing-around-br-001-expected.txt:
  • platform/gtk/editing/inserting/typing-around-image-001-expected.txt:
  • platform/gtk/editing/pasteboard/4076267-2-expected.txt:
  • platform/gtk/editing/pasteboard/4076267-3-expected.txt:
  • platform/gtk/editing/pasteboard/4076267-expected.txt:
  • platform/gtk/editing/pasteboard/5032095-expected.txt:
  • platform/gtk/editing/pasteboard/5071074-2-expected.txt:
  • platform/gtk/editing/pasteboard/5075944-3-expected.txt:
  • platform/gtk/editing/pasteboard/5089327-expected.txt:
  • platform/gtk/editing/pasteboard/5134759-expected.txt:
  • platform/gtk/editing/pasteboard/5156401-1-expected.txt:
  • platform/gtk/editing/pasteboard/5387578-expected.txt:
  • platform/gtk/editing/pasteboard/5483567-expected.txt:
  • platform/gtk/editing/pasteboard/7955-expected.txt:
  • platform/gtk/editing/pasteboard/cut-text-001-expected.txt:
  • platform/gtk/editing/pasteboard/drag-drop-dead-frame-expected.txt:
  • platform/gtk/editing/pasteboard/drag-drop-modifies-page-expected.txt:
  • platform/gtk/editing/pasteboard/drag-image-to-contenteditable-in-iframe-expected.txt:
  • platform/gtk/editing/pasteboard/drag-selected-image-to-contenteditable-expected.txt:
  • platform/gtk/editing/pasteboard/drop-text-without-selection-expected.txt:
  • platform/gtk/editing/pasteboard/innerText-inline-table-expected.txt:
  • platform/gtk/editing/pasteboard/paste-blockquote-1-expected.txt:
  • platform/gtk/editing/pasteboard/paste-blockquote-2-expected.txt:
  • platform/gtk/editing/pasteboard/paste-blockquote-3-expected.txt:
  • platform/gtk/editing/pasteboard/paste-blockquote-after-blockquote-expected.txt:
  • platform/gtk/editing/pasteboard/paste-blockquote-into-blockquote-2-expected.txt:
  • platform/gtk/editing/pasteboard/paste-blockquote-into-blockquote-3-expected.txt:
  • platform/gtk/editing/pasteboard/paste-blockquote-into-blockquote-4-expected.txt:
  • platform/gtk/editing/pasteboard/paste-blockquote-into-blockquote-expected.txt:
  • platform/gtk/editing/pasteboard/paste-table-001-expected.txt:
  • platform/gtk/editing/pasteboard/paste-text-001-expected.txt:
  • platform/gtk/editing/pasteboard/paste-text-002-expected.txt:
  • platform/gtk/editing/pasteboard/paste-text-003-expected.txt:
  • platform/gtk/editing/pasteboard/paste-text-004-expected.txt:
  • platform/gtk/editing/pasteboard/paste-text-005-expected.txt:
  • platform/gtk/editing/pasteboard/paste-text-006-expected.txt:
  • platform/gtk/editing/pasteboard/paste-text-007-expected.txt:
  • platform/gtk/editing/pasteboard/paste-text-008-expected.txt:
  • platform/gtk/editing/pasteboard/paste-text-009-expected.txt:
  • platform/gtk/editing/pasteboard/paste-text-010-expected.txt:
  • platform/gtk/editing/pasteboard/paste-text-015-expected.txt:
  • platform/gtk/editing/pasteboard/paste-xml-expected.txt:
  • platform/gtk/editing/pasteboard/subframe-dragndrop-1-expected.txt:
  • platform/gtk/editing/selection/13804-expected.txt:
  • platform/gtk/editing/selection/4818145-expected.txt:
  • platform/gtk/editing/selection/4866671-expected.txt:
  • platform/gtk/editing/selection/4889598-expected.txt:
  • platform/gtk/editing/selection/4895428-2-expected.txt:
  • platform/gtk/editing/selection/4960116-expected.txt:
  • platform/gtk/editing/selection/4960137-expected.txt:
  • platform/gtk/editing/selection/4983858-expected.txt:
  • platform/gtk/editing/selection/5007143-2-expected.txt:
  • platform/gtk/editing/selection/5007143-expected.txt:
  • platform/gtk/editing/selection/5057506-2-expected.txt:
  • platform/gtk/editing/selection/5057506-expected.txt:
  • platform/gtk/editing/selection/5076323-1-expected.txt:
  • platform/gtk/editing/selection/5076323-2-expected.txt:
  • platform/gtk/editing/selection/5076323-3-expected.txt:
  • platform/gtk/editing/selection/5081257-1-expected.txt:
  • platform/gtk/editing/selection/5081257-2-expected.txt:
  • platform/gtk/editing/selection/5099303-expected.txt:
  • platform/gtk/editing/selection/5109817-expected.txt:
  • platform/gtk/editing/selection/5131716-1-expected.txt:
  • platform/gtk/editing/selection/5131716-2-expected.txt:
  • platform/gtk/editing/selection/5131716-3-expected.txt:
  • platform/gtk/editing/selection/5131716-4-expected.txt:
  • platform/gtk/editing/selection/5232159-expected.txt:
  • platform/gtk/editing/selection/5234383-1-expected.txt:
  • platform/gtk/editing/selection/5234383-2-expected.txt:
  • platform/gtk/editing/selection/5333725-expected.txt:
  • platform/gtk/editing/selection/addRange-expected.txt:
  • platform/gtk/editing/selection/drag-in-iframe-expected.txt:
  • platform/gtk/editing/selection/drag-select-1-expected.txt:
  • platform/gtk/editing/selection/drag-text-delay-expected.txt:
  • platform/gtk/editing/selection/drag-to-contenteditable-iframe-expected.txt:
  • platform/gtk/editing/selection/extend-by-character-002-expected.txt:
  • platform/gtk/editing/selection/extend-by-character-003-expected.txt:
  • platform/gtk/editing/selection/extend-by-character-004-expected.txt:
  • platform/gtk/editing/selection/extend-by-character-005-expected.txt:
  • platform/gtk/editing/selection/fake-drag-expected.txt:
  • platform/gtk/editing/selection/iframe-expected.txt:
  • platform/gtk/editing/selection/inline-table-expected.txt:
  • platform/gtk/editing/selection/mixed-editability-6-expected.txt:
  • platform/gtk/editing/selection/mixed-editability-7-expected.txt:
  • platform/gtk/editing/selection/move-backwords-by-word-001-expected.txt:
  • platform/gtk/editing/selection/move-between-blocks-no-001-expected.txt:
  • platform/gtk/editing/selection/move-between-blocks-yes-001-expected.txt:
  • platform/gtk/editing/selection/move-by-character-001-expected.txt:
  • platform/gtk/editing/selection/move-by-character-002-expected.txt:
  • platform/gtk/editing/selection/move-by-character-003-expected.txt:
  • platform/gtk/editing/selection/move-by-character-004-expected.txt:
  • platform/gtk/editing/selection/move-by-character-005-expected.txt:
  • platform/gtk/editing/selection/move-by-sentence-001-expected.txt:
  • platform/gtk/editing/selection/move-by-sentence-linebreak-expected.txt:
  • platform/gtk/editing/selection/move-past-trailing-space-expected.txt:
  • platform/gtk/editing/selection/range-between-block-and-inline-expected.txt:
  • platform/gtk/editing/selection/select-box-expected.txt:
  • platform/gtk/editing/selection/select-text-overflow-ellipsis-expected.txt:
  • platform/gtk/editing/selection/selectNode-expected.txt:
  • platform/gtk/editing/selection/selectNodeContents-expected.txt:
  • platform/gtk/editing/selection/selection-actions-expected.txt:
  • platform/gtk/editing/selection/wrapped-line-caret-1-expected.txt:
  • platform/gtk/editing/selection/wrapped-line-caret-2-expected.txt:
  • platform/gtk/editing/spelling/spelling-expected.txt:
  • platform/gtk/editing/spelling/spelling-linebreak-expected.txt:
  • platform/gtk/editing/style/4916887-expected.txt:
  • platform/gtk/editing/style/5017613-1-expected.txt:
  • platform/gtk/editing/style/5017613-2-expected.txt:
  • platform/gtk/editing/style/5046875-1-expected.txt:
  • platform/gtk/editing/style/5046875-2-expected.txt:
  • platform/gtk/editing/style/5084241-expected.txt:
  • platform/gtk/editing/style/5228141-expected.txt:
  • platform/gtk/editing/style/5279521-expected.txt:
  • platform/gtk/editing/style/block-style-003-expected.txt:
  • platform/gtk/editing/style/highlight-expected.txt:
  • platform/gtk/editing/style/relative-font-size-change-001-expected.txt:
  • platform/gtk/editing/style/style-3681552-fix-001-expected.txt:
  • platform/gtk/editing/style/style-3681552-fix-002-expected.txt:
  • platform/gtk/editing/style/typing-style-001-expected.txt:
  • platform/gtk/editing/style/typing-style-002-expected.txt:
  • platform/gtk/editing/style/unbold-in-bold-expected.txt:
  • platform/gtk/editing/undo/4063751-expected.txt:
  • platform/gtk/editing/undo/5378473-expected.txt:
  • platform/gtk/editing/undo/redo-typing-001-expected.txt:
  • platform/gtk/editing/undo/undo-combined-delete-boundary-expected.txt:
  • platform/gtk/editing/undo/undo-combined-delete-expected.txt:
  • platform/gtk/editing/undo/undo-delete-boundary-expected.txt:
  • platform/gtk/editing/undo/undo-delete-expected.txt:
  • platform/gtk/editing/undo/undo-forward-delete-boundary-expected.txt:
  • platform/gtk/editing/undo/undo-forward-delete-expected.txt:
  • platform/gtk/editing/undo/undo-misspellings-expected.txt:
  • platform/gtk/fast/backgrounds/001-expected.txt:
  • platform/gtk/fast/backgrounds/animated-gif-as-background-expected.txt:
  • platform/gtk/fast/backgrounds/animated-svg-as-background-expected.txt:
  • platform/gtk/fast/backgrounds/background-inherit-color-bug-expected.txt:
  • platform/gtk/fast/backgrounds/background-origin-root-element-expected.txt:
  • platform/gtk/fast/backgrounds/background-position-1-expected.txt:
  • platform/gtk/fast/backgrounds/background-position-rounding-expected.txt:
  • platform/gtk/fast/backgrounds/body-generated-image-propagated-to-root-expected.txt:
  • platform/gtk/fast/backgrounds/mask-composite-expected.txt:
  • platform/gtk/fast/backgrounds/opacity-on-document-element-expected.txt:
  • platform/gtk/fast/backgrounds/quirks-mode-line-box-backgrounds-expected.txt:
  • platform/gtk/fast/backgrounds/repeat/mask-negative-offset-repeat-expected.txt:
  • platform/gtk/fast/backgrounds/repeat/negative-offset-repeat-expected.txt:
  • platform/gtk/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.txt:
  • platform/gtk/fast/backgrounds/repeat/noRepeatCorrectClip-expected.txt:
  • platform/gtk/fast/backgrounds/size/backgroundSize15-expected.txt:
  • platform/gtk/fast/backgrounds/size/backgroundSize16-expected.txt:
  • platform/gtk/fast/backgrounds/size/zero-expected.txt:
  • platform/gtk/fast/backgrounds/solid-color-context-restore-expected.txt:
  • platform/gtk/fast/backgrounds/svg-as-background-1-expected.txt:
  • platform/gtk/fast/backgrounds/svg-as-background-2-expected.txt:
  • platform/gtk/fast/backgrounds/svg-as-background-3-expected.txt:
  • platform/gtk/fast/backgrounds/svg-as-background-4-expected.txt:
  • platform/gtk/fast/backgrounds/svg-as-background-5-expected.txt:
  • platform/gtk/fast/backgrounds/svg-as-background-6-expected.txt:
  • platform/gtk/fast/block/margin-collapse/block-inside-inline/001-expected.txt:
  • platform/gtk/fast/block/margin-collapse/block-inside-inline/002-expected.txt:
  • platform/gtk/fast/block/margin-collapse/block-inside-inline/003-expected.txt:
  • platform/gtk/fast/block/margin-collapse/block-inside-inline/004-expected.txt:
  • platform/gtk/fast/block/margin-collapse/block-inside-inline/005-expected.txt:
  • platform/gtk/fast/block/margin-collapse/block-inside-inline/006-expected.txt:
  • platform/gtk/fast/block/margin-collapse/block-inside-inline/010-expected.txt:
  • platform/gtk/fast/block/margin-collapse/block-inside-inline/011-expected.txt:
  • platform/gtk/fast/block/margin-collapse/block-inside-inline/012-expected.txt:
  • platform/gtk/fast/block/margin-collapse/block-inside-inline/015-expected.txt:
  • platform/gtk/fast/block/margin-collapse/block-inside-inline/016-expected.txt:
  • platform/gtk/fast/block/margin-collapse/block-inside-inline/017-expected.txt:
  • platform/gtk/fast/block/margin-collapse/block-inside-inline/018-expected.txt:
  • platform/gtk/fast/block/margin-collapse/block-inside-inline/019-expected.txt:
  • platform/gtk/fast/block/margin-collapse/block-inside-inline/020-expected.txt:
  • platform/gtk/fast/block/margin-collapse/block-inside-inline/021-expected.txt:
  • platform/gtk/fast/block/margin-collapse/block-inside-inline/022-expected.txt:
  • platform/gtk/fast/block/margin-collapse/block-inside-inline/025-expected.txt:
  • platform/gtk/fast/block/positioning/absolute-positioning-no-scrollbar-expected.txt:
  • platform/gtk/fast/block/positioning/relative-positioned-inline-container-expected.txt:
  • platform/gtk/fast/borders/block-mask-overlay-image-expected.txt:
  • platform/gtk/fast/borders/border-color-inherit-expected.txt:
  • platform/gtk/fast/borders/border-fit-expected.txt:
  • platform/gtk/fast/borders/border-image-01-expected.txt:
  • platform/gtk/fast/borders/border-image-border-radius-expected.txt:
  • platform/gtk/fast/borders/border-image-rotate-transform-expected.txt:
  • platform/gtk/fast/borders/border-image-scale-transform-expected.txt:
  • platform/gtk/fast/borders/border-radius-constraints-expected.txt:
  • platform/gtk/fast/borders/border-radius-huge-assert-expected.txt:
  • platform/gtk/fast/borders/border-radius-split-inline-expected.txt:
  • platform/gtk/fast/borders/borderRadiusAllStylesAllCorners-expected.txt:
  • platform/gtk/fast/borders/borderRadiusArcs01-expected.txt:
  • platform/gtk/fast/borders/borderRadiusDashed01-expected.txt:
  • platform/gtk/fast/borders/borderRadiusDashed02-expected.txt:
  • platform/gtk/fast/borders/borderRadiusDashed03-expected.txt:
  • platform/gtk/fast/borders/borderRadiusDotted01-expected.txt:
  • platform/gtk/fast/borders/borderRadiusDotted02-expected.txt:
  • platform/gtk/fast/borders/borderRadiusDotted03-expected.txt:
  • platform/gtk/fast/borders/borderRadiusDouble01-expected.txt:
  • platform/gtk/fast/borders/borderRadiusDouble02-expected.txt:
  • platform/gtk/fast/borders/borderRadiusDouble03-expected.txt:
  • platform/gtk/fast/borders/borderRadiusGroove01-expected.txt:
  • platform/gtk/fast/borders/borderRadiusGroove02-expected.txt:
  • platform/gtk/fast/borders/borderRadiusInset01-expected.txt:
  • platform/gtk/fast/borders/borderRadiusInvalidColor-expected.txt:
  • platform/gtk/fast/borders/borderRadiusOutset01-expected.txt:
  • platform/gtk/fast/borders/borderRadiusRidge01-expected.txt:
  • platform/gtk/fast/borders/borderRadiusSolid01-expected.txt:
  • platform/gtk/fast/borders/borderRadiusSolid02-expected.txt:
  • platform/gtk/fast/borders/borderRadiusSolid03-expected.txt:
  • platform/gtk/fast/borders/borderRadiusSolid04-expected.txt:
  • platform/gtk/fast/borders/different-color-borders-expected.txt:
  • platform/gtk/fast/borders/inline-mask-overlay-image-expected.txt:
  • platform/gtk/fast/borders/svg-as-border-image-2-expected.txt:
  • platform/gtk/fast/borders/svg-as-border-image-expected.txt:
  • platform/gtk/fast/box-shadow/basic-shadows-expected.txt:
  • platform/gtk/fast/box-shadow/border-radius-big-expected.txt:
  • platform/gtk/fast/box-shadow/inset-expected.txt:
  • platform/gtk/fast/box-shadow/transform-fringing-expected.txt:
  • platform/gtk/fast/canvas/setWidthResetAfterForcedRender-expected.txt:
  • platform/gtk/fast/canvas/shadow-offset-1-expected.txt:
  • platform/gtk/fast/canvas/shadow-offset-2-expected.txt:
  • platform/gtk/fast/canvas/shadow-offset-3-expected.txt:
  • platform/gtk/fast/canvas/shadow-offset-4-expected.txt:
  • platform/gtk/fast/canvas/shadow-offset-5-expected.txt:
  • platform/gtk/fast/canvas/shadow-offset-6-expected.txt:
  • platform/gtk/fast/canvas/shadow-offset-7-expected.txt:
  • platform/gtk/fast/canvas/toDataURL-alpha-expected.txt:
  • platform/gtk/fast/css-generated-content/after-duplicated-after-split-expected.txt:
  • platform/gtk/fast/css/compare-content-style-expected.txt:
  • platform/gtk/fast/css/css3-space-in-nth-and-lang-expected.txt:
  • platform/gtk/fast/css/first-letter-first-line-hover-expected.txt:
  • platform/gtk/fast/css/font-face-in-shadow-DOM-expected.txt:
  • platform/gtk/fast/css/getComputedStyle/marginComputedStyle-expected.txt:
  • platform/gtk/fast/css/inline-element-line-break-expected.txt:
  • platform/gtk/fast/css/input-search-padding-expected.txt:
  • platform/gtk/fast/css/non-standard-checkbox-size-expected.txt:
  • platform/gtk/fast/css/percent-top-relative-container-height-unspecified-expected.txt:
  • platform/gtk/fast/css/preserve-user-specified-zoom-level-on-reload-expected.txt: Added.
  • platform/gtk/fast/css/pseudo-element-line-break-expected.txt:
  • platform/gtk/fast/css/shadow-multiple-expected.txt:
  • platform/gtk/fast/css/text-input-with-webkit-border-radius-expected.txt:
  • platform/gtk/fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element-expected.txt:
  • platform/gtk/fast/dom/HTMLProgressElement/progress-element-expected.txt:
  • platform/gtk/fast/dynamic/float-in-trailing-whitespace-after-last-line-break-2-expected.txt:
  • platform/gtk/fast/dynamic/window-resize-scrollbars-test-expected.txt:
  • platform/gtk/fast/dynamic/window-scrollbars-test-expected.txt:
  • platform/gtk/fast/events/event-sender-mouse-moved-expected.txt:
  • platform/gtk/fast/events/mouseout-dead-node-expected.txt:
  • platform/gtk/fast/events/standalone-image-drag-to-editable-expected.txt:
  • platform/gtk/fast/forms/box-shadow-override-expected.txt:
  • platform/gtk/fast/forms/button-style-color-expected.txt:
  • platform/gtk/fast/forms/input-text-drag-down-expected.txt:
  • platform/gtk/fast/forms/placeholder-stripped-expected.txt:
  • platform/gtk/fast/forms/range-thumb-height-percentage-expected.txt:
  • platform/gtk/fast/forms/slider-padding-expected.txt:
  • platform/gtk/fast/forms/slider-thumb-shared-style-expected.txt:
  • platform/gtk/fast/forms/slider-thumb-stylability-expected.txt:
  • platform/gtk/fast/forms/thumbslider-crash-expected.txt:
  • platform/gtk/fast/forms/thumbslider-no-parent-slider-expected.txt:
  • platform/gtk/fast/frames/001-expected.txt:
  • platform/gtk/fast/frames/contentWindow_Frame-expected.txt:
  • platform/gtk/fast/frames/contentWindow_iFrame-expected.txt:
  • platform/gtk/fast/frames/frame-element-name-expected.txt:
  • platform/gtk/fast/frames/frame-navigation-expected.txt:
  • platform/gtk/fast/frames/frame-scrolling-attribute-expected.txt:
  • platform/gtk/fast/frames/frame-src-attribute-expected.txt:
  • platform/gtk/fast/frames/frameElement-frame-expected.txt:
  • platform/gtk/fast/frames/frameElement-iframe-expected.txt:
  • platform/gtk/fast/frames/frameset-style-recalc-expected.txt:
  • platform/gtk/fast/frames/iframe-option-crash-expected.txt:
  • platform/gtk/fast/frames/iframe-scrolling-attribute-expected.txt:
  • platform/gtk/fast/frames/iframe-with-frameborder-expected.txt:
  • platform/gtk/fast/frames/inline-object-inside-frameset-expected.txt:
  • platform/gtk/fast/frames/take-focus-from-iframe-expected.txt:
  • platform/gtk/fast/frames/viewsource-attribute-expected.txt:
  • platform/gtk/fast/frames/viewsource-on-image-file-expected.txt:
  • platform/gtk/fast/gradients/radial-centered-expected.txt:
  • platform/gtk/fast/images/svg-background-partial-redraw-expected.txt:
  • platform/gtk/fast/inline/continuation-outlines-with-layers-2-expected.txt:
  • platform/gtk/fast/layers/remove-only-this-layer-update-expected.txt:
  • platform/gtk/fast/lists/drag-into-marker-expected.txt:
  • platform/gtk/fast/multicol/border-padding-pagination-expected.txt:
  • platform/gtk/fast/multicol/client-rects-expected.txt:
  • platform/gtk/fast/multicol/column-break-with-balancing-expected.txt:
  • platform/gtk/fast/multicol/column-count-with-rules-expected.txt:
  • platform/gtk/fast/multicol/column-rules-expected.txt:
  • platform/gtk/fast/multicol/column-rules-stacking-expected.txt:
  • platform/gtk/fast/multicol/columns-shorthand-parsing-expected.txt:
  • platform/gtk/fast/multicol/float-avoidance-expected.txt:
  • platform/gtk/fast/multicol/float-multicol-expected.txt:
  • platform/gtk/fast/multicol/float-paginate-complex-expected.txt:
  • platform/gtk/fast/multicol/float-paginate-expected.txt:
  • platform/gtk/fast/multicol/layers-in-multicol-expected.txt:
  • platform/gtk/fast/multicol/layers-split-across-columns-expected.txt:
  • platform/gtk/fast/multicol/margin-collapse-expected.txt:
  • platform/gtk/fast/multicol/max-height-columns-block-expected.txt:
  • platform/gtk/fast/multicol/nested-columns-expected.txt:
  • platform/gtk/fast/multicol/paginate-block-replaced-expected.txt:
  • platform/gtk/fast/multicol/positioned-split-expected.txt:
  • platform/gtk/fast/multicol/positioned-with-constrained-height-expected.txt:
  • platform/gtk/fast/multicol/shadow-breaking-expected.txt:
  • platform/gtk/fast/multicol/single-line-expected.txt:
  • platform/gtk/fast/multicol/span/anonymous-style-inheritance-expected.txt:
  • platform/gtk/fast/multicol/span/span-as-immediate-child-complex-splitting-expected.txt:
  • platform/gtk/fast/multicol/span/span-as-immediate-child-generated-content-expected.txt:
  • platform/gtk/fast/multicol/span/span-as-immediate-child-property-removal-expected.txt:
  • platform/gtk/fast/multicol/span/span-as-immediate-columns-child-dynamic-expected.txt:
  • platform/gtk/fast/multicol/span/span-as-immediate-columns-child-expected.txt:
  • platform/gtk/fast/multicol/span/span-as-immediate-columns-child-removal-expected.txt:
  • platform/gtk/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.txt:
  • platform/gtk/fast/multicol/span/span-as-nested-columns-child-expected.txt:
  • platform/gtk/fast/multicol/span/span-margin-collapsing-expected.txt:
  • platform/gtk/fast/multicol/table-margin-collapse-expected.txt:
  • platform/gtk/fast/multicol/table-vertical-align-expected.txt:
  • platform/gtk/fast/multicol/unsplittable-inline-block-expected.txt:
  • platform/gtk/fast/repaint/block-layout-inline-children-float-positioned-expected.txt:
  • platform/gtk/fast/repaint/block-layout-inline-children-replaced-expected.txt:
  • platform/gtk/fast/repaint/block-no-inflow-children-expected.txt:
  • platform/gtk/fast/repaint/fixed-child-move-after-scroll-expected.txt:
  • platform/gtk/fast/repaint/fixed-child-of-fixed-move-after-scroll-expected.txt:
  • platform/gtk/fast/repaint/fixed-child-of-transformed-move-after-scroll-expected.txt:
  • platform/gtk/fast/repaint/fixed-move-after-keyboard-scroll-expected.txt:
  • platform/gtk/fast/repaint/fixed-move-after-scroll-expected.txt:
  • platform/gtk/fast/repaint/inline-relative-positioned-expected.txt:
  • platform/gtk/fast/repaint/layout-state-scrolloffset-expected.txt:
  • platform/gtk/fast/repaint/layout-state-scrolloffset2-expected.txt:
  • platform/gtk/fast/repaint/layout-state-scrolloffset3-expected.txt:
  • platform/gtk/fast/repaint/multicol-repaint-expected.txt:
  • platform/gtk/fast/repaint/selection-clear-expected.txt:
  • platform/gtk/fast/repaint/selection-gap-overflow-scroll-2-expected.txt:
  • platform/gtk/fast/repaint/stacked-diacritics-expected.txt:
  • platform/gtk/fast/table/early-table-layout-expected.txt:
  • platform/gtk/fast/table/fixed-table-with-percent-inside-percent-table-expected.txt:
  • platform/gtk/fast/table/fixed-table-with-percent-width-inside-auto-table-expected.txt:
  • platform/gtk/fast/table/fixed-table-with-percent-width-inside-div-expected.txt:
  • platform/gtk/fast/table/fixed-table-with-percent-width-inside-extra-large-div-expected.txt:
  • platform/gtk/fast/table/fixed-table-with-percent-width-inside-fixed-width-table-expected.txt:
  • platform/gtk/fast/table/fixed-table-with-small-percent-width-expected.txt:
  • platform/gtk/fast/text/backslash-to-yen-sign-dynamic-expected.txt:
  • platform/gtk/fast/text/backslash-to-yen-sign-euc-expected.txt:
  • platform/gtk/fast/text/backslash-to-yen-sign-expected.txt:
  • platform/gtk/fast/text/format-control-expected.txt:
  • platform/gtk/fast/text/international/bidi-mirror-he-ar-expected.txt:
  • platform/gtk/fast/text/international/bold-bengali-expected.txt:
  • platform/gtk/fast/text/international/plane2-expected.txt:
  • platform/gtk/fast/text/shadow-no-blur-expected.txt:
  • platform/gtk/fast/text/shadow-translucent-fill-expected.txt:
  • platform/gtk/fast/text/stroking-expected.txt:
  • platform/gtk/http/tests/misc/slow-loading-image-in-pattern-expected.txt:
  • platform/gtk/mathml/presentation/attributes-expected.txt:
  • platform/gtk/mathml/presentation/fenced-expected.txt:
  • platform/gtk/mathml/presentation/fractions-expected.txt:
  • platform/gtk/mathml/presentation/fractions-vertical-alignment-expected.txt:
  • platform/gtk/mathml/presentation/mo-expected.txt:
  • platform/gtk/mathml/presentation/over-expected.txt:
  • platform/gtk/mathml/presentation/roots-expected.txt:
  • platform/gtk/mathml/presentation/row-alignment-expected.txt:
  • platform/gtk/mathml/presentation/row-expected.txt:
  • platform/gtk/mathml/presentation/style-expected.txt:
  • platform/gtk/mathml/presentation/subsup-expected.txt:
  • platform/gtk/mathml/presentation/tokenElements-expected.txt:
  • platform/gtk/mathml/presentation/under-expected.txt:
  • platform/gtk/mathml/presentation/underover-expected.txt:
  • platform/gtk/scrollbars/basic-scrollbar-expected.txt:
  • platform/gtk/scrollbars/custom-scrollbar-with-incomplete-style-expected.txt:
  • platform/gtk/scrollbars/disabled-scrollbar-expected.txt:
  • platform/gtk/scrollbars/listbox-scrollbar-combinations-expected.txt:
  • platform/gtk/scrollbars/overflow-scrollbar-combinations-expected.txt:
  • platform/gtk/scrollbars/scrollbar-buttons-expected.txt:
  • platform/gtk/scrollbars/scrollbar-orientation-expected.txt:
  • platform/gtk/svg/batik/text/textDecoration-expected.txt:
  • platform/gtk/svg/css/composite-shadow-text-expected.txt:
  • platform/gtk/svg/css/group-with-shadow-expected.txt:
  • platform/gtk/svg/css/shadow-changes-expected.txt:
  • platform/gtk/svg/css/text-shadow-multiple-expected.txt:
  • platform/gtk/svg/custom/broken-internal-references-expected.txt:
  • platform/gtk/svg/custom/bug45331-expected.txt:
  • platform/gtk/svg/custom/clone-element-with-animated-svg-properties-expected.txt:
  • platform/gtk/svg/custom/empty-mask-expected.txt:
  • platform/gtk/svg/custom/getscreenctm-in-scrollable-div-area-expected.txt:
  • platform/gtk/svg/custom/getscreenctm-in-scrollable-div-area-nested-expected.txt:
  • platform/gtk/svg/custom/getscreenctm-in-scrollable-svg-area-expected.txt:
  • platform/gtk/svg/custom/js-update-stop-linked-gradient-expected.txt:
  • platform/gtk/svg/custom/mask-invalidation-expected.txt:
  • platform/gtk/svg/custom/mouse-move-on-svg-container-expected.txt:
  • platform/gtk/svg/custom/mouse-move-on-svg-container-standalone-expected.txt:
  • platform/gtk/svg/custom/mouse-move-on-svg-root-expected.txt:
  • platform/gtk/svg/custom/mouse-move-on-svg-root-standalone-expected.txt:
  • platform/gtk/svg/custom/pattern-incorrect-tiling-expected.txt:
  • platform/gtk/svg/custom/recursive-gradient-expected.txt:
  • platform/gtk/svg/custom/recursive-pattern-expected.txt:
  • platform/gtk/svg/custom/relative-sized-content-expected.txt:
  • platform/gtk/svg/custom/relative-sized-content-with-resources-expected.txt:
  • platform/gtk/svg/custom/relative-sized-deep-shadow-tree-content-expected.txt:
  • platform/gtk/svg/custom/relative-sized-shadow-tree-content-expected.txt:
  • platform/gtk/svg/custom/stroke-width-large-expected.txt:
  • platform/gtk/svg/custom/svg-curve-with-relative-cordinates-expected.txt:
  • platform/gtk/svg/custom/svg-fonts-without-missing-glyph-expected.txt:
  • platform/gtk/svg/custom/text-rotated-gradient-expected.txt:
  • platform/gtk/svg/custom/text-xy-updates-SVGList-expected.txt:
  • platform/gtk/svg/custom/text-zoom-expected.txt:
  • platform/gtk/svg/custom/use-font-face-crash-expected.txt:
  • platform/gtk/svg/filters/filter-on-filter-for-text-expected.txt:
  • platform/gtk/svg/filters/filter-on-tspan-expected.txt:
  • platform/gtk/svg/filters/filter-width-update-expected.txt:
  • platform/gtk/svg/foreignObject/no-crash-with-svg-content-in-html-document-expected.txt:
  • platform/gtk/svg/foreignObject/svg-document-as-direct-child-expected.txt:
  • platform/gtk/svg/foreignObject/svg-document-in-html-document-expected.txt:
  • platform/gtk/svg/foreignObject/text-tref-02-b-expected.txt:
  • platform/gtk/svg/in-html/by-reference-expected.txt: Copied from LayoutTests/platform/chromium-linux/svg/in-html/by-reference-expected.txt.
  • platform/gtk/svg/in-html/circle-expected.txt:
  • platform/gtk/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-auto-expected.txt:
  • platform/gtk/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-defaults-expected.txt:
  • platform/gtk/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-hidden-expected.txt:
  • platform/gtk/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-scroll-expected.txt:
  • platform/gtk/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-visible-expected.txt:
  • platform/gtk/svg/repaint/filter-repaint-expected.txt:
  • platform/gtk/svg/text/foreignObject-text-clipping-bug-expected.txt:
  • platform/gtk/svg/text/select-textLength-spacing-squeeze-1-expected.txt:
  • platform/gtk/svg/text/select-textLength-spacing-squeeze-2-expected.txt:
  • platform/gtk/svg/text/select-textLength-spacing-squeeze-3-expected.txt:
  • platform/gtk/svg/text/select-textLength-spacing-squeeze-4-expected.txt:
  • platform/gtk/svg/text/select-textLength-spacing-stretch-1-expected.txt:
  • platform/gtk/svg/text/select-textLength-spacing-stretch-2-expected.txt:
  • platform/gtk/svg/text/select-textLength-spacing-stretch-3-expected.txt:
  • platform/gtk/svg/text/select-textLength-spacing-stretch-4-expected.txt:
  • platform/gtk/svg/text/select-textLength-spacingAndGlyphs-squeeze-1-expected.txt:
  • platform/gtk/svg/text/select-textLength-spacingAndGlyphs-squeeze-2-expected.txt:
  • platform/gtk/svg/text/select-textLength-spacingAndGlyphs-squeeze-3-expected.txt:
  • platform/gtk/svg/text/select-textLength-spacingAndGlyphs-squeeze-4-expected.txt:
  • platform/gtk/svg/text/select-textLength-spacingAndGlyphs-stretch-1-expected.txt:
  • platform/gtk/svg/text/select-textLength-spacingAndGlyphs-stretch-2-expected.txt:
  • platform/gtk/svg/text/select-textLength-spacingAndGlyphs-stretch-3-expected.txt:
  • platform/gtk/svg/text/select-textLength-spacingAndGlyphs-stretch-4-expected.txt:
  • platform/gtk/svg/text/select-x-list-1-expected.txt:
  • platform/gtk/svg/text/select-x-list-2-expected.txt:
  • platform/gtk/svg/text/select-x-list-3-expected.txt:
  • platform/gtk/svg/text/select-x-list-4-expected.txt:
  • platform/gtk/svg/text/select-x-list-with-tspans-1-expected.txt:
  • platform/gtk/svg/text/select-x-list-with-tspans-2-expected.txt:
  • platform/gtk/svg/text/select-x-list-with-tspans-3-expected.txt:
  • platform/gtk/svg/text/select-x-list-with-tspans-4-expected.txt:
  • platform/gtk/svg/text/selection-background-color-expected.txt:
  • platform/gtk/svg/text/selection-doubleclick-expected.txt:
  • platform/gtk/svg/text/selection-styles-expected.txt:
  • platform/gtk/svg/text/selection-tripleclick-expected.txt:
  • platform/gtk/svg/zoom/page/zoom-foreignObject-expected.txt:
  • platform/gtk/svg/zoom/page/zoom-hixie-mixed-008-expected.txt:
  • platform/gtk/svg/zoom/page/zoom-hixie-mixed-009-expected.txt:
  • platform/gtk/svg/zoom/page/zoom-hixie-rendering-model-004-expected.txt:
  • platform/gtk/svg/zoom/page/zoom-svg-float-border-padding-expected.txt:
  • platform/gtk/svg/zoom/text/zoom-foreignObject-expected.txt:
  • platform/gtk/svg/zoom/text/zoom-hixie-mixed-008-expected.txt:
  • platform/gtk/svg/zoom/text/zoom-hixie-rendering-model-004-expected.txt:
  • platform/gtk/svg/zoom/text/zoom-svg-float-border-padding-expected.txt:
  • platform/gtk/tables/layering/paint-test-layering-1-expected.txt:
  • platform/gtk/tables/layering/paint-test-layering-2-expected.txt:
  • platform/gtk/transforms/2d/compound-transforms-vs-containers-expected.txt:
  • platform/gtk/transforms/2d/hindi-rotated-expected.txt:
  • platform/gtk/transforms/2d/transform-borderbox-expected.txt:
  • platform/gtk/transforms/2d/transform-fixed-container-expected.txt:
  • platform/gtk/transforms/2d/transform-origin-borderbox-expected.txt:
  • platform/gtk/transforms/2d/zoom-menulist-expected.txt:
  • platform/gtk/transforms/no_transform_hit_testing-expected.txt:
  • platform/gtk/transforms/svg-vs-css-expected.txt:
  • platform/gtk/transitions/move-after-transition-expected.txt:
  • platform/gtk/transitions/svg-text-shadow-transition-expected.txt:
  • platform/gtk/transitions/transition-drt-api-expected.txt:

2010-09-19 Martin Robinson <mrobinson@igalia.com>

Reviewed by Gustavo Noronha Silva.

[GTK] Wrong font instantiated from an unknown font family
https://bugs.webkit.org/show_bug.cgi?id=36548

When FontConfig returns a match for a particular family name, ensure that
the family name matches the configured alias for the original pattern. This
should prevent selecting FontConfig fallbacks in situations where the next
font on the CSS fallback list should be used. This requires moving all FontConfig
matching logic into FontCacheFreeType and out of FontPlatformDataFreeType.
It should be there anyway.

Test: platform/gtk/fonts/font-family-fallback.html

  • platform/graphics/cairo/FontCacheFreeType.cpp: (WebCore::FontCache::platformInit): Simply call FcInit here instead of deferring to FontPlatformData. (WebCore::FontCache::getLastResortFallbackFont): The last resort font should be a fallback font or else the new FontConfig logic may result in null font data if it cannot find an appropriate match. (WebCore::getFamilyNameStringFromFontDescriptionAndFamily): Added. Helper function which converts WebCore fallback names into ones that FontConfig understands. (WebCore::isFallbackFontAllowed): Added. Helper function that allows FontConfig fallbacks to be used when generic family names are specified. (WebCore::FontCache::createFontPlatformData): Move all FontConfig matching logic here and prevent against the situation where FontConfig returns a different family name than we asked for.
  • platform/graphics/cairo/FontCustomPlatformData.cpp: Updated FontPlatformData constructor.
  • platform/graphics/cairo/FontPlatformDataFreeType.cpp: Update the constructor to take the FcPattern returned and the original FontDescription. We no longer need the other arguments, because the selection is now done by FontCacheFreeType. (WebCore::FontPlatformData::FontPlatformData): Remove the FontConfig selection logic from this code.
  • platform/graphics/cairo/FontPlatformDataFreeType.h: Updated method definitions.
  • platform/graphics/cairo/GlyphPageTreeNodeCairo.cpp: Fixed includes.
  • platform/graphics/cairo/PlatformRefPtrCairo.cpp: Added a PlatformRefPtr specialization for cairo_font_face_t. (WTF::refPlatformPtr): Added. (WTF::derefPlatformPtr): Added.
  • platform/graphics/cairo/PlatformRefPtrCairo.h: Updated method definitons.
  • platform/graphics/cairo/SimpleFontDataCairo.cpp: (WebCore::SimpleFontData::smallCapsFontData): Fixed FontPlatformData constructor.
10:53 AM Changeset in webkit [68405] by Philippe Normand
  • 4 edits in trunk

2010-09-27 Philippe Normand <pnormand@igalia.com>

Reviewed by Martin Robinson.

[GTK] use ENABLE(GLIB_SUPPORT)
https://bugs.webkit.org/show_bug.cgi?id=46630

Enabling GLIB_SUPPORT on all ports that use GLib to simplify
checks.

  • GNUmakefile.am: Enabled the GLIB_SUPPORT define.

JavaScriptCore:

Reviewed by Martin Robinson.

[GTK] use ENABLE(GLIB_SUPPORT)
https://bugs.webkit.org/show_bug.cgi?id=46630

  • wtf/Platform.h: Include GTypedefs.h only if glib support is explicitly enabled.
10:50 AM Changeset in webkit [68404] by Philippe Normand
  • 6 edits in trunk

2010-09-27 Philippe Normand <pnormand@igalia.com>

Reviewed by Martin Robinson.

[GTK] Doesn't build with gtk+ 2.14
https://bugs.webkit.org/show_bug.cgi?id=46565

Fixed the build for GTK+ 2.14 by adding backward compatible
a backward-compatible function for gtk_menu_item_get_label and a
utility function to create a blank mouse cursor. Those functions
are used in the fullscreen video controller and in the DRT
EventSender.

  • platform/gtk/GtkVersioning.c: (gdk_window_get_root_coords): (blankCursor): (gtk_menu_item_get_label):
  • platform/gtk/GtkVersioning.h:

WebKit/gtk:

Reviewed by Martin Robinson.

[GTK] Doesn't build with gtk+ 2.14
https://bugs.webkit.org/show_bug.cgi?id=46565

Fixed the build for GTK+ 2.14. Don't use gdk_window_get_cursor()
for that GTK+ version as I found no acceptable way to work-around
its absence.

  • WebCoreSupport/FullscreenVideoController.cpp: (FullscreenVideoController::showHud): (FullscreenVideoController::hideHud): (FullscreenVideoController::enterFullscreen):
10:50 AM Changeset in webkit [68403] by Martin Robinson
  • 4 edits
    3 adds
    1 delete in trunk/WebKitTools

2010-09-18 Martin Robinson <mrobinson@igalia.com>

Reviewed by Gustavo Noronha Silva.

[GTK] Clean up the DRT fonts.conf and switch to Liberation
https://bugs.webkit.org/show_bug.cgi?id=46038

Switch to Liberation fonts for GTK+ layout tests. This will make our
test results metric-compatible with many Windows/Chromium results. It
also simplifies the fonts.conf that we load and prepares the way for
fixing many font bugs.

  • DumpRenderTree/gtk/DumpRenderTree.cpp: (initializeFonts): Initialize a known list of fonts instead of loading every font in the WEBKIT_TESTFONTS directory.
  • DumpRenderTree/gtk/fonts.conf: Removed.
  • DumpRenderTree/gtk/fonts/AHEM.TTF: Copied from WebKitTools/DumpRenderTree/qt/fonts/AHEM.TTF.
  • DumpRenderTree/gtk/fonts/fonts.conf: Added.
  • GNUmakefile.am: Modify FONTS_CONF_FILE to be FONTS_CONF_DIR, so that we can load both fonts.conf and AHEM.TTF from this location.
  • Scripts/old-run-webkit-tests: Remove the check for WEBKIT_TESTFONTS, since it is no longer used.
10:44 AM Changeset in webkit [68402] by senorblanco@chromium.org
  • 4 edits in trunk/WebCore

2010-09-23 Stephen White <senorblanco@chromium.org>

Reviewed by James Robinson.

[CHROMIUM] Fix for canvas clearRect() with clipping active, when
--enable-accelerated-2d-canvas is on.
https://bugs.webkit.org/show_bug.cgi?id=46412

Covered by layout test http://philip.html5.org/tests/canvas/suite/tests/2d.clearRect.clip.html.

  • platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContext::clearRect): Check if a clip is active during clipRect(), and force to software if so. Force a readback in this case, since clearRect() is not compatible with mixed-mode rendering.
  • platform/graphics/skia/PlatformContextSkia.cpp: (WebCore::PlatformContextSkia::canvasClipApplied):
  • platform/graphics/skia/PlatformContextSkia.h: Implement accessor to check if a clip is active.
10:23 AM Changeset in webkit [68401] by zmo@google.com
  • 5 edits in trunk

2010-09-14 Zhenyao Mo <zmo@google.com>

Reviewed by Kenneth Russell.

drawElements with count=0 and offset = 0 should not generate GL error or crash
https://bugs.webkit.org/show_bug.cgi?id=45769

  • html/canvas/WebGLRenderingContext.cpp: Deal with count=0 case. (WebCore::WebGLRenderingContext::validateIndexArrayConservative): (WebCore::WebGLRenderingContext::validateIndexArrayPrecise): (WebCore::WebGLRenderingContext::drawElements):

2010-09-14 Zhenyao Mo <zmo@google.com>

Reviewed by Kenneth Russell.

drawElements with count=0 and offset = 0 should not generate GL error or crash
https://bugs.webkit.org/show_bug.cgi?id=45769

  • fast/canvas/webgl/draw-elements-out-of-bounds-expected.txt: Test count=0 cases.
  • fast/canvas/webgl/draw-elements-out-of-bounds.html: Ditto.
10:07 AM Changeset in webkit [68400] by zmo@google.com
  • 5 edits
    2 adds in trunk

2010-09-16 Zhenyao Mo <zmo@google.com>

Reviewed by Kenneth Russell.

Fold getString into getParameter and implement new queries
https://bugs.webkit.org/show_bug.cgi?id=40321

Test: fast/canvas/webgl/gl-getstring.html

  • html/canvas/WebGLRenderingContext.cpp: Merge getString enums into getParameter. (WebCore::WebGLRenderingContext::getParameter):
  • html/canvas/WebGLRenderingContext.h: Remove getString.
  • html/canvas/WebGLRenderingContext.idl: Remove getString.

2010-09-16 Zhenyao Mo <zmo@google.com>

Reviewed by Kenneth Russell.

Fold getString into getParameter and implement new queries
https://bugs.webkit.org/show_bug.cgi?id=40321

  • fast/canvas/webgl/gl-getstring-expected.txt: Added.
  • fast/canvas/webgl/gl-getstring.html: Added.
10:01 AM Changeset in webkit [68399] by zmo@google.com
  • 6 edits in trunk

2010-09-24 Zhenyao Mo <zmo@google.com>

Reviewed by Kenneth Russell.

gl-teximage fails on chrome mac bot
https://bugs.webkit.org/show_bug.cgi?id=45332

Add support for alpha first pixel formats.

  • platform/graphics/GraphicsContext3D.cpp: (WebCore::doPacking):
  • platform/graphics/GraphicsContext3D.h:
  • platform/graphics/cg/GraphicsContext3DCG.cpp: (WebCore::GraphicsContext3D::getImageData):

2010-09-24 Zhenyao Mo <zmo@google.com>

Reviewed by Kenneth Russell.

gl-teximage fails on chrome mac bot
https://bugs.webkit.org/show_bug.cgi?id=45332

  • platform/chromium/test_expectations.txt: Re-enabling gl-textimage.html with the fix.
9:55 AM Changeset in webkit [68398] by yurys@chromium.org
  • 7 edits
    2 adds in trunk/WebCore

2010-09-17 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: implement go-to-line feature
https://bugs.webkit.org/show_bug.cgi?id=45166

  • English.lproj/localizedStrings.js:
  • inspector/front-end/GoToLineDialog.js: Added. (WebInspector.GoToLineDialog): (WebInspector.GoToLineDialog.show): (WebInspector.GoToLineDialog.prototype._hide): (WebInspector.GoToLineDialog.prototype._onKeyDown): (WebInspector.GoToLineDialog.prototype._onBlur):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype._registerShortcuts): (WebInspector.ScriptsPanel.prototype.jumpToPreviousSearchResult): (WebInspector.ScriptsPanel.prototype.showGoToLineDialog):
  • inspector/front-end/goToLineDialog.css: Added. (.go-to-line-dialog):
  • inspector/front-end/inspector.html:
9:52 AM Changeset in webkit [68397] by weinig@apple.com
  • 11 edits
    1 add in trunk/WebKit2

The mouseDidMoveOverElement callback in the injected bundle should include modifier info
https://bugs.webkit.org/show_bug.cgi?id=46629

Reviewed by Anders Carlsson.

  • Moves event related API enums to WKEvent.h which can be shared between both the bundle and the main API.
  • Shared/API/c/WKEvent.h: Added.
  • Shared/API/c/WKSharedAPICast.h:

(WebKit::toRef):

  • UIProcess/API/C/WKAPICast.h:
  • UIProcess/API/C/WKPage.h:
  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/InjectedBundle/API/c/WKBundlePage.h:
  • WebProcess/InjectedBundle/InjectedBundlePageUIClient.cpp:

(WebKit::InjectedBundlePageUIClient::mouseDidMoveOverElement):

  • WebProcess/InjectedBundle/InjectedBundlePageUIClient.h:
  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::mouseDidMoveOverElement):

  • win/WebKit2.vcproj:
  • win/WebKit2Generated.make:
9:38 AM WebKit Team edited by skyul@company100.net
(diff)
9:20 AM Changeset in webkit [68396] by Adam Roben
  • 2 edits in trunk/WebKit2

Give mouse wheel events the right coordinates on Windows

Fixes <http://webkit.org/b/46625> <rdar://problem/8481161> Placing
mouse cursor inside a scrollable area and scrolling the mouse wheel
generally doesn't scroll the area

Reviewed by Sam Weinig.

  • Shared/win/WebEventFactory.cpp:

(WebKit::point): Renamed from positionForEvent. The old name implied
that all events used the same relative origin, which is untrue.
(WebKit::WebEventFactory::createWebMouseEvent): Changed to use point
and ::ClientToScreen explicitly rather than relying on
positionForEvent/globalPositionForEvent.
(WebKit::WebEventFactory::createWebWheelEvent): Changed to use point
and ::ScreenToClient. The old code was assuming that wheel event
points are relative to the client area, but they are in fact relative
to the screen.

9:08 AM Changeset in webkit [68395] by podivilov@chromium.org
  • 13 edits
    1 add in trunk/WebCore

2010-09-24 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: add XHR breakpoints sidebar pane to front-end
https://bugs.webkit.org/show_bug.cgi?id=46483

  • English.lproj/localizedStrings.js:
  • WebCore.gypi:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::instrumentWillSendXMLHttpRequestImpl):
  • inspector/InspectorTimelineAgent.h:
  • inspector/front-end/BreakpointManager.js: (WebInspector.BreakpointManager): (WebInspector.BreakpointManager.prototype._setBreakpointOnBackend): (WebInspector.BreakpointManager.prototype.createXHRBreakpoint): (WebInspector.BreakpointManager.prototype._xhrBreakpointRemoved): (WebInspector.Breakpoint.prototype.compareTo): (WebInspector.XHRBreakpoint): (WebInspector.XHRBreakpoint.prototype.get enabled): (WebInspector.XHRBreakpoint.prototype.set enabled): (WebInspector.XHRBreakpoint.prototype.get url): (WebInspector.XHRBreakpoint.prototype.formatLabel): (WebInspector.XHRBreakpoint.prototype.compareTo): (WebInspector.XHRBreakpoint.prototype.remove): (WebInspector.XHRBreakpoint.prototype._setOnBackend.didSet): (WebInspector.XHRBreakpoint.prototype._setOnBackend): (WebInspector.XHRBreakpoint.prototype._removeFromBackend):
  • inspector/front-end/BreakpointsSidebarPane.js: (WebInspector.XHRBreakpointsSidebarPane): (WebInspector.XHRBreakpointsSidebarPane.prototype._showEditBreakpointDialog): (WebInspector.XHRBreakpointsSidebarPane.prototype._hideEditBreakpointDialog): (WebInspector.BreakpointItem.prototype.compareTo): (WebInspector.BreakpointItem.prototype._checkboxClicked): (WebInspector.BreakpointItem.prototype._enableChanged): (WebInspector.BreakpointItem.prototype._breakpointClicked): (WebInspector.XHRBreakpointItem):
  • inspector/front-end/CallStackSidebarPane.js: (WebInspector.CallStackSidebarPane.prototype.updateStatus.formatters.s): (WebInspector.CallStackSidebarPane.prototype.updateStatus.append): (WebInspector.CallStackSidebarPane.prototype.updateStatus):
  • inspector/front-end/DOMAgent.js: (WebInspector.DOMBreakpoint.prototype.compareTo):
  • inspector/front-end/Images/paneAddButtons.png: Added.
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel): (WebInspector.ScriptsPanel.prototype.reset):
  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.css: (.pane > .title > button.add): (.pane > .title > button.add:hover): (.pane > .title > button.add:active): (.pane > .body .breakpoint-condition):
  • inspector/front-end/inspector.js: (WebInspector.createXHRBreakpointsSidebarPane.breakpointAdded): (WebInspector.createXHRBreakpointsSidebarPane):
8:59 AM Changeset in webkit [68394] by pfeldman@chromium.org
  • 7 edits
    1 delete in trunk/WebCore

2010-09-27 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Merge AbstractTimelinePanel into ResourcesPanel.
https://bugs.webkit.org/show_bug.cgi?id=46612

I am refactoring resources panel and would like to merge abstract
one back in since it is not use anywhere else.

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/front-end/AbstractTimelinePanel.js: Removed.
  • inspector/front-end/ResourceCategory.js: (WebInspector.ResourceCategory): (WebInspector.ResourceCategory.prototype.toString):
  • inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel): (WebInspector.ResourcesPanel.prototype.get items): (WebInspector.ResourcesPanel.prototype.createInterface): (WebInspector.ResourcesPanel.prototype.createFilterPanel.createFilterElement): (WebInspector.ResourcesPanel.prototype.createFilterPanel): (WebInspector.ResourcesPanel.prototype.showCategory): (WebInspector.ResourcesPanel.prototype.hideCategory): (WebInspector.ResourcesPanel.prototype.filter): (WebInspector.ResourcesPanel.prototype._updateFilter): (WebInspector.ResourcesPanel.prototype._updateDividersLabelBarPosition): (WebInspector.ResourcesPanel.prototype.get needsRefresh): (WebInspector.ResourcesPanel.prototype.set needsRefresh): (WebInspector.ResourcesPanel.prototype.refreshIfNeeded): (WebInspector.ResourcesPanel.prototype.resize): (WebInspector.ResourcesPanel.prototype.invalidateAllItems): (WebInspector.ResourcesPanel.prototype.get calculator): (WebInspector.ResourcesPanel.prototype.set calculator): (WebInspector.ResourcesPanel.prototype.addItem): (WebInspector.ResourcesPanel.prototype.removeItem): (WebInspector.ResourcesPanel.prototype.refreshItem): (WebInspector.ResourcesPanel.prototype.revealAndSelectItem): (WebInspector.ResourcesPanel.prototype.sortItems): (WebInspector.ResourcesPanel.prototype.adjustScrollPosition): (WebInspector.ResourcesPanel.prototype.addEventDivider): (WebInspector.ResourcesPanel.prototype.hideEventDividers): (WebInspector.ResourcesPanel.prototype.showEventDividers): (WebInspector.ResourcesPanel.prototype.show): (WebInspector.ResourcesPanel.prototype.refresh): (WebInspector.ResourcesPanel.prototype.reset): (WebInspector.ResourcesPanel.prototype.updateGraphDividersIfNeeded): (WebInspector.ResourcesPanel.prototype.updateMainViewWidth): (WebInspector.ResourceBaseCalculator): (WebInspector.ResourceBaseCalculator.prototype.computeSummaryValues): (WebInspector.ResourceBaseCalculator.prototype.computeBarGraphPercentages): (WebInspector.ResourceBaseCalculator.prototype.computeBarGraphLabels): (WebInspector.ResourceBaseCalculator.prototype.get boundarySpan): (WebInspector.ResourceBaseCalculator.prototype.updateBoundaries): (WebInspector.ResourceBaseCalculator.prototype.reset): (WebInspector.ResourceBaseCalculator.prototype._value): (WebInspector.ResourceBaseCalculator.prototype.formatValue): (WebInspector.ResourceTimeCalculator): (WebInspector.ResourceTransferSizeCalculator):
  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.html:
8:56 AM Changeset in webkit [68393] by diegohcg@webkit.org
  • 3 edits
    1 move in trunk/WebCore

2010-09-27 Ragner Magalhaes <ragner.magalhaes@openbossa.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] New input style for Qt Mobile theme
https://bugs.webkit.org/show_bug.cgi?id=46461

Rename themeQtMaemo5.css to themeQtMobile.css since it is the theme for all Qt mobile platform.
Adjust new input style.

  • WebCore.pri:
  • css/themeQtMobile.css: Renamed from css/themeQtMaemo5.css (select): (select:disabled): (select:active): (select:active:disabled): (textarea): (textarea:disabled): (textarea:active):
  • platform/qt/RenderThemeQt.cpp: (WebCore::RenderThemeQt::extraDefaultStyleSheet): Renamed themeQtMaemo5UserAgentStyleSheet to themeQtMobileUserAgentStyleSheet to match renamed file.
8:19 AM Changeset in webkit [68392] by weinig@apple.com
  • 2 edits in trunk/WebKit2

Opening links in a new window asserts while decoding decidePolicyForNewWindowAction.
<rdar://problem/8479445>
https://bugs.webkit.org/show_bug.cgi?id=46623

Reviewed by Adam Roben.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didReceiveMessage): Fix the order of decoding to
match the order of encoding. (Swapping url and mouseButton).

8:12 AM Changeset in webkit [68391] by Adam Roben
  • 6 edits in trunk/WebKit2

Stop leaking the web process's process handle on Windows

Fixes <http://webkit.org/b/46133> <rdar://problem/8455343>

Reviewed by Anders Carlsson.

  • UIProcess/Launcher/ProcessLauncher.cpp:

(WebKit::ProcessLauncher::invalidate): Call platformInvalidate.

  • UIProcess/Launcher/ProcessLauncher.h: Added platformInvalidate.
  • UIProcess/Launcher/mac/ProcessLauncherMac.mm:

(WebKit::ProcessLauncher::platformInvalidate):

  • UIProcess/Launcher/qt/ProcessLauncherQt.cpp:

(WebKit::ProcessLauncher::platformInvalidate):
Stubbed out.

  • UIProcess/Launcher/win/ProcessLauncherWin.cpp:

(WebKit::ProcessLauncher::platformInvalidate): Close the process
handle like MSDN says we should.

7:54 AM Changeset in webkit [68390] by Girish Ramakrishnan
  • 8 edits in trunk

2010-09-27 Girish Ramakrishnan <Girish Ramakrishnan>

Reviewed by Antonio Gomes.

[Qt] Enable local rendering of NPAPI plugins on Maemo6.

https://bugs.webkit.org/show_bug.cgi?id=46618

  • WebCore.pro:
  • bridge/npapi.h:
  • plugins/PluginView.cpp: (WebCore::PluginView::setValue): (WebCore::PluginView::PluginView):
  • plugins/PluginView.h:
  • plugins/qt/PluginViewQt.cpp: (WebCore::PluginView::updatePluginWidget): (WebCore::PluginView::paint): (WebCore::PluginView::platformGetValueStatic):
  • WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::createPlugin):
6:59 AM Changeset in webkit [68389] by loislo@chromium.org
  • 3 edits in trunk/WebCore

2010-09-27 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: divide InspectorTimelineAgent into two parts.

We have an idea to split InspectorTimelineAgent into two parts.
The first part is an instrumentation API which can be used for DOM breakpoints too.
The other is the real Timeline agent which do a transformation of raw data into timeline data.

https://bugs.webkit.org/show_bug.cgi?id=46611

  • inspector/InspectorTimelineAgent.cpp: (WebCore::InspectorTimelineAgent2::TimelineRecordEntry::TimelineRecordEntry): (WebCore::InspectorTimelineAgent2::GCEvent::GCEvent): (WebCore::InspectorTimelineAgent2::InspectorTimelineAgent2): (WebCore::InspectorTimelineAgent2::~InspectorTimelineAgent2): (WebCore::InspectorTimelineAgent2::didGC): (WebCore::InspectorTimelineAgent2::addRecordToTimeline): (WebCore::InspectorTimelineAgent2::setHeapSizeStatistic): (WebCore::InspectorTimelineAgent2::startNewRecord): (WebCore::InspectorTimelineAgent2::completeCurrentRecord): (WebCore::InspectorTimelineAgent2::asyncRecord): (WebCore::InspectorTimelineAgent2::atomicRecord): (WebCore::InspectorTimelineAgent2::getTopRecordData): (WebCore::InspectorTimelineAgent2::reset): (WebCore::InspectorTimelineAgent2::resetFrontendProxyObject): (WebCore::InspectorTimelineAgent2::pushGCEventRecords): (WebCore::InspectorTimelineAgent::InspectorTimelineAgent): (WebCore::InspectorTimelineAgent::~InspectorTimelineAgent): (WebCore::InspectorTimelineAgent::reset): (WebCore::InspectorTimelineAgent::willCallFunction): (WebCore::InspectorTimelineAgent::didCallFunction): (WebCore::InspectorTimelineAgent::willDispatchEvent): (WebCore::InspectorTimelineAgent::didDispatchEvent): (WebCore::InspectorTimelineAgent::willLayout): (WebCore::InspectorTimelineAgent::didLayout): (WebCore::InspectorTimelineAgent::willRecalculateStyle): (WebCore::InspectorTimelineAgent::didRecalculateStyle): (WebCore::InspectorTimelineAgent::willPaint): (WebCore::InspectorTimelineAgent::didPaint): (WebCore::InspectorTimelineAgent::willWriteHTML): (WebCore::InspectorTimelineAgent::didWriteHTML): (WebCore::InspectorTimelineAgent::didInstallTimer): (WebCore::InspectorTimelineAgent::didRemoveTimer): (WebCore::InspectorTimelineAgent::willFireTimer): (WebCore::InspectorTimelineAgent::didFireTimer): (WebCore::InspectorTimelineAgent::willChangeXHRReadyState): (WebCore::InspectorTimelineAgent::didChangeXHRReadyState): (WebCore::InspectorTimelineAgent::willLoadXHR): (WebCore::InspectorTimelineAgent::didLoadXHR): (WebCore::InspectorTimelineAgent::willEvaluateScript): (WebCore::InspectorTimelineAgent::didEvaluateScript): (WebCore::InspectorTimelineAgent::didScheduleResourceRequest): (WebCore::InspectorTimelineAgent::willSendResourceRequest): (WebCore::InspectorTimelineAgent::willReceiveResourceData): (WebCore::InspectorTimelineAgent::didReceiveResourceData): (WebCore::InspectorTimelineAgent::willReceiveResourceResponse): (WebCore::InspectorTimelineAgent::didReceiveResourceResponse): (WebCore::InspectorTimelineAgent::didFinishLoadingResource): (WebCore::InspectorTimelineAgent::didMarkTimeline): (WebCore::InspectorTimelineAgent::didMarkDOMContentEvent): (WebCore::InspectorTimelineAgent::didMarkLoadEvent): (WebCore::InspectorTimelineAgent::resetFrontendProxyObject):
  • inspector/InspectorTimelineAgent.h:
6:36 AM Changeset in webkit [68388] by apavlov@chromium.org
  • 6 edits
    2 adds in trunk

2010-09-27 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Sam Weinig.

Implement CSSStyleRule::setSelectorText()

This involves removing the "selectorText" "setter raises(DOMException)" clause from the IDL files,
since the setter no longer raises the exception, as per http://dev.w3.org/csswg/cssom/#dom-cssstylerule-selectortext
https://bugs.webkit.org/show_bug.cgi?id=46487

Test: fast/css/css-set-selector-text.html

WebCore:

  • css/CSSPageRule.idl:
  • css/CSSStyleRule.cpp: (WebCore::CSSStyleRule::setSelectorText):
  • css/CSSStyleRule.h:
  • css/CSSStyleRule.idl:

LayoutTests:

  • fast/css/css-set-selector-text-expected.txt: Added.
  • fast/css/css-set-selector-text.html: Added.
6:28 AM Changeset in webkit [68387] by Adam Roben
  • 3 edits in trunk/WebKit2

Don't double-free CERT_CONTEXTs when copying PlatformCertificateInfos on Windows

Fixes <http://webkit.org/b/46536> <rdar://problem/8477292> REGRESSION
(r68260): Crash in PlatformCertificateInfo::~PlatformCertificateInfo
when navigating away from Gmail

Reviewed by Sam Weinig.

  • Shared/win/PlatformCertificateInfo.cpp:

(WebKit::PlatformCertificateInfo::PlatformCertificateInfo):
(WebKit::PlatformCertificateInfo::operator=):

  • Shared/win/PlatformCertificateInfo.h:

Added a copy constructor and assigment operator to handle correctly
reffing/dereffing the CERT_CONTEXTs when copying a
PlatformCertificateInfo.

6:09 AM Changeset in webkit [68386] by caseq@chromium.org
  • 2 edits
    1 copy
    2 adds in trunk/LayoutTests

2010-09-27 Andrey Kosyakov <caseq@chromium.org>

Unreviewed. Updated chromium expectations for ifast/block/basic/016.html (mac expectations changed in r68362)

  • platform/chromium-linux/fast/block/basic/016-expected.txt: Added.
  • platform/chromium-mac/fast/block/basic/016-expected.checksum: Added.
  • platform/chromium-win/fast/block/basic/016-expected.txt:
5:55 AM Changeset in webkit [68385] by zherczeg@webkit.org
  • 5 edits in trunk/WebCore

Filter builder should be able to follow the filter object dependencies
https://bugs.webkit.org/show_bug.cgi?id=45812

Reviewed by Dirk Schulze.

To propagate the changes of a primitive object, a data structure
is needed which stores the dependent primitive objects. (Those
who use the resulting image.) This data structure is implemented
as a hash map, which contains primitive object and set of primitive
objects <key,value> pairs. The hash map is able to follow the
dynamic topology changes.

  • rendering/RenderSVGResourceFilter.cpp:

(WebCore::RenderSVGResourceFilter::buildPrimitives):

  • rendering/RenderSVGResourceFilterPrimitive.h:

(WebCore::RenderSVGResourceFilterPrimitive::renderName):
(WebCore::RenderSVGResourceFilterPrimitive::isSVGResourceFilterPrimitive):

  • svg/graphics/filters/SVGFilterBuilder.cpp:

(WebCore::SVGFilterBuilder::SVGFilterBuilder):
(WebCore::SVGFilterBuilder::appendEffectToEffectReferences):
(WebCore::SVGFilterBuilder::clearEffects):

  • svg/graphics/filters/SVGFilterBuilder.h:

(WebCore::SVGFilterBuilder::getEffectReferences):
(WebCore::SVGFilterBuilder::addBuiltinEffects):

5:31 AM Changeset in webkit [68384] by caseq@chromium.org
  • 2 edits in trunk/WebKit/win

2010-09-27 Andrey Kosyakov <caseq@chromium.org>

Unreviewed build fix (win; broken in r68371)

  • WebFrame.cpp: remove include <WebCore/ResourceHandleWin.h>
5:20 AM Changeset in webkit [68383] by caseq@chromium.org
  • 1 edit
    30 adds in trunk/LayoutTests

2010-09-27 Andrey Kosyakov <caseq@chromium.org>

Unreviewed. Added chromium expectations for SVGFEBlendElement* tests.

  • platform/chromium-linux/svg/dynamic-updates/SVGFEBlendElement-dom-in-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEBlendElement-dom-in-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEBlendElement-dom-in2-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEBlendElement-dom-in2-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEBlendElement-dom-mode-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEBlendElement-dom-mode-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEBlendElement-svgdom-in-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEBlendElement-svgdom-in-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEBlendElement-svgdom-in2-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEBlendElement-svgdom-in2-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEBlendElement-svgdom-mode-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEBlendElement-svgdom-mode-prop-expected.png: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEBlendElement-dom-in-attr-expected.checksum: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEBlendElement-dom-in2-attr-expected.checksum: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEBlendElement-dom-mode-attr-expected.checksum: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEBlendElement-svgdom-in-prop-expected.checksum: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEBlendElement-svgdom-in2-prop-expected.checksum: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEBlendElement-svgdom-mode-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEBlendElement-dom-in-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEBlendElement-dom-in-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEBlendElement-dom-in2-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEBlendElement-dom-in2-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEBlendElement-dom-mode-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEBlendElement-dom-mode-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEBlendElement-svgdom-in-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEBlendElement-svgdom-in-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEBlendElement-svgdom-in2-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEBlendElement-svgdom-in2-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEBlendElement-svgdom-mode-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEBlendElement-svgdom-mode-prop-expected.png: Added.
4:48 AM Changeset in webkit [68382] by benjamin.poulain@nokia.com
  • 2 edits in trunk/WebKit/qt

2010-09-27 Benjamin Poulain <benjamin.poulain@nokia.com>

Reviewed by Andreas Kling.

[Qt] tst_QWebFrame::popupFocus() randomly fail on MeeGo handset because the focus is not set on the window
https://bugs.webkit.org/show_bug.cgi?id=46617

This patch avoid the race condition by waiting for the window
to be mapped on screen before attempting any actions.

  • tests/qwebframe/tst_qwebframe.cpp:
4:45 AM Changeset in webkit [68381] by andreas.kling@nokia.com
  • 2 edits in trunk/WebCore

2010-09-27 Andreas Kling <andreas.kling@nokia.com>

Rubber-stamped by Kenneth Rohde Christiansen.

[Qt] 32-bit Flash crashes on repeated SetWindow calls
https://bugs.webkit.org/show_bug.cgi?id=46616

Re-enable PluginQuirkDontCallSetWindowMoreThanOnce for Qt on x86 Unix.

We incorrectly thought this was fixed in Flash 10, but it turns out it
was just never broken on 64-bit.

  • plugins/PluginPackage.cpp: (WebCore::PluginPackage::determineQuirks):
2:43 AM Changeset in webkit [68380] by Philippe Normand
  • 2 edits in trunk/LayoutTests

2010-09-27 Philippe Normand <pnormand@igalia.com>

Unreviewed, unskip fixed test. See also r68126

  • platform/gtk/Skipped: Unskip media/video-controls-with-mutation-event-handler.html
2:38 AM Changeset in webkit [68379] by zecke@webkit.org
  • 2 edits in trunk/JavaScriptCore

jsc: Document the strcat opcode.

https://bugs.webkit.org/show_bug.cgi?id=46571

2:30 AM Changeset in webkit [68378] by zecke@webkit.org
  • 2 edits in trunk/JavaScriptCore

make-bytecode-docs.pl: Add a comment to the generated HTML

https://bugs.webkit.org/show_bug.cgi?id=46570

Generate an HTML Comment that this file was generated from
Interpreter.cpp with the make-bytecode-docs.pl script.

2:00 AM Changeset in webkit [68377] by andreas.kling@nokia.com
  • 2 edits in trunk/WebCore

2010-09-27 İsmail Dönmez <ismail@namtrac.org>

Reviewed by Andreas Kling.

Add PluginView::setJavaScriptPaused(bool) stub for WinCE.

  • platform/qt/TemporaryLinkStubsQt.cpp: (PluginView::setJavaScriptPaused):
1:25 AM Changeset in webkit [68376] by commit-queue@webkit.org
  • 2 edits
    1 add in trunk/LayoutTests

2010-09-27 James Kozianski <koz@chromium.org>

Reviewed by Adam Barth.

[Chromium] fast/dom/anchor-origin.html failing since r68354
https://bugs.webkit.org/show_bug.cgi?id=46597

Adding expectations needed for Chrome due to URL parsing differences
between KURL and GURL. Once a spec for URL parsing is defined we can
update these expectations to conform to it.

  • platform/chromium/fast/dom/anchor-origin-expected.txt: Added.
1:06 AM Changeset in webkit [68375] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-09-27 Gyuyoung Kim <gyuyoung.kim@samsung.com>

Reviewed by Dirk Schulze.

Bug 46607 - [WML] Fix a build break when WML is enabled

Fix a build break when WML is enabled.

  • wml/WMLElement.cpp: Include HTMLParserIdioms.h (WebCore::WMLElement::parseMappedAttribute): Add additional parameter to invoke parseHTMLInteger() function.
12:04 AM Changeset in webkit [68374] by Patrick Gansterer
  • 3 edits in trunk/JavaScriptCore

2010-09-27 Patrick Gansterer <Patrick Gansterer>

Reviewed by Adam Barth.

Remove WTF::stringHash functions
https://bugs.webkit.org/show_bug.cgi?id=46520

Since r68289 the stringHash functions are only wrappers around StringHasher::createHash.
So use StringHasher::createHash directly and remove stringHash.

  • wtf/StringHashFunctions.h:
  • wtf/text/StringImpl.h: (WTF::StringImpl::computeHash): Use WTF::StringHasher::createHash directly.

Sep 26, 2010:

11:24 PM Changeset in webkit [68373] by commit-queue@webkit.org
  • 4 edits
    4 adds in trunk

2010-09-26 Jenn Braithwaite <jennb@chromium.org>

Reviewed by Adam Barth.

GTK client needs updating when live iframe element is moved
between pages.
https://bugs.webkit.org/show_bug.cgi?id=46300

This test case fails on mac (see related bug 44713), which will
be fixed in a separate patch.

  • fast/frames/iframe-reparenting-adopt-node-expected.txt: Added.
  • fast/frames/iframe-reparenting-adopt-node.html: Added.
  • fast/frames/resources/iframe-reparenting-adopt-node-iframe-content.html: Added.
  • fast/frames/resources/iframe-reparenting-adopt-node-new-page.html: Added.
  • platform/mac/Skipped:

2010-09-26 Jenn Braithwaite <jennb@chromium.org>

Reviewed by Adam Barth.

GTK client needs updating when live iframe element is moved
between pages.
https://bugs.webkit.org/show_bug.cgi?id=46300

Test: fast/frames/iframe-reparenting-adopt-node.html

  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::didTransferChildFrameToNewDocument): Update the webView for the frame to match the parent frame's webView.
11:11 PM Changeset in webkit [68372] by victorw@chromium.org
  • 3 edits
    2 deletes in trunk/LayoutTests

2010-09-26 Victor Wang <victorw@chromium.org>

Reviewed by Adam Barth.

Update layout test notification-replace.html to be platform independent.

This layout test fails on windows if it is not running from C drive.
This is caused by local icon urls used by the test and this makes the
test becomes platform dependent. Change the icon urls so that the test
results are same for all platforms.

https://bugs.webkit.org/show_bug.cgi?id=45824

  • fast/notifications/notifications-replace-expected.txt:
  • fast/notifications/notifications-replace.html:
  • platform/chromium-linux/fast/notifications: Removed.
  • platform/chromium-linux/fast/notifications/notifications-replace-expected.txt: Removed.
  • platform/chromium-win/fast/notifications: Removed.
  • platform/chromium-win/fast/notifications/notifications-replace-expected.txt: Removed.
11:05 PM Changeset in webkit [68371] by Patrick Gansterer
  • 4 edits
    1 delete in trunk/WebCore

2010-09-26 Patrick Gansterer <Patrick Gansterer>

Reviewed by Adam Barth.

Remove dead code and fix header includes in ResourceHandleWin
https://bugs.webkit.org/show_bug.cgi?id=46479

Also add missing member varibale from r68167.

  • platform/network/ResourceHandle.h:
  • platform/network/ResourceHandleInternal.h: (WebCore::ResourceHandleInternal::ResourceHandleInternal):
  • platform/network/win/ResourceHandleWin.cpp: (WebCore::ResourceHandleInternal::~ResourceHandleInternal): (WebCore::ResourceHandle::~ResourceHandle): (WebCore::ResourceHandle::onRequestComplete):
  • platform/network/win/ResourceHandleWin.h: Removed.
10:59 PM Changeset in webkit [68370] by andreip@google.com
  • 2 edits in trunk/LayoutTests

2010-09-26 Andrei Popescu <andreip@google.com>

Reviewed by Adam Barth.

[Chromium] storage/indexeddb/transaction-basics.html is expected to fail but actually passes.
https://bugs.webkit.org/show_bug.cgi?id=46484

  • platform/chromium/test_expectations.txt:
10:28 PM Changeset in webkit [68369] by Patrick Gansterer
  • 5 edits in trunk

2010-09-26 Patrick Gansterer <Patrick Gansterer>

Reviewed by Adam Barth.

Add WTF::StringHasher::createBlobHash
https://bugs.webkit.org/show_bug.cgi?id=46514

Add this function for hashing FormElementKey and QualifiedNameComponents.

  • wtf/StringHashFunctions.h: (WTF::StringHasher::createBlobHash):

2010-09-26 Patrick Gansterer <Patrick Gansterer>

Reviewed by Adam Barth.

Add WTF::StringHasher::createBlobHash
https://bugs.webkit.org/show_bug.cgi?id=46514

Add this function for hashing FormElementKey and QualifiedNameComponents.

  • dom/Document.cpp: (WebCore::FormElementKeyHash::hash):
  • dom/QualifiedName.h: (WebCore::hashComponents): (WebCore::QualifiedNameHash::hash):
10:09 PM Changeset in webkit [68368] by Patrick Gansterer
  • 2 edits in trunk/JavaScriptCore

2010-09-26 Patrick Gansterer <Patrick Gansterer>

Reviewed by Adam Barth.

REGRESSION (r68289): Assertion failure in StringHasher::addCharacter() (ch != invalidCharacterValue)
running websocket/tests/bad-sub-protocol-non-ascii.html
https://bugs.webkit.org/show_bug.cgi?id=46553

Because we use StringHasher for binary data too, so the check for invalid unicode input is wrong.
Add an additional member variable to indicate if we have an pending character
instead of only using an invalid character for this purpose.

  • wtf/StringHashFunctions.h: (WTF::StringHasher::StringHasher): (WTF::StringHasher::addCharacters): (WTF::StringHasher::addCharacter): (WTF::StringHasher::hash):
9:56 PM Changeset in webkit [68367] by mihaip@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-09-26 Mihai Parparita <mihaip@chromium.org>

Reviewed by Adam Barth.

[Chromium] Remove no longer used WebView member functions
https://bugs.webkit.org/show_bug.cgi?id=46515

With http://crrev.com/60526 there's no longer any Chromium code calling
the non-static versions of addUserScript and addUserStyleSheet.

  • public/WebView.h:
9:35 PM Changeset in webkit [68366] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

2010-09-26 Shane Stephens <shanestephens@google.com>

Reviewed by Adam Barth.

[Chromium] Test expectations update to green canary bots.
https://bugs.webkit.org/show_bug.cgi?id=46604

https://bugs.webkit.org/show_bug.cgi?id=46596 and
https://bugs.webkit.org/show_bug.cgi?id=46597

  • platform/chromium/test_expectations.txt:
7:58 PM Changeset in webkit [68365] by mihaip@chromium.org
  • 3 edits in trunk/WebKitTools

2010-09-26 Mihai Parparita <mihaip@chromium.org>

Reviewed by Ojan Vafai.

new-run-webkit-httpd fails if Perl is not installed
https://bugs.webkit.org/show_bug.cgi?id=46602

Make Port._read_configuration catch all exceptions, since trying to run
perl (because of _webkit_build_directory) when it's not installed throws
a WindowsError or OSError, not an IOError (this became an issue after
r68268, since ChromiumPort ends up calling Port.default_configuration in
its constructor, which means that we're ending up on this codepath in
non-NRWT cases too, e.g. for the Chromium NaCl tests, which use
new-run-webkit-httpd).

  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/port/base_unittest.py:
7:53 PM Changeset in webkit [68364] by weinig@apple.com
  • 3 edits in trunk/WebKit2

MiniBrowser crashes when opening main menu item
https://bugs.webkit.org/show_bug.cgi?id=46588

Reviewed by Simon Fraser.

  • UIProcess/API/mac/PageClientImpl.mm:

(WebKit::PageClientImpl::setEditCommandState): Don't allow default
String -> NSString conversion to take place, and use the increasingly
misnamed nsStringFromWebCoreString instead.

7:43 PM Changeset in webkit [68363] by commit-queue@webkit.org
  • 5 edits in trunk

2010-09-26 Gyuyoung Kim <gyuyoung.kim@samsung.com>

Reviewed by Antonio Gomes.

[EFL] Add setting API to set a local storage database path.
https://bugs.webkit.org/show_bug.cgi?id=45446

Add a setting API to set local storage database path.

  • ewk/ewk_view.cpp: (_ewk_view_priv_new): (_ewk_view_priv_del): (ewk_view_setting_local_storage_database_path_get): Added. (ewk_view_setting_local_storage_database_path_set): Added.
  • ewk/ewk_view.h:

2010-09-26 Gyuyoung Kim <gyuyoung.kim@samsung.com>

Reviewed by Antonio Gomes.

[EFL] Add setting API to set a local storage database path.
https://bugs.webkit.org/show_bug.cgi?id=45446

Add a setting API to set local storage database path.

  • EWebLauncher/main.c: (on_key_down): (browserCreate): (main):
7:09 PM Changeset in webkit [68362] by hyatt@apple.com
  • 13 edits in trunk

https://bugs.webkit.org/show_bug.cgi?id=46519

Reviewed by Sam Weinig.

Convert the implementation of computeLogicalWidth to work with block-flow.

WebCore:

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::determineHorizontalPosition):
Patched to call the new computeMarginsInContainingBlockInlineDirection. Eventually determineHorizontalPosition will
be placing children along the inline direction of the containing block, and those children may have mismatched
block flows. The new computeMarginsInContainingBlockInlineDirection function is designed to handle that.

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::marginStart):
(WebCore::RenderBox::marginStartUsing):
(WebCore::RenderBox::marginEnd):
(WebCore::RenderBox::marginEndUsing):
(WebCore::RenderBox::setMarginStart):
(WebCore::RenderBox::setMarginEnd):
(WebCore::RenderBox::setMarginStartUsing):
(WebCore::RenderBox::setMarginEndUsing):
Helpers that allow for marginStart/End access and that also allow for marginStart/End to be computed based off another
element's block-flow and direction (typically the containing block).

(WebCore::RenderBox::computeBorderBoxLogicalWidth):
(WebCore::RenderBox::computeBorderBoxLogicalHeight):
(WebCore::RenderBox::computeContentBoxLogicalWidth):
(WebCore::RenderBox::computeContentBoxLogicalHeight):
Patched to use logical border/padding widths and heights.

(WebCore::RenderBox::perpendicularContainingBlockLogicalHeight):
A function for returning the available logical height of a perpendicular containing block. If a child has vertical
text for example and its block-flow is "lr", its available logical width is determined by the logical
height of the containing block when that containing block is perpendicular, e.g. "tb".

(WebCore::RenderBox::computeLogicalWidth):
(WebCore::RenderBox::computeLogicalWidthUsing):
Patched to be block-flow-aware and to use logical width values everywhere.

(WebCore::RenderBox::sizesToIntrinsicLogicalWidth):
Patched to use logical widths.

(WebCore::RenderBox::computeMarginsInContainingBlockInlineDirection):
A new function that is directionally abstract and that can handle the computation of margins in the containing
block's inline direction. This function is written such that a perpendicular child block flow can still be
pushed to the center, left or right in the containing block's inline direction.

(WebCore::RenderBox::computePositionedLogicalWidth):
This function is still largely unpatched. A future patch will address positioend elements.

  • rendering/RenderBox.h:

(WebCore::RenderBox::stretchesToMinIntrinsicLogicalWidth):

  • rendering/RenderFieldset.h:

(WebCore::RenderFieldset::stretchesToMinIntrinsicLogicalWidth):
Renames.

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::computeLogicalWidth):
Renames, but not converted yet. Tables will happen in a future patch.

  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::marginStartUsing):
(WebCore::RenderStyle::marginEndUsing):

  • rendering/style/RenderStyle.h:

Added helpers for accessing marginStart and End using another style's direction and block flow (typically will
be the containing block's).

fast/block/basic/016.html changed, since centering now always awards the extra pixel for odd widths to the end margin
instead of the right margin. This is a progression.

fast/css/logical-property-values.html is now reporting garbage results, which is expected now that some of the core layout
functions have been patched.

Horizontal block flows are untestable still, since the normal layout process incorrectly blows away any computed height values.

LayoutTests:

  • fast/css/logical-property-resolution-expected.txt:
  • platform/mac/fast/block/basic/016-expected.checksum:
  • platform/mac/fast/block/basic/016-expected.png:
  • platform/mac/fast/block/basic/016-expected.txt:
6:56 PM Changeset in webkit [68361] by weinig@apple.com
  • 2 edits in trunk/WebKit2

Another windows build fix windows attempt.

  • win/WebKit2Common.vsprops:
6:47 PM Changeset in webkit [68360] by weinig@apple.com
  • 2 edits in trunk/WebKit2

Another windows build fix windows attempt.

  • win/WebKit2Generated.make:
6:34 PM Changeset in webkit [68359] by weinig@apple.com
  • 2 edits in trunk/WebKit2

Attempt to fix windows build.

  • win/WebKit2Common.vsprops:
6:31 PM Changeset in webkit [68358] by weinig@apple.com
  • 2 edits in trunk/WebKit2

Attempt to fix Qt build.

  • WebKit2.pro:
6:22 PM Changeset in webkit [68357] by weinig@apple.com
  • 19 edits
    6 copies
    33 moves
    4 adds
    2 deletes in trunk

Move shared WebKit2 API (used by both bundle and main API) to WebKit2/Shared/API
https://bugs.webkit.org/show_bug.cgi?id=46587

Reviewed by Anders Carlsson.

WebKit2:

  • Moves shared types (WKArrayRef, WKDictionaryRef, etc) to Shared/API/c.
  • Removes WKBundleBase.h and moves all opaque type declarations to WKBase.h (which moves to Shared/API/c).
  • Adds WKSharedAPICast.h which includes shared API casting logic and is included by both WKAPICast.h and WKBundleAPICast.h now. Moved to using macros for API mappings to reduce verbosity.
  • Move windows c API files from UIProcess/API/win to UIProcess/API/C/win.
  • Shared/API: Added.
  • Shared/API/c: Added.
  • Shared/API/c/WKArray.cpp: Copied from UIProcess/API/C/WKArray.cpp.
  • Shared/API/c/WKArray.h: Copied from UIProcess/API/C/WKArray.h.
  • Shared/API/c/WKBase.h: Copied from UIProcess/API/C/WKBase.h.
  • Shared/API/c/WKCertificateInfo.cpp: Copied from UIProcess/API/C/WKCertificateInfo.cpp.
  • Shared/API/c/WKCertificateInfo.h: Copied from UIProcess/API/C/WKCertificateInfo.h.
  • Shared/API/c/WKData.cpp: Copied from UIProcess/API/C/WKData.cpp.
  • Shared/API/c/WKData.h: Copied from UIProcess/API/C/WKData.h.
  • Shared/API/c/WKDictionary.cpp: Copied from UIProcess/API/C/WKDictionary.cpp.
  • Shared/API/c/WKDictionary.h: Copied from UIProcess/API/C/WKDictionary.h.
  • Shared/API/c/WKError.cpp: Copied from UIProcess/API/C/WKError.cpp.
  • Shared/API/c/WKError.h: Copied from UIProcess/API/C/WKError.h.
  • Shared/API/c/WKMutableArray.cpp: Copied from UIProcess/API/C/WKMutableArray.cpp.
  • Shared/API/c/WKMutableArray.h: Copied from UIProcess/API/C/WKMutableArray.h.
  • Shared/API/c/WKMutableDictionary.cpp: Copied from UIProcess/API/C/WKMutableDictionary.cpp.
  • Shared/API/c/WKMutableDictionary.h: Copied from UIProcess/API/C/WKMutableDictionary.h.
  • Shared/API/c/WKNumber.cpp: Copied from UIProcess/API/C/WKNumber.cpp.
  • Shared/API/c/WKNumber.h: Copied from UIProcess/API/C/WKNumber.h.
  • Shared/API/c/WKSerializedScriptValue.cpp: Copied from UIProcess/API/C/WKSerializedScriptValue.cpp.
  • Shared/API/c/WKSerializedScriptValue.h: Copied from UIProcess/API/C/WKSerializedScriptValue.h.
  • Shared/API/c/WKSharedAPICast.h: Copied from UIProcess/API/C/WKAPICast.h.
  • Shared/API/c/WKString.cpp: Copied from UIProcess/API/C/WKString.cpp.
  • Shared/API/c/WKString.h: Copied from UIProcess/API/C/WKString.h.
  • Shared/API/c/WKType.cpp: Copied from UIProcess/API/C/WKType.cpp.
  • Shared/API/c/WKType.h: Copied from UIProcess/API/C/WKType.h.
  • Shared/API/c/WKURL.cpp: Copied from UIProcess/API/C/WKURL.cpp.
  • Shared/API/c/WKURL.h: Copied from UIProcess/API/C/WKURL.h.
  • Shared/API/c/WKURLRequest.cpp: Copied from UIProcess/API/C/WKURLRequest.cpp.
  • Shared/API/c/WKURLRequest.h: Copied from UIProcess/API/C/WKURLRequest.h.
  • Shared/API/c/WKURLResponse.cpp: Copied from UIProcess/API/C/WKURLResponse.cpp.
  • Shared/API/c/WKURLResponse.h: Copied from UIProcess/API/C/WKURLResponse.h.
  • Shared/API/c/cf: Copied from UIProcess/API/C/cf.
  • Shared/API/c/mac: Copied from UIProcess/API/C/mac.
  • Shared/API/c/win: Added.
  • Shared/API/c/win/WKBaseWin.h: Copied from UIProcess/API/win/WKBaseWin.h.
  • Shared/API/c/win/WKCertificateInfoWin.cpp: Copied from UIProcess/API/C/win/WKCertificateInfoWin.cpp.
  • Shared/API/c/win/WKCertificateInfoWin.h: Copied from UIProcess/API/C/win/WKCertificateInfoWin.h.
  • UIProcess/API/C/WKAPICast.h: Replaced.
  • UIProcess/API/C/WKArray.cpp: Removed.
  • UIProcess/API/C/WKArray.h: Removed.
  • UIProcess/API/C/WKBase.h: Removed.
  • UIProcess/API/C/WKCertificateInfo.cpp: Removed.
  • UIProcess/API/C/WKCertificateInfo.h: Removed.
  • UIProcess/API/C/WKData.cpp: Removed.
  • UIProcess/API/C/WKData.h: Removed.
  • UIProcess/API/C/WKDictionary.cpp: Removed.
  • UIProcess/API/C/WKDictionary.h: Removed.
  • UIProcess/API/C/WKError.cpp: Removed.
  • UIProcess/API/C/WKError.h: Removed.
  • UIProcess/API/C/WKMutableArray.cpp: Removed.
  • UIProcess/API/C/WKMutableArray.h: Removed.
  • UIProcess/API/C/WKMutableDictionary.cpp: Removed.
  • UIProcess/API/C/WKMutableDictionary.h: Removed.
  • UIProcess/API/C/WKNumber.cpp: Removed.
  • UIProcess/API/C/WKNumber.h: Removed.
  • UIProcess/API/C/WKSerializedScriptValue.cpp: Removed.
  • UIProcess/API/C/WKSerializedScriptValue.h: Removed.
  • UIProcess/API/C/WKString.cpp: Removed.
  • UIProcess/API/C/WKString.h: Removed.
  • UIProcess/API/C/WKType.cpp: Removed.
  • UIProcess/API/C/WKType.h: Removed.
  • UIProcess/API/C/WKURL.cpp: Removed.
  • UIProcess/API/C/WKURL.h: Removed.
  • UIProcess/API/C/WKURLRequest.cpp: Removed.
  • UIProcess/API/C/WKURLRequest.h: Removed.
  • UIProcess/API/C/WKURLResponse.cpp: Removed.
  • UIProcess/API/C/WKURLResponse.h: Removed.
  • UIProcess/API/C/cf: Removed.
  • UIProcess/API/C/cf/WKStringCF.cpp: Removed.
  • UIProcess/API/C/cf/WKStringCF.h: Removed.
  • UIProcess/API/C/cf/WKURLCF.cpp: Removed.
  • UIProcess/API/C/cf/WKURLCF.h: Removed.
  • UIProcess/API/C/cf/WKURLRequestCF.cpp: Removed.
  • UIProcess/API/C/cf/WKURLRequestCF.h: Removed.
  • UIProcess/API/C/cf/WKURLResponseCF.cpp: Removed.
  • UIProcess/API/C/cf/WKURLResponseCF.h: Removed.
  • UIProcess/API/C/mac: Removed.
  • UIProcess/API/C/mac/WKCertificateInfoMac.h: Removed.
  • UIProcess/API/C/mac/WKCertificateInfoMac.mm: Removed.
  • UIProcess/API/C/mac/WKURLRequestNS.h: Removed.
  • UIProcess/API/C/mac/WKURLRequestNS.mm: Removed.
  • UIProcess/API/C/mac/WKURLResponseNS.h: Removed.
  • UIProcess/API/C/mac/WKURLResponseNS.mm: Removed.
  • UIProcess/API/C/win/WKAPICastWin.h: Copied from UIProcess/API/win/WKAPICastWin.h.
  • UIProcess/API/C/win/WKBaseWin.h: Copied from UIProcess/API/win/WKBaseWin.h.
  • UIProcess/API/C/win/WKCertificateInfoWin.cpp: Removed.
  • UIProcess/API/C/win/WKCertificateInfoWin.h: Removed.
  • UIProcess/API/C/win/WKView.cpp: Copied from UIProcess/API/win/WKView.cpp.
  • UIProcess/API/C/win/WKView.h: Copied from UIProcess/API/win/WKView.h.
  • UIProcess/API/win: Removed.
  • UIProcess/API/win/WKAPICastWin.h: Removed.
  • UIProcess/API/win/WKBaseWin.h: Removed.
  • UIProcess/API/win/WKView.cpp: Removed.
  • UIProcess/API/win/WKView.h: Removed.
  • WebKit2.pro:
  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/InjectedBundle/API/c/WKBundle.h:
  • WebProcess/InjectedBundle/API/c/WKBundleAPICast.h:
  • WebProcess/InjectedBundle/API/c/WKBundleBase.h: Removed.
  • WebProcess/InjectedBundle/API/c/WKBundleFrame.h:
  • WebProcess/InjectedBundle/API/c/WKBundleFramePrivate.h:
  • WebProcess/InjectedBundle/API/c/WKBundleHitTestResult.h:
  • WebProcess/InjectedBundle/API/c/WKBundleInitialize.h:
  • WebProcess/InjectedBundle/API/c/WKBundleNodeHandle.h:
  • WebProcess/InjectedBundle/API/c/WKBundlePage.h:
  • WebProcess/InjectedBundle/API/c/WKBundlePagePrivate.h:
  • WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:
  • WebProcess/InjectedBundle/API/c/WKBundleRangeHandle.h:
  • WebProcess/InjectedBundle/API/c/WKBundleScriptWorld.h:
  • win/WebKit2.vcproj:
  • win/WebKit2Generated.make:

WebKitTools:

  • WebKitTestRunner/InjectedBundle/InjectedBundle.h:
5:23 PM Changeset in webkit [68356] by tonikitoo@webkit.org
  • 16 edits in trunk

[Mac][DRT] Implement LayoutTestController::nodesFromRect
https://bugs.webkit.org/show_bug.cgi?id=46580

Patch by Antonio Gomes <agomes@rim.comg> on 2010-09-26
Reviewed by Kenneth Christiansen.

WebCore:

Symbol files updated.

  • WebCore.exp.in: Added symbols to Document::nodesFromRect and bits of JSDocument now

needed in WebKit/mac.

  • WebCore.xcodeproj/project.pbxproj: Set both JSDocument.h and JSNodeList as private headers

now that they are referred in WebKit/mac.

WebKit/mac:

Implement nodesFromRect as a private method to access non-exposed Document
methods, similarly to computedStyleIncludingVisitedInfo.

  • WebView/WebView.mm: Added JSDocument.h and JSNodeList.h to the include list.

These headers makes it possible to:
1) Get a Document off of a JSDocument;
2) Call toJS function, defined in JSNodeList.cpp|h so we can convert RefPtr<NodeList>
gotten from Document::nodesFromRect to JS bindings.
(-[WebView _nodesFromRect:forDocument:x:y:hPadding:vPadding:ignoreClipping:]):

  • WebView/WebViewPrivate.h: Added nodesFromRect method to access methods of the

Document class not exposed to JavaScript. It works similarly to computedStyleIncludingVisitedInfo.

WebKitTools:

Implements LayoutTestController::nodesFromRect for Mac DRT, and
adding stubs for GTK+ and Windows.

  • DumpRenderTree/LayoutTestController.cpp:

(nodesFromRectCallback):
(LayoutTestController::staticFunctions):

  • DumpRenderTree/LayoutTestController.h:

(LayoutTestController::LayoutTestController::nodesFromRect):

  • DumpRenderTree/mac/LayoutTestControllerMac.mm:

(LayoutTestController::nodesFromRect):

LayoutTests:

Unskipping fast/dom/nodesFromRect-based.html on Mac, and changes it
so that it calls layoutTestController.nodesFromRect() instead of
document.nodesFromRect().

  • fast/dom/resources/nodesFromRect.js:

(check):

  • platform/mac/Skipped:
3:59 PM Changeset in webkit [68355] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

2010-09-26 Adam Barth <abarth@webkit.org>

Rebaseline Qt results.

  • platform/qt/fast/dom/Window/window-properties-expected.txt:
3:22 PM Changeset in webkit [68354] by abarth@webkit.org
  • 11 edits
    4 adds in trunk

2010-09-26 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

Implement location.origin and HTMLAnchorElement.origin
https://bugs.webkit.org/show_bug.cgi?id=46558

Test the origin attribute of Location and HTMLAnchorElement.

  • fast/dom/anchor-origin-expected.txt: Added.
  • fast/dom/anchor-origin.html: Added.
  • http/tests/misc/location-origin-expected.txt: Added.
  • http/tests/misc/location-origin.html: Added.

2010-09-26 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

Implement location.origin and HTMLAnchorElement.origin
https://bugs.webkit.org/show_bug.cgi?id=46558

These attributes are part of my proposed URL API:
https://docs.google.com/document/edit?id=1r_VTFKApVOaNIkocrg0z-t7lZgzisTuGTXkdzAk4gLU&hl=en

Hixie thought we should implement as much of this API as makes sense on
Location and HTMLAnchorElement as well. I'm starting with the origin
attribute, because that seems like the biggest bang for the buck.

Tests: fast/dom/anchor-origin.html

http/tests/misc/location-origin.html

  • WebCore.xcodeproj/project.pbxproj:
  • html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::origin):
  • html/HTMLAnchorElement.h:
  • html/HTMLAnchorElement.idl:
  • page/Location.cpp: (WebCore::Location::origin):
  • page/Location.h:
  • page/Location.idl:
3:11 PM Changeset in webkit [68353] by andersca@apple.com
  • 3 edits in trunk/WebKit2

Fix non-Mac builds.

  • Platform/SharedMemory.h:
  • Platform/mac/SharedMemoryMac.cpp:

(WebKit::SharedMemory::Handle::isNull):

2:48 PM Changeset in webkit [68352] by andersca@apple.com
  • 3 edits in trunk/WebKit2

Make it possible to encode null SharedMemory::Handle objects
https://bugs.webkit.org/show_bug.cgi?id=46585

Reviewed by Sam Weinig.

  • Platform/SharedMemory.h:

(WebKit::SharedMemory::Handle::isNull):
Add isNull.

  • Platform/mac/SharedMemoryMac.cpp:

(WebKit::SharedMemory::Handle::encode):
Remove asserts.

(WebKit::SharedMemory::create):
Bail if we see a null handle. Also work around a kernel bug where
mach_vm_map fails if the given address to map is already mapped, even if
VM_FLAG_ANYWHERE is set.

2:48 PM Changeset in webkit [68351] by andersca@apple.com
  • 2 edits
    3 adds in trunk/WebKit2

Add BackingStore class
https://bugs.webkit.org/show_bug.cgi?id=46584

Reviewed by Sam Weinig.

  • Shared/BackingStore.cpp: Added.

(WebKit::BackingStore::create):
Create a backing store backed by fastMalloc memory.

(WebKit::BackingStore::createSharable):
Create a backing store backed by shared memory.

(WebKit::BackingStore::createHandle):
Create a handle that can be sent over the wire.

(WebKit::BackingStore::resize):
Resize the backing store memory.

(WebKit::BackingStore::data):
Return the backing store data.

  • Shared/mac/BackingStoreMac.mm: Added.

(WebKit::BackingStore::createGraphicsContext):
Create a graphics context that will paint into the backing store.

(WebKit::BackingStore::paint):
Paint the backing store in a graphics context.

  • WebKit2.xcodeproj/project.pbxproj:

Add files.

2:48 PM Changeset in webkit [68350] by andersca@apple.com
  • 11 edits in trunk/WebKit2

Establish a connection between the plug-in process and the web process
https://bugs.webkit.org/show_bug.cgi?id=46583

Reviewed by Sam Weinig.

  • PluginProcess/PluginProcess.cpp:

(WebKit::PluginProcess::didReceiveMessage):
Call the auto-generated didReceivePluginProcessMessage.

  • PluginProcess/PluginProcess.h:

Add didReceivePluginProcessMessage declaration.

  • PluginProcess/PluginProcess.messages.in:

Add new "CreateWebProcessConnection" message.

  • PluginProcess/WebProcessConnection.cpp:

(WebKit::WebProcessConnection::didReceiveMessage):
(WebKit::WebProcessConnection::didReceiveSyncMessage):
(WebKit::WebProcessConnection::didClose):
(WebKit::WebProcessConnection::didReceiveInvalidMessage):
Add stubbed out member functions.

  • UIProcess/Plugins/PluginProcessManager.cpp:

(WebKit::PluginProcessManager::getPluginProcessConnection):
Ask the plug-in process proxy to create a connection.

  • UIProcess/Plugins/PluginProcessProxy.cpp:

(WebKit::PluginProcessProxy::createWebProcessConnection):
Add the WebProcessProxy and the reply encoder to the queue of pending replies.
If the process is still launching, keep track of how many pending requests we have, otherwise
just send the request.

(WebKit::PluginProcessProxy::didReceiveMessage):
Call the auto-generated didReceivePluginProcessMessage.

(WebKit::PluginProcessProxy::didFinishLaunching):
Send all pending connection requests.

(WebKit::PluginProcessProxy::didCreateWebProcessConnection):
Get the first pending reply and send it with the mach port.

  • WebKit2.xcodeproj/project.pbxproj:

Actually compile PluginProcessMessageReceiver.

  • WebProcess/Plugins/PluginProcessConnection.cpp:

(WebKit::PluginProcessConnection::PluginProcessConnection):
Create a CoreIPC connection.

(WebKit::PluginProcessConnection::didReceiveMessage):
(WebKit::PluginProcessConnection::didClose):
(WebKit::PluginProcessConnection::didReceiveInvalidMessage):
Add stubbed out member functions.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::createPlugin):
Ask the plug-in process connection manager for a connection.

2:47 PM Changeset in webkit [68349] by andersca@apple.com
  • 3 edits in trunk/WebKit2

Generated message handlers should include argument coder headers for some types
https://bugs.webkit.org/show_bug.cgi?id=46582

Reviewed by Sam Weinig.

  • Scripts/webkit2/messages.py:

When determining which headers to use when generating a message handler, consider the
argument coder headers.

  • Scripts/webkit2/messages_unittest.py:

Update test result.

2:38 PM Changeset in webkit [68348] by commit-queue@webkit.org
  • 5 edits in trunk

2010-09-26 Mark Hahnenberg <mhahnenb@gmail.com>

Reviewed by Oliver Hunt.

valueOf called in wrong order in atan2 and date constructors.
https://bugs.webkit.org/show_bug.cgi?id=26978

Fixed the bug where the arguments to atan2 were being evaluated
out of order.

  • runtime/MathObject.cpp: (JSC::mathProtoFuncATan2):

2010-09-26 Mark Hahnenberg <mhahnenb@gmail.com>

Reviewed by Oliver Hunt.

valueOf called in wrong order in atan2 and date constructors.
https://bugs.webkit.org/show_bug.cgi?id=26978

Regression test for the issue where the arguments to atan2 were
evaluated out of order.

  • fast/js/math-expected.txt:
  • fast/js/script-tests/math.js: (v.valueOf): (w.valueOf):
2:26 PM Changeset in webkit [68347] by commit-queue@webkit.org
  • 5 edits in trunk

2010-09-26 Mark Hahnenberg <mhahnenb@gmail.com>

Reviewed by Oliver Hunt.

valueOf called in wrong order in atan2 and date constructors.
https://bugs.webkit.org/show_bug.cgi?id=26978

Fixed the issue where the parameters to the Date constructor
were being evaluated to numbers more than once.

  • runtime/DateConstructor.cpp: (JSC::constructDate): (JSC::dateUTC):

2010-09-26 Mark Hahnenberg <mhahnenb@gmail.com>

Reviewed by Oliver Hunt.

valueOf called in wrong order in atan2 and date constructors.
https://bugs.webkit.org/show_bug.cgi?id=26978

Added regression test for the Date constructor issue.

  • fast/js/date-constructor-expected.txt:
  • fast/js/script-tests/date-constructor.js: (year.valueOf): (month.valueOf): (date.valueOf): (hours.valueOf): (minutes.valueOf): (seconds.valueOf): (ms.valueOf):
12:21 PM Changeset in webkit [68346] by andreas.kling@nokia.com
  • 3 edits
    3 deletes in trunk

2010-09-26 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r68343.
http://trac.webkit.org/changeset/68343
https://bugs.webkit.org/show_bug.cgi?id=46581

broke GTK+ (Requested by kling on #webkit).

  • html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::setFont):

2010-09-26 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r68343.
http://trac.webkit.org/changeset/68343
https://bugs.webkit.org/show_bug.cgi?id=46581

broke GTK+ (Requested by kling on #webkit).

  • fast/canvas/canvas-font-ex-units-crash-expected.txt: Removed.
  • fast/canvas/canvas-font-ex-units-crash.html: Removed.
  • fast/canvas/script-tests/canvas-font-ex-units-crash.js: Removed.
12:00 PM Changeset in webkit [68345] by tonikitoo@webkit.org
  • 9 edits in trunk

document.nodesFromRect() needs to be removed from Document.idl
https://bugs.webkit.org/show_bug.cgi?id=46492

Reviewed by Kenneth Christiansen and Andreas Kling.
Patch by Antonio Gomes <agomes@rim.com>

WebCore:

As discussed with Sam Weinig on IRC, it was decided to removed
nodesFromRect() from the Document.idl, and that way, not exposing
it to Web content.

Reason: there is no plan to make it standard at the moment, and at the
very least, the method should had been originally added with the "webkit"
prefix, which was not the case.

  • dom/Document.idl:

LayoutTests:

Skip the tests relying on document.nodesFromRect in all platform for
the moment, and adjusting the expected results tests also accordingly.

  • fast/dom/Window/window-properties-expected.txt:
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/qt/fast/dom/Window/window-properties-expected.txt:
  • platform/win/Skipped:
10:45 AM Changeset in webkit [68344] by commit-queue@webkit.org
  • 4 edits
    30 adds in trunk

2010-09-26 Renata Hodovan <reni@inf.u-szeged.hu>

Reviewed by Dirk Schulze.

SVGFEBlendElement doesn't support dynamic invalidation, when attributes change.
https://bugs.webkit.org/show_bug.cgi?id=46464
Adding layout tests for feBlend dynamic changes.

  • platform/mac/svg/dynamic-updates/SVGFEBlendElement-dom-in-attr-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFEBlendElement-dom-in-attr-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGFEBlendElement-dom-in2-attr-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFEBlendElement-dom-in2-attr-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGFEBlendElement-dom-mode-attr-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFEBlendElement-dom-mode-attr-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGFEBlendElement-svgdom-in-prop-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFEBlendElement-svgdom-in-prop-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGFEBlendElement-svgdom-in2-prop-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFEBlendElement-svgdom-in2-prop-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGFEBlendElement-svgdom-mode-prop-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFEBlendElement-svgdom-mode-prop-expected.png: Added.
  • svg/dynamic-updates/SVGFEBlendElement-dom-in-attr-expected.txt: Added.
  • svg/dynamic-updates/SVGFEBlendElement-dom-in-attr.html: Added.
  • svg/dynamic-updates/SVGFEBlendElement-dom-in2-attr-expected.txt: Added.
  • svg/dynamic-updates/SVGFEBlendElement-dom-in2-attr.html: Added.
  • svg/dynamic-updates/SVGFEBlendElement-dom-mode-attr-expected.txt: Added.
  • svg/dynamic-updates/SVGFEBlendElement-dom-mode-attr.html: Added.
  • svg/dynamic-updates/SVGFEBlendElement-svgdom-in-prop-expected.txt: Added.
  • svg/dynamic-updates/SVGFEBlendElement-svgdom-in-prop.html: Added.
  • svg/dynamic-updates/SVGFEBlendElement-svgdom-in2-prop-expected.txt: Added.
  • svg/dynamic-updates/SVGFEBlendElement-svgdom-in2-prop.html: Added.
  • svg/dynamic-updates/SVGFEBlendElement-svgdom-mode-prop-expected.txt: Added.
  • svg/dynamic-updates/SVGFEBlendElement-svgdom-mode-prop.html: Added.
  • svg/dynamic-updates/script-tests/SVGFEBlendElement-dom-in-attr.js: Added. (executeTest):
  • svg/dynamic-updates/script-tests/SVGFEBlendElement-dom-in2-attr.js: Added. (executeTest):
  • svg/dynamic-updates/script-tests/SVGFEBlendElement-dom-mode-attr.js: Added. (executeTest):
  • svg/dynamic-updates/script-tests/SVGFEBlendElement-svgdom-in-prop.js: Added. (executeTest):
  • svg/dynamic-updates/script-tests/SVGFEBlendElement-svgdom-in2-prop.js: Added. (executeTest):
  • svg/dynamic-updates/script-tests/SVGFEBlendElement-svgdom-mode-prop.js: Added. (executeTest):

2010-09-26 Renata Hodovan <reni@inf.u-szeged.hu>

Reviewed by Dirk Schulze.

SVGFEBlendElement doesn't support dynamic invalidation, when attributes change.
https://bugs.webkit.org/show_bug.cgi?id=46464

Tests: svg/dynamic-updates/SVGFEBlendElement-dom-in-attr.html

svg/dynamic-updates/SVGFEBlendElement-dom-in2-attr.html
svg/dynamic-updates/SVGFEBlendElement-dom-mode-attr.html
svg/dynamic-updates/SVGFEBlendElement-svgdom-in-prop.html
svg/dynamic-updates/SVGFEBlendElement-svgdom-in2-prop.html
svg/dynamic-updates/SVGFEBlendElement-svgdom-mode-prop.html

  • svg/SVGFEBlendElement.cpp: (WebCore::SVGFEBlendElement::svgAttributeChanged):
  • svg/SVGFEBlendElement.h:
10:39 AM Changeset in webkit [68343] by andreas.kling@nokia.com
  • 3 edits
    3 adds in trunk

2010-09-26 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Dan Bernstein.

Canvas: Crash when setting a font with size in 'ex' units
https://bugs.webkit.org/show_bug.cgi?id=46538

update() the style's font after setting the style's font description.
Needed because CSSPrimitiveValue::computeLengthDouble() later assumes
that the style's font is properly initialized (for xHeight().)

Fixes crash on IE test center's canvas-text-font-002 test.

  • html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::setFont):

2010-09-26 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Dan Bernstein.

Canvas: Crash when setting a font with size in 'ex' units
https://bugs.webkit.org/show_bug.cgi?id=46538

  • fast/canvas/canvas-font-ex-units-crash-expected.txt: Added.
  • fast/canvas/canvas-font-ex-units-crash.html: Added.
  • fast/canvas/script-tests/canvas-font-ex-units-crash.js: Added.
10:25 AM Changeset in webkit [68342] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-09-26 Kwang Yul Seo <skyul@company100.net>

Reviewed by Eric Seidel.

[BREWMP] Don't pass PassOwnPtr in makeAllDirectories
https://bugs.webkit.org/show_bug.cgi?id=42058

Change makeAllDirectories to take a raw FileMgr pointer
because it is not safe to pass PassOwnPtr recursively.

  • platform/brew/FileSystemBrew.cpp: (WebCore::makeAllDirectories):
6:12 AM Changeset in webkit [68341] by robert@webkit.org
  • 4 edits in trunk

2010-09-26 Robert Hogan <robert@webkit.org>

Reviewed by Andreas Kling.

[Qt] fix http/tests/uri/escaped-entity.html

Replace invalid encodings with the appropriate escaped entity.

See also http://bugreports.qt.nokia.com/browse/QTBUG-13412

https://bugs.webkit.org/show_bug.cgi?id=45245

  • platform/qt/Skipped:

2010-09-26 Robert Hogan <robert@webkit.org>

Reviewed by Andreas Kling.

[Qt] fix http/tests/uri/escaped-entity.html

Replace invalid encodings with the appropriate escaped entity.

See also http://bugreports.qt.nokia.com/browse/QTBUG-13412

https://bugs.webkit.org/show_bug.cgi?id=45245

  • platform/text/qt/TextCodecQt.cpp: (WebCore::TextCodecQt::encode):

Sep 25, 2010:

10:56 PM Changeset in webkit [68340] by inferno@chromium.org
  • 3 edits
    2 adds in trunk

2010-09-25 Abhishek Arya <inferno@chromium.org>

Reviewed by Nikolas Zimmermann.

Fix the macro to bail out after setting the SVG style to 'initial'. Check that color is
SVGColor before calling colorFromSVGColorCSSValue which makes sure we don't set invalid
color. Also, doing the static cast in the caller and keeping the function
colorFromSVGColorCSSValue clean to accept only take SVGColor objects.


https://bugs.webkit.org/show_bug.cgi?id=46471

Test: svg/css/invalid-color-crash.svg

  • css/SVGCSSStyleSelector.cpp: (WebCore::colorFromSVGColorCSSValue): (WebCore::CSSStyleSelector::applySVGProperty):

2010-09-25 Abhishek Arya <inferno@chromium.org>

Reviewed by Nikolas Zimmermann.

Tests that we dont crash when setting color to initial for SVG.
https://bugs.webkit.org/show_bug.cgi?id=46471

  • svg/css/invalid-color-crash-expected.txt: Added.
  • svg/css/invalid-color-crash.svg: Added.
3:57 PM Changeset in webkit [68339] by oliver@apple.com
  • 4 edits in trunk/JavaScriptCore

Relearning the lesson that last minute changes are bad.

2:42 PM Changeset in webkit [68338] by oliver@apple.com
  • 11 edits in trunk/JavaScriptCore

2010-09-25 Oliver Hunt <oliver@apple.com>

Reviewed by Cameron Zwarich.

Avoid constructing arguments object when accessing length and index properties
https://bugs.webkit.org/show_bug.cgi?id=46572

Add opcodes to read argument length and properties, and then implement them.
Much like other lazy opcodes these opcodes take a fast path when the arguments
object has not been instantiated, and fall back on generic access mechanisms
if they are acting on an instantiated object.

3% win on v8-earleyboyer, no change elsewhere.

  • bytecode/CodeBlock.cpp: (JSC::CodeBlock::dump):
  • bytecode/Opcode.h:
  • bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::emitGetArgumentsLength): (JSC::BytecodeGenerator::emitGetArgumentByVal):
  • bytecompiler/BytecodeGenerator.h:
  • bytecompiler/NodesCodegen.cpp: (JSC::BracketAccessorNode::emitBytecode): (JSC::DotAccessorNode::emitBytecode):
  • interpreter/Interpreter.cpp: (JSC::Interpreter::privateExecute):
  • jit/JIT.cpp: (JSC::JIT::privateCompileMainPass): (JSC::JIT::privateCompileSlowCases):
  • jit/JIT.h:
  • jit/JITOpcodes.cpp: (JSC::JIT::emit_op_get_arguments_length): (JSC::JIT::emitSlow_op_get_arguments_length): (JSC::JIT::emit_op_get_argument_by_val): (JSC::JIT::emitSlow_op_get_argument_by_val):
  • jit/JITOpcodes32_64.cpp: (JSC::JIT::emit_op_get_arguments_length): (JSC::JIT::emitSlow_op_get_arguments_length): (JSC::JIT::emit_op_get_argument_by_val): (JSC::JIT::emitSlow_op_get_argument_by_val):
1:42 PM Changeset in webkit [68337] by rniwa@webkit.org
  • 3 edits in trunk/WebCore

2010-09-25 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Tony Chang.

FormatBlockCommand's modifyRange and doApply should be merged
https://bugs.webkit.org/show_bug.cgi?id=46504

Isolated the code in doApply to insert and remove lists for single paragraph into doApplyForSingleParagraph.
Merged the code in modifyRange into doApply and cleaned up.

No new tests are added since this is a cleanup.

  • editing/FormatBlockCommand.cpp: (WebCore::FormatBlockCommand::doApply): Merged with modifyRange; calls doApplyForSingleParagraph. (WebCore::FormatBlockCommand::doApplyForSingleParagraph): Added.
  • editing/FormatBlockCommand.h:
11:09 AM Changeset in webkit [68336] by mihaip@chromium.org
  • 2 edits in trunk/LayoutTests

2010-09-25 Mihai Parparita <mihaip@chromium.org>

Unreviewed Chromium drt_expectations.txt update.

Speech input appearance tests have image diffs on Linux too.

  • platform/chromium/drt_expectations.txt:
10:34 AM Changeset in webkit [68335] by mitz@apple.com
  • 3 edits
    2 adds in trunk

<rdar://problem/8478160> Null deref in InlineBox::height()
https://bugs.webkit.org/show_bug.cgi?id=45344

Reviewed by John Sullivan.

WebCore:

Test: fast/css/first-line-parent-style-different.html

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::firstLineStyleSlowCase): Set the pseudo style bit on the RenderStyle
which is going to supply the first-line style rather than on this object’s RenderStyle. The
styles may differ.

LayoutTests:

  • fast/css/first-line-parent-style-different-expected.txt: Added.
  • fast/css/first-line-parent-style-different.html: Added.
10:30 AM Changeset in webkit [68334] by mitz@apple.com
  • 2 edits in trunk/WebCore

<rdar://problem/8478182> Make canHyphenate() return false for unsupported locales

Reviewed by John Sullivan.

No change in functionality, hence no new test.

  • platform/text/cf/HyphenationCF.cpp:

(WebCore::::createValueForKey): Return 0 if hyphenation is not available for the locale.
(WebCore::cfLocaleCache): Moved the definition of the cache from lastHyphenLocation() to
this new getter to allow canHyphenate() to share it.
(WebCore::canHyphenate): Now returns true only if hyphenation is available.
(WebCore::lastHyphenLocation): Added an assertion.

10:01 AM Changeset in webkit [68333] by thakis@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-09-25 Nicolas Weber <thakis@chromium.org>

Reviewed by James Robinson.

[chromium] Fix clang warning/error.
https://bugs.webkit.org/show_bug.cgi?id=46552

  • src/WorkerFileSystemCallbacksBridge.h:
9:17 AM Changeset in webkit [68332] by andreas.kling@nokia.com
  • 2 edits in trunk/LayoutTests

2010-09-25 Andreas Kling <andreas.kling@nokia.com>

Unreviewed, Qt rebaseline after r68331 which fixed dash offset rendering.

  • platform/qt/svg/custom/js-repaint-rect-on-path-with-stroke-expected.txt:
8:44 AM Changeset in webkit [68331] by andreas.kling@nokia.com
  • 2 edits in trunk/WebCore

2010-09-25 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] GraphicsContext::setLineDash() should scale dashOffset to penWidth
https://bugs.webkit.org/show_bug.cgi?id=46548

Fixes incorrect rendering of <http://www.carto.net/svg/samples/animated_bustrack.shtml>

This is covered by existing layout tests which need to be rebaselined.

  • platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::setLineDash):
2:07 AM Changeset in webkit [68330] by Patrick Gansterer
  • 2 edits in trunk/JavaScriptCore

2010-09-25 Patrick Gansterer <Patrick Gansterer>

Unreviewed.

Fix typo in StringHasher class
https://bugs.webkit.org/show_bug.cgi?id=45970

  • wtf/StringHashFunctions.h: (WTF::StringHasher::createHash):
12:36 AM Changeset in webkit [68329] by thakis@chromium.org
  • 2 edits in trunk/WebKitTools

2010-09-25 Nicolas Weber <thakis@chromium.org>

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=46555
Fix typo in prepare-ChangeLog's help output.

  • Scripts/prepare-ChangeLog:

Sep 24, 2010:

11:53 PM Changeset in webkit [68328] by mihaip@chromium.org
  • 3 edits in trunk/LayoutTests

2010-09-24 Mihai Parparita <mihaip@chromium.org>

Unreviewed Chromium test_expectations.txt and drt_expectations.txt update.

fast/canvas/webgl/null-object-behaviour.html and
fast/canvas/webgl/uniform-location.html were unskipped with r68187,
however, they still fail with the DRT (only on the bot, presumably due
to a Leopard-only issue), just like a lot of other WebGL tests.

fast/viewport/viewport-128.html is yet another viewport test that only
the Qt port supports.

animations/opacity-transform-animation.html hasn't passed since it was
committed with r68323.

  • platform/chromium/drt_expectations.txt:
  • platform/chromium/test_expectations.txt:
10:52 PM Changeset in webkit [68327] by mihaip@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-09-24 Mihai Parparita <mihaip@chromium.org>

Reviewed by Darin Fisher.

[Chromium] Unnecessary blob dependency in WebKit.gyp
https://bugs.webkit.org/show_bug.cgi?id=46488

r66322 shouldn't have added a blob dependency by hand to targets in
WebKit.gyp, instead blob should be a dependency of webkit_support.
http://crrev.com/59406 did that, so we can now remove these deps.

  • WebKit.gyp:
8:45 PM WebKit Team edited by andreas.kling@nokia.com
(diff)
8:42 PM WebKit Team edited by andreas.kling@nokia.com
(diff)
8:29 PM Changeset in webkit [68326] by weinig@apple.com
  • 2 edits in trunk/WebCore

Fix accidental increase in the size of InlineBox by using a bit
field to indicate that a bool should only take up 1 bit.

Rubber-stamped by Dan Bernstein.

  • rendering/InlineBox.h:
8:26 PM Changeset in webkit [68325] by weinig@apple.com
  • 2 edits in trunk/WebKit2

Fix release build.

  • WebProcess/InjectedBundle/API/c/WKBundlePage.h:
8:05 PM Changeset in webkit [68324] by enrica@apple.com
  • 2 edits in trunk/WebKit2

One more build fix.

  • UIProcess/API/qt/qwkpage.cpp:

(QWKPagePrivate::setEditCommandState):

7:52 PM Changeset in webkit [68323] by Simon Fraser
  • 4 edits
    4 adds in trunk

2010-09-24 Simon Fraser <Simon Fraser>

Reviewed by Sam Weinig.

Accelerated transitions do not suspend/resume properly.
https://bugs.webkit.org/show_bug.cgi?id=43792

(1) Fix regression from r68233, where if an animation affected two
properties, only one would animate. The testcase tests this.

(2) Fix a flash at the end of an animation or transition that has been
paused and resumed. The flash occurred because we used CAAnimation's
timeOffset when resuming to push the start of the animation into
the past. However, timeOffset does not play nicely with fill modes,
causing a single frame of animation with the element in its unanimated state.

Fixed this by offsetting the beginTime into the past, rather than setting
timeOffset. Normally we submit animations with beginTime == 0, and rely
on CA assigning a beginTime when the animation is committed. This beginTime
is then passed to AnimationController to sync hardware and software animations.
However, since the code now assigns beginTimes in the past (on resume),
we now have to denote whether we've done this, and send an appropriate
timestamp back to AnimationController.

(3) Finally, the patch removes PropertyAnimationPair and just uses LayerPropertyAnimation
instead. This is just cleanup.

Test: animations/opacity-transform-animation.html

  • platform/graphics/mac/GraphicsLayerCA.h: Remove PropertyAnimationPair, and change AnimationsMap to store a vector of LayerPropertyAnimation. New method, animationDidStart(), is called from the -animationDidStart: callback.
  • platform/graphics/mac/GraphicsLayerCA.mm: (-[WebAnimationDelegate animationDidStart:]): Just call m_graphicsLayer->animationDidStart() now. (WebCore::animationIdentifier): We need to pass in the property, to fix (1) (WebCore::GraphicsLayerCA::moveOrCopyAnimationsForProperty): Copy the WebKitAnimationBeginTimeSet value, if present. (WebCore::GraphicsLayerCA::animationDidStart): Call notifyAnimationStarted() on the client, after testing if we set a non-zero beginTime on this particular animation. (WebCore::GraphicsLayerCA::updateLayerAnimations): Change to use LayerPropertyAnimation. (WebCore::GraphicsLayerCA::setCAAnimationOnLayer): Set value for WebKitAnimationBeginTimeSetKey if we have a non-zero timeOffset. Make animationID an NSString, to avoid several conversions. (WebCore::GraphicsLayerCA::removeCAAnimationFromLayer): Make animationID an NSString, to avoid several conversions. (WebCore::copyAnimationProperties): Copy WebKitAnimationBeginTimeSetKey if present. (WebCore::GraphicsLayerCA::pauseCAAnimationOnLayer): Make animationID an NSString, to avoid several conversions.
7:32 PM Changeset in webkit [68322] by weinig@apple.com
  • 23 edits
    4 adds in trunk

Implement WebKit2 callback equivalent to -[WebUIDelegate mouseDidMoveOverElement:modifierFlags:]
<rdar://problem/8359279>
https://bugs.webkit.org/show_bug.cgi?id=46546

Reviewed by Darin Adler.

WebKit2:

  • Adds new WKBundleHitTestResultRef object to represent a content under a cursor.
  • Adds new Bundle and UI level mouseDidMoveOverElement UIClient callbacks, with pass through userData to communicate context up to the UIProcess
  • Shared/APIObject.h:
  • Shared/CoreIPCSupport/WebPageProxyMessageKinds.h:
  • UIProcess/API/C/WKPage.h:
  • UIProcess/API/qt/qwkpage.cpp:

(QWKPage::QWKPage):

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didReceiveMessage):
(WebKit::WebPageProxy::mouseDidMoveOverElement):

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebUIClient.cpp:

(WebKit::WebUIClient::mouseDidMoveOverElement):

  • UIProcess/WebUIClient.h:
  • WebKit2.pro:
  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/InjectedBundle/API/c/WKBundleAPICast.h:
  • WebProcess/InjectedBundle/API/c/WKBundleBase.h:
  • WebProcess/InjectedBundle/API/c/WKBundleHitTestResult.cpp: Added.

(WKBundleHitTestResultGetTypeID):
(WKBundleHitTestResultGetNodeHandle):
(WKBundleHitTestResultGetFrame):
(WKBundleHitTestResultCopyAbsoluteLinkURL):

  • WebProcess/InjectedBundle/API/c/WKBundleHitTestResult.h: Added.
  • WebProcess/InjectedBundle/API/c/WKBundlePage.h:
  • WebProcess/InjectedBundle/InjectedBundleHitTestResult.cpp: Added.

(WebKit::InjectedBundleHitTestResult::create):
(WebKit::InjectedBundleHitTestResult::nodeHandle):
(WebKit::InjectedBundleHitTestResult::webFrame):
(WebKit::InjectedBundleHitTestResult::absoluteLinkURL):

  • WebProcess/InjectedBundle/InjectedBundleHitTestResult.h: Added.

(WebKit::InjectedBundleHitTestResult::coreHitTestResult):
(WebKit::InjectedBundleHitTestResult::InjectedBundleHitTestResult):
(WebKit::InjectedBundleHitTestResult::type):

  • WebProcess/InjectedBundle/InjectedBundlePageUIClient.cpp:

(WebKit::InjectedBundlePageUIClient::mouseDidMoveOverElement):

  • WebProcess/InjectedBundle/InjectedBundlePageUIClient.h:
  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::mouseDidMoveOverElement):

  • win/WebKit2.vcproj:

WebKitTools:

  • MiniBrowser/mac/BrowserWindowController.m:

(mouseDidMoveOverElement):
(-[BrowserWindowController awakeFromNib]):

  • MiniBrowser/win/BrowserView.cpp:

(mouseDidMoveOverElement):
(BrowserView::create):

  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::InjectedBundlePage::InjectedBundlePage):

  • WebKitTestRunner/TestController.cpp:

(WTR::createOtherPage):
(WTR::TestController::initialize):

6:57 PM Changeset in webkit [68321] by andreas.kling@nokia.com
  • 2 edits in trunk/WebCore

2010-09-24 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

SVG: Avoid calling pow() in genericParseNumber() unless necessary
https://bugs.webkit.org/show_bug.cgi?id=46537

0.4% speedup on <http://themaninblue.com/experiment/AnimationBenchmark/svg/>

  • svg/SVGParserUtilities.cpp: (WebCore::genericParseNumber): Only call pow() when we have an exponent.
6:50 PM Changeset in webkit [68320] by enrica@apple.com
  • 4 edits in trunk/WebKit2

Build fix.

  • UIProcess/API/qt/qwkpage_p.h:
  • UIProcess/win/WebView.cpp:

(WebKit::WebView::setEditCommandState):

  • UIProcess/win/WebView.h:
6:39 PM Changeset in webkit [68319] by commit-queue@webkit.org
  • 2 edits in trunk/WebKit/wx

2010-09-24 Kwang Yul Seo <skyul@company100.net>

Reviewed by Andreas Kling.

[wx] ChromeClientWx::scaleFactor must return 1.0
https://bugs.webkit.org/show_bug.cgi?id=46542

The default value of ChromeClientWx::scaleFactor must be 1.0.
Otherwise, canvas element won't be painted.

  • WebKitSupport/ChromeClientWx.cpp: (WebCore::ChromeClientWx::scaleFactor):
6:36 PM Changeset in webkit [68318] by enrica@apple.com
  • 14 edits in trunk/WebKit2

Maui: Pasteboard support (42317)
<rdar://problem/7660537>
https://bugs.webkit.org/show_bug.cgi?id=42317

Reviewed by Darin Adler.

This is the final piece of the pasteboard support for WebKit2.
The menu validation has been hooked up for Mac. The validation is
performed asynchronously and the menu entries updated while the menu
is visible. I've created a generic mechanism to call editing commands
that will make it easy to add new commands we will support in the future.
The commands supported now are copy, cut, paste, pasteAsPlainText, delete
and selectAll.

  • Shared/CoreIPCSupport/WebPageProxyMessageKinds.h: Added DidValidateMenuItem.
  • UIProcess/API/mac/PageClientImpl.h: Added setEditCommandState.
  • UIProcess/API/mac/PageClientImpl.mm: Added setEditCommandState implementation.

(WebKit::PageClientImpl::setEditCommandState): Added.

  • UIProcess/API/mac/WKView.mm:

(WebCore::MenuItemInfo::MenuItemInfo):
(-[WKView initWithFrame:pageNamespaceRef:]):
(createSelectorExceptionMap): Added.
(commandNameForSelector): Added.
(-[WKView validateUserInterfaceItem:]): Added implementation.
(-[WKView _setUserInterfaceItemState:enabled:state:]): Added.

  • UIProcess/API/mac/WKViewInternal.h:
  • UIProcess/PageClient.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::validateMenuItem):
(WebKit::WebPageProxy::executeEditCommand):
(WebKit::WebPageProxy::didReceiveMessage): Now processing also
DidValidateMenuItem.

  • UIProcess/WebPageProxy.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::executeEditingCommand): Fixed.
(WebKit::WebPage::isEditingCommandEnabled): Fixed.
(WebKit::WebPage::validateMenuItem): Added.
(WebKit::WebPage::executeEditCommand): Added.

  • WebProcess/WebPage/WebPage.h: Removed cut, copy, paste, selectAll.

Added validateMenuItem and executeEditCommand.

  • WebProcess/WebPage/WebPage.messages.in: Added new messages.
  • UIProcess/API/qt/qwkpage.cpp:

(WebKit::QWKPage::setEditCommandState): Added.

  • UIProcess/API/qt/qwkpage_p.h: Added
6:36 PM Changeset in webkit [68317] by mihaip@chromium.org
  • 4 edits in trunk/WebKitTools

2010-09-24 Mihai Parparita <mihaip@chromium.org>

Reviewed by Adam Barth.

Allow rebaselines for webkit-patch rebaseline to be chosen
https://bugs.webkit.org/show_bug.cgi?id=46407

Instead of always rebaselining all failing tests, allow a subset to be
chosen.

  • Scripts/webkitpy/common/system/user.py:
  • Scripts/webkitpy/tool/commands/rebaseline.py:
5:47 PM Changeset in webkit [68316] by andersca@apple.com
  • 2 edits in trunk/WebKit2

Build fix.

  • WebKit2.xcodeproj/project.pbxproj:
5:40 PM Changeset in webkit [68315] by crogers@google.com
  • 32 edits
    2 copies in branches/audio/WebCore

audio branch: changes in preparation for landing in trunk

  • split BiquadProcessor files into BiquadProcessor and BiquadDSPKernel
  • HRTFDatabase, HRTFDatabaseLoader, and HRTFPanner cleanup
  • AudioPannerNode cleanup
  • AudioBasicProcessorNode cleanup
  • other misc. cleanup
4:36 PM Changeset in webkit [68314] by mihaip@chromium.org
  • 3 edits in trunk/LayoutTests

2010-09-24 Mihai Parparita <mihaip@chromium.org>

Unreviewed Chromium test_expectations.txt and drt_expectations.txt update.

Userscript test now pass with both the Chromium DRT and test_shell
(as of http://crrev.com/60526).

  • platform/chromium/drt_expectations.txt:
  • platform/chromium/test_expectations.txt:
4:33 PM Changeset in webkit [68313] by Martin Robinson
  • 4 edits in trunk

2010-09-24 Martin Robinson <mrobinson@igalia.com>

Reviewed by Gustavo Noronha Silva.

[GTK] opening local files on win32
https://bugs.webkit.org/show_bug.cgi?id=31066

This is tested by changes to the testmimehandling API test.

  • platform/network/soup/ResourceHandleSoup.cpp: Properly convert the GContentType of a file into a mime type. This is important for non-Unix platforms.

2010-09-24 Martin Robinson <mrobinson@igalia.com>

Reviewed by Gustavo Noronha Silva.

[GTK] opening local files on win32
https://bugs.webkit.org/show_bug.cgi?id=31066

Add tests that check the mime type returned by local files loaded via file URLs.

  • tests/testmimehandling.c: (testRemoteMimeType): Added. (testLocalMimeType): Added. (main): Run tests by using g_test_add_data_func with either testRemoteMimeType or testLocalMimeType.
4:22 PM Changeset in webkit [68312] by rniwa@webkit.org
  • 10 edits in trunk

2010-09-24 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Tony Chang.

[chromium] Implement TextInputController::firstRectForCharacterRange
https://bugs.webkit.org/show_bug.cgi?id=38100

The following test now passes on chromium DumpRenderTree:
platform/mac/editing/input/caret-primary-bidi.html
platform/mac/editing/input/firstrectforcharacterrange-plain.html
platform/mac/editing/input/range-for-empty-document.html
editing/inserting/caret-position.html

  • platform/chromium/test_expectations.txt:

2010-09-24 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Tony Chang.

[chromium] Implement TextInputController::firstRectForCharacterRange
https://bugs.webkit.org/show_bug.cgi?id=38100

Implemented TextInputController::firstRectForCharacterRange for chromium platform.
Because the function needs to return an array of integers, added makeIntArray to WebBindings.
makeIntArray does not take Vector because WebBindings.h is included in plugin glue code
where it cannot find wtf/Vector.h.

No new tests are added since we need to implement the same feature in chromium side
in order to enable any tests that uses this function.

  • public/WebBindings.h:
  • public/WebFrame.h:
  • src/WebBindings.cpp: (WebKit::makeIntArrayImpl): Added. (WebKit::WebBindings::makeIntArray): Added.
  • src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::firstRectForCharacterRange): Added.
  • src/WebFrameImpl.h:

2010-09-24 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Tony Chang.

[chromium] Implement TextInputController::firstRectForCharacterRange
https://bugs.webkit.org/show_bug.cgi?id=38100

Implemented TextInputController::firstRectForCharacterRange for chromium platform.
No new tests are added since we need to implement the same feature in chromium side
in order to enable any tests that uses this function.

  • DumpRenderTree/chromium/TextInputController.cpp: (TextInputController::firstRectForCharacterRange): Added.
4:18 PM Changeset in webkit [68311] by tony@chromium.org
  • 2 edits in trunk/LayoutTests

2010-09-24 Tony Chang <tony@chromium.org>

Reviewed by Dimitri Glazkov.

[chromium] add individual entries for repaint failures on mac
https://bugs.webkit.org/show_bug.cgi?id=46517

  • platform/chromium/test_expectations.txt:
4:17 PM Changeset in webkit [68310] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-09-24 Pawel Hajdan <phajdan.jr@chromium.org>

Reviewed by Dumitru Daniliuc.

Move the implementation of chromium_vfs to webkit for POSIX.
This allows us to link Chrome with system-provided SQLite on Linux.
See also http://code.google.com/p/chromium/issues/detail?id=22208.
https://bugs.webkit.org/show_bug.cgi?id=45416

No new tests.

  • platform/sql/chromium/SQLiteFileSystemChromiumPosix.cpp: (sqliteErrorFromPosixError): (releaseLockInfo): (releaseOpenInfo): (findLockInfo): (chromiumCheckReservedLock): (rangeLock): (chromiumLock): (closePendingFds): (chromiumUnlock): (chromiumCloseNoLock): (chromiumClose): (chromiumCheckReservedLockNoop): (chromiumLockNoop): (chromiumUnlockNoop): (seekAndRead): (chromiumRead): (seekAndWrite): (chromiumWrite): (syncWrapper): (chromiumSync): (chromiumTruncate): (chromiumFileSize): (chromiumFileControl): (chromiumSectorSize): (chromiumDeviceCharacteristics): (fillInChromiumFile): (findReusableFd): (chromiumOpen): (chromiumDelete): (chromiumAccess): (chromiumFullPathname): (chromiumDlOpen): (chromiumDlError): (chromiumDlSym): (chromiumDlClose): (chromiumRandomness): (chromiumSleep): (chromiumCurrentTime): (chromiumGetLastError): (WebCore::SQLiteFileSystem::registerSQLiteVFS):
4:12 PM Changeset in webkit [68309] by andersca@apple.com
  • 12 edits
    1 add in trunk/WebKit2

Fill in more of PluginProcess
https://bugs.webkit.org/show_bug.cgi?id=46534

Reviewed by Adam Roben.

  • DerivedSources.make:

Add PluginProcessProxy.

  • Platform/CoreIPC/MessageID.h:

Add a MessageClassPluginProcessProxy message class.

  • PluginProcess/PluginProcess.cpp:

(WebKit::PluginProcess::PluginProcess):
Initialize the shutdown timer.

(WebKit::PluginProcess::initializeConnection):
Rename this to initializeConnection to avoid conflicts in the CoreIPC message handler.

(WebKit::PluginProcess::removeWebProcessConnection):
Remove the given web process connection from our vector.

(WebKit::PluginProcess::initialize):
Create the plug-in module.

(WebKit::PluginProcess::createWebProcessConnection):
Create a connection handle and send it to the UI process.

(WebKit::PluginProcess::shutdownTimerFired):
Quit.

  • PluginProcess/mac/PluginProcessMainMac.mm:

(WebKit::PluginProcessMain):
Call initializeConnection.

  • Scripts/webkit2/messages.py:

Add CoreIPC::MachPort as a special case.

  • Scripts/webkit2/messages_unittest.py:

Add test case.

  • UIProcess/Plugins/PluginProcessProxy.cpp:

(WebKit::PluginProcessProxy::didCreateWebProcessConnection):
Add empty function.

  • UIProcess/Plugins/PluginProcessProxy.messages.in: Added.
  • WebKit2.xcodeproj/project.pbxproj:

Add PluginProcessProxy.messages.in.

  • WebKit2Prefix.h:

Add an ENABLE_PLUGIN_PROCESS #define which is 0 for now.

4:09 PM Changeset in webkit [68308] by abarth@webkit.org
  • 3 edits in trunk/WebKitTools

2010-09-24 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

commit-queue reports land failures as "PASS"
https://bugs.webkit.org/show_bug.cgi?id=46530

We were ignoring the return value of land instead of passing it back to
CommitQueue. Of course, this was the one case I forgot to test!

  • Scripts/webkitpy/tool/bot/commitqueuetask.py:
  • Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
3:57 PM Changeset in webkit [68307] by andreas.kling@nokia.com
  • 3 edits
    3 adds in trunk

2010-09-24 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Dirk Schulze.

SVG: Make SVGLength's stringToLengthType() stricter and faster
https://bugs.webkit.org/show_bug.cgi?id=46066

Add test coverage for handling of invalid SVGLength units.

  • svg/custom/invalid-length-units-expected.txt: Added.
  • svg/custom/invalid-length-units.html: Added.
  • svg/custom/script-tests/invalid-length-units.js: Added. (trySettingLength):

2010-09-24 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Dirk Schulze.

SVG: Make SVGLength's stringToLengthType() stricter and faster
https://bugs.webkit.org/show_bug.cgi?id=46066

Only accept unit names immediately following the numeric value.
This behavior matches Gecko.

Also, using String::endsWith("foo") caused a temporary WTF::String to be created.
Avoid this by comparing characters directly.

10.5% speedup on <http://data.xeoh.net/svg.benchmark/>

Test: svg/custom/invalid-length-units.html

  • svg/SVGLength.cpp: (WebCore::stringToLengthType): (WebCore::SVGLength::setValueAsString):
3:48 PM Changeset in webkit [68306] by mihaip@chromium.org
  • 3 edits
    2 deletes in trunk/LayoutTests

2010-09-24 Mihai Parparita <mihaip@chromium.org>

Reviewed by Adam Barth.

Layout test html5lib/runner.html failing on Chromium
https://bugs.webkit.org/show_bug.cgi?id=42845

Rebaseline html5lib tests (diffs from upstream are still only due to V8
differences).

  • platform/chromium-mac/html5lib/runner-expected.txt: Removed.
  • platform/chromium-win/html5lib/runner-expected.txt: Removed.
  • platform/chromium/html5lib/runner-expected.txt:
  • platform/chromium/test_expectations.txt:
3:47 PM Changeset in webkit [68305] by inferno@chromium.org
  • 1 edit
    2 copies in branches/chromium/517

Merge 67716
Review URL: http://codereview.chromium.org/3405033

3:31 PM Changeset in webkit [68304] by mrowe@apple.com
  • 5 edits in trunk

Versioning.

3:28 PM Changeset in webkit [68303] by mrowe@apple.com
  • 1 copy in tags/Safari-534.9

New tag.

3:26 PM Changeset in webkit [68302] by inferno@chromium.org
  • 1 edit in branches/chromium/517/WebCore/rendering/RenderObject.cpp

Merge 68278
Review URL: http://codereview.chromium.org/3497007

3:25 PM Changeset in webkit [68301] by inferno@chromium.org
  • 1 edit
    2 copies in branches/chromium/517

Merge 68158
Review URL: http://codereview.chromium.org/3404021

3:13 PM Changeset in webkit [68300] by inferno@chromium.org
  • 1 edit
    4 copies in branches/chromium/517

Merge 68062
Review URL: http://codereview.chromium.org/3471012

3:12 PM Changeset in webkit [68299] by Adam Roben
  • 9 edits in trunk/WebKit2

Give windowed Netscape plugins their own window

The plugin window is a child of the WebView's window. The WebView's
window is in the UI process, and the plugin's window is in the web
process (though someday it will be in the plugin process), but Windows
mostly handles this just fine. Right now we move the plugin's window
in the web process, but we need to do it at paint time in the UI
process instead so that the plugin windows will stay in sync with the
web page's contents. There are also a whole bunch of plugin quirks
that WebKit1 supports that we don't support yet, but that's a task for
another day.

Fixes <http://webkit.org/b/44428> Get basic in-process windowed
plugins working in WebKit2 on Windows

Reviewed by Anders Carlsson.

  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp:

(WebKit::NetscapePlugin::destroy):
(WebKit::NetscapePlugin::geometryDidChange):
Call the new platform-specific functions.

  • WebProcess/Plugins/Netscape/NetscapePlugin.h: Added

platformDestroy/platformGeometryDidChange, and an m_window member on
Windows to hold our window.

  • WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:

(WebKit::NetscapePlugin::platformDestroy):
(WebKit::NetscapePlugin::platformGeometryDidChange):

  • WebProcess/Plugins/Netscape/qt/NetscapePluginQt.cpp:

(WebKit::NetscapePlugin::platformDestroy):
(WebKit::NetscapePlugin::platformGeometryDidChange):
Stubbed these out.

  • WebProcess/Plugins/Netscape/win/NetscapePluginWin.cpp:

(WebKit::registerPluginView): Added. The code came from
WebCore's PluginViewWin.cpp, though I changed it to add one to
COLOR_WINDOW, since that's what MSDN says we should do.
(WebKit::NetscapePlugin::platformPostInitialize): If we're windowed,
create a window for the plugin and make it a child of the WebView's
window. If we're not windowed, just set m_window to 0.
(WebKit::NetscapePlugin::platformDestroy): Destroy our window if we
have one and it hasn't been destroyed already.
(WebKit::NetscapePlugin::platformGeometryDidChange): Update our
window's size and position.

  • WebProcess/Plugins/PluginController.h:
  • WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::nativeParentWindow):

  • WebProcess/Plugins/PluginView.h:

Added nativeParentWindow on Windows to return the WebView's window.

3:12 PM Changeset in webkit [68298] by Adam Roben
  • 9 edits in trunk/WebKit2

Pass the WebView's HWND over to the web process

The HWND is packaged up in the WebPageCreationParameters and stored in
the WebPage. It will eventually be used by windowed plugins.

Fixes <http://webkit.org/b/46512> WebPage needs access to its
corresponding HWND from the UI process

Reviewed by Anders Carlsson.

  • Shared/WebPageCreationParameters.cpp:

(WebKit::WebPageCreationParameters::encode):
(WebKit::WebPageCreationParameters::decode):
Encode and decode the HWND as a uint64_t.

  • Shared/WebPageCreationParameters.h: Added a nativeWindow member to

store the HWND.

  • UIProcess/PageClient.h: Added a nativeWindow function on Windows.
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::creationParameters): Store the HWND from the
page client in the struct to be sent to the web process.

  • UIProcess/win/WebView.cpp:

(WebKit::WebView::WebView): Moved the call to initializeWebPage after
we've created our window so that our window will be ready when
WebPageProxy asks for it to send it to the web process.
(WebKit::WebView::nativeWindow): Added. Just returns our window.

  • UIProcess/win/WebView.h: Added nativeWindow.
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::WebPage): Store the HWND in the new m_nativeWindow
member.

  • WebProcess/WebPage/WebPage.h:

(WebKit::WebPage::nativeWindow): Added this simple getter.

3:11 PM Changeset in webkit [68297] by Adam Roben
  • 3 edits in trunk/WebKit2

Add WebPageProxy::creationParameters

Fixes <http://webkit.org/b/46510> WebPageProxy has a bunch of
duplicated WebPageCreationParameters code

Reviewed by Anders Carlsson.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::initializeWebPage):
(WebKit::WebPageProxy::reinitializeWebPage):
(WebKit::WebPageProxy::didReceiveSyncMessage):
Use creationParameters.

(WebKit::WebPageProxy::creationParameters):

  • UIProcess/WebPageProxy.h:

Added creationParameters.

3:11 PM Changeset in webkit [68296] by Adam Roben
  • 4 edits in trunk/WebKit2

Make WebPage::create take a WebPageCreationParameter struct

It only makes sense, after all.

Fixes <http://webkit.org/b/46502>.

Reviewed by Anders Carlsson.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::create):
(WebKit::WebPage::WebPage):

  • WebProcess/WebPage/WebPage.h:

Changed to take a WebPageCreationParameters struct.

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::createWebPage): Changed to pass a
WebPageCreationParameters struct.

3:09 PM Changeset in webkit [68295] by inferno@chromium.org
  • 1 edit
    2 copies in branches/chromium/517

Merge 67967
Review URL: http://codereview.chromium.org/3389031

3:04 PM Changeset in webkit [68294] by commit-queue@webkit.org
  • 3 edits in trunk/WebKitTools

2010-09-24 Kenichi Ishibashi <bashi@google.com>

Reviewed by Eric Seidel.

new-run-webkit-tests prints out nothing when build-dumprendertree fails
https://bugs.webkit.org/show_bug.cgi?id=37563

Print error message when build-dumprendertree fails.

  • Scripts/webkitpy/layout_tests/port/webkit.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3:04 PM Changeset in webkit [68293] by inferno@chromium.org
  • 1 edit in branches/chromium/517/WebCore/html/HTMLFrameOwnerElement.cpp

Merge 67659
Review URL: http://codereview.chromium.org/3427022

2:54 PM Changeset in webkit [68292] by luiz@webkit.org
  • 12 edits
    2 adds in trunk

2010-09-24 Luiz Agostini <luiz.agostini@openbossa.org>

Reviewed by Kenneth Rohde Christiansen.

Keep viewport information in Document
https://bugs.webkit.org/show_bug.cgi?id=46385

The viewport meta data (layout viewport, scale) needs to be set again when bringing
back a page from the page cache. As the viewport metadata is only retrieved while parsing
the document, we need to store it in the Document class.

  • fast/viewport/viewport-128-expected.txt: Copied from LayoutTests/fast/viewport/viewport-19-expected.txt.
  • fast/viewport/viewport-128.html: Added.

2010-09-24 Luiz Agostini <luiz.agostini@openbossa.org>

Reviewed by Kenneth Rohde Christiansen.

Keep viewport information in Document
https://bugs.webkit.org/show_bug.cgi?id=46385

The viewport meta data (layout viewport, scale) needs to be set again when bringing
back a page from the page cache. As the viewport metadata is only retrieved while parsing
the document, we need to store it in the Document class.

Test: fast/viewport/viewport-128.html

  • WebCore.xcodeproj/project.pbxproj:
  • dom/Document.cpp: (WebCore::Document::processViewport): (WebCore::Document::setInPageCache):
  • dom/Document.h: (WebCore::Document::viewportArguments):

2010-09-24 Luiz Agostini <luiz.agostini@openbossa.org>

Reviewed by Kenneth Rohde Christiansen.

Keep viewport information in Document
https://bugs.webkit.org/show_bug.cgi?id=46385

The viewport meta data (layout viewport, scale) needs to be set again when bringing
back a page from the page cache. As the viewport metadata is only retrieved while parsing
the document, we need to store it in the Document class.

  • Api/qwebframe.cpp: (QWebFramePrivate::viewportArguments):
  • Api/qwebframe_p.h:
  • Api/qwebpage.cpp: (QWebPage::viewportConfigurationForSize):
  • WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::didReceiveViewportArguments):
  • WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::viewportAsText):
  • WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::dispatchDidCommitLoad):
2:47 PM Changeset in webkit [68291] by kenneth@webkit.org
  • 5 edits in trunk/WebKit2

Expose all WebKit2 C API preferences via the Qt API.

Reviewed by Andreas Kling.

Also rename a wrongly named C method (was using Web instead of WK).

  • UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesCopyStandardFontFamily):

  • UIProcess/API/C/WKPreferences.h:
  • UIProcess/API/qt/qwkpreferences.cpp:

(QWKPreferences::setFontFamily):
(QWKPreferences::fontFamily):
(QWKPreferences::testAttribute):
(QWKPreferences::setAttribute):

  • UIProcess/API/qt/qwkpreferences.h:
2:47 PM BuildBot edited by mrowe@apple.com
(diff)
2:07 PM Changeset in webkit [68290] by mpcomplete@chromium.org
  • 12 edits in branches/chromium/517

Merge 68061 - 2010-09-22 Matt Perry <mpcomplete@chromium.org>

Reviewed by Darin Fisher.

Trying to reland a version of r67749:
Have V8DOMWindowShell ask the embedder whether to run a V8 extension
in a particular script context.
https://bugs.webkit.org/show_bug.cgi?id=45721

  • bindings/v8/V8DOMWindowShell.cpp: (WebCore::V8DOMWindowShell::createNewContext):
  • bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::registerExtension):
  • bindings/v8/V8Proxy.h:
  • loader/EmptyClients.h: (WebCore::EmptyFrameLoaderClient::allowScriptExtension):
  • loader/FrameLoaderClient.h:

2010-09-22 Matt Perry <mpcomplete@chromium.org>

Reviewed by Darin Fisher.

Trying to reland a version of r67749:
Have V8DOMWindowShell ask the embedder whether to run a V8 extension
in a particular script context.
https://bugs.webkit.org/show_bug.cgi?id=45721

  • public/WebFrameClient.h: (WebKit::WebFrameClient::allowScriptExtension):
  • public/WebScriptController.h:
  • src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::allowScriptExtension):
  • src/FrameLoaderClientImpl.h:
  • src/WebScriptController.cpp: (WebKit::WebScriptController::registerExtension):

TBR=mpcomplete@chromium.org
Review URL: http://codereview.chromium.org/3453022

2:06 PM Changeset in webkit [68289] by commit-queue@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-09-24 Patrick Gansterer <paroga@paroga.com>

Reviewed by Gavin Barraclough.

Add WTF::StringHasher
https://bugs.webkit.org/show_bug.cgi?id=45970

StringHasher is a class for calculation stringHash out of character string.
This class will unify the different usages of the same algorithm.

  • wtf/StringHashFunctions.h: (WTF::StringHasher::StringHasher): (WTF::StringHasher::addCharacters): (WTF::StringHasher::addCharacter): (WTF::StringHasher::hash): (WTF::StringHasher::createHash): (WTF::StringHasher::defaultCoverter): (WTF::StringHasher::addCharactersToHash): (WTF::stringHash):
1:54 PM Changeset in webkit [68288] by oliver@apple.com
  • 2 edits in trunk/JavaScriptCore

2010-09-24 Oliver Hunt <oliver@apple.com>

Reviewed by Geoffrey Garen.

Variable declarations inside a catch scope don't get propogated to the parent scope
https://bugs.webkit.org/show_bug.cgi?id=46501

Add logic to make variable declaration look for a scope for the
new variable. This allows us to create a scope (eg. for catch)
and then seal it, so that additional variable declarations
contained are propogated to the correct target. Strangely this
comes out as a performance win, but I think it's mostly cache
effects.

  • parser/JSParser.cpp: (JSC::JSParser::Scope::Scope): (JSC::JSParser::Scope::preventNewDecls): (JSC::JSParser::Scope::allowsNewDecls): (JSC::JSParser::declareVariable): (JSC::JSParser::parseVarDeclarationList): (JSC::JSParser::parseConstDeclarationList): (JSC::JSParser::parseTryStatement): (JSC::JSParser::parseFormalParameters): (JSC::JSParser::parseFunctionDeclaration):
1:47 PM Changeset in webkit [68287] by andersca@apple.com
  • 2 edits in trunk/WebKit2

messages_unittest.py should compare the generated results against expected results
https://bugs.webkit.org/show_bug.cgi?id=46490

Reviewed by Adam Roben.

  • Scripts/webkit2/messages_unittest.py:
1:22 PM Changeset in webkit [68286] by senorblanco@chromium.org
  • 8 edits in trunk/LayoutTests

2010-09-24 Stephen White <senorblanco@chromium.org>

Unreviewed; new test baselines and test_expectations update.

[CHROMIUM] Rebaseline some fast/speech test results for chromium-mac. Also mark svg/clip-path/clip-path-text-and-stroke.svg as crashing intermittently.

  • platform/chromium-mac/fast/speech/input-appearance-numberandspeech-expected.checksum:
  • platform/chromium-mac/fast/speech/input-appearance-numberandspeech-expected.png:
  • platform/chromium-mac/fast/speech/input-appearance-searchandspeech-expected.checksum:
  • platform/chromium-mac/fast/speech/input-appearance-searchandspeech-expected.png:
  • platform/chromium-mac/fast/speech/input-appearance-speechbutton-expected.checksum:
  • platform/chromium-mac/fast/speech/input-appearance-speechbutton-expected.png:
  • platform/chromium/test_expectations.txt:
1:11 PM Changeset in webkit [68285] by commit-queue@webkit.org
  • 1 edit
    1 add in trunk/JavaScriptCore

2010-09-24 İsmail Dönmez <ismail@namtrac.org>

Reviewed by Csaba Osztrogonác.

Add a Windows compatible inttypes.h header to fix WinCE build.
https://bugs.webkit.org/show_bug.cgi?id=46463

  • os-win32/inttypes.h: Added.
12:43 PM Changeset in webkit [68284] by kenneth@webkit.org
  • 6 edits
    1 copy in trunk/WebKit2

Make it possible to get the page preferences for Qt WebKit2 port.

Reviewed by Antonio Gomes.

  • UIProcess/API/qt/qwkpage.cpp:

(QWKPagePrivate::QWKPagePrivate):
(QWKPage::preferences):

  • UIProcess/API/qt/qwkpage.h:
  • UIProcess/API/qt/qwkpage_p.h:
  • UIProcess/API/qt/qwkpreferences.cpp:

(QWKPreferencesPrivate::createPreferences):
(QWKPreferencesPrivate::createSharedPreferences):
(QWKPreferences::sharedPreferences):
(QWKPreferences::QWKPreferences):

  • UIProcess/API/qt/qwkpreferences.h:
12:32 PM Changeset in webkit [68283] by hyatt@apple.com
  • 6 edits in trunk/WebCore

https://bugs.webkit.org/show_bug.cgi?id=46496, rename containingBlockWidthForContent to
containingBlockLogicalWidthForContent.

Reviewed by Sam Weinig.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::localCaretRect):

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::containingBlockLogicalWidthForContent):
(WebCore::RenderBox::computeLogicalWidth):
(WebCore::RenderBox::computeReplacedWidthUsing):

  • rendering/RenderBox.h:
  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::relativePositionOffsetX):
(WebCore::RenderBoxModelObject::containingBlockLogicalWidthForContent):

  • rendering/RenderBoxModelObject.h:
12:14 PM Changeset in webkit [68282] by hyatt@apple.com
  • 9 edits in trunk/WebCore

https://bugs.webkit.org/show_bug.cgi?id=46489, rename the lineWidth and left/RightOffset methods
to reflect that they will be logical.

Reviewed by Sam Weinig.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::determineHorizontalPosition):
(WebCore::RenderBlock::leftSelectionOffset):
(WebCore::RenderBlock::rightSelectionOffset):
(WebCore::RenderBlock::positionNewFloats):
(WebCore::RenderBlock::logicalLeftOffsetForContent):
(WebCore::RenderBlock::logicalLeftOffsetForLine):
(WebCore::RenderBlock::logicalRightOffsetForContent):
(WebCore::RenderBlock::logicalRightOffsetForLine):
(WebCore::RenderBlock::availableLogicalWidthForLine):
(WebCore::RenderBlock::getClearDelta):

  • rendering/RenderBlock.h:

(WebCore::RenderBlock::logicalRightOffsetForLine):
(WebCore::RenderBlock::logicalLeftOffsetForLine):

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::computeInlineDirectionPositionsForLine):
(WebCore::RenderBlock::layoutInlineChildren):
(WebCore::RenderBlock::skipTrailingWhitespace):
(WebCore::RenderBlock::skipLeadingWhitespace):
(WebCore::RenderBlock::fitBelowFloats):
(WebCore::RenderBlock::findNextLineBreak):
(WebCore::RenderBlock::checkLinesForTextOverflow):

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::containingBlockWidthForContent):

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::applyLineClamp):

  • rendering/RenderListItem.cpp:

(WebCore::RenderListItem::positionListMarker):

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::computeLogicalWidth):

  • rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::selectionTop):

12:06 PM Changeset in webkit [68281] by oliver@apple.com
  • 11 edits in trunk/JavaScriptCore

REGRESSION(r68223): It broke 2-3 tests on bots (Requested by Ossy on #webkit).
https://bugs.webkit.org/show_bug.cgi?id=46448

Reviewed by Gavin Barraclough

Roll this back in, with additional logic to prevent us from delaying construction
of functions named "arguments"

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::dump):

  • bytecode/Opcode.h:
  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::BytecodeGenerator):
(JSC::BytecodeGenerator::emitInitLazyRegister):
(JSC::BytecodeGenerator::registerFor):
(JSC::BytecodeGenerator::createLazyRegisterIfNecessary):
(JSC::BytecodeGenerator::constRegisterFor):
(JSC::BytecodeGenerator::emitNewFunction):
(JSC::BytecodeGenerator::emitLazyNewFunction):
(JSC::BytecodeGenerator::emitNewFunctionInternal):

  • bytecompiler/BytecodeGenerator.h:
  • interpreter/Interpreter.cpp:

(JSC::Interpreter::privateExecute):

  • jit/JIT.cpp:

(JSC::JIT::privateCompileMainPass):

  • jit/JIT.h:
  • jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_init_lazy_reg):
(JSC::JIT::emit_op_new_func):

  • jit/JITOpcodes32_64.cpp:

(JSC::JIT::emit_op_init_lazy_reg):

  • parser/Nodes.h:

(JSC::ScopeNode::needsActivationForMoreThanVariables):

11:55 AM Changeset in webkit [68280] by mitz@apple.com
  • 2 edits in trunk/WebKit/mac

automaticSpellingCorrectionEnabled isn't updated.
https://bugs.webkit.org/show_bug.cgi?id=46486
<rdar://problem/8475212>

Patch by Jia Pu <jpu@apple.com> on 2010-09-24
Reviewed by Dan Bernstein.

  • WebView/WebView.mm:

(+[WebView initialize]): Should update "automaticSpellingCorrectionEnabled"

instead of "automaticTextReplacementEnabled".

11:38 AM Changeset in webkit [68279] by tony@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-09-24 Tony Chang <tony@chromium.org>

Unreviewed, fix chromium compile after r68276 which renamed
Render*::minPrefWidth to minPreferredLogicalWidth.

  • src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::contentsPreferredWidth):
11:21 AM Changeset in webkit [68278] by inferno@chromium.org
  • 2 edits in trunk/WebCore

2010-09-24 Abhishek Arya <inferno@chromium.org>

Reviewed by Simon Fraser.

Comply with spec by generalizing container on which transforms can be applied.
https://bugs.webkit.org/show_bug.cgi?id=46485

Already covered by existing tests.

  • rendering/RenderObject.cpp: (WebCore::RenderObject::getTransformFromContainer):
11:08 AM Changeset in webkit [68277] by tony@chromium.org
  • 2 edits in trunk/LayoutTests

2010-09-24 Tony Chang <tony@chromium.org>

Unreviewed, updating test_expectations.txt.

Removing tests that are now passing in test_shell.

  • platform/chromium/test_expectations.txt:
11:07 AM Changeset in webkit [68276] by hyatt@apple.com
  • 58 edits in trunk/WebCore

https://bugs.webkit.org/show_bug.cgi?id=46482, rename the various prefWidth functions to use
preferredLogicalWidth.

Reviewed by Simon Fraser.

  • rendering/AutoTableLayout.cpp:

(WebCore::AutoTableLayout::recalcColumn):
(WebCore::AutoTableLayout::computePreferredLogicalWidths):
(WebCore::AutoTableLayout::calcEffectiveWidth):

  • rendering/AutoTableLayout.h:
  • rendering/FixedTableLayout.cpp:

(WebCore::FixedTableLayout::calcWidthArray):
(WebCore::FixedTableLayout::computePreferredLogicalWidths):

  • rendering/FixedTableLayout.h:
  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::layoutBlockChildren):
(WebCore::RenderBlock::layoutPositionedObjects):
(WebCore::RenderBlock::getClearDelta):
(WebCore::RenderBlock::computePreferredLogicalWidths):
(WebCore::RenderBlock::computeInlinePreferredLogicalWidths):
(WebCore::RenderBlock::computeBlockPreferredLogicalWidths):

  • rendering/RenderBlock.h:
  • rendering/RenderBlockLineLayout.cpp:

(WebCore::dirtyLineBoxesForRenderer):
(WebCore::RenderBlock::layoutInlineChildren):

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::RenderBox):
(WebCore::RenderBox::minPreferredLogicalWidth):
(WebCore::RenderBox::maxPreferredLogicalWidth):
(WebCore::RenderBox::computeLogicalWidth):
(WebCore::RenderBox::computeLogicalWidthUsing):
(WebCore::RenderBox::computePositionedLogicalWidth):
(WebCore::RenderBox::computePositionedLogicalWidthUsing):

  • rendering/RenderBox.h:

(WebCore::RenderBox::computePreferredLogicalWidths):

  • rendering/RenderCounter.cpp:

(WebCore::RenderCounter::computePreferredLogicalWidths):

  • rendering/RenderCounter.h:
  • rendering/RenderDataGrid.cpp:

(WebCore::RenderDataGrid::computePreferredLogicalWidths):

  • rendering/RenderDataGrid.h:
  • rendering/RenderFieldset.cpp:

(WebCore::RenderFieldset::computePreferredLogicalWidths):

  • rendering/RenderFieldset.h:
  • rendering/RenderFileUploadControl.cpp:

(WebCore::RenderFileUploadControl::computePreferredLogicalWidths):

  • rendering/RenderFileUploadControl.h:
  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::calcHorizontalPrefWidths):
(WebCore::RenderFlexibleBox::calcVerticalPrefWidths):
(WebCore::RenderFlexibleBox::computePreferredLogicalWidths):
(WebCore::RenderFlexibleBox::allowedChildFlex):

  • rendering/RenderFlexibleBox.h:
  • rendering/RenderFrameBase.cpp:

(WebCore::RenderFrameBase::layoutWithFlattening):

  • rendering/RenderHTMLCanvas.cpp:

(WebCore::RenderHTMLCanvas::canvasSizeChanged):

  • rendering/RenderImage.cpp:

(WebCore::RenderImage::imageChanged):

  • rendering/RenderListBox.cpp:

(WebCore::RenderListBox::computePreferredLogicalWidths):

  • rendering/RenderListBox.h:
  • rendering/RenderListItem.cpp:

(WebCore::RenderListItem::updateMarkerLocation):
(WebCore::RenderListItem::computePreferredLogicalWidths):

  • rendering/RenderListItem.h:
  • rendering/RenderListMarker.cpp:

(WebCore::RenderListMarker::layout):
(WebCore::RenderListMarker::computePreferredLogicalWidths):
(WebCore::RenderListMarker::updateMargins):

  • rendering/RenderListMarker.h:
  • rendering/RenderMenuList.cpp:

(WebCore::RenderMenuList::computePreferredLogicalWidths):

  • rendering/RenderMenuList.h:
  • rendering/RenderObject.cpp:

(WebCore::RenderObject::RenderObject):
(WebCore::RenderObject::setPreferredLogicalWidthsDirty):
(WebCore::RenderObject::invalidateContainerPreferredLogicalWidths):

  • rendering/RenderObject.h:

(WebCore::RenderObject::preferredLogicalWidthsDirty):
(WebCore::RenderObject::setNeedsLayoutAndPrefWidthsRecalc):
(WebCore::RenderObject::minPreferredLogicalWidth):
(WebCore::RenderObject::maxPreferredLogicalWidth):

  • rendering/RenderReplaced.cpp:

(WebCore::RenderReplaced::computePreferredLogicalWidths):

  • rendering/RenderReplaced.h:
  • rendering/RenderReplica.cpp:

(WebCore::RenderReplica::computePreferredLogicalWidths):

  • rendering/RenderReplica.h:
  • rendering/RenderSVGRoot.cpp:

(WebCore::RenderSVGRoot::computePreferredLogicalWidths):

  • rendering/RenderSVGRoot.h:
  • rendering/RenderScrollbarPart.cpp:

(WebCore::RenderScrollbarPart::computePreferredLogicalWidths):

  • rendering/RenderScrollbarPart.h:
  • rendering/RenderSlider.cpp:

(WebCore::RenderSlider::computePreferredLogicalWidths):

  • rendering/RenderSlider.h:
  • rendering/RenderTable.cpp:

(WebCore::RenderTable::computeLogicalWidth):
(WebCore::RenderTable::computePreferredLogicalWidths):

  • rendering/RenderTable.h:
  • rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::computePreferredLogicalWidths):

  • rendering/RenderTableCell.h:
  • rendering/RenderTableCol.cpp:

(WebCore::RenderTableCol::computePreferredLogicalWidths):

  • rendering/RenderTableCol.h:
  • rendering/RenderText.cpp:

(WebCore::RenderText::trimmedPrefWidths):
(WebCore::RenderText::minPreferredLogicalWidth):
(WebCore::RenderText::maxPreferredLogicalWidth):
(WebCore::RenderText::computePreferredLogicalWidths):
(WebCore::RenderText::width):

  • rendering/RenderText.h:
  • rendering/RenderTextControl.cpp:

(WebCore::RenderTextControl::computePreferredLogicalWidths):

  • rendering/RenderTextControl.h:
  • rendering/RenderTextControlSingleLine.cpp:

(WebCore::RenderTextControlSingleLine::preferredContentWidth):
(WebCore::RenderTextControlSingleLine::preferredDecorationWidthRight):

  • rendering/RenderVideo.cpp:

(WebCore::RenderVideo::updateIntrinsicSize):

  • rendering/RenderView.cpp:

(WebCore::RenderView::RenderView):
(WebCore::RenderView::computePreferredLogicalWidths):
(WebCore::RenderView::layout):

  • rendering/RenderView.h:
  • rendering/TableLayout.h:
11:03 AM Changeset in webkit [68275] by jianli@chromium.org
  • 7 edits
    2 adds in trunk

DOMWindow::revokeBlobURL erroneously uses ParsedURLString.
https://bugs.webkit.org/show_bug.cgi?id=46434

Reviewed by Alexey Proskuryakov.

WebCore:

Test: fast/files/revoke-blob-url.html

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::revokeBlobURL):

LayoutTests:

Add a test. Also update Skipped files for those not-supported platforms.

  • fast/files/revoke-blob-url-expected.txt: Added.
  • fast/files/revoke-blob-url.html: Added.
  • platform/gtk/Skipped:
  • platform/mac-wk2/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
11:00 AM Changeset in webkit [68274] by kenneth@webkit.org
  • 8 edits in trunk/WebKit2

Add WebKit2 C API for setting/getting frame flattening and plugin settings.
http://webkit.org/b/46477

Reviewed by Sam Weinig.

NOTE: The plugin setting was partly done but there was no C API.

  • Shared/WebPreferencesStore.cpp:

(WebKit::WebPreferencesStore::WebPreferencesStore):
(WebKit::WebPreferencesStore::encode):
(WebKit::WebPreferencesStore::decode):

  • Shared/WebPreferencesStore.h:
  • UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesSetFrameFlatteningEnabled):
(WKPreferencesGetFrameFlatteningEnabled):
(WKPreferencesSetPluginsEnabled):
(WKPreferencesGetPluginsEnabled):

  • UIProcess/API/C/WKPreferences.h:
  • UIProcess/WebPreferences.cpp:

(WebKit::WebPreferences::setFrameFlatteningEnabled):
(WebKit::WebPreferences::frameFlatteningEnabled):
(WebKit::WebPreferences::setPluginsEnabled):
(WebKit::WebPreferences::pluginsEnabled):

  • UIProcess/WebPreferences.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::WebPage):
(WebKit::WebPage::preferencesDidChange):

10:51 AM Changeset in webkit [68273] by zmo@google.com
  • 2 edits in trunk/LayoutTests

2010-09-24 Zhenyao Mo <zmo@google.com>

Unreviewed.

Remove outdated WebGL linux entries from chromium/drt_expectations.txt.

  • platform/chromium/drt_expectations.txt:
10:24 AM Changeset in webkit [68272] by Adam Roben
  • 8 edits
    2 adds in trunk/WebKit2

Add WebPageCreationParameters

This struct is used in any messages that end up creating a WebPage.
Using a struct instead of individual parameters will make it easier to
add platform-specific data, such as an HWND on Windows.

Fixes <http://webkit.org/b/46470> Pass parameters for creating a
WebPage in a single struct

Reviewed by Anders Carlsson.

  • Shared/WebPageCreationParameters.cpp: Added.

(WebKit::WebPageCreationParameters::encode):
(WebKit::WebPageCreationParameters::decode):
Simple encode/decode functions.

  • Shared/WebPageCreationParameters.h: Added.
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::initializeWebPage):
(WebKit::WebPageProxy::reinitializeWebPage):
(WebKit::WebPageProxy::didReceiveSyncMessage):

  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::createWindow):

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::createWebPage):
(WebKit::WebProcess::didReceiveMessage):

  • WebProcess/WebProcess.h:

Changed to use WebPageCreationParameters instead of passing the
values individually.

  • WebKit2.pro:
  • WebKit2.xcodeproj/project.pbxproj:
  • win/WebKit2.vcproj:

Added WebPageCreationParameters.

10:23 AM Changeset in webkit [68271] by Adam Roben
  • 7 edits
    1 delete in trunk/WebKit2

Stop pretending that we know how to encode a DrawingArea and just encode the DrawingAreaInfo directly

DrawingAreaBase and friends were trying to hide the fact that they
were just encoding/decoding a DrawingAreaInfo behind the scenes, but
everyone knew what was going on and it was getting embarassing.

Fixes <http://webkit.org/b/46469> Code to encode/decode a
DrawingAreaInfo is confusing

Reviewed by Anders Carlsson.

  • Shared/DrawingAreaBase.cpp: Removed.
  • Shared/DrawingAreaBase.h: Removed encode/decode.
  • UIProcess/ChunkedUpdateDrawingAreaProxy.h: Removed encode override.
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::initializeWebPage):
(WebKit::WebPageProxy::reinitializeWebPage):
(WebKit::WebPageProxy::didReceiveSyncMessage):
Changed to encode the DrawingAreaInfo directly.

  • WebKit2.pro:
  • WebKit2.xcodeproj/project.pbxproj:
  • win/WebKit2.vcproj:

Removed DrawingAreaBase.cpp.

10:23 AM Changeset in webkit [68270] by hyatt@apple.com
  • 6 edits in trunk

https://bugs.webkit.org/show_bug.cgi?id=46474

Reviewed by Sam Weinig.

Patch computeWidthUsing to be block-flow-aware. Rename the WidthType enum to LogicalWidthType. Make computeLogicalWidthUsing
query the style for logical width properties instead of width properties.

fast/css/logical-property-resolution.html now fails and gives bad results. This is expected. It will become correct
again as more layout code gets patched.

WebCore:

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::computeLogicalWidth):
(WebCore::RenderBox::computeLogicalWidthUsing):
(WebCore::RenderBox::sizesToIntrinsicWidth):

  • rendering/RenderBox.h:

LayoutTests:

  • fast/css/logical-property-resolution-expected.txt:
  • fast/css/logical-property-resolution.html:
10:23 AM Changeset in webkit [68269] by Adam Roben
  • 9 edits in trunk/WebKit2

Expose a whole DrawingAreaInfo instead of its constituent parts from DrawingAreaBase

This is just a step toward cleaning up how drawing areas are
encoded/ecoded.

Fixes <http://webkit.org/b/46468> DrawingAreaInfo should be used in
more places

Reviewed by Anders Carlsson.

  • Shared/DrawingAreaBase.cpp:

(WebKit::DrawingAreaBase::encode): Changed to use info().

  • Shared/DrawingAreaBase.h:

(WebKit::DrawingAreaBase::info): Added. Replaces type() and id().
(WebKit::DrawingAreaBase::DrawingAreaBase): Changed to store a
DrawingAreaInfo instead of storing its constituent parts.

  • UIProcess/API/mac/WKView.mm:
  • UIProcess/ChunkedUpdateDrawingAreaProxy.cpp:
  • UIProcess/LayerBackedDrawingAreaProxy.cpp:
  • WebProcess/WebPage/ChunkedUpdateDrawingArea.cpp:
  • WebProcess/WebPage/LayerBackedDrawingArea.cpp:
  • WebProcess/WebPage/WebPage.cpp:

Updated to use info().

10:22 AM Changeset in webkit [68268] by mihaip@chromium.org
  • 3 edits in trunk/WebKitTools

2010-09-24 Mihai Parparita <mihaip@chromium.org>

Reviewed by Tony Chang.

NRWT doesn't respect config set with set-webkit-configuration
https://bugs.webkit.org/show_bug.cgi?id=46278

Use Port.default_configuration() instead of hardcoding Release in
ChromiumPort configuration initialization, so that we still inherit the
configuration set by set-webkit-configuration.

  • Scripts/webkitpy/layout_tests/port/chromium.py:
  • Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
10:20 AM Changeset in webkit [68267] by andersca@apple.com
  • 2 edits
    2 adds in trunk/WebKit2

Add WebProcessConnection class
https://bugs.webkit.org/show_bug.cgi?id=46478

Reviewed by Sam Weinig.

  • PluginProcess/WebProcessConnection.cpp: Added.
  • PluginProcess/WebProcessConnection.h: Added.

Add stubbed out WebProcessConnection class.

  • WebKit2.xcodeproj/project.pbxproj:

Add files.

10:17 AM Changeset in webkit [68266] by ap@apple.com
  • 2 edits in trunk/WebKit/mac

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=46380
REGRESSION: Crash when downloading a file

Downloading cannot be tested in DRT.

  • Misc/WebNSFileManagerExtras.m: (-[NSFileManager _webkit_setMetadataURL:referrer:atPath:]): Don't copy null strings.
10:03 AM Changeset in webkit [68265] by tony@chromium.org
  • 2 edits
    5 deletes in trunk/LayoutTests

2010-09-24 Tony Chang <tony@chromium.org>

Reviewed by Kent Tamura.

[chromium] Remove a bad baseline and clean up a comment
https://bugs.webkit.org/show_bug.cgi?id=46446

  • platform/chromium-linux/svg/filters/filterRes-expected.checksum: Removed.
  • platform/chromium-linux/svg/filters/filterRes-expected.png: Removed.
  • platform/chromium-win/svg/filters/filterRes-expected.checksum: Removed.
  • platform/chromium-win/svg/filters/filterRes-expected.png: Removed.
  • platform/chromium-win/svg/filters/filterRes-expected.txt: Removed.
  • platform/chromium/test_expectations.txt:
10:03 AM Changeset in webkit [68264] by andersca@apple.com
  • 4 edits
    2 copies in trunk/WebKit2

Add PluginProcess class
https://bugs.webkit.org/show_bug.cgi?id=46476

Reviewed by Sam Weinig.

  • PluginProcess/PluginProcess.cpp: Added.
  • PluginProcess/PluginProcess.h: Added.

Add stubbed out PluginProcess class.

  • PluginProcess/mac/PluginProcessMainMac.mm:

(WebKit::PluginProcessMain):
Initialize the plug-in process.

  • WebKit2.xcodeproj/project.pbxproj:

Add files.

  • WebProcess/Plugins/PluginProcessConnection.h:

Add a comment about which connection this is.

9:51 AM Changeset in webkit [68263] by Nate Chapin
  • 2 edits in trunk/LayoutTests

2010-09-24 Nate Chapin <Nate Chapin>

Unreviewed, chromium expectations update.

http/tests/navigation/ping-* are passing now
that they have had their LayoutTestController patch.

  • platform/chromium/test_expectations.txt:
9:37 AM Changeset in webkit [68262] by weinig@apple.com
  • 2 edits in trunk/WebKit2

Fix windows build.

  • Shared/win/PlatformCertificateInfo.cpp:

(WebKit::PlatformCertificateInfo::PlatformCertificateInfo):

9:17 AM Changeset in webkit [68261] by caseq@chromium.org
  • 2 edits in trunk/WebCore

2010-09-24 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Clicking "Select All" in audits panel has no effect when the checkbox is unchecked
Only add category event listeners to real categories, not to "Select All"
https://bugs.webkit.org/show_bug.cgi?id=46467

  • inspector/front-end/AuditLauncherView.js: (WebInspector.AuditLauncherView.prototype._createCategoryElement):
9:10 AM Changeset in webkit [68260] by weinig@apple.com
  • 5 edits
    3 adds in trunk/WebKit2

Add Windows implementation of PlatformCertificateInfo
Part of < rdar://problem/8350189>
https://bugs.webkit.org/show_bug.cgi?id=46450

Reviewed by Adam Roben.

  • Shared/win/PlatformCertificateInfo.cpp: Added.

(WebKit::PlatformCertificateInfo::PlatformCertificateInfo):
(WebKit::PlatformCertificateInfo::~PlatformCertificateInfo):
(WebKit::PlatformCertificateInfo::encode):
(WebKit::PlatformCertificateInfo::decode):
(WebKit::organizationNameForCertificate):

  • Shared/win/PlatformCertificateInfo.h:

(WebKit::PlatformCertificateInfo::certificateContext):

  • UIProcess/API/C/win/WKCertificateInfoWin.cpp: Added.

(WKCertificateInfoGetCertificateContext):

  • UIProcess/API/C/win/WKCertificateInfoWin.h: Added.
  • win/WebKit2.vcproj:
  • win/WebKit2Generated.make:
9:10 AM Changeset in webkit [68259] by chang.shu@nokia.com
  • 2 edits in trunk/WebKitTools

2010-09-24 Chang Shu <chang.shu@nokia.com>

Reviewed by Csaba Osztrogonác.

[Qt] Fix the code to check file existence.
https://bugs.webkit.org/show_bug.cgi?id=46465

  • QtTestBrowser/main.cpp: (main):
9:01 AM Changeset in webkit [68258] by kenneth@webkit.org
  • 6 edits in trunk/WebKit2

Add WebKit2 C API for setting the font families.
https://bugs.webkit.org/show_bug.cgi?id=46408

Reviewed by Sam Weinig.

  • UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesSetStandardFontFamily):
(WebPreferencesCopyStandardFontFamily):
(WKPreferencesSetFixedFontFamily):
(WKPreferencesCopyFixedFontFamily):
(WKPreferencesSetSerifFontFamily):
(WKPreferencesCopySerifFontFamily):
(WKPreferencesSetSansSerifFontFamily):
(WKPreferencesCopySansSerifFontFamily):
(WKPreferencesSetCursiveFontFamily):
(WKPreferencesCopyCursiveFontFamily):
(WKPreferencesSetFantasyFontFamily):
(WKPreferencesCopyFantasyFontFamily):

  • UIProcess/API/C/WKPreferences.h:
  • UIProcess/WebPreferences.cpp:

(WebKit::WebPreferences::setStandardFontFamily):
(WebKit::WebPreferences::standardFontFamily):
(WebKit::WebPreferences::setFixedFontFamily):
(WebKit::WebPreferences::fixedFontFamily):
(WebKit::WebPreferences::setSerifFontFamily):
(WebKit::WebPreferences::serifFontFamily):
(WebKit::WebPreferences::setSansSerifFontFamily):
(WebKit::WebPreferences::sansSerifFontFamily):
(WebKit::WebPreferences::setCursiveFontFamily):
(WebKit::WebPreferences::cursiveFontFamily):
(WebKit::WebPreferences::setFantasyFontFamily):
(WebKit::WebPreferences::fantasyFontFamily):

  • UIProcess/WebPreferences.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::preferencesDidChange):

8:58 AM Changeset in webkit [68257] by hans@chromium.org
  • 3 edits in trunk/WebCore

2010-09-24 Hans Wennborg <hans@chromium.org>

Reviewed by Steve Block.

Remove unnecessary casts in DeviceOrientation V8 bindings
https://bugs.webkit.org/show_bug.cgi?id=46466

Remove unnecessary casts of v8::Value::NumberValue() to double from
the custom v8 bindings code for DeviceOrientation/Motion.

No new tests: just cleanup, no new functionality.

  • bindings/v8/custom/V8DeviceMotionEventCustom.cpp: (WebCore::V8DeviceMotionEvent::initDeviceMotionEventCallback):
  • bindings/v8/custom/V8DeviceOrientationEventCustom.cpp: (WebCore::V8DeviceOrientationEvent::initDeviceOrientationEventCallback):
8:45 AM Changeset in webkit [68256] by loislo@chromium.org
  • 6 edits in trunk/WebCore

2010-09-24 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: move searchingForNode flag in InspectorController under control of InspectorCookies.

Four functions from Inspector IDL go away.
Searching for node feature of Inspector keeps alive even after navigation.

https://bugs.webkit.org/show_bug.cgi?id=46462

  • inspector/Inspector.idl:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::updateInspectorStateCookie): (WebCore::InspectorController::restoreInspectorStateFromCookie): (WebCore::InspectorController::setSearchingForNode): (WebCore::InspectorController::populateScriptObjects):
  • inspector/InspectorController.h:
  • inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel.prototype.hide): (WebInspector.ElementsPanel.prototype.updateFocusedNode): (WebInspector.ElementsPanel.prototype._setSearchingForNode): (WebInspector.ElementsPanel.prototype.setSearchingForNode): (WebInspector.ElementsPanel.prototype.toggleSearchingForNode):
  • inspector/front-end/inspector.js: (WebInspector._updateFocusedNode):
8:42 AM Changeset in webkit [68255] by satish@chromium.org
  • 2 edits in trunk/LayoutTests

2010-09-24 Satish Sampath <satish@chromium.org>

Unreviewed, updating the baseline for a speech input layout test.

  • fast/speech/input-text-speechbutton-expected.txt:
8:23 AM Changeset in webkit [68254] by andreip@google.com
  • 2 edits in trunk/WebCore

2010-09-24 Andrei Popescu <andreip@google.com>

Reviewed by Jeremy Orlow.

IDBTransactionCoordinator incorrectly assumes that aborted transactions must have been started or running.
https://bugs.webkit.org/show_bug.cgi?id=46459

No new tests, storage/indexeddb/transaction-basics.html covers this.

Also fixes http://code.google.com/p/chromium/issues/detail?id=56732

  • storage/IDBTransactionCoordinator.cpp: (WebCore::IDBTransactionCoordinator::didFinishTransaction):
8:08 AM Changeset in webkit [68253] by satish@chromium.org
  • 2 edits in trunk/LayoutTests

2010-09-24 Satish Sampath <satish@chromium.org>

Reviewed by NOBODY (OOPS!).

Remove chromium test expectation entries for 3 tests which pass now.
https://bugs.webkit.org/show_bug.cgi?id=46457

These tests were marked as fail when the related images were being updated so removing the
entries now that the new images have landed.

  • platform/chromium/test_expectations.txt:
7:38 AM Changeset in webkit [68252] by hans@chromium.org
  • 13 edits in trunk

2010-09-24 Hans Wennborg <hans@chromium.org>

Reviewed by Steve Block.

Update DeviceMotionEvent to spec
https://bugs.webkit.org/show_bug.cgi?id=46344

  • fast/dom/DeviceMotion/script-tests/create-event.js:
  • fast/dom/DeviceMotion/create-event-expected.txt: Look for the new attributes.
  • fast/dom/DeviceMotion/script-tests/optional-event-properties.js:
  • fast/dom/DeviceMotion/optional-event-properties-expected.txt: Test the new attributes.
  • fast/dom/script-tests/prototype-inheritance.js: DeviceMotionEvent is not implemented on all platforms, so it should be skipped in this test. This is necessary for platforms that enable the feature to pass the layout tests.

2010-09-24 Hans Wennborg <hans@chromium.org>

Reviewed by Steve Block.

Update DeviceMotionEvent to spec
https://bugs.webkit.org/show_bug.cgi?id=46344

The spec has changed: the DeviceMotionEvent attributes accelerationX,
accelerationY, etc. have been baked into an 'acceleration' attribute
which returns an object with x, y, and z values. Likewise for the
rotation rate. The 'accelerationIncludingGravity' attribute is new.

  • WebCore.exp.in: The DeviceMotionData::create member function has changed. Also export create functions for DeviceMotionData::Acceleration and RotationRate.
  • bindings/js/JSDeviceMotionEventCustom.cpp: (WebCore::JSDeviceMotionEvent::acceleration): (WebCore::JSDeviceMotionEvent::accelerationIncludingGravity): (WebCore::JSDeviceMotionEvent::rotationRate): (WebCore::JSDeviceMotionEvent::initDeviceMotionEvent): Manually create and return objects with the right attributes for acceleration, accelerationIncludingGravity, and rotationRate. When creating the DeviceMotionData object in initDeviceMotionEvent, accept any input objects that have the right attributes.
  • bindings/v8/custom/V8DeviceMotionEventCustom.cpp: (WebCore::V8DeviceMotionEvent::accelerationAccessorGetter): (WebCore::V8DeviceMotionEvent::accelerationIncludingGravityAccessorGetter): (WebCore::V8DeviceMotionEvent::rotationRateAccessorGetter): (WebCore::V8DeviceMotionEvent::initDeviceMotionEventCallback): V8 counterpart to the JSC code above.
  • dom/DeviceMotionData.cpp: (WebCore::DeviceMotionData::Acceleration::create): (WebCore::DeviceMotionData::Acceleration::Acceleration): (WebCore::DeviceMotionData::RotationRate::create): (WebCore::DeviceMotionData::RotationRate::RotationRate): (WebCore::DeviceMotionData::create): (WebCore::DeviceMotionData::DeviceMotionData):
  • dom/DeviceMotionData.h: (WebCore::DeviceMotionData::Acceleration::canProvideX): (WebCore::DeviceMotionData::Acceleration::canProvideY): (WebCore::DeviceMotionData::Acceleration::canProvideZ): (WebCore::DeviceMotionData::Acceleration::x): (WebCore::DeviceMotionData::Acceleration::y): (WebCore::DeviceMotionData::Acceleration::z): (WebCore::DeviceMotionData::RotationRate::canProvideAlpha): (WebCore::DeviceMotionData::RotationRate::canProvideBeta): (WebCore::DeviceMotionData::RotationRate::canProvideGamma): (WebCore::DeviceMotionData::RotationRate::alpha): (WebCore::DeviceMotionData::RotationRate::beta): (WebCore::DeviceMotionData::RotationRate::gamma): (WebCore::DeviceMotionData::acceleration): (WebCore::DeviceMotionData::accelerationIncludingGravity): (WebCore::DeviceMotionData::rotationRate): Add member classes Acceleration and RotationRate to DeviceMotionData.
  • dom/DeviceMotionEvent.idl: Update according to the spec. Acceleration and RotationRate need not be backed by native classes.
7:26 AM Changeset in webkit [68251] by Simon Hausmann
  • 4 edits in trunk

[Qt] Fix the Wince build.

Patch by Romain Pokrzywka <romain@kdab.com> on 2010-09-24
Reviewed by Simon Hausmann.

.:

  • WebKit.pri: Apply msvc flags to wince, too.

WebCore:

  • WebCore.pro: Apply msvc flags to wince, too.
7:24 AM Changeset in webkit [68250] by Simon Hausmann
  • 2 edits in trunk/WebCore

[Qt] Enable building Qt/Webkit with debug symbols

Patch by Anders Bakken <agbakken@gmail.com> on 2010-09-24
Reviewed by Simon Hausmann.

With this patch one can configure with -webkit-debug to build Webkit
with debug symbols without having to manually edit WebCore.pro.

  • WebCore.pro:
6:46 AM Changeset in webkit [68249] by vestbo@webkit.org
  • 2 edits in trunk/BugsSite

Support Unicode-strings in committers-autocomplete script

Reviewed by Csaba Osztrogonác.

  • committers-autocomplete.js:
5:44 AM Changeset in webkit [68248] by yael.aharon@nokia.com
  • 2 edits in trunk/WebCore

2010-09-24 Yael Aharon <yael.aharon@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Web Sockets are insecure with QtWebKit
https://bugs.webkit.org/show_bug.cgi?id=44769

Throw an error when the server certificate is not valid.
DRT currently does not support secure websocket connection,
so no new tests. This was tested with the server at
http://code.google.com/p/pywebsocket instead.

  • platform/network/qt/SocketStreamHandleQt.cpp: (WebCore::SocketStreamHandlePrivate::socketSslErrors):
5:08 AM Changeset in webkit [68247] by loislo@chromium.org
  • 2 edits in trunk/WebKit/mac

2010-09-24 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: CRASH at node highlight on MAC Safari.
1) run-safari --debug
2) open inspector
3) open elements panel
4) hover mouse over elements panel items multiple times
5) CRASH
Looks like it is a race condition. WebNodeHighlightView doesn't check
the pointer to WebNodeHighligh object and it can be nil.

https://bugs.webkit.org/show_bug.cgi?id=46261

  • WebInspector/WebNodeHighlightView.mm: (-[WebNodeHighlightView drawRect:]):
4:31 AM Changeset in webkit [68246] by satish@chromium.org
  • 20 edits in trunk/LayoutTests

2010-09-24 Satish Sampath <satish@chromium.org>

Reviewed by Jeremy Orlow.

Update speech button image baselines for chromium port.
https://bugs.webkit.org/show_bug.cgi?id=46457

  • platform/chromium-linux/fast/speech/input-appearance-numberandspeech-expected.checksum:
  • platform/chromium-linux/fast/speech/input-appearance-numberandspeech-expected.png:
  • platform/chromium-linux/fast/speech/input-appearance-searchandspeech-expected.checksum:
  • platform/chromium-linux/fast/speech/input-appearance-searchandspeech-expected.png:
  • platform/chromium-linux/fast/speech/input-appearance-speechbutton-expected.checksum:
  • platform/chromium-linux/fast/speech/input-appearance-speechbutton-expected.png:
  • platform/chromium-mac/fast/speech/input-appearance-numberandspeech-expected.checksum:
  • platform/chromium-mac/fast/speech/input-appearance-numberandspeech-expected.png:
  • platform/chromium-mac/fast/speech/input-appearance-searchandspeech-expected.checksum:
  • platform/chromium-mac/fast/speech/input-appearance-searchandspeech-expected.png:
  • platform/chromium-mac/fast/speech/input-appearance-speechbutton-expected.checksum:
  • platform/chromium-mac/fast/speech/input-appearance-speechbutton-expected.png:
  • platform/chromium-win/fast/speech/input-appearance-numberandspeech-expected.checksum:
  • platform/chromium-win/fast/speech/input-appearance-numberandspeech-expected.png:
  • platform/chromium-win/fast/speech/input-appearance-searchandspeech-expected.checksum:
  • platform/chromium-win/fast/speech/input-appearance-searchandspeech-expected.png:
  • platform/chromium-win/fast/speech/input-appearance-speechbutton-expected.checksum:
  • platform/chromium-win/fast/speech/input-appearance-speechbutton-expected.png:
  • platform/chromium/test_expectations.txt: Disables above tests, they will get enabled again after the chromium patch is submitted.
3:16 AM Changeset in webkit [68245] by caseq@chromium.org
  • 1 edit
    14 adds in trunk/LayoutTests

2010-09-24 Andrey Kosyakov <caseq@chromium.org>

Unreviewed test expectations update after new tests in 68233.

  • platform/chromium-linux/animations/suspend-transform-animation-expected.png: Added.
  • platform/chromium-linux/transitions/suspend-transform-transition-expected.png: Added.
  • platform/chromium-mac/animations/suspend-transform-animation-expected.checksum: Added.
  • platform/chromium-mac/animations/suspend-transform-animation-expected.png: Added.
  • platform/chromium-mac/transitions/suspend-transform-transition-expected.checksum: Added.
  • platform/chromium-mac/transitions/suspend-transform-transition-expected.png: Added.
  • platform/chromium-win-xp/animations/suspend-transform-animation-expected.png: Added.
  • platform/chromium-win-xp/transitions/suspend-transform-transition-expected.png: Added.
  • platform/chromium-win/animations/suspend-transform-animation-expected.checksum: Added.
  • platform/chromium-win/animations/suspend-transform-animation-expected.png: Added.
  • platform/chromium-win/transitions/suspend-transform-transition-expected.checksum: Added.
  • platform/chromium-win/transitions/suspend-transform-transition-expected.png: Added.
2:13 AM Changeset in webkit [68244] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

2010-09-24 James Kozianski <koz@chromium.org>

Reviewed by Ojan Vafai.

[chromium] Updated test expectations to match the bots using new auto-update script.
https://bugs.webkit.org/show_bug.cgi?id=46452

Updated expectations to match the bots using the new auto-update script.

  • platform/chromium/test_expectations.txt:
1:44 AM Changeset in webkit [68243] by commit-queue@webkit.org
  • 4 edits in trunk/WebCore

2010-09-24 Jia Pu <jpu@apple.com>

Reviewed by Shinichiro Hamaji.

Need to remove autocorrection underlines in current line when newline is entered.
https://bugs.webkit.org/show_bug.cgi?id=45709
<rdar://problem/8335576>

This change affects only Mac OSX build.

  • dom/DocumentMarker.h: Added "CorrectionIndicator" to indicate the words on which we need to draw autocorrection underline. We cannot use existing "Replacement" for this purpose, since it is not meant to be removed once it is added. But we need to remove all autocorrection underlines when a line break or paragraph separator is inserted, which is the behavior in NSTextView. Hence we need a separate marker value for drawing autocorrection underline.
  • editing/Editor.cpp: (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges): Add "CorrectionIndicator" when autocorrection takes place. (WebCore::Editor::changeSelectionAfterCommand): Remove "CorrectionIndicator" markers if the command results in inserting paragraph separator.
  • rendering/InlineTextBox.cpp: (WebCore::textCheckingLineStyleForMarkerType): Use "CorrectionIndicator" marker instead of "Replacement" to draw autocorrection underline. (WebCore::InlineTextBox::paintDocumentMarkers): Ditto.
1:15 AM Changeset in webkit [68242] by commit-queue@webkit.org
  • 8 edits in trunk

2010-09-24 Eric Uhrhane <ericu@chromium.org>

Reviewed by David Levin.

Remove unnecessary parameter from AsyncFileWriterClient::didTruncate
https://bugs.webkit.org/show_bug.cgi?id=46390

  • fileapi/AsyncFileWriterClient.h:

Added state to FileWriter to replace the parameter.

  • fileapi/FileWriter.h:
  • fileapi/FileWriter.cpp: (WebCore::FileWriter::truncate): (WebCore::FileWriter::didTruncate):

2010-09-24 Eric Uhrhane <ericu@chromium.org>

Reviewed by David Levin.

Remove unnecessary parameter from AsyncFileWriterClient::didTruncate
https://bugs.webkit.org/show_bug.cgi?id=46390

  • public/WebFileWriterClient.h:
  • src/AsyncFileWriterChromium.cpp:
  • src/AsyncFileWriterChromium.h:
1:02 AM Changeset in webkit [68241] by commit-queue@webkit.org
  • 13 edits in trunk

2010-09-24 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r68236.
http://trac.webkit.org/changeset/68236
https://bugs.webkit.org/show_bug.cgi?id=46449

compile fix didn't work (Requested by dino_ on #webkit).

  • fast/dom/DeviceMotion/create-event-expected.txt:
  • fast/dom/DeviceMotion/optional-event-properties-expected.txt:
  • fast/dom/DeviceMotion/script-tests/create-event.js:
  • fast/dom/DeviceMotion/script-tests/optional-event-properties.js:
  • fast/dom/script-tests/prototype-inheritance.js:

2010-09-24 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r68236.
http://trac.webkit.org/changeset/68236
https://bugs.webkit.org/show_bug.cgi?id=46449

compile fix didn't work (Requested by dino_ on #webkit).

  • WebCore.exp.in:
  • bindings/js/JSDeviceMotionEventCustom.cpp: (WebCore::JSDeviceMotionEvent::xAcceleration): (WebCore::JSDeviceMotionEvent::yAcceleration): (WebCore::JSDeviceMotionEvent::zAcceleration): (WebCore::JSDeviceMotionEvent::xRotationRate): (WebCore::JSDeviceMotionEvent::yRotationRate): (WebCore::JSDeviceMotionEvent::zRotationRate): (WebCore::JSDeviceMotionEvent::initDeviceMotionEvent):
  • bindings/v8/custom/V8DeviceMotionEventCustom.cpp: (WebCore::V8DeviceMotionEvent::xAccelerationAccessorGetter): (WebCore::V8DeviceMotionEvent::yAccelerationAccessorGetter): (WebCore::V8DeviceMotionEvent::zAccelerationAccessorGetter): (WebCore::V8DeviceMotionEvent::xRotationRateAccessorGetter): (WebCore::V8DeviceMotionEvent::yRotationRateAccessorGetter): (WebCore::V8DeviceMotionEvent::zRotationRateAccessorGetter): (WebCore::V8DeviceMotionEvent::initDeviceMotionEventCallback):
  • dom/DeviceMotionData.cpp: (WebCore::DeviceMotionData::create): (WebCore::DeviceMotionData::DeviceMotionData):
  • dom/DeviceMotionData.h: (WebCore::DeviceMotionData::xAcceleration): (WebCore::DeviceMotionData::yAcceleration): (WebCore::DeviceMotionData::zAcceleration): (WebCore::DeviceMotionData::xRotationRate): (WebCore::DeviceMotionData::yRotationRate): (WebCore::DeviceMotionData::zRotationRate): (WebCore::DeviceMotionData::canProvideXAcceleration): (WebCore::DeviceMotionData::canProvideYAcceleration): (WebCore::DeviceMotionData::canProvideZAcceleration): (WebCore::DeviceMotionData::canProvideXRotationRate): (WebCore::DeviceMotionData::canProvideYRotationRate): (WebCore::DeviceMotionData::canProvideZRotationRate):
  • dom/DeviceMotionEvent.idl:
12:51 AM Changeset in webkit [68240] by commit-queue@webkit.org
  • 35 edits
    1 copy in trunk

2010-09-24 Chris Guillory <chris.guillory@google.com>

Reviewed by Chris Fleizach.

Send webkit accessibility notifications to Chromium.
https://bugs.webkit.org/show_bug.cgi?id=45156

  • platform/chromium/accessibility/post-notification-ActiveDescendantChanged-expected.txt:
  • platform/chromium/accessibility/post-notification-CheckedStateChanged-expected.txt:
  • platform/chromium/accessibility/post-notification-ChildrenChanged-expected.txt:
  • platform/chromium/accessibility/post-notification-FocusedUIElementChanged-expected.txt:
  • platform/chromium/accessibility/post-notification-FocusedUIElementChanged.html:
  • platform/chromium/accessibility/post-notification-LayoutComplete-expected.txt:
  • platform/chromium/accessibility/post-notification-LayoutComplete.html:
  • platform/chromium/accessibility/post-notification-LiveRegionChanged-expected.txt:
  • platform/chromium/accessibility/post-notification-LoadComplete-expected.txt:
  • platform/chromium/accessibility/post-notification-LoadComplete.html:
  • platform/chromium/accessibility/post-notification-MenuListValueChanged-expected.txt:
  • platform/chromium/accessibility/post-notification-RowCollapsed-expected.txt:
  • platform/chromium/accessibility/post-notification-RowCountChanged-expected.txt:
  • platform/chromium/accessibility/post-notification-RowExpanded-expected.txt:
  • platform/chromium/accessibility/post-notification-ScrolledToAnchor-expected.txt:
  • platform/chromium/accessibility/post-notification-ScrolledToAnchor.html:
  • platform/chromium/accessibility/post-notification-SelectedChildrenChanged-expected.txt:
  • platform/chromium/accessibility/post-notification-SelectedTextChanged-expected.txt:
  • platform/chromium/accessibility/post-notification-SelectedTextChanged.html:
  • platform/chromium/accessibility/post-notification-ValueChanged-expected.txt:
  • platform/chromium/accessibility/post-notification.js: (test):

2010-09-24 Chris Guillory <chris.guillory@google.com>

Reviewed by Chris Fleizach.

Send webkit accessibility notifications to Chromium.
https://bugs.webkit.org/show_bug.cgi?id=45156

  • WebCore.gypi:
  • accessibility/chromium/AXObjectCacheChromium.cpp: (WebCore::AXObjectCache::postPlatformNotification): (WebCore::AXObjectCache::handleFocusedUIElementChanged): (WebCore::AXObjectCache::handleScrolledToAnchor):
  • dom/Document.cpp: (WebCore::Document::implicitClose): (WebCore::Document::setFocusedNode):
  • editing/SelectionController.h:
  • page/ChromeClient.h: (WebCore::ChromeClient::postAccessibilityNotification):
  • page/FrameView.cpp: (WebCore::FrameView::layout):

2010-09-24 Chris Guillory <chris.guillory@google.com>

Reviewed by Chris Fleizach.

Send webkit accessibility notifications to Chromium.
https://bugs.webkit.org/show_bug.cgi?id=45156

  • public/WebAccessibilityCache.h:
  • public/WebViewClient.h:
  • src/ChromeClientImpl.cpp: (WebKit::ChromeClientImpl::focusedNodeChanged): (WebKit::ChromeClientImpl::getPopupMenuInfo):
  • src/ChromeClientImpl.h:
  • src/WebAccessibilityCache.cpp: (WebKit::WebAccessibilityCache::accessibilityEnabled):
12:26 AM Changeset in webkit [68239] by hyatt@apple.com
  • 24 edits in trunk/WebCore

https://bugs.webkit.org/show_bug.cgi?id=46454, rename a bunch of the width and height calculation methods.

Reviewed by Maciej Stachowiak.

calcReplacedWidth -> computeReplacedWidth

calcHorizontalMargins -> computeInlineDirectionMargins

calcVerticalMargins -> computeBlockDirectionMargins

calcWidthUsing -> computeLogicalWidthUsing

calcHeightUsing -> computeLogicalHeightUsing

calcReplacedHeight/HeightUsing -> computeReplacedHeight/HeightUsing

calcAbsoluteHorizontalValues -> computePositionedLogicalWidthUsing

calcAbsoluteVerticalValues -> computePositionedLogicalHeightUsing

calcAbsoluteHorizontal -> computePositionedLogicalWIdth

calcAbsoluteVertical -> computePositionedLogicalHeight

calcAbsoluteHorizontalReplaced -> computePositionedLogicalWidthReplaced

calcAbsoluteVerticalReplaced -> computePositionedLogicalHeightReplaced

calcBorderBoxWidth/Height -> computeBorderBoxLogicalWidth/LogicalHeight

calcContentBoxWidth/Height -> computeContentBoxLogicalWidth/LogicalHeight

shouldCalculateSizeAsReplaced -> shouldComputeSizeAsReplaced

calcPercentageHeight -> computePercentageLogicalHeight

  • rendering/AutoTableLayout.cpp:

(WebCore::AutoTableLayout::recalcColumn):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::adjustPositionedBlock):
(WebCore::RenderBlock::determineHorizontalPosition):
(WebCore::RenderBlock::layoutBlockChild):
(WebCore::RenderBlock::insertFloatingObject):
(WebCore::RenderBlock::calcPrefWidths):

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::computeBorderBoxLogicalWidth):
(WebCore::RenderBox::computeBorderBoxLogicalHeight):
(WebCore::RenderBox::computeContentBoxLogicalWidth):
(WebCore::RenderBox::computeContentBoxLogicalHeight):
(WebCore::RenderBox::computeLogicalWidth):
(WebCore::RenderBox::computeLogicalWidthUsing):
(WebCore::RenderBox::computeInlineDirectionMargins):
(WebCore::RenderBox::computeLogicalHeight):
(WebCore::RenderBox::computeLogicalHeightUsing):
(WebCore::RenderBox::computePercentageLogicalHeight):
(WebCore::RenderBox::computeReplacedWidth):
(WebCore::RenderBox::computeReplacedWidthUsing):
(WebCore::RenderBox::computeReplacedHeight):
(WebCore::RenderBox::computeReplacedHeightUsing):
(WebCore::RenderBox::availableHeightUsing):
(WebCore::RenderBox::computeBlockDirectionMargins):
(WebCore::RenderBox::computePositionedLogicalWidth):
(WebCore::RenderBox::computePositionedLogicalWidthUsing):
(WebCore::RenderBox::computePositionedLogicalHeight):
(WebCore::RenderBox::computePositionedLogicalHeightUsing):
(WebCore::RenderBox::computePositionedLogicalWidthReplaced):
(WebCore::RenderBox::computePositionedLogicalHeightReplaced):

  • rendering/RenderBox.h:

(WebCore::RenderBox::shouldComputeSizeAsReplaced):

  • rendering/RenderDataGrid.cpp:

(WebCore::RenderDataGrid::calcPrefWidths):

  • rendering/RenderFileUploadControl.cpp:

(WebCore::RenderFileUploadControl::calcPrefWidths):

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::calcPrefWidths):
(WebCore::RenderFlexibleBox::layoutHorizontalBox):
(WebCore::RenderFlexibleBox::layoutVerticalBox):

  • rendering/RenderImage.cpp:

(WebCore::RenderImage::computeReplacedWidth):
(WebCore::RenderImage::computeReplacedHeight):
(WebCore::RenderImage::calcAspectRatioWidth):
(WebCore::RenderImage::calcAspectRatioHeight):

  • rendering/RenderImage.h:
  • rendering/RenderListBox.cpp:

(WebCore::RenderListBox::calcPrefWidths):

  • rendering/RenderMenuList.cpp:

(WebCore::RenderMenuList::calcPrefWidths):

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::container):

  • rendering/RenderObject.h:

(WebCore::RenderObject::computeBlockDirectionMargins):

  • rendering/RenderReplaced.cpp:

(WebCore::RenderReplaced::computeReplacedWidth):
(WebCore::RenderReplaced::computeReplacedHeight):
(WebCore::RenderReplaced::calcAspectRatioWidth):
(WebCore::RenderReplaced::calcAspectRatioHeight):
(WebCore::RenderReplaced::calcPrefWidths):

  • rendering/RenderReplaced.h:
  • rendering/RenderSVGRoot.cpp:

(WebCore::RenderSVGRoot::calcPrefWidths):
(WebCore::RenderSVGRoot::computeReplacedWidth):
(WebCore::RenderSVGRoot::computeReplacedHeight):

  • rendering/RenderSVGRoot.h:
  • rendering/RenderSlider.cpp:

(WebCore::RenderSlider::calcPrefWidths):

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::computeLogicalWidth):
(WebCore::RenderTable::layout):

  • rendering/RenderTableRow.cpp:

(WebCore::RenderTableRow::layout):

  • rendering/RenderTextControl.cpp:

(WebCore::RenderTextControl::calcPrefWidths):

  • rendering/RenderVideo.cpp:

(WebCore::RenderVideo::computeReplacedWidth):
(WebCore::RenderVideo::computeReplacedHeight):

  • rendering/RenderVideo.h:

Sep 23, 2010:

11:45 PM Changeset in webkit [68238] by hyatt@apple.com
  • 32 edits in trunk/WebCore

https://bugs.webkit.org/show_bug.cgi?id=46451

Reviewed by Sam Weinig.

Rename calcWidth to computeLogicalWidth. Rename calcHeight to computeLogicalHeight.

  • rendering/RenderApplet.cpp:

(WebCore::RenderApplet::layout):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::layoutBlock):
(WebCore::RenderBlock::insertFloatingObject):
(WebCore::RenderBlock::getClearDelta):

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::computeInlineDirectionPositionsForLine):

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::computeLogicalWidth):
(WebCore::RenderBox::computeLogicalHeight):
(WebCore::RenderBox::calcPercentageHeight):
(WebCore::RenderBox::calcReplacedHeightUsing):
(WebCore::RenderBox::availableHeightUsing):
(WebCore::RenderBox::calcAbsoluteHorizontal):

  • rendering/RenderBox.h:

(WebCore::RenderBox::tryLayoutDoingPositionedMovementOnly):

  • rendering/RenderEmbeddedObject.cpp:

(WebCore::RenderEmbeddedObject::layout):

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::layoutBlock):
(WebCore::RenderFlexibleBox::layoutHorizontalBox):
(WebCore::RenderFlexibleBox::layoutVerticalBox):

  • rendering/RenderForeignObject.cpp:

(WebCore::RenderForeignObject::computeLogicalWidth):
(WebCore::RenderForeignObject::computeLogicalHeight):

  • rendering/RenderForeignObject.h:
  • rendering/RenderHTMLCanvas.cpp:

(WebCore::RenderHTMLCanvas::canvasSizeChanged):

  • rendering/RenderIFrame.cpp:

(WebCore::RenderIFrame::computeLogicalHeight):
(WebCore::RenderIFrame::computeLogicalWidth):
(WebCore::RenderIFrame::layout):

  • rendering/RenderIFrame.h:
  • rendering/RenderImage.cpp:

(WebCore::RenderImage::imageChanged):

  • rendering/RenderIndicator.cpp:

(WebCore::RenderIndicator::layout):

  • rendering/RenderListBox.cpp:

(WebCore::RenderListBox::computeLogicalHeight):

  • rendering/RenderListBox.h:
  • rendering/RenderMeter.cpp:

(WebCore::RenderMeter::computeLogicalWidth):
(WebCore::RenderMeter::computeLogicalHeight):

  • rendering/RenderMeter.h:
  • rendering/RenderReplaced.cpp:

(WebCore::RenderReplaced::layout):

  • rendering/RenderSVGRoot.cpp:

(WebCore::RenderSVGRoot::layout):

  • rendering/RenderSlider.cpp:

(WebCore::RenderSlider::layout):

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::computeLogicalWidth):
(WebCore::RenderTable::layout):

  • rendering/RenderTable.h:
  • rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::computeLogicalWidth):

  • rendering/RenderTableCell.h:
  • rendering/RenderTextControl.cpp:

(WebCore::RenderTextControl::computeLogicalHeight):

  • rendering/RenderTextControl.h:
  • rendering/RenderTextControlSingleLine.cpp:

(WebCore::RenderTextControlSingleLine::layout):
(WebCore::RenderTextControlSingleLine::textBlockWidth):
(WebCore::RenderTextControlSingleLine::decorationWidthRight):
(WebCore::RenderTextControlSingleLine::preferredDecorationWidthRight):
(WebCore::RenderTextControlSingleLine::adjustControlHeightBasedOnLineHeight):

  • rendering/RenderView.cpp:

(WebCore::RenderView::computeLogicalHeight):
(WebCore::RenderView::computeLogicalWidth):

  • rendering/RenderView.h:
  • svg/SVGSVGElement.cpp:

(WebCore::SVGSVGElement::svgAttributeChanged):

11:24 PM Changeset in webkit [68237] by Csaba Osztrogonác
  • 11 edits in trunk/JavaScriptCore

2010-09-23 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r68223.
http://trac.webkit.org/changeset/68223
https://bugs.webkit.org/show_bug.cgi?id=46448

It broke 2-3 tests on bots (Requested by Ossy on #webkit).

  • bytecode/CodeBlock.cpp: (JSC::CodeBlock::dump):
  • bytecode/Opcode.h:
  • bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::BytecodeGenerator): (JSC::BytecodeGenerator::registerFor): (JSC::BytecodeGenerator::constRegisterFor): (JSC::BytecodeGenerator::emitNewFunction):
  • bytecompiler/BytecodeGenerator.h:
  • interpreter/Interpreter.cpp: (JSC::Interpreter::privateExecute):
  • jit/JIT.cpp: (JSC::JIT::privateCompileMainPass):
  • jit/JIT.h:
  • jit/JITOpcodes.cpp: (JSC::JIT::emit_op_new_func): (JSC::JIT::emit_op_init_arguments):
  • jit/JITOpcodes32_64.cpp: (JSC::JIT::emit_op_new_func): (JSC::JIT::emit_op_init_arguments):
  • parser/Nodes.h:
11:05 PM Changeset in webkit [68236] by dino@apple.com
  • 13 edits in trunk

2010-09-23 Hans Wennborg <hans@chromium.org>

Reviewed by Simon Fraser.

Update DeviceMotionEvent to spec
https://bugs.webkit.org/show_bug.cgi?id=46344

The spec has changed: the DeviceMotionEvent attributes accelerationX,
accelerationY, etc. have been baked into an 'acceleration' attribute
which returns an object with x, y, and z values. Likewise for the
rotation rate. The 'accelerationIncludingGravity' attribute is new.

  • WebCore.exp.in: The DeviceMotionData::create member function has changed. Also export create functions for DeviceMotionData::Acceleration and RotationRate.
  • bindings/js/JSDeviceMotionEventCustom.cpp: (WebCore::JSDeviceMotionEvent::acceleration): (WebCore::JSDeviceMotionEvent::accelerationIncludingGravity): (WebCore::JSDeviceMotionEvent::rotationRate): (WebCore::JSDeviceMotionEvent::initDeviceMotionEvent): Manually create and return objects with the right attributes for acceleration, accelerationIncludingGravity, and rotationRate. When creating the DeviceMotionData object in initDeviceMotionEvent, accept any input objects that have the right attributes.
  • bindings/v8/custom/V8DeviceMotionEventCustom.cpp: (WebCore::V8DeviceMotionEvent::accelerationAccessorGetter): (WebCore::V8DeviceMotionEvent::accelerationIncludingGravityAccessorGetter): (WebCore::V8DeviceMotionEvent::rotationRateAccessorGetter): (WebCore::V8DeviceMotionEvent::initDeviceMotionEventCallback): V8 counterpart to the JSC code above.
  • dom/DeviceMotionData.cpp: (WebCore::DeviceMotionData::Acceleration::create): (WebCore::DeviceMotionData::Acceleration::Acceleration): (WebCore::DeviceMotionData::RotationRate::create): (WebCore::DeviceMotionData::RotationRate::RotationRate): (WebCore::DeviceMotionData::create): (WebCore::DeviceMotionData::DeviceMotionData):
  • dom/DeviceMotionData.h: (WebCore::DeviceMotionData::Acceleration::canProvideX): (WebCore::DeviceMotionData::Acceleration::canProvideY): (WebCore::DeviceMotionData::Acceleration::canProvideZ): (WebCore::DeviceMotionData::Acceleration::x): (WebCore::DeviceMotionData::Acceleration::y): (WebCore::DeviceMotionData::Acceleration::z): (WebCore::DeviceMotionData::RotationRate::canProvideAlpha): (WebCore::DeviceMotionData::RotationRate::canProvideBeta): (WebCore::DeviceMotionData::RotationRate::canProvideGamma): (WebCore::DeviceMotionData::RotationRate::alpha): (WebCore::DeviceMotionData::RotationRate::beta): (WebCore::DeviceMotionData::RotationRate::gamma): (WebCore::DeviceMotionData::acceleration): (WebCore::DeviceMotionData::accelerationIncludingGravity): (WebCore::DeviceMotionData::rotationRate): Add member classes Acceleration and RotationRate to DeviceMotionData.
  • dom/DeviceMotionEvent.idl: Update according to the spec. Acceleration and RotationRate need not be backed by native classes.

2010-09-23 Hans Wennborg <hans@chromium.org>

Reviewed by Simon Fraser.

Update DeviceMotionEvent to spec
https://bugs.webkit.org/show_bug.cgi?id=46344

  • fast/dom/DeviceMotion/script-tests/create-event.js:
  • fast/dom/DeviceMotion/create-event-expected.txt: Look for the new attributes.
  • fast/dom/DeviceMotion/script-tests/optional-event-properties.js:
  • fast/dom/DeviceMotion/optional-event-properties-expected.txt: Test the new attributes.
  • fast/dom/script-tests/prototype-inheritance.js: DeviceMotionEvent is not implemented on all platforms, so it should be skipped in this test.
10:43 PM Changeset in webkit [68235] by Csaba Osztrogonác
  • 4 edits in trunk/WebKit2

Unreviewed buildfix after r68220 on WebKit2.

WebKit2 API: Need way to know when a frame is removed from the hierarchy
https://bugs.webkit.org/show_bug.cgi?id=46432

[Qt] qt_wk_didRemoveFrameFromHierarchy needs to be implemented

  • UIProcess/API/qt/ClientImpl.cpp:

(qt_wk_didRemoveFrameFromHierarchy):

  • UIProcess/API/qt/ClientImpl.h:
  • UIProcess/API/qt/qwkpage.cpp:

(QWKPage::QWKPage):

9:28 PM Changeset in webkit [68234] by tony@chromium.org
  • 2 edits in trunk/WebKitTools

2010-09-23 Tony Chang <tony@chromium.org>

Unreviewed, rolling out r68232.
http://trac.webkit.org/changeset/68232

Broken NRWT on the canary bots.

  • Scripts/webkitpy/layout_tests/port/chromium.py:
9:17 PM Changeset in webkit [68233] by Simon Fraser
  • 11 edits
    8 adds in trunk

2010-09-23 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein.

Accelerated transitions do not suspend/resume properly.
https://bugs.webkit.org/show_bug.cgi?id=43792

Fix suspending of accelerated transitions.

GraphicsLayer changes unify the handling of transitions and animations
in GraphicsLayer. Both are now identified by name, so the code
now refers to "animationName" rather than "keyframesName". Transitions
use a dummy name which is not a valid keyframe identifier.

Tests: animations/suspend-transform-animation.html

transitions/suspend-transform-transition.html

  • page/animation/ImplicitAnimation.h:
  • page/animation/ImplicitAnimation.cpp: (WebCore::ImplicitAnimation::pauseAnimation): Call down to the RenderLayerBacking to tell it that an accelerated transition was paused.
  • platform/graphics/GraphicsLayer.h:
  • platform/graphics/GraphicsLayer.cpp: (WebCore::GraphicsLayer::animationNameForTransition): Create a name for the transition of the given property. (WebCore::GraphicsLayer::addAnimation): Generalize "keyframe" to "animation" in the parameter names. (WebCore::GraphicsLayer::pauseAnimation): ditto (WebCore::GraphicsLayer::removeAnimation): ditto
  • platform/graphics/mac/GraphicsLayerCA.h: Parameter renaming, and some method renames for clarity. (WebCore::GraphicsLayerCA::animationIsRunning): (WebCore::GraphicsLayerCA::LayerPropertyAnimation::LayerPropertyAnimation): struct rename for clarity.
  • platform/graphics/mac/GraphicsLayerCA.mm: (WebCore::animationIdentifier): the animationName already has the property baked in. (WebCore::GraphicsLayerCA::moveOrCopyLayerAnimation): just deals with one animation now. (WebCore::GraphicsLayerCA::moveOrCopyAnimationsForProperty): we have to trawl through m_runningAnimations to get the identifiers for the animations that need to be copied. (WebCore::GraphicsLayerCA::addAnimation): rename parameters. (WebCore::GraphicsLayerCA::pauseAnimation): re-ordered methods here. member var renames. (WebCore::GraphicsLayerCA::removeAnimation): ditto. (WebCore::GraphicsLayerCA::updateLayerAnimations): no need to iterate over m_transitionPropertiesToRemove, and no more divergence between transitions and animations. (WebCore::GraphicsLayerCA::setCAAnimationOnLayer): renames for clarity. (WebCore::GraphicsLayerCA::removeCAAnimationFromLayer): ditto (WebCore::GraphicsLayerCA::pauseCAAnimationOnLayer): ditto (WebCore::GraphicsLayerCA::createAnimationFromKeyframes): renames (WebCore::GraphicsLayerCA::createTransformAnimationsFromKeyframes): renames (WebCore::GraphicsLayerCA::suspendAnimations): whitespace.
  • rendering/RenderLayerBacking.h: Group the transition and animation methods together.
  • rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::animationPaused): Re-ordered methods for clarity. (WebCore::RenderLayerBacking::animationFinished): ditto (WebCore::RenderLayerBacking::startTransition): Use animationNameForTransition() to generate the animation identifier. (WebCore::RenderLayerBacking::transitionPaused): Call pauseAnimation, using animationNameForTransition() to generate the animation identifier. (WebCore::RenderLayerBacking::transitionFinished): Call removeAnimation, using animationNameForTransition() to generate the animation identifier. (WebCore::RenderLayerBacking::notifyAnimationStarted): Moved. (WebCore::RenderLayerBacking::notifySyncRequired): Moved.
8:57 PM Changeset in webkit [68232] by dpranke@chromium.org
  • 2 edits in trunk/WebKitTools

2010-09-23 Dirk Pranke <dpranke@chromium.org>

Unreviewed, build fix.

r68008 broke new-run-webkit-tests in that the chromium ports no
longer respect set-webkit-configuration. The correct fix for this
is being pursued in bug 46278 (along with a bunch of unit tests),
but in the meantime I'm reverting the particular lines that broke
things. This was tested by hand.

  • Scripts/webkitpy/layout_tests/port/chromium.py:
8:54 PM Changeset in webkit [68231] by tony@chromium.org
  • 1 edit
    1 delete in trunk/LayoutTests

2010-09-23 Tony Chang <tony@chromium.org>

Unreviewed. Removing a png that I didn't mean to check in. This
pixel result matches Windows so it doesn't need a png (and I forgot
the checksum file anyway).

  • platform/chromium-linux/svg/custom/broken-internal-references-expected.png: Removed.
8:41 PM Changeset in webkit [68230] by tkent@chromium.org
  • 4 edits in trunk

2010-09-23 Kent Tamura <tkent@chromium.org>

Reviewed by Dimitri Glazkov.

[Chromium] Fix some IndexedDB tests for DRT
https://bugs.webkit.org/show_bug.cgi?id=46444

  • platform/chromium/drt_expectations.txt:

2010-09-23 Kent Tamura <tkent@chromium.org>

Reviewed by Dimitri Glazkov.

[Chromium] Fix some IndexedDB tests for DRT
https://bugs.webkit.org/show_bug.cgi?id=46444

  • DEPS: Roll Chromium revision to 60394, which added WebKitClient::createIDBKeysFromSerializedValuesAndKeyPath() implementation.
8:38 PM Changeset in webkit [68229] by tony@chromium.org
  • 2 edits
    7 adds
    11 deletes in trunk/LayoutTests

2010-09-23 Tony Chang <tony@chromium.org>

Reviewed by Dimitri Glazkov.

[chromium] layout test rebaselines
https://bugs.webkit.org/show_bug.cgi?id=46440

These 2 tests were being skipped for an unknown reason. Remove the results
and mark as failing so we can see it on the flakiness dashboard.

  • platform/chromium-linux/fast/images/svg-background-partial-redraw-expected.checksum: Removed.
  • platform/chromium-linux/fast/images/svg-background-partial-redraw-expected.png: Removed.
  • platform/chromium-win/fast/images/svg-background-partial-redraw-expected.checksum: Removed.
  • platform/chromium-win/fast/images/svg-background-partial-redraw-expected.png: Removed.
  • platform/chromium-win/fast/images/svg-background-partial-redraw-expected.txt: Removed.
  • platform/chromium-win/svg/carto.net/tabgroup-expected.png: Removed.

Small antialiasing difference in borders and font metric differences.

  • platform/chromium-linux/svg/custom/broken-internal-references-expected.png: Added.
  • platform/chromium-linux/svg/custom/broken-internal-references-expected.txt: Added.
  • platform/chromium-win/svg/custom/broken-internal-references-expected.checksum: Added.
  • platform/chromium-win/svg/custom/broken-internal-references-expected.png: Added.
  • platform/chromium-win/svg/custom/broken-internal-references-expected.txt: Added.

This test passes once these bad baselines are removed.

  • platform/chromium-mac/svg/clip-path/clip-path-child-clipped-expected.txt: Removed.
  • platform/chromium-win/svg/clip-path/clip-path-child-clipped-expected.txt: Removed.

I don't think this is correct, so I'm removing the baseline and I
updated test_expecations.txt with a note.

  • platform/chromium-win/svg/custom/use-font-face-crash-expected.checksum: Removed.
  • platform/chromium-win/svg/custom/use-font-face-crash-expected.png: Removed.
  • platform/chromium-win/svg/custom/use-font-face-crash-expected.txt: Removed.

This is just a difference it error text between V8 and JSC.

  • platform/chromium/fast/dom/Window/invalid-protocol-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
7:28 PM Changeset in webkit [68228] by aestes@apple.com
  • 2 edits in trunk/WebKit/mac

2010-09-23 Andy Estes <aestes@apple.com>

Reviewed by Darin Adler.

REGRESSION (r61285): some Dashboard widgets are always invisible due to
HTML parser changes.
https://bugs.webkit.org/show_bug.cgi?id=46435

Enable pre-HTML5 parser quirks if Dashboard is in backward compatibility
mode.

  • WebView/WebView.mm: (-[WebView _needsPreHTML5ParserQuirks]): Renamed from shouldUsePreHTML5ParserQuirks(). Return true if WebCore::Settings::usesDashboardCompatibilityMode() is true. (-[WebView _preferencesChangedNotification:]): (-[WebView _setDashboardBehavior:to:]): Enable pre-HTML5 parser quirks if Dashboard behavior is set to backward compatibility mode.
7:27 PM Changeset in webkit [68227] by hyatt@apple.com
  • 2 edits in trunk/WebCore

https://bugs.webkit.org/show_bug.cgi?id=46442

Reviewed by Sam Weinig.

Disallow the setting of block-flow to anything other than "tb" for all table-related display types
and flexible box display types. By disallowing block-flow on the subclasses of RenderBlock like tables
and flexible boxes, we ensure that alterations to the RenderBlock base class won't result in misrenderings
in tables and flexible boxes that try to specify other block flow values.

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::adjustRenderStyle):

7:12 PM Changeset in webkit [68226] by kinuko@chromium.org
  • 4 edits in trunk/WebKit/chromium

2010-09-23 Kinuko Yasuda <kinuko@chromium.org>

Unreviewed, another attempt to fix build. The code didn't have proper if-defs.

  • src/WebWorkerBase.cpp: (WebKit::WebWorkerBase::openFileSystem):
  • src/WebWorkerBase.h:
  • src/WorkerFileSystemCallbacksBridge.h:
6:54 PM Changeset in webkit [68225] by kinuko@chromium.org
  • 3 edits in trunk/WebKit/chromium

2010-09-23 Kinuko Yasuda <kinuko@chromium.org>

Unreviewed; build fix attempt.

  • src/WebWorkerBase.cpp: (WebKit::WebWorkerBase::openFileSystem):
  • src/WorkerFileSystemCallbacksBridge.h:
6:09 PM Changeset in webkit [68224] by tony@chromium.org
  • 2 edits in trunk/LayoutTests

2010-09-23 Tony Chang <tony@chromium.org>

Unreviewed. Fix a test expecatation for no-caret-repaint-in-non-content-editable-element.html (should be TEXT not TEXT+IMAGE).

  • platform/chromium/test_expectations.txt:
5:52 PM Changeset in webkit [68223] by oliver@apple.com
  • 11 edits in trunk/JavaScriptCore

2010-09-23 Oliver Hunt <oliver@apple.com>

Reviewed by Geoffrey Garen.

Delay construction of functions that aren't captured
https://bugs.webkit.org/show_bug.cgi?id=46433

If a function isn't captured by an activation there's no
way it can be accessed indirectly, so we can delay the
construction until it's used (similar to what we do with
arguments). We rename the existing op_init_arguments to
op_init_lazy_reg and removed its implicit handling of
the anonymous argument register, and make op_new_function
take a parameter to indicate whether it should null check
the target slot before creating the function object.

  • bytecode/CodeBlock.cpp: (JSC::CodeBlock::dump):
  • bytecode/Opcode.h:
  • bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::BytecodeGenerator): (JSC::BytecodeGenerator::emitInitLazyRegister): (JSC::BytecodeGenerator::registerFor): (JSC::BytecodeGenerator::createLazyRegisterIfNecessary): (JSC::BytecodeGenerator::constRegisterFor): (JSC::BytecodeGenerator::emitNewFunction): (JSC::BytecodeGenerator::emitLazyNewFunction): (JSC::BytecodeGenerator::emitNewFunctionInternal):
  • bytecompiler/BytecodeGenerator.h:
  • interpreter/Interpreter.cpp: (JSC::Interpreter::privateExecute):
  • jit/JIT.cpp: (JSC::JIT::privateCompileMainPass):
  • jit/JIT.h:
  • jit/JITOpcodes.cpp: (JSC::JIT::emit_op_init_lazy_reg): (JSC::JIT::emit_op_new_func):
  • jit/JITOpcodes32_64.cpp: (JSC::JIT::emit_op_init_lazy_reg):
  • parser/Nodes.h: (JSC::ScopeNode::needsActivationForMoreThanVariables):
5:46 PM Changeset in webkit [68222] by kinuko@chromium.org
  • 24 edits
    2 adds in trunk

2010-09-23 Kinuko Yasuda <kinuko@chromium.org>

Reviewed by David Levin.

Add Worker support for FileSystem API
https://bugs.webkit.org/show_bug.cgi?id=45808

Added WebWorkerBase::openFileSystem and WebCommonWorkerClient::
openFileSystem to call in to the browser via Worker stub/proxy
in the chromium.

Also added WorkerFileSystemCallbacksBridge class that proxies
requests and callbacks between from/to worker thread to/from the
main thread.

  • public/WebCommonWorkerClient.h: (WebKit::WebCommonWorkerClient::openFileSystem): Added.
  • src/LocalFileSystemChromium.cpp: (WebCore::LocalFileSystem::localFileSystem): Added. (WebCore::LocalFileSystem::requestFileSystem): Added implementation for workers. In worker case this calls WebWorkerBase::openFileSystem.
  • src/WebWorkerBase.cpp: (WebKit::WebWorkerBase::openFileSystem): Added. This is called from LocalFileSystem::requestFileSystem on the worker thread and creates a bridge to call WebCommonWorkerClient::openFileSystem on the main thread.
  • src/WebWorkerBase.h:
  • src/WebWorkerClientImpl.h: (WebKit::WebWorkerClientImpl::openFileSystem): Added.
  • src/WorkerFileSystemCallbacksBridge.cpp: Added.
  • src/WorkerFileSystemCallbacksBridge.h: Added.

2010-09-23 Kinuko Yasuda <kinuko@chromium.org>

Reviewed by David Levin.

Add Worker support for FileSystem API
https://bugs.webkit.org/show_bug.cgi?id=45808

Exposed requestFileSystem and Flags constructor on worker contexts.

Also changed how to get the base path for Web file systems (in
non-chromium ports) so that it works for workers too.
This patch assumes each port calls
LocalFileSystem::initializeLocalFileSystem() in its initialization
phase.

No new tests; tests will be added when we have complete implementation.

  • bindings/generic/RuntimeEnabledFeatures.cpp: (WebCore::RuntimeEnabledFeatures::fileSystemEnabled): Changed to reflect AsyncFileSystem::isAvailable
  • bindings/generic/RuntimeEnabledFeatures.h: Moved the implementation of fileSystemEnabled to .cpp.
  • fileapi/LocalFileSystem.cpp: (WebCore::LocalFileSystem::initializeLocalFileSystem): Added. (WebCore::LocalFileSystem::localFileSystem): Added. (WebCore::LocalFileSystem::fileSystemBasePath): Added.
  • fileapi/LocalFileSystem.h: (WebCore::LocalFileSystem::~LocalFileSystem): Removed. (As now it's going to be used as a singleton.)
  • page/DOMWindow.cpp: (WebCore::DOMWindow::requestFileSystem): Changed to use a singleton instance of LocalFileSystem.
  • page/SecurityOrigin.h: (WebCore::SecurityOrigin::canAccessFileSystem): Added.
  • page/Settings.cpp: Removed fileSystemRootPath method.
  • page/Settings.h: Removed fileSystemRootPath method.
  • platform/AsyncFileSystem.cpp: (WebCore::AsyncFileSystem::isAvailable): Added.
  • workers/WorkerContext.cpp: (WebCore::WorkerContext::requestFileSystem): Added to expose requestFileSystem method in worker contexts. (WebCore::WorkerContext::Observer): Added. (WebCore::WorkerContext::registerObserver): Added. (WebCore::WorkerContext::unregisterObserver): Added. (WebCore::WorkerContext::notifyObserversOfStop): Added.
  • workers/WorkerContext.h:
  • workers/WorkerContext.idl:
  • workers/WorkerThread.cpp: (WebCore::WorkerThreadShutdownStartTask::performTask): Modified to call workerContext->notifyObserversOfStop to notify worker observers of the worker thread termination.
5:29 PM Changeset in webkit [68221] by commit-queue@webkit.org
  • 4 edits in trunk/WebCore

2010-09-23 Matthew Delaney <mdelaney@apple.com>

Reviewed by Oliver Hunt.

Lower the default canvas interpolation quality for platforms that use CG
https://bugs.webkit.org/show_bug.cgi?id=45722

Lowered the default image interpolation quality for platforms that
use CG down to low since this is as good as if not better than
other graphics platforms defaults (being bilinear interpolation).

  • html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::createImageBuffer):
  • html/HTMLCanvasElement.h: Moved in macros for default canvas interp quality.
  • platform/graphics/GraphicsContext.h: Moved out macros for default canvas interp quality. It makes more sense for them to be housed where they're used.
5:21 PM Changeset in webkit [68220] by weinig@apple.com
  • 15 edits in trunk

WebKit2 API: Need way to know when a frame is removed from the hierarchy
<rdar://problem/8414062>
https://bugs.webkit.org/show_bug.cgi?id=46432

Reviewed by Anders Carlsson.

WebKit2:

  • Shared/CoreIPCSupport/WebPageProxyMessageKinds.h:
  • UIProcess/API/C/WKPage.h:
  • UIProcess/WebLoaderClient.cpp:

(WebKit::WebLoaderClient::didRemoveFrameFromHierarchy):

  • UIProcess/WebLoaderClient.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didReceiveMessage):
(WebKit::WebPageProxy::didRemoveFrameFromHierarchy):

  • UIProcess/WebPageProxy.h:
  • WebProcess/InjectedBundle/API/c/WKBundlePage.h:
  • WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.cpp:

(WebKit::InjectedBundlePageLoaderClient::didRemoveFrameFromHierarchy):

  • WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.h:
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::detachedFromParent2):
(WebKit::WebFrameLoaderClient::didTransferChildFrameToNewDocument):

WebKitTools:

  • MiniBrowser/mac/BrowserWindowController.m:

(didRemoveFrameFromHierarchy):
(-[BrowserWindowController awakeFromNib]):

  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::InjectedBundlePage::InjectedBundlePage):

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::initialize):

5:09 PM Changeset in webkit [68219] by andersca@apple.com
  • 2 edits
    4 adds in trunk/WebKit2

Add PluginProcessConnection and PluginProcessConnectionManager
https://bugs.webkit.org/show_bug.cgi?id=46425

Reviewed by Sam Weinig.

  • WebKit2.xcodeproj/project.pbxproj:

Add files.

  • WebProcess/Plugins/PluginProcessConnection.cpp:

Add empty file for now.

  • WebProcess/Plugins/PluginProcessConnection.h:

Add header.

  • WebProcess/Plugins/PluginProcessConnectionManager.cpp: Added.

(WebKit::PluginProcessConnectionManager::getPluginProcessConnection):
Check for an existing plug-in process connection. If we don't have one, ask the
UI process to create one.

(WebKit::PluginProcessConnectionManager::removePluginProcessConnection):
Remove the connection from our global vector.

5:01 PM Changeset in webkit [68218] by tony@chromium.org
  • 2 edits
    7 adds in trunk/LayoutTests

2010-09-23 Tony Chang <tony@chromium.org>

Reviewed by Dimitri Glazkov.

[chromium] add baselines for no-caret-repaint-in-non-content-editable-element.html
https://bugs.webkit.org/show_bug.cgi?id=46428

  • platform/chromium-linux/fast/repaint/no-caret-repaint-in-non-content-editable-element-expected.checksum: Added.
  • platform/chromium-linux/fast/repaint/no-caret-repaint-in-non-content-editable-element-expected.png: Added.
  • platform/chromium-mac/fast/repaint/no-caret-repaint-in-non-content-editable-element-expected.checksum: Added.
  • platform/chromium-mac/fast/repaint/no-caret-repaint-in-non-content-editable-element-expected.png: Added.
  • platform/chromium-win/fast/repaint/no-caret-repaint-in-non-content-editable-element-expected.checksum: Added.
  • platform/chromium-win/fast/repaint/no-caret-repaint-in-non-content-editable-element-expected.png: Added.
  • platform/chromium-win/fast/repaint/no-caret-repaint-in-non-content-editable-element-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
4:58 PM Changeset in webkit [68217] by mihaip@chromium.org
  • 3 edits
    1 add
    8 deletes in trunk/LayoutTests

2010-09-23 Mihai Parparita <mihaip@chromium.org>

Reviewed by Dimitri Glazkov.

Convert http/tests/navigation/error404-frames.html to dumpAsText
https://bugs.webkit.org/show_bug.cgi?id=46341

  • http/tests/navigation/error404-frames-expected.txt: Added.
  • http/tests/navigation/error404-frames.html:
  • platform/chromium-linux/http/tests/navigation/error404-frames-expected.checksum: Removed.
  • platform/chromium-linux/http/tests/navigation/error404-frames-expected.png: Removed.
  • platform/chromium-win/http/tests/navigation/error404-frames-expected.checksum: Removed.
  • platform/chromium-win/http/tests/navigation/error404-frames-expected.png: Removed.
  • platform/chromium-win/http/tests/navigation/error404-frames-expected.txt: Removed.
  • platform/chromium/test_expectations.txt:
  • platform/mac/http/tests/navigation/error404-frames-expected.checksum: Removed.
  • platform/mac/http/tests/navigation/error404-frames-expected.png: Removed.
  • platform/mac/http/tests/navigation/error404-frames-expected.txt: Removed.
4:48 PM Changeset in webkit [68216] by tony@chromium.org
  • 9 edits in trunk

2010-09-23 Tony Chang <tony@chromium.org>

Reviewed by Dimitri Glazkov.

[chromium] implement layoutTestController.sampleSVGAnimationForElementAtTime
https://bugs.webkit.org/show_bug.cgi?id=46426

  • platform/chromium/test_expectations.txt: Mark 4 tests as passing.

2010-09-23 Tony Chang <tony@chromium.org>

Reviewed by Dimitri Glazkov.

[chromium] implement layoutTestController.sampleSVGAnimationForElementAtTime
https://bugs.webkit.org/show_bug.cgi?id=46426

  • public/WebFrame.h:
  • src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::pauseSVGAnimation):
  • src/WebFrameImpl.h:

2010-09-23 Tony Chang <tony@chromium.org>

Reviewed by Dimitri Glazkov.

[chromium] implement layoutTestController.sampleSVGAnimationForElementAtTime
https://bugs.webkit.org/show_bug.cgi?id=46426

  • DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): (LayoutTestController::sampleSVGAnimationForElementAtTime):
  • DumpRenderTree/chromium/LayoutTestController.h:
4:41 PM Changeset in webkit [68215] by atwilson@chromium.org
  • 2 edits
    2 adds in trunk/LayoutTests

Unreviewed chromium expectations update.

  • platform/chromium-linux/svg/in-html/by-reference-expected.txt: Added.
  • platform/chromium-win/svg/in-html/by-reference-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
4:39 PM Changeset in webkit [68214] by mihaip@chromium.org
  • 3 edits
    1 add
    9 deletes in trunk/LayoutTests

2010-09-23 Mihai Parparita <mihaip@chromium.org>

Reviewed by Ojan Vafai.

[Chromium] convert clientWidthAfterDocumentIsRemoved to dumpAsText
https://bugs.webkit.org/show_bug.cgi?id=46397

As suggested in http://crbug.com/9613, this should just be a text-only
test.

  • fast/dom/clientWidthAfterDocumentIsRemoved-expected.txt: Added.
  • fast/dom/clientWidthAfterDocumentIsRemoved.html:
  • platform/chromium-linux/fast/dom/clientWidthAfterDocumentIsRemoved-expected.checksum: Removed.
  • platform/chromium-linux/fast/dom/clientWidthAfterDocumentIsRemoved-expected.png: Removed.
  • platform/chromium-mac/fast/dom/clientWidthAfterDocumentIsRemoved-expected.txt: Removed.
  • platform/chromium-win/fast/dom/clientWidthAfterDocumentIsRemoved-expected.checksum: Removed.
  • platform/chromium-win/fast/dom/clientWidthAfterDocumentIsRemoved-expected.png: Removed.
  • platform/chromium-win/fast/dom/clientWidthAfterDocumentIsRemoved-expected.txt: Removed.
  • platform/chromium/test_expectations.txt:
  • platform/mac/fast/dom/clientWidthAfterDocumentIsRemoved-expected.checksum: Removed.
  • platform/mac/fast/dom/clientWidthAfterDocumentIsRemoved-expected.png: Removed.
  • platform/mac/fast/dom/clientWidthAfterDocumentIsRemoved-expected.txt: Removed.
4:35 PM Changeset in webkit [68213] by tony@chromium.org
  • 6 edits in trunk/LayoutTests

2010-09-23 Tony Chang <tony@chromium.org>

Reviewed by David Levin.

[chromium] make fast/events/standalone-image-drag-to-editable.html non-flakey
https://bugs.webkit.org/show_bug.cgi?id=46381

In chromium, the image that was dropped sometimes hasn't loaded when
the pixel results are taken. This results in a 0x0 image and makes
the test flakey. The fix is to wait for the image load event if it's
not already loaded.

  • fast/events/resources/standalone-image-drag-to-editable-frame.html:
  • fast/events/standalone-image-drag-to-editable.html:
  • platform/chromium-linux/fast/events/standalone-image-drag-to-editable-expected.checksum: Image result with dropped image loaded.
  • platform/chromium-linux/fast/events/standalone-image-drag-to-editable-expected.png:
  • platform/chromium/test_expectations.txt:
4:11 PM Changeset in webkit [68212] by ddkilzer@apple.com
  • 2 edits in trunk/JavaScriptCore

<rdar://problem/8460731> ~9.9% speedup when compiling interpreter with llvm-gcc-4.2
https://bugs.webkit.org/show_bug.cgi?id=46423

Reviewed by Oliver Hunt.

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::privateExecute): Disable the gcc computed
goto hacks added in r55564 when compiling with llvm-gcc-4.2.

4:09 PM Changeset in webkit [68211] by Martin Robinson
  • 2 edits in trunk/WebKitTools

2010-09-23 Martin Robinson <mrobinson@igalia.com>

Reviewed by Nate Chapin.

[GTK] r68199 introduced two test failures
https://bugs.webkit.org/show_bug.cgi?id=46424

Fix a regression handling preference overrides that are attached to boolean properties.

  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::overridePreference): g_strcasecmp returns 0 when strings match so we must check for that when converting a string to a boolean.
3:53 PM Changeset in webkit [68210] by Adam Roben
  • 6 edits in trunk/WebKit2

Remove the DrawingAreaProxy parameter to WebPagProxy::initializeWebPage

Callers are now required to set the drawing area via
WebPageProxy::setDrawingArea before calling initializeWebPage. This
will allow us to delay calling initializeWebPage on Windows until
after we've created the WebView's HWND, which in turn will allow us to
send the HWND over to the web process when the page is created. (The
drawing area must be set before creating the HWND so that its size can
be updated, etc., as the window is created.)

Fixes <http://webkit.org/b/46409> DrawingAreaProxy parameter to
initializeWebPage is unnecessary, and causes problems on Windows

Reviewed by Anders Carlsson.

  • UIProcess/API/mac/WKView.mm:

(-[WKView initWithFrame:pageNamespaceRef:]):

  • UIProcess/API/qt/qwkpage.cpp:

(QWKPagePrivate::init):

  • UIProcess/win/WebView.cpp:

(WebKit::WebView::WebView):
Added explicit calls to setDrawingArea.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::initializeWebPage):

  • UIProcess/WebPageProxy.h:

Removed the DrawingAreaProxy parameter and a stray puts(), and added
an assertion.

3:46 PM Changeset in webkit [68209] by commit-queue@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-09-23 Lucas De Marchi <lucas.demarchi@profusion.mobi>

Reviewed by Darin Adler.

Fix usage of enum as if it was a define
https://bugs.webkit.org/show_bug.cgi?id=46355

pthread.h defines PTHREAD_MUTEX_DEFAULT and PTHREAD_MUTEX_NORMAL as an
enum. Hence, it cannot be used by the preprocessor which always
evaluates that condition as true. This was giving a warning when
compiling with gcc and "-Wundef" flag.

The second path, when PTHREAD_MUTEX_DEFAULT is not the same of
PTHREAD_MUTEX_NORMAL, is not slow. So, let's eliminate the first path
and get rid of that #if.

  • wtf/ThreadingPthreads.cpp: Always call pthread_mutexattr_init() to set mutex type to PTHREAD_MUTEX_NORMAL. (WTF::Mutex::Mutex):
3:26 PM Changeset in webkit [68208] by mihaip@chromium.org
  • 2 edits
    2 adds
    2 deletes in trunk/LayoutTests

2010-09-23 Mihai Parparita <mihaip@chromium.org>

Reviewed by Tony Chang.

[Chromium] traversal/node-iterator-prototype.html has incorrect baselines
https://bugs.webkit.org/show_bug.cgi?id=46413

Chromium/V8 actually gets this test right (unlike JSC), but had
incorrect baselines for it checked in by r58524.

  • platform/chromium-mac/traversal/node-iterator-prototype-expected.txt: Removed.
  • platform/chromium-win/traversal/node-iterator-prototype-expected.txt: Removed.
  • platform/chromium/test_expectations.txt:
  • platform/chromium/traversal/node-iterator-prototype-expected.txt: Added.
3:23 PM Changeset in webkit [68207] by msaboff@apple.com
  • 3 edits in trunk/JavaScriptCore

2010-09-23 Michael Saboff <msaboff@apple.com>

Reviewed by Geoffrey Garen.

Removed extraneous truncation of ovector on entry and error exit.
Changed the initialization to -1 of vector to only initialize
the start indecies, which is sufficient for the pattern/subpatterns.
Changed the JIT code to not clear the end index for subpatterns
as it isn't needed. These changes are worth ~2.7% on v8-regexp.
https://bugs.webkit.org/show_bug.cgi?id=46404

  • runtime/RegExp.cpp: (JSC::RegExp::match):
  • yarr/RegexJIT.cpp: (JSC::Yarr::RegexGenerator::generateParenthesesSingle):
3:21 PM Changeset in webkit [68206] by hyatt@apple.com
  • 8 edits in trunk/WebCore

https://bugs.webkit.org/show_bug.cgi?id=46414, rename line box methods that refer specifically to
"horizontal" and "vertical." Replace those terms with "inline direction" and "block direction."

Reviewed by Adele Peterson.

  • rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::placeBoxesInInlineDirection):
(WebCore::InlineFlowBox::placeBoxesInBlockDirection):
(WebCore::InlineFlowBox::computeBlockDirectionOverflow):

  • rendering/InlineFlowBox.h:

(WebCore::InlineFlowBox::setInlineDirectionOverflowPositions):
(WebCore::InlineFlowBox::setBlockDirectionOverflowPositions):

  • rendering/RenderBlock.h:
  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::computeInlineDirectionPositionsForLine):
(WebCore::RenderBlock::computeBlockDirectionPositionsForLine):
(WebCore::RenderBlock::layoutInlineChildren):

  • rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::alignBoxesInBlockDirection):

  • rendering/RootInlineBox.h:
3:20 PM Changeset in webkit [68205] by andersca@apple.com
  • 6 edits in trunk/WebKit2

Implement handlers for the GetPluginProcessConnection message
https://bugs.webkit.org/show_bug.cgi?id=46415

Reviewed by Darin Adler.

  • Shared/CoreIPCSupport/WebProcessProxyMessageKinds.h:

Add GetPluginProcessConnection message kind

  • UIProcess/Plugins/PluginProcessManager.cpp:

(WebKit::PluginProcessManager::PluginProcessManager):
Add missing constructor.

  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::getPluginProcessConnection):
Ask the plug-in process manager for a connection.

(WebKit::WebProcessProxy::didReceiveSyncMessage):
Call getPluginProcessConnection.

  • UIProcess/WebProcessProxy.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::createPlugin):
Send the GetPluginProcessConnection message.

3:08 PM Changeset in webkit [68204] by commit-queue@webkit.org
  • 4 edits in trunk/WebKit/qt

2010-09-23 Ademar de Souza Reis Jr <Ademar Reis>

Reviewed by Kenneth Rohde Christiansen.

Fix QWebHapticFeedbackPlayer exposure via QWebKitPlatformPlugin

[Qt] QWebHapticFeedbackPlayer needs correct exposure through QWebKitPlatformPlugin
https://bugs.webkit.org/show_bug.cgi?id=46402

QWebHapticFeedbackPlayer is exported through
QWebKitPlatformPlugin::createExtension(), but
createHapticFeedbackPlayer() and the correct
inheritage are missing.

  • Api/qwebkitplatformplugin.h:
  • WebCoreSupport/QtPlatformPlugin.cpp: (WebCore::QtPlatformPlugin::createHapticFeedbackPlayer):
  • WebCoreSupport/QtPlatformPlugin.h:
3:03 PM Changeset in webkit [68203] by atwilson@chromium.org
  • 13 edits in trunk

Revert "2010-09-23 Hans Wennborg <hans@chromium.org>"

Revert r68197 because it breaks the chromium linux build.
https://bugs.webkit.org/show_bug.cgi?id=46344

2:56 PM Changeset in webkit [68202] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

2010-09-22 Dirk Pranke <dpranke@chromium.org>

Unreviewed, expectations change.

Update the comments to more accurately reflect which tests we expect
to run and pass.

https://bugs.webkit.org/show_bug.cgi?id=46331

  • platform/chromium-gpu/test_expectations.txt:
2:49 PM Changeset in webkit [68201] by Dimitri Glazkov
  • 2 edits in trunk/WebKitTools

2010-09-23 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by David Levin.

Fix a condition check in ServerProcess, which becomes relevant when reading binary data.
https://bugs.webkit.org/show_bug.cgi?id=46406

This breaks when the method is called with specified size of data (image data), and the
buffer hasn't yet reached this size.

  • Scripts/webkitpy/layout_tests/port/server_process.py: Changed to check for values of index larger than 0.
2:47 PM Changeset in webkit [68200] by hyatt@apple.com
  • 6 edits in trunk/WebCore

https://bugs.webkit.org/show_bug.cgi?id=46403, convert the margin/border/padding accessors
to be logical.

Reviewed by Adele Peterson.

  • rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::getFlowSpacingLogicalWidth):
(WebCore::InlineFlowBox::placeBoxesHorizontally):
(WebCore::InlineFlowBox::paintBoxShadow):
(WebCore::InlineFlowBox::paintBoxDecorations):
(WebCore::InlineFlowBox::paintTextDecorations):

  • rendering/InlineFlowBox.h:

(WebCore::InlineFlowBox::InlineFlowBox):
(WebCore::InlineFlowBox::marginBorderPaddingLogicalLeft):
(WebCore::InlineFlowBox::marginBorderPaddingLogicalRight):
(WebCore::InlineFlowBox::marginLogicalLeft):
(WebCore::InlineFlowBox::marginLogicalRight):
(WebCore::InlineFlowBox::borderLogicalLeft):
(WebCore::InlineFlowBox::borderLogicalRight):
(WebCore::InlineFlowBox::paddingLogicalLeft):
(WebCore::InlineFlowBox::paddingLogicalRight):
(WebCore::InlineFlowBox::includeLogicalLeftEdge):
(WebCore::InlineFlowBox::includeLogicalRightEdge):
(WebCore::InlineFlowBox::setEdges):

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::computeHorizontalPositionsForLine):

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::containingBlockWidthForPositioned):
(WebCore::RenderBox::calcAbsoluteHorizontalValues):
(WebCore::RenderBox::calcAbsoluteHorizontalReplaced):

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::paintFillLayerExtended):

2:36 PM Changeset in webkit [68199] by Martin Robinson
  • 4 edits in trunk

2010-09-23 Martin Robinson <mrobinson@igalia.com>

Reviewed by Nate Chapin.

[GTK] Some tests from r68174 fail on the GTK+ bots
https://bugs.webkit.org/show_bug.cgi?id=46396

Fix since version number in this new WebKitWebSettings property.

  • webkit/webkitwebsettings.cpp: (webkit_web_settings_class_init): Fix the since version number.

2010-09-23 Martin Robinson <mrobinson@igalia.com>

Reviewed by Nate Chapin.

[GTK] Some tests from r68174 fail on the GTK+ bots
https://bugs.webkit.org/show_bug.cgi?id=46396

Simplify LayoutTestController::overridePreference to make it easier for
people unfamiliar with the code to keep the list of preferences up to date.
Add the conversion for enable-hyperlink-auditing.

  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::overridePreference): Use a simple if-else block to determine out the property name for overrridePreference. Also simplify the logic for setting string properties. Add the conversion for enable-hyperlink-auditing.
2:36 PM Changeset in webkit [68198] by commit-queue@webkit.org
  • 5 edits
    4 adds in trunk

2010-09-23 Jeff Schiller <jeffschiller@google.com>

Reviewed by David Hyatt.

Test to confirm that object/iframe/embed backgrounds are transparent for SVG documents
https://bugs.webkit.org/show_bug.cgi?id=10687

  • platform/mac/svg/in-html/by-reference-expected.txt: Added.
  • svg/in-html/by-reference-expected.checksum: Added.
  • svg/in-html/by-reference-expected.png: Added.
  • svg/in-html/by-reference.html: Added.

2010-09-23 Jeff Schiller <jeffschiller@google.com>

Reviewed by David Hyatt.

Ensure that SVG documents included by reference (object, iframe, embed) have transparent
backgrounds (not white). https://bugs.webkit.org/show_bug.cgi?id=10687

Test: svg/in-html/by-reference.html

  • dom/Document.cpp: (WebCore::Document::hasSVGRootNode):
  • dom/Document.h: (WebCore::Document::hasSVGRootNode):
  • rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::paintFillLayerExtended):
2:31 PM Changeset in webkit [68197] by hans@chromium.org
  • 13 edits in trunk

2010-09-23 Hans Wennborg <hans@chromium.org>

Reviewed by Simon Fraser.

Update DeviceMotionEvent to spec
https://bugs.webkit.org/show_bug.cgi?id=46344

  • fast/dom/DeviceMotion/script-tests/create-event.js:
  • fast/dom/DeviceMotion/create-event-expected.txt: Look for the new attributes.
  • fast/dom/DeviceMotion/script-tests/optional-event-properties.js:
  • fast/dom/DeviceMotion/optional-event-properties-expected.txt: Test the new attributes.
  • fast/dom/script-tests/prototype-inheritance.js: DeviceMotionEvent is not implemented on all platforms, so it should be skipped in this test.

2010-09-23 Hans Wennborg <hans@chromium.org>

Reviewed by Simon Fraser.

Update DeviceMotionEvent to spec
https://bugs.webkit.org/show_bug.cgi?id=46344

The spec has changed: the DeviceMotionEvent attributes accelerationX,
accelerationY, etc. have been baked into an 'acceleration' attribute
which returns an object with x, y, and z values. Likewise for the
rotation rate. The 'accelerationIncludingGravity' attribute is new.

  • WebCore.exp.in: The DeviceMotionData::create member function has changed. Also export create functions for DeviceMotionData::Acceleration and RotationRate.
  • bindings/js/JSDeviceMotionEventCustom.cpp: (WebCore::JSDeviceMotionEvent::acceleration): (WebCore::JSDeviceMotionEvent::accelerationIncludingGravity): (WebCore::JSDeviceMotionEvent::rotationRate): (WebCore::JSDeviceMotionEvent::initDeviceMotionEvent): Manually create and return objects with the right attributes for acceleration, accelerationIncludingGravity, and rotationRate. When creating the DeviceMotionData object in initDeviceMotionEvent, accept any input objects that have the right attributes.
  • bindings/v8/custom/V8DeviceMotionEventCustom.cpp: (WebCore::V8DeviceMotionEvent::accelerationAccessorGetter): (WebCore::V8DeviceMotionEvent::accelerationIncludingGravityAccessorGetter): (WebCore::V8DeviceMotionEvent::rotationRateAccessorGetter): (WebCore::V8DeviceMotionEvent::initDeviceMotionEventCallback): V8 counterpart to the JSC code above.
  • dom/DeviceMotionData.cpp: (WebCore::DeviceMotionData::Acceleration::create): (WebCore::DeviceMotionData::Acceleration::Acceleration): (WebCore::DeviceMotionData::RotationRate::create): (WebCore::DeviceMotionData::RotationRate::RotationRate): (WebCore::DeviceMotionData::create): (WebCore::DeviceMotionData::DeviceMotionData):
  • dom/DeviceMotionData.h: (WebCore::DeviceMotionData::Acceleration::canProvideX): (WebCore::DeviceMotionData::Acceleration::canProvideY): (WebCore::DeviceMotionData::Acceleration::canProvideZ): (WebCore::DeviceMotionData::Acceleration::x): (WebCore::DeviceMotionData::Acceleration::y): (WebCore::DeviceMotionData::Acceleration::z): (WebCore::DeviceMotionData::RotationRate::canProvideAlpha): (WebCore::DeviceMotionData::RotationRate::canProvideBeta): (WebCore::DeviceMotionData::RotationRate::canProvideGamma): (WebCore::DeviceMotionData::RotationRate::alpha): (WebCore::DeviceMotionData::RotationRate::beta): (WebCore::DeviceMotionData::RotationRate::gamma): (WebCore::DeviceMotionData::acceleration): (WebCore::DeviceMotionData::accelerationIncludingGravity): (WebCore::DeviceMotionData::rotationRate): Add member classes Acceleration and RotationRate to DeviceMotionData.
  • dom/DeviceMotionEvent.idl: Update according to the spec. Acceleration and RotationRate need not be backed by native classes.
2:18 PM Changeset in webkit [68196] by Patrick Gansterer
  • 3 edits in trunk/WebCore

2010-09-23 Patrick Gansterer <Patrick Gansterer>

Reviewed by Adam Roben.

Set synchronous handle in ResourceHandleWin
https://bugs.webkit.org/show_bug.cgi?id=46395

When loading synchronous network resources, we need to use a synchronous internet handle.

  • platform/network/ResourceHandle.h:
  • platform/network/win/ResourceHandleWin.cpp: (WebCore::ResourceHandle::loadResourceSynchronously): (WebCore::ResourceHandle::setSynchronousInternetHandle):
2:09 PM Changeset in webkit [68195] by ap@apple.com
  • 4 edits
    2 adds in trunk

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=46326
Crash when trying to create a NodeIterator rooted at a document-less DocumentType node

Test: fast/dom/node-iterator-with-doctype-root.html

  • dom/Document.cpp: (WebCore::Document::detachNodeIterator): Added a comment explaining that attach/detach may not always be paired.
  • dom/NodeIterator.cpp: (WebCore::NodeIterator::NodeIterator): Don't try to register with the document if there is none. (WebCore::NodeIterator::~NodeIterator): Ditto. (WebCore::NodeIterator::detach): Ditto. (WebCore::NodeIterator::updateForNodeRemoval): There should be a document if we're getting a notification.
2:03 PM Changeset in webkit [68194] by mihaip@chromium.org
  • 2 edits in trunk/LayoutTests

2010-09-23 Mihai Parparita <mihaip@chromium.org>

Unreviewed chromium text_expectations.txt change.

Unskip traversal/node-iterator-prototype.html on Chromium, so we can
get updated expectations for it from the bots.

  • platform/chromium/test_expectations.txt:
1:56 PM Changeset in webkit [68193] by atwilson@chromium.org
  • 1 edit
    12 adds in trunk/LayoutTests

Unreviewed chromium expectations update.

  • platform/chromium-win/svg/dynamic-updates/SVGFEMorphologyElement-dom-in-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEMorphologyElement-dom-in-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEMorphologyElement-dom-operator-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEMorphologyElement-dom-operator-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEMorphologyElement-dom-radius-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEMorphologyElement-dom-radius-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEMorphologyElement-svgdom-in-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEMorphologyElement-svgdom-in-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEMorphologyElement-svgdom-operator-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEMorphologyElement-svgdom-operator-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEMorphologyElement-svgdom-radius-call-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEMorphologyElement-svgdom-radius-call-expected.png: Added.
1:53 PM Changeset in webkit [68192] by Patrick Gansterer
  • 2 edits in trunk/WebCore

2010-09-23 Patrick Gansterer <Patrick Gansterer>

Reviewed by Adam Roben.

Add synchronous loading for local files to ResourceHandleWin
https://bugs.webkit.org/show_bug.cgi?id=46392

  • platform/network/win/ResourceHandleWin.cpp: (WebCore::ResourceHandle::start):
1:52 PM Changeset in webkit [68191] by tony@chromium.org
  • 8 edits in trunk

2010-09-23 Tony Chang <tony@chromium.org>

Reviewed by David Levin.

[chromium] add caretBrowsingEnabled to WebSettings and DRT
https://bugs.webkit.org/show_bug.cgi?id=46388

  • public/WebSettings.h:
  • src/WebSettingsImpl.cpp: (WebKit::WebSettingsImpl::setCaretBrowsingEnabled):
  • src/WebSettingsImpl.h:

2010-09-23 Tony Chang <tony@chromium.org>

Reviewed by David Levin.

[chromium] add caretBrowsingEnabled to WebSettings and DRT
https://bugs.webkit.org/show_bug.cgi?id=46388

  • DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::overridePreference):
  • DumpRenderTree/chromium/WebPreferences.cpp: (WebPreferences::reset): (WebPreferences::applyTo):
  • DumpRenderTree/chromium/WebPreferences.h:
1:45 PM Changeset in webkit [68190] by Patrick Gansterer
  • 3 edits in trunk/WebCore

2010-09-23 Patrick Gansterer <Patrick Gansterer>

Reviewed by Adam Roben.

Remove (has|set)ReceivedResponse() from public ResourceHandleWin API
https://bugs.webkit.org/show_bug.cgi?id=46391

There is no need for this functions to be public, so remove them.

  • platform/network/ResourceHandle.h:
  • platform/network/win/ResourceHandleWin.cpp: (WebCore::ResourceHandle::onRequestComplete):
1:41 PM Changeset in webkit [68189] by hyatt@apple.com
  • 2 edits in trunk/WebCore

https://bugs.webkit.org/show_bug.cgi?id=46400

Reviewed by Adele Peterson.

Add logicalLeft/Top getter/setters to line boxes.

  • rendering/InlineBox.h:

(WebCore::InlineBox::logicalLeft):
(WebCore::InlineBox::setLogicalLeft):
(WebCore::InlineBox::logicalTop):
(WebCore::InlineBox::setLogicalTop):

1:35 PM Changeset in webkit [68188] by commit-queue@webkit.org
  • 8 edits in trunk

2010-09-23 Matthew Delaney <mdelaney@apple.com>

Reviewed by Simon Fraser.

Reduce minimum DOMTimer interval
https://bugs.webkit.org/show_bug.cgi?id=45362

Since the setInterval call is meant to reflect a global change for
all pages' DOMTimers, it's misleading to have it be a method on a
given page's settings' object. Thus, this patch changes the call to be static.

This simple change to using a static call instead of the page's setting's
method doesn't warrant a test.

  • page/Settings.h: Changed the setInterval call to be static.

2010-09-23 Matthew Delaney <mdelaney@apple.com>

Reviewed by Simon Fraser.

Reduce minimum DOMTimer interval
https://bugs.webkit.org/show_bug.cgi?id=45362

  • WebView/WebView.mm: Updating set interval call to use Settings' static version inside one time init block.

2010-09-23 Matthew Delaney <mdelaney@apple.com>

Reviewed by Simon Fraser.

Reduce minimum DOMTimer interval
https://bugs.webkit.org/show_bug.cgi?id=45362

  • WebView.cpp: Updating set interval call to use Settings' static version inside one time init block.

2010-09-23 Matthew Delaney <mdelaney@apple.com>

Reviewed by Simon Fraser.

Reduce minimum DOMTimer interval
https://bugs.webkit.org/show_bug.cgi?id=45362

  • WebProcess/WebPage/WebPage.cpp: Updating set interval call to use Settings' static version.
1:24 PM Changeset in webkit [68187] by mihaip@chromium.org
  • 2 edits
    2 deletes in trunk/LayoutTests

2010-09-23 Mihai Parparita <mihaip@chromium.org>

Reviewed by David Levin.

[Chromium] remove incorrect baselines for two WebGL tests
https://bugs.webkit.org/show_bug.cgi?id=46372

As far as I can tell, these tests were not failing because of
"new-run-webkit-tests's diff trimming line ends", but because they had
chromium-mac baselines checked in with r56251, but then the test was
changed since then, with the chromium-mac baselines not being updated.
The test seems to pass on chromium-mac (both test_shell and DRT) with
the regular baselines.

  • platform/chromium-mac/fast/canvas/webgl/null-object-behaviour-expected.txt: Removed.
  • platform/chromium-mac/fast/canvas/webgl/uniform-location-expected.txt: Removed.
  • platform/chromium/test_expectations.txt:
1:21 PM Changeset in webkit [68186] by hyatt@apple.com
  • 8 edits in trunk/WebCore

https://bugs.webkit.org/show_bug.cgi?id=46386, give line boxes a vertical bit so that it's easy to know
the overall direction of the line without having to ask the containing block.

Reviewed by Dan Bernstein.

Also couldn't resist some cleanup. Tightened up the type of the renderobject passed to RootInlineBox's
constructor to be a RenderBlock. Moved all the virtual logical height stuff outside of the SVG ifdef
since TrailingFloatsRootInlineBox uses it and should work without SVG enabled.

  • rendering/EllipsisBox.h:

(WebCore::EllipsisBox::EllipsisBox):

  • rendering/InlineBox.h:

(WebCore::InlineBox::InlineBox):
(WebCore::InlineBox::isVertical):
(WebCore::InlineBox::setIsVertical):

  • rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::addToLine):

  • rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::RootInlineBox):
(WebCore::RootInlineBox::placeEllipsis):

  • rendering/RootInlineBox.h:
  • rendering/SVGRootInlineBox.h:

(WebCore::SVGRootInlineBox::SVGRootInlineBox):

  • rendering/TrailingFloatsRootInlineBox.h:

(WebCore::TrailingFloatsRootInlineBox::TrailingFloatsRootInlineBox):

1:10 PM Changeset in webkit [68185] by Patrick Gansterer
  • 2 edits in trunk/WebCore

2010-09-23 Patrick Gansterer <Patrick Gansterer>

Reviewed by Adam Roben.

Check for a valid ResourceHandleClient in ResourceHandleWin
https://bugs.webkit.org/show_bug.cgi?id=46389

  • platform/network/win/ResourceHandleWin.cpp: (WebCore::ResourceHandle::onRequestComplete): Add checks to ensure client() is not 0.
12:55 PM Changeset in webkit [68184] by Patrick Gansterer
  • 2 edits in trunk/WebCore

2010-09-23 Patrick Gansterer <Patrick Gansterer>

Reviewed by Adam Roben.

Fix ResourceHandleWin::cancel() for network resources
https://bugs.webkit.org/show_bug.cgi?id=46383

  • platform/network/win/ResourceHandleWin.cpp: (WebCore::ResourceHandle::onRequestComplete): Check it requestHandle is not 0. (WebCore::ResourceHandle::cancel): Set requestHandle to 0.
12:52 PM WebKit Team edited by eric.carlson@apple.com
(diff)
12:43 PM Changeset in webkit [68183] by Patrick Gansterer
  • 2 edits in trunk/WebCore

2010-09-23 Patrick Gansterer <Patrick Gansterer>

Reviewed by Adam Roben.

Add handling for form data and additional HTTP headers in ResourceHandleWin
https://bugs.webkit.org/show_bug.cgi?id=46369

  • platform/network/win/ResourceHandleWin.cpp: (WebCore::ResourceHandle::start):
12:39 PM Changeset in webkit [68182] by Adam Roben
  • 2 edits in trunk/WebKit2

Try to fix the Windows build

  • win/WebKit2Common.vsprops: Add WebKit2/PluginProcess to the include

path.

12:37 PM Changeset in webkit [68181] by eric.carlson@apple.com
  • 4 edits in trunk

2010-09-23 Eric Carlson <eric.carlson@apple.com>

Reviewed by Simon Fraser

'seeking' event should always fire
https://bugs.webkit.org/show_bug.cgi?id=45694

Update seek algorithm to match current spec.

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::setReadyState): Don't need to fire 'seeking' event here. (WebCore::HTMLMediaElement::seek): Always fire 'seeking'. Update comments. (WebCore::HTMLMediaElement::finishSeek): Update comments. (WebCore::HTMLMediaElement::mediaPlayerTimeChanged): Ditto.

2010-09-23 Eric Carlson <eric.carlson@apple.com>

Reviewed by Simon Fraser

'seeking' event should always fire
https://bugs.webkit.org/show_bug.cgi?id=45694

  • media/event-attributes-expected.txt: Update for changes.
12:33 PM Changeset in webkit [68180] by commit-queue@webkit.org
  • 13 edits
    1 move in trunk

2010-09-23 Eric Uhrhane <ericu@chromium.org>

Reviewed by David Levin.

Rename FileWriterClient to AsyncFileWriterClient.
https://bugs.webkit.org/show_bug.cgi?id=46325

  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • fileapi/AsyncFileWriter.h:
  • fileapi/AsyncFileWriterClient.h: Copied from WebCore/fileapi/FileWriterClient.h.
  • fileapi/FileWriter.h:
  • fileapi/FileWriterClient.h: Removed.
  • platform/AsyncFileSystem.h:

2010-09-23 Eric Uhrhane <ericu@chromium.org>

Reviewed by David Levin.

Rename FileWriterClient to AsyncFileWriterClient.
https://bugs.webkit.org/show_bug.cgi?id=46325

  • src/AsyncFileSystemChromium.cpp:
  • src/AsyncFileSystemChromium.h:
  • src/AsyncFileWriterChromium.cpp:
  • src/AsyncFileWriterChromium.h:
12:24 PM Changeset in webkit [68179] by Nate Chapin
  • 5 edits in trunk/WebKit/win

2010-09-23 Nate Chapin <Nate Chapin>

Unreviewed, build fix.

Move hyperlinkAuditingEnabled to IWebPreferencesPrivate.idl
and touch WebKit.idl

  • Interfaces/IWebPreferences.idl:
  • Interfaces/IWebPreferencesPrivate.idl:
  • Interfaces/WebKit.idl:
  • WebView.cpp: (WebView::notifyPreferencesChanged):
12:17 PM Changeset in webkit [68178] by atwilson@chromium.org
  • 1 edit
    12 adds in trunk/LayoutTests

Unreviewed chromium expecations update.

  • platform/chromium-linux/svg/dynamic-updates/SVGFEMorphologyElement-dom-in-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEMorphologyElement-dom-in-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEMorphologyElement-dom-operator-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEMorphologyElement-dom-operator-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEMorphologyElement-dom-radius-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEMorphologyElement-dom-radius-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEMorphologyElement-svgdom-in-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEMorphologyElement-svgdom-in-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEMorphologyElement-svgdom-operator-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEMorphologyElement-svgdom-operator-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEMorphologyElement-svgdom-radius-call-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEMorphologyElement-svgdom-radius-call-expected.png: Added.
12:17 PM Changeset in webkit [68177] by hyatt@apple.com
  • 27 edits in trunk/WebCore

https://bugs.webkit.org/show_bug.cgi?id=46378, rename width/height on line boxes to logicalWidth/logicalHeight.

Reviewed by Dan Bernstein.

  • editing/visible_units.cpp:

(WebCore::previousLinePosition):
(WebCore::nextLinePosition):

  • rendering/EllipsisBox.cpp:

(WebCore::EllipsisBox::paint):
(WebCore::EllipsisBox::paintSelection):
(WebCore::EllipsisBox::nodeAtPoint):

  • rendering/InlineBox.cpp:

(WebCore::InlineBox::logicalHeight):
(WebCore::InlineBox::canAccommodateEllipsis):

  • rendering/InlineBox.h:

(WebCore::InlineBox::InlineBox):
(WebCore::InlineBox::hasVirtualLogicalHeight):
(WebCore::InlineBox::setHasVirtualLogicalHeight):
(WebCore::InlineBox::virtualLogicalHeight):
(WebCore::InlineBox::setLogicalWidth):
(WebCore::InlineBox::logicalWidth):

  • rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::placeBoxesHorizontally):
(WebCore::InlineFlowBox::placeBoxesVertically):
(WebCore::InlineFlowBox::computeVerticalOverflow):
(WebCore::InlineFlowBox::nodeAtPoint):
(WebCore::InlineFlowBox::paintFillLayer):
(WebCore::InlineFlowBox::paintBoxDecorations):
(WebCore::InlineFlowBox::paintMask):
(WebCore::InlineFlowBox::paintTextDecorations):
(WebCore::InlineFlowBox::placeEllipsisBox):

  • rendering/InlineFlowBox.h:

(WebCore::InlineFlowBox::visibleOverflowRect):
(WebCore::InlineFlowBox::bottomLayoutOverflow):
(WebCore::InlineFlowBox::rightLayoutOverflow):
(WebCore::InlineFlowBox::layoutOverflowRect):
(WebCore::InlineFlowBox::bottomVisualOverflow):
(WebCore::InlineFlowBox::rightVisualOverflow):
(WebCore::InlineFlowBox::visualOverflowRect):
(WebCore::InlineFlowBox::setHorizontalOverflowPositions):
(WebCore::InlineFlowBox::setVerticalOverflowPositions):

  • rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::selectionRect):
(WebCore::InlineTextBox::placeEllipsisBox):
(WebCore::InlineTextBox::nodeAtPoint):
(WebCore::InlineTextBox::paint):
(WebCore::InlineTextBox::paintSelection):
(WebCore::InlineTextBox::paintCustomHighlight):
(WebCore::InlineTextBox::paintDecoration):
(WebCore::InlineTextBox::paintSpellingOrGrammarMarker):
(WebCore::InlineTextBox::paintTextMatchMarker):
(WebCore::InlineTextBox::paintCompositionUnderline):

  • rendering/InlineTextBox.h:

(WebCore::InlineTextBox::calculateBoundaries):
(WebCore::InlineTextBox::setSpaceAdd):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::paintEllipsisBoxes):
(WebCore::RenderBlock::rightmostPosition):
(WebCore::RenderBlock::adjustForBorderFit):
(WebCore::RenderBlock::addFocusRingRects):

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::computeHorizontalPositionsForLine):
(WebCore::RenderBlock::checkLinesForTextOverflow):

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::paintCustomHighlight):
(WebCore::RenderBox::containingBlockWidthForPositioned):

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::applyLineClamp):

  • rendering/RenderInline.cpp:

(WebCore::RenderInline::absoluteRects):
(WebCore::RenderInline::absoluteQuads):
(WebCore::RenderInline::linesBoundingBox):
(WebCore::RenderInline::addFocusRingRects):
(WebCore::RenderInline::paintOutline):

  • rendering/RenderSVGInline.cpp:

(WebCore::RenderSVGInline::createInlineFlowBox):
(WebCore::RenderSVGInline::absoluteQuads):

  • rendering/RenderSVGInlineText.cpp:

(WebCore::RenderSVGInlineText::createTextBox):

  • rendering/RenderSVGText.cpp:

(WebCore::RenderSVGText::createRootInlineBox):

  • rendering/RenderText.cpp:

(WebCore::RenderText::absoluteRects):
(WebCore::RenderText::absoluteRectsForRange):
(WebCore::RenderText::absoluteQuadsForRange):
(WebCore::RenderText::positionForPoint):
(WebCore::RenderText::localCaretRect):
(WebCore::RenderText::linesBoundingBox):

  • rendering/RenderTreeAsText.cpp:

(WebCore::writeTextRun):

  • rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::canAccommodateEllipsis):
(WebCore::RootInlineBox::placeEllipsis):
(WebCore::RootInlineBox::addHighlightOverflow):
(WebCore::RootInlineBox::paintCustomHighlight):
(WebCore::RootInlineBox::fillLineSelectionGap):
(WebCore::RootInlineBox::closestLeafChildForXPos):

  • rendering/SVGInlineFlowBox.h:

(WebCore::SVGInlineFlowBox::SVGInlineFlowBox):
(WebCore::SVGInlineFlowBox::virtualLogicalHeight):
(WebCore::SVGInlineFlowBox::setLogicalHeight):

  • rendering/SVGInlineTextBox.cpp:

(WebCore::SVGInlineTextBox::SVGInlineTextBox):

  • rendering/SVGInlineTextBox.h:

(WebCore::SVGInlineTextBox::virtualLogicalHeight):
(WebCore::SVGInlineTextBox::setLogicalHeight):
(WebCore::SVGInlineTextBox::selectionHeight):

  • rendering/SVGRenderTreeAsText.cpp:

(WebCore::writeRenderSVGTextBox):

  • rendering/SVGRootInlineBox.cpp:

(WebCore::SVGRootInlineBox::layoutChildBoxes):
(WebCore::SVGRootInlineBox::layoutRootBox):

  • rendering/SVGRootInlineBox.h:

(WebCore::SVGRootInlineBox::SVGRootInlineBox):
(WebCore::SVGRootInlineBox::virtualLogicalHeight):
(WebCore::SVGRootInlineBox::setLogicalHeight):

  • rendering/TrailingFloatsRootInlineBox.h:

(WebCore::TrailingFloatsRootInlineBox::TrailingFloatsRootInlineBox):
(WebCore::TrailingFloatsRootInlineBox::virtualLogicalHeight):

12:15 PM Changeset in webkit [68176] by commit-queue@webkit.org
  • 3 edits
    6 adds in trunk

2010-09-23 Matthew Delaney <mdelaney@apple.com>

Reviewed by Oliver Hunt.

context.drawImage with (source rect's height) = -(input image's native height) draws nothing
https://bugs.webkit.org/show_bug.cgi?id=46243

These test simply exercise using negative widths and heights for the source rect in ctx.drawImage calls.

  • canvas/philip/tests/2d.drawImage.negativeSourceHeight-expected.txt: Added.
  • canvas/philip/tests/2d.drawImage.negativeSourceHeight.html: Added.
  • canvas/philip/tests/2d.drawImage.negativeSourceHeight2-expected.txt: Added.
  • canvas/philip/tests/2d.drawImage.negativeSourceHeight2.html: Added.
  • canvas/philip/tests/2d.drawImage.negativeSourceHeightAndWidth-expected.txt: Added.
  • canvas/philip/tests/2d.drawImage.negativeSourceHeightAndWidth.html: Added.

2010-09-23 Matthew Delaney <mdelaney@apple.com>

Reviewed by Oliver Hunt.

context.drawImage with (source rect's height) = -(input image's native height) draws nothing
https://bugs.webkit.org/show_bug.cgi?id=46243

This patch changes canvasrenderingcontext2d's drawImage with an image element to
normalize the source and dest rects to acheive the desired canvas spec behavior
of allowing negative widths and heights that don't cause flipping and fix the
adverse behavior of specifying a source rect height of negative the source image's height

Tests: canvas/philip/tests/2d.drawImage.negativeSourceHeight.html

canvas/philip/tests/2d.drawImage.negativeSourceHeight2.html
canvas/philip/tests/2d.drawImage.negativeSourceHeightAndWidth.html

  • html/canvas/CanvasRenderingContext2D.cpp: Normalize rects in drawImage before calling lower level draw calls.
12:14 PM Changeset in webkit [68175] by aestes@apple.com
  • 6 edits in trunk

2010-09-22 Andy Estes <aestes@apple.com>

Reviewed by Darin Adler.

REGRESSION (r61285): Microsoft Entourage 2008 does not invoke My Day window
https://bugs.webkit.org/show_bug.cgi?id=46334

Microsoft My Day loads scripts using self-closing script tags, markup
which is incompatible with the HTML5 parser. Enable parser quirks for
this application.

  • WebView/WebView.mm: (shouldUsePreHTML5ParserQuirks): Return true if the application is Microsoft My Day and was linked against a version of WebKit prior to the introduction of the HTML5 parser.

2010-09-23 Renata Hodovan <reni@inf.u-szeged.hu>

Reviewed by Dirk Schulze.

SVGFEMorphologyElement doesn't support dynamic invalidation, when attributes change.
https://bugs.webkit.org/show_bug.cgi?id=46363
The patch also implements the simple setRadius method.

Tests: svg/dynamic-updates/SVGFEMorphologyElement-dom-in-attr.html

svg/dynamic-updates/SVGFEMorphologyElement-dom-operator-attr.html
svg/dynamic-updates/SVGFEMorphologyElement-dom-radius-attr.html
svg/dynamic-updates/SVGFEMorphologyElement-svgdom-in-prop.html
svg/dynamic-updates/SVGFEMorphologyElement-svgdom-operator-prop.html
svg/dynamic-updates/SVGFEMorphologyElement-svgdom-radius-call.html

  • svg/SVGFEMorphologyElement.cpp: (WebCore::SVGFEMorphologyElement::setRadius): (WebCore::SVGFEMorphologyElement::svgAttributeChanged):
  • svg/SVGFEMorphologyElement.h:
12:06 PM Changeset in webkit [68174] by Nate Chapin
  • 2 edits in trunk/LayoutTests

2010-09-23 Nate Chapin <Nate Chapin>

Unreviewed, Chromium expectations tweak.

Temporarily add http/tests/navigation/ping-*.

  • platform/chromium/test_expectations.txt:
11:59 AM Changeset in webkit [68173] by andersca@apple.com
  • 3 edits
    3 adds in trunk/WebKit2

Add PluginProcessMain files
https://bugs.webkit.org/show_bug.cgi?id=46379

Reviewed by Sam Weinig.

  • PluginProcess/PluginProcessMain.h: Added.
  • PluginProcess/mac/PluginProcessMainMac.mm: Added.
  • WebKit2.xcodeproj/project.pbxproj:

Add PluginProcessMain files. Remove PluginProcess.messages.in from the target so it
won't be installed in the WebKit2.framework bundle.

  • WebProcess/WebKitMain.cpp:

(WebKitMain):
Call PluginProcessMain if the process type is ProcessLauncher::PluginProcess.

11:50 AM Changeset in webkit [68172] by Patrick Gansterer
  • 1 edit
    2 copies in trunk/WebKit/wince

2010-09-23 Patrick Gansterer <Patrick Gansterer>

Reviewed by Adam Roben.

Add PlatformStrategiesWinCE
https://bugs.webkit.org/show_bug.cgi?id=46371

  • WebCoreSupport/PlatformStrategiesWinCE.cpp: Copied from WebKit/win/WebCoreSupport/WebPlatformStrategies.cpp.
  • WebCoreSupport/PlatformStrategiesWinCE.h: Copied from WebKit/win/WebCoreSupport/WebPlatformStrategies.h.
11:49 AM Changeset in webkit [68171] by oliver@apple.com
  • 9 edits in trunk/JavaScriptCore

Only copy captured variables into activation
https://bugs.webkit.org/show_bug.cgi?id=46330

Reviewed by Geoff Garen

We now track free variable information which means that
we no longer need to copy every variable defined in a
function. With this patch activations only retain those
variables needed for correctness. In order to interact
safely with the inspector this means that JSActivation
now provides its own lookup functions so it can avoid
trying to read or write to variables that have been
optimised out.

  • bytecode/CodeBlock.h:
  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::BytecodeGenerator):

  • parser/Nodes.h:

(JSC::ScopeNode::capturedVariableCount):
(JSC::ScopeNode::captures):

  • runtime/Arguments.h:

(JSC::JSActivation::copyRegisters):

  • runtime/Executable.cpp:

(JSC::FunctionExecutable::FunctionExecutable):
(JSC::FunctionExecutable::compileForCallInternal):
(JSC::FunctionExecutable::compileForConstructInternal):

  • runtime/Executable.h:

(JSC::FunctionExecutable::capturedVariableCount):

  • runtime/JSActivation.cpp:

(JSC::JSActivation::markChildren):
(JSC::JSActivation::symbolTableGet):
(JSC::JSActivation::symbolTablePut):
(JSC::JSActivation::getOwnPropertyNames):
(JSC::JSActivation::symbolTablePutWithAttributes):

  • runtime/JSActivation.h:
11:21 AM Changeset in webkit [68170] by andersca@apple.com
  • 9 edits
    1 copy
    3 adds in trunk/WebKit2

Add PluginProcessProxy class
https://bugs.webkit.org/show_bug.cgi?id=46377

Reviewed by Sam Weinig.

  • DerivedSources.make:

Add PluginProcess.

  • Platform/CoreIPC/Connection.h:

(CoreIPC::Connection::send):
Add send overload that takes a message.

  • Platform/CoreIPC/MessageID.h:

Add MessageClassPluginProcess message kind.

  • PluginProcess/PluginProcess.messages.in: Added.

Add PluginProcess messages.

  • UIProcess/Plugins/PluginInfoStore.cpp:

(WebKit::PluginInfoStore::infoForPluginWithPath):

  • UIProcess/Plugins/PluginInfoStore.h:

New function that returns the plug-in info for a plug-in with the given path.

  • UIProcess/Plugins/PluginProcessManager.cpp:

(WebKit::PluginProcessManager::getPluginProcessConnection):
Look for an existing plug-in process proxy.

  • UIProcess/Plugins/PluginProcessProxy.cpp: Added.

(WebKit::PluginProcessProxy::create):
Launch the process.

(WebKit::PluginProcessProxy::didReceiveMessage):
(WebKit::PluginProcessProxy::didReceiveInvalidMessage):
Add stubbed out functions.

(WebKit::PluginProcessProxy::didClose):
Delete the plug-in process proxy.

(WebKit::PluginProcessProxy::didFinishLaunching):
Open a connection to the plug-in process proxy.

  • UIProcess/Plugins/PluginProcessProxy.h: Added.

(WebKit::PluginProcessProxy::pluginInfo):
Return the plug-in info.

  • UIProcess/WebProcessProxy.h:

(WebKit::WebProcessProxy::context):
Add a context getter.

  • WebKit2.xcodeproj/project.pbxproj:

Add new files.

11:19 AM Changeset in webkit [68169] by Nate Chapin
  • 4 edits in trunk/WebKit

2010-09-23 Nate Chapin <Nate Chapin>

Unreviewed, build fix.

Look for hyperlinkAuditingEnabled in the right set of preferences.

  • WebView.cpp: (WebView::notifyPreferencesChanged):
11:17 AM Changeset in webkit [68168] by commit-queue@webkit.org
  • 4 edits
    30 adds in trunk

2010-09-23 Renata Hodovan <reni@inf.u-szeged.hu>

Reviewed by Dirk Schulze.

SVGFEMorphologyElement doesn't support dynamic invalidation, when attributes change.
https://bugs.webkit.org/show_bug.cgi?id=46363
Adding layout tests for feMorphology dynamic changes.

  • platform/mac/svg/dynamic-updates/SVGFEMorphologyElement-dom-in-attr-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFEMorphologyElement-dom-in-attr-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGFEMorphologyElement-dom-operator-attr-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFEMorphologyElement-dom-operator-attr-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGFEMorphologyElement-dom-radius-attr-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFEMorphologyElement-dom-radius-attr-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGFEMorphologyElement-svgdom-in-prop-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFEMorphologyElement-svgdom-in-prop-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGFEMorphologyElement-svgdom-operator-prop-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFEMorphologyElement-svgdom-operator-prop-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGFEMorphologyElement-svgdom-radius-call-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFEMorphologyElement-svgdom-radius-call-expected.png: Added.
  • svg/dynamic-updates/SVGFEMorphologyElement-dom-in-attr-expected.txt: Added.
  • svg/dynamic-updates/SVGFEMorphologyElement-dom-in-attr.html: Added.
  • svg/dynamic-updates/SVGFEMorphologyElement-dom-operator-attr-expected.txt: Added.
  • svg/dynamic-updates/SVGFEMorphologyElement-dom-operator-attr.html: Added.
  • svg/dynamic-updates/SVGFEMorphologyElement-dom-radius-attr-expected.txt: Added.
  • svg/dynamic-updates/SVGFEMorphologyElement-dom-radius-attr.html: Added.
  • svg/dynamic-updates/SVGFEMorphologyElement-svgdom-in-prop-expected.txt: Added.
  • svg/dynamic-updates/SVGFEMorphologyElement-svgdom-in-prop.html: Added.
  • svg/dynamic-updates/SVGFEMorphologyElement-svgdom-operator-prop-expected.txt: Added.
  • svg/dynamic-updates/SVGFEMorphologyElement-svgdom-operator-prop.html: Added.
  • svg/dynamic-updates/SVGFEMorphologyElement-svgdom-radius-call-expected.txt: Added.
  • svg/dynamic-updates/SVGFEMorphologyElement-svgdom-radius-call.html: Added.
  • svg/dynamic-updates/script-tests/SVGFEMorphologyElement-dom-in-attr.js: Added. (executeTest):
  • svg/dynamic-updates/script-tests/SVGFEMorphologyElement-dom-operator-attr.js: Added. (executeTest):
  • svg/dynamic-updates/script-tests/SVGFEMorphologyElement-dom-radius-attr.js: Added. (executeTest):
  • svg/dynamic-updates/script-tests/SVGFEMorphologyElement-svgdom-in-prop.js: Added. (executeTest):
  • svg/dynamic-updates/script-tests/SVGFEMorphologyElement-svgdom-operator-prop.js: Added. (executeTest):
  • svg/dynamic-updates/script-tests/SVGFEMorphologyElement-svgdom-radius-call.js: Added. (executeTest):

2010-09-23 Renata Hodovan <reni@inf.u-szeged.hu>

Reviewed by Dirk Schulze.

SVGFEMorphologyElement doesn't support dynamic invalidation, when attributes change.
https://bugs.webkit.org/show_bug.cgi?id=46363
The patch also implements the simple setRadius method.

Tests: svg/dynamic-updates/SVGFEMorphologyElement-dom-in-attr.html

svg/dynamic-updates/SVGFEMorphologyElement-dom-operator-attr.html
svg/dynamic-updates/SVGFEMorphologyElement-dom-radius-attr.html
svg/dynamic-updates/SVGFEMorphologyElement-svgdom-in-prop.html
svg/dynamic-updates/SVGFEMorphologyElement-svgdom-operator-prop.html
svg/dynamic-updates/SVGFEMorphologyElement-svgdom-radius-call.html

  • svg/SVGFEMorphologyElement.cpp: (WebCore::SVGFEMorphologyElement::setRadius): (WebCore::SVGFEMorphologyElement::svgAttributeChanged):
  • svg/SVGFEMorphologyElement.h:
11:08 AM Changeset in webkit [68167] by Patrick Gansterer
  • 3 edits in trunk/WebCore

2010-09-23 Patrick Gansterer <Patrick Gansterer>

Reviewed by Adam Roben.

Add synchronous loading for network resources to ResourceHandleWin
https://bugs.webkit.org/show_bug.cgi?id=46364

Use return value of onRequestComplete() to indicate that an additional
call to it is required for receiving remaining network data.

  • platform/network/ResourceHandle.h:
  • platform/network/win/ResourceHandleWin.cpp: (WebCore::ResourceHandle::onRequestComplete): (WebCore::ResourceHandle::start):
11:02 AM Changeset in webkit [68166] by Nate Chapin
  • 39 edits
    6 adds in trunk

2010-09-23 Nate Chapin <Nate Chapin>

Reviewed by Darin Fisher.


Implement <a ping> (disabled by default).
https://bugs.webkit.org/show_bug.cgi?id=30458


Tests: http/tests/navigation/ping-cross-origin-from-https.html

http/tests/navigation/ping-cross-origin.html
http/tests/navigation/ping-same-origin.html

  • html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::defaultEventHandler): (WebCore::HTMLAnchorElement::sendPings):
  • html/HTMLAnchorElement.h:
  • html/HTMLAttributeNames.in:
  • loader/PingLoader.cpp: (WebCore::PingLoader::sendPing): Set ping-specific headers. (WebCore::PingLoader::PingLoader):
  • loader/PingLoader.h: (WebCore::PingLoader::timeout): Ensure pings eventually timeout, since

the normal cancel mechanism can't stop them.

  • page/Settings.cpp:
  • page/Settings.h: Add hyperlinkAuditingEnabled.
10:56 AM Changeset in webkit [68165] by jhawkins@chromium.org
  • 7 edits in trunk/WebCore

2010-09-23 Steve VanDeBogart <vandebo@chromium.org>

Reviewed by David Levin.

https://bugs.webkit.org/show_bug.cgi?id=46312

Use Skia's SkSafeRef/SkSafeUnref functions instead of safeRef/safeUnref.

  • platform/graphics/chromium/FontLinux.cpp: (WebCore::Font::drawGlyphs):
  • platform/graphics/chromium/FontPlatformDataLinux.cpp: (WebCore::FontPlatformData::FontPlatformData): (WebCore::FontPlatformData::~FontPlatformData):
  • platform/graphics/skia/GradientSkia.cpp: (WebCore::Gradient::platformDestroy):
  • platform/graphics/skia/PatternSkia.cpp: (WebCore::Pattern::platformDestroy):
  • platform/graphics/skia/PlatformContextSkia.cpp: (WebCore::PlatformContextSkia::State::State): (WebCore::PlatformContextSkia::State::~State): (WebCore::PlatformContextSkia::drawRect): (WebCore::PlatformContextSkia::setStrokeShader): (WebCore::PlatformContextSkia::setFillShader): (WebCore::PlatformContextSkia::setDashPathEffect):
  • platform/graphics/skia/SkiaFontWin.cpp: (WebCore::paintSkiaText):
10:52 AM Changeset in webkit [68164] by demarchi@webkit.org
  • 2 edits in trunk/WebCore

2010-09-23 Lucas De Marchi <lucas.demarchi@profusion.mobi>

Reviewed by Csaba Osztrogonác.

Fix warnings regarding print format in 64 bits
https://bugs.webkit.org/show_bug.cgi?id=46357

Use inttypes.h in order to have portable print formats across 32 and
64 bits.

  • platform/sql/SQLiteFileSystem.cpp: (WebCore::SQLiteFileSystem::getFileNameForNewDatabase):
10:49 AM Changeset in webkit [68163] by crogers@google.com
  • 1 edit
    3 adds in trunk/WebCore

2010-09-23 Chris Rogers <crogers@google.com>

Reviewed by Kenneth Russell.

Add AudioContext files
https://bugs.webkit.org/show_bug.cgi?id=44890

No new tests since audio API is not yet implemented.

  • webaudio/AudioContext.cpp: Added. (WebCore::AudioContext::createAudioRequest): (WebCore::AudioContext::create): (WebCore::AudioContext::AudioContext): (WebCore::AudioContext::~AudioContext): (WebCore::AudioContext::lazyInitialize): (WebCore::AudioContext::uninitialize): (WebCore::AudioContext::isInitialized): (WebCore::AudioContext::isRunnable): (WebCore::AudioContext::stop): (WebCore::AudioContext::document): (WebCore::AudioContext::hasDocument): (WebCore::AudioContext::refBuffer): (WebCore::AudioContext::createBuffer): (WebCore::AudioContext::createBufferSource): (WebCore::AudioContext::createJavaScriptNode): (WebCore::AudioContext::createLowPass2Filter): (WebCore::AudioContext::createHighPass2Filter): (WebCore::AudioContext::createPanner): (WebCore::AudioContext::createConvolver): (WebCore::AudioContext::createAnalyser): (WebCore::AudioContext::createGainNode): (WebCore::AudioContext::createDelayNode): (WebCore::AudioContext::createChannelSplitter): (WebCore::AudioContext::createChannelMerger): (WebCore::AudioContext::notifyNodeFinishedProcessing): (WebCore::AudioContext::derefFinishedSourceNodes): (WebCore::AudioContext::refNode): (WebCore::AudioContext::derefNode): (WebCore::AudioContext::derefUnfinishedSourceNodes): (WebCore::AudioContext::lock): (WebCore::AudioContext::tryLock): (WebCore::AudioContext::unlock): (WebCore::AudioContext::isAudioThread): (WebCore::AudioContext::isGraphOwner): (WebCore::AudioContext::addDeferredFinishDeref): (WebCore::AudioContext::handlePostRenderTasks): (WebCore::AudioContext::handleDeferredFinishDerefs): (WebCore::AudioContext::markForDeletion): (WebCore::AudioContext::deleteMarkedNodes):
  • webaudio/AudioContext.h: Added. (WebCore::AudioContext::destination): (WebCore::AudioContext::currentTime): (WebCore::AudioContext::sampleRate): (WebCore::AudioContext::listener): (WebCore::AudioContext::temporaryMonoBus): (WebCore::AudioContext::temporaryStereoBus): (WebCore::AudioContext::incrementConnectionCount): (WebCore::AudioContext::connectionCount): (WebCore::AudioContext::setAudioThread): (WebCore::AudioContext::audioThread): (WebCore::AudioContext::isAudioThreadFinished): (WebCore::AudioContext::AutoLocker::AutoLocker): (WebCore::AudioContext::AutoLocker::~AutoLocker): (WebCore::AudioContext::RefInfo::RefInfo):
  • webaudio/AudioContext.idl: Added.
10:37 AM Changeset in webkit [68162] by jberlin@webkit.org
  • 3 edits in trunk/WebKit2

Expose the BundlePage on the BundleFrame in the API.
https://bugs.webkit.org/show_bug.cgi?id=46366

Reviewed by Sam Weinig.

  • WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:

(WKBundleFrameGetPage):

  • WebProcess/InjectedBundle/API/c/WKBundleFrame.h:
10:32 AM Changeset in webkit [68161] by jorlow@chromium.org
  • 5 edits in trunk

2010-09-23 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Steve Block.

IndexedDB shouldn't crash on invalid index names
https://bugs.webkit.org/show_bug.cgi?id=46362

  • storage/indexeddb/objectstore-basics-expected.txt:
  • storage/indexeddb/objectstore-basics.html:

2010-09-23 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Steve Block.

IndexedDB shouldn't crash on invalid index names
https://bugs.webkit.org/show_bug.cgi?id=46362

For now, return null. In a later patch, we'll do proper exception raising.

  • storage/IDBObjectStore.cpp: (WebCore::IDBObjectStore::index):
10:29 AM Changeset in webkit [68160] by ap@apple.com
  • 3 edits
    2 adds in trunk

Reviewed by Anders Carlsson.

https://bugs.webkit.org/show_bug.cgi?id=43667
ASSERT failure in NetscapePluginInstanceProxy::disconnectStream

Test: plugins/get-javascript-url.html

  • Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::evaluateJavaScript): Add the stream to m_streams, just like any other one.
10:27 AM Changeset in webkit [68159] by andersca@apple.com
  • 3 edits in trunk/WebKit2

It should be possible to conditionally define an entire group of messages
https://bugs.webkit.org/show_bug.cgi?id=46368

Reviewed by Adam Roben.

  • Scripts/webkit2/messages.py:

Check for a condition when parsing the "messages -> " string and set it as the
message receiver condition.

  • Scripts/webkit2/messages_unittest.py:

Add test.

10:21 AM Changeset in webkit [68158] by inferno@chromium.org
  • 3 edits
    2 adds in trunk

2010-09-23 Abhishek Arya <inferno@chromium.org>

Reviewed by Dave Hyatt.

Fix the memory safety issue by checking containerObject is a RenderBox
before doing the transforms.
https://bugs.webkit.org/show_bug.cgi?id=46365

Test: compositing/overflow/get-transform-from-non-box-container.html

  • rendering/RenderObject.cpp: (WebCore::RenderObject::getTransformFromContainer):

2010-09-23 Abhishek Arya <inferno@chromium.org>

Reviewed by Dave Hyatt.

Tests that we donot assert on object->isBox.
https://bugs.webkit.org/show_bug.cgi?id=46365

  • compositing/overflow/get-transform-from-non-box-container-expected.txt: Added.
  • compositing/overflow/get-transform-from-non-box-container.html: Added.
10:17 AM Changeset in webkit [68157] by hyatt@apple.com
  • 3 edits in trunk/WebCore

https://bugs.webkit.org/show_bug.cgi?id=46314.

Reviewed by Simon Fraser.

The RenderView's block-flow should match the root element's block-flow. When we create (or re-create) the style for the document, take
the block-flow from the document element's style and use it if it's available.

Also patch styleDidChange so that if the block-flow changes dynamically after we have already made the document style, we'll propagate
the change back up to the RenderView and have it do a relayout.

No tests possible yet, since you can't see the document's style anywhere, and block-flow isn't doing anything to affect layout
yet.

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::styleForDocument):

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::styleDidChange):

10:11 AM Changeset in webkit [68156] by kenneth@webkit.org
  • 2 edits
    2 adds in trunk/WebKit2

Add a preference class for Qt for WebKit2.

Reviewed by Andreas Kling.

  • UIProcess/API/qt/qwkpreferences.cpp: Added.

(QWKPreferences::globalPreferences):
(QWKPreferences::QWKPreferences):
(QWKPreferences::~QWKPreferences):
(QWKPreferences::testAttribute):
(QWKPreferences::setAttribute):

  • UIProcess/API/qt/qwkpreferences.h: Added.
  • WebKit2.pro:
10:10 AM Changeset in webkit [68155] by Dimitri Glazkov
  • 2 edits in trunk/LayoutTests

2010-09-23 Dimitri Glazkov <Dimitri Glazkov>

Remove passing tests. These were failing because the bot was missing QuickTime.

  • platform/chromium/drt_expectations.txt: Removed QuickTime-dependent tests after installing QuickTime on the build bot.
9:56 AM Changeset in webkit [68154] by demarchi@webkit.org
  • 5 edits in trunk/WebKit/efl

2010-09-23 Lucas De Marchi <lucas.demarchi@profusion.mobi>

Reviewed by Csaba Osztrogonác.

[EFL] Fix warnings during build
https://bugs.webkit.org/show_bug.cgi?id=46354

  • ewk/ewk_frame.cpp: (ewk_frame_text_matches_nth_pos_get): Change argument type because it's meant to be always positive.
  • ewk/ewk_frame.h: Ditto.
  • ewk/ewk_view.cpp: (ewk_view_exceeded_database_quota): Add missing "%" causing warning about number of arguments to printf-like function.
  • ewk/ewk_view.h: Add missing initialization.
9:46 AM Changeset in webkit [68153] by andersca@apple.com
  • 3 edits in trunk/WebKit2

Message autogeneration script should parse sync message syntax
https://bugs.webkit.org/show_bug.cgi?id=46359

Reviewed by Adam Roben.

  • Scripts/webkit2/messages.py:

(MessageReceiver.parse): Expand the regular expression to handle sync messages.
(function_parameter_type): Use a const reference for all parameters except the known builtins.
(base_class): Returns the base class for a sync message reply struct.
(delayed_base_class): Returns the base class for a delayed sync message reply struct.

  • Scripts/webkit2/messages_unittest.py:

Add unit tests for various sync messages.

9:45 AM Changeset in webkit [68152] by caseq@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-09-23 Andrey Kosyakov <caseq@chromium.org>

Unreviewed build fix ("WTF/" -> "wtf/" in include, broke Arm build)

  • src/AsyncFileWriterChromium.h:
9:37 AM Changeset in webkit [68151] by podivilov@chromium.org
  • 2 edits in trunk/WebCore

2010-09-23 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: source frame popups shouldn't disappear when hovered
https://bugs.webkit.org/show_bug.cgi?id=46358

  • inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype._mouseMove):
9:21 AM Changeset in webkit [68150] by demarchi@webkit.org
  • 2 edits in trunk

2010-09-23 Lucas De Marchi <lucas.demarchi@profusion.mobi>

Reviewed by Antonio Gomes.

[EFL] Enable warnings during build by default
https://bugs.webkit.org/show_bug.cgi?id=46351

Change default build to enable several warnings like other ports do.
We need to pay special attention to "-Wall" in order to produce better
code, so highlight this keyword, too.

  • cmake/WebKitHelpers.cmake:
9:20 AM Changeset in webkit [68149] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

2010-09-23 Mario Sanchez Prada <msanchez@igalia.com>

Reviewed by Chris Fleizach.

[Regression][Gtk] Left and Right Arrows no longer function when caret browsing is enabled
https://bugs.webkit.org/show_bug.cgi?id=45375

Added the following test to make sure key navigation across a
paragraph always work as expected, both with and without the shift
and ctrl modifiers.

  • platform/gtk/editing/selection/caret-mode-paragraph-keys-navigation-expected.txt: Added.
  • platform/gtk/editing/selection/caret-mode-paragraph-keys-navigation.html: Added.

2010-09-23 Mario Sanchez Prada <msanchez@igalia.com>

Reviewed by Chris Fleizach.

[Regression][Gtk] Left and Right Arrows no longer function when caret browsing is enabled
https://bugs.webkit.org/show_bug.cgi?id=45375

Consider caret browsing for Move commands.

Test: platform/gtk/editing/selection/caret-mode-left-right-arrows.html

  • editing/EditorCommand.cpp: (WebCore::createCommandMap): Use "caret browsing aware functions" as isEnabled() function for those commands moving the caret forward and backward across characters, words, lines or paragraphs, not just left and right, as it was the case so far.
9:18 AM Changeset in webkit [68148] by mitz@apple.com
  • 2 edits in trunk/WebCore

Address a remaining discrepancy in piecewise text measurement
https://bugs.webkit.org/show_bug.cgi?id=45796

Patch by Brad Moore <bradm@apple.com> on 2010-09-23
Reviewed by Dan Bernstein.

Don't include always-integral space widths in the floating point accumulator designed
to minimize precision loss. This brings whole-string measurement in line with piecewise
text measurement when dealing with fonts with fractional advances.

  • platform/graphics/WidthIterator.cpp:

(WebCore::WidthIterator::advance): Change the associativity of width addition to minimize precision loss.

9:12 AM Changeset in webkit [68147] by Patrick Gansterer
  • 3 edits in trunk/WebCore

2010-09-23 Patrick Gansterer <Patrick Gansterer>

Reviewed by Adam Roben.

Cleanup network communication code in ResourceHandleWin
https://bugs.webkit.org/show_bug.cgi?id=46200

Add logic for request handling directly into ResourceHandle::start and fix style.
Use Unicode instead of ASCII Windows API functions.

  • platform/network/ResourceHandleInternal.h: (WebCore::ResourceHandleInternal::ResourceHandleInternal):
  • platform/network/win/ResourceHandleWin.cpp: (WebCore::ResourceHandle::onRequestComplete): (WebCore::ResourceHandle::start):
8:56 AM Changeset in webkit [68146] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-09-23 Luiz Agostini <luiz.agostini@openbossa.org>

Reviewed by Andreas Kling.

Invalid assertion in ScriptCallback
https://bugs.webkit.org/show_bug.cgi?id=46348

Removing invalid ASSERT from method ScriptCallback::call().

  • bindings/js/ScriptFunctionCall.cpp: (WebCore::ScriptCallback::call):
8:51 AM Changeset in webkit [68145] by Martin Robinson
  • 7 edits
    2 moves
    2 adds in trunk/WebCore

2010-09-23 Martin Robinson <mrobinson@igalia.com>

Reviewed by Ariya Hidayat.

[Cairo] Generalize ContextShadow from the Qt port and use it for shadow code
https://bugs.webkit.org/show_bug.cgi?id=45599

Make ContextShadow platform-independent and add a Cairo implementation. This is currently
disabled for Cairo, but will be enabled in a followup patch with new baselines.

No new tests as this does not change functionality.

  • GNUmakefile.am: Update source lists.
  • WebCore.pro: Update source lists.
  • platform/graphics/ContextShadow.cpp: Added. A generalized version of Qt's ContextShadow. (WebCore::ContextShadow::ContextShadow): (WebCore::ContextShadow::clear): (WebCore::ContextShadow::blurLayerImage): (WebCore::ContextShadow::calculateMinimalLayerRect):
  • platform/graphics/ContextShadow.h: Added. (WebCore::ContextShadow::offset):
  • platform/graphics/cairo/CairoUtilities.cpp: Added. (WebCore::setSourceRGBAFromColor): A utility to set the source RGBA on a Cairo surface from a WebCore color.
  • platform/graphics/cairo/CairoUtilities.h: Added.
  • platform/graphics/cairo/ContextShadowCairo.cpp: Added. (WebCore::purgeScratchBuffer): Static function to purge the shadow buffer. (WebCore::PurgeScratchBufferTimer::fired): Timer callback. (WebCore::scheduleScratchBufferPurge): Schedule's a WebCore timer to purge the shadow buffer. (WebCore::getScratchBuffer): Create or reuse the scratch buffer. (WebCore::ContextShadow::beginShadowLayer): Added. (WebCore::ContextShadow::endShadowLayer): Added.
  • platform/graphics/gtk/CairoUtilities.cpp: Removed.
  • platform/graphics/gtk/CairoUtilities.h: Removed.
  • platform/graphics/gtk/GdkCairoUtilities.cpp: Renamed from CairoUtilities.cpp. (getCairoSurfacePixel): (getGdkPixbufPixel): (cairoImageSurfaceToGdkPixbuf):
  • platform/graphics/gtk/GdkCairoUtilities.h: Added.
  • platform/graphics/gtk/ImageBufferGtk.cpp:
  • platform/graphics/gtk/ImageGtk.cpp:
  • platform/graphics/qt/ContextShadow.cpp: Removed.
  • platform/graphics/qt/ContextShadow.h: Removed.
  • platform/graphics/qt/ContextShadowQt.cpp: Added. Adapted from code originally in ContextShadow.cpp. (WebCore::ShadowBuffer::ShadowBuffer): (WebCore::ShadowBuffer::scratchImage): (WebCore::ShadowBuffer::schedulePurge): (WebCore::ShadowBuffer::timerEvent): (WebCore::ContextShadow::beginShadowLayer): (WebCore::ContextShadow::endShadowLayer):
  • platform/graphics/qt/FontQt.cpp: (WebCore::drawTextCommon): Updated to reflect new ContextShadow members.
  • platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContextPlatformPrivate::hasShadow): Updated to reflect new ContextShadow members. (WebCore::GraphicsContext::strokeArc): Ditto. (WebCore::GraphicsContext::drawConvexPolygon): Ditto. (WebCore::GraphicsContext::fillPath): Ditto. (WebCore::GraphicsContext::strokePath): Ditto. (WebCore::GraphicsContext::fillRect): Ditto. (WebCore::GraphicsContext::fillRoundedRect): Ditto. (WebCore::GraphicsContext::setPlatformShadow): Ditto.
8:39 AM Changeset in webkit [68144] by Patrick Gansterer
  • 4 edits in trunk/WebCore

2010-09-23 Patrick Gansterer <Patrick Gansterer>

Reviewed by Adam Roben.

Add internetStatusCallback to ResourceHandleWin.
https://bugs.webkit.org/show_bug.cgi?id=46187

Add callback for asynchronous network transfer.

  • platform/network/ResourceHandle.h:
  • platform/network/ResourceHandleInternal.h:
  • platform/network/win/ResourceHandleWin.cpp: (WebCore::callOnRedirect): (WebCore::callOnRequestComplete): (WebCore::ResourceHandle::internetStatusCallback): (WebCore::ResourceHandle::onRedirect):
8:37 AM Changeset in webkit [68143] by andreip@google.com
  • 2 edits in trunk/WebCore

2010-09-23 Andrei Popescu <andreip@google.com>

Reviewed by Jeremy Orlow.

IDBTransactionCoordinator contains a broken assertion.
https://bugs.webkit.org/show_bug.cgi?id=46356

Remove the broken assertion.

  • storage/IDBTransactionCoordinator.cpp: (WebCore::IDBTransactionCoordinator::processStartedTransactions):
8:29 AM Changeset in webkit [68142] by andreas.kling@nokia.com
  • 2 edits in trunk/JavaScriptCore

2010-09-23 Ismail Donmez <ismail@namtrac.org>

Reviewed by Andreas Kling.

Fix jsc.exe build for Windows CE

  • jsc.pro: Add mmtimer.lib for Windows CE.
8:29 AM Changeset in webkit [68141] by tonyg@chromium.org
  • 5 edits
    2 adds in trunk/WebKit/chromium

2010-09-08 Tony Gentilcore <tonyg@chromium.org>

Reviewed by Darin Fisher.

[chromium] Add chromium port API for accessing Web Timing information
https://bugs.webkit.org/show_bug.cgi?id=45428

  • WebKit.gyp:
  • public/WebFrame.h:
  • public/WebPerformance.h: Added. (WebKit::WebPerformance::WebPerformance):
  • src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::performance):
  • src/WebFrameImpl.h:
  • src/WebPerformance.cpp: Added. (WebKit::WebPerformance::WebPerformance): (WebKit::WebPerformance::~WebPerformance): (WebKit::WebPerformance::operator=): (WebKit::WebPerformance::navigationType): (WebKit::WebPerformance::navigationStart): (WebKit::WebPerformance::unloadEventEnd): (WebKit::WebPerformance::redirectStart): (WebKit::WebPerformance::redirectEnd): (WebKit::WebPerformance::redirectCount): (WebKit::WebPerformance::fetchStart): (WebKit::WebPerformance::domainLookupStart): (WebKit::WebPerformance::domainLookupEnd): (WebKit::WebPerformance::connectStart): (WebKit::WebPerformance::connectEnd): (WebKit::WebPerformance::requestStart): (WebKit::WebPerformance::requestEnd): (WebKit::WebPerformance::responseStart): (WebKit::WebPerformance::responseEnd): (WebKit::WebPerformance::loadEventStart): (WebKit::WebPerformance::loadEventEnd): (WebKit::WebPerformance::operator PassRefPtr<Performance>):
8:20 AM Changeset in webkit [68140] by podivilov@chromium.org
  • 3 edits in trunk/WebCore

2010-09-23 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: highlight DOM nodes when navigating the DOM with keyboard
https://bugs.webkit.org/show_bug.cgi?id=46346

  • inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeElement.prototype.onselect):
  • inspector/front-end/treeoutline.js: (TreeOutline.prototype._treeKeyDown): (TreeElement.prototype.selectOnMouseDown): (TreeElement.prototype.select):
8:13 AM Changeset in webkit [68139] by andreip@google.com
  • 3 edits in trunk/WebCore

2010-09-23 Andrei Popescu <andreip@google.com>

Reviewed by Jeremy Orlow.

[Chromium] Build broken due to missing include in IDBTransactionBackendImpl.h
https://bugs.webkit.org/show_bug.cgi?id=46352

No new tests needed, build fix.

  • storage/IDBTransaction.cpp: (WebCore::IDBTransaction::objectStore):
  • storage/IDBTransactionBackendImpl.h:
7:34 AM Changeset in webkit [68138] by andreip@google.com
  • 46 edits in trunk

2010-09-23 Andrei Popescu <andreip@google.com>

Reviewed by Jeremy Orlow.

IDBObjectStore::get should run in a transaction.
https://bugs.webkit.org/show_bug.cgi?id=44700

  • storage/indexeddb/objectstore-basics-expected.txt:
  • storage/indexeddb/objectstore-basics.html:
  • storage/indexeddb/objectstore-removeobjectstore-expected.txt:
  • storage/indexeddb/objectstore-removeobjectstore.html:

2010-09-23 Andrei Popescu <andreip@google.com>

Reviewed by Jeremy Orlow.

IDBObjectStore::get should run in a transaction.
https://bugs.webkit.org/show_bug.cgi?id=44700

Implements logic for running IDBObjectStore::get() in a transaction.
Refactors the pending transaction monitor and the transaction coordinator
to use pointers instead of transaction IDs.

  • bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::didLeaveScriptContext):
  • storage/IDBCursorBackendImpl.cpp:
  • storage/IDBDatabase.cpp: (WebCore::IDBDatabase::objectStore):
  • storage/IDBDatabaseBackendImpl.cpp: (WebCore::IDBDatabaseBackendImpl::objectStore):
  • storage/IDBDatabaseBackendImpl.h: (WebCore::IDBDatabaseBackendImpl::transactionCoordinator):
  • storage/IDBFactoryBackendImpl.cpp:
  • storage/IDBFactoryBackendImpl.h:
  • storage/IDBFactoryBackendInterface.h:
  • storage/IDBObjectStore.cpp: (WebCore::IDBObjectStore::IDBObjectStore): (WebCore::IDBObjectStore::get):
  • storage/IDBObjectStore.h: (WebCore::IDBObjectStore::create):
  • storage/IDBObjectStoreBackendImpl.cpp: (WebCore::IDBTask::IDBTask): (WebCore::IDBTask::performTask): (WebCore::createTask): (WebCore::IDBObjectStoreBackendImpl::get): (WebCore::IDBObjectStoreBackendImpl::getInternal):
  • storage/IDBObjectStoreBackendImpl.h:
  • storage/IDBObjectStoreBackendInterface.h:
  • storage/IDBPendingTransactionMonitor.cpp: (WebCore::IDBPendingTransactionMonitor::addPendingTransaction): (WebCore::IDBPendingTransactionMonitor::removePendingTransaction): (WebCore::IDBPendingTransactionMonitor::abortPendingTransactions):
  • storage/IDBPendingTransactionMonitor.h:
  • storage/IDBRequest.cpp: (WebCore::IDBRequest::IDBRequest): (WebCore::IDBRequest::~IDBRequest): (WebCore::IDBRequest::onSuccess): (WebCore::IDBRequest::timerFired):
  • storage/IDBRequest.h: (WebCore::IDBRequest::create):
  • storage/IDBTransaction.cpp: (WebCore::IDBTransaction::IDBTransaction): (WebCore::IDBTransaction::objectStore):
  • storage/IDBTransactionBackendImpl.cpp: (WebCore::IDBTransactionBackendImpl::create): (WebCore::IDBTransactionBackendImpl::IDBTransactionBackendImpl): (WebCore::IDBTransactionBackendImpl::objectStore): (WebCore::IDBTransactionBackendImpl::scheduleTask): (WebCore::IDBTransactionBackendImpl::abort): (WebCore::IDBTransactionBackendImpl::didCompleteTaskEvents): (WebCore::IDBTransactionBackendImpl::run): (WebCore::IDBTransactionBackendImpl::start): (WebCore::IDBTransactionBackendImpl::commit): (WebCore::IDBTransactionBackendImpl::timerFired):
  • storage/IDBTransactionBackendImpl.h: (WebCore::IDBTransactionBackendImpl::~IDBTransactionBackendImpl): (WebCore::IDBTransactionBackendImpl::isFinished):
  • storage/IDBTransactionBackendInterface.h:
  • storage/IDBTransactionCoordinator.cpp: (WebCore::IDBTransactionCoordinator::createTransaction): (WebCore::IDBTransactionCoordinator::didStartTransaction): (WebCore::IDBTransactionCoordinator::didFinishTransaction): (WebCore::IDBTransactionCoordinator::processStartedTransactions):
  • storage/IDBTransactionCoordinator.h:

2010-09-23 Andrei Popescu <andreip@google.com>

Reviewed by Jeremy Orlow.

IDBObjectStore::get should run in a transaction.
https://bugs.webkit.org/show_bug.cgi?id=44700

  • public/WebIDBFactory.h:
  • public/WebIDBObjectStore.h:
  • public/WebIDBTransaction.h: (WebKit::WebIDBTransaction::didCompleteTaskEvents): (WebKit::WebIDBTransaction::getIDBTransactionBackendInterface):
  • src/IDBDatabaseProxy.h:
  • src/IDBFactoryBackendProxy.cpp:
  • src/IDBFactoryBackendProxy.h:
  • src/IDBObjectStoreProxy.cpp: (WebCore::IDBObjectStoreProxy::get):
  • src/IDBObjectStoreProxy.h:
  • src/IDBTransactionBackendProxy.cpp: (WebCore::IDBTransactionBackendProxy::scheduleTask): (WebCore::IDBTransactionBackendProxy::didCompleteTaskEvents):
  • src/IDBTransactionBackendProxy.h: (WebCore::IDBTransactionBackendProxy::getWebIDBTransaction):
  • src/WebIDBFactoryImpl.cpp:
  • src/WebIDBFactoryImpl.h:
  • src/WebIDBObjectStoreImpl.cpp: (WebKit::WebIDBObjectStoreImpl::get):
  • src/WebIDBObjectStoreImpl.h:
  • src/WebIDBTransactionImpl.cpp: (WebKit::WebIDBTransactionImpl::didCompleteTaskEvents): (WebKit::WebIDBTransactionImpl::getIDBTransactionBackendInterface):
  • src/WebIDBTransactionImpl.h:
7:24 AM Changeset in webkit [68137] by Patrick Gansterer
  • 1 edit
    2 adds in trunk/WebKit/wince

2010-09-23 Patrick Gansterer <Patrick Gansterer>

Reviewed by Adam Roben.

Add ChromeClientWinCE
https://bugs.webkit.org/show_bug.cgi?id=46294

  • WebCoreSupport/ChromeClientWinCE.cpp: Added.
  • WebCoreSupport/ChromeClientWinCE.h: Added.
7:24 AM Changeset in webkit [68136] by senorblanco@chromium.org
  • 6 edits in trunk/WebKitTools

2010-09-21 Stephen White <senorblanco@chromium.org>

Reviewed by David Levin.

Implement --enable-accelerated-2d-canvas flag in DumpRenderTree.
https://bugs.webkit.org/show_bug.cgi?id=46208

This flag allows the layout tests to be run with or without accelerated
2D canvas rendering.

  • DumpRenderTree/chromium/DumpRenderTree.cpp: (main): Declare the new flag string, and check for it on startup.
  • DumpRenderTree/chromium/TestShell.cpp: (TestShell::TestShell): Add a boolean for the new flag, in order to preserve its value over preferences reset. (TestShell::resetWebSettings): Set the new flag to the stored value on reset.
  • DumpRenderTree/chromium/TestShell.h: (TestShell::setAccelerated2dCanvasEnabled): Add an accessor for the new flag.
  • DumpRenderTree/chromium/WebPreferences.cpp: (WebPreferences::reset): Initialize the new flag to false. (WebPreferences::applyTo): Copy the flag's value to the WebSettings.
  • DumpRenderTree/chromium/WebPreferences.h: Add the new flag.
7:22 AM Changeset in webkit [68135] by Patrick Gansterer
  • 3 edits in trunk/WebCore

2010-09-23 Patrick Gansterer <Patrick Gansterer>

Reviewed by Adam Roben.

[WINCE] Remove usage of MemoryManager
https://bugs.webkit.org/show_bug.cgi?id=46206

MemoryManager does not provide any extra value, so remove it.

  • page/wince/FrameWinCE.cpp: (WebCore::imageFromSelection):
  • platform/graphics/wince/PlatformPathWinCE.cpp: (WebCore::drawPolygons):
7:14 AM Changeset in webkit [68134] by Patrick Gansterer
  • 2 edits in trunk/JavaScriptCore

2010-09-23 Ismail Dönmez <ismail@namtrac.org>

Unreviewed.

JIT should be disabled on Windows CE. Broken in r64176.

  • wtf/Platform.h:
6:47 AM QtWebKitRelease20 edited by Ademar Reis
(diff)
6:36 AM Changeset in webkit [68133] by commit-queue@webkit.org
  • 2 edits in trunk/WebKit/win

2010-09-23 Matthew Delaney <mdelaney@apple.com>

Reviewed by Adam Roben.

Create one time initialization block for WebView's initWithFrame
https://bugs.webkit.org/show_bug.cgi?id=46307

  • WebView.cpp: Added one time initialization block for webview code that needs only be run once and not for each webview. This is just as the mac version WebView.mm does.
6:29 AM Changeset in webkit [68132] by Patrick Gansterer
  • 3 edits in trunk/WebKit/wince

2010-09-23 Patrick Gansterer <Patrick Gansterer>

Unreviewed.

Build fix for FrameLoaderClientWinCE.

  • WebCoreSupport/FrameLoaderClientWinCE.cpp: (WebKit::FrameLoaderClientWinCE::canShowMIMETypeAsHTML): Add missing method.
  • WebCoreSupport/FrameLoaderClientWinCE.h:
5:38 AM Changeset in webkit [68131] by jorlow@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-09-23 Jeremy Orlow <jorlow@chromium.org>

Unreviewed small fix for my last patch.

  • public/WebIDBTransaction.h: (WebKit::WebIDBTransaction::id):
4:24 AM Changeset in webkit [68130] by vestbo@webkit.org
  • 1 add in trunk/WebKit/qt/examples/examples.pro

Fix Qt build by adding missing file

4:13 AM Changeset in webkit [68129] by abarth@webkit.org
  • 14 edits
    3 adds
    1 delete in trunk/LayoutTests

2010-09-23 Adam Barth <abarth@webkit.org>

Rubber-stamped by Eric Seidel.

Sync HTML5lib tests with upstream.

  • html5lib/resources/comments01.dat:
  • html5lib/resources/pending-spec-changes-plain-text-unsafe.dat: Added.
  • html5lib/resources/pending-spec-changes.dat: Added.
  • html5lib/resources/plain-text-unsafe.dat: Added.
  • html5lib/resources/tests1.dat:
  • html5lib/resources/tests10.dat:
  • html5lib/resources/tests13.dat: Removed.
  • html5lib/resources/tests14.dat:
  • html5lib/resources/tests15.dat:
  • html5lib/resources/tests17.dat:
  • html5lib/resources/tests19.dat:
  • html5lib/resources/tests20.dat:
  • html5lib/resources/tests21.dat:
  • html5lib/resources/tests9.dat:
  • html5lib/resources/tests_innerHTML_1.dat:
  • html5lib/runner-expected.txt:
3:53 AM Changeset in webkit [68128] by vestbo@webkit.org
  • 9 edits in trunk

2010-09-23 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>

Reviewed by Simon Hausmann.

[Qt] Refactor QtWebKitPlatformPlugin interface

Make it easier to keep source-compability for the
QtWebKitPlatformPlugin interface, and run qmake
on the example (but not build) for convenience.

https://bugs.webkit.org/show_bug.cgi?id=46345

  • Api/qwebkitplatformplugin.h:
  • WebCoreSupport/QtPlatformPlugin.cpp:
  • examples/platformplugin/README:
  • examples/platformplugin/WebPlugin.cpp:
  • examples/platformplugin/WebPlugin.h:
  • examples/platformplugin/qwebkitplatformplugin.h:

2010-09-23 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>

Reviewed by Simon Hausmann.

[Qt] Refactor QtWebKitPlatformPlugin interface

Make it easier to keep source-compability for the
QtWebKitPlatformPlugin interface, and run qmake
on the example (but not build) for convenience.

https://bugs.webkit.org/show_bug.cgi?id=46345

  • Scripts/webkitdirs.pm:
1:40 AM Changeset in webkit [68127] by commit-queue@webkit.org
  • 3 edits in trunk/JavaScriptCore

2010-09-23 Peter Varga <pvarga@inf.u-szeged.hu>

Reviewed by Gavin Barraclough.

Reduce the number of BOL checks in YARR Interpreter
https://bugs.webkit.org/show_bug.cgi?id=46260

Extend the YARR Interpreter with an optimization which reduces the number of
BOL assertion checks. If a "TypeBodyAlternative" byteTerm is followed by a
"TypeAssertionBOL" byteTerm it will be checked just one time.

  • yarr/RegexInterpreter.cpp: (JSC::Yarr::Interpreter::matchDisjunction): (JSC::Yarr::ByteCompiler::compile): (JSC::Yarr::ByteCompiler::regexBegin): (JSC::Yarr::ByteCompiler::alternativeBodyDisjunction): (JSC::Yarr::ByteCompiler::emitDisjunction):
  • yarr/RegexInterpreter.h: (JSC::Yarr::ByteTerm::BodyAlternativeBegin): (JSC::Yarr::ByteTerm::BodyAlternativeDisjunction): (JSC::Yarr::ByteTerm::BodyAlternativeEnd): (JSC::Yarr::ByteTerm::AlternativeBegin): (JSC::Yarr::ByteTerm::AlternativeDisjunction): (JSC::Yarr::ByteTerm::AlternativeEnd):
1:38 AM Changeset in webkit [68126] by Darin Adler
  • 3 edits in trunk/WebCore

2010-09-23 Darin Adler <Darin Adler>

Reviewed by Chris Fleizach.

media/video-controls-with-mutation-event-handler.html crashing
https://bugs.webkit.org/show_bug.cgi?id=46169

  • rendering/MediaControlElements.cpp: (WebCore::MediaControlInputElement::MediaControlInputElement): Don't take a type argument. We can't set the type until after the element is created beacuse of reference counting rules. (WebCore::MediaControlMuteButtonElement::MediaControlMuteButtonElement): Don't pass the type. (WebCore::MediaControlMuteButtonElement::create): Set the type. (WebCore::MediaControlPlayButtonElement::MediaControlPlayButtonElement): More of the same. (WebCore::MediaControlPlayButtonElement::create): Ditto. (WebCore::MediaControlSeekButtonElement::MediaControlSeekButtonElement): Ditto. (WebCore::MediaControlSeekButtonElement::create): Ditto. (WebCore::MediaControlRewindButtonElement::MediaControlRewindButtonElement): Ditto. (WebCore::MediaControlRewindButtonElement::create): Ditto. (WebCore::MediaControlReturnToRealtimeButtonElement::MediaControlReturnToRealtimeButtonElement): Ditto. (WebCore::MediaControlReturnToRealtimeButtonElement::create): Ditto. (WebCore::MediaControlToggleClosedCaptionsButtonElement::MediaControlToggleClosedCaptionsButtonElement): Ditto. (WebCore::MediaControlToggleClosedCaptionsButtonElement::create): Ditto. (WebCore::MediaControlTimelineElement::MediaControlTimelineElement): Ditto. (WebCore::MediaControlTimelineElement::create): Ditto. (WebCore::MediaControlVolumeSliderElement::MediaControlVolumeSliderElement): Ditto. (WebCore::MediaControlVolumeSliderElement::create): Ditto. (WebCore::MediaControlFullscreenButtonElement::MediaControlFullscreenButtonElement): Ditto. (WebCore::MediaControlFullscreenButtonElement::create): Ditto.
  • rendering/MediaControlElements.h: Removed the type argument from the MediaControlInputElement constructor.
12:23 AM Changeset in webkit [68125] by abarth@webkit.org
  • 3 edits in trunk/WebKitTools

2010-09-23 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Tweak some status messages that Eric thought were confusing
https://bugs.webkit.org/show_bug.cgi?id=46342

  • Scripts/webkitpy/tool/commands/queues.py:
  • Scripts/webkitpy/tool/commands/queues_unittest.py:
Note: See TracTimeline for information about the timeline view.