Context Navigation

When transitioning between an non-repeating beginning of line
anchored expression and the remaining refactored repeating
expression, we should not clear any residual datalabel in
state's m_backtrack. It will be resolved and cleared in subsequent
code when linkAlternativeBacktracks() is called for the repeating
alternative(s).

yarr/RegexJIT.cpp: (JSC::Yarr::RegexGenerator::BacktrackDestination::clear): (JSC::Yarr::RegexGenerator::TermGenerationState::clearBacktrack):

2010-12-17 Michael Saboff <msaboff@apple.com>

Reviewed by Oliver Hunt.

RegExp Jit'ed expression crashes clicking link on yelp.com
https://bugs.webkit.org/show_bug.cgi?id=51284

New tests to validate changes made in regex JIT.

fast/regex/parentheses-expected.txt:
fast/regex/script-tests/parentheses.js:

5:57 PM Changeset in webkit [74308] by mitz@apple.com

5 edits in trunk

Updated for the renaming of WebKitTools to Tools

Rubber-stamped by Mark Rowe.

JavaScriptCore:

JavaScriptCore.vcproj/JavaScriptCore/build-generated-files.sh:

WebCore:

WebCore.vcproj/build-generated-files.sh:
WebCore.vcproj/migrate-scripts.sh:

5:56 PM Changeset in webkit [74307] by tonyg@chromium.org

2 edits in trunk/WebKit/chromium

2010-12-17 Tony Gentilcore <tonyg@chromium.org>

Unreviewed, build fix.

Add WebKitTools -> Tools rename that got missed.

WebKit.gyp:

5:43 PM UsingGitWithWebKit edited by rniwa@webkit.org

Replaced WebKitTools by Tools (diff)

5:42 PM Changeset in webkit [74306] by Darin Adler

2 edits in trunk/WebKit2

2010-12-17 Darin Adler <Darin Adler>

Reviewed by Dan Bernstein.

Window title for image documents shows corrupted characters instead of multiplication sign when using WebKit2
https://bugs.webkit.org/show_bug.cgi?id=43505

WebProcess/WebCoreSupport/WebPlatformStrategies.cpp: Changed UI_STRING macros to return WebCore::String objects instead of C strings. (WebKit::formatLocalizedString): Added. Uses the Core Foundation string formatting function for reasons explained in the comment. (WebKit::WebPlatformStrategies::multipleFileUploadText): Use formatLocalizedString instead of String::format. (WebKit::WebPlatformStrategies::imageTitle): Ditto. (WebKit::WebPlatformStrategies::localizedMediaTimeDescription): Ditto.

5:24 PM Changeset in webkit [74305] by jberlin@webkit.org

1 edit
2 adds in trunk/LayoutTests

Add expected results for Windows XP to get the bot green for
http://trac.webkit.org/changeset/74281.
Unreviewed.

platform/win-xp/fast/text/emphasis-expected.txt: Added.
platform/win-xp/fast/text/emphasis-vertical-expected.txt: Added.

5:14 PM Changeset in webkit [74304] by dpranke@chromium.org

2 edits in trunk/WebKit/chromium

2010-12-17 Dirk Pranke <dpranke@chromium.org>

Unreviewed, build fix.

Add WebKitTools -> Tools rename that got missed.

WebKit.gyp:

5:07 PM Changeset in webkit [74303] by andersca@apple.com

2 edits in trunk/WebKit2

2010-12-17 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Resizing a WKView while loading a page can leave the page at a size that doesn't match the window
https://bugs.webkit.org/show_bug.cgi?id=51282
<rdar://problem/8133142>

Fix a race condition in waitForMessage. If we time out on the wait condition, we would keep the
m_waitForMessageMutex mutex unlocked for a brief period of time before taking the lock again and
then removing the messageID/destinationID pair from the hash map. Under some circumstances, the
connection queue would update the hash map right before we removed it, leading to a lost message.

Platform/CoreIPC/Connection.cpp: (CoreIPC::Connection::waitForMessage):

4:30 PM Changeset in webkit [74302] by Csaba Osztrogonác

3 edits in trunk/Tools

Unreviewed Qt buildfix after r74301.

Rename WebKitTools to Tools
https://bugs.webkit.org/show_bug.cgi?id=49861

MiniBrowser/DerivedSources.pro:
MiniBrowser/qt/MiniBrowser.pro:

4:02 PM Changeset in webkit [74301] by mitz@apple.com

64 edits
1 move in trunk

Rename WebKitTools to Tools
https://bugs.webkit.org/show_bug.cgi?id=49861

Reviewed by Simon Fraser.

DerivedSources.pro:
GNUmakefile.am:
MakeFile:
MakeFile.shared:
Tools: Renamed from WebKitTools.
WebKit.pro:
cmake/WebKitPackaging.cmake:
wscript:

BugsSite:

PrettyPatch/PrettyPatch.rb:
committers-autocomplete.js:

Tools:

BuildSlaveSupport/build.webkit.org-config/master.cfg:
CodeCoverage/README:
DumpRenderTree/qt/DumpRenderTreeQt.cpp:

(WebCore::DumpRenderTree::initializeFonts):

EWSTools/start-commit-queue.sh:
EWSTools/start-queue.sh:
GNUmakefile.am:
MIDLWrapper/MIDLWrapper.cpp:

(wmain):

MiniBrowser/qt/MiniBrowser.pro:
Scripts/build-api-tests:
Scripts/build-dumprendertree:
Scripts/build-webkit:
Scripts/build-webkittestrunner:
Scripts/generate-coverage-data:
Scripts/old-run-webkit-tests:
Scripts/run-api-tests:
Scripts/run-iexploder-tests:
Scripts/run-javascriptcore-tests:
Scripts/run-mangleme-tests:
Scripts/run-sunspider:
Scripts/run-webkit-websocketserver:
Scripts/sunspider-compare-results:
Scripts/test-webkitperl:
Scripts/test-webkitpy:
Scripts/update-iexploder-cssproperties:
Scripts/update-webkit:
Scripts/update-webkit-localizable-strings:
Scripts/webkitdirs.pm:
Scripts/webkitpy/common/checkout/scm.py:
Scripts/webkitpy/common/checkout/scm_unittest.py:
Scripts/webkitpy/common/config/committervalidator.py:
Scripts/webkitpy/common/config/committervalidator_unittest.py:
Scripts/webkitpy/common/config/ports.py:
Scripts/webkitpy/common/config/ports_unittest.py:
Scripts/webkitpy/common/system/logutils_unittest.py:
Scripts/webkitpy/common/system/ospath_unittest.py:
Scripts/webkitpy/layout_tests/port/chromium.py:
Scripts/webkitpy/layout_tests/port/config.py:
Scripts/webkitpy/layout_tests/port/config_unittest.py:
Scripts/webkitpy/layout_tests/port/http_server.py:
Scripts/webkitpy/layout_tests/port/test.py:
Scripts/webkitpy/style/checker.py:
Scripts/webkitpy/style/checker_unittest.py:
Scripts/webkitpy/tool/bot/feeders_unittest.py:
Scripts/webkitpy/tool/commands/queues_unittest.py:
Scripts/webkitpy/tool/steps/steps_unittest.py:
WebKitTestRunner/DerivedSources.pro:
WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:

(WTR::activateFonts):

WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
wx/build/build_utils.py:

WebKitSite:

asking_questions.html:
building/tools.html:
coding/scripts.html:

3:35 PM Changeset in webkit [74300] by andersca@apple.com

4 edits in trunk/WebKit2

Clean up ChunkedUpdateDrawingAreaProxy
https://bugs.webkit.org/show_bug.cgi?id=51277

Reviewed by Simon Fraser.

Get rid of m_lastSetViewSize since it was always equal to m_size.

UIProcess/ChunkedUpdateDrawingAreaProxy.cpp:

(WebKit::ChunkedUpdateDrawingAreaProxy::sizeDidChange):
Call sendSetSize().

(WebKit::ChunkedUpdateDrawingAreaProxy::didSetSize):
Call sendSetSize if the size differs.

(WebKit::ChunkedUpdateDrawingAreaProxy::sendSetSize):
Move code from sizeDidChange over here.

UIProcess/ChunkedUpdateDrawingAreaProxy.h:
UIProcess/DrawingAreaProxy.cpp:

(WebKit::DrawingAreaProxy::setSize):
Add back the early return if the sizes are equal.

3:28 PM Changeset in webkit [74299] by ariya@webkit.org

2 edits in trunk/JavaScriptCore

2010-12-17 Ariya Hidayat <ariya@sencha.com>

Reviewed by Oliver Hunt.

[JSC] parseAssignmentExpression should use TreeBuilder::CreatesAST
https://bugs.webkit.org/show_bug.cgi?id=51268

parser/JSParser.cpp: (JSC::JSParser::parseAssignmentExpression):

3:03 PM Changeset in webkit [74298] by bfulgham@webkit.org

2 edits in trunk/WebKit2

Unreviewed build fix.

WebProcess/WebPage/win/WebPageWin.cpp:

(WebKit::WebPage::canHandleRequest): Provide alternative for
non-CFNetwork implementation.

2:48 PM Changeset in webkit [74297] by ggaren@apple.com

3 edits in trunk/JavaScriptCore

2010-12-17 Geoffrey Garen <ggaren@apple.com>

Reviewed by Oliver Hunt.

Removed RChunk from PageAllocation/PageReservation, since it's now unused.
https://bugs.webkit.org/show_bug.cgi?id=51276

wtf/PageAllocation.h: (WTF::PageAllocation::PageAllocation):
wtf/PageReservation.h: (WTF::PageReservation::PageReservation):

2:43 PM Changeset in webkit [74296] by adachan@apple.com

10 edits in trunk/WebKit2

Reviewed by Anders Carlsson.

Implement WKView::setInitialFocus().
https://bugs.webkit.org/show_bug.cgi?id=51274

UIProcess/API/C/win/WKView.cpp: (WKViewSetInitialFocus):
UIProcess/API/C/win/WKView.h:
UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::setInitialFocus): Send message to the Web Process to set initial focus.
UIProcess/WebPageProxy.h:
UIProcess/win/WebView.cpp: (WebKit::WebView::setInitialFocus):
UIProcess/win/WebView.h:
WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::setInitialFocus): Set the focused node to null initially. Then ask FocusController to set the initial focus based on the focus direction.
WebProcess/WebPage/WebPage.h:
WebProcess/WebPage/WebPage.messages.in: Add a new message for SetInitialFocus.

2:24 PM Changeset in webkit [74295] by andersca@apple.com

2 edits in trunk/WebKit2

Remove a check that probably uncovered a resizing bug.

Reviewed by Sam Weinig.

UIProcess/DrawingAreaProxy.cpp:

(WebKit::DrawingAreaProxy::setSize):

2:11 PM Changeset in webkit [74294] by andersca@apple.com

9 edits in trunk/WebKit2

2010-12-17 Brian Weinstein <bweinstein@apple.com>

Qt build fix.

UIProcess/qt/WebPopupMenuProxyQt.h:

1:54 PM Changeset in webkit [74293] by Simon Fraser

3 edits in trunk/LayoutTests

2010-12-17 Simon Fraser <Simon Fraser>

Change this test to use the pause API by testing the individual properties,
rather than the compound property.

transitions/mask-transitions-expected.txt: Removed.
transitions/mask-transitions.html:

1:50 PM BuildBot edited by Dimitri Glazkov

(diff)

1:39 PM Changeset in webkit [74292] by carol.szabo@nokia.com

4 edits in trunk/WebCore

2010-12-17 Carol Szabo <carol.szabo@nokia.com>

Reviewed by Darin Adler.

A corrupted counter tree is created when renderers are added to the
tree bypassing RenderObject::addChild
https://bugs.webkit.org/show_bug.cgi?id=51270

This patch replaces the hack introduced for fixing bug 43812
with code that addresses the underlying problem for that bug.
No new layout tests provided as there is no identified scenario when
visible behavior would be different, the internal datastructures
are maintained properly through this fix so the previous hack
introduced for bug 43812 is now removed. The fact that the
layout test introduced for 43812 continues to pass is proof that the
code works.

rendering/RenderCounter.cpp: (WebCore::findPlaceForCounter): Removed hack.
rendering/RenderObject.cpp: (WebCore::RenderObject::addChild): Moved call to counter nodes updater to lower level functions to avoid bypass.
rendering/RenderObjectChildList.cpp: (WebCore::RenderObjectChildList::appendChildNode): (WebCore::RenderObjectChildList::insertChildNode): Changed to update the values of the counters that may be inserted in the tree.

1:38 PM Changeset in webkit [74291] by oliver@apple.com

3 edits
3 adds in trunk

2010-12-17 Oliver Hunt <oliver@apple.com>

Reviewed by Gavin Barraclough.

Incorrect encoding of some constants in ARMv7 JIT
https://bugs.webkit.org/show_bug.cgi?id=51273
<rdar://problem/8650210>

When using immediate encoding 3 we need to write the byte
that holds a duplicated value.

assembler/ARMv7Assembler.h: (JSC::ARMThumbImmediate::makeEncodedImm):

2010-12-17 Oliver Hunt <oliver@apple.com>

Reviewed by Gavin Barraclough.

Incorrect encoding of some constants in ARMv7 JIT
https://bugs.webkit.org/show_bug.cgi?id=51273

Add a few tests for different byte patterns in immediates.

fast/js/constant-encoding-expected.txt: Added.
fast/js/constant-encoding.html: Added.
fast/js/script-tests/constant-encoding.js: Added.

1:37 PM Changeset in webkit [74290] by jberlin@webkit.org

1 edit
6 adds in trunk/LayoutTests

Add Windows-specific expected results for the the tests added in
http://trac.webkit.org/changeset/74281.

Rubber-stamped by Dan Bernstein.

platform/win/fast/text/emphasis-expected.checksum: Added.
platform/win/fast/text/emphasis-expected.png: Added.
platform/win/fast/text/emphasis-expected.txt: Added.
platform/win/fast/text/emphasis-vertical-expected.checksum: Added.
platform/win/fast/text/emphasis-vertical-expected.png: Added.
platform/win/fast/text/emphasis-vertical-expected.txt: Added.

1:29 PM Changeset in webkit [74289] by bweinstein@apple.com

2 edits in trunk/WebKit2

Qt build fix.

UIProcess/qt/WebPopupMenuProxyQt.h:

1:24 PM Changeset in webkit [74288] by commit-queue@webkit.org

2 edits in trunk/WebCore

2010-12-17 Shimeng (Simon) Wang <swang@google.com>

Reviewed by Steve Block.

Fix V8 JNI binding.
https://bugs.webkit.org/show_bug.cgi?id=51156

There're LayoutTests in:
http://trac.webkit.org/browser/trunk/LayoutTests/java/lc3/JSNumber
to exercise these code paths.
Though Chromium don't run them.
Tested on Android fast/events/touch tests.

bridge/jni/v8/JNIUtilityPrivate.cpp: (JSC::Bindings::convertNPVariantToJValue):

1:22 PM Changeset in webkit [74287] by Simon Fraser

3 edits
3 adds in trunk

2010-12-17 Simon Fraser <Simon Fraser>

Reviewed by Chris Marrin.

Interrupted accelerated animation can break later transitions
<rdar://problem/8767714>
https://bugs.webkit.org/show_bug.cgi?id=51264

If we're still waiting for the 'animationDidStart' callback when renderers
get destroyed, then the m_waitingForStartTimeResponse flag could be left
set to 'true', which causes later transitions to never start.

Fix by clearing the m_waitingForStartTimeResponse flag when the m_startTimeResponseWaiters
becomes empty.

Test: transitions/interrupted-accelerated-transition.html

page/animation/AnimationController.cpp: (WebCore::AnimationControllerPrivate::removeFromStartTimeResponseWaitList):

1:22 PM Changeset in webkit [74286] by Simon Fraser

3 edits in trunk/WebCore

2010-12-17 Simon Fraser <Simon Fraser>

Reviewed by Chris Marrin.

Interrupted accelerated animation can break later transitions
https://bugs.webkit.org/show_bug.cgi?id=51264

Step 1: code cleanup.
Rename "responseWait" variables to "startTimeResponseWait", to make it clear
the kind of response that is being waited for.

Make a couple of methods private.

No behavioral changes, so no tests.

page/animation/AnimationController.cpp: (WebCore::AnimationControllerPrivate::AnimationControllerPrivate): (WebCore::AnimationControllerPrivate::endAnimationUpdate): (WebCore::AnimationControllerPrivate::receivedStartTimeResponse): (WebCore::AnimationControllerPrivate::addToStartTimeResponseWaitList): (WebCore::AnimationControllerPrivate::removeFromStartTimeResponseWaitList): (WebCore::AnimationControllerPrivate::startTimeResponse):
page/animation/AnimationControllerPrivate.h:

1:08 PM Changeset in webkit [74285] by bweinstein@apple.com

21 edits in trunk/WebKit2

Text area does not update when you arrow through a <select> in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=51269
<rdar://problem/8612853>

Reviewed by Anders Carlsson.

Patch by Sam Weinig.

Insteaed of keeping track of the selected index of a <select> just in the UI process, we
need to pass this information along to the web process so that the web process can draw
the correct text in the text field at the top of the select, when the selection changes (via
the arrows or other typing while the select is opened).

When the selected item in a popup changes, the UI process sends a message to the web process, telling
it about the new selected index. The web process gets this message, and then sets the text that
is visible in the select element.

UIProcess/API/mac/PageClientImpl.h: CreatePopupMenuProxy now takes a WebPageProxy.
UIProcess/API/mac/PageClientImpl.mm:

(WebKit::PageClientImpl::createPopupMenuProxy): Pass the WebPageProxy to create.

UIProcess/API/qt/qwkpage.cpp:

(QWKPagePrivate::createPopupMenuProxy):

UIProcess/API/qt/qwkpage_p.h: CreatePopupMenuProxy now takes a WebPageProxy.
UIProcess/PageClient.h: CreatePopupMenuProxy now takes a WebPageProxy.
UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::valueChangedForPopupMenu): Send that the selected index changed to the

web process.selected

(WebKit::WebPageProxy::setTextFromItemForPopupMenu): Send that we should update the text for the

active popup menu (with the index of the item to show).

(WebKit::WebPageProxy::showPopupMenu): Pass the WebPageProxy to createPopupMenuProxy.

UIProcess/WebPageProxy.h:
UIProcess/WebPopupMenuProxy.h: Add a client who has virtual functions for the state changing of the

popup menu. ShowPopupMenu doesn't take a new selected index anymore, that is handled by the client,
and calling down to the web process.

(WebKit::WebPopupMenuProxy::Client::~Client):
(WebKit::WebPopupMenuProxy::WebPopupMenuProxy): Initialize the client.

UIProcess/mac/WebPopupMenuProxyMac.h:

(WebKit::WebPopupMenuProxyMac::create): Takes a WebPopupMenuProxy::Client, and passes it to the constructor.

UIProcess/mac/WebPopupMenuProxyMac.mm:

(WebKit::WebPopupMenuProxyMac::WebPopupMenuProxyMac): Update what's initialized by the constructor.
(WebKit::WebPopupMenuProxyMac::showPopupMenu): Call through to the web process that the value changed.

UIProcess/qt/WebPopupMenuProxyQt.cpp:

(WebKit::WebPopupMenuProxyQt::WebPopupMenuProxyQt): Update what's initialized by the constructor.

UIProcess/win/WebPopupMenuProxyWin.cpp:

(WebKit::WebPopupMenuProxyWin::WebPopupMenuProxyWin): Ditto.
(WebKit::WebPopupMenuProxyWin::showPopupMenu): Call through to the web process that the value changed.
(WebKit::WebPopupMenuProxyWin::setFocusedIndex): Resolve a FIXME to set the text of the popup menu.

UIProcess/win/WebPopupMenuProxyWin.h:

(WebKit::WebPopupMenuProxyWin::create): Take in a WebPopupMenuProxy::client, and pass it to the constructor.

UIProcess/win/WebView.cpp:

(WebKit::WebView::createPopupMenuProxy): Pass the WebPageProxy to create.

UIProcess/win/WebView.h:
WebProcess/WebCoreSupport/WebPopupMenu.cpp:

(WebKit::WebPopupMenu::setTextForIndex): Call through to setTextFromItem to set the select text.

WebProcess/WebCoreSupport/WebPopupMenu.h:
WebProcess/WebPage/WebPage.cpp: Call through to setTextForIndex on the active popup menu.

(WebKit::WebPage::setTextForActivePopupMenu):

WebProcess/WebPage/WebPage.h:
WebProcess/WebPage/WebPage.messages.in: Add a new message.

1:06 PM Changeset in webkit [74284] by andersca@apple.com

12 edits in trunk/WebKit2

Add a WebPageProxy parameter to the DrawingAreaProxy constructor
https://bugs.webkit.org/show_bug.cgi?id=51271

Reviewed by Sam Weinig.

UIProcess/API/mac/WKView.mm:

(-[WKView initWithFrame:contextRef:pageGroupRef:]):
(-[WKView _switchToDrawingAreaTypeIfNecessary:DrawingAreaInfo::]):

UIProcess/API/qt/qgraphicswkview.cpp:

(QGraphicsWKView::QGraphicsWKView):

UIProcess/ChunkedUpdateDrawingAreaProxy.cpp:

(WebKit::ChunkedUpdateDrawingAreaProxy::create):
(WebKit::ChunkedUpdateDrawingAreaProxy::ChunkedUpdateDrawingAreaProxy):

UIProcess/ChunkedUpdateDrawingAreaProxy.h:
UIProcess/DrawingAreaProxy.cpp:

(WebKit::DrawingAreaProxy::DrawingAreaProxy):

UIProcess/DrawingAreaProxy.h:
UIProcess/LayerBackedDrawingAreaProxy.cpp:

(WebKit::LayerBackedDrawingAreaProxy::create):
(WebKit::LayerBackedDrawingAreaProxy::LayerBackedDrawingAreaProxy):

UIProcess/LayerBackedDrawingAreaProxy.h:
UIProcess/TiledDrawingAreaProxy.cpp:

(WebKit::TiledDrawingAreaProxy::create):
(WebKit::TiledDrawingAreaProxy::TiledDrawingAreaProxy):

UIProcess/TiledDrawingAreaProxy.h:
UIProcess/win/WebView.cpp:

(WebKit::WebView::WebView):
(WebKit::WebView::switchToDrawingAreaTypeIfNecessary):

11:45 AM Changeset in webkit [74283] by mitz@apple.com

10 edits in trunk/WebKit2

Add API for "Always Use the Complex Text Code Path"
https://bugs.webkit.org/show_bug.cgi?id=51265

Reviewed by Darin Adler.

Shared/WebProcessCreationParameters.cpp:

(WebKit::WebProcessCreationParameters::WebProcessCreationParameters): Initialize shouldAlwaysUseComplexTextCodePath.
(WebKit::WebProcessCreationParameters::encode): Encode shouldAlwaysUseComplexTextCodePath.
(WebKit::WebProcessCreationParameters::decode): Decode shouldAlwaysUseComplexTextCodePath.

Shared/WebProcessCreationParameters.h:
UIProcess/API/C/WKContext.cpp:

(_WKContextSetAlwaysUsesComplexTextCodePath): Added.

UIProcess/API/C/WKContextPrivate.h:
UIProcess/WebContext.cpp:

(WebKit::WebContext::WebContext): Initialize m_alwaysUsesComplexTextCodePath.
(WebKit::WebContext::ensureWebProcess): Set shouldAlwaysUseComplexTextCodePath in the creation parameters.
(WebKit::WebContext::setAlwaysUsesComplexTextCodePath): Added. Sets m_alwaysUsesComplexTextCodePath and
sends a message to the WebProcess.

UIProcess/WebContext.h:
WebProcess/WebProcess.cpp:

(WebKit::WebProcess::initializeWebProcess): Call setAlwaysUsesComplexTextCodePath() based on the creation
parameters.
(WebKit::WebProcess::setAlwaysUsesComplexTextCodePath): Added.

WebProcess/WebProcess.h:
WebProcess/WebProcess.messages.in: Added SetAlwaysUsesComplexTextCodePath.

11:35 AM Changeset in webkit [74282] by weinig@apple.com

7 edits in trunk/WebKit2

WebKit2: Implement a title attribute per frame
https://bugs.webkit.org/show_bug.cgi?id=51266

Reviewed by Darin Adler.

Cache the title of each frame on the WebFrameProxy. Removes
the WebPageProxy's cache of the main frame title to just
access the main frame.

We clear the cached title on new committed loads and on failures
to load.

UIProcess/API/C/WKFrame.cpp:

(WKFrameCopyTitle):

UIProcess/API/C/WKFrame.h:
UIProcess/WebFrameProxy.cpp:

(WebKit::WebFrameProxy::didCommitLoad):
(WebKit::WebFrameProxy::didFailLoad):
(WebKit::WebFrameProxy::didChangeTitle):

UIProcess/WebFrameProxy.h:

(WebKit::WebFrameProxy::title):

UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::close):
(WebKit::WebPageProxy::pageTitle):
(WebKit::WebPageProxy::didReceiveTitleForFrame):
(WebKit::WebPageProxy::processDidCrash):

UIProcess/WebPageProxy.h:

11:31 AM Changeset in webkit [74281] by mitz@apple.com

10 edits
8 adds in trunk

WebCore: Layout and rendering of CSS text-emphasis
Final part of <rdar://problem/7720300> Support the CSS3 text-emphasis property
https://bugs.webkit.org/show_bug.cgi?id=48539

Reviewed by Dave Hyatt.

Tests: fast/text/emphasis-vertical.html

fast/text/emphasis.html

Emphasis marks behave like they are stuck just above the ascender (or just below the
descender). They occupy space in the leading and in padding, and only grow the line space
if they cannot fit.

rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::placeBoxesInBlockDirection): Renamed the containsRuby parameter to
hasAnnotationsBefore, and added hasAnnotationsAfter. Line annotations include ruby and text emphasis
marks.
(WebCore::InlineFlowBox::addTextBoxVisualOverflow): Added overflow from emphasis marks.
(WebCore::InlineFlowBox::computeOverAnnotationAdjustment): Remaned computeBlockDirectionRubyAdjustment()
to this and added adjustment for text emphasis marks.
(WebCore::InlineFlowBox::computeUnderAnnotationAdjustment): Added. Similar to the previous function,
but for annotations under the glyphs. These can only be text emphasis marks.

rendering/InlineFlowBox.h:
rendering/InlineTextBox.cpp:

(WebCore::paintTextWithShadows): Paint emphasis marks.
(WebCore::InlineTextBox::paint): Ditto.

rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::layoutInlineChildren): Generalized the code that adjusts the last line for
ruby in flipped writing mode to also adjust the last line for emphasis marks under the line in non-
flipped writing mode.

rendering/RenderObject.cpp:

(WebCore::RenderObject::selectionColor): Added this helper method which generalizes selectionForegroundColor().
(WebCore::RenderObject::selectionForegroundColor): Moved most of the code to selectionColor().
(WebCore::RenderObject::selectionEmphasisMarkColor): Added.

rendering/RenderObject.h:
rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::RootInlineBox): Updated initialization for new members.
(WebCore::RootInlineBox::alignBoxesInBlockDirection): Update new members.
(WebCore::RootInlineBox::beforeAnnotationsAdjustment): Renamed blockDirectionRubyAdjustment() to this
and extended to deal with annotations over and under the line and the previous line. If both lines have
annotations into the space between the lines, maintain separation so that the annotations do not overlap.

rendering/RootInlineBox.h:

(WebCore::RootInlineBox::hasAnnotationsBefore): Added this accessor.
(WebCore::RootInlineBox::hasAnnotationsAfter): Ditto.

LayoutTests: <rdar://problem/7720300> Support the CSS3 text-emphasis property
https://bugs.webkit.org/show_bug.cgi?id=48539

Reviewed by Dave Hyatt.

fast/text/emphasis-vertical.html: Added.
fast/text/emphasis.html: Added.
platform/mac/fast/text/emphasis-expected.checksum: Added.
platform/mac/fast/text/emphasis-expected.png: Added.
platform/mac/fast/text/emphasis-expected.txt: Added.
platform/mac/fast/text/emphasis-vertical-expected.checksum: Added.
platform/mac/fast/text/emphasis-vertical-expected.png: Added.
platform/mac/fast/text/emphasis-vertical-expected.txt: Added.

11:12 AM Changeset in webkit [74280] by tonikitoo@webkit.org

1 edit
1 add in trunk/LayoutTests

2010-12-17 Antonio Gomes <agomes@rim.com>

Unreviewed fix for Windows bots.

r74270 removed the windows specific result for extend-selection-home-end.html
since it was matching the cross platform expectation result. However, when there is
no win specific test result but there is a mac one for the same test, the later
is picked before the cross platform one.

platform/win/editing/selection/extend-selection-home-end-expected.txt: Added.

10:58 AM Changeset in webkit [74279] by rniwa@webkit.org

2 edits
1 add
4 deletes in trunk/LayoutTests

2010-12-17 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Antonio Gomes.

editing/execCommand/toggle-compound-styles-expected should use LayoutTestController::setEditingBehavior
https://bugs.webkit.org/show_bug.cgi?id=51261

Modified the test to run each test case using each editing behavior, eliminating the need for
platform-specific expected results.

editing/execCommand/script-tests/toggle-compound-styles.js: (testSingleToggle):
platform/gtk/editing/execCommand/toggle-compound-styles-expected.txt: Removed.
platform/mac/editing/execCommand/toggle-compound-styles-expected.txt: Removed.
platform/qt/editing/execCommand/toggle-compound-styles-expected.txt: Removed.
platform/win/editing/execCommand/toggle-compound-styles-expected.txt: Removed.

10:56 AM Changeset in webkit [74278] by commit-queue@webkit.org

3 edits in trunk/WebCore

2010-12-17 W. James MacLean <wjmaclean@chromium.org>

Reviewed by James Robinson.

[chromium] Add support to compositor to composite to offscreen texture.
https://bugs.webkit.org/show_bug.cgi?id=50833

A patch to extend compositor to be able to composite into an offscreen texture instead
of just directly to the display buffer. Builds on RenderSurfaceChromium support.

External behaviour not changed, so no tests.

platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::LayerRendererChromium): (WebCore::LayerRendererChromium::prepareToDrawLayers): (WebCore::LayerRendererChromium::drawLayers): (WebCore::LayerRendererChromium::setCompositeOffscreen): (WebCore::LayerRendererChromium::useRenderSurface): (WebCore::LayerRendererChromium::setScissorToRect):
platform/graphics/chromium/LayerRendererChromium.h: (WebCore::LayerRendererChromium::isCompositingOffscreen): (WebCore::LayerRendererChromium::getOffscreenLayerTexture):

10:37 AM Changeset in webkit [74277] by ojan@chromium.org

2 edits in trunk/BugsSite

2010-12-17 Ojan Vafai <ojan@chromium.org>

Increment psuedo-version number to avoid pulling cached version.

PrettyPatch/PrettyPatch.rb:

10:33 AM Changeset in webkit [74276] by ojan@chromium.org

3 edits in trunk/BugsSite

2010-12-17 Ojan Vafai <ojan@chromium.org>

Speculative fix for the code review tool in Firefox.
Fixes a JS error and makes the status bubble mostly work
if postMessage is not supported.

PrettyPatch/PrettyPatch.rb:
code-review.js:

9:57 AM Changeset in webkit [74275] by Darin Adler

9 edits in trunk/WebKit2

2010-12-16 Darin Adler <Darin Adler>

Reviewed by Maciej Stachowiak.

Add text encoding menu API for WebKit2
https://bugs.webkit.org/show_bug.cgi?id=51226

UIProcess/API/C/WKPage.cpp: (WKPageSupportsTextEncoding): Added. (WKPageCopyCustomTextEncodingName): Added. (WKPageSetCustomTextEncodingName): Added.
UIProcess/API/C/WKPage.h: Added the functions above.

UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::WebPageProxy): Initialize m_mainFrameHasCustomRepresentation to false. (WebKit::WebPageProxy::supportsTextEncoding): Added. (WebKit::WebPageProxy::setCustomTextEncodingName): Added. (WebKit::WebPageProxy::didCommitLoadForFrame): Set m_mainFrameHasCustomRepresentation.

UIProcess/WebPageProxy.h: Added supportsTextEncoding, setCustomTextEncodingName, customTextEncodingName, and m_mainFrameHasCustomRepresentation.

UIProcess/WebPageProxy.messages.in: Tweaked formatting (added a blank line).

WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::setCustomTextEncodingName): Added.
WebProcess/WebPage/WebPage.h: Added setCustomTextEncodingName.

WebProcess/WebPage/WebPage.messages.in: Added the SetCustomTextEncodingName message. Tweaked formatting of the dummy message.

9:37 AM Changeset in webkit [74274] by commit-queue@webkit.org

2 edits in trunk/WebKit/chromium

2010-12-17 John Knottenbelt <jknotten@chromium.org>

Reviewed by Jeremy Orlow.

Fix test failures where NULL GeolocationClient is provided
https://bugs.webkit.org/show_bug.cgi?id=51256

src/GeolocationClientProxy.cpp: (WebKit::GeolocationClientProxy::geolocationDestroyed):

9:12 AM Changeset in webkit [74273] by tonikitoo@webkit.org

2 edits in trunk/LayoutTests

2010-12-17 Antonio Gomes <agomes@rim.com>

Unreviewed expectation result update.

editing/execCommand/toggle-compound-styles.html needs new expected results after r74269.

Default editing behavior of GTK+ DRT was changed from Mac to Unix, and this test is wrongly
going through platform specific editing behavior code path without making calls to
LayoutTestController::setEditingBehavior. Filed bug 51261 for the proper fix.

platform/gtk/editing/execCommand/toggle-compound-styles-expected.txt:

8:43 AM Changeset in webkit [74272] by ariya@webkit.org

2 edits in trunk/WebCore

2010-12-17 Ariya Hidayat <ariya@sencha.com>

Reviewed by Andreas Kling.

[Qt] Default image interpolation should reset the render hint
https://bugs.webkit.org/show_bug.cgi?id=51233

Save initial SmoothPixmapTransform render hint so that it can be used
with default image interpolation quality to reset back the render hints.

platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContextPlatformPrivate::GraphicsContextPlatformPrivate): (WebCore::GraphicsContext::setImageInterpolationQuality):

8:26 AM Changeset in webkit [74271] by ariya@webkit.org

2 edits in trunk/WebKit/qt

2010-12-17 Ariya Hidayat <ariya@sencha.com>

Reviewed by Antonio Gomes.

[Qt] GraphicsContext should respect QWebView render hints
https://bugs.webkit.org/show_bug.cgi?id=51208

Adjust the test since SmoothPixmapTransform is set by default.

tests/qwebview/tst_qwebview.cpp: (tst_QWebView::renderHints):

8:16 AM Changeset in webkit [74270] by tonikitoo@webkit.org

5 edits
2 moves in trunk

2010-12-05 Antonio Gomes <agomes@rim.com>

Reviewed by Ariya Hidayat.

[Qt] Fix caret browsing navigation mode
https://bugs.webkit.org/show_bug.cgi?id=50536

WebKit/qt:

Caret browsing can consume editing commands even when the start
of current selection is not a editable content. r69582 missed this
case because caret browsing feature testing is very poor today.

This commit reintroduces part of the removed code in r69582 but
guarded by a isCaretBrowsingEnabled() check. No regression found.

WebCoreSupport/EditorClientQt.cpp: (WebCore::EditorClientQt::handleKeyboardEvent):

LayoutTests:

/platform/gtk/editing/selection/caret-mode-paragraph-keys-navigation.html
is one of the few tests actually tests the caret browsing feature.
Patch makes the test not Gtk+ specific, and Qt now passes on it.

editing/selection/caret-mode-paragraph-keys-navigation-expected.txt: Renamed from LayoutTests/platform/gtk/editing/selection/caret-mode-paragraph-keys-navigation-expected.tx t.
editing/selection/caret-mode-paragraph-keys-navigation.html: Renamed from LayoutTests/platform/gtk/editing/selection/caret-mode-paragraph-keys-navigation.html.
fast/events/multiline-link-arrow-navigation.html:

8:15 AM Changeset in webkit [74269] by tonikitoo@webkit.org

3 edits
2 deletes in trunk

2010-12-16 Antonio Gomes <agomes@rim.com>

Reviewed by Martin Robinson.

Settings::editingBehaviorType() incorrectly returns mac for the gtk build when running tests
https://bugs.webkit.org/show_bug.cgi?id=51163

WebKitTools:
Since GTK+'s default editing behavior was changed to UNIX in r70975 (see webkitwebsettings.cpp),
GTK+'s DRT should also reset to UNIX after each test execution.

DumpRenderTree/gtk/DumpRenderTree.cpp: (resetDefaultsToConsistentValues):

LayoutTests:
Removed platform specific expected result files for gtk and windows
for editing/selection/extend-selection-home-end.html, since they all match
the cross platform result file.

Note: chromium-win and mac still have their own expected file each.

platform/gtk/editing/selection/extend-selection-home-end-expected.txt: Removed.
platform/win/editing/selection/extend-selection-home-end-expected.txt: Removed.

7:54 AM Changeset in webkit [74268] by commit-queue@webkit.org

2 edits in trunk/WebKit2

2010-12-17 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r74201.
http://trac.webkit.org/changeset/74201
https://bugs.webkit.org/show_bug.cgi?id=51248

It broke ~6000 layout tests (Requested by Ossy_ on #webkit).

UIProcess/API/qt/qgraphicswkview.cpp: (QGraphicsWKView::setGeometry): (QGraphicsWKView::itemChange):

7:48 AM BuildingOnWindows edited by Adam Roben

Update the rebase instructions (diff)

7:11 AM Changeset in webkit [74267] by yurys@chromium.org

2 edits in trunk/LayoutTests

2010-12-17 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Remove custom expectations for fast/js/regexp-ranges-and-escaped-hyphens.html

platform/chromium/test_expectations.txt:

7:10 AM Changeset in webkit [74266] by hans@chromium.org

12 edits in trunk

2010-12-17 Hans Wennborg <hans@chromium.org>

Reviewed by Jeremy Orlow.

IndexedDB: Support Date objects as keys.
https://bugs.webkit.org/show_bug.cgi?id=51193

Update layout tests to check that having Date objects as keys work.

storage/indexeddb/objectstore-basics-expected.txt:
storage/indexeddb/objectstore-basics.html:

2010-12-17 Hans Wennborg <hans@chromium.org>

Reviewed by Jeremy Orlow.

IndexedDB: Support Date objects as keys.
https://bugs.webkit.org/show_bug.cgi?id=51193

bindings/v8/IDBBindingUtilities.cpp: (WebCore::createIDBKeyFromValue): Use the new IDBKey factory functions, and support Date objects.
bindings/v8/custom/V8IDBKeyCustom.cpp: (WebCore::toV8): Create Date objects from DateType keys.
storage/IDBKey.cpp: (WebCore::IDBKey::fromQuery): (WebCore::IDBKey::isEqual): (WebCore::IDBKey::whereSyntax): (WebCore::IDBKey::lowerCursorWhereFragment): (WebCore::IDBKey::upperCursorWhereFragment): (WebCore::IDBKey::bind): (WebCore::IDBKey::bindWithNulls): Update all SQL related functions to handle Date keys.
storage/IDBKey.h: (WebCore::IDBKey::createNull): (WebCore::IDBKey::createNumber): (WebCore::IDBKey::createString): (WebCore::IDBKey::createDate): Rename the create factories; since both number and date is just a double, function overloading can't be used to discriminate between the factories. (WebCore::IDBKey::date): Add getter for the date value.

2010-12-17 Hans Wennborg <hans@chromium.org>

Reviewed by Jeremy Orlow.

IndexedDB: Support Date objects as keys.
https://bugs.webkit.org/show_bug.cgi?id=51193

Update to match the underlying WebCore IDBKey class:
add the DateType, add create() functions for each type,
deprecate the public constructors (will be removed once
Chromium side is updated).

public/WebIDBKey.h: (WebKit::WebIDBKey::WebIDBKey):
src/AssertMatchingEnums.cpp:
src/WebIDBKey.cpp: (WebKit::WebIDBKey::createString): (WebKit::WebIDBKey::createDate): (WebKit::WebIDBKey::createNumber): (WebKit::WebIDBKey::assignNull): (WebKit::WebIDBKey::assignString): (WebKit::WebIDBKey::assignDate): (WebKit::WebIDBKey::assignNumber): (WebKit::WebIDBKey::date):

7:05 AM Changeset in webkit [74265] by pfeldman@chromium.org

2 edits in branches/chromium/597/WebCore/inspector/front-end

Merge 74261 - 2010-12-17 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: add scripts parsed after resource load to SourceFrame.
https://bugs.webkit.org/show_bug.cgi?id=51243

inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype._addScript):
inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype.addScript):

TBR=podivilov@chromium.org
BUG=74261

Review URL: http://codereview.chromium.org/5997002

6:58 AM Changeset in webkit [74264] by pfeldman@chromium.org

2 edits in branches/chromium/597/WebCore/inspector/front-end

Merge 74253 - 2010-12-17 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: [REGRESSION] Cmd (Ctrl) + G does not search next in Scripts panel.
https://bugs.webkit.org/show_bug.cgi?id=50893

Now Mac shortcuts are:

Cmd F/G = find / next
Cmd L = go to line

Win/Linux:

Ctrl+G = go to line

inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype._registerShortcuts):
inspector/front-end/inspector.js: (WebInspector._registerShortcuts):

TBR=pfeldman@chromium.org
BUG=67282

Review URL: http://codereview.chromium.org/6006001

6:55 AM Changeset in webkit [74263] by sergio@webkit.org

2 edits in trunk/LayoutTests

2010-12-17 Sergio Villar Senin <svillar@igalia.com>

Unreviewed, tests were skipped due to a bug in libsoup
https://bugzilla.gnome.org/show_bug.cgi?id=631679. Now that it was
fixed we can safely unskip them again.

[GTK] Failing http/tests/xmlhttprequest tests
https://bugs.webkit.org/show_bug.cgi?id=30582

platform/gtk/Skipped:

6:51 AM Changeset in webkit [74262] by pfeldman@chromium.org

1 edit in branches/chromium/597/WebCore/inspector/front-end/ResourceManager.js

Merge 74259 - 2010-12-17 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: [REGRESSION] scripts in scripts panel are not updated on reload.
https://bugs.webkit.org/show_bug.cgi?id=51101

inspector/front-end/ResourceManager.js: (WebInspector.ResourceTreeModel.prototype.didCommitLoadForFrame):

TBR=podivilov@chromium.org
BUG=67313

Review URL: http://codereview.chromium.org/6005001

6:47 AM Changeset in webkit [74261] by podivilov@chromium.org

3 edits in trunk/WebCore

2010-12-17 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: add scripts parsed after resource load to SourceFrame.
https://bugs.webkit.org/show_bug.cgi?id=51243

inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype._addScript):
inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype.addScript):

6:39 AM Changeset in webkit [74260] by antonm@chromium.org

2 edits in trunk/WebCore

2010-12-17 Anton Muhin <antonm@chromium.org>

Reviewed by Yury Semikhatsky.

[v8] The last portion of CSS GC work: fixing fast/dom/StyleSheet/gc-stylesheet-wrapper.html
https://bugs.webkit.org/show_bug.cgi?id=51121

Properly group style elements of HTML links, style elements and processing instructions.

bindings/v8/V8GCController.cpp: (WebCore::NodeGrouperVisitor::visitDOMWrapper): (WebCore::NodeGrouperVisitor::addDOMObjectToGroup):

6:37 AM Changeset in webkit [74259] by podivilov@chromium.org

2 edits in trunk/WebCore

2010-12-17 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: [REGRESSION] scripts in scripts panel are not updated on reload.
https://bugs.webkit.org/show_bug.cgi?id=51101

inspector/front-end/ResourceManager.js: (WebInspector.ResourceTreeModel.prototype.didCommitLoadForFrame):

6:33 AM Changeset in webkit [74258] by tkent@chromium.org

2 edits in trunk/LayoutTests

2010-12-17 Kent Tamura <tkent@chromium.org>

Unreviewed, test expectation update.

platform/chromium/test_expectations.txt: Collect and correct failures about vertical writing.

6:15 AM Changeset in webkit [74257] by benjamin.poulain@nokia.com

2 edits in trunk/WebCore

2010-12-17 Benjamin Poulain <benjamin.poulain@nokia.com>

Reviewed by Laszlo Gombos.

The inspector does not compile without JAVASCRIPT_DEBUGGER
https://bugs.webkit.org/show_bug.cgi?id=51246

Fix the build, m_extraHeaders does not depend on JAVASCRIPT_DEBUGGER.

inspector/InspectorController.h:

5:52 AM Changeset in webkit [74256] by caseq@chromium.org

2 edits in trunk/WebCore

2010-12-17 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: clear extra/override headers when front-end is closed
https://bugs.webkit.org/show_bug.cgi?id=51244

inspector/InspectorController.cpp: (WebCore::InspectorController::disconnectFrontend): (WebCore::InspectorController::willSendRequest):

5:15 AM Changeset in webkit [74255] by levin@chromium.org

3 edits in trunk/WebKitTools

2010-12-17 David Levin <levin@chromium.org>

Reviewed by Eric Seidel.

check-webkit-style should understand WTF #include guards
https://bugs.webkit.org/show_bug.cgi?id=44911

Scripts/webkitpy/style/checkers/cpp.py: (get_header_guard_cpp_variable): modify to suggest the WTF style of header guard when appropriate. (check_for_header_guard): handle multiple return values from get_header_guard_cpp_variable
Scripts/webkitpy/style/checkers/cpp_unittest.py: (CppStyleTest.test_build_header_guard): Added tests for the WTF header style.

5:07 AM Changeset in webkit [74254] by Csaba Osztrogonác

2 edits in trunk/LayoutTests

Unreviewed.

[Qt] Web Timing related bugs
https://bugs.webkit.org/show_bug.cgi?id=51245

platform/qt/Skipped: http/tests/misc/webtiming-ssl.php added until fix.

4:52 AM Changeset in webkit [74253] by pfeldman@chromium.org

3 edits in trunk/WebCore

2010-12-17 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: [REGRESSION] Cmd (Ctrl) + G does not search next in Scripts panel.
https://bugs.webkit.org/show_bug.cgi?id=50893

Now Mac shortcuts are:

Cmd F/G = find / next
Cmd L = go to line

Win/Linux:

Ctrl+G = go to line

inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype._registerShortcuts):
inspector/front-end/inspector.js: (WebInspector._registerShortcuts):

4:50 AM Changeset in webkit [74252] by yurys@chromium.org

2 edits in trunk/LayoutTests

2010-12-17 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Update Chromium test expectations.

platform/chromium/test_expectations.txt:

4:46 AM Changeset in webkit [74251] by sergio@webkit.org

2 edits in trunk/WebCore

2010-12-16 Sergio Villar Senin <svillar@igalia.com>

Reviewed by Martin Robinson.

Wrong check in ResourceHandleSoup in error cases
https://bugs.webkit.org/show_bug.cgi?id=51171

Calling didReceiveData with no data causes a crash in debug
builds. Checking for soupMsg->response_body->data is not correct as libsoup
always creates a buffer for that. Instead we should check for
soupMsg->response_body->length

platform/network/soup/ResourceHandleSoup.cpp: (WebCore::sendRequestCallback):

4:27 AM Changeset in webkit [74250] by sergio@webkit.org

2 edits in trunk/LayoutTests

2010-12-17 Sergio Villar Senin <svillar@igalia.com>

Unreviewed, skipping a failing test in the bots.

[GTK] fast/dom/global-constructors.html failing on bots
https://bugs.webkit.org/show_bug.cgi?id=51242

platform/gtk/Skipped:

4:19 AM Changeset in webkit [74249] by yurys@chromium.org

2 edits in trunk/LayoutTests

2010-12-17 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Fix typo in Chromium test expectations.

platform/chromium/test_expectations.txt:

4:05 AM Changeset in webkit [74248] by andreas.kling@nokia.com

2 edits in trunk/WebCore

2010-12-17 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Avoid unnecessary calls to GraphicsContextPlatformPrivate::p()
https://bugs.webkit.org/show_bug.cgi?id=49954

platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::pushTransparencyLayerInternal): (WebCore::GraphicsContext::beginTransparencyLayer):

3:24 AM Changeset in webkit [74247] by mrowe@apple.com

20 edits in tags/Safari-534.15

Revert some changes to work around <rdar://problem/8771085>.

3:13 AM Changeset in webkit [74246] by xan@webkit.org

2 edits in trunk/WebCore

2010-12-17 Carlos Garcia Campos <cgarcia@igalia.com>

Reviewed by Martin Robinson.

[GTK] Compile warning introduced in r74129
https://bugs.webkit.org/show_bug.cgi?id=51181

platform/gtk/RenderThemeGtk.cpp: (WebCore::RenderThemeGtk::gtkContainer):

3:05 AM Changeset in webkit [74245] by mrowe@apple.com

5 edits in trunk

Versioning.

3:04 AM Changeset in webkit [74244] by mrowe@apple.com

1 copy in tags/Safari-534.15

New tag.

2:51 AM Changeset in webkit [74243] by commit-queue@webkit.org

4 edits in trunk/WebKit/qt

2010-12-17 Yi Shen <yi.4.shen@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] QWebPage sends out a RequestSoftwareInputPanel event
incorrectly in particular case
https://bugs.webkit.org/show_bug.cgi?id=50419

Add HitTestResult check before firing RequestSoftwareInputPanel event.

Api/qwebpage.cpp: (QWebPagePrivate::mouseReleaseEvent): (QWebPagePrivate::handleSoftwareInputPanel):
Api/qwebpage_p.h:
tests/qwebpage/tst_qwebpage.cpp: (clickOnPage): (tst_QWebPage::inputMethods):

2:37 AM Changeset in webkit [74242] by commit-queue@webkit.org

13 edits
3 adds in trunk

2010-12-17 James Simonsen <simonjam@chromium.org>

Reviewed by Darin Fisher.

[Web Timing] Add sslHandshakeStart to interface

https://bugs.webkit.org/show_bug.cgi?id=50400

fast/dom/Window/window-properties-performance-expected.txt: Added sslHandshakeStart.
fast/dom/script-tests/webtiming.js: Ditto. (checkTimingBeforeLoad): (checkTimingWhileDeferred): (checkWebTimingOnDOMContentLoaded): (checkWebTimingWhileAsync): (checkWebTimingOnLoad): (checkWebTimingAfterLoad):
fast/dom/webtiming-document-open-expected.txt: Ditto.
fast/dom/webtiming-expected.txt: Ditto.
fast/dom/webtiming-navigate-within-document-expected.txt: Ditto.
http/tests/misc/resources/webtiming-ssl.html: Added.
http/tests/misc/webtiming-ssl-expected.txt: Added.
http/tests/misc/webtiming-ssl.php: Added.
platform/gtk/Skipped: WebTiming disabled here.
platform/mac/Skipped: Ditto.
platform/win/Skipped: Ditto.

2010-12-17 James Simonsen <simonjam@chromium.org>

Reviewed by Darin Fisher.

[Web Timing] Add sslHandshakeStart to interface

https://bugs.webkit.org/show_bug.cgi?id=50400

Test: http/tests/misc/webtiming-ssl.php

page/PerformanceTiming.cpp: (WebCore::PerformanceTiming::connectStart): Update comment. (WebCore::PerformanceTiming::connectEnd): Remove SSL time. (WebCore::PerformanceTiming::sslHandshakeStart): Added.
page/PerformanceTiming.h: Added sslHandshakeStart.
page/PerformanceTiming.idl: Ditto.

2:19 AM Changeset in webkit [74241] by commit-queue@webkit.org

8 edits in trunk

2010-12-17 James Simonsen <simonjam@chromium.org>

Reviewed by Darin Fisher.

[Web Timing] Navigation type enums should begin with TYPE_
https://bugs.webkit.org/show_bug.cgi?id=51200

fast/dom/Window/window-properties-performance-expected.txt: Added TYPE_ to navigation types and added TYPE_RESERVED.

2010-12-17 James Simonsen <simonjam@chromium.org>

Reviewed by Darin Fisher.

[Web Timing] Navigation type enums should begin with TYPE_
https://bugs.webkit.org/show_bug.cgi?id=51200

page/PerformanceNavigation.cpp: (WebCore::PerformanceNavigation::type): Added TYPE_ to navigation types.
page/PerformanceNavigation.h: Ditto and added TYPE_RESERVED.
page/PerformanceNavigation.idl: Ditto.

2010-12-17 James Simonsen <simonjam@chromium.org>

Reviewed by Darin Fisher.

[Web Timing] Navigation type enums should begin with TYPE_
https://bugs.webkit.org/show_bug.cgi?id=51200

src/WebPerformance.cpp: (WebKit::WebPerformance::navigationType): Added TYPE_ to navigation types.

2:05 AM Changeset in webkit [74240] by steveblock@google.com

2 edits in trunk/WebCore

Fix build with Geolocation disabled.

1:48 AM Changeset in webkit [74239] by caseq@chromium.org

3 edits in trunk/LayoutTests

2010-12-17 Andrey Kosyakov <caseq@chromium.org>

Unreviewed test fix: removed real user agent from test expectations.

http/tests/inspector/extensions-headers-expected.txt:
http/tests/inspector/extensions-headers.html:

1:17 AM Changeset in webkit [74238] by Patrick Gansterer

2 edits in trunk/WebCore

2010-12-17 Patrick Gansterer <Patrick Gansterer>

Unreviewed. WinCE build fix.

platform/graphics/GraphicsContext.h:

1:13 AM Changeset in webkit [74237] by caseq@chromium.org

3 edits in trunk/LayoutTests

2010-12-17 Andrey Kosyakov <caseq@chromium.org>

Unreviewed. Clean up extra headers set in test to avoid side effects on other tests.

http/tests/inspector/extensions-headers-expected.txt:
http/tests/inspector/extensions-headers.html:

12:29 AM Changeset in webkit [74236] by loislo@chromium.org

5 edits
1 delete in trunk/WebCore

2010-12-17 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: remove unnecessary dependencies from InspectorBackendStub.

InspectorBackendStub is a transport-only thing but it has dependencies with
Callback.js and WebInspector namespace. Callback can be integrated into
InspectorBackendStub because it is the only client.
Without these dependencies InspectorBackendStub can be used as an API
wrapper for Inspector Protocol.

https://bugs.webkit.org/show_bug.cgi?id=51184

WebCore.gypi:
inspector/CodeGeneratorInspector.pm:
inspector/front-end/Callback.js: Removed.
inspector/front-end/WebKit.qrc:
inspector/front-end/inspector.html:

12:23 AM Changeset in webkit [74235] by eric@webkit.org

5 edits
2 moves in trunk

2010-12-17 Eric Seidel <eric@webkit.org>

Unreviewed, rolling out r74229.
http://trac.webkit.org/changeset/74229
https://bugs.webkit.org/show_bug.cgi?id=50536

Broken on Snow Leopard and possibly other platforms

platform/gtk/editing/selection/caret-mode-paragraph-keys-navigation-expected.txt: Renamed from LayoutTests/editing/selection/caret-mode-paragraph-keys-navigation-expected.txt.
platform/gtk/editing/selection/caret-mode-paragraph-keys-navigation.html: Renamed from LayoutTests/editing/selection/caret-mode-paragraph-keys-navigation.html.
platform/mac/Skipped:
platform/win/Skipped:

2010-12-17 Eric Seidel <eric@webkit.org>

Unreviewed, rolling out r74229.
http://trac.webkit.org/changeset/74229
https://bugs.webkit.org/show_bug.cgi?id=50536

Broken on Snow Leopard and possibly other platforms

WebCoreSupport/EditorClientQt.cpp: (WebCore::EditorClientQt::handleKeyboardEvent):

12:22 AM Changeset in webkit [74234] by caseq@chromium.org

17 edits
5 moves
3 adds in trunk

2010-12-15 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: [Extension API] add support for adding/overriding HTTP request headers
https://bugs.webkit.org/show_bug.cgi?id=50493

Test: http/tests/inspector/extensions-headers.html

inspector/Inspector.idl:
inspector/InspectorController.cpp: (WebCore::InspectorController::willSendRequest): Apply extra headers. (WebCore::InspectorController::setExtraHeaders):
inspector/InspectorController.h:
inspector/front-end/ExtensionAPI.js: (WebInspector.injectedExtensionAPI.Resources.prototype.getHAR): (WebInspector.injectedExtensionAPI.Resources.prototype.addRequestHeaders):
inspector/front-end/ExtensionServer.js: (WebInspector.ExtensionServer): (WebInspector.ExtensionServer.prototype._onAddRequestHeaders):

2010-12-15 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: [Extension API] add support for adding/overriding HTTP request headers
Moved extensions test frameworks under http/tests/inspector, so HTTP tests may reuse it.
https://bugs.webkit.org/show_bug.cgi?id=50493

http/tests/inspector/extensions-headers-expected.txt: Added.
http/tests/inspector/extensions-headers.html: Added.
http/tests/inspector/extensions-test.js: Renamed from LayoutTests/inspector/extensions-test.js. (log): (extensionFunctions): (initialize_ExtensionsTest.InspectorTest.dispatchOnMessage): (initialize_ExtensionsTest.InspectorTest.runExtensionTests): (initialize_ExtensionsTest.extensionOutput): (initialize_ExtensionsTest.dumpSidebarContent): (initialize_ExtensionsTest.reloadPage): (test):
http/tests/inspector/resources/echo-headers.php: Added.
http/tests/inspector/resources/extension-main.html: Renamed from LayoutTests/inspector/resources/extension-main.html.
http/tests/inspector/resources/extension-main.js: Renamed from LayoutTests/inspector/resources/extension-main.js. (fetchTests.callback): (fetchTests): (runTests): (onTestsDone): (dispatchOnFrontend.callbackWrapper): (dispatchOnFrontend): (callbackAndNextTest.callbackWrapper): (callbackAndNextTest):
http/tests/inspector/resources/extension-panel.html: Renamed from LayoutTests/inspector/resources/extension-panel.html.
http/tests/inspector/resources/extension-sidebar.html: Renamed from LayoutTests/inspector/resources/extension-sidebar.html.
inspector/extensions-api-expected.txt:
inspector/extensions-api.html:
inspector/extensions-audits-api.html:
inspector/extensions-audits.html:
inspector/extensions-eval.html:
inspector/extensions-events.html:
inspector/extensions-resources-expected.txt:
inspector/extensions-resources.html:
inspector/extensions.html:
platform/chromium/test_expectations.txt:

Dec 16, 2010:

9:46 PM Changeset in webkit [74233] by tkent@chromium.org

11 edits in trunk/LayoutTests

Unreviewed, test expectation update.

Update Chromium-Linux results changed by r74232.
https://bugs.webkit.org/show_bug.cgi?id=50365

platform/chromium-linux/fast/blockflow/japanese-rl-text-with-broken-font-expected.checksum:
platform/chromium-linux/fast/blockflow/japanese-rl-text-with-broken-font-expected.png:
platform/chromium-linux/fast/blockflow/japanese-ruby-vertical-lr-expected.checksum:
platform/chromium-linux/fast/blockflow/japanese-ruby-vertical-lr-expected.png:
platform/chromium-linux/fast/blockflow/japanese-ruby-vertical-rl-expected.checksum:
platform/chromium-linux/fast/blockflow/japanese-ruby-vertical-rl-expected.png:
platform/chromium-linux/fast/blockflow/vertical-align-table-baseline-expected.checksum:
platform/chromium-linux/fast/blockflow/vertical-align-table-baseline-expected.png:
platform/chromium-linux/fast/blockflow/vertical-baseline-alignment-expected.checksum:
platform/chromium-linux/fast/blockflow/vertical-baseline-alignment-expected.png:

9:19 PM Changeset in webkit [74232] by tkent@chromium.org

8 edits in trunk/WebCore

2010-12-16 Koan-Sin Tan <koansin.tan@gmail.com>

Reviewed by Kent Tamura.

Glyphs in vertical text tests are rotated 90 degrees clockwise on Chromium Linux
https://bugs.webkit.org/show_bug.cgi?id=50365

No new tests. But this makes Chromimium Linux show
fast/blockflow/japanese-*-text.html and other vertical
writing text correctly as on WebKit and Chromimum for Mac.

platform/graphics/chromium/FontCacheLinux.cpp: (WebCore::FontCache::createFontPlatformData):
platform/graphics/chromium/FontLinux.cpp: (WebCore::Font::drawGlyphs):
platform/graphics/chromium/FontPlatformDataLinux.cpp: (WebCore::FontPlatformData::FontPlatformData): (WebCore::FontPlatformData::operator=): (WebCore::FontPlatformData::operator==): (WebCore::FontPlatformData::hash):
platform/graphics/chromium/FontPlatformDataLinux.h: (WebCore::FontPlatformData::FontPlatformData): (WebCore::FontPlatformData::orientation):
platform/graphics/chromium/SimpleFontDataLinux.cpp: (WebCore::SimpleFontData::platformInit):
platform/graphics/skia/FontCustomPlatformData.cpp: (WebCore::FontCustomPlatformData::fontPlatformData):
platform/graphics/skia/GlyphPageTreeNodeSkia.cpp: (WebCore::substituteWithVerticalGlyphs): (WebCore::GlyphPage::fill):

9:06 PM Changeset in webkit [74231] by tkent@chromium.org

2 edits in trunk/LayoutTests

2010-12-16 Kent Tamura <tkent@chromium.org>

Unreviewed, test expectation update.

platform/chromium/test_expectations.txt: Remove SLOW for fail-on-update-2.html.

7:51 PM Changeset in webkit [74230] by commit-queue@webkit.org

4 edits in trunk/LayoutTests

2010-12-16 Benjamin Kalman <kalman@chromium.org>

Reviewed by Ojan Vafai.

Update BUG comment in test expectations files
https://bugs.webkit.org/show_bug.cgi?id=51216

Change the BUG[0-9]+ description to BUG(CR|WK|V8_)[0-9]+ where necessary.

platform/chromium/test_expectations.txt:
platform/mac/test_expectations.txt:
platform/qt/test_expectations.txt:

7:36 PM Changeset in webkit [74229] by tonikitoo@webkit.org

5 edits
2 moves in trunk

2010-12-05 Antonio Gomes <agomes@rim.com>

Reviewed by Ariya Hidayat.

[Qt] Fix caret browsing navigation mode
https://bugs.webkit.org/show_bug.cgi?id=50536

WebKit/qt:

Caret browsing can consume editing commands even when the start
of current selection is not a editable content. r69582 missed this
case because caret browsing feature testing is very poor today.

This commit reintroduces part of the removed code in r69582 but
guarded by a isCaretBrowsingEnabled() check. No regression found.

WebCoreSupport/EditorClientQt.cpp: (WebCore::EditorClientQt::handleKeyboardEvent):

LayoutTests:

/platform/gtk/editing/selection/caret-mode-paragraph-keys-navigation.html
is one of the few tests actually tests the caret browsing feature.
Patch makes the test not Gtk+ specific, and Qt now passes on it.

editing/selection/caret-mode-paragraph-keys-navigation-expected.txt: Renamed from LayoutTests/platform/gtk/editing/selection/caret-mode-paragraph-keys-navigation-expected.tx t.
editing/selection/caret-mode-paragraph-keys-navigation.html: Renamed from LayoutTests/platform/gtk/editing/selection/caret-mode-paragraph-keys-navigation.html.
fast/events/multiline-link-arrow-navigation.html:

7:28 PM Changeset in webkit [74228] by commit-queue@webkit.org

5 edits in trunk/WebCore

2010-12-16 Yi Shen <yi.4.shen@nokia.com>, Tor Arne Vestbo <tor.arne.vestbo@nokia.com>

Reviewed by Eric Carlson.

Provide an interface to require using fullscreen mediaplayer
https://bugs.webkit.org/show_bug.cgi?id=51133

Add ChromeClient::requiresFullscreenForVideoPlayback to require webkit
to launch fullscreen video player for playing the html5 video. The
idea is that a browser vendor can specify this behavior through the
platform plugin or something else by using this interface.

No new tests because no client implements requiresFullscreenForVideoPlayback yet.

html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::updatePlayState): (WebCore::HTMLMediaElement::exitFullscreen):
page/Chrome.cpp: (WebCore::Chrome::requiresFullscreenForVideoPlayback):
page/Chrome.h:
page/ChromeClient.h: (WebCore::ChromeClient::requiresFullscreenForVideoPlayback):

7:05 PM Changeset in webkit [74227] by levin@chromium.org

2 edits in trunk/WebKitTools

2010-12-16 David Levin <levin@chromium.org>

Reviewed by Eric Seidel.

test-webkitpy: unittest for the xml.py checker displays a decprecation warning.
https://bugs.webkit.org/show_bug.cgi?id=51210

The error only shows up when using python 2.6 or later.

Scripts/webkitpy/style/checkers/xml.py: Replace the usage of the decprecated field error,message with something equivalent.

6:47 PM Changeset in webkit [74226] by steveblock@google.com

5 edits in trunk/WebCore

2010-12-16 Steve Block <steveblock@google.com>

Reviewed by Steve Block.

GeolocationPositionCache needs refactoring
https://bugs.webkit.org/show_bug.cgi?id=50826

No new tests, refactoring only.

page/Geolocation.cpp: (WebCore::Geolocation::Geolocation): (WebCore::Geolocation::makeCachedPositionCallbacks): (WebCore::Geolocation::haveSuitableCachedPosition): (WebCore::Geolocation::positionChangedInternal):
page/Geolocation.h:
page/GeolocationPositionCache.cpp: (WebCore::GeolocationPositionCache::instance): (WebCore::GeolocationPositionCache::GeolocationPositionCache): (WebCore::GeolocationPositionCache::addUser): (WebCore::GeolocationPositionCache::removeUser): (WebCore::GeolocationPositionCache::setDatabasePath): (WebCore::GeolocationPositionCache::setCachedPosition): (WebCore::GeolocationPositionCache::cachedPosition): (WebCore::GeolocationPositionCache::readFromDatabase): (WebCore::GeolocationPositionCache::writeToDatabase):
page/GeolocationPositionCache.h: (WebCore::GeolocationPositionCacheWrapper::GeolocationPositionCacheWrapper): (WebCore::GeolocationPositionCacheWrapper::~GeolocationPositionCacheWrapper): (WebCore::GeolocationPositionCacheWrapper::setCachedPosition): (WebCore::GeolocationPositionCacheWrapper::cachedPosition):

6:28 PM Changeset in webkit [74225] by commit-queue@webkit.org

4 edits in trunk/LayoutTests

2010-12-16 Yong Li <yoli@rim.com>

Reviewed by Alexey Proskuryakov.

https://bugs.webkit.org/show_bug.cgi?id=51199
Add decoding tests for UTF-16 LE/BE and their variants.
Also, check the full decoded text but not only the first one.

fast/encoding/char-decoding.html:
fast/encoding/char-decoding-expected.txt:
fast/encoding/resources/char-decoding-utils.js:

6:20 PM Changeset in webkit [74224] by weinig@apple.com

18 edits in trunk/WebKit2

Add svn:eol-style native to the message.in files as a favor to Darin Adler.

Reviewed by Darin Adler.

PluginProcess/PluginControllerProxy.messages.in: Added property svn:eol-style.
PluginProcess/PluginProcess.messages.in: Added property svn:eol-style.
PluginProcess/WebProcessConnection.messages.in: Added property svn:eol-style.
Shared/Plugins/NPObjectMessageReceiver.messages.in: Added property svn:eol-style.
UIProcess/Downloads/DownloadProxy.messages.in: Added property svn:eol-style.
UIProcess/Plugins/PluginProcessProxy.messages.in: Added property svn:eol-style.
UIProcess/WebContext.messages.in: Added property svn:eol-style.
UIProcess/WebDatabaseManagerProxy.messages.in: Added property svn:eol-style.
UIProcess/WebInspectorProxy.messages.in: Added property svn:eol-style.
UIProcess/WebPageProxy.messages.in: Added property svn:eol-style.
UIProcess/WebProcessProxy.messages.in: Added property svn:eol-style.
WebProcess/Authentication/AuthenticationManager.messages.in: Added property svn:eol-style.
WebProcess/Plugins/PluginProxy.messages.in: Added property svn:eol-style.
WebProcess/WebCoreSupport/WebDatabaseManager.messages.in: Added property svn:eol-style.
WebProcess/WebPage/WebInspector.messages.in: Added property svn:eol-style.
WebProcess/WebPage/WebPage.messages.in: Added property svn:eol-style.
WebProcess/WebProcess.messages.in: Added property svn:eol-style.

6:13 PM Changeset in webkit [74223] by mihaip@chromium.org

4 edits in trunk/WebKitTools

2010-12-16 Mihai Parparita <mihaip@chromium.org>

Reviewed by Eric Seidel.

Add --exit-after-n-failures/crashes to NRWT
https://bugs.webkit.org/show_bug.cgi?id=51160

Abort test run (in a similar way to how control-C is handled) when
--exit-after-n-failures/crashes-or-timeouts are passed and we've reached
that number of unexpected failures/crashes/timeouts.

Scripts/webkitpy/layout_tests/port/test.py:
Scripts/webkitpy/layout_tests/run_webkit_tests.py:
Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:

5:56 PM Changeset in webkit [74222] by jianli@chromium.org

2 edits in trunk/LayoutTests

Unreviewed. Updated chromium test expectations to mark
http/tests/appcache/fail-on-update-2.html as flaky with TIMEOUT.

platform/chromium/test_expectations.txt:

5:52 PM Changeset in webkit [74221] by evan@chromium.org

2 edits in trunk/JavaScriptCore

2010-12-16 Evan Martin <evan@chromium.org>

Reviewed by Darin Fisher.

[chromium] useless warnings when building on Windows
https://bugs.webkit.org/show_bug.cgi?id=50985

Disable some compiler warnings that aren't indicative of real problems.

JavaScriptCore.gyp/JavaScriptCore.gyp:

5:44 PM Changeset in webkit [74220] by ariya@webkit.org

6 edits in trunk

2010-12-16 Ariya Hidayat <ariya@sencha.com>

Reviewed by Andreas Kling.

[Qt] GraphicsContext should respect QWebView render hints
https://bugs.webkit.org/show_bug.cgi?id=51208

GraphicsContext does not override SmoothPixmapTransform (see also
r62762). To keep the same behavior, canvas default image interpolation
quality is set to medium and QWebView's render hints by default also
include SmoothPixmapTransform.

html/HTMLCanvasElement.h:
platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContextPlatformPrivate::GraphicsContextPlatformPrivate):

2010-12-16 Ariya Hidayat <ariya@sencha.com>

Reviewed by Andreas Kling.

[Qt] GraphicsContext should respect QWebView render hints
https://bugs.webkit.org/show_bug.cgi?id=51208

Add some checks to ensure that GraphicsContext (via QWebFrame)
does not clobber the render hints.

Api/qwebview.cpp: (QWebViewPrivate::QWebViewPrivate):
tests/qwebframe/tst_qwebframe.cpp:

4:29 PM Changeset in webkit [74219] by weinig@apple.com

9 edits in trunk/WebKit2

Move NSURLCache initialization from the ProcessLauncherMac to the centralized
WebContext initialize WebProcess mechanism.

Reviewed by Anders Carlsson.

Shared/WebProcessCreationParameters.cpp:

(WebKit::WebProcessCreationParameters::WebProcessCreationParameters):
(WebKit::WebProcessCreationParameters::encode):
(WebKit::WebProcessCreationParameters::decode):

Shared/WebProcessCreationParameters.h:
UIProcess/Launcher/mac/ProcessLauncherMac.mm:

(WebKit::ProcessLauncher::launchProcess):

UIProcess/mac/WebContextMac.mm:

(WebKit::WebContext::platformInitializeWebProcess):

WebProcess/WebProcess.cpp:

(WebKit::WebProcess::initializeWebProcess):

WebProcess/mac/WebProcessMac.mm:

(WebKit::WebProcess::platformInitializeWebProcess):

WebProcess/mac/WebProcessMainMac.mm:

(WebKit::WebProcessMain):

WebProcess/win/WebProcessWin.cpp:

(WebKit::WebProcess::platformInitializeWebProcess):
(WebKit::WebProcess::setShouldPaintNativeControls):

3:26 PM Changeset in webkit [74218] by dbates@webkit.org

2 edits in trunk/WebCore

2010-12-16 Daniel Bates <dbates@rim.com>

Formatting fix; un-indent one level all lines in [2793, 2808] (with respect to r74217)
so as to be consistent with the formatting of the rest of this file.

Also, add an empty line between the win32* and wince* conditional include blocks.

WebCore.pro:

3:17 PM Changeset in webkit [74217] by dbates@webkit.org

2 edits in trunk/WebCore

2010-12-16 Daniel Bates <dbates@rim.com>

Reviewed by Antonio Gomes.

[Qt] Only include ScrollAnimatorWin.h and compile ScrollAnimatorWin.cpp
on Windows if ENABLE_SMOOTH_SCROLLING=1
https://bugs.webkit.org/show_bug.cgi?id=51215

Conditionally include the files ScrollAnimatorWin.h and ScrollAnimatorWin.cpp when building
the Qt Windows with smooth scrolling enabled.

No change in functionality since these files are guarded by ENABLE(SMOOTH_SCROLLING).

WebCore.pro:

3:12 PM Changeset in webkit [74216] by rniwa@webkit.org

2 edits in trunk/WebKit/mac

2010-12-16 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Cameron Zwarich.

REGRESSION(r74172): 125 java tests fail on Mac
https://bugs.webkit.org/show_bug.cgi?id=51214

The regression was caused by an incorrectly adding sizeof(struct fat_header)
to a pointer for uint32_t as supposed to uint8_t.

Fixed the bug by explicitly casting it to uint8_t* before the addition.

Plugins/WebBasePluginPackage.mm: (-[WebBasePluginPackage isNativeLibraryData:]):

2:21 PM Changeset in webkit [74215] by xan@webkit.org

2 edits in trunk/LayoutTests

2010-12-16 Xan Lopez <xlopez@igalia.com>

[GTK] fast/dom/gc-11.html fails in 64bit debug bot
https://bugs.webkit.org/show_bug.cgi?id=51213

platform/gtk/Skipped:

2:08 PM Changeset in webkit [74214] by rniwa@webkit.org

3 edits
2 adds in trunk

2010-12-16 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Darin Adler.

execCommand('JustifyCenter') adds extra BR
https://bugs.webkit.org/show_bug.cgi?id=51082

The bug was caused by moveParagraphContentsToNewBlockIfNecessary's adding a placeholder br
to new block and not removing it later. Fixed the bug by removing it when the paragraph
moved into the block didn't have a br at the end.

Test: editing/execCommand/justify.html

editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::moveParagraphContentsToNewBlockIfNecessary):

2010-12-16 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Darin Adler.

execCommand('JustifyCenter') adds extra BR
https://bugs.webkit.org/show_bug.cgi?id=51082

Added a test to ensure WebKit executes Justify* properly. In particular,
this test ensures WebKit does not erroneously add a BR at the end of each block.

editing/execCommand/justify-expected.txt: Added.
editing/execCommand/justify.html: Added.

2:06 PM Changeset in webkit [74213] by jianli@chromium.org

2 edits in trunk/LayoutTests

Unreviewed. Updated chromium test expectations.

platform/chromium/test_expectations.txt:

1:52 PM Changeset in webkit [74212] by mihaip@chromium.org

2 edits in trunk/LayoutTests

2010-12-16 Mihai Parparita <mihaip@chromium.org>

Unreviewed. Remove Chromium platform/chromium/accessibility
expectations, that directory doesn't exist anymore as of r74039.

platform/chromium/test_expectations.txt:

1:45 PM Changeset in webkit [74211] by commit-queue@webkit.org

9 edits
1 add in trunk/LayoutTests

2010-12-16 Cosmin Truta <ctruta@chromium.org>

Reviewed by Adam Roben.

More rebaselining needed for new-run-webkit-tests update
https://bugs.webkit.org/show_bug.cgi?id=51147

Some cases were missed while rebaselining in bug 51018.

platform/chromium-mac/editing/execCommand/outdent-blockquote-test2-expected.txt:
platform/chromium-mac/editing/pasteboard/copy-standalone-image-expected.txt:
platform/chromium-mac/http/tests/misc/authentication-sent-to-redirect-expected.txt:
platform/chromium-mac/http/tests/security/cross-frame-access-get-override-expected.txt:
platform/chromium-mac/svg/custom/use-invalid-style-expected.txt:
platform/chromium-win/http/tests/misc/authentication-sent-to-redirect-expected.txt:
platform/chromium-win/platform/win/plugins/get-value-netscape-window-expected.txt:
platform/chromium/plugins/document-open-expected.txt: Added.
plugins/document-open-expected.txt: Rolled out change from r74097.

1:37 PM XBL2UseCases edited by Dimitri Glazkov

(diff)

1:36 PM Changeset in webkit [74210] by ggaren@apple.com

2 edits in trunk/JavaScriptCore

https://bugs.webkit.org/show_bug.cgi?id=51166
ExecutableAllocator::cacheFlush should call sys_cache_control

Patch by Pratik Solanki <psolanki@apple.com> on 2010-12-16
Reviewed by Geoffrey Garen.

jit/ExecutableAllocator.h:

(JSC::ExecutableAllocator::cacheFlush): Use the more correct and forward looking API -
sys_cache_control(kCacheFunctionPrepareForExecution,...).

1:36 PM XBL2UseCases edited by Dimitri Glazkov

(diff)

1:21 PM XBL2UseCases edited by Dimitri Glazkov

(diff)

1:11 PM Changeset in webkit [74209] by andersca@apple.com

4 edits in trunk/WebKit2

2010-12-16 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein.

Defer getting a PluginProcessConnection object until the plug-in is initialized
https://bugs.webkit.org/show_bug.cgi?id=51207
<rdar://problem/8731306>

Before this change, we would pass the PluginProcessConnection to the PluginProxy constructor, but not
call PluginProcessConnection::addPluginProxy (which associates the plug-in proxy with the connection)
until the plug-in is initialized.

This could lead to a PluginProxy holding a reference to a PluginProcessConnection when the PluginProxyConnection
itself did not know anything about the PluginProxy. This would happen when a page with plug-ins is opened in a background
tab, with the plug-ins not yet initialized.

Because of this, we could end up in a weird state, where the PluginProcessConnection would think that there are no
more plug-ins alive, and invalidate (and null out) the underlying CoreIPC connection, which would lead to crashes
when trying to send messages to the connection during later initialization.

The fix is to pass the plug-in path to the PluginProxy constructor, and get the connection from PluginProxy::initialize.

PluginProcessConnection object

WebProcess/Plugins/PluginProxy.cpp: (WebKit::PluginProxy::create): (WebKit::PluginProxy::PluginProxy): (WebKit::PluginProxy::initialize):
WebProcess/Plugins/PluginProxy.h:
WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::createPlugin):

1:10 PM QtWebKitFeatures22 created by Ademar Reis

1:08 PM Changeset in webkit [74208] by jianli@chromium.org

2 edits in trunk/WebCore

Unreviewed. Fixed chromium build break caused by r74207.

platform/ContextMenuItem.h:

1:02 PM QtWebKitRelease22 edited by Ademar Reis

(diff)

12:30 PM Changeset in webkit [74207] by leandro@webkit.org

12 edits
2 deletes in trunk

2010-12-16 Leandro Pereira <leandro@profusion.mobi>

[EFL] Unreviewed build fix.

Disable ContextMenu support for now while support for
CROSS_PLATFORM_MENUS is written.

CMakeListsEfl.txt:
WebCoreSupport/ContextMenuClientEfl.cpp: Removed.
WebCoreSupport/ContextMenuClientEfl.h: Removed.
ewk/ewk_contextmenu.cpp: (ewk_context_menu_item_append):
ewk/ewk_view.cpp: (_ewk_view_priv_new):

2010-12-16 Leandro Pereira <leandro@profusion.mobi>

[EFL] Unreviewed build fix.

Disable ContextMenu support for now while support for
CROSS_PLATFORM_MENUS is written.

CMakeListsEfl.txt:
platform/ContextMenu.h:
platform/ContextMenuItem.h:
platform/efl/ContextMenuEfl.cpp: (WebCore::ContextMenu::ContextMenu): (WebCore::ContextMenu::getContextMenuItems): (WebCore::ContextMenu::createNativeMenuFromItems): (WebCore::ContextMenu::nativeMenu):
platform/efl/ContextMenuItemEfl.cpp: (WebCore::ContextMenuItem::ContextMenuItem): (WebCore::ContextMenuItem::~ContextMenuItem): (WebCore::ContextMenuItem::nativeMenuItem): (WebCore::ContextMenuItem::type): (WebCore::ContextMenuItem::setAction): (WebCore::ContextMenuItem::action): (WebCore::ContextMenuItem::setChecked): (WebCore::ContextMenuItem::checked): (WebCore::ContextMenuItem::setEnabled): (WebCore::ContextMenuItem::enabled): (WebCore::ContextMenuItem::setSubMenu):

2010-12-16 Leandro Pereira <leandro@profusion.mobi>

[EFL] Unreviewed build fix.

Disable ContextMenu support for now while support for
CROSS_PLATFORM_MENUS is written.

cmake/OptionsEfl.cmake:

12:18 PM Changeset in webkit [74206] by enrica@apple.com

2 edits in trunk/WebKit2

WebKit2: Cannot copy two successive selections using cmd-c
<rdar://problem/8680309>
https://bugs.webkit.org/show_bug.cgi?id=51203

Reviewed by Maciej Stachowiak.

The previous implementation assumed a call sequence from AppKit that
was not always happening.
When the user clicks on the pulldown menu, AppKit sends validateUserInterfaceItem
calls for each element that needs validation and we used to count the number of
validation requests being sent to the web process.
All these calls are made before we have the chance to get one reply from the WebProcess.
We also delayed the menu update until we had received all the replies to the validation requests.
At that point we called update on the menu to trigger the validation one more time with
the data retrived from the WebProcess.
When the user simply presses cmd-c, only one call to vaidateUserInterfaceItem is made
and the menu update triggered the validation of all the menu entries causing the internal
state to be out of sync.
The new implementation is very simple: for each validation request from AppKit we send
a request to the WebProcess and we cache a reference to the menu item being validated.
When the WebProcess replies, we retrieve the menu item from our cache and update its state.

UIProcess/API/mac/WKView.mm:

(-[WKView initWithFrame:contextRef:pageGroupRef:]): Removed initialization of deleted memebers.
(-[WKView validateUserInterfaceItem:]): Request validation to the WebProcess and return YES to
allow AppKit to do the keyBinding processing.
(-[WKView _setUserInterfaceItemState:enabled:state:]): Called when the WebProcess replies to the
validation request to check/uncheck and enable/disable the menu item.

12:07 PM Changeset in webkit [74205] by andersca@apple.com

2 edits in trunk/WebKit2

Don't try to call plug-in member functions if the plug-in hasn't been initialized
https://bugs.webkit.org/show_bug.cgi?id=51205
<rdar://problem/8730204>

Reviewed by Oliver Hunt.

Make sure that all PluginView functions that can be called while a plug-in has not been
initialized (if the plug-in page is in a background tab for example) have an additional
check for m_isInitialized.

WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::setWindowIsFocused):
(WebKit::PluginView::windowAndViewFramesChanged):
(WebKit::PluginView::platformLayer):
(WebKit::PluginView::scriptObject):
(WebKit::PluginView::privateBrowsingStateChanged):
(WebKit::PluginView::handleEvent):
(WebKit::PluginView::viewGeometryDidChange):
(WebKit::PluginView::setFocus):

12:01 PM Changeset in webkit [74204] by rniwa@webkit.org

3 edits
2 adds in trunk

2010-12-16 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Darin Adler.

execCommand('styleWithCSS') is ignored when selection isn't inside a contenteditable area
https://bugs.webkit.org/show_bug.cgi?id=51164

Fixed the bug by always enabling the StyleWithCSS command.

Test: editing/style/stylewithcss-without-selection.html

editing/EditorCommand.cpp: (WebCore::createCommandMap): StyleWithCSS is enabled rather than enabledInRichlyEditableText.

2010-12-16 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Darin Adler.

execCommand('styleWithCSS') is ignored when selection isn't inside a contenteditable area
https://bugs.webkit.org/show_bug.cgi?id=51164

Added a test to ensure WebKit accepts StyleWithCSS command even if the current selection
isn't inside a contenteditable region.

editing/style/stylewithcss-without-selection-expected.txt: Added.
editing/style/stylewithcss-without-selection.html: Added.

11:45 AM Changeset in webkit [74203] by andersca@apple.com

2 edits in trunk/WebKit2

Add a bunch of m_isStarted assertions to plug-in code.

Reviewed by John Sullivan.

WebProcess/Plugins/Netscape/NetscapePlugin.cpp:

(WebKit::NetscapePlugin::frameDidFinishLoading):
(WebKit::NetscapePlugin::frameDidFail):
(WebKit::NetscapePlugin::didEvaluateJavaScript):
(WebKit::NetscapePlugin::streamDidReceiveResponse):
(WebKit::NetscapePlugin::streamDidReceiveData):
(WebKit::NetscapePlugin::streamDidFinishLoading):
(WebKit::NetscapePlugin::streamDidFail):
(WebKit::NetscapePlugin::manualStreamDidReceiveResponse):
(WebKit::NetscapePlugin::manualStreamDidReceiveData):
(WebKit::NetscapePlugin::manualStreamDidFinishLoading):
(WebKit::NetscapePlugin::manualStreamDidFail):
(WebKit::NetscapePlugin::handleMouseEvent):
(WebKit::NetscapePlugin::handleWheelEvent):
(WebKit::NetscapePlugin::handleMouseEnterEvent):
(WebKit::NetscapePlugin::handleMouseLeaveEvent):
(WebKit::NetscapePlugin::handleKeyboardEvent):
(WebKit::NetscapePlugin::setFocus):
(WebKit::NetscapePlugin::pluginScriptableNPObject):
(WebKit::NetscapePlugin::privateBrowsingStateChanged):

11:37 AM Changeset in webkit [74202] by andersca@apple.com

5 edits in trunk

Save the manual plug-in stream data and redeliver it when the plug-in is initialized
https://bugs.webkit.org/show_bug.cgi?id=51201

Reviewed by Darin Adler.

WebCore:

Export SharedBuffer related symbols.

WebCore.exp.in:

WebKit2:

WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::PluginView):
Initialize m_manualStreamState.

(WebKit::PluginView::manualLoadDidReceiveResponse):
If the plug-in hasn't been initialized, store the response.

(WebKit::PluginView::manualLoadDidReceiveData):
If the plug-in hasn't been initialized, store the data.

(WebKit::PluginView::manualLoadDidFinishLoading):
If the plug-in hasn't been initialized, update the state.

(WebKit::PluginView::manualLoadDidFail):
If the plug-in hasn't been initialized, store the error and update the state.

(WebKit::PluginView::initializePlugin):
Call redeliverManualStream.

(WebKit::PluginView::redeliverManualStream):
Redeliver the manual stream to the plug-in.

WebProcess/Plugins/PluginView.h:

10:56 AM Changeset in webkit [74201] by andreas.kling@nokia.com

2 edits in trunk/WebKit2

2010-12-16 Kimmo Kinnunen <kimmo.t.kinnunen@nokia.com>

Reviewed by Andreas Kling.

[Qt] Turn off drawing area updates if the item is not visible

The updates are controlled by the QGraphicsItem::visible property.

UIProcess/API/qt/qgraphicswkview.cpp: (QGraphicsWKViewPrivate::updateViewportSize): (QGraphicsWKView::setGeometry): (QGraphicsWKView::itemChange):

10:45 AM Changeset in webkit [74200] by levin@chromium.org

3 edits in trunk/WebKitTools

2010-12-16 David Levin <levin@chromium.org>

Reviewed by Shinichiro Hamaji.

check-webkit-style unit tests has some duplicate boilerplate code.
https://bugs.webkit.org/show_bug.cgi?id=49519

Scripts/webkitpy/style/checkers/cpp.py: (update_include_state): Replaced the "io" parameter with the global configuration _unit_test_config. This allowed not calling into functions at a low level and also not plumbing through the injection information through many levels of code. (check_for_include_what_you_use): Ditto. (process_file_data): Added the ability to set up the unit test config to allow for injection.
Scripts/webkitpy/style/checkers/cpp_unittest.py: (ErrorCollector.init): Added support for having a filter for errors. (ErrorCollector.call): Ditto. (CppStyleTestBase.process_file_data): Added the ability to set unit_test_config. (CppStyleTestBase.perform_lint): Consolidated logic for the perform functions. (CppStyleTestBase.perform_single_line_lint): Replace specific calls to functions in the cpp.py with generic processing and a filter that indicates what errors should be kept. (CppStyleTestBase.perform_multi_line_lint): Ditto. (CppStyleTestBase.perform_language_rules_check): Ditto. (CppStyleTestBase.perform_function_lengths_check): Ditto. (CppStyleTestBase.perform_pass_ptr_check): Ditto. (CppStyleTestBase.perform_include_what_you_use): Ditto. (CppStyleTest.test_multi_line_comments): Added another error message which applies to the test case. (CppStyleTest.test_spacing_for_binary_ops): Fixed test to not have config.h, since it is processed as a header file. (CppStyleTest.test_static_or_global_stlstrings): Fixed variable name style and indentation in checked code. (OrderOfIncludesTest.test_check_preprocessor_in_include_section): Fixed line number. (NoNonVirtualDestructorsTest.test_multi_line_declaration_with_error): Ditto.

10:06 AM Changeset in webkit [74199] by ap@apple.com

1 edit in trunk/WebCore/ChangeLog

Correcting Radar number.

10:01 AM Changeset in webkit [74198] by pfeldman@chromium.org

4 edits in trunk/WebCore

2010-12-16 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: timeline records should only operate WebCore time.
https://bugs.webkit.org/show_bug.cgi?id=51127

inspector/InspectorTimelineAgent.cpp: (WebCore::InspectorTimelineAgent::didFinishLoadingResource):
inspector/TimelineRecordFactory.cpp: (WebCore::TimelineRecordFactory::createResourceFinishData):
inspector/TimelineRecordFactory.h:

9:54 AM Changeset in webkit [74197] by ap@apple.com

2 edits in trunk/WebCore

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=50996
<rdar://problem/8086718> Consider disabling DNS prefetch when proxy is used

No new tests, cannot test DNS.

platform/network/cf/DNSCFNet.cpp: (WebCore::proxyIsEnabledInSystemPreferences): Check if accessing example.com is going to use a proxy. This is only an estimate - even with a proxy is configured in system preferences, an actual request can go directly to the host if a PAC script says so. (WebCore::DNSResolveQueue::add): Check if proxy is enabled when sending immediate requests. (WebCore::DNSResolveQueue::fired): Ditto when sending queued ones.

9:50 AM Changeset in webkit [74196] by Martin Robinson

2 edits in trunk/WebKit/gtk

2010-12-16 Carlos Garcia Campos <cgarcia@igalia.com>

Reviewed by Martin Robinson.

[Gtk] scrolling artifacts
https://bugs.webkit.org/show_bug.cgi?id=45029

Call gdk_window_process_updates() right after moving the window
when scrolling.

WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::scroll):

9:33 AM Changeset in webkit [74195] by scherkus@chromium.org

2 edits
8 deletes in trunk/LayoutTests

2010-12-16 Andrew Scherkus <scherkus@chromium.org>

Unreviewed. Updating Chromium media test expectations.

platform/chromium-mac/media/audio-constructor-expected.txt: Removed.
platform/chromium-mac/media/audio-constructor-preload-expected.txt: Removed.
platform/chromium-mac/media/audio-constructor-src-expected.txt: Removed.
platform/chromium-mac/media/media-load-event-expected.txt: Removed.
platform/chromium-win/media/audio-constructor-expected.txt: Removed.
platform/chromium-win/media/audio-constructor-preload-expected.txt: Removed.
platform/chromium-win/media/audio-constructor-src-expected.txt: Removed.
platform/chromium-win/media/media-load-event-expected.txt: Removed.
platform/chromium/test_expectations.txt:

9:01 AM Changeset in webkit [74194] by wsiegrist@apple.com

1 edit in trunk/WebKitTools/BuildSlaveSupport/build.webkit.org-config/master.cfg

William Siegrist <wsiegrist@apple.com>

Unreviewed buildbot master config change to prevent slave shutdowns via web interface.

8:56 AM Changeset in webkit [74193] by yurys@chromium.org

4 edits in trunk/WebCore

2010-12-16 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Console always scroll to the bottom on new events
https://bugs.webkit.org/show_bug.cgi?id=51189

When new messages are added to the console it will auto scroll
only if it was already scrolled down to the last record.

inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.prototype._scheduleScrollIntoView.scrollIntoView): (WebInspector.ConsoleView.prototype._scheduleScrollIntoView): (WebInspector.ConsoleView.prototype._isScrolledToLastMessage): (WebInspector.ConsoleView.prototype.addMessage):

8:32 AM Changeset in webkit [74192] by ariya@webkit.org

3 edits in trunk/JavaScriptCore

2010-12-16 Ariya Hidayat <ariya@sencha.com>

Reviewed by Andreas Kling.

[JSC] Const correctness in ASTBuilder and SyntaxChecker
https://bugs.webkit.org/show_bug.cgi?id=51141

parser/ASTBuilder.h: (JSC::ASTBuilder::getName): (JSC::ASTBuilder::getType): (JSC::ASTBuilder::isResolve):
parser/SyntaxChecker.h: (JSC::SyntaxChecker::operatorStackPop):

7:57 AM Changeset in webkit [74191] by podivilov@chromium.org

5 edits in trunk/WebCore

2010-12-16 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: update CallStackSidebarPane placards and status message in the same event handler.
https://bugs.webkit.org/show_bug.cgi?id=51174

inspector/front-end/BreakpointManager.js: (WebInspector.BreakpointManager.prototype.breakpointViewForEventData): (WebInspector.BreakpointManager.prototype._debuggerPaused): (WebInspector.BreakpointManager.prototype._debuggerResumed):
inspector/front-end/CallStackSidebarPane.js: (WebInspector.CallStackSidebarPane): (WebInspector.CallStackSidebarPane.prototype.update): (WebInspector.CallStackSidebarPane.prototype.registerShortcuts):
inspector/front-end/DebuggerModel.js: (WebInspector.DebuggerModel.prototype.pausedScript):
inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype._debuggerPaused):

7:47 AM Changeset in webkit [74190] by yurys@chromium.org

1 edit
3 adds in trunk/LayoutTests

2010-12-16 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Update Chromium test expectations for svg/repaint/filter-repaint.svg

platform/chromium-mac/svg/repaint/filter-repaint-expected.checksum: Added.
platform/chromium-mac/svg/repaint/filter-repaint-expected.png: Added.

7:05 AM Changeset in webkit [74189] by jorlow@chromium.org

2 edits in trunk/WebKit/chromium

2010-12-16 John Knottenbelt <jknotten@chromium.org>

Reviewed by Jeremy Orlow.

Enable client-based geolocation in Chromium
https://bugs.webkit.org/show_bug.cgi?id=50562

features.gypi:

6:55 AM Changeset in webkit [74188] by hans@chromium.org

4 edits in trunk

2010-12-16 Hans Wennborg <hans@chromium.org>

Reviewed by Jeremy Orlow.

IndexedDB: Fix IDBDatabaseError code offset bug
https://bugs.webkit.org/show_bug.cgi?id=51177

IDBDatabaseError::code() needs to return the error code without
offset. But when the IDBDatabaseError is created, the code comes with
an offset (it gets passed a IDBDatabaseException::IDBDatabaseExceptionCode).

However, in Chromium, IDBDatabaseErrors are sometimes also created via
WebIDBDatabaseError when they are sent across IPC, and then the error
code comes *without* offset. Provide a second create() function for
this case.

storage/IDBDatabaseError.h: (WebCore::IDBDatabaseError::create): (WebCore::IDBDatabaseError::createWithoutOffset): (WebCore::IDBDatabaseError::code):

2010-12-16 Hans Wennborg <hans@chromium.org>

Reviewed by Jeremy Orlow.

IndexedDB: Fix IDBDatabaseError code offset bug
https://bugs.webkit.org/show_bug.cgi?id=51177

WebIDBDatabaseError must use the
IDBDatabaseError::createWithoutOffset() function.

src/WebIDBDatabaseError.cpp: (WebKit::WebIDBDatabaseError::assign):

6:44 AM Changeset in webkit [74187] by xan@webkit.org

10 edits
3 deletes in trunk

Revert "2010-12-15 Helder Correia <helder@sencha.com>"

[Qt] Canvas shadow offset should not be affected by any transformation
https://bugs.webkit.org/show_bug.cgi?id=50422

Breaks canvas tests in GTK+.

6:31 AM Changeset in webkit [74186] by xan@webkit.org

6 edits in trunk

2010-12-16 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r74162.
http://trac.webkit.org/changeset/74162
https://bugs.webkit.org/show_bug.cgi?id=51185

More breakage in GTK+ (Requested by xan_ on #webkit).

fast/encoding/char-decoding-expected.txt:
fast/encoding/char-decoding.html:
fast/encoding/resources/char-decoding-utils.js: (decode):

2010-12-16 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r74162.
http://trac.webkit.org/changeset/74162
https://bugs.webkit.org/show_bug.cgi?id=51185

More breakage in GTK+ (Requested by xan_ on #webkit).

platform/text/TextCodecUTF16.cpp: (WebCore::TextCodecUTF16::registerEncodingNames):

6:09 AM Changeset in webkit [74185] by apavlov@chromium.org

5 edits in trunk

2010-12-16 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Up/Down/PageUp/PageDown on a CSS property numeric value commit the value editor
https://bugs.webkit.org/show_bug.cgi?id=51114

The r74038 regressed the behaviour. This patch additionally ensures that both Metrics and Styles panes
are updated once a stylesheet is reverted.

WebCore:

inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel.prototype._stylesPaneEdited): (WebInspector.ElementsPanel.prototype._metricsPaneEdited): (WebInspector.ElementsPanel.prototype._styleSheetChanged):

LayoutTests:

inspector/styles-add-blank-property-expected.txt:
inspector/styles-add-blank-property.html:

5:26 AM Changeset in webkit [74184] by yurys@chromium.org

2 edits in trunk/WebCore

2010-12-16 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Fix Chromium Mac Debug Clang compilation.

platform/graphics/FontFastPath.cpp: (WebCore::Font::getGlyphsAndAdvancesForSimpleText):

5:13 AM Changeset in webkit [74183] by alex

2 edits in trunk/WebCore

2010-12-16 Alejandro G. Castro <alex@igalia.com>

Unreviewed. Fix GTK3 compilation after 74129.

platform/gtk/WidgetRenderingContextGtk3.cpp:

5:01 AM Changeset in webkit [74182] by yurys@chromium.org

2 edits in trunk/LayoutTests

2010-12-16 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Update Chromium test expectations.

platform/chromium/test_expectations.txt:

4:44 AM Changeset in webkit [74181] by yurys@chromium.org

10 edits
4 adds in trunk/LayoutTests

2010-12-16 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Update Chromium test expectations.

platform/chromium-linux/svg/W3C-SVG-1.1/filters-composite-02-b-expected.checksum:
platform/chromium-linux/svg/W3C-SVG-1.1/filters-composite-02-b-expected.png:
platform/chromium-linux/svg/filters/feComposite-expected.checksum:
platform/chromium-linux/svg/filters/feComposite-expected.png:
platform/chromium-mac/svg/W3C-SVG-1.1/filters-composite-02-b-expected.checksum: Added.
platform/chromium-mac/svg/W3C-SVG-1.1/filters-composite-02-b-expected.png: Added.
platform/chromium-mac/svg/filters/feComposite-expected.checksum: Added.
platform/chromium-mac/svg/filters/feComposite-expected.png: Added.
platform/chromium-win/svg/W3C-SVG-1.1/filters-composite-02-b-expected.checksum:
platform/chromium-win/svg/W3C-SVG-1.1/filters-composite-02-b-expected.png:
platform/chromium-win/svg/filters/feComposite-expected.checksum:
platform/chromium-win/svg/filters/feComposite-expected.png:
platform/chromium/test_expectations.txt:

3:34 AM Changeset in webkit [74180] by yurys@chromium.org

73 edits in trunk/LayoutTests

2010-12-16 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Update Chromium test expectations to match changes made in r74177.

platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-dom-in2-attr-expected.checksum:
platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-dom-in2-attr-expected.png:
platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-dom-k1-attr-expected.checksum:
platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-dom-k1-attr-expected.png:
platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-dom-k2-attr-expected.checksum:
platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-dom-k2-attr-expected.png:
platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-dom-k3-attr-expected.checksum:
platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-dom-k3-attr-expected.png:
platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-dom-k4-attr-expected.checksum:
platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-dom-k4-attr-expected.png:
platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-dom-operator-attr-expected.checksum:
platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-dom-operator-attr-expected.png:
platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-svgdom-in2-prop-expected.checksum:
platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-svgdom-in2-prop-expected.png:
platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-svgdom-k1-prop-expected.checksum:
platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-svgdom-k1-prop-expected.png:
platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-svgdom-k2-prop-expected.checksum:
platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-svgdom-k2-prop-expected.png:
platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-svgdom-k3-prop-expected.checksum:
platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-svgdom-k3-prop-expected.png:
platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-svgdom-k4-prop-expected.checksum:
platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-svgdom-k4-prop-expected.png:
platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-svgdom-operator-prop-expected.checksum:
platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-svgdom-operator-prop-expected.png:
platform/chromium-mac/svg/dynamic-updates/SVGFECompositeElement-dom-in2-attr-expected.checksum:
platform/chromium-mac/svg/dynamic-updates/SVGFECompositeElement-dom-in2-attr-expected.png:
platform/chromium-mac/svg/dynamic-updates/SVGFECompositeElement-dom-k1-attr-expected.checksum:
platform/chromium-mac/svg/dynamic-updates/SVGFECompositeElement-dom-k1-attr-expected.png:
platform/chromium-mac/svg/dynamic-updates/SVGFECompositeElement-dom-k2-attr-expected.checksum:
platform/chromium-mac/svg/dynamic-updates/SVGFECompositeElement-dom-k2-attr-expected.png:
platform/chromium-mac/svg/dynamic-updates/SVGFECompositeElement-dom-k3-attr-expected.checksum:
platform/chromium-mac/svg/dynamic-updates/SVGFECompositeElement-dom-k3-attr-expected.png:
platform/chromium-mac/svg/dynamic-updates/SVGFECompositeElement-dom-k4-attr-expected.checksum:
platform/chromium-mac/svg/dynamic-updates/SVGFECompositeElement-dom-k4-attr-expected.png:
platform/chromium-mac/svg/dynamic-updates/SVGFECompositeElement-dom-operator-attr-expected.checksum:
platform/chromium-mac/svg/dynamic-updates/SVGFECompositeElement-dom-operator-attr-expected.png:
platform/chromium-mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-in2-prop-expected.checksum:
platform/chromium-mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-in2-prop-expected.png:
platform/chromium-mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-k1-prop-expected.checksum:
platform/chromium-mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-k1-prop-expected.png:
platform/chromium-mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-k2-prop-expected.checksum:
platform/chromium-mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-k2-prop-expected.png:
platform/chromium-mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-k3-prop-expected.checksum:
platform/chromium-mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-k3-prop-expected.png:
platform/chromium-mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-k4-prop-expected.checksum:
platform/chromium-mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-k4-prop-expected.png:
platform/chromium-mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-operator-prop-expected.checksum:
platform/chromium-mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-operator-prop-expected.png:
platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-dom-in2-attr-expected.checksum:
platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-dom-in2-attr-expected.png:
platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-dom-k1-attr-expected.checksum:
platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-dom-k1-attr-expected.png:
platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-dom-k2-attr-expected.checksum:
platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-dom-k2-attr-expected.png:
platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-dom-k3-attr-expected.checksum:
platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-dom-k3-attr-expected.png:
platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-dom-k4-attr-expected.checksum:
platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-dom-k4-attr-expected.png:
platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-dom-operator-attr-expected.checksum:
platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-dom-operator-attr-expected.png:
platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-svgdom-in2-prop-expected.checksum:
platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-svgdom-in2-prop-expected.png:
platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-svgdom-k1-prop-expected.checksum:
platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-svgdom-k1-prop-expected.png:
platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-svgdom-k2-prop-expected.checksum:
platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-svgdom-k2-prop-expected.png:
platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-svgdom-k3-prop-expected.checksum:
platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-svgdom-k3-prop-expected.png:
platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-svgdom-k4-prop-expected.checksum:
platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-svgdom-k4-prop-expected.png:
platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-svgdom-operator-prop-expected.checksum:
platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-svgdom-operator-prop-expected.png:

3:20 AM Changeset in webkit [74179] by yurys@chromium.org

2 edits in trunk/WebCore

2010-12-16 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Fix Chromium Debug compilation after r74177

platform/graphics/filters/FEComposite.cpp: (WebCore::arithmetic):

12:40 AM Changeset in webkit [74178] by tkent@chromium.org

2 edits in trunk/WebCore

2010-12-16 Kent Tamura <tkent@chromium.org>

Unreviewed, build fix.

Fix a warning on 32-bit Mac.

platform/graphics/mac/SimpleFontDataMac.mm: (WebCore::SimpleFontData::emphasisMarkFontData): 0.5 -> 0.5f

12:32 AM Changeset in webkit [74177] by zherczeg@webkit.org

27 edits in trunk

Improve feArithmeticFilter
https://bugs.webkit.org/show_bug.cgi?id=51105

Reviewed by Dirk Schulze.

WebCore:

In case of the arithmetic operator on feComposite filter, we could use
different result passing modes depend on its type. Furthermore, the
number of executed multiplications is reduced if k1 or k4 argument is zero.

2% speedup on WebCore/manual-tests/svg-filter-animation.svg

platform/graphics/filters/FEComposite.cpp:

(WebCore::computeArithmeticPixels):
(WebCore::arithmetic):
(WebCore::FEComposite::apply):

LayoutTests:

No visible changes.

platform/mac-leopard/svg/dynamic-updates/SVGFECompositeElement-dom-in2-attr-expected.checksum:
platform/mac-leopard/svg/dynamic-updates/SVGFECompositeElement-dom-in2-attr-expected.png:
platform/mac-leopard/svg/dynamic-updates/SVGFECompositeElement-dom-k1-attr-expected.checksum:
platform/mac-leopard/svg/dynamic-updates/SVGFECompositeElement-dom-k1-attr-expected.png:
platform/mac-leopard/svg/dynamic-updates/SVGFECompositeElement-dom-k2-attr-expected.checksum:
platform/mac-leopard/svg/dynamic-updates/SVGFECompositeElement-dom-k2-attr-expected.png:
platform/mac-leopard/svg/dynamic-updates/SVGFECompositeElement-dom-k3-attr-expected.checksum:
platform/mac-leopard/svg/dynamic-updates/SVGFECompositeElement-dom-k3-attr-expected.png:
platform/mac-leopard/svg/dynamic-updates/SVGFECompositeElement-dom-k4-attr-expected.checksum:
platform/mac-leopard/svg/dynamic-updates/SVGFECompositeElement-dom-k4-attr-expected.png:
platform/mac-leopard/svg/dynamic-updates/SVGFECompositeElement-dom-operator-attr-expected.checksum:
platform/mac-leopard/svg/dynamic-updates/SVGFECompositeElement-dom-operator-attr-expected.png:
platform/mac-leopard/svg/dynamic-updates/SVGFECompositeElement-svgdom-in2-prop-expected.checksum:
platform/mac-leopard/svg/dynamic-updates/SVGFECompositeElement-svgdom-in2-prop-expected.png:
platform/mac-leopard/svg/dynamic-updates/SVGFECompositeElement-svgdom-k1-prop-expected.checksum:
platform/mac-leopard/svg/dynamic-updates/SVGFECompositeElement-svgdom-k1-prop-expected.png:
platform/mac-leopard/svg/dynamic-updates/SVGFECompositeElement-svgdom-k2-prop-expected.checksum:
platform/mac-leopard/svg/dynamic-updates/SVGFECompositeElement-svgdom-k2-prop-expected.png:
platform/mac-leopard/svg/dynamic-updates/SVGFECompositeElement-svgdom-k3-prop-expected.checksum:
platform/mac-leopard/svg/dynamic-updates/SVGFECompositeElement-svgdom-k3-prop-expected.png:
platform/mac-leopard/svg/dynamic-updates/SVGFECompositeElement-svgdom-k4-prop-expected.checksum:
platform/mac-leopard/svg/dynamic-updates/SVGFECompositeElement-svgdom-k4-prop-expected.png:
platform/mac-leopard/svg/dynamic-updates/SVGFECompositeElement-svgdom-operator-prop-expected.checksum:
platform/mac-leopard/svg/dynamic-updates/SVGFECompositeElement-svgdom-operator-prop-expected.png:

Dec 15, 2010:

11:48 PM Changeset in webkit [74176] by yurys@chromium.org

3 edits in trunk/LayoutTests

2010-12-15 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Update Chromium test expectations.

platform/chromium-gpu/test_expectations.txt:
platform/chromium/test_expectations.txt:

10:52 PM Changeset in webkit [74175] by mitz@apple.com

3 edits in trunk/WebKit2

<rdar://problem/8731320> WebProcess's CFNetwork cache is in ~/Library/Caches/com.apple.WebProcess

Reviewed by Sam Weinig.

UIProcess/Launcher/mac/ProcessLauncherMac.mm:

(WebKit::ProcessLauncher::launchProcess): Get the location, disk capacity and memory capacity
of the UI process's NSURLCache and pass them to the WebProcess.

WebProcess/mac/WebProcessMainMac.mm:

(WebKit::WebProcessMain): If an NSURLCache location was passed on the command line, set the
shared NSURLCache to that path and use the specified capacities as initial values.

10:32 PM Changeset in webkit [74174] by mitz@apple.com

2 edits in trunk/WebKit2

Allow responses to be cached by the NSURLCache.

Reviewed by Sam "I blame undersea" Weinig.

WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::willCacheResponse): Changed to return the response instead of 0.

10:14 PM Changeset in webkit [74173] by Laszlo Gombos

2 edits in trunk/WebKit/qt

2010-12-15 Laszlo Gombos <Laszlo Gombos>

Reviewed by Antonio Gomes.

[Qt] Fix tst_QWebPage::geolocationRequestJS()
https://bugs.webkit.org/show_bug.cgi?id=46814

Change the test case according to the changes introduced by
r72603 and enable the test case.

tests/qwebpage/tst_qwebpage.cpp: (tst_QWebPage::geolocationRequestJS):

8:35 PM Changeset in webkit [74172] by cwzwarich@webkit.org

2 edits in trunk/WebKit/mac

Reviewed by Darin Adler.

Clang -Wcast-align gives an error in WebBasePluginPackage.mm
https://bugs.webkit.org/show_bug.cgi?id=51144

Fix an alignment issue. OSSwapInt32 takes data that is 32-bit aligned on ARM, but
we were calling it on a byte array 32 bits at a time. While this is okay in practice,
since TCMalloc won't give us a non-32-bit aligned block array of bytes and Vector's
inline storage is at the beginning of the Vector, it is still better to fix this
and silence the warning.

Plugins/WebBasePluginPackage.mm:

(swapIntsInHeader):
(-[WebBasePluginPackage isNativeLibraryData:]):

7:31 PM Changeset in webkit [74171] by commit-queue@webkit.org

3 edits in trunk/WebKit/chromium

2010-12-15 Chris Guillory <chris.guillory@google.com>

Reviewed by Darin Fisher.

Expose AccessibilityObject::url() to Chromium
https://bugs.webkit.org/show_bug.cgi?id=51046

public/WebAccessibilityObject.h:
src/WebAccessibilityObject.cpp: (WebKit::WebAccessibilityObject::url):

6:26 PM Changeset in webkit [74170] by bweinstein@apple.com

3 edits in trunk/WebCore

WebKit2 should exit auto scrolling mode when losing focus
https://bugs.webkit.org/show_bug.cgi?id=49209

Reviewed by Jon Honeycutt.

When a page loses focus, make sure that we stop the autoscroll timer, which exits pan scrolling mode. We
don't want to automatically scroll when a page doesn't have focus.

Updated manual-tests/autoscroll.html with instructions to test this bug.

manual-tests/autoscroll.html:
page/FocusController.cpp:

(WebCore::FocusController::setFocused):

6:23 PM Changeset in webkit [74169] by mitz@apple.com

33 edits in trunk/WebCore

Font support for the text-emphasis CSS property
Part of <rdar://problem/7720300> Support the CSS3 text-emphasis property
https://bugs.webkit.org/show_bug.cgi?id=48539

Reviewed by Darin Adler.

platform/graphics/Font.cpp:

(WebCore::Font::drawEmphasisMarks): Added. Calls through to drawEmphasisMarksFor{Simple,Complex}Text.
(WebCore::Font::canReceiveTextEmphasis): Added. For simple text, checks if the character should
have an emphasis mark.

platform/graphics/Font.h:

platform/graphics/FontFastPath.cpp:

(WebCore::Font::glyphDataForCharacter): Replaced the forceSmallCaps boolean with a FontDataVariant
parameter and made this function work with other variants.
(WebCore::Font::getEmphasisMarkGlyphData): Added. Returns glyph data for the first character of
the emphasis mark. This function may not work if the emphasis mark uses a complex script, but none
of the standard emphasis marks do so.
(WebCore::Font::emphasisMarkAscent): Added.
(WebCore::Font::emphasisMarkDescent): Added.
(WebCore::Font::emphasisMarkHeight): Added.
(WebCore::Font::getGlyphsAndAdvancesForSimpleText): Moved much of the logic from drawSimpleText()
into this new function, which also has a ForTextEmphasis parameter, which is passed along to the
WidthIterator.
(WebCore::Font::drawSimpleText): Left the drawing part here.
(WebCore::Font::drawEmphasisMarksForSimpleText): Added.
(WebCore::Font::drawGlyphBuffer): Removed the unused TextRun parameter.
(WebCore::offsetToMiddleOfGlyph): Added this helper.
(WebCore::offsetToMiddleOfGlyphAtIndex): Added this other helper.
(WebCore::Font::drawEmphasisMarks): Added. Draws emphasis marks for a given glyph buffer by placing
one mark centered above each glyph. Zero glyphs in the buffer indicate that no mark should be drawn.

platform/graphics/GraphicsContext.cpp:

(WebCore::GraphicsContext::drawEmphasisMarks): Added. Calls through to Font::drawEmphasisMarks().

platform/graphics/GraphicsContext.h:

platform/graphics/SimpleFontData.cpp:

(WebCore::SimpleFontData::SimpleFontData): Removed initialization of deleted members.
(WebCore::SimpleFontData::~SimpleFontData): Removed derived font data cleanup, which now happens
in ~DerivedFontData.
(WebCore::SimpleFontData::brokenIdeographFontData): Changed to use m_derivedFontData.
(WebCore::SimpleFontData::DerivedFontData::DerivedFontData): Added. This lazily-allocated struct
contains the SimpleFontData for small caps, broken ideograph and emphasis mark.
(WebCore::SimpleFontData::DerivedFontData::~DerivedFontData): Added.

platform/graphics/SimpleFontData.h:

(WebCore::SimpleFontData::variantFontData): Added. This is used by Font::glyphDataForCharacter().

platform/graphics/WidthIterator.cpp:

(WebCore::WidthIterator::WidthIterator): Added forTextEmphasis parameter.
(WebCore::WidthIterator::advance): When used for text emphasis, replace glyphs with the zero glyph
if they should not receive an emphasis mark.

platform/graphics/WidthIterator.h:

platform/graphics/chromium/FontChromiumWin.cpp:

(WebCore::Font::drawEmphasisMarksForComplexText): Added stub.

platform/graphics/chromium/FontLinux.cpp:

(WebCore::TextRunWalker::nextScriptRun): Updated for change to Font::glyphDataForCharacter().
(WebCore::TextRunWalker::setupFontForScriptRun): Ditto.
(WebCore::Font::drawEmphasisMarksForComplexText): Added stub.

platform/graphics/chromium/SimpleFontDataChromiumWin.cpp:

(WebCore::SimpleFontData::scaledFontData): Moved code from smallCapsFontData() here and generalized.
(WebCore::SimpleFontData::smallCapsFontData): Adopted m_derivedFontData and scaledFontData().
(WebCore::SimpleFontData::emphasisMarkFontData): Added.

platform/graphics/chromium/SimpleFontDataLinux.cpp:

platform/graphics/efl/FontEfl.cpp:

(WebCore::Font::drawEmphasisMarksForComplexText): Added stub.

platform/graphics/freetype/SimpleFontDataFreeType.cpp:

platform/graphics/gtk/FontGtk.cpp:

(WebCore::Font::drawEmphasisMarksForComplexText): Added stub.

platform/graphics/haiku/FontHaiku.cpp:

(WebCore::Font::drawEmphasisMarksForComplexText): Added stub.

platform/graphics/haiku/SimpleFontDataHaiku.cpp:

platform/graphics/mac/ComplexTextController.cpp:

(WebCore::ComplexTextController::ComplexTextController): Added forTextEmphasis parameter.
(WebCore::ComplexTextController::collectComplexTextRuns): Updated for change to Font::glyphDataForCharacter().
(WebCore::ComplexTextController::adjustGlyphsAndAdvances): When used for text emphasis, replace glyphs with the zero glyph
if they should not receive an emphasis mark.

platform/graphics/mac/ComplexTextController.h:

platform/graphics/mac/FontComplexTextMac.cpp:

(WebCore::Font::getGlyphsAndAdvancesForComplexText): Moved much of the logic from drawComplexText()
into this new function, which also has a ForTextEmphasis parameter, which is passed along to the
ComplexTextController.
(WebCore::Font::drawComplexText): Left the drawing part here.
(WebCore::Font::drawEmphasisMarksForComplexText): Added.

platform/graphics/mac/SimpleFontDataMac.mm:

(WebCore::SimpleFontData::platformDestroy): Adopted m_derivedFontData.
(WebCore::SimpleFontData::scaledFontData): Moved code from smallCapsFontData() here and generalized.
(WebCore::SimpleFontData::smallCapsFontData): Adopted m_derivedFontData and scaledFontData().
(WebCore::SimpleFontData::emphasisMarkFontData): Added.

platform/graphics/pango/SimpleFontDataPango.cpp:

(WebCore::SimpleFontData::platformDestroy): Removed redundant clearing of derived font.
(WebCore::SimpleFontData::scaledFontData): Moved code from smallCapsFontData() here and generalized.
(WebCore::SimpleFontData::smallCapsFontData): Adopted m_derivedFontData and scaledFontData().
(WebCore::SimpleFontData::emphasisMarkFontData): Added.

platform/graphics/qt/FontQt.cpp:

(WebCore::Font::emphasisMarkAscent): Added stub.
(WebCore::Font::emphasisMarkDescent): Ditto.
(WebCore::Font::emphasisMarkHeight): Ditto.
(WebCore::Font::drawEmphasisMarksForSimpleText): Ditto.
(WebCore::Font::drawEmphasisMarksForComplexText): Ditto.

platform/graphics/win/FontWin.cpp:

(WebCore::Font::getGlyphsAndAdvancesForComplexText): Moved much of the logic from drawComplexText()
into this new function, which also has a ForTextEmphasis parameter. Currently returns an empty
glyph buffer for text emphasis.
(WebCore::Font::drawComplexText): Left the drawing part here.
(WebCore::Font::drawEmphasisMarksForComplexText): Added.

platform/graphics/win/SimpleFontDataWin.cpp:

platform/graphics/win/UniscribeController.cpp:

(WebCore::UniscribeController::advance): Updated for change to Font::glyphDataForCharacter().

platform/graphics/wince/FontWinCE.cpp:

(WebCore::Font::drawEmphasisMarksForComplexText): Added stub.

platform/graphics/wince/SimpleFontDataWinCE.cpp:

platform/graphics/wx/FontWx.cpp:

(WebCore::Font::getGlyphsAndAdvancesForComplexText): Added stub.
(WebCore::Font::drawComplexText): Updated for removal of unused TextRun parameter to drawGlyphBuffer().
(WebCore::Font::drawEmphasisMarksForComplexText): Added.

platform/graphics/wx/SimpleFontDataWx.cpp:

platform/text/CharacterNames.h: Added characters used in Font::canReceiveTextEmphasis().

6:20 PM Rebaseline edited by jamesr@google.com

(diff)

6:13 PM Changeset in webkit [74168] by Beth Dakin

3 edits in trunk/WebCore

Fix for https://bugs.webkit.org/show_bug.cgi?id=51150 WebView's
_scaleWebView SPI doesn't work on pages with compositing layers
-and corresponding-
<rdar://problem/8604713>

Reviewed by Darin Adler.

paintingGoesToWindow() should return false if the owning layer has
a transform.

rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::paintingGoesToWindow):

Use docWidth() and docHeight() instead of rightLayoutOverflow() and
bottomLayoutOverflow() since docWidth/Height are now the preferred
way to query physical dimensions of the document.

rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::updateRootLayerPosition):

5:33 PM Changeset in webkit [74167] by commit-queue@webkit.org

2 edits in trunk/WebCore

2010-12-15 Alex Bredariol Grilo <abgrilo@profusion.mobi>

Reviewed by Eric Seidel.

[EFL] Fix timer calling time in SharedTimerEfl

No new features, so no tests added.

The usage of ecore_timer_loop_add instead of ecore_timer_add corrects
the problem that the timer is not called at the correct time. Since this
code runs in a single thread, all multiple thread operations were
removed.

platform/efl/SharedTimerEfl.cpp: (WebCore::stopSharedTimer): (WebCore::addNewTimer):

5:16 PM Changeset in webkit [74166] by bweinstein@apple.com

4 edits
1 add in trunk/LayoutTests

Rebaseline Windows XP results after r73993. Windows 7 results were landed in r73998, but some XP
rebaselines were needed as well.

platform/win-xp/fast/text/international/bidi-control-chars-treated-as-ZWS-expected.txt: Added.
platform/win-xp/fast/text/international/bold-bengali-expected.txt:
platform/win-xp/fast/text/international/complex-character-based-fallback-expected.txt:
platform/win-xp/transforms/2d/hindi-rotated-expected.txt:

5:15 PM Changeset in webkit [74165] by andreas.kling@nokia.com

2 edits in trunk/WebCore

2010-12-15 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Ariya Hidayat.

[Qt] StillImage::draw() shouldn't call setCompositionMode() unless the QPaintEngine has Porter-Duff composition
https://bugs.webkit.org/show_bug.cgi?id=49918

Go through GraphicsContext::setCompositeOperation() which does the check for us.

platform/graphics/qt/StillImageQt.cpp: (WebCore::StillImage::draw):

5:07 PM Changeset in webkit [74164] by enrica@apple.com

12 edits in trunk/WebKit2

Add IME support to WebKit2 on Windows
https://bugs.webkit.org/show_bug.cgi?id=51049
The implementation is very close to the one in WebKit.
The main change is the addition of handlers for WM_IME_STARTCOMPOSITION,
WM_IME_REQUEST, WM_IME_COMPOSITION, WM_IME_ENDCOMPOSITION,
WM_IME_SELECT, WM_IME_SETCONTEXT and a number of new messages
between the UI process and the WebProcess to send/retrieve
the data being handled by the messages listed above.

Reviewed by Adam Roben.

UIProcess/PageClient.h: Added compositionSelectionChanged for Windows platform.
UIProcess/WebPageProxy.cpp:

The following methods send synchronous messages to the WebProcess.
(WebKit::WebPageProxy::firstRectForCharacterInSelectedRange): Retrieves the rectangle to position
the cnadidates window.
(WebKit::WebPageProxy::getSelectedText): Retrieves the currently selected text.
The following methods send asynchronous messages to the WebProcess.
(WebKit::WebPageProxy::confirmComposition):
(WebKit::WebPageProxy::setComposition):
(WebKit::WebPageProxy::didChangeSelection): Name changed.
(WebKit::WebPageProxy::didChangeCompositionSelection): Called when there is a change
in the composition selection.

UIProcess/WebPageProxy.messages.in: Added messages corresponding to the methods above.
UIProcess/win/WebView.cpp:

(WebKit::WebView::wndProc): Added handling of messages for IME.
The following are the handlers for the window message being sent during composition.
(WebKit::WebView::onIMEComposition):
(WebKit::WebView::onIMEEndComposition):
(WebKit::WebView::onIMERequestCharPosition):
(WebKit::WebView::onIMERequestReconvertString):
(WebKit::WebView::onIMERequest):
(WebKit::WebView::onIMESelect):
(WebKit::WebView::onIMESetContext):

WebProcess/WebCoreSupport/WebEditorClient.cpp:

(WebKit::WebEditorClient::respondToChangedSelection): Added notification
of composition selection changed for Windows.

WebProcess/WebPage/win/WebPageWin.cpp:

The following are the WebProcess counterparts of the new messages.
(WebKit::WebPage::confirmComposition):
(WebKit::WebPage::setComposition):
(WebKit::WebPage::firstRectForCharacterInSelectedRange):
(WebKit::WebPage::getSelectedText):

4:58 PM Changeset in webkit [74163] by commit-queue@webkit.org

4 edits in trunk/WebKitTools

2010-12-15 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r74136.
http://trac.webkit.org/changeset/74136
https://bugs.webkit.org/show_bug.cgi?id=51135

r74136 breaks chromium canary bots because some tests are not
rebaselined correctly to resolve EOL differences (Requested by
jianli on #webkit).

Scripts/webkitpy/layout_tests/port/base.py:
Scripts/webkitpy/layout_tests/port/test.py:
Scripts/webkitpy/layout_tests/test_types/text_diff.py:

4:55 PM Changeset in webkit [74162] by commit-queue@webkit.org

6 edits in trunk

2010-12-15 Yong Li <yoli@rim.com>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=51035
Add tests for UTF-16 BE/LE and their variants.
Also, check the full decoded text but not only the first one.

fast/encoding/char-decoding.html:
fast/encoding/char-decoding-expected.txt:
fast/encoding/resources/char-decoding-utils.js:

2010-12-15 Yong Li <yoli@rim.com>

Reviewed by Darin Adler.

UTF-16 and its variants should be treated as Big Endian when BOM
is absent.
https://bugs.webkit.org/show_bug.cgi?id=51035

Test: fast/encoding/char-decoding.html (changed)

platform/text/TextCodecUTF16.cpp: (WebCore::TextCodecUTF16::registerEncodingNames):

4:12 PM Changeset in webkit [74161] by darin@chromium.org

3 edits in trunk/WebKit/chromium

2010-12-14 Darin Fisher <darin@chromium.org>

Reviewed by Dimitri Glazkov.

[chromium] AssociatedURLLoader leaks m_realLoader to its WebURLLoaderClient.
https://bugs.webkit.org/show_bug.cgi?id=51062

src/AssociatedURLLoader.cpp: Intercept WebURLLoaderClient methods and forward |this| as the WebURLLoader parameter. (WebKit::AssociatedURLLoader::AssociatedURLLoader): (WebKit::AssociatedURLLoader::loadSynchronously): (WebKit::AssociatedURLLoader::loadAsynchronously): (WebKit::AssociatedURLLoader::willSendRequest): (WebKit::AssociatedURLLoader::didSendData): (WebKit::AssociatedURLLoader::didReceiveResponse): (WebKit::AssociatedURLLoader::didDownloadData): (WebKit::AssociatedURLLoader::didReceiveData): (WebKit::AssociatedURLLoader::didReceiveCachedMetadata): (WebKit::AssociatedURLLoader::didFinishLoading): (WebKit::AssociatedURLLoader::didFail):
src/AssociatedURLLoader.h:

4:02 PM Changeset in webkit [74160] by ojan@chromium.org

3 edits in trunk/BugsSite

2010-12-15 Ojan Vafai <ojan@chromium.org>

Reviewed by Adam Barth.

size status bubble to it's contents on the code review page
https://bugs.webkit.org/show_bug.cgi?id=51142

PrettyPatch/PrettyPatch.rb:
code-review.js:

4:00 PM Changeset in webkit [74159] by mihaip@chromium.org

4 edits
1 add
11 deletes in trunk/LayoutTests

2010-12-15 Mihai Parparita <mihaip@chromium.org>

Reviewed by Eric Seidel.

fast/parser/remove-block-in-residual-style.html does not need pixel output
https://bugs.webkit.org/show_bug.cgi?id=51120

fast/parser/remove-block-in-residual-style.html just checks that we
don't crash, it doesn't need pixel output.

(noticed while doing Snow Leopard rebaselines)

fast/parser/remove-block-in-residual-style-expected.txt: Added.
fast/parser/remove-block-in-residual-style.html:
platform/chromium-linux/fast/parser/remove-block-in-residual-style-expected.checksum: Removed.
platform/chromium-linux/fast/parser/remove-block-in-residual-style-expected.png: Removed.
platform/chromium-mac/fast/parser/remove-block-in-residual-style-expected.checksum: Removed.
platform/chromium-mac/fast/parser/remove-block-in-residual-style-expected.png: Removed.
platform/chromium-win/fast/parser/remove-block-in-residual-style-expected.checksum: Removed.
platform/chromium-win/fast/parser/remove-block-in-residual-style-expected.png: Removed.
platform/chromium-win/fast/parser/remove-block-in-residual-style-expected.txt: Removed.
platform/gtk/Skipped:
platform/mac/fast/parser/remove-block-in-residual-style-expected.checksum: Removed.
platform/mac/fast/parser/remove-block-in-residual-style-expected.png: Removed.
platform/mac/fast/parser/remove-block-in-residual-style-expected.txt: Removed.
platform/qt/Skipped:
platform/qt/fast/parser/remove-block-in-residual-style-expected.txt: Removed.

3:59 PM Changeset in webkit [74158] by ojan@chromium.org

2 edits in trunk/WebKitTools

2010-12-15 Adam Roben <Adam Roben>

Teach check-webkit-style to check .vcproj and .vsprops files for XML
syntax errors

Fixes <http://webkit.org/b/51103> check-webkit-style should check for
XML syntax errors in .vcproj/.vsprops files

Reviewed by Dave Levin.

Scripts/webkitpy/style/checker.py: Added lists of file extensions that should be treated as XML and that should be allowed to contain carriage returns. (These lists happen to be identical currently.) (FileType): Added a new XML type. (CheckerDispatcher.should_check_and_strip_carriage_returns): Added. Just does a simple file extension check. (CheckerDispatcher._file_type): Added a case for XML files. (CheckerDispatcher._create_checker): Ditto. We use XMLChecker for XML files (surprise!). (StyleProcessor.process): Ask the dispatcher whether we should pass the lines through the carriage checker.

Scripts/webkitpy/style/checker_unittest.py: (CheckerDispatcherCarriageReturnTest.test_should_check_and_strip_carriage_returns): Added. Checks a few file names to see if carriage returns are allowed or not. (CheckerDispatcherDispatchTest.assert_checker_xml): Added. Similar to other assert_checker_* functions. (CheckerDispatcherDispatchTest.test_xml_paths): Added. Similar to other test_*_paths functions. (CheckerDispatcherDispatchTest.test_xml_paths): Added. Similar to other test_*_paths functions. (CheckerDispatcherDispatchTest.test_none_paths): Removed the vcproj file from this test case, as vcproj files now have a type. (StyleProcessor_CodeCoverageTest.MockDispatcher.should_check_and_strip_carriage_returns): Added. Similar to the other should_* functions. (StyleProcessor_CodeCoverageTest.test_processcarriage_returns_not_stripped): Added. Checks that carriage returns aren't checked for or stripped for allowed files.

Scripts/webkitpy/style/checkers/xml.py: Added. (XMLChecker.init): Simple init method. (XMLChecker.check): Pass each line through the expat parser, and record a style error for any errors thrown by the parser.

Scripts/webkitpy/style/checkers/xml_unittest.py: Added. (XMLCheckerTest.assert_no_error): Checks that the given XML does not produce a style error. (XMLCheckerTest.assert_error): Checks that the given XML produces an error of the given category on the given line. (XMLCheckerTest.mock_handle_style_error): Does nothing. Used for checking that the XMLChecker constructor works properly. (XMLCheckerTest.test_conflict_marker): Tests that conflict markers cause a style error (see, e.g., r73887). (XMLCheckerTest.test_extra_closing_tag): Tests that extra closing tags cause a style error (see, e.g., r73773). (XMLCheckerTest.test_init): Tests that the XMLChecker constructor works properly. (XMLCheckerTest.test_missing_closing_tag): Tests that missing closing tags cause a style error (see, e.g., r72795). (XMLCheckerTest.test_no_error): Tests that valid XML does not cause a style error.

3:55 PM Changeset in webkit [74157] by weinig@apple.com

3 edits in trunk/WebKit2

Loading webkit.org over and over is slower in WebKit2 than WebKit1, looks like page is not cached
<rdar://problem/8774683>
https://bugs.webkit.org/show_bug.cgi?id=51143

Reviewed by Brady Eidson.

WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::canCachePage): Return true as long as we
are not a custom representation (eg. a PDF).
(WebKit::WebFrameLoaderClient::shouldCacheResponse): Always return true.

WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences): Enable the page cache.

3:49 PM Changeset in webkit [74156] by Simon Fraser

4 edits
2 adds in trunk

2010-12-15 Simon Fraser <Simon Fraser>

Reviewed by Chris Marrin.

Percentage Z values in 3d transform functions and transform-origin should cause the property to be invalid
https://bugs.webkit.org/show_bug.cgi?id=51070

Treat as inavlid -webkit-transform values that include a percentage value in translateZ()
or in the third parameter to translate3d().

Test: transforms/3d/general/3dtransform-values.html

css/CSSParser.cpp: (WebCore::CSSParser::parseTransform): (WebCore::CSSParser::parseTransformOrigin): Whitespace change.

3:49 PM Changeset in webkit [74155] by Simon Fraser

3 edits
4 adds in trunk

2010-12-15 Simon Fraser <Simon Fraser>

Reviewed by Chris Marrin.

Reflection does not render properly when -webkit-transform is toggled, untoggled, and retoggled
https://bugs.webkit.org/show_bug.cgi?id=50967

If a reflection on a compositied, transformed element is toggled on, off and on,
then we pick up a cached layer clone that has the wrong transform set on it.

The fix is to reset those properties on the layer clones that get changed
when the GraphicsLayer gains a structural layer (for reflection flattening).

Test: compositing/reflections/remove-add-reflection.html

platform/graphics/ca/GraphicsLayerCA.cpp: (WebCore::GraphicsLayerCA::ensureStructuralLayer):

3:48 PM Changeset in webkit [74154] by commit-queue@webkit.org

10 edits
2 copies
1 add in trunk

2010-12-15 Helder Correia <helder@sencha.com>

Reviewed by Ariya Hidayat.

[Qt] Canvas shadow offset should not be affected by any transformation
https://bugs.webkit.org/show_bug.cgi?id=50422

On a canvas context, shadows are currently affected by all
transformations except scaling. According to the spec:
http://www.whatwg.org/specs/web-apps/current-work/multipage/the-canvas-element.html#shadows

"The shadowOffsetX and shadowOffsetY attributes specify the distance
that the shadow will be offset in the positive horizontal and positive
vertical distance respectively. Their values are in coordinate space
units. They are not affected by the current transformation matrix."

NOTE: this applies only to canvas, not to box shadows.

Add new test to ensure that shadows are correctly transformed keeping
the relative offset to the shape.

fast/canvas/canvas-scale-strokePath-shadow-expected.txt:
fast/canvas/canvas-transforms-fillRect-shadow-expected.txt: Added.
fast/canvas/canvas-transforms-fillRect-shadow.html: Added.
fast/canvas/script-tests/canvas-scale-fillPath-shadow.js:
fast/canvas/script-tests/canvas-scale-fillRect-shadow.js:
fast/canvas/script-tests/canvas-scale-strokePath-shadow.js: Now using a lineWidth > 1 to make it easier to test and more fair among all ports, since there can be different transformation smoothness or aliasing settings.
fast/canvas/script-tests/canvas-transforms-fillRect-shadow.js: Added.

2010-12-15 Helder Correia <helder@sencha.com>

Reviewed by Ariya Hidayat.

[Qt] Canvas shadow offset should not be affected by any transformation
https://bugs.webkit.org/show_bug.cgi?id=50422

On a canvas context, shadows are currently affected by all
transformations except scaling. According to the spec:
http://www.whatwg.org/specs/web-apps/current-work/multipage/the-canvas-element.html#shadows

"The shadowOffsetX and shadowOffsetY attributes specify the distance
that the shadow will be offset in the positive horizontal and positive
vertical distance respectively. Their values are in coordinate space
units. They are not affected by the current transformation matrix."

NOTE: this applies only to canvas, not to box shadows.

Test: fast/canvas/canvas-transforms-fillRect-shadow.html

platform/graphics/ContextShadow.cpp: (WebCore::ContextShadow::ContextShadow): (WebCore::ContextShadow::calculateLayerBoundingRect):
platform/graphics/ContextShadow.h: (WebCore::ContextShadow::setShadowsIgnoreTransforms): (WebCore::ContextShadow::shadowsIgnoreTransforms): (WebCore::ContextShadow::offset):
platform/graphics/qt/ContextShadowQt.cpp: (WebCore::ContextShadow::beginShadowLayer): (WebCore::ContextShadow::endShadowLayer):
platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::mustUseContextShadow): (WebCore::GraphicsContext::fillPath): (WebCore::GraphicsContext::strokePath): (WebCore::GraphicsContext::fillRect): (WebCore::GraphicsContext::fillRoundedRect): (WebCore::GraphicsContext::setPlatformShadow):

3:45 PM BuildingOnWindows edited by jhoneycutt@apple.com

After rebasing all of the DLLs in /usr/bin and /bin, I've not had any … (diff)

3:41 PM Changeset in webkit [74153] by timothy@apple.com

2 edits in trunk/WebCore

Fix a regression where the Web Inspector console would be empty
if the Inspector is localized.

https://bugs.webkit.org/show_bug.cgi?id=51145

Reviewed by Joseph Pecoraro.

inspector/front-end/ConsoleView.js:

(WebInspector.ConsoleView.createFilterElement): Add a label argument so the UI string
is separate from the classname. Code clean up.
(WebInspector.ConsoleView.prototype.filter): Remove toLowerCase and use string compare.
(WebInspector.ConsoleView): Pass separate classnames and labels to createFilterElement.

3:35 PM Changeset in webkit [74152] by Simon Fraser

7 edits in trunk

2010-12-15 Simon Fraser <Simon Fraser>

Reviewed by Adele Peterson.

WebKit2 in compositing mode no longer has font smoothing
https://bugs.webkit.org/show_bug.cgi?id=50733

Only turn off font smoothing for layers whose contents are
not opaque. This allows the root GraphicsLayer in WebKit2 to
set the opaque flag, and get smoothed text.

platform/graphics/mac/WebLayer.mm: (drawLayerContents):

2010-12-15 Simon Fraser <Simon Fraser>

Reviewed by Adele Peterson.

WebKit2 in compositing mode no longer has font smoothing
https://bugs.webkit.org/show_bug.cgi?id=50733

Tell the root GraphicsLayer that its contents are opaque
if the WebPage draws its background, and that background
is not transparent.

The GraphicsLayer then uses the 'contentsOpaque' setting to
determine whether to use font smoothing.

Add pageBackgroundTransparencyChanged() to DrawingArea
so that the WebPage can inform the DrawingArea when the
background transparency changes.

WebProcess/WebPage/DrawingArea.h: (WebKit::DrawingArea::pageBackgroundTransparencyChanged): (WebKit::DrawingArea::onPageClose):
WebProcess/WebPage/LayerBackedDrawingArea.cpp: (WebKit::LayerBackedDrawingArea::LayerBackedDrawingArea): (WebKit::LayerBackedDrawingArea::pageBackgroundTransparencyChanged):
WebProcess/WebPage/LayerBackedDrawingArea.h:
WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::setDrawsBackground): (WebKit::WebPage::setDrawsTransparentBackground):

3:34 PM Changeset in webkit [74151] by Simon Fraser

6 edits
1 add in trunk/WebCore

2010-12-15 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein.

Allow disabling of font smoothing in compositing layers to be overridden by style
https://bugs.webkit.org/show_bug.cgi?id=50732

Add methods to GraphicsContext to get and set font smoothing,
and have them be part of the graphics state.

Fix Font::drawGlyphs() to allow the font's smoothing mode (from style)
to override the current smoothing mode of the context. The global
shouldUseSmoothing() still has final say.

Turn off smoothing in compositing layers with this, rather than
the non-stateful 'allow' method.

manual-tests/compositing/font-smoothing.html: Added. Manual test because DRT disables font smoothing.

platform/graphics/GraphicsContext.cpp: (WebCore::GraphicsContext::setShouldSmoothFonts): (WebCore::GraphicsContext::shouldSmoothFonts): (WebCore::GraphicsContext::setPlatformShouldSmoothFonts):
platform/graphics/GraphicsContext.h: (WebCore::GraphicsContextState::GraphicsContextState):
platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::setPlatformShouldSmoothFonts):
platform/graphics/mac/FontMac.mm: (WebCore::Font::drawGlyphs):
platform/graphics/mac/WebLayer.mm: (drawLayerContents):

3:33 PM Changeset in webkit [74150] by ojan@chromium.org

3 edits in trunk/BugsSite

2010-12-15 Ojan Vafai <ojan@chromium.org>

Reviewed by Adam Barth.

fix goofups from r74142 and r74130
https://bugs.webkit.org/show_bug.cgi?id=51146

Accidentally shrank the inline comment boxes and made
the toolbar not show up when there were image diffs.

PrettyPatch/PrettyPatch.rb:
code-review.js:

3:32 PM Changeset in webkit [74149] by Adam Roben

3 edits
2 adds in trunk/WebKitTools

Teach check-webkit-style to check .vcproj and .vsprops files for XML syntax errors

Fixes <http://webkit.org/b/51103> check-webkit-style should check for
XML syntax errors in .vcproj/.vsprops files

Reviewed by Dave Levin.

Scripts/webkitpy/style/checker.py: Added lists of file extensions

that should be treated as XML and that should be allowed to contain
carriage returns. (These lists happen to be identical currently.)
(FileType): Added a new XML type.
(CheckerDispatcher.should_check_and_strip_carriage_returns): Added.
Just does a simple file extension check.
(CheckerDispatcher._file_type): Added a case for XML files.
(CheckerDispatcher._create_checker): Ditto. We use XMLChecker for XML
files (surprise!).
(StyleProcessor.process): Ask the dispatcher whether we should pass the
lines through the carriage checker.

Scripts/webkitpy/style/checker_unittest.py:

(CheckerDispatcherCarriageReturnTest.test_should_check_and_strip_carriage_returns):
Added. Checks a few file names to see if carriage returns are allowed
or not.
(CheckerDispatcherDispatchTest.assert_checker_xml): Added. Similar to
other assert_checker_* functions.
(CheckerDispatcherDispatchTest.test_xml_paths): Added. Similar to other
test_*_paths functions.
(CheckerDispatcherDispatchTest.test_xml_paths): Added. Similar to other
test_*_paths functions.
(CheckerDispatcherDispatchTest.test_none_paths): Removed the vcproj
file from this test case, as vcproj files now have a type.
(StyleProcessor_CodeCoverageTest.MockDispatcher.should_check_and_strip_carriage_returns):
Added. Similar to the other should_* functions.
(StyleProcessor_CodeCoverageTest.test_processcarriage_returns_not_stripped):
Added. Checks that carriage returns aren't checked for or stripped for
allowed files.

Scripts/webkitpy/style/checkers/xml.py: Added.

(XMLChecker.init): Simple init method.
(XMLChecker.check): Pass each line through the expat parser, and record
a style error for any errors thrown by the parser.

Scripts/webkitpy/style/checkers/xml_unittest.py: Added.

(XMLCheckerTest.assert_no_error): Checks that the given XML does not
produce a style error.
(XMLCheckerTest.assert_error): Checks that the given XML produces an
error of the given category on the given line.
(XMLCheckerTest.mock_handle_style_error): Does nothing. Used for
checking that the XMLChecker constructor works properly.
(XMLCheckerTest.test_conflict_marker): Tests that conflict markers
cause a style error (see, e.g., r73887).
(XMLCheckerTest.test_extra_closing_tag): Tests that extra closing tags
cause a style error (see, e.g., r73773).
(XMLCheckerTest.test_init): Tests that the XMLChecker constructor works
properly.
(XMLCheckerTest.test_missing_closing_tag): Tests that missing closing
tags cause a style error (see, e.g., r72795).
(XMLCheckerTest.test_no_error): Tests that valid XML does not cause a
style error.

3:26 PM Changeset in webkit [74148] by mdelaney@apple.com

2 edits in trunk/WebCore

2010-12-15 Matthew Delaney <mdelaney@apple.com>

Reviewed by Simon Fraser.

IOSurface bounds checks on bytesPerRow and allocSize are incorrect
https://bugs.webkit.org/show_bug.cgi?id=51137

No new tests added. For those using this new functionality, many current canvas layout tests will now pass.

platform/graphics/cg/ImageBufferCG.cpp:

3:12 PM Changeset in webkit [74147] by kbr@google.com

6 edits
2 adds in trunk

2010-12-15 Kenneth Russell <kbr@google.com>

Reviewed by James Robinson.

Web Audio API: port FFTFrame to MKL
https://bugs.webkit.org/show_bug.cgi?id=50986

Fixed bug in log2 emulation function provided for Windows port of
Web Audio API.

wtf/MathExtras.h: (log2):

2010-12-15 Kenneth Russell <kbr@google.com>

Reviewed by James Robinson.

Web Audio API: port FFTFrame to MKL
https://bugs.webkit.org/show_bug.cgi?id=50986

Ported FFTFrame to Intel's MKL. This patch contains the port and
initial, though not complete, build system changes. Tested so far
with a unit test by Chris Rogers (which requires code changes to
AudioContext.cpp and is not being checked in). Further testing to
follow once layout tests are available for the Web Audio API.

WebCore.gyp/WebCore.gyp:
WebCore.gypi:
platform/audio/FFTFrame.h:
platform/audio/mkl: Added.
platform/audio/mkl/FFTFrameMKL.cpp: Added. (WebCore::FFTFrame::FFTFrame): (WebCore::FFTFrame::~FFTFrame): (WebCore::FFTFrame::multiply): (WebCore::FFTFrame::doFFT): (WebCore::FFTFrame::doInverseFFT): (WebCore::FFTFrame::cleanup): (WebCore::FFTFrame::realData): (WebCore::FFTFrame::imagData): (WebCore::FFTFrame::getUpToDateComplexData): (WebCore::FFTFrame::descriptorHandleForSize):

3:10 PM Changeset in webkit [74146] by commit-queue@webkit.org

2 edits in trunk/LayoutTests

2010-12-15 Kenji Imasaki <imasaki@chromium.org>

Reviewed by David Levin.

Skip tests for unimplmented media features (aspect ratio video,
full screen, reverse-playback, video-preloading, context menu).
will enable these tests once these features are implemented.
https://bugs.webkit.org/show_bug.cgi?id=51085

platform/chromium/test_expectations.txt:

3:06 PM Changeset in webkit [74145] by commit-queue@webkit.org

4 edits
2 adds in trunk

2010-12-15 Yong Li <yoli@rim.com>

Reviewed by Darin Adler.

Reproduce stack overflow when there are too many sibling inline boxes.
https://bugs.webkit.org/show_bug.cgi?id=48255

fast/overflow/lots-of-sibling-inline-boxes.html: Added.

2010-12-15 Yong Li <yoli@rim.com>

Reviewed by Darin Adler.

Fix stack overflow when there are too many sibling inline boxes by using
a loop to traverse children instead of calling each sibling from the first child.
https://bugs.webkit.org/show_bug.cgi?id=48255

Test: fast/overflow/lots-of-sibling-inline-boxes.html

rendering/InlineBox.h: (WebCore::InlineBox::setConstructed): (WebCore::InlineBox::next):
rendering/InlineFlowBox.h: (WebCore::InlineFlowBox::setConstructed):

3:03 PM Changeset in webkit [74144] by andersca@apple.com

3 edits in trunk/WebKit2

2010-12-15 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Fix assertion in plugins/return-error-from-new-stream-callback-in-full-frame-plugin.html test
https://bugs.webkit.org/show_bug.cgi?id=51136

Ensure that a plug-in that has explicitly cancelled the manual stream won't get any more callbacks.

PluginProcess/PluginControllerProxy.cpp: (WebKit::PluginControllerProxy::PluginControllerProxy): (WebKit::PluginControllerProxy::cancelManualStreamLoad): (WebKit::PluginControllerProxy::manualStreamDidReceiveResponse): (WebKit::PluginControllerProxy::manualStreamDidReceiveData): (WebKit::PluginControllerProxy::manualStreamDidFinishLoading): (WebKit::PluginControllerProxy::manualStreamDidFail):
PluginProcess/PluginControllerProxy.h:

2:56 PM Changeset in webkit [74143] by Lucas Forschler

2 edits in trunk/WebKitTools

https://bugs.webkit.org/show_bug.cgi?id=51117
Add a new leopard test bot
really really commit to trunk this time.

Reviewed by Stephanie Lewis.

BuildSlaveSupport/build.webkit.org-config/config.json:

2:51 PM Changeset in webkit [74142] by ojan@chromium.org

3 edits in trunk/BugsSite

2010-12-14 Ojan Vafai <ojan@chromium.org>

Reviewed by Adam Barth.

add ability to view for file context to the review tool
https://bugs.webkit.org/show_bug.cgi?id=51057

At the beginning/end of each file diff and between each
hunk add links to expand the context. For now it grabs the
tip of tree version of the file and tries to apply the diff
to that file. If it can't apply, then it gives up as we
wouldn't want to show the wrong lines of context.

In the future, we can consider adding the upload svn revision
to the diff itself, then we could fallback to the file at that
revision if tip of tree doesn't apply.

PrettyPatch/PrettyPatch.rb:
code-review.js:

2:44 PM Changeset in webkit [74141] by bweinstein@apple.com

2 edits in trunk/WebKit2

Windows Build Fix. A .h file was added to the vcproj twice, but not its corresponding cpp file.

win/WebKit2.vcproj:

2:27 PM Changeset in webkit [74140] by jianli@chromium.org

2 edits in trunk/LayoutTests

Unreviewed. Updated chromium test_expectations to skip a test that
causes DRT to crash in dbg mode.

platform/chromium/test_expectations.txt:

1:52 PM Changeset in webkit [74139] by weinig@apple.com

27 edits
10 adds in trunk

WebKit2: Can't add files to an <input type=file>
https://bugs.webkit.org/show_bug.cgi?id=51087

Reviewed by Anders Carlsson.

WebCore:

Add exported function.

WebCore.exp.in:

WebKit2:

Scripts/webkit2/messages.py:

Adds new types.

Shared/API/c/WKBase.h:

Adds WKOpenPanelParametersRef and WKOpenPanelResultListenerRef.

Shared/APIObject.h:

Adds TypeOpenPanelParameters and TypeOpenPanelResultListener.

Shared/WebOpenPanelParameters.cpp: Added.

(WebKit::WebOpenPanelParameters::create):
(WebKit::WebOpenPanelParameters::WebOpenPanelParameters):
(WebKit::WebOpenPanelParameters::~WebOpenPanelParameters):
(WebKit::WebOpenPanelParameters::Data::encode):
(WebKit::WebOpenPanelParameters::Data::decode):

Shared/WebOpenPanelParameters.h: Added.

(WebKit::WebOpenPanelParameters::allowMultipleFiles):
(WebKit::WebOpenPanelParameters::type):
Class representing options one can pass to open panel.

UIProcess/API/C/WKAPICast.h:

Add casts for WebOpenPanelParameters and WebOpenPanelResultListenerProxy.

UIProcess/API/C/WKOpenPanelParameters.cpp: Added.

(WKOpenPanelParametersGetTypeID):
(WKOpenPanelParametersGetAllowsMultipleFiles):

UIProcess/API/C/WKOpenPanelParameters.h: Added.
UIProcess/API/C/WKOpenPanelResultListener.cpp: Added.

(WKOpenPanelResultListenerGetTypeID):
(WKOpenPanelResultListenerChooseFiles):
(WKOpenPanelResultListenerCancel):

UIProcess/API/C/WKOpenPanelResultListener.h: Added.

Add API wrappers.

UIProcess/API/C/WKPage.h:

Add new UI callback, WKPageRunOpenPanelCallback.

UIProcess/API/C/WebKit2.h:

Add includes for new API headers.

UIProcess/API/qt/qwkpage.cpp:

(QWKPage::QWKPage):
Stub out the runOpenPanel callback.

UIProcess/WebOpenPanelResultListenerProxy.cpp: Added.

(WebKit::WebOpenPanelResultListenerProxy::WebOpenPanelResultListenerProxy):
(WebKit::WebOpenPanelResultListenerProxy::~WebOpenPanelResultListenerProxy):
(WebKit::WebOpenPanelResultListenerProxy::chooseFiles):
(WebKit::WebOpenPanelResultListenerProxy::cancel):
(WebKit::WebOpenPanelResultListenerProxy::invalidate):

UIProcess/WebOpenPanelResultListenerProxy.h: Added.

(WebKit::WebOpenPanelResultListenerProxy::create):
(WebKit::WebOpenPanelResultListenerProxy::type):
Adds the listener used to choose files for <input type=file>

UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::runOpenPanel):
(WebKit::WebPageProxy::didChooseFilesForOpenPanel):
(WebKit::WebPageProxy::didCancelForOpenPanel):

UIProcess/WebPageProxy.h:
UIProcess/WebPageProxy.messages.in:
UIProcess/WebUIClient.cpp:

(WebKit::WebUIClient::runOpenPanel):

UIProcess/WebUIClient.h:
WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::runOpenPanel):

WebProcess/WebPage/WebOpenPanelResultListener.cpp: Added.

(WebKit::WebOpenPanelResultListener::create):
(WebKit::WebOpenPanelResultListener::WebOpenPanelResultListener):
(WebKit::WebOpenPanelResultListener::~WebOpenPanelResultListener):
(WebKit::WebOpenPanelResultListener::didChooseFiles):

WebProcess/WebPage/WebOpenPanelResultListener.h: Added.

(WebKit::WebOpenPanelResultListener::disconnectFromPage):

WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::close):
(WebKit::WebPage::setActiveOpenPanelResultListener):
(WebKit::WebPage::didChooseFilesForOpenPanel):
(WebKit::WebPage::didCancelForOpenPanel):

WebProcess/WebPage/WebPage.h:

(WebKit::WebPage::activeOpenPanelResultListener):

WebProcess/WebPage/WebPage.messages.in:

Pipe through file choosing.

WebKit2.pro:
WebKit2.xcodeproj/project.pbxproj:
win/WebKit2.vcproj:
win/WebKit2Generated.make:

Add new files.

WebKitTools:

MiniBrowser/mac/BrowserWindowController.m:

(runOpenPanel):
(-[BrowserWindowController awakeFromNib]):
Add simple implementation of runOpenPanel callback.

MiniBrowser/win/BrowserView.cpp:

(BrowserView::create):

WebKitTestRunner/TestController.cpp:

(WTR::createOtherPage):
(WTR::TestController::initialize):
Stub out runOpenPanel callback.

1:48 PM Changeset in webkit [74138] by eric@webkit.org

12 edits in trunk/WebKitTools

2010-12-14 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

commit-queue should upload failure diffs when tests flake
https://bugs.webkit.org/show_bug.cgi?id=51051

To make this testable I needed to pipe FileSystem down onto tool.
We've wanted it there for a long time anyway.

This patch is kinda a big hack. But we don't have a nice
way to read results.html files. I think this will need further
revision before this code actually feels clean.

As part of testing this change, I had to make MockBugzilla.create_bug
actually return an id (like it should) which required updating
a few other unit test results (for the better).

The results_matching_keys change in layouttestresults/rebasline
was an alternate path which I decided not to use in the end, but
I left the change as it seemed an improvement.

Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
Scripts/webkitpy/common/net/layouttestresults.py:
Scripts/webkitpy/tool/bot/flakytestreporter.py:
Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
Scripts/webkitpy/tool/commands/queues.py:
Scripts/webkitpy/tool/commands/rebaseline.py:
Scripts/webkitpy/tool/main.py:
Scripts/webkitpy/tool/mocktool.py:

1:00 PM Changeset in webkit [74137] by andreas.kling@nokia.com

2 edits in trunk/WebCore

2010-12-15 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Antonio Gomes.

[Qt] screenIsMonochrome() is broken
https://bugs.webkit.org/show_bug.cgi?id=49957

platform/qt/PlatformScreenQt.cpp: (WebCore::screenIsMonochrome):

12:39 PM Changeset in webkit [74136] by commit-queue@webkit.org

4 edits in trunk/WebKitTools

2010-12-15 Cosmin Truta <ctruta@chromium.org>

Reviewed by James Robinson.

new-run-webkit-tests ignores trailing EOL differences in text tests
https://bugs.webkit.org/show_bug.cgi?id=36983

Changed the handling of new-line characters within new-run-webkit-tests
to match old-run-webkit-tests. Differences in leading and trailing empty
lines in text expectation files are no longer ignored.

Scripts/webkitpy/layout_tests/port/base.py:
Scripts/webkitpy/layout_tests/port/test.py: Added unit tests. Removed old duplicate unit test entries.
Scripts/webkitpy/layout_tests/test_types/text_diff.py:

12:26 PM Changeset in webkit [74135] by ojan@chromium.org

2 edits in trunk/WebKitTools

2010-12-15 Ojan Vafai <ojan@chromium.org>

Reviewed by Adam Barth.

have the statusbubble postMessage it's metrics so that embedders can properly size the iframe
https://bugs.webkit.org/show_bug.cgi?id=51125

QueueStatusServer/templates/statusbubble.html:

12:15 PM Changeset in webkit [74134] by andersca@apple.com

4 edits in trunk/WebKit2

2010-12-15 Anders Carlsson <andersca@apple.com>

Reviewed by Maciej Stachowiak.

Semi-reproducible crash in ChunkedUpdateDrawingArea::paintIntoUpdateChunk closing a particular yahoo page
https://bugs.webkit.org/show_bug.cgi?id=51126
<rdar://problem/8771219>

Laying out the web page can cause the drawing area to change so we need to protect against this.

WebProcess/WebPage/ChunkedUpdateDrawingArea.cpp: (WebKit::ChunkedUpdateDrawingArea::display):
WebProcess/WebPage/LayerBackedDrawingArea.cpp: (WebKit::LayerBackedDrawingArea::display):
WebProcess/WebPage/mac/LayerBackedDrawingAreaMac.mm: (WebKit::LayerBackedDrawingArea::updateLayoutRunLoopObserverFired):

11:58 AM Changeset in webkit [74133] by jianli@chromium.org

2 edits in trunk/LayoutTests

Unreviewed. Mark a failed test in chromium test expectations.

platform/chromium/test_expectations.txt:

11:39 AM Changeset in webkit [74132] by Martin Robinson

2 edits in trunk/WebCore

2010-12-15 Martin Robinson <mrobinson@igalia.com>

Reviewed by Gustavo Noronha Silva.

[GTK] Move button rendering from gtk{2,3}drawing.cpp to RenderThemeGtk
https://bugs.webkit.org/show_bug.cgi?id=48486

Implement button rendering in RenderThemeGtk. The implementation
from gtk{2,3}drawing.cpp will be removed once menu list button rendering
is implemented in RenderThemeGtk as well.

No new tests, as this should not change functionality.

platform/gtk/RenderThemeGtk.cpp: (WebCore::RenderThemeGtk::paintButton): Add an implementation of button rendering that uses WidgetRenderingContext.

11:34 AM Changeset in webkit [74131] by bweinstein@apple.com

6 edits in trunk/WebKit2

WebKit2: WebPageWin needs implementations of hasLocalDataForURL and canHandleRequest
https://bugs.webkit.org/show_bug.cgi?id=51090

Reviewed by Adam Roben.

Implement these functions for WebKit2 on Windows.

WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::hasLocalDataForURL): Does the cross-platform part of the check for having local

data (file URL or subresource), then calls platformHasLocalDataForURL to let the platform do
their specific checks.

WebProcess/WebPage/WebPage.h:
WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::WebPage::platformHasLocalDataForURL): Moved the cross-platform code from here to WebPage::hasLocalDataForURL.

WebProcess/WebPage/qt/WebPageQt.cpp:

(WebKit::WebPage::platformHasLocalDataForURL): Renamed from hasLocalDataForURL.

WebProcess/WebPage/win/WebPageWin.cpp:

(WebKit::WebPage::platformHasLocalDataForURL): Renamed from hasLocalDataForURL and implemented with CFNetwork calls. This is the

CFNetwork equivalent of the code in WebPageMac::platformHasLocalDataForURL.

(WebKit::WebPage::canHandleRequest): Copied the line of code from WebView::canHandleRequest in WebKit1, with a FIXME saying

this might not be enough (although it was in WebKit1 on Windows).

11:33 AM Changeset in webkit [74130] by ojan@chromium.org

3 edits in trunk/BugsSite

2010-12-08 Ojan Vafai <ojan@chromium.org>

Reviewed by Adam Barth.

[reviewtool] should always show overall comments text box
https://bugs.webkit.org/show_bug.cgi?id=45870

PrettyPatch/PrettyPatch.rb:
code-review.js:

11:22 AM QtWebKitRelease22 edited by Ademar Reis

(diff)

11:19 AM Changeset in webkit [74129] by Martin Robinson

9 edits in trunk/WebCore

2010-10-18 Martin Robinson <mrobinson@igalia.com>

Reviewed by Gustavo Noronha Silva.

[GTK] Move input type=range rendering to RenderThemeGtk
https://bugs.webkit.org/show_bug.cgi?id=47836

Begin moving widget rendering out of the old Mozilla theme drawing code,
which should remove many lines of code when completed. WidgetRenderingContext
now hides the GTK+ 2 vs. 3 API differences, so that RenderThemeGtk can stay
version agnostic.

No new tests as this patch does not change functionality.

platform/gtk/RenderThemeGtk.cpp: (WebCore::RenderThemeGtk::RenderThemeGtk): gtkContainer() now returns a GtkWidget, so update the cast here. (WebCore::RenderThemeGtk::getGtkStateType): Added this helper which converts a RenderObject state into a GtkStateType. (WebCore::RenderThemeGtk::paintRenderObject): Removed work-arounds for scale painting, as it's not handled by this method any longer. (WebCore::RenderThemeGtk::paintSliderTrack): Updated to use WidgetRenderingContext. (WebCore::RenderThemeGtk::paintSliderThumb): Ditto. (WebCore::RenderThemeGtk::adjustSliderThumbSize): Get the size properties directly from the widget now instead of asking the Mozilla code. (WebCore::RenderThemeGtk::setupWidgetAndAddToContainer): Added this helper which reduces the amount of code quite a bit. (WebCore::RenderThemeGtk::gtkContainer): Updated to use helper. (WebCore::RenderThemeGtk::gtkButton): Ditto. (WebCore::RenderThemeGtk::gtkEntry): Ditto. (WebCore::RenderThemeGtk::gtkTreeView): Ditto. (WebCore::RenderThemeGtk::gtkVScale): Added. (WebCore::RenderThemeGtk::gtkHScale): Added. (WebCore::RenderThemeGtk::platformColorsDidChange): Removed GTK_CONTAINER cast.
platform/gtk/RenderThemeGtk.h: Updated to add new GtkHScale and GtkVScale members.
platform/gtk/WidgetRenderingContext.h: Aded new methods to proxy gtk_paint_box, gtk_paint_focus and gtk_paint_slider.
platform/gtk/WidgetRenderingContextGtk2.cpp: (WebCore::WidgetRenderingContext::gtkPaintBox): Added. (WebCore::WidgetRenderingContext::gtkPaintFocus): Ditto. (WebCore::WidgetRenderingContext::gtkPaintSlider): Ditto.
platform/gtk/WidgetRenderingContextGtk3.cpp: (WebCore::WidgetRenderingContext::gtkPaintBox): Ditto. (WebCore::WidgetRenderingContext::gtkPaintFocus): Ditto. (WebCore::WidgetRenderingContext::gtkPaintSlider): Ditto.
platform/gtk/gtk2drawing.c: Removed defunct code! (moz_gtk_get_widget_border): (moz_gtk_widget_paint):
platform/gtk/gtk3drawing.c: Ditto. (moz_gtk_get_widget_border): (moz_gtk_widget_paint):
platform/gtk/gtkdrawing.h:

10:59 AM Changeset in webkit [74128] by Darin Adler

2 edits in trunk/WebKitTools

Scripts/webkitpy/common/net/buildbot: Added property svn:ignore.

10:59 AM Changeset in webkit [74127] by antonm@chromium.org

2 edits in trunk/LayoutTests

Unreviewed. Removing another two suppressions for CSS entities garbage collection.

platform/chromium/test_expectations.txt:

10:57 AM Changeset in webkit [74126] by podivilov@chromium.org

2 edits in trunk/LayoutTests

2010-12-15 Pavel Podivilov <podivilov@chromium.org>

Unreviewed, build fix for r74119.

Fix debugger tests.

http/tests/inspector/debugger-test2.js: (initialize_DebuggerTest.InspectorTest.captureStackTrace):

10:51 AM Changeset in webkit [74125] by antonm@chromium.org

2 edits in trunk/LayoutTests

Unreviewed. Adjusting v8-dependent test expectations.

platform/chromium/test_expectations.txt:

10:49 AM Changeset in webkit [74124] by Martin Robinson

13 edits
2 deletes in trunk

2010-12-15 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r74117.
http://trac.webkit.org/changeset/74117
https://bugs.webkit.org/show_bug.cgi?id=51113

This broke the GTK1 build. (Requested by mrobinson on
#webkit).

GNUmakefile.am:
configure.ac:

2010-12-15 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r74117.
http://trac.webkit.org/changeset/74117
https://bugs.webkit.org/show_bug.cgi?id=51113

This broke the GTK1 build. (Requested by mrobinson on
#webkit).

GNUmakefile.am:
platform/network/soup/cache/webkit/soup-cache.h:

2010-12-15 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r74117.
http://trac.webkit.org/changeset/74117
https://bugs.webkit.org/show_bug.cgi?id=51113

This broke the GTK1 build. (Requested by mrobinson on
#webkit).

GNUmakefile.am:

2010-12-15 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r74117.
http://trac.webkit.org/changeset/74117
https://bugs.webkit.org/show_bug.cgi?id=51113

This broke the GTK1 build. (Requested by mrobinson on
#webkit).

GNUmakefile.am: Removed.
Scripts/generate-forwarding-headers.pl:
WebKit2Prefix.h:
gtk/webkit2.pc.in: Removed.

2010-12-15 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r74117.
http://trac.webkit.org/changeset/74117
https://bugs.webkit.org/show_bug.cgi?id=51113

This broke the GTK1 build. (Requested by mrobinson on
#webkit).

Scripts/webkitdirs.pm:

10:35 AM Changeset in webkit [74123] by Stephanie Lewis

2 edits in /

https://bugs.webkit.org/show_bug.cgi?id=51117
Add a new leopard WK2 test bot

Reviewed by Stephanie Lewis.

BuildSlaveSupport/build.webkit.org-config/config.json:

10:16 AM Changeset in webkit [74122] by jianli@chromium.org

2 edits in trunk/WebCore

Unreviewed. Fixed a clang compiling error by making the forward
declaration of MediaPlayerFactory be consistent with the definition.

platform/graphics/MediaPlayer.h:

10:10 AM Changeset in webkit [74121] by hyatt@apple.com

9 edits in trunk/WebCore

Rename pageY to pageLogicalOffset, since for vertical writing modes it is an x-position rather than a
y-position.

Reviewed by Simon Fraser.

rendering/LayoutState.cpp:

(WebCore::LayoutState::pageLogicalOffset):
(WebCore::LayoutState::addForcedColumnBreak):

rendering/LayoutState.h:
rendering/RenderBlock.cpp:

(WebCore::RenderBlock::layoutBlock):
(WebCore::RenderBlock::markForPaginationRelayoutIfNeeded):
(WebCore::RenderBlock::layoutColumns):
(WebCore::RenderBlock::setPageLogicalOffset):

rendering/RenderBlock.h:

(WebCore::RenderBlock::pageLogicalOffset):
(WebCore::RenderBlock::RenderBlockRareData::RenderBlockRareData):

rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::layoutBlock):

rendering/RenderTable.cpp:

(WebCore::RenderTable::layout):

rendering/RenderTableRow.cpp:

(WebCore::RenderTableRow::layout):

rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::layoutRows):

10:05 AM Changeset in webkit [74120] by yurys@chromium.org

2 edits in trunk/LayoutTests

2010-12-15 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Update Chromium test expectations.

platform/chromium/test_expectations.txt:

9:36 AM Changeset in webkit [74119] by podivilov@chromium.org

9 edits in trunk/WebCore

2010-12-13 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: move scripts storage from ScriptsPanel to DebuggerModel.
https://bugs.webkit.org/show_bug.cgi?id=50908

inspector/front-end/BreakpointManager.js: (WebInspector.BreakpointManager): (WebInspector.BreakpointManager.prototype._debuggerPaused):
inspector/front-end/CallStackSidebarPane.js: (WebInspector.CallStackSidebarPane): (WebInspector.CallStackSidebarPane.prototype.update):
inspector/front-end/DebuggerModel.js: (WebInspector.DebuggerModel): (WebInspector.DebuggerModel.prototype.setBreakpoint): (WebInspector.DebuggerModel.prototype._setBreakpoint): (WebInspector.DebuggerModel.prototype.scriptForSourceID): (WebInspector.DebuggerModel.prototype.scriptsForURL): (WebInspector.DebuggerModel.prototype.queryScripts): (WebInspector.DebuggerModel.prototype.parsedScriptSource): (WebInspector.DebuggerModel.prototype.failedToParseScriptSource): (WebInspector.DebuggerModel.prototype.breakpointRestored): (WebInspector.DebuggerModel.prototype.debuggerPaused): (WebInspector.DebuggerModel.prototype.debuggerResumed):
inspector/front-end/Resource.js:
inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel): eliminate sourceIDMap
inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype._createViewerIfNeeded): (WebInspector.SourceFrame.prototype._setBreakpoint):
inspector/front-end/SourceView.js: (WebInspector.SourceView):
inspector/front-end/inspector.js: (WebInspector.createJSBreakpointsSidebarPane): (WebInspector.parsedScriptSource): (WebInspector.failedToParseScriptSource):

9:27 AM Changeset in webkit [74118] by eric.carlson@apple.com

3 edits in trunk/WebCore

2010-12-15 Eric Carlson <eric.carlson@apple.com>

Reviewed by Darin Adler.

MediaPlayer should try all installed media engines
https://bugs.webkit.org/show_bug.cgi?id=50209

platform/graphics/MediaPlayer.cpp: (WebCore::bestMediaEngineForTypeAndCodecs): Rename from chooseBestEngineForTypeAndCodecs. Take optional parameter for current engine. (WebCore::nextMediaEngine): New, return the next media engine in the list. (WebCore::MediaPlayer::MediaPlayer): Initialize reload timer. (WebCore::MediaPlayer::load): Store url, mime type, and codecs parameter in member variables. (WebCore::MediaPlayer::loadWithNextMediaEngine): New, initiate loading with the next media engine. (WebCore::MediaPlayer::supportsType): Make contentType parameter const. (WebCore::MediaPlayer::reloadTimerFired): New, call loadWithNextMediaEngine. (WebCore::MediaPlayer::networkStateChanged): If network state signals a failure and the file's metadata has not loaded, give the next installed engine a try.
platform/graphics/MediaPlayer.h:

9:10 AM BuildingGtk edited by Martin Robinson

Made required build steps more prominant (diff)

8:51 AM Changeset in webkit [74117] by commit-queue@webkit.org

13 edits
3 adds in trunk

2010-12-15 Amruth Raj <amruthraj@motorola.com> and Ravi Kasibhatla <ravi.kasibhatla@motorola.com>

Reviewed by Martin Robinson.

Changes to enable building WebKit2 for Gtk port.
(https://bugs.webkit.org/show_bug.cgi?id=37369)

GNUmakefile.am: Changes to build either of WebKit1 or WebKit2. It basically excludes all WebKit/gtk/webkit/ files when building WebKit2. Also, exludes Unittests, DumprenderTree, GtkLauncher etc for WebKit2.
configure.ac: Option for enable or disable WebKit2.

2010-12-15 Amruth Raj <amruthraj@motorola.com> and Ravi Kasibhatla <ravi.kasibhatla@motorola.com>

Reviewed by Martin Robinson.

Changes to enable building WebKit2 for Gtk port
(https://bugs.webkit.org/show_bug.cgi?id=37369)

No new functionality added or deleted. Only makefile change. Hence, no tests added.

GNUmakefile.am: Removed bindings/gobject from webcore_sources & webcore_cppflags and added them to WebKit/gtk/GNUmakefile.am
platform/network/soup/cache/webkit/soup-cache.h: Remove include <webkit/webkitdefines.h> and declare WEBKIT_API directly

2010-12-15 Amruth Raj <amruthraj@motorola.com> and Ravi Phaneendra Kasibhatla <ravi.kasibhatla@motorola.com>

Reviewed by Martin Robinson.

Changes to enable building WebKit2 for Gtk port.
(https://bugs.webkit.org/show_bug.cgi?id=37369)

GNUmakefile.am: Added WebCore/bindings/gobject to webkitgtk_sources & webkitgtk_cppflags. They should get compiled only when WebKit/gtk/GNUmakefile.am is getting included but not with WebKit2/GNUmakefile.am inclusion.

2010-12-15 Amruth Raj <amruthraj@motorola.com> and Ravi Kasibhatla <ravi.kasibhatla@motorola.com>

Reviewed by Martin Robinson.

Changes to enable building WebKit2 for Gtk port.
(https://bugs.webkit.org/show_bug.cgi?id=37369)

GNUmakefile.am: Added.
Scripts/generate-forwarding-headers.pl: For GTK port, taking 1 extra argument for copying network headers.
WebKit2Prefix.h: Included WebCore/config.h for GTK port as the first header file for WebKit2 sources files.
gtk: Added.
gtk/webkit2.pc.in: Added.

2010-12-15 Amruth Raj <amruthraj@motorola.com> and Ravi Kasibhatla <ravi.kasibhatla@motorola.com>

Reviewed by Martin Robinson.

Change generate-forwarding-headers.pl for GTK port usage
(https://bugs.webkit.org/show_bug.cgi?id=37369)

Scripts/webkitdirs.pm: Added changes to build webkit2 for GTK port using build-webkit script.

8:13 AM Changeset in webkit [74116] by yurys@chromium.org

2 edits
2 deletes in trunk/LayoutTests

2010-12-15 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Update Chromium test expectations.

platform/chromium-mac/storage/private-browsing-noread-nowrite-expected.txt: Removed.
platform/chromium-win/storage/private-browsing-noread-nowrite-expected.txt: Removed.
platform/chromium/test_expectations.txt: test private-browsing-readonly.html was renamed into private-browsing-noread-nowrite.html in r74093, changing expecations accrodingly.

8:00 AM Changeset in webkit [74115] by commit-queue@webkit.org

10 edits in trunk

2010-12-15 Jarred Nicholls <jarred@sencha.com>

Reviewed by Andreas Kling.

[Qt] Implement the File API spec
https://bugs.webkit.org/show_bug.cgi?id=49839

platform/qt/fast/dom/Window/window-properties-expected.txt:
platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:
platform/qt/fast/dom/prototype-inheritance-expected.txt:
platform/qt/fast/js/global-constructors-expected.txt:

2010-12-15 Jarred Nicholls <jarred@sencha.com>

Reviewed by Andreas Kling.

[Qt] Implement the File API spec
https://bugs.webkit.org/show_bug.cgi?id=49839

No new tests. fast/files tests work when manually operated.
They do not automatically work due to Qt's inability to handle multi-file
inputs (https://bugs.webkit.org/show_bug.cgi?id=22048) as well as Qt's DRT
is missing an eventSender.beginDragWithFiles implementation.

WebCore.pri:
WebCore.pro:
features.pri:
platform/qt/FileSystemQt.cpp: (WebCore::directoryName): (WebCore::readFromFile): (WebCore::seekFile):

6:31 AM Changeset in webkit [74114] by yurys@chromium.org

10 edits
9 adds in trunk/LayoutTests

2010-12-15 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Rebaseline Chromium tests.

platform/chromium-linux/fast/blockflow/japanese-rl-text-with-broken-font-expected.txt: Added.
platform/chromium-linux/fast/box-shadow/inset-expected.checksum:
platform/chromium-linux/fast/box-shadow/inset-expected.png:
platform/chromium-linux/fast/css/focus-ring-detached-expected.checksum: Added.
platform/chromium-linux/fast/css/focus-ring-detached-expected.png: Added.
platform/chromium-linux/fast/css/focus-ring-multiline-expected.checksum: Added.
platform/chromium-linux/fast/css/focus-ring-multiline-expected.png: Added.
platform/chromium-mac/fast/css/focus-ring-detached-expected.checksum: Added.
platform/chromium-mac/fast/css/focus-ring-detached-expected.png: Added.
platform/chromium-mac/fast/css/focus-ring-multiline-expected.checksum: Added.
platform/chromium-mac/fast/css/focus-ring-multiline-expected.png: Added.
platform/chromium-win/fast/css/focus-ring-detached-expected.checksum:
platform/chromium-win/fast/css/focus-ring-detached-expected.png:
platform/chromium-win/fast/css/focus-ring-detached-expected.txt:
platform/chromium-win/fast/css/focus-ring-multiline-expected.checksum:
platform/chromium-win/fast/css/focus-ring-multiline-expected.png:
platform/chromium-win/fast/css/focus-ring-multiline-expected.txt:
platform/chromium/test_expectations.txt:

5:47 AM Changeset in webkit [74113] by yurys@chromium.org

2 edits in trunk/LayoutTests

2010-12-15 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Mark fast/dom/global-constructors.html as flaky on Chromium.

platform/chromium/test_expectations.txt:

5:38 AM Changeset in webkit [74112] by sergio@webkit.org

2 edits in trunk/LayoutTests

2010-12-15 Sergio Villar Senin <svillar@igalia.com>

Unreviewed, skipping failing tests in the bots.

[GTK] HTTP tests failing/crashing in the bots
https://bugs.webkit.org/show_bug.cgi?id=51104

platform/gtk/Skipped:

5:14 AM Changeset in webkit [74111] by yurys@chromium.org

2 edits in trunk/LayoutTests

2010-12-15 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Mark one more compositing test as timing out on chromium-gpu.

platform/chromium-gpu/test_expectations.txt:

4:52 AM Changeset in webkit [74110] by yurys@chromium.org

13 edits
9 adds in trunk/LayoutTests

2010-12-15 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Rebaseline Chromium test expectations.

platform/chromium-linux/fast/blockflow/box-shadow-horizontal-bt-expected.checksum:
platform/chromium-linux/fast/blockflow/box-shadow-horizontal-bt-expected.png:
platform/chromium-linux/fast/blockflow/box-shadow-vertical-lr-expected.checksum:
platform/chromium-linux/fast/blockflow/box-shadow-vertical-lr-expected.png:
platform/chromium-linux/fast/blockflow/box-shadow-vertical-rl-expected.checksum:
platform/chromium-linux/fast/blockflow/box-shadow-vertical-rl-expected.png:
platform/chromium-linux/fast/blockflow/japanese-rl-text-with-broken-font-expected.checksum: Added.
platform/chromium-linux/fast/blockflow/japanese-rl-text-with-broken-font-expected.png: Added.
platform/chromium-mac/http/tests/misc/authentication-sent-to-redirect-expected.txt: Added.
platform/chromium-mac/storage/private-browsing-noread-nowrite-expected.txt: Added.
platform/chromium-win/fast/blockflow/box-shadow-horizontal-bt-expected.checksum:
platform/chromium-win/fast/blockflow/box-shadow-horizontal-bt-expected.png:
platform/chromium-win/fast/blockflow/box-shadow-vertical-lr-expected.checksum:
platform/chromium-win/fast/blockflow/box-shadow-vertical-lr-expected.png:
platform/chromium-win/fast/blockflow/box-shadow-vertical-rl-expected.checksum:
platform/chromium-win/fast/blockflow/box-shadow-vertical-rl-expected.png:
platform/chromium-win/fast/blockflow/japanese-rl-text-with-broken-font-expected.checksum: Added.
platform/chromium-win/fast/blockflow/japanese-rl-text-with-broken-font-expected.png: Added.
platform/chromium-win/fast/blockflow/japanese-rl-text-with-broken-font-expected.txt: Added.
platform/chromium-win/http/tests/misc/authentication-sent-to-redirect-expected.txt: Added.
platform/chromium-win/storage/private-browsing-noread-nowrite-expected.txt: Added.

4:43 AM Changeset in webkit [74109] by podivilov@chromium.org

2 edits in trunk/LayoutTests

2010-12-15 Pavel Podivilov <podivilov@chromium.org>

Unreviewed, fix for r74103.

Fix dom-breakpoints test.

inspector/dom-breakpoints.html:

4:34 AM Changeset in webkit [74108] by commit-queue@webkit.org

2 edits in trunk/WebKit2

2010-12-15 Jan Erik Hanssen <jhanssen@sencha.com>

Reviewed by Andreas Kling.

[Qt][WK2] webkit2 does not compile on OS X
https://bugs.webkit.org/show_bug.cgi?id=50128

prctl(2) is only available on Linux, so use an atexit handler for killing
all the child processes when the process is exiting.

UIProcess/Launcher/qt/ProcessLauncherQt.cpp: (WebKit::cleanupProcesses): (WebKit::QtWebProcess::QtWebProcess): (WebKit::QtWebProcess::processStateChanged): (WebKit::ProcessLauncherHelper::instance):

3:27 AM Changeset in webkit [74107] by Antti Koivisto

9 edits
2 adds in trunk

WebCore: https://bugs.webkit.org/show_bug.cgi?id=49548
WebCore cache stores duplicate copies of subresources with URL fragments

Reviewed by Alexey Proskuryakov.

Strip fragment identifiers from HTTP and file URLs for the memory cache.
Changed some CachedResourceLoader and MemoryCache interfaces to use KURLs instead of strings to reduce repeated URL parsing.

Test: http/tests/cache/subresource-fragment-identifier.html

inspector/InspectorResourceAgent.cpp:

(WebCore::InspectorResourceAgent::cachedResource):

loader/FrameLoader.cpp:

(WebCore::FrameLoader::tellClientAboutPastMemoryCacheLoads):

loader/cache/CachedResource.cpp:

(WebCore::CachedResource::~CachedResource):

loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::cachedResource):
(WebCore::CachedResourceLoader::checkForReload):
(WebCore::CachedResourceLoader::requestUserCSSStyleSheet):
(WebCore::CachedResourceLoader::requestResource):

loader/cache/CachedResourceLoader.h:
loader/cache/MemoryCache.cpp:

(WebCore::MemoryCache::requestResource):
(WebCore::MemoryCache::requestUserCSSStyleSheet):
(WebCore::MemoryCache::removeFragmentIdentifierIfNeeded):
(WebCore::MemoryCache::resourceForURL):

loader/cache/MemoryCache.h:

LayoutTests: https://bugs.webkit.org/show_bug.cgi?id=49548
WebCore cache stores duplicate copies of subresources with URL fragments

Reviewed by Alexey Proskuryakov.

http/tests/cache/subresource-fragment-identifier-expected.txt: Added.
http/tests/cache/subresource-fragment-identifier.html: Added.

2:57 AM Changeset in webkit [74106] by antonm@chromium.org

2 edits in trunk/WebCore

2010-12-15 Anton Muhin <antonm@chromium.org>

Reviewed by David Levin.

[v8] Next round of CSS GC story: proper grouping of CSSStyleDeclarations
https://bugs.webkit.org/show_bug.cgi?id=50965

bindings/v8/V8GCController.cpp: (WebCore::DOMObjectGrouperVisitor::visitDOMWrapper): (WebCore::DOMObjectGrouperVisitor::addAllItems):

2:49 AM Changeset in webkit [74105] by commit-queue@webkit.org

1 edit in trunk/ChangeLog

2010-12-14 Commit Queue <commit-queue@webkit.org>

Unreviewed. Test commit for commit-queue@webkit.org.

2:40 AM Changeset in webkit [74104] by commit-queue@webkit.org

1 edit in trunk/ChangeLog

2010-12-14 Commit Queue <commit-queue@webkit.org>

Unreviewed. Test commit for commit-queue@webkit.org.

2:39 AM Changeset in webkit [74103] by podivilov@chromium.org

13 edits in trunk/WebCore

2010-12-13 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: push persistent breakpoints into backend state cookie so they hit on navigation.
https://bugs.webkit.org/show_bug.cgi?id=48858

BreakpointManager pushes all persistent breakpoints to backend when loaded.
InspectorController restores sticky breakpoints from cookie on navigation.

inspector/Inspector.idl:
inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController): (WebCore::InspectorController::disconnectFrontend): (WebCore::InspectorController::didCommitLoad): (WebCore::InspectorController::setStickyBreakpoints): (WebCore::InspectorController::restoreStickyBreakpoints): (WebCore::InspectorController::restoreStickyBreakpoint):
inspector/InspectorController.h:
inspector/InspectorState.cpp: (WebCore::InspectorState::InspectorState): (WebCore::InspectorState::getObject): (WebCore::InspectorState::setObject): (WebCore::InspectorState::registerObject):
inspector/InspectorState.h:
inspector/front-end/BreakpointManager.js: (WebInspector.BreakpointManager):
inspector/front-end/BreakpointsSidebarPane.js: (WebInspector.BreakpointsSidebarPane): (WebInspector.BreakpointsSidebarPane.prototype._removeListElement): (WebInspector.BreakpointsSidebarPane.prototype._projectChanged): (WebInspector.EventListenerBreakpointsSidebarPane): (WebInspector.EventListenerBreakpointsSidebarPane.prototype._createCategory): (WebInspector.EventListenerBreakpointsSidebarPane.prototype._breakpointAdded): (WebInspector.EventListenerBreakpointsSidebarPane.prototype._projectChanged):
inspector/front-end/CallStackSidebarPane.js: (WebInspector.CallStackSidebarPane):
inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel.prototype.reset):
inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype.reset):
inspector/front-end/Settings.js: (WebInspector.Settings.prototype.inspectedURLChanged): (WebInspector.Settings.prototype.get projectId): (WebInspector.Settings.prototype.findSettingForAllProjects): (WebInspector.Settings.prototype._formatProjectKey):
inspector/front-end/inspector.js: (WebInspector.createDOMBreakpointsSidebarPane): (WebInspector.createXHRBreakpointsSidebarPane): (WebInspector.reset): (WebInspector.inspectedURLChanged):

2:24 AM Changeset in webkit [74102] by mario@webkit.org

2 edits in trunk/WebCore

2010-12-15 Mario Sanchez Prada <msanchez@igalia.com>

Unreviewed, fix compilation warnings after r74066.

rendering/RenderBox.cpp: (WebCore::layersUseImage): Place this static function between the same if-def region used in the only place where it's called from.

1:47 AM Changeset in webkit [74101] by commit-queue@webkit.org

3 edits
2 adds in trunk

2010-12-15 Emil Eklund <eae@chromium.org>

Reviewed by Adam Barth.

Added test for infinite loop in ContainerNode::willRemoveChildren.
https://bugs.webkit.org/show_bug.cgi?id=51079

fast/dom/containerNode-expected.txt: Added.
fast/dom/containerNode.html: Added.

2010-12-15 Emil Eklund <eae@chromium.org>

Reviewed by Adam Barth.

Change ContainerNode::willRemoveChildren to not fire mutation events for children
added as a result of a mutation event, thereby avoiding an infinite loop.
https://bugs.webkit.org/show_bug.cgi?id=51079

Test: fast/dom/containerNode.html

dom/ContainerNode.cpp: (WebCore::willRemoveChildren): Don't fire mutation events for children added during a mutation event.

12:10 AM Changeset in webkit [74100] by Csaba Osztrogonác

2 edits
1 copy in trunk/LayoutTests

Unreviewed.

platform/qt/Skipped: Add http/tests/misc/authentication-sent-to-redirect.html because of missing layoutTestController.setHandlesAuthenticationChallenges()
platform/qt/plugins/document-open-expected.txt: Copied from LayoutTests/plugins/document-open-expected.txt.

Dec 14, 2010:

11:10 PM Changeset in webkit [74099] by mitz@apple.com

4 edits
2 adds in trunk

<rdar://problem/8767193> REGRESSION (r60822): caps-lock-indicator is accepted as a -webkit-appearance value
https://bugs.webkit.org/show_bug.cgi?id=51096

Reviewed by Maciej Stachowiak.

WebCore:

Test: fast/css/appearance-caps-lock-indicator.html

css/CSSValueKeywords.in: Moved caps-lock-indicator outside the range of values that should be

accepted by the parser, and added comments about maintaining the list of appearance values.

platform/ThemeTypes.h: Moved CapsLockIndicatorPart to the end of the ControlPart enum.

LayoutTests:

fast/css/appearance-caps-lock-indicator-expected.txt: Added.
fast/css/appearance-caps-lock-indicator.html: Added.

10:48 PM Changeset in webkit [74098] by commit-queue@webkit.org

9 edits in trunk

2010-12-14 takano takumi <takano@apple.com>

Reviewed by Dan Bernstein.

text-combine value names have been changed in the css3 proposal.
https://bugs.webkit.org/show_bug.cgi?id=51089

fast/text/international/text-combine-parser-test-expected.txt: Result updated.
fast/text/international/text-combine-parser-test.html: Test updated.

2010-12-14 takano takumi <takano@apple.com>

Reviewed by Dan Bernstein.

text-combine value names have been changed in the css3 proposal.
https://bugs.webkit.org/show_bug.cgi?id=51089

Changed text-combine's value names from "none|cluster|upright" to "none|horizontal".

css/CSSParser.cpp: Changed value name. (WebCore::CSSParser::parseValue):
css/CSSPrimitiveValueMappings.h: Changed value name. (WebCore::CSSPrimitiveValue::CSSPrimitiveValue): (WebCore::CSSPrimitiveValue::operator TextCombine):
css/CSSValueKeywords.in: No more text-combine specific values needed since "horizontal" is already there.
rendering/style/RenderStyleConstants.h: Changed value name.
rendering/style/StyleRareNonInheritedData.h: Changed textCombine field size.

8:19 PM Changeset in webkit [74097] by commit-queue@webkit.org

429 edits
1 add in trunk/LayoutTests

2010-12-14 Cosmin Truta <ctruta@chromium.org>

Reviewed by Eric Seidel.

Rebaseline: leading and trailing EOL must occur consistently in expectation files
https://bugs.webkit.org/show_bug.cgi?id=51018

We are planning to make new-run-webkit-tests treat EOLs in the same strict manner as old-run-webkit-tests.
This change in tooling requires rebaselining.

editing/pasteboard/file-drag-to-editable-expected.txt:
fast/dom/Window/slow-unload-handler-expected.txt:
fast/filesystem/file-writer-truncate-extend-expected.txt:
fast/images/webp-image-decoding-expected.txt:
fast/speech/input-onspeechchange-event-expected.txt:
fast/speech/input-text-language-tag-expected.txt:
fast/speech/input-text-speechbutton-expected.txt:
fast/speech/speech-button-ignore-generated-events-expected.txt:
http/tests/media/video-play-suspend-expected.txt:
platform/chromium-linux/fast/dom/DeviceOrientation/window-property-expected.txt:
platform/chromium-linux/fast/dom/HTMLAnchorElement/set-href-attribute-hostname-expected.txt:
platform/chromium-linux/fast/dom/HTMLAnchorElement/set-href-attribute-search-expected.txt:
platform/chromium-linux/fast/dom/HTMLProgressElement/progress-element-with-child-crash-expected.txt:
platform/chromium-linux/fast/dom/Window/window-properties-device-orientation-expected.txt:
platform/chromium-linux/fast/forms/onselect-textarea-expected.txt:
platform/chromium-linux/fast/preloader/script-expected.txt:
platform/chromium-linux/fast/url/file-expected.txt:
platform/chromium-linux/fast/url/relative-unix-expected.txt:
platform/chromium-linux/fast/url/relative-win-expected.txt:
platform/chromium-linux/fast/url/segments-expected.txt:
platform/chromium-linux/fast/url/segments-from-data-url-expected.txt:
platform/chromium-linux/http/tests/loading/bad-scheme-subframe-expected.txt:
platform/chromium-linux/http/tests/security/xssAuditor/javascript-link-HTML-entities-null-char-expected.txt:
platform/chromium-linux/http/tests/websocket/tests/bad-sub-protocol-control-chars-expected.txt:
platform/chromium-linux/http/tests/websocket/tests/url-parsing-expected.txt:
platform/chromium-linux/svg/custom/use-invalid-pattern-expected.txt:
platform/chromium-mac/animations/keyframes-rule-expected.txt:
platform/chromium-mac/fast/css/font-face-descriptor-multiple-values-parsing-expected.txt:
platform/chromium-mac/fast/dom/DOMException/EventException-expected.txt:
platform/chromium-mac/fast/dom/DOMException/RangeException-expected.txt:
platform/chromium-mac/fast/dom/DOMException/XPathException-expected.txt:
platform/chromium-mac/fast/dom/DOMException/prototype-object-expected.txt:
platform/chromium-mac/fast/dom/DeviceOrientation/window-property-expected.txt:
platform/chromium-mac/fast/dom/HTMLAnchorElement/set-href-attribute-hash-expected.txt:
platform/chromium-mac/fast/dom/HTMLAnchorElement/set-href-attribute-host-expected.txt:
platform/chromium-mac/fast/dom/HTMLAnchorElement/set-href-attribute-hostname-expected.txt:
platform/chromium-mac/fast/dom/HTMLAnchorElement/set-href-attribute-pathname-expected.txt:
platform/chromium-mac/fast/dom/HTMLAnchorElement/set-href-attribute-port-expected.txt:
platform/chromium-mac/fast/dom/HTMLAnchorElement/set-href-attribute-search-expected.txt:
platform/chromium-mac/fast/dom/HTMLSelectElement/named-options-expected.txt:
platform/chromium-mac/fast/dom/Range/getClientRects-expected.txt:
platform/chromium-mac/fast/dom/Window/window-postmessage-args-expected.txt:
platform/chromium-mac/fast/dom/Window/window-properties-device-orientation-expected.txt:
platform/chromium-mac/fast/dom/Window/window-properties-geolocation-expected.txt:
platform/chromium-mac/fast/dom/error-to-string-stack-overflow-expected.txt:
platform/chromium-mac/fast/dom/getElementsByClassName/011-expected.txt:
platform/chromium-mac/fast/dom/javascript-url-exception-isolation-expected.txt:
platform/chromium-mac/fast/dom/prototype-chain-expected.txt:
platform/chromium-mac/fast/dom/setPrimitiveValue-exceptions-expected.txt:
platform/chromium-mac/fast/dom/timer-clear-interval-in-handler-and-generate-error-expected.txt:
platform/chromium-mac/fast/dom/wrapper-classes-expected.txt:
platform/chromium-mac/fast/events/event-view-toString-expected.txt:
platform/chromium-mac/fast/forms/ValidityState-typeMismatch-url-expected.txt:
platform/chromium-mac/fast/js/array-every-expected.txt:
platform/chromium-mac/fast/js/array-foreach-expected.txt:
platform/chromium-mac/fast/js/array-some-expected.txt:
platform/chromium-mac/fast/js/assign-expected.txt:
platform/chromium-mac/fast/js/break-ASI-expected.txt:
platform/chromium-mac/fast/js/console-non-string-values-expected.txt:
platform/chromium-mac/fast/js/const-expected.txt:
platform/chromium-mac/fast/js/cyclic-prototypes-expected.txt:
platform/chromium-mac/fast/js/date-proto-generic-invocation-expected.txt:
platform/chromium-mac/fast/js/date-toisostring-expected.txt:
platform/chromium-mac/fast/js/deep-recursion-test-expected.txt:
platform/chromium-mac/fast/js/delete-getters-setters-expected.txt:
platform/chromium-mac/fast/js/exception-thrown-from-new-expected.txt:
platform/chromium-mac/fast/js/function-declaration-expected.txt:
platform/chromium-mac/fast/js/function-prototype-descriptor-expected.txt:
platform/chromium-mac/fast/js/kde/RegExp-expected.txt:
platform/chromium-mac/fast/js/kde/StringObject-expected.txt:
platform/chromium-mac/fast/js/kde/encode_decode_uri-expected.txt:
platform/chromium-mac/fast/js/kde/function-expected.txt:
platform/chromium-mac/fast/js/kde/garbage-n-expected.txt:
platform/chromium-mac/fast/js/kde/lval-exceptions-expected.txt:
platform/chromium-mac/fast/js/kde/parse-expected.txt:
platform/chromium-mac/fast/js/kde/string-1-n-expected.txt:
platform/chromium-mac/fast/js/kde/string-2-n-expected.txt:
platform/chromium-mac/fast/js/modify-non-references-expected.txt:
platform/chromium-mac/fast/js/no-semi-insertion-at-end-of-script-expected.txt:
platform/chromium-mac/fast/js/number-toExponential-expected.txt:
platform/chromium-mac/fast/js/number-toString-expected.txt:
platform/chromium-mac/fast/js/number-tofixed-expected.txt:
platform/chromium-mac/fast/js/number-toprecision-expected.txt:
platform/chromium-mac/fast/js/object-extra-comma-expected.txt:
platform/chromium-mac/fast/js/property-getters-and-setters-expected.txt:
platform/chromium-mac/fast/js/recursion-limit-equal-expected.txt:
platform/chromium-mac/fast/js/regexp-compile-expected.txt:
platform/chromium-mac/fast/js/regexp-overflow-expected.txt:
platform/chromium-mac/fast/js/reserved-words-expected.txt:
platform/chromium-mac/fast/js/string-capitalization-expected.txt:
platform/chromium-mac/fast/js/toString-and-valueOf-override-expected.txt:
platform/chromium-mac/fast/js/toString-stack-overflow-expected.txt:
platform/chromium-mac/fast/text/find-kana-expected.txt:
platform/chromium-mac/fast/url/file-expected.txt:
platform/chromium-mac/fast/url/host-expected.txt:
platform/chromium-mac/fast/url/ipv6-expected.txt:
platform/chromium-mac/fast/url/mailto-expected.txt:
platform/chromium-mac/fast/url/path-expected.txt:
platform/chromium-mac/fast/url/path-url-expected.txt:
platform/chromium-mac/fast/url/port-expected.txt:
platform/chromium-mac/fast/url/relative-unix-expected.txt:
platform/chromium-mac/fast/url/relative-win-expected.txt:
platform/chromium-mac/fast/url/scheme-expected.txt:
platform/chromium-mac/fast/url/segments-expected.txt:
platform/chromium-mac/fast/url/segments-from-data-url-expected.txt:
platform/chromium-mac/fast/url/standard-url-expected.txt:
platform/chromium-mac/fast/xmlhttprequest/xmlhttprequest-get-expected.txt:
platform/chromium-mac/fast/xmlhttprequest/xmlhttprequest-nonexistent-file-expected.txt:
platform/chromium-mac/fast/xmlhttprequest/xmlhttprequest-recursive-sync-event-expected.txt:
platform/chromium-mac/http/tests/loading/bad-scheme-subframe-expected.txt:
platform/chromium-mac/http/tests/security/cross-frame-access-enumeration-expected.txt:
platform/chromium-mac/http/tests/security/cross-frame-access-get-expected.txt:
platform/chromium-mac/http/tests/security/cross-frame-access-get-override-expected.txt:
platform/chromium-mac/http/tests/security/cross-frame-access-history-get-expected.txt:
platform/chromium-mac/http/tests/security/cross-frame-access-history-get-override-expected.txt:
platform/chromium-mac/http/tests/security/cross-frame-access-location-get-override-expected.txt:
platform/chromium-mac/http/tests/security/cross-frame-access-location-put-expected.txt:
platform/chromium-mac/http/tests/security/dataURL/xss-DENIED-from-data-url-sub-frame-to-data-url-sub-frame-expected.txt:
platform/chromium-mac/http/tests/security/dataURL/xss-DENIED-to-data-url-in-foreign-domain-window-open-expected.txt:
platform/chromium-mac/http/tests/security/dataURL/xss-DENIED-to-data-url-window-open-expected.txt:
platform/chromium-mac/http/tests/security/xssAuditor/javascript-link-HTML-entities-null-char-expected.txt:
platform/chromium-mac/http/tests/websocket/tests/bad-sub-protocol-control-chars-expected.txt:
platform/chromium-mac/http/tests/websocket/tests/url-parsing-expected.txt:
platform/chromium-mac/http/tests/xmlhttprequest/XMLHttpRequestException-expected.txt:
platform/chromium-mac/http/tests/xmlhttprequest/xmlhttprequest-missing-file-exception-expected.txt:
platform/chromium-mac/ietestcenter/Javascript/11.4.1-4.a-10-expected.txt:
platform/chromium-mac/ietestcenter/Javascript/11.4.1-4.a-8-expected.txt:
platform/chromium-mac/ietestcenter/Javascript/15.12.1.1-0-2-expected.txt:
platform/chromium-mac/ietestcenter/Javascript/15.12.1.1-0-3-expected.txt:
platform/chromium-mac/ietestcenter/Javascript/15.12.2-0-2-expected.txt:
platform/chromium-mac/ietestcenter/Javascript/15.12.3-0-2-expected.txt:
platform/chromium-mac/ietestcenter/Javascript/15.2.3.10-0-1-expected.txt:
platform/chromium-mac/ietestcenter/Javascript/15.2.3.10-0-2-expected.txt:
platform/chromium-mac/ietestcenter/Javascript/15.2.3.10-1-expected.txt:
platform/chromium-mac/ietestcenter/Javascript/15.2.3.10-2-expected.txt:
platform/chromium-mac/ietestcenter/Javascript/15.2.3.13-0-1-expected.txt:
platform/chromium-mac/ietestcenter/Javascript/15.2.3.13-0-2-expected.txt:
platform/chromium-mac/ietestcenter/Javascript/15.2.3.13-0-3-expected.txt:
platform/chromium-mac/ietestcenter/Javascript/15.2.3.13-1-expected.txt:
platform/chromium-mac/ietestcenter/Javascript/15.2.3.13-2-1-expected.txt:
platform/chromium-mac/ietestcenter/Javascript/15.2.3.13-2-10-expected.txt:
platform/chromium-mac/ietestcenter/Javascript/15.2.3.13-2-11-expected.txt:
platform/chromium-mac/ietestcenter/Javascript/15.2.3.13-2-12-expected.txt:
platform/chromium-mac/ietestcenter/Javascript/15.2.3.13-2-13-expected.txt:
platform/chromium-mac/ietestcenter/Javascript/15.2.3.13-2-14-expected.txt:
platform/chromium-mac/ietestcenter/Javascript/15.2.3.13-2-15-expected.txt:
platform/chromium-mac/ietestcenter/Javascript/15.2.3.13-2-16-expected.txt:
platform/chromium-mac/ietestcenter/Javascript/15.2.3.13-2-17-expected.txt:
platform/chromium-mac/ietestcenter/Javascript/15.2.3.13-2-18-expected.txt:
platform/chromium-mac/ietestcenter/Javascript/15.2.3.13-2-19-expected.txt:
platform/chromium-mac/ietestcenter/Javascript/15.2.3.13-2-2-expected.txt:
platform/chromium-mac/ietestcenter/Javascript/15.2.3.13-2-20-expected.txt:
platform/chromium-mac/ietestcenter/Javascript/15.2.3.13-2-21-expected.txt:
platform/chromium-mac/ietestcenter/Javascript/15.2.3.13-2-3-expected.txt:
platform/chromium-mac/ietestcenter/Javascript/15.2.3.13-2-4-expected.txt:
platform/chromium-mac/ietestcenter/Javascript/15.2.3.13-2-5-expected.txt:
platform/chromium-mac/ietestcenter/Javascript/15.2.3.13-2-6-expected.txt:
platform/chromium-mac/ietestcenter/Javascript/15.2.3.13-2-7-expected.txt:
platform/chromium-mac/ietestcenter/Javascript/15.2.3.13-2-8-expected.txt:
platform/chromium-mac/ietestcenter/Javascript/15.2.3.13-2-9-expected.txt:
platform/chromium-mac/ietestcenter/Javascript/15.2.3.14-2-4-expected.txt:
platform/chromium-mac/ietestcenter/Javascript/15.2.3.14-3-4-expected.txt:
platform/chromium-mac/ietestcenter/Javascript/15.2.3.3-4-22-expected.txt:
platform/chromium-mac/ietestcenter/Javascript/15.2.3.3-4-25-expected.txt:
platform/chromium-mac/ietestcenter/Javascript/15.2.3.6-4-1-expected.txt:
platform/chromium-mac/ietestcenter/Javascript/15.4.4.14-9-a-12-expected.txt:
platform/chromium-mac/ietestcenter/Javascript/15.4.4.15-3-26-expected.txt:
platform/chromium-mac/ietestcenter/Javascript/15.4.4.15-3-27-expected.txt:
platform/chromium-mac/ietestcenter/Javascript/15.4.4.15-5-1-expected.txt:
platform/chromium-mac/ietestcenter/Javascript/15.4.4.15-5-12-expected.txt:
platform/chromium-mac/ietestcenter/Javascript/15.4.4.15-5-14-expected.txt:
platform/chromium-mac/ietestcenter/Javascript/15.4.4.15-5-16-expected.txt:
platform/chromium-mac/ietestcenter/Javascript/15.4.4.15-5-4-expected.txt:
platform/chromium-mac/ietestcenter/Javascript/15.4.4.15-8-9-expected.txt:
platform/chromium-mac/ietestcenter/Javascript/15.4.4.15-8-a-12-expected.txt:
platform/chromium-mac/ietestcenter/Javascript/15.5.4.20-1-1-expected.txt:
platform/chromium-mac/ietestcenter/Javascript/15.5.4.20-1-2-expected.txt:
platform/chromium-mac/media/audio-constructor-expected.txt:
platform/chromium-mac/media/audio-constructor-preload-expected.txt:
platform/chromium-mac/media/audio-constructor-src-expected.txt:
platform/chromium-mac/media/media-load-event-expected.txt:
platform/chromium-mac/media/video-append-source-expected.txt:
platform/chromium-mac/media/video-canvas-source-expected.txt:
platform/chromium-mac/media/video-currentTime-set-expected.txt:
platform/chromium-mac/media/video-dom-src-expected.txt:
platform/chromium-mac/media/video-load-networkState-expected.txt:
platform/chromium-mac/media/video-seek-past-end-paused-expected.txt:
platform/chromium-mac/media/video-seek-past-end-playing-expected.txt:
platform/chromium-mac/media/video-source-expected.txt:
platform/chromium-mac/media/video-src-change-expected.txt:
platform/chromium-mac/media/video-src-expected.txt:
platform/chromium-mac/plugins/clicking-missing-plugin-fires-delegate-expected.txt:
platform/chromium-mac/plugins/npruntime/object-from-destroyed-plugin-expected.txt:
platform/chromium-mac/security/block-test-no-port-expected.txt:
platform/chromium-mac/storage/transaction-error-callback-expected.txt:
platform/chromium-mac/svg/custom/SVGException-expected.txt:
platform/chromium-mac/svg/custom/use-invalid-pattern-expected.txt:
platform/chromium-mac/svg/custom/use-nested-missing-target-removed-expected.txt:
platform/chromium-mac/svg/dom/svgpath-out-of-bounds-getPathSeg-expected.txt:
platform/chromium-mac/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-values-prop-expected.txt:
platform/chromium-win/animations/keyframes-rule-expected.txt:
platform/chromium-win/editing/selection/extend-selection-home-end-expected.txt:
platform/chromium-win/editing/selection/home-end-expected.txt:
platform/chromium-win/fast/css/button-height-expected.txt:
platform/chromium-win/fast/css/font-face-descriptor-multiple-values-parsing-expected.txt:
platform/chromium-win/fast/css/getComputedStyle/computed-style-expected.txt:
platform/chromium-win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
platform/chromium-win/fast/dom/DOMException/EventException-expected.txt:
platform/chromium-win/fast/dom/DOMException/RangeException-expected.txt:
platform/chromium-win/fast/dom/DOMException/XPathException-expected.txt:
platform/chromium-win/fast/dom/DOMException/prototype-object-expected.txt:
platform/chromium-win/fast/dom/DeviceOrientation/window-property-expected.txt:
platform/chromium-win/fast/dom/HTMLAnchorElement/set-href-attribute-hash-expected.txt:
platform/chromium-win/fast/dom/HTMLAnchorElement/set-href-attribute-host-expected.txt:
platform/chromium-win/fast/dom/HTMLAnchorElement/set-href-attribute-hostname-expected.txt:
platform/chromium-win/fast/dom/HTMLAnchorElement/set-href-attribute-pathname-expected.txt:
platform/chromium-win/fast/dom/HTMLAnchorElement/set-href-attribute-port-expected.txt:
platform/chromium-win/fast/dom/HTMLAnchorElement/set-href-attribute-search-expected.txt:
platform/chromium-win/fast/dom/HTMLProgressElement/progress-element-with-child-crash-expected.txt:
platform/chromium-win/fast/dom/HTMLSelectElement/named-options-expected.txt:
platform/chromium-win/fast/dom/Window/new-window-opener-expected.txt:
platform/chromium-win/fast/dom/Window/webkitConvertPoint-expected.txt:
platform/chromium-win/fast/dom/Window/window-lookup-precedence-expected.txt:
platform/chromium-win/fast/dom/Window/window-postmessage-args-expected.txt:
platform/chromium-win/fast/dom/Window/window-properties-device-orientation-expected.txt:
platform/chromium-win/fast/dom/Window/window-properties-geolocation-expected.txt:
platform/chromium-win/fast/dom/error-to-string-stack-overflow-expected.txt:
platform/chromium-win/fast/dom/getElementsByClassName/011-expected.txt:
platform/chromium-win/fast/dom/javascript-url-exception-isolation-expected.txt:
platform/chromium-win/fast/dom/prototype-chain-expected.txt:
platform/chromium-win/fast/dom/setPrimitiveValue-exceptions-expected.txt:
platform/chromium-win/fast/dom/timer-clear-interval-in-handler-and-generate-error-expected.txt:
platform/chromium-win/fast/dom/wrapper-classes-expected.txt:
platform/chromium-win/fast/events/event-view-toString-expected.txt:
platform/chromium-win/fast/events/offsetX-offsetY-expected.txt:
platform/chromium-win/fast/forms/ValidityState-typeMismatch-url-expected.txt:
platform/chromium-win/fast/forms/focus-selection-textarea-expected.txt:
platform/chromium-win/fast/forms/input-maxlength-ime-completed-expected.txt:
platform/chromium-win/fast/forms/input-maxlength-ime-preedit-expected.txt:
platform/chromium-win/fast/forms/slider-mouse-events-expected.txt:
platform/chromium-win/fast/js/array-every-expected.txt:
platform/chromium-win/fast/js/array-foreach-expected.txt:
platform/chromium-win/fast/js/array-some-expected.txt:
platform/chromium-win/fast/js/assign-expected.txt:
platform/chromium-win/fast/js/break-ASI-expected.txt:
platform/chromium-win/fast/js/console-non-string-values-expected.txt:
platform/chromium-win/fast/js/const-expected.txt:
platform/chromium-win/fast/js/cyclic-prototypes-expected.txt:
platform/chromium-win/fast/js/date-proto-generic-invocation-expected.txt:
platform/chromium-win/fast/js/date-toisostring-expected.txt:
platform/chromium-win/fast/js/deep-recursion-test-expected.txt:
platform/chromium-win/fast/js/delete-getters-setters-expected.txt:
platform/chromium-win/fast/js/exception-thrown-from-new-expected.txt:
platform/chromium-win/fast/js/function-declaration-expected.txt:
platform/chromium-win/fast/js/function-prototype-descriptor-expected.txt:
platform/chromium-win/fast/js/function-prototype-expected.txt:
platform/chromium-win/fast/js/kde/RegExp-expected.txt:
platform/chromium-win/fast/js/kde/StringObject-expected.txt:
platform/chromium-win/fast/js/kde/encode_decode_uri-expected.txt:
platform/chromium-win/fast/js/kde/exception_propagation-expected.txt:
platform/chromium-win/fast/js/kde/function-expected.txt:
platform/chromium-win/fast/js/kde/garbage-n-expected.txt:
platform/chromium-win/fast/js/kde/lval-exceptions-expected.txt:
platform/chromium-win/fast/js/kde/parse-expected.txt:
platform/chromium-win/fast/js/kde/string-1-n-expected.txt:
platform/chromium-win/fast/js/kde/string-2-n-expected.txt:
platform/chromium-win/fast/js/modify-non-references-expected.txt:
platform/chromium-win/fast/js/no-semi-insertion-at-end-of-script-expected.txt:
platform/chromium-win/fast/js/number-toExponential-expected.txt:
platform/chromium-win/fast/js/number-toString-expected.txt:
platform/chromium-win/fast/js/number-tofixed-expected.txt:
platform/chromium-win/fast/js/number-toprecision-expected.txt:
platform/chromium-win/fast/js/object-extra-comma-expected.txt:
platform/chromium-win/fast/js/property-getters-and-setters-expected.txt:
platform/chromium-win/fast/js/recursion-limit-equal-expected.txt:
platform/chromium-win/fast/js/regexp-caching-expected.txt:
platform/chromium-win/fast/js/regexp-compile-expected.txt:
platform/chromium-win/fast/js/regexp-overflow-expected.txt:
platform/chromium-win/fast/js/reserved-words-expected.txt:
platform/chromium-win/fast/js/string-capitalization-expected.txt:
platform/chromium-win/fast/js/toString-and-valueOf-override-expected.txt:
platform/chromium-win/fast/replaced/table-percent-height-expected.txt:
platform/chromium-win/fast/url/file-expected.txt:
platform/chromium-win/fast/url/host-expected.txt:
platform/chromium-win/fast/url/ipv6-expected.txt:
platform/chromium-win/fast/url/mailto-expected.txt:
platform/chromium-win/fast/url/path-expected.txt:
platform/chromium-win/fast/url/path-url-expected.txt:
platform/chromium-win/fast/url/port-expected.txt:
platform/chromium-win/fast/url/relative-unix-expected.txt:
platform/chromium-win/fast/url/relative-win-expected.txt:
platform/chromium-win/fast/url/scheme-expected.txt:
platform/chromium-win/fast/url/segments-expected.txt:
platform/chromium-win/fast/url/segments-from-data-url-expected.txt:
platform/chromium-win/fast/url/standard-url-expected.txt:
platform/chromium-win/fast/xmlhttprequest/xmlhttprequest-get-expected.txt:
platform/chromium-win/fast/xmlhttprequest/xmlhttprequest-nonexistent-file-expected.txt:
platform/chromium-win/fast/xmlhttprequest/xmlhttprequest-recursive-sync-event-expected.txt:
platform/chromium-win/http/tests/loading/bad-scheme-subframe-expected.txt:
platform/chromium-win/http/tests/security/cross-frame-access-enumeration-expected.txt:
platform/chromium-win/http/tests/security/cross-frame-access-get-expected.txt:
platform/chromium-win/http/tests/security/cross-frame-access-get-override-expected.txt:
platform/chromium-win/http/tests/security/cross-frame-access-history-get-expected.txt:
platform/chromium-win/http/tests/security/cross-frame-access-history-get-override-expected.txt:
platform/chromium-win/http/tests/security/cross-frame-access-location-get-override-expected.txt:
platform/chromium-win/http/tests/security/cross-frame-access-location-put-expected.txt:
platform/chromium-win/http/tests/security/cross-frame-access-put-expected.txt:
platform/chromium-win/http/tests/security/dataURL/xss-DENIED-from-data-url-sub-frame-to-data-url-sub-frame-expected.txt:
platform/chromium-win/http/tests/security/dataURL/xss-DENIED-to-data-url-in-foreign-domain-window-open-expected.txt:
platform/chromium-win/http/tests/security/dataURL/xss-DENIED-to-data-url-window-open-expected.txt:
platform/chromium-win/http/tests/security/xssAuditor/javascript-link-HTML-entities-null-char-expected.txt:
platform/chromium-win/http/tests/websocket/tests/bad-sub-protocol-control-chars-expected.txt:
platform/chromium-win/http/tests/websocket/tests/url-parsing-expected.txt:
platform/chromium-win/http/tests/xmlhttprequest/XMLHttpRequestException-expected.txt:
platform/chromium-win/ietestcenter/Javascript/11.4.1-4.a-10-expected.txt:
platform/chromium-win/ietestcenter/Javascript/11.4.1-4.a-8-expected.txt:
platform/chromium-win/ietestcenter/Javascript/15.12.1.1-0-2-expected.txt:
platform/chromium-win/ietestcenter/Javascript/15.12.1.1-0-3-expected.txt:
platform/chromium-win/ietestcenter/Javascript/15.12.2-0-2-expected.txt:
platform/chromium-win/ietestcenter/Javascript/15.12.3-0-2-expected.txt:
platform/chromium-win/ietestcenter/Javascript/15.2.3.10-0-1-expected.txt:
platform/chromium-win/ietestcenter/Javascript/15.2.3.10-0-2-expected.txt:
platform/chromium-win/ietestcenter/Javascript/15.2.3.10-1-expected.txt:
platform/chromium-win/ietestcenter/Javascript/15.2.3.10-2-expected.txt:
platform/chromium-win/ietestcenter/Javascript/15.2.3.13-0-1-expected.txt:
platform/chromium-win/ietestcenter/Javascript/15.2.3.13-0-2-expected.txt:
platform/chromium-win/ietestcenter/Javascript/15.2.3.13-0-3-expected.txt:
platform/chromium-win/ietestcenter/Javascript/15.2.3.13-1-expected.txt:
platform/chromium-win/ietestcenter/Javascript/15.2.3.13-2-1-expected.txt:
platform/chromium-win/ietestcenter/Javascript/15.2.3.13-2-10-expected.txt:
platform/chromium-win/ietestcenter/Javascript/15.2.3.13-2-11-expected.txt:
platform/chromium-win/ietestcenter/Javascript/15.2.3.13-2-12-expected.txt:
platform/chromium-win/ietestcenter/Javascript/15.2.3.13-2-13-expected.txt:
platform/chromium-win/ietestcenter/Javascript/15.2.3.13-2-14-expected.txt:
platform/chromium-win/ietestcenter/Javascript/15.2.3.13-2-15-expected.txt:
platform/chromium-win/ietestcenter/Javascript/15.2.3.13-2-16-expected.txt:
platform/chromium-win/ietestcenter/Javascript/15.2.3.13-2-17-expected.txt:
platform/chromium-win/ietestcenter/Javascript/15.2.3.13-2-18-expected.txt:
platform/chromium-win/ietestcenter/Javascript/15.2.3.13-2-19-expected.txt:
platform/chromium-win/ietestcenter/Javascript/15.2.3.13-2-2-expected.txt:
platform/chromium-win/ietestcenter/Javascript/15.2.3.13-2-20-expected.txt:
platform/chromium-win/ietestcenter/Javascript/15.2.3.13-2-21-expected.txt:
platform/chromium-win/ietestcenter/Javascript/15.2.3.13-2-3-expected.txt:
platform/chromium-win/ietestcenter/Javascript/15.2.3.13-2-4-expected.txt:
platform/chromium-win/ietestcenter/Javascript/15.2.3.13-2-5-expected.txt:
platform/chromium-win/ietestcenter/Javascript/15.2.3.13-2-6-expected.txt:
platform/chromium-win/ietestcenter/Javascript/15.2.3.13-2-7-expected.txt:
platform/chromium-win/ietestcenter/Javascript/15.2.3.13-2-8-expected.txt:
platform/chromium-win/ietestcenter/Javascript/15.2.3.13-2-9-expected.txt:
platform/chromium-win/ietestcenter/Javascript/15.2.3.14-2-4-expected.txt:
platform/chromium-win/ietestcenter/Javascript/15.2.3.14-3-4-expected.txt:
platform/chromium-win/ietestcenter/Javascript/15.2.3.3-4-22-expected.txt:
platform/chromium-win/ietestcenter/Javascript/15.2.3.3-4-25-expected.txt:
platform/chromium-win/ietestcenter/Javascript/15.2.3.6-4-1-expected.txt:
platform/chromium-win/ietestcenter/Javascript/15.4.4.14-9-a-12-expected.txt:
platform/chromium-win/ietestcenter/Javascript/15.4.4.15-3-26-expected.txt:
platform/chromium-win/ietestcenter/Javascript/15.4.4.15-3-27-expected.txt:
platform/chromium-win/ietestcenter/Javascript/15.4.4.15-5-1-expected.txt:
platform/chromium-win/ietestcenter/Javascript/15.4.4.15-5-12-expected.txt:
platform/chromium-win/ietestcenter/Javascript/15.4.4.15-5-14-expected.txt:
platform/chromium-win/ietestcenter/Javascript/15.4.4.15-5-16-expected.txt:
platform/chromium-win/ietestcenter/Javascript/15.4.4.15-5-4-expected.txt:
platform/chromium-win/ietestcenter/Javascript/15.4.4.15-8-9-expected.txt:
platform/chromium-win/ietestcenter/Javascript/15.4.4.15-8-a-12-expected.txt:
platform/chromium-win/ietestcenter/Javascript/15.5.4.20-1-1-expected.txt:
platform/chromium-win/ietestcenter/Javascript/15.5.4.20-1-2-expected.txt:
platform/chromium-win/inspector/console-format-expected.txt:
platform/chromium-win/inspector/console-uncaught-exception-expected.txt:
platform/chromium-win/media/audio-constructor-expected.txt:
platform/chromium-win/media/audio-constructor-preload-expected.txt:
platform/chromium-win/media/audio-constructor-src-expected.txt:
platform/chromium-win/media/audio-delete-while-slider-thumb-clicked-expected.txt:
platform/chromium-win/media/media-load-event-expected.txt:
platform/chromium-win/media/video-append-source-expected.txt:
platform/chromium-win/media/video-canvas-source-expected.txt:
platform/chromium-win/media/video-currentTime-set-expected.txt:
platform/chromium-win/media/video-dom-src-expected.txt:
platform/chromium-win/media/video-load-networkState-expected.txt:
platform/chromium-win/media/video-seek-past-end-paused-expected.txt:
platform/chromium-win/media/video-seek-past-end-playing-expected.txt:
platform/chromium-win/media/video-source-expected.txt:
platform/chromium-win/media/video-src-change-expected.txt:
platform/chromium-win/media/video-src-expected.txt:
platform/chromium-win/media/video-src-remove-expected.txt:
platform/chromium-win/media/video-src-set-expected.txt:
platform/chromium-win/media/video-src-source-expected.txt:
platform/chromium-win/plugins/clicking-missing-plugin-fires-delegate-expected.txt:
platform/chromium-win/plugins/inner-html-display-none-expected.txt:
platform/chromium-win/plugins/npruntime/object-from-destroyed-plugin-expected.txt:
platform/chromium-win/security/block-test-no-port-expected.txt:
platform/chromium-win/storage/statement-error-callback-expected.txt:
platform/chromium-win/storage/transaction-error-callback-expected.txt:
platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt:
platform/chromium-win/svg/custom/SVGException-expected.txt:
platform/chromium-win/svg/custom/use-invalid-pattern-expected.txt:
platform/chromium-win/svg/custom/use-nested-missing-target-removed-expected.txt:
platform/chromium-win/svg/dom/path-parser-expected.txt:
platform/chromium-win/svg/dom/svgpath-out-of-bounds-getPathSeg-expected.txt:
platform/chromium-win/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-values-prop-expected.txt:
platform/chromium-win/svg/dynamic-updates/SVGLineElement-dom-requiredFeatures-expected.txt:
platform/chromium-win/svg/dynamic-updates/SVGLineElement-svgdom-requiredFeatures-expected.txt:
platform/chromium-win/svg/text/lengthAdjust-text-metrics-expected.txt:
platform/chromium/fast/dom/anchor-origin-expected.txt:
platform/chromium/fast/dom/domListEnumeration-expected.txt:
platform/chromium/fast/dom/global-constructors-expected.txt:
platform/chromium/fast/dom/horizontal-scrollbar-when-dir-change-expected.txt:
platform/chromium/fast/dom/prototype-inheritance-expected.txt:
platform/chromium/fast/forms/search-popup-crasher-expected.txt:
platform/chromium/fast/js/ToNumber-expected.txt:
platform/chromium/fast/js/parseFloat-expected.txt:
platform/chromium/fast/js/regexp-look-ahead-empty-expected.txt:
platform/chromium/fast/js/regexp-overflow-expected.txt:
platform/chromium/fast/text/font-linux-normalize-expected.txt:
platform/chromium/fast/url/relative-expected.txt:
platform/chromium/http/tests/inspector/console-resource-errors-expected.txt:
platform/chromium/http/tests/inspector/console-xhr-logging-expected.txt:
platform/chromium/http/tests/security/cross-frame-access-call-expected.txt:
platform/chromium/http/tests/security/cross-origin-xsl-BLOCKED-expected.txt: Added.
platform/chromium/inspector/console-eval-global-expected.txt:
platform/chromium/inspector/console-log-syntax-error-expected.txt:
platform/chromium/inspector/console-object-constructor-name-expected.txt:
platform/chromium/inspector/console-trace-in-eval-expected.txt:
platform/chromium/inspector/console-uncaught-exception-in-eval-expected.txt:
platform/chromium/inspector/debugger-autocontinue-on-syntax-error-expected.txt:
platform/chromium/inspector/debugger-expand-scope-expected.txt:
platform/chromium/security/block-test-no-port-expected.txt:
platform/chromium/traversal/node-iterator-prototype-expected.txt:
plugins/document-open-expected.txt:
plugins/iframe-shims-expected.txt:

7:48 PM Changeset in webkit [74096] by commit-queue@webkit.org

3 edits
4 adds in trunk

2010-12-14 Koan-Sin Tan <koansin.tan@gmail.com>

Reviewed by Alexey Proskuryakov.

Kana should be part of CJK Ideographs in WebCore/platform/graphics/Font.cpp
https://bugs.webkit.org/show_bug.cgi?id=51012

Test if kana displayed correctly in vertical text with broken font.

fast/blockflow/japanese-rl-text-with-broken-font.html: Added.
platform/mac/fast/blockflow/japanese-rl-text-with-broken-font-expected.checksum: Added.
platform/mac/fast/blockflow/japanese-rl-text-with-broken-font-expected.png: Added.
platform/mac/fast/blockflow/japanese-rl-text-with-broken-font-expected.txt: Added.

2010-12-14 Koan-Sin Tan <koansin.tan@gmail.com>

Reviewed by Alexey Proskuryakov.

Kana should be part of CJK Ideographs in WebCore/platform/graphics/Font.cpp
https://bugs.webkit.org/show_bug.cgi?id=51012

Kana should be displayed correctly in vertical text with broken font.

Test: fast/blockflow/japanese-rl-text-with-broken-font.html

platform/graphics/Font.cpp: (WebCore::Font::isCJKIdeographOrSymbol): add katakana, hiraganna, and Halfwidth and Fullwidth Forms

7:37 PM Changeset in webkit [74095] by mitz@apple.com

5 edits in trunk/WebCore

Additional RenderStyle support for the text-emphasis CSS property
Part of <rdar://problem/7720300> Support the CSS3 text-emphasis property
https://bugs.webkit.org/show_bug.cgi?id=48539

Reviewed by Sam Weinig.

No test possible, since this is just adding a function to be used by upcoming patches.

platform/text/CharacterNames.h: Added characters used as emphasis marks.
rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::textEmphasisMarkString): Added. Returns a string containing the
emphasis mark, or the null AtomicString if there is none.

rendering/style/RenderStyle.h:

7:06 PM Changeset in webkit [74094] by rniwa@webkit.org

2 edits
2 adds in trunk/LayoutTests

2010-12-14 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Darin Adler.

Range::extractContents needs more tests
https://bugs.webkit.org/show_bug.cgi?id=51005

Added a test to ensure Range::extractContents work as expected.

fast/dom/Range/range-extract-contents-crash-expected.txt: Renamed from LayoutTests/fast/dom/Range/range-extractContents-expected.txt.
fast/dom/Range/range-extract-contents-crash.html: Renamed from LayoutTests/fast/dom/Range/range-extractContents.html.
fast/dom/Range/range-extract-contents-expected.txt: Added.
fast/dom/Range/range-extract-contents.html: Added.
resources/dump-as-markup.js: (Markup.dump): Don't call node.getElementsByTagName if it doesn't exist.

7:01 PM Changeset in webkit [74093] by commit-queue@webkit.org

15 edits
2 moves in trunk

2010-12-14 Anton D'Auria <adauria@apple.com>

Reviewed by Darin Adler.

Do not allow access to existing HTML5 databases in private browsing
mode https://bugs.webkit.org/show_bug.cgi?id=49332

Test: storage/private-browsing-noread-nowrite.html

Previously, read-only transactions and private browsing mode were
represented by the same SQLStatement and DatabaseAuthorizer states.
This patch removes the m_readOnly member variable from SQLStatement and
DatabaseAuthorizer, and replaces it with m_permissions whose bit fields
are initialized by a DatabaseAuthorizer enum Permissions (ReadWrite,
ReadOnly, NoAccess). A read-only transaction sets permissions to
ReadOnly, and if !m_database->scriptExecutionContext()->allowDatabaseAccess(),
then permissions also set to NoAccess.

dom/Document.cpp: (WebCore::Document::allowDatabaseAccess): this method was previously called isDatabaseReadOnly. It checks if private browsing preference is set. This method is renamed because it is used to check if private browsing restricts access to databases.
dom/Document.h:
dom/ScriptExecutionContext.h:
storage/AbstractDatabase.cpp: (WebCore::AbstractDatabase::setAuthorizerPermissions):
storage/AbstractDatabase.h:
storage/DatabaseAuthorizer.cpp: (WebCore::DatabaseAuthorizer::reset): (WebCore::DatabaseAuthorizer::createTable): (WebCore::DatabaseAuthorizer::createTempTable): (WebCore::DatabaseAuthorizer::dropTable): (WebCore::DatabaseAuthorizer::dropTempTable): (WebCore::DatabaseAuthorizer::allowAlterTable): (WebCore::DatabaseAuthorizer::createIndex): (WebCore::DatabaseAuthorizer::createTempIndex): (WebCore::DatabaseAuthorizer::dropIndex): (WebCore::DatabaseAuthorizer::dropTempIndex): (WebCore::DatabaseAuthorizer::createTrigger): (WebCore::DatabaseAuthorizer::createTempTrigger): (WebCore::DatabaseAuthorizer::dropTrigger): (WebCore::DatabaseAuthorizer::dropTempTrigger): (WebCore::DatabaseAuthorizer::createView): (WebCore::DatabaseAuthorizer::createTempView): (WebCore::DatabaseAuthorizer::dropView): (WebCore::DatabaseAuthorizer::dropTempView): (WebCore::DatabaseAuthorizer::createVTable): (WebCore::DatabaseAuthorizer::dropVTable): (WebCore::DatabaseAuthorizer::allowDelete): (WebCore::DatabaseAuthorizer::allowInsert): (WebCore::DatabaseAuthorizer::allowUpdate): (WebCore::DatabaseAuthorizer::allowRead): (WebCore::DatabaseAuthorizer::allowReindex): (WebCore::DatabaseAuthorizer::allowWrite): a new private method that checks if DatabaseAuthorizer is enabled and if it is in ReadOnly or NoAccess mode. (WebCore::DatabaseAuthorizer::setReadOnly): (WebCore::DatabaseAuthorizer::setPermissions):
storage/DatabaseAuthorizer.h:
storage/SQLStatement.cpp: (WebCore::SQLStatement::create): (WebCore::SQLStatement::SQLStatement): (WebCore::SQLStatement::execute):
storage/SQLStatement.h:
storage/SQLStatementSync.cpp: (WebCore::SQLStatementSync::SQLStatementSync): (WebCore::SQLStatementSync::execute):
storage/SQLStatementSync.h:
storage/SQLTransaction.cpp: (WebCore::SQLTransaction::executeSQL):
storage/SQLTransactionSync.cpp: (WebCore::SQLTransactionSync::executeSQL):
workers/WorkerContext.h: (WebCore::WorkerContext::allowDatabaseAccess):

6:36 PM Changeset in webkit [74092] by tkent@chromium.org

2 edits in trunk/WebKitTools

2010-12-14 Kent Tamura <tkent@chromium.org>

Reviewed by Jian Li.

[DRT/Chromium] Remove another unnecessary error message
https://bugs.webkit.org/show_bug.cgi?id=51083

DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::didInvalidateRect):

6:34 PM Changeset in webkit [74091] by jianli@chromium.org

2 edits
12 adds in trunk/LayoutTests

Unreviewed. Mark 2 new focus-ring-* tests as failed in chromium.

platform/chromium-mac-leopard/fast/css/focus-ring-detached-expected.checksum: Added.
platform/chromium-mac-leopard/fast/css/focus-ring-detached-expected.png: Added.
platform/chromium-mac-leopard/fast/css/focus-ring-detached-expected.txt: Added.
platform/chromium-mac-leopard/fast/css/focus-ring-multiline-expected.checksum: Added.
platform/chromium-mac-leopard/fast/css/focus-ring-multiline-expected.png: Added.
platform/chromium-mac-leopard/fast/css/focus-ring-multiline-expected.txt: Added.
platform/chromium-win/fast/css/focus-ring-detached-expected.checksum: Added.
platform/chromium-win/fast/css/focus-ring-detached-expected.png: Added.
platform/chromium-win/fast/css/focus-ring-detached-expected.txt: Added.
platform/chromium-win/fast/css/focus-ring-multiline-expected.checksum: Added.
platform/chromium-win/fast/css/focus-ring-multiline-expected.png: Added.
platform/chromium-win/fast/css/focus-ring-multiline-expected.txt: Added.
platform/chromium/test_expectations.txt:

6:21 PM Changeset in webkit [74090] by mihaip@chromium.org

3 edits
41 deletes in trunk/LayoutTests

2010-12-14 Mihai Parparita <mihaip@chromium.org>

Reviewed by Eric Seidel.

Remove pixel tests that are obsoleted by the HTML5 parser suite
https://bugs.webkit.org/show_bug.cgi?id=51077

Remove tests which had stale Mac pixel baselines (were not updated for
the HTML5 parser change or for Snow Leopard) which are obsoleted by
the HTML5 parser test suite (i.e. the same behavior is tested there):

fast/parser/parseCommentsInTitles.html is tested by tests16.dat (line 956)
fast/parser/comment-in-style.html is tested by tests16.dat (line 904)
fast/tokenizer/missing-title-end-tag-1.html is tested by tests16.dat (line 980)
fast/tokenizer/missing-title-end-tag-2.html is tested by tests2.dat (line 550)

fast/parser/comment-in-style.html: Removed.
fast/parser/parseCommentsInTitles.html: Removed.
fast/tokenizer/missing-title-end-tag-1.html: Removed.
fast/tokenizer/missing-title-end-tag-2.html: Removed.
platform/chromium-linux/fast/parser/comment-in-style-expected.checksum: Removed.
platform/chromium-linux/fast/parser/comment-in-style-expected.png: Removed.
platform/chromium-linux/fast/parser/parseCommentsInTitles-expected.checksum: Removed.
platform/chromium-linux/fast/parser/parseCommentsInTitles-expected.png: Removed.
platform/chromium-mac/fast/parser/comment-in-style-expected.checksum: Removed.
platform/chromium-mac/fast/parser/comment-in-style-expected.png: Removed.
platform/chromium-mac/fast/parser/parseCommentsInTitles-expected.checksum: Removed.
platform/chromium-mac/fast/parser/parseCommentsInTitles-expected.png: Removed.
platform/chromium-mac/fast/tokenizer/missing-title-end-tag-1-expected.checksum: Removed.
platform/chromium-mac/fast/tokenizer/missing-title-end-tag-1-expected.png: Removed.
platform/chromium-mac/fast/tokenizer/missing-title-end-tag-2-expected.checksum: Removed.
platform/chromium-mac/fast/tokenizer/missing-title-end-tag-2-expected.png: Removed.
platform/chromium-win/fast/parser/comment-in-style-expected.checksum: Removed.
platform/chromium-win/fast/parser/comment-in-style-expected.png: Removed.
platform/chromium-win/fast/parser/comment-in-style-expected.txt: Removed.
platform/chromium-win/fast/parser/parseCommentsInTitles-expected.checksum: Removed.
platform/chromium-win/fast/parser/parseCommentsInTitles-expected.png: Removed.
platform/chromium-win/fast/parser/parseCommentsInTitles-expected.txt: Removed.
platform/chromium-win/fast/tokenizer/missing-title-end-tag-1-expected.checksum: Removed.
platform/chromium-win/fast/tokenizer/missing-title-end-tag-1-expected.png: Removed.
platform/chromium-win/fast/tokenizer/missing-title-end-tag-2-expected.checksum: Removed.
platform/chromium-win/fast/tokenizer/missing-title-end-tag-2-expected.png: Removed.
platform/gtk/Skipped:
platform/mac/fast/parser/comment-in-style-expected.checksum: Removed.
platform/mac/fast/parser/comment-in-style-expected.png: Removed.
platform/mac/fast/parser/comment-in-style-expected.txt: Removed.
platform/mac/fast/parser/parseCommentsInTitles-expected.checksum: Removed.
platform/mac/fast/parser/parseCommentsInTitles-expected.png: Removed.
platform/mac/fast/parser/parseCommentsInTitles-expected.txt: Removed.
platform/mac/fast/tokenizer/missing-title-end-tag-1-expected.checksum: Removed.
platform/mac/fast/tokenizer/missing-title-end-tag-1-expected.png: Removed.
platform/mac/fast/tokenizer/missing-title-end-tag-1-expected.txt: Removed.
platform/mac/fast/tokenizer/missing-title-end-tag-2-expected.checksum: Removed.
platform/mac/fast/tokenizer/missing-title-end-tag-2-expected.png: Removed.
platform/mac/fast/tokenizer/missing-title-end-tag-2-expected.txt: Removed.
platform/qt/Skipped:
platform/qt/fast/parser/parseCommentsInTitles-expected.txt: Removed.
platform/qt/fast/tokenizer/missing-title-end-tag-1-expected.txt: Removed.
platform/qt/fast/tokenizer/missing-title-end-tag-2-expected.txt: Removed.

6:09 PM Changeset in webkit [74089] by morrita@google.com

5 edits in trunk

2010-12-02 MORITA Hajime <morrita@google.com>

Reviewed by Dimitri Glazkov.

[chromium] Fix drawing of inset box shadows
https://bugs.webkit.org/show_bug.cgi?id=41576

platform/chromium-win/fast/box-shadow/inset-expected.checksum:
platform/chromium-win/fast/box-shadow/inset-expected.png:

2010-12-02 MORITA Hajime <morrita@google.com>

Reviewed by Dimitri Glazkov.

[chromium] Fix drawing of inset box shadows
https://bugs.webkit.org/show_bug.cgi?id=41576

When clearing outside clipped path, the context contains unexpected transform.
Fixed to restore original state before the clear.

platform/graphics/skia/PlatformContextSkia.cpp: (WebCore::PlatformContextSkia::clipPathAntiAliased): (WebCore::PlatformContextSkia::applyAntiAliasedClipPaths):

6:03 PM Changeset in webkit [74088] by Stephanie Lewis

1 edit in trunk/WebKitTools/ChangeLog

Add a new Leopard Debug Test WK2 Bot

Reviewed by Stephanie Lewis.

BuildSlaveSupport/build.webkit.org-config/config.json:

6:00 PM Changeset in webkit [74087] by yael.aharon@nokia.com

1 edit
6 moves in trunk/LayoutTests

Unreviewed.

Move some new tests from mac-snowleopard to mac
https://bugs.webkit.org/show_bug.cgi?id=51075

platform/mac-snowleopard/fast/css/focus-ring-detached-expected.checksum: Removed.
platform/mac-snowleopard/fast/css/focus-ring-detached-expected.png: Removed.
platform/mac-snowleopard/fast/css/focus-ring-detached-expected.txt: Removed.
platform/mac-snowleopard/fast/css/focus-ring-multiline-expected.checksum: Removed.
platform/mac-snowleopard/fast/css/focus-ring-multiline-expected.png: Removed.
platform/mac-snowleopard/fast/css/focus-ring-multiline-expected.txt: Removed.
platform/mac/fast/css/focus-ring-detached-expected.checksum: Copied from LayoutTests/platform/mac-snowleopard/fast/css/focus-ring-detached-expected.checksum.
platform/mac/fast/css/focus-ring-detached-expected.png: Copied from LayoutTests/platform/mac-snowleopard/fast/css/focus-ring-detached-expected.png.
platform/mac/fast/css/focus-ring-detached-expected.txt: Copied from LayoutTests/platform/mac-snowleopard/fast/css/focus-ring-detached-expected.txt.
platform/mac/fast/css/focus-ring-multiline-expected.checksum: Copied from LayoutTests/platform/mac-snowleopard/fast/css/focus-ring-multiline-expected.checksum.
platform/mac/fast/css/focus-ring-multiline-expected.png: Copied from LayoutTests/platform/mac-snowleopard/fast/css/focus-ring-multiline-expected.png.
platform/mac/fast/css/focus-ring-multiline-expected.txt: Copied from LayoutTests/platform/mac-snowleopard/fast/css/focus-ring-multiline-expected.txt.

5:56 PM Changeset in webkit [74086] by andersca@apple.com

3 edits in trunk/WebCore

Mouse Events Not Received in Run Applet in their Own Process Mode
https://bugs.webkit.org/show_bug.cgi?id=51078
<rdar://problem/8333491>

Reviewed by Sam Weinig.

Make sure that Widget::handleEvent is called for applets as well.

html/HTMLAppletElement.cpp:

(WebCore::HTMLAppletElement::defaultEventHandler):

html/HTMLAppletElement.h:

5:52 PM Changeset in webkit [74085] by Simon Fraser

5 edits
2 adds in trunk

2010-12-14 Simon Fraser <Simon Fraser>

Reviewed by Chris Marrin.

Parts of page disappear
https://bugs.webkit.org/show_bug.cgi?id=41701

The page has text-indent: -1000000px on an element that becomes
compositing, causing a huge tiled layer to get created.

r63452 aimed to fix this by clamping layer bounds to the viewport,
but did not do so for pages running accelerated animations (since
we don't want to clamp for transform animations). However, this
page only has an opacity animation.

So refine the logic added for r63452 to only call setCompositingConsultsOverlap(false)
for transform animations.

Test: compositing/geometry/limit-layer-bounds-opacity-transition.html

rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::startAnimation): call didStartAcceleratedAnimation() with the appropriate properties, and clean up confusing logic that was used to compute the return value. We want to return true if either property is accelerated.

(WebCore::RenderLayerBacking::startTransition): Call didStartAcceleratedAnimation()
with the appropriate property.

rendering/RenderLayerCompositor.h:
rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::didStartAcceleratedAnimation): Pass the property in, and only turn off overlap testing if we see a transform animation.

5:50 PM Changeset in webkit [74084] by beidson@apple.com

6 edits
4 adds in trunk

WebCore: <rdar://problem/8225016> and https://bugs.webkit.org/show_bug.cgi?id=40138
Authorization header is sent from an HTTP Auth protected site on redirect
Test: http/tests/misc/authentication-sent-to-redirect.html

Reviewed by Alexey Proskuryakov.

Add helper to clear the Auth headers from a resource request:

platform/network/ResourceRequestBase.cpp:

(WebCore::ResourceRequestBase::clearHTTPAuthorization):

platform/network/ResourceRequestBase.h:

Only Mac and Windows CFNetwork ports seem to have this problem, so plug it for them:

platform/network/cf/ResourceHandleCFNet.cpp:

(WebCore::ResourceHandle::willSendRequest):

platform/network/mac/ResourceHandleMac.mm:

(WebCore::ResourceHandle::willSendRequest):

LayoutTests: <rdar://problem/8225016> and https://bugs.webkit.org/show_bug.cgi?id=40138
Authorization header is sent from an HTTP Auth protected site on redirect

Reviewed by Alexey Proskuryakov.

http/tests/misc/authentication-sent-to-redirect-expected.txt: Added.
http/tests/misc/authentication-sent-to-redirect.html: Added.
http/tests/misc/resources/auth-echo.php: Added.
http/tests/misc/resources/auth-then-redirect.php: Added.

5:32 PM Changeset in webkit [74083] by yael.aharon@nokia.com

3 edits in trunk/LayoutTests

Unreviewed .

Fix test results that I just committed. They seem to have extra newlines.

platform/mac-snowleopard/fast/css/focus-ring-detached-expected.txt:
platform/mac-snowleopard/fast/css/focus-ring-multiline-expected.txt:

5:26 PM Changeset in webkit [74082] by ojan@chromium.org

2 edits in trunk/WebKitTools

2010-12-14 Ojan Vafai <ojan@chromium.org>

Fix python unittests after http://trac.webkit.org/changeset/74070.

Scripts/webkitpy/style/checkers/test_expectations_unittest.py:

5:14 PM Changeset in webkit [74081] by tkent@chromium.org

4 edits in trunk/LayoutTests

2010-12-14 Kent Tamura <tkent@chromium.org>

Unreviewed. Test expectation update.

Rebaseline fast/forms/ValidityState-typeMismatch-url.html
http://crbug.com/66818

Chromium has different expectations because it doesn't use KURL.

platform/chromium-mac/fast/forms/ValidityState-typeMismatch-url-expected.txt:
platform/chromium-win/fast/forms/ValidityState-typeMismatch-url-expected.txt:
platform/chromium/test_expectations.txt:

5:13 PM Changeset in webkit [74080] by andersca@apple.com

2 edits in trunk/WebKit2

Fix Windows build.

win/WebKit2Common.vsprops:

5:11 PM Changeset in webkit [74079] by andersca@apple.com

2 edits in trunk/WebKit2

Fix Qt build.

WebKit2.pro:

5:10 PM Changeset in webkit [74078] by andersca@apple.com

2 edits in trunk/WebKit2

Fix a typo.

Reviewed by TYPO FIX.

Shared/Plugins/Netscape/mac/NetscapePluginModuleMac.mm:

(WebKit::NetscapePluginModule::determineQuirks):

5:06 PM Changeset in webkit [74077] by andersca@apple.com

8 edits
1 copy in trunk/WebKit2

Cannot type into plugin edit field
https://bugs.webkit.org/show_bug.cgi?id=51074
<rdar://problem/8483741>

Reviewed by Sam Weinig.

Add a PrognameShouldBeWebKitPluginHost quirk, since it turns out Flash Player calls getprogname() and checks
if the return value is "WebKitPluginHost" in order to determine when to handle NPCocoaEventKeyDown events.

PluginProcess/PluginProcess.cpp:

(WebKit::PluginProcess::netscapePluginModule):
If the plug-in module has the PrognameShouldBeWebKitPluginHost quirk, call setprocname("WebKitPluginHost").

Shared/Plugins/Netscape/NetscapePluginModule.cpp:

(WebKit::NetscapePluginModule::load):
Call determineQuirks()

Shared/Plugins/Netscape/mac/NetscapePluginModuleMac.mm:

(WebKit::NetscapePluginModule::determineQuirks):
Add the PrognameShouldBeWebKitPluginHost quirk for Flash.

Shared/Plugins/Netscape/win/NetscapePluginModuleWin.cpp:

(WebKit::NetscapePluginModule::determineQuirks):

Shared/Plugins/Netscape/x11/NetscapePluginModuleX11.cpp:

(WebKit::NetscapePluginModule::determineQuirks):
Add stubs.

Shared/Plugins/PluginQuirks.h:

Add new PluginQuirks file.

WebKit2.xcodeproj/project.pbxproj:

Add PluginQuirks.h

5:05 PM Changeset in webkit [74076] by mihaip@chromium.org

13 edits in trunk/LayoutTests

2010-12-14 Mihai Parparita <mihaip@chromium.org>

Unreviewed update of the pixel expectations for the Mac port.

Update expectations for tests whose output changed after the switch to
the HTML5 parser. The chromium-mac port did a similar rebaseline in
r64728.

The new expectations are for Snow Leopard. Current expectations are not
moved to mac-leopard, since they're not valid anymore.

platform/mac/fast/doctypes/003-expected.checksum:
platform/mac/fast/doctypes/003-expected.png:
platform/mac/fast/dom/isindex-001-expected.checksum:
platform/mac/fast/dom/isindex-001-expected.png:
platform/mac/fast/dom/isindex-002-expected.checksum:
platform/mac/fast/dom/isindex-002-expected.png:
platform/mac/fast/forms/isindex-placeholder-expected.checksum:
platform/mac/fast/forms/isindex-placeholder-expected.png:
platform/mac/fast/forms/text-style-color-expected.checksum:
platform/mac/fast/forms/text-style-color-expected.png:
platform/mac/tables/mozilla/other/wa_table_thtd_rowspan-expected.checksum:
platform/mac/tables/mozilla/other/wa_table_thtd_rowspan-expected.png:

4:52 PM Changeset in webkit [74075] by andersca@apple.com

3 edits
1 copy
1 add in trunk/WebKit2

Add a NetscapePluginModuleX11 and move the Qt implementation of PluginInfoStore::getPluginInfo there
https://bugs.webkit.org/show_bug.cgi?id=51066

Reviewed by Sam Weinig.

Shared/Plugins/Netscape/x11/NetscapePluginModuleX11.cpp: Copied from WebKit2/UIProcess/Plugins/qt/PluginInfoStoreQt.cpp.

(WebKit::NetscapePluginModule::getPluginInfo):

UIProcess/Plugins/qt/PluginInfoStoreQt.cpp:

(WebKit::PluginInfoStore::getPluginInfo):

WebKit2.pro:

4:51 PM Changeset in webkit [74074] by Simon Fraser

2 edits in trunk/WebCore

2010-12-14 Simon Fraser <Simon Fraser>

Reviewed by Chris Marrin.

Crash in WebCore::GraphicsLayer::paintGraphicsLayerContents() loading this URL
https://bugs.webkit.org/show_bug.cgi?id=51072

Fix a crash when painting a layer whose PlatformCALayer has been deleted,
by clearing the PlatformCALayer value on the CALayer when the PlatformCALayer
is destroyed.

I was not able to reduce the page to a simple testcase.

platform/graphics/ca/mac/PlatformCALayerMac.mm: (PlatformCALayer::~PlatformCALayer):

4:34 PM Changeset in webkit [74073] by andersca@apple.com

3 edits
2 adds in trunk/WebKit2

2010-12-14 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein.

Move Windows version of getPluginInfo to NetscapePluginModule
https://bugs.webkit.org/show_bug.cgi?id=51073

Shared/Plugins/Netscape/win/NetscapePluginModuleWin.cpp: Added. (WebKit::getVersionInfo): (WebKit::fileVersion): (WebKit::NetscapePluginModule::getPluginInfo):
UIProcess/Plugins/win/PluginInfoStoreWin.cpp: (WebKit::PluginInfoStore::getPluginInfo):
win/WebKit2.vcproj:

4:32 PM Changeset in webkit [74072] by tkent@chromium.org

2 edits in trunk/WebKitTools

2010-12-14 Kent Tamura <tkent@chromium.org>

Reviewed by Jian Li.

[DRT/Chromium] Remove a unnecessary error message
https://bugs.webkit.org/show_bug.cgi?id=51069

DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::paintInvalidatedRegion):

4:30 PM Changeset in webkit [74071] by Laszlo Gombos

2 edits in trunk/WebCore

2010-12-14 Laszlo Gombos < Laszlo Gombos>

Unreviewed, build fix.

[Qt] Fix the list of header files in WebCore.pro after r74049.

No new tests as there is no new functionality.

WebCore.pro:

4:28 PM Changeset in webkit [74070] by ojan@chromium.org

7 edits in trunk

2010-12-14 Benjamin Kalman <kalman@chromium.org>

Reviewed by Ojan Vafai.

Using BUG/BUGWK in test_expectations is error prone, should use BUGCR/BUGWK
https://bugs.webkit.org/show_bug.cgi?id=48926

Update all the text expectations files that have BUGXXX to either BUGCRXXX or (where
appropriate) BUGWKXXX.

platform/chromium-gpu/test_expectations.txt:
platform/chromium/test_expectations.txt:
platform/mac/test_expectations.txt:
platform/qt/test_expectations.txt:

2010-12-14 Benjamin Kalman <kalman@chromium.org>

Reviewed by Ojan Vafai.

Using BUG/BUGWK in test_expectations is error prone, should use BUGCR/BUGWK
https://bugs.webkit.org/show_bug.cgi?id=48926

Scripts/webkitpy/layout_tests/layout_package/test_expectations.py: Add presubmit check that BUG isn't used, either BUGCR/BUGWK/BUGV8_.

4:27 PM Changeset in webkit [74069] by yael.aharon@nokia.com

3 edits
15 adds in trunk

[Qt] Focus rings are ugly, rects should be united instead of drawn individually
https://bugs.webkit.org/show_bug.cgi?id=49953

Reviewed by Andreas Kling.

WebCore:

Create a QPainterPath and add to it the focus rects, one at a time.
Combine the 2 drawFocusRing functions into one function drawFocusRingForPath.

Tests: fast/css/focus-ring-detached.html

fast/css/focus-ring-multiline.html

platform/graphics/qt/GraphicsContextQt.cpp:

(WebCore::drawFocusRingForPath):
(WebCore::GraphicsContext::drawFocusRing):

LayoutTests:

fast/css/focus-ring-detached.html: Added.
fast/css/focus-ring-multiline.html: Added.
platform/mac-snowleopard/fast/css/focus-ring-detached-expected.checksum: Added.
platform/mac-snowleopard/fast/css/focus-ring-detached-expected.png: Added.
platform/mac-snowleopard/fast/css/focus-ring-detached-expected.txt: Added.
platform/mac-snowleopard/fast/css/focus-ring-multiline-expected.checksum: Added.
platform/mac-snowleopard/fast/css/focus-ring-multiline-expected.png: Added.
platform/mac-snowleopard/fast/css/focus-ring-multiline-expected.txt: Added.
platform/qt/fast/css/focus-ring-detached-expected.checksum: Added.
platform/qt/fast/css/focus-ring-detached-expected.png: Added.
platform/qt/fast/css/focus-ring-detached-expected.txt: Added.
platform/qt/fast/css/focus-ring-multiline-expected.checksum: Added.
platform/qt/fast/css/focus-ring-multiline-expected.png: Added.
platform/qt/fast/css/focus-ring-multiline-expected.txt: Added.

4:19 PM Changeset in webkit [74068] by mrowe@apple.com

2 edits in trunk/WebCore

Fix the Qt build.

xml/XSLTProcessorQt.cpp:

(WebCore::XSLTProcessor::transformToString): Make the conversion to QString explicit
since QVariant can be constructed from either a QString or a bool.

4:19 PM Changeset in webkit [74067] by rniwa@webkit.org

2 edits in trunk

2010-12-14 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Eric Seidel.

[git].DS_Store should be in .gitignore
https://bugs.webkit.org/show_bug.cgi?id=51065

Added .DS_Store to .gitignore.

.gitignore:

4:09 PM Changeset in webkit [74066] by Simon Fraser

10 edits in trunk/WebCore

2010-12-14 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein.

compositing/masks/simple-composited-mask.html failure
https://bugs.webkit.org/show_bug.cgi?id=49746

Geometry of composited layers with a mask depends on the loading
of the mask image, since maskClipRect() is used for the layer bounds.

So when RenderBox::imageChanged() is called for an image used by
a mask on a layer with a composited mask, call the newly-renamed
layer->contentsChanged() method. This percolates down into RenderLayerBacking,
ending in a layer geometry update.

Renamed RenderLayer::rendereContentsChanged() to contentsChanged() and added
an enum to say what changed, for somewhat more efficient updating.

Also, when the mask layer gets resized, make sure we mark it as needing
display.

Tested by pixel result of compositing/masks/simple-composited-mask.html

html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::didDraw):
html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::markContextChanged): (WebCore::WebGLRenderingContext::reshape):
rendering/RenderBox.cpp: (WebCore::layersUseImage): (WebCore::RenderBox::imageChanged):
rendering/RenderImage.cpp: (WebCore::RenderImage::imageDimensionsChanged): (WebCore::RenderImage::notifyFinished):
rendering/RenderLayer.cpp: (WebCore::RenderLayer::contentChanged):
rendering/RenderLayer.h:
rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::updateGraphicsLayerGeometry): (WebCore::RenderLayerBacking::contentChanged):
rendering/RenderLayerBacking.h:
rendering/RenderVideo.cpp: (WebCore::RenderVideo::updatePlayer):

3:54 PM Changeset in webkit [74065] by mrowe@apple.com

6 edits in trunk

<http://webkit.org/b/51064> Reproducible crash inside WebCore::MediaPlayerPrivateQTKit::createQTMovie when loading <video>

Reviewed by Sam Weinig.

JavaScriptCore:

wtf/text/WTFString.h: Prevent String from being implicitly convertable to bool.

It was previously implicitly convertible to bool on Mac via operator NSString*,
but since that always has a non-zero return value it would give unexpected results.

WebCore:

We were crashing inside MediaPlayerPrivateQTKit::createQTMovie as we were passing a null URL in
to CFNetworkCopyProxiesForURL. This happened because we were null-checking the URL incorrectly.

platform/graphics/mac/MediaPlayerPrivateQTKit.mm:

(WebCore::MediaPlayerPrivateQTKit::resumeLoad): Explicitly test for a null string.

WebKit/mac:

History/WebHistoryItem.mm:

(-[WebHistoryItem description]): Test whether the string is empty rather than incorrectly
always including the target in the output.

3:37 PM Changeset in webkit [74064] by alice.liu@apple.com

2 edits in trunk/WebKit2

Fix clang++ build.

UIProcess/WebProcessProxy.h:

(WebKit::WebProcessProxy::sendSync):
Move the default argument to the declaration.

3:01 PM Changeset in webkit [74063] by hyatt@apple.com

9 edits
3 adds in trunk

https://bugs.webkit.org/show_bug.cgi?id=50970

Reviewed by Dan Bernstein.

It's arguably a bug, but we don't let inline flow layers paint floating
descendants. The containing block of the inline flow paints them instead.
However our shouldPaint logic has always been flawed and has turned off propagation
of painting when an inline flow layer is enclosing the float.

Change enclosingSelfPaintingLayer to enclosingFloatPaintingLayer to be more precise
and for now limit it to RenderBoxes.

Added fast/block/float/floatstack.html

WebCore:

rendering/RenderBlock.cpp:

(WebCore::RenderBlock::addOverhangingFloats):

rendering/RenderBox.cpp:

(WebCore::RenderBox::enclosingFloatPaintingLayer):

rendering/RenderBox.h:
rendering/RenderObject.cpp:
rendering/RenderObject.h:

LayoutTests:

fast/block/float/floatstack.html: Added.
platform/mac/fast/block/float/floatstack-expected.checksum: Added.
platform/mac/fast/block/float/floatstack-expected.png: Added.
platform/mac/fast/block/float/floatstack-expected.txt: Added.
platform/mac/fast/repaint/positioned-document-element-expected.checksum:
platform/mac/fast/repaint/positioned-document-element-expected.png:

2:52 PM Changeset in webkit [74062] by mihaip@chromium.org

14 edits
2 adds in trunk

2010-12-14 Mihai Parparita <mihaip@chromium.org>

Reviewed by Dimitri Glazkov.

Move asynchronous event dispatching out of Document
https://bugs.webkit.org/show_bug.cgi?id=49785

Move asynchonous event code out of Document and into a standalone
EventQueue class (which supports async events for both regular nodes
and the window object).

No new tests necessary, since no new functionality is exposed (existing
layout tests pass).

Android.mk:
CMakeLists.txt:
GNUmakefile.am:
WebCore.gypi:
WebCore.pro:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
dom/Document.cpp: (WebCore::Document::Document): (WebCore::Document::enqueueWindowEvent): (WebCore::Document::enqueueHashchangeEvent):
dom/DOMAllInOne.cpp: (WebCore::Document::eventQueue):
dom/Document.h:
dom/EventQueue.cpp: Added. (WebCore::EventQueue::EventQueue): (WebCore::EventQueue::enqueueEvent): (WebCore::EventQueue::pendingEventTimerFired): (WebCore::EventQueue::dispatchEvent):
dom/EventQueue.h: Added.
storage/StorageEventDispatcher.cpp: (WebCore::StorageEventDispatcher::dispatch):

2010-12-14 Mihai Parparita <mihaip@chromium.org>

Reviewed by Dimitri Glazkov.

Move asynchronous event dispatching out of Document
https://bugs.webkit.org/show_bug.cgi?id=49785

Change enqueueEvent callsite.

src/StorageAreaProxy.cpp: (WebCore::StorageAreaProxy::storageEvent):

2:40 PM Changeset in webkit [74061] by andersca@apple.com

4 edits
1 copy
1 add in trunk/WebKit2

Move PluginInfoStore::getPluginInfo to NetscapePluginModule
https://bugs.webkit.org/show_bug.cgi?id=51058

Reviewed by Adam Roben.

Shared/Plugins/Netscape/mac/NetscapePluginModuleMac.mm:

Move implementation of PluginInfoStore::getPluginInfo and related
helper functions here.

UIProcess/Plugins/mac/PluginInfoStoreMac.mm:

(WebKit::PluginInfoStore::getPluginInfo):
Just call NetscapePluginModule::getPluginInfo here for now.

WebKit2.xcodeproj/project.pbxproj:

Add NetscapePluginModuleMac.mm.

2:04 PM Changeset in webkit [74060] by andersca@apple.com

2 edits in trunk/WebKit2

2010-12-14 Anders Carlsson <andersca@apple.com>

Reviewed by John Sullivan.

Switch name and description order when fetching Carbon plug-in info
https://bugs.webkit.org/show_bug.cgi?id=46211

The plug-in description comes before the name in the Carbon string list resource.

UIProcess/Plugins/mac/PluginInfoStoreMac.mm: (WebKit::getPluginInfoFromCarbonResources):

1:54 PM PythonGuidelines edited by dpranke@chromium.org

add a note adding WebKitTools/Scripts to your PYTHONPATH (diff)

1:52 PM Changeset in webkit [74059] by commit-queue@webkit.org

2 edits in trunk/WebCore

2010-12-14 Kyounga Ra <kyounga.ra@gmail.com>

Reviewed by Adam Barth.

<noscript> is rendered with enabled XHTMLMP.
https://bugs.webkit.org/show_bug.cgi?id=48493

html/HTMLElement.cpp: (WebCore::HTMLElement::rendererIsNeeded):

1:45 PM Changeset in webkit [74058] by andersca@apple.com

5 edits
2 moves
1 add in trunk/WebKit2

Move NetscapePluginModule.{cpp|h} to Shared/Plugins/Netscape
https://bugs.webkit.org/show_bug.cgi?id=51052

Reviewed by Adam Roben.

Shared/Plugins/Netscape/NetscapePluginModule.cpp: Renamed from WebKit2/WebProcess/Plugins/Netscape/NetscapePluginModule.cpp.
Shared/Plugins/Netscape/NetscapePluginModule.h: Renamed from WebKit2/WebProcess/Plugins/Netscape/NetscapePluginModule.h.
WebKit2.pro:
WebKit2.xcodeproj/project.pbxproj:
win/WebKit2.vcproj:
win/WebKit2Common.vsprops:

1:35 PM Changeset in webkit [74057] by commit-queue@webkit.org

2 edits in trunk/WebKit/qt

2010-12-14 Viatcheslav Ostapenko <ostapenko.viatcheslav@nokia.com>

Reviewed by Laszlo Gombos.

[Qt] Flash plugins should be windowless on QGraphicsWebView on Symbian
Remove #idef SYMBIAN introduced by r69396.
https://bugs.webkit.org/show_bug.cgi?id=50487

WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::createPlugin):

1:20 PM Changeset in webkit [74056] by Laszlo Gombos

8 edits in trunk

2010-12-14 Laszlo Gombos <Laszlo Gombos>

Reviewed by Eric Seidel.

[Qt] [Symbian] Do not use pkg-config on Symbian as it is not supported
https://bugs.webkit.org/show_bug.cgi?id=50231

Guard CONFIG+=link_pkgconfig with !symbian.

jsc.pro:

2010-12-14 Laszlo Gombos <Laszlo Gombos>

Reviewed by Eric Seidel.

[Qt] [Symbian] Do not use pkg-config on Symbian as it is not supported
https://bugs.webkit.org/show_bug.cgi?id=50231

No new tests as there is no new functionality.

Guard CONFIG+=link_pkgconfig with !symbian.

WebCore.pro:

2010-12-14 Laszlo Gombos <Laszlo Gombos>

Reviewed by Eric Seidel.

[Qt] [Symbian] Do not use pkg-config on Symbian as it is not supported
https://bugs.webkit.org/show_bug.cgi?id=50231

Guard CONFIG+=link_pkgconfig with !symbian.

DumpRenderTree/qt/DumpRenderTree.pro:
WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
WebKitTestRunner/qt/WebKitTestRunner.pro:

1:06 PM Changeset in webkit [74055] by Adam Roben

2 edits in trunk/WebKit/win

Always record the last-set cursor, even when the UI delegate is setting the cursor for us

Prior to r63339, the last-set cursor was recorded in Widget::setCursor.
r63339 moved that code up to WebChromeClient, but failed to call it
when the UI delegate was the one setting the cursor.

Fixes <http://webkit.org/b/45692> <rdar://problem/8423464> REGRESSION
(r63339): Mouse cursor disappears when holding mouse button down on
page

Reviewed by Ada Chan.

WebCoreSupport/WebChromeClient.cpp:

(WebChromeClient::setCursor): After the cursor is set, regardless of
whether the UI delegate sets it or we set it, record the cursor that
was just set. That way we'll be able to use the cursor later when
responding to the WM_SETCURSOR message.

1:04 PM Changeset in webkit [74054] by commit-queue@webkit.org

10 edits
3 deletes in trunk

2010-12-14 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r74040.
http://trac.webkit.org/changeset/74040
https://bugs.webkit.org/show_bug.cgi?id=51050

Breaks 2d.shadow.canvas.transparent.2 and
2d.shadow.image.transparent.2 (Requested by helder on
#webkit).

fast/canvas/canvas-scale-strokePath-shadow-expected.txt:
fast/canvas/canvas-transforms-fillRect-shadow-expected.txt: Removed.
fast/canvas/canvas-transforms-fillRect-shadow.html: Removed.
fast/canvas/script-tests/canvas-scale-fillPath-shadow.js:
fast/canvas/script-tests/canvas-scale-fillRect-shadow.js:
fast/canvas/script-tests/canvas-scale-strokePath-shadow.js:
fast/canvas/script-tests/canvas-transforms-fillRect-shadow.js: Removed.

2010-12-14 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r74040.
http://trac.webkit.org/changeset/74040
https://bugs.webkit.org/show_bug.cgi?id=51050

Breaks 2d.shadow.canvas.transparent.2 and
2d.shadow.image.transparent.2 (Requested by helder on
#webkit).

platform/graphics/ContextShadow.cpp: (WebCore::ContextShadow::ContextShadow): (WebCore::ContextShadow::calculateLayerBoundingRect):
platform/graphics/ContextShadow.h: (WebCore::ContextShadow::offset):
platform/graphics/qt/ContextShadowQt.cpp: (WebCore::ContextShadow::beginShadowLayer): (WebCore::ContextShadow::endShadowLayer):
platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::fillPath): (WebCore::GraphicsContext::strokePath): (WebCore::GraphicsContext::fillRect): (WebCore::GraphicsContext::fillRoundedRect): (WebCore::GraphicsContext::setPlatformShadow):

12:51 PM Changeset in webkit [74053] by mihaip@chromium.org

116 edits
52 copies
1 add in trunk/LayoutTests

2010-12-14 Mihai Parparita <mihaip@chromium.org>

Update the pixel expectations for the Mac port.

For the tests that currently fail on Snow Leopard with --pixel-tests
--tolerance 0, this moves the current pixel results to mac-leopard and
adds new Snow Leopard-specific results to platform/mac.

List of files omitted due to length but composed entirely of moves from
platform/mac to platform/mac-leopard and newly added files in
platform/mac.

Also removes most of platform/mac/test_expectations.txt, those
expectations were from April and are un-maintained.

12:43 PM Changeset in webkit [74052] by Nate Chapin

3 edits in trunk/WebCore

2010-12-14 Nate Chapin <Nate Chapin>

Unreviewed, fixing qt (hopefully for real this time).

Remove a couple more references to loader.h.

xml/XSLStyleSheetQt.cpp:
xml/XSLTProcessorQt.cpp:

12:32 PM Changeset in webkit [74051] by jianli@chromium.org

8 edits
9 adds in trunk/LayoutTests

Unreviewed. Added missing expectations in chromium-mac-leopard to
complete the move in r74042.

platform/chromium-mac-leopard/editing/deleting/5144139-2-expected.checksum:
platform/chromium-mac-leopard/editing/deleting/5144139-2-expected.png:
platform/chromium-mac-leopard/editing/selection/extend-selection-bidi-expected.checksum:
platform/chromium-mac-leopard/editing/selection/extend-selection-bidi-expected.png:
platform/chromium-mac-leopard/fast/text/complex-text-opacity-expected.checksum:
platform/chromium-mac-leopard/fast/text/complex-text-opacity-expected.png:
platform/chromium-mac-leopard/fast/text/complex-text-opacity-expected.txt:
platform/chromium-mac-leopard/fast/text/international/bidi-mirror-he-ar-expected.checksum: Added.
platform/chromium-mac-leopard/fast/text/international/bidi-mirror-he-ar-expected.png: Added.
platform/chromium-mac-leopard/fast/text/international/bidi-mirror-he-ar-expected.txt: Added.
platform/chromium-mac-leopard/fast/text/international/bidi-neutral-directionality-paragraph-start-expected.checksum: Added.
platform/chromium-mac-leopard/fast/text/international/bidi-neutral-directionality-paragraph-start-expected.png: Added.
platform/chromium-mac-leopard/fast/text/international/bidi-neutral-directionality-paragraph-start-expected.txt: Added.
platform/chromium-mac-leopard/fast/text/international/bidi-neutral-run-expected.checksum: Added.
platform/chromium-mac-leopard/fast/text/international/bidi-neutral-run-expected.png: Added.
platform/chromium-mac-leopard/fast/text/international/bidi-neutral-run-expected.txt: Added.

12:31 PM Changeset in webkit [74050] by Nate Chapin

4 edits in trunk/WebCore

2010-12-14 Nate Chapin <Nate Chapin>

Unreviewed, fix mac and qt builds.

Missed a couple of references to loader.h and
improperly added CachedResourceRequest.h to
WebCore.xcodeproj.

WebCore.xcodeproj/project.pbxproj:
platform/android/TemporaryLinkStubs.cpp:
platform/qt/TemporaryLinkStubsQt.cpp:

12:09 PM Changeset in webkit [74049] by Nate Chapin

18 edits
2 moves in trunk/WebCore

2010-12-14 Nate Chapin <Nate Chapin>

Reviewed by Adam Barth.

Rename Loader to CachedResourceRequest.
https://bugs.webkit.org/show_bug.cgi?id=50848

No new tests, rename only.

Android.mk:
CMakeLists.txt:
GNUmakefile.am:
WebCore.gypi:
WebCore.pro:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
css/CSSStyleSelector.cpp:
loader/cache/CachedCSSStyleSheet.cpp:
loader/cache/CachedFont.cpp:
loader/cache/CachedResource.cpp: (WebCore::CachedResource::setRequest):
loader/cache/CachedResource.h:
loader/cache/CachedResourceLoader.cpp: (WebCore::CachedResourceLoader::load): (WebCore::CachedResourceLoader::loadDone): (WebCore::CachedResourceLoader::cancelRequests):
loader/cache/CachedResourceLoader.h:
loader/cache/CachedResourceRequest.cpp: Copied from WebCore/loader/loader.cpp.
loader/cache/CachedResourceRequest.h: Copied from WebCore/loader/loader.h.
loader/loader.cpp: Removed.
loader/loader.h: Removed.
xml/XSLStyleSheetLibxslt.cpp:
xml/XSLTProcessor.cpp:
xml/XSLTProcessorLibxslt.cpp:

11:58 AM Changeset in webkit [74048] by hyatt@apple.com

13 edits in trunk/WebCore

https://bugs.webkit.org/show_bug.cgi?id=46422

Reviewed by Tim Hatcher.

Rename pageHeight variables and members in WebCore to pageLogicalHeight in preparation for
making printing and pagination work with vertical writing modes.

page/FrameView.cpp:

(WebCore::FrameView::forceLayoutForPagination):

rendering/LayoutState.cpp:

(WebCore::LayoutState::LayoutState):
(WebCore::LayoutState::clearPaginationInformation):

rendering/LayoutState.h:

(WebCore::LayoutState::LayoutState):
(WebCore::LayoutState::isPaginated):
(WebCore::LayoutState::pageLogicalHeight):
(WebCore::LayoutState::pageLogicalHeightChanged):

rendering/RenderBlock.cpp:

(WebCore::RenderBlock::layoutBlock):
(WebCore::RenderBlock::markForPaginationRelayoutIfNeeded):
(WebCore::RenderBlock::insertFloatingObject):
(WebCore::RenderBlock::layoutColumns):
(WebCore::RenderBlock::nextPageTop):
(WebCore::RenderBlock::applyBeforeBreak):
(WebCore::RenderBlock::applyAfterBreak):
(WebCore::RenderBlock::adjustForUnsplittableChild):
(WebCore::RenderBlock::adjustLinePositionForPagination):

rendering/RenderBlock.h:
rendering/RenderBox.cpp:

(WebCore::RenderBox::computeLogicalHeight):

rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::layoutBlock):

rendering/RenderTable.cpp:

(WebCore::RenderTable::layout):

rendering/RenderTableRow.cpp:

(WebCore::RenderTableRow::layout):

rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::layoutRows):

rendering/RenderView.cpp:

(WebCore::RenderView::RenderView):
(WebCore::RenderView::layout):

rendering/RenderView.h:

(WebCore::RenderView::pageLogicalHeight):
(WebCore::RenderView::setPageLogicalHeight):

11:57 AM Changeset in webkit [74047] by Dimitri Glazkov

2 edits in trunk/WebCore

2010-12-14 Dimitri Glazkov <Dimitri Glazkov>

Fix GTK build by adding source files that were accidentally skipped in
r74044. Sorry!

GNUmakefile.am: Added SliderThumbElement.

11:41 AM Changeset in webkit [74046] by andersca@apple.com

18 edits
2 adds in trunk/WebKit2

Handle complex text input for plug-ins
https://bugs.webkit.org/show_bug.cgi?id=51047

Reviewed by Sam Weinig.

PluginProcess/PluginControllerProxy.cpp:

(WebKit::PluginControllerProxy::sendComplexTextInput):
Pass along the text input to the plug-in.

PluginProcess/PluginControllerProxy.messages.in:

Add SendComplexTextInput message.

UIProcess/API/mac/WKTextInputWindowController.h: Added.
UIProcess/API/mac/WKTextInputWindowController.mm: Added.

Add text input window controller, mostly copied from WebKit1.

UIProcess/API/mac/WKView.mm:

(-[WKView keyDown:]):
If needed, pass along the event to the text input window controller.

(-[WKView inputContext]):
Return the input context of the text input window controller.

(-[WKView _setComplexTextInputEnabled:pluginComplexTextInputIdentifier:]):
Notify the input window controller that the input source changed.

UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::sendComplexTextInputToPlugin):
Send the complex text input to the web process.

WebKit2.xcodeproj/project.pbxproj:

Add new files.

WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:

(WebKit::convertStringToKeyCodes):
Convert a string to a vector of key codes in the current encoding.

(WebKit::NetscapePlugin::sendComplexTextInput):
In the Cocoa event model, create and dispatch an NPCocoaEventTextInput event.
In the Carbon event model, convert the string to individual key codes and send them
as key down events.

WebProcess/Plugins/PluginProxy.cpp:

(WebKit::PluginProxy::sendComplexTextInput):
Send the text to the plug-in controller proxy.

WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::sendComplexTextInput):
If the plug-in has a matching text input identifier, call Plugin::sendComplexTextInput.

WebProcess/WebPage/WebPage.messages.in:

Add SendComplexTextInputToPlugin message.

WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::WebPage::sendComplexTextInputToPlugin):
Iterate over all known plug-in views and try to find one to send the text input to.

11:34 AM Changeset in webkit [74045] by Beth Dakin

3 edits
2 adds in trunk

WebCore: Fix for https://bugs.webkit.org/show_bug.cgi?id=50974
getComputedStyle() returns wrong values for zoomed elements when
display is none
-and corresponding-
<rdar://problem/8522731>

Reviewed by Darin Adler.

If there is no renderer but the RenderStyle's value is a fixed
length, send it through zoomAdjustedPixelValue(). There's not much
we can do for other length types without a renderer.

css/CSSComputedStyleDeclaration.cpp:

(WebCore::zoomAdjustedPixelValueForLength):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

LayoutTests: New test for https://bugs.webkit.org/show_bug.cgi?id=50974
getComputedStyle() returns wrong values for zoomed elements when
display is none
-and corresponding-
<rdar://problem/8522731>

Reviewed by Darin Adler.

fast/css/getComputedStyle/zoom-on-display-none-expected.txt: Added.
fast/css/getComputedStyle/zoom-on-display-none.html: Added.

11:30 AM Changeset in webkit [74044] by Dimitri Glazkov

11 edits
3 adds in trunk/WebCore

2010-12-13 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by David Levin.

Move SliderThumbElement into its own file.
https://bugs.webkit.org/show_bug.cgi?id=50973

No change in behavior, so no tests.

Android.mk: Added SliderThumbElement.
CMakeLists.txt: Ditto.
WebCore.gyp/WebCore.gyp: Ditto.
WebCore.gypi: Ditto.
WebCore.pro: Ditto.
WebCore.vcproj/WebCore.vcproj: Ditto.
WebCore.xcodeproj/project.pbxproj: Ditto,
html/shadow/SliderThumbElement.cpp: Added.
html/shadow/SliderThumbElement.h: Added.
rendering/RenderSlider.cpp: Removed code that was moved into

SliderThumbElement.

11:09 AM Changeset in webkit [74043] by andersca@apple.com

4 edits in trunk/WebKitLibraries

Add WKGetScriptCodeFromCurrentKeyboardInputSource function.

Reviewed by Dan Bernstein.

WebKitSystemInterface.h:
libWebKitSystemInterfaceLeopard.a:
libWebKitSystemInterfaceSnowLeopard.a:

10:40 AM Changeset in webkit [74042] by pfeldman@chromium.org

121 edits
135 deletes in trunk/LayoutTests

2010-12-14 Pavel Feldman <pfeldman@chromium.org>

Not reviewed. Move chromium-mac expectations to chromium-mac-leopard.

platform/chromium-mac-leopard/css2.1/t0805-c5518-brdr-t-01-e-expected.checksum:
platform/chromium-mac-leopard/css2.1/t0805-c5518-brdr-t-01-e-expected.png:
platform/chromium-mac-leopard/css2.1/t0805-c5519-brdr-r-00-a-expected.checksum:
platform/chromium-mac-leopard/css2.1/t0805-c5519-brdr-r-00-a-expected.png:
platform/chromium-mac-leopard/css2.1/t0805-c5520-brdr-b-01-e-expected.checksum:
platform/chromium-mac-leopard/css2.1/t0805-c5520-brdr-b-01-e-expected.png:
platform/chromium-mac-leopard/css2.1/t0805-c5521-brdr-l-00-a-expected.checksum:
platform/chromium-mac-leopard/css2.1/t0805-c5521-brdr-l-00-a-expected.png:
platform/chromium-mac-leopard/css2.1/t0805-c5521-brdr-l-01-e-expected.checksum:
platform/chromium-mac-leopard/css2.1/t0805-c5521-brdr-l-01-e-expected.png:
platform/chromium-mac-leopard/css2.1/t0805-c5521-ibrdr-l-00-a-expected.checksum:
platform/chromium-mac-leopard/css2.1/t0805-c5521-ibrdr-l-00-a-expected.png:
platform/chromium-mac-leopard/css2.1/t0905-c414-flt-02-c-expected.checksum:
platform/chromium-mac-leopard/css2.1/t0905-c414-flt-02-c-expected.png:
platform/chromium-mac-leopard/css2.1/t0905-c414-flt-03-c-expected.checksum:
platform/chromium-mac-leopard/css2.1/t0905-c414-flt-03-c-expected.png:
platform/chromium-mac-leopard/css2.1/t0905-c414-flt-04-c-expected.checksum:
platform/chromium-mac-leopard/css2.1/t0905-c414-flt-04-c-expected.png:
platform/chromium-mac-leopard/css2.1/t0905-c414-flt-fit-01-d-g-expected.checksum:
platform/chromium-mac-leopard/css2.1/t0905-c414-flt-fit-01-d-g-expected.png:
platform/chromium-mac-leopard/css2.1/t0905-c5525-fltblck-01-d-expected.checksum:
platform/chromium-mac-leopard/css2.1/t0905-c5525-fltblck-01-d-expected.png:
platform/chromium-mac-leopard/css2.1/t0905-c5525-fltcont-00-d-g-expected.checksum:
platform/chromium-mac-leopard/css2.1/t0905-c5525-fltcont-00-d-g-expected.png:
platform/chromium-mac-leopard/css2.1/t0905-c5525-fltwidth-03-c-g-expected.checksum:
platform/chromium-mac-leopard/css2.1/t0905-c5525-fltwidth-03-c-g-expected.png:
platform/chromium-mac-leopard/css2.1/t090501-c414-flt-01-b-expected.checksum:
platform/chromium-mac-leopard/css2.1/t090501-c414-flt-01-b-expected.png:
platform/chromium-mac-leopard/css2.1/t090501-c5525-flt-l-00-b-g-expected.checksum:
platform/chromium-mac-leopard/css2.1/t090501-c5525-flt-l-00-b-g-expected.png:
platform/chromium-mac-leopard/css2.1/t090501-c5525-flt-r-00-b-g-expected.checksum:
platform/chromium-mac-leopard/css2.1/t090501-c5525-flt-r-00-b-g-expected.png:
platform/chromium-mac-leopard/css2.1/t1202-counter-03-b-expected.checksum:
platform/chromium-mac-leopard/css2.1/t1202-counter-03-b-expected.png:
platform/chromium-mac-leopard/css2.1/t1202-counter-04-b-expected.checksum:
platform/chromium-mac-leopard/css2.1/t1202-counter-04-b-expected.png:
platform/chromium-mac-leopard/css2.1/t1202-counter-09-b-expected.checksum:
platform/chromium-mac-leopard/css2.1/t1202-counter-09-b-expected.png:
platform/chromium-mac-leopard/css2.1/t1202-counters-03-b-expected.checksum:
platform/chromium-mac-leopard/css2.1/t1202-counters-03-b-expected.png:
platform/chromium-mac-leopard/css2.1/t1202-counters-04-b-expected.checksum:
platform/chromium-mac-leopard/css2.1/t1202-counters-04-b-expected.png:
platform/chromium-mac-leopard/fast/css/beforeSelectorOnCodeElement-expected.checksum:
platform/chromium-mac-leopard/fast/css/beforeSelectorOnCodeElement-expected.png:
platform/chromium-mac-leopard/fast/css/font-face-opentype-expected.checksum:
platform/chromium-mac-leopard/fast/css/font-face-opentype-expected.png:
platform/chromium-mac-leopard/fast/css/rtl-ordering-expected.checksum:
platform/chromium-mac-leopard/fast/css/rtl-ordering-expected.png:
platform/chromium-mac-leopard/fast/css/text-overflow-ellipsis-bidi-expected.checksum:
platform/chromium-mac-leopard/fast/css/text-overflow-ellipsis-bidi-expected.png:
platform/chromium-mac-leopard/fast/css/text-security-expected.checksum:
platform/chromium-mac-leopard/fast/css/text-security-expected.png:
platform/chromium-mac-leopard/fast/encoding/denormalised-voiced-japanese-chars-expected.checksum:
platform/chromium-mac-leopard/fast/encoding/denormalised-voiced-japanese-chars-expected.png:
platform/chromium-mac-leopard/fast/encoding/invalid-UTF-8-expected.checksum:
platform/chromium-mac-leopard/fast/encoding/invalid-UTF-8-expected.png:
platform/chromium-mac-leopard/fast/forms/select-visual-hebrew-expected.checksum:
platform/chromium-mac-leopard/fast/forms/select-visual-hebrew-expected.png:
platform/chromium-mac-leopard/fast/forms/visual-hebrew-text-field-expected.checksum:
platform/chromium-mac-leopard/fast/forms/visual-hebrew-text-field-expected.png:
platform/chromium-mac-leopard/fast/text/bidi-embedding-pop-and-push-same-expected.checksum:
platform/chromium-mac-leopard/fast/text/bidi-embedding-pop-and-push-same-expected.png:
platform/chromium-mac-leopard/fast/text/cg-fallback-bolding-expected.checksum:
platform/chromium-mac-leopard/fast/text/cg-fallback-bolding-expected.png:
platform/chromium-mac-leopard/fast/text/in-rendered-text-rtl-expected.checksum:
platform/chromium-mac-leopard/fast/text/in-rendered-text-rtl-expected.png:
platform/chromium-mac-leopard/fast/text/international/001-expected.checksum:
platform/chromium-mac-leopard/fast/text/international/001-expected.png:
platform/chromium-mac-leopard/fast/text/international/bidi-AN-after-L-expected.checksum:
platform/chromium-mac-leopard/fast/text/international/bidi-AN-after-L-expected.png:
platform/chromium-mac-leopard/fast/text/international/bidi-AN-after-empty-run-expected.checksum:
platform/chromium-mac-leopard/fast/text/international/bidi-AN-after-empty-run-expected.png:
platform/chromium-mac-leopard/fast/text/international/bidi-AN-after-empty-run-expected.txt:
platform/chromium-mac-leopard/fast/text/international/bidi-CS-after-AN-expected.checksum:
platform/chromium-mac-leopard/fast/text/international/bidi-CS-after-AN-expected.png:
platform/chromium-mac-leopard/fast/text/international/bidi-CS-after-AN-expected.txt:
platform/chromium-mac-leopard/fast/text/international/bidi-L2-run-reordering-expected.checksum:
platform/chromium-mac-leopard/fast/text/international/bidi-L2-run-reordering-expected.png:
platform/chromium-mac-leopard/fast/text/international/bidi-LDB-2-CSS-expected.checksum:
platform/chromium-mac-leopard/fast/text/international/bidi-LDB-2-CSS-expected.png:
platform/chromium-mac-leopard/fast/text/international/bidi-LDB-2-HTML-expected.checksum:
platform/chromium-mac-leopard/fast/text/international/bidi-LDB-2-HTML-expected.png:
platform/chromium-mac-leopard/fast/text/international/bidi-LDB-2-formatting-characters-expected.checksum:
platform/chromium-mac-leopard/fast/text/international/bidi-LDB-2-formatting-characters-expected.png:
platform/chromium-mac-leopard/fast/text/international/bidi-european-terminators-expected.checksum:
platform/chromium-mac-leopard/fast/text/international/bidi-european-terminators-expected.png:
platform/chromium-mac-leopard/fast/text/international/bidi-ignored-for-first-child-inline-expected.checksum:
platform/chromium-mac-leopard/fast/text/international/bidi-ignored-for-first-child-inline-expected.png:
platform/chromium-mac-leopard/fast/text/international/bidi-innertext-expected.checksum:
platform/chromium-mac-leopard/fast/text/international/bidi-innertext-expected.png:
platform/chromium-mac-leopard/fast/text/international/bidi-linebreak-001-expected.checksum:
platform/chromium-mac-leopard/fast/text/international/bidi-linebreak-001-expected.png:
platform/chromium-mac-leopard/fast/text/international/bidi-linebreak-002-expected.checksum:
platform/chromium-mac-leopard/fast/text/international/bidi-linebreak-002-expected.png:
platform/chromium-mac-leopard/fast/text/international/bidi-linebreak-003-expected.checksum:
platform/chromium-mac-leopard/fast/text/international/bidi-linebreak-003-expected.png:
platform/chromium-mac-leopard/fast/text/international/bidi-listbox-atsui-expected.checksum:
platform/chromium-mac-leopard/fast/text/international/bidi-listbox-atsui-expected.png:
platform/chromium-mac-leopard/fast/text/international/bidi-listbox-expected.checksum:
platform/chromium-mac-leopard/fast/text/international/bidi-listbox-expected.png:
platform/chromium-mac-leopard/fast/text/international/bidi-override-expected.checksum:
platform/chromium-mac-leopard/fast/text/international/bidi-override-expected.png:
platform/chromium-mac-leopard/fast/text/international/danda-space-expected.checksum:
platform/chromium-mac-leopard/fast/text/international/danda-space-expected.png:
platform/chromium-mac-leopard/fast/text/international/hebrew-vowels-expected.checksum:
platform/chromium-mac-leopard/fast/text/international/hebrew-vowels-expected.png:
platform/chromium-mac-leopard/fast/text/international/hindi-spacing-expected.checksum:
platform/chromium-mac-leopard/fast/text/international/hindi-spacing-expected.png:
platform/chromium-mac-leopard/fast/text/international/hindi-whitespace-expected.checksum:
platform/chromium-mac-leopard/fast/text/international/hindi-whitespace-expected.png:
platform/chromium-mac-leopard/fast/text/international/plane2-expected.checksum:
platform/chromium-mac-leopard/fast/text/international/plane2-expected.png:
platform/chromium-mac-leopard/fast/text/international/rtl-caret-expected.checksum:
platform/chromium-mac-leopard/fast/text/international/rtl-caret-expected.png:
platform/chromium-mac-leopard/fast/text/international/thai-baht-space-expected.checksum:
platform/chromium-mac-leopard/fast/text/international/thai-baht-space-expected.png:
platform/chromium-mac-leopard/fast/text/international/thai-baht-space-expected.txt:
platform/chromium-mac-leopard/fast/text/international/wrap-CJK-001-expected.checksum:
platform/chromium-mac-leopard/fast/text/international/wrap-CJK-001-expected.png:
platform/chromium-mac/css2.1/t0805-c5518-brdr-t-01-e-expected.checksum: Removed.
platform/chromium-mac/css2.1/t0805-c5518-brdr-t-01-e-expected.png: Removed.
platform/chromium-mac/css2.1/t0805-c5519-brdr-r-00-a-expected.checksum: Removed.
platform/chromium-mac/css2.1/t0805-c5519-brdr-r-00-a-expected.png: Removed.
platform/chromium-mac/css2.1/t0805-c5520-brdr-b-01-e-expected.checksum: Removed.
platform/chromium-mac/css2.1/t0805-c5520-brdr-b-01-e-expected.png: Removed.
platform/chromium-mac/css2.1/t0805-c5521-brdr-l-00-a-expected.checksum: Removed.
platform/chromium-mac/css2.1/t0805-c5521-brdr-l-00-a-expected.png: Removed.
platform/chromium-mac/css2.1/t0805-c5521-brdr-l-01-e-expected.checksum: Removed.
platform/chromium-mac/css2.1/t0805-c5521-brdr-l-01-e-expected.png: Removed.
platform/chromium-mac/css2.1/t0805-c5521-ibrdr-l-00-a-expected.checksum: Removed.
platform/chromium-mac/css2.1/t0805-c5521-ibrdr-l-00-a-expected.png: Removed.
platform/chromium-mac/css2.1/t0905-c414-flt-02-c-expected.checksum: Removed.
platform/chromium-mac/css2.1/t0905-c414-flt-02-c-expected.png: Removed.
platform/chromium-mac/css2.1/t0905-c414-flt-03-c-expected.checksum: Removed.
platform/chromium-mac/css2.1/t0905-c414-flt-03-c-expected.png: Removed.
platform/chromium-mac/css2.1/t0905-c414-flt-04-c-expected.checksum: Removed.
platform/chromium-mac/css2.1/t0905-c414-flt-04-c-expected.png: Removed.
platform/chromium-mac/css2.1/t0905-c414-flt-fit-01-d-g-expected.checksum: Removed.
platform/chromium-mac/css2.1/t0905-c414-flt-fit-01-d-g-expected.png: Removed.
platform/chromium-mac/css2.1/t0905-c5525-fltblck-01-d-expected.checksum: Removed.
platform/chromium-mac/css2.1/t0905-c5525-fltblck-01-d-expected.png: Removed.
platform/chromium-mac/css2.1/t0905-c5525-fltcont-00-d-g-expected.checksum: Removed.
platform/chromium-mac/css2.1/t0905-c5525-fltcont-00-d-g-expected.png: Removed.
platform/chromium-mac/css2.1/t0905-c5525-fltwidth-03-c-g-expected.checksum: Removed.
platform/chromium-mac/css2.1/t0905-c5525-fltwidth-03-c-g-expected.png: Removed.
platform/chromium-mac/css2.1/t090501-c414-flt-01-b-expected.checksum: Removed.
platform/chromium-mac/css2.1/t090501-c414-flt-01-b-expected.png: Removed.
platform/chromium-mac/css2.1/t090501-c5525-flt-l-00-b-g-expected.checksum: Removed.
platform/chromium-mac/css2.1/t090501-c5525-flt-l-00-b-g-expected.png: Removed.
platform/chromium-mac/css2.1/t090501-c5525-flt-r-00-b-g-expected.checksum: Removed.
platform/chromium-mac/css2.1/t090501-c5525-flt-r-00-b-g-expected.png: Removed.
platform/chromium-mac/css2.1/t1202-counter-03-b-expected.checksum: Removed.
platform/chromium-mac/css2.1/t1202-counter-03-b-expected.png: Removed.
platform/chromium-mac/css2.1/t1202-counter-04-b-expected.checksum: Removed.
platform/chromium-mac/css2.1/t1202-counter-04-b-expected.png: Removed.
platform/chromium-mac/css2.1/t1202-counter-09-b-expected.checksum: Removed.
platform/chromium-mac/css2.1/t1202-counter-09-b-expected.png: Removed.
platform/chromium-mac/css2.1/t1202-counters-03-b-expected.checksum: Removed.
platform/chromium-mac/css2.1/t1202-counters-03-b-expected.png: Removed.
platform/chromium-mac/css2.1/t1202-counters-04-b-expected.checksum: Removed.
platform/chromium-mac/css2.1/t1202-counters-04-b-expected.png: Removed.
platform/chromium-mac/editing/deleting/5144139-2-expected.checksum: Removed.
platform/chromium-mac/editing/deleting/5144139-2-expected.png: Removed.
platform/chromium-mac/editing/selection/extend-selection-bidi-expected.checksum: Removed.
platform/chromium-mac/editing/selection/extend-selection-bidi-expected.png: Removed.
platform/chromium-mac/fast/css/beforeSelectorOnCodeElement-expected.checksum: Removed.
platform/chromium-mac/fast/css/beforeSelectorOnCodeElement-expected.png: Removed.
platform/chromium-mac/fast/css/font-face-opentype-expected.checksum: Removed.
platform/chromium-mac/fast/css/font-face-opentype-expected.png: Removed.
platform/chromium-mac/fast/css/rtl-ordering-expected.checksum: Removed.
platform/chromium-mac/fast/css/rtl-ordering-expected.png: Removed.
platform/chromium-mac/fast/css/text-overflow-ellipsis-bidi-expected.checksum: Removed.
platform/chromium-mac/fast/css/text-overflow-ellipsis-bidi-expected.png: Removed.
platform/chromium-mac/fast/css/text-security-expected.checksum: Removed.
platform/chromium-mac/fast/css/text-security-expected.png: Removed.
platform/chromium-mac/fast/encoding/denormalised-voiced-japanese-chars-expected.checksum: Removed.
platform/chromium-mac/fast/encoding/denormalised-voiced-japanese-chars-expected.png: Removed.
platform/chromium-mac/fast/encoding/invalid-UTF-8-expected.checksum: Removed.
platform/chromium-mac/fast/encoding/invalid-UTF-8-expected.png: Removed.
platform/chromium-mac/fast/forms/select-visual-hebrew-expected.checksum: Removed.
platform/chromium-mac/fast/forms/select-visual-hebrew-expected.png: Removed.
platform/chromium-mac/fast/forms/visual-hebrew-text-field-expected.checksum: Removed.
platform/chromium-mac/fast/forms/visual-hebrew-text-field-expected.png: Removed.
platform/chromium-mac/fast/text/bidi-embedding-pop-and-push-same-expected.checksum: Removed.
platform/chromium-mac/fast/text/bidi-embedding-pop-and-push-same-expected.png: Removed.
platform/chromium-mac/fast/text/cg-fallback-bolding-expected.checksum: Removed.
platform/chromium-mac/fast/text/cg-fallback-bolding-expected.png: Removed.
platform/chromium-mac/fast/text/complex-text-opacity-expected.checksum: Removed.
platform/chromium-mac/fast/text/complex-text-opacity-expected.png: Removed.
platform/chromium-mac/fast/text/complex-text-opacity-expected.txt: Removed.
platform/chromium-mac/fast/text/in-rendered-text-rtl-expected.checksum: Removed.
platform/chromium-mac/fast/text/in-rendered-text-rtl-expected.png: Removed.
platform/chromium-mac/fast/text/international/001-expected.checksum: Removed.
platform/chromium-mac/fast/text/international/001-expected.png: Removed.
platform/chromium-mac/fast/text/international/bidi-AN-after-L-expected.checksum: Removed.
platform/chromium-mac/fast/text/international/bidi-AN-after-L-expected.png: Removed.
platform/chromium-mac/fast/text/international/bidi-AN-after-empty-run-expected.checksum: Removed.
platform/chromium-mac/fast/text/international/bidi-AN-after-empty-run-expected.png: Removed.
platform/chromium-mac/fast/text/international/bidi-AN-after-empty-run-expected.txt: Removed.
platform/chromium-mac/fast/text/international/bidi-CS-after-AN-expected.checksum: Removed.
platform/chromium-mac/fast/text/international/bidi-CS-after-AN-expected.png: Removed.
platform/chromium-mac/fast/text/international/bidi-CS-after-AN-expected.txt: Removed.
platform/chromium-mac/fast/text/international/bidi-L2-run-reordering-expected.checksum: Removed.
platform/chromium-mac/fast/text/international/bidi-L2-run-reordering-expected.png: Removed.
platform/chromium-mac/fast/text/international/bidi-LDB-2-CSS-expected.checksum: Removed.
platform/chromium-mac/fast/text/international/bidi-LDB-2-CSS-expected.png: Removed.
platform/chromium-mac/fast/text/international/bidi-LDB-2-HTML-expected.checksum: Removed.
platform/chromium-mac/fast/text/international/bidi-LDB-2-HTML-expected.png: Removed.
platform/chromium-mac/fast/text/international/bidi-LDB-2-formatting-characters-expected.checksum: Removed.
platform/chromium-mac/fast/text/international/bidi-LDB-2-formatting-characters-expected.png: Removed.
platform/chromium-mac/fast/text/international/bidi-european-terminators-expected.checksum: Removed.
platform/chromium-mac/fast/text/international/bidi-european-terminators-expected.png: Removed.
platform/chromium-mac/fast/text/international/bidi-ignored-for-first-child-inline-expected.checksum: Removed.
platform/chromium-mac/fast/text/international/bidi-ignored-for-first-child-inline-expected.png: Removed.
platform/chromium-mac/fast/text/international/bidi-innertext-expected.checksum: Removed.
platform/chromium-mac/fast/text/international/bidi-innertext-expected.png: Removed.
platform/chromium-mac/fast/text/international/bidi-linebreak-001-expected.checksum: Removed.
platform/chromium-mac/fast/text/international/bidi-linebreak-001-expected.png: Removed.
platform/chromium-mac/fast/text/international/bidi-linebreak-002-expected.checksum: Removed.
platform/chromium-mac/fast/text/international/bidi-linebreak-002-expected.png: Removed.
platform/chromium-mac/fast/text/international/bidi-linebreak-003-expected.checksum: Removed.
platform/chromium-mac/fast/text/international/bidi-linebreak-003-expected.png: Removed.
platform/chromium-mac/fast/text/international/bidi-listbox-atsui-expected.checksum: Removed.
platform/chromium-mac/fast/text/international/bidi-listbox-atsui-expected.png: Removed.
platform/chromium-mac/fast/text/international/bidi-listbox-expected.checksum: Removed.
platform/chromium-mac/fast/text/international/bidi-listbox-expected.png: Removed.
platform/chromium-mac/fast/text/international/bidi-mirror-he-ar-expected.checksum: Removed.
platform/chromium-mac/fast/text/international/bidi-mirror-he-ar-expected.png: Removed.
platform/chromium-mac/fast/text/international/bidi-mirror-he-ar-expected.txt: Removed.
platform/chromium-mac/fast/text/international/bidi-neutral-directionality-paragraph-start-expected.checksum: Removed.
platform/chromium-mac/fast/text/international/bidi-neutral-directionality-paragraph-start-expected.png: Removed.
platform/chromium-mac/fast/text/international/bidi-neutral-directionality-paragraph-start-expected.txt: Removed.
platform/chromium-mac/fast/text/international/bidi-neutral-run-expected.checksum: Removed.
platform/chromium-mac/fast/text/international/bidi-neutral-run-expected.png: Removed.
platform/chromium-mac/fast/text/international/bidi-neutral-run-expected.txt: Removed.
platform/chromium-mac/fast/text/international/bidi-override-expected.checksum: Removed.
platform/chromium-mac/fast/text/international/bidi-override-expected.png: Removed.
platform/chromium-mac/fast/text/international/danda-space-expected.checksum: Removed.
platform/chromium-mac/fast/text/international/danda-space-expected.png: Removed.
platform/chromium-mac/fast/text/international/hebrew-vowels-expected.checksum: Removed.
platform/chromium-mac/fast/text/international/hebrew-vowels-expected.png: Removed.
platform/chromium-mac/fast/text/international/hindi-spacing-expected.checksum: Removed.
platform/chromium-mac/fast/text/international/hindi-spacing-expected.png: Removed.
platform/chromium-mac/fast/text/international/hindi-whitespace-expected.checksum: Removed.
platform/chromium-mac/fast/text/international/hindi-whitespace-expected.png: Removed.
platform/chromium-mac/fast/text/international/plane2-expected.checksum: Removed.
platform/chromium-mac/fast/text/international/plane2-expected.png: Removed.
platform/chromium-mac/fast/text/international/rtl-caret-expected.checksum: Removed.
platform/chromium-mac/fast/text/international/rtl-caret-expected.png: Removed.
platform/chromium-mac/fast/text/international/thai-baht-space-expected.checksum: Removed.
platform/chromium-mac/fast/text/international/thai-baht-space-expected.png: Removed.
platform/chromium-mac/fast/text/international/thai-baht-space-expected.txt: Removed.
platform/chromium-mac/fast/text/international/wrap-CJK-001-expected.checksum: Removed.
platform/chromium-mac/fast/text/international/wrap-CJK-001-expected.png: Removed.
platform/chromium/test_expectations.txt:

10:35 AM Changeset in webkit [74041] by ap@apple.com

14 edits in trunk

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=50953
DNS Prefetch should be an opt-in feature

10:30 AM Changeset in webkit [74040] by commit-queue@webkit.org

10 edits
2 copies
1 add in trunk

2010-12-14 Helder Correia <helder@sencha.com>

Reviewed by Ariya Hidayat.

[Qt] Canvas shadow offset should not be affected by any transformation
https://bugs.webkit.org/show_bug.cgi?id=50422

On a canvas context, shadows are currently affected by all
transformations except scaling. According to the spec:
http://www.whatwg.org/specs/web-apps/current-work/multipage/the-canvas-element.html#shadows

"The shadowOffsetX and shadowOffsetY attributes specify the distance
that the shadow will be offset in the positive horizontal and positive
vertical distance respectively. Their values are in coordinate space
units. They are not affected by the current transformation matrix."

NOTE: this applies only to canvas, not to box shadows.

Add new test to ensure that shadows are correctly transformed keeping
the relative offset to the shape.

fast/canvas/canvas-scale-strokePath-shadow-expected.txt:
fast/canvas/canvas-transforms-fillRect-shadow-expected.txt: Added.
fast/canvas/canvas-transforms-fillRect-shadow.html: Added.
fast/canvas/script-tests/canvas-scale-fillPath-shadow.js:
fast/canvas/script-tests/canvas-scale-fillRect-shadow.js:
fast/canvas/script-tests/canvas-scale-strokePath-shadow.js: Now using a lineWidth > 1 to make it easier to test and more fair among all ports, since there can be different transformation smoothness or aliasing settings.
fast/canvas/script-tests/canvas-transforms-fillRect-shadow.js: Added.

2010-12-14 Helder Correia <helder@sencha.com>

Reviewed by Ariya Hidayat.

[Qt] Canvas shadow offset should not be affected by any transformation
https://bugs.webkit.org/show_bug.cgi?id=50422

On a canvas context, shadows are currently affected by all
transformations except scaling. According to the spec:
http://www.whatwg.org/specs/web-apps/current-work/multipage/the-canvas-element.html#shadows

"The shadowOffsetX and shadowOffsetY attributes specify the distance
that the shadow will be offset in the positive horizontal and positive
vertical distance respectively. Their values are in coordinate space
units. They are not affected by the current transformation matrix."

NOTE: this applies only to canvas, not to box shadows.

Test: fast/canvas/canvas-transforms-fillRect-shadow.html

platform/graphics/ContextShadow.cpp: (WebCore::ContextShadow::ContextShadow): (WebCore::ContextShadow::calculateLayerBoundingRect):
platform/graphics/ContextShadow.h: (WebCore::ContextShadow::setShadowsIgnoreTransforms): (WebCore::ContextShadow::shadowsIgnoreTransforms): (WebCore::ContextShadow::offset):
platform/graphics/qt/ContextShadowQt.cpp: (WebCore::ContextShadow::beginShadowLayer): (WebCore::ContextShadow::endShadowLayer):
platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::mustUseContextShadow): (WebCore::GraphicsContext::fillPath): (WebCore::GraphicsContext::strokePath): (WebCore::GraphicsContext::fillRect): (WebCore::GraphicsContext::fillRoundedRect): (WebCore::GraphicsContext::setPlatformShadow):

10:07 AM Changeset in webkit [74039] by pfeldman@chromium.org

2 edits
31 deletes in trunk/LayoutTests

2010-12-14 Pavel Feldman <pfeldman@chromium.org>

Not reviewed. Removed obsolete chromium expectations.

platform/chromium/accessibility/post-notification-ActiveDescendantChanged-expected.txt: Removed.
platform/chromium/accessibility/post-notification-ActiveDescendantChanged.html: Removed.
platform/chromium/accessibility/post-notification-CheckedStateChanged-expected.txt: Removed.
platform/chromium/accessibility/post-notification-CheckedStateChanged.html: Removed.
platform/chromium/accessibility/post-notification-ChildrenChanged-expected.txt: Removed.
platform/chromium/accessibility/post-notification-ChildrenChanged.html: Removed.
platform/chromium/accessibility/post-notification-FocusedUIElementChanged-expected.txt: Removed.
platform/chromium/accessibility/post-notification-FocusedUIElementChanged.html: Removed.
platform/chromium/accessibility/post-notification-LayoutComplete-expected.txt: Removed.
platform/chromium/accessibility/post-notification-LayoutComplete.html: Removed.
platform/chromium/accessibility/post-notification-LiveRegionChanged-expected.txt: Removed.
platform/chromium/accessibility/post-notification-LiveRegionChanged.html: Removed.
platform/chromium/accessibility/post-notification-LoadComplete-expected.txt: Removed.
platform/chromium/accessibility/post-notification-LoadComplete.html: Removed.
platform/chromium/accessibility/post-notification-MenuListValueChanged-expected.txt: Removed.
platform/chromium/accessibility/post-notification-MenuListValueChanged.html: Removed.
platform/chromium/accessibility/post-notification-RowCollapsed-expected.txt: Removed.
platform/chromium/accessibility/post-notification-RowCollapsed.html: Removed.
platform/chromium/accessibility/post-notification-RowCountChanged-expected.txt: Removed.
platform/chromium/accessibility/post-notification-RowCountChanged.html: Removed.
platform/chromium/accessibility/post-notification-RowExpanded-expected.txt: Removed.
platform/chromium/accessibility/post-notification-RowExpanded.html: Removed.
platform/chromium/accessibility/post-notification-ScrolledToAnchor-expected.txt: Removed.
platform/chromium/accessibility/post-notification-ScrolledToAnchor.html: Removed.
platform/chromium/accessibility/post-notification-SelectedChildrenChanged-expected.txt: Removed.
platform/chromium/accessibility/post-notification-SelectedChildrenChanged.html: Removed.
platform/chromium/accessibility/post-notification-SelectedTextChanged-expected.txt: Removed.
platform/chromium/accessibility/post-notification-SelectedTextChanged.html: Removed.
platform/chromium/accessibility/post-notification-ValueChanged-expected.txt: Removed.
platform/chromium/accessibility/post-notification-ValueChanged.html: Removed.
platform/chromium/accessibility/post-notification.js: Removed.
platform/chromium/test_expectations.txt:

10:06 AM Changeset in webkit [74038] by apavlov@chromium.org

3 edits in trunk/WebCore

2010-12-14 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: Rule data not updated in Styles pane after stylesheet gets reverted
https://bugs.webkit.org/show_bug.cgi?id=51034

inspector/front-end/CSSStyleModel.js: (WebInspector.CSSStyleModel.prototype._onRevert):
inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel): (WebInspector.ElementsPanel.prototype._metricsPaneEdited): (WebInspector.ElementsPanel.prototype._stylesPaneEdited): (WebInspector.ElementsPanel.prototype._styleSheetChanged):

9:54 AM Changeset in webkit [74037] by andersca@apple.com

7 edits in trunk/WebKit2

Pass the complex text input status to the WKView
https://bugs.webkit.org/show_bug.cgi?id=50993

Reviewed by Kevin Decker.

UIProcess/API/mac/PageClientImpl.h:
UIProcess/API/mac/PageClientImpl.mm:

(WebKit::PageClientImpl::setComplexTextInputEnabled):

UIProcess/API/mac/WKView.mm:

(-[WKView _setComplexTextInputEnabled:pluginComplexTextInputIdentifier:]):

UIProcess/API/mac/WKViewInternal.h:
UIProcess/PageClient.h:
UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::setComplexTextInputEnabled):

9:54 AM Changeset in webkit [74036] by Philippe Normand

4 edits in trunk/WebKitTools

2010-12-14 Philippe Normand <pnormand@igalia.com>

Reviewed by Ojan Vafai.

[new-run-webkit-tests] expectations parsing is slow
https://bugs.webkit.org/show_bug.cgi?id=50635

Avoid expensive iteration of all the tests when checking if a test
file is to be skipped or not.

Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
Scripts/webkitpy/layout_tests/port/test.py:

9:49 AM Changeset in webkit [74035] by andreas.kling@nokia.com

2 edits in trunk/WebCore

2010-12-14 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Avoid GraphicsContext save/restore in Image::drawPattern()
https://bugs.webkit.org/show_bug.cgi?id=51037

It's enough to restore the CompositeOperator after drawing.

platform/graphics/qt/ImageQt.cpp: (WebCore::Image::drawPattern):

9:27 AM Changeset in webkit [74034] by eric.carlson@apple.com

2 edits in trunk/WebCore

2010-12-14 Eric Carlson <eric.carlson@apple.com>

Reviewed by Dan Bernstein.

<rdar://problem/8763862>
r72017 used incorrect compiler conditional.

platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivateQTKit::createQTMovie):

9:21 AM Changeset in webkit [74033] by pfeldman@chromium.org

10 edits
12 adds in trunk/LayoutTests

2010-12-14 Pavel Feldman <pfeldman@chromium.org>

Not reviewed. More chromium rebaselines.

platform/chromium-mac/fast/text/complex-text-opacity-expected.checksum: Added.
platform/chromium-mac/fast/text/complex-text-opacity-expected.png: Added.
platform/chromium-mac/fast/text/complex-text-opacity-expected.txt: Added.
platform/chromium-mac/fast/text/international/bidi-AN-after-empty-run-expected.checksum: Added.
platform/chromium-mac/fast/text/international/bidi-AN-after-empty-run-expected.png: Added.
platform/chromium-mac/fast/text/international/bidi-AN-after-empty-run-expected.txt: Added.
platform/chromium-mac/fast/text/international/bidi-CS-after-AN-expected.checksum: Added.
platform/chromium-mac/fast/text/international/bidi-CS-after-AN-expected.png: Added.
platform/chromium-mac/fast/text/international/bidi-CS-after-AN-expected.txt: Added.
platform/chromium-mac/fast/text/international/bidi-mirror-he-ar-expected.checksum:
platform/chromium-mac/fast/text/international/bidi-mirror-he-ar-expected.png:
platform/chromium-mac/fast/text/international/bidi-mirror-he-ar-expected.txt:
platform/chromium-mac/fast/text/international/bidi-neutral-directionality-paragraph-start-expected.checksum:
platform/chromium-mac/fast/text/international/bidi-neutral-directionality-paragraph-start-expected.png:
platform/chromium-mac/fast/text/international/bidi-neutral-directionality-paragraph-start-expected.txt:
platform/chromium-mac/fast/text/international/bidi-neutral-run-expected.checksum:
platform/chromium-mac/fast/text/international/bidi-neutral-run-expected.png:
platform/chromium-mac/fast/text/international/bidi-neutral-run-expected.txt:
platform/chromium-mac/fast/text/international/thai-baht-space-expected.checksum: Added.
platform/chromium-mac/fast/text/international/thai-baht-space-expected.png: Added.
platform/chromium-mac/fast/text/international/thai-baht-space-expected.txt: Added.

9:05 AM Changeset in webkit [74032] by mario@webkit.org

2 edits in trunk/LayoutTests

2010-12-14 Mario Sanchez Prada <msanchez@igalia.com>

Unreviewed, skipping flaky test on GTK debug bot.

[gtk] editing/selection/extend-by-character-002.html is flaky on

GTK Linux 64 bit debug

https://bugs.webkit.org/show_bug.cgi?id=51017

platform/gtk/Skipped: Skipped test.

9:05 AM Changeset in webkit [74031] by mario@webkit.org

2 edits in trunk/LayoutTests

2010-12-14 Mario Sanchez Prada <msanchez@igalia.com>

Unreviewed, skipping test crashing in the GTK release bot.

[GTK] Crash in LayoutTest/fast/history/history_reload.html
https://bugs.webkit.org/show_bug.cgi?id=51038

platform/gtk/Skipped: Skipped fast/history/history_reload.html.

8:59 AM Changeset in webkit [74030] by cwzwarich@webkit.org

2 edits in trunk/JavaScriptCore

Not reviewed.

Revert accidental change disabling the JIT for most platforms.

wtf/Platform.h:

8:57 AM Changeset in webkit [74029] by cwzwarich@webkit.org

3 edits in trunk/JavaScriptCore

Reviewed by Eric Seidel.

Clang fails to build the JSC interpreter
https://bugs.webkit.org/show_bug.cgi?id=51016

Clang does not allow indirect gotos out of scopes with cleanup. GCC 4.2 allows
them, but it does not correctly generate the cleanup, causing a leak if the
cleanup decrements a reference count.

interpreter/Interpreter.cpp:

(JSC::Interpreter::privateExecute): Put an Identifier into its own scope.

8:25 AM Changeset in webkit [74028] by commit-queue@webkit.org

8 edits in trunk

2010-12-14 Carlos Garcia Campos <cgarcia@igalia.com>

Reviewed by Martin Robinson.

[GTK] Simplify context-menu handling code
https://bugs.webkit.org/show_bug.cgi?id=49658

wtf/PlatformRefPtr.h: Add leakRef()

2010-12-14 Carlos Garcia Campos <cgarcia@igalia.com>

Reviewed by Martin Robinson.

[GTK] Simplify context-menu handling code
https://bugs.webkit.org/show_bug.cgi?id=49658

platform/ContextMenuItem.h:
platform/gtk/ContextMenuGtk.cpp: (WebCore::ContextMenu::appendItem):
platform/gtk/ContextMenuItemGtk.cpp: (WebCore::ContextMenuItem::ContextMenuItem): (WebCore::ContextMenuItem::~ContextMenuItem): (WebCore::ContextMenuItem::releasePlatformDescription): (WebCore::ContextMenuItem::type): (WebCore::ContextMenuItem::setType): (WebCore::ContextMenuItem::action): (WebCore::ContextMenuItem::setAction): (WebCore::ContextMenuItem::title): (WebCore::ContextMenuItem::setTitle): (WebCore::ContextMenuItem::platformSubMenu): (WebCore::ContextMenuItem::setSubMenu): (WebCore::ContextMenuItem::setChecked): (WebCore::ContextMenuItem::setEnabled):

2010-12-14 Carlos Garcia Campos <cgarcia@igalia.com>

Reviewed by Martin Robinson.

[GTK] Simplify context-menu handling code
https://bugs.webkit.org/show_bug.cgi?id=49658

Use gtk_container_foreach() so that we only iterate the list of
children once and we avoid creating/destroying the list. It also
connects the activate signal for submenu items.

webkit/webkitwebview.cpp: (contextMenuConnectActivate): (webkit_web_view_forward_context_menu_event):

7:55 AM Changeset in webkit [74027] by pfeldman@chromium.org

2 edits in trunk/LayoutTests

2010-12-14 Pavel Feldman <pfeldman@chromium.org>

Not reviewed. Updated chromium expectations.

platform/chromium/test_expectations.txt:

7:55 AM Changeset in webkit [74026] by commit-queue@webkit.org

4 edits in trunk/WebKit/gtk

2010-12-14 Carlos Garcia Campos <cgarcia@igalia.com>

Reviewed by Xan Lopez.

[GTK] Fix several issues in r73858
https://bugs.webkit.org/show_bug.cgi?id=51032

It uses both glib private data and it allocates its own private structure.
It calls parent's dispose method from finalize.
webkit_web_plugin_get_mimetypes() uses a wrong annotation for the returned value, it should be transfer none rather than transfer container.
Since the mime type list is internal and we return the list and not a copy, it should never be freed by the caller, so webkit_web_plugin_mime_type_list_free() should be removed from the public API.
Mime types list is used uninitialized.
Mention in the docs that list returned by webkit_web_plugin_database_get_plugins() must be freed with webkit_web_plugin_database_plugins_list_free().

webkit/webkitwebplugin.cpp: (webkit_web_plugin_finalize): (webkit_web_plugin_class_init): (webkit_web_plugin_init):
webkit/webkitwebplugin.h:
webkit/webkitwebplugindatabase.cpp:

7:35 AM Changeset in webkit [74025] by mario@webkit.org

10 edits
2 adds in trunk

2010-12-14 Mario Sanchez Prada <msanchez@igalia.com>

Reviewed by Xan Lopez.

[Gtk] Implement STATE_FOCUSED, STATE_FOCUSABLE, and corresponding events for text objects
https://bugs.webkit.org/show_bug.cgi?id=27048

Added a new GTK-specific test to check focus{able|ed} states are
properly set when moving the caret across text objects.

platform/gtk/accessibility/caret-browsing-text-focus-expected.txt: Added.
platform/gtk/accessibility/caret-browsing-text-focus.html: Added.

2010-12-14 Mario Sanchez Prada <msanchez@igalia.com>

Reviewed by Xan Lopez.

[Gtk] Implement STATE_FOCUSED, STATE_FOCUSABLE, and corresponding events for text objects
https://bugs.webkit.org/show_bug.cgi?id=27048

Handle focus change for text objects based in caret changes.

As text objects (such as paragraphs) seem not to accept focus in
WebCore in the same way other objects (text controls) do, a
Gtk-specific workaround is needed to expose this states and the
related events to ATK-based assistive technologies.

Test: platform/gtk/accessibility/caret-browsing-text-focus.html

Ensure that text objects are exposed with the ATK_STATE_FOCUSABLE
state, and that the ATK_STATE_FOCUSED state is added to those
text objects containing the currently active caret selection.

accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (selectionBelongsToObject): Moved upwards to use it from the new isTextWithCaret() function. (isTextWithCaret): New, checks whether an accessibility object represents a text object with the current caret selection on it. (setAtkStateSetFromCoreObject): Add the ATK_STATE_FOCUSED state when also when isTextWithCaret(coreObject) returns true. (webkit_accessible_ref_state_set): Add the ATK_STATE_FOCUSABLE state to text objects and those with the ATK_ROLE_PARAGRAPH role. (webkit_accessible_text_get_n_selections): Optimize return expression.

Make sure the proper events associated to a change of focus are
emitted, based on caret changes across different accessibility
objects. Also, refactored the code in more manageable and
understandable helper functions.

editing/gtk/SelectionControllerGtk.cpp: (WebCore::emitTextSelectionChange): New, includes the specific code formerly placed in notifyAccessibilityForSelectionChange() to emit the 'text-caret-moved' and 'text-selection-change' signals. (WebCore::maybeEmitTextFocusChange): New, takes care of emitting the 'focus-event' and 'state-changed::focused' signals when needed, that is, when a change in the selection happens across different accessible objects. (WebCore::SelectionController::notifyAccessibilityForSelectionChange): Refactored some code here, by using the new helper functions.

2010-12-14 Mario Sanchez Prada <msanchez@igalia.com>

Reviewed by Xan Lopez.

[Gtk] Implement STATE_FOCUSED, STATE_FOCUSABLE, and corresponding events for text objects
https://bugs.webkit.org/show_bug.cgi?id=27048

Add support in DRT for checking whether an accessibility UI
element is focusable and/or focused. Implemented for GTK.

DumpRenderTree/AccessibilityUIElement.cpp: (getIsFocusedCallback): New. (getIsFocusableCallback): New. (AccessibilityUIElement::getJSClass): Add the new available callbacks for isFocused and isFocusable.
DumpRenderTree/AccessibilityUIElement.h:
DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: (AccessibilityUIElement::isFocused): New, implemented by checking whether the related AtkState value is in the object's state set. (AccessibilityUIElement::isFocusable): Ditto.
DumpRenderTree/mac/AccessibilityUIElementMac.mm: (AccessibilityUIElement::isFocused): New, dummy implementation. (AccessibilityUIElement::isFocusable): Ditto.
DumpRenderTree/win/AccessibilityUIElementWin.cpp: (AccessibilityUIElement::isFocused): Ditto. (AccessibilityUIElement::isFocusable): Ditto.

7:02 AM Changeset in webkit [74024] by yurys@chromium.org

3 edits in branches/chromium/597

Merge 74020 - 2010-12-14 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: Reverted stylesheet breaks style data
https://bugs.webkit.org/show_bug.cgi?id=51030

WebCore:

inspector/InspectorStyleSheet.cpp: (WebCore::InspectorStyleSheet::reparseStyleSheet):

LayoutTests:

inspector/styles-new-API-expected.txt:
inspector/styles-new-API.html:

BUG=66825
TBR=apavlov@chromium.org
Review URL: http://codereview.chromium.org/5701007

6:55 AM Changeset in webkit [74023] by yurys@chromium.org

2 edits in branches/chromium/597/WebCore/inspector/front-end

Merge 73311 - 2010-12-03 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: Duplicate "!important" for !important properties displayed in the Styles pane
https://bugs.webkit.org/show_bug.cgi?id=50460

inspector/front-end/StylesSidebarPane.js:
inspector/front-end/inspector.css:

TBR=apavlov@chromium.org
Review URL: http://codereview.chromium.org/5816003

6:54 AM Changeset in webkit [74022] by loislo@chromium.org

2 edits in trunk/WebCore

2010-12-14 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: regroup Inspector.idl entries.
Just for better visibility.

https://bugs.webkit.org/show_bug.cgi?id=51025

inspector/Inspector.idl:

6:52 AM Changeset in webkit [74021] by pfeldman@chromium.org

2 edits in trunk/LayoutTests

2010-12-14 Pavel Feldman <pfeldman@chromium.org>

Not reviwed. Chromium expectations updated.

platform/chromium/test_expectations.txt:

6:46 AM Changeset in webkit [74020] by apavlov@chromium.org

5 edits in trunk

2010-12-14 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: Reverted stylesheet breaks style data
https://bugs.webkit.org/show_bug.cgi?id=51030

WebCore:

inspector/InspectorStyleSheet.cpp: (WebCore::InspectorStyleSheet::reparseStyleSheet):

LayoutTests:

inspector/styles-new-API-expected.txt:
inspector/styles-new-API.html:

5:39 AM Changeset in webkit [74019] by ager@chromium.org

4 edits in trunk

2010-12-14 Mads Ager <ager@chromium.org>

Reviewed by Pavel Feldman.

[V8] Reflected unsigned attributes should be in the range [0, 2^{31)

https://bugs.webkit.org/show_bug.cgi?id=51023}

Remove test that now passes from chromium test expectations.

platform/chromium/test_expectations.txt:

2010-12-14 Mads Ager <ager@chromium.org>

Reviewed by Pavel Feldman.

[V8] Reflected unsigned attributes should be in the range [0, 2^{31)

https://bugs.webkit.org/show_bug.cgi?id=51023}

Follow the changes made to CodeGeneratorJS.pm to return 0 for
reflected unsigned attributes that are outside the allowed range.
See https://bugs.webkit.org/show_bug.cgi?id=50472

bindings/scripts/CodeGeneratorV8.pm:

5:22 AM Changeset in webkit [74018] by commit-queue@webkit.org

2 edits in trunk/WebKit/gtk

2010-12-14 Diego Escalante Urrelo <descalante@igalia.com>

Reviewed by Xan Lopez.

[gtk] misnamed gtk-doc strings for webkit_web_view_can_{c|c|p}_clipboard
https://bugs.webkit.org/show_bug.cgi?id=50571

webkit/webkitwebview.cpp:

5:17 AM Changeset in webkit [74017] by mario@webkit.org

2 edits in trunk/LayoutTests

2010-12-14 Mario Sanchez Prada <msanchez@igalia.com>

Unreviewed, skipping failing test in the release bots.

Incorrect refcount on plug.testObject in LayoutTests/plugins/refcount-leaks.html
https://bugs.webkit.org/show_bug.cgi?id=51027

platform/gtk/Skipped: Skip plugins/refcount-leaks.html.

4:36 AM Changeset in webkit [74016] by pfeldman@chromium.org

24 edits
122 adds in trunk/LayoutTests

2010-12-14 Pavel Feldman <pfeldman@chromium.org>

Not reviewed. Chromium tests rebaselined.

platform/chromium-mac/css2.1/t0805-c5518-brdr-t-01-e-expected.checksum: Added.
platform/chromium-mac/css2.1/t0805-c5518-brdr-t-01-e-expected.png: Added.
platform/chromium-mac/css2.1/t0805-c5519-brdr-r-00-a-expected.checksum: Added.
platform/chromium-mac/css2.1/t0805-c5519-brdr-r-00-a-expected.png: Added.
platform/chromium-mac/css2.1/t0805-c5520-brdr-b-01-e-expected.checksum: Added.
platform/chromium-mac/css2.1/t0805-c5520-brdr-b-01-e-expected.png: Added.
platform/chromium-mac/css2.1/t0805-c5521-brdr-l-00-a-expected.checksum: Added.
platform/chromium-mac/css2.1/t0805-c5521-brdr-l-00-a-expected.png: Added.
platform/chromium-mac/css2.1/t0805-c5521-brdr-l-01-e-expected.checksum: Added.
platform/chromium-mac/css2.1/t0805-c5521-brdr-l-01-e-expected.png: Added.
platform/chromium-mac/css2.1/t0805-c5521-ibrdr-l-00-a-expected.checksum: Added.
platform/chromium-mac/css2.1/t0805-c5521-ibrdr-l-00-a-expected.png: Added.
platform/chromium-mac/css2.1/t0905-c414-flt-02-c-expected.checksum: Added.
platform/chromium-mac/css2.1/t0905-c414-flt-02-c-expected.png: Added.
platform/chromium-mac/css2.1/t0905-c414-flt-03-c-expected.checksum: Added.
platform/chromium-mac/css2.1/t0905-c414-flt-03-c-expected.png: Added.
platform/chromium-mac/css2.1/t0905-c414-flt-04-c-expected.checksum: Added.
platform/chromium-mac/css2.1/t0905-c414-flt-04-c-expected.png: Added.
platform/chromium-mac/css2.1/t0905-c414-flt-fit-01-d-g-expected.checksum: Added.
platform/chromium-mac/css2.1/t0905-c414-flt-fit-01-d-g-expected.png: Added.
platform/chromium-mac/css2.1/t0905-c5525-fltblck-01-d-expected.checksum: Added.
platform/chromium-mac/css2.1/t0905-c5525-fltblck-01-d-expected.png: Added.
platform/chromium-mac/css2.1/t0905-c5525-fltcont-00-d-g-expected.checksum: Added.
platform/chromium-mac/css2.1/t0905-c5525-fltcont-00-d-g-expected.png: Added.
platform/chromium-mac/css2.1/t0905-c5525-flthw-00-c-g-expected.checksum: Added.
platform/chromium-mac/css2.1/t0905-c5525-flthw-00-c-g-expected.png: Added.
platform/chromium-mac/css2.1/t0905-c5525-fltwidth-00-c-g-expected.checksum:
platform/chromium-mac/css2.1/t0905-c5525-fltwidth-00-c-g-expected.png:
platform/chromium-mac/css2.1/t0905-c5525-fltwidth-03-c-g-expected.checksum: Added.
platform/chromium-mac/css2.1/t0905-c5525-fltwidth-03-c-g-expected.png: Added.
platform/chromium-mac/css2.1/t0905-c5526-flthw-00-c-g-expected.checksum: Added.
platform/chromium-mac/css2.1/t0905-c5526-flthw-00-c-g-expected.png: Added.
platform/chromium-mac/css2.1/t090501-c414-flt-01-b-expected.checksum: Added.
platform/chromium-mac/css2.1/t090501-c414-flt-01-b-expected.png: Added.
platform/chromium-mac/css2.1/t090501-c414-flt-03-b-g-expected.checksum:
platform/chromium-mac/css2.1/t090501-c414-flt-03-b-g-expected.png:
platform/chromium-mac/css2.1/t090501-c5525-flt-l-00-b-g-expected.checksum: Added.
platform/chromium-mac/css2.1/t090501-c5525-flt-l-00-b-g-expected.png: Added.
platform/chromium-mac/css2.1/t090501-c5525-flt-r-00-b-g-expected.checksum: Added.
platform/chromium-mac/css2.1/t090501-c5525-flt-r-00-b-g-expected.png: Added.
platform/chromium-mac/css2.1/t100304-c43-rpl-bbx-01-d-g-expected.checksum:
platform/chromium-mac/css2.1/t100304-c43-rpl-bbx-01-d-g-expected.png:
platform/chromium-mac/css2.1/t1202-counter-03-b-expected.checksum: Added.
platform/chromium-mac/css2.1/t1202-counter-03-b-expected.png: Added.
platform/chromium-mac/css2.1/t1202-counter-04-b-expected.checksum: Added.
platform/chromium-mac/css2.1/t1202-counter-04-b-expected.png: Added.
platform/chromium-mac/css2.1/t1202-counter-09-b-expected.checksum: Added.
platform/chromium-mac/css2.1/t1202-counter-09-b-expected.png: Added.
platform/chromium-mac/css2.1/t1202-counters-03-b-expected.checksum: Added.
platform/chromium-mac/css2.1/t1202-counters-03-b-expected.png: Added.
platform/chromium-mac/css2.1/t1202-counters-04-b-expected.checksum: Added.
platform/chromium-mac/css2.1/t1202-counters-04-b-expected.png: Added.
platform/chromium-mac/css2.1/t1202-counters-09-b-expected.checksum:
platform/chromium-mac/css2.1/t1202-counters-09-b-expected.png:
platform/chromium-mac/editing/deleting/5144139-2-expected.checksum: Added.
platform/chromium-mac/editing/deleting/5144139-2-expected.png: Added.
platform/chromium-mac/editing/selection/caret-rtl-2-expected.checksum:
platform/chromium-mac/editing/selection/caret-rtl-2-expected.png:
platform/chromium-mac/editing/selection/caret-rtl-2-left-expected.checksum:
platform/chromium-mac/editing/selection/caret-rtl-2-left-expected.png:
platform/chromium-mac/editing/selection/caret-rtl-expected.checksum:
platform/chromium-mac/editing/selection/caret-rtl-expected.png:
platform/chromium-mac/editing/selection/caret-rtl-right-expected.checksum:
platform/chromium-mac/editing/selection/caret-rtl-right-expected.png:
platform/chromium-mac/editing/selection/extend-selection-bidi-expected.checksum: Added.
platform/chromium-mac/editing/selection/extend-selection-bidi-expected.png: Added.
platform/chromium-mac/fast/css/beforeSelectorOnCodeElement-expected.checksum: Added.
platform/chromium-mac/fast/css/beforeSelectorOnCodeElement-expected.png: Added.
platform/chromium-mac/fast/css/font-face-opentype-expected.checksum: Added.
platform/chromium-mac/fast/css/font-face-opentype-expected.png: Added.
platform/chromium-mac/fast/css/rtl-ordering-expected.checksum: Added.
platform/chromium-mac/fast/css/rtl-ordering-expected.png: Added.
platform/chromium-mac/fast/css/text-overflow-ellipsis-bidi-expected.checksum: Added.
platform/chromium-mac/fast/css/text-overflow-ellipsis-bidi-expected.png: Added.
platform/chromium-mac/fast/css/text-overflow-ellipsis-strict-expected.checksum:
platform/chromium-mac/fast/css/text-overflow-ellipsis-strict-expected.png:
platform/chromium-mac/fast/css/text-security-expected.checksum: Added.
platform/chromium-mac/fast/css/text-security-expected.png: Added.
platform/chromium-mac/fast/encoding/denormalised-voiced-japanese-chars-expected.checksum: Added.
platform/chromium-mac/fast/encoding/denormalised-voiced-japanese-chars-expected.png: Added.
platform/chromium-mac/fast/encoding/invalid-UTF-8-expected.checksum: Added.
platform/chromium-mac/fast/encoding/invalid-UTF-8-expected.png: Added.
platform/chromium-mac/fast/forms/select-visual-hebrew-expected.checksum: Added.
platform/chromium-mac/fast/forms/select-visual-hebrew-expected.png: Added.
platform/chromium-mac/fast/forms/visual-hebrew-text-field-expected.checksum: Added.
platform/chromium-mac/fast/forms/visual-hebrew-text-field-expected.png: Added.
platform/chromium-mac/fast/text/backslash-to-yen-sign-euc-expected.checksum:
platform/chromium-mac/fast/text/backslash-to-yen-sign-euc-expected.png:
platform/chromium-mac/fast/text/backslash-to-yen-sign-expected.checksum:
platform/chromium-mac/fast/text/backslash-to-yen-sign-expected.png:
platform/chromium-mac/fast/text/bidi-embedding-pop-and-push-same-expected.checksum: Added.
platform/chromium-mac/fast/text/bidi-embedding-pop-and-push-same-expected.png: Added.
platform/chromium-mac/fast/text/cg-fallback-bolding-expected.checksum: Added.
platform/chromium-mac/fast/text/cg-fallback-bolding-expected.png: Added.
platform/chromium-mac/fast/text/in-rendered-text-rtl-expected.checksum: Added.
platform/chromium-mac/fast/text/in-rendered-text-rtl-expected.png: Added.
platform/chromium-mac/fast/text/international/001-expected.checksum: Added.
platform/chromium-mac/fast/text/international/001-expected.png: Added.
platform/chromium-mac/fast/text/international/bidi-AN-after-L-expected.checksum: Added.
platform/chromium-mac/fast/text/international/bidi-AN-after-L-expected.png: Added.
platform/chromium-mac/fast/text/international/bidi-L2-run-reordering-expected.checksum: Added.
platform/chromium-mac/fast/text/international/bidi-L2-run-reordering-expected.png: Added.
platform/chromium-mac/fast/text/international/bidi-LDB-2-CSS-expected.checksum: Added.
platform/chromium-mac/fast/text/international/bidi-LDB-2-CSS-expected.png: Added.
platform/chromium-mac/fast/text/international/bidi-LDB-2-HTML-expected.checksum: Added.
platform/chromium-mac/fast/text/international/bidi-LDB-2-HTML-expected.png: Added.
platform/chromium-mac/fast/text/international/bidi-LDB-2-formatting-characters-expected.checksum: Added.
platform/chromium-mac/fast/text/international/bidi-LDB-2-formatting-characters-expected.png: Added.
platform/chromium-mac/fast/text/international/bidi-european-terminators-expected.checksum: Added.
platform/chromium-mac/fast/text/international/bidi-european-terminators-expected.png: Added.
platform/chromium-mac/fast/text/international/bidi-ignored-for-first-child-inline-expected.checksum: Added.
platform/chromium-mac/fast/text/international/bidi-ignored-for-first-child-inline-expected.png: Added.
platform/chromium-mac/fast/text/international/bidi-innertext-expected.checksum: Added.
platform/chromium-mac/fast/text/international/bidi-innertext-expected.png: Added.
platform/chromium-mac/fast/text/international/bidi-linebreak-001-expected.checksum: Added.
platform/chromium-mac/fast/text/international/bidi-linebreak-001-expected.png: Added.
platform/chromium-mac/fast/text/international/bidi-linebreak-002-expected.checksum: Added.
platform/chromium-mac/fast/text/international/bidi-linebreak-002-expected.png: Added.
platform/chromium-mac/fast/text/international/bidi-linebreak-003-expected.checksum: Added.
platform/chromium-mac/fast/text/international/bidi-linebreak-003-expected.png: Added.
platform/chromium-mac/fast/text/international/bidi-listbox-atsui-expected.checksum: Added.
platform/chromium-mac/fast/text/international/bidi-listbox-atsui-expected.png: Added.
platform/chromium-mac/fast/text/international/bidi-listbox-expected.checksum: Added.
platform/chromium-mac/fast/text/international/bidi-listbox-expected.png: Added.
platform/chromium-mac/fast/text/international/bidi-override-expected.checksum: Added.
platform/chromium-mac/fast/text/international/bidi-override-expected.png: Added.
platform/chromium-mac/fast/text/international/complex-character-based-fallback-expected.checksum: Added.
platform/chromium-mac/fast/text/international/complex-character-based-fallback-expected.png: Added.
platform/chromium-mac/fast/text/international/danda-space-expected.checksum: Added.
platform/chromium-mac/fast/text/international/danda-space-expected.png: Added.
platform/chromium-mac/fast/text/international/hebrew-vowels-expected.checksum: Added.
platform/chromium-mac/fast/text/international/hebrew-vowels-expected.png: Added.
platform/chromium-mac/fast/text/international/hindi-spacing-expected.checksum: Added.
platform/chromium-mac/fast/text/international/hindi-spacing-expected.png: Added.
platform/chromium-mac/fast/text/international/hindi-whitespace-expected.checksum: Added.
platform/chromium-mac/fast/text/international/hindi-whitespace-expected.png: Added.
platform/chromium-mac/fast/text/international/plane2-expected.checksum: Added.
platform/chromium-mac/fast/text/international/plane2-expected.png: Added.
platform/chromium-mac/fast/text/international/rtl-caret-expected.checksum: Added.
platform/chromium-mac/fast/text/international/rtl-caret-expected.png: Added.
platform/chromium-mac/fast/text/international/wrap-CJK-001-expected.checksum: Added.
platform/chromium-mac/fast/text/international/wrap-CJK-001-expected.png: Added.
platform/chromium-win/svg/filters/feColorMatrix-offset-expected.checksum: Added.
platform/chromium-win/svg/filters/feColorMatrix-offset-expected.png: Added.
platform/chromium/test_expectations.txt:

4:10 AM Changeset in webkit [74015] by benjamin.poulain@nokia.com

2 edits in trunk/WebKit2

2010-12-14 Benjamin Poulain <benjamin.poulain@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

WebKit 2 does not send touch cancel events correctly between processes
https://bugs.webkit.org/show_bug.cgi?id=50235

The classes WebKit2PlatformTouchPoint and WebKit2PlatformTouchEvent
misses the conversion of TouchCancel events and points.

This patch add the missing enums when converting from a WebTouchEvent
to a PlatformTouchEvent.

Testing is already covered by fast/events/touch/send-oncancel-event.html

Shared/WebEventConversion.cpp: (WebKit::WebKit2PlatformTouchPoint::WebKit2PlatformTouchPoint): (WebKit::WebKit2PlatformTouchEvent::WebKit2PlatformTouchEvent):

4:03 AM Changeset in webkit [74014] by commit-queue@webkit.org

2 edits in trunk/WebCore

2010-12-14 Charlie Reis <creis@chromium.org>

Reviewed by Darin Adler.

Remove stale include of Document.h in V8DOMWrapper.h
https://bugs.webkit.org/show_bug.cgi?id=50607

We no longer need to include Document.h or V8DOMMap.h in
V8DOMWrapper. Removing them to avoid dependencies.

bindings/v8/V8DOMWrapper.h:

3:48 AM Changeset in webkit [74013] by commit-queue@webkit.org

2 edits in trunk/WebKit2

2010-12-14 Zalan Bujtas <zbujtas@gmail.com>

Reviewed by Kenneth Rohde Christiansen.

Add loadFinished() for provisional load error
This fixes the hanging UI state, when provisional load error occurs due to
the async nature of policy check.

https://bugs.webkit.org/show_bug.cgi?id=48724

UIProcess/API/qt/ClientImpl.cpp: (loadFinished): (qt_wk_didFailProvisionalLoadWithErrorForFrame): (qt_wk_didFinishLoadForFrame): (qt_wk_didFailLoadWithErrorForFrame):

3:40 AM Changeset in webkit [74012] by commit-queue@webkit.org

4 edits
1 add in trunk

2010-12-14 Lucas De Marchi <lucas.demarchi@profusion.mobi>

Reviewed by Eric Seidel.

[EFL] Add linker script to export less symbols
https://bugs.webkit.org/show_bug.cgi?id=44609

Filter the exported symbols by using a linker script. Only symbols
starting with "ewk_" are exported.

cmake/OptionsEfl.cmake: Pass linker option to use a version script when linking webkit.
cmake/eflsymbols.filter: Added. Export only symbols starting with "ewk_" (C linkage).

2010-12-14 Lucas De Marchi <lucas.demarchi@profusion.mobi>

Reviewed by Eric Seidel.

[EFL] Add linker script to export less symbols
https://bugs.webkit.org/show_bug.cgi?id=44609

Filter the exported symbols by using a linker script. Only symbols
starting with "ewk_" are exported.

CMakeLists.txt: Add link flags to webkit library when there's a version script.

3:29 AM Changeset in webkit [74011] by commit-queue@webkit.org

3 edits
6 adds in trunk

2010-12-14 Julien Chaffraix <jchaffraix@codeaurora.org>

Reviewed by Darin Adler.

Test for: EventSource fails to connect if Content-Type header has a charset attribute
https://bugs.webkit.org/show_bug.cgi?id=45372

Test that a Content-Type of "text/event-stream; charset=UTF8" works correctly but
"text/event-stream" does not work.

http/tests/eventsource/eventsource-content-type-charset-expected.txt: Added.
http/tests/eventsource/eventsource-content-type-charset.html: Added.
http/tests/eventsource/eventsource-content-type-text-event-stream-foobar-expected.txt: Added.
http/tests/eventsource/eventsource-content-type-text-event-stream-foobar.html: Added.
http/tests/eventsource/resources/response-content-type-charset.php: Added.
http/tests/eventsource/resources/response-content-type-event-stream-foobar.php: Added.

2010-12-14 Julien Chaffraix <jchaffraix@codeaurora.org>

Reviewed by Darin Adler.

Test for: EventSource fails to connect if Content-Type header has a charset attribute
https://bugs.webkit.org/show_bug.cgi?id=45372

Tests: http/tests/eventsource/eventsource-content-type-charset.html

http/tests/eventsource/eventsource-content-type-text-event-stream-foobar.html

page/EventSource.cpp: (WebCore::EventSource::didReceiveResponse): Use the mimeType instead of the Content-Type header directly. This makes the detection of the "text/stream" mimeType more accurate.

3:02 AM Changeset in webkit [74010] by commit-queue@webkit.org

3 edits
4 adds in trunk

2010-12-14 Pieter Senster <psenster@google.com>

Reviewed by Dirk Schulze.

Test that the channel offsets in the ColorMatrix filter are correctly incorporated
https://bugs.webkit.org/show_bug.cgi?id=50682

platform/mac/svg/filters/feColorMatrix-offset-expected.checksum: Added.
platform/mac/svg/filters/feColorMatrix-offset-expected.png: Added.
platform/mac/svg/filters/feColorMatrix-offset-expected.txt: Added.
svg/filters/feColorMatrix-offset.svg: Added.

2010-12-14 Pieter Senster <psenster@google.com>

Reviewed by Dirk Schulze.

Incorporate the channel offsets from the ColorMatrix filter in the filter calculation
https://bugs.webkit.org/show_bug.cgi?id=50682

Test: svg/filters/feColorMatrix-offset.svg

platform/graphics/filters/FEColorMatrix.cpp: (WebCore::matrix):

2:50 AM Changeset in webkit [74009] by commit-queue@webkit.org

2 edits in trunk/WebCore

2010-12-14 Jarred Nicholls <jarred@sencha.com>

Reviewed by Kenneth Rohde Christiansen.

Qt's Clipboard::files() implementation for HTML5 Drag/Drop (DataTransfer)

No new tests. Run tests manually until DRT is updated w/ beginDragWithFiles.

platform/qt/ClipboardQt.cpp: (WebCore::ClipboardQt::files):

1:43 AM Changeset in webkit [74008] by eric@webkit.org

2 edits in trunk/WebKitTools

2010-12-14 Eric Seidel <eric@webkit.org>

Reviewed by Ojan Vafai.

webkit-patch should warn users when they're using a 32-bit git on a 64-bit system
https://bugs.webkit.org/show_bug.cgi?id=50715

This patch makes webkit-patch print the following:

Warning: This machine is 64-bit, but the git binary (/usr/local/git/bin/git) does not support 64-bit.
Install a 64-bit git for better performance, see:
https://lists.webkit.org/pipermail/webkit-dev/2010-December/015249.html

I wrote this mostly because I have approximately 8 machines that I use
and making sure each one is using a good Git install seemed folly.
webkit-patch makes a lot of git calls, so using a fast git can shave
several seconds in every invocation. See the webkit-dev thread for more info.

This message will print twice during 'webkit-patch upload',
once from webkit-patch and once from check-webkit-style.

Unfortunately there is no good way to test this due to how machine-dependent
the code is. I considered writing a test for the log message, but it seemed not worth it.

Scripts/webkitpy/common/checkout/scm.py:

12:34 AM Changeset in webkit [74007] by gyuyoung.kim@samsung.com

3 edits in trunk

2010-12-13 Gyuyoung Kim <gyuyoung.kim@samsung.com>

Unreviewed build fix for EFL.

Remove DataSourceGStreamer.cpp in WebCore/CMakeListsEfl.txt
Because, DataSourceGStreamer.cpp was removed by Bug 30007.

../WebCore/CMakeListsEfl.txt:

Dec 13, 2010:

11:17 PM Changeset in webkit [74006] by tonikitoo@webkit.org

3 edits in trunk/WebCore

2010-12-13 Antonio Gomes <agomes@rim.com>

Rubber stamped by Daniel Bates.

Spatial Navigation: code clean up (part V)
https://bugs.webkit.org/show_bug.cgi?id=50666

No new tests needed.

page/SpatialNavigation.cpp: (WebCore::distanceDataForNode): Made 'FocusCandidate current' const since it is not supposed to change within this function.
page/SpatialNavigation.h: Ditto.

10:58 PM Changeset in webkit [74005] by commit-queue@webkit.org

5 edits in trunk/WebCore

2010-12-13 takano takumi <takano@apple.com>

Reviewed by Dan Bernstein.

GlyphPage::fill() is slow on vertical writing (Mac)
https://bugs.webkit.org/show_bug.cgi?id=50865

No test. Just a performance improvement.

platform/graphics/Font.cpp: (WebCore::Font::isCJKIdeograph): Now this only checks pure ideographs (Hanji). (WebCore::Font::isCJKIdeographOrSymbol): Added this for Hanji and Hanji related symbols.
platform/graphics/Font.h:
platform/graphics/FontFastPath.cpp: (WebCore::Font::glyphDataForCharacter): Changed to call isCJKIdeographOrSymbol() instead of isCJKIdeograph().
platform/graphics/mac/GlyphPageTreeNodeMac.cpp: (WebCore::shouldUseCoreText): This tests if GlyphPage::fill() should use CoreText or not. For vertical writing, if the current page contains only ideographs, we go CG path. (WebCore::GlyphPage::fill): Made to call shouldUseCoreText() and switch code path.

10:51 PM Changeset in webkit [74004] by tonikitoo@webkit.org

3 edits in trunk/WebCore

2010-12-13 Antonio Gomes <agomes@rim.com>

Reviewed by Daniel Bates.

Spatial Navigation: code clean up (part IV)
https://bugs.webkit.org/show_bug.cgi?id=50666

Avoid calling canScrollInDirection more than necessary.

No new tests needed.

page/FocusController.cpp: (WebCore::FocusController::advanceFocusDirectionallyInContainer): Moved the call to canScrollInDirection() to within the scrollInDirection().
page/SpatialNavigation.cpp: Removed the assertion to canScrollingDirection function. (WebCore::scrollInDirection):

10:51 PM Changeset in webkit [74003] by tonikitoo@webkit.org

4 edits in trunk/WebCore

2010-12-13 Antonio Gomes <agomes@rim.com>

Reviewed by Daniel Bates.

Spatial Navigation: code clean up (part III)
https://bugs.webkit.org/show_bug.cgi?id=50666

No new tests needed.

page/SpatialNavigation.h: Added FocusCandidate::isFrameOwnerElement and WebCore::frameOwnerElement helper functions. (WebCore::FocusCandidate::isFrameOwnerElement): Returns true if the Node pointer wrapped by FocusCandidate is an instance of HTMLFrameOwnerElement. Returns false otherwise.
page/SpatialNavigation.cpp: (WebCore::frameOwnerElement): Returns the HTMLFrameOwnerElement associated with the FocusCandidate if appropriate.
page/FocusController.cpp: (WebCore::updateFocusCandidateIfNeeded): Make use of newly added frameOwnerElement() helper. (WebCore::FocusController::adva

10:03 PM Changeset in webkit [74002] by mitz@apple.com

12 edits in trunk/LayoutTests

Updated Leopard-specific results after r73993.

platform/mac-leopard/css2.1/t1202-counter-04-b-expected.txt:
platform/mac-leopard/css2.1/t1202-counters-04-b-expected.txt:
platform/mac-leopard/fast/text/complex-text-opacity-expected.txt:
platform/mac-leopard/fast/text/international/bidi-AN-after-L-expected.txt:
platform/mac-leopard/fast/text/international/bidi-AN-after-empty-run-expected.txt:
platform/mac-leopard/fast/text/international/bidi-CS-after-AN-expected.txt:
platform/mac-leopard/fast/text/international/bidi-mirror-he-ar-expected.txt:
platform/mac-leopard/fast/text/international/bidi-neutral-directionality-paragraph-start-expected.txt:
platform/mac-leopard/fast/text/international/bidi-neutral-run-expected.txt:
platform/mac-leopard/fast/text/international/thai-baht-space-expected.txt:
platform/mac-leopard/platform/mac/editing/input/devanagari-ligature-expected.txt:

9:53 PM Changeset in webkit [74001] by commit-queue@webkit.org

3 edits in trunk

2010-12-13 Mike Lawther <mikelawther@chromium.org>

Reviewed by Daniel Bates.

[skia] ignore transform for canvas shadows
https://bugs.webkit.org/show_bug.cgi?id=50437

platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContext::setPlatformShadow):

9:49 PM Changeset in webkit [74000] by weinig@apple.com

13 edits
3 adds in trunk/WebKit2

WebKit2: Need to be able to set the application name for the user agent for a WKPage
https://bugs.webkit.org/show_bug.cgi?id=51011

Reviewed by Anders Carlsson.

Fixes:

WebKit2: Need to be able to set the application name for the user agent for a WKPage
<rdar://problem/8564532>
WebKit2: Need to be able to get the computed user agent for a WKPage
<rdar://problem/8637285>

Moves user agent computation to the UIProcess and just passes it to the WebProcess
when it has changed.

Shared/WebPageCreationParameters.cpp:

(WebKit::WebPageCreationParameters::encode):
(WebKit::WebPageCreationParameters::decode):

Shared/WebPageCreationParameters.h:

Add a user agent to the creation parameters.

UIProcess/API/C/WKPage.cpp:

(WKPageCopyUserAgent):
(WKPageCopyApplicationNameForUserAgent):
(WKPageSetApplicationNameForUserAgent):
(WKPageSetCustomUserAgent):

UIProcess/API/C/WKPage.h:

Add new API to set the application name and access the computed user agent.

UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::close):
(WebKit::WebPageProxy::setUserAgent):
(WebKit::WebPageProxy::setApplicationNameForUserAgent):
(WebKit::WebPageProxy::setCustomUserAgent):
(WebKit::WebPageProxy::processDidCrash):
(WebKit::WebPageProxy::creationParameters):

UIProcess/WebPageProxy.h:

(WebKit::WebPageProxy::userAgent):
(WebKit::WebPageProxy::applicationNameForUserAgent):

UIProcess/mac/WebPageProxyMac.mm: Added.
WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::WebPage):
(WebKit::WebPage::setUserAgent):

WebProcess/WebPage/WebPage.h:

(WebKit::WebPage::userAgent):

WebProcess/WebPage/WebPage.messages.in:

Pipe through user agent.

(WebKit::callGestalt):
(WebKit::macOSXVersionString):
(WebKit::userVisibleWebKitVersionString):
(WebKit::WebPageProxy::standardUserAgent):

UIProcess/win/WebPageProxyWin.cpp: Added.

(WebKit::windowsVersion):
(WebKit::userVisibleWebKitVersionString):
(WebKit::WebPageProxy::standardUserAgent):
Port standardUserAgent computation from WebKit1.

UIProcess/qt/WebPageProxyQt.cpp: Added.

(WebKit::WebPageProxy::standardUserAgent):
Stub out the user agent so there is no change in behavior.

WebKit2.pro:
WebKit2.xcodeproj/project.pbxproj:
win/WebKit2.vcproj:

Add new file.

9:19 PM Changeset in webkit [73999] by commit-queue@webkit.org

48 edits in trunk

2010-12-13 Dai Mikurube <dmikurube@google.com>

Reviewed by Kent Tamura.

ValidityState's exposed functions should check if willValidate() is true before all
https://bugs.webkit.org/show_bug.cgi?id=50617

fast/css/pseudo-required-optional-005-expected.txt:
fast/css/pseudo-required-optional-005.html:
fast/css/pseudo-valid-001-expected.txt:
fast/css/pseudo-valid-001.html:
fast/css/pseudo-valid-unapplied-expected.txt:
fast/css/pseudo-valid-unapplied.html:
fast/forms/ValidityState-customError.html:
fast/forms/ValidityState-customError-expected.txt:
fast/forms/ValidityState-customError.html:
fast/forms/ValidityState-patternMismatch-expected.txt:
fast/forms/ValidityState-patternMismatch.html:
fast/forms/ValidityState-rangeOverflow-expected.txt:
fast/forms/ValidityState-rangeUnderflow-expected.txt:
fast/forms/ValidityState-stepMismatch-expected.txt:
fast/forms/ValidityState-tooLong-input-expected.txt:
fast/forms/ValidityState-tooLong-textarea-expected.txt:
fast/forms/ValidityState-typeMismatch-color-expected.txt:
fast/forms/ValidityState-typeMismatch-date-expected.txt:
fast/forms/ValidityState-typeMismatch-datetime-expected.txt:
fast/forms/ValidityState-typeMismatch-datetimelocal-expected.txt:
fast/forms/ValidityState-typeMismatch-month-expected.txt:
fast/forms/ValidityState-typeMismatch-number-expected.txt:
fast/forms/ValidityState-typeMismatch-time-expected.txt:
fast/forms/ValidityState-typeMismatch-url-expected.txt:
fast/forms/ValidityState-typeMismatch-week-expected.txt:
fast/forms/script-tests/ValidityState-rangeOverflow.js: (checkOverflow): (checkNotOverflow):
fast/forms/script-tests/ValidityState-rangeUnderflow.js: (checkUnderflow): (checkNotUnderflow):
fast/forms/script-tests/ValidityState-stepMismatch.js: (stepMismatchFor):
fast/forms/script-tests/ValidityState-tooLong-input.js:
fast/forms/script-tests/ValidityState-tooLong-textarea.js:
fast/forms/script-tests/ValidityState-typeMismatch-color.js: ():
fast/forms/script-tests/ValidityState-typeMismatch-date.js: (): (shouldBeValid): (shouldBeInvalid):
fast/forms/script-tests/ValidityState-typeMismatch-datetime.js: (): (shouldBeValid): (shouldBeInvalid):
fast/forms/script-tests/ValidityState-typeMismatch-datetimelocal.js: (): (shouldBeValid): (shouldBeInvalid):
fast/forms/script-tests/ValidityState-typeMismatch-month.js: (): (shouldBeValid): (shouldBeInvalid):
fast/forms/script-tests/ValidityState-typeMismatch-number.js: ():
fast/forms/script-tests/ValidityState-typeMismatch-time.js: (): (shouldBeValid): (shouldBeInvalid):
fast/forms/script-tests/ValidityState-typeMismatch-url.js: (check): (expectValid): (expectInvalid):
fast/forms/script-tests/ValidityState-typeMismatch-week.js: (): (shouldBeValid): (shouldBeInvalid):
fast/forms/script-tests/willvalidate.js:
fast/forms/willvalidate-expected.txt:

2010-12-13 Dai Mikurube <dmikurube@google.com>

Reviewed by Kent Tamura.

ValidityState's exposed functions should check if willValidate() is true before all
https://bugs.webkit.org/show_bug.cgi?id=50617

Added checking willValidate() to exposed functions. And modified willValidate() behavior
for <button type="submit"> and <input type="submit"> to return true if not disabled and
not readonly.

html/HTMLButtonElement.cpp: (WebCore::HTMLButtonElement::parseMappedAttribute): Added calling setNeedsWillValidateCheck() to refresh willValidate() after changing its type. (WebCore::HTMLButtonElement::recalcWillValidate): Added to return true if not disabled and not readonly when type="submit". It's to be compliant to the spec.
html/HTMLButtonElement.h:
html/SubmitInputType.cpp: (WebCore::SubmitInputType::supportsValidation): Removed it to enable willValidate() for <input> when type="submit". It's to be compliant to the spec. (WebCore::SubmitInputType::supportsRequired): Added it to reject required attributes though validation is available.
html/SubmitInputType.h:
html/ValidityState.cpp: Added checking willValidate(). (WebCore::ValidityState::typeMismatch): (WebCore::ValidityState::patternMismatch): (WebCore::ValidityState::tooLong): (WebCore::ValidityState::rangeUnderflow): (WebCore::ValidityState::rangeOverflow): (WebCore::ValidityState::stepMismatch): (WebCore::ValidityState::customError):
html/ValidityState.h:

9:08 PM Changeset in webkit [73998] by bweinstein@apple.com

8 edits
6 adds in trunk/LayoutTests

Rebaseline Windows test results after r73993. All of these results were updated on the Mac with this
change, and this rebaselines Windows results to pass.

platform/win/css2.1/t0805-c5519-brdr-r-01-e-expected.txt: Added.
platform/win/css2.1/t0805-c5521-brdr-l-01-e-expected.txt: Added.
platform/win/css2.1/t0905-c5525-fltblck-00-d-ag-expected.txt: Added.
platform/win/css2.1/t0905-c5525-fltwidth-00-c-g-expected.txt: Added.
platform/win/css2.1/t0905-c5525-fltwrap-00-b-expected.txt: Added.
platform/win/css2.1/t1202-counter-04-b-expected.txt:
platform/win/css2.1/t1202-counters-04-b-expected.txt:
platform/win/editing/deleting/5144139-2-expected.txt: Added.
platform/win/fast/text/international/bidi-mirror-he-ar-expected.txt:
platform/win/fast/text/international/bold-bengali-expected.txt:
platform/win/fast/text/international/complex-character-based-fallback-expected.txt:
platform/win/fast/text/international/hebrew-vowels-expected.txt:
platform/win/transforms/2d/hindi-rotated-expected.txt:

8:47 PM Changeset in webkit [73997] by commit-queue@webkit.org

2 edits in trunk/WebCore

2010-12-13 Noel Gordon <noel.gordon@gmail.com>

Reviewed by David Levin.

[chromium] Upstream skia/ImageBuffer.cpp routine mulDiv255Ceil()
https://bugs.webkit.org/show_bug.cgi?id=50545

Skia has rolled, replace uses of mulDiv255Ceil with SkMulDiv255Ceiling.

No new tests, no change in behaviour.

platform/graphics/skia/ImageBufferSkia.cpp: (WebCore::putImageData):

7:21 PM Changeset in webkit [73996] by commit-queue@webkit.org

4 edits in trunk

2010-12-13 Gavin Peters <gavinp@chromium.org>

Reviewed by Adam Barth.

Re land Purpose after bad merge
https://bugs.webkit.org/show_bug.cgi?id=51000

http/tests/misc/resources/prefetch-purpose.php:

2010-12-13 Gavin Peters <gavinp@chromium.org>

Reviewed by Adam Barth.

Re land Purpose after bad merge
https://bugs.webkit.org/show_bug.cgi?id=51000

loader/loader.cpp: (WebCore::Loader::load):

7:04 PM Changeset in webkit [73995] by commit-queue@webkit.org

2 edits in trunk/WebKit/chromium

2010-12-13 Mike Lawther <mikelawther@chromium.org>

Reviewed by James Robinson.

Update chromium DEPS to pull in latest Skia
https://bugs.webkit.org/show_bug.cgi?id=50984

Roll to revision that pulled in Skia r632 (http://src.chromium.org/viewvc/chrome?view=rev&revision=68558)

DEPS:

6:16 PM Changeset in webkit [73994] by mihaip@chromium.org

2 edits in trunk/LayoutTests

2010-12-13 Mihai Parparita <mihaip@chromium.org>

Unreviewed Chromium test expectations update.

Now that we've switched Chromium to the DRT (and the switch seems to
have stuck), remove the BUG_AWESOME lines about tests that only pass
with the DRT (but not test_shell).

platform/chromium/test_expectations.txt:

6:14 PM Changeset in webkit [73993] by mitz@apple.com

279 edits in trunk

<rdar://problem/8763696> REGRESSION (r72173): Fallback fonts’ vertical metrics aren’t accounted for even when line-height is unspecified
https://bugs.webkit.org/show_bug.cgi?id=50979

Reviewed by Simon Fraser.

WebCore:

Many test results updated.

rendering/InlineFlowBox.cpp: Reinstated the code that updates affectsAscent and

affectsDescent in the used-fonts code path. Renamed variables for clarity. Added
a check whether usedFonts is empty (which it might be if there is glyph overflow
but no fallback) as an optimization.

LayoutTests:

editing/selection/extend-selection-bidi-expected.txt:
platform/mac/css2.1/t0805-c5518-brdr-t-01-e-expected.checksum:
platform/mac/css2.1/t0805-c5518-brdr-t-01-e-expected.png:
platform/mac/css2.1/t0805-c5518-brdr-t-01-e-expected.txt:
platform/mac/css2.1/t0805-c5519-brdr-r-00-a-expected.checksum:
platform/mac/css2.1/t0805-c5519-brdr-r-00-a-expected.png:
platform/mac/css2.1/t0805-c5519-brdr-r-00-a-expected.txt:
platform/mac/css2.1/t0805-c5520-brdr-b-01-e-expected.checksum:
platform/mac/css2.1/t0805-c5520-brdr-b-01-e-expected.png:
platform/mac/css2.1/t0805-c5520-brdr-b-01-e-expected.txt:
platform/mac/css2.1/t0805-c5521-brdr-l-00-a-expected.checksum:
platform/mac/css2.1/t0805-c5521-brdr-l-00-a-expected.png:
platform/mac/css2.1/t0805-c5521-brdr-l-00-a-expected.txt:
platform/mac/css2.1/t0805-c5521-brdr-l-01-e-expected.checksum:
platform/mac/css2.1/t0805-c5521-brdr-l-01-e-expected.png:
platform/mac/css2.1/t0805-c5521-brdr-l-01-e-expected.txt:
platform/mac/css2.1/t0805-c5521-ibrdr-l-00-a-expected.checksum:
platform/mac/css2.1/t0805-c5521-ibrdr-l-00-a-expected.png:
platform/mac/css2.1/t0805-c5521-ibrdr-l-00-a-expected.txt:
platform/mac/css2.1/t0905-c414-flt-02-c-expected.checksum:
platform/mac/css2.1/t0905-c414-flt-02-c-expected.png:
platform/mac/css2.1/t0905-c414-flt-02-c-expected.txt:
platform/mac/css2.1/t0905-c414-flt-03-c-expected.checksum:
platform/mac/css2.1/t0905-c414-flt-03-c-expected.png:
platform/mac/css2.1/t0905-c414-flt-03-c-expected.txt:
platform/mac/css2.1/t0905-c414-flt-04-c-expected.checksum:
platform/mac/css2.1/t0905-c414-flt-04-c-expected.png:
platform/mac/css2.1/t0905-c414-flt-04-c-expected.txt:
platform/mac/css2.1/t0905-c414-flt-fit-01-d-g-expected.checksum:
platform/mac/css2.1/t0905-c414-flt-fit-01-d-g-expected.png:
platform/mac/css2.1/t0905-c414-flt-fit-01-d-g-expected.txt:
platform/mac/css2.1/t0905-c5525-fltblck-01-d-expected.checksum:
platform/mac/css2.1/t0905-c5525-fltblck-01-d-expected.png:
platform/mac/css2.1/t0905-c5525-fltblck-01-d-expected.txt:
platform/mac/css2.1/t0905-c5525-fltcont-00-d-g-expected.checksum:
platform/mac/css2.1/t0905-c5525-fltcont-00-d-g-expected.png:
platform/mac/css2.1/t0905-c5525-fltcont-00-d-g-expected.txt:
platform/mac/css2.1/t0905-c5525-flthw-00-c-g-expected.checksum:
platform/mac/css2.1/t0905-c5525-flthw-00-c-g-expected.png:
platform/mac/css2.1/t0905-c5525-flthw-00-c-g-expected.txt:
platform/mac/css2.1/t0905-c5525-fltwidth-00-c-g-expected.checksum:
platform/mac/css2.1/t0905-c5525-fltwidth-00-c-g-expected.png:
platform/mac/css2.1/t0905-c5525-fltwidth-00-c-g-expected.txt:
platform/mac/css2.1/t0905-c5525-fltwidth-02-c-g-expected.checksum:
platform/mac/css2.1/t0905-c5525-fltwidth-02-c-g-expected.png:
platform/mac/css2.1/t0905-c5525-fltwidth-02-c-g-expected.txt:
platform/mac/css2.1/t0905-c5525-fltwidth-03-c-g-expected.checksum:
platform/mac/css2.1/t0905-c5525-fltwidth-03-c-g-expected.png:
platform/mac/css2.1/t0905-c5525-fltwidth-03-c-g-expected.txt:
platform/mac/css2.1/t0905-c5525-fltwrap-00-b-expected.checksum:
platform/mac/css2.1/t0905-c5525-fltwrap-00-b-expected.png:
platform/mac/css2.1/t0905-c5525-fltwrap-00-b-expected.txt:
platform/mac/css2.1/t0905-c5526-flthw-00-c-g-expected.checksum:
platform/mac/css2.1/t0905-c5526-flthw-00-c-g-expected.png:
platform/mac/css2.1/t0905-c5526-flthw-00-c-g-expected.txt:
platform/mac/css2.1/t090501-c414-flt-01-b-expected.checksum:
platform/mac/css2.1/t090501-c414-flt-01-b-expected.png:
platform/mac/css2.1/t090501-c414-flt-01-b-expected.txt:
platform/mac/css2.1/t090501-c414-flt-03-b-g-expected.checksum:
platform/mac/css2.1/t090501-c414-flt-03-b-g-expected.png:
platform/mac/css2.1/t090501-c414-flt-03-b-g-expected.txt:
platform/mac/css2.1/t090501-c5525-flt-l-00-b-g-expected.checksum:
platform/mac/css2.1/t090501-c5525-flt-l-00-b-g-expected.png:
platform/mac/css2.1/t090501-c5525-flt-l-00-b-g-expected.txt:
platform/mac/css2.1/t090501-c5525-flt-r-00-b-g-expected.checksum:
platform/mac/css2.1/t090501-c5525-flt-r-00-b-g-expected.png:
platform/mac/css2.1/t090501-c5525-flt-r-00-b-g-expected.txt:
platform/mac/css2.1/t100304-c43-rpl-bbx-01-d-g-expected.checksum:
platform/mac/css2.1/t100304-c43-rpl-bbx-01-d-g-expected.png:
platform/mac/css2.1/t100304-c43-rpl-bbx-01-d-g-expected.txt:
platform/mac/css2.1/t1202-counter-03-b-expected.checksum:
platform/mac/css2.1/t1202-counter-03-b-expected.png:
platform/mac/css2.1/t1202-counter-03-b-expected.txt:
platform/mac/css2.1/t1202-counter-04-b-expected.checksum:
platform/mac/css2.1/t1202-counter-04-b-expected.png:
platform/mac/css2.1/t1202-counter-04-b-expected.txt:
platform/mac/css2.1/t1202-counter-09-b-expected.checksum:
platform/mac/css2.1/t1202-counter-09-b-expected.png:
platform/mac/css2.1/t1202-counter-09-b-expected.txt:
platform/mac/css2.1/t1202-counters-03-b-expected.checksum:
platform/mac/css2.1/t1202-counters-03-b-expected.png:
platform/mac/css2.1/t1202-counters-03-b-expected.txt:
platform/mac/css2.1/t1202-counters-04-b-expected.checksum:
platform/mac/css2.1/t1202-counters-04-b-expected.png:
platform/mac/css2.1/t1202-counters-04-b-expected.txt:
platform/mac/css2.1/t1202-counters-09-b-expected.checksum:
platform/mac/css2.1/t1202-counters-09-b-expected.png:
platform/mac/css2.1/t1202-counters-09-b-expected.txt:
platform/mac/editing/deleting/5144139-2-expected.checksum:
platform/mac/editing/deleting/5144139-2-expected.png:
platform/mac/editing/deleting/5144139-2-expected.txt:
platform/mac/editing/selection/caret-rtl-2-expected.checksum:
platform/mac/editing/selection/caret-rtl-2-expected.png:
platform/mac/editing/selection/caret-rtl-2-expected.txt:
platform/mac/editing/selection/caret-rtl-2-left-expected.checksum:
platform/mac/editing/selection/caret-rtl-2-left-expected.png:
platform/mac/editing/selection/caret-rtl-2-left-expected.txt:
platform/mac/editing/selection/caret-rtl-expected.checksum:
platform/mac/editing/selection/caret-rtl-expected.png:
platform/mac/editing/selection/caret-rtl-expected.txt:
platform/mac/editing/selection/caret-rtl-right-expected.checksum:
platform/mac/editing/selection/caret-rtl-right-expected.png:
platform/mac/editing/selection/caret-rtl-right-expected.txt:
platform/mac/editing/selection/extend-selection-bidi-expected.checksum:
platform/mac/editing/selection/extend-selection-bidi-expected.png:
platform/mac/fast/blockflow/Kusa-Makura-background-canvas-expected.checksum:
platform/mac/fast/blockflow/Kusa-Makura-background-canvas-expected.png:
platform/mac/fast/blockflow/Kusa-Makura-background-canvas-expected.txt:
platform/mac/fast/css/beforeSelectorOnCodeElement-expected.checksum:
platform/mac/fast/css/beforeSelectorOnCodeElement-expected.png:
platform/mac/fast/css/beforeSelectorOnCodeElement-expected.txt:
platform/mac/fast/css/font-face-opentype-expected.checksum:
platform/mac/fast/css/font-face-opentype-expected.png:
platform/mac/fast/css/font-face-opentype-expected.txt:
platform/mac/fast/css/rtl-ordering-expected.checksum:
platform/mac/fast/css/rtl-ordering-expected.png:
platform/mac/fast/css/rtl-ordering-expected.txt:
platform/mac/fast/css/text-overflow-ellipsis-bidi-expected.checksum:
platform/mac/fast/css/text-overflow-ellipsis-bidi-expected.png:
platform/mac/fast/css/text-overflow-ellipsis-bidi-expected.txt:
platform/mac/fast/css/text-overflow-ellipsis-expected.checksum:
platform/mac/fast/css/text-overflow-ellipsis-expected.png:
platform/mac/fast/css/text-overflow-ellipsis-expected.txt:
platform/mac/fast/css/text-overflow-ellipsis-strict-expected.checksum:
platform/mac/fast/css/text-overflow-ellipsis-strict-expected.png:
platform/mac/fast/css/text-overflow-ellipsis-strict-expected.txt:
platform/mac/fast/css/text-security-expected.checksum:
platform/mac/fast/css/text-security-expected.png:
platform/mac/fast/css/text-security-expected.txt:
platform/mac/fast/encoding/denormalised-voiced-japanese-chars-expected.checksum:
platform/mac/fast/encoding/denormalised-voiced-japanese-chars-expected.png:
platform/mac/fast/encoding/denormalised-voiced-japanese-chars-expected.txt:
platform/mac/fast/encoding/invalid-UTF-8-expected.checksum:
platform/mac/fast/encoding/invalid-UTF-8-expected.png:
platform/mac/fast/encoding/invalid-UTF-8-expected.txt:
platform/mac/fast/events/updateLayoutForHitTest-expected.checksum:
platform/mac/fast/events/updateLayoutForHitTest-expected.png:
platform/mac/fast/events/updateLayoutForHitTest-expected.txt:
platform/mac/fast/forms/select-visual-hebrew-expected.checksum:
platform/mac/fast/forms/select-visual-hebrew-expected.png:
platform/mac/fast/forms/select-visual-hebrew-expected.txt:
platform/mac/fast/forms/select-writing-direction-natural-expected.checksum:
platform/mac/fast/forms/select-writing-direction-natural-expected.png:
platform/mac/fast/forms/select-writing-direction-natural-expected.txt:
platform/mac/fast/forms/visual-hebrew-text-field-expected.checksum:
platform/mac/fast/forms/visual-hebrew-text-field-expected.png:
platform/mac/fast/forms/visual-hebrew-text-field-expected.txt:
platform/mac/fast/ruby/nested-ruby-expected.txt:
platform/mac/fast/text/atsui-multiple-renderers-expected.checksum:
platform/mac/fast/text/atsui-multiple-renderers-expected.png:
platform/mac/fast/text/atsui-multiple-renderers-expected.txt:
platform/mac/fast/text/backslash-to-yen-sign-euc-expected.checksum:
platform/mac/fast/text/backslash-to-yen-sign-euc-expected.png:
platform/mac/fast/text/backslash-to-yen-sign-euc-expected.txt:
platform/mac/fast/text/backslash-to-yen-sign-expected.checksum:
platform/mac/fast/text/backslash-to-yen-sign-expected.png:
platform/mac/fast/text/backslash-to-yen-sign-expected.txt:
platform/mac/fast/text/bidi-embedding-pop-and-push-same-expected.checksum:
platform/mac/fast/text/bidi-embedding-pop-and-push-same-expected.png:
platform/mac/fast/text/bidi-embedding-pop-and-push-same-expected.txt:
platform/mac/fast/text/capitalize-boundaries-expected.checksum:
platform/mac/fast/text/capitalize-boundaries-expected.png:
platform/mac/fast/text/capitalize-boundaries-expected.txt:
platform/mac/fast/text/cg-fallback-bolding-expected.checksum:
platform/mac/fast/text/cg-fallback-bolding-expected.png:
platform/mac/fast/text/cg-fallback-bolding-expected.txt:
platform/mac/fast/text/complex-text-opacity-expected.checksum:
platform/mac/fast/text/complex-text-opacity-expected.png:
platform/mac/fast/text/complex-text-opacity-expected.txt:
platform/mac/fast/text/in-rendered-text-rtl-expected.checksum:
platform/mac/fast/text/in-rendered-text-rtl-expected.png:
platform/mac/fast/text/in-rendered-text-rtl-expected.txt:
platform/mac/fast/text/international/001-expected.checksum:
platform/mac/fast/text/international/001-expected.png:
platform/mac/fast/text/international/001-expected.txt:
platform/mac/fast/text/international/002-expected.checksum:
platform/mac/fast/text/international/002-expected.png:
platform/mac/fast/text/international/002-expected.txt:
platform/mac/fast/text/international/003-expected.checksum:
platform/mac/fast/text/international/003-expected.png:
platform/mac/fast/text/international/003-expected.txt:
platform/mac/fast/text/international/bidi-AN-after-L-expected.checksum:
platform/mac/fast/text/international/bidi-AN-after-L-expected.png:
platform/mac/fast/text/international/bidi-AN-after-L-expected.txt:
platform/mac/fast/text/international/bidi-AN-after-empty-run-expected.checksum:
platform/mac/fast/text/international/bidi-AN-after-empty-run-expected.png:
platform/mac/fast/text/international/bidi-AN-after-empty-run-expected.txt:
platform/mac/fast/text/international/bidi-CS-after-AN-expected.checksum:
platform/mac/fast/text/international/bidi-CS-after-AN-expected.png:
platform/mac/fast/text/international/bidi-CS-after-AN-expected.txt:
platform/mac/fast/text/international/bidi-L2-run-reordering-expected.checksum:
platform/mac/fast/text/international/bidi-L2-run-reordering-expected.png:
platform/mac/fast/text/international/bidi-L2-run-reordering-expected.txt:
platform/mac/fast/text/international/bidi-LDB-2-CSS-expected.checksum:
platform/mac/fast/text/international/bidi-LDB-2-CSS-expected.png:
platform/mac/fast/text/international/bidi-LDB-2-CSS-expected.txt:
platform/mac/fast/text/international/bidi-LDB-2-HTML-expected.checksum:
platform/mac/fast/text/international/bidi-LDB-2-HTML-expected.png:
platform/mac/fast/text/international/bidi-LDB-2-HTML-expected.txt:
platform/mac/fast/text/international/bidi-LDB-2-formatting-characters-expected.checksum:
platform/mac/fast/text/international/bidi-LDB-2-formatting-characters-expected.png:
platform/mac/fast/text/international/bidi-LDB-2-formatting-characters-expected.txt:
platform/mac/fast/text/international/bidi-european-terminators-expected.checksum:
platform/mac/fast/text/international/bidi-european-terminators-expected.png:
platform/mac/fast/text/international/bidi-european-terminators-expected.txt:
platform/mac/fast/text/international/bidi-fallback-font-weight-expected.checksum:
platform/mac/fast/text/international/bidi-fallback-font-weight-expected.png:
platform/mac/fast/text/international/bidi-fallback-font-weight-expected.txt:
platform/mac/fast/text/international/bidi-ignored-for-first-child-inline-expected.checksum:
platform/mac/fast/text/international/bidi-ignored-for-first-child-inline-expected.png:
platform/mac/fast/text/international/bidi-ignored-for-first-child-inline-expected.txt:
platform/mac/fast/text/international/bidi-innertext-expected.checksum:
platform/mac/fast/text/international/bidi-innertext-expected.png:
platform/mac/fast/text/international/bidi-innertext-expected.txt:
platform/mac/fast/text/international/bidi-linebreak-001-expected.checksum:
platform/mac/fast/text/international/bidi-linebreak-001-expected.png:
platform/mac/fast/text/international/bidi-linebreak-001-expected.txt:
platform/mac/fast/text/international/bidi-linebreak-002-expected.checksum:
platform/mac/fast/text/international/bidi-linebreak-002-expected.png:
platform/mac/fast/text/international/bidi-linebreak-002-expected.txt:
platform/mac/fast/text/international/bidi-linebreak-003-expected.checksum:
platform/mac/fast/text/international/bidi-linebreak-003-expected.png:
platform/mac/fast/text/international/bidi-linebreak-003-expected.txt:
platform/mac/fast/text/international/bidi-listbox-atsui-expected.checksum:
platform/mac/fast/text/international/bidi-listbox-atsui-expected.png:
platform/mac/fast/text/international/bidi-listbox-atsui-expected.txt:
platform/mac/fast/text/international/bidi-listbox-expected.checksum:
platform/mac/fast/text/international/bidi-listbox-expected.png:
platform/mac/fast/text/international/bidi-listbox-expected.txt:
platform/mac/fast/text/international/bidi-menulist-expected.checksum:
platform/mac/fast/text/international/bidi-menulist-expected.png:
platform/mac/fast/text/international/bidi-menulist-expected.txt:
platform/mac/fast/text/international/bidi-mirror-he-ar-expected.checksum:
platform/mac/fast/text/international/bidi-mirror-he-ar-expected.png:
platform/mac/fast/text/international/bidi-mirror-he-ar-expected.txt:
platform/mac/fast/text/international/bidi-neutral-directionality-paragraph-start-expected.checksum:
platform/mac/fast/text/international/bidi-neutral-directionality-paragraph-start-expected.png:
platform/mac/fast/text/international/bidi-neutral-directionality-paragraph-start-expected.txt:
platform/mac/fast/text/international/bidi-neutral-run-expected.checksum:
platform/mac/fast/text/international/bidi-neutral-run-expected.png:
platform/mac/fast/text/international/bidi-neutral-run-expected.txt:
platform/mac/fast/text/international/bidi-override-expected.checksum:
platform/mac/fast/text/international/bidi-override-expected.png:
platform/mac/fast/text/international/bidi-override-expected.txt:
platform/mac/fast/text/international/complex-character-based-fallback-expected.checksum:
platform/mac/fast/text/international/complex-character-based-fallback-expected.png:
platform/mac/fast/text/international/complex-character-based-fallback-expected.txt:
platform/mac/fast/text/international/danda-space-expected.checksum:
platform/mac/fast/text/international/danda-space-expected.png:
platform/mac/fast/text/international/danda-space-expected.txt:
platform/mac/fast/text/international/hebrew-vowels-expected.checksum:
platform/mac/fast/text/international/hebrew-vowels-expected.png:
platform/mac/fast/text/international/hebrew-vowels-expected.txt:
platform/mac/fast/text/international/hindi-spacing-expected.checksum:
platform/mac/fast/text/international/hindi-spacing-expected.png:
platform/mac/fast/text/international/hindi-spacing-expected.txt:
platform/mac/fast/text/international/hindi-whitespace-expected.checksum:
platform/mac/fast/text/international/hindi-whitespace-expected.png:
platform/mac/fast/text/international/hindi-whitespace-expected.txt:
platform/mac/fast/text/international/plane2-expected.checksum:
platform/mac/fast/text/international/plane2-expected.png:
platform/mac/fast/text/international/plane2-expected.txt:
platform/mac/fast/text/international/rtl-caret-expected.checksum:
platform/mac/fast/text/international/rtl-caret-expected.png:
platform/mac/fast/text/international/rtl-caret-expected.txt:
platform/mac/fast/text/international/thai-baht-space-expected.checksum:
platform/mac/fast/text/international/thai-baht-space-expected.png:
platform/mac/fast/text/international/thai-baht-space-expected.txt:
platform/mac/fast/text/international/thai-line-breaks-expected.checksum:
platform/mac/fast/text/international/thai-line-breaks-expected.png:
platform/mac/fast/text/international/thai-line-breaks-expected.txt:
platform/mac/fast/text/international/wrap-CJK-001-expected.checksum:
platform/mac/fast/text/international/wrap-CJK-001-expected.png:
platform/mac/fast/text/international/wrap-CJK-001-expected.txt:
platform/mac/transforms/2d/hindi-rotated-expected.checksum:
platform/mac/transforms/2d/hindi-rotated-expected.png:
platform/mac/transforms/2d/hindi-rotated-expected.txt:

5:59 PM Changeset in webkit [73992] by beidson@apple.com

5 edits in trunk/WebKit2

<rdar://problem/8752202> and https://bugs.webkit.org/show_bug.cgi?id=50997
Expose "link title" and "link label" to InjectedBundleHitTestResult API

Reviewed by Jon Honeycutt (and Brian Weinstein in heart).

WebProcess/InjectedBundle/API/c/WKBundleHitTestResult.cpp:

(WKBundleHitTestResultCopyLinkLabel):
(WKBundleHitTestResultCopyLinkTitle):

WebProcess/InjectedBundle/API/c/WKBundleHitTestResult.h:

WebProcess/InjectedBundle/InjectedBundleHitTestResult.cpp:

(WebKit::InjectedBundleHitTestResult::linkLabel):
(WebKit::InjectedBundleHitTestResult::linkTitle):

WebProcess/InjectedBundle/InjectedBundleHitTestResult.h:

5:42 PM Changeset in webkit [73991] by eric@webkit.org

6 edits
1 add in trunk/WebKitTools

2010-12-13 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

FlakyTestReporter doesn't understand bots running from multiple email addresses
https://bugs.webkit.org/show_bug.cgi?id=50960

This explains at least one of the dupes of:
https://bugs.webkit.org/show_bug.cgi?id=50863
that we saw filed by the commit-queue this morning.
I think the other one was explained by my previous fix to result counting code.

Since this is really hard to test with a unit test, instead I
create a new (possibly useful in the future) command
which given a layout test path will return you
the one bug which our tools would assume it the flaky test bug.
If some other script wants to use bug-for-test we'll
need to extend it with some options like --create-if-missing or similar.

Scripts/webkitpy/common/net/bugzilla/bug.py:
Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
Scripts/webkitpy/tool/bot/flakytestreporter.py:
Scripts/webkitpy/tool/commands/init.py:
Scripts/webkitpy/tool/commands/bugfortest.py: Added.

5:28 PM Changeset in webkit [73990] by demarchi@webkit.org

2 edits in trunk/WebKit/efl

2010-12-13 Alex Bredariol Grilo <abgrilo@profusion.mobi>

Reviewed by Andreas Kling.

Remove adjacent tiles rendering queue.
https://bugs.webkit.org/show_bug.cgi?id=50023

In the current implementation of the tiled backing store, one extra row
and column of tiles are needed to render the entire viewport. These
extra row/col proved to be expensive when being rendered, and were
postponed to a queue that would render them after rendering the other
tiles of the viewport first. This approach complicated unnecessarily
the logics with no gain for keeping the extra row and column. This
change removes this rendering queue, for later removing the extra row
and column of tiles.

ewk/ewk_tiled_backing_store.c: (_ewk_tiled_backing_store_pre_render_request_add): (_ewk_tiled_backing_store_pre_render_request_flush): (_ewk_tiled_backing_store_pre_render_request_clear): (_ewk_tiled_backing_store_pre_render_request_process_single): (_ewk_tiled_backing_store_item_fill): (_ewk_tiled_backing_store_item_add): (_ewk_tiled_backing_store_item_del): (_ewk_tiled_backing_store_recalc_renderers): (ewk_tiled_backing_store_pre_render_region): (ewk_tiled_backing_store_pre_render_relative_radius): (ewk_tiled_backing_store_pre_render_cancel):

5:08 PM Changeset in webkit [73989] by mrowe@apple.com

2 edits in trunk/WebCore

Remove unnecessary include of Switch module.

Rubber-stamped by Jon Honeycutt.

There are no switch statements in this file.

dom/make_names.pl:

5:08 PM Changeset in webkit [73988] by bweinstein@apple.com

2 edits in trunk/WebKit2

Windows Build Fix. Add a needed include.

UIProcess/win/WebView.cpp:

4:59 PM Changeset in webkit [73987] by jhoneycutt@apple.com

2 edits in trunk/LayoutTests

Add a failing test to the Windows skipped list.

Rubber-stamped by Steve Falkenburg.

platform/win/Skipped:

Added fast/loader/user-stylesheet-fast-path.html.

4:55 PM Changeset in webkit [73986] by weinig@apple.com

20 edits
2 deletes in trunk/WebKit2

Remove associated page concept from WKView constructor
https://bugs.webkit.org/show_bug.cgi?id=50983

Reviewed by Anders Carlsson.

Step 2: Remove WebPageNamespace. It no longer does anything.

Shared/APIObject.h:
UIProcess/API/C/WKPage.h:
UIProcess/API/mac/WKView.mm:

(-[WKView initWithFrame:contextRef:pageGroupRef:]):

UIProcess/API/qt/qgraphicswkview.cpp:
UIProcess/API/qt/qwkcontext.cpp:

(QWKContext::QWKContext):

UIProcess/API/qt/qwkcontext_p.h:
UIProcess/API/qt/qwkpage.cpp:

(QWKPagePrivate::QWKPagePrivate):

UIProcess/API/qt/qwkpage_p.h:
UIProcess/WebContext.cpp:

(WebKit::WebContext::WebContext):
(WebKit::WebContext::~WebContext):
(WebKit::WebContext::createWebPage):

UIProcess/WebContext.h:
UIProcess/WebPageNamespace.cpp: Removed.
UIProcess/WebPageNamespace.h: Removed.
UIProcess/WebPageProxy.cpp:
UIProcess/WebPageProxy.h:

(WebKit::WebPageProxy::context):

UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::createWebPage):

UIProcess/WebProcessProxy.h:
UIProcess/win/WebView.cpp:

(WebKit::WebView::WebView):

UIProcess/win/WebView.h:
WebKit2.pro:
WebKit2.xcodeproj/project.pbxproj:
win/WebKit2.vcproj:

4:55 PM Changeset in webkit [73985] by mihaip@chromium.org

2 edits in trunk/WebKitTools

2010-12-13 Mihai Parparita <mihaip@chromium.org>

Reviewed by James Robinson.

Add option to build-webkit to not build WebKit2
https://bugs.webkit.org/show_bug.cgi?id=50988

Add support for a --no-webkit2 option to build-webkit. It seems to save
~1 minute from clean builds and ~10 seconds from no-op builds.

Scripts/build-webkit:

4:24 PM Changeset in webkit [73984] by commit-queue@webkit.org

2 edits in trunk/WebCore

2010-12-13 Emil Eklund <eae@chromium.org>

Reviewed by Dimitri Glazkov.

Change SelectionController::setFocusedNodeIfNeeded to traverse the DOM
tree instead of the render tree.
https://bugs.webkit.org/show_bug.cgi?id=50989

editing/SelectionController.cpp: (WebCore::SelectionController::setFocusedNodeIfNeeded): Walk up DOM/hosted tree rather than render tree and remove FIXME comment that does't apply (SelectionController and EventHandler needs different checks).

4:16 PM Changeset in webkit [73983] by Chris Fleizach

11 edits
2 adds in trunk

AX: aria-invalid should be supported.
https://bugs.webkit.org/show_bug.cgi?id=50573

Reviewed by Beth Dakin.

WebCore:

Test: platform/mac/accessibility/aria-invalid.html

accessibility/AXObjectCache.h:
accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::invalidStatus):

accessibility/AccessibilityObject.h:
accessibility/chromium/AXObjectCacheChromium.cpp

(WebCore::AXObjectCache::postPlatformNotification):

accessibility/mac/AXObjectCacheMac.mm:

(WebCore::AXObjectCache::postPlatformNotification):

accessibility/mac/AccessibilityObjectWrapper.mm:

(-[AccessibilityObjectWrapper accessibilityAttributeNames]):
(-[AccessibilityObjectWrapper accessibilityAttributeValue:]):

dom/Element.cpp:

(WebCore::Element::updateAfterAttributeChanged):

html/HTMLAttributeNames.in:

LayoutTests:

platform/mac/accessibility/aria-invalid-expected.txt: Added.
platform/mac/accessibility/aria-invalid.html: Added.
platform/mac/accessibility/radio-button-group-members-expected.txt:

4:15 PM Changeset in webkit [73982] by Stephanie Lewis

1 edit
13 copies
3 moves
96 adds in trunk/WebKitTools

Update iexploder from 1.3.2 to 1.7.2
Move 1.3.2 into its own subdir
Add 1.7.2 into its own subdir
update scripts to point to new 1.3.2 location (avoid breaking existing scripts)

Reviewed by Dave Kilzer.

Scripts/run-iexploder-tests:
Scripts/update-iexploder-cssproperties:
iExploder/CHANGELOG.txt: Removed.
iExploder/LICENSE.txt: Removed.
iExploder/README.txt: Removed.
iExploder/htdocs: Removed.
iExploder/iexploder-1.3.2: Added.
iExploder/iexploder-1.3.2/CHANGELOG.txt: Copied from iExploder/CHANGELOG.txt.
iExploder/iexploder-1.3.2/LICENSE.txt: Copied from iExploder/LICENSE.txt.
iExploder/iexploder-1.3.2/README.txt: Copied from iExploder/README.txt.
iExploder/iexploder-1.3.2/htdocs: Added.
iExploder/iexploder-1.3.2/htdocs/config.rb: Copied from iExploder/htdocs/config.rb.
iExploder/iexploder-1.3.2/htdocs/cssproperties.in: Copied from iExploder/htdocs/cssproperties.in.
iExploder/iexploder-1.3.2/htdocs/cssvalues.in: Copied from iExploder/htdocs/cssvalues.in.
iExploder/iexploder-1.3.2/htdocs/htmlattrs.in: Copied from iExploder/htdocs/htmlattrs.in.
iExploder/iexploder-1.3.2/htdocs/htmltags.in: Copied from iExploder/htdocs/htmltags.in.
iExploder/iexploder-1.3.2/htdocs/htmlvalues.in: Copied from iExploder/htdocs/htmlvalues.in.
iExploder/iexploder-1.3.2/htdocs/iexploder.cgi: Copied from iExploder/htdocs/iexploder.cgi.
iExploder/iexploder-1.3.2/htdocs/iexploder.rb: Copied from iExploder/htdocs/iexploder.rb.
iExploder/iexploder-1.3.2/htdocs/index.html: Copied from iExploder/htdocs/index.html.
iExploder/iexploder-1.3.2/htdocs/webserver.rb: Copied from iExploder/htdocs/webserver.rb.
iExploder/iexploder-1.3.2/tools: Added.
iExploder/iexploder-1.3.2/tools/lasthit.rb: Copied from iExploder/tools/lasthit.rb.
iExploder/iexploder-1.3.2/tools/osx_last_crash.rb: Copied from iExploder/tools/osx_last_crash.rb.
iExploder/iexploder-1.3.2/tools/showtest.rb: Copied from iExploder/tools/showtest.rb.
iExploder/iexploder-1.7.2: Added.
iExploder/iexploder-1.7.2/ChangeLog.txt: Added.
iExploder/iexploder-1.7.2/LICENSE.txt: Added.
iExploder/iexploder-1.7.2/README.txt: Added.
iExploder/iexploder-1.7.2/output: Added.
iExploder/iexploder-1.7.2/src: Added.
iExploder/iexploder-1.7.2/src/browser_harness.rb: Added.
iExploder/iexploder-1.7.2/src/config.yaml: Added.
iExploder/iexploder-1.7.2/src/css-atrules: Added.
iExploder/iexploder-1.7.2/src/css-atrules/mozilla: Added.
iExploder/iexploder-1.7.2/src/css-atrules/webkit: Added.
iExploder/iexploder-1.7.2/src/css-properties: Added.
iExploder/iexploder-1.7.2/src/css-properties/dillo: Added.
iExploder/iexploder-1.7.2/src/css-properties/gtkhtml: Added.
iExploder/iexploder-1.7.2/src/css-properties/internet_explorer6: Added.
iExploder/iexploder-1.7.2/src/css-properties/mozilla: Added.
iExploder/iexploder-1.7.2/src/css-properties/webkit: Added.
iExploder/iexploder-1.7.2/src/css-pseudo: Added.
iExploder/iexploder-1.7.2/src/css-pseudo/mozilla: Added.
iExploder/iexploder-1.7.2/src/css-pseudo/webkit: Added.
iExploder/iexploder-1.7.2/src/css-values: Added.
iExploder/iexploder-1.7.2/src/css-values/dillo: Added.
iExploder/iexploder-1.7.2/src/css-values/gtkhtml: Added.
iExploder/iexploder-1.7.2/src/css-values/mozilla: Added.
iExploder/iexploder-1.7.2/src/css-values/other: Added.
iExploder/iexploder-1.7.2/src/css-values/webkit: Added.
iExploder/iexploder-1.7.2/src/headers: Added.
iExploder/iexploder-1.7.2/src/headers/dillo: Added.
iExploder/iexploder-1.7.2/src/headers/gtkhtml: Added.
iExploder/iexploder-1.7.2/src/headers/mozilla: Added.
iExploder/iexploder-1.7.2/src/headers/webkit: Added.
iExploder/iexploder-1.7.2/src/html-attrs: Added.
iExploder/iexploder-1.7.2/src/html-attrs/dillo: Added.
iExploder/iexploder-1.7.2/src/html-attrs/gtkhtml: Added.
iExploder/iexploder-1.7.2/src/html-attrs/internet_explorer6: Added.
iExploder/iexploder-1.7.2/src/html-attrs/mozilla: Added.
iExploder/iexploder-1.7.2/src/html-attrs/other: Added.
iExploder/iexploder-1.7.2/src/html-attrs/webkit: Added.
iExploder/iexploder-1.7.2/src/html-tags: Added.
iExploder/iexploder-1.7.2/src/html-tags/dillo: Added.
iExploder/iexploder-1.7.2/src/html-tags/gtkhtml: Added.
iExploder/iexploder-1.7.2/src/html-tags/mozilla: Added.
iExploder/iexploder-1.7.2/src/html-tags/other: Added.
iExploder/iexploder-1.7.2/src/html-tags/webkit: Added.
iExploder/iexploder-1.7.2/src/html-values: Added.
iExploder/iexploder-1.7.2/src/html-values/dillo: Added.
iExploder/iexploder-1.7.2/src/html-values/gtkhtml: Added.
iExploder/iexploder-1.7.2/src/html-values/mozilla: Added.
iExploder/iexploder-1.7.2/src/html-values/other: Added.
iExploder/iexploder-1.7.2/src/html-values/webkit: Added.
iExploder/iexploder-1.7.2/src/iexploder.cgi: Added.
iExploder/iexploder-1.7.2/src/iexploder.rb: Added.
iExploder/iexploder-1.7.2/src/index.html: Added.
iExploder/iexploder-1.7.2/src/media: Added.
iExploder/iexploder-1.7.2/src/media/blank.ogg: Added.
iExploder/iexploder-1.7.2/src/media/blank.snd: Added.
iExploder/iexploder-1.7.2/src/media/blank.wav: Added.
iExploder/iexploder-1.7.2/src/media/bug.bmp: Added.
iExploder/iexploder-1.7.2/src/media/bug.gif: Added.
iExploder/iexploder-1.7.2/src/media/bug.ico: Added.
iExploder/iexploder-1.7.2/src/media/bug.jng: Added.
iExploder/iexploder-1.7.2/src/media/bug.jpg: Added.
iExploder/iexploder-1.7.2/src/media/bug.png: Added.
iExploder/iexploder-1.7.2/src/media/bug.svg: Added.
iExploder/iexploder-1.7.2/src/media/bug.tiff: Added.
iExploder/iexploder-1.7.2/src/media/bug.xbm: Added.
iExploder/iexploder-1.7.2/src/media/bug.xpm: Added.
iExploder/iexploder-1.7.2/src/mime-types: Added.
iExploder/iexploder-1.7.2/src/mime-types/dillo: Added.
iExploder/iexploder-1.7.2/src/mime-types/mozilla: Added.
iExploder/iexploder-1.7.2/src/mime-types/webkit: Added.
iExploder/iexploder-1.7.2/src/protocols: Added.
iExploder/iexploder-1.7.2/src/protocols/dillo: Added.
iExploder/iexploder-1.7.2/src/protocols/gtkhtml: Added.
iExploder/iexploder-1.7.2/src/protocols/mozilla: Added.
iExploder/iexploder-1.7.2/src/protocols/webkit: Added.
iExploder/iexploder-1.7.2/src/scanner.rb: Added.
iExploder/iexploder-1.7.2/src/version.rb: Added.
iExploder/iexploder-1.7.2/src/webserver.rb: Added.
iExploder/iexploder-1.7.2/testcases: Added.
iExploder/iexploder-1.7.2/testcases/testcase-Linux_x86_64_rv2.0b6pre_Gecko-20100904_Firefox-4.0b6pre-TEST-8375-1_59.html: Added.
iExploder/iexploder-1.7.2/testcases/testcase-Opera-9.80_Linux_x86_64_en_Presto-2.6.30_Version-10.61-16704-3_108,3.html: Added.
iExploder/iexploder-1.7.2/testcases/testcase-U_Intel_Mac_OS_X_10_6_4_en-US_AppleWebKit-534.8_Chrome-7.0.529.0-TEST-611-3_36,9.html: Added.
iExploder/iexploder-1.7.2/testcases/testcase-U_Intel_Mac_OS_X_10_6_4_en-US_AppleWebKit-534.8_hrome-7.0.529.0-TEST-55313622206-3_6,0.html: Added.
iExploder/iexploder-1.7.2/testcases/testcase-U_Linux_x86_64_en-US_AppleWebKit-534.6_Chrome-7.0.503.1-TEST-120813-8_72,56,24,8,0.html: Added.
iExploder/iexploder-1.7.2/testcases/testcase-U_Linux_x86_64_en-US_AppleWebKit-534.6_Chrome-7.0.503.1-TEST-121240-3_81,3.html: Added.
iExploder/iexploder-1.7.2/testcases/testcase-U_Linux_x86_64_en-US_AppleWebKit-534.7_Chrome-7.0.513.0-4800-5_80,65,15.html: Added.
iExploder/iexploder-1.7.2/testcases/testcase-U_Linux_x86_64_en-US_AppleWebKit-534.7_Chrome-7.0.513.0-TEST-23583190347-3_15,12.html: Added.
iExploder/iexploder-1.7.2/tools: Added.
iExploder/iexploder-1.7.2/tools/lasthit.rb: Added.
iExploder/iexploder-1.7.2/tools/osx_last_crash.rb: Added.
iExploder/iexploder-1.7.2/tools/release_src.sh: Added.
iExploder/iexploder-1.7.2/tools/update_html_tags_from_sources.sh: Added.
iExploder/tools: Removed.

4:02 PM Changeset in webkit [73981] by cwzwarich@webkit.org

2 edits in trunk/JavaScriptCore

Reviewed by Gavin Barraclough.

JavaScriptCore should not use "asm volatile" outside of a function
https://bugs.webkit.org/show_bug.cgi?id=50991

jit/JITStubs.cpp: Remove the volatile keyword from asm statements.

4:01 PM Changeset in webkit [73980] by sfalken@apple.com

2 edits in tags/Safari-534.14.3/JavaScriptCore

Merge r73967.

3:58 PM Changeset in webkit [73979] by sfalken@apple.com

5 edits in tags/Safari-534.14.3

Versioning.

3:39 PM Changeset in webkit [73978] by weinig@apple.com

2 edits in trunk/WebKit2

Fix windows build.

UIProcess/win/WebView.h:

3:39 PM Changeset in webkit [73977] by weinig@apple.com

3 edits in trunk/WebKit2

Fix windows build.

UIProcess/win/WebInspectorProxyWin.cpp:

(WebKit::WebInspectorProxy::platformCreateInspectorPage):

UIProcess/win/WebView.h:

(WebKit::WebView::create):

3:23 PM Changeset in webkit [73976] by weinig@apple.com

19 edits in trunk

Remove associated page concept from WKView constructor
https://bugs.webkit.org/show_bug.cgi?id=50983

Reviewed by Anders Carlsson.

Step 1: Remove associate page constructors from WKView and make
all views use the shared namespace for the context.

WebKit2:

UIProcess/API/C/win/WKView.cpp:
UIProcess/API/C/win/WKView.h:
UIProcess/API/mac/WKView.h:
UIProcess/API/mac/WKView.mm:

(-[WKView initWithFrame:contextRef:pageGroupRef:]):

UIProcess/API/qt/qwkcontext.cpp:
UIProcess/API/qt/qwkcontext.h:
UIProcess/mac/WebInspectorProxyMac.mm:

(WebKit::WebInspectorProxy::platformCreateInspectorPage):

UIProcess/win/WebView.cpp:

(WebKit::WebView::WebView):

UIProcess/win/WebView.h:

(WebKit::WebView::create):

WebKitTools:

TestWebKitAPI/PlatformWebView.h:
TestWebKitAPI/mac/PlatformWebViewMac.mm:
TestWebKitAPI/win/PlatformWebViewWin.cpp:
WebKitTestRunner/PlatformWebView.h:
WebKitTestRunner/TestController.cpp:

(WTR::createOtherPage):

WebKitTestRunner/mac/PlatformWebViewMac.mm:
WebKitTestRunner/qt/PlatformWebViewQt.cpp:
WebKitTestRunner/win/PlatformWebViewWin.cpp:

3:20 PM Changeset in webkit [73975] by commit-queue@webkit.org

3 edits in trunk/WebCore

2010-12-13 Joone Hur <joone@kldp.org>

Reviewed by Eric Seidel.

WebKit fails to compile when building with WML support enabled
https://bugs.webkit.org/show_bug.cgi?id=42943

Use TextPosition instead of lineNumber() and columNumber().

No new tests are added, because this is just a build fix.

dom/XMLDocumentParser.h: Make lineNumber() private.
wml/WMLErrorHandling.cpp: (WebCore::reportWMLError): Use TextPosition instead of lineNumber() and columnNumber().

3:19 PM Changeset in webkit [73974] by andersca@apple.com

2 edits in trunk/WebKit2

Fix build.

UIProcess/WebPageProxy.h:

3:06 PM Changeset in webkit [73973] by Chris Fleizach

2 edits in trunk

AX: lists and list boxes need different attributes
https://bugs.webkit.org/show_bug.cgi?id=50978

Reviewed by Beth Dakin.

WebCore:

Separate out the attributes being returned for lists (<ul>) and listboxes (<select multiple>).

accessibility/mac/AccessibilityObjectWrapper.mm:

(-[AccessibilityObjectWrapper accessibilityAttributeNames]):

LayoutTests:

platform/mac/accessibility/lists-expected.txt:

3:05 PM Changeset in webkit [73972] by hyatt@apple.com

3 edits in trunk/WebCore

https://bugs.webkit.org/show_bug.cgi?id=50963

Reviewed by Sam Weinig.

REGRESSION: Scrolling nested iframes is messed up on platforms that use the cross-platform ScrollView.

The selfClipRect and childrenClipRect methods of RenderLayer were incorrectly relying on the bounding box
of the root layer. This bounding box was only coincidentally incorporating overflow as part of the
RenderLayer's bounds. Since I fixed the RenderLayer bounds to not include layout overflow any longer,
this check is now exposed as incorrect. Use the entire document size when computing layer clip
rects.

rendering/RenderLayer.cpp:

(WebCore::RenderLayer::childrenClipRect):
(WebCore::RenderLayer::selfClipRect):

rendering/RenderView.h:

(WebCore::RenderView::documentRect):

3:05 PM Changeset in webkit [73971] by Chris Fleizach

2 edits in trunk

2010-12-13 Chris Fleizach <Chris Fleizach>

Reviewed by Beth Dakin.

AX: lists and list boxes need different attributes
https://bugs.webkit.org/show_bug.cgi?id=50978

Separate out the attributes being returned for lists (<ul>) and listboxes (<select multiple>).

accessibility/mac/AccessibilityObjectWrapper.mm: (-[AccessibilityObjectWrapper accessibilityAttributeNames]):

3:02 PM Changeset in webkit [73970] by bweinstein@apple.com

4 edits in trunk/WebKit2

WebKit2: Leaks a WebView when opening/closing Web Inspector on Windows
https://bugs.webkit.org/show_bug.cgi?id=50975
<rdar://problem/8763501>

Reviewed by Adam Roben.

Make m_inspectorView be a RefPtr<WebView>, instead of a WebView*.

UIProcess/WebInspectorProxy.cpp:

(WebKit::WebInspectorProxy::WebInspectorProxy): If we are on Windows, include WebView.h.

UIProcess/WebInspectorProxy.h: Change the type of m_inspectorView to a RefPtr<WebView>.
UIProcess/win/WebInspectorProxyWin.cpp:

(WebKit::WebInspectorProxy::platformCreateInspectorPage): Remove the call to leakRef when creating the WebView.

3:02 PM Changeset in webkit [73969] by sfalken@apple.com

1 copy in tags/Safari-534.14.3

New tag.

3:01 PM Changeset in webkit [73968] by andersca@apple.com

12 edits in trunk/WebKit2

Pass the complex text input state all the way to the UI process
https://bugs.webkit.org/show_bug.cgi?id=50980

Reviewed by Darin Adler.

PluginProcess/PluginControllerProxy.cpp:

(WebKit::PluginControllerProxy::setComplexTextInputEnabled):

UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::setComplexTextInputEnabled):

UIProcess/WebPageProxy.h:
UIProcess/WebPageProxy.messages.in:
WebProcess/Plugins/Netscape/NetscapePlugin.h:
WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:

(WebKit::NetscapePlugin::pluginComplexTextInputIdentifier):

WebProcess/Plugins/Plugin.h:
WebProcess/Plugins/PluginProxy.cpp:

(WebKit::PluginProxy::pluginComplexTextInputIdentifier):
(WebKit::PluginProxy::setComplexTextInputEnabled):

WebProcess/Plugins/PluginProxy.h:
WebProcess/Plugins/PluginProxy.messages.in:
WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::setComplexTextInputEnabled):

3:01 PM Changeset in webkit [73967] by sfalken@apple.com

2 edits in trunk/JavaScriptCore

Windows production build fix.
Try copying ICU 4.6 in addition to 4.4 and 4.2.

JavaScriptCore.vcproj/jsc/jscPostBuild.cmd:

2:50 PM Changeset in webkit [73966] by jianli@chromium.org

2 edits in trunk/LayoutTests

Unreviewed. Updated chromium test expectations.

platform/chromium/test_expectations.txt:

2:38 PM Changeset in webkit [73965] by weinig@apple.com

54 edits
2 deletes in trunk

Change the WebKit2 public API so there is no explicit WKPageNamespace object
https://bugs.webkit.org/show_bug.cgi?id=50898

Reviewed by Anders Carlsson.

WebKit2:

Shared/API/c/WKBase.h: Remove definition of WKPageNamespaceRef.
UIProcess/API/C/WKAPICast.h: Remove toAPI/toImpl for WKPageNamespaceRef.

UIProcess/API/C/WKPage.cpp:
UIProcess/API/C/WKPage.h:

Replace WKPageGetPageNamespace with WKPageGetContext.

UIProcess/API/C/WKPageNamespace.cpp: Removed.
UIProcess/API/C/WKPageNamespace.h: Removed.

UIProcess/API/C/WebKit2.h: Remove #include of WKPageNamespace.h.

UIProcess/API/C/win/WKView.cpp:

(WKViewCreate): Changed to take a WKContextRef instead of a WKPageNamespaceRef.
(WKViewCreateUsingSharedProcess): Added. Similar to WKViewCreate except that
all callers of it will have their views end up in the same shared process, whereas
with WKViewCreate, a new internal page namespace will be created and could place
the view's WebPage into a new process.
(WKViewCreateForAssociatedPage): Added. Creates a view that is forced to use the
same process as the passed in page.

UIProcess/win/WebView.cpp:

(WebKit::WebView::WebView):
(WebKit::WebView::initialize):

UIProcess/win/WebView.h:

(WebKit::WebView::create):
(WebKit::WebView::createUsingSharedProcess):
(WebKit::WebView::createForAssociatedPage):
Implementation of the WKView create functions.

UIProcess/API/C/win/WKView.h:
UIProcess/API/mac/WKView.h:
UIProcess/API/mac/WKView.mm:

(-[WKView initWithFrame:]):
(-[WKView initWithFrame:contextRef:]):
(-[WKView initWithFrame:contextRef:pageGroupRef:]):
(-[WKView initWithFrame:contextRef:usingSharedProcess:]):
(-[WKView initWithFrame:contextRef:pageGroupRef:usingSharedProcess:]):
(-[WKView initWithFrame:forAssociatedPageRef:]):
(-[WKView initWithFrame:forAssociatedPageRef:pageGroupRef:]):
(-[WKView initWithFrame:pageNamespace:pageGroup:]):
Add new initializers for the objective-c WKView. It follows the same
pattern as WKViewRef.

UIProcess/API/qt/qwkcontext.cpp:

(QWKContext::QWKContext):

UIProcess/API/qt/qwkcontext.h:

Remove uses of WKPageNamespaceRef.

UIProcess/WebContext.cpp:

(WebKit::WebContext::sharedPageNamespace): Returns a shared
page namespace used by the view's createUsingSharedProcess constructions.
(WebKit::WebContext::createPageNamespace): Change to return
a PassRefPtr to make things clearer.
(WebKit::WebContext::pageNamespaceWasDestroyed): Clear the shared
namespace if it is cleared.

UIProcess/WebContext.h:

UIProcess/WebPageNamespace.h: Remove unused "struct WKContextStatistics".

UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::context):

UIProcess/WebPageProxy.h:

Add context getter.

UIProcess/mac/WebInspectorProxyMac.mm:

(WebKit::WebInspectorProxy::platformCreateInspectorPage):

UIProcess/win/WebInspectorProxyWin.cpp:

(WebKit::WebInspectorProxy::platformCreateInspectorPage):
Use forAssociatedPageRef constructor for the WebInspector view.

WebKit2.pro:
WebKit2.xcodeproj/project.pbxproj:
win/WebKit2.vcproj:
win/WebKit2Generated.make:

Remove WKPageNamespace.h/cpp.

WebKitTools:

MiniBrowser/mac/AppDelegate.h:
MiniBrowser/mac/AppDelegate.m:
MiniBrowser/mac/BrowserWindowController.h:
MiniBrowser/mac/BrowserWindowController.m:
MiniBrowser/win/BrowserView.cpp:

Convert MiniBrowser to not use PageNamespaces.

TestWebKitAPI/PlatformWebView.h:
TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp:
TestWebKitAPI/Tests/WebKit2/EvaluateJavaScript.cpp:
TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp:
TestWebKitAPI/Tests/WebKit2/Find.cpp:
TestWebKitAPI/Tests/WebKit2/FrameMIMETypeHTML.cpp:
TestWebKitAPI/Tests/WebKit2/FrameMIMETypePNG.cpp:
TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic.cpp:
TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
TestWebKitAPI/Tests/WebKit2/PreventEmptyUserAgent.cpp:
TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
TestWebKitAPI/Tests/WebKit2/win/AltKeyGeneratesWMSysCommand.cpp:
TestWebKitAPI/Tests/WebKit2/win/WMCloseCallsUIClientClose.cpp:
TestWebKitAPI/mac/PlatformWebViewMac.mm:
TestWebKitAPI/win/PlatformWebViewWin.cpp:

Convert TestWebKitAPI to not use PageNamespaces.

WebKitTestRunner/PlatformWebView.h:
WebKitTestRunner/TestController.cpp:
WebKitTestRunner/TestController.h:
WebKitTestRunner/mac/PlatformWebViewMac.mm:
WebKitTestRunner/qt/PlatformWebViewQt.cpp:
WebKitTestRunner/win/PlatformWebViewWin.cpp:

Convert WebKitTestRunner to not use PageNamespaces.

2:34 PM Changeset in webkit [73964] by Simon Fraser

2 edits in trunk/WebCore

2010-12-13 Simon Fraser <Simon Fraser>

GraphicsContextPrivate.h was removed. Nuke it from the project.

WebCore.xcodeproj/project.pbxproj:

2:32 PM DetectingWebKit edited by arthur5005@gmail.com

http://developer.apple.com/internet/safari/uamatrix.html no longer … (diff)

2:29 PM Changeset in webkit [73963] by bfulgham@webkit.org

2 edits in trunk/WebKit2

Unreviewed build fix.

UIProcess/win/WebInspectorProxyWin.cpp: Non-Apple builds

need to include <wtf/RetainPtr.h>.

2:19 PM Changeset in webkit [73962] by msaboff@apple.com

5 edits in trunk

2010-12-13 Michael Saboff <msaboff@apple.com>

Reviewed by Oliver Hunt.

REGRESSION: mobileme mail viewing is broken
https://bugs.webkit.org/show_bug.cgi?id=50884

Fixed problem where simple parenthesis (those without capture and
with a fixed count) where not propagating backtrack to labels for
nested parentheses. Also added the nesting level for the parentheses
state created in that case as well.

yarr/RegexJIT.cpp: (JSC::Yarr::RegexGenerator::BacktrackDestination::copyBacktrackToLabel): (JSC::Yarr::RegexGenerator::TermGenerationState::isLastTerm): (JSC::Yarr::RegexGenerator::ParenthesesTail::generateCode): (JSC::Yarr::RegexGenerator::generateParenthesesSingle):

2010-12-13 Michael Saboff <msaboff@apple.com>

Reviewed by Oliver Hunt.

REGRESSION: mobileme mail viewing is broken
https://bugs.webkit.org/show_bug.cgi?id=50884

Added a test to check parentheses nesting within parentheses that
don't capture and that are fixed count. There is special handling
for this case in the RegExp JIT code.

fast/regex/parentheses-expected.txt:
fast/regex/script-tests/parentheses.js:

2:15 PM Changeset in webkit [73961] by Chris Fleizach

3 edits in trunk/LayoutTests

2010-12-13 Chris Fleizach <Chris Fleizach>

Reviewed by Beth Dakin.

Fix legend.htm accessibility test so it doesn't dump all attributes
https://bugs.webkit.org/show_bug.cgi?id=50957

accessibility/legend.html:
platform/mac/accessibility/legend-expected.txt:

2:08 PM Changeset in webkit [73960] by commit-queue@webkit.org

10 edits
1 copy in trunk/LayoutTests

2010-12-13 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r73922.
http://trac.webkit.org/changeset/73922
https://bugs.webkit.org/show_bug.cgi?id=50964

Remove rebaseline results due to that 73914 has been rolled
out (Requested by jianli on #webkit).

platform/chromium-linux/http/tests/security/xss-DENIED-frame-name-expected.txt: Copied from LayoutTests/platform/chromium-win/http/tests/security/xss-DENIED-frame-name-expected.txt.
platform/chromium-mac/http/tests/security/aboutBlank/xss-DENIED-navigate-opener-document-write-expected.txt:
platform/chromium-mac/http/tests/security/aboutBlank/xss-DENIED-navigate-opener-javascript-url-expected.txt:
platform/chromium-mac/http/tests/security/aboutBlank/xss-DENIED-set-opener-expected.txt:
platform/chromium-mac/http/tests/security/xss-DENIED-frame-name-expected.txt:
platform/chromium-win/http/tests/security/aboutBlank/xss-DENIED-navigate-opener-document-write-expected.txt:
platform/chromium-win/http/tests/security/aboutBlank/xss-DENIED-navigate-opener-javascript-url-expected.txt:
platform/chromium-win/http/tests/security/aboutBlank/xss-DENIED-set-opener-expected.txt:
platform/chromium-win/http/tests/security/xss-DENIED-frame-name-expected.txt:
platform/chromium/test_expectations.txt:

2:03 PM Changeset in webkit [73959] by jhoneycutt@apple.com

1 edit
2 deletes in trunk/LayoutTests

Remove some empty files that should've been removed as part of r73942.

Reviewed by Ojan Vafai.

editing/selection/extend-to-line-boundary-expected.txt: Removed.
editing/selection/extend-to-line-boundary.html: Removed.

2:00 PM Changeset in webkit [73958] by bfulgham@webkit.org

2 edits
2 adds in trunk/WebKit2

Unreviewed build fix after r73807.

Added stub implementation of Download object.

WebProcess/Downloads/curl: Added.
WebProcess/Downloads/curl/DownloadCurl.cpp: Added.

(WebKit::Download::start):
(WebKit::Download::startWithHandle):
(WebKit::Download::cancel):
(WebKit::Download::platformInvalidate):

win/WebKit2.vcproj: Exclude DownloadCFNet for Cairo builds,

added DownloadCurl (excluded for regular Apple builds.)

1:57 PM Changeset in webkit [73957] by eric.carlson@apple.com

2 edits in trunk/WebCore

2010-12-13 Eric Carlson <eric.carlson@apple.com>

Reviewed by Antti Koivisto.

HTMLMediaElement::endedPlayback should not return true if duration is zero
https://bugs.webkit.org/show_bug.cgi?id=50962

(WebCore::HTMLMediaElement::endedPlayback): Don't return true when duration is zero because a
media file can't play if it has no duration, therefore it can't have ended playback.

1:53 PM Changeset in webkit [73956] by andersca@apple.com

9 edits in trunk/WebKit2

Add the ability for plug-ins to toggle complex text input
https://bugs.webkit.org/show_bug.cgi?id=50966

Reviewed by Sam Weinig.

PluginProcess/PluginControllerProxy.cpp:

(WebKit::PluginControllerProxy::PluginControllerProxy):
Initialize m_isComplexTextInputEnabled.

(WebKit::PluginControllerProxy::setComplexTextInputEnabled):
Update m_isComplexTextInputEnabled.

PluginProcess/PluginControllerProxy.h:
WebProcess/Plugins/Netscape/NetscapePlugin.cpp:

(WebKit::NetscapePlugin::NetscapePlugin):
Initialize m_pluginHasFocus and m_windowHasFocus.

WebProcess/Plugins/Netscape/NetscapePlugin.h:

(WebKit::NetscapePlugin::isWindowActive):
Return m_windowHasFocus.

WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:

(WebKit::NetscapePlugin::platformSetFocus):
Update m_pluginHasFocus and call setComplexTextInputEnabled.

(WebKit::NetscapePlugin::windowFocusChanged):
Update m_windowHasFocus and call setComplexTextInputEnabled.

WebProcess/Plugins/PluginController.h:

Add setComplexTextInputEnabled.

WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::setComplexTextInputEnabled):

WebProcess/Plugins/PluginView.h:

Add setComplexTextInputEnabled

1:25 PM Changeset in webkit [73955] by bfulgham@webkit.org

2 edits in trunk/WebCore

Unreviewed build fix after r73840.

WebCore.vcproj/WebCoreGeneratedCairo.vsprops: Update property file

to pass three arguments to build-generated-files.sh, just like
the official Apple port.

1:21 PM Changeset in webkit [73954] by Antti Koivisto

2 edits in trunk/LayoutTests

Unreviewed.

Adding

http/tests/local/link-stylesheet-load-order.html
http/tests/local/link-stylesheet-load-order-preload.html

to the Gtk skip list.

platform/gtk/Skipped:

1:11 PM Changeset in webkit [73953] by mthole@apple.com

3 edits in trunk/WebKit/mac

https://bugs.webkit.org/show_bug.cgi?id=50956
WebAuthenticationPanel.nib appears to have a cut-off sentence

Rubber-stamped by John Sullivan.

Replace the sentence fragment in the sheet layout with "<-- do not localize -->" style text.
The contents of this text field are updated dynamically before the sheet is displayed.

Panels/English.lproj/WebAuthenticationPanel.nib/designable.nib:
Panels/English.lproj/WebAuthenticationPanel.nib/keyedobjects.nib:

12:54 PM Changeset in webkit [73952] by hyatt@apple.com

4 edits in trunk

WebCore: Make sure the defaultSpaceEventHandler does logical scrolling.

Reviewed by Adam Roben.

page/EventHandler.cpp:

(WebCore::EventHandler::defaultSpaceEventHandler):

WebKit2: Remove the space behavior that I added. It's covered in EventHandler in WebCore
already for Windows.

Reviewed by Adam Roben.

WebProcess/WebPage/win/WebPageWin.cpp:

(WebKit::WebPage::performDefaultBehaviorForKeyEvent):

12:41 PM Changeset in webkit [73951] by commit-queue@webkit.org

10 edits in trunk/WebKitTools

2010-12-13 Gabor Rapcsanyi <rgabor@inf.u-szeged.hu>

Reviewed by Eric Seidel.

webkit-patch rollout should be able to do multi-revision rollouts
https://bugs.webkit.org/show_bug.cgi?id=33336

Make it possible to pass more than one revision to webkit-patch.

Scripts/webkitpy/common/checkout/api.py:
Scripts/webkitpy/common/checkout/changelog.py:
Scripts/webkitpy/common/checkout/changelog_unittest.py:
Scripts/webkitpy/tool/commands/abstractsequencedcommand.py:
Scripts/webkitpy/tool/commands/download.py:
Scripts/webkitpy/tool/commands/download_unittest.py:
Scripts/webkitpy/tool/mocktool.py:
Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
Scripts/webkitpy/tool/steps/revertrevision.py:

12:36 PM Changeset in webkit [73950] by eric@webkit.org

3 edits in trunk/WebKitTools

2010-12-13 Eric Seidel <eric@webkit.org>

Unreviewed.

Teach webkit-patch how to search bugzilla
https://bugs.webkit.org/show_bug.cgi?id=50500

webkit-patch bug-search fails when there is only one result.
Turns out we needed a bit more logic in our result count parsing code.

Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:

12:35 PM Changeset in webkit [73949] by mdelaney@apple.com

11 edits in trunk/WebCore

2010-12-13 Matthew Delaney <mdelaney@apple.com>

Reviewed by Simon Fraser.

https://bugs.webkit.org/show_bug.cgi?id=50591 Adopt new CG API for canvas

No new tests necessary.

Configurations/WebCore.xcconfig: Added IOSurface framework link.
html/canvas/CanvasRenderingContext2D.cpp: Used IOSurface def. instead.
platform/graphics/ImageBuffer.h: Pushed renderingMode down into ctor.
platform/graphics/cairo/ImageBufferCairo.cpp:
platform/graphics/cg/ImageBufferCG.cpp:
platform/graphics/haiku/ImageBufferHaiku.cpp:
platform/graphics/qt/ImageBufferQt.cpp:
platform/graphics/skia/ImageBufferSkia.cpp:
platform/graphics/wince/ImageBufferWinCE.cpp:
platform/graphics/wx/ImageBufferWx.cpp:

12:30 PM Changeset in webkit [73948] by timothy@apple.com

1 copy in releases/Apple/Safari 3.0/WebKit

WebKit release tag for Safari 3.0.

12:30 PM Changeset in webkit [73947] by Antti Koivisto

3 edits in trunk/LayoutTests

Unreviewed.

Adding

http/tests/local/link-stylesheet-load-order.html
http/tests/local/link-stylesheet-load-order-preload.html

to Mac WebKit2 and Qt skip lists.

platform/mac-wk2/Skipped:
platform/qt/Skipped:

12:30 PM Changeset in webkit [73946] by timothy@apple.com

1 copy in releases/Apple/Safari 3.0/WebCore

WebCore release tag for Safari 3.0.

12:30 PM Changeset in webkit [73945] by timothy@apple.com

1 copy in releases/Apple/Safari 3.0/JavaScriptGlue

JavaScriptGlue release tag for Safari 3.0.

12:29 PM Changeset in webkit [73944] by timothy@apple.com

1 copy in releases/Apple/Safari 3.0/JavaScriptCore

JavaScriptCore release tag for Safari 3.0.

12:29 PM Changeset in webkit [73943] by timothy@apple.com

1 add in releases/Apple/Safari 3.0

Safari 3.0 release tag.

12:20 PM Changeset in webkit [73942] by jianli@chromium.org

5 edits in trunk

Unreviewed, rolling out r73923.
http://trac.webkit.org/changeset/73923
https://bugs.webkit.org/show_bug.cgi?id=50944

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2010-12-13
Broke editing/selection/extend-selection-home-end.html on non-
mac platforms. Looks like a real bug. (Requested by ojan on

WebCore:

editing/SelectionController.cpp:

(WebCore::SelectionController::positionForPlatform):
(WebCore::SelectionController::modifyExtendingForward):

LayoutTests:

editing/selection/extend-to-line-boundary-expected.txt: Removed.
editing/selection/extend-to-line-boundary.html: Removed.

12:14 PM Changeset in webkit [73941] by hyatt@apple.com

20 edits in trunk

WebCore: https://bugs.webkit.org/show_bug.cgi?id=48545, Home/End, PageUp/PageDwn should respect writing-mode.

Reviewed by Sam Weinig.

Add logical scrolling to WebCore. It basically mirrors physical scrolling but works in abstract logical
directions and only converts to physical when it's time to attempt the scroll.

Also fixed bugs in scrollRecursively and logicalScrollRecursively where overflow sections in containing
frames got skipped over.

Made the resetting of the inline axis scroll position on Home/End Mac-specific for overflow sections.

WebCore.exp.in:
page/EventHandler.cpp:

(WebCore::EventHandler::logicalScrollOverflow):
(WebCore::EventHandler::scrollRecursively):
(WebCore::EventHandler::logicalScrollRecursively):

page/EventHandler.h:
page/FrameView.cpp:

(WebCore::FrameView::isVerticalDocument):
(WebCore::FrameView::isFlippedDocument):

page/FrameView.h:
platform/ScrollTypes.h:

(WebCore::logicalToPhysical):

platform/ScrollView.cpp:

(WebCore::ScrollView::scroll):
(WebCore::ScrollView::logicalScroll):

platform/ScrollView.h:

(WebCore::ScrollView::isVerticalDocument):
(WebCore::ScrollView::isFlippedDocument):

rendering/RenderBox.cpp:

(WebCore::RenderBox::logicalScroll):

rendering/RenderBox.h:
rendering/RenderLayer.cpp:

(WebCore::RenderLayer::scroll):

rendering/RenderListBox.cpp:

(WebCore::RenderListBox::logicalScroll):

rendering/RenderListBox.h:
rendering/RenderTextControlSingleLine.cpp:

(WebCore::RenderTextControlSingleLine::logicalScroll):

rendering/RenderTextControlSingleLine.h:

WebKit2: https://bugs.webkit.org/show_bug.cgi?id=48545, Home/End, PageUp/PageDwn should respect writing-mode. Use
logical scrolling instead of physical scrolling for those keys in WebKit2.

Reviewed by Sam Weinig.

WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::logicalScroll):
(WebKit::WebPage::performDefaultBehaviorForKeyEvent):

WebProcess/WebPage/qt/WebPageQt.cpp:

(WebKit::logicalScroll):
(WebKit::WebPage::performDefaultBehaviorForKeyEvent):

WebProcess/WebPage/win/WebPageWin.cpp:

(WebKit::logicalScroll):
(WebKit::WebPage::performDefaultBehaviorForKeyEvent):

11:56 AM Changeset in webkit [73940] by commit-queue@webkit.org

6 edits in trunk/WebKit/chromium

2010-12-13 David Holloway <dhollowa@chromium.org>

Reviewed by Eric Seidel.

[chromium] Removes deprecated logic following the consolidation of AutoFill and
Autocomplete popup menu handling (https://bugs.webkit.org/show_bug.cgi?id=41236).
Filling of the form fields is now handled completely on the Chromium side, for
both AutoFill and Autocomplete.

https://bugs.webkit.org/show_bug.cgi?id=41822

public/WebView.h:
src/AutoFillPopupMenuClient.cpp: (WebKit::AutoFillPopupMenuClient::AutoFillPopupMenuClient): (WebKit::AutoFillPopupMenuClient::valueChanged):
src/AutoFillPopupMenuClient.h:
src/WebViewImpl.cpp: (WebKit::WebViewImpl::applyAutoFillSuggestions):
src/WebViewImpl.h:

11:54 AM Changeset in webkit [73939] by yurys@chromium.org

39 edits
2 moves
46 deletes in trunk

2010-12-13 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Rollout 73914, 73915, 73917, 73920 and 73921.

REGRESSION(r73914): "Chromium page_cycler_morejs fails" (Requested by yurys on #webkit).
https://bugs.webkit.org/show_bug.cgi?id=50950

fast/events/resources/window-onerror.js: Removed.
fast/events/window-onerror1-expected.txt: Removed.
fast/events/window-onerror1.html: Removed.
fast/events/window-onerror10-expected.txt: Removed.
fast/events/window-onerror10.html: Removed.
fast/events/window-onerror11-expected.txt: Removed.
fast/events/window-onerror11.html: Removed.
fast/events/window-onerror2-expected.txt: Removed.
fast/events/window-onerror2.html: Removed.
fast/events/window-onerror3-expected.txt: Removed.
fast/events/window-onerror3.html: Removed.
fast/events/window-onerror4-expected.txt: Removed.
fast/events/window-onerror4.html: Removed.
fast/events/window-onerror5-expected.txt: Removed.
fast/events/window-onerror5.html: Removed.
fast/events/window-onerror6-expected.txt: Removed.
fast/events/window-onerror6.html: Removed.
fast/events/window-onerror7-expected.txt: Removed.
fast/events/window-onerror7.html: Removed.
fast/events/window-onerror8-expected.txt: Removed.
fast/events/window-onerror8.html: Removed.
fast/events/window-onerror9-expected.txt: Removed.
fast/events/window-onerror9.html: Removed.
fast/workers/worker-script-error-expected.txt:
http/tests/security/resources/onerror-iframe.html: Removed.
http/tests/security/window-onerror-exception-in-iframe-expected.txt: Removed.
http/tests/security/window-onerror-exception-in-iframe.html: Removed.
platform/chromium-win/fast/workers/worker-script-error-expected.txt:
platform/chromium/fast/events/window-onerror1-expected.txt: Removed.
platform/chromium/fast/events/window-onerror10-expected.txt: Removed.
platform/chromium/fast/events/window-onerror11-expected.txt: Removed.
platform/chromium/fast/events/window-onerror2-expected.txt: Removed.
platform/chromium/fast/events/window-onerror3-expected.txt: Removed.
platform/chromium/fast/events/window-onerror4-expected.txt: Removed.
platform/chromium/fast/events/window-onerror5-expected.txt: Removed.
platform/chromium/fast/events/window-onerror6-expected.txt: Removed.
platform/chromium/fast/events/window-onerror7-expected.txt: Removed.
platform/chromium/fast/events/window-onerror8-expected.txt: Removed.
platform/chromium/fast/events/window-onerror9-expected.txt: Removed.
platform/chromium/http/tests/security/window-onerror-exception-in-iframe-expected.txt: Removed.
platform/chromium/userscripts/window-onerror-for-isolated-world-1-expected.txt: Removed.
platform/chromium/userscripts/window-onerror-for-isolated-world-2-expected.txt: Removed.
platform/gtk/Skipped:
userscripts/window-onerror-for-isolated-world-1-expected.txt: Removed.
userscripts/window-onerror-for-isolated-world-1.html: Removed.
userscripts/window-onerror-for-isolated-world-2-expected.txt: Removed.
userscripts/window-onerror-for-isolated-world-2.html: Removed.

2010-12-13 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Rollout 73914, 73915, 73917, 73920 and 73921.

REGRESSION(r73914): "Chromium page_cycler_morejs fails" (Requested by yurys on #webkit).
https://bugs.webkit.org/show_bug.cgi?id=50950

Android.jscbindings.mk:
CMakeLists.txt:
GNUmakefile.am:
WebCore.gypi:
WebCore.order:
WebCore.pro:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
bindings/js/JSBindingsAllInOne.cpp:
bindings/js/JSDOMBinding.cpp: (WebCore::reportException):
bindings/js/JSWorkerContextErrorHandler.cpp: Renamed from WebCore/bindings/js/JSErrorHandler.cpp. (WebCore::JSWorkerContextErrorHandler::JSWorkerContextErrorHandler): (WebCore::JSWorkerContextErrorHandler::~JSWorkerContextErrorHandler): (WebCore::JSWorkerContextErrorHandler::handleEvent):
bindings/js/JSWorkerContextErrorHandler.h: Renamed from WebCore/bindings/js/JSErrorHandler.h. (WebCore::JSWorkerContextErrorHandler::create): (WebCore::createJSWorkerContextErrorHandler):
bindings/scripts/CodeGeneratorJS.pm:
bindings/scripts/CodeGeneratorV8.pm:
bindings/v8/V8ConsoleMessage.cpp: (WebCore::V8ConsoleMessage::dispatchNow): (WebCore::V8ConsoleMessage::handler):
bindings/v8/V8ConsoleMessage.h:
bindings/v8/V8WindowErrorHandler.cpp: Removed.
bindings/v8/V8WindowErrorHandler.h: Removed.
bindings/v8/WorkerContextExecutionProxy.cpp: (WebCore::v8MessageHandler):
bindings/v8/WorkerScriptController.cpp: (WebCore::WorkerScriptController::evaluate):
dom/Document.cpp: (WebCore::Document::reportException): (WebCore::Document::addMessage):
dom/Document.h:
dom/ErrorEvent.cpp:
dom/ErrorEvent.h:
dom/Event.cpp:
dom/Event.h:
dom/ScriptExecutionContext.cpp: (WebCore::ScriptExecutionContext::ScriptExecutionContext):
dom/ScriptExecutionContext.h:
websockets/WebSocket.cpp: (WebCore::WebSocket::connect):
websockets/WebSocketChannel.cpp: (WebCore::WebSocketChannel::didOpen): (WebCore::WebSocketChannel::appendToBuffer):
websockets/WebSocketHandshake.cpp: (WebCore::WebSocketHandshake::readServerHandshake): (WebCore::WebSocketHandshake::readStatusLine): (WebCore::WebSocketHandshake::readHTTPHeaders): (WebCore::WebSocketHandshake::checkResponseHeaders):
workers/DefaultSharedWorkerRepository.cpp: (WebCore::postExceptionTask): (WebCore::postConsoleMessageTask):
workers/WorkerContext.cpp: (WebCore::WorkerContext::WorkerContext): (WebCore::WorkerContext::reportException): (WebCore::WorkerContext::addMessage):
workers/WorkerContext.h:
workers/WorkerMessagingProxy.cpp: (WebCore::WorkerExceptionTask::performTask): (WebCore::postConsoleMessageTask):
xml/XMLHttpRequest.cpp: (WebCore::reportUnsafeUsage):

2010-12-13 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Rollout 73914, 73915, 73917, 73920 and 73921.

REGRESSION(r73914): "Chromium page_cycler_morejs fails" (Requested by yurys on #webkit).
https://bugs.webkit.org/show_bug.cgi?id=50950

src/WebWorkerClientImpl.cpp: (WebKit::WebWorkerClientImpl::postExceptionToWorkerObject): (WebKit::WebWorkerClientImpl::postConsoleMessageToWorkerObject): (WebKit::WebWorkerClientImpl::postExceptionToWorkerObjectTask): (WebKit::WebWorkerClientImpl::postConsoleMessageToWorkerObjectTask):

11:49 AM Changeset in webkit [73938] by Antti Koivisto

31 edits
5 adds in trunk

WebCore: https://bugs.webkit.org/show_bug.cgi?id=50758
<rdar://problem/8722094>
Defer loading print stylesheets

Reviewed by Alexey Proskuryakov.

Make preload scanner skip stylesheets with non-screen media types.
Make it possible to specify non-default load priority from the client.
Use this mechanism to load print stylesheets using very low priority so they get loaded after everything else.
Move default priority code from Loader to CachedResource.
Move ResourceLoadScheduler::Priority enum to a separate file (as ResourceLoadPriority).
Add a way to make ResourceLoadScheduler load resources one at the time so the above functionality can be tested reliably.

Tests: http/tests/local/link-stylesheet-load-order-preload.html

http/tests/local/link-stylesheet-load-order.html

WebCore.exp.in:
WebCore.gypi:
WebCore.pro:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
css/CSSImageValue.cpp:

(WebCore::CSSImageValue::cachedImage):

html/HTMLLinkElement.cpp:

(WebCore::HTMLLinkElement::process):

html/parser/HTMLPreloadScanner.cpp:

(WebCore::HTMLNames::PreloadTask::PreloadTask):
(WebCore::HTMLNames::PreloadTask::processAttributes):
(WebCore::HTMLNames::PreloadTask::relAttributeIsStyleSheet):
(WebCore::HTMLNames::PreloadTask::linkMediaAttributeIsScreen):
(WebCore::HTMLNames::PreloadTask::preload):

loader/DocumentThreadableLoader.cpp:

(WebCore::DocumentThreadableLoader::loadRequest):

loader/ResourceLoadPriority.h: Added.
loader/ResourceLoadScheduler.cpp:

(WebCore::ResourceLoadScheduler::ResourceLoadScheduler):
(WebCore::ResourceLoadScheduler::scheduleSubresourceLoad):
(WebCore::ResourceLoadScheduler::schedulePluginStreamLoad):
(WebCore::ResourceLoadScheduler::scheduleLoad):
(WebCore::ResourceLoadScheduler::servePendingRequests):
(WebCore::ResourceLoadScheduler::HostInformation::~HostInformation):
(WebCore::ResourceLoadScheduler::HostInformation::schedule):
(WebCore::ResourceLoadScheduler::HostInformation::remove):
(WebCore::ResourceLoadScheduler::HostInformation::hasRequests):
(WebCore::ResourceLoadScheduler::HostInformation::limitRequests):

loader/ResourceLoadScheduler.h:

(WebCore::ResourceLoadScheduler::isSerialLoadingEnabled):
(WebCore::ResourceLoadScheduler::setSerialLoadingEnabled):
(WebCore::ResourceLoadScheduler::HostInformation::requestsPending):

loader/cache/CachedResource.cpp:

(WebCore::defaultPriorityForResourceType):
(WebCore::CachedResource::CachedResource):

loader/cache/CachedResource.h:

(WebCore::CachedResource::loadPriority):
(WebCore::CachedResource::setLoadPriority):

loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::requestCSSStyleSheet):
(WebCore::CachedResourceLoader::requestResource):
(WebCore::CachedResourceLoader::requestPreload):

loader/cache/CachedResourceLoader.h:
loader/cache/MemoryCache.cpp:

(WebCore::MemoryCache::requestResource):

loader/cache/MemoryCache.h:
loader/loader.cpp:

(WebCore::Loader::load):

WebKit/mac: https://bugs.webkit.org/show_bug.cgi?id=50758
<rdar://problem/8722094>
Defer loading print stylesheets

Reviewed by Alexey Proskuryakov.

Expose SPI for DRT for making resources load serially. This is useful for testing resource load order.

WebView/WebView.mm:

(+[WebView _setLoadResourcesSerially:forHost:]):

WebView/WebViewPrivate.h:

WebKitTools: Add setSerializeHTTPLoads function to allow testing resource load order on OS X.
https://bugs.webkit.org/show_bug.cgi?id=50758

Reviewed by Alexey Proskuryakov.

DumpRenderTree/LayoutTestController.cpp:

(setSerializeHTTPLoadsCallback):
(LayoutTestController::staticFunctions):

DumpRenderTree/LayoutTestController.h:
DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:

(LayoutTestController::setSerializeHTTPLoads):

DumpRenderTree/mac/DumpRenderTree.mm:

(resetDefaultsToConsistentValues):

DumpRenderTree/mac/LayoutTestControllerMac.mm:

(LayoutTestController::setSerializeHTTPLoads):

DumpRenderTree/win/LayoutTestControllerWin.cpp:

(LayoutTestController::setSerializeHTTPLoads):

LayoutTests: https://bugs.webkit.org/show_bug.cgi?id=50758
<rdar://problem/8722094>
Defer loading print stylesheets

Reviewed by Alexey Proskuryakov.

Test load ordering.

http/tests/local/link-stylesheet-load-order-expected.txt: Added.
http/tests/local/link-stylesheet-load-order-preload-expected.txt: Added.
http/tests/local/link-stylesheet-load-order-preload.html: Added.
http/tests/local/link-stylesheet-load-order.html: Added.

11:34 AM Changeset in webkit [73937] by jschuh@chromium.org

2 edits in trunk/WebCore

2010-12-13 Justin Schuh <jschuh@chromium.org>

Reviewed by Dimitri Glazkov.

Build fix for r73927
https://bugs.webkit.org/show_bug.cgi?id=50946

Reverting CSSCanvasValue::canvasDestroyed to its code before r73927
because it's breaking the build and I changed it only because it
appeared redunudant after r73927.

No behavior changed so no new tests needed.

css/CSSCanvasValue.cpp: (WebCore::CSSCanvasValue::canvasDestroyed):

11:29 AM Changeset in webkit [73936] by xan@webkit.org

4 edits in trunk/WebKit/gtk

2010-12-13 Xan Lopez <xlopez@igalia.com>

Reviewed by Martin Robinson.

[GTK] Add API to enable/disable plugins at runtime
https://bugs.webkit.org/show_bug.cgi?id=50891

tests/testwebplugindatabase.c: (test_webkit_web_plugin_database_get_plugins): test that disabling a plugin works.
webkit/webkitwebplugin.cpp: (webkit_web_plugin_get_property): hook 'enabled' property. (webkit_web_plugin_set_property): ditto. (webkit_web_plugin_class_init): define 'enabled' property. (webkit_web_plugin_set_enabled): setter for the property. (webkit_web_plugin_get_enabled): getter for the property.
webkit/webkitwebplugin.h: add the APIs to the header.

11:27 AM Changeset in webkit [73935] by bweinstein@apple.com

3 edits in trunk/WebKit2

WebKit2: Focusing Web Inspector window doesn't focus contents on Windows
https://bugs.webkit.org/show_bug.cgi?id=50947
<rdar://problem/8762468>

Reviewed by Darin Adler.

When we get the notification that the inspector window has focused, focus the inner inspector view.

UIProcess/WebInspectorProxy.h:
UIProcess/win/WebInspectorProxyWin.cpp:

(WebKit::WebInspectorProxy::onSetFocusEvent): Set the focus of the inspector view, because that is what

needs to be focused in the inspector window.

11:11 AM Changeset in webkit [73934] by rniwa@webkit.org

3 edits
8 copies in branches/chromium/597

Merge 73279 - 2010-12-03 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Darin Adler.

REGRESSION: Crash when deleting text after textarea's value is modified on input event
https://bugs.webkit.org/show_bug.cgi?id=49962

The crash was caused by TypingCommand::deleteKeyPressed's reusing a typing command for
textarea's shadow DOM after its input event handler rewrote the value set by the typing command.
Because the reused typing command's ending selection was pointing at a shadow node
that has been detached from the document when the event handler set the new value,
rootEditableElement of the ending selection was null and caused the crash.

Fixed the bug by updating the ending selection of the last typing command when it differsfrom
that of the current selection held by the SelectionController in TypingCommand::deleteKeyPressed.
Also fixed similar bugs in forwardDeleteKeyPressed and insertText, and insertTextRunWithoutNewlines.

Tests: editing/input/set-value-on-input-and-delete.html

editing/input/set-value-on-input-and-forward-delete.html
editing/input/set-value-on-input-and-type-input.html
editing/input/set-value-on-input-and-type-textarea.html

editing/InsertTextCommand.h: Added TypingCommand as a friend because it needs to update selection.
editing/TypingCommand.cpp: (WebCore::TypingCommand::deleteKeyPressed): Updates the last typing command's selection as needed. (WebCore::TypingCommand::forwardDeleteKeyPressed): Ditto. (WebCore::TypingCommand::insertText): Ditto. (WebCore::TypingCommand::updateSelectionIfDifferentFromCurrentSelection): Added. (WebCore::TypingCommand::insertTextRunWithoutNewlines): Updates InsertTextCommand's selection as needed.
editing/TypingCommand.h:

2010-12-03 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Darin Adler.

REGRESSION: Crash when deleting text after textarea's value is modified on input event
https://bugs.webkit.org/show_bug.cgi?id=49962

Added tests to ensure inserting and deleting a character inside input or textarea
succeeds even if the value of those elements have been rewritten by its input event handler.

editing/input/set-value-on-input-and-delete-expected.txt: Added.
editing/input/set-value-on-input-and-delete.html: Added.
editing/input/set-value-on-input-and-forward-delete-expected.txt: Added.
editing/input/set-value-on-input-and-forward-delete.html: Added.
editing/input/set-value-on-input-and-type-input-expected.txt: Added.
editing/input/set-value-on-input-and-type-input.html: Added.
editing/input/set-value-on-input-and-type-textarea-expected.txt: Added.
editing/input/set-value-on-input-and-type-textarea.html: Added.

BUG=62608
TBR=rniwa@webkit.org
Review URL: http://codereview.chromium.org/5812003

11:00 AM Changeset in webkit [73933] by mdelaney@apple.com

2 edits in trunk/WebCore

2010-12-13 Matthew Delaney <mdelaney@apple.com>

Reviewed by nobody, build fix.

Unlinking IOSurface framework from xcodeproj.

WebCore.xcodeproj/project.pbxproj:

10:41 AM Changeset in webkit [73932] by mitz@apple.com

2 edits in trunk/WebKit2

Coding style fix.

WebProcess/Downloads/mac/DownloadMac.mm:

(WebKit::originatingURLFromBackForwardList):

10:38 AM Changeset in webkit [73931] by timothy@apple.com

1 copy in releases/Apple/Safari 3.0.4

Safari 3.0.4 release tag.

10:35 AM Changeset in webkit [73930] by kbalazs@webkit.org

2 edits in trunk/WebKit2

Unreviewed trivial build fix (linux, 64 bit, gcc-4.5.1)

WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::exceededDatabaseQuota):
Don't use unsigned long long as alias for uint64_t.

10:27 AM Changeset in webkit [73929] by andersca@apple.com

2 edits in trunk/WebKit2

Crash when clicking a download link that targets a new tab
https://bugs.webkit.org/show_bug.cgi?id=50935
<rdar://problem/8760572>

Reviewed by John Sullivan.

Check for a null history item.

WebProcess/Downloads/mac/DownloadMac.mm:

(WebKit::originatingURLFromBackForwardList):

10:22 AM Changeset in webkit [73928] by Dimitri Glazkov

2 edits in trunk/WebKitTools

2010-12-13 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Ojan Vafai.

Remove "use-drt" option from test step command line, since the option was removed in r73748.
https://bugs.webkit.org/show_bug.cgi?id=50936

BuildSlaveSupport/build.webkit.org-config/master.cfg: Removed the option.

10:21 AM Changeset in webkit [73927] by jschuh@chromium.org

5 edits
2 adds in trunk

2010-12-13 Justin Schuh <jschuh@chromium.org>

Reviewed by Dimitri Glazkov.

HTMLCanvasElement should handle multiple observers.
https://bugs.webkit.org/show_bug.cgi?id=50899

Test: fast/canvas/canvas-bg-multiple-removal.html

css/CSSCanvasValue.cpp: (WebCore::CSSCanvasValue::~CSSCanvasValue): (WebCore::CSSCanvasValue::canvasDestroyed): (WebCore::CSSCanvasValue::element):
html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::HTMLCanvasElement): (WebCore::HTMLCanvasElement::~HTMLCanvasElement): (WebCore::HTMLCanvasElement::addObserver): (WebCore::HTMLCanvasElement::removeObserver): (WebCore::HTMLCanvasElement::didDraw): (WebCore::HTMLCanvasElement::reset):
html/HTMLCanvasElement.h:

2010-12-13 Justin Schuh <jschuh@chromium.org>

Reviewed by Dimitri Glazkov.

HTMLCanvasElement should handle multiple observers.
https://bugs.webkit.org/show_bug.cgi?id=50899

fast/canvas/canvas-bg-multiple-removal-expected.txt: Added.
fast/canvas/canvas-bg-multiple-removal.html: Added.

10:15 AM Changeset in webkit [73926] by mihaip@chromium.org

3 edits
2 adds in trunk

2010-12-13 Mihai Parparita <mihaip@chromium.org>

Reviewed by Adam Barth.

[Chromium] canvas/philip/tests/2d.missingargs.html hangs on Snow Leopard
https://bugs.webkit.org/show_bug.cgi?id=50841

Add test that calls strokeText() (i.e. with no arguments).

fast/canvas/strokeText-missing-args-expected.txt: Added.
fast/canvas/strokeText-missing-args.html: Added.

2010-12-13 Mihai Parparita <mihaip@chromium.org>

Reviewed by Adam Barth.

[Chromium] canvas/philip/tests/2d.missingargs.html hangs on Snow Leopard
https://bugs.webkit.org/show_bug.cgi?id=50841

Test: fast/canvas/strokeText-missing-args.html

We didn't have isfinite checks for the x and y coordinates that are
passed to strokeText/drawTextInternal (unlike all the other methods,
which got checks in r50910 and r59447).

html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::drawTextInternal):

10:13 AM Changeset in webkit [73925] by mdelaney@apple.com

20 edits in trunk

2010-12-09 Matthew Delaney <mdelaney@apple.com>

Reviewed by Simon Fraser.

Adopt new CG API for canvas
https://bugs.webkit.org/show_bug.cgi?id=50591

WebCoreSupport/WebSystemInterface.mm:

2010-12-09 Matthew Delaney <mdelaney@apple.com>

Reviewed by Simon Fraser.

Adopt new CG API for canvas
https://bugs.webkit.org/show_bug.cgi?id=50591

No new tests. All current layout tests are sufficient.

html/HTMLCanvasElement.cpp: Add in accelerateRendering flag for imagebuffer creation.
html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::isAccelerated): Always return true if using CA on new platforms. (WebCore::CanvasRenderingContext2D::drawTextInternal): Use accelerateRendering for imagebuffer.
platform/graphics/ImageBuffer.h: (WebCore::ImageBuffer::create): Plumb through new flag.
platform/graphics/cairo/ImageBufferCairo.cpp: Update method sig.
platform/graphics/cg/ImageBufferCG.cpp: Switch off of accelerateRendering flag for new accelerated paths.
platform/graphics/cg/ImageBufferData.h: Add in surface ref
platform/graphics/haiku/ImageBufferHaiku.cpp: Update method sig.
platform/graphics/qt/ImageBufferQt.cpp:
platform/graphics/skia/ImageBufferSkia.cpp:
platform/graphics/wince/ImageBufferWinCE.cpp:
platform/graphics/wx/ImageBufferWx.cpp:
platform/mac/WebCoreSystemInterface.h: Add new method sigs
platform/mac/WebCoreSystemInterface.mm:
rendering/RenderLayerBacking.cpp:
rendering/RenderLayerCompositor.cpp: Set acceleratesDrawing for canvas backings.

9:56 AM Changeset in webkit [73924] by commit-queue@webkit.org

2 edits in trunk/WebKit/efl

2010-12-13 Alex Bredariol Grilo <abgrilo@profusion.mobi>

Reviewed by Andreas Kling.

Remove one row/column of renderers.
https://bugs.webkit.org/show_bug.cgi?id=50456

This changes the algorithm in a way that it will require one less column
and row of renderers to fill the viewport. The direct result of this is
that now less tiles need to be rendered at once when displaying the
viewport.

ewk/ewk_tiled_backing_store.c: (_ewk_tiled_backing_store_smart_add): (_ewk_tiled_backing_store_recalc_renderers): (_ewk_tiled_backing_store_view_wrap_up): (_ewk_tiled_backing_store_view_wrap_down): (_ewk_tiled_backing_store_view_wrap_left): (_ewk_tiled_backing_store_view_wrap_right): (_ewk_tiled_backing_store_smart_calculate_offset_force): (_ewk_tiled_backing_store_smart_calculate_offset): (_ewk_tiled_backing_store_smart_calculate): (_ewk_tiled_backing_store_zoom_set_internal): (ewk_tiled_backing_store_zoom_weak_set): (ewk_tiled_backing_store_fix_offsets): (ewk_tiled_backing_store_flush):

9:27 AM Changeset in webkit [73923] by commit-queue@webkit.org

3 edits
2 adds in trunk

2010-12-13 Benjamin Kalman <kalman@chromium.org>

Reviewed by Ojan Vafai.

Shift-End does not select to the end of the line
https://bugs.webkit.org/show_bug.cgi?id=50610

editing/selection/extend-to-line-boundary-expected.txt: Added.
editing/selection/extend-to-line-boundary.html: Added.

2010-12-13 Benjamin Kalman <kalman@chromium.org>

Reviewed by Ojan Vafai.

Shift-End does not select to the end of the line
https://bugs.webkit.org/show_bug.cgi?id=50610

Test: editing/selection/extend-to-line-boundary.html

editing/SelectionController.cpp: (WebCore::SelectionController::positionForPlatform): Use visibleStart/visibleEnd rather than start/end. (WebCore::SelectionController::modifyExtendingForward):

9:05 AM Changeset in webkit [73922] by pfeldman@chromium.org

10 edits
1 delete in trunk/LayoutTests

2010-12-13 Pavel Feldman <pfeldman@chromium.org>

Not reviewed: rebaseline chromium xss tests for window.onerror.

platform/chromium-linux/http/tests/security/xss-DENIED-frame-name-expected.txt: Removed.
platform/chromium-mac/http/tests/security/aboutBlank/xss-DENIED-navigate-opener-document-write-expected.txt:
platform/chromium-mac/http/tests/security/aboutBlank/xss-DENIED-navigate-opener-javascript-url-expected.txt:
platform/chromium-mac/http/tests/security/aboutBlank/xss-DENIED-set-opener-expected.txt:
platform/chromium-mac/http/tests/security/xss-DENIED-frame-name-expected.txt:
platform/chromium-win/http/tests/security/aboutBlank/xss-DENIED-navigate-opener-document-write-expected.txt:
platform/chromium-win/http/tests/security/aboutBlank/xss-DENIED-navigate-opener-javascript-url-expected.txt:
platform/chromium-win/http/tests/security/aboutBlank/xss-DENIED-set-opener-expected.txt:
platform/chromium-win/http/tests/security/xss-DENIED-frame-name-expected.txt:
platform/chromium/test_expectations.txt:

8:39 AM Changeset in webkit [73921] by Adam Roben

2 edits in trunk/WebCore

Windows build fix after r73914

WebCore.vcproj/WebCore.vcproj: Fix malformed XML.

8:04 AM Changeset in webkit [73920] by yurys@chromium.org

3 edits in trunk/WebCore

2010-12-13 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Qt build fix.

dom/ScriptExecutionContext.cpp: (WebCore::ScriptExecutionContext::ScriptExecutionContext):
dom/ScriptExecutionContext.h:

7:54 AM Changeset in webkit [73919] by commit-queue@webkit.org

2 edits in trunk/LayoutTests

2010-12-13 John Knottenbelt <jknotten@chromium.org>

Reviewed by Steve Block.

Fix layout test dom/fast/Geolocation/permission-denied-already-error.html for client-based Geolocation
https://bugs.webkit.org/show_bug.cgi?id=50920

fast/dom/Geolocation/script-tests/permission-denied-already-error.js:

7:53 AM Changeset in webkit [73918] by mario@webkit.org

3 edits
2 adds in trunk

2010-12-13 Mario Sanchez Prada <msanchez@igalia.com>

Reviewed by Xan Lopez.

[Gtk] Additional support is needed for caret browsing
https://bugs.webkit.org/show_bug.cgi?id=25526

New layout test to check the "MoveTo{Beginninng|End}OfDocument"
commands when caret browsing is enabled.

platform/gtk/editing/selection/caret-mode-document-begin-end-expected.txt: Added.
platform/gtk/editing/selection/caret-mode-document-begin-end.html: Added.

2010-12-13 Mario Sanchez Prada <msanchez@igalia.com>

Reviewed by Xan Lopez.

[Gtk] Additional support is needed for caret browsing
https://bugs.webkit.org/show_bug.cgi?id=25526

Enable "MoveTo{Beginninng|End}OfDocument" commands when caret
browsing is enabled.

This change impacts the GTK-port only as caret browsing is a
feature only used in that platform so far.

Test: platform/gtk/editing/selection/caret-mode-document-begin-end.html

editing/EditorCommand.cpp: (WebCore::createCommandMap): Enable the commads when in caret browsing.

7:46 AM QtWebKitRelease22 created by Ademar Reis

7:45 AM Changeset in webkit [73917] by yurys@chromium.org

3 edits in trunk/WebCore

2010-12-13 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Qt build fix.

dom/Event.cpp: (WebCore::Event::isErrorEvent):
dom/Event.h: remove ENABLE(WORKERS) guard since ErrorEvent is now used not only in workers.

7:35 AM Changeset in webkit [73916] by loislo@chromium.org

15 edits in trunk

2010-12-13 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: Protocol cleanup task. Assign domain attribute to Resources and Debugger specific functions.

Debugger and Resources related notification functions of Inspector.idl were
marked as such with help of "domain" attribute. The other changes in js files
are reflecting this change. Some wrappers in WebInspector namespace were dropped,
the others were moved to DebuggerModel class.

https://bugs.webkit.org/show_bug.cgi?id=50906

inspector/Inspector.idl:
inspector/InspectorDebuggerAgent.cpp: (WebCore::InspectorDebuggerAgent::didParseSource):
inspector/InspectorProfilerAgent.cpp: (WebCore::InspectorProfilerAgent::resetState):
inspector/front-end/DOMAgent.js: (WebInspector.DOMAgent.prototype.didCommitLoad):
inspector/front-end/Database.js:
inspector/front-end/DebuggerModel.js: (WebInspector.DebuggerModel): (WebInspector.DebuggerModel.prototype.pausedScript): (WebInspector.DebuggerModel.prototype.resumedScript): (WebInspector.DebuggerModel.prototype.attachDebuggerWhenShown): (WebInspector.DebuggerModel.prototype.debuggerWasEnabled): (WebInspector.DebuggerModel.prototype.debuggerWasDisabled): (WebInspector.DebuggerModel.prototype.parsedScriptSource): (WebInspector.DebuggerModel.prototype.failedToParseScriptSource): (WebInspector.DebuggerModel.prototype.didCreateWorker): (WebInspector.DebuggerModel.prototype.didDestroyWorker):
inspector/front-end/ProfilesPanel.js: (WebInspector.ProfilesPanel): (WebInspector.ProfilesPanel.prototype.updateMainViewWidth): (WebInspector.ProfilesPanel.prototype.setRecordingProfile):
inspector/front-end/ResourceManager.js: (WebInspector.ResourceManager): (WebInspector.ResourceManager.prototype._unbindResourceURL): (WebInspector.ResourceManager.prototype.updateDOMStorage): (WebInspector.ResourceManager.prototype.updateApplicationCacheStatus): (WebInspector.ResourceManager.prototype.didGetFileSystemPath): (WebInspector.ResourceManager.prototype.didGetFileSystemError): (WebInspector.ResourceManager.prototype.didGetFileSystemDisabled): (WebInspector.ResourceManager.prototype.updateNetworkState): (WebInspector.ResourceManager.prototype.addDOMStorage): (WebInspector.ResourceManager.prototype.selectDOMStorage): (WebInspector.ResourceManager.prototype.addDatabase): (WebInspector.ResourceManager.prototype.selectDatabase): (WebInspector.ResourceManager.prototype.sqlTransactionSucceeded): (WebInspector.ResourceManager.prototype.sqlTransactionFailed):
inspector/front-end/WorkersSidebarPane.js: (WebInspector.Worker):
inspector/front-end/inspector.js:

2010-12-13 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: Protocol cleanup task. Assign domain attribute to Resources and Debugger specific functions.

Debugger and Resources related notification functions of Inspector.idl were
marked as such with help of "domain" attribute. The other changes in js files
are reflecting this change. Some wrappers in WebInspector namespace were dropped,
the others were moved to DebuggerModel class.

https://bugs.webkit.org/show_bug.cgi?id=50906

src/js/Tests.js: (.TestSuite.prototype._waitForScriptPause): (.TestSuite.prototype._waitUntilScriptsAreParsed.waitForAllScripts): (.TestSuite.prototype._waitUntilScriptsAreParsed):

2010-12-13 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: Protocol cleanup task. Assign domain attribute to Resources and Debugger specific functions.

Debugger and Resources related notification functions of Inspector.idl were
marked as such with help of "domain" attribute. The other changes in js files
are reflecting this change. Some wrappers in WebInspector namespace were dropped,
the others were moved to DebuggerModel class.

https://bugs.webkit.org/show_bug.cgi?id=50906

http/tests/inspector/debugger-test2.js: (initialize_DebuggerTest.InspectorTest.startDebuggerTest.startTest): (initialize_DebuggerTest.InspectorTest.startDebuggerTest): (initialize_DebuggerTest.InspectorTest.completeDebuggerTest.disableDebugger): (initialize_DebuggerTest.InspectorTest.showScriptSource):

7:33 AM Changeset in webkit [73915] by yurys@chromium.org

3 edits in trunk/WebCore

2010-12-13 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Qt build fix.

dom/ErrorEvent.cpp:
dom/ErrorEvent.h: remove ENABLE(WORKERS) guard since ErrorEvent is now used not only in workers.

7:16 AM Changeset in webkit [73914] by yurys@chromium.org

35 edits
2 copies
2 moves
45 adds in trunk

2010-12-13 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Adam Barth.

WebCore doesn't fire window.onerror event when uncaught JavaScript exceptions are thrown
https://bugs.webkit.org/show_bug.cgi?id=8519

Uncaught exceptions are propagated to window.onerror hander if one is present.
The handler is expected to be a function accepting three arguments: error message,
resource url and line number where the exception occured.

fast/events/resources/window-onerror.js: Added. (throwException):
fast/events/window-onerror1-expected.txt: Added.
fast/events/window-onerror1.html: Added.
fast/events/window-onerror10-expected.txt: Added.
fast/events/window-onerror10.html: Added.
fast/events/window-onerror11-expected.txt: Added.
fast/events/window-onerror11.html: Added.
fast/events/window-onerror2-expected.txt: Added.
fast/events/window-onerror2.html: Added.
fast/events/window-onerror3-expected.txt: Added.
fast/events/window-onerror3.html: Added.
fast/events/window-onerror4-expected.txt: Added.
fast/events/window-onerror4.html: Added.
fast/events/window-onerror5-expected.txt: Added.
fast/events/window-onerror5.html: Added.
fast/events/window-onerror6-expected.txt: Added.
fast/events/window-onerror6.html: Added.
fast/events/window-onerror7-expected.txt: Added.
fast/events/window-onerror7.html: Added.
fast/events/window-onerror8-expected.txt: Added.
fast/events/window-onerror8.html: Added.
fast/events/window-onerror9-expected.txt: Added.
fast/events/window-onerror9.html: Added.
fast/workers/worker-script-error-expected.txt:
http/tests/security/resources/onerror-iframe.html: Added.
http/tests/security/window-onerror-exception-in-iframe-expected.txt: Added.
http/tests/security/window-onerror-exception-in-iframe.html: Added.
platform/chromium-win/fast/workers/worker-script-error-expected.txt:
platform/chromium/fast/events/window-onerror1-expected.txt: Added.
platform/chromium/fast/events/window-onerror10-expected.txt: Added.
platform/chromium/fast/events/window-onerror11-expected.txt: Added.
platform/chromium/fast/events/window-onerror2-expected.txt: Added.
platform/chromium/fast/events/window-onerror3-expected.txt: Added.
platform/chromium/fast/events/window-onerror4-expected.txt: Added.
platform/chromium/fast/events/window-onerror5-expected.txt: Added.
platform/chromium/fast/events/window-onerror6-expected.txt: Added.
platform/chromium/fast/events/window-onerror7-expected.txt: Added.
platform/chromium/fast/events/window-onerror8-expected.txt: Added.
platform/chromium/fast/events/window-onerror9-expected.txt: Added.
platform/chromium/http/tests/security/window-onerror-exception-in-iframe-expected.txt: Added.
platform/chromium/userscripts/window-onerror-for-isolated-world-1-expected.txt: Added.
platform/chromium/userscripts/window-onerror-for-isolated-world-2-expected.txt: Added.
userscripts/window-onerror-for-isolated-world-1-expected.txt: Added.
userscripts/window-onerror-for-isolated-world-1.html: Added.
userscripts/window-onerror-for-isolated-world-2-expected.txt: Added.
userscripts/window-onerror-for-isolated-world-2.html: Added.

2010-12-13 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Adam Barth.

WebCore doesn't fire window.onerror event when uncaught JavaScript exceptions are thrown
https://bugs.webkit.org/show_bug.cgi?id=8519

Uncaught exceptions are propagated to window.onerror hander if one is present.
The handler is expected to be a function accepting three arguments: error message,
resource url and line number where the exception occured.

It was decided to dispatch ErrorEvent to all listeners/handlers no matter if they
were created in the same isolated world where the exception occured or not.

Tests: fast/events/window-onerror1.html

fast/events/window-onerror10.html
fast/events/window-onerror11.html
fast/events/window-onerror2.html
fast/events/window-onerror3.html
fast/events/window-onerror4.html
fast/events/window-onerror5.html
fast/events/window-onerror6.html
fast/events/window-onerror7.html
fast/events/window-onerror8.html
fast/events/window-onerror9.html
http/tests/security/window-onerror-exception-in-iframe.html
userscripts/window-onerror-for-isolated-world-1.html
userscripts/window-onerror-for-isolated-world-2.html

Android.jscbindings.mk:
CMakeLists.txt:
GNUmakefile.am:
WebCore.gypi:
WebCore.order:
WebCore.pro:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
bindings/js/JSBindingsAllInOne.cpp:
bindings/js/JSDOMBinding.cpp: (WebCore::reportException):
bindings/js/JSErrorHandler.cpp: Renamed from WebCore/bindings/js/JSWorkerContextErrorHandler.cpp. (WebCore::JSErrorHandler::JSErrorHandler): (WebCore::JSErrorHandler::~JSErrorHandler): (WebCore::JSErrorHandler::handleEvent):
bindings/js/JSErrorHandler.h: Copied from WebCore/bindings/js/JSWorkerContextErrorHandler.h. (WebCore::JSErrorHandler::create): (WebCore::createJSErrorHandler):
bindings/scripts/CodeGeneratorJS.pm:
bindings/scripts/CodeGeneratorV8.pm:
bindings/v8/V8ConsoleMessage.cpp: (WebCore::V8ConsoleMessage::dispatchNow): (WebCore::V8ConsoleMessage::handler): the method was changed to use generic WebCore exception reporting mechanism which is also used by JSC bindings.
bindings/v8/V8ConsoleMessage.h:
bindings/v8/V8WindowErrorHandler.cpp: Copied from WebCore/bindings/js/JSWorkerContextErrorHandler.h. (WebCore::V8WindowErrorHandler::V8WindowErrorHandler): (WebCore::V8WindowErrorHandler::callListenerFunction):
bindings/v8/V8WindowErrorHandler.h: Renamed from WebCore/bindings/js/JSWorkerContextErrorHandler.h. (WebCore::V8WindowErrorHandler::create):
bindings/v8/WorkerContextExecutionProxy.cpp: (WebCore::v8MessageHandler):
bindings/v8/WorkerScriptController.cpp: (WebCore::WorkerScriptController::evaluate):
dom/Document.cpp: (WebCore::Document::errorEventTarget): (WebCore::Document::logExceptionToConsole):
dom/Document.h:
dom/ScriptExecutionContext.cpp: (WebCore::ScriptExecutionContext::PendingException::PendingException): (WebCore::ScriptExecutionContext::ScriptExecutionContext): (WebCore::ScriptExecutionContext::reportException): this method is not virtual anymore to ensure that error event dispatching algorithm is the same in WorkerContext and in Document. (WebCore::ScriptExecutionContext::dispatchErrorEvent):
dom/ScriptExecutionContext.h:
workers/DefaultSharedWorkerRepository.cpp: (WebCore::postExceptionTask):
workers/WorkerContext.cpp: (WebCore::WorkerContext::WorkerContext): (WebCore::WorkerContext::errorEventTarget): (WebCore::WorkerContext::logExceptionToConsole):
workers/WorkerContext.h:
workers/WorkerMessagingProxy.cpp: (WebCore::WorkerExceptionTask::performTask):

2010-12-13 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Adam Barth.

WebCore doesn't fire window.onerror event when uncaught JavaScript exceptions are thrown
https://bugs.webkit.org/show_bug.cgi?id=8519

Uncaught exceptions are propagated to window.onerror hander if one is present.
The handler is expected to be a function accepting three arguments: error message,
resource url and line number where the exception occured.

src/WebWorkerClientImpl.cpp: (WebKit::WebWorkerClientImpl::postExceptionToWorkerObject): (WebKit::WebWorkerClientImpl::postExceptionToWorkerObjectTask):

7:06 AM Changeset in webkit [73913] by apavlov@chromium.org

17 edits in trunk

2010-12-08 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Joseph Pecoraro.

Web Inspector: Enable CSS property editing name/value-wise (like Firebug does)
https://bugs.webkit.org/show_bug.cgi?id=50565

For CSS property editing, the property name and value have become two fields separated
by a colon (rather than one field containing the full property text.) A user can tab
between the name and value fields forward and backward. A colon typed in the name field
and a semicolon in the value field (unless found inside a string) act as a Tab and focus
the next editable field (while applying the entire property value.)

Now a user can tab through all editable styles for an element, even across rule boundaries.

WebCore:

inspector/front-end/BreakpointsSidebarPane.js: (WebInspector.XHRBreakpointsSidebarPane.prototype._startEditingBreakpoint):
inspector/front-end/DataGrid.js: (WebInspector.DataGrid.prototype._startEditingColumnOfDataGridNode): (WebInspector.DataGrid.prototype._startEditing):
inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeElement.prototype._startEditingAttribute): (WebInspector.ElementsTreeElement.prototype._startEditingTextNode): (WebInspector.ElementsTreeElement.prototype._startEditingTagName): (WebInspector.ElementsTreeElement.prototype._startEditingAsHTML):
inspector/front-end/MetricsSidebarPane.js: (WebInspector.MetricsSidebarPane.prototype.startEditing):
inspector/front-end/ObjectPropertiesSection.js: (WebInspector.ObjectPropertyTreeElement.prototype.startEditing):
inspector/front-end/Section.js: (WebInspector.Section): (WebInspector.Section.prototype.get subtitleAsTextForTest): (WebInspector.Section.prototype.get nextSibling): (WebInspector.Section.prototype.get previousSibling):
inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype._editBreakpointCondition):
inspector/front-end/StylesSidebarPane.js: (WebInspector.StylePropertiesSection.prototype.nextEditableSibling): (WebInspector.StylePropertiesSection.prototype.previousEditableSibling): (WebInspector.StylePropertiesSection.prototype.addNewBlankProperty): (WebInspector.StylePropertiesSection.prototype.startEditingSelector): (WebInspector.StylePropertiesSection.prototype.editingSelectorCommitted): (WebInspector.StylePropertyTreeElement.prototype.): (WebInspector.StylePropertyTreeElement.prototype):
inspector/front-end/TextViewer.js: (WebInspector.TextViewer.prototype._handleDoubleClick):
inspector/front-end/WatchExpressionsSidebarPane.js: (WebInspector.WatchExpressionTreeElement.prototype.startEditing):
inspector/front-end/inspector.css: (.child-editing):
inspector/front-end/inspector.js: (WebInspector.startEditing.defaultFinishHandler): (WebInspector.startEditing):
inspector/front-end/treeoutline.js: (TreeElement.prototype.select):

LayoutTests:

inspector/console-dir.html:
inspector/styles-add-blank-property.html:

6:25 AM Changeset in webkit [73912] by yael.aharon@nokia.com

2 edits in trunk/WebCore

Unreviewed.

Added svn propery eol-style. Patches to this file fail to apply on Windows EWS bot.

accessibility/AccessibilityAllInOne.cpp: Added property svn:eol-style.

6:20 AM Changeset in webkit [73911] by commit-queue@webkit.org

1 edit
10 deletes in trunk/LayoutTests

2010-12-13 W. James MacLean <wjmaclean@chromium.org>

Reviewed by Csaba Osztrogonác.

Remove unnecessary pixel results, use platform-independent text results, re Changeset 72802
https://bugs.webkit.org/show_bug.cgi?id=50233

Remove redundant, platform-specific test results.

platform/chromium-linux/svg/custom/svg-parse-overflow-1-expected.txt: Removed.
platform/chromium-linux/svg/custom/svg-parse-overflow-2-expected.txt: Removed.
platform/chromium-linux/svg/custom/svg-parse-overflow-3-expected.txt: Removed.
platform/chromium-linux/svg/custom/svg-parse-overflow-4-expected.txt: Removed.
platform/chromium-linux/svg/custom/svg-parse-overflow-5-expected.txt: Removed.
platform/mac/svg/custom/svg-parse-overflow-1-expected.txt: Removed.
platform/mac/svg/custom/svg-parse-overflow-2-expected.txt: Removed.
platform/mac/svg/custom/svg-parse-overflow-3-expected.txt: Removed.
platform/mac/svg/custom/svg-parse-overflow-4-expected.txt: Removed.
platform/mac/svg/custom/svg-parse-overflow-5-expected.txt: Removed.

5:50 AM Changeset in webkit [73910] by hans@chromium.org

13 edits in branches/chromium/597

Merge 73605 - 2010-12-07 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Steve Block.

IndexedDB returns the wrong exceptions
https://bugs.webkit.org/show_bug.cgi?id=50632

storage/indexeddb/constants-expected.txt:
storage/indexeddb/constants.html:
storage/indexeddb/objectstore-removeobjectstore-expected.txt:
storage/indexeddb/objectstore-removeobjectstore.html:

2010-12-07 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Steve Block.

IndexedDB returns the wrong exceptions
https://bugs.webkit.org/show_bug.cgi?id=50632

IndexedDB exceptions need to have an offset so they can
be distinguished from DOM exceptions. We also need to
add strings for the various exceptions. Lastly, make
IDBDatabaseException use the common exception base class.

bindings/js/JSDOMBinding.cpp: (WebCore::setDOMException):
bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::setDOMException):
dom/ExceptionCode.cpp: (WebCore::getExceptionCodeDescription):
dom/ExceptionCode.h:
storage/IDBDatabaseError.h: (WebCore::IDBDatabaseError::code):
storage/IDBDatabaseException.h: (WebCore::IDBDatabaseException::create): (WebCore::IDBDatabaseException::ErrorCodeToExceptionCode): (WebCore::IDBDatabaseException::IDBDatabaseException):
storage/IDBDatabaseException.idl:

TBR=jorlow@chromium.org
Review URL: http://codereview.chromium.org/5722007

5:50 AM Changeset in webkit [73909] by loislo@chromium.org

13 edits in trunk

2010-12-13 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r73898.
http://trac.webkit.org/changeset/73898
https://bugs.webkit.org/show_bug.cgi?id=50919

FileSystem and Database API's were broken (Requested by loislo
on #webkit).

http/tests/inspector/debugger-test2.js: (initialize_DebuggerTest.InspectorTest.startDebuggerTest.startTest): (initialize_DebuggerTest.InspectorTest.startDebuggerTest): (initialize_DebuggerTest.InspectorTest.completeDebuggerTest.disableDebugger): (initialize_DebuggerTest.InspectorTest.showScriptSource):

2010-12-13 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r73898.
http://trac.webkit.org/changeset/73898
https://bugs.webkit.org/show_bug.cgi?id=50919

FileSystem and Database API's were broken (Requested by loislo
on #webkit).

inspector/Inspector.idl:
inspector/InspectorDebuggerAgent.cpp: (WebCore::InspectorDebuggerAgent::didParseSource):
inspector/InspectorProfilerAgent.cpp: (WebCore::InspectorProfilerAgent::resetState):
inspector/front-end/DOMAgent.js:
inspector/front-end/DebuggerModel.js: (WebInspector.DebuggerModel): (WebInspector.DebuggerModel.prototype.debuggerPaused): (WebInspector.DebuggerModel.prototype.debuggerResumed):
inspector/front-end/ProfilesPanel.js: (WebInspector.ProfilesPanel): (WebInspector.ProfilesPanel.prototype.updateMainViewWidth):
inspector/front-end/ResourceManager.js: (WebInspector.ResourceManager): (WebInspector.ResourceManager.prototype._registerNotifyHandlers): (WebInspector.ResourceManager.prototype._unbindResourceURL):
inspector/front-end/inspector.js: (WebInspector.addDatabase): (WebInspector.addDOMStorage): (WebInspector.updateDOMStorage): (WebInspector.updateApplicationCacheStatus): (WebInspector.didGetFileSystemPath): (WebInspector.didGetFileSystemError): (WebInspector.didGetFileSystemDisabled): (WebInspector.updateNetworkState): (WebInspector.attachDebuggerWhenShown): (WebInspector.debuggerWasEnabled): (WebInspector.debuggerWasDisabled): (WebInspector.profilerWasEnabled): (WebInspector.profilerWasDisabled): (WebInspector.parsedScriptSource): (WebInspector.restoredBreakpoint): (WebInspector.failedToParseScriptSource): (WebInspector.pausedScript): (WebInspector.resumedScript): (WebInspector.resetProfilesPanel): (WebInspector.didCommitLoad): (WebInspector.addProfileHeader): (WebInspector.setRecordingProfile): (WebInspector.addHeapSnapshotChunk): (WebInspector.finishHeapSnapshot):

2010-12-13 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r73898.
http://trac.webkit.org/changeset/73898
https://bugs.webkit.org/show_bug.cgi?id=50919

FileSystem and Database API's were broken (Requested by loislo
on #webkit).

src/js/Tests.js: (.TestSuite.prototype._waitForScriptPause):

5:46 AM Changeset in webkit [73908] by Patrick Gansterer

2 edits in trunk/WebKitTools

2010-12-13 Patrick Gansterer <Patrick Gansterer>

Reviewed by Csaba Osztrogonác.

Add revlink to BuildBot status
https://bugs.webkit.org/show_bug.cgi?id=50914

This adds a hyperlink to trac changeset on the revision numbers.

BuildSlaveSupport/build.webkit.org-config/master.cfg:

5:34 AM Changeset in webkit [73907] by antonm@chromium.org

6 edits in trunk/WebCore

2010-12-13 Anton Muhin <antonm@chromium.org>

Reviewed by Pavel Feldman.

[v8] More CSS wrappers GC work: keep document's style sheets, style sheet and css rule lists' items in proper object groups
https://bugs.webkit.org/show_bug.cgi?id=50828

bindings/v8/DOMData.h: (WebCore::DOMData::WrapperMapObjectRemover::visitDOMWrapper): (WebCore::DOMData::removeObjectsFromWrapperMap):
bindings/v8/DOMDataStore.h: (WebCore::ChunkedTable::visit): (WebCore::ChunkedTable::visitEntries): (WebCore::DOMDataStore::IntrusiveDOMWrapperMap::visit): (WebCore::DOMDataStore::IntrusiveDOMWrapperMap::ChunkedTableTraits::visit):
bindings/v8/V8DOMMap.cpp: (WebCore::removeAllDOMObjectsInCurrentThread): (WebCore::visitDOMNodesInCurrentThread): (WebCore::visitDOMObjectsInCurrentThread): (WebCore::visitActiveDOMObjectsInCurrentThread): (WebCore::visitDOMSVGElementInstancesInCurrentThread):
bindings/v8/V8DOMMap.h: (WebCore::WeakReferenceMap::visit):
bindings/v8/V8GCController.cpp: (WebCore::DOMObjectVisitor::visitDOMWrapper): (WebCore::EnsureWeakDOMNodeVisitor::visitDOMWrapper): (WebCore::GCPrologueVisitor::visitDOMWrapper): (WebCore::NodeGrouperVisitor::visitDOMWrapper): (WebCore::NodeGrouperVisitor::applyGrouping): (WebCore::DOMObjectGrouperVisitor::visitDOMWrapper): (WebCore::GCEpilogueVisitor::visitDOMWrapper):

5:27 AM Changeset in webkit [73906] by commit-queue@webkit.org

28 edits in trunk/WebKit/gtk

2010-12-13 Carlos Garcia Campos <cgarcia@igalia.com>

Reviewed by Xan Lopez.

[GTK] Do not use GET_PRIVATE macros
https://bugs.webkit.org/show_bug.cgi?id=50915

GET_PRIVATE macros are slow and should only be used in the object
init() method.

WebCoreSupport/ContextMenuClientGtk.cpp: (WebKit::inputMethodsMenuItem):
WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::postProgressFinishedNotification): (WebKit::FrameLoaderClient::setTitle): (WebKit::FrameLoaderClient::dispatchCreatePage): (WebKit::postCommitFrameViewSetup):
webkit/webkitdownload.cpp: (webkit_download_init):
webkit/webkitgeolocationpolicydecision.cpp: (webkit_geolocation_policy_decision_init):
webkit/webkithittestresult.cpp: (webkit_hit_test_result_init):
webkit/webkitnetworkrequest.cpp: (webkit_network_request_init):
webkit/webkitsecurityorigin.cpp: (webkit_security_origin_init):
webkit/webkitsecurityoriginprivate.h:
webkit/webkitviewportattributes.cpp: (webkit_viewport_attributes_init):
webkit/webkitwebbackforwardlist.cpp: (webkit_web_back_forward_list_init):
webkit/webkitwebdatabase.cpp: (webkit_web_database_init):
webkit/webkitwebdatasource.cpp: (webkit_web_data_source_init):
webkit/webkitwebframe.cpp: (webkit_web_frame_init): (webkit_web_frame_new):
webkit/webkitwebframeprivate.h:
webkit/webkitwebhistoryitem.cpp: (webkit_web_history_item_init):
webkit/webkitwebinspector.cpp: (webkit_web_inspector_init):
webkit/webkitwebnavigationaction.cpp: (webkit_web_navigation_action_init):
webkit/webkitwebplugin.cpp: (webkit_web_plugin_init):
webkit/webkitwebplugindatabase.cpp: (webkit_web_plugin_database_init):
webkit/webkitwebplugindatabaseprivate.h:
webkit/webkitwebpluginprivate.h:
webkit/webkitwebpolicydecision.cpp: (webkit_web_policy_decision_init):
webkit/webkitwebresource.cpp: (webkit_web_resource_init):
webkit/webkitwebresourceprivate.h:
webkit/webkitwebsettings.cpp: (webkit_web_settings_init):
webkit/webkitwebview.cpp: (PopupMenuPositionFunc): (webkit_web_view_forward_context_menu_event): (webkit_web_view_drag_end): (webkit_web_view_drag_data_get): (webkit_web_view_query_tooltip): (webkit_web_view_init):
webkit/webkitwebwindowfeatures.cpp: (webkit_web_window_features_init):

5:16 AM Changeset in webkit [73905] by abecsi@webkit.org

8 edits
1 move
1 add in trunk

2010-12-13 Andras Becsi <abecsi@webkit.org>

Reviewed by Csaba Osztrogonác.

[Qt][WK2] Fix build if WebKitTools are not available
https://bugs.webkit.org/show_bug.cgi?id=50242

DerivedSources.pro: add new DerivedSources.pro to SUBDIRS.

2010-12-13 Andras Becsi <abecsi@webkit.org>

Reviewed by Csaba Osztrogonác.

[Qt][WK2] Fix build if WebKitTools are not available
https://bugs.webkit.org/show_bug.cgi?id=50242

DerivedSources.pro: Remove dependency to WebKitTools.
Scripts/generate-forwarding-headers.pl: Moved from WebKitTools/Scripts/generate-forwarding-headers.pl.

2010-12-13 Andras Becsi <abecsi@webkit.org>

Reviewed by Csaba Osztrogonác.

[Qt][WK2] Fix build if WebKitTools are not available
https://bugs.webkit.org/show_bug.cgi?id=50242

MiniBrowser/qt/MiniBrowser.pro: Correct the comment.
Scripts/webkitdirs.pm: Added WebKitTools/MiniBrowser to $subdirs.
MiniBrowser/DerivedSources.pro: Added.

5:13 AM Changeset in webkit [73904] by zherczeg@webkit.org

2 edits in trunk/WebCore

Unreviewed build fix for r73894.

SVGFEImage should also check its hasResult() in its apply().

svg/graphics/filters/SVGFEImage.cpp:

(WebCore::FEImage::apply):

4:55 AM Changeset in webkit [73903] by abecsi@webkit.org

3 edits in trunk/JavaScriptCore

2010-12-13 Peter Varga <pvarga@inf.u-szeged.hu>

Reviewed by Gavin Barraclough.

Reduce the size of the RegexStackSpaceForBackTrackInfoParentheses in YARR
https://bugs.webkit.org/show_bug.cgi?id=49385

Remove the BackTrackInfoParentheses struct prevBegin and prevEnd members.

yarr/RegexInterpreter.cpp: (JSC::Yarr::Interpreter::matchParentheses): (JSC::Yarr::Interpreter::backtrackParentheses):
yarr/RegexPattern.h:

4:25 AM Changeset in webkit [73902] by hans@chromium.org

16 edits in branches/chromium/597

Merge 73697 - 2010-12-10 Hans Wennborg <hans@chromium.org>

Reviewed by Jeremy Orlow.

IndexedDB: Numeric keys are floats.
https://bugs.webkit.org/show_bug.cgi?id=50674

Update layout tests to use floating-point values for keys.

storage/indexeddb/keyrange-expected.txt:
storage/indexeddb/keyrange.html: Make sure creating the keys works.
storage/indexeddb/objectstore-cursor-expected.txt:
storage/indexeddb/objectstore-cursor.html: Make sure retrieving the keys from the DB objectstore works.

2010-12-10 Hans Wennborg <hans@chromium.org>

Reviewed by Jeremy Orlow.

IndexedDB: Numeric keys are floats.
https://bugs.webkit.org/show_bug.cgi?id=50674

Use floating point to represent numeric keys,
add version meta data to the SQLite db,
and migrate object stores that use integers.

bindings/v8/IDBBindingUtilities.cpp: (WebCore::createIDBKeyFromValue):
bindings/v8/custom/V8IDBKeyCustom.cpp: (WebCore::toV8):
storage/IDBFactoryBackendImpl.cpp: (WebCore::createTables): (WebCore::migrateDatabase): (WebCore::IDBFactoryBackendImpl::open):
storage/IDBKey.cpp: (WebCore::IDBKey::IDBKey): (WebCore::IDBKey::fromQuery): (WebCore::IDBKey::bind): (WebCore::IDBKey::bindWithNulls):
storage/IDBKey.h: (WebCore::IDBKey::create): (WebCore::IDBKey::number):

2010-12-10 Hans Wennborg <hans@chromium.org>

Reviewed by Jeremy Orlow.

IndexedDB: Numeric keys are floats.
https://bugs.webkit.org/show_bug.cgi?id=50674

Represent numeric keys as floating point values.

public/WebIDBKey.h: (WebKit::WebIDBKey::WebIDBKey):
src/WebIDBKey.cpp: (WebKit::WebIDBKey::assign): (WebKit::WebIDBKey::number):

TBR=hans@chromium.org
Review URL: http://codereview.chromium.org/5800002

4:11 AM Changeset in webkit [73901] by Csaba Osztrogonác

2 edits in trunk/LayoutTests

Unreviewed.

[Qt] fast/loader/user-stylesheet-fast-path.html fails
https://bugs.webkit.org/show_bug.cgi?id=50911

platform/qt/Skipped: Add the failing test until fix.

3:54 AM Changeset in webkit [73900] by pfeldman@chromium.org

2 edits in trunk/LayoutTests

2010-12-13 Pavel Feldman <pfeldman@chromium.org>

Not reviewed. Updated chromium gpu test expectations.

platform/chromium-gpu/test_expectations.txt:

3:38 AM Changeset in webkit [73899] by pfeldman@chromium.org

2 edits in trunk/LayoutTests

2010-12-13 Pavel Feldman <pfeldman@chromium.org>

Not reviewed. Updated chromium test expectations.

platform/chromium/test_expectations.txt:

3:21 AM Changeset in webkit [73898] by loislo@chromium.org

13 edits in trunk

2010-12-13 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: Protocol cleanup task. Assign domain attribute to Resources and Debugger specific functions.

Debugger and Resources related notification functions of Inspector.idl were
marked as such with help of "domain" attribute. The other changes in js files
are reflecting this change. Some wrappers in WebInspector namespace were dropped,
the others were moved to DebuggerModel class.

https://bugs.webkit.org/show_bug.cgi?id=50906

inspector/Inspector.idl:
inspector/InspectorDebuggerAgent.cpp: (WebCore::InspectorDebuggerAgent::didParseSource):
inspector/InspectorProfilerAgent.cpp: (WebCore::InspectorProfilerAgent::resetState):
inspector/front-end/DOMAgent.js: (WebInspector.DOMAgent.prototype.didCommitLoad):
inspector/front-end/DebuggerModel.js: (WebInspector.DebuggerModel): (WebInspector.DebuggerModel.prototype.pausedScript): (WebInspector.DebuggerModel.prototype.resumedScript): (WebInspector.DebuggerModel.prototype.attachDebuggerWhenShown): (WebInspector.DebuggerModel.prototype.debuggerWasEnabled): (WebInspector.DebuggerModel.prototype.debuggerWasDisabled): (WebInspector.DebuggerModel.prototype.parsedScriptSource): (WebInspector.DebuggerModel.prototype.failedToParseScriptSource):
inspector/front-end/ProfilesPanel.js: (WebInspector.ProfilesPanel): (WebInspector.ProfilesPanel.prototype.addHeapSnapshots): (WebInspector.ProfilesPanel.prototype.updateMainViewWidth): (WebInspector.ProfilesPanel.prototype.setRecordingProfile):
inspector/front-end/ResourceManager.js: (WebInspector.ResourceManager): (WebInspector.ResourceManager.prototype._unbindResourceURL): (WebInspector.ResourceManager.prototype.updateDOMStorage): (WebInspector.ResourceManager.prototype.updateApplicationCacheStatus): (WebInspector.ResourceManager.prototype.didGetFileSystemPath): (WebInspector.ResourceManager.prototype.didGetFileSystemError): (WebInspector.ResourceManager.prototype.didGetFileSystemDisabled): (WebInspector.ResourceManager.prototype.updateNetworkState): (WebInspector.ResourceManager.prototype.addDatabase): (WebInspector.ResourceManager.prototype.addDOMStorage):
inspector/front-end/inspector.js:

2010-12-13 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: Protocol cleanup task. Assign domain attribute to Resources and Debugger specific functions.

Debugger and Resources related notification functions of Inspector.idl were
marked as such with help of "domain" attribute. The other changes in js files
are reflecting this change. Some wrappers in WebInspector namespace were dropped,
the others were moved to DebuggerModel class.

https://bugs.webkit.org/show_bug.cgi?id=50906

src/js/Tests.js: (.TestSuite.prototype._waitForScriptPause):

2010-12-13 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: Protocol cleanup task. Assign domain attribute to Resources and Debugger specific functions.

Debugger and Resources related notification functions of Inspector.idl were
marked as such with help of "domain" attribute. The other changes in js files
are reflecting this change. Some wrappers in WebInspector namespace were dropped,
the others were moved to DebuggerModel class.

https://bugs.webkit.org/show_bug.cgi?id=50906

http/tests/inspector/debugger-test2.js: (initialize_DebuggerTest.InspectorTest.startDebuggerTest.startTest): (initialize_DebuggerTest.InspectorTest.startDebuggerTest): (initialize_DebuggerTest.InspectorTest.completeDebuggerTest.disableDebugger): (initialize_DebuggerTest.InspectorTest.showScriptSource):
platform/chromium/test_expectations.txt:

3:14 AM Changeset in webkit [73897] by pfeldman@chromium.org

2 edits in trunk/LayoutTests

2010-12-13 Pavel Feldman <pfeldman@chromium.org>

Not reviewed. Updated chromium test expectations.

platform/chromium/test_expectations.txt:

2:59 AM Changeset in webkit [73896] by pfeldman@chromium.org

2 edits in trunk/LayoutTests

2010-12-13 Pavel Feldman <pfeldman@chromium.org>

Not reviewed. Updated chromium test expectations.

platform/chromium/test_expectations.txt:

2:19 AM Changeset in webkit [73895] by eric@webkit.org

2 edits
1 delete in trunk/WebKitTools

2010-12-13 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

EWS Queues should remove orpahned pyc files before starting
https://bugs.webkit.org/show_bug.cgi?id=50904

A previous check added a platform.py which caused
EWS bots on some platforms to hit an import exception.
The platform.py file was removed in a subsequent commit, but
the EWS bots in question stayed stuck. This change will
fix those bots once restarted (and prevent this in the future).

I also went ahead and unified start-queue and start-commit-queue
since they were nearly identical. I also added bot_id support
to both force all EWSes to have bot ids as well as get rid of the one
remaining reason why I had my own copies of these scripts.
Hopefully this will be enough to get all the other bot admins
(ahem, Adam, ahem) to move to using these checked in copies as well.

EWSTools/start-commit-queue.sh: Removed.
EWSTools/start-queue.sh:

2:15 AM Changeset in webkit [73894] by zherczeg@webkit.org

23 edits
1 add in trunk/WebCore

Better result passing in filter primitives
https://bugs.webkit.org/show_bug.cgi?id=49907

Reviewed by Dirk Schulze.

SVG filter primitives can use the output of other filters. The
input and output format of a filter can be a premultiplied or
unmultiplied RGBA array, or an image buffer. All filter
primitive results were converted to image buffers before, which
could be an unecessary (and really costly) operation, if
a filter expects its input in the same format as the output
of the input filter primitive. This overhead is removed by
this patch. All apply() methods are updated according to this
new filter primitive interface.

Filters do not generate their results twice (or more) anymore,
when their apply() called multiple times.

The existing tests cover this feature.

manual-tests/svg-filter-animation.svg: Added.
platform/graphics/filters/FEBlend.cpp:

(WebCore::FEBlend::apply):

platform/graphics/filters/FEColorMatrix.cpp:

(WebCore::FEColorMatrix::apply):

platform/graphics/filters/FEComponentTransfer.cpp:

(WebCore::FEComponentTransfer::apply):

platform/graphics/filters/FEComposite.cpp:

(WebCore::FEComposite::apply):

platform/graphics/filters/FEConvolveMatrix.cpp:

(WebCore::FEConvolveMatrix::apply):

platform/graphics/filters/FEDisplacementMap.cpp:

(WebCore::FEDisplacementMap::apply):

platform/graphics/filters/FEFlood.cpp:

(WebCore::FEFlood::apply):

platform/graphics/filters/FEGaussianBlur.cpp:

(WebCore::FEGaussianBlur::apply):

platform/graphics/filters/FELighting.cpp:

(WebCore::FELighting::apply):

platform/graphics/filters/FEMerge.cpp:

(WebCore::FEMerge::apply):

platform/graphics/filters/FEMerge.h:
platform/graphics/filters/FEMorphology.cpp:

(WebCore::FEMorphology::apply):

platform/graphics/filters/FEOffset.cpp:

(WebCore::FEOffset::apply):

platform/graphics/filters/FETile.cpp:

(WebCore::FETile::apply):

platform/graphics/filters/FETurbulence.cpp:

(WebCore::FETurbulence::apply):

platform/graphics/filters/FilterEffect.cpp:

(WebCore::FilterEffect::requestedRegionOfInputImageData):
(WebCore::FilterEffect::asImageBuffer):
(WebCore::FilterEffect::asUnmultipliedImage):
(WebCore::FilterEffect::asPremultipliedImage):
(WebCore::FilterEffect::copyImageBytes):
(WebCore::FilterEffect::copyUnmultipliedImage):
(WebCore::FilterEffect::copyPremultipliedImage):
(WebCore::FilterEffect::createImageBufferResult):
(WebCore::FilterEffect::createUnmultipliedImageResult):
(WebCore::FilterEffect::createPremultipliedImageResult):

platform/graphics/filters/FilterEffect.h:

(WebCore::FilterEffect::hasResult):

platform/graphics/filters/SourceAlpha.cpp:

(WebCore::SourceAlpha::apply):

platform/graphics/filters/SourceGraphic.cpp:

(WebCore::SourceGraphic::apply):

platform/graphics/filters/SourceGraphic.h:
rendering/RenderSVGResourceFilter.cpp:

(WebCore::RenderSVGResourceFilter::postApplyResource):

svg/graphics/filters/SVGFEImage.cpp:

(WebCore::FEImage::apply):

2:00 AM Changeset in webkit [73893] by Patrick Gansterer

1 edit
2 moves in trunk/LayoutTests

2010-12-13 Patrick Gansterer <Patrick Gansterer>

Reviewed by Eric Seidel.

Move user stylesheet test into platform independent directory
https://bugs.webkit.org/show_bug.cgi?id=47335

There is nothing platform specific in the test, so move it out of the mac directory.

fast/loader/user-stylesheet-fast-path-expected.txt: Copied from LayoutTests/platform/mac/fast/loader/user-stylesheet-fast-path-expected.txt.
fast/loader/user-stylesheet-fast-path.html: Copied from LayoutTests/platform/mac/fast/loader/user-stylesheet-fast-path.html.
platform/mac/fast/loader/user-stylesheet-fast-path-expected.txt: Removed.
platform/mac/fast/loader/user-stylesheet-fast-path.html: Removed.

1:50 AM Changeset in webkit [73892] by Csaba Osztrogonác

4 edits in trunk

Unreviewed.

WebCore:

WebCore.pro: Remove non-existant loader/Request.h from build system.

WebKit2:

WebKit2.pro: Remove non-existant Shared/DrawingAreaBase.h from build system.

1:39 AM Changeset in webkit [73891] by morrita@google.com

2 edits in trunk/LayoutTests

2010-12-13 MORITA Hajime <morrita@google.com>

Unreviewed expectation update.

platform/chromium/test_expectations.txt:

1:11 AM Changeset in webkit [73890] by commit-queue@webkit.org

2 edits in trunk/WebCore

2010-12-13 Noel Gordon <noel.gordon@gmail.com>

Reviewed by Eric Seidel.

[chromium] Reduce canvas.toDataURL("image/jpeg") run-time cost by 10%
https://bugs.webkit.org/show_bug.cgi?id=50804

Follow on from r73173, unroll the SkUnPreMultiply::PMColorToColor() call
viz., compute the unpremultiplatcion in-place. This reduces the run-time
cost of jpeg encoding by 10-15% for my image test set.

No new tests: canvas.toDataURL() is covered by existing tests.

platform/image-encoders/skia/JPEGImageEncoder.cpp: (WebCore::preMultipliedBGRAtoRGB):

12:56 AM Changeset in webkit [73889] by commit-queue@webkit.org

3 edits
3 adds in trunk

2010-12-13 Helder Correia <helder@sencha.com>

Reviewed by Eric Seidel.

[Qt] StillImage::draw() should use ContextShadow
https://bugs.webkit.org/show_bug.cgi?id=50849

The branch that checks for a shadow requirement in StillImage::draw()
is executed when drawing a canvas onto a canvas with
ctx1.drawImage(canvas2, x, y). The current implementation supports
solid shadows only. And if transformations are present, the offset gets
transformed as well. Thus, ContextShadow must be used instead in order
to support blur and correct offset transformations.

fast/canvas/canvas-draw-canvas-on-canvas-shadow-expected.txt: Added.
fast/canvas/canvas-draw-canvas-on-canvas-shadow.html: Added.
fast/canvas/script-tests/canvas-draw-canvas-on-canvas-shadow.js: Added.

2010-12-13 Helder Correia <helder@sencha.com>

Reviewed by Eric Seidel.

[Qt] StillImage::draw() should use ContextShadow
https://bugs.webkit.org/show_bug.cgi?id=50849

The branch that checks for a shadow requirement in StillImage::draw()
is executed when drawing a canvas onto a canvas with
ctx1.drawImage(canvas2, x, y). The current implementation supports
solid shadows only. And if transformations are present, the offset gets
transformed as well. Thus, ContextShadow must be used instead in order
to support blur and correct offset transformations.

Context Navigation

Timeline

Dec 17, 2010:

Dec 16, 2010:

Dec 15, 2010:

Dec 14, 2010:

Dec 13, 2010:

Download in other formats: