Timeline
Apr 27, 2011:
- 11:56 PM Changeset in webkit [85169] by
-
- 2 edits in trunk/Source/WebCore
2011-04-27 Adam Barth <abarth@webkit.org>
Reviewed by Maciej Stachowiak.
Fix OwnPtr issues in IndexedDB
https://bugs.webkit.org/show_bug.cgi?id=59656
This patch is an attempt to fix the clang build. Clang can't seem to
cope with OwnPtrs to classes declared in an anonymous namespace because
OwnPtr's copy constructor isn't defined (but would need to be defined
in this translation unit).
- platform/leveldb/LevelDBDatabase.cpp:
- 11:46 PM Changeset in webkit [85168] by
-
- 5 edits in trunk/Source/WebCore
2011-04-27 Ryuan Choi <ryuan.choi@samsung.com>
Reviewed by Antonio Gomes.
[EFL] Change cursor to LAZY_NATIVE_CURSOR
https://bugs.webkit.org/show_bug.cgi?id=59411
Enable LAZY_NATIVE_CURSOR on EFL build.
No test added because functionality is unchanged.
- CMakeListsEfl.txt: Add Cursor.cpp
- platform/Cursor.h: (WebCore::Cursor::Cursor):
- platform/efl/CursorEfl.cpp: (WebCore::Cursor::Cursor): (WebCore::Cursor::~Cursor): (WebCore::getCursorString): (WebCore::Cursor::ensurePlatformCursor):
- platform/efl/WidgetEfl.cpp: (WebCore::Widget::setCursor):
- 11:35 PM Changeset in webkit [85167] by
-
- 2 edits in trunk/Source/JavaScriptCore
2011-04-27 Adam Barth <abarth@webkit.org>
Reviewed by David Levin.
Enable strict OwnPtrs for Chromium
https://bugs.webkit.org/show_bug.cgi?id=59666
- wtf/OwnPtr.h:
- 11:23 PM Changeset in webkit [85166] by
-
- 2 edits in trunk/Source/WebCore
2011-04-27 Adam Barth <abarth@webkit.org>
Build fix from the future. Another trival strict OwnPtr fixes. This
is the last futuristic build fix I can detect with my time traveling
abilities.
- platform/graphics/chromium/TransparencyWin.cpp: (WebCore::TransparencyWin::initializeNewContext):
- 11:21 PM Changeset in webkit [85165] by
-
- 20 edits in trunk/Source
2011-04-27 Dmitry Lomov <dslomov@google.com>
Reviewed by David Levin.
CrossThreadCopier should not have a default specialization for raw pointers
https://bugs.webkit.org/show_bug.cgi?id=59234
Removed the ablity to pass raw pointers cross-thread
Added and applied annotations for doing that
- fileapi/FileReader.cpp: (WebCore::FileReader::readInternal): (WebCore::FileReader::abort):
- fileapi/FileStreamProxy.cpp: (WebCore::FileStreamProxy::startOnFileThread): (WebCore::FileStreamProxy::stopOnFileThread): (WebCore::FileStreamProxy::getSize): (WebCore::FileStreamProxy::getSizeOnFileThread): (WebCore::FileStreamProxy::openForRead): (WebCore::FileStreamProxy::openForReadOnFileThread): (WebCore::FileStreamProxy::openForWrite): (WebCore::FileStreamProxy::openForWriteOnFileThread): (WebCore::FileStreamProxy::close): (WebCore::FileStreamProxy::read): (WebCore::FileStreamProxy::readOnFileThread): (WebCore::FileStreamProxy::write): (WebCore::FileStreamProxy::writeOnFileThread): (WebCore::FileStreamProxy::truncate): (WebCore::FileStreamProxy::truncateOnFileThread):
- loader/WorkerThreadableLoader.cpp: (WebCore::WorkerThreadableLoader::MainThreadBridge::MainThreadBridge): (WebCore::WorkerThreadableLoader::MainThreadBridge::destroy): (WebCore::WorkerThreadableLoader::MainThreadBridge::cancel):
- page/GeolocationPositionCache.cpp: (WebCore::GeolocationPositionCache::triggerReadFromDatabase): (WebCore::GeolocationPositionCache::triggerWriteToDatabase):
- platform/CrossThreadCopier.h: (WebCore::AllowCrossThreadAccessWrapper::AllowCrossThreadAccessWrapper): (WebCore::AllowCrossThreadAccessWrapper::value): (WebCore::AllowCrossThreadAccess): (WebCore::AllowExtendedLifetimeWrapper::AllowExtendedLifetimeWrapper): (WebCore::AllowExtendedLifetimeWrapper::value): (WebCore::AllowExtendedLifetime):
- platform/graphics/chromium/cc/CCCompletionEvent.h:
- storage/IDBObjectStoreBackendImpl.cpp: (WebCore::IDBObjectStoreBackendImpl::get): (WebCore::IDBObjectStoreBackendImpl::put): (WebCore::IDBObjectStoreBackendImpl::deleteFunction): (WebCore::IDBObjectStoreBackendImpl::clear): (WebCore::IDBObjectStoreBackendImpl::createIndex): (WebCore::IDBObjectStoreBackendImpl::deleteIndex): (WebCore::IDBObjectStoreBackendImpl::openCursor):
- storage/SQLCallbackWrapper.h: (WebCore::SQLCallbackWrapper::clear):
- websockets/WorkerThreadableWebSocketChannel.cpp: (WebCore::WorkerThreadableWebSocketChannel::Bridge::mainThreadCreateWebSocketChannel): (WebCore::WorkerThreadableWebSocketChannel::Bridge::Bridge): (WebCore::WorkerThreadableWebSocketChannel::Bridge::connect): (WebCore::WorkerThreadableWebSocketChannel::Bridge::send): (WebCore::WorkerThreadableWebSocketChannel::Bridge::bufferedAmount): (WebCore::WorkerThreadableWebSocketChannel::Bridge::close): (WebCore::WorkerThreadableWebSocketChannel::Bridge::disconnect): (WebCore::WorkerThreadableWebSocketChannel::Bridge::suspend): (WebCore::WorkerThreadableWebSocketChannel::Bridge::resume):
- workers/WorkerMessagingProxy.cpp: (WebCore::WorkerMessagingProxy::postConsoleMessageToWorkerObject):
2011-04-27 Dmitry Lomov <dslomov@google.com>
Reviewed by David Levin.
CrossThreadCopier should not have a default specialization for raw pointers
https://bugs.webkit.org/show_bug.cgi?id=59234
Removed the ablity to pass raw pointers cross-thread
Added and applied annotations for doing that
- src/WebSharedWorkerImpl.cpp: (WebKit::WebSharedWorkerImpl::connect): (WebKit::WebSharedWorkerImpl::connectTask):
- src/WebSharedWorkerImpl.h:
- src/WebWorkerBase.cpp: (WebKit::WebWorkerBase::postMessageToWorkerObject): (WebKit::WebWorkerBase::postExceptionToWorkerObject): (WebKit::WebWorkerBase::postConsoleMessageToWorkerObject): (WebKit::WebWorkerBase::confirmMessageFromWorkerObject): (WebKit::WebWorkerBase::reportPendingActivity): (WebKit::WebWorkerBase::workerContextClosed): (WebKit::WebWorkerBase::workerContextDestroyed):
- src/WebWorkerClientImpl.cpp: (WebKit::WebWorkerClientImpl::startWorkerContext): (WebKit::WebWorkerClientImpl::terminateWorkerContext): (WebKit::WebWorkerClientImpl::postMessageToWorkerContext): (WebKit::WebWorkerClientImpl::workerObjectDestroyed): (WebKit::WebWorkerClientImpl::postMessageToWorkerObject): (WebKit::WebWorkerClientImpl::postExceptionToWorkerObject): (WebKit::WebWorkerClientImpl::postConsoleMessageToWorkerObject): (WebKit::WebWorkerClientImpl::confirmMessageFromWorkerObject): (WebKit::WebWorkerClientImpl::reportPendingActivity):
- src/WebWorkerImpl.cpp: (WebKit::WebWorkerImpl::postMessageToWorkerContext):
- src/WorkerFileSystemCallbacksBridge.cpp: (WebKit::WorkerFileSystemCallbacksBridge::postOpenFileSystemToMainThread): (WebKit::WorkerFileSystemCallbacksBridge::postMoveToMainThread): (WebKit::WorkerFileSystemCallbacksBridge::postCopyToMainThread): (WebKit::WorkerFileSystemCallbacksBridge::postRemoveToMainThread): (WebKit::WorkerFileSystemCallbacksBridge::postRemoveRecursivelyToMainThread): (WebKit::WorkerFileSystemCallbacksBridge::postReadMetadataToMainThread): (WebKit::WorkerFileSystemCallbacksBridge::postCreateFileToMainThread): (WebKit::WorkerFileSystemCallbacksBridge::postCreateDirectoryToMainThread): (WebKit::WorkerFileSystemCallbacksBridge::postFileExistsToMainThread): (WebKit::WorkerFileSystemCallbacksBridge::postDirectoryExistsToMainThread): (WebKit::WorkerFileSystemCallbacksBridge::postReadDirectoryToMainThread): (WebKit::WorkerFileSystemCallbacksBridge::didFailOnMainThread): (WebKit::WorkerFileSystemCallbacksBridge::didOpenFileSystemOnMainThread): (WebKit::WorkerFileSystemCallbacksBridge::didSucceedOnMainThread): (WebKit::WorkerFileSystemCallbacksBridge::didReadMetadataOnMainThread): (WebKit::WorkerFileSystemCallbacksBridge::didReadDirectoryOnMainThread):
- src/WorkerFileWriterCallbacksBridge.cpp: (WebKit::WorkerFileWriterCallbacksBridge::postWriteToMainThread): (WebKit::WorkerFileWriterCallbacksBridge::postTruncateToMainThread): (WebKit::WorkerFileWriterCallbacksBridge::postAbortToMainThread): (WebKit::WorkerFileWriterCallbacksBridge::didWrite): (WebKit::WorkerFileWriterCallbacksBridge::didFail): (WebKit::WorkerFileWriterCallbacksBridge::didTruncate): (WebKit::WorkerFileWriterCallbacksBridge::postInitToMainThread): (WebKit::WorkerFileWriterCallbacksBridge::dispatchTaskToMainThread): (WebKit::WorkerFileWriterCallbacksBridge::dispatchTaskToWorkerThread):
- tests/CCThreadTest.cpp: (WebCore::TEST):
- 11:16 PM Changeset in webkit [85164] by
-
- 3 edits in trunk/Source/WebCore
2011-04-27 Adam Barth <abarth@webkit.org>
Two build fixes from the future. (Trivial strict OwnPtr fixes.)
- page/Frame.cpp: (WebCore::Frame::setTiledBackingStoreEnabled):
- platform/audio/ReverbConvolver.cpp: (WebCore::ReverbConvolver::ReverbConvolver):
- 11:15 PM Changeset in webkit [85163] by
-
- 2 edits1 add7 deletes in trunk/LayoutTests
2011-04-27 Naoki Takano <takano.naoki@gmail.com>
Reviewed by Ryosuke Niwa.
Convert LayoutTests/fast/events/mouseout-dead-node.html from pixel test to text-based test
https://bugs.webkit.org/show_bug.cgi?id=59369
- fast/events/mouseout-dead-node-expected.txt: Added.
- fast/events/mouseout-dead-node.html: Change to use dumpAsText.
- platform/chromium-linux/fast/events/mouseout-dead-node-expected.png: Removed.
- platform/chromium-win/fast/events/mouseout-dead-node-expected.png: Removed.
- platform/chromium-win/fast/events/mouseout-dead-node-expected.txt: Removed.
- platform/gtk/fast/events/mouseout-dead-node-expected.txt: Removed.
- platform/mac-leopard/fast/events/mouseout-dead-node-expected.png: Removed.
- platform/mac/fast/events/mouseout-dead-node-expected.png: Removed.
- platform/mac/fast/events/mouseout-dead-node-expected.txt: Removed.
- 11:08 PM Changeset in webkit [85162] by
-
- 7 edits in trunk/Source/WebCore
2011-04-27 Adam Barth <abarth@webkit.org>
Reviewed by David Levin.
Fix five strict PassOwnPtr violations in WebCore
https://bugs.webkit.org/show_bug.cgi?id=59640
- css/MediaList.cpp: (WebCore::MediaList::deleteMedium): (WebCore::MediaList::setMediaText): (WebCore::MediaList::appendMedium):
- css/MediaQuery.h:
- dom/MessagePort.cpp: (WebCore::MessagePort::disentanglePorts): (WebCore::MessagePort::entanglePorts):
- inspector/InspectorStyleSheet.cpp: (ParsedStyleSheet::setText):
- rendering/RenderTheme.cpp: (WebCore::RenderTheme::adjustStyle): (WebCore::RenderTheme::adjustMeterStyle):
- rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::adjustMenuListStyle): (WebCore::RenderThemeMac::adjustSliderTrackStyle): (WebCore::RenderThemeMac::adjustSliderThumbStyle): (WebCore::RenderThemeMac::adjustSearchFieldStyle): (WebCore::RenderThemeMac::adjustSearchFieldCancelButtonStyle): (WebCore::RenderThemeMac::adjustSearchFieldDecorationStyle): (WebCore::RenderThemeMac::adjustSearchFieldResultsDecorationStyle): (WebCore::RenderThemeMac::adjustSearchFieldResultsButtonStyle):
- 10:59 PM Changeset in webkit [85161] by
-
- 2 edits in trunk/LayoutTests
2011-04-27 Kenneth Russell <kbr@google.com>
Chromium test failures after r85142
https://bugs.webkit.org/show_bug.cgi?id=59673
Unreviewed. Temporarily suppress test failures.
- platform/chromium/test_expectations.txt:
- 10:53 PM Changeset in webkit [85160] by
-
- 2 edits in trunk/LayoutTests
2011-04-27 Eric Seidel <eric@webkit.org>
Reviewed by Ojan Vafai.
Log more information when http/tests/xmlhttprequest/basic-auth.html fails
https://bugs.webkit.org/show_bug.cgi?id=59651
Very basic, but it's better than nothing.
- http/tests/xmlhttprequest/basic-auth.html:
- 10:49 PM Changeset in webkit [85159] by
-
- 2 edits in tags/Safari-534.31.2/Source/WebCore
Merge r85147.
- 10:49 PM Changeset in webkit [85158] by
-
- 5 edits in tags/Safari-534.31.2/Source
Versioning.
- 10:43 PM Changeset in webkit [85157] by
-
- 3 edits2 adds in trunk
2011-04-27 Chris Fleizach <Chris Fleizach>
Reviewed by Beth Dakin.
<rdar://problem/9315254> ARIA role attribute implemented incorrectly; does not support token list with fallbacks
https://bugs.webkit.org/show_bug.cgi?id=59648
- accessibility/aria-fallback-roles.html: Added.
- platform/mac/accessibility/aria-fallback-roles-expected.txt: Added.
2011-04-27 Chris Fleizach <Chris Fleizach>
Reviewed by Beth Dakin.
<rdar://problem/9315254> ARIA role attribute implemented incorrectly; does not support token list with fallbacks
https://bugs.webkit.org/show_bug.cgi?id=59648
Test: accessibility/aria-fallback-roles.html
- accessibility/AccessibilityObject.cpp: (WebCore::AccessibilityObject::ariaRoleToWebCoreRole):
- 10:41 PM Changeset in webkit [85156] by
-
- 1 copy in tags/Safari-534.31.2
New tag.
- 10:38 PM Changeset in webkit [85155] by
-
- 2 edits in trunk/Tools
2011-04-27 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
error_log.txt should include PHP errors
https://bugs.webkit.org/show_bug.cgi?id=59643
Turns out this was really easy after I finally learned
enough about PHP to do it...
I'm adding this in hopes of better tracking down
our random http failures.
- Scripts/webkitperl/httpd.pm:
- 10:19 PM Changeset in webkit [85154] by
-
- 1 edit2 adds in trunk/LayoutTests
2011-04-27 Mark Pilgrim <pilgrim@chromium.org>
Reviewed by Tony Chang.
Port Mozilla's IndexedDB tests: creating unique index and updating indexNames
https://bugs.webkit.org/show_bug.cgi?id=59631
- storage/indexeddb/mozilla/create-index-unique-expected.txt: Added.
- storage/indexeddb/mozilla/create-index-unique.html: Added.
- 10:18 PM Changeset in webkit [85153] by
-
- 4 edits in trunk/LayoutTests
2011-04-27 Mark Pilgrim <pilgrim@chromium.org>
Reviewed by Tony Chang.
Should call done() from unexpectedErrorCallback so failing IndexedDB tests don't time out
https://bugs.webkit.org/show_bug.cgi?id=59569
- storage/indexeddb/exception-in-event-aborts-expected.txt:
- storage/indexeddb/exception-in-event-aborts.html:
- storage/indexeddb/resources/shared.js: (unexpectedSuccessCallback): (unexpectedErrorCallback): (unexpectedAbortCallback): (unexpectedCompleteCallback): (unexpectedBlockedCallback):
- 10:03 PM Changeset in webkit [85152] by
-
- 1 edit2 adds in trunk/LayoutTests
2011-04-27 Mark Pilgrim <pilgrim@chromium.org>
Reviewed by Tony Chang.
Port Mozilla's IndexedDB tests: creating and deleting indexes
https://bugs.webkit.org/show_bug.cgi?id=59635
- storage/indexeddb/mozilla/remove-index-expected.txt: Added.
- storage/indexeddb/mozilla/remove-index.html: Added.
- 9:59 PM Changeset in webkit [85151] by
-
- 1 edit2 adds in trunk/LayoutTests
2011-04-27 Mark Pilgrim <pilgrim@chromium.org>
Reviewed by Tony Chang.
Port Mozilla's IndexedDB tests: get() and put() basics
https://bugs.webkit.org/show_bug.cgi?id=59468
- storage/indexeddb/mozilla: Added.
- storage/indexeddb/mozilla/put-get-values-expected.txt: Added.
- storage/indexeddb/mozilla/put-get-values.html: Added.
- 9:55 PM Changeset in webkit [85150] by
-
- 1 edit2 adds in trunk/LayoutTests
2011-04-27 Mark Pilgrim <pilgrim@chromium.org>
Reviewed by Tony Chang.
Port Mozilla's IndexedDB tests: index cursors
https://bugs.webkit.org/show_bug.cgi?id=59472
- storage/indexeddb/mozilla: Added.
- storage/indexeddb/mozilla/object-cursors-expected.txt: Added.
- storage/indexeddb/mozilla/object-cursors.html: Added.
- 9:40 PM Changeset in webkit [85149] by
-
- 1 edit2 adds in trunk/LayoutTests
2011-04-27 Mark Pilgrim <pilgrim@chromium.org>
Reviewed by Tony Chang.
Port Mozilla's IndexedDB tests: event.target.source in success callbacks
https://bugs.webkit.org/show_bug.cgi?id=59632
- storage/indexeddb/mozilla/event-source-expected.txt: Added.
- storage/indexeddb/mozilla/event-source.html: Added.
- 9:37 PM Changeset in webkit [85148] by
-
- 1 edit2 adds in trunk/LayoutTests
2011-04-27 Mark Pilgrim <pilgrim@chromium.org>
Reviewed by Tony Chang.
Port Mozilla's IndexedDB tests: event.target.result after add() and put()
https://bugs.webkit.org/show_bug.cgi?id=59634
- storage/indexeddb/mozilla/key-requirements-expected.txt: Added.
- storage/indexeddb/mozilla/key-requirements.html: Added.
- 9:32 PM Changeset in webkit [85147] by
-
- 2 edits in trunk/Source/WebCore
https://bugs.webkit.org/show_bug.cgi?id=59671
Race condition with scrollbar animations and closing a page can cause a crash in
WebCore::FrameView::setVisibleScrollerThumbRect + 15
-and corresponding-
<rdar://problem/9329253>
Reviewed by Dan Bernstein.
It is definitely possible for Page to be null here. So we should null-check it!
And we should not ASSERT.
- page/FrameView.cpp:
(WebCore::FrameView::didCompleteRubberBand):
(WebCore::FrameView::scrollbarStyleChanged):
(WebCore::FrameView::setVisibleScrollerThumbRect):
- 9:27 PM Changeset in webkit [85146] by
-
- 2 edits in trunk/Source/WebCore
2011-04-27 Ryosuke Niwa <rniwa@webkit.org>
WinCE build fix after r85143.
- platform/graphics/wince/FontWinCE.cpp: (WebCore::TextRunComponent::TextRunComponent):
- 9:11 PM Changeset in webkit [85145] by
-
- 3 edits2 adds in trunk
2011-04-27 Mark Pilgrim <pilgrim@chromium.org>
Reviewed by Tony Chang.
IndexedDB object store deleting entry should fail if key is null
https://bugs.webkit.org/show_bug.cgi?id=58614
- storage/indexeddb/mozilla: Added.
- storage/indexeddb/mozilla/key-requirements-delete-null-key-expected.txt: Added.
- storage/indexeddb/mozilla/key-requirements-delete-null-key.html: Added.
2011-04-27 Mark Pilgrim <pilgrim@chromium.org>
Reviewed by Tony Chang.
IndexedDB object store delete should fail if key is null
https://bugs.webkit.org/show_bug.cgi?id=58614
Test: storage/indexeddb/mozilla/key-requirements-delete-null-key.html
- storage/IDBObjectStoreBackendImpl.cpp: (WebCore::IDBObjectStoreBackendImpl::deleteFunction):
- 8:35 PM Changeset in webkit [85144] by
-
- 2 edits1 add7 deletes in trunk/LayoutTests
2011-04-27 Eric Carlson <eric.carlson@apple.com>
Reviewed by Dan Bernstein.
audio-no-installed-engines.html media test has unnecessary pixel results
https://bugs.webkit.org/show_bug.cgi?id=59456
Convert audio-no-installed-engines.html results from pixel to text.
- media/audio-no-installed-engines-expected.txt: Added.
- media/audio-no-installed-engines.html:
- platform/chromium-linux/media/audio-no-installed-engines-expected.png: Removed.
- platform/chromium-win/media/audio-no-installed-engines-expected.png: Removed.
- platform/chromium-win/media/audio-no-installed-engines-expected.txt: Removed.
- platform/gtk/media/audio-no-installed-engines-expected.txt: Removed.
- platform/mac-leopard/media/audio-no-installed-engines-expected.png: Removed.
- platform/mac/media/audio-no-installed-engines-expected.png: Removed.
- platform/mac/media/audio-no-installed-engines-expected.txt: Removed.
- 8:20 PM Changeset in webkit [85143] by
-
- 17 edits in trunk/Source
2011-04-27 Eric Seidel <eric@webkit.org>
Reviewed by Ryosuke Niwa.
Should have an easy way to construct starting BidiStatus for a paragraph root
https://bugs.webkit.org/show_bug.cgi?id=59226
Two places try to construct BidiStatuses for a paragraph root using copy/paste code.
I've made this a constructor for BidiStatus instead.
As part of this effort I added a direction() accessor for TextRun and got
rid of the old m_rtl bool. This is part of the generic effort in the
Bidi code to replace old bool usage with the superior TextDirection enum
(this generally makes the code cleaner).
As part of this replacement effort I found several places which were
assuming LTR (by passing rtl=false) when they probably want to use
the current text direction. I suspect that LTR vs. RTL may affect
string width in the case of ligatures. It's unclear.
This is almost entirely a mechanical change.
- html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::drawTextInternal):
- platform/graphics/GraphicsContext.cpp: (WebCore::GraphicsContext::drawBidiText):
- platform/graphics/TextRun.h: (WebCore::TextRun::TextRun): (WebCore::TextRun::direction): (WebCore::TextRun::rtl): (WebCore::TextRun::ltr): (WebCore::TextRun::setDirection):
- platform/text/BidiResolver.h: (WebCore::BidiStatus::BidiStatus):
- rendering/EllipsisBox.cpp: (WebCore::EllipsisBox::paint): (WebCore::EllipsisBox::selectionRect): (WebCore::EllipsisBox::paintSelection):
- rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::selectionRect): (WebCore::InlineTextBox::paint): (WebCore::InlineTextBox::paintSelection): (WebCore::InlineTextBox::paintCompositionBackground): (WebCore::InlineTextBox::paintSpellingOrGrammarMarker): (WebCore::InlineTextBox::paintTextMatchMarker): (WebCore::InlineTextBox::computeRectForReplacementMarker): (WebCore::InlineTextBox::offsetForPosition): (WebCore::InlineTextBox::positionForOffset):
- rendering/RenderBlockLineLayout.cpp: (WebCore::RenderBlock::determineStartPosition):
- rendering/RenderFileUploadControl.cpp: (WebCore::RenderFileUploadControl::paintObject): (WebCore::RenderFileUploadControl::computePreferredLogicalWidths):
- rendering/RenderListBox.cpp: (WebCore::RenderListBox::updateFromElement): (WebCore::RenderListBox::paintItemForeground):
- rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::getAvgCharWidth): (WebCore::RenderTextControl::paintPlaceholder):
- rendering/svg/SVGInlineTextBox.cpp: (WebCore::SVGInlineTextBox::constructTextRun):
- rendering/svg/SVGTextMetrics.cpp: (WebCore::constructTextRun):
- 8:18 PM Changeset in webkit [85142] by
-
- 10 edits6 adds in trunk
2011-04-27 Robert Hogan <robert@webkit.org>
Reviewed by Adam Barth.
Allow shadowing of history object
https://bugs.webkit.org/show_bug.cgi?id=55965
- fast/dom/Window/get-set-properties-expected.txt:
- fast/dom/Window/get-set-properties.html:
- fast/dom/Window/window-property-shadowing-expected.txt:
- fast/dom/Window/window-property-shadowing.html:
- fast/js/var-declarations-shadowing-expected.txt:
- fast/js/var-declarations-shadowing.html:
- http/tests/history/cross-origin-replace-history-object-child-expected.txt: Added.
- http/tests/history/cross-origin-replace-history-object-child.html: Added.
- http/tests/history/cross-origin-replace-history-object-expected.txt: Added.
- http/tests/history/cross-origin-replace-history-object.html: Added.
- http/tests/history/resources/cross-origin-replaces-history-object-child-iframe.html: Added.
- http/tests/history/resources/cross-origin-replaces-history-object-iframe.html: Added.
- http/tests/security/cross-frame-access-put-expected.txt: Note that a window property with the DoNotCheckDomainSecurityOnGet attribute generates two cross-origin JS warnings. Amended expected results to include the additional extra warning for the history object.
2011-04-27 Robert Hogan <robert@webkit.org>
Reviewed by Adam Barth.
Allow shadowing of history object
https://bugs.webkit.org/show_bug.cgi?id=55965
Tests: http/tests/history/cross-origin-replace-history-object-child.html
http/tests/history/cross-origin-replace-history-object.html
- page/DOMWindow.idl:
- 8:07 PM Changeset in webkit [85141] by
-
- 2 edits in trunk/LayoutTests
2011-04-27 Dirk Pranke <dpranke@chromium.org>
Unreviewed, expectations change. Fix some
Chromium Mac Leopard failures.
- platform/chromium/test_expectations.txt:
- 7:45 PM Changeset in webkit [85140] by
-
- 2 edits in trunk/LayoutTests
2011-04-27 Dirk Pranke <dpranke@chromium.org>
Unreviewed, expectations change. Fix Chromium Mac SL Debug
expectations, few miscellaneous other expectations.
- platform/chromium/test_expectations.txt:
- 7:02 PM Changeset in webkit [85139] by
-
- 1 edit2 adds in trunk/LayoutTests
2011-04-27 Mark Pilgrim <pilgrim@chromium.org>
Reviewed by Tony Chang.
Port Mozilla's IndexedDB tests: clear()
https://bugs.webkit.org/show_bug.cgi?id=59498
- storage/indexeddb/mozilla: Added.
- storage/indexeddb/mozilla/clear-expected.txt: Added.
- storage/indexeddb/mozilla/clear.html: Added.
- 6:54 PM Changeset in webkit [85138] by
-
- 3 edits in trunk/Tools
check-webkit-style should flags spacing errors for braces on the same line.
https://bugs.webkit.org/show_bug.cgi?id=59665
Reviewed by Adam Barth.
- Scripts/webkitpy/style/checkers/cpp.py: Added the check.
- Scripts/webkitpy/style/checkers/cpp_unittest.py: Added some tests for the check and fixed some test cases to not trigger this error since it isn't what they are verifying.
- 6:49 PM Changeset in webkit [85137] by
-
- 3 edits in trunk/Tools
check-webkit-style error for spaces after periods in a comment has a bad error
message and warns about end of line spaces.
https://bugs.webkit.org/show_bug.cgi?id=59663
Reviewed by Adam Barth.
- Scripts/webkitpy/style/checkers/cpp.py: Fix both issues.
- Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests for spaces at the end of line
and changed the error messages.
- 6:43 PM Changeset in webkit [85136] by
-
- 7 edits in trunk/Source
2011-04-27 James Robinson <jamesr@chromium.org>
Reviewed by Kenneth Russell.
[chromium] Ensure compositing layers are up to date before entering doComposite
https://bugs.webkit.org/show_bug.cgi?id=59159
Adds some assertions to try to catch GraphicsLayer mutations at bad times (such as during
GraphicsLayerClient::paintContents() implementations).
- platform/graphics/chromium/GraphicsLayerChromium.cpp: (WebCore::GraphicsLayerChromium::updateLayerPreserves3D):
- platform/graphics/chromium/LayerChromium.cpp: (WebCore::LayerChromium::LayerChromium): (WebCore::LayerChromium::~LayerChromium):
- platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::updateLayers):
- platform/graphics/chromium/LayerRendererChromium.h: Add a set of assertions that we aren't creating or destroying LayerChromiums during paintContents
2011-04-27 James Robinson <jamesr@chromium.org>
Reviewed by Kenneth Russell.
[chromium] Ensure compositing layers are up to date before entering doComposite
https://bugs.webkit.org/show_bug.cgi?id=59159
Explicitly update and sync the compositing layer data structures for all frames in the tree before entering the
composite operation so that lazily updated state doesn't mutate the GraphicsLayer tree while compositing.
- src/WebViewImpl.cpp: (WebKit::WebViewImpl::composite):
- 6:42 PM Changeset in webkit [85135] by
-
- 7 edits in trunk/Source
2011-04-27 James Robinson <jamesr@chromium.org>
Reviewed by Adam Barth.
Fix OwnPtr strict issues in chromium linux build
https://bugs.webkit.org/show_bug.cgi?id=59664
- platform/graphics/chromium/ComplexTextControllerLinux.cpp: (WebCore::ComplexTextController::getNormalizedTextRun):
- platform/graphics/skia/ImageBufferSkia.cpp: (WebCore::ImageBuffer::ImageBuffer):
- platform/graphics/skia/PlatformContextSkia.cpp: (WebCore::PlatformContextSkia::PlatformContextSkia):
2011-04-27 James Robinson <jamesr@chromium.org>
Reviewed by Adam Barth.
Fix OwnPtr strict issues in chromium linux build
https://bugs.webkit.org/show_bug.cgi?id=59664
- src/WebImageDecoder.cpp: (WebKit::WebImageDecoder::getFrameAtIndex):
- src/WebImageSkia.cpp: (WebKit::WebImage::fromData):
- 6:31 PM Changeset in webkit [85134] by
-
- 1 edit2 adds in trunk/LayoutTests
2011-04-27 Mark Pilgrim <pilgrim@chromium.org>
Reviewed by Tony Chang.
Port Mozilla's IndexedDB tests: add twice failure
https://bugs.webkit.org/show_bug.cgi?id=59492
- storage/indexeddb/mozilla: Added.
- storage/indexeddb/mozilla/add-twice-failure-expected.txt: Added.
- storage/indexeddb/mozilla/add-twice-failure.html: Added.
- 6:22 PM Changeset in webkit [85133] by
-
- 2 edits in trunk/Source/WebCore
2011-04-27 Chris Rogers <crogers@google.com>
Reviewed by Kenneth Russell.
Make sure to set sample-rate of created AudioBus in AudioBus::createBySampleRateConverting()
https://bugs.webkit.org/show_bug.cgi?id=59641
No new tests since audio API is not yet implemented.
- platform/audio/AudioBus.cpp: (WebCore::AudioBus::createBySampleRateConverting): (WebCore::AudioBus::createByMixingToMono):
- 6:07 PM Changeset in webkit [85132] by
-
- 2 edits in trunk/LayoutTests
2011-04-27 Kenneth Russell <kbr@google.com>
Unreviewed. Fixed more breakage in test_expectations.txt caused by
my previous checkin, caught with --lint-test-files thanks to dpranke.
- platform/chromium/test_expectations.txt:
- 6:01 PM Changeset in webkit [85131] by
-
- 2 edits in trunk/Source/WebCore
Motivated by Alexey Proskuryakov.
- bindings/scripts/CodeGeneratorJS.pm: Tried to make this comment more
informative, since it confused Alexey and me.
- 5:59 PM Changeset in webkit [85130] by
-
- 2 edits in trunk/LayoutTests
2011-04-27 Andy Estes <aestes@apple.com>
Skip fast/blockflow/broken-ideographic-font.html on Leopard.
- platform/mac-leopard/Skipped:
- 5:57 PM Changeset in webkit [85129] by
-
- 2 edits in trunk/LayoutTests
2011-04-27 Kenneth Russell <kbr@google.com>
Unreviewed, test expectation updates.
- Marked media/video-controls-transformed.html as failing generally.
- Fixed malformed bug ID in last update.
- platform/chromium/test_expectations.txt:
- 5:31 PM Changeset in webkit [85128] by
-
- 3 edits in trunk/LayoutTests
2011-04-27 Kenneth Russell <kbr@google.com>
Unreviewed, test expectation updates.
- Added a couple of flaky tests.
- Filed bugs for a preexisting and a new failure.
- Rebaselined fast/lists/003-vertical.html on Mac.
- platform/chromium-mac/fast/lists/003-vertical-expected.txt:
- platform/chromium/test_expectations.txt:
- 5:19 PM Changeset in webkit [85127] by
-
- 5 edits in trunk/Source/WebCore
2011-04-27 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Fixed a small leak related to CSSValues when deallocating a DOMWrapperWorld
https://bugs.webkit.org/show_bug.cgi?id=59646
Made the cssValueRoots map per-world, instead of a global. When we deallocate
a world, we need to clear all entries in the map for that world, since
the finalizers that would otherwise clear those entries don't run. The
simplest way to do this is just to make the world own the map.
- bindings/js/DOMWrapperWorld.h:
- bindings/js/JSCSSStyleDeclarationCustom.cpp: (WebCore::JSCSSStyleDeclaration::getPropertyCSSValue):
- bindings/js/JSCSSValueCustom.cpp: (WebCore::JSCSSValueOwner::isReachableFromOpaqueRoots): (WebCore::JSCSSValueOwner::finalize):
- bindings/js/JSDOMBinding.h:
- 5:17 PM Changeset in webkit [85126] by
-
- 2 edits in trunk/Source/WebKit/chromium
2011-04-27 Adam Barth <abarth@webkit.org>
Reviewed by David Levin.
Make GraphicsContext3DChromium play nice with strict OwnPtrs
https://bugs.webkit.org/show_bug.cgi?id=59659
Attempt #2. Hopefully this time I won't make everything crash.
- src/GraphicsContext3DChromium.cpp: (WebCore::GraphicsContext3DInternal::initialize):
- 5:05 PM Changeset in webkit [85125] by
-
- 2 edits in trunk/Tools
2011-04-27 Ojan Vafai <ojan@chromium.org>
remove assertion now that platform/mac-tiger no longer exists
https://bugs.webkit.org/show_bug.cgi?id=59660
- Scripts/webkitpy/layout_tests/port/mac_unittest.py:
- 5:04 PM Changeset in webkit [85124] by
-
- 2 edits in trunk/LayoutTests
2011-04-27 Dirk Pranke <dpranke@chromium.org>
Unreviewed, update w/ failing tests and remove a bunch of
passing mac tests.
- platform/chromium/test_expectations.txt:
- 5:00 PM Changeset in webkit [85123] by
-
- 2 edits in trunk/Tools
2011-04-27 Ojan Vafai <ojan@chromium.org>
Reviewed by Eric Seidel.
remove test that didn't make sense
https://bugs.webkit.org/show_bug.cgi?id=59658
It was artifically saying the test wasn't expected to pass,
but the expectations string was empty. The case of unexpected
passes with a real expectations string is tested later in the
same test.
- Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
- 4:52 PM Changeset in webkit [85122] by
-
- 7 edits in trunk/Source/WebCore
2011-04-27 Adam Barth <abarth@webkit.org>
Reviewed by David Levin.
Fix OwnPtr issues in IndexedDB
https://bugs.webkit.org/show_bug.cgi?id=59656
I didn't do an exhaustive review of this code, but I fixed the problems
caught by turning on strict OwnPtr and all their antecedents. This
patch is entirely tighter bookkeeping. There shouldn't be any actual
behavior change.
- platform/leveldb/LevelDBDatabase.cpp: (WebCore::LevelDBDatabase::LevelDBDatabase): (WebCore::LevelDBDatabase::open): (WebCore::LevelDBDatabase::createIterator):
- platform/leveldb/LevelDBDatabase.h:
- platform/leveldb/LevelDBIterator.cpp: (WebCore::LevelDBIterator::LevelDBIterator):
- platform/leveldb/LevelDBIterator.h:
- storage/IDBLevelDBBackingStore.cpp: (WebCore::IDBLevelDBBackingStore::IDBLevelDBBackingStore): (WebCore::IDBLevelDBBackingStore::open): (WebCore::getNewDatabaseId): (WebCore::IDBLevelDBBackingStore::getObjectStores): (WebCore::getNewObjectStoreId): (WebCore::deleteRange): (WebCore::IDBLevelDBBackingStore::nextAutoIncrementNumber): (WebCore::IDBLevelDBBackingStore::forEachObjectStoreRecord): (WebCore::IDBLevelDBBackingStore::getIndexes): (WebCore::getNewIndexId): (WebCore::findGreatestKeyLessThan): (WebCore::IDBLevelDBBackingStore::getPrimaryKeyViaIndex): (WebCore::IDBLevelDBBackingStore::keyExistsInIndex): (WebCore::findLastIndexKeyEqualTo):
- storage/IDBLevelDBBackingStore.h:
- 4:48 PM Changeset in webkit [85121] by
-
- 1 edit2 adds in trunk/LayoutTests
2011-04-27 Mark Pilgrim <pilgrim@chromium.org>
Reviewed by Tony Chang.
Port Mozilla's IndexedDB tests: bad keypath
https://bugs.webkit.org/show_bug.cgi?id=59497
- storage/indexeddb/mozilla: Added.
- storage/indexeddb/mozilla/bad-keypath-expected.txt: Added.
- storage/indexeddb/mozilla/bad-keypath.html: Added.
- 4:45 PM Changeset in webkit [85120] by
-
- 12 edits in trunk
2011-04-27 Sam Weinig <sam@webkit.org>
Reviewed by Adam Roben.
WebKit2 needs to notify the client when a plugin fails to initialize
https://bugs.webkit.org/show_bug.cgi?id=59657
Add didFailToInitializePlugin client function and call it when a plugin
fails to initialize.
- UIProcess/API/C/WKPage.h:
- UIProcess/API/qt/qwkpage.cpp: (QWKPage::QWKPage):
- UIProcess/WebLoaderClient.cpp: (WebKit::WebLoaderClient::didFailToInitializePlugin):
- UIProcess/WebLoaderClient.h:
- UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::didFailToInitializePlugin):
- UIProcess/WebPageProxy.h:
- UIProcess/WebPageProxy.messages.in:
- WebProcess/Plugins/PluginView.cpp: (WebKit::PluginView::initializePlugin):
2011-04-27 Sam Weinig <sam@webkit.org>
Reviewed by Adam Roben.
WebKit2 needs to notify the client when a plugin fails to initialize
https://bugs.webkit.org/show_bug.cgi?id=59657
- MiniBrowser/mac/BrowserWindowController.m: (-[BrowserWindowController awakeFromNib]):
- WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize): Add stubs.
- 4:17 PM Changeset in webkit [85119] by
-
- 4 edits in trunk/Tools
2011-04-26 Sam Weinig <sam@webkit.org>
Reviewed by David Levin.
Add a few more missing options to new-run-webkit-tests
https://bugs.webkit.org/show_bug.cgi?id=59567
Add support for:
--threaded
--gc-between-tests
--complex-text
- Scripts/webkitpy/layout_tests/port/webkit.py:
- Scripts/webkitpy/layout_tests/run_webkit_tests.py:
- Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
- 4:09 PM Changeset in webkit [85118] by
-
- 9 edits1 add in trunk/Source/WebCore
2011-04-19 MORITA Hajime <morrita@google.com>
Reviewed by Tony Chang.
[Refactoring] DocumentMarkerController::MarkerMapVectorPair should be replaced with a list of some class.
https://bugs.webkit.org/show_bug.cgi?id=58113
- Introduced RenderedDocumentMarker, a subclass of DocumentMarker.
- Eliminated Vector<IntRect> and move the IntRect into RenderedDocumentMarker
- Now MarkerMapVectorPair is no longer used.
No new tests, No behavior change.
- GNUmakefile.list.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- dom/DocumentMarker.h:
- dom/DocumentMarkerController.cpp: (WebCore::DocumentMarkerController::addMarker): (WebCore::DocumentMarkerController::copyMarkers): (WebCore::DocumentMarkerController::removeMarkers): (WebCore::DocumentMarkerController::markerContainingPoint): (WebCore::DocumentMarkerController::markersForNode): (WebCore::DocumentMarkerController::renderedRectsForMarkers): (WebCore::DocumentMarkerController::removeMarkersFromList): (WebCore::DocumentMarkerController::repaintMarkers): (WebCore::DocumentMarkerController::setRenderedRectForMarker): (WebCore::DocumentMarkerController::invalidateRenderedRectsForMarkersInRect): (WebCore::DocumentMarkerController::shiftMarkers): (WebCore::DocumentMarkerController::setMarkersActive): (WebCore::DocumentMarkerController::clearDescriptionOnMarkersIntersectingRange): (WebCore::DocumentMarkerController::showMarkers):
- dom/DocumentMarkerController.h:
- dom/RenderedDocumentMarker.h: Added. (WebCore::RenderedDocumentMarker::RenderedDocumentMarker): (WebCore::RenderedDocumentMarker::isRendered): (WebCore::RenderedDocumentMarker::contains): (WebCore::RenderedDocumentMarker::setRenderedRect): (WebCore::RenderedDocumentMarker::renderedRect): (WebCore::RenderedDocumentMarker::invalidate): (WebCore::RenderedDocumentMarker::invalidMarkerRect):
- 4:06 PM Changeset in webkit [85117] by
-
- 4 edits in trunk/Source/JavaScriptCore
2011-04-27 Oliver Hunt <oliver@apple.com>
Reviewed by Geoffrey Garen.
Add ability to remove keys from weakmap API
https://bugs.webkit.org/show_bug.cgi?id=59645
Add JSWeakObjectMapRemove API
- API/JSWeakObjectMapRefPrivate.cpp:
- API/JSWeakObjectMapRefPrivate.h:
- JavaScriptCore.exp:
- 4:01 PM Changeset in webkit [85116] by
-
- 7 edits in trunk/Source/WebCore
2011-04-27 James Robinson <jamesr@chromium.org>
Unreviewed, rolling out r85112.
http://trac.webkit.org/changeset/85112
https://bugs.webkit.org/show_bug.cgi?id=59159
Broke mac compile
- page/FrameView.cpp: (WebCore::FrameView::updateCompositingLayers):
- page/FrameView.h:
- platform/graphics/chromium/GraphicsLayerChromium.cpp: (WebCore::GraphicsLayerChromium::updateLayerPreserves3D):
- platform/graphics/chromium/LayerChromium.cpp: (WebCore::LayerChromium::LayerChromium): (WebCore::LayerChromium::~LayerChromium):
- platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::updateLayers):
- platform/graphics/chromium/LayerRendererChromium.h:
- 3:57 PM Changeset in webkit [85115] by
-
- 2 edits in trunk/Tools
Build fix.
Fix an OwnPtr-related issue that was missed before the strictness was turned on.
- WebKitTestRunner/TestController.cpp:
(WTR::TestController::runTest):
- 3:56 PM April 2011 Meeting/Threading edited by
- (diff)
- 3:56 PM SuccessfulPortHowTo edited by
- Fix typo; "wkdirs.pm" => "webkitdirs.pm". (diff)
- 3:53 PM Changeset in webkit [85114] by
-
- 2 edits in trunk/Source/WebCore
Build fix.
- WebCore.xcodeproj/project.pbxproj: Make RenderLayerCompositor.h accessbile to WebKit and WebKit2.
- 3:50 PM Changeset in webkit [85113] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed. Fix WinCE build. The include should be guarded inside USE(CFNETWORK).
- platform/network/ResourceHandleClient.h:
- 3:41 PM Changeset in webkit [85112] by
-
- 7 edits in trunk/Source/WebCore
2011-04-27 James Robinson <jamesr@chromium.org>
Reviewed by Kenneth Russell.
[chromium] Ensure compositing layers are up to date before entering doComposite
https://bugs.webkit.org/show_bug.cgi?id=59159
Adds some assertions to try to catch GraphicsLayer mutations at bad times (such as during
GraphicsLayerClient::paintContents() implementations).
- page/FrameView.cpp: (WebCore::FrameView::updateCompositingLayers):
Add an optional CompositingUpdateType parameter.
- page/FrameView.h:
- platform/graphics/chromium/GraphicsLayerChromium.cpp: (WebCore::GraphicsLayerChromium::updateLayerPreserves3D):
- platform/graphics/chromium/LayerChromium.cpp: (WebCore::LayerChromium::LayerChromium): (WebCore::LayerChromium::~LayerChromium):
- platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::updateLayers):
- platform/graphics/chromium/LayerRendererChromium.h: Add a set of assertions that we aren't creating or destroying LayerChromiums during paintContents
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::dirtyZOrderLists): (WebCore::RenderLayer::updateCompositingAndLayerListsIfNeeded):
- rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::updateCompositingLayers):
- rendering/RenderLayerCompositor.h: Fix a typo in CompositingUpdateType Pait->Paint
- 3:39 PM Changeset in webkit [85111] by
-
- 2 edits in trunk/Tools
2011-04-27 Ojan Vafai <ojan@chromium.org>
Forgot to upload the new times_ms.json file after splitting
it out from full_results.json.
- Scripts/webkitpy/layout_tests/layout_package/manager.py:
- 3:34 PM Changeset in webkit [85110] by
-
- 3 edits in trunk/LayoutTests
2011-04-27 Kenneth Russell <kbr@google.com>
[chromium] Rebaseline direct-image-compositing.html after r85011
https://bugs.webkit.org/show_bug.cgi?id=59624
Unreviewed. It looks like the previous image result for this
layout test was checked in from a Debug rather than Release build
and was affected by bug 58587.
- platform/chromium-gpu-linux/compositing/direct-image-compositing-expected.png:
- platform/chromium/test_expectations.txt:
- 3:31 PM Changeset in webkit [85109] by
-
- 11 edits in trunk/Source
Part of WebCore should use CFNetwork-based loader on Mac
https://bugs.webkit.org/show_bug.cgi?id=51836
Reviewed by Antti Koivisto.
Source/WebCore:
Add willCacheResponse method when using CFNetwork on Mac. Also put appropriate ifdefs around
willCacheResponse/shouldCacheResponse.
- loader/EmptyClients.h:
- loader/FrameLoaderClient.h:
- loader/ResourceLoader.h:
- loader/cf/ResourceLoaderCFNet.cpp:
- loader/mac/ResourceLoaderMac.mm:
(WebCore::ResourceLoader::willCacheResponse):
- platform/network/ResourceHandleClient.h:
(WebCore::ResourceHandleClient::willCacheResponse):
(WebCore::ResourceHandleClient::shouldCacheResponse):
- platform/network/cf/ResourceHandleCFNet.cpp:
(WebCore::willCacheResponse):
Source/WebKit2:
Add PLATFORM(WIN) ifdef around shouldCacheResponse.
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
- WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
- 3:28 PM Changeset in webkit [85108] by
-
- 2 edits in trunk/Tools
2011-04-27 Ojan Vafai <ojan@chromium.org>
Fix snafu in generating the JSON for the chromium tests.
- Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
- 3:24 PM Changeset in webkit [85107] by
-
- 2 edits in trunk/Tools
2011-04-27 Ojan Vafai <ojan@chromium.org>
Fix bad merge. This broke the chromium tests generating JSON files.
- Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
- 3:24 PM Changeset in webkit [85106] by
-
- 2 edits in trunk/LayoutTests
2011-04-27 Dirk Pranke <dpranke@chromium.org>
Unreviewed, update w/ failing tests.
- platform/chromium/test_expectations.txt:
- 3:12 PM Changeset in webkit [85105] by
-
- 2 edits in trunk/Tools
Don't look for results in a location that no longer exists.
Rubber-stamped by Geoff Garen.
- Scripts/old-run-webkit-tests:
- 3:12 PM Changeset in webkit [85104] by
-
- 2 edits2 deletes in trunk
Remove some files that are no longer relevant.
Rubber-stamped by Geoff Garen.
WebKitLibraries:
- libWebKitSystemInterfaceTiger.a: Removed.
LayoutTests:
- platform/mac-tiger: Removed.
- 3:10 PM Changeset in webkit [85103] by
-
- 2 edits in trunk/LayoutTests
[Qt][Mac] Unreviewed. Add more failing tests to the Skipped list.
- platform/qt-mac/Skipped:
- 3:06 PM Changeset in webkit [85102] by
-
- 25 edits17 adds in trunk/LayoutTests
2011-04-27 Victoria Kirst <vrk@chromium.org>
Unreviewed.
[chromium] Rebaseline and add baselines for a few media layout tests
and update test_expectations.txt.
- platform/chromium-gpu-linux/media/controls-after-reload-expected.png: Added.
- platform/chromium-gpu-linux/media/controls-strict-expected.png: Added.
- platform/chromium-gpu-linux/media/controls-styling-expected.png: Added.
- platform/chromium-gpu-linux/media/controls-without-preload-expected.png: Added.
- platform/chromium-gpu-linux/media/video-transformed-expected.png: Added.
- platform/chromium-gpu-linux/media/video-zoom-controls-expected.png: Added.
- platform/chromium-gpu-mac/media/controls-after-reload-expected.png: Added.
- platform/chromium-gpu-mac/media/controls-strict-expected.png: Added.
- platform/chromium-gpu-mac/media/controls-styling-expected.png: Added.
- platform/chromium-gpu-mac/media/controls-without-preload-expected.png: Added.
- platform/chromium-gpu-mac/media/video-transformed-expected.png: Added.
- platform/chromium-gpu-mac/media/video-zoom-controls-expected.png:
- platform/chromium-gpu-win/media/controls-after-reload-expected.png: Added.
- platform/chromium-gpu-win/media/controls-strict-expected.png: Added.
- platform/chromium-gpu-win/media/controls-styling-expected.png: Added.
- platform/chromium-gpu-win/media/controls-without-preload-expected.png: Added.
- platform/chromium-gpu-win/media/video-transformed-expected.png: Added.
- platform/chromium-gpu-win/media/video-zoom-controls-expected.png: Added.
- platform/chromium-linux/media/controls-after-reload-expected.png:
- platform/chromium-linux/media/controls-strict-expected.png:
- platform/chromium-linux/media/controls-styling-expected.png:
- platform/chromium-linux/media/controls-without-preload-expected.png:
- platform/chromium-linux/media/video-transformed-expected.png:
- platform/chromium-linux/media/video-zoom-controls-expected.png:
- platform/chromium-mac-leopard/media/controls-after-reload-expected.png:
- platform/chromium-mac-leopard/media/controls-strict-expected.png:
- platform/chromium-mac-leopard/media/controls-styling-expected.png:
- platform/chromium-mac-leopard/media/controls-without-preload-expected.png:
- platform/chromium-mac-leopard/media/video-zoom-controls-expected.png:
- platform/chromium-mac/media/controls-after-reload-expected.png:
- platform/chromium-mac/media/controls-strict-expected.png:
- platform/chromium-mac/media/controls-styling-expected.png:
- platform/chromium-mac/media/controls-without-preload-expected.png:
- platform/chromium-mac/media/video-zoom-controls-expected.png:
- platform/chromium-win/media/controls-after-reload-expected.png:
- platform/chromium-win/media/controls-strict-expected.png:
- platform/chromium-win/media/controls-styling-expected.png:
- platform/chromium-win/media/controls-without-preload-expected.png:
- platform/chromium-win/media/video-transformed-expected.png:
- platform/chromium-win/media/video-zoom-controls-expected.png:
- platform/chromium/test_expectations.txt:
- 3:00 PM Changeset in webkit [85101] by
-
- 2 edits in trunk/Source/WebCore
2011-04-27 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Brian Weinstein.
Web Inspector: Stop on Exception state does not persist.
A wrong property name was used when we persist PauseOnExceptionState property to Local Storage.
https://bugs.webkit.org/show_bug.cgi?id=59630
- inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype._debuggerWasEnabled): (WebInspector.ScriptsPanel.prototype._setPauseOnExceptions.callback): (WebInspector.ScriptsPanel.prototype._setPauseOnExceptions):
- 2:53 PM Changeset in webkit [85100] by
-
- 4 edits4 deletes in trunk
2011-04-27 Adrienne Walker <enne@google.com>
[chromium] Unreviewed, rollout r85075 (scissor rect changes)
https://bugs.webkit.org/show_bug.cgi?id=59020
- compositing/flat-with-transformed-child-expected.txt: Removed.
- compositing/flat-with-transformed-child.html: Removed.
- platform/chromium-gpu-linux/compositing/flat-with-transformed-child-expected.checksum: Removed.
- platform/chromium-gpu-linux/compositing/flat-with-transformed-child-expected.png: Removed.
- platform/chromium/test_expectations.txt:
2011-04-27 Adrienne Walker <enne@google.com>
[chromium] Unreviewed, rollout r85075 (scissor rect changes)
https://bugs.webkit.org/show_bug.cgi?id=59020
- platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::updatePropertiesAndRenderSurfaces):
- 2:50 PM Changeset in webkit [85099] by
-
- 2 edits in trunk/LayoutTests
[Qt][Mac] Unreviewed. Add more failing tests to the Skipped list.
- platform/qt-mac/Skipped:
- 2:45 PM Changeset in webkit [85098] by
-
- 1 edit in branches/chromium/742/Source/JavaScriptCore/wtf/CryptographicallyRandomNumber.cpp
Reviewed by Adam Barth.
Remove currently-spurious ASSERTs in WTF's random number generator for Chromium M12 branch
https://bugs.webkit.org/show_bug.cgi?id=59633
- 2:41 PM Changeset in webkit [85097] by
-
- 2 edits in trunk/Tools
2011-04-27 Adrienne Walker <enne@google.com>
Unreviewed, add Chrome GPU folks to contributors that I'm tired of manually CCing
- Scripts/webkitpy/common/config/committers.py:
- 2:35 PM Changeset in webkit [85096] by
-
- 2 edits in trunk/LayoutTests
[Qt][Mac] Unreviewed. Add more failing tests to the Skipped list.
- platform/qt-mac/Skipped:
- 2:27 PM Changeset in webkit [85095] by
-
- 2 edits in trunk/Tools
2011-04-22 Ojan Vafai <ojan@chromium.org>
Reviewed by Tony Chang.
only include failures in full_results.json
https://bugs.webkit.org/show_bug.cgi?id=59256
- Scripts/webkitpy/layout_tests/layout_package/manager.py:
- 2:25 PM Changeset in webkit [85094] by
-
- 22 edits in trunk/Source/WebCore
2011-04-27 Darin Adler <Darin Adler>
Reviewed by David Levin.
Fix strict OwnPtr issues seen in about 30 more files
https://bugs.webkit.org/show_bug.cgi?id=59615
- bindings/js/JSCallbackData.h: (WebCore::DeleteCallbackDataTask::create): Use adoptPtr.
- bindings/js/JSMessageEventCustom.cpp: (WebCore::JSMessageEvent::initMessageEvent): Use adoptPtr.
- css/CSSParser.cpp: (WebCore::CSSParser::updateSpecifiersWithElementName): Use OwnPtr, adoptPtr, and release.
- dom/MessageEvent.cpp: (WebCore::MessageEvent::initMessageEvent): Use OwnPtr, adoptPtr, and release.
- dom/MessagePortChannel.cpp: (WebCore::MessagePortChannel::EventData::create): Use adoptPtr.
- dom/ScriptExecutionContext.cpp: (WebCore::ProcessMessagesSoonTask::create): Use adoptPtr.
- dom/XMLDocumentParserLibxml2.cpp: (WebCore::XMLDocumentParser::doEnd): Use adoptPtr.
- dom/default/PlatformMessagePortChannel.cpp: (WebCore::MessagePortChannel::create): Use adoptPtr.
- html/HTMLFormControlElement.cpp: (WebCore::HTMLFormControlElement::detach): Use nullptr.
- inspector/InspectorAgent.cpp: (WebCore::PostWorkerNotificationToFrontendTask::create): Use adoptPtr.
- inspector/InspectorConsoleAgent.cpp: (WebCore::InspectorConsoleAgent::addMessageToConsole): Use adoptPtr. (WebCore::InspectorConsoleAgent::didReceiveResponse): Use adoptPtr. (WebCore::InspectorConsoleAgent::didFailLoading): Use adoptPtr.
- inspector/InspectorController.cpp: (WebCore::InspectorController::connectFrontend): Use adoptPtr.
- inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::didInvalidateStyleAttr): Use adoptPtr.
- inspector/InspectorResourceAgent.cpp: (WebCore::InspectorResourceAgent::InspectorResourceAgent): Use adoptPtr.
- page/FrameActionScheduler.cpp: (WebCore::FrameActionScheduler::scheduleEvent): Use adoptPtr.
- platform/graphics/ShadowBlur.cpp: (WebCore::ScratchBuffer::clearScratchBuffer): Use nullptr.
- platform/graphics/ca/GraphicsLayerCA.cpp: (WebCore::GraphicsLayer::create): Use adoptPtr. (WebCore::GraphicsLayerCA::ensureCloneLayers): Use adoptPtr. (WebCore::GraphicsLayerCA::removeCloneLayers): Use nullptr.
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::setMaxMarginBeforeValues): Use adoptPtr. (WebCore::RenderBlock::setMaxMarginAfterValues): Use adoptPtr. (WebCore::RenderBlock::setPaginationStrut): Use adoptPtr. (WebCore::RenderBlock::setPageLogicalOffset): Use adoptPtr.
- rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::destroyGraphicsLayer): Use nullptr. (WebCore::RenderLayerBacking::updateClippingLayers): Use nullptr. (WebCore::RenderLayerBacking::updateForegroundLayer): Use nullptr. (WebCore::RenderLayerBacking::updateMaskLayer): Use nullptr.
- rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::updateOverflowControlsLayers): Use nullptr. (WebCore::RenderLayerCompositor::ensureRootPlatformLayer): Use nullptr. (WebCore::RenderLayerCompositor::destroyRootPlatformLayer): Use nullptr.
- rendering/style/StyleRareNonInheritedData.cpp: (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData): Removed explicit initializations of OwnPtr members to 0. Use adoptPtr.
- workers/SharedWorkerContext.cpp: (WebCore::createConnectEvent): Use adoptPtr.
- workers/Worker.cpp: (WebCore::Worker::notifyFinished): Use nullptr.
- 2:22 PM Changeset in webkit [85093] by
-
- 2 edits in trunk/Source/WebKit/chromium
2011-04-27 Dirk Pranke <dpranke@chromium.org>
Reviewed by Darin Fisher.
remove unneeded TestWebWidget class
https://bugs.webkit.org/show_bug.cgi?id=59573
- tests/PopupMenuTest.cpp:
- 2:21 PM Changeset in webkit [85092] by
-
- 2 edits in trunk/LayoutTests
2011-04-27 Adrienne Walker <enne@google.com>
[chromium] Unreviewed, update flat-with-transformed-child expectations.
- platform/chromium/test_expectations.txt:
- 2:20 PM Changeset in webkit [85091] by
-
- 2 edits in trunk/Source/WebKit/mac
Follow-up Leopard build fix.
- Carbon/HIViewAdapter.m:
(_webkit_NSView_setNeedsDisplayInRect):
- 2:19 PM April 2011 Meeting/Threading edited by
- Added a better formatting (s/ (diff)
- 2:17 PM Changeset in webkit [85090] by
-
- 3 edits2 adds in trunk
REGRESSION (r84311): Copy should preserve background color if specified in the body only if the entire content is selected.
https://bugs.webkit.org/show_bug.cgi?id=59251
<rdar://problem/9327044>
Reviewed by Darin Adler.
Source/WebCore:
When we are looking for wrapping elements that are presentational, we should
include elements that have a non transparent background color only if they
are not blocks.
Test: editing/pasteboard/do-not-copy-body-color.html
- editing/markup.cpp:
(WebCore::isElementPresentational):
LayoutTests:
- editing/pasteboard/do-not-copy-body-color-expected.txt: Added.
- editing/pasteboard/do-not-copy-body-color.html: Added.
- 2:13 PM Unifying the build system created by
- Dumped my notes
- 2:11 PM Changeset in webkit [85089] by
-
- 4 edits in trunk/LayoutTests
2011-04-27 Ojan Vafai <ojan@chromium.org>
Reviewed by Eric Seidel.
address aesthetic concerns for results.html format brought up at webkit meeting
https://bugs.webkit.org/show_bug.cgi?id=59625
-remove background-color
-lowercase expected/actual results types to reduce overall width
-let the test name (first column) wrap
- fast/harness/resources/results-test.js:
- fast/harness/results.html:
- 2:05 PM Changeset in webkit [85088] by
-
- 2 edits in trunk/Source/WebKit2
2011-04-27 Anders Carlsson <andersca@apple.com>
Reviewed by Dan Bernstein.
Hang if a sync message handler invalidates the connection
https://bugs.webkit.org/show_bug.cgi?id=59627
If dispatching incoming messages while waiting for the sync reply caused the connection to be invalidated,
we need to return early or we'll wait forever.
- Platform/CoreIPC/Connection.cpp: (CoreIPC::Connection::waitForSyncReply):
- 2:04 PM Changeset in webkit [85087] by
-
- 7 edits in trunk/Tools
2011-04-22 Ojan Vafai <ojan@chromium.org>
Reviewed by Adam Roben.
move times into their own json file
https://bugs.webkit.org/show_bug.cgi?id=59239
The test runtimes are the only case where we need an entry for
every test that was run, including passing tests. Move them into
their own json file so we can prune the other json files to only
include failing tests.
Use a trie-like data structure to hold the tests to avoid including
full test paths. This cuts 52% of the filesize. The end result is ~700k
pre-gzip.
- Scripts/webkitpy/common/net/resultsjsonparser.py: Exclude times from the parsed TestResults.
- Scripts/webkitpy/common/net/resultsjsonparser_unittest.py:
- Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
- Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
- Scripts/webkitpy/layout_tests/layout_package/manager.py:
- 2:03 PM Changeset in webkit [85086] by
-
- 2 edits in branches/chromium/742/Source/WebCore
Merge 84732:
2011-04-27 Nate Chapin <Nate Chapin>
Reviewed by Adam Barth.
Don't use XMLTreeViewer when script is disabled (it uses Javascript
to build a prettified version of the xml document).
https://bugs.webkit.org/show_bug.cgi?id=59113
- xml/XMLTreeViewer.cpp: (WebCore::XMLTreeViewer::transformDocumentToTreeView):
- 2:01 PM Changeset in webkit [85085] by
-
- 1 edit4 adds in trunk/LayoutTests
2011-04-27 Mark Pilgrim <pilgrim@chromium.org>
Reviewed by Tony Chang.
Port Mozilla's IndexedDB tests: objectStoreNames
https://bugs.webkit.org/show_bug.cgi?id=59484
- storage/indexeddb/mozilla: Added.
- storage/indexeddb/mozilla/global-data-expected.txt: Added.
- storage/indexeddb/mozilla/global-data.html: Added.
- storage/indexeddb/mozilla/objectstorenames-expected.txt: Added.
- storage/indexeddb/mozilla/objectstorenames.html: Added.
- 1:58 PM Changeset in webkit [85084] by
-
- 2 edits in trunk/Source/JavaScriptCore
2011-04-27 Adam Barth <abarth@webkit.org>
Reviewed by David Levin.
Enable strict mode for OwnPtr
https://bugs.webkit.org/show_bug.cgi?id=59428
This patch enables strict mode for OwnPtr on PLATFORM(MAC) only.
- wtf/OwnPtr.h:
- 1:57 PM Changeset in webkit [85083] by
-
- 4 edits in trunk/Tools
More casts and more clang++ build fixes.
- DumpRenderTree/mac/DumpRenderTree.mm:
(createWebViewAndOffscreenWindow):
- TestWebKitAPI/mac/PlatformWebViewMac.mm:
(TestWebKitAPI::PlatformWebView::PlatformWebView):
- WebKitTestRunner/mac/PlatformWebViewMac.mm:
(WTR::PlatformWebView::PlatformWebView):
- 1:56 PM April 2011 Meeting edited by
- Added a "unifying the build system" page for some notes (diff)
- 1:54 PM Changeset in webkit [85082] by
-
- 3 edits in trunk/LayoutTests
2011-04-27 Dimitri Glazkov <Dimitri Glazkov>
Skip crashing/failing shadow DOM tests until they are fixed.
https://bugs.webkit.org/show_bug.cgi?id=59571
- platform/gtk/Skipped: Added failing tests.
- platform/mac/Skipped: Ditto.
- 1:50 PM April 2011 Meeting edited by
- (diff)
- 1:50 PM Changeset in webkit [85081] by
-
- 12 edits in trunk/Source/WebKit/mac
More clang++ 32-bit build fixes.
- Carbon/CarbonWindowAdapter.mm:
(-[CarbonWindowAdapter reconcileToCarbonWindowBounds]):
(-[CarbonWindowAdapter setContentView:]):
(-[CarbonWindowAdapter _handleContentBoundsChanged]):
- Carbon/HIViewAdapter.m:
(_webkit_NSView_setNeedsDisplayInRect):
- Panels/WebAuthenticationPanel.h:
- Plugins/WebBaseNetscapePluginView.mm:
(-[WebBaseNetscapePluginView convertFromX:andY:space:toX:andY:space:]):
- Plugins/WebNetscapePluginEventHandlerCarbon.mm:
(getCarbonEvent):
- WebCoreSupport/WebChromeClient.mm:
(WebChromeClient::scrollRectIntoView):
- WebCoreSupport/WebViewFactory.mm:
(-[WebViewFactory accessibilityConvertScreenRect:]):
- WebView/WebFrameView.mm:
(-[WebFrameView _scrollToBeginningOfDocument]):
(-[WebFrameView _scrollToEndOfDocument]):
- WebView/WebFullScreenController.mm:
(-[WebFullScreenController windowDidEnterFullscreen:]):
- WebView/WebHTMLView.mm:
(-[WebHTMLView _hitViewForEvent:]):
(coreGraphicsScreenPointForAppKitScreenPoint):
- WebView/WebPDFView.mm:
(-[WebPDFView setScrollPoint:]):
- 1:48 PM April 2011 Meeting/WebKit2 edited by
- Dumped my notes about WebKit2 (diff)
- 1:44 PM Changeset in webkit [85080] by
-
- 8 edits1 add in trunk/Tools
2011-04-27 Tony Chang <tony@chromium.org>
Reviewed by Ojan Vafai.
lazily autoinstall thirdparty python libraries
https://bugs.webkit.org/show_bug.cgi?id=55723
This helps by only having pywebsocket installed when the bots run. It
doesn't help much for devs since webkit-patch pulls in almost everything.
- Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
- Scripts/webkitpy/common/net/buildbot/buildbot.py:
- Scripts/webkitpy/common/net/networktransaction.py:
- Scripts/webkitpy/common/net/networktransaction_unittest.py:
- Scripts/webkitpy/common/net/statusserver.py:
- Scripts/webkitpy/layout_tests/port/websocket_server.py:
- Scripts/webkitpy/thirdparty/init.py: Add an import hook so we can install based on
the import command rather than just installing everything.
- Scripts/webkitpy/thirdparty/init_unittest.py: Added.
- 1:43 PM Changeset in webkit [85079] by
-
- 2 edits in trunk/LayoutTests
[Qt][Mac] Unreviewed. Add all failing tests to the Skipped list.
- platform/qt-mac/Skipped:
- 1:33 PM Changeset in webkit [85078] by
-
- 1 edit3 adds in trunk/LayoutTests
2011-04-27 Mark Pilgrim <pilgrim@chromium.org>
Reviewed by Tony Chang.
Port Mozilla's IndexedDB tests: createObjectStore basics
https://bugs.webkit.org/show_bug.cgi?id=59486
- storage/indexeddb/mozilla: Added.
- storage/indexeddb/mozilla/create-objectstore-basics-expected.txt: Added.
- storage/indexeddb/mozilla/create-objectstore-basics.html: Added.
- 1:32 PM Changeset in webkit [85077] by
-
- 10 edits in trunk
2011-04-16 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Antti Koivisto.
Teach sub-selector chains about shadow descendants
https://bugs.webkit.org/show_bug.cgi?id=58342
- fast/css/unknown-pseudo-element-matching-expected.txt: Updated expectations.
- fast/css/unknown-pseudo-element-matching.html: Added new tests.
2011-04-20 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Antti Koivisto.
Teach sub-selector chains about shadow descendants
https://bugs.webkit.org/show_bug.cgi?id=58342
The primary change is to the logic of parsing specifiers:
1) The shadow descendant selectors (those specifiers that are unknown
pseudo element selectors) are always kept at the top of the chain.
2) The sub-selectors after shadow descendant selectors are stashed right
behind the sub-selector, but not at the end of the chain.
3) Other sub-selectors are appended at the end of the chain.
- css/CSSGrammar.y: Changed specifier_list collection to use new
CSSParser::updateSpecifier helper.
- css/CSSParser.cpp: (WebCore::CSSParser::updateSpecifiersWithElementName): Added logic to
look for the last ShadowDescendant relation in the chain of selectors,
because the next selector after it is the one that should get the
element name.
(WebCore::CSSParser::updateSpecifiers): Moved and modified the logic from
CSSGrammar.y. The new logic adjusts the selector chain to allow
shadow descendant selectors have sub-selectors (and have multiple shadow
descendants in the chain).
- css/CSSParser.h: Added decl.
- css/CSSParserValues.cpp: (WebCore::CSSParserSelector::insertTagHistory): Added. (WebCore::CSSParserSelector::appendTagHistory): Aded.
- css/CSSParserValues.h: Added decls.
- css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector): Added
shadow descendant selector match check, since now there could be many
of them in the selector chain.
- 1:25 PM Changeset in webkit [85076] by
-
- 2 edits in trunk/Tools
2011-04-27 Girish Ramakrishnan <Girish Ramakrishnan>
Add my IRC nick.
- Scripts/webkitpy/common/config/committers.py:
- 1:21 PM Changeset in webkit [85075] by
-
- 4 edits4 adds in trunk
2011-04-20 Adrienne Walker <enne@google.com>
Reviewed by Kenneth Russell.
[chromium] Fix incorrect scissor rect for layers that render into a rendersurface
https://bugs.webkit.org/show_bug.cgi?id=59020
- compositing/flat-with-transformed-child-expected.txt: Added.
- compositing/flat-with-transformed-child.html: Added.
- platform/chromium-gpu-linux/compositing/flat-with-transformed-child-expected.checksum: Added.
- platform/chromium-gpu-linux/compositing/flat-with-transformed-child-expected.png: Added.
- platform/chromium/test_expectations.txt:
2011-04-20 Adrienne Walker <enne@google.com>
Reviewed by Kenneth Russell.
[chromium] Fix incorrect scissor rect for layers that render into a rendersurface
https://bugs.webkit.org/show_bug.cgi?id=59020
mapRect is the incorrect transform here. The parent scissor rect
needs to be projected into layer space instead.
Test: compositing/flat-with-transformed-child.html
- platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::updatePropertiesAndRenderSurfaces):
- 12:51 PM Changeset in webkit [85074] by
-
- 3 edits in trunk/LayoutTests
2011-04-27 Martin Robinson <mrobinson@igalia.com>
Rebaseline some tests which differ on the bots after r85066.
- platform/gtk/fast/forms/select-writing-direction-natural-expected.txt:
- platform/gtk/fast/text/international/bidi-menulist-expected.txt:
- 12:40 PM Changeset in webkit [85073] by
-
- 2 edits in trunk/LayoutTests
2011-04-27 Kenneth Russell <kbr@google.com>
Web Inspector: regression in inspector/console/console-dir.html after r85054
https://bugs.webkit.org/show_bug.cgi?id=59620
Unreviewed. Missed updating chromium-specific expectations in earlier rebaseline.
- platform/chromium/inspector/console/console-dir-expected.txt:
- 12:17 PM Changeset in webkit [85072] by
-
- 2 edits in trunk/LayoutTests
2011-04-27 Kenneth Russell <kbr@google.com>
[chromium] Rebaseline direct-image-compositing.html after r85011
https://bugs.webkit.org/show_bug.cgi?id=59624
- platform/chromium-gpu-win/compositing/direct-image-compositing-expected.txt:
- 11:58 AM Changeset in webkit [85071] by
-
- 5 edits1 add in trunk/Source/WebKit/chromium
2011-04-27 Tony Chang <tony@chromium.org>
Reviewed by Ojan Vafai.
[chromium] add a build target to make a zip file with the inspector debug files
https://bugs.webkit.org/show_bug.cgi?id=56656
- WebKit.gyp: Add target
- scripts/concatenate_css_files.py: Pass in a string of html rather
than a filename
- scripts/concatenate_js_files.py: Same as above
- scripts/generate_devtools_html.py: Refactor main into a helper function
- scripts/generate_devtools_zip.py: Added.
- 11:52 AM Changeset in webkit [85070] by
-
- 4 edits in trunk/Source/WebCore
Part of WebCore should use CFNetwork-based loader on Mac
https://bugs.webkit.org/show_bug.cgi?id=51836
Reviewed by Antti Koivisto.
- Configurations/WebCore.xcconfig: Add location of CFNetwork.framework.
- platform/mac/SoftLinking.h:
- platform/network/cf/CookieJarCFNet.cpp: Soft-link in CFNetwork functions on Mac.
- 11:44 AM Changeset in webkit [85069] by
-
- 2 edits in trunk/Source/WebCore
2011-04-27 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Antti Koivisto.
Cleanup CSSStyleApplyProperty.cpp
https://bugs.webkit.org/show_bug.cgi?id=59623
As first step remove ApplyPropertyColorBase, merge it with ApplyPropertyColor, there's no need for two seperated classes.
Use typedefs instead of repating the function pointer declarations in a few places.
- css/CSSStyleApplyProperty.cpp: (WebCore::ApplyPropertyDefault::ApplyPropertyDefault): (WebCore::ApplyPropertyColor::ApplyPropertyColor): (WebCore::ApplyPropertyColor::applyInheritValue): (WebCore::ApplyPropertyColor::applyInitialValue): (WebCore::ApplyPropertyColor::applyValue): (WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):
- 11:35 AM Changeset in webkit [85068] by
-
- 2 edits in trunk/Websites/webkit.org
2011-04-27 Ojan Vafai <ojan@chromium.org>
Reviewed by Dan Bernstein.
change style guide to pre-increment in for-loops
https://bugs.webkit.org/show_bug.cgi?id=59619
This matches what a number of reviewers have been asking
for in code reviews.
- coding/coding-style.html:
- 11:29 AM Changeset in webkit [85067] by
-
- 5 edits3 adds in trunk
<rdar://problem/9335973> REGRESSION (r84341): Buttons in the Mac App store are rendered incorrectly
https://bugs.webkit.org/show_bug.cgi?id=59622
Reviewed by Anders Carlsson.
Source/WebCore:
Test: fast/borders/border-image-trumps-radius.html
- rendering/RenderBox.cpp:
(WebCore::RenderBox::determineBackgroundBleedAvoidance): If there is a renderable, loaded border
image, then border radius is ignored, so no bleed avoidance is needed.
- rendering/RenderObject.cpp:
(WebCore::RenderObject::borderImageIsLoadedAndCanBeRendered): Added. Moved some logic here from...
(WebCore::RenderObject::mustRepaintBackgroundOrBorder): ...here.
- rendering/RenderObject.h:
LayoutTests:
- fast/borders/border-image-trumps-radius-expected.png: Added.
- fast/borders/border-image-trumps-radius-expected.txt: Added.
- fast/borders/border-image-trumps-radius.html: Added.
- 11:21 AM Changeset in webkit [85066] by
-
- 5 edits1 add in trunk
2011-04-27 Martin Robinson <mrobinson@igalia.com>
Reviewed by Eric Seidel.
[GTK] Menulists do not follow text direction when rendering options with right-to-left text
https://bugs.webkit.org/show_bug.cgi?id=54038
- platform/gtk/Skipped: Unskip passing test.
- platform/gtk/fast/text/international/pop-up-button-text-alignment-and-direction-expected.checksum: Added.
- platform/gtk/fast/text/international/pop-up-button-text-alignment-and-direction-expected.png: Added.
- platform/gtk/fast/text/international/pop-up-button-text-alignment-and-direction-expected.txt: Added.
2011-04-27 Martin Robinson <mrobinson@igalia.com>
Reviewed by Eric Seidel.
[GTK] Menulists do not follow text direction when rendering options with right-to-left text
https://bugs.webkit.org/show_bug.cgi?id=54038
Fix rendering of menulists that contain right-to-left text. Text direction
inside a menulist now follows the alignment of its contents.
- WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::selectItemWritingDirectionIsNatural): Return false instead of true. (WebKit::ChromeClient::selectItemAlignmentFollowsMenuWritingDirection): Return true instead of false.
- 11:16 AM Changeset in webkit [85065] by
-
- 9 edits in trunk/Tools
2011-04-27 Eric Seidel <eric@webkit.org>
Reviewed by Mihai Parparita.
sherrifbot create-bug shouldn't assign bugs to webkit.review.bot
https://bugs.webkit.org/show_bug.cgi?id=59545
To do this, I needed a way to look up contributors by irc-name
(since anyone in #webkit who might use this command may not be a committer).
To lookup contributors, I had to make Contributor a real object.
Which led me to redesign parts of committers.py...
and finally fix one spot in changelog.py where we wanted to be
looking up contributors and not committers.
Overall a pretty simple fix, once you wade through the yak-hair.
This may not prevent *all* possible ways that bugs would get assigned
to webkit.review.bot. If we don't recognize the requester we will
go through the previous code path (which shouldn't change the assignee
on the bug from the default as far as I can tell).
- Scripts/webkitpy/common/checkout/changelog.py:
- Scripts/webkitpy/common/config/committers.py:
- Scripts/webkitpy/common/config/committers_unittest.py:
- Scripts/webkitpy/tool/bot/irc_command.py:
- Scripts/webkitpy/tool/bot/irc_command_unittest.py:
- 11:15 AM Changeset in webkit [85064] by
-
- 10 edits in trunk
2011-02-03 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[GTK] editing/pasteboard/copy-standalone-image.html fails
https://bugs.webkit.org/show_bug.cgi?id=53645
Unskip the test and add new expected results for it.
- platform/gtk/Skipped: Unskip this test as it is now passing.
- platform/gtk/editing/pasteboard/copy-standalone-image-expected.checksum:
- platform/gtk/editing/pasteboard/copy-standalone-image-expected.png:
- platform/gtk/editing/pasteboard/copy-standalone-image-expected.txt:
2011-02-03 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[GTK] editing/pasteboard/copy-standalone-image.html fails
https://bugs.webkit.org/show_bug.cgi?id=53645
When writing an image to the clipboard, also write the URL and title
into the markup and URL portion. This change also abstracts a helper
imageToMarkup into markup.{cpp/h} from several different locations
throughout the platform layer.
- editing/markup.h: Added new function definition.
- editing/markup.cpp: (WebCore::imageToMarkup): Add this function which turns an image URL and element into some markup representing that image, while preserving non-src attributes.
- platform/chromium/ClipboardChromium.cpp: Move the imageToMarkup helper to markup.cpp.
- platform/gtk/PasteboardGtk.cpp: (WebCore::getURLForImageNode): Add this helper which gets the appropriate image URL for a variety of image tag types. (WebCore::Pasteboard::writeImage): Write the image URL and title to the markup and URL portions of the clipboard. This will ensure that images paste properly back into WebKit.
- platform/win/ClipboardWin.cpp: Remove the imageToMarkup helper and the one from markup.h
- 11:09 AM Changeset in webkit [85063] by
-
- 2 edits in trunk/LayoutTests
2011-04-27 Kenneth Russell <kbr@google.com>
Not reviewed. Rebaseline test to get the tree green.
Web Inspector: regression in inspector/console/console-dir.html after r85054
https://bugs.webkit.org/show_bug.cgi?id=59620
- inspector/console/console-dir-expected.txt:
- 10:55 AM Changeset in webkit [85062] by
-
- 7 edits4 adds in trunk
2011-04-27 Yi Shen <yi.4.shen@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Upstream Symbian platform plugin
https://bugs.webkit.org/show_bug.cgi?id=58435
Upstream Symbian platform plugin.
- Source/WebKit.pro: Add platformplugin path to the SUBDIRS.
2011-04-27 Yi Shen <yi.4.shen@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Upstream Symbian platform plugin
https://bugs.webkit.org/show_bug.cgi?id=58435
Exempting directory WebKit/qt/symbian/platformplugin from style guide.
- Scripts/webkitpy/style/checker.py:
- Scripts/webkitpy/style/checker_unittest.py:
2011-04-27 Yi Shen <yi.4.shen@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Upstream Symbian platform plugin
https://bugs.webkit.org/show_bug.cgi?id=58435
Upstream Symbian platform plugin.
- QtWebKit.pro: Add platformplugin.dll to the QtWebKit.sis.
- symbian/platformplugin: Added.
- symbian/platformplugin/WebPlugin.cpp: Added. (ItemListDelegate::ItemListDelegate): (ItemListDelegate::paint): (Popup::Popup): (Popup::resizeEvent): (Popup::populateList): (Popup::onItemSelected): (Popup::updateSelectionsBeforeDialogClosing): (Popup::updateAndClose): (WebPopup::WebPopup): (WebPopup::~WebPopup): (WebPopup::createSingleSelectionPopup): (WebPopup::createMultipleSelectionPopup): (WebPopup::createPopup): (WebPopup::show): (WebPopup::hide): (WebPopup::popupClosed): (WebPopup::itemClicked): (SingleSelectionPopup::SingleSelectionPopup): (MultipleSelectionPopup::MultipleSelectionPopup): (WebNotificationPresenter::showNotification): (WebPlugin::supportsExtension): (WebPlugin::createExtension):
- symbian/platformplugin/WebPlugin.h: Added. (Popup::preSelectedIndices): (Popup::listWidget): (WebNotificationPresenter::WebNotificationPresenter): (WebNotificationPresenter::~WebNotificationPresenter):
- symbian/platformplugin/platformplugin.pro: Added.
- symbian/platformplugin/qwebkitplatformplugin.h: Copied from WebKit/qt/Api/qwebkitplatformplugin.h. (QWebSelectData::~QWebSelectData): (QWebSelectMethod::~QWebSelectMethod): (QWebNotificationData::~QWebNotificationData): (QWebNotificationPresenter::QWebNotificationPresenter): (QWebNotificationPresenter::~QWebNotificationPresenter): (QWebTouchModifier::~QWebTouchModifier): (QWebFullScreenVideoHandler::QWebFullScreenVideoHandler): (QWebFullScreenVideoHandler::~QWebFullScreenVideoHandler): (QWebKitPlatformPlugin::~QWebKitPlatformPlugin):
- 10:42 AM Changeset in webkit [85061] by
-
- 4 edits in trunk
2011-04-27 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r84987.
http://trac.webkit.org/changeset/84987
https://bugs.webkit.org/show_bug.cgi?id=59618
Caused crashes on the GTK+ debug bots. (Requested by mrobinson
on #webkit).
- platform/gtk/Skipped:
2011-04-27 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r84987.
http://trac.webkit.org/changeset/84987
https://bugs.webkit.org/show_bug.cgi?id=59618
Caused crashes on the GTK+ debug bots. (Requested by mrobinson
on #webkit).
- WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::exceededDatabaseQuota):
- 10:27 AM April 2011 Meeting/Threading edited by
- Fixed the section to make it more obvious what were the topics (diff)
- 10:24 AM Changeset in webkit [85060] by
-
- 49 edits1 add in trunk/LayoutTests
2011-04-27 Levi Weintraub <leviw@chromium.org>
new baselines needed after r85011
https://bugs.webkit.org/show_bug.cgi?id=59581
- platform/chromium-linux/css2.1/t0905-c414-flt-02-c-expected.txt:
- platform/chromium-linux/css2.1/t0905-c414-flt-03-c-expected.txt:
- platform/chromium-linux/css2.1/t0905-c414-flt-04-c-expected.txt:
- platform/chromium-linux/css2.1/t0905-c5525-fltcont-00-d-g-expected.txt:
- platform/chromium-linux/css2.1/t0905-c5525-fltwidth-02-c-g-expected.txt:
- platform/chromium-linux/css2.1/t0905-c5525-fltwidth-03-c-g-expected.txt:
- platform/chromium-linux/css2.1/t090501-c414-flt-03-b-g-expected.txt:
- platform/chromium-mac-leopard/fast/repaint/box-shadow-h-expected.png:
- platform/chromium-mac-leopard/fast/repaint/box-shadow-v-expected.png:
- platform/chromium-mac/fast/inline/inline-box-background-long-image-expected.png:
- platform/chromium-mac/fast/repaint/box-shadow-v-expected.png:
- platform/chromium-win/css2.1/t0905-c414-flt-00-d-expected.txt:
- platform/chromium-win/css2.1/t0905-c414-flt-01-d-g-expected.txt:
- platform/chromium-win/css2.1/t0905-c414-flt-02-c-expected.txt:
- platform/chromium-win/css2.1/t0905-c414-flt-03-c-expected.txt:
- platform/chromium-win/css2.1/t0905-c414-flt-04-c-expected.txt:
- platform/chromium-win/css2.1/t0905-c414-flt-wrap-01-d-g-expected.txt:
- platform/chromium-win/css2.1/t0905-c5525-fltcont-00-d-g-expected.txt:
- platform/chromium-win/css2.1/t0905-c5525-fltwidth-02-c-g-expected.txt:
- platform/chromium-win/css2.1/t0905-c5525-fltwidth-03-c-g-expected.txt:
- platform/chromium-win/css2.1/t090501-c414-flt-02-d-g-expected.txt:
- platform/chromium-win/css2.1/t090501-c414-flt-03-b-g-expected.txt:
- platform/chromium-win/fast/backgrounds/background-position-parsing-expected.txt:
- platform/chromium-win/fast/block/float/029-expected.txt:
- platform/chromium-win/fast/block/float/031-expected.txt:
- platform/chromium-win/fast/block/float/clamped-right-float-expected.txt:
- platform/chromium-win/fast/block/float/float-overhangs-root-expected.png: Added.
- platform/chromium-win/fast/block/float/nested-clearance-expected.txt:
- platform/chromium-win/fast/block/margin-collapse/062-expected.txt:
- platform/chromium-win/fast/block/margin-collapse/063-expected.txt:
- platform/chromium-win/fast/box-shadow/basic-shadows-expected.txt:
- platform/chromium-win/fast/css/h1-in-section-elements-expected.txt:
- platform/chromium-win/fast/forms/basic-textareas-quirks-expected.txt:
- platform/chromium-win/fast/inline/inline-box-background-expected.txt:
- platform/chromium-win/fast/inline/inline-box-background-long-image-expected.txt:
- platform/chromium-win/fast/inline/inline-box-background-repeat-x-expected.txt:
- platform/chromium-win/fast/inline/inline-box-background-repeat-y-expected.txt:
- platform/chromium-win/fast/lists/003-expected.txt:
- platform/chromium-win/fast/lists/003-vertical-expected.txt:
- platform/chromium-win/fast/media/mq-relative-constraints-08-expected.txt:
- platform/chromium-win/fast/repaint/box-shadow-h-expected.txt:
- platform/chromium-win/fast/repaint/box-shadow-v-expected.txt:
- platform/chromium-win/fast/text/whitespace/012-expected.txt:
- platform/chromium-win/tables/mozilla/bugs/bug120364-expected.txt:
- platform/chromium-win/tables/mozilla/bugs/bug45055-2-expected.txt:
- platform/chromium-win/tables/mozilla/bugs/bug72359-expected.txt:
- platform/chromium-win/tables/mozilla/marvin/x_table_align_left-expected.txt:
- platform/chromium-win/tables/mozilla/marvin/x_table_align_right-expected.txt:
- platform/chromium/test_expectations.txt:
- 10:23 AM Changeset in webkit [85059] by
-
- 3 edits2 moves1 add in trunk/Source/WebKit2
2011-04-27 Carlos Garcia Campos <cgarcia@igalia.com>
Reviewed by Martin Robinson.
[GTK] Move WebViewWidget to UIProcess/API/gtk
https://bugs.webkit.org/show_bug.cgi?id=59594
API files should be under the API directory. This view widget will
be used by both C and gtk high level API, so it has been renamed
to WebKitWebViewBase.
- GNUmakefile.am:
- UIProcess/API/gtk/WebKitWebViewBase.cpp: Renamed from Source/WebKit2/UIProcess/gtk/WebViewWidget.cpp. (webkitWebViewBaseRealize): (webkitWebViewBaseContainerAdd): (webkitWebViewBaseDispose): (webkitWebViewBaseInit): (webViewExpose): (webViewDraw): (webViewSizeAllocate): (webViewFocusInEvent): (webViewFocusOutEvent): (webViewKeyPressEvent): (webViewKeyReleaseEvent): (getEventTime): (webViewButtonPressEvent): (webViewButtonReleaseEvent): (webViewScrollEvent): (webViewMotionNotifyEvent): (webkitWebViewBaseClassInit): (webkitWebViewBaseGetType): (webkitWebViewBaseGetWebViewInstance): (webkitWebViewBaseSetWebViewInstance): (webkitWebViewBaseGetIMContext):
- UIProcess/API/gtk/WebKitWebViewBase.h: Renamed from Source/WebKit2/UIProcess/gtk/WebViewWidget.h.
- UIProcess/gtk/WebView.cpp: (WebKit::WebView::WebView):
- 9:50 AM Changeset in webkit [85058] by
-
- 3 edits9 deletes in trunk
2011-04-27 Steve Block <steveblock@google.com>
Reviewed by David Levin.
Remove Android build system
https://bugs.webkit.org/show_bug.cgi?id=48111
This is to avoid the maintenance burden until the Android port is
fully upstreamed.
- Source/Android.mk: Removed.
2011-04-27 Steve Block <steveblock@google.com>
Reviewed by David Levin.
Remove Android build system
https://bugs.webkit.org/show_bug.cgi?id=48111
This is to avoid the maintenance burden until the Android port is
fully upstreamed.
- Android.mk: Removed.
- Android.v8.wtf.mk: Removed.
2011-04-27 Steve Block <steveblock@google.com>
Reviewed by David Levin.
Remove Android build system
https://bugs.webkit.org/show_bug.cgi?id=48111
This is to avoid the maintenance burden until the Android port is
fully upstreamed.
No new tests, build change only.
- Android.derived.jscbindings.mk: Removed.
- Android.derived.mk: Removed.
- Android.derived.v8bindings.mk: Removed.
- Android.jscbindings.mk: Removed.
- Android.mk: Removed.
- Android.v8bindings.mk: Removed.
- 9:47 AM Changeset in webkit [85057] by
-
- 1 edit5 deletes in trunk/LayoutTests
- platform/chromium-mac/fast/block/positioning/rtl-fixed-positioning-expected.checksum: Removed.
- platform/chromium-mac/fast/block/positioning/vertical-rl/fixed-positioning-expected.checksum: Removed.
- platform/chromium-mac/fast/forms/basic-textareas-quirks-actual.checksum: Removed.
- platform/chromium-mac/fast/forms/select-empty-option-height.checksum: Removed.
- platform/mac/fast/block/float/float-overhangs-root-expected.checksum: Removed.
- 9:22 AM Changeset in webkit [85056] by
-
- 7 edits in trunk/Source/WebCore
2011-04-27 Darin Adler <Darin Adler>
Reviewed by Sam Weinig.
Somehow about:blank gets into the icon database
https://bugs.webkit.org/show_bug.cgi?id=58067
rdar://problem/6751446
Implemented the policy Brady suggested, where only http and https URLs can
be associated with and icon, guarding both on the way in to the database,
and on the way out.
- loader/icon/IconDatabase.cpp: (WebCore::pageCanHaveIcon): Added. (WebCore::IconDatabase::synchronousIconForPageURL): Call pageCanHaveIcon instead of just checking for an empty URL. (WebCore::IconDatabase::synchronousIconURLForPageURL): Ditto. (WebCore::IconDatabase::retainIconForPageURL): Ditto. (WebCore::IconDatabase::releaseIconForPageURL): Ditto. (WebCore::IconDatabase::setIconURLForPageURL): Ditto. (WebCore::IconDatabase::getOrCreatePageURLRecord): Ditto. (WebCore::IconDatabase::importIconURLForPageURL): Broke assertion into two separate assertions and added a third. (WebCore::IconDatabase::performURLImport): Call pageCanHaveIcon.
- platform/KURL.cpp: Sorted includes. Moved a FIXME to the top of the file. (WebCore::isLetterMatchIgnoringCase): Renamed matchLetter to this name, overloaded it to work on both UChar and char, and added an assertion to it. Also moved this to the top of the file and made the UChar version usable in the shared code used even by Google. (WebCore::KURL::invalidate): Updated for name change. (WebCore::KURL::protocolIs): Use isLetterMatchIgnoringCase instead of toASCIILower since it's faster. (WebCore::KURL::parse): Updated for name changes. (WebCore::protocolIs):Use isLetterMatchIgnoringCase instead of toASCIILower since it's faster. (WebCore::protocolIsInHTTPFamily): Added.
- platform/KURL.h: Tweaked formatting. Renamed protocolInHTTPFamily to protocolIsInHTTPFamily and added a version that works on a string. Kept the old name as an inline function so we don't have to rename all the cal sites now.
- platform/KURLGoogle.cpp: Renamed as above. (WebCore::KURLGooglePrivate::KURLGooglePrivate): Updated for rename. (WebCore::KURLGooglePrivate::setUtf8): Ditto. (WebCore::KURLGooglePrivate::setAscii): Ditto. (WebCore::KURLGooglePrivate::initProtocolIsInHTTPFamily): Ditto. (WebCore::KURLGooglePrivate::copyTo): Ditto. (WebCore::KURL::KURL): Ditto. (WebCore::KURL::protocolIsInHTTPFamily): Ditto. (WebCore::KURL::invalidate): Ditto.
- platform/KURLGooglePrivate.h: Ditto.
- WebCore.exp.in: Updated for above changes.
- 9:12 AM Changeset in webkit [85055] by
-
- 3 edits in trunk/LayoutTests
Update the Windows-XP-specific platform results after r85011 and r85052 to get the bots green.
- platform/win-xp/fast/text/emphasis-expected.txt:
- platform/win-xp/fast/text/emphasis-vertical-expected.txt:
- 9:00 AM Changeset in webkit [85054] by
-
- 3 edits2 adds in trunk
2011-04-27 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: browser crash on evaluation of 'throw undefined'
https://bugs.webkit.org/show_bug.cgi?id=59611
- inspector/console/console-eval-throw-undefined-expected.txt: Added.
- inspector/console/console-eval-throw-undefined.html: Added.
2011-04-27 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: browser crash on evaluation of 'throw undefined'
https://bugs.webkit.org/show_bug.cgi?id=59611
Test: inspector/console/console-eval-throw-undefined.html
- inspector/InjectedScriptSource.js: use try/catch to protect from exception during conversion of another exception to string.
- 8:51 AM April 2011 Meeting/Threading edited by
- typo fix (diff)
- 8:44 AM Changeset in webkit [85053] by
-
- 2 edits in trunk/LayoutTests
[Qt] Migrate to Debian Squeeze
https://bugs.webkit.org/show_bug.cgi?id=59609
- platform/qt/Skipped: Add failing tests until fix.
- fast/workers/storage/use-same-database-in-page-and-workers.html
- svg/W3C-SVG-1.1/struct-image-06-t.svg
- http/tests/loading/preload-slow-loading.php
- http/tests/security/contentSecurityPolicy/media-src-allowed.html
- http/tests/security/contentSecurityPolicy/media-src-blocked.html
- 8:10 AM Changeset in webkit [85052] by
-
- 10 edits in trunk/LayoutTests
Update the Windows-specific platform results after r85011 to get the bots green.
- platform/win/fast/borders/bidi-012-expected.txt:
- platform/win/fast/forms/basic-textareas-quirks-expected.txt:
- platform/win/fast/inline/inline-box-background-expected.txt:
- platform/win/fast/inline/inline-box-background-long-image-expected.txt:
- platform/win/fast/inline/inline-box-background-repeat-x-expected.txt:
- platform/win/fast/inline/inline-box-background-repeat-y-expected.txt:
- platform/win/fast/lists/003-vertical-expected.txt:
- platform/win/fast/text/emphasis-expected.txt:
- platform/win/fast/text/emphasis-vertical-expected.txt:
- 8:10 AM Changeset in webkit [85051] by
-
- 2 edits in trunk/Source/WebKit/mac
2011-04-27 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
REGRESSION: Crash occurs at objc_msgSend when closing a window that is displaying the web inspector
https://bugs.webkit.org/show_bug.cgi?id=44230
Use RetainPtr access inspected view from the inspector one to avoid inspected view being deleted before
inspector is closed.
- WebCoreSupport/WebInspectorClient.mm: store reference to inspected view in RetainPtr. Despite the removed comment in initWithInspectedWebView this doesn't introduce cyclic reference since there are no retaining pointers to the WebInspectorWindowController from the inspected page or from the WebInspectorClient. There is only one reference to it from WebInspectorFrontendClient which is held by the inspector front-end page.
Drive-by fix: removed several unused methods which are currently implemented in mac/WebInspector/WebInspector.mm
(-[WebInspectorWindowController initWithInspectedWebView:]):
(-[WebInspectorWindowController close]):
(-[WebInspectorWindowController showWindow:]):
(-[WebInspectorWindowController setAttachedWindowHeight:]):
(-[WebInspectorWindowController destroyInspectorView:]):
- 8:05 AM April 2011 Meeting/Threading edited by
- Dumped my notes on the session (diff)
- 7:51 AM Changeset in webkit [85050] by
-
- 2 edits in trunk/LayoutTests
2011-04-27 Pavel Feldman <pfeldman@google.com>
Not reviewed: rebaselining inspector test.
- inspector/extensions/extensions-events-expected.txt:
- 7:18 AM Changeset in webkit [85049] by
-
- 2 edits in trunk/Tools
Correct my IRC nickname.
- Scripts/webkitpy/common/config/committers.py:
- 5:37 AM Changeset in webkit [85048] by
-
- 4 edits in trunk/Source/WebCore
2011-04-27 Pavel Feldman <pfeldman@google.com>
Reviewed by Yury Semikhatsky.
Web Inspector: clicking bookmarklet multiplies resources panel entries.
https://bugs.webkit.org/show_bug.cgi?id=59590
- inspector/front-end/ResourceTreeModel.js: (WebInspector.ResourceTreeModel): (WebInspector.ResourceTreeModel.prototype._processCachedResources): (WebInspector.ResourceTreeModel.prototype._frameNavigated):
- inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype._populateResourceTree): (WebInspector.FrameTreeElement): (WebInspector.FrameTreeElement.prototype.appendResource):
- inspector/front-end/inspector.js: (WebInspector.frontendReused):
- 4:58 AM Changeset in webkit [85047] by
-
- 2 edits in trunk/Source/WebCore
2011-04-27 Pavel Feldman <pfeldman@google.com>
Reviewed by Yury Semikhatsky.
Web Inspector: opening bookmarklet disconnects DOM agent.
https://bugs.webkit.org/show_bug.cgi?id=59588
- inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::setDocument):
- 4:45 AM Changeset in webkit [85046] by
-
- 2 edits in trunk/Source/WebCore
2011-04-27 Hans Wennborg <hans@chromium.org>
Reviewed by Tony Gentilcore.
IndexedDB: Fix compiler warnings about uninitialized variables
https://bugs.webkit.org/show_bug.cgi?id=59599
Build fix. No new tests.
- storage/IDBLevelDBBackingStore.cpp: (WebCore::getNewObjectStoreId): (WebCore::getNewIndexId):
- 4:11 AM Changeset in webkit [85045] by
-
- 4 edits2 adds in trunk/Source/WebCore
2011-04-26 Hans Wennborg <hans@chromium.org>
Reviewed by Tony Gentilcore.
IndexedDB: Move LevelDB key coding routines to separate file
https://bugs.webkit.org/show_bug.cgi?id=59452
Move all routines concerned with encoding, decoding and comparison of
LevelDB keys from IDBLevelDBBackingStore.cpp to a separate file:
IDBLevelDBCoding.cpp.
This makes IDBLevelDBBackingStore.cpp easier to work with, and will
allow for unit testing of the coding routines.
No new functionality, no new tests.
- WebCore.gypi:
- storage/IDBLevelDBBackingStore.cpp: (WebCore::getInt): (WebCore::putInt): (WebCore::getString): (WebCore::putString): (WebCore::compareKeys): (WebCore::compareIndexKeys): (WebCore::Comparator::compare): (WebCore::setUpMetadata): (WebCore::IDBLevelDBBackingStore::extractIDBDatabaseMetaData): (WebCore::getNewDatabaseId): (WebCore::IDBLevelDBBackingStore::setIDBDatabaseMetaData): (WebCore::IDBLevelDBBackingStore::getObjectStores): (WebCore::getNewObjectStoreId): (WebCore::IDBLevelDBBackingStore::createObjectStore): (WebCore::IDBLevelDBBackingStore::deleteObjectStore): (WebCore::IDBLevelDBBackingStore::getObjectStoreRecord): (WebCore::getNewVersionNumber): (WebCore::IDBLevelDBBackingStore::putObjectStoreRecord): (WebCore::IDBLevelDBBackingStore::clearObjectStore): (WebCore::IDBLevelDBBackingStore::deleteObjectStoreRecord): (WebCore::IDBLevelDBBackingStore::nextAutoIncrementNumber): (WebCore::IDBLevelDBBackingStore::keyExistsInObjectStore): (WebCore::IDBLevelDBBackingStore::forEachObjectStoreRecord): (WebCore::IDBLevelDBBackingStore::getIndexes): (WebCore::getNewIndexId): (WebCore::IDBLevelDBBackingStore::createIndex): (WebCore::IDBLevelDBBackingStore::putIndexDataForRecord): (WebCore::versionExists): (WebCore::IDBLevelDBBackingStore::getPrimaryKeyViaIndex): (WebCore::IDBLevelDBBackingStore::keyExistsInIndex): (WebCore::IDBLevelDBBackingStore::openObjectStoreCursor): (WebCore::IDBLevelDBBackingStore::openIndexKeyCursor): (WebCore::IDBLevelDBBackingStore::openIndexCursor):
- storage/IDBLevelDBCoding.cpp: Added. (WebCore::IDBLevelDBCoding::encodeByte): (WebCore::IDBLevelDBCoding::maxIDBKey): (WebCore::IDBLevelDBCoding::minIDBKey): (WebCore::IDBLevelDBCoding::encodeInt): (WebCore::IDBLevelDBCoding::decodeInt): (WebCore::IDBLevelDBCoding::encodeVarInt): (WebCore::IDBLevelDBCoding::decodeVarInt): (WebCore::IDBLevelDBCoding::encodeString): (WebCore::IDBLevelDBCoding::decodeString): (WebCore::IDBLevelDBCoding::encodeStringWithLength): (WebCore::IDBLevelDBCoding::decodeStringWithLength): (WebCore::IDBLevelDBCoding::encodeDouble): (WebCore::IDBLevelDBCoding::decodeDouble): (WebCore::IDBLevelDBCoding::encodeIDBKey): (WebCore::IDBLevelDBCoding::decodeIDBKey): (WebCore::IDBLevelDBCoding::extractEncodedIDBKey): (WebCore::IDBLevelDBCoding::compareEncodedIDBKeys): (WebCore::IDBLevelDBCoding::compare): (WebCore::IDBLevelDBCoding::KeyPrefix::KeyPrefix): (WebCore::IDBLevelDBCoding::KeyPrefix::decode): (WebCore::IDBLevelDBCoding::KeyPrefix::encode): (WebCore::IDBLevelDBCoding::KeyPrefix::compare): (WebCore::IDBLevelDBCoding::KeyPrefix::type): (WebCore::IDBLevelDBCoding::SchemaVersionKey::encode): (WebCore::IDBLevelDBCoding::MaxDatabaseIdKey::encode): (WebCore::IDBLevelDBCoding::DatabaseFreeListKey::DatabaseFreeListKey): (WebCore::IDBLevelDBCoding::DatabaseFreeListKey::decode): (WebCore::IDBLevelDBCoding::DatabaseFreeListKey::encode): (WebCore::IDBLevelDBCoding::DatabaseFreeListKey::databaseId): (WebCore::IDBLevelDBCoding::DatabaseFreeListKey::compare): (WebCore::IDBLevelDBCoding::DatabaseNameKey::decode): (WebCore::IDBLevelDBCoding::DatabaseNameKey::encode): (WebCore::IDBLevelDBCoding::DatabaseNameKey::compare): (WebCore::IDBLevelDBCoding::DatabaseMetaDataKey::encode): (WebCore::IDBLevelDBCoding::ObjectStoreMetaDataKey::ObjectStoreMetaDataKey): (WebCore::IDBLevelDBCoding::ObjectStoreMetaDataKey::decode): (WebCore::IDBLevelDBCoding::ObjectStoreMetaDataKey::encode): (WebCore::IDBLevelDBCoding::ObjectStoreMetaDataKey::objectStoreId): (WebCore::IDBLevelDBCoding::ObjectStoreMetaDataKey::metaDataType): (WebCore::IDBLevelDBCoding::ObjectStoreMetaDataKey::compare): (WebCore::IDBLevelDBCoding::IndexMetaDataKey::IndexMetaDataKey): (WebCore::IDBLevelDBCoding::IndexMetaDataKey::decode): (WebCore::IDBLevelDBCoding::IndexMetaDataKey::encode): (WebCore::IDBLevelDBCoding::IndexMetaDataKey::compare): (WebCore::IDBLevelDBCoding::IndexMetaDataKey::indexId): (WebCore::IDBLevelDBCoding::ObjectStoreFreeListKey::ObjectStoreFreeListKey): (WebCore::IDBLevelDBCoding::ObjectStoreFreeListKey::decode): (WebCore::IDBLevelDBCoding::ObjectStoreFreeListKey::encode): (WebCore::IDBLevelDBCoding::ObjectStoreFreeListKey::objectStoreId): (WebCore::IDBLevelDBCoding::ObjectStoreFreeListKey::compare): (WebCore::IDBLevelDBCoding::IndexFreeListKey::IndexFreeListKey): (WebCore::IDBLevelDBCoding::IndexFreeListKey::decode): (WebCore::IDBLevelDBCoding::IndexFreeListKey::encode): (WebCore::IDBLevelDBCoding::IndexFreeListKey::compare): (WebCore::IDBLevelDBCoding::IndexFreeListKey::objectStoreId): (WebCore::IDBLevelDBCoding::IndexFreeListKey::indexId): (WebCore::IDBLevelDBCoding::ObjectStoreNamesKey::decode): (WebCore::IDBLevelDBCoding::ObjectStoreNamesKey::encode): (WebCore::IDBLevelDBCoding::ObjectStoreNamesKey::compare): (WebCore::IDBLevelDBCoding::IndexNamesKey::IndexNamesKey): (WebCore::IDBLevelDBCoding::IndexNamesKey::decode): (WebCore::IDBLevelDBCoding::IndexNamesKey::encode): (WebCore::IDBLevelDBCoding::IndexNamesKey::compare): (WebCore::IDBLevelDBCoding::ObjectStoreDataKey::decode): (WebCore::IDBLevelDBCoding::ObjectStoreDataKey::encode): (WebCore::IDBLevelDBCoding::ObjectStoreDataKey::compare): (WebCore::IDBLevelDBCoding::ObjectStoreDataKey::userKey): (WebCore::IDBLevelDBCoding::ExistsEntryKey::decode): (WebCore::IDBLevelDBCoding::ExistsEntryKey::encode): (WebCore::IDBLevelDBCoding::ExistsEntryKey::compare): (WebCore::IDBLevelDBCoding::ExistsEntryKey::userKey): (WebCore::IDBLevelDBCoding::IndexDataKey::IndexDataKey): (WebCore::IDBLevelDBCoding::IndexDataKey::decode): (WebCore::IDBLevelDBCoding::IndexDataKey::encode): (WebCore::IDBLevelDBCoding::IndexDataKey::encodeMaxKey): (WebCore::IDBLevelDBCoding::IndexDataKey::compare): (WebCore::IDBLevelDBCoding::IndexDataKey::databaseId): (WebCore::IDBLevelDBCoding::IndexDataKey::objectStoreId): (WebCore::IDBLevelDBCoding::IndexDataKey::indexId): (WebCore::IDBLevelDBCoding::IndexDataKey::userKey):
- storage/IDBLevelDBCoding.h: Added. (WebCore::IDBLevelDBCoding::DatabaseNameKey::origin): (WebCore::IDBLevelDBCoding::DatabaseNameKey::databaseName): (WebCore::IDBLevelDBCoding::IndexMetaDataKey::metaDataType): (WebCore::IDBLevelDBCoding::ObjectStoreNamesKey::objectStoreName): (WebCore::IDBLevelDBCoding::IndexNamesKey::indexName):
- 3:22 AM Changeset in webkit [85044] by
-
- 2 edits in trunk/Source/JavaScriptCore
Fix 32-bit build after r85036.
- wtf/Platform.h: USE(PLUGIN_HOST_PROCESS) is only true for 64-bit.
- 3:14 AM Changeset in webkit [85043] by
-
- 2 edits in trunk/Tools
2011-04-27 Lucas De Marchi <lucas.demarchi@profusion.mobi>
Reviewed by Darin Adler.
Change the email used on bugzilla
https://bugs.webkit.org/show_bug.cgi?id=59582
- Scripts/webkitpy/common/config/committers.py:
- 3:00 AM Changeset in webkit [85042] by
-
- 4 edits in trunk/Source/WebCore
2011-04-27 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: expose exception details when script is paused on exception
https://bugs.webkit.org/show_bug.cgi?id=59591
When script is paused on an exception, the exception value is added as <exception>
property in the local scope and the breakpoint details message says
"Paused on excepion: '<exception to strin value>'."
- English.lproj/localizedStrings.js:
- inspector/front-end/ScopeChainSidebarPane.js: (WebInspector.ScopeChainSidebarPane.prototype.update):
- inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype._debuggerPaused.else.didGetSourceLocation): (WebInspector.ScriptsPanel.prototype._debuggerPaused):
- 3:00 AM Changeset in webkit [85041] by
-
- 2 edits in trunk/Source/JavaScriptCore
Unreviewed buildfix after r85036.
Readd non-dead code.
- wtf/OSAllocatorPosix.cpp:
(WTF::OSAllocator::reserveAndCommit):
- 2:48 AM Changeset in webkit [85040] by
-
- 3 edits1 copy1 add in trunk/Tools
2011-04-27 James Kozianski <koz@chromium.org>
Reviewed by Ojan Vafai.
Extract map from port to builder name.
https://bugs.webkit.org/show_bug.cgi?id=58301
- Scripts/webkitpy/layout_tests/port/init.py:
- Scripts/webkitpy/layout_tests/port/builders.py: Added.
- Scripts/webkitpy/layout_tests/port/builders_unittest.py: Added.
- Scripts/webkitpy/layout_tests/port/factory.py:
- 2:42 AM Changeset in webkit [85039] by
-
- 3 edits in trunk/Tools
2011-04-27 Ryuan Choi <ryuan.choi@samsung.com>
Reviewed by Martin Robinson.
[GTK] Add proxy support to GtkLauncher
https://bugs.webkit.org/show_bug.cgi?id=58852
Add SOUP_TYPE_PROXY_RESOLVER_DEFAULT feature or set SOUP_SESSION_PROXY_URI for developers behind proxy.
- GNUmakefile.am:
- GtkLauncher/main.c: (main):
- 2:26 AM Changeset in webkit [85038] by
-
- 2 edits in trunk/Tools
2011-04-27 Annie Sullivan <sullivan@chromium.org>
Reviewed by David Levin.
Adding myself as a Chromium contributor to committers.py.
- Scripts/webkitpy/common/config/committers.py:
- 2:21 AM Changeset in webkit [85037] by
-
- 36 edits in trunk
Remove some obsolete Xcode configuration settings.
Reviewed by Timothy Hatcher.
- 2:21 AM Changeset in webkit [85036] by
-
- 169 edits in trunk
Remove some dead code.
Rubber-stamped by Timothy Hatcher.
- 1:55 AM Changeset in webkit [85035] by
-
- 19 edits in trunk/Source/WebCore
2011-04-26 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: [protocol] Paused event should expose exception value that caused it
https://bugs.webkit.org/show_bug.cgi?id=58996
Debug.pause event now contains an optional reference to the exception
object in case script execution is paused on a JavaScript exception.
Also JavaScript call frames are passed directly into the injected script when
we need to wrap them for passing to the front-end. This change breaks cyclic
dependency ScriptDebugServer->InspectorDebuggerAgent->InjectedScript->InjectedScriptHost->ScriptDebugServer
- bindings/js/JSInjectedScriptHostCustom.cpp:
- bindings/js/ScriptDebugServer.cpp: (WebCore::ScriptDebugServer::dispatchDidPause):
- bindings/js/ScriptDebugServer.h:
- bindings/v8/ScriptDebugServer.cpp: (WebCore::ScriptDebugServer::breakProgram): (WebCore::ScriptDebugServer::editScriptSource): (WebCore::ScriptDebugServer::breakProgramCallback): (WebCore::ScriptDebugServer::handleV8DebugEvent):
- bindings/v8/ScriptDebugServer.h:
- bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
- inspector/InjectedScript.cpp: (WebCore::InjectedScript::evaluateOnCallFrame): (WebCore::InjectedScript::wrapCallFrames):
- inspector/InjectedScript.h:
- inspector/InjectedScriptHost.cpp:
- inspector/InjectedScriptHost.h: (WebCore::InjectedScriptHost::init):
- inspector/InjectedScriptHost.idl:
- inspector/InjectedScriptSource.js: (.):
- inspector/Inspector.json:
- inspector/InspectorAgent.cpp: (WebCore::InspectorAgent::InspectorAgent):
- inspector/InspectorDebuggerAgent.cpp: (WebCore::InspectorDebuggerAgent::evaluateOnCallFrame): (WebCore::InspectorDebuggerAgent::currentCallFrames): (WebCore::InspectorDebuggerAgent::wrapCallFrames): (WebCore::InspectorDebuggerAgent::didPause): (WebCore::InspectorDebuggerAgent::didContinue): (WebCore::InspectorDebuggerAgent::clear):
- inspector/InspectorDebuggerAgent.h:
- inspector/ScriptDebugListener.h:
- inspector/WorkerInspectorController.cpp: (WebCore::WorkerInspectorController::WorkerInspectorController):
- 1:34 AM Changeset in webkit [85034] by
-
- 2 edits in trunk/Source/WebCore
2011-04-27 Pavel Feldman <pfeldman@google.com>
Reviewed by Yury Semikhatsky.
Web Inspector: implement incremental CSS editing in the structure view.
https://bugs.webkit.org/show_bug.cgi?id=59455
- inspector/front-end/StylesSidebarPane.js: (WebInspector.StylePropertyTreeElement.prototype):
- 1:15 AM Changeset in webkit [85033] by
-
- 2 edits in trunk/LayoutTests
2011-04-27 Martin Robinson <mrobinson@igalia.com>
Skip another test on GTK+ because we are still missing frame loader delegate output
in the DRT.
- platform/gtk/Skipped: Update skipped list.
- 1:11 AM Changeset in webkit [85032] by
-
- 54 edits3 adds in trunk/LayoutTests
2011-04-27 Martin Robinson <mrobinson@igalia.com>
Update GTK+ specific expected results after r85011.
- platform/gtk/css2.1/t0905-c414-flt-00-d-expected.txt:
- platform/gtk/css2.1/t0905-c414-flt-01-d-g-expected.txt:
- platform/gtk/css2.1/t0905-c414-flt-02-c-expected.txt:
- platform/gtk/css2.1/t0905-c414-flt-03-c-expected.txt:
- platform/gtk/css2.1/t0905-c414-flt-04-c-expected.txt:
- platform/gtk/css2.1/t0905-c414-flt-wrap-01-d-g-expected.txt:
- platform/gtk/css2.1/t0905-c5525-fltcont-00-d-g-expected.txt:
- platform/gtk/css2.1/t0905-c5525-fltwidth-02-c-g-expected.txt:
- platform/gtk/css2.1/t0905-c5525-fltwidth-03-c-g-expected.txt:
- platform/gtk/css2.1/t090501-c414-flt-02-d-g-expected.txt:
- platform/gtk/css2.1/t090501-c414-flt-03-b-g-expected.txt:
- platform/gtk/fast/backgrounds/background-position-parsing-expected.txt:
- platform/gtk/fast/backgrounds/repeat/mask-negative-offset-repeat-expected.png: Added.
- platform/gtk/fast/backgrounds/repeat/mask-negative-offset-repeat-expected.txt:
- platform/gtk/fast/backgrounds/repeat/negative-offset-repeat-expected.png: Added.
- platform/gtk/fast/backgrounds/repeat/negative-offset-repeat-expected.txt:
- platform/gtk/fast/block/float/008-expected.txt:
- platform/gtk/fast/block/float/029-expected.txt:
- platform/gtk/fast/block/float/031-expected.txt:
- platform/gtk/fast/block/float/033-expected.txt:
- platform/gtk/fast/block/float/035-expected.txt:
- platform/gtk/fast/block/float/clamped-right-float-expected.txt:
- platform/gtk/fast/block/float/float-forced-below-other-floats-expected.txt:
- platform/gtk/fast/block/float/nested-clearance-expected.txt:
- platform/gtk/fast/block/margin-collapse/062-expected.txt:
- platform/gtk/fast/block/margin-collapse/063-expected.txt:
- platform/gtk/fast/blockflow/block-level-images-expected.png:
- platform/gtk/fast/blockflow/block-level-images-expected.txt:
- platform/gtk/fast/blockflow/floats-in-block-layout-expected.txt:
- platform/gtk/fast/borders/bidi-012-expected.png:
- platform/gtk/fast/borders/bidi-012-expected.txt:
- platform/gtk/fast/box-shadow/basic-shadows-expected.txt:
- platform/gtk/fast/css/color-correction-on-background-image-expected.txt:
- platform/gtk/fast/css/h1-in-section-elements-expected.png:
- platform/gtk/fast/css/h1-in-section-elements-expected.txt:
- platform/gtk/fast/forms/basic-textareas-quirks-expected.png:
- platform/gtk/fast/forms/basic-textareas-quirks-expected.txt:
- platform/gtk/fast/inline/inline-box-background-expected.txt:
- platform/gtk/fast/inline/inline-box-background-long-image-expected.txt:
- platform/gtk/fast/inline/inline-box-background-repeat-x-expected.txt:
- platform/gtk/fast/inline/inline-box-background-repeat-y-expected.txt:
- platform/gtk/fast/lists/003-expected.txt:
- platform/gtk/fast/lists/003-vertical-expected.png: Added.
- platform/gtk/fast/lists/003-vertical-expected.txt:
- platform/gtk/fast/media/mq-relative-constraints-08-expected.txt:
- platform/gtk/fast/repaint/box-shadow-h-expected.txt:
- platform/gtk/fast/repaint/box-shadow-v-expected.txt:
- platform/gtk/fast/repaint/subtree-root-clip-expected.txt:
- platform/gtk/fast/text/emphasis-vertical-expected.txt:
- platform/gtk/fast/text/whitespace/012-expected.txt:
- platform/gtk/plugins/resize-from-plugin-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug120364-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug45055-2-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug72359-expected.txt:
- platform/gtk/tables/mozilla/marvin/x_table_align_left-expected.txt:
- platform/gtk/tables/mozilla/marvin/x_table_align_right-expected.txt:
- 1:07 AM Changeset in webkit [85031] by
-
- 2 edits1 add2 deletes in trunk/LayoutTests
2011-04-27 Martin Robinson <mrobinson@igalia.com>
Skip a failing test. Add GTK+-specific results for another and organize
the Skipped file a bit. Remove platform-specific results for a test which
is now a text dumping test.
- platform/gtk/Skipped: Organize and skip a new test.
- platform/gtk/fast/events/keydown-1-expected.png: Removed.
- platform/gtk/fast/events/keydown-1-expected.txt: Removed.
- platform/gtk/fast/events/overflow-viewport-renderer-deleted-expected.txt: Added.
- 12:37 AM Changeset in webkit [85030] by
-
- 28 edits in trunk/Source
2011-04-27 Mihai Parparita <mihaip@chromium.org>
Reviewed by Eric Seidel.
Frame.h shouldn't include Document.h
https://bugs.webkit.org/show_bug.cgi?id=59560
Frame can use a forward-declared Document if we move
Frame::displayStringModifiedByEncoding's implementation out of the
header.
Size #includes Size * #includes
Before: page/Frame.h: 0.746 653 487.138
dom/Document.h: 0.220 1306 287.320
After: page/Frame.h: 0.646 653 421.838
dom/Document.h: 0.220 1189 261.580
- WebCore.exp.in:
- bindings/ScriptControllerBase.cpp:
- bindings/generic/BindingSecurityBase.cpp:
- bindings/v8/V8Proxy.cpp:
- bindings/v8/custom/V8XMLHttpRequestCustom.cpp:
- dom/CharacterData.cpp:
- dom/UserTypingGestureIndicator.cpp:
- editing/chromium/SelectionControllerChromium.cpp:
- inspector/InspectorDOMStorageResource.cpp:
- inspector/InspectorInstrumentation.h:
- loader/PingLoader.cpp:
- loader/SubresourceLoader.cpp:
- loader/appcache/DOMApplicationCache.cpp:
- loader/cache/CachedResourceRequest.cpp:
- page/Frame.cpp: (WebCore::Frame::displayStringModifiedByEncoding):
- page/Frame.h:
- page/Geolocation.cpp:
- page/Location.cpp:
- page/Navigator.cpp:
- page/PageGroupLoadDeferrer.cpp:
- page/PerformanceTiming.cpp:
- xml/XSLTProcessorLibxslt.cpp:
2011-04-27 Mihai Parparita <mihaip@chromium.org>
Reviewed by Eric Seidel.
Frame.h shouldn't include Document.h
https://bugs.webkit.org/show_bug.cgi?id=59560
Add Document.h #includes for files that were relying on transitive
#includes via Frame.h.
- src/LocalFileSystemChromium.cpp:
- src/StorageEventDispatcherImpl.cpp:
- src/WebFrameImpl.h:
- src/WebWorkerBase.cpp:
- 12:18 AM Changeset in webkit [85029] by
-
- 57 edits3 adds in trunk/LayoutTests
Root element should establish a new block formatting context
https://bugs.webkit.org/show_bug.cgi?id=54573
Update Qt specific expected results after r85011.
- platform/qt/css2.1/t0905-c414-flt-00-d-expected.png:
- platform/qt/css2.1/t0905-c414-flt-00-d-expected.txt:
- platform/qt/css2.1/t0905-c414-flt-01-d-g-expected.png:
- platform/qt/css2.1/t0905-c414-flt-01-d-g-expected.txt:
- platform/qt/css2.1/t0905-c414-flt-02-c-expected.png:
- platform/qt/css2.1/t0905-c414-flt-02-c-expected.txt:
- platform/qt/css2.1/t0905-c414-flt-03-c-expected.png:
- platform/qt/css2.1/t0905-c414-flt-03-c-expected.txt:
- platform/qt/css2.1/t0905-c414-flt-04-c-expected.png:
- platform/qt/css2.1/t0905-c414-flt-04-c-expected.txt:
- platform/qt/css2.1/t0905-c5525-fltcont-00-d-g-expected.png:
- platform/qt/css2.1/t0905-c5525-fltcont-00-d-g-expected.txt:
- platform/qt/css2.1/t0905-c5525-fltwidth-02-c-g-expected.png:
- platform/qt/css2.1/t0905-c5525-fltwidth-02-c-g-expected.txt:
- platform/qt/css2.1/t0905-c5525-fltwidth-03-c-g-expected.png:
- platform/qt/css2.1/t0905-c5525-fltwidth-03-c-g-expected.txt:
- platform/qt/css2.1/t090501-c414-flt-02-d-g-expected.png:
- platform/qt/css2.1/t090501-c414-flt-02-d-g-expected.txt:
- platform/qt/css2.1/t090501-c414-flt-03-b-g-expected.png:
- platform/qt/css2.1/t090501-c414-flt-03-b-g-expected.txt:
- platform/qt/fast/backgrounds/repeat/mask-negative-offset-repeat-expected.png: Added.
- platform/qt/fast/backgrounds/repeat/mask-negative-offset-repeat-expected.txt:
- platform/qt/fast/backgrounds/repeat/negative-offset-repeat-expected.png:
- platform/qt/fast/backgrounds/repeat/negative-offset-repeat-expected.txt:
- platform/qt/fast/block/float/008-expected.png:
- platform/qt/fast/block/float/008-expected.txt:
- platform/qt/fast/block/float/029-expected.txt:
- platform/qt/fast/block/float/031-expected.txt:
- platform/qt/fast/block/float/033-expected.png:
- platform/qt/fast/block/float/033-expected.txt:
- platform/qt/fast/block/float/035-expected.png:
- platform/qt/fast/block/float/035-expected.txt:
- platform/qt/fast/block/float/clamped-right-float-expected.txt:
- platform/qt/fast/block/float/nested-clearance-expected.txt:
- platform/qt/fast/block/margin-collapse/062-expected.txt:
- platform/qt/fast/block/margin-collapse/063-expected.txt:
- platform/qt/fast/blockflow/block-level-images-expected.png:
- platform/qt/fast/blockflow/block-level-images-expected.txt:
- platform/qt/fast/blockflow/floats-in-block-layout-expected.png:
- platform/qt/fast/blockflow/floats-in-block-layout-expected.txt:
- platform/qt/fast/borders/bidi-012-expected.txt:
- platform/qt/fast/box-shadow/basic-shadows-expected.png:
- platform/qt/fast/box-shadow/basic-shadows-expected.txt:
- platform/qt/fast/lists/003-vertical-expected.png:
- platform/qt/fast/lists/003-vertical-expected.txt:
- platform/qt/fast/media/mq-relative-constraints-08-expected.png: Added.
- platform/qt/fast/media/mq-relative-constraints-08-expected.txt:
- platform/qt/fast/text/whitespace/012-expected.png: Added.
- platform/qt/fast/text/whitespace/012-expected.txt:
- platform/qt/tables/mozilla/bugs/bug120364-expected.png:
- platform/qt/tables/mozilla/bugs/bug120364-expected.txt:
- platform/qt/tables/mozilla/bugs/bug45055-2-expected.png:
- platform/qt/tables/mozilla/bugs/bug45055-2-expected.txt:
- platform/qt/tables/mozilla/bugs/bug72359-expected.png:
- platform/qt/tables/mozilla/bugs/bug72359-expected.txt:
- platform/qt/tables/mozilla/marvin/x_table_align_left-expected.png:
- platform/qt/tables/mozilla/marvin/x_table_align_left-expected.txt:
- platform/qt/tables/mozilla/marvin/x_table_align_right-expected.png:
- platform/qt/tables/mozilla/marvin/x_table_align_right-expected.txt:
- 12:15 AM Changeset in webkit [85028] by
-
- 2 edits in trunk/Source/JavaScriptCore
2011-04-27 Adam Barth <abarth@webkit.org>
Reviewed by Kenneth Russell.
OwnPtr assignment operator should be private
https://bugs.webkit.org/show_bug.cgi?id=59487
Unfortunately we can't remove the copy constructor because of some
detail about gcc. (The issue is documented in a comment already.)
- wtf/OwnPtr.h:
- 12:04 AM Changeset in webkit [85027] by
-
- 10 edits in trunk/Source/WebCore
2011-04-27 James Robinson <jamesr@chromium.org>
Reviewed by Eric Seidel.
Fix OwnPtr strict errors in RenderStyle and make StyleRareInheritedData::textShadow an OwnPtr
https://bugs.webkit.org/show_bug.cgi?id=59377
This cleans up some strict OwnPtr<> violations around text and box shadow data. ShadowData's linked list data
structure now uses OwnPtr<>s to manage memory - each entry in the list has ownership of the next ShadowData.
- css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty):
- page/animation/AnimationBase.cpp: (WebCore::blendFunc): (WebCore::PropertyWrapperShadow::PropertyWrapperShadow): (WebCore::PropertyWrapperShadow::blend):
- rendering/style/RenderStyle.cpp: (WebCore::RenderStyle::setTextShadow): (WebCore::RenderStyle::setBoxShadow):
- rendering/style/RenderStyle.h: (WebCore::InheritedFlags::textShadow):
- rendering/style/ShadowData.cpp: (WebCore::ShadowData::ShadowData):
- rendering/style/ShadowData.h: (WebCore::ShadowData::ShadowData): (WebCore::ShadowData::next): (WebCore::ShadowData::setNext):
- rendering/style/StyleRareInheritedData.cpp: (WebCore::StyleRareInheritedData::StyleRareInheritedData): (WebCore::StyleRareInheritedData::~StyleRareInheritedData):
- rendering/style/StyleRareInheritedData.h:
- rendering/style/StyleRareNonInheritedData.cpp: (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
Apr 26, 2011:
- 11:59 PM Changeset in webkit [85026] by
-
- 2 edits1 add in trunk/LayoutTests
[Qt] Improper rendering of <button> tag when it contains a <br>
https://bugs.webkit.org/show_bug.cgi?id=50521
Update Qt specific expected files after r85009.
- platform/qt/fast/replaced/table-percent-height-expected.txt:
- 11:52 PM Changeset in webkit [85025] by
-
- 113 edits1 copy22 adds in trunk/LayoutTests
[Qt] Improper rendering of <button> tag when it contains a <br>
https://bugs.webkit.org/show_bug.cgi?id=50521
Update Qt specific expected files after r85009.
- platform/qt/editing/selection/3690703-2-expected.png:
- platform/qt/editing/selection/3690703-2-expected.txt:
- platform/qt/editing/selection/3690703-expected.png:
- platform/qt/editing/selection/3690703-expected.txt:
- platform/qt/editing/selection/3690719-expected.png:
- platform/qt/editing/selection/3690719-expected.txt:
- platform/qt/editing/selection/5240265-expected.png:
- platform/qt/editing/selection/5240265-expected.txt:
- platform/qt/fast/block/float/float-avoidance-expected.png:
- platform/qt/fast/block/float/float-avoidance-expected.txt:
- platform/qt/fast/block/positioning/inline-block-relposition-expected.png:
- platform/qt/fast/block/positioning/inline-block-relposition-expected.txt:
- platform/qt/fast/css/continuationCrash-expected.png:
- platform/qt/fast/css/continuationCrash-expected.txt:
- platform/qt/fast/css/margin-top-bottom-dynamic-expected.png:
- platform/qt/fast/css/margin-top-bottom-dynamic-expected.txt:
- platform/qt/fast/dom/HTMLTableColElement/resize-table-using-col-width-expected.png: Added.
- platform/qt/fast/dom/HTMLTableColElement/resize-table-using-col-width-expected.txt:
- platform/qt/fast/dynamic/positioned-movement-with-positioned-children-expected.txt:
- platform/qt/fast/forms/basic-buttons-expected.png: Added.
- platform/qt/fast/forms/basic-buttons-expected.txt:
- platform/qt/fast/forms/basic-selects-expected.png:
- platform/qt/fast/forms/basic-selects-expected.txt:
- platform/qt/fast/forms/blankbuttons-expected.png: Copied from LayoutTests/platform/qt/tables/mozilla/bugs/bug4429-expected.png.
- platform/qt/fast/forms/blankbuttons-expected.txt:
- platform/qt/fast/forms/button-align-expected.png: Added.
- platform/qt/fast/forms/button-align-expected.txt:
- platform/qt/fast/forms/button-cannot-be-nested-expected.png: Added.
- platform/qt/fast/forms/button-cannot-be-nested-expected.txt:
- platform/qt/fast/forms/button-generated-content-expected.png: Added.
- platform/qt/fast/forms/button-generated-content-expected.txt:
- platform/qt/fast/forms/button-inner-block-reuse-expected.png: Added.
- platform/qt/fast/forms/button-inner-block-reuse-expected.txt:
- platform/qt/fast/forms/button-line-break-expected.txt:
- platform/qt/fast/forms/button-positioned-expected.png: Added.
- platform/qt/fast/forms/button-positioned-expected.txt:
- platform/qt/fast/forms/button-sizes-expected.png: Added.
- platform/qt/fast/forms/button-sizes-expected.txt:
- platform/qt/fast/forms/button-style-color-expected.png: Added.
- platform/qt/fast/forms/button-style-color-expected.txt:
- platform/qt/fast/forms/button-table-styles-expected.png: Added.
- platform/qt/fast/forms/button-table-styles-expected.txt:
- platform/qt/fast/forms/button-text-transform-expected.png: Added.
- platform/qt/fast/forms/button-text-transform-expected.txt:
- platform/qt/fast/forms/control-clip-overflow-expected.png: Added.
- platform/qt/fast/forms/control-clip-overflow-expected.txt:
- platform/qt/fast/forms/control-restrict-line-height-expected.png: Added.
- platform/qt/fast/forms/control-restrict-line-height-expected.txt:
- platform/qt/fast/forms/formmove3-expected.png: Added.
- platform/qt/fast/forms/formmove3-expected.txt:
- platform/qt/fast/forms/input-button-sizes-expected.png:
- platform/qt/fast/forms/input-button-sizes-expected.txt:
- platform/qt/fast/forms/select-baseline-expected.png: Added.
- platform/qt/fast/forms/select-baseline-expected.txt:
- platform/qt/fast/forms/targeted-frame-submission-expected.png: Added.
- platform/qt/fast/forms/targeted-frame-submission-expected.txt:
- platform/qt/fast/replaced/replaced-breaking-expected.png:
- platform/qt/fast/replaced/replaced-breaking-expected.txt:
- platform/qt/fast/replaced/width100percent-button-expected.png:
- platform/qt/fast/replaced/width100percent-button-expected.txt:
- platform/qt/fast/selectors/064-expected.png:
- platform/qt/fast/selectors/064-expected.txt:
- platform/qt/fast/table/append-cells2-expected.png:
- platform/qt/fast/table/append-cells2-expected.txt:
- platform/qt/fast/table/remove-td-display-none-expected.png:
- platform/qt/fast/table/remove-td-display-none-expected.txt:
- platform/qt/fast/text/textIteratorNilRenderer-expected.png: Added.
- platform/qt/fast/text/textIteratorNilRenderer-expected.txt:
- platform/qt/http/tests/navigation/javascriptlink-frames-expected.png:
- platform/qt/http/tests/navigation/javascriptlink-frames-expected.txt:
- platform/qt/platform/qt/fast/forms/button-line-break-expected.png: Added.
- platform/qt/svg/custom/inline-svg-in-xhtml-expected.png:
- platform/qt/svg/custom/inline-svg-in-xhtml-expected.txt:
- platform/qt/tables/mozilla/bugs/bug1188-expected.png:
- platform/qt/tables/mozilla/bugs/bug1188-expected.txt:
- platform/qt/tables/mozilla/bugs/bug1318-expected.png:
- platform/qt/tables/mozilla/bugs/bug1318-expected.txt:
- platform/qt/tables/mozilla/bugs/bug138725-expected.png:
- platform/qt/tables/mozilla/bugs/bug138725-expected.txt:
- platform/qt/tables/mozilla/bugs/bug18359-expected.png:
- platform/qt/tables/mozilla/bugs/bug18359-expected.txt:
- platform/qt/tables/mozilla/bugs/bug2479-2-expected.png:
- platform/qt/tables/mozilla/bugs/bug2479-2-expected.txt:
- platform/qt/tables/mozilla/bugs/bug2479-3-expected.png:
- platform/qt/tables/mozilla/bugs/bug2479-3-expected.txt:
- platform/qt/tables/mozilla/bugs/bug2479-4-expected.png:
- platform/qt/tables/mozilla/bugs/bug2479-4-expected.txt:
- platform/qt/tables/mozilla/bugs/bug26178-expected.png:
- platform/qt/tables/mozilla/bugs/bug26178-expected.txt:
- platform/qt/tables/mozilla/bugs/bug28928-expected.png:
- platform/qt/tables/mozilla/bugs/bug28928-expected.txt:
- platform/qt/tables/mozilla/bugs/bug33855-expected.png:
- platform/qt/tables/mozilla/bugs/bug33855-expected.txt:
- platform/qt/tables/mozilla/bugs/bug39209-expected.png:
- platform/qt/tables/mozilla/bugs/bug39209-expected.txt:
- platform/qt/tables/mozilla/bugs/bug4429-expected.png:
- platform/qt/tables/mozilla/bugs/bug4429-expected.txt:
- platform/qt/tables/mozilla/bugs/bug44505-expected.png:
- platform/qt/tables/mozilla/bugs/bug44505-expected.txt:
- platform/qt/tables/mozilla/bugs/bug46368-1-expected.png:
- platform/qt/tables/mozilla/bugs/bug46368-1-expected.txt:
- platform/qt/tables/mozilla/bugs/bug46368-2-expected.png:
- platform/qt/tables/mozilla/bugs/bug46368-2-expected.txt:
- platform/qt/tables/mozilla/bugs/bug51037-expected.png:
- platform/qt/tables/mozilla/bugs/bug51037-expected.txt:
- platform/qt/tables/mozilla/bugs/bug51727-expected.png:
- platform/qt/tables/mozilla/bugs/bug51727-expected.txt:
- platform/qt/tables/mozilla/bugs/bug52505-expected.png:
- platform/qt/tables/mozilla/bugs/bug52505-expected.txt:
- platform/qt/tables/mozilla/bugs/bug52506-expected.png:
- platform/qt/tables/mozilla/bugs/bug52506-expected.txt:
- platform/qt/tables/mozilla/bugs/bug60749-expected.png:
- platform/qt/tables/mozilla/bugs/bug60749-expected.txt:
- platform/qt/tables/mozilla/bugs/bug68912-expected.png:
- platform/qt/tables/mozilla/bugs/bug68912-expected.txt:
- platform/qt/tables/mozilla/bugs/bug7342-expected.png:
- platform/qt/tables/mozilla/bugs/bug7342-expected.txt:
- platform/qt/tables/mozilla/collapsing_borders/bug41262-4-expected.png:
- platform/qt/tables/mozilla/collapsing_borders/bug41262-4-expected.txt:
- platform/qt/tables/mozilla/dom/tableDom-expected.png:
- platform/qt/tables/mozilla/dom/tableDom-expected.txt:
- platform/qt/tables/mozilla/other/move_row-expected.png:
- platform/qt/tables/mozilla/other/move_row-expected.txt:
- platform/qt/tables/mozilla_expected_failures/bugs/bug1725-expected.png:
- platform/qt/tables/mozilla_expected_failures/bugs/bug1725-expected.txt:
- platform/qt/tables/mozilla_expected_failures/bugs/bug58402-2-expected.png:
- platform/qt/tables/mozilla_expected_failures/bugs/bug58402-2-expected.txt:
- platform/qt/tables/mozilla_expected_failures/collapsing_borders/bug41262-5-expected.png:
- platform/qt/tables/mozilla_expected_failures/collapsing_borders/bug41262-5-expected.txt:
- platform/qt/tables/mozilla_expected_failures/collapsing_borders/bug41262-6-expected.png:
- platform/qt/tables/mozilla_expected_failures/collapsing_borders/bug41262-6-expected.txt:
- 11:36 PM Changeset in webkit [85024] by
-
- 2 edits in trunk/Tools
2011-04-26 David Grogan <dgrogan@chromium.org>
Reviewed by David Levin.
Adding myself to Chromium contributors list in committers.py
https://bugs.webkit.org/show_bug.cgi?id=59565
- Scripts/webkitpy/common/config/committers.py:
- 11:32 PM Changeset in webkit [85023] by
-
- 2 edits in trunk/Source/WebKit/chromium
2011-04-26 Jay Civelli <jcivelli@chromium.org>
Reviewed by Eric Seidel.
Typedefing the shared timer function.
https://bugs.webkit.org/show_bug.cgi?id=59564
- public/WebKitClient.h: (WebKit::WebKitClient::setSharedTimerFiredFunction):
- 11:16 PM Changeset in webkit [85022] by
-
- 2 edits in trunk/LayoutTests
2011-04-26 Dirk Pranke <dpranke@chromium.org>
Unreviewed, expectations change.
And yet more failures resulting from r85011
- platform/chromium/test_expectations.txt:
- 11:09 PM Changeset in webkit [85021] by
-
- 2 edits in trunk/LayoutTests
2011-04-26 Dirk Pranke <dpranke@chromium.org>
Unreviewed, expectations change.
Suppress more failures resulting from r85011
- platform/chromium/test_expectations.txt:
- 11:08 PM Changeset in webkit [85020] by
-
- 8 edits in trunk/Source/WebCore
2011-04-26 David Levin <levin@chromium.org>
Reviewed by Eric Seidel.
Fix some strict PassOwnPtr issues in WebCore.
https://bugs.webkit.org/show_bug.cgi?id=59563
- css/SVGCSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applySVGProperty):
- html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::create): (WebCore::WebGLRenderingContext::~WebGLRenderingContext):
- platform/text/TextCodecLatin1.cpp: (WebCore::newStreamingTextDecoderWindowsLatin1):
- platform/text/TextCodecUTF16.cpp: (WebCore::newStreamingTextDecoderUTF16LE): (WebCore::newStreamingTextDecoderUTF16BE):
- platform/text/TextCodecUserDefined.cpp: (WebCore::newStreamingTextDecoderUserDefined):
- platform/text/mac/TextCodecMac.cpp: (WebCore::newTextCodecMac):
- workers/Worker.cpp: (WebCore::Worker::notifyFinished):
- 10:54 PM Changeset in webkit [85019] by
-
- 13 edits in trunk
2011-04-26 Chang Shu <cshu@webkit.org>
Reviewed by Laszlo Gombos.
WebKitTestRunner needs layoutTestController.addOriginAccessWhitelistEntry
https://bugs.webkit.org/show_bug.cgi?id=42544
Unskip passed tests and place failing tests for other reasons to other sections.
- platform/mac-wk2/Skipped:
- platform/qt-wk2/Skipped:
2011-04-26 Chang Shu <cshu@webkit.org>
Reviewed by Laszlo Gombos.
WebKitTestRunner needs layoutTestController.addOriginAccessWhitelistEntry
https://bugs.webkit.org/show_bug.cgi?id=42544
Also implemented removeOriginAccessWhitelistEntry and resetOriginAccessWhitelists.
- WebProcess/InjectedBundle/API/c/WKBundle.cpp: (WKBundleAddOriginAccessWhitelistEntry): (WKBundleRemoveOriginAccessWhitelistEntry): (WKBundleResetOriginAccessWhitelists):
- WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:
- WebProcess/InjectedBundle/InjectedBundle.cpp: (WebKit::InjectedBundle::addOriginAccessWhitelistEntry): (WebKit::InjectedBundle::removeOriginAccessWhitelistEntry): (WebKit::InjectedBundle::resetOriginAccessWhitelists):
- WebProcess/InjectedBundle/InjectedBundle.h:
2011-04-26 Chang Shu <cshu@webkit.org>
Reviewed by Laszlo Gombos.
WebKitTestRunner needs layoutTestController.addOriginAccessWhitelistEntry
https://bugs.webkit.org/show_bug.cgi?id=42544
Also implemented removeOriginAccessWhitelistEntry and resetOriginAccessWhitelists.
- WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
- WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: (WTR::InjectedBundle::beginTesting):
- WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: (WTR::LayoutTestController::addOriginAccessWhitelistEntry): (WTR::LayoutTestController::removeOriginAccessWhitelistEntry):
- WebKitTestRunner/InjectedBundle/LayoutTestController.h:
- 10:37 PM Changeset in webkit [85018] by
-
- 2 edits in trunk/LayoutTests
2011-04-26 Dirk Pranke <dpranke@chromium.org>
Unreviewed, expectations change.
Suppress failures resulting from r85011 - probably just needs
new baselines.
- platform/chromium/test_expectations.txt:
- 10:30 PM Changeset in webkit [85017] by
-
- 10 edits in trunk/Source/WebCore
2011-04-26 Justin Novosad <junov@chromium.org>
Reviewed by Kenneth Russell.
[Chromium] Expose skia gpu canvas rendering as a runtime flag
https://bugs.webkit.org/show_bug.cgi?id=58683
Replace the SKIA_GPU compile flag by the pre-existing
acceleratedDrawingEnabled flag. Most code changes are trivial:
compile-time conditionals on SKIA_GPU were either replaced with
a run-time check, or a compile time check on USE(SKIA)
No new tests. Covered by existing tests.
- html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::setGlobalCompositeOperation):
- page/Page.cpp: (WebCore::Page::sharedGraphicsContext3D): Added check for the acceleratedDrawing flag.
- platform/graphics/chromium/DrawingBufferChromium.cpp: (WebCore::DrawingBuffer::DrawingBuffer): (WebCore::DrawingBuffer::publishToPlatformLayer):
- platform/graphics/gpu/DrawingBuffer.h:
- platform/graphics/gpu/SharedGraphicsContext3D.cpp: (WebCore::SharedGraphicsContext3D::create): On Skia builds, this methos now receives a bool arg to turn on GPU-accelerated skia rendering (WebCore::SharedGraphicsContext3D::SharedGraphicsContext3D): (WebCore::SharedGraphicsContext3D::~SharedGraphicsContext3D): (WebCore::SharedGraphicsContext3D::grContext):
- platform/graphics/gpu/SharedGraphicsContext3D.h:
- platform/graphics/skia/ImageSkia.cpp: (WebCore::computeResamplingMode): (WebCore::paintSkBitmap): (WebCore::Image::drawPattern):
- platform/graphics/skia/PlatformContextSkia.cpp: (WebCore::PlatformContextSkia::PlatformContextSkia): (WebCore::PlatformContextSkia::~PlatformContextSkia): (WebCore::PlatformContextSkia::isNativeFontRenderingAllowed): (WebCore::PlatformContextSkia::setSharedGraphicsContext3D): (WebCore::PlatformContextSkia::prepareForSoftwareDraw): (WebCore::PlatformContextSkia::prepareForHardwareDraw): (WebCore::PlatformContextSkia::syncSoftwareCanvas): (WebCore::PlatformContextSkia::markDirtyRect):
- platform/graphics/skia/PlatformContextSkia.h: (WebCore::PlatformContextSkia::accelerationMode): (WebCore::PlatformContextSkia::useGPU): (WebCore::PlatformContextSkia::useSkiaGPU):
- 10:11 PM Changeset in webkit [85016] by
-
- 3 edits1 move in trunk
2011-04-26 Pavel Feldman <pfeldman@chromium.org>
Not reviewed: restore inspector test disabled in r84913.
Test: http/tests/inspector-enabled/dom-storage-open.html
- inspector/InspectorDOMStorageAgent.cpp: (WebCore::InspectorDOMStorageAgent::clearFrontend):
- 10:07 PM Changeset in webkit [85015] by
-
- 3 edits in trunk/LayoutTests
2011-04-26 Ami Fischman <fischman@google.com>
Reviewed by David Levin.
Fix media/video-controls-transformed.html layouttest to compute the click
location of the play button instead of hard-coding pixel values that have
been wrong for a long time. Start expecting the test to pass in chromium
(it's currently Skipped on all platforms).
https://bugs.webkit.org/show_bug.cgi?id=58590
- media/video-controls-transformed.html:
- platform/chromium/test_expectations.txt:
- 9:55 PM Changeset in webkit [85014] by
-
- 2 edits in trunk/LayoutTests
2011-04-26 Dirk Pranke <dpranke@chromium.org>
Unreviewed, expectations change. Update w/ more flakiness.
- platform/chromium/test_expectations.txt:
- 9:49 PM Changeset in webkit [85013] by
-
- 5 edits5 adds in trunk
2011-04-26 Kenichi Ishibashi <bashi@chromium.org>
Reviewed by Tony Chang.
[Chromium] Vertical positions are off for some Arabic glyphs on Linux
https://bugs.webkit.org/show_bug.cgi?id=59182
Add a test for checking vertical offsets of Arabic script shaping.
The font which is used in the test was created from scratch.
- platform/chromium-linux/fast/text/international/arabic-vertical-offset-expected.png: Added.
- platform/chromium-linux/fast/text/international/arabic-vertical-offset-expected.txt: Added.
- platform/chromium-linux/fast/text/international/arabic-vertical-offset.html: Added.
- platform/chromium-linux/fast/text/international/resources/font-for-arabic-offset-test.ttf: Added.
2011-04-26 Kenichi Ishibashi <bashi@chromium.org>
Reviewed by Tony Chang.
[Chromium] Vertical positions are off for some Arabic glyphs on Linux
https://bugs.webkit.org/show_bug.cgi?id=59182
Use vertical offsets of the shaping results.
Test: platform/chromium-linux/fast/text/international/arabic-vertical-offset.html
- platform/graphics/chromium/ComplexTextControllerLinux.cpp: (WebCore::ComplexTextController::ComplexTextController): Added initialization of m_startingY. (WebCore::ComplexTextController::nextScriptRun): Followed the change in handling positions. (WebCore::ComplexTextController::deleteGlyphArrays): Ditto. (WebCore::ComplexTextController::createGlyphArrays): Ditto. (WebCore::ComplexTextController::resetGlyphArrays): Ditto. (WebCore::ComplexTextController::setGlyphPositions): Changed to use vertical offsets as same as horizontal offsets.
- platform/graphics/chromium/ComplexTextControllerLinux.h: Removed m_xPositions and Added m_positions and m_startingY. (WebCore::ComplexTextController::positions): Added.
- platform/graphics/chromium/FontLinux.cpp: Followed the change in ComplexTextController. (WebCore::Font::drawComplexText): Ditto. (WebCore::Font::floatWidthForComplexText): Ditto. (WebCore::glyphIndexForXPositionInScriptRun): Ditto. (WebCore::Font::offsetForPositionForComplexText): Ditto. (WebCore::Font::selectionRectForComplexText): Ditto.
- 9:44 PM Changeset in webkit [85012] by
-
- 3 edits1 add in trunk/LayoutTests
2011-04-26 Tony Chang <tony@chromium.org>
Reviewed by Ojan Vafai.
Fix http/tests/security/cross-frame-access-document-direct.html timeout in chromium
https://bugs.webkit.org/show_bug.cgi?id=59376
- http/tests/security/cross-frame-access-document-direct.html: Include a try/catch for invalid access.
- platform/chromium/http/tests/security/cross-frame-access-document-direct-expected.txt: Added. Chromium includes a console.log
statement of the invalid access.
- platform/chromium/test_expectations.txt: Remove passing test.
- 9:33 PM Changeset in webkit [85011] by
-
- 54 edits4 adds in trunk
2011-04-26 Levi Weintraub <leviw@chromium.org>
Reviewed by Eric Seidel.
Root element should establish a new block formatting context
https://bugs.webkit.org/show_bug.cgi?id=54573
Always expanding the root render object to enclose overhanging floats.
- fast/backgrounds/size/contain-and-cover-expected.txt:
- fast/block/float/float-overhangs-root.html: Added.
- platform/mac/compositing/direct-image-compositing-expected.txt:
- platform/mac/css2.1/t0905-c414-flt-00-d-expected.txt:
- platform/mac/css2.1/t0905-c414-flt-01-d-g-expected.txt:
- platform/mac/css2.1/t0905-c414-flt-02-c-expected.txt:
- platform/mac/css2.1/t0905-c414-flt-03-c-expected.txt:
- platform/mac/css2.1/t0905-c414-flt-04-c-expected.txt:
- platform/mac/css2.1/t0905-c414-flt-wrap-01-d-g-expected.txt:
- platform/mac/css2.1/t0905-c5525-fltcont-00-d-g-expected.txt:
- platform/mac/css2.1/t0905-c5525-fltwidth-02-c-g-expected.txt:
- platform/mac/css2.1/t0905-c5525-fltwidth-03-c-g-expected.txt:
- platform/mac/css2.1/t090501-c414-flt-02-d-g-expected.txt:
- platform/mac/css2.1/t090501-c414-flt-03-b-g-expected.txt:
- platform/mac/fast/backgrounds/background-position-parsing-expected.txt:
- platform/mac/fast/backgrounds/repeat/mask-negative-offset-repeat-expected.txt:
- platform/mac/fast/backgrounds/repeat/negative-offset-repeat-expected.txt:
- platform/mac/fast/block/float/008-expected.txt:
- platform/mac/fast/block/float/029-expected.txt:
- platform/mac/fast/block/float/031-expected.txt:
- platform/mac/fast/block/float/033-expected.txt:
- platform/mac/fast/block/float/035-expected.txt:
- platform/mac/fast/block/float/clamped-right-float-expected.txt:
- platform/mac/fast/block/float/float-forced-below-other-floats-expected.txt:
- platform/mac/fast/block/float/float-overhangs-root-expected.checksum: Added.
- platform/mac/fast/block/float/float-overhangs-root-expected.png: Added.
- platform/mac/fast/block/float/float-overhangs-root-expected.txt: Added.
- platform/mac/fast/block/float/nested-clearance-expected.txt:
- platform/mac/fast/block/margin-collapse/062-expected.txt:
- platform/mac/fast/block/margin-collapse/063-expected.txt:
- platform/mac/fast/blockflow/block-level-images-expected.txt:
- platform/mac/fast/blockflow/floats-in-block-layout-expected.txt:
- platform/mac/fast/borders/bidi-012-expected.txt:
- platform/mac/fast/box-shadow/basic-shadows-expected.txt:
- platform/mac/fast/css/color-correction-on-background-image-expected.txt:
- platform/mac/fast/css/h1-in-section-elements-expected.txt:
- platform/mac/fast/forms/basic-textareas-quirks-expected.txt:
- platform/mac/fast/inline/inline-box-background-expected.txt:
- platform/mac/fast/inline/inline-box-background-long-image-expected.txt:
- platform/mac/fast/inline/inline-box-background-repeat-x-expected.txt:
- platform/mac/fast/inline/inline-box-background-repeat-y-expected.txt:
- platform/mac/fast/lists/003-expected.txt:
- platform/mac/fast/lists/003-vertical-expected.txt:
- platform/mac/fast/media/mq-relative-constraints-08-expected.txt:
- platform/mac/fast/repaint/box-shadow-h-expected.txt:
- platform/mac/fast/repaint/box-shadow-v-expected.txt:
- platform/mac/fast/repaint/subtree-root-clip-expected.txt:
- platform/mac/fast/text/emphasis-expected.txt:
- platform/mac/fast/text/emphasis-vertical-expected.txt:
- platform/mac/fast/text/whitespace/012-expected.txt:
- platform/mac/tables/mozilla/bugs/bug120364-expected.txt:
- platform/mac/tables/mozilla/bugs/bug45055-2-expected.txt:
- platform/mac/tables/mozilla/bugs/bug72359-expected.txt:
- platform/mac/tables/mozilla/marvin/x_table_align_left-expected.txt:
- platform/mac/tables/mozilla/marvin/x_table_align_right-expected.txt:
2011-04-26 Levi Weintraub <leviw@chromium.org>
Reviewed by Eric Seidel.
Root element should establish a new block formatting context
https://bugs.webkit.org/show_bug.cgi?id=54573
Always expanding the root renderer to include overhanging floats.
Test: fast/block/float/float-overhangs-root.html
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::expandsToEncloseOverhangingFloats):
- 9:31 PM Changeset in webkit [85010] by
-
- 1 edit1 add in branches/chromium/742
2011-04-26 James Robinson <jamesr@chromium.org>
Reviewed by Dimitri Glazkov.
[chromium] Add codereview.settings to the 742 branch so drover works properly
https://bugs.webkit.org/show_bug.cgi?id=59578
- codereview.settings: Added.
- 9:29 PM Changeset in webkit [85009] by
-
- 3 edits2 adds in trunk
2011-04-26 Dawit Alemayehu <adawit@kde.org>
Reviewed by Andreas Kling.
Added qtwebkit layout test for the button line break fix (Bug 50521).
[Qt] Improper rendering of <button> tag when it contains a <br>
https://bugs.webkit.org/show_bug.cgi?id=50521
- platform/qt/fast/forms/button-line-break-expected.txt: Added.
- platform/qt/fast/forms/button-line-break.html: Added.
2011-04-26 Dawit Alemayehu <adawit@kde.org>
Reviewed by Andreas Kling.
[Qt] Improper rendering of <button> tag when it contains a <br>
https://bugs.webkit.org/show_bug.cgi?id=50521
Test: platform/qt/fast/forms/button-line-break.html
- platform/qt/RenderThemeQt.cpp: (WebCore::RenderThemeQt::computeSizeBasedOnStyle): (WebCore::RenderThemeQt::setButtonPadding):
- 9:10 PM Changeset in webkit [85008] by
-
- 2 edits in trunk/Websites/webkit.org
2011-04-26 Carol Szabo <carol.szabo@nokia.com>
Reviewed by Tor Arne Vestbø.
Added instructions on how to work from behind proxy
and detailed the instructions refering to rebasing.
Windows build instructions do not work if you are behind a proxy
or have a Temp directory that you do not own directly.
https://bugs.webkit.org/show_bug.cgi?id=57246
- building/tools.html:
- 8:50 PM Changeset in webkit [85007] by
-
- 5 edits in trunk
2011-04-26 Chris Fleizach <Chris Fleizach>
Reviewed by Adele Peterson.
AX: Add more text marker routines to DRT
https://bugs.webkit.org/show_bug.cgi?id=58949
- platform/mac/accessibility/textmarker-string-for-range-expected.txt: Added.
- platform/mac/accessibility/textmarker-string-for-range.html: Added.
2011-04-26 Chris Fleizach <Chris Fleizach>
Reviewed by Adele Peterson.
AX: Add more text marker routines to DRT
https://bugs.webkit.org/show_bug.cgi?id=58949
Add a few more methods to help test the text marker system, including nextMarker, previousMarker and
stringForMarkerRange.
- DumpRenderTree/AccessibilityUIElement.cpp: (nextTextMarkerCallback): (previousTextMarkerCallback): (stringForTextMarkerRangeCallback): (AccessibilityUIElement::previousTextMarker): (AccessibilityUIElement::nextTextMarker): (AccessibilityUIElement::stringForTextMarkerRange): (AccessibilityUIElement::getJSClass):
- DumpRenderTree/AccessibilityUIElement.h:
- DumpRenderTree/mac/AccessibilityUIElementMac.mm: (AccessibilityUIElement::previousTextMarker): (AccessibilityUIElement::nextTextMarker): (AccessibilityUIElement::stringForTextMarkerRange):
- 8:30 PM Changeset in webkit [85006] by
-
- 2 edits in trunk/LayoutTests
2011-04-26 Dirk Pranke <dpranke@chromium.org>
Unreviewed, even more expectations change for flaky tests.
- platform/chromium/test_expectations.txt:
- 8:14 PM Changeset in webkit [85005] by
-
- 2 edits in trunk/LayoutTests
2011-04-26 Dirk Pranke <dpranke@chromium.org>
Unreviewed, expectations change for flaky and passing tests.
- platform/chromium/test_expectations.txt:
- 7:09 PM Changeset in webkit [85004] by
-
- 3 edits in branches/chromium/742/Source/WebCore
Merge 85002 - 2011-04-26 James Robinson <jamesr@chromium.org> Reviewed by Kenneth Russell. [chromium] Only reset tiles if the LayerRendererChromium is actually changing https://bugs.webkit.org/show_bug.cgi?id=59572 http://trac.webkit.org/changeset/84981/ caused us to reset the tiles when LayerRendererChromium was set. We set this pointer every frame and should only reset the tiles if the new LayerRendererChromium is different from the old one (indicating a context loss), not just reset on every frame. * platform/graphics/chromium/LayerTilerChromium.cpp: (WebCore::LayerTilerChromium::setLayerRenderer): * platform/graphics/chromium/LayerTilerChromium.h:
TBR=jamesr@google.com
BUG=78880
- 7:07 PM Changeset in webkit [85003] by
-
- 10 edits in trunk
Build fix.
Source/JavaScriptGlue:
- Configurations/CompilerVersion.xcconfig:
Source/ThirdParty/ANGLE:
- Configurations/CompilerVersion.xcconfig:
Source/WebKit2:
- Configurations/CompilerVersion.xcconfig:
Tools:
- DumpRenderTree/mac/Configurations/CompilerVersion.xcconfig:
- MiniBrowser/Configurations/CompilerVersion.xcconfig:
- WebKitTestRunner/Configurations/CompilerVersion.xcconfig:
- 7:06 PM Changeset in webkit [85002] by
-
- 3 edits in trunk/Source/WebCore
2011-04-26 James Robinson <jamesr@chromium.org>
Reviewed by Kenneth Russell.
[chromium] Only reset tiles if the LayerRendererChromium is actually changing
https://bugs.webkit.org/show_bug.cgi?id=59572
http://trac.webkit.org/changeset/84981/ caused us to reset the tiles
when LayerRendererChromium was set. We set this pointer every frame
and should only reset the tiles if the new LayerRendererChromium is
different from the old one (indicating a context loss), not just reset
on every frame.
- platform/graphics/chromium/LayerTilerChromium.cpp: (WebCore::LayerTilerChromium::setLayerRenderer):
- platform/graphics/chromium/LayerTilerChromium.h:
- 7:00 PM Changeset in webkit [85001] by
-
- 10 edits2 adds in trunk/Source/WebKit/chromium
2011-04-26 Dirk Pranke <dpranke@chromium.org>
Unreviewed, rolling out r84982.
http://trac.webkit.org/changeset/84982
https://bugs.webkit.org/show_bug.cgi?id=59558
re-land r84951
- WebKit.gyp:
- public/WebFrame.h:
- public/WebWidget.h:
- public/mac/WebSubstringUtil.h: Added.
- src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::firstRectForCharacterRange): (WebKit::WebFrameImpl::characterIndexForPoint):
- src/WebFrameImpl.h:
- src/WebPopupMenuImpl.cpp: (WebKit::WebPopupMenuImpl::compositionRange): (WebKit::WebPopupMenuImpl::caretOrSelectionRange):
- src/WebPopupMenuImpl.h:
- src/WebViewImpl.cpp: (WebKit::WebViewImpl::compositionRange): (WebKit::WebViewImpl::caretOrSelectionRange):
- src/WebViewImpl.h:
- src/mac/WebSubstringUtil.mm: Added. (WebKit::WebSubstringUtil::attributedSubstringInRange):
- 6:41 PM Changeset in webkit [85000] by
-
- 2 edits in trunk/Source/JavaScriptCore
2011-04-26 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r84977.
http://trac.webkit.org/changeset/84977
https://bugs.webkit.org/show_bug.cgi?id=59568
caused crashes on the SL WK2 bots (Requested by jessieberlin
on #webkit).
- assembler/MacroAssemblerX86_64.h: (JSC::MacroAssemblerX86_64::call): (JSC::MacroAssemblerX86_64::tailRecursiveCall): (JSC::MacroAssemblerX86_64::makeTailRecursiveCall):
- 6:28 PM Changeset in webkit [84999] by
-
- 5 edits2 adds in trunk
2011-04-26 Dinesh K Garg <dineshg@codeaurora.org>
Reviewed by Eric Seidel.
Test case for: beginElement broken by setAttribute
https://bugs.webkit.org/show_bug.cgi?id=26019
- svg/animations/animate-beginElementAt-expected.txt: Added.
- svg/animations/animate-beginElementAt.svg: Added.
- svg/animations/animate-dynamic-update-attributeName-expected.txt: Nice side effect of the patch, we are now fully passing this test.
2011-04-26 Dinesh K Garg <dineshg@codeaurora.org>
Reviewed by Eric Seidel.
beginElement broken by setAttribute
https://bugs.webkit.org/show_bug.cgi?id=26019
Test: svg/animations/animate-beginElementAt.svg
- svg/SVGAnimationElement.cpp: (WebCore::SVGAnimationElement::attributeChanged): Reset the animation state here as the rest of the code reads it and would still think we are animating when we are not.
- svg/animation/SVGSMILElement.h: (WebCore::SVGSMILElement::setInactive): Helper function to reset the state.
- 6:19 PM Changeset in webkit [84998] by
-
- 5 edits in trunk/LayoutTests
Fixed a few flaky tests, noticed while working on new-run-webkit-tests.
Reviewed by Oliver Hunt.
- accessibility/image-link.html: Wait until the load event fires before
traversing the AX tree, since the the tree will be different after our
subresources load.
- fast/dom/StyleSheet/detached-style-pi-expected.txt:
- fast/dom/StyleSheet/detached-style-pi.xhtml: Wait until the load event
fires before traversing the style tree, since the the tree will be
different after our subresources load.
- platform/mac/test_expectations.txt: Expect success for two extra tests,
since they pass when you have the right fonts.
- 6:16 PM Changeset in webkit [84997] by
-
- 6 edits in trunk/Source/WebKit2
Fix 32-bit clang build.
- PluginProcess/mac/PluginProcessMac.mm:
(WebKit::windowCoversAnyScreen):
- UIProcess/API/mac/WKTextInputWindowController.mm:
(-[WKTextInputPanel init]):
- WebProcess/FullScreen/mac/WebFullScreenManagerMac.mm:
(WebKit::WebFullScreenManagerMac::beginExitFullScreenAnimation):
- WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:
(WebKit::flipScreenYCoordinate):
(WebKit::computeFakeWindowBoundsRect):
- WebProcess/WebPage/mac/AccessibilityWebPageObject.mm:
(-[AccessibilityWebPageObject accessibilityHitTest:]):
- 6:15 PM Changeset in webkit [84996] by
-
- 6 edits in trunk/Source/WebCore
2011-04-26 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r84989.
http://trac.webkit.org/changeset/84989
https://bugs.webkit.org/show_bug.cgi?id=59566
REGRESSION (r84989): Lots of vertical text tests failing on
windows (Requested by weinig on #webkit).
- platform/graphics/FontPlatformData.h:
- platform/graphics/win/FontCacheWin.cpp: (WebCore::FontCache::getFontDataForCharacters): (WebCore::FontCache::createFontPlatformData):
- platform/graphics/win/FontCustomPlatformData.cpp: (WebCore::FontCustomPlatformData::fontPlatformData):
- platform/graphics/win/FontPlatformDataCGWin.cpp: (WebCore::FontPlatformData::FontPlatformData):
- platform/graphics/win/FontPlatformDataWin.cpp: (WebCore::FontPlatformData::FontPlatformData):
- 6:14 PM Changeset in webkit [84995] by
-
- 2 edits in trunk/LayoutTests
2011-04-26 Dirk Pranke <dpranke@chromium.org>
Unreviewed, expectations change. Remove tests that are passing.
- platform/chromium/test_expectations.txt:
- 6:08 PM Changeset in webkit [84994] by
-
- 7 edits6 adds in trunk
Rubberstamped by Eric Seidel.
Enable waf to be used to build other ports
https://bugs.webkit.org/show_bug.cgi?id=58213
- 5:55 PM Changeset in webkit [84993] by
-
- 2 edits in branches/chromium/742/Source/WebCore
Merge 84981 - 2011-04-26 James Robinson <jamesr@chromium.org> Reviewed by Kenneth Russell. [chromium] Clear out LayerTilerChromium's tiles on lost context https://bugs.webkit.org/show_bug.cgi?id=59233 Clears out the LayerTilerChromium's tile set when the LayerRendererChromium is reset. In this case the tiles are no longer valid since they exist in the previous LayerRendererChromium. Will be tested by a chrome test since we don't have any way to exercise the context lost case in layout tests. * platform/graphics/chromium/LayerTilerChromium.h: (WebCore::LayerTilerChromium::setLayerRenderer):
TBR=jamesr@google.com
BUG=78880
- 5:53 PM Changeset in webkit [84992] by
-
- 4 edits in trunk/Source/WebCore
Try again:
Remove JSDOMWrapperWithGlobalPointer now that all JSDOMWrappers have global objects
https://bugs.webkit.org/show_bug.cgi?id=59310
Reviewed by Eric Seidel.
- bindings/js/JSDOMBinding.h:
(WebCore::DOMConstructorObject::DOMConstructorObject):
- bindings/js/JSDOMWrapper.h:
(WebCore::JSDOMWrapper::globalObject):
(WebCore::JSDOMWrapper::scriptExecutionContext):
(WebCore::JSDOMWrapper::createStructure):
(WebCore::JSDOMWrapper::JSDOMWrapper):
- bindings/scripts/CodeGeneratorJS.pm:
- 5:51 PM Changeset in webkit [84991] by
-
- 41 edits31 deletes in trunk
2011-04-26 Sam Weinig <sam@webkit.org>
Reviewed by David Hyatt.
Remove Datagrid from the tree
https://bugs.webkit.org/show_bug.cgi?id=59543
- Scripts/build-webkit: Remove feature.
- iExploder/iexploder-1.3.2/htdocs/htmltags.in:
- iExploder/iexploder-1.7.2/src/html-tags/webkit: Remove from fuzzer.
2011-04-26 Sam Weinig <sam@webkit.org>
Reviewed by David Hyatt.
Remove Datagrid from the tree
https://bugs.webkit.org/show_bug.cgi?id=59543
- Configurations/FeatureDefines.xcconfig: Remove feature.
2011-04-26 Sam Weinig <sam@webkit.org>
Reviewed by David Hyatt.
Remove Datagrid from the tree
https://bugs.webkit.org/show_bug.cgi?id=59543
- features.gypi: Remove feature.
2011-04-26 Sam Weinig <sam@webkit.org>
Reviewed by David Hyatt.
Remove Datagrid from the tree
https://bugs.webkit.org/show_bug.cgi?id=59543
- Configurations/FeatureDefines.xcconfig: Remove feature.
2011-04-26 Sam Weinig <sam@webkit.org>
Reviewed by David Hyatt.
Remove Datagrid from the tree
https://bugs.webkit.org/show_bug.cgi?id=59543
- Android.derived.jscbindings.mk:
- Android.derived.v8bindings.mk:
- Android.jscbindings.mk:
- Android.v8bindings.mk:
- CMakeLists.txt:
- CodeGenerators.pri:
- Configurations/FeatureDefines.xcconfig:
- DerivedSources.cpp:
- DerivedSources.make:
- GNUmakefile.am:
- GNUmakefile.list.am:
- UseJSC.cmake:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSBindingsAllInOne.cpp:
- bindings/js/JSDataGridColumnListCustom.cpp: Removed.
- bindings/js/JSDataGridDataSource.cpp: Removed.
- bindings/js/JSDataGridDataSource.h: Removed.
- bindings/js/JSHTMLDataGridElementCustom.cpp: Removed.
- bindings/v8/V8DataGridDataSource.cpp: Removed.
- bindings/v8/V8DataGridDataSource.h: Removed.
- bindings/v8/custom/V8DataGridColumnListCustom.cpp: Removed.
- bindings/v8/custom/V8HTMLDataGridElementCustom.cpp: Removed.
- css/CSSStyleSelector.cpp:
- css/CSSStyleSelector.h:
- css/html.css: (input, textarea, keygen, select, button, isindex): (select:disabled, keygen:disabled, optgroup:disabled, option:disabled):
- editing/htmlediting.cpp: (WebCore::canHaveChildrenForEditing):
- features.pri:
- html/DOMDataGridDataSource.cpp: Removed.
- html/DOMDataGridDataSource.h: Removed.
- html/DataGridColumn.cpp: Removed.
- html/DataGridColumn.h: Removed.
- html/DataGridColumn.idl: Removed.
- html/DataGridColumnList.cpp: Removed.
- html/DataGridColumnList.h: Removed.
- html/DataGridColumnList.idl: Removed.
- html/DataGridDataSource.h: Removed.
- html/HTMLDataGridCellElement.cpp: Removed.
- html/HTMLDataGridCellElement.h: Removed.
- html/HTMLDataGridCellElement.idl: Removed.
- html/HTMLDataGridColElement.cpp: Removed.
- html/HTMLDataGridColElement.h: Removed.
- html/HTMLDataGridColElement.idl: Removed.
- html/HTMLDataGridElement.cpp: Removed.
- html/HTMLDataGridElement.h: Removed.
- html/HTMLDataGridElement.idl: Removed.
- html/HTMLDataGridRowElement.cpp: Removed.
- html/HTMLDataGridRowElement.h: Removed.
- html/HTMLDataGridRowElement.idl: Removed.
- html/HTMLElement.cpp: (WebCore::HTMLElement::ieForbidsInsertHTML):
- html/HTMLElementsAllInOne.cpp:
- html/HTMLTagNames.in:
- page/DOMWindow.idl:
- rendering/RenderBox.cpp: (WebCore::RenderBox::sizesToIntrinsicLogicalWidth):
- rendering/RenderDataGrid.cpp: Removed.
- rendering/RenderDataGrid.h: Removed.
- rendering/RenderingAllInOne.cpp:
2011-04-26 Sam Weinig <sam@webkit.org>
Reviewed by David Hyatt.
Remove Datagrid from the tree
https://bugs.webkit.org/show_bug.cgi?id=59543
- Configurations/FeatureDefines.xcconfig: Remove feature.
- 5:29 PM Changeset in webkit [84990] by
-
- 7 edits in trunk
2011-04-26 Brent Fulgham <bfulgham@webkit.org>
Reviewed by Adam Roben.
Implement a transparent WebView under Windows. This feature
allows the user to create small web-based applications, similar
to the dashboard on Mac OS X.
https://bugs.webkit.org/show_bug.cgi?id=58300
- Interfaces/IWebViewPrivate.idl: Add new set/get accessors to change the state of a WebView into a Layered Window, or back into a standard window.
- Interfaces/WebKit.idl: touch to force clean build
- WebView.cpp: (WebView::WebView): Set layered window state in constructor. (WebView::updateBackingStore): Cleanup old bitmap when finished. (WebView::performLayeredWindowUpdate): New method to do the work of calling ::UpdateLayeredWindow for the WebView with proper alpha blending. (WebView::paint): Small change to prevent accelerated compositing when using a layered window. DirectX is not compatible with ::UpdateLayeredWindow (at least currently). (WebView::WebViewWndProc): Adjust main window procedure to avoid painting a default background on a layered window (this is handled by Windows during compositing), and to deal with paint messages properly in the layered window case. (WebView::active): The layered window is not a child window, so the active state logic is slightly different. (WebView::setUsesLayeredWindow): New set method for layered stated. When called, it will convert a WebView into a Layered Window. (WebView::usesLayeredWindow): Accessor
- WebView.h: (WebView::setUsesLayeredWindow): Declare new accessor (WebView::usesLayeredWindow): Declare new accessor
2011-04-26 Brent Fulgham <bfulgham@webkit.org>
Reviewed by Adam Roben.
Update WinLauncher with command-line arguments to allow the
transparency to be tested. Use --transparent to create a
transparent view. Use --desktop to have the view fill the
desktop area of the screen.
https://bugs.webkit.org/show_bug.cgi?id=58300
- WinLauncher/WinLauncher.cpp: (usesLayeredWebView): New method to indicate that the program is running with layered windows (alpha-blended transparent windows). (shouldUseFullDesktop): New method to indicate that the program is running across the full desktop (less any task bars.) (resizeSubViews): Layered window mode doesn't have any winapi child windows, so this routine is exited early for that case. (subclassForLayeredWindow): Subclass the window so we can override its defaut message loop. (computeFullDesktopFrame): Convenience function to get the desktop region and update the frame dimensions appropriately. (_tWinMain): Updated to accept the new '--transparent' and '--desktop' arguments. (InitInstance): Modified to exit early for the transparent background case. WebKit will construct our primary window (with appropriate settings) so we don't need to create one ourselves. (WndProc): (TransparentWndProc): New message loop for transparent windows, since they need special handling to support dragging.
- 5:17 PM April 2011 Meeting edited by
- (diff)
- 5:17 PM Changeset in webkit [84989] by
-
- 6 edits in trunk/Source/WebCore
2011-04-26 Chun-Lung Huang <alvincl.huang@gmail.com>
Reviewed by Adele Peterson.
On WebKit (Windows), glyphs in vertical text tests are rotated 90
degrees clockwise. https://bugs.webkit.org/show_bug.cgi?id=48459
This platform dependent patch makes WebKit (Windows) show the
vertical writing text correctly. Job was done by adding a prefix '@'
in front of the font family name (Windows Only). No new tests added.
Some layout tests images:
http://www.flickr.com/photos/burorly/sets/72157625585506341/
- platform/graphics/FontPlatformData.h:
- platform/graphics/win/FontCacheWin.cpp: (WebCore::FontCache::getFontDataForCharacters): (WebCore::FontCache::createFontPlatformData):
- platform/graphics/win/FontCustomPlatformData.cpp: (WebCore::FontCustomPlatformData::fontPlatformData):
- platform/graphics/win/FontPlatformDataCGWin.cpp: (WebCore::FontPlatformData::FontPlatformData):
- platform/graphics/win/FontPlatformDataWin.cpp: (WebCore::FontPlatformData::FontPlatformData):
- 5:15 PM Changeset in webkit [84988] by
-
- 5 edits in trunk/Source/WebCore
2011-04-26 Jer Noble <jer.noble@apple.com>
Reviewed by Brady Eidson.
HTML5 video fullscreen transition causes an audio stutter
https://bugs.webkit.org/show_bug.cgi?id=59544
AVFoundation will momentarily stutter when you disconnect a AVPlayerLayer
from its AVPlayer. Since you shouldn't necessarily have to destroy the
layer to render it invisible, instead just set the layer as hidden.
- platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp: (WebCore::MediaPlayerPrivateAVFoundation::setVisible): Call through to platformSetVisible().
- platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
- platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.h:
- platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.mm: (WebCore::MediaPlayerPrivateAVFoundationObjC::platformSetVisible): Added.
- 5:07 PM Changeset in webkit [84987] by
-
- 4 edits in trunk
2011-04-26 Alejandro G. Castro <alex@igalia.com>
Remove gtk specific render expectations after the tests were
converted in text tests (r84873).
- platform/gtk/animations/animation-drt-api-expected.txt: Removed.
- platform/gtk/animations/animation-drt-api-multiple-keyframes-expected.txt: Removed.
2011-04-26 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[GTK] flaky crash storage/open-database-set-empty-version.html
https://bugs.webkit.org/show_bug.cgi?id=58988
Construct the security origin directly instead of getting it from the WebKitWebFrame object.
This prevents failing to create the WebKitSecurityOrigin in cases where the frame is in
some inconsistent state.
- WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::exceededDatabaseQuota): Construct the origin directly.
- 5:06 PM Changeset in webkit [84986] by
-
- 2 edits in trunk/Source/JavaScriptCore
2011-04-26 Adrienne Walker <enne@google.com>
Reviewed by Geoffrey Garen.
Fix incorrect use of OwnPtr<T*> in GCActivityCallback
https://bugs.webkit.org/show_bug.cgi?id=59559
- runtime/GCActivityCallback.h:
- 5:05 PM Changeset in webkit [84985] by
-
- 2 edits in trunk/Tools
2011-04-26 Alexandre MAzari <amazari@igalia.com>
Reviewed by Xan Lopez.
[Gtk] Implement LayoutTestController::setPluginsEnabled
https://bugs.webkit.org/show_bug.cgi?id=59184
- DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::setPluginsEnabled):
- 5:01 PM Changeset in webkit [84984] by
-
- 1 edit2 deletes in trunk/LayoutTests
2011-04-26 Alejandro G. Castro <alex@igalia.com>
Remove gtk specific render expectations after the tests were
converted in text tests (r84873).
- platform/gtk/animations/animation-drt-api-expected.txt: Removed.
- platform/gtk/animations/animation-drt-api-multiple-keyframes-expected.txt: Removed.
- 5:01 PM April 2011 Meeting edited by
- (diff)
- 4:57 PM Changeset in webkit [84983] by
-
- 2 edits in trunk/Source/WebCore
2011-04-26 Christian Dywan <christian@lanedo.com>
Reviewed by Eric Seidel.
Extra separator after Select All in context menu
https://bugs.webkit.org/show_bug.cgi?id=54092
- page/ContextMenuController.cpp: Move separator to non-GTK+
port guards since it is for the spelling options menu
which the GTK+ port doesn't use.
- 4:53 PM Changeset in webkit [84982] by
-
- 10 edits2 deletes in trunk/Source/WebKit/chromium
2011-04-26 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r84951.
http://trac.webkit.org/changeset/84951
https://bugs.webkit.org/show_bug.cgi?id=59558
"breaks chromium compile" (Requested by dpranke on #webkit).
- WebKit.gyp:
- public/WebFrame.h:
- public/WebWidget.h:
- public/mac/WebSubstringUtil.h: Removed.
- src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::firstRectForCharacterRange):
- src/WebFrameImpl.h:
- src/WebPopupMenuImpl.cpp:
- src/WebPopupMenuImpl.h:
- src/WebViewImpl.cpp:
- src/WebViewImpl.h:
- src/mac/WebSubstringUtil.mm: Removed.
- 4:51 PM Changeset in webkit [84981] by
-
- 2 edits in trunk/Source/WebCore
2011-04-26 James Robinson <jamesr@chromium.org>
Reviewed by Kenneth Russell.
[chromium] Clear out LayerTilerChromium's tiles on lost context
https://bugs.webkit.org/show_bug.cgi?id=59233
Clears out the LayerTilerChromium's tile set when the LayerRendererChromium is reset. In this case the tiles are
no longer valid since they exist in the previous LayerRendererChromium.
Will be tested by a chrome test since we don't have any way to exercise the context lost case in layout tests.
- platform/graphics/chromium/LayerTilerChromium.h: (WebCore::LayerTilerChromium::setLayerRenderer):
- 4:43 PM Changeset in webkit [84980] by
-
- 10 edits in trunk
2011-04-26 Chang Shu <cshu@webkit.org>
Reviewed by Laszlo Gombos.
WebKitTestRunner needs layoutTestController.setAllowFileAccessFromFileURLs
https://bugs.webkit.org/show_bug.cgi?id=57572
Remove the unnecessary code that updates preference.
- Shared/WebPreferencesStore.cpp: (WebKit::WebPreferencesStore::decode):
- Shared/WebPreferencesStore.h:
- WebProcess/InjectedBundle/API/c/WKBundle.cpp: (WKBundleSetAllowUniversalAccessFromFileURLs):
- WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:
- WebProcess/InjectedBundle/InjectedBundle.cpp: (WebKit::InjectedBundle::setAllowUniversalAccessFromFileURLs): (WebKit::InjectedBundle::setAllowFileAccessFromFileURLs):
- WebProcess/InjectedBundle/InjectedBundle.h:
2011-04-26 Chang Shu <cshu@webkit.org>
Reviewed by Laszlo Gombos.
WebKitTestRunner needs layoutTestController.setAllowFileAccessFromFileURLs
https://bugs.webkit.org/show_bug.cgi?id=57572
Remove the unnecessary code that updates preference.
- WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: (WTR::InjectedBundle::beginTesting):
- WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: (WTR::LayoutTestController::setAllowUniversalAccessFromFileURLs):
- 4:35 PM Changeset in webkit [84979] by
-
- 4 edits1 add in trunk/Source/WebCore
2011-04-26 Martin Robinson <mrobinson@igalia.com>
Reviewed by Dirk Schulze.
[GTK] Flash in divs with overflow: auto is not positioned and clipped properly
https://bugs.webkit.org/show_bug.cgi?id=57644
Manual test: plugins/windowed-in-iframe-2.html
- manual-tests/plugins/windowed-in-iframe-2.html: Added.
- platform/gtk/WidgetGtk.cpp: (WebCore::Widget::setFrameRect): Like the Qt port, we notify the widget via frameRectsChanged.
- plugins/PluginView.h: Added helper method to set the allocation and clip.
- plugins/gtk/PluginViewGtk.cpp: (WebCore::PluginView::setNPWindowIfNeeded):Call the helper method instead of setting the allocation immediately. Bring this method into sync with the implementation in the Qt port. (WebCore::PluginView::updateWidgetAllocationAndClip): Added. (WebCore::PluginView::plugAddedCallback): Call the new helper method.
- 4:31 PM Changeset in webkit [84978] by
-
- 5 edits in trunk
2011-04-26 Martin Robinson <mrobinson@igalia.com>
Reviewed by Eric Seidel.
[GTK] fast/block/float/overhanging-tall-block.html crashes in the bots
https://bugs.webkit.org/show_bug.cgi?id=58818
- platform/gtk/Skipped: Unskip a test which is no longer crashing.
2011-04-26 Martin Robinson <mrobinson@igalia.com>
Reviewed by Eric Seidel.
[GTK] fast/block/float/overhanging-tall-block.html crashes in the bots
https://bugs.webkit.org/show_bug.cgi?id=58818
Prevent allocating scratch buffers larger than the target GdkDrawable
when creating a WidgetRenderingContext. This prevents incredibly large
widgets from crashing the X Server. This change also allowed greatly
simplifying the way that the painting offset is calculated.
- platform/gtk/WidgetRenderingContext.cpp: (WebCore::WidgetRenderingContext::WidgetRenderingContext): Never allocate a pixmap larger than the target GdkDrawable. (WebCore::WidgetRenderingContext::~WidgetRenderingContext): Calculate the offset of the blit by looking at the location of the target rect itself, rather than delaying the calculation up to this point. (WebCore::WidgetRenderingContext::calculateClipRect): Added. (WebCore::WidgetRenderingContext::gtkPaintBox): Use the new calculateClipRectHelper. (WebCore::WidgetRenderingContext::gtkPaintFlatBox): Ditto. (WebCore::WidgetRenderingContext::gtkPaintFocus): Ditto. (WebCore::WidgetRenderingContext::gtkPaintSlider): Ditto. (WebCore::WidgetRenderingContext::gtkPaintCheck): Ditto. (WebCore::WidgetRenderingContext::gtkPaintOption): Ditto. (WebCore::WidgetRenderingContext::gtkPaintShadow): Ditto. (WebCore::WidgetRenderingContext::gtkPaintArrow): Ditto. (WebCore::WidgetRenderingContext::gtkPaintVLine): Ditto.
- platform/gtk/WidgetRenderingContext.h: Remove some now unused members. Add a member to store the IntSize mapping from the coordinates of the target to the coordinates of the scratch buffer.
- 4:31 PM Changeset in webkit [84977] by
-
- 2 edits in trunk/Source/JavaScriptCore
2011-04-26 Xan Lopez <xlopez@igalia.com>
Reviewed by Daniel Bates.
Unused but set variable warning in MacroAssembelX86_64
https://bugs.webkit.org/show_bug.cgi?id=59482
- assembler/MacroAssemblerX86_64.h: (JSC::MacroAssemblerX86_64::call): do not declare the label variable if we are not going to use it. (JSC::MacroAssemblerX86_64::tailRecursiveCall): ditto. (JSC::MacroAssemblerX86_64::makeTailRecursiveCall): ditto.
- 4:26 PM Changeset in webkit [84976] by
-
- 2 edits in trunk/Source/WebCore
2011-04-26 Patrick Gansterer <Patrick Gansterer>
Reviewed by Adam Barth.
Respect charset in handleDataURL
https://bugs.webkit.org/show_bug.cgi?id=47746
Original patch by Kwang Yul Seo <skyul@company100.net>
We must use TextEncoding(charset) to encode data URL again. Otherwise TextEncoding::encode()
returns an empty string because encoding name is not specified.
Also use "US-ASCII" as fallback charset as extractCharsetFromMediaType can be empty.
This change fixes over 130 layout tests when running GTK port with cURL network backend.
- platform/network/DataURL.cpp: (WebCore::handleDataURL):
- 4:20 PM Changeset in webkit [84975] by
-
- 6 edits1 copy in trunk
2011-04-26 Mario Sanchez Prada <msanchez@igalia.com>
Reviewed by Eric Seidel.
[GTK] accessibility/aria-combobox-expected.txt
https://bugs.webkit.org/show_bug.cgi?id=59399
Unskip the test and provide expectations for Mac and GTK.
- accessibility/aria-combobox.html: Do not check roles to be the right ones, print them and leave the check for the expected file.
- platform/gtk/Skipped: Unskip the test.
- platform/gtk/accessibility/aria-combobox-expected.txt: New.
- platform/mac/accessibility/aria-combobox-expected.txt: Updated.
2011-04-26 Mario Sanchez Prada <msanchez@igalia.com>
Reviewed by Eric Seidel.
[GTK] accessibility/aria-combobox-expected.txt
https://bugs.webkit.org/show_bug.cgi?id=59399
Implement isExpanded(), as it's used in the layout test.
- DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: (AccessibilityUIElement::isExpanded): Implemented.
- 4:18 PM Changeset in webkit [84974] by
-
- 2 edits in trunk/Source/WebKit/qt
2011-04-26 Yi Shen <yi.4.shen@nokia.com>
Reviewed by Tor Arne Vestbø.
[Qt][Symbian] Fix Api test failure -- tst_QWebFrame::setHtmlWithBaseURL
https://bugs.webkit.org/show_bug.cgi?id=56946
Deployed the missing resource for Symbian platform.
- tests/qwebframe/qwebframe.pro:
- 4:18 PM Changeset in webkit [84973] by
-
- 2 edits in trunk/Tools
2011-04-26 Adrienne Walker <enne@google.com>
Reviewed by Kent Tamura.
[chromium] Fix memory leak in DRT due to OwnPtr<T*>
https://bugs.webkit.org/show_bug.cgi?id=59489
- DumpRenderTree/chromium/WebViewHost.h:
- 4:17 PM Changeset in webkit [84972] by
-
- 4 edits in trunk/Source/WebKit/efl
2011-04-26 Grzegorz Czajkowski <g.czajkowski@samsung.com>
Reviewed by Antonio Gomes.
[EFL] Update signals description
https://bugs.webkit.org/show_bug.cgi?id=56904
Add, fix signals description that are emitted by evas_object_smart_callcabck_call in
ewk_view, ewk_frame, ewk_contextmenu.
- ewk/ewk_contextmenu.h:
- ewk/ewk_frame.h:
- ewk/ewk_view.h:
- 4:15 PM Changeset in webkit [84971] by
-
- 3 edits in trunk/Source/WebCore
Fix clang++ build.
You can never have too many casts!
- accessibility/mac/AccessibilityObjectWrapper.mm:
(-[AccessibilityObjectWrapper position]):
- editing/mac/SelectionControllerMac.mm:
(WebCore::accessibilityConvertScreenRect):
- 4:12 PM Changeset in webkit [84970] by
-
- 2 edits in trunk/Source/WebKit2
WebKit2: Docked Inspector doesn't behave well if inspected web view isn't at 0,0
https://bugs.webkit.org/show_bug.cgi?id=59554
<rdar://problem/9341188>
Reviewed by Steve Falkenburg.
Use GetWindowRect and ScreenToClient to properly place our inspector and inspected
web views instead of using GetClientRect. We need to correctly handle the case where
the inspected web view isn't at 0, 0.
- UIProcess/win/WebInspectorProxyWin.cpp:
(WebKit::WebInspectorProxy::platformSetAttachedWindowHeight):
- 4:11 PM Changeset in webkit [84969] by
-
- 5 edits in trunk/Source/WebCore
2011-04-26 Chris Rogers <crogers@google.com>
Reviewed by Kenneth Russell.
Fix web audio build on mac port
https://bugs.webkit.org/show_bug.cgi?id=59355
No new tests since audio API is not yet implemented.
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSAudioContextCustom.cpp: (WebCore::JSAudioContext::visitChildren):
- bindings/js/JSJavaScriptAudioNodeCustom.cpp: (WebCore::JSJavaScriptAudioNode::visitChildren):
- webaudio/AudioContext.idl:
- 4:02 PM April 2011 Meeting edited by
- (diff)
- 4:01 PM Changeset in webkit [84968] by
-
- 7 edits2 adds in trunk/Source/WebCore
2011-04-26 Chris Rogers <crogers@google.com>
Reviewed by Kenneth Russell.
Add FFTFrame implementation for FFmpeg
https://bugs.webkit.org/show_bug.cgi?id=59408
No new tests since audio API is not yet implemented.
- WebCore.gyp/WebCore.gyp:
- WebCore.gypi:
- platform/audio/FFTFrame.h:
- platform/audio/FFTFrameStub.cpp:
- platform/audio/ffmpeg: Added.
- platform/audio/ffmpeg/FFTFrameFFMPEG.cpp: Added. (WebCore::FFTFrame::FFTFrame): (WebCore::FFTFrame::initialize): (WebCore::FFTFrame::cleanup): (WebCore::FFTFrame::~FFTFrame): (WebCore::FFTFrame::multiply): (WebCore::FFTFrame::doFFT): (WebCore::FFTFrame::doInverseFFT): (WebCore::FFTFrame::realData): (WebCore::FFTFrame::imagData): (WebCore::FFTFrame::getUpToDateComplexData): (WebCore::FFTFrame::contextForSize):
- platform/audio/mac/FFTFrameMac.cpp:
- webaudio/ConvolverNode.cpp:
- 3:59 PM Changeset in webkit [84967] by
-
- 3 edits in trunk/Source/WebKit/chromium
2011-04-26 Daniel Cheng <dcheng@chromium.org>
Reviewed by Eric Seidel.
[chromium] Implement EditorClient::canCopyCut and EditorClient::canPaste
https://bugs.webkit.org/show_bug.cgi?id=59264
- public/WebViewClient.h: (WebKit::WebViewClient::canTriggerClipboardRead): (WebKit::WebViewClient::canTriggerClipboardWrite):
- src/EditorClientImpl.cpp: (WebKit::EditorClientImpl::canCopyCut): (WebKit::EditorClientImpl::canPaste):
- 3:58 PM Changeset in webkit [84966] by
-
- 4 edits in trunk
2011-04-26 Mario Sanchez Prada <msanchez@igalia.com>
Reviewed by Eric Seidel.
[GTK] Implement isChecked in DRT
https://bugs.webkit.org/show_bug.cgi?id=59385
- platform/gtk/Skipped: Unskip the layout test accessibility/aria-checkbox-checked.html.
2011-04-26 Mario Sanchez Prada <msanchez@igalia.com>
Reviewed by Eric Seidel.
[GTK] Implement isChecked in DRT
https://bugs.webkit.org/show_bug.cgi?id=59385
- DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: (AccessibilityUIElement::isChecked): Implemented.
- 3:47 PM Changeset in webkit [84965] by
-
- 2 edits in trunk/Tools
2011-04-26 Alejandro G. Castro <alex@igalia.com>
Unreviewed, rolling out r84949.
http://trac.webkit.org/changeset/84949
https://bugs.webkit.org/show_bug.cgi?id=58852
Broke GTK+ compilation
- GtkLauncher/main.c: (main):
- 3:17 PM UsingGitWithWebKit edited by
- Remove warning about first-time webkit-patch use since we hopefully … (diff)
- 3:10 PM Changeset in webkit [84964] by
-
- 2 edits in trunk/LayoutTests
2011-04-26 Alejandro G. Castro <alex@igalia.com>
Skipped insecure-css-in-iframe.html, we are missing
didRunInsecureContent notification.
- platform/gtk/Skipped:
- 3:00 PM Changeset in webkit [84963] by
-
- 1 edit61 adds in trunk/LayoutTests
[Qt] Add platform specific expected results for new passing tests.
- platform/qt/fast/backgrounds/background-leakage-expected.png: Added.
- platform/qt/fast/backgrounds/background-leakage-expected.txt: Added.
- platform/qt/fast/backgrounds/background-leakage-transforms-expected.png: Added.
- platform/qt/fast/backgrounds/background-leakage-transforms-expected.txt: Added.
- platform/qt/fast/backgrounds/gradient-background-leakage-expected.png: Added.
- platform/qt/fast/backgrounds/gradient-background-leakage-expected.txt: Added.
- platform/qt/fast/block/positioning/rtl-fixed-positioning-expected.png: Added.
- platform/qt/fast/block/positioning/rtl-fixed-positioning-expected.txt: Added.
- platform/qt/fast/block/positioning/vertical-rl/fixed-positioning-expected.png: Added.
- platform/qt/fast/block/positioning/vertical-rl/fixed-positioning-expected.txt: Added.
- platform/qt/fast/borders/bidi-002-expected.png: Added.
- platform/qt/fast/borders/bidi-002-expected.txt: Added.
- platform/qt/fast/borders/bidi-009a-expected.png: Added.
- platform/qt/fast/borders/bidi-009a-expected.txt: Added.
- platform/qt/fast/borders/bidi-012-expected.png: Added.
- platform/qt/fast/borders/bidi-012-expected.txt: Added.
- platform/qt/fast/borders/border-radius-different-width-001-expected.png: Added.
- platform/qt/fast/borders/border-radius-different-width-001-expected.txt: Added.
- platform/qt/fast/borders/border-radius-inset-outset-expected.png: Added.
- platform/qt/fast/borders/border-radius-inset-outset-expected.txt: Added.
- platform/qt/fast/borders/mixed-border-styles-expected.png: Added.
- platform/qt/fast/borders/mixed-border-styles-expected.txt: Added.
- platform/qt/fast/borders/mixed-border-styles-radius-expected.png: Added.
- platform/qt/fast/borders/mixed-border-styles-radius-expected.txt: Added.
- platform/qt/fast/borders/table-borders-expected.png: Added.
- platform/qt/fast/borders/table-borders-expected.txt: Added.
- platform/qt/fast/borders/webkit-border-radius-expected.png: Added.
- platform/qt/fast/borders/webkit-border-radius-expected.txt: Added.
- platform/qt/fast/dom/HTMLMeterElement/meter-writing-mode-expected.png: Added.
- platform/qt/fast/dom/HTMLMeterElement/meter-writing-mode-expected.txt: Added.
- platform/qt/fast/dom/HTMLProgressElement/progress-writing-mode-expected.png: Added.
- platform/qt/fast/dom/HTMLProgressElement/progress-writing-mode-expected.txt: Added.
- platform/qt/fast/forms/select-background-none-expected.png: Added.
- platform/qt/fast/forms/select-background-none-expected.txt: Added.
- platform/qt/fast/html/details-add-child-1-expected.png: Added.
- platform/qt/fast/html/details-add-child-1-expected.txt: Added.
- platform/qt/fast/html/details-add-child-2-expected.png: Added.
- platform/qt/fast/html/details-add-child-2-expected.txt: Added.
- platform/qt/fast/html/details-add-summary-child-1-expected.png: Added.
- platform/qt/fast/html/details-add-summary-child-1-expected.txt: Added.
- platform/qt/fast/html/details-add-summary-child-2-expected.png: Added.
- platform/qt/fast/html/details-add-summary-child-2-expected.txt: Added.
- platform/qt/fast/html/details-remove-child-1-expected.png: Added.
- platform/qt/fast/html/details-remove-child-1-expected.txt: Added.
- platform/qt/fast/html/details-remove-child-2-expected.png: Added.
- platform/qt/fast/html/details-remove-child-2-expected.txt: Added.
- platform/qt/fast/html/details-remove-summary-child-1-expected.png: Added.
- platform/qt/fast/html/details-remove-summary-child-1-expected.txt: Added.
- platform/qt/fast/html/details-remove-summary-child-2-expected.png: Added.
- platform/qt/fast/html/details-remove-summary-child-2-expected.txt: Added.
- platform/qt/fast/inline/positioned-object-between-replaced-elements-expected.png: Added.
- platform/qt/fast/inline/positioned-object-between-replaced-elements-expected.txt: Added.
- platform/qt/fast/table/auto-100-percent-width-expected.png: Added.
- platform/qt/fast/table/auto-100-percent-width-expected.txt: Added.
- platform/qt/fast/text/zero-font-size-expected.png: Added.
- platform/qt/fast/text/zero-font-size-expected.txt: Added.
- platform/qt/svg/W3C-SVG-1.1-SE/svgdom-over-01-f-expected.png: Added.
- platform/qt/svg/W3C-SVG-1.1-SE/svgdom-over-01-f-expected.txt: Added.
- platform/qt/svg/filters/feDropShadow-expected.png: Added.
- platform/qt/svg/filters/feDropShadow-expected.txt: Added.
- 2:52 PM Changeset in webkit [84962] by
-
- 2 edits in trunk/LayoutTests
Not reviewed.
Flaky Test: fast/loader/file-protocol-fragment.html
https://bugs.webkit.org/show_bug.cgi?id=59488
- fast/loader/file-protocol-fragment.html:
- 2:49 PM Changeset in webkit [84961] by
-
- 19 edits1 add6 deletes in trunk/LayoutTests
2011-04-26 Simon Fraser <Simon Fraser>
Reviewed by Daniel Bates.
Convert some transition tests to use the pause API, and more cleanup
https://bugs.webkit.org/show_bug.cgi?id=59490
- animations/animation-drt-api.html: Fail message was the same as the pass message (doh!).
- platform/chromium-linux/transitions/transition-drt-api-expected.png: Removed.
- platform/chromium-win/transitions/transition-drt-api-expected.png: Removed.
- platform/chromium-win/transitions/transition-drt-api-expected.txt: Removed.
- platform/gtk/transitions/transition-drt-api-expected.txt: Removed.
- platform/mac/transitions/transition-drt-api-expected.png: Removed.
- platform/mac/transitions/transition-drt-api-expected.txt: Removed.
- transitions/transition-drt-api-expected.txt: Added.
- transitions/transition-drt-api.html: Made into a text test.
- transitions/font-family-during-transition.html: Use the pause API.
- transitions/transition-drt-api-delay.html: General cleanup.
- transitions/bad-transition-shorthand-crash.html: Shorten the test.
- transitions/border-radius-transition.html:
- transitions/default-timing-function.html:
- transitions/interrupt-zero-duration.html: Remove style attribute
- transitions/color-transition-premultiplied.html:
- transitions/transition-timing-function-expected.txt:
- transitions/transition-timing-function.html: Use pause API.
- transitions/inherit-other-props.html:
- transitions/transform-op-list-match.html: Whitespace.
- transitions/opacity-transition-zindex.html: Add FIXME.
- transitions/transition-shorthand-delay-expected.txt:
- transitions/transition-shorthand-delay.html:
- transitions/zero-duration-with-non-zero-delay-start-expected.txt:
- transitions/zero-duration-with-non-zero-delay-start.html: Use runTransitionTest().
- 2:44 PM Changeset in webkit [84960] by
-
- 2 edits in trunk/Source/WebKit/chromium
2011-04-26 Evan Martin <evan@chromium.org>
Unreviewed, Chrome/Mac build fix.
- WebKit.gypi: Remove extra file. (I removed a subtraction, but forgot to remove the corresponding addition that the subtraction was counteracting.)
- 2:43 PM Changeset in webkit [84959] by
-
- 3 edits in trunk/LayoutTests
2011-04-26 Maciej Stachowiak <mjs@apple.com>
Reviewed by Adam Barth.
[Windows and Leopard Tests] media/invalid-media-url-crash.html failing since r84762
https://bugs.webkit.org/show_bug.cgi?id=59324
Use a properly invalid URL, instead of http:aa. This also allows the test to
be unskipped on SL.
- media/invalid-media-url-crash.html:
- platform/mac-snowleopard/Skipped:
- 2:37 PM Changeset in webkit [84958] by
-
- 2 edits in trunk/Source/WebCore
Add a newline at the end of SVGFEDropShadowElement.idl.
- svg/SVGFEDropShadowElement.idl:
- 2:29 PM Changeset in webkit [84957] by
-
- 2 edits in trunk/LayoutTests
2011-04-26 Stephen White <senorblanco@chromium.org>
Unreviewed; chromium test expectations update.
- platform/chromium/test_expectations.txt: fast/css/table-border-spacing.html is flaky in Debug.
- 2:21 PM Changeset in webkit [84956] by
-
- 4 edits in trunk/Source/WebCore
2011-04-26 Mihai Parparita <mihaip@chromium.org>
Reviewed by Eric Seidel.
InlineBox.h shouldn't include RenderBR.h
https://bugs.webkit.org/show_bug.cgi?id=59480
Per bug 59348 RenderBR.h is a "top header" by include * size, because
InlineBox.h includes it. There's no reason why it has to.
- rendering/InlineBox.h:
- rendering/InlineTextBox.cpp:
- rendering/RenderBlock.h:
- 2:21 PM Changeset in webkit [84955] by
-
- 4 edits in trunk/Tools
2011-04-26 Eric Seidel <eric@webkit.org>
Reviewed by Mihai Parparita.
sheriff-bot should have a create-bug command
https://bugs.webkit.org/show_bug.cgi?id=59491
This patch has some stderr unittest spew, but I will
fix it after my live demo.
- Scripts/webkitpy/tool/bot/irc_command.py:
- Scripts/webkitpy/tool/bot/irc_command_unittest.py:
- Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
- 2:15 PM Changeset in webkit [84954] by
-
- 4 edits in trunk/Source/WebCore
Nope, roll out r84950 and r84952. Working on a laptop is clearly not something
I should do.
- bindings/js/JSDOMBinding.h:
(WebCore::JSDOMWrapperWithGlobalPointer::globalObject):
(WebCore::JSDOMWrapperWithGlobalPointer::scriptExecutionContext):
(WebCore::JSDOMWrapperWithGlobalPointer::createStructure):
(WebCore::JSDOMWrapperWithGlobalPointer::JSDOMWrapperWithGlobalPointer):
(WebCore::DOMConstructorObject::DOMConstructorObject):
- bindings/js/JSDOMWrapper.h:
(WebCore::JSDOMWrapper::JSDOMWrapper):
- bindings/scripts/CodeGeneratorJS.pm:
- 2:12 PM Changeset in webkit [84953] by
-
- 3 edits in trunk/Source/WebKit/chromium
2011-04-26 Evan Martin <evan@chromium.org>
Reviewed by Tony Chang.
[chromium] refactor duplicated list of test source files
https://bugs.webkit.org/show_bug.cgi?id=59478
The platform-specific unit test files were listed twice in
WebKit.gyp: once for the components build, once for the normal
build. Refactor this into the unified webkit_unittest_files
variable. (It appears the omission of WebPageSerializerTest
in one instance was an oversight.)
- WebKit.gyp:
- WebKit.gypi:
- 2:06 PM Changeset in webkit [84952] by
-
- 2 edits in trunk/Source/WebCore
Fix build.
- bindings/js/JSDOMWrapper.h:
(WebCore::JSDOMWrapper::globalObject):
- 2:06 PM Changeset in webkit [84951] by
-
- 10 edits2 adds in trunk/Source/WebKit/chromium
2011-04-26 Robert Sesek <rsesek@chromium.org>
Reviewed by Dimitri Glazkov.
[Chromium] Implement WebKit methods to assist with Cocoa NSTextInput implementation
https://bugs.webkit.org/show_bug.cgi?id=54969
- WebKit.gyp:
- public/WebFrame.h:
- public/WebWidget.h:
- public/mac/WebSubstringUtil.h: Added.
- src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::firstRectForCharacterRange): Return the result rect in window coordinates (WebKit::WebFrameImpl::characterIndexForPoint): New method on WebFrame
- src/WebFrameImpl.h:
- src/WebPopupMenuImpl.cpp: (WebKit::WebPopupMenuImpl::compositionRange): New method on WebWidget; empty impl (WebKit::WebPopupMenuImpl::caretOrSelectionRange): New method on WebWidget; empty impl
- src/WebPopupMenuImpl.h:
- src/WebViewImpl.cpp: (WebKit::WebViewImpl::compositionRange): New method on WebWidget (WebKit::WebViewImpl::caretOrSelectionRange): New method on WebWidget
- src/WebViewImpl.h:
- src/mac/WebSubstringUtil.mm: Added. (WebKit::WebSubstringUtil::attributedSubstringInRange):
- 2:01 PM Changeset in webkit [84950] by
-
- 4 edits in trunk/Source/WebCore
Roll r84945 back in with infinite recursion removed.
- bindings/js/JSDOMBinding.h:
(WebCore::DOMConstructorObject::DOMConstructorObject):
- bindings/js/JSDOMWrapper.h:
(WebCore::JSDOMWrapper::globalObject):
(WebCore::JSDOMWrapper::scriptExecutionContext):
(WebCore::JSDOMWrapper::createStructure):
(WebCore::JSDOMWrapper::JSDOMWrapper):
- bindings/scripts/CodeGeneratorJS.pm:
- 1:58 PM Changeset in webkit [84949] by
-
- 2 edits in trunk/Tools
2011-04-26 Ryuan Choi <ryuan.choi@samsung.com>
Reviewed by Martin Robinson.
[GTK] Add proxy support to GtkLauncher
https://bugs.webkit.org/show_bug.cgi?id=58852
Add SOUP_TYPE_PROXY_RESOLVER_DEFAULT feature or set SOUP_SESSION_PROXY_URI for developers behind proxy.
- GtkLauncher/main.c: (main):
- 1:57 PM April 2011 Meeting edited by
- (diff)
- 1:46 PM Changeset in webkit [84948] by
-
- 2 edits in trunk/LayoutTests
2011-04-26 Stephen White <senorblanco@chromium.org>
Unreviewed; test expectations update.
- platform/chromium/test_expectations.txt: Mark a test that seems to be passing IMAGE CRASH (I don't trust it enough yet to remove the CRASH).
- 1:38 PM April 2011 Meeting edited by
- (diff)
- 1:30 PM Changeset in webkit [84947] by
-
- 4 edits in trunk/Source/WebCore
Rollout previous patch. It broke stuff.
- bindings/js/JSDOMBinding.h:
(WebCore::JSDOMWrapperWithGlobalPointer::globalObject):
(WebCore::JSDOMWrapperWithGlobalPointer::scriptExecutionContext):
(WebCore::JSDOMWrapperWithGlobalPointer::createStructure):
(WebCore::JSDOMWrapperWithGlobalPointer::JSDOMWrapperWithGlobalPointer):
(WebCore::DOMConstructorObject::DOMConstructorObject):
- bindings/js/JSDOMWrapper.h:
(WebCore::JSDOMWrapper::JSDOMWrapper):
- bindings/scripts/CodeGeneratorJS.pm:
- 1:24 PM Changeset in webkit [84946] by
-
- 1 edit1 add in trunk/LayoutTests
[Qt] Add Qt specific expected result for new test introduced in r84930.
- platform/qt/fast/loader/file-protocol-fragment-expected.txt: Added.
- 1:22 PM Changeset in webkit [84945] by
-
- 4 edits in trunk/Source/WebCore
Remove JSDOMWrapperWithGlobalPointer now that all JSDOMWrappers have global objects
https://bugs.webkit.org/show_bug.cgi?id=59310
Reviewed by Maciej Stachowiak.
- bindings/js/JSDOMBinding.h:
(WebCore::DOMConstructorObject::DOMConstructorObject):
- bindings/js/JSDOMWrapper.h:
(WebCore::JSDOMWrapper::globalObject):
(WebCore::JSDOMWrapper::scriptExecutionContext):
(WebCore::JSDOMWrapper::createStructure):
(WebCore::JSDOMWrapper::JSDOMWrapper):
Merge JSDOMWrapperWithGlobalPointer with JSDOMWrapper.
- bindings/scripts/CodeGeneratorJS.pm:
Make JSDOMWrapper the base class.
- 1:20 PM Changeset in webkit [84944] by
-
- 17 edits10 adds in trunk
Choose the compiler based on the Xcode version for Snow Leopard debug builds.
Reviewed by Mark Rowe.
Source/JavaScriptCore:
- Configurations/Base.xcconfig:
- Configurations/CompilerVersion.xcconfig: Added.
Source/JavaScriptGlue:
- Configurations/Base.xcconfig:
- Configurations/CompilerVersion.xcconfig: Added.
Source/ThirdParty/ANGLE:
- Configurations/Base.xcconfig:
- Configurations/CompilerVersion.xcconfig: Added.
Source/WebCore:
- Configurations/Base.xcconfig:
- Configurations/CompilerVersion.xcconfig: Added.
Source/WebKit/mac:
- Configurations/Base.xcconfig:
- Configurations/CompilerVersion.xcconfig: Added.
Source/WebKit2:
- Configurations/Base.xcconfig:
- Configurations/CompilerVersion.xcconfig: Added.
Tools:
- DumpRenderTree/mac/Configurations/Base.xcconfig:
- DumpRenderTree/mac/Configurations/CompilerVersion.xcconfig: Added.
- MiniBrowser/Configurations/Base.xcconfig:
- MiniBrowser/Configurations/CompilerVersion.xcconfig: Added.
- TestWebKitAPI/Configurations/Base.xcconfig:
- TestWebKitAPI/Configurations/CompilerVersion.xcconfig: Added.
- WebKitTestRunner/Configurations/Base.xcconfig:
- WebKitTestRunner/Configurations/CompilerVersion.xcconfig: Added.
- 1:05 PM Changeset in webkit [84943] by
-
- 1 edit1 delete in trunk/LayoutTests
editing/text-iterator/findString.html passes on Leopard after r84750, so remove the expected
failing results to get the bots green.
- platform/mac-leopard/editing/text-iterator/findString-expected.txt: Removed.
- 12:35 PM Changeset in webkit [84942] by
-
- 2 edits in trunk/LayoutTests
[Windows Tests] media/invalid-media-url-crash.html failing since r84726.
https://bugs.webkit.org/show_bug.cgi?id=59324
The test is timing out on all of the Windows bots, so skip it to get them green.
- platform/win/Skipped:
- 12:14 PM April 2011 Meeting/Threading edited by
- (diff)
- 12:13 PM April 2011 Meeting/Threading edited by
- Initial set of notes. (diff)
- 12:05 PM Changeset in webkit [84941] by
-
- 2 edits in trunk/LayoutTests
Not reviewed.
Add fast/loader/file-protocol-fragment.html to WebKit2 skip list
(uses layoutTestController.dumpResourceLoadCallbacks).
- platform/mac-wk2/Skipped:
- 11:58 AM Changeset in webkit [84940] by
-
- 2 edits in trunk/Source/WebCore
2011-04-26 Adrienne Walker <enne@google.com>
Reviewed by Geoffrey Garen.
Use OwnArrayPtr<T> instead of OwnPtr<T*> in ScopeTracer
https://bugs.webkit.org/show_bug.cgi?id=59469
- platform/chromium/TraceEvent.h: (WebCore::internal::ScopeTracer::ScopeTracer):
- 11:57 AM Changeset in webkit [84939] by
-
- 2 edits in trunk/LayoutTests
2011-04-26 Stephen White <senorblanco@chromium.org>
Unreviewed; chromium test expectations update.
- platform/chromium/test_expectations.txt: Tracking yet more flaky tests.
- 11:53 AM Changeset in webkit [84938] by
-
- 3 edits2 adds16 deletes in trunk/LayoutTests
2011-04-26 Dmitry Titov <dimich@chromium.org>
Reviewed by Darin Adler.
Convert fast/frames/contentWindow_Frame.html and fast/frames/contentWindow_IFrame.html to 'dumpAsText'
https://bugs.webkit.org/show_bug.cgi?id=59436
- fast/frames/contentWindow_Frame-expected.txt: Added.
- fast/frames/contentWindow_Frame.html:
- fast/frames/contentWindow_iFrame-expected.txt: Added.
- fast/frames/contentWindow_iFrame.html:
- platform/chromium-linux/fast/frames/contentWindow_Frame-expected.png: Removed.
- platform/chromium-linux/fast/frames/contentWindow_iFrame-expected.png: Removed.
- platform/chromium-win/fast/frames/contentWindow_Frame-expected.png: Removed.
- platform/chromium-win/fast/frames/contentWindow_Frame-expected.txt: Removed.
- platform/chromium-win/fast/frames/contentWindow_iFrame-expected.png: Removed.
- platform/chromium-win/fast/frames/contentWindow_iFrame-expected.txt: Removed.
- platform/gtk/fast/frames/contentWindow_Frame-expected.txt: Removed.
- platform/gtk/fast/frames/contentWindow_iFrame-expected.txt: Removed.
- platform/mac-leopard/fast/frames/contentWindow_Frame-expected.png: Removed.
- platform/mac-leopard/fast/frames/contentWindow_iFrame-expected.png: Removed.
- platform/mac/fast/frames/contentWindow_Frame-expected.png: Removed.
- platform/mac/fast/frames/contentWindow_Frame-expected.txt: Removed.
- platform/mac/fast/frames/contentWindow_iFrame-expected.png: Removed.
- platform/mac/fast/frames/contentWindow_iFrame-expected.txt: Removed.
- platform/qt/fast/frames/contentWindow_Frame-expected.txt: Removed.
- platform/qt/fast/frames/contentWindow_iFrame-expected.txt: Removed.
- 11:52 AM April 2011 Meeting edited by
- Added geoff- to the attendee list (diff)
- 11:44 AM Changeset in webkit [84937] by
-
- 2 edits in trunk/Tools
2011-04-26 Finnur Thorarinsson <finnur.webkit@gmail.com>
Reviewed by David Levin.
Adding myself as a Chromium contributors to committers.py.
- Scripts/webkitpy/common/config/committers.py:
- 11:43 AM Changeset in webkit [84936] by
-
- 2 edits in trunk/LayoutTests
2011-04-26 Stephen White <senorblanco@chromium.org>
Unreviewed; chromium test expectations update.
- platform/chromium/test_expectations.txt: Add a few flaky tests.
- 11:31 AM Changeset in webkit [84935] by
-
- 2 edits in trunk/LayoutTests
2011-04-26 Stephen White <senorblanco@chromium.org>
Unreviewed; chromium test expectations update.
- platform/chromium/test_expectations.txt: Add failing expectations for new test introduced in r84930.
- 11:31 AM April 2011 Meeting edited by
- (diff)
- 11:31 AM Changeset in webkit [84934] by
-
- 9 edits in trunk/Source
2011-04-25 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Nixed special finalizer handling for WebCore strings
https://bugs.webkit.org/show_bug.cgi?id=59425
SunSpider reports no change.
Not needed anymore, since weak handles have finalizers.
- runtime/JSString.cpp: (JSC::JSString::resolveRope): (JSC::JSString::resolveRopeSlowCase): (JSC::JSString::outOfMemory): (JSC::JSString::substringFromRope): (JSC::JSString::replaceCharacter): Updated for removal of union.
- runtime/JSString.h: (JSC::RopeBuilder::JSString): (JSC::RopeBuilder::~JSString): (JSC::RopeBuilder::appendStringInConstruct): (JSC::RopeBuilder::appendValueInConstructAndIncrementLength): No need for union or special constructor anymore.
2011-04-25 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Nixed special finalizer handling for WebCore strings
https://bugs.webkit.org/show_bug.cgi?id=59425
Not needed anymore, since weak handles have finalizers.
- WebCore.exp.in: Exports!
- bindings/js/DOMWrapperWorld.cpp: (WebCore::JSStringOwner::finalize): (WebCore::DOMWrapperWorld::DOMWrapperWorld): Use a weak handle finalizer, so we don't need special treatment anymore.
- bindings/js/DOMWrapperWorld.h: (WebCore::JSStringOwner::JSStringOwner): (WebCore::DOMWrapperWorld::stringWrapperOwner): Use a HashMap of Weak<T> instead of a WeakGCMap, so we can specify a custom finalizer.
- bindings/js/JSDOMBinding.cpp: (WebCore::jsStringSlowCase):
- bindings/js/JSDOMBinding.h: (WebCore::jsString): Updated for string map change.
- 11:27 AM April 2011 Meeting edited by
- (diff)
- 11:23 AM Changeset in webkit [84933] by
-
- 11 edits in trunk/Source/WebKit/chromium
2011-04-26 Adam Barth <abarth@webkit.org>
Reviewed by David Levin.
Moar strict OwnPtr fixes for WebKit/chromium
https://bugs.webkit.org/show_bug.cgi?id=59437
This patch fixes all but two strict OwnPtr issues in WebKit/chromium.
- src/WebDataSourceImpl.cpp: (WebKit::WebDataSourceImpl::setExtraData): (WebKit::WebDataSourceImpl::setNextPluginLoadObserver): (WebKit::WebDataSourceImpl::WebDataSourceImpl):
- src/WebDataSourceImpl.h:
- src/WebDevToolsAgentImpl.cpp: (WebKit::WebDevToolsAgentImpl::attach): (WebKit::WebDevToolsAgentImpl::detach): (WebKit::WebDevToolsAgent::interruptAndDispatch):
- src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::printBegin):
- src/WebMediaPlayerClientImpl.cpp: (WebKit::createWebMediaPlayer): (WebKit::WebMediaPlayerClientImpl::loadInternal):
- src/WebSpeechInputControllerMockImpl.cpp: (WebKit::WebSpeechInputControllerMockImpl::WebSpeechInputControllerMockImpl):
- src/WebStorageEventDispatcherImpl.cpp: (WebKit::WebStorageEventDispatcherImpl::WebStorageEventDispatcherImpl):
- src/WebViewImpl.cpp: (WebKit::WebViewImpl::WebViewImpl): (WebKit::WebViewImpl::settings): (WebKit::WebViewImpl::applyAutoFillSuggestions): (WebKit::WebView::addUserScript): (WebKit::WebView::addUserStyleSheet):
- 11:21 AM April 2011 Meeting edited by
- (diff)
- 11:13 AM April 2011 Meeting edited by
- (diff)
- 11:13 AM Changeset in webkit [84932] by
-
- 2 edits in trunk/Source/WebCore
<http://webkit.org/b/59372> Restore user default for enabling HTTP pipelining
Reviewed by Antti Koivisto.
To enable HTTP pipelining post-SnowLeopard, use this command:
defaults write BUNDLE.ID WebKitEnableHTTPPipelining -bool YES
- platform/network/cf/ResourceRequestCFNet.cpp:
(WebCore::readBooleanPreference): Re-added. Originally added in
r76756 and removed in r84120.
(WebCore::initializeMaximumHTTPConnectionCountPerHost): Enable
HTTP pipelining if use default is set to true. Added macro
guards to match those in ResourceRequestMac.mm.
- 11:11 AM WebKit Team edited by
- (diff)
- 11:07 AM April 2011 Meeting edited by
- (diff)
- 11:03 AM Changeset in webkit [84931] by
-
- 1 edit5 adds in trunk/LayoutTests
2011-04-26 Daniel Bates <dbates@webkit.org>
Add expected results for GTK and Qt ports for the test panScroll-click-hyperlink.html
(added in <http://trac.webkit.org/changeset/84922>).
- platform/gtk/fast/events/panScroll-click-hyperlink-expected.txt: Added; expected failure results since this port doesn't build with pan scrolling enabled.
- platform/qt-win/fast: Added.
- platform/qt-win/fast/events: Added.
- platform/qt-win/fast/events/panScroll-click-hyperlink-expected.txt: Added.
- platform/qt/fast/events/panScroll-click-hyperlink-expected.txt: Added; expected failure results since the port for the Linux platform doesn't build with pan scrolling enabled.
- 10:58 AM Fingerprinting edited by
- (diff)
- 10:56 AM Changeset in webkit [84930] by
-
- 3 edits2 adds in trunk
Source/WebCore: Don't strip fragments from file: urls in memory cache
https://bugs.webkit.org/show_bug.cgi?id=59463
<rdar://problem/9231130>
Reviewed by Adele Peterson.
Some clients expect file: resources to be unique based on fragment identifier.
Limit the changes in http://trac.webkit.org/changeset/74107 to the HTTP protocol only
Test: fast/loader/file-protocol-fragment.html
- loader/cache/MemoryCache.cpp:
(WebCore::MemoryCache::removeFragmentIdentifierIfNeeded):
LayoutTests: Don't strip fragments from file: urls in memory cache
https://bugs.webkit.org/show_bug.cgi?id=59463
Reviewed by Adele Peterson.
- fast/loader/file-protocol-fragment-expected.txt: Added.
- fast/loader/file-protocol-fragment.html: Added.
- 10:40 AM Changeset in webkit [84929] by
-
- 2 edits in trunk/LayoutTests
2011-04-26 Stephen White <senorblanco@chromium.org>
Unreviewed; chromium test expectations update.
- platform/chromium/test_expectations.txt: Added expectations for new test fast/events/panScroll-click-hyperlink.html. Added a flaky test.
- 10:33 AM Changeset in webkit [84928] by
-
- 5 edits in trunk/Source/WebKit/qt
2011-04-26 Siddharth Mathur <siddharth.mathur@nokia.com>
Reviewed by Andreas Kling.
[Qt] Build fix: QtDeclarative Webview element has a fixed white background
https://bugs.webkit.org/show_bug.cgi?id=40918
Macro Q_REVISION and associated qdeclarativeitem.h signals are not available in 4.7.3 headers in Nokia Qt SDK.
- declarative/plugin.cpp: Bump up required version to 4.7.4+ (WebKitQmlPlugin::registerTypes):
- declarative/qdeclarativewebview.cpp: ditto
- declarative/qdeclarativewebview_p.h: ditto
- tests/qdeclarativewebview/tst_qdeclarativewebview.cpp: ditto
- 10:26 AM April 2011 Meeting/Threading edited by
- (diff)
- 10:24 AM April 2011 Meeting/Threading created by
- 10:23 AM April 2011 Meeting edited by
- (diff)
- 10:22 AM Changeset in webkit [84927] by
-
- 2 edits in trunk/LayoutTests
2011-04-26 Stephen White <senorblanco@chromium.org>
Unreviewed; chromium test expectations update.
- platform/chromium/test_expectations.txt: Add some failing and flaky tests.
- 10:21 AM Changeset in webkit [84926] by
-
- 9 edits in trunk/Tools
2011-04-26 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
DumpRenderTree/chromium should play nice with strict OwnPtrs
https://bugs.webkit.org/show_bug.cgi?id=59458
All these changes are pretty straight forward.
- DumpRenderTree/chromium/CppBoundClass.cpp: (GetterPropertyCallback::GetterPropertyCallback): (CppBoundClass::bindGetterCallback):
- DumpRenderTree/chromium/CppBoundClass.h: (CppBoundClass::bindProperty): (CppBoundClass::bindFallbackCallback): (CppBoundClass::bindFallbackMethod):
- DumpRenderTree/chromium/DRTDevToolsClient.cpp: (DRTDevToolsClient::DRTDevToolsClient):
- DumpRenderTree/chromium/TestEventPrinter.cpp: (TestEventPrinter::createDRTPrinter): (TestEventPrinter::createTestShellPrinter):
- DumpRenderTree/chromium/TestEventPrinter.h:
- DumpRenderTree/chromium/TestShell.cpp: (TestShell::TestShell): (TestShell::createMainWindow): (TestShell::createDRTDevToolsClient):
- DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::geolocationClientMock): (WebViewHost::speechInputController): (WebViewHost::deviceOrientationClientMock): (WebViewHost::reset): (WebViewHost::navigate): (WebViewHost::setPendingExtraData): (WebViewHost::canvas):
- DumpRenderTree/chromium/WebViewHost.h:
- 10:19 AM Changeset in webkit [84925] by
-
- 2 edits in trunk/LayoutTests
2011-04-26 Simon Fraser <Simon Fraser>
Reviewed by Adam Roben.
Fix path to transition-test-helpers.js in a test that is skipped
on Mac but not Windows.
- compositing/animation/animated-composited-inside-hidden.html:
- 10:16 AM Changeset in webkit [84924] by
-
- 2 edits in trunk/Tools
Make DRT/win log loading errors the same way DRT/mac does
Fixes <http://webkit.org/b/59303> [Windows WebKit1 Tests]
http/tests/misc/will-send-request-returns-null-on-redirect.html failing since r84742
Reviewed by Alexey Proskuryakov.
- DumpRenderTree/win/ResourceLoadDelegate.cpp:
(ResourceLoadDelegate::descriptionSuitableForTestResult): Removed the workaround for
<rdar://problem/5064234>, which has long since been fixed, and then made this function match
-[NSError(DRTExtras) _drt_descriptionSuitableForTestResult] more closely.
- 10:16 AM Changeset in webkit [84923] by
-
- 5 edits in trunk/Source/WebCore
Fix more strict OwnPtr in WebCore (round N).
https://bugs.webkit.org/show_bug.cgi?id=59464
Reviewed by Darin Adler.
- dom/Document.cpp:
(WebCore::Document::Document):
(WebCore::Document::attach):
- fileapi/FileReader.cpp:
(WebCore::FileReader::terminate):
- loader/DocumentThreadableLoader.cpp:
(WebCore::DocumentThreadableLoader::preflightFailure):
- workers/DefaultSharedWorkerRepository.cpp:
(WebCore::SharedWorkerConnectTask::create):
(WebCore::SharedWorkerScriptLoader::load):
- 10:12 AM Changeset in webkit [84922] by
-
- 1 edit3 adds in trunk/LayoutTests
2011-04-26 Daniel Bates <dbates@rim.com>
Reviewed by Adam Barth.
Add layout test to ensure we don't regress clicking when exiting pan scrolling
https://bugs.webkit.org/show_bug.cgi?id=58702
On ports that build with PAN_SCROLLING enabled (includes all Windows ports at
the time of writing), ensure that a mouse click is ignored when in pan scroll mode.
This test is expected to fail on ports either built with PAN_SCROLLING disabled
or don't support pan scrolling. In particular, this test is expected to fail on
the Apple Mac and Chromium Mac port.
- fast/events/panScroll-click-hyperlink.html: Added.
- platform/mac/fast/events/panScroll-click-hyperlink-expected.txt: Added.
- platform/win/fast/events/panScroll-click-hyperlink-expected.txt: Added.
- 10:10 AM April 2011 Meeting edited by
- (diff)
- 10:09 AM Changeset in webkit [84921] by
-
- 16 edits in trunk/Source
2011-04-26 Ruben <chromium@hybridsource.org>
Reviewed by Tony Chang.
Change linux ifdefs for Chromium to Unix instead, allowing
new Unix ports to be enabled by default
https://bugs.webkit.org/show_bug.cgi?id=59297
No new tests, just changing preprocessor defines.
- bindings/js/JSInspectorFrontendHostCustom.cpp:
- bindings/v8/custom/V8InspectorFrontendHostCustom.cpp:
- dom/SelectElement.cpp:
- loader/cache/CachedFont.cpp:
- page/EventHandler.cpp:
- page/chromium/EventHandlerChromium.cpp:
- platform/Scrollbar.cpp:
- platform/chromium/PlatformBridge.h:
- platform/graphics/chromium/FontPlatformData.h:
- platform/graphics/skia/FontCustomPlatformData.cpp:
- platform/graphics/skia/FontCustomPlatformData.h:
2011-04-26 Ruben <chromium@hybridsource.org>
Reviewed by Tony Chang.
Change linux ifdefs for Chromium to Unix instead, allowing
new Unix ports to be enabled by default
https://bugs.webkit.org/show_bug.cgi?id=59297
- src/PlatformBridge.cpp:
- src/WebFrameImpl.cpp:
- src/WebViewImpl.cpp:
- 10:03 AM April 2011 Meeting edited by
- (diff)
- 10:01 AM Changeset in webkit [84920] by
-
- 2 edits in trunk/LayoutTests
2011-04-26 John Knottenbelt <jknotten@chromium.org>
Reviewed by Ojan Vafai.
[Chromium] Adjust expectation for animations/play-state.html
https://bugs.webkit.org/show_bug.cgi?id=59441
- platform/chromium/test_expectations.txt:
- 9:54 AM April 2011 Meeting edited by
- (diff)
- 9:50 AM April 2011 Meeting edited by
- (diff)
- 9:48 AM April 2011 Meeting edited by
- (diff)
- 9:41 AM April 2011 Meeting edited by
- (diff)
- 9:40 AM Changeset in webkit [84919] by
-
- 5 edits in trunk
2011-04-26 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Dan Bernstein.
[RTL] Arabic/AB - after typing a date, cursors doesn't go back
https://bugs.webkit.org/show_bug.cgi?id=49111
Added a test to move left and right within Arabic numerals and Arabic letters.
We still fail to set the position offset properly when we moving to the left from before B
to before A in "ABC123" (logical order) in a LTR block where ABC and 123 are Arabic letters
and numerals respectively. This bug is to be fixed in the followup bugs.
- editing/selection/move-left-right-expected.txt:
- editing/selection/move-left-right.html:
2011-04-26 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Dan Bernstein.
[RTL] Arabic/AB - after typing a date, cursors doesn't go back
https://bugs.webkit.org/show_bug.cgi?id=49111
Even when the offset corresponds to a position visually left of the box
and there aren't any inline boxes on the left, the previous/next position
may still correspond to some position in the same line.
The bug was caused by our ignoring such cases. Fixed the bug by comparing
previous/next position's inline box to the current box. If they match,
then we stay on the same position because moving to the left visually at
the left edge should not result in a position on the same line.
Also fixed a bug that WebKit uses offsets that are not extrema when moved to
the left edge or to the right edge, and a bug that WebKit could not move to
the left from 123 CBA abc to 123 CBA abc (there is no offset between 3 and C).
Test cases are added to editing/selection/move-left-right.html
- editing/VisiblePosition.cpp: (WebCore::VisiblePosition::leftVisuallyDistinctCandidate): (WebCore::VisiblePosition::rightVisuallyDistinctCandidate):
- 9:33 AM April 2011 Meeting edited by
- (diff)
- 9:30 AM Changeset in webkit [84918] by
-
- 2 edits in trunk/LayoutTests
2011-04-26 Stephen White <senorblanco@chromium.org>
Unreviewed; chromium test_expectations update.
Updated expectations for newly-failing tests.
- platform/chromium/test_expectations.txt:
- 9:05 AM April 2011 Meeting edited by
- (diff)
- 9:00 AM Changeset in webkit [84917] by
-
- 2 edits in trunk/LayoutTests
2011-04-26 Stephen White <senorblanco@chromium.org>
Unreviewed; chromium test_expectations update.
Remove duplicate expectations.
- platform/chromium/test_expectations.txt:
- 8:56 AM April 2011 Meeting edited by
- (diff)
- 8:49 AM April 2011 Meeting edited by
- (diff)
- 8:37 AM April 2011 Meeting edited by
- (diff)
- 8:36 AM Changeset in webkit [84916] by
-
- 2 edits in trunk/Source/WebKit/chromium
2011-04-26 Stephen White <senorblanco@chromium.org>
Reviewed by Kenneth Russell.
Partial revert of http://trac.webkit.org/changeset/84893, since it
triggered a large number of layout test failures.
https://bugs.webkit.org/show_bug.cgi?id=59459
- src/GraphicsContext3DChromium.cpp: (WebCore::GraphicsContext3DInternal::initialize):
- 8:32 AM Changeset in webkit [84915] by
-
- 2 edits in trunk/Tools
REGRESSION (84876): build-webkit produces an error message
https://bugs.webkit.org/show_bug.cgi?id=59460
- Scripts/webkitdirs.pm:
- 8:15 AM April 2011 Meeting edited by
- (diff)
- 8:13 AM Changeset in webkit [84914] by
-
- 2 edits in trunk/Source/WebKit/chromium
2011-04-26 Hans Wennborg <hans@chromium.org>
Reviewed by Tony Gentilcore.
IndexedDB: Enable compile-time flag for LevelDB
https://bugs.webkit.org/show_bug.cgi?id=59457
Set ENABLE_LEVELDB=1 in features.gypi.
- features.gypi:
- 8:11 AM Changeset in webkit [84913] by
-
- 1 edit1 move in trunk/LayoutTests
2011-04-26 Pavel Feldman <pfeldman@google.com>
Not reviewed: disable failing inspector test while I'm finding a better way to test what it does.
- http/tests/inspector-enabled/dom-storage-open.html-disabled: Renamed from LayoutTests/http/tests/inspector-enabled/dom-storage-open.html.
- 7:58 AM April 2011 Meeting edited by
- (diff)
- 7:50 AM April 2011 Meeting edited by
- (diff)
- 7:47 AM Changeset in webkit [84912] by
-
- 2 edits in trunk/Tools
2011-04-26 Mihai Parparita <mihaip@chromium.org>
Reviewed by Eric Seidel.
Fix timestamp comparison in check-for-weak-vtables-and-externals
https://bugs.webkit.org/show_bug.cgi?id=59416
We should only re-run the check-for-weak-vtables-and-externals script
if the executable is more recent than the last run.
- Scripts/check-for-weak-vtables-and-externals:
- 7:40 AM Changeset in webkit [84911] by
-
- 10 edits6 adds in trunk/Source
2011-04-26 Gabor Loki <loki@webkit.org>
Reviewed by Csaba Osztrogonác.
Speeding up SVG filters with multicore (SMP) support
https://bugs.webkit.org/show_bug.cgi?id=43903
Some SVG filters execute a huge number of pixel manipulations, which
cannot be sped up by graphics accelerators, since their algorithm is
too complex. Using the power of Symmetric Multi Processing (SMP) we
can split up a task to smaller (data independent) tasks, which can be
executed independently.
The ParallelJobs framework provides a simple way for distributed
programming. The framework is based on WebKit's threading infrastructure,
Open Multi-Processing's (OpenMP) API, and libdispatch API.
- GNUmakefile.list.am:
- JavaScriptCore.vcproj/WTF/WTF.vcproj:
- JavaScriptCore.xcodeproj/project.pbxproj:
- wtf/CMakeLists.txt:
- wtf/ParallelJobs.h: Added. (WTF::ParallelJobs::ParallelJobs): (WTF::ParallelJobs::numberOfJobs): (WTF::ParallelJobs::parameterForJob): (WTF::ParallelJobs::executeJobs):
- wtf/ParallelJobsGeneric.cpp: Added. (WTF::ParallelEnvironment::ThreadPrivate::tryLockFor): (WTF::ParallelEnvironment::ThreadPrivate::executeJob): (WTF::ParallelEnvironment::ThreadPrivate::waitForFinish): (WTF::ParallelEnvironment::ThreadPrivate::workerThread):
- wtf/ParallelJobsGeneric.h: Added. (WTF::ParallelEnvironment::ParallelEnvironment): (WTF::ParallelEnvironment::numberOfJobs): (WTF::ParallelEnvironment::parameterForJob): (WTF::ParallelEnvironment::executeJobs): (WTF::ParallelEnvironment::ThreadPrivate::ThreadPrivate): (WTF::ParallelEnvironment::ThreadPrivate::create):
- wtf/ParallelJobsLibdispatch.h: Added. (WTF::ParallelEnvironment::ParallelEnvironment): (WTF::ParallelEnvironment::numberOfJobs): (WTF::ParallelEnvironment::parameterForJob): (WTF::ParallelEnvironment::executeJobs):
- wtf/ParallelJobsOpenMP.h: Added. (WTF::ParallelEnvironment::ParallelEnvironment): (WTF::ParallelEnvironment::numberOfJobs): (WTF::ParallelEnvironment::parameterForJob): (WTF::ParallelEnvironment::executeJobs):
- wtf/Platform.h:
- wtf/wtf.pri:
2011-04-26 Gabor Loki <loki@webkit.org>
Reviewed by Csaba Osztrogonác.
Speeding up SVG filters with multicore (SMP) support
https://bugs.webkit.org/show_bug.cgi?id=43903
Some SVG filters execute a huge number of pixel manipulations, which
cannot be sped up by graphics accelerators, since their algorithm is
too complex. Using the power of Symmetric Multi Processing (SMP) we
can split up a task to smaller (data independent) tasks, which can be
executed independently.
The ParallelJobs framework provides a simple way for distributed
programming. The framework is based on WebKit's threading infrastructure,
Open Multi-Processing's (OpenMP) API, and libdispatch API.
- ForwardingHeaders/wtf/ParallelJobs.h: Added.
- platform/graphics/filters/FETurbulence.cpp: (WebCore::FETurbulence::PaintingData::PaintingData): (WebCore::FETurbulence::noise2D): (WebCore::FETurbulence::calculateTurbulenceValueForPoint): (WebCore::FETurbulence::fillRegion): (WebCore::FETurbulence::fillRegionWorker): (WebCore::FETurbulence::apply):
- platform/graphics/filters/FETurbulence.h:
- 7:27 AM Changeset in webkit [84910] by
-
- 2 edits in trunk/Source/WebCore
2011-04-26 Pavel Feldman <pfeldman@google.com>
Reviewed by Yury Semikhatsky.
Web Inspector: close button is off in docked mode on a mac.
https://bugs.webkit.org/show_bug.cgi?id=59453
- inspector/front-end/inspector.css: (.toolbar-item.close-left):
- 7:23 AM Changeset in webkit [84909] by
-
- 8 edits in trunk
2011-04-26 Pavel Feldman <pfeldman@google.com>
Reviewed by Yury Semikhatsky.
Web Inspector: New Style is not working (UI glitch)
https://bugs.webkit.org/show_bug.cgi?id=59451
- inspector/InspectorDOMStorageAgent.cpp: (WebCore::InspectorDOMStorageAgent::setFrontend):
- inspector/front-end/AuditRules.js: (WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun.getStyles): (WebInspector.AuditRules.CssInHeadRule.prototype.doRun.externalStylesheetsReceived): (WebInspector.AuditRules.CssInHeadRule.prototype.doRun.inlineStylesReceived): (WebInspector.AuditRules.StylesScriptsOrderRule.prototype.doRun.cssBeforeInlineReceived): (WebInspector.AuditRules.StylesScriptsOrderRule.prototype.doRun.lateStylesReceived):
- inspector/front-end/CSSStyleModel.js: (WebInspector.CSSStyleModel.prototype.setRuleSelector): (WebInspector.CSSStyleModel.prototype.setRuleSelector.callback): (WebInspector.CSSStyleModel.prototype.addRule): (WebInspector.CSSStyleModel.prototype.addRule.callback): (WebInspector.CSSStyleModel.prototype._documentElementId):
- inspector/front-end/DOMAgent.js: (WebInspector.DOMNode.prototype._addAttribute): (WebInspector.DOMNode.prototype.documentElement):
- inspector/front-end/ResourceTreeModel.js: (WebInspector.PageDispatcher.prototype.frameDetached):
- inspector/front-end/StylesSidebarPane.js: (WebInspector.StylesSidebarPane.prototype._createNewRule):
- 7:03 AM Changeset in webkit [84908] by
-
- 2 edits in trunk/Source/WebKit2
Unreviewed build fix.
- Platform/Region.cpp: Need to include stdio.h for printf
(at least in my Qt-Linux environment).
- 6:51 AM April 2011 Meeting edited by
- (diff)
- 6:39 AM April 2011 Meeting edited by
- (diff)
- 6:36 AM Changeset in webkit [84907] by
-
- 2 edits in trunk/LayoutTests
[Qt] layoutTestController.overridePreference() is already implemented.
Patch by Kristóf Kosztyó <Kosztyo.Kristof@stud.u-szeged.hu> on 2011-04-26
Reviewed by Csaba Osztrogonác.
- platform/qt/Skipped: Unskip now passing tests:
- fast/events/pageshow-pagehide-on-back-cached.html
- fast/events/pageshow-pagehide-on-back-cached-with-frames.html
- 6:19 AM Changeset in webkit [84906] by
-
- 8 edits in trunk
[Qt] Implement LayoutTestController::setAutofilled
https://bugs.webkit.org/show_bug.cgi?id=59439
Patch by Kristóf Kosztyó <Kosztyo.Kristof@stud.u-szeged.hu> on 2011-04-26
Reviewed by Csaba Osztrogonác.
Source/WebKit/qt:
- WebCoreSupport/DumpRenderTreeSupportQt.cpp:
(DumpRenderTreeSupportQt::setAutofilled):
- WebCoreSupport/DumpRenderTreeSupportQt.h:
Tools:
- DumpRenderTree/qt/LayoutTestControllerQt.cpp:
(LayoutTestController::setAutofilled):
- DumpRenderTree/qt/LayoutTestControllerQt.h:
LayoutTests:
- platform/qt/Skipped:
- 5:48 AM April 2011 Meeting edited by
- (diff)
- 5:25 AM Changeset in webkit [84905] by
-
- 7 edits in trunk
2011-04-26 Pavel Feldman <pfeldman@google.com>
Reviewed by Yury Semikhatsky.
Web Inspector: introduce DOMStorage::enable and disable.
https://bugs.webkit.org/show_bug.cgi?id=59445
- inspector/Inspector.json:
- inspector/InspectorAgent.cpp: (WebCore::InspectorAgent::InspectorAgent): (WebCore::InspectorAgent::restoreInspectorStateFromCookie):
- inspector/InspectorDOMStorageAgent.cpp: (WebCore::InspectorDOMStorageAgent::InspectorDOMStorageAgent): (WebCore::InspectorDOMStorageAgent::restore): (WebCore::InspectorDOMStorageAgent::enable): (WebCore::InspectorDOMStorageAgent::disable):
- inspector/InspectorDOMStorageAgent.h: (WebCore::InspectorDOMStorageAgent::create):
- inspector/front-end/DOMStorage.js: (WebInspector.DOMStorageDispatcher.prototype.addDOMStorage):
- inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype._reset):
- inspector/front-end/inspector.js:
- 5:14 AM April 2011 Meeting edited by
- (diff)
- 4:35 AM Changeset in webkit [84904] by
-
- 14 edits in trunk/Source/WebCore
2011-04-26 Pavel Feldman <pfeldman@google.com>
Reviewed by Yury Semikhatsky.
Web Inspector: extract Page agent dispatcher into the ResourceTreeModel.
https://bugs.webkit.org/show_bug.cgi?id=59440
- inspector/Inspector.json:
- inspector/InspectorAgent.cpp: (WebCore::InspectorAgent::restoreInspectorStateFromCookie):
- inspector/InspectorPageAgent.cpp: (WebCore::InspectorPageAgent::setFrontend): (WebCore::InspectorPageAgent::frameNavigated):
- inspector/InspectorPageAgent.h:
- inspector/front-end/AuditsPanel.js: (WebInspector.AuditsPanel): (WebInspector.AuditsPanel.prototype._onLoadEventFired): (WebInspector.AuditsPanel.prototype._domContentLoadedEventFired):
- inspector/front-end/CSSStyleModel.js: (WebInspector.CSSStyleModelResourceBinding): (WebInspector.CSSStyleModelResourceBinding.prototype._inspectedURLChanged):
- inspector/front-end/DOMBreakpointsSidebarPane.js: (WebInspector.DOMBreakpointsSidebarPane): (WebInspector.DOMBreakpointsSidebarPane.prototype._inspectedURLChanged):
- inspector/front-end/DOMStorage.js: (WebInspector.DOMStorageDispatcher.prototype.addDOMStorage):
- inspector/front-end/ExtensionServer.js: (WebInspector.ExtensionServer.prototype._inspectedURLChanged): (WebInspector.ExtensionServer.prototype.initExtensions):
- inspector/front-end/NetworkPanel.js: (WebInspector.NetworkPanel): (WebInspector.NetworkPanel.prototype._onLoadEventFired): (WebInspector.NetworkPanel.prototype._domContentLoadedEventFired): (WebInspector.NetworkPanel.prototype._frameNavigated):
- inspector/front-end/ResourceTreeModel.js: (WebInspector.ResourceTreeModel): (WebInspector.ResourceTreeModel.prototype._processCachedResources): (WebInspector.ResourceTreeModel.prototype._dispatchInspectedURLChanged): (WebInspector.ResourceTreeModel.prototype._frameNavigated): (WebInspector.ResourceTreeModel.prototype._frameDetached): (WebInspector.ResourceTreeModel.prototype._clearChildFramesAndResources): (WebInspector.PageDispatcher): (WebInspector.PageDispatcher.prototype.domContentEventFired): (WebInspector.PageDispatcher.prototype.loadEventFired): (WebInspector.PageDispatcher.prototype.frameNavigated): (WebInspector.PageDispatcher.prototype.frameDetached):
- inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel): (WebInspector.ResourcesPanel.prototype._onLoadEventFired): (WebInspector.ResourcesPanel.prototype._frameNavigated):
- inspector/front-end/inspector.js:
- 4:31 AM Changeset in webkit [84903] by
-
- 2 edits in trunk/LayoutTests
Unreviewed.
[WK2] editing/pasteboard/paste-before-tab-span.html introdueced in r84885, but
it doesn't work with WK2 because of missing eventSender.keyDown() implementation.
- platform/mac-wk2/Skipped: Add editing/pasteboard/paste-before-tab-span.html until fix.
- 3:46 AM Changeset in webkit [84902] by
-
- 2 edits in trunk/LayoutTests
2011-04-26 John Knottenbelt <jknotten@chromium.org>
Unreviewed.
[Chromium] Remove passing tests from test_expectations.txt
https://bugs.webkit.org/show_bug.cgi?id=59443
- platform/chromium/test_expectations.txt:
- 3:35 AM Changeset in webkit [84901] by
-
- 8 edits in trunk/Source/WebCore
Unreviewed rollout r84877 and StyleRareInheritedData.cpp changes of r84892,
because it broke transitions/multiple-text-shadow-transition.html
Fix OwnPtr strict errors in RenderStyle and make StyleRareInheritedData::textShadow an OwnPtr
https://bugs.webkit.org/show_bug.cgi?id=59377
- css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty):
- page/animation/AnimationBase.cpp:
(WebCore::PropertyWrapperShadow::PropertyWrapperShadow):
(WebCore::PropertyWrapperShadow::blend):
- rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::setTextShadow):
(WebCore::RenderStyle::setBoxShadow):
- rendering/style/RenderStyle.h:
(WebCore::InheritedFlags::textShadow):
- rendering/style/StyleRareInheritedData.cpp:
(WebCore::StyleRareInheritedData::StyleRareInheritedData):
(WebCore::StyleRareInheritedData::~StyleRareInheritedData):
- rendering/style/StyleRareInheritedData.h:
- rendering/style/StyleRareNonInheritedData.cpp:
(WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
- 3:08 AM Changeset in webkit [84900] by
-
- 8 edits in trunk/Source
2011-04-26 Mihai Parparita <mihaip@chromium.org>
Reviewed by Adam Barth.
Turn off make built-in implicit rules for derived sources makefile
https://bugs.webkit.org/show_bug.cgi?id=59418
We don't use any of make's built-in implicit rules, turning them off
speeds up parsing of the makefile.
- JavaScriptCore.xcodeproj/project.pbxproj:
- gyp/generate-derived-sources.sh:
2011-04-26 Mihai Parparita <mihaip@chromium.org>
Reviewed by Adam Barth.
Turn off make built-in implicit rules for derived sources makefile
https://bugs.webkit.org/show_bug.cgi?id=59418
We don't use any of make's built-in implicit rules, turning them off
speeds up parsing of the makefile.
- WebCore.xcodeproj/project.pbxproj:
- gyp/generate-derived-sources.sh:
2011-04-26 Mihai Parparita <mihaip@chromium.org>
Reviewed by Adam Barth.
Turn off make built-in implicit rules for derived sources makefile
https://bugs.webkit.org/show_bug.cgi?id=59418
We don't use any of make's built-in implicit rules, turning them off
speeds up parsing of the makefile.
- WebKit2.xcodeproj/project.pbxproj:
- 2:57 AM Changeset in webkit [84899] by
-
- 3 edits2 adds in trunk
2011-04-26 Leo Yang <leo.yang@torchmobile.com.cn>
Reviewed by Nikolas Zimmermann.
ASSERT failure in SVGUseElement
https://bugs.webkit.org/show_bug.cgi?id=59313
Test case to verify webkit doesn't crash when a <use> element
is pending on resource and the document is not well-formed.
Test passes if no crash occurs in debug mode.
- svg/custom/use-crash-in-non-wellformed-document-expected.txt: Added.
- svg/custom/use-crash-in-non-wellformed-document.svg: Added.
2011-04-26 Leo Yang <leo.yang@torchmobile.com.cn>
Reviewed by Nikolas Zimmermann.
ASSERT failure in SVGUseElement
https://bugs.webkit.org/show_bug.cgi?id=59313
In SVGUseElement::insertedIntoDocument(), ASSERT(!m_isPendingResource)
was wrong because the document may not be well-formed.
This patch asserts the element is not pending on resource or the
document is not well-formed.
Test: svg/custom/use-crash-in-non-wellformed-document.svg
- svg/SVGUseElement.cpp: (WebCore::isWellFormedDocument): (WebCore::SVGUseElement::insertedIntoDocument):
- 2:41 AM Changeset in webkit [84898] by
-
- 2 edits in trunk/Source/WebCore
2011-04-26 Mikhail Naganov <mnaganov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: [Chromium] Fix columns resizing in the detailed heap snapshot grids.
https://bugs.webkit.org/show_bug.cgi?id=59438
- inspector/front-end/DetailedHeapshotView.js: (WebInspector.DetailedHeapshotView.prototype._changeView):
- 1:38 AM Changeset in webkit [84897] by
-
- 2 edits1 add2 deletes in trunk/LayoutTests
2011-04-26 Chang Shu <cshu@webkit.org>
Reviewed by Sam Weinig.
Convert fast/dom/keydown-1.html to dumpAsText test
https://bugs.webkit.org/show_bug.cgi?id=59390
- fast/events/keydown-1-expected.txt: Added.
- fast/events/keydown-1.html:
- platform/mac/fast/events/keydown-1-expected.png: Removed.
- platform/mac/fast/events/keydown-1-expected.txt: Removed.
- 1:37 AM Changeset in webkit [84896] by
-
- 2 edits in trunk/Source/WebKit2
2011-04-26 Carlos Garcia Campos <cgarcia@igalia.com>
Unreviewed. Fix WebKit2 GTK build after r84785.
- UIProcess/gtk/WebInspectorGtk.cpp: (WebKit::WebInspectorProxy::platformAttach): (WebKit::WebInspectorProxy::platformDetach): (WebKit::WebInspectorProxy::platformSetAttachedWindowHeight):
- 1:33 AM Changeset in webkit [84895] by
-
- 2 edits in trunk/Source/WebKit2
2011-04-26 Carlos Garcia Campos <cgarcia@igalia.com>
Unreviewed. Fix WebKit2 GTK build after r84886
- Platform/gtk/RunLoopGtk.cpp: Include WorkItem.h
- 1:31 AM Changeset in webkit [84894] by
-
- 2 edits in trunk/Source/WebKit/chromium
2011-04-26 Pavel Feldman <pfeldman@google.com>
Reviewed by Yury Semikhatsky.
Chromium DevTools: recognize WebP as a valid mimetype in the Chromium port.
https://bugs.webkit.org/show_bug.cgi?id=59332
- src/js/DevTools.js:
- 12:43 AM Changeset in webkit [84893] by
-
- 7 edits in trunk/Source/WebKit/chromium
2011-04-26 Adam Barth <abarth@webkit.org>
Reviewed by David Levin.
WebKit/chromium should play nice with strict OwnPtrs
https://bugs.webkit.org/show_bug.cgi?id=59434
This fixes about half the issues.
- src/ApplicationCacheHost.cpp: (WebCore::ApplicationCacheHost::maybeLoadMainResource):
- src/ApplicationCacheHostInternal.h: (WebCore::ApplicationCacheHostInternal::ApplicationCacheHostInternal):
- src/AutoFillPopupMenuClient.cpp: (WebKit::AutoFillPopupMenuClient::initialize):
- src/GraphicsContext3DChromium.cpp: (WebCore::GraphicsContext3DInternal::initialize):
- src/ResourceHandle.cpp: (WebCore::ResourceHandleInternal::start): (WebCore::ResourceHandle::ResourceHandle): (WebCore::ResourceHandle::loadResourceSynchronously):
- src/SocketStreamHandle.cpp: (WebCore::SocketStreamHandleInternal::connect):
- 12:31 AM Changeset in webkit [84892] by
-
- 15 edits in trunk/Source/WebCore
Fix a few OwnPtr strict errors in WebCore headers.
https://bugs.webkit.org/show_bug.cgi?id=59431
Reviewed by Adam Barth.
- bindings/js/ScheduledAction.cpp:
(WebCore::ScheduledAction::create):
- css/MediaQueryMatcher.cpp:
(WebCore::MediaQueryMatcher::prepareEvaluator):
- dom/NodeRareData.h:
(WebCore::NodeListsNodeData::create):
- dom/ScriptRunner.h:
(WebCore::ScriptRunner::create):
- inspector/WorkerInspectorController.cpp:
(WebCore::WorkerInspectorController::connectFrontend):
- loader/icon/IconDatabase.h:
(WebCore::IconDatabase::create):
- platform/graphics/SimpleFontData.cpp:
(WebCore::SimpleFontData::verticalRightOrientationFontData):
(WebCore::SimpleFontData::uprightOrientationFontData):
(WebCore::SimpleFontData::brokenIdeographFontData):
- rendering/style/StyleRareInheritedData.cpp:
(WebCore::StyleRareInheritedData::StyleRareInheritedData):
- rendering/svg/SVGResources.h:
(WebCore::SVGResources::ClipperFilterMaskerData::create):
(WebCore::SVGResources::MarkerData::create):
(WebCore::SVGResources::FillStrokeData::create):
- storage/StorageSyncManager.cpp:
(WebCore::StorageSyncManager::close):
- workers/WorkerContext.cpp:
(WebCore::CloseWorkerContextTask::create):
- workers/WorkerMessagingProxy.cpp:
(WebCore::MessageWorkerContextTask::create):
(WebCore::MessageWorkerTask::create):
(WebCore::WorkerExceptionTask::create):
(WebCore::WorkerContextDestroyedTask::create):
(WebCore::WorkerTerminateTask::create):
(WebCore::WorkerThreadActivityReportTask::create):
- workers/WorkerRunLoop.cpp:
(WebCore::WorkerRunLoop::Task::create):
- workers/WorkerThread.cpp:
(WebCore::WorkerThreadStartupData::create):
(WebCore::WorkerThreadShutdownFinishTask::create):
(WebCore::WorkerThreadShutdownStartTask::create):
- 12:30 AM Changeset in webkit [84891] by
-
- 2 edits in trunk/Source/WebCore
2011-04-26 Adam Klein <adamk@chromium.org>
Reviewed by Adam Barth.
Fix last strict OwnPtr violation under svg/...
https://bugs.webkit.org/show_bug.cgi?id=59429
- svg/SVGDocumentExtensions.cpp: (WebCore::SVGDocumentExtensions::removePendingResource):
- 12:29 AM April 2011 Meeting edited by
- (diff)
- 12:27 AM Changeset in webkit [84890] by
-
- 18 edits in trunk/Source/WebCore
2011-04-26 Adam Barth <abarth@webkit.org>
Reviewed by David Levin.
Fix more strict OwnPtr violations in WebCore
https://bugs.webkit.org/show_bug.cgi?id=59433
These manifest in the Chromium build.
- bindings/v8/ScriptController.cpp: (WebCore::ScriptController::ScriptController):
- bindings/v8/ScriptDebugServer.cpp: (WebCore::ScriptDebugServer::editScriptSource):
- bindings/v8/V8DOMMap.cpp: (WebCore::DOMDataStoreHandle::DOMDataStoreHandle):
- bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::precompileScript):
- bindings/v8/WorkerScriptController.cpp: (WebCore::WorkerScriptController::WorkerScriptController):
- page/Page.cpp: (WebCore::Page::Page): (WebCore::Page::speechInput):
- platform/PlatformGestureRecognizer.cpp: (WebCore::PlatformGestureRecognizer::create):
- platform/PlatformGestureRecognizer.h:
- platform/graphics/chromium/DrawingBufferChromium.cpp: (WebCore::DrawingBuffer::DrawingBuffer):
- platform/graphics/chromium/cc/CCLayerImpl.cpp: (WebCore::CCLayerImpl::CCLayerImpl):
- platform/graphics/gpu/Texture.cpp: (WebCore::Texture::create):
- platform/image-decoders/bmp/BMPImageDecoder.cpp: (WebCore::BMPImageDecoder::decodeHelper):
- platform/image-decoders/gif/GIFImageDecoder.cpp: (WebCore::GIFImageDecoder::decode):
- platform/image-decoders/ico/ICOImageDecoder.cpp: (WebCore::ICOImageDecoder::decodeAtIndex):
- platform/image-decoders/jpeg/JPEGImageDecoder.cpp: (WebCore::JPEGImageDecoder::decode):
- platform/image-decoders/png/PNGImageDecoder.cpp: (WebCore::PNGImageDecoder::decode):
- storage/chromium/DatabaseTrackerChromium.cpp: (WebCore::DatabaseTracker::addOpenDatabase):
- 12:18 AM Changeset in webkit [84889] by
-
- 1 edit1 delete in trunk/LayoutTests
Convert LayoutTests/fast/events/onloadFrameCrash.html from pixel test to text-based test
https://bugs.webkit.org/show_bug.cgi?id=59362
We don't need Qt specific expected file after r84817.
- platform/qt/fast/events/onloadFrameCrash-expected.txt: Removed.
Apr 25, 2011:
- 11:59 PM Changeset in webkit [84888] by
-
- 2 edits in trunk/Source/WebCore
Fix OwnPtr strict errors in CrossThreadTask.h
https://bugs.webkit.org/show_bug.cgi?id=59427
Reviewed by Adam Barth.
- dom/CrossThreadTask.h:
(WebCore::CrossThreadTask1::create):
(WebCore::CrossThreadTask2::create):
(WebCore::CrossThreadTask3::create):
(WebCore::CrossThreadTask4::create):
(WebCore::CrossThreadTask5::create):
(WebCore::CrossThreadTask6::create):
(WebCore::CrossThreadTask7::create):
(WebCore::CrossThreadTask8::create):
- 11:54 PM Changeset in webkit [84887] by
-
- 3 edits in trunk/Source/WebCore
<rdar://problem/9330337> Leak of 'WebCore::ApplyPropertyFillLayer<WebCore::FillSize>'
Reviewed by Dan Bernstein.
- css/CSSStyleApplyProperty.cpp:
(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty): Don't initialize CSSPropertyWebkitMaskSize twice.
- css/CSSStyleApplyProperty.h:
(WebCore::CSSStyleApplyProperty::setPropertyValue): Add some asserts to catch this class of leak.
- 11:46 PM Changeset in webkit [84886] by
-
- 8 edits in trunk/Source
2011-04-25 Adam Barth <abarth@webkit.org>
Reviewed by David Levin.
WebKit2 should play nice with strict OwnPtrs
https://bugs.webkit.org/show_bug.cgi?id=59426
Fix include ordering.
- WebView/WebDeviceOrientationProviderMock.mm:
2011-04-25 Adam Barth <abarth@webkit.org>
Reviewed by David Levin.
WebKit2 should play nice with strict OwnPtrs
https://bugs.webkit.org/show_bug.cgi?id=59426
- Platform/CoreIPC/Connection.cpp:
(CoreIPC::Connection::waitForMessage):
- Lack of OwnPtr in HashMap is sad face. This code becomes very pretty if we could use OwnPtr in HashMap...
- Platform/RunLoop.cpp: (RunLoop::performWork): (RunLoop::scheduleWork):
- Platform/RunLoop.h:
- Platform/mac/WorkQueueMac.cpp: (WorkQueue::executeWorkItem):
- WebProcess/Plugins/Netscape/NetscapePluginStream.cpp: (WebKit::NetscapePluginStream::deliverData):
- 11:31 PM Changeset in webkit [84885] by
-
- 3 edits2 adds in trunk
2011-04-25 Levi Weintraub <leviw@chromium.org>
Reviewed by Ryosuke Niwa.
REGRESSION: a character appears after tab span when typing immediately before the tab span
https://bugs.webkit.org/show_bug.cgi?id=58132
Correcting the order of operations we use to avoid inserting into invalid positions in
ReplaceSelectionCommand to avoid inserting into tab-spans.
Test: editing/pasteboard/paste-before-tab-span.html
- editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::doApply): Moving positionOutsideTabSpan to after positionAvoidingPrecedingNodes, since that function could once again put our position inside a tab span.
2011-04-25 Levi Weintraub <leviw@chromium.org>
Reviewed by Ryosuke Niwa.
REGRESSION: a character appears after tab span when typing immediately before the tab span
https://bugs.webkit.org/show_bug.cgi?id=58132
Correcting the order of operations we use to avoid inserting into invalid positions in
ReplaceSelectionCommand to avoid inserting into tab-spans.
- editing/pasteboard/paste-before-tab-span-expected.txt: Added.
- editing/pasteboard/paste-before-tab-span.html: Added.
- 11:26 PM Changeset in webkit [84884] by
-
- 2 edits in trunk/Source/WebCore
Fix OwnPtr strict error in ImageBuffer.h
https://bugs.webkit.org/show_bug.cgi?id=59422
Reviewed by Adam Barth.
- platform/graphics/ImageBuffer.h:
(WebCore::ImageBuffer::create):
- 11:24 PM Changeset in webkit [84883] by
-
- 7 edits in trunk/Source/WebKit/mac
2011-04-25 Adam Barth <abarth@webkit.org>
Reviewed by David Levin.
WebKit1 should build cleanly with strict OwnPtrs
https://bugs.webkit.org/show_bug.cgi?id=59424
- History/WebHistoryItem.mm: (-[WebHistoryItem initFromDictionaryRepresentation:]):
- Plugins/WebNetscapePluginEventHandler.h:
- Plugins/WebNetscapePluginEventHandler.mm: (WebNetscapePluginEventHandler::create):
- Plugins/WebNetscapePluginView.mm: (-[WebNetscapePluginView createPlugin]):
- WebView/WebDeviceOrientationProviderMock.mm:
- WebView/WebTextIterator.mm: (-[WebTextIterator initWithRange:]):
- 11:23 PM Changeset in webkit [84882] by
-
- 5 edits2 adds in trunk
2011-04-25 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Custom prototypes on DOM objects don't persist after garbage collection
https://bugs.webkit.org/show_bug.cgi?id=59412
SunSpider reports no change.
The hasCustomProperties() check didn't check for a custom prototype.
- runtime/JSObject.h: (JSC::JSObject::hasCustomProperties): Changed to delegate to Structure because it is the "truth" about an object's pedigree.
- runtime/Structure.cpp: (JSC::Structure::Structure):
- runtime/Structure.h: (JSC::Structure::didTransition): Track whether a Structure has ever transitioned for any reason. If so, we have to assume that the object holding it is custom in some way.
2011-04-25 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Custom prototypes on DOM objects don't persist after garbage collection
https://bugs.webkit.org/show_bug.cgi?id=59412
- fast/dom/gc-custom-prototype-expected.txt: Added.
- fast/dom/gc-custom-prototype.html: Added.
- fast/dom/script-tests/dataset-gc.js:
- 11:22 PM Changeset in webkit [84881] by
-
- 8 edits in trunk/Source/WebCore
2011-04-25 Adam Barth <abarth@webkit.org>
Reviewed by David Levin.
Fix strict OwnPtr violations and whitelist known-tricky files
https://bugs.webkit.org/show_bug.cgi?id=59421
With this patch, WebCore builds cleanly with strict OwnPtrs.
- dom/MessagePort.cpp: (WebCore::MessagePort::MessagePort):
- dom/XMLDocumentParserLibxml2.cpp:
- page/ContextMenuController.cpp: (WebCore::ContextMenuController::ContextMenuController): (WebCore::ContextMenuController::clearContextMenu):
- page/PluginHalter.cpp:
- platform/graphics/MediaPlayer.cpp:
- platform/network/ResourceRequestBase.cpp: (WebCore::ResourceRequestBase::adopt): (WebCore::ResourceRequestBase::copyData):
- svg/SVGDocumentExtensions.cpp:
- 11:07 PM April 2011 Meeting edited by
- (diff)
- 10:57 PM April 2011 Meeting edited by
- (diff)
- 10:56 PM April 2011 Meeting edited by
- (diff)
- 10:45 PM April 2011 Meeting edited by
- (diff)
- 10:45 PM Changeset in webkit [84880] by
-
- 2 edits in trunk/Source/WebCore
Fix OwnPtr strict errors in DatasetDOMStringMap.h.
https://bugs.webkit.org/show_bug.cgi?id=59419
Reviewed by Adam Barth.
- dom/DatasetDOMStringMap.h:
(WebCore::DatasetDOMStringMap::create):
- 10:40 PM Changeset in webkit [84879] by
-
- 2 edits in trunk/Source/WebCore
2011-04-25 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>
Reviewed by Eric Seidel.
KeyboardEvent.cpp should work with strict OwnPtrs.
https://bugs.webkit.org/show_bug.cgi?id=59403
- dom/KeyboardEvent.cpp: (WebCore::KeyboardEvent::KeyboardEvent):
- 10:25 PM April 2011 Meeting edited by
- (diff)
- 10:24 PM April 2011 Meeting edited by
- (diff)
- 10:22 PM April 2011 Meeting edited by
- Adding the Oslo webkittens (diff)
- 10:10 PM Changeset in webkit [84878] by
-
- 7 edits in trunk/LayoutTests
2011-04-25 Daniel Bates <dbates@webkit.org>
Update some call sites that referenced the old location for
the scripts {animation, transition}-test-helpers.js. These
scripts were moved in <http://trac.webkit.org/changeset/84872>,
and <http://trac.webkit.org/changeset/84874>, respectively.
- compositing/animation/computed-style-during-delay.html:
- compositing/reflections/animation-inside-reflection.html:
- compositing/reflections/nested-reflection-animated.html:
- compositing/reflections/nested-reflection-transition.html:
- compositing/transitions/scale-transition-no-start.html:
- compositing/transitions/singular-scale-transition.html:
- 10:05 PM Changeset in webkit [84877] by
-
- 8 edits in trunk/Source/WebCore
2011-04-25 James Robinson <jamesr@chromium.org>
Reviewed by Eric Seidel.
Fix OwnPtr strict errors in RenderStyle and make StyleRareInheritedData::textShadow an OwnPtr
https://bugs.webkit.org/show_bug.cgi?id=59377
- css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty):
- page/animation/AnimationBase.cpp: (WebCore::PropertyWrapperShadow::PropertyWrapperShadow): (WebCore::PropertyWrapperShadow::blend):
- rendering/style/RenderStyle.cpp: (WebCore::RenderStyle::setTextShadow): (WebCore::RenderStyle::setBoxShadow):
- rendering/style/RenderStyle.h: (WebCore::InheritedFlags::textShadow):
- rendering/style/StyleRareInheritedData.cpp: (WebCore::StyleRareInheritedData::StyleRareInheritedData): (WebCore::StyleRareInheritedData::~StyleRareInheritedData):
- rendering/style/StyleRareInheritedData.h:
- rendering/style/StyleRareNonInheritedData.cpp: (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
- 10:05 PM April 2011 Meeting edited by
- (diff)
- 9:57 PM April 2011 Meeting edited by
- (diff)
- 9:53 PM Changeset in webkit [84876] by
-
- 2 edits in trunk/Tools
Teach build-webkit where newer Xcode versions store the application-wide build settings user default.
Reviewed by Mark Rowe.
- Scripts/webkitdirs.pm:
- 9:47 PM April 2011 Meeting edited by
- (diff)
- 9:34 PM April 2011 Meeting edited by
- (diff)
- 9:08 PM April 2011 Meeting edited by
- (diff)
- 9:01 PM April 2011 Meeting edited by
- (diff)
- 8:44 PM April 2011 Meeting edited by
- (diff)
- 8:42 PM April 2011 Meeting edited by
- (diff)
- 8:42 PM April 2011 Meeting edited by
- (diff)
- 8:40 PM April 2011 Meeting edited by
- (diff)
- 8:37 PM April 2011 Meeting edited by
- Fix tony's nick (diff)
- 8:32 PM April 2011 Meeting edited by
- (diff)
- 8:31 PM April 2011 Meeting edited by
- (diff)
- 8:25 PM Changeset in webkit [84875] by
-
- 70 edits in trunk/LayoutTests
2011-04-25 Simon Fraser <Simon Fraser>
Reviewed by Dan Bernstein.
Clean up transition tests
https://bugs.webkit.org/show_bug.cgi?id=59410
General test cleanup: use the named variables as
arguments to runTransitionTest() for readability,
remove unnecessary titles and meta tags, remove
style and script tag attributes etc. No substantive
changes.
- 8:25 PM April 2011 Meeting edited by
- Fix the attendee list (diff)
- 8:24 PM April 2011 Meeting edited by
- Added some attendees (diff)
- 8:17 PM Changeset in webkit [84874] by
-
- 30 edits1 move in trunk/LayoutTests
2011-04-25 Simon Fraser <Simon Fraser>
Reviewed by Daniel Bates.
Move transition-test-helpers.js to resources/
https://bugs.webkit.org/show_bug.cgi?id=59397
Move transition-test-helpers.js and fix tests.
- transitions/background-transitions.html:
- transitions/border-radius-transition.html:
- transitions/clip-transition.html:
- transitions/color-transition-all.html:
- transitions/color-transition-premultiplied.html:
- transitions/default-timing-function.html:
- transitions/font-family-during-transition.html:
- transitions/mask-transitions.html:
- transitions/min-max-width-height-transitions.html:
- transitions/mismatched-shadow-styles.html:
- transitions/move-after-transition.html:
- transitions/multiple-background-size-transitions.html:
- transitions/multiple-background-transitions.html:
- transitions/multiple-mask-transitions.html:
- transitions/multiple-shadow-transitions.html:
- transitions/negative-delay.html:
- transitions/resources/interrupted-accelerated-transition-final.html:
- transitions/resources/transition-test-helpers.js: (roundNumber): (isCloseEnough): (isShadow): (): (expected): (callback.delay):
- transitions/shorthand-border-transitions.html:
- transitions/shorthand-transitions.html:
- transitions/steps-timing-function.html:
- transitions/svg-text-shadow-transition.html:
- transitions/text-indent-transition.html:
- transitions/transform-op-list-match.html:
- transitions/transform-op-list-no-match.html:
- transitions/transition-drt-api-delay.html:
- transitions/transition-end-event-rendering.html:
- transitions/transition-hit-test-transform.html:
- transitions/transition-shorthand-delay.html:
- transitions/zero-duration-in-list.html:
- 8:16 PM Changeset in webkit [84873] by
-
- 4 edits2 adds4 deletes in trunk/LayoutTests
2011-04-25 Simon Fraser <Simon Fraser>
Reviewed by Daniel Bates.
Make a couple of animation tests into text tests
https://bugs.webkit.org/show_bug.cgi?id=59389
- animations/animation-drt-api-multiple-keyframes.html:
- animations/animation-drt-api.html: No need for these two to be text tests.
- animations/state-at-end-event.html: General cleanup.
- animations/animation-drt-api-expected.txt: Added.
- animations/animation-drt-api-multiple-keyframes-expected.txt: Added.
- animations/animation-drt-api-multiple-keyframes.html:
- animations/animation-drt-api.html:
- animations/state-at-end-event.html:
- platform/mac/animations/animation-drt-api-expected.png: Removed.
- platform/mac/animations/animation-drt-api-expected.txt: Removed.
- platform/mac/animations/animation-drt-api-multiple-keyframes-expected.png: Removed.
- platform/mac/animations/animation-drt-api-multiple-keyframes-expected.txt: Removed.
- 8:16 PM Changeset in webkit [84872] by
-
- 48 edits1 move in trunk/LayoutTests
2011-04-25 Simon Fraser <Simon Fraser>
Reviewed by Daniel Bates.
Move animation-test-helpers.js into resources directory
https://bugs.webkit.org/show_bug.cgi?id=59365
Move animation-test-helpers.js and fix the tests accordingly.
- animations/3d/matrix-transform-type-animation.html:
- animations/3d/transform-perspective.html:
- animations/animation-direction.html:
- animations/animation-drt-api-multiple-keyframes.html:
- animations/animation-drt-api.html:
- animations/animation-hit-test-transform.html:
- animations/animation-hit-test.html:
- animations/big-rotation.html:
- animations/change-keyframes-name.html:
- animations/change-keyframes.html:
- animations/change-one-anim.html:
- animations/combo-transform-rotate+scale.html:
- animations/dynamic-stylesheet-loading.html:
- animations/generic-from-to.html:
- animations/import.html:
- animations/keyframe-timing-functions-transform.html:
- animations/keyframe-timing-functions.html:
- animations/keyframe-timing-functions2.html:
- animations/keyframes-comma-separated.html:
- animations/keyframes-out-of-order.html:
- animations/keyframes.html:
- animations/lineheight-animation.html:
- animations/longhand-timing-function.html:
- animations/matrix-anim.html:
- animations/missing-from-to-transforms.html:
- animations/missing-from-to.html:
- animations/missing-keyframe-properties-repeating.html:
- animations/missing-keyframe-properties-timing-function.html:
- animations/missing-keyframe-properties.html:
- animations/missing-values-first-keyframe.html:
- animations/missing-values-last-keyframe.html:
- animations/multiple-animations.html:
- animations/multiple-keyframes.html:
- animations/negative-delay.html:
- animations/opacity-transform-animation.html:
- animations/play-state-suspend.html:
- animations/play-state.html:
- animations/resources/animation-test-helpers.js: (isCloseEnough): (matrixStringToArray): (checkExpectedValue): (endTest): (startTest): (runAnimationTest.else): (runAnimationTest): (waitForAnimationToStart):
- animations/simultaneous-start-left.html:
- animations/simultaneous-start-transform.html:
- animations/stop-animation-on-suspend.html:
- animations/suspend-resume-animation.html:
- animations/timing-functions.html:
- animations/transition-and-animation-1.html:
- animations/transition-and-animation-2.html:
- animations/transition-and-animation-3.html:
- animations/unanimated-style.html:
- animations/width-using-ems.html:
- 8:14 PM Changeset in webkit [84871] by
-
- 3 edits2 deletes in trunk
2011-04-25 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r84864.
http://trac.webkit.org/changeset/84864
https://bugs.webkit.org/show_bug.cgi?id=59413
Expect result of use-crash-in-non-wellformed-document.svg is
platform dependent (Requested by leoyang on #webkit).
- svg/custom/use-crash-in-non-wellformed-document-expected.txt: Removed.
- svg/custom/use-crash-in-non-wellformed-document.svg: Removed.
2011-04-25 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r84864.
http://trac.webkit.org/changeset/84864
https://bugs.webkit.org/show_bug.cgi?id=59413
Expect result of use-crash-in-non-wellformed-document.svg is
platform dependent (Requested by leoyang on #webkit).
- svg/SVGUseElement.cpp: (WebCore::SVGUseElement::insertedIntoDocument):
- 8:00 PM Changeset in webkit [84870] by
-
- 2 edits in tags/Safari-534.31.1/Source/WebCore
Merge r84753.
- 8:00 PM Changeset in webkit [84869] by
-
- 5 edits in tags/Safari-534.31.1/Source/WebCore
Merge r84752.
- 7:59 PM Changeset in webkit [84868] by
-
- 5 edits in tags/Safari-534.31.1/Source
Versioning.
- 7:56 PM Changeset in webkit [84867] by
-
- 2 edits3 adds in trunk/LayoutTests
2011-04-25 Dirk Pranke <dpranke@chromium.org>
Unreviewed, expectations change. Remove tests that are no longer
failing, add missing baselines for Chromium Mac SL.
- platform/chromium/test_expectations.txt:
- platform/chromium-mac/fast/block/positioning/rtl-fixed-positioning-expected.png: Added.
- platform/chromium-mac/fast/block/positioning/rtl-fixed-positioning-expected.txt: Added.
- platform/chromium-mac/fast/block/positioning/vertical-rl/fixed-positioning-expected.png: Added.
- 7:48 PM Changeset in webkit [84866] by
-
- 1 copy in tags/Safari-534.31.1
New tag.
- 7:26 PM Changeset in webkit [84865] by
-
- 2 edits1 add8 deletes in trunk/LayoutTests
2011-04-25 Mihai Parparita <mihaip@chromium.org>
Reviewed by Ojan Vafai.
Convert fast/events/focusingUnloadedFrame.html to dumpAsText
https://bugs.webkit.org/show_bug.cgi?id=59371
- fast/events/focusingUnloadedFrame-expected.txt: Added.
- fast/events/focusingUnloadedFrame.html:
- platform/chromium-linux/fast/events/focusingUnloadedFrame-expected.png: Removed.
- platform/chromium-win/fast/events/focusingUnloadedFrame-expected.png: Removed.
- platform/chromium-win/fast/events/focusingUnloadedFrame-expected.txt: Removed.
- platform/gtk/fast/events/focusingUnloadedFrame-expected.png: Removed.
- platform/gtk/fast/events/focusingUnloadedFrame-expected.txt: Removed.
- platform/mac-leopard/fast/events/focusingUnloadedFrame-expected.png: Removed.
- platform/mac/fast/events/focusingUnloadedFrame-expected.png: Removed.
- platform/mac/fast/events/focusingUnloadedFrame-expected.txt: Removed.
- 7:07 PM TextInputTestSuite edited by
- (diff)
- 7:04 PM TextInputTestSuite edited by
- (diff)
- 7:04 PM Changeset in webkit [84864] by
-
- 3 edits2 adds in trunk
2011-04-25 Leo Yang <leo.yang@torchmobile.com.cn>
Reviewed by Nikolas Zimmermann.
ASSERT failure in SVGUseElement
https://bugs.webkit.org/show_bug.cgi?id=59313
In SVGUseElement::insertedIntoDocument(), ASSERT(!m_isPendingResource)
was wrong because the document may not be well-formed.
This patch asserts the element is not pending on resource or the
document is not well-formed.
Test: svg/custom/use-crash-in-non-wellformed-document.svg
- svg/SVGUseElement.cpp: (WebCore::isWellFormedDocument): (WebCore::SVGUseElement::insertedIntoDocument):
2011-04-25 Leo Yang <leo.yang@torchmobile.com.cn>
Reviewed by Nikolas Zimmermann.
ASSERT failure in SVGUseElement
https://bugs.webkit.org/show_bug.cgi?id=59313
Test case to verify webkit doesn't crash when a <use> element
is pending on resource and the document is not well-formed.
Test passes if no crash occurs in debug mode.
- svg/custom/use-crash-in-non-wellformed-document-expected.txt: Added.
- svg/custom/use-crash-in-non-wellformed-document.svg: Added.
- 7:02 PM TextInputTestSuite created by
- 7:02 PM Changeset in webkit [84863] by
-
- 2 edits1 add9 deletes in trunk/LayoutTests
2011-04-25 Mihai Parparita <mihaip@chromium.org>
Reviewed by Tony Chang.
Convert fast/loader/start-load-in-unload.html to dumpAsText
https://bugs.webkit.org/show_bug.cgi?id=59384
- fast/loader/start-load-in-unload-expected.txt: Added.
- fast/loader/start-load-in-unload.html:
- platform/chromium-linux/fast/loader/start-load-in-unload-expected.png: Removed.
- platform/chromium-win/fast/loader/start-load-in-unload-expected.png: Removed.
- platform/chromium-win/fast/loader/start-load-in-unload-expected.txt: Removed.
- platform/gtk/fast/loader/start-load-in-unload-expected.png: Removed.
- platform/gtk/fast/loader/start-load-in-unload-expected.txt: Removed.
- platform/mac-leopard/fast/loader/start-load-in-unload-expected.png: Removed.
- platform/mac/fast/loader/start-load-in-unload-expected.png: Removed.
- platform/mac/fast/loader/start-load-in-unload-expected.txt: Removed.
- platform/qt/fast/loader/start-load-in-unload-expected.txt: Removed.
- 7:01 PM April 2011 Meeting edited by
- (diff)
- 6:59 PM April 2011 Meeting edited by
- (diff)
- 6:59 PM Changeset in webkit [84862] by
-
- 2 edits in trunk/LayoutTests
2011-04-25 Tony Chang <tony@chromium.org>
Reviewed by Antonio Gomes.
replace a setTimeout with a onload event to save 2 seconds in a test
https://bugs.webkit.org/show_bug.cgi?id=59350
- http/tests/security/xssAuditor/meta-tag-http-refresh-javascript-url.html:
- 6:44 PM Changeset in webkit [84861] by
-
- 2 edits1 add8 deletes in trunk/LayoutTests
2011-04-25 Mihai Parparita <mihaip@chromium.org>
Reviewed by Ojan Vafai.
Convert fast/events/event-sender-mouse-moved.html to dumpAsText
https://bugs.webkit.org/show_bug.cgi?id=59366
- fast/events/event-sender-mouse-moved-expected.txt: Added.
- fast/events/event-sender-mouse-moved.html:
- platform/chromium-linux/fast/events/event-sender-mouse-moved-expected.png: Removed.
- platform/chromium-win/fast/events/event-sender-mouse-moved-expected.png: Removed.
- platform/chromium-win/fast/events/event-sender-mouse-moved-expected.txt: Removed.
- platform/gtk/fast/events/event-sender-mouse-moved-expected.txt: Removed.
- platform/mac-leopard/fast/events/event-sender-mouse-moved-expected.png: Removed.
- platform/mac/fast/events/event-sender-mouse-moved-expected.png: Removed.
- platform/mac/fast/events/event-sender-mouse-moved-expected.txt: Removed.
- platform/qt/fast/events/event-sender-mouse-moved-expected.txt: Removed.
- 6:40 PM Changeset in webkit [84860] by
-
- 11 edits in trunk/Source/JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=59405
DFG JIT - add type speculation for integer & array types, for vars & args.
Reviewed by Geoff Garen.
If a var or argument is used as the base for a GetByVal or PutByVal access
we are speculating that it is of type Array (we only generate code on the
speculative path to perform array accesses). By typing the var or args slot
as Array, and checking on entry to the function (in the case of args), and
each time the local is written to, we can avoid a type check at each point
the array is accessed. This will typically hoist type checks out of loops.
Similarly, any local that is incremented or decremented, or is the input or
output or a bitwise operator, is likely to be an integer. By typing the
local as int32 we can avoid speculation checks on access, and tagging when
writing to the slot. All accesses can become 32bit instead of 64.
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::set):
(JSC::DFG::ByteCodeParser::predictArray):
(JSC::DFG::ByteCodeParser::predictInt32):
(JSC::DFG::ByteCodeParser::parseBlock):
- dfg/DFGGraph.h:
(JSC::DFG::PredictionSlot::PredictionSlot):
(JSC::DFG::Graph::Graph):
(JSC::DFG::Graph::predict):
(JSC::DFG::Graph::getPrediction):
- dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::compileFunction):
- dfg/DFGJITCompiler.h:
(JSC::DFG::JITCompiler::tagFor):
(JSC::DFG::JITCompiler::payloadFor):
- dfg/DFGNode.h:
- dfg/DFGNonSpeculativeJIT.cpp:
(JSC::DFG::NonSpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):
(JSC::DFG::SpeculativeJIT::checkArgumentTypes):
(JSC::DFG::SpeculativeJIT::initializeVariableTypes):
- dfg/DFGSpeculativeJIT.h:
- runtime/Executable.cpp:
(JSC::tryDFGCompile):
- 6:28 PM Changeset in webkit [84859] by
-
- 2 edits in releases/WebKitGTK/webkit-1.4.0/Source/WebKit/gtk
2011-04-25 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
Update the news file for the 1.4.0 release.
- NEWS: Update news.
- 6:23 PM Changeset in webkit [84858] by
-
- 2 edits in trunk/LayoutTests
2011-04-25 Dirk Pranke <dpranke@chromium.org>
Unreviewed, expectations change. Remove tests that are no longer
failing.
- platform/chromium/test_expectations.txt:
- 5:31 PM Changeset in webkit [84857] by
-
- 15 edits1 copy in trunk/Source/WebCore
2011-04-25 Igor Oliveira <igor.oliveira@openbossa.org>
Reviewed by Tony Chang.
Move complexity from DataTransferItemsChromium and DataTransferItemChromium for base class
https://bugs.webkit.org/show_bug.cgi?id=59028
The DataTransferItemsChromium and DataTransferItemChromium code can be reused by other platforms.
Moving the code for base class we can reduce the efforts to support DataTransferItems
element in different platforms.
- Android.mk:
- CMakeLists.txt:
- GNUmakefile.list.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- dom/DataTransferItem.cpp: (WebCore::DataTransferItem::DataTransferItem): (WebCore::DataTransferItem::owner): (WebCore::DataTransferItem::kind): (WebCore::DataTransferItem::type):
- dom/DataTransferItem.h:
- dom/DataTransferItems.cpp: Copied from Source/WebCore/platform/chromium/DataTransferItemsChromium.cpp. (WebCore::DataTransferItems::DataTransferItems): (WebCore::DataTransferItems::length): (WebCore::DataTransferItems::item): (WebCore::DataTransferItems::deleteItem): (WebCore::DataTransferItems::clear): (WebCore::DataTransferItems::add):
- dom/DataTransferItems.h:
- platform/chromium/DataTransferItemChromium.cpp: (WebCore::DataTransferItem::create): (WebCore::DataTransferItemChromium::DataTransferItemChromium): (WebCore::DataTransferItemChromium::getAsString): (WebCore::DataTransferItemChromium::getAsFile):
- platform/chromium/DataTransferItemChromium.h:
- platform/chromium/DataTransferItemsChromium.cpp: (WebCore::DataTransferItemsChromium::DataTransferItemsChromium):
- platform/chromium/DataTransferItemsChromium.h:
- 5:24 PM Changeset in webkit [84856] by
-
- 2 edits in trunk/Source/WebCore
2011-04-25 Chris Marrin <cmarrin@apple.com>
Reviewed by Simon Fraser.
REGRESSION(75137): directly composited images are double-drawn sometimes
https://bugs.webkit.org/show_bug.cgi?id=58632
Depending on the order of operations (layout, creating compositing
layers and creating simple image layers) a layer can have both image
content and have m_drawsContent=true. In this case 2 copies of the image
are drawn in the layer. If the image has alpha, it looks wrong.
I added an updateDrawsContent() call after setting the image contents
to make sure it's correct.
I couldn't create a test case that shows the problem because layerTreeAsText()
doesn't emit enough info to show this level of detail. I've opened
https://bugs.webkit.org/show_bug.cgi?id=59352 to fix that.
- rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::updateImageContents):
- 5:18 PM Changeset in webkit [84855] by
-
- 2 edits in trunk/Source/JavaScriptCore
Fix OwnPtr strict mode violation in MessageQueue.h
https://bugs.webkit.org/show_bug.cgi?id=59400
Reviewed by James Robinson.
- wtf/MessageQueue.h:
(WTF::::waitForMessage):
(WTF::::waitForMessageFilteredWithTimeout):
(WTF::::tryGetMessage):
- 5:13 PM Changeset in webkit [84854] by
-
- 2 edits in trunk/Source/WebCore
2011-04-25 Kenneth Russell <kbr@google.com>
Reviewed by David Levin.
Fix OwnPtr strict errors in InlineFlowBox.cpp
https://bugs.webkit.org/show_bug.cgi?id=59392
- rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::setLayoutOverflow): (WebCore::InlineFlowBox::setVisualOverflow):
- 5:11 PM Changeset in webkit [84853] by
-
- 2 edits in trunk/Source/WebCore
2011-04-25 Kenneth Russell <kbr@google.com>
Reviewed by David Levin.
Fix OwnPtr strict errors in TransformState.cpp
https://bugs.webkit.org/show_bug.cgi?id=59380
- rendering/TransformState.cpp: (WebCore::TransformState::applyTransform):
- 5:07 PM Changeset in webkit [84852] by
-
- 3 edits in trunk/Source/WebCore
2011-04-25 Adam Barth <abarth@webkit.org>
Reviewed by James Robinson.
DOMWindow.cpp should work with strict OwnPtrs
https://bugs.webkit.org/show_bug.cgi?id=59356
- page/DOMWindow.cpp: (WebCore::PostMessageTimer::fired): (WebCore::DOMWindow::postMessageTimerFired):
- page/DOMWindow.h:
- 5:06 PM Changeset in webkit [84851] by
-
- 6 edits in trunk/Source/WebCore
2011-04-25 Adam Klein <adamk@chromium.org>
Reviewed by James Robinson.
Fix OwnPtr strict errors in some SVG classes.
https://bugs.webkit.org/show_bug.cgi?id=59395
- rendering/style/SVGRenderStyleDefs.cpp: (WebCore::StyleShadowSVGData::StyleShadowSVGData):
- svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::SVGSVGElement):
- svg/SVGStyledTransformableElement.cpp: (WebCore::SVGStyledTransformableElement::supplementalTransform):
- svg/SVGTextElement.cpp: (WebCore::SVGTextElement::supplementalTransform):
- svg/graphics/SVGImage.cpp: (WebCore::SVGImage::dataChanged):
- 5:04 PM Changeset in webkit [84850] by
-
- 2 edits in trunk/Source/WebCore
2011-04-25 Adam Barth <abarth@webkit.org>
Re-land changes to ValidationMessage.
- html/ValidationMessage.cpp: (WebCore::ValidationMessage::setMessage): (WebCore::ValidationMessage::setMessageDOMAndStartTimer): (WebCore::ValidationMessage::requestToHideMessage):
- 5:00 PM Changeset in webkit [84849] by
-
- 2 edits in trunk/Source/WebKit/chromium
2011-04-25 Dirk Pranke <dpranke@chromium.org>
Unreviewed, build fix.
Change FAILS_ to DISABLED_ in r84813.
- tests/TransparencyWinTest.cpp: (WebCore::TEST):
- 4:56 PM Changeset in webkit [84848] by
-
- 2 edits in trunk/Source/WebCore
2011-04-25 Ojan Vafai <ojan@chromium.org>
Reviewed by James Robinson.
fix OwnPtr strict error in FrameView.cpp
https://bugs.webkit.org/show_bug.cgi?id=59402
- page/FrameView.cpp: (WebCore::FrameView::FrameView): (WebCore::FrameView::addWidgetToUpdate):
- 4:55 PM Changeset in webkit [84847] by
-
- 7 edits in trunk/Source/WebCore
2011-04-25 Adam Klein <adamk@chromium.org>
Unreviewed, rolling out r84844.
http://trac.webkit.org/changeset/84844
https://bugs.webkit.org/show_bug.cgi?id=59395
Checked in too much.
- rendering/style/SVGRenderStyleDefs.cpp: (WebCore::StyleShadowSVGData::StyleShadowSVGData):
- svg/SVGDocumentExtensions.cpp: (WebCore::SVGDocumentExtensions::removePendingResource):
- svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::SVGSVGElement):
- svg/SVGStyledTransformableElement.cpp: (WebCore::SVGStyledTransformableElement::supplementalTransform):
- svg/SVGTextElement.cpp: (WebCore::SVGTextElement::supplementalTransform):
- svg/graphics/SVGImage.cpp: (WebCore::SVGImage::dataChanged):
- 4:54 PM Changeset in webkit [84846] by
-
- 6 edits in trunk/Source/JavaScriptCore
2011-04-25 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
JavaScriptCore should play nice strict OwnPtrs
https://bugs.webkit.org/show_bug.cgi?id=59401
- dfg/DFGByteCodeParser.cpp: (JSC::DFG::ByteCodeParser::parse):
- heap/Heap.cpp: (JSC::TypeCounter::TypeCounter):
- jit/JITStubs.cpp: (JSC::JITThunks::JITThunks):
- parser/JSParser.cpp: (JSC::JSParser::Scope::Scope):
- yarr/YarrJIT.cpp: (JSC::Yarr::YarrGenerator::GenerationState::addParenthesesTail):
- 4:52 PM Changeset in webkit [84845] by
-
- 2 edits in trunk/Source/WebCore
2011-04-25 Adrienne Walker <enne@google.com>
Reviewed by David Levin.
Make ActiveDOMCallback play nice with OwnPtr strict mode
https://bugs.webkit.org/show_bug.cgi?id=59398
- bindings/generic/ActiveDOMCallback.cpp: (WebCore::ActiveDOMCallback::ActiveDOMCallback):
- 4:51 PM Changeset in webkit [84844] by
-
- 7 edits in trunk/Source/WebCore
2011-04-25 Adam Klein <adamk@chromium.org>
Reviewed by James Robinson.
Fix OwnPtr strict errors in some SVG classes.
https://bugs.webkit.org/show_bug.cgi?id=59395
- rendering/style/SVGRenderStyleDefs.cpp: (WebCore::StyleShadowSVGData::StyleShadowSVGData):
- svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::SVGSVGElement):
- svg/SVGStyledTransformableElement.cpp: (WebCore::SVGStyledTransformableElement::supplementalTransform):
- svg/SVGTextElement.cpp: (WebCore::SVGTextElement::supplementalTransform):
- svg/graphics/SVGImage.cpp: (WebCore::SVGImage::dataChanged):
- 4:45 PM Changeset in webkit [84843] by
-
- 3 edits in trunk/Source/WebCore
2011-04-25 James Robinson <jamesr@chromium.org>
Unreviewed, rolling out r84835.
http://trac.webkit.org/changeset/84835
https://bugs.webkit.org/show_bug.cgi?id=59394
Breaks compile because Deque<OwnPtr> doesn't work
- dom/XMLDocumentParserLibxml2.cpp: (WebCore::PendingCallbacks::~PendingCallbacks): (WebCore::PendingCallbacks::appendStartElementNSCallback): (WebCore::PendingCallbacks::appendEndElementNSCallback): (WebCore::PendingCallbacks::appendCharactersCallback): (WebCore::PendingCallbacks::appendProcessingInstructionCallback): (WebCore::PendingCallbacks::appendCDATABlockCallback): (WebCore::PendingCallbacks::appendCommentCallback): (WebCore::PendingCallbacks::appendInternalSubsetCallback): (WebCore::PendingCallbacks::appendErrorCallback): (WebCore::XMLDocumentParser::XMLDocumentParser):
- html/ValidationMessage.cpp: (WebCore::ValidationMessage::setMessage): (WebCore::ValidationMessage::setMessageDOMAndStartTimer): (WebCore::ValidationMessage::requestToHideMessage):
- 4:43 PM Changeset in webkit [84842] by
-
- 2 edits in trunk/Source/WebCore
2011-04-25 James Robinson <jamesr@chromium.org>
Reviewed by Sam Weinig.
Fix OwnPtr strict mode violation in ImageBufferCG
https://bugs.webkit.org/show_bug.cgi?id=59396
- platform/graphics/cg/ImageBufferCG.cpp: (WebCore::ImageBuffer::ImageBuffer):
- 4:43 PM Changeset in webkit [84841] by
-
- 2 edits in trunk/Source/WebKit2
WebKit2: Should be able to inspect Web Inspector in Debug Builds
https://bugs.webkit.org/show_bug.cgi?id=59378
Reviewed by Adam Roben.
- UIProcess/WebInspectorProxy.cpp:
(WebKit::createInspectorPageGroup): Creates an inspector page group and enables
developer extras in a debug build.
(WebKit::WebInspectorProxy::inspectorPageGroup): Calls createInspectorPageGroup.
- 4:41 PM Changeset in webkit [84840] by
-
- 5 edits1 copy in trunk/Tools
2011-04-25 Sam Weinig <sam@webkit.org>
Reviewed by Adam Roben.
Leaks Viewer throws "Cannot post cyclic structures" in Safari 5
https://bugs.webkit.org/show_bug.cgi?id=56090
Make LeaksViewer work with versions of browsers that don't support message
passing of cyclic structures.
- BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParser.js: (LeaksParser.this._worker.onmessage): (LeaksParser): (LeaksParser.prototype.addLeaksFile): Use LeaksParserImpl directly if we don't support passing cyclic structures.
- BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParserImpl.js: Copied from BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParserWorker.js. (LeaksParserImpl): (LeaksParserImpl.prototype.addLeaksFile): (LeaksParserImpl.prototype._incorporateLeaks):
- BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParserWorker.js: (onmessage): Factor out LeaksParser implementation into LeaksParserImpl.js.
- BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/Utilities.js: (workersSupportCyclicStructures): Add function to detect if workers support passing cyclic structures.
- BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/index.html: Add LeaksParserImpl.js include.
- 4:41 PM Changeset in webkit [84839] by
-
- 2 edits1 add10 deletes in trunk/LayoutTests
Convert a test to dump as text.
Reviewed by Sam Weinig.
- fast/dom/jsDevicePixelRatio-expected.txt: Added.
- fast/dom/jsDevicePixelRatio.html:
- platform/chromium-linux/fast/dom/jsDevicePixelRatio-expected.png: Removed.
- platform/chromium-win/fast/dom/jsDevicePixelRatio-expected.png: Removed.
- platform/chromium-win/fast/dom/jsDevicePixelRatio-expected.txt: Removed.
- platform/gtk/fast/dom/jsDevicePixelRatio-expected.png: Removed.
- platform/gtk/fast/dom/jsDevicePixelRatio-expected.txt: Removed.
- platform/mac-leopard/fast/dom/jsDevicePixelRatio-expected.png: Removed.
- platform/mac/fast/dom/jsDevicePixelRatio-expected.png: Removed.
- platform/mac/fast/dom/jsDevicePixelRatio-expected.txt: Removed.
- platform/qt/fast/dom/jsDevicePixelRatio-expected.png: Removed.
- platform/qt/fast/dom/jsDevicePixelRatio-expected.txt: Removed.
- 4:39 PM Changeset in webkit [84838] by
-
- 2 edits in trunk/Source/WebCore
2011-04-25 Huang Dongsung <luxtella@company100.net>
Reviewed by Dirk Schulze.
[Skia] Remove an unused local variable in PlatformContextSkia::readbackHardwareToSoftware().
https://bugs.webkit.org/show_bug.cgi?id=59308
An unused local variable is created and even allocates heap memory.
- platform/graphics/skia/PlatformContextSkia.cpp: (WebCore::PlatformContextSkia::readbackHardwareToSoftware):
- 4:37 PM Changeset in webkit [84837] by
-
- 3 edits in trunk/Source/WebCore
Qt build fix: Updated files not used by other ports for rename.
- bindings/js/JSTouchCustom.cpp:
(WebCore::toJSNewlyCreated):
- bindings/js/JSTouchListCustom.cpp:
(WebCore::toJSNewlyCreated):
- 4:36 PM Changeset in webkit [84836] by
-
- 3 edits in trunk/Source/WebCore
2011-04-25 Adrienne Walker <enne@google.com>
Reviewed by David Levin.
WebCore/css/CSS* files should play nice with strict OwnPtrs
https://bugs.webkit.org/show_bug.cgi?id=59382
- css/CSSFontFaceSource.cpp: (WebCore::CSSFontFaceSource::getFontData):
- css/CSSParser.cpp: (WebCore::CSSParser::addProperty): (WebCore::CSSParser::parseValue):
- 4:35 PM Changeset in webkit [84835] by
-
- 3 edits in trunk/Source/WebCore
2011-04-25 Adam Barth <abarth@webkit.org>
Reviewed by James Robinson.
ValidationMessage and XMLDocumentParserLibxml2 should play nice with strict OwnPtrs
https://bugs.webkit.org/show_bug.cgi?id=59394
- dom/XMLDocumentParserLibxml2.cpp: (WebCore::PendingCallbacks::PendingCallbacks): (WebCore::PendingCallbacks::appendStartElementNSCallback): (WebCore::PendingCallbacks::appendEndElementNSCallback): (WebCore::PendingCallbacks::appendCharactersCallback): (WebCore::PendingCallbacks::appendProcessingInstructionCallback): (WebCore::PendingCallbacks::appendCDATABlockCallback): (WebCore::PendingCallbacks::appendCommentCallback): (WebCore::PendingCallbacks::appendInternalSubsetCallback): (WebCore::PendingCallbacks::appendErrorCallback): (WebCore::XMLDocumentParser::XMLDocumentParser):
- html/ValidationMessage.cpp: (WebCore::ValidationMessage::setMessage): (WebCore::ValidationMessage::setMessageDOMAndStartTimer): (WebCore::ValidationMessage::requestToHideMessage):
- 4:35 PM Changeset in webkit [84834] by
-
- 3 edits in trunk/LayoutTests
2011-04-25 Philippe Normand <pnormand@igalia.com>
Unreviewed, GTK rebaseline and skip a couple of failing tests.
- platform/gtk/Skipped: skip http/tests/security/mixedContent/insecure-css-in-main-frame.html and editing/text-iterator/findString.html
- platform/gtk/fast/dom/HTMLMeterElement/meter-element-expected.txt:
- 4:30 PM Changeset in webkit [84833] by
-
- 4 edits in trunk/Source/WebCore
2011-04-25 James Robinson <jamesr@chromium.org>
Reviewed by Adam Barth.
Fix OwnPtr strictness issues in WebCore/inspector/
https://bugs.webkit.org/show_bug.cgi?id=59387
- inspector/InspectorAgent.cpp: (WebCore::InspectorAgent::InspectorAgent):
- inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController):
- inspector/InspectorStyleSheet.cpp: (WebCore::InspectorStyleSheet::ensureSourceData):
- 4:25 PM Changeset in webkit [84832] by
-
- 8 edits2 deletes in trunk/Source/WebCore
Removed XPathNamespace because it was unused
https://bugs.webkit.org/show_bug.cgi?id=59381
Reviewed by Beth Dakin.
This allows us to make Node::ownerDocument() non-virtual, though it has
the unhappy side-effect of rebuilding the world.
- CMakeLists.txt:
- GNUmakefile.list.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj: Bye bye dead code.
- dom/Node.h: Hello fast code!
- xml/XPathNamespace.cpp: Removed.
- xml/XPathNamespace.h: Removed.
- 4:25 PM Changeset in webkit [84831] by
-
- 1 edit1 add8 deletes in trunk/LayoutTests
Move text-only results of a test that was switched to dump as text in r72166
alongside the test, and remove old expected pixel results.
- fast/dom/setPrimitiveValue-expected.txt: Added.
- platform/chromium-linux/fast/dom/setPrimitiveValue-expected.png: Removed.
- platform/chromium-win/fast/dom/setPrimitiveValue-expected.png: Removed.
- platform/gtk/fast/dom/setPrimitiveValue-expected.txt: Removed.
- platform/mac-leopard/fast/dom/setPrimitiveValue-expected.png: Removed.
- platform/mac/fast/dom/setPrimitiveValue-expected.png: Removed.
- platform/mac/fast/dom/setPrimitiveValue-expected.txt: Removed.
- platform/qt/fast/dom/setPrimitiveValue-expected.png: Removed.
- platform/qt/fast/dom/setPrimitiveValue-expected.txt: Removed.
- 4:24 PM Changeset in webkit [84830] by
-
- 2 edits in trunk/Source/WebCore
2011-04-25 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
HistoryItemMac should play nice with OwnPtrs
https://bugs.webkit.org/show_bug.cgi?id=59388
- history/mac/HistoryItemMac.mm: (WebCore::HistoryItem::setTransientProperty):
- 4:20 PM Changeset in webkit [84829] by
-
- 2 edits in trunk/Source/WebCore
Fix strict OwnPtrs in ContextMenuController.cpp
https://bugs.webkit.org/show_bug.cgi?id=59375
Reviewed by Kenneth Russell.
- page/ContextMenuController.cpp:
(WebCore::ContextMenuController::createContextMenu):
(WebCore::separatorItem):
- 4:19 PM Changeset in webkit [84828] by
-
- 2 edits in trunk/Source/WebCore
2011-04-25 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
CheckedRadioButton should play nice with strict OwnPtr
https://bugs.webkit.org/show_bug.cgi?id=59386
- dom/CheckedRadioButtons.cpp: (WebCore::CheckedRadioButtons::addButton):
- 4:17 PM Changeset in webkit [84827] by
-
- 4 edits in trunk/Source/WebCore
2011-04-25 Adam Barth <abarth@webkit.org>
Reviewed by David Levin.
Resource*.cpp should play nice with strict OwnPtrs
https://bugs.webkit.org/show_bug.cgi?id=59383
- bridge/runtime_method.cpp: (JSC::RuntimeMethod::RuntimeMethod):
- platform/network/ResourceHandle.cpp: (WebCore::ResourceHandle::ResourceHandle):
- platform/network/ResourceResponseBase.cpp: (WebCore::ResourceResponseBase::adopt): (WebCore::ResourceResponseBase::copyData):
- 4:15 PM Changeset in webkit [84826] by
-
- 2 edits in trunk/Tools
2011-04-25 Jeff Miller <jeffm@apple.com>
Reviewed by Timothy Hatcher.
Treat strings defined with UI_STRING_LOCALIZE_LATER_KEY() as debugging strings in extract-localizable-strings
https://bugs.webkit.org/show_bug.cgi?id=59373
- Scripts/extract-localizable-strings: Add UI_STRING_LOCALIZE_LATER_KEY() to isDebugMacro var.
- 4:14 PM Changeset in webkit [84825] by
-
- 2 edits in trunk/Source/JavaScriptCore
Build fix.
- wtf/ListHashSet.h:
- 4:09 PM Changeset in webkit [84824] by
-
- 3 edits in trunk/Source/WebKit2
WebKit2: Web Inspector's style sidebar fails to display when inspecting element
https://bugs.webkit.org/show_bug.cgi?id=58071
<rdar://problem/9243093>
Reviewed by Timothy Hatcher.
When creating our WebKit2 inspector views, we were creating them on both Mac and Windows
with the empty rect for their initial size. Before we sized them correctly, the inspector
was calling window.innerWidth on them, which returned 0, making the sidebar take up 0 pixels.
- UIProcess/mac/WebInspectorProxyMac.mm:
(WebKit::WebInspectorProxy::platformCreateInspectorPage): Create the window with the initial window width
and height.
- UIProcess/win/WebInspectorProxyWin.cpp:
(WebKit::WebInspectorProxy::platformCreateInspectorPage): Ditto.
- 4:09 PM Changeset in webkit [84823] by
-
- 2 edits1 move8 deletes in trunk/LayoutTests
Convert fast/events/label-focus.html to a text only test
https://bugs.webkit.org/show_bug.cgi?id=59364
Reviewed by Adam Roben.
- fast/events/label-focus-expected.txt: Copied from LayoutTests/platform/mac/fast/events/label-focus-expected.txt.
- fast/events/label-focus.html:
- platform/chromium-linux/fast/events/label-focus-expected.png: Removed.
- platform/chromium-win/fast/events/label-focus-expected.png: Removed.
- platform/chromium-win/fast/events/label-focus-expected.txt: Removed.
- platform/gtk/fast/events/label-focus-expected.png: Removed.
- platform/gtk/fast/events/label-focus-expected.txt: Removed.
- platform/mac-leopard/fast/events/label-focus-expected.png: Removed.
- platform/mac/fast/events/label-focus-expected.png: Removed.
- platform/mac/fast/events/label-focus-expected.txt: Removed.
- platform/qt/fast/events/label-focus-expected.txt: Removed.
- 4:08 PM Changeset in webkit [84822] by
-
- 5 edits in trunk/Source/WebCore
2011-04-25 Adam Barth <abarth@webkit.org>
Reviewed by David Levin.
Page*.cpp and objc_runtime.mm should play nice with strict OwnPtrs
https://bugs.webkit.org/show_bug.cgi?id=59374
- bridge/objc/objc_runtime.mm: (JSC::Bindings::callObjCFallbackObject):
- page/Page.cpp: (WebCore::Page::Page): (WebCore::Page::initGroup):
- page/PageGroup.cpp: (WebCore::PageGroup::addUserScriptToWorld): (WebCore::PageGroup::addUserStyleSheetToWorld):
- page/mac/PageMac.cpp: (WebCore::Page::addSchedulePair):
- 4:06 PM Changeset in webkit [84821] by
-
- 2 edits in trunk/Source/JavaScriptCore
Bug 59370 - DFG JIT - fix leak of BlocksBlocks
(put the blocks immediately into an OwnPtr).
Reviewed by Oliver Hunt.
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parse):
- 4:02 PM Changeset in webkit [84820] by
-
- 2 edits in trunk/Source/WebCore
Build fix: This time for sure!
- dom/make_names.pl:
- 3:58 PM Changeset in webkit [84819] by
-
- 2 edits in trunk/Source/WebCore
Build fix: Let's edit the script instead of the autogenrated file. That
way, our change will stand the test of time.
- dom/make_names.pl:
- 3:57 PM Changeset in webkit [84818] by
-
- 2 edits1 add6 deletes in trunk/LayoutTests
Changed a test to dump as text.
Reviewed by Sam Weinig.
- fast/css/affected-by-hover-after-style-change.html:
- platform/gtk/fast/css/affected-by-hover-after-style-change-expected.png: Removed.
- platform/gtk/fast/css/affected-by-hover-after-style-change-expected.txt: Removed.
- platform/mac/fast/css/affected-by-hover-after-style-change-expected.png: Removed.
- platform/mac/fast/css/affected-by-hover-after-style-change-expected.txt: Removed.
- platform/qt/fast/css/affected-by-hover-after-style-change-expected.png: Removed.
- platform/qt/fast/css/affected-by-hover-after-style-change-expected.txt: Removed.
- 3:56 PM Changeset in webkit [84817] by
-
- 2 edits1 add4 deletes in trunk/LayoutTests
2011-04-25 Daniel Bates <dbates@webkit.org>
Reviewed by Sam Weinig.
Convert LayoutTests/fast/events/onloadFrameCrash.html from pixel test to text-based test
https://bugs.webkit.org/show_bug.cgi?id=59362
- fast/events/onloadFrameCrash-expected.txt: Added.
- fast/events/onloadFrameCrash.html: Modified to dump as text.
- platform/gtk/fast/events/onloadFrameCrash-expected.png: Removed.
- platform/gtk/fast/events/onloadFrameCrash-expected.txt: Removed.
- platform/mac/fast/events/onloadFrameCrash-expected.png: Removed.
- platform/mac/fast/events/onloadFrameCrash-expected.txt: Removed.
- 3:56 PM Changeset in webkit [84816] by
-
- 3 edits in trunk/Source/WebCore
2011-04-25 Adam Barth <abarth@webkit.org>
Reviewed by David Levin.
Fix strict OwnPtrs in HTMLMediaElement and HTTPHeaderMap
https://bugs.webkit.org/show_bug.cgi?id=59368
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::HTMLMediaElement):
- platform/network/HTTPHeaderMap.cpp: (WebCore::HTTPHeaderMap::copyData):
- 3:54 PM Changeset in webkit [84815] by
-
- 10 edits in trunk/Source/WebCore
2011-04-25 James Robinson <jamesr@chromium.org>
Reviewed by Adam Barth.
Fix strict OwnPtr violations in Render*.cpp
https://bugs.webkit.org/show_bug.cgi?id=59361
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::RenderBlock): (WebCore::RenderBlock::finishDelayUpdateScrollInfo):
- rendering/RenderBox.cpp: (WebCore::RenderBox::addLayoutOverflow): (WebCore::RenderBox::addVisualOverflow):
- rendering/RenderButton.cpp: (WebCore::RenderButton::styleDidChange):
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::updateTransform): (WebCore::RenderLayer::paintChildLayerIntoColumns): (WebCore::RenderLayer::hitTestChildLayerColumns): (WebCore::RenderLayer::ensureBacking):
- rendering/RenderTable.cpp: (WebCore::RenderTable::styleDidChange):
- rendering/RenderView.cpp: (WebCore::RenderView::compositor):
- rendering/style/RenderStyle.cpp: (WebCore::RenderStyle::addCachedPseudoStyle): (WebCore::RenderStyle::accessCounterDirectives): (WebCore::RenderStyle::accessAnimations): (WebCore::RenderStyle::accessTransitions):
- rendering/svg/RenderSVGResourceFilter.cpp: (WebCore::RenderSVGResourceFilter::applyResource):
- rendering/svg/SVGResources.cpp: (WebCore::SVGResources::SVGResources):
- 3:48 PM Changeset in webkit [84814] by
-
- 2 edits in trunk/Source/WebCore
2011-04-25 Adam Barth <abarth@webkit.org>
Attempt to fix the compile.
- platform/graphics/MediaPlayer.cpp: (WebCore::MediaPlayer::loadWithNextMediaEngine):
- 3:47 PM Changeset in webkit [84813] by
-
- 2 edits in trunk/Source/WebKit/chromium
2011-04-25 Dirk Pranke <dpranke@chromium.org>
Reviewed by James Robinson.
Suppress test failure in Chromium webkit_unit_tests.
https://bugs.webkit.org/show_bug.cgi?id=59358
Looks like this started failing after
http://trac.webkit.org/changeset/84631.
- tests/TransparencyWinTest.cpp: (WebCore::TEST):
- 3:47 PM Changeset in webkit [84812] by
-
- 18 edits in trunk/Source/WebCore
Merged CREATE_DOM_NODE_WRAPPER and CREATE_DOM_OBJECT_WRAPPER into
CREATE_DOM_WRAPPER because there's no meaningful difference between
them anymore.
Rubber-stamped by Beth Dakin.
- bindings/js/JSCDATASectionCustom.cpp:
(WebCore::toJSNewlyCreated):
- bindings/js/JSCSSRuleCustom.cpp:
(WebCore::toJS):
- bindings/js/JSCSSValueCustom.cpp:
(WebCore::toJS):
- bindings/js/JSDOMBinding.h:
- bindings/js/JSDocumentCustom.cpp:
(WebCore::toJS):
- bindings/js/JSElementCustom.cpp:
(WebCore::toJSNewlyCreated):
- bindings/js/JSEventCustom.cpp:
(WebCore::toJS):
- bindings/js/JSHTMLCollectionCustom.cpp:
(WebCore::toJS):
- bindings/js/JSImageDataCustom.cpp:
(WebCore::toJS):
- bindings/js/JSNodeCustom.cpp:
(WebCore::createWrapperInline):
- bindings/js/JSSVGPathSegCustom.cpp:
(WebCore::toJS):
- bindings/js/JSStyleSheetCustom.cpp:
(WebCore::toJS):
- bindings/js/JSTextCustom.cpp:
(WebCore::toJSNewlyCreated):
- bindings/js/JSWebKitCSSMatrixCustom.cpp:
(WebCore::JSWebKitCSSMatrixConstructor::constructJSWebKitCSSMatrix):
- bindings/js/JSWebSocketCustom.cpp:
(WebCore::JSWebSocketConstructor::constructJSWebSocket):
- bindings/js/JSXMLHttpRequestCustom.cpp:
(WebCore::JSXMLHttpRequestConstructor::constructJSXMLHttpRequest):
- bindings/js/JSXSLTProcessorCustom.cpp:
(WebCore::JSXSLTProcessorConstructor::constructJSXSLTProcessor):
- 3:45 PM Changeset in webkit [84811] by
-
- 2 edits in trunk/Source/WebCore
2011-04-25 Adam Barth <abarth@webkit.org>
Reviewed by James Robinson.
HTMLDocumentParser should play nice with OwnPtrs
https://bugs.webkit.org/show_bug.cgi?id=59363
- html/parser/HTMLDocumentParser.cpp: (WebCore::HTMLDocumentParser::pumpTokenizer):
- 3:41 PM Changeset in webkit [84810] by
-
- 2 edits in trunk/Source/WebCore
2011-04-25 Adam Barth <abarth@webkit.org>
Reviewed by James Robinson.
Frame.cpp should work with strict OwnPtrs
https://bugs.webkit.org/show_bug.cgi?id=59360
- page/Frame.cpp: (WebCore::createRegExpForLabels):
- 3:39 PM Changeset in webkit [84809] by
-
- 2 edits1 add10 deletes in trunk/LayoutTests
Changed a test to dump as text.
Reviewed by Adam Roben.
- fast/css/zoom-property-parsing-expected.txt: Added.
- fast/css/zoom-property-parsing.html:
- platform/chromium-linux/fast/css/zoom-property-parsing-expected.png: Removed.
- platform/chromium-win/fast/css/zoom-property-parsing-expected.png: Removed.
- platform/chromium-win/fast/css/zoom-property-parsing-expected.txt: Removed.
- platform/gtk/fast/css/zoom-property-parsing-expected.png: Removed.
- platform/gtk/fast/css/zoom-property-parsing-expected.txt: Removed.
- platform/mac-leopard/fast/css/zoom-property-parsing-expected.png: Removed.
- platform/mac/fast/css/zoom-property-parsing-expected.png: Removed.
- platform/mac/fast/css/zoom-property-parsing-expected.txt: Removed.
- platform/qt/fast/css/zoom-property-parsing-expected.png: Removed.
- platform/qt/fast/css/zoom-property-parsing-expected.txt: Removed.
- 3:38 PM Changeset in webkit [84808] by
-
- 2 edits in trunk/Source/WebCore
2011-04-25 Adam Barth <abarth@webkit.org>
Reviewed by David Levin.
Fix strict OwnPtr in Element.cpp
https://bugs.webkit.org/show_bug.cgi?id=59357
- dom/NodeRareData.h: (WebCore::NodeRareData::ensureEventTargetData):
- 3:32 PM Changeset in webkit [84807] by
-
- 2 edits in trunk/LayoutTests
2011-04-25 Dirk Pranke <dpranke@chromium.org>
Unreviewed, expectations change.
Missed the Chromium Mac baseline in the previous change.
- platform/chromium-mac/fast/dom/HTMLAnchorElement/set-href-attribute-host-expected.txt:
- 3:28 PM Changeset in webkit [84806] by
-
- 4 edits in trunk/Source/WebCore
2011-04-25 Adam Barth <abarth@webkit.org>
Reviewed by David Levin.
Fix strict OwnPtr issues in Media*.cpp
https://bugs.webkit.org/show_bug.cgi?id=59354
There's still a tricky case in MediaPlayer.cpp, but we'll worry about
that later.
- css/MediaQueryMatcher.cpp: (WebCore::MediaQueryMatcher::addListener):
- dom/Document.cpp:
- platform/graphics/MediaPlayer.cpp: (WebCore::createNullMediaPlayer):
- 3:22 PM Changeset in webkit [84805] by
-
- 4 edits in trunk/Source
2011-04-25 James Robinson <jamesr@chromium.org>
Reviewed by David Levin.
Fix strict OwnPtr violations in ListHashSet and RenderLayerCompositor
https://bugs.webkit.org/show_bug.cgi?id=59353
- wtf/ListHashSet.h: (WTF::::ListHashSet):
2011-04-25 James Robinson <jamesr@chromium.org>
Reviewed by David Levin.
Fix strict OwnPtr violations in ListHashSet and RenderLayerCompositor
https://bugs.webkit.org/show_bug.cgi?id=59353
- rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::RenderLayerCompositor):
- 2:48 PM Changeset in webkit [84804] by
-
- 4 edits in trunk/Source/JavaScriptCore
Fix PassOwnPtr issues in Structure and JSGlobalData.cpp
https://bugs.webkit.org/show_bug.cgi?id=59347
Reviewed by Adam Barth.
- runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::JSGlobalData):
- runtime/Structure.cpp:
(JSC::Structure::copyPropertyTable):
(JSC::Structure::createPropertyMap):
- runtime/Structure.h:
- 2:48 PM Changeset in webkit [84803] by
-
- 2 edits in trunk/LayoutTests
2011-04-25 Dirk Pranke <dpranke@chromium.org>
Unreviewed, expectations change.
- platform/chromium-win/fast/dom/HTMLAnchorElement/set-href-attribute-host-expected.txt:
- 2:48 PM Changeset in webkit [84802] by
-
- 5 edits in trunk/Source/WebCore
2011-04-25 Adam Barth <abarth@webkit.org>
Reviewed by James Robinson.
Worker*.cpp should work with strict OwnPtrs
https://bugs.webkit.org/show_bug.cgi?id=59346
- inspector/WorkerInspectorController.cpp: (WebCore::WorkerInspectorController::WorkerInspectorController):
- workers/WorkerContext.cpp: (WebCore::WorkerContext::WorkerContext):
- workers/WorkerRunLoop.cpp: (WebCore::WorkerRunLoop::WorkerRunLoop):
- workers/WorkerScriptLoader.cpp: (WebCore::WorkerScriptLoader::createResourceRequest):
- 2:31 PM April 2011 Meeting/WebKit2 created by
- 2:30 PM April 2011 Meeting edited by
- (diff)
- 2:21 PM Changeset in webkit [84801] by
-
- 2 edits in trunk/Source/WebCore
2011-04-25 James Robinson <jamesr@chromium.org>
Reviewed by Adam Barth.
Remove bad use of OwnPtr::set() in IconDatabase.cpp
https://bugs.webkit.org/show_bug.cgi?id=59344
Needed for strict OwnPtr compliance.
- loader/icon/IconDatabase.cpp: (WebCore::readySQLiteStatement):
- 2:21 PM Changeset in webkit [84800] by
-
- 11 edits in trunk/Source/JavaScriptCore
2011-04-25 Oliver Hunt <oliver@apple.com>
Reviewed by Geoffrey Garen.
Make ClassInfo required when creating a Structure
https://bugs.webkit.org/show_bug.cgi?id=59340
Add ClassInfo to all those types which currently don't
have it, and add an assertion to Structure::create to
ensure that the provided classInfo is not null.
- runtime/Executable.h: (JSC::EvalExecutable::createStructure): (JSC::ProgramExecutable::createStructure): (JSC::FunctionExecutable::createStructure):
- runtime/GetterSetter.cpp:
- runtime/GetterSetter.h: (JSC::GetterSetter::createStructure):
- runtime/JSAPIValueWrapper.cpp:
- runtime/JSAPIValueWrapper.h: (JSC::JSAPIValueWrapper::createStructure):
- runtime/JSCell.cpp:
- runtime/JSCell.h:
- runtime/JSString.cpp:
- runtime/JSString.h: (JSC::RopeBuilder::createStructure):
- runtime/Structure.h: (JSC::Structure::create): (JSC::JSCell::createDummyStructure):
- 2:16 PM Changeset in webkit [84799] by
-
- 2 edits in trunk/Source/JavaScriptCore
PropertyMapHashTable.h should use adoptPtr instead of implicit conversions to PassRefPtr.
https://bugs.webkit.org/show_bug.cgi?id=59342
Reviewed by Adam Barth.
This patch is to prepare for the strict OwnPtr hack-a-thon.
- runtime/PropertyMapHashTable.h:
(JSC::PropertyTable::copy):
- 1:57 PM Changeset in webkit [84798] by
-
- 2 edits in trunk/Source/WebCore
2011-04-25 Adam Barth <abarth@webkit.org>
Reviewed by Maciej Stachowiak.
ImageBuffer.h should work with strict OwnPtrs
https://bugs.webkit.org/show_bug.cgi?id=59341
This patch is to prepare for the strict OwnPtr hack-a-thon.
- platform/graphics/ImageBuffer.h: (WebCore::ImageBuffer::create):
- 1:50 PM Changeset in webkit [84797] by
-
- 2 edits in trunk/Source/WebCore
2011-04-25 Steve Falkenburg <sfalken@apple.com>
Reviewed by Brian Weinstein.
WebCore build on Windows should include windows.h in its precompiled header to speed builds
https://bugs.webkit.org/show_bug.cgi?id=59339
windows.h is included by several of the underlying wtf headers, including Atomics.h and
ThreadingPrimitives.h anyway, so include it in the WebCorePrefix.h to speed up compilation.
On my 8 core Mac Pro, this reduces a clean rebuild of debug WebCore from 8 minutes to 7 minutes
(a 12% speedup).
- WebCorePrefix.h: Include windows.h
- 1:19 PM Changeset in webkit [84796] by
-
- 4 edits in trunk/Source/JavaScriptCore
2011-04-25 Thouraya ANDOLSI <thouraya.andolsi@st.com>
Reviewed by Gavin Barraclough.
Rationalize MacroAssembler branch methods
https://bugs.webkit.org/show_bug.cgi?id=58950
split out the 'Condition' enum into 'RelationalCondition' and 'ResultCondition'
and apply related changes (only for SH4 platforms).
- assembler/MacroAssemblerSH4.cpp:
- assembler/MacroAssemblerSH4.h: (JSC::MacroAssemblerSH4::compare32): (JSC::MacroAssemblerSH4::branch32WithUnalignedHalfWords): (JSC::MacroAssemblerSH4::branchDouble): (JSC::MacroAssemblerSH4::branch32): (JSC::MacroAssemblerSH4::branchTest8): (JSC::MacroAssemblerSH4::branch8): (JSC::MacroAssemblerSH4::branchTruncateDoubleToInt32): (JSC::MacroAssemblerSH4::test8): (JSC::MacroAssemblerSH4::branch16): (JSC::MacroAssemblerSH4::branchTest32): (JSC::MacroAssemblerSH4::branchAdd32): (JSC::MacroAssemblerSH4::branchMul32): (JSC::MacroAssemblerSH4::branchSub32): (JSC::MacroAssemblerSH4::branchOr32): (JSC::MacroAssemblerSH4::branchConvertDoubleToInt32): (JSC::MacroAssemblerSH4::branchPtrWithPatch): (JSC::MacroAssemblerSH4::SH4Condition):
- assembler/SH4Assembler.h: (JSC::SH4Assembler::cmpEqImmR0):
- 1:16 PM Changeset in webkit [84795] by
-
- 2 edits in trunk/Source/JavaScriptCore
2011-04-25 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
PropertyMapHashTable should work with strict OwnPtr
https://bugs.webkit.org/show_bug.cgi?id=59337
This patch is in preparation for the strict OwnPtr hack-a-thon.
- runtime/PropertyMapHashTable.h: (JSC::PropertyTable::PropertyTable): (JSC::PropertyTable::addDeletedOffset):
- 1:04 PM Changeset in webkit [84794] by
-
- 2 edits in releases/WebKitGTK/webkit-1.4.0/Source/WebCore
Merging r84793
- 1:00 PM Changeset in webkit [84793] by
-
- 2 edits in trunk/Source/WebCore
2011-04-25 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[GTK] Crash in WebCore::FrameView::notifyPageThatContentAreaWillPaint()
https://bugs.webkit.org/show_bug.cgi?id=59311
- platform/gtk/MainFrameScrollbarGtk.cpp: (MainFrameScrollbarGtk::attachAdjustment): Before connecting an adjustment to a scrollbar disconnect any lingering signal handlers. This prevents an adjustment from controlling the active ScrollView and some zombie ScrollView.
- 12:34 PM detect a RenderObject is destroyed unsafely edited by
- (diff)
- 12:23 PM Changeset in webkit [84792] by
-
- 2 edits in trunk/Source/JavaScriptCore
Nixed MarkStack::deprecatedAppend, since it has no clients left.
Reviewed by Sam Weinig.
- heap/MarkStack.h:
- 12:23 PM detect a RenderObject is destroyed unsafely edited by
- (diff)
- 12:21 PM Changeset in webkit [84791] by
-
- 3 edits in trunk/Source/WebCore
Another shot at fixing the EFL build.
- UseJSC.cmake:
- bindings/js/JSDOMBinding.cpp:
- 12:14 PM detect a RenderObject is destroyed unsafely edited by
- (diff)
- 12:13 PM Changeset in webkit [84790] by
-
- 2 edits in trunk/Source/WebCore
Try to fix EFL build.
- UseJSC.cmake: Added a missing file.
- 12:11 PM detect a RenderObject is destroyed unsafely edited by
- (diff)
- 12:11 PM detect a RenderObject is destroyed unsafely edited by
- (diff)
- 12:02 PM detect a RenderObject is destroyed unsafely edited by
- (diff)
- 12:01 PM QtWebKitFeatures21 edited by
- (diff)
- 11:56 AM Changeset in webkit [84789] by
-
- 27 edits in trunk/Source/WebCore
2011-04-25 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Removed a use of markDOMObjectWrapper: ActiveDOMObjects, Workers, and MessagePorts
https://bugs.webkit.org/show_bug.cgi?id=59333
- WebCore.xcodeproj/project.pbxproj: Added .idl files for easier editing.
- bindings/js/JSDOMBinding.cpp:
- bindings/js/JSDOMBinding.h:
- bindings/js/JSDocumentCustom.cpp:
- bindings/js/JSWorkerContextCustom.cpp: (WebCore::JSWorkerContext::visitChildren): Removed now-unused functions.
- bindings/scripts/CodeGeneratorJS.pm: Added support for ActiveDOMObject lifetime management.
- dom/Document.idl: No need for a custom mark function anymore, since ActiveDOMObjets now manage their own lifetimes.
- dom/MessagePort.cpp: (WebCore::MessagePort::hasPendingActivity): Correctly report that we have pending activity when we're remotely entangled, instead of relying on our clients to know this about us and do the check for us.
- dom/MessagePort.h: FIXME!
- dom/MessagePort.idl:
- fileapi/DOMFileSystem.idl:
- fileapi/FileReader.idl:
- fileapi/FileWriter.idl:
- notifications/Notification.idl:
- notifications/NotificationCenter.idl:
- page/EventSource.idl:
- storage/IDBDatabase.idl:
- storage/IDBRequest.idl:
- storage/IDBTransaction.idl:
- webaudio/AudioContext.idl:
- websockets/WebSocket.idl:
- workers/AbstractWorker.idl:
- workers/SharedWorker.idl:
- workers/Worker.idl: Opt in to ActiveDOMObject lifetime management.
- workers/WorkerContext.cpp: (WebCore::WorkerContext::hasPendingActivity): No need to make up for MessagePort::hasPendingActivity being wrong anymore, since it's now right.
- xml/XMLHttpRequest.idl: Opt in to ActiveDOMObject lifetime management.
- 11:55 AM detect a RenderObject is destroyed unsafely created by
- 11:48 AM April 2011 Meeting edited by
- (diff)
- 11:47 AM April 2011 Meeting edited by
- (diff)
- 11:33 AM April 2011 Meeting Hardware Acceleration Track created by
- 11:32 AM April 2011 Meeting/Getting compile time under control created by
- 11:31 AM April 2011 Meeting edited by
- (diff)
- 11:24 AM QtWebKitFeatures21 edited by
- (diff)
- 11:15 AM Changeset in webkit [84788] by
-
- 2 edits2 copies in branches/chromium/742
Merge 84755 - 2011-04-24 Rik Cabanier <cabanier@adobe.com> Reviewed by Simon Fraser. Tables are not rendered correctly https://bugs.webkit.org/show_bug.cgi?id=59138 * fast/table/auto-100-percent-width.html: Added. * platform/mac/fast/table/auto-100-percent-width-expected.txt: Added.2011-04-24 Rik Cabanier <cabanier@adobe.com> Reviewed by Simon Fraser. Tables are not rendered correctly https://bugs.webkit.org/show_bug.cgi?id=59138 Test: fast/table/auto-100-percent-width.html * rendering/AutoTableLayout.cpp: (WebCore::AutoTableLayout::computePreferredLogicalWidths):
TBR=commit-queue@webkit.org
- 11:02 AM Changeset in webkit [84787] by
-
- 2 edits in trunk/LayoutTests
[Qt][WK2]fast/dom/shadow/gc-shadow.html fails
https://bugs.webkit.org/show_bug.cgi?id=59335
- platform/qt-wk2/Skipped: Add fast/dom/shadow/gc-shadow.html.
- 10:47 AM Changeset in webkit [84786] by
-
- 2 edits in trunk/LayoutTests
[Qt] New tests introduced in r84742 fail
https://bugs.webkit.org/show_bug.cgi?id=59334
- platform/qt/Skipped:
- 10:41 AM Changeset in webkit [84785] by
-
- 15 edits in trunk/Source/WebKit2
Windows part of - WebKit2: Support docked mode for Web Inspector
https://bugs.webkit.org/show_bug.cgi?id=59134
<rdar://problem/8739005>
Reviewed by Adam Roben.
Implement attaching and detaching of the Web Inspector on Windows,
and also support setAttachedWindowHeight when the user changes the height
of the docked inspector.
This patch doesn't remember whether the user prefers attached or detached, and
doesn't remember the user's preferred docked height, but that will be a separate
bug.
- UIProcess/WebInspectorProxy.cpp:
(WebKit::WebInspectorProxy::attach): Set the attached flag and call platform-specific code.
(WebKit::WebInspectorProxy::detach): Ditto.
(WebKit::WebInspectorProxy::setAttachedWindowHeight): Call platform-specific code.
(WebKit::WebInspectorProxy::didClose): Set m_isVisible before calling platformClose. platformClose
calls detach if the inspector was docked, and detach needs to know whether or not the window is
visible.
- UIProcess/WebInspectorProxy.h:
- UIProcess/WebInspectorProxy.messages.in: Add new messages.
- UIProcess/WebPageProxy.h:
(WebKit::WebPageProxy::pageClient): Add a getter for the page client.
- UIProcess/win/WebInspectorProxyWin.cpp:
(WebKit::WebInspectorProxy::windowReceivedMessage): Relay WM_WINDOWPOSCHANGING messages from the inspected
web view to the WebInspectorProxy.
(WebKit::WebInspectorProxy::onWebViewWindowPosChangingEvent): Resize the inspected web view to behave well
with the docked inspector.
(WebKit::WebInspectorProxy::platformClose): If we are attached, detach before destroying.
(WebKit::WebInspectorProxy::platformAttach): Set the inspector's host window to be the inspected web view's parent
window, so the inspected web view and the inspector are siblings.
(WebKit::WebInspectorProxy::platformDetach): Set the inspector's host window to be the standalone inspector window.
(WebKit::WebInspectorProxy::platformSetAttachedWindowHeight): Size the views.
- WebProcess/WebCoreSupport/WebInspectorClient.cpp:
- WebProcess/WebCoreSupport/WebInspectorClient.h:
- WebProcess/WebCoreSupport/WebInspectorFrontendClient.cpp:
(WebKit::WebInspectorFrontendClient::attachWindow): Call WebInspector::attach.
(WebKit::WebInspectorFrontendClient::closeWindow): Add a call to the InspectorController to disconnect the inspector frontend
from the inspector backend. Without this line, when we close the attached inspector, it won't re-open, because the
inspector controller still thinks there is a frontend. This matches WebKit1's behavior, although it seems like this is
something WebCore should handle.
(WebKit::WebInspectorFrontendClient::detachWindow): Call WebInspector::detach.
(WebKit::WebInspectorFrontendClient::setAttachedWindowHeight): Call WebInspector::setAttachedWindowHeight.
- UIProcess/DrawingAreaProxyImpl.cpp:
(WebKit::DrawingAreaImpl::sendUpdateBackingStoreState): Add an early return if the WebPageProxy's viewSize is empty.
This can be needed if the inspector takes up the whole view, and it is useful to prevent a possible synchronous message
from the UIProcess -> WebProcess to update a backing store that isn't visible in the first place.
- WebProcess/WebPage/WebInspector.cpp:
(WebKit::WebInspector::attach): Send a message to the UIProcess.
(WebKit::WebInspector::detach): Ditto.
(WebKit::WebInspector::setAttachedWindowHeight): Ditto.
- WebProcess/WebPage/WebInspector.h: Remove some dead code.
- 10:37 AM April 2011 Meeting edited by
- (diff)
- 10:24 AM Changeset in webkit [84784] by
-
- 2 edits in trunk/LayoutTests
Unreviewed; add failing test to mac-wk2/Skipped list.
- platform/mac-wk2/Skipped:
- 10:19 AM Changeset in webkit [84783] by
-
- 1 edit5 adds in trunk/LayoutTests
[Snow Leopard Intel WebKit2 Release Tests] editing/undo/undo-iframe-location-change.html and
compositing/iframes/invisible-nested-iframe-show.html failing since r84037.
https://bugs.webkit.org/show_bug.cgi?id=58990
Add failing expected results for SL WK2 to get the bots green.
These tests are already Skipped on Windows or have their own expected results.
- platform/mac-wk2/compositing/iframes/invisible-nested-iframe-show-expected.txt: Added.
- platform/mac-wk2/editing/undo/undo-iframe-location-change-expected.txt: Added.
- 10:18 AM Changeset in webkit [84782] by
-
- 1 edit in trunk/LayoutTests/ChangeLog
Add another HTMLProgressElement test to the Windows Skipped list to get the bots green,
since Windows does not have an implementation of HTMLProgressElement.
- platform/win/Skipped:
Add fast/dom/HTMLProgressElement/progress-writing-mode.html.
- 10:10 AM Changeset in webkit [84781] by
-
- 3 edits in trunk/Source/WebKit2
WebKit2: Web Inspector: Support highlighting page elements
https://bugs.webkit.org/show_bug.cgi?id=59263
<rdar://problem/8767659>
Reviewed by Alice Liu.
Support highlighting of page elements for the inspector in WebKit2 by
having the WebInspectorClient be a PageOverlay Client and be responsible
for calling InspectorController::drawNodeHighlight.
- WebProcess/WebCoreSupport/WebInspectorClient.cpp:
(WebKit::WebInspectorClient::highlight): Create our overlay if it hasn't been created,
or call setNeedsDisplay if it has.
(WebKit::WebInspectorClient::hideHighlight): Uninstall the page overlay if it exists.
(WebKit::WebInspectorClient::pageOverlayDestroyed):
(WebKit::WebInspectorClient::willMoveToWebPage): If it's being destroyed (moving to a null
WebPage), clear the member variable.
(WebKit::WebInspectorClient::didMoveToWebPage):
(WebKit::WebInspectorClient::drawRect): Call InspectorController::drawNodeHighlight.
(WebKit::WebInspectorClient::mouseEvent):
- WebProcess/WebCoreSupport/WebInspectorClient.h:
(WebKit::WebInspectorClient::WebInspectorClient): Add a new member variable.
- 10:04 AM April 2011 Meeting edited by
- (diff)
- 10:00 AM April 2011 Meeting edited by
- (diff)
- 9:57 AM April 2011 Meeting edited by
- (diff)
- 9:47 AM Changeset in webkit [84780] by
-
- 6 edits1 add in trunk/Source/WebCore
2011-04-25 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: worker messages should be routed to corresponding worker front-end
https://bugs.webkit.org/show_bug.cgi?id=59323
Added WorkerManager which is responsible for routing messages between
Page inspector front-end and Worker inspector front-ends.
- WebCore.gypi:
- inspector/front-end/WebKit.qrc:
- inspector/front-end/WorkerManager.js: Added. (WebInspector.WorkerManager): (WebInspector.WorkerManager.loaded.InspectorFrontendHost.sendMessageToBackend): (WebInspector.WorkerManager.loaded.InspectorFrontendHost.loaded): (WebInspector.WorkerManager.loaded): (WebInspector.WorkerFrontendStub): (WebInspector.WorkerFrontendStub.prototype._receiveMessage): (WebInspector.WorkerDispatcher): (WebInspector.WorkerDispatcher.prototype._receiveMessage): (WebInspector.WorkerDispatcher.prototype.workerCreated): (WebInspector.WorkerDispatcher.prototype.dispatchMessageFromWorker):
- inspector/front-end/inspector.html:
- inspector/front-end/inspector.js: (WebInspector.loaded):
- 9:45 AM April 2011 Meeting edited by
- Moar (diff)
- 9:45 AM Changeset in webkit [84779] by
-
- 2 edits in trunk/Tools
2011-04-25 Andrew Scherkus <scherkus@chromium.org>
Reviewed by Dimitri Glazkov.
Adding a few Chromium contributors to committers.py.
- Scripts/webkitpy/common/config/committers.py:
- 9:39 AM Changeset in webkit [84778] by
-
- 4 edits in trunk/Source/WebCore
2011-04-25 Annie Sullivan <sullivan@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: [Resources panel] Should be easy to copy data.
https://bugs.webkit.org/show_bug.cgi?id=45662
Adds context menu items to copy resource location, resource request headers, and resource response headers.
- inspector/front-end/NetworkPanel.js: (WebInspector.NetworkPanel.prototype._contextMenu): Add new items to context menu. (WebInspector.NetworkPanel.prototype._exportLocation): Copy resource location to clipboard. (WebInspector.NetworkPanel.prototype._exportRequestHeaders): Copy resource request headers to clipboard. (WebInspector.NetworkPanel.prototype._exportResponseHeaders): Copy resource response headers to clipboard.
- inspector/front-end/Resource.js: (WebInspector.Resource.prototype.get requestHeadersText): If _requestHeadersText is undefined, generate it from requestHeaders. (WebInspector.Resource.prototype.get responseHeadersText): If _responseHeadersText is undefined, generate it form responseHeaders.
- 9:32 AM April 2011 Meeting edited by
- (diff)
- 9:24 AM April 2011 Meeting edited by
- (diff)
- 9:22 AM April 2011 Meeting edited by
- (diff)
- 9:20 AM April 2011 Meeting edited by
- (diff)
- 9:19 AM April 2011 Meeting edited by
- (diff)
- 9:18 AM April 2011 Meeting edited by
- (diff)
- 9:18 AM April 2011 Meeting edited by
- (diff)
- 9:17 AM April 2011 Meeting edited by
- (diff)
- 9:17 AM April 2011 Meeting edited by
- (diff)
- 9:16 AM April 2011 Meeting edited by
- (diff)
- 9:16 AM April 2011 Meeting edited by
- (diff)
- 9:14 AM April 2011 Meeting edited by
- (diff)
- 9:06 AM April 2011 Meeting edited by
- (diff)
- 8:51 AM Changeset in webkit [84777] by
-
- 3 edits4 adds in trunk
2011-04-25 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: CSS is parsed improperly when saved in UTF-8 with a BOM
https://bugs.webkit.org/show_bug.cgi?id=59322
- inspector/styles/parse-utf8-bom-expected.txt: Added.
- inspector/styles/parse-utf8-bom.html: Added.
- inspector/styles/resources/parse-utf8-bom-main.css: Added. (h1): (h2):
- inspector/styles/resources/parse-utf8-bom-reset.css: Added.
2011-04-25 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: CSS is parsed improperly when saved in UTF-8 with a BOM
https://bugs.webkit.org/show_bug.cgi?id=59322
Use TextResourceDecoder to determine external stylesheet charsets correctly.
Test: inspector/styles/parse-utf8-bom.html
- inspector/InspectorStyleSheet.cpp: (WebCore::InspectorStyleSheet::originalStyleSheetText):
- 8:13 AM Changeset in webkit [84776] by
-
- 2 edits in trunk/LayoutTests
Add another HTMLProgressElement test to the Windows Skipped list to get the bots green,
since Windows does not have an implementation of HTMLProgressElement.
- platform/win/Skipped:
Add fast/dom/HTMLProgressElement/progress-writing-mode.html.
- 7:38 AM April 2011 Meeting edited by
- (diff)
- 7:27 AM April 2011 Meeting edited by
- (diff)
- 7:18 AM Changeset in webkit [84775] by
-
- 2 edits in trunk/Source/WebCore
2011-04-25 Pavel Feldman <pfeldman@google.com>
Not reviewed: Inspector.json cleanup.
- inspector/Inspector.json:
- 7:12 AM Changeset in webkit [84774] by
-
- 17 edits in trunk
2011-04-25 Pavel Feldman <pfeldman@google.com>
Reviewed by Yury Semikhatsky.
Web Inspector: move Frame and Resource Tree management into the Page agent.
https://bugs.webkit.org/show_bug.cgi?id=59321
- inspector/report-protocol-errors.html:
2011-04-25 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: introduce InspectorWorkerAgent
https://bugs.webkit.org/show_bug.cgi?id=59320
InspectorWorkerAgent is responsible for routing inspector messages
between worker context inspector agents and corresponding worker
inspector front-end.
- CMakeLists.txt:
- GNUmakefile.list.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- inspector/CodeGeneratorInspector.pm:
- inspector/Inspector.json:
- inspector/InspectorAgent.cpp: (WebCore::InspectorAgent::InspectorAgent): (WebCore::InspectorAgent::setFrontend): (WebCore::InspectorAgent::disconnectFrontend):
- inspector/InspectorAgent.h: (WebCore::InspectorAgent::workerAgent):
- inspector/InspectorController.cpp: (WebCore::InspectorController::connectFrontend): (WebCore::InspectorController::disconnectFrontend):
- inspector/InspectorInstrumentation.cpp: (WebCore::InspectorInstrumentation::didStartWorkerContextImpl):
- inspector/InspectorInstrumentation.h: (WebCore::InspectorInstrumentation::willStartWorkerContext): (WebCore::InspectorInstrumentation::didStartWorkerContext):
- inspector/InspectorWorkerAgent.cpp: Added. (WebCore::InspectorWorkerAgent::WorkerFrontendChannel::WorkerFrontendChannel): (WebCore::InspectorWorkerAgent::WorkerFrontendChannel::~WorkerFrontendChannel): (WebCore::InspectorWorkerAgent::WorkerFrontendChannel::id): (WebCore::InspectorWorkerAgent::WorkerFrontendChannel::inspectorProxy): (WebCore::InspectorWorkerAgent::WorkerFrontendChannel::sendMessageToFrontend): (WebCore::InspectorWorkerAgent::create): (WebCore::InspectorWorkerAgent::InspectorWorkerAgent): (WebCore::InspectorWorkerAgent::~InspectorWorkerAgent): (WebCore::InspectorWorkerAgent::setFrontend): (WebCore::InspectorWorkerAgent::clearFrontend): (WebCore::InspectorWorkerAgent::dispatchMessageOnWorkerInspector): (WebCore::InspectorWorkerAgent::didStartWorkerContext):
- inspector/InspectorWorkerAgent.h: Added.
- inspector/InstrumentingAgents.h: (WebCore::InstrumentingAgents::InstrumentingAgents): (WebCore::InstrumentingAgents::inspectorWorkerAgent): (WebCore::InstrumentingAgents::setInspectorWorkerAgent):
- inspector/WorkerInspectorController.cpp: (WebCore::WorkerInspectorController::connectFrontend):
- inspector/generate-inspector-idl:
- workers/Worker.cpp: (WebCore::Worker::notifyFinished):
- workers/WorkerContextInspectorProxy.h: Added. Platform-specific transport for inspector messages sent from the inspected page worker agent to the worker context inspector agents. (WebCore::WorkerContextInspectorProxy::connectFrontend): (WebCore::WorkerContextInspectorProxy::disconnectFrontend): (WebCore::WorkerContextInspectorProxy::sendMessageToWorkerContextInspector): (WebCore::WorkerContextInspectorProxy::~WorkerContextInspectorProxy):
- workers/WorkerContextProxy.h: (WebCore::WorkerContextProxy::inspectorProxy):
- 7:01 AM April 2011 Meeting edited by
- (diff)
- 6:27 AM Changeset in webkit [84773] by
-
- 19 edits2 copies1 add in trunk/Source/WebCore
2011-04-25 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: introduce InspectorWorkerAgent
https://bugs.webkit.org/show_bug.cgi?id=59320
InspectorWorkerAgent is responsible for routing inspector messages
between worker context inspector agents and corresponding worker
inspector front-end.
- CMakeLists.txt:
- GNUmakefile.list.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- inspector/CodeGeneratorInspector.pm:
- inspector/Inspector.json:
- inspector/InspectorAgent.cpp: (WebCore::InspectorAgent::InspectorAgent): (WebCore::InspectorAgent::setFrontend): (WebCore::InspectorAgent::disconnectFrontend):
- inspector/InspectorAgent.h: (WebCore::InspectorAgent::workerAgent):
- inspector/InspectorController.cpp: (WebCore::InspectorController::connectFrontend): (WebCore::InspectorController::disconnectFrontend):
- inspector/InspectorInstrumentation.cpp: (WebCore::InspectorInstrumentation::didStartWorkerContextImpl):
- inspector/InspectorInstrumentation.h: (WebCore::InspectorInstrumentation::willStartWorkerContext): (WebCore::InspectorInstrumentation::didStartWorkerContext):
- inspector/InspectorWorkerAgent.cpp: Added. (WebCore::InspectorWorkerAgent::WorkerFrontendChannel::WorkerFrontendChannel): (WebCore::InspectorWorkerAgent::WorkerFrontendChannel::~WorkerFrontendChannel): (WebCore::InspectorWorkerAgent::WorkerFrontendChannel::id): (WebCore::InspectorWorkerAgent::WorkerFrontendChannel::inspectorProxy): (WebCore::InspectorWorkerAgent::WorkerFrontendChannel::sendMessageToFrontend): (WebCore::InspectorWorkerAgent::create): (WebCore::InspectorWorkerAgent::InspectorWorkerAgent): (WebCore::InspectorWorkerAgent::~InspectorWorkerAgent): (WebCore::InspectorWorkerAgent::setFrontend): (WebCore::InspectorWorkerAgent::clearFrontend): (WebCore::InspectorWorkerAgent::dispatchMessageOnWorkerInspector): (WebCore::InspectorWorkerAgent::didStartWorkerContext):
- inspector/InspectorWorkerAgent.h: Added.
- inspector/InstrumentingAgents.h: (WebCore::InstrumentingAgents::InstrumentingAgents): (WebCore::InstrumentingAgents::inspectorWorkerAgent): (WebCore::InstrumentingAgents::setInspectorWorkerAgent):
- inspector/WorkerInspectorController.cpp: (WebCore::WorkerInspectorController::connectFrontend):
- inspector/generate-inspector-idl:
- workers/Worker.cpp: (WebCore::Worker::notifyFinished):
- workers/WorkerContextInspectorProxy.h: Added. Platform-specific transport for inspector messages sent from the inspected page worker agent to the worker context inspector agents. (WebCore::WorkerContextInspectorProxy::connectFrontend): (WebCore::WorkerContextInspectorProxy::disconnectFrontend): (WebCore::WorkerContextInspectorProxy::sendMessageToWorkerContextInspector): (WebCore::WorkerContextInspectorProxy::~WorkerContextInspectorProxy):
- workers/WorkerContextProxy.h: (WebCore::WorkerContextProxy::inspectorProxy):
- 4:25 AM Changeset in webkit [84772] by
-
- 17 edits in trunk
2011-04-25 Pavel Feldman <pfeldman@google.com>
Reviewed by Yury Semikhatsky.
Web Inspector: few protocol improvements.
https://bugs.webkit.org/show_bug.cgi?id=59319
- http/tests/inspector/inspector-test.js: (initialize_InspectorTest.InspectorTest.reloadPage):
2011-04-25 Pavel Feldman <pfeldman@google.com>
Reviewed by Yury Semikhatsky.
Web Inspector: few protocol improvements.
https://bugs.webkit.org/show_bug.cgi?id=59319
- Page domain is documented
- setUserAgentOverride is moved to the Network agent
- setSearchingForNode -> setInspectModeEnabled
- highlightDOMNode -> highlightNode
- reloadPage -> reload
- openInNewWindow -> open with optional parameter
- inspector/Inspector.json:
- inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::setInspectModeEnabled): (WebCore::InspectorDOMAgent::highlightNode):
- inspector/InspectorDOMAgent.h: (WebCore::InspectorDOMAgent::hideNodeHighlight):
- inspector/InspectorInstrumentation.cpp: (WebCore::InspectorInstrumentation::applyUserAgentOverrideImpl):
- inspector/InspectorPageAgent.cpp: (WebCore::InspectorPageAgent::clearFrontend): (WebCore::InspectorPageAgent::reload): (WebCore::InspectorPageAgent::open):
- inspector/InspectorPageAgent.h:
- inspector/InspectorResourceAgent.cpp: (WebCore::InspectorResourceAgent::clearFrontend): (WebCore::InspectorResourceAgent::applyUserAgentOverride): (WebCore::InspectorResourceAgent::setUserAgentOverride):
- inspector/InspectorResourceAgent.h:
- inspector/front-end/AuditsPanel.js: (WebInspector.AuditsPanel.prototype._reloadResources):
- inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel.prototype.setSearchingForNode):
- inspector/front-end/ExtensionServer.js: (WebInspector.ExtensionServer.prototype._onReload):
- inspector/front-end/NetworkPanel.js: (WebInspector.NetworkDataGridNode.prototype._openInNewTab):
- inspector/front-end/ResourcesPanel.js: (WebInspector.FrameResourceTreeElement.prototype.ondblclick):
- inspector/front-end/inspector.js: (WebInspector.highlightDOMNode): (WebInspector.openResource): (WebInspector.documentKeyDown):
- 4:18 AM Changeset in webkit [84771] by
-
- 11 edits1 delete in trunk/Source/WebKit/efl
2011-04-25 Ryuan Choi <ryuan.choi@samsung.com>
Reviewed by Antonio Gomes.
[EFL] Remove ewk_eapi.h
https://bugs.webkit.org/show_bug.cgi?id=59091
- ewk/EWebKit.h:
- ewk/ewk_contextmenu.h:
- ewk/ewk_cookies.h:
- ewk/ewk_eapi.h: Removed.
- ewk/ewk_frame.h:
- ewk/ewk_history.h:
- ewk/ewk_main.h:
- ewk/ewk_settings.h:
- ewk/ewk_tiled_matrix.h:
- ewk/ewk_tiled_model.h:
- ewk/ewk_window_features.h:
- 2:59 AM Changeset in webkit [84770] by
-
- 7 edits in trunk/LayoutTests
2011-04-25 Maciej Stachowiak <mjs@apple.com>
Reviewed by Cameron Zwarich.
Fix tests after URL parsing fix
https://bugs.webkit.org/show_bug.cgi?id=59317
- fast/dom/HTMLAnchorElement/script-tests/set-href-attribute-host.js: Update expected behavior.
- fast/dom/HTMLAnchorElement/script-tests/set-href-attribute-protocol.js: Update expected behavior.
- fast/dom/HTMLAnchorElement/set-href-attribute-host-expected.txt: Update expectations.
- fast/dom/HTMLAnchorElement/set-href-attribute-protocol-expected.txt: Update expectations.
- fast/loader/url-parse-1-expected.txt: Update expectations.
- http/tests/loading/cross-origin-XHR-willLoadRequest.html: Replace single slash in an http: URL with a double slash - the single slash seemed to be erroneous.
- 1:26 AM Changeset in webkit [84769] by
-
- 16 edits in trunk/Source
2011-04-25 Jon Lee <jonlee@apple.com>
Reviewed by Maciej Stachowiak.
Overlay scroller hard to see on pages with dark background (59183)
https://bugs.webkit.org/show_bug.cgi?id=59183
<rdar://problem/8975367>
Switch the scrollbar's overlay style depending on its frame's background color.
This refactors the getDocumentBackgroundColor method needed for gestures. The style
is determined and set on every paint() call to the Mac scrollbar theme.
- WebCore.exp.in: adding method to allow changing style
- page/Frame.cpp: (WebCore::Frame::getDocumentBackgroundColor): moving code from WebFrame for reuse by FrameView
- page/Frame.h:
- page/FrameView.cpp: (WebCore::FrameView::recommendedScrollbarOverlayStyle): overridden to suggest a style based on CSS background color
- page/FrameView.h:
- platform/ScrollTypes.h: new enum to represent different overlay scrollbar styles
- platform/ScrollableArea.h: (WebCore::ScrollableArea::recommendedScrollbarOverlayStyle): new virtual function to return a suggested overlay style
- platform/mac/ScrollbarThemeMac.mm: (WebCore::ScrollbarThemeMac::paint):
- platform/mac/WebCoreSystemInterface.h:
- platform/mac/WebCoreSystemInterface.mm:
2011-04-25 Jon Lee <jonlee@apple.com>
Reviewed by Maciej Stachowiak.
Overlay scroller hard to see on pages with dark background (59183)
https://bugs.webkit.org/show_bug.cgi?id=59183
<rdar://problem/8975367>
- WebCoreSupport/WebSystemInterface.mm: (InitWebCoreSystemInterface): adding method to allow changing style
2011-04-25 Jon Lee <jonlee@apple.com>
Reviewed by Maciej Stachowiak.
Overlay scroller hard to see on pages with dark background (59183)
https://bugs.webkit.org/show_bug.cgi?id=59183
<rdar://problem/8975367>
- WebProcess/WebCoreSupport/mac/WebSystemInterface.mm: (InitWebCoreSystemInterface): adding method to allow changing style
- WebProcess/WebPage/WebFrame.cpp: (WebKit::WebFrame::getDocumentBackgroundColor): refactoring to use common code for retrieving background color
- 12:29 AM April 2011 Meeting edited by
- (diff)
- 12:28 AM Changeset in webkit [84768] by
-
- 1 edit in trunk/Source/WebCore/ChangeLog
Added Radar link
- 12:26 AM Changeset in webkit [84767] by
-
- 6 edits in trunk/Source/WebCore
REGRESSION (WK2): Holding down Option while dragging scrollbar thumb has no effect (should make scroll distance equal mouse translation)
https://bugs.webkit.org/show_bug.cgi?id=59315
Reviewed by Maciej Stachowiak.
- platform/Scrollbar.cpp:
(WebCore::Scrollbar::Scrollbar): Initialize new member variables.
(WebCore::Scrollbar::moveThumb): Added a boolean draggingDocument parameter. When true, the document
is scrolled a distance equal to the change in the mouse position.
(WebCore::Scrollbar::mouseMoved): Check with the theme whether the mouse move event should drag
the document rather than the thumb, and pass the result to moveThumb.
(WebCore::Scrollbar::mouseUp): Reset m_draggingDocument.
- platform/Scrollbar.h:
- platform/ScrollbarTheme.h:
(WebCore::ScrollbarTheme::shouldDragDocumentInsteadOfThumb): Added. The base class implementation
returns false.
- platform/mac/ScrollbarThemeMac.h:
- platform/mac/ScrollbarThemeMac.mm:
(WebCore::ScrollbarThemeMac::shouldDragDocumentInsteadOfThumb): Overridden to return true if the
Option key is down.
Apr 24, 2011:
- 11:47 PM April 2011 Meeting edited by
- (diff)
- 11:45 PM April 2011 Meeting edited by
- (diff)
- 11:22 PM Changeset in webkit [84766] by
-
- 2 edits2 adds in trunk/LayoutTests
2011-04-24 Dirk Pranke <dpranke@chromium.org>
Unreviewed, expectations change.
Add Chromium baselines for fast/table/auto-100-percent-width.html.
Mark fast/dom/HTMLMeterElement/meter-element.html and
http/tests/misc/will-send-request-returns-null-on-redirect.html
as failing - need triage.
- platform/chromium-mac/fast/table/auto-100-percent-width-expected.png: Added.
- platform/chromium-win/fast/table/auto-100-percent-width-expected.png: Added.
- platform/chromium/test_expectations.txt:
- 11:02 PM April 2011 Meeting edited by
- (diff)
- 10:36 PM Changeset in webkit [84765] by
-
- 4 edits in trunk/LayoutTests
2011-04-24 Adam Barth <abarth@webkit.org>
Update Chromium results for standard-url.html (again).
- platform/chromium-linux/fast/url/standard-url-expected.txt:
- platform/chromium-mac/fast/url/standard-url-expected.txt:
- platform/chromium-win/fast/url/standard-url-expected.txt:
- 10:12 PM April 2011 Meeting edited by
- adding /me to interesting talkings (diff)
- 9:56 PM April 2011 Meeting edited by
- (diff)
- 9:55 PM April 2011 Meeting edited by
- (diff)
- 9:22 PM ThreadCommunication edited by
- (diff)
- 9:08 PM April 2011 Meeting edited by
- (diff)
- 9:06 PM April 2011 Meeting edited by
- (diff)
- 8:49 PM April 2011 Meeting edited by
- (diff)
- 8:43 PM April 2011 Meeting edited by
- (diff)
- 7:43 PM April 2011 Meeting edited by
- (diff)
- 5:47 PM Changeset in webkit [84764] by
-
- 80 edits in trunk/Source/WebCore
2011-04-24 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Removed a use of markDOMObjectWrapper: WebGL, XHR, workers; plus, more autogeneration
https://bugs.webkit.org/show_bug.cgi?id=59307
- WebCore.xcodeproj/project.pbxproj: Added Blob.idl, so it's easier to edit.
- bindings/js/JSCSSRuleCustom.cpp:
- bindings/js/JSCSSStyleDeclarationCustom.cpp:
- bindings/js/JSCanvasRenderingContextCustom.cpp:
- bindings/js/JSDOMApplicationCacheCustom.cpp: Autogenerate these instead of hand-coding them.
- bindings/js/JSDOMBinding.h: (WebCore::root): Moved some GC helpers here from JSNodeCustom.h, because they're reasonably generic.
- bindings/js/JSDOMImplementationCustom.cpp:
- bindings/js/JSDOMStringMapCustom.cpp:
- bindings/js/JSDOMTokenListCustom.cpp:
- bindings/js/JSHTMLCollectionCustom.cpp:
- bindings/js/JSMediaListCustom.cpp: Autogenerate these instead of hand-coding them.
- bindings/js/JSMessageChannelCustom.cpp: (WebCore::JSMessageChannel::visitChildren):
- bindings/js/JSMessagePortCustom.cpp: (WebCore::JSMessagePort::visitChildren): Use addOpaqueRoot instead of markDOMObjectWrapper. This is one of the few cases where a DOM object is considered a stand-alone root. It's not as efficient as the shared root case, but workers and message ports are very rare objects, so it's no big deal.
- bindings/js/JSNamedNodeMapCustom.cpp: Autogenerate!
- bindings/js/JSNodeCustom.h: Moved to JSDOMBinding.h.
- bindings/js/JSSharedWorkerCustom.cpp: (WebCore::JSSharedWorker::visitChildren): Use addOpaqueRoot instead of markDOMObjectWrapper, as above. Once again, a stand-alone root.
- bindings/js/JSStyleSheetCustom.cpp:
- bindings/js/JSStyleSheetListCustom.cpp: Autogenerate!
- bindings/js/JSWebGLRenderingContextCustom.cpp: (WebCore::JSWebGLRenderingContext::visitChildren): Use the opaque roots system for marking WebGL contexts and their associated satellite objects.
- bindings/js/JSWorkerContextCustom.cpp: (WebCore::JSWorkerContext::visitChildren):
- bindings/js/JSXMLHttpRequestCustom.cpp: Use addOpaqueRoot instead of markDOMObjectWrapper, as above. Once again, stand-alone roots.
(WebCore::JSXMLHttpRequest::visitChildren):
- bindings/js/JSXMLHttpRequestUploadCustom.cpp: No need to mark our owner XHR because it is not reachable from us.
- bindings/scripts/CodeGeneratorJS.pm: Added autogeneration support for a bunch of repetitive cases of isReachableFromOpaqueRoots callbacks.
- css/CSSRule.idl:
- css/CSSStyleDeclaration.idl:
- css/MediaList.idl:
- css/StyleMedia.idl:
- css/StyleSheet.idl:
- css/StyleSheetList.idl:
- dom/DOMImplementation.idl:
- dom/DOMStringMap.idl:
- dom/MessagePort.idl:
- dom/NamedNodeMap.idl:
- fileapi/Blob.idl:
- html/DOMTokenList.idl: Opt in to autogeneration.
- html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::getContext): Standardized on PassOwnPtr/OwnPtr usage, to reduce human error and make ownership rules more obvious.
- html/HTMLCollection.idl:
- html/canvas/ArrayBuffer.idl: Opt in to autogeneration.
- html/canvas/CanvasRenderingContext.cpp:
- html/canvas/CanvasRenderingContext.h: (WebCore::CanvasRenderingContext::ref): (WebCore::CanvasRenderingContext::deref):
- html/canvas/CanvasRenderingContext2D.h: (WebCore::CanvasRenderingContext2D::create): (WebCore::CanvasRenderingContext2D::state): Standardized on PassOwnPtr/OwnPtr usage, to reduce human error and make ownership rules more obvious.
Inlined some functions to match our standard idiom and to make the code
in the header document itself.
- html/canvas/CanvasRenderingContext.idl: Opt in to autogeneration.
- html/canvas/OESStandardDerivatives.cpp: (WebCore::OESStandardDerivatives::OESStandardDerivatives): (WebCore::OESStandardDerivatives::create):
- html/canvas/OESStandardDerivatives.h:
- html/canvas/OESStandardDerivatives.idl:
- html/canvas/OESTextureFloat.cpp: (WebCore::OESTextureFloat::OESTextureFloat): (WebCore::OESTextureFloat::create):
- html/canvas/OESTextureFloat.h:
- html/canvas/OESTextureFloat.idl:
- html/canvas/OESVertexArrayObject.cpp: (WebCore::OESVertexArrayObject::OESVertexArrayObject): (WebCore::OESVertexArrayObject::create):
- html/canvas/OESVertexArrayObject.h:
- html/canvas/OESVertexArrayObject.idl:
- html/canvas/WebGLExtension.cpp: (WebCore::WebGLExtension::WebGLExtension):
- html/canvas/WebGLExtension.h: (WebCore::WebGLExtension::ref): (WebCore::WebGLExtension::deref): (WebCore::WebGLExtension::context):
- html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::~WebGLRenderingContext): (WebCore::WebGLRenderingContext::getExtension):
- html/canvas/WebGLRenderingContext.h:
- html/canvas/WebKitLoseContext.cpp: (WebCore::WebKitLoseContext::WebKitLoseContext): (WebCore::WebKitLoseContext::create): (WebCore::WebKitLoseContext::loseContext):
- html/canvas/WebKitLoseContext.h:
- html/canvas/WebKitLoseContext.idl: Updated the ownership model for WebGL canavs rendering contexts to match the model for 2D canvas rendering contexts. This makes garbage collection a lot more straightforward, but it also makes the behavior of these objects more reliable. (Previously, satellite objects would magically stop working when the last reference to their owner object was dropped. Now, satellite objects keep their owner alive through reference counting.)
- loader/appcache/DOMApplicationCache.idl:
- page/BarInfo.idl:
- page/Console.idl:
- page/DOMSelection.idl:
- page/Geolocation.idl:
- page/History.idl:
- page/Location.idl:
- page/Navigator.idl:
- page/Screen.idl:
- page/WorkerNavigator.idl:
- plugins/DOMMimeTypeArray.h: (WebCore::DOMMimeTypeArray::frame):
- plugins/DOMMimeTypeArray.idl:
- plugins/DOMPluginArray.h: (WebCore::DOMPluginArray::frame):
- plugins/DOMPluginArray.idl:
- storage/Storage.idl:
- workers/WorkerLocation.idl: Opt in to autogeneration.
- xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::~XMLHttpRequest):
- xml/XMLHttpRequest.h:
- xml/XMLHttpRequestUpload.cpp: (WebCore::XMLHttpRequestUpload::scriptExecutionContext):
- xml/XMLHttpRequestUpload.h: (WebCore::XMLHttpRequestUpload::create): (WebCore::XMLHttpRequestUpload::ref): (WebCore::XMLHttpRequestUpload::deref): (WebCore::XMLHttpRequestUpload::xmlHttpRequest): (WebCore::XMLHttpRequestUpload::toXMLHttpRequestUpload):
- xml/XMLHttpRequestUpload.idl: Updated the ownership model for XHR and its associated upload object to match the model for canvas. This makes garbage collection a lot more straightforward, but it also makes the behavior of these objects more reliable.
- 5:38 PM April 2011 Meeting edited by
- Make the title of RenderObject guard more descriptive (diff)
- 4:39 PM April 2011 Meeting edited by
- (diff)
- 4:13 PM April 2011 Meeting edited by
- (diff)
- 4:09 PM Changeset in webkit [84763] by
-
- 3 edits2 deletes in trunk
2011-04-24 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r84759.
http://trac.webkit.org/changeset/84759
https://bugs.webkit.org/show_bug.cgi?id=59306
Caused gc-shadow.html to start crashing in V8. (Requested by
dglazkov|away on #webkit).
- fast/dom/shadow/append-child-text-expected.txt: Removed.
- fast/dom/shadow/append-child-text.html: Removed.
2011-04-24 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r84759.
http://trac.webkit.org/changeset/84759
https://bugs.webkit.org/show_bug.cgi?id=59306
Caused gc-shadow.html to start crashing in V8. (Requested by
dglazkov|away on #webkit).
- dom/Node.cpp: (WebCore::NodeRendererFactory::createRendererAndStyle): (WebCore::Node::styleForRenderer):
- 3:53 PM Changeset in webkit [84762] by
-
- 9 edits in trunk
2011-04-24 Maciej Stachowiak <mjs@apple.com>
Reviewed by George Staikos.
Handling of URLs like http:/example.com/ is incorrect
https://bugs.webkit.org/show_bug.cgi?id=59300
<rdar://problem/9231956>
URLs like http:/example.com/ or http:example.com/ are now correctly
canonicalized as http://example.com/
The code still doesn't quite match other browsers - at least some
other browsers seem to base parsing behavior on whether they
recongize a scheme from a fixed list, and ignore whether is
present in the URL or not.
- platform/KURL.cpp: (WebCore::isNonFileHierarchicalScheme): New helper function. (WebCore::KURL::parse): For a particular list of whitelisted schemes, assume they are hierarchical and need an authority even if there is no after the :/
2011-04-24 Maciej Stachowiak <mjs@apple.com>
Reviewed by George Staikos.
Handling of URLs like http:/example.com/ is incorrect
https://bugs.webkit.org/show_bug.cgi?id=59300
<rdar://problem/9231956>
Added some new test cases. Also updated results for the
change. The changes are progressions.
- fast/url/relative-expected.txt:
- fast/url/script-tests/segments.js:
- fast/url/script-tests/standard-url.js:
- fast/url/segments-expected.txt:
- fast/url/segments-from-data-url-expected.txt:
- fast/url/standard-url-expected.txt:
- 2:48 PM Changeset in webkit [84761] by
-
- 3 edits1 add in trunk/LayoutTests
2011-04-24 Adam Barth <abarth@webkit.org>
Update Chromium results for standard-url.html
- platform/chromium-linux/fast/url/standard-url-expected.txt: Added.
- platform/chromium-mac/fast/url/standard-url-expected.txt:
- platform/chromium-win/fast/url/standard-url-expected.txt:
- 2:37 PM Changeset in webkit [84760] by
-
- 2 edits in trunk/Source/WebCore
LLVM Compiler build fix.
- page/ContentSecurityPolicy.cpp: Removed an unused function.
- 2:20 PM Changeset in webkit [84759] by
-
- 3 edits2 adds in trunk
2011-04-24 Dominic Cooney <dominicc@chromium.org>
Reviewed by Dimitri Glazkov.
Crash when adding a text node to a shadow root
https://bugs.webkit.org/show_bug.cgi?id=59304
- fast/dom/shadow/append-child-text-expected.txt: Added.
- fast/dom/shadow/append-child-text.html: Added.
2011-04-24 Dominic Cooney <dominicc@chromium.org>
Reviewed by Dimitri Glazkov.
Crash when adding a text node to a shadow root
https://bugs.webkit.org/show_bug.cgi?id=59304
Text nodes need to consult their host element for style.
Test: fast/dom/shadow/append-child-text.html
- dom/Node.cpp: (WebCore::NodeRendererFactory::styleForRenderer): (WebCore::NodeRendererFactory::createRendererAndStyle): (WebCore::Node::styleForRenderer): forward to NodeRendererFactory
- 11:38 AM Component Model edited by
- (diff)
- 11:38 AM Component Model edited by
- (diff)
- 11:37 AM Component Model edited by
- (diff)
- 11:36 AM Changeset in webkit [84758] by
-
- 15 edits in trunk
2011-04-24 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Update Content-Security-Policy syntax to match new version of spec
https://bugs.webkit.org/show_bug.cgi?id=59291
Update tests to use the new syntax.
- http/tests/security/contentSecurityPolicy/eval-scripts-setInterval-allowed.html:
- http/tests/security/contentSecurityPolicy/eval-scripts-setInterval-blocked.html:
- http/tests/security/contentSecurityPolicy/eval-scripts-setTimeout-allowed.html:
- http/tests/security/contentSecurityPolicy/eval-scripts-setTimeout-blocked.html:
- http/tests/security/contentSecurityPolicy/image-allowed.html:
- http/tests/security/contentSecurityPolicy/image-blocked.html:
- http/tests/security/contentSecurityPolicy/inline-script-allowed.html:
- http/tests/security/contentSecurityPolicy/style-allowed.html:
- http/tests/security/contentSecurityPolicy/style-blocked.html:
- http/tests/security/contentSecurityPolicy/xsl-allowed.php:
- http/tests/security/contentSecurityPolicy/xsl-blocked.php:
2011-04-24 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Update Content-Security-Policy syntax to match new version of spec
https://bugs.webkit.org/show_bug.cgi?id=59291
Brandon removed disable-xss-protection in favor of unsafe-inline and
allow-eval in favor of unsafe-eval. This change in syntax also means
the options directive no longer exists.
- page/ContentSecurityPolicy.cpp: (WebCore::CSPSourceList::allowInline): (WebCore::CSPSourceList::allowEval): (WebCore::CSPSourceList::CSPSourceList): (WebCore::CSPSourceList::parseSource): (WebCore::CSPSourceList::addSourceUnsafeInline): (WebCore::CSPSourceList::addSourceUnsafeEval): (WebCore::CSPDirective::allowInline): (WebCore::CSPDirective::allowEval): (WebCore::ContentSecurityPolicy::allowJavaScriptURLs): (WebCore::ContentSecurityPolicy::allowInlineEventHandlers): (WebCore::ContentSecurityPolicy::allowInlineScript): (WebCore::ContentSecurityPolicy::allowEval): (WebCore::ContentSecurityPolicy::addDirective):
- page/ContentSecurityPolicy.h:
- 11:29 AM Changeset in webkit [84757] by
-
- 3 edits1 add in trunk/Source
../WebCore: Manual test for <rdar://problem/9329741> Reproducible crash in WebChromeClient::invalidateContentsAndWindow() on simonscat.com
https://bugs.webkit.org/show_bug.cgi?id=59299
Reviewed by Maciej Stachowiak.
- manual-tests/back-from-document-with-scrollbar.html: Added.
../WebKit2: <rdar://problem/9329741> Reproducible crash in WebChromeClient::invalidateContentsAndWindow() on simonscat.com
https://bugs.webkit.org/show_bug.cgi?id=59299
Reviewed by Maciej Stachowiak.
- WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::invalidateContentsAndWindow): Null-check the document.
(WebKit::WebChromeClient::invalidateContentsForSlowScroll): Ditto.
- 10:50 AM April 2011 Meeting edited by
- (diff)
- 9:25 AM Component Model edited by
- (diff)
- 9:25 AM Component Model edited by
- (diff)
- 9:23 AM Component Model edited by
- (diff)
- 9:02 AM Component Model created by
- 2:41 AM April 2011 Meeting edited by
- (diff)
- 2:41 AM April 2011 Meeting edited by
- (diff)
- 2:40 AM April 2011 Meeting edited by
- (diff)
- 2:23 AM April 2011 Meeting edited by
- (diff)
- 2:14 AM Changeset in webkit [84756] by
-
- 5 edits in trunk/LayoutTests
2011-04-24 Adam Barth <abarth@webkit.org>
Reviewed by Maciej Stachowiak.
Test canonicalization of scheme:/host
https://bugs.webkit.org/show_bug.cgi?id=59296
- fast/url/script-tests/segments.js:
- fast/url/script-tests/standard-url.js:
- fast/url/segments-expected.txt:
- fast/url/standard-url-expected.txt:
- 1:17 AM Changeset in webkit [84755] by
-
- 3 edits2 adds in trunk
2011-04-24 Rik Cabanier <cabanier@adobe.com>
Reviewed by Simon Fraser.
Tables are not rendered correctly
https://bugs.webkit.org/show_bug.cgi?id=59138
- fast/table/auto-100-percent-width.html: Added.
- platform/mac/fast/table/auto-100-percent-width-expected.txt: Added.
2011-04-24 Rik Cabanier <cabanier@adobe.com>
Reviewed by Simon Fraser.
Tables are not rendered correctly
https://bugs.webkit.org/show_bug.cgi?id=59138
Test: fast/table/auto-100-percent-width.html
- rendering/AutoTableLayout.cpp: (WebCore::AutoTableLayout::computePreferredLogicalWidths):
Apr 23, 2011:
- 11:22 PM Changeset in webkit [84754] by
-
- 2 edits in trunk/WebKitLibraries
[WinCairo] Unreviewed build change.
Activate Geolocation API, as it will work with WinCairo assuming
an appropriate Geolocation Provider is registered.
- win/tools/vsprops/FeatureDefinesCairo.vsprops: Activate the Geolocation features.
- 11:01 PM Changeset in webkit [84753] by
-
- 2 edits in trunk/Source/WebCore
2011-04-23 Simon Fraser <Simon Fraser>
Fix Windows build, which complains about unreachable code.
- platform/ScrollableArea.cpp: (WebCore::ScrollableArea::hasLayerForHorizontalScrollbar): (WebCore::ScrollableArea::hasLayerForVerticalScrollbar): (WebCore::ScrollableArea::hasLayerForScrollCorner):
- 10:53 PM Changeset in webkit [84752] by
-
- 5 edits in trunk/Source/WebCore
2011-04-23 Simon Fraser <Simon Fraser>
Reviewed by Dan Bernstein.
Area under composited scrollbars not repainted in WebKit2 on scrolling
https://bugs.webkit.org/show_bug.cgi?id=59294
<rdar://problem/9299062>
When computing the rect that can be copied on scrolling, we normally
exclude the areas occupied by overlay scrollbars to avoid smeared scrollbars;
the assumption is that other code will repaint these areas. However, when
scrollbars are in their own compositing layers, we can, and should
copy the entire area.
Not testable in DRT because it does not allow tests to use overlay scrollbars.
- platform/ScrollView.h:
- platform/ScrollView.cpp: (WebCore::ScrollView::rectToCopyOnScroll): New method, with code moved from scrollContents and fixed to look for scrollbars in layers. (WebCore::ScrollView::scrollContents): Call rectToCopyOnScroll().
- platform/ScrollableArea.h:
- platform/ScrollableArea.cpp: (WebCore::ScrollableArea::hasLayerForHorizontalScrollbar): (WebCore::ScrollableArea::hasLayerForVerticalScrollbar): (WebCore::ScrollableArea::hasLayerForScrollCorner): Methods we can call outside of the ACCELERATED_COMPOSITING #ifdef.
- 8:59 PM Changeset in webkit [84751] by
-
- 13 edits in trunk/Source
2011-04-23 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r84740.
http://trac.webkit.org/changeset/84740
https://bugs.webkit.org/show_bug.cgi?id=59290
change breaks apple internal builds and is incorrect
(Requested by smfr on #webkit).
- WebCore.exp.in:
- page/FrameView.cpp:
- page/FrameView.h:
- platform/ScrollTypes.h:
- platform/ScrollableArea.h:
- platform/mac/ScrollbarThemeMac.mm: (WebCore::ScrollbarThemeMac::paint):
- platform/mac/WebCoreSystemInterface.h:
- platform/mac/WebCoreSystemInterface.mm:
2011-04-23 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r84740.
http://trac.webkit.org/changeset/84740
https://bugs.webkit.org/show_bug.cgi?id=59290
change breaks apple internal builds and is incorrect
(Requested by smfr on #webkit).
- WebCoreSupport/WebSystemInterface.mm: (InitWebCoreSystemInterface):
2011-04-23 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r84740.
http://trac.webkit.org/changeset/84740
https://bugs.webkit.org/show_bug.cgi?id=59290
change breaks apple internal builds and is incorrect
(Requested by smfr on #webkit).
- WebProcess/WebCoreSupport/mac/WebSystemInterface.mm: (InitWebCoreSystemInterface):
- 8:56 PM Changeset in webkit [84750] by
-
- 5 edits in trunk
<rdar://problem/8970549> WebFindOptionsAtWordStarts fails with Japanese words
https://bugs.webkit.org/show_bug.cgi?id=59288
Reviewed by Simon Fraser.
Source/WebCore:
- platform/text/mac/TextBoundaries.mm:
(WebCore::wordStringTokenizer): Added this helper function.
(WebCore::findNextWordFromIndex): Changed to use a CFStringTokenizer with kCFStringTokenizerUnitWord,
whose behavior is not locale-dependent.
LayoutTests:
- editing/text-iterator/findString-expected.txt:
- editing/text-iterator/findString.html:
- 7:24 PM April 2011 Meeting edited by
- (diff)
- 7:12 PM April 2011 Meeting edited by
- (diff)
- 7:10 PM April 2011 Meeting edited by
- (diff)
- 7:08 PM April 2011 Meeting edited by
- (diff)
- 7:07 PM April 2011 Meeting edited by
- (diff)
- 6:31 PM Changeset in webkit [84749] by
-
- 5 edits2 adds in trunk
2011-04-23 Dominic Cooney <dominicc@chromium.org>
Reviewed by Dimitri Glazkov.
[V8] Nodes in shadow DOM should not be GCed while their hosts are alive
https://bugs.webkit.org/show_bug.cgi?id=59284
- fast/dom/shadow/gc-shadow-expected.txt: Added.
- fast/dom/shadow/gc-shadow.html: Added.
2011-04-23 Dominic Cooney <dominicc@chromium.org>
Reviewed by Dimitri Glazkov.
[V8] Nodes in shadow DOM should not be GCed while their hosts are alive
https://bugs.webkit.org/show_bug.cgi?id=59284
Test: fast/dom/shadow/gc-shadow.html
- bindings/v8/V8GCController.cpp: (WebCore::calculateGroupId): group shadow nodes with their hosts
2011-04-23 Dominic Cooney <dominicc@chromium.org>
Reviewed by Dimitri Glazkov.
[V8] Nodes in shadow DOM should not be GCed while their hosts are alive
https://bugs.webkit.org/show_bug.cgi?id=59284
Chromium DRT over-refcounted the NPObject wrappers it used to
marshal shadowRoot nodes back to tests (WebBindings::makeNode
births NPObjects with referenceCount == 1). This masked the GC bug
59284 in tests by making shadowRoot nodes live forever.
- DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::shadowRoot): (LayoutTestController::ensureShadowRoot):
- 6:05 PM Changeset in webkit [84748] by
-
- 3 edits in trunk/Source/JavaScriptCore
Bug 59287 - DFG JIT - Handle temporaries as vars, allowing support for ?:
Reviewed by Oliver Hunt.
SetLocals to temporaries will only be generated if they are used within other
blocks, due to the SSA based DCE.
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::ByteCodeParser):
(JSC::DFG::ByteCodeParser::get):
(JSC::DFG::ByteCodeParser::set):
(JSC::DFG::ByteCodeParser::getLocal):
(JSC::DFG::ByteCodeParser::setLocal):
(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::processPhiStack):
(JSC::DFG::ByteCodeParser::allocateVirtualRegisters):
(JSC::DFG::ByteCodeParser::parse):
- dfg/DFGGraph.h:
(JSC::DFG::BasicBlock::BasicBlock):
- 5:51 PM Changeset in webkit [84747] by
-
- 4 edits in trunk/Source/WebCore
2011-04-23 MORITA Hajime <morrita@google.com>
Reviewed by Dimitri Glazkov.
[Refactoring] NodeRenderParentDetector should be NodeRenderFactory
https://bugs.webkit.org/show_bug.cgi?id=59280
- Rename NodeRenderParentDetector to NodeRendererFactory
- move createRendererAndStyle() and createRendererIfNeeded to NodeRendererFactory
No new test, no behavioral change.
- dom/Node.cpp: (WebCore::NodeRendererFactory::NodeRendererFactory): (WebCore::NodeRendererFactory::document): (WebCore::NodeRendererFactory::nextRenderer): (WebCore::NodeRendererFactory::findVisualParent): (WebCore::NodeRendererFactory::shouldCreateRenderer): (WebCore::NodeRendererFactory::createRendererAndStyle): (WebCore::NodeRendererFactory::createRendererIfNeeded): (WebCore::Node::parentNodeForRenderingAndStyle): (WebCore::Node::createRendererIfNeeded):
- dom/Node.h:
- html/HTMLDetailsElement.cpp: (WebCore::DetailsSummaryElement::detailsElement): Added const_cast due to the chage on parentNodeForRenderingAndStyle()
- 5:17 PM Changeset in webkit [84746] by
-
- 2 edits in trunk/LayoutTests
2011-04-23 MORITA Hajime <morrita@google.com>
Unreviewed test_expectations.txt update.
r84745 didn't fix meter-element.html break on chromium.
- platform/chromium/test_expectations.txt:
- 4:16 PM Changeset in webkit [84745] by
-
- 4 edits6 adds in trunk
2011-04-23 MORITA Hajime <morrita@google.com>
Reviewed by Kent Tamura.
REGRESSION: (non-Mac) <meter>'s bar part isn't rendered for with -webkit-writing-mode: vertical-lr from r82899
https://bugs.webkit.org/show_bug.cgi?id=59281
- fast/dom/HTMLMeterElement/meter-writing-mode.html: Added.
- fast/dom/HTMLProgressElement/progress-writing-mode.html: Added.
- platform/chromium/test_expectations.txt:
- platform/mac/fast/dom/HTMLMeterElement/meter-writing-mode-expected.png: Added.
- platform/mac/fast/dom/HTMLMeterElement/meter-writing-mode-expected.txt: Added.
- platform/mac/fast/dom/HTMLProgressElement/progress-writing-mode-expected.png: Added.
- platform/mac/fast/dom/HTMLProgressElement/progress-writing-mode-expected.txt: Added.
2011-04-23 MORITA Hajime <morrita@google.com>
Reviewed by Kent Tamura.
REGRESSION: (non-Mac) <meter>'s bar part isn't rendered for with -webkit-writing-mode: vertical-lr from r82899
https://bugs.webkit.org/show_bug.cgi?id=59281
Styles for -webkit-meter-bar and -webkit-progress-bar missed width property, which caused unexpected layout results
for vertical writing modes. This fix added a width property for each of them.
Tests: fast/dom/HTMLMeterElement/meter-writing-mode.html
fast/dom/HTMLProgressElement/progress-writing-mode.html
- css/html.css: (meter::-webkit-meter-bar): (progress::-webkit-progress-bar):
- 1:16 PM Changeset in webkit [84744] by
-
- 8 edits in trunk/Source/JavaScriptCore
Bug 59266 - DFG JIT - Add SSA style DCE
Reviewed by Sam Weinig & Geoff Garen.
This works by making GetLocal nodes reference SetLocal nodes from prior blocks,
via intermediate Phi nodes. Whenever we add a GetLocal to the graph, also add a
matching child Phi, and add the Phi to a work queue to add references to prior
definitions once we have the full CFG & can determine predecessors. This process
is iterative, inserting new phis into predecessors as necessary.
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::getVariable):
(JSC::DFG::ByteCodeParser::setVariable):
(JSC::DFG::ByteCodeParser::getArgument):
(JSC::DFG::ByteCodeParser::setArgument):
(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::processWorkQueue):
(JSC::DFG::ByteCodeParser::allocateVirtualRegisters):
(JSC::DFG::ByteCodeParser::parse):
- dfg/DFGGraph.cpp:
(JSC::DFG::Graph::dump):
(JSC::DFG::Graph::refChildren):
- dfg/DFGGraph.h:
(JSC::DFG::Graph::ref):
- dfg/DFGNode.h:
(JSC::DFG::Node::ref):
- dfg/DFGNonSpeculativeJIT.cpp:
(JSC::DFG::NonSpeculativeJIT::compile):
- dfg/DFGScoreBoard.h:
(JSC::DFG::ScoreBoard::~ScoreBoard):
(JSC::DFG::ScoreBoard::dump):
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- 1:05 PM Changeset in webkit [84743] by
-
- 7 edits in trunk
[wx] Unreviewed build fixes for recent trunk changes.
- 12:14 PM Changeset in webkit [84742] by
-
- 10 edits in trunk
2011-04-23 Alexey Proskuryakov <ap@apple.com>
Unreviewed.
REGRESSION (r80812): window.print();window.close() doesn't work in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=59241
<rdar://problem/9150861>
- http/tests/misc/will-send-request-returns-null-on-redirect-expected.txt:
- http/tests/security/XFrameOptions/x-frame-options-deny-expected.txt:
- http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-deny-expected.txt: Resource load delegates for cancelled loads are now correctly sent before frame load delegate's didFinishLoading, so cancellation errors get logged by DumpRenderTree.
2011-04-23 Alexey Proskuryakov <ap@apple.com>
Reviewed by Maciej Stachowiak.
REGRESSION (r80812): window.print();window.close() doesn't work in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=59241
<rdar://problem/9150861>
Covered by manual-tests/print-after-window-close.html.
Re-fixing <https://bugs.webkit.org/show_bug.cgi?id=51357> in a way that doesn't cause the
regression.
- loader/MainResourceLoader.cpp: (WebCore::MainResourceLoader::didCancel): We shouldn't be doing complicated work while the loader is half-canceled.
- manual-tests/print-after-window-close.html: Extended to actually print a non-empty page, thus being more practical.
- page/Chrome.cpp: (WebCore::Chrome::print): Added a FIXME about a need for PageGroupLoadDeferrer. It's too scary for me to try now.
- page/DOMWindow.cpp: (WebCore::DOMWindow::DOMWindow): (WebCore::DOMWindow::finishedLoading):
- page/DOMWindow.h: Reverted the previous fix for <https://bugs.webkit.org/show_bug.cgi?id=51357>.
- 12:11 AM Changeset in webkit [84741] by
-
- 6 edits in trunk/Source/WebCore
2011-04-19 Vitaly Repeshko <vitalyr@chromium.org>
Reviewed by Adam Barth.
[V8] Use implicit references for V8 listeners on DOM nodes.
https://bugs.webkit.org/show_bug.cgi?id=58953
Instead of allocating an auxiliary V8 array referencing V8
listener objects associated with a DOM node and using an extra
pointer in every DOM node wrapper, we can register implicit
references between nodes and their listeners during GC. This also
makes V8 bindings more aligned with JSC bindings.
No new tests because this is a refactoring.
- bindings/scripts/CodeGeneratorV8.pm: Stopped generating the listener cache internal field for DOM nodes.
- bindings/v8/V8AbstractEventListener.h: Exposed the lister handle to the GC. (WebCore::V8AbstractEventListener::existingListenerObjectPeristentHandle):
- bindings/v8/V8GCController.cpp: Started using implicit references. (WebCore::GrouperVisitor::visitDOMWrapper):
- dom/EventTarget.h: Implemented an iterator over all listeners. (WebCore::EventListenerIterator):
