Timeline
Apr 19, 2012:
- 11:58 PM Changeset in webkit [114721] by
-
- 6 edits in trunk
[EFL] Missing keycode translation for space key
https://bugs.webkit.org/show_bug.cgi?id=84153
Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-04-19
Reviewed by Antonio Gomes.
Source/WebCore:
Map space key to Unicode value in createKeyMap(), and also set
correct keyname 'space' for space key in createWindowsKeyMap().
Tests: fast/html/details-keyboard-show-hide.html
fast/forms/button-spacebar-click.html
- platform/efl/EflKeyboardUtilities.cpp:
(WebCore::createKeyMap):
Tools:
Set keyname for space key before dispatching event.
- DumpRenderTree/efl/EventSender.cpp:
(keyNameFromJSValue):
LayoutTests:
Unskip tests connected with space key.
- platform/efl/Skipped:
- 11:53 PM April 2012 MeetingRethinkingRendering edited by
- (diff)
- 11:47 PM Changeset in webkit [114720] by
-
- 3 edits2 adds in trunk/Tools
[GTK] Allow to use WebInspector in GtkLauncher
https://bugs.webkit.org/show_bug.cgi?id=84143
Reviewed by Martin Robinson.
- GNUmakefile.am: Add new files to compilation.
- GtkLauncher/LauncherInspectorWindow.c: Added.
(launcherInspectorWindowFinalize):
(launcher_inspector_window_init):
(launcher_inspector_window_class_init):
(inspectedURIChanged): Update the window title based on current
inspected URI.
(showInspectorWindow): Show inspector window.
(closeInspectorWindow): Hide inspector window.
(launcherInspectorWindowNew): Create an inspector window.
(launcherInspectorWindowGetWebView): Return the inspected web view.
- GtkLauncher/LauncherInspectorWindow.h: Added.
- GtkLauncher/main.c:
(inspectorInspectWebViewCb): Create an inspector window.
(createBrowser): Connect to inspect-web-view signal of the view
inspector.
- 11:44 PM Changeset in webkit [114719] by
-
- 4 edits in trunk/Source/WebKit2
[GTK] Ignore resources while replacing content in WebKit2 GTK+ API
https://bugs.webkit.org/show_bug.cgi?id=79777
Reviewed by Philippe Normand.
- UIProcess/API/gtk/WebKitResourceLoadClient.cpp:
(didSendRequestForResource): Return early if resources is Null.
(didReceiveResponseForResource): Ditto.
(didReceiveContentLengthForResource): Ditto.
(didFinishLoadForResource): Ditto.
(didFailLoadForResource): Ditto.
- UIProcess/API/gtk/WebKitWebView.cpp:
(webkitWebViewLoadChanged): Clear resources before checking
whether we are replacing content.
(webkitWebViewIsReplacingContentOrDidReplaceContent): Helper
function to check whether view is replacing content or current
content is replaced.
(webkitWebViewResourceLoadStarted): Do not create resources when
replacing content.
(webkitWebViewGetLoadingWebResource): Ignore when replacing
content. Also add an assert when getting a loading resources to
make sure we only return Null when replacing content.
(webkitWebViewRemoveLoadingWebResource): Ditto.
(webkitWebViewResourceLoadFinished): Ditto.
- UIProcess/API/gtk/tests/TestResources.cpp:
(replacedContentResourceLoadStartedCallback):
(testWebViewResourcesReplacedContent):
(beforeAll):
- 11:18 PM Changeset in webkit [114718] by
-
- 3 edits2 adds in trunk
Inserting empty html moves caret.
https://bugs.webkit.org/show_bug.cgi?id=71771
Patch by Antaryami Pandia <antaryami.pandia@motorola.com> on 2012-04-19
Reviewed by Ryosuke Niwa.
Source/WebCore:
When we place the cursor in the middle of a text node and try to insert some text
between, then we split text node. But in this case we have nothing to insert since
the string to be inserted is empty. So the check for fragments should precedes the
call to code block containing splitTextNode.
Test: editing/inserting/insert-empty-html.html
- editing/ReplaceSelectionCommand.cpp:
(WebCore::ReplaceSelectionCommand::doApply):
LayoutTests:
Test inserting empty html.
- editing/inserting/insert-empty-html-expected.txt: Added.
- editing/inserting/insert-empty-html.html: Added.
- 10:35 PM Changeset in webkit [114717] by
-
- 4 edits in trunk/Source
Versioning.
- 10:23 PM Changeset in webkit [114716] by
-
- 1 copy in tags/Safari-536.8
New Tag.
- 9:49 PM WebComponentsStatusMeetingNotes edited by
- formatting! (diff)
- 8:35 PM Changeset in webkit [114715] by
-
- 2 edits in trunk/Source/WebCore
[BlackBerry] Update HTTP connection per host limit in ResourceRequestBlackBerry
https://bugs.webkit.org/show_bug.cgi?id=84380
Patch by Tay Grigg <tgrigg@rim.com> on 2012-04-19
Reviewed by George Staikos.
Reviewed Internally by: George Rizkalla, Lyon Chen
Set the limit on the http connection count per host to the default
of 10000, queue the requests in the networking layer instead,
this should increase parallelism at the WebKit layer to remove
any potential bottlenecks.
- platform/network/blackberry/ResourceRequestBlackBerry.cpp:
(WebCore::initializeMaximumHTTPConnectionCountPerHost):
- 8:29 PM Changeset in webkit [114714] by
-
- 8 edits in trunk
Media Stream API: Piece of code cleanup for the chromium port
https://bugs.webkit.org/show_bug.cgi?id=84328
Patch by Jeremy Mao <yujie.mao@intel.com> on 2012-04-19
Reviewed by Kent Tamura.
Source/WebKit/chromium:
Remove some deprecated interfaces.
No new tests. No behavior changes.
- public/WebUserMediaClient.h:
Remove deprecated requestUserMedia interface.
- public/WebUserMediaRequest.h:
Remove deprecated requestSucceeded interface.
- src/UserMediaClientImpl.cpp:
(WebKit::UserMediaClientImpl::requestUserMedia):
Use the requestUserMedia split sources implementation.
- src/WebUserMediaRequest.cpp:
Remove deprecated requestSucceeded implementation.
Tools:
WebUserMediaClientMock use an old requestUserMedia interface and
Replace it with the new interface.
- DumpRenderTree/chromium/WebUserMediaClientMock.cpp:
(WebKit::WebUserMediaClientMock::requestUserMedia):
Remove the old requestUserMedia and replace it with the new.
- DumpRenderTree/chromium/WebUserMediaClientMock.h:
(WebUserMediaClientMock):
- 7:32 PM Changeset in webkit [114713] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed, rolling out r114711.
http://trac.webkit.org/changeset/114711
https://bugs.webkit.org/show_bug.cgi?id=84412
Many tests crash in RenderObject::container() (Requested by
dimich on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-19
- page/scrolling/ScrollingCoordinator.cpp:
(WebCore::computeNonFastScrollableRegion):
(WebCore::ScrollingCoordinator::frameViewLayoutUpdated):
(WebCore::ScrollingCoordinator::frameViewScrollableAreasDidChange):
- 7:07 PM Changeset in webkit [114712] by
-
- 1 edit2 moves12 deletes in trunk/LayoutTests
Not reviewed, re-update baselines for new tests
added in http://trac.webkit.org/changeset/114666
and then modified in http://trac.webkit.org/changeset/114685
- platform/chromium-linux/fast/ruby/floating-ruby-text-expected.txt: Removed.
- platform/chromium-linux/fast/ruby/positioned-ruby-text-expected.txt: Removed.
- platform/chromium-mac-leopard/fast/ruby/floating-ruby-text-expected.txt: Removed.
- platform/chromium-mac-leopard/fast/ruby/positioned-ruby-text-expected.txt: Removed.
- platform/chromium-mac-snowleopard/fast/ruby/floating-ruby-text-expected.txt: Removed.
- platform/chromium-mac-snowleopard/fast/ruby/positioned-ruby-text-expected.txt: Removed.
- platform/chromium-mac/fast/ruby/floating-ruby-text-expected.txt: Removed.
- platform/chromium-mac/fast/ruby/positioned-ruby-text-expected.txt: Removed.
- platform/chromium-win-vista/fast/ruby/floating-ruby-text-expected.txt: Removed.
- platform/chromium-win-vista/fast/ruby/positioned-ruby-text-expected.txt: Removed.
- platform/chromium-win/fast/ruby/floating-ruby-text-expected.txt: Removed.
- platform/chromium-win/fast/ruby/positioned-ruby-text-expected.txt: Removed.
- platform/chromium/fast/ruby/floating-ruby-text-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/fast/ruby/floating-ruby-text-expected.txt.
- platform/chromium/fast/ruby/positioned-ruby-text-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/fast/ruby/positioned-ruby-text-expected.txt.
- 6:40 PM Changeset in webkit [114711] by
-
- 2 edits in trunk/Source/WebCore
computeNonFastScrollableRegion needs to traverse the entire frame tree
https://bugs.webkit.org/show_bug.cgi?id=84409
<rdar://problem/11285741>
Reviewed by Dan Bernstein.
Now that scrollable areas won't be in the set of scrollable areas unless they are actually scrollable, we need to look for scrollable
areas in the entire frame tree since there can be a scrollable frame that's a subframe of a non-scrollable frame for example.
- page/scrolling/ScrollingCoordinator.cpp:
(WebCore::computeNonFastScrollableRegion):
Traverse the entire frame tree looking for scrollable areas. Also, remove the scrollability checks because scrollable areas will only be
in the set if they have scrollbars that are enabled.
(WebCore::ScrollingCoordinator::frameViewLayoutUpdated):
(WebCore::ScrollingCoordinator::frameViewScrollableAreasDidChange):
computeNonFastScrollableRegion now takes the main frame.
- 6:40 PM Changeset in webkit [114710] by
-
- 1 edit in branches/chromium/1084/Source/WebCore/css/CSSImportRule.cpp
Merge 114350 - Stack overflow in CSS parser caused by recursive stylesheet import
https://bugs.webkit.org/show_bug.cgi?id=83545
Patch by David Barr <davidbarr@chromium.org> on 2012-04-16
Reviewed by Ryosuke Niwa.
Source/WebCore:
Test: http/tests/css/css-imports-redirect-cycle.html
- css/CSSImportRule.cpp:
(WebCore::StyleRuleImport::requestStyleSheet):
LayoutTests:
- http/tests/css/css-imports-redirect-cycle-expected.txt: Added.
- http/tests/css/css-imports-redirect-cycle.css: Added.
- http/tests/css/css-imports-redirect-cycle.html: Added.
BUG=122606
TBR=commit-queue@webkit.org
Review URL: https://chromiumcodereview.appspot.com/10143006
- 6:14 PM Changeset in webkit [114709] by
-
- 1 edit in branches/chromium/1084/Source/WebCore/platform/graphics/chromium/UniscribeHelper.cpp
Merge 114267 - [chromium] wrong justification for arabic/persian page in cr-win.
https://bugs.webkit.org/show_bug.cgi?id=83227
Reviewed by Kent Tamura.
Source/WebCore:
Disable kashida justification if using Skia to draw.
Test: fast/text/international/arabic-justify.html
- platform/graphics/chromium/UniscribeHelper.cpp:
(WebCore::UniscribeHelper::justify):
LayoutTests:
- fast/text/international/arabic-justify.html: Added.
- platform/chromium-win/fast/text/international/arabic-justify-expected.png: Added.
- platform/chromium-win/fast/text/international/arabic-justify-expected.txt: Added.
- platform/chromium/test_expectations.txt:
- platform/gtk/fast/text/international/arabic-justify-expected.txt: Added.
- platform/mac-snowleopard/fast/text/international/arabic-justify-expected.png: Added.
- platform/mac-snowleopard/fast/text/international/arabic-justify-expected.txt: Added.
- platform/mac/fast/text/international/arabic-justify-expected.txt: Added.
- platform/qt/fast/text/international/arabic-justify-expected.txt: Added.
TBR=xji@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10154002
- 5:59 PM Internals_Hackathon edited by
- (diff)
- 5:58 PM Changeset in webkit [114708] by
-
- 7 edits in trunk/Source/WebKit/chromium
[Chromium] IndexedDB: Prep for changing keyPath return type
https://bugs.webkit.org/show_bug.cgi?id=84208
To introduce Array-type key paths (see http://webkit.org/b/84207) the keyPath() accessors
on WebIDBObjectStore and WebIDBIndex need to change return type. To do so requires temporarily
changing the method names to keyPathString with compatibility shims (on the WebKit side)
then switching the implementation in the Chromium port in a follow-up patch.
Reviewed by Kent Tamura.
- public/WebIDBIndex.h:
(WebKit::WebIDBIndex::keyPath):
(WebKit::WebIDBIndex::keyPathString):
- public/WebIDBObjectStore.h:
(WebKit::WebIDBObjectStore::keyPath):
(WebKit::WebIDBObjectStore::keyPathString):
- src/WebIDBIndexImpl.cpp:
(WebKit::WebIDBIndexImpl::keyPathString):
- src/WebIDBIndexImpl.h:
(WebIDBIndexImpl):
- src/WebIDBObjectStoreImpl.cpp:
(WebKit::WebIDBObjectStoreImpl::keyPathString):
- src/WebIDBObjectStoreImpl.h:
(WebIDBObjectStoreImpl):
- 5:50 PM Changeset in webkit [114707] by
-
- 4 edits in trunk/Source/WebCore
Focus ring on wikipedia gets blobs when you type
https://bugs.webkit.org/show_bug.cgi?id=84407
<rdar://problem/11011847>
Reviewed by Dan Bernstein.
Make it possible to override the focus ring visible rect from layer drawing code.
- platform/graphics/mac/WebLayer.mm:
(drawLayerContents):
Call ThemeMac::setFocusRingClipRect to set the focus ring clip rect while drawing.
- platform/mac/ThemeMac.h:
- platform/mac/ThemeMac.mm:
(-[WebCoreFlippedView _focusRingVisibleRect]):
If there's an active focus ring visible rect, use it. Otherwise, fall back to the previous behavior
and just return the view's visible rect.
(WebCore::ThemeMac::setFocusRingClipRect):
Update the focus clip rect.
- 5:48 PM Changeset in webkit [114706] by
-
- 1 edit2 deletes in trunk/LayoutTests
Rollout r114674.
New tests added in http://trac.webkit.org/changeset/114685 made the
platform results added in http://trac.webkit.org/changeset/114674
unnecessary.
- platform/mac/fast/ruby/floating-ruby-text-expected.txt: Removed.
- platform/mac/fast/ruby/positioned-ruby-text-expected.txt: Removed.
- 5:37 PM Changeset in webkit [114705] by
-
- 6 edits in trunk/Source/WebKit2
[Qt] ASSERT(m_thread == currentThread()) on Mac when threaded rendering is enabled for the Qt scenegraph
https://bugs.webkit.org/show_bug.cgi?id=84278
Reviewed by Noam Rosenthal.
Delete the whole layer tree on UI side when paint node is deleted and force resync of the layers when
page becomes visible again.
- UIProcess/LayerTreeHostProxy.cpp:
(WebKit::LayerTreeHostProxy::purgeBackingStores):
- UIProcess/WebLayerTreeRenderer.cpp:
(WebKit::WebLayerTreeRenderer::WebLayerTreeRenderer):
(WebKit::WebLayerTreeRenderer::purgeGLResources):
(WebKit::WebLayerTreeRenderer::appendUpdate):
(WebKit::WebLayerTreeRenderer::setActive):
(WebKit):
- UIProcess/WebLayerTreeRenderer.h:
(WebLayerTreeRenderer):
- UIProcess/qt/QtWebPageSGNode.cpp:
(WebKit::ContentsSGNode::ContentsSGNode):
- WebProcess/WebCoreSupport/WebGraphicsLayer.cpp:
(WebCore::WebGraphicsLayer::purgeBackingStores):
- 5:33 PM Changeset in webkit [114704] by
-
- 2 edits in trunk/LayoutTests
Partial rollout of r114673.
Test plugins/npp-set-window-called-during-destruction.html passes on mac-wk2,
but fails on mac. Update test_expectations so that both results are expected.
- platform/mac/test_expectations.txt:
- 5:33 PM Changeset in webkit [114703] by
-
- 3 edits in trunk/Source/WebCore
Unreviewed, rolling out r114690.
http://trac.webkit.org/changeset/114690
https://bugs.webkit.org/show_bug.cgi?id=84408
Broke GlueSerializeTest.BackwardsCompatibleTest in Chromium
test_shell_tests (Requested by dimich on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-19
- history/HistoryItem.cpp:
(WebCore::HistoryItem::HistoryItem):
- loader/HistoryController.cpp:
(WebCore::HistoryController::restoreScrollPositionAndViewState):
- 5:23 PM Deprecating features and vendor prefixes created by
- 5:17 PM Changeset in webkit [114702] by
-
- 25 edits in trunk
Exception stack traces aren't complete when the exception starts in native code
https://bugs.webkit.org/show_bug.cgi?id=84073
Reviewed by Filip Pizlo.
Source/JavaScriptCore:
Refactored building the stack trace to so that we can construct
it earlier, and don't rely on any prior work performed in the
exception handling machinery. Also updated LLInt and the DFG to
completely initialise the callframes of host function calls.
Also fixed a few LLInt paths that failed to correctly update the
topCallFrame.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- dfg/DFGJITCompiler.h:
- dfg/DFGOperations.cpp:
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::emitCall):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::emitCall):
- interpreter/Interpreter.cpp:
(JSC::eval):
(JSC::Interpreter::getStackTrace):
(JSC::Interpreter::addStackTraceIfNecessary):
(JSC):
(JSC::Interpreter::throwException):
- interpreter/Interpreter.h:
(Interpreter):
- jit/JITCall.cpp:
(JSC::JIT::compileOpCall):
- jit/JITCall32_64.cpp:
(JSC::JIT::compileOpCall):
- jit/JITOpcodes.cpp:
(JSC::JIT::privateCompileCTINativeCall):
- jit/JITOpcodes32_64.cpp:
(JSC::JIT::privateCompileCTINativeCall):
- jsc.cpp:
(functionJSCStack):
- llint/LLIntExceptions.cpp:
(JSC::LLInt::interpreterThrowInCaller):
(JSC::LLInt::returnToThrow):
(JSC::LLInt::callToThrow):
- llint/LLIntSlowPaths.cpp:
(JSC::LLInt::handleHostCall):
- llint/LowLevelInterpreter32_64.asm:
- llint/LowLevelInterpreter64.asm:
- parser/Parser.h:
(JSC::::parse):
- runtime/Error.cpp:
(JSC::addErrorInfo):
(JSC::throwError):
- runtime/Error.h:
(JSC):
LayoutTests:
Update tests to show complete trace information
- fast/js/exception-properties-expected.txt:
- fast/js/script-tests/exception-properties.js:
- fast/js/script-tests/stack-trace.js:
(selfRecursive1):
- fast/js/stack-trace-expected.txt:
- 5:12 PM Changeset in webkit [114701] by
-
- 1 edit18 adds in trunk/LayoutTests
[Chromium] Rebaselining new tests added in http://trac.webkit.org/changeset/114666
Not reviewed.
- platform/chromium-linux-x86/fast/ruby/floating-ruby-text-expected.txt: Added.
- platform/chromium-linux-x86/fast/ruby/positioned-ruby-text-expected.txt: Added.
- platform/chromium-linux/fast/ruby/floating-ruby-text-expected.txt: Added.
- platform/chromium-linux/fast/ruby/positioned-ruby-text-expected.txt: Added.
- platform/chromium-mac-leopard/fast/ruby/floating-ruby-text-expected.txt: Added.
- platform/chromium-mac-leopard/fast/ruby/positioned-ruby-text-expected.txt: Added.
- platform/chromium-mac-snowleopard/fast/ruby/floating-ruby-text-expected.txt: Added.
- platform/chromium-mac-snowleopard/fast/ruby/positioned-ruby-text-expected.txt: Added.
- platform/chromium-mac/fast/ruby/floating-ruby-text-expected.txt: Added.
- platform/chromium-mac/fast/ruby/positioned-ruby-text-expected.txt: Added.
- platform/chromium-win-vista/fast/ruby/floating-ruby-text-expected.txt: Added.
- platform/chromium-win-vista/fast/ruby/positioned-ruby-text-expected.txt: Added.
- platform/chromium-win-xp/fast/ruby/floating-ruby-text-expected.txt: Added.
- platform/chromium-win-xp/fast/ruby/positioned-ruby-text-expected.txt: Added.
- platform/chromium-win/fast/ruby/floating-ruby-text-expected.txt: Added.
- platform/chromium-win/fast/ruby/positioned-ruby-text-expected.txt: Added.
- 5:11 PM Changeset in webkit [114700] by
-
- 2 edits in trunk/Source/WebCore
ElementAttributeData should be fast-malloc'd.
<http://webkit.org/b/84405>
Reviewed by Antti Koivisto.
Sprinkle missing WTF_MAKE_FAST_ALLOCATED.
- dom/ElementAttributeData.h:
(ElementAttributeData):
- 5:10 PM April 2012 Meeting edited by
- (diff)
- 5:08 PM Changeset in webkit [114699] by
-
- 9 edits in trunk
REGRESSION(r112177): Numbered list item rendered bulleted
https://bugs.webkit.org/show_bug.cgi?id=84216
Patch by David Barr <davidbarr@chromium.org> on 2012-04-19
Reviewed by Ryosuke Niwa.
Shorthands that imply omitted values cannot be derived from
an incomplete set of longhand rules.
No new tests; updated existing tests that should have caught this.
Source/WebCore:
- css/CSSParser.cpp:
(WebCore::CSSParser::parseTransformOriginShorthand):
Set implicit initial for Z when omitted.
- css/StylePropertySet.cpp:
(WebCore::StylePropertySet::getShorthandValue):
LayoutTests:
- css3/flexbox/css-properties.html:
- fast/css/cssText-shorthand.html:
- fast/css/uri-token-parsing-expected.txt:
- fast/css/uri-token-parsing.html:
- fast/dom/css-dom-read-2-expected.txt:
- 5:06 PM Internals_Hackathon edited by
- (diff)
- 5:05 PM Changeset in webkit [114698] by
-
- 19 edits in trunk/Source/JavaScriptCore
We're collecting pathologically due to small allocations
https://bugs.webkit.org/show_bug.cgi?id=84404
Reviewed by Geoffrey Garen.
No change in performance on run-jsc-benchmarks.
- dfg/DFGSpeculativeJIT.h: Replacing m_firstFreeCell with m_freeList.
(JSC::DFG::SpeculativeJIT::emitAllocateBasicJSObject):
- heap/CopiedSpace.cpp: Getting rid of any water mark related stuff, since it's no
longer useful.
(JSC::CopiedSpace::CopiedSpace):
(JSC::CopiedSpace::tryAllocateSlowCase): We now only call didAllocate here rather than
carrying out a somewhat complicated accounting job for our old water mark throughout CopiedSpace.
(JSC::CopiedSpace::tryAllocateOversize): Call the new didAllocate to notify the Heap of
newly allocated stuff.
(JSC::CopiedSpace::tryReallocateOversize):
(JSC::CopiedSpace::doneFillingBlock):
(JSC::CopiedSpace::doneCopying):
(JSC::CopiedSpace::destroy):
- heap/CopiedSpace.h:
(CopiedSpace):
- heap/CopiedSpaceInlineMethods.h:
(JSC::CopiedSpace::startedCopying):
- heap/Heap.cpp: Removed water mark related stuff, replaced with new bytesAllocated and
bytesAllocatedLimit to track how much memory has been allocated since the last collection.
(JSC::Heap::Heap):
(JSC::Heap::reportExtraMemoryCostSlowCase):
(JSC::Heap::collect): We now set the new limit of bytes that we can allocate before triggering
a collection to be the size of the Heap after the previous collection. Thus, we still have our
2x allocation amount.
(JSC::Heap::didAllocate): Notifies the GC activity timer of how many bytes have been allocated
thus far and then adds the new number of bytes to the current total.
(JSC):
- heap/Heap.h: Removed water mark related stuff.
(JSC::Heap::notifyIsSafeToCollect):
(Heap):
(JSC::Heap::shouldCollect):
(JSC):
- heap/MarkedAllocator.cpp:
(JSC::MarkedAllocator::tryAllocateHelper): Refactored to use MarkedBlock's new FreeList struct.
(JSC::MarkedAllocator::allocateSlowCase):
(JSC::MarkedAllocator::addBlock):
- heap/MarkedAllocator.h:
(MarkedAllocator):
(JSC::MarkedAllocator::MarkedAllocator):
(JSC::MarkedAllocator::allocate):
(JSC::MarkedAllocator::zapFreeList): Refactored to take in a FreeList instead of a FreeCell.
- heap/MarkedBlock.cpp:
(JSC::MarkedBlock::specializedSweep):
(JSC::MarkedBlock::sweep):
(JSC::MarkedBlock::sweepHelper):
(JSC::MarkedBlock::zapFreeList):
- heap/MarkedBlock.h:
(FreeList): Added a new struct that keeps track of the current MarkedAllocator's
free list including the number of bytes of stuff in the free list so that when the free list is
exhausted, the correct amount can be reported to Heap.
(MarkedBlock):
(JSC::MarkedBlock::FreeList::FreeList):
(JSC):
- heap/MarkedSpace.cpp: Removing all water mark related stuff.
(JSC::MarkedSpace::MarkedSpace):
(JSC::MarkedSpace::resetAllocators):
- heap/MarkedSpace.h:
(MarkedSpace):
(JSC):
- heap/WeakSet.cpp:
(JSC::WeakSet::findAllocator): Refactored to use the didAllocate interface with the Heap. This
function still needs work though now that the Heap knows how many bytes have been allocated
since the last collection.
- jit/JITInlineMethods.h: Refactored to use MarkedBlock's new FreeList struct.
(JSC::JIT::emitAllocateBasicJSObject): Ditto.
- llint/LowLevelInterpreter.asm: Ditto.
- runtime/GCActivityCallback.cpp:
(JSC::DefaultGCActivityCallback::didAllocate):
- runtime/GCActivityCallback.h:
(JSC::GCActivityCallback::didAllocate): Renamed willAllocate to didAllocate to indicate that
the allocation that is being reported has already taken place.
(DefaultGCActivityCallback):
- runtime/GCActivityCallbackCF.cpp:
(JSC):
(JSC::DefaultGCActivityCallback::didAllocate): Refactored to return early if the amount of
allocation since the last collection is not above a threshold (initially arbitrarily chosen to
be 128KB).
- 5:05 PM Changeset in webkit [114697] by
-
- 2 edits in trunk/Source/WebCore
[Chromium] Don't compile FontCacheSkia for Android
https://bugs.webkit.org/show_bug.cgi?id=84392
Reviewed by Kent Tamura.
Chromium for the Android platform uses its own FontCacheAndroid
implementation. Compile errors show up when trying to build the
content shell.
- WebCore.gyp/WebCore.gyp:
- 5:03 PM Internals_Hackathon edited by
- (diff)
- 5:01 PM Internals_Hackathon edited by
- (diff)
- 4:59 PM Internals_Hackathon edited by
- (diff)
- 4:58 PM Internals_Hackathon edited by
- (diff)
- 4:58 PM Internals_Hackathon edited by
- (diff)
- 4:57 PM Internals_Hackathon edited by
- (diff)
- 4:56 PM Internals_Hackathon edited by
- (diff)
- 4:55 PM Internals_Hackathon edited by
- (diff)
- 4:54 PM Changeset in webkit [114696] by
-
- 1 edit2 deletes in trunk/Source/WebCore
[Cairo] Remove rgb24-hacks.txt and scale-removal.txt
https://bugs.webkit.org/show_bug.cgi?id=83475
Patch by Martin Robinson <mrobinson@igalia.com> on 2012-04-19
Reviewed by Daniel Bates.
No new tests. This does not change functionality.
Remove some obsolete patch files for Cairo that were used in some
very old versions of Safari for Windows.
- platform/graphics/cairo/rgb24-hacks.txt: Removed.
- platform/graphics/cairo/scale-removal.txt: Removed.
- 4:54 PM Internals_Hackathon edited by
- (diff)
- 4:53 PM Internals_Hackathon edited by
- (diff)
- 4:52 PM Changeset in webkit [114695] by
-
- 2 edits in trunk/Source/JavaScriptCore
MacroAssemblerARMv7::branchTruncateDoubleToUint32 should obey the overflow signal
https://bugs.webkit.org/show_bug.cgi?id=84401
Reviewed by Gavin Barraclough.
- assembler/MacroAssemblerARMv7.h:
(JSC::MacroAssemblerARMv7::branchTruncateDoubleToUint32):
- 4:52 PM Internals_Hackathon edited by
- (diff)
- 4:52 PM Internals_Hackathon edited by
- (diff)
- 4:50 PM Internals_Hackathon edited by
- (diff)
- 4:50 PM Changeset in webkit [114694] by
-
- 4 edits in trunk
[EFL] DRT console messages should contain only the file name part of local URIs
https://bugs.webkit.org/show_bug.cgi?id=84236
Patch by Christophe Dumez <Christophe Dumez> on 2012-04-19
Reviewed by Kentaro Hara.
Tools:
Process console messages before printing them in EFL's DumpRenderTree
them so that they contain only the file name part of local URIs. This
is what is expected by test cases.
- DumpRenderTree/efl/DumpRenderTreeView.cpp:
(urlSuitableForTestResult):
(onConsoleMessage):
LayoutTests:
Remove from the skip list the tests which expect only the file name
part of local URIs to be displayed in console messages now that it has
been fixed in EFL's DumpRenderTree.
- platform/efl/Skipped:
- 4:49 PM Internals_Hackathon edited by
- (diff)
- 4:48 PM Internals_Hackathon edited by
- (diff)
- 4:47 PM Internals_Hackathon edited by
- (diff)
- 4:46 PM Changeset in webkit [114693] by
-
- 3 edits1 add15 deletes in trunk/LayoutTests
transforms/no_transform_hit_testing.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=82415
Patch by Florin Malita <fmalita@google.com> on 2012-04-19
Reviewed by Simon Fraser.
Convert the test to text-only (dumpAsText) to avoid inconsistent pixel results.
- platform/chromium-linux/transforms/no_transform_hit_testing-expected.png: Removed.
- platform/chromium-mac-leopard/transforms/no_transform_hit_testing-expected.png: Removed.
- platform/chromium-mac-snowleopard/transforms/no_transform_hit_testing-expected.png: Removed.
- platform/chromium-mac/transforms/no_transform_hit_testing-expected.png: Removed.
- platform/chromium-win/transforms/no_transform_hit_testing-expected.png: Removed.
- platform/chromium-win/transforms/no_transform_hit_testing-expected.txt: Removed.
- platform/chromium/test_expectations.txt:
- platform/efl/transforms/no_transform_hit_testing-expected.png: Removed.
- platform/efl/transforms/no_transform_hit_testing-expected.txt: Removed.
- platform/gtk/transforms/no_transform_hit_testing-expected.txt: Removed.
- platform/mac-leopard/transforms/no_transform_hit_testing-expected.png: Removed.
- platform/mac/transforms/no_transform_hit_testing-expected.png: Removed.
- platform/mac/transforms/no_transform_hit_testing-expected.txt: Removed.
- platform/qt-mac/transforms/no_transform_hit_testing-expected.txt: Removed.
- platform/qt/transforms/no_transform_hit_testing-expected.png: Removed.
- platform/qt/transforms/no_transform_hit_testing-expected.txt: Removed.
- transforms/no_transform_hit_testing-expected.txt: Added.
- transforms/no_transform_hit_testing.html:
- 4:45 PM Internals_Hackathon edited by
- (diff)
- 4:43 PM Internals_Hackathon edited by
- (diff)
- 4:42 PM Internals_Hackathon edited by
- (diff)
- 4:42 PM Internals_Hackathon edited by
- (diff)
- 4:41 PM Changeset in webkit [114692] by
-
- 2 edits3 deletes in trunk/LayoutTests
[chromium] Unreviewed, update chromium expectations for various compositing layout tests
- platform/chromium/test_expectations.txt:
- 4:39 PM Internals_Hackathon edited by
- (diff)
- 4:38 PM Changeset in webkit [114691] by
-
- 2 edits in trunk/Source/WebCore
Use sqrtf instead of sqrt in CanvasRenderingContext2D.cpp
https://bugs.webkit.org/show_bug.cgi?id=84403
Reviewed by Andreas Kling.
r114679 broke Chromium Win and Android bots due to call
ambiguity between a double and float argument.
- html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::inflateStrokeRect):
- 4:34 PM Internals_Hackathon edited by
- (diff)
- 4:30 PM Internals_Hackathon edited by
- (diff)
- 4:30 PM Changeset in webkit [114690] by
-
- 3 edits in trunk/Source/WebCore
Default to null value for HistoryItem::m_pageScaleFactor
https://bugs.webkit.org/show_bug.cgi?id=84385
Patch by Alexandre Elias <aelias@google.com> on 2012-04-19
Reviewed by Nate Chapin.
Previously, HistoryItem::m_pageScaleFactor defaulted to a value
of 1, making it impossible to determine whether this value was never
set, or intentionally set to 1. This patch introduces a default value
of 0 and makes restoreScrollPositionAndViewState not touch the page
scale factor if this value is still present at time of reload.
This is a no-op change for common navigation scenarios. The
motivation for this change is the corner case of syncing history items
from a desktop browser to a mobile device. In that case, we need a
way to specify that the history item does not contain a
pageScaleFactor so that the mobile device does not display the page
overly zoomed in.
No new tests.
- history/HistoryItem.cpp:
(WebCore::HistoryItem::HistoryItem):
- loader/HistoryController.cpp:
(WebCore::HistoryController::restoreScrollPositionAndViewState):
- 4:28 PM Internals_Hackathon edited by
- (diff)
- 4:27 PM Changeset in webkit [114689] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed Qt build warning fix.
The file editing/StringHelper.h does not exist.
- Target.pri:
- 4:27 PM Internals_Hackathon edited by
- (diff)
- 4:26 PM Internals_Hackathon edited by
- (diff)
- 4:19 PM Internals_Hackathon edited by
- (diff)
- 4:17 PM Internals_Hackathon edited by
- (diff)
- 4:03 PM Internals_Hackathon edited by
- (diff)
- 4:01 PM Changeset in webkit [114688] by
-
- 1 edit1 delete in trunk/Source/WebCore
Remove empty directory Source/WebCore/webaudio
Changeset 111474 <http://trac.webkit.org/changeset/111474> moved all the files in
Source/WebCore/webaudio to Source/WebCore/Modules/webaudio. We should remove the
empty directory Source/WebCore/webaudio.
- webaudio: Removed.
- 4:00 PM Changeset in webkit [114687] by
-
- 2 edits in trunk/LayoutTests
[Qt][Wk2] unskip page-reload-cancel-permission-requests from geolocation for wk2
https://bugs.webkit.org/show_bug.cgi?id=84293
Reviewed by Tor Arne Vestbø.
Unskipped page-reload-cancel-permission-requests after r105988.
- platform/qt-5.0-wk2/Skipped:
- 4:00 PM Internals_Hackathon edited by
- (diff)
- 3:59 PM Changeset in webkit [114686] by
-
- 3 edits in trunk/Source/WebKit/chromium
[chromium] Add simplified API for iterating over a WebElement's attributes.
<http://webkit.org/b/84183>
Reviewed by Dimitri Glazkov.
Add attributeCount(), attributeLocalName(index) and attributeValue(index) to the
WebElement API so that call sites currently using WebNamedNodeMap can be
converted, which will ultimately allow us to refactor WebCore::Attribute
on <http://webkit.org/b/83440>.
- public/WebElement.h:
- src/WebElement.cpp:
(WebKit::WebElement::attributeCount):
(WebKit::WebElement::attributeLocalName):
(WebKit::WebElement::attributeValue):
- 3:59 PM Internals_Hackathon edited by
- (diff)
- 3:59 PM Internals_Hackathon edited by
- (diff)
- 3:58 PM Internals_Hackathon edited by
- (diff)
- 3:57 PM April 2012 Meeting edited by
- (diff)
- 3:54 PM Internals_Hackathon edited by
- (diff)
- 3:53 PM Internals_Hackathon created by
- 3:49 PM Changeset in webkit [114685] by
-
- 5 edits in trunk/LayoutTests
New ruby tests broken on Mac
https://bugs.webkit.org/show_bug.cgi?id=84382
Patch by Ken Buchanan <kenrb@chromium.org> on 2012-04-19
Reviewed by Eric Seidel.
Tweaking new tests to make them render the same on all platforms.
- fast/ruby/floating-ruby-text-expected.txt:
- fast/ruby/floating-ruby-text.html:
- fast/ruby/positioned-ruby-text-expected.txt:
- fast/ruby/positioned-ruby-text.html:
- 3:44 PM Changeset in webkit [114684] by
-
- 2 edits in trunk/Source/JavaScriptCore
KeywordLookupGenerator.py should take an output file as an argument
https://bugs.webkit.org/show_bug.cgi?id=84292
Patch by Don Olmstead <don.olmstead@am.sony.com> on 2012-04-19
Reviewed by Eric Seidel.
Extended KeywordLookupGenerator to accept an additional argument specifying an output file. If this argument is found stdout is redirected to a file for the duration of the script.
- KeywordLookupGenerator.py:
- 3:33 PM Changeset in webkit [114683] by
-
- 3 edits in trunk/Source/WebCore
Incorrect inter-caps in “ShouldSkipMetaData” etc.
https://bugs.webkit.org/show_bug.cgi?id=72159
Reviewed by Dan Bernstein.
No new tests since no change in functionality.
- platform/graphics/ImageSource.h:
- platform/graphics/cg/ImageSourceCG.cpp:
(WebCore::imageSourceOptions):
(WebCore::ImageSource::isSizeAvailable):
(WebCore::ImageSource::frameSizeAtIndex):
(WebCore::ImageSource::orientationAtIndex):
(WebCore::ImageSource::getHotSpot):
(WebCore::ImageSource::repetitionCount):
(WebCore::ImageSource::createFrameAtIndex):
(WebCore::ImageSource::frameDurationAtIndex):
- 3:12 PM Changeset in webkit [114682] by
-
- 2 edits in trunk/Tools
[EFL] [DRT] Should create offline storage inside DUMPRENDERTREE_TEMP
https://bugs.webkit.org/show_bug.cgi?id=84169
All databases were being created inside ~/.webkit which was causing
flaky tests when running multiple tests in parallel, specially timeouts
due to concurrency.
Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-04-19
Reviewed by Eric Seidel.
- DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
(DumpRenderTreeChrome::initialize):
- 3:10 PM Changeset in webkit [114681] by
-
- 3 edits in trunk/Websites/webkit.org
Update Build Location notice on Mac debug instructions to reflect changes in Xcode 4.3.2
https://bugs.webkit.org/show_bug.cgi?id=84364
Reviewed by Eric Seidel.
As of Xcode 4.3.2, the build location "Locations Specified by Targets" has been renamed to
"Legacy".
- building/debug-mac-uiprocess.html:
- building/debug.html:
- 3:07 PM Changeset in webkit [114680] by
-
- 1 edit3 adds in trunk/LayoutTests
Canvas more precisely makes the bounding rect for stroke rendering.
https://bugs.webkit.org/show_bug.cgi?id=75792
Patch by Huang Dongsung <luxtella@company100.net> on 2012-04-19
Reviewed by Simon Fraser.
- fast/canvas/canvas-strokePath-cap-join-expected.txt: Added.
- fast/canvas/canvas-strokePath-cap-join.html: Added.
- fast/canvas/script-tests/canvas-strokePath-cap-join.js: Added.
- 3:05 PM Changeset in webkit [114679] by
-
- 3 edits in trunk/Source/WebCore
Canvas more precisely makes the bounding rect for stroke rendering.
https://bugs.webkit.org/show_bug.cgi?id=75792
Patch by Huang Dongsung <luxtella@company100.net> on 2012-04-19
Reviewed by Simon Fraser.
- html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::stroke):
(WebCore::CanvasRenderingContext2D::drawTextInternal):
(WebCore::CanvasRenderingContext2D::inflateStrokeRect):
(WebCore):
- html/canvas/CanvasRenderingContext2D.h:
(CanvasRenderingContext2D):
- 3:03 PM Changeset in webkit [114678] by
-
- 2 edits in trunk/Source/WebCore
Eliminate potential null pointer dereference in CSSStyleSelector::containsUncommonAttributeSelector().
https://bugs.webkit.org/show_bug.cgi?id=84366
Reviewed by Kentaro Hara.
No new tests / code cleanup only.
- css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::collectMatchingRulesForList):
- 3:00 PM Changeset in webkit [114677] by
-
- 3 edits2 adds in trunk
Fix null-pointer dereference in ApplyPropertyZoom::applyValue().
https://bugs.webkit.org/show_bug.cgi?id=84279
Reviewed by Simon Fraser.
Source/WebCore:
Test: fast/css/zoom-on-unattached.html
- css/CSSStyleApplyProperty.cpp:
(WebCore::ApplyPropertyZoom::applyValue):
LayoutTests:
- fast/css/zoom-on-unattached-expected.txt: Added.
- fast/css/zoom-on-unattached.html: Added.
- 2:56 PM Changeset in webkit [114676] by
-
- 2 edits in trunk/Source/WebCore
Clean up list iteration in MediaQueryExp constructor (avoid unnecessary calls to current()).
https://bugs.webkit.org/show_bug.cgi?id=84369
Reviewed by Simon Fraser.
No new tests / code cleanup only.
- css/MediaQueryExp.cpp:
(WebCore::MediaQueryExp::MediaQueryExp):
- 2:55 PM Changeset in webkit [114675] by
-
- 7 edits in trunk/Source/JavaScriptCore
It should be possible to perform debugCall on ARMv7
https://bugs.webkit.org/show_bug.cgi?id=84381
Reviewed by Oliver Hunt.
debugCall() was clobbering the argument to the call it was making, leading to a
corrupt ExecState*. This change fixes that issue by using a scratch register that
does not clobber arguments, and it also introduces more assertions that we have
a valid call frame.
- dfg/DFGAssemblyHelpers.cpp:
(DFG):
(JSC::DFG::AssemblyHelpers::jitAssertHasValidCallFrame):
- dfg/DFGAssemblyHelpers.h:
(JSC::DFG::AssemblyHelpers::selectScratchGPR):
(AssemblyHelpers):
(JSC::DFG::AssemblyHelpers::debugCall):
(JSC::DFG::AssemblyHelpers::jitAssertHasValidCallFrame):
- dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::linkOSRExits):
- dfg/DFGOSRExitCompiler.cpp:
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::selectScratchGPR):
- 2:48 PM April 2012 Meeting edited by
- (diff)
- 2:32 PM Changeset in webkit [114674] by
-
- 1 edit2 adds in trunk/LayoutTests
REGRESSION (r114666): fast/ruby/floating-ruby-text.html, fast/ruby/positioned-ruby-text.html failing on Lion Release (Tests)
https://bugs.webkit.org/show_bug.cgi?id=84384
Add platform/mac baselines for new ruby tests.
- platform/mac/fast/ruby/floating-ruby-text-expected.txt: Added.
- platform/mac/fast/ruby/positioned-ruby-text-expected.txt: Added.
- 2:29 PM Changeset in webkit [114673] by
-
- 2 edits in trunk/LayoutTests
Check in correct expectations for some passing tests.
Rubber stamped by Oliver Hunt.
- platform/mac/test_expectations.txt:
- 2:26 PM Changeset in webkit [114672] by
-
- 53 edits in trunk/LayoutTests
Remove description from calls to indexedDB.open
https://bugs.webkit.org/show_bug.cgi?id=84109
open() used to take two parameters, a database name and an optional
string database description. The description was deprecated. An
optional integer version parameter was recently added in its place.
This change removes the description parameter from calls that still
had it so that it's not interpreted as a version.
Reviewed by Eric Seidel.
- storage/indexeddb/create-object-store-options-expected.txt:
- storage/indexeddb/createObjectStore-name-argument-required-expected.txt:
- storage/indexeddb/createObjectStore-null-name-expected.txt:
- storage/indexeddb/cursor-update-value-argument-required-expected.txt:
- storage/indexeddb/database-odd-names-expected.txt:
- storage/indexeddb/deleteObjectStore-name-argument-required-expected.txt:
- storage/indexeddb/deleteObjectStore-null-name-expected.txt:
- storage/indexeddb/factory-basics-expected.txt:
- storage/indexeddb/index-get-key-argument-required-expected.txt:
- storage/indexeddb/invalid-keys-expected.txt:
- storage/indexeddb/key-sort-order-across-types-expected.txt:
- storage/indexeddb/key-sort-order-date-expected.txt:
- storage/indexeddb/key-type-array-expected.txt:
- storage/indexeddb/key-type-infinity-expected.txt:
- storage/indexeddb/keypath-basics-expected.txt:
- storage/indexeddb/keypath-fetch-key-expected.txt:
- storage/indexeddb/objectStore-required-arguments-expected.txt:
- storage/indexeddb/odd-strings-expected.txt:
- storage/indexeddb/readonly-expected.txt:
- storage/indexeddb/readonly-properties-expected.txt:
- storage/indexeddb/resources/create-object-store-options.js:
(test):
- storage/indexeddb/resources/createObjectStore-name-argument-required.js:
(test):
- storage/indexeddb/resources/createObjectStore-null-name.js:
(test):
- storage/indexeddb/resources/cursor-update-value-argument-required.js:
(test):
- storage/indexeddb/resources/database-odd-names.js:
(openNextDatabase):
- storage/indexeddb/resources/deleteObjectStore-name-argument-required.js:
(test):
- storage/indexeddb/resources/deleteObjectStore-null-name.js:
(test):
- storage/indexeddb/resources/factory-basics.js:
(test):
(getDatabaseNamesSuccess1):
- storage/indexeddb/resources/index-get-key-argument-required.js:
(test):
- storage/indexeddb/resources/invalid-keys.js:
(test):
- storage/indexeddb/resources/key-sort-order-across-types.js:
(test):
- storage/indexeddb/resources/key-sort-order-date.js:
(test):
- storage/indexeddb/resources/key-type-array.js:
(test):
- storage/indexeddb/resources/key-type-infinity.js:
(test):
- storage/indexeddb/resources/keypath-basics.js:
(test):
- storage/indexeddb/resources/keypath-fetch-key.js:
(test):
- storage/indexeddb/resources/objectStore-required-arguments.js:
(test):
- storage/indexeddb/resources/odd-strings.js:
(openNextDatabase):
(verifyNextDatabase):
- storage/indexeddb/resources/readonly-properties.js:
(test):
- storage/indexeddb/resources/readonly.js:
(test):
- storage/indexeddb/resources/setVersion-null.js:
(test):
- storage/indexeddb/resources/setVersion-undefined.js:
(test):
- storage/indexeddb/resources/transaction-and-objectstore-calls.js:
(test):
- storage/indexeddb/resources/transaction-storeNames-required.js:
(test):
- storage/indexeddb/resources/value-undefined.js:
(test):
- storage/indexeddb/resources/values-odd-types.js:
(test):
- storage/indexeddb/setVersion-null-expected.txt:
- storage/indexeddb/setVersion-undefined-expected.txt:
- storage/indexeddb/transaction-and-objectstore-calls-expected.txt:
- storage/indexeddb/transaction-storeNames-required-expected.txt:
- storage/indexeddb/value-undefined-expected.txt:
- storage/indexeddb/values-odd-types-expected.txt:
- 2:24 PM Changeset in webkit [114671] by
-
- 5 edits in trunk/Source
[Chromium] Call signedPublicKeyAndChallengeString directly
https://bugs.webkit.org/show_bug.cgi?id=84372
Reviewed by Kentaro Hara.
Part of a refactoring series. See tracking bug 82948.
Source/WebCore:
- platform/chromium/PlatformSupport.h:
(PlatformSupport):
- platform/chromium/SSLKeyGeneratorChromium.cpp:
(WebCore::signedPublicKeyAndChallengeString):
Source/WebKit/chromium:
- src/PlatformSupport.cpp:
(WebCore):
- 2:22 PM Changeset in webkit [114670] by
-
- 2 edits in trunk/Source/WebCore
Remove unnecessary assignment in CSSParser::parseCubicBezierTimingFunctionValue().
https://bugs.webkit.org/show_bug.cgi?id=84368
Reviewed by Simon Fraser.
No new tests / code cleanup only.
- css/CSSParser.cpp:
(WebCore::CSSParser::parseCubicBezierTimingFunctionValue):
- 2:20 PM Changeset in webkit [114669] by
-
- 2 edits in trunk/Source/WebCore
Initialize all member variables in CSSImageSetValue's copy constructor.
https://bugs.webkit.org/show_bug.cgi?id=84379
Reviewed by Simon Fraser.
No new tests / code cleanup only.
- css/CSSImageSetValue.cpp:
(WebCore::CSSImageSetValue::CSSImageSetValue):
- 2:19 PM April 2012 Meeting edited by
- (diff)
- 1:54 PM April 2012 Meeting edited by
- (diff)
- 1:53 PM Changeset in webkit [114668] by
-
- 2 edits in trunk/Source/WebKit/chromium
[Chromium] Call audioHardwareBufferSize directly
https://bugs.webkit.org/show_bug.cgi?id=84370
Reviewed by Kentaro Hara.
Part of a refactoring series. See tracking bug 82948.
- src/AudioDestinationChromium.cpp:
(WebCore::AudioDestinationChromium::AudioDestinationChromium):
- 1:34 PM Changeset in webkit [114667] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, GTK test_expectations update after r114640.
- platform/gtk/test_expectations.txt:
- 1:15 PM Changeset in webkit [114666] by
-
- 4 edits8 adds in trunk
Positioned children of ruby runs not handled correctly during layout
https://bugs.webkit.org/show_bug.cgi?id=84157
Patch by Ken Buchanan <kenrb@chromium.org> on 2012-04-19
Reviewed by Julien Chaffraix.
Source/WebCore:
A positioned ruby text causes a problem because it is excluded from
normal layout by its parent and instead gets layout from
RenderRubyRun::layoutSpecialExcludedChild; however this means it gets
skipped over during the loop in RenderBlock::layoutBlockChildren,
which is where positioned RenderBlocks get added to the appropriate
positioned object lists. As a result, a dirty positioned ruby text
will not get layout again unless the RenderRubyRun also needs layout
which is not guaranteed.
This patch disqualifies ruby text elements from being positioned.
If it is necessary to support this in future, ruby text layout will
have to be modified to ensure the renderers are added to the
appropriate block lists.
- css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::adjustRenderStyle):
- rendering/RenderRubyRun.cpp:
(WebCore::RenderRubyRun::rubyText):
LayoutTests:
- fast/ruby/modify-positioned-ruby-text-crash-expected.txt: Added
- fast/ruby/modify-positioned-ruby-text-crash.html: Exercises the crash condition
in but 84157 relating to positioned ruby text. This is being added
in case support for positioned ruby text is added in future, so that
we can guard against regression.
- fast/ruby/floating-ruby-text-expected.png: Added
- fast/ruby/floating-ruby-text-expected.txt: Added
- fast/ruby/floating-ruby-text.html: Creates a positioned ruby text. The
position should be ignored.
- fast/ruby/positioned-ruby-text-expected.png: Added
- fast/ruby/positioned-ruby-text-expected.txt: Added
- fast/ruby/positioned-ruby-text.html: Creates a floating ruby text. The
float should be ignored.
- 12:27 PM April 2012 MeetingRethinkingRendering edited by
- (diff)
- 12:22 PM April 2012 MeetingRethinkingRendering edited by
- (diff)
- 12:20 PM April 2012 MeetingRethinkingRendering edited by
- (diff)
- 12:19 PM April 2012 Meeting edited by
- Added link to Web Components notes (diff)
- 12:18 PM April 2012 MeetingRethinkingRendering edited by
- (diff)
- 12:18 PM WebComponentsStatusMeetingNotes created by
- Initial commit; may fix formatting later.
- 12:12 PM Changeset in webkit [114665] by
-
- 3 edits in trunk/Source/WebKit2
DevTools: assertion failure upon devtools window reopen.
https://bugs.webkit.org/show_bug.cgi?id=53493
Patch by Vivek Galatage <vivekgalatage@gmail.com> on 2012-04-19
Reviewed by Pavel Feldman.
The pointers pointed to by WebInspector must be reset explicitly
in WebInspector::didClose() method
- WebProcess/WebCoreSupport/WebInspectorClient.cpp:
(WebKit::WebInspectorClient::closeInspectorFrontend):
- WebProcess/WebPage/WebInspector.cpp:
(WebKit::WebInspector::didClose):
- 12:11 PM Accelerated rendering and compositing edited by
- (diff)
- 12:08 PM Changeset in webkit [114664] by
-
- 3 edits in trunk/Source/JavaScriptCore
LLInt no-JIT fallback native call trampoline's exception handler incorrectly assumes that
the PB/PC has been preserved
https://bugs.webkit.org/show_bug.cgi?id=84367
Reviewed by Oliver Hunt.
- llint/LowLevelInterpreter32_64.asm:
- llint/LowLevelInterpreter64.asm:
- 11:59 AM April 2012 MeetingRethinkingRendering edited by
- (diff)
- 11:56 AM Changeset in webkit [114663] by
-
- 6 edits3 adds in trunk
Web Inspector: No response body available for cached resource requests with error status codes.
https://bugs.webkit.org/show_bug.cgi?id=84265
Reviewed by Pavel Feldman.
Source/WebCore:
InspectorResourceAgent now saves failed subresource request response body in its cache.
Saved data is shown on front-end.
Test: http/tests/inspector/network/network-image-404.html
- inspector/InspectorResourceAgent.cpp:
(WebCore::isErrorStatusCode):
(WebCore):
(WebCore::InspectorResourceAgent::didReceiveData):
- inspector/NetworkResourcesData.cpp:
(WebCore::NetworkResourcesData::ResourceData::removeContent):
(WebCore::NetworkResourcesData::ResourceData::purgeContent):
(WebCore):
(WebCore::NetworkResourcesData::responseReceived):
(WebCore::NetworkResourcesData::setResourceContent):
- inspector/NetworkResourcesData.h:
(ResourceData):
(WebCore::NetworkResourcesData::ResourceData::httpStatusCode):
(WebCore::NetworkResourcesData::ResourceData::setHTTPStatusCode):
- inspector/front-end/RequestView.js:
(WebInspector.RequestView.hasTextContent):
LayoutTests:
- http/tests/inspector/network/network-image-404-expected.txt: Added.
- http/tests/inspector/network/network-image-404.html: Added.
- http/tests/inspector/network/resources/404.php: Added.
- 11:51 AM April 2012 MeetingRethinkingRendering edited by
- (diff)
- 11:50 AM Changeset in webkit [114662] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector / Heap snapshots: "Object's retaining tree" view doesn't get cleared when navigating between objects
https://bugs.webkit.org/show_bug.cgi?id=84337
When DataGrid root node is reset, make sure all existing rows are removed.
Reviewed by Vsevolod Vlasov.
- inspector/front-end/DataGrid.js:
(WebInspector.DataGrid.prototype.setRootNode):
- 11:47 AM Changeset in webkit [114661] by
-
- 2 edits in trunk/Source/WebCore
https://bugs.webkit.org/show_bug.cgi?id=80534
REGRESSION: When Safari is not frontmost, pages should not get mouse moves or
hover
Reviewed by Adele Peterson.
This patch just adds some code back that was removed by
http://trac.webkit.org/changeset/102632 This particular code was unrelated to that
bug and should not have been removed.
- page/EventHandler.cpp:
(WebCore::EventHandler::handleMouseMoveEvent):
- 11:46 AM Accelerated rendering and compositing edited by
- (diff)
- 11:44 AM Changeset in webkit [114660] by
-
- 2 edits in trunk/Source/JavaScriptCore
It should be possible to load from Float64 arrays on ARMv7 without crashing
https://bugs.webkit.org/show_bug.cgi?id=84361
Reviewed by Oliver Hunt.
- assembler/MacroAssemblerARMv7.h:
(JSC::MacroAssemblerARMv7::loadDouble):
(JSC::MacroAssemblerARMv7::storeDouble):
- 11:42 AM April 2012 MeetingRethinkingRendering edited by
- (diff)
- 11:42 AM Changeset in webkit [114659] by
-
- 3 edits3 adds in trunk
DevTools highlights elements in frames at un-scaled positions
https://bugs.webkit.org/show_bug.cgi?id=84181
Source/WebCore:
On mobile platforms (e.g. chromium-android), normally pages are scaled,
thus the coordinations of highlight rect inside of a frame needs to
consider not only the offset, but also the scale. The change uses
FrameView::contentsToRootView() to map the coordinates of a node in
a frame to the coordinates in the main frame, instead of calculating
by only the offset.
Reviewed by Pavel Feldman.
Test: inspector/elements/highlight-node-scaled.html
- inspector/DOMNodeHighlighter.cpp:
LayoutTests:
The new test case is a scaled web page containing an iframe. It tests
if the highlight rect of an element in the iframe is correct.
Reviewed by Pavel Feldman.
- inspector/elements/highlight-node-scaled-expected.txt: Added.
- inspector/elements/highlight-node-scaled.html: Added.
- inspector/elements/resources/highlight-node-scaled-iframe.html: Added.
- 11:38 AM Changeset in webkit [114658] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector / Heap snapshots: "Objects allocated ..." views are empty
https://bugs.webkit.org/show_bug.cgi?id=84347
Pass parsed maxJSObjectId value to the profile header constructor.
Reviewed by Pavel Feldman.
- inspector/front-end/ProfilesPanel.js:
(WebInspector.ProfileHeader):
(WebInspector.ProfilesPanel.prototype.setRecordingProfile):
(WebInspector.ProfilesPanel.prototype.takeHeapSnapshot):
(WebInspector.ProfilerDispatcher.prototype.addProfileHeader):
- 11:36 AM April 2012 Meeting edited by
- (diff)
- 11:35 AM April 2012 Meeting edited by
- (diff)
- 11:33 AM April 2012 Meeting edited by
- (diff)
- 11:33 AM April 2012 MeetingRethinkingRendering created by
- 11:30 AM UpdatingBugzilla edited by
- (diff)
- 11:30 AM UpdatingBugzilla edited by
- (diff)
- 11:28 AM April 2012 Meeting edited by
- (diff)
- 11:27 AM Changeset in webkit [114657] by
-
- 1 edit1 add in trunk/LayoutTests
AVFoundation: media/video-size-intrinsic-scale.html test fails, and the movie is drawn incorrectly
https://bugs.webkit.org/show_bug.cgi?id=66601
Reviewed by Eric Carlson.
- platform/mac-snowleopard/media/video-size-intrinsic-scale-expected.txt: Added.
Copied passing result, since this doesn't fail on Snow Leopard.
- platform/mac/media/video-size-intrinsic-scale-expected.txt: Added a failing results to make
bots green.
- 11:25 AM Changeset in webkit [114656] by
-
- 2 edits in trunk/Source/WebCore
<rdar://problem/10664148> and https://bugs.webkit.org/show_bug.cgi?id=84360 StorageThread should have an autorelease pool in place for Cocoa clients
Reviewed by Eric Carlson.
No new tests. (Not practical to test this with current tools)
- storage/StorageThread.cpp:
(WebCore::StorageThread::threadEntryPoint): Include an AutodrainedPool and cycle it after each message.
- 11:20 AM Changeset in webkit [114655] by
-
- 2 edits in trunk/Source/WebCore
Fix potential null pointer dereference in RuleSet::addRulesFromSheet().
https://bugs.webkit.org/show_bug.cgi?id=84258
Reviewed by Andreas Kling.
Fix variable that is dereferenced without null check here, but checked in code above and below.
No new test / code cleanup from coverity analysis.
- css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::collectMatchingRulesForList):
- 11:19 AM Accelerated rendering and compositing edited by
- (diff)
- 11:19 AM Accelerated rendering and compositing edited by
- (diff)
- 11:18 AM Accelerated rendering and compositing created by
- Initial draft
- 11:18 AM Changeset in webkit [114654] by
-
- 4 edits in trunk/Source/WebCore
Web Inspector: exception when hovering object while paused
https://bugs.webkit.org/show_bug.cgi?id=84358
Added missing boolean parameter to the call site of evaluate method
on call frame.
Reviewed by Vsevolod Vlasov.
- inspector/front-end/AdvancedSearchController.js:
- inspector/front-end/DebuggerPresentationModel.js: annotated slectedCallFrame
method so that closure compiler catches errors like in the bug report.
(WebInspector.DebuggerPresentationModel.prototype.evaluateInSelectedCallFrame):
- inspector/front-end/JavaScriptSourceFrame.js:
(WebInspector.JavaScriptSourceFrame.prototype._resolveObjectForPopover):
- 11:17 AM Changeset in webkit [114653] by
-
- 5 edits in trunk
[GTK] 3 fast/ layout tests failing after upgrading libsoup to 2.37.92
https://bugs.webkit.org/show_bug.cgi?id=82484
Patch by Dominik Röttsches <dominik.rottsches@linux.intel.com> on 2012-04-19
Reviewed by Martin Robinson.
Tools:
Bumping libsoup to version 2.38.1 which fixes the above WebKit bug.
- efl/jhbuild.modules:
- gtk/jhbuild.modules:
LayoutTests:
Unskipping tests that were previously failing due to a bug in libsoup.
- platform/gtk/test_expectations.txt:
- 11:17 AM April 2012 Meeting edited by
- (diff)
- 11:14 AM April 2012 Meeting edited by
- (diff)
- 11:11 AM Changeset in webkit [114652] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: nodes are not removed from the summary view when switching between allocation ranges
https://bugs.webkit.org/show_bug.cgi?id=84354
Clear all top level nodes not only those visible in the viewport when populating
the constructors view with new content.
Reviewed by Pavel Feldman.
- inspector/front-end/HeapSnapshotDataGrids.js:
(WebInspector.HeapSnapshotSortableDataGrid.prototype.dispose):
(WebInspector.HeapSnapshotSortableDataGrid.prototype.topLevelNodes):
(WebInspector.HeapSnapshotSortableDataGrid.prototype.changeNameFilter):
(WebInspector.HeapSnapshotViewportDataGrid.prototype.topLevelNodes):
(WebInspector.HeapSnapshotViewportDataGrid.prototype.removeTopLevelNodes):
(WebInspector.HeapSnapshotConstructorsDataGrid.prototype.populateChildren):
(WebInspector.HeapSnapshotDiffDataGrid.prototype.setBaseDataSource):
- 11:05 AM MeetingNotesLayoutModes edited by
- (diff)
- 11:03 AM Changeset in webkit [114651] by
-
- 18 edits in trunk/Source
Source/WebCore: [chromium] Allow scrolling non-root layers in the compositor thread
https://bugs.webkit.org/show_bug.cgi?id=73350
Patch by Sami Kyostila <skyostil@chromium.org> on 2012-04-19
Reviewed by James Robinson.
This patch enables scrolling child layers in the compositor thread.
Scroll deltas are accumulated for each scrolled CCLayerImpl and
synchronized to the main thread.
If a layer has no room to scroll in a given direction, one of its
ancestor layers is scrolled instead if possible.
Added new webkit_unit_tests to verify scrolling behavior.
- platform/graphics/chromium/ContentLayerChromium.cpp:
(WebCore::ContentLayerChromium::scrollBy):
(WebCore):
- platform/graphics/chromium/ContentLayerChromium.h:
(ContentLayerDelegate):
(ContentLayerChromium):
- platform/graphics/chromium/GraphicsLayerChromium.h:
(WebCore::GraphicsLayerChromium::didScroll):
- platform/graphics/chromium/LayerChromium.cpp:
(WebCore::LayerChromium::setMaxScrollPosition):
(WebCore):
(WebCore::LayerChromium::pushPropertiesTo):
- platform/graphics/chromium/LayerChromium.h:
(LayerChromium):
(WebCore::LayerChromium::maxScrollPosition):
(WebCore::LayerChromium::scrollable):
(WebCore::LayerChromium::scrollBy):
- platform/graphics/chromium/cc/CCLayerImpl.cpp:
(WebCore::CCLayerImpl::findLayerInSubtree):
(WebCore):
(WebCore::CCLayerImpl::tryScroll):
- platform/graphics/chromium/cc/CCLayerImpl.h:
(CCLayerImpl):
- platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::findLayerById):
(WebCore):
(WebCore::findFirstScrollableLayer):
(WebCore::CCLayerTreeHost::applyScrollAndScale):
- platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::CCLayerTreeHostImpl):
(WebCore::CCLayerTreeHostImpl::startPageScaleAnimation):
(WebCore::CCLayerTreeHostImpl::contentSize):
(WebCore):
(WebCore::CCLayerTreeHostImpl::calculateVisibleLayers):
(WebCore::CCLayerTreeHostImpl::prepareToDraw):
(WebCore::findRootScrollLayer):
(WebCore::findScrollLayerForContentLayer):
(WebCore::CCLayerTreeHostImpl::setRootLayer):
(WebCore::adjustScrollsForPageScaleChange):
(WebCore::applyPageScaleDeltaToScrollLayers):
(WebCore::CCLayerTreeHostImpl::setPageScaleFactorAndLimits):
(WebCore::CCLayerTreeHostImpl::setPageScaleDelta):
(WebCore::CCLayerTreeHostImpl::updateMaxScrollPosition):
(WebCore::CCLayerTreeHostImpl::scrollBegin):
(WebCore::CCLayerTreeHostImpl::scrollBy):
(WebCore::CCLayerTreeHostImpl::scrollEnd):
(WebCore::CCLayerTreeHostImpl::pinchGestureUpdate):
(WebCore::CCLayerTreeHostImpl::computePinchZoomDeltas):
(WebCore::CCLayerTreeHostImpl::makeScrollAndScaleSet):
(WebCore::collectScrollDeltas):
(WebCore::CCLayerTreeHostImpl::processScrollDeltas):
(WebCore::CCLayerTreeHostImpl::animatePageScale):
- platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
(WebCore::CCLayerTreeHostImpl::rootScrollLayer):
(CCLayerTreeHostImpl):
(LayerGeometry):
Source/WebKit/chromium: [chromium] Add tests for scrolling non-root layers in the compositor thread
https://bugs.webkit.org/show_bug.cgi?id=73350
Patch by Sami Kyostila <skyostil@chromium.org> on 2012-04-19
Reviewed by James Robinson.
- src/WebContentLayerImpl.cpp:
(WebKit::WebContentLayerImpl::didScroll):
(WebKit):
- src/WebContentLayerImpl.h:
(WebContentLayerImpl):
- tests/CCLayerImplTest.cpp:
(WebCore::TEST):
(WebCore):
- tests/CCLayerTreeHostImplTest.cpp:
(WebKitTests::CCLayerTreeHostImplTest::createScrollableLayer):
(CCLayerTreeHostImplTest):
(WebKitTests::CCLayerTreeHostImplTest::initializeLayerRendererAndDrawFrame):
(WebKitTests::TEST_F):
(WebKitTests):
- tests/CCLayerTreeHostTest.cpp:
(WTF::TestOpacityChangeLayerDelegate::didScroll):
(WTF::MockContentLayerDelegate::paintContents):
(WTF::MockContentLayerDelegate::didScroll):
(CCLayerTreeHostTestScrollChildLayer):
(WTF::CCLayerTreeHostTestScrollChildLayer::CCLayerTreeHostTestScrollChildLayer):
(WTF::CCLayerTreeHostTestScrollChildLayer::beginTest):
(WTF::CCLayerTreeHostTestScrollChildLayer::applyScrollAndScale):
(WTF::CCLayerTreeHostTestScrollChildLayer::beginCommitOnCCThread):
(WTF::CCLayerTreeHostTestScrollChildLayer::drawLayersOnCCThread):
(WTF::CCLayerTreeHostTestScrollChildLayer::afterTest):
(WTF):
(WTF::TEST_F):
- 10:55 AM MeetingNotesLayoutModes edited by
- (diff)
- 10:53 AM Changeset in webkit [114650] by
-
- 4 edits in trunk/LayoutTests
Space out captions-fast.vtt to prevent flakiness in media/track/track-mode.html.
https://bugs.webkit.org/show_bug.cgi?id=83878
Reviewed by Eric Carlson.
- media/track/captions-webvtt/captions-fast.vtt:
- media/track/track-mode-expected.txt:
- media/track/track-mode.html:
- 10:44 AM MeetingNotesLayoutModes edited by
- (diff)
- 10:41 AM MeetingNotesLayoutModes edited by
- (diff)
- 10:39 AM MeetingNotesLayoutModes edited by
- (diff)
- 10:39 AM MeetingNotesLayoutModes created by
- 10:11 AM Changeset in webkit [114649] by
-
- 7 edits in trunk
Web Inspector: make constructors and diff heap snapshot data grids use viewport
https://bugs.webkit.org/show_bug.cgi?id=84348
HeapSnapshotViewportDataGrid is introduced which allows to add to the tbody only
visible rows. HeapSnapshotConstructorsDataGrid and HeapSnapshotDiffDataGrid are
inherited from this class which makes them operate well on large amounts of nodes.
Reviewed by Pavel Feldman.
Source/WebCore:
- inspector/front-end/DataGrid.js:
(WebInspector.DataGridNode.prototype.nodeHeight):
(WebInspector.DataGridNode.prototype._attach):
- inspector/front-end/HeapSnapshotDataGrids.js:
(WebInspector.HeapSnapshotSortableDataGrid):
(WebInspector.HeapSnapshotSortableDataGrid.prototype.nodesForNameFilter):
(WebInspector.HeapSnapshotSortableDataGrid.prototype.changeNameFilter):
(WebInspector.HeapSnapshotSortableDataGrid.prototype._performSorting):
(WebInspector.HeapSnapshotSortableDataGrid.prototype.appendChildAfterSorting):
(WebInspector.HeapSnapshotSortableDataGrid.prototype.updateVisibleNodes):
(WebInspector.HeapSnapshotSortableDataGrid.prototype.recursiveSortingEnter):
(WebInspector.HeapSnapshotSortableDataGrid.prototype.recursiveSortingLeave):
(WebInspector.HeapSnapshotViewportDataGrid):
(WebInspector.HeapSnapshotViewportDataGrid.prototype.nodesForNameFilter):
(WebInspector.HeapSnapshotViewportDataGrid.prototype.appendChildAfterSorting):
(WebInspector.HeapSnapshotViewportDataGrid.prototype.updateVisibleNodes):
(WebInspector.HeapSnapshotViewportDataGrid.prototype.appendTopLevelNode):
(WebInspector.HeapSnapshotViewportDataGrid.prototype._addPaddingRows):
(WebInspector.HeapSnapshotViewportDataGrid.prototype._removePaddingRows):
(WebInspector.HeapSnapshotViewportDataGrid.prototype.onResize):
(WebInspector.HeapSnapshotViewportDataGrid.prototype._onScroll):
(WebInspector.HeapSnapshotPaddingNode):
(WebInspector.HeapSnapshotPaddingNode.prototype.setHeight):
(WebInspector.HeapSnapshotPaddingNode.prototype.removeFromTable):
(WebInspector.HeapSnapshotConstructorsDataGrid):
(WebInspector.HeapSnapshotConstructorsDataGrid.prototype.populateChildren):
(WebInspector.HeapSnapshotDiffDataGrid):
(WebInspector.HeapSnapshotDiffDataGrid.prototype.populateChildren.baseAggregatesReceived.aggregatesReceived.addNodeIfNonZeroDiff):
(WebInspector.HeapSnapshotDiffDataGrid.prototype.populateChildren.baseAggregatesReceived.aggregatesReceived):
(WebInspector.HeapSnapshotDiffDataGrid.prototype.populateChildren):
- inspector/front-end/HeapSnapshotGridNodes.js:
(WebInspector.HeapSnapshotGridNode):
(WebInspector.HeapSnapshotGridNode.prototype.collapse):
(WebInspector.HeapSnapshotGridNode.prototype.sort.afterSort.afterPopulate):
(WebInspector.HeapSnapshotGridNode.prototype.sort.afterSort):
(WebInspector.HeapSnapshotGridNode.prototype.sort):
(WebInspector.HeapSnapshotObjectNode.prototype._createChildNode):
(WebInspector.HeapSnapshotObjectNode.prototype.comparator):
(WebInspector.HeapSnapshotInstanceNode.prototype._createChildNode):
(WebInspector.HeapSnapshotInstanceNode.prototype.comparator):
(WebInspector.HeapSnapshotConstructorNode):
(WebInspector.HeapSnapshotConstructorNode.prototype._createChildNode):
(WebInspector.HeapSnapshotConstructorNode.prototype.comparator):
(WebInspector.HeapSnapshotDiffNode):
(WebInspector.HeapSnapshotDiffNode.prototype._createChildNode):
(WebInspector.HeapSnapshotDiffNode.prototype.comparator):
(WebInspector.HeapSnapshotDominatorObjectNode.prototype._createChildNode):
(WebInspector.HeapSnapshotDominatorObjectNode.prototype.comparator):
- inspector/front-end/ShowMoreDataGridNode.js:
(WebInspector.ShowMoreDataGridNode.prototype.createCells):
(WebInspector.ShowMoreDataGridNode.prototype.nodeHeight):
LayoutTests:
- inspector/profiler/heap-snapshot-test.js: since summary and containment views are
now viewports, we should make sure all lazy clean up is done before collecting visible
rows content.
(initialize_HeapSnapshotTest):
- 10:07 AM Changeset in webkit [114648] by
-
- 2 edits in trunk/LayoutTests
[EFL] [DRT] Unskip KeyEvent related tests which are passing now
https://bugs.webkit.org/show_bug.cgi?id=84345
Unreviewed, unskip passing KeyEvent tests.
Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-04-19
- platform/efl/Skipped:
- 10:05 AM Changeset in webkit [114647] by
-
- 4 edits in trunk/Source/WebKit/chromium
IndexedDB: Stub out IDBCursor.advance for landing
https://bugs.webkit.org/show_bug.cgi?id=84280
Patch by Alec Flett <alecflett@chromium.org> on 2012-04-19
Reviewed by Dimitri Glazkov.
Just a stub method so it can be implemented on chromium
- public/WebIDBCursor.h:
(WebKit::WebIDBCursor::advance):
- src/WebIDBCursorImpl.cpp:
(WebKit::WebIDBCursorImpl::advance):
(WebKit):
- src/WebIDBCursorImpl.h:
(WebIDBCursorImpl):
- 10:00 AM Changeset in webkit [114646] by
-
- 2 edits in trunk/Tools
Move apple-xserve-10 from Lion Test to SnowLeopard Debug Build
- BuildSlaveSupport/build.webkit.org-config/config.json:
- 10:00 AM Changeset in webkit [114645] by
-
- 7 edits in trunk/Source/WebCore
Unreviewed, rolling out r114421.
http://trac.webkit.org/changeset/114421
https://bugs.webkit.org/show_bug.cgi?id=84103
Chromium crash
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateNormalAttrGetter):
(GenerateFunctionCallString):
(NativeToJSValue):
- bindings/scripts/test/V8/V8TestEventConstructor.cpp:
(WebCore::TestEventConstructorV8Internal::attr1AttrGetter):
(WebCore::TestEventConstructorV8Internal::attr2AttrGetter):
- bindings/scripts/test/V8/V8TestInterface.cpp:
(WebCore::TestInterfaceV8Internal::supplementalStr1AttrGetter):
(WebCore::TestInterfaceV8Internal::supplementalStr2AttrGetter):
- bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::TestObjV8Internal::readOnlyStringAttrAttrGetter):
(WebCore::TestObjV8Internal::stringAttrAttrGetter):
(WebCore::TestObjV8Internal::reflectedStringAttrAttrGetter):
(WebCore::TestObjV8Internal::reflectedURLAttrAttrGetter):
(WebCore::TestObjV8Internal::reflectedCustomURLAttrAttrGetter):
(WebCore::TestObjV8Internal::stringAttrWithGetterExceptionAttrGetter):
(WebCore::TestObjV8Internal::stringAttrWithSetterExceptionAttrGetter):
(WebCore::TestObjV8Internal::hashAttrGetter):
(WebCore::TestObjV8Internal::conditionalMethod1Callback):
- bindings/v8/V8Binding.cpp:
(WebCore::getElementStringAttr):
- bindings/v8/V8Binding.h:
(WebCore::v8ExternalString):
(WebCore::v8String):
(WebCore::v8StringOrNull):
(WebCore::v8StringOrUndefined):
(WebCore::v8StringOrFalse):
- 9:59 AM Changeset in webkit [114644] by
-
- 6 edits3 deletes in trunk
Unreviewed, rolling out r114626.
http://trac.webkit.org/changeset/114626
https://bugs.webkit.org/show_bug.cgi?id=84349
caused new assertions in debug builds (Requested by smfr_ on
#webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-19
Source/WebCore:
- inspector/InspectorResourceAgent.cpp:
(WebCore::InspectorResourceAgent::didReceiveData):
- inspector/NetworkResourcesData.cpp:
(WebCore::NetworkResourcesData::responseReceived):
- inspector/NetworkResourcesData.h:
(ResourceData):
(NetworkResourcesData):
- inspector/front-end/RequestView.js:
(WebInspector.RequestView.hasTextContent):
LayoutTests:
- http/tests/inspector/network/network-image-404-expected.txt: Removed.
- http/tests/inspector/network/network-image-404.html: Removed.
- http/tests/inspector/network/resources/404.php: Removed.
- 9:58 AM UpdatingBugzilla edited by
- (diff)
- 9:56 AM UpdatingBugzilla edited by
- (diff)
- 9:53 AM Changeset in webkit [114643] by
-
- 1 edit in branches/chromium/1084/Source/WebKit/chromium/src/WebPluginContainerImpl.cpp
Merge 114275
BUG=27086
TBR=raymes@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10113012
- 9:40 AM Changeset in webkit [114642] by
-
- 4 edits in branches/chromium/1084/Source/WebCore
Merge 114191 - [chromium] Remove viewport memory restrictions
https://bugs.webkit.org/show_bug.cgi?id=83316
Reviewed by Adrienne Walker.
We remove the memory restriction on web pages based on viewport size
on desktop. This is causing pages that have complex use of layers to
end up hitting our memory limits, and moreso when the window is small.
Page complexity is not really a function of the viewport size.
We drop the mininum memory limit entirely, and just evict all
unprotected textures instead.
Covered by existing tests.
- platform/graphics/chromium/TextureManager.cpp:
(WebCore::TextureManager::highLimitBytes):
(WebCore::TextureManager::reclaimLimitBytes):
- platform/graphics/chromium/TextureManager.h:
(TextureManager):
- platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::beginCommitOnImplThread):
(WebCore::CCLayerTreeHost::setVisible):
(WebCore::CCLayerTreeHost::didBecomeInvisibleOnImplThread):
(WebCore::CCLayerTreeHost::updateLayers):
TBR=danakj@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10025037
- 9:40 AM Changeset in webkit [114641] by
-
- 5 edits in trunk/Source
[Chromium] Call mimeRegistry directly
https://bugs.webkit.org/show_bug.cgi?id=84334
Reviewed by Kentaro Hara.
Part of a refactoring series. See tracking bug 82948.
Source/WebCore:
- platform/chromium/MIMETypeRegistryChromium.cpp:
(WebCore::MIMETypeRegistry::getMIMETypeForExtension):
(WebCore::MIMETypeRegistry::getWellKnownMIMETypeForExtension):
(WebCore::MIMETypeRegistry::getPreferredExtensionForMIMEType):
(WebCore::MIMETypeRegistry::isSupportedImageMIMEType):
(WebCore::MIMETypeRegistry::isSupportedJavaScriptMIMEType):
(WebCore::MIMETypeRegistry::isSupportedNonImageMIMEType):
- platform/chromium/PlatformSupport.h:
(PlatformSupport):
Source/WebKit/chromium:
- src/PlatformSupport.cpp:
(WebCore::PlatformSupport::layoutTestMode):
- 9:27 AM Changeset in webkit [114640] by
-
- 9 edits3 adds in trunk
Display a TextTrackCue when snap-to-lines flag is not set
https://bugs.webkit.org/show_bug.cgi?id=79750
Patch by Victor Carbune <vcarbune@adobe.com> on 2012-04-19
Reviewed by Eric Carlson.
Source/WebCore:
Support for positioning of a cue on top of the video element when snap-to-lines is not set.
Test: media/track/track-cue-rendering-snap-to-lines-not-set.html
- css/mediaControls.css:
(video::-webkit-media-text-track-container): Marked the container as
flexible box in order to use all the available space on top of the controls.
(video::-webkit-media-text-track-background): Added background default settings.
(video::-webkit-media-text-track-display): Added default position.
- html/shadow/MediaControlElements.cpp:
(WebCore::MediaControlTextTrackContainerElement::updateDisplay): Updated comments.
- html/track/TextTrackCue.cpp:
(WebCore):
(WebCore::TextTrackCue::TextTrackCue): Updated constructor to calculate
the computed line position.
(WebCore::TextTrackCue::setLine): Updated call to calculate the computed line
position.
(WebCore::TextTrackCue::setPosition):
(WebCore::TextTrackCue::calculateComputedLinePosition): Partial calculation of the
computated line position.
(WebCore::TextTrackCue::calculateDisplayParameters): Updated display parameter computations
required by the spec.
(WebCore::TextTrackCue::getDisplayTree): Updated positioning attributes when snap-to-lines
is not set. Added extra anonymous box for background, because setting position:absolute
on the display tree determines the background to cover the whole block, not just inline.
(WebCore::TextTrackCue::getPositionCoordinates): Determine coordinates as required by the spec.
- html/track/TextTrackCue.h:
(TextTrackCue):
LayoutTests:
Added tests to support positioning of cues when snap-to-lines set.
- media/media-controls.js:
(textTrackDisplayElement): Added an extra parameter, to return the display
box of the N-th active cue.
- media/track/captions-webvtt/captions-snap-to-lines-not-set.vtt: Added.
- media/track/track-cue-rendering-expected.txt: Updated background color check.
- media/track/track-cue-rendering-snap-to-lines-not-set-expected.txt: Added.
- media/track/track-cue-rendering-snap-to-lines-not-set.html: Added.
- media/track/track-cue-rendering.html: Updated background color check.
- 9:23 AM Changeset in webkit [114639] by
-
- 2 edits3 adds in trunk/LayoutTests
JSC testing should have complete coverage over typed array types
https://bugs.webkit.org/show_bug.cgi?id=84302
Rubber stamped by Gavin Barraclough.
Added float64 array test coverage.
- fast/js/dfg-float64array-expected.txt: Added.
- fast/js/dfg-float64array.html: Added.
- fast/js/jsc-test-list:
- fast/js/script-tests/dfg-float64array.js: Added.
(getter1):
(setter1):
(getter2):
(setter2):
(getter3):
(setter3):
(getter4):
(setter4):
(getters.getter1.a):
(.a):
(setters.setter1.a):
(safeGetter):
(safeSetter):
- 9:20 AM Changeset in webkit [114638] by
-
- 1 edit in branches/chromium/1084/Source/WebCore/inspector/InspectorIndexedDBAgent.cpp
Merge 114373 - Web Inspector: [Chromium] Crash when inspecting empty IndexedDB object store.
https://bugs.webkit.org/show_bug.cgi?id=84035
Reviewed by Pavel Feldman.
Added a check that m_idbCursor is not null before calling postSuccessHandlerCallback() on it.
- inspector/InspectorIndexedDBAgent.cpp:
(WebCore):
TBR=vsevik@chromium.org
BUG=121578
Review URL: https://chromiumcodereview.appspot.com/10125008
- 9:19 AM Changeset in webkit [114637] by
-
- 17 edits1 add in trunk/Source/WebCore
Web Inspector: introduce styles panel as an experiment
https://bugs.webkit.org/show_bug.cgi?id=84331
Reviewed by Vsevolod Vlasov.
This change introduces new "Styles" panel that looks like the "Scripts" one,
but operates stylesheets. This is happening under the experimental flag.
- English.lproj/localizedStrings.js:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- inspector/compile-front-end.py:
- inspector/front-end/Panel.js:
(WebInspector.Panel.prototype.showAnchorLocation):
- inspector/front-end/ResourceView.js:
(WebInspector.EditableResourceSourceFrame.prototype.didEditContent):
- inspector/front-end/ScriptsNavigator.js:
(WebInspector.ScriptsNavigatorController.prototype._navigatorOverlayWasShown):
- inspector/front-end/ScriptsPanel.js:
- inspector/front-end/Settings.js:
(WebInspector.ExperimentsSettings):
- inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame.prototype._clearLineHighlight):
- inspector/front-end/StylesPanel.js: Added.
(WebInspector.StylesPanel):
(WebInspector.StylesPanel.prototype.wasShown):
(WebInspector.StylesPanel.prototype._initialize):
(WebInspector.StylesPanel.prototype._populateResourceTree.populateFrame):
(WebInspector.StylesPanel.prototype._populateResourceTree):
(WebInspector.StylesPanel.prototype._resourceAdded):
(WebInspector.StylesPanel.prototype._reset):
(WebInspector.StylesPanel.prototype._cachedResourcesLoaded):
(WebInspector.StylesPanel.prototype.get toolbarItemLabel):
(WebInspector.StylesPanel.prototype.viewForFile.get if):
(WebInspector.StylesPanel.prototype.viewForFile):
(WebInspector.StylesPanel.prototype._textEdited):
(WebInspector.StylesPanel.prototype._scriptSelected):
(WebInspector.StylesPanel.prototype._showFile):
(WebInspector.StylesPanel.prototype.canShowAnchorLocation):
- inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylePropertiesSection):
(WebInspector.StylePropertiesSection.prototype._createRuleOriginNode):
- inspector/front-end/TabbedEditorContainer.js:
(WebInspector.TabbedEditorContainer):
- inspector/front-end/WebKit.qrc:
- inspector/front-end/inspector.html:
- inspector/front-end/inspector.js:
(WebInspector._createPanels):
(WebInspector._showAnchorLocationInPanel):
- inspector/front-end/scriptsPanel.css:
- inspector/front-end/splitView.css:
(.sidebar-overlay):
- 9:16 AM Changeset in webkit [114636] by
-
- 2 edits in trunk/Source/WebCore
Follow up to r114632: build fix.
- inspector/InspectorDebuggerAgent.cpp:
(WebCore):
(WebCore::InspectorDebuggerAgent::evaluateOnCallFrame):
- 9:10 AM WebKitGTK/1.8.x edited by
- (diff)
- 8:57 AM Changeset in webkit [114635] by
-
- 5 edits in trunk/Source
[Chromium] Call sampleGamepads directly
https://bugs.webkit.org/show_bug.cgi?id=84339
Reviewed by Kentaro Hara.
Part of a refactoring series. See tracking bug 82948.
Source/WebCore:
- platform/chromium/GamepadsChromium.cpp:
(WebCore::sampleGamepads):
- platform/chromium/PlatformSupport.h:
(WebCore):
(PlatformSupport):
Source/WebKit/chromium:
- src/PlatformSupport.cpp:
(WebCore::PlatformSupport::injectIDBKeyIntoSerializedValue):
- 8:51 AM Changeset in webkit [114634] by
-
- 2 edits in trunk/Source/WebKit/chromium
[Chromium] Call audioHardwareSampleRate directly
https://bugs.webkit.org/show_bug.cgi?id=84335
Reviewed by Kentaro Hara.
Part of a refactoring series. See tracking bug 82948.
- src/AudioDestinationChromium.cpp:
(WebCore::AudioDestination::hardwareSampleRate):
- 8:48 AM UpdatingBugzilla edited by
- Added (diff)
- 8:37 AM Changeset in webkit [114633] by
-
- 8 edits in trunk
[EFL] dispatchDidCancelClientRedirect needs implementation
https://bugs.webkit.org/show_bug.cgi?id=83669
Patch by Christophe Dumez <Christophe Dumez> on 2012-04-19
Reviewed by Antonio Gomes.
Source/WebKit/efl:
Emit a new "redirect,cancelled" signal on the ewk_frame when a
redirect is cancelled. This is needed by EFL's DumpRenderTree to dump
frame load callbacks information.
- WebCoreSupport/FrameLoaderClientEfl.cpp:
(WebCore::FrameLoaderClientEfl::dispatchDidCancelClientRedirect):
- ewk/ewk_frame.cpp:
(ewk_frame_redirect_cancelled):
- ewk/ewk_frame.h:
- ewk/ewk_private.h:
Tools:
Catch the new ewk_frame "redirect,cancelled" signal in EFL's DRT and
and print out information that is expected by several test cases if
LayoutTestController's dumpFrameLoadCallback() returns true.
- DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
(DumpRenderTreeChrome::createView):
(DumpRenderTreeChrome::onFrameCreated):
(DumpRenderTreeChrome::onFrameRedirectCancelled):
- DumpRenderTree/efl/DumpRenderTreeChrome.h:
(DumpRenderTreeChrome):
- 8:34 AM Changeset in webkit [114632] by
-
- 20 edits in trunk/Source/WebCore
Web Inspector: x-frame security errors logged when typing in the console are annoying.
https://bugs.webkit.org/show_bug.cgi?id=81970
Reviewed by Pavel Feldman.
Parameter DoNotPauseOnExceptions in Runtime.evaluate() renamed to DoNotPauseOnExceptionsAndMuteConsole.
Added this parameter to Runtime.callFunctionOn() and passed true in all call sites.
Added this parameter to Debugger.evaluateOnCallFrame().
Added a flag to console that mutes all messages unless they have ConsoleAPI message source.
This flag is now temporarily set from InspectorRuntimeAgent and InspectorDebuggerAgent for certain injected source calls.
- inspector/Inspector.json:
- inspector/InspectorDebuggerAgent.cpp:
(WebCore::asBool):
(WebCore):
(WebCore::InspectorDebuggerAgent::evaluateOnCallFrame):
- inspector/InspectorDebuggerAgent.h:
(InspectorDebuggerAgent):
- inspector/InspectorRuntimeAgent.cpp:
(WebCore):
(WebCore::setPauseOnExceptionsState):
(WebCore::InspectorRuntimeAgent::evaluate):
(WebCore::InspectorRuntimeAgent::callFunctionOn):
(WebCore::InspectorRuntimeAgent::getProperties):
- inspector/InspectorRuntimeAgent.h:
(InspectorRuntimeAgent):
- inspector/PageDebuggerAgent.cpp:
(WebCore::PageDebuggerAgent::muteConsole):
(WebCore):
(WebCore::PageDebuggerAgent::unmuteConsole):
- inspector/PageDebuggerAgent.h:
(PageDebuggerAgent):
- inspector/PageRuntimeAgent.cpp:
(WebCore::PageRuntimeAgent::muteConsole):
(WebCore):
(WebCore::PageRuntimeAgent::unmuteConsole):
- inspector/PageRuntimeAgent.h:
(PageRuntimeAgent):
- inspector/WorkerDebuggerAgent.cpp:
(WebCore::WorkerDebuggerAgent::muteConsole):
(WebCore):
(WebCore::WorkerDebuggerAgent::unmuteConsole):
- inspector/WorkerDebuggerAgent.h:
(WorkerDebuggerAgent):
- inspector/WorkerRuntimeAgent.cpp:
(WebCore::WorkerRuntimeAgent::muteConsole):
(WebCore):
(WebCore::WorkerRuntimeAgent::unmuteConsole):
- inspector/WorkerRuntimeAgent.h:
(WorkerRuntimeAgent):
- inspector/front-end/ConsoleView.js:
(WebInspector.ConsoleView.prototype.evalInInspectedWindow):
- inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel.prototype.evaluateInSelectedCallFrame):
(WebInspector.PresentationCallFrame.prototype.evaluate):
- inspector/front-end/RemoteObject.js:
(WebInspector.RemoteObject.prototype.setPropertyValue):
(WebInspector.RemoteObject.prototype.callFunction):
(WebInspector.RemoteObject.prototype.callFunctionJSON):
- inspector/front-end/WorkerManager.js:
- page/Console.cpp:
(WebCore::Console::addMessage):
(WebCore::Console::warn):
(WebCore):
(WebCore::Console::mute):
(WebCore::Console::unmute):
- page/Console.h:
(Console):
- 8:26 AM Changeset in webkit [114631] by
-
- 2 edits in trunk/Source/WebKit2
[Qt][WK2] Zoom out on the second double click does not always scale right.
https://bugs.webkit.org/show_bug.cgi?id=84332
Patch by Zalan Bujtas <zbujtas@gmail.com> on 2012-04-19
Reviewed by Simon Hausmann.
Zoom out to the minimum scale value instead of the fixed 1.
- UIProcess/qt/QtViewportInteractionEngine.cpp:
(WebKit::QtViewportInteractionEngine::zoomToAreaGestureEnded):
- 8:21 AM April 2012 Meeting edited by
- (diff)
- 7:46 AM Changeset in webkit [114630] by
-
- 20 edits in trunk/Source/WebCore
Unreviewed, rolling out r114628.
http://trac.webkit.org/changeset/114628
https://bugs.webkit.org/show_bug.cgi?id=84341
Breaks EFL and GTK builds (Requested by pfeldman on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-19
- inspector/Inspector.json:
- inspector/InspectorDebuggerAgent.cpp:
(WebCore):
(WebCore::InspectorDebuggerAgent::evaluateOnCallFrame):
- inspector/InspectorDebuggerAgent.h:
(InspectorDebuggerAgent):
- inspector/InspectorRuntimeAgent.cpp:
(WebCore::InspectorRuntimeAgent::evaluate):
(WebCore::InspectorRuntimeAgent::callFunctionOn):
(WebCore::InspectorRuntimeAgent::getProperties):
- inspector/InspectorRuntimeAgent.h:
(InspectorRuntimeAgent):
- inspector/PageDebuggerAgent.cpp:
- inspector/PageDebuggerAgent.h:
(PageDebuggerAgent):
- inspector/PageRuntimeAgent.cpp:
- inspector/PageRuntimeAgent.h:
(PageRuntimeAgent):
- inspector/WorkerDebuggerAgent.cpp:
- inspector/WorkerDebuggerAgent.h:
(WorkerDebuggerAgent):
- inspector/WorkerRuntimeAgent.cpp:
- inspector/WorkerRuntimeAgent.h:
(WorkerRuntimeAgent):
- inspector/front-end/ConsoleView.js:
(WebInspector.ConsoleView.prototype.evalInInspectedWindow):
- inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel.prototype.evaluateInSelectedCallFrame):
(WebInspector.PresentationCallFrame.prototype.evaluate):
- inspector/front-end/RemoteObject.js:
(WebInspector.RemoteObject.prototype.setPropertyValue):
(WebInspector.RemoteObject.prototype.callFunction):
(WebInspector.RemoteObject.prototype.callFunctionJSON):
- inspector/front-end/WorkerManager.js:
- page/Console.cpp:
(WebCore):
(WebCore::Console::addMessage):
(WebCore::Console::warn):
- page/Console.h:
(Console):
- 6:42 AM Changeset in webkit [114629] by
-
- 2 edits in trunk/LayoutTests
Add expectation for flaky svg/custom/foreign-object-skew.svg
Unreviewed Chromium expectations fix.
- platform/chromium/test_expectations.txt:
- 6:28 AM Changeset in webkit [114628] by
-
- 20 edits in trunk/Source/WebCore
Web Inspector: x-frame security errors logged when typing in the console are annoying.
https://bugs.webkit.org/show_bug.cgi?id=81970
Reviewed by Pavel Feldman.
Parameter DoNotPauseOnExceptions in Runtime.evaluate() renamed to DoNotPauseOnExceptionsAndMuteConsole.
Added this parameter to Runtime.callFunctionOn() and passed true in all call sites.
Added this parameter to Debugger.evaluateOnCallFrame().
Added a flag to console that mutes all messages unless they have ConsoleAPI message source.
This flag is now temporarily set from InspectorRuntimeAgent and InspectorDebuggerAgent for certain injected source calls.
- inspector/Inspector.json:
- inspector/InspectorDebuggerAgent.cpp:
(WebCore::asBool):
(WebCore):
(WebCore::InspectorDebuggerAgent::evaluateOnCallFrame):
- inspector/InspectorDebuggerAgent.h:
(InspectorDebuggerAgent):
- inspector/InspectorRuntimeAgent.cpp:
(WebCore):
(WebCore::setPauseOnExceptionsState):
(WebCore::InspectorRuntimeAgent::evaluate):
(WebCore::InspectorRuntimeAgent::callFunctionOn):
(WebCore::InspectorRuntimeAgent::getProperties):
- inspector/InspectorRuntimeAgent.h:
(InspectorRuntimeAgent):
- inspector/PageDebuggerAgent.cpp:
(WebCore::PageDebuggerAgent::muteConsole):
(WebCore):
(WebCore::PageDebuggerAgent::unmuteConsole):
- inspector/PageDebuggerAgent.h:
(PageDebuggerAgent):
- inspector/PageRuntimeAgent.cpp:
(WebCore::PageRuntimeAgent::muteConsole):
(WebCore):
(WebCore::PageRuntimeAgent::unmuteConsole):
- inspector/PageRuntimeAgent.h:
(PageRuntimeAgent):
- inspector/WorkerDebuggerAgent.cpp:
(WebCore::WorkerDebuggerAgent::muteConsole):
(WebCore):
(WebCore::WorkerDebuggerAgent::unmuteConsole):
- inspector/WorkerDebuggerAgent.h:
(WorkerDebuggerAgent):
- inspector/WorkerRuntimeAgent.cpp:
(WebCore::WorkerRuntimeAgent::muteConsole):
(WebCore):
(WebCore::WorkerRuntimeAgent::unmuteConsole):
- inspector/WorkerRuntimeAgent.h:
(WorkerRuntimeAgent):
- inspector/front-end/ConsoleView.js:
(WebInspector.ConsoleView.prototype.evalInInspectedWindow):
- inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel.prototype.evaluateInSelectedCallFrame):
(WebInspector.PresentationCallFrame.prototype.evaluate):
- inspector/front-end/RemoteObject.js:
(WebInspector.RemoteObject.prototype.setPropertyValue):
(WebInspector.RemoteObject.prototype.callFunction):
(WebInspector.RemoteObject.prototype.callFunctionJSON):
- inspector/front-end/WorkerManager.js:
- page/Console.cpp:
(WebCore::Console::addMessage):
(WebCore::Console::warn):
(WebCore):
(WebCore::Console::mute):
(WebCore::Console::unmute):
- page/Console.h:
(Console):
- 6:11 AM Changeset in webkit [114627] by
-
- 2 edits in trunk/Source/WebCore
[Qt] Fix Qt-Mac build after libxml patch
https://bugs.webkit.org/show_bug.cgi?id=84313
Use direct include/library paths instead of PKGCONFIG when on Mac.
Reviewed by Simon Hausmann.
No new tests, build fix.
- WebCore.pri:
- 5:08 AM Changeset in webkit [114626] by
-
- 6 edits3 adds in trunk
Web Inspector: No response body available for cached resource requests with error status codes.
https://bugs.webkit.org/show_bug.cgi?id=84265
Source/WebCore:
Reviewed by Pavel Feldman.
InspectorResourceAgent now saves failed subresource request response body in its cache.
Saved data is shown on front-end.
Test: http/tests/inspector/network/network-image-404.html
- inspector/InspectorResourceAgent.cpp:
(WebCore::InspectorResourceAgent::didReceiveData):
- inspector/NetworkResourcesData.cpp:
(WebCore::NetworkResourcesData::responseReceived):
(WebCore::NetworkResourcesData::httpStatusCode):
(WebCore):
- inspector/NetworkResourcesData.h:
(WebCore::NetworkResourcesData::ResourceData::httpStatusCode):
(WebCore::NetworkResourcesData::ResourceData::setHTTPStatusCode):
(ResourceData):
(NetworkResourcesData):
- inspector/front-end/RequestView.js:
(WebInspector.RequestView.hasTextContent):
LayoutTests:
- http/tests/inspector/network/network-image-404-expected.txt: Added.
- http/tests/inspector/network/network-image-404.html: Added.
- http/tests/inspector/network/resources/404.php: Added.
- 4:55 AM Changeset in webkit [114625] by
-
- 2 edits in trunk/LayoutTests
[Qt] Gardening. Skip failing reftest after 114574.
Patch by Ádám Kallai <kadam@inf.u-szeged.hu> on 2012-04-19
Reviewed by Csaba Osztrogonác.
- platform/qt/Skipped:
- 4:46 AM SelectiveTestBuildBot edited by
- (diff)
- 4:44 AM Changeset in webkit [114624] by
-
- 4 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Always use the AnimationFrameRateController for accelerated animations
https://bugs.webkit.org/show_bug.cgi?id=84323
Patch by Arvid Nilsson <anilsson@rim.com> on 2012-04-19
Reviewed by Antonio Gomes.
PR 150750
Regardless of whether there's a WebPageCompositorClient, we want the
AnimationFrameRateController to manage animation frames.
Reviewed internally by Andrew Lo.
- Api/BackingStore.cpp:
(BlackBerry::WebKit::BackingStorePrivate::blitContents):
- Api/WebPageCompositor.cpp:
(BlackBerry::WebKit::WebPageCompositorPrivate::WebPageCompositorPrivate):
(BlackBerry::WebKit::WebPageCompositorPrivate::drawLayers):
- Api/WebPageCompositor_p.h:
(WebPageCompositorPrivate):
- 4:39 AM SelectiveTestBuildBot edited by
- (diff)
- 4:39 AM Changeset in webkit [114623] by
-
- 10 edits in trunk
Web Inspector: reuse ParsedUrl in the UISourceCode
https://bugs.webkit.org/show_bug.cgi?id=84326
Reviewed by Yury Semikhatsky.
Source/WebCore:
Migrated UISourceCode to ParsedURL, moved the displayName logic into its only client:
TabbedEditorContainer.
- inspector/front-end/CompilerScriptMapping.js:
(WebInspector.SourceMapParser.prototype._canonicalizeURL):
- inspector/front-end/FilteredItemSelectionDialog.js:
(WebInspector.OpenResourceDialog.filterOutEmptyURLs):
(WebInspector.OpenResourceDialog.compareFunction):
(WebInspector.OpenResourceDialog):
(WebInspector.OpenResourceDialog.prototype.itemTitleAt):
(WebInspector.OpenResourceDialog.prototype.itemKeyAt):
- inspector/front-end/ResourceUtils.js:
(WebInspector.ParsedURL):
- inspector/front-end/ScriptsNavigator.js:
(WebInspector.ScriptsNavigator.prototype._getOrCreateFolderTreeElement):
(WebInspector.NavigatorFolderTreeElement):
- inspector/front-end/TabbedEditorContainer.js:
(WebInspector.TabbedEditorContainer.prototype._titleForFile):
- inspector/front-end/UISourceCode.js:
(WebInspector.UISourceCode):
(WebInspector.UISourceCode.prototype.get parsedURL):
LayoutTests:
- http/tests/inspector/debugger-test.js:
(initialize_DebuggerTest):
- inspector/debugger/ui-source-code-display-name.html:
- 4:36 AM SelectiveTestBuildBot edited by
- (diff)
- 3:18 AM SelectiveTestBuildBot edited by
- fixes (diff)
- 2:57 AM SelectiveTestBuildBot edited by
- (diff)
- 2:08 AM Changeset in webkit [114622] by
-
- 2 edits in trunk/Source/JavaScriptCore
[CMake] Build fix after r114575
https://bugs.webkit.org/show_bug.cgi?id=84322
Patch by Dominik Röttsches <dominik.rottsches@linux.intel.com> on 2012-04-19
Reviewed by Simon Hausmann.
Build fix, adding WTF when linking jsc shell.
- shell/CMakeLists.txt:
- 12:20 AM Changeset in webkit [114621] by
-
- 2 edits in trunk/Source/WebCore
Optimize for DARWIN in DirectConvolver::process()
https://bugs.webkit.org/show_bug.cgi?id=80256
Patch by Xingnan Wang <xingnan.wang@intel.com> on 2012-04-19
Reviewed by Chris Rogers.
- platform/audio/DirectConvolver.cpp:
(WebCore::DirectConvolver::process):
- 12:09 AM Changeset in webkit [114620] by
-
- 3 edits in releases/WebKitGTK/webkit-1.8/Source/WebCore/rendering/svg
Finish merge of r111601
- 12:07 AM Changeset in webkit [114619] by
-
- 1 edit1 add in trunk/LayoutTests
Unreviewed, add expected.txt for cookies-wrong-domain-rejected-result.php .
- http/tests/security/cookies/cookies-wrong-domain-rejected-result-expected.txt: Added.
- 12:05 AM Changeset in webkit [114618] by
-
- 1 edit in releases/WebKitGTK/webkit-1.8/Source/WebCore/rendering/svg/RenderSVGResourceContainer.cpp
Fix failed merge
Apr 18, 2012:
- 11:59 PM Changeset in webkit [114617] by
-
- 1 edit in releases/WebKitGTK/webkit-1.8/Source/WebCore/dom/ShadowRootList.cpp
Fix failed merge
- 11:56 PM Changeset in webkit [114616] by
-
- 2 edits in trunk/Source/WebCore
[CG] ImageBuffer::toDataURL: Remove alpha stuffing loop when encoding to JPEG
https://bugs.webkit.org/show_bug.cgi?id=84319
Reviewed by Eric Seidel.
No change in behavior. Covered by existing canvas 2d and 3d tests:
canvas/philip/tests/toDataURL.jpeg.alpha.html
fast/canvas/webgl/premultiplyalpha-test.html
- platform/graphics/cg/ImageBufferCG.cpp:
(WebCore::ImageBuffer::toDataURL): Remove the alpha stuffing loop and instead,
make JPEG encoder ignore the alpha channel (kCGImageAlphaNoneSkipLast).
- 11:54 PM Changeset in webkit [114615] by
-
- 2 edits in releases/WebKitGTK/webkit-1.8/Source/WebCore
Merging r110374
- 11:42 PM Changeset in webkit [114614] by
-
- 2 edits in releases/WebKitGTK/webkit-1.8/Source/WebCore
Merging r111601
- 11:38 PM Changeset in webkit [114613] by
-
- 4 edits2 adds in releases/WebKitGTK/webkit-1.8
Merging r111899
- 11:35 PM Changeset in webkit [114612] by
-
- 2 edits in trunk/LayoutTests
Unrevieded, rebaseline svg/as-image/img-preserveAspectRatio-support-1.html
- platform/chromium-mac-leopard/svg/as-image/img-preserveAspectRatio-support-1-expected.png:
- 11:35 PM Changeset in webkit [114611] by
-
- 10 edits2 adds in releases/WebKitGTK/webkit-1.8
Merging r110323
- 11:33 PM Changeset in webkit [114610] by
-
- 6 edits in releases/WebKitGTK/webkit-1.8/Source/WebCore
Fix a failed merge.
- 11:24 PM April 2012 Meeting edited by
- (diff)
- 10:40 PM Changeset in webkit [114609] by
-
- 2 edits in trunk/Source/WebCore
Remove unnecessary rounding/conversions in RenderBoxModelObject
https://bugs.webkit.org/show_bug.cgi?id=84288
Reviewed by Eric Seidel.
No new tests, no change in functionality.
- rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::paintBoxShadow):
Remove unnecessary pixelSnapping logic and casts in paintBoxShadow as
shadow rects are now int based.
- 10:21 PM Changeset in webkit [114608] by
-
- 6 edits3 adds in trunk
[BlackBerry] Parsed Cookie's m_hasDefaultDomain is not needed.
https://bugs.webkit.org/show_bug.cgi?id=82830
Patch by Jason Liu <jason.liu@torchmobile.com.cn> on 2012-04-18
Reviewed by George Staikos.
Source/WebCore:
RFC 2965
3.2.2
Domain = value
If an explicitly specified value does not start with a dot, the user agent supplies
a leading dot.
3.3.1
Domain Defaults to the effective request-host. (Note that because there is no dot
at the beginning of effective request-host, the default Domain can only domain-match
itself.)
The first char can show the difference even though it is from the cookie database.
But m_hasDefaultDomain is set to false if the cookie is from database although the
domain is host as a default value. So m_hasDefaultDomain sometimes is wrong.
In sum, we shouldn't use m_hasDefaultDomain.
Test: http/tests/security/cookies/cookies-wrong-domain-rejected.php
- platform/blackberry/CookieManager.cpp:
(WebCore::CookieManager::shouldRejectForSecurityReason):
- platform/blackberry/CookieParser.cpp:
(WebCore::CookieParser::parseOneCookie):
- platform/blackberry/ParsedCookie.cpp:
(WebCore::ParsedCookie::ParsedCookie):
- platform/blackberry/ParsedCookie.h:
(ParsedCookie):
LayoutTests:
- http/tests/security/cookies/cookies-wrong-domain-rejected-expected.txt: Added.
- http/tests/security/cookies/cookies-wrong-domain-rejected-result.php: Added.
- http/tests/security/cookies/cookies-wrong-domain-rejected.php: Added.
- 9:51 PM Changeset in webkit [114607] by
-
- 6 edits in trunk/Source/WebCore
[chromium] Consolidate adjustTextRenderMode copypasta into Skia context
https://bugs.webkit.org/show_bug.cgi?id=83840
Reviewed by James Robinson.
The same logic to decide when to make text use LCD rendering is copy
and pasted in all the different font classes. It seems like this
should live in a single place.
- platform/graphics/harfbuzz/FontHarfBuzz.cpp:
(WebCore::Font::drawGlyphs):
(WebCore::Font::drawComplexText):
- platform/graphics/skia/FontSkia.cpp:
(WebCore::Font::drawGlyphs):
- platform/graphics/skia/PlatformContextSkia.cpp:
(WebCore::PlatformContextSkia::adjustTextRenderMode):
(WebCore):
(WebCore::PlatformContextSkia::couldUseLCDRenderedText):
- platform/graphics/skia/PlatformContextSkia.h:
(PlatformContextSkia):
- platform/graphics/skia/SkiaFontWin.cpp:
(WebCore::setupPaintForFont):
- 9:45 PM Changeset in webkit [114606] by
-
- 2 edits in trunk/Source/WebKit/chromium
[chromium/mac] Fix build.
https://bugs.webkit.org/show_bug.cgi?id=84314
Unreviewed, build fix after http://trac.webkit.org/changeset/114604
- src/WebPluginContainerImpl.cpp:
(WebKit::WebPluginContainerImpl::setBackingIOSurfaceId):
- 9:33 PM April 2012 Meeting edited by
- (diff)
- 9:07 PM April 2012 Meeting edited by
- (diff)
- 9:02 PM April 2012 Meeting edited by
- (diff)
- 8:51 PM Changeset in webkit [114605] by
-
- 13 edits2 adds in trunk
Split SpellChecker::didCheck() to SpellChecker::didCheckSucceeded() and SpellChecker::didCheckCanceled()
https://bugs.webkit.org/show_bug.cgi?id=83748
Reviewed by Ryosuke Niwa.
Source/WebCore:
The current SpellChecker::didCheck() does not delete existing markers. It causes
a problem that it leaves misspelled markers when a spellchecker client finishes
checking text successfully. This change splits this function to didCheckSucceeded()
and didCheckCanceled() so the SpellChecker class can delete existing markers
when its client finishes checking text successfully. (We do not have to erase
existing markers when the client needs to cancel a text-check request.)
Test: platform/chromium/editing/spelling/delete-misspelled-word.html
- WebCore.exp.in: Replaced SpellChecker::didCheck with SpellChecker::didCheckSucceeded.
- editing/SpellChecker.cpp:
(WebCore::SpellChecker::didCheckSucceeded): Added.
(WebCore):
(WebCore::SpellChecker::didCheckCanceled): Added.
- editing/SpellChecker.h:
(SpellChecker): Added didCheckSucceeded and didCheckCanceled. Also changed didCheck to a private function.
Source/WebKit/chromium:
This change adds a new API WebTextCheckingCompletion::didCancelCheckingText(),
which encapsulates SpellChecker::didCheckCanceled() and implements it so
Chromium can use it.
- public/WebTextCheckingCompletion.h:
(WebKit::WebTextCheckingCompletion::didCancelCheckingText):
- src/WebTextCheckingCompletionImpl.cpp:
(WebKit::WebTextCheckingCompletionImpl::didFinishCheckingText):
(WebKit):
(WebKit::WebTextCheckingCompletionImpl::didCancelCheckingText):
- src/WebTextCheckingCompletionImpl.h:
(WebTextCheckingCompletionImpl):
Source/WebKit/mac:
This change replaces a call for SpellChecker::didCheck() with one for
SpellChecker::didCheckSucceeded() because didCheck has been split into
didCheckSucceeded(0 and didCheckCanceled().
- WebCoreSupport/WebEditorClient.mm:
(-[WebEditorSpellCheckResponder perform]): Replaced didCheck with didCheckSucceeded.
Tools:
This change replaces a call for SpellChecker::didCheck() with one for
SpellChecker::didCheckCenceled() because didCheck() has been split into
didCheckSucceeded() and didCheckCanceled().
- DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::requestCheckingOfText): Replaced didCheck with didCheckCanceled.
LayoutTests:
The current SpellChecker::didCheck() does not delete existing markers. It causes
a problem that it leaves misspelled markers when a spellchecker client finishes
checking text successfully. This change splits this function to didCheckSucceeded()
and didCheckCanceled() so the SpellChecker class can delete existing markers
when its client finishes checking text successfully. (We do not have to erase
existing markers when the client needs to cancel a text-check request.)
- platform/chromium/editing/spelling/delete-misspelled-word-expected.txt: Added.
- platform/chromium/editing/spelling/delete-misspelled-word.html: Added.
- 8:29 PM April 2012 Meeting edited by
- (diff)
- 8:29 PM April 2012 Meeting edited by
- (diff)
- 8:26 PM April 2012 Meeting edited by
- (diff)
- 7:48 PM Changeset in webkit [114604] by
-
- 15 edits2 moves3 deletes in trunk/Source
[chromium] Convert WebPluginContainerImpl over to use WebExternalTextureLayer
https://bugs.webkit.org/show_bug.cgi?id=84120
Reviewed by Adrienne Walker.
Source/Platform:
This adds support for IO surface backed WebExternalTextureLayer, used by CoreAnimation plugins on OS X and moves
some functionality used by multiple WebLayer subclasses up to the base class.
- chromium/public/WebContentLayer.h:
(WebContentLayer):
- chromium/public/WebExternalTextureLayer.h:
(WebCore):
(WebExternalTextureLayer):
- chromium/public/WebLayer.h:
(WebKit):
(WebLayer):
(WebKit::WebLayer::unwrap):
Source/WebCore:
This renames PluginLayerChromium -> TextureLayerChromium since it is now used only as the implementation of
WebExternalTextureLayer and cleans it up slightly.
- WebCore.gypi:
- platform/graphics/chromium/TextureLayerChromium.cpp: Renamed from Source/WebCore/platform/graphics/chromium/PluginLayerChromium.cpp.
(WebCore):
(WebCore::TextureLayerChromium::create):
(WebCore::TextureLayerChromium::TextureLayerChromium):
(WebCore::TextureLayerChromium::createCCLayerImpl):
(WebCore::TextureLayerChromium::drawsContent):
(WebCore::TextureLayerChromium::setTextureId):
(WebCore::TextureLayerChromium::setFlipped):
(WebCore::TextureLayerChromium::setUVRect):
(WebCore::TextureLayerChromium::setIOSurfaceProperties):
(WebCore::TextureLayerChromium::pushPropertiesTo):
- platform/graphics/chromium/TextureLayerChromium.h: Renamed from Source/WebCore/platform/graphics/chromium/PluginLayerChromium.h.
(WebCore):
(TextureLayerChromium):
(WebCore::TextureLayerChromium::flipped):
(WebCore::TextureLayerChromium::uvRect):
Source/WebKit/chromium:
This ports WebPluginContainerImpl over to use WebExternalTextureLayer instead of directly using a *LayerChromium
type for better layering and code sharing. The changes to WebPluginContainerImpl are fairly straightforward. In
addition to renames I also moved some state tracking into WPCI instead of having it exposed on the interface. I
also removed the WebExternalTextureLayerImpl intermediate class since it wasn't doing anything useful.
- WebKit.gyp:
- WebKit.gypi:
- src/WebContentLayer.cpp:
- src/WebExternalTextureLayer.cpp:
(WebKit::WebExternalTextureLayer::create):
(WebKit::WebExternalTextureLayer::setTextureId):
(WebKit::WebExternalTextureLayer::setIOSurfaceProperties):
(WebKit::WebExternalTextureLayer::setFlipped):
(WebKit::WebExternalTextureLayer::flipped):
(WebKit::WebExternalTextureLayer::setUVRect):
(WebKit::WebExternalTextureLayer::uvRect):
(WebKit::WebExternalTextureLayer::WebExternalTextureLayer):
- src/WebExternalTextureLayerImpl.cpp: Removed.
- src/WebExternalTextureLayerImpl.h: Removed.
- src/WebLayer.cpp:
(WebKit::WebLayer::invalidateRect):
(WebKit):
(WebKit::WebLayer::invalidate):
- src/WebPluginContainerImpl.cpp:
(WebKit::WebPluginContainerImpl::setBackingTextureId):
(WebKit::WebPluginContainerImpl::setBackingIOSurfaceId):
(WebKit::WebPluginContainerImpl::commitBackingTexture):
(WebKit::WebPluginContainerImpl::setOpaque):
(WebKit::WebPluginContainerImpl::platformLayer):
(WebKit::WebPluginContainerImpl::WebPluginContainerImpl):
- src/WebPluginContainerImpl.h:
(WebCore):
(WebPluginContainerImpl):
- tests/WebExternalTextureLayerImplTest.cpp: Removed.
- tests/WebLayerTest.cpp:
- 7:44 PM April 2012 Meeting edited by
- (diff)
- 7:32 PM Changeset in webkit [114603] by
-
- 9 edits in trunk
Expose attack, release as DynamicsCompressorNode's attributes.
https://bugs.webkit.org/show_bug.cgi?id=81221
Patch by Raymond Toy <Raymond Toy> on 2012-04-18
Reviewed by Chris Rogers.
Source/WebCore:
- Modules/webaudio/DynamicsCompressorNode.cpp:
(WebCore::DynamicsCompressorNode::DynamicsCompressorNode):
(WebCore::DynamicsCompressorNode::process):
- Modules/webaudio/DynamicsCompressorNode.h:
(WebCore::DynamicsCompressorNode::attack):
(WebCore::DynamicsCompressorNode::releaseTime):
(DynamicsCompressorNode):
- Modules/webaudio/DynamicsCompressorNode.idl: Add attack and
release attributes.
- bindings/scripts/CodeGeneratorObjC.pm:
(SkipAttribute): Skip release()
(GenerateHeader): Call SkipAttribute for getters/setters.
- platform/audio/DynamicsCompressor.h:
(DynamicsCompressor):
LayoutTests:
- webaudio/dynamicscompressor-basic-expected.txt:
- webaudio/dynamicscompressor-basic.html:
- 7:02 PM Changeset in webkit [114602] by
-
- 2 edits in trunk/Tools
Fix failure in test-webkitpy after r114583.
Unreviewed, build fix.
Updating the call site in r114583 w/o updating the test caused
the test to fail. Somehow I forgot to run the unit tests :(.
- Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
(ChromiumDriverTest.test_crash_log):
- 7:01 PM Changeset in webkit [114601] by
-
- 10 edits in trunk/Source
[chromium] Simplify occlusion tracker API by passing layer iterator data
https://bugs.webkit.org/show_bug.cgi?id=84088
Reviewed by Adrienne Walker.
Source/WebCore:
Previously three methods lived in the API and you needed to call the
appropriate method (with different amounts of data) depending on what
the current layer iterator was representing.
This makes usage of the occlusion tracker simpler to read and harder
to mess up, by just passing in the layer iterator at each step of the
iteration process.
Covered by existing tests.
- platform/graphics/chromium/cc/CCLayerIterator.h:
(WebCore):
(CCLayerIteratorPosition):
(CCLayerIterator):
(WebCore::CCLayerIterator::operator const CCLayerIteratorPosition<LayerType>):
- platform/graphics/chromium/cc/CCLayerTilingData.cpp:
(WebCore::CCLayerTilingData::opaqueRegionInLayerRect):
- platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::paintLayerContents):
- platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::calculateRenderPasses):
- platform/graphics/chromium/cc/CCOcclusionTracker.cpp:
(WebCore::::enterLayer):
(WebCore):
(WebCore::::leaveLayer):
- platform/graphics/chromium/cc/CCOcclusionTracker.h:
(CCOcclusionTrackerBase):
Source/WebKit/chromium:
- tests/CCOcclusionTrackerTest.cpp:
(CCOcclusionTrackerTestMainThreadTypes):
(CCOcclusionTrackerTestImplThreadTypes):
(WebKitTests::CCOcclusionTrackerTest::CCOcclusionTrackerTest):
(WebKitTests::CCOcclusionTrackerTest::calcDrawEtc):
(CCOcclusionTrackerTest):
(WebKitTests::CCOcclusionTrackerTest::enterLayer):
(WebKitTests::CCOcclusionTrackerTest::leaveLayer):
(WebKitTests::CCOcclusionTrackerTest::visitLayer):
(WebKitTests::CCOcclusionTrackerTest::enterContributingSurface):
(WebKitTests::CCOcclusionTrackerTest::leaveContributingSurface):
(WebKitTests::CCOcclusionTrackerTest::visitContributingSurface):
(WebKitTests::CCOcclusionTrackerTest::resetLayerIterator):
(WebKitTests::CCOcclusionTrackerTestIdentityTransforms::runMyTest):
(WebKitTests::CCOcclusionTrackerTestRotatedChild::runMyTest):
(WebKitTests::CCOcclusionTrackerTestTranslatedChild::runMyTest):
(WebKitTests::CCOcclusionTrackerTestChildInRotatedChild::runMyTest):
(WebKitTests::CCOcclusionTrackerTestVisitTargetTwoTimes::runMyTest):
(WebKitTests::CCOcclusionTrackerTestSurfaceRotatedOffAxis::runMyTest):
(WebKitTests::CCOcclusionTrackerTestSurfaceWithTwoOpaqueChildren::runMyTest):
(WebKitTests::CCOcclusionTrackerTestOverlappingSurfaceSiblings::runMyTest):
(WebKitTests::CCOcclusionTrackerTestOverlappingSurfaceSiblingsWithTwoTransforms::runMyTest):
(WebKitTests::CCOcclusionTrackerTestFilters::runMyTest):
(WebKitTests::CCOcclusionTrackerTestReplicaDoesOcclude::runMyTest):
(WebKitTests::CCOcclusionTrackerTestReplicaWithClipping::runMyTest):
(WebKitTests::CCOcclusionTrackerTestLayerScissorRectOutsideChild::runMyTest):
(WebKitTests::CCOcclusionTrackerTestScreenScissorRectOutsideChild::runMyTest):
(WebKitTests::CCOcclusionTrackerTestLayerScissorRectOverChild::runMyTest):
(WebKitTests::CCOcclusionTrackerTestScreenScissorRectOverChild::runMyTest):
(WebKitTests::CCOcclusionTrackerTestLayerScissorRectPartlyOverChild::runMyTest):
(WebKitTests::CCOcclusionTrackerTestScreenScissorRectPartlyOverChild::runMyTest):
(WebKitTests::CCOcclusionTrackerTestLayerScissorRectOverNothing::runMyTest):
(WebKitTests::CCOcclusionTrackerTestScreenScissorRectOverNothing::runMyTest):
(WebKitTests::CCOcclusionTrackerTestLayerScissorRectForLayerOffOrigin::runMyTest):
(WebKitTests::CCOcclusionTrackerTestOpaqueContentsRegionEmpty::runMyTest):
(WebKitTests::CCOcclusionTrackerTestOpaqueContentsRegionNonEmpty::runMyTest):
(WebKitTests::CCOcclusionTrackerTest3dTransform::runMyTest):
(WebKitTests::CCOcclusionTrackerTestPerspectiveTransform::runMyTest):
(WebKitTests::CCOcclusionTrackerTestPerspectiveTransformBehindCamera::runMyTest):
(WebKitTests::CCOcclusionTrackerTestLayerBehindCameraDoesNotOcclude::runMyTest):
(WebKitTests::CCOcclusionTrackerTestLargePixelsOccludeInsideClipRect::runMyTest):
(WebKitTests::CCOcclusionTrackerTestAnimationOpacity1OnMainThread::runMyTest):
(WebKitTests::CCOcclusionTrackerTestAnimationOpacity0OnMainThread::runMyTest):
(WebKitTests::CCOcclusionTrackerTestAnimationTranslateOnMainThread::runMyTest):
(WebKitTests::CCOcclusionTrackerTestSurfaceOcclusionTranslatesToParent::runMyTest):
(WebKitTests::CCOcclusionTrackerTestSurfaceOcclusionTranslatesWithClipping::runMyTest):
(WebKitTests::CCOcclusionTrackerTestReplicaOccluded::runMyTest):
(WebKitTests::CCOcclusionTrackerTestSurfaceWithReplicaUnoccluded::runMyTest):
(WebKitTests::CCOcclusionTrackerTestSurfaceAndReplicaOccludedDifferently::runMyTest):
(WebKitTests::CCOcclusionTrackerTestSurfaceChildOfSurface::runMyTest):
(WebKitTests::CCOcclusionTrackerTestSurfaceChildOfClippingSurface::runMyTest):
- tests/CCQuadCullerTest.cpp:
(WebCore):
(WebCore::makeLayer):
(WebCore::appendQuads):
(WebCore::TEST):
- 6:47 PM Changeset in webkit [114600] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, GTK test_expectations update.
- platform/gtk/test_expectations.txt: Mark new fast/table test as failing.
- 6:30 PM Changeset in webkit [114599] by
-
- 9 edits in trunk/Source
[chromium] Add canBeginFrame state to CCSchedulerStateMachine to suppress initialization before our surface is available
https://bugs.webkit.org/show_bug.cgi?id=84301
Reviewed by Adrienne Walker.
Source/WebCore:
If our composited surface isn't ready yet, then the compositor may initialize in a state where the first
makeContextCurrent() fails. This adds a new state to the scheduler that we can use to suppress initialization
until we get notified that the surface is ready. I'll add the plumbing for actually notifying in a follow-up.
Updated CCSchedulerTest / CCSchedulerStateMachineTest unit tests.
- platform/graphics/chromium/cc/CCScheduler.cpp:
(WebCore::CCScheduler::setCanBeginFrame):
(WebCore):
- platform/graphics/chromium/cc/CCScheduler.h:
(CCScheduler):
- platform/graphics/chromium/cc/CCSchedulerStateMachine.cpp:
(WebCore::CCSchedulerStateMachine::CCSchedulerStateMachine):
(WebCore::CCSchedulerStateMachine::nextAction):
- platform/graphics/chromium/cc/CCSchedulerStateMachine.h:
(WebCore::CCSchedulerStateMachine::setCanBeginFrame):
(CCSchedulerStateMachine):
- platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::initializeImplOnImplThread):
Source/WebKit/chromium:
Update unit tests for new canBeginFrame bit.
- tests/CCSchedulerStateMachineTest.cpp:
(WebCore::TEST):
(WebCore):
- tests/CCSchedulerTest.cpp:
(WebKitTests::TEST):
- 6:22 PM Changeset in webkit [114598] by
-
- 3 edits2 adds in releases/WebKitGTK/webkit-1.8
Merging r112935
- 6:22 PM Changeset in webkit [114597] by
-
- 4 edits in releases/WebKitGTK/webkit-1.8/Source/WebCore
Merging r112596
- 6:20 PM Changeset in webkit [114596] by
-
- 2 edits in releases/WebKitGTK/webkit-1.8/Source/WebCore
Merging r112596
- 6:20 PM Changeset in webkit [114595] by
-
- 7 edits2 adds in releases/WebKitGTK/webkit-1.8
Merging r112200
- 6:10 PM Changeset in webkit [114594] by
-
- 21 edits in trunk/LayoutTests
JSC testing should have complete coverage over typed array types
https://bugs.webkit.org/show_bug.cgi?id=84302
Rubber stamped by Geoff Garen.
Changed calls to shouldBe("...", "...") to be more informative, per Geoff's
suggestion.
- fast/js/dfg-float32array-expected.txt:
- fast/js/dfg-int16array-expected.txt:
- fast/js/dfg-int32array-expected.txt:
- fast/js/dfg-int32array-overflow-values-expected.txt:
- fast/js/dfg-int8array-expected.txt:
- fast/js/dfg-uint16array-expected.txt:
- fast/js/dfg-uint32array-expected.txt:
- fast/js/dfg-uint32array-overflow-values-expected.txt:
- fast/js/dfg-uint8array-expected.txt:
- fast/js/dfg-uint8clampedarray-expected.txt:
- fast/js/script-tests/dfg-float32array.js:
- fast/js/script-tests/dfg-int16array.js:
- fast/js/script-tests/dfg-int32array-overflow-values.js:
- fast/js/script-tests/dfg-int32array.js:
- fast/js/script-tests/dfg-int8array.js:
- fast/js/script-tests/dfg-uint16array.js:
- fast/js/script-tests/dfg-uint32array-overflow-values.js:
- fast/js/script-tests/dfg-uint32array.js:
- fast/js/script-tests/dfg-uint8array.js:
- fast/js/script-tests/dfg-uint8clampedarray.js:
- 6:05 PM Changeset in webkit [114593] by
-
- 22 edits4 adds in releases/WebKitGTK/webkit-1.8
Merging r112184
- 6:03 PM Changeset in webkit [114592] by
-
- 7 edits2 adds in releases/WebKitGTK/webkit-1.8
Merging r112119
- 6:02 PM Changeset in webkit [114591] by
-
- 4 edits2 adds in releases/WebKitGTK/webkit-1.8
Merging r112012
- 5:55 PM Changeset in webkit [114590] by
-
- 3 edits2 adds in releases/WebKitGTK/webkit-1.8
Merging r111912
- 5:52 PM Changeset in webkit [114589] by
-
- 6 edits2 adds in releases/WebKitGTK/webkit-1.8
Merging r111895
- 5:32 PM Changeset in webkit [114588] by
-
- 2 edits in releases/WebKitGTK/webkit-1.8/Source/WebCore
Merging r110139
- 5:15 PM Changeset in webkit [114587] by
-
- 11 edits9 adds in trunk
JSC testing should have complete coverage over typed array types
https://bugs.webkit.org/show_bug.cgi?id=84302
Source/JavaScriptCore:
Reviewed by Geoff Garen.
Added Uint8ClampedArray to the set of typed arrays that are supported by jsc
command-line.
- JSCTypedArrayStubs.h:
(JSC):
- jsc.cpp:
(GlobalObject::finishCreation):
Tools:
Reviewed by Geoff Garen.
Made run-fast-jsc print something and a newline if jsc threw an exception or
otherwise returned with an error code, but did not crash.
- Scripts/run-fast-jsc:
LayoutTests:
Reviewed by Geoff Garen.
Added tests for uint8 and uint16 arrays. Added a test for uint32 arrays that
does not focus entirely on overflow values.
Also added the typed array tests to the repertoire that can be run by
run-fast-jsc.
- fast/js/dfg-int16array-expected.txt:
- fast/js/dfg-int8array-expected.txt:
- fast/js/dfg-uint16array-expected.txt: Added.
- fast/js/dfg-uint16array.html: Added.
- fast/js/dfg-uint32array-expected.txt: Added.
- fast/js/dfg-uint32array.html: Added.
- fast/js/dfg-uint8array-expected.txt: Added.
- fast/js/dfg-uint8array.html: Added.
- fast/js/jsc-test-list:
- fast/js/script-tests/dfg-int16array.js:
- fast/js/script-tests/dfg-int8array.js:
- fast/js/script-tests/dfg-uint16array.js: Added.
(getter1):
(setter1):
(getter2):
(setter2):
(getter3):
(setter3):
(getter4):
(setter4):
(getters.getter1.a):
(.a):
(setters.setter1.a):
(safeGetter):
(safeSetter):
- fast/js/script-tests/dfg-uint32array.js: Added.
(getter1):
(setter1):
(getter2):
(setter2):
(getter3):
(setter3):
(getter4):
(setter4):
(getters.getter1.a):
(.a):
(setters.setter1.a):
(safeGetter):
(safeSetter):
- fast/js/script-tests/dfg-uint8array.js: Added.
(getter1):
(setter1):
(getter2):
(setter2):
(getter3):
(setter3):
(getter4):
(setter4):
(getters.getter1.a):
(.a):
(setters.setter1.a):
(safeGetter):
(safeSetter):
- 5:11 PM Changeset in webkit [114586] by
-
- 4 edits in trunk/LayoutTests
[GTK] r114021 triggered media flakyness
https://bugs.webkit.org/show_bug.cgi?id=83874
Reviewed by Eric Carlson.
Fix-up use of setMediaPlaybackRequiresUserGesture() in two media
tests.
- media/video-load-require-user-gesture.html:
- media/video-play-require-user-gesture.html:
- platform/gtk/test_expectations.txt:
- 5:05 PM Changeset in webkit [114585] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, GTK test_expectations update.
- platform/gtk/test_expectations.txt: Unflag some tests now passing.
- 5:04 PM Changeset in webkit [114584] by
-
- 2 edits in trunk/Source/WTF
Somehow, there's an errant backslash in my last WTF patch
https://bugs.webkit.org/show_bug.cgi?id=84290
Patch by Myles Maxfield <mmaxfield@google.com> on 2012-04-18
Reviewed by Andreas Kling.
- wtf/StdLibExtras.h:
(WTF::roundUpToMultipleOf):
- 4:56 PM Changeset in webkit [114583] by
-
- 2 edits in trunk/Tools
Fix crash in chromium.py after r114877.
Unreviewed, build fix.
Missed updating one call site for get_crash_log() :(.
- Scripts/webkitpy/layout_tests/port/chromium.py:
(ChromiumDriver.run_test):
- 4:38 PM Changeset in webkit [114582] by
-
- 3 edits in releases/WebKitGTK/webkit-1.8/Source/WebCore
Merging r111775
- 4:34 PM Changeset in webkit [114581] by
-
- 3 edits2 adds in releases/WebKitGTK/webkit-1.8
Merging r111714
- 4:32 PM Changeset in webkit [114580] by
-
- 4 edits in trunk/Source
[Chromium] Solid color layers should respect opacity value.
https://bugs.webkit.org/show_bug.cgi?id=84197
Patch by David Reveman <reveman@chromium.org> on 2012-04-18
Reviewed by Adrienne Walker.
Source/WebCore:
Fold opacity into shader color for solid color layers.
Test: CCSolidColorLayerImplTest.verifyCorrectOpacityInQuad
- platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::drawSolidColorQuad):
Source/WebKit/chromium:
- tests/CCSolidColorLayerImplTest.cpp:
(CCLayerTestCommon::TEST):
(CCLayerTestCommon):
- 4:29 PM Changeset in webkit [114579] by
-
- 2 edits in trunk/Tools
[GTK] NRWT bails out if more than one X server runs on the machine
https://bugs.webkit.org/show_bug.cgi?id=84276
Reviewed by Dirk Pranke.
Set up GTK driver's Xvfb display number based on Xorg servers
currently running.
- Scripts/webkitpy/layout_tests/port/gtk.py:
(GtkDriver._start):
(GtkDriver._start.x_filter):
- 4:23 PM Changeset in webkit [114578] by
-
- 3 edits5 adds in releases/WebKitGTK/webkit-1.8
Merging r111556
- 4:17 PM Changeset in webkit [114577] by
-
- 10 edits in trunk/Tools
run-webkit-tests picked up an old crash log
https://bugs.webkit.org/show_bug.cgi?id=84196
Reviewed by Ryosuke Niwa.
Modify the crash log-finding code so that we can
limit our search to logs newer than X - this prevents
us from finding old crash logs for a given process/pid
combination even when the PIDs might've wrapped.
Also fix a bug in filesystem_mock where files_under() would
return paths that didn't exist.
- Scripts/webkitpy/common/system/crashlogs.py:
(CrashLogs.find_newest_log):
(CrashLogs._find_newest_log_darwin):
- Scripts/webkitpy/common/system/crashlogs_unittest.py:
(CrashLogsTest.test_find_log_darwin):
(CrashLogsTest.test_find_log_darwin.bad_read):
(CrashLogsTest):
- Scripts/webkitpy/common/system/filesystem_mock.py:
(MockFileSystem.files_under):
- Scripts/webkitpy/layout_tests/port/base.py:
(Port._get_crash_log):
- Scripts/webkitpy/layout_tests/port/gtk.py:
(GtkPort._get_crash_log):
- Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
- Scripts/webkitpy/layout_tests/port/mac.py:
(MacPort._get_crash_log):
- Scripts/webkitpy/layout_tests/port/port_testcase.py:
(PortTestCase.test_get_crash_log):
- Scripts/webkitpy/layout_tests/port/webkit.py:
(WebKitDriver.run_test):
- 4:11 PM April 2012 Meeting edited by
- (diff)
- 4:10 PM Changeset in webkit [114576] by
-
- 5 edits in trunk/Source
[Chromium] Call prefetchDNS directly
https://bugs.webkit.org/show_bug.cgi?id=84262
Reviewed by Kentaro Hara.
Part of a series, see tracking bug 82948.
Source/WebCore:
- platform/chromium/PlatformSupport.h:
(PlatformSupport):
- platform/network/chromium/DNSChromium.cpp:
(WebCore::prefetchDNS):
Source/WebKit/chromium:
- src/PlatformSupport.cpp:
(WebCore):
- 4:08 PM Changeset in webkit [114575] by
-
- 3 edits in trunk/Source/JavaScriptCore
jsc command line should support typed arrays by default
https://bugs.webkit.org/show_bug.cgi?id=84298
Rubber stamped by Gavin Barraclough.
- JSCTypedArrayStubs.h:
(JSC):
- jsc.cpp:
(GlobalObject::finishCreation):
- 4:07 PM Changeset in webkit [114574] by
-
- 3 edits2 adds in trunk
REGRESSION(102040): Auto-table layout with percent width doesn't shrink-to-fit content a cell with colspan
https://bugs.webkit.org/show_bug.cgi?id=84260
Reviewed by Ojan Vafai.
Source/WebCore:
Tests: fast/table/td-width-fifty-percent-regression-expected.html
fast/table/td-width-fifty-percent-regression.html
- rendering/AutoTableLayout.cpp:
(WebCore::AutoTableLayout::calcEffectiveLogicalWidth):
As we are spreading the cell's min / max logical width, we should be updating them.
This prevents the following logic getting confused and allocating more than needed.
LayoutTests:
- fast/table/td-width-fifty-percent-regression-expected.html: Added.
- fast/table/td-width-fifty-percent-regression.html: Added.
- 3:59 PM Changeset in webkit [114573] by
-
- 2 edits in branches/chromium/1084/Source/WebCore
Merge 114342 - Auto-sized frames may be taller than expected
https://bugs.webkit.org/show_bug.cgi?id=84106
Patch by Andrei Burago <aburago@chromium.org> on 2012-04-16
Reviewed by David Levin.
No new tests. The repro steps require using Chrome notifications on Win.
- page/FrameView.cpp:
(WebCore::FrameView::autoSizeIfEnabled):
TBR=commit-queue@webkit.org
Review URL: https://chromiumcodereview.appspot.com/10035046
- 3:57 PM Changeset in webkit [114572] by
-
- 4 edits in branches/chromium/1084/Source/WebCore
Merge 113287 - Auto-size may not work on first load
https://bugs.webkit.org/show_bug.cgi?id=82989
Patch by Andrei Burago <aburago@chromium.org> on 2012-04-04
Reviewed by David Levin.
No new tests. The only known repro scenario involves using chrome with a third-party extension,
which makes making a test out of it problematic.
- dom/Document.cpp:
(WebCore::Document::implicitClose):
- page/FrameView.cpp:
(WebCore::FrameView::autoSizeIfEnabled):
TBR=commit-queue@webkit.org
Review URL: https://chromiumcodereview.appspot.com/10116046
- 3:49 PM Changeset in webkit [114571] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, GTK test_expectations update.
- platform/gtk/test_expectations.txt: Mark some tests as crashing
in debug builds due to bug 63611.
- 3:31 PM Changeset in webkit [114570] by
-
- 3 edits in trunk/Source/JavaScriptCore
JSVALUE32_64 should be able to perform division on ARM without crashing, and variables
forced double should not be scrambled when performing OSR entry
https://bugs.webkit.org/show_bug.cgi?id=84272
Reviewed by Geoff Garen.
- dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
- dfg/DFGOSREntry.cpp:
(JSC::DFG::prepareOSREntry):
- 3:29 PM Changeset in webkit [114569] by
-
- 2 edits in trunk/Source/WebCore
Win8 builds usually fail due to cygwin rebasing
https://bugs.webkit.org/show_bug.cgi?id=84274
Reviewed by Dirk Pranke.
Cygwin can fail to spawn children if the DLL is rebased. This happens
frequently enough on Windows 8 that we should retry on failure.
No new tests. No behavior changed.
- bindings/scripts/preprocessor.pm:
(applyPreprocessor):
- 3:03 PM Changeset in webkit [114568] by
-
- 2 edits in trunk/Source/WebCore
Add explicit template instantiation to chromium/PopupListBox.cpp to prepare for sub-pixel layout
https://bugs.webkit.org/show_bug.cgi?id=84264
Reviewed by Eric Seidel.
Explicitly instantiating integer max and min templates to fix compilation in Chromium. We
intentionally truncated these values in platform code, which matches earlier behavior.
See https://trac.webkit.org/wiki/LayoutUnit for details.
No new tests. No change in behavior.
- platform/chromium/PopupListBox.cpp:
(WebCore::PopupListBox::paintRow):
(WebCore::PopupListBox::layout):
- 2:53 PM Changeset in webkit [114567] by
-
- 4 edits in trunk/Source
Full Screen mode does not preserve CALayer ordering after exiting.
https://bugs.webkit.org/show_bug.cgi?id=83931
Reviewed by Eric Carlson.
When swapping the placeholder and web views, use -[NSView addSubview:positioned:relativeTo:]
instead of -[NSView replaceSubview:with:], as the latter does not preserve the relative order
of the view's backing CALayers.
Source/WebKit/mac:
- WebView/WebFullScreenController.mm:
(-[WebFullScreenController _swapView:with:]):
Source/WebKit2:
- UIProcess/mac/WKFullScreenWindowController.mm:
(-[WKFullScreenWindowController _swapView:with:]):
- 2:51 PM Changeset in webkit [114566] by
-
- 2 edits in trunk/Source/WebCore
Prevent potential null pointer dereference in CSSStyleSelector::applyProperty().
https://bugs.webkit.org/show_bug.cgi?id=84267
Reviewed by Kentaro Hara.
No new tests / code cleanup found via static analysis.
- css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::collectMatchingRulesForList):
- 2:45 PM Changeset in webkit [114565] by
-
- 2 edits in trunk/Source/JavaScriptCore
JavaScriptCore.gypi not current
https://bugs.webkit.org/show_bug.cgi?id=84224
Patch by Don Olmstead <don.olmstead@am.sony.com> on 2012-04-18
Reviewed by Eric Seidel.
Updated JavaScriptCore.gypi to contain the latest sources. Removed os-win32 as it wasn't used. Also removed references to ICU files in the gypi file as ICU is most likely specified by the port itself.
Private and public header files were determined by looking at copy-files.cmd within Apple's Visual Studio directory.
- JavaScriptCore.gypi:
- 2:34 PM Changeset in webkit [114564] by
-
- 12 edits1 copy1 add in releases/WebKitGTK/webkit-1.8
[Soup] DNS prefetching spams resolver, shoots self in the foot
https://bugs.webkit.org/show_bug.cgi?id=41630
Reviewed by Martin Robinson.
.:
Bump libsoup and glib dependencies.
- Source/cmake/OptionsEfl.cmake:
- configure.ac:
Source/WebCore:
Added generic DNSResolveQueue class to throttle DNS
prefetches. It's an abstract refactoring of CFNET's
DNSResolveQueue. Platform specific methods implemented for soup
and CFNET backends.
No new tests required as we're just refactoring existing code to
be used by two different ports.
- CMakeLists.txt: added new file.
- GNUmakefile.list.am: ditto.
- WebCore.vcproj/WebCore.vcproj: ditto.
- WebCore.xcodeproj/project.pbxproj: ditto.
- platform/network/DNSResolveQueue.cpp: Added.
(WebCore):
(WebCore::DNSResolveQueue::add): adds a new host to be prefetched.
(WebCore::DNSResolveQueue::fired): by using a delay we coalesce
several prefetch requests and try to resolve them all here.
- platform/network/DNSResolveQueue.h: Added.
(WebCore):
(DNSResolveQueue): class that implements DNS prefetch
throttling using a template pattern.
(WebCore::DNSResolveQueue::shared):
(WebCore::DNSResolveQueue::decrementRequestCount):
- platform/network/cf/DNSCFNet.cpp:
(WebCore::DNSResolveQueue::platformProxyIsEnabledInSystemPreferences):
(WebCore::DNSResolveQueue::platformResolve):
- platform/network/soup/DNSSoup.cpp:
(WebCore):
(WebCore::DNSResolveQueue::platformProxyIsEnabledInSystemPreferences):
(WebCore::resolvedCallback):
(WebCore::DNSResolveQueue::platformResolve):
(WebCore::prefetchDNS):
Tools:
Bump libsoup and glib dependencies.
- efl/jhbuild.modules:
- gtk/jhbuild.modules:
Conflicts:
Tools/efl/jhbuild.modules
- 2:34 PM Changeset in webkit [114563] by
-
- 2 edits in releases/WebKitGTK/webkit-1.8/Source/WebCore
Build error: DNSSoup.cpp:30: fatal error: CString.h: No such file or
directory
https://bugs.webkit.org/show_bug.cgi?id=81093
Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-03-14
Reviewed by Philippe Normand.
Fix build error introduced by r110669.
- platform/network/soup/DNSSoup.cpp:
- 2:34 PM Changeset in webkit [114562] by
-
- 11 edits1 copy in releases/WebKitGTK/webkit-1.8/Source/WebCore
[GTK] Use the same DNS prefetching path than the other ports.
https://bugs.webkit.org/show_bug.cgi?id=80997
Reviewed by Martin Robinson.
This patch basically reverts r56128. There is no need to add an
special code path for GTK+ DNS pre-fetching because the main
reason to do that (some potential changes in libsoup) is not
going to happen. It also reduces the amount of DNS queries by
adding a NULL hostname check.
No need for new tests as this just moves code around.
- GNUmakefile.list.am:
- html/HTMLAnchorElement.cpp:
(WebCore::HTMLAnchorElement::parseAttribute):
- html/HTMLLinkElement.cpp:
- loader/LinkLoader.cpp:
(WebCore::LinkLoader::loadLink):
- page/Chrome.cpp:
(WebCore::Chrome::mouseDidMoveOverElement):
- platform/network/DNS.h:
(WebCore):
- platform/network/ResourceHandle.cpp:
- platform/network/ResourceHandle.h:
(ResourceHandle):
- platform/network/chromium/DNSChromium.cpp:
- platform/network/soup/DNSSoup.cpp: restored.
(WebCore):
(WebCore::prefetchDNS):
- platform/network/soup/ResourceHandleSoup.cpp:
- 2:33 PM WebKitGTK/1.8.x edited by
- (diff)
- 2:27 PM April 2012 Meeting edited by
- (diff)
- 2:26 PM Changeset in webkit [114561] by
-
- 2 edits in trunk/Source/WebKit/chromium
Chromium compile of WebDatabase.cpp fails without SQL_DATABASE
https://bugs.webkit.org/show_bug.cgi?id=84212
Patch by Myles Maxfield <mmaxfield@google.com> on 2012-04-18
Reviewed by Kentaro Hara.
- src/WebDatabase.cpp:
(WebCore::AbstractDatabase::isSyncDatabase):
- 2:21 PM Changeset in webkit [114560] by
-
- 2 edits in trunk/Source/WebCore
Prevent switch case fallthrough in StylePropertySet::getPropertyValue().
https://bugs.webkit.org/show_bug.cgi?id=84266
Reviewed by Kentaro Hara.
No new tests / code cleanup found by static analysis.
- css/StylePropertySet.cpp:
(WebCore::StylePropertySet::getPropertyValue):
- 2:04 PM Changeset in webkit [114559] by
-
- 5 edits in trunk/Tools
nrwt: support additional test expectations files
https://bugs.webkit.org/show_bug.cgi?id=84222
Reviewed by Ojan Vafai.
This patch adds an --additional-expectations flag that can be
used to point to more files that will override the default set
of expectations. This will allow us to remove the
'google_chrome' ports and eventually help to clean up override
handling in the chromium ports and unify expectations files and
Skipped files; this can also be used to specify overrides for
tests that run differently on a given machine.
- Scripts/webkitpy/layout_tests/port/base.py:
(Port.test_expectations_overrides):
- Scripts/webkitpy/layout_tests/port/chromium.py:
(ChromiumPort.test_expectations_overrides):
- Scripts/webkitpy/layout_tests/run_webkit_tests.py:
(parse_args):
- Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
(MainTest.test_additional_expectations):
- 2:01 PM Changeset in webkit [114558] by
-
- 3 edits in trunk/Source/WebCore
CSSValuePool: Make numeric value caches fixed-size arrays.
<http://webkit.org/b/84268>
Reviewed by Antti Koivisto.
Change the numeric CSSPrimitiveValue caches in CSSValuePool from HashMaps to
fixed-size arrays of RefPtr<CSSPrimitiveValue>s.
This is more space efficient and doesn't incur the cost of a hash lookup every
time a numeric CSSPrimitiveValue is needed. We retain the limit of caching
only values between 0-255 for now.
- css/CSSValuePool.cpp:
(WebCore::CSSValuePool::CSSValuePool):
(WebCore::CSSValuePool::createValue):
- css/CSSValuePool.h:
(CSSValuePool):
- 1:53 PM Changeset in webkit [114557] by
-
- 2 edits in trunk/Source/WebCore
[chromium] Rename overdraw histograms so we can use field trials in histograms.xml
https://bugs.webkit.org/show_bug.cgi?id=83500
Reviewed by James Robinson.
- platform/graphics/chromium/cc/CCOverdrawMetrics.cpp:
(WebCore::CCOverdrawMetrics::recordMetricsInternal):
- 1:52 PM Changeset in webkit [114556] by
-
- 528 edits14 copies1 delete in branches/subpixellayout
Merge trunk changes up until 114550 into subpixel branch.
- 1:47 PM Changeset in webkit [114555] by
-
- 2 edits in trunk/Tools
Lion Production Test failing with error: "Failed to stop httpd: pid file still exists" https://bugs.webkit.org/show_bug.cgi?id=84177
Reviewed by Dirk Pranke.
Try to delete the pid file left by Apache in the case it was killed forcefully.
- Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
(LayoutTestApacheHttpd._stop_running_server):
- 1:46 PM Changeset in webkit [114554] by
-
- 17 edits2 adds in branches/dfgopt/Source/JavaScriptCore
DFG should have constant propagation
https://bugs.webkit.org/show_bug.cgi?id=84004
Reviewed by Gavin Barraclough.
Changes AbstractValue to be able to hold a "set" of constants, where
the maximum set size is 1 - so merging a value containing constant A
with another value containing constant B where A != B will result in
the AbstractValue claiming that it does not know any constants (i.e.
it'll just have a predicted type and possible a structure).
Added a constant folding phase that uses this new information to
replace pure operations known to have constant results with
JSConstants. This is OSR-exit-aware, in that it will prepend a Phantom
that refers to all of the kids of the node we replaced.
- CMakeLists.txt:
- GNUmakefile.list.am:
- JavaScriptCore.xcodeproj/project.pbxproj:
- Target.pri:
- dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::beginBasicBlock):
(JSC::DFG::AbstractState::endBasicBlock):
(JSC::DFG::AbstractState::execute):
- dfg/DFGAbstractState.h:
(AbstractState):
- dfg/DFGAbstractValue.h:
(JSC::DFG::AbstractValue::clear):
(JSC::DFG::AbstractValue::isClear):
(JSC::DFG::AbstractValue::makeTop):
(JSC::DFG::AbstractValue::clobberValue):
(AbstractValue):
(JSC::DFG::AbstractValue::valueIsTop):
(JSC::DFG::AbstractValue::value):
(JSC::DFG::AbstractValue::set):
(JSC::DFG::AbstractValue::operator==):
(JSC::DFG::AbstractValue::merge):
(JSC::DFG::AbstractValue::filter):
(JSC::DFG::AbstractValue::validate):
(JSC::DFG::AbstractValue::checkConsistency):
(JSC::DFG::AbstractValue::dump):
- dfg/DFGAdjacencyList.h:
(JSC::DFG::AdjacencyList::initialize):
(AdjacencyList):
(JSC::DFG::AdjacencyList::reset):
- dfg/DFGBasicBlock.h:
(JSC::DFG::BasicBlock::BasicBlock):
(BasicBlock):
- dfg/DFGCSEPhase.cpp:
(JSC::DFG::CSEPhase::constantCSE):
(CSEPhase):
(JSC::DFG::CSEPhase::performNodeCSE):
- dfg/DFGConstantFoldingPhase.cpp: Added.
(DFG):
(ConstantFoldingPhase):
(JSC::DFG::ConstantFoldingPhase::ConstantFoldingPhase):
(JSC::DFG::ConstantFoldingPhase::run):
(JSC::DFG::performConstantFolding):
- dfg/DFGConstantFoldingPhase.h: Added.
(DFG):
- dfg/DFGDriver.cpp:
(JSC::DFG::compile):
- dfg/DFGGraph.h:
(Graph):
(JSC::DFG::Graph::convertToConstant):
- dfg/DFGInsertionSet.h:
(JSC::DFG::InsertionSet::execute):
- dfg/DFGNode.h:
(JSC::DFG::Node::convertToConstant):
(Node):
- runtime/JSValue.cpp:
(JSC::JSValue::description):
- runtime/JSValue.h:
(JSValue):
- 1:37 PM Changeset in webkit [114553] by
-
- 1 edit2 adds in branches/dfgopt/Source/JavaScriptCore
Unreviewed, adding files that I forgot to add in http://trac.webkit.org/changeset/114472
- dfg/DFGSilentRegisterSavePlan.h: Added.
(DFG):
(SilentRegisterSavePlan):
(JSC::DFG::SilentRegisterSavePlan::SilentRegisterSavePlan):
(JSC::DFG::SilentRegisterSavePlan::spillAction):
(JSC::DFG::SilentRegisterSavePlan::fillAction):
(JSC::DFG::SilentRegisterSavePlan::nodeIndex):
(JSC::DFG::SilentRegisterSavePlan::gpr):
(JSC::DFG::SilentRegisterSavePlan::fpr):
- dfg/DFGSlowPathGenerator.h: Added.
(DFG):
(SlowPathGenerator):
(JSC::DFG::SlowPathGenerator::SlowPathGenerator):
(JSC::DFG::SlowPathGenerator::~SlowPathGenerator):
(JSC::DFG::SlowPathGenerator::generate):
(JSC::DFG::SlowPathGenerator::label):
(JSC::DFG::SlowPathGenerator::call):
(JumpingSlowPathGenerator):
(JSC::DFG::JumpingSlowPathGenerator::JumpingSlowPathGenerator):
(JSC::DFG::JumpingSlowPathGenerator::linkFrom):
(JSC::DFG::JumpingSlowPathGenerator::jumpTo):
(CallSlowPathGenerator):
(JSC::DFG::CallSlowPathGenerator::CallSlowPathGenerator):
(JSC::DFG::CallSlowPathGenerator::call):
(JSC::DFG::CallSlowPathGenerator::setUp):
(JSC::DFG::CallSlowPathGenerator::recordCall):
(JSC::DFG::CallSlowPathGenerator::tearDown):
(CallResultAndNoArgumentsSlowPathGenerator):
(JSC::DFG::CallResultAndNoArgumentsSlowPathGenerator::CallResultAndNoArgumentsSlowPathGenerator):
(JSC::DFG::CallResultAndNoArgumentsSlowPathGenerator::generateInternal):
(CallResultAndOneArgumentSlowPathGenerator):
(JSC::DFG::CallResultAndOneArgumentSlowPathGenerator::CallResultAndOneArgumentSlowPathGenerator):
(JSC::DFG::CallResultAndOneArgumentSlowPathGenerator::generateInternal):
(CallResultAndTwoArgumentsSlowPathGenerator):
(JSC::DFG::CallResultAndTwoArgumentsSlowPathGenerator::CallResultAndTwoArgumentsSlowPathGenerator):
(JSC::DFG::CallResultAndTwoArgumentsSlowPathGenerator::generateInternal):
(CallResultAndThreeArgumentsSlowPathGenerator):
(JSC::DFG::CallResultAndThreeArgumentsSlowPathGenerator::CallResultAndThreeArgumentsSlowPathGenerator):
(JSC::DFG::CallResultAndThreeArgumentsSlowPathGenerator::generateInternal):
(CallResultAndFourArgumentsSlowPathGenerator):
(JSC::DFG::CallResultAndFourArgumentsSlowPathGenerator::CallResultAndFourArgumentsSlowPathGenerator):
(JSC::DFG::CallResultAndFourArgumentsSlowPathGenerator::generateInternal):
(CallResultAndFiveArgumentsSlowPathGenerator):
(JSC::DFG::CallResultAndFiveArgumentsSlowPathGenerator::CallResultAndFiveArgumentsSlowPathGenerator):
(JSC::DFG::CallResultAndFiveArgumentsSlowPathGenerator::generateInternal):
(JSC::DFG::slowPathCall):
(AssigningSlowPathGenerator):
(JSC::DFG::AssigningSlowPathGenerator::AssigningSlowPathGenerator):
(JSC::DFG::AssigningSlowPathGenerator::generateInternal):
(JSC::DFG::slowPathMove):
- 1:34 PM Changeset in webkit [114552] by
-
- 3 edits in trunk/Source/WebCore
[Chromium] Solid color shader should use premultiplied alpha.
https://bugs.webkit.org/show_bug.cgi?id=84215
Patch by David Reveman <reveman@chromium.org> on 2012-04-18
Reviewed by Adrienne Walker.
For efficiency and consistency, expect premultiplied alpha in
solid color shader.
- platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::drawDebugBorderQuad):
(WebCore::LayerRendererChromium::drawSolidColorQuad):
- platform/graphics/chromium/ShaderChromium.cpp:
(WebCore::FragmentShaderColor::getShaderString):
- 1:23 PM Changeset in webkit [114551] by
-
- 9 edits in trunk/Source
[WK2] Sandbox violations prevent attaching files to gmail messages
https://bugs.webkit.org/show_bug.cgi?id=84263
<rdar://problem/11248260>
Reviewed by Oliver Hunt.
- page/DragActions.h: Removed the newly added upload action. We cannot know if or when an upload is going to happen - a drop even listener can always get a reference to a File object, and upload it with XMLHttpRequest.
- page/DragController.cpp: (WebCore::DragController::concludeEditDrag): Removed a separate willPerformDragDestinationAction call for upload action - ther is nothing we'd want to only do when dropping on a file upload button.
- 1:13 PM LayoutUnit edited by
- (diff)
- 1:12 PM Changeset in webkit [114550] by
-
- 2 edits in branches/subpixellayout/Source
WebKit/win cleanup on branch.
- 1:08 PM Changeset in webkit [114549] by
-
- 3 edits in branches/subpixellayout/Source/WebCore/platform/graphics
Merging in r114548.
- 1:05 PM Changeset in webkit [114548] by
-
- 4 edits in trunk/Source/WebCore
GraphicsContextCG's roundToDevicePixels should round even when there's no transform
https://bugs.webkit.org/show_bug.cgi?id=84191
Reviewed by Eric Seidel.
When painting with the identify transform, the roundToDevicePixels function in GraphicsContextCG
does an early return that simply returns the FloatRect that was passed in. This proved to be a
problem in sub-pixel layout, as we wouldn't adjust the paint rect for text underline, and it could
end up being more than one pixel wide. Adding a roundedIntRect method on FloatRect for the simple
short-circuit case.
No new tests. No change in behavior before switching to sub-pixel layout.
- platform/graphics/FloatRect.cpp:
(WebCore::roundedIntRect):
- platform/graphics/FloatRect.h:
- platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::GraphicsContext::roundToDevicePixels):
- 12:53 PM Changeset in webkit [114547] by
-
- 5 edits in branches/safari-534.57-branch/Source
Versioning.
- 12:48 PM Changeset in webkit [114546] by
-
- 9 edits in trunk
Clean-up WheelEvent Conversion.
https://bugs.webkit.org/show_bug.cgi?id=84243
Source/WebKit/qt:
Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-04-18
Reviewed by Simon Hausmann.
- WebCoreSupport/WebEventConversion.cpp:
(WebCore::WebKitPlatformWheelEvent::applyDelta):
Source/WebKit2:
Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-04-18
Reviewed by Simon Hausmann.
- Shared/qt/WebEventFactoryQt.cpp:
(WebKit::WebEventFactory::createWebWheelEvent):
- UIProcess/qt/QtViewportInteractionEngine.cpp:
(WebKit::QtViewportInteractionEngine::wheelEvent):
Tools:
Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-04-18
Reviewed by Simon Hausmann.
Calculate proper wheel-delta from pixel-delta given.
- DumpRenderTree/qt/EventSenderQt.cpp:
(EventSender::EventSender):
(EventSender::mouseScrollBy):
(EventSender::continuousMouseScrollBy):
LayoutTests:
Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-04-18
Reviewed by Simon Hausmann.
- platform/qt/fast/events/continuous-platform-wheelevent-in-scrolling-div-expected.txt:
- 12:32 PM Changeset in webkit [114545] by
-
- 10 edits in trunk
[chromium] Turn on ENABLE_DATALIST for chromium
https://bugs.webkit.org/show_bug.cgi?id=84118
Reviewed by Kent Tamura.
Source/WebCore:
- html/HTMLDataListElement.cpp: Touched to avoid build issues. No code change.
- html/HTMLDataListElement.h: Ditto.
- html/HTMLInputElement.cpp: Ditto.
- html/HTMLInputElement.h: Ditto.
Source/WebKit/chromium:
- features.gypi: Turn on ENABLE_DATALIST.
- src/WebInputElement.cpp: Touched to avoid build issues. No code change.
LayoutTests:
- platform/chromium/fast/forms/label/labelable-elements-expected.txt: Update expectated result.
- 12:25 PM SelectiveTestEWS edited by
- (diff)
- 12:19 PM Changeset in webkit [114544] by
-
- 1 edit1 delete in trunk/Source/WebCore
[Qt] WheelEventQt.cpp should be deleted.
https://bugs.webkit.org/show_bug.cgi?id=84237
Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-04-18
Reviewed by Simon Hausmann.
- platform/qt/WheelEventQt.cpp: Removed.
- 12:14 PM SelectiveTestBuildBot edited by
- (diff)
- 11:58 AM Changeset in webkit [114543] by
-
- 22 edits4 adds in trunk/LayoutTests
[EFL][DRT] Update baselines after font-face support was fixed
https://bugs.webkit.org/show_bug.cgi?id=84234
Unreviewed, EFL gardening.
Fixing baselines for css/font-face* tests and tests affected
by working @font-face. A bunch of table/* rebaselines will
follow in a separate batch.
Patch by Dominik Röttsches <dominik.rottsches@linux.intel.com> on 2012-04-18
- platform/efl/fast/css/beforeSelectorOnCodeElement-expected.png:
- platform/efl/fast/css/font-face-default-font-expected.png:
- platform/efl/fast/css/font-face-in-media-rule-expected.png:
- platform/efl/fast/css/font-face-multiple-faces-expected.png:
- platform/efl/fast/css/font-face-multiple-faces-expected.txt:
- platform/efl/fast/css/font-face-opentype-expected.png:
- platform/efl/fast/css/font-face-opentype-expected.txt:
- platform/efl/fast/css/font-face-remote-expected.png:
- platform/efl/fast/css/font-face-remote-expected.txt:
- platform/efl/fast/css/font-face-synthetic-bold-italic-expected.png: Added.
- platform/efl/fast/css/font-face-synthetic-bold-italic-expected.txt: Added.
- platform/efl/fast/css/font-face-unicode-range-expected.png:
- platform/efl/fast/css/font-face-unicode-range-expected.txt:
- platform/efl/fast/css/font-face-weight-matching-expected.png: Added.
- platform/efl/fast/css/font-face-weight-matching-expected.txt: Added.
- platform/efl/fast/css/font-face-woff-expected.png:
- platform/efl/fast/css/font-face-woff-expected.txt:
- platform/efl/fast/css/rtl-ordering-expected.txt:
- platform/efl/fast/css/text-security-expected.txt:
- platform/efl/fast/events/updateLayoutForHitTest-expected.png:
- platform/efl/fast/writing-mode/broken-ideograph-small-caps-expected.png:
- platform/efl/fast/writing-mode/broken-ideograph-small-caps-expected.txt:
- platform/efl/fast/writing-mode/broken-ideographic-font-expected.png:
- platform/efl/fast/writing-mode/broken-ideographic-font-expected.txt:
- platform/efl/test_expectations.txt:
- 11:54 AM Changeset in webkit [114542] by
-
- 1109 edits236 copies123 deletes in branches/subpixellayout
Merge trunk changes up until 114521 into subpixel branch.
- 11:46 AM Changeset in webkit [114541] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed. Adding FIXME comment to FractionalLayoutUnit explaining the lack of size_t operators.
- platform/FractionalLayoutUnit.h:
(FractionalLayoutUnit):
- 11:40 AM Changeset in webkit [114540] by
-
- 2 edits5 adds in trunk/LayoutTests
IDB: Pending setVersion call in worker prevents document from opening the db, even after worker termination
https://bugs.webkit.org/show_bug.cgi?id=83952
These two tests fail in DRT most proximately because DRT provides
different instances of IDBFactoryBackend to a document and worker:
https://bugs.webkit.org/show_bug.cgi?id=82776.
One fails in chromium because of a logic error tracked by
http://crbug.com/123418. The plan is to run them both as browser tests
when the logic is fixed, but just one in the meantime.
Also added SKIP for storage/indexeddb/dont-commit-on-blocked.html
since it also can't pass in DRT and just turns the flakiness dashboard
all red.
Reviewed by Ojan Vafai.
- platform/chromium/test_expectations.txt:
- storage/indexeddb/pending-version-change-stuck-expected.txt: Added.
- storage/indexeddb/pending-version-change-stuck-works-with-terminate-expected.txt: Added.
- storage/indexeddb/pending-version-change-stuck-works-with-terminate.html: Added.
- storage/indexeddb/pending-version-change-stuck.html: Added.
- storage/indexeddb/resources/pending-version-change-stuck.js: Added.
(test.request.onsuccess.request.onblocked):
(test.request.onsuccess):
(test):
- 11:36 AM Changeset in webkit [114539] by
-
- 7 edits in trunk/Source
Remove m_subclassData from JSArray, move the attribute to subclass as needed
https://bugs.webkit.org/show_bug.cgi?id=84249
Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-04-18
Reviewed by Geoffrey Garen.
Source/JavaScriptCore:
JSArray's m_subclassData is only used by WebCore's RuntimeArray. This patch moves
the attribute to RuntimeArray to avoid allocating memory for the pointer in the common
case.
This gives ~1% improvement in JSArray creation microbenchmark thanks to fewer allocations
of CopiedSpace.
- jit/JITInlineMethods.h:
(JSC::JIT::emitAllocateJSArray):
- runtime/JSArray.cpp:
(JSC::JSArray::JSArray):
- runtime/JSArray.h:
Source/WebCore:
- bridge/runtime_array.cpp:
(JSC::RuntimeArray::RuntimeArray):
(JSC::RuntimeArray::finishCreation):
- bridge/runtime_array.h:
(JSC::RuntimeArray::getLength):
(JSC::RuntimeArray::getConcreteArray):
(RuntimeArray):
- 11:34 AM Changeset in webkit [114538] by
-
- 7 edits in trunk
matchMedia() MediaQueryList not updating
https://bugs.webkit.org/show_bug.cgi?id=75903
Patch by Luiz Agostini <luiz.agostini@palm.com> on 2012-04-18
Reviewed by Antti Koivisto.
Source/WebCore:
Test: fast/media/media-query-list-08.html
Viewport related MediaQueryList listeners were not triggered and the value
of matches were not updated if the document's style selector were not
affected by viewport changes.
The new method evaluateMediaQueries() is now called by FrameView instead of
styleSelectorChanged() if the style selector is not affected by viewport changes.
- dom/Document.cpp:
(WebCore::Document::evaluateMediaQueries):
(WebCore):
(WebCore::Document::styleSelectorChanged):
- dom/Document.h:
(Document):
- page/FrameView.cpp:
(WebCore::FrameView::layout):
LayoutTests:
Testing MediaQueryLists listeners related to viewport changes.
- fast/media/media-query-list-08-expected.txt: Added.
- fast/media/media-query-list-08.html: Added.
Skipping the new test in Mac and Qt due to an issue in its DumpRenderTree.
- platform/qt/Skipped:
- platform/mac/Skipped:
- 11:31 AM Changeset in webkit [114537] by
-
- 4 edits in trunk/Source/WebCore
Use explicit casts for size_t to unsigned conversion
https://bugs.webkit.org/show_bug.cgi?id=83602
Reviewed by Eric Seidel.
No new tests, no change in functinality.
Not all platforms have implicit casts from size_t to unsigned and we
can't add size_t versions of the operators to FractionalLayoutUnit for
all platforms as it would conflict with the unsigned versions of same.
Change support methods to take unsigned instead of size_t and use
explicit casts when multiplying or dividing a FractionalLayoutUnit with
a size_t and the other way around.
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::adjustForColumns):
- rendering/RenderFlexibleBox.cpp:
(WebCore::initialPackingOffset):
(WebCore::packingSpaceBetweenChildren):
(WebCore::initialLinePackingOffset):
(WebCore::linePackingSpaceBetweenChildren):
(WebCore::RenderFlexibleBox::packFlexLines):
- rendering/RenderFrameSet.cpp:
(WebCore::RenderFrameSet::layout):
- 11:31 AM Changeset in webkit [114536] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, GTK test_expectations update.
- platform/gtk/test_expectations.txt: Skip some failing tests and
mark 3 more frame flattening tests flaky.
- 11:14 AM Changeset in webkit [114535] by
-
- 5 edits in trunk
Source/WebCore: Web Inspector: [Chromium] Module's require injects scripts before the debug id is set to the context.
https://bugs.webkit.org/show_bug.cgi?id=84166
Re-applying r114497.
- bindings/v8/V8IsolatedContext.cpp:
(WebCore::setInjectedScriptContextDebugId):
(WebCore):
(WebCore::V8IsolatedContext::V8IsolatedContext):
- bindings/v8/V8Proxy.cpp:
(WebCore::V8Proxy::evaluateInIsolatedWorld):
- bindings/v8/V8Proxy.h:
(V8Proxy):
LayoutTests: Unreviewed, rolling out r114506.
http://trac.webkit.org/changeset/114506
https://bugs.webkit.org/show_bug.cgi?id=84254
Seems to be making gtk's DumpRenderTree crash occasionally
(Requested by tomz on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-18
- platform/gtk/test_expectations.txt:
- 11:06 AM Changeset in webkit [114534] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed, trying to fix QT build.
It was using a FilterEffectRenderer::prepare that changed to allocateBackingStoreIfNeeded in 114529.
- platform/graphics/texmap/TextureMapperImageBuffer.cpp:
(WebCore::BitmapTextureImageBuffer::applyFilters):
- 11:03 AM Changeset in webkit [114533] by
-
- 7 edits5 adds in trunk/LayoutTests
[chromium] Unreviewed, rebaseline compositing tests after r114283.
https://bugs.webkit.org/show_bug.cgi?id=84083
- platform/chromium-linux/compositing/overflow/overflow-positioning-expected.png:
- platform/chromium-mac-leopard/compositing/overflow/overflow-positioning-expected.png: Added.
- platform/chromium-mac-snowleopard/compositing/overflow/overflow-positioning-expected.png:
- platform/chromium-mac/compositing/overflow/overflow-positioning-expected.png:
- platform/chromium-win/compositing/backing/no-backing-for-clip-expected.txt: Added.
- platform/chromium-win/compositing/backing/no-backing-for-clip-overlap-expected.txt: Added.
- platform/chromium-win/compositing/backing/no-backing-for-perspective-expected.txt: Added.
- platform/chromium-win/compositing/geometry/preserve-3d-switching-expected.txt:
- platform/chromium-win/compositing/overflow/overflow-positioning-expected.png:
- platform/chromium/test_expectations.txt:
- 11:01 AM Changeset in webkit [114532] by
-
- 3 edits in trunk/Source/WebCore
Web Inspector: extract script navigator overlay logic into the scripts navigator controller.
https://bugs.webkit.org/show_bug.cgi?id=84244
Reviewed by Vsevolod Vlasov.
Overlay logic is well separable from the scripts panel and does not belong there.
Extracting it into a separate class.
- inspector/front-end/ScriptsNavigator.js:
(WebInspector.ScriptsNavigatorController.prototype.wasShown):
(WebInspector.ScriptsNavigatorController.prototype._createNavigatorControlButton):
(WebInspector.ScriptsNavigatorController.prototype._escDownWhileNavigatorOverlayOpen):
(WebInspector.ScriptsNavigatorController.prototype._toggleNavigator):
(WebInspector.ScriptsNavigatorController.prototype._hidePinnedNavigator):
(WebInspector.ScriptsNavigatorController.prototype.set _pinNavigator):
(WebInspector.ScriptsNavigatorController.prototype.set showNavigatorOverlay):
(WebInspector.ScriptsNavigatorController.prototype.hideNavigatorOverlay):
(WebInspector.ScriptsNavigatorController.prototype._navigatorOverlayWasShown):
- inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype.wasShown):
(WebInspector.ScriptsPanel.prototype._editorClosed):
(WebInspector.ScriptsPanel.prototype._editorSelected):
(WebInspector.ScriptsPanel.prototype._scriptSelected):
- 11:01 AM Changeset in webkit [114531] by
-
- 8 edits in trunk
Unreviewed, rolling out r114506.
http://trac.webkit.org/changeset/114506
https://bugs.webkit.org/show_bug.cgi?id=84254
Seems to be making gtk's DumpRenderTree crash occasionally
(Requested by tomz on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-18
Source/WebKit/gtk:
- webkit/webkitwebsettings.cpp:
(webkit_web_settings_class_init):
(webkit_web_settings_set_property):
(webkit_web_settings_get_property):
- webkit/webkitwebsettingsprivate.h:
- webkit/webkitwebview.cpp:
(webkit_web_view_update_settings):
(webkit_web_view_settings_notify):
Tools:
- DumpRenderTree/gtk/DumpRenderTree.cpp:
(resetDefaultsToConsistentValues):
LayoutTests:
- platform/gtk/test_expectations.txt:
- 10:44 AM Changeset in webkit [114530] by
-
- 4 edits in trunk/Source/WebCore
Unreviewed, rolling out r114497.
http://trac.webkit.org/changeset/114497
https://bugs.webkit.org/show_bug.cgi?id=84253
Broke compile on Win, including stdio did not help (Requested
by dimich on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-18
- bindings/v8/V8IsolatedContext.cpp:
(WebCore::V8IsolatedContext::V8IsolatedContext):
- bindings/v8/V8Proxy.cpp:
(WebCore::V8Proxy::evaluateInIsolatedWorld):
(WebCore::V8Proxy::setInjectedScriptContextDebugId):
(WebCore):
- bindings/v8/V8Proxy.h:
(V8Proxy):
- 10:37 AM Changeset in webkit [114529] by
-
- 4 edits in trunk/Source/WebCore
[CSS Filters] Drop-shadow and blur can avoid using full source image
https://bugs.webkit.org/show_bug.cgi?id=81263
Reviewed by Dean Jackson.
Instead of using the full bounding box of the RenderLayer we now compute the exact rectangle that is needed to
compute filter inside the dirty rectangle on screen. That's easy to calculate by reversing the filter outsets.
Even if the element is completely offscreen, but its shadow is in the viewport, we can still compute the source
rectangle that needs to be drawn in order to update the shadow correctly.
No new tests, this change doesn't have visible results and the functionality should
already be covered by previous filter tests.
- rendering/FilterEffectRenderer.cpp:
(WebCore::FilterEffectRenderer::FilterEffectRenderer):
(WebCore::FilterEffectRenderer::build): Save the outsets of the filters, so that we can use them in computeSourceImageRectForDirtyRect.
(WebCore::FilterEffectRenderer::updateBackingStoreRect): Only allocate a new source image if the size of the source rectangle changed.
(WebCore::FilterEffectRenderer::allocateBackingStoreIfNeeded): There's no need to call clearIntermediateResults() in this function. We do that after
the filter is computed.
(WebCore::FilterEffectRenderer::computeSourceImageRectForDirtyRect):
(WebCore):
(WebCore::FilterEffectRendererHelper::prepareFilterEffect):
(WebCore::FilterEffectRendererHelper::beginFilterEffect):
- rendering/FilterEffectRenderer.h:
(FilterEffectRendererHelper):
(WebCore::FilterEffectRendererHelper::repaintRect):
(FilterEffectRenderer):
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::paintLayerContents):
- 10:23 AM Changeset in webkit [114528] by
-
- 2 edits in releases/WebKitGTK/webkit-1.8/Source/WebKit/gtk
[GTK] Enable back double buffering on WebKitWebView to fix flickering
https://bugs.webkit.org/show_bug.cgi?id=84149
Patch by Carlos Garnacho <carlos@lanedo.com> on 2012-04-17
Reviewed by Martin Robinson.
Despite having WebKitWebView its own backing buffer, calling
gtk_widget_set_double_buffered(...,FALSE) may still pose side
effects, such as ensuring that all drawing operations are
flushed to the X server before rendering a non-double buffered
widget, which may translate into flickering of the parent
GdkWindow before the WebKitWebView itself is rendered.
Enabling back double buffering solves this as all contents are
first composited together before getting to the front buffer,
but effectively acts as 3rd buffer. This is sort of unavoidable
unless GTK+ gains a "let me take ownership of the backing buffer
for this widget", which currently lacks.
- webkit/webkitwebview.cpp:
(webkit_web_view_init): Remove call to gtk_widget_set_double_buffered(..., FALSE)
- 10:23 AM Changeset in webkit [114527] by
-
- 4 edits2 adds in releases/WebKitGTK/webkit-1.8
[soup] Crash while loading http://www.jusco.cn
https://bugs.webkit.org/show_bug.cgi?id=68238
Patch by Martin Robinson <mrobinson@igalia.com> on 2012-04-09
Reviewed by Philippe Normand.
.:
- configure.ac: Bumped the libsoup dependency to 2.37.90.
Source/WebCore:
Test: http/tests/xmlhttprequest/xmlhttprequest-sync-no-timers.html
When running synchronous XMLHttpRequests, push a new inner thread default
context, so that other sources from timers and network activity do not run.
This will make synchronous requests truly synchronous with the rest of
WebCore.
- platform/network/soup/ResourceHandleSoup.cpp:
(WebCoreSynchronousLoader): Clean up the method definitions a bit by writing them inline.
(WebCore::WebCoreSynchronousLoader::WebCoreSynchronousLoader): Push a new thread default
context to prevent other sources from running.
(WebCore::WebCoreSynchronousLoader::~WebCoreSynchronousLoader): Pop the inner thread default context.
(WebCore::closeCallback): If the client is synchronous call didFinishLoading now.
(WebCore::readCallback): Only call didFinishLoading if the client isn't synchronous.
(WebCore::ResourceHandle::defaultSession): Activate use-thread-context so that the soup session
respects the inner thread context.
LayoutTests:
- http/tests/xmlhttprequest/xmlhttprequest-sync-no-timers-expected.txt: Added.
- http/tests/xmlhttprequest/xmlhttprequest-sync-no-timers.html: Added.
- 10:22 AM Changeset in webkit [114526] by
-
- 3 edits3 adds in releases/WebKitGTK/webkit-1.8
[GTK] Toggle buttons do not size appropriately in some themes
https://bugs.webkit.org/show_bug.cgi?id=82833
Patch by Martin Robinson <mrobinson@igalia.com> on 2012-04-09
Reviewed by Gustavo Noronha Silva.
Source/WebCore:
Test: platform/gtk/fast/forms/large-toggle-elements.html
Instead of drawing a toggle button across the entire rectangle of
the WebCore control, draw a default-sized one cenetered in the rectangle.
- platform/gtk/RenderThemeGtk3.cpp:
(WebCore::paintToggle): Draw default-sized toggles.
LayoutTests:
Add a test for this issue.
- platform/gtk/fast/forms/large-toggle-elements-expected.png: Added.
- platform/gtk/fast/forms/large-toggle-elements-expected.txt: Added.
- platform/gtk/fast/forms/large-toggle-elements.html: Added.
- 10:22 AM Changeset in webkit [114525] by
-
- 5 edits5 adds in releases/WebKitGTK/webkit-1.8
[GTK] Scrolling some iframes that are partially out of the viewport leads to repaint errors
https://bugs.webkit.org/show_bug.cgi?id=83309
Patch by Martin Robinson <mrobinson@igalia.com> on 2012-04-05
Reviewed by Gustavo Noronha Silva.
Source/WebCore:
Test: platform/gtk/fast/frames/scrolling-iframe-out-of-viewport.html
The X11 backing store was not properly trimming the scroll region when it
was only a portion of the screen. This was hidden by subsequent repaints.
- platform/gtk/GtkWidgetBackingStoreX11.cpp:
(WebCore::WidgetBackingStore::scroll): Fix the calculation of the scrolling region.
Source/WebKit/gtk:
Instead of only updating scrollRect - preservedRegion, update
scrollRect - (preservedRegion - offscreenPreservedRegion). This ensures that
when part of the scroll rect is moved onscreen from offscreen that part is
queued for a redraw.
- WebCoreSupport/ChromeClientGtk.cpp:
(WebKit::ChromeClient::scroll): Properly calculate the area to repaint.
LayoutTests:
Added a pixel test for this issue.
- platform/gtk/fast/frames/resources/scrolling-iframe-out-of-viewport-interior.html: Added.
- platform/gtk/fast/frames/scrolling-iframe-out-of-viewport-expected.png: Added.
- platform/gtk/fast/frames/scrolling-iframe-out-of-viewport-expected.txt: Added.
- platform/gtk/fast/frames/scrolling-iframe-out-of-viewport.html: Added.
- 10:22 AM WebKitGTK/1.8.x edited by
- (diff)
- 10:17 AM WebKitGTK/1.8.x edited by
- (diff)
- 10:17 AM Changeset in webkit [114524] by
-
- 2 edits in releases/WebKitGTK/webkit-1.8/Source/JavaScriptCore
SIGILL in JavaScriptCore on a Geode processor
https://bugs.webkit.org/show_bug.cgi?id=82496
Reviewed by Gavin Barraclough.
Don't attempt to use the DFG when SSE2 is not available.
- dfg/DFGCapabilities.cpp:
(JSC::DFG::canCompileOpcodes):
- 10:16 AM Changeset in webkit [114523] by
-
- 2 edits in trunk/Source/WebCore
[EFL][DRT] @font-face support fails on EFL
https://bugs.webkit.org/show_bug.cgi?id=83264
Patch by Dominik Röttsches <dominik.rottsches@linux.intel.com> on 2012-04-18
Reviewed by Dimitri Glazkov.
STORE_FONT_CUSTOM_PLATFORM_DATA was not defined for EFL.
Fixing that by removing a long standing FIXME with the intention
to turn the whitelist for this switch into a blacklist.
- loader/cache/CachedFont.cpp:
- 10:16 AM WebKitGTK/1.8.x edited by
- (diff)
- 10:15 AM Changeset in webkit [114522] by
-
- 2 edits in releases/WebKitGTK/webkit-1.8
[GTK] Respect NOCONFIGURE option in autogen.sh
https://bugs.webkit.org/show_bug.cgi?id=82447
Reviewed by Philippe Normand.
Make autogen.sh follow the new build-api for GNOME, see
http://people.gnome.org/~walters/docs/build-api.txt
- autogen.sh: respect the NOCONFIGURE environment flag, per the
new GNOME build-api.
- 10:07 AM Changeset in webkit [114521] by
-
- 2 edits in trunk/Source/JavaScriptCore
replaceUsingStringSearch: delay the creation of the replace string until needed
https://bugs.webkit.org/show_bug.cgi?id=83841
Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-04-18
Reviewed by Geoffrey Garen.
We do not need to obtain the replaceValue until we have a match. By moving the intialization
of replaceValue when needed, we save a few instructions when there is no match.
- runtime/StringPrototype.cpp:
(JSC::replaceUsingRegExpSearch):
(JSC::replaceUsingStringSearch):
(JSC::stringProtoFuncReplace):
- 10:05 AM Changeset in webkit [114520] by
-
- 13 edits in trunk/Source/WebCore
Convert ShadowData and DropShadowFilterOperation to use IntPoint
https://bugs.webkit.org/show_bug.cgi?id=84098
Reviewed by Eric Seidel.
Shadows do not flow with the page, so sub-pixel layout doesn't actually offer any benefit that
couldn't have been attained before that conversion. With that in mind, this patch reverts
drop shadow offsets to integers, but also cleans up the code by switching the x/y location pair
to be an IntPoint.
No new tests. No change in behavior.
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::valueForFilter):
- css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::collectMatchingRulesForList):
- css/SVGCSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applySVGProperty):
- page/animation/AnimationBase.cpp:
(WebCore::blendFunc):
(WebCore::shadowForBlending):
- platform/animation/AnimationUtilities.h:
(WebCore::blend): New blend function that operates on IntPoints.
(WebCore):
- platform/chromium/support/WebFilterOperations.cpp:
(WebKit::WebDropShadowFilterOperation):
- platform/graphics/filters/FilterOperation.cpp:
(WebCore::DropShadowFilterOperation::blend):
- platform/graphics/filters/FilterOperation.h:
(WebCore::DropShadowFilterOperation::clone):
(WebCore::DropShadowFilterOperation::x):
(WebCore::DropShadowFilterOperation::y):
(WebCore::DropShadowFilterOperation::location): Preserved the comment about lengths.
(WebCore::DropShadowFilterOperation::operator==):
(WebCore::DropShadowFilterOperation::DropShadowFilterOperation):
(DropShadowFilterOperation):
- rendering/RenderBoxModelObject.cpp:
(WebCore::areaCastingShadowInHole): Reverted to integers since this operates on the IntRect from
a RoundedRect.
(WebCore::RenderBoxModelObject::paintBoxShadow): Reduced the complexity and unnecessary conversion
between LayoutUnits and integers by using all integers after we calculate the pixel-snapped
RoundedRect that we use for painting.
- rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::getShadowExtent):
(WebCore::RenderStyle::getShadowHorizontalExtent):
(WebCore::RenderStyle::getShadowVerticalExtent):
- rendering/style/ShadowData.cpp:
(WebCore::ShadowData::ShadowData):
(WebCore::ShadowData::operator==):
(WebCore::calculateShadowExtent):
(WebCore::ShadowData::adjustRectForShadow):
- rendering/style/ShadowData.h:
(WebCore::ShadowData::ShadowData):
(WebCore::ShadowData::x):
(WebCore::ShadowData::y):
(WebCore::ShadowData::location):
(ShadowData):
- 9:53 AM Changeset in webkit [114519] by
-
- 18 edits in trunk/Source/WebCore
[V8] Add an optional Isolate argument to wrap()
https://bugs.webkit.org/show_bug.cgi?id=84202
Reviewed by Nate Chapin.
The final objective is to pass Isolate around in V8 bindings.
This patch adds an optional Isolate argument to wrap().
After rewriting all wrap() callers so that they pass Isolate
to wrap(), I'll make the Isolate argument non-optional.
No tests. No change in behavior.
- bindings/scripts/CodeGeneratorV8.pm: Modified as described above.
(GenerateHeader):
- bindings/v8/custom/V8DocumentCustom.cpp: Ditto.
(WebCore::toV8):
- bindings/v8/custom/V8HTMLDocumentCustom.cpp: Ditto.
(WebCore::toV8):
- bindings/v8/custom/V8NodeCustom.cpp: Ditto.
(WebCore::toV8Slow):
- bindings/v8/custom/V8SVGDocumentCustom.cpp: Ditto.
(WebCore::toV8):
- dom/make_names.pl: Ditto.
(printWrapperFactoryCppFile):
- bindings/scripts/test/V8/V8Float64Array.h:
Updated run-bindings-tests results.
(V8Float64Array):
(WebCore::V8Float64Array::wrap):
- bindings/scripts/test/V8/V8TestActiveDOMObject.h:
(V8TestActiveDOMObject):
(WebCore::V8TestActiveDOMObject::wrap):
(WebCore::toV8):
- bindings/scripts/test/V8/V8TestCustomNamedGetter.h:
(V8TestCustomNamedGetter):
(WebCore::V8TestCustomNamedGetter::wrap):
(WebCore::toV8):
- bindings/scripts/test/V8/V8TestEventConstructor.h:
(V8TestEventConstructor):
(WebCore::V8TestEventConstructor::wrap):
(WebCore::toV8):
- bindings/scripts/test/V8/V8TestEventTarget.h:
(V8TestEventTarget):
(WebCore::V8TestEventTarget::wrap):
(WebCore::toV8):
- bindings/scripts/test/V8/V8TestInterface.h:
(V8TestInterface):
(WebCore::V8TestInterface::wrap):
(WebCore::toV8):
- bindings/scripts/test/V8/V8TestMediaQueryListListener.h:
(V8TestMediaQueryListListener):
(WebCore::V8TestMediaQueryListListener::wrap):
(WebCore::toV8):
- bindings/scripts/test/V8/V8TestNamedConstructor.h:
(V8TestNamedConstructor):
(WebCore::V8TestNamedConstructor::wrap):
(WebCore::toV8):
- bindings/scripts/test/V8/V8TestNode.h:
(V8TestNode):
(WebCore::V8TestNode::wrap):
(WebCore::toV8):
- bindings/scripts/test/V8/V8TestObj.h:
(V8TestObj):
(WebCore::V8TestObj::wrap):
(WebCore::toV8):
- bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h:
(V8TestSerializedScriptValueInterface):
(WebCore::V8TestSerializedScriptValueInterface::wrap):
(WebCore::toV8):
- 9:34 AM Changeset in webkit [114518] by
-
- 3 edits in trunk/Source/WebCore
[CSS Filters] Do not use clipping rect when calculating the bounds of a layer
https://bugs.webkit.org/show_bug.cgi?id=83960
Reviewed by Simon Fraser.
The local clip rect should not be used when calculating the bounds of a filter area. Otherwise
drop-shadow might not know about the pixels outside the clipping rectangle, even though the actual shadow might
be inside it.
No new tests added in this patch, but this patch fixes two existing tests that fail.
LayoutTests/css3/filters/filter-repaint-shadow-clipped.html
LayoutTests/css3/filters/filter-repaint-shadow-rotated.html
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::paintLayerContents):
(WebCore::RenderLayer::calculateLayerBounds):
- rendering/RenderLayer.h:
- 9:33 AM Changeset in webkit [114517] by
-
- 1 copy in tags/Safari-534.57.2
New tag.
- 9:29 AM Changeset in webkit [114516] by
-
- 3 edits2 adds in releases/WebKitGTK/webkit-1.8
Merging r111263
- 9:29 AM Changeset in webkit [114515] by
-
- 11 edits3 adds in trunk/Source/WebCore
Followup to "Call incrementStatsCounter directly"
https://bugs.webkit.org/show_bug.cgi?id=83109
Reviewed by Kentaro Hara.
Now that incrementStatsCounter has been moved from
PlatformSupport.h to Platform.h, we need to be able to call it directly
from WebCore/bindings/v8/v8Proxy.h (for the INC_STATS macro). That
means we need a new StatsCounter class in WebCore/platform/ and an
implementation in
WebCore/platform/chromium/StatsCounterChromium.cpp. Other ports
are welcome to implement their own stats counters if they
wish. This pattern was based on the
HistogramSupport/HistogramSupportChromium classes.
- CMakeLists.txt:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- bindings/v8/V8Proxy.h:
- bindings/v8/custom/V8DedicatedWorkerContextCustom.cpp:
(WebCore::V8DedicatedWorkerContext::postMessageCallback):
(WebCore::V8DedicatedWorkerContext::webkitPostMessageCallback):
- bindings/v8/custom/V8NotificationCenterCustom.cpp:
(WebCore::V8NotificationCenter::createHTMLNotificationCallback):
(WebCore::V8NotificationCenter::createNotificationCallback):
(WebCore::V8NotificationCenter::requestPermissionCallback):
- bindings/v8/custom/V8WorkerContextCustom.cpp:
(WebCore::V8WorkerContext::importScriptsCallback):
(WebCore::V8WorkerContext::setTimeoutCallback):
(WebCore::V8WorkerContext::setIntervalCallback):
- platform/StatsCounter.cpp: Added.
(WebCore):
(WebCore::StatsCounter::incrementStatsCounter):
- platform/StatsCounter.h: Added.
(WebCore):
(StatsCounter):
- platform/chromium/StatsCounterChromium.cpp: Added.
(WebCore):
(WebCore::StatsCounter::incrementStatsCounter):
- 9:28 AM Changeset in webkit [114514] by
-
- 4 edits in branches/subpixellayout/Source/WebCore
Replace uses of size_t with unsigned in rendering code on branch.
- 9:25 AM Changeset in webkit [114513] by
-
- 5 edits in trunk/Source
[Chromium] REGRESSION: Popup shrinks because of autocomplete
https://bugs.webkit.org/show_bug.cgi?id=84139
http://code.google.com/p/chromium/issues/detail?id=123432
Source/WebCore:
Do not update the window rect on the wrong client but instead return the popup widget's
new screen coordinates from the refresh() method.
Reviewed by Kent Tamura.
- platform/chromium/PopupContainer.cpp:
(WebCore::PopupContainer::refresh):
- platform/chromium/PopupContainer.h:
(PopupContainer):
Source/WebKit/chromium:
Do not use the PopupContainer's frameRect() to update the popup client's window rect,
since PopupContainer is always positioned at (0, 0) inside the client's window rect,
and the latter one is positioned relative to the screen origin.
Reviewed by Kent Tamura.
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::refreshAutofillPopup):
- 9:20 AM Changeset in webkit [114512] by
-
- 3 edits2 adds in releases/WebKitGTK/webkit-1.8
Merging r110487
- 9:18 AM Changeset in webkit [114511] by
-
- 9 edits in trunk/Source/JavaScriptCore
GC activity timer should be tied to allocation, not collection
https://bugs.webkit.org/show_bug.cgi?id=83919
Reviewed by Geoffrey Garen.
- API/JSContextRef.cpp: Used the new didAbandonObjectGraph callback to indicate that now that we've
released a global object, we're abandoning a potentially large number of objects that JSC might want
to collect.
- heap/CopiedSpace.cpp:
(JSC::CopiedSpace::tryAllocateSlowCase): Added the call to timer's willAllocate function to indicate
that we've hit a slow path and are allocating now, so schedule the timer.
- heap/Heap.cpp:
(JSC::Heap::Heap):
(JSC::Heap::collectAllGarbage): Removed the call to discardAllCompiledCode because it was causing us to
throw away too much code during our benchmarks (especially vp8, which is very large and thus has large
amounts of compiled code).
(JSC::Heap::collect): Added the new call to didCollect at the conclusion of a collection so that we
can cancel the timer if we no longer need to run a collection. Also added a check at the beginning of a
collection to see if we should throw away our compiled code. Currently this is set to happen about once
every minute.
- heap/Heap.h: Added field to keep track of the last time we threw away our compiled code.
- heap/MarkedAllocator.cpp:
(JSC::MarkedAllocator::allocateSlowCase): Added call to willAllocate on the allocation slow path, just like
in CopiedSpace.
- runtime/GCActivityCallback.cpp: Added default stubs for non-CF platforms.
(JSC::DefaultGCActivityCallback::willAllocate):
(JSC):
(JSC::DefaultGCActivityCallback::didCollect):
(JSC::DefaultGCActivityCallback::didAbandonObjectGraph):
- runtime/GCActivityCallback.h: Added new functions to make JSC's GC timer less arcane. This includes replacing
the operator () with willAllocate() and adding an explicit didCollect() to cancel the timer after a collection
occurs rather than relying on the way the timer is invoked to cancel itself. Also added a callback for
when somebody else (e.g. WebCore or the JSC API) to notify JSC that they have just abandoned an entire graph of
objects and that JSC might want to clean them up.
(JSC::GCActivityCallback::~GCActivityCallback):
(JSC::GCActivityCallback::willAllocate):
(JSC::GCActivityCallback::didCollect):
(JSC::GCActivityCallback::didAbandonObjectGraph):
(JSC::GCActivityCallback::synchronize):
(DefaultGCActivityCallback):
- runtime/GCActivityCallbackCF.cpp: Re-wired all the run loop stuff to implement the aforementioned functions.
We added a flag to check whether the timer was active because the call to CFRunLoopTimerSetNextFireDate actually
turned out to be quite expensive (although Instruments couldn't tell us this).
(DefaultGCActivityCallbackPlatformData):
(JSC):
(JSC::DefaultGCActivityCallbackPlatformData::timerDidFire):
(JSC::DefaultGCActivityCallback::commonConstructor):
(JSC::scheduleTimer):
(JSC::cancelTimer):
(JSC::DefaultGCActivityCallback::willAllocate):
(JSC::DefaultGCActivityCallback::didCollect):
(JSC::DefaultGCActivityCallback::didAbandonObjectGraph):
- 9:18 AM Changeset in webkit [114510] by
-
- 5 edits2 adds in releases/WebKitGTK/webkit-1.8
Merging r110307
- 9:17 AM Changeset in webkit [114509] by
-
- 3 edits2 adds in trunk
ASSERT when a layer with a foreground layer is in 'paint into ancestor' mode
https://bugs.webkit.org/show_bug.cgi?id=84221
Source/WebCore:
Reviewed by Dean Jackson.
When a RenderLayerBacking doesn't require its own backing store, and is
in "paintIntoCompositingAncestor" mode, we would assert when trying to
paint its m_foregroundLayer if it had one (because of a negative z-index child).
The fix is to set the 'drawsContent' state on the m_foregroundLayer
as well as m_graphicsLayer.
Test: compositing/backing/no-backing-foreground-layer.html
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateDrawsContent):
LayoutTests:
Reviewed by Dean Jackson.
New testcase.
- compositing/backing/no-backing-foreground-layer-expected.txt: Added.
- compositing/backing/no-backing-foreground-layer.html: Added.
- 9:14 AM Changeset in webkit [114508] by
-
- 4 edits in trunk
[CMake] Use jsc target instead of ONLY_BUILD_JAVASCRIPTCORE
https://bugs.webkit.org/show_bug.cgi?id=84229
CMake caches ONLY_BUILD_JAVASCRIPTCORE=1 and will reuse the setting for
subsequent builds, stopping WebCore from being built ever again.
Instead of trying to emulate a build target using command line options,
just build the existing jsc target directly.
Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-04-18
Reviewed by Rob Buis.
.:
- CMakeLists.txt:
Tools:
- Scripts/build-jsc:
- 8:45 AM Changeset in webkit [114507] by
-
- 1 edit in branches/chromium/1025/Source/WebCore/platform/graphics/skia/NativeImageSkia.cpp
Merge 114487 - Skia OOM error when upscaling small subsets of images by large quantities
https://bugs.webkit.org/show_bug.cgi?id=84225
Patch by Rachel Blum <groby@chromium.org> on 2012-04-17
Reviewed by David Levin.
Tested with manual tests.
- platform/graphics/skia/NativeImageSkia.cpp:
(WebCore::NativeImageSkia::shouldCacheResampling):
TBR=commit-queue@webkit.org
Review URL: https://chromiumcodereview.appspot.com/10035027
- 8:44 AM Changeset in webkit [114506] by
-
- 8 edits in trunk
[GTK] r114021 triggered media flakyness
https://bugs.webkit.org/show_bug.cgi?id=83874
Patch by Simon Pena <Simon Pena> on 2012-04-18
Reviewed by Philippe Normand.
Source/WebKit/gtk:
When the MediaPlaybackRequiresUserGesture setting was added, no gtk
API was implemented to access it.
This adds a property to gtk WebKit WebSettings, and connects it to
WebKit WebView, thus allowing clients to programmatically modify it.
- webkit/webkitwebsettings.cpp:
(webkit_web_settings_class_init):
(webkit_web_settings_set_property):
(webkit_web_settings_get_property):
- webkit/webkitwebsettingsprivate.h:
- webkit/webkitwebview.cpp:
(webkit_web_view_update_settings):
(webkit_web_view_settings_notify):
Tools:
Now that there is gtk API to update the
MediaPlaybackRequiresUserGesture property, set it to false from the
DumpRenderTree tool when resetting defaults to consistent values.
- DumpRenderTree/gtk/DumpRenderTree.cpp:
(resetDefaultsToConsistentValues):
LayoutTests:
media/video-load-require-user-gesture.html and
media/video-play-require-user-gesture.html where enabling
MediaPlaybackRequiresUserGesture when run, so tests running
concurrently would fail -they would pass when run independently.
Since new API is added to ensure DumpRenderTree is able to reset
that setting, having media/video-load-require-user-gesture.html and
media/video-play-require-user-gesture.html no longer causes
flakiness.
- platform/gtk/test_expectations.txt: Unskip
media/video-load-require-user-gesture.html and
media/video-play-require-user-gesture.html
- 8:09 AM Changeset in webkit [114505] by
-
- 1 edit in branches/chromium/1084/Source/WebCore/inspector/front-end/TextPrompt.js
Merge 114382 - Web Inspector: Suggest box appears after the command was executed in console sometimes.
https://bugs.webkit.org/show_bug.cgi?id=84148
Reviewed by Pavel Feldman.
TextPrompt.complete() requests completions asynchronously, this change adds a flag
that informs TextPrompt._completionsReady() whether completions should still be shown.
- inspector/front-end/TextPrompt.js:
(WebInspector.TextPrompt.prototype.clearAutoComplete):
(WebInspector.TextPrompt.prototype.complete):
(WebInspector.TextPrompt.prototype._completionsReady):
TBR=vsevik@chromium.org
BUG=123826
Review URL: https://chromiumcodereview.appspot.com/10116026
- 7:59 AM Changeset in webkit [114504] by
-
- 18 edits in trunk
Web Inspector: DataGrid should use explicit root node
https://bugs.webkit.org/show_bug.cgi?id=84240
DataGrid now has an explicit root node. All children are added/removed
to that node.
Reviewed by Pavel Feldman.
Source/WebCore:
- inspector/front-end/ApplicationCacheItemsView.js:
(WebInspector.ApplicationCacheItemsView.prototype._createDataGrid):
(WebInspector.ApplicationCacheItemsView.prototype._populateDataGrid):
- inspector/front-end/CSSSelectorProfileView.js:
(WebInspector.CSSSelectorProfileView):
(WebInspector.CSSSelectorProfileView.prototype.rebuildGridItems):
(WebInspector.CSSSelectorProfileView.prototype.refreshData):
- inspector/front-end/CookieItemsView.js:
(WebInspector.SimpleCookiesTable):
(WebInspector.SimpleCookiesTable.prototype.setCookies):
- inspector/front-end/CookiesTable.js:
(WebInspector.CookiesTable):
(WebInspector.CookiesTable.prototype._rebuildTable):
- inspector/front-end/DOMStorageItemsView.js:
(WebInspector.DOMStorageItemsView.prototype._dataGridForDOMStorageEntries):
- inspector/front-end/DataGrid.js:
(WebInspector.DataGrid):
(WebInspector.DataGrid.createSortableDataGrid.sortDataGrid):
(WebInspector.DataGrid.createSortableDataGrid):
(WebInspector.DataGrid.prototype.setRootNode):
(WebInspector.DataGrid.prototype.rootNode):
(WebInspector.DataGrid.prototype.autoSizeColumns):
(WebInspector.DataGrid.prototype._enumerateChildren):
(WebInspector.DataGrid.prototype._keyDown):
(WebInspector.DataGrid.prototype._contextMenuInDataTable):
(WebInspector.DataGridNode.prototype.get revealed):
(WebInspector.DataGridNode.prototype.get depth):
(WebInspector.DataGridNode.prototype.appendChild):
(WebInspector.DataGridNode.prototype.insertChild):
(WebInspector.DataGridNode.prototype.removeChild):
(WebInspector.DataGridNode.prototype.removeChildren):
(WebInspector.DataGridNode.prototype.collapse):
(WebInspector.DataGridNode.prototype.expand):
(WebInspector.DataGridNode.prototype.reveal):
(WebInspector.DataGridNode.prototype.revealAndSelect):
(WebInspector.DataGridNode.prototype.traverseNextNode):
(WebInspector.DataGridNode.prototype.traversePreviousNode):
- inspector/front-end/HeapSnapshotDataGrids.js:
(WebInspector.HeapSnapshotSortableDataGrid):
(WebInspector.HeapSnapshotSortableDataGrid.prototype.dispose):
(WebInspector.HeapSnapshotSortableDataGrid.prototype.changeNameFilter):
(WebInspector.HeapSnapshotSortableDataGrid.prototype.updateVisibleNodes):
(WebInspector.HeapSnapshotSortableDataGrid.prototype._performSorting):
(WebInspector.HeapSnapshotContainmentDataGrid.prototype._defaultPopulateCount.100.expandRoute):
(WebInspector.HeapSnapshotContainmentDataGrid.prototype.setDataSource):
(WebInspector.HeapSnapshotContainmentDataGrid.prototype.sortingChanged):
(WebInspector.HeapSnapshotRetainmentDataGrid.prototype.reset):
(WebInspector.HeapSnapshotConstructorsDataGrid.prototype.populateChildren):
(WebInspector.HeapSnapshotDiffDataGrid.prototype.setBaseDataSource):
(WebInspector.HeapSnapshotDiffDataGrid.prototype.populateChildren.baseAggregatesReceived.aggregatesReceived.addNodeIfNonZeroDiff):
(WebInspector.HeapSnapshotDiffDataGrid.prototype.populateChildren.baseAggregatesReceived.aggregatesReceived):
(WebInspector.HeapSnapshotDiffDataGrid.prototype.populateChildren):
(WebInspector.HeapSnapshotDominatorsDataGrid.prototype._defaultPopulateCount.25.setDataSource):
(WebInspector.HeapSnapshotDominatorsDataGrid.prototype.sortingChanged):
- inspector/front-end/HeapSnapshotGridNodes.js:
(WebInspector.HeapSnapshotGenericObjectNode):
- inspector/front-end/HeapSnapshotView.js:
(WebInspector.HeapSnapshotView.prototype.performSearch):
(WebInspector.HeapSnapshotView.prototype.refreshVisibleData):
- inspector/front-end/IndexedDBViews.js:
(WebInspector.IDBDataView.prototype._createDataGrid):
(WebInspector.IDBDataView.prototype._updateData.callback):
(WebInspector.IDBDataView.prototype._updateData):
(WebInspector.IDBDataView.prototype.clear):
- inspector/front-end/NetworkPanel.js:
(WebInspector.NetworkLogView.prototype._createTable):
(WebInspector.NetworkLogView.prototype.refresh):
(WebInspector.NetworkLogView.prototype._reset):
- inspector/front-end/ProfileDataGridTree.js:
(WebInspector.ProfileDataGridNode.prototype.insertChild):
(WebInspector.ProfileDataGridNode.prototype.removeChild):
(WebInspector.ProfileDataGridNode.prototype.removeChildren):
- inspector/front-end/ProfileView.js:
(WebInspector.CPUProfileView.prototype.refresh):
- inspector/front-end/treeoutline.js:
LayoutTests:
- inspector/profiler/heap-snapshot-test.js:
(initialize_HeapSnapshotTest):
- inspector/storage-panel-dom-storage.html:
- 7:55 AM Changeset in webkit [114503] by
-
- 2 edits2 deletes in trunk/LayoutTests
Layout Test svg/transforms/transform-origin-css-property.xhtml is failing
https://bugs.webkit.org/show_bug.cgi?id=84203
Unreviewed test expectation fix.
The svg/transforms/transform-origin-css-property.xhtml test has a
ref-test for it, so there should not be any image expectations. If the
test if failing, we need to look at why the ref test is not valid, or
why we differ.
The expectations file update here is just some cleanup for
https://bugs.webkit.org/show_bug.cgi?id=84230.
- platform/chromium-mac/svg/transforms/transform-origin-css-property-expected.png: Removed.
- platform/chromium-win/svg/transforms/transform-origin-css-property-expected.png: Removed.
- platform/chromium/test_expectations.txt:
- 6:55 AM Changeset in webkit [114502] by
-
- 15 edits in trunk/Source/WebCore
Add PassThis=* to support the callbacks which requires to pass "this" value.
https://bugs.webkit.org/show_bug.cgi?id=84232
Patch by Vineet Chaudhary <Vineet> on 2012-04-18
Reviewed by Kentaro Hara.
Adding PassThisToCallback=XXX to attributes will be useful for the callbacks which requires to pass "this".
This will help to identify the type(XXX) of "this" value in codegenerator.
Tests: bindings/scripts/test/TestCallback.idl
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateCallbackImplementation): Modified codegenerator to support [PassThisToCallback]
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateCallbackImplementation): Ditto.
- bindings/scripts/IDLAttributes.txt: Added PassThisToCallback=*
- bindings/scripts/test/CPP/WebDOMTestCallback.cpp: Modofied results from run-bindings-tests.
(WebDOMTestCallback::callbackWithBoolean):
(WebDOMTestCallback::callbackRequiresThisToPass):
- bindings/scripts/test/CPP/WebDOMTestCallback.h: Ditto.
(WebDOMTestCallback):
- bindings/scripts/test/GObject/WebKitDOMTestCallback.cpp: Ditto.
(webkit_dom_test_callback_callback_with_boolean):
(webkit_dom_test_callback_callback_requires_this_to_pass):
- bindings/scripts/test/GObject/WebKitDOMTestCallback.h: Ditto.
- bindings/scripts/test/JS/JSTestCallback.cpp: Ditto.
(WebCore::JSTestCallback::callbackWithBoolean):
(WebCore):
(WebCore::JSTestCallback::callbackRequiresThisToPass):
- bindings/scripts/test/JS/JSTestCallback.h: Ditto.
(JSTestCallback):
- bindings/scripts/test/ObjC/DOMTestCallback.h: Ditto.
- bindings/scripts/test/ObjC/DOMTestCallback.mm: Ditto.
(-[DOMTestCallback callbackWithBoolean:]):
(-[DOMTestCallback callbackRequiresThisToPass:thisClassParam:]):
- bindings/scripts/test/TestCallback.idl: Added test to verify generated code.
- bindings/scripts/test/V8/V8TestCallback.cpp: Ditto.
(WebCore::V8TestCallback::callbackWithBoolean):
(WebCore):
(WebCore::V8TestCallback::callbackRequiresThisToPass):
- bindings/scripts/test/V8/V8TestCallback.h: Ditto.
(V8TestCallback):
- 6:52 AM Changeset in webkit [114501] by
-
- 2 edits in trunk/Source/WebCore
Not reviewed: fixing Chromium win compilation.
- bindings/v8/V8IsolatedContext.cpp:
- 6:02 AM Changeset in webkit [114500] by
-
- 2 edits in trunk/Source/WebCore
Remove unnecessary variable reassignment in CSSParser::parseImageSet().
https://bugs.webkit.org/show_bug.cgi?id=84204
Reviewed by Kentaro Hara.
Code calls next and then current instead of reusing the result of next.
No new tests / no functionality changed.
- css/CSSParser.cpp:
(WebCore::CSSParser::parseImageSet):
- 5:26 AM Changeset in webkit [114499] by
-
- 10 edits in trunk
Web Inspector: Disabling Inspector causes build failure on Windows
https://bugs.webkit.org/show_bug.cgi?id=83557
Patch by Vivek Galatage <vivekgalatage@gmail.com> on 2012-04-18
Reviewed by Pavel Feldman.
The calls to inspector APIs are not put under ENABLE(INSPECTOR) guard.
This change brings all such API calls under the guard.
Source/WebKit/win:
- WebCoreSupport/WebInspectorClient.cpp:
- WebInspector.cpp:
- WebNodeHighlight.cpp:
(WebNodeHighlight::WebNodeHighlight):
(WebNodeHighlight::update):
- WebNodeHighlight.h:
(WebNodeHighlight):
- WebView.cpp:
(WebView::WebView):
(WebView::close):
(WebView::initWithFrame):
(WebView::inspector):
- WebView.h:
(WebView):
Tools:
- WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
(WTR::LayoutTestController::showWebInspector):
(WTR::LayoutTestController::closeWebInspector):
(WTR::LayoutTestController::evaluateInWebInspector):
(WTR::LayoutTestController::setJavaScriptProfilingEnabled):
- WebKitTestRunner/TestInvocation.cpp:
(WTR::TestInvocation::invoke):
- 3:56 AM Changeset in webkit [114498] by
-
- 3 edits2 adds in trunk
[BlackBerry] HTTP GET header has a "Cookie" when refreshing a page after cookies have been cleared.
https://bugs.webkit.org/show_bug.cgi?id=84223
Patch by Jason Liu <jason.liu@torchmobile.com.cn> on 2012-04-18
Reviewed by George Staikos.
.:
- ManualTests/blackberry/clear-cookie-refresh-result.php: Added.
- ManualTests/blackberry/clear-cookie-refresh.php: Added.
Source/WebCore:
Webkit uses the old ResourceRequest when refreshing. Its cookies' header isn't removed after clicking
"clear cookies" button. We need to set cookies for this request again.
We must click "clear button" to test, so have to write a manual test case.
Test: ManualTests/blackberry/clear-cookie-refresh.php
- platform/network/blackberry/ResourceRequestBlackBerry.cpp:
(WebCore::ResourceRequest::initializePlatformRequest):
- 3:09 AM Changeset in webkit [114497] by
-
- 4 edits in trunk/Source/WebCore
Web Inspector: [Chromium] Module's require injects scripts before the debug id is set to the context.
https://bugs.webkit.org/show_bug.cgi?id=84166
Reviewed by Yury Semikhatsky.
V8IsolatedContext was getting debug id assigned post-construction. At the same time, it was compiling all
its module scripts within the constructor. As a result, scripts ended up in the main world's list.
- bindings/v8/V8IsolatedContext.cpp:
(WebCore::setInjectedScriptContextDebugId):
(WebCore):
(WebCore::V8IsolatedContext::V8IsolatedContext):
- bindings/v8/V8Proxy.cpp:
(WebCore::V8Proxy::evaluateInIsolatedWorld):
- bindings/v8/V8Proxy.h:
(V8Proxy):
- 3:04 AM Changeset in webkit [114496] by
-
- 2 edits in trunk/Source/WebKit2
[Qt][WK2] Minibrowser asserts on startup at QtViewportInteractionEngine::ensureContentWithinViewportBoundary()
https://bugs.webkit.org/show_bug.cgi?id=84172
Patch by Zalan Bujtas <zbujtas@gmail.com> on 2012-04-18
Reviewed by Simon Hausmann.
After the viewport computing refactor, ensureContentWithinViewportBoundary() can be called
with resumed page. QtViewportInteractionEngine::ensureContentWithinViewportBoundary()
functionality does not necessarily require the page to be suspended. It's the caller's context
that determines whether the page needs to be suspended, so it's the caller's responsibility
to enforce the ASSERT().
Remove the invalid ASSERT on m_suspendCount at QtViewportInteractionEngine::ensureContentWithinViewportBoundary()
- UIProcess/qt/QtViewportInteractionEngine.cpp:
(WebKit::QtViewportInteractionEngine::ensureContentWithinViewportBoundary):
- 2:29 AM SelectiveTestEWS edited by
- (diff)
- 1:53 AM Changeset in webkit [114495] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, update expectations
https://bugs.webkit.org/show_bug.cgi?id=84230
- platform/chromium/test_expectations.txt:
- 1:49 AM Changeset in webkit [114494] by
-
- 5 edits2 adds in trunk
Web Inspector: document.open removes the documentElement, but does not clear the elements panel.
https://bugs.webkit.org/show_bug.cgi?id=84179
Reviewed by Yury Semikhatsky.
Source/WebCore:
Perform total update upon modifications of the document node.
Test: inspector/elements/delete-from-document.html
- inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::didRemoveDOMNode):
- inspector/front-end/ElementsTreeOutline.js:
LayoutTests:
- http/tests/inspector/elements-test.js:
(initialize_ElementTest.InspectorTest.dumpElementsTree.print):
(initialize_ElementTest.InspectorTest.dumpElementsTree):
- inspector/elements/delete-from-document-expected.txt: Added.
- inspector/elements/delete-from-document.html: Added.
- 1:40 AM Changeset in webkit [114493] by
-
- 8 edits2 adds in trunk
Source/WebCore: [BlackBerry] Tab awareness for HTML5 concurrent audio
https://bugs.webkit.org/show_bug.cgi?id=82930
Support for concurrent HTML5 audio improvements being made in
the platform library, which need to be aware of tabs and tab
visibility. PR96004.
Patch by Max Feil <mfeil@rim.com> on 2012-04-18
Reviewed by George Staikos.
Test: media/audio-concurrent-supported.html
- platform/blackberry/PageClientBlackBerry.h:
- platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp:
(WebCore::MediaPlayerPrivate::MediaPlayerPrivate):
(WebCore::MediaPlayerPrivate::showErrorDialog):
(WebCore::MediaPlayerPrivate::isTabVisible):
(WebCore):
- platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.h:
(MediaPlayerPrivate):
Source/WebKit/blackberry: [BlackBerry] Tab awareness for HTML5 concurrent audio
https://bugs.webkit.org/show_bug.cgi?id=82930
Support for concurrent HTML5 audio improvements being made in
the platform library, which need to be aware of tabs and tab
visibility. PR96004.
Patch by Max Feil <mfeil@rim.com> on 2012-04-18
Reviewed by George Staikos.
- Api/WebPageClient.h:
- Api/WebPage_p.h:
(BlackBerry::WebKit::WebPagePrivate::isVisible):
LayoutTests: [BlackBerry] Tab awareness for HTML5 concurrent audio
https://bugs.webkit.org/show_bug.cgi?id=82930
Layout test for concurrent HTML5 audio. This is a simple test
to confirm that multiple audio elements can play at the same time.
Patch by Max Feil <mfeil@rim.com> on 2012-04-18
Reviewed by George Staikos.
- media/audio-concurrent-supported-expected.txt: Added.
- media/audio-concurrent-supported.html: Added.
- 1:17 AM Changeset in webkit [114492] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed gardening, skipping test that uses disabled feature SHADOW_DOM
Patch by Zoltan Arvai <zarvai@inf.u-szeged.hu> on 2012-04-18
- platform/qt/Skipped: fast/dom/shadow/adopt-node-with-shadow-root.html
- 1:05 AM Changeset in webkit [114491] by
-
- 2 edits in trunk/Source/WebCore
[CG] ImageBuffer: check getPremultipliedImageData() error return
https://bugs.webkit.org/show_bug.cgi?id=84022
Reviewed by Eric Seidel.
ImageBuffer::getPremultipliedImageData() can fail. toDataURL() should check for a
failure return, and return "data:," if so.
No new tests. Covered by existing toDataURL tests, in particular:
canvas/philip/tests/toDataURL.jpeg.alpha.html
- platform/graphics/cg/ImageBufferCG.cpp:
(WebCore::ImageBuffer::toDataURL): Rename |arr| variable to premultipliedData and
return "data:," if premultipliedData is empty. Clean up whitespace and a comment.
- 12:37 AM Changeset in webkit [114490] by
-
- 2 edits in trunk/Tools
[GTK] atk/textChangedNotifications API test fails
https://bugs.webkit.org/show_bug.cgi?id=84010
Unreviewed, unskipping test after bug being fixed by r114311.
- Scripts/run-gtk-tests:
(TestRunner): Unskip now passing test.
- 12:35 AM Changeset in webkit [114489] by
-
- 1 edit in branches/chromium/1084/Source/WebCore/platform/graphics/skia/NativeImageSkia.cpp
Merge 114487 - Skia OOM error when upscaling small subsets of images by large quantities
https://bugs.webkit.org/show_bug.cgi?id=84225
Patch by Rachel Blum <groby@chromium.org> on 2012-04-17
Reviewed by David Levin.
Tested with manual tests.
- platform/graphics/skia/NativeImageSkia.cpp:
(WebCore::NativeImageSkia::shouldCacheResampling):
TBR=commit-queue@webkit.org
Review URL: https://chromiumcodereview.appspot.com/10083037
