Timeline



Jun 2, 2012:

11:29 PM Changeset in webkit [119354] by aestes@apple.com
  • 2 edits in trunk/Source/WebCore

ZNK7WebCore4Node27traverseNextAncestorSiblingEv should be exported even if ENABLE(FULLSCREEN_API) is false
​https://bugs.webkit.org/show_bug.cgi?id=88184

Reviewed by Dan Bernstein.

Node::traverseNextAncestorSibling() is called in several inline
functions defined in ContainerNode.h (a private header), so its symbol
needs to be exported regardless of whether full-screen API is enabled.

  • WebCore.exp.in:
10:06 PM Changeset in webkit [119353] by wangxianzhu@chromium.org
  • 15 edits
    2 adds in trunk

SVGImageCache leaks image data
​https://bugs.webkit.org/show_bug.cgi?id=87792

Source/WebCore:

There are two functions to remove a client from a CachedImage:

  • CachedResource::removeClient()
  • CachedImage::removeClientForRenderer().

It's easy to make error to call the former which will leak the cached
image buffers in SVGImageCache.

This change combined the two by adding the virtual
CachedResource::didRemoveClient(). CachedImage will do SVGImageCache
cleanup in the function.

Reviewed by Nikolas Zimmermann.

Test: svg/as-image/svg-image-leak-cached-data.html

  • loader/cache/CachedFont.h:

(WebCore::CachedFontClient::resourceClientType): Added 'const'.

  • loader/cache/CachedImage.cpp:

(WebCore):
(WebCore::CachedImage::didRemoveClient): Removes the client from SVGImageCache.
(WebCore::CachedImage::lookupOrCreateImageForRenderer):

  • loader/cache/CachedImage.h:

(CachedImage):
(WebCore::CachedImageClient::resourceClientType): Added 'const'.

  • loader/cache/CachedRawResource.h:

(WebCore::CachedRawResourceClient::resourceClientType): Added 'const'.

  • loader/cache/CachedResource.cpp:

(WebCore::CachedResource::removeClient): Added invocation of didRemoveClient().

  • loader/cache/CachedResource.h:

(WebCore::CachedResource::didRemoveClient): Added for subclasses to do additional works.

  • loader/cache/CachedResourceClient.h:

(WebCore::CachedResourceClient::resourceClientType): Added 'const'.

  • loader/cache/CachedSVGDocument.h:

(WebCore::CachedSVGDocumentClient::resourceClientType): Added 'const'.

  • loader/cache/CachedStyleSheetClient.h:

(WebCore::CachedStyleSheetClient::resourceClientType): Added 'const'.

  • rendering/style/StyleCachedImage.cpp:

(WebCore::StyleCachedImage::removeClient):

  • rendering/style/StyleCachedImageSet.cpp:

(WebCore::StyleCachedImageSet::removeClient):

  • svg/graphics/SVGImageCache.cpp:

(WebCore::SVGImageCache::~SVGImageCache): Added checking for leaks.
(WebCore::SVGImageCache::removeClientFromCache):
(WebCore::SVGImageCache::setRequestedSizeAndScales):
(WebCore::SVGImageCache::requestedSizeAndScales):
(WebCore::SVGImageCache::lookupOrCreateBitmapImageForClient):

  • svg/graphics/SVGImageCache.h:

(WebCore):
(SVGImageCache):

LayoutTests:

Reviewed by Nikolas Zimmermann.

New test case.

  • svg/as-image/svg-image-leak-cached-data-expected.txt: Added.
  • svg/as-image/svg-image-leak-cached-data.html: Added.
9:10 PM Changeset in webkit [119352] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

Remove the failing expectation on fast/forms/textarea-scrollbar-height.html since it has been passing.

  • platform/chromium/TestExpectations:
8:45 PM Changeset in webkit [119351] by ggaren@apple.com
  • 3 edits in trunk/Source/WebKit2

2012-06-02 Geoffrey Garen <​ggaren@apple.com>

Try to fix the Windows build.

  • win/WebKit2.def:
  • win/WebKit2CFLite.def:
8:35 PM Changeset in webkit [119350] by rniwa@webkit.org
  • 1 edit
    3 adds in trunk/LayoutTests

Add back files inadvertently removed in r119323.

7:46 PM Changeset in webkit [119349] by aestes@apple.com
  • 20 edits in trunk/Source/WebKit2

[WebKit2] Use USE(), ENABLE(), and HAVE() macros in more places
​https://bugs.webkit.org/show_bug.cgi?id=88182

Reviewed by Sam Weinig.

Use USE(APPKIT):

  • Shared/mac/NativeWebKeyboardEventMac.mm:
  • Shared/mac/NativeWebMouseEventMac.mm:
  • Shared/mac/NativeWebWheelEventMac.mm:
  • Shared/mac/WebEventFactory.h:
  • UIProcess/API/mac/WKTextInputWindowController.h:
  • UIProcess/API/mac/WKTextInputWindowController.mm:
  • UIProcess/PageClient.h:
  • UIProcess/WebPageProxy.h:

Use ENABLE(NETSCAPE_PLUGIN_API):

  • UIProcess/API/C/WKPluginSiteDataManager.cpp:

(WKPluginSiteDataManagerClearSiteData):
(WKPluginSiteDataManagerClearAllSiteData):

Use USE(AUTOCORRECTION_PANEL):

  • UIProcess/API/mac/PageClientImpl.h:
  • UIProcess/API/mac/PageClientImpl.mm:

(WebKit::PageClientImpl::showCorrectionPanel):
(WebKit::PageClientImpl::dismissCorrectionPanel):
(WebKit::PageClientImpl::dismissCorrectionPanelSoon):

  • UIProcess/mac/CorrectionPanel.mm:

Use HAVE(HOSTED_CORE_ANIMATION):

  • UIProcess/mac/WebContextMac.mm:

Put ENABLE(FULLSCREEN_API) in the right place:

  • UIProcess/mac/WebFullScreenManagerProxyMac.mm:

Remove unnecessary use of USE(APPKIT):

  • UIProcess/mac/WebPageProxyMac.mm:

Use USE(SECURITY_FRAMEWORK):

  • WebProcess/Authentication/mac/AuthenticationManager.mac.mm:

Use ENABLE(CONTEXT_MENUS):

  • WebProcess/WebCoreSupport/mac/WebContextMenuClientMac.mm:

Use USE(SECURITY_FRAMEWORK):

  • WebProcess/WebProcess.h:

Remove unnecessary use of USE(SECURITY_FRAMEWORK):

  • WebProcess/mac/WebProcessMac.mm:
7:38 PM Changeset in webkit [119348] by rniwa@webkit.org
  • 3 edits in trunk/Source/WebCore

Windows build fix after r119330. Unnest the class for now.

  • dom/SelectorQuery.cpp:

(WebCore::SelectorQueryCacheEntry::SelectorQueryCacheEntry):
(WebCore::SelectorQueryCache::add):

  • dom/SelectorQuery.h:

(SelectorQueryCacheEntry):
(WebCore::SelectorQueryCacheEntry::selectorQuery):
(WebCore):
(SelectorQueryCache):

7:33 PM Changeset in webkit [119347] by aestes@apple.com
  • 2 edits in trunk/Source/WebKit2

Remove a duplicate INIT() from WebSystemInterface.mm
​https://bugs.webkit.org/show_bug.cgi?id=88181

Reviewed by Anders Carlsson.

  • WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:

(InitWebCoreSystemInterface):

7:23 PM Changeset in webkit [119346] by aestes@apple.com
  • 2 edits in trunk/Source/WebKit2

Remove unnecessary import of <Cocoa/Cocoa.h>
​https://bugs.webkit.org/show_bug.cgi?id=88180

Reviewed by Sam Weinig.

  • UIProcess/mac/WKFullKeyboardAccessWatcher.h:
5:53 PM Changeset in webkit [119345] by aestes@apple.com
  • 2 edits in trunk/Source/WebKit2

Ensure cpu_type_t is defined by including <mach/machine.h>
​https://bugs.webkit.org/show_bug.cgi?id=88178

Reviewed by Anders Carlsson.

  • Shared/Plugins/PluginModuleInfo.h:
5:47 PM Changeset in webkit [119344] by weinig@apple.com
  • 2 edits in trunk/Source/WebKit2

InjectedBundles' sandbox extensions don't do what we think they do
​https://bugs.webkit.org/show_bug.cgi?id=88177

Reviewed by Anders Carlsson.

This cannot be tested with our current infrastructure (or any modifications of the
infrastructure I can think of) since it relies on the bundle being put outside
the build directory where WebKit is put.

  • WebProcess/InjectedBundle/mac/InjectedBundleMac.cpp:

(WebKit::InjectedBundle::load):
Use SandboxExtension::consumePermanently() rather than consume(), otherwise,
nulling out the SandboxExtension a few lines later invalidates the extension
we just consumed.

5:41 PM Changeset in webkit [119343] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

If the DFG bytecode parser detects that op_method_check has gone polymorphic, it
shouldn't revert all the way to GetById/GetByIdFlush
​https://bugs.webkit.org/show_bug.cgi?id=88176

Reviewed by Geoffrey Garen.

Refactored the code so that the op_method_check case of the parser gracefully falls
through to all of the goodness of the normal op_get_by_id case.

  • dfg/DFGByteCodeParser.cpp:

(ByteCodeParser):
(JSC::DFG::ByteCodeParser::handleGetById):
(DFG):
(JSC::DFG::ByteCodeParser::parseBlock):

3:58 PM Changeset in webkit [119342] by fpizlo@apple.com
  • 18 edits in trunk/Source/JavaScriptCore

DFG CSE should be able to eliminate unnecessary flushes of arguments and captured variables
​https://bugs.webkit.org/show_bug.cgi?id=87929

Reviewed by Geoffrey Garen.

Slight speed-up on V8. Big win (up to 50%) on programs that inline very small functions.

This required a bunch of changes:

  • The obvious change is making CSE essentially ignore whether or not the set of operations between the Flush and the SetLocal can exit, and instead focus on whether or not that set of operations can clobber the world or access local variables. This code is now refactored to return a set of flags indicating any of these events, and the CSE decides what to do based on those flags. If the set of operations is non-clobbering and non-accessing, then the Flush is turned into a Phantom on the child of the SetLocal. This expands the liveness of the relevant variable but virtually guarantees that it will be register allocated and not flushed to the stack. So, yeah, this patch is a lot of work to save a few stores to the stack.


  • Previously, CheckArgumentsNotCreated was optimized "lazily" in that you only knew if it was a no-op if you were holding onto a CFA abstract state. But this would make the CSE act pessimistically, since it doesn't use the CFA. Hence, this patch changes the constant folding phase into something more broad; it now fixes up CheckArgumentsNotCreated nodes by turning them into phantoms if it knows that they are no-ops.


  • Arguments simplification was previously relying on this very strange PhantomArguments node, which had two different meanings: for normal execution it meant the empty value but for OSR exit it meant that the arguments should be reified. This produces problems when set SetLocals to the captured arguments registers are CSE'd away, since we'd be triggering reification of arguments without having initialized the arguments registers to empty. The cleanest solution was to fix PhantomArguments to have one meaning: namely, arguments reification on OSR exit. Hence, this patch changes arguments simplification to change SetLocal of CreateArguments on the arguments registers to be a SetLocal of Empty.


  • Argument value recoveries were previously derived from the value source of the arguments at the InlineStart. But that relies on all SetLocals to arguments having been flushed. It's possible that we could have elided the SetLocal to the arguments at the callsite because there were subsequent SetLocals to the arguments inside of the callee, in which case the InlineStart would get the wrong information. Hence, this patch changes argument value recovery computation to operate over the ArgumentPositions directly.


  • But that doesn't actually work, because previously, there was no way to link an InlineStart back to the corresponding ArgumentPositions, at least not without some ugliness. So this patch instates the rule that the m_argumentPositions vector consists of disjoint subsequences such that each subsequence corresponds to an inline callsite and can be identified by its first index, and within each subsequence are the ArgumentPositions of all of the arguments ordered by argument index. This required flipping the order in which ArgumentPositions are added to the vector, and giving InlineStart an operand that indicates the start of that inline callsite's ArgumentPosition subsequence.


  • This patch also revealed a nasty bug in the reification of arguments in inline call frames on OSR exit. Since the reification was happening after the values of virtual registers were recovered, the value recoveries of the inline arguments were wrong. Hence using operationCreateInlinedArguments is wrong. For example a value recovery might say that you have to box a double, but if we had already boxed it then boxing it a second time will result in garbage. The specific case of this bug was this patch uncovered was that now it is possible for an inline call frame to not have any valid value recoveries for any inline arguments, if the optimization elides all argument flushes, while at the same time optimizing away arguments creation. Then OSR exit would try to recover the arguments using the inline call frame, which had bogus information, and humorous crashes would ensue. This patch fixes this issue by moving arguments reification to after call frame reification, so that arguments reification can always use operationCreateArguments instead of operationCreateInlinedArguments.


  • This patch may turn a Flush into a Phantom. That's kind of the whole point. But that broke forward speculation checks, which knew to look for a Flush prior to a SetLocal but didn't know that there could alternatively be a Phantom in place of the Flush. This patch fixes that by augmenting the forward speculation check logic.


  • Finally, in the process of having fun with all of the above, I realized that my DFG validation was not actually running on every phase like I had originally designed it to. In fact it was only running just after bytecode parsing. I initially tried to make it run in every phase but found that this causes some tests to timeout (specifically the evil fuzzing ones), so I decided on a compromise where: (i) in release mode validation never runs, (ii) in debug mode validation will run just after parsing and just before the backend, and (iii) it's possible with a simple switch to enable validation to run on every phase.


Luckily all of the above issues were already covered by the 77 or so DFG-specific
layout tests. Hence, this patch does not introduce any new tests despite being so
meaty.

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::execute):

  • dfg/DFGArgumentPosition.h:

(JSC::DFG::ArgumentPosition::prediction):
(JSC::DFG::ArgumentPosition::doubleFormatState):
(JSC::DFG::ArgumentPosition::shouldUseDoubleFormat):
(ArgumentPosition):

  • dfg/DFGArgumentsSimplificationPhase.cpp:

(JSC::DFG::ArgumentsSimplificationPhase::run):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::handleInlining):
(JSC::DFG::ByteCodeParser::InlineStackEntry::InlineStackEntry):

  • dfg/DFGCSEPhase.cpp:

(JSC::DFG::CSEPhase::SetLocalStoreEliminationResult::SetLocalStoreEliminationResult):
(SetLocalStoreEliminationResult):
(JSC::DFG::CSEPhase::setLocalStoreElimination):
(JSC::DFG::CSEPhase::performNodeCSE):

  • dfg/DFGCommon.h:
  • dfg/DFGConstantFoldingPhase.cpp:

(JSC::DFG::ConstantFoldingPhase::run):

  • dfg/DFGDriver.cpp:

(JSC::DFG::compile):

  • dfg/DFGNode.h:

(Node):
(JSC::DFG::Node::hasArgumentPositionStart):
(JSC::DFG::Node::argumentPositionStart):

  • dfg/DFGOSRExitCompiler32_64.cpp:

(JSC::DFG::OSRExitCompiler::compileExit):

  • dfg/DFGOSRExitCompiler64.cpp:

(JSC::DFG::OSRExitCompiler::compileExit):

  • dfg/DFGPhase.cpp:

(DFG):

  • dfg/DFGPhase.h:

(Phase):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::forwardSpeculationCheck):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

3:49 PM Changeset in webkit [119341] by ggaren@apple.com
  • 8 edits in trunk/Source

DOM string cache should hash pointers, not characters
​https://bugs.webkit.org/show_bug.cgi?id=88175

Reviewed by Phil Pizlo and Sam Weinig.

../JavaScriptCore:

  • heap/Weak.h:

(JSC::weakAdd):
(JSC::weakRemove): Made these function templates slightly more generic
to accommodate new client types.

../WebCore:

Dromaeo DOM Core reports no change.

​http://trac.webkit.org/changeset/84934 accidentally changed from hashing
pointers to hashing characters, due to template defaults. Let's change back.

Hashing characters is not so good because:

(1) It's not memory-safe with HashMap::set(). HashMap::set() replaces
the value but not the key. Since our values own our keys, we need to
ensure object identity between key and value, or the key can be freed
prematurely. (This is impossible to demonstrate with our current
eager sweep behavior, but it shows up as crashes in layout tests if you
change to lazy sweep.)

(2) It's slower.

  • bindings/js/DOMWrapperWorld.h:

(WebCore): Override the default hash, which hashes based on characters.

2:52 PM Changeset in webkit [119340] by efidler@rim.com
  • 2 edits in trunk/Source/WebCore

Don't crash if we ask for fonts that don't exist.
​https://bugs.webkit.org/show_bug.cgi?id=88106

Reviewed by Dan Bernstein.

RIM PR 161219

If the site doesn't ask for a reasonable font and the system doesn't
provide a good fallback, FontFallBackList::primaryFontData can be 0,
which can cause a crash.

  • platform/graphics/skia/FontCacheSkia.cpp:

(WebCore::FontCache::getLastResortFallbackFont):

2:30 PM Changeset in webkit [119339] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/mac

loadRequest should check for empty URLs.
​https://bugs.webkit.org/show_bug.cgi?id=88154

In [WebFrame loadRequest], if the url is invalid and not nil, we transform it to file: url.
However, WebKit client could send down an empty URL that makes us transform it to file: url
as well. We should skip that as we did for nil URLs.

Patch by Yongjun Zhang <​yongjun_zhang@apple.com> on 2012-06-02
Reviewed by Brady Eidson.

  • WebView/WebFrame.mm:

(-[WebFrame loadRequest:]):

1:34 PM WebKitGTK/1.8.x edited by kov@webkit.org
(diff)
1:32 PM Changeset in webkit [119338] by kov@webkit.org
  • 5 edits in releases/WebKitGTK/webkit-1.8

Merge 115763 - Ensure HTMLElementStack fails gracefully if it has a non-Element.
​https://bugs.webkit.org/show_bug.cgi?id=85167

Reviewed by Adam Barth.

Source/WebCore:

Test: Added to html5lib/resources/webkit02.dat

  • html/parser/HTMLElementStack.cpp:

(WebCore::HTMLElementStack::oneBelowTop):

  • html/parser/HTMLTreeBuilder.cpp:

(WebCore::HTMLTreeBuilder::processEndTag):

LayoutTests:

  • html5lib/resources/webkit02.dat:
1:31 PM Changeset in webkit [119337] by kov@webkit.org
  • 4 edits in releases/WebKitGTK/webkit-1.8

Merge 108311 - Invalid cast in WebCore::toElement / WebCore::HTMLElementStack::ElementRecord::element
​https://bugs.webkit.org/show_bug.cgi?id=78975

Reviewed by Eric Seidel.

Source/WebCore:

We're supposed to set the action attribute on the form element we just
created. Previously, we assumed the newly created form element would
be on the top of the stack of open elements, but if we're in the table
body insertion mode, the form element gets treated as self closing and
is therefore popped off the stack of open elements.

Fortunately, we already cache a pointer to the most recently inserted
form element on the HTMLConstructionSite, so we can just grab the
element from there.

Test: html5lib/runner.html

  • html/parser/HTMLTreeBuilder.cpp:

(WebCore::HTMLTreeBuilder::processIsindexStartTagForInBody):
(WebCore):

LayoutTests:

  • html5lib/resourcesl/webkit-02.dat:
1:31 PM Changeset in webkit [119336] by kov@webkit.org
  • 1 add in releases/WebKitGTK/webkit-1.8/LayoutTests/platform/gtk/fast/dom/htmlcollection-non-html-expected.txt

Rebseline for 115398.

1:31 PM Changeset in webkit [119335] by kov@webkit.org
  • 3 edits
    2 adds in releases/WebKitGTK/webkit-1.8

Merge 115646 - loadOrRedirectSubframe should return the owner element's frame
​https://bugs.webkit.org/show_bug.cgi?id=84780

Reviewed by Nate Chapin.

Source/WebCore:

Test: fast/loader/javascript-url-iframe-remove-on-navigate.html

  • loader/SubframeLoader.cpp:

(WebCore::SubframeLoader::loadOrRedirectSubframe):

LayoutTests:

  • fast/loader/javascript-url-iframe-remove-on-navigate-expected.txt: Added.
  • fast/loader/javascript-url-iframe-remove-on-navigate.html: Added.
1:30 PM Changeset in webkit [119334] by kov@webkit.org
  • 3 edits
    2 adds in releases/WebKitGTK/webkit-1.8

Merge 115398 - Invalid cast in WebCore::HTMLCollection::isAcceptableElement
​https://bugs.webkit.org/show_bug.cgi?id=84626

Reviewed by Darin Adler.

Source/WebCore:

Check if the object is an HTMLElement before casting.

Test: fast/dom/htmlcollection-non-html.html

  • html/HTMLCollection.cpp:

(WebCore::HTMLCollection::isAcceptableElement):

LayoutTests:

Add tests to make sure only HTML elements are present in most HTMLCollection objects.

  • fast/dom/htmlcollection-non-html-option-expected.txt: Added.
  • fast/dom/htmlcollection-non-html.html: Added.
1:30 PM Changeset in webkit [119333] by kov@webkit.org
  • 3 edits
    2 adds in releases/WebKitGTK/webkit-1.8

Source/WebCore: Crash in CachedRawResource::didAddClient() due to missing protector.
​https://bugs.webkit.org/show_bug.cgi?id=83632

Reviewed by Eric Seidel.

Test: http/tests/xmlhttprequest/access-control-repeated-failed-preflight-crash.html

  • loader/cache/CachedRawResource.cpp:

(WebCore::CachedRawResource::didAddClient):

LayoutTests: Test for ​https://bugs.webkit.org/show_bug.cgi?id=83632.

Reviewed by Eric Seidel.

  • http/tests/xmlhttprequest/access-control-repeated-failed-preflight-crash-expected.txt: Added.
  • http/tests/xmlhttprequest/access-control-repeated-failed-preflight-crash.html: Added.
1:30 PM Changeset in webkit [119332] by kov@webkit.org
  • 3 edits
    3 adds in releases/WebKitGTK/webkit-1.8

2012-03-09 Nate Chapin <Nate Chapin>

CachedRawResource breaks when trying to load
a resource with an empty response body from cache.

Reviewed by Alexey Proskuryakov.

Test: http/tests/cache/zero-length-xhr.html

  • loader/cache/CachedRawResource.cpp: (WebCore::CachedRawResource::didAddClient): Don't exit early

if m_data is empty, we may still need to notifyFinished().

1:29 PM Changeset in webkit [119331] by kov@webkit.org
  • 7 edits in releases/WebKitGTK/webkit-1.8

Source/WebCore: Prevent CachedRawResource from sending the same data
chunk multiple times.
​https://bugs.webkit.org/show_bug.cgi?id=78810

Reviewed by Adam Barth.

If a CachedRawResource receives data while a CachedRawResourceCallback
timer is active, the incremental data will be sent to the client, followed
but all data received so far, resulting in invalid data. Resolving this adds
complexity to CachedRawResource and requires making a few more CachedResource
functions virtual, so push the callback logic into CachedResource where it can
be implemented more cleanly.

Test: inspector/debugger/script-formatter-console.html

should no longer be flaky.

  • loader/cache/CachedRawResource.cpp: CachedRawResourceCallback renamed and moved to CachedResource.

(WebCore::CachedRawResource::didAddClient): More or less the same as sendCallbacks() was.

  • loader/cache/CachedRawResource.h:
  • loader/cache/CachedResource.cpp:

(WebCore::CachedResource::addClient): Check the return value of addClientToSet() to determine whether

or not to call didAddClient.

(WebCore::CachedResource::didAddClient): May be called during addClient(), or may be called on a timer.

If called on a timer, move the client between sets.

(WebCore::CachedResource::addClientToSet): Determine whether didAddClient() can be called synchronously and

return true if it can.

(WebCore::CachedResource::removeClient): Ensure we cancel pending callbacks if necessary.
(WebCore::CachedResource::CachedResourceCallback::CachedResourceCallback): Renamed and moved from CachedRawResource.

  • loader/cache/CachedResource.h:

(WebCore::CachedResource::hasClients): Check m_clientsAwaitingCallback as well as m_clients.
(WebCore::CachedResource::CachedResourceCallback::schedule):
(WebCore::CachedResource::hasClient): Helper for calling contains() on both m_clientsAwaitingCallback and m_clients.

LayoutTests: inspector/debugger/script-formatter-console.html should
no longer be flaky.
​https://bugs.webkit.org/show_bug.cgi?id=78810

Reviewed by Adam Barth.

  • platform/chromium/test_expectations.txt:
12:23 PM Changeset in webkit [119330] by haraken@chromium.org
  • 7 edits in trunk/Source/WebCore

[Performance] Optimize querySelector() by caching SelectorQuery objects
​https://bugs.webkit.org/show_bug.cgi?id=87942

Reviewed by Antti Koivisto.

This patch improves performance of Node::querySelector() by 7.1x in Safari/Mac
and by 8.5x in Chromium/Linux.

Performance test: Parser/query-selector-first.html, Parser/query-selector-last.html

[query-selector-first.html]
Safari/Mac 264.97 runs/s => 1872.78 runs/s (7.06x speed-up)
Chromium/Linux 244.84 runs/s => 2071.60 runs/s (8.46x speed-up)

[query-selector-last.html]
Safari/Mac 393.73 runs/s => 466.05 runs/s (1.18x speed-up)
Chromium/Linux 401.15 runs/s => 484.45 runs/s (1.20x speed-up)

Previously Node::querySelector() and Node::querySelectorAll() had been
parsing CSS queries every time. This patch optimizes the performance by caching
parsed results onto a Document.

The cache is invalidated when any of CSS related variables is updated.
As per the current implementation of CSSParserContext::operator==(), the CSS related
variables are as follows:

  • baseURI
  • charset
  • mode
  • isHTMLDocument
  • isCSSCustomFilterEnabled
  • isCSSRegionsEnabled
  • needsSiteSpecificQuirks
  • enforcesCSSMIMETypeInNoQuirksMode

Actually, we do not need to watch all of these variables:

  • The current implementation does not watch the change of charset.

charset is always set to a null String by CSSParserContext::CSSParserContext().

  • isHTMLDocument never changes.
  • isCSSCustomFilterEnabled, isCSSRegionsEnabled, needsSiteSpecificQuirks and

enforcesCSSMIMETypeInNoQuirksMode are not flipped in a user scenario.
If someone changes them, it would be reasonable to expect them
to take the effect only on subsequent document loads.
Thus we do not need to invalidate the cache when these variables are updated.

Consequently, the condition under which we have to invalidate the cache is
that any of the following variables is updated:

  • baseURI
  • mode

Tests: fast/dom/SelectorAPI/*. No change in test results.

  • dom/SelectorQuery.h: SelectorQueryCache is a cache from CSS selectors to parsed results.

SelectorQueryCache::Entry is an entry of the cache.
SelectorQueryCache::Entry holds a SelectorQuery object and a CSSSelectorList object.
The reason why SelectorQueryCache::Entry needs to hold the CSSSelectorList object
is that the CSSSelectorList object keeps the lifetime of CSSSelector objects
in the SelectorQuery object. Since the SelectorQuery object just holds pointers
to CSSSelector objects, the CSSSelectorList object must not be destructed
before the SelectorQuery object is destructed.
(WebCore):
(SelectorDataList):
(WebCore::SelectorQuery::SelectorQuery):
(SelectorQuery):
(SelectorQueryCache):
(WebCore::SelectorQueryCache::SelectorQueryCache):
(Entry):
(WebCore::SelectorQueryCache::Entry::selectorQuery):

  • dom/SelectorQuery.cpp:

(WebCore::SelectorQuery::initialize):
(WebCore::SelectorQueryCache::Entry::Entry):
(WebCore::SelectorQueryCache::add): Returns a cached SelectorQuery object if any.
Otherwise, parses a given CSS selector, creates a SelectorQuery object,
adds the SelectorQuery object to a new entry in the cache, returns the SelectorQuery
object.
(WebCore::SelectorQueryCache::invalidate): Clears the cache.

  • dom/Document.h:

(WebCore):
(Document):

  • dom/Document.cpp:

(WebCore::Document::selectorQueryCache):
(WebCore):
(WebCore::Document::setCompatibilityMode): Invalidates the cache
when m_compatibilityMode is updated.
(WebCore::Document::updateBaseURL): Invalidates the cache
when m_baseURL is updated.

  • dom/Node.h: Changed String to AtomicString, since the key of the cache

should be AtomicString.
(Node):

  • dom/Node.cpp: Optimized the code by using the cache.

(WebCore::Node::querySelector):
(WebCore::Node::querySelectorAll):

12:05 PM Changeset in webkit [119329] by mitz@apple.com
  • 2 edits in trunk/Source/WebCore

Reverted the last change.

  • WebCore.xcodeproj/project.pbxproj:
12:02 PM Changeset in webkit [119328] by mitz@apple.com
  • 2 edits in trunk/Source/WebKit2

Reverted the last change.

  • WebKit2.xcodeproj/project.pbxproj:
11:59 AM Changeset in webkit [119327] by mitz@apple.com
  • 2 edits in trunk/Source/WebCore

Stop treating Perl code as private headers.

  • WebCore.xcodeproj/project.pbxproj: Removed CodeGenerator.pm, generate-bindings.pl,

IDLParser.pm, IDLStructure.pm, and preprocessor.pm from the Copy Headers build phase.

11:57 AM Changeset in webkit [119326] by fischman@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] SKIP http/tests/media/video-buffered.html because it requires overly large data
​https://bugs.webkit.org/show_bug.cgi?id=88172

Unreviewed gardening.

  • platform/chromium/TestExpectations:
11:54 AM Changeset in webkit [119325] by kevino@webkit.org
  • 2 edits in trunk

[wx] Unreviewed build fix. Temporarily disable DerivedSources cleanup on Windows.

11:43 AM Changeset in webkit [119324] by mitz@apple.com
  • 2 edits in trunk/Source/WebKit2

Stop treating two Python scripts as private headers.

  • WebKit2.xcodeproj/project.pbxproj: Removed model.py and parser.py from the Copy Headers

build phase.

9:58 AM Changeset in webkit [119323] by Csaba Osztrogonác
  • 6 edits
    37 moves
    17 adds
    5 deletes in trunk/LayoutTests

[Qt] Replace QtXmlPatterns usage with libxslt dependency
​https://bugs.webkit.org/show_bug.cgi?id=76820

Unreviewed gardening.

  • fast/xsl/xslt-mismatched-tags-in-xslt-expected.txt: Renamed from LayoutTests/platform/efl/fast/xsl/xslt-mismatched-tags-in-xslt-expected.txt.
  • platform/efl/fast/xsl/xslt-mismatched-tags-in-xslt-expected.png: Removed.
  • platform/gtk/fast/xsl/xslt-mismatched-tags-in-xslt-expected.png: Removed.
  • platform/gtk/fast/xsl/xslt-mismatched-tags-in-xslt-expected.txt: Removed.
  • platform/mac/fast/xsl/xslt-mismatched-tags-in-xslt-expected.png: Removed.
  • platform/mac/fast/xsl/xslt-mismatched-tags-in-xslt-expected.txt: Removed.
  • platform/qt-4.8/Skipped:
  • platform/qt-4.8/fast/css/dumpAsText/xml-stylesheet-pi-not-in-prolog-expected.txt: Renamed from LayoutTests/platform/qt/fast/css/dumpAsText/xml-stylesheet-pi-not-in-prolog-expected.txt.
  • platform/qt-4.8/fast/dom/Range/surround-contents-font-face-crash-expected.txt: Renamed from LayoutTests/platform/qt/fast/dom/Range/surround-contents-font-face-crash-expected.txt.
  • platform/qt-4.8/fast/dom/xml-parser-error-message-crash-expected.txt: Renamed from LayoutTests/platform/qt/fast/dom/xml-parser-error-message-crash-expected.txt.
  • platform/qt-4.8/fast/encoding/dumpAsText/utf-16-no-bom-expected.txt: Renamed from LayoutTests/platform/qt/fast/encoding/dumpAsText/utf-16-no-bom-expected.txt.
  • platform/qt-4.8/fast/events/xsl-onload-expected.txt: Renamed from LayoutTests/platform/qt/fast/events/xsl-onload-expected.txt.
  • platform/qt-4.8/fast/parser/xml-colon-entity-expected.txt: Renamed from LayoutTests/platform/qt/fast/parser/xml-colon-entity-expected.txt.
  • platform/qt-4.8/fast/parser/xml-declaration-missing-ending-mark-expected.txt: Renamed from LayoutTests/platform/qt/fast/parser/xml-declaration-missing-ending-mark-expected.txt.
  • platform/qt-4.8/fast/parser/xslt-with-html-expected.txt: Renamed from LayoutTests/platform/qt/fast/parser/xslt-with-html-expected.txt.
  • platform/qt-4.8/fast/xsl/subframe-location-expected.txt: Renamed from LayoutTests/platform/qt/fast/xsl/subframe-location-expected.txt.
  • platform/qt-4.8/fast/xsl/transform-to-html-expected.txt: Renamed from LayoutTests/platform/qt/fast/xsl/transform-to-html-expected.txt.
  • platform/qt-4.8/fast/xsl/utf8-chunks-expected.txt: Renamed from LayoutTests/platform/qt/fast/xsl/utf8-chunks-expected.txt.
  • platform/qt-4.8/fast/xsl/xslt-bad-import-uri-expected.txt: Renamed from LayoutTests/platform/qt/fast/xsl/xslt-bad-import-uri-expected.txt.
  • platform/qt-4.8/fast/xsl/xslt-doc-noenc-expected.txt: Renamed from LayoutTests/platform/qt/fast/xsl/xslt-doc-noenc-expected.txt.
  • platform/qt-4.8/fast/xsl/xslt-entity-enc-expected.txt: Renamed from LayoutTests/platform/qt/fast/xsl/xslt-entity-enc-expected.txt.
  • platform/qt-4.8/fast/xsl/xslt-entity-expected.png: Renamed from LayoutTests/platform/qt/fast/xsl/xslt-entity-expected.png.
  • platform/qt-4.8/fast/xsl/xslt-mismatched-tags-in-xslt-expected.txt: Renamed from LayoutTests/platform/qt/fast/xsl/xslt-mismatched-tags-in-xslt-expected.txt.
  • platform/qt-4.8/fast/xsl/xslt-recursion-expected.txt: Renamed from LayoutTests/platform/qt/fast/xsl/xslt-recursion-expected.txt.
  • platform/qt-4.8/http/tests/misc/location-test-xsl-style-sheet-expected.txt: Renamed from LayoutTests/platform/qt/http/tests/misc/location-test-xsl-style-sheet-expected.txt.
  • platform/qt-4.8/http/tests/security/contentSecurityPolicy/xsl-allowed-expected.txt: Renamed from LayoutTests/platform/qt/http/tests/security/contentSecurityPolicy/xsl-allowed-expected.txt.
  • platform/qt-4.8/http/tests/security/contentSecurityPolicy/xsl-img-blocked-expected.txt: Renamed from LayoutTests/platform/qt/http/tests/security/contentSecurityPolicy/xsl-img-blocked-expected.txt.
  • platform/qt-4.8/http/tests/security/contentSecurityPolicy/xsl-unaffected-by-style-src-2-expected.txt: Renamed from LayoutTests/platform/qt/http/tests/security/contentSecurityPolicy/xsl-unaffected-by-style-src-2-expected.txt.
  • platform/qt-4.8/http/tests/security/cookies/first-party-cookie-allow-xslt-expected.png: Renamed from LayoutTests/platform/qt/http/tests/security/cookies/first-party-cookie-allow-xslt-expected.png.
  • platform/qt-4.8/http/tests/security/cookies/first-party-cookie-allow-xslt-expected.txt: Renamed from LayoutTests/platform/qt/http/tests/security/cookies/first-party-cookie-allow-xslt-expected.txt.
  • platform/qt-4.8/http/tests/security/cookies/third-party-cookie-blocking-xslt-expected.png: Renamed from LayoutTests/platform/qt/http/tests/security/cookies/third-party-cookie-blocking-xslt-expected.png.
  • platform/qt-4.8/http/tests/security/cookies/third-party-cookie-blocking-xslt-expected.txt: Renamed from LayoutTests/platform/qt/http/tests/security/cookies/third-party-cookie-blocking-xslt-expected.txt.
  • platform/qt-4.8/http/tests/security/xss-DENIED-xml-external-entity-expected.txt: Renamed from LayoutTests/platform/qt/http/tests/security/xss-DENIED-xml-external-entity-expected.txt.
  • platform/qt-4.8/http/tests/security/xss-DENIED-xsl-document-redirect-expected.txt: Renamed from LayoutTests/platform/qt/http/tests/security/xss-DENIED-xsl-document-redirect-expected.txt.
  • platform/qt-4.8/http/tests/security/xss-DENIED-xsl-external-entity-expected.txt: Renamed from LayoutTests/platform/qt/http/tests/security/xss-DENIED-xsl-external-entity-expected.txt.
  • platform/qt-4.8/http/tests/security/xss-DENIED-xsl-external-entity-redirect-expected.txt: Renamed from LayoutTests/platform/qt/http/tests/security/xss-DENIED-xsl-external-entity-redirect-expected.txt.
  • platform/qt-4.8/svg/custom/bug45331-expected.png: Renamed from LayoutTests/platform/qt/svg/custom/bug45331-expected.png.
  • platform/qt-4.8/svg/custom/bug45331-expected.txt: Renamed from LayoutTests/platform/qt/svg/custom/bug45331-expected.txt.
  • platform/qt-4.8/svg/custom/bug78807-expected.txt: Renamed from LayoutTests/platform/qt/svg/custom/bug78807-expected.txt.
  • platform/qt-4.8/svg/custom/use-invalid-html-expected.txt: Renamed from LayoutTests/platform/qt/svg/custom/use-invalid-html-expected.txt.
  • platform/qt-4.8/svg/custom/use-invalid-style-expected.txt: Renamed from LayoutTests/platform/qt/svg/custom/use-invalid-style-expected.txt.
  • platform/qt-4.8/svg/hixie/error/dumpAsText/004-expected.txt: Renamed from LayoutTests/platform/qt/svg/hixie/error/dumpAsText/004-expected.txt.
  • platform/qt-4.8/svg/hixie/error/dumpAsText/005-expected.txt: Renamed from LayoutTests/platform/qt/svg/hixie/error/dumpAsText/005-expected.txt.
  • platform/qt-5.0-wk1/Skipped:
  • platform/qt-5.0/Skipped:
  • platform/qt-5.0/http/tests/security/xss-DENIED-xsl-document-redirect-expected.txt: Added.
  • platform/qt-5.0/http/tests/security/xss-DENIED-xsl-external-entity-redirect-expected.txt: Added.
  • platform/qt-arm/Skipped:
  • platform/qt/Skipped:
7:53 AM Changeset in webkit [119322] by tonikitoo@webkit.org
  • 3 edits in trunk/Source/WebKit/blackberry

[BlackBerry] browser video player fullscreen mode (portrait) - out of screen/focus - cannot navigate or use the buttons on the screen (PART III)
​https://bugs.webkit.org/show_bug.cgi?id=88019

Reviewed by George Staikos.
Patch by Antonio Gomes <​agomes@rim.com>

Enter 'pure-with-mouse-conversion' mode when going fullscreen, so
that it prevents user from scrolling the WebPage, pinch zooming,
touch-and-hold, enter selection mode, etc ...

Internally reviewed by Gen Mak.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
(BlackBerry::WebKit::WebPagePrivate::enterFullScreenForElement):
(BlackBerry::WebKit::WebPagePrivate::exitFullScreenForElement):

  • Api/WebPage_p.h:

(WebPagePrivate):

7:52 AM Changeset in webkit [119321] by tonikitoo@webkit.org
  • 3 edits in trunk/Source/WebKit/blackberry

[BlackBerry] browser video player fullscreen mode (portrait) - out of screen/focus - cannot navigate or use the buttons on the screen (PART II)
​https://bugs.webkit.org/show_bug.cgi?id=88019

Reviewed by George Staikos.
Patch by Antonio Gomes <​agomes@rim.com>

When an element goes fullscreen, its wrapper/container obeys all
BlackBerry specific fixed position customizations: we fixed
against Y, but not X. Then, in order to have the wrapper element
properly positioned when entering fullscreen mode, we
temporarily scroll x to 0.

The original x scroll position is restored when we leave
fullscreen.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
(BlackBerry::WebKit::WebPagePrivate::enterFullScreenForElement):
(BlackBerry::WebKit::WebPagePrivate::exitFullScreenForElement):

  • Api/WebPage_p.h:

(WebPagePrivate):

7:52 AM Changeset in webkit [119320] by tonikitoo@webkit.org
  • 3 edits in trunk/Source/WebKit/blackberry

[BlackBerry] browser video player fullscreen mode (portrait) - out of screen/focus - cannot navigate or use the buttons on the screen (PART I)
​https://bugs.webkit.org/show_bug.cgi?id=88019
PR #158266

Reviewed by George Staikos.
Patch by Antonio Gomes <​agomes@rim.com>

The way elements go fullscreen with the new FULLSCREEN_API
is that they get cloned and added to an out-of-DOM wrapper
element. The wrapper is a normal fixed position element and
then zoom in/out accordingly to how other layers do: following
WebPage's scale.

When going fullscreen, we have to take the current WebPage scale
into account in order to properly fit the element to the screen,
regardless the web page scale.

  • WebCoreSupport/ChromeClientBlackBerry.cpp:

(WebCore):
(WebCore::ChromeClientBlackBerry::fullScreenRendererChanged):

  • WebCoreSupport/ChromeClientBlackBerry.h:

(ChromeClientBlackBerry):

7:48 AM Changeset in webkit [119319] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed fix after r119255.

  • platform/qt/svg/css/getComputedStyle-basic-expected.txt:
7:01 AM Changeset in webkit [119318] by zeno.albisser@nokia.com
  • 20 edits in trunk

Fix and enable WebGL for WebKit2 on Qt.
​https://bugs.webkit.org/show_bug.cgi?id=86214

Source/WebCore:

Make GraphicsContext3DPrivate use GraphicsSurfaces
for WK2. The GraphicsContext3D then uses the existing
RenderBuffer for multisample rendering.
When WebGraphicsLayer::syncCompositingState is being
executed, the canvas is being synced as well. This means
that the RenderBuffer contents are being blit onto
a GraphicsSurface, and the GraphicsSurface token is
being sent to the UIProcess.
The WebLayerTreeRenderer then creates a
TextureMapperSurfaceBackingStore for the canvas and
passes the GraphicsSurface token as an argument.
The token can then be used to identify the GraphicsSurface
from the UIProcess side.

Reviewed by Noam Rosenthal.

  • platform/graphics/GraphicsContext3D.h:

Added createGraphicsSurfaces function. This is currently only
being used by the Qt port.

  • platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:

(WebCore::GraphicsContext3D::reshape):
Calling the createGraphicsSurfaces function when the GraphicsContext3D
is reshaped. This is currently only relevant for the Qt port.

  • platform/graphics/qt/GraphicsContext3DQt.cpp:

(GraphicsContext3DPrivate):
Added m_frontBufferGraphicsSurface, m_backBufferGraphicsSurface
and m_surfaceFlags members.
(WebCore::GraphicsContext3DPrivate::GraphicsContext3DPrivate):
In case of WK2, create a QOpenGLContext and two GraphicsSurface
for sharing the WebGL content with the UIProcess. One GraphicsSurface
is being used as the front, the other one as the backbuffer.
Creating a QOpenGLContext currently requires showing a QWindow.
For the moment we therefore create a minimal QWindow and place
it offscreen.
(WebCore::GraphicsContext3DPrivate::copyToGraphicsSurface):
This new function is called from the WebGraphicsLayer,
to blit the multisample framebuffer and copy its contents
onto the GraphicsSurface.
(WebCore::GraphicsContext3DPrivate::createGraphicsSurfaces):
Whenever the GraphicsContext3D is being reshaped,
new GraphicsSurfaces must be created with the updated dimensions.
(WebCore::GraphicsContext3D::createGraphicsSurfaces):

  • platform/graphics/texmap/TextureMapperPlatformLayer.h:

Added a new virtual function copyToGraphicsSurface.
(TextureMapperPlatformLayer):
(WebCore::TextureMapperPlatformLayer::copyToGraphicsSurface):

Source/WebKit2:

Added glue code to make use of GraphicsSurface
as a backend for the webgl-canvas in case of WK2.

Reviewed by Noam Rosenthal.

  • UIProcess/API/qt/qwebpreferences.cpp:

(QWebPreferencesPrivate::testAttribute):
(QWebPreferencesPrivate::setAttribute):
(QWebPreferences::webGLEnabled):
(QWebPreferences::setWebGLEnabled):

  • UIProcess/API/qt/qwebpreferences_p.h:
  • UIProcess/API/qt/qwebpreferences_p_p.h:

Added WebGLEnabled enum to allow enabling/disabling of
WebGL using QWebPreferences.

  • UIProcess/LayerTreeHostProxy.cpp:

(WebKit::LayerTreeHostProxy::syncCanvas):
Dispatch syncCanvas calls to the apropriate
WebLayerTreeRenderer.

  • UIProcess/LayerTreeHostProxy.h:

(LayerTreeHostProxy):

  • UIProcess/LayerTreeHostProxy.messages.in:
  • UIProcess/WebLayerTreeRenderer.h:

(WebLayerTreeRenderer):

  • UIProcess/WebLayerTreeRenderer.cpp:

(WebKit::WebLayerTreeRenderer::syncCanvas):
(WebKit::WebLayerTreeRenderer::deleteLayer):
(WebKit::WebLayerTreeRenderer::purgeGLResources):
Create a TextureMapperSurfaceBackingStore for the canvas
if necessary and pass or update the graphicsSurfaceToken
for to be used with the backing store.

  • WebProcess/WebCoreSupport/WebGraphicsLayer.cpp:

(WebCore::WebGraphicsLayer::WebGraphicsLayer):
(WebCore):
(WebCore::WebGraphicsLayer::setContentsToCanvas):
(WebCore::WebGraphicsLayer::syncCanvas):
Copy the multisample framebuffer contents onto the GraphicsSurface.
Notify the UIProcess of the availability of a new texture.
(WebCore::WebGraphicsLayer::syncCompositingStateForThisLayerOnly):
Sync the canvas as well.

  • WebProcess/WebCoreSupport/WebGraphicsLayer.h:

Added a pure virtual function syncCanvas.
This is guarded by PLATFORM(QT).
(WebGraphicsLayerClient):
(WebGraphicsLayer):

  • WebProcess/WebPage/qt/LayerTreeHostQt.cpp:

(WebKit::LayerTreeHostQt::syncLayerChildren):
(WebKit):
(WebKit::LayerTreeHostQt::syncCanvas):

  • WebProcess/WebPage/qt/LayerTreeHostQt.h:

(LayerTreeHostQt):

Tools:

Enable WebGL by default for Qt MiniBrowser.

Reviewed by Noam Rosenthal.

  • MiniBrowser/qt/qml/BrowserWindow.qml:
2:46 AM Changeset in webkit [119317] by rniwa@webkit.org
  • 3 edits
    6 moves in trunk

Tools: Teach svn-apply how to apply changes in test_expectations.txt to TestExpectations
​https://bugs.webkit.org/show_bug.cgi?id=88164

Reviewed by Kentaro Hara.

Just like r74856, adjust git/svn headers from test_expectations.txt to TestExpectations.
Also replace all occurrences of /test_expectations.txt: by /TestExpectations: in change log entries.

  • Scripts/VCSUtils.pm:

(adjustPathForRecentRenamings):
(fixChangeLogPatch):

LayoutTests: Rename test_expectations.txt to TestExpectations.

  • platform/chromium/TestExpectations: Copied from LayoutTests/platform/chromium/test_expectations.txt.
  • platform/chromium/test_expectations.txt: Removed.
  • platform/efl/TestExpectations: Copied from LayoutTests/platform/efl/test_expectations.txt.
  • platform/efl/test_expectations.txt: Removed.
  • platform/gtk/TestExpectations: Copied from LayoutTests/platform/gtk/test_expectations.txt.
  • platform/gtk/test_expectations.txt: Removed.
  • platform/mac/TestExpectations: Copied from LayoutTests/platform/mac/test_expectations.txt.
  • platform/mac/test_expectations.txt: Removed.
  • platform/qt/TestExpectations: Copied from LayoutTests/platform/qt/test_expectations.txt.
  • platform/qt/test_expectations.txt: Removed.
  • platform/win/TestExpectations: Copied from LayoutTests/platform/win/test_expectations.txt.
  • platform/win/test_expectations.txt: Removed.
1:15 AM Changeset in webkit [119316] by tony@chromium.org
  • 55 edits in trunk

Rename the flexbox CSS propery values from start to flex-start and end to flex-end
​https://bugs.webkit.org/show_bug.cgi?id=88152

Reviewed by Ojan Vafai.

Source/WebCore:

The spec changed. This is to differentiate from start/end which will
depend on writing mode direction, rather than flex direction.

No new tests, just updated the existing values.

  • css/CSSParser.cpp:

(WebCore::isValidKeywordPropertyAndValue):

  • css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator EAlignItems):
(WebCore::CSSPrimitiveValue::operator EJustifyContent):
(WebCore::CSSPrimitiveValue::operator EAlignContent):

  • css/CSSValueKeywords.in:
  • rendering/RenderFlexibleBox.cpp:

(WebCore::initialJustifyContentOffset):
(WebCore::alignmentForChild):
(WebCore::initialAlignContentOffset):
(WebCore::RenderFlexibleBox::alignFlexLines):
(WebCore::RenderFlexibleBox::alignChildren):

  • rendering/style/RenderStyle.h:
  • rendering/style/RenderStyleConstants.h:

LayoutTests:

Rename start to flex-start and end to flex-end.

  • css3/flexbox/css-properties-expected.txt:
  • css3/flexbox/css-properties.html:
  • css3/flexbox/flex-align-column.html:
  • css3/flexbox/flex-align-end.html:
  • css3/flexbox/flex-align-vertical-writing-mode.html:
  • css3/flexbox/flex-align.html:
  • css3/flexbox/flex-pack.html:
  • css3/flexbox/line-wrapping.html:
  • css3/flexbox/multiline-align.html:
  • css3/flexbox/multiline-column-auto.html:
  • css3/flexbox/multiline-line-pack-horizontal-column-expected.txt:
  • css3/flexbox/multiline-line-pack-horizontal-column.html:
  • css3/flexbox/multiline-line-pack.html:
  • css3/flexbox/multiline-pack-expected.txt:
  • css3/flexbox/multiline-pack.html:
  • css3/flexbox/multiline-reverse-wrap-baseline.html:
  • css3/flexbox/multiline-reverse-wrap-overflow.html:
  • css3/flexbox/multiline-shrink-to-fit.html:
  • css3/flexbox/multiline.html:
  • css3/flexbox/nested-stretch.html:
  • css3/flexbox/orthogonal-flex-directions.html:
  • platform/chromium-linux-x86/svg/css/getComputedStyle-basic-expected.txt:
  • platform/chromium-linux/svg/css/getComputedStyle-basic-expected.txt:
  • platform/chromium-mac-leopard/svg/css/getComputedStyle-basic-expected.txt:
  • platform/chromium-mac-snowleopard/svg/css/getComputedStyle-basic-expected.txt:
  • platform/chromium-mac/svg/css/getComputedStyle-basic-expected.txt:
  • platform/chromium-win-vista/svg/css/getComputedStyle-basic-expected.txt:
  • platform/chromium-win-xp/svg/css/getComputedStyle-basic-expected.txt:
  • platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt:
  • platform/gtk/svg/css/getComputedStyle-basic-expected.txt:
  • platform/mac/svg/css/getComputedStyle-basic-expected.txt:
  • platform/qt/svg/css/getComputedStyle-basic-expected.txt:
  • svg/css/getComputedStyle-basic-expected.txt:
12:12 AM Changeset in webkit [119315] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/qt

[Qt] Use 'Ok' and 'Cancel' buttons in JavaScript confirm box.
​https://bugs.webkit.org/show_bug.cgi?id=76190
Based on Johannes Obermayrs (​johannesobermayr@gmx.de) patch.
See: ​http://www.javascripter.net/faq/confirm.htm
Fixes: ​https://bugs.kde.org/show_bug.cgi?id=287629

Patch by Zoltan Arvai <​zarvai@inf.u-szeged.hu> on 2012-06-02
Reviewed by Simon Hausmann.

  • Api/qwebpage.cpp:

(QWebPage::javaScriptConfirm):

Jun 1, 2012:

11:44 PM Changeset in webkit [119314] by rniwa@webkit.org
  • 19 edits in trunk/Tools

Rename test_expectations.txt to TestExpectations
​https://bugs.webkit.org/show_bug.cgi?id=86690

Reviewed by Dirk Pranke.

Make webkitpy aware of both test_expectations.txt and TestExpectations while we rename files.
We can the code to read test_expectations.txt once we've successfully transitioned.

  • Scripts/webkitpy/layout_tests/models/test_expectations.py:

(TestExpectationParser._check_path_does_not_exist):
(TestExpectationParser._tokenize):
(TestExpectations): Removed TEST_LIST, which is not used anywhere.

  • Scripts/webkitpy/layout_tests/port/base.py:

(Port.path_to_test_expectations_file): Moved from WebKitPort and ChromiumPort. Returns the path to
test_expectations.txt if one exists and the path to TestExpectations otherwise.

  • Scripts/webkitpy/layout_tests/port/base_unittest.py:

(PortTest.test_virtual_methods): path_to_test_expectations_file and test_expectations are no longer
virtual.

  • Scripts/webkitpy/layout_tests/port/chromium.py:

(ChromiumPort.path_from_chromium_base):

  • Scripts/webkitpy/layout_tests/port/chromium_android.py:

(ChromiumAndroidPort.test_expectations):

  • Scripts/webkitpy/layout_tests/port/test.py:

(add_unit_tests_to_mock_filesystem): Use TestExpectations instead of test_expectations.txt.
(TestPort.init):

  • Scripts/webkitpy/layout_tests/port/webkit.py:

(WebKitPort.baseline_search_path):
(WebKitPort.test_expectations):

  • Scripts/webkitpy/layout_tests/port/webkit_unittest.py: Added some test cases. We should move these

tests to base as a follow up.
(WebKitPortTest.test_path_to_test_expectations_file):
(test_test_expectations):
(test_legacy_test_expectations):

  • Scripts/webkitpy/style/checker.py:

(CheckerDispatcher.should_skip_without_warning): Replace the check for legacy drt_expectations.txt
with one for TestExpectations.

  • Scripts/webkitpy/style/checkers/test_expectations.py:

(TestExpectationsChecker): Accept both test_expectations.txt and TestExpectations in warning outputs.

  • Scripts/webkitpy/style/checkers/test_expectations_unittest.py:

(TestExpectationsTestCase._expect_port_for_expectations_path): Test both TestExpectations and
test_expectations.txt.
(TestExpectationsTestCase.test_determine_port_from_expectations_path):
(TestExpectationsTestCase.assert_lines_lint):

  • Scripts/webkitpy/tool/commands/queries.py:

(PrintExpectations.init):

  • Scripts/webkitpy/tool/commands/rebaseline.py:

(RebaselineExpectations):

  • Scripts/webkitpy/tool/steps/commit.py:

(Commit._check_test_expectations):

  • Scripts/webkitpy/tool/steps/commit_unittest.py:

(CommitTest._test_check_test_expectations): Extracted from test_check_test_expectations.
(CommitTest.test_check_test_expectations): For TestExpectations.
(CommitTest.test_check_legacy_test_expectations): For test_expectations.txt

  • TestResultServer/static-dashboards/dashboard_base.js:

(requestExpectationsFile): Look for TestExpectations first, and fallback to test_expectations.txt.
Error only when neither exists.

  • TestResultServer/static-dashboards/flakiness_dashboard.js:

(processMissingAndExtraExpectations):
(htmlForTestsWithExpectationsButNoFailures):

  • TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
11:07 PM Changeset in webkit [119313] by commit-queue@webkit.org
  • 61 edits
    1 copy
    1 add in trunk/Source

[chromium] Software compositor initialization and base classes
​https://bugs.webkit.org/show_bug.cgi?id=87920

Patch by Alexandre Elias <​aelias@google.com> on 2012-06-01
Reviewed by James Robinson.

Source/Platform:

Add a new setting to force software compositing. In this mode,
no GraphicsContext3D should ever be created.

  • chromium/public/WebLayerTreeView.h:

(WebKit::WebLayerTreeView::Settings::Settings):
(Settings):

Source/WebCore:

This introduces new wrapper class CCGraphicsContext and base class
CCRenderer which will be used for software compositing support.
If no GraphicsContext3D is available, early return for now.

No new tests. (No-op change in 3d mode.)

  • platform/graphics/chromium/BitmapCanvasLayerTextureUpdater.cpp:

(WebCore::BitmapCanvasLayerTextureUpdater::Texture::updateRect):
(WebCore::BitmapCanvasLayerTextureUpdater::updateTextureRect):

  • platform/graphics/chromium/BitmapCanvasLayerTextureUpdater.h:

(Texture):
(BitmapCanvasLayerTextureUpdater):

  • platform/graphics/chromium/BitmapSkPictureCanvasLayerTextureUpdater.cpp:

(WebCore::BitmapSkPictureCanvasLayerTextureUpdater::Texture::updateRect):
(WebCore::BitmapSkPictureCanvasLayerTextureUpdater::updateTextureRect):

  • platform/graphics/chromium/BitmapSkPictureCanvasLayerTextureUpdater.h:

(Texture):
(BitmapSkPictureCanvasLayerTextureUpdater):

  • platform/graphics/chromium/CanvasLayerTextureUpdater.h:
  • platform/graphics/chromium/FrameBufferSkPictureCanvasLayerTextureUpdater.cpp:

(WebCore::FrameBufferSkPictureCanvasLayerTextureUpdater::Texture::updateRect):
(WebCore::FrameBufferSkPictureCanvasLayerTextureUpdater::updateTextureRect):

  • platform/graphics/chromium/FrameBufferSkPictureCanvasLayerTextureUpdater.h:

(Texture):
(FrameBufferSkPictureCanvasLayerTextureUpdater):

  • platform/graphics/chromium/ImageLayerChromium.cpp:

(WebCore::ImageLayerTextureUpdater::Texture::updateRect):
(WebCore::ImageLayerTextureUpdater::updateTextureRect):

  • platform/graphics/chromium/LayerChromium.h:

(WebCore):

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::CCRenderer::toGLMatrix):
(WebCore):
(WebCore::LayerRendererChromium::create):
(WebCore::CCRenderer::CCRenderer):
(WebCore::LayerRendererChromium::LayerRendererChromium):
(WebCore::LayerRendererChromium::copyPlaneToTexture):
(WebCore::LayerRendererChromium::drawHeadsUpDisplay):
(WebCore::LayerRendererChromium::getFramebufferTexture):
(WebCore::LayerRendererChromium::bindFramebufferToTexture):

  • platform/graphics/chromium/LayerRendererChromium.h:

(CCRenderer):
(WebCore::CCRenderer::~CCRenderer):
(WebCore::CCRenderer::ccContext):
(WebCore::CCRenderer::settings):
(WebCore::CCRenderer::viewportSize):
(WebCore::CCRenderer::viewportWidth):
(WebCore::CCRenderer::viewportHeight):
(WebCore::CCRenderer::projectionMatrix):
(WebCore::CCRenderer::windowMatrix):
(WebCore::CCRenderer::sharedGeometryQuad):
(WebCore):
(LayerRendererChromium):

  • platform/graphics/chromium/LayerTextureSubImage.cpp:

(WebCore::LayerTextureSubImage::upload):
(WebCore::LayerTextureSubImage::uploadWithTexSubImage):
(WebCore::LayerTextureSubImage::uploadWithMapTexSubImage):

  • platform/graphics/chromium/LayerTextureSubImage.h:

(WebCore):
(LayerTextureSubImage):

  • platform/graphics/chromium/LayerTextureUpdater.h:

(WebCore):
(Texture):

  • platform/graphics/chromium/ManagedTexture.cpp:

(WebCore::ManagedTexture::bindTexture):
(WebCore::ManagedTexture::framebufferTexture2D):

  • platform/graphics/chromium/ManagedTexture.h:

(WebCore):
(ManagedTexture):

  • platform/graphics/chromium/RenderSurfaceChromium.cpp:
  • platform/graphics/chromium/TextureCopier.cpp:

(WebCore::AcceleratedTextureCopier::copyTexture):

  • platform/graphics/chromium/TextureCopier.h:

(TextureCopier):
(AcceleratedTextureCopier):

  • platform/graphics/chromium/TextureUploader.h:

(TextureUploader):

  • platform/graphics/chromium/ThrottledTextureUploader.cpp:

(WebCore::ThrottledTextureUploader::uploadTexture):

  • platform/graphics/chromium/ThrottledTextureUploader.h:

(ThrottledTextureUploader):

  • platform/graphics/chromium/cc/CCGraphicsContext.h: Copied from Source/WebCore/platform/graphics/chromium/CanvasLayerTextureUpdater.h.

(WebCore):
(CCGraphicsContext):
(WebCore::CCGraphicsContext::create2D):
(WebCore::CCGraphicsContext::create3D):
(WebCore::CCGraphicsContext::context3D):
(WebCore::CCGraphicsContext::CCGraphicsContext):

  • platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:

(WebCore::CCHeadsUpDisplay::draw):

  • platform/graphics/chromium/cc/CCLayerImpl.cpp:

(WebCore::CCLayerImpl::willDraw):
(WebCore::CCLayerImpl::bindContentsTexture):

  • platform/graphics/chromium/cc/CCLayerImpl.h:

(WebCore):
(CCLayerImpl):

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::createContext):
(WebCore::CCLayerTreeHost::context):

  • platform/graphics/chromium/cc/CCLayerTreeHost.h:

(CCLayerTreeHostClient):
(WebCore::CCSettings::CCSettings):
(CCSettings):
(CCLayerTreeHost):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::context):
(WebCore::CCLayerTreeHostImpl::initializeLayerRenderer):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:

(CCLayerTreeHostImpl):
(WebCore::CCLayerTreeHostImpl::layerRenderer):

  • platform/graphics/chromium/cc/CCProxy.h:

(WebCore):
(CCProxy):

  • platform/graphics/chromium/cc/CCScrollbarLayerImpl.cpp:

(WebCore::CCScrollbarLayerImpl::willDraw):

  • platform/graphics/chromium/cc/CCScrollbarLayerImpl.h:

(CCScrollbarLayerImpl):

  • platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:

(WebCore::CCSingleThreadProxy::context):
(WebCore::CCSingleThreadProxy::initializeContext):
(WebCore::CCSingleThreadProxy::recreateContext):

  • platform/graphics/chromium/cc/CCSingleThreadProxy.h:

(CCSingleThreadProxy):

  • platform/graphics/chromium/cc/CCTextureUpdater.cpp:

(WebCore::CCTextureUpdater::update):

  • platform/graphics/chromium/cc/CCTextureUpdater.h:

(CCTextureUpdater):

  • platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::context):
(WebCore::CCThreadProxy::initializeContext):
(WebCore::CCThreadProxy::recreateContext):
(WebCore::CCThreadProxy::beginFrame):
(WebCore::CCThreadProxy::initializeContextOnImplThread):
(WebCore::CCThreadProxy::recreateContextOnImplThread):

  • platform/graphics/chromium/cc/CCThreadProxy.h:

(CCThreadProxy):

  • platform/graphics/chromium/cc/CCVideoLayerImpl.cpp:

(WebCore::CCVideoLayerImpl::willDraw):
(WebCore::CCVideoLayerImpl::willDrawInternal):
(WebCore::CCVideoLayerImpl::reserveTextures):

  • platform/graphics/chromium/cc/CCVideoLayerImpl.h:

(CCVideoLayerImpl):

Source/WebKit/chromium:

Add a new setting to force software compositing. In this mode,
no GraphicsContext3D should ever be created.

  • public/WebSettings.h:
  • src/WebLayerTreeView.cpp:

(WebKit::WebLayerTreeView::Settings::operator CCSettings):
(WebKit::WebLayerTreeView::context):

  • src/WebLayerTreeViewImpl.cpp:
  • src/WebSettingsImpl.cpp:

(WebKit::WebSettingsImpl::WebSettingsImpl):
(WebKit::WebSettingsImpl::setForceSoftwareCompositing):
(WebKit):

  • src/WebSettingsImpl.h:

(WebSettingsImpl):
(WebKit::WebSettingsImpl::forceSoftwareCompositing):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
(WebKit::WebViewImpl::createCompositorGraphicsContext3D):
(WebKit::WebViewImpl::createContext3D):

  • tests/CCLayerTreeHostImplTest.cpp:

(WebKitTests::CCLayerTreeHostImplTest::createContext):
(WebKitTests::TEST_F):

  • tests/CCLayerTreeHostTest.cpp:

(WTF::CCLayerTreeHostTestAtomicCommit::commitCompleteOnCCThread):
(WTF::CCLayerTreeHostTestAtomicCommit::drawLayersOnCCThread):
(WTF::CCLayerTreeHostTestAtomicCommitWithPartialUpdate::commitCompleteOnCCThread):
(WTF::CCLayerTreeHostTestAtomicCommitWithPartialUpdate::drawLayersOnCCThread):

  • tests/CCTiledLayerTestCommon.cpp:

(WebKitTests::FakeLayerTextureUpdater::Texture::updateRect):

  • tests/CCTiledLayerTestCommon.h:

(Texture):
(WebKitTests::FakeTextureCopier::copyTexture):
(WebKitTests::FakeTextureUploader::uploadTexture):

  • tests/Canvas2DLayerChromiumTest.cpp:

(Canvas2DLayerChromiumTest::fullLifecycleTest):

  • tests/FakeCCLayerTreeHostClient.h:
  • tests/LayerRendererChromiumTest.cpp:

(FakeLayerRendererChromium::FakeLayerRendererChromium):
(LayerRendererChromiumTest::LayerRendererChromiumTest):
(LayerRendererChromiumTest):
(TEST):

  • tests/TextureCopierTest.cpp:
  • tests/TiledLayerChromiumTest.cpp:

(WTF::TEST):

10:47 PM Changeset in webkit [119312] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

Suppress text diff on http/tests/media/video-buffered.html on Chromium Leopard as
it has been failing on Leopard since it was re-enabled in ​http://trac.webkit.org/changeset/119268.
The failure is tracked by the bug 88160.

  • platform/chromium/test_expectations.txt:
8:20 PM Changeset in webkit [119311] by commit-queue@webkit.org
  • 19 edits
    2 deletes in trunk/Source

Unreviewed, rolling out r119283, r119287, and r119291.
​http://trac.webkit.org/changeset/119283
​http://trac.webkit.org/changeset/119287
​http://trac.webkit.org/changeset/119291
​https://bugs.webkit.org/show_bug.cgi?id=88159

Not only broke compilation in the initial commit but also
broke LayerChromiumTest.basicCreateAndDestroy (Requested by
rniwa on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-06-01

Source/WebCore:

  • WebCore.gypi:
  • platform/graphics/chromium/AnimationTranslationUtil.cpp: Removed.
  • platform/graphics/chromium/AnimationTranslationUtil.h: Removed.
  • platform/graphics/chromium/GraphicsLayerChromium.cpp:

(WebCore::GraphicsLayerChromium::addAnimation):

  • platform/graphics/chromium/LayerChromium.cpp:

(WebCore::LayerChromium::addAnimation):

  • platform/graphics/chromium/LayerChromium.h:

(LayerChromium):

  • platform/graphics/chromium/LinkHighlight.cpp:

(WebCore::LinkHighlight::LinkHighlight):

  • platform/graphics/chromium/cc/CCAnimationCurve.h:

(CCTransformAnimationCurve):

  • platform/graphics/chromium/cc/CCKeyframedAnimationCurve.cpp:

(WebCore::CCTransformKeyframe::create):
(WebCore::CCTransformKeyframe::CCTransformKeyframe):
(WebCore::CCTransformKeyframe::value):
(WebCore::CCTransformKeyframe::clone):
(WebCore::CCKeyframedTransformAnimationCurve::getValue):

  • platform/graphics/chromium/cc/CCKeyframedAnimationCurve.h:

(CCTransformKeyframe):
(CCKeyframedTransformAnimationCurve):

  • platform/graphics/chromium/cc/CCLayerAnimationController.cpp:

(WebCore::CCLayerAnimationController::addAnimation):
(WebCore):
(WebCore::CCLayerAnimationController::add):
(WebCore::CCLayerAnimationController::pushNewAnimationsToImplThread):
(WebCore::CCLayerAnimationController::replaceImplThreadAnimations):
(WebCore::CCLayerAnimationController::tickAnimations):

  • platform/graphics/chromium/cc/CCLayerAnimationController.h:

(CCLayerAnimationControllerClient):
(CCLayerAnimationController):

  • platform/graphics/chromium/cc/CCLayerImpl.h:

Source/WebKit/chromium:

  • tests/CCAnimationTestCommon.cpp:

(WebCore::addOpacityTransition):
(WebCore::addAnimatedTransform):
(WebKitTests::FakeTransformTransition::getValue):

  • tests/CCAnimationTestCommon.h:
  • tests/CCKeyframedAnimationCurveTest.cpp:
  • tests/CCLayerAnimationControllerTest.cpp:
  • tests/CCLayerTreeHostTest.cpp:

(WTF::CCLayerTreeHostTestLayerAddedWithAnimation::beginTest):

  • tests/GraphicsLayerChromiumTest.cpp:

(WebKitTests::MockGraphicsLayerClient::notifyAnimationStarted):
(WebKitTests::MockGraphicsLayerClient::notifySyncRequired):
(WebKitTests::MockGraphicsLayerClient::paintContents):
(WebKitTests::MockGraphicsLayerClient::showDebugBorders):
(WebKitTests::MockGraphicsLayerClient::showRepaintCounter):
(WebKitTests::TEST):

8:17 PM Changeset in webkit [119310] by leviw@chromium.org
  • 2 edits in trunk/Source/WebCore

Large number constant in TransformationMatrix::projectPoint overflows FractionalLayoutUnits with sub-pixel layout enabled
​https://bugs.webkit.org/show_bug.cgi?id=87896

Reviewed by James Robinson.

kLargeNumber is meant to avoid overflowing when projecting a point through a transform. Unfortunately,
due to FractionalLayoutUnit's diminished range compared to integers, we were overflowing anyways. This
change adjusts our large number by the same value, but adjusted for our denominator.

This was originally missed because transforms/3d is marked as pass/fail in Chromium's test_expectations.txt
​https://bugs.webkit.org/show_bug.cgi?id=66989 tracks removing this problem.

No new tests. Covered by transforms/3d/hit-testing/perspective-clipped.html

  • platform/graphics/transforms/TransformationMatrix.cpp:

(WebCore::TransformationMatrix::projectPoint):

7:47 PM Changeset in webkit [119309] by wangxianzhu@chromium.org
  • 4 edits in trunk

Remove dependency from ImageDiff to WTF
​https://bugs.webkit.org/show_bug.cgi?id=88147

Reviewed by Adam Barth.

Source/WTF:

  • WTF.gyp/WTF.gyp:

Tools:

  • DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
7:09 PM Changeset in webkit [119308] by dpranke@chromium.org
  • 5 edits in trunk/Tools

NRWT seems to leak (more?) temp dirs
​https://bugs.webkit.org/show_bug.cgi?id=88126

Re-land r119297 with chromium fix (weren't calling the
super() method if not in --test-shell mode in start().
Add unit tests to chromium_unittest as well to check.

  • Scripts/webkitpy/layout_tests/port/chromium.py:

(ChromiumDriver.start):

  • Scripts/webkitpy/layout_tests/port/webkit.py:

(WebKitDriver.del):
(WebKitDriver._start):
(WebKitDriver.run_test):

  • Scripts/webkitpy/layout_tests/port/webkit_unittest.py:

(WebKitDriverTest.test_check_for_driver_crash):
(WebKitDriverTest.test_stop_cleans_up_properly):
(WebKitDriverTest):
(WebKitDriverTest.test_two_starts_cleans_up_properly):

  • Scripts/webkitpy/layout_tests/port/chromium_unittest.py:

(ChromiumDriverTest.test_stop_cleans_up_properly):
(ChromiumDriverTest.test_two_starts_cleans_up_properly):

6:38 PM Changeset in webkit [119307] by timothy_horton@apple.com
  • 7 edits in trunk/Source/WebCore

Cleanup GeneratorGeneratedImage/Gradient changes from r117858
​https://bugs.webkit.org/show_bug.cgi?id=88063

Reviewed by Simon Fraser.

No new tests, code cleanup.

  • platform/graphics/Generator.h:

(WebCore::Generator::hash): hash() should be const.

  • platform/graphics/GeneratorGeneratedImage.cpp:

(WebCore::GeneratorGeneratedImage::drawPattern): Minor cleanup.

  • platform/graphics/Gradient.cpp:

(WebCore::Gradient::Gradient): Rename m_hashCache to m_cachedHash.
(WebCore::Gradient::addColorStop): Rename clearHashCache to invalidateHash.
(WebCore::Gradient::sortStopsIfNecessary): Rename clearHashCache to invalidateHash.
(WebCore::Gradient::setSpreadMethod): Rename clearHashCache to invalidateHash.
(WebCore::Gradient::setGradientSpaceTransform): Rename clearHashCache to invalidateHash.
(WebCore::Gradient::hash): Use intHash instead of the pair hasher. Add compile time size checks
for structures being passed to StringHasher.

  • platform/graphics/Gradient.h:

(WebCore::Gradient::setP0): Rename clearHashCache to invalidateHash.
(WebCore::Gradient::setP1): Rename clearHashCache to invalidateHash.
(WebCore::Gradient::setStartRadius): Rename clearHashCache to invalidateHash.
(WebCore::Gradient::setEndRadius): Rename clearHashCache to invalidateHash.
(WebCore::Gradient::invalidateHash): Rename clearHashCache to invalidateHash.

  • platform/graphics/GraphicsContext.cpp:

(WebCore::scalesMatch): Added. Determine if the scale of two AffineTransforms match.
(WebCore::GraphicsContext::isCompatibleWithBuffer): Make use of scalesMatch to simplify the logic.

6:26 PM Changeset in webkit [119306] by jberlin@webkit.org
  • 2 edits in trunk/LayoutTests

Skip more asserting tests on Windows.

  • platform/win/Skipped:
6:26 PM Changeset in webkit [119305] by timothy_horton@apple.com
  • 2 edits in trunk/Tools

Lots of "failed download-built-product" on Apple bots
​https://bugs.webkit.org/show_bug.cgi?id=88158

Reviewed by Jessie Berlin.

Disable mergeRequests on all Apple builders. This is a speculative fix.

  • BuildSlaveSupport/build.webkit.org-config/config.json:
6:00 PM Changeset in webkit [119304] by rniwa@webkit.org
  • 3 edits in trunk/Tools

Unreviewed, rolling out r119297.
​http://trac.webkit.org/changeset/119297
​https://bugs.webkit.org/show_bug.cgi?id=88156

May have broken Chromium bots (Requested by rniwa on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-06-01

  • Scripts/webkitpy/layout_tests/port/webkit.py:

(WebKitDriver.del):
(WebKitDriver.run_test):

  • Scripts/webkitpy/layout_tests/port/webkit_unittest.py:

(WebKitDriverTest.test_check_for_driver_crash):
(WebKitDriverTest.test_stop_cleans_up_properly):

5:22 PM Changeset in webkit [119303] by fpizlo@apple.com
  • 3 edits
    3 adds in trunk

DFG CFA should know that PutByVal can clobber the world
​https://bugs.webkit.org/show_bug.cgi?id=88155

Reviewed by Gavin Barraclough.

Source/JavaScriptCore:

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::execute):

LayoutTests:

  • fast/js/dfg-putbyval-cfa-clobber-expected.txt: Added.
  • fast/js/dfg-putbyval-cfa-clobber.html: Added.
  • fast/js/script-tests/dfg-putbyval-cfa-clobber.js: Added.

(foo.bar):
(foo):

5:09 PM Changeset in webkit [119302] by commit-queue@webkit.org
  • 7 edits in trunk/Source/WebCore

Remove RefInfo class
​https://bugs.webkit.org/show_bug.cgi?id=87904

Patch by Raymond Toy <Raymond Toy> on 2012-06-01
Reviewed by Chris Rogers.

No new tests; covered by existing tests.

  • Modules/webaudio/AudioBufferSourceNode.cpp:

(WebCore::AudioBufferSourceNode::~AudioBufferSourceNode): Clear
panner node.
(WebCore::AudioBufferSourceNode::totalPitchRate):
(WebCore::AudioBufferSourceNode::setPannerNode): Use
RefTypeConnection counting for panner node.
(WebCore):
(WebCore::AudioBufferSourceNode::clearPannerNode): New function to

clear panner node in AudioBufferSourceNode.

(WebCore::AudioBufferSourceNode::finish): Clear panner node when done.

  • Modules/webaudio/AudioBufferSourceNode.h:

(AudioBufferSourceNode): Add virtual finish(), m_pannerNode is not
a RefPtr anymore.

  • Modules/webaudio/AudioContext.cpp:

(WebCore::AudioContext::addDeferredFinishDeref): Remove unneeded RefTyp.
(WebCore::AudioContext::handleDeferredFinishDerefs): Remove
unneeded RefType.

  • Modules/webaudio/AudioContext.h:

(AudioContext): Update addDeferredFinishDeref signature.

  • Modules/webaudio/AudioNode.cpp:

(WebCore::AudioNode::deref): Update call to addDeferredFinishDeref.

  • Modules/webaudio/AudioScheduledSourceNode.h:

(AudioScheduledSourceNode): Make finish() virtual.

4:54 PM Changeset in webkit [119301] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

DFG CFA should mark basic blocks as having constants if local accesses yield constants
​https://bugs.webkit.org/show_bug.cgi?id=88153

Reviewed by Gavin Barraclough.

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::execute):

4:47 PM Changeset in webkit [119300] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

DFG arguments simplification phase uses a node.codeOrigin after appending a node
​https://bugs.webkit.org/show_bug.cgi?id=88151

Reviewed by Geoffrey Garen.

The right thing to do is to save the CodeOrigin before appending to the graph.

  • dfg/DFGArgumentsSimplificationPhase.cpp:

(JSC::DFG::ArgumentsSimplificationPhase::run):

4:18 PM Changeset in webkit [119299] by fpizlo@apple.com
  • 3 edits
    3 adds in trunk

DFG should not emit unnecessary speculation checks when performing an int32 to double conversion on
a value that is proved to be a number, predicted to be an int32, but not proved to be an int32
​https://bugs.webkit.org/show_bug.cgi?id=88146

Reviewed by Gavin Barraclough.

Source/JavaScriptCore:

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileInt32ToDouble):

LayoutTests:

  • fast/js/dfg-int32-to-double-on-known-number-expected.txt: Added.
  • fast/js/dfg-int32-to-double-on-known-number.html: Added.
  • fast/js/script-tests/dfg-int32-to-double-on-known-number.js: Added.

(foo.bar):
(foo):

4:18 PM Changeset in webkit [119298] by tony@chromium.org
  • 60 edits in trunk

rename -webkit-flex-pack and -webkit-flex-line-pack to -webkit-justify-content and -webkit-align-content
​https://bugs.webkit.org/show_bug.cgi?id=88113

Reviewed by Ojan Vafai.

Source/WebCore:

This recently changed in the spec:
​http://dev.w3.org/csswg/css3-flexbox/#justify-content-property
​http://dev.w3.org/csswg/css3-flexbox/#align-content-property

No new tests, updated existing tests.

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

  • css/CSSParser.cpp:

(WebCore::isValidKeywordPropertyAndValue):
(WebCore::isKeywordPropertyID):
(WebCore::CSSParser::parseValue):

  • css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator EJustifyContent):
(WebCore::CSSPrimitiveValue::operator EAlignContent):

  • css/CSSProperty.cpp:

(WebCore::CSSProperty::isInheritedProperty):

  • css/CSSPropertyNames.in:
  • css/StyleBuilder.cpp:

(WebCore::StyleBuilder::StyleBuilder):

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::collectMatchingRulesForList):

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::repositionLogicalHeightDependentFlexItems):
(WebCore::initialJustifyContentOffset):
(WebCore::justifyContentSpaceBetweenChildren):
(WebCore::RenderFlexibleBox::layoutAndPlaceChildren):
(WebCore::RenderFlexibleBox::layoutColumnReverse):
(WebCore::initialAlignContentOffset):
(WebCore::alignContentSpaceBetweenChildren):
(WebCore::RenderFlexibleBox::alignFlexLines):

  • rendering/RenderFlexibleBox.h:
  • rendering/style/RenderStyle.h:
  • rendering/style/RenderStyleConstants.h:
  • rendering/style/StyleFlexibleBoxData.cpp:

(WebCore::StyleFlexibleBoxData::StyleFlexibleBoxData):
(WebCore::StyleFlexibleBoxData::operator==):

  • rendering/style/StyleFlexibleBoxData.h:

(StyleFlexibleBoxData):

  • rendering/style/StyleRareNonInheritedData.cpp:

(WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
(WebCore::StyleRareNonInheritedData::operator==):

  • rendering/style/StyleRareNonInheritedData.h:

(StyleRareNonInheritedData):

LayoutTests:

Find and replace for the CSS keywords.

  • css3/flexbox/columns-auto-size.html:
  • css3/flexbox/css-properties-expected.txt:
  • css3/flexbox/css-properties.html:
  • css3/flexbox/flex-pack.html:
  • css3/flexbox/multiline-align.html:
  • css3/flexbox/multiline-column-auto.html:
  • css3/flexbox/multiline-line-pack-expected.txt:
  • css3/flexbox/multiline-line-pack-horizontal-column-expected.txt:
  • css3/flexbox/multiline-line-pack-horizontal-column.html:
  • css3/flexbox/multiline-line-pack.html:
  • css3/flexbox/multiline-pack-expected.txt:
  • css3/flexbox/multiline-pack.html:
  • css3/flexbox/multiline-reverse-wrap-overflow.html:
  • css3/flexbox/multiline-shrink-to-fit.html:
  • css3/flexbox/multiline.html:
  • css3/flexbox/nested-stretch.html:
  • css3/flexbox/position-absolute-child.html:
  • css3/flexbox/true-centering.html:
  • fast/css/getComputedStyle/computed-style-expected.txt:
  • fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/chromium-linux-x86/svg/css/getComputedStyle-basic-expected.txt:
  • platform/chromium-linux/svg/css/getComputedStyle-basic-expected.txt:
  • platform/chromium-mac-leopard/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/chromium-mac-leopard/svg/css/getComputedStyle-basic-expected.txt:
  • platform/chromium-mac-snowleopard/svg/css/getComputedStyle-basic-expected.txt:
  • platform/chromium-mac/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/chromium-mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/chromium-mac/svg/css/getComputedStyle-basic-expected.txt:
  • platform/chromium-win-vista/svg/css/getComputedStyle-basic-expected.txt:
  • platform/chromium-win-xp/svg/css/getComputedStyle-basic-expected.txt:
  • platform/chromium-win/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/chromium-win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt:
  • platform/gtk/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/gtk/svg/css/getComputedStyle-basic-expected.txt:
  • platform/mac/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/mac/svg/css/getComputedStyle-basic-expected.txt:
  • platform/qt/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/qt/svg/css/getComputedStyle-basic-expected.txt:
  • platform/win/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • svg/css/getComputedStyle-basic-expected.txt:
4:11 PM Changeset in webkit [119297] by dpranke@chromium.org
  • 3 edits in trunk/Tools

nrwt seems to leak tmpdirs
​https://bugs.webkit.org/show_bug.cgi?id=88126

Reviewed by Ojan Vafai.

Fix leak possibly introduced in r118979 - we now will
make sure we clean up any stale temp directories during the
start routine and attempt to clean up again in del. It
turns out that asserting in del logs a message but is
caught by the runtime, so it's mostly useless.

  • Scripts/webkitpy/layout_tests/port/webkit.py:

(WebKitDriver.del):
(WebKitDriver._start):
(WebKitDriver.run_test):

  • Scripts/webkitpy/layout_tests/port/webkit_unittest.py:

(WebKitDriverTest.test_check_for_driver_crash):
(WebKitDriverTest.test_stop_cleans_up_properly):
(WebKitDriverTest):
(WebKitDriverTest.test_two_starts_cleans_up_properly):

4:09 PM Changeset in webkit [119296] by ap@apple.com
  • 6 edits
    1 delete in trunk/LayoutTests

Make cookie tests debuggable by merging scripts into HTML
​https://bugs.webkit.org/show_bug.cgi?id=88143

Reviewed by Anders Carlsson.

  • http/tests/cookies/double-quoted-value-with-semi-colon.html:
  • http/tests/cookies/multiple-cookies.html:
  • http/tests/cookies/script-tests: Removed.
  • http/tests/cookies/script-tests/TEMPLATE.html: Removed.
  • http/tests/cookies/script-tests/double-quoted-value-with-semi-colon.js: Removed.
  • http/tests/cookies/script-tests/multiple-cookies.js: Removed.
  • http/tests/cookies/script-tests/simple-cookies-expired.js: Removed.
  • http/tests/cookies/script-tests/simple-cookies-max-age.js: Removed.
  • http/tests/cookies/script-tests/single-quoted-value.js: Removed.
  • http/tests/cookies/simple-cookies-expired.html:
  • http/tests/cookies/simple-cookies-max-age.html:
  • http/tests/cookies/single-quoted-value.html:
3:59 PM Changeset in webkit [119295] by jberlin@webkit.org
  • 1 edit
    48 adds in trunk/LayoutTests

[Win] Windows 7 Release Testers report many compositing failures
​https://bugs.webkit.org/show_bug.cgi?id=88040

Part 2 of adding expected (failing?) results to get the bots greener.

  • platform/win/compositing/images: Added.
  • platform/win/compositing/images/clip-on-directly-composited-image-expected.txt: Added.
  • platform/win/compositing/images/direct-image-background-color-expected.txt: Added.
  • platform/win/compositing/images/direct-pdf-image-expected.txt: Added.
  • platform/win/compositing/images/direct-svg-image-expected.txt: Added.
  • platform/win/compositing/layer-creation/fixed-position-out-of-view-expected.txt: Added.
  • platform/win/compositing/layer-creation/overflow-scroll-overlap-expected.txt: Added.
  • platform/win/compositing/layer-creation/overlap-animation-expected.txt: Added.
  • platform/win/compositing/layer-creation/overlap-child-layer-expected.txt: Added.
  • platform/win/compositing/layer-creation/overlap-clipping-expected.txt: Added.
  • platform/win/compositing/layer-creation/overlap-transformed-and-clipped-expected.txt: Added.
  • platform/win/compositing/layer-creation/overlap-transformed-layer-expected.txt: Added.
  • platform/win/compositing/layer-creation/overlap-transforms-expected.txt: Added.
  • platform/win/compositing/layer-creation/rotate3d-overlap-expected.txt: Added.
  • platform/win/compositing/layer-creation/scroll-partial-update-expected.txt: Added.
  • platform/win/compositing/layer-creation/spanOverlapsCanvas-expected.txt: Added.
  • platform/win/compositing/layer-creation/stacking-context-overlap-expected.txt: Added.
  • platform/win/compositing/layer-creation/stacking-context-overlap-nested-expected.txt: Added.
  • platform/win/compositing/layer-creation/translatez-overlap-expected.txt: Added.
  • platform/win/compositing/masks: Added.
  • platform/win/compositing/masks/direct-image-mask-expected.txt: Added.
  • platform/win/compositing/masks/masked-ancestor-expected.txt: Added.
  • platform/win/compositing/masks/multiple-masks-expected.txt: Added.
  • platform/win/compositing/masks/simple-composited-mask-expected.txt: Added.
  • platform/win/compositing/overflow/ancestor-overflow-expected.txt
  • platform/win/compositing/overflow/clip-descendents-expected.txt: Added.
  • platform/win/compositing/overflow/content-gains-scrollbars-expected.txt: Added.
  • platform/win/compositing/overflow/content-loses-scrollbars-expected.txt: Added.
  • platform/win/compositing/overflow/overflow-compositing-descendant-expected.txt: Added.
  • platform/win/compositing/overflow/overflow-positioning-expected.txt: Added.
  • platform/win/compositing/overflow/overflow-scrollbar-layers-expected.txt: Added.
  • platform/win/compositing/overflow/resize-painting-expected.txt: Added.
  • platform/win/compositing/rtl: Added.
  • platform/win/compositing/rtl/rtl-absolute-expected.txt: Added.
  • platform/win/compositing/rtl/rtl-absolute-overflow-expected.txt: Added.
  • platform/win/compositing/rtl/rtl-absolute-overflow-scrolled-expected.txt: Added.
  • platform/win/compositing/rtl/rtl-iframe-absolute-expected.txt: Added.
  • platform/win/compositing/rtl/rtl-iframe-absolute-overflow-expected.txt: Added.
  • platform/win/compositing/rtl/rtl-iframe-absolute-overflow-scrolled-expected.txt: Added.
  • platform/win/compositing/rtl/rtl-iframe-fixed-expected.txt: Added.
  • platform/win/compositing/rtl/rtl-iframe-fixed-overflow-expected.txt: Added.
  • platform/win/compositing/rtl/rtl-iframe-fixed-overflow-scrolled-expected.txt: Added.
  • platform/win/compositing/rtl/rtl-iframe-relative-expected.txt: Added.
  • platform/win/compositing/rtl/rtl-relative-expected.txt: Added.
  • platform/win/compositing/tiling/crash-reparent-tiled-layer-expected.txt: Added.
  • platform/win/compositing/visibility: Added.
  • platform/win/compositing/visibility/layer-visible-content-expected.txt: Added.
  • platform/win/compositing/visibility/visibility-image-layers-dynamic-expected.txt: Added.
3:53 PM Changeset in webkit [119294] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

Overflow scrolling doesn't need to create a stacking context is the overflow is hidden
​https://bugs.webkit.org/show_bug.cgi?id=88057

Reviewed by James Robinson.

This patch causes us to match the iOS implementation of this feature.

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::collectMatchingRulesForList):

3:50 PM Changeset in webkit [119293] by mrowe@apple.com
  • 4 edits in branches/safari-536-branch/Source

Versioning.

3:44 PM Changeset in webkit [119292] by fpizlo@apple.com
  • 3 edits
    3 adds in trunk

DFG constant folding search for the last local access skips the immediately previous local access
​https://bugs.webkit.org/show_bug.cgi?id=88141

Source/JavaScriptCore:

Reviewed by Michael Saboff.

If you use a loop in the style of:

for (i = start; i--;)

then you need to remember that the first value of 'i' that the loop body will see is 'start - 1'.
Hence the following is probably wrong:

for (i = start - 1; i--;)

  • dfg/DFGConstantFoldingPhase.cpp:

(JSC::DFG::ConstantFoldingPhase::run):

LayoutTests:

Reviewed by Michael Saboff.

  • fast/js/dfg-obvious-constant-cfa-expected.txt: Added.
  • fast/js/dfg-obvious-constant-cfa.html: Added.
  • fast/js/script-tests/dfg-obvious-constant-cfa.js: Added.

(bar.baz):
(bar):

3:43 PM Changeset in webkit [119291] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Use fully qualified name for Fixed to avoid the collision with "typedef SInt32 Fixed" in MacTypes.h

  • tests/GraphicsLayerChromiumTest.cpp:

(WebKitTests::TEST_F):

3:34 PM Changeset in webkit [119290] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Fix the return value checking in SelectPopupClient
​https://bugs.webkit.org/show_bug.cgi?id=88130

Patch by Crystal Zhang <​haizhang@rim.com> on 2012-06-01
Reviewed by Rob Buis.

In SelectPopupClient, return '1' means selected, '0' means not selected,
the ASCII value of '0' is 48, not 32, use '0' to be more readable.

  • WebCoreSupport/SelectPopupClient.cpp:

(WebCore::SelectPopupClient::setValueAndClosePopup):

3:32 PM Changeset in webkit [119289] by rniwa@webkit.org
  • 1 edit
    4 adds in trunk/LayoutTests

Chromium rebaseline after r119274.

  • platform/chromium-linux/fast/reflections/reflection-with-zoom-expected.png: Added.
  • platform/chromium-mac-leopard/fast/reflections/reflection-with-zoom-expected.png: Added.
  • platform/chromium-mac/fast/reflections/reflection-with-zoom-expected.png: Added.
  • platform/chromium-win/fast/reflections/reflection-with-zoom-expected.png: Added.
3:15 PM Changeset in webkit [119288] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

Fix a typo in the expected result for the test added in r119281.119281

  • fast/js/dfg-cse-cfa-discrepancy-expected.txt:
3:14 PM Changeset in webkit [119287] by jamesr@google.com
  • 5 edits in trunk/Source

[chromium] Unreviewed compile fix for r119283

For the record, Dana Jensens <​danakj@chromium.org> wrote this slightly faster than I did.

Source/WebCore:

  • platform/graphics/chromium/LayerChromium.h:

(WebCore::LayerChromium::bounds):

  • platform/graphics/chromium/cc/CCLayerImpl.h:

(WebCore::CCLayerImpl::bounds):

Source/WebKit/chromium:

  • tests/CCAnimationTestCommon.h:
3:11 PM Changeset in webkit [119286] by ap@apple.com
  • 2 edits in trunk/LayoutTests

http/tests/cookies/simple-cookies-expired.html and simple-cookies-max-age.html are failing
​https://bugs.webkit.org/show_bug.cgi?id=82749

I don't see any failures locally (other than sometimes as flakiness in all cookie
tests), and the bug report doesnt' have any information about what was wrong.

  • platform/mac/Skipped: Re-enable to see what happens.
2:59 PM Changeset in webkit [119285] by jberlin@webkit.org
  • 3 edits
    48 adds in trunk/LayoutTests

[Win] Windows 7 Release Testers report many compositing failures
​https://bugs.webkit.org/show_bug.cgi?id=88040

Part 1 of adding expected (failing?) results to get the bots greener.

  • platform/win/compositing/geometry/flipped-writing-mode-expected.txt: Added.
  • platform/win/compositing/geometry/foreground-layer-expected.txt: Added.
  • platform/win/compositing/geometry/foreground-offset-change-expected.txt: Added.
  • platform/win/compositing/geometry/horizontal-scroll-composited-expected.txt: Added.
  • platform/win/compositing/geometry/layer-due-to-layer-children-deep-expected.txt: Added.
  • platform/win/compositing/geometry/layer-due-to-layer-children-deep-switch-expected.txt: Added.
  • platform/win/compositing/geometry/layer-due-to-layer-children-expected.txt: Added.
  • platform/win/compositing/geometry/layer-due-to-layer-children-switch-expected.txt: Added.
  • platform/win/compositing/geometry/limit-layer-bounds-clipping-ancestor-expected.txt: Added.
  • platform/win/compositing/geometry/limit-layer-bounds-opacity-transition-expected.txt: Added.
  • platform/win/compositing/geometry/limit-layer-bounds-overflow-repaint-expected.txt: Added.
  • platform/win/compositing/geometry/limit-layer-bounds-overflow-root-expected.txt: Added.
  • platform/win/compositing/geometry/limit-layer-bounds-positioned-expected.txt: Added.
  • platform/win/compositing/geometry/limit-layer-bounds-positioned-transition-expected.txt: Added.
  • platform/win/compositing/geometry/limit-layer-bounds-transformed-expected.txt: Added.
  • platform/win/compositing/geometry/limit-layer-bounds-transformed-overflow-expected.txt: Added.
  • platform/win/compositing/geometry/outline-change-expected.txt: Added.
  • platform/win/compositing/geometry/partial-layout-update-expected.txt: Added.
  • platform/win/compositing/geometry/preserve-3d-switching-expected.txt: Added.
  • platform/win/compositing/geometry/root-layer-update-expected.txt: Added.
  • platform/win/compositing/geometry/tall-page-composited-expected.txt: Added.
  • platform/win/compositing/geometry/transfrom-origin-on-zero-size-layer-expected.txt: Added.
  • platform/win/compositing/geometry/vertical-scroll-composited-expected.txt: Added.
  • platform/win/compositing/geometry/video-opacity-overlay-expected.txt: Added.
  • platform/win/compositing/iframes/become-composited-nested-iframes-expected.txt: Added.
  • platform/win/compositing/iframes/become-overlapped-iframe-expected.txt: Added.
  • platform/win/compositing/iframes/composited-iframe-alignment-expected.txt: Added.
  • platform/win/compositing/iframes/composited-iframe-scroll-expected.txt: Added.
  • platform/win/compositing/iframes/composited-parent-iframe-expected.txt: Added.
  • platform/win/compositing/iframes/connect-compositing-iframe-delayed-expected.txt: Added.
  • platform/win/compositing/iframes/connect-compositing-iframe-expected.txt: Added.
  • platform/win/compositing/iframes/connect-compositing-iframe2-expected.txt: Added.
  • platform/win/compositing/iframes/connect-compositing-iframe3-expected.txt: Added.
  • platform/win/compositing/iframes/enter-compositing-iframe-expected.txt: Added.
  • platform/win/compositing/iframes/iframe-content-flipping-expected.txt: Added.
  • platform/win/compositing/iframes/iframe-copy-on-scroll-expected.txt: Added.
  • platform/win/compositing/iframes/iframe-in-composited-layer-expected.txt: Added.
  • platform/win/compositing/iframes/iframe-resize-expected.txt: Added.
  • platform/win/compositing/iframes/iframe-size-from-zero-expected.txt: Added.
  • platform/win/compositing/iframes/invisible-iframe-expected.txt: Added.
  • platform/win/compositing/iframes/invisible-nested-iframe-expected.txt: Added.
  • platform/win/compositing/iframes/invisible-nested-iframe-hide-expected.txt: Added.
  • platform/win/compositing/iframes/invisible-nested-iframe-show-expected.txt:
  • platform/win/compositing/iframes/layout-on-compositing-change-expected.txt: Added.
  • platform/win/compositing/iframes/nested-iframe-scrolling-expected.txt: Added.
  • platform/win/compositing/iframes/overlapped-iframe-expected.txt: Added.
  • platform/win/compositing/iframes/overlapped-iframe-iframe-expected.txt:
  • platform/win/compositing/iframes/page-cache-layer-tree-expected.txt: Added.
  • platform/win/compositing/iframes/resizer-expected.txt: Added.
  • platform/win/compositing/iframes/scrolling-iframe-expected.txt: Added.
2:53 PM Changeset in webkit [119284] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

Unreviewed GTK gardening, adding a TEXT expectation for http/tests/media/video-buffered.html
after it started failing in r119268.

  • platform/gtk/test_expectations.txt:
2:46 PM Changeset in webkit [119283] by commit-queue@webkit.org
  • 18 edits
    2 adds in trunk/Source

[chromium] Accelerated animations should use WebTransformOperations
​https://bugs.webkit.org/show_bug.cgi?id=87686

Patch by Ian Vollick <​vollick@chromium.org> on 2012-06-01
Reviewed by James Robinson.

CCTransformKeyframe new owns a WebTransformOperations rather than a
TransformOperations. LayerChromium's API has been changed so that
LayerChromium::addAnimation should take only a CCActiveAnimation.
GraphicsLayerChromium is new responsible for translating to
WebTransformOperations and creating CCActiveAnimations. Tests that use
the public API (that is, they call addAnimation with KeyframeValueList
and Animation arguments) have been moved to GraphicsLayerChromiumTest.

Source/WebCore:

Unit tests:

GraphicsLayerChromiumTest.createOpacityAnimation
GraphicsLayerChromiumTest.createTransformAnimation
GraphicsLayerChromiumTest.createTransformAnimationWithBigRotation
GraphicsLayerChromiumTest.createTransformAnimationWithSingularMatrix
GraphicsLayerChromiumTest.createReversedAnimation
GraphicsLayerChromiumTest.createAlternatingAnimation
GraphicsLayerChromiumTest.createReversedAlternatingAnimation

  • WebCore.gypi:
  • platform/graphics/chromium/AnimationTranslationUtil.cpp: Added.

(WebCore):
(WebCore::toWebTransformOperations):
(WebCore::appendKeyframe):
(WebCore::CCKeyframedTransformAnimationCurve):
(WebCore::createActiveAnimation):

  • platform/graphics/chromium/AnimationTranslationUtil.h: Added.

(WebCore):

  • platform/graphics/chromium/GraphicsLayerChromium.cpp:

(WebCore::GraphicsLayerChromium::addAnimation):

  • platform/graphics/chromium/LayerChromium.cpp:

(WebCore::LayerChromium::addAnimation):

  • platform/graphics/chromium/LayerChromium.h:

(WebCore):
(LayerChromium):

  • platform/graphics/chromium/LinkHighlight.cpp:

(WebCore::LinkHighlight::LinkHighlight):

  • platform/graphics/chromium/cc/CCAnimationCurve.h:

(CCTransformAnimationCurve):

  • platform/graphics/chromium/cc/CCKeyframedAnimationCurve.cpp:

(WebCore::CCTransformKeyframe::create):
(WebCore::CCTransformKeyframe::CCTransformKeyframe):
(WebCore::CCTransformKeyframe::value):
(WebCore::CCTransformKeyframe::clone):
(WebCore::CCKeyframedTransformAnimationCurve::getValue):

  • platform/graphics/chromium/cc/CCKeyframedAnimationCurve.h:

(CCTransformKeyframe):
(CCKeyframedTransformAnimationCurve):

  • platform/graphics/chromium/cc/CCLayerAnimationController.cpp:

(WebCore::CCLayerAnimationController::removeAnimation):
(WebCore):
(WebCore::CCLayerAnimationController::addAnimation):
(WebCore::CCLayerAnimationController::getActiveAnimation):
(WebCore::CCLayerAnimationController::pushNewAnimationsToImplThread):
(WebCore::CCLayerAnimationController::replaceImplThreadAnimations):
(WebCore::CCLayerAnimationController::tickAnimations):

  • platform/graphics/chromium/cc/CCLayerAnimationController.h:

(CCLayerAnimationControllerClient):
(CCLayerAnimationController):

Source/WebKit/chromium:

  • tests/CCAnimationTestCommon.cpp:

(WebCore::addOpacityTransition):
(WebCore::addAnimatedTransform):
(WebKitTests::FakeTransformTransition::getValue):

  • tests/CCAnimationTestCommon.h:
  • tests/CCKeyframedAnimationCurveTest.cpp:

(WebCore::TEST):

  • tests/CCLayerAnimationControllerTest.cpp:

(WebKitTests::TEST):

  • tests/CCLayerTreeHostTest.cpp:

(WTF::CCLayerTreeHostTestLayerAddedWithAnimation::beginTest):

  • tests/GraphicsLayerChromiumTest.cpp:

(MockLayerTreeHostClient):
(WebKitTests):
(MockLayerTreeHost):
(WebKitTests::MockLayerTreeHost::create):
(WebKitTests::MockLayerTreeHost::createLayerTreeHostImpl):
(WebKitTests::MockLayerTreeHost::MockLayerTreeHost):
(GraphicsLayerChromiumTest):
(WebKitTests::GraphicsLayerChromiumTest::GraphicsLayerChromiumTest):
(WebKitTests::GraphicsLayerChromiumTest::~GraphicsLayerChromiumTest):
(WebKitTests::GraphicsLayerChromiumTest::expectTranslateX):
(WebKitTests::TEST_F):

2:34 PM Changeset in webkit [119282] by fpizlo@apple.com
  • 2 edits in trunk/LayoutTests

DFG constant folding should be OK with GetLocal of captured variables having a constant
​https://bugs.webkit.org/show_bug.cgi?id=88137

Fix a typo that Gavin found but that I failed to fix in previous commit.

  • fast/js/script-tests/dfg-cse-cfa-discrepancy.js:
2:32 PM Changeset in webkit [119281] by fpizlo@apple.com
  • 3 edits
    3 adds in trunk

DFG constant folding should be OK with GetLocal of captured variables having a constant
​https://bugs.webkit.org/show_bug.cgi?id=88137

Reviewed by Gavin Barraclough.

Source/JavaScriptCore:

  • dfg/DFGConstantFoldingPhase.cpp:

(JSC::DFG::ConstantFoldingPhase::run):

LayoutTests:

  • fast/js/dfg-cse-cfa-discrepancy-expected.txt: Added.
  • fast/js/dfg-cse-cfa-discrepancy.html: Added.
  • fast/js/script-tests/dfg-cse-cfa-discrepancy.js: Added.

(foo.bar.baz):
(foo.bar):
(foo):

2:26 PM Changeset in webkit [119280] by msaboff@apple.com
  • 4 edits in trunk

WebFrame::_stringByEvaluatingJavaScriptFromString methods don't handle nil string
​https://bugs.webkit.org/show_bug.cgi?id=88109

Reviewed by Geoffrey Garen.

Source/WebKit/mac:

Added short circuit return when the NSString to evaluate is nil.

  • WebView/WebFrame.mm:

(-[WebFrame _stringByEvaluatingJavaScriptFromString:forceUserGesture:]):
(-[WebFrame _stringByEvaluatingJavaScriptFromString:withGlobalObject:inScriptWorld:]):

Tools:

Additional test case.

  • TestWebKitAPI/Tests/mac/StringByEvaluatingJavaScriptFromString.mm:

(TestWebKitAPI::TEST):

2:04 PM Changeset in webkit [119279] by jberlin@webkit.org
  • 2 edits in trunk/LayoutTests

[Win] ASSERT(enclosingIntRect(rendererMappedResult) == enclosingIntRect(FloatQuad(result).boundingBox()))
failed in RenderGeometryMap::absoluteRect
​https://bugs.webkit.org/show_bug.cgi?id=88128

Add affected tests to the Windows Skipped list.

  • platform/win/Skipped:

Also, fix the line endings for this file.

2:00 PM Changeset in webkit [119278] by zandobersek@gmail.com
  • 1 edit
    6 adds in trunk/LayoutTests

Unreviewed GTK gardening, adding new baselines after r119256.

  • platform/gtk/fast/viewport/viewport-legacy-handheldfriendly-expected.txt: Added.
  • platform/gtk/fast/viewport/viewport-legacy-mobileoptimized-2-expected.txt: Added.
  • platform/gtk/fast/viewport/viewport-legacy-mobileoptimized-3-expected.txt: Added.
  • platform/gtk/fast/viewport/viewport-legacy-mobileoptimized-expected.txt: Added.
  • platform/gtk/fast/viewport/viewport-legacy-ordering-5-expected.txt: Added.
  • platform/gtk/fast/viewport/viewport-legacy-ordering-6-expected.txt: Added.
1:47 PM Changeset in webkit [119277] by schenney@chromium.org
  • 2 edits in trunk/LayoutTests

Layout Test fast/dom/HTMLMeterElement/meter-element-crash.html is failing
​https://bugs.webkit.org/show_bug.cgi?id=88131

Unreviewed addition to Chromium test expectations.

  • platform/chromium/test_expectations.txt:
1:23 PM Changeset in webkit [119276] by mihaip@chromium.org
  • 5 edits in trunk

Improve synchronous XHR disabling
​https://bugs.webkit.org/show_bug.cgi?id=88032

Reviewed by Alexey Proskuryakov.

Source/WebCore:

  • testing/InternalSettings.cpp:

(WebCore::InternalSettings::setSyncXHRInDocumentsEnabled): Fix a
copy-and-paste error

  • xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::open): Improves the disabled message, as
suggested in a comment after r118599 was put in the commit queue.

LayoutTests:

Update with new error message.

  • fast/xmlhttprequest/xmlhttprequest-sync-disabled-expected.txt:
1:22 PM Changeset in webkit [119275] by caio.oliveira@openbossa.org
  • 2 edits in trunk/Source/WebKit/qt

[Qt] Fix QObject bridge tests in Qt5 after (not so) recent QVariant changes
​https://bugs.webkit.org/show_bug.cgi?id=88127

Reviewed by Noam Rosenthal.

We were checking for invalid QVariants in a very odd way. Since in Qt5 the
userType of invalid changed to not be Void, this broke the tests for QtWebKit
with Qt5. Replace those checks with QVariant::isValid() calls.

  • tests/qobjectbridge/tst_qobjectbridge.cpp:

(tst_QObjectBridge::evalJS):
(tst_QObjectBridge::evalJSV):

1:20 PM Changeset in webkit [119274] by Beth Dakin
  • 4 edits
    3 adds in trunk

​https://bugs.webkit.org/show_bug.cgi?id=87774
REGRESSION (r105515): reflection masks are truncated at zoom levels < 1
-and corresponding-
<rdar://problem/11387506>

Reviewed by Simon Fraser.

Source/WebCore:

paintNinePieceImage() expects un-zoomed results from
calculateImageIntrinsicDimensions(). This was previously addressed by having
paintNinePieceImage() divide the effective zoom out of the result from
calculateImageIntrinsicDimensions(). However, that results in buggy behavior for
generated images and images with percentage sizes. In the end it seems best to
just send a parameter to calculateImageIntrinsicDimensions() indicating whether
the caller wants the result to be scaled by the effective zoom when appropriate.

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::calculateImageIntrinsicDimensions):
(WebCore::RenderBoxModelObject::calculateFillTileSize):
(WebCore::RenderBoxModelObject::paintNinePieceImage):

  • rendering/RenderBoxModelObject.h:

(RenderBoxModelObject):

LayoutTests:

  • fast/reflections/reflection-with-zoom.html: Added.
  • platform/mac/fast/reflections/reflection-with-zoom-expected.png: Added.
  • platform/mac/fast/reflections/reflection-with-zoom-expected.txt: Added.
1:15 PM Changeset in webkit [119273] by schenney@chromium.org
  • 2 edits in trunk/LayoutTests

Another Chromium test expectation update per the bug 88124.

Unreviewed Chromium test expectations fix.

  • platform/chromium/test_expectations.txt:
1:15 PM Changeset in webkit [119272] by jchaffraix@webkit.org
  • 6 edits in trunk/Source/WebCore

Prepare table collapsed border computation to support mixed directionality on row group
​https://bugs.webkit.org/show_bug.cgi?id=88110

Reviewed by Ojan Vafai.

No expected change in behavior.

One big issue with supporting mixed directionality inside a table is that the start / end
borders don't align between table parts anymore: the start border of a ltr table will have
to match the end border of a rtl row group for the purpose of collapsed border computation.

This change adds the concept of adjoining borders in the table direction so that we can safely
hide which exact borders we pick up for the collapsed border computation.

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::calcBorderStart):
(WebCore::RenderTable::calcBorderEnd):
Refactored those functions to use proper naming along with the new APIs. The name 'adjoining' is
used extensively as we cannot make any assumptions on which borders we will get.

(WebCore::RenderTable::recalcBordersInRowDirection):
Added a FIXME found during testing.

  • rendering/RenderTableCell.h:

(WebCore::RenderTableCell::borderAdjoiningTableStart):
(WebCore::RenderTableCell::borderAdjoiningTableEnd):

  • rendering/RenderTableRow.h:

(WebCore::RenderTableRow::borderAdjoiningTableStart):
(WebCore::RenderTableRow::borderAdjoiningTableEnd):

  • rendering/RenderTableSection.h:

(WebCore::RenderTableSection::borderAdjoiningTableStart):
(WebCore::RenderTableSection::borderAdjoiningTableEnd):
Those functions are the same at the moment to match the existing code. They
will be changed to use the proper directionality in a follow up patch.

  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::firstRowCellAdjoiningTableStart):
(WebCore::RenderTableSection::firstRowCellAdjoiningTableEnd):
Those functions return the cells that is adjoining a table edge. Due to us flipping
the cells at layout to match the section's direction, those functions will need to
account for mixed direction in determining the right cell to consider.

1:13 PM Changeset in webkit [119271] by timothy_horton@apple.com
  • 2 edits in trunk/LayoutTests

Unreviewed rebaseline of svg/css/getComputedStyle-basic for mac.

  • platform/mac/svg/css/getComputedStyle-basic-expected.txt:
1:08 PM Changeset in webkit [119270] by commit-queue@webkit.org
  • 3 edits
    4 adds in trunk

Indenting a paragraph that begins with a link 3 times breaks the paragraph into two paragraphs
​https://bugs.webkit.org/show_bug.cgi?id=87428

Patch by Shezan Baig <​shezbaig.wk@gmail.com> on 2012-06-01
Reviewed by Ryosuke Niwa.

Source/WebCore:

Fix the way lastNode (our insertion point) is updated whenever
traverseNextSibling moves up to a new parent, so that the relative
depth between the next sibling and the original start node is
maintained in the clone. The divergence in depth broke the paragraph
into two paragraphs because the next sibling was inserted outside the
blockquote that was created for the indentation.

Note that the topNode is not required anymore because it is no longer
used anywhere.

Tests: editing/execCommand/indent-nested-inlines-1.html

editing/execCommand/indent-nested-inlines-2.html

  • editing/CompositeEditCommand.cpp:

(WebCore::CompositeEditCommand::cloneParagraphUnderNewElement):

LayoutTests:

Adding two tests for indenting nested inlines.

  • editing/execCommand/indent-nested-inlines-1-expected.txt: Added.
  • editing/execCommand/indent-nested-inlines-1.html: Added.
  • editing/execCommand/indent-nested-inlines-2-expected.txt: Added.
  • editing/execCommand/indent-nested-inlines-2.html: Added.
1:00 PM Changeset in webkit [119269] by Simon Hausmann
  • 5 edits in trunk

[Qt] Use -Werror only in developer builds

Rubber-stamped by Tor Arne Vestbø.

In production builds -Werror with custom toolchains and wierd system
headers, -Werror is of no use and just creates confusion. So use it
only if Qt is configured with -developer-build.

.:

  • Source/api.pri: qt_developer_build determination moved to default_pre.prf

Tools:

  • qmake/mkspecs/features/default_pre.prf: Move qt_developer_build determination here...
  • qmake/mkspecs/features/unix/default_post.prf: ... so that we can use it here to do -Werror

only if qt_developer_build is set.

12:58 PM Changeset in webkit [119268] by fischman@chromium.org
  • 4 edits in trunk/LayoutTests

[chromium] Unskip http/tests/media/video-buffered.html
​https://bugs.webkit.org/show_bug.cgi?id=87568

Reviewed by Eric Carlson.

  • http/tests/media/video-buffered-expected.txt:
  • http/tests/media/video-buffered.html:
  • platform/chromium/test_expectations.txt:
12:57 PM Changeset in webkit [119267] by caio.oliveira@openbossa.org
  • 4 edits
    1 copy
    2 adds in trunk

[Qt] Move QObject bridge related tests from tst_qwebframe to tst_qobjectbridge
​https://bugs.webkit.org/show_bug.cgi?id=88117

Reviewed by Noam Rosenthal.

.:

  • Source/tests.pri: Add new entry for tst_qobjectbridge.

Source/WebKit/qt:

Five tests (classEnums, classConstructor, transferInvokable, findObject and
findChildren) were removed since they contained commented code since the file was
added back in 2008. The QObject bridge tests were probably inspired in similar
tests for QtScript, so many features not yet implemented were present in QtWebKit
tests but commented.

Other minor changes:

  • Moved MyEnumTestQObject near the only test function that uses it.
  • Removed unnecessary Q_INVOKABLE from setBrushProperty.
  • Removed some bits of dead / commented code.
  • tests/qobjectbridge/qobjectbridge.pro: Added.
  • tests/qobjectbridge/tst_qobjectbridge.cpp: Copied from Source/WebKit/qt/tests/qwebframe/tst_qwebframe.cpp.

Kept only the tests related to QObject bridge implementation.

  • tests/qwebframe/tst_qwebframe.cpp:

(tst_QWebFrame):
(tst_QWebFrame::init):
(tst_QWebFrame::cleanup):

12:52 PM Changeset in webkit [119266] by jochen@chromium.org
  • 2 edits in trunk/Tools

[watchlist] Add myself to loader and v8 bindings changes
​https://bugs.webkit.org/show_bug.cgi?id=88112

Reviewed by Adam Barth.

  • Scripts/webkitpy/common/config/watchlist:
12:41 PM Changeset in webkit [119265] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

Another Chromium test expectation update per the bug 88124.

  • platform/chromium/test_expectations.txt:
12:39 PM Changeset in webkit [119264] by zhajiang@rim.com
  • 2 edits in trunk/Tools

Adding Jacky Jiang to committers.py
​https://bugs.webkit.org/show_bug.cgi?id=88122

Reviewed by Rob Buis.

Adding myself to committers.py as a Committer.

  • Scripts/webkitpy/common/config/committers.py:
12:38 PM Changeset in webkit [119263] by ap@apple.com
  • 3 edits in branches/safari-536-branch/LayoutTests

Update test results after r119025

  • platform/mac/mathml/presentation/mo-stretch-expected.txt: Clearly incorrect results were landed for this test, not sure how that happened (I cannot find these wrong results anywhere in trunk history).
  • platform/mac/tables/mozilla/bugs/bug4527-expected.txt: Looks like this test was not updated with others. The only observable difference is a slightly smaller width of an input field, which matches what one could expect from the change.
12:32 PM Changeset in webkit [119262] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

Chromium test expectation update.

  • platform/chromium/test_expectations.txt:
12:32 PM Changeset in webkit [119261] by beidson@apple.com
  • 2 edits in trunk/Source/WebKit2

<rdar://problem/11335622> and ​https://bugs.webkit.org/show_bug.cgi?id=88119
REGRESSION (r99448) Zero-sized plug-ins no longer get an NPP_SetWindow call

Followup to r119260

Rubber-stamped by Anders Carlsson.

  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp:

(WebKit::NetscapePlugin::callSetWindow): Set the m_hasCalledSetWindow here...
(WebKit::NetscapePlugin::geometryDidChange): ...instead of here.

12:24 PM Changeset in webkit [119260] by beidson@apple.com
  • 3 edits in trunk/Source/WebKit2

<rdar://problem/11335622> and ​https://bugs.webkit.org/show_bug.cgi?id=88119
REGRESSION (r99448) Zero-sized plug-ins no longer get an NPP_SetWindow call

Reviewed by Oliver Hunt.

Add a flag to NetscapePlugin to track whether or not NPP_SetWindow has ever been called.
Check this flag in geometryDidChange to make sure every plug-in gets the call at least once.

"Everybody gets one. Tell him, Peter."
"Apparently everybody gets one."
"Bingo."

  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp:

(WebKit::NetscapePlugin::NetscapePlugin):
(WebKit::NetscapePlugin::geometryDidChange):

  • WebProcess/Plugins/Netscape/NetscapePlugin.h:

(NetscapePlugin):

12:00 PM Changeset in webkit [119259] by commit-queue@webkit.org
  • 7 edits in trunk

getComputedStyle for background shorthand property does not return background-origin and background-clip.
​https://bugs.webkit.org/show_bug.cgi?id=86155

Patch by Joe Thomas <​joethomas@motorola.com> on 2012-06-01
Reviewed by Tony Chang.

Added background-origin and background-clip CSS Property values to the background shorthand CSSValueList.

Source/WebCore:

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getBackgroundShorthandValue):

LayoutTests:

  • fast/backgrounds/background-shorthand-with-backgroundSize-style-expected.txt:
  • fast/backgrounds/background-shorthand-with-backgroundSize-style.html:
  • fast/css/getComputedStyle/getComputedStyle-background-shorthand-expected.txt:
  • fast/css/getComputedStyle/getComputedStyle-background-shorthand.html:
11:55 AM Changeset in webkit [119258] by pilgrim@chromium.org
  • 14 edits
    1 delete in trunk/Source

[Chromium] Call clipboard methods directly
​https://bugs.webkit.org/show_bug.cgi?id=88038

Reviewed by Adam Barth.

Part of a refactoring series. See tracking bug 82948.

Source/Platform:

  • chromium/public/WebClipboard.h:

(WebKit::WebClipboard::sequenceNumber):

Source/WebCore:

  • WebCore.gypi:
  • platform/Pasteboard.h:

(Pasteboard):

  • platform/chromium/ChromiumDataObject.cpp:

(WebCore::ChromiumDataObject::createFromPasteboard):

  • platform/chromium/ChromiumDataObjectItem.cpp:

(WebCore::ChromiumDataObjectItem::getAsFile):
(WebCore::ChromiumDataObjectItem::internalGetAsString):

  • platform/chromium/ClipboardUtilitiesChromium.cpp:

(WebCore::currentPasteboardBuffer):

  • platform/chromium/ClipboardUtilitiesChromium.h:

(WebCore):

  • platform/chromium/PasteboardChromium.cpp:

(WebCore::Pasteboard::writeSelection):
(WebCore::Pasteboard::writePlainText):
(WebCore::Pasteboard::writeURL):
(WebCore::Pasteboard::writeImage):
(WebCore::Pasteboard::writeClipboard):
(WebCore::Pasteboard::canSmartReplace):
(WebCore::Pasteboard::plainText):
(WebCore::Pasteboard::documentFragment):

  • platform/chromium/PasteboardPrivate.h: Removed.
  • platform/chromium/PlatformSupport.h:

(WebCore):
(PlatformSupport):

Source/WebKit/chromium:

  • src/AssertMatchingEnums.cpp:
  • src/PlatformSupport.cpp:

(WebCore::getCookieJar):

11:33 AM Changeset in webkit [119257] by jberlin@webkit.org
  • 2 edits in trunk/Tools

Fix Windows build.

  • TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash.cpp:
11:24 AM Changeset in webkit [119256] by commit-queue@webkit.org
  • 6 edits
    26 adds in trunk

Improve handling of legacy viewport meta tags
​https://bugs.webkit.org/show_bug.cgi?id=55874

Patch by Hugo Parente Lima <Hugo Parente Lima> on 2012-06-01
Reviewed by Adam Barth.

Source/WebCore:

We now support MobileOptimized and HandheldFriendly as well.

We set width equal to device-width for HandheldFriendly and
for MobileOptimized, the content value of MobileOptimized is
ignored and the initial-scale set to 1 to fit Android behavior.

The prioritizing is done the same way as on Windows Phone 7:

XHTML Mobile Profile found
HandheldFriendly
MobileOptimized (overrides HandheldFriendly)
Viewport (overrides all above)

Original patch by Kenneth Rohde Christiansen.

Tests: fast/viewport/viewport-legacy-handheldfriendly.html

fast/viewport/viewport-legacy-mobileoptimized-2.html
fast/viewport/viewport-legacy-mobileoptimized-3.html
fast/viewport/viewport-legacy-mobileoptimized.html
fast/viewport/viewport-legacy-ordering-1.html
fast/viewport/viewport-legacy-ordering-2.html
fast/viewport/viewport-legacy-ordering-3.html
fast/viewport/viewport-legacy-ordering-4.html
fast/viewport/viewport-legacy-ordering-5.html
fast/viewport/viewport-legacy-ordering-6.html
fast/viewport/viewport-legacy-ordering-7.html
fast/viewport/viewport-legacy-ordering-8.html
fast/viewport/viewport-legacy-ordering-9.html

  • dom/Document.cpp:

(WebCore::Document::setDocType):
(WebCore::Document::processViewport): Add an origin parameter to
tell what is changing the viewport.

  • dom/Document.h:

(Document):

  • dom/ViewportArguments.h:
  • html/HTMLMetaElement.cpp:

(WebCore::HTMLMetaElement::process):

LayoutTests:

Add tests and expected results.

  • fast/viewport/viewport-legacy-handheldfriendly-expected.txt: Added.
  • fast/viewport/viewport-legacy-handheldfriendly.html: Added.
  • fast/viewport/viewport-legacy-mobileoptimized-2-expected.txt: Added.
  • fast/viewport/viewport-legacy-mobileoptimized-2.html: Added.
  • fast/viewport/viewport-legacy-mobileoptimized-3-expected.txt: Added.
  • fast/viewport/viewport-legacy-mobileoptimized-3.html: Added.
  • fast/viewport/viewport-legacy-mobileoptimized-expected.txt: Added.
  • fast/viewport/viewport-legacy-mobileoptimized.html: Added.
  • fast/viewport/viewport-legacy-ordering-1-expected.txt: Added.
  • fast/viewport/viewport-legacy-ordering-1.html: Added.
  • fast/viewport/viewport-legacy-ordering-2-expected.txt: Added.
  • fast/viewport/viewport-legacy-ordering-2.html: Added.
  • fast/viewport/viewport-legacy-ordering-3-expected.txt: Added.
  • fast/viewport/viewport-legacy-ordering-3.html: Added.
  • fast/viewport/viewport-legacy-ordering-4-expected.txt: Added.
  • fast/viewport/viewport-legacy-ordering-4.html: Added.
  • fast/viewport/viewport-legacy-ordering-5-expected.txt: Added.
  • fast/viewport/viewport-legacy-ordering-5.html: Added.
  • fast/viewport/viewport-legacy-ordering-6-expected.txt: Added.
  • fast/viewport/viewport-legacy-ordering-6.html: Added.
  • fast/viewport/viewport-legacy-ordering-7-expected.txt: Added.
  • fast/viewport/viewport-legacy-ordering-7.html: Added.
  • fast/viewport/viewport-legacy-ordering-8-expected.txt: Added.
  • fast/viewport/viewport-legacy-ordering-8.html: Added.
  • fast/viewport/viewport-legacy-ordering-9-expected.txt: Added.
  • fast/viewport/viewport-legacy-ordering-9.html: Added.
11:10 AM Changeset in webkit [119255] by tony@chromium.org
  • 43 edits in trunk

rename -webkit-flex-order to -webkit-order
​https://bugs.webkit.org/show_bug.cgi?id=88104

Reviewed by Ojan Vafai.

Source/WebCore:

This recently changed in the spec:
​http://dev.w3.org/csswg/css3-flexbox/#order-property

No new tests, just updated existing results.

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):

  • css/CSSProperty.cpp:

(WebCore::CSSProperty::isInheritedProperty):

  • css/CSSPropertyNames.in:
  • css/StyleBuilder.cpp:

(WebCore::StyleBuilder::StyleBuilder):

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::collectMatchingRulesForList):

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::OrderIterator::OrderIterator):
(WebCore::RenderFlexibleBox::OrderIterator::next):
(WebCore::RenderFlexibleBox::layoutBlock):
(WebCore::RenderFlexibleBox::repositionLogicalHeightDependentFlexItems):
(WebCore::RenderFlexibleBox::layoutFlexItems):
(WebCore::RenderFlexibleBox::computeMainAxisPreferredSizes):
(WebCore::RenderFlexibleBox::computeNextFlexLine):
(WebCore::RenderFlexibleBox::packFlexLines):
(WebCore::RenderFlexibleBox::alignChildren):
(WebCore::RenderFlexibleBox::flipForRightToLeftColumn):
(WebCore::RenderFlexibleBox::flipForWrapReverse):

  • rendering/RenderFlexibleBox.h:
  • rendering/style/RenderStyle.h:
  • rendering/style/StyleFlexibleBoxData.cpp:

(WebCore::StyleFlexibleBoxData::StyleFlexibleBoxData):
(WebCore::StyleFlexibleBoxData::operator==):

  • rendering/style/StyleFlexibleBoxData.h:

(StyleFlexibleBoxData):

  • rendering/style/StyleRareNonInheritedData.cpp:

(WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
(WebCore::StyleRareNonInheritedData::operator==):

  • rendering/style/StyleRareNonInheritedData.h:

(StyleRareNonInheritedData):

LayoutTests:

Just a find and replace for the new property name.

  • css3/flexbox/css-properties-expected.txt:
  • css3/flexbox/css-properties.html:
  • css3/flexbox/flex-order.html:
  • fast/css/getComputedStyle/computed-style-expected.txt:
  • fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/chromium-linux-x86/svg/css/getComputedStyle-basic-expected.txt:
  • platform/chromium-linux/svg/css/getComputedStyle-basic-expected.txt:
  • platform/chromium-mac-leopard/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/chromium-mac-leopard/svg/css/getComputedStyle-basic-expected.txt:
  • platform/chromium-mac-snowleopard/svg/css/getComputedStyle-basic-expected.txt:
  • platform/chromium-mac/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/chromium-mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/chromium-mac/svg/css/getComputedStyle-basic-expected.txt:
  • platform/chromium-win-vista/svg/css/getComputedStyle-basic-expected.txt:
  • platform/chromium-win-xp/svg/css/getComputedStyle-basic-expected.txt:
  • platform/chromium-win/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/chromium-win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt:
  • platform/gtk/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/gtk/svg/css/getComputedStyle-basic-expected.txt:
  • platform/mac/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/mac/svg/css/getComputedStyle-basic-expected.txt:
  • platform/qt/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/qt/svg/css/getComputedStyle-basic-expected.txt:
  • platform/win/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • svg/css/getComputedStyle-basic-expected.txt:
10:50 AM Changeset in webkit [119254] by fmalita@chromium.org
  • 2 edits
    1 copy
    1 move
    2 adds in trunk/LayoutTests

[Chromium] Unreviewed. Adding Win and Mac baselines after r119241.

Patch by Florin Malita <​fmalita@chromium.org> on 2012-06-01

  • platform/chromium-mac/svg/repaint/text-mask-update-expected.png: Added.
  • platform/chromium-mac/svg/repaint/text-mask-update-expected.txt: Copied from LayoutTests/platform/chromium-linux/svg/repaint/text-mask-update-expected.txt.
  • platform/chromium-win/svg/repaint/text-mask-update-expected.png: Added.
  • platform/chromium-win/svg/repaint/text-mask-update-expected.txt: Renamed from LayoutTests/platform/chromium-linux/svg/repaint/text-mask-update-expected.txt.
  • platform/chromium/test_expectations.txt:
10:31 AM Changeset in webkit [119253] by jberlin@webkit.org
  • 5 edits
    2 adds in trunk/LayoutTests

[Win] 9 plugin tests fail/time out
​https://bugs.webkit.org/show_bug.cgi?id=88107

Skip the ones that time out and add/update platform-specific results for the the ones that
fail to get the bots greener.

  • platform/win/Skipped:
  • platform/win/plugins/get-value-netscape-window-expected.txt:
  • platform/win/plugins/netscape-dom-access-and-reload-expected.txt: Added.
  • platform/win/plugins/npn-invalidate-rect-invalidates-window-expected.txt:
  • platform/win/plugins/window-geometry-initialized-before-set-window-expected.txt:
  • platform/win/plugins/geturlnotify-during-document-teardown-expected.txt
10:26 AM Changeset in webkit [119252] by zeno.albisser@nokia.com
  • 2 edits in trunk/Source/WebCore

Unreviewed build fix after r119247.

Do not include TextureMapperGL.h when not building
with GRAPHICS_SURFACE.

  • platform/graphics/texmap/TextureMapperBackingStore.cpp:
10:16 AM Changeset in webkit [119251] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[WK2] WebLayerTreeRenderer::setContentsSize called synchronously
​https://bugs.webkit.org/show_bug.cgi?id=88091

Patch by Dinu Jacob <​dinu.jacob@nokia.com> on 2012-06-01
Reviewed by Noam Rosenthal.

Do not call WebLayerTreeRenderer::setContentsSize synchronously
from LayerTreeHostProxy.

  • UIProcess/LayerTreeHostProxy.cpp:

(WebKit::LayerTreeHostProxy::setContentsSize):

10:09 AM Changeset in webkit [119250] by jberlin@webkit.org
  • 2 edits in trunk/Tools

Windows WK2 MouseMoveAfterCrash API test failing
​https://bugs.webkit.org/show_bug.cgi?id=69982

Disable the test on Windows to get the bots greener.

  • TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash.cpp:

(TestWebKitAPI::TEST):

10:05 AM Changeset in webkit [119249] by mario@webkit.org
  • 3 edits
    4 adds in trunk/Source/WebCore

[GTK] Add a new and reusable Geoclue-based geolocation provider in WebCore
​https://bugs.webkit.org/show_bug.cgi?id=87800

Reviewed by Carlos Garcia Campos.

Added new and reusable Geoclue-based geolocation provider to WebCore.

  • GNUmakefile.am:
  • GNUmakefile.list.am:
  • platform/geoclue/GeolocationProviderGeoclue.cpp: Added.

(getPositionCallback):
(positionChangedCallback):
(GeolocationProviderGeoclue::GeolocationProviderGeoclue):
(GeolocationProviderGeoclue::~GeolocationProviderGeoclue):
(GeolocationProviderGeoclue::startUpdating):
(GeolocationProviderGeoclue::stopUpdating):
(GeolocationProviderGeoclue::setEnableHighAccuracy):
(GeolocationProviderGeoclue::setGeoclueClient):
(GeolocationProviderGeoclue::setGeocluePosition):
(GeolocationProviderGeoclue::updateClientRequirements):
(GeolocationProviderGeoclue::positionChanged):
(GeolocationProviderGeoclue::errorOccured):

  • platform/geoclue/GeolocationProviderGeoclue.h: Added.

(WebCore):
(GeolocationProviderGeoclue):

  • platform/geoclue/GeolocationProviderGeoclueClient.h: Added.

(WebCore):
(GeolocationProviderGeoclueClient):

10:04 AM Changeset in webkit [119248] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[Qt] Remove deprecated Q_GLOBAL_STATIC_WITH_INITIALIZER
​https://bugs.webkit.org/show_bug.cgi?id=88100

Patch by Thiago Marcos P. Santos <​thiago.santos@intel.com> on 2012-06-01
Reviewed by Tor Arne Vestbø.

It will be deprecated on Qt5.

  • platform/text/qt/TextBreakIteratorInternalICUQt.cpp:

(WebCore):

10:02 AM Changeset in webkit [119247] by zeno.albisser@nokia.com
  • 7 edits in trunk/Source/WebCore

Make TextureMapper work with GraphicsSurface.
​https://bugs.webkit.org/show_bug.cgi?id=87738

Add TextureMapperSurfaceBackingStore, a new backing store
that allows to import textures from a GraphicsSurface.
On Mac the GraphicsSurface is backed by an IOSurface
which must be used with a GL_TEXTURE_RECTANGLE_ARB texture.
Therefore it is also necessary to add new shader programs
for directly painting these textures on screen.

Reviewed by Noam Rosenthal.

  • platform/graphics/texmap/TextureMapperBackingStore.cpp:

Add a new TextureMapperBackingStore implementation that can directly
reuse textures as they are being passed from the GraphicsSurface.
(WebCore::TextureMapperSurfaceBackingStore::setGraphicsSurface):
(WebCore::TextureMapperSurfaceBackingStore::texture):
(WebCore::TextureMapperSurfaceBackingStore::paintToTextureMapper):

  • platform/graphics/texmap/TextureMapperBackingStore.h:

(GraphicsSurfaceData):
(WebCore::GraphicsSurfaceData::setSurface):
(WebCore::GraphicsSurfaceData::GraphicsSurfaceData):
(TextureMapperSurfaceBackingStore):
(WebCore::TextureMapperSurfaceBackingStore::create):
(WebCore::TextureMapperSurfaceBackingStore::~TextureMapperSurfaceBackingStore):
(WebCore::TextureMapperSurfaceBackingStore::TextureMapperSurfaceBackingStore):

  • platform/graphics/texmap/TextureMapperGL.cpp:

Add a drawing function for textures of type GL_TEXTURE_RECTANGLE_ARB.
(WebCore::TextureMapperGL::drawTextureRectangleARB):

  • platform/graphics/texmap/TextureMapperShaderManager.cpp:

(WebCore::TextureMapperShaderManager::getShaderProgram):
(WebCore::TextureMapperShaderProgramSimple::create):
(WebCore::TextureMapperShaderProgramSimple::initialize):
(WebCore::TextureMapperShaderProgramSolidColor::create):
(WebCore::TextureMapperShaderProgramSolidColor::initialize):
(WebCore::TextureMapperShaderProgramRectSimple::create):
(WebCore::TextureMapperShaderProgramRectSimple::fragmentShaderSource):
(WebCore::TextureMapperShaderProgramOpacityAndMask::create):
(WebCore::TextureMapperShaderProgramOpacityAndMask::initialize):
(WebCore::TextureMapperShaderProgramRectOpacityAndMask::create):
(WebCore::TextureMapperShaderProgramRectOpacityAndMask::fragmentShaderSource):

  • platform/graphics/texmap/TextureMapperShaderManager.h:

Add new shader programs that can be used with GL_TEXTURE_RECTANGLE_ARB textures.
This is mainly necessary, because this type of texture uses non-normalized coordinates.
Further move the calls to initializeProgram() from the constructor into a separate
initialize() function, as initializeProgram() calls vertexShaderSource() (and friends)
and we should not call virtual functions in the constructor.
(WebCore::TextureMapperShaderProgram::initialize):
(TextureMapperShaderProgramSimple):
(WebCore::TextureMapperShaderProgramSimple::TextureMapperShaderProgramSimple):
(TextureMapperShaderProgramRectSimple):
(WebCore::TextureMapperShaderProgramRectSimple::TextureMapperShaderProgramRectSimple):
(TextureMapperShaderProgramOpacityAndMask):
(WebCore::TextureMapperShaderProgramOpacityAndMask::TextureMapperShaderProgramOpacityAndMask):
(TextureMapperShaderProgramRectOpacityAndMask):
(WebCore::TextureMapperShaderProgramRectOpacityAndMask::TextureMapperShaderProgramRectOpacityAndMask):
(TextureMapperShaderProgramSolidColor):
(WebCore::TextureMapperShaderProgramSolidColor::TextureMapperShaderProgramSolidColor):

9:57 AM Changeset in webkit [119246] by jberlin@webkit.org
  • 2 edits in trunk/LayoutTests

Skip some plugin tests that crash/assert on Windows.

  • platform/win/Skipped:
9:50 AM Changeset in webkit [119245] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[Qt][WK2] Set QWebKitTest::isScalable default as false
​https://bugs.webkit.org/show_bug.cgi?id=88095

Patch by Dinu Jacob <​dinu.jacob@nokia.com> on 2012-06-01
Reviewed by Tor Arne Vestbø.

Set QWebKitTest::isScalable default as false

  • UIProcess/API/qt/qwebkittest.cpp:

(QWebKitTest::isScalable):

9:41 AM Changeset in webkit [119244] by pdr@google.com
  • 2 edits
    2 copies in branches/chromium/1084

Merge 117365 - Crash if SVG gradient stop has display: none set

9:35 AM Changeset in webkit [119243] by commit-queue@webkit.org
  • 19 edits in trunk

[EFL] EFL port does not enable WEB_INTENTS_TAG flag
​https://bugs.webkit.org/show_bug.cgi?id=86866

Patch by Christophe Dumez <Christophe Dumez> on 2012-06-01
Reviewed by Adam Barth.

.:

Enable WEB_INTENTS_TAG flag by default on EFL port.

  • Source/cmake/OptionsEfl.cmake:
  • Source/cmake/WebKitFeatures.cmake:
  • Source/cmakeconfig.h.cmake:

Source/WebCore:

Fix compilation error when WEB_INTENTS_TAG flag is enabled.
HTMLElement::insertedInto() takes a ContainerNode* in argument, not a
Node*.

Test: webintents/intent-tag.html

  • CMakeLists.txt:
  • html/HTMLIntentElement.cpp:

(WebCore::HTMLIntentElement::insertedInto):

  • html/HTMLIntentElement.h:

(HTMLIntentElement):

Source/WebKit/efl:

Implement registerIntentService() in EFL's FrameLoaderClient.
Emit a "intent,service,register" signal on the frame when a new Web
Intent service registers.

  • WebCoreSupport/FrameLoaderClientEfl.cpp:

(WebCore):
(WebCore::FrameLoaderClientEfl::registerIntentService):

  • WebCoreSupport/FrameLoaderClientEfl.h:

(FrameLoaderClientEfl):

  • ewk/ewk_frame.cpp:

(ewk_frame_intent_service_register):

  • ewk/ewk_frame.h:
  • ewk/ewk_frame_private.h:

Tools:

Catch new "intent,service,register" signal on the frame and print out
information about the Web Intent service in EFL's DumpRenderTree.

  • DumpRenderTree/efl/DumpRenderTreeChrome.cpp:

(DumpRenderTreeChrome::createView):
(DumpRenderTreeChrome::onFrameCreated):
(DumpRenderTreeChrome::onFrameIntentServiceRegistration):

  • DumpRenderTree/efl/DumpRenderTreeChrome.h:

(DumpRenderTreeChrome):

LayoutTests:

Unskip webintents/intent-tag.html now that the WEB_INTENTS_TAG flag is
enabled by default on EFL port.

  • platform/efl/test_expectations.txt:
9:19 AM Changeset in webkit [119242] by commit-queue@webkit.org
  • 7 edits in trunk

[cairo] Pixel artifacts can be seen on reflections
​https://bugs.webkit.org/show_bug.cgi?id=85483

Source/WebCore:

Antialiased clipping in the simple rectangular clip method
leads to edge artifacts when transformations are applied to the layer.
Explicitly disabling antialiased clipping for this function solves this issue.
Comparing Cairo GraphicsContext to Qt and Skia GC, it seems that these
backends do not expect the platform context to clip antialiased in this
case either.

Patch by Dominik Röttsches <​dominik.rottsches@intel.com> on 2012-06-01
Reviewed by Martin Robinson.

No new tests, covered by fast/css/transformed-mask.html.

  • platform/graphics/cairo/GraphicsContextCairo.cpp:

(WebCore::GraphicsContext::clip):

LayoutTests:

Patch by Dominik Röttsches <​dominik.rottsches@intel.com> on 2012-06-01
Reviewed by Martin Robinson.

Rebaselining the relevant test case for GTK and EFL.

  • platform/efl/fast/css/transformed-mask-expected.png:
  • platform/efl/fast/css/transformed-mask-expected.txt:
  • platform/efl/test_expectations.txt:
  • platform/gtk/fast/css/transformed-mask-expected.png:
9:03 AM Changeset in webkit [119241] by fmalita@chromium.org
  • 5 edits
    3 adds in trunk

​http://shinydemos.com/clock/ doesn't seem to work
​https://bugs.webkit.org/show_bug.cgi?id=79682

Reviewed by Nikolas Zimmermann.

Source/WebCore:

Test: svg/repaint/text-mask-update.svg

Currently, parent resources are not invalidated when SVGInlineText nodes
are added or removed. Adjusting SVGResourcesCache::clientWasAddedToTree()
and SVGResourcesCache::clientWillBeRemovedFromTree() to cover this case.

  • rendering/svg/SVGResourcesCache.cpp:

(WebCore::SVGResourcesCache::clientWasAddedToTree):
(WebCore::SVGResourcesCache::clientWillBeRemovedFromTree):

LayoutTests:

  • platform/chromium-linux/svg/repaint/text-mask-update-expected.png: Added.
  • platform/chromium-linux/svg/repaint/text-mask-update-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
  • platform/mac/test_expectations.txt:
  • svg/repaint/text-mask-update.svg: Added.
9:03 AM Changeset in webkit [119240] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

The ChangeLog parser cannot handle reviewers with initials in their name
​https://bugs.webkit.org/show_bug.cgi?id=87864

Patch by Martin Robinson <​mrobinson@igalia.com> on 2012-06-01
Reviewed by Ryosuke Niwa.

Add support in the ChangeLog parser for reviewer names that have
initials in them.

  • Scripts/webkitpy/common/checkout/changelog.py:

(ChangeLogEntry): Add a new group of regular expressions that need a backreference
in the replacement string. This allows for matching the word characters before a
period, without totally throwing them away.
(ChangeLogEntry._parse_reviewer_text): Use the new regular expression.

  • Scripts/webkitpy/common/checkout/changelog_unittest.py:

(test_fuzzy_reviewer_match_initial): Add a test for a reviewer name that has an initial.

9:00 AM Changeset in webkit [119239] by commit-queue@webkit.org
  • 7 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Add end editing handling into AutofillManager
​https://bugs.webkit.org/show_bug.cgi?id=88071

Patch by Jonathan Dong <Jonathan Dong> on 2012-06-01
Reviewed by Rob Buis.

RIM PR: 160857
Implemented EditorClientBlackBerry::textFieldDidEndEditing
to notify AutofillManager to send the dismissing autofill
dialog notification to webpage client.

No new tests since there is no behavior changes.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::notifyDismissAutofillDialog):
(WebKit):

  • Api/WebPageClient.h:
  • Api/WebPage_p.h:

(WebPagePrivate):

  • WebCoreSupport/AutofillManager.cpp:

(WebCore::AutofillManager::textFieldDidEndEditing):
(WebCore):

  • WebCoreSupport/AutofillManager.h:

(AutofillManager):

  • WebCoreSupport/EditorClientBlackBerry.cpp:

(WebCore::EditorClientBlackBerry::textFieldDidEndEditing):

8:56 AM Changeset in webkit [119238] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/efl

[EFL] ewk_intent_data_get() is not needed and can be removed
​https://bugs.webkit.org/show_bug.cgi?id=88072

Patch by Christophe Dumez <Christophe Dumez> on 2012-06-01
Reviewed by Adam Barth.

Remove ewk_intent_data_get() method from Ewk_Intent. Intent data is
serialized and does not need to be publicly exposed. The browser only
needs action and type to match with services.

  • ewk/ewk_intent.cpp:

(_Ewk_Intent):
(ewk_intent_action_get):
(ewk_intent_type_get):
(ewk_intent_service_get):
(ewk_intent_free):

  • ewk/ewk_intent.h:
8:49 AM Changeset in webkit [119237] by commit-queue@webkit.org
  • 18 edits in trunk

[EFL] EFL's LayoutTestController needs to implement deliverWebIntent
​https://bugs.webkit.org/show_bug.cgi?id=86865

Patch by Christophe Dumez <Christophe Dumez> on 2012-06-01
Reviewed by Adam Barth.

Source/WebKit:

Add "${WEBCORE_DIR}/dom/default" to include directories in
CMakeLists.txt.

  • CMakeLists.txt:

Source/WebKit/efl:

Add method on Ewk_Frame to deliver an intent.
Add helper function to DumpRenderTreeSupportEfl to deliver a Web
Intent.

  • WebCoreSupport/DumpRenderTreeSupportEfl.cpp:

(DumpRenderTreeSupportEfl::deliverWebIntent):

  • WebCoreSupport/DumpRenderTreeSupportEfl.h:
  • ewk/ewk_frame.cpp:

(ewk_frame_intent_deliver):

  • ewk/ewk_frame.h:

Tools:

Add deliverWebIntent method to LayoutTestController and provide
implementation for EFL port.

  • DumpRenderTree/LayoutTestController.cpp:

(deliverWebIntentCallback):
(LayoutTestController::staticFunctions):

  • DumpRenderTree/LayoutTestController.h:

(LayoutTestController):

  • DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:

(LayoutTestController::deliverWebIntent):

  • DumpRenderTree/efl/LayoutTestControllerEfl.cpp:

(LayoutTestController::deliverWebIntent):

  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:

(LayoutTestController::deliverWebIntent):

  • DumpRenderTree/mac/LayoutTestControllerMac.mm:

(LayoutTestController::deliverWebIntent):

  • DumpRenderTree/win/LayoutTestControllerWin.cpp:

(LayoutTestController::deliverWebIntent):

  • DumpRenderTree/wx/LayoutTestControllerWx.cpp:

(LayoutTestController::deliverWebIntent):

LayoutTests:

Unskip webintents/web-intents-delivery.html now that Web intent
delivery is implemented on EFL port.

  • platform/efl/test_expectations.txt:
8:47 AM Changeset in webkit [119236] by zhajiang@rim.com
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Bridge Apps - Apps do not redraw correctly after orientation change
​https://bugs.webkit.org/show_bug.cgi?id=88033

Reviewed by Rob Buis.
Patch by Jacky Jiang <​zhajiang@rim.com>

PR: 142961
When bridge apps were in carousel mode, the backing store was inactive
as its memory had been released. When we rotated the device, we would
call WebPagPrivate:setViewportSize and resume screen and backing store
to render and blit visible contents. As backing store was inactive and
the window usage was GLES2Usage, we were neither doing backing store
rendering nor direct rendering. Therefore, we drew layers directly
based on the invalid texture contents when blitting contents if
accelerated compositing was enabled.
This patch forces compositing mode to let the accelerated compositing
layer take care of the rendering which can update texture contents
before drawing when backing store is inactive and is openGL compositing.

Reviewed internally by George Staikos and Arvid Nilsson.

  • Api/BackingStore.cpp:

(BlackBerry::WebKit::BackingStorePrivate::resumeScreenAndBackingStoreUpdates):

8:45 AM Changeset in webkit [119235] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Don't set scroll position twice in HistoryController::restoreScrollPositionAndViewState
​https://bugs.webkit.org/show_bug.cgi?id=88068

Patch by John Mellor <​johnme@chromium.org> on 2012-06-01
Reviewed by Adam Barth.

In the case where pageScaleFactor changes, we were calling
setScrollPosition with an incorrect scroll position (i.e. a scroll
position scaled by the pageScaleFactor we hadn't yet applied), then
fixing it by setting the pageScaleFactor and scroll position together,
overwriting the old scroll position. It's cleaner to just set the
pageScaleFactor and scroll position together.

No new tests as this isn't expected to change the ultimate behavior, just clean up how it happens.

  • loader/HistoryController.cpp:

(WebCore::HistoryController::restoreScrollPositionAndViewState):

8:43 AM Changeset in webkit [119234] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit2

[Qt] Remove QtViewportInteractionEngine::pageItemSizeChanged.
​https://bugs.webkit.org/show_bug.cgi?id=88082

Patch by Allan Sandfeld Jensen <​allan.jensen@nokia.com> on 2012-06-01
Reviewed by Kenneth Rohde Christiansen.

The function was causing flickering, and after testing it was verified
that it was no longer needed either.

  • UIProcess/qt/QtViewportInteractionEngine.cpp:

(WebKit::QtViewportInteractionEngine::QtViewportInteractionEngine):

  • UIProcess/qt/QtViewportInteractionEngine.h:

(QtViewportInteractionEngine):

8:38 AM Changeset in webkit [119233] by commit-queue@webkit.org
  • 4 edits in trunk

Unreviewed, rolling out r119228.
​http://trac.webkit.org/changeset/119228
​https://bugs.webkit.org/show_bug.cgi?id=88098

Caused the EFL debug bot to crash. (Requested by rakuco on
#webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-06-01

Source/WebKit/efl:

  • ewk/ewk_main.cpp:

(ewk_init):

LayoutTests:

  • platform/efl/test_expectations.txt:
8:34 AM Changeset in webkit [119232] by commit-queue@webkit.org
  • 7 edits in trunk/Source

[Qt] Remove deprecated to/fromAscii()
​https://bugs.webkit.org/show_bug.cgi?id=88086

Patch by Thiago Marcos P. Santos <​thiago.santos@intel.com> on 2012-06-01
Reviewed by Simon Hausmann.

Replacing to/fromAscii with to/fromLatin1 since it
is deprecated on Qt5.

Source/WebCore:

  • bridge/qt/qt_class.cpp:

(JSC::Bindings::QtClass::fallbackObject):

  • platform/network/qt/ResourceRequestQt.cpp:

(WebCore::ResourceRequest::toNetworkRequest):

Source/WebKit/qt:

  • WebCoreSupport/InspectorClientQt.cpp:

(WebCore):

  • WebCoreSupport/InspectorServerQt.cpp:

(WebCore::InspectorServerRequestHandlerQt::tcpReadyRead):

  • tests/qdeclarativewebview/tst_qdeclarativewebview.cpp:

(tst_QDeclarativeWebView::settings):

8:21 AM Changeset in webkit [119231] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit2

[Qt][WK2] Contents not rendered in MiniBrowser for some pages
​https://bugs.webkit.org/show_bug.cgi?id=87922

Patch by Dinu Jacob <​dinu.jacob@nokia.com> on 2012-06-01
Reviewed by Kenneth Rohde Christiansen.

Set drawing area visible contents rect if new visible contents rect is different from
the previous one.

  • UIProcess/qt/QtViewportInteractionEngine.cpp:

(WebKit::QtViewportInteractionEngine::informVisibleContentChange):

  • UIProcess/qt/QtViewportInteractionEngine.h:

(QtViewportInteractionEngine):

7:36 AM Changeset in webkit [119230] by Csaba Osztrogonác
  • 2 edits
    2 adds in trunk/LayoutTests

[Qt] Unreviewed gardening.

  • platform/qt-5.0-wk2/Skipped:
  • platform/qt-5.0-wk2/compositing/layer-creation/fixed-position-and-transform-expected.txt: Added.
  • platform/qt-5.0-wk2/compositing/layer-creation/fixed-position-under-transform-expected.txt: Added.
7:27 AM Changeset in webkit [119229] by apavlov@chromium.org
  • 4 edits in trunk/LayoutTests

Web Inspector: Prepare styles-new-API.html results format for a more complex CSS model
​https://bugs.webkit.org/show_bug.cgi?id=88090

Reviewed by Antti Koivisto.

  • inspector/styles/resources/styles-new-API.css:
  • inspector/styles/styles-new-API-expected.txt:
  • inspector/styles/styles-new-API.html:
7:23 AM Changeset in webkit [119228] by commit-queue@webkit.org
  • 4 edits in trunk

[EFL] [DRT] editing/execCommand/paste-and-match-style-event.html crashes
​https://bugs.webkit.org/show_bug.cgi?id=86961

Patch by Christophe Dumez <Christophe Dumez> on 2012-06-01
Reviewed by Csaba Osztrogonác.

Source/WebKit/efl:

Call ecore_x_init() in ewk_init() to initialize the ecore_x library.
This avoids crashing upong calling WebCore::systemBeep() which uses
ecore_x_bell() internally.

  • ewk/ewk_main.cpp:

(ewk_init):

LayoutTests:

Unskip editing/execCommand/paste-and-match-style-event.html now that
it is no longer crashing thanks to ecore_x library init.

  • platform/efl/test_expectations.txt:
7:14 AM Changeset in webkit [119227] by mitz@apple.com
  • 4 edits
    2 adds in trunk

Layout not updated after setting -webkit-line-clamp to none
​https://bugs.webkit.org/show_bug.cgi?id=88049

Reviewed by Abhishek Arya.

Source/WebCore:

Test: fast/flexbox/line-clamp-removed-dynamically.html

  • rendering/RenderDeprecatedFlexibleBox.cpp:

(WebCore::RenderDeprecatedFlexibleBox::styleWillChange): Added. Calls clearLineClamp if
line-clamp will change to none.
(WebCore::RenderDeprecatedFlexibleBox::clearLineClamp): Added. Marks possibly-clamped
children for layout and clears truncation from blocks.

  • rendering/RenderDeprecatedFlexibleBox.h:

LayoutTests:

  • fast/flexbox/line-clamp-removed-dynamically-expected.html: Added.
  • fast/flexbox/line-clamp-removed-dynamically.html: Added.
6:53 AM Changeset in webkit [119226] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Unreviewed, rolling out r119213.
​http://trac.webkit.org/changeset/119213
​https://bugs.webkit.org/show_bug.cgi?id=88084

This patch broke two tests on all platform except Chromium.
The authors are unavailable. (Requested by zherczeg on
#webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-06-01

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::collectMatchingRulesForList):

6:51 AM Changeset in webkit [119225] by kkristof@inf.u-szeged.hu
  • 5 edits in trunk/Source/WebCore

Unreviewed, rolling out r119219.
​http://trac.webkit.org/changeset/119219
​https://bugs.webkit.org/show_bug.cgi?id=88088

This patch broke two tests on GTK/Qt. The authors are
unavailable. (Requested by kkristof on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-06-01

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::closeAndRemoveChild):
(WebCore::FrameLoader::detachFromParent):

  • page/Frame.cpp:

(WebCore::Frame::willDetachPage):

  • page/Frame.h:

(Frame):
(WebCore::Frame::detachFromPage):
(WebCore):

  • page/Page.cpp:

(WebCore::Page::~Page):

6:47 AM Changeset in webkit [119224] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: Add Closure compiler annotations to WorkerConsole
​https://bugs.webkit.org/show_bug.cgi?id=88073

Patch by Alexei Filippov <​alexeif@chromium.org> on 2012-06-01
Reviewed by Yury Semikhatsky.

  • inspector/front-end/HeapSnapshotWorker.js:

(WebInspector.WorkerConsole.prototype.log):
(WebInspector.WorkerConsole.prototype.error):
(WebInspector.WorkerConsole.prototype.info):

5:57 AM Changeset in webkit [119223] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/efl

[EFL] New signals in ewk_view to enable global history delegate functionality
​https://bugs.webkit.org/show_bug.cgi?id=86343

Patch by Mikhail Pozdnyakov <​mikhail.pozdnyakov@intel.com> on 2012-06-01
Reviewed by Kenneth Rohde Christiansen.

Global history delegate is an interface for WebKit clients to manage their own global history store.
The new ewk_view signals do the following:
1) report that a navigation happened within the view and give the navigation details.
2) report that view performed a client redirect and give source and destination uris.
3) report that view performed a server redirect and give source and destination uris.

  • WebCoreSupport/FrameLoaderClientEfl.cpp:

(WebCore::FrameLoaderClientEfl::updateGlobalHistoryRedirectLinks): implementation added.
(WebCore::FrameLoaderClientEfl::updateGlobalHistory): implementation added.

  • ewk/ewk_view.h: Added new signals and data types.
5:52 AM Changeset in webkit [119222] by vestbo@webkit.org
  • 2 edits in trunk/Source/WTF

[Qt] Save one copy when going from 8-bit WTF::String to QString

Asking for characters() of an 8-bit string will make a 16-bit copy internally
in WTF::String. Since we're going to copy the data to QStringData anyways, which
is 16-bit, we can do the conversion ourselves and save one copy.

Reviewed by Simon Hausmann.

5:50 AM Changeset in webkit [119221] by Csaba Osztrogonác
  • 3 edits in trunk/LayoutTests

[Qt] Unreviewed gardening, skip new failing and crashing tests.

  • platform/qt-5.0-wk2/Skipped:
  • platform/qt/Skipped:
5:32 AM Changeset in webkit [119220] by kenneth@webkit.org
  • 6 edits in trunk/Source/WebKit2

[Qt] Move suspension to QtViewportInteractionEngine
​https://bugs.webkit.org/show_bug.cgi?id=88078

Reviewed by Simon Hausmann.

Next step is to take care of visibility changes.

  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewFlickablePrivate::QQuickWebViewFlickablePrivate):
(QQuickWebViewFlickablePrivate::onComponentComplete):

  • UIProcess/API/qt/qquickwebview_p.h:
  • UIProcess/API/qt/qquickwebview_p_p.h:

(QQuickWebViewPrivate):
(QQuickWebViewFlickablePrivate):

  • UIProcess/qt/QtViewportInteractionEngine.cpp:

(WebKit::ViewportUpdateDeferrer::ViewportUpdateDeferrer):
(WebKit::ViewportUpdateDeferrer::~ViewportUpdateDeferrer):
(WebKit::QtViewportInteractionEngine::suspendPageContent):
(WebKit):
(WebKit::QtViewportInteractionEngine::resumePageContent):

  • UIProcess/qt/QtViewportInteractionEngine.h:

(QtViewportInteractionEngine):

5:30 AM Changeset in webkit [119219] by morrita@google.com
  • 5 edits in trunk/Source/WebCore

Frame::willDetachPage() shouldn't be called more than once.
​https://bugs.webkit.org/show_bug.cgi?id=88056

Reviewed by Ryosuke Niwa.

This change moved willDetachPage() to private and calls it from
detachFromParent(). Also, it checks m_page and call
willDetachPage() only once, if m_page is available.

No new tests. Covered by existing suites.

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::closeAndRemoveChild):
(WebCore::FrameLoader::detachFromParent):

  • page/Frame.cpp:

(WebCore::Frame::detachFromPage):
(WebCore):
(WebCore::Frame::willDetachPage):

  • page/Frame.h:

(Frame):

  • page/Page.cpp:

(WebCore::Page::~Page):

5:26 AM Changeset in webkit [119218] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[Qt][W2] Qml Error in ViewportInfoItem.qml in MiniBrowser
​https://bugs.webkit.org/show_bug.cgi?id=87999

Patch by Dinu Jacob <​dinu.jacob@nokia.com> on 2012-06-01
Reviewed by Kenneth Rohde Christiansen.

Return default viewport attributes rather than invalid QVariant.

  • UIProcess/API/qt/qwebkittest.cpp:

(QWebKitTest::contentsScale):
(QWebKitTest::devicePixelRatio):
(QWebKitTest::initialScale):
(QWebKitTest::minimumScale):
(QWebKitTest::maximumScale):
(QWebKitTest::isScalable):
(QWebKitTest::layoutSize):

5:25 AM Changeset in webkit [119217] by vestbo@webkit.org
  • 4 edits in trunk/Source/WTF

[Qt] Make conversion from QString to WTF::String (and back again) ~free

​https://bugs.webkit.org/show_bug.cgi?id=87847

Instead of copying the QString data when converting to a WTF::String we
make the WTF::String adopt the QString data by introducing a new buffer
ownership type, and pointing the internal WTF::StringImpl 16-bit data
member to the string data managed by QStringData.

We make sure to reference the QStringData when adopting, so that the
data will stay alive, and then dereference it when the WTF::StringImpl
is deleted, which will free the QStringData (either straight away, if
we're the only one holding a reference still, or later, when the ref
count goes to 0).

In the case of going back from a WTF::String to a QString we can cheat
a bit (avoid a copy), if we know that the WTF::String was adopted from
a QString, since it's then just a matter of having the QString adopt
the existing QStringData (just like a regular QString copy).

If the WTF::String buffer is not owned by QStringData, eg a regular
8-bit or 16-bit string/substring, we have to fall back to copying,
as before (though there are potential optimization tricks we can
apply here later on).

Reviewed by Gavin Barraclough.

  • wtf/qt/StringQt.cpp:
  • wtf/text/StringImpl.cpp:
  • wtf/text/StringImpl.h:
5:21 AM Changeset in webkit [119216] by pierre.rossi@gmail.com
  • 4 edits in trunk

[Qt] Support drawing a pattern with a translation.
​https://bugs.webkit.org/show_bug.cgi?id=87025

Source/WebCore:

Drawing an SVG pattern that has its x or y attribute set
works by setting a transform on the Pattern.
We would ignore this by only taking into account the texture and
target rect.

Reviewed by Kenneth Rohde Christiansen.

test: svg/W3C-SVG-1.1-SE/pservers-pattern-04-f.svg

  • platform/graphics/qt/GraphicsContextQt.cpp:

(WebCore::drawRepeatPattern): refactored to take into account the translation set on the brush.
(WebCore::GraphicsContext::fillRect):

LayoutTests:

Reviewed by Kenneth Rohde Christiansen.

  • platform/qt-5.0/svg/W3C-SVG-1.1-SE/pservers-pattern-04-f-expected.png: fix the expected pixel result
4:56 AM Changeset in webkit [119215] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Gardening failure case on EFL build bot
​https://bugs.webkit.org/show_bug.cgi?id=88067

Unreviewed EFL gardening after r119196.

Patch by Sudarsana Nagineni <​sudarsana.nagineni@linux.intel.com> on 2012-06-01

  • platform/efl/test_expectations.txt:
4:55 AM Changeset in webkit [119214] by peter@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled DEPS.

  • DEPS:
4:53 AM Changeset in webkit [119213] by yosin@chromium.org
  • 2 edits in trunk/Source/WebCore

REGRESSION(r109729) [Form] Rendering of select/optgroup/option combination is too slow.
​https://bugs.webkit.org/show_bug.cgi?id=88059

Reviewed by Kent Tamura.

This patch changes to share RenderStyle object among the "option"
elements to improve rendering performance and reducing memory usage
of RenderStyle.

No new tests. This patch doesn't change behavior but rendering performance.

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::canShareStyleWithElement): Check attribute value
mismatching for "option" element.

4:26 AM Changeset in webkit [119212] by apavlov@chromium.org
  • 4 edits in trunk/Source/WebCore

Web Inspector: [REGRESSION] Bad layout of "Override device metrics" controls in the Settings dialog
​https://bugs.webkit.org/show_bug.cgi?id=88074

Reviewed by Yury Semikhatsky.

The "Override device metrics" controls are placed in a table, which gets too narrow. Give it a
"white-space: nowrap" to avoid wrapping individual cells.

  • inspector/front-end/SettingsScreen.js:

(WebInspector.SettingsScreen.prototype._createDeviceMetricsElement):

  • inspector/front-end/elementsPanel.css:
  • inspector/front-end/inspector.css:

(.nowrap):

4:18 AM Changeset in webkit [119211] by vestbo@webkit.org
  • 2 edits in trunk/Tools

[Qt] Make Qt Creator aware of files in webkitpy/perl for easy editing

Reviewed by Simon Hausmann.

4:12 AM Changeset in webkit [119210] by kenneth@webkit.org
  • 6 edits in trunk/Source/WebKit2

[Qt] Clean up our viewport handling mess
​https://bugs.webkit.org/show_bug.cgi?id=87977

Reviewed by Simon Hausmann.

Consolidated functionality from QQuickWebViewPrivate* into
ViewportInteractionEngine that belongs there, in preparation for
renaming ViewportInteractionEngine in the future.

Remove unneeded methods and move others to private.

  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewFlickablePrivate::QQuickWebViewFlickablePrivate):
(QQuickWebViewFlickablePrivate::onComponentComplete):
(QQuickWebViewFlickablePrivate::didChangeViewportProperties):
(QQuickWebViewFlickablePrivate::updateViewportSize):
(QQuickWebViewFlickablePrivate::_q_resume):
(QQuickWebViewFlickablePrivate::pageDidRequestScroll):

  • UIProcess/API/qt/qquickwebview_p.h:
  • UIProcess/API/qt/qquickwebview_p_p.h:

(QQuickWebViewPrivate):
(QQuickWebViewFlickablePrivate):

  • UIProcess/qt/QtViewportInteractionEngine.cpp:

(WebKit::ViewportUpdateDeferrer::~ViewportUpdateDeferrer):
(WebKit::QtViewportInteractionEngine::QtViewportInteractionEngine):
(WebKit::QtViewportInteractionEngine::viewportAttributesChanged):
(WebKit::QtViewportInteractionEngine::pageContentsSizeChanged):
(WebKit::QtViewportInteractionEngine::pageItemPositionChanged):
(WebKit::QtViewportInteractionEngine::pageContentPositionRequested):
(WebKit::QtViewportInteractionEngine::visibleContentsRect):
(WebKit):
(WebKit::QtViewportInteractionEngine::informVisibleContentChange):
(WebKit::QtViewportInteractionEngine::viewportItemSizeChanged):

  • UIProcess/qt/QtViewportInteractionEngine.h:

(WebKit):
(QtViewportInteractionEngine):

3:50 AM Changeset in webkit [119209] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Move input element's spinner style tests to test_expectations.txt
​https://bugs.webkit.org/show_bug.cgi?id=88054

Unreviewed EFL gardening.

Patch by Alexander Shalamov <​alexander.shalamov@intel.com> on 2012-06-01

  • platform/efl/test_expectations.txt:
3:45 AM Changeset in webkit [119208] by commit-queue@webkit.org
  • 8 edits
    2 adds
    1 delete in trunk/Source

[EFL] Implement PlatformStrategies
​https://bugs.webkit.org/show_bug.cgi?id=86946

Source/WebCore:

Patch by Sudarsana Nagineni <​sudarsana.nagineni@linux.intel.com> on 2012-06-01
Reviewed by Carlos Garcia Campos.

  • PlatformEfl.cmake: Add PlatformStrategies.cpp file to the build system.

Also, remove PluginDataEfl.cpp because the same functionality is now
implemented in PlatformStrategiesEfl.cpp.

Source/WebKit:

Patch by Sudarsana Nagineni <​sudarsana.nagineni@linux.intel.com> on 2012-06-01
Reviewed by Carlos Garcia Campos.

  • PlatformEfl.cmake: Add PlatformStrategiesEfl file to the build

system.

Source/WebKit/efl:

Patch by Sudarsana Nagineni <​sudarsana.nagineni@linux.intel.com> on 2012-06-01
Reviewed by Carlos Garcia Campos.

Enable PLATFORM_STRATEGIES for EFL platform.

  • WebCoreSupport/PlatformStrategiesEfl.cpp: Added, code was moved

from platform/PluginDataEfl.
(PlatformStrategiesEfl::initialize): Initialize platform strategies.
(PlatformStrategiesEfl::PlatformStrategiesEfl):
(PlatformStrategiesEfl::createCookiesStrategy): Return this.
(PlatformStrategiesEfl::createPluginStrategy): Ditto.
(PlatformStrategiesEfl::createVisitedLinkStrategy): Ditto.
(PlatformStrategiesEfl::createPasteboardStrategy): Return 0, since
PasteboardStrategy is only used by mac code for now.
(PlatformStrategiesEfl::notifyCookiesChanged):
(PlatformStrategiesEfl::refreshPlugins): Refresh the plugin
database. Code executes only when NETSCAPE_PLUGIN_API is ON.
(PlatformStrategiesEfl::getPluginInfo): Initialize plugins and
populate the given vector with plugins information. Code executes
only when NETSCAPE_PLUGIN_API is ON.
(PlatformStrategiesEfl::isLinkVisited): Return whether the given
hash is a visited link of the page group.
(PlatformStrategiesEfl::addVisitedLink): Add the given hash to the
page group visited links.

  • WebCoreSupport/PlatformStrategiesEfl.h: Added.

(PlatformStrategiesEfl):

  • ewk/ewk_main.cpp: Initialize PlatformStrategiesEfl.

(_ewk_init_body):

Source/WTF:

Patch by Sudarsana Nagineni <​sudarsana.nagineni@linux.intel.com> on 2012-06-01
Reviewed by Carlos Garcia Campos.

  • wtf/Platform.h: Enable PLATFORM_STRATEGIES for EFL platform.
3:39 AM Changeset in webkit [119207] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

ASSERT(m_fontSelector->document()) is bogus and should be removed
​https://bugs.webkit.org/show_bug.cgi?id=88053

Reviewed by Abhishek Arya.

This ASSERT was introduced in ​http://trac.webkit.org/changeset/97402
together with a branch that handled the case of the ASSERT firing.
This ASSERT fires when running tests on Android (which runs with
ASSERTs enabled). The ASSERT appears to be bogus, so this patch removes
it.

  • css/CSSSegmentedFontFace.cpp:

(WebCore::CSSSegmentedFontFace::getFontData):

3:37 AM Changeset in webkit [119206] by Csaba Osztrogonác
  • 15 edits in trunk/LayoutTests

[Qt] Unreviewed gardening, update expected files.

  • platform/qt-5.0/fast/forms/HTMLOptionElement_label06-expected.png:
  • platform/qt-5.0/fast/forms/HTMLOptionElement_label06-expected.txt:
  • platform/qt-5.0/fast/forms/HTMLOptionElement_label07-expected.png:
  • platform/qt-5.0/fast/forms/HTMLOptionElement_label07-expected.txt:
  • platform/qt-5.0/fast/forms/form-element-geometry-expected.png:
  • platform/qt-5.0/fast/forms/form-element-geometry-expected.txt:
  • platform/qt-5.0/fast/forms/menulist-separator-painting-expected.png:
  • platform/qt-5.0/fast/forms/menulist-separator-painting-expected.txt:
  • platform/qt-5.0/fast/forms/select-baseline-expected.png:
  • platform/qt-5.0/fast/forms/select-baseline-expected.txt:
  • platform/qt-5.0/fast/forms/selectlist-minsize-expected.png:
  • platform/qt-5.0/fast/forms/selectlist-minsize-expected.txt:
  • platform/qt-5.0/fast/replaced/three-selects-break-expected.png:
  • platform/qt-5.0/fast/replaced/three-selects-break-expected.txt:
2:40 AM Changeset in webkit [119205] by yosin@chromium.org
  • 4 edits in trunk/Source

[Platform][Decimal] UInt128::operator/= calls makeUInt128 with wrong argument order
​https://bugs.webkit.org/show_bug.cgi?id=88044

Reviewed by Kent Tamura.

Source/WebCore:

This patch fixed wrong argument of makeUInt128 in UInt128::operator/= to get right
result for decimal multiplication.

Test: WebKit/chromium/tests/DecimalTest.cpp: Add new a new test case.

  • platform/Decimal.cpp:

(WebCore::DecimalPrivate::UInt128::operator/=):

Source/WebKit/chromium:

  • tests/DecimalTest.cpp:

(TEST_F): Add a new test for multiplication.

2:26 AM Changeset in webkit [119204] by abarth@webkit.org
  • 7 edits
    9 adds in trunk

sandbox directive in X-WebKit-CSP header unable to create a unique origin
​https://bugs.webkit.org/show_bug.cgi?id=88014

Reviewed by Ryosuke Niwa.

Source/WebCore:

We process the HTTP headers for a response after we create a document
object for the response. Previously, the SecurityOrigin of a document
was determined when the document was created, which meant that the
sandbox directive in CSP couldn't create a unique origin.

In this patch, we transition to a unique origin when we start enforcing
the SandboxOrigin bit. This patch is more complicated than you might
expect because we redundantly store the SecurityOrigin object in
DOMWindow. Removing that redundant state is
​https://bugs.webkit.org/show_bug.cgi?id=75793.

The CSP sandbox directive is defined in
​http://dvcs.w3.org/hg/content-security-policy/raw-file/tip/csp-1.0-specification.html
by reference to
​http://www.whatwg.org/specs/web-apps/current-work/#forced-sandboxing-flag-set.
The relation between sandbox and unique origin arises from
​http://www.whatwg.org/specs/web-apps/current-work/#origin-0.

Test: http/tests/security/contentSecurityPolicy/sandbox-allow-scripts-in-http-header-control.html

http/tests/security/contentSecurityPolicy/sandbox-allow-scripts-in-http-header.html
http/tests/security/contentSecurityPolicy/sandbox-in-http-header-control.html
http/tests/security/contentSecurityPolicy/sandbox-in-http-header.html

  • dom/Document.cpp:

(WebCore::Document::didUpdateSecurityOrigin):
(WebCore::Document::initContentSecurityPolicy):

  • dom/Document.h:

(Document):

  • dom/SecurityContext.cpp:

(WebCore::SecurityContext::enforceSandboxFlags):
(WebCore):
(WebCore::SecurityContext::didUpdateSecurityOrigin):

  • dom/SecurityContext.h:

(SecurityContext):

LayoutTests:

  • http/tests/security/contentSecurityPolicy/sandbox-allow-scripts-in-http-header-control.html: Added.
  • http/tests/security/contentSecurityPolicy/sandbox-allow-scripts-in-http-header-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/sandbox-allow-scripts-in-http-header.html: Added.
  • http/tests/security/contentSecurityPolicy/sandbox-in-http-header-control-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/sandbox-in-http-header-control.html: Added.
  • http/tests/security/contentSecurityPolicy/resources/sandbox.php: Added.
  • http/tests/security/contentSecurityPolicy/sandbox-in-http-header-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/sandbox-in-http-header.html: Added.
  • http/tests/security/contentSecurityPolicy/sandbox-allow-scripts-in-http-header-control-expected.txt: Added.
2:03 AM Changeset in webkit [119203] by yurys@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: expose MemoryCache statistics in the inspector protocol
​https://bugs.webkit.org/show_bug.cgi?id=87984

Reviewed by Pavel Feldman.

Added MemoryCache statistics to Memory.getProcessMemoryDistribution command
result. Corresponding sector is added to the memory pie-chart.

  • inspector/InspectorMemoryAgent.cpp:

(MemoryBlockName):
(WebCore):
(WebCore::addMemoryBlockFor):
(WebCore::memoryCacheInfo):
(WebCore::InspectorMemoryAgent::getProcessMemoryDistribution):

  • inspector/front-end/NativeMemorySnapshotView.js:

(WebInspector.MemoryBlockViewProperties._initialize):

1:54 AM Changeset in webkit [119202] by zandobersek@gmail.com
  • 2 edits
    3 adds in trunk/LayoutTests

Unreviewed GTK gardening, add missing text and image baselines for
fast/images/png-suite/test.html. Add MISSING expectations for two
placeholder-in-text-area tests - the placeholder text does not appear
in text areas (known bug).

  • platform/gtk/fast/images/png-suite: Added.
  • platform/gtk/fast/images/png-suite/test-expected.png: Added.
  • platform/gtk/fast/images/png-suite/test-expected.txt: Added.
  • platform/gtk/test_expectations.txt:
1:34 AM Changeset in webkit [119201] by yurys@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: add RenderArena sizes to the memory pie-chart
​https://bugs.webkit.org/show_bug.cgi?id=87971

Reviewed by Pavel Feldman.

Added allocated and used sizes of page render arenas to the memory
report returned by the InspectorMemoryAgent. Total allocated size of
the inspected page's render arenas will be displayed on the memory
pie-chart.

  • inspector/InspectorMemoryAgent.cpp:

(MemoryBlockName):
(WebCore):
(WebCore::renderTreeInfo):
(WebCore::InspectorMemoryAgent::getProcessMemoryDistribution):

  • inspector/front-end/NativeMemorySnapshotView.js:

(WebInspector.MemoryBlockViewProperties._initialize):

1:32 AM Changeset in webkit [119200] by zandobersek@gmail.com
  • 2 edits
    1 add in trunk/LayoutTests

Unreviewed GTK gardening after r119196.

  • platform/gtk/fast/dom/gc-attribute-node-expected.txt: Added.
  • platform/gtk/test_expectations.txt: Also mark fast/replaced/border-radius-clip.html as flaky.
1:29 AM Changeset in webkit [119199] by tkent@chromium.org
  • 3 edits
    2 copies in branches/chromium/1132

Merge 118721 - Form controls in <fieldset disabled> should not be validated.
​https://bugs.webkit.org/show_bug.cgi?id=87381

Reviewed by Hajime Morita.

Source/WebCore:

We need to use disabeld() instead of m_disabled to calculate
willValidate property. Also, we need to update willValidate if
necessary.

Test: fast/forms/fieldset/validation-in-fieldset.html

  • html/HTMLFieldSetElement.cpp:

(WebCore::HTMLFieldSetElement::disabledAttributeChanged):

  • Do not traverse this.
  • Calls ancestorDisabledStateWasChanged() instead of setNeedsStyleRecalc() because we'd like to do additional tasks.
  • html/HTMLFormControlElement.cpp:

(WebCore::HTMLFormControlElement::ancestorDisabledStateWasChanged):
Added. Just calls disabledAttributeChanged().
(WebCore::HTMLFormControlElement::parseAttribute):
Do not call setNeedsWillValidateCheck() whenever an attribute is updated.
It should be called only if disabled or readonly attribute is updated.
(WebCore::HTMLFormControlElement::disabledAttributeChanged):
Add setNeedsWillValidateCheck(). It was moved from parseAttribute().
(WebCore::HTMLFormControlElement::insertedInto):
Invalidate ancestor information.
(WebCore::HTMLFormControlElement::recalcWillValidate):
Use disabled() instead of m_disabled. disabled() takes care of
ancestor's disabled state.

  • html/HTMLFormControlElement.h:

(HTMLFormControlElement):

LayoutTests:

  • fast/forms/fieldset/validation-in-fieldset-expected.txt: Added.
  • fast/forms/fieldset/validation-in-fieldset.html: Added.

TBR=​tkent@chromium.org
Review URL: ​https://chromiumcodereview.appspot.com/10451107

1:23 AM Changeset in webkit [119198] by yurys@chromium.org
  • 6 edits in trunk/Source/WebCore

Web Inspector: change type of injected script id from long to int
​https://bugs.webkit.org/show_bug.cgi?id=87837

Reviewed by Pavel Feldman.

Changed injected script id type from long to int so that we don't
lose precision when sending the id over the protocol.

  • bindings/js/JSInjectedScriptManager.cpp:

(WebCore::InjectedScriptManager::createInjectedScript):
(WebCore::InjectedScriptManager::injectedScriptFor):

  • bindings/v8/custom/V8InjectedScriptManager.cpp:

(WebCore::InjectedScriptManager::createInjectedScript):
(WebCore::InjectedScriptManager::injectedScriptFor):

  • inspector/InjectedScriptManager.cpp:

(WebCore::InjectedScriptManager::injectedScriptForId):
(WebCore::InjectedScriptManager::injectedScriptIdFor):
(WebCore::InjectedScriptManager::injectScript):

  • inspector/InjectedScriptManager.h:

(InjectedScriptManager):

  • inspector/PageRuntimeAgent.cpp:

(WebCore::PageRuntimeAgent::notifyContextCreated):

1:17 AM Changeset in webkit [119197] by yurys@chromium.org
  • 6 edits
    1 add in trunk/Source/WebCore

Web Inspector: draw pie-chart based on memory data received from backend
​https://bugs.webkit.org/show_bug.cgi?id=87737

Reviewed by Pavel Feldman.

Added pie chart for memory data received from inspector memory agent.

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/front-end/NativeMemorySnapshotView.js:

(WebInspector.NativeMemorySnapshotView):
(WebInspector.NativeMemoryProfileType):
(WebInspector.NativeMemoryProfileType.prototype.buttonClicked.didReceiveMemorySnapshot):
(WebInspector.NativeMemoryProfileType.prototype.buttonClicked):
(WebInspector.NativeMemoryProfileHeader):
(WebInspector.MemoryBlockViewProperties):
(WebInspector.MemoryBlockViewProperties._initialize):
(WebInspector.MemoryBlockViewProperties._forMemoryBlock):
(WebInspector.NativeMemoryPieChart):
(WebInspector.NativeMemoryPieChart.prototype.onResize):
(WebInspector.NativeMemoryPieChart.prototype._updateSize):
(WebInspector.NativeMemoryPieChart.prototype._addBlockLabels):
(WebInspector.NativeMemoryPieChart.prototype._paint.paintPercentAndLabel):
(WebInspector.NativeMemoryPieChart.prototype._paint):
(WebInspector.NativeMemoryPieChart.prototype._clear):

  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/nativeMemoryProfiler.css: Added.

(.memory-pie-chart-container):
(.memory-pie-chart):
(.memory-blocks-list .swatch):
(.memory-blocks-list):
(.memory-blocks-list .item):

May 31, 2012:

11:37 PM Changeset in webkit [119196] by dominicc@chromium.org
  • 3 edits
    4 adds in trunk

[V8] Expando properties on attribute nodes disappear
​https://bugs.webkit.org/show_bug.cgi?id=87925

Source/WebCore:

Reviewed by Adam Barth.

Test: fast/dom/gc-attribute-node.html

  • bindings/v8/V8GCController.cpp:

(WebCore::calculateGroupId): Group attributes like other nodes.

LayoutTests:

Checks in a failing result for JSC; see
<​https://bugs.webkit.org/show_bug.cgi?id=88045>.

Reviewed by Adam Barth.

  • fast/dom/gc-attribute-node-expected.txt: Added.
  • fast/dom/gc-attribute-node.html: Added.
  • platform/chromium/fast/dom/gc-attribute-node-expected.txt: Added.
  • platform/mac/fast/dom/gc-attribute-node-expected.txt: Added.
11:33 PM Changeset in webkit [119195] by commit-queue@webkit.org
  • 7 edits
    9 adds in trunk

[EFL] <input type="number"> is not a spinbutton
​https://bugs.webkit.org/show_bug.cgi?id=86846

Patch by Alexander Shalamov <​alexander.shalamov@intel.com> on 2012-05-31
Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

Implemented adjustInnerSpinButtonStyle and
paintInnerSpinButton in RenderThemeEfl.

  • platform/efl/RenderThemeEfl.cpp:

(WebCore::RenderThemeEfl::applyEdjeStateFromForm):
(WebCore::RenderThemeEfl::edjeGroupFromFormType):
(WebCore::RenderThemeEfl::adjustInnerSpinButtonStyle):
(WebCore):
(WebCore::RenderThemeEfl::paintInnerSpinButton):

  • platform/efl/RenderThemeEfl.h:

(RenderThemeEfl):

Source/WebKit/efl:

Implemented spinner widget.

  • DefaultTheme/default.edc:
  • DefaultTheme/widget/spinner/sp_bg.png: Added.
  • DefaultTheme/widget/spinner/sp_down_default.png: Added.
  • DefaultTheme/widget/spinner/sp_down_hover.png: Added.
  • DefaultTheme/widget/spinner/sp_down_pressed.png: Added.
  • DefaultTheme/widget/spinner/sp_up_default.png: Added.
  • DefaultTheme/widget/spinner/sp_up_hover.png: Added.
  • DefaultTheme/widget/spinner/sp_up_pressed.png: Added.
  • DefaultTheme/widget/spinner/spinner.edc: Added.

LayoutTests:

Unskip spinbutton layout tests.

  • platform/efl/test_expectations.txt:
10:05 PM Changeset in webkit [119194] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

Update Chromium test expectation of media/video-poster-blocked-by-willsendrequest.html to PASS TEXT
on all platforms as supposed to just Mac and Linux since the result of jquery/traversing.html is
bleeding into this test on Windows as well.

  • platform/chromium/test_expectations.txt:
9:24 PM Changeset in webkit [119193] by tony@chromium.org
  • 5 edits in trunk/LayoutTests

Unreviewed. Fix expectations for for fast/multicol/span/clone-flexbox.html,
the result I checked in was off by 1px.

  • fast/multicol/span/clone-flexbox-expected.txt:
  • platform/efl/fast/multicol/span/clone-flexbox-expected.txt:
  • platform/gtk/fast/multicol/span/clone-flexbox-expected.txt:
  • platform/qt/fast/multicol/span/clone-flexbox-expected.txt:
9:00 PM Changeset in webkit [119192] by commit-queue@webkit.org
  • 35 edits in trunk

REGRESSION(r117572): editing/spelling/spellcheck-async-remove-frame.html crashes on Mac
​https://bugs.webkit.org/show_bug.cgi?id=86859

Source/WebCore:

Patch by Hajime Morrita <​morrita@chromium.org> on 2012-05-31
Reviewed by Ryosuke Niwa.

The test tries to reach an invalid SpellChecker object. Such an access should be guarded
beforehand.

Asynchronous spellchecking can return results after originated
frame is gone, which triggered an invalid access to the dead spellchecker
object. This chagne prevents it by marking request objects from
the spellchecker as invalid:

  • Originally TextCheckerClient API was passed a SpellCheker object. This change abstracted it behind TextCheckingRequest interface, didSucceed() and didCancel() method specifically.
  • TextCheckingRequest was turned from a plain old object into a refcounted abstract class, which is now subclassed by SpellCheckRequest.
  • SpellChecker now marks pending SpellCheckRequest objects as invalid on its destructor.

Test: editing/spelling/spellcheck-async-remove-frame.html

  • WebCore.exp.in:
  • editing/SpellChecker.cpp:

(WebCore::SpellCheckRequest::SpellCheckRequest):
(WebCore::SpellCheckRequest::create):
(WebCore::SpellCheckRequest::didSucceed):
(WebCore):
(WebCore::SpellCheckRequest::didCancel):
(WebCore::SpellCheckRequest::wasRequestedBy):
(WebCore::SpellCheckRequest::requesterDestroyed):
(WebCore::SpellChecker::~SpellChecker):
(WebCore::SpellChecker::requestCheckingFor):
(WebCore::SpellChecker::invokeRequest):
(WebCore::SpellChecker::didCheckSucceed):
(WebCore::SpellChecker::didCheckCancel):

  • editing/SpellChecker.h:

(WebCore):
(SpellCheckRequest):
(WebCore::SpellCheckRequest::isStarted):
(SpellChecker):

  • loader/EmptyClients.h:

(WebCore::EmptyTextCheckerClient::requestCheckingOfString):

  • platform/text/TextCheckerClient.h:

(TextCheckerClient):

  • platform/text/TextChecking.h:

(GrammarDetail):
(TextCheckingResult):
(TextCheckingRequest):
(WebCore::TextCheckingRequest::~TextCheckingRequest):

Source/WebKit/blackberry:

Patch by Hajime Morrita <​morrita@chromium.org> on 2012-05-31
Reviewed by Ryosuke Niwa.

  • WebCoreSupport/EditorClientBlackBerry.cpp:

(WebCore::EditorClientBlackBerry::requestCheckingOfString):

  • WebCoreSupport/EditorClientBlackBerry.h:

(EditorClientBlackBerry):

Source/WebKit/chromium:

Removed a port specific fix which was introduced at r117572.

Patch by Hajime Morrita <​morrita@chromium.org> on 2012-05-31
Reviewed by Ryosuke Niwa.

  • src/EditorClientImpl.cpp:

(WebKit::EditorClientImpl::frameWillDetachPage):
(WebKit::EditorClientImpl::requestCheckingOfString):

  • src/EditorClientImpl.h:

(WebCore):
(EditorClientImpl):

  • src/WebTextCheckingCompletionImpl.cpp:

(WebKit::WebTextCheckingCompletionImpl::didFinishCheckingText):
(WebKit::WebTextCheckingCompletionImpl::didCancelCheckingText):

  • src/WebTextCheckingCompletionImpl.h:

(WebKit::WebTextCheckingCompletionImpl::WebTextCheckingCompletionImpl):
(WebTextCheckingCompletionImpl):

Source/WebKit/efl:

Patch by Hajime Morrita <​morrita@chromium.org> on 2012-05-31
Reviewed by Ryosuke Niwa.

  • WebCoreSupport/EditorClientEfl.h:

(WebCore::EditorClientEfl::requestCheckingOfString):

Source/WebKit/gtk:

Patch by Hajime Morrita <​morrita@chromium.org> on 2012-05-31
Reviewed by Ryosuke Niwa.

  • WebCoreSupport/TextCheckerClientGtk.h:

(WebKit::TextCheckerClientGtk::requestCheckingOfString):

Source/WebKit/mac:

Patch by Hajime Morrita <​morrita@chromium.org> on 2012-05-31
Reviewed by Ryosuke Niwa.

  • WebCoreSupport/WebEditorClient.h:
  • WebCoreSupport/WebEditorClient.mm:

(-[WebEditorSpellCheckResponder initWithClient:sequence:results:]):
(-[WebEditorSpellCheckResponder perform]):
(WebEditorClient::didCheckSucceeded):
(WebEditorClient::requestCheckingOfString):

Source/WebKit/qt:

Patch by Hajime Morrita <​morrita@chromium.org> on 2012-05-31
Reviewed by Ryosuke Niwa.

  • WebCoreSupport/TextCheckerClientQt.h:

(WebCore::TextCheckerClientQt::requestCheckingOfString):

Source/WebKit/win:

Patch by Hajime Morrita <​morrita@chromium.org> on 2012-05-31
Reviewed by Ryosuke Niwa.

  • WebCoreSupport/WebEditorClient.h:

(WebEditorClient::requestCheckingOfString):

Source/WebKit/wince:

Patch by Hajime Morrita <​morrita@chromium.org> on 2012-05-31
Reviewed by Ryosuke Niwa.

  • WebCoreSupport/EditorClientWinCE.h:

(WebKit::EditorClientWinCE::requestCheckingOfString):

Source/WebKit/wx:

Patch by Hajime Morrita <​morrita@chromium.org> on 2012-05-31
Reviewed by Ryosuke Niwa.

  • WebKitSupport/EditorClientWx.h:

(WebCore::EditorClientWx::requestCheckingOfString):

Source/WebKit2:

Patch by Hajime Morrita <​morrita@chromium.org> on 2012-05-31
Reviewed by Ryosuke Niwa.

  • WebProcess/WebCoreSupport/WebEditorClient.cpp:

(WebKit::WebEditorClient::requestCheckingOfString):

  • WebProcess/WebCoreSupport/WebEditorClient.h:

LayoutTests:

Patch by Hajime Morrita <​morrita@chromium.org> on 2012-05-31
Reviewed by Ryosuke Niwa.

  • platform/mac/Skipped: Unskipped the test.
8:35 PM WikiStart edited by tkent@chromium.org
Add a link to ChromiumWebKitAPI (diff)
8:32 PM Changeset in webkit [119191] by tony@chromium.org
  • 57 edits in trunk

initial flex value should be 1 1 auto
​https://bugs.webkit.org/show_bug.cgi?id=86526

Source/WebCore:

Reviewed by Ojan Vafai.

Also, if -webkit-flex is used to set the positive flex to 0 and
the negative flex is omitted, the negative flex is set to 0.

New test cases in: flex-property-parsing.html

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseFlex):

  • css/StyleBuilder.cpp:

(WebCore::ApplyPropertyFlex::applyValue):

  • rendering/style/RenderStyle.h:

LayoutTests:

In most tests, I added a CSS rule to default -webkit-flex: none.
In a few tests, -webkit-flex didn't include the negative flex value
and it was becoming 1, causing negative flexing. I fixed those by
explicitly stating the negative flex as 0.

Reviewed by Ojan Vafai.

  • css3/flexbox/align-absolute-child.html:
  • css3/flexbox/auto-margins.html:
  • css3/flexbox/flex-algorithm-with-margins.html:
  • css3/flexbox/flex-algorithm.html:
  • css3/flexbox/flex-align-end.html:
  • css3/flexbox/flex-flow-auto-margins.html:
  • css3/flexbox/flex-flow-orientations.html:
  • css3/flexbox/flex-flow-overflow.html:
  • css3/flexbox/flex-pack.html:
  • css3/flexbox/flex-property-parsing-expected.txt:
  • css3/flexbox/flex-property-parsing.html:
  • css3/flexbox/flexbox-overflow-auto-expected.html:
  • css3/flexbox/flexbox-overflow-auto.html:
  • css3/flexbox/multiline-column-auto.html:
  • css3/flexbox/multiline-pack.html:
  • css3/flexbox/multiline-shrink-to-fit.html:
  • css3/flexbox/multiline.html:
  • css3/flexbox/nested-stretch.html:
  • css3/flexbox/orthogonal-flex-directions.html:
  • css3/flexbox/position-absolute-child.html:
  • css3/flexbox/preferred-widths-orthogonal.html:
  • css3/flexbox/true-centering.html:
  • fast/css/getComputedStyle/computed-style-expected.txt:
  • fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/chromium-linux-x86/svg/css/getComputedStyle-basic-expected.txt:
  • platform/chromium-linux/svg/css/getComputedStyle-basic-expected.txt:
  • platform/chromium-mac-leopard/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/chromium-mac-leopard/svg/css/getComputedStyle-basic-expected.txt:
  • platform/chromium-mac-snowleopard/svg/css/getComputedStyle-basic-expected.txt:
  • platform/chromium-mac/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/chromium-mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/chromium-mac/svg/css/getComputedStyle-basic-expected.txt:
  • platform/chromium-win-vista/svg/css/getComputedStyle-basic-expected.txt:
  • platform/chromium-win-xp/svg/css/getComputedStyle-basic-expected.txt:
  • platform/chromium-win/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/chromium-win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt:
  • platform/gtk/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/gtk/svg/css/getComputedStyle-basic-expected.txt:
  • platform/mac/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/mac/svg/css/getComputedStyle-basic-expected.txt:
  • platform/qt/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/qt/svg/css/getComputedStyle-basic-expected.txt:
  • platform/win/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • svg/css/getComputedStyle-basic-expected.txt:
8:29 PM Changeset in webkit [119190] by jberlin@webkit.org
  • 1 edit
    4 adds in trunk/LayoutTests

[Win] 4 fast/frames tests failing
​https://bugs.webkit.org/show_bug.cgi?id=88034

Add Windows-specific expected (failing?) results to get the bots green.

  • platform/win/fast/frames/frame-set-scaling-hit-expected.txt: Added.
  • platform/win/fast/frames/frame-with-noresize-can-be-resized-after-removal-of-noresize-expected.txt: Added.
  • platform/win/fast/frames/frame-with-noresize-can-be-resized-after-setting-noResize-to-false-expected.txt: Added.
  • platform/win/fast/frames/frames-with-frameborder-zero-can-be-resized-expected.txt: Added.
8:21 PM Changeset in webkit [119189] by aestes@apple.com
  • 3 edits in trunk/Source/WebKit2

[WebKit2] Remove nested #if conditions from messages.in files
​https://bugs.webkit.org/show_bug.cgi?id=88039

Reviewed by Filip Pizlo.

The code generator that processes messages.in files can't handle nested
#if conditions. Sadly I added said conditions in r117700 but failed to
verify the generated result. Un-nest the conditions I added.

  • UIProcess/WebPageProxy.messages.in:
  • WebProcess/WebPage/WebPage.messages.in:
8:19 PM Changeset in webkit [119188] by rniwa@webkit.org
  • 8 edits
    3 adds in trunk

Add public page loading performance tests using web-page-replay
​https://bugs.webkit.org/show_bug.cgi?id=84008

Reviewed by Dirk Pranke.

PerformanceTests:

Add replay tests for google.com and youtube.com as examples.

  • Replay: Added.
  • Replay/www.google.com.replay: Added.
  • Replay/www.youtube.com.replay: Added.

Tools:

Add the primitive implementation of replay performance tests. We use web-page-replay (​http://code.google.com/p/web-page-replay/)
to cache data locally. Each replay test is represented by a text file with .replay extension containing a single URL.
To hash out bugs and isolate them from the rest of performance tests, replay tests are hidden behind --replay flag.

Run "run-perf-tests --replay PerformanceTests/Replay" after changing the system network preference to forward HTTP and HTTPS requests
to localhost:8080 and localhost:8443 respectively (i.e. configure the system as if there are HTTP proxies at ports 8080 and 8443)
excluding: *.webkit.org, *.googlecode.com, *.sourceforge.net, pypi.python.org, and www.adambarth.com for thirdparty Python dependencies.
run-perf-tests starts web-page-replay, which provides HTTP proxies at ports 8080 and 8443 to replay pages.

  • Scripts/webkitpy/layout_tests/port/driver.py:

(Driver.is_external_http_test): Added.

  • Scripts/webkitpy/layout_tests/port/webkit.py:

(WebKitDriver._command_from_driver_input): Allow test names that starts with ​http:// or ​https://.

  • Scripts/webkitpy/performance_tests/perftest.py:

(PerfTest.init): Takes port.
(PerfTest.prepare): Added. Overridden by ReplayPerfTest.
(PerfTest):
(PerfTest.run): Calls run_single.
(PerfTest.run_single): Extracted from PageLoadingPerfTest.run.
(ChromiumStylePerfTest.init):
(PageLoadingPerfTest.init):
(PageLoadingPerfTest.run):
(ReplayServer): Added. Responsible for starting and stopping replay.py in the web-page-replay.
(ReplayServer.init):
(ReplayServer.wait_until_ready): Wait until port 8080 is ready. I have tried looking at the piped output from web-page-replay
but it caused a dead lock on some web pages.
(ReplayServer.stop):
(ReplayServer.del):
(ReplayPerfTest):
(ReplayPerfTest.init):
(ReplayPerfTest._start_replay_server):
(ReplayPerfTest.prepare): Creates test.wpr and test-expected.png to cache the page when a replay test is ran for the first time.
The subsequent runs of the same test will just use test.wpr.
(ReplayPerfTest.run_single):
(PerfTestFactory):
(PerfTestFactory.create_perf_test):

  • Scripts/webkitpy/performance_tests/perftest_unittest.py:

(MainTest.test_parse_output):
(MainTest.test_parse_output_with_failing_line):
(TestPageLoadingPerfTest.test_run):
(TestPageLoadingPerfTest.test_run_with_bad_output):
(TestReplayPerfTest):
(TestReplayPerfTest.ReplayTestPort):
(TestReplayPerfTest.ReplayTestPort.init):
(TestReplayPerfTest.ReplayTestPort.init.ReplayTestDriver):
(TestReplayPerfTest.ReplayTestPort.init.ReplayTestDriver.run_test):
(TestReplayPerfTest.ReplayTestPort._driver_class):
(TestReplayPerfTest.MockReplayServer):
(TestReplayPerfTest.MockReplayServer.init):
(TestReplayPerfTest.MockReplayServer.stop):
(TestReplayPerfTest._add_file):
(TestReplayPerfTest._setup_test):
(TestReplayPerfTest.test_run_single):
(TestReplayPerfTest.test_run_single.run_test):
(TestReplayPerfTest.test_run_single_fails_without_webpagereplay):
(TestReplayPerfTest.test_prepare_fails_when_wait_until_ready_fails):
(TestReplayPerfTest.test_run_single_fails_when_output_has_error):
(TestReplayPerfTest.test_run_single_fails_when_output_has_error.run_test):
(TestReplayPerfTest.test_prepare):
(TestReplayPerfTest.test_prepare.run_test):
(TestReplayPerfTest.test_prepare_calls_run_single):
(TestReplayPerfTest.test_prepare_calls_run_single.run_single):
(TestPerfTestFactory.test_regular_test):
(TestPerfTestFactory.test_inspector_test):
(TestPerfTestFactory.test_page_loading_test):

  • Scripts/webkitpy/performance_tests/perftestsrunner.py:

(PerfTestsRunner):
(PerfTestsRunner._parse_args): Added --replay flag to enable replay tests.
(PerfTestsRunner._collect_tests): Collect .replay files when replay tests are enabled.
(PerfTestsRunner._collect_tests._is_test_file):
(PerfTestsRunner.run): Exit early if one of calls to prepare() fails.

  • Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:

(create_runner):
(run_test):
(_tests_for_runner):
(test_run_test_set):
(test_run_test_set_kills_drt_per_run):
(test_run_test_pause_before_testing):
(test_run_test_set_for_parser_tests):
(test_run_test_set_with_json_output):
(test_run_test_set_with_json_source):
(test_run_test_set_with_multiple_repositories):
(test_run_with_upload_json):
(test_upload_json):
(test_upload_json.MockFileUploader.upload_single_text_file):
(_add_file):
(test_collect_tests):
(test_collect_tests_with_multile_files):
(test_collect_tests_with_multile_files.add_file):
(test_collect_tests_with_skipped_list):
(test_collect_tests_with_page_load_svg):
(test_collect_tests_should_ignore_replay_tests_by_default):
(test_collect_tests_with_replay_tests):
(test_parse_args):

  • Scripts/webkitpy/thirdparty/init.py: Added the dependency for web-page-replay version 1.1.1.

(AutoinstallImportHook.find_module):
(AutoinstallImportHook._install_webpagereplay):

7:16 PM Changeset in webkit [119187] by commit-queue@webkit.org
  • 22 edits in trunk/Source

Unreviewed, rolling out r119146.
​http://trac.webkit.org/changeset/119146
​https://bugs.webkit.org/show_bug.cgi?id=88035

android breakage fixed in ​http://crrev.com/139945 (Requested
by fischman on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-05-31

Source/WebCore:

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::HTMLMediaElement):
(WebCore::HTMLMediaElement::startProgressEventTimer):
(WebCore::HTMLMediaElement::changeNetworkStateFromLoadingToIdle):
(WebCore::HTMLMediaElement::progressEventTimerFired):
(WebCore::HTMLMediaElement::startPlaybackProgressTimer):

  • platform/graphics/MediaPlayer.cpp:

(WebCore::NullMediaPlayerPrivate::didLoadingProgress):
(WebCore::MediaPlayer::didLoadingProgress):

  • platform/graphics/MediaPlayer.h:
  • platform/graphics/MediaPlayerPrivate.h:

(MediaPlayerPrivateInterface):

  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:

(WebCore::MediaPlayerPrivateAVFoundation::MediaPlayerPrivateAVFoundation):
(WebCore::MediaPlayerPrivateAVFoundation::didLoadingProgress):

  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:

(MediaPlayerPrivateAVFoundation):

  • platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp:

(WebCore::MediaPlayerPrivate::didLoadingProgress):

  • platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.h:

(MediaPlayerPrivate):

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::MediaPlayerPrivateGStreamer):
(WebCore::MediaPlayerPrivateGStreamer::didLoadingProgress):

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:

(MediaPlayerPrivateGStreamer):

  • platform/graphics/mac/MediaPlayerPrivateQTKit.h:

(MediaPlayerPrivateQTKit):

  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm:

(WebCore::MediaPlayerPrivateQTKit::MediaPlayerPrivateQTKit):
(WebCore::MediaPlayerPrivateQTKit::didLoadingProgress):

  • platform/graphics/qt/MediaPlayerPrivateQt.cpp:

(WebCore::MediaPlayerPrivateQt::MediaPlayerPrivateQt):
(WebCore::MediaPlayerPrivateQt::didLoadingProgress):

  • platform/graphics/qt/MediaPlayerPrivateQt.h:

(MediaPlayerPrivateQt):

  • platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:

(WebCore::MediaPlayerPrivateQuickTimeVisualContext::MediaPlayerPrivateQuickTimeVisualContext):
(WebCore::MediaPlayerPrivateQuickTimeVisualContext::didLoadingProgress):

  • platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.h:

(MediaPlayerPrivateQuickTimeVisualContext):

  • platform/graphics/wince/MediaPlayerPrivateWinCE.h:

(MediaPlayerPrivate):

Source/WebKit/chromium:

  • public/WebMediaPlayer.h:

(WebMediaPlayer):

  • src/WebMediaPlayerClientImpl.cpp:

(WebKit::WebMediaPlayerClientImpl::didLoadingProgress):

  • src/WebMediaPlayerClientImpl.h:

(WebMediaPlayerClientImpl):

7:01 PM Changeset in webkit [119186] by yosin@chromium.org
  • 5 edits
    5 copies in branches/chromium/1132

Merge 118772 - REGRESSION(r109729): The optgroup element's "disabled" attribute has no effect to rendering and selection
​https://bugs.webkit.org/show_bug.cgi?id=87614

Reviewed by Kent Tamura.

Source/WebCore:

This patch adds HTMLOptGroupElement::disabled and isEnabledFormControl
methods which was implemented in HTMLFormControlElement at r109729 and
updates CSS pseudo class checker to check "optgroup" element.

Tests: fast/forms/select/optgroup-clicking.html

fast/forms/select/optgroup-disabled.html
fast/forms/select/optgroup-rendering.html

  • css/SelectorChecker.cpp:

(WebCore::SelectorChecker::checkOneSelector): On disabled and enabled pseudo class checker.
We checked tag name "optgroup" in addition isFormControlElement.

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::canShareStyleWithElement): Checks optgroup.disabled.

  • html/HTMLOptGroupElement.cpp:

(WebCore::HTMLOptGroupElement::disabled): Added.

  • html/HTMLOptGroupElement.h:

(HTMLOptGroupElement): Added isEnabledFormControl.

LayoutTests:

Note: An image for optgroup-rendering.html will be change due by
BUG-87719. Color of option elements should be blue (:enabled
pseudo class) instead of green.

  • fast/forms/select/optgroup-clicking-expected.txt: Added.
  • fast/forms/select/optgroup-clicking.html: Added.
  • fast/forms/select/optgroup-disabled-expected.txt: Added.
  • fast/forms/select/optgroup-disabled.html: Added.
  • fast/forms/select/optgroup-rendering.html: Added.
  • platform/chromium/test_expectations.txt: Add MISSING entry for optgroup-rendering.html.
  • platform/chromium-linux/fast/forms/select/optgroup-rendering-expected.png: Added.
  • platform/chromium-linux/fast/forms/select/optgroup-rendering-expected.txt: Added.

TBR=​yosin@chromium.org
Review URL: ​https://chromiumcodereview.appspot.com/10453112

6:37 PM Changeset in webkit [119185] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit/blackberry

[BlackBerry] WebGL and 2D canvas output not available to WebPageCompositor
​https://bugs.webkit.org/show_bug.cgi?id=88012

Patch by Arvid Nilsson <​anilsson@rim.com> on 2012-05-31
Reviewed by George Staikos.

Properly set up resource sharing between WebKit thread EGL contexts and
the compositing thread EGL context, so the texture ID produced by WebGL
and 2D canvas makes sense to the compositing context.

There's no public API to supply an EGLContext yet, so we're lucky that
the embedder never makes its context un-current. Just grab the current
context on the compositing thread and use that as the compositing
context.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::setCompositor):

  • Api/WebPageCompositor.cpp:

(BlackBerry::WebKit::WebPageCompositor::WebPageCompositor):
(BlackBerry::WebKit::WebPageCompositor::~WebPageCompositor):

  • Api/WebPage_p.h:

(WebPagePrivate):

6:31 PM Changeset in webkit [119184] by tsepez@chromium.org
  • 3 edits
    2 adds in trunk

XSSAuditor bypass with leading /*/*/ comment
​https://bugs.webkit.org/show_bug.cgi?id=88002

Reviewed by Adam Barth.

Source/WebCore:

Fixes issue in xssauditor's parsing of /*/.

Test: http/tests/security/xssAuditor/script-tag-with-trailing-comment4.html

  • html/parser/XSSAuditor.cpp:

(WebCore::XSSAuditor::decodedSnippetForJavaScript):

LayoutTests:

Fixes issue in xssauditor's parsing of /*/.

  • http/tests/security/xssAuditor/script-tag-with-trailing-comment4-expected.txt: Added.
  • http/tests/security/xssAuditor/script-tag-with-trailing-comment4.html: Added.
6:13 PM Changeset in webkit [119183] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Support building the Android port of chromium with Ninja
​https://bugs.webkit.org/show_bug.cgi?id=87545

Patch by Yaron Friedman <​yfriedman@chromium.org> on 2012-05-31
Reviewed by Adam Barth.

Ensures that shared libraries are looked up in a generator-agnostic
way and that output is placed in the correct directory.

Depends on ​http://codereview.chromium.org/10386188/

  • DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
5:59 PM Changeset in webkit [119182] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

Bug: Negative SVG rect rx,ry corner radii values aren't handled correctly
​https://bugs.webkit.org/show_bug.cgi?id=87859

Patch by Hans Muller <​hmuller@adobe.com> on 2012-05-31
Reviewed by Dirk Schulze.

Source/WebCore:

Added the rect element corner radius constraints specified in steps 2-4 of
​http://www.w3.org/TR/SVG/shapes.html#RectElement to Path::addRoundedRect().
Support for steps 6 and 7 was already included. Steps 2-4:

2 - If neither rx nor ry are properly specified, then set both rx and ry to 0. (This will result in square corners.)
3 - Otherwise, if a properly specified value is provided for rx, but not for ry then set both rx and ry to the value of rx.
4 - Otherwise, if a properly specified value is provided for ry, but not for rx, then set both rx and ry to the value of ry.

Tests: svg/custom/rect-negative-corner-radii-expected.svg

svg/custom/rect-negative-corner-radii.svg

  • platform/graphics/Path.cpp:

(WebCore::Path::addRoundedRect):

LayoutTests:

Added a reftest which verifies that negative rect corner radius values are handled per the SVG spec,
​http://www.w3.org/TR/SVG/shapes.html#RectElement.

  • svg/custom/rect-negative-corner-radii-expected.svg: Added.
  • svg/custom/rect-negative-corner-radii.svg: Added.
5:56 PM Changeset in webkit [119181] by rakuco@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Gardening. Skip fast/loader/opaque-base-url.html only on debug bots.

The test hits an assertion which obviously only crashes the debug
bots.

  • platform/efl/test_expectations.txt:
5:55 PM Changeset in webkit [119180] by rakuco@webkit.org
  • 68 edits
    32 adds in trunk/LayoutTests

[EFL] Unskip fast/multicol tests.

Most tests were passing and just needed new baselines. Only skip
the few failing ones.

  • platform/efl/Skipped:
  • platform/efl/fast/multicol/block-axis-horizontal-bt-expected.png: Added.
  • platform/efl/fast/multicol/block-axis-horizontal-bt-expected.txt: Added.
  • platform/efl/fast/multicol/block-axis-horizontal-tb-expected.png: Added.
  • platform/efl/fast/multicol/block-axis-horizontal-tb-expected.txt: Added.
  • platform/efl/fast/multicol/block-axis-vertical-lr-expected.png: Added.
  • platform/efl/fast/multicol/block-axis-vertical-lr-expected.txt: Added.
  • platform/efl/fast/multicol/block-axis-vertical-rl-expected.png: Added.
  • platform/efl/fast/multicol/block-axis-vertical-rl-expected.txt: Added.
  • platform/efl/fast/multicol/client-rects-expected.png: Added.
  • platform/efl/fast/multicol/client-rects-expected.txt: Added.
  • platform/efl/fast/multicol/column-count-with-rules-expected.png:
  • platform/efl/fast/multicol/column-rules-expected.png:
  • platform/efl/fast/multicol/column-rules-stacking-expected.png:
  • platform/efl/fast/multicol/columns-shorthand-parsing-expected.png:
  • platform/efl/fast/multicol/float-avoidance-expected.png:
  • platform/efl/fast/multicol/float-multicol-expected.png:
  • platform/efl/fast/multicol/float-paginate-complex-expected.png:
  • platform/efl/fast/multicol/float-paginate-complex-expected.txt:
  • platform/efl/fast/multicol/float-paginate-empty-lines-expected.png:
  • platform/efl/fast/multicol/float-paginate-expected.png:
  • platform/efl/fast/multicol/layers-in-multicol-expected.png:
  • platform/efl/fast/multicol/layers-split-across-columns-expected.png:
  • platform/efl/fast/multicol/margin-collapse-expected.png:
  • platform/efl/fast/multicol/max-height-columns-block-expected.png:
  • platform/efl/fast/multicol/nested-columns-expected.png:
  • platform/efl/fast/multicol/nested-columns-expected.txt:
  • platform/efl/fast/multicol/overflow-across-columns-expected.png:
  • platform/efl/fast/multicol/overflow-across-columns-percent-height-expected.png:
  • platform/efl/fast/multicol/overflow-unsplittable-expected.png:
  • platform/efl/fast/multicol/paginate-block-replaced-expected.png:
  • platform/efl/fast/multicol/pagination-h-horizontal-bt-expected.png: Added.
  • platform/efl/fast/multicol/pagination-h-horizontal-bt-expected.txt: Added.
  • platform/efl/fast/multicol/pagination-h-horizontal-tb-expected.png: Added.
  • platform/efl/fast/multicol/pagination-h-horizontal-tb-expected.txt: Added.
  • platform/efl/fast/multicol/pagination-h-vertical-lr-expected.png: Added.
  • platform/efl/fast/multicol/pagination-h-vertical-lr-expected.txt: Added.
  • platform/efl/fast/multicol/pagination-h-vertical-rl-expected.png: Added.
  • platform/efl/fast/multicol/pagination-h-vertical-rl-expected.txt: Added.
  • platform/efl/fast/multicol/pagination-v-horizontal-bt-expected.png: Added.
  • platform/efl/fast/multicol/pagination-v-horizontal-bt-expected.txt: Added.
  • platform/efl/fast/multicol/pagination-v-horizontal-tb-expected.png: Added.
  • platform/efl/fast/multicol/pagination-v-horizontal-tb-expected.txt: Added.
  • platform/efl/fast/multicol/pagination-v-vertical-lr-expected.png: Added.
  • platform/efl/fast/multicol/pagination-v-vertical-lr-expected.txt: Added.
  • platform/efl/fast/multicol/pagination-v-vertical-rl-expected.png: Added.
  • platform/efl/fast/multicol/pagination-v-vertical-rl-expected.txt: Added.
  • platform/efl/fast/multicol/positioned-split-expected.png:
  • platform/efl/fast/multicol/positioned-with-constrained-height-expected.png:
  • platform/efl/fast/multicol/positive-leading-expected.png:
  • platform/efl/fast/multicol/scrolling-overflow-expected.png:
  • platform/efl/fast/multicol/single-line-expected.png: Added.
  • platform/efl/fast/multicol/single-line-expected.txt: Added.
  • platform/efl/fast/multicol/span/anonymous-before-child-parent-crash-expected.png: Added.
  • platform/efl/fast/multicol/span/anonymous-split-block-crash-expected.png:
  • platform/efl/fast/multicol/span/anonymous-style-inheritance-expected.png:
  • platform/efl/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.png:
  • platform/efl/fast/multicol/span/clone-flexbox-expected.txt: Added.
  • platform/efl/fast/multicol/span/clone-summary-expected.txt: Added.
  • platform/efl/fast/multicol/span/span-as-immediate-child-complex-splitting-expected.png:
  • platform/efl/fast/multicol/span/span-as-immediate-child-generated-content-expected.png:
  • platform/efl/fast/multicol/span/span-as-immediate-child-property-removal-expected.png:
  • platform/efl/fast/multicol/span/span-as-immediate-child-property-removal-expected.txt:
  • platform/efl/fast/multicol/span/span-as-immediate-columns-child-dynamic-expected.png:
  • platform/efl/fast/multicol/span/span-as-immediate-columns-child-expected.png:
  • platform/efl/fast/multicol/span/span-as-immediate-columns-child-removal-expected.png:
  • platform/efl/fast/multicol/span/span-as-immediate-columns-child-removal-expected.txt:
  • platform/efl/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.png:
  • platform/efl/fast/multicol/span/span-as-nested-columns-child-expected.png:
  • platform/efl/fast/multicol/span/span-as-nested-inline-block-child-expected.png:
  • platform/efl/fast/multicol/span/span-margin-collapsing-expected.png:
  • platform/efl/fast/multicol/table-margin-collapse-expected.png:
  • platform/efl/fast/multicol/table-vertical-align-expected.png:
  • platform/efl/fast/multicol/table-vertical-align-expected.txt:
  • platform/efl/fast/multicol/unsplittable-inline-block-expected.png:
  • platform/efl/fast/multicol/vertical-lr/column-break-with-balancing-expected.png:
  • platform/efl/fast/multicol/vertical-lr/column-count-with-rules-expected.png:
  • platform/efl/fast/multicol/vertical-lr/column-rules-expected.png:
  • platform/efl/fast/multicol/vertical-lr/float-avoidance-expected.png:
  • platform/efl/fast/multicol/vertical-lr/float-multicol-expected.png:
  • platform/efl/fast/multicol/vertical-lr/float-paginate-complex-expected.png:
  • platform/efl/fast/multicol/vertical-lr/float-paginate-complex-expected.txt:
  • platform/efl/fast/multicol/vertical-lr/float-paginate-expected.png:
  • platform/efl/fast/multicol/vertical-lr/nested-columns-expected.png:
  • platform/efl/fast/multicol/vertical-lr/nested-columns-expected.txt:
  • platform/efl/fast/multicol/vertical-lr/unsplittable-inline-block-expected.png:
  • platform/efl/fast/multicol/vertical-rl/column-break-with-balancing-expected.png:
  • platform/efl/fast/multicol/vertical-rl/column-count-with-rules-expected.png:
  • platform/efl/fast/multicol/vertical-rl/column-rules-expected.png:
  • platform/efl/fast/multicol/vertical-rl/float-avoidance-expected.png:
  • platform/efl/fast/multicol/vertical-rl/float-multicol-expected.png:
  • platform/efl/fast/multicol/vertical-rl/float-paginate-complex-expected.png:
  • platform/efl/fast/multicol/vertical-rl/float-paginate-complex-expected.txt:
  • platform/efl/fast/multicol/vertical-rl/float-paginate-expected.png:
  • platform/efl/fast/multicol/vertical-rl/nested-columns-expected.png:
  • platform/efl/fast/multicol/vertical-rl/nested-columns-expected.txt:
  • platform/efl/fast/multicol/vertical-rl/rule-style-expected.txt: Added.
  • platform/efl/fast/multicol/vertical-rl/unsplittable-inline-block-expected.png:
  • platform/efl/test_expectations:
5:29 PM Changeset in webkit [119179] by danakj@chromium.org
  • 16 edits in branches/chromium/1132/Source

Merge 118383 - [chromium] Only display frames created with memory allocations meant to be displayed
​https://bugs.webkit.org/show_bug.cgi?id=85108

Reviewed by Adrienne Walker.

Source/WebCore:

In this patch we remove the setVisible() code paths from CCProxy, and
instead commit visiblity state along with a frame. We also commit a
flag with a frame that indicates if the frame is one that can be drawn.

The impl host is set to visible during commit instead of using a
special channel through the proxy, and the scheduler allows
commits when we are waiting to draw our first frame but blocked on
being non-visible.

canDraw is gated on a new flag that indicates if the frame is one meant
for display. A frame is meant for display if the frame was generated
with a memory allocation meant for display. At this time, any non-zero
memory allocation is considered meant for display.

We prevent races by not changing the memory allocation at any time
except during a commit. So we force a commit when the memory
allocation needs to be adjusted and we are not visible. Similarly,
we force a commit when visibility changes so that we are able to
commit the visibility change to the impl tree.

In order to prevent drawing frames that are not meant for display
with a single thread, we prevent compositing when the impl tree
is not visible, with an early out in CCSingleThreadProxy.

Unit tests: CCLayerTreeHostTestVisibilityAndAllocationControlDrawing

  • platform/graphics/chromium/LayerChromium.h:
  • platform/graphics/chromium/TiledLayerChromium.cpp:
  • platform/graphics/chromium/TiledLayerChromium.h:
  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::CCLayerTreeHost):
(WebCore::CCLayerTreeHost::initializeLayerRenderer):
(WebCore::CCLayerTreeHost::finishCommitOnImplThread):
(WebCore::CCLayerTreeHost::setNeedsCommit):
(WebCore):
(WebCore::CCLayerTreeHost::setNeedsForcedCommit):
(WebCore::CCLayerTreeHost::setVisible):
(WebCore::CCLayerTreeHost::setContentsMemoryAllocationLimitBytes):
(WebCore::CCLayerTreeHost::scheduleComposite):
(WebCore::CCLayerTreeHost::updateLayers):

  • platform/graphics/chromium/cc/CCLayerTreeHost.h:

(CCLayerTreeHost):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::CCLayerTreeHostImpl):
(WebCore::CCLayerTreeHostImpl::canDraw):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:

(WebCore::CCLayerTreeHostImpl::sourceFrameCanBeDrawn):
(WebCore::CCLayerTreeHostImpl::setSourceFrameCanBeDrawn):
(CCLayerTreeHostImpl):

  • platform/graphics/chromium/cc/CCProxy.h:

(CCProxy):

  • platform/graphics/chromium/cc/CCSchedulerStateMachine.cpp:

(WebCore::CCSchedulerStateMachine::drawSuspendedUntilCommit):
(WebCore::CCSchedulerStateMachine::scheduledToDraw):
(WebCore::CCSchedulerStateMachine::updateState):

  • platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:

(WebCore::CCSingleThreadProxy::doCommit):
(WebCore::CCSingleThreadProxy::setNeedsCommit):
(WebCore):
(WebCore::CCSingleThreadProxy::setNeedsForcedCommit):
(WebCore::CCSingleThreadProxy::doComposite):

  • platform/graphics/chromium/cc/CCSingleThreadProxy.h:
  • platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::CCThreadProxy):
(WebCore::CCThreadProxy::setNeedsForcedCommit):
(WebCore):
(WebCore::CCThreadProxy::setNeedsForcedCommitOnImplThread):
(WebCore::CCThreadProxy::forceBeginFrameOnImplThread):
(WebCore::CCThreadProxy::beginFrame):
(WebCore::CCThreadProxy::scheduledActionCommit):

  • platform/graphics/chromium/cc/CCThreadProxy.h:

(CCThreadProxy):

Source/WebKit/chromium:

Removing code to protect visible textures when a tab becomes invisible,
as we want to reduce our memory limit for invisible tabs and these
textures should not be saved.

  • src/NonCompositedContentHost.cpp:
  • src/NonCompositedContentHost.h:

(NonCompositedContentHost):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::setVisibilityState):

  • tests/CCLayerTreeHostTest.cpp:

(WTF::TestHooks::didCommit):
(WTF::CCLayerTreeHostTest::CCLayerTreeHostTest):
(WTF::CCLayerTreeHostTest::scheduleComposite):
(WTF::CCLayerTreeHostTest::dispatchComposite):
(CCLayerTreeHostTest):
(WTF::CCLayerTreeHostTest::doBeginTest):
(CCLayerTreeHostTestTickAnimationWhileBackgrounded):
(WTF::CCLayerTreeHostTestTickAnimationWhileBackgrounded::willAnimateLayers):
(CCLayerTreeHostTestVisibilityAndAllocationControlDrawing):
(WTF::CCLayerTreeHostTestVisibilityAndAllocationControlDrawing::CCLayerTreeHostTestVisibilityAndAllocationControlDrawing):
(WTF::CCLayerTreeHostTestVisibilityAndAllocationControlDrawing::beginTest):
(WTF::CCLayerTreeHostTestVisibilityAndAllocationControlDrawing::didCommitAndDrawFrame):
(WTF::CCLayerTreeHostTestVisibilityAndAllocationControlDrawing::didCommit):
(WTF::CCLayerTreeHostTestVisibilityAndAllocationControlDrawing::commitCompleteOnCCThread):
(WTF::CCLayerTreeHostTestVisibilityAndAllocationControlDrawing::afterTest):
(WTF):

TBR=​danakj@chromium.org

5:24 PM Changeset in webkit [119178] by jamesr@google.com
  • 65 edits in trunk/Source

[chromium] Migrate to WebTransformationMatrix
​https://bugs.webkit.org/show_bug.cgi?id=87788

Patch by Shawn Singh <​shawnsingh@chromium.org> on 2012-05-31
Reviewed by James Robinson.

Source/Platform:

  • chromium/public/WebTransformationMatrix.h:

(WebTransformationMatrix):

Source/WebCore:

Covered by all existing layout tests and unit tests.

This patch replaces all occurrences of WebCore::TransformationMatrix
with WebKit::WebTransformationMatrix in the chromium compositor code.

  • platform/chromium/support/WebTransformationMatrix.cpp:

(WebKit::WebTransformationMatrix::WebTransformationMatrix):
(WebKit):

  • platform/graphics/chromium/LayerChromium.cpp:

(WebCore::LayerChromium::setSublayerTransform):
(WebCore::LayerChromium::setTransform):
(WebCore::LayerChromium::setTransformFromAnimation):

  • platform/graphics/chromium/LayerChromium.h:

(LayerChromium):
(WebCore::LayerChromium::sublayerTransform):
(WebCore::LayerChromium::drawTransform):
(WebCore::LayerChromium::setDrawTransform):
(WebCore::LayerChromium::screenSpaceTransform):
(WebCore::LayerChromium::setScreenSpaceTransform):

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::drawCheckerboardQuad):
(WebCore::LayerRendererChromium::drawDebugBorderQuad):
(WebCore::LayerRendererChromium::drawBackgroundFilters):
(WebCore::LayerRendererChromium::drawRenderSurfaceQuad):
(WebCore::LayerRendererChromium::drawSolidColorQuad):
(WebCore::LayerRendererChromium::drawTileQuad):
(WebCore::LayerRendererChromium::drawHeadsUpDisplay):
(WebCore::LayerRendererChromium::toGLMatrix):
(WebCore::LayerRendererChromium::drawTexturedQuad):
(WebCore::LayerRendererChromium::copyTextureToFramebuffer):

  • platform/graphics/chromium/LayerRendererChromium.h:

(WebCore::LayerRendererChromium::projectionMatrix):
(WebCore::LayerRendererChromium::windowMatrix):
(LayerRendererChromium):

  • platform/graphics/chromium/LinkHighlight.cpp:

(WebCore::LinkHighlight::LinkHighlight):

  • platform/graphics/chromium/RenderSurfaceChromium.h:

(WebCore::RenderSurfaceChromium::drawTransform):
(WebCore::RenderSurfaceChromium::setDrawTransform):
(WebCore::RenderSurfaceChromium::originTransform):
(WebCore::RenderSurfaceChromium::setOriginTransform):
(WebCore::RenderSurfaceChromium::screenSpaceTransform):
(WebCore::RenderSurfaceChromium::setScreenSpaceTransform):
(WebCore::RenderSurfaceChromium::replicaDrawTransform):
(WebCore::RenderSurfaceChromium::setReplicaDrawTransform):
(WebCore::RenderSurfaceChromium::replicaOriginTransform):
(WebCore::RenderSurfaceChromium::setReplicaOriginTransform):
(WebCore::RenderSurfaceChromium::replicaScreenSpaceTransform):
(WebCore::RenderSurfaceChromium::setReplicaScreenSpaceTransform):
(RenderSurfaceChromium):

  • platform/graphics/chromium/TiledLayerChromium.cpp:

(WebCore::TiledLayerChromium::updateTiles):

  • platform/graphics/chromium/cc/CCAnimationCurve.h:

(WebCore):
(CCTransformAnimationCurve):

  • platform/graphics/chromium/cc/CCDamageTracker.cpp:

(WebCore::CCDamageTracker::extendDamageForLayer):
(WebCore::CCDamageTracker::extendDamageForRenderSurface):

  • platform/graphics/chromium/cc/CCDrawQuad.h:

(WebCore::CCDrawQuad::quadTransform):
(WebCore::CCDrawQuad::layerTransform):

  • platform/graphics/chromium/cc/CCKeyframedAnimationCurve.cpp:

(WebCore::CCTransformKeyframe::clone):
(WebCore::CCKeyframedTransformAnimationCurve::getValue):

  • platform/graphics/chromium/cc/CCKeyframedAnimationCurve.h:

(CCKeyframedTransformAnimationCurve):

  • platform/graphics/chromium/cc/CCLayerAnimationController.cpp:

(WebCore::CCLayerAnimationController::tickAnimations):

  • platform/graphics/chromium/cc/CCLayerAnimationController.h:

(WebKit):
(WebCore):
(CCLayerAnimationControllerClient):

  • platform/graphics/chromium/cc/CCLayerImpl.cpp:

(WebCore::CCLayerImpl::quadTransform):
(WebCore::CCLayerImpl::setTransformFromAnimation):
(WebCore::CCLayerImpl::setSublayerTransform):
(WebCore::CCLayerImpl::setTransform):

  • platform/graphics/chromium/cc/CCLayerImpl.h:

(CCLayerImpl):
(WebCore::CCLayerImpl::sublayerTransform):
(WebCore::CCLayerImpl::drawTransform):
(WebCore::CCLayerImpl::setDrawTransform):
(WebCore::CCLayerImpl::screenSpaceTransform):
(WebCore::CCLayerImpl::setScreenSpaceTransform):

  • platform/graphics/chromium/cc/CCLayerSorter.cpp:

(WebCore::CCLayerSorter::LayerShape::LayerShape):
(WebCore::CCLayerSorter::createGraphNodes):

  • platform/graphics/chromium/cc/CCLayerSorter.h:

(WebKit):
(LayerShape):

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::updateLayers):

  • platform/graphics/chromium/cc/CCLayerTreeHost.h:
  • platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:

(WebCore::CCLayerTreeHostCommon::calculateVisibleRect):
(WebCore::isSurfaceBackFaceVisible):
(WebCore::calculateVisibleLayerRect):
(WebCore::isScaleOrTranslation):
(WebCore::calculateDrawTransformsAndVisibilityInternal):
(WebCore::CCLayerTreeHostCommon::calculateDrawTransformsAndVisibility):

  • platform/graphics/chromium/cc/CCLayerTreeHostCommon.h:

(CCLayerTreeHostCommon):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::damageInSurfaceSpace):
(WebCore::CCLayerTreeHostImpl::calculateRenderSurfaceLayerList):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:

(WebCore):

  • platform/graphics/chromium/cc/CCMathUtil.cpp:

(WebCore::projectPoint):
(WebCore::mapPoint):
(WebCore::CCMathUtil::mapClippedRect):
(WebCore::CCMathUtil::projectClippedRect):
(WebCore::CCMathUtil::mapClippedQuad):
(WebCore::CCMathUtil::mapQuad):
(WebCore::CCMathUtil::projectQuad):

  • platform/graphics/chromium/cc/CCMathUtil.h:

(WebKit):
(WebCore):
(CCMathUtil):

  • platform/graphics/chromium/cc/CCOcclusionTracker.cpp:

(WebCore::transformSurfaceOpaqueRegion):
(WebCore::reduceOcclusionBelowSurface):
(WebCore::contentToScreenSpaceTransform):
(WebCore::contentToTargetSurfaceTransform):
(WebCore::addOcclusionBehindLayer):
(WebCore::::markOccludedBehindLayer):
(WebCore::testContentRectOccluded):
(WebCore::computeUnoccludedContentRect):
(WebCore::::unoccludedContributingSurfaceContentRect):

  • platform/graphics/chromium/cc/CCOcclusionTracker.h:
  • platform/graphics/chromium/cc/CCOverdrawMetrics.cpp:

(WebCore::CCOverdrawMetrics::didUpload):
(WebCore::CCOverdrawMetrics::didCullForDrawing):
(WebCore::CCOverdrawMetrics::didDraw):

  • platform/graphics/chromium/cc/CCOverdrawMetrics.h:

(WebKit):
(CCOverdrawMetrics):

  • platform/graphics/chromium/cc/CCQuadCuller.cpp:
  • platform/graphics/chromium/cc/CCRenderPass.cpp:

(WebCore::CCRenderPass::appendQuadsToFillScreen):

  • platform/graphics/chromium/cc/CCRenderSurface.h:

(WebCore::CCRenderSurface::setDrawTransform):
(WebCore::CCRenderSurface::drawTransform):
(WebCore::CCRenderSurface::setOriginTransform):
(WebCore::CCRenderSurface::originTransform):
(WebCore::CCRenderSurface::setScreenSpaceTransform):
(WebCore::CCRenderSurface::screenSpaceTransform):
(WebCore::CCRenderSurface::setReplicaDrawTransform):
(WebCore::CCRenderSurface::replicaDrawTransform):
(WebCore::CCRenderSurface::setReplicaOriginTransform):
(WebCore::CCRenderSurface::replicaOriginTransform):
(WebCore::CCRenderSurface::setReplicaScreenSpaceTransform):
(WebCore::CCRenderSurface::replicaScreenSpaceTransform):
(CCRenderSurface):

  • platform/graphics/chromium/cc/CCSharedQuadState.cpp:

(WebCore::CCSharedQuadState::create):
(WebCore::CCSharedQuadState::CCSharedQuadState):

  • platform/graphics/chromium/cc/CCSharedQuadState.h:

(CCSharedQuadState):
(WebCore::CCSharedQuadState::quadTransform):
(WebCore::CCSharedQuadState::layerTransform):

  • platform/graphics/chromium/cc/CCSolidColorLayerImpl.cpp:

(WebCore::CCSolidColorLayerImpl::quadTransform):

  • platform/graphics/chromium/cc/CCSolidColorLayerImpl.h:

(CCSolidColorLayerImpl):

  • platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:

(WebCore::CCTiledLayerImpl::quadTransform):

  • platform/graphics/chromium/cc/CCTiledLayerImpl.h:

(CCTiledLayerImpl):

Source/WebKit/chromium:

  • src/WebLayer.cpp:

(WebKit::WebLayer::setSublayerTransform):
(WebKit::WebLayer::setTransform):

  • tests/CCAnimationTestCommon.cpp:

(WebKitTests::FakeTransformTransition::getValue):

  • tests/CCAnimationTestCommon.h:
  • tests/CCDamageTrackerTest.cpp:

(WebKitTests::executeCalculateDrawTransformsAndVisibility):
(WebKitTests::TEST_F):

  • tests/CCKeyframedAnimationCurveTest.cpp:
  • tests/CCLayerAnimationControllerTest.cpp:
  • tests/CCLayerImplTest.cpp:

(WebCore::TEST):

  • tests/CCLayerIteratorTest.cpp:
  • tests/CCLayerSorterTest.cpp:
  • tests/CCLayerTreeHostCommonTest.cpp:
  • tests/CCLayerTreeHostTest.cpp:

(WTF::CCLayerTreeHostTestDeviceScaleFactorScalesViewportAndLayers::commitCompleteOnCCThread):
(WTF::setLayerPropertiesForTesting):
(WTF::CCLayerTreeHostTestAtomicCommitWithPartialUpdate::beginTest):
(WTF::setTestLayerPropertiesForTesting):
(WTF::CCLayerTreeHostTestLayerOcclusion::beginTest):
(WTF::CCLayerTreeHostTestLayerOcclusionWithFilters::beginTest):
(WTF::CCLayerTreeHostTestManySurfaces::beginTest):

  • tests/CCLayerTreeTestCommon.h:

(WebKitTests):

  • tests/CCMathUtilTest.cpp:
  • tests/CCOcclusionTrackerTest.cpp:

(WebKitTests::CCOcclusionTrackerTest::createRoot):
(WebKitTests::CCOcclusionTrackerTest::createLayer):
(WebKitTests::CCOcclusionTrackerTest::createSurface):
(WebKitTests::CCOcclusionTrackerTest::createDrawingLayer):
(WebKitTests::CCOcclusionTrackerTest::createReplicaLayer):
(WebKitTests::CCOcclusionTrackerTest::createDrawingSurface):
(CCOcclusionTrackerTest):
(WebKitTests::CCOcclusionTrackerTest::setBaseProperties):
(WebKitTests::CCOcclusionTrackerTest::setProperties):
(WebKitTests::CCOcclusionTrackerTestRotatedChild::runMyTest):
(WebKitTests::CCOcclusionTrackerTestTranslatedChild::runMyTest):
(WebKitTests::CCOcclusionTrackerTestChildInRotatedChild::runMyTest):
(WebKitTests::CCOcclusionTrackerTestVisitTargetTwoTimes::runMyTest):
(WebKitTests::CCOcclusionTrackerTestSurfaceRotatedOffAxis::runMyTest):
(WebKitTests::CCOcclusionTrackerTestSurfaceWithTwoOpaqueChildren::runMyTest):
(WebKitTests::CCOcclusionTrackerTestOverlappingSurfaceSiblings::runMyTest):
(WebKitTests::CCOcclusionTrackerTestOverlappingSurfaceSiblingsWithTwoTransforms::runMyTest):
(WebKitTests::CCOcclusionTrackerTestFilters::runMyTest):
(WebKitTests::CCOcclusionTrackerTest3dTransform::runMyTest):
(WebKitTests::CCOcclusionTrackerTestPerspectiveTransform::runMyTest):
(WebKitTests::CCOcclusionTrackerTestPerspectiveTransformBehindCamera::runMyTest):
(WebKitTests::CCOcclusionTrackerTestLayerBehindCameraDoesNotOcclude::runMyTest):
(WebKitTests::CCOcclusionTrackerTestLargePixelsOccludeInsideClipRect::runMyTest):
(WebKitTests::CCOcclusionTrackerTestSurfaceOcclusionTranslatesToParent::runMyTest):
(WebKitTests::CCOcclusionTrackerTestDontOccludePixelsNeededForBackgroundFilter::runMyTest):
(WebKitTests::CCOcclusionTrackerTestTwoBackgroundFiltersReduceOcclusionTwice::runMyTest):
(WebKitTests::CCOcclusionTrackerTestDontReduceOcclusionBelowBackgroundFilter::runMyTest):
(WebKitTests::CCOcclusionTrackerTestDontReduceOcclusionIfBackgroundFilterIsOccluded::runMyTest):
(WebKitTests::CCOcclusionTrackerTestReduceOcclusionWhenBackgroundFilterIsPartiallyOccluded::runMyTest):

  • tests/CCQuadCullerTest.cpp:
  • tests/CCRenderSurfaceTest.cpp:
  • tests/FloatQuadTest.cpp:
  • tests/LayerChromiumTest.cpp:
  • tests/LinkHighlightTest.cpp:
  • tests/TiledLayerChromiumTest.cpp:
  • tests/WebTransformationMatrixTest.cpp:

(WebKit::TEST):
(WebKit):

5:05 PM Changeset in webkit [119177] by danakj@chromium.org
  • 2 edits in branches/chromium/1132/Source/WebKit/chromium

Merge 118276 - [chromium] Enable the CCLayerTreeHostTestCanDrawBlocksDrawing test in single-threaded mode
​https://bugs.webkit.org/show_bug.cgi?id=87308

Reviewed by James Robinson.

Chromium bug: ​http://crbug.com/127481

Unit test: CCLayerTreeHostTestCanDrawBlocksDrawing.runSingleThread

  • tests/CCLayerTreeHostTest.cpp:

(WTF::TestHooks::didCommit):
(WTF):
(WTF::CCLayerTreeHostTestCanDrawBlocksDrawing::didCommit):

TBR=​danakj@chromium.org
Review URL: ​https://chromiumcodereview.appspot.com/10456072

5:02 PM Changeset in webkit [119176] by piman@chromium.org
  • 1 edit in branches/chromium/1132/Source/WebCore/platform/graphics/chromium/cc/CCThreadProxy.cpp

Merge 117825 - Don't force rendering in finishAllRendering
​https://bugs.webkit.org/show_bug.cgi?id=86919

Reviewed by James Robinson.

After we acquire the texture layers on the main thread, we can't draw.
In particular if we destroyed the texture ids used previously by
TextureLayerChromium, drawing before a commit would cause a
bind-after-destroy.

Tested by CCLayerTreeHostTestFinishAllRendering.

  • platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::CCThreadProxy):
(WebCore::CCThreadProxy::finishAllRenderingOnImplThread):
(WebCore::CCThreadProxy::scheduledActionDrawAndSwapInternal):

TBR=​piman@chromium.org
Review URL: ​https://chromiumcodereview.appspot.com/10448114

5:02 PM Changeset in webkit [119175] by mhahnenberg@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

JSGlobalObject does not mark m_privateNameStructure
​https://bugs.webkit.org/show_bug.cgi?id=88023

Rubber stamped by Gavin Barraclough.

  • runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::visitChildren): We need to mark this so it doesn't get
inadvertently garbage collected.

4:53 PM Changeset in webkit [119174] by jberlin@webkit.org
  • 1 edit
    7 adds in trunk/LayoutTests

[Win] 4 css3 tests fail
​https://bugs.webkit.org/show_bug.cgi?id=88024

Add Windows-specific expected (failing?) results to get the bots green.

  • platform/win/css3: Added.
  • platform/win/css3/filters: Added.
  • platform/win/css3/filters/composited-during-animation-expected.txt: Added.
  • platform/win/css3/filters/composited-during-animation-layertree-expected.txt: Added.
  • platform/win/css3/filters/composited-during-transition-layertree-expected.txt: Added.
  • platform/win/css3/unicode-bidi-isolate-basic-expected.png: Added.
  • platform/win/css3/unicode-bidi-isolate-basic-expected.txt: Added.
4:48 PM Changeset in webkit [119173] by commit-queue@webkit.org
  • 5 edits in trunk/Source

[chromium] Single thread proxy should not tick animations unless the layer renderer has been initialized
​https://bugs.webkit.org/show_bug.cgi?id=87873

Patch by Ian Vollick <​vollick@chromium.org> on 2012-05-31
Reviewed by James Robinson.

When the layer renderer fails to initialize, be sure to stop the animation timer.

Source/WebCore:

Unit test: CCLayerTreeHostTestInitializeLayerRendererFailsAfterAddAnimation.runSingleThread

  • platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:

(WebCore::CCSingleThreadProxy::initializeLayerRenderer):
(WebCore::CCSingleThreadProxy::didAddAnimation):
(WebCore::CCSingleThreadProxy::animationTimerDelay):
(WebCore):

  • platform/graphics/chromium/cc/CCSingleThreadProxy.h:

Source/WebKit/chromium:

  • tests/CCLayerTreeHostTest.cpp:

(CompositorFakeWebGraphicsContext3DWithTextureTracking):
(WTF::CompositorFakeWebGraphicsContext3DWithTextureTracking::create):
(WTF::CompositorFakeWebGraphicsContext3DWithTextureTracking::createTexture):
(WTF::CompositorFakeWebGraphicsContext3DWithTextureTracking::deleteTexture):
(WTF::CompositorFakeWebGraphicsContext3DWithTextureTracking::bindTexture):
(WTF::CompositorFakeWebGraphicsContext3DWithTextureTracking::numTextures):
(WTF::CompositorFakeWebGraphicsContext3DWithTextureTracking::texture):
(WTF::CompositorFakeWebGraphicsContext3DWithTextureTracking::resetTextures):
(WTF::CompositorFakeWebGraphicsContext3DWithTextureTracking::numUsedTextures):
(WTF::CompositorFakeWebGraphicsContext3DWithTextureTracking::usedTexture):
(WTF::CompositorFakeWebGraphicsContext3DWithTextureTracking::resetUsedTextures):
(WTF::CompositorFakeWebGraphicsContext3DWithTextureTracking::CompositorFakeWebGraphicsContext3DWithTextureTracking):
(WTF):
(WTF::TestHooks::didRecreateContext):
(TestHooks):
(WTF::TestHooks::createContext):
(CCLayerTreeHostTest):
(WTF::CCLayerTreeHostTest::clearEndTestTask):
(WTF::CCLayerTreeHostTest::CCLayerTreeHostTest):
(EndTestTask):
(WTF::CCLayerTreeHostTest::EndTestTask::EndTestTask):
(WTF::CCLayerTreeHostTest::EndTestTask::~EndTestTask):
(WTF::CCLayerTreeHostTest::EndTestTask::clearTest):
(WTF::CCLayerTreeHostTest::EndTestTask::run):
(WTF::CCLayerTreeHostTest::runTest):
(WTF::CCLayerTreeHostTest::endTestAfterDelay):
(FakeWebGraphicsContext3DMakeCurrentFails):
(WTF::FakeWebGraphicsContext3DMakeCurrentFails::makeContextCurrent):
(CCLayerTreeHostTestInitializeLayerRendererFailsAfterAddAnimation):
(WTF::CCLayerTreeHostTestInitializeLayerRendererFailsAfterAddAnimation::CCLayerTreeHostTestInitializeLayerRendererFailsAfterAddAnimation):
(WTF::CCLayerTreeHostTestInitializeLayerRendererFailsAfterAddAnimation::beginTest):
(WTF::CCLayerTreeHostTestInitializeLayerRendererFailsAfterAddAnimation::animateLayers):
(WTF::CCLayerTreeHostTestInitializeLayerRendererFailsAfterAddAnimation::didRecreateContext):
(WTF::CCLayerTreeHostTestInitializeLayerRendererFailsAfterAddAnimation::afterTest):
(WTF::TEST_F):

4:48 PM WikiStart edited by alex.bravo@nokia.com
Added "(obsolete)" to "Result Fallback Order" (diff)
4:25 PM Changeset in webkit [119172] by Simon Fraser
  • 3 edits in trunk/Source/WebCore

RenderLayerCompositor cleanup: make RenderGeometryMap part of the OverlapMap
​https://bugs.webkit.org/show_bug.cgi?id=88021

Reviewed by James Robinson.

We only ever use the RenderGeometryMap when we have an OverlapMap, so make
it a member of the OverlapMap.

No behavior change.

  • rendering/RenderLayerCompositor.cpp:

(RenderLayerCompositor::OverlapMap):
(WebCore::RenderLayerCompositor::OverlapMap::geometryMap):
(WebCore::RenderLayerCompositor::updateCompositingLayers):
(WebCore::RenderLayerCompositor::addToOverlapMap):
(WebCore::RenderLayerCompositor::addToOverlapMapRecursive):
(WebCore::RenderLayerCompositor::computeCompositingRequirements):

  • rendering/RenderLayerCompositor.h:

(WebCore):
(RenderLayerCompositor):

4:13 PM Changeset in webkit [119171] by haraken@chromium.org
  • 6 edits in trunk/Source/WebCore

[V8] Pass Isolate to v8Boolean()
​https://bugs.webkit.org/show_bug.cgi?id=87948

Reviewed by Adam Barth.

The objective is to pass Isolate around in V8 bindings.
This patch passes Isolate to v8Boolean().

No tests. No change in behavior.

  • bindings/v8/SerializedScriptValue.cpp:
  • bindings/v8/custom/V8DOMStringMapCustom.cpp:

(WebCore::V8DOMStringMap::namedPropertyDeleter):

  • bindings/v8/custom/V8InjectedScriptHostCustom.cpp:

(WebCore::V8InjectedScriptHost::isHTMLAllCollectionCallback):

  • bindings/v8/custom/V8StorageCustom.cpp:

(WebCore::storageDeleter):

  • bindings/v8/custom/V8WebSocketCustom.cpp:

(WebCore::V8WebSocket::sendCallback):

4:12 PM Changeset in webkit [119170] by Martin Robinson
  • 1 edit in trunk/Source/WebKit/gtk/ChangeLog

Fix a broken ChangeLog entry from r119113 due to a corrupted patch.

4:02 PM Changeset in webkit [119169] by Lucas Forschler
  • 4 edits in branches/safari-536-branch/Source

Versioning.

4:01 PM Changeset in webkit [119168] by Lucas Forschler
  • 1 copy in tags/Safari-536.15

New Tag.

4:00 PM Changeset in webkit [119167] by Lucas Forschler
  • 4 edits in branches/safari-536-branch/Source

Versioning.

4:00 PM Changeset in webkit [119166] by jberlin@webkit.org
  • 8 edits
    12 adds in trunk/LayoutTests

[Win] 10 fast/forms tests failing
​https://bugs.webkit.org/show_bug.cgi?id=88013

Add/update Windows-expected (failing?) results to get the bots greener.

  • platform/win/fast/forms/basic-selects-expected.png: Added.
  • platform/win/fast/forms/basic-selects-expected.txt:
  • platform/win/fast/forms/fieldset-legend-padding-unclipped-fieldset-border-expected.png:
  • platform/win/fast/forms/fieldset-legend-padding-unclipped-fieldset-border-expected.txt:
  • platform/win/fast/forms/file: Added.
  • platform/win/fast/forms/file/file-input-disabled-expected.png: Added.
  • platform/win/fast/forms/file/file-input-disabled-expected.txt: Added.
  • platform/win/fast/forms/implicit-submission-expected.txt:
  • platform/win/fast/forms/input-step-as-double-expected.txt: Added.
  • platform/win/fast/forms/input-text-drag-down-expected.png:
  • platform/win/fast/forms/input-text-drag-down-expected.txt:
  • platform/win/fast/forms/select: Added.
  • platform/win/fast/forms/select-overflow-scroll-expected.png: Added.
  • platform/win/fast/forms/select-overflow-scroll-expected.txt: Added.
  • platform/win/fast/forms/select-overflow-scroll-inherited-expected.png: Added.
  • platform/win/fast/forms/select-overflow-scroll-inherited-expected.txt: Added.
  • platform/win/fast/forms/select/optgroup-rendering-expected.png: Added.
  • platform/win/fast/forms/select/optgroup-rendering-expected.txt: Added.
  • platform/win/fast/forms/text-control-intrinsic-widths-expected.txt:
3:58 PM Changeset in webkit [119165] by Lucas Forschler
  • 3 edits in branches/safari-536-branch/Source/WebCore

fix after r119150.

3:54 PM Changeset in webkit [119164] by brettw@chromium.org
  • 4 edits in trunk/Source/WebKit/chromium

2012-05-15 Brett Wilson <​brettw@chromium.org>

Hook up GTK IsKeyPad flag for keyboard events, and preserve this flag
on all platforms when converting back to a WebKeyboardEvent.

​https://bugs.webkit.org/show_bug.cgi?id=86514

Reviewed by Dimitri Glazkov.

  • src/WebInputEventConversion.cpp: (WebKit::WebKeyboardEventBuilder::WebKeyboardEventBuilder):
  • src/gtk/WebInputEventFactory.cpp: (WebKit::WebInputEventFactory::keyboardEvent):
  • tests/WebInputEventFactoryTestGtk.cpp:
3:53 PM Changeset in webkit [119163] by Lucas Forschler
  • 1 delete in tags/Safari-536.15

Remove Tag.

3:50 PM Changeset in webkit [119162] by andersca@apple.com
  • 2 edits in trunk/Source/WTF

Enable support for rvalue references when building with a version of clang that supports them
​https://bugs.webkit.org/show_bug.cgi?id=88018

Re-enable support for rvalue references when building with a version of Xcode newer than 4.2.

  • wtf/Compiler.h:
3:47 PM Changeset in webkit [119161] by commit-queue@webkit.org
  • 78 edits in trunk

IndexedDB: Implement IDBTransaction.error and IDBRequest.error
​https://bugs.webkit.org/show_bug.cgi?id=87865

Patch by Alec Flett <​alecflett@chromium.org> on 2012-05-31
Reviewed by Tony Chang.

Source/WebCore:

Added "error" attribute to IDBRequest and IDBTransaction. Update
IDBDatabaseError to honor the IDBDatabaseException behavior
of dealing with IDB-specific throws of DOMException codes,
as per the spec.

Existing tests which previously tested 'errorCode' and
'webkitErrorMessage' have been updated to use the new attribute.

  • Modules/indexeddb/IDBCursor.cpp:

(WebCore::IDBCursor::advance):

  • Modules/indexeddb/IDBDatabaseBackendImpl.cpp:

(WebCore::IDBDatabaseBackendImpl::setVersion):

  • Modules/indexeddb/IDBDatabaseError.h:

(WebCore::IDBDatabaseError::create):
(WebCore::IDBDatabaseError::code):
(WebCore::IDBDatabaseError::idbCode):
(WebCore::IDBDatabaseError::name):
(WebCore::IDBDatabaseError::IDBDatabaseError):
(IDBDatabaseError):

  • Modules/indexeddb/IDBDatabaseException.cpp:

(WebCore):
(WebCore::getErrorEntry):
(WebCore::IDBDatabaseException::initializeDescription):
(WebCore::IDBDatabaseException::getErrorName):
(WebCore::IDBDatabaseException::getLegacyErrorCode):

  • Modules/indexeddb/IDBDatabaseException.h:

(IDBDatabaseException):

  • Modules/indexeddb/IDBObjectStore.cpp:

(WebCore::IDBObjectStore::createIndex):

  • Modules/indexeddb/IDBRequest.cpp:

(WebCore::IDBRequest::error):
(WebCore):
(WebCore::IDBRequest::resetReadyState):
(WebCore::IDBRequest::abort):
(WebCore::IDBRequest::onError):
(WebCore::IDBRequest::onSuccess):
(WebCore::IDBRequest::onSuccessWithContinuation):
(WebCore::IDBRequest::dispatchEvent):

  • Modules/indexeddb/IDBRequest.h:

(IDBRequest):

  • Modules/indexeddb/IDBRequest.idl:
  • Modules/indexeddb/IDBTransaction.cpp:

(WebCore::IDBTransaction::error):
(WebCore):
(WebCore::IDBTransaction::setError):

  • Modules/indexeddb/IDBTransaction.h:

(IDBTransaction):

  • Modules/indexeddb/IDBTransaction.idl:

Source/WebKit/chromium:

IDBDatabaseError now honors IDB-specific DOMException codes,
so make sure that's how they are passed to/from chromium.

  • src/WebIDBDatabaseError.cpp:

(WebKit::WebIDBDatabaseError::assign):

LayoutTests:

  • storage/indexeddb/basics-expected.txt:
  • storage/indexeddb/basics-workers-expected.txt:
  • storage/indexeddb/create-and-remove-object-store-expected.txt:
  • storage/indexeddb/cursor-continue-expected.txt:
  • storage/indexeddb/cursor-update-expected.txt:
  • storage/indexeddb/database-basics-expected.txt:
  • storage/indexeddb/deleteIndex-expected.txt:
  • storage/indexeddb/factory-cmp-expected.txt:
  • storage/indexeddb/get-keyrange-expected.txt:
  • storage/indexeddb/index-basics-expected.txt:
  • storage/indexeddb/index-basics-workers-expected.txt:
  • storage/indexeddb/index-count-expected.txt:
  • storage/indexeddb/index-unique-expected.txt:
  • storage/indexeddb/invalid-keys-expected.txt:
  • storage/indexeddb/key-generator-expected.txt:
  • storage/indexeddb/key-type-array-expected.txt:
  • storage/indexeddb/keypath-edges-expected.txt:
  • storage/indexeddb/keyrange-expected.txt:
  • storage/indexeddb/objectstore-autoincrement-expected.txt:
  • storage/indexeddb/objectstore-basics-expected.txt:
  • storage/indexeddb/objectstore-basics-workers-expected.txt:
  • storage/indexeddb/objectstore-count-expected.txt:
  • storage/indexeddb/open-cursor-expected.txt:
  • storage/indexeddb/readonly-expected.txt:
  • storage/indexeddb/resources/basics.js:

(test):
(openCallback):

  • storage/indexeddb/resources/create-and-remove-object-store.js:

(testCreateAndRemove):
(cleanDatabase):
(tryOnceMore):

  • storage/indexeddb/resources/cursor-continue.js:

(ascendingErrorTestLessThan.request.onsuccess):
(ascendingErrorTestLessThan):
(ascendingErrorTestEqual.request.onsuccess):
(ascendingErrorTestEqual):
(descendingErrorTestGreaterThan.request.onsuccess):
(descendingErrorTestGreaterThan):
(descendingErrorTestEqual.request.onsuccess):
(descendingErrorTestEqual):
(onTransactionComplete):

  • storage/indexeddb/resources/cursor-update.js:

(keyCursor):

  • storage/indexeddb/resources/database-basics.js:

(testClose):

  • storage/indexeddb/resources/database-quota.js:

(logError):

  • storage/indexeddb/resources/deleteIndex.js:

(twiddleIndexes):
(postTwiddling):

  • storage/indexeddb/resources/factory-cmp.js:

(testValidKeys):
(testInvalidKeys):

  • storage/indexeddb/resources/get-keyrange.js:

(getNullTest):

  • storage/indexeddb/resources/index-basics.js:

(index3Count):

  • storage/indexeddb/resources/index-count.js:
  • storage/indexeddb/resources/index-unique.js:

(addMoreDataFailed):

  • storage/indexeddb/resources/invalid-keys.js:
  • storage/indexeddb/resources/key-generator.js:
  • storage/indexeddb/resources/key-type-array.js:

(testDepthLimits):

  • storage/indexeddb/resources/keypath-edges.js:
  • storage/indexeddb/resources/keyrange.js:

(test):

  • storage/indexeddb/resources/objectstore-autoincrement.js:

(getAbrahamSuccess):

  • storage/indexeddb/resources/objectstore-basics.js:

(setVersionSuccess):
(createIndex):
(addAgainFailure):
(removeSuccessButNotThere):
(testPreConditions.request.onsuccess):
(testPreConditions):

  • storage/indexeddb/resources/objectstore-count.js:
  • storage/indexeddb/resources/open-cursor.js:

(cursorWithKeySuccess):
(cursorSuccess):

  • storage/indexeddb/resources/readonly.js:

(openSuccess):

  • storage/indexeddb/resources/set_version_queue.js:

(connectionError):

  • storage/indexeddb/resources/shared.js:

(unexpectedErrorCallback):
(evalAndExpectException):

  • storage/indexeddb/resources/transaction-abort-workers.js:

(transactionAborted):
(transactionCompleted):
(timeoutTest.transaction.onabort):
(timeoutTest):
(errorTransactionAborted):

  • storage/indexeddb/resources/transaction-abort.js:

(firstAdd):
(secondAdd):
(transactionAborted):

  • storage/indexeddb/resources/transaction-after-close.js:

(firstTransactionComplete):

  • storage/indexeddb/resources/transaction-and-objectstore-calls.js:

(created):
(afterComplete):

  • storage/indexeddb/resources/transaction-basics.js:

(testInactiveAbortedTransaction):
(testInactiveCompletedTransaction):
(testInvalidMode):

  • storage/indexeddb/resources/transaction-read-only.js:

(setVersionDone):
(gotCursor):

  • storage/indexeddb/set_version_queue-expected.txt:
  • storage/indexeddb/transaction-abort-expected.txt:
  • storage/indexeddb/transaction-abort-workers-expected.txt:
  • storage/indexeddb/transaction-after-close-expected.txt:
  • storage/indexeddb/transaction-and-objectstore-calls-expected.txt:
  • storage/indexeddb/transaction-basics-expected.txt:
  • storage/indexeddb/transaction-read-only-expected.txt:
3:43 PM Changeset in webkit [119160] by jamesr@google.com
  • 4 edits in trunk/Source

[chromium] Assertion failures during compositor startup in lost context situations
​https://bugs.webkit.org/show_bug.cgi?id=87912

Reviewed by Adrienne Walker.

Source/WebCore:

getShaderiv and getProgramiv may return 0 if the context is lost. We correctly recover in this case, so it's
bogus to fail an ASSERT in debug in this case.

Added new unit test in LayerRendererChromiumTest to cover this.

  • platform/graphics/chromium/ProgramBinding.cpp:

(WebCore::contextLost):
(WebCore):
(WebCore::ProgramBindingBase::init):
(WebCore::ProgramBindingBase::createShaderProgram):

Source/WebKit/chromium:

Adds a unit test verifying that even if we lose our context during or before initialization we get through the
rest of the path without failing ASSERT()s.

  • tests/LayerRendererChromiumTest.cpp:

(LoseContextOnFirstGetContext):
(LoseContextOnFirstGetContext::LoseContextOnFirstGetContext):
(TEST):

3:37 PM Changeset in webkit [119159] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/gtk

Unreviewed, rolling out r119113.
​http://trac.webkit.org/changeset/119113
​https://bugs.webkit.org/show_bug.cgi?id=88016

This caused multiple regressions (Requested by mrobinson on
#webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-05-31

  • WebCoreSupport/TextCheckerClientGtk.cpp:

(WebKit::TextCheckerClientGtk::checkSpellingOfString):

  • webkit/webkitspellcheckerenchant.cpp:

(checkSpellingOfString):

3:36 PM Acronyms edited by alex.bravo@nokia.com
(diff)
3:34 PM Changeset in webkit [119158] by benm@google.com
  • 5 edits
    3 adds in trunk

Fix crash in V8Document::createTouchListCallback.
​https://bugs.webkit.org/show_bug.cgi?id=87085

Source/WebCore:

Reviewed by Abhishek Arya.

Test: fast/events/touch/document-create-touch-list-crash.html

  • bindings/v8/custom/V8DocumentCustom.cpp:

(WebCore::V8Document::createTouchListCallback): Verify the native type
of the arguments passed to createTouchList are Touches before appending
them to the TouchList. In the case of a non-Touch argument, insert
null into the TouchList. This consolidates V8 and JSC bindings
behaviour.

  • dom/Document.cpp: Remove dead code.
  • dom/Document.h: ditto.

LayoutTests:

Test for crash in document.createTouchList when it
is supplied with non-touch parameters.

Reviewed by Abhishek Arya.

  • fast/events/touch/document-create-touch-list-crash-expected.txt: Added.
  • fast/events/touch/document-create-touch-list-crash.html: Added.
3:30 PM Changeset in webkit [119157] by fpizlo@apple.com
  • 2 edits in trunk/Source/WTF

DataLog should be usable outside of JSC
​https://bugs.webkit.org/show_bug.cgi?id=88015

Reviewed by Oliver Hunt.

  • wtf/DataLog.h:

(WTF):

3:18 PM Changeset in webkit [119156] by rafaelw@chromium.org
  • 1 edit
    2 adds in trunk/LayoutTests

Updating test expectations after r119124.

  • platform/chromium/fast/workers/storage/test-authorizer-sync-expected.txt: Added.
3:06 PM Changeset in webkit [119155] by Lucas Forschler
  • 4 edits in branches/safari-536-branch/Source

Versioning.

3:03 PM Changeset in webkit [119154] by Lucas Forschler
  • 1 copy in tags/Safari-536.15

New Tag.

2:51 PM Changeset in webkit [119153] by rniwa@webkit.org
  • 2 edits in trunk/Tools

[Chromium] Chromium DRT should be able to load external resources
​https://bugs.webkit.org/show_bug.cgi?id=87893

Reviewed by Dirk Pranke.

Allow external resources to be loaded when the main frame's URL is also an external resource.
This change is analogous to r118231 for Mac port.

  • DumpRenderTree/chromium/WebViewHost.cpp:

(blockRequest):
(isLocalhost):
(hostIsUsedBySomeTestsToGenerateError):
(WebViewHost::willSendRequest):

2:32 PM SettingUpDevelopmentEnvironmentForN9 edited by Luciano Miguel Wolf
(diff)
2:26 PM Changeset in webkit [119152] by ap@apple.com
  • 4 edits in branches/safari-536-branch/LayoutTests

More result updating for disabling CSS Exclusions.

  • platform/mac/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/mac/svg/css/getComputedStyle-basic-expected.txt:
2:21 PM Changeset in webkit [119151] by Simon Fraser
  • 3 edits in trunk/Source/WebCore

Remove some duplicate code in RenderLayerCompositor
​https://bugs.webkit.org/show_bug.cgi?id=88009

Reviewed by Anders Carlsson.

RenderLayerCompositor::hasNonAffineTransform() has the same code
as the existing RenderLayer::has3DTransform(), so just use the
RenderLayer method and remove hasNonAffineTransform().

No behavior change.

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::computeCompositingRequirements):

  • rendering/RenderLayerCompositor.h:

(RenderLayerCompositor):

2:20 PM Changeset in webkit [119150] by Lucas Forschler
  • 34 edits in branches/safari-536-branch

Merge <rdar://problem/11524921>

2:15 PM Changeset in webkit [119149] by jberlin@webkit.org
  • 1 edit
    5 adds in trunk/LayoutTests

[Win] 5 fast/events/popup-* tests fail
​https://bugs.webkit.org/show_bug.cgi?id=88008

Add Windows-specific expected (failing?) results to get the bots greener.

  • platform/win/fast/events/popup-allowed-from-gesture-initiated-event-expected.txt: Added.
  • platform/win/fast/events/popup-allowed-from-gesture-initiated-form-submit-expected.txt: Added.
  • platform/win/fast/events/popup-blocked-from-fake-user-gesture-expected.txt: Added.
  • platform/win/fast/events/popup-blocked-from-untrusted-mouse-click-expected.txt: Added.
  • platform/win/fast/events/popup-blocking-timers-expected.txt: Added.
2:12 PM Changeset in webkit [119148] by ap@apple.com
  • 4 edits in branches/safari-536-branch/LayoutTests

Updating results after r119051.

Per discussion with Simon, it's not surprising that more layers have drawsContents now.

  • compositing/layer-creation/overlap-animation-expected.txt:
  • compositing/layer-creation/overlap-transforms-expected.txt:
  • compositing/overflow/clip-descendents-expected.txt:
2:10 PM Changeset in webkit [119147] by jberlin@webkit.org
  • 13 edits
    8 adds in trunk/LayoutTests

[Win] 23 media tests fail / time out
​https://bugs.webkit.org/show_bug.cgi?id=88005

Add/update the Windows expected (failing?) results to get the bots greener.

  • platform/win/Skipped:
  • platform/win/media/audio-controls-rendering-expected.txt:
  • platform/win/media/audio-repaint-expected.txt:
  • platform/win/media/controls-after-reload-expected.txt:
  • platform/win/media/controls-strict-expected.txt:
  • platform/win/media/controls-styling-expected.txt:
  • platform/win/media/controls-without-preload-expected.txt:
  • platform/win/media/media-can-play-wav-audio-expected.txt: Added.
  • platform/win/media/media-controls-clone-expected.txt:
  • platform/win/media/media-controls-invalid-url-expected.txt: Added.
  • platform/win/media/media-document-audio-repaint-expected.txt:
  • platform/win/media/nodesFromRect-shadowContent-expected.txt: Added.
  • platform/win/media/video-colorspace-yuv420-expected.txt: Added.
  • platform/win/media/video-colorspace-yuv422-expected.txt: Added.
  • platform/win/media/video-controls-rendering-expected.txt:
  • platform/win/media/video-display-toggle-expected.txt:
  • platform/win/media/video-no-audio-expected.txt:
  • platform/win/media/video-pause-immediately-expected.txt: Added.
  • platform/win/media/video-playing-and-pause-expected.txt: Added.
  • platform/win/media/video-size-intrinsic-scale-expected.txt: Added.
2:09 PM Changeset in webkit [119146] by rafaelw@chromium.org
  • 22 edits in trunk/Source

Unreviewed, rolling out r119125.
​http://trac.webkit.org/changeset/119125
​https://bugs.webkit.org/show_bug.cgi?id=88007

Will break android build if rolled (Requested by rafaelw_ on
#webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-05-31

Source/WebCore:

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::HTMLMediaElement):
(WebCore::HTMLMediaElement::startProgressEventTimer):
(WebCore::HTMLMediaElement::changeNetworkStateFromLoadingToIdle):
(WebCore::HTMLMediaElement::progressEventTimerFired):
(WebCore::HTMLMediaElement::startPlaybackProgressTimer):

  • platform/graphics/MediaPlayer.cpp:

(WebCore::NullMediaPlayerPrivate::bytesLoaded):
(WebCore::MediaPlayer::bytesLoaded):

  • platform/graphics/MediaPlayer.h:
  • platform/graphics/MediaPlayerPrivate.h:

(MediaPlayerPrivateInterface):

  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:

(WebCore::MediaPlayerPrivateAVFoundation::MediaPlayerPrivateAVFoundation):
(WebCore::MediaPlayerPrivateAVFoundation::bytesLoaded):

  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:

(MediaPlayerPrivateAVFoundation):

  • platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp:

(WebCore::MediaPlayerPrivate::bytesLoaded):

  • platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.h:

(MediaPlayerPrivate):

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::MediaPlayerPrivateGStreamer):
(WebCore::MediaPlayerPrivateGStreamer::bytesLoaded):

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:

(MediaPlayerPrivateGStreamer):

  • platform/graphics/mac/MediaPlayerPrivateQTKit.h:

(MediaPlayerPrivateQTKit):

  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm:

(WebCore::MediaPlayerPrivateQTKit::MediaPlayerPrivateQTKit):
(WebCore::MediaPlayerPrivateQTKit::bytesLoaded):

  • platform/graphics/qt/MediaPlayerPrivateQt.cpp:

(WebCore::MediaPlayerPrivateQt::MediaPlayerPrivateQt):
(WebCore::MediaPlayerPrivateQt::bytesLoaded):

  • platform/graphics/qt/MediaPlayerPrivateQt.h:

(MediaPlayerPrivateQt):

  • platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:

(WebCore::MediaPlayerPrivateQuickTimeVisualContext::MediaPlayerPrivateQuickTimeVisualContext):
(WebCore::MediaPlayerPrivateQuickTimeVisualContext::bytesLoaded):

  • platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.h:

(MediaPlayerPrivateQuickTimeVisualContext):

  • platform/graphics/wince/MediaPlayerPrivateWinCE.h:

(MediaPlayerPrivate):

Source/WebKit/chromium:

  • public/WebMediaPlayer.h:

(WebMediaPlayer):

  • src/WebMediaPlayerClientImpl.cpp:

(WebKit::WebMediaPlayerClientImpl::bytesLoaded):

  • src/WebMediaPlayerClientImpl.h:

(WebMediaPlayerClientImpl):

2:03 PM Changeset in webkit [119145] by aestes@apple.com
  • 12 edits in trunk/Source

Disentangle code that relies on USE(AUTOMATIC_TEXT_REPLACEMENT) from that which merely relies on PLATFORM(MAC)
​https://bugs.webkit.org/show_bug.cgi?id=87933

Reviewed by Dan Bernstein.

Source/WebCore:

  • editing/Editor.cpp:
  • editing/Editor.h:
  • loader/EmptyClients.h:
  • page/ContextMenuController.cpp:

(WebCore::ContextMenuController::contextMenuItemSelected):

  • page/EditorClient.h:

Source/WebKit/mac:

  • WebCoreSupport/WebEditorClient.h:
  • WebCoreSupport/WebEditorClient.mm:

Source/WebKit2:

  • WebProcess/WebCoreSupport/WebEditorClient.h:
  • WebProcess/WebCoreSupport/mac/WebEditorClientMac.mm:
1:58 PM Changeset in webkit [119144] by jberlin@webkit.org
  • 1 edit
    5 adds in trunk/LayoutTests

[Win] fast/events/remove-target* tests fail
​https://bugs.webkit.org/show_bug.cgi?id=88006

Add Windows-specific expected (failing?) results to get the bots greener.

  • platform/win/fast/events/remove-target-in-mouseup-deep-expected.txt: Added.
  • platform/win/fast/events/remove-target-in-mouseup-expected.txt: Added.
  • platform/win/fast/events/remove-target-in-mouseup-insertback-expected.txt: Added.
  • platform/win/fast/events/remove-target-in-mouseup-twice-expected.txt: Added.
  • platform/win/fast/events/remove-target-with-shadow-in-drag-expected.txt: Added.
1:55 PM Writing Layout Tests for DumpRenderTree edited by jchaffraix@webkit.org
Added a section on ref-tests and added more tips on portable text (diff)
1:55 PM Changeset in webkit [119143] by andersca@apple.com
  • 2 edits in trunk/Source/WTF

Disable support for rvalue references until I figure out why this is breaking the Xcode 4.2 build.

  • wtf/Compiler.h:
1:53 PM Changeset in webkit [119142] by rakuco@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Gardening; skip fast/canvas/canvas-imageSmoothingEnabled.

Skip the test just like GTK+, as there seems to be a problem in
the cairo backend that makes the test fail.

  • platform/efl/test_expectations.txt:
1:48 PM Changeset in webkit [119141] by ap@apple.com
  • 9 edits in branches/safari-536-branch/LayoutTests

Update test results for disabling CSS Exclusions.

  • fast/css/getComputedStyle/computed-style-expected.txt:
  • fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/mac/Skipped:
  • platform/mac/fast/js/global-constructors-expected.txt:
  • platform/win/Skipped:
  • platform/win/fast/js/global-constructors-expected.txt:
  • platform/wk2/Skipped:
  • svg/css/getComputedStyle-basic-expected.txt:
1:44 PM Changeset in webkit [119140] by andersca@apple.com
  • 4 edits in trunk/Tools

Build fixes.

Disable the C++11 extensions warning.

  • DumpRenderTree/mac/Configurations/Base.xcconfig:
  • TestWebKitAPI/Configurations/Base.xcconfig:
  • WebKitTestRunner/Configurations/Base.xcconfig:
1:41 PM Changeset in webkit [119139] by danakj@chromium.org
  • 17 edits in trunk/Source

[chromium] Move drawing code for RenderSurfaces into LayerRendererChromium
​https://bugs.webkit.org/show_bug.cgi?id=87877

Reviewed by James Robinson.

Source/WebCore:

We add data to CCRenderSurfaceDrawQuad so that the only use of
CCRenderSurface directly from LayerRendererChromium is to
reserve, release, and use the surface's textures, and to set the
scissor rect. Each of these changes will be done independent
of this change.

Covered by existing tests.

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::applyFilters):
(WebCore):
(WebCore::LayerRendererChromium::drawBackgroundFilters):
(WebCore::LayerRendererChromium::drawRenderSurfaceQuad):
(WebCore::LayerRendererChromium::copyTextureToFramebuffer):

  • platform/graphics/chromium/LayerRendererChromium.h:

(LayerRendererChromium):

  • platform/graphics/chromium/cc/CCLayerImpl.cpp:

(WebCore::CCLayerImpl::contentsTextureId):

  • platform/graphics/chromium/cc/CCLayerImpl.h:

(CCLayerImpl):

  • platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:

(WebCore::calculateDrawTransformsAndVisibilityInternal):

  • platform/graphics/chromium/cc/CCQuadCuller.cpp:
  • platform/graphics/chromium/cc/CCQuadCuller.h:

(CCQuadCuller):

  • platform/graphics/chromium/cc/CCRenderPass.cpp:

(WebCore::CCRenderPass::appendQuadsForRenderSurfaceLayer):

  • platform/graphics/chromium/cc/CCRenderSurface.cpp:

(WebCore):
(WebCore::CCRenderSurface::CCRenderSurface):
(WebCore::CCRenderSurface::prepareContentsTexture):
(WebCore::CCRenderSurface::releaseContentsTexture):
(WebCore::CCRenderSurface::hasValidContentsTexture):
(WebCore::CCRenderSurface::releaseBackgroundTexture):
(WebCore::CCRenderSurface::hasValidBackgroundTexture):
(WebCore::CCRenderSurface::hasMask):
(WebCore::CCRenderSurface::replicaHasMask):
(WebCore::CCRenderSurface::appendQuads):

  • platform/graphics/chromium/cc/CCRenderSurface.h:

(WebCore):
(CCRenderSurface):

  • platform/graphics/chromium/cc/CCRenderSurfaceDrawQuad.cpp:

(WebCore::CCRenderSurfaceDrawQuad::create):
(WebCore::CCRenderSurfaceDrawQuad::CCRenderSurfaceDrawQuad):

  • platform/graphics/chromium/cc/CCRenderSurfaceDrawQuad.h:

(WebKit):
(CCRenderSurfaceDrawQuad):
(WebCore::CCRenderSurfaceDrawQuad::maskTextureId):
(WebCore::CCRenderSurfaceDrawQuad::filters):
(WebCore::CCRenderSurfaceDrawQuad::backgroundFilters):

  • platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:

(WebCore::CCTiledLayerImpl::contentsTextureId):

  • platform/graphics/chromium/cc/CCTiledLayerImpl.h:

(CCTiledLayerImpl):

Source/WebKit/chromium:

  • tests/CCRenderSurfaceTest.cpp:

(WebCore::TEST):

1:28 PM Changeset in webkit [119138] by jberlin@webkit.org
  • 3 edits
    8 adds in trunk/LayoutTests

[Win] 10 fast/text tests failing
​https://bugs.webkit.org/show_bug.cgi?id=87998

Add/update Windows-specific expected (failing?) pixel results in order to get the bots greener.

  • platform/win/fast/text/complex-preferred-logical-widths-expected.png: Added.
  • platform/win/fast/text/complex-synthetic-bold-space-width-expected.png: Added.
  • platform/win/fast/text/international/arabic-justify-expected.png: Added.
  • platform/win/fast/text/international/bidi-mirror-he-ar-expected.png:
  • platform/win/fast/text/international/float-as-only-child-of-isolate-crash-expected.png: Added.
  • platform/win/fast/text/international/text-combine-image-test-expected.png:
  • platform/win/fast/text/international/text-spliced-font-expected.png: Added.
  • platform/win/fast/text/line-initial-and-final-swashes-expected.png: Added.
  • platform/win/fast/text/midword-break-before-surrogate-pair-2-expected.png: Added.
  • platform/win/fast/text/unicode-variation-selector-expected.png: Added.
1:16 PM Changeset in webkit [119137] by zandobersek@gmail.com
  • 4 edits in trunk/LayoutTests

Unreviewed gardening, updating baselines after r119124.

  • dom/xhtml/level3/core/documentnormalizedocument10-expected.txt:
  • dom/xhtml/level3/core/documentsetxmlversion03-expected.txt:
  • fast/workers/storage/test-authorizer-sync-expected.txt:
12:58 PM Changeset in webkit [119136] by beidson@apple.com
  • 3 edits in trunk/Source/WebCore

<rdar://problem/11544454> and ​https://bugs.webkit.org/show_bug.cgi?id=87990
Crashes unregistering DOMWindowProperties while releasing CachedPages

Reviewed by Jessie Berlin.

This patch rewrites DOMWindowProperty to always keep direct track of the DOMWindow
it has registered with and to only ever unregister from that very same DOMWindow.

No new tests. (While the direct cause of the crash is understood, reproducing it is not)

  • page/DOMWindowProperty.cpp:

(WebCore::DOMWindowProperty::DOMWindowProperty):
(WebCore::DOMWindowProperty::~DOMWindowProperty):
(WebCore::DOMWindowProperty::disconnectFrameForPageCache):
(WebCore::DOMWindowProperty::reconnectFrameFromPageCache):
(WebCore::DOMWindowProperty::willDestroyGlobalObjectInCachedFrame):
(WebCore::DOMWindowProperty::willDestroyGlobalObjectInFrame):
(WebCore::DOMWindowProperty::willDetachGlobalObjectFromFrame):

  • page/DOMWindowProperty.h:

(DOMWindowProperty):

12:48 PM Changeset in webkit [119135] by jamesr@google.com
  • 1 edit in branches/chromium/1132/LayoutTests/platform/chromium/test_expectations.txt

Revert bad merge of chromium test_expectations.txt on 1132 branch

BUG=130392

12:30 PM Changeset in webkit [119134] by staikos@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[Blackberry] Initialize the select client and delete the pointer
in the destructor so it doesn't leak. Fixes test crashes.
​https://bugs.webkit.org/show_bug.cgi?id=87992

Reviewed by Rob Buis.

  • WebKitSupport/InputHandler.cpp:

(BlackBerry::WebKit::InputHandler::InputHandler):
(BlackBerry::WebKit::InputHandler::~InputHandler):

12:20 PM Changeset in webkit [119133] by pdr@google.com
  • 2 edits
    2 copies in branches/chromium/1132

Merge 117365 - Crash if SVG gradient stop has display: none set

12:12 PM Changeset in webkit [119132] by andersca@apple.com
  • 3 edits in trunk/Source/WTF

Vector should have a move constructor and move assignment operator
​https://bugs.webkit.org/show_bug.cgi?id=87997

Reviewed by Andreas Kling.

  • wtf/Compiler.h:

Use has_extension so we can use move semantics and other C++11 features even when building as C++98.

  • wtf/Vector.h:

Add a move constructor and a move assignment operator to Vector.

12:08 PM Changeset in webkit [119131] by tony@chromium.org
  • 58 edits in trunk

rename flexbox CSS properties from flex-align and flex-item-align to align-items and align-self
​https://bugs.webkit.org/show_bug.cgi?id=87907

Reviewed by Ojan Vafai.

Source/WebCore:

This was recently changed in the spec:
​http://dev.w3.org/csswg/css3-flexbox/#align-items-property

No new tests, updated the tests to use the new naming.

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

  • css/CSSParser.cpp:

(WebCore::isValidKeywordPropertyAndValue):
(WebCore::isKeywordPropertyID):
(WebCore::CSSParser::parseValue):

  • css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator EAlignItems):

  • css/CSSProperty.cpp:

(WebCore::CSSProperty::isInheritedProperty):

  • css/CSSPropertyNames.in:
  • css/StyleBuilder.cpp:

(WebCore::StyleBuilder::StyleBuilder):

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::collectMatchingRulesForList):

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::sizesToIntrinsicLogicalWidth):

  • rendering/RenderFlexibleBox.cpp:

(WebCore::alignmentForChild):
(WebCore::RenderFlexibleBox::layoutAndPlaceChildren):
(WebCore::RenderFlexibleBox::alignChildren):

  • rendering/style/RenderStyle.h:
  • rendering/style/RenderStyleConstants.h:
  • rendering/style/StyleFlexibleBoxData.cpp:

(WebCore::StyleFlexibleBoxData::StyleFlexibleBoxData):
(WebCore::StyleFlexibleBoxData::operator==):

  • rendering/style/StyleFlexibleBoxData.h:

(StyleFlexibleBoxData): Move member variables to StyleRareNonInheritedData
because these values will eventually apply to more than just flexbox.

  • rendering/style/StyleRareNonInheritedData.cpp:

(WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
(WebCore::StyleRareNonInheritedData::operator==):

  • rendering/style/StyleRareNonInheritedData.h:

(StyleRareNonInheritedData):

LayoutTests:

Updated tests for new CSS property names.

  • css3/flexbox/align-absolute-child.html:
  • css3/flexbox/cross-axis-scrollbar.html:
  • css3/flexbox/css-properties-expected.txt:
  • css3/flexbox/css-properties.html:
  • css3/flexbox/flex-align-baseline.html:
  • css3/flexbox/flex-align-column.html:
  • css3/flexbox/flex-align-end.html:
  • css3/flexbox/flex-align-stretch.html:
  • css3/flexbox/flex-align-vertical-writing-mode.html:
  • css3/flexbox/flex-align.html:
  • css3/flexbox/line-wrapping.html:
  • css3/flexbox/multiline-align.html:
  • css3/flexbox/multiline-reverse-wrap-baseline.html:
  • css3/flexbox/orthogonal-flex-directions.html:
  • css3/flexbox/position-absolute-child.html:
  • css3/flexbox/true-centering.html:
11:52 AM Changeset in webkit [119130] by jberlin@webkit.org
  • 2 edits
    9 adds in trunk/LayoutTests

[Win] 10 fast/text tests failing
​https://bugs.webkit.org/show_bug.cgi?id=87998

Add/update Windows-specific expected (failing?) results in order to get the bots greener.

  • platform/win/fast/text/complex-preferred-logical-widths-expected.txt: Added.
  • platform/win/fast/text/complex-synthetic-bold-space-width-expected.txt: Added.
  • platform/win/fast/text/international/arabic-justify-expected.txt: Added.
  • platform/win/fast/text/international/bidi-mirror-he-ar-expected.txt: Added.
  • platform/win/fast/text/international/float-as-only-child-of-isolate-crash-expected.txt: Added.
  • platform/win/fast/text/international/text-combine-image-test-expected.txt:
  • platform/win/fast/text/international/text-spliced-font-expected.txt: Added.
  • platform/win/fast/text/line-initial-and-final-swashes-expected.txt: Added.
  • platform/win/fast/text/midword-break-before-surrogate-pair-2-expected.txt: Added.
  • platform/win/fast/text/unicode-variation-selector-expected.txt: Added.
11:48 AM Changeset in webkit [119129] by danakj@chromium.org
  • 2 edits in trunk/Source/Platform

[chromium] Add copy constructor to WebFilterOperations
​https://bugs.webkit.org/show_bug.cgi?id=87970

Reviewed by James Robinson.

  • chromium/public/WebFilterOperations.h:

(WebKit::WebFilterOperations::WebFilterOperations):

11:37 AM Changeset in webkit [119128] by rafaelw@chromium.org
  • 2 edits in trunk/LayoutTests

Updating test expectations (svg/as-image/animated-svg-as-image.html)

  • platform/chromium/test_expectations.txt:
11:17 AM Writing testharness Tests edited by jacobg@adobe.com
(diff)
11:17 AM Writing testharness Tests edited by jacobg@adobe.com
(diff)
11:11 AM Changeset in webkit [119127] by ap@apple.com
  • 4 edits in trunk/Tools

[WK2] window.internals settings are not reset between tests
​https://bugs.webkit.org/show_bug.cgi?id=87783

Reviewed by Mihai Parparita.

  • WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: (WTR::InjectedBundle::done): Call resetAfterTest().
  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::InjectedBundlePage::prepare): Renamed from "reset" for clarity. (WTR::InjectedBundlePage::resetAfterTest): Added a function that resets internals. This needs to be done after a tets, because the code assumes that there is an object with this name in global scope.
  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
11:09 AM Changeset in webkit [119126] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Crash when destroying WebOverlay with active WebOverlayOverride
​https://bugs.webkit.org/show_bug.cgi?id=87968

Patch by Arvid Nilsson <​anilsson@rim.com> on 2012-05-31
Reviewed by Rob Buis.

The override object is using a compositing thread WebOverlayPrivate
object with no client because the layer doesn't delegate drawing to the
WebOverlayPrivate, it's only used to modify the override properties on
the underlying compositing thread layer.

Since the m_layerCompositingThreadClient is optional, we have to add
null checks.

  • Api/WebOverlay.cpp:

(BlackBerry::WebKit::WebOverlayPrivateCompositingThread::~WebOverlayPrivateCompositingThread):
(BlackBerry::WebKit::WebOverlayPrivateCompositingThread::setClient):
(BlackBerry::WebKit::WebOverlayPrivateCompositingThread::setContentsToImage):
(BlackBerry::WebKit::WebOverlayPrivateCompositingThread::setContentsToColor):
(BlackBerry::WebKit::WebOverlayPrivateCompositingThread::setDrawsContent):
(BlackBerry::WebKit::WebOverlayPrivateCompositingThread::invalidate):

11:03 AM Changeset in webkit [119125] by fischman@chromium.org
  • 22 edits in trunk/Source

Replace WebMediaPlayer::bytesLoaded() with an explicit didLoadingProgress()
​https://bugs.webkit.org/show_bug.cgi?id=86113

Reviewed by Eric Carlson.

Source/WebCore:

No new functionality, so no new tests. Loading progress is already tested by existing layouttests.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::HTMLMediaElement):
(WebCore::HTMLMediaElement::startProgressEventTimer):
(WebCore::HTMLMediaElement::changeNetworkStateFromLoadingToIdle):
(WebCore::HTMLMediaElement::progressEventTimerFired):
(WebCore::HTMLMediaElement::startPlaybackProgressTimer):

  • platform/graphics/MediaPlayer.cpp:

(WebCore::NullMediaPlayerPrivate::didLoadingProgress):
(WebCore::MediaPlayer::didLoadingProgress):

  • platform/graphics/MediaPlayer.h:
  • platform/graphics/MediaPlayerPrivate.h:

(MediaPlayerPrivateInterface):

  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:

(WebCore::MediaPlayerPrivateAVFoundation::MediaPlayerPrivateAVFoundation):

  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:

(MediaPlayerPrivateAVFoundation):

  • platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp:

(WebCore::MediaPlayerPrivate::didLoadingProgress):

  • platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.h:

(MediaPlayerPrivate):

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::MediaPlayerPrivateGStreamer):
(WebCore::MediaPlayerPrivateGStreamer::didLoadingProgress):

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:

(MediaPlayerPrivateGStreamer):

  • platform/graphics/mac/MediaPlayerPrivateQTKit.h:

(MediaPlayerPrivateQTKit):

  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm:

(WebCore::MediaPlayerPrivateQTKit::MediaPlayerPrivateQTKit):
(WebCore::MediaPlayerPrivateQTKit::didLoadingProgress):

  • platform/graphics/qt/MediaPlayerPrivateQt.cpp:

(WebCore::MediaPlayerPrivateQt::MediaPlayerPrivateQt):
(WebCore::MediaPlayerPrivateQt::didLoadingProgress):

  • platform/graphics/qt/MediaPlayerPrivateQt.h:

(MediaPlayerPrivateQt):

  • platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:

(WebCore::MediaPlayerPrivateQuickTimeVisualContext::MediaPlayerPrivateQuickTimeVisualContext):
(WebCore::MediaPlayerPrivateQuickTimeVisualContext::didLoadingProgress):

  • platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.h:

(MediaPlayerPrivateQuickTimeVisualContext):

  • platform/graphics/wince/MediaPlayerPrivateWinCE.h:

(MediaPlayerPrivate):

Source/WebKit/chromium:

  • public/WebMediaPlayer.h:

(WebMediaPlayer):

  • src/WebMediaPlayerClientImpl.cpp:

(WebKit::WebMediaPlayerClientImpl::didLoadingProgress):

  • src/WebMediaPlayerClientImpl.h:

(WebMediaPlayerClientImpl):

11:00 AM Changeset in webkit [119124] by arv@chromium.org
  • 31 edits
    3 moves
    8 adds
    4 deletes in trunk

Make DOM Exceptions Errors
​https://bugs.webkit.org/show_bug.cgi?id=85078

Reviewed by Oliver Hunt.

WebIDL mandates that exceptions should have Error.prototype on its prototype chain.

For JSC we have access to the Error.prototype from the binding code.

For V8 we set a field in the WrapperTypeInfo and when the constructor function is created we
set the prototype as needed.

Updated test: fast/dom/DOMException/prototype-object.html

Source/JavaScriptCore:

  • JavaScriptCore.xcodeproj/project.pbxproj:
  • runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::reset):

  • runtime/JSGlobalObject.h:

(JSC):
(JSGlobalObject):
(JSC::JSGlobalObject::errorPrototype):

Source/WebCore:

  • ForwardingHeaders/runtime/ErrorPrototype.h: Added.
  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader):
(GenerateImplementation):

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateNamedConstructorCallback):
(GenerateImplementation):

  • bindings/scripts/test/JS/JSTestException.cpp:

(WebCore::JSTestException::createPrototype):

  • bindings/scripts/test/JS/JSTestException.h:
  • bindings/scripts/test/V8/V8Float64Array.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8TestEventConstructor.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8TestEventTarget.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8TestException.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8TestInterface.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8TestNamedConstructor.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8TestNode.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore):
(WebCore::V8TestObj::installPerContextProperties):

  • bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:

(WebCore):

  • bindings/v8/NPV8Object.cpp:

(WebCore::npObjectTypeInfo):

  • bindings/v8/V8BindingPerContextData.cpp:

(WebCore):
(WebCore::V8BindingPerContextData::init):
(WebCore::V8BindingPerContextData::createWrapperFromCacheSlowCase):
(WebCore::V8BindingPerContextData::constructorForTypeSlowCase):

  • bindings/v8/V8BindingPerContextData.h:

(V8BindingPerContextData):

  • bindings/v8/V8HiddenPropertyName.h:

(WebCore):

  • bindings/v8/WrapperTypeInfo.h:

(WebCore):
(WrapperTypeInfo):

  • bindings/v8/custom/V8HTMLImageElementConstructor.cpp:

(WebCore):

LayoutTests:

  • fast/dom/DOMException/prototype-object-expected.txt:
  • fast/dom/DOMException/prototype-object.html:
  • fast/dom/DOMException/resources/prototype-object.js: Removed.
  • platform/chromium-win/fast/dom/NamedNodeMap-setNamedItem-crash-expected.txt: Removed.
  • platform/chromium-win/fast/dom/timer-clear-interval-in-handler-and-generate-error-expected.txt: Removed.
  • platform/chromium-win/svg/filters/feBlend-invalid-mode-expected.txt: Removed.
  • platform/chromium/dom/xhtml/level3/core/documentnormalizedocument10-expected.txt: Added.
  • platform/chromium/dom/xhtml/level3/core/documentsetxmlversion03-expected.txt: Added.
  • platform/chromium/fast/dom/DOMException/prototype-object-expected.txt:
  • platform/chromium/fast/dom/NamedNodeMap-setNamedItem-crash-expected.txt: Renamed from LayoutTests/platform/chromium-mac/fast/dom/NamedNodeMap-setNamedItem-crash-expected.txt.
  • platform/chromium/fast/dom/timer-clear-interval-in-handler-and-generate-error-expected.txt: Renamed from LayoutTests/platform/chromium-mac/fast/dom/timer-clear-interval-in-handler-and-generate-error-expected.txt.
  • platform/chromium/svg/filters/feBlend-invalid-mode-expected.txt: Renamed from LayoutTests/platform/chromium-mac/svg/filters/feBlend-invalid-mode-expected.txt.
10:56 AM Changeset in webkit [119123] by jberlin@webkit.org
  • 2 edits in trunk/LayoutTests

[Win] ASSERT(oldLayoutDelta == view()->layoutDelta()) failed in RenderBlock::layoutBlockChild
when running media/media-volume-slider-rendered-below.html
​https://bugs.webkit.org/show_bug.cgi?id=87450

Add the test to the Windows Skipped list to get the bots greener.

  • platform/win/Skipped:
10:55 AM Writing Layout Tests for DumpRenderTree edited by jacobg@adobe.com
(diff)
10:51 AM Writing testharness Tests created by jacobg@adobe.com
10:42 AM WikiStart edited by jacobg@adobe.com
(diff)
10:41 AM Changeset in webkit [119122] by Lucas Forschler
  • 40 edits in branches/safari-536-branch

Merge <rdar://problem/10887709>

10:38 AM Changeset in webkit [119121] by commit-queue@webkit.org
  • 6 edits
    3 adds in trunk/Source

[chromium] create WebTransformOperation interface for chromium platform
​https://bugs.webkit.org/show_bug.cgi?id=87510

Patch by Ian Vollick <​vollick@chromium.org> on 2012-05-31
Reviewed by James Robinson.

Source/Platform:

  • Platform.gypi:
  • chromium/public/WebTransformOperations.h: Added.

(WebKit):
(WebTransformOperations):
(WebKit::WebTransformOperations::~WebTransformOperations):
(WebKit::WebTransformOperations::WebTransformOperations):
(WebKit::WebTransformOperations::operator=):

Source/WebCore:

Unit tests:

WebTransformOperationsTest.transformTypesAreUnique
WebTransformOperationsTest.matchesTypesSameLength
WebTransformOperationsTest.matchesTypesDifferentLength
WebTransformOperationsTest.applyTranslate
WebTransformOperationsTest.applyRotate
WebTransformOperationsTest.applyScale
WebTransformOperationsTest.applySkew
WebTransformOperationsTest.applyPerspective
WebTransformOperationsTest.applyMatrix
WebTransformOperationsTest.applyOrder
WebTransformOperationsTest.blendOrder
WebTransformOperationsTest.blendProgress
WebTransformOperationsTest.blendWhenTypesDoNotMatch

  • WebCore.gypi:
  • platform/chromium/support/WebTransformOperations.cpp: Added.

(WebKit):
(WebTransformOperationsPrivate):
(WebKit::WebTransformOperations::apply):
(WebKit::WebTransformOperations::blend):
(WebKit::WebTransformOperations::matchesTypes):
(WebKit::WebTransformOperations::appendTranslate):
(WebKit::WebTransformOperations::appendRotate):
(WebKit::WebTransformOperations::appendScale):
(WebKit::WebTransformOperations::appendSkew):
(WebKit::WebTransformOperations::appendPerspective):
(WebKit::WebTransformOperations::appendMatrix):
(WebKit::WebTransformOperations::reset):
(WebKit::WebTransformOperations::initialize):

Source/WebKit/chromium:

  • WebKit.gypi:
  • tests/WebTransformOperationsTest.cpp: Added.

(TEST):
(checkProgress):

10:36 AM WikiStart edited by jacobg@adobe.com
(diff)
10:35 AM Changeset in webkit [119120] by jberlin@webkit.org
  • 1 edit
    15 adds in trunk/LayoutTests

10 W3C video and audio canPlayType tests are failing on Mac and Win
​https://bugs.webkit.org/show_bug.cgi?id=75184

Add Windows-specific expected (failing?) results to get the bots greener.

  • platform/win/media/W3C: Added.
  • platform/win/media/W3C/audio: Added.
  • platform/win/media/W3C/audio/canPlayType: Added.
  • platform/win/media/W3C/audio/canPlayType/canPlayType_supported_but_no_codecs_parameter_1-expected.txt: Added.
  • platform/win/media/W3C/audio/canPlayType/canPlayType_supported_but_no_codecs_parameter_2-expected.txt: Added.
  • platform/win/media/W3C/video: Added.
  • platform/win/media/W3C/video/canPlayType: Added.
  • platform/win/media/W3C/video/canPlayType/canPlayType_codecs_order_2-expected.txt: Added.
  • platform/win/media/W3C/video/canPlayType/canPlayType_codecs_order_3-expected.txt: Added.
  • platform/win/media/W3C/video/canPlayType/canPlayType_supported_but_no_codecs_parameter_2-expected.txt: Added.
  • platform/win/media/W3C/video/canPlayType/canPlayType_supported_but_no_codecs_parameter_3-expected.txt: Added.
  • platform/win/media/W3C/video/canPlayType/canPlayType_two_implies_one_3-expected.txt: Added.
  • platform/win/media/W3C/video/canPlayType/canPlayType_two_implies_one_4-expected.txt: Added.
  • platform/win/media/W3C/video/canPlayType/canPlayType_two_implies_one_5-expected.txt: Added.
  • platform/win/media/W3C/video/canPlayType/canPlayType_two_implies_one_6-expected.txt: Added.
10:33 AM Changeset in webkit [119119] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebKit/blackberry

[Blackberry] WebKit's fullscreen mode needs to notify page client.
​https://bugs.webkit.org/show_bug.cgi?id=87337

Patch by Chris Guan <​chris.guan@torchmobile.com.cn> on 2012-05-31
Reviewed by Antonio Gomes.

Move "fullScreenVideoCapable" into webpagePrivate to make code
clean for "fullScreenForElement/Node" of cromeClientBlackberry,
All Video checks and code path selections are in webpagePrivate now.
For some UX and secure reasons, we could not apply fullscreen capacity
for all elements, So we use client's fullscreenStart/Stop only for
those video elements and those elements containing video tags.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::webContext):
(BlackBerry::WebKit::WebPage::notifyFullScreenVideoExited):
(WebKit):
(BlackBerry::WebKit::containsVideoTags):
(BlackBerry::WebKit::WebPagePrivate::enterFullScreenForElement):
(BlackBerry::WebKit::WebPagePrivate::exitFullScreenForElement):

  • Api/WebPageClient.h:
  • Api/WebPage_p.h:

(WebCore):
(WebPagePrivate):

  • WebCoreSupport/ChromeClientBlackBerry.cpp:

(WebCore::ChromeClientBlackBerry::enterFullScreenForElement):
(WebCore::ChromeClientBlackBerry::exitFullScreenForElement):

10:29 AM Changeset in webkit [119118] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/gtk

[GTK] Memory leak in webkit_web_view_init
​https://bugs.webkit.org/show_bug.cgi?id=87943

Patch by Sudarsana Nagineni <​sudarsana.nagineni@linux.intel.com> on 2012-05-31
Reviewed by Martin Robinson.

Fixed a memory leak in webkit_web_view_init by making the
UserMediaClientGtk to be owned by the WebView.

  • webkit/webkitwebview.cpp:

(webkit_web_view_init):

  • webkit/webkitwebviewprivate.h:
10:28 AM Changeset in webkit [119117] by wingo@igalia.com
  • 2 edits in trunk/Source/JavaScriptCore

Fix reference to unset variable in debug mode
​https://bugs.webkit.org/show_bug.cgi?id=87981

Reviewed by Geoffrey Garen.

  • runtime/JSONObject.cpp (Stringifier::Holder::Holder):

Initialize m_size in debug mode, as we check it later in an assert.

10:15 AM Changeset in webkit [119116] by commit-queue@webkit.org
  • 9 edits in trunk

[EFL][DRT] EFL's DRT navigation_policy_decision implementation
​https://bugs.webkit.org/show_bug.cgi?id=85006

Patch by Mikhail Pozdnyakov <​mikhail.pozdnyakov@intel.com> on 2012-05-31
Reviewed by Tor Arne Vestbø.

Tools:

Added navigation_policy_decision implementation for DumpRenderTreeView.
Added LayoutTestController::setCustomPolicyDelegate implementation.
Modified LayoutTestController::waitForPolicyDelegate.

  • DumpRenderTree/efl/DumpRenderTree.cpp:
  • DumpRenderTree/efl/DumpRenderTreeChrome.cpp:

(DumpRenderTreeChrome::resetDefaultsToConsistentValues):

  • DumpRenderTree/efl/DumpRenderTreeEfl.h:
  • DumpRenderTree/efl/DumpRenderTreeView.cpp:

(navigationTypeToString): aux function
(onNavigationPolicyDecision): navigation_policy_decision implementation
(drtViewAdd):

  • DumpRenderTree/efl/LayoutTestControllerEfl.cpp:

(LayoutTestController::setCustomPolicyDelegate):
(LayoutTestController::waitForPolicyDelegate):

LayoutTests:

Unskipped corresponding tests. Those still not passing are put into
test_expectations.txt.

  • platform/efl/Skipped:
  • platform/efl/test_expectations.txt:
10:00 AM Changeset in webkit [119115] by commit-queue@webkit.org
  • 7 edits in trunk

[EFL][DRT] LayoutTestController does not implement clearApplicationCacheForOrigin
​https://bugs.webkit.org/show_bug.cgi?id=86195

Patch by Jussi Kukkonen <​jussi.kukkonen@intel.com> on 2012-05-31
Reviewed by Gustavo Noronha Silva.

Source/WebKit/efl:

add new function to clear security origin application cache,
and a function to create a security origin from url string.
Reindent the header to match new longer return signature.

  • ewk/ewk_security_origin.cpp:

(ewk_security_origin_application_cache_clear):
(ewk_security_origin_new_from_string):

  • ewk/ewk_security_origin.h:

Tools:

Implement clearApplicationCacheForOrigin in EFL
LayoutTestController.

  • DumpRenderTree/efl/LayoutTestControllerEfl.cpp:

(LayoutTestController::clearApplicationCacheForOrigin):

LayoutTests:

Unskip http/tests/appcache/origin-delete.html now that
EFL TestLayoutController has required functionality.

  • platform/efl/Skipped:
9:53 AM Changeset in webkit [119114] by yurys@chromium.org
  • 2 edits in trunk/Source/WebCore

m_totalAllocated should be intialized in RenderArena constructor
​https://bugs.webkit.org/show_bug.cgi?id=87967

Reviewed by Ojan Vafai.

  • rendering/RenderArena.cpp:

(WebCore::RenderArena::RenderArena): added missing initializer.

9:36 AM Changeset in webkit [119113] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/gtk

Spell checker doesn't recognize contractions (apostrophes)
​https://bugs.webkit.org/show_bug.cgi?id=86118

Patch by ​commit-queue@webkit.org <​commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc> on 2012-05-31
Reviewed by Gustavo Noronha Silva.

The Enchant spell checker was breaking words on apostrophes, because
apparently they were always being detected as Pango word-end
characters. To know whether or not the apostrophe is a
word end character requires looking at a string with a larger
granularity than one character.

Simplify the way the we break strings, by search for non-graphable
character manually to find word starts and ends. This has the side
effect of removing the dependency on Pango and eliminating one copy.

This change also cleans up some misbehavior on the part of the
WebCoreSupport layer which was not converting from Unicode character
offsets to UTF-16. These offsets can be different if any of the
characters in the UTF-16 string are surrogate pairs (non BMP
characters).

  • WebCoreSupport/TextCheckerClientGtk.cpp:

(WebKit::TextCheckerClientGtk::checkSpellingOfString): Properly
convert from Unicode offsets to UTF-16 offsets.

  • webkit/webkitspellcheckerenchant.cpp:

(findByteOffsetToFirstNonGraphableCharacter): Added this helper.
(getExtentsOfNextWord): Ditto.
(wordIsSpelledCorrectlyInAtLeastOneDictionary): Ditto.
(checkSpellingOfString): Don't split words on apostrophes.

9:32 AM Changeset in webkit [119112] by mario@webkit.org
  • 2 edits in trunk/LayoutTests

[GTK] Unreviewed. Added FAIL expectation due to failure after r119100.

  • platform/gtk/test_expectations.txt:
9:08 AM Changeset in webkit [119111] by jberlin@webkit.org
  • 1 edit
    6 adds in trunk/LayoutTests

[Win] 6 canvas tests failing
​https://bugs.webkit.org/show_bug.cgi?id=87983

Add Windows-specific expected (failing?) results to get the bots greener.

  • platform/win/fast/canvas/canvas-draw-canvas-on-canvas-shadow-expected.txt: Added.
  • platform/win/fast/canvas/canvas-fillRect-gradient-shadow-expected.txt: Added.
  • platform/win/fast/canvas/canvas-scale-drawImage-shadow-expected.txt: Added.
  • platform/win/fast/canvas/canvas-scale-fillPath-shadow-expected.txt: Added.
  • platform/win/fast/canvas/canvas-scale-fillRect-shadow-expected.txt: Added.
  • platform/win/fast/canvas/canvas-transforms-fillRect-shadow-expected.txt: Added.
9:00 AM Changeset in webkit [119110] by jchaffraix@webkit.org
  • 13 edits in trunk/Source/WebCore

The difference between a column and a column group renderer is badly drawn
​https://bugs.webkit.org/show_bug.cgi?id=87556

Reviewed by Abhishek Arya.

No expected change in behavior.

This patch tries to draw a better line between those 3 concepts:

  • renderer is a RenderTableCol (RenderObject::isRenderTableCol).
  • renderer is a column (RenderTableCol::isTableColumn()).
  • renderer is a column group (RenderTableCol::isTableColumnGroup()).

(most of the code that needs to know the difference manipulate a RenderTableCol
so there was no need to move the 2 last helpers into RenderObject)

  • rendering/AutoTableLayout.cpp:

(WebCore::AutoTableLayout::recalcColumn):
Factored the code to use the column / column group iteration we
set up in the rest of the code. Made the code more self-describing
by using more RenderTableCol functions.

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::addChild):
Factored the code to use the isTableColumn() and isTableColumnGroup() to
better underline what we check.

  • rendering/RenderObject.h:

(WebCore::RenderObject::isRenderTableCol):
(WebCore::RenderObject::isTablePart):
Renamed isTableCol to isRenderTableCol to match the class as this doesn't
imply that the renderer is actually a column.

  • html/HTMLTableColElement.cpp:

(WebCore::HTMLTableColElement::parseAttribute):

  • rendering/AutoTableLayout.cpp:

(WebCore::AutoTableLayout::fullRecalc):

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::addChild):
(WebCore::RenderTable::layout):
(WebCore::RenderTable::firstColumn):
Updated after the isRenderTableCol rename.

  • dom/Text.cpp:

(WebCore::Text::rendererIsNeeded):

  • editing/htmlediting.cpp:

(WebCore::isTableStructureNode):
Ditto and renamed some variables.

  • html/HTMLFormElement.cpp:

(WebCore::HTMLFormElement::rendererIsNeeded):
Ditto and added a FIXME as the logic doesn't seem very bullet proof.

  • rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::computeCollapsedStartBorder):
(WebCore::RenderTableCell::computeCollapsedEndBorder):
(WebCore::RenderTableCell::computeCollapsedBeforeBorder):
(WebCore::RenderTableCell::computeCollapsedAfterBorder):
Changed to use the enclosingColumnGroup* helpers.

  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::paintCell):

  • rendering/RenderTableCol.cpp:

(WebCore::RenderTableCol::isChildAllowed):
(WebCore::RenderTableCol::canHaveChildren):
(WebCore::RenderTableCol::enclosingColumnGroup):
(WebCore::RenderTableCol::nextColumn):
Updated to use the new functions.

  • rendering/RenderTableCol.h:

(WebCore::RenderTableCol::isTableColumn):
(WebCore::RenderTableCol::isTableColumnGroup):
(WebCore::RenderTableCol::enclosingColumnGroupIfAdjacentBefore):
(WebCore::RenderTableCol::enclosingColumnGroupIfAdjacentAfter):
Added the following new helpers.

8:41 AM Changeset in webkit [119109] by jberlin@webkit.org
  • 2 edits in trunk/Source/WebCore

Fix Lion build after r119073.

  • platform/Decimal.cpp:

(WebCore::Decimal::toString):
Do not attempt to assign a unsigned long long to an int.

8:31 AM Changeset in webkit [119108] by Carlos Garcia Campos
  • 5 edits in trunk/Source/WebKit2

[GTK] Add webkit_download_get_request to WebKit2 GTK+ API
​https://bugs.webkit.org/show_bug.cgi?id=87957

Reviewed by Martin Robinson.

  • UIProcess/API/gtk/WebKitDownload.cpp:

(webkit_download_get_request): Return the WebKitURIRequest
representing the request that originated the download.

  • UIProcess/API/gtk/WebKitDownload.h:
  • UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Add new symbol.
  • UIProcess/API/gtk/tests/TestDownloads.cpp:

(testDownloadLocalFile):
(testDownloadRemoteFile):

8:29 AM Changeset in webkit [119107] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebKit2

[SOUP] WebProcess crashes when a download is started from an existing ResourceHandle
​https://bugs.webkit.org/show_bug.cgi?id=87953

Reviewed by Martin Robinson.

The output stream to write the downloaded data is created in the
didReceiveResponse callback of the download client. When a
download is created for an existing ResourceHandle (this happens
for example when policy decision is download), the response has
already been received. In this case we should make sure that the
download client is notified about the response, so that when data
actually arrives the output stream has already been created.

  • WebProcess/Downloads/soup/DownloadSoup.cpp:

(WebKit::Download::startWithHandle):

8:27 AM Changeset in webkit [119106] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebKit2

[GTK] Fix webkit_web_view_can_execute_editing_command() API doc
​https://bugs.webkit.org/show_bug.cgi?id=87930

Reviewed by Martin Robinson.

  • UIProcess/API/gtk/WebKitWebView.cpp:
8:27 AM Changeset in webkit [119105] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Crash when closing web page if selection is active
​https://bugs.webkit.org/show_bug.cgi?id=87962

Patch by Arvid Nilsson <​anilsson@rim.com> on 2012-05-31
Reviewed by Antonio Gomes.

The embedder may try to remove a layer from the compositor at a stage
where the compositor has been set to 0.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPage::addCompositingThreadOverlay):
(BlackBerry::WebKit::WebPage::removeCompositingThreadOverlay):

8:15 AM Changeset in webkit [119104] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

[v8] Fix bug reference in array-override-set.html test
​https://bugs.webkit.org/show_bug.cgi?id=87952

Patch by Ulan Degenbaev <​ulan@chromium.org> on 2012-05-31
Reviewed by Abhishek Arya.

  • fast/canvas/webgl/array-override-set-expected.txt:
  • fast/canvas/webgl/array-override-set.html:
8:12 AM Changeset in webkit [119103] by mario@webkit.org
  • 2 edits in trunk/LayoutTests

[GTK] Unreviewed. Added FAIL expectation due to test consistently failing.

  • platform/gtk/test_expectations.txt:
7:47 AM Changeset in webkit [119102] by commit-queue@webkit.org
  • 8 edits in trunk

[EFL] Enable CSS_IMAGE_SET flag
​https://bugs.webkit.org/show_bug.cgi?id=87727

Patch by Christophe Dumez <Christophe Dumez> on 2012-05-31
Reviewed by Adam Roben.

.:

Add CSS_IMAGE_SET flag to CMake and enable it by default on EFL port.

  • Source/cmake/OptionsEfl.cmake:
  • Source/cmake/WebKitFeatures.cmake:
  • Source/cmakeconfig.h.cmake:

Source/WebCore:

Fix CMakeLists.txt so that CSSImageSetValue.cpp gets compiled if
CSS_IMAGE_SET flag is enabled.

  • CMakeLists.txt:

LayoutTests:

Unskip test case associated to CSS image-set functionality now that it
is enabled by default on EFL port.

  • platform/efl/test_expectations.txt:
7:44 AM Changeset in webkit [119101] by mario@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed. Added FAIL expectation for GTK due to missing feature in DRT.

  • platform/gtk/test_expectations.txt:
7:32 AM Changeset in webkit [119100] by commit-queue@webkit.org
  • 6 edits in trunk

the imageSmoothingEnabled flag needs to be in the state object
​https://bugs.webkit.org/show_bug.cgi?id=87853

Patch by Keyar Hood <​keyar@chromium.org> on 2012-05-31
Reviewed by Darin Adler.

Source/WebCore:

Updated fast/canvas/canvas-imageSmoothingEnabled.html instead of
adding a new test.

The imageSmoothingEnabled flag is saved in the draw state now.

  • html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::CanvasRenderingContext2D):
(WebCore::CanvasRenderingContext2D::State::State):
(WebCore::CanvasRenderingContext2D::State::operator=):
(WebCore::CanvasRenderingContext2D::webkitImageSmoothingEnabled):
(WebCore::CanvasRenderingContext2D::setWebkitImageSmoothingEnabled):

  • html/canvas/CanvasRenderingContext2D.h:

(State):

LayoutTests:

Updated the test for imageSmoothingEnabled to test that it is saved in
the draw state.

  • fast/canvas/canvas-imageSmoothingEnabled-expected.txt:
  • fast/canvas/script-tests/canvas-imageSmoothingEnabled.js:
7:08 AM Changeset in webkit [119099] by caseq@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: Fix checkbox position on Settings screen.
​https://bugs.webkit.org/show_bug.cgi?id=87007

Patch by Eugene Klyuchnikov <​eustas.bug@gmail.com> on 2012-05-31
Reviewed by Yury Semikhatsky.

Checkbox seems to be improperly aligned.
It is "shifted" up on 1px on Mac and 2px on Linux.
Also, keyboard-shortcuts screen has "wrapped" key descriptions on Mac.

UI changes, no new tests.

  • inspector/front-end/helpScreen.css:

(.help-container): Fixed column width.
(.help-block): Ditto.
(.help-key-cell): Ditto.
(body.platform-mac .help-container): Ditto.
(body.platform-mac .help-block): Ditto.
(body.platform-mac .help-key-cell): Ditto.
(.help-content p): Ajdusted spacing between lines
(.help-content input[type=checkbox]): Fixed alignment.
(body.platform-mac .help-content input[type=checkbox]): Ditto.
(.help-content input[type=radio]): Fixed alignment.
(body.platform-mac .help-content input[type=radio]): Ditto.

7:00 AM Changeset in webkit [119098] by vestbo@webkit.org
  • 53 edits in trunk

[Qt] Simplify QT_VERSION_CHECKS for Qt5 by introducing HAVE(QT5)
​https://bugs.webkit.org/show_bug.cgi?id=87955

Reviewed by Simon Hausmann.

Source/WebCore:

  • bridge/qt/qt_class.cpp:
  • bridge/qt/qt_instance.cpp:
  • bridge/qt/qt_runtime.h:
  • page/qt/EventHandlerQt.cpp:
  • platform/graphics/GraphicsContext3D.h:
  • platform/graphics/OpenGLShims.cpp:
  • platform/graphics/OpenGLShims.h:
  • platform/graphics/gstreamer/PlatformVideoWindowPrivate.h:
  • platform/graphics/gstreamer/PlatformVideoWindowQt.cpp:
  • platform/graphics/qt/GraphicsContext3DQt.cpp:
  • platform/graphics/qt/SimpleFontDataQt.cpp:
  • platform/graphics/texmap/TextureMapper.h:
  • platform/graphics/texmap/TextureMapperGL.cpp:
  • platform/qt/DeviceMotionProviderQt.h:
  • platform/qt/DeviceOrientationProviderQt.h:
  • platform/qt/KURLQt.cpp:
  • platform/qt/PlatformScreenQt.cpp:
  • platform/qt/QWebPageClient.h:
  • plugins/qt/PluginPackageQt.cpp:
  • plugins/qt/PluginViewQt.cpp:

Source/WebKit/qt:

  • Api/qgraphicswebview.cpp:
  • Api/qgraphicswebview.h:
  • Api/qwebframe.cpp:
  • Api/qwebframe_p.h:
  • Api/qwebpage.cpp:
  • Api/qwebpage.h:
  • Api/qwebsettings.cpp:
  • Api/qwebview.cpp:
  • Api/qwebview.h:
  • WebCoreSupport/FrameLoaderClientQt.cpp:
  • WebCoreSupport/GeolocationClientQt.cpp:
  • WebCoreSupport/GeolocationClientQt.h:
  • WebCoreSupport/PageClientQt.cpp:
  • WebCoreSupport/WebEventConversion.cpp:
  • declarative/plugin.cpp:
  • tests/qwebframe/tst_qwebframe.cpp:
  • tests/util.h:

Source/WebKit2:

  • UIProcess/API/qt/tests/publicapi/tst_publicapi.cpp:

Source/WTF:

  • wtf/qt/UtilsQt.h:

Tools:

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp:
  • DumpRenderTree/qt/EventSenderQt.cpp:
  • DumpRenderTree/qt/QtInitializeTestFonts.cpp:
  • DumpRenderTree/qt/main.cpp:
  • QtTestBrowser/cookiejar.cpp:
  • QtTestBrowser/launcherwindow.cpp:
  • WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp:
  • qmake/mkspecs/features/default_post.prf:
6:38 AM Changeset in webkit [119097] by kling@webkit.org
  • 5 edits in trunk/Source/WebCore

Have StylePropertySet constructor take array/length instead of vector.
<​http://webkit.org/b/87876>

Reviewed by Antti Koivisto.

Remove the StylePropertyVector typedef and have StylePropertySet constructors
take CSSProperty*/length since we are copying the data into a tightly packed
array anyway. This frees up the call sites to use whatever storage they please
rather than being restricted to a vector with inlineCapacity=4.

Change said call sites to use an arbitrary high inline capacity (256) for their
stack-allocated temporary vectors.

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::copyPropertiesInSet):

  • css/CSSParser.cpp:

(WebCore::filterProperties):
(WebCore::CSSParser::createStylePropertySet):

  • css/StylePropertySet.cpp:

(WebCore::StylePropertySet::createImmutable):
(WebCore::StylePropertySet::StylePropertySet):
(WebCore::StylePropertySet::removePropertiesInSet):
(WebCore::StylePropertySet::copyPropertiesInSet):

  • css/StylePropertySet.h:

(WebCore::StylePropertySet::create):
(StylePropertySet):

6:24 AM Changeset in webkit [119096] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Gardening after r118989
​https://bugs.webkit.org/show_bug.cgi?id=87958

Unreviewed gardening.

fast/css/font-face-download-error.html is skipped as bug85977 is not fixed yet.

Patch by Mikhail Pozdnyakov <​mikhail.pozdnyakov@intel.com> on 2012-05-31

  • platform/efl/test_expectations.txt:
6:07 AM Changeset in webkit [119095] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[Qt][WK2] Add missing ViewportUpdateDeferrer guarding to setPageItemRectVisible() calls.
​https://bugs.webkit.org/show_bug.cgi?id=87936

Patch by Zalan Bujtas <​zbujtas@gmail.com> on 2012-05-31
Reviewed by Kenneth Rohde Christiansen.

  • UIProcess/qt/QtViewportInteractionEngine.cpp:

(WebKit::QtViewportInteractionEngine::viewportAttributesChanged):
(WebKit::QtViewportInteractionEngine::pageContentsSizeChanged):

5:41 AM Changeset in webkit [119094] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Fixing compilation with SVG disabled.
​https://bugs.webkit.org/show_bug.cgi?id=87944

This patch adds the missing enumeration value
'CSSPropertyWebkitBoxDecorationBreak' into switch statements to make
clang happy.

Patch by Mike West <​mkwst@chromium.org> on 2012-05-31
Reviewed by Alexis Menard.

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::collectMatchingRulesForList):

5:33 AM Changeset in webkit [119093] by apavlov@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed, update Mac Leopard baselines for fast/muticol/span/span-as-immediate-columns-child.html.

  • platform/chromium-mac-leopard/fast/multicol/span/span-as-immediate-columns-child-expected.png:
5:30 AM Changeset in webkit [119092] by commit-queue@webkit.org
  • 1 edit
    10 adds in trunk/Source/WebKit2

[EFL][WK2] Add WKURLRequestEfl and WKURLResponseEfl
​https://bugs.webkit.org/show_bug.cgi?id=70231

Patch by Keunsoon Lee <​keunsoon.lee@samsung.com> on 2012-05-31
Reviewed by Chang Shu.

These codes can be used for WKPageDecidePolicyForResponseCallback on page policy callbacks.
The callback conveys WKURLResponseRef and WKURLRequestRef as parameter.

By the way, EFL browser needs content type from response to decide correct policy.
Another information, cookie, is necessary with similar reason.
But, there is no way to obtain such information on WebKit2 main stream, except for WKURLRequestCopyURL().

So, EFL port created those files to extract necessary information from WKURLResponseRef and WKURLRequestRef,
and not to desturb WebKit2 main stream.

  • Shared/API/c/efl/WKURLRequestEfl.cpp: Added.

(WKURLRequestEflCopyCookies): extracting cookie information from WKURLRequestRef.

  • Shared/API/c/efl/WKURLRequestEfl.h: Added.
  • Shared/API/c/efl/WKURLResponseEfl.cpp: Added.

(WKURLResponseEflCopyContentType): extracting content type (i.e. MIME type) from WKURLResponseRef.

  • Shared/API/c/efl/WKURLResponseEfl.h: Added.
  • Shared/efl/WebCoreArgumentCodersEfl.cpp: Added.

(CoreIPC):
(CoreIPC::::encode):
(CoreIPC::::decode):

  • Shared/efl/WebURLRequestEfl.cpp: Added.

(WebKit):
(WebKit::WebURLRequestEfl::WebURLRequestEfl):
(WebKit::WebURLRequestEfl::cookies): obtaining cookie information from ResourceRequest.

  • Shared/efl/WebURLRequestEfl.h: Added.

(WebKit):
(WebURLRequestEfl):
(WebKit::WebURLRequestEfl::create):

  • Shared/efl/WebURLResponseEfl.cpp: Added.

(WebKit):
(WebKit::WebURLResponseEfl::WebURLResponseEfl):
(WebKit::WebURLResponseEfl::contentType): obtaining content type (i.e. MIME type) from ResourceResponse.

  • Shared/efl/WebURLResponseEfl.h: Added.

(WebKit):
(WebURLResponseEfl):
(WebKit::WebURLResponseEfl::create):

5:06 AM Changeset in webkit [119091] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening, skip new failing tests, unskip a now passing test.

  • platform/qt/Skipped:
4:57 AM Changeset in webkit [119090] by mario@webkit.org
  • 2 edits
    4 adds in trunk/LayoutTests

Unreviewed. Added new baselines for GTK after r117815.

  • platform/gtk/svg/zoom/page/zoom-hixie-rendering-model-004-expected.txt: Added.
  • platform/gtk/svg/zoom/page/zoom-svg-as-background-with-relative-size-and-viewBox-expected.png: Added.
  • platform/gtk/svg/zoom/page/zoom-svg-as-background-with-relative-size-and-viewBox-expected.txt: Added.
  • platform/gtk/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.png: Updated.
  • platform/gtk/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.txt: Added.
4:57 AM Changeset in webkit [119089] by mario@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

Unreviewed. Added new baselines for GTK after r118891.

  • platform/gtk/fast/forms/select/optgroup-rendering-expected.png: Added.
  • platform/gtk/fast/forms/select/optgroup-rendering-expected.txt: Added.
4:54 AM Changeset in webkit [119088] by yosin@chromium.org
  • 2 edits in trunk/Source/WebCore

[Platform] Implementation of Decimal(int32_t) isn't portable.
​https://bugs.webkit.org/show_bug.cgi?id=87941

Reviewed by Kent Tamura.

This patch changes negation of integer to make unsigned integer
in portable way.

No new tests. This patch doesn't change behavior.

  • platform/Decimal.cpp:

(WebCore::Decimal::Decimal): Use uint64_t(-int64_t(i32)) instead of uint64_t(-i32)

4:48 AM Changeset in webkit [119087] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

fast/events/message-port-multi.html needs new baseline after r119027
​https://bugs.webkit.org/show_bug.cgi?id=87949

Unreviewed gardening.

Update baseline for fast/events/message-port-multi.html after r119027.
Now all the checks are passing and we can get rid of the FAIL lines in
the expected result.

Patch by Christophe Dumez <Christophe Dumez> on 2012-05-31

  • fast/events/message-port-multi-expected.txt:
4:35 AM Changeset in webkit [119086] by gyuyoung.kim@samsung.com
  • 3 edits
    1 move in trunk/Source/WebKit2

[EFL][WK2] Rename ewk_private.h to ewk_view_private.h
​https://bugs.webkit.org/show_bug.cgi?id=87923

Reviewed by Kenneth Rohde Christiansen.

EFL WK1 decided to divide up ewk_private.h into each file's XXX_private.h file in order to maintain
internal functions more easily. EFL WK2 needs to adjust this as well.

  • UIProcess/API/efl/PageClientImpl.cpp:
  • UIProcess/API/efl/ewk_view_private.h: Renamed from Source/WebKit2/UIProcess/API/efl/ewk_private.h.

(WebCore):

  • UIProcess/cairo/BackingStoreCairo.cpp:
4:28 AM Changeset in webkit [119085] by apavlov@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Web Inspector: [Chromium] Cannot bring Inspector to front when paused on breakpoint
​https://bugs.webkit.org/show_bug.cgi?id=87871

Reviewed by Yury Semikhatsky.

When input events handling is suppressed (due to the JS being paused on a breakpoint), we should report
these events as NOT handled by the WebKit, so that the browser can handle them appropriately
(on MacOS, switching between the application windows is done through the default key event handler, so if you run
event.preventDefault() for all keydown events in a handler, the Chromium window switch will not occur on Cmd+`).

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::handleInputEvent):

4:22 AM Changeset in webkit [119084] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Gardening after r118993
​https://bugs.webkit.org/show_bug.cgi?id=87946

Unreviewed gardening.

Test fast/forms/file/input-file-write-files.html that was added at r118993 relies on
unsupported EventSender.beginDragWithFiles and hence should be skipped.

Patch by Mikhail Pozdnyakov <​mikhail.pozdnyakov@intel.com> on 2012-05-31

  • platform/efl/test_expectations.txt:
4:14 AM Changeset in webkit [119083] by mario@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed. Unskipping tests for GTK now passing in all the bots.

  • platform/gtk/test_expectations.txt:
3:42 AM Changeset in webkit [119082] by mario@webkit.org
  • 2 edits in trunk/LayoutTests

fast/dom/Window/mozilla-focus-blur.html failing after r118916
​https://bugs.webkit.org/show_bug.cgi?id=87951

Unreviewed. Added FAIL expectation for GTK after r118916.

  • platform/gtk/test_expectations.txt:
3:10 AM Changeset in webkit [119081] by abecsi@webkit.org
  • 7 edits in trunk/LayoutTests

Test expectation pngs missing checksums
​https://bugs.webkit.org/show_bug.cgi?id=87947

Reviewed by Ojan Vafai.

Add proper platform independent png expectation with checksum and revert chromium
expectations since layoutTestController.keepWebHistory() seems to have no effect
on chromium, and the test is still failing (See bug 87839).

  • http/tests/misc/acid3-expected.png: Add png with embedded checksum.
  • platform/chromium-mac-leopard/http/tests/misc/acid3-expected.png: Revert to prior r118566.
  • platform/chromium-mac-snowleopard/http/tests/misc/acid3-expected.png: Revert to prior r118566.
  • platform/chromium-mac/http/tests/misc/acid3-expected.png: Revert to prior r118566.
  • platform/chromium-mac/http/tests/misc/acid3-expected.txt: Revert to prior r118566.
  • platform/chromium/test_expectations.txt: Revert to prior r118566.
3:02 AM Changeset in webkit [119080] by gyuyoung.kim@samsung.com
  • 4 edits in trunk/Source

Source/WebCore: [CMAKE][EFL] Remove unneeded include path
​https://bugs.webkit.org/show_bug.cgi?id=87927

Reviewed by Kenneth Rohde Christiansen.

Though *wtf* directory was moved to Source/WTF, PlatformEfl.cmake is still including the previous
path. In addition, files on EFL port are using "<wtf/gobject/XXX>" directly in #include line.
So, EFL port doesn't need to include ${JAVASCRIPTCORE_DIR}/wtf/gobject path anymore.

  • PlatformEfl.cmake: Remove '${JAVASCRIPTCORE_DIR}/wtf/gobject' path from include path list.

Source/WebKit: [CMAKE][EFL] Remove unneeded include path
​https://bugs.webkit.org/show_bug.cgi?id=87927

Reviewed by Kenneth Rohde Christiansen.

Though *wtf* directory was moved to Source/WTF, PlatformEfl.cmake is still including the previous
path. In addition, files on EFL port are using <wtf/gobject/XXX> directly in #include line.
So, EFL port doesn't need to include ${JAVASCRIPTCORE_DIR}/wtf/gobject path anymore.

  • PlatformEfl.cmake: Remove '${JAVASCRIPTCORE_DIR}/wtf/gobject' path from include path list.
2:50 AM Changeset in webkit [119079] by peter@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled DEPS.

  • DEPS:
2:47 AM Changeset in webkit [119078] by zoltan@webkit.org
  • 2 edits in trunk/Tools

[Qt] Don't enforce the version of libpng for the config test when passing the option to the linker

Rubber-stamped by Kenneth Rohde Christiansen.

  • qmake/config.tests/libpng/libpng.pro:
2:22 AM Changeset in webkit [119077] by peter@chromium.org
  • 5 edits in trunk

[Chromium] Automatically install 64-bit linker for Android
​https://bugs.webkit.org/show_bug.cgi?id=79780

Reviewed by Adam Barth.

Source/WebKit/chromium:

Change the Android-specific dependencies to inherit their revision from
Chromium's DEPS file, like many other dependencies do, solving the
versioning problem that we're running in to right now. These are listed
in Chromium's main DEPS file starting Chromium r139529.

  • DEPS:

Tools:

Change the update-webkit-chromium script to check whether the 64-bit
linker needs to be installed as part of the update process. The actual
code for doing these checks and "installing" it has been added to the
webkitdirs.pm script.

The linker itself is part of the third_party/aosp repository, which
will be pulled in through the DEPS change.

  • Scripts/update-webkit-chromium:
  • Scripts/webkitdirs.pm:

(chromiumInstall64BitAndroidLinkerIfNeeded):
(chromiumReplaceAndroidLinkerIfNeeded):

2:02 AM Changeset in webkit [119076] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Gardening after r118957
​https://bugs.webkit.org/show_bug.cgi?id=87937

Unreviewed gardening.

compositing/layer-creation/fixed-position-and-transform.html and compositing/layer-creation/fixed-position-under-transform.html
added with r118957 were skipped in EFL port as EFL's LayoutTestController does not implement layerTreeAsText.

Patch by Mikhail Pozdnyakov <​mikhail.pozdnyakov@intel.com> on 2012-05-31

  • platform/efl/test_expectations.txt:
1:55 AM Changeset in webkit [119075] by yosin@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Build fix for Chromium Linux (Tests) after r119073.

  • tests/DecimalTest.cpp:

(TEST_F):

1:42 AM Changeset in webkit [119074] by kkristof@inf.u-szeged.hu
  • 5 edits in trunk/LayoutTests

[Qt] Unreviewed gardening. Rebase xss test, skip failing tests.

Patch by Zoltan Arvai <​zarvai@inf.u-szeged.hu> on 2012-05-31

  • platform/qt/Skipped:
  • platform/qt/http/tests/security/aboutBlank/xss-DENIED-navigate-opener-document-write-expected.txt:
  • platform/qt/http/tests/security/aboutBlank/xss-DENIED-navigate-opener-javascript-url-expected.txt:
  • platform/qt/http/tests/security/aboutBlank/xss-DENIED-set-opener-expected.txt:
1:28 AM Changeset in webkit [119073] by yosin@chromium.org
  • 9 edits
    3 adds in trunk/Source

[Platform] Introduce Decimal class for Number/Range input type.
​https://bugs.webkit.org/show_bug.cgi?id=87360

Reviewed by Kent Tamura.

Source/WebCore:

This patch added new class Decimal for decimal arithmatic in two
files: platform/Decimal.cpp and Decimal.h with unit test.

Test: WebKit/chromium/tests/DecimalTest.cpp

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/Decimal.cpp: Added.

(WebCore):
(DecimalPrivate):
(SpecialValueHandler):
(WebCore::DecimalPrivate::SpecialValueHandler::SpecialValueHandler):
(WebCore::DecimalPrivate::SpecialValueHandler::handle):
(WebCore::DecimalPrivate::SpecialValueHandler::value):
(UInt128):
(WebCore::DecimalPrivate::UInt128::UInt128):
(WebCore::DecimalPrivate::UInt128::high):
(WebCore::DecimalPrivate::UInt128::low):
(WebCore::DecimalPrivate::UInt128::multiply):
(WebCore::DecimalPrivate::UInt128::highUInt32):
(WebCore::DecimalPrivate::UInt128::lowUInt32):
(WebCore::DecimalPrivate::UInt128::isZero):
(WebCore::DecimalPrivate::UInt128::makeUInt64):
(WebCore::DecimalPrivate::UInt128::operator/=):
(WebCore::DecimalPrivate::UInt128::multiplyHigh):
(WebCore::DecimalPrivate::countDigits):
(WebCore::DecimalPrivate::scaleDown):
(WebCore::DecimalPrivate::scaleUp):
(WebCore::Decimal::EncodedData::EncodedData):
(WebCore::Decimal::EncodedData::operator==):
(WebCore::Decimal::Decimal):
(WebCore::Decimal::operator=):
(WebCore::Decimal::operator+=):
(WebCore::Decimal::operator-=):
(WebCore::Decimal::operator*=):
(WebCore::Decimal::operator/=):
(WebCore::Decimal::operator-):
(WebCore::Decimal::operator+):
(WebCore::Decimal::operator*):
(WebCore::Decimal::operator/):
(WebCore::Decimal::operator==):
(WebCore::Decimal::operator!=):
(WebCore::Decimal::operator<):
(WebCore::Decimal::operator<=):
(WebCore::Decimal::operator>):
(WebCore::Decimal::operator>=):
(WebCore::Decimal::abs):
(WebCore::Decimal::alignOperands):
(WebCore::Decimal::ceiling):
(WebCore::Decimal::compareTo):
(WebCore::Decimal::floor):
(WebCore::Decimal::fromString):
(WebCore::Decimal::infinity):
(WebCore::Decimal::nan):
(WebCore::Decimal::remainder):
(WebCore::Decimal::round):
(WebCore::Decimal::toString):
(WebCore::Decimal::zero):

  • platform/Decimal.h: Added.

(WebCore):
(DecimalPrivate):
(Decimal):
(EncodedData):
(WebCore::Decimal::EncodedData::operator!=):
(WebCore::Decimal::EncodedData::coefficient):
(WebCore::Decimal::EncodedData::exponent):
(WebCore::Decimal::EncodedData::isFinite):
(WebCore::Decimal::EncodedData::isNaN):
(WebCore::Decimal::EncodedData::isSpecial):
(WebCore::Decimal::EncodedData::isZero):
(WebCore::Decimal::EncodedData::sign):
(WebCore::Decimal::EncodedData::setSign):
(WebCore::Decimal::EncodedData::formatClass):
(WebCore::Decimal::isFinite):
(WebCore::Decimal::isNaN):
(WebCore::Decimal::isNegative):
(WebCore::Decimal::isPositive):
(WebCore::Decimal::isSpecial):
(WebCore::Decimal::isZero):
(WebCore::Decimal::value):
(AlignedOperands):
(WebCore::Decimal::invertSign):
(WebCore::Decimal::exponent):
(WebCore::Decimal::sign):

Source/WebKit/chromium:

This patch added unit test for Decimal class.

  • WebKit.gypi:
  • tests/DecimalTest.cpp: Added.

(WebCore):
(WebCore::operator<<): Output Decimal for unit test debugging
(DecimalStepRange):
(DecimalStepRange::DecimalStepRange):
(DecimalStepRange::clampValue):
(DecimalTest):
(DecimalTest::encode):
(DecimalTest::fromString):
(DecimalTest::stepDown):
(DecimalTest::stepUp):
(TEST_F):

1:22 AM Changeset in webkit [119072] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL][DRT] Gardening after r118920
​https://bugs.webkit.org/show_bug.cgi?id=87934

Unreviewed, gardening of http/tests/local/fileapi/file-last-modified-after-delete.html which
relies on unsupported drag'n'drop feature.

Patch by Mikhail Pozdnyakov <​mikhail.pozdnyakov@intel.com> on 2012-05-31

  • platform/efl/test_expectations.txt:
1:05 AM Changeset in webkit [119071] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

Web Inspector: Retainers are missing for all objects
​https://bugs.webkit.org/show_bug.cgi?id=87655

Skip the test on wincairo platform.

Patch by Alexei Filippov <​alexeif@chromium.org> on 2012-05-31
Reviewed by Yury Semikhatsky.

  • platform/wincairo/Skipped:
1:00 AM Changeset in webkit [119070] by haraken@chromium.org
  • 22 edits in trunk/Source/WebCore

[V8] Pass Isolate to v8String() in custom bindings
​https://bugs.webkit.org/show_bug.cgi?id=87825

Reviewed by Adam Barth.

The objective is to pass Isolate around in V8 bindings.
This patch passes Isolate to v8String() in custom bindings.

No tests. No change in behavior.

  • bindings/v8/custom/V8ArrayBufferViewCustom.cpp:

(WebCore::installFastSet):

  • bindings/v8/custom/V8ArrayBufferViewCustom.h:

(WebCore):
(WebCore::setWebGLArrayHelper):

  • bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp:

(WebCore::V8CSSStyleDeclaration::namedPropertyEnumerator):
(WebCore::V8CSSStyleDeclaration::namedPropertyGetter):

  • bindings/v8/custom/V8CanvasRenderingContext2DCustom.cpp:

(WebCore::toV8Object):

  • bindings/v8/custom/V8ClipboardCustom.cpp:

(WebCore::V8Clipboard::typesAccessorGetter):

  • bindings/v8/custom/V8DOMStringMapCustom.cpp:

(WebCore::V8DOMStringMap::namedPropertyGetter):
(WebCore::V8DOMStringMap::namedPropertyEnumerator):

  • bindings/v8/custom/V8FileReaderCustom.cpp:

(WebCore::V8FileReader::resultAccessorGetter):

  • bindings/v8/custom/V8HTMLCanvasElementCustom.cpp:

(WebCore::V8HTMLCanvasElement::toDataURLCallback):

  • bindings/v8/custom/V8HTMLElementCustom.cpp:

(WebCore::toV8Object):

  • bindings/v8/custom/V8HTMLInputElementCustom.cpp:

(WebCore::V8HTMLInputElement::selectionDirectionAccessorGetter):

  • bindings/v8/custom/V8IDBAnyCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8IDBKeyCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8InjectedScriptHostCustom.cpp:

(WebCore::V8InjectedScriptHost::databaseIdCallback):
(WebCore::V8InjectedScriptHost::storageIdCallback):

  • bindings/v8/custom/V8InspectorFrontendHostCustom.cpp:

(WebCore::V8InspectorFrontendHost::platformCallback):

  • bindings/v8/custom/V8JavaScriptCallFrameCustom.cpp:

(WebCore::V8JavaScriptCallFrame::typeAccessorGetter):

  • bindings/v8/custom/V8LocationCustom.cpp:

(WebCore::V8Location::toStringCallback):

  • bindings/v8/custom/V8SQLResultSetRowListCustom.cpp:

(WebCore::V8SQLResultSetRowList::itemCallback):

  • bindings/v8/custom/V8StorageCustom.cpp:

(WebCore::V8Storage::namedPropertyEnumerator):
(WebCore::storageGetter):

  • bindings/v8/custom/V8XMLHttpRequestCustom.cpp:

(WebCore::V8XMLHttpRequest::responseTextAccessorGetter):

  • bindings/v8/custom/V8XSLTProcessorCustom.cpp:

(WebCore::V8XSLTProcessor::getParameterCallback):

12:55 AM Changeset in webkit [119069] by hayato@chromium.org
  • 5 edits in trunk

ComposedShadowTreeWalker should support traversing nodes in an orphaned shadow subtree.
​https://bugs.webkit.org/show_bug.cgi?id=87493

Reviewed by Dimitri Glazkov.

Source/WebCore:

ComposedShadowTreeWalker assumed that a visited shadow root is
always assigned to a shadow insertion point since it only
traverses nodes which are rendered. But there is an exceptional
use case such as an event dispatching. Some events, such as a
'click' event, may happen in an orphaned shadow subtree. In such
cases, traversal might start with a node in an orphaned shadow
subtree. So ComposedShadowTreeWalker can not assume that visited
shadow root is always assigned to a shadow insertion point.

This patch only fixes ComposedShadowTreeWalker.
ComposedShadowTreeParentWalker will be fixed in another patch with
an event dispatching test.

Test: fast/dom/shadow/composed-shadow-tree-walker.html

  • dom/ComposedShadowTreeWalker.cpp:

(WebCore::ComposedShadowTreeWalker::traverseParentBackToYoungerShadowRootOrHost):

LayoutTests:

  • fast/dom/shadow/composed-shadow-tree-walker.html:
12:33 AM Changeset in webkit [119068] by yurys@chromium.org
  • 10 edits in trunk/Source

Web Inspector: add MemoryUsageSupport::processMemorySizesInBytes
​https://bugs.webkit.org/show_bug.cgi?id=87830

Reviewed by James Robinson.

Source/Platform:

  • chromium/public/Platform.h:

(Platform):
(WebKit::Platform::processMemorySizesInBytes): moved this method from
Source/WebKit/chromium/public/platform/WebKitPlatformSupport.h, also
removed 'get' prefix.

Source/WebCore:

Added a method for getting process memory usage in bytes. It is
used in the inspector memory instrumentation to get process total
memory usage.

  • inspector/InspectorMemoryAgent.cpp:

(WebCore::InspectorMemoryAgent::getProcessMemoryDistribution):

  • platform/MemoryUsageSupport.cpp:

(WebCore::MemoryUsageSupport::processMemorySizesInBytes):
(WebCore):

  • platform/MemoryUsageSupport.h:

(MemoryUsageSupport): provided embedders with a way to report WebKit process
memory usage.

  • platform/chromium/MemoryUsageSupportChromium.cpp:

(WebCore::MemoryUsageSupport::processMemorySizesInBytes):
(WebCore):

Source/WebKit/chromium:

  • public/platform/WebKitPlatformSupport.h: pulled getProcessMemorySize up

to the Source/Platform/chromium/public/Platform.h

  • src/PlatformSupport.cpp:
12:22 AM Changeset in webkit [119067] by tkent@chromium.org
  • 9 edits
    3 deletes in trunk/Source

Unreviewed, rolling out r119062 and r119064.
​http://trac.webkit.org/changeset/119062
​http://trac.webkit.org/changeset/119064
​https://bugs.webkit.org/show_bug.cgi?id=87360

Broke build on Lion, SnowLoepard, Chromium Windows, and
Chromium Linux 32

Source/WebCore:

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/Decimal.cpp: Removed.
  • platform/Decimal.h: Removed.

Source/WebKit/chromium:

  • WebKit.gypi:
  • tests/DecimalTest.cpp: Removed.
12:18 AM Changeset in webkit [119066] by aestes@apple.com
  • 3 edits in trunk/Source/WebKit2

Move the specification of framework and library linking out of WebKit2.xcodeproj and into WebKit2.xcconfig
​https://bugs.webkit.org/show_bug.cgi?id=87932

Reviewed by Dan Bernstein.

Doing this makes it easier to vary linking based on SDK or other factors.

  • Configurations/WebKit2.xcconfig: Create FRAMEWORK_AND_LIBRARY_LDFLAGS,

which specifies the same list of frameworks and libraries that were
previously in WebKit2's 'Link Binary With Libraries' build phase, and
append it to $(OTHER_LDFLAGS).

  • WebKit2.xcodeproj/project.pbxproj: Remove all frameworks and

libraries from the 'Link Binary With Libraries' build phase.

12:12 AM Changeset in webkit [119065] by commit-queue@webkit.org
  • 5 edits
    2 adds in trunk

text-decoration should not be propagated through absolutely positioned elements to <a> tags
​https://bugs.webkit.org/show_bug.cgi?id=86517

Source/WebCore:

Patch by Shane Stephens <​shanestephens@google.com> on 2012-05-31
Reviewed by Darin Adler.

Test: fast/css/text-decoration-in-second-order-descendants.html

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::getTextDecorationColors):
Remove fix from 18611 as it doesn't work on second order descendants.

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::adjustRenderStyle):
Add floating and positioned checks when deciding whether to avoid propagating text decoration. Move all checks into new method to improve readability.
(WebCore::doesNotInheritTextDecoration): Added

LayoutTests:

Added layout test to check no propagation of text-decoration to second-order descendants
(i.e. descendants of descendants), where the first-order descendant is positioned.

Tightened up existing descendants test to fail when text-decoration is incorrectly propagated
to first-order descendant.

Patch by Shane Stephens <​shanestephens@google.com> on 2012-05-31
Reviewed by Darin Adler.

  • fast/css/text-decoration-in-descendants-expected.html:
  • fast/css/text-decoration-in-second-order-descendants-expected.html: Added.
  • fast/css/text-decoration-in-second-order-descendants.html: Added.

May 30, 2012:

11:58 PM Changeset in webkit [119064] by yosin@chromium.org
  • 2 edits in trunk/Source/WebCore

Build fix for Linon/SnowLeopard after r119062

  • platform/Decimal.cpp:

(WebCore::Decimal::Decimal):

11:46 PM Changeset in webkit [119063] by commit-queue@webkit.org
  • 4 edits in trunk/Source

[GTK] [WK2] Memory leak in webkitWebViewBaseStartDrag
​https://bugs.webkit.org/show_bug.cgi?id=87756

Patch by Sudarsana Nagineni <​sudarsana.nagineni@linux.intel.com> on 2012-05-30
Reviewed by Carlos Garcia Campos.

Source/WebKit/gtk:

Fixed a memory leak in drag and drop by using adoptRef instead
of just getting a new reference of targetList.

  • WebCoreSupport/DragClientGtk.cpp:

(WebKit::DragClient::startDrag):

Source/WebKit2:

Fixed memory leaks in drag and drop by using adoptRef instead
of just getting new references.

  • UIProcess/API/gtk/WebKitWebViewBase.cpp:

(webkitWebViewBaseStartDrag):

11:36 PM Changeset in webkit [119062] by yosin@chromium.org
  • 9 edits
    3 adds in trunk/Source

[Platform] Introduce Decimal class for Number/Range input type.
​https://bugs.webkit.org/show_bug.cgi?id=87360

Reviewed by Kent Tamura.

Source/WebCore:

This patch added new class Decimal for decimal arithmatic in two
files: platform/Decimal.cpp and Decimal.h with unit test.

Test: WebKit/chromium/tests/DecimalTest.cpp

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/Decimal.cpp: Added.

(WebCore):
(DecimalPrivate):
(SpecialValueHandler):
(WebCore::DecimalPrivate::SpecialValueHandler::SpecialValueHandler):
(WebCore::DecimalPrivate::SpecialValueHandler::handle):
(WebCore::DecimalPrivate::SpecialValueHandler::value):
(UInt128):
(WebCore::DecimalPrivate::UInt128::UInt128):
(WebCore::DecimalPrivate::UInt128::high):
(WebCore::DecimalPrivate::UInt128::low):
(WebCore::DecimalPrivate::UInt128::multiply):
(WebCore::DecimalPrivate::UInt128::highUInt32):
(WebCore::DecimalPrivate::UInt128::lowUInt32):
(WebCore::DecimalPrivate::UInt128::isZero):
(WebCore::DecimalPrivate::UInt128::makeUInt64):
(WebCore::DecimalPrivate::UInt128::operator/=):
(WebCore::DecimalPrivate::UInt128::multiplyHigh):
(WebCore::DecimalPrivate::countDigits):
(WebCore::DecimalPrivate::scaleDown):
(WebCore::DecimalPrivate::scaleUp):
(WebCore::Decimal::EncodedData::EncodedData):
(WebCore::Decimal::EncodedData::operator==):
(WebCore::Decimal::Decimal):
(WebCore::Decimal::operator=):
(WebCore::Decimal::operator+=):
(WebCore::Decimal::operator-=):
(WebCore::Decimal::operator*=):
(WebCore::Decimal::operator/=):
(WebCore::Decimal::operator-):
(WebCore::Decimal::operator+):
(WebCore::Decimal::operator*):
(WebCore::Decimal::operator/):
(WebCore::Decimal::operator==):
(WebCore::Decimal::operator!=):
(WebCore::Decimal::operator<):
(WebCore::Decimal::operator<=):
(WebCore::Decimal::operator>):
(WebCore::Decimal::operator>=):
(WebCore::Decimal::abs):
(WebCore::Decimal::alignOperands):
(WebCore::Decimal::ceiling):
(WebCore::Decimal::compareTo):
(WebCore::Decimal::floor):
(WebCore::Decimal::fromString):
(WebCore::Decimal::infinity):
(WebCore::Decimal::nan):
(WebCore::Decimal::remainder):
(WebCore::Decimal::round):
(WebCore::Decimal::toString):
(WebCore::Decimal::zero):

  • platform/Decimal.h: Added.

(WebCore):
(DecimalPrivate):
(Decimal):
(EncodedData):
(WebCore::Decimal::EncodedData::operator!=):
(WebCore::Decimal::EncodedData::coefficient):
(WebCore::Decimal::EncodedData::exponent):
(WebCore::Decimal::EncodedData::isFinite):
(WebCore::Decimal::EncodedData::isNaN):
(WebCore::Decimal::EncodedData::isSpecial):
(WebCore::Decimal::EncodedData::isZero):
(WebCore::Decimal::EncodedData::sign):
(WebCore::Decimal::EncodedData::setSign):
(WebCore::Decimal::EncodedData::formatClass):
(WebCore::Decimal::isFinite):
(WebCore::Decimal::isNaN):
(WebCore::Decimal::isNegative):
(WebCore::Decimal::isPositive):
(WebCore::Decimal::isSpecial):
(WebCore::Decimal::isZero):
(WebCore::Decimal::value):
(AlignedOperands):
(WebCore::Decimal::invertSign):
(WebCore::Decimal::exponent):
(WebCore::Decimal::sign):

Source/WebKit/chromium:

This patch added unit test for Decimal class.

  • WebKit.gypi:
  • tests/DecimalTest.cpp: Added.

(WebCore):
(WebCore::operator<<): Output Decimal for unit test debugging
(DecimalStepRange):
(DecimalStepRange::DecimalStepRange):
(DecimalStepRange::clampValue):
(DecimalTest):
(DecimalTest::encode):
(DecimalTest::fromString):
(DecimalTest::stepDown):
(DecimalTest::stepUp):
(TEST_F):

11:30 PM Changeset in webkit [119061] by Patrick Gansterer
  • 2 edits in trunk/Source/WebCore

Build fix for WinCE after r116723.

  • platform/graphics/wince/FontWinCE.cpp:

(WebCore::TextRunComponent::TextRunComponent):

11:23 PM Changeset in webkit [119060] by haraken@chromium.org
  • 4 edits in trunk/Source/WebCore

Implement CSSParser::determineNameInNamespace() as a helper function for CSSGrammar.y
​https://bugs.webkit.org/show_bug.cgi?id=87799

Reviewed by Darin Adler.

As pointed out by darin@ in ​https://bugs.webkit.org/show_bug.cgi?id=87627#c12,
we should avoid repeating the following code in CSSGrammar.y:

if (p->m_styleSheet)

$$->setTag(QualifiedName(namespacePrefix, $2, p->m_styleSheet->determineNamespace(namespacePrefix)));

else

$$->setTag(QualifiedName(namespacePrefix, $2, p->m_defaultNamespace));

This patch implements CSSParser::determineNameInNamespace() as a helper function
and replaces the above code.

Tests: fast/dom/SelectorAPI/*. No change in test results.

  • css/CSSGrammar.y:
  • css/CSSParser.cpp:

(WebCore::CSSParser::determineNameInNamespace):
(WebCore):

  • css/CSSParser.h:
11:15 PM Changeset in webkit [119059] by Patrick Gansterer
  • 2 edits in trunk/Source/WebCore

Build fix for WinCE after r117697.

  • page/wince/FrameWinCE.cpp:

(WebCore::computePageRectsForFrame):

11:05 PM Changeset in webkit [119058] by shawnsingh@chromium.org
  • 5 edits in trunk/Source

[chromium] Fix min/max bounds error in CCMathUtil.cpp
​https://bugs.webkit.org/show_bug.cgi?id=87915

Reviewed by James Robinson.

Source/WebCore:

Two unit tests added to CCMathUtilTest:

CCMathUtilTest.verifyEnclosingClippedRectUsesCorrectInitialBounds
CCMathUtilTest.verifyEnclosingRectOfVerticesUsesCorrectInitialBounds

While computing bounds, the initial values for xmax and ymax are
intended to be set to -float_max. It turns out that
std::numeric_limits<float>::min() actually returns the smallest
positive value close to zero, which is not what was intended. This
patch fixes the code to use -float_max instead, which is the
intended value.

  • platform/graphics/chromium/cc/CCMathUtil.cpp:

(WebCore::CCMathUtil::mapClippedRect):
(WebCore::CCMathUtil::projectClippedRect):
(WebCore::CCMathUtil::computeEnclosingRectOfVertices):
(WebCore::CCMathUtil::computeEnclosingClippedRect):
(WebCore):

  • platform/graphics/chromium/cc/CCMathUtil.h:

(WebCore::HomogeneousCoordinate::HomogeneousCoordinate):
(HomogeneousCoordinate):
(WebCore::HomogeneousCoordinate::shouldBeClipped):
(WebCore::HomogeneousCoordinate::cartesianPoint2d):
(WebCore):
(CCMathUtil):

Source/WebKit/chromium:

  • tests/CCMathUtilTest.cpp:

(WebCore::TEST):
(WebCore):

10:58 PM Changeset in webkit [119057] by Patrick Gansterer
  • 2 edits in trunk/Source/WebCore

Build fix for WinCE after r118568.

  • platform/text/wince/TextBreakIteratorWinCE.cpp:

(WebCore::NonSharedCharacterBreakIterator::NonSharedCharacterBreakIterator):

10:54 PM Changeset in webkit [119056] by Lucas Forschler
  • 4 edits in branches/safari-536-branch

Merged r118891 -> <rdar://problem/11553964>

10:50 PM Changeset in webkit [119055] by fischman@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Roll chromium DEPS from r139300 to r139542. Unreviewed.
​https://bugs.webkit.org/show_bug.cgi?id=87868

  • DEPS:
9:47 PM Changeset in webkit [119054] by Lucas Forschler
  • 4 edits
    3 copies in branches/safari-536-branch

Merged r118956 -> <rdar://problem/11463622>

9:45 PM Changeset in webkit [119053] by Lucas Forschler
  • 2 edits in branches/safari-536-branch/Source/WebKit2

Merged r118896 -> <rdar://problem/11505987>

9:39 PM Changeset in webkit [119052] by Lucas Forschler
  • 3 edits in branches/safari-536-branch/Source/WebCore

Merged r118883 -> <rdar://problem/11550608>

9:30 PM Changeset in webkit [119051] by Lucas Forschler
  • 11 edits
    2 deletes in branches/safari-536-branch

Merge <rdar://problem/11538697>

9:25 PM Changeset in webkit [119050] by inferno@chromium.org
  • 3 edits
    2 adds in trunk

Crash in ContainerNode::parserAddChild.
​https://bugs.webkit.org/show_bug.cgi?id=87903

Reviewed by Ryosuke Niwa.

Source/WebCore:

Call the ChildNodeInsertionNotifier.notify call at the end since
it can destroy |this| and some of the local pointers like |last|.
This also matches the order of calls - childrenChanged precedes
ChildNodeInsertionNotifier.notify in updateTreeAfterInsertion and
ContainerNode::parserInsertBefore.

Also remove a FIXME since we use ChildNodeInsertionNotifier.notify
instead of ChildNodeInsertionNotifier.notifyInsertedIntoDocument
(as recommended in the FIXME).

Test: fast/dom/child-insertion-notify-crash.html

  • dom/ContainerNode.cpp:

(WebCore::ContainerNode::parserAddChild):

LayoutTests:

  • fast/dom/child-insertion-notify-crash-expected.txt: Added.
  • fast/dom/child-insertion-notify-crash.html: Added.
9:23 PM Changeset in webkit [119049] by Lucas Forschler
  • 3 edits in branches/safari-536-branch/Source/WebCore

Merged r118820 -> <rdar://problem/11550048>

9:20 PM Changeset in webkit [119048] by Lucas Forschler
  • 2 edits in branches/safari-536-branch/Source/JavaScriptCore

Merged r118810 -> <rdar://problem/11459513>

9:12 PM Changeset in webkit [119047] by Lucas Forschler
  • 2 edits in branches/safari-536-branch/Source/WebKit2

Merged r118615 -> <rdar://problem/11499408>

8:59 PM Changeset in webkit [119046] by commit-queue@webkit.org
  • 8 edits
    2 adds in trunk/Source/WebKit

[BlackBerry] Add an Accelerated Compositing layer for Web Inspector DOM highlight.
​https://bugs.webkit.org/show_bug.cgi?id=81001

Source/WebKit:

Patch by Konrad Piascik <​kpiascik@rim.com> on 2012-05-30
Reviewed by Antonio Gomes

Added new InspectorOverlay class

  • PlatformBlackBerry.cmake:

Source/WebKit/blackberry:

Patch by Konrad Piascik <​kpiascik@rim.com> on 2012-05-30
Reviewed by Antonio Gomes.

Implemented InspectorOverlay using WebOverlayAPI.

  • Api/BackingStore.cpp:

(BlackBerry::WebKit::BackingStorePrivate::renderContents):

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::updateDelegatedOverlays):
(BlackBerry::WebKit::WebPagePrivate::commitRootLayerIfNeeded):
(BlackBerry::WebKit::WebPagePrivate::setInspectorOverlayClient):
(WebKit):

  • Api/WebPage_p.h:

(WebCore):
(WebPagePrivate):

  • WebCoreSupport/InspectorClientBlackBerry.cpp:

(WebCore::InspectorClientBlackBerry::highlight):
(WebCore::InspectorClientBlackBerry::hideHighlight):
(WebCore::InspectorClientBlackBerry::paintInspectorOverlay):
(WebCore):

  • WebCoreSupport/InspectorClientBlackBerry.h:

(InspectorClientBlackBerry):

  • WebCoreSupport/InspectorOverlay.cpp: Added.

(WebCore):
(WebCore::InspectorOverlay::create):
(WebCore::InspectorOverlay::InspectorOverlay):
(WebCore::InspectorOverlay::notifySyncRequired):
(WebCore::InspectorOverlay::paintContents):
(WebCore::InspectorOverlay::showDebugBorders):
(WebCore::InspectorOverlay::showRepaintCounter):
(WebCore::InspectorOverlay::contentsVisible):
(WebCore::InspectorOverlay::~InspectorOverlay):
(WebCore::InspectorOverlay::clear):
(WebCore::InspectorOverlay::update):
(WebCore::InspectorOverlay::paintWebFrame):
(WebCore::InspectorOverlay::invalidateWebFrame):

  • WebCoreSupport/InspectorOverlay.h: Added.

(WebKit):
(WebCore):
(InspectorOverlay):
(InspectorOverlayClient):
(WebCore::InspectorOverlay::setClient):
(WebCore::InspectorOverlay::notifyAnimationStarted):

8:56 PM Changeset in webkit [119045] by commit-queue@webkit.org
  • 8 edits
    2 adds in trunk

[chromium] Implement pointer and hover CSS media features
​https://bugs.webkit.org/show_bug.cgi?id=87403

Patch by Rick Byers <​rbyers@chromium.org> on 2012-05-30
Reviewed by Adam Barth.

Source/WebCore:

Add initial support for the pointer and hover media features as defined
here:
​http://dev.w3.org/csswg/css4-mediaqueries/#pointer
​http://dev.w3.org/csswg/css4-mediaqueries/#hover

For now this only supports the case where we know a touch screen is
available (currently known only for the chromium port on certain
platforms). All other cases continue to behave exactly as if the media
feature isn't supported.

Tests: fast/media/mq-pointer.html

  • css/CSSValueKeywords.in:
  • css/MediaFeatureNames.h:

(MediaFeatureNames):

  • css/MediaQueryEvaluator.cpp:

(WebCore::getLeastCapablePrimaryPointerDeviceType):
(WebCore):
(WebCore::hoverMediaFeatureEval):
(WebCore::pointerMediaFeatureEval):

  • testing/InternalSettings.cpp:

(WebCore::InternalSettings::InternalSettings):
(WebCore::InternalSettings::restoreTo):
(WebCore::InternalSettings::setDeviceSupportsTouch):
(WebCore):

  • testing/InternalSettings.h:

(InternalSettings):

  • testing/InternalSettings.idl:

LayoutTests:

Adds tests for pointer and hover media features, for the initial cases
with and without a touch screen.

  • fast/media/mq-pointer-expected.txt: Added.
  • fast/media/mq-pointer.html: Added.
8:55 PM Changeset in webkit [119044] by Lucas Forschler
  • 2 edits in branches/safari-536-branch/Source/WebKit2

Merged r118559 -> <rdar://problem/11518154>

8:53 PM Changeset in webkit [119043] by Lucas Forschler
  • 2 edits in branches/safari-536-branch/Source/WebCore

Merged r118553 -> <rdar://problem/11267408>

8:50 PM Changeset in webkit [119042] by Lucas Forschler
  • 3 edits in branches/safari-536-branch/Source/WebKit2

Merged r118505 -> <rdar://problem/11527166>

8:41 PM Changeset in webkit [119041] by Lucas Forschler
  • 2 edits in branches/safari-536-branch

Fix Changelogs after rolling out 115573.

8:27 PM Changeset in webkit [119040] by Lucas Forschler
  • 2 edits in branches/safari-536-branch/Source/WebCore

Merged r118450 -> <rdar://problem/11503078>

8:26 PM Changeset in webkit [119039] by jberlin@webkit.org
  • 2 edits in trunk/LayoutTests

[Win] Need implementation of layoutTestController.setBackingScaleFactor
​https://bugs.webkit.org/show_bug.cgi?id=87919

Add tests that use setBackingScaleFactor to the Windows Skipped list.

  • platform/win/Skipped:
8:25 PM Changeset in webkit [119038] by Lucas Forschler
  • 2 edits in branches/safari-536-branch/Source/WebKit2

Merged r118443 -> <rdar://problem/10090764>

8:23 PM Changeset in webkit [119037] by Lucas Forschler
  • 3 edits in branches/safari-536-branch/Source/WebKit2

Merged r118441 -> <rdar://problem/10090764>

8:22 PM Changeset in webkit [119036] by Lucas Forschler
  • 5 edits
    3 adds in branches/safari-536-branch

Merge <rdar://problem/11519288>

8:18 PM Changeset in webkit [119035] by Lucas Forschler
  • 7 edits in branches/safari-536-branch/Source/WebKit2

Merged r118439 -> <rdar://problem/11510337>

8:16 PM Changeset in webkit [119034] by Lucas Forschler
  • 2 edits in branches/safari-536-branch/Source/WebCore

Merged r118411 -> <rdar://problem/11350416>

8:15 PM Changeset in webkit [119033] by jchaffraix@webkit.org
  • 4 edits in trunk/Source/WebCore

Add an helper function to get the style for a cell's flow computation
​https://bugs.webkit.org/show_bug.cgi?id=87902

Reviewed by Ojan Vafai.

No expected change in behavior.

This change introduces styleForCellFlow that unify which function we use
to determine a cell's direction and writing mode.

This unification will make it easier to support direction on table row
group (section in WebKit land).

  • rendering/RenderTableCell.h:

(WebCore::RenderTableCell::styleForCellFlow):
Added the new function along with a comment as to its purpose.

  • rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::clippedOverflowRectForRepaint):
(WebCore::RenderTableCell::computeCollapsedStartBorder):
(WebCore::RenderTableCell::computeCollapsedEndBorder):
(WebCore::RenderTableCell::computeCollapsedBeforeBorder):
(WebCore::RenderTableCell::computeCollapsedAfterBorder):
(WebCore::RenderTableCell::borderHalfLeft):
(WebCore::RenderTableCell::borderHalfRight):
(WebCore::RenderTableCell::borderHalfTop):
(WebCore::RenderTableCell::borderHalfBottom):
(WebCore::RenderTableCell::borderHalfStart):
(WebCore::RenderTableCell::borderHalfEnd):
(WebCore::RenderTableCell::borderHalfBefore):
(WebCore::RenderTableCell::borderHalfAfter):
(WebCore::RenderTableCell::paintCollapsedBorders):
Mostly mechanical replacement.

  • rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::cachedCollapsedLeftBorder):
(WebCore::RenderTableCell::cachedCollapsedRightBorder):
(WebCore::RenderTableCell::cachedCollapsedTopBorder):
(WebCore::RenderTableCell::cachedCollapsedBottomBorder):
Made the argument 'const' now.

  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::layoutRows):
Added a FIXME to unify with the rest.

8:14 PM Changeset in webkit [119032] by Lucas Forschler
  • 2 edits in branches/safari-536-branch/Source/WebCore

Merged r118314 -> <rdar://problem/11497837>

8:12 PM Changeset in webkit [119031] by Lucas Forschler
  • 2 edits in branches/safari-536-branch/Source/WebCore

Merged r118087 -> <rdar://problem/11497837>

8:05 PM Changeset in webkit [119030] by Stephanie Lewis
  • 3 edits in trunk/Tools

​https://bugs.webkit.org/show_bug.cgi?id=87803
Layout tests often fail trying to stat nonexistent logs

Reviewed by Dirk Pranke.

CrashReporter removes logs using a heuristic to conserve space. Wrap a
try/catch block around accessing the logs as a precaution.

  • Scripts/webkitpy/common/system/crashlogs.py:

(CrashLogs._find_newest_log_darwin):

8:05 PM Changeset in webkit [119029] by Lucas Forschler
  • 2 edits in branches/safari-536-branch/Source

Merged r116319 -> <rdar://problem/11522805>

8:04 PM Changeset in webkit [119028] by mhahnenberg@apple.com
  • 10 edits
    2 adds in trunk/Source/JavaScriptCore

Heap should sweep incrementally
​https://bugs.webkit.org/show_bug.cgi?id=85429

We shouldn't have to wait for the opportunistic GC timer to fire in order
to call object destructors. Instead, we should incrementally sweep some
subset of the blocks requiring sweeping periodically. We tie this sweeping
to a timer rather than to collections because we want to reclaim this memory
even if we stop allocating. This way, our memory usage scales smoothly with
actual use, regardless of whether we've recently done an opportunistic GC or not.

Reviewed by Geoffrey Garen.

(JSC::Heap::Heap):
(JSC::Heap::collect): We no longer sweep during a full sweep. We only shrink now,
which we will switch over to being done during incremental sweeping too as soon as
all finalizers can be run lazily (and, by extension, incrementally).
(JSC::Heap::sweeper):
(JSC):

  • heap/Heap.h:

(JSC):
(Heap):

  • heap/IncrementalSweeper.cpp: Added.

(JSC):
(JSC::IncrementalSweeper::timerDidFire): The IncrementalSweeper works very similarly to
GCActivityCallback. It is tied to a run-loop based timer that fires periodically based
on how long the previous sweep increment took to run. The IncrementalSweeper doesn't do
anything if the platform doesn't support CoreFoundation.
(JSC::IncrementalSweeper::IncrementalSweeper):
(JSC::IncrementalSweeper::~IncrementalSweeper):
(JSC::IncrementalSweeper::create):
(JSC::IncrementalSweeper::scheduleTimer):
(JSC::IncrementalSweeper::cancelTimer):
(JSC::IncrementalSweeper::doSweep): Iterates over the snapshot of the MarkedSpace taken
during the last collection, checking to see which blocks need sweeping. If it successfully
gets to the end of the blocks that need sweeping then it cancels the timer.
(JSC::IncrementalSweeper::startSweeping): We take a snapshot of the Heap and store it in
a Vector that the incremental sweep will iterate over. We also reset our index into this Vector.

  • heap/IncrementalSweeper.h: Added.

(JSC):
(IncrementalSweeper):

  • heap/MarkedBlock.h:

(JSC::MarkedBlock::needsSweeping): If a block is in the Marked state it needs sweeping
to be usable and to run any destructors that need to be run.

7:58 PM Changeset in webkit [119027] by commit-queue@webkit.org
  • 4 edits in trunk

[JSC] SerializedScriptValue.create() succeeds even if MessagePort object cannot be found in transferred ports
​https://bugs.webkit.org/show_bug.cgi?id=87118

Patch by Christophe Dumez <Christophe Dumez> on 2012-05-30
Reviewed by Adam Barth.

Source/WebCore:

Make SerializedScriptValue.create() throw an exception if one of the
MessagePort objects cannot be found in the transferred ports. This
matches the behavior of the V8 implementation.

Test: webintents/web-intents-obj-constructor.html

  • bindings/js/SerializedScriptValue.cpp:

(WebCore::CloneSerializer::dumpIfTerminal):

LayoutTests:

Unskip webintents/web-intents-obj-constructor.html now that
SerializedScriptValue.create() throws an exception if one of the
MessagePort objects cannot be found in the transferred ports.

  • platform/efl/test_expectations.txt:
7:53 PM Changeset in webkit [119026] by jberlin@webkit.org
  • 1 edit
    157 adds in trunk/LayoutTests

[Win] Need results for ietestcenter CSS3 tests
​https://bugs.webkit.org/show_bug.cgi?id=87916

Add expected (failing?) results to get the bots greener.

  • platform/win/ietestcenter/css3/flexbox/flexbox-align-baseline-001-expected-expected.txt: Added.
  • platform/win/ietestcenter/css3/flexbox/flexbox-align-baseline-001-expected.txt: Added.
  • platform/win/ietestcenter/css3/flexbox/flexbox-align-center-001-expected-expected.txt: Added.
  • platform/win/ietestcenter/css3/flexbox/flexbox-align-center-001-expected.txt: Added.
  • platform/win/ietestcenter/css3/flexbox/flexbox-align-center-002-expected-expected.txt: Added.
  • platform/win/ietestcenter/css3/flexbox/flexbox-align-center-002-expected.txt: Added.
  • platform/win/ietestcenter/css3/flexbox/flexbox-align-end-001-expected-expected.txt: Added.
  • platform/win/ietestcenter/css3/flexbox/flexbox-align-end-001-expected.txt: Added.
  • platform/win/ietestcenter/css3/flexbox/flexbox-align-start-001-expected-expected.txt: Added.
  • platform/win/ietestcenter/css3/flexbox/flexbox-align-start-001-expected.txt: Added.
  • platform/win/ietestcenter/css3/flexbox/flexbox-align-stretch-001-expected-expected.txt: Added.
  • platform/win/ietestcenter/css3/flexbox/flexbox-align-stretch-001-expected.txt: Added.
  • platform/win/ietestcenter/css3/flexbox/flexbox-direction-001-expected-expected.txt: Added.
  • platform/win/ietestcenter/css3/flexbox/flexbox-direction-001-expected.txt: Added.
  • platform/win/ietestcenter/css3/flexbox/flexbox-flex-001-expected-expected.txt: Added.
  • platform/win/ietestcenter/css3/flexbox/flexbox-flex-001-expected.txt: Added.
  • platform/win/ietestcenter/css3/flexbox/flexbox-flex-002-expected-expected.txt: Added.
  • platform/win/ietestcenter/css3/flexbox/flexbox-flex-002-expected.txt: Added.
  • platform/win/ietestcenter/css3/flexbox/flexbox-flex-003-expected-expected.txt: Added.
  • platform/win/ietestcenter/css3/flexbox/flexbox-flex-003-expected.txt: Added.
  • platform/win/ietestcenter/css3/flexbox/flexbox-flex-004-expected-expected.txt: Added.
  • platform/win/ietestcenter/css3/flexbox/flexbox-flex-004-expected.txt: Added.
  • platform/win/ietestcenter/css3/flexbox/flexbox-flex-005-expected-expected.txt: Added.
  • platform/win/ietestcenter/css3/flexbox/flexbox-flex-005-expected.txt: Added.
  • platform/win/ietestcenter/css3/flexbox/flexbox-groups-001-expected-expected.txt: Added.
  • platform/win/ietestcenter/css3/flexbox/flexbox-groups-001-expected.txt: Added.
  • platform/win/ietestcenter/css3/flexbox/flexbox-groups-002-expected-expected.txt: Added.
  • platform/win/ietestcenter/css3/flexbox/flexbox-groups-002-expected.txt: Added.
  • platform/win/ietestcenter/css3/flexbox/flexbox-groups-003-expected-expected.txt: Added.
  • platform/win/ietestcenter/css3/flexbox/flexbox-groups-003-expected.txt: Added.
  • platform/win/ietestcenter/css3/flexbox/flexbox-groups-004-expected-expected.txt: Added.
  • platform/win/ietestcenter/css3/flexbox/flexbox-groups-004-expected.txt: Added.
  • platform/win/ietestcenter/css3/flexbox/flexbox-layout-001-expected-expected.txt: Added.
  • platform/win/ietestcenter/css3/flexbox/flexbox-layout-001-expected.txt: Added.
  • platform/win/ietestcenter/css3/flexbox/flexbox-layout-002-expected-expected.txt: Added.
  • platform/win/ietestcenter/css3/flexbox/flexbox-layout-002-expected.txt: Added.
  • platform/win/ietestcenter/css3/flexbox/flexbox-layout-003-expected-expected.txt: Added.
  • platform/win/ietestcenter/css3/flexbox/flexbox-layout-003-expected.txt: Added.
  • platform/win/ietestcenter/css3/flexbox/flexbox-ordinal-group-001-expected-expected.txt: Added.
  • platform/win/ietestcenter/css3/flexbox/flexbox-pack-center-001-expected-expected.txt: Added.
  • platform/win/ietestcenter/css3/flexbox/flexbox-pack-center-001-expected.txt: Added.
  • platform/win/ietestcenter/css3/flexbox/flexbox-pack-end-001-expected-expected.txt: Added.
  • platform/win/ietestcenter/css3/flexbox/flexbox-pack-end-001-expected.txt: Added.
  • platform/win/ietestcenter/css3/flexbox/flexbox-pack-justify-001-expected-expected.txt: Added.
  • platform/win/ietestcenter/css3/flexbox/flexbox-pack-justify-001-expected.txt: Added.
  • platform/win/ietestcenter/css3/flexbox/flexbox-pack-start-001-expected-expected.txt: Added.
  • platform/win/ietestcenter/css3/flexbox/flexbox-pack-start-001-expected.txt: Added.
  • platform/win/ietestcenter/css3/grid/display-grid-001-expected-expected.txt: Added.
  • platform/win/ietestcenter/css3/grid/display-grid-001-expected.txt: Added.
  • platform/win/ietestcenter/css3/grid/display-grid-002-expected-expected.txt: Added.
  • platform/win/ietestcenter/css3/grid/display-grid-002-expected.txt: Added.
  • platform/win/ietestcenter/css3/grid/grid-column-001-expected-expected.txt: Added.
  • platform/win/ietestcenter/css3/grid/grid-column-001-expected.txt: Added.
  • platform/win/ietestcenter/css3/grid/grid-column-002-expected-expected.txt: Added.
  • platform/win/ietestcenter/css3/grid/grid-column-002-expected.txt: Added.
  • platform/win/ietestcenter/css3/grid/grid-column-003-expected-expected.txt: Added.
  • platform/win/ietestcenter/css3/grid/grid-column-003-expected.txt: Added.
  • platform/win/ietestcenter/css3/grid/grid-columns-001-expected-expected.txt: Added.
  • platform/win/ietestcenter/css3/grid/grid-columns-001-expected.txt: Added.
  • platform/win/ietestcenter/css3/grid/grid-items-001-expected-expected.txt: Added.
  • platform/win/ietestcenter/css3/grid/grid-items-001-expected.txt: Added.
  • platform/win/ietestcenter/css3/grid/grid-items-002-expected-expected.txt: Added.
  • platform/win/ietestcenter/css3/grid/grid-items-002-expected.txt: Added.
  • platform/win/ietestcenter/css3/grid/grid-items-003-expected-expected.txt: Added.
  • platform/win/ietestcenter/css3/grid/grid-items-003-expected.txt: Added.
  • platform/win/ietestcenter/css3/grid/grid-items-004-expected-expected.txt: Added.
  • platform/win/ietestcenter/css3/grid/grid-items-004-expected.txt: Added.
  • platform/win/ietestcenter/css3/grid/grid-items-005-expected-expected.txt: Added.
  • platform/win/ietestcenter/css3/grid/grid-items-005-expected.txt: Added.
  • platform/win/ietestcenter/css3/multicolumn/column-block-formatting-context-001-expected-expected.txt: Added.
  • platform/win/ietestcenter/css3/multicolumn/column-block-formatting-context-001-expected.txt: Added.
  • platform/win/ietestcenter/css3/multicolumn/column-containing-block-001-expected-expected.txt: Added.
  • platform/win/ietestcenter/css3/multicolumn/column-containing-block-001-expected.txt: Added.
  • platform/win/ietestcenter/css3/multicolumn/column-containing-block-002-expected-expected.txt: Added.
  • platform/win/ietestcenter/css3/multicolumn/column-containing-block-002-expected.txt: Added.
  • platform/win/ietestcenter/css3/multicolumn/column-containing-block-003-expected-expected.txt: Added.
  • platform/win/ietestcenter/css3/multicolumn/column-containing-block-003-expected.txt: Added.
  • platform/win/ietestcenter/css3/multicolumn/column-filling-001-expected-expected.txt: Added.
  • platform/win/ietestcenter/css3/multicolumn/column-filling-001-expected.txt: Added.
  • platform/win/ietestcenter/css3/multicolumn/column-width-applies-to-001-expected-expected.txt: Added.
  • platform/win/ietestcenter/css3/multicolumn/column-width-applies-to-001-expected.txt: Added.
  • platform/win/ietestcenter/css3/multicolumn/column-width-applies-to-002-expected-expected.txt: Added.
  • platform/win/ietestcenter/css3/multicolumn/column-width-applies-to-002-expected.txt: Added.
  • platform/win/ietestcenter/css3/multicolumn/column-width-applies-to-003-expected-expected.txt: Added.
  • platform/win/ietestcenter/css3/multicolumn/column-width-applies-to-003-expected.txt: Added.
  • platform/win/ietestcenter/css3/multicolumn/column-width-applies-to-004-expected-expected.txt: Added.
  • platform/win/ietestcenter/css3/multicolumn/column-width-applies-to-004-expected.txt: Added.
  • platform/win/ietestcenter/css3/multicolumn/column-width-applies-to-005-expected-expected.txt: Added.
  • platform/win/ietestcenter/css3/multicolumn/column-width-applies-to-005-expected.txt: Added.
  • platform/win/ietestcenter/css3/multicolumn/column-width-applies-to-006-expected-expected.txt: Added.
  • platform/win/ietestcenter/css3/multicolumn/column-width-applies-to-006-expected.txt: Added.
  • platform/win/ietestcenter/css3/multicolumn/column-width-applies-to-007-expected-expected.txt: Added.
  • platform/win/ietestcenter/css3/multicolumn/column-width-applies-to-007-expected.txt: Added.
  • platform/win/ietestcenter/css3/multicolumn/column-width-applies-to-008-expected-expected.txt: Added.
  • platform/win/ietestcenter/css3/multicolumn/column-width-applies-to-008-expected.txt: Added.
  • platform/win/ietestcenter/css3/multicolumn/column-width-applies-to-009-expected-expected.txt: Added.
  • platform/win/ietestcenter/css3/multicolumn/column-width-applies-to-009-expected.txt: Added.
  • platform/win/ietestcenter/css3/multicolumn/column-width-applies-to-010-expected-expected.txt: Added.
  • platform/win/ietestcenter/css3/multicolumn/column-width-applies-to-010-expected.txt: Added.
  • platform/win/ietestcenter/css3/multicolumn/column-width-applies-to-012-expected-expected.txt: Added.
  • platform/win/ietestcenter/css3/multicolumn/column-width-applies-to-012-expected.txt: Added.
  • platform/win/ietestcenter/css3/multicolumn/column-width-applies-to-013-expected-expected.txt: Added.
  • platform/win/ietestcenter/css3/multicolumn/column-width-applies-to-013-expected.txt: Added.
  • platform/win/ietestcenter/css3/multicolumn/column-width-applies-to-014-expected-expected.txt: Added.
  • platform/win/ietestcenter/css3/multicolumn/column-width-applies-to-014-expected.txt: Added.
  • platform/win/ietestcenter/css3/multicolumn/column-width-applies-to-015-expected-expected.txt: Added.
  • platform/win/ietestcenter/css3/multicolumn/column-width-applies-to-015-expected.txt: Added.
  • platform/win/ietestcenter/css3/multicolumn/column-width-negative-001-expected-expected.txt: Added.
  • platform/win/ietestcenter/css3/multicolumn/column-width-negative-001-expected.txt: Added.
  • platform/win/ietestcenter/css3/multicolumn/column-width-percentage-001-expected-expected.txt: Added.
  • platform/win/ietestcenter/css3/multicolumn/column-width-percentage-001-expected.txt: Added.
  • platform/win/ietestcenter/css3/namespaces/declaring-001-expected-expected.txt: Added.
  • platform/win/ietestcenter/css3/namespaces/declaring-001-expected.txt: Added.
  • platform/win/ietestcenter/css3/namespaces/prefix-007-expected-expected.txt: Added.
  • platform/win/ietestcenter/css3/namespaces/prefix-007-expected.txt: Added.
  • platform/win/ietestcenter/css3/namespaces/prefix-008-expected-expected.txt: Added.
  • platform/win/ietestcenter/css3/namespaces/prefix-008-expected.txt: Added.
  • platform/win/ietestcenter/css3/namespaces/prefix-009-expected-expected.txt: Added.
  • platform/win/ietestcenter/css3/namespaces/prefix-009-expected.txt: Added.
  • platform/win/ietestcenter/css3/namespaces/prefix-010-expected-expected.txt: Added.
  • platform/win/ietestcenter/css3/namespaces/prefix-010-expected.txt: Added.
  • platform/win/ietestcenter/css3/namespaces/prefix-011-expected-expected.txt: Added.
  • platform/win/ietestcenter/css3/namespaces/prefix-011-expected.txt: Added.
  • platform/win/ietestcenter/css3/namespaces/qualifiedNames-001-expected-expected.txt: Added.
  • platform/win/ietestcenter/css3/namespaces/qualifiedNames-001-expected.txt: Added.
  • platform/win/ietestcenter/css3/namespaces/scope-003-expected-expected.txt: Added.
  • platform/win/ietestcenter/css3/namespaces/scope-003-expected.txt: Added.
  • platform/win/ietestcenter/css3/namespaces/syntax-016-expected-expected.txt: Added.
  • platform/win/ietestcenter/css3/namespaces/syntax-016-expected.txt: Added.
  • platform/win/ietestcenter/css3/namespaces/syntax-017-expected-expected.txt: Added.
  • platform/win/ietestcenter/css3/namespaces/syntax-017-expected.txt: Added.
  • platform/win/ietestcenter/css3/namespaces/syntax-018-expected-expected.txt: Added.
  • platform/win/ietestcenter/css3/namespaces/syntax-018-expected.txt: Added.
  • platform/win/ietestcenter/css3/namespaces/syntax-019-expected-expected.txt: Added.
  • platform/win/ietestcenter/css3/namespaces/syntax-019-expected.txt: Added.
  • platform/win/ietestcenter/css3/namespaces/syntax-020-expected-expected.txt: Added.
  • platform/win/ietestcenter/css3/namespaces/syntax-020-expected.txt: Added.
  • platform/win/ietestcenter/css3/namespaces/syntax-021-expected-expected.txt: Added.
  • platform/win/ietestcenter/css3/namespaces/syntax-021-expected.txt: Added.
  • platform/win/ietestcenter/css3/namespaces/syntax-022-expected-expected.txt: Added.
  • platform/win/ietestcenter/css3/namespaces/syntax-022-expected.txt: Added.
  • platform/win/ietestcenter/css3/namespaces/syntax-023-expected-expected.txt: Added.
  • platform/win/ietestcenter/css3/namespaces/syntax-023-expected.txt: Added.
  • platform/win/ietestcenter/css3/namespaces/terminology-001-expected-expected.txt: Added.
  • platform/win/ietestcenter/css3/namespaces/terminology-001-expected.txt: Added.
  • platform/win/ietestcenter/css3/valuesandunits/units-000-expected-expected.txt: Added.
  • platform/win/ietestcenter/css3/valuesandunits/units-010-expected-expected.txt: Added.
  • platform/win/ietestcenter/css3/valuesandunits/units-010-expected.txt: Added.
  • platform/win/ietestcenter/css3/valuesandunits/units-020-expected-expected.txt: Added.
  • platform/win/ietestcenter/css3/valuesandunits/units-020-expected.txt: Added.
7:43 PM Changeset in webkit [119025] by Lucas Forschler
  • 28 edits in branches/safari-536-branch

Rollout r115573 -> <rdar://problem/11553831>

7:31 PM Changeset in webkit [119024] by pilgrim@chromium.org
  • 6 edits in trunk/Source

[Chromium] Call fileUtilities methods directly
​https://bugs.webkit.org/show_bug.cgi?id=87852

Reviewed by Adam Barth.

Part of a refactoring series. See tracking bug 82948.

Source/WebCore:

  • platform/chromium/DragDataChromium.cpp:

(WebCore::DragData::asURL):

  • platform/chromium/FileSystemChromium.cpp:

(WebCore::deleteFile):
(WebCore::deleteEmptyDirectory):
(WebCore::getFileSize):
(WebCore::getFileModificationTime):
(WebCore::getFileMetadata):
(WebCore::directoryName):
(WebCore::pathByAppendingComponent):
(WebCore::makeAllDirectories):
(WebCore::openFile):
(WebCore::closeFile):
(WebCore::seekFile):
(WebCore::truncateFile):
(WebCore::readFromFile):
(WebCore::writeToFile):

  • platform/chromium/PlatformSupport.h:

(PlatformSupport):

Source/WebKit/chromium:

  • src/PlatformSupport.cpp:

(WebCore):

7:24 PM Changeset in webkit [119023] by tkent@chromium.org
  • 5 edits
    2 adds in trunk

Form controls in <fieldset disabled> should not be focusable.
​https://bugs.webkit.org/show_bug.cgi?id=87380

Reviewed by Darin Adler.

Source/WebCore:

Test: fast/forms/fieldset/focus-in-fieldset-disabled.html

  • html/HTMLFormControlElement.cpp:

(WebCore::HTMLFormControlElement::supportsFocus):
Refer to disabled() instead of m_disabled to take account of wrapping
fieldset elements.

LayoutTests:

  • fast/forms/fieldset/fieldset-disabled-expected.txt:
  • fast/forms/fieldset/fieldset-disabled.html:

Updated because disabled controls are not focusable.
Also, remove testing elements to remove unnecessary blank lines.

  • fast/forms/fieldset/focus-in-fieldset-disabled-expected.txt: Added.
  • fast/forms/fieldset/focus-in-fieldset-disabled.html: Added.
7:17 PM Changeset in webkit [119022] by hayato@chromium.org
  • 3 edits in trunk/LayoutTests

Fix a composed-shadow-tree-walker.html so that it uses correct selectors.
​https://bugs.webkit.org/show_bug.cgi?id=87500

Reviewed by Dimitri Glazkov.

Fix a test and an expectation for composed-shadow-tree-walker.html.
A current composed-shadow-tree-walker.html uses class selector
(.class). That's not the test author's intention and the expected
text was wrongly generated based on wrong tests.

  • fast/dom/shadow/composed-shadow-tree-walker-expected.txt:
  • fast/dom/shadow/composed-shadow-tree-walker.html:
7:03 PM Changeset in webkit [119021] by kevino@webkit.org
  • 3 edits in trunk/Source/WebCore

[wx] Implement HTML clipboard support.
​https://bugs.webkit.org/show_bug.cgi?id=87883

Reviewed by Kevin Ollivier.

7:01 PM Changeset in webkit [119020] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

TextFieldDecorationElement should respect style attribute
​https://bugs.webkit.org/show_bug.cgi?id=87762

Patch by Garrett Casto <​gcasto@chromium.org> on 2012-05-30
Reviewed by Kent Tamura.

  • html/shadow/TextFieldDecorationElement.cpp: Use style set on the

Element when creating rendering style.
(WebCore::TextFieldDecorationElement::customStyleForRenderer):

6:54 PM Changeset in webkit [119019] by gavinp@chromium.org
  • 7 edits
    6 adds in trunk

Add a LayoutTest for prerender remove after stop.
​https://bugs.webkit.org/show_bug.cgi?id=87860

Tools:

These very boring mocks in DumpRenderTree mean that the basic Prerendering API
can be tested by LayoutTests now.

Reviewed by Adam Barth.

  • DumpRenderTree/DumpRenderTree.gypi:
  • DumpRenderTree/chromium/MockWebPrerenderingSupport.cpp: Added.

(MockWebPrerenderingSupport::MockWebPrerenderingSupport):
(MockWebPrerenderingSupport::~MockWebPrerenderingSupport):
(MockWebPrerenderingSupport::add):
(MockWebPrerenderingSupport::cancel):
(MockWebPrerenderingSupport::abandon):

  • DumpRenderTree/chromium/MockWebPrerenderingSupport.h: Added.

(MockWebPrerenderingSupport):

  • DumpRenderTree/chromium/TestShell.cpp:

(TestShell::initialize):

  • DumpRenderTree/chromium/TestShell.h:

(TestShell):

  • DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::willAddPrerender):
(WebViewHost::setWebWidget):

  • DumpRenderTree/chromium/WebViewHost.h:

(WebViewHost):

LayoutTests:

Bug 87746 was uploaded without a LayoutTest because I originally thought
it would only be testable in Chrome with a browser test. However, that was
wrong.

Note that this test doesn't need to be disabled based on if the platform
uses Prerendering, since the test is for a crash, which won't happen on
platforms without prerendering, either.

Reviewed by Adam Barth.

  • fast/dom/HTMLLinkElement/prerender-remove-after-stop-expected.txt: Added.
  • fast/dom/HTMLLinkElement/prerender-remove-after-stop.html: Added.
  • fast/dom/HTMLLinkElement/resources/empty.html: Added.
  • fast/dom/HTMLLinkElement/resources/simple-prerender.html: Added.
6:51 PM Changeset in webkit [119018] by Stephanie Lewis
  • 4 edits in trunk/Tools

​https://bugs.webkit.org/show_bug.cgi?id=87717
Unresponsive WebProcesses can be mistaken for WebProcess crashes.

Reviewed by Dirk Pranke.

Change the error message from #CRASHED to #UNRESPONSIVE PROCESS
If there isn't a crash log found for the process add a message saying
the process was unresponsive.

  • Scripts/webkitpy/layout_tests/port/webkit.py:

(WebKitDriver.init):
(WebKitDriver._check_for_driver_crash):
(WebKitDriver.run_test):

  • Scripts/webkitpy/layout_tests/port/webkit_unittest.py:

(WebKitDriverTest.test_check_for_driver_crash.assert_crash):
(WebKitDriverTest):
(WebKitDriverTest.test_check_for_driver_crash):

  • WebKitTestRunner/TestController.cpp:

(WTR):
(WTR::TestController::runTest):

6:51 PM Changeset in webkit [119017] by Stephanie Lewis
  • 6 edits in trunk/Tools

​https://bugs.webkit.org/show_bug.cgi?id=87714
Mac crash logs can take a really long time to be written out.

Reviewed by Dirk Pranke.

Make a second pass looking for crash logs after the tests have completed running.

  • Scripts/webkitpy/layout_tests/controllers/manager.py:

(use_trac_links_in_results_html):
(Manager.run):

  • Scripts/webkitpy/layout_tests/port/base.py:

(Port.repository_paths):
(Port.look_for_new_crash_logs):

  • Scripts/webkitpy/layout_tests/port/mac.py:

(MacPort.look_for_new_crash_logs):

  • Scripts/webkitpy/layout_tests/port/mac_unittest.py:

(test_get_crash_log):
(test_look_for_new_crash_logs):
(test_look_for_new_crash_logs.fake_time_cb):

6:38 PM Changeset in webkit [119016] by Patrick Gansterer
  • 2 edits in trunk/Source/JavaScriptCore

[WINCE] Fix JSString after r115516.
​https://bugs.webkit.org/show_bug.cgi?id=87892

Reviewed by Geoffrey Garen.

r115516 splitted JSString into two classes, with addition nested classes.
Add a workaround for the WinCE compiler since it can't resolve the friend class
declerations corretly and denies the access to protected members of JSString.

  • runtime/JSString.h:

(JSC::JSRopeString::RopeBuilder::append):
(JSC::JSRopeString::append):
(JSRopeString):

6:37 PM Changeset in webkit [119015] by ojan@chromium.org
  • 2 edits in trunk/Source/WebCore

Avoid second layout for flex-direction:row, flex-basis:auto flex items
​https://bugs.webkit.org/show_bug.cgi?id=87901

Reviewed by Tony Chang.

No new tests. This is strictly a performance optimization and has no other
web visible changes.

Also, add FIXMEs for other cases where we could avoid doing layouts.

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::computeMainAxisPreferredSizes):
(WebCore::RenderFlexibleBox::layoutAndPlaceChildren):
(WebCore::RenderFlexibleBox::applyStretchAlignmentToChild):

6:31 PM Changeset in webkit [119014] by zmo@google.com
  • 5 edits in trunk

WebKit incorrectly clears the alpha channel on readPixels, even for Framebuffers
​https://bugs.webkit.org/show_bug.cgi?id=87310

Reviewed by Kenneth Russell.

Source/WebCore:

  • html/canvas/WebGLRenderingContext.cpp:

(WebCore):
(WebCore::WebGLRenderingContext::getParameter): set DEPTH_BITS/STENCIL_BITS to 0 if related channels are not requested.
(WebCore::WebGLRenderingContext::readPixels): don't do the alpha value fix if the current bound is not the internal drawing buffer.

LayoutTests:

  • fast/canvas/webgl/context-attributes-alpha-depth-stencil-antialias-expected.txt:
  • fast/canvas/webgl/context-attributes-alpha-depth-stencil-antialias.html: synced with khronos
6:21 PM Changeset in webkit [119013] by rafaelw@chromium.org
  • 77 edits in trunk

Unreviewed, rolling out r118986.
​http://trac.webkit.org/changeset/118986
​https://bugs.webkit.org/show_bug.cgi?id=87914

Caused several IndexedDB browser_test failures on Chromium
canary builders (Requested by rafaelw_ on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-05-30

Source/WebCore:

  • Modules/indexeddb/IDBCursor.cpp:

(WebCore::IDBCursor::advance):

  • Modules/indexeddb/IDBDatabaseBackendImpl.cpp:

(WebCore::IDBDatabaseBackendImpl::setVersion):

  • Modules/indexeddb/IDBDatabaseError.h:

(WebCore::IDBDatabaseError::create):
(IDBDatabaseError):
(WebCore::IDBDatabaseError::createWithoutOffset):
(WebCore::IDBDatabaseError::code):
(WebCore::IDBDatabaseError::setCode):
(WebCore::IDBDatabaseError::setMessage):
(WebCore::IDBDatabaseError::IDBDatabaseError):

  • Modules/indexeddb/IDBDatabaseException.cpp:

(WebCore):
(WebCore::IDBDatabaseException::initializeDescription):

  • Modules/indexeddb/IDBDatabaseException.h:

(IDBDatabaseException):

  • Modules/indexeddb/IDBObjectStore.cpp:

(WebCore::IDBObjectStore::createIndex):

  • Modules/indexeddb/IDBRequest.cpp:

(WebCore::IDBRequest::resetReadyState):
(WebCore::IDBRequest::abort):
(WebCore::IDBRequest::onError):
(WebCore::IDBRequest::onSuccess):
(WebCore::IDBRequest::onSuccessWithContinuation):
(WebCore::IDBRequest::dispatchEvent):

  • Modules/indexeddb/IDBRequest.h:

(IDBRequest):

  • Modules/indexeddb/IDBRequest.idl:
  • Modules/indexeddb/IDBTransaction.cpp:
  • Modules/indexeddb/IDBTransaction.h:

(IDBTransaction):

  • Modules/indexeddb/IDBTransaction.idl:

Source/WebKit/chromium:

  • src/WebIDBDatabaseError.cpp:

(WebKit::WebIDBDatabaseError::assign):

LayoutTests:

  • storage/indexeddb/basics-expected.txt:
  • storage/indexeddb/basics-workers-expected.txt:
  • storage/indexeddb/create-and-remove-object-store-expected.txt:
  • storage/indexeddb/cursor-continue-expected.txt:
  • storage/indexeddb/cursor-update-expected.txt:
  • storage/indexeddb/database-basics-expected.txt:
  • storage/indexeddb/deleteIndex-expected.txt:
  • storage/indexeddb/factory-cmp-expected.txt:
  • storage/indexeddb/get-keyrange-expected.txt:
  • storage/indexeddb/index-basics-expected.txt:
  • storage/indexeddb/index-basics-workers-expected.txt:
  • storage/indexeddb/index-count-expected.txt:
  • storage/indexeddb/index-unique-expected.txt:
  • storage/indexeddb/invalid-keys-expected.txt:
  • storage/indexeddb/key-generator-expected.txt:
  • storage/indexeddb/key-type-array-expected.txt:
  • storage/indexeddb/keypath-edges-expected.txt:
  • storage/indexeddb/keyrange-expected.txt:
  • storage/indexeddb/objectstore-autoincrement-expected.txt:
  • storage/indexeddb/objectstore-basics-expected.txt:
  • storage/indexeddb/objectstore-basics-workers-expected.txt:
  • storage/indexeddb/objectstore-count-expected.txt:
  • storage/indexeddb/open-cursor-expected.txt:
  • storage/indexeddb/readonly-expected.txt:
  • storage/indexeddb/resources/basics.js:

(test):
(openCallback):

  • storage/indexeddb/resources/create-and-remove-object-store.js:

(testCreateAndRemove):
(cleanDatabase):
(tryOnceMore):

  • storage/indexeddb/resources/cursor-continue.js:

(ascendingErrorTestLessThan.request.onsuccess):
(ascendingErrorTestLessThan):
(ascendingErrorTestEqual.request.onsuccess):
(ascendingErrorTestEqual):
(descendingErrorTestGreaterThan.request.onsuccess):
(descendingErrorTestGreaterThan):
(descendingErrorTestEqual.request.onsuccess):
(descendingErrorTestEqual):
(onTransactionComplete):

  • storage/indexeddb/resources/cursor-update.js:

(keyCursor):

  • storage/indexeddb/resources/database-basics.js:

(testClose):

  • storage/indexeddb/resources/database-quota.js:

(logError):

  • storage/indexeddb/resources/deleteIndex.js:

(twiddleIndexes):
(postTwiddling):

  • storage/indexeddb/resources/factory-cmp.js:

(testValidKeys):
(testInvalidKeys):

  • storage/indexeddb/resources/get-keyrange.js:

(getNullTest):

  • storage/indexeddb/resources/index-basics.js:

(index3Count):

  • storage/indexeddb/resources/index-count.js:
  • storage/indexeddb/resources/index-unique.js:

(addMoreDataFailed):

  • storage/indexeddb/resources/invalid-keys.js:
  • storage/indexeddb/resources/key-generator.js:
  • storage/indexeddb/resources/key-type-array.js:

(testDepthLimits):

  • storage/indexeddb/resources/keypath-edges.js:
  • storage/indexeddb/resources/keyrange.js:

(test):

  • storage/indexeddb/resources/objectstore-autoincrement.js:

(getAbrahamSuccess):

  • storage/indexeddb/resources/objectstore-basics.js:

(setVersionSuccess):
(createIndex):
(addAgainFailure):
(removeSuccessButNotThere):
(testPreConditions.request.onsuccess):
(testPreConditions):

  • storage/indexeddb/resources/objectstore-count.js:
  • storage/indexeddb/resources/open-cursor.js:

(cursorWithKeySuccess):
(cursorSuccess):

  • storage/indexeddb/resources/readonly.js:

(openSuccess):

  • storage/indexeddb/resources/set_version_queue.js:

(connectionError):

  • storage/indexeddb/resources/shared.js:

(unexpectedErrorCallback):
(evalAndExpectException):

  • storage/indexeddb/resources/transaction-abort-workers.js:

(transactionAborted):
(transactionCompleted):
(timeoutTest.transaction.onabort):
(timeoutTest):
(errorTransactionAborted):

  • storage/indexeddb/resources/transaction-abort.js:

(firstAdd):
(secondAdd):
(transactionAborted):

  • storage/indexeddb/resources/transaction-after-close.js:

(firstTransactionComplete):

  • storage/indexeddb/resources/transaction-and-objectstore-calls.js:

(created):
(afterComplete):

  • storage/indexeddb/resources/transaction-basics.js:

(testInactiveAbortedTransaction):
(testInactiveCompletedTransaction):
(testInvalidMode):

  • storage/indexeddb/resources/transaction-read-only.js:

(setVersionDone):
(gotCursor):

  • storage/indexeddb/set_version_queue-expected.txt:
  • storage/indexeddb/transaction-abort-expected.txt:
  • storage/indexeddb/transaction-abort-workers-expected.txt:
  • storage/indexeddb/transaction-after-close-expected.txt:
  • storage/indexeddb/transaction-and-objectstore-calls-expected.txt:
  • storage/indexeddb/transaction-basics-expected.txt:
  • storage/indexeddb/transaction-read-only-expected.txt:
6:14 PM Changeset in webkit [119012] by commit-queue@webkit.org
  • 9 edits
    2 adds
    1 delete in trunk

Source/WebCore: [Chromium] AX: WebAccessibilityObject should check if an AccessibilityObject is detached
​https://bugs.webkit.org/show_bug.cgi?id=87778

Patch by Dominic Mazzoni <​dmazzoni@chromium.org> on 2012-05-30
Reviewed by Adam Barth.

Chromium was never actually using AccessibilityObjectWrapper, so
this change deletes it. Instead, it's replaced with a simple bool
that keeps track of whether an AccessibilityObject was detached or
not. WebKit/chromium/public/WebAccessibilityObject can then use this
to determine if an object is still valid.

Test: accessibility/accessibility-object-detached.html

  • WebCore.gypi:
  • accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::AccessibilityObject):
(WebCore::AccessibilityObject::detach):
(WebCore::AccessibilityObject::isDetached):
(WebCore):

  • accessibility/AccessibilityObject.h:

(AccessibilityObject):

  • accessibility/chromium/AXObjectCacheChromium.cpp:

(WebCore):
(WebCore::AXObjectCache::detachWrapper):
(WebCore::AXObjectCache::attachWrapper):

  • accessibility/chromium/AccessibilityObjectWrapper.h: Removed.

Source/WebKit/chromium: AX: Chromium WebAccessibilityObject should check if an AccessibilityObject is detached
​https://bugs.webkit.org/show_bug.cgi?id=87778

Patch by Dominic Mazzoni <​dmazzoni@google.com> on 2012-05-30
Reviewed by Adam Barth.

Pretty simple - all places that previously just checked for null
now also check if the wrapped AccessibilityObject is detached.

  • public/WebAccessibilityObject.h:

(WebAccessibilityObject):

  • src/WebAccessibilityObject.cpp:

(WebKit::WebAccessibilityObject::isDetached):
(WebKit):
(WebKit::WebAccessibilityObject::axID):
(WebKit::WebAccessibilityObject::accessibilityDescription):
(WebKit::WebAccessibilityObject::actionVerb):
(WebKit::WebAccessibilityObject::canSetFocusAttribute):
(WebKit::WebAccessibilityObject::canSetValueAttribute):
(WebKit::WebAccessibilityObject::isValid):
(WebKit::WebAccessibilityObject::childCount):
(WebKit::WebAccessibilityObject::childAt):
(WebKit::WebAccessibilityObject::firstChild):
(WebKit::WebAccessibilityObject::focusedChild):
(WebKit::WebAccessibilityObject::lastChild):
(WebKit::WebAccessibilityObject::nextSibling):
(WebKit::WebAccessibilityObject::parentObject):
(WebKit::WebAccessibilityObject::previousSibling):
(WebKit::WebAccessibilityObject::canSetSelectedAttribute):
(WebKit::WebAccessibilityObject::isAnchor):
(WebKit::WebAccessibilityObject::isAriaReadOnly):
(WebKit::WebAccessibilityObject::isButtonStateMixed):
(WebKit::WebAccessibilityObject::isChecked):
(WebKit::WebAccessibilityObject::isCollapsed):
(WebKit::WebAccessibilityObject::isControl):
(WebKit::WebAccessibilityObject::isEnabled):
(WebKit::WebAccessibilityObject::isFocused):
(WebKit::WebAccessibilityObject::isHovered):
(WebKit::WebAccessibilityObject::isIndeterminate):
(WebKit::WebAccessibilityObject::isLinked):
(WebKit::WebAccessibilityObject::isLoaded):
(WebKit::WebAccessibilityObject::isMultiSelectable):
(WebKit::WebAccessibilityObject::isOffScreen):
(WebKit::WebAccessibilityObject::isPasswordField):
(WebKit::WebAccessibilityObject::isPressed):
(WebKit::WebAccessibilityObject::isReadOnly):
(WebKit::WebAccessibilityObject::isRequired):
(WebKit::WebAccessibilityObject::isSelected):
(WebKit::WebAccessibilityObject::isSelectedOptionActive):
(WebKit::WebAccessibilityObject::isVertical):
(WebKit::WebAccessibilityObject::isVisible):
(WebKit::WebAccessibilityObject::isVisited):
(WebKit::WebAccessibilityObject::accessKey):
(WebKit::WebAccessibilityObject::ariaHasPopup):
(WebKit::WebAccessibilityObject::ariaLiveRegionAtomic):
(WebKit::WebAccessibilityObject::ariaLiveRegionBusy):
(WebKit::WebAccessibilityObject::ariaLiveRegionRelevant):
(WebKit::WebAccessibilityObject::ariaLiveRegionStatus):
(WebKit::WebAccessibilityObject::boundingBoxRect):
(WebKit::WebAccessibilityObject::estimatedLoadingProgress):
(WebKit::WebAccessibilityObject::helpText):
(WebKit::WebAccessibilityObject::headingLevel):
(WebKit::WebAccessibilityObject::hierarchicalLevel):
(WebKit::WebAccessibilityObject::hitTest):
(WebKit::WebAccessibilityObject::keyboardShortcut):
(WebKit::WebAccessibilityObject::performDefaultAction):
(WebKit::WebAccessibilityObject::roleValue):
(WebKit::WebAccessibilityObject::selectionEnd):
(WebKit::WebAccessibilityObject::selectionStart):
(WebKit::WebAccessibilityObject::setFocused):
(WebKit::WebAccessibilityObject::stringValue):
(WebKit::WebAccessibilityObject::title):
(WebKit::WebAccessibilityObject::titleUIElement):
(WebKit::WebAccessibilityObject::url):
(WebKit::WebAccessibilityObject::valueDescription):
(WebKit::WebAccessibilityObject::valueForRange):
(WebKit::WebAccessibilityObject::maxValueForRange):
(WebKit::WebAccessibilityObject::minValueForRange):
(WebKit::WebAccessibilityObject::node):
(WebKit::WebAccessibilityObject::document):
(WebKit::WebAccessibilityObject::hasComputedStyle):
(WebKit::WebAccessibilityObject::computedStyleDisplay):
(WebKit::WebAccessibilityObject::accessibilityIsIgnored):
(WebKit::WebAccessibilityObject::lineBreaks):
(WebKit::WebAccessibilityObject::columnCount):
(WebKit::WebAccessibilityObject::rowCount):

LayoutTests: AX: Chromium WebAccessibilityObject should check if an AccessibilityObject is detached
​https://bugs.webkit.org/show_bug.cgi?id=87778

Patch by Dominic Mazzoni <​dmazzoni@google.com> on 2012-05-30
Reviewed by Adam Barth.

  • accessibility/accessibility-object-detached-expected.txt: Added.
  • accessibility/accessibility-object-detached.html: Added.
6:03 PM Changeset in webkit [119011] by kevino@webkit.org
  • 2 edits in trunk/Tools

[wx] Unreviewed build fix. Fix 2.9 issues with c_str() type errors by using the wx fprintf wrapper.

6:01 PM Changeset in webkit [119010] by ojan@chromium.org
  • 3 edits in trunk/Websites/bugs.webkit.org

Only include the image checksum error in pretty-diffs for -expected.png files.
​https://bugs.webkit.org/show_bug.cgi?id=87881

Reviewed by Tony Chang.

  • PrettyPatch/PrettyPatch.rb:
  • PrettyPatch/PrettyPatch_test.rb:
5:49 PM Changeset in webkit [119009] by jberlin@webkit.org
  • 2 edits in trunk/LayoutTests

Enhance Windows DRT implementation to support platform scroll wheel events
​https://bugs.webkit.org/show_bug.cgi?id=36002

Skip more tests that use eventSender.mouseScrollBy on Windows.

  • platform/win/Skipped:
5:48 PM Changeset in webkit [119008] by shawnsingh@chromium.org
  • 5 edits in trunk/Source

Simplify TransformationMatrix rotation code to improve precision
​https://bugs.webkit.org/show_bug.cgi?id=86666

Reviewed by Adrienne Walker.

Source/WebCore:

Change covered by existing layout tests;
Additional unit tests added.

The original rotation code for WebCore::TransformationMatrix was
using indirect trig identities to compute basic rotation
matrices. As far as I can imagine, this is unnecessary, and brief
informal experiments showed that we can gain a few extra bits of
precision by avoiding that indirection.

Indeed, precision improved such that it revealed a mistake on one
of the unit tests, where the test was actually degenerate so that
the layer was aligned with a viewport boundary. When it was
imprecise, it didnt appear to be aligned. Putting an additional
translation on that test fixes it so it is no longer a degenerate
test.

This patch also revealed a few chinks in the unit testing armor of
this code, an error that should have been caught in unit tests was
luckily caught by SVG layout tests. This chink is fixed by adding
2 extra unit tests.

  • platform/graphics/transforms/TransformationMatrix.cpp:

(WebCore::TransformationMatrix::rotate3d):

Source/WebKit/chromium:

  • tests/CCLayerTreeHostCommonTest.cpp:

(WebKitTests::TEST):

  • tests/WebTransformationMatrixTest.cpp:

(WebKit::TEST):
(WebKit):

5:47 PM Changeset in webkit [119007] by timothy_horton@apple.com
  • 2 edits in trunk/LayoutTests

WebKitTestRunner needs an implementation of eventSender
<​https://bugs.webkit.org/show_bug.cgi?id=42194>

Unreviewed mac-wk2 skip of fast/forms/file/input-file-write-files.html, which depends on eventSender.

  • platform/mac-wk2/Skipped:
5:46 PM Changeset in webkit [119006] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebCore

IndexedDB: Remove old get/getKey implementations
​https://bugs.webkit.org/show_bug.cgi?id=87879

Patch by Alec Flett <​alecflett@chromium.org> on 2012-05-30
Reviewed by Ojan Vafai.

Removal of dead code, was scaffolding for a complicated
Chromium landing.

  • Modules/indexeddb/IDBIndexBackendImpl.cpp:

(WebCore::IDBIndexBackendImpl::getInternal):
(WebCore::IDBIndexBackendImpl::getKeyInternal):
(WebCore::IDBIndexBackendImpl::get):
(WebCore::IDBIndexBackendImpl::getKey):

  • Modules/indexeddb/IDBIndexBackendImpl.h:

(IDBIndexBackendImpl):

  • Modules/indexeddb/IDBObjectStoreBackendImpl.cpp:

(WebCore::IDBObjectStoreBackendImpl::get):
(WebCore::IDBObjectStoreBackendImpl::getInternal):

  • Modules/indexeddb/IDBObjectStoreBackendImpl.h:

(IDBObjectStoreBackendImpl):

5:39 PM Changeset in webkit [119005] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[BlackBerry] Fix assertion fail on redirect due to multiple jobs per handle
​https://bugs.webkit.org/show_bug.cgi?id=87579

Patch by Joe Mason <​jmason@rim.com> on 2012-05-30
Reviewed by George Staikos.

RIM PR #158892:

When we start a redirect, we now call cancelJob instead of just deleting it immediately to make sure
that all cleanup is performed. However, we also reassign the ResourceHandle to the new job, and
since cancelJob is asynchronous it is now assigned to two jobs simultaneously.

Work around this by only returning handles that have not been cancelled from findJobForHandle.
Cancelled jobs still technically exist in the jobs list, but they're invisible to callers. This is
safe because there is literally nothing that can be done with a cancelled job - it is supposed to
merely consume any notifications that are already in progress and then kill itself off - so no
callers of findJobForHandle are expecting a cancelled job. (All existing callers call methods on the
returned job which are no-ops for cancelled jobs, so there is no behaviour change.)

No new tests because there is no behaviour change (fixes a regression).

  • platform/network/blackberry/NetworkManager.cpp:

(WebCore::NetworkManager::findJobForHandle):

5:30 PM Changeset in webkit [119004] by haraken@chromium.org
  • 4 edits in trunk/Source/WebCore

[V8][Performance] Optimize DOM attribute getters that return an empty string
​https://bugs.webkit.org/show_bug.cgi?id=87820

Reviewed by Adam Barth.

This patch optimizes the performance of DOM attribute getters that return an
empty string by 65.8% (e.g. div.id, div.className, div.title, div.lang ...etc)

Performance test: Bindings/undefined-id-getter.html

[Without the patch]
RESULT Bindings: undefined-id-getter= 441.984669644 runs/s
median= 445.544554455 runs/s, stdev= 11.8406070959 runs/s, min= 405.063291139 runs/s, max= 447.204968944 runs/s

[With the patch]
RESULT Bindings: undefined-id-getter= 738.840460474 runs/s
median= 738.786279683 runs/s, stdev= 2.00249797161 runs/s, min= 733.944954128 runs/s, max= 741.721854305 runs/s

  • This patch passes Isolate to v8::String::Empty(), which removes Isolate

look-up inside v8::String::Empty().

  • This patch inlines V8Binding::getElementStringAttr() and

V8Binding::setElementStringAttr().

No tests. No change in behavior.

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateNormalAttrGetter):
(GenerateNormalAttrSetter):

  • bindings/v8/V8Binding.cpp:

(WebCore::StringCache::v8ExternalStringSlow):

  • bindings/v8/V8Binding.h:

(WebCore::StringCache::v8ExternalString):
(StringCache):
(WebCore::v8ExternalString):
(WebCore):

5:28 PM Changeset in webkit [119003] by haraken@chromium.org
  • 5 edits in trunk/Source/WebCore

[V8] Implement V8Binding::v8BooleanWithCheck(isolate)
​https://bugs.webkit.org/show_bug.cgi?id=87814

Reviewed by Adam Barth.

The objective is to pass Isolate to v8::True() and v8::False().
Similarly to v8NullWithCheck() (bug 87713), this patch implements
V8Binding::v8BooleanWithCheck(isolate), which calls v8::True()/v8::False()
or v8::True(isolate)/v8::False(isolate) depending on whether the
passed isolate is null or not.

This patch also passes Isolate to v8Boolean() in CodeGeneratorV8.pm.

No tests. No behavior change.

  • bindings/scripts/CodeGeneratorV8.pm:

(NativeToJSValue):

  • bindings/scripts/test/V8/V8TestEventTarget.cpp:

(WebCore::TestEventTargetV8Internal::dispatchEventCallback):

  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::TestObjV8Internal::createAttrGetter):
(WebCore::TestObjV8Internal::reflectedBooleanAttrAttrGetter):
(WebCore::TestObjV8Internal::reflectedCustomBooleanAttrAttrGetter):

  • bindings/v8/V8Binding.h:

(WebCore::v8Boolean):
(WebCore):
(WebCore::v8BooleanWithCheck):

5:16 PM Changeset in webkit [119002] by haraken@chromium.org
  • 7 edits in trunk/Source/WebCore

[V8] Replace v8::True() and v8::False() with v8Boolean()
​https://bugs.webkit.org/show_bug.cgi?id=87812

Reviewed by Adam Barth.

To avoid implementing all of v8TrueWithCheck(isolate), v8FalseWithCheck(isolate)
and v8BooleanWithCheck(isolate), we can first replace v8::True() and v8::False()
with v8Boolean(). Then we can just implement v8BooleanWithCheck(isolate).

No tests. No change in behavior.

  • bindings/v8/SerializedScriptValue.cpp:
  • bindings/v8/V8Binding.h:

(WebCore::v8StringOrFalse):

  • bindings/v8/V8NPUtils.cpp:

(WebCore::convertNPVariantToV8Object):

  • bindings/v8/custom/V8DOMStringMapCustom.cpp:

(WebCore::V8DOMStringMap::namedPropertyDeleter):

  • bindings/v8/custom/V8InjectedScriptHostCustom.cpp:

(WebCore::V8InjectedScriptHost::isHTMLAllCollectionCallback):

  • bindings/v8/custom/V8StorageCustom.cpp:

(WebCore::storageDeleter):

5:13 PM Changeset in webkit [119001] by haraken@chromium.org
  • 37 edits in trunk/Source/WebCore

[V8] Replace v8::Null() with v8NullWithCheck(isolate) in custom bindings where isolate can be 0
​https://bugs.webkit.org/show_bug.cgi?id=87807

Reviewed by Adam Barth.

The objective is to pass Isolate around in V8 bindings.
This patch replaces v8::Null() with v8NullWithCheck(isolate)
in custom bindings where isolate can be 0.

'where isolate can be 0' means all the places where we cannot
retrieve Isolate directly from AccessorInfo or Arguments.

No tests. No behavior change.

  • bindings/v8/custom/V8BlobCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8CSSRuleCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8CSSStyleSheetCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8CSSValueCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8DOMStringMapCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8DOMTokenListCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8DOMWindowCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8DataViewCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8DocumentCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8EntryCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8EntrySyncCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8EventCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8Float32ArrayCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8Float64ArrayCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8HTMLDocumentCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8HTMLElementCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8IDBAnyCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8IDBKeyCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8ImageDataCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8Int16ArrayCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8Int32ArrayCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8Int8ArrayCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8LocationCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8NamedNodeMapCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8NodeCustom.cpp:

(WebCore::toV8Slow):

  • bindings/v8/custom/V8SVGDocumentCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8SVGElementCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8SVGPathSegCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8ScriptProfileCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8ScriptProfileNodeCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8StyleSheetCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8Uint16ArrayCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8Uint32ArrayCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8Uint8ArrayCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8Uint8ClampedArrayCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8WorkerContextCustom.cpp:

(WebCore::toV8):

5:12 PM Changeset in webkit [119000] by jberlin@webkit.org
  • 4 edits
    5 adds in trunk/LayoutTests

[Win] 8 accessibility tests failing
​https://bugs.webkit.org/show_bug.cgi?id=87909

Add expected (failing?) results for Windows to get the bots greener.

  • platform/win/accessibility/deleting-iframe-destroys-axcache-expected.txt: Added.
  • platform/win/accessibility/disabled-controls-not-focusable-expected.txt: Added.
  • platform/win/accessibility/focus-events-expected.txt:
  • platform/win/accessibility/img-alt-tag-only-whitespace-expected.txt: Added.
  • platform/win/accessibility/option-element-selection-and-focus-events-expected.txt:
  • platform/win/accessibility/select-element-valuechange-event-expected.txt:
  • platform/win/accessibility/textbox-role-reports-line-number-expected.txt: Added.
  • platform/win/accessibility/textbox-role-reports-selection-expected.txt: Added.
5:11 PM Changeset in webkit [118999] by haraken@chromium.org
  • 6 edits in trunk/Source/WebCore

[V8] Replace v8::Null() with v8::Null(isolate) or v8NullWithCheck(isolate) in non-custom bindings
​https://bugs.webkit.org/show_bug.cgi?id=87810

Reviewed by Adam Barth.

The objective is to pass Isolate around in V8 bindings.
For non-custom bindings, we replace v8::Null() with v8::Null(isolate)
where isolate cannot be 0, and replace v8::Null() with v8NullWithCheck(isolate)
where isolate can be 0.

This will be the final patch for passing Isolate to v8::Null().

No tests. No change in behavior.

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateNormalAttrGetter):
(GenerateFunctionCallback):

  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::TestObjV8Internal::contentDocumentAttrGetter):
(WebCore::TestObjV8Internal::getSVGDocumentCallback):

  • bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:

(WebCore::TestSerializedScriptValueInterfaceV8Internal::cachedValueAttrGetter):
(WebCore::TestSerializedScriptValueInterfaceV8Internal::cachedReadonlyValueAttrGetter):

  • bindings/v8/SerializedScriptValue.cpp:

(WebCore::SerializedScriptValue::deserialize):

  • bindings/v8/V8DOMWrapper.cpp:

(WebCore::V8DOMWrapper::convertEventTargetToV8Object):

5:02 PM Changeset in webkit [118998] by haraken@chromium.org
  • 15 edits in trunk/Source/WebCore

[V8] Replace v8::Null() with v8::Null(isolate) in custom bindings where isolate shouldn't be 0
​https://bugs.webkit.org/show_bug.cgi?id=87809

Reviewed by Adam Barth.

The objective is to pass Isolate around in V8 bindings.
This patch replaces v8::Null() with v8::Null(isolate) in custom bindings
where isolate shouldn't be 0. 'where isolate shouldn't be 0' is the place
where isolate is retrieved directly from AccessorInfo and Arguments.

This patch includes a couple of refactorings:

  • Makes V8DeviceMotionEvent::createAccelerationObject() and

V8DeviceMotionEvent::createRotationRateObject() static

  • Moves V8HTMLElement::toV8Object() into the existing ENABLE(MICRODATA) flag.

No tests. No change in behavior.

  • bindings/v8/custom/V8ClipboardCustom.cpp:

(WebCore::V8Clipboard::typesAccessorGetter):

  • bindings/v8/custom/V8CoordinatesCustom.cpp:

(WebCore::V8Coordinates::altitudeAccessorGetter):
(WebCore::V8Coordinates::altitudeAccuracyAccessorGetter):
(WebCore::V8Coordinates::headingAccessorGetter):
(WebCore::V8Coordinates::speedAccessorGetter):

  • bindings/v8/custom/V8DeviceMotionEventCustom.cpp:

(WebCore::V8DeviceMotionEvent::accelerationAccessorGetter):
(WebCore::V8DeviceMotionEvent::accelerationIncludingGravityAccessorGetter):
(WebCore::V8DeviceMotionEvent::rotationRateAccessorGetter):
(WebCore::V8DeviceMotionEvent::intervalAccessorGetter):

  • bindings/v8/custom/V8DeviceOrientationEventCustom.cpp:

(WebCore::V8DeviceOrientationEvent::alphaAccessorGetter):
(WebCore::V8DeviceOrientationEvent::betaAccessorGetter):
(WebCore::V8DeviceOrientationEvent::gammaAccessorGetter):
(WebCore::V8DeviceOrientationEvent::absoluteAccessorGetter):

  • bindings/v8/custom/V8DocumentLocationCustom.cpp:

(WebCore::V8Document::locationAccessorGetter):

  • bindings/v8/custom/V8HTMLCanvasElementCustom.cpp:

(WebCore::V8HTMLCanvasElement::getContextCallback):

  • bindings/v8/custom/V8HTMLElementCustom.cpp:

(WebCore::toV8):
(WebCore):
(WebCore::toV8Object):

  • bindings/v8/custom/V8HistoryCustom.cpp:

(WebCore::V8History::stateAccessorGetter):

  • bindings/v8/custom/V8MessageEventCustom.cpp:

(WebCore::V8MessageEvent::dataAccessorGetter):

  • bindings/v8/custom/V8NodeCustom.cpp:

(WebCore::V8Node::insertBeforeCallback):
(WebCore::V8Node::replaceChildCallback):
(WebCore::V8Node::removeChildCallback):
(WebCore::V8Node::appendChildCallback):

  • bindings/v8/custom/V8PopStateEventCustom.cpp:

(WebCore::V8PopStateEvent::stateAccessorGetter):

  • bindings/v8/custom/V8SQLResultSetRowListCustom.cpp:

(WebCore::V8SQLResultSetRowList::itemCallback):

  • bindings/v8/custom/V8TrackEventCustom.cpp:

(WebCore::V8TrackEvent::trackAccessorGetter):

  • bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:

(WebCore::toV8Object):
(WebCore::V8WebGLRenderingContext::getAttachedShadersCallback):
(WebCore::V8WebGLRenderingContext::getSupportedExtensionsCallback):

4:56 PM Changeset in webkit [118997] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[Qt] handled touchmove events should not cancel tap gesture recognition
​https://bugs.webkit.org/show_bug.cgi?id=87808

Patch by Luiz Agostini <​luiz.agostini@nokia.com> on 2012-05-30
Reviewed by Kenneth Rohde Christiansen.

Tap gesture recognition should not be canceled if a touchmove event is handled
by the web process.

  • UIProcess/qt/QtWebPageEventHandler.cpp:

(WebKit::QtWebPageEventHandler::doneWithTouchEvent):

4:55 PM Changeset in webkit [118996] by ojan@chromium.org
  • 3 edits in trunk/Tools

Only give lint errors for -expected.png png files that lack a checksum
​https://bugs.webkit.org/show_bug.cgi?id=87875

Reviewed by Tony Chang.

We have other pngs in the tree, e.g. for the inspector, that legitimately
lack a checksum.

  • Scripts/webkitpy/style/checkers/png.py:

(PNGChecker.check):

  • Scripts/webkitpy/style/checkers/png_unittest.py:

(PNGCheckerTest.test_check):

4:47 PM Changeset in webkit [118995] by oliver@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Really provide error information with the inspector disabled
​https://bugs.webkit.org/show_bug.cgi?id=87910

Reviewed by Filip Pizlo.

Don't bother checking for anything other than pre-existing error info.
In the absence of complete line number information you'll only get the
line a function starts on, but at least it's something.

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::throwException):

4:35 PM Changeset in webkit [118994] by eae@chromium.org
  • 6 edits in trunk/LayoutTests

Unreviewed test expectations updates for window and mac now that we no longer skip a couple of tests on those platforms.

  • platform/chromium-mac-leopard/fast/backgrounds/background-position-parsing-expected.png:
  • platform/chromium-win/fast/backgrounds/background-position-parsing-expected.png:
  • platform/chromium-win/fast/backgrounds/background-position-parsing-expected.txt:
  • platform/chromium-win/fast/block/margin-collapse/103-expected.png:
  • platform/chromium-win/fast/block/margin-collapse/103-expected.txt:
4:10 PM Changeset in webkit [118993] by thakis@chromium.org
  • 9 edits
    2 adds in trunk

Make the files attribute of HTMLInputElement writable
​https://bugs.webkit.org/show_bug.cgi?id=87154

Reviewed by Adam Barth.

whatwg thread:
​http://lists.whatwg.org/htdig.cgi/whatwg-whatwg.org/2012-May/036140.html

  • bindings/objc/PublicDOMInterfaces.h:

Remove readonly on files property.

  • html/FileInputType.cpp:

(FileInputType):

Add a NULL check to setFiles().

  • html/FileInputType.h:

(FileInputType):

Let setFiles() overwrite the base class's method.

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::setFiles):

Add setFiles() implementation, delegate to input type.

  • html/HTMLInputElement.h:

(HTMLInputElement):

  • html/HTMLInputElement.idl:
  • html/InputType.cpp:

(WebCore::InputType::setFiles):

setFiles() does nothing by default.

  • html/InputType.h:

(InputType):

Add a virtual setFiles() method.

4:09 PM Changeset in webkit [118992] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

LLInt broken on x86-32 with JIT turned off
​https://bugs.webkit.org/show_bug.cgi?id=87906

Reviewed by Geoffrey Garen.

Fixed the code to not clobber registers that contain important things, like the call frame.

  • llint/LowLevelInterpreter32_64.asm:
4:07 PM Changeset in webkit [118991] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[BlackBerry] Remove useless string->char*->string conversion in NetworkJob.
​https://bugs.webkit.org/show_bug.cgi?id=87861

Patch by Joe Mason <​jmason@rim.com> on 2012-05-30
Reviewed by Antonio Gomes.

RIM PR #152383: username is a WTF::String. ResourceHandleInternal::m_user is a string. Yet they're
assigned with "username = m_user.utf8().data()". Pointless: "username = m_user" will do.

No new tests since there is no behaviour change.

  • platform/network/blackberry/NetworkJob.cpp:

(WebCore::NetworkJob::sendRequestWithCredentials):

3:58 PM Changeset in webkit [118990] by mitz@apple.com
  • 4 edits in trunk

[Qt] REGRESSION(r118568): It broke fast/forms/textarea-maxlength.html on Qt 4.8
​https://bugs.webkit.org/show_bug.cgi?id=87740

Reviewed by Darin Adler.

Source/WebCore:

  • platform/text/qt/TextBreakIteratorQt.cpp:

(WebCore::NonSharedCharacterBreakIterator::NonSharedCharacterBreakIterator): Changed to use
the return value of setUpIterator.

LayoutTests:

  • platform/qt-4.8/Skipped: Removed fast/forms/textarea-maxlength.html.
3:50 PM Changeset in webkit [118989] by rakuco@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Gardening. Unskip test that is now passing.

  • platform/efl/test_expectations.txt:
3:49 PM Changeset in webkit [118988] by eae@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed chromium snowleopard rebaseline for background-position-parsing test following r118978.

  • platform/chromium-mac-snowleopard/fast/backgrounds/background-position-parsing-expected.png:
3:43 PM Changeset in webkit [118987] by zeno.albisser@nokia.com
  • 4 edits in trunk/Source/WebCore

GraphicsSurface: allow importing and exporting of textures directly on GPU side.
​https://bugs.webkit.org/show_bug.cgi?id=87725

Add copyFromFramebuffer function to copy a texture from an FBO
onto the GraphicsSurface.
Add getTextureID function to export the texture ID.
This allows binding/blitting the texture directly on the GPU.

Reviewed by Noam Rosenthal.

  • platform/graphics/surfaces/GraphicsSurface.cpp:

(WebCore::GraphicsSurface::getTextureID):
(WebCore):
(WebCore::GraphicsSurface::copyFromFramebuffer):

  • platform/graphics/surfaces/GraphicsSurface.h:

(GraphicsSurface):

  • platform/graphics/surfaces/mac/GraphicsSurfaceMac.cpp:

(WebCore::GraphicsSurface::platformGetTextureID):
(WebCore):
(WebCore::GraphicsSurface::platformCopyFromFramebuffer):

3:39 PM Changeset in webkit [118986] by commit-queue@webkit.org
  • 77 edits in trunk

IndexedDB: Implement IDBTransaction.error and IDBRequest.error
​https://bugs.webkit.org/show_bug.cgi?id=87865

Patch by Alec Flett <​alecflett@chromium.org> on 2012-05-30
Reviewed by Tony Chang.

Source/WebCore:

Added "error" attribute to IDBRequest and IDBTransaction. Update
IDBDatabaseError to honor the IDBDatabaseException behavior
of dealing with IDB-specific throws of DOMException codes,
as per the spec.

Existing tests which previously tested 'errorCode' and
'webkitErrorMessage' have been updated to use the new attribute.

  • Modules/indexeddb/IDBCursor.cpp:

(WebCore::IDBCursor::advance):

  • Modules/indexeddb/IDBDatabaseBackendImpl.cpp:

(WebCore::IDBDatabaseBackendImpl::setVersion):

  • Modules/indexeddb/IDBDatabaseError.h:

(WebCore::IDBDatabaseError::create):
(WebCore::IDBDatabaseError::code):
(WebCore::IDBDatabaseError::idbCode):
(WebCore::IDBDatabaseError::name):
(WebCore::IDBDatabaseError::IDBDatabaseError):
(IDBDatabaseError):

  • Modules/indexeddb/IDBDatabaseException.cpp:

(WebCore):
(WebCore::getErrorEntry):
(WebCore::IDBDatabaseException::initializeDescription):
(WebCore::IDBDatabaseException::getErrorName):
(WebCore::IDBDatabaseException::getLegacyErrorCode):

  • Modules/indexeddb/IDBDatabaseException.h:

(IDBDatabaseException):

  • Modules/indexeddb/IDBObjectStore.cpp:

(WebCore::IDBObjectStore::createIndex):

  • Modules/indexeddb/IDBRequest.cpp:

(WebCore::IDBRequest::error):
(WebCore):
(WebCore::IDBRequest::resetReadyState):
(WebCore::IDBRequest::abort):
(WebCore::IDBRequest::onError):
(WebCore::IDBRequest::onSuccess):
(WebCore::IDBRequest::onSuccessWithContinuation):
(WebCore::IDBRequest::dispatchEvent):

  • Modules/indexeddb/IDBRequest.h:

(IDBRequest):

  • Modules/indexeddb/IDBRequest.idl:
  • Modules/indexeddb/IDBTransaction.cpp:

(WebCore::IDBTransaction::error):
(WebCore):
(WebCore::IDBTransaction::setError):

  • Modules/indexeddb/IDBTransaction.h:

(IDBTransaction):

  • Modules/indexeddb/IDBTransaction.idl:

Source/WebKit/chromium:

IDBDatabaseError now honors IDB-specific DOMException codes,
so make sure that's how they are passed to/from chromium.

  • src/WebIDBDatabaseError.cpp:

(WebKit::WebIDBDatabaseError::assign):

LayoutTests:

  • storage/indexeddb/basics-expected.txt:
  • storage/indexeddb/basics-workers-expected.txt:
  • storage/indexeddb/create-and-remove-object-store-expected.txt:
  • storage/indexeddb/cursor-continue-expected.txt:
  • storage/indexeddb/cursor-update-expected.txt:
  • storage/indexeddb/database-basics-expected.txt:
  • storage/indexeddb/deleteIndex-expected.txt:
  • storage/indexeddb/factory-cmp-expected.txt:
  • storage/indexeddb/get-keyrange-expected.txt:
  • storage/indexeddb/index-basics-expected.txt:
  • storage/indexeddb/index-basics-workers-expected.txt:
  • storage/indexeddb/index-count-expected.txt:
  • storage/indexeddb/index-unique-expected.txt:
  • storage/indexeddb/invalid-keys-expected.txt:
  • storage/indexeddb/key-generator-expected.txt:
  • storage/indexeddb/key-type-array-expected.txt:
  • storage/indexeddb/keypath-edges-expected.txt:
  • storage/indexeddb/keyrange-expected.txt:
  • storage/indexeddb/objectstore-autoincrement-expected.txt:
  • storage/indexeddb/objectstore-basics-expected.txt:
  • storage/indexeddb/objectstore-basics-workers-expected.txt:
  • storage/indexeddb/objectstore-count-expected.txt:
  • storage/indexeddb/open-cursor-expected.txt:
  • storage/indexeddb/readonly-expected.txt:
  • storage/indexeddb/resources/basics.js:

(test):
(openCallback):

  • storage/indexeddb/resources/create-and-remove-object-store.js:

(testCreateAndRemove):
(cleanDatabase):
(tryOnceMore):

  • storage/indexeddb/resources/cursor-continue.js:

(ascendingErrorTestLessThan.request.onsuccess):
(ascendingErrorTestLessThan):
(ascendingErrorTestEqual.request.onsuccess):
(ascendingErrorTestEqual):
(descendingErrorTestGreaterThan.request.onsuccess):
(descendingErrorTestGreaterThan):
(descendingErrorTestEqual.request.onsuccess):
(descendingErrorTestEqual):
(onTransactionComplete):

  • storage/indexeddb/resources/cursor-update.js:

(keyCursor):

  • storage/indexeddb/resources/database-basics.js:

(testClose):

  • storage/indexeddb/resources/database-quota.js:

(logError):

  • storage/indexeddb/resources/deleteIndex.js:

(twiddleIndexes):
(postTwiddling):

  • storage/indexeddb/resources/factory-cmp.js:

(testValidKeys):
(testInvalidKeys):

  • storage/indexeddb/resources/get-keyrange.js:

(getNullTest):

  • storage/indexeddb/resources/index-basics.js:

(index3Count):

  • storage/indexeddb/resources/index-count.js:
  • storage/indexeddb/resources/index-unique.js:

(addMoreDataFailed):

  • storage/indexeddb/resources/invalid-keys.js:
  • storage/indexeddb/resources/key-generator.js:
  • storage/indexeddb/resources/key-type-array.js:

(testDepthLimits):

  • storage/indexeddb/resources/keypath-edges.js:
  • storage/indexeddb/resources/keyrange.js:

(test):

  • storage/indexeddb/resources/objectstore-autoincrement.js:

(getAbrahamSuccess):

  • storage/indexeddb/resources/objectstore-basics.js:

(setVersionSuccess):
(createIndex):
(addAgainFailure):
(removeSuccessButNotThere):
(testPreConditions.request.onsuccess):
(testPreConditions):

  • storage/indexeddb/resources/objectstore-count.js:
  • storage/indexeddb/resources/open-cursor.js:

(cursorWithKeySuccess):
(cursorSuccess):

  • storage/indexeddb/resources/readonly.js:

(openSuccess):

  • storage/indexeddb/resources/set_version_queue.js:

(connectionError):

  • storage/indexeddb/resources/shared.js:

(unexpectedErrorCallback):
(evalAndExpectException):

  • storage/indexeddb/resources/transaction-abort-workers.js:

(transactionAborted):
(transactionCompleted):
(timeoutTest.transaction.onabort):
(timeoutTest):
(errorTransactionAborted):

  • storage/indexeddb/resources/transaction-abort.js:

(firstAdd):
(secondAdd):
(transactionAborted):

  • storage/indexeddb/resources/transaction-after-close.js:

(firstTransactionComplete):

  • storage/indexeddb/resources/transaction-and-objectstore-calls.js:

(created):
(afterComplete):

  • storage/indexeddb/resources/transaction-basics.js:

(testInactiveAbortedTransaction):
(testInactiveCompletedTransaction):
(testInvalidMode):

  • storage/indexeddb/resources/transaction-read-only.js:

(setVersionDone):
(gotCursor):

  • storage/indexeddb/set_version_queue-expected.txt:
  • storage/indexeddb/transaction-abort-expected.txt:
  • storage/indexeddb/transaction-abort-workers-expected.txt:
  • storage/indexeddb/transaction-after-close-expected.txt:
  • storage/indexeddb/transaction-and-objectstore-calls-expected.txt:
  • storage/indexeddb/transaction-basics-expected.txt:
  • storage/indexeddb/transaction-read-only-expected.txt:
3:37 PM Changeset in webkit [118985] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[GTK][WK2] Errors in documentation about webkit_web_view_run_javascript()
​https://bugs.webkit.org/show_bug.cgi?id=87866

Patch by Mario Sanchez Prada <​msanchez@igalia.com> on 2012-05-30
Reviewed by Martin Robinson.

  • UIProcess/API/gtk/WebKitWebView.cpp: Fix errors.
3:29 PM Changeset in webkit [118984] by eae@chromium.org
  • 7 edits in trunk/LayoutTests

Unreviewed chromium mac rebaseline for changes in r118978.

  • platform/chromium-mac/fast/backgrounds/background-position-parsing-expected.png:
  • platform/chromium-mac/fast/backgrounds/background-position-parsing-expected.txt:
  • platform/chromium-mac/fast/multicol/span/span-as-immediate-columns-child-expected.png:
  • platform/chromium-mac/fast/multicol/span/span-as-immediate-columns-child-expected.txt:
  • platform/chromium/test_expectations.txt:
3:29 PM Changeset in webkit [118983] by Lucas Forschler
  • 5 edits in branches/safari-534.57-branch/Source

Versioning.

3:21 PM Changeset in webkit [118982] by Lucas Forschler
  • 1 copy in tags/Safari-534.57.5

New tag.

3:18 PM Changeset in webkit [118981] by Lucas Forschler
  • 2 edits in branches/safari-534.57-branch/Source/WebCore

Merged r108550.

3:08 PM Changeset in webkit [118980] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[Qt] ImageDecoderQt doesn't support some decoders.
​https://bugs.webkit.org/show_bug.cgi?id=87851

Patch by Allan Sandfeld Jensen <​allan.jensen@nokia.com> on 2012-05-30
Reviewed by Kenneth Rohde Christiansen.

If forced to decode GIF and JPEG, ImageDecoderQt show several
artifacts. This is caused by mismatched decoded image-formats.

Convert mismatched color spaces into ARGB color space, and perform
manual mem-copy when the image has been decoded into a new buffer.

This patch also add support for down-scaling in the decoder.

  • platform/graphics/qt/ImageDecoderQt.cpp:

(WebCore::ImageDecoderQt::internalDecodeSize):
(WebCore::ImageDecoderQt::internalHandleCurrentImage):

2:58 PM Changeset in webkit [118979] by dpranke@chromium.org
  • 4 edits in trunk/Tools

nrwt: seems to leak temp dirs
​https://bugs.webkit.org/show_bug.cgi?id=87795

Reviewed by Ojan Vafai.

There appears to be a bug where the chromium bots are creating
temporary directories and not cleaning them up that started
after the switch to WebKitDriver. It's possible that del
wasn't getting called in a timely manner (or at all), and it's
generally bad style to rely on del being called, so this
code changes things so that we create a temp dir in
driver.start() and remove it in driver.stop(). We could be
paranoid and leave the del code in, but there doesn't seem
to be much advantage to it. If there are bugs that result in
drivers being started but not stopped, we have other problems.

  • Scripts/webkitpy/common/system/filesystem_mock.py:

(MockFileSystem.init):
(MockFileSystem._mktemp):
(MockFileSystem.mkdtemp):

  • Scripts/webkitpy/layout_tests/port/webkit.py:

(WebKitDriver.init):
(WebKitDriver._start):
(WebKitDriver.stop):

  • Scripts/webkitpy/layout_tests/port/webkit_unittest.py:

(WebKitDriverTest.test_check_for_driver_crash):
(WebKitDriverTest):
(WebKitDriverTest.test_creating_a_port_does_not_write_to_the_filesystem):
(WebKitDriverTest.test_stop_cleans_up_properly):

2:56 PM Changeset in webkit [118978] by eae@chromium.org
  • 20 edits
    2 adds in trunk

Floats wraps incorrectly when top edge has subpixel precision
​https://bugs.webkit.org/show_bug.cgi?id=87688

Reviewed by Levi Weintraub.

When computing the logical left and right offsets for a float we
incorrectly floored the logical top when passing it to the float search
adapter. This caused it to return incorrect values where the floored and
pixel snapped values are not the same.

Source/WebCore:

Test: fast/sub-pixel/float-wrap-with-subpixel-top.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::logicalLeftOffsetForLine):
(WebCore::RenderBlock::logicalRightOffsetForLine):

LayoutTests:

  • fast/sub-pixel/float-wrap-with-subpixel-top-expected.html: Added.
  • fast/sub-pixel/float-wrap-with-subpixel-top.html: Added.
  • platform/chromium-linux/fast/backgrounds/background-position-parsing-expected.png:
  • platform/chromium-linux/fast/backgrounds/background-position-parsing-expected.txt:
  • platform/chromium-win/fast/multicol/span/span-as-immediate-columns-child-expected.txt:
  • platform/chromium/test_expectations.txt:
  • platform/efl/Skipped:
  • platform/gtk-wk2/Skipped:
  • platform/mac-lion/Skipped:
  • platform/mac-snowleopard/Skipped:
  • platform/mac-wk2/Skipped:
  • platform/mac/Skipped:
  • platform/qt-4.8/Skipped:
  • platform/qt/Skipped:
  • platform/win-wk2/Skipped:
  • platform/win-xp/Skipped:
  • platform/win/Skipped:
  • platform/wincairo/Skipped:
  • platform/wk2/Skipped:
2:44 PM Changeset in webkit [118977] by rakuco@webkit.org
  • 9 edits in trunk

[EFL] EFL's DRT should print the number of MessagePorts for new each new intent
​https://bugs.webkit.org/show_bug.cgi?id=86841

Patch by Christophe Dumez <Christophe Dumez> on 2012-05-30
Reviewed by Adam Barth.

Source/WebKit/efl:

Add EWKPrivate method to retrieve the internal WebCore object for a Ewk_Intent.
Add helper function to DumpRenderTreeSupportEfl that returns the MessagePorts
for a Ewk_Intent object so that the DRT can print information about them.

  • WebCoreSupport/DumpRenderTreeSupportEfl.cpp:

(DumpRenderTreeSupportEfl::intentMessagePorts):

  • WebCoreSupport/DumpRenderTreeSupportEfl.h:

(WebCore):

  • ewk/ewk_intent.cpp:

(EWKPrivate):
(EWKPrivate::coreIntent):

  • ewk/ewk_intent_private.h:

(EWKPrivate):

Tools:

Print the number of MessagePorts for each new intent in EFL's DRT.
This output is expected by several Web Intents test cases.

  • DumpRenderTree/efl/DumpRenderTreeChrome.cpp:

(DumpRenderTreeChrome::onFrameIntentNew):

LayoutTests:

Unskip the test case which requires the DumpRenderTree to print out
the number of MessagePorts for each new intent.

  • platform/efl/test_expectations.txt:
2:42 PM Changeset in webkit [118976] by caio.oliveira@openbossa.org
  • 2 edits in trunk/Source/WTF

HashTable.h has using directives for std::pair and std::make_pair
​https://bugs.webkit.org/show_bug.cgi?id=29919

Reviewed by Darin Adler.

  • wtf/HashTraits.h:

(WTF): Remove the directives.

2:42 PM Changeset in webkit [118975] by eae@chromium.org
  • 16 edits
    2 adds in trunk

Inline blocks with margin wrap incorrectly with subpixel layout turned on
​https://bugs.webkit.org/show_bug.cgi?id=87897

Reviewed by Levi Weintraub.

Source/WebCore:

Change WebCore::getBorderPaddingMargin and the helper function
getBPMWidth to return a LayoutUnit rather than an int as the padding and
margin values have subpixel precision. This fixes an issue where we would
incorrectly wrap inline blocks with a subpixel padding or margin.

Test: fast/sub-pixel/inline-block-with-margin.html

  • rendering/RenderBlock.cpp:

(WebCore::getBPMWidth):
(WebCore::getBorderPaddingMargin):
(WebCore::RenderBlock::computeInlinePreferredLogicalWidths):

LayoutTests:

Add test for inline blocks with a subpixel margin. Marked as skipped on
all platforms but chromium as subpixel layout has not yet been enabled
for any other platform.

  • fast/sub-pixel/inline-block-with-margin-expected.html: Added.
  • fast/sub-pixel/inline-block-with-margin.html: Added.
  • platform/efl/Skipped:
  • platform/gtk-wk2/Skipped:
  • platform/mac-lion/Skipped:
  • platform/mac-snowleopard/Skipped:
  • platform/mac-wk2/Skipped:
  • platform/mac/Skipped:
  • platform/qt-4.8/Skipped:
  • platform/qt/Skipped:
  • platform/win-wk2/Skipped:
  • platform/win-xp/Skipped:
  • platform/win/Skipped:
  • platform/wincairo/Skipped:
  • platform/wk2/Skipped:
2:35 PM Changeset in webkit [118974] by jberlin@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt][GTK][Mac][Win] New plugins/npruntime/delete-plugin-within-* tests introduced in r117012
fail/crash
​https://bugs.webkit.org/show_bug.cgi?id=86443

Skip these tests on Windows because they crash.

  • platform/win/Skipped:
2:23 PM Changeset in webkit [118973] by rakuco@webkit.org
  • 17 edits in trunk/LayoutTests

[EFL] Unreviewed gardening in fast/transforms.

Unskip passing tests that just needed baselines and update the
PNGs for a few ones which were already passing.

  • platform/efl/Skipped:
  • platform/efl/fast/transforms/bounding-rect-zoom-expected.png:
  • platform/efl/fast/transforms/diamond-expected.png:
  • platform/efl/fast/transforms/identity-matrix-expected.png:
  • platform/efl/fast/transforms/overflow-with-transform-expected.png:
  • platform/efl/fast/transforms/rotated-transform-affects-scrolling-1-expected.png:
  • platform/efl/fast/transforms/rotated-transform-affects-scrolling-2-expected.png:
  • platform/efl/fast/transforms/skew-with-unitless-zero-expected.png:
  • platform/efl/fast/transforms/transform-on-inline-expected.png:
  • platform/efl/fast/transforms/transform-positioned-ancestor-expected.png:
  • platform/efl/fast/transforms/transform-table-row-expected.png:
  • platform/efl/fast/transforms/transformed-caret-expected.png:
  • platform/efl/fast/transforms/transformed-caret-expected.txt:
  • platform/efl/fast/transforms/transformed-focused-text-input-expected.png:
  • platform/efl/fast/transforms/transformed-focused-text-input-expected.txt:
  • platform/efl/fast/transforms/transforms-with-opacity-expected.png:
2:22 PM Changeset in webkit [118972] by rakuco@webkit.org
  • 16 edits in trunk/LayoutTests

[EFL] Unreviewed gardening in fast/parser.

Unskip a passing test that just needed a baseline and update the
PNGs for a few ones which were already passing.

  • platform/efl/Skipped:
  • platform/efl/fast/parser/001-expected.png:
  • platform/efl/fast/parser/bad-xml-slash-expected.png:
  • platform/efl/fast/parser/broken-comments-vs-parsing-mode-expected.png:
  • platform/efl/fast/parser/document-write-option-expected.png:
  • platform/efl/fast/parser/entity-comment-in-style-expected.png:
  • platform/efl/fast/parser/entity-comment-in-style-expected.txt:
  • platform/efl/fast/parser/entity-comment-in-textarea-expected.png:
  • platform/efl/fast/parser/fonts-expected.png:
  • platform/efl/fast/parser/nofoo-tags-inside-paragraph-expected.png:
  • platform/efl/fast/parser/open-comment-in-style-expected.png:
  • platform/efl/fast/parser/open-comment-in-textarea-expected.png:
  • platform/efl/fast/parser/title-error-test-expected.png:
  • platform/efl/fast/parser/xhtml-alternate-entities-expected.png:
  • platform/efl/test_expectations.txt:
2:12 PM Changeset in webkit [118971] by tony@chromium.org
  • 18 edits in trunk

rename flexbox css values from justify and distribute to space-between and space-around
​https://bugs.webkit.org/show_bug.cgi?id=87867

Reviewed by Ojan Vafai.

Source/WebCore:

This was recently changed in the spec:
​http://dev.w3.org/csswg/css3-flexbox/#justify-content

No new tests, updated existing tests and expectations.

  • css/CSSParser.cpp:

(WebCore::isValidKeywordPropertyAndValue):

  • css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator EFlexPack):
(WebCore::CSSPrimitiveValue::operator EFlexLinePack):

  • css/CSSValueKeywords.in:
  • rendering/RenderFlexibleBox.cpp:

(WebCore::initialPackingOffset):
(WebCore::packingSpaceBetweenChildren):
(WebCore::initialLinePackingOffset):
(WebCore::linePackingSpaceBetweenChildren):

  • rendering/style/RenderStyleConstants.h:

LayoutTests:

  • css3/flexbox/columns-auto-size.html:
  • css3/flexbox/css-properties-expected.txt:
  • css3/flexbox/css-properties.html:
  • css3/flexbox/flex-pack.html:
  • css3/flexbox/multiline-line-pack-horizontal-column-expected.txt:
  • css3/flexbox/multiline-line-pack-horizontal-column.html:
  • css3/flexbox/multiline-line-pack.html:
  • css3/flexbox/multiline-pack-expected.txt:
  • css3/flexbox/multiline-pack.html:
  • css3/flexbox/position-absolute-child.html:
  • css3/flexbox/true-centering.html:
2:08 PM Changeset in webkit [118970] by kevino@webkit.org
  • 2 edits in trunk/Source/WebCore

[wx] Unreviewed build fix. Make sure we get the file size with the proper native type.

2:08 PM Changeset in webkit [118969] by rafaelw@chromium.org
  • 1 edit
    1 add in trunk/LayoutTests

[Chromium] rebaseline fast/dom/Window/mozilla-focus-blur.html

  • platform/chromium/fast/dom/Window/mozilla-focus-blur-expected.txt: Added.
2:06 PM Changeset in webkit [118968] by kevino@webkit.org
  • 2 edits in trunk/Tools

[wx] Unreviewed build fix after removal of setJavaScriptProfilingEnabled.

2:05 PM Changeset in webkit [118967] by kevino@webkit.org
  • 2 edits in trunk

[wx] Unreviewed build fix. Add needed file back to the wx build.

2:04 PM Changeset in webkit [118966] by fpizlo@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

ScriptDebugServer wants sourceIDs that are non-zero because that's what HashMaps want, so JSC should placate it
​https://bugs.webkit.org/show_bug.cgi?id=87887

Reviewed by Darin Adler.

Better fix - we now never call SourceProvider::asID() if SourceProvider* is 0.

  • parser/Nodes.h:

(JSC::ScopeNode::sourceID):

  • parser/SourceCode.h:

(JSC::SourceCode::providerID):
(SourceCode):

  • parser/SourceProvider.h:

(SourceProvider):
(JSC::SourceProvider::asID):

  • runtime/Executable.h:

(JSC::ScriptExecutable::sourceID):

2:01 PM Changeset in webkit [118965] by dmazzoni@google.com
  • 1 edit
    2 copies in branches/chromium/1132

Merge 117976 - Chromium AX: Crash when menulist adds selected option via document.write
​https://bugs.webkit.org/show_bug.cgi?id=87028

Reviewed by Chris Fleizach.

Source/WebCore:

Test: platform/chromium/accessibility/add-to-menu-list-crashes.html

  • rendering/RenderMenuList.cpp:

(WebCore::RenderMenuList::addChild):

LayoutTests:

  • platform/chromium/accessibility/add-to-menu-list-crashes-expected.txt: Added.
  • platform/chromium/accessibility/add-to-menu-list-crashes.html: Added.

TBR=​dmazzoni@google.com
Review URL: ​https://chromiumcodereview.appspot.com/10446087

1:52 PM Changeset in webkit [118964] by jberlin@webkit.org
  • 6 edits
    10 adds in trunk/LayoutTests

[Win] Many editing tests failing
​https://bugs.webkit.org/show_bug.cgi?id=87890

Add/updated expected (failing?) results for Windows editing tests.

  • platform/win/editing/deleting/delete-start-block-expected.txt: Added.
  • platform/win/editing/deleting/regional-indicators-expected.txt: Added.
  • platform/win/editing/input: Added.
  • platform/win/editing/input/reveal-caret-of-multiline-contenteditable-expected.txt: Added.
  • platform/win/editing/input/reveal-caret-of-multiline-input-expected.txt: Added.
  • platform/win/editing/input/scroll-to-edge-if-line-break-at-end-of-document-contenteditable-expected.txt: Added.
  • platform/win/editing/selection/caret-ltr-right-expected.txt:
  • platform/win/editing/selection/caret-rtl-2-left-expected.txt:
  • platform/win/editing/selection/caret-rtl-right-expected.txt:
  • platform/win/editing/selection/select-from-textfield-outwards-expected.txt:
  • platform/win/editing/selection/transformed-selection-rects-expected.txt:
  • platform/win/editing/spelling/grammar-paste-expected.txt: Added.
  • platform/win/editing/spelling/spellcheck-async-mutation-expected.txt: Added.
  • platform/win/editing/spelling/spellcheck-queue-expected.txt: Added.
  • platform/win/editing/spelling/spellcheck-sequencenum-expected.txt: Added.
1:50 PM Changeset in webkit [118963] by commit-queue@webkit.org
  • 52 edits in trunk/Source/WebCore

Unreviewed, rolling out r118913.
​http://trac.webkit.org/changeset/118913
​https://bugs.webkit.org/show_bug.cgi?id=87891

patch is incorrect (see comments in
​https://bugs.webkit.org/show_bug.cgi?id=87889) (Requested by
thorton on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-05-30

  • css/CSSFontFaceSrcValue.cpp:

(WebCore::CSSFontFaceSrcValue::addSubresourceStyleURLs):

  • css/CSSFontFaceSrcValue.h:

(CSSFontFaceSrcValue):

  • css/CSSPrimitiveValue.cpp:

(WebCore::CSSPrimitiveValue::addSubresourceStyleURLs):

  • css/CSSPrimitiveValue.h:

(CSSPrimitiveValue):

  • css/CSSReflectValue.cpp:

(WebCore::CSSReflectValue::addSubresourceStyleURLs):

  • css/CSSReflectValue.h:

(CSSReflectValue):

  • css/CSSValue.cpp:

(WebCore::CSSValue::addSubresourceStyleURLs):

  • css/CSSValue.h:

(CSSValue):

  • css/CSSValueList.cpp:

(WebCore::CSSValueList::addSubresourceStyleURLs):

  • css/CSSValueList.h:

(CSSValueList):

  • css/StylePropertySet.cpp:

(WebCore::StylePropertySet::addSubresourceStyleURLs):

  • css/StylePropertySet.h:

(StylePropertySet):

  • css/StyleSheetContents.cpp:

(WebCore::StyleSheetContents::addSubresourceStyleURLs):

  • css/StyleSheetContents.h:

(StyleSheetContents):

  • dom/Element.h:
  • dom/Node.cpp:

(WebCore::Node::getSubresourceURLs):

  • dom/Node.h:

(WebCore::Node::addSubresourceAttributeURLs):
(WebCore):

  • dom/ProcessingInstruction.cpp:

(WebCore::ProcessingInstruction::addSubresourceAttributeURLs):

  • dom/ProcessingInstruction.h:

(ProcessingInstruction):

  • dom/StyledElement.cpp:

(WebCore::StyledElement::addSubresourceAttributeURLs):

  • dom/StyledElement.h:

(StyledElement):

  • html/HTMLBodyElement.cpp:

(WebCore::HTMLBodyElement::addSubresourceAttributeURLs):

  • html/HTMLBodyElement.h:

(HTMLBodyElement):

  • html/HTMLEmbedElement.cpp:

(WebCore::HTMLEmbedElement::addSubresourceAttributeURLs):

  • html/HTMLEmbedElement.h:

(HTMLEmbedElement):

  • html/HTMLImageElement.cpp:

(WebCore::HTMLImageElement::addSubresourceAttributeURLs):

  • html/HTMLImageElement.h:

(HTMLImageElement):

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::addSubresourceAttributeURLs):

  • html/HTMLInputElement.h:

(HTMLInputElement):

  • html/HTMLLinkElement.cpp:

(WebCore::HTMLLinkElement::addSubresourceAttributeURLs):

  • html/HTMLLinkElement.h:

(HTMLLinkElement):

  • html/HTMLObjectElement.cpp:

(WebCore::HTMLObjectElement::addSubresourceAttributeURLs):

  • html/HTMLObjectElement.h:

(HTMLObjectElement):

  • html/HTMLParamElement.cpp:

(WebCore::HTMLParamElement::addSubresourceAttributeURLs):

  • html/HTMLParamElement.h:

(HTMLParamElement):

  • html/HTMLScriptElement.cpp:

(WebCore::HTMLScriptElement::addSubresourceAttributeURLs):

  • html/HTMLScriptElement.h:

(HTMLScriptElement):

  • html/HTMLStyleElement.cpp:

(WebCore::HTMLStyleElement::addSubresourceAttributeURLs):

  • html/HTMLStyleElement.h:

(HTMLStyleElement):

  • html/HTMLTableCellElement.cpp:

(WebCore::HTMLTableCellElement::addSubresourceAttributeURLs):

  • html/HTMLTableCellElement.h:

(HTMLTableCellElement):

  • html/HTMLTableElement.cpp:

(WebCore::HTMLTableElement::addSubresourceAttributeURLs):

  • html/HTMLTableElement.h:

(HTMLTableElement):

  • svg/SVGCursorElement.cpp:

(WebCore::SVGCursorElement::addSubresourceAttributeURLs):

  • svg/SVGCursorElement.h:

(SVGCursorElement):

  • svg/SVGFEImageElement.cpp:

(WebCore::SVGFEImageElement::addSubresourceAttributeURLs):

  • svg/SVGFEImageElement.h:

(SVGFEImageElement):

  • svg/SVGImageElement.cpp:

(WebCore::SVGImageElement::addSubresourceAttributeURLs):

  • svg/SVGImageElement.h:

(SVGImageElement):

  • svg/SVGScriptElement.cpp:

(WebCore::SVGScriptElement::addSubresourceAttributeURLs):

  • svg/SVGScriptElement.h:

(SVGScriptElement):

1:47 PM Changeset in webkit [118962] by commit-queue@webkit.org
  • 8 edits in trunk

[EFL] Ewk_Intent_Request's postResult/postFailure should take serialized script values in argument
​https://bugs.webkit.org/show_bug.cgi?id=87829

Patch by Christophe Dumez <Christophe Dumez> on 2012-05-30
Reviewed by Adam Barth.

Source/WebKit/efl:

Ewk_Intent_Request's postResult/postFailure methods now take
SerializedScriptValues in argument instead of strings. The client can
now post results of any type, not just strings, which is according to
spec. Those methods are now moved to private header and a helper
function was added to DumpRenderTreeSupportEfl so that the DRT can
still send intent results.

  • WebCoreSupport/DumpRenderTreeSupportEfl.cpp:

(DumpRenderTreeSupportEfl::sendWebIntentResponse):

  • WebCoreSupport/DumpRenderTreeSupportEfl.h:
  • ewk/ewk_intent_private.h:

(WebCore):

  • ewk/ewk_intent_request.cpp:

(ewk_intent_request_result_post):
(ewk_intent_request_failure_post):

  • ewk/ewk_intent_request.h:

Tools:

EFL's LayoutTestController now makes uses of the new helper method in
DumpRenderTreeSupportEfl in order to send the intent response. This is
now needed because the Ewk_Intent_Request postResult / postFailure
methods were made private.

  • DumpRenderTree/efl/LayoutTestControllerEfl.cpp:

(LayoutTestController::sendWebIntentResponse):

1:30 PM Changeset in webkit [118961] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebCore

Rename offsetTopLeft in RenderBoxModelObject to something better
​https://bugs.webkit.org/show_bug.cgi?id=85915

Patch by Shezan Baig <​shezbaig.wk@gmail.com> on 2012-05-30
Reviewed by Darin Adler.

Renamed offsetTopLeft in RenderBoxModelObject to
adjustedPositionRelativeToOffsetParent, because it returns the given
startPoint after adjusting it to be relative to the top-left corner of
the offsetParent. The definition of offsetParent itself is non-trivial
and is documented within the body of RenderObject::offsetParent,
therefore I decided to reuse this term, as-is, in the name of this
function.

No new tests; no functional or visible changes.

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::offsetLeft):
(WebCore::RenderBox::offsetTop):

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::adjustedPositionRelativeToOffsetParent):
(WebCore::RenderBoxModelObject::offsetLeft):
(WebCore::RenderBoxModelObject::offsetTop):

  • rendering/RenderBoxModelObject.h:

(RenderBoxModelObject):

  • rendering/RenderInline.cpp:

(WebCore::RenderInline::offsetLeft):
(WebCore::RenderInline::offsetTop):

1:18 PM Changeset in webkit [118960] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

ScriptDebugServer wants sourceIDs that are non-zero because that's what HashMaps want, so JSC should placate it
​https://bugs.webkit.org/show_bug.cgi?id=87887

Reviewed by Geoffrey Garen.

  • parser/SourceProvider.h:

(JSC::SourceProvider::asID):

1:17 PM Changeset in webkit [118959] by shawnsingh@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] Merge shared code in CCOcclusionTrackerTest
​https://bugs.webkit.org/show_bug.cgi?id=87798

Reviewed by Adrienne Walker.

This patch simple uses a different existing macro function so that
the same thing doesn't exist in multiple places, and so that the
naming is more consistent with gtest's conventions.

  • tests/CCOcclusionTrackerTest.cpp:

(WebKitTests::CCOcclusionTrackerTestIdentityTransforms::runMyTest):
(WebKitTests::CCOcclusionTrackerTestRotatedChild::runMyTest):
(WebKitTests::CCOcclusionTrackerTestTranslatedChild::runMyTest):
(WebKitTests::CCOcclusionTrackerTestChildInRotatedChild::runMyTest):
(WebKitTests::CCOcclusionTrackerTestVisitTargetTwoTimes::runMyTest):
(WebKitTests::CCOcclusionTrackerTestSurfaceRotatedOffAxis::runMyTest):
(WebKitTests::CCOcclusionTrackerTestSurfaceWithTwoOpaqueChildren::runMyTest):
(WebKitTests::CCOcclusionTrackerTestOverlappingSurfaceSiblings::runMyTest):
(WebKitTests::CCOcclusionTrackerTestOverlappingSurfaceSiblingsWithTwoTransforms::runMyTest):
(WebKitTests::CCOcclusionTrackerTestFilters::runMyTest):
(WebKitTests::CCOcclusionTrackerTestReplicaDoesOcclude::runMyTest):
(WebKitTests::CCOcclusionTrackerTestReplicaWithClipping::runMyTest):
(WebKitTests::CCOcclusionTrackerTestReplicaWithMask::runMyTest):
(WebKitTests::CCOcclusionTrackerTestLayerScissorRectOutsideChild::runMyTest):
(WebKitTests::CCOcclusionTrackerTestScreenScissorRectOutsideChild::runMyTest):
(WebKitTests::CCOcclusionTrackerTestLayerScissorRectPartlyOverChild::runMyTest):
(WebKitTests::CCOcclusionTrackerTestScreenScissorRectPartlyOverChild::runMyTest):
(WebKitTests::CCOcclusionTrackerTestOpaqueContentsRegionNonEmpty::runMyTest):
(WebKitTests::CCOcclusionTrackerTest3dTransform::runMyTest):
(WebKitTests::CCOcclusionTrackerTestPerspectiveTransform::runMyTest):
(WebKitTests::CCOcclusionTrackerTestAnimationOpacity1OnMainThread::runMyTest):
(WebKitTests::CCOcclusionTrackerTestAnimationOpacity0OnMainThread::runMyTest):
(WebKitTests::CCOcclusionTrackerTestAnimationTranslateOnMainThread::runMyTest):
(WebKitTests::CCOcclusionTrackerTestSurfaceOcclusionTranslatesToParent::runMyTest):
(WebKitTests::CCOcclusionTrackerTestSurfaceOcclusionTranslatesWithClipping::runMyTest):
(WebKitTests::CCOcclusionTrackerTestReplicaOccluded::runMyTest):
(WebKitTests::CCOcclusionTrackerTestSurfaceWithReplicaUnoccluded::runMyTest):
(WebKitTests::CCOcclusionTrackerTestSurfaceAndReplicaOccludedDifferently::runMyTest):
(WebKitTests::CCOcclusionTrackerTestSurfaceChildOfSurface::runMyTest):
(WebKitTests::CCOcclusionTrackerTestTopmostSurfaceIsClippedToScissor::runMyTest):
(WebKitTests::CCOcclusionTrackerTestSurfaceChildOfClippingSurface::runMyTest):
(WebKitTests::CCOcclusionTrackerTestDontOccludePixelsNeededForBackgroundFilter::runMyTest):
(WebKitTests::CCOcclusionTrackerTestTwoBackgroundFiltersReduceOcclusionTwice::runMyTest):
(WebKitTests::CCOcclusionTrackerTestDontOccludePixelsNeededForBackgroundFilterWithClip::runMyTest):
(WebKitTests::CCOcclusionTrackerTestDontReduceOcclusionBelowBackgroundFilter::runMyTest):
(WebKitTests::CCOcclusionTrackerTestDontReduceOcclusionIfBackgroundFilterIsOccluded::runMyTest):
(WebKitTests::CCOcclusionTrackerTestMinimumTrackingSize::runMyTest):

12:53 PM Changeset in webkit [118958] by tony@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] port webframe_unittest.cc to webkit_unit_tests
​https://bugs.webkit.org/show_bug.cgi?id=87796

Reviewed by James Robinson.

Move WebFrameTest.GetContentAsPlainText and WebFrameTest.GetFullHtmlOfPage to webkit_unit_tests.

  • tests/WebFrameTest.cpp:

(WebKit::TEST_F):
(WebKit): Add tests.

12:51 PM Changeset in webkit [118957] by enne@google.com
  • 4 edits
    6 adds in trunk

Transformed fixed position layers have an incorrect overlap map entry
​https://bugs.webkit.org/show_bug.cgi?id=64201

Reviewed by Darin Adler.

Source/WebCore:

Previously, layers that both had a transform and were fixed position
were not considered as being fixed position in RenderGeometryMap or in
RenderBox::mapLocalToContainer (although this case is not incorrect in
the case of painting, so an external caller likely adjusts for this).

Tests: compositing/layer-creation/fixed-position-and-transform.html

compositing/layer-creation/fixed-position-under-transform.html

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::mapLocalToContainer):

  • rendering/RenderGeometryMap.cpp:

(WebCore::RenderGeometryMap::mapToAbsolute):

LayoutTests:

Add a test for a layer with both fixed position and a transform to
verify that this is considered as fixed position with respect to the
root.

Also, add a test with a child layer with fixed position and a parent
with a transform to verify that the child is not considered as fixed
position with respect to the root.

  • compositing/layer-creation/fixed-position-and-transform-expected.png: Added.
  • compositing/layer-creation/fixed-position-and-transform-expected.txt: Added.
  • compositing/layer-creation/fixed-position-and-transform.html: Added.
  • compositing/layer-creation/fixed-position-under-transform-expected.png: Added.
  • compositing/layer-creation/fixed-position-under-transform-expected.txt: Added.
  • compositing/layer-creation/fixed-position-under-transform.html: Added.
12:45 PM Changeset in webkit [118956] by oliver@apple.com
  • 4 edits
    3 adds in trunk

DFG does not correctly handle exceptions caught in the LLInt
​https://bugs.webkit.org/show_bug.cgi?id=87885

Reviewed by Filip Pizlo.

Source/JavaScriptCore:

Make the DFG use genericThrow, rather than reimplementing a small portion of it.
Also make the LLInt slow paths validate that their PC is correct.

  • dfg/DFGOperations.cpp:
  • llint/LLIntSlowPaths.cpp:

(LLInt):

LayoutTests:

Pile of code to convince the DFG to throw an exception that ends up being caught
in the LLInt

  • fast/js/exception-propagate-from-dfg-to-llint-expected.txt: Added.
  • fast/js/exception-propagate-from-dfg-to-llint.html: Added.
  • fast/js/script-tests/exception-propagate-from-dfg-to-llint.js: Added.

(o.toString):
(h):
(g):
(f1):
(f2):

12:44 PM Changeset in webkit [118955] by commit-queue@webkit.org
  • 5 edits
    2 adds in trunk

[v8] Crash after redefining setter on typed array to a number
​https://bugs.webkit.org/show_bug.cgi?id=87862

Patch by Ulan Degenbaev <​ulan@chromium.org> on 2012-05-30
Reviewed by Kenneth Russell.

Remove calls to typed array set() method from C++.
Store the copying script as a hidden property of a typed array prototype.

Source/WebCore:

Test: fast/canvas/webgl/array-override-set.html

  • bindings/v8/custom/V8ArrayBufferViewCustom.cpp:

(WebCore):
(WebCore::getHiddenCopyMethod):
(WebCore::installHiddenCopyMethod):
(WebCore::copyElements):

  • bindings/v8/custom/V8ArrayBufferViewCustom.h:

(WebCore):
(WebCore::constructWebGLArray):
(WebCore::setWebGLArrayHelper):

  • bindings/v8/custom/V8ArrayBufferViewCustomScript.js:

LayoutTests:

  • fast/canvas/webgl/array-override-set-expected.txt: Added.
  • fast/canvas/webgl/array-override-set.html: Added.
12:40 PM Changeset in webkit [118954] by schenney@chromium.org
  • 2 edits in trunk/LayoutTests

http/tests/cache/subresource-expiration-2.html is slow on Linux

Unreviewed Chromium test expectations expansion.

  • platform/chromium/test_expectations.txt:
12:34 PM Changeset in webkit [118953] by timothy_horton@apple.com
  • 1 edit
    1 add in trunk/LayoutTests

fast/dom/Window/mozilla-focus-blur.html is failing on Mac
​https://bugs.webkit.org/show_bug.cgi?id=87884
<rdar://problem/11558864>

Unreviewed failing baselines after ​http://trac.webkit.org/changeset/118916.

  • platform/mac/fast/dom/Window/mozilla-focus-blur-expected.txt: Added.
12:32 PM Changeset in webkit [118952] by schenney@chromium.org
  • 2 edits in trunk/LayoutTests

Layout Test perf/mouse-event.html is flaky on Linux
​https://bugs.webkit.org/show_bug.cgi?id=87886

Unreviewed Chromium expectations update for perf/mouse-event.html

  • platform/chromium/test_expectations.txt:
12:22 PM Changeset in webkit [118951] by schenney@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed Chromium epxectations update for http/tests/media/media-source/video-media-source-errors.html

  • platform/chromium/test_expectations.txt:
12:11 PM Changeset in webkit [118950] by hyatt@apple.com
  • 5 edits in trunk/Source/WebCore

​https://bugs.webkit.org/show_bug.cgi?id=87882

[New Multicolumn] Rename layoutColumns to relayoutForPagination and make it
virtual so that it can be implemented by RenderMultiColumnBlock.

Reviewed by Anders Carlsson.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::layoutBlock):
(WebCore::RenderBlock::relayoutForPagination):

  • rendering/RenderBlock.h:

(RenderBlock):

  • rendering/RenderMultiColumnBlock.cpp:

(WebCore::RenderMultiColumnBlock::relayoutForPagination):
(WebCore):

  • rendering/RenderMultiColumnBlock.h:

(RenderMultiColumnBlock):

12:08 PM Changeset in webkit [118949] by Martin Robinson
  • 3 edits in trunk/Source/WebCore

Check for GTK2/GTK3 symbol mismatch earlier
​https://bugs.webkit.org/show_bug.cgi?id=87687

Patch by Daniel Drake <​dsd@laptop.org> on 2012-05-30
Reviewed by Martin Robinson.

No new tests. Regressions in core behavior are covered by existing
plugin tests and the fix deals with particular aspects of the system
environment that are difficult to test.

Detect plugins that would mix GTK+ symbols earlier, so that the
WebKit can skip them and choose a more appropriate plugin module.

  • plugins/gtk/PluginPackageGtk.cpp: Move this code from PluginViewGtk.

(WebCore::moduleMixesGtkSymbols):
(WebCore::PluginPackage::load):

  • plugins/gtk/PluginViewGtk.cpp: Move this code to PluginPackageGtk.

(WebCore::PluginView::platformStart):

11:57 AM Changeset in webkit [118948] by aestes@apple.com
  • 2 edits in trunk/Source/WebKit2

WebProcessMainMac.mm doesn't need to import WKView.h.

Rubber-stamped by Anders Carlsson.

  • WebProcess/mac/WebProcessMainMac.mm:
11:48 AM Changeset in webkit [118947] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebCore

[Qt] Support IMAGE_DECODER_DOWN_SAMPLING flag.
​https://bugs.webkit.org/show_bug.cgi?id=87840

Based on patches by Qi Zhang and Jussi Lehto.
Patch by Allan Sandfeld Jensen <​allan.jensen@nokia.com> on 2012-05-30
Reviewed by Kenneth Rohde Christiansen.

  • platform/graphics/Image.cpp:

(WebCore::Image::adjustSourceRectForDownSampling):

  • platform/graphics/Image.h:

(Image):

  • platform/graphics/openvg/ImageOpenVG.cpp:

(WebCore::BitmapImage::draw):

  • platform/graphics/qt/ImageQt.cpp:

(WebCore::Image::drawPattern):
(WebCore::BitmapImage::draw):

11:44 AM Changeset in webkit [118946] by ap@apple.com
  • 2 edits in trunk/LayoutTests
  • platform/wk2/Skipped: Skipping newly added file-last-modified-after-delete.html, because WTR doesn't implement beginDragWithFiles.
11:36 AM Changeset in webkit [118945] by shinyak@chromium.org
  • 5 edits
    2 adds in trunk

comparePositions in htmlediting should consider nested Shadow DOM.
​https://bugs.webkit.org/show_bug.cgi?id=87623

Reviewed by Ryosuke Niwa.

Source/WebCore:

comparePositions in htmlediting.cpp didn't consider nested Shadow DOM.
This patch makes it possible to compare the nodes in nested Shadow DOM.

The algorithm is: we calculate the common tree scope of node A and B, and
adjust the nodes to the treeScope, then compare them. If the adjusted nodes
are the same, we check the shadow descendent of each node.

Test: editing/shadow/compare-positions-in-nested-shadow.html

  • dom/TreeScope.cpp:

(WebCore::listTreeScopes):
(WebCore):
(WebCore::commonTreeScope):

  • dom/TreeScope.h:

(WebCore):

  • editing/htmlediting.cpp:

(WebCore::comparePositions):

LayoutTests:

  • editing/shadow/compare-positions-in-nested-shadow-expected.txt: Added.
  • editing/shadow/compare-positions-in-nested-shadow.html: Added.
11:33 AM Changeset in webkit [118944] by arv@chromium.org
  • 4 edits in trunk

[V8] Clean up V8LazyEventListener to use one less function call
​https://bugs.webkit.org/show_bug.cgi?id=87785

Reviewed by Kentaro Hara.

Instead of relying on 'arguments' we rely on 'this'. 'this' cannot be intercepted by a
with-statement so it is safe to use that to bind the context objects. This allows us to
remove one layer of function indirection in the generated code.

Source/WebCore:

Covered by existing tests.

  • bindings/v8/V8LazyEventListener.cpp:

(WebCore::V8LazyEventListener::prepareListenerObject):

LayoutTests:

  • platform/chromium-win/inspector/debugger/debugger-scripts-expected.txt:
11:31 AM Changeset in webkit [118943] by schenney@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed Chromium test expectations for fast/layers/scroll-with-transform-composited-layer.html

  • platform/chromium/test_expectations.txt:
11:28 AM Changeset in webkit [118942] by timothy_horton@apple.com
  • 5 edits in trunk/Source/WebCore

Factor DeferrableOneShotTimer out of GraphicsContextCG/GeneratorGeneratedImage
​https://bugs.webkit.org/show_bug.cgi?id=87824

Reviewed by Simon Fraser.

DeferrableOneShotTimer is a timer which takes a class and method to call (as Timer does),
and a delay. It exposes restart(), stop(), and isActive(), and none of the rest of
the TimerBase interface. On restart(), the timer is started with the given delay,
unless it's already running, in which case a flag is set to automatically restart
the timer when it fires instead of calling the given method. This provides a
low-overhead way to implement a deferrable timer.

No new tests, refactoring.

  • platform/Timer.h:

(DeferrableOneShotTimer):
(WebCore::DeferrableOneShotTimer::DeferrableOneShotTimer): New class.
(WebCore::DeferrableOneShotTimer::restart):
(WebCore::DeferrableOneShotTimer::fired):

  • platform/graphics/GeneratorGeneratedImage.cpp:

(WebCore::GeneratorGeneratedImage::invalidateCacheTimerFired):

  • platform/graphics/GeneratorGeneratedImage.h:

(WebCore::GeneratorGeneratedImage::GeneratorGeneratedImage): Make use of DeferrableOneShotTimer.

  • platform/graphics/cg/GraphicsContextCG.cpp:

(WebCore::SubimageCacheWithTimer::SubimageCacheWithTimer): Make use of DeferrableOneShotTimer.
(WebCore::SubimageCacheWithTimer::invalidateCacheTimerFired):

11:09 AM Changeset in webkit [118941] by commit-queue@webkit.org
  • 7 edits
    4 adds in trunk

Source/WebCore: eventSender.beginDragWithFiles should be implemented in Windows, which blocked drag and drop related tests.
​https://bugs.webkit.org/show_bug.cgi?id=86296

Patch by Xueqing Huang <​huangxueqing@baidu.com> on 2012-05-30
Reviewed by Tony Chang.

Test: This change was requirement for eventSender.beginDragWithFiles, update win/Skipped file to remove drag and drop related tests will valiate it.

  • platform/win/DragDataWin.cpp:

(WebCore::DragData::numberOfFiles):

Tools: eventSender.beginDragWithFiles should be implemented in Windows, which blocked drag and drop related tests.
​https://bugs.webkit.org/show_bug.cgi?id=86296

Patch by Xueqing Huang <​huangxueqing@baidu.com> on 2012-05-30
Reviewed by Tony Chang.

  • DumpRenderTree/win/DRTDataObject.cpp: Added.

(cfHDropFormat):
(cfFileNameWFormat):
(cfUrlWFormat):
(WCEnumFormatEtc):
(WCEnumFormatEtc::WCEnumFormatEtc):
(WCEnumFormatEtc::QueryInterface):
(WCEnumFormatEtc::AddRef):
(WCEnumFormatEtc::Release):
(WCEnumFormatEtc::Next):
(WCEnumFormatEtc::Skip):
(WCEnumFormatEtc::Reset):
(WCEnumFormatEtc::Clone):
(DRTDataObject::createInstance):
(DRTDataObject::DRTDataObject):
(DRTDataObject::~DRTDataObject):
(DRTDataObject::QueryInterface):
(DRTDataObject::AddRef):
(DRTDataObject::Release):
(DRTDataObject::GetData):
(DRTDataObject::GetDataHere):
(DRTDataObject::QueryGetData):
(DRTDataObject::GetCanonicalFormatEtc):
(DRTDataObject::SetData):
(DRTDataObject::CopyMedium):
(DRTDataObject::EnumFormatEtc):
(DRTDataObject::DAdvise):
(DRTDataObject::DUnadvise):
(DRTDataObject::EnumDAdvise):
(DRTDataObject::clearData):

  • DumpRenderTree/win/DRTDataObject.h: Added.

(DRTDataObject):

  • DumpRenderTree/win/DRTDropSource.cpp: Added.

(DRTDropSource::DRTDropSource):
(DRTDropSource::~DRTDropSource):
(DRTDropSource::QueryInterface):
(DRTDropSource::AddRef):
(DRTDropSource::Release):
(DRTDropSource::createInstance):
(DRTDropSource::QueryContinueDrag):
(DRTDropSource::GiveFeedback):

  • DumpRenderTree/win/DRTDropSource.h: Added.

(DRTDropSource):

  • DumpRenderTree/win/DumpRenderTree.vcproj:
  • DumpRenderTree/win/EventSender.cpp:

(beginDragWithFilesCallback):

LayoutTests: The tests listed in win/Skipped should be removed after this change, but some of these need to rebaseline in Windows, we do that in bug#87610.
​https://bugs.webkit.org/show_bug.cgi?id=86296

Patch by Xueqing Huang <​huangxueqing@baidu.com> on 2012-05-30
Reviewed by Tony Chang.

  • platform/win/Skipped:
11:07 AM Changeset in webkit [118940] by ap@apple.com
  • 2 edits in trunk/LayoutTests
  • fast/files/read-blob-async-expected.txt: Updating results to what Mac WK1 bot sees (two additional "result: null" lines).
10:47 AM Changeset in webkit [118939] by Dave Barton
  • 3 edits in trunk/LayoutTests

mathml/presentation/mo-stretch.html and mroot-pref-width.html tests fail on Mac
​https://bugs.webkit.org/show_bug.cgi?id=86786

Somehow these weren't included in r118935.

Unreviewed gardening.

  • platform/mac-lion/Skipped:
  • platform/mac/Skipped:
10:43 AM WebKitGTK/1.8.x edited by Martin Robinson
(diff)
10:41 AM Changeset in webkit [118938] by schenney@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed Chromium test expectations update.

tex-image-with-format-and-type.html
tex-image-with-format-and-type.html
formaction-attribute.html
terminate-during-sync-operation.html

  • platform/chromium/test_expectations.txt:
10:29 AM Changeset in webkit [118937] by commit-queue@webkit.org
  • 11 edits in trunk

WebKit2: Implement layoutTestController.setPluginsEnabled() in WebKitTestRunner.
​https://bugs.webkit.org/show_bug.cgi?id=58593

Source/WebKit2:

Adds the ability to change the pluginsEnabled flag in WebCore::Settings
to WebKitTestRunner's LayoutTestController. The flag is modified via the
public C API of the WebProcess.

Patch by Marcelo Lira <​marcelo.lira@openbossa.org> on 2012-05-30
Reviewed by Darin Adler.

  • WebProcess/InjectedBundle/API/c/WKBundle.cpp:

(WKBundleSetPluginsEnabled):

  • WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:
  • WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::InjectedBundle::setPluginsEnabled): Calls the setPluginsEnabled
method for the WebCore::Settings of each WebCore::Page in the current
page group.
(WebKit):

  • WebProcess/InjectedBundle/InjectedBundle.h:

(InjectedBundle):

Tools:

Adds the ability to change the pluginsEnabled flag in WebCore::Settings
to WebKitTestRunner's LayoutTestController. The flag is modified via the
public C API of the WebProcess.

Patch by Marcelo Lira <​marcelo.lira@openbossa.org> on 2012-05-30
Reviewed by Darin Adler.

  • WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
  • WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:

(WTR::LayoutTestController::setPluginsEnabled): Just calls the
WKBundleSetPluginsEnabled function in the public C API of WebProcess.

  • WebKitTestRunner/InjectedBundle/LayoutTestController.h:

LayoutTests:

Unskip passing tests.

Patch by Marcelo Lira <​marcelo.lira@openbossa.org> on 2012-05-30
Reviewed by Darin Adler.

  • platform/wk2/Skipped:
10:26 AM Changeset in webkit [118936] by rafaelw@chromium.org
  • 2 edits in trunk/LayoutTests

Updating test expectations (css3/filters/custom-filter-property-computed-style,
fast/frames/cached-frame-counter).

  • platform/chromium/test_expectations.txt:
10:25 AM Changeset in webkit [118935] by Dave Barton
  • 12 edits in trunk/LayoutTests

mathml/presentation/mo-stretch.html and mroot-pref-width.html tests fail on Mac
​https://bugs.webkit.org/show_bug.cgi?id=86786

The test result files below contain slightly improved metrics (usually by a single
pixel) and some other very minor (visually undetectable) pixel changes. To be honest,
I'm not sure what caused all these changes, since a lot of mathml tests have been
skipped or failing for a while. The small metric improvements were not caused by changes
in mathml code - perhaps LayoutUnit rounding or other 1-pixel corrections in logical
width code? At any rate, I'd like to rebaseline these tests, and unskip them and other
mathml tests.

Unreviewed rebaselining/gardening.

  • platform/mac-lion/Skipped:
  • platform/mac/Skipped:
  • platform/mac/mathml/presentation/attributes-expected.png:
  • platform/mac/mathml/presentation/fenced-mi-expected.png:
  • platform/mac/mathml/presentation/fractions-expected.png:
  • platform/mac/mathml/presentation/fractions-expected.txt:
  • platform/mac/mathml/presentation/fractions-vertical-alignment-expected.png:
  • platform/mac/mathml/presentation/fractions-vertical-alignment-expected.txt:
  • platform/mac/mathml/presentation/mo-stretch-expected.png:
  • platform/mac/mathml/presentation/mo-stretch-expected.txt:
  • platform/mac/mathml/presentation/roots-expected.png:
  • platform/mac/mathml/presentation/subsup-expected.png:
  • platform/mac/mathml/presentation/subsup-expected.txt:
10:18 AM Changeset in webkit [118934] by caio.oliveira@openbossa.org
  • 12 edits in trunk/Source

HashTable.h has using directives for std::pair and std::make_pair
​https://bugs.webkit.org/show_bug.cgi?id=29919

Reviewed by Darin Adler.

Source/WebCore:

Change code to use std::pair and std::make_pair.

  • accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::postNotification):

  • html/MediaFragmentURIParser.cpp:

(WebCore::MediaFragmentURIParser::parseFragments):

  • html/parser/HTMLMetaCharsetParser.cpp:

(WebCore::HTMLMetaCharsetParser::processMeta):

  • loader/cache/CachedImage.cpp:

(WebCore::CachedImage::brokenImage):

  • page/PageSerializer.cpp:

(WebCore::isCharsetSpecifyingNode):

Source/WebKit2:

Change code to use std::pair and std::make_pair.

  • UIProcess/Launcher/mac/DynamicLinkerEnvironmentExtractor.mm:

(WebKit::DynamicLinkerEnvironmentExtractor::processEnvironmentVariable):

  • UIProcess/WebContext.cpp:

(WebKit::WebContext::postMessageToInjectedBundle):

Source/WTF:

Change code to use std::pair and std::make_pair. Later patch will remove the
'using' directives.

  • wtf/HashTable.h:

(WTF::hashTableSwap):
(HashTable):

  • wtf/HashTraits.h:

(PairHashTraits):
(WTF::PairHashTraits::emptyValue):

10:17 AM Changeset in webkit [118933] by commit-queue@webkit.org
  • 5 edits in trunk

[EFL][DRT] http/tests/navigation/new-window-redirect-history.html does not pass
​https://bugs.webkit.org/show_bug.cgi?id=87848

Patch by Mikhail Pozdnyakov <​mikhail.pozdnyakov@intel.com> on 2012-05-30
Reviewed by Csaba Osztrogonác.

Tools:

The reason was that DumpRenderTreeChrome::extraViews() returned copy of the vector
and dumpBackForwardListForWebViews() used iterators belonging actually to different vectors
(browser->extraViews().begin() and browser->extraViews().end()) as if they had belonged to the same vector.

  • DumpRenderTree/efl/DumpRenderTreeChrome.cpp:

(DumpRenderTreeChrome::extraViews):

  • DumpRenderTree/efl/DumpRenderTreeChrome.h:

(DumpRenderTreeChrome):

LayoutTests:

  • platform/efl/Skipped: Unskipped http/tests/navigation/new-window-redirect-history.html.
10:02 AM Changeset in webkit [118932] by fpizlo@apple.com
  • 6 edits in trunk/Source/JavaScriptCore

DFG CFA should infer types and values of captured variables
​https://bugs.webkit.org/show_bug.cgi?id=87813

Reviewed by Gavin Barraclough.

Slight speed-up in V8/earley-boyer (~1%).

  • bytecode/CodeBlock.h:

(JSC::CodeBlock::argumentsAreCaptured):
(JSC::CodeBlock::argumentIsCaptured):
(CodeBlock):

  • dfg/DFGAbstractState.cpp:

(DFG):
(JSC::DFG::AbstractState::beginBasicBlock):
(JSC::DFG::AbstractState::initialize):
(JSC::DFG::AbstractState::endBasicBlock):
(JSC::DFG::AbstractState::execute):
(JSC::DFG::AbstractState::clobberWorld):
(JSC::DFG::AbstractState::clobberStructures):
(JSC::DFG::AbstractState::mergeStateAtTail):
(JSC::DFG::AbstractState::merge):
(JSC::DFG::AbstractState::mergeToSuccessors):

  • dfg/DFGAbstractState.h:

(JSC::DFG::AbstractState::variables):
(AbstractState):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

9:44 AM Changeset in webkit [118931] by Patrick Gansterer
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed. Build fix for !ENABLE(JIT) after r117823.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::dump):

9:14 AM Changeset in webkit [118930] by sergio@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed, removed some tests from the test_expectations file as
they have been regularly passing in the 3 GTK bots for some time.

  • platform/gtk/test_expectations.txt:
9:07 AM Changeset in webkit [118929] by Patrick Gansterer
  • 2 edits in trunk/Source/WebKit/wince

Unreviewed WinCE build fix after r115926.

  • WebView.cpp:
9:06 AM Changeset in webkit [118928] by jberlin@webkit.org
  • 2 edits in trunk/LayoutTests

[Win] REGRESSION(r118018) fast/js/names.html failing due to JavaScriptExperiments not being
enabled on Windows
​https://bugs.webkit.org/show_bug.cgi?id=87858

Skip the test on Windows to get the bots greener.

  • platform/win/Skipped:
8:49 AM Changeset in webkit [118927] by Patrick Gansterer
  • 2 edits in trunk/Source/WebKit/wince

Unreviewed WinCE build fix after r117470.

  • WebCoreSupport/EditorClientWinCE.h:

(EditorClientWinCE):

8:45 AM Changeset in webkit [118926] by jberlin@webkit.org
  • 3 edits
    1 add in trunk/LayoutTests

More Windows test cleanup.

Update the Skipped list and tests for features turned on/off on Windows.

  • platform/win/Skipped:
  • platform/win/fast/dom/constructed-objects-prototypes-expected.txt: Added.
  • platform/win/fast/js/global-constructors-expected.txt:
8:26 AM Changeset in webkit [118925] by caseq@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: disable ExactlyInt feature in InspectorTypeBuilder since it breaks release Windows 7 WK2
​https://bugs.webkit.org/show_bug.cgi?id=87857

Patch by Peter Rybin <​peter.rybin@gmail.com> on 2012-05-30
Reviewed by Yury Semikhatsky.

Code generator is patched to support old style of int parameter.

  • inspector/CodeGeneratorInspector.py:

(TypeModel.init_class):

8:17 AM Changeset in webkit [118924] by kenneth@webkit.org
  • 2 edits in trunk/Source/WebKit2

Unreviewed: Fix wrongly typed Qt slot.

  • UIProcess/qt/QtViewportInteractionEngine.cpp:

(WebKit::QtViewportInteractionEngine::QtViewportInteractionEngine):

8:06 AM Changeset in webkit [118923] by kenneth@webkit.org
  • 6 edits in trunk/Source/WebKit2

[Qt] Move ViewportAttribute related methods to the interaction engine.
​https://bugs.webkit.org/show_bug.cgi?id=87855

Reviewed by Simon Hausmann.

Move the logic of didChange{ViewportProperties|ContentsSize} to the
interaction engine and update our testing object.

  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewLegacyPrivate::QQuickWebViewLegacyPrivate):
(QQuickWebViewFlickablePrivate::didChangeViewportProperties):
(QQuickWebViewFlickablePrivate::didChangeContentsSize):

  • UIProcess/API/qt/qquickwebview_p_p.h:

(QQuickWebViewPrivate):

  • UIProcess/API/qt/qwebkittest.cpp:

(QWebKitTest::contentsScale):
(QWebKitTest::devicePixelRatio):
(QWebKitTest::initialScale):
(QWebKitTest::minimumScale):
(QWebKitTest::maximumScale):
(QWebKitTest::isScalable):
(QWebKitTest::layoutSize):

  • UIProcess/qt/QtViewportInteractionEngine.cpp:

(WebKit::QtViewportInteractionEngine::viewportAttributesChanged):
(WebKit):
(WebKit::QtViewportInteractionEngine::pageContentsSizeChanged):

  • UIProcess/qt/QtViewportInteractionEngine.h:

(QtViewportInteractionEngine):

7:24 AM Changeset in webkit [118922] by Patrick Gansterer
  • 2 edits in trunk/Source/WTF

Build fix for WinCE after r118603.

  • wtf/Atomics.h:

(WTF::weakCompareAndSwap):

7:20 AM Changeset in webkit [118921] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: Add trace() method to the WorkerConsole
​https://bugs.webkit.org/show_bug.cgi?id=87656

Patch by Alexei Filippov <​alexeif@chromium.org> on 2012-05-30
Reviewed by Yury Semikhatsky.

  • inspector/front-end/HeapSnapshotProxy.js:

(WebInspector.HeapSnapshotRealWorker.prototype._messageReceived):

  • inspector/front-end/HeapSnapshotWorker.js:

(WebInspector.WorkerConsole.prototype.trace):

6:57 AM Changeset in webkit [118920] by kinuko@chromium.org
  • 7 edits
    1 copy
    3 adds in trunk

File.lastModifiedDate must return null if the modified time info is not available
​https://bugs.webkit.org/show_bug.cgi?id=87709

Reviewed by Kentaro Hara.

Source/WebCore:

Per File API spec, File.lastModifiedDate must return null if the
modified time info is not available.
​http://dev.w3.org/2006/webapi/FileAPI/#dfn-lastModifiedDate

Test: http/tests/local/fileapi/file-last-modified-after-delete.html

  • fileapi/File.cpp:

(WebCore::File::lastModifiedDateForBinding): Added.
(WebCore):

  • fileapi/File.h:

(File):

  • fileapi/File.idl: Added ImplementedAs=lastModifiedDateForBinding.

LayoutTests:

  • http/tests/local/fileapi/file-last-modified-after-delete-expected.txt: Added.
  • http/tests/local/fileapi/file-last-modified-after-delete.html: Added.
  • http/tests/local/fileapi/resources/temp-file-utils.js: Added.
  • http/tests/local/fileapi/script-tests/file-last-modified-after-delete.js: Added.
  • http/tests/local/fileapi/script-tests/send-sliced-dragged-file.js: Factored out common temp-file related functions into temp-file-utils.js.
  • http/tests/local/fileapi/send-sliced-dragged-file.html:
6:56 AM Changeset in webkit [118919] by kenneth@webkit.org
  • 4 edits in trunk/Source/WebKit2

[Qt] Do renames in ViewportInteractionEngine as agreed upon
​https://bugs.webkit.org/show_bug.cgi?id=87845

Reviewed by Simon Hausmann.

Mostly moving methods around and renaming them to be more
consistent and avoid terminology clashes.

  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewFlickablePrivate::didChangeViewportProperties):
(QQuickWebViewFlickablePrivate::pageDidRequestScroll):
(QQuickWebViewFlickablePrivate::didChangeContentsSize):

  • UIProcess/qt/QtViewportInteractionEngine.cpp:

(WebKit::boundPosition):
(WebKit):
(WebKit::QtViewportInteractionEngine::QtViewportInteractionEngine):
(WebKit::QtViewportInteractionEngine::setPageItemRectVisible):
(WebKit::QtViewportInteractionEngine::animatePageItemRectVisible):
(WebKit::QtViewportInteractionEngine::flickMoveStarted):
(WebKit::QtViewportInteractionEngine::flickMoveEnded):
(WebKit::QtViewportInteractionEngine::pageItemPositionChanged):
(WebKit::QtViewportInteractionEngine::pageContentPositionRequest):
(WebKit::QtViewportInteractionEngine::scaleAnimationValueChanged):
(WebKit::QtViewportInteractionEngine::computePosRangeForPageItemAtScale):
(WebKit::QtViewportInteractionEngine::focusEditableArea):
(WebKit::QtViewportInteractionEngine::zoomToAreaGestureEnded):
(WebKit::QtViewportInteractionEngine::nearestValidBounds):
(WebKit::QtViewportInteractionEngine::cancelScrollAnimation):
(WebKit::QtViewportInteractionEngine::pinchGestureEnded):
(WebKit::QtViewportInteractionEngine::pageItemSizeChanged):

  • UIProcess/qt/QtViewportInteractionEngine.h:

(WebKit::QtViewportInteractionEngine::setDevicePixelRatio):
(QtViewportInteractionEngine):

6:55 AM Changeset in webkit [118918] by commit-queue@webkit.org
  • 4 edits in trunk

[EFL][DRT] EFL's DRT needs "postProgressFinishedNotification" message
​https://bugs.webkit.org/show_bug.cgi?id=87833

Patch by Mikhail Pozdnyakov <​mikhail.pozdnyakov@intel.com> on 2012-05-30
Reviewed by Tor Arne Vestbø.

Tools:

Print "postProgressFinishedNotification" message if frame load finished
to unskip http/tests/loading/progress-finished-callback.html.

  • DumpRenderTree/efl/DumpRenderTreeChrome.cpp:

(DumpRenderTreeChrome::onFrameLoadFinished):

LayoutTests:

  • platform/efl/Skipped: Unskipped http/tests/loading/progress-finished-callback.html.
6:34 AM Changeset in webkit [118917] by schenney@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Layout Test http/tests/media/media-source/webm/video-media-source-*.html is flaky
​https://bugs.webkit.org/show_bug.cgi?id=85952

Unreviewed Chromium expectations update to broaden expectations.

  • platform/chromium/test_expectations.txt:
6:28 AM Changeset in webkit [118916] by jochen@chromium.org
  • 20 edits
    6 adds in trunk

Match Firefox restrictions to window.blur and window.focus
​https://bugs.webkit.org/show_bug.cgi?id=86969

Reviewed by Adam Barth.

Source/WebCore:

Disallow window.blur altogether, and only allow window.focus to be
invoked from the context that created this very window.

There's a new setting (windowFocusRestricted) that defaults to true. If
false, the new restrictions are lifted. This can be used by ports that
would prefer to stick with the old behavior.

For tests, this setting is accessible in window.internals.settings

To temporarily allow window.focus(), an object of type
WindowFocusAllowedIndicator can be created. It is currently used to
enable window.focus() during dispatch of the click event for
notifications.

Tests: fast/dom/Window/mozilla-focus-blur.html

fast/notifications/notifications-click-event-focus.html

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • notifications/Notification.cpp:

(WebCore::Notification::dispatchClickEvent):

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::focus):
(WebCore::DOMWindow::blur):

  • page/DOMWindow.h:

(DOMWindow):

  • page/DOMWindow.idl:
  • page/Settings.cpp:

(WebCore::Settings::Settings):

  • page/Settings.h:

(Settings):
(WebCore::Settings::setWindowFocusRestricted):
(WebCore::Settings::windowFocusRestricted):

  • page/WindowFocusAllowedIndicator.cpp: Added.

(WebCore):
(WebCore::WindowFocusAllowedIndicator::windowFocusAllowed):
(WebCore::WindowFocusAllowedIndicator::WindowFocusAllowedIndicator):
(WebCore::WindowFocusAllowedIndicator::~WindowFocusAllowedIndicator):

  • page/WindowFocusAllowedIndicator.h: Added.

(WebCore):
(WindowFocusAllowedIndicator):

  • testing/InternalSettings.cpp:

(WebCore::InternalSettings::InternalSettings):
(WebCore::InternalSettings::restoreTo):
(WebCore::InternalSettings::setWindowFocusRestricted):
(WebCore):

  • testing/InternalSettings.h:

(InternalSettings):

  • testing/InternalSettings.idl:

Source/WebKit/chromium:

Allow window.focus() during the dispatch of the click event on
notifications.

  • src/WebNotification.cpp:

(WebKit::WebNotification::dispatchClickEvent):

LayoutTests:

  • fast/dom/HTMLDocument/hasFocus.html:
  • fast/dom/Window/mozilla-focus-blur-expected.txt: Added.
  • fast/dom/Window/mozilla-focus-blur.html: Added.
  • fast/notifications/notifications-click-event-focus-expected.txt: Added.
  • fast/notifications/notifications-click-event-focus.html: Added.
6:18 AM Changeset in webkit [118915] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

Unreviewed GTK gardening, updating platform-specific baselines after r118902.

  • platform/gtk/fast/js/global-constructors-expected.txt:
5:12 AM Changeset in webkit [118914] by ryuan.choi@samsung.com
  • 17 edits in trunk

[EFL][WK2] Fix WebKit2-EFL build
​https://bugs.webkit.org/show_bug.cgi?id=83693

Reviewed by Carlos Garcia Campos.

.:

  • Source/cmake/OptionsEfl.cmake: Define BUILDING_SOUP to build WebKit2/Efl.

Source/WebCore:

  • CMakeLists.txt: Add GestureTapHighlighter.cpp.

Source/WebKit2:

  • CMakeLists.txt: Move IDL generator codes to generate port specific *.messages.in.
  • PlatformEfl.cmake: Add soup related files after r115411 and includes to fix build break.
  • UIProcess/API/efl/PageClientImpl.cpp: Fix build break with ENABLE_TOUCH_EVENTS.

(WebKit):
(WebKit::PageClientImpl::doneWithTouchEvent):

  • UIProcess/API/efl/PageClientImpl.h:

(PageClientImpl):

  • WebProcess/WebCoreSupport/WebChromeClient.cpp: Fix build break with ENABLE_INPUT_TYPE_COLOR and ENABLE_REGISTER_PROTOCOL_HANDLER.

(WebKit):
(WebKit::WebChromeClient::createColorChooser):

  • WebProcess/WebCoreSupport/WebChromeClient.h:

(WebChromeClient):

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: Fix build break with ENABLE_WEB_INTENTS

(WebKit):
(WebKit::WebFrameLoaderClient::dispatchIntent):

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.h:

(WebCore):
(WebFrameLoaderClient):

  • WebProcess/WebProcess.cpp: Guard PLATFORM_STRATEGIES codes.

(WebKit::WebProcess::didGetPlugins):

  • WebProcess/soup/WebSoupRequestManager.cpp: Try to share with EFL port.

(WebKit::WebSoupRequestManager::didHandleURIRequest):

Tools:

  • CMakeLists.txt: Guard Webkit1 related codes with ENABLE_WEBKIT.
5:09 AM Changeset in webkit [118913] by Antti Koivisto
  • 52 edits in trunk/Source/WebCore

Rename Foo::addSubresourceStyleURLs and Node::addSubresourceAttributeURLs
​https://bugs.webkit.org/show_bug.cgi?id=87739

Rubber-stamped by Andreas Kling.

Rename them to collectSubresourceURLs and collectSubresourceURLsFromAttributes to match
the naming conventions.

Move collectSubresourceURLsFromAttributes from Node to Element as only elements have attributes.

  • css/CSSFontFaceSrcValue.cpp:

(WebCore::CSSFontFaceSrcValue::collectSubresourceURLs):

  • css/CSSFontFaceSrcValue.h:

(CSSFontFaceSrcValue):

  • css/CSSPrimitiveValue.cpp:

(WebCore::CSSPrimitiveValue::collectSubresourceURLs):

  • css/CSSPrimitiveValue.h:

(CSSPrimitiveValue):

  • css/CSSReflectValue.cpp:

(WebCore::CSSReflectValue::collectSubresourceURLs):

  • css/CSSReflectValue.h:

(CSSReflectValue):

  • css/CSSValue.cpp:

(WebCore::CSSValue::collectSubresourceURLs):

  • css/CSSValue.h:

(CSSValue):

  • css/CSSValueList.cpp:

(WebCore::CSSValueList::collectSubresourceURLs):

  • css/CSSValueList.h:

(CSSValueList):

  • css/StylePropertySet.cpp:

(WebCore::StylePropertySet::collectSubresourceURLs):

  • css/StylePropertySet.h:

(StylePropertySet):

  • css/StyleSheetContents.cpp:

(WebCore::StyleSheetContents::collectSubresourceURLs):

  • css/StyleSheetContents.h:

(StyleSheetContents):

  • dom/Element.h:

(WebCore::Element::collectSubresourceURLsFromAttributes):
(Element):

  • dom/Node.cpp:

(WebCore::Node::getSubresourceURLs):

  • dom/Node.h:

(WebCore):

  • dom/ProcessingInstruction.cpp:

(WebCore::ProcessingInstruction::collectSubresourceURLsFromAttributes):

  • dom/ProcessingInstruction.h:

(ProcessingInstruction):

  • dom/StyledElement.cpp:

(WebCore::StyledElement::collectSubresourceURLsFromAttributes):

  • dom/StyledElement.h:

(StyledElement):

  • html/HTMLBodyElement.cpp:

(WebCore::HTMLBodyElement::collectSubresourceURLsFromAttributes):

  • html/HTMLBodyElement.h:

(HTMLBodyElement):

  • html/HTMLEmbedElement.cpp:

(WebCore::HTMLEmbedElement::collectSubresourceURLsFromAttributes):

  • html/HTMLEmbedElement.h:

(HTMLEmbedElement):

  • html/HTMLImageElement.cpp:

(WebCore::HTMLImageElement::collectSubresourceURLsFromAttributes):

  • html/HTMLImageElement.h:

(HTMLImageElement):

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::collectSubresourceURLsFromAttributes):

  • html/HTMLInputElement.h:

(HTMLInputElement):

  • html/HTMLLinkElement.cpp:

(WebCore::HTMLLinkElement::collectSubresourceURLsFromAttributes):

  • html/HTMLLinkElement.h:

(HTMLLinkElement):

  • html/HTMLObjectElement.cpp:

(WebCore::HTMLObjectElement::collectSubresourceURLsFromAttributes):

  • html/HTMLObjectElement.h:

(HTMLObjectElement):

  • html/HTMLParamElement.cpp:

(WebCore::HTMLParamElement::collectSubresourceURLsFromAttributes):

  • html/HTMLParamElement.h:

(HTMLParamElement):

  • html/HTMLScriptElement.cpp:

(WebCore::HTMLScriptElement::collectSubresourceURLsFromAttributes):

  • html/HTMLScriptElement.h:

(HTMLScriptElement):

  • html/HTMLStyleElement.cpp:

(WebCore::HTMLStyleElement::collectSubresourceURLsFromAttributes):

  • html/HTMLStyleElement.h:

(HTMLStyleElement):

  • html/HTMLTableCellElement.cpp:

(WebCore::HTMLTableCellElement::collectSubresourceURLsFromAttributes):

  • html/HTMLTableCellElement.h:

(HTMLTableCellElement):

  • html/HTMLTableElement.cpp:

(WebCore::HTMLTableElement::collectSubresourceURLsFromAttributes):

  • html/HTMLTableElement.h:

(HTMLTableElement):

  • svg/SVGCursorElement.cpp:

(WebCore::SVGCursorElement::collectSubresourceURLsFromAttributes):

  • svg/SVGCursorElement.h:

(SVGCursorElement):

  • svg/SVGFEImageElement.cpp:

(WebCore::SVGFEImageElement::collectSubresourceURLsFromAttributes):

  • svg/SVGFEImageElement.h:

(SVGFEImageElement):

  • svg/SVGImageElement.cpp:

(WebCore::SVGImageElement::collectSubresourceURLsFromAttributes):

  • svg/SVGImageElement.h:

(SVGImageElement):

  • svg/SVGScriptElement.cpp:

(WebCore::SVGScriptElement::collectSubresourceURLsFromAttributes):

  • svg/SVGScriptElement.h:

(SVGScriptElement):

4:57 AM Changeset in webkit [118912] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Browser crashed when selecting in textarea
​https://bugs.webkit.org/show_bug.cgi?id=87484

The function FatFingers::checkForText() uses host node's whole text
to checkFingerIntersection(). We should not give the text of shadow
nodes to it.

Patch by Sean Wang <​Xuewen.Wang@torchmobile.com.cn> on 2012-05-30
Reviewed by Antonio Gomes.

  • WebKitSupport/FatFingers.cpp:

(BlackBerry::WebKit::FatFingers::getNodesFromRect): Avoid returning
shadow nodes when the context is Text node.

4:01 AM Changeset in webkit [118911] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: Fix JS compiler warning
​https://bugs.webkit.org/show_bug.cgi?id=87836

Patch by Eugene Klyuchnikov <​eustas.bug@gmail.com> on 2012-05-30
Reviewed by Yury Semikhatsky.

  • inspector/front-end/SettingsScreen.js: Fix method annotation.
3:28 AM Changeset in webkit [118910] by kenneth@webkit.org
  • 3 edits in trunk/Source/WebKit2

[Qt] Variable renaming as preparation of further refactoring.

Rubberstamped by Simon Hausmann.

Change m_viewport to m_viewportItem and m_content to m_pageItem.

  • UIProcess/qt/QtViewportInteractionEngine.cpp:

(WebKit::QtViewportInteractionEngine::QtViewportInteractionEngine):
(WebKit::QtViewportInteractionEngine::setItemRectVisible):
(WebKit::QtViewportInteractionEngine::animateItemRectVisible):
(WebKit::QtViewportInteractionEngine::flickableMoveStarted):
(WebKit::QtViewportInteractionEngine::flickableMoveEnded):
(WebKit::QtViewportInteractionEngine::flickableMovingPositionUpdate):
(WebKit::QtViewportInteractionEngine::scaleAnimationStateChanged):
(WebKit::QtViewportInteractionEngine::pagePositionRequest):
(WebKit::QtViewportInteractionEngine::computePosRangeForItemAtScale):
(WebKit::QtViewportInteractionEngine::focusEditableArea):
(WebKit::QtViewportInteractionEngine::zoomToAreaGestureEnded):
(WebKit::QtViewportInteractionEngine::nearestValidBounds):
(WebKit::QtViewportInteractionEngine::reset):
(WebKit::QtViewportInteractionEngine::setCSSScale):
(WebKit::QtViewportInteractionEngine::currentCSSScale):
(WebKit::QtViewportInteractionEngine::scrollAnimationActive):
(WebKit::QtViewportInteractionEngine::panGestureActive):
(WebKit::QtViewportInteractionEngine::panGestureStarted):
(WebKit::QtViewportInteractionEngine::panGestureRequestUpdate):
(WebKit::QtViewportInteractionEngine::panGestureEnded):
(WebKit::QtViewportInteractionEngine::panGestureCancelled):
(WebKit::QtViewportInteractionEngine::cancelScrollAnimation):
(WebKit::QtViewportInteractionEngine::pinchGestureStarted):
(WebKit::QtViewportInteractionEngine::pinchGestureRequestUpdate):
(WebKit::QtViewportInteractionEngine::scaleContent):

  • UIProcess/qt/QtViewportInteractionEngine.h:

(QtViewportInteractionEngine):

2:37 AM Changeset in webkit [118909] by zoltan@webkit.org
  • 11 edits
    1 delete in trunk/Source

[Qt] Set WebCore imagedecoders as default and add fallback to QImageDecoder
​https://bugs.webkit.org/show_bug.cgi?id=80400

Source/WebCore:

This change modifies the default ImageDecoder for Qt-port from QImageDecoder to WebCore ImageDecoder.
The new behavior is to use QImageDecoder only if WebCoreImageDecoder - and the platform - doesn't support
the requested image type.
The WTF_USE_QT_IMAGE_DECODER macro has been removed, since it is no longer needed.

This change adds build depedency (except Qt-MAC and Qt-WIN platform) for libpng-dev and libjpeg-dev packages,
because PNG and JPEG imagedecoders need not only these libraries, but their headers also. Qmake-config
tests for these libraries were introduced in r110045.

Notice: with using libjpeg-turbo as a system library I measured 10% performance improvement on Methanol benchmark
(collection of popular sites, page-loading benchmark) with this patch.

Reviewed by Simon Hausmann.

No new tests needed.

  • Target.pri: Move WebCore ImageDecoder files out of guards. Remove ImageFrameQt.cpp from sources.
  • WebCore.pri: Move WebCore ImageDecoder include paths out of guards.
  • platform/MIMETypeRegistry.cpp:

(WebCore::initializeSupportedImageMIMETypes): Add WebCore supported and Qt supported MIME types.
(WebCore::initializeSupportedImageMIMETypesForEncoding): Use Qt supported MIME types.

  • platform/graphics/ImageSource.cpp: Remove unnecessary includes.
  • platform/graphics/ImageSource.h: Remove unnecessary typedefs.

(WebCore):

  • platform/graphics/qt/ImageDecoderQt.cpp: Remove ImageDecoder::create, since it is no longer needed.

(WebCore::ImageDecoderQt::filenameExtension): Remove unnecessary semicolon.
(WebCore::ImageDecoderQt::internalHandleCurrentImage): Use QImage and ImageFrame instead of QPixmap.
(WebCore):
(WebCore::ImageFrame::asNewNativeImage): Moved here from removed ImageFrameQt.cpp.

  • platform/image-decoders/ImageDecoder.cpp: Reorganize the includes of the header.

(WebCore::ImageDecoder::create): Add platform macro guarded fallback case for QImageDecoder. Add guards
for JPEG, PNG, ICO decoder for Qt-MAC and Qt-WIN platform.

  • platform/image-decoders/ImageDecoder.h: Remove Qt-specific codes.

(WebCore::ImageFrame::getAddr): Remove Qt-specific case, since it is no longer needed.
(ImageFrame):

  • platform/image-decoders/qt/ImageFrameQt.cpp: Removed. Dead code, other code has been moved to

ImageDecoderQt.cpp.

Source/WebKit/blackberry:

Get rid of QT_IMAGE_DECODER flag.

Reviewed by Simon Hausmann.

  • WebCoreSupport/AboutDataEnableFeatures.in:
2:34 AM Changeset in webkit [118908] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[Qt][WK2] Do not use anonymous variables for ViewportUpdateDeferrer.
​https://bugs.webkit.org/show_bug.cgi?id=87831

Patch by Zalan Bujtas <​zbujtas@gmail.com> on 2012-05-30
Reviewed by Kenneth Rohde Christiansen.

  • UIProcess/qt/QtViewportInteractionEngine.cpp:

(WebKit::QtViewportInteractionEngine::pagePositionRequest):
(WebKit::QtViewportInteractionEngine::cancelScrollAnimation):
(WebKit::QtViewportInteractionEngine::itemSizeChanged):

2:08 AM Changeset in webkit [118907] by kinuko@chromium.org
  • 4 edits in trunk/Source/WebCore

REGRESSION: We should allow null modificationTime when snapshot metadata is given
​https://bugs.webkit.org/show_bug.cgi?id=86811

Reviewed by Jian Li.

r117432 has introduced a new File constructor which allows the caller
to pass in a snapshot file metadata. In the change we had considered the
given metadata is valid if "metadata.length >= 0 AND metadata.lastModifiedDate != 0",
but we should drop the latter condition (lastModifiedDate != 0) because

  1. the value 0 is used to indicate the time information is unavailable in File, and
  2. it is valid per spec (​http://dev.w3.org/2006/webapi/FileAPI/#dfn-lastModifiedDate says the UA must return null if the information is not available).

(Note: the current js/v8 binding returns Date(0) for the time value 0,
which is still valid as epoch time but would fail to indicate the
unavailability of the information. In this patch I added FIXME in
File.idl and filed a separate issue ​http://webkit.org/b/87709)

No new tests as this change does not affect regular files/filesystems behavior.
(Tests in Chrome OS port should be able to verify this)

  • fileapi/File.cpp:

(WebCore::File::lastModifiedDate):
(WebCore::File::size):
(WebCore::File::captureSnapshot):

  • fileapi/File.h:

(File):

1:32 AM Changeset in webkit [118906] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Gardening. Shadow DOM is disabled on Qt.

Patch by Zoltan Arvai <​zarvai@inf.u-szeged.hu> on 2012-05-30
Reviewed by Csaba Osztrogonác.

  • platform/qt/Skipped: Skip fast/dom/shadow/shadow-element.html.
1:20 AM Changeset in webkit [118905] by commit-queue@webkit.org
  • 7 edits in trunk/LayoutTests

Update test expectations for tests duplicated in Skipped
​https://bugs.webkit.org/show_bug.cgi?id=87822

Unreviewed gardening; updating test expectations.

Patch by David Barr <​davidbarr@chromium.org> on 2012-05-30

  • platform/mac/Skipped:
  • platform/mac/test_expectations.txt:
  • platform/qt/Skipped:
  • platform/qt/test_expectations.txt:
  • platform/qt-5.0-wk1/Skipped:
  • platform/qt-mac/Skipped:
1:17 AM Changeset in webkit [118904] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebKit2

Unreviewed. Fix WebKit2GTK+ API tests in the bots.

  • UIProcess/API/gtk/tests/TestWebKitWebView.cpp:

(testWebViewCanShowMIMEType): Remove the check for multimedia and
plugins MIME types since they depend on the configuration and they
are not available in the bots.

1:04 AM QtWebKitBuildBots edited by Csaba Osztrogonác
Update Qt versions on the bots (diff)
12:33 AM Changeset in webkit [118903] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[GTK] Update test expectations after r118841.
​https://bugs.webkit.org/show_bug.cgi?id=87827

Unreviewed gardening; updating test expectations

Patch by David Barr <​davidbarr@chromium.org> on 2012-05-30

  • platform/gtk/test_expectations.txt:
12:26 AM Changeset in webkit [118902] by morrita@google.com
  • 7 edits in trunk

[Shadow DOM] HTMLContentElement and HTMLShadowElement constructors should be visible.
​https://bugs.webkit.org/show_bug.cgi?id=87818

Source/WebCore:

Reviewed by Kentaro Hara.

Added them as DOMWindow properties

Tests: fast/dom/shadow/content-element-api.html

fast/dom/shadow/shadow-element.html

  • page/DOMWindow.idl:

LayoutTests:

Added constructor checks.

Reviewed by Kentaro Hara.

  • fast/dom/shadow/content-element-api-expected.txt:
  • fast/dom/shadow/content-element-api.html:
  • fast/dom/shadow/shadow-element-expected.txt:
  • fast/dom/shadow/shadow-element.html:
12:17 AM Changeset in webkit [118901] by commit-queue@webkit.org
  • 6 edits in trunk/Source/JavaScriptCore

Unreviewed, rolling out r118868.
​http://trac.webkit.org/changeset/118868
​https://bugs.webkit.org/show_bug.cgi?id=87828

introduced ~20 crashes on Mac and Qt bots (Requested by pizlo_
on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-05-30

  • heap/Heap.cpp:

(JSC::Heap::collect):

  • heap/MarkedBlock.cpp:

(JSC::MarkedBlock::sweep):

  • heap/MarkedBlock.h:

(JSC::MarkedBlock::sweepWeakSet):
(JSC):

  • heap/MarkedSpace.cpp:

(JSC::SweepWeakSet::operator()):
(JSC):
(JSC::MarkedSpace::sweepWeakSets):

  • heap/MarkedSpace.h:

(MarkedSpace):

12:01 AM Changeset in webkit [118900] by mikelawther@chromium.org
  • 4 edits
    2 adds in trunk

CSS3 calc: Implement CSSOM support
​https://bugs.webkit.org/show_bug.cgi?id=84551

Reviewed by Ryosuke Niwa.

Source/WebCore:

Adds a pretty printer for the calc expression tree.

Test: css3/calc/cssom.html

  • css/CSSCalculationValue.cpp:

(WebCore::CSSCalcValue::customCssText):
(WebCore::CSSCalcPrimitiveValue::customCssText):
(WebCore::CSSCalcBinaryOperation::customCssText):
(CSSCalcBinaryOperation):

  • css/CSSCalculationValue.h:

(CSSCalcExpressionNode):

LayoutTests:

  • css3/calc/cssom-expected.txt: Added.
  • css3/calc/cssom.html: Added.
12:00 AM Changeset in webkit [118899] by haraken@chromium.org
  • 1 edit
    2 adds in trunk/PerformanceTests

[perf-test] Add a benchmark for querySelector()
​https://bugs.webkit.org/show_bug.cgi?id=87742

Reviewed by Ryosuke Niwa.

Now I am optimizing querySelector() (bug 87625).
This patch adds a performance test for querySelector().
query-selector-first.html queries an element that appears
at the head of the document. On the other hand,
query-selector-last.html queries an element that appears
at the tail of the document.

Test results in my desktop:

[query-selector-first.html]
RESULT Parser: query-selector-first= 252.339803014 runs/s
median= 253.646265594 runs/s, stdev= 2.32610873209 runs/s, min= 248.138957816 runs/s, max= 254.777070064 runs/s

RESULT Parser: query-selector-first= 252.688468897 runs/s
median= 252.684876579 runs/s, stdev= 3.60008778708 runs/s, min= 246.002460025 runs/s, max= 258.397932817 runs/s

RESULT Parser: query-selector-first= 253.466019656 runs/s
median= 254.129606099 runs/s, stdev= 1.78002675664 runs/s, min= 247.831474597 runs/s, max= 254.777070064 runs/s

RESULT Parser: query-selector-first= 256.245078189 runs/s
median= 257.06940874 runs/s, stdev= 2.84722072201 runs/s, min= 249.687890137 runs/s, max= 259.74025974 runs/s

RESULT Parser: query-selector-first= 252.203100497 runs/s
median= 252.047989175 runs/s, stdev= 1.75233446036 runs/s, min= 248.138957816 runs/s, max= 255.427841635 runs/s

[query-selector-last.html]
RESULT Parser: query-selector-last= 356.009616076 runs/s
median= 355.781448539 runs/s, stdev= 0.841519086864 runs/s, min= 354.430379747 runs/s, max= 358.056265985 runs/s

RESULT Parser: query-selector-last= 360.735271001 runs/s
median= 361.057532424 runs/s, stdev= 1.12253219867 runs/s, min= 358.514724712 runs/s, max= 362.225097025 runs/s

RESULT Parser: query-selector-last= 359.598592463 runs/s
median= 359.435173299 runs/s, stdev= 0.816538258728 runs/s, min= 358.056265985 runs/s, max= 360.824742268 runs/s

RESULT Parser: query-selector-last= 357.260651715 runs/s
median= 357.598978289 runs/s, stdev= 1.17393159885 runs/s, min= 353.982300885 runs/s, max= 358.974358974 runs/s

RESULT Parser: query-selector-last= 351.696240713 runs/s
median= 351.980025916 runs/s, stdev= 1.14200564038 runs/s, min= 348.692403487 runs/s, max= 353.535353535 runs/s

  • Parser/query-selector-first.html: Added.
  • Parser/query-selector-last.html: Added.

May 29, 2012:

11:37 PM Changeset in webkit [118898] by Csaba Osztrogonác
  • 4 edits in trunk/Tools

[Qt] Modified ORWT and NRWT to check for test expectations in platform/qt-5.0-wk1 too
(They only used to check for Skipped in platform/qt-5.0-wk1)
​https://bugs.webkit.org/show_bug.cgi?id=87376

Patch by János Badics <János Badics> on 2012-05-29
Reviewed by Csaba Osztrogonác.

  • Scripts/old-run-webkit-tests:

(buildPlatformResultHierarchy):

  • Scripts/webkitpy/layout_tests/port/qt.py:

(QtPort.baseline_search_path):

11:34 PM Changeset in webkit [118897] by commit-queue@webkit.org
  • 7 edits in trunk

[FileAPI] The result attribute of FileReader shuold use null to replace empty string
​https://bugs.webkit.org/show_bug.cgi?id=87578

Patch by Li Yin <​li.yin@intel.com> on 2012-05-29
Reviewed by Jian Li.

Source/WebCore:

Spec: ​http://www.w3.org/TR/FileAPI/#dfn-result
If the readyState is EMPTY (no read method has been called) or an error
in reading the File or Blob has occurred (using any read method), then the
result attribute MUST return null.

Currently, Firefox11, Opera and IE 10 follows the spec, but Webkit based
browser doesn't.
WebKit should change the returned value empty string into null to keep
conformance with the spec.

Tests: fast/files/read-file-async.html

fast/files/workers/worker-read-file-async.html

  • fileapi/FileReader.cpp:

(WebCore::FileReader::arrayBufferResult):
(WebCore::FileReader::stringResult):

LayoutTests:

Spec: ​http://www.w3.org/TR/FileAPI/#dfn-result
If the readyState is EMPTY (no read method has been called) or an error in
reading the File or Blob has occurred (using any read method), then the result
attribute MUST return null.

Currently, webkit return empty string, not null.

  • fast/files/read-file-async-expected.txt:
  • fast/files/resources/read-common.js:

(logResult):
(loadFailed):

  • fast/files/resources/read-file-test-cases.js:

(testReadAgainAfterFailedReadStep1):

  • fast/files/workers/worker-read-file-async-expected.txt:
11:33 PM Changeset in webkit [118896] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebKit2

Noticeable delay taking an HTML5 trailer fullscreen.
​https://bugs.webkit.org/show_bug.cgi?id=87794

Reviewed by Darin Adler.

Work around a not-entirely understood delay when using the results of a CGWindowListCreateImage()
call as the contents of a placeholder view. The backing of the resulting CGImageRef resides on
the WindowServer, and drawing that image requires synchronous calls to the WindowServer process.
By copying the image data, up front, into our own process, we can avoid those synchronous calls
later and avoid the delay-causing drawing behavior.

  • UIProcess/mac/WKFullScreenWindowController.mm:

(CGImageDeepCopy): Added a helper function which copies the image data into a new CGImage.
(-[WKFullScreenWindowController enterFullScreen:]): Use the above.

11:17 PM Changeset in webkit [118895] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] The Page's deviceScaleFactor() is not being properly maintained
​https://bugs.webkit.org/show_bug.cgi?id=87817

Patch by Max Feil <​mfeil@rim.com> on 2012-05-29
Reviewed by Antonio Gomes.

This bug fix in WebKit/blackberry is needed by the changes for
fullscreen media control sizing in WebCore (bug 87551). The sizing
of controls depends on the page's deviceScaleFactor(), which was
not being maintained properly due to errors in logic. Viewport
changes from non-default to default were being erroneously
thrown out. Also, when the viewport did change back to default
the deviceScaleFactor was not being updated.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::recomputeVirtualViewportFromViewportArguments):
(BlackBerry::WebKit::WebPagePrivate::dispatchViewportPropertiesDidChange):

10:08 PM Changeset in webkit [118894] by pilgrim@chromium.org
  • 4 edits in trunk/Source

[Chromium] Move fileExists to Platform.h
​https://bugs.webkit.org/show_bug.cgi?id=87531

Reviewed by Adam Barth.

Call fileExists through fileUtilities(), not directly.

Source/Platform:

  • chromium/public/Platform.h:

(Platform):

Source/WebCore:

  • platform/chromium/FileSystemChromium.cpp:

(WebCore::fileExists):

9:37 PM Changeset in webkit [118893] by tkent@chromium.org
  • 20 edits
    12 adds
    2 deletes in trunk/LayoutTests

[Chromium] Test expectation update.

Rebaseline for placeholder-related tests.

  • platform/chromium-linux/fast/forms/date/date-appearance-expected.txt:
  • platform/chromium-linux/fast/forms/input-placeholder-paint-order-expected.png: Added.
  • platform/chromium-linux/fast/forms/placeholder-position-expected.png:
  • platform/chromium-linux/fast/forms/search-styled-expected.txt:
  • platform/chromium-linux/fast/forms/textarea/textarea-placeholder-paint-order-expected.png: Added.
  • platform/chromium-mac-leopard/fast/forms/input-placeholder-paint-order-expected.png: Added.
  • platform/chromium-mac-leopard/fast/forms/textarea/textarea-placeholder-paint-order-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/input-placeholder-paint-order-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/textarea/textarea-placeholder-paint-order-expected.txt: Removed.
  • platform/chromium-mac/fast/css/text-overflow-input-expected.png:
  • platform/chromium-mac/fast/forms/date/date-appearance-expected.txt:
  • platform/chromium-mac/fast/forms/input-placeholder-paint-order-expected.png: Added.
  • platform/chromium-mac/fast/forms/placeholder-pseudo-style-expected.txt:
  • platform/chromium-mac/fast/forms/textarea-placeholder-pseudo-style-expected.txt:
  • platform/chromium-mac/fast/forms/textarea/textarea-placeholder-paint-order-expected.png: Added.
  • platform/chromium-win-xp/fast/forms/search-styled-expected.txt:
  • platform/chromium-win/fast/css/text-overflow-input-expected.txt:
  • platform/chromium-win/fast/forms/date/date-appearance-expected.txt:
  • platform/chromium-win/fast/forms/input-placeholder-paint-order-expected.png: Added.
  • platform/chromium-win/fast/forms/input-placeholder-visibility-1-expected.txt:
  • platform/chromium-win/fast/forms/input-placeholder-visibility-3-expected.txt:
  • platform/chromium-win/fast/forms/placeholder-position-expected.txt:
  • platform/chromium-win/fast/forms/placeholder-pseudo-style-expected.txt:
  • platform/chromium-win/fast/forms/search-styled-expected.txt:
  • platform/chromium-win/fast/forms/textarea-placeholder-pseudo-style-expected.txt:
  • platform/chromium-win/fast/forms/textarea-placeholder-visibility-1-expected.txt:
  • platform/chromium-win/fast/forms/textarea-placeholder-visibility-2-expected.txt:
  • platform/chromium-win/fast/forms/textarea/textarea-placeholder-paint-order-expected.png: Added.
  • platform/chromium/test_expectations.txt:
9:37 PM Changeset in webkit [118892] by haraken@chromium.org
  • 2 edits in trunk/Source/WebCore

Remove a dummy style sheet from CSSParser::parseFlowThread()
​https://bugs.webkit.org/show_bug.cgi?id=87715

Reviewed by Darin Adler.

r118736 changed CSSGrammar.y so that it works fine with no style sheet.
r118736 removed a dummy style sheet from CSSParser::parserSelector().
Now we can safely remove a dummy style sheet from parserFlowThread().

Tests: fast/regions. No change in test results.

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseFlowThread):

9:34 PM Changeset in webkit [118891] by yosin@chromium.org
  • 5 edits in trunk

REGRESSION(r111497): The "option" element doesn't match CSS pseudo class :enabled
​https://bugs.webkit.org/show_bug.cgi?id=87719

Reviewed by Kent Tamura.

Source/WebCore:

This patch added checking of "option" element for CSS pseudo class :enabled as same as
:disabled to selector checker. Before r111497, it was done by using isFormControlElement.
After that revision, HTMLOptionElement was no longer derived from HTMLFormControlElement.

Test: fast/form/select/optgroup-rendering.html

  • css/SelectorChecker.cpp:

(WebCore::SelectorChecker::checkOneSelector): Checking element is option element as same
as PseudoDisabled in PseudoEnabled case.

LayoutTests:

  • platform/chromium-linux/fast/forms/select/optgroup-rendering-expected.png: Updated. Text color of option element is bule from CSS pseudo class option:enabled.
  • platform/chromium/test_expectations.txt: Update comment.
9:20 PM Changeset in webkit [118890] by hayato@chromium.org
  • 5 edits in trunk/Source/WebCore

Introduces ComposedShadowTreeParentWalker, extracted from ComposedShadowTreeWalker.
​https://bugs.webkit.org/show_bug.cgi?id=87004

Reviewed by Dimitri Glazkov.

Introduces a ComposedShadowTreeParentWalker, which is only used
for traversing a parent node (including shadow roots and insertion
points) and get rid of an equivalent function from
ComposedShadowTreeWalker.

Before this patch, there is an inconsistency inside of
ComposedShadowTreeWalker. The Walker uses 'Policy' to decide
whether it should visit shadow roots or not, but
parentIncludingInsertionPointAndShadowRoot() member function
ignores the policy. We can not add an assertion in its
constructor due to this inconsistency. To resolve it, we could
add yet another special policy, but that makes the implementation
complex and may add some overhead in runtime. So separate the
functionality into another class as ComposedShadowTreeParentWalker.

No new tests, no new functionality except for assertion.

  • dom/ComposedShadowTreeWalker.cpp:

(WebCore::ComposedShadowTreeWalker::ComposedShadowTreeWalker):
(WebCore::ComposedShadowTreeParentWalker::ComposedShadowTreeParentWalker):
(WebCore):
(WebCore::ComposedShadowTreeParentWalker::parentIncludingInsertionPointAndShadowRoot):
(WebCore::ComposedShadowTreeParentWalker::traverseParentIncludingInsertionPointAndShadowRoot):

  • dom/ComposedShadowTreeWalker.h:

(ComposedShadowTreeWalker):
(WebCore::ComposedShadowTreeWalker::assertPrecondition):
(WebCore):
(ComposedShadowTreeParentWalker):
(WebCore::ComposedShadowTreeParentWalker::get):

  • dom/EventDispatcher.cpp:

(WebCore::EventRelatedTargetAdjuster::adjust):
(WebCore::EventDispatcher::ensureEventAncestors):

  • page/EventHandler.cpp:

(WebCore::EventHandler::updateMouseEventTargetNode):

9:05 PM Changeset in webkit [118889] by hayato@chromium.org
  • 3 edits in trunk/Source/WebCore

Add assertions to make sure that event's target and relatedTarget are accessible.
​https://bugs.webkit.org/show_bug.cgi?id=87641

Reviewed by Dimitri Glazkov.

No new tests. No new functionality except for assertions.

  • dom/EventContext.cpp:

(WebCore::EventContext::EventContext):

  • dom/EventContext.h:

(WebCore):
(EventContext):
(WebCore::EventContext::setRelatedTarget):
(WebCore::EventContext::accessible):

9:03 PM Changeset in webkit [118888] by tkent@chromium.org
  • 3 edits in trunk/Source/WebCore

Fix inefficient usage of traverseNextNode()
​https://bugs.webkit.org/show_bug.cgi?id=87804

Reviewed by Ryosuke Niwa.

foo->traverseNextNode(foo) is equivalent to foo->firstChild(), and
firstChild() is more efficient.

No new tests because of no behavior change.

  • html/HTMLFieldSetElement.cpp:

(WebCore::HTMLFieldSetElement::invalidateDisabledStateUnder):
Replace traverseNextNode() with firstChild(), and shorten a variable name.

  • svg/SVGSVGElement.cpp:

(WebCore::SVGSVGElement::getElementById):
Replace traverseNextNode() with firstChild().

8:51 PM Changeset in webkit [118887] by commit-queue@webkit.org
  • 4 edits
    1 add in trunk

[BlackBerry] Loading media data with http authentication
​https://bugs.webkit.org/show_bug.cgi?id=84214

Patch by Jonathan Dong <Jonathan Dong> on 2012-05-29
Reviewed by George Staikos.

.:

Added a manual test case which needs user to provide a HTTP server
with HTTP authentication support when loading the specified media
resource. The test case will test if the media resource is successfully
loaded.

  • ManualTests/blackberry/video-load-with-authentication.html: Added.

Source/WebCore:

RIM PR: 117618
Implemented http authentication feature for media by implementing
two interface functions in class MediaPlayerPrivate:
onAuthenticationNeeded(): this function is triggered when MMR
engine requires http authentication. We search the CredentialStorage
to see if we have already stored existing credential information,
or challenge user to provide it.
OnAuthenticationAccepted(): this function is triggered when MMR
engine accepts the credential information, and we need to save
it in CredentialStorage for later use.

Internally reviewed by Max Feil <​mfeil@qnx.com>.

Manual test case: blackberry/video-load-with-authentication.html

  • platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp:

(WebCore::generateProtectionSpaceFromMMRAuthChallenge):
(WebCore):
(WebCore::MediaPlayerPrivate::onAuthenticationNeeded):
(WebCore::MediaPlayerPrivate::onAuthenticationAccepted):

  • platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.h:

(MediaPlayerPrivate):

8:33 PM Changeset in webkit [118886] by morrita@google.com
  • 15 edits in trunk/Source/WebCore

[Shadow DOM] Node distribution should be orthogonal from node attachment
​https://bugs.webkit.org/show_bug.cgi?id=87223

Reviewed by Dimitri Glazkov.

This chagne reorganizes Shadow DOM subtree distribution implementation.

Originally, it was interleaved across attach() of several classes like
InsertionPoint and ShadowRoot. Its invalidation was also mixed as a part of
the style recalculation and detach()-es.

This change extracts these bits of code to a set of ContentDistributor methods, which are
facaded by two ElementShadow API. Following two API are the primary entry points:

  • ElementShadow::ensureDistribution()
  • ElementShadow::invalidateDistribution()

The actual implementations are ContentDistributor::distribute() and
ContentDistributor::invalidate() respectively.

When clients need to traverse composed tree, before attach() for
example, they should call ensureDistribution() to make sure that
the traversal data structure ("the distribution") is ready. When
there is any DOM mutation which can result a composed tree
mutation, then clients should call invalidateDistribution() to
mark the distribution being dated.

Here are such DOM mutations:

  • The children of any ShadowRoots are changed,
  • The children of any InsertionPoints are changed,
  • The children of any host elements are changed,
  • Any insertion point is inserted to or removed from the shadow tree,
  • @select attribute of <content> is modified and
  • New ShadowRoot is added to the shadow tree.

Note that the validity of the distribution is tracked and
unnecessary distribution requests are ignored.

After the invalidation, that shadow subtrees are detached once and
request their re-attachment through the style recalculation.
Then, on the responding style recalculation and attach(), new
distribution will be computed.

No new tests. Covered by existing tests.

  • dom/Element.cpp:

(WebCore::Element::~Element):
(WebCore::Element::childrenChanged):

  • dom/ElementShadow.cpp:

(WebCore::ElementShadow::~ElementShadow):
(WebCore::ElementShadow::addShadowRoot):
(WebCore::ElementShadow::removeAllShadowRoots):
(WebCore::ElementShadow::attach):
(WebCore::ElementShadow::recalcStyle):
(WebCore::ElementShadow::ensureDistribution):
(WebCore::ElementShadow::invalidateDistribution):

  • dom/ElementShadow.h:

(ElementShadow):

  • dom/NodeRenderingContext.cpp:

(WebCore::NodeRenderingContext::NodeRenderingContext):
(WebCore::NodeRendererFactory::createRendererIfNeeded):

  • dom/NodeRenderingContext.h:

(NodeRenderingContext):

  • dom/ShadowRoot.cpp:

(WebCore::ShadowRoot::setApplyAuthorStyles):
(WebCore::ShadowRoot::attach):
(WebCore::ShadowRoot::childrenChanged):
(WebCore):

  • dom/ShadowRoot.h:

(ShadowRoot):

  • html/HTMLFormControlElement.cpp:
  • html/ValidationMessage.cpp:

(WebCore::ValidationMessage::buildBubbleTree):

  • html/shadow/ContentDistributor.cpp:

(WebCore::ContentDistributor::ContentDistributor):
(WebCore::ContentDistributor::~ContentDistributor):
(WebCore::ContentDistributor::findInsertionPointFor):
(WebCore::ContentDistributor::distribute):
(WebCore::ContentDistributor::invalidate):
(WebCore::ContentDistributor::finishInivalidation):
(WebCore::ContentDistributor::distributeSelectionsTo):
(WebCore::ContentDistributor::distributeShadowChildrenTo):
(WebCore::ContentDistributor::invalidateDistributionIn):

  • html/shadow/ContentDistributor.h:

(WebCore::ContentDistributor::needsInvalidation):
(ContentDistributor):
(WebCore::ContentDistributor::needsDistribution):

  • html/shadow/HTMLContentElement.cpp:

(WebCore::HTMLContentElement::parseAttribute):

  • html/shadow/InsertionPoint.cpp:

(WebCore::InsertionPoint::attach):
(WebCore::InsertionPoint::detach):
(WebCore::InsertionPoint::nextTo):
(WebCore::InsertionPoint::previousTo):
(WebCore::InsertionPoint::childrenChanged):

  • html/shadow/InsertionPoint.h:

(WebCore::InsertionPoint::setDistribution):
(WebCore::InsertionPoint::clearDistribution):
(InsertionPoint):

8:30 PM Changeset in webkit [118885] by macpherson@chromium.org
  • 2 edits in trunk/Source/WebCore

Implement post-landing feedback for WebKitCSSTransformValue::customCSSText().
​https://bugs.webkit.org/show_bug.cgi?id=87684

Reviewed by Darin Adler.

Darin provided some style suggesting on ​https://bugs.webkit.org/show_bug.cgi?id=87462 after it landed.
This patch incorporates those suggestions, namely using 0 instead of empty string for UnknownTransformOperation
and WTF_ARRAY_LENGTH instead of hard coding the array length.

Covered by existing transform tests.

  • css/WebKitCSSTransformValue.cpp:

(WebCore):
(WebCore::WebKitCSSTransformValue::customCssText):

8:15 PM Changeset in webkit [118884] by ojan@chromium.org
  • 5 edits
    2 moves in trunk/Tools

Add a linter error for pngs that lack an embedded checksum
​https://bugs.webkit.org/show_bug.cgi?id=87793

Reviewed by Dirk Pranke.

  • Scripts/read-checksum-from-png:
  • Scripts/webkitpy/common/read_checksum_from_png.py: Renamed from Tools/Scripts/webkitpy/layout_tests/read_checksum_from_png.py.

(read_checksum):

  • Scripts/webkitpy/common/read_checksum_from_png_unittest.py: Renamed from Tools/Scripts/webkitpy/layout_tests/read_checksum_from_png_unittest.py.

(ReadChecksumFromPngTest):
(ReadChecksumFromPngTest.test_read_checksum):

  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/style/checkers/png.py:

(PNGChecker.check):

  • Scripts/webkitpy/style/checkers/png_unittest.py:

(PNGCheckerTest.test_check):

7:28 PM Changeset in webkit [118883] by eric@webkit.org
  • 3 edits in trunk/Source/WebCore

Fix ENABLE_IFRAME_SEAMLESS to actually fully disable <iframe seamless>
​https://bugs.webkit.org/show_bug.cgi?id=87646

Reviewed by Adam Barth.

In the process of moving the seamless feature out of github and into bugs.webkit.org
multiple versions of the shouldDisplaySeamlessly function got written
(and moved from HTMLIFrameElement to Document), but only one of them was wrapped
in ENABLE_IFRAME_SEAMLESS. HTMLIFrameElement was checking mayDisplaySeamlessly
directly (as was my original design), which got around the ENABLE_IFRAME_SEAMLESS check.
I've fixed this oversight, and the feature is now off when we tell it to be off.

This is covered by many existing tests. I've verified locally that
all tests fail when ENABLE_IFRAME_SEAMLESS is disabled instead of
only some of them.

  • dom/SecurityContext.h:

(SecurityContext):

  • html/HTMLIFrameElement.cpp:

(WebCore::HTMLIFrameElement::shouldDisplaySeamlessly):

7:18 PM Changeset in webkit [118882] by ojan@chromium.org
  • 3 edits in trunk/Websites/bugs.webkit.org

Show an error in the pretty diff when an image lacks a checksum
​https://bugs.webkit.org/show_bug.cgi?id=87791

Reviewed by Dirk Pranke.

  • PrettyPatch/PrettyPatch.rb:
  • PrettyPatch/PrettyPatch_test.rb:
7:13 PM Changeset in webkit [118881] by hayato@chromium.org
  • 2 edits in trunk/LayoutTests

Refactor shadow-dom-event-dispatching.html.
​https://bugs.webkit.org/show_bug.cgi?id=87626

Reviewed by Dimitri Glazkov.

There are badly named functions in shadow-dom-event-dispatching.html.
e.g. prepareDOMTree1, prepareDOMTree2 and so on.
That should have better namings which make the intention of each test clear.

  • fast/dom/shadow/shadow-dom-event-dispatching.html:
7:01 PM Changeset in webkit [118880] by cevans@google.com
  • 13 edits
    4 copies
    2 deletes in branches/chromium/1132

Merge 117971
BUG=125374
Review URL: ​https://chromiumcodereview.appspot.com/10447082

6:57 PM Changeset in webkit [118879] by cevans@google.com
  • 2 edits in branches/chromium/1132/Source/WebCore

Merge 117957
BUG=128342
Review URL: ​https://chromiumcodereview.appspot.com/10446075

6:55 PM Changeset in webkit [118878] by cevans@google.com
  • 1 edit
    2 copies in branches/chromium/1132

Merge 117792
BUG=127234
Review URL: ​https://chromiumcodereview.appspot.com/10443074

6:52 PM Changeset in webkit [118877] by cevans@google.com
  • 1 edit in branches/chromium/1132/Source/WebCore/rendering/svg/RenderSVGText.cpp

Merge 117977
BUG=128800
Review URL: ​https://chromiumcodereview.appspot.com/10448069

6:51 PM IdlAttributes edited by thakis@chromium.org
(diff)
6:51 PM Changeset in webkit [118876] by cevans@google.com
  • 3 edits
    2 copies in branches/chromium/1132

Merge 117975
BUG=128800
Review URL: ​https://chromiumcodereview.appspot.com/10456022

6:47 PM Changeset in webkit [118875] by cevans@google.com
  • 15 edits
    6 copies in branches/chromium/1132

Merge 117225
BUG=127679
Review URL: ​https://chromiumcodereview.appspot.com/10443073

6:36 PM Changeset in webkit [118874] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Fix warning in preprocessing Source/WebCore/dom/DOMError.idl
​https://bugs.webkit.org/show_bug.cgi?id=87763

Patch by Scott Graham <​scottmg@chromium.org> on 2012-05-29
Reviewed by Adam Barth.

Add newline at end of file to avoid warning:
../dom/DOMError.idl:35:2: warning: no newline at end of file

  • dom/DOMError.idl:
6:33 PM Changeset in webkit [118873] by pilgrim@chromium.org
  • 7 edits in trunk/Source

[Chromium] Move fileExists to Platform.h
​https://bugs.webkit.org/show_bug.cgi?id=87531

Reviewed by Adam Barth.

Part of a refactoring series. See tracking bug 82948.

Source/Platform:

  • chromium/public/Platform.h:

(WebKit::Platform::fileExists):
(Platform):

Source/WebCore:

  • platform/chromium/FileSystemChromium.cpp:

(WebCore::fileExists):

  • platform/chromium/PlatformSupport.h:

(PlatformSupport):

Source/WebKit/chromium:

  • src/PlatformSupport.cpp:

(WebCore):

6:24 PM Changeset in webkit [118872] by cevans@google.com
  • 1 edit
    2 copies in branches/chromium/1132

Merge 118471
BUG=128665
Review URL: ​https://chromiumcodereview.appspot.com/10444080

6:17 PM Changeset in webkit [118871] by rakuco@webkit.org
  • 9 edits
    4 adds in trunk/LayoutTests

[EFL] Gardening after r118845 and r118851.

Apparently some baselines were not updated as expected, fixing
that now.

  • platform/efl/fast/ruby/ruby-text-before-after-content-expected.png: Added.
  • platform/efl/fast/ruby/ruby-text-before-after-content-expected.txt:
  • platform/efl/fast/selectors/166-expected.png:
  • platform/efl/fast/selectors/166-expected.txt:
  • platform/efl/fast/selectors/unqualified-hover-strict-expected.png:
  • platform/efl/fast/selectors/unqualified-hover-strict-expected.txt: Added.
  • platform/efl/svg/batik/text/textAnchor-expected.txt:
  • platform/efl/svg/batik/text/textOnPath3-expected.txt:
  • platform/efl/svg/batik/text/verticalTextOnPath-expected.txt:
  • platform/efl/svg/carto.net/tabgroup-expected.txt:
  • platform/efl/transitions/cross-fade-background-image-expected.txt: Added.
  • platform/efl/transitions/cross-fade-border-image-expected.txt: Added.
6:13 PM Changeset in webkit [118870] by cevans@google.com
  • 1 edit
    2 copies in branches/chromium/1132

Merge 118005
BUG=128204
Review URL: ​https://chromiumcodereview.appspot.com/10453072

6:09 PM Changeset in webkit [118869] by cevans@google.com
  • 1 edit
    2 copies in branches/chromium/1132

Merge 118248
BUG=126475
Review URL: ​https://chromiumcodereview.appspot.com/10442075

6:05 PM Changeset in webkit [118868] by ggaren@apple.com
  • 6 edits in trunk/Source/JavaScriptCore

Rolled back in r118646, now that
​https://bugs.webkit.org/show_bug.cgi?id=87784 is fixed.

​http://trac.webkit.org/changeset/118646
​https://bugs.webkit.org/show_bug.cgi?id=87599

  • heap/Heap.cpp:

(JSC::Heap::collect):

  • heap/MarkedBlock.cpp:

(JSC::MarkedBlock::sweep):

  • heap/MarkedBlock.h:

(JSC):

  • heap/MarkedSpace.cpp:

(JSC):

  • heap/MarkedSpace.h:

(MarkedSpace):

6:04 PM Changeset in webkit [118867] by cevans@google.com
  • 2 edits
    2 copies in branches/chromium/1132

Merge 118592
BUG=120222
Review URL: ​https://chromiumcodereview.appspot.com/10459020

6:00 PM Changeset in webkit [118866] by cevans@google.com
  • 2 edits
    2 copies in branches/chromium/1132

Merge 118236
BUG=129357
Review URL: ​https://chromiumcodereview.appspot.com/10448068

5:56 PM Changeset in webkit [118865] by cevans@google.com
  • 1 edit
    2 copies in branches/chromium/1132

Merge 118249
BUG=129299
Review URL: ​https://chromiumcodereview.appspot.com/10458025

5:47 PM Changeset in webkit [118864] by cevans@google.com
  • 10 edits
    6 copies
    3 deletes in branches/chromium/1132

Merge 117865
BUG=128711
Review URL: ​https://chromiumcodereview.appspot.com/10447080

5:38 PM Changeset in webkit [118863] by cevans@google.com
  • 6 edits
    15 copies in branches/chromium/1132

Merge 117482
BUG=120006
Review URL: ​https://chromiumcodereview.appspot.com/10448067

5:34 PM Changeset in webkit [118862] by haraken@chromium.org
  • 14 edits in trunk/Source/WebCore

[V8] Rename v8Null() to v8NullWithCheck()
​https://bugs.webkit.org/show_bug.cgi?id=87713

Reviewed by Adam Barth.

In IRC, cmarcelo@ pointed out that v8::Null() and v8Null()
are confusing. This patch renames v8Null() to v8NullWithCheck().

No tests. No behavior change.

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateHeader):

  • bindings/scripts/test/V8/V8TestActiveDOMObject.h:

(WebCore::toV8):

  • bindings/scripts/test/V8/V8TestCustomNamedGetter.h:

(WebCore::toV8):

  • bindings/scripts/test/V8/V8TestEventConstructor.h:

(WebCore::toV8):

  • bindings/scripts/test/V8/V8TestEventTarget.h:

(WebCore::toV8):

  • bindings/scripts/test/V8/V8TestException.h:

(WebCore::toV8):

  • bindings/scripts/test/V8/V8TestInterface.h:

(WebCore::toV8):

  • bindings/scripts/test/V8/V8TestMediaQueryListListener.h:

(WebCore::toV8):

  • bindings/scripts/test/V8/V8TestNamedConstructor.h:

(WebCore::toV8):

  • bindings/scripts/test/V8/V8TestNode.h:

(WebCore::toV8):

  • bindings/scripts/test/V8/V8TestObj.h:

(WebCore::toV8):

  • bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h:

(WebCore::toV8):

  • bindings/v8/V8Binding.h:

(WebCore::v8NullWithCheck):
(WebCore::v8DateOrNull):

5:25 PM Changeset in webkit [118861] by commit-queue@webkit.org
  • 3 edits
    8 deletes in trunk

Some Content Security Policy console messages are missing line numbers in JSC
​https://bugs.webkit.org/show_bug.cgi?id=87558

Patch by Christophe Dumez <Christophe Dumez> on 2012-05-29
Reviewed by Adam Barth.

Source/WebCore:

Make ScriptController::eventHandlerPosition() behave the same way on
JSC than V8. This means that TextPosition::minimumPosition() is
returned if parser is null, instead of
TextPosition::belowRangePosition(). The line numbers are now correctly
printed in the output of Content Security Policy tests.

Tests: http/tests/security/contentSecurityPolicy/inline-script-blocked-javascript-url.html

http/tests/security/contentSecurityPolicy/javascript-url-blocked.html

  • bindings/js/ScriptController.cpp:

(WebCore::ScriptController::eventHandlerPosition):

LayoutTests:

Remove Mac/EFL/GTK/Qt-specific expectations for Content Security Policy
tests now that the line numbers are correctly printed.

  • platform/efl/http/tests/security/contentSecurityPolicy/inline-script-blocked-javascript-url-expected.txt: Removed.
  • platform/efl/http/tests/security/contentSecurityPolicy/javascript-url-blocked-expected.txt: Removed.
  • platform/gtk/http/tests/security/contentSecurityPolicy/inline-script-blocked-javascript-url-expected.txt: Removed.
  • platform/gtk/http/tests/security/contentSecurityPolicy/javascript-url-blocked-expected.txt: Removed.
  • platform/mac/http/tests/security/contentSecurityPolicy/inline-script-blocked-javascript-url-expected.txt: Removed.
  • platform/mac/http/tests/security/contentSecurityPolicy/javascript-url-blocked-expected.txt: Removed.
  • platform/qt/http/tests/security/contentSecurityPolicy/inline-script-blocked-javascript-url-expected.txt: Removed.
  • platform/qt/http/tests/security/contentSecurityPolicy/javascript-url-blocked-expected.txt: Removed.
5:03 PM Changeset in webkit [118860] by Stephanie Lewis
  • 2 edits in trunk/Tools

​https://bugs.webkit.org/show_bug.cgi?id=87720
WebProcess is often killed due to being unresponsive on the bots

Reviewed by Alexey Proskuryakov.

Blind attempt to improve flakiness on the bots by reducing the number
of crashes due to an unresponsive process. This helped on my personal machine
under stress conditions. I don't have enough cores to hit the problem
under normal conditions.

  • WebKitTestRunner/TestController.cpp:

(WTR):

4:46 PM Changeset in webkit [118859] by andersca@apple.com
  • 3 edits in trunk/Source/WTF

String should be move enabled/optimized
​https://bugs.webkit.org/show_bug.cgi?id=87596

Reviewed by Andreas Kling.

Add move constructors and move assignment operators to String and AtomicString when building with
compilers that support rvalue references. This gets rid of ref-churn when the source of the
constructor or assignment is a temporary object.

  • wtf/text/AtomicString.h:

(AtomicString):
(WTF::AtomicString::AtomicString):
(WTF::AtomicString::operator=):

  • wtf/text/WTFString.h:

(String):
(WTF::String::String):
(WTF::String::operator=):

4:43 PM Changeset in webkit [118858] by fpizlo@apple.com
  • 6 edits
    3 adds in trunk

DFG should keep captured variables alive until the (inline) return.
​https://bugs.webkit.org/show_bug.cgi?id=87205

Source/JavaScriptCore:

Reviewed by Gavin Barraclough.

Changes the way we do flushing for captured variables and arguments. Instead of flushing
each SetLocal immediately, we flush at kill points. So a SetLocal will cause a Flush of
whatever was live in the variable previously, and a return will cause a Flush of all
captured variables and all arguments.

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::setDirect):
(JSC::DFG::ByteCodeParser::set):
(JSC::DFG::ByteCodeParser::setLocal):
(JSC::DFG::ByteCodeParser::getArgument):
(JSC::DFG::ByteCodeParser::setArgument):
(JSC::DFG::ByteCodeParser::findArgumentPositionForArgument):
(ByteCodeParser):
(JSC::DFG::ByteCodeParser::findArgumentPositionForLocal):
(JSC::DFG::ByteCodeParser::findArgumentPosition):
(JSC::DFG::ByteCodeParser::flush):
(JSC::DFG::ByteCodeParser::flushDirect):
(JSC::DFG::ByteCodeParser::flushArgumentsAndCapturedVariables):
(JSC::DFG::ByteCodeParser::handleInlining):
(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::InlineStackEntry::InlineStackEntry):

  • dfg/DFGCSEPhase.cpp:

(JSC::DFG::CSEPhase::setLocalStoreElimination):
(JSC::DFG::CSEPhase::performNodeCSE):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::forwardSpeculationCheck):

LayoutTests:

Reviewed by Gavin Barraclough.

  • fast/js/dfg-inline-arguments-osr-exit-and-capture-expected.txt: Added.
  • fast/js/dfg-inline-arguments-osr-exit-and-capture.html: Added.
  • fast/js/script-tests/dfg-inline-arguments-osr-exit-and-capture.js: Added.

(foo):
(bar):
(baz):

4:42 PM Changeset in webkit [118857] by shawnsingh@chromium.org
  • 4 edits in trunk/Source

[chromium] make WebTransformationMatrix object usable by non-webkit code
​https://bugs.webkit.org/show_bug.cgi?id=87315

Reviewed by James Robinson.

Source/Platform:

  • chromium/public/WebTransformationMatrix.h:

(WebKit::WebTransformationMatrix::~WebTransformationMatrix):
(WebTransformationMatrix):

Source/WebCore:

This change is covered by existing tests and by whether it
compiles. There should be no changes in behavior.

  • platform/chromium/support/WebTransformationMatrix.cpp:

(WebKit::WebTransformationMatrix::WebTransformationMatrix):
(WebKit::WebTransformationMatrix::operator=):
(WebKit::WebTransformationMatrix::operator==):
(WebKit::WebTransformationMatrix::inverse):
(WebKit::WebTransformationMatrix::to2dTransform):
(WebKit::WebTransformationMatrix::multiply):
(WebKit::WebTransformationMatrix::makeIdentity):
(WebKit::WebTransformationMatrix::translate):
(WebKit::WebTransformationMatrix::translate3d):
(WebKit::WebTransformationMatrix::translateRight3d):
(WebKit::WebTransformationMatrix::scale):
(WebKit::WebTransformationMatrix::scaleNonUniform):
(WebKit::WebTransformationMatrix::scale3d):
(WebKit::WebTransformationMatrix::rotate):
(WebKit::WebTransformationMatrix::rotate3d):
(WebKit::WebTransformationMatrix::skewX):
(WebKit::WebTransformationMatrix::skewY):
(WebKit::WebTransformationMatrix::applyPerspective):
(WebKit::WebTransformationMatrix::blend):
(WebKit::WebTransformationMatrix::hasPerspective):
(WebKit::WebTransformationMatrix::isInvertible):
(WebKit::WebTransformationMatrix::isBackFaceVisible):
(WebKit::WebTransformationMatrix::isIdentity):
(WebKit::WebTransformationMatrix::isIdentityOrTranslation):
(WebKit::WebTransformationMatrix::isIntegerTranslation):
(WebKit::WebTransformationMatrix::m11):
(WebKit::WebTransformationMatrix::setM11):
(WebKit::WebTransformationMatrix::m12):
(WebKit::WebTransformationMatrix::setM12):
(WebKit::WebTransformationMatrix::m13):
(WebKit::WebTransformationMatrix::setM13):
(WebKit::WebTransformationMatrix::m14):
(WebKit::WebTransformationMatrix::setM14):
(WebKit::WebTransformationMatrix::m21):
(WebKit::WebTransformationMatrix::setM21):
(WebKit::WebTransformationMatrix::m22):
(WebKit::WebTransformationMatrix::setM22):
(WebKit::WebTransformationMatrix::m23):
(WebKit::WebTransformationMatrix::setM23):
(WebKit::WebTransformationMatrix::m24):
(WebKit::WebTransformationMatrix::setM24):
(WebKit::WebTransformationMatrix::m31):
(WebKit::WebTransformationMatrix::setM31):
(WebKit::WebTransformationMatrix::m32):
(WebKit::WebTransformationMatrix::setM32):
(WebKit::WebTransformationMatrix::m33):
(WebKit::WebTransformationMatrix::setM33):
(WebKit::WebTransformationMatrix::m34):
(WebKit::WebTransformationMatrix::setM34):
(WebKit::WebTransformationMatrix::m41):
(WebKit::WebTransformationMatrix::setM41):
(WebKit::WebTransformationMatrix::m42):
(WebKit::WebTransformationMatrix::setM42):
(WebKit::WebTransformationMatrix::m43):
(WebKit::WebTransformationMatrix::setM43):
(WebKit::WebTransformationMatrix::m44):
(WebKit::WebTransformationMatrix::setM44):
(WebKit::WebTransformationMatrix::a):
(WebKit::WebTransformationMatrix::setA):
(WebKit::WebTransformationMatrix::b):
(WebKit::WebTransformationMatrix::setB):
(WebKit::WebTransformationMatrix::c):
(WebKit::WebTransformationMatrix::setC):
(WebKit::WebTransformationMatrix::d):
(WebKit::WebTransformationMatrix::setD):
(WebKit::WebTransformationMatrix::e):
(WebKit::WebTransformationMatrix::setE):
(WebKit::WebTransformationMatrix::f):
(WebKit::WebTransformationMatrix::setF):
(WebKit::WebTransformationMatrix::toWebCoreTransform):
(WebKit::WebTransformationMatrix::mapRect):
(WebKit::WebTransformationMatrix::mapPoint):
(WebKit::WebTransformationMatrix::mapQuad):
(WebKit::WebTransformationMatrix::projectPoint):

4:40 PM Changeset in webkit [118856] by ggaren@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

WeakGCMap should be lazy-finalization-safe
​https://bugs.webkit.org/show_bug.cgi?id=87784

Reviewed by Darin Adler.

  • runtime/WeakGCMap.h:

(JSC::WeakGCMap::get): Since this is a map of raw WeakImpl pointers, and
not Weak<T>, we need to verify manually that the WeakImpl is live before
we return its payload.

4:31 PM Changeset in webkit [118855] by dpranke@chromium.org
  • 4 edits in trunk/Tools

webkitpy: rename 'rm' to 'delete' in rebaseline scm output
​https://bugs.webkit.org/show_bug.cgi?id=87779

Reviewed by Eric Seidel.

Update output to match the names in scm.py as per
​https://bugs.webkit.org/show_bug.cgi?id=87451#c26 .

  • Scripts/webkitpy/tool/commands/rebaseline.py:

(RebaselineTest.execute):

  • Scripts/webkitpy/tool/commands/rebaseline_unittest.py:

(test_rebaseline_test_and_print_scm_changes):

  • Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:

(GardeningServerTest.test_rebaselineall):

4:27 PM Changeset in webkit [118854] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WTF

Support WebKit log messages on Android
​https://bugs.webkit.org/show_bug.cgi?id=87773

Patch by Alexandre Elias <​aelias@google.com> on 2012-05-29
Reviewed by Darin Adler.

This sends WebKit log messages to the Android "logcat" facility, as
Android sends stderr to /dev/null.

  • wtf/Assertions.cpp:
4:24 PM Changeset in webkit [118853] by alexis.menard@openbossa.org
  • 38 edits
    3 adds in trunk

[CSS3 Backgrounds and Borders] Implement box-decoration-break parsing.
​https://bugs.webkit.org/show_bug.cgi?id=87678

Reviewed by Eric Seidel.

Source/WebCore:

Implement the parsing part of box-decoration-break. The specification
is located at ​http://www.w3.org/TR/css3-background/#box-decoration-break.
So far Opera implements it. This patch only implements the parsing part of
the property. A following patch will implement the rendering part. Despite
the rendering part missing it improves ​http://css3test.com by 1%.

Test: fast/box-decoration-break/box-decoration-break-parsing.html

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

  • css/CSSParser.cpp:

(WebCore::isValidKeywordPropertyAndValue):
(WebCore::isKeywordPropertyID):

  • css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore):
(WebCore::CSSPrimitiveValue::operator EBoxDecorationBreak):

  • css/CSSProperty.cpp:

(WebCore::CSSProperty::isInheritedProperty):

  • css/CSSPropertyNames.in:
  • css/CSSValueKeywords.in:
  • css/StyleBuilder.cpp:

(WebCore::StyleBuilder::StyleBuilder):

  • rendering/style/RenderStyle.h:
  • rendering/style/RenderStyleConstants.h:
  • rendering/style/StyleBoxData.cpp:

(WebCore::StyleBoxData::StyleBoxData):
(WebCore::StyleBoxData::operator==):

  • rendering/style/StyleBoxData.h:

(WebCore::StyleBoxData::boxDecorationBreak):
(StyleBoxData):

LayoutTests:

Add a new test to cover the parsing part of the new css property. Also rebase the
existing tests which are listing the css properties of the style.

  • fast/box-decoration-break/box-decoration-break-parsing-expected.txt: Added.
  • fast/box-decoration-break/box-decoration-break-parsing.html: Added.
  • fast/css/getComputedStyle/computed-style-expected.txt:
  • fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/chromium-linux-x86/svg/css/getComputedStyle-basic-expected.txt:
  • platform/chromium-linux/svg/css/getComputedStyle-basic-expected.txt:
  • platform/chromium-mac-leopard/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/chromium-mac-leopard/svg/css/getComputedStyle-basic-expected.txt:
  • platform/chromium-mac-snowleopard/svg/css/getComputedStyle-basic-expected.txt:
  • platform/chromium-mac/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/chromium-mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/chromium-mac/svg/css/getComputedStyle-basic-expected.txt:
  • platform/chromium-win-vista/svg/css/getComputedStyle-basic-expected.txt:
  • platform/chromium-win-xp/svg/css/getComputedStyle-basic-expected.txt:
  • platform/chromium-win/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/chromium-win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt:
  • platform/gtk/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/gtk/svg/css/getComputedStyle-basic-expected.txt:
  • platform/mac/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/mac/svg/css/getComputedStyle-basic-expected.txt:
  • platform/qt/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/qt/svg/css/getComputedStyle-basic-expected.txt:
  • platform/win/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • svg/css/getComputedStyle-basic-expected.txt:
4:20 PM Changeset in webkit [118852] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

[text-overflow: ellipsis] WebKit should ignore the ellipsis for the purpose of dispatching mouse events
​https://bugs.webkit.org/show_bug.cgi?id=63781

Patch by David Barr <​davidbarr@chromium.org> on 2012-05-29
Reviewed by Eric Seidel.

Source/WebCore:

"Ellipsing only affects rendering and must not affect layout nor dispatching of pointer events."
​http://www.w3.org/TR/2012/WD-css3-ui-20120117/#text-overflow

Test: fast/css/text-overflow-ellipsis-hit-test.html

  • rendering/EllipsisBox.cpp:

(WebCore::EllipsisBox::nodeAtPoint): Always return false.

LayoutTests:

  • fast/css/text-overflow-ellipsis-hit-test-expected.txt: Added.
  • fast/css/text-overflow-ellipsis-hit-test.html: Added.
4:15 PM Changeset in webkit [118851] by rakuco@webkit.org
  • 73 edits in trunk/LayoutTests

[EFL] Unreviewed gardening.

Unskip a lot of fast/selectors tests which were really passing all
the time, they just needed updated baselines after the jhbuild and
font commits.

  • platform/efl/Skipped:
  • platform/efl/fast/selectors/001-expected.png:
  • platform/efl/fast/selectors/002-expected.png:
  • platform/efl/fast/selectors/003-expected.png:
  • platform/efl/fast/selectors/004-expected.png:
  • platform/efl/fast/selectors/005-expected.png:
  • platform/efl/fast/selectors/006-expected.png:
  • platform/efl/fast/selectors/007a-expected.png:
  • platform/efl/fast/selectors/007b-expected.png:
  • platform/efl/fast/selectors/008-expected.png:
  • platform/efl/fast/selectors/009-expected.png:
  • platform/efl/fast/selectors/010-expected.png:
  • platform/efl/fast/selectors/011-expected.png:
  • platform/efl/fast/selectors/012-expected.png:
  • platform/efl/fast/selectors/013-expected.png:
  • platform/efl/fast/selectors/014-expected.png:
  • platform/efl/fast/selectors/015-expected.png:
  • platform/efl/fast/selectors/018-expected.png:
  • platform/efl/fast/selectors/018b-expected.png:
  • platform/efl/fast/selectors/021-expected.png:
  • platform/efl/fast/selectors/021b-expected.png:
  • platform/efl/fast/selectors/032-expected.png:
  • platform/efl/fast/selectors/034-expected.png:
  • platform/efl/fast/selectors/038-expected.png:
  • platform/efl/fast/selectors/040-expected.png:
  • platform/efl/fast/selectors/043-expected.png:
  • platform/efl/fast/selectors/043b-expected.png:
  • platform/efl/fast/selectors/044-expected.png:
  • platform/efl/fast/selectors/044b-expected.png:
  • platform/efl/fast/selectors/044c-expected.png:
  • platform/efl/fast/selectors/044d-expected.png:
  • platform/efl/fast/selectors/045-expected.png:
  • platform/efl/fast/selectors/045b-expected.png:
  • platform/efl/fast/selectors/045c-expected.png:
  • platform/efl/fast/selectors/046-expected.png:
  • platform/efl/fast/selectors/054-expected.png:
  • platform/efl/fast/selectors/056-expected.png:
  • platform/efl/fast/selectors/058-expected.png:
  • platform/efl/fast/selectors/059-expected.png:
  • platform/efl/fast/selectors/060-expected.png:
  • platform/efl/fast/selectors/061-expected.png:
  • platform/efl/fast/selectors/063-expected.png:
  • platform/efl/fast/selectors/064-expected.png:
  • platform/efl/fast/selectors/066-expected.png:
  • platform/efl/fast/selectors/066b-expected.png:
  • platform/efl/fast/selectors/072-expected.png:
  • platform/efl/fast/selectors/072b-expected.png:
  • platform/efl/fast/selectors/077-expected.png:
  • platform/efl/fast/selectors/077b-expected.png:
  • platform/efl/fast/selectors/078b-expected.png:
  • platform/efl/fast/selectors/083-expected.png:
  • platform/efl/fast/selectors/087b-expected.png:
  • platform/efl/fast/selectors/090b-expected.png:
  • platform/efl/fast/selectors/154-expected.png:
  • platform/efl/fast/selectors/155-expected.png:
  • platform/efl/fast/selectors/155a-expected.png:
  • platform/efl/fast/selectors/155b-expected.png:
  • platform/efl/fast/selectors/155c-expected.png:
  • platform/efl/fast/selectors/155d-expected.png:
  • platform/efl/fast/selectors/156b-expected.png:
  • platform/efl/fast/selectors/157-expected.png:
  • platform/efl/fast/selectors/158-expected.png:
  • platform/efl/fast/selectors/160-expected.png:
  • platform/efl/fast/selectors/168-expected.png:
  • platform/efl/fast/selectors/168a-expected.png:
  • platform/efl/fast/selectors/169-expected.png:
  • platform/efl/fast/selectors/169a-expected.png:
  • platform/efl/fast/selectors/lang-inheritance-expected.png:
  • platform/efl/fast/selectors/lang-inheritance2-expected.png:
  • platform/efl/fast/selectors/lang-vs-xml-lang-expected.png:
  • platform/efl/fast/selectors/lang-vs-xml-lang-xhtml-expected.png:
  • platform/efl/fast/selectors/visited-descendant-expected.png:
4:12 PM Changeset in webkit [118850] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebKit/blackberry

[BlackBerry] WebOverlay build fixes and bug fixes
​https://bugs.webkit.org/show_bug.cgi?id=87780

Patch by Arvid Nilsson <​anilsson@rim.com> on 2012-05-29
Reviewed by Rob Buis.

Fix build when accelerated compositing disabled, or debug build.

Also fix a bug where the selection overlay would not disappear properly
because of a typo in WebPage::removeOverlay(). Also convert said method
to early return style.

Debug build fixes contributed by Ming Xie.

  • Api/WebOverlay.cpp:

(BlackBerry::WebKit::WebOverlay::addAnimation):
(BlackBerry::WebKit::WebOverlay::setContentsToImage):
(WebKit):
(BlackBerry::WebKit::WebOverlay::setContentsToColor):
(BlackBerry::WebKit::WebOverlay::setDrawsContent):
(BlackBerry::WebKit::WebOverlay::invalidate):
(BlackBerry::WebKit::WebOverlay::setClient):
(BlackBerry::WebKit::WebOverlay::override):
(BlackBerry::WebKit::WebOverlay::resetOverrides):

  • Api/WebOverlayOverride.cpp:

(BlackBerry::WebKit::WebOverlayOverride::WebOverlayOverride):

  • Api/WebOverlay_p.h:

(BlackBerry::WebKit::WebOverlayPrivate::~WebOverlayPrivate):

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPage::removeOverlay):
(BlackBerry::WebKit::WebPage::addCompositingThreadOverlay):
(BlackBerry::WebKit::WebPage::removeCompositingThreadOverlay):

4:12 PM Changeset in webkit [118849] by jberlin@webkit.org
  • 1 edit
    11 adds in trunk/LayoutTests

<progress> element is unsupported on Windows
​https://bugs.webkit.org/show_bug.cgi?id=49769

Add platform-specific results for tests that use the progress element on Windows.

  • platform/win/fast/forms/label: Added.
  • platform/win/fast/forms/label/labelable-elements-expected.txt: Added.
  • platform/win/fast/forms/label/labels-add-htmlFor-label-expected.txt: Added.
  • platform/win/fast/forms/label/labels-add-parent-label-expected.txt: Added.
  • platform/win/fast/forms/label/labels-change-htmlFor-attribute-expected.txt: Added.
  • platform/win/fast/forms/label/labels-multiple-sibling-labels-expected.txt: Added.
  • platform/win/fast/forms/label/labels-parent-and-sibling-labels-expected.txt: Added.
  • platform/win/fast/forms/label/labels-remove-htmlFor-attribute-expected.txt: Added.
  • platform/win/fast/forms/label/labels-remove-htmlFor-label-expected.txt: Added.
  • platform/win/fast/forms/label/labels-remove-parent-label-expected.txt: Added.
  • platform/win/fast/forms/label/labels-set-htmlFor-attribute-expected.txt: Added.
4:07 PM Changeset in webkit [118848] by gavinp@chromium.org
  • 3 edits in trunk/Source/WebCore

[Chromium] Remove assertions on state in Prerender.cpp
​https://bugs.webkit.org/show_bug.cgi?id=87746

Chrome was crashing in the new Prerender API on Google Web Search; this was because the DOM would stop(), setting the
state of the Prerenders in the document to Inactive, but an asyncronous GC would later come come along and trigger the
removedFromDocument behaviour on each element, including the <link> element launching the prerender. This causes an
assertion failure.

I believe the late-deletion of the DOM, and the HTMLElement::removedFromDocument calls are legal, and it was the
overzealous assertions in Prerender that were inappropriate.

Reviewed by Adam Barth.

No new automated tests, working on a Chromium browser test. Manually test by entering many prerender and non-prerendered
queries into Google Web Search.

  • platform/chromium/Prerender.cpp:

(WebCore::Prerender::Prerender):
(WebCore::Prerender::add):
(WebCore::Prerender::cancel):
(WebCore::Prerender::abandon):

  • platform/chromium/Prerender.h:

(Prerender):

3:59 PM Changeset in webkit [118847] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Add malloc info to about:memory page
​https://bugs.webkit.org/show_bug.cgi?id=87676

Patch by Yong Li <​yoli@rim.com> on 2012-05-29
Reviewed by Rob Buis.

Detailed malloc info can tell us how much memory
in the heaps is being in use.

  • WebCoreSupport/AboutData.cpp:

(WebCore::memoryPage):

3:59 PM Changeset in webkit [118846] by rafaelw@chromium.org
  • 2 edits in trunk/LayoutTests

Updating test expectation (media/track/track-cues-missed CRASH).

  • platform/chromium/test_expectations.txt:
3:53 PM Changeset in webkit [118845] by rakuco@webkit.org
  • 10 edits
    70 adds in trunk/LayoutTests

[EFL] Unreviewed gardening.

House cleaning on Skipped: remove tests which do not exist, unskip
some which are passing and add expectations for some which were
lacking them.

  • platform/efl/Skipped:
  • platform/efl/editing/selection/fake-doubleclick-expected.png: Added.
  • platform/efl/editing/selection/fake-doubleclick-expected.txt: Added.
  • platform/efl/fast/borders/border-image-slice-constrained-expected.png: Added.
  • platform/efl/fast/borders/border-image-slice-constrained-expected.txt: Added.
  • platform/efl/fast/borders/border-mixed-alpha-expected.png: Added.
  • platform/efl/fast/borders/borderRadiusArcs01-expected.txt: Added.
  • platform/efl/fast/borders/borderRadiusDouble01-expected.txt: Added.
  • platform/efl/fast/borders/borderRadiusDouble02-expected.txt: Added.
  • platform/efl/fast/borders/borderRadiusDouble03-expected.txt: Added.
  • platform/efl/fast/borders/borderRadiusGroove01-expected.txt: Added.
  • platform/efl/fast/borders/borderRadiusGroove02-expected.txt: Added.
  • platform/efl/fast/borders/borderRadiusInset01-expected.txt: Added.
  • platform/efl/fast/borders/borderRadiusOutset01-expected.txt: Added.
  • platform/efl/fast/borders/borderRadiusRidge01-expected.txt: Added.
  • platform/efl/fast/borders/scaled-border-image-expected.png: Added.
  • platform/efl/fast/borders/scaled-border-image-expected.txt: Added.
  • platform/efl/fast/forms/input-appearance-disabled-expected.png: Added.
  • platform/efl/fast/forms/input-appearance-disabled-expected.txt: Added.
  • platform/efl/fast/forms/input-appearance-readonly-expected.png: Added.
  • platform/efl/fast/forms/input-appearance-readonly-expected.txt: Added.
  • platform/efl/fast/forms/input-placeholder-visibility-3-expected.png: Added.
  • platform/efl/fast/forms/input-placeholder-visibility-3-expected.txt: Added.
  • platform/efl/fast/forms/textarea-placeholder-visibility-1-expected.png: Added.
  • platform/efl/fast/forms/textarea-placeholder-visibility-1-expected.txt: Added.
  • platform/efl/fast/forms/textarea-placeholder-visibility-2-expected.png: Added.
  • platform/efl/fast/forms/textarea-placeholder-visibility-2-expected.txt: Added.
  • platform/efl/fast/forms/textarea-scrollbar-expected.png: Added.
  • platform/efl/fast/forms/textarea-scrollbar-expected.txt: Added.
  • platform/efl/fast/line-grid/line-grid-floating-expected.png: Added.
  • platform/efl/fast/line-grid/line-grid-floating-expected.txt: Added.
  • platform/efl/fast/line-grid/line-grid-inside-columns-expected.png: Added.
  • platform/efl/fast/line-grid/line-grid-inside-columns-expected.txt: Added.
  • platform/efl/fast/line-grid/line-grid-into-floats-expected.png: Added.
  • platform/efl/fast/line-grid/line-grid-into-floats-expected.txt: Added.
  • platform/efl/fast/line-grid/line-grid-positioned-expected.png: Added.
  • platform/efl/fast/line-grid/line-grid-positioned-expected.txt: Added.
  • platform/efl/fast/repaint/4774354-expected.png: Added.
  • platform/efl/fast/repaint/4774354-expected.txt: Added.
  • platform/efl/fast/repaint/4776765-expected.png: Added.
  • platform/efl/fast/repaint/4776765-expected.txt: Added.
  • platform/efl/fast/repaint/delete-into-nested-block-expected.png: Added.
  • platform/efl/fast/repaint/delete-into-nested-block-expected.txt: Added.
  • platform/efl/fast/repaint/inline-outline-repaint-expected.png: Added.
  • platform/efl/fast/repaint/inline-outline-repaint-expected.txt: Added.
  • platform/efl/fast/repaint/selection-after-delete-expected.png: Added.
  • platform/efl/fast/repaint/selection-after-delete-expected.txt: Added.
  • platform/efl/fast/selectors/159-expected.png: Added.
  • platform/efl/fast/selectors/159-expected.txt: Added.
  • platform/efl/fast/selectors/177a-expected.png: Added.
  • platform/efl/fast/selectors/177a-expected.txt: Added.
  • platform/efl/fast/spatial-navigation/snav-multiple-select-focusring-expected.png: Added.
  • platform/efl/fast/spatial-navigation/snav-multiple-select-focusring-expected.txt: Added.
  • platform/efl/fast/table/colspanMinWidth-vertical-expected.png:
  • platform/efl/fast/table/colspanMinWidth-vertical-expected.txt:
  • platform/efl/fast/text/delete-hard-break-character-expected.png: Added.
  • platform/efl/fast/text/delete-hard-break-character-expected.txt: Added.
  • platform/efl/fast/writing-mode/japanese-ruby-horizontal-bt-expected.png: Added.
  • platform/efl/fast/writing-mode/japanese-ruby-horizontal-bt-expected.txt: Added.
  • platform/efl/mathml/presentation/roots-expected.png: Added.
  • platform/efl/mathml/presentation/roots-expected.txt: Added.
  • platform/efl/mathml/presentation/row-alignment-expected.png: Added.
  • platform/efl/mathml/presentation/row-alignment-expected.txt: Added.
  • platform/efl/media/controls-styling-expected.png: Added.
  • platform/efl/media/controls-styling-expected.txt: Added.
  • platform/efl/svg/batik/text/textAnchor-expected.png: Added.
  • platform/efl/svg/batik/text/textOnPath3-expected.png: Added.
  • platform/efl/svg/batik/text/verticalTextOnPath-expected.png: Added.
  • platform/efl/svg/carto.net/tabgroup-expected.png: Added.
  • platform/efl/transitions/cross-fade-background-image-expected.png: Added.
  • platform/efl/transitions/cross-fade-border-image-expected.png: Added.
  • platform/efl/transitions/default-timing-function-expected.png:
  • platform/efl/transitions/default-timing-function-expected.txt:
  • platform/efl/transitions/move-after-transition-expected.png:
  • platform/efl/transitions/move-after-transition-expected.txt:
  • platform/efl/transitions/svg-text-shadow-transition-expected.png:
  • platform/efl/transitions/svg-text-shadow-transition-expected.txt:
3:37 PM Changeset in webkit [118844] by jamesr@google.com
  • 16 edits in branches/chromium/1132

Merge 118261 - [chromium] Turn ENABLE(OVERFLOW_SCROLLING) off for Chromium port
​https://bugs.webkit.org/show_bug.cgi?id=87177

Reviewed by Eric Seidel.

Source/WebKit/chromium:

Removes ENABLE(OVERFLOW_SCROLLING) from the set of enables set by Chromium. This guards a new non-standard
CSS property, -webkit-overflow-scrolling, that was introduced by iOS5 intended for mobile browsers. This
property is very partially implemented in Chromium but the way it's implemented does cause new stacking contexts
to be created that otherwise would not be, breaking "desktop" pages.

This turns the feature off until we can figure out how to deal with the compatibility issues.

  • features.gypi:

LayoutTests:

Mark test depending on ENABLE(OVERFLOW_SCROLLING) as an expected failure since the define is off.

  • platform/chromium/test_expectations.txt:

TBR=​jamesr@google.com
BUG=124559
Review URL: ​https://chromiumcodereview.appspot.com/10447078

3:36 PM Changeset in webkit [118843] by rafaelw@chromium.org
  • 2 edits in trunk/LayoutTests

Updating test expectations (fast/forms/form-associated-element-removal MISSING).

  • platform/chromium/test_expectations.txt:
3:33 PM Changeset in webkit [118842] by Stephanie Lewis
  • 2 edits in trunk/Tools

​https://bugs.webkit.org/show_bug.cgi?id=87711

Reviewed by Jessie Berlin.

Remove Snowleopard testers so the hardware can be repurposed. The lion bots
are better maintained.

  • BuildSlaveSupport/build.webkit.org-config/config.json:
3:28 PM Changeset in webkit [118841] by commit-queue@webkit.org
  • 8 edits
    2 moves in trunk

Display cues in the controls area
​https://bugs.webkit.org/show_bug.cgi?id=87591

Patch by Victor Carbune <​victor@rosedu.org> on 2012-05-29
Reviewed by Eric Carlson.

Source/WebCore:

Changed the behaviour to implicitly hide the volume slidebar
if the controls are hidden (due mouse moving out of the video
area or controls are toggled through JS).

This seems to be the simplest fix to this issue, otherwise
on toggling the display:none property on the controls the
volume slidebar might appear below the video.

Re-enabled failing tests for this functionality.

  • html/shadow/MediaControlElements.cpp:

(WebCore::MediaControlPanelElement::makeTransparent): Re-enabled
timer to set the display:none property on the controls.

  • html/shadow/MediaControlRootElement.cpp:

(WebCore::MediaControlRootElement::hide): Added a call to hide
the volume slider.
(WebCore::MediaControlRootElement::makeTransparent): Same.

  • html/shadow/MediaControlRootElementChromium.cpp:

(WebCore::MediaControlRootElementChromium::hide): Same.
(WebCore::MediaControlRootElementChromium::makeTransparent): Same.

LayoutTests:

  • media/media-volume-slider-rendered-normal-expected.txt: Renamed from LayoutTests/media/video-controls-rendering-toggle-display-none-expected.txt.
  • media/media-volume-slider-rendered-normal.html: Renamed from LayoutTests/media/video-controls-rendering-toggle-display-none.html.
  • platform/chromium/test_expectations.txt: Unmarked tests.
  • platform/efl/test_expectations.txt: Unmarked tests.
  • platform/mac/test_expectations.txt: Unmarked tests.
3:24 PM Changeset in webkit [118840] by enne@google.com
  • 2 edits in trunk/Source/WebCore

Fix transparent iframes with composited contents in WK1 on Mac
​https://bugs.webkit.org/show_bug.cgi?id=76478

Reviewed by Simon Fraser.

Test: compositing/iframes/repaint-after-losing-scrollbars.html

  • page/FrameView.cpp:

(WebCore::FrameView::useSlowRepaints):

3:22 PM Changeset in webkit [118839] by hyatt@apple.com
  • 9 edits in trunk/Source/WebCore

​https://bugs.webkit.org/show_bug.cgi?id=87787

[New Multicolumn] Refactor the region and flow thread code so that it can pick up the correct column widths
and heights when determining the logical width and height of the flow thread itself.

This patch adds new virtual methods to RenderRegion: logicalWidthForFlowThreadContent and logicalHeightForFlowThreadContent.
For normal regions, these methods return the contentWidth and contentHeight of the regions themselves. For column sets,
however, these methods actually return the column widths and heights.

This allows the flow thread to properly lay out according to the column width.

Region invalidation is also done properly by using these new methods.

In some cases the code is actually simplified, since we can get rid of some isHorizontalWritingMode() switching.

With this patch the flow thread now actually lays out and paints at the right width (spilling out of the region set in a single unbroken
column).

Reviewed by Dan Bernstein.

  • rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::layout):
(WebCore::RenderFlowThread::computeLogicalWidth):
(WebCore::RenderFlowThread::computeLogicalHeight):

  • rendering/RenderMultiColumnBlock.cpp:

(WebCore::RenderMultiColumnBlock::ensureColumnSets):

  • rendering/RenderMultiColumnBlock.h:

(WebCore::RenderMultiColumnBlock::isRenderMultiColumnBlock):
(RenderMultiColumnBlock):
(WebCore::toRenderMultiColumnBlock):
(WebCore):

  • rendering/RenderMultiColumnSet.cpp:

(WebCore::RenderMultiColumnSet::computeLogicalWidth):
(WebCore):
(WebCore::RenderMultiColumnSet::computeLogicalHeight):

  • rendering/RenderMultiColumnSet.h:

(WebCore::RenderMultiColumnSet::setColumnWidthAndCount):
(RenderMultiColumnSet):

  • rendering/RenderObject.h:

(WebCore::RenderObject::isRenderMultiColumnBlock):

  • rendering/RenderRegion.cpp:

(WebCore::RenderRegion::logicalWidthForFlowThreadContent):
(WebCore):
(WebCore::RenderRegion::logicalHeightForFlowThreadContent):
(WebCore::RenderRegion::layout):

  • rendering/RenderRegion.h:

(RenderRegion):

2:46 PM Changeset in webkit [118838] by dpranke@chromium.org
  • 2 edits in trunk/Tools

webkit-patch optimize-baselines should add/delete files in batches from the vcs
​https://bugs.webkit.org/show_bug.cgi?id=87538

Reviewed by Ojan Vafai.

Invoking git and svn on one file at a time is kinda slow. We
should batch the add and rm operations together.

  • Scripts/webkitpy/common/checkout/baselineoptimizer.py:

(BaselineOptimizer._move_baselines):

2:39 PM Changeset in webkit [118837] by rakuco@webkit.org
  • 2 edits
    2 adds in trunk/LayoutTests

[EFL] Gardening. Unskip passing test.

  • platform/efl/Skipped:
  • platform/efl/editing/input/emacs-ctrl-o-expected.png: Added.
  • platform/efl/editing/input/emacs-ctrl-o-expected.txt: Added.
2:30 PM Changeset in webkit [118836] by dpranke@chromium.org
  • 9 edits in trunk/Tools

garden-o-matic should rebaseline baselines in parallel
​https://bugs.webkit.org/show_bug.cgi?id=87451

Reviewed by Ojan Vafai.

This modifies garden-o-matic so that we will fetch all
of the baselines in parallel from the bots, and then
optimize the baselines serially (since that should be fairly
quick and we get into trouble if we optimize in parallel due
to concurrent access to the source control system).

This change adds a flag to webkit-patch rebaseline-test (--print-scm-changes)
so that the files that need to be modified in the SCM are returned to
garden-o-matic rather than actually added or removed. This is done so that
we can run multiple rebaseline-tests in parallel (we can't modify the SCM
concurrently). In order to safely return the files (as a JSON dict) I
needed to shift all of the logging in rebaseline-test to use the logging
module (and hence log to stderr).

I also had to stub out a line in chromium.py that would get confused if
the skia overrides file didn't exist in a mock checkout.

  • Scripts/webkitpy/common/system/executive.py:

(Executive.popen):
(Executive):
(Executive.run_in_parallel):
(_run_command_thunk):

  • Scripts/webkitpy/common/system/executive_mock.py:

(MockExecutive.run_in_parallel):

  • Scripts/webkitpy/common/system/executive_unittest.py:

(ExecutiveTest.test_run_in_parallel):

  • Scripts/webkitpy/layout_tests/port/chromium.py:

(ChromiumPort._expectations_file_contents):

  • Scripts/webkitpy/tool/commands/rebaseline.py:

(AbstractRebaseliningCommand.init):
(RebaselineTest.init):
(RebaselineTest._copy_existing_baseline):
(RebaselineTest._save_baseline):
(RebaselineTest):
(RebaselineTest._add_to_scm):
(RebaselineTest._rebaseline_test):
(RebaselineTest.execute):
(RebaselineExpectations._rebaseline_port):
(RebaselineExpectations.execute):
(Rebaseline._builder_to_pull_from):
(Rebaseline.execute):

  • Scripts/webkitpy/tool/commands/rebaseline_unittest.py:

(test_rebaseline_updates_expectations_file):
(test_rebaseline_test):
(test_rebaseline_test_and_print_scm_changes):
(test_rebaseline_and_copy_test):
(test_rebaseline_and_copy_test_no_existing_result):
(test_rebaseline_and_copy_test_with_lion_result):
(test_rebaseline_and_copy_no_overwrite_test):
(test_rebaseline_expectations):

  • Scripts/webkitpy/tool/servers/gardeningserver.py:

(GardeningHTTPRequestHandler._rebaseline_commands):
(GardeningHTTPRequestHandler):
(GardeningHTTPRequestHandler._files_to_add):
(GardeningHTTPRequestHandler._optimize_baselines):
(GardeningHTTPRequestHandler.rebaselineall):

  • Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:

(GardeningServerTest._post_to_path):
(GardeningServerTest.test_rebaselineall):
(GardeningServerTest.test_rebaselineall.run_command):

2:20 PM Changeset in webkit [118835] by commit-queue@webkit.org
  • 17 edits in trunk

IndexedDB: Align codes and names for IDB-specific and DOM-specific errors/exceptions
​https://bugs.webkit.org/show_bug.cgi?id=87276

Patch by Alec Flett <​alecflett@chromium.org> on 2012-05-29
Reviewed by Tony Chang.

Source/WebCore:

No new tests. Existing tests have been updated to use the new
exception constant values.

The IDB spec has evolved to DOM4-style DOMExceptions, which are
referred to with MixedCase, string-based style names for
exceptions rather than UNDERSCORE_CONSTANT_ERR codes. Change to
use MixedCase error/exception names, and tease out the
IDB-specific exception/error codes/names from the system-level
codes. Make sure that the legacy IDB-masked exception code values
match the DOM exception values. Make sure that
IDBDatabaseException[exception.name] still works.

  • Modules/indexeddb/IDBDatabase.cpp:

(WebCore::IDBDatabase::createObjectStore):
(WebCore::IDBDatabase::transaction):

  • Modules/indexeddb/IDBDatabaseBackendImpl.cpp:

(WebCore::IDBDatabaseBackendImpl::deleteObjectStore):
(WebCore::IDBDatabaseBackendImpl::setVersion):
(WebCore::IDBDatabaseBackendImpl::transaction):

  • Modules/indexeddb/IDBDatabaseException.cpp:

(IDBDatabaseExceptionNameDescription):
(WebCore):
(WebCore::IDBDatabaseException::initializeDescription):

  • Modules/indexeddb/IDBDatabaseException.h:
  • Modules/indexeddb/IDBDatabaseException.idl:
  • Modules/indexeddb/IDBObjectStore.cpp:

(WebCore::IDBObjectStore::createIndex):

  • Modules/indexeddb/IDBObjectStoreBackendImpl.cpp:

(WebCore::IDBObjectStoreBackendImpl::index):
(WebCore::IDBObjectStoreBackendImpl::deleteIndex):

  • Modules/indexeddb/IDBRequest.cpp:

(WebCore::IDBRequest::abort):

  • Modules/indexeddb/IDBTransactionBackendImpl.cpp:

(WebCore::IDBTransactionBackendImpl::objectStore):

Source/WebKit/chromium:

  • public/WebIDBDatabaseException.h:
  • src/AssertMatchingEnums.cpp:

LayoutTests:

  • storage/indexeddb/constants-expected.txt:
  • storage/indexeddb/resources/constants.js:

(test):

2:17 PM Changeset in webkit [118834] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening, skip new failing tests
because of missing LayoutTestController implementation.

  • platform/qt/Skipped:
2:13 PM Changeset in webkit [118833] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Unskip scroll related layout tests
​https://bugs.webkit.org/show_bug.cgi?id=87765

Unreviewed EFL gardening.

Patch by Alexander Shalamov <​alexander.shalamov@intel.com> on 2012-05-29

  • platform/efl/Skipped:
2:13 PM Changeset in webkit [118832] by hyatt@apple.com
  • 5 edits in trunk/Source/WebCore

​https://bugs.webkit.org/show_bug.cgi?id=87775

[New Multicolumn] Make sure RenderMultiColumnSets have their own copy of the count, width and height of their columns.

Reviewed by Anders Carlsson.

  • rendering/RenderMultiColumnBlock.cpp:

(WebCore::RenderMultiColumnBlock::RenderMultiColumnBlock):
(WebCore::RenderMultiColumnBlock::ensureColumnSets):

  • rendering/RenderMultiColumnBlock.h:

(WebCore::RenderMultiColumnBlock::columnWidth):
(WebCore::RenderMultiColumnBlock::columnCount):
(RenderMultiColumnBlock):

  • rendering/RenderMultiColumnSet.cpp:

(WebCore::RenderMultiColumnSet::RenderMultiColumnSet):

  • rendering/RenderMultiColumnSet.h:

(WebCore::RenderMultiColumnSet::columnCount):
(WebCore::RenderMultiColumnSet::columnWidth):
(WebCore::RenderMultiColumnSet::columnHeight):
(RenderMultiColumnSet):
(WebCore::RenderMultiColumnSet::setColumnWidthAndCount):
(WebCore::RenderMultiColumnSet::setColumnHeight):

1:58 PM Changeset in webkit [118831] by jberlin@webkit.org
  • 2 edits in trunk/LayoutTests

AX: windows DRT needs to implement ::press
​https://bugs.webkit.org/show_bug.cgi?id=36145

Add more tests that use press to the Windows Skipped list.

  • platform/win/Skipped:
1:56 PM Changeset in webkit [118830] by ap@apple.com
  • 2 edits in trunk/LayoutTests

fast/events/message-port-close.html hits ASSERT in Debug
​https://bugs.webkit.org/show_bug.cgi?id=85811

  • platform/mac/Skipped: I think that it's just this one test with a delayed effect. Skipping it, and unskipping a victim.
1:49 PM Changeset in webkit [118829] by rafaelw@chromium.org
  • 2 edits in trunk/LayoutTests

Updating chromium test_expectations (svg/dom/viewspec-parser timeouts)

  • platform/chromium/test_expectations.txt:
1:49 PM Changeset in webkit [118828] by Simon Fraser
  • 5 edits
    1 add in trunk

Incomplete repaint on twitter.com when replying to a tweet
​https://bugs.webkit.org/show_bug.cgi?id=87553

Reviewed by Dean Jackson.

Manual test that adds a transform to a layer, forcing that
layer to gain backing store.

  • ManualTests/compositing/requires-backing-change.html: Added.

Source/WebCore:

Reviewed by Dean Jackson.

Style changes can cause a compositing layer to change between
requiring its own backing store or not, e.g. with the addition
or removal of a transform.

When that happens, we need to repaint the ancesetor layer that
this layer was, or will be drawing into.

Factored some code out of layerWillBeRemoved() to be able to
also call it from setRequiresOwnBackingStore().

New manual test, ManualTests/compositing/requires-backing-change.html.
I was not able to get an automated pixel test to work.

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::setRequiresOwnBackingStore):

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::updateCompositingLayers): Remove trailing whitespace.
(WebCore::RenderLayerCompositor::repaintInCompositedAncestor):
(WebCore::RenderLayerCompositor::layerWillBeRemoved):

  • rendering/RenderLayerCompositor.h:
1:35 PM Changeset in webkit [118827] by jberlin@webkit.org
  • 3 edits in trunk/LayoutTests

JSC doesn't support heap profiling.
​https://bugs.webkit.org/show_bug.cgi?id=50485

Add another heap profiling test to the Mac and Windows Skipped lists.

  • platform/mac/Skipped:
  • platform/win/Skipped:
1:27 PM Changeset in webkit [118826] by hyatt@apple.com
  • 3 edits in trunk/Source/WebCore

​https://bugs.webkit.org/show_bug.cgi?id=87771

[New Multicolumn] Make sure we have one column set by default and add it to the flow thread's region list.

Reviewed by Anders Carlsson.

  • rendering/RenderMultiColumnBlock.cpp:

(WebCore::RenderMultiColumnBlock::ensureColumnSets):

  • rendering/RenderRegion.cpp:

(WebCore::RenderRegion::RenderRegion):

1:26 PM Changeset in webkit [118825] by ap@apple.com
  • 2 edits in trunk/LayoutTests

WTR doesn't support beginDragWithFiles.

  • platform/wk2/Skipped: Added fast/files/file-list-test.html
1:19 PM Changeset in webkit [118824] by jberlin@webkit.org
  • 2 edits in trunk/LayoutTests

Clean up the Windows WK2 Skipped list.

Update it for the moves / renames in r96918, r102226, and r108612.

  • platform/win-wk2/Skipped:
1:03 PM Changeset in webkit [118823] by rafaelw@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled DEPS.

  • DEPS:
12:59 PM Changeset in webkit [118822] by jberlin@webkit.org
  • 2 edits in trunk/LayoutTests

JSC doesn't support heap profiling.
​https://bugs.webkit.org/show_bug.cgi?id=50485

Add two heap profiling tests to the Windows Skipped list.

  • platform/win/Skipped:
12:42 PM Changeset in webkit [118821] by benjamin@webkit.org
  • 2 edits in trunk/Tools

Fix the type of dispatch_time() offset

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2012-05-29
Rubber-stamped by Joseph Pecoraro.

In r118631, I erroneously used the type NSTimeInterval for the delta of dispatch_time().

  • DumpRenderTree/mac/FrameLoadDelegate.mm:

(-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]):

12:33 PM Changeset in webkit [118820] by sullivan@apple.com
  • 3 edits in trunk/Source/WebCore

Update label for blacklisted plug-in
​https://bugs.webkit.org/show_bug.cgi?id=87767
rdar://problem/11550048

Reviewed by Kevin Decker.

  • English.lproj/Localizable.strings:

Regenerated.

  • platform/LocalizedStrings.cpp:

(WebCore::insecurePluginVersionText):
Changed this string.

12:30 PM Changeset in webkit [118819] by jchaffraix@webkit.org
  • 3 edits
    9 adds in trunk

REGRESSION(r111742): box-sizing: border-box doesn't work on fixed table layout
​https://bugs.webkit.org/show_bug.cgi?id=87536

Reviewed by Tony Chang.

Source/WebCore:

Tests: fast/table/fixed-table-layout/cell-box-sizing-fixed-table-layout.html

fast/table/fixed-table-layout/column-box-sizing-fixed-table-layout.html
fast/table/fixed-table-layout/column-group-box-sizing-fixed-table-layout.html
fast/table/fixed-table-layout/column-in-column-group-box-sizing-fixed-table-layout.html

The change in r111742 completely ignored border-sizing (following the table's code lead unfortunately).
The issue is that we would count the borders and paddings twice for the border-box case which would lead
to the content-box including them too. From a web-author, this behavior is equivalent to ignoring box-sizing.

  • rendering/FixedTableLayout.cpp:

(WebCore::FixedTableLayout::calcWidthArray):
Reworked the function to properly use computeBorderBoxLogicalWidth() for correctness. This matches
what RenderBox and the rendering code does generally. Also refactored the code to avoid the need
for local variables and make it more readable.

LayoutTests:

  • fast/table/fixed-table-layout/cell-box-sizing-fixed-table-layout-expected.html: Added.
  • fast/table/fixed-table-layout/cell-box-sizing-fixed-table-layout.html: Added.

This test covers the regression.

  • fast/table/fixed-table-layout/column-box-sizing-fixed-table-layout-expected.html: Added.
  • fast/table/fixed-table-layout/column-box-sizing-fixed-table-layout.html: Added.
  • fast/table/fixed-table-layout/column-group-box-sizing-fixed-table-layout-expected.html: Added.
  • fast/table/fixed-table-layout/column-group-box-sizing-fixed-table-layout.html: Added.
  • fast/table/fixed-table-layout/column-in-column-group-box-sizing-fixed-table-layout-expected.html: Added.
  • fast/table/fixed-table-layout/column-in-column-group-box-sizing-fixed-table-layout.html: Added.

Those test ensured I didn't regress and document our current behavior ie that column and column group fixed
width apply to the cell's border-box.

12:28 PM Changeset in webkit [118818] by ojan@chromium.org
  • 6 edits
    2 adds in trunk

Absolute positioned elements in a relative positioned CSS3 Flexbox fail to display properly
​https://bugs.webkit.org/show_bug.cgi?id=58453

Reviewed by Tony Chang.

Source/WebCore:

Test: css3/flexbox/align-absolute-child.html

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::prepareChildForPositionedLayout):
(WebCore::RenderFlexibleBox::layoutAndPlaceChildren):
(WebCore::RenderFlexibleBox::adjustAlignmentForChild):
When adjusting positioned items, adjust their static position, not their location.
(WebCore::RenderFlexibleBox::flipForRightToLeftColumn):
(WebCore::RenderFlexibleBox::flipForWrapReverse):

  • rendering/RenderFlexibleBox.h:

LayoutTests:

  • css3/flexbox/align-absolute-child-expected.txt: Added.
  • css3/flexbox/align-absolute-child.html: Added.
  • css3/flexbox/position-absolute-child-expected.txt:
  • css3/flexbox/position-absolute-child.html:
12:23 PM Changeset in webkit [118817] by jberlin@webkit.org
  • 3 edits
    13 deletes in trunk

[Win] ~1/2 of all the iframe seamless tests fail
​https://bugs.webkit.org/show_bug.cgi?id=87543

Rubber-stamped by Eric Seidel.

WebKitLibraries:

Finish enabling IFRAME_SEAMLESS on Windows.

  • win/tools/vsprops/FeatureDefines.vsprops:

LayoutTests:

Remove the platform-specific results as they are no longer needed.

  • platform/win/fast/frames/seamless/seamless-basic-expected.txt: Removed.
  • platform/win/fast/frames/seamless/seamless-css-cascade-expected.txt: Removed.
  • platform/win/fast/frames/seamless/seamless-form-get-expected.txt: Removed.
  • platform/win/fast/frames/seamless/seamless-form-get-named-expected.txt: Removed.
  • platform/win/fast/frames/seamless/seamless-form-post-expected.txt: Removed.
  • platform/win/fast/frames/seamless/seamless-form-post-named-expected.txt: Removed.
  • platform/win/fast/frames/seamless/seamless-hyperlink-expected.txt: Removed.
  • platform/win/fast/frames/seamless/seamless-hyperlink-named-expected.txt: Removed.
  • platform/win/fast/frames/seamless/seamless-inherited-document-style-expected.txt: Removed.
  • platform/win/fast/frames/seamless/seamless-window-location-expected.txt: Removed.
  • platform/win/fast/frames/seamless/seamless-window-location-href-expected.txt: Removed.
  • platform/win/fast/frames/seamless/seamless-window-location-sandbox-expected.txt: Removed.
  • platform/win/fast/frames/seamless/seamless-window-open-expected.txt: Removed.
12:15 PM Changeset in webkit [118816] by inferno@chromium.org
  • 3 edits
    2 adds in trunk

Crash due to text fragment destruction when updating first-letter block.
​https://bugs.webkit.org/show_bug.cgi?id=87751

Reviewed by Eric Seidel.

Source/WebCore:

Test: fast/text/text-fragment-first-letter-update-crash.html

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::setStyle):

LayoutTests:

  • fast/text/text-fragment-first-letter-update-crash-expected.txt: Added.
  • fast/text/text-fragment-first-letter-update-crash.html: Added.
12:12 PM Changeset in webkit [118815] by hyatt@apple.com
  • 3 edits in trunk/Source/WebCore

​https://bugs.webkit.org/show_bug.cgi?id=87764

Add implementation of checkForPaginationLogicalHeightChange to RenderMultiColumnBlock.

Also stub out ensureColumnSets() and write a comment describing how it's going to work.

Reviewed by Anders Carlsson.

  • rendering/RenderMultiColumnBlock.cpp:

(WebCore::RenderMultiColumnBlock::RenderMultiColumnBlock):
(WebCore::RenderMultiColumnBlock::checkForPaginationLogicalHeightChange):
(WebCore):
(WebCore::RenderMultiColumnBlock::ensureColumnSets):

  • rendering/RenderMultiColumnBlock.h:

(WebCore::RenderMultiColumnBlock::columnHeight):
(WebCore::RenderMultiColumnBlock::setColumnHeight):
(RenderMultiColumnBlock):

11:48 AM Changeset in webkit [118814] by commit-queue@webkit.org
  • 3 edits
    3 adds in trunk/LayoutTests

[EFL] Gardening of failing tests and new passes
​https://bugs.webkit.org/show_bug.cgi?id=87754

Unreviewed gardening.

Patch by Thiago Marcos P. Santos <​thiago.santos@intel.com> on 2012-05-29

  • platform/efl/Skipped:
  • platform/efl/fast/forms/select/optgroup-rendering-expected.png: Added.
  • platform/efl/fast/forms/select/optgroup-rendering-expected.txt: Added.
  • platform/efl/test_expectations.txt:
11:42 AM Changeset in webkit [118813] by rniwa@webkit.org
  • 1 edit
    2 copies in branches/chromium/1132

Merge 118449 - REGRESSION (r112399): insertHTML doesn't respect current selection range and inserts HTML to incorrect position
​https://bugs.webkit.org/show_bug.cgi?id=87195

Reviewed by Darin Adler.

Source/WebCore:
The bug was caused by our passing insertionPos.anchorNode() to splitTreeToNode's start node even when
the position's type was an offset in a container. Fixed the bug by passing the node after the insert position
or the container node if the position is at the end of the container.

Test: editing/pasteboard/paste-at-end-of-node-followed-by-inline-element.html

  • editing/ReplaceSelectionCommand.cpp:

(WebCore::ReplaceSelectionCommand::doApply):
LayoutTests:
Add a regression test.

  • editing/pasteboard/paste-at-end-of-node-followed-by-inline-element-expected.txt: Added.
  • editing/pasteboard/paste-at-end-of-node-followed-by-inline-element.html: Added.
11:42 AM Changeset in webkit [118812] by commit-queue@webkit.org
  • 9 edits in trunk

Unreviewed, rolling out r118620.
​http://trac.webkit.org/changeset/118620
​https://bugs.webkit.org/show_bug.cgi?id=87760

This patch causes regression to read an empty file/blob via
FileReader (Requested by jianli on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-05-29

Source/WebCore:

  • fileapi/FileReader.cpp:

(WebCore::FileReader::stringResult):

LayoutTests:

  • fast/files/blob-slice-test-expected.txt:
  • fast/files/read-blob-async-expected.txt:
  • fast/files/read-file-async-expected.txt:
  • fast/files/resources/read-common.js:

(logResult):

  • fast/files/workers/worker-read-blob-async-expected.txt:
  • fast/files/workers/worker-read-file-async-expected.txt:
11:39 AM Changeset in webkit [118811] by jberlin@webkit.org
  • 2 edits in trunk/LayoutTests

[Win] ASSERT(m_manualStream) failed in PluginView::didFinishLoading running
fast/loader/reload-zero-byte-plugin.html

Skip the test on Windows to get the bots greener.

  • platform/win/Skipped:
11:38 AM Changeset in webkit [118810] by mhahnenberg@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

CopiedSpace::doneCopying could start another collection
​https://bugs.webkit.org/show_bug.cgi?id=86538

Reviewed by Geoffrey Garen.

It's possible that if we don't have anything at the head of to-space
after a collection and the BlockAllocator doesn't have any fresh blocks
to give us right now we could start another collection while still in
the middle of the first collection when we call CopiedSpace::addNewBlock().

One way to resolve this would be to have Heap::shouldCollect() check that
m_operationInProgress is NoOperation. This would prevent the path in
getFreshBlock() that starts the collection if we're already in the middle of one.

I could not come up with a test case to reproduce this crash on ToT.

  • heap/Heap.h:

(JSC::Heap::shouldCollect): We shouldn't collect if we're already in the middle
of a collection, i.e. the current operation should be NoOperation.

11:19 AM Changeset in webkit [118809] by kling@webkit.org
  • 6 edits in trunk/Source/WebCore

Make StylePropertySet a variable-sized object to reduce memory use.
<​http://webkit.org/b/87506>

Reviewed by Antti Koivisto.

Make immutable StylePropertySet objects variable-sized and allocate exactly
the space needed to hold the CSSProperty objects passed at construction.
This lets us avoid the memory overhead of Vector<CSSProperty, 4>.

Renamed StylePropertySet::adopt* to create and createImmutable since they no
longer adopt the incoming vector. More cleanup will follow in this area.

This reduces memory usage across the board - the more CSS declarations,
the bigger the benefit. As an example, we save around ~0.5MB on wsj.com.

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::copyPropertiesInSet):

  • css/CSSParser.cpp:

(WebCore::CSSParser::createStylePropertySet):

  • css/StylePropertySet.cpp:

(WebCore::StylePropertySet::createImmutable):
(WebCore::StylePropertySet::StylePropertySet):
(WebCore::StylePropertySet::~StylePropertySet):
(WebCore::StylePropertySet::copyPropertiesFrom):
(WebCore::StylePropertySet::removeProperty):
(WebCore::StylePropertySet::setProperty):
(WebCore::StylePropertySet::parseDeclaration):
(WebCore::StylePropertySet::addParsedProperties):
(WebCore::StylePropertySet::asText):
(WebCore::StylePropertySet::merge):
(WebCore::StylePropertySet::addSubresourceStyleURLs):
(WebCore::StylePropertySet::removePropertiesInSet):
(WebCore::StylePropertySet::findPropertyWithId):
(WebCore::StylePropertySet::removeEquivalentProperties):
(WebCore::StylePropertySet::copyPropertiesInSet):
(WebCore::StylePropertySet::averageSizeInBytes):
(SameSizeAsStylePropertySet):
(WebCore::StylePropertySet::append):

  • css/StylePropertySet.h:

(WebCore::StylePropertySet::create):
(StylePropertySet):
(WebCore::StylePropertySet::propertyAt):
(WebCore::StylePropertySet::propertyCount):
(WebCore::StylePropertySet::isEmpty):
(WebCore::StylePropertySet::array):

  • dom/StyledElement.cpp:

(WebCore::StyledElement::updateAttributeStyle):

11:15 AM Changeset in webkit [118808] by hyatt@apple.com
  • 3 edits in trunk/Source/WebCore

​https://bugs.webkit.org/show_bug.cgi?id=87759

Pull the initial page logical height checking for columns into its own separate function. This
will allow the derived RenderMultiColumnBlock class to do its own setup there. It also has the
effect of cleaning up layoutBlock even for the existing code.

Reviewed by Anders Carlsson.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::checkForPaginationLogicalHeightChange):
(WebCore):
(WebCore::RenderBlock::layoutBlock):

  • rendering/RenderBlock.h:

(RenderBlock):

11:13 AM Changeset in webkit [118807] by rafaelw@chromium.org
  • 2 edits in trunk/LayoutTests

Adding VISTA timeout expectations to a number of viewport tests. Also, narrowing optgroup-clicking.html
to be just MAC.

  • platform/chromium/test_expectations.txt:
10:55 AM Changeset in webkit [118806] by commit-queue@webkit.org
  • 6 edits in trunk

Update cue event dispatching for zero and negative duration cues
​https://bugs.webkit.org/show_bug.cgi?id=85143

Patch by Victor Carbune <​victor@rosedu.org> on 2012-05-29
Reviewed by Eric Carlson.

Source/WebCore:

Updated existing test.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::updateActiveTextTrackCues): Explicitly
treated event dispatching for zero and negative duration cues.
(WebCore::HTMLMediaElement::textTrackAddCue): Interval tree doesn't
handle invalid cues with intervals - negative cues need to be treated
as zero-length cues as they are always missed cues anyway.
(WebCore::HTMLMediaElement::textTrackRemoveCue): Same.

LayoutTests:

  • media/track/captions-webvtt/missed-cues.vtt: Added negative

duration cue and changed a missed cue to have zero-length.

  • media/track/track-cues-missed-expected.txt: Updated.
  • media/track/track-cues-missed.html: Updated.
10:50 AM Changeset in webkit [118805] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Make DefaultTapHighlight use the new WebOverlay API
​https://bugs.webkit.org/show_bug.cgi?id=87604

Patch by Arvid Nilsson <​anilsson@rim.com> on 2012-05-29
Reviewed by Antonio Gomes.

Also add a new method to allow the embedder to use the default tap
highlight instead of replacing it with a custom one just to keep track
of the "shouldHideAfterScroll" flag.

PR #160262.

  • Api/WebTapHighlight.h:
  • WebKitSupport/DefaultTapHighlight.cpp:

(BlackBerry::WebKit::DefaultTapHighlight::DefaultTapHighlight):
(BlackBerry::WebKit::DefaultTapHighlight::draw):
(BlackBerry::WebKit::DefaultTapHighlight::hide):
(BlackBerry::WebKit::DefaultTapHighlight::paintContents):

  • WebKitSupport/DefaultTapHighlight.h:

(BlackBerry::WebKit::DefaultTapHighlight::shouldHideAfterScroll):
(DefaultTapHighlight):

10:50 AM Changeset in webkit [118804] by morrita@google.com
  • 4 edits
    2 adds in trunk

ShadowRoot.getElementById() returns removed node.
​https://bugs.webkit.org/show_bug.cgi?id=62184

Source/WebCore:

Deregitration of m_elementsById map is done at Element::removedFrom()
But the tree scope of the removed node is already reset from a shadow root
to a document.

This change lookup the old shadow root through its parent node and
deregitrater the node against it.

Reviewed by Dimitri Glazkov.

Test: fast/dom/shadow/get-element-by-id-in-shadow-mutation.html

  • dom/Element.cpp:

(WebCore::treeScopeOfParent):
(WebCore):
(WebCore::Element::removedFrom):

  • dom/Element.h:

(Element):
(WebCore::Element::updateId):
(WebCore):

LayoutTests:

Reviewed by Dimitri Glazkov.

  • fast/dom/shadow/get-element-by-id-in-shadow-mutation-expected.txt: Added.
  • fast/dom/shadow/get-element-by-id-in-shadow-mutation.html: Added.
10:46 AM Changeset in webkit [118803] by danakj@chromium.org
  • 8 edits in trunk/Source

[chromium] Unoccluded area in surfaces should always be clipped to the rootScissorRect
​https://bugs.webkit.org/show_bug.cgi?id=87677

Reviewed by Adrienne Walker.

Source/WebCore:

When a contributing surface is visited, and we have not visited another
surface, then we know the surface is completely unoccluded. However, the
root scissor rect should still be applied, and anything outside of it
should be considered occluded.

Unit test: WebKitTests::CCOcclusionTrackerTestTopmostSurfaceIsClippedToScissor

  • platform/graphics/chromium/RenderSurfaceChromium.cpp:

(WebCore::RenderSurfaceChromium::targetRenderSurface):
(WebCore):

  • platform/graphics/chromium/RenderSurfaceChromium.h:

(RenderSurfaceChromium):

  • platform/graphics/chromium/cc/CCOcclusionTracker.cpp:

(WebCore::::unoccludedContributingSurfaceContentRect):

  • platform/graphics/chromium/cc/CCRenderSurface.cpp:

(WebCore::CCRenderSurface::targetRenderSurface):
(WebCore):

  • platform/graphics/chromium/cc/CCRenderSurface.h:

(CCRenderSurface):

Source/WebKit/chromium:

  • tests/CCOcclusionTrackerTest.cpp:

(CCOcclusionTrackerTestTopmostSurfaceIsClippedToScissor):
(WebKitTests::CCOcclusionTrackerTestTopmostSurfaceIsClippedToScissor::runMyTest):
(WebKitTests):

10:23 AM Changeset in webkit [118802] by ap@apple.com
  • 2 edits in trunk/LayoutTests
  • platform/mac/Skipped: Skipping a heap profiler test (unsupported functionality).
10:14 AM Changeset in webkit [118801] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

[BlackBerry] Refactoring http/proxy authentication to use authcallback mechanism introduced with libcurl
​https://bugs.webkit.org/show_bug.cgi?id=87706

Patch by Jonathan Dong <Jonathan Dong> on 2012-05-29
Reviewed by Antonio Gomes.

Because we use authentication callback mechanism of libcurl,
which will take care of all the authentication communication
between UA and server, so the only thing we need to do is to
provide credential information when authentication callback
is triggered. By using this we don't need to process
intermediate headers for each http authentication scheme.

Implemented interface function notifyAuthReceived() in
NetworkJob to handle the authentication notification from
networking thread.
When the authentication callback is triggered, we should
cancel the current loading request and restart a new one with
credential information attached which comes from
credentialStorage or user input.

Internally reviewed by Joe Mason <​jmason@rim.com>.

No new tests since there is no behavior change.

  • platform/network/blackberry/NetworkJob.cpp:

(WebCore::NetworkJob::notifyAuthReceived):
(WebCore):
(WebCore::NetworkJob::handleNotifyHeaderReceived):
(WebCore::NetworkJob::sendRequestWithCredentials):

  • platform/network/blackberry/NetworkJob.h:

(NetworkJob):

10:02 AM Changeset in webkit [118800] by jberlin@webkit.org
  • 2 edits in branches/safari-536-branch/LayoutTests

Merge r118078, which skips the test added in r118039, onto the 536 branch.

WTR does not have support for layoutTestController.setPrinting yet.

  • platform/wk2/Skipped:
9:57 AM Changeset in webkit [118799] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[BlackBerry] http authentication challenge issue when loading subresource
​https://bugs.webkit.org/show_bug.cgi?id=87660

Patch by Jonathan Dong <Jonathan Dong> on 2012-05-29
Reviewed by Rob Buis.

We should try to store the credential information as soon as we
receive http status notification which indicates that the
authentication succeeds, instead of storing credentials when the
main resource receives notify done which is too late for loading
subresource.

Internally reviewed by Joe Mason <​jmason@rim.com>

No new tests since there is no change in behavior.

  • platform/network/blackberry/NetworkJob.cpp:

(WebCore::NetworkJob::handleNotifyStatusReceived):
(WebCore::NetworkJob::handleNotifyClose):

9:52 AM Changeset in webkit [118798] by ap@apple.com
  • 4 edits
    1 delete in trunk/Source/WebCore

[Mac] Move DefaultFonts.plist to C++ code
​https://bugs.webkit.org/show_bug.cgi?id=87560
<rdar://problem/11466119>

Reviewed by Dan Bernstein.

  • DerivedSources.make:
  • Resources/DefaultFonts.plist.in: Removed.
  • WebCore.xcodeproj/project.pbxproj:
  • page/mac/SettingsMac.mm: (WebCore::Settings::initializeDefaultFontFamilies):

Instead of having a separate configuration file, just hardcode the settings in C++.

9:49 AM Changeset in webkit [118797] by jberlin@webkit.org
  • 2 edits in trunk/LayoutTests

Regression: fast/forms/select/optgroup-clicking.html is failing / timing out
​https://bugs.webkit.org/show_bug.cgi?id=87748

This test times out on Mac if there is no interaction with the keyboard. Skip it to keep the
bots green.

  • platform/mac/Skipped:
9:48 AM Changeset in webkit [118796] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[GTK] [WK2] Reproducible crash in performDragControllerAction
​https://bugs.webkit.org/show_bug.cgi?id=87744

Patch by Sudarsana Nagineni <​sudarsana.nagineni@linux.intel.com> on 2012-05-29
Reviewed by Martin Robinson.

Fix a crash by using deref() instead of delete to dereference and
release the platformData of DragData.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::performDragControllerAction):

9:47 AM Changeset in webkit [118795] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit2

[GTK] Missing field initializers for WKPageLoaderClient and WKPageUIClient
​https://bugs.webkit.org/show_bug.cgi?id=87745

Patch by Simon Pena <Simon Pena> on 2012-05-29
Reviewed by Carlos Garcia Campos.

Add missing initializers for WKPageLoaderClient and
WKPageUIClient, for callbacks WKPagePluginDidFailCallback and
WKPageUnavailablePluginButtonClickedCallback, introduced in
revision r116716.

  • UIProcess/API/gtk/WebKitLoaderClient.cpp:

(attachLoaderClientToView): Initialize WKPagePluginDidFailCallback

  • UIProcess/API/gtk/WebKitUIClient.cpp:

(attachUIClientToView): Initialize callback
WKPageUnavailablePluginButtonClickedCallback

9:44 AM Changeset in webkit [118794] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebKit2

[GTK] Policy decision headers are not included in the main webkit2.h header
​https://bugs.webkit.org/show_bug.cgi?id=87753

Reviewed by Martin Robinson.

  • UIProcess/API/gtk/webkit2.h: Include

WebKitNavigationPolicyDecision.h and WebKitResponsePolicyDecision.h.

9:36 AM Changeset in webkit [118793] by commit-queue@webkit.org
  • 4 edits
    2 adds in trunk

Web Inspector: Retainers are missing for all objects
​https://bugs.webkit.org/show_bug.cgi?id=87655

Patch by Alexei Filippov <​alexeif@chromium.org> on 2012-05-29
Reviewed by Yury Semikhatsky.

Source/WebCore:

  • inspector/front-end/HeapSnapshotDataGrids.js:

(WebInspector.HeapSnapshotContainmentDataGrid.prototype.setDataSource):

LayoutTests:

  • inspector/profiler/heap-snapshot-summary-retainers-expected.txt: Added.
  • inspector/profiler/heap-snapshot-summary-retainers.html: Added.
  • inspector/profiler/heap-snapshot-test.js:

(initialize_HeapSnapshotTest.):
(initialize_HeapSnapshotTest):

9:31 AM Changeset in webkit [118792] by commit-queue@webkit.org
  • 9 edits in trunk/LayoutTests

[GTK] fast tests needs rebaseline after r118733
​https://bugs.webkit.org/show_bug.cgi?id=87729

Unreviewed GTK gardening, updated fast pngs.

Patch by Simon Pena <Simon Pena> on 2012-05-29

  • platform/gtk/fast/forms/input-placeholder-visibility-1-expected.png:
  • platform/gtk/fast/forms/input-placeholder-visibility-3-expected.png:
  • platform/gtk/fast/forms/placeholder-position-expected.png:
  • platform/gtk/fast/forms/placeholder-pseudo-style-expected.png:
  • platform/gtk/fast/forms/search-styled-expected.png:
  • platform/gtk/fast/forms/textarea-placeholder-pseudo-style-expected.png:
  • platform/gtk/fast/forms/textarea-placeholder-visibility-1-expected.png:
  • platform/gtk/fast/forms/textarea-placeholder-visibility-2-expected.png:
9:29 AM Changeset in webkit [118791] by jberlin@webkit.org
  • 1 edit
    3 adds in trunk/LayoutTests

[Mac] fast/forms/select/optgroup-rendering.html "failing" since introduction in r118772
​https://bugs.webkit.org/show_bug.cgi?id=87752

Add expected (failing?) results to get the bots green.

  • platform/mac/fast/forms/select/optgroup-rendering-expected.png: Added.
  • platform/mac/fast/forms/select/optgroup-rendering-expected.txt: Added.
9:28 AM Changeset in webkit [118790] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

Unreviewed GTK gardening after r118776. The failing test was split into
5 separate tests, but we're still failing all of them.

  • platform/gtk/test_expectations.txt:
9:27 AM Changeset in webkit [118789] by Philippe Normand
  • 4 edits in trunk/Source/WebCore

[GStreamer] Video sink doesn't respect WebKit code style
​https://bugs.webkit.org/show_bug.cgi?id=87693

Reviewed by Alexis Menard.

No change in behavior of the sink, this patch only adapts the code
style to WebKit's.

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
  • platform/graphics/gstreamer/VideoSinkGStreamer.cpp:

(_WebKitVideoSinkPrivate):
(webkitVideoSinkTimeoutCallback):
(webkitVideoSinkRender):
(webkitVideoSinkDispose):
(unlockBufferMutex):
(webkitVideoSinkUnlock):
(webkitVideoSinkUnlockStop):
(webkitVideoSinkStop):
(webkitVideoSinkStart):
(webkitVideoSinkMarshalVoidAndMiniObject):
(webkit_video_sink_class_init):
(webkitVideoSinkNew):

  • platform/graphics/gstreamer/VideoSinkGStreamer.h:

(_WebKitVideoSink):
(_WebKitVideoSinkClass):

9:20 AM Changeset in webkit [118788] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[Qt] Uninitialized shader compiler when GLES is used
​https://bugs.webkit.org/show_bug.cgi?id=87712

The '#if !defined(QT_OPENGL_ES_2)' has been removed before the initialization
of shader compiler to compile shader codes for ES-platforms as well.

Patch by Roland Takacs <​takacs.roland@stud.u-szeged.hu> on 2012-05-29
Reviewed by Noam Rosenthal.

  • platform/graphics/qt/GraphicsContext3DQt.cpp:

(WebCore::GraphicsContext3D::GraphicsContext3D):

9:17 AM Changeset in webkit [118787] by commit-queue@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

[FileAPI] Miss FileList test
​https://bugs.webkit.org/show_bug.cgi?id=87696

Patch by Li Yin <​li.yin@intel.com> on 2012-05-29
Reviewed by Kentaro Hara.

WebKit should have the test to track the attribute of FileList.

  • fast/files/file-list-test-expected.txt: Added.
  • fast/files/file-list-test.html: Added.
9:09 AM Changeset in webkit [118786] by Carlos Garcia Campos
  • 8 edits in trunk/Source/WebKit2

[GTK] Add webkit_web_view_can_show_mime_type() to WebKit2 GTK+ API
​https://bugs.webkit.org/show_bug.cgi?id=85998

Reviewed by Martin Robinson.

And use it in the default handler of WebKitWebView::decide-policy
signal to decide whether to use or ignore a response policy
decision depending on whether the mime type of the response can be
displayed in the WebView or not.

  • UIProcess/API/gtk/WebKitURIResponse.cpp:

(webkitURIResponseGetProperty): Add getter for mime-type property.
(webkit_uri_response_class_init): Add mime-type property.
(webkit_uri_response_get_mime_type): Return the mime type of the
response.

  • UIProcess/API/gtk/WebKitURIResponse.h:
  • UIProcess/API/gtk/WebKitWebView.cpp:

(webkitWebViewDecidePolicy): In case of response policy decisions,
use the URI response to decide what to do: download if the
response is an attachment, use if the mime type is supported by
the web view or ignore otherwise.
(webkit_web_view_can_show_mime_type): Returns whether the given
mime type can be displayed in the WebView or not.

  • UIProcess/API/gtk/WebKitWebView.h:
  • UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Add new symbols.
  • UIProcess/API/gtk/tests/TestResources.cpp:

(testWebResourceResponse):
(testWebResourceMimeType):
(serverCallback):
(beforeAll):

  • UIProcess/API/gtk/tests/TestWebKitWebView.cpp:

(testWebViewCanShowMIMEType):
(beforeAll):

9:06 AM Changeset in webkit [118785] by commit-queue@webkit.org
  • 7 edits
    3 adds in trunk/Source/WebKit

[BlackBerry] WebKit-side implementation of SelectionOverlay
​https://bugs.webkit.org/show_bug.cgi?id=87605

Patch by Arvid Nilsson <​anilsson@rim.com> on 2012-05-29
Reviewed by Rob Buis.

Source/WebKit:

Add SelectionOverlay to the build system.

PR #160263

  • PlatformBlackBerry.cmake:

Source/WebKit/blackberry:

Leverage the new WebOverlay API to move SelectionOverlay to the WebKit
library, so we always draw selection regardless of which embedder is
integrating WebKit.

PR #160263

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::init):
(BlackBerry::WebKit::WebPage::selectionOverlay):
(WebKit):

  • Api/WebPage.h:

(WebKit):

  • Api/WebPage_p.h:

(WebPagePrivate):

  • Api/WebSelectionOverlay.h: Added.

(WebKit):

  • WebKitSupport/SelectionHandler.cpp:

(BlackBerry::WebKit::SelectionHandler::selectionPositionChanged):

  • WebKitSupport/SelectionOverlay.cpp: Added.

(WebKit):
(BlackBerry::WebKit::SelectionOverlay::SelectionOverlay):
(BlackBerry::WebKit::SelectionOverlay::~SelectionOverlay):
(BlackBerry::WebKit::SelectionOverlay::draw):
(BlackBerry::WebKit::SelectionOverlay::hide):
(BlackBerry::WebKit::SelectionOverlay::notifySyncRequired):
(BlackBerry::WebKit::SelectionOverlay::paintContents):

  • WebKitSupport/SelectionOverlay.h: Added.

(WebKit):
(SelectionOverlay):
(BlackBerry::WebKit::SelectionOverlay::create):
(BlackBerry::WebKit::SelectionOverlay::notifyAnimationStarted):
(BlackBerry::WebKit::SelectionOverlay::showDebugBorders):
(BlackBerry::WebKit::SelectionOverlay::showRepaintCounter):
(BlackBerry::WebKit::SelectionOverlay::contentsVisible):

9:02 AM Changeset in webkit [118784] by jberlin@webkit.org
  • 2 edits in trunk/LayoutTests

[Mac] fast/events/message-port-constructor-for-deleted-document.html ASSERTS in Debug.

This is happening often enough that it is necessary to add the test to the Mac Skipped list
in order to keep the bots green.

  • platform/mac/Skipped:
9:00 AM Changeset in webkit [118783] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Add InspectorFileSystemAgent::FrontendProvider
​https://bugs.webkit.org/show_bug.cgi?id=87635

InspectorFileSystemAgent needs weak reference to its frontend to perform
asynchronous operation.

Patch by Taiju Tsuiki <​tzik@chromium.org> on 2012-05-29
Reviewed by Yury Semikhatsky.

  • inspector/InspectorFileSystemAgent.cpp:

(InspectorFileSystemAgent::FrontendProvider):
(WebCore):
(WebCore::InspectorFileSystemAgent::~InspectorFileSystemAgent):
(WebCore::InspectorFileSystemAgent::enable):
(WebCore::InspectorFileSystemAgent::disable):
(WebCore::InspectorFileSystemAgent::setFrontend):
(WebCore::InspectorFileSystemAgent::clearFrontend):
(WebCore::InspectorFileSystemAgent::restore):
(WebCore::InspectorFileSystemAgent::InspectorFileSystemAgent):

  • inspector/InspectorFileSystemAgent.h:

(InspectorFileSystemAgent):

8:52 AM Changeset in webkit [118782] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

[EFL][DRT] move idn encoding test to test_expectations.txt
​https://bugs.webkit.org/show_bug.cgi?id=86080

Unreviewed gardening. Implementing copy{En,De}codedHostName just
to test them is not useful: marking fast/encoding/idn-security.html
as expected to fail.

Patch by Jussi Kukkonen <​jussi.kukkonen@intel.com> on 2012-05-29

  • platform/efl/Skipped:
  • platform/efl/test_expectations.txt:
8:28 AM Changeset in webkit [118781] by Csaba Osztrogonác
  • 7 edits
    2 adds in trunk/LayoutTests

[Qt] Unreviewed gardening.

  • platform/qt-5.0-wk2/compositing/geometry/composited-in-columns-expected.txt: Added.
  • platform/qt-5.0-wk2/fast/forms/placeholder-pseudo-style-expected.png:
  • platform/qt-5.0-wk2/fast/forms/placeholder-pseudo-style-expected.txt:
  • platform/qt-5.0-wk2/svg/css/text-gradient-shadow-expected.png: Added.
  • platform/qt-5.0-wk2/svg/css/text-gradient-shadow-expected.txt:
  • platform/qt-5.0/fast/forms/placeholder-pseudo-style-expected.png:
  • platform/qt-5.0/fast/forms/placeholder-pseudo-style-expected.txt:
  • platform/wk2/Skipped:
8:20 AM Changeset in webkit [118780] by bulach@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Regression: fast/forms/select/optgroup-clicking.html is failing
​https://bugs.webkit.org/show_bug.cgi?id=87748

Unreviewed gardening.

This test was added by r118772 and it fails with a mismatch in menulist.selectedIndex.

  • platform/chromium/test_expectations.txt:
8:12 AM Changeset in webkit [118779] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

Fix new layout tests for images with color profiles by using fixed size
​https://bugs.webkit.org/show_bug.cgi?id=87542

Patch by Tony Payne <​tpayne@chromium.org> on 2012-05-29
Reviewed by Kent Tamura.

  • fast/images/jpeg-with-color-profile.html: Use width=400px instead of 50% to make sure size is consistent across ports.
  • fast/images/png-with-color-profile.html: Use width=40px instead of 50% to make sure size is consistent across ports.
8:08 AM Changeset in webkit [118778] by loislo@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed: Web Inspector: single line fix.
heap-snapshot-loader are failing in Debug configuration because the list of profiles is not empty.

  • inspector/profiler/heap-snapshot-loader.html:
7:56 AM Changeset in webkit [118777] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[BlackBerry] OpenGL content is not rendered on simulator
​https://bugs.webkit.org/show_bug.cgi?id=87721

Patch by Arvid Nilsson <​anilsson@rim.com> on 2012-05-29
Reviewed by George Staikos.

Fixed by enabling GLES2 support in simulator builds.

To experiment with building without OpenGL support, you can set the
DISABLE_GLES2 environment variable to a non-empty string and rebuild.

PR #150695

  • Scripts/webkitdirs.pm:

(blackberryCMakeArguments):

7:53 AM Changeset in webkit [118776] by bulach@chromium.org
  • 1 edit
    4 copies
    1 move
    6 adds
    1 delete in trunk/LayoutTests

Split svg/dom/viewspec-parser.html in smaller tests
​https://bugs.webkit.org/show_bug.cgi?id=87726

Reviewed by Andreas Kling.

This test was added by r118735.
Splits into smaller independent tests to avoid timeouts on ports such as chromium.

  • svg/dom/resources/viewspec-parser.js: Added.

(buildTestsToRun):
(zoomAndPanToString):
(viewSpecToString):
(testString.string_appeared_here.makeURLRelative):
(testFragment):
(startNextTest):
(continueFuzzing.else.script.onload):
(continueFuzzing):

  • svg/dom/viewspec-parser-1-expected.txt: Copied from LayoutTests/svg/dom/viewspec-parser-expected.txt.
  • svg/dom/viewspec-parser-1.html: Added.
  • svg/dom/viewspec-parser-2-expected.txt: Copied from LayoutTests/svg/dom/viewspec-parser-expected.txt.
  • svg/dom/viewspec-parser-2.html: Added.
  • svg/dom/viewspec-parser-3-expected.txt: Copied from LayoutTests/svg/dom/viewspec-parser-expected.txt.
  • svg/dom/viewspec-parser-3.html: Added.
  • svg/dom/viewspec-parser-4-expected.txt: Copied from LayoutTests/svg/dom/viewspec-parser-expected.txt.
  • svg/dom/viewspec-parser-4.html: Added.
  • svg/dom/viewspec-parser-5-expected.txt: Renamed from LayoutTests/svg/dom/viewspec-parser-expected.txt.
  • svg/dom/viewspec-parser-5.html: Added.
  • svg/dom/viewspec-parser.html: Removed.
7:45 AM Changeset in webkit [118775] by Csaba Osztrogonác
  • 3 edits in trunk/LayoutTests

Unreviewed gardening, skip failing tests.

  • platform/mac/Skipped:
  • platform/qt/Skipped:
7:44 AM Changeset in webkit [118774] by commit-queue@webkit.org
  • 14 edits in trunk

Introduce ENABLE_CSS_IMAGE_RESOLUTION compile flag
​https://bugs.webkit.org/show_bug.cgi?id=87685

Patch by David Barr <​davidbarr@chromium.org> on 2012-05-29
Reviewed by Eric Seidel.

Add a configuration option for CSS image-resolution support, disabling it by default.

.:

  • Source/cmake/WebKitFeatures.cmake:
  • Source/cmakeconfig.h.cmake:

Source/JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit/chromium:

  • features.gypi:

Source/WebKit/mac:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

  • Configurations/FeatureDefines.xcconfig:

Tools:

  • Scripts/webkitperl/FeatureList.pm:
  • qmake/mkspecs/features/features.pri:
7:09 AM Changeset in webkit [118773] by apavlov@chromium.org
  • 1 edit in branches/chromium/1132/Source/WebCore/platform/chromium/PopupContainer.cpp

Merge 118768 - [Chromium] [Regression] SELECT popup misplaced when there is not enough vertical space
​https://bugs.webkit.org/show_bug.cgi?id=87735

Reviewed by Kent Tamura.

This change fixes the obsolete WebWidget Y-repositioning code for the insufficient vertical space case, not removed in r113418.

No new tests, as popups are not testable in Chromium.

  • platform/chromium/PopupContainer.cpp:

(WebCore::PopupContainer::layoutAndCalculateWidgetRect):

TBR=​apavlov@chromium.org
Review URL: ​https://chromiumcodereview.appspot.com/10442063

7:00 AM Changeset in webkit [118772] by yosin@chromium.org
  • 7 edits
    8 adds in trunk

REGRESSION(r109729): The optgroup element's "disabled" attribute has no effect to rendering and selection
​https://bugs.webkit.org/show_bug.cgi?id=87614

Reviewed by Kent Tamura.

Source/WebCore:

This patch adds HTMLOptGroupElement::disabled and isEnabledFormControl
methods which was implemented in HTMLFormControlElement at r109729 and
updates CSS pseudo class checker to check "optgroup" element.

Tests: fast/forms/select/optgroup-clicking.html

fast/forms/select/optgroup-disabled.html
fast/forms/select/optgroup-rendering.html

  • css/SelectorChecker.cpp:

(WebCore::SelectorChecker::checkOneSelector): On disabled and enabled pseudo class checker.
We checked tag name "optgroup" in addition isFormControlElement.

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::canShareStyleWithElement): Checks optgroup.disabled.

  • html/HTMLOptGroupElement.cpp:

(WebCore::HTMLOptGroupElement::disabled): Added.

  • html/HTMLOptGroupElement.h:

(HTMLOptGroupElement): Added isEnabledFormControl.

LayoutTests:

Note: An image for optgroup-rendering.html will be change due by
BUG-87719. Color of option elements should be blue (:enabled
pseudo class) instead of green.

  • fast/forms/select/optgroup-clicking-expected.txt: Added.
  • fast/forms/select/optgroup-clicking.html: Added.
  • fast/forms/select/optgroup-disabled-expected.txt: Added.
  • fast/forms/select/optgroup-disabled.html: Added.
  • fast/forms/select/optgroup-rendering.html: Added.
  • platform/chromium/test_expectations.txt: Add MISSING entry for optgroup-rendering.html.
  • platform/chromium-linux/fast/forms/select/optgroup-rendering-expected.png: Added.
  • platform/chromium-linux/fast/forms/select/optgroup-rendering-expected.txt: Added.
6:57 AM Changeset in webkit [118771] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

REGRESSION(r118742): It made inspector/profiler/heap-snapshot-loader.html fail on Lion, Qt
​https://bugs.webkit.org/show_bug.cgi?id=87741

Patch by Ádám Kallai <​kadam@inf.u-szeged.hu> on 2012-05-29
Reviewed by Csaba Osztrogonác.

  • platform/qt/Skipped: Skip the failing test.
6:53 AM Changeset in webkit [118770] by commit-queue@webkit.org
  • 5 edits in trunk/LayoutTests

[EFL] Tests needs gardening after r118733
​https://bugs.webkit.org/show_bug.cgi?id=87733

Unreviewed gardening.

Patch by Thiago Marcos P. Santos <​thiago.santos@intel.com> on 2012-05-29

  • platform/efl/fast/css/text-overflow-input-expected.txt:
  • platform/efl/fast/forms/search-styled-expected.png:
  • platform/efl/fast/forms/search-styled-expected.txt:
  • platform/efl/test_expectations.txt:
6:53 AM Changeset in webkit [118769] by vestbo@webkit.org
  • 2 edits in trunk/Source/WTF

[Qt] Remove duplication of logic for disabling selected warnings related to C++11

This is already handled in unix/default_post.prf

Reviewed by Simon Hausmann.

6:41 AM Changeset in webkit [118768] by apavlov@chromium.org
  • 2 edits in trunk/Source/WebCore

[Chromium] [Regression] SELECT popup misplaced when there is not enough vertical space
​https://bugs.webkit.org/show_bug.cgi?id=87735

Reviewed by Kent Tamura.

This change fixes the obsolete WebWidget Y-repositioning code for the insufficient vertical space case, not removed in r113418.

No new tests, as popups are not testable in Chromium.

  • platform/chromium/PopupContainer.cpp:

(WebCore::PopupContainer::layoutAndCalculateWidgetRect):

6:39 AM Changeset in webkit [118767] by commit-queue@webkit.org
  • 7 edits
    2 adds
    2 deletes in trunk

[CSS Regions]Rename NamedFlow::overflow to NamedFlow::overset
​https://bugs.webkit.org/show_bug.cgi?id=87491

This patch updates the CSSOM property name overflow to overset. There are no changes in functionality.
Link to spec: ​http://www.w3.org/TR/2012/WD-css3-regions-20120503/

Source/WebCore:

Patch by Andrei Bucur <​abucur@adobe.com> on 2012-05-29
Reviewed by Andreas Kling.

Test: fast/regions/webkit-named-flow-overset.html

  • dom/WebKitNamedFlow.cpp:

(WebCore::WebKitNamedFlow::overset):

  • dom/WebKitNamedFlow.h:

(WebKitNamedFlow):

  • dom/WebKitNamedFlow.idl:
  • rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::RenderFlowThread):
(WebCore::RenderFlowThread::computeOverflowStateForRegions):

  • rendering/RenderFlowThread.h:

LayoutTests:

The test was refactored to be more similar to the other script tests (by using make-new-script-test)

Patch by Andrei Bucur <​abucur@adobe.com> on 2012-05-29
Reviewed by Andreas Kling.

  • fast/regions/webkit-named-flow-overflow-expected.txt: Removed.
  • fast/regions/webkit-named-flow-overflow.html: Removed.
  • fast/regions/webkit-named-flow-overset-expected.txt: Added.
  • fast/regions/webkit-named-flow-overset.html: Added.
6:37 AM Changeset in webkit [118766] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] REGRESSION(r118568): It broke fast/forms/textarea-maxlength.html on Qt 4.8
​https://bugs.webkit.org/show_bug.cgi?id=87740

Unreviewed gardening.

  • platform/qt-4.8/Skipped: Skip fast/forms/textarea-maxlength.html until proper fix.
6:34 AM Changeset in webkit [118765] by Csaba Osztrogonác
  • 5 edits
    1 add in trunk/LayoutTests

[Qt] Unreviewed gardening.

  • platform/qt-4.8/Skipped: Skip fast/parser/innerhtml-with-prefixed-elements.xhtml because of buggy QtXmlPatterns.
  • platform/qt-5.0/Skipped: Unskip fast/parser/innerhtml-with-prefixed-elements.xhtml, because libxslt works fine.
  • platform/qt/Skipped: Unskip a non-existing test.
  • platform/qt/fast/parser/innerhtml-with-prefixed-elements-expected.png: Added.
  • platform/qt/fast/parser/innerhtml-with-prefixed-elements-expected.txt: Updated.
6:26 AM Changeset in webkit [118764] by kenneth@webkit.org
  • 1 edit
    4 moves in trunk/Source/WebKit2

[Qt] Move tests from DesktopBehavior which can be made to work
​https://bugs.webkit.org/show_bug.cgi?id=87736

Rubberstamped by Simon Hausmann.

Move and modify the following tests to WebView/ and make them
use touch events.

  • UIProcess/API/qt/tests/qmltests/WebView/tst_itemSelector.qml: Renamed from Source/WebKit2/UIProcess/API/qt/tests/qmltests/DesktopBehavior/tst_itemSelector.qml.
  • UIProcess/API/qt/tests/qmltests/WebView/tst_messaging.qml: Renamed from Source/WebKit2/UIProcess/API/qt/tests/qmltests/DesktopBehavior/tst_messaging.qml.
  • UIProcess/API/qt/tests/qmltests/WebView/tst_multiFileUpload.qml: Renamed from Source/WebKit2/UIProcess/API/qt/tests/qmltests/DesktopBehavior/tst_multiFileUpload.qml.
  • UIProcess/API/qt/tests/qmltests/WebView/tst_singleFileUpload.qml: Renamed from Source/WebKit2/UIProcess/API/qt/tests/qmltests/DesktopBehavior/tst_singleFileUpload.qml.
6:21 AM Changeset in webkit [118763] by vestbo@webkit.org
  • 2 edits in trunk/Tools

[Qt] Don't add cxx-flags to QMAKE_CFLAGS

Prevents warnings such as: "command line option ‘-Wno-c++0x-compat’ is

valid for C++/ObjC++ but not for C [enabled by default]"

Reviewed by Simon Hausmann.

6:17 AM Changeset in webkit [118762] by vestbo@webkit.org
  • 15 edits in trunk

[Qt] Sync up favicon-implementation with WebView url changes in r118158

​https://bugs.webkit.org/show_bug.cgi?id=87133

We now base64-encode the page url in the image-provider url, so that any
normalization done by QUrl will not mess up the page-url. The logic of
creating and parsing the provider-url has been moved into the image
provider, to keep it in one place.

We were also releasing icons (even ones we hadn't retained), which we can't
do since we don't know when the icon url is no longer in use.

Reviewed-by Simon Hausmann.

5:25 AM Changeset in webkit [118761] by kling@webkit.org
  • 24 edits in trunk/Source/WebCore

Give StylePropertySet a proper mutability flag.
<​http://webkit.org/b/87675>

Reviewed by Antti Koivisto.

Add a flag to StylePropertySet that determines whether it's mutable or not. Only objects
constructed from the CSS parser (by way of StylePropertySet::adopt()) are made immutable.
This is clean-up and prep work for implementing a more efficient storage scheme for immutable
StylePropertySets (fixed-size array instead of vector) as the vast majority of them are
unlikely to ever mutate during their lifetime.

Sprinkled ASSERT(isMutable()) all over StylePropertySet to catch any attempts to modify
an immutable object.

Also made properties() const on StyleRule and friends, which brought some additional code
churn along with it.

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::copyPropertiesInSet):

  • css/CSSFontFaceRule.cpp:

(WebCore::CSSFontFaceRule::style):
(WebCore::CSSFontFaceRule::reattach):

  • css/CSSFontFaceSrcValue.cpp:

(WebCore::CSSFontFaceSrcValue::addSubresourceStyleURLs):

  • css/CSSFontFaceSrcValue.h:

(CSSFontFaceSrcValue):

  • css/CSSPageRule.cpp:

(WebCore::CSSPageRule::style):
(WebCore::CSSPageRule::reattach):

  • css/CSSPrimitiveValue.cpp:

(WebCore::CSSPrimitiveValue::addSubresourceStyleURLs):

  • css/CSSPrimitiveValue.h:

(CSSPrimitiveValue):

  • css/CSSReflectValue.cpp:

(WebCore::CSSReflectValue::addSubresourceStyleURLs):

  • css/CSSReflectValue.h:

(CSSReflectValue):

  • css/CSSStyleRule.cpp:

(WebCore::CSSStyleRule::style):
(WebCore::CSSStyleRule::reattach):

  • css/CSSValue.cpp:

(WebCore::CSSValue::addSubresourceStyleURLs):

  • css/CSSValue.h:

(CSSValue):

  • css/CSSValueList.cpp:

(WebCore::CSSValueList::addSubresourceStyleURLs):

  • css/CSSValueList.h:

(CSSValueList):

  • css/StylePropertySet.cpp:

(WebCore::StylePropertySet::StylePropertySet):
(WebCore::StylePropertySet::setCSSParserMode):
(WebCore):
(WebCore::StylePropertySet::copyPropertiesFrom):
(WebCore::StylePropertySet::removeShorthandProperty):
(WebCore::StylePropertySet::removeProperty):
(WebCore::StylePropertySet::setProperty):
(WebCore::StylePropertySet::parseDeclaration):
(WebCore::StylePropertySet::addParsedProperties):
(WebCore::StylePropertySet::addParsedProperty):
(WebCore::StylePropertySet::merge):
(WebCore::StylePropertySet::addSubresourceStyleURLs):
(WebCore::StylePropertySet::removePropertiesInSet):
(WebCore::StylePropertySet::findPropertyWithId):
(WebCore::StylePropertySet::removeEquivalentProperties):
(WebCore::StylePropertySet::copyPropertiesInSet):

  • css/StylePropertySet.h:

(WebCore::StylePropertySet::adopt):
(WebCore::StylePropertySet::adoptMutable):
(StylePropertySet):
(WebCore::StylePropertySet::isMutable):

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::addMatchedProperties):
(WebCore::StyleResolver::collectMatchingRulesForList):

  • css/StyleResolver.h:

(StyleResolver):

  • css/StyleRule.cpp:

(WebCore::StyleRule::mutableProperties):
(WebCore):
(WebCore::StyleRulePage::mutableProperties):
(WebCore::StyleRuleFontFace::mutableProperties):

  • css/StyleRule.h:

(WebCore::StyleRule::properties):
(StyleRule):
(WebCore::StyleRuleFontFace::properties):
(StyleRuleFontFace):
(WebCore::StyleRulePage::properties):
(StyleRulePage):

  • dom/ElementAttributeData.cpp:

(WebCore::ElementAttributeData::ensureInlineStyle):
(WebCore::ElementAttributeData::updateInlineStyleAvoidingMutation):

  • editing/EditingStyle.cpp:

(WebCore::styleFromMatchedRulesForElement):

  • svg/SVGFontFaceElement.cpp:

(WebCore::SVGFontFaceElement::parseAttribute):
(WebCore::SVGFontFaceElement::rebuildFontFace):
(WebCore::SVGFontFaceElement::removedFrom):

5:13 AM Changeset in webkit [118760] by commit-queue@webkit.org
  • 5 edits in trunk

[EFL] Refactoring. Get rid of unnecessary singleCharacterString() function
​https://bugs.webkit.org/show_bug.cgi?id=87654

Patch by Mikhail Pozdnyakov <​mikhail.pozdnyakov@intel.com> on 2012-05-29
Reviewed by Csaba Osztrogonác.

Source/WebCore:

Evas key events already provide key string, so no practical need for singleCharacterString()
evaluating the event string from keyname.
Modified code related functionality is already covered with fast/events and fast/forms tests.

  • platform/efl/EflKeyboardUtilities.cpp:
  • platform/efl/PlatformKeyboardEventEfl.cpp:

(WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):

Tools:

Event sender provides strings for all the key events.
Also KeyEventInfo constructor parameters order was changed to simplify the case when
a key event has empty string.

  • DumpRenderTree/efl/EventSender.cpp:

(KeyEventInfo::KeyEventInfo):
(keyPadNameFromJSValue):
(keyNameFromJSValue):

5:10 AM Changeset in webkit [118759] by zandobersek@gmail.com
  • 11 edits in trunk/LayoutTests

Unreviewed GTK gardening after r118733 and r118735.

  • platform/gtk/fast/css/text-overflow-input-expected.txt:
  • platform/gtk/fast/forms/input-placeholder-visibility-1-expected.txt:
  • platform/gtk/fast/forms/input-placeholder-visibility-3-expected.txt:
  • platform/gtk/fast/forms/placeholder-position-expected.txt:
  • platform/gtk/fast/forms/placeholder-pseudo-style-expected.txt:
  • platform/gtk/fast/forms/search-styled-expected.txt:
  • platform/gtk/fast/forms/textarea-placeholder-pseudo-style-expected.txt:
  • platform/gtk/fast/forms/textarea-placeholder-visibility-1-expected.txt:
  • platform/gtk/fast/forms/textarea-placeholder-visibility-2-expected.txt:
  • platform/gtk/test_expectations.txt:
5:09 AM Changeset in webkit [118758] by kenneth@webkit.org
  • 8 edits in trunk/Source/WebKit2

[Qt][WK2] Fix failing qmltests::FitToView::test_basic()
​https://bugs.webkit.org/show_bug.cgi?id=87236

Reviewed by Simon Hausmann.

The fix is a combination of things. First of all some events
were emitted at the wrong times or when nothing had changed.

We also initialized the view saying it was suspended which is
not correct.

Another bug was that the touch tap, didn't result in marking
the view as having user interaction. This was recently fixed
in r118493.

  • UIProcess/API/qt/qquickwebpage.cpp:

(QQuickWebPage::setContentsScale):

  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewFlickablePrivate::QQuickWebViewFlickablePrivate):

Make sure pageIsSuspended is initialized to false.

(QQuickWebViewFlickablePrivate::_q_onInformVisibleContentChange):

Early bail out if there is no change.

Inform contentScaleCommitted if the scale changed since last time.

(QQuickWebViewFlickablePrivate::didChangeContentsSize):

Make sure to commit the right signals, ie. *Changed and not *Committed.

  • UIProcess/API/qt/qquickwebview_p.h:
  • UIProcess/API/qt/qwebkittest.cpp:

(touchPoint):
(QWebKitTest::sendTouchEvent):
(QWebKitTest::touchTap):
(QWebKitTest::touchDoubleTap):

Add proper touch emulation for the testing system. Call directly
to our WebKit API (avoid Qt event loop) to ensure all events gets
delivered.

  • UIProcess/API/qt/qwebkittest_p.h:
  • UIProcess/qt/QtViewportInteractionEngine.cpp:

(WebKit::QtViewportInteractionEngine::setItemRectVisible):

Assert that a ViewportUpdateDeferrer is always used when calling
this method.

(WebKit::QtViewportInteractionEngine::animateItemRectVisible):

Remove work around now we have the proper fix in place.

(WebKit::QtViewportInteractionEngine::pagePositionRequest):

Do not send the informVisibleContentChange manually, use the
ViewportUpdateDeferrer instead.

(WebKit::QtViewportInteractionEngine::cancelScrollAnimation):

Add missing ViewportUpdateDeferrer.

(WebKit::QtViewportInteractionEngine::pinchGestureStarted):

No reason to emit informVisibleContentChange before pinch
start, as it is always done on end (due to the ViewportUpdateDeferrer).

(WebKit::QtViewportInteractionEngine::itemSizeChanged):

Add missing ViewportUpdateDeferrer.

4:43 AM Changeset in webkit [118757] by kkristof@inf.u-szeged.hu
  • 10 edits in trunk/LayoutTests

[Qt] Unreviewed Gardening. Update test expectations after r118733.

Patch by Ádám Kallai <​kadam@inf.u-szeged.hu> on 2012-05-29

  • platform/qt/fast/css/text-overflow-input-expected.txt:
  • platform/qt/fast/forms/input-placeholder-visibility-1-expected.txt:
  • platform/qt/fast/forms/input-placeholder-visibility-3-expected.txt:
  • platform/qt/fast/forms/placeholder-position-expected.txt:
  • platform/qt/fast/forms/placeholder-pseudo-style-expected.txt:
  • platform/qt/fast/forms/search-styled-expected.txt:
  • platform/qt/fast/forms/textarea-placeholder-pseudo-style-expected.txt:
  • platform/qt/fast/forms/textarea-placeholder-visibility-1-expected.txt:
  • platform/qt/fast/forms/textarea-placeholder-visibility-2-expected.txt:
4:43 AM Changeset in webkit [118756] by caio.oliveira@openbossa.org
  • 10 edits
    5 adds in trunk/Source/WebKit2

[Qt] [WK2] Allow user to inject JS scripts when the page loads
​https://bugs.webkit.org/show_bug.cgi?id=85827

Reviewed by Simon Hausmann.

Create a new experimental property to list URLs of JS scripts that should be
loaded when a page is loaded. These scripts will run in the normal JS environment
of the page.

The supported URL schemes are ​file:/// and qrc:///. The scripts are read from the
UI process and transfered to the Web process.

Together with the experimental messaging API this provides a way for the
application to manipulate the DOM (by injecting a script that does the
manipulation and communicating with it via postMessage). This covers some of the
use cases of QWebElement in our WK1 API.

  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewPrivate::didRelaunchProcess):
(readUserScript):
(QQuickWebViewPrivate::updateUserScripts):
(QQuickWebViewExperimental::userScripts):
(QQuickWebViewExperimental::setUserScripts):

  • UIProcess/API/qt/qquickwebview_p.h:
  • UIProcess/API/qt/qquickwebview_p_p.h:

(QQuickWebViewPrivate):

  • UIProcess/API/qt/tests/qmltests/WebView.pro:
  • UIProcess/API/qt/tests/qmltests/WebView/tst_userScripts.qml: Added.
  • UIProcess/API/qt/tests/qmltests/common/append-document-title.js: Added.
  • UIProcess/API/qt/tests/qmltests/common/big-user-script.js: Added.
  • UIProcess/API/qt/tests/qmltests/common/change-document-title.js: Added.
  • UIProcess/API/qt/tests/qmltests/resources.qrc: Added.
  • UIProcess/WebPageProxy.h:

(WebPageProxy):

  • UIProcess/qt/WebPageProxyQt.cpp:

(WebKit::WebPageProxy::setUserScripts):
(WebKit):

  • WebProcess/WebPage/WebPage.h:

(WebPage):

  • WebProcess/WebPage/WebPage.messages.in:
  • WebProcess/WebPage/qt/WebPageQt.cpp:

(WebKit::WebPage::setUserScripts):
(WebKit):

4:42 AM Changeset in webkit [118755] by vestbo@webkit.org
  • 2 edits in trunk/Tools

[Qt] Cancel potential url-edit when going back/forward

Reviewed by Kenneth Rohde Christiansen.

  • MiniBrowser/qt/qml/BrowserWindow.qml:
4:37 AM Changeset in webkit [118754] by caio.oliveira@openbossa.org
  • 10 edits in trunk/Source/WebKit2

Unreviewed, rolling out r118752.
​http://trac.webkit.org/changeset/118752
​https://bugs.webkit.org/show_bug.cgi?id=87731

incomplete patch (Requested by cmarcelo on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-05-29

  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewPrivate::didRelaunchProcess):

  • UIProcess/API/qt/qquickwebview_p.h:
  • UIProcess/API/qt/qquickwebview_p_p.h:

(QQuickWebViewPrivate):

  • UIProcess/API/qt/tests/qmltests/WebView.pro:
  • UIProcess/WebPageProxy.h:

(WebPageProxy):

  • UIProcess/qt/WebPageProxyQt.cpp:
  • WebProcess/WebPage/WebPage.h:

(WebPage):

  • WebProcess/WebPage/WebPage.messages.in:
  • WebProcess/WebPage/qt/WebPageQt.cpp:
4:36 AM Changeset in webkit [118753] by Stephanie Lewis
  • 2 edits in trunk/LayoutTests

Unreviewed, skipping failing test
See ​https://bugs.webkit.org/show_bug.cgi?id=87728

  • platform/mac/Skipped:
4:22 AM Changeset in webkit [118752] by caio.oliveira@openbossa.org
  • 10 edits in trunk/Source/WebKit2

[Qt] [WK2] Allow user to inject JS scripts when the page loads
​https://bugs.webkit.org/show_bug.cgi?id=85827

Reviewed by Simon Hausmann.

Create a new experimental property to list URLs of JS scripts that should be
loaded when a page is loaded. These scripts will run in the normal JS environment
of the page.

The supported URL schemes are ​file:/// and qrc:///. The scripts are read from the
UI process and transfered to the Web process.

Together with the experimental messaging API this provides a way for the
application to manipulate the DOM (by injecting a script that does the
manipulation and communicating with it via postMessage). This covers some of the
use cases of QWebElement in our WK1 API.

  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewPrivate::didRelaunchProcess):
(readUserScript):
(QQuickWebViewPrivate::updateUserScripts):
(QQuickWebViewExperimental::userScripts):
(QQuickWebViewExperimental::setUserScripts):

  • UIProcess/API/qt/qquickwebview_p.h:
  • UIProcess/API/qt/qquickwebview_p_p.h:

(QQuickWebViewPrivate):

  • UIProcess/API/qt/tests/qmltests/WebView.pro:
  • UIProcess/API/qt/tests/qmltests/WebView/tst_userScripts.qml: Added.
  • UIProcess/API/qt/tests/qmltests/common/append-document-title.js: Added.
  • UIProcess/API/qt/tests/qmltests/common/big-user-script.js: Added.
  • UIProcess/API/qt/tests/qmltests/common/change-document-title.js: Added.
  • UIProcess/API/qt/tests/qmltests/resources.qrc: Added.
  • UIProcess/WebPageProxy.h:

(WebPageProxy):

  • UIProcess/qt/WebPageProxyQt.cpp:

(WebKit::WebPageProxy::setUserScripts):
(WebKit):

  • WebProcess/WebPage/WebPage.h:

(WebPage):

  • WebProcess/WebPage/WebPage.messages.in:
  • WebProcess/WebPage/qt/WebPageQt.cpp:

(WebKit::WebPage::setUserScripts):
(WebKit):

4:14 AM Changeset in webkit [118751] by Stephanie Lewis
  • 10 edits
    3 adds in trunk/LayoutTests

Unreviewed, updating results after ​http://trac.webkit.org/projects/webkit/changeset/118733

  • platform/mac/fast/css/text-overflow-input-expected.txt:
  • platform/mac/fast/forms/input-placeholder-visibility-1-expected.txt:
  • platform/mac/fast/forms/input-placeholder-visibility-3-expected.txt:
  • platform/mac/fast/forms/placeholder-position-expected.txt:
  • platform/mac/fast/forms/placeholder-pseudo-style-expected.txt:
  • platform/mac/fast/forms/search-styled-expected.txt:
  • platform/mac/fast/forms/textarea-placeholder-pseudo-style-expected.txt:
  • platform/mac/fast/forms/textarea-placeholder-visibility-1-expected.txt:
  • platform/mac/fast/forms/textarea-placeholder-visibility-2-expected.txt:
4:14 AM Changeset in webkit [118750] by commit-queue@webkit.org
  • 7 edits
    9 adds in trunk/Source/WebKit

[BlackBerry] WebOverlay API
​https://bugs.webkit.org/show_bug.cgi?id=87603

Patch by Arvid Nilsson <​anilsson@rim.com> on 2012-05-29
Reviewed by Rob Buis.

Source/WebKit:

Add WebOverlay related files to the build system.

PR #156812

  • PlatformBlackBerry.cmake:

Source/WebKit/blackberry:

This new API makes it possible to leverage the BlackBerry accelerated
compositing implementation to draw, transform and fluidly animate
overlays in the embedding library or application.

A WebOverlay has an affinity for the thread where it was created. If
the current thread is the WebKit thread, use WebPage::addOverlay() to
add it to the page, and manipulate it only from the WebKit thread, with
exception of the "override" functionality which can be used from the
compositing thread. If the current thread is the compositing thread,
use WebPage::addCompositingThreadOverlay() to add it to the page, and
only manipulate it on the compositing thread.

A WebOverlay can be painted using Skia, or its contents can be set to
an image or a solid color.

PR #156812

  • Api/WebAnimation.cpp: Added.

(WebKit):
(BlackBerry::WebKit::WebAnimation::fadeAnimation):
(BlackBerry::WebKit::WebAnimation::name):
(BlackBerry::WebKit::WebAnimation::WebAnimation):
(BlackBerry::WebKit::WebAnimation::~WebAnimation):
(BlackBerry::WebKit::WebAnimation::operator=):

  • Api/WebAnimation.h: Added.

(WebKit):

  • Api/WebAnimation_p.h: Added.

(WebKit):
(WebAnimationPrivate):
(BlackBerry::WebKit::WebAnimationPrivate::WebAnimationPrivate):

  • Api/WebOverlay.cpp: Added.

(WebKit):
(BlackBerry::WebKit::WebOverlay::WebOverlay):
(BlackBerry::WebKit::WebOverlay::~WebOverlay):
(BlackBerry::WebKit::WebOverlay::position):
(BlackBerry::WebKit::WebOverlay::setPosition):
(BlackBerry::WebKit::WebOverlay::anchorPoint):
(BlackBerry::WebKit::WebOverlay::setAnchorPoint):
(BlackBerry::WebKit::WebOverlay::size):
(BlackBerry::WebKit::WebOverlay::setSize):
(BlackBerry::WebKit::WebOverlay::sizeIsScaleInvariant):
(BlackBerry::WebKit::WebOverlay::setSizeIsScaleInvariant):
(BlackBerry::WebKit::WebOverlay::transform):
(BlackBerry::WebKit::WebOverlay::setTransform):
(BlackBerry::WebKit::WebOverlay::opacity):
(BlackBerry::WebKit::WebOverlay::setOpacity):
(BlackBerry::WebKit::WebOverlay::addAnimation):
(BlackBerry::WebKit::WebOverlay::removeAnimation):
(BlackBerry::WebKit::WebOverlay::parent):
(BlackBerry::WebKit::WebOverlay::addChild):
(BlackBerry::WebKit::WebOverlay::removeFromParent):
(BlackBerry::WebKit::WebOverlay::setContentsToImage):
(BlackBerry::WebKit::WebOverlay::setContentsToColor):
(BlackBerry::WebKit::WebOverlay::setDrawsContent):
(BlackBerry::WebKit::WebOverlay::invalidate):
(BlackBerry::WebKit::WebOverlay::setClient):
(BlackBerry::WebKit::WebOverlay::override):
(BlackBerry::WebKit::WebOverlay::resetOverrides):
(BlackBerry::WebKit::WebOverlayPrivate::page):
(BlackBerry::WebKit::WebOverlayPrivate::override):
(BlackBerry::WebKit::WebOverlayPrivate::drawContents):
(BlackBerry::WebKit::WebOverlayPrivate::scheduleCompositingRun):
(BlackBerry::WebKit::WebOverlayPrivateWebKitThread::WebOverlayPrivateWebKitThread):
(BlackBerry::WebKit::WebOverlayPrivateWebKitThread::override):
(BlackBerry::WebKit::WebOverlayPrivateWebKitThread::position):
(BlackBerry::WebKit::WebOverlayPrivateWebKitThread::setPosition):
(BlackBerry::WebKit::WebOverlayPrivateWebKitThread::anchorPoint):
(BlackBerry::WebKit::WebOverlayPrivateWebKitThread::setAnchorPoint):
(BlackBerry::WebKit::WebOverlayPrivateWebKitThread::size):
(BlackBerry::WebKit::WebOverlayPrivateWebKitThread::setSize):
(BlackBerry::WebKit::WebOverlayPrivateWebKitThread::sizeIsScaleInvariant):
(BlackBerry::WebKit::WebOverlayPrivateWebKitThread::setSizeIsScaleInvariant):
(BlackBerry::WebKit::WebOverlayPrivateWebKitThread::transform):
(BlackBerry::WebKit::WebOverlayPrivateWebKitThread::setTransform):
(BlackBerry::WebKit::WebOverlayPrivateWebKitThread::opacity):
(BlackBerry::WebKit::WebOverlayPrivateWebKitThread::setOpacity):
(BlackBerry::WebKit::WebOverlayPrivateWebKitThread::addAnimation):
(BlackBerry::WebKit::WebOverlayPrivateWebKitThread::removeAnimation):
(BlackBerry::WebKit::WebOverlayPrivateWebKitThread::addChild):
(BlackBerry::WebKit::WebOverlayPrivateWebKitThread::removeFromParent):
(BlackBerry::WebKit::WebOverlayPrivateWebKitThread::setContentsToImage):
(BlackBerry::WebKit::WebOverlayPrivateWebKitThread::setContentsToColor):
(BlackBerry::WebKit::WebOverlayPrivateWebKitThread::setDrawsContent):
(BlackBerry::WebKit::WebOverlayPrivateWebKitThread::clear):
(BlackBerry::WebKit::WebOverlayPrivateWebKitThread::invalidate):
(BlackBerry::WebKit::WebOverlayPrivateWebKitThread::resetOverrides):
(BlackBerry::WebKit::WebOverlayPrivateWebKitThread::notifySyncRequired):
(BlackBerry::WebKit::WebOverlayPrivateWebKitThread::paintContents):
(BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::WebOverlayLayerCompositingThreadClient):
(BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::~WebOverlayLayerCompositingThreadClient):
(BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::setDrawsContent):
(BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::invalidate):
(BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::setContents):
(BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::setContentsToColor):
(BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::layerCompositingThreadDestroyed):
(BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::layerVisibilityChanged):
(BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::uploadTexturesIfNeeded):
(BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::drawTextures):
(BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::deleteTextures):
(BlackBerry::WebKit::WebOverlayPrivateCompositingThread::WebOverlayPrivateCompositingThread):
(BlackBerry::WebKit::WebOverlayPrivateCompositingThread::~WebOverlayPrivateCompositingThread):
(BlackBerry::WebKit::WebOverlayPrivateCompositingThread::setClient):
(BlackBerry::WebKit::WebOverlayPrivateCompositingThread::override):
(BlackBerry::WebKit::WebOverlayPrivateCompositingThread::position):
(BlackBerry::WebKit::WebOverlayPrivateCompositingThread::setPosition):
(BlackBerry::WebKit::WebOverlayPrivateCompositingThread::anchorPoint):
(BlackBerry::WebKit::WebOverlayPrivateCompositingThread::setAnchorPoint):
(BlackBerry::WebKit::WebOverlayPrivateCompositingThread::size):
(BlackBerry::WebKit::WebOverlayPrivateCompositingThread::setSize):
(BlackBerry::WebKit::WebOverlayPrivateCompositingThread::sizeIsScaleInvariant):
(BlackBerry::WebKit::WebOverlayPrivateCompositingThread::setSizeIsScaleInvariant):
(BlackBerry::WebKit::WebOverlayPrivateCompositingThread::transform):
(BlackBerry::WebKit::WebOverlayPrivateCompositingThread::setTransform):
(BlackBerry::WebKit::WebOverlayPrivateCompositingThread::opacity):
(BlackBerry::WebKit::WebOverlayPrivateCompositingThread::setOpacity):
(BlackBerry::WebKit::WebOverlayPrivateCompositingThread::addAnimation):
(BlackBerry::WebKit::WebOverlayPrivateCompositingThread::removeAnimation):
(BlackBerry::WebKit::WebOverlayPrivateCompositingThread::addChild):
(BlackBerry::WebKit::WebOverlayPrivateCompositingThread::removeFromParent):
(BlackBerry::WebKit::WebOverlayPrivateCompositingThread::setContentsToImage):
(BlackBerry::WebKit::WebOverlayPrivateCompositingThread::setContentsToColor):
(BlackBerry::WebKit::WebOverlayPrivateCompositingThread::setDrawsContent):
(BlackBerry::WebKit::WebOverlayPrivateCompositingThread::clear):
(BlackBerry::WebKit::WebOverlayPrivateCompositingThread::invalidate):
(BlackBerry::WebKit::WebOverlayPrivateCompositingThread::resetOverrides):

  • Api/WebOverlay.h: Added.

(WebCore):
(WebKit):

  • Api/WebOverlayClient.h: Added.

(WebKit):

  • Api/WebOverlayOverride.cpp: Added.

(WebKit):
(BlackBerry::WebKit::WebOverlayOverride::WebOverlayOverride):
(BlackBerry::WebKit::WebOverlayOverride::~WebOverlayOverride):
(BlackBerry::WebKit::WebOverlayOverride::setPosition):
(BlackBerry::WebKit::WebOverlayOverride::setAnchorPoint):
(BlackBerry::WebKit::WebOverlayOverride::setSize):
(BlackBerry::WebKit::WebOverlayOverride::setTransform):
(BlackBerry::WebKit::WebOverlayOverride::setOpacity):
(BlackBerry::WebKit::WebOverlayOverride::addAnimation):
(BlackBerry::WebKit::WebOverlayOverride::removeAnimation):

  • Api/WebOverlayOverride.h: Added.

(WebKit):

  • Api/WebOverlay_p.h: Added.

(WTF):
(WebCore):
(WebKit):
(WebOverlayPrivate):
(BlackBerry::WebKit::WebOverlayPrivate::WebOverlayPrivate):
(BlackBerry::WebKit::WebOverlayPrivate::~WebOverlayPrivate):
(BlackBerry::WebKit::WebOverlayPrivate::setPage):
(BlackBerry::WebKit::WebOverlayPrivate::setClient):
(BlackBerry::WebKit::WebOverlayPrivate::layerCompositingThread):
(BlackBerry::WebKit::WebOverlayPrivate::graphicsLayer):
(WebOverlayPrivateWebKitThread):
(BlackBerry::WebKit::WebOverlayPrivateWebKitThread::graphicsLayer):
(BlackBerry::WebKit::WebOverlayPrivateWebKitThread::notifyAnimationStarted):
(BlackBerry::WebKit::WebOverlayPrivateWebKitThread::showDebugBorders):
(BlackBerry::WebKit::WebOverlayPrivateWebKitThread::showRepaintCounter):
(BlackBerry::WebKit::WebOverlayPrivateWebKitThread::contentsVisible):
(WebOverlayLayerCompositingThreadClient):
(BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::setLayer):
(BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::setClient):
(BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::drawsContent):
(BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::contents):
(WebOverlayPrivateCompositingThread):

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPage::addOverlay):
(WebKit):
(BlackBerry::WebKit::WebPage::removeOverlay):
(BlackBerry::WebKit::WebPage::addCompositingThreadOverlay):
(BlackBerry::WebKit::WebPage::removeCompositingThreadOverlay):

  • Api/WebPage.h:

(WebKit):

  • Api/WebPageCompositor.cpp:

(BlackBerry::WebKit::WebPageCompositorPrivate::prepareFrame):
(BlackBerry::WebKit::WebPageCompositorPrivate::render):
(WebKit):
(BlackBerry::WebKit::WebPageCompositorPrivate::compositeLayers):
(BlackBerry::WebKit::WebPageCompositorPrivate::drawLayers):
(BlackBerry::WebKit::WebPageCompositorPrivate::addOverlay):
(BlackBerry::WebKit::WebPageCompositorPrivate::removeOverlay):

  • Api/WebPageCompositor_p.h:

(BlackBerry::WebKit::WebPageCompositorPrivate::compositingThreadOverlayLayer):
(WebPageCompositorPrivate):

4:14 AM Changeset in webkit [118749] by loislo@chromium.org
  • 2 edits in trunk/Source/WebCore

Unreviewed: Web Inspector: single line fix after r118742.

  • inspector/front-end/HeapSnapshotView.js:

(WebInspector.HeapProfileHeader.prototype.saveToFile):

3:42 AM Changeset in webkit [118748] by haraken@chromium.org
  • 4 edits in trunk/Source/WebCore

Remove m_rootNode and m_selectorChecker from SelectorQuery.h
​https://bugs.webkit.org/show_bug.cgi?id=87650

Reviewed by Antti Koivisto.

To avoid parsing CSS selectors every time, I am planning to cache
SelectorQuery objects into a HashMap, which will be defined in
Node::querySelector(). To make the size of SelectorQuery small,
this patch removes m_rootNode and m_selectorChecker from SelectorQuery.h.

Tests: fast/dom/SelectorAPI/*. No change in test results.

  • dom/Node.cpp:

(WebCore::Node::querySelector):
(WebCore::Node::querySelectorAll):

  • dom/SelectorQuery.cpp:

(WebCore::SelectorQuery::SelectorQuery):
(WebCore):
(WebCore::SelectorQuery::queryAll):
(WebCore::SelectorQuery::queryFirst):

  • dom/SelectorQuery.h:

(SelectorQuery):

3:06 AM Changeset in webkit [118747] by caseq@chromium.org
  • 6 edits in trunk/Source/WebCore

Web Inspector: Tabbed Settings Screen
​https://bugs.webkit.org/show_bug.cgi?id=87497

Patch by Eugene Klyuchnikov <​eustas.bug@gmail.com> on 2012-05-29
Reviewed by Yury Semikhatsky.

Combine settings screen and shortcuts screen
to a single tabbed settings screen.
This will make shortcuts screen more discoverable.

  • inspector/front-end/HelpScreen.js:

(WebInspector.HelpScreen): Make titled tamplate optional.
(WebInspector.HelpScreen.prototype._createCloseButton): Extract method.

  • inspector/front-end/SettingsScreen.js:

(WebInspector.SettingsScreen): Split initialization and UI construction.
(WebInspector.SettingsScreen.prototype._createSettingsTabView.appendSection):
(WebInspector.SettingsScreen.prototype._createSettingsTabView):
Extract GUI construction method.
(WebInspector.SettingsScreen.prototype._getOrCreateTabbedPane):
Make GUI construction lazy.
(WebInspector.SettingsScreen.prototype.selectTab):
Add method for external tab swithching.
(WebInspector.SettingsScreen.prototype.wasShown):
Make GUI construction lazy.
(WebInspector.SettingsScreenTabbedPane):
Extend class to access protected member.
(WebInspector.SettingsController.prototype._buttonClicked):
Change "showSettingsScreen" visibility and parameters.
(WebInspector.SettingsController.prototype._onHideSettingsScreen):
Preserve settings screen state.
(WebInspector.SettingsController.prototype.showSettingsScreen):
Change method visibility and parameters.

  • inspector/front-end/ShortcutsScreen.js:

(WebInspector.ShortcutsScreen): Remove inheritance from HelpScreen.
(WebInspector.ShortcutsScreen.prototype._createShortcutsTabView):
Refactoring of GUI construction.
(WebInspector.ShortcutsSection.prototype.renderSection):
Ditto.

  • inspector/front-end/helpScreen.css:

(.help-window-main ::-webkit-scrollbar): Rebind scrollbar settings.
(.help-window-main ::-webkit-resizer): Ditto.
(.help-window-main ::-webkit-scrollbar-thumb:vertical): Ditto.
(.help-window-main ::-webkit-scrollbar-thumb:vertical:active): Ditto.
(.help-window-main ::-webkit-scrollbar-track:vertical): Ditto.
(body:not(.compact) #settings-screen .tabbed-pane): Fix container height.
(#settings-screen .tabbed-pane-header): Ditto.
(#settings-screen .tabbed-pane-header-tabs): Adjust spacing.
(#settings-screen .tabbed-pane-header-tab): Adjust style.
(#settings-screen .help-close-button): Adjust spacing.
(#settings-screen .tabbed-pane-header-tab.selected):
Erase line below active tab.
(#settings-screen .tabbed-pane-content): Adjust spacing.
(#settings-screen .help-content): Ditto.

  • inspector/front-end/inspector.js:

(WebInspector.documentKeyDown): Use Settings screen to show shortcuts.

2:43 AM Changeset in webkit [118746] by peter@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled DEPS.

  • DEPS:
2:35 AM Changeset in webkit [118745] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Update test expectations
​https://bugs.webkit.org/show_bug.cgi?id=87155

More placehodler tests.

  • platform/chromium/test_expectations.txt:
2:29 AM Changeset in webkit [118744] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Update test expectations.
​https://bugs.webkit.org/show_bug.cgi?id=87155

Placeholder-related render dumps need to be udpated.

  • platform/chromium/test_expectations.txt:
2:20 AM Changeset in webkit [118743] by kkristof@inf.u-szeged.hu
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening after r118618. http/tests/cache/cancel-in-progress-load.html
fails with code 5.
​https://bugs.webkit.org/show_bug.cgi?id=35377

Patch by János Badics <János Badics> on 2012-05-29

  • platform/qt/Skipped:
2:17 AM Changeset in webkit [118742] by loislo@chromium.org
  • 8 edits in trunk

Web Inspector: REGRESSION: load heap snapshot doesn't work.
​https://bugs.webkit.org/show_bug.cgi?id=87642

Source/WebCore:

HeapSnapshotReceiver interface was introduced.
It declares the API for HeapSnapshotLoader, HeapSnapshotLoaderProxy and HeapSnapshotSaveToFileReceiver.
The HeapProfileHeader was refactored and tests were added.

Reviewed by Yury Semikhatsky.

  • inspector/front-end/HeapSnapshotLoader.js:

(WebInspector.HeapSnapshotLoader):
(WebInspector.HeapSnapshotLoader.prototype.startLoading):
(WebInspector.HeapSnapshotLoader.prototype.dispose):
(WebInspector.HeapSnapshotLoader.prototype._reset):
(WebInspector.HeapSnapshotLoader.prototype.finishLoading):

  • inspector/front-end/HeapSnapshotProxy.js:

(WebInspector.HeapSnapshotWorker.prototype.startCheckingForLongRunningCalls):
(WebInspector.HeapSnapshotLoaderProxy.prototype.startLoading):
(WebInspector.HeapSnapshotLoaderProxy.prototype.pushJSONChunk):
(WebInspector.HeapSnapshotLoaderProxy.prototype.finishLoading):

  • inspector/front-end/HeapSnapshotView.js:

(WebInspector.HeapSnapshotReceiver):
(WebInspector.HeapSnapshotReceiver.prototype.startLoading):
(WebInspector.HeapSnapshotReceiver.prototype.pushJSONChunk):
(WebInspector.HeapSnapshotReceiver.prototype.finishLoading):
(WebInspector.HeapSnapshotReceiver.prototype.dispose):
(WebInspector.HeapProfileHeader):
(WebInspector.HeapProfileHeader.prototype.load):
(WebInspector.HeapProfileHeader.prototype._setupWorker):
(WebInspector.HeapProfileHeader.prototype.dispose):
(WebInspector.HeapProfileHeader.prototype._saveStatusUpdate):
(WebInspector.HeapProfileHeader.prototype.pushJSONChunk):
(WebInspector.HeapProfileHeader.prototype._parsed):
(WebInspector.HeapProfileHeader.prototype.finishHeapSnapshot):
(WebInspector.HeapProfileHeader.prototype.saveToFile):
(WebInspector.HeapProfileHeader.prototype.loadFromFile.onLoad):
(WebInspector.HeapProfileHeader.prototype.loadFromFile):
(WebInspector.HeapProfileHeader.prototype._loadNextChunk):
(WebInspector.HeapProfileHeader.prototype._nextChunkLoaded):
(WebInspector.HeapProfileHeader.prototype._createFileReader):
(WebInspector.HeapSnapshotSaveToFileReceiver):
(WebInspector.HeapSnapshotSaveToFileReceiver.prototype.startLoading):
(WebInspector.HeapSnapshotSaveToFileReceiver.prototype.pushJSONChunk):
(WebInspector.HeapSnapshotSaveToFileReceiver.prototype.finishLoading):
(WebInspector.HeapSnapshotSaveToFileReceiver.prototype.dispose):
(WebInspector.HeapSnapshotSaveToFileReceiver.prototype._startSavingSnapshot):
(WebInspector.HeapSnapshotSaveToFileReceiver.prototype._saveStatusUpdate):

  • inspector/front-end/ProfilesPanel.js:

(WebInspector.ProfilesPanel.prototype._createFileSelectorElement.onChange):
(WebInspector.ProfilesPanel.prototype._createFileSelectorElement):
(WebInspector.ProfilesPanel.prototype._loadFromFile):

LayoutTests:

HeapSnapshotReceiver interface was introduced.
It declares the API for HSLoader, HSLoaderProxy and HSSaveToFileReceiver.
The HeapProfileHeader was refactored and tests were added.

Reviewed by Yury Semikhatsky.

  • inspector/profiler/heap-snapshot-loader-expected.txt:
  • inspector/profiler/heap-snapshot-loader.html:
2:12 AM Changeset in webkit [118741] by bulach@chromium.org
  • 2 edits in trunk/LayoutTests

Test expectation pngs missing checksums are treated as MISSING by bots
​https://bugs.webkit.org/show_bug.cgi?id=87552

Unreviewed gardening.

This test was already failing for IMAGE and TEXT reasons prior to r118566.
On r118566, new images were added, probably without an embedded checksum.
It looks like our test infrastructure thinks that these images are MISSING.
Temporarily add MISSING expectations, so that we can proceed with this (failing) test.

  • platform/chromium/test_expectations.txt:
2:10 AM Changeset in webkit [118740] by hbono@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Use WebSpellCheckClient::spellcheck to retrieve suggestions.
​https://bugs.webkit.org/show_bug.cgi?id=87690

Reviewed by Hajime Morita.

This change uses WebSpellCheckClient::spellcheck as a fallback method to
retrieve suggestions when a marker does not have any suggestions. (It consumes
lots of CPU power to get suggestions for misspelled word, i.e. Chromium cannot
afford to attach suggestions to all spelling markers.)

  • src/ContextMenuClientImpl.cpp:

(WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems): Retrieve suggestions if markers do not have any.

2:06 AM Changeset in webkit [118739] by commit-queue@webkit.org
  • 7 edits in trunk/LayoutTests

[EFL] MathML tests needs rebaseline after r118713
​https://bugs.webkit.org/show_bug.cgi?id=87705

Unreviewed gardening.

Patch by Thiago Marcos P. Santos <​thiago.santos@intel.com> on 2012-05-29

  • platform/efl/mathml/presentation/mo-stretch-expected.png:
  • platform/efl/mathml/presentation/mo-stretch-expected.txt:
  • platform/efl/mathml/presentation/mroot-pref-width-expected.png:
  • platform/efl/mathml/presentation/mroot-pref-width-expected.txt:
  • platform/efl/mathml/presentation/tables-expected.png:
  • platform/efl/mathml/presentation/tables-expected.txt:
2:05 AM Changeset in webkit [118738] by kkristof@inf.u-szeged.hu
  • 1 edit
    2 adds in trunk/LayoutTests

[Qt] Unreviewed gardening after r118585. Added Qt platform specific expected files.
​https://bugs.webkit.org/show_bug.cgi?id=86848

Patch by János Badics <János Badics> on 2012-05-29

  • platform/qt/http/tests/security/contentSecurityPolicy/inline-script-blocked-javascript-url-expected.txt: Added.
  • platform/qt/http/tests/security/contentSecurityPolicy/javascript-url-blocked-expected.txt: Added.
2:01 AM Changeset in webkit [118737] by eric@webkit.org
  • 11 edits in trunk

Add HTMLIFrameElement.seamless property accessor now that seamless is enabled and works
​https://bugs.webkit.org/show_bug.cgi?id=87708

Reviewed by Adam Barth.

Source/WebCore:

Lots of tests in fast/frames/seamless cover this property.

  • html/HTMLIFrameElement.idl:

LayoutTests:

  • fast/frames/seamless/seamless-basic-expected.txt:
  • fast/frames/seamless/seamless-inherited-origin-expected.txt:
  • fast/frames/seamless/seamless-nested-expected.txt:
  • fast/frames/seamless/seamless-quirks-expected.txt:
  • fast/frames/seamless/seamless-sandbox-flag-expected.txt:
  • fast/frames/seamless/seamless-sandbox-srcdoc-expected.txt:
  • http/tests/security/seamless/seamless-cross-origin-expected.txt:
  • http/tests/security/seamless/seamless-sandbox-srcdoc-expected.txt:
1:43 AM Changeset in webkit [118736] by haraken@chromium.org
  • 3 edits in trunk/Source/WebCore

[Performance] Optimize querySelector() and querySelectorAll() by removing
redundant dummy style sheet creations
​https://bugs.webkit.org/show_bug.cgi?id=87627

Reviewed by Antti Koivisto.

This patch improves performance of querySelector("#id") by 4.2% ~ 17.7%
in Safari and Chromium.

Performance tests: ​https://bugs.webkit.org/attachment.cgi?id=144288

The performance test results in my desktop:

[Safari/Mac]
document.querySelector("#headId") : 13.60 ms => 12.40 ms +9.68%
document.querySelector("#duplicatedId") : 14.80 ms => 14.20 ms +4.23%
document.querySelector("#tailId") : 13.80 ms => 12.20 ms +13.11%
document.querySelectorAll("#headId") : 17.80 ms => 14.60 ms +21.92%
document.querySelectorAll("#duplicatedId") : 513.80 ms => 471.60 ms +8.95%
document.querySelectorAll("#tailId") : 19.20 ms => 16.40 ms +17.07%
document.querySelector("h1") : 14.40 ms => 13.60 ms +5.88%
document.querySelector("h2") : 14.80 ms => 13.80 ms +7.25%
document.querySelector("h3") : 312.00 ms => 306.60 ms +1.76%
document.querySelectorAll("h1") : 322.00 ms => 314.60 ms +2.35%
document.querySelectorAll("h2") : 481.00 ms => 420.60 ms +14.36%
document.querySelectorAll("h3") : 326.80 ms => 315.80 ms +3.48%
document.querySelector(".headClass") : 16.20 ms => 15.40 ms +5.19%
document.querySelector(".duplicatedClass") : 17.00 ms => 15.40 ms +10.39%
document.querySelector(".tailClass") : 369.60 ms => 362.60 ms +1.93%
document.querySelectorAll(".headClass") : 388.20 ms => 377.60 ms +2.81%
document.querySelectorAll(".duplicatedClass") : 605.00 ms => 581.20 ms +4.09%
document.querySelectorAll(".tailClass") : 401.60 ms => 391.40 ms +2.61%

[Chromium/Linux]
ocument.querySelector("#headId") : 16.00 ms => 13.60 ms +17.65%
document.querySelector("#duplicatedId") : 16.80 ms => 15.40 ms +9.09%
document.querySelector("#tailId") : 16.00 ms => 13.60 ms +17.65%
document.querySelectorAll("#headId") : 29.00 ms => 25.00 ms +16.00%
document.querySelectorAll("#duplicatedId") : 561.40 ms => 505.20 ms +11.12%
document.querySelectorAll("#tailId") : 34.00 ms => 26.80 ms +26.87%
document.querySelector("h1") : 18.20 ms => 15.80 ms +15.19%
document.querySelector("h2") : 19.00 ms => 16.60 ms +14.46%
document.querySelector("h3") : 280.40 ms => 274.00 ms +2.34%
document.querySelectorAll("h1") : 300.20 ms => 365.20 ms -17.80%
document.querySelectorAll("h2") : 487.60 ms => 504.20 ms -3.29%
document.querySelectorAll("h3") : 349.40 ms => 324.00 ms +7.84%
document.querySelector(".headClass") : 18.40 ms => 16.00 ms +15.00%
document.querySelector(".duplicatedClass") : 19.40 ms => 16.20 ms +19.75%
document.querySelector(".tailClass") : 349.60 ms => 345.40 ms +1.22%
document.querySelectorAll(".headClass") : 382.80 ms => 378.20 ms +1.22%
document.querySelectorAll(".duplicatedClass") : 550.80 ms => 574.20 ms -4.08%
document.querySelectorAll(".tailClass") : 381.00 ms => 387.00 ms -1.55%

I've found that StyleSheetInternal::create() in CSSParser::parseSelector()
is a bottleneck of querySelector() and querySelectorAll().

void CSSParser::parseSelector(const String& string, CSSSelectorList& selectorList)
{

RefPtr<StyleSheetInternal> dummyStyleSheet = StyleSheetInternal::create();
setStyleSheet(dummyStyleSheet.get());
...;

}

This patch removes a dummy style sheet. Previously the dummy style sheet
was needed to avoid null checks of m_styleSheet in CSSGrammer.y.
This patch fixes CSSGrammer.y so that it works fine with a null m_styleSheet.

Tests: fast/dom/SelectorAPI/*. No change in the test results.

  • css/CSSGrammar.y:
  • css/CSSParser.cpp:

(WebCore::CSSParser::parseSelector):

1:41 AM Changeset in webkit [118735] by Nikolas Zimmermann
  • 58 edits
    1 move
    11 adds
    11 deletes in trunk

SVGViewSpec DOM bindings aka SVGSVGElement.currentView is unimplemented
​https://bugs.webkit.org/show_bug.cgi?id=15495

Reviewed by Rob Buis.

Source/WebCore:

Finish SVGViewSpec implementation and expose it to the Web. Numerous smaller bugs are fixed:

  • SVGViewSpec and all of its contents should be read-only. Enforce that and test it. Add a new enum to SVGPropertyInfo so that each SVGAnimatedProperty knows if its content is supposed to be read-write or read-only.
  • Make the 'transform' attribute of SVGViewSpec exposable by switching to a SVGTransformListProperty - it can now be accessed from JS.
  • Assure that following XXXString methods are in sync with the corresponding SVG DOM interfaces

readonly attribute DOMString viewBoxString;
readonly attribute DOMString preserveAspectRatioString;
readonly attribute DOMString transformString;
readonly attribute DOMString viewTargetString;

  • Cleanup code in svg/properties that was intended to handle SVGViewSpec. Turns out lot of the complexity was unncessary, and can be removed.
  • Move SVGFitToViewBox to the same pattern SVGZoomAndPan uses since two days, that avoids any virtual function calls for attribute parsing.
  • Create/expose ObjectiveC/JS bindings for SVGViewSpec.
  • Enable SVGViewSpec constructor.

Tests: svg/custom/linking-a-03-b-all-expected.svg

svg/dom/SVGViewSpec-defaults.html
svg/dom/SVGViewSpec.html
svg/dom/complex-svgView-specification.html
svg/dom/viewspec-parser.html

  • CMakeLists.txt:
  • DerivedSources.cpp:
  • DerivedSources.make:
  • DerivedSources.pri:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
  • WebCore.order:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSSVGLengthCustom.cpp:

(WebCore::JSSVGLength::setValue):
(WebCore::JSSVGLength::convertToSpecifiedUnits):

  • bindings/objc/DOMSVG.h:
  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateImplementation):
(NativeToJSValue):

  • bindings/scripts/CodeGeneratorObjC.pm:

(GenerateImplementation):

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateNormalAttrGetter):
(GenerateNormalAttrSetter):
(GenerateFunctionCallback):

  • bindings/v8/custom/V8SVGLengthCustom.cpp:

(WebCore::V8SVGLength::valueAccessorSetter):
(WebCore::V8SVGLength::convertToSpecifiedUnitsCallback):

  • page/DOMWindow.idl:
  • rendering/svg/RenderSVGResourcePattern.cpp:

(WebCore::RenderSVGResourcePattern::buildTileImageTransform):

  • svg/SVGFitToViewBox.cpp:
  • svg/SVGFitToViewBox.h:

(SVGFitToViewBox):
(WebCore::SVGFitToViewBox::parseAttribute):

  • svg/SVGMarkerElement.cpp:

(WebCore::SVGMarkerElement::orientTypePropertyInfo):
(WebCore::SVGMarkerElement::parseAttribute):
(WebCore::SVGMarkerElement::synchronizeOrientType):
(WebCore::SVGMarkerElement::lookupOrCreateOrientTypeWrapper):

  • svg/SVGPathElement.cpp:

(WebCore::SVGPathElement::dPropertyInfo):
(WebCore::SVGPathElement::svgAttributeChanged):
(WebCore::SVGPathElement::pathByteStream):
(WebCore::SVGPathElement::lookupOrCreateDWrapper):
(WebCore::SVGPathElement::synchronizeD):

  • svg/SVGPathSegWithContext.h:

(WebCore::SVGPathSegWithContext::animatedProperty):

  • svg/SVGPatternElement.cpp:

(WebCore::SVGPatternElement::parseAttribute):

  • svg/SVGPolyElement.cpp:

(WebCore::SVGPolyElement::pointsPropertyInfo):
(WebCore::SVGPolyElement::parseAttribute):
(WebCore::SVGPolyElement::synchronizePoints):
(WebCore::SVGPolyElement::lookupOrCreatePointsWrapper):

  • svg/SVGRect.h:
  • svg/SVGSVGElement.cpp:

(WebCore::SVGSVGElement::~SVGSVGElement):
(WebCore::SVGSVGElement::currentView):
(WebCore::SVGSVGElement::parseAttribute):
(WebCore::SVGSVGElement::currentViewBoxRect):
(WebCore::SVGSVGElement::viewBoxToViewTransform):
(WebCore::SVGSVGElement::setupInitialView):
(WebCore::SVGSVGElement::inheritViewAttributes):

  • svg/SVGSVGElement.h:

(SVGSVGElement):

  • svg/SVGSVGElement.idl:
  • svg/SVGSymbolElement.cpp:

(WebCore::SVGSymbolElement::parseAttribute):

  • svg/SVGTests.cpp:

(WebCore::SVGTests::requiredFeaturesPropertyInfo):
(WebCore::SVGTests::requiredExtensionsPropertyInfo):
(WebCore::SVGTests::systemLanguagePropertyInfo):
(WebCore::SVGTests::synchronizeRequiredFeatures):
(WebCore::SVGTests::synchronizeRequiredExtensions):
(WebCore::SVGTests::synchronizeSystemLanguage):

  • svg/SVGTextContentElement.cpp:

(WebCore::SVGTextContentElement::textLengthPropertyInfo):
(WebCore::SVGTextContentElement::synchronizeTextLength):
(WebCore::SVGTextContentElement::lookupOrCreateTextLengthWrapper):

  • svg/SVGViewElement.cpp:

(WebCore::SVGViewElement::parseAttribute):

  • svg/SVGViewElement.h:
  • svg/SVGViewSpec.cpp:

(WebCore::SVGViewSpec::viewBoxPropertyInfo):
(WebCore::SVGViewSpec::preserveAspectRatioPropertyInfo):
(WebCore::SVGViewSpec::transformPropertyInfo):
(WebCore::SVGViewSpec::SVGViewSpec):
(WebCore::SVGViewSpec::viewBoxIdentifier):
(WebCore::SVGViewSpec::preserveAspectRatioIdentifier):
(WebCore::SVGViewSpec::transformIdentifier):
(WebCore::SVGViewSpec::setZoomAndPan):
(WebCore::SVGViewSpec::setTransformString):
(WebCore::SVGViewSpec::transformString):
(WebCore::SVGViewSpec::viewBoxString):
(WebCore::SVGViewSpec::preserveAspectRatioString):
(WebCore::SVGViewSpec::viewTarget):
(WebCore::SVGViewSpec::transform):
(WebCore::SVGViewSpec::lookupOrCreateViewBoxWrapper):
(WebCore::SVGViewSpec::lookupOrCreatePreserveAspectRatioWrapper):
(WebCore::SVGViewSpec::lookupOrCreateTransformWrapper):
(WebCore::SVGViewSpec::reset):
(WebCore::SVGViewSpec::parseViewSpec):

  • svg/SVGViewSpec.h:

(WebCore::SVGViewSpec::~SVGViewSpec):
(SVGViewSpec):
(WebCore::SVGViewSpec::create):
(WebCore::SVGViewSpec::setViewTargetString):
(WebCore::SVGViewSpec::setZoomAndPan):
(WebCore::SVGViewSpec::contextElement):
(WebCore::SVGViewSpec::resetContextElement):
(WebCore::SVGViewSpec::transformBaseValue):
(WebCore::SVGViewSpec::viewBoxAnimated):
(WebCore::SVGViewSpec::viewBox):
(WebCore::SVGViewSpec::viewBoxBaseValue):
(WebCore::SVGViewSpec::setViewBoxBaseValue):
(WebCore::SVGViewSpec::preserveAspectRatioAnimated):
(WebCore::SVGViewSpec::preserveAspectRatio):
(WebCore::SVGViewSpec::preserveAspectRatioBaseValue):
(WebCore::SVGViewSpec::setPreserveAspectRatioBaseValue):

  • svg/SVGViewSpec.idl:
  • svg/properties/SVGAnimatedProperty.h:

(WebCore::SVGAnimatedProperty::isReadOnly):
(WebCore::SVGAnimatedProperty::setIsReadOnly):
(SVGAnimatedProperty):
(WebCore::SVGAnimatedProperty::lookupOrCreateWrapper):
(WebCore::SVGAnimatedProperty::lookupWrapper):
(WebCore::SVGAnimatedProperty::SVGAnimatedProperty):

  • svg/properties/SVGAnimatedPropertyMacros.h:

(WebCore::SVGSynchronizableAnimatedProperty::synchronize):
(SVGSynchronizableAnimatedProperty):

  • svg/properties/SVGAnimatedPropertySynchronizer.h: Removed.
  • svg/properties/SVGAttributeToPropertyMap.h:
  • svg/properties/SVGListProperty.h:
  • svg/properties/SVGListPropertyTearOff.h:

(SVGListPropertyTearOff):
(WebCore::SVGListPropertyTearOff::isReadOnly):

  • svg/properties/SVGPathSegListPropertyTearOff.h:

(SVGPathSegListPropertyTearOff):
(WebCore::SVGPathSegListPropertyTearOff::isReadOnly):

  • svg/properties/SVGProperty.h:

(SVGProperty):

  • svg/properties/SVGPropertyInfo.h:

(WebCore::SVGPropertyInfo::SVGPropertyInfo):
(SVGPropertyInfo):

  • svg/properties/SVGPropertyTearOff.h:

(WebCore::SVGPropertyTearOff::isReadOnly):

  • svg/properties/SVGStaticListPropertyTearOff.h:

(SVGStaticListPropertyTearOff):
(WebCore::SVGStaticListPropertyTearOff::isReadOnly):

Source/WebKit/mac:

  • MigrateHeaders.make: Copy DOMSVGViewSpec*.h headers.

LayoutTests:

Re-enable a long disabled test for SVGViewSpec, and make it actually work.
Extend SVGViewSpec test coverage, and rebaseline results that changed due the SVGViewSpec constructor addition.

Make linking-a-03-b-all.svg a reftest, to avoid rebaselines on all platforms.

  • platform/chromium-linux/svg/custom/linking-a-03-b-all-expected.png: Removed.
  • platform/chromium-mac/svg/custom/linking-a-03-b-all-expected.png: Removed.
  • platform/chromium-win/fast/js/global-constructors-expected.txt:
  • platform/chromium-win/svg/custom/linking-a-03-b-all-expected.png: Removed.
  • platform/chromium-win/svg/custom/linking-a-03-b-all-expected.txt: Removed.
  • platform/gtk/fast/js/global-constructors-expected.txt:
  • platform/gtk/svg/custom/linking-a-03-b-all-expected.png: Removed.
  • platform/gtk/svg/custom/linking-a-03-b-all-expected.txt: Removed.
  • platform/mac/fast/js/global-constructors-expected.txt:
  • platform/mac/svg/custom/linking-a-03-b-all-expected.png: Removed.
  • platform/mac/svg/custom/linking-a-03-b-all-expected.txt: Removed.
  • platform/qt/fast/js/global-constructors-expected.txt:
  • platform/qt/svg/custom/linking-a-03-b-all-expected.png: Removed.
  • platform/qt/svg/custom/linking-a-03-b-all-expected.txt: Removed.
  • platform/win/fast/js/global-constructors-expected.txt:
  • svg/custom/global-constructors-expected.txt:
  • svg/custom/linking-a-03-b-all-expected.svg: Added.
  • svg/dom/SVGViewSpec-defaults-expected.txt: Added.
  • svg/dom/SVGViewSpec-defaults.html: Added.
  • svg/dom/SVGViewSpec-expected.txt: Added.
  • svg/dom/SVGViewSpec.html: Added.
  • svg/dom/complex-svgView-specification-expected.html: Added.
  • svg/dom/complex-svgView-specification.html: Added.
  • svg/dom/resources/viewspec-target.svg: Added.
  • svg/dom/script-tests/SVGViewSpec-defaults.js: Added.
  • svg/dom/script-tests/SVGViewSpec.js: Added.

(completeTest.script.onload):
(completeTest):
(testFragment):
(matrixToString):
(continueTesting):

  • svg/dom/viewspec-parser-expected.txt: Added.
  • svg/dom/viewspec-parser.html: Renamed from LayoutTests/svg/dom/viewspec-parser.html-disabled.
1:32 AM Changeset in webkit [118734] by bulach@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Adjust expectations for fast/layers/clip-rects-assertion-expected.txt
​https://bugs.webkit.org/show_bug.cgi?id=87671

Unreviewed gardening.
Test has been fixed by r118724, remove expectation.

  • platform/chromium/test_expectations.txt:
1:23 AM Changeset in webkit [118733] by tkent@chromium.org
  • 9 edits
    12 adds in trunk

REGRESSION (r90971): the cursor is painted “behind” the placeholder text
​https://bugs.webkit.org/show_bug.cgi?id=87155

Reviewed by Hajime Morita.

Source/WebCore:

This regression happened only on platforms on which
RenderTheme::shouldShowPlaceholderWhenFocused() returns true.

Because the order of renderers for the editable node and the placeholder
node was:

  • A renderer for the editable node
  • A renderer for the placeholder node,

The text caret was painted, then the palceholder was painted.

We should not use z-index in the built-in shadow nodes. So the patch
fixes this bug by re-ordering these renderers.

Tests: fast/forms/input-placeholder-paint-order-2.html

fast/forms/input-placeholder-paint-order.html
fast/forms/textarea/textarea-placeholder-paint-order-2.html
fast/forms/textarea/textarea-placeholder-paint-order.html

  • html/HTMLTextFormControlElement.cpp:

(WebCore::HTMLTextFormControlElement::fixPlaceholderRenderer):
Added. Reorder the order of renderers so that the placeholder renderer
precedes the inner text renderer.

  • html/HTMLTextFormControlElement.h: Add fixPlaceholderRenderer() declaration.
  • html/HTMLTextAreaElement.cpp:

(WebCore::HTMLTextAreaElement::attach): Calls fixPlaceholderRenderer().
(WebCore::HTMLTextAreaElement::updatePlaceholderText):
ditto. Also, use innerTextElement() to improvde code readability.

  • html/HTMLTextAreaElement.h:

(HTMLTextAreaElement): Overrides attach().

  • html/TextFieldInputType.cpp:

(WebCore::TextFieldInputType::updatePlaceholderText):
Calls fixPlaceholderRenderer().
(WebCore::TextFieldInputType::attach): ditto.

  • html/TextFieldInputType.h:

(TextFieldInputType): Overrides attach().

LayoutTests:

  • fast/forms/input-placeholder-paint-order-2-expected.html: Added.
  • fast/forms/input-placeholder-paint-order-2.html: Added.
  • fast/forms/input-placeholder-paint-order.html: Added.
  • fast/forms/textarea/textarea-placeholder-paint-order-2-expected.html: Added.
  • fast/forms/textarea/textarea-placeholder-paint-order-2.html: Added.
  • fast/forms/textarea/textarea-placeholder-paint-order.html: Added.
  • platform/chromium-mac-snowleopard/fast/forms/input-placeholder-paint-order-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/input-placeholder-paint-order-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/forms/textarea/textarea-placeholder-paint-order-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/textarea/textarea-placeholder-paint-order-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
1:08 AM Changeset in webkit [118732] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebKit2

[GTK] Add return value information to WebKitWebView::load-failed signal documentation
​https://bugs.webkit.org/show_bug.cgi?id=87704

Reviewed by Martin Robinson.

  • UIProcess/API/gtk/WebKitWebView.cpp:

(webkit_web_view_class_init):

1:06 AM Changeset in webkit [118731] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebKit2

[GTK] Add WebKitWebInspector.h to the list of WebKit2 GTK public headers
​https://bugs.webkit.org/show_bug.cgi?id=87703

Reviewed by Martin Robinson.

  • GNUmakefile.list.am: Add WebKitWebInspector.h to webkit2gtk_h_api.
12:57 AM Changeset in webkit [118730] by kkristof@inf.u-szeged.hu
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening after r118631. http/tests/appcache/load-from-appcache-defer-resume-crash.html
fails because of missing LayoutTestController::setUseDeferredFrameLoading implementation.

Patch by János Badics <János Badics> on 2012-05-29

  • platform/qt/Skipped:
12:51 AM Changeset in webkit [118729] by commit-queue@webkit.org
  • 4 edits in trunk

[EFL] Compilation warning in DumpRenderTreeView.cpp
​https://bugs.webkit.org/show_bug.cgi?id=87636

Patch by Christophe Dumez <Christophe Dumez> on 2012-05-29
Reviewed by Filip Pizlo.

Source/WebKit/efl:

Fix return type of exceeded_application_cache_quota callback, it
should be int64_t, not uint64_t.

  • ewk/ewk_view.h:

Tools:

Fix compilation error in DumpRenderTreeView.cpp due to wrong format
specifier in printf. Also fix the return type for
onExceededApplicationCacheQuota callback.

  • DumpRenderTree/efl/DumpRenderTreeView.cpp:

(onExceededApplicationCacheQuota):

12:34 AM Changeset in webkit [118728] by hbono@chromium.org
  • 2 edits in trunk/Tools

Adding Hironori Bono to committers.py.
​https://bugs.webkit.org/show_bug.cgi?id=87697

  • Scripts/webkitpy/common/config/committers.py:
Note: See TracTimeline for information about the timeline view.