Timeline



Nov 23, 2012:

10:40 PM Changeset in webkit [135643] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Fix unused parameter compile warnings
https://bugs.webkit.org/show_bug.cgi?id=103167

Patch by Kangil Han <kangil.han@samsung.com> on 2012-11-23
Reviewed by Gyuyoung Kim.

Remove compile warning messages by omitting parameter name and using UNUSED_PARAM.

  • accessibility/atk/WebKitAccessibleHyperlink.cpp:

(webkitAccessibleHyperlinkIsSelectedLink):

  • accessibility/atk/WebKitAccessibleInterfaceText.cpp:

(webkitAccessibleTextGetTextAfterOffset):
(webkitAccessibleTextGetTextAtOffset):
(webkitAccessibleTextGetTextBeforeOffset):
(webkitAccessibleTextGetOffsetAtPoint):

10:13 PM Changeset in webkit [135642] by Csaba Osztrogonác
  • 5 edits in trunk/Source

Unreviewed, rolling out r135575.
http://trac.webkit.org/changeset/135575
https://bugs.webkit.org/show_bug.cgi?id=103169

It made all tests assert (Requested by Ossy on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-11-23

Source/WebKit/qt:

  • Api/qwebpage.cpp:

(QWebPagePrivate::QWebPagePrivate):

  • WebCoreSupport/InitWebCoreQt.cpp:

(WebKit::initializeWebKitQt):

Source/WebKit2:

  • qt/MainQt.cpp:

(WebKit):
(main):

9:18 PM Changeset in webkit [135641] by msaboff@apple.com
  • 2 edits in trunk/Source/WebCore

listMarkerText() should create 8 bit strings when possible
https://bugs.webkit.org/show_bug.cgi?id=103011

Reviewed by Filip Pizlo.

Made processing of marker text items use 8 bit strings where possible in order to reduce 16 bit strings.

Changes covered by existing tests.

  • rendering/RenderListMarker.cpp:

(WebCore::toRoman): Changed character constants and buffer to build string to LChar's
(WebCore::toAlphabeticOrNumeric): Made a template based on character type.
(WebCore::toSymbolic): Made a template based on character type.
(WebCore::toAlphabetic): Made a template based on character type.
(WebCore::toNumeric): Added character type template parameter.
(WebCore::listMarkerText): Changed character constants to LChar where possible.

7:16 PM Changeset in webkit [135640] by fpizlo@apple.com
  • 21 edits
    4 adds in trunk/Source

Any function that can log things should be able to easily log them to a memory buffer as well
https://bugs.webkit.org/show_bug.cgi?id=103000

Reviewed by Sam Weinig.

Source/JavaScriptCore:

Change all users of WTF::dataFile() to expect a PrintStream& rather than a FILE*.

  • bytecode/Operands.h:

(JSC::OperandValueTraits::dump):
(JSC::dumpOperands):
(JSC):

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::dump):

  • dfg/DFGAbstractState.h:

(AbstractState):

  • dfg/DFGAbstractValue.h:

(JSC::DFG::AbstractValue::dump):

  • dfg/DFGCommon.h:

(JSC::DFG::NodeIndexTraits::dump):

  • dfg/DFGStructureAbstractValue.h:

(JSC::DFG::StructureAbstractValue::dump):

  • dfg/DFGVariableEvent.cpp:

(JSC::DFG::VariableEvent::dump):
(JSC::DFG::VariableEvent::dumpFillInfo):
(JSC::DFG::VariableEvent::dumpSpillInfo):

  • dfg/DFGVariableEvent.h:

(VariableEvent):

  • disassembler/Disassembler.h:

(JSC):
(JSC::tryToDisassemble):

  • disassembler/UDis86Disassembler.cpp:

(JSC::tryToDisassemble):

Source/WTF:

We have a number of places where we pass around a FILE* as a target to which to print
some logging information. But the purpose of passing FILE* instead of always assuming
that we should dump to stderr is that it may be sometimes useful to send the logging
information elsewhere. Unfortunately, FILE* isn't quite powerful enough: it's combersome
to use it to send logging to a string, for example.

We could get around this by using <iostream> and <sstream>, but so far this aspect of
C++ has not been part of the WebKit coding conventions. Personally I find <iostream>
awkward due to its abuse of operator overloading.

So this patch introduces the PrintStream abstract class, which offers printf-like
functionality while completely abstracting the destination and mechanism of the printing
output. It would be trivial to implement a StringPrintStream, for example. This will feed
into work on https://bugs.webkit.org/show_bug.cgi?id=102999.

This also sets us up for creating templatized print() and println() methods that will
allow us to say things like out.print("count = ", count, "\n"), but that is the topic
of https://bugs.webkit.org/show_bug.cgi?id=103009.

This patch also changes dataLog() to use FilePrintStream internally, and WTF::dataFile()
now returns a FilePrintStream&. Any previous users of WTF::dataFile() have been changed
to expect a PrintStream&.

  • GNUmakefile.list.am:
  • WTF.pro:
  • WTF.vcproj/WTF.vcproj:
  • WTF.xcodeproj/project.pbxproj:
  • wtf/CMakeLists.txt:
  • wtf/DataLog.cpp:

(WTF):
(WTF::initializeLogFileOnce):
(WTF::initializeLogFile):
(WTF::dataFile):
(WTF::dataLogV):
(WTF::dataLogString):

  • wtf/DataLog.h:

(WTF):

  • wtf/FilePrintStream.cpp: Added.

(WTF):
(WTF::FilePrintStream::FilePrintStream):
(WTF::FilePrintStream::~FilePrintStream):
(WTF::FilePrintStream::vprintf):
(WTF::FilePrintStream::flush):

  • wtf/FilePrintStream.h: Added.

(WTF):
(FilePrintStream):
(WTF::FilePrintStream::file):

  • wtf/PrintStream.cpp: Added.

(WTF):
(WTF::PrintStream::PrintStream):
(WTF::PrintStream::~PrintStream):
(WTF::PrintStream::printf):
(WTF::PrintStream::print):
(WTF::PrintStream::println):
(WTF::PrintStream::flush):
(WTF::print):

  • wtf/PrintStream.h: Added.

(WTF):
(PrintStream):
(WTF::print):
(WTF::println):

5:30 PM Changeset in webkit [135639] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Define platform limitations in platform layer
https://bugs.webkit.org/show_bug.cgi?id=103160

Patch by Nima Ghanavatian <nghanavatian@rim.com> on 2012-11-23
Reviewed by Rob Buis.

Taking length as const unsigned in checkSpellingOfStringAsync.
This value is unchanging and should never be less than 0, even
in an error case.

Internally reviewed by Mike Fenton.

  • Api/WebPageClient.h:
  • WebKitSupport/InputHandler.cpp:

(BlackBerry::WebKit::InputHandler::requestCheckingOfString):

4:42 PM Changeset in webkit [135638] by rjkroege@chromium.org
  • 12 edits in trunk/Source

Remove unused ScrollByPixelVelocity
https://bugs.webkit.org/show_bug.cgi?id=102840

Reviewed by Sam Weinig.

Source/WebCore:

https://bugs.webkit.org/show_bug.cgi?id=80311 wrongly introduced a new
kind of scroll: "ScrollByPixelVelocity". This code is not used on any platform
and will not be of use in the future so this patch removes it.

No new tests: code removal/cleanup.

  • page/EventHandler.cpp:

(WebCore::EventHandler::defaultWheelEventHandler):
(WebCore::EventHandler::handleGestureEvent):

  • platform/PlatformWheelEvent.h:
  • platform/ScrollAnimator.cpp:

(WebCore::ScrollAnimator::handleWheelEvent):

  • platform/ScrollAnimatorNone.cpp:

(WebCore::ScrollAnimatorNone::ScrollAnimatorNone):
(WebCore::ScrollAnimatorNone::scroll):
(WebCore::ScrollAnimatorNone::cancelAnimations):
(WebCore::ScrollAnimatorNone::animationTimerFired):

  • platform/ScrollAnimatorNone.h:

(ScrollAnimatorNone):

  • platform/ScrollTypes.h:
  • platform/ScrollableArea.cpp:

(WebCore::ScrollableArea::scroll):

Source/WebKit/chromium:

Removed test for deleted code.

  • tests/ScrollAnimatorNoneTest.cpp:

Source/WTF:

The GESTURE_ANIMATION feature turns on code in WebCore is unused.
Remove it.

No new tests: code removal/cleanup.

  • wtf/Platform.h:
3:20 PM Changeset in webkit [135637] by rjkroege@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening: updated test expectations for failure in

  • svg/batik/text/textPosition2.svg

https://bugs.webkit.org/show_bug.cgi?id=103148

  • platform/chromium/TestExpectations:
3:02 PM Changeset in webkit [135636] by rjkroege@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening: text failures in:

  • inspector/console/command-line-api-inspect.html
  • inspector/runtime/runtime-localStorage-getProperties.html

https://bugs.webkit.org/show_bug.cgi?id=103161

  • platform/chromium/TestExpectations:
2:39 PM Changeset in webkit [135635] by rjkroege@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening: update test expectations for
svg/hixie/perf/007.xml

  • platform/chromium/TestExpectations:
2:24 PM Changeset in webkit [135634] by rjkroege@chromium.org
  • 1 edit
    1 move
    1 add in trunk/LayoutTests

[CSS3 Backgrounds and Borders] Implement new CSS3 background-position parsing.
https://bugs.webkit.org/show_bug.cgi?id=102104

Patch by Alexis Menard <alexis@webkit.org> on 2012-11-23
Reviewed by Julien Chaffraix.

Add new tests to cover the new parsing for the background position
property. For now the computed style checks are commented out because
the rendering part of the feature is not yet implemented (i.e.
FillLayer does not contain yet the feature and this is what
CSSComputedStyleDeclaration is using).

  • fast/backgrounds/background-position-parsing-2-expected.txt:
  • fast/backgrounds/background-position-parsing-2.html:
  • platform/chromium/TestExpectations:
  • platform/efl/TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/mac/TestExpectations:
  • platform/qt/TestExpectations:
  • platform/win/TestExpectations:
  • platform/wincairo/TestExpectations:
2:04 PM Changeset in webkit [135633] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Removing unnecessary RenderBox friend access in RenderObject
https://bugs.webkit.org/show_bug.cgi?id=103159

Patch by Adenilson Cavalcanti <cavalcantii@gmail.com> on 2012-11-23
Reviewed by Eric Seidel.

RenderObject has several classes marked as friend, between them,
there is RenderBox which is derived from it indirectly and is not accessing
its forefather private data making unnecessary the 'friend' access level.

No new tests, no changes in functionality.

  • rendering/RenderObject.h:

(RenderObject):

1:24 PM Changeset in webkit [135632] by alexis@webkit.org
  • 34 edits in trunk

[CSS3 Backgrounds and Borders] Implement new CSS3 background-position parsing.
https://bugs.webkit.org/show_bug.cgi?id=102104

Reviewed by Julien Chaffraix.

.:

Protect the new feature behind a feature flag.

  • Source/cmake/WebKitFeatures.cmake:
  • Source/cmakeconfig.h.cmake:
  • configure.ac:

Source/JavaScriptCore:

Protect the new feature behind a feature flag.

  • Configurations/FeatureDefines.xcconfig:

Source/WebCore:

Implement the parsing of the CSS3 background-position property which
allows to specify up to four values to position the background. It is
documented here :
http://www.w3.org/TR/css3-background/#the-background-position . I
decided to split up the patch is two pieces, the parsing and later I
will do the rendering. I kept the old code as much as possible (i.e.
the two values parsing) as it is used not only by background-position
but by few other properties. The new four values support is only valid
on the property itself but does not work on the shorthand.

Opera has already implemented this feature.

I extended backgrounds/background-position-parsing-2.html to cover the
new possible values as well as buggy values.

  • Configurations/FeatureDefines.xcconfig:
  • GNUmakefile.am:
  • GNUmakefile.features.am:
  • css/CSSParser.cpp:

(WebCore::CSSParser::parseFillPositionComponent): Modify this function
to allow creation of CSS primitive values with not only percentage or
length but with keywords also as the new <position> type allows to
specify keywords, for example top 30px right 20px.
(WebCore):
(WebCore::isValueConflictingWithCurrentEdge):
(WebCore::isBackgroundPositionKeyword):
(WebCore::CSSParser::parse3ValuesBackgroundPosition):
(WebCore::CSSParser::parse4ValuesBackgroundPosition):
(WebCore::CSSParser::parseFillBackgroundPosition): This function counts
the number of words for the property value and call dedicated parsing
functions for each case. Note that in case of two values we just call the old CSS 2.1
method.
(WebCore::CSSParser::parseFillPosition):
(WebCore::CSSParser::parseFillProperty): Only call the new parsing
function if the feature is activated otherwise fallback to the old code
path.

  • css/CSSParser.h:

Source/WebKit/chromium:

Protect the new feature behind a feature flag.

  • features.gypi:

Source/WebKit/mac:

Protect the new feature behind a feature flag.

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

Protect the new feature behind a feature flag.

  • Configurations/FeatureDefines.xcconfig:

Tools:

Protect the new feature behind a feature flag.

  • Scripts/webkitperl/FeatureList.pm:
  • qmake/mkspecs/features/features.pri:

WebKitLibraries:

Protect the new feature behind a feature flag.

  • win/tools/vsprops/FeatureDefines.vsprops:
  • win/tools/vsprops/FeatureDefinesCairo.vsprops:

LayoutTests:

Add new tests to cover the new parsing for the background position
property. For now the computed style checks are commented out because
the rendering part of the feature is not yet implemented (i.e.
FillLayer does not contain yet the feature and this is what
CSSComputedStyleDeclaration is using).

  • fast/backgrounds/background-position-parsing-2-expected.txt:
  • fast/backgrounds/background-position-parsing-2.html:
  • platform/chromium/TestExpectations:
  • platform/efl/TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/mac/TestExpectations:
  • platform/qt/TestExpectations:
  • platform/win/TestExpectations:
  • platform/wincairo/TestExpectations:
11:32 AM Changeset in webkit [135631] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

Unreviewed gardening.

Adding failure expectation for fast/dom/shadow/host-wrapper-reclaimed.html.

  • platform/gtk/TestExpectations:
11:17 AM Changeset in webkit [135630] by rjkroege@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed: updated test expecations -- additional failures in

  • fast/text/large-text-composed-char.html
  • fast/text/text-letter-spacing.html
  • http/tests/inspector/indexeddb/database-data.html

and new failures:

  • fast/frames/frame-unload-crash2.html
  • platform/chromium/TestExpectations:
10:43 AM Changeset in webkit [135629] by junov@google.com
  • 26 edits
    2 adds in trunk

Adding occlusion detection to reduce overdraw in RenderBox background rendering
https://bugs.webkit.org/show_bug.cgi?id=102557

Reviewed by Stephen White.

Source/WebCore:

Adding hasAlpha method to all classes dervived from CSSImageValue and
StyleImage, in order to support occlusion testing.
This allows the FillLayer recursion to stop early when an opaque layer
is encountered while applying a CSS background style. This also allows
the elimination of background color application when the background is
completely covered by an image. The optimization also skips the
clearing of the page's root element when the page background is
entirely covered by an image (e.g a tiled bitmap or a gradient)

Test: fast/backgrounds/background-opaque-images-over-color.html

  • css/CSSCrossfadeValue.cpp:

(WebCore::subimageHasAlpha):
(WebCore):
(WebCore::CSSCrossfadeValue::isPending):
(WebCore::CSSCrossfadeValue::hasAlpha):

  • css/CSSCrossfadeValue.h:

(CSSCrossfadeValue):

  • css/CSSGradientValue.cpp:

(WebCore::CSSGradientValue::hasAlpha):
(WebCore):

  • css/CSSGradientValue.h:

(CSSGradientValue):

  • css/CSSImageGeneratorValue.cpp:

(WebCore::CSSImageGeneratorValue::hasAlpha):
(WebCore):

  • css/CSSImageGeneratorValue.h:

(CSSImageGeneratorValue):

  • css/CSSImageValue.cpp:

(WebCore::CSSImageValue::hasAlpha):
(WebCore):

  • css/CSSImageValue.h:

(WebCore):
(CSSImageValue):

  • loader/cache/CachedImage.cpp:

(WebCore::CachedImage::currentFrameHasAlpha):
Test whether a cached image has alpha, with side effect of ensuring
the image is in cache. (new method)
(WebCore):

  • loader/cache/CachedImage.h:

(CachedImage):

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::paintFillLayers):
Added layer recursion early exit when an opaque layer is encountered.

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::paintFillLayerExtended):
Eliminated background color fill when the layer contains an opaque
image that covers the entire RenderBox.

  • rendering/style/FillLayer.cpp:

(WebCore::FillLayer::hasOpaqueImage):
Returns true if the layer's image is known to be fully opaque.
(WebCore):
(WebCore::FillLayer::hasRepeatXY):

  • rendering/style/FillLayer.h:

(FillLayer):

  • rendering/style/StyleCachedImage.cpp:

(WebCore::StyleCachedImage::hasAlpha):
(WebCore):

  • rendering/style/StyleCachedImage.h:

(StyleCachedImage):

  • rendering/style/StyleCachedImageSet.cpp:

(WebCore::StyleCachedImageSet::hasAlpha):
(WebCore):

  • rendering/style/StyleCachedImageSet.h:

(StyleCachedImageSet):

  • rendering/style/StyleGeneratedImage.cpp:

(WebCore::StyleGeneratedImage::hasAlpha):
(WebCore):

  • rendering/style/StyleGeneratedImage.h:

(StyleGeneratedImage):

  • rendering/style/StyleImage.h:

(StyleImage):

  • rendering/style/StylePendingImage.h:

(WebCore::StylePendingImage::hasAlpha):

LayoutTests:

New test exercises different CSS background style use cases that
are candidates for optimization by occlusion culling.

  • fast/backgrounds/background-opaque-images-over-color-expected.txt: Added.
  • fast/backgrounds/background-opaque-images-over-color.html: Added.
  • platform/chromium/TestExpectations:
10:39 AM Changeset in webkit [135628] by rjkroege@chromium.org
  • 2 edits in trunk/LayoutTests

Gardening: updated expectations (pass/timeout) for
week-multiple-fields-preserve-value-after-history-back.html
https://bugs.webkit.org/show_bug.cgi?id=103152

  • platform/chromium/TestExpectations:
10:17 AM Changeset in webkit [135627] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Adapt accessibility feature to WebKitTestRunner.
https://bugs.webkit.org/show_bug.cgi?id=100757

Patch by Krzysztof Czech <k.czech@samsung.com> on 2012-11-23
Reviewed by Laszlo Gombos.

Skipping Accessibility tests for wk1/wk2.
Some of the implementation is still missing.

  • platform/efl/TestExpectations:
9:15 AM Changeset in webkit [135626] by mario@webkit.org
  • 2 edits in trunk/Tools

Unreviewed. Update my e-mail address.

  • Scripts/webkitpy/common/config/committers.py:
9:13 AM Changeset in webkit [135625] by junov@google.com
  • 4 edits
    2 adds in trunk

Page background color bleeds through inner edge of div border with rounded edges
https://bugs.webkit.org/show_bug.cgi?id=103089

Reviewed by Stephen White.

Source/WebCore:

Test that verifies whether a RenderBoxEdge is more than 2 pixels wide
was applying the content scale factor backwards, so the
obscuresBackgroundEdge was falsely passing for downsized boxes.

Test: fast/backgrounds/gradient-background-leakage-2.html

  • rendering/RenderBoxModelObject.cpp:

(WebCore::BorderEdge::obscuresBackgroundEdge):

LayoutTests:

New layout test to verify that there is no color bleeding between
a div element's border and background when there are rounded corners
an a scale that reduces a thick border down to a width of less than
two pixels.

  • fast/backgrounds/gradient-background-leakage-2-expected.txt: Added.
  • fast/backgrounds/gradient-background-leakage-2.html: Added.
  • platform/chromium/TestExpectations:
9:10 AM Changeset in webkit [135624] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

Coordinated Graphics: Match the behavior of selfOrAncestorHaveNonAffineTransforms() to its name.
https://bugs.webkit.org/show_bug.cgi?id=103097

Patch by Huang Dongsung <luxtella@company100.net> on 2012-11-23
Reviewed by Noam Rosenthal.

CoordinatedGraphicsLayer::selfOrAncestorHaveNonAffineTransforms() does
not check its ancestor. This patch makes this method check its ancestor
to match its name.

  • WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.cpp:

(WebCore::CoordinatedGraphicsLayer::selfOrAncestorHaveNonAffineTransforms):

9:06 AM Changeset in webkit [135623] by rjkroege@chromium.org
  • 2 edits in trunk/LayoutTests

Gardening: update expectations for fast/events/stopPropagation-submit.html flaky
https://bugs.webkit.org/show_bug.cgi?id=103149

  • platform/chromium/TestExpectations:
8:57 AM Changeset in webkit [135622] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

Coordinated Graphics: LayerTreeRenderer::removeTile() does not remove tiles actually.
https://bugs.webkit.org/show_bug.cgi?id=103030

Patch by Huang Dongsung <luxtella@company100.net> on 2012-11-23
Reviewed by Noam Rosenthal.

LayerTreeRenderer::removeTile() must add a backing store into
m_backingStoresWithPendingBuffers. Otherwise, tiles are not removed.

  • UIProcess/CoordinatedGraphics/LayerTreeRenderer.cpp:

(WebKit::LayerTreeRenderer::removeTile):

8:54 AM Changeset in webkit [135621] by Patrick Gansterer
  • 2 edits in trunk

[CMake] Add support for winflexbison distribution
https://bugs.webkit.org/show_bug.cgi?id=102551

Reviewed by Laszlo Gombos.

Since GnuWin32 does not provide recent versions of bision and flex supporting
the alternative winflexbison distribution is the prefered option.

  • Source/cmake/WebKitMacros.cmake:
8:51 AM Changeset in webkit [135620] by commit-queue@webkit.org
  • 7 edits in trunk/Source

[TexMap] Remove dependency of TextureMapperLayer on GraphicsLayerTextureMapper.
https://bugs.webkit.org/show_bug.cgi?id=103046

Patch by Huang Dongsung <luxtella@company100.net> on 2012-11-23
Reviewed by Noam Rosenthal.

Source/WebCore:

It is a preparation patch for Threaded Coordinated Graphics on WK1.

We want to make TextureMapperLayer into an actor model. After making an actor
model, GraphicsLayerTextureMapper and LayerTreeRenderer will communicate with
TextureMapperLayer using message passing. In the first step, we want to hide
GraphicsLayerTextureMapper from TextureMapperLayer.

There are 2 kinds of dependencies of TextureMapperLayer in GraphicsLayerTextureMapper.

  1. To query layer states
  2. To paint layer contents

In this patch, we removed the second dependency. Currently, TextureMapperLayer
requests painting contents to GraphicsLayerTextureMapper in WK1 while
Coordinated Graphics prepares the contents in LayerTreeRenderer. This patch
makes WK1 prepare the contents in GraphicsLayerTextureMapper like
LayerTreeRenderer.

We will remove the first dependency in a follow-up patch.

Covered by existing layout tests.

  • platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:

(WebCore::GraphicsLayerTextureMapper::GraphicsLayerTextureMapper):
(WebCore::GraphicsLayerTextureMapper::flushCompositingStateForThisLayerOnly):
(WebCore::GraphicsLayerTextureMapper::flushCompositingState):
(WebCore):
(WebCore::GraphicsLayerTextureMapper::didFlushCompositingState):
(WebCore::GraphicsLayerTextureMapper::didFlushCompositingStateRecursive):
(WebCore::GraphicsLayerTextureMapper::updateBackingStore):
(WebCore::GraphicsLayerTextureMapper::prepareBackingStore):
(WebCore::GraphicsLayerTextureMapper::shouldHaveBackingStore):
(WebCore::GraphicsLayerTextureMapper::drawRepaintCounter):
(WebCore::GraphicsLayerTextureMapper::setDebugBorder):

  • platform/graphics/texmap/GraphicsLayerTextureMapper.h:

(GraphicsLayerTextureMapper):
(WebCore::GraphicsLayerTextureMapper::setHasOwnBackingStore):

  • platform/graphics/texmap/TextureMapperLayer.cpp:

(WebCore::TextureMapperLayer::rootLayer):
(WebCore::TextureMapperLayer::paintSelf):
(WebCore::TextureMapperLayer::textureMapper):
(WebCore):
(WebCore::TextureMapperLayer::flushCompositingState):
(WebCore::TextureMapperLayer::flushCompositingStateSelf):

  • platform/graphics/texmap/TextureMapperLayer.h:

(WebCore):
(WebCore::TextureMapperLayer::TextureMapperLayer):
(TextureMapperLayer):
(WebCore::TextureMapperLayer::setBackingStore):
(State):
(WebCore::TextureMapperLayer::State::State):

Source/WebKit2:

This patch makes GraphicsLayerTextureMapper create its own backing
store. However, LayerTreeRenderer also creates its own backing store. So
when LayerTreeRenderer uses GraphicsLayerTextureMapper,
LayerTreeRenderer needs GraphicsLayerTextureMapper to not create its own
backing store.

  • UIProcess/CoordinatedGraphics/LayerTreeRenderer.cpp:

(WebKit::LayerTreeRenderer::createLayer):
(WebKit::LayerTreeRenderer::getBackingStore):

8:47 AM Changeset in webkit [135619] by commit-queue@webkit.org
  • 10 edits in trunk

[EFL][GTK] Adapt accessibility feature to WebKitTestRunner.
https://bugs.webkit.org/show_bug.cgi?id=100757

Patch by Mateusz Leszko <m.leszko@samsung.com> on 2012-11-23
Reviewed by Laszlo Gombos.

Tools:

Allow to build accessibility feature in WebkitTestRunner for EFL Platform.
Updating CMake files due to changes from Bug 99011.

  • WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:

(WTR::AccessibilityController::AccessibilityController):
(WTR):

  • WebKitTestRunner/InjectedBundle/AccessibilityController.h:

(AccessibilityController):

  • WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:

(WTR):

  • WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:

(AccessibilityUIElement):

  • WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp: - Removed gtk/gtk.h dependency.
  • WebKitTestRunner/PlatformEfl.cmake: - Adding atk includes.

LayoutTests:

Unskipping EFL Accessiblity tests for wk2.

  • platform/efl-wk1/TestExpectations:
  • platform/efl/TestExpectations:
8:40 AM Changeset in webkit [135618] by Carlos Garcia Campos
  • 5 edits in trunk/Source/WebCore

[ENCHANT] Infinite loop when end word position is not found
https://bugs.webkit.org/show_bug.cgi?id=103139

Reviewed by Martin Robinson.

Covered by existing tests in editing/spelling.

  • editing/visible_units.cpp:

(WebCore::isLogicalStartOfWord): Make it private again.
(WebCore::islogicalEndOfWord): Ditto.

  • editing/visible_units.h:
  • platform/text/enchant/TextCheckerEnchant.cpp:

(WebCore::TextCheckerEnchant::checkSpellingOfWord): Helper funtion
to check a word inside a string using the loaded dictionaries.
(WebCore::TextCheckerEnchant::checkSpellingOfString): Optimize and
simply the code by using the word iterator to iterate the
words.

  • platform/text/enchant/TextCheckerEnchant.h:

(TextCheckerEnchant):

8:38 AM Changeset in webkit [135617] by rjkroege@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening: test expectations failures.
https://bugs.webkit.org/show_bug.cgi?id=103148

  • platform/chromium/TestExpectations:
8:37 AM Changeset in webkit [135616] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit2

REGRESSION(r135486): ASSERT(isMainThread()) hit in LayerTreeRenderer::setActive(bool)
https://bugs.webkit.org/show_bug.cgi?id=103077

Patch by Huang Dongsung <luxtella@company100.net> on 2012-11-23
Reviewed by Noam Rosenthal.

Currently, the painting thread uses purgeGLResources() and setActive().
QQuickWebPage::updatePaintNode() indirectly calls both methods after
locking the main thread.

This patch changes two points.

  1. Remove ASSERT(isMainThread()) in methods that the painting thread can

call.

  1. Make purgeGLResources() and setActive() call methods of

LayerTreeCoordinatorProxy via dispatchOnMainThread().

  • UIProcess/CoordinatedGraphics/LayerTreeRenderer.cpp:

(WebKit::LayerTreeRenderer::LayerTreeRenderer):
(WebKit::LayerTreeRenderer::renderNextFrame):
(WebKit::LayerTreeRenderer::purgeGLResources):
(WebKit):
(WebKit::LayerTreeRenderer::purgeBackingStores):
(WebKit::LayerTreeRenderer::setActive):

  • UIProcess/CoordinatedGraphics/LayerTreeRenderer.h:

(LayerTreeRenderer):

8:27 AM Changeset in webkit [135615] by zhajiang@rim.com
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Meta viewport can't be changed dynamically
https://bugs.webkit.org/show_bug.cgi?id=103098

Patch by Jacky Jiang <zhajiang@rim.com>.
Reviewed by Rob Buis.
Internally reviewed by Arvid Nilsson.

PR: 237072
Reset m_userPerformedManualZoom and enable
m_shouldZoomToInitialScaleAfterLoadFinished so that we can relayout the
page and zoom it to fit the screen when we dynamically change the meta
viewport after the load is finished.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::dispatchViewportPropertiesDidChange):

8:15 AM Changeset in webkit [135614] by rjkroege@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening: update expectations for now crashing test
visibility-simple-canvas2d-layer.html
https://bugs.webkit.org/show_bug.cgi?id=98086

  • platform/chromium/TestExpectations:
8:11 AM Changeset in webkit [135613] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Drop Synchronous Mouse Events
https://bugs.webkit.org/show_bug.cgi?id=102980

Patch by Genevieve Mak <gmak@rim.com> on 2012-11-23
Reviewed by Rob Buis.

Reviewed Internally by George Staikos and Mike Lattanzio.
Don't send actual Touch Events to fullscreen plugins unless
its a Touch Cancel, DoubleTap or TouchHold.
Instead send mouse events as long as its a single finger.
PR #242781

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPage::touchPointAsMouseEvent):
(BlackBerry::WebKit::WebPagePrivate::dispatchTouchEventToFullScreenPlugin):
(WebKit):
(BlackBerry::WebKit::WebPagePrivate::dispatchTouchPointAsMouseEventToFullScreenPlugin):

7:36 AM Changeset in webkit [135612] by commit-queue@webkit.org
  • 4 edits in trunk

[EFL] Define WTF_PLATFORM_EFL in Platform.h
https://bugs.webkit.org/show_bug.cgi?id=101482

Patch by Laszlo Gombos <l.gombos@samsung.com> on 2012-11-23
Reviewed by Kenneth Rohde Christiansen.

.:

Remove the definition of WTF_PLATFORM_EFL from the build system to
make the EFL port consistent with other ports.

  • Source/cmake/OptionsEfl.cmake:

Source/WTF:

Define WTF_PLATFORM_EFL in Platform.h to be consistent with
other ports.

  • wtf/Platform.h:
7:34 AM Changeset in webkit [135611] by zeno.albisser@digia.com
  • 2 edits in trunk/Source/WebCore

[Qt] GraphicsContext3DQt makes wrong surface current.
https://bugs.webkit.org/show_bug.cgi?id=103136

blitMultisampleFramebufferAndRestoreContext restores
the wrong surface in case the currentContext is the same
as m_platformContext.
In this case we would reset the bound surface to NULL.
Instead we should just leave the context unchanged.

Reviewed by Kenneth Rohde Christiansen.

  • platform/graphics/qt/GraphicsContext3DQt.cpp:

(WebCore::GraphicsContext3DPrivate::blitMultisampleFramebufferAndRestoreContext):

7:32 AM Changeset in webkit [135610] by Csaba Osztrogonác
  • 3 edits in trunk/Source/JavaScriptCore

Fix the ARM traditional build after r135330
https://bugs.webkit.org/show_bug.cgi?id=102871

Patch by Gabor Ballabas <gaborb@inf.u-szeged.hu> on 2012-11-23
Reviewed by Zoltan Herczeg.

Added missing functionality to traditional ARM architecture.

  • assembler/ARMAssembler.h:

(JSC::ARMAssembler::revertJump):
(ARMAssembler):

  • assembler/MacroAssemblerARM.h:

(JSC::MacroAssemblerARM::startOfPatchableBranchPtrWithPatchOnAddress):
(JSC::MacroAssemblerARM::startOfBranchPtrWithPatchOnRegister):
(MacroAssemblerARM):
(JSC::MacroAssemblerARM::revertJumpReplacementToBranchPtrWithPatch):

7:15 AM Changeset in webkit [135609] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[EFL][WK2][AC] EwkViewImpl::transformToScreen() does not retrieve the Ecore_X_Window properly
https://bugs.webkit.org/show_bug.cgi?id=103133

Patch by Christophe Dumez <Christophe Dumez> on 2012-11-23
Reviewed by Kenneth Rohde Christiansen.

If accelerated compositing is enabled, EwkViewImpl::transformToScreen() should
attempt to retrieve the Ecore_X_Window using ecore_evas_gl_x11_window_get() first
and only fall back to ecore_evas_software_x11_window_get().

  • UIProcess/API/efl/EwkViewImpl.cpp:

(EwkViewImpl::transformToScreen):

7:13 AM Changeset in webkit [135608] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: remove total item from NMI snapshot grid
https://bugs.webkit.org/show_bug.cgi?id=101926

Patch by Alexei Filippov <alph@chromium.org> on 2012-11-23
Reviewed by Yury Semikhatsky.

  • inspector/front-end/NativeMemorySnapshotView.js:

(WebInspector.NativeSnapshotDataGrid):

7:11 AM Changeset in webkit [135607] by zeno.albisser@digia.com
  • 2 edits in trunk/Source/WebCore

[Qt] GraphicsContext3DQt should not overwrite glClearColor of sharing context.
https://bugs.webkit.org/show_bug.cgi?id=103135

In case we use GraphicsContext3DQt to render into or
read from an existing context, we should not reset
the glClearColor on construction.
Otherwise we might overwrite an existing definition from
the sharing context.

Reviewed by Kenneth Rohde Christiansen.

  • platform/graphics/qt/GraphicsContext3DQt.cpp:

(WebCore::GraphicsContext3D::GraphicsContext3D):

7:01 AM Changeset in webkit [135606] by pfeldman@chromium.org
  • 6 edits
    2 adds in trunk

Web Inspector: damaging last chunk does not remove its garbage from DOM
https://bugs.webkit.org/show_bug.cgi?id=103132

Reviewed by Vsevolod Vlasov.

Source/WebCore:

Removing everything between undamaged chunks, not registered chunk rows.

  • inspector/front-end/DefaultTextEditor.js:

(WebInspector.TextEditorMainPanel.prototype._insertSpanBefore):
(WebInspector.TextEditorMainPanel.prototype._updateChunksForRanges):
(WebInspector.TextEditorMainChunk.prototype.updateCollapsedLineRow):
(WebInspector.TextEditorMainChunk.prototype.firstElement):
(WebInspector.TextEditorMainChunk.prototype.lastElement):

LayoutTests:

  • inspector/editor/editor-test.js:

(initialize_EditorTests.InspectorTest.createTestEditor):
(initialize_EditorTests.InspectorTest.dumpEditorChunks):
(initialize_EditorTests.InspectorTest.dumpEditorModel):
(initialize_EditorTests.InspectorTest.dumpEditorDOM):
(initialize_EditorTests):

  • inspector/editor/text-editor-remove-chunks-from-dom-expected.txt: Added.
  • inspector/editor/text-editor-remove-chunks-from-dom.html: Added.
  • inspector/editor/text-editor-selection-expected.txt:
  • inspector/editor/text-editor-selection.html:
6:55 AM Changeset in webkit [135605] by loislo@chromium.org
  • 3 edits in trunk/Source/WebCore

RenderLayer minor clean-up: replace raw pointers with OwnPtrs.
https://bugs.webkit.org/show_bug.cgi?id=103134

Reviewed by Eric Seidel.

I found that RenderLayer still uses raw pointers to the objects which it owns.
Looks like these pointers could be replaced with OwnPtrs.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::RenderLayer):
(WebCore::RenderLayer::~RenderLayer):
(WebCore::RenderLayer::paintLayerContents):
(WebCore::RenderLayer::hitTestLayer):
(WebCore::RenderLayer::updateNormalFlowList):
(WebCore::RenderLayer::collectLayers):
(WebCore::RenderLayer::styleChanged):

  • rendering/RenderLayer.h:

(WebCore::RenderLayer::marquee):
(WebCore::RenderLayer::posZOrderList):
(WebCore::RenderLayer::negZOrderList):
(WebCore::RenderLayer::normalFlowList):
(RenderLayer):
(WebCore::RenderLayer::clearZOrderLists):

6:31 AM WebKitGTK/AddingNewWebKit2API edited by Carlos Garcia Campos
Add rules to not use the C API (diff)
6:24 AM WebKitGTK/AddingNewWebKit2API edited by Carlos Garcia Campos
Document WEBKIT_DEFINE_ macros (diff)
6:22 AM Changeset in webkit [135604] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[EFL][AC] Mouse cursor is not updated when accelerated compositing is enabled
https://bugs.webkit.org/show_bug.cgi?id=103131

Patch by Christophe Dumez <Christophe Dumez> on 2012-11-23
Reviewed by Kenneth Rohde Christiansen.

Make sure we try to get the Ecore_X_Window using ecore_evas_gl_x11_window_get()
in applyFallbackCursor() if accelerated compositing is enabled instead of
using ecore_evas_software_x11_window_get(). This fixes mouse cursor update
when accelerated compositing is enabled.

No new tests, no behavior change for layout tests.

  • platform/efl/EflScreenUtilities.cpp:

(WebCore::applyFallbackCursor):

6:08 AM Changeset in webkit [135603] by yurys@chromium.org
  • 18 edits
    2 adds in trunk

Memory instrumentation: extract MemoryObjectInfo declaration into a separate file
https://bugs.webkit.org/show_bug.cgi?id=102510

Reviewed by Pavel Feldman.

Source/JavaScriptCore:

Added new symbols for the methods that have moved into .../wtf/MemoryInstrumentation.cpp

Source/WebCore:

Added necessary includes where MemoryObjectInfo declaration is required.

  • platform/audio/FFTFrame.cpp:
  • rendering/style/RenderStyle.cpp:
  • rendering/style/StyleRareInheritedData.cpp:
  • rendering/style/StyleRareNonInheritedData.cpp:

Source/WTF:

Moved MemoryObjectInfo into separate header. Moved definition of MemoryInstrumentation
methods that depend on MemoryObjectInfo declaration into MemoryInstrumentation.cpp to
make MemoryInstrumentation require only forward declaration of MemoryObjectInfo.

  • GNUmakefile.list.am:
  • WTF.gypi:
  • WTF.pro:
  • WTF.vcproj/WTF.vcproj:
  • wtf/CMakeLists.txt:
  • wtf/MemoryInstrumentation.cpp: Added.

(WTF):
(WTF::MemoryInstrumentation::MemoryInstrumentation):
(WTF::MemoryInstrumentation::~MemoryInstrumentation):
(WTF::MemoryInstrumentation::getObjectType): this method allows to get object type without
pulling in MemoryObjectInfo.h and all its dependencies.
(WTF::MemoryInstrumentation::callReportObjectInfo):
(WTF::MemoryInstrumentation::InstrumentedPointerBase::InstrumentedPointerBase):
(WTF::MemoryInstrumentation::InstrumentedPointerBase::process):
(WTF::MemoryClassInfo::init):
(WTF::MemoryClassInfo::addRawBuffer):
(WTF::MemoryClassInfo::addPrivateBuffer):

  • wtf/MemoryInstrumentation.h:

(MemoryInstrumentation):
(WTF::MemoryInstrumentation::addRootObject):
(InstrumentedPointerBase):
(WTF::MemoryInstrumentation::reportObjectMemoryUsage):
(InstrumentedPointer):
(WTF::MemoryInstrumentation::addObject): we now pass owner's MemoryObjectInfo in all places
where we report objects pointed by the owner.
(WTF::MemoryInstrumentation::OwningTraits::addObject):
(WTF::MemoryClassInfo::MemoryClassInfo):
(WTF::MemoryClassInfo::addMember):
(MemoryClassInfo):
(WTF::MemoryInstrumentation::addObjectImpl):
(WTF::::InstrumentedPointer):
(WTF::::callReportMemoryUsage):

  • wtf/MemoryObjectInfo.h: Added.

(WTF):
(MemoryObjectInfo):
(WTF::MemoryObjectInfo::MemoryObjectInfo):
(WTF::MemoryObjectInfo::objectType):
(WTF::MemoryObjectInfo::objectSize):
(WTF::MemoryObjectInfo::reportedPointer):
(WTF::MemoryObjectInfo::memoryInstrumentation):
(WTF::MemoryObjectInfo::reportObjectInfo):

Tools:

Added missing includes.

  • TestWebKitAPI/Tests/WTF/MemoryInstrumentationTest.cpp:
6:05 AM Changeset in webkit [135602] by allan.jensen@digia.com
  • 2 edits in trunk/Source/WebKit/qt

tst_qwebpage fails after QMimeDatabase patch
https://bugs.webkit.org/show_bug.cgi?id=103125

Reviewed by Simon Hausmann.

Replace the static extension->mimetype table with a QMimeDatabase lookup

  • tests/qwebpage/tst_qwebpage.cpp:

(tst_QWebPage::findText):
(tst_QWebPage::supportedContentType):

5:44 AM Changeset in webkit [135601] by commit-queue@webkit.org
  • 11 edits in trunk/Source/WebCore

Remove V8DOMWindowShell::getEntered
https://bugs.webkit.org/show_bug.cgi?id=96637

Patch by Dan Carney <dcarney@google.com> on 2012-11-23
Reviewed by Adam Barth.

V8DOMWindowShell::getEntered was refactored so that the window shell
no longer has to be kept alive by a v8 context. Instead, only
the DOMWrapperWorld will be kept alive.

No new tests. No change in functionality.

  • bindings/v8/DOMDataStore.cpp:

(WebCore::DOMDataStore::current):

  • bindings/v8/DOMWrapperWorld.cpp:

(WebCore::isolatedWorldWeakCallback):
(WebCore):
(WebCore::DOMWrapperWorld::makeContextWeak):
(WebCore::DOMWrapperWorld::setIsolatedWorldField):

  • bindings/v8/DOMWrapperWorld.h:

(DOMWrapperWorld):
(WebCore::DOMWrapperWorld::isolated):

  • bindings/v8/ScriptController.cpp:

(WebCore::ScriptController::existingWindowShell):
(WebCore::ScriptController::windowShell):
(WebCore::ScriptController::evaluateInIsolatedWorld):
(WebCore::ScriptController::currentWorldContext):
(WebCore::ScriptController::collectIsolatedContexts):

  • bindings/v8/ScriptController.h:

(ScriptController):

  • bindings/v8/V8Binding.h:

(WebCore::worldForEnteredContextIfIsolated):

  • bindings/v8/V8DOMWindowShell.cpp:

(WebCore::V8DOMWindowShell::destroyIsolatedShell):
(WebCore::V8DOMWindowShell::disposeContext):
(WebCore::V8DOMWindowShell::initializeIfNeeded):

  • bindings/v8/V8DOMWindowShell.h:

(V8DOMWindowShell):

  • bindings/v8/V8PerContextData.h:
  • bindings/v8/WorldContextHandle.cpp:

(WebCore::WorldContextHandle::WorldContextHandle):

5:38 AM Changeset in webkit [135600] by commit-queue@webkit.org
  • 4 edits in trunk/Tools

[EFL][WK2] Add support for PlatformWebView::simulateSpacebarKeyPress() in TestWebKitAPI
https://bugs.webkit.org/show_bug.cgi?id=103123

Patch by Sudarsana Nagineni <sudarsana.nagineni@intel.com> on 2012-11-23
Reviewed by Kenneth Rohde Christiansen.

Add support for PlatformWebView::simulateSpacebarKeyPress() and enable
WebKit2 API test ResponsivenessTimerDoesntFireEarly.

  • TestWebKitAPI/PlatformEfl.cmake: Enable ResponsivenessTimerDoesntFireEarly

test.

  • TestWebKitAPI/efl/PlatformUtilities.cpp:

(TestWebKitAPI::Util::sleep): Use usleep() instead of sleep since the
test case is passing 0.5 seconds to sleep.

  • TestWebKitAPI/efl/PlatformWebView.cpp:

(TestWebKitAPI::PlatformWebView::simulateSpacebarKeyPress): Implemented.
(TestWebKitAPI):

5:25 AM Changeset in webkit [135599] by commit-queue@webkit.org
  • 9 edits in trunk/Source/WebCore

Web Inspector: Refine JsDoc in ProfilesPanel.js
https://bugs.webkit.org/show_bug.cgi?id=103042

Patch by Eugene Klyuchnikov <eustas.bug@gmail.com> on 2012-11-23
Reviewed by Yury Semikhatsky.

I'm going to make profiler output typed.

This will require some amount of refactoring.

Before refactoring I would like to make things
unambiguous by adding JsDoc where they are missing.

  • inspector/front-end/ProfilesPanel.js:

(WebInspector.ProfilesPanel.prototype._onToggleProfiling):
Added to eliminate parameter type ambiguity.

5:11 AM Changeset in webkit [135598] by tkent@chromium.org
  • 12 edits in trunk

Correct input[type=number] value sanitization for user-input
https://bugs.webkit.org/show_bug.cgi?id=103018

Reviewed by Kentaro Hara.

Source/WebCore:

If a number field has non-number string, HTMLInputElement::value is not
updated and returns the past valid value. It doesn't match to the value
sanitization algorithm defined by the HTML standard [1], and Opera's
behavior. We should sanitize non-number strings to "".

[1] http://www.whatwg.org/specs/web-apps/current-work/multipage/states-of-the-type-attribute.html#number-state-(type=number)

The value sanitization algorithm is as follows: If the value of the
element is not a valid floating-point number, then set it to the empty
string instead.

No new tests. Update existing tests;
fast/forms/number/number-commit-valid-only.html and
fast/forms/number/number-unacceptable-style.html

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::subtreeHasChanged):
Remove isAcceptableValue check.

  • html/HTMLInputElement.h:

(HTMLInputElement): isAcceptableValue is no longer needed.

  • html/InputType.cpp: Remove isAcceptableValue.
  • html/InputType.h: Ditto.
  • html/NumberInputType.cpp: Ditto.

(WebCore::NumberInputType::hasUnacceptableValue):
Fold the isAcceptableValue content into this.

  • html/NumberInputType.h:

(NumberInputType): Remove isAcceptableValue.

LayoutTests:

  • fast/forms/number/number-commit-valid-only-expected.txt:
  • fast/forms/number/number-commit-valid-only.html:

Update the expected HTMLInputElement::value results.

  • fast/forms/number/number-unacceptable-style-expected.txt:
  • fast/forms/number/number-unacceptable-style.html:

Add some checks for HTMLInputElement::value.

5:11 AM Changeset in webkit [135597] by commit-queue@webkit.org
  • 3 edits in trunk/Source/JavaScriptCore

[sh4] JavaScriptCore JIT build is broken since r130839
Add missing implementation for sh4 arch.
https://bugs.webkit.org/show_bug.cgi?id=101479

Patch by Julien BRIANCEAU <jbrianceau@nds.com> on 2012-11-23
Reviewed by Filip Pizlo.

  • assembler/MacroAssemblerSH4.h:

(JSC::MacroAssemblerSH4::load8Signed):
(MacroAssemblerSH4):
(JSC::MacroAssemblerSH4::load16Signed):
(JSC::MacroAssemblerSH4::store8):
(JSC::MacroAssemblerSH4::store16):
(JSC::MacroAssemblerSH4::moveDoubleToInts):
(JSC::MacroAssemblerSH4::moveIntsToDouble):
(JSC::MacroAssemblerSH4::loadFloat):
(JSC::MacroAssemblerSH4::loadDouble):
(JSC::MacroAssemblerSH4::storeFloat):
(JSC::MacroAssemblerSH4::storeDouble):
(JSC::MacroAssemblerSH4::addDouble):
(JSC::MacroAssemblerSH4::convertFloatToDouble):
(JSC::MacroAssemblerSH4::convertDoubleToFloat):
(JSC::MacroAssemblerSH4::urshift32):

  • assembler/SH4Assembler.h:

(JSC::SH4Assembler::sublRegReg):
(JSC::SH4Assembler::subvlRegReg):
(JSC::SH4Assembler::floatfpulfrn):
(JSC::SH4Assembler::fldsfpul):
(JSC::SH4Assembler::fstsfpul):
(JSC::SH4Assembler::dcnvsd):
(SH4Assembler):
(JSC::SH4Assembler::movbRegMem):
(JSC::SH4Assembler::sizeOfConstantPool):
(JSC::SH4Assembler::linkJump):
(JSC::SH4Assembler::printInstr):
(JSC::SH4Assembler::printBlockInstr):

4:57 AM Changeset in webkit [135596] by yurys@chromium.org
  • 2 edits in trunk/Source/WebCore

Unreviewed, rolling out r135592.
http://trac.webkit.org/changeset/135592
https://bugs.webkit.org/show_bug.cgi?id=103126

broke Chromium Mac compilation (Requested by yurys on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-11-23

  • WebCore.gypi:
4:55 AM Changeset in webkit [135595] by commit-queue@webkit.org
  • 14 edits in trunk

[WK2][WKTR] WebKitTestRunner needs eventSender.contextClick()
https://bugs.webkit.org/show_bug.cgi?id=86881

Patch by Wojciech Bielawski <w.bielawski@samsung.com> on 2012-11-23
Reviewed by Kenneth Rohde Christiansen.

Source/WebKit2:

InjectedBundle API extended to retrieve contextMenu entries names.
WebContextMenu exteded with function to retrieve menu items.
This API is required by layout tests.
Common code in WebContextMenu.cpp moved to separate method menuItemsWithUserData().
Behaviour of dependend methods is unchanged.

  • WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:

(WKBundlePageGetContextMenuEntriesNames):

  • WebProcess/InjectedBundle/API/c/WKBundlePage.h:
  • WebProcess/WebPage/WebContextMenu.cpp:

(WebKit::WebContextMenu::items):
(WebKit):

  • WebProcess/WebPage/WebContextMenu.h:

(WebContextMenu):

Tools:

eventSender object extended with contextClick() method in WebKitTestRunner.
contextClick() method returns an array of menu items objects with field 'title' containing title of single
context menu entry. According to some tests menu items objects shall also support 'click()' method, but it's not
delivered in this patch.

  • WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
  • WebKitTestRunner/InjectedBundle/EventSendingController.cpp:

(WTR::EventSendingController::contextClick):
(WTR):

  • WebKitTestRunner/InjectedBundle/EventSendingController.h:

(EventSendingController):

LayoutTests:

Added expected results for two tests for EFL platform. Test expectations changed
for EFL WK1/WK2 and GTK platforms

  • platform/efl/TestExpectations:
  • platform/efl-wk1/TestExpectations:
  • platform/efl-wk2/TestExpectations:
  • platform/gkt-wk2/TestExpectations:
  • platform/gtk/editing/selection/5354455-2-expected.txt:
  • platform/efl/editing/selection/5354455-2-expected.txt: Added.
  • platform/efl/fast/events/context-no-deselect-expected.txt: Added.
4:54 AM Changeset in webkit [135594] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] InputHandler::ensureFocusTextElementVisible incorrectly used y coordinate as x coordinate
https://bugs.webkit.org/show_bug.cgi?id=103091

Patch by Andrew Lo <anlo@rim.com> on 2012-11-23
Reviewed by Yong Li.

Internally reviewed by Mike Fenton.
Internal PR249523
Incorrectly used y coordinate as x coordinate in
InputHandler::ensureFocusTextElementVisible.

  • WebKitSupport/InputHandler.cpp:

(BlackBerry::WebKit::InputHandler::ensureFocusTextElementVisible):

4:48 AM Changeset in webkit [135593] by yurys@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Fix Chromium Win compilation after r135580.
https://bugs.webkit.org/show_bug.cgi?id=101772

  • tests/WebFrameTest.cpp:
4:38 AM Changeset in webkit [135592] by yurys@chromium.org
  • 2 edits in trunk/Source/WebCore

Remove references to non-chromium entries from WebCore.gypi (part 2)
https://bugs.webkit.org/show_bug.cgi?id=103124

Reviewed by Pavel Feldman.

  • WebCore.gypi: removed references to gtk, cocoa, posix, ios, cf, win and mac
4:20 AM Changeset in webkit [135591] by commit-queue@webkit.org
  • 8 edits in trunk/Source/WebCore

Web Inspector: [Canvas] add startCapturing and stopCapturing methods to protocol
https://bugs.webkit.org/show_bug.cgi?id=103053

Patch by Andrey Adaikin <aandrey@chromium.org> on 2012-11-23
Reviewed by Pavel Feldman.

Add startCapturing and stopCapturing methods to the protocol to instrument several canvas frames in a row.
Drive-by: support start offset index in retrieving trace logs in the backend as well as "alive" flag.

  • inspector/InjectedScriptCanvasModule.cpp:

(WebCore::InjectedScriptCanvasModule::captureFrame):
(WebCore):
(WebCore::InjectedScriptCanvasModule::startCapturing):
(WebCore::InjectedScriptCanvasModule::callStartCapturingFunction):
(WebCore::InjectedScriptCanvasModule::stopCapturing):
(WebCore::InjectedScriptCanvasModule::dropTraceLog):
(WebCore::InjectedScriptCanvasModule::callVoidFunctionWithTraceLogIdArgument):
(WebCore::InjectedScriptCanvasModule::traceLog):

  • inspector/InjectedScriptCanvasModule.h:

(InjectedScriptCanvasModule):

  • inspector/InjectedScriptCanvasModuleSource.js:

(.):

  • inspector/Inspector.json:
  • inspector/InspectorCanvasAgent.cpp:

(WebCore::InspectorCanvasAgent::startCapturing):
(WebCore):
(WebCore::InspectorCanvasAgent::stopCapturing):
(WebCore::InspectorCanvasAgent::getTraceLog):

  • inspector/InspectorCanvasAgent.h:

(InspectorCanvasAgent):

  • inspector/front-end/CanvasProfileView.js:

(WebInspector.CanvasProfileView):

4:15 AM Changeset in webkit [135590] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

[EFL] Newly added tests in r135436 and r135456 are failng
https://bugs.webkit.org/show_bug.cgi?id=103112

Unreviewed EFL gardening.

Skip new failing tests introduced in r135436 and r135456.

Patch by Sudarsana Nagineni <sudarsana.nagineni@intel.com> on 2012-11-23

  • platform/efl-wk2/TestExpectations:
  • platform/efl/TestExpectations:
4:09 AM Changeset in webkit [135589] by Csaba Osztrogonác
  • 3 edits in trunk/LayoutTests

Unreviewed gardening, skip failing tests.

  • platform/qt-5.0-wk2/TestExpectations:
  • platform/wk2/TestExpectations:
4:08 AM Changeset in webkit [135588] by caseq@chromium.org
  • 11 edits in trunk/Source/WebCore

Web Inspector: dispatch events upon certain user actions on inspector's notification services
https://bugs.webkit.org/show_bug.cgi?id=103114

Reviewed by Pavel Feldman.

Add a bunch of WebInspector.UserMetrics.UserAction, so platform-specific code can wire to user actions
without breaking too often.

  • inspector/front-end/ElementsPanel.js:

(WebInspector.ElementsPanel.prototype._setPseudoClassForNodeId):

  • inspector/front-end/JavaScriptSourceFrame.js:

(WebInspector.JavaScriptSourceFrame.prototype._setBreakpoint):

  • inspector/front-end/NetworkItemView.js:

(WebInspector.NetworkItemView.prototype._tabSelected.set WebInspector):
(WebInspector.NetworkItemView.prototype._tabSelected):

  • inspector/front-end/NetworkPanel.js:

(WebInspector.NetworkLogView.prototype._sortItems):
(WebInspector.NetworkDataGridNode.prototype.select):

  • inspector/front-end/ProfilesPanel.js:

(WebInspector.ProfilesPanel.prototype.addProfileHeader):

  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype._showSourceLine):
(WebInspector.ScriptsPanel.prototype._toggleFormatSource):

  • inspector/front-end/UISourceCode.js:

(WebInspector.UISourceCode.prototype.revertToOriginal):
(WebInspector.UISourceCode.prototype.revertAndClearHistory):
(WebInspector.UISourceCode.prototype.commitWorkingCopy):

  • inspector/front-end/UserMetrics.js:
  • inspector/front-end/externs.js:
  • inspector/front-end/inspector.js:

(WebInspector._requestZoom.set var):
(WebInspector._requestZoom):

3:52 AM Changeset in webkit [135587] by commit-queue@webkit.org
  • 5 edits
    4 adds in trunk

WebSocket's MessageEvent.origin attribute is an empty string
https://bugs.webkit.org/show_bug.cgi?id=102889

Patch by Christophe Dumez <Christophe Dumez> on 2012-11-23
Reviewed by Kentaro Hara.

Source/WebCore:

Fix WebSocket implementation so that the message event's origin
attribute is properly set to the Unicode serialization of the
origin of the URL that was passed to the WebSocket object's
constructor, instead of an empty string.

The new behavior is according to the specification:
http://www.whatwg.org/specs/web-apps/current-work/multipage/network.html#feedback-from-the-protocol

It also matches the behavior of Firefox.

Tests: http/tests/websocket/tests/hybi/send-blob-onmessage-origin.html

http/tests/websocket/tests/hybi/send-onmessage-origin.html

  • Modules/websockets/WebSocket.cpp:

(WebCore::WebSocket::didReceiveMessage):
(WebCore::WebSocket::didReceiveBinaryData):

  • dom/MessageEvent.cpp:

(WebCore::MessageEvent::MessageEvent):

  • dom/MessageEvent.h:

(WebCore::MessageEvent::create):
(MessageEvent):

LayoutTests:

Add layout tests to check that the message event's origin attribute
is set to the Unicode serialization of the origin of the URL that
was passed to the WebSocket object's constructor, as per the
WebSocket specification.

  • http/tests/websocket/tests/hybi/send-blob-onmessage-origin-expected.txt: Added.
  • http/tests/websocket/tests/hybi/send-blob-onmessage-origin.html: Added.
  • http/tests/websocket/tests/hybi/send-onmessage-origin-expected.txt: Added.
  • http/tests/websocket/tests/hybi/send-onmessage-origin.html: Added.
3:31 AM Changeset in webkit [135586] by caseq@chromium.org
  • 5 edits in trunk

Web Inspector: No "Save Heap Snapshot" option after canceling save to file dialog.
https://bugs.webkit.org/show_bug.cgi?id=100916

Patch by Eugene Klyuchnikov <eustas.bug@gmail.com> on 2012-11-22
Reviewed by Yury Semikhatsky.

Source/WebCore:

Fixed order of operations - now receiver is assigned only when save
dialog responds.

  • inspector/front-end/HeapSnapshotView.js: Fixed order of operations.

LayoutTests:

Extracted "injectMockProfile" method and reused it in new test.

  • inspector/profiler/heap-snapshot-loader-expected.txt: Added test case.
  • inspector/profiler/heap-snapshot-loader.html:

Refactored and added new test case.

3:29 AM Changeset in webkit [135585] by Simon Hausmann
  • 5 edits in trunk

[Qt] Compiling against QtWebkit API requires QT_DLL to be defined
https://bugs.webkit.org/show_bug.cgi?id=102942

Reviewed by Tor Arne Vestbø.

Remove the requirement of having QT_DLL defined in order for the QWEBKIT_EXPORT
macro to be defined as Q_DECL_IMPORT. Instead unify the export macro definition
to follow the same rules as other Qt 5 modules, with the exception that instead of
QT_BUILD_WEBKIT_LIB we continue to use BUILDING_WEBKIT, because that's used also
in other cross-platform header files to determine the correct meaning of export
macros.

Source/WebKit/qt:

  • Api/qwebkitglobal.h:

Tools:

  • qmake/mkspecs/features/default_post.prf:
  • qmake/mkspecs/features/win32/default_post.prf:
3:27 AM Changeset in webkit [135584] by allan.jensen@digia.com
  • 4 edits in trunk

[Qt] REGRESSION(r135507): It made 13 tests fail
https://bugs.webkit.org/show_bug.cgi?id=103069

Reviewed by Simon Hausmann.

Source/WebCore:

The subframe loading logic depends on that script extensions are not recognized,
so avoid recognizing them in getMIMETypeForExtension which is used for pre-load
mimetype detection.

  • platform/qt/MIMETypeRegistryQt.cpp:

(WebCore::MIMETypeRegistry::getMIMETypeForExtension):

LayoutTests:

Unskip the last of test regressions now passing.

  • platform/qt/TestExpectations:
3:22 AM Changeset in webkit [135583] by jochen@chromium.org
  • 2 edits in trunk/Source/WebCore

REGRESSION (r135455): Compilation without SVG enabled broken
https://bugs.webkit.org/show_bug.cgi?id=103108

Reviewed by Yury Semikhatsky.

Move SVG-only code behind #if ENABLE(SVG) that was accidentially moved
outside of the #if block during the refactoring.

  • platform/graphics/filters/FilterOperation.h:

(ReferenceFilterOperation):

3:17 AM Changeset in webkit [135582] by Simon Hausmann
  • 10 edits in trunk

[Qt] QWebPage::shouldInterruptJavaScript should be virtual in Qt 5
https://bugs.webkit.org/show_bug.cgi?id=103111

Reviewed by Kenneth Rohde Christiansen.

This function was added as a slot during Qt 4.x times because adding
virtual functions breaks binary compatibility. This constraint is gone
with the initial release of WebKit with Qt 5, and therefore we can
make it virtual now.

The change is fully source compatible as existing "re-implementations"
as slots will now be called through it being a virtual function. They
become unused slots.

Source/WebKit/qt:

  • Api/qwebpage.cpp:

(QWebPagePrivate::shouldInterruptJavaScript):

  • Api/qwebpage.h:
  • Api/qwebpage_p.h:
  • WebCoreSupport/ChromeClientQt.cpp:

(WebCore::ChromeClientQt::shouldInterruptJavaScript):

  • WebCoreSupport/QWebPageAdapter.h:

(QWebPageAdapter):

  • tests/qwebpage/tst_qwebpage.cpp:

(JSTestPage::shouldInterruptJavaScript):
(JSTestPage):

Tools:

  • DumpRenderTree/qt/DumpRenderTreeQt.h:

(WebCore::WebPage::shouldInterruptJavaScript):
(WebPage):

  • QtTestBrowser/webpage.h:

(WebPage):

3:17 AM Changeset in webkit [135581] by yurys@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed. Updated test expectations.

  • platform/chromium/TestExpectations:
3:15 AM Changeset in webkit [135580] by commit-queue@webkit.org
  • 7 edits in trunk/Source

[chromium] Remove WebScreenInfo.{horizontal,vertical}DPI
https://bugs.webkit.org/show_bug.cgi?id=101772

Patch by Sami Kyostila <skyostil@chromium.org> on 2012-11-23
Reviewed by Adam Barth.

Now that nothing is using WebScreenInfo.{horizontal,vertical}DPI we can simply
remove them.

Source/Platform:

  • chromium/public/WebScreenInfo.h:

(WebKit::WebScreenInfo::WebScreenInfo):

Source/WebKit/chromium:

  • src/mac/WebScreenInfoFactory.mm:

(WebKit::WebScreenInfoFactory::screenInfo):

  • src/win/WebScreenInfoFactory.cpp:

(WebKit::WebScreenInfoFactory::screenInfo):

  • src/x11/WebScreenInfoFactory.cpp:

(WebKit::WebScreenInfoFactory::screenInfo):

3:10 AM Changeset in webkit [135579] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

fast/events/mouseover-button.html never releases a mouse button
https://bugs.webkit.org/show_bug.cgi?id=103041

Patch by Jussi Kukkonen <jussi.kukkonen@intel.com> on 2012-11-23
Reviewed by Kenneth Rohde Christiansen.

mouseover-button.html released the wrong mouse button so subsequent
tests would fail: This includes at least svg/text/select-*.svg .

  • fast/events/mouseover-button.html:
2:59 AM Changeset in webkit [135578] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

REGRESSION (r128633): td changes size during re-layout of table although it shouldn't
https://bugs.webkit.org/show_bug.cgi?id=102802

Patch by Julian Pastarmov <pastarmovj@chromium.org> on 2012-11-23
Reviewed by Ojan Vafai.

Source/WebCore:

The bug was caused by incorrectly rewriting a nested condition which caused the else
clause to trigger in wrong cases.

Test: fast/table/nested-tables-with-div-offset.html

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::computePercentageLogicalHeight):
Reverted wrong combination of nested if statements.

LayoutTests:

This test checks that table layout of some nested tables in quirks mode is computed correctly.

  • fast/table/nested-tables-with-div-offset-expected.txt: Added.
  • fast/table/nested-tables-with-div-offset.html: Added.
2:30 AM Changeset in webkit [135577] by allan.jensen@digia.com
  • 4 edits
    1 add in trunk

[Qt] REGRESSION(r135507): It made 13 tests fail
https://bugs.webkit.org/show_bug.cgi?id=103069

Reviewed by Simon Hausmann.

Source/WebCore:

Fix regression in recognizing MHTML on some platforms.

  • platform/qt/MIMETypeRegistryQt.cpp:

(ExtensionMap):
(WebCore::MIMETypeRegistry::getMIMETypeForExtension):
(WebCore::MIMETypeRegistry::getMIMETypeForPath):

LayoutTests:

Unskip fixed test and update one benign change.

  • platform/qt/TestExpectations:
  • platform/qt/fast/preloader/script-expected.txt: Added.
2:18 AM Changeset in webkit [135576] by pierre.rossi@gmail.com
  • 4 edits in trunk

[Qt] REGRESSION(r135515): 3 appcache tests still failing
https://bugs.webkit.org/show_bug.cgi?id=103073

Rubber-stamped by Simon Hausmann.

Source/WebKit/qt:

Another sneaky typo.

  • Api/qwebpage.cpp:

(QWebPagePrivate::applicationCacheQuotaExceeded):

LayoutTests:

  • platform/qt/TestExpectations: Unskipped the affected tests.
2:17 AM Changeset in webkit [135575] by pierre.rossi@gmail.com
  • 5 edits in trunk/Source

[Qt] Avoid initializing PlatformStrategies twice.

Rubber-stamped by Simon Hausmann.

This fixes another regression introduced in r135515:
initializeWebKitQt shouldn't implicitely call initializeWebCoreQt
since it can be called from WebKit2 to initialize QStyle for testing.
This would then lead to things such as PlatformStrategies being
initialized twice.

Source/WebKit/qt:

  • Api/qwebpage.cpp: Explicitely call initializeWebCoreQt().

(QWebPagePrivate::QWebPagePrivate):

  • WebCoreSupport/InitWebCoreQt.cpp:

(WebKit::initializeWebKitQt):

Source/WebKit2:

  • qt/MainQt.cpp: No need to initialize anything if we're not using QStyle.

(WebKit):
(main):

2:14 AM Changeset in webkit [135574] by pfeldman@chromium.org
  • 4 edits
    3 adds in trunk

Web Inspector: ctrl+end in editor does not select the last symbol.
https://bugs.webkit.org/show_bug.cgi?id=103078

Reviewed by Vsevolod Vlasov.

Source/WebCore:

Test: inspector/editor/text-editor-selection.html

  • inspector/front-end/DefaultTextEditor.js:

(WebInspector.DefaultTextEditor.prototype._handleScrollChanged):
(WebInspector.DefaultTextEditor.prototype.overrideViewportForTest):
(WebInspector.TextEditorChunkedPanel.prototype._repaintAll):
(WebInspector.TextEditorChunkedPanel.prototype._scrollTop):
(WebInspector.TextEditorChunkedPanel.prototype._clientHeight):
(WebInspector.TextEditorMainPanel.prototype._paintLineChunks):
(WebInspector.TextEditorMainPanel.prototype._selectionToPosition):
(WebInspector.TextEditorMainPanel.prototype._updateHighlightsForRange):

LayoutTests:

  • inspector/editor/editor-test.js: Added.

(initialize_EditorTests.InspectorTest.createTestEditor):
(initialize_EditorTests.InspectorTest.dumpEditorChunks):
(initialize_EditorTests):

  • inspector/editor/text-editor-selection-expected.txt: Added.
  • inspector/editor/text-editor-selection.html: Added.
1:57 AM Changeset in webkit [135573] by yurys@chromium.org
  • 2 edits in trunk/Source/WebCore

Remove references to non-chromium entries from WebCore.gypi
https://bugs.webkit.org/show_bug.cgi?id=103103

Reviewed by Pavel Feldman.

  • WebCore.gypi: Removed references to files specific for wince, cairo, qt, wx and efl.
1:55 AM Changeset in webkit [135572] by yurys@chromium.org
  • 4 edits
    2 moves
    6 adds in trunk/LayoutTests

Unreviewed. Updated test expectations.

  • platform/chromium-linux/fast/repaint/line-flow-with-floats-in-regions-expected.png: Added.
  • platform/chromium-linux/fast/writing-mode/text-orientation-basic-expected.png: Added.
  • platform/chromium-linux/platform/chromium/virtual/gpu/fast/hidpi/video-controls-in-hidpi-expected.png: Added.
  • platform/chromium-win/fast/transforms/transformed-focused-text-input-expected.png:
  • platform/chromium-win/platform/chromium/virtual/deferred/fast/images/pdf-as-image-landscape-expected.png: Added.
  • platform/chromium-win/platform/chromium/virtual/gpu/fast/canvas/arc360-expected.png:
  • platform/chromium/TestExpectations:
  • platform/efl-wk1/fast/transforms/transformed-focused-text-input-expected.png: Renamed from LayoutTests/platform/efl/fast/transforms/transformed-focused-text-input-expected.png.
  • platform/efl-wk1/fast/writing-mode/text-orientation-basic-expected.png: Renamed from LayoutTests/platform/efl/fast/writing-mode/text-orientation-basic-expected.png.
1:45 AM Changeset in webkit [135571] by apavlov@chromium.org
  • 4 edits in trunk/Source/WebCore

Web Inspector: inspector overlay is always updated when inspector is open
https://bugs.webkit.org/show_bug.cgi?id=103106

Reviewed by Pavel Feldman.

Provide empty size into the InspectorOverlay if the metrics emulation is disabled,
so that it will not get painted in all cases.

  • inspector/InspectorController.cpp:

(WebCore::InspectorController::webViewResized): Call InspectorPageAgent::webViewResized() rather than InspectorOverlay::resize().

  • inspector/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::webViewResized): Provide empty size into InspectorOverlay::resize() if device metrics are not emulated.

  • inspector/InspectorPageAgent.h:
1:29 AM Changeset in webkit [135570] by kkristof@inf.u-szeged.hu
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening after r135532. It made 3 tests fail.
https://bugs.webkit.org/show_bug.cgi?id=103073

Patch by János Badics <János Badics> on 2012-11-23

  • platform/qt/TestExpectations:
1:22 AM Changeset in webkit [135569] by commit-queue@webkit.org
  • 8 edits
    1 add
    1 delete in trunk

[EFL] Platform support for Accessibility feature.
https://bugs.webkit.org/show_bug.cgi?id=100848

Patch by Krzysztof Czech <k.czech@samsung.com> on 2012-11-23
Reviewed by Gyuyoung Kim.

.:

Add support for ATK library.

  • Source/cmake/FindATK.cmake: Added.
  • Source/cmake/OptionsEfl.cmake:

Source/WebCore:

Add EFL platform's definitions to enable proper accessibility routines.

No new tests. Covered by existing layout tests.

  • PlatformEfl.cmake: Add accessibility/atk content to compilation.
  • accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::AccessibilityObject):

  • accessibility/AccessibilityObject.h:

(AccessibilityObject):

  • accessibility/efl/AccessibilityObjectEfl.cpp: Removed. No needed platform specific implementation. ATK shared implementation will be used.

Source/WTF:

Enable HAVE(ACCESSIBILITY) ifdefs so that EFL port can use it.

  • wtf/Platform.h:
1:13 AM Changeset in webkit [135568] by yurys@chromium.org
  • 11 edits
    3 moves
    1 add in trunk/LayoutTests

Unreviewed. Update test expectations.

  • platform/chromium-mac-lion/fast/css/input-search-padding-expected.png:
  • platform/chromium-mac-lion/svg/W3C-SVG-1.1/struct-dom-06-b-expected.png:
  • platform/chromium-mac-lion/svg/batik/text/xmlSpace-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/struct-dom-06-b-expected.png:
  • platform/chromium-mac-snowleopard/svg/batik/text/xmlSpace-expected.png:
  • platform/chromium-mac/fast/css/input-search-padding-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/struct-dom-06-b-expected.png:
  • platform/chromium-mac/svg/batik/text/xmlSpace-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/struct-dom-06-b-expected.png:
  • platform/chromium-win/svg/batik/text/xmlSpace-expected.png:
  • platform/efl-wk1/fast/css/input-search-padding-expected.png: Renamed from LayoutTests/platform/efl/fast/css/input-search-padding-expected.png.
  • platform/efl-wk1/svg/W3C-SVG-1.1/struct-dom-06-b-expected.png: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/struct-dom-06-b-expected.png.
  • platform/efl-wk1/svg/batik/text/xmlSpace-expected.png: Renamed from LayoutTests/platform/efl/svg/batik/text/xmlSpace-expected.png.
1:12 AM Changeset in webkit [135567] by Simon Hausmann
  • 5 edits in trunk/Source/WebKit/qt

Unreviewed trivial Qt/Win build fix:

Include FormState.h/HTMLFormElement.h in the FrameLoaderClient
declaration because MSVC needs it. Also fix Q_DECL_EXPORT declarations
for functions that are supposed to be exported.

  • Api/qwebelement.cpp:
  • WebCoreSupport/FrameLoaderClientQt.h:
  • WebCoreSupport/InitWebCoreQt.h:

(WebKit):

  • WebCoreSupport/InitWebKitQt.h:

(WebKit):

1:10 AM EFLWebKit edited by k.czech@samsung.com
(diff)
1:00 AM Changeset in webkit [135566] by yurys@chromium.org
  • 1 edit
    2 moves
    8 adds in trunk/LayoutTests

Unreviewed. Update test expectations.

  • platform/chromium-mac-lion/fast/css/font-weight-1-expected.png: Added.
  • platform/chromium-mac-lion/fast/css/font-weight-1-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/css/font-weight-1-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/css/font-weight-1-expected.txt: Added.
  • platform/chromium-mac/fast/css/font-weight-1-expected.png: Added.
  • platform/chromium-mac/fast/css/font-weight-1-expected.txt: Added.
  • platform/chromium-mac/platform/chromium/virtual/deferred/fast/images/pdf-as-image-expected.png: Added.
  • platform/chromium-win/fast/css/font-weight-1-expected.png: Renamed from LayoutTests/platform/chromium/fast/css/font-weight-1-expected.png.
  • platform/chromium-win/platform/chromium/virtual/deferred/fast/images/pdf-as-image-expected.png: Added.
  • platform/efl-wk1/fast/css/font-weight-1-expected.png: Renamed from LayoutTests/platform/efl/fast/css/font-weight-1-expected.png.
12:30 AM Changeset in webkit [135565] by Carlos Garcia Campos
  • 31 edits in trunk/Source/WebKit2

[GTK] Use custom private macros to define GObjects
https://bugs.webkit.org/show_bug.cgi?id=99705

Reviewed by Martin Robinson.

Add WEBKIT_DEFINE_TYPE macros, similar and compatible with
G_DEFINE_TYPE macros, to define GObject types. These macros also
define the init and finalize functions reducing the GObject
boilerplate and hiding the placement new syntax that causes some
confusion. The patch replaces the use of G_DEFINE_TYPE macros by
WEBKIT_DEFINE_TYPE ones and removes the init and finalize
implementations, moving custom code when needed to the private
struct constructor/destructor or constructed/dispose virtual
methods when appropriate.

  • UIProcess/API/gtk/WebKitBackForwardList.cpp:
  • UIProcess/API/gtk/WebKitBackForwardListItem.cpp:

(webkit_back_forward_list_item_class_init):

  • UIProcess/API/gtk/WebKitContextMenu.cpp:

(webkitContextMenuDispose):
(webkit_context_menu_class_init):

  • UIProcess/API/gtk/WebKitContextMenuItem.cpp:

(_WebKitContextMenuItemPrivate::~_WebKitContextMenuItemPrivate):
(_WebKitContextMenuItemPrivate):
(webkit_context_menu_item_class_init):

  • UIProcess/API/gtk/WebKitCookieManager.cpp:

(_WebKitCookieManagerPrivate::~_WebKitCookieManagerPrivate):
(_WebKitCookieManagerPrivate):

  • UIProcess/API/gtk/WebKitDownload.cpp:

(webkit_download_class_init):

  • UIProcess/API/gtk/WebKitFaviconDatabase.cpp:

(webkit_favicon_database_class_init):

  • UIProcess/API/gtk/WebKitFileChooserRequest.cpp:

(webkitFileChooserRequestDispose):
(webkit_file_chooser_request_class_init):

  • UIProcess/API/gtk/WebKitFindController.cpp:

(webkit_find_controller_class_init):

  • UIProcess/API/gtk/WebKitFormSubmissionRequest.cpp:

(webkitFormSubmissionRequestDispose):
(webkit_form_submission_request_class_init):

  • UIProcess/API/gtk/WebKitGeolocationPermissionRequest.cpp:

(webkitGeolocationPermissionRequestDispose):
(webkit_geolocation_permission_request_class_init):

  • UIProcess/API/gtk/WebKitHitTestResult.cpp:

(webkit_hit_test_result_class_init):

  • UIProcess/API/gtk/WebKitNavigationPolicyDecision.cpp:

(webkit_navigation_policy_decision_class_init):

  • UIProcess/API/gtk/WebKitPlugin.cpp:

(_WebKitPluginPrivate::~_WebKitPluginPrivate):
(_WebKitPluginPrivate):
(webkit_plugin_class_init):

  • UIProcess/API/gtk/WebKitPolicyDecision.cpp:

(webkitPolicyDecisionDispose):
(webkit_policy_decision_class_init):
(webkit_policy_decision_use):
(webkit_policy_decision_ignore):
(webkit_policy_decision_download):

  • UIProcess/API/gtk/WebKitPrintOperation.cpp:

(_WebKitPrintOperationPrivate::~_WebKitPrintOperationPrivate):
(_WebKitPrintOperationPrivate):
(webkit_print_operation_class_init):

  • UIProcess/API/gtk/WebKitPrivate.h:
  • UIProcess/API/gtk/WebKitResponsePolicyDecision.cpp:

(webkit_response_policy_decision_class_init):

  • UIProcess/API/gtk/WebKitSecurityManager.cpp:

(webkit_security_manager_class_init):

  • UIProcess/API/gtk/WebKitSettings.cpp:

(_WebKitSettingsPrivate::_WebKitSettingsPrivate):
(_WebKitSettingsPrivate):
(webkit_settings_class_init):

  • UIProcess/API/gtk/WebKitURIRequest.cpp:

(webkit_uri_request_class_init):

  • UIProcess/API/gtk/WebKitURIResponse.cpp:

(webkit_uri_response_class_init):

  • UIProcess/API/gtk/WebKitURISchemeRequest.cpp:

(webkit_uri_scheme_request_class_init):

  • UIProcess/API/gtk/WebKitWebContext.cpp:
  • UIProcess/API/gtk/WebKitWebInspector.cpp:

(_WebKitWebInspectorPrivate::~_WebKitWebInspectorPrivate):
(_WebKitWebInspectorPrivate):
(webkit_web_inspector_class_init):

  • UIProcess/API/gtk/WebKitWebResource.cpp:

(webkit_web_resource_class_init):

  • UIProcess/API/gtk/WebKitWebView.cpp:

(_WebKitWebViewPrivate::~_WebKitWebViewPrivate):
(_WebKitWebViewPrivate):
(webkitWebViewConstructed):
(webkitWebViewDispose):
(webkit_web_view_class_init):

  • UIProcess/API/gtk/WebKitWebViewBase.cpp:

(_WebKitWebViewBasePrivate::_WebKitWebViewBasePrivate):
(_WebKitWebViewBasePrivate):
(_WebKitWebViewBasePrivate::~_WebKitWebViewBasePrivate):
(webkitWebViewBaseDispose):
(webkitWebViewBaseConstructed):
(webkit_web_view_base_class_init):

  • UIProcess/API/gtk/WebKitWebViewBaseAccessible.cpp:

(webkit_web_view_base_accessible_class_init):

  • UIProcess/API/gtk/WebKitWindowProperties.cpp:

(webkit_window_properties_class_init):

12:06 AM Changeset in webkit [135564] by commit-queue@webkit.org
  • 14 edits
    3 adds in trunk

Expose DOM interface for CSS Device Adaptation
https://bugs.webkit.org/show_bug.cgi?id=95966

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-11-23
Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

Added V8 and JSC bindings for CSS Device Adapation.

Test: css3/device-adapt/opera/cssom-001.xhtml

  • CMakeLists.txt:
  • DerivedSources.make:
  • DerivedSources.pri:
  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSCSSRuleCustom.cpp:

(WebCore::toJS):

  • bindings/objc/DOMCSS.mm:

(kitClass):

  • bindings/v8/custom/V8CSSRuleCustom.cpp:

(WebCore::wrap):

  • css/CSSRule.idl:
  • css/WebKitCSSViewportRule.idl: Added.
  • page/DOMWindow.idl:

LayoutTests:

Imported a test submitted by Opera that tests the exposed interface.

  • css3/device-adapt/opera/cssom-001-expected.txt: Added.
  • css3/device-adapt/opera/cssom-001.xhtml: Added.
  • platform/efl/fast/js/global-constructors-expected.txt:

Nov 22, 2012:

11:54 PM Changeset in webkit [135563] by yurys@chromium.org
  • 4 edits
    2 deletes in trunk

Unreviewed, rolling out r135549.
http://trac.webkit.org/changeset/135549
https://bugs.webkit.org/show_bug.cgi?id=103102

Multiple layout test crashes (Requested by yurys on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-11-22

Source/WebCore:

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::layout):

  • rendering/RenderTable.h:

(RenderTable):

LayoutTests:

  • fast/table/css-table-max-height-expected.txt: Removed.
  • fast/table/css-table-max-height.html: Removed.
11:44 PM Changeset in webkit [135562] by commit-queue@webkit.org
  • 8 edits in trunk

window is missing Touch and TouchList - touch event conformance test failure
https://bugs.webkit.org/show_bug.cgi?id=96295

Patch by Rick Byers <rbyers@chromium.org> on 2012-11-22
Reviewed by Adam Barth.

Source/WebCore:

Add Touch and TouchList constructors to window for ENABLE(TOUCH_EVENTS).

Tests: fast/js/global-constructors.html

fast/events/touch/document-create-touch-list.html

  • page/DOMWindow.idl:

LayoutTests:

  • fast/events/touch/document-create-touch-list-expected.txt:
  • fast/events/touch/script-tests/document-create-touch-list.js: Add instanceof checks
  • platform/efl/fast/js/global-constructors-expected.txt: Add new expected constructors
  • platform/qt-5.0/fast/js/global-constructors-expected.txt: Add new expected constructors
  • platform/qt/fast/js/global-constructors-expected.txt: Add new expected constructors
11:35 PM Changeset in webkit [135561] by yurys@chromium.org
  • 45 edits
    3 copies
    24 moves
    77 adds
    2 deletes in trunk/LayoutTests

Unreviewed. Test expectations update after Skia changes.

  • fast/repaint/line-flow-with-floats-in-regions-expected.png: Renamed from LayoutTests/platform/efl/fast/repaint/line-flow-with-floats-in-regions-expected.png.
  • platform/chromium-linux-x86/fast/images/imagemap-circle-focus-ring-expected.txt: Added.
  • platform/chromium-linux-x86/fast/images/imagemap-focus-ring-outline-color-expected.txt: Added.
  • platform/chromium-linux-x86/fast/images/imagemap-focus-ring-outline-color-explicitly-inherited-from-map-expected.txt: Added.
  • platform/chromium-linux-x86/fast/images/imagemap-focus-ring-outline-color-not-inherited-from-map-expected.txt: Added.
  • platform/chromium-linux-x86/fast/images/imagemap-polygon-focus-ring-expected.txt: Added.
  • platform/chromium-linux-x86/platform/chromium/virtual/deferred/fast/images/imagemap-circle-focus-ring-expected.txt: Added.
  • platform/chromium-linux-x86/platform/chromium/virtual/deferred/fast/images/imagemap-focus-ring-outline-color-expected.txt: Added.
  • platform/chromium-linux-x86/platform/chromium/virtual/deferred/fast/images/imagemap-focus-ring-outline-color-explicitly-inherited-from-map-expected.txt: Added.
  • platform/chromium-linux-x86/platform/chromium/virtual/deferred/fast/images/imagemap-focus-ring-outline-color-not-inherited-from-map-expected.txt: Added.
  • platform/chromium-linux-x86/platform/chromium/virtual/deferred/fast/images/imagemap-polygon-focus-ring-expected.txt: Added.
  • platform/chromium-linux/fast/css/color-correction-expected.png: Added.
  • platform/chromium-linux/fast/css/color-correction-on-background-image-expected.png: Added.
  • platform/chromium-linux/fast/css/color-correction-on-backgrounds-expected.png: Added.
  • platform/chromium-linux/fast/css/color-correction-on-box-shadow-expected.png: Added.
  • platform/chromium-linux/fast/css/color-correction-on-text-expected.png: Added.
  • platform/chromium-linux/fast/css/color-correction-on-text-shadow-expected.png: Added.
  • platform/chromium-linux/fast/css/color-correction-untagged-images-expected.png: Added.
  • platform/chromium-linux/fast/css/font-smoothing-expected.png: Added.
  • platform/chromium-linux/fast/history/visited-link-background-color-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/history/visited-link-background-color-expected.png.
  • platform/chromium-linux/fast/images/imagemap-circle-focus-ring-expected.png: Added.
  • platform/chromium-linux/fast/images/imagemap-circle-focus-ring-expected.txt: Added.
  • platform/chromium-linux/fast/images/imagemap-focus-ring-outline-color-expected.png: Added.
  • platform/chromium-linux/fast/images/imagemap-focus-ring-outline-color-expected.txt: Added.
  • platform/chromium-linux/fast/images/imagemap-focus-ring-outline-color-explicitly-inherited-from-map-expected.png: Added.
  • platform/chromium-linux/fast/images/imagemap-focus-ring-outline-color-explicitly-inherited-from-map-expected.txt: Added.
  • platform/chromium-linux/fast/images/imagemap-focus-ring-outline-color-not-inherited-from-map-expected.png: Added.
  • platform/chromium-linux/fast/images/imagemap-focus-ring-outline-color-not-inherited-from-map-expected.txt: Added.
  • platform/chromium-linux/fast/images/imagemap-polygon-focus-ring-expected.png: Added.
  • platform/chromium-linux/fast/images/imagemap-polygon-focus-ring-expected.txt: Added.
  • platform/chromium-linux/fast/text/atsui-pointtooffset-calls-cg-expected.png: Added.
  • platform/chromium-linux/fast/text/atsui-rtl-override-selection-expected.png: Added.
  • platform/chromium-linux/fast/text/line-initial-and-final-swashes-expected.png: Added.
  • platform/chromium-linux/fast/text/midword-break-before-surrogate-pair-2-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/text/midword-break-before-surrogate-pair-2-expected.png.
  • platform/chromium-linux/platform/chromium/virtual/deferred/fast/images/imagemap-circle-focus-ring-expected.png: Added.
  • platform/chromium-linux/platform/chromium/virtual/deferred/fast/images/imagemap-circle-focus-ring-expected.txt: Added.
  • platform/chromium-linux/platform/chromium/virtual/deferred/fast/images/imagemap-focus-ring-outline-color-expected.png: Added.
  • platform/chromium-linux/platform/chromium/virtual/deferred/fast/images/imagemap-focus-ring-outline-color-expected.txt: Added.
  • platform/chromium-linux/platform/chromium/virtual/deferred/fast/images/imagemap-focus-ring-outline-color-explicitly-inherited-from-map-expected.png: Added.
  • platform/chromium-linux/platform/chromium/virtual/deferred/fast/images/imagemap-focus-ring-outline-color-explicitly-inherited-from-map-expected.txt: Added.
  • platform/chromium-linux/platform/chromium/virtual/deferred/fast/images/imagemap-focus-ring-outline-color-not-inherited-from-map-expected.png: Added.
  • platform/chromium-linux/platform/chromium/virtual/deferred/fast/images/imagemap-focus-ring-outline-color-not-inherited-from-map-expected.txt: Added.
  • platform/chromium-linux/platform/chromium/virtual/deferred/fast/images/imagemap-polygon-focus-ring-expected.png: Added.
  • platform/chromium-linux/platform/chromium/virtual/deferred/fast/images/imagemap-polygon-focus-ring-expected.txt: Added.
  • platform/chromium-linux/platform/chromium/virtual/deferred/fast/images/object-image-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/text/midword-break-before-surrogate-pair-2-expected.png.
  • platform/chromium-mac-lion/fast/repaint/line-flow-with-floats-in-regions-expected.png:
  • platform/chromium-mac-lion/svg/batik/filters/filterRegions-expected.png:
  • platform/chromium-mac-lion/svg/batik/paints/gradientLimit-expected.png:
  • platform/chromium-mac-lion/svg/batik/text/smallFonts-expected.png:
  • platform/chromium-mac-lion/svg/batik/text/textDecoration-expected.png:
  • platform/chromium-mac-lion/svg/batik/text/textEffect-expected.png:
  • platform/chromium-mac-lion/svg/batik/text/textEffect2-expected.png:
  • platform/chromium-mac-lion/svg/batik/text/textFeatures-expected.png:
  • platform/chromium-mac-lion/svg/batik/text/textLayout-expected.png:
  • platform/chromium-mac-lion/svg/batik/text/textLayout2-expected.png:
  • platform/chromium-mac-lion/svg/batik/text/textProperties2-expected.png:
  • platform/chromium-mac-snowleopard/fast/repaint/line-flow-with-floats-in-regions-expected.png:
  • platform/chromium-mac-snowleopard/svg/batik/filters/filterRegions-expected.png:
  • platform/chromium-mac-snowleopard/svg/batik/paints/gradientLimit-expected.png:
  • platform/chromium-mac-snowleopard/svg/batik/text/smallFonts-expected.png:
  • platform/chromium-mac-snowleopard/svg/batik/text/textDecoration-expected.png:
  • platform/chromium-mac-snowleopard/svg/batik/text/textEffect-expected.png:
  • platform/chromium-mac-snowleopard/svg/batik/text/textEffect2-expected.png:
  • platform/chromium-mac-snowleopard/svg/batik/text/textFeatures-expected.png:
  • platform/chromium-mac-snowleopard/svg/batik/text/textLayout-expected.png:
  • platform/chromium-mac-snowleopard/svg/batik/text/textLayout2-expected.png:
  • platform/chromium-mac-snowleopard/svg/batik/text/textProperties2-expected.png:
  • platform/chromium-mac/fast/repaint/line-flow-with-floats-in-regions-expected.png:
  • platform/chromium-mac/svg/batik/filters/filterRegions-expected.png:
  • platform/chromium-mac/svg/batik/paints/gradientLimit-expected.png:
  • platform/chromium-mac/svg/batik/text/smallFonts-expected.png:
  • platform/chromium-mac/svg/batik/text/textDecoration-expected.png:
  • platform/chromium-mac/svg/batik/text/textEffect-expected.png:
  • platform/chromium-mac/svg/batik/text/textEffect2-expected.png:
  • platform/chromium-mac/svg/batik/text/textFeatures-expected.png:
  • platform/chromium-mac/svg/batik/text/textLayout-expected.png:
  • platform/chromium-mac/svg/batik/text/textLayout2-expected.png:
  • platform/chromium-mac/svg/batik/text/textProperties2-expected.png:
  • platform/chromium-win-xp/fast/images/imagemap-circle-focus-ring-expected.txt: Added.
  • platform/chromium-win-xp/fast/images/imagemap-focus-ring-outline-color-expected.txt: Added.
  • platform/chromium-win-xp/fast/images/imagemap-focus-ring-outline-color-explicitly-inherited-from-map-expected.txt: Added.
  • platform/chromium-win-xp/fast/images/imagemap-focus-ring-outline-color-not-inherited-from-map-expected.txt: Added.
  • platform/chromium-win-xp/fast/images/imagemap-polygon-focus-ring-expected.txt: Added.
  • platform/chromium-win-xp/platform/chromium/virtual/deferred/fast/images/imagemap-circle-focus-ring-expected.txt: Added.
  • platform/chromium-win-xp/platform/chromium/virtual/deferred/fast/images/imagemap-focus-ring-outline-color-expected.txt: Added.
  • platform/chromium-win-xp/platform/chromium/virtual/deferred/fast/images/imagemap-focus-ring-outline-color-explicitly-inherited-from-map-expected.txt: Added.
  • platform/chromium-win-xp/platform/chromium/virtual/deferred/fast/images/imagemap-focus-ring-outline-color-not-inherited-from-map-expected.txt: Added.
  • platform/chromium-win-xp/platform/chromium/virtual/deferred/fast/images/imagemap-polygon-focus-ring-expected.txt: Added.
  • platform/chromium-win/fast/images/imagemap-circle-focus-ring-expected.png: Added.
  • platform/chromium-win/fast/images/imagemap-focus-ring-outline-color-expected.png: Added.
  • platform/chromium-win/fast/images/imagemap-focus-ring-outline-color-explicitly-inherited-from-map-expected.png: Added.
  • platform/chromium-win/fast/images/imagemap-focus-ring-outline-color-not-inherited-from-map-expected.png: Added.
  • platform/chromium-win/fast/images/imagemap-polygon-focus-ring-expected.png: Added.
  • platform/chromium-win/fast/repaint/line-flow-with-floats-in-regions-expected.png: Added.
  • platform/chromium-win/fast/text/line-initial-and-final-swashes-expected.png: Added.
  • platform/chromium-win/platform/chromium/virtual/deferred/fast/images/imagemap-circle-focus-ring-expected.png: Added.
  • platform/chromium-win/platform/chromium/virtual/deferred/fast/images/imagemap-focus-ring-outline-color-expected.png: Added.
  • platform/chromium-win/platform/chromium/virtual/deferred/fast/images/imagemap-focus-ring-outline-color-explicitly-inherited-from-map-expected.png: Added.
  • platform/chromium-win/platform/chromium/virtual/deferred/fast/images/imagemap-focus-ring-outline-color-not-inherited-from-map-expected.png: Added.
  • platform/chromium-win/platform/chromium/virtual/deferred/fast/images/imagemap-polygon-focus-ring-expected.png: Added.
  • platform/chromium-win/svg/batik/filters/filterRegions-expected.png:
  • platform/chromium-win/svg/batik/paints/gradientLimit-expected.png:
  • platform/chromium-win/svg/batik/text/smallFonts-expected.png:
  • platform/chromium-win/svg/batik/text/textDecoration-expected.png:
  • platform/chromium-win/svg/batik/text/textEffect-expected.png:
  • platform/chromium-win/svg/batik/text/textEffect2-expected.png:
  • platform/chromium-win/svg/batik/text/textFeatures-expected.png:
  • platform/chromium-win/svg/batik/text/textLayout-expected.png:
  • platform/chromium-win/svg/batik/text/textLayout2-expected.png:
  • platform/chromium-win/svg/batik/text/textProperties2-expected.png:
  • platform/chromium/TestExpectations:
  • platform/chromium/fast/history/visited-link-background-color-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/history/visited-link-background-color-expected.png.
  • platform/chromium/fast/repaint/line-flow-with-floats-in-regions-expected.png: Removed.
  • platform/chromium/fast/text/midword-break-before-surrogate-pair-2-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/text/midword-break-before-surrogate-pair-2-expected.png.
  • platform/efl-wk1/fast/css/font-smoothing-expected.png: Renamed from LayoutTests/platform/efl/fast/css/font-smoothing-expected.png.
  • platform/efl-wk1/fast/history/visited-link-background-color-expected.png: Renamed from LayoutTests/platform/efl/fast/history/visited-link-background-color-expected.png.
  • platform/efl-wk1/fast/images/imagemap-circle-focus-ring-expected.png: Renamed from LayoutTests/platform/efl/fast/images/imagemap-circle-focus-ring-expected.png.
  • platform/efl-wk1/fast/images/imagemap-focus-ring-outline-color-expected.png: Renamed from LayoutTests/platform/efl/fast/images/imagemap-focus-ring-outline-color-expected.png.
  • platform/efl-wk1/fast/images/imagemap-focus-ring-outline-color-explicitly-inherited-from-map-expected.png: Renamed from LayoutTests/platform/efl/fast/images/imagemap-focus-ring-outline-color-explicitly-inherited-from-map-expected.png.
  • platform/efl-wk1/fast/images/imagemap-focus-ring-outline-color-not-inherited-from-map-expected.png: Renamed from LayoutTests/platform/efl/fast/images/imagemap-focus-ring-outline-color-not-inherited-from-map-expected.png.
  • platform/efl-wk1/fast/images/imagemap-polygon-focus-ring-expected.png: Renamed from LayoutTests/platform/efl/fast/images/imagemap-polygon-focus-ring-expected.png.
  • platform/efl-wk1/fast/text/atsui-pointtooffset-calls-cg-expected.png: Renamed from LayoutTests/platform/efl/fast/text/atsui-pointtooffset-calls-cg-expected.png.
  • platform/efl-wk1/fast/text/atsui-rtl-override-selection-expected.png: Renamed from LayoutTests/platform/efl/fast/text/atsui-rtl-override-selection-expected.png.
  • platform/efl-wk1/fast/text/line-initial-and-final-swashes-expected.png: Renamed from LayoutTests/platform/efl/fast/text/line-initial-and-final-swashes-expected.png.
  • platform/efl-wk1/fast/text/line-initial-and-final-swashes-expected.txt: Renamed from LayoutTests/platform/efl/fast/text/line-initial-and-final-swashes-expected.txt.
  • platform/efl-wk1/fast/text/midword-break-before-surrogate-pair-2-expected.png: Renamed from LayoutTests/platform/efl/fast/text/midword-break-before-surrogate-pair-2-expected.png.
  • platform/efl-wk1/svg/batik/filters/filterRegions-expected.png: Renamed from LayoutTests/platform/efl/svg/batik/filters/filterRegions-expected.png.
  • platform/efl-wk1/svg/batik/text/smallFonts-expected.png: Renamed from LayoutTests/platform/efl/svg/batik/text/smallFonts-expected.png.
  • platform/efl-wk1/svg/batik/text/textDecoration-expected.png: Renamed from LayoutTests/platform/efl/svg/batik/text/textDecoration-expected.png.
  • platform/efl-wk1/svg/batik/text/textEffect-expected.png: Renamed from LayoutTests/platform/efl/svg/batik/text/textEffect-expected.png.
  • platform/efl-wk1/svg/batik/text/textEffect2-expected.png: Renamed from LayoutTests/platform/efl/svg/batik/text/textEffect2-expected.png.
  • platform/efl-wk1/svg/batik/text/textFeatures-expected.png: Renamed from LayoutTests/platform/efl/svg/batik/text/textFeatures-expected.png.
  • platform/efl-wk1/svg/batik/text/textLayout-expected.png: Renamed from LayoutTests/platform/efl/svg/batik/text/textLayout-expected.png.
  • platform/efl-wk1/svg/batik/text/textLayout2-expected.png: Renamed from LayoutTests/platform/efl/svg/batik/text/textLayout2-expected.png.
  • platform/efl-wk1/svg/batik/text/textProperties2-expected.png: Renamed from LayoutTests/platform/efl/svg/batik/text/textProperties2-expected.png.
  • platform/gtk/fast/repaint/line-flow-with-floats-in-regions-expected.png: Removed.
11:32 PM Changeset in webkit [135560] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[V8] Make worker context prototype chain match other browsers
https://bugs.webkit.org/show_bug.cgi?id=103057

Patch by Dan Carney <dcarney@google.com> on 2012-11-22
Reviewed by Adam Barth.

The following should be defined in a worker:
Object.getOwnPropertyDescriptor(this.proto, "postMessage")
It is currently undefined in chrome only. This patch fixes that.

No new tests. No change in functionality.

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateImplementation):

11:08 PM WebKitGTK/WebKit2Roadmap edited by Carlos Garcia Campos
Update target versions after release (diff)
10:39 PM Changeset in webkit [135559] by commit-queue@webkit.org
  • 7 edits
    4 adds
    2 deletes in trunk/Source/WebKit

[BlackBerry] Update Web Notifications Implementation
https://bugs.webkit.org/show_bug.cgi?id=102621

Patch by Jeff Rogers <jrogers@rim.com> on 2012-11-22
Reviewed by George Staikos.

Source/WebKit:

Reviewed internally by George Staikos and Joe Mason.
Internal PR 172120
Add new Notification files and remove obsolete ones.

  • PlatformBlackBerry.cmake:

Source/WebKit/blackberry:

Reviewed internally by George Staikos and Joe Mason
Internal PR 172120
Add new notifications implementation for the BlackBerry port. Rename
existing class to match Client naming. Adds NotificationManager
implementation for managing notifications and permissions, and logic
for passing the notifications to the platform provider.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
(BlackBerry::WebKit::WebPagePrivate::init):
(BlackBerry::WebKit::WebPage::updateNotificationPermission):
(WebKit):
(BlackBerry::WebKit::WebPage::notificationClicked):
(BlackBerry::WebKit::WebPage::notificationClosed):
(BlackBerry::WebKit::WebPage::notificationError):
(BlackBerry::WebKit::WebPage::notificationShown):

  • Api/WebPage.h:
  • Api/WebPageClient.h:
  • Api/WebPage_p.h:

(WebPagePrivate):
(BlackBerry::WebKit::WebPagePrivate::notificationManager):

  • WebCoreSupport/NotificationClientBlackBerry.cpp: Added.

(WebCore):
(WebCore::NotificationClientBlackBerry::NotificationClientBlackBerry):
(WebCore::NotificationClientBlackBerry::show):
(WebCore::NotificationClientBlackBerry::cancel):
(WebCore::NotificationClientBlackBerry::clearNotifications):
(WebCore::NotificationClientBlackBerry::notificationObjectDestroyed):
(WebCore::NotificationClientBlackBerry::notificationControllerDestroyed):
(WebCore::NotificationClientBlackBerry::requestPermission):
(WebCore::NotificationClientBlackBerry::cancelRequestsForPermission):
(WebCore::NotificationClientBlackBerry::checkPermission):

  • WebCoreSupport/NotificationClientBlackBerry.h: Added.

(WebKit):
(WebCore):
(NotificationClientBlackBerry):

  • WebCoreSupport/NotificationPresenterImpl.cpp: Removed.
  • WebCoreSupport/NotificationPresenterImpl.h: Removed.
  • WebKitSupport/NotificationManager.cpp: Added.

(WebKit):
(BlackBerry::WebKit::NotificationManager::NotificationManager):
(BlackBerry::WebKit::NotificationManager::~NotificationManager):
(BlackBerry::WebKit::NotificationManager::show):
(BlackBerry::WebKit::NotificationManager::cancel):
(BlackBerry::WebKit::NotificationManager::clearNotifications):
(BlackBerry::WebKit::NotificationManager::notificationObjectDestroyed):
(BlackBerry::WebKit::NotificationManager::requestPermission):
(BlackBerry::WebKit::NotificationManager::cancelRequestsForPermission):
(BlackBerry::WebKit::NotificationManager::checkPermission):
(BlackBerry::WebKit::NotificationManager::updatePermission):
(BlackBerry::WebKit::NotificationManager::notificationClicked):
(BlackBerry::WebKit::NotificationManager::notificationClosed):
(BlackBerry::WebKit::NotificationManager::notificationError):
(BlackBerry::WebKit::NotificationManager::notificationShown):
(BlackBerry::WebKit::NotificationManager::removeNotificationFromContextMap):

  • WebKitSupport/NotificationManager.h: Added.

(WebKit):
(NotificationManager):

10:07 PM Changeset in webkit [135558] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled DEPS.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-11-22

  • DEPS:
9:36 PM Changeset in webkit [135557] by rafael.lobo@openbossa.org
  • 2 edits in trunk/Source/WebCore

Remove PLATFORM(HAIKU) leftovers code
https://bugs.webkit.org/show_bug.cgi?id=103086

Reviewed by Antti Koivisto.

  • platform/PlatformWheelEvent.h:

(PlatformWheelEvent):

9:08 PM Changeset in webkit [135556] by krit@webkit.org
  • 3 edits
    2 adds in trunk

-webkit-mask shorthand switches -webkit-mask-clip and -webkit-mask-origin values
https://bugs.webkit.org/show_bug.cgi?id=103083

Reviewed by Antti Koivisto.

Source/WebCore:

The order of CSSPropertyWebkitMaskOrigin and CSSPropertyWebkitMaskClip was not correct
for property value. Just changed the order in the property array to match behavior of
background and CSS Masking spec.

Test: fast/masking/parsing-mask.html

  • css/StylePropertyShorthand.cpp:

(WebCore::webkitMaskShorthand):

LayoutTests:

Add parser tests for -webkit-mask property.

  • fast/masking/parsing-mask-expected.txt: Added.
  • fast/masking/parsing-mask.html: Added.
8:54 PM Changeset in webkit [135555] by commit-queue@webkit.org
  • 3 edits in trunk/Source/JavaScriptCore

Fix the MIPS build after r135330
https://bugs.webkit.org/show_bug.cgi?id=102872

Patch by Balazs Kilvady <kilvadyb@homejinni.com> on 2012-11-22
Reviewed by Gavin Barraclough.

Revert/replace functions added to MIPS port.

  • assembler/MIPSAssembler.h:

(JSC::MIPSAssembler::revertJumpToMove):
(MIPSAssembler):
(JSC::MIPSAssembler::replaceWithJump):

  • assembler/MacroAssemblerMIPS.h:

(MacroAssemblerMIPS):
(JSC::MacroAssemblerMIPS::startOfBranchPtrWithPatchOnRegister):
(JSC::MacroAssemblerMIPS::revertJumpReplacementToBranchPtrWithPatch):
(JSC::MacroAssemblerMIPS::startOfPatchableBranchPtrWithPatchOnAddress):

7:31 PM Changeset in webkit [135554] by mifenton@rim.com
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Guard against a lost focusedNode that input handler isn't yet informed of.
https://bugs.webkit.org/show_bug.cgi?id=103071

Reviewed by Rob Buis.

Fix potential for a crash if input mode is active but
we can't get a focusedNode.

Reviewed Internally by Gen Mak.

  • WebKitSupport/SelectionHandler.cpp:

(BlackBerry::WebKit::SelectionHandler::setCaretPosition):

6:54 PM Changeset in webkit [135553] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

Text Autosizing: Improve handling of nested comments on reddit.com
https://bugs.webkit.org/show_bug.cgi?id=102409

Patch by John Mellor <johnme@chromium.org> on 2012-11-22
Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

No longer consider overflow != visible as requiring an independent
cluster. Some sites (e.g. reddit.com) wrap ordinary blocks (such as
comments) in overflow:hidden or overflow:auto, for various reasons
(like allowing it to be scrollable, or clipping an element that sticks
out). These reasons are not sufficient justification for a new cluster.

On reddit.com this means that comments will all get the same multiplier,
rather than being independently assigned a variety of multipliers based
on how much text each comment contains (etc), which significantly
improves the look.

Test: fast/text-autosizing/cluster-narrow-in-wide-ohidden.html

  • rendering/TextAutosizer.cpp:

(WebCore::TextAutosizer::isAutosizingCluster):

LayoutTests:

Added test to confirm that overflow:hidden no longer triggers a cluster.

  • fast/text-autosizing/cluster-narrow-in-wide-ohidden-expected.html: Added.
  • fast/text-autosizing/cluster-narrow-in-wide-ohidden.html: Added.
6:38 PM Changeset in webkit [135552] by peter@chromium.org
  • 4 edits in trunk/Tools

[Chromium] Return an accurate exit code when running Android suites, and wait after restarting adb as root
https://bugs.webkit.org/show_bug.cgi?id=103065

Reviewed by Dirk Pranke.

This addresses two further reliability issues in the Android test running
scripts. Firstly, the run_tests.py script needs to have the --exit_code
argument passed in order to return non-zero codes, which we need for the
build master to distinguish failures from successful runs.

Secondly, it modifies the layout test runner to briefly wait (through
the wait-for-device command) after requesting a device to switch to root
mode. Without this waiting period, commands might get lost and thereby
unexpectedly fail.

  • Scripts/run-api-tests:
  • Scripts/run-chromium-webkit-unit-tests:
  • Scripts/webkitpy/layout_tests/port/chromium_android.py:

(ChromiumAndroidDriver._setup_test):
(ChromiumAndroidDriver._restart_adb_as_root):

5:53 PM Changeset in webkit [135551] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[EFL][WK2] Buildfix when ENABLE_NETSCAPE_PLUGIN_API is disabled
https://bugs.webkit.org/show_bug.cgi?id=103044

Patch by KwangYong Choi <ky0.choi@samsung.com> on 2012-11-22
Reviewed by Kentaro Hara.

enum ProcessType has PluginProcess only if ENABLE(PLUGIN_PROCESS) is enabled.
So, guard PluginProcess with ENABLE(PLUGIN_PROCESS).

  • UIProcess/Launcher/efl/ProcessLauncherEfl.cpp:

(WebKit::ProcessLauncher::launchProcess):

4:46 PM Changeset in webkit [135550] by schenney@chromium.org
  • 11 edits
    101 adds
    23 deletes in trunk/LayoutTests

Test expectations update after enabling Skia changes.

Unreviewed expectations update.

Final rebaselines. These tests did not get correctly rebased the first time through.

  • fast/replaced/border-radius-clip-expected.png: Added.
  • fast/text/line-initial-and-final-swashes-expected.txt: Added.
  • platform/chromium-linux-x86/fast/replaced/border-radius-clip-expected.txt: Added.
  • platform/chromium-linux/fast/replaced/border-radius-clip-expected.png:
  • platform/chromium-linux/fast/replaced/border-radius-clip-expected.txt: Added.
  • platform/chromium-linux/transforms/3d/hit-testing/backface-hit-test-expected.png:
  • platform/chromium-linux/transforms/3d/hit-testing/backface-no-transform-hit-test-expected.png:
  • platform/chromium-mac-lion/fast/block/basic/fieldset-stretch-to-legend-expected.png: Added.
  • platform/chromium-mac-lion/fast/css/color-correction-expected.txt: Added.
  • platform/chromium-mac-lion/fast/css/color-correction-on-background-image-expected.txt: Added.
  • platform/chromium-mac-lion/fast/css/color-correction-on-backgrounds-expected.txt: Added.
  • platform/chromium-mac-lion/fast/css/color-correction-on-box-shadow-expected.png: Added.
  • platform/chromium-mac-lion/fast/css/color-correction-on-box-shadow-expected.txt: Added.
  • platform/chromium-mac-lion/fast/css/color-correction-on-text-expected.txt: Added.
  • platform/chromium-mac-lion/fast/css/color-correction-on-text-shadow-expected.png: Added.
  • platform/chromium-mac-lion/fast/css/color-correction-on-text-shadow-expected.txt: Added.
  • platform/chromium-mac-lion/fast/css/color-correction-untagged-images-expected.txt: Added.
  • platform/chromium-mac-lion/fast/css/font-smoothing-expected.txt: Added.
  • platform/chromium-mac-lion/fast/images/imagemap-circle-focus-ring-expected.txt: Added.
  • platform/chromium-mac-lion/fast/images/imagemap-focus-ring-outline-color-expected.txt: Added.
  • platform/chromium-mac-lion/fast/images/imagemap-focus-ring-outline-color-explicitly-inherited-from-map-expected.txt: Added.
  • platform/chromium-mac-lion/fast/images/imagemap-focus-ring-outline-color-not-inherited-from-map-expected.txt: Added.
  • platform/chromium-mac-lion/fast/images/imagemap-polygon-focus-ring-expected.txt: Added.
  • platform/chromium-mac-lion/fast/images/object-image-expected.png: Added.
  • platform/chromium-mac-lion/fast/repaint/body-background-image-expected.png: Added.
  • platform/chromium-mac-lion/fast/repaint/body-background-image-expected.txt: Added.
  • platform/chromium-mac-lion/fast/repaint/overflow-outline-repaint-expected.txt: Added.
  • platform/chromium-mac-lion/fast/text/atsui-pointtooffset-calls-cg-expected.txt: Added.
  • platform/chromium-mac-lion/fast/text/atsui-rtl-override-selection-expected.txt: Added.
  • platform/chromium-mac-lion/fast/text/font-initial-expected.png: Added.
  • platform/chromium-mac-lion/fast/text/font-initial-expected.txt: Added.
  • platform/chromium-mac-lion/fast/text/line-initial-and-final-swashes-expected.png: Added.
  • platform/chromium-mac-lion/platform/chromium/virtual/deferred/fast/images/object-image-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/block/basic/fieldset-stretch-to-legend-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/css/color-correction-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/css/color-correction-on-background-image-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/css/color-correction-on-backgrounds-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/css/color-correction-on-box-shadow-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/css/color-correction-on-box-shadow-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/css/color-correction-on-text-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/css/color-correction-on-text-shadow-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/css/color-correction-on-text-shadow-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/css/color-correction-untagged-images-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/css/font-smoothing-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/images/imagemap-circle-focus-ring-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/images/imagemap-focus-ring-outline-color-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/images/imagemap-focus-ring-outline-color-explicitly-inherited-from-map-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/images/imagemap-focus-ring-outline-color-not-inherited-from-map-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/images/imagemap-polygon-focus-ring-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/repaint/body-background-image-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/repaint/body-background-image-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/repaint/overflow-outline-repaint-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/text/atsui-pointtooffset-calls-cg-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/text/atsui-rtl-override-selection-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/text/font-initial-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/text/font-initial-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/text/line-initial-and-final-swashes-expected.png: Added.
  • platform/chromium-mac/fast/block/basic/fieldset-stretch-to-legend-expected.png:
  • platform/chromium-mac/fast/css/color-correction-expected.txt: Added.
  • platform/chromium-mac/fast/css/color-correction-on-background-image-expected.txt: Added.
  • platform/chromium-mac/fast/css/color-correction-on-backgrounds-expected.txt: Added.
  • platform/chromium-mac/fast/css/color-correction-on-box-shadow-expected.png: Added.
  • platform/chromium-mac/fast/css/color-correction-on-box-shadow-expected.txt: Added.
  • platform/chromium-mac/fast/css/color-correction-on-text-expected.txt: Added.
  • platform/chromium-mac/fast/css/color-correction-on-text-shadow-expected.png: Added.
  • platform/chromium-mac/fast/css/color-correction-on-text-shadow-expected.txt: Added.
  • platform/chromium-mac/fast/css/color-correction-untagged-images-expected.txt: Added.
  • platform/chromium-mac/fast/css/font-smoothing-expected.txt: Added.
  • platform/chromium-mac/fast/history/visited-link-background-color-expected.png: Added.
  • platform/chromium-mac/fast/images/imagemap-circle-focus-ring-expected.txt: Added.
  • platform/chromium-mac/fast/images/imagemap-focus-ring-outline-color-expected.txt: Added.
  • platform/chromium-mac/fast/images/imagemap-focus-ring-outline-color-explicitly-inherited-from-map-expected.txt: Added.
  • platform/chromium-mac/fast/images/imagemap-focus-ring-outline-color-not-inherited-from-map-expected.txt: Added.
  • platform/chromium-mac/fast/images/imagemap-polygon-focus-ring-expected.txt: Added.
  • platform/chromium-mac/fast/images/object-image-expected.png: Added.
  • platform/chromium-mac/fast/repaint/body-background-image-expected.png: Added.
  • platform/chromium-mac/fast/repaint/body-background-image-expected.txt: Added.
  • platform/chromium-mac/fast/repaint/overflow-outline-repaint-expected.txt: Added.
  • platform/chromium-mac/fast/text/atsui-pointtooffset-calls-cg-expected.txt: Added.
  • platform/chromium-mac/fast/text/atsui-rtl-override-selection-expected.txt: Added.
  • platform/chromium-mac/fast/text/font-initial-expected.png: Added.
  • platform/chromium-mac/fast/text/font-initial-expected.txt: Added.
  • platform/chromium-mac/fast/text/line-initial-and-final-swashes-expected.png: Added.
  • platform/chromium-mac/fast/text/midword-break-before-surrogate-pair-2-expected.png: Added.
  • platform/chromium-mac/platform/chromium/virtual/deferred/fast/images/imagemap-circle-focus-ring-expected.txt: Added.
  • platform/chromium-mac/platform/chromium/virtual/deferred/fast/images/imagemap-focus-ring-outline-color-expected.txt: Added.
  • platform/chromium-mac/platform/chromium/virtual/deferred/fast/images/imagemap-focus-ring-outline-color-explicitly-inherited-from-map-expected.txt: Added.
  • platform/chromium-mac/platform/chromium/virtual/deferred/fast/images/imagemap-focus-ring-outline-color-not-inherited-from-map-expected.txt: Added.
  • platform/chromium-mac/platform/chromium/virtual/deferred/fast/images/imagemap-polygon-focus-ring-expected.txt: Added.
  • platform/chromium-mac/platform/chromium/virtual/deferred/fast/images/object-image-expected.png: Added.
  • platform/chromium-win-xp/fast/replaced/border-radius-clip-expected.txt: Added.
  • platform/chromium-win/fast/block/basic/fieldset-stretch-to-legend-expected.png:
  • platform/chromium-win/fast/css/color-correction-expected.png: Added.
  • platform/chromium-win/fast/css/color-correction-on-background-image-expected.png: Added.
  • platform/chromium-win/fast/css/color-correction-on-backgrounds-expected.png: Added.
  • platform/chromium-win/fast/css/color-correction-on-box-shadow-expected.png: Added.
  • platform/chromium-win/fast/css/color-correction-on-text-expected.png: Added.
  • platform/chromium-win/fast/css/color-correction-on-text-shadow-expected.png: Added.
  • platform/chromium-win/fast/css/color-correction-untagged-images-expected.png: Added.
  • platform/chromium-win/fast/css/font-smoothing-expected.png:
  • platform/chromium-win/fast/history/visited-link-background-color-expected.png: Added.
  • platform/chromium-win/fast/images/object-image-expected.png: Added.
  • platform/chromium-win/fast/repaint/body-background-image-expected.png: Added.
  • platform/chromium-win/fast/replaced/border-radius-clip-expected.png:
  • platform/chromium-win/fast/replaced/border-radius-clip-expected.txt:
  • platform/chromium-win/fast/text/atsui-pointtooffset-calls-cg-expected.png:
  • platform/chromium-win/fast/text/atsui-rtl-override-selection-expected.png:
  • platform/chromium-win/fast/text/font-initial-expected.png: Added.
  • platform/chromium-win/fast/text/line-initial-and-final-swashes-expected.txt: Added.
  • platform/chromium-win/fast/text/midword-break-before-surrogate-pair-2-expected.png: Added.
  • platform/chromium-win/platform/chromium/virtual/deferred/fast/images/object-image-expected.png: Added.
  • platform/chromium/fast/canvas/canvas-scale-strokePath-shadow-expected.txt: Removed.
  • platform/chromium/fast/css/color-correction-expected.png: Removed.
  • platform/chromium/fast/css/color-correction-on-background-image-expected.png: Removed.
  • platform/chromium/fast/css/color-correction-on-backgrounds-expected.png: Removed.
  • platform/chromium/fast/css/color-correction-on-box-shadow-expected.png: Removed.
  • platform/chromium/fast/css/color-correction-on-text-expected.png: Removed.
  • platform/chromium/fast/css/color-correction-on-text-shadow-expected.png: Removed.
  • platform/chromium/fast/css/color-correction-untagged-images-expected.png: Removed.
  • platform/chromium/fast/history/visited-link-background-color-expected.png: Removed.
  • platform/chromium/fast/images/imagemap-circle-focus-ring-expected.png: Removed.
  • platform/chromium/fast/images/imagemap-focus-ring-outline-color-expected.png: Removed.
  • platform/chromium/fast/images/imagemap-focus-ring-outline-color-explicitly-inherited-from-map-expected.png: Removed.
  • platform/chromium/fast/images/imagemap-focus-ring-outline-color-not-inherited-from-map-expected.png: Removed.
  • platform/chromium/fast/images/imagemap-polygon-focus-ring-expected.png: Removed.
  • platform/chromium/fast/images/object-image-expected.png: Removed.
  • platform/chromium/fast/repaint/body-background-image-expected.png: Removed.
  • platform/chromium/fast/replaced/border-radius-clip-expected.png: Removed.
  • platform/chromium/fast/text/font-initial-expected.png: Removed.
  • platform/chromium/fast/text/line-initial-and-final-swashes-expected.png: Removed.
  • platform/chromium/fast/text/line-initial-and-final-swashes-expected.txt: Removed.
  • platform/chromium/fast/text/midword-break-before-surrogate-pair-2-expected.png: Removed.
  • platform/mac/fast/replaced/border-radius-clip-expected.png: Removed.
  • platform/mac/fast/text/line-initial-and-final-swashes-expected.txt: Removed.
3:56 PM Changeset in webkit [135549] by commit-queue@webkit.org
  • 4 edits
    2 adds in trunk

max-height property not respected in case of tables
https://bugs.webkit.org/show_bug.cgi?id=98633

Patch by Pravin D <pravind.2k4@gmail.com> on 2012-11-22
Reviewed by Julien Chaffraix.

Source/WebCore:

The max-height property determines the maximum computed height an element can have. In case of tables
the computed height was not being limited by the max-height property. The current patch fixes the same.

Test: fast/table/css-table-max-height.html

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::convertStyleLogicalHeightToComputedHeight):

Helper function to compute height from the given style height.
This function handles style height of type fixed, percent and viewport percent.
As height of type 'calculated' gets internally resolved to either fixed or percent
there is no special handling required for the same.

(WebCore):
(WebCore::RenderTable::layout):

Logic to compute the logical height of an element such that it does not exceed the max-height value given that
min-width < Content height < max-height, when min-height < max-height.
However max-height value is not respected if either min-height > max-height or Content height > max-height.

  • rendering/RenderTable.h:

(RenderTable):

Function definition for the newly add function convertStyleLogicalHeightToComputedHeight().

LayoutTests:

  • fast/table/css-table-max-height-expected.txt: Added.
  • fast/table/css-table-max-height.html: Added.
3:47 PM Changeset in webkit [135548] by rjkroege@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening: Updated test expectations for MountainLion crash in
media/video-preload.html.
https://bugs.webkit.org/show_bug.cgi?id=103093

  • platform/chromium/TestExpectations:
3:12 PM Changeset in webkit [135547] by haraken@chromium.org
  • 2 edits in trunk/Source/WebCore

Remove 'module' from IDL parser
https://bugs.webkit.org/show_bug.cgi?id=102670

Reviewed by Adam Barth.

The Web IDL spec no longer supports 'module'. We already removed
'module's from WebKit IDL files. So this patch removes 'module'
from the IDL parser.

No tests. No change in behavior.

  • bindings/scripts/IDLParser.pm:

(Parse):
(parseDefinitionOld):

3:02 PM Changeset in webkit [135546] by rjkroege@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviwed gardening. Updated test expectations for failure
in complex-joining-using-gpos.html
https://bugs.webkit.org/show_bug.cgi?id=101377

  • platform/chromium/TestExpectations:
2:55 PM Changeset in webkit [135545] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

[V8] fix DOMWrapperWorld destructor
https://bugs.webkit.org/show_bug.cgi?id=103066

Patch by Dan Carney <dcarney@google.com> on 2012-11-22
Reviewed by Jochen Eisinger.

DOMWrapperWorld had a workaround in place during deletion.
This patch brings it in line with WebKit standards.

No new tests: refactor.

  • bindings/v8/DOMWrapperWorld.cpp:

(WebCore::DOMWrapperWorld::~DOMWrapperWorld):
(WebCore::DOMWrapperWorld::ensureIsolatedWorld):

  • bindings/v8/DOMWrapperWorld.h:

(DOMWrapperWorld):
(WebCore::DOMWrapperWorld::isolatedWorldDOMDataStore):

2:45 PM Changeset in webkit [135544] by Antti Koivisto
  • 4 edits in trunk/Source/WebCore

Remove SVGShadowText class
https://bugs.webkit.org/show_bug.cgi?id=103088

Reviewed by Ryosuke Niwa.

Remove SVGShadowText class and merge the little functionality it has to Text.

  • dom/Text.cpp:

(WebCore):
(WebCore::isSVGShadowText):

Figure out if we are a SVGShadowText from the context.

(WebCore::isSVGText):
(WebCore::Text::createRenderer):
(WebCore::Text::recalcTextStyle):

Factor SVG special case testing to functions.

  • dom/Text.h:

(Text):

Get rid of the now unnecessary willRecalcTextStyle mechanism.

  • svg/SVGTRefElement.cpp:

(WebCore):
(WebCore::SVGTRefElement::updateReferencedText):

2:38 PM Changeset in webkit [135543] by senorblanco@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed gardening. Remove a now-passing test from TestExpectations.

  • platform/chromium/TestExpectations:
2:31 PM Changeset in webkit [135542] by akling@apple.com
  • 2 edits in trunk/Source/WebCore

Style sharing: Remove O(n2) presentation attribute checks that never found anything anyway.
<http://webkit.org/b/103019>

Reviewed by Ojan Vafai.

Rely on the global presentation attribute cache and remove the slow-path code that compares
the full StylePropertySets for attribute-derived style.
There are virtually no cases of logically equivalent presentation attribute styles that don't
already share the same memory address. (Zero hits on Apple and Chromium PLT content.)

  • css/StyleResolver.cpp:

(WebCore::haveIdenticalStyleAffectingAttributes):
(WebCore::StyleResolver::canShareStyleWithElement):

2:30 PM Changeset in webkit [135541] by pfeldman@chromium.org
  • 4 edits in trunk/Source/WebCore

Web Inspector: evaluate on hover regressed with the editor change
https://bugs.webkit.org/show_bug.cgi?id=103063

Reviewed by Vsevolod Vlasov.

We are no longer mutating the editor's dom from outside.

  • inspector/front-end/DOMExtension.js:

(Element.prototype.remove):

  • inspector/front-end/DefaultTextEditor.js:

(WebInspector.DefaultTextEditor.prototype.highlightRangesWithStyleClass):
(WebInspector.DefaultTextEditor.prototype.highlightExpression):
(WebInspector.DefaultTextEditor.prototype.hideHighlightedExpression):

  • inspector/front-end/JavaScriptSourceFrame.js:

(WebInspector.JavaScriptSourceFrame.prototype._getPopoverAnchor):
(WebInspector.JavaScriptSourceFrame.prototype._onHidePopover):
(WebInspector.JavaScriptSourceFrame.prototype._highlightExpression):

2:14 PM Changeset in webkit [135540] by schenney@chromium.org
  • 2931 edits
    33 adds
    25 deletes in trunk/LayoutTests

Test expectations update after enabling Skia changes.

Unreviewed expectations update.

All the SVG tests. We should now be done.

  • To many files to list.
1:35 PM Changeset in webkit [135539] by senorblanco@chromium.org
  • 1 edit
    5 adds in trunk/LayoutTests

[Chromium] Unreviewed gardening. New baselines for test effect-reference-ordering-hw.

  • platform/chromium-linux/css3/filters/effect-reference-ordering-hw-expected.png: Added.
  • platform/chromium-mac/css3/filters/effect-reference-ordering-hw-expected.png: Added.
  • platform/chromium-mac/css3/filters/effect-reference-ordering-hw-expected.txt: Added.
  • platform/chromium-win/css3/filters/effect-reference-ordering-hw-expected.png: Added.
  • platform/chromium-win/css3/filters/effect-reference-ordering-hw-expected.txt: Added.
1:07 PM Changeset in webkit [135538] by kov@webkit.org
  • 9 edits in trunk

[GTK] Split SVG from WebCore to work-around make limitation
https://bugs.webkit.org/show_bug.cgi?id=97735

Reviewed by Carlos Garcia Campos.

Add a new libtool convenience library, libWebCoreSVG.la, to work-around
make limitation when linking libWebCore.

.:

  • GNUmakefile.am: variables for the new library.

Source/WebCore:

  • GNUmakefile.am: new libWebCoreSVG.la library.
  • GNUmakefile.list.am: move SVG-related files to be part of the new library.

Source/WebKit/gtk:

  • GNUmakefile.am: link libWebCoreSVG.la into libwebkitgtk.

Source/WebKit2:

  • GNUmakefile.am: link libWebCoreSVG.la into libwebkit2gtk.
12:31 PM Changeset in webkit [135537] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[Web Inspector]Code Style changes in TimelinePresentationModel.js.
https://bugs.webkit.org/show_bug.cgi?id=102885.

Patch by Pan Deng <pan.deng@intel.com> on 2012-11-22
Reviewed by Pavel Feldman.

This patch changes "switch" code style for TimelinePresentationModel.js, no functionality update.

No new tests.

  • inspector/front-end/TimelinePresentationModel.js:

(WebInspector.TimelinePresentationModel.Record.prototype._getRecordDetails):

12:18 PM Changeset in webkit [135536] by schenney@chromium.org
  • 529 edits
    4 adds
    23 deletes in trunk/LayoutTests

Test expectations update after enabling Skia changes.

Unreviewed expectations update.

Partial update, covering all but eh SVG tests.

  • To many files to list.
12:14 PM Changeset in webkit [135535] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

Build fix attempt.

  • html/HTMLCollection.h:

(HTMLCollection):

12:06 PM Changeset in webkit [135534] by rniwa@webkit.org
  • 5 edits in trunk/Source/WebCore

Get rid of HTMLCollectionCacheBase
https://bugs.webkit.org/show_bug.cgi?id=103085

Reviewed by Sam Weinig.

Merged HTMLCollectionCacheBase into HTMLCollection now that DynamicNodeList and HTMLCollection
share one implementation.

  • dom/DynamicNodeList.cpp:

(WebCore::DynamicNodeListCacheBase::rootNode): Merged ownerNodeHasItemRefAttribute since this was
the only caller of this function, and the function name didn't match what it was checking.
(WebCore::DynamicNodeListCacheBase::invalidateCache):
(WebCore::DynamicNodeListCacheBase::invalidateIdNameCacheMaps):

  • dom/DynamicNodeList.h:

(WebCore):
(WebCore::DynamicNodeListCacheBase::cachedItemOffset):
(DynamicNodeListCacheBase):

  • html/HTMLCollection.cpp:

(WebCore::HTMLCollection::HTMLCollection):
(WebCore::DynamicNodeListCacheBase::setItemCache):
(WebCore::DynamicNodeListCacheBase::itemBeforeOrAfterCachedItem): Merged cachedElementsArrayOffset()
now that this is the only caller.
(WebCore::HTMLCollection::append):

  • html/HTMLCollection.h:

(HTMLCollection):
(WebCore::HTMLCollection::idCache): Moved from HTMLCollectionCacheBase.
(WebCore::HTMLCollection::nameCache): Ditto.
(WebCore::HTMLCollection::appendIdCache): Ditto.
(WebCore::HTMLCollection::appendNameCache): Ditto.

11:30 AM Changeset in webkit [135533] by schenney@chromium.org
  • 1881 edits
    59 adds
    84 deletes in trunk/LayoutTests

[Chromium] Test expectations update after enabling Skia changes.

Unreviewed Chromium expectations update.

Partial update, covering all fast tests. Many more to come.

  • To many files to list. Most of the pixel results in fast for Chromium.
10:37 AM Changeset in webkit [135532] by pierre.rossi@gmail.com
  • 5 edits in trunk

[Qt] REGRESSION(r135515): It made 3-3 tests fail and crash
https://bugs.webkit.org/show_bug.cgi?id=103073

Rubber-stamped by Simon Hausmann.

Source/WebKit/qt:

Removing the QNetworkAccessManager member in FrameNetworkingContextQt
was right, but we need to be careful as to how we fetch it back.
Since the WebCore Page is not always valid, get the QNAM instance
straight from the frame adapter through its page adapter instead.

  • WebCoreSupport/ChromeClientQt.cpp: [Style nit] Remove stray emit.
  • WebCoreSupport/FrameNetworkingContextQt.cpp:

(WebCore::FrameNetworkingContextQt::networkAccessManager):

LayoutTests:

Unskip the tests that had regressed.

  • platform/qt/TestExpectations:
10:18 AM Changeset in webkit [135531] by schenney@chromium.org
  • 1223 edits
    1 add in trunk/LayoutTests

[Chromium] Test expectations update after enabling Skia changes.

Unreviewed Chromium expectations update.

Partial update, covering all editing tests. Many more to come.

  • platform/chromium-mac-lion/editing/deleting/4922367-expected.png:
  • platform/chromium-mac-lion/editing/deleting/5099303-expected.png:
  • platform/chromium-mac-lion/editing/deleting/5126166-expected.png:
  • platform/chromium-mac-lion/editing/deleting/5144139-2-expected.png:
  • platform/chromium-mac-lion/editing/deleting/5206311-1-expected.png:
  • platform/chromium-mac-lion/editing/deleting/5272440-expected.png:
  • platform/chromium-mac-lion/editing/deleting/5369009-expected.png:
  • platform/chromium-mac-lion/editing/deleting/5433862-2-expected.png:
  • platform/chromium-mac-lion/editing/deleting/5483370-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-3608445-fix-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-3608462-fix-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-4083333-fix-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-after-span-ws-001-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-after-span-ws-002-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-after-span-ws-003-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-and-undo-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-at-paragraph-boundaries-002-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-at-paragraph-boundaries-003-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-at-paragraph-boundaries-004-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-at-paragraph-boundaries-005-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-at-paragraph-boundaries-006-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-at-paragraph-boundaries-007-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-at-paragraph-boundaries-008-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-at-paragraph-boundaries-009-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-at-paragraph-boundaries-010-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-at-paragraph-boundaries-011-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-block-contents-003-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-block-merge-contents-001-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-block-merge-contents-002-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-block-merge-contents-003-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-block-merge-contents-004-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-block-merge-contents-005-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-block-merge-contents-006-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-block-merge-contents-007-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-block-merge-contents-008-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-block-merge-contents-009-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-block-merge-contents-010-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-block-merge-contents-011-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-block-merge-contents-012-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-block-merge-contents-013-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-block-merge-contents-014-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-block-merge-contents-015-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-block-merge-contents-016-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-block-merge-contents-017-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-br-001-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-br-002-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-br-003-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-br-004-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-br-005-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-br-006-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-br-007-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-br-013-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-character-001-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-contiguous-ws-001-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-first-list-item-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-hr-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-image-001-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-image-002-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-image-003-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-leading-ws-001-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-line-015-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-line-016-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-line-017-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-line-end-ws-001-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-line-end-ws-002-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-listitem-001-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-listitem-002-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-selection-001-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-tab-001-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-tab-002-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-tab-003-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-tab-004-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-to-select-table-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-trailing-ws-001-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-trailing-ws-002-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-ws-fixup-001-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-ws-fixup-002-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-ws-fixup-003-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-ws-fixup-004-expected.png:
  • platform/chromium-mac-lion/editing/deleting/list-item-1-expected.png:
  • platform/chromium-mac-lion/editing/deleting/merge-different-styles-expected.png:
  • platform/chromium-mac-lion/editing/deleting/merge-endOfParagraph-expected.png:
  • platform/chromium-mac-lion/editing/deleting/merge-no-br-expected.png:
  • platform/chromium-mac-lion/editing/deleting/merge-unrendered-space-expected.png:
  • platform/chromium-mac-lion/editing/deleting/merge-whitespace-pre-expected.png:
  • platform/chromium-mac-lion/editing/deleting/non-smart-delete-expected.png:
  • platform/chromium-mac-lion/editing/deleting/pruning-after-merge-2-expected.png:
  • platform/chromium-mac-lion/editing/deleting/smart-delete-001-expected.png:
  • platform/chromium-mac-lion/editing/deleting/smart-delete-002-expected.png:
  • platform/chromium-mac-lion/editing/deleting/smart-delete-003-expected.png:
  • platform/chromium-mac-lion/editing/deleting/smart-delete-004-expected.png:
  • platform/chromium-mac-lion/editing/deleting/table-cells-expected.png:
  • platform/chromium-mac-lion/editing/deleting/type-delete-after-quote-expected.png:
  • platform/chromium-mac-lion/editing/execCommand/4580583-1-expected.png:
  • platform/chromium-mac-lion/editing/execCommand/4580583-2-expected.png:
  • platform/chromium-mac-lion/editing/execCommand/4641880-1-expected.png:
  • platform/chromium-mac-lion/editing/execCommand/4641880-2-expected.png:
  • platform/chromium-mac-lion/editing/execCommand/4747450-expected.png:
  • platform/chromium-mac-lion/editing/execCommand/4916402-expected.png:
  • platform/chromium-mac-lion/editing/execCommand/4916541-expected.png:
  • platform/chromium-mac-lion/editing/execCommand/4924441-expected.png:
  • platform/chromium-mac-lion/editing/execCommand/5080333-1-expected.png:
  • platform/chromium-mac-lion/editing/execCommand/5080333-2-expected.png:
  • platform/chromium-mac-lion/editing/execCommand/5136770-expected.png:
  • platform/chromium-mac-lion/editing/execCommand/5138441-expected.png:
  • platform/chromium-mac-lion/editing/execCommand/5142012-1-expected.png:
  • platform/chromium-mac-lion/editing/execCommand/5142012-2-expected.png:
  • platform/chromium-mac-lion/editing/execCommand/5481523-expected.png:
  • platform/chromium-mac-lion/editing/execCommand/5569741-expected.png:
  • platform/chromium-mac-lion/editing/execCommand/create-list-with-hr-expected.png:
  • platform/chromium-mac-lion/editing/execCommand/format-block-with-trailing-br-expected.png:
  • platform/chromium-mac-lion/editing/execCommand/indent-empty-root-expected.png:
  • platform/chromium-mac-lion/editing/execCommand/indent-list-item-expected.png:
  • platform/chromium-mac-lion/editing/execCommand/indent-selection-expected.png:
  • platform/chromium-mac-lion/editing/execCommand/insert-list-and-stitch-expected.png:
  • platform/chromium-mac-lion/editing/execCommand/insertHorizontalRule-expected.png:
  • platform/chromium-mac-lion/editing/execCommand/insertImage-expected.png:
  • platform/chromium-mac-lion/editing/execCommand/nsresponder-indent-expected.png:
  • platform/chromium-mac-lion/editing/execCommand/nsresponder-outdent-expected.png:
  • platform/chromium-mac-lion/editing/execCommand/print-expected.png:
  • platform/chromium-mac-lion/editing/execCommand/remove-list-from-range-selection-expected.png:
  • platform/chromium-mac-lion/editing/execCommand/remove-list-item-1-expected.png:
  • platform/chromium-mac-lion/editing/execCommand/selectAll-expected.png:
  • platform/chromium-mac-lion/editing/input/caret-at-the-edge-of-contenteditable-expected.png:
  • platform/chromium-mac-lion/editing/input/caret-at-the-edge-of-input-expected.png:
  • platform/chromium-mac-lion/editing/input/reveal-caret-of-multiline-contenteditable-expected.png:
  • platform/chromium-mac-lion/editing/input/reveal-caret-of-multiline-input-expected.png:
  • platform/chromium-mac-lion/editing/inserting/12882-expected.png:
  • platform/chromium-mac-lion/editing/inserting/4278698-expected.png:
  • platform/chromium-mac-lion/editing/inserting/4840662-expected.png:
  • platform/chromium-mac-lion/editing/inserting/4875189-1-expected.png:
  • platform/chromium-mac-lion/editing/inserting/4875189-2-expected.png:
  • platform/chromium-mac-lion/editing/inserting/4959067-expected.png:
  • platform/chromium-mac-lion/editing/inserting/4960120-1-expected.png:
  • platform/chromium-mac-lion/editing/inserting/4960120-2-expected.png:
  • platform/chromium-mac-lion/editing/inserting/5002441-expected.png:
  • platform/chromium-mac-lion/editing/inserting/5058163-1-expected.png:
  • platform/chromium-mac-lion/editing/inserting/5058163-2-expected.png:
  • platform/chromium-mac-lion/editing/inserting/5156401-2-expected.png:
  • platform/chromium-mac-lion/editing/inserting/5418891-expected.png:
  • platform/chromium-mac-lion/editing/inserting/5510537-expected.png:
  • platform/chromium-mac-lion/editing/inserting/5549929-2-expected.png:
  • platform/chromium-mac-lion/editing/inserting/5549929-3-expected.png:
  • platform/chromium-mac-lion/editing/inserting/6703873-expected.png:
  • platform/chromium-mac-lion/editing/inserting/before-after-input-element-expected.png:
  • platform/chromium-mac-lion/editing/inserting/break-blockquote-after-delete-expected.png:
  • platform/chromium-mac-lion/editing/inserting/editable-inline-element-expected.png:
  • platform/chromium-mac-lion/editing/inserting/edited-whitespace-1-expected.png:
  • platform/chromium-mac-lion/editing/inserting/editing-empty-divs-expected.png:
  • platform/chromium-mac-lion/editing/inserting/insert-3775316-fix-expected.png:
  • platform/chromium-mac-lion/editing/inserting/insert-3778059-fix-expected.png:
  • platform/chromium-mac-lion/editing/inserting/insert-3800346-fix-expected.png:
  • platform/chromium-mac-lion/editing/inserting/insert-after-delete-001-expected.png:
  • platform/chromium-mac-lion/editing/inserting/insert-at-end-01-expected.png:
  • platform/chromium-mac-lion/editing/inserting/insert-at-end-02-expected.png:
  • platform/chromium-mac-lion/editing/inserting/insert-br-001-expected.png:
  • platform/chromium-mac-lion/editing/inserting/insert-br-002-expected.png:
  • platform/chromium-mac-lion/editing/inserting/insert-br-003-expected.png:
  • platform/chromium-mac-lion/editing/inserting/insert-br-004-expected.png:
  • platform/chromium-mac-lion/editing/inserting/insert-br-005-expected.png:
  • platform/chromium-mac-lion/editing/inserting/insert-br-006-expected.png:
  • platform/chromium-mac-lion/editing/inserting/insert-br-007-expected.png:
  • platform/chromium-mac-lion/editing/inserting/insert-br-008-expected.png:
  • platform/chromium-mac-lion/editing/inserting/insert-br-009-expected.png:
  • platform/chromium-mac-lion/editing/inserting/insert-br-at-tabspan-001-expected.png:
  • platform/chromium-mac-lion/editing/inserting/insert-br-at-tabspan-002-expected.png:
  • platform/chromium-mac-lion/editing/inserting/insert-br-at-tabspan-003-expected.png:
  • platform/chromium-mac-lion/editing/inserting/insert-br-quoted-001-expected.png:
  • platform/chromium-mac-lion/editing/inserting/insert-br-quoted-002-expected.png:
  • platform/chromium-mac-lion/editing/inserting/insert-br-quoted-003-expected.png:
  • platform/chromium-mac-lion/editing/inserting/insert-br-quoted-004-expected.png:
  • platform/chromium-mac-lion/editing/inserting/insert-br-quoted-005-expected.png:
  • platform/chromium-mac-lion/editing/inserting/insert-br-quoted-006-expected.png:
  • platform/chromium-mac-lion/editing/inserting/insert-div-025-expected.png:
  • platform/chromium-mac-lion/editing/inserting/insert-div-026-expected.png:
  • platform/chromium-mac-lion/editing/inserting/insert-paragraph-01-expected.png:
  • platform/chromium-mac-lion/editing/inserting/insert-paragraph-02-expected.png:
  • platform/chromium-mac-lion/editing/inserting/insert-paragraph-03-expected.png:
  • platform/chromium-mac-lion/editing/inserting/insert-paragraph-04-expected.png:
  • platform/chromium-mac-lion/editing/inserting/insert-paragraph-05-expected.png:
  • platform/chromium-mac-lion/editing/inserting/insert-space-in-empty-doc-expected.png:
  • platform/chromium-mac-lion/editing/inserting/insert-tab-001-expected.png:
  • platform/chromium-mac-lion/editing/inserting/insert-tab-002-expected.png:
  • platform/chromium-mac-lion/editing/inserting/insert-tab-003-expected.png:
  • platform/chromium-mac-lion/editing/inserting/insert-tab-004-expected.png:
  • platform/chromium-mac-lion/editing/inserting/insert-text-at-tabspan-001-expected.png:
  • platform/chromium-mac-lion/editing/inserting/insert-text-at-tabspan-002-expected.png:
  • platform/chromium-mac-lion/editing/inserting/insert-text-at-tabspan-003-expected.png:
  • platform/chromium-mac-lion/editing/inserting/insert-text-with-newlines-expected.png:
  • platform/chromium-mac-lion/editing/inserting/line-break-expected.png:
  • platform/chromium-mac-lion/editing/inserting/multiple-lines-selected-expected.png:
  • platform/chromium-mac-lion/editing/inserting/paragraph-separator-01-expected.png:
  • platform/chromium-mac-lion/editing/inserting/paragraph-separator-02-expected.png:
  • platform/chromium-mac-lion/editing/inserting/paragraph-separator-03-expected.png:
  • platform/chromium-mac-lion/editing/inserting/paragraph-separator-in-table-1-expected.png:
  • platform/chromium-mac-lion/editing/inserting/paragraph-separator-in-table-2-expected.png:
  • platform/chromium-mac-lion/editing/inserting/redo-expected.png:
  • platform/chromium-mac-lion/editing/inserting/return-key-with-selection-001-expected.png:
  • platform/chromium-mac-lion/editing/inserting/return-key-with-selection-002-expected.png:
  • platform/chromium-mac-lion/editing/inserting/return-key-with-selection-003-expected.png:
  • platform/chromium-mac-lion/editing/inserting/typing-001-expected.png:
  • platform/chromium-mac-lion/editing/inserting/typing-002-expected.png:
  • platform/chromium-mac-lion/editing/inserting/typing-003-expected.png:
  • platform/chromium-mac-lion/editing/inserting/typing-around-br-001-expected.png:
  • platform/chromium-mac-lion/editing/inserting/typing-around-image-001-expected.png:
  • platform/chromium-mac-lion/editing/inserting/typing-at-end-of-line-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/3976872-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/4076267-2-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/4076267-3-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/4076267-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/4242293-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/4631972-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/4641033-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/4806874-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/4944770-1-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/4944770-2-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/4947130-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/5006779-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/5032095-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/5071074-2-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/5071074-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/5075944-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/5134759-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/5156401-1-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/5247341-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/5387578-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/5478250-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/5601583-1-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/8145-1-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/8145-2-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/8145-3-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/bad-placeholder-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/copy-standalone-image-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/cut-text-001-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/displaced-generic-placeholder-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/displaced-placeholder-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/drag-drop-modifies-page-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/drag-selected-image-to-contenteditable-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/drop-text-without-selection-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/innerText-inline-table-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/input-field-1-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/merge-after-delete-1-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/merge-after-delete-2-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/merge-after-delete-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/merge-end-blockquote-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/merge-end-borders-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/merge-start-blockquote-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/merge-start-list-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/paste-4035648-fix-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/paste-4038267-fix-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/paste-blockquote-after-blockquote-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/paste-blockquote-into-blockquote-4-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/paste-line-endings-001-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/paste-line-endings-002-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/paste-line-endings-003-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/paste-line-endings-004-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/paste-line-endings-005-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/paste-line-endings-006-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/paste-line-endings-007-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/paste-line-endings-008-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/paste-line-endings-009-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/paste-line-endings-010-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/paste-match-style-001-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/paste-match-style-002-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/paste-text-019-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/paste-text-at-tabspan-003-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/pasting-object-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/pasting-tabs-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/quirks-mode-br-1-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/smart-drag-drop-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/smart-paste-007-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/smart-paste-008-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/styled-element-markup-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/undoable-fragment-removes-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/unrendered-br-expected.png:
  • platform/chromium-mac-lion/editing/selection/13804-expected.png:
  • platform/chromium-mac-lion/editing/selection/3690703-2-expected.png:
  • platform/chromium-mac-lion/editing/selection/3690703-expected.png:
  • platform/chromium-mac-lion/editing/selection/3690719-expected.png:
  • platform/chromium-mac-lion/editing/selection/4397952-expected.png:
  • platform/chromium-mac-lion/editing/selection/4402375-expected.png:
  • platform/chromium-mac-lion/editing/selection/4818145-expected.png:
  • platform/chromium-mac-lion/editing/selection/4866671-expected.png:
  • platform/chromium-mac-lion/editing/selection/4889598-expected.png:
  • platform/chromium-mac-lion/editing/selection/4895428-2-expected.png:
  • platform/chromium-mac-lion/editing/selection/4895428-3-expected.png:
  • platform/chromium-mac-lion/editing/selection/4932260-1-expected.png:
  • platform/chromium-mac-lion/editing/selection/4932260-2-expected.png:
  • platform/chromium-mac-lion/editing/selection/4932260-3-expected.png:
  • platform/chromium-mac-lion/editing/selection/4947387-expected.png:
  • platform/chromium-mac-lion/editing/selection/5007143-2-expected.png:
  • platform/chromium-mac-lion/editing/selection/5007143-expected.png:
  • platform/chromium-mac-lion/editing/selection/5057506-2-expected.png:
  • platform/chromium-mac-lion/editing/selection/5057506-expected.png:
  • platform/chromium-mac-lion/editing/selection/5076323-1-expected.png:
  • platform/chromium-mac-lion/editing/selection/5076323-2-expected.png:
  • platform/chromium-mac-lion/editing/selection/5076323-3-expected.png:
  • platform/chromium-mac-lion/editing/selection/5099303-expected.png:
  • platform/chromium-mac-lion/editing/selection/5131716-1-expected.png:
  • platform/chromium-mac-lion/editing/selection/5131716-2-expected.png:
  • platform/chromium-mac-lion/editing/selection/5131716-3-expected.png:
  • platform/chromium-mac-lion/editing/selection/5131716-4-expected.png:
  • platform/chromium-mac-lion/editing/selection/5195166-2-expected.png:
  • platform/chromium-mac-lion/editing/selection/5234383-1-expected.png:
  • platform/chromium-mac-lion/editing/selection/5234383-2-expected.png:
  • platform/chromium-mac-lion/editing/selection/5240265-expected.png:
  • platform/chromium-mac-lion/editing/selection/6476-expected.png:
  • platform/chromium-mac-lion/editing/selection/after-line-wrap-expected.png:
  • platform/chromium-mac-lion/editing/selection/caret-before-select-expected.png:
  • platform/chromium-mac-lion/editing/selection/caret-ltr-2-expected.png:
  • platform/chromium-mac-lion/editing/selection/caret-ltr-2-left-expected.png:
  • platform/chromium-mac-lion/editing/selection/caret-ltr-expected.png:
  • platform/chromium-mac-lion/editing/selection/caret-ltr-right-expected.png:
  • platform/chromium-mac-lion/editing/selection/caret-rtl-2-expected.png:
  • platform/chromium-mac-lion/editing/selection/caret-rtl-2-left-expected.png:
  • platform/chromium-mac-lion/editing/selection/caret-rtl-expected.png:
  • platform/chromium-mac-lion/editing/selection/caret-rtl-right-expected.png:
  • platform/chromium-mac-lion/editing/selection/click-start-of-line-expected.png:
  • platform/chromium-mac-lion/editing/selection/contains-boundaries-expected.png:
  • platform/chromium-mac-lion/editing/selection/contenteditable-click-inside-expected.png:
  • platform/chromium-mac-lion/editing/selection/drag-select-1-expected.png:
  • platform/chromium-mac-lion/editing/selection/drag-to-contenteditable-iframe-expected.png:
  • platform/chromium-mac-lion/editing/selection/editable-non-editable-crash-expected.png:
  • platform/chromium-mac-lion/editing/selection/end-of-document-expected.png:
  • platform/chromium-mac-lion/editing/selection/expanding-selections-expected.png:
  • platform/chromium-mac-lion/editing/selection/expanding-selections2-expected.png:
  • platform/chromium-mac-lion/editing/selection/extend-by-character-001-expected.png:
  • platform/chromium-mac-lion/editing/selection/extend-by-character-002-expected.png:
  • platform/chromium-mac-lion/editing/selection/extend-by-character-003-expected.png:
  • platform/chromium-mac-lion/editing/selection/extend-by-character-004-expected.png:
  • platform/chromium-mac-lion/editing/selection/extend-by-character-005-expected.png:
  • platform/chromium-mac-lion/editing/selection/extend-by-character-006-expected.png:
  • platform/chromium-mac-lion/editing/selection/extend-by-sentence-001-expected.png:
  • platform/chromium-mac-lion/editing/selection/extend-by-word-001-expected.png:
  • platform/chromium-mac-lion/editing/selection/extend-by-word-002-expected.png:
  • platform/chromium-mac-lion/editing/selection/extend-inside-transforms-backward-expected.png:
  • platform/chromium-mac-lion/editing/selection/extend-inside-transforms-forward-expected.png:
  • platform/chromium-mac-lion/editing/selection/extend-selection-bidi-expected.png:
  • platform/chromium-mac-lion/editing/selection/fake-doubleclick-expected.png:
  • platform/chromium-mac-lion/editing/selection/iframe-expected.png:
  • platform/chromium-mac-lion/editing/selection/image-before-linebreak-expected.png:
  • platform/chromium-mac-lion/editing/selection/inline-table-expected.png:
  • platform/chromium-mac-lion/editing/selection/leave-requested-block-expected.png:
  • platform/chromium-mac-lion/editing/selection/mixed-editability-3-expected.png:
  • platform/chromium-mac-lion/editing/selection/mixed-editability-4-expected.png:
  • platform/chromium-mac-lion/editing/selection/mixed-editability-5-expected.png:
  • platform/chromium-mac-lion/editing/selection/mixed-editability-6-expected.png:
  • platform/chromium-mac-lion/editing/selection/mixed-editability-7-expected.png:
  • platform/chromium-mac-lion/editing/selection/mixed-editability-8-expected.png:
  • platform/chromium-mac-lion/editing/selection/mixed-editability-9-expected.png:
  • platform/chromium-mac-lion/editing/selection/move-backwords-by-word-001-expected.png:
  • platform/chromium-mac-lion/editing/selection/move-between-blocks-no-001-expected.png:
  • platform/chromium-mac-lion/editing/selection/move-by-character-001-expected.png:
  • platform/chromium-mac-lion/editing/selection/move-by-character-002-expected.png:
  • platform/chromium-mac-lion/editing/selection/move-by-character-003-expected.png:
  • platform/chromium-mac-lion/editing/selection/move-by-character-004-expected.png:
  • platform/chromium-mac-lion/editing/selection/move-by-character-005-expected.png:
  • platform/chromium-mac-lion/editing/selection/move-by-character-6-expected.png:
  • platform/chromium-mac-lion/editing/selection/move-by-line-002-expected.png:
  • platform/chromium-mac-lion/editing/selection/move-by-sentence-001-expected.png:
  • platform/chromium-mac-lion/editing/selection/move-by-sentence-linebreak-expected.png:
  • platform/chromium-mac-lion/editing/selection/move-by-word-001-expected.png:
  • platform/chromium-mac-lion/editing/selection/move-past-trailing-space-expected.png:
  • platform/chromium-mac-lion/editing/selection/previous-line-position-expected.png:
  • platform/chromium-mac-lion/editing/selection/replace-selection-1-expected.png:
  • platform/chromium-mac-lion/editing/selection/replaced-boundaries-1-expected.png:
  • platform/chromium-mac-lion/editing/selection/replaced-boundaries-2-expected.png:
  • platform/chromium-mac-lion/editing/selection/replaced-boundaries-3-expected.png:
  • platform/chromium-mac-lion/editing/selection/select-across-readonly-input-1-expected.png:
  • platform/chromium-mac-lion/editing/selection/select-across-readonly-input-2-expected.png:
  • platform/chromium-mac-lion/editing/selection/select-across-readonly-input-3-expected.png:
  • platform/chromium-mac-lion/editing/selection/select-across-readonly-input-4-expected.png:
  • platform/chromium-mac-lion/editing/selection/select-across-readonly-input-5-expected.png:
  • platform/chromium-mac-lion/editing/selection/select-all-001-expected.png:
  • platform/chromium-mac-lion/editing/selection/select-all-002-expected.png:
  • platform/chromium-mac-lion/editing/selection/select-all-iframe-expected.png:
  • platform/chromium-mac-lion/editing/selection/select-box-expected.png:
  • platform/chromium-mac-lion/editing/selection/select-element-paragraph-boundary-expected.png:
  • platform/chromium-mac-lion/editing/selection/select-from-textfield-outwards-expected.png:
  • platform/chromium-mac-lion/editing/selection/select-missing-image-expected.png:
  • platform/chromium-mac-lion/editing/selection/selectNode-expected.png:
  • platform/chromium-mac-lion/editing/selection/selectNodeContents-expected.png:
  • platform/chromium-mac-lion/editing/selection/selection-3748164-fix-expected.png:
  • platform/chromium-mac-lion/editing/selection/selection-button-text-expected.png:
  • platform/chromium-mac-lion/editing/selection/table-caret-1-expected.png:
  • platform/chromium-mac-lion/editing/selection/table-caret-2-expected.png:
  • platform/chromium-mac-lion/editing/selection/table-caret-3-expected.png:
  • platform/chromium-mac-lion/editing/selection/transformed-selection-rects-expected.png:
  • platform/chromium-mac-lion/editing/selection/triple-click-in-pre-expected.png:
  • platform/chromium-mac-lion/editing/selection/unrendered-001-expected.png:
  • platform/chromium-mac-lion/editing/selection/unrendered-002-expected.png:
  • platform/chromium-mac-lion/editing/selection/unrendered-003-expected.png:
  • platform/chromium-mac-lion/editing/selection/unrendered-004-expected.png:
  • platform/chromium-mac-lion/editing/selection/unrendered-005-expected.png:
  • platform/chromium-mac-lion/editing/selection/unrendered-space-expected.png:
  • platform/chromium-mac-lion/editing/selection/vertical-rl-rtl-extend-line-backward-br-expected.png:
  • platform/chromium-mac-lion/editing/selection/vertical-rl-rtl-extend-line-backward-p-expected.png:
  • platform/chromium-mac-lion/editing/selection/vertical-rl-rtl-extend-line-forward-br-expected.png:
  • platform/chromium-mac-lion/editing/selection/vertical-rl-rtl-extend-line-forward-p-expected.png:
  • platform/chromium-mac-lion/editing/selection/wrapped-line-caret-1-expected.png:
  • platform/chromium-mac-lion/editing/selection/wrapped-line-caret-2-expected.png:
  • platform/chromium-mac-lion/editing/spelling/grammar-markers-expected.png:
  • platform/chromium-mac-lion/editing/spelling/grammar-markers-hidpi-expected.png:
  • platform/chromium-mac-lion/editing/spelling/spelling-expected.png:
  • platform/chromium-mac-lion/editing/style/4916887-expected.png:
  • platform/chromium-mac-lion/editing/style/5017613-1-expected.png:
  • platform/chromium-mac-lion/editing/style/5017613-2-expected.png:
  • platform/chromium-mac-lion/editing/style/5046875-1-expected.png:
  • platform/chromium-mac-lion/editing/style/5046875-2-expected.png:
  • platform/chromium-mac-lion/editing/style/5065910-expected.png:
  • platform/chromium-mac-lion/editing/style/5084241-expected.png:
  • platform/chromium-mac-lion/editing/style/5228141-expected.png:
  • platform/chromium-mac-lion/editing/style/5279521-expected.png:
  • platform/chromium-mac-lion/editing/style/block-styles-007-expected.png:
  • platform/chromium-mac-lion/editing/style/highlight-expected.png:
  • platform/chromium-mac-lion/editing/style/smoosh-styles-001-expected.png:
  • platform/chromium-mac-lion/editing/style/smoosh-styles-003-expected.png:
  • platform/chromium-mac-lion/editing/style/style-3681552-fix-001-expected.png:
  • platform/chromium-mac-lion/editing/style/style-3681552-fix-002-expected.png:
  • platform/chromium-mac-lion/editing/style/style-3998892-fix-expected.png:
  • platform/chromium-mac-lion/editing/style/style-boundary-001-expected.png:
  • platform/chromium-mac-lion/editing/style/style-boundary-002-expected.png:
  • platform/chromium-mac-lion/editing/style/style-boundary-003-expected.png:
  • platform/chromium-mac-lion/editing/style/style-boundary-004-expected.png:
  • platform/chromium-mac-lion/editing/style/style-boundary-005-expected.png:
  • platform/chromium-mac-lion/editing/style/typing-style-001-expected.png:
  • platform/chromium-mac-lion/editing/style/typing-style-002-expected.png:
  • platform/chromium-mac-lion/editing/style/unbold-in-bold-expected.png:
  • platform/chromium-mac-lion/editing/undo/4063751-expected.png:
  • platform/chromium-mac-lion/editing/undo/redo-typing-001-expected.png:
  • platform/chromium-mac-lion/editing/undo/undo-combined-delete-boundary-expected.png:
  • platform/chromium-mac-lion/editing/undo/undo-combined-delete-expected.png:
  • platform/chromium-mac-lion/editing/undo/undo-delete-boundary-expected.png:
  • platform/chromium-mac-lion/editing/undo/undo-delete-expected.png:
  • platform/chromium-mac-lion/editing/undo/undo-forward-delete-boundary-expected.png:
  • platform/chromium-mac-lion/editing/undo/undo-forward-delete-expected.png:
  • platform/chromium-mac-lion/editing/undo/undo-typing-001-expected.png:
  • platform/chromium-mac-lion/editing/unsupported-content/list-delete-001-expected.png:
  • platform/chromium-mac-lion/editing/unsupported-content/list-delete-003-expected.png:
  • platform/chromium-mac-lion/editing/unsupported-content/list-type-after-expected.png:
  • platform/chromium-mac-lion/editing/unsupported-content/list-type-before-expected.png:
  • platform/chromium-mac-lion/editing/unsupported-content/table-delete-001-expected.png:
  • platform/chromium-mac-lion/editing/unsupported-content/table-delete-002-expected.png:
  • platform/chromium-mac-lion/editing/unsupported-content/table-delete-003-expected.png:
  • platform/chromium-mac-lion/editing/unsupported-content/table-type-after-expected.png:
  • platform/chromium-mac-lion/editing/unsupported-content/table-type-before-expected.png:
  • platform/chromium-mac-snowleopard/editing/deleting/4922367-expected.png:
  • platform/chromium-mac-snowleopard/editing/deleting/5099303-expected.png:
  • platform/chromium-mac-snowleopard/editing/deleting/5126166-expected.png:
  • platform/chromium-mac-snowleopard/editing/deleting/5144139-2-expected.png:
  • platform/chromium-mac-snowleopard/editing/deleting/5206311-1-expected.png:
  • platform/chromium-mac-snowleopard/editing/deleting/5272440-expected.png:
  • platform/chromium-mac-snowleopard/editing/deleting/5369009-expected.png:
  • platform/chromium-mac-snowleopard/editing/deleting/5433862-2-expected.png:
  • platform/chromium-mac-snowleopard/editing/deleting/5483370-expected.png:
  • platform/chromium-mac-snowleopard/editing/deleting/delete-after-span-ws-001-expected.png:
  • platform/chromium-mac-snowleopard/editing/deleting/delete-after-span-ws-002-expected.png:
  • platform/chromium-mac-snowleopard/editing/deleting/delete-after-span-ws-003-expected.png:
  • platform/chromium-mac-snowleopard/editing/deleting/delete-br-013-expected.png:
  • platform/chromium-mac-snowleopard/editing/deleting/delete-first-list-item-expected.png:
  • platform/chromium-mac-snowleopard/editing/deleting/delete-hr-expected.png:
  • platform/chromium-mac-snowleopard/editing/deleting/delete-line-015-expected.png:
  • platform/chromium-mac-snowleopard/editing/deleting/delete-line-016-expected.png:
  • platform/chromium-mac-snowleopard/editing/deleting/delete-line-017-expected.png:
  • platform/chromium-mac-snowleopard/editing/deleting/delete-line-end-ws-001-expected.png:
  • platform/chromium-mac-snowleopard/editing/deleting/delete-line-end-ws-002-expected.png:
  • platform/chromium-mac-snowleopard/editing/deleting/delete-to-select-table-expected.png:
  • platform/chromium-mac-snowleopard/editing/deleting/delete-ws-fixup-002-expected.png:
  • platform/chromium-mac-snowleopard/editing/deleting/list-item-1-expected.png:
  • platform/chromium-mac-snowleopard/editing/deleting/merge-different-styles-expected.png:
  • platform/chromium-mac-snowleopard/editing/deleting/merge-endOfParagraph-expected.png:
  • platform/chromium-mac-snowleopard/editing/deleting/merge-no-br-expected.png:
  • platform/chromium-mac-snowleopard/editing/deleting/merge-unrendered-space-expected.png:
  • platform/chromium-mac-snowleopard/editing/deleting/merge-whitespace-pre-expected.png:
  • platform/chromium-mac-snowleopard/editing/deleting/pruning-after-merge-2-expected.png:
  • platform/chromium-mac-snowleopard/editing/deleting/smart-delete-003-expected.png:
  • platform/chromium-mac-snowleopard/editing/deleting/smart-delete-004-expected.png:
  • platform/chromium-mac-snowleopard/editing/deleting/table-cells-expected.png:
  • platform/chromium-mac-snowleopard/editing/deleting/type-delete-after-quote-expected.png:
  • platform/chromium-mac-snowleopard/editing/execCommand/4580583-1-expected.png:
  • platform/chromium-mac-snowleopard/editing/execCommand/4580583-2-expected.png:
  • platform/chromium-mac-snowleopard/editing/execCommand/4641880-1-expected.png:
  • platform/chromium-mac-snowleopard/editing/execCommand/4641880-2-expected.png:
  • platform/chromium-mac-snowleopard/editing/execCommand/4747450-expected.png:
  • platform/chromium-mac-snowleopard/editing/execCommand/4916402-expected.png:
  • platform/chromium-mac-snowleopard/editing/execCommand/4916541-expected.png:
  • platform/chromium-mac-snowleopard/editing/execCommand/4924441-expected.png:
  • platform/chromium-mac-snowleopard/editing/execCommand/5080333-1-expected.png:
  • platform/chromium-mac-snowleopard/editing/execCommand/5080333-2-expected.png:
  • platform/chromium-mac-snowleopard/editing/execCommand/5136770-expected.png:
  • platform/chromium-mac-snowleopard/editing/execCommand/5138441-expected.png:
  • platform/chromium-mac-snowleopard/editing/execCommand/5142012-1-expected.png:
  • platform/chromium-mac-snowleopard/editing/execCommand/5142012-2-expected.png:
  • platform/chromium-mac-snowleopard/editing/execCommand/5481523-expected.png:
  • platform/chromium-mac-snowleopard/editing/execCommand/5569741-expected.png:
  • platform/chromium-mac-snowleopard/editing/execCommand/create-list-with-hr-expected.png:
  • platform/chromium-mac-snowleopard/editing/execCommand/format-block-with-trailing-br-expected.png:
  • platform/chromium-mac-snowleopard/editing/execCommand/indent-empty-root-expected.png:
  • platform/chromium-mac-snowleopard/editing/execCommand/indent-list-item-expected.png:
  • platform/chromium-mac-snowleopard/editing/execCommand/indent-selection-expected.png:
  • platform/chromium-mac-snowleopard/editing/execCommand/insert-list-and-stitch-expected.png:
  • platform/chromium-mac-snowleopard/editing/execCommand/insertHorizontalRule-expected.png:
  • platform/chromium-mac-snowleopard/editing/execCommand/insertImage-expected.png:
  • platform/chromium-mac-snowleopard/editing/execCommand/nsresponder-indent-expected.png:
  • platform/chromium-mac-snowleopard/editing/execCommand/nsresponder-outdent-expected.png:
  • platform/chromium-mac-snowleopard/editing/execCommand/remove-list-from-range-selection-expected.png:
  • platform/chromium-mac-snowleopard/editing/execCommand/remove-list-item-1-expected.png:
  • platform/chromium-mac-snowleopard/editing/input/caret-at-the-edge-of-contenteditable-expected.png:
  • platform/chromium-mac-snowleopard/editing/input/caret-at-the-edge-of-input-expected.png:
  • platform/chromium-mac-snowleopard/editing/input/reveal-caret-of-multiline-contenteditable-expected.png:
  • platform/chromium-mac-snowleopard/editing/input/reveal-caret-of-multiline-input-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/12882-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/4278698-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/4840662-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/4875189-1-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/4875189-2-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/4959067-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/4960120-1-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/4960120-2-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/5002441-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/5058163-1-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/5058163-2-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/5156401-2-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/5418891-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/5510537-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/5549929-2-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/5549929-3-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/6703873-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/before-after-input-element-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/break-blockquote-after-delete-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/editable-inline-element-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/edited-whitespace-1-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/editing-empty-divs-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/insert-at-end-01-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/insert-at-end-02-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/insert-br-009-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/insert-br-quoted-001-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/insert-br-quoted-002-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/insert-br-quoted-003-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/insert-br-quoted-004-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/insert-br-quoted-005-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/insert-br-quoted-006-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/insert-paragraph-01-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/insert-paragraph-02-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/insert-paragraph-03-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/insert-paragraph-04-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/insert-paragraph-05-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/line-break-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/multiple-lines-selected-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/paragraph-separator-01-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/paragraph-separator-02-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/paragraph-separator-03-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/paragraph-separator-in-table-1-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/paragraph-separator-in-table-2-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/redo-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/typing-at-end-of-line-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/3976872-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/4076267-2-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/4076267-3-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/4076267-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/4242293-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/4631972-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/4641033-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/4806874-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/4944770-1-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/4944770-2-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/4947130-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/5006779-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/5032095-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/5071074-2-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/5071074-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/5075944-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/5134759-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/5156401-1-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/5247341-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/5387578-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/5478250-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/5601583-1-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/8145-1-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/8145-2-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/8145-3-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/bad-placeholder-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/copy-standalone-image-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/displaced-generic-placeholder-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/displaced-placeholder-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/drag-drop-modifies-page-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/drag-selected-image-to-contenteditable-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/drop-text-without-selection-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/innerText-inline-table-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/input-field-1-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/merge-after-delete-1-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/merge-after-delete-2-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/merge-after-delete-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/merge-end-blockquote-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/merge-end-borders-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/merge-start-blockquote-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/merge-start-list-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/paste-blockquote-after-blockquote-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/paste-blockquote-into-blockquote-4-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/pasting-object-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/pasting-tabs-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/quirks-mode-br-1-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/smart-drag-drop-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/smart-paste-008-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/styled-element-markup-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/undoable-fragment-removes-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/unrendered-br-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/13804-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/3690703-2-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/3690703-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/3690719-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/4397952-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/4402375-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/4818145-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/4866671-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/4889598-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/4895428-2-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/4895428-3-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/4932260-1-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/4932260-2-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/4932260-3-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/4947387-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/5007143-2-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/5007143-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/5057506-2-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/5057506-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/5076323-1-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/5076323-2-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/5076323-3-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/5099303-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/5131716-1-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/5131716-2-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/5131716-3-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/5131716-4-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/5195166-2-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/5234383-1-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/5234383-2-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/5240265-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/6476-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/after-line-wrap-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/caret-before-select-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/caret-ltr-2-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/caret-ltr-2-left-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/caret-ltr-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/caret-ltr-right-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/caret-rtl-2-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/caret-rtl-2-left-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/caret-rtl-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/caret-rtl-right-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/click-start-of-line-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/contains-boundaries-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/contenteditable-click-inside-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/drag-select-1-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/drag-to-contenteditable-iframe-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/editable-non-editable-crash-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/end-of-document-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/expanding-selections-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/expanding-selections2-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/extend-by-word-002-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/extend-selection-bidi-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/fake-doubleclick-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/iframe-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/image-before-linebreak-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/inline-table-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/leave-requested-block-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/mixed-editability-3-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/mixed-editability-4-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/mixed-editability-5-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/mixed-editability-6-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/mixed-editability-7-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/mixed-editability-8-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/mixed-editability-9-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/move-by-line-001-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/selection/move-by-sentence-linebreak-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/previous-line-position-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/replace-selection-1-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/replaced-boundaries-1-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/replaced-boundaries-2-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/replaced-boundaries-3-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/select-across-readonly-input-1-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/select-across-readonly-input-2-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/select-across-readonly-input-3-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/select-across-readonly-input-4-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/select-across-readonly-input-5-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/select-all-001-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/select-all-002-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/select-all-iframe-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/select-box-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/select-element-paragraph-boundary-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/select-from-textfield-outwards-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/selectNode-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/selectNodeContents-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/selection-button-text-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/table-caret-1-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/table-caret-2-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/table-caret-3-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/transformed-selection-rects-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/triple-click-in-pre-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/unrendered-001-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/unrendered-002-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/unrendered-003-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/unrendered-004-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/unrendered-005-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/unrendered-space-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/vertical-rl-rtl-extend-line-backward-br-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/vertical-rl-rtl-extend-line-backward-p-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/vertical-rl-rtl-extend-line-forward-br-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/vertical-rl-rtl-extend-line-forward-p-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/wrapped-line-caret-1-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/wrapped-line-caret-2-expected.png:
  • platform/chromium-mac-snowleopard/editing/spelling/grammar-markers-expected.png:
  • platform/chromium-mac-snowleopard/editing/spelling/spelling-expected.png:
  • platform/chromium-mac-snowleopard/editing/style/4916887-expected.png:
  • platform/chromium-mac-snowleopard/editing/style/5017613-1-expected.png:
  • platform/chromium-mac-snowleopard/editing/style/5017613-2-expected.png:
  • platform/chromium-mac-snowleopard/editing/style/5046875-1-expected.png:
  • platform/chromium-mac-snowleopard/editing/style/5046875-2-expected.png:
  • platform/chromium-mac-snowleopard/editing/style/5065910-expected.png:
  • platform/chromium-mac-snowleopard/editing/style/5084241-expected.png:
  • platform/chromium-mac-snowleopard/editing/style/5228141-expected.png:
  • platform/chromium-mac-snowleopard/editing/style/5279521-expected.png:
  • platform/chromium-mac-snowleopard/editing/style/highlight-expected.png:
  • platform/chromium-mac-snowleopard/editing/style/style-boundary-005-expected.png:
  • platform/chromium-mac-snowleopard/editing/undo/4063751-expected.png:
  • platform/chromium-mac-snowleopard/editing/unsupported-content/list-delete-001-expected.png:
  • platform/chromium-mac-snowleopard/editing/unsupported-content/list-delete-003-expected.png:
  • platform/chromium-mac-snowleopard/editing/unsupported-content/list-type-after-expected.png:
  • platform/chromium-mac-snowleopard/editing/unsupported-content/list-type-before-expected.png:
  • platform/chromium-mac-snowleopard/editing/unsupported-content/table-delete-001-expected.png:
  • platform/chromium-mac-snowleopard/editing/unsupported-content/table-delete-002-expected.png:
  • platform/chromium-mac-snowleopard/editing/unsupported-content/table-delete-003-expected.png:
  • platform/chromium-mac-snowleopard/editing/unsupported-content/table-type-after-expected.png:
  • platform/chromium-mac-snowleopard/editing/unsupported-content/table-type-before-expected.png:
  • platform/chromium-mac/editing/deleting/4922367-expected.png:
  • platform/chromium-mac/editing/deleting/5099303-expected.png:
  • platform/chromium-mac/editing/deleting/5126166-expected.png:
  • platform/chromium-mac/editing/deleting/5144139-2-expected.png:
  • platform/chromium-mac/editing/deleting/5206311-1-expected.png:
  • platform/chromium-mac/editing/deleting/5272440-expected.png:
  • platform/chromium-mac/editing/deleting/5369009-expected.png:
  • platform/chromium-mac/editing/deleting/5433862-2-expected.png:
  • platform/chromium-mac/editing/deleting/5483370-expected.png:
  • platform/chromium-mac/editing/deleting/collapse-whitespace-3587601-fix-expected.png:
  • platform/chromium-mac/editing/deleting/delete-3608445-fix-expected.png:
  • platform/chromium-mac/editing/deleting/delete-3608462-fix-expected.png:
  • platform/chromium-mac/editing/deleting/delete-4083333-fix-expected.png:
  • platform/chromium-mac/editing/deleting/delete-after-span-ws-001-expected.png:
  • platform/chromium-mac/editing/deleting/delete-after-span-ws-002-expected.png:
  • platform/chromium-mac/editing/deleting/delete-after-span-ws-003-expected.png:
  • platform/chromium-mac/editing/deleting/delete-and-undo-expected.png:
  • platform/chromium-mac/editing/deleting/delete-at-paragraph-boundaries-002-expected.png:
  • platform/chromium-mac/editing/deleting/delete-at-paragraph-boundaries-003-expected.png:
  • platform/chromium-mac/editing/deleting/delete-at-paragraph-boundaries-004-expected.png:
  • platform/chromium-mac/editing/deleting/delete-at-paragraph-boundaries-005-expected.png:
  • platform/chromium-mac/editing/deleting/delete-at-paragraph-boundaries-006-expected.png:
  • platform/chromium-mac/editing/deleting/delete-at-paragraph-boundaries-007-expected.png:
  • platform/chromium-mac/editing/deleting/delete-at-paragraph-boundaries-008-expected.png:
  • platform/chromium-mac/editing/deleting/delete-at-paragraph-boundaries-009-expected.png:
  • platform/chromium-mac/editing/deleting/delete-at-paragraph-boundaries-010-expected.png:
  • platform/chromium-mac/editing/deleting/delete-at-paragraph-boundaries-011-expected.png:
  • platform/chromium-mac/editing/deleting/delete-at-start-or-end-expected.png:
  • platform/chromium-mac/editing/deleting/delete-block-contents-001-expected.png:
  • platform/chromium-mac/editing/deleting/delete-block-contents-002-expected.png:
  • platform/chromium-mac/editing/deleting/delete-block-contents-003-expected.png:
  • platform/chromium-mac/editing/deleting/delete-block-merge-contents-001-expected.png:
  • platform/chromium-mac/editing/deleting/delete-block-merge-contents-002-expected.png:
  • platform/chromium-mac/editing/deleting/delete-block-merge-contents-003-expected.png:
  • platform/chromium-mac/editing/deleting/delete-block-merge-contents-004-expected.png:
  • platform/chromium-mac/editing/deleting/delete-block-merge-contents-005-expected.png:
  • platform/chromium-mac/editing/deleting/delete-block-merge-contents-006-expected.png:
  • platform/chromium-mac/editing/deleting/delete-block-merge-contents-007-expected.png:
  • platform/chromium-mac/editing/deleting/delete-block-merge-contents-008-expected.png:
  • platform/chromium-mac/editing/deleting/delete-block-merge-contents-009-expected.png:
  • platform/chromium-mac/editing/deleting/delete-block-merge-contents-010-expected.png:
  • platform/chromium-mac/editing/deleting/delete-block-merge-contents-011-expected.png:
  • platform/chromium-mac/editing/deleting/delete-block-merge-contents-012-expected.png:
  • platform/chromium-mac/editing/deleting/delete-block-merge-contents-013-expected.png:
  • platform/chromium-mac/editing/deleting/delete-block-merge-contents-014-expected.png:
  • platform/chromium-mac/editing/deleting/delete-block-merge-contents-015-expected.png:
  • platform/chromium-mac/editing/deleting/delete-block-merge-contents-016-expected.png:
  • platform/chromium-mac/editing/deleting/delete-block-merge-contents-017-expected.png:
  • platform/chromium-mac/editing/deleting/delete-br-001-expected.png:
  • platform/chromium-mac/editing/deleting/delete-br-002-expected.png:
  • platform/chromium-mac/editing/deleting/delete-br-003-expected.png:
  • platform/chromium-mac/editing/deleting/delete-br-004-expected.png:
  • platform/chromium-mac/editing/deleting/delete-br-005-expected.png:
  • platform/chromium-mac/editing/deleting/delete-br-006-expected.png:
  • platform/chromium-mac/editing/deleting/delete-br-007-expected.png:
  • platform/chromium-mac/editing/deleting/delete-br-013-expected.png:
  • platform/chromium-mac/editing/deleting/delete-character-001-expected.png:
  • platform/chromium-mac/editing/deleting/delete-contiguous-ws-001-expected.png:
  • platform/chromium-mac/editing/deleting/delete-first-list-item-expected.png:
  • platform/chromium-mac/editing/deleting/delete-hr-expected.png:
  • platform/chromium-mac/editing/deleting/delete-image-001-expected.png:
  • platform/chromium-mac/editing/deleting/delete-image-002-expected.png:
  • platform/chromium-mac/editing/deleting/delete-image-003-expected.png:
  • platform/chromium-mac/editing/deleting/delete-image-004-expected.png:
  • platform/chromium-mac/editing/deleting/delete-leading-ws-001-expected.png:
  • platform/chromium-mac/editing/deleting/delete-line-015-expected.png:
  • platform/chromium-mac/editing/deleting/delete-line-016-expected.png:
  • platform/chromium-mac/editing/deleting/delete-line-017-expected.png:
  • platform/chromium-mac/editing/deleting/delete-line-end-ws-001-expected.png:
  • platform/chromium-mac/editing/deleting/delete-line-end-ws-002-expected.png:
  • platform/chromium-mac/editing/deleting/delete-listitem-001-expected.png:
  • platform/chromium-mac/editing/deleting/delete-listitem-002-expected.png:
  • platform/chromium-mac/editing/deleting/delete-selection-001-expected.png:
  • platform/chromium-mac/editing/deleting/delete-tab-001-expected.png:
  • platform/chromium-mac/editing/deleting/delete-tab-002-expected.png:
  • platform/chromium-mac/editing/deleting/delete-tab-003-expected.png:
  • platform/chromium-mac/editing/deleting/delete-tab-004-expected.png:
  • platform/chromium-mac/editing/deleting/delete-to-select-table-expected.png:
  • platform/chromium-mac/editing/deleting/delete-trailing-ws-001-expected.png:
  • platform/chromium-mac/editing/deleting/delete-trailing-ws-002-expected.png:
  • platform/chromium-mac/editing/deleting/delete-ws-fixup-001-expected.png:
  • platform/chromium-mac/editing/deleting/delete-ws-fixup-002-expected.png:
  • platform/chromium-mac/editing/deleting/delete-ws-fixup-003-expected.png:
  • platform/chromium-mac/editing/deleting/delete-ws-fixup-004-expected.png:
  • platform/chromium-mac/editing/deleting/list-item-1-expected.png:
  • platform/chromium-mac/editing/deleting/merge-different-styles-expected.png:
  • platform/chromium-mac/editing/deleting/merge-endOfParagraph-expected.png:
  • platform/chromium-mac/editing/deleting/merge-no-br-expected.png:
  • platform/chromium-mac/editing/deleting/merge-unrendered-space-expected.png:
  • platform/chromium-mac/editing/deleting/merge-whitespace-pre-expected.png:
  • platform/chromium-mac/editing/deleting/non-smart-delete-expected.png:
  • platform/chromium-mac/editing/deleting/pruning-after-merge-2-expected.png:
  • platform/chromium-mac/editing/deleting/smart-delete-001-expected.png:
  • platform/chromium-mac/editing/deleting/smart-delete-002-expected.png:
  • platform/chromium-mac/editing/deleting/smart-delete-003-expected.png:
  • platform/chromium-mac/editing/deleting/smart-delete-004-expected.png:
  • platform/chromium-mac/editing/deleting/table-cells-expected.png:
  • platform/chromium-mac/editing/deleting/type-delete-after-quote-expected.png:
  • platform/chromium-mac/editing/execCommand/4580583-1-expected.png:
  • platform/chromium-mac/editing/execCommand/4580583-2-expected.png:
  • platform/chromium-mac/editing/execCommand/4641880-1-expected.png:
  • platform/chromium-mac/editing/execCommand/4641880-2-expected.png:
  • platform/chromium-mac/editing/execCommand/4747450-expected.png:
  • platform/chromium-mac/editing/execCommand/4916402-expected.png:
  • platform/chromium-mac/editing/execCommand/4916541-expected.png:
  • platform/chromium-mac/editing/execCommand/4924441-expected.png:
  • platform/chromium-mac/editing/execCommand/5080333-1-expected.png:
  • platform/chromium-mac/editing/execCommand/5080333-2-expected.png:
  • platform/chromium-mac/editing/execCommand/5136770-expected.png:
  • platform/chromium-mac/editing/execCommand/5138441-expected.png:
  • platform/chromium-mac/editing/execCommand/5142012-1-expected.png:
  • platform/chromium-mac/editing/execCommand/5142012-2-expected.png:
  • platform/chromium-mac/editing/execCommand/5481523-expected.png:
  • platform/chromium-mac/editing/execCommand/5569741-expected.png:
  • platform/chromium-mac/editing/execCommand/create-list-with-hr-expected.png:
  • platform/chromium-mac/editing/execCommand/format-block-with-trailing-br-expected.png:
  • platform/chromium-mac/editing/execCommand/indent-empty-root-expected.png:
  • platform/chromium-mac/editing/execCommand/indent-list-item-expected.png:
  • platform/chromium-mac/editing/execCommand/indent-selection-expected.png:
  • platform/chromium-mac/editing/execCommand/insert-list-and-stitch-expected.png:
  • platform/chromium-mac/editing/execCommand/insertHorizontalRule-expected.png:
  • platform/chromium-mac/editing/execCommand/insertImage-expected.png:
  • platform/chromium-mac/editing/execCommand/nsresponder-indent-expected.png:
  • platform/chromium-mac/editing/execCommand/nsresponder-outdent-expected.png:
  • platform/chromium-mac/editing/execCommand/print-expected.png:
  • platform/chromium-mac/editing/execCommand/remove-list-from-range-selection-expected.png:
  • platform/chromium-mac/editing/execCommand/remove-list-item-1-expected.png:
  • platform/chromium-mac/editing/execCommand/selectAll-expected.png:
  • platform/chromium-mac/editing/input/caret-at-the-edge-of-contenteditable-expected.png:
  • platform/chromium-mac/editing/input/caret-at-the-edge-of-input-expected.png:
  • platform/chromium-mac/editing/input/reveal-caret-of-multiline-contenteditable-expected.png:
  • platform/chromium-mac/editing/input/reveal-caret-of-multiline-input-expected.png:
  • platform/chromium-mac/editing/inserting/12882-expected.png:
  • platform/chromium-mac/editing/inserting/4278698-expected.png:
  • platform/chromium-mac/editing/inserting/4840662-expected.png:
  • platform/chromium-mac/editing/inserting/4875189-1-expected.png:
  • platform/chromium-mac/editing/inserting/4875189-2-expected.png:
  • platform/chromium-mac/editing/inserting/4959067-expected.png:
  • platform/chromium-mac/editing/inserting/4960120-1-expected.png:
  • platform/chromium-mac/editing/inserting/4960120-2-expected.png:
  • platform/chromium-mac/editing/inserting/5002441-expected.png:
  • platform/chromium-mac/editing/inserting/5058163-1-expected.png:
  • platform/chromium-mac/editing/inserting/5058163-2-expected.png:
  • platform/chromium-mac/editing/inserting/5156401-2-expected.png:
  • platform/chromium-mac/editing/inserting/5418891-expected.png:
  • platform/chromium-mac/editing/inserting/5510537-expected.png:
  • platform/chromium-mac/editing/inserting/5549929-2-expected.png:
  • platform/chromium-mac/editing/inserting/5549929-3-expected.png:
  • platform/chromium-mac/editing/inserting/6703873-expected.png:
  • platform/chromium-mac/editing/inserting/before-after-input-element-expected.png:
  • platform/chromium-mac/editing/inserting/break-blockquote-after-delete-expected.png:
  • platform/chromium-mac/editing/inserting/editable-inline-element-expected.png:
  • platform/chromium-mac/editing/inserting/edited-whitespace-1-expected.png:
  • platform/chromium-mac/editing/inserting/editing-empty-divs-expected.png:
  • platform/chromium-mac/editing/inserting/insert-3775316-fix-expected.png:
  • platform/chromium-mac/editing/inserting/insert-3778059-fix-expected.png:
  • platform/chromium-mac/editing/inserting/insert-3800346-fix-expected.png:
  • platform/chromium-mac/editing/inserting/insert-after-delete-001-expected.png:
  • platform/chromium-mac/editing/inserting/insert-at-end-01-expected.png:
  • platform/chromium-mac/editing/inserting/insert-at-end-02-expected.png:
  • platform/chromium-mac/editing/inserting/insert-br-001-expected.png:
  • platform/chromium-mac/editing/inserting/insert-br-002-expected.png:
  • platform/chromium-mac/editing/inserting/insert-br-003-expected.png:
  • platform/chromium-mac/editing/inserting/insert-br-004-expected.png:
  • platform/chromium-mac/editing/inserting/insert-br-005-expected.png:
  • platform/chromium-mac/editing/inserting/insert-br-006-expected.png:
  • platform/chromium-mac/editing/inserting/insert-br-007-expected.png:
  • platform/chromium-mac/editing/inserting/insert-br-008-expected.png:
  • platform/chromium-mac/editing/inserting/insert-br-009-expected.png:
  • platform/chromium-mac/editing/inserting/insert-br-at-tabspan-001-expected.png:
  • platform/chromium-mac/editing/inserting/insert-br-at-tabspan-002-expected.png:
  • platform/chromium-mac/editing/inserting/insert-br-at-tabspan-003-expected.png:
  • platform/chromium-mac/editing/inserting/insert-br-quoted-001-expected.png:
  • platform/chromium-mac/editing/inserting/insert-br-quoted-002-expected.png:
  • platform/chromium-mac/editing/inserting/insert-br-quoted-003-expected.png:
  • platform/chromium-mac/editing/inserting/insert-br-quoted-004-expected.png:
  • platform/chromium-mac/editing/inserting/insert-br-quoted-005-expected.png:
  • platform/chromium-mac/editing/inserting/insert-br-quoted-006-expected.png:
  • platform/chromium-mac/editing/inserting/insert-div-025-expected.png:
  • platform/chromium-mac/editing/inserting/insert-div-026-expected.png:
  • platform/chromium-mac/editing/inserting/insert-paragraph-01-expected.png:
  • platform/chromium-mac/editing/inserting/insert-paragraph-02-expected.png:
  • platform/chromium-mac/editing/inserting/insert-paragraph-03-expected.png:
  • platform/chromium-mac/editing/inserting/insert-paragraph-04-expected.png:
  • platform/chromium-mac/editing/inserting/insert-paragraph-05-expected.png:
  • platform/chromium-mac/editing/inserting/insert-space-in-empty-doc-expected.png:
  • platform/chromium-mac/editing/inserting/insert-tab-001-expected.png:
  • platform/chromium-mac/editing/inserting/insert-tab-002-expected.png:
  • platform/chromium-mac/editing/inserting/insert-tab-003-expected.png:
  • platform/chromium-mac/editing/inserting/insert-tab-004-expected.png:
  • platform/chromium-mac/editing/inserting/insert-text-at-tabspan-001-expected.png:
  • platform/chromium-mac/editing/inserting/insert-text-at-tabspan-002-expected.png:
  • platform/chromium-mac/editing/inserting/insert-text-at-tabspan-003-expected.png:
  • platform/chromium-mac/editing/inserting/insert-text-with-newlines-expected.png:
  • platform/chromium-mac/editing/inserting/line-break-expected.png:
  • platform/chromium-mac/editing/inserting/multiple-lines-selected-expected.png:
  • platform/chromium-mac/editing/inserting/paragraph-separator-01-expected.png:
  • platform/chromium-mac/editing/inserting/paragraph-separator-02-expected.png:
  • platform/chromium-mac/editing/inserting/paragraph-separator-03-expected.png:
  • platform/chromium-mac/editing/inserting/paragraph-separator-in-table-1-expected.png:
  • platform/chromium-mac/editing/inserting/paragraph-separator-in-table-2-expected.png:
  • platform/chromium-mac/editing/inserting/redo-expected.png:
  • platform/chromium-mac/editing/inserting/return-key-with-selection-001-expected.png:
  • platform/chromium-mac/editing/inserting/return-key-with-selection-002-expected.png:
  • platform/chromium-mac/editing/inserting/return-key-with-selection-003-expected.png:
  • platform/chromium-mac/editing/inserting/typing-001-expected.png:
  • platform/chromium-mac/editing/inserting/typing-002-expected.png:
  • platform/chromium-mac/editing/inserting/typing-003-expected.png:
  • platform/chromium-mac/editing/inserting/typing-around-br-001-expected.png:
  • platform/chromium-mac/editing/inserting/typing-around-image-001-expected.png:
  • platform/chromium-mac/editing/inserting/typing-at-end-of-line-expected.png:
  • platform/chromium-mac/editing/pasteboard/3976872-expected.png:
  • platform/chromium-mac/editing/pasteboard/4076267-2-expected.png:
  • platform/chromium-mac/editing/pasteboard/4076267-3-expected.png:
  • platform/chromium-mac/editing/pasteboard/4076267-expected.png:
  • platform/chromium-mac/editing/pasteboard/4242293-expected.png:
  • platform/chromium-mac/editing/pasteboard/4631972-expected.png:
  • platform/chromium-mac/editing/pasteboard/4641033-expected.png:
  • platform/chromium-mac/editing/pasteboard/4806874-expected.png:
  • platform/chromium-mac/editing/pasteboard/4944770-1-expected.png:
  • platform/chromium-mac/editing/pasteboard/4944770-2-expected.png:
  • platform/chromium-mac/editing/pasteboard/4947130-expected.png:
  • platform/chromium-mac/editing/pasteboard/5006779-expected.png:
  • platform/chromium-mac/editing/pasteboard/5032095-expected.png:
  • platform/chromium-mac/editing/pasteboard/5071074-2-expected.png:
  • platform/chromium-mac/editing/pasteboard/5071074-expected.png:
  • platform/chromium-mac/editing/pasteboard/5075944-expected.png:
  • platform/chromium-mac/editing/pasteboard/5134759-expected.png:
  • platform/chromium-mac/editing/pasteboard/5156401-1-expected.png:
  • platform/chromium-mac/editing/pasteboard/5247341-expected.png:
  • platform/chromium-mac/editing/pasteboard/5387578-expected.png:
  • platform/chromium-mac/editing/pasteboard/5478250-expected.png:
  • platform/chromium-mac/editing/pasteboard/5601583-1-expected.png:
  • platform/chromium-mac/editing/pasteboard/8145-1-expected.png:
  • platform/chromium-mac/editing/pasteboard/8145-2-expected.png:
  • platform/chromium-mac/editing/pasteboard/8145-3-expected.png:
  • platform/chromium-mac/editing/pasteboard/bad-placeholder-expected.png:
  • platform/chromium-mac/editing/pasteboard/copy-standalone-image-expected.png:
  • platform/chromium-mac/editing/pasteboard/cut-text-001-expected.png:
  • platform/chromium-mac/editing/pasteboard/displaced-generic-placeholder-expected.png:
  • platform/chromium-mac/editing/pasteboard/displaced-placeholder-expected.png:
  • platform/chromium-mac/editing/pasteboard/drag-drop-modifies-page-expected.png:
  • platform/chromium-mac/editing/pasteboard/drag-selected-image-to-contenteditable-expected.png:
  • platform/chromium-mac/editing/pasteboard/drop-text-without-selection-expected.png:
  • platform/chromium-mac/editing/pasteboard/innerText-inline-table-expected.png:
  • platform/chromium-mac/editing/pasteboard/input-field-1-expected.png:
  • platform/chromium-mac/editing/pasteboard/merge-after-delete-1-expected.png:
  • platform/chromium-mac/editing/pasteboard/merge-after-delete-2-expected.png:
  • platform/chromium-mac/editing/pasteboard/merge-after-delete-expected.png:
  • platform/chromium-mac/editing/pasteboard/merge-end-blockquote-expected.png:
  • platform/chromium-mac/editing/pasteboard/merge-end-borders-expected.png:
  • platform/chromium-mac/editing/pasteboard/merge-start-blockquote-expected.png:
  • platform/chromium-mac/editing/pasteboard/merge-start-list-expected.png:
  • platform/chromium-mac/editing/pasteboard/paste-4035648-fix-expected.png:
  • platform/chromium-mac/editing/pasteboard/paste-4038267-fix-expected.png:
  • platform/chromium-mac/editing/pasteboard/paste-blockquote-after-blockquote-expected.png:
  • platform/chromium-mac/editing/pasteboard/paste-blockquote-into-blockquote-4-expected.png:
  • platform/chromium-mac/editing/pasteboard/paste-line-endings-001-expected.png:
  • platform/chromium-mac/editing/pasteboard/paste-line-endings-002-expected.png:
  • platform/chromium-mac/editing/pasteboard/paste-line-endings-003-expected.png:
  • platform/chromium-mac/editing/pasteboard/paste-line-endings-004-expected.png:
  • platform/chromium-mac/editing/pasteboard/paste-line-endings-005-expected.png:
  • platform/chromium-mac/editing/pasteboard/paste-line-endings-006-expected.png:
  • platform/chromium-mac/editing/pasteboard/paste-line-endings-007-expected.png:
  • platform/chromium-mac/editing/pasteboard/paste-line-endings-008-expected.png:
  • platform/chromium-mac/editing/pasteboard/paste-line-endings-009-expected.png:
  • platform/chromium-mac/editing/pasteboard/paste-line-endings-010-expected.png:
  • platform/chromium-mac/editing/pasteboard/paste-match-style-001-expected.png:
  • platform/chromium-mac/editing/pasteboard/paste-match-style-002-expected.png:
  • platform/chromium-mac/editing/pasteboard/paste-text-019-expected.png:
  • platform/chromium-mac/editing/pasteboard/paste-text-at-tabspan-003-expected.png:
  • platform/chromium-mac/editing/pasteboard/pasting-object-expected.png:
  • platform/chromium-mac/editing/pasteboard/pasting-tabs-expected.png:
  • platform/chromium-mac/editing/pasteboard/quirks-mode-br-1-expected.png:
  • platform/chromium-mac/editing/pasteboard/smart-drag-drop-expected.png:
  • platform/chromium-mac/editing/pasteboard/smart-paste-007-expected.png:
  • platform/chromium-mac/editing/pasteboard/smart-paste-008-expected.png:
  • platform/chromium-mac/editing/pasteboard/styled-element-markup-expected.png:
  • platform/chromium-mac/editing/pasteboard/undoable-fragment-removes-expected.png:
  • platform/chromium-mac/editing/pasteboard/unrendered-br-expected.png:
  • platform/chromium-mac/editing/selection/13804-expected.png:
  • platform/chromium-mac/editing/selection/3690703-2-expected.png:
  • platform/chromium-mac/editing/selection/3690703-expected.png:
  • platform/chromium-mac/editing/selection/3690719-expected.png:
  • platform/chromium-mac/editing/selection/4397952-expected.png:
  • platform/chromium-mac/editing/selection/4402375-expected.png:
  • platform/chromium-mac/editing/selection/4818145-expected.png:
  • platform/chromium-mac/editing/selection/4866671-expected.png:
  • platform/chromium-mac/editing/selection/4889598-expected.png:
  • platform/chromium-mac/editing/selection/4895428-2-expected.png:
  • platform/chromium-mac/editing/selection/4895428-3-expected.png:
  • platform/chromium-mac/editing/selection/4932260-1-expected.png:
  • platform/chromium-mac/editing/selection/4932260-2-expected.png:
  • platform/chromium-mac/editing/selection/4932260-3-expected.png:
  • platform/chromium-mac/editing/selection/4947387-expected.png:
  • platform/chromium-mac/editing/selection/5007143-2-expected.png:
  • platform/chromium-mac/editing/selection/5007143-expected.png:
  • platform/chromium-mac/editing/selection/5057506-2-expected.png:
  • platform/chromium-mac/editing/selection/5057506-expected.png:
  • platform/chromium-mac/editing/selection/5076323-1-expected.png:
  • platform/chromium-mac/editing/selection/5076323-2-expected.png:
  • platform/chromium-mac/editing/selection/5076323-3-expected.png:
  • platform/chromium-mac/editing/selection/5099303-expected.png:
  • platform/chromium-mac/editing/selection/5131716-1-expected.png:
  • platform/chromium-mac/editing/selection/5131716-2-expected.png:
  • platform/chromium-mac/editing/selection/5131716-3-expected.png:
  • platform/chromium-mac/editing/selection/5131716-4-expected.png:
  • platform/chromium-mac/editing/selection/5195166-2-expected.png:
  • platform/chromium-mac/editing/selection/5234383-1-expected.png:
  • platform/chromium-mac/editing/selection/5234383-2-expected.png:
  • platform/chromium-mac/editing/selection/5240265-expected.png:
  • platform/chromium-mac/editing/selection/6476-expected.png:
  • platform/chromium-mac/editing/selection/after-line-wrap-expected.png:
  • platform/chromium-mac/editing/selection/caret-before-select-expected.png:
  • platform/chromium-mac/editing/selection/caret-ltr-2-expected.png:
  • platform/chromium-mac/editing/selection/caret-ltr-2-left-expected.png:
  • platform/chromium-mac/editing/selection/caret-ltr-expected.png:
  • platform/chromium-mac/editing/selection/caret-ltr-right-expected.png:
  • platform/chromium-mac/editing/selection/caret-rtl-2-expected.png:
  • platform/chromium-mac/editing/selection/caret-rtl-2-left-expected.png:
  • platform/chromium-mac/editing/selection/caret-rtl-expected.png:
  • platform/chromium-mac/editing/selection/caret-rtl-right-expected.png:
  • platform/chromium-mac/editing/selection/click-start-of-line-expected.png:
  • platform/chromium-mac/editing/selection/contains-boundaries-expected.png:
  • platform/chromium-mac/editing/selection/contenteditable-click-inside-expected.png:
  • platform/chromium-mac/editing/selection/drag-select-1-expected.png:
  • platform/chromium-mac/editing/selection/drag-to-contenteditable-iframe-expected.png:
  • platform/chromium-mac/editing/selection/editable-non-editable-crash-expected.png:
  • platform/chromium-mac/editing/selection/end-of-document-expected.png:
  • platform/chromium-mac/editing/selection/expanding-selections-expected.png:
  • platform/chromium-mac/editing/selection/expanding-selections2-expected.png:
  • platform/chromium-mac/editing/selection/extend-by-character-001-expected.png:
  • platform/chromium-mac/editing/selection/extend-by-character-002-expected.png:
  • platform/chromium-mac/editing/selection/extend-by-character-003-expected.png:
  • platform/chromium-mac/editing/selection/extend-by-character-004-expected.png:
  • platform/chromium-mac/editing/selection/extend-by-character-005-expected.png:
  • platform/chromium-mac/editing/selection/extend-by-character-006-expected.png:
  • platform/chromium-mac/editing/selection/extend-by-sentence-001-expected.png:
  • platform/chromium-mac/editing/selection/extend-by-word-001-expected.png:
  • platform/chromium-mac/editing/selection/extend-by-word-002-expected.png:
  • platform/chromium-mac/editing/selection/extend-inside-transforms-backward-expected.png:
  • platform/chromium-mac/editing/selection/extend-inside-transforms-forward-expected.png:
  • platform/chromium-mac/editing/selection/extend-selection-bidi-expected.png:
  • platform/chromium-mac/editing/selection/fake-doubleclick-expected.png:
  • platform/chromium-mac/editing/selection/iframe-expected.png:
  • platform/chromium-mac/editing/selection/image-before-linebreak-expected.png:
  • platform/chromium-mac/editing/selection/inline-table-expected.png:
  • platform/chromium-mac/editing/selection/leave-requested-block-expected.png:
  • platform/chromium-mac/editing/selection/mixed-editability-3-expected.png:
  • platform/chromium-mac/editing/selection/mixed-editability-4-expected.png:
  • platform/chromium-mac/editing/selection/mixed-editability-5-expected.png:
  • platform/chromium-mac/editing/selection/mixed-editability-6-expected.png:
  • platform/chromium-mac/editing/selection/mixed-editability-7-expected.png:
  • platform/chromium-mac/editing/selection/mixed-editability-8-expected.png:
  • platform/chromium-mac/editing/selection/mixed-editability-9-expected.png:
  • platform/chromium-mac/editing/selection/move-backwords-by-word-001-expected.png:
  • platform/chromium-mac/editing/selection/move-between-blocks-no-001-expected.png:
  • platform/chromium-mac/editing/selection/move-by-character-001-expected.png:
  • platform/chromium-mac/editing/selection/move-by-character-002-expected.png:
  • platform/chromium-mac/editing/selection/move-by-character-003-expected.png:
  • platform/chromium-mac/editing/selection/move-by-character-004-expected.png:
  • platform/chromium-mac/editing/selection/move-by-character-005-expected.png:
  • platform/chromium-mac/editing/selection/move-by-character-6-expected.png:
  • platform/chromium-mac/editing/selection/move-by-line-001-expected.png:
  • platform/chromium-mac/editing/selection/move-by-line-002-expected.png:
  • platform/chromium-mac/editing/selection/move-by-sentence-001-expected.png:
  • platform/chromium-mac/editing/selection/move-by-sentence-linebreak-expected.png:
  • platform/chromium-mac/editing/selection/move-by-word-001-expected.png:
  • platform/chromium-mac/editing/selection/move-past-trailing-space-expected.png:
  • platform/chromium-mac/editing/selection/previous-line-position-expected.png:
  • platform/chromium-mac/editing/selection/replace-selection-1-expected.png:
  • platform/chromium-mac/editing/selection/replaced-boundaries-1-expected.png:
  • platform/chromium-mac/editing/selection/replaced-boundaries-2-expected.png:
  • platform/chromium-mac/editing/selection/replaced-boundaries-3-expected.png:
  • platform/chromium-mac/editing/selection/select-across-readonly-input-1-expected.png:
  • platform/chromium-mac/editing/selection/select-across-readonly-input-2-expected.png:
  • platform/chromium-mac/editing/selection/select-across-readonly-input-3-expected.png:
  • platform/chromium-mac/editing/selection/select-across-readonly-input-4-expected.png:
  • platform/chromium-mac/editing/selection/select-across-readonly-input-5-expected.png:
  • platform/chromium-mac/editing/selection/select-all-001-expected.png:
  • platform/chromium-mac/editing/selection/select-all-002-expected.png:
  • platform/chromium-mac/editing/selection/select-all-iframe-expected.png:
  • platform/chromium-mac/editing/selection/select-box-expected.png:
  • platform/chromium-mac/editing/selection/select-element-paragraph-boundary-expected.png:
  • platform/chromium-mac/editing/selection/select-from-textfield-outwards-expected.png:
  • platform/chromium-mac/editing/selection/select-missing-image-expected.png:
  • platform/chromium-mac/editing/selection/selectNode-expected.png:
  • platform/chromium-mac/editing/selection/selectNodeContents-expected.png:
  • platform/chromium-mac/editing/selection/selection-3748164-fix-expected.png:
  • platform/chromium-mac/editing/selection/selection-button-text-expected.png:
  • platform/chromium-mac/editing/selection/table-caret-1-expected.png:
  • platform/chromium-mac/editing/selection/table-caret-2-expected.png:
  • platform/chromium-mac/editing/selection/table-caret-3-expected.png:
  • platform/chromium-mac/editing/selection/transformed-selection-rects-expected.png:
  • platform/chromium-mac/editing/selection/triple-click-in-pre-expected.png:
  • platform/chromium-mac/editing/selection/unrendered-001-expected.png:
  • platform/chromium-mac/editing/selection/unrendered-002-expected.png:
  • platform/chromium-mac/editing/selection/unrendered-003-expected.png:
  • platform/chromium-mac/editing/selection/unrendered-004-expected.png:
  • platform/chromium-mac/editing/selection/unrendered-005-expected.png:
  • platform/chromium-mac/editing/selection/unrendered-space-expected.png:
  • platform/chromium-mac/editing/selection/vertical-rl-rtl-extend-line-backward-br-expected.png:
  • platform/chromium-mac/editing/selection/vertical-rl-rtl-extend-line-backward-p-expected.png:
  • platform/chromium-mac/editing/selection/vertical-rl-rtl-extend-line-forward-br-expected.png:
  • platform/chromium-mac/editing/selection/vertical-rl-rtl-extend-line-forward-p-expected.png:
  • platform/chromium-mac/editing/selection/wrapped-line-caret-1-expected.png:
  • platform/chromium-mac/editing/selection/wrapped-line-caret-2-expected.png:
  • platform/chromium-mac/editing/spelling/grammar-markers-expected.png:
  • platform/chromium-mac/editing/spelling/grammar-markers-hidpi-expected.png:
  • platform/chromium-mac/editing/spelling/spelling-expected.png:
  • platform/chromium-mac/editing/style/4916887-expected.png:
  • platform/chromium-mac/editing/style/5017613-1-expected.png:
  • platform/chromium-mac/editing/style/5017613-2-expected.png:
  • platform/chromium-mac/editing/style/5046875-1-expected.png:
  • platform/chromium-mac/editing/style/5046875-2-expected.png:
  • platform/chromium-mac/editing/style/5065910-expected.png:
  • platform/chromium-mac/editing/style/5084241-expected.png:
  • platform/chromium-mac/editing/style/5228141-expected.png:
  • platform/chromium-mac/editing/style/5279521-expected.png:
  • platform/chromium-mac/editing/style/block-styles-007-expected.png:
  • platform/chromium-mac/editing/style/highlight-expected.png:
  • platform/chromium-mac/editing/style/smoosh-styles-001-expected.png:
  • platform/chromium-mac/editing/style/smoosh-styles-003-expected.png:
  • platform/chromium-mac/editing/style/style-3681552-fix-001-expected.png:
  • platform/chromium-mac/editing/style/style-3681552-fix-002-expected.png:
  • platform/chromium-mac/editing/style/style-3998892-fix-expected.png:
  • platform/chromium-mac/editing/style/style-boundary-001-expected.png:
  • platform/chromium-mac/editing/style/style-boundary-002-expected.png:
  • platform/chromium-mac/editing/style/style-boundary-003-expected.png:
  • platform/chromium-mac/editing/style/style-boundary-004-expected.png:
  • platform/chromium-mac/editing/style/style-boundary-005-expected.png:
  • platform/chromium-mac/editing/style/typing-style-001-expected.png:
  • platform/chromium-mac/editing/style/typing-style-002-expected.png:
  • platform/chromium-mac/editing/style/unbold-in-bold-expected.png:
  • platform/chromium-mac/editing/undo/4063751-expected.png:
  • platform/chromium-mac/editing/undo/5378473-expected.png:
  • platform/chromium-mac/editing/undo/redo-typing-001-expected.png:
  • platform/chromium-mac/editing/undo/undo-combined-delete-boundary-expected.png:
  • platform/chromium-mac/editing/undo/undo-combined-delete-expected.png:
  • platform/chromium-mac/editing/undo/undo-delete-boundary-expected.png:
  • platform/chromium-mac/editing/undo/undo-delete-expected.png:
  • platform/chromium-mac/editing/undo/undo-forward-delete-boundary-expected.png:
  • platform/chromium-mac/editing/undo/undo-forward-delete-expected.png:
  • platform/chromium-mac/editing/undo/undo-misspellings-expected.png:
  • platform/chromium-mac/editing/undo/undo-typing-001-expected.png:
  • platform/chromium-mac/editing/unsupported-content/list-delete-001-expected.png:
  • platform/chromium-mac/editing/unsupported-content/list-delete-003-expected.png:
  • platform/chromium-mac/editing/unsupported-content/list-type-after-expected.png:
  • platform/chromium-mac/editing/unsupported-content/list-type-before-expected.png:
  • platform/chromium-mac/editing/unsupported-content/table-delete-001-expected.png:
  • platform/chromium-mac/editing/unsupported-content/table-delete-002-expected.png:
  • platform/chromium-mac/editing/unsupported-content/table-delete-003-expected.png:
  • platform/chromium-mac/editing/unsupported-content/table-type-after-expected.png:
  • platform/chromium-mac/editing/unsupported-content/table-type-before-expected.png:
  • platform/chromium-win/editing/deleting/delete-first-list-item-expected.png:
  • platform/chromium-win/editing/deleting/delete-listitem-002-expected.png:
  • platform/chromium-win/editing/deleting/list-item-1-expected.png:
  • platform/chromium-win/editing/execCommand/4641880-1-expected.png:
  • platform/chromium-win/editing/execCommand/4747450-expected.png:
  • platform/chromium-win/editing/execCommand/4916402-expected.png:
  • platform/chromium-win/editing/execCommand/5136770-expected.png:
  • platform/chromium-win/editing/execCommand/5142012-2-expected.png:
  • platform/chromium-win/editing/execCommand/5569741-expected.png:
  • platform/chromium-win/editing/execCommand/create-list-with-hr-expected.png:
  • platform/chromium-win/editing/execCommand/indent-list-item-expected.png:
  • platform/chromium-win/editing/execCommand/remove-list-item-1-expected.png:
  • platform/chromium-win/editing/inserting/4875189-1-expected.png:
  • platform/chromium-win/editing/inserting/4959067-expected.png:
  • platform/chromium-win/editing/pasteboard/drag-selected-image-to-contenteditable-expected.png:
  • platform/chromium-win/editing/pasteboard/innerText-inline-table-expected.png:
  • platform/chromium-win/editing/pasteboard/input-field-1-expected.png:
  • platform/chromium-win/editing/pasteboard/merge-start-list-expected.png:
  • platform/chromium-win/editing/selection/4402375-expected.png:
  • platform/chromium-win/editing/selection/4895428-2-expected.png:
  • platform/chromium-win/editing/selection/drag-to-contenteditable-iframe-expected.png:
  • platform/chromium-win/editing/selection/extend-by-word-002-expected.png:
  • platform/chromium-win/editing/selection/extend-inside-transforms-backward-expected.png:
  • platform/chromium-win/editing/selection/extend-inside-transforms-forward-expected.png:
  • platform/chromium-win/editing/selection/image-before-linebreak-expected.png:
  • platform/chromium-win/editing/selection/replaced-boundaries-1-expected.png:
  • platform/chromium-win/editing/selection/replaced-boundaries-2-expected.png:
  • platform/chromium-win/editing/selection/replaced-boundaries-3-expected.png:
  • platform/chromium-win/editing/selection/select-all-iframe-expected.png:
  • platform/chromium-win/editing/selection/selectNode-expected.png:
  • platform/chromium-win/editing/selection/selectNodeContents-expected.png:
  • platform/chromium-win/editing/selection/transformed-selection-rects-expected.png:
  • platform/chromium-win/editing/spelling/grammar-markers-hidpi-expected.png:
  • platform/chromium-win/editing/unsupported-content/list-delete-001-expected.png:
  • platform/chromium-win/editing/unsupported-content/list-type-after-expected.png:
  • platform/chromium-win/editing/unsupported-content/list-type-before-expected.png:
9:38 AM Changeset in webkit [135530] by commit-queue@webkit.org
  • 2 edits in trunk/Source/Platform

[Chromium] Add GL_CHROMIUM_pixel_transfer_buffer_object extension support.
https://bugs.webkit.org/show_bug.cgi?id=102528

Patch by David Reveman <reveman@chromium.org> on 2012-11-22
Reviewed by James Robinson.

Add mapBufferCHROMIUM and unmapBufferCHROMIUM prototypes to WebGraphicsContext3D.h.

  • chromium/public/WebGraphicsContext3D.h:

(WebGraphicsContext3D):
(WebKit::WebGraphicsContext3D::mapBufferCHROMIUM):
(WebKit::WebGraphicsContext3D::unmapBufferCHROMIUM):

9:34 AM Changeset in webkit [135529] by Antti Koivisto
  • 22 edits
    2 deletes in trunk/Source/WebCore

Merge EditingText into Text
https://bugs.webkit.org/show_bug.cgi?id=103060

Reviewed by Ryosuke Niwa.

Remove the EditingText class. Its only function beyond the regular Text is that it always creates a renderer.
It can be replaced with a bit.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/CDATASection.cpp:

(WebCore::CDATASection::CDATASection):

  • dom/Document.cpp:

(WebCore::Document::createEditingTextNode):

  • dom/Document.h:

(WebCore):
(Document):

  • dom/EditingText.cpp: Removed.
  • dom/EditingText.h: Removed.
  • dom/Node.h:

(WebCore::Node::hasName):
(WebCore::Node::isEditingText):
(WebCore::Node::setHasName):

Use the same bit as hasName() which is Element specific.

  • dom/Text.cpp:

(WebCore::Text::create):
(WebCore):
(WebCore::Text::createEditingText):
(WebCore::Text::rendererIsNeeded):

  • dom/Text.h:

(Text):
(WebCore::Text::Text):

  • editing/Editor.cpp:
  • editing/InsertTextCommand.cpp:
  • editing/ReplaceSelectionCommand.cpp:
  • editing/htmlediting.cpp:
  • editing/mac/EditorMac.mm:
  • page/Frame.cpp:
9:30 AM Changeset in webkit [135528] by danakj@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] Add OS!="ios" to guard for gcc_version in WebKit.gyp
https://bugs.webkit.org/show_bug.cgi?id=103007

Reviewed by Adam Barth.

This matches the guards used in chromium's chrome/chrome_browser.gypi.

  • WebKit.gyp:
9:03 AM Changeset in webkit [135527] by schenney@chromium.org
  • 377 edits
    6 deletes in trunk/LayoutTests

[Chromium] Test expectations update after enabling Skia changes.

Unreviewed Chromium expectations update.

Partial update, covering all css tests. Many more to come.

  • platform/chromium-mac-lion/css1/box_properties/border_left-expected.png:
  • platform/chromium-mac-lion/css1/box_properties/border_right_inline-expected.png:
  • platform/chromium-mac-lion/css1/box_properties/border_top-expected.png:
  • platform/chromium-mac-lion/css1/box_properties/clear_float-expected.png:
  • platform/chromium-mac-lion/css1/box_properties/float_elements_in_series-expected.png:
  • platform/chromium-mac-lion/css1/box_properties/float_on_text_elements-expected.png:
  • platform/chromium-mac-lion/css1/box_properties/margin_left-expected.png:
  • platform/chromium-mac-lion/css1/box_properties/margin_right-expected.png:
  • platform/chromium-mac-lion/css1/box_properties/padding_left-expected.png:
  • platform/chromium-mac-lion/css1/box_properties/padding_right-expected.png:
  • platform/chromium-mac-lion/css1/cascade/cascade_order-expected.png:
  • platform/chromium-mac-lion/css1/classification/list_style_image-expected.png:
  • platform/chromium-mac-lion/css1/classification/list_style_position-expected.png:
  • platform/chromium-mac-lion/css1/classification/list_style_type-expected.png:
  • platform/chromium-mac-lion/css1/pseudo/anchor-expected.png:
  • platform/chromium-mac-lion/css1/text_properties/text_align-expected.png:
  • platform/chromium-mac-lion/css2.1/20110323/margin-applies-to-010-expected.png:
  • platform/chromium-mac-lion/css2.1/20110323/replaced-intrinsic-ratio-001-expected.png:
  • platform/chromium-mac-lion/css2.1/t0402-c71-fwd-parsing-02-f-expected.png:
  • platform/chromium-mac-lion/css2.1/t0505-c16-descendant-01-e-expected.png:
  • platform/chromium-mac-lion/css2.1/t050803-c14-classes-00-e-expected.png:
  • platform/chromium-mac-lion/css2.1/t0509-c15-ids-01-e-expected.png:
  • platform/chromium-mac-lion/css2.1/t0805-c5517-brdr-s-00-c-expected.png:
  • platform/chromium-mac-lion/css2.1/t0805-c5518-brdr-t-01-e-expected.png:
  • platform/chromium-mac-lion/css2.1/t0805-c5519-brdr-r-02-e-expected.png:
  • platform/chromium-mac-lion/css2.1/t0805-c5520-brdr-b-01-e-expected.png:
  • platform/chromium-mac-lion/css2.1/t0805-c5521-brdr-l-02-e-expected.png:
  • platform/chromium-mac-lion/css2.1/t0905-c5525-fltcont-00-d-g-expected.png:
  • platform/chromium-mac-lion/css2.1/t0905-c5525-fltwidth-00-c-g-expected.png:
  • platform/chromium-mac-lion/css2.1/t1202-counter-04-b-expected.png:
  • platform/chromium-mac-lion/css2.1/t1202-counters-04-b-expected.png:
  • platform/chromium-mac-lion/css2.1/t1205-c563-list-type-00-b-expected.png:
  • platform/chromium-mac-lion/css2.1/t1205-c564-list-img-00-b-g-expected.png:
  • platform/chromium-mac-lion/css2.1/t1602-c546-txt-align-00-b-expected.png:
  • platform/chromium-mac-lion/css3/selectors3/html/css3-modsel-1-expected.png:
  • platform/chromium-mac-lion/css3/selectors3/html/css3-modsel-13-expected.png:
  • platform/chromium-mac-lion/css3/selectors3/html/css3-modsel-15-expected.png:
  • platform/chromium-mac-lion/css3/selectors3/html/css3-modsel-161-expected.png:
  • platform/chromium-mac-lion/css3/selectors3/html/css3-modsel-19b-expected.png:
  • platform/chromium-mac-lion/css3/selectors3/html/css3-modsel-22-expected.png:
  • platform/chromium-mac-lion/css3/selectors3/html/css3-modsel-23-expected.png:
  • platform/chromium-mac-lion/css3/selectors3/html/css3-modsel-24-expected.png:
  • platform/chromium-mac-lion/css3/selectors3/html/css3-modsel-28-expected.png:
  • platform/chromium-mac-lion/css3/selectors3/html/css3-modsel-28b-expected.png:
  • platform/chromium-mac-lion/css3/selectors3/html/css3-modsel-29-expected.png:
  • platform/chromium-mac-lion/css3/selectors3/html/css3-modsel-29b-expected.png:
  • platform/chromium-mac-lion/css3/selectors3/html/css3-modsel-3a-expected.png:
  • platform/chromium-mac-lion/css3/selectors3/html/css3-modsel-64-expected.png:
  • platform/chromium-mac-lion/css3/selectors3/html/css3-modsel-68-expected.png:
  • platform/chromium-mac-lion/css3/selectors3/html/css3-modsel-69-expected.png:
  • platform/chromium-mac-lion/css3/selectors3/html/css3-modsel-73-expected.png:
  • platform/chromium-mac-lion/css3/selectors3/html/css3-modsel-73b-expected.png:
  • platform/chromium-mac-lion/css3/selectors3/html/css3-modsel-74-expected.png:
  • platform/chromium-mac-lion/css3/selectors3/html/css3-modsel-74b-expected.png:
  • platform/chromium-mac-lion/css3/selectors3/xhtml/css3-modsel-1-expected.png:
  • platform/chromium-mac-lion/css3/selectors3/xhtml/css3-modsel-13-expected.png:
  • platform/chromium-mac-lion/css3/selectors3/xhtml/css3-modsel-15-expected.png:
  • platform/chromium-mac-lion/css3/selectors3/xhtml/css3-modsel-161-expected.png:
  • platform/chromium-mac-lion/css3/selectors3/xhtml/css3-modsel-19b-expected.png:
  • platform/chromium-mac-lion/css3/selectors3/xhtml/css3-modsel-22-expected.png:
  • platform/chromium-mac-lion/css3/selectors3/xhtml/css3-modsel-23-expected.png:
  • platform/chromium-mac-lion/css3/selectors3/xhtml/css3-modsel-24-expected.png:
  • platform/chromium-mac-lion/css3/selectors3/xhtml/css3-modsel-28-expected.png:
  • platform/chromium-mac-lion/css3/selectors3/xhtml/css3-modsel-28b-expected.png:
  • platform/chromium-mac-lion/css3/selectors3/xhtml/css3-modsel-29-expected.png:
  • platform/chromium-mac-lion/css3/selectors3/xhtml/css3-modsel-29b-expected.png:
  • platform/chromium-mac-lion/css3/selectors3/xhtml/css3-modsel-3-expected.png:
  • platform/chromium-mac-lion/css3/selectors3/xhtml/css3-modsel-3a-expected.png:
  • platform/chromium-mac-lion/css3/selectors3/xhtml/css3-modsel-64-expected.png:
  • platform/chromium-mac-lion/css3/selectors3/xhtml/css3-modsel-68-expected.png:
  • platform/chromium-mac-lion/css3/selectors3/xhtml/css3-modsel-69-expected.png:
  • platform/chromium-mac-lion/css3/selectors3/xhtml/css3-modsel-73-expected.png:
  • platform/chromium-mac-lion/css3/selectors3/xhtml/css3-modsel-73b-expected.png:
  • platform/chromium-mac-lion/css3/selectors3/xhtml/css3-modsel-74-expected.png:
  • platform/chromium-mac-lion/css3/selectors3/xhtml/css3-modsel-74b-expected.png:
  • platform/chromium-mac-lion/css3/selectors3/xml/css3-modsel-1-expected.png:
  • platform/chromium-mac-lion/css3/selectors3/xml/css3-modsel-13-expected.png:
  • platform/chromium-mac-lion/css3/selectors3/xml/css3-modsel-15-expected.png:
  • platform/chromium-mac-lion/css3/selectors3/xml/css3-modsel-161-expected.png:
  • platform/chromium-mac-lion/css3/selectors3/xml/css3-modsel-19b-expected.png:
  • platform/chromium-mac-lion/css3/selectors3/xml/css3-modsel-22-expected.png:
  • platform/chromium-mac-lion/css3/selectors3/xml/css3-modsel-23-expected.png:
  • platform/chromium-mac-lion/css3/selectors3/xml/css3-modsel-24-expected.png:
  • platform/chromium-mac-lion/css3/selectors3/xml/css3-modsel-28-expected.png:
  • platform/chromium-mac-lion/css3/selectors3/xml/css3-modsel-28b-expected.png:
  • platform/chromium-mac-lion/css3/selectors3/xml/css3-modsel-29-expected.png:
  • platform/chromium-mac-lion/css3/selectors3/xml/css3-modsel-29b-expected.png:
  • platform/chromium-mac-lion/css3/selectors3/xml/css3-modsel-3-expected.png:
  • platform/chromium-mac-lion/css3/selectors3/xml/css3-modsel-3a-expected.png:
  • platform/chromium-mac-lion/css3/selectors3/xml/css3-modsel-64-expected.png:
  • platform/chromium-mac-lion/css3/selectors3/xml/css3-modsel-68-expected.png:
  • platform/chromium-mac-lion/css3/selectors3/xml/css3-modsel-69-expected.png:
  • platform/chromium-mac-lion/css3/selectors3/xml/css3-modsel-73-expected.png:
  • platform/chromium-mac-lion/css3/selectors3/xml/css3-modsel-73b-expected.png:
  • platform/chromium-mac-lion/css3/selectors3/xml/css3-modsel-74-expected.png:
  • platform/chromium-mac-lion/css3/selectors3/xml/css3-modsel-74b-expected.png:
  • platform/chromium-mac-lion/css3/unicode-bidi-isolate-basic-expected.png:
  • platform/chromium-mac-snowleopard/css1/box_properties/border_left-expected.png:
  • platform/chromium-mac-snowleopard/css1/box_properties/border_right_inline-expected.png:
  • platform/chromium-mac-snowleopard/css1/box_properties/border_top-expected.png:
  • platform/chromium-mac-snowleopard/css1/box_properties/clear_float-expected.png:
  • platform/chromium-mac-snowleopard/css1/box_properties/float_elements_in_series-expected.png:
  • platform/chromium-mac-snowleopard/css1/box_properties/float_on_text_elements-expected.png:
  • platform/chromium-mac-snowleopard/css1/box_properties/margin_left-expected.png:
  • platform/chromium-mac-snowleopard/css1/box_properties/margin_right-expected.png:
  • platform/chromium-mac-snowleopard/css1/box_properties/padding_left-expected.png:
  • platform/chromium-mac-snowleopard/css1/box_properties/padding_right-expected.png:
  • platform/chromium-mac-snowleopard/css1/cascade/cascade_order-expected.png:
  • platform/chromium-mac-snowleopard/css1/classification/list_style_image-expected.png:
  • platform/chromium-mac-snowleopard/css1/classification/list_style_position-expected.png:
  • platform/chromium-mac-snowleopard/css1/classification/list_style_type-expected.png:
  • platform/chromium-mac-snowleopard/css1/pseudo/anchor-expected.png:
  • platform/chromium-mac-snowleopard/css1/text_properties/text_align-expected.png:
  • platform/chromium-mac-snowleopard/css2.1/20110323/margin-applies-to-010-expected.png:
  • platform/chromium-mac-snowleopard/css2.1/20110323/replaced-intrinsic-ratio-001-expected.png:
  • platform/chromium-mac-snowleopard/css2.1/t0402-c71-fwd-parsing-02-f-expected.png:
  • platform/chromium-mac-snowleopard/css2.1/t0505-c16-descendant-01-e-expected.png:
  • platform/chromium-mac-snowleopard/css2.1/t050803-c14-classes-00-e-expected.png:
  • platform/chromium-mac-snowleopard/css2.1/t0509-c15-ids-01-e-expected.png:
  • platform/chromium-mac-snowleopard/css2.1/t0805-c5517-brdr-s-00-c-expected.png:
  • platform/chromium-mac-snowleopard/css2.1/t0805-c5518-brdr-t-01-e-expected.png:
  • platform/chromium-mac-snowleopard/css2.1/t0805-c5519-brdr-r-02-e-expected.png:
  • platform/chromium-mac-snowleopard/css2.1/t0805-c5520-brdr-b-01-e-expected.png:
  • platform/chromium-mac-snowleopard/css2.1/t0805-c5521-brdr-l-02-e-expected.png:
  • platform/chromium-mac-snowleopard/css2.1/t0905-c5525-fltcont-00-d-g-expected.png:
  • platform/chromium-mac-snowleopard/css2.1/t0905-c5525-fltwidth-00-c-g-expected.png:
  • platform/chromium-mac-snowleopard/css2.1/t1202-counter-04-b-expected.png:
  • platform/chromium-mac-snowleopard/css2.1/t1202-counters-04-b-expected.png:
  • platform/chromium-mac-snowleopard/css2.1/t1205-c563-list-type-00-b-expected.png:
  • platform/chromium-mac-snowleopard/css2.1/t1205-c564-list-img-00-b-g-expected.png:
  • platform/chromium-mac-snowleopard/css2.1/t1602-c546-txt-align-00-b-expected.png:
  • platform/chromium-mac-snowleopard/css3/selectors3/html/css3-modsel-1-expected.png:
  • platform/chromium-mac-snowleopard/css3/selectors3/html/css3-modsel-13-expected.png:
  • platform/chromium-mac-snowleopard/css3/selectors3/html/css3-modsel-15-expected.png:
  • platform/chromium-mac-snowleopard/css3/selectors3/html/css3-modsel-161-expected.png:
  • platform/chromium-mac-snowleopard/css3/selectors3/html/css3-modsel-19b-expected.png:
  • platform/chromium-mac-snowleopard/css3/selectors3/html/css3-modsel-22-expected.png:
  • platform/chromium-mac-snowleopard/css3/selectors3/html/css3-modsel-28-expected.png:
  • platform/chromium-mac-snowleopard/css3/selectors3/html/css3-modsel-28b-expected.png:
  • platform/chromium-mac-snowleopard/css3/selectors3/html/css3-modsel-29-expected.png:
  • platform/chromium-mac-snowleopard/css3/selectors3/html/css3-modsel-29b-expected.png:
  • platform/chromium-mac-snowleopard/css3/selectors3/html/css3-modsel-3a-expected.png:
  • platform/chromium-mac-snowleopard/css3/selectors3/html/css3-modsel-64-expected.png:
  • platform/chromium-mac-snowleopard/css3/selectors3/html/css3-modsel-73-expected.png:
  • platform/chromium-mac-snowleopard/css3/selectors3/html/css3-modsel-73b-expected.png:
  • platform/chromium-mac-snowleopard/css3/selectors3/html/css3-modsel-74-expected.png:
  • platform/chromium-mac-snowleopard/css3/selectors3/html/css3-modsel-74b-expected.png:
  • platform/chromium-mac-snowleopard/css3/selectors3/xhtml/css3-modsel-1-expected.png:
  • platform/chromium-mac-snowleopard/css3/selectors3/xhtml/css3-modsel-13-expected.png:
  • platform/chromium-mac-snowleopard/css3/selectors3/xhtml/css3-modsel-15-expected.png:
  • platform/chromium-mac-snowleopard/css3/selectors3/xhtml/css3-modsel-161-expected.png:
  • platform/chromium-mac-snowleopard/css3/selectors3/xhtml/css3-modsel-19b-expected.png:
  • platform/chromium-mac-snowleopard/css3/selectors3/xhtml/css3-modsel-22-expected.png:
  • platform/chromium-mac-snowleopard/css3/selectors3/xhtml/css3-modsel-28-expected.png:
  • platform/chromium-mac-snowleopard/css3/selectors3/xhtml/css3-modsel-28b-expected.png:
  • platform/chromium-mac-snowleopard/css3/selectors3/xhtml/css3-modsel-29-expected.png:
  • platform/chromium-mac-snowleopard/css3/selectors3/xhtml/css3-modsel-29b-expected.png:
  • platform/chromium-mac-snowleopard/css3/selectors3/xhtml/css3-modsel-3-expected.png:
  • platform/chromium-mac-snowleopard/css3/selectors3/xhtml/css3-modsel-3a-expected.png:
  • platform/chromium-mac-snowleopard/css3/selectors3/xhtml/css3-modsel-64-expected.png:
  • platform/chromium-mac-snowleopard/css3/selectors3/xhtml/css3-modsel-73-expected.png:
  • platform/chromium-mac-snowleopard/css3/selectors3/xhtml/css3-modsel-73b-expected.png:
  • platform/chromium-mac-snowleopard/css3/selectors3/xhtml/css3-modsel-74-expected.png:
  • platform/chromium-mac-snowleopard/css3/selectors3/xhtml/css3-modsel-74b-expected.png:
  • platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-1-expected.png:
  • platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-13-expected.png:
  • platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-15-expected.png:
  • platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-161-expected.png:
  • platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-19b-expected.png:
  • platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-22-expected.png:
  • platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-28-expected.png:
  • platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-28b-expected.png:
  • platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-29-expected.png:
  • platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-29b-expected.png:
  • platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-3-expected.png:
  • platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-3a-expected.png:
  • platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-64-expected.png:
  • platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-73-expected.png:
  • platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-73b-expected.png:
  • platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-74-expected.png:
  • platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-74b-expected.png:
  • platform/chromium-mac-snowleopard/css3/unicode-bidi-isolate-basic-expected.png:
  • platform/chromium-mac/css1/box_properties/border_left-expected.png:
  • platform/chromium-mac/css1/box_properties/border_right_inline-expected.png:
  • platform/chromium-mac/css1/box_properties/border_top-expected.png:
  • platform/chromium-mac/css1/box_properties/clear_float-expected.png:
  • platform/chromium-mac/css1/box_properties/float_elements_in_series-expected.png:
  • platform/chromium-mac/css1/box_properties/float_on_text_elements-expected.png:
  • platform/chromium-mac/css1/box_properties/margin_left-expected.png:
  • platform/chromium-mac/css1/box_properties/margin_right-expected.png:
  • platform/chromium-mac/css1/box_properties/padding_left-expected.png:
  • platform/chromium-mac/css1/box_properties/padding_right-expected.png:
  • platform/chromium-mac/css1/cascade/cascade_order-expected.png:
  • platform/chromium-mac/css1/classification/list_style_image-expected.png:
  • platform/chromium-mac/css1/classification/list_style_position-expected.png:
  • platform/chromium-mac/css1/classification/list_style_type-expected.png:
  • platform/chromium-mac/css1/pseudo/anchor-expected.png:
  • platform/chromium-mac/css1/text_properties/text_align-expected.png:
  • platform/chromium-mac/css2.1/20110323/margin-applies-to-010-expected.png:
  • platform/chromium-mac/css2.1/20110323/replaced-intrinsic-ratio-001-expected.png:
  • platform/chromium-mac/css2.1/t0402-c71-fwd-parsing-02-f-expected.png:
  • platform/chromium-mac/css2.1/t0505-c16-descendant-01-e-expected.png:
  • platform/chromium-mac/css2.1/t050803-c14-classes-00-e-expected.png:
  • platform/chromium-mac/css2.1/t0509-c15-ids-01-e-expected.png:
  • platform/chromium-mac/css2.1/t0805-c5517-brdr-s-00-c-expected.png:
  • platform/chromium-mac/css2.1/t0805-c5518-brdr-t-01-e-expected.png:
  • platform/chromium-mac/css2.1/t0805-c5519-brdr-r-02-e-expected.png:
  • platform/chromium-mac/css2.1/t0805-c5520-brdr-b-01-e-expected.png:
  • platform/chromium-mac/css2.1/t0805-c5521-brdr-l-02-e-expected.png:
  • platform/chromium-mac/css2.1/t0905-c5525-fltcont-00-d-g-expected.png:
  • platform/chromium-mac/css2.1/t0905-c5525-fltwidth-00-c-g-expected.png:
  • platform/chromium-mac/css2.1/t1202-counter-04-b-expected.png:
  • platform/chromium-mac/css2.1/t1202-counters-04-b-expected.png:
  • platform/chromium-mac/css2.1/t1205-c563-list-type-00-b-expected.png:
  • platform/chromium-mac/css2.1/t1205-c564-list-img-00-b-g-expected.png:
  • platform/chromium-mac/css2.1/t1602-c546-txt-align-00-b-expected.png:
  • platform/chromium-mac/css3/filters/filter-repaint-child-layers-expected.png:
  • platform/chromium-mac/css3/filters/filter-repaint-composited-fallback-crash-expected.png:
  • platform/chromium-mac/css3/filters/filter-repaint-composited-fallback-expected.png:
  • platform/chromium-mac/css3/filters/filter-with-transform-expected.png:
  • platform/chromium-mac/css3/filters/nested-filter-expected.png:
  • platform/chromium-mac/css3/images/cross-fade-overflow-position-expected.png:
  • platform/chromium-mac/css3/masking/clip-path-circle-expected.png:
  • platform/chromium-mac/css3/masking/clip-path-circle-filter-expected.png:
  • platform/chromium-mac/css3/masking/clip-path-circle-overflow-expected.png:
  • platform/chromium-mac/css3/masking/clip-path-circle-overflow-hidden-expected.png:
  • platform/chromium-mac/css3/masking/clip-path-ellipse-expected.png:
  • platform/chromium-mac/css3/masking/clip-path-polygon-evenodd-expected.png:
  • platform/chromium-mac/css3/masking/clip-path-polygon-expected.png:
  • platform/chromium-mac/css3/masking/clip-path-polygon-nonzero-expected.png:
  • platform/chromium-mac/css3/masking/clip-path-rectangle-expected.png:
  • platform/chromium-mac/css3/selectors3/html/css3-modsel-1-expected.png:
  • platform/chromium-mac/css3/selectors3/html/css3-modsel-13-expected.png:
  • platform/chromium-mac/css3/selectors3/html/css3-modsel-15-expected.png:
  • platform/chromium-mac/css3/selectors3/html/css3-modsel-161-expected.png:
  • platform/chromium-mac/css3/selectors3/html/css3-modsel-19b-expected.png:
  • platform/chromium-mac/css3/selectors3/html/css3-modsel-22-expected.png:
  • platform/chromium-mac/css3/selectors3/html/css3-modsel-23-expected.png:
  • platform/chromium-mac/css3/selectors3/html/css3-modsel-24-expected.png:
  • platform/chromium-mac/css3/selectors3/html/css3-modsel-28-expected.png:
  • platform/chromium-mac/css3/selectors3/html/css3-modsel-28b-expected.png:
  • platform/chromium-mac/css3/selectors3/html/css3-modsel-29-expected.png:
  • platform/chromium-mac/css3/selectors3/html/css3-modsel-29b-expected.png:
  • platform/chromium-mac/css3/selectors3/html/css3-modsel-3a-expected.png:
  • platform/chromium-mac/css3/selectors3/html/css3-modsel-64-expected.png:
  • platform/chromium-mac/css3/selectors3/html/css3-modsel-68-expected.png:
  • platform/chromium-mac/css3/selectors3/html/css3-modsel-69-expected.png:
  • platform/chromium-mac/css3/selectors3/html/css3-modsel-73-expected.png:
  • platform/chromium-mac/css3/selectors3/html/css3-modsel-73b-expected.png:
  • platform/chromium-mac/css3/selectors3/html/css3-modsel-74-expected.png:
  • platform/chromium-mac/css3/selectors3/html/css3-modsel-74b-expected.png:
  • platform/chromium-mac/css3/selectors3/xhtml/css3-modsel-1-expected.png:
  • platform/chromium-mac/css3/selectors3/xhtml/css3-modsel-13-expected.png:
  • platform/chromium-mac/css3/selectors3/xhtml/css3-modsel-15-expected.png:
  • platform/chromium-mac/css3/selectors3/xhtml/css3-modsel-161-expected.png:
  • platform/chromium-mac/css3/selectors3/xhtml/css3-modsel-19b-expected.png:
  • platform/chromium-mac/css3/selectors3/xhtml/css3-modsel-22-expected.png:
  • platform/chromium-mac/css3/selectors3/xhtml/css3-modsel-23-expected.png:
  • platform/chromium-mac/css3/selectors3/xhtml/css3-modsel-24-expected.png:
  • platform/chromium-mac/css3/selectors3/xhtml/css3-modsel-28-expected.png:
  • platform/chromium-mac/css3/selectors3/xhtml/css3-modsel-28b-expected.png:
  • platform/chromium-mac/css3/selectors3/xhtml/css3-modsel-29-expected.png:
  • platform/chromium-mac/css3/selectors3/xhtml/css3-modsel-29b-expected.png:
  • platform/chromium-mac/css3/selectors3/xhtml/css3-modsel-3-expected.png:
  • platform/chromium-mac/css3/selectors3/xhtml/css3-modsel-3a-expected.png:
  • platform/chromium-mac/css3/selectors3/xhtml/css3-modsel-64-expected.png:
  • platform/chromium-mac/css3/selectors3/xhtml/css3-modsel-68-expected.png:
  • platform/chromium-mac/css3/selectors3/xhtml/css3-modsel-69-expected.png:
  • platform/chromium-mac/css3/selectors3/xhtml/css3-modsel-73-expected.png:
  • platform/chromium-mac/css3/selectors3/xhtml/css3-modsel-73b-expected.png:
  • platform/chromium-mac/css3/selectors3/xhtml/css3-modsel-74-expected.png:
  • platform/chromium-mac/css3/selectors3/xhtml/css3-modsel-74b-expected.png:
  • platform/chromium-mac/css3/selectors3/xml/css3-modsel-1-expected.png:
  • platform/chromium-mac/css3/selectors3/xml/css3-modsel-13-expected.png:
  • platform/chromium-mac/css3/selectors3/xml/css3-modsel-15-expected.png:
  • platform/chromium-mac/css3/selectors3/xml/css3-modsel-161-expected.png:
  • platform/chromium-mac/css3/selectors3/xml/css3-modsel-19b-expected.png:
  • platform/chromium-mac/css3/selectors3/xml/css3-modsel-22-expected.png:
  • platform/chromium-mac/css3/selectors3/xml/css3-modsel-23-expected.png:
  • platform/chromium-mac/css3/selectors3/xml/css3-modsel-24-expected.png:
  • platform/chromium-mac/css3/selectors3/xml/css3-modsel-28-expected.png:
  • platform/chromium-mac/css3/selectors3/xml/css3-modsel-28b-expected.png:
  • platform/chromium-mac/css3/selectors3/xml/css3-modsel-29-expected.png:
  • platform/chromium-mac/css3/selectors3/xml/css3-modsel-29b-expected.png:
  • platform/chromium-mac/css3/selectors3/xml/css3-modsel-3-expected.png:
  • platform/chromium-mac/css3/selectors3/xml/css3-modsel-3a-expected.png:
  • platform/chromium-mac/css3/selectors3/xml/css3-modsel-64-expected.png:
  • platform/chromium-mac/css3/selectors3/xml/css3-modsel-68-expected.png:
  • platform/chromium-mac/css3/selectors3/xml/css3-modsel-69-expected.png:
  • platform/chromium-mac/css3/selectors3/xml/css3-modsel-73-expected.png:
  • platform/chromium-mac/css3/selectors3/xml/css3-modsel-73b-expected.png:
  • platform/chromium-mac/css3/selectors3/xml/css3-modsel-74-expected.png:
  • platform/chromium-mac/css3/selectors3/xml/css3-modsel-74b-expected.png:
  • platform/chromium-mac/css3/unicode-bidi-isolate-basic-expected.png:
  • platform/chromium-win-xp/css1/cascade: Removed.
  • platform/chromium-win-xp/css1/classification: Removed.
  • platform/chromium-win-xp/css1/pseudo: Removed.
  • platform/chromium-win-xp/css3/selectors3/html: Removed.
  • platform/chromium-win-xp/css3/selectors3/html/css3-modsel-161-expected.png: Removed.
  • platform/chromium-win-xp/css3/selectors3/xhtml: Removed.
  • platform/chromium-win-xp/css3/selectors3/xhtml/css3-modsel-161-expected.png: Removed.
  • platform/chromium-win-xp/css3/selectors3/xml: Removed.
  • platform/chromium-win-xp/css3/selectors3/xml/css3-modsel-161-expected.png: Removed.
  • platform/chromium-win/css1/box_properties/border_left-expected.png:
  • platform/chromium-win/css1/box_properties/border_right_inline-expected.png:
  • platform/chromium-win/css1/box_properties/border_top-expected.png:
  • platform/chromium-win/css1/box_properties/clear_float-expected.png:
  • platform/chromium-win/css1/box_properties/margin_left-expected.png:
  • platform/chromium-win/css1/box_properties/margin_right-expected.png:
  • platform/chromium-win/css1/box_properties/padding_left-expected.png:
  • platform/chromium-win/css1/box_properties/padding_right-expected.png:
  • platform/chromium-win/css1/cascade/cascade_order-expected.png:
  • platform/chromium-win/css1/classification/list_style_image-expected.png:
  • platform/chromium-win/css1/classification/list_style_position-expected.png:
  • platform/chromium-win/css1/classification/list_style_type-expected.png:
  • platform/chromium-win/css1/pseudo/anchor-expected.png:
  • platform/chromium-win/css2.1/20110323/margin-applies-to-010-expected.png:
  • platform/chromium-win/css2.1/20110323/replaced-intrinsic-ratio-001-expected.png:
  • platform/chromium-win/css2.1/t0402-c71-fwd-parsing-02-f-expected.png:
  • platform/chromium-win/css2.1/t0505-c16-descendant-01-e-expected.png:
  • platform/chromium-win/css2.1/t050803-c14-classes-00-e-expected.png:
  • platform/chromium-win/css2.1/t0509-c15-ids-01-e-expected.png:
  • platform/chromium-win/css2.1/t0805-c5517-brdr-s-00-c-expected.png:
  • platform/chromium-win/css2.1/t0805-c5518-brdr-t-01-e-expected.png:
  • platform/chromium-win/css2.1/t0805-c5519-brdr-r-02-e-expected.png:
  • platform/chromium-win/css2.1/t0805-c5520-brdr-b-01-e-expected.png:
  • platform/chromium-win/css2.1/t0805-c5521-brdr-l-02-e-expected.png:
  • platform/chromium-win/css2.1/t1205-c563-list-type-00-b-expected.png:
  • platform/chromium-win/css2.1/t1205-c564-list-img-00-b-g-expected.png:
  • platform/chromium-win/css3/filters/filter-repaint-child-layers-expected.png:
  • platform/chromium-win/css3/filters/filter-repaint-composited-fallback-crash-expected.png:
  • platform/chromium-win/css3/filters/filter-repaint-composited-fallback-expected.png:
  • platform/chromium-win/css3/filters/filter-with-transform-expected.png:
  • platform/chromium-win/css3/filters/nested-filter-expected.png:
  • platform/chromium-win/css3/images/cross-fade-overflow-position-expected.png:
  • platform/chromium-win/css3/masking/clip-path-circle-expected.png:
  • platform/chromium-win/css3/masking/clip-path-circle-filter-expected.png:
  • platform/chromium-win/css3/masking/clip-path-circle-overflow-expected.png:
  • platform/chromium-win/css3/masking/clip-path-circle-overflow-hidden-expected.png:
  • platform/chromium-win/css3/masking/clip-path-ellipse-expected.png:
  • platform/chromium-win/css3/masking/clip-path-polygon-evenodd-expected.png:
  • platform/chromium-win/css3/masking/clip-path-polygon-expected.png:
  • platform/chromium-win/css3/masking/clip-path-polygon-nonzero-expected.png:
  • platform/chromium-win/css3/masking/clip-path-rectangle-expected.png:
  • platform/chromium-win/css3/selectors3/html/css3-modsel-1-expected.png:
  • platform/chromium-win/css3/selectors3/html/css3-modsel-13-expected.png:
  • platform/chromium-win/css3/selectors3/html/css3-modsel-15-expected.png:
  • platform/chromium-win/css3/selectors3/html/css3-modsel-22-expected.png:
  • platform/chromium-win/css3/selectors3/html/css3-modsel-28-expected.png:
  • platform/chromium-win/css3/selectors3/html/css3-modsel-28b-expected.png:
  • platform/chromium-win/css3/selectors3/html/css3-modsel-29-expected.png:
  • platform/chromium-win/css3/selectors3/html/css3-modsel-29b-expected.png:
  • platform/chromium-win/css3/selectors3/html/css3-modsel-3a-expected.png:
  • platform/chromium-win/css3/selectors3/html/css3-modsel-73-expected.png:
  • platform/chromium-win/css3/selectors3/html/css3-modsel-73b-expected.png:
  • platform/chromium-win/css3/selectors3/html/css3-modsel-74-expected.png:
  • platform/chromium-win/css3/selectors3/html/css3-modsel-74b-expected.png:
  • platform/chromium-win/css3/selectors3/xhtml/css3-modsel-1-expected.png:
  • platform/chromium-win/css3/selectors3/xhtml/css3-modsel-13-expected.png:
  • platform/chromium-win/css3/selectors3/xhtml/css3-modsel-15-expected.png:
  • platform/chromium-win/css3/selectors3/xhtml/css3-modsel-22-expected.png:
  • platform/chromium-win/css3/selectors3/xhtml/css3-modsel-28-expected.png:
  • platform/chromium-win/css3/selectors3/xhtml/css3-modsel-28b-expected.png:
  • platform/chromium-win/css3/selectors3/xhtml/css3-modsel-29-expected.png:
  • platform/chromium-win/css3/selectors3/xhtml/css3-modsel-29b-expected.png:
  • platform/chromium-win/css3/selectors3/xhtml/css3-modsel-3-expected.png:
  • platform/chromium-win/css3/selectors3/xhtml/css3-modsel-3a-expected.png:
  • platform/chromium-win/css3/selectors3/xhtml/css3-modsel-73-expected.png:
  • platform/chromium-win/css3/selectors3/xhtml/css3-modsel-73b-expected.png:
  • platform/chromium-win/css3/selectors3/xhtml/css3-modsel-74-expected.png:
  • platform/chromium-win/css3/selectors3/xhtml/css3-modsel-74b-expected.png:
  • platform/chromium-win/css3/selectors3/xml/css3-modsel-1-expected.png:
  • platform/chromium-win/css3/selectors3/xml/css3-modsel-13-expected.png:
  • platform/chromium-win/css3/selectors3/xml/css3-modsel-15-expected.png:
  • platform/chromium-win/css3/selectors3/xml/css3-modsel-22-expected.png:
  • platform/chromium-win/css3/selectors3/xml/css3-modsel-28-expected.png:
  • platform/chromium-win/css3/selectors3/xml/css3-modsel-28b-expected.png:
  • platform/chromium-win/css3/selectors3/xml/css3-modsel-29-expected.png:
  • platform/chromium-win/css3/selectors3/xml/css3-modsel-29b-expected.png:
  • platform/chromium-win/css3/selectors3/xml/css3-modsel-3-expected.png:
  • platform/chromium-win/css3/selectors3/xml/css3-modsel-3a-expected.png:
  • platform/chromium-win/css3/selectors3/xml/css3-modsel-73-expected.png:
  • platform/chromium-win/css3/selectors3/xml/css3-modsel-73b-expected.png:
  • platform/chromium-win/css3/selectors3/xml/css3-modsel-74-expected.png:
  • platform/chromium-win/css3/selectors3/xml/css3-modsel-74b-expected.png:
8:26 AM Changeset in webkit [135526] by Csaba Osztrogonác
  • 3 edits in trunk/LayoutTests

[Qt] Unreviewed gardening, skip failing tests to paint the bots green.

  • platform/qt-5.0-wk2/TestExpectations:
  • platform/qt/TestExpectations:
8:21 AM Changeset in webkit [135525] by schenney@chromium.org
  • 50 edits
    2 deletes in trunk/LayoutTests

[Chromium] Test expectations update after enabling Skia changes.

Unreviewed Chromium expectations update.

Partial update, many more to come.

  • platform/chromium-linux/compositing/culling/filter-occlusion-blur-expected.png:
  • platform/chromium-linux/compositing/culling/filter-occlusion-blur-large-expected.png:
  • platform/chromium-mac-lion/compositing/geometry/fixed-position-iframe-composited-page-scale-down-expected.png:
  • platform/chromium-mac-lion/compositing/geometry/fixed-position-iframe-composited-page-scale-expected.png:
  • platform/chromium-mac-lion/compositing/geometry/fixed-position-transform-composited-page-scale-down-expected.png:
  • platform/chromium-mac-lion/compositing/reflections/nested-reflection-transformed-expected.png:
  • platform/chromium-mac-lion/compositing/reflections/nested-reflection-transformed2-expected.png:
  • platform/chromium-mac-lion/compositing/reflections/reflection-in-composited-expected.png:
  • platform/chromium-mac-lion/compositing/video/video-controls-layer-creation-expected.png:
  • platform/chromium-mac-lion/css1/basic/class_as_selector-expected.png:
  • platform/chromium-mac-lion/css1/basic/containment-expected.png:
  • platform/chromium-mac-lion/css1/basic/contextual_selectors-expected.png:
  • platform/chromium-mac-lion/css1/basic/id_as_selector-expected.png:
  • platform/chromium-mac-lion/css1/box_properties/border_bottom-expected.png:
  • platform/chromium-mac-snowleopard/compositing/geometry/fixed-position-iframe-composited-page-scale-down-expected.png:
  • platform/chromium-mac-snowleopard/compositing/plugins/composited-plugin-expected.png:
  • platform/chromium-mac-snowleopard/compositing/reflections/nested-reflection-transformed-expected.png:
  • platform/chromium-mac-snowleopard/compositing/reflections/nested-reflection-transformed2-expected.png:
  • platform/chromium-mac-snowleopard/compositing/reflections/reflection-in-composited-expected.png:
  • platform/chromium-mac-snowleopard/compositing/video/video-controls-layer-creation-expected.png:
  • platform/chromium-mac-snowleopard/css1/basic/class_as_selector-expected.png:
  • platform/chromium-mac-snowleopard/css1/basic/containment-expected.png:
  • platform/chromium-mac-snowleopard/css1/basic/contextual_selectors-expected.png:
  • platform/chromium-mac-snowleopard/css1/basic/id_as_selector-expected.png:
  • platform/chromium-mac-snowleopard/css1/box_properties/border_bottom-expected.png:
  • platform/chromium-mac/compositing/geometry/fixed-position-iframe-composited-page-scale-down-expected.png:
  • platform/chromium-mac/compositing/geometry/fixed-position-iframe-composited-page-scale-expected.png:
  • platform/chromium-mac/compositing/geometry/fixed-position-transform-composited-page-scale-down-expected.png:
  • platform/chromium-mac/compositing/reflections/nested-reflection-transformed-expected.png:
  • platform/chromium-mac/compositing/reflections/nested-reflection-transformed2-expected.png:
  • platform/chromium-mac/compositing/reflections/reflection-in-composited-expected.png:
  • platform/chromium-mac/compositing/video/video-controls-layer-creation-expected.png:
  • platform/chromium-mac/css1/basic/class_as_selector-expected.png:
  • platform/chromium-mac/css1/basic/containment-expected.png:
  • platform/chromium-mac/css1/basic/contextual_selectors-expected.png:
  • platform/chromium-mac/css1/basic/id_as_selector-expected.png:
  • platform/chromium-mac/css1/box_properties/border_bottom-expected.png:
  • platform/chromium-win-xp/compositing/reflections: Removed.
  • platform/chromium-win-xp/css1/basic: Removed.
  • platform/chromium-win/compositing/culling/filter-occlusion-alpha-large-expected.png:
  • platform/chromium-win/compositing/geometry/fixed-position-iframe-composited-page-scale-down-expected.png:
  • platform/chromium-win/compositing/geometry/fixed-position-iframe-composited-page-scale-expected.png:
  • platform/chromium-win/compositing/reflections/nested-reflection-transformed-expected.png:
  • platform/chromium-win/compositing/reflections/nested-reflection-transformed2-expected.png:
  • platform/chromium-win/compositing/reflections/reflection-in-composited-expected.png:
  • platform/chromium-win/compositing/video/video-controls-layer-creation-expected.png:
  • platform/chromium-win/css1/basic/class_as_selector-expected.png:
  • platform/chromium-win/css1/basic/containment-expected.png:
  • platform/chromium-win/css1/basic/contextual_selectors-expected.png:
  • platform/chromium-win/css1/basic/id_as_selector-expected.png:
  • platform/chromium-win/css1/box_properties/border_bottom-expected.png:
8:02 AM Changeset in webkit [135524] by dbates@webkit.org
  • 1 edit
    1 delete in trunk/LayoutTests

JavaScript fails to concatenate large strings
<https://bugs.webkit.org/show_bug.cgi?id=102963>

Remove Qt-specific results for test concat-large-strings-crash.html
since they are identical to the platform-independent expected results
as of changeset 135523, <http://trac.webkit.org/changeset/135523>.

  • platform/qt/fast/js/concat-large-strings-crash-expected.txt: Removed.
7:50 AM Changeset in webkit [135523] by dbates@webkit.org
  • 2 edits in trunk/LayoutTests

JavaScript fails to concatenate large strings
<https://bugs.webkit.org/show_bug.cgi?id=102963>

Update test result.

  • fast/js/concat-large-strings-crash-expected.txt:
7:32 AM Changeset in webkit [135522] by schenney@chromium.org
  • 1 edit
    3 deletes in trunk/LayoutTests

Chromium expectations fix.

Unreviewed removal of bad expectations.

  • platform/chromium/svg/animations/animate-text-nested-transforms-expected.txt: Removed.
  • platform/chromium/svg/custom/getscreenctm-in-mixed-content2-expected.txt: Removed.
  • platform/chromium/svg/custom/svg-fonts-in-text-controls-expected.txt: Removed.
7:28 AM Changeset in webkit [135521] by schenney@chromium.org
  • 341 edits in trunk/LayoutTests

[Chromium] Test expectations update after enabling Skia changes.

Unreviewed Chromium expectations update.

Update of remaining platform-specific expectations for linux. Other platforms to come.

Too many files to list.

7:15 AM Changeset in webkit [135520] by Simon Hausmann
  • 2 edits in trunk/Source/WebKit/qt

Unreviewed MSVC Windows build fix: Include header files referenced in RefPtr
instances.

  • Api/qwebelement.cpp:
6:46 AM Changeset in webkit [135519] by schenney@chromium.org
  • 1037 edits
    25 adds in trunk/LayoutTests

[Chromium] Test expectations update after enabling Skia changes.

Unreviewed Chromium expectations update.

Update of svg results.

Too many files to list. All Chromium platform results for svg tests.

6:30 AM Changeset in webkit [135518] by caseq@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: Timeline: Disclosure arrows rendered underneath frame boundaries
https://bugs.webkit.org/show_bug.cgi?id=101053

Patch by Eugene Klyuchnikov <eustas.bug@gmail.com> on 2012-11-22
Reviewed by Yury Semikhatsky.

In Timeline, when in "frames" mode, event disclosure arrows are rendered
below the dividing lines for the frame (div.timeline-frame-divider).
When this happens, the frame divider can capture mouse clicks and make
it difficult to open the disclosure arrow.

  • inspector/front-end/timelinePanel.css:

(#timeline-grid-header): Render dividers under timeline bars.

6:22 AM Changeset in webkit [135517] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

[TexMap] Reduce public methods of TextureMapperTiledBackingStore.
https://bugs.webkit.org/show_bug.cgi?id=103032

Patch by Huang Dongsung <luxtella@company100.net> on 2012-11-22
Reviewed by Noam Rosenthal.

This patch makes two methods private and removes one method.

No new tests, refactoring only.

  • platform/graphics/texmap/TextureMapperBackingStore.cpp:

(WebCore::TextureMapperTiledBackingStore::updateContentsFromImageIfNeeded):

  • platform/graphics/texmap/TextureMapperBackingStore.h:

(WebCore::TextureMapperTiledBackingStore::create):
(TextureMapperTiledBackingStore):
(WebCore::TextureMapperTiledBackingStore::setContentsToImage):
(WebCore::TextureMapperTiledBackingStore::rect):

6:06 AM Changeset in webkit [135516] by schenney@chromium.org
  • 1062 edits in trunk

Source/WebKit/chromium: [Chromium]: Removing gyp flags controlling Skia features.

Unreviewed, pre-tested rendering changes that have been waiting for a chance to rebaseline tests.

Enabled fixes for test rendering, and fast patsh for anti-aliased primitives.

  • skia_webkit.gyp:

LayoutTests: [Chromium] Test expectations update.

Unreviewed changes due to Skia changes.

Too many files to list (over 1000). All Chromium platform expectations.

5:57 AM Changeset in webkit [135515] by Simon Hausmann
  • 81 edits
    8 copies
    12 adds in trunk

[Qt] Separate QWidget dependant code into separate WebKitWidgets static library
https://bugs.webkit.org/show_bug.cgi?id=102800

Patch by Simon Hausmann <simon.hausmann@digia.com>, Pierre Rossi <pierre.rossi@digia.com> on 2012-11-22
Reviewed by Tor Arne Vestbø.

This patch separates code that needs to use QWidget related APIs in
WebKit/qt/WebCoreSupport and Api from code that doesn't. This means for
example FrameLoaderClientQt.cpp remains in the WebKit1 static library,
while qwebpage.cpp and qwebframe.cpp become part of the WebKitWidgets
static library. WebKit1 is compiled without QT += widgets and therefore
any widget related dependency has been moved "up" and out of WebKit1 into
the WebKitWidgets library.

Between the code in WebKit.a and WebKitWidgets.a new adapters and
interfaces have been introduced, such as QWebPageAdapter and
QWebFrameAdapter. QWebPageAdapter, when used from WebKit1, is a way to
call out into the API layer, implemented by QWebPage (QWebPagePrivate).
The other way around if QWebPage wants to access WebCore or
WebCoreSupport related functionality, it will go through
QWebPageAdapater (as base class). The separation in the direction up
into the API layer is complete with this patch, no code in WebKit1
depends on QtWidgets. The separation the other way around, code in the
API layer not using any WebCore types, is not complete yet.

Some classes such as QWebSettings, QWebElement or
DumpRenderTreeSupportQt remain in WebKit1. While they are API layer,
they do not depend on widget related Qt APIs and they make much more
use of WebCore internal APIs and therefore are easier to keep in
WebKit1.

In the future we plan to place a real shared library boundary between
WebKit1 and WebKitWidgets, by keeping the WebKit1 static library as
part of the QtWebKit shared library and by turning the WebKitWidgets
static library into a shared one.

.:

  • Source/api.pri:
  • WebKit.pro:

Source/WebCore:

  • platform/qt/QWebPageClient.h:

(QWebPageClient):

Source/WebKit:

  • WebKit1.pri:
  • WebKit1.pro:
  • WebKitWidgets.pri: Copied from Source/WebKit/WebKit1.pri.
  • WebKitWidgets.pro: Added.

Source/WebKit/qt:

  • Api/qgraphicswebview.cpp:

(QGraphicsWebViewPrivate::pageClient):
(QGraphicsWebViewPrivate::detachCurrentPage):
(QGraphicsWebView::setPage):

  • Api/qwebelement.cpp:

(QWebElement::webFrame):

  • Api/qwebframe.cpp:

(QWebFramePrivate::setPage):
(QWebFramePrivate::didStartProvisionalLoad):
(QWebFramePrivate::handleProgressFinished):
(QWebFramePrivate::emitInitialLayoutCompleted):
(QWebFramePrivate::emitIconChanged):
(QWebFramePrivate::emitLoadStarted):
(QWebFramePrivate::emitLoadFinished):
(QWebFramePrivate::createChildFrame):
(QWebFramePrivate::apiHandle):
(QWebFramePrivate::handle):
(QWebFramePrivate::contentsSizeDidChange):
(QWebFramePrivate::scrollBarPolicy):
(QWebFrame::QWebFrame):
(QWebFrame::~QWebFrame):
(QWebFrame::setUrl):
(QWebFrame::load):
(QWebFrame::scrollPosition):
(QWebFrame::geometry):
(QWebFramePrivate::kit):
(QWebFrame::handle):

  • Api/qwebframe.h:
  • Api/qwebframe_p.h:

(QWebFramePrivate::QWebFramePrivate):
(QWebFramePrivate):

  • Api/qwebhistory.cpp:

(QWebHistoryPrivate::page):

  • Api/qwebhistory_p.h:

(QWebHistoryPrivate):

  • Api/qwebinspector.cpp:

(QWebInspectorPrivate::setFrontend):

  • Api/qwebinspector_p.h:

(QWebInspectorPrivate):

  • Api/qwebpage.cpp:

(QWebPagePrivate::QWebPagePrivate):
(QWebPagePrivate::~QWebPagePrivate):
(QWebPagePrivate::core):
(QWebPagePrivate::show):
(QWebPagePrivate::setFocus):
(QWebPagePrivate::unfocus):
(QWebPagePrivate::setWindowRect):
(QWebPagePrivate::viewportSize):
(QWebPagePrivate::createWindow):
(QWebPagePrivate::javaScriptConsoleMessage):
(QWebPagePrivate::javaScriptAlert):
(QWebPagePrivate::javaScriptConfirm):
(QWebPagePrivate::javaScriptPrompt):
(QWebPagePrivate::printRequested):
(QWebPagePrivate::databaseQuotaExceeded):
(QWebPagePrivate::applicationCacheQuotaExceeded):
(QWebPagePrivate::setToolTip):
(QWebPagePrivate::createFullScreenVideoHandler):
(QWebPagePrivate::mainFrameAdapter):
(QWebPagePrivate::chooseFiles):
(QWebPagePrivate::acceptNavigationRequest):
(QWebPagePrivate::emitRestoreFrameStateRequested):
(QWebPagePrivate::emitSaveFrameStateRequested):
(QWebPagePrivate::emitDownloadRequested):
(QWebPagePrivate::emitFrameCreated):
(QWebPagePrivate::errorPageExtension):
(QWebPagePrivate::createPlugin):
(QWebPagePrivate::adapterForWidget):
(QWebPagePrivate::createMainFrame):
(QWebPagePrivate::createContextMenu):
(QWebPagePrivate::inspectorHandle):
(QWebPagePrivate::setInspectorFrontend):
(QWebPagePrivate::setInspectorWindowTitle):
(QWebPagePrivate::createWebInspector):
(iterateContextMenu):
(QWebPagePrivate::menuActionsAsText):
(QWebPagePrivate::emitViewportChangeRequested):
(QWebPagePrivate::mouseMoveEvent):
(QWebPagePrivate::mousePressEvent):
(QWebPagePrivate::mouseDoubleClickEvent):
(QWebPagePrivate::mouseTripleClickEvent):
(QWebPagePrivate::mouseReleaseEvent):
(QWebPagePrivate::handleSoftwareInputPanel):
(QWebPagePrivate::wheelEvent):
(QWebPagePrivate::gestureEvent):
(QWebPage::setView):
(QWebPage::javaScriptConsoleMessage):
(QWebPage::javaScriptAlert):
(QWebPage::javaScriptConfirm):
(QWebPage::javaScriptPrompt):
(QWebPage::shouldInterruptJavaScript):
(QWebPage::setFeaturePermission):
(QWebPagePrivate::colorSelectionRequested):
(QWebPagePrivate::createSelectPopup):
(QWebPagePrivate::viewRectRelativeToWindow):
(QWebPagePrivate::geolocationPermissionRequested):
(QWebPagePrivate::geolocationPermissionRequestCancelled):
(QWebPagePrivate::notificationsPermissionRequested):
(QWebPagePrivate::notificationsPermissionRequestCancelled):
(QWebPagePrivate::respondToChangedContents):
(QWebPagePrivate::respondToChangedSelection):
(QWebPagePrivate::microFocusChanged):
(QWebPagePrivate::triggerCopyAction):
(QWebPagePrivate::triggerActionForKeyEvent):
(QWebPagePrivate::clearUndoStack):
(QWebPagePrivate::canUndo):
(QWebPagePrivate::canRedo):
(QWebPagePrivate::undo):
(QWebPagePrivate::redo):
(QWebPagePrivate::createUndoStep):
(QWebPagePrivate::editorCommandForKeyEvent):
(QWebPage::viewportSize):
(QWebPage::setViewportSize):
(QWebPage::viewportAttributesForSize):
(QWebPage::event):
(QWebPage::extension):
(QWebPage::handle):
(QWebPage::chooseFile):
(QWebPage::setNetworkAccessManager):
(QWebPage::networkAccessManager):

  • Api/qwebpage.h:
  • Api/qwebpage_p.h:

(WebCore):
(QWebPagePrivate):

  • Api/qwebsettings.cpp:
  • Api/qwebsettings.h:
  • Api/qwebview.cpp:

(QWebViewPrivate::detachCurrentPage):

  • WebCoreSupport/ChromeClientQt.cpp:

(WebCore::ChromeClientQt::ChromeClientQt):
(WebCore::ChromeClientQt::setWindowRect):
(WebCore::ChromeClientQt::focus):
(WebCore::ChromeClientQt::unfocus):
(WebCore::ChromeClientQt::createWindow):
(WebCore::ChromeClientQt::show):
(WebCore::ChromeClientQt::setToolbarsVisible):
(WebCore::ChromeClientQt::setStatusbarVisible):
(WebCore::ChromeClientQt::setMenubarVisible):
(WebCore::ChromeClientQt::addMessageToConsole):
(WebCore::ChromeClientQt::closeWindowSoon):
(WebCore::ChromeClientQt::runJavaScriptAlert):
(WebCore::ChromeClientQt::runJavaScriptConfirm):
(WebCore::ChromeClientQt::runJavaScriptPrompt):
(WebCore::ChromeClientQt::setStatusbarText):
(WebCore::ChromeClientQt::shouldInterruptJavaScript):
(WebCore::ChromeClientQt::keyboardUIMode):
(WebCore::ChromeClientQt::windowResizerRect):

  • WebCoreSupport/ChromeClientQt.h:

(ChromeClientQt):

  • WebCoreSupport/ContextMenuClientQt.cpp:
  • WebCoreSupport/ContextMenuClientQt.h:

(ContextMenuClientQt):

  • WebCoreSupport/DefaultFullScreenVideoHandler.cpp: Added.

(DefaultFullScreenVideoHandler::DefaultFullScreenVideoHandler):
(DefaultFullScreenVideoHandler::~DefaultFullScreenVideoHandler):
(DefaultFullScreenVideoHandler::requiresFullScreenForVideoPlayback):
(DefaultFullScreenVideoHandler::enterFullScreen):
(DefaultFullScreenVideoHandler::exitFullScreen):

  • WebCoreSupport/DefaultFullScreenVideoHandler.h: Copied from Source/WebKit/qt/WebCoreSupport/QtWebComboBox.h.

(WebKit):
(DefaultFullScreenVideoHandler):

  • WebCoreSupport/DragClientQt.cpp:

(WebCore::DragClientQt::startDrag):

  • WebCoreSupport/DragClientQt.h:

(WebCore):
(WebCore::DragClientQt::DragClientQt):
(DragClientQt):

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp:

(toGeolocationClientMock):
(toDeviceOrientationClientMock):
(DumpRenderTreeSupportQt::initialize):
(DumpRenderTreeSupportQt::setDumpRenderTreeModeEnabled):
(DumpRenderTreeSupportQt::setFrameFlatteningEnabled):
(DumpRenderTreeSupportQt::webPageSetGroupName):
(DumpRenderTreeSupportQt::webPageGroupName):
(DumpRenderTreeSupportQt::webInspectorExecuteScript):
(DumpRenderTreeSupportQt::webInspectorShow):
(DumpRenderTreeSupportQt::webInspectorClose):
(DumpRenderTreeSupportQt::hasDocumentElement):
(DumpRenderTreeSupportQt::pauseAnimation):
(DumpRenderTreeSupportQt::pauseTransitionOfProperty):
(DumpRenderTreeSupportQt::numberOfActiveAnimations):
(DumpRenderTreeSupportQt::clearFrameName):
(DumpRenderTreeSupportQt::setCaretBrowsingEnabled):
(DumpRenderTreeSupportQt::setAuthorAndUserStylesEnabled):
(DumpRenderTreeSupportQt::setSmartInsertDeleteEnabled):
(DumpRenderTreeSupportQt::setSelectTrailingWhitespaceEnabled):
(DumpRenderTreeSupportQt::executeCoreCommandByName):
(DumpRenderTreeSupportQt::isCommandEnabled):
(DumpRenderTreeSupportQt::findString):
(DumpRenderTreeSupportQt::selectedRange):
(DumpRenderTreeSupportQt::firstRectForCharacterRange):
(DumpRenderTreeSupportQt::elementDoesAutoCompleteForElementWithId):
(DumpRenderTreeSupportQt::setWindowsBehaviorAsEditingBehavior):
(DumpRenderTreeSupportQt::viewportAsText):
(DumpRenderTreeSupportQt::scalePageBy):
(DumpRenderTreeSupportQt::setMockDeviceOrientation):
(DumpRenderTreeSupportQt::resetGeolocationMock):
(DumpRenderTreeSupportQt::setMockGeolocationPermission):
(DumpRenderTreeSupportQt::setMockGeolocationPosition):
(DumpRenderTreeSupportQt::setMockGeolocationPositionUnavailableError):
(DumpRenderTreeSupportQt::numberOfPendingGeolocationPermissionRequests):
(DumpRenderTreeSupportQt::shouldClose):
(DumpRenderTreeSupportQt::evaluateScriptInIsolatedWorld):
(DumpRenderTreeSupportQt::addUserStyleSheet):
(DumpRenderTreeSupportQt::removeUserStyleSheets):
(DumpRenderTreeSupportQt::setDefersLoading):
(DumpRenderTreeSupportQt::goBack):
(DumpRenderTreeSupportQt::responseMimeType):
(DumpRenderTreeSupportQt::clearOpener):
(DumpRenderTreeSupportQt::setInteractiveFormValidationEnabled):
(DumpRenderTreeSupportQt::contextMenu):
(DumpRenderTreeSupportQt::setMinimumTimerInterval):
(DumpRenderTreeSupportQt::thirdPartyCookiePolicyAllows):
(DumpRenderTreeSupportQt::mediaContentUrlByElementId):
(DumpRenderTreeSupportQt::setAlternateHtml):
(DumpRenderTreeSupportQt::confirmComposition):
(DumpRenderTreeSupportQt::injectInternalsObject):
(DumpRenderTreeSupportQt::resetInternalsObject):
(DumpRenderTreeSupportQt::paintPagesWithBoundaries):
(DumpRenderTreeSupportQt::setTrackRepaintRects):
(DumpRenderTreeSupportQt::trackRepaintRects):
(DumpRenderTreeSupportQt::getTrackedRepaintRects):

  • WebCoreSupport/DumpRenderTreeSupportQt.h:
  • WebCoreSupport/EditorClientQt.cpp:

(dumpRange):
(WebCore::EditorClientQt::shouldShowDeleteInterface):
(WebCore::EditorClientQt::shouldInsertText):
(WebCore::EditorClientQt::shouldChangeSelectedRange):
(WebCore::EditorClientQt::shouldApplyStyle):
(WebCore::EditorClientQt::respondToChangedContents):
(WebCore::EditorClientQt::respondToChangedSelection):
(WebCore::EditorClientQt::registerUndoStep):
(WebCore::EditorClientQt::clearUndoRedoOperations):
(WebCore::EditorClientQt::canUndo):
(WebCore::EditorClientQt::canRedo):
(WebCore::EditorClientQt::undo):
(WebCore::EditorClientQt::redo):
(WebCore::EditorClientQt::shouldInsertNode):
(WebCore::EditorClientQt::smartInsertDeleteEnabled):
(WebCore::EditorClientQt::toggleSmartInsertDelete):
(WebCore::EditorClientQt::isSelectTrailingWhitespaceEnabled):
(WebCore::EditorClientQt::handleKeyboardEvent):
(WebCore::EditorClientQt::EditorClientQt):
(WebCore::EditorClientQt::setInputMethodState):

  • WebCoreSupport/EditorClientQt.h:

(EditorClientQt):
(WebCore::EditorClientQt::setSmartInsertDeleteEnabled):
(WebCore::EditorClientQt::setSelectTrailingWhitespaceEnabled):

  • WebCoreSupport/FrameLoaderClientQt.cpp:

(drtDescriptionSuitableForTestResult):
(WebCore::FrameLoaderClientQt::setFrame):
(WebCore::FrameLoaderClientQt::transitionToCommittedForNewPage):
(WebCore::FrameLoaderClientQt::dispatchDidChangeLocationWithinPage):
(WebCore::FrameLoaderClientQt::dispatchDidStartProvisionalLoad):
(WebCore::FrameLoaderClientQt::dispatchDidCommitLoad):
(WebCore::FrameLoaderClientQt::dispatchDidFinishDocumentLoad):
(WebCore::FrameLoaderClientQt::dispatchDidFinishLoad):
(WebCore::FrameLoaderClientQt::dispatchDidLayout):
(WebCore::FrameLoaderClientQt::dispatchWillSubmitForm):
(WebCore::FrameLoaderClientQt::postProgressStartedNotification):
(WebCore::FrameLoaderClientQt::postProgressFinishedNotification):
(WebCore::FrameLoaderClientQt::frameLoadCompleted):
(WebCore::FrameLoaderClientQt::restoreViewState):
(WebCore::FrameLoaderClientQt::userAgent):
(WebCore::FrameLoaderClientQt::dispatchDidReceiveIcon):
(WebCore::FrameLoaderClientQt::frameLoaderDestroyed):
(WebCore::FrameLoaderClientQt::dispatchDidClearWindowObjectInWorld):
(WebCore::FrameLoaderClientQt::didPerformFirstNavigation):
(WebCore::FrameLoaderClientQt::onIconLoadedForPageURL):
(WebCore::FrameLoaderClientQt::updateGlobalHistoryRedirectLinks):
(WebCore::FrameLoaderClientQt::saveViewStateToItem):
(WebCore::FrameLoaderClientQt::cancelledError):
(WebCore::FrameLoaderClientQt::blockedError):
(WebCore::FrameLoaderClientQt::cannotShowURLError):
(WebCore::FrameLoaderClientQt::interruptedForPolicyChangeError):
(WebCore::FrameLoaderClientQt::cannotShowMIMETypeError):
(WebCore::FrameLoaderClientQt::fileDoesNotExistError):
(WebCore::FrameLoaderClientQt::pluginWillHandleLoadError):
(WebCore::FrameLoaderClientQt::download):
(WebCore::FrameLoaderClientQt::dispatchWillSendRequest):
(WebCore::FrameLoaderClientQt::dispatchDidReceiveResponse):
(WebCore::FrameLoaderClientQt::dispatchDidFinishLoading):
(WebCore::FrameLoaderClientQt::dispatchDidFailLoading):
(WebCore::FrameLoaderClientQt::callErrorPageExtension):
(WebCore::FrameLoaderClientQt::dispatchCreatePage):
(WebCore::FrameLoaderClientQt::dispatchDecidePolicyForNewWindowAction):
(WebCore::FrameLoaderClientQt::dispatchDecidePolicyForNavigationAction):
(WebCore::FrameLoaderClientQt::startDownload):
(WebCore::FrameLoaderClientQt::createFrame):
(WebCore::FrameLoaderClientQt::createPlugin):
(WebCore::FrameLoaderClientQt::createJavaAppletWidget):
(WebCore::FrameLoaderClientQt::chooseFile):
(WebCore::FrameLoaderClientQt::createNetworkingContext):
(WebCore):
(WebCore::FrameLoaderClientQt::webFrame):
(WebCore::FrameLoaderClientQt::emitLoadStarted):
(WebCore::FrameLoaderClientQt::emitLoadFinished):

  • WebCoreSupport/FrameLoaderClientQt.h:

(FrameLoaderClientQt):

  • WebCoreSupport/FrameNetworkingContextQt.cpp:

(WebCore::FrameNetworkingContextQt::FrameNetworkingContextQt):
(WebCore::FrameNetworkingContextQt::create):
(WebCore::FrameNetworkingContextQt::networkAccessManager):

  • WebCoreSupport/FrameNetworkingContextQt.h:

(FrameNetworkingContextQt):

  • WebCoreSupport/FullScreenVideoQt.cpp:

(WebCore):
(WebCore::FullScreenVideoQt::FullScreenVideoQt):

  • WebCoreSupport/FullScreenVideoQt.h:

(WebCore):

  • WebCoreSupport/FullScreenVideoWidget.cpp:
  • WebCoreSupport/FullScreenVideoWidget.h:
  • WebCoreSupport/GeolocationClientQt.cpp:

(WebCore::GeolocationClientQt::GeolocationClientQt):
(WebCore::GeolocationClientQt::positionUpdated):
(WebCore::GeolocationClientQt::startUpdating):
(WebCore::GeolocationClientQt::requestPermission):
(WebCore::GeolocationClientQt::cancelPermissionRequest):

  • WebCoreSupport/GeolocationClientQt.h:

(GeolocationClientQt):

  • WebCoreSupport/GeolocationPermissionClientQt.cpp:

(WebCore::GeolocationPermissionClientQt::requestGeolocationPermissionForFrame):
(WebCore::GeolocationPermissionClientQt::cancelGeolocationPermissionRequestForFrame):
(WebCore::GeolocationPermissionClientQt::setPermission):

  • WebCoreSupport/GeolocationPermissionClientQt.h:

(GeolocationPermissionClientQt):

  • WebCoreSupport/InitWebCoreQt.cpp:

(WebKit):
(WebKit::setWebKitWidgetsInitCallback):
(WebKit::initializeWebKitQt):
(WebKit::setImagePlatformResource):
(WebCore::initializeWebCoreQt):

  • WebCoreSupport/InitWebCoreQt.h:

(WebCore):
(WebKit):

  • WebCoreSupport/InitWebKitQt.cpp: Added.

(WebKit):
(WebKit::initializeWebKitWidgets):

  • WebCoreSupport/InitWebKitQt.h: Copied from Source/WebKit/qt/WebCoreSupport/QtWebComboBox.h.

(WebKit):

  • WebCoreSupport/InspectorClientQt.cpp:

(WebCore):
(WebCore::InspectorClientQt::InspectorClientQt):
(WebCore::InspectorClientQt::openInspectorFrontend):
(WebCore::InspectorClientQt::attachAndReplaceRemoteFrontend):
(WebCore::InspectorClientQt::detachRemoteFrontend):
(WebCore::InspectorClientQt::hideHighlight):
(WebCore::InspectorClientQt::sendMessageToFrontend):
(WebCore::InspectorFrontendClientQt::InspectorFrontendClientQt):
(WebCore::InspectorFrontendClientQt::updateWindowTitle):
(WebCore::InspectorFrontendClientQt::destroyInspectorView):

  • WebCoreSupport/InspectorClientQt.h:

(InspectorClientQt):
(InspectorFrontendClientQt):

  • WebCoreSupport/InspectorClientWebPage.cpp: Added.

(InspectorClientWebPage::InspectorClientWebPage):
(InspectorClientWebPage::createWindow):
(InspectorClientWebPage::javaScriptWindowObjectCleared):

  • WebCoreSupport/InspectorClientWebPage.h: Copied from Source/WebKit/qt/WebCoreSupport/WebSystemInterface.h.

(WebKit):
(InspectorClientWebPage):

  • WebCoreSupport/InspectorServerQt.cpp:

(WebCore::InspectorServerRequestHandlerQt::tcpReadyRead):
(WebCore::InspectorServerRequestHandlerQt::webSocketReadyRead):

  • WebCoreSupport/InspectorServerQt.h:

(InspectorServerQt):
(InspectorServerRequestHandlerQt):

  • WebCoreSupport/NotificationPresenterClientQt.cpp:

(WebCore::NotificationWrapper::NotificationWrapper):
(WebCore::NotificationPresenterClientQt::displayNotification):
(WebCore::NotificationPresenterClientQt::requestPermission):
(WebCore::NotificationPresenterClientQt::cancelRequestsForPermission):
(WebCore::NotificationPresenterClientQt::dumpShowText):
(WebCore::NotificationPresenterClientQt::toPage):
(WebCore::NotificationPresenterClientQt::toFrame):

  • WebCoreSupport/NotificationPresenterClientQt.h:

(WebCore::NotificationWrapper::~NotificationWrapper):
(NotificationWrapper):
(NotificationPresenterClientQt):
(WebCore::NotificationPresenterClientQt::hasSystemTrayIcon):
(WebCore::NotificationPresenterClientQt::setSystemTrayIcon):
(CallbacksInfo):
(WebCore):

  • WebCoreSupport/PageClientQt.cpp:

(createPlatformGraphicsContext3DFromWidget):
(QWebPageClient::ownerWindow):
(WebCore::PageClientQWidget::ownerWidget):
(WebCore::PageClientQWidget::createPlatformGraphicsContext3D):
(WebCore::PageClientQGraphicsWidget::ownerWidget):
(WebCore::PageClientQGraphicsWidget::createPlatformGraphicsContext3D):

  • WebCoreSupport/PageClientQt.h:

(PageClientQWidget):
(WebCore::QGraphicsItemOverlay::QGraphicsItemOverlay):
(WebCore::PageClientQGraphicsWidget::PageClientQGraphicsWidget):
(PageClientQGraphicsWidget):

  • WebCoreSupport/PlatformStrategiesQt.cpp:

(PlatformStrategiesQt::getPluginInfo):

  • WebCoreSupport/PopupMenuQt.cpp:

(SelectData::SelectData):

  • WebCoreSupport/QGraphicsWidgetPluginImpl.cpp: Added.

(QGraphicsWidgetPluginImpl::~QGraphicsWidgetPluginImpl):
(QGraphicsWidgetPluginImpl::update):
(QGraphicsWidgetPluginImpl::setGeometryAndClip):
(QGraphicsWidgetPluginImpl::setVisible):
(QGraphicsWidgetPluginImpl::setWidgetParent):
(QGraphicsWidgetPluginImpl::handle):

  • WebCoreSupport/QGraphicsWidgetPluginImpl.h: Added.

(QGraphicsWidgetPluginImpl):
(QGraphicsWidgetPluginImpl::QGraphicsWidgetPluginImpl):

  • WebCoreSupport/QWebFrameAdapter.cpp: Added.

(cacheLoadControlToCachePolicy):
(QWebFrameData::QWebFrameData):
(QWebFrameAdapter::QWebFrameAdapter):
(QWebFrameAdapter::~QWebFrameAdapter):
(QWebFrameAdapter::load):
(QWebFrameAdapter::handleGestureEvent):
(QWebFrameAdapter::scrollPosition):
(QWebFrameAdapter::frameRect):
(QWebFrameAdapter::init):
(QWebFrameAdapter::kit):
(QWebFrameAdapter::ensureAbsoluteUrl):

  • WebCoreSupport/QWebFrameAdapter.h: Added.

(WebCore):
(QWebFrameData):
(QWebFrameAdapter):
(QWebFrameAdapter::hasView):

  • WebCoreSupport/QWebPageAdapter.cpp: Added.

(QWebPageAdapter::QWebPageAdapter):
(QWebPageAdapter::~QWebPageAdapter):
(QWebPageAdapter::init):
(QWebPageAdapter::deletePage):
(QWebPageAdapter::kit):
(QWebPageAdapter::viewportArguments):
(QWebPageAdapter::registerUndoStep):
(QWebPageAdapter::setNetworkAccessManager):
(QWebPageAdapter::networkAccessManager):

  • WebCoreSupport/QWebPageAdapter.h: Added.

(WebCore):
(QWebPageAdapter):
(ErrorPageOption):
(ErrorPageReturn):

  • WebCoreSupport/QWebUndoCommand.cpp: Copied from Source/WebKit/qt/WebCoreSupport/QtWebComboBox.h.

(QWebUndoCommand::QWebUndoCommand):
(QWebUndoCommand::undo):
(QWebUndoCommand::redo):

  • WebCoreSupport/QWebUndoCommand.h: Copied from Source/WebKit/qt/WebCoreSupport/QtWebComboBox.h.

(QWebUndoCommand):

  • WebCoreSupport/QWidgetPluginImpl.cpp: Added.

(QWidgetPluginImpl::~QWidgetPluginImpl):
(QWidgetPluginImpl::update):
(QWidgetPluginImpl::setGeometryAndClip):
(QWidgetPluginImpl::setVisible):
(QWidgetPluginImpl::setStyleSheet):
(QWidgetPluginImpl::setWidgetParent):
(QWidgetPluginImpl::handle):

  • WebCoreSupport/QWidgetPluginImpl.h: Copied from Source/WebKit/qt/WebCoreSupport/QtWebComboBox.h.

(QWidgetPluginImpl):
(QWidgetPluginImpl::QWidgetPluginImpl):

  • WebCoreSupport/QtFallbackWebPopup.cpp:

(WebCore::QtFallbackWebPopup::QtFallbackWebPopup):
(WebCore::QtFallbackWebPopup::show):
(WebCore::QtFallbackWebPopup::pageClient):

  • WebCoreSupport/QtFallbackWebPopup.h:

(QtFallbackWebPopup):

  • WebCoreSupport/QtPluginWidgetAdapter.h: Copied from Source/WebKit/qt/WebCoreSupport/QtWebComboBox.h.

(QtPluginWidgetAdapter):

  • WebCoreSupport/QtWebComboBox.cpp:

(WebCore::QtWebComboBox::showPopupAtCursorPosition):

  • WebCoreSupport/QtWebComboBox.h:
  • WebCoreSupport/SearchPopupMenuQt.h:

(SearchPopupMenuQt):

  • WebCoreSupport/UndoStepQt.cpp:

(UndoStepQt::UndoStepQt):
(UndoStepQt::text):

  • WebCoreSupport/UndoStepQt.h:

(UndoStepQt):

  • WebCoreSupport/WebEventConversion.cpp:

(WebCore::mouseEventTypeAndMouseButtonFromQEvent):
(WebKitPlatformWheelEvent):
(WebCore::WebKitPlatformWheelEvent::applyDelta):
(WebCore::WebKitPlatformWheelEvent::WebKitPlatformWheelEvent):
(WebKitPlatformGestureEvent):
(WebCore::toPlatformEventType):
(WebCore::WebKitPlatformGestureEvent::WebKitPlatformGestureEvent):
(WebCore):
(WebCore::convertWheelEvent):
(WebCore::convertGesture):

  • WebCoreSupport/WebEventConversion.h:

(QGestureEventFacade):
(WebCore):

  • WebCoreSupport/WebSystemInterface.h:
  • tests/qwebpage/tst_qwebpage.cpp:

(tst_QWebPage::loadHtml5Video):
(tst_QWebPage::multiplePageGroupsAndLocalStorage):
(tst_QWebPage::thirdPartyCookiePolicy):

Source/WebKit2:

  • qt/MainQt.cpp:

(WebKit):
(main):

Tools:

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp:

(WebCore::WebPage::resetSettings):
(WebCore::WebPage::createWindow):
(WebCore::DumpRenderTree::DumpRenderTree):
(WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
(WebCore::DumpRenderTree::initJSObjects):
(WebCore::DumpRenderTree::dumpFrameScrollPosition):
(WebCore::DumpRenderTree::dumpFramesAsText):
(WebCore::DumpRenderTree::dump):
(WebCore::DumpRenderTree::createWindow):
(WebCore::DumpRenderTree::pageAdapter):
(WebCore):
(WebCore::DumpRenderTree::mainFrameAdapter):

  • DumpRenderTree/qt/DumpRenderTreeQt.h:

(DumpRenderTree):

  • DumpRenderTree/qt/EventSenderQt.cpp:

(EventSender::contextClick):
(EventSender::scalePageBy):

  • DumpRenderTree/qt/TestRunnerQt.cpp:

(TestRunner::reset):
(TestRunner::display):
(TestRunner::closeWebInspector):
(TestRunner::showWebInspector):
(TestRunner::evaluateInWebInspector):
(TestRunner::setFrameFlatteningEnabled):
(TestRunner::goBack):
(TestRunner::setDefersLoading):
(TestRunner::pauseAnimationAtTimeOnElementWithId):
(TestRunner::pauseTransitionAtTimeOnElementWithId):
(TestRunner::numberOfActiveAnimations):
(TestRunner::setCaretBrowsingEnabled):
(TestRunner::setAuthorAndUserStylesEnabled):
(TestRunner::callShouldCloseOnWebView):
(TestRunner::setSmartInsertDeleteEnabled):
(TestRunner::setSelectTrailingWhitespaceEnabled):
(TestRunner::execCommand):
(TestRunner::isCommandEnabled):
(TestRunner::findString):
(TestRunner::elementDoesAutoCompleteForElementWithId):
(TestRunner::setMockDeviceOrientation):
(TestRunner::setGeolocationPermission):
(TestRunner::numberOfPendingGeolocationPermissionRequests):
(TestRunner::setMockGeolocationPositionUnavailableError):
(TestRunner::setMockGeolocationPosition):
(TestRunner::evaluateScriptInIsolatedWorld):
(TestRunner::addUserStyleSheet):
(TestRunner::setMinimumTimerInterval):

  • DumpRenderTree/qt/TextInputControllerQt.cpp:

(TextInputController::selectedRange):
(TextInputController::firstRectForCharacterRange):
(TextInputController::unmarkText):

  • DumpRenderTree/qt/WorkQueueItemQt.cpp:

(LoadAlternateHTMLStringItem::invoke):

  • qmake/mkspecs/features/default_post.prf:
  • qmake/mkspecs/features/production_build.prf:
  • qmake/mkspecs/features/webkit_modules.prf:
  • qmake/mkspecs/modules/webkitwidgets.prf: Added.
5:52 AM Changeset in webkit [135514] by kenneth@webkit.org
  • 4 edits in trunk/Source/WebKit2

[WK2][EFL] No need to remove surface before replacing
https://bugs.webkit.org/show_bug.cgi?id=103055

Rubberstamped by Simon Hausmann.

The surface is stored in a OwnPtr which automatically
frees the existing surface after replacing it with a new
one. For some reason, this also fixes resizing issues on
my Nvidia driver.

  • UIProcess/API/efl/EwkViewImpl.cpp:

(EwkViewImpl::createGLSurface):

  • UIProcess/API/efl/EwkViewImpl.h:
  • UIProcess/API/efl/ewk_view.cpp:

(_ewk_view_smart_calculate):

5:52 AM Changeset in webkit [135513] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

[V8] Add context checks to WorldContextHandle and V8DOMWindowShell
https://bugs.webkit.org/show_bug.cgi?id=101573

Patch by Dan Carney <dcarney@google.com> on 2012-11-22
Reviewed by Adam Barth.

Added a bunch of assertions to ensure the problems with IndexedDB
contexts cannot reemerge.

No new tests. No change in functionality.

  • bindings/v8/V8DOMWindowShell.cpp:

(WebCore):
(WebCore::V8DOMWindowShell::assertContextHasCorrectPrototype):

  • bindings/v8/V8DOMWindowShell.h:

(V8DOMWindowShell):
(WebCore::V8DOMWindowShell::isolated):

  • bindings/v8/WorldContextHandle.cpp:

(WebCore::WorldContextHandle::WorldContextHandle):

5:51 AM Changeset in webkit [135512] by yurys@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed. Mark LayoutTests/fast/canvas/canvas-stroke*-gradient-shadow.html as crashing after latest Skia roll.
https://bugs.webkit.org/show_bug.cgi?id=103062

  • platform/chromium/TestExpectations:
5:50 AM Changeset in webkit [135511] by allan.jensen@digia.com
  • 3 edits in trunk/Source/WebCore

[Qt] Correct extensions on preferredFilename
https://bugs.webkit.org/show_bug.cgi?id=103054

Reviewed by Simon Hausmann.

When guessing a filename we will now ensure it has an extension that is valid for its mimetype.
To do this the two missing methods getExtensionsForMIMEType and getPreferredExtensionForMIMEType
have been added to the Qt implementation of MIMETypeRegistry.

  • platform/network/qt/QNetworkReplyHandler.cpp:

(WebCore::QNetworkReplyHandler::sendResponseIfNeeded):

  • platform/qt/MIMETypeRegistryQt.cpp:

(WebCore::MIMETypeRegistry::getExtensionsForMIMEType):
(WebCore::MIMETypeRegistry::getPreferredExtensionForMIMEType):

5:45 AM Changeset in webkit [135510] by tkent@chromium.org
  • 8 edits in trunk

INPUT_MULTIPLE_FIELDS_UI: Refactoring: Do not call updateInnerTextValue if only read-only sub-fields have values
https://bugs.webkit.org/show_bug.cgi?id=103033

Reviewed by Kentaro Hara.

Source/WebCore:

input[type=time] can have read-only sub fields. If only read-only fields
have values, we don't need to call updateInnerTextValue when
HTMLInputElement::value is set to "".

Tests: this patch doesn't change any visible behavior, but we add test cases to
fast/forms/time-multiple-fields/time-multiple-fields-value-set-empty.html
just in case.

  • html/shadow/DateTimeEditElement.h:

(DateTimeEditElement): Declare anyEditableFieldsHaveValues.

  • html/shadow/DateTimeEditElement.cpp:

(WebCore::DateTimeEditElement::anyEditableFieldsHaveValues):
Added. This function checks value existence against only editable sub-fields.

  • html/BaseMultipleFieldsDateAndTimeInputType.cpp:

(WebCore::BaseMultipleFieldsDateAndTimeInputType::setValue):
Call DateTimeEditElement::anyEditableFieldsHaveValues() instead of
DateTimeFieldsState::hasAnyValue().

  • html/DateTimeFieldsState.h: Remove hasAnyValue.

LayoutTests:

  • fast/forms/time-multiple-fields/time-multiple-fields-value-set-empty-expected.txt:
  • fast/forms/time-multiple-fields/time-multiple-fields-value-set-empty.html:
5:31 AM Changeset in webkit [135509] by keishi@webkit.org
  • 2 edits
    20 adds in trunk/LayoutTests

Add week-multiple-fields tests
https://bugs.webkit.org/show_bug.cgi?id=102045

Reviewed by Kent Tamura.

Adding test cases for multiple field week input.

  • fast/forms/resources/multiple-fields-blur-and-focus-events.js:

(startTestFor.beginTestCase):
(startTestFor):

  • fast/forms/week-multiple-fields/week-multiple-fields-ax-aria-attributes-expected.txt: Added.
  • fast/forms/week-multiple-fields/week-multiple-fields-ax-aria-attributes.html: Added.
  • fast/forms/week-multiple-fields/week-multiple-fields-ax-value-changed-notification-expected.txt: Added.
  • fast/forms/week-multiple-fields/week-multiple-fields-ax-value-changed-notification.html: Added.
  • fast/forms/week-multiple-fields/week-multiple-fields-blur-and-focus-events-expected.txt: Added.
  • fast/forms/week-multiple-fields/week-multiple-fields-blur-and-focus-events.html: Added.
  • fast/forms/week-multiple-fields/week-multiple-fields-change-layout-by-value-expected.txt: Added.
  • fast/forms/week-multiple-fields/week-multiple-fields-change-layout-by-value.html: Added.
  • fast/forms/week-multiple-fields/week-multiple-fields-keyboard-events-expected.txt: Added.
  • fast/forms/week-multiple-fields/week-multiple-fields-keyboard-events.html: Added.
  • fast/forms/week-multiple-fields/week-multiple-fields-mouse-events-expected.txt: Added.
  • fast/forms/week-multiple-fields/week-multiple-fields-mouse-events.html: Added.
  • fast/forms/week-multiple-fields/week-multiple-fields-preserve-value-after-history-back-expected.txt: Added.
  • fast/forms/week-multiple-fields/week-multiple-fields-preserve-value-after-history-back.html: Added.
  • fast/forms/week-multiple-fields/week-multiple-fields-reset-value-after-reloads-expected.txt: Added.
  • fast/forms/week-multiple-fields/week-multiple-fields-reset-value-after-reloads.html: Added.
  • fast/forms/week-multiple-fields/week-multiple-fields-spinbutton-change-and-input-events-expected.txt: Added.
  • fast/forms/week-multiple-fields/week-multiple-fields-spinbutton-change-and-input-events.html: Added.
  • fast/forms/week-multiple-fields/week-multiple-fields-wheel-event-expected.txt: Added.
  • fast/forms/week-multiple-fields/week-multiple-fields-wheel-event.html: Added.
5:23 AM Changeset in webkit [135508] by commit-queue@webkit.org
  • 13 edits in trunk

WebKitTestRunner needs layoutTestController.setCacheModel
https://bugs.webkit.org/show_bug.cgi?id=42684

Patch by Christophe Dumez <Christophe Dumez> on 2012-11-22
Reviewed by Kenneth Rohde Christiansen.

Source/WebKit2:

Add Bundle C API for WebKitTestRunner to set the
cache model.

  • WebProcess/InjectedBundle/API/c/WKBundle.cpp:

(WKBundleSetCacheModel):

  • WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:
  • WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::InjectedBundle::setCacheModel):
(WebKit):

  • WebProcess/InjectedBundle/InjectedBundle.h:

(InjectedBundle):

  • WebProcess/WebProcess.h:

(WebProcess):

Tools:

Add support for testRunner.setCacheModel to WebKitTestRunner.

  • WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
  • WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:

(WTR::InjectedBundle::beginTesting):

  • WebKitTestRunner/InjectedBundle/TestRunner.cpp:

(WTR::TestRunner::setCacheModel):
(WTR):

  • WebKitTestRunner/InjectedBundle/TestRunner.h:

(TestRunner):

LayoutTests:

Unskip fast/dom/HTMLScriptElement/nested-execution.html for
WK2 now that WebKitTestRunner implements
testRunner.setCacheModel.

  • platform/wk2/TestExpectations:
5:23 AM Changeset in webkit [135507] by allan.jensen@digia.com
  • 4 edits in trunk/Source/WebCore

[Qt] Lookup mimetypes using QMimeDatabase
https://bugs.webkit.org/show_bug.cgi?id=102667

Reviewed by Simon Hausmann.

The Qt backend of MIMETypeRegistry now looks up using QMimeDatabase.

  • loader/archive/ArchiveFactory.cpp:

(WebCore::archiveMIMETypes):

Also map the preferred freedesktop mimetype for MIME archives to MIME archive constructor.

  • platform/MIMETypeRegistry.cpp:

(WebCore::MIMETypeRegistry::getNormalizedMIMEType):

  • platform/qt/MIMETypeRegistryQt.cpp:

(WebCore::MIMETypeRegistry::getMIMETypeForExtension):
(WebCore::MIMETypeRegistry::getMIMETypeForPath):
(WebCore::MIMETypeRegistry::getNormalizedMIMEType):

5:16 AM Changeset in webkit [135506] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/chromium

IDBRequestTest needs a v8 context
https://bugs.webkit.org/show_bug.cgi?id=102941

Patch by Dan Carney <dcarney@google.com> on 2012-11-22
Reviewed by Jochen Eisinger.

Added v8 context to IDBRequestTest tests.

  • tests/IDBRequestTest.cpp:

(IDBRequestTest):
(WebKit::IDBRequestTest::IDBRequestTest):
(WebKit::IDBRequestTest::context):
(WebKit::IDBRequestTest::scriptExecutionContext):
(WebKit):
(WebKit::TEST_F):

4:39 AM Changeset in webkit [135505] by schenney@chromium.org
  • 5 edits
    1 add
    2 deletes in trunk/LayoutTests

Fixing some Chromium test expectations.

Unreviewed expectations update

  • platform/chromium-mac/fast/css/font-smoothing-expected.png:
  • platform/chromium-mac/fast/css/text-rendering-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/filters-conv-01-f-expected.png:
  • platform/chromium-mac/svg/text/scaling-font-with-geometric-precision-expected.png:
  • platform/chromium-win/fast/css/font-smoothing-expected.png: Added.
  • platform/chromium/fast/css/font-smoothing-expected.png: Removed.
  • platform/chromium/fast/css/text-rendering-expected.png: Removed.
4:14 AM Changeset in webkit [135504] by rakuco@webkit.org
  • 2 edits in trunk/Source/WebKit2

REGRESSION(r135399): Wrong assertion causing an assertion failure: m_rawAttributes.initialScale > 0
https://bugs.webkit.org/show_bug.cgi?id=102971

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-11-22
Reviewed by Kenneth Rohde Christiansen.

m_rawAttributes.initialScale has to be initialized even if m_minimumScaleToFit hasn't changed
it's value.

  • UIProcess/PageViewportController.cpp:

(WebKit::PageViewportController::didChangeViewportAttributes):

3:59 AM Changeset in webkit [135503] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebCore

Move URL-checking code into Frame
https://bugs.webkit.org/show_bug.cgi?id=103014

Patch by Cosmin Truta <ctruta@rim.com> on 2012-11-22
Reviewed by Ojan Vafai.

Move the common URL checking logic from HTMLFrameElementBase::isURLAllowed
and HTMLPlugInImageElement::allowedToLoadFrameURL into Frame::isURLAllowed.

No new tests. Refactoring.

  • html/HTMLFrameElementBase.cpp:

(WebCore::HTMLFrameElementBase::isURLAllowed): Call Frame::isURLAllowed.

  • html/HTMLPlugInImageElement.cpp:

(WebCore::HTMLPlugInImageElement::allowedToLoadFrameURL): Call Frame::isURLAllowed.

  • page/Frame.cpp:

(WebCore::Frame::isURLAllowed): Added.

  • page/Frame.h:

(Frame): Added isURLAllowed.

3:31 AM Changeset in webkit [135502] by haraken@chromium.org
  • 7 edits in trunk/Source/WebCore

[V8] Rename toWebCoreStringWithNullOrUndefinedCheck() with toWebCoreStringWithUndefinedOrNullCheck()
https://bugs.webkit.org/show_bug.cgi?id=103013

Reviewed by Adam Barth.

IDL attributes and other V8 and JSC files use "UndefinedOrNull" instead of "NullOrUndefined".

No tests. No change in behavior.

  • bindings/v8/JavaScriptCallFrame.cpp:

(WebCore::JavaScriptCallFrame::functionName):

  • bindings/v8/ScriptDebugServer.cpp:

(WebCore::ScriptDebugServer::setScriptSource):
(WebCore::ScriptDebugServer::dispatchDidParseSource):
(WebCore::ScriptDebugServer::compileScript):
(WebCore::ScriptDebugServer::runScript):

  • bindings/v8/ScriptEventListener.cpp:

(WebCore::eventListenerHandlerLocation):

  • bindings/v8/V8Binding.h:

(WebCore::toWebCoreStringWithUndefinedOrNullCheck):

  • bindings/v8/custom/V8DOMWindowCustom.cpp:

(WebCore::V8DOMWindow::showModalDialogCallback):
(WebCore::V8DOMWindow::openCallback):

  • bindings/v8/custom/V8JavaScriptCallFrameCustom.cpp:

(WebCore::V8JavaScriptCallFrame::evaluateCallback):

3:12 AM Changeset in webkit [135501] by yurys@chromium.org
  • 5 edits in trunk/LayoutTests

Chromium gardening. Rebaseline compositing tests
https://bugs.webkit.org/show_bug.cgi?id=103039

Reviewed by Pavel Feldman.

  • platform/chromium-linux/platform/chromium/virtual/softwarecompositing/reflections/nested-reflection-anchor-point-expected.png:
  • platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/reflections/nested-reflection-anchor-point-expected.png:
  • platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/reflections/nested-reflection-anchor-point-expected.png:
  • platform/chromium-mac/platform/chromium/virtual/softwarecompositing/reflections/nested-reflection-anchor-point-expected.png:
2:59 AM Changeset in webkit [135500] by commit-queue@webkit.org
  • 7 edits in trunk

Name enumerator function for GetStats RTCStatsElement
https://bugs.webkit.org/show_bug.cgi?id=102933

Patch by Harald Alvestrand <hta@google.com> on 2012-11-22
Reviewed by Adam Barth.

Source/WebCore:

Tested by extensions to the RTCPeerConnection-stats test.

  • Modules/mediastream/RTCStatsElement.cpp:

(WebCore::RTCStatsElement::names):
(WebCore):

  • Modules/mediastream/RTCStatsElement.h:

(RTCStatsElement):

  • Modules/mediastream/RTCStatsElement.idl:

LayoutTests:

  • fast/mediastream/RTCPeerConnection-stats-expected.txt:
  • fast/mediastream/RTCPeerConnection-stats.html:
2:12 AM Changeset in webkit [135499] by kkristof@inf.u-szeged.hu
  • 1 edit
    1 add in trunk/LayoutTests

[Qt] Unreviewed gardening

Add platform specific exception.

  • platform/qt/fast/js/concat-large-strings-crash-expected.txt: Added.
1:58 AM Changeset in webkit [135498] by haraken@chromium.org
  • 3 edits in trunk/Source/WebCore

Rename the "eden" bit to something more descriptive
https://bugs.webkit.org/show_bug.cgi?id=102985

Reviewed by Adam Barth.

InEdenFlag is not descriptive. Per the discussion in IRC,
we rename InEdenFlag to V8CollectableDuringMinorGCFlag.

No tests. No change in behavior.

  • bindings/v8/V8GCController.cpp:

(WebCore::gcTree):
(WebCore::V8GCController::didCreateWrapperForNode):
(WebCore::V8GCController::minorGCPrologue):

  • dom/Node.h:

(WebCore::Node::isV8CollectableDuringMinorGC):
(WebCore::Node::setV8CollectableDuringMinorGC):

1:47 AM Changeset in webkit [135497] by haraken@chromium.org
  • 2 edits in trunk/Source/WebCore

[V8] Move AddMessageListener() from WorkerContextExecutionProxy::initializeIfNeeded() to WorkerContextExecutionProxy::initIsolate()
https://bugs.webkit.org/show_bug.cgi?id=102998

Reviewed by Adam Barth.

This is an incremental step for moving initializeIfNeeded()
to V8Initializer.h. Given that AddMessageListener() needs to
be called once per Isolate, we can move AddMessageListener()
from initializeIfNeeded() to initIsolate().

No tests. No change in behavior.

  • bindings/v8/WorkerContextExecutionProxy.cpp:

(WebCore::WorkerContextExecutionProxy::initIsolate):
(WebCore::WorkerContextExecutionProxy::initializeIfNeeded):

1:44 AM Changeset in webkit [135496] by kbalazs@webkit.org
  • 8 edits in trunk/Tools

[Qt][WTR] TestController::platformRunUntil should not do busy waiting
https://bugs.webkit.org/show_bug.cgi?id=101327

Reviewed by Simon Hausmann.

Avoid busy waiting for events in platformRunUntil while making
sure we don't change the behavior of modal event loops.

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::~TestController):

  • WebKitTestRunner/TestController.h:

(TestController):

  • WebKitTestRunner/efl/TestControllerEfl.cpp:

(WTR::TestController::platformDestroy):
(WTR):

  • WebKitTestRunner/gtk/TestControllerGtk.cpp:

(WTR::TestController::platformDestroy):
(WTR):

  • WebKitTestRunner/mac/TestControllerMac.mm:

(WTR::TestController::platformDestroy):
(WTR):

  • WebKitTestRunner/qt/TestControllerQt.cpp:

(TestController::RunLoop): Helper class to handle
the event loop logic
(WTR):
(WTR::TestController::RunLoop::RunLoop):
(WTR::TestController::RunLoop::runUntil): Use QEventLoop to implement
the run loop. This is the appropriate API to push the WaitForMoreEvents
flag to QCoreApplication::processEvents and also being able to exit the
loop if we have timed out.
(WTR::TestController::RunLoop::notifyDone):
(WTR::TestController::RunLoop::timerFired):
(WTR::TestController::RunLoop::runModal):
(WTR::TestController::notifyDone):
(WTR::TestController::platformInitialize):
(WTR::TestController::platformDestroy):
(WTR::TestController::platformRunUntil):
(WTR::TestController::runModal):

  • WebKitTestRunner/win/TestControllerWin.cpp:

(WTR::TestController::platformDestroy):
(WTR):

1:37 AM Changeset in webkit [135495] by msaboff@apple.com
  • 4 edits in trunk/Source

HTML integer parsing functions don't natively handle 8 bit strings
https://bugs.webkit.org/show_bug.cgi?id=102997

Reviewed by Filip Pizlo.

Source/WebCore:

In order to avoid unnecessary up convering of 8 bit strings to 16 bits, added 8 bit paths to
parseHTMLInteger() and parseHTMLNonNegativeInteger() by breaking out the core logic into
templated helper functions. These methods are primarily used to process attribute values.

No new tests needed, functionnality covered by existing tests.

  • html/parser/HTMLParserIdioms.cpp:

(WebCore::parseHTMLIntegerInternal):
(WebCore::parseHTMLInteger):
(WebCore::parseHTMLNonNegativeIntegerInternal):
(WebCore::parseHTMLNonNegativeInteger):

Source/WTF:

Added exports to the LChar* versions of charactersToIntStrict() and charactersToUIntStrict()
to support the changes made to parseHTMLInteger() and parseHTMLNonNegativeInteger().

  • wtf/text/WTFString.h:

(WTF::charactersToIntStrict): Added export
(WTF::charactersToUIntStrict): Added export

1:28 AM Changeset in webkit [135494] by haraken@chromium.org
  • 5 edits in trunk/Source/WebCore

[V8] WebCoreStringResourceBase should be located in V8StringResource.h
https://bugs.webkit.org/show_bug.cgi?id=103002

Reviewed by Adam Barth.

Currently WebCoreStringResourceBase is mis-located in V8ValueCache.h.
It should be in V8StringResource.h.

No tests. No change in behavior.

  • bindings/v8/V8StringResource.cpp:

(WebCore::WebCoreStringResourceBase::toWebCoreStringResourceBase):
(WebCore):
(WebCore::WebCoreStringResourceBase::visitStrings):

  • bindings/v8/V8StringResource.h:

(WebCore):
(WebCoreStringResourceBase):
(WebCore::WebCoreStringResourceBase::WebCoreStringResourceBase):
(WebCore::WebCoreStringResourceBase::~WebCoreStringResourceBase):
(WebCore::WebCoreStringResourceBase::webcoreString):
(WebCore::WebCoreStringResourceBase::atomicString):
(WebCore::WebCoreStringResourceBase::memoryConsumption):
(WebCoreStringResource16):
(WebCore::WebCoreStringResource16::WebCoreStringResource16):
(WebCoreStringResource8):
(WebCore::WebCoreStringResource8::WebCoreStringResource8):

  • bindings/v8/V8ValueCache.cpp:
  • bindings/v8/V8ValueCache.h:

(WebCore):

1:24 AM Changeset in webkit [135493] by loislo@chromium.org
  • 4 edits in trunk/Source/WebCore

Web Inspector: NMI add instrumentation to DynamicNodeList classes hierarchy.
https://bugs.webkit.org/show_bug.cgi?id=103025

Reviewed by Yury Semikhatsky.

RNiwa changed pointer type in NodeRareData::NodeListAtomicNameCacheMap from the topmost
DynamicSubtreeNodeList to the base DynamicNodeListCacheBase at r135429.
As a result we got non zero count of pointers that don't match with tcmalloc data,
because DynamicNodeList uses multiple inheritance.
It could be fixed with help of explicit native memory instrumentation for DynamicNodeList class hierarchy.

No change in behavior, so no new tests.

  • dom/Document.cpp: drive by fix.

(WebCore::Document::reportMemoryUsage):

  • dom/DynamicNodeList.cpp:

(WebCore::DynamicNodeListCacheBase::reportMemoryUsage):
(WebCore):
(WebCore::DynamicNodeList::reportMemoryUsage):
(WebCore::DynamicSubtreeNodeList::reportMemoryUsage):

  • dom/DynamicNodeList.h:

(WebCore::DynamicNodeListCacheBase::~DynamicNodeListCacheBase):
(DynamicNodeListCacheBase):
(DynamicNodeList):
(DynamicSubtreeNodeList):

12:56 AM Changeset in webkit [135492] by yurys@chromium.org
  • 1 edit
    2 adds in trunk/LayoutTests

Unreviewed. Rebaselined new tests added in r135454.

  • platform/chromium/fast/js/concat-large-strings-crash-expected.txt: Added.
  • platform/chromium/fast/js/concat-large-strings-crash2-expected.txt: Added.
12:40 AM Changeset in webkit [135491] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[EFL][WK2] Correct the parameters of WebPlatformTouchPoint.
https://bugs.webkit.org/show_bug.cgi?id=102865

Patch by Eunmi Lee <eunmi15.lee@samsung.com> on 2012-11-22
Reviewed by Kenneth Rohde Christiansen.

Set the screen position as a third parameter and contents position as
a fourth parameter of WebPlatformTouchPoint().

  • Shared/efl/WebEventFactory.cpp:

(WebKit::WebEventFactory::createWebTouchEvent):

12:36 AM Changeset in webkit [135490] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

Coordinated Graphics: Remove an invisible TiledBackingStore of CoordinatedGraphicsLayer.
https://bugs.webkit.org/show_bug.cgi?id=102894

Patch by Huang Dongsung <luxtella@company100.net> on 2012-11-22
Reviewed by Kenneth Rohde Christiansen.

CoordinatedGraphicsLayer does not need to have a backing store

if (!drawsContent()
!contentsAreVisible() m_size.isEmpty()).
  • WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.cpp:

(WebCore::CoordinatedGraphicsLayer::updateContentBuffers):

12:30 AM Changeset in webkit [135489] by commit-queue@webkit.org
  • 4 edits in trunk/Tools

[EFL][WK2] Enable WKPreferences and AboutBlankLoad API tests
https://bugs.webkit.org/show_bug.cgi?id=102926

Patch by Sudarsana Nagineni <sudarsana.nagineni@intel.com> on 2012-11-22
Reviewed by Kenneth Rohde Christiansen.

Add missing bits needed by WKPreferences and AboutBlankLoad API
tests in the test harness and enable these tests on EFL port.

  • TestWebKitAPI/PlatformEfl.cmake:
  • TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:

(TestWebKitAPI::TEST):

  • TestWebKitAPI/efl/PlatformUtilities.cpp:

(TestWebKitAPI::Util::MIMETypeForWKURLResponse):
(Util):

12:13 AM Changeset in webkit [135488] by haraken@chromium.org
  • 5 edits in trunk/Source/WebCore

Unreviewed, rolling out r135482.
http://trac.webkit.org/changeset/135482
https://bugs.webkit.org/show_bug.cgi?id=103002

It broke Chrome/Linux Debug build

  • bindings/v8/V8StringResource.cpp:
  • bindings/v8/V8StringResource.h:
  • bindings/v8/V8ValueCache.cpp:

(WebCore::WebCoreStringResourceBase::toWebCoreStringResourceBase):
(WebCore):
(WebCore::WebCoreStringResourceBase::visitStrings):

  • bindings/v8/V8ValueCache.h:

(WebCore):
(WebCoreStringResourceBase):
(WebCore::WebCoreStringResourceBase::WebCoreStringResourceBase):
(WebCore::WebCoreStringResourceBase::~WebCoreStringResourceBase):
(WebCore::WebCoreStringResourceBase::webcoreString):
(WebCore::WebCoreStringResourceBase::atomicString):
(WebCore::WebCoreStringResourceBase::memoryConsumption):
(WebCoreStringResource16):
(WebCore::WebCoreStringResource16::WebCoreStringResource16):
(WebCoreStringResource8):
(WebCore::WebCoreStringResource8::WebCoreStringResource8):

12:09 AM Changeset in webkit [135487] by commit-queue@webkit.org
  • 21 edits
    1 copy in trunk/Source/WebCore

Unreviewed, rolling out r134927 and r134944.
http://trac.webkit.org/changeset/134927
http://trac.webkit.org/changeset/134944
https://bugs.webkit.org/show_bug.cgi?id=103028

Reverting the reverts after merging. (Requested by vsevik on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-11-22

  • English.lproj/localizedStrings.js:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/compile-front-end.py:
  • inspector/front-end/AdvancedSearchController.js:
  • inspector/front-end/CallStackSidebarPane.js:

(WebInspector.CallStackSidebarPane.prototype.registerShortcuts):

  • inspector/front-end/ConsoleView.js:

(WebInspector.ConsoleView.prototype._registerShortcuts):

  • inspector/front-end/ElementsPanel.js:

(WebInspector.ElementsPanel):

  • inspector/front-end/ElementsPanelDescriptor.js:

(WebInspector.ElementsPanelDescriptor.prototype.registerShortcuts):

  • inspector/front-end/GoToLineDialog.js:

(WebInspector.GoToLineDialog.install):

  • inspector/front-end/KeyboardShortcut.js:

(WebInspector.KeyboardShortcut._keyName):

  • inspector/front-end/Panel.js:

(WebInspector.Panel.prototype.registerShortcuts):
(WebInspector.PanelDescriptor.prototype.panel):
(WebInspector.PanelDescriptor.prototype.registerShortcuts):

  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel):
(WebInspector.ScriptsPanel.prototype._createDebugToolbar):
(WebInspector.ScriptsPanel.prototype._createButtonAndRegisterShortcuts):

  • inspector/front-end/ScriptsPanelDescriptor.js:

(WebInspector.ScriptsPanelDescriptor.prototype.registerShortcuts):

  • inspector/front-end/ShortcutsScreen.js:

(WebInspector.ShortcutsScreen):
(WebInspector.ShortcutsSection):
(WebInspector.ShortcutsSection.prototype._renderKey):

  • inspector/front-end/StylesSidebarPane.js:
  • inspector/front-end/TimelinePanel.js:

(WebInspector.TimelinePanel.prototype._registerShortcuts):

  • inspector/front-end/TimelinePanelDescriptor.js: Copied from Source/WebCore/inspector/front-end/ScriptsPanelDescriptor.js.

(WebInspector.TimelinePanelDescriptor):
(WebInspector.TimelinePanelDescriptor.prototype.registerShortcuts):

  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.html:
  • inspector/front-end/inspector.js:

(WebInspector._panelDescriptors):
(WebInspector._registerShortcuts):

12:06 AM Changeset in webkit [135486] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebKit2

Coordinated Graphics: refactor LayerTreeRenderer.
https://bugs.webkit.org/show_bug.cgi?id=103004

Patch by Huang Dongsung <luxtella@company100.net> on 2012-11-22
Reviewed by Noam Rosenthal.

This patch changes two subjects.

  1. Add ASSERT(isMainThread()) in all methods that are called in the main thread.

In addition, make dispatchOnMainThread() use callOnMainThread(const Function<void()>&
function) instead of its own implementation.

  1. Remove setAccelerationMode() because we don't use m_accelerationMode member

except for the setter.

  • UIProcess/API/efl/EwkViewImpl.cpp:

(EwkViewImpl::createGLSurface):

  • UIProcess/CoordinatedGraphics/LayerTreeRenderer.cpp:

(WebKit):
(WebKit::LayerTreeRenderer::dispatchOnMainThread):
(WebKit::LayerTreeRenderer::LayerTreeRenderer):
(WebKit::LayerTreeRenderer::animationFrameReady):
(WebKit::LayerTreeRenderer::updateViewport):
(WebKit::LayerTreeRenderer::renderNextFrame):
(WebKit::LayerTreeRenderer::purgeGLResources):
(WebKit::LayerTreeRenderer::detach):
(WebKit::LayerTreeRenderer::setActive):

  • UIProcess/CoordinatedGraphics/LayerTreeRenderer.h:

(LayerTreeRenderer):

  • UIProcess/efl/PageClientBase.cpp:

(WebKit::PageClientBase::createDrawingAreaProxy):

Nov 21, 2012:

11:57 PM EFLWebKit edited by tmpsantos@gmail.com
(diff)
11:54 PM Changeset in webkit [135485] by zandobersek@gmail.com
  • 2 edits in trunk/Tools

[GTK][WTR] Implement AccessibilityUIElement::stringValue
https://bugs.webkit.org/show_bug.cgi?id=102951

Reviewed by Martin Robinson.

Implement AccessibilityUIElement::stringValue in the ATK backend
in the same manner it is implemented in DumpRenderTree.

  • WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:

(WTR::replaceCharactersForResults):
(WTR):
(WTR::AccessibilityUIElement::stringValue):

11:47 PM Changeset in webkit [135484] by yurys@chromium.org
  • 11 edits in trunk/Source/WebCore

Unreviewed, rolling out r135433 and r135479.
http://trac.webkit.org/changeset/135433
http://trac.webkit.org/changeset/135479
https://bugs.webkit.org/show_bug.cgi?id=103029

"IDBRequestTest.EventsAfterStopping crashes" (Requested by
yurys on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-11-21

  • bindings/v8/DOMDataStore.cpp:

(WebCore::DOMDataStore::current):

  • bindings/v8/DOMWrapperWorld.cpp:
  • bindings/v8/DOMWrapperWorld.h:
  • bindings/v8/ScriptController.cpp:

(WebCore::ScriptController::existingWindowShell):
(WebCore::ScriptController::windowShell):
(WebCore::ScriptController::evaluateInIsolatedWorld):
(WebCore::ScriptController::currentWorldContext):
(WebCore::ScriptController::collectIsolatedContexts):

  • bindings/v8/ScriptController.h:

(ScriptController):

  • bindings/v8/V8Binding.h:

(WebCore::worldForEnteredContextIfIsolated):

  • bindings/v8/V8DOMWindowShell.cpp:

(WebCore::V8DOMWindowShell::destroyIsolatedShell):
(WebCore::isolatedContextWeakCallback):
(WebCore):
(WebCore::V8DOMWindowShell::disposeContext):
(WebCore::V8DOMWindowShell::initializeIfNeeded):
(WebCore::V8DOMWindowShell::installDOMWindow):

  • bindings/v8/V8DOMWindowShell.h:

(WebCore::V8DOMWindowShell::isolated):
(V8DOMWindowShell):

  • bindings/v8/V8PerContextData.h:
  • bindings/v8/WorldContextHandle.cpp:

(WebCore::WorldContextHandle::WorldContextHandle):

11:41 PM Changeset in webkit [135483] by pfeldman@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: simplify the _updateChunksForRanges routine
https://bugs.webkit.org/show_bug.cgi?id=102927

Reviewed by Vsevolod Vlasov.

  • inspector/front-end/DefaultTextEditor.js:

(WebInspector.TextEditorMainPanel.prototype._updateChunksForRanges):
(WebInspector.TextEditorMainChunk.prototype.updateCollapsedLineRow):
(WebInspector.TextEditorMainChunk.prototype.detachFromDOM):
(WebInspector.TextEditorMainChunk.prototype.anchorElement):

11:35 PM Changeset in webkit [135482] by haraken@chromium.org
  • 5 edits in trunk/Source/WebCore

[V8] WebCoreStringResourceBase should be located in V8StringResource.h
https://bugs.webkit.org/show_bug.cgi?id=103002

Reviewed by Adam Barth.

Currently WebCoreStringResourceBase is mis-located in V8ValueCache.h.
It should be in V8StringResource.h.

No tests. No change in behavior.

  • bindings/v8/V8StringResource.cpp:

(WebCore::WebCoreStringResourceBase::toWebCoreStringResourceBase):
(WebCore):
(WebCore::WebCoreStringResourceBase::visitStrings):

  • bindings/v8/V8StringResource.h:

(WebCore):
(WebCoreStringResourceBase):
(WebCore::WebCoreStringResourceBase::WebCoreStringResourceBase):
(WebCore::WebCoreStringResourceBase::~WebCoreStringResourceBase):
(WebCore::WebCoreStringResourceBase::webcoreString):
(WebCore::WebCoreStringResourceBase::atomicString):
(WebCore::WebCoreStringResourceBase::memoryConsumption):
(WebCoreStringResource16):
(WebCore::WebCoreStringResource16::WebCoreStringResource16):
(WebCoreStringResource8):
(WebCore::WebCoreStringResource8::WebCoreStringResource8):

  • bindings/v8/V8ValueCache.cpp:
  • bindings/v8/V8ValueCache.h:

(WebCore):

11:33 PM Changeset in webkit [135481] by commit-queue@webkit.org
  • 5 edits
    2 deletes in trunk

Unreviewed, rolling out r135464.
http://trac.webkit.org/changeset/135464
https://bugs.webkit.org/show_bug.cgi?id=103026

breaks gtk bot (Requested by morrita on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-11-21

Source/WebCore:

  • dom/Element.cpp:
  • dom/Element.h:

(Element):

  • dom/Element.idl:

LayoutTests:

  • fast/dom/shadow/shadow-aware-create-shadow-root-expected.txt: Removed.
  • fast/dom/shadow/shadow-aware-create-shadow-root.html: Removed.
11:08 PM Changeset in webkit [135480] by Vineet
  • 2 edits in trunk/Tools

Unreviewed. Adding myself to committers.py.

  • Scripts/webkitpy/common/config/committers.py:
11:04 PM Changeset in webkit [135479] by commit-queue@webkit.org
  • 11 edits in trunk/Source/WebCore

Remove V8DOMWindowShell::getEntered
https://bugs.webkit.org/show_bug.cgi?id=96637

Patch by Dan Carney <dcarney@google.com> on 2012-11-21
Reviewed by Adam Barth.

V8DOMWindowShell::getEntered was refactored so that the window shell
no longer has to be kept alive by a v8 context. Instead, only
the DOMWrapperWorld will be kept alive.

No new tests. No change in functionality.

  • bindings/v8/DOMDataStore.cpp:

(WebCore::DOMDataStore::current):

  • bindings/v8/DOMWrapperWorld.cpp:

(WebCore::isolatedWorldWeakCallback):
(WebCore):
(WebCore::DOMWrapperWorld::makeContextWeak):
(WebCore::DOMWrapperWorld::setIsolatedWorldField):

  • bindings/v8/DOMWrapperWorld.h:

(DOMWrapperWorld):
(WebCore::DOMWrapperWorld::isolated):

  • bindings/v8/ScriptController.cpp:

(WebCore::ScriptController::existingWindowShell):
(WebCore::ScriptController::windowShell):
(WebCore::ScriptController::evaluateInIsolatedWorld):
(WebCore::ScriptController::currentWorldContext):
(WebCore::ScriptController::collectIsolatedContexts):

  • bindings/v8/ScriptController.h:

(ScriptController):

  • bindings/v8/V8Binding.h:

(WebCore::worldForEnteredContextIfIsolated):

  • bindings/v8/V8DOMWindowShell.cpp:

(WebCore::V8DOMWindowShell::destroyIsolatedShell):
(WebCore::V8DOMWindowShell::disposeContext):
(WebCore::V8DOMWindowShell::initializeIfNeeded):

  • bindings/v8/V8DOMWindowShell.h:

(V8DOMWindowShell):

  • bindings/v8/V8PerContextData.h:
  • bindings/v8/WorldContextHandle.cpp:

(WebCore::WorldContextHandle::WorldContextHandle):

10:45 PM Changeset in webkit [135478] by commit-queue@webkit.org
  • 7 edits
    4 adds in trunk

Numeric identifiers of events should not be globally sequential
https://bugs.webkit.org/show_bug.cgi?id=102244

Patch by Cosmin Truta <ctruta@rim.com> on 2012-11-21
Reviewed by Alexey Proskuryakov.

Source/WebCore:

The functions setTimeout, setInterval and navigator.geolocation.watchPosition
are currently returning values that are unique across all JavaScript execution
contexts, due to their dependency on global variables.
Such a guarantee is unnecessarily strong. In this patch, we constrain uniqueness
to these functions' own script execution context only.

Tests: fast/dom/Geolocation/watchPosition-unique.html

fast/dom/Window/setTimeout-setInterval-unique.html

  • Modules/geolocation/Geolocation.cpp:

(WebCore): Remove firstAvailableWatchId.
(WebCore::Geolocation::watchPosition): Get new watchID from script execution context.
(WebCore::Geolocation::clearWatch): Invalid watchID means less than or equal to 0.

  • Modules/geolocation/Geolocation.h:

(Geolocation): Renamed the argument of Geolocation::clearWatch to WatchID.

  • dom/ScriptExecutionContext.cpp:

(WebCore::ScriptExecutionContext::ScriptExecutionContext): Update initialization.
(WebCore::ScriptExecutionContext::newUniqueID): Add.

  • dom/ScriptExecutionContext.h:

(ScriptExecutionContext): Add m_sequentialID.
(WebCore::ScriptExecutionContext::addTimeout): Inline.
(WebCore::ScriptExecutionContext::removeTimeout): Inline.
(WebCore::ScriptExecutionContext::findTimeout): Inline.

  • page/DOMTimer.cpp:

(WebCore): Remove timeoutId.
(WebCore::DOMTimer::DOMTimer): Get new timeoutId from script execution context.

LayoutTests:

Ensured that the results of setTimeout(), setInterval() and
navigator.geolocation.watchPosition() are strictly positive
and unique within their script execution context.

  • fast/dom/Geolocation/watchPosition-unique-expected.txt: Added.
  • fast/dom/Geolocation/watchPosition-unique.html: Added.
  • fast/dom/Window/setTimeout-setInterval-unique-expected.txt: Added.
  • fast/dom/Window/setTimeout-setInterval-unique.html: Added.
10:18 PM Changeset in webkit [135477] by ryuan.choi@samsung.com
  • 2 edits in trunk

[EFL] Remove unnecessary definition, -DENABLE_SPELLCHECK=1
https://bugs.webkit.org/show_bug.cgi?id=102988

Patch by Ryuan Choi <ryuan.choi@gmail.com> on 2012-11-21
Reviewed by Laszlo Gombos.

Removed -DENABLE_SPELLCHECK=1 because feature macros are controlled by
WEBKIT_OPTION_XXX and cmakeconfig.h.cmake.

  • Source/cmake/OptionsEfl.cmake:
10:18 PM Changeset in webkit [135476] by rniwa@webkit.org
  • 16 edits in trunk/Source/WebCore

CollectionType and DynamicNodeList::NodeListType should be merged
https://bugs.webkit.org/show_bug.cgi?id=102983

Reviewed by Antti Koivisto.

Merged DynamicNodeList::NodeListType (for live NodeList) into CollectionType.

  • dom/ClassNodeList.cpp:

(WebCore::ClassNodeList::~ClassNodeList):

  • dom/Document.cpp:

(WebCore::Document::registerNodeListCache):
(WebCore::Document::unregisterNodeListCache):
(WebCore::Document::getItems):

  • dom/DynamicNodeList.cpp:

(WebCore::DynamicNodeListCacheBase::invalidateCache):
(WebCore::DynamicNodeListCacheBase::invalidateIdNameCacheMaps):

  • dom/DynamicNodeList.h:

(WebCore::DynamicNodeListCacheBase::DynamicNodeListCacheBase):
(WebCore::DynamicNodeListCacheBase::hasIdNameCache): Added. Returns iff this is a HTMLCollection.
(WebCore::DynamicNodeListCacheBase::invalidateCache):
(WebCore::DynamicNodeList::DynamicNodeList):
(WebCore::DynamicSubtreeNodeList::DynamicSubtreeNodeList):

  • dom/MicroDataItemList.cpp:

(WebCore::MicroDataItemList::~MicroDataItemList):

  • dom/NameNodeList.cpp:

(WebCore::NameNodeList::~NameNodeList):

  • dom/Node.cpp:

(WebCore::Node::getElementsByTagName):
(WebCore::Node::getElementsByName):
(WebCore::Node::getElementsByClassName):
(WebCore::Node::radioNodeList):
(WebCore::Node::propertyNodeList):

  • dom/NodeRareData.h:

(WebCore::NodeListsNodeData::addCacheWithAtomicName): No longer converts CollectionType to
a NodeListType equivalent since two enums have been merged.
(WebCore::NodeListsNodeData::cacheWithAtomicName): Ditto.
(WebCore::NodeListsNodeData::addCacheWithName): Ditto.
(WebCore::NodeListsNodeData::removeCacheWithAtomicName): Ditto.
(WebCore::NodeListsNodeData::removeCacheWithName): Ditto.
(WebCore::NodeListsNodeData::namedNodeListKey): Ignore types before FirstNodeCollectionType
to minimize the hash conflicts.

  • dom/PropertyNodeList.cpp:

(WebCore::PropertyNodeList::~PropertyNodeList):

  • dom/TagNodeList.cpp:

(WebCore::TagNodeList::~TagNodeList):

  • html/CollectionType.h:

(WebCore::isNodeList): Added.

  • html/HTMLCollection.cpp:

(WebCore::shouldOnlyIncludeDirectChildren):
(WebCore::rootTypeFromCollectionType):
(WebCore::invalidationTypeExcludingIdAndNameAttributes):
(WebCore::isAcceptableElement):
(WebCore::DynamicNodeListCacheBase::iterateForNextNode):
(WebCore::DynamicNodeListCacheBase::itemBeforeOrAfter):

  • html/LabelableElement.cpp:

(WebCore::LabelableElement::labels):

  • html/LabelsNodeList.cpp:

(WebCore::LabelsNodeList::~LabelsNodeList):

  • html/RadioNodeList.cpp:

(WebCore::RadioNodeList::~RadioNodeList):

10:06 PM Changeset in webkit [135475] by tkent@chromium.org
  • 4788 edits in trunk/LayoutTests

2012-11-21 Kent Tamura <tkent@chromium.org>

[Chromium] Correct svn:mime-type for platform/chromium*//*.png

  • <Omit the file list>
9:08 PM Changeset in webkit [135474] by tkent@chromium.org
  • 339 edits in trunk/LayoutTests

2012-11-21 Kent Tamura <tkent@chromium.org>

[Chromium] Correct svn:mime-type for platform/chromium-linux//*.png

  • <Omit the file list>
8:58 PM Changeset in webkit [135473] by tkent@chromium.org
  • 299 edits in trunk/LayoutTests

2012-11-21 Kent Tamura <tkent@chromium.org>

[Chromium] Correct svn:mime-type for platform/chromium-win//*.png

  • <Omit the file list>
8:49 PM Changeset in webkit [135472] by tkent@chromium.org
  • 1820 edits in trunk/LayoutTests/platform/chromium-mac

2012-11-21 Kent Tamura <tkent@chromium.org>

[Chromium] Correct svn:mime-type for platform/chromium-mac//*.png

  • <Omit the file list>
8:34 PM Changeset in webkit [135471] by commit-queue@webkit.org
  • 7 edits in trunk/Source/WebCore

IndexedDB: Obtain ScriptState from IDL binding generator
https://bugs.webkit.org/show_bug.cgi?id=102552

Patch by Michael Pruett <michael@68k.org> on 2012-11-21
Reviewed by Kentaro Hara.

Obtain ScriptState from IDL binding generator rather than directly
calling ScriptState::current() since that method does not exist
in JSC.

Tests: storage/indexeddb/*

  • Modules/indexeddb/IDBCursor.cpp:

(WebCore::IDBCursor::update):

  • Modules/indexeddb/IDBCursor.h:

(IDBCursor):

  • Modules/indexeddb/IDBCursor.idl:
  • Modules/indexeddb/IDBObjectStore.cpp:

(WebCore::IDBObjectStore::add):
(WebCore::IDBObjectStore::put):

  • Modules/indexeddb/IDBObjectStore.h:

(WebCore::IDBObjectStore::add):
(WebCore::IDBObjectStore::put):
(IDBObjectStore):

  • Modules/indexeddb/IDBObjectStore.idl:
8:30 PM Changeset in webkit [135470] by tkent@chromium.org
  • 1 edit in trunk/LayoutTests/ChangeLog

[Chromium] Correct svn:mime-type for platform/chromium-mac//*.png

  • <Omit the file list>
8:23 PM Changeset in webkit [135469] by fpizlo@apple.com
  • 73 edits in trunk/Source

Rename dataLog() and dataLogV() to dataLogF() and dataLogFV()
https://bugs.webkit.org/show_bug.cgi?id=103001

Rubber stamped by Dan Bernstein.

Source/JavaScriptCore:

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
  • assembler/LinkBuffer.cpp:

(JSC::LinkBuffer::finalizeCodeWithDisassembly):
(JSC::LinkBuffer::dumpLinkStatistics):
(JSC::LinkBuffer::dumpCode):

  • assembler/LinkBuffer.h:

(JSC):

  • assembler/SH4Assembler.h:

(JSC::SH4Assembler::vprintfStdoutInstr):

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::dumpBytecodeCommentAndNewLine):
(JSC::CodeBlock::printUnaryOp):
(JSC::CodeBlock::printBinaryOp):
(JSC::CodeBlock::printConditionalJump):
(JSC::CodeBlock::printGetByIdOp):
(JSC::dumpStructure):
(JSC::dumpChain):
(JSC::CodeBlock::printGetByIdCacheStatus):
(JSC::CodeBlock::printCallOp):
(JSC::CodeBlock::printPutByIdOp):
(JSC::CodeBlock::printStructure):
(JSC::CodeBlock::printStructures):
(JSC::CodeBlock::dump):
(JSC::CodeBlock::dumpStatistics):
(JSC::CodeBlock::finalizeUnconditionally):
(JSC::CodeBlock::resetStubInternal):
(JSC::CodeBlock::reoptimize):
(JSC::ProgramCodeBlock::jettison):
(JSC::EvalCodeBlock::jettison):
(JSC::FunctionCodeBlock::jettison):
(JSC::CodeBlock::shouldOptimizeNow):
(JSC::CodeBlock::tallyFrequentExitSites):
(JSC::CodeBlock::dumpValueProfiles):

  • bytecode/Opcode.cpp:

(JSC::OpcodeStats::~OpcodeStats):

  • bytecode/SamplingTool.cpp:

(JSC::SamplingFlags::stop):
(JSC::SamplingRegion::dumpInternal):
(JSC::SamplingTool::dump):

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::initialize):
(JSC::DFG::AbstractState::endBasicBlock):
(JSC::DFG::AbstractState::mergeStateAtTail):
(JSC::DFG::AbstractState::mergeToSuccessors):

  • dfg/DFGAbstractValue.h:

(JSC::DFG::AbstractValue::dump):

  • dfg/DFGArgumentsSimplificationPhase.cpp:

(JSC::DFG::ArgumentsSimplificationPhase::run):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::injectLazyOperandSpeculation):
(JSC::DFG::ByteCodeParser::getPredictionWithoutOSRExit):
(JSC::DFG::ByteCodeParser::getArrayModeAndEmitChecks):
(JSC::DFG::ByteCodeParser::makeSafe):
(JSC::DFG::ByteCodeParser::makeDivSafe):
(JSC::DFG::ByteCodeParser::handleCall):
(JSC::DFG::ByteCodeParser::handleInlining):
(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::processPhiStack):
(JSC::DFG::ByteCodeParser::linkBlock):
(JSC::DFG::ByteCodeParser::InlineStackEntry::InlineStackEntry):
(JSC::DFG::ByteCodeParser::parseCodeBlock):
(JSC::DFG::ByteCodeParser::parse):

  • dfg/DFGCFAPhase.cpp:

(JSC::DFG::CFAPhase::performBlockCFA):
(JSC::DFG::CFAPhase::performForwardCFA):

  • dfg/DFGCFGSimplificationPhase.cpp:

(JSC::DFG::CFGSimplificationPhase::run):
(JSC::DFG::CFGSimplificationPhase::fixPossibleGetLocal):
(JSC::DFG::CFGSimplificationPhase::fixPhis):
(JSC::DFG::CFGSimplificationPhase::fixJettisonedPredecessors):
(JSC::DFG::CFGSimplificationPhase::removePotentiallyDeadPhiReference):
(JSC::DFG::CFGSimplificationPhase::mergeBlocks):

  • dfg/DFGCSEPhase.cpp:

(JSC::DFG::CSEPhase::endIndexForPureCSE):
(JSC::DFG::CSEPhase::setReplacement):
(JSC::DFG::CSEPhase::eliminate):
(JSC::DFG::CSEPhase::performNodeCSE):

  • dfg/DFGCapabilities.cpp:

(JSC::DFG::debugFail):

  • dfg/DFGConstantFoldingPhase.cpp:

(JSC::DFG::ConstantFoldingPhase::foldConstants):
(JSC::DFG::ConstantFoldingPhase::paintUnreachableCode):

  • dfg/DFGDisassembler.cpp:

(JSC::DFG::Disassembler::dump):

  • dfg/DFGDriver.cpp:

(JSC::DFG::compile):

  • dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):
(JSC::DFG::FixupPhase::fixDoubleEdge):

  • dfg/DFGGraph.cpp:

(JSC::DFG::printWhiteSpace):
(JSC::DFG::Graph::dumpCodeOrigin):
(JSC::DFG::Graph::dump):
(JSC::DFG::Graph::dumpBlockHeader):
(JSC::DFG::Graph::predictArgumentTypes):

  • dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::link):

  • dfg/DFGOSREntry.cpp:

(JSC::DFG::prepareOSREntry):

  • dfg/DFGOSRExitCompiler.cpp:
  • dfg/DFGOSRExitCompiler32_64.cpp:

(JSC::DFG::OSRExitCompiler::compileExit):

  • dfg/DFGOSRExitCompiler64.cpp:

(JSC::DFG::OSRExitCompiler::compileExit):

  • dfg/DFGOperations.cpp:
  • dfg/DFGPhase.cpp:

(JSC::DFG::Phase::beginPhase):

  • dfg/DFGPhase.h:

(JSC::DFG::runAndLog):

  • dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::propagate):
(JSC::DFG::PredictionPropagationPhase::propagateForward):
(JSC::DFG::PredictionPropagationPhase::propagateBackward):
(JSC::DFG::PredictionPropagationPhase::doRoundOfDoubleVoting):

  • dfg/DFGRegisterBank.h:

(JSC::DFG::RegisterBank::dump):

  • dfg/DFGScoreBoard.h:

(JSC::DFG::ScoreBoard::use):
(JSC::DFG::ScoreBoard::dump):

  • dfg/DFGSlowPathGenerator.h:

(JSC::DFG::SlowPathGenerator::generate):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::terminateSpeculativeExecution):
(JSC::DFG::SpeculativeJIT::terminateSpeculativeExecutionWithConditionalDirection):
(JSC::DFG::SpeculativeJIT::runSlowPathGenerators):
(JSC::DFG::SpeculativeJIT::dump):
(JSC::DFG::SpeculativeJIT::checkConsistency):
(JSC::DFG::SpeculativeJIT::compile):
(JSC::DFG::SpeculativeJIT::checkGeneratedTypeForToInt32):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::fillSpeculateIntInternal):
(JSC::DFG::SpeculativeJIT::fillSpeculateDouble):
(JSC::DFG::SpeculativeJIT::fillSpeculateCell):
(JSC::DFG::SpeculativeJIT::fillSpeculateBoolean):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::fillSpeculateIntInternal):
(JSC::DFG::SpeculativeJIT::fillSpeculateDouble):
(JSC::DFG::SpeculativeJIT::fillSpeculateCell):
(JSC::DFG::SpeculativeJIT::fillSpeculateBoolean):

  • dfg/DFGStructureCheckHoistingPhase.cpp:

(JSC::DFG::StructureCheckHoistingPhase::run):

  • dfg/DFGValidate.cpp:

(Validate):
(JSC::DFG::Validate::reportValidationContext):
(JSC::DFG::Validate::dumpData):
(JSC::DFG::Validate::dumpGraphIfAppropriate):

  • dfg/DFGVariableEventStream.cpp:

(JSC::DFG::VariableEventStream::logEvent):
(JSC::DFG::VariableEventStream::reconstruct):

  • dfg/DFGVirtualRegisterAllocationPhase.cpp:

(JSC::DFG::VirtualRegisterAllocationPhase::run):

  • heap/Heap.cpp:
  • heap/HeapStatistics.cpp:

(JSC::HeapStatistics::logStatistics):
(JSC::HeapStatistics::showObjectStatistics):

  • heap/MarkStack.h:
  • heap/MarkedBlock.h:
  • heap/SlotVisitor.cpp:

(JSC::SlotVisitor::validate):

  • interpreter/CallFrame.cpp:

(JSC::CallFrame::dumpCaller):

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::dumpRegisters):

  • jit/JIT.cpp:

(JSC::JIT::privateCompileMainPass):
(JSC::JIT::privateCompileSlowCases):
(JSC::JIT::privateCompile):

  • jit/JITDisassembler.cpp:

(JSC::JITDisassembler::dump):
(JSC::JITDisassembler::dumpForInstructions):

  • jit/JITStubRoutine.h:

(JSC):

  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

  • jit/JumpReplacementWatchpoint.cpp:

(JSC::JumpReplacementWatchpoint::fireInternal):

  • llint/LLIntExceptions.cpp:

(JSC::LLInt::interpreterThrowInCaller):
(JSC::LLInt::returnToThrow):
(JSC::LLInt::callToThrow):

  • llint/LLIntSlowPaths.cpp:

(JSC::LLInt::llint_trace_operand):
(JSC::LLInt::llint_trace_value):
(JSC::LLInt::LLINT_SLOW_PATH_DECL):
(JSC::LLInt::traceFunctionPrologue):
(JSC::LLInt::jitCompileAndSetHeuristics):
(JSC::LLInt::entryOSR):
(JSC::LLInt::handleHostCall):
(JSC::LLInt::setUpCall):

  • profiler/Profile.cpp:

(JSC::Profile::debugPrintData):
(JSC::Profile::debugPrintDataSampleStyle):

  • profiler/ProfileNode.cpp:

(JSC::ProfileNode::debugPrintData):
(JSC::ProfileNode::debugPrintDataSampleStyle):

  • runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::dumpRegExpTrace):

  • runtime/RegExp.cpp:

(JSC::RegExp::matchCompareWithInterpreter):

  • runtime/SamplingCounter.cpp:

(JSC::AbstractSamplingCounter::dump):

  • runtime/Structure.cpp:

(JSC::Structure::dumpStatistics):
(JSC::PropertyMapStatisticsExitLogger::~PropertyMapStatisticsExitLogger):

  • tools/CodeProfile.cpp:

(JSC::CodeProfile::report):

  • tools/ProfileTreeNode.h:

(JSC::ProfileTreeNode::dumpInternal):

  • yarr/YarrInterpreter.cpp:

(JSC::Yarr::ByteCompiler::dumpDisjunction):

Source/WebCore:

No change in behavior, so no new tests.

  • platform/KURLWTFURL.cpp:

(WebCore::KURL::print):

Source/WTF:

  • wtf/DataLog.cpp:

(WTF::dataLogFV):
(WTF::dataLogF):
(WTF::dataLogFString):

  • wtf/DataLog.h:

(WTF):

  • wtf/HashTable.cpp:

(WTF::HashTableStats::dumpStats):

  • wtf/HashTable.h:

(WTF::HashTable::Stats::dumpStats):

  • wtf/MetaAllocator.cpp:

(WTF::MetaAllocator::dumpProfile):

  • wtf/StackStats.cpp:

(WTF::StackStats::initialize):
(WTF::StackStats::PerThreadStats::PerThreadStats):
(WTF::StackStats::CheckPoint::CheckPoint):
(WTF::StackStats::CheckPoint::~CheckPoint):
(WTF::StackStats::probe):
(WTF::StackStats::LayoutCheckPoint::LayoutCheckPoint):

  • wtf/text/WTFString.cpp:

(String::show):

8:11 PM Changeset in webkit [135468] by commit-queue@webkit.org
  • 5 edits
    10 adds in trunk/Source/WebCore

[EFL] Refactor GraphicsContext3DEFL.
https://bugs.webkit.org/show_bug.cgi?id=101291.

Patch by Kondapally Kalyan <kalyan.kondapally@intel.com> on 2012-11-21
Reviewed by Kenneth Rohde Christiansen.

GraphicsContext3DEfl creates GraphicsContext3DPrivate, which acts as its platform Layer.
GraphicsContext3DPrivate needs to handle the following cases:
1) To provide an off-screen buffer for accelerated composition.
2) Render to a current context.
3) To render directly to host window. (currently not supported.)

Before this patch Evas was used to provide us an off-screen context and buffer. GLX was used in
the other supported case. Evas acts as a glue layer to provide us with appropriate
GL bindings (OpenGL functions), GL context and drawable (surface/offscreenbuffer).
However, primitive rendering is handled by TextureMapper and OpenGLShims is used to load the needed GL functions.

It would be for our advantage to be able to take in to use any optimisations/extensions
provided by underlying drivers, specific to a platform (e.g. GLX_MESA_copy_sub_buffer etc.).
This patch introduces an abstraction layer to make it easy to add support for any GL backend (GLX, EGL etc.)
and do any platform specific optimizations as needed without complicating GraphicsContext3DPrivate class.
Two new classes are added with this implementation, GLPlatformContext and GLPlatformSurface.
GraphicsContext3DPrivate would create and own a GLPlatformContext and GLPlatformSurface.

GLPlatformContext encapsulates an OpenGL context hiding any platform specific management.
It uses GL extension ARB_robustness (when available) to detect driver resets.
It defines a simple interface for things that need to be handled by the context. Support
for multi-threaded usage and shared context-group would be added later.

GLPlatformSurface encapsulates an OpenGL drawable hiding any platform specific management.
It defines a simple interface for things that need to be handled by the surface.
It creates an off-screen rendering area. Any GLPlatformContext (compatible with the surface)
can be used to render into this off-screen area.

This patch also adds GLX implementation. To keep the patch to minimum EGL support would be added in another changeset.

  • PlatformEfl.cmake:
  • platform/graphics/efl/GraphicsContext3DEfl.cpp:

(WebCore::GraphicsContext3D::create):
(WebCore::GraphicsContext3D::GraphicsContext3D):
(WebCore::GraphicsContext3D::~GraphicsContext3D):
(WebCore::GraphicsContext3D::makeContextCurrent):
(WebCore::GraphicsContext3D::setContextLostCallback):

  • platform/graphics/efl/GraphicsContext3DPrivate.cpp:

(WebCore::GraphicsContext3DPrivate::GraphicsContext3DPrivate):
(GraphicsContext3DPrivate::~GraphicsContext3DPrivate):
(GraphicsContext3DPrivate::releaseResources):
(GraphicsContext3DPrivate::setContextLostCallback):
(GraphicsContext3DPrivate::platformGraphicsContext3D):
(GraphicsContext3DPrivate::makeContextCurrent):
(GraphicsContext3DPrivate::createGraphicsSurfaces):
(GraphicsContext3DPrivate::copyToGraphicsSurface):
(GraphicsContext3DPrivate::graphicsSurfaceToken):

  • platform/graphics/efl/GraphicsContext3DPrivate.h:

(GraphicsContext3DPrivate):

  • platform/graphics/opengl/GLDefs.h: Added.

(WebCore):

  • platform/graphics/opengl/GLPlatformContext.cpp: Added.

(WebCore):
(WebCore::GLPlatformContext::createContext):
(WebCore::GLPlatformContext::createOffScreenContext):
(WebCore::GLPlatformContext::createCurrentContextWrapper):
(WebCore::GLPlatformContext::GLPlatformContext):
(WebCore::GLPlatformContext::~GLPlatformContext):
(WebCore::GLPlatformContext::makeCurrent):
(WebCore::GLPlatformContext::isValid):
(WebCore::GLPlatformContext::releaseCurrent):
(WebCore::GLPlatformContext::handle):
(WebCore::GLPlatformContext::isCurrentContext):
(WebCore::GLPlatformContext::initialize):
(WebCore::GLPlatformContext::getCurrent):
(WebCore::GLPlatformContext::platformMakeCurrent):
(WebCore::GLPlatformContext::platformReleaseCurrent):
(WebCore::GLPlatformContext::destroy):

  • platform/graphics/opengl/GLPlatformContext.h: Added.

(WebCore):
(GLPlatformContext):

  • platform/graphics/opengl/GLPlatformSurface.cpp: Added.

(WebCore):
(WebCore::GLPlatformSurface::createOffscreenSurface):
(WebCore::GLPlatformSurface::createTransportSurface):
(WebCore::GLPlatformSurface::GLPlatformSurface):
(WebCore::GLPlatformSurface::~GLPlatformSurface):
(WebCore::GLPlatformSurface::handle):
(WebCore::GLPlatformSurface::geometry):
(WebCore::GLPlatformSurface::sharedDisplay):
(WebCore::GLPlatformSurface::configuration):
(WebCore::GLPlatformSurface::swapBuffers):
(WebCore::GLPlatformSurface::copyTexture):
(WebCore::GLPlatformSurface::updateContents):
(WebCore::GLPlatformSurface::setGeometry):
(WebCore::GLPlatformSurface::destroy):

  • platform/graphics/opengl/GLPlatformSurface.h: Added.

(WebCore):
(GLPlatformSurface):

GLXOffScreenContext creates an off-screen context. This is used when
renderstyle is RenderOffscreen.
It uses GL extension GLX_ARB_create_context (when available)
to create a context else falls back to use glXCreateNewContext.

  • platform/graphics/surfaces/glx/GLXContext.cpp: Added.

(WebCore):
(WebCore::initializeARBExtensions):
(WebCore::GLXOffScreenContext::GLXOffScreenContext):
(WebCore::GLXOffScreenContext::initialize):
(WebCore::GLXOffScreenContext::~GLXOffScreenContext):
(WebCore::GLXOffScreenContext::isCurrentContext):
(WebCore::GLXOffScreenContext::platformMakeCurrent):
(WebCore::GLXOffScreenContext::platformReleaseCurrent):
(WebCore::GLXOffScreenContext::freeResources):
(WebCore::GLXOffScreenContext::destroy):

GLXCurrentContextWrapper acts as a wrapper for current context.
This is used when renderstyle is RenderToCurrentGLContext.

  • platform/graphics/surfaces/glx/GLXContext.h: Added.

(WebCore):
(GLXCurrentContextWrapper):
(WebCore::GLXCurrentContextWrapper::GLXCurrentContextWrapper):
(WebCore::GLXCurrentContextWrapper::~GLXCurrentContextWrapper):
(GLXOffScreenContext):

  • platform/graphics/surfaces/glx/GLXSurface.cpp: Added.

(WebCore):
(WebCore::GLXSurface::GLXSurface):
(WebCore::GLXSurface::~GLXSurface):
(WebCore::GLXSurface::visualInfo):
(WebCore::GLXSurface::xWindow):
(WebCore::GLXSurface::pBufferConfiguration):
(WebCore::GLXSurface::transportSurfaceConfiguration):
(WebCore::GLXSurface::isXRenderExtensionSupported):

GLXTransportSurface creates Window and uses it as an off-screen surface.
Any GLContext that was created with respect to configuration can be used
to render into this.
This is used when contents of the buffer are to be provided to UI Process
for display.

(WebCore::GLXTransportSurface::GLXTransportSurface):
(WebCore::GLXTransportSurface::~GLXTransportSurface):
(WebCore::GLXTransportSurface::configuration):
(WebCore::GLXTransportSurface::swapBuffers):
(WebCore::GLXTransportSurface::setGeometry):
(WebCore::GLXTransportSurface::initialize):
(WebCore::GLXTransportSurface::destroy):
(WebCore::GLXTransportSurface::freeResources):

GLXPBuffer, Creates a GL surface (PBuffer) used for offscreen rendering.
Any GLContext that was created with respect to configuration can be used
to render into this.

(WebCore::GLXPBuffer::GLXPBuffer):
(WebCore::GLXPBuffer::~GLXPBuffer):
(WebCore::GLXPBuffer::initialize):
(WebCore::GLXPBuffer::configuration):
(WebCore::GLXPBuffer::destroy):
(WebCore::GLXPBuffer::freeResources):

  • platform/graphics/surfaces/glx/GLXSurface.h: Added.

(WebCore):

Creates X resources which are shared between surface and context.

(SharedX11Resources):
(WebCore::SharedX11Resources::create):
(WebCore::SharedX11Resources::deref):
(WebCore::SharedX11Resources::getXWindow):
(WebCore::SharedX11Resources::display):
(WebCore::SharedX11Resources::visualInfo):
(WebCore::SharedX11Resources::createConfig):
(WebCore::SharedX11Resources::pBufferContextConfig):
(WebCore::SharedX11Resources::surfaceContextConfig):
(WebCore::SharedX11Resources::isXRenderExtensionSupported):
(WebCore::SharedX11Resources::SharedX11Resources):
(WebCore::SharedX11Resources::~SharedX11Resources):
(GLXSurface):
(GLXTransportSurface):
(GLXPBuffer):

8:01 PM Changeset in webkit [135467] by tkent@chromium.org
  • 41 edits
    24 adds in trunk/LayoutTests

[Chromium] Rebaselin for recent forms changes.

  • platform/chromium-linux-x86/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-rtl-expected.png: Added.
  • platform/chromium-linux/fast/forms/datetime/datetime-appearance-l10n-expected.png: Added.
  • platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-expected.png:
  • platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png:
  • platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-step-expected.png:
  • platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-expected.png:
  • platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-step-expected.png:
  • platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-expected.png:
  • platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-step-expected.png:
  • platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-expected.png: Added.
  • platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-rtl-expected.png: Added.
  • platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-with-scroll-bar-expected.png: Added.
  • platform/chromium-mac-lion/fast/forms/datetime/datetime-appearance-l10n-expected.png: Added.
  • platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-expected.png:
  • platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png:
  • platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-step-expected.png:
  • platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-expected.png:
  • platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-step-expected.png:
  • platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-expected.png:
  • platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-step-expected.png:
  • platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-expected.png: Added.
  • platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-rtl-expected.png: Added.
  • platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-with-scroll-bar-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/datetime/datetime-appearance-l10n-expected.png: Added.
  • platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-expected.png:
  • platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png:
  • platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-step-expected.png:
  • platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-expected.png:
  • platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-step-expected.png:
  • platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-expected.png:
  • platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-step-expected.png:
  • platform/chromium-mac-snowleopard/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-expected.png: Added.
  • platform/chromium-mac-snowleopard/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-rtl-expected.png: Added.
  • platform/chromium-mac-snowleopard/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-with-scroll-bar-expected.png: Added.
  • platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-expected.png:
  • platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png:
  • platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-step-expected.png:
  • platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-expected.png:
  • platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-step-expected.png:
  • platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-expected.png:
  • platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-step-expected.png:
  • platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-expected.png:
  • platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-rtl-expected.png:
  • platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-with-scroll-bar-expected.png:
  • platform/chromium-win-xp/fast/forms/datetime/datetime-appearance-l10n-expected.png: Added.
  • platform/chromium-win-xp/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png:
  • platform/chromium-win-xp/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-rtl-expected.png: Added.
  • platform/chromium-win/fast/forms/datetime/datetime-appearance-l10n-expected.png: Added.
  • platform/chromium-win/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-expected.png:
  • platform/chromium-win/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png:
  • platform/chromium-win/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-step-expected.png:
  • platform/chromium-win/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-expected.png:
  • platform/chromium-win/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-step-expected.png:
  • platform/chromium-win/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-expected.png:
  • platform/chromium-win/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-step-expected.png:
  • platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-expected.png: Added.
  • platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-rtl-expected.png: Added.
  • platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-with-scroll-bar-expected.png: Added.
  • platform/chromium/TestExpectations:
7:47 PM Changeset in webkit [135466] by fpizlo@apple.com
  • 10 edits
    1 add in trunk/Source/JavaScriptCore

It should be possible to say disassemble(stuff) instead of having to say if (!tryToDisassemble(stuff)) dataLog("I failed")
https://bugs.webkit.org/show_bug.cgi?id=103010

Reviewed by Anders Carlsson.

You can still say tryToDisassemble(), which will tell you if it failed; you can then
decide what to do instead. But it's better to say disassemble(), which will just print
the instruction ranges if tryToDisassemble() failed. This is particularly appropriate
since that's what all previous users of tryToDisassemble() would have done in some
form or another.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • Target.pri:
  • assembler/LinkBuffer.cpp:

(JSC::LinkBuffer::finalizeCodeWithDisassembly):

  • dfg/DFGDisassembler.cpp:

(JSC::DFG::Disassembler::dumpDisassembly):

  • disassembler/Disassembler.cpp: Added.

(JSC):
(JSC::disassemble):

  • disassembler/Disassembler.h:

(JSC):

  • jit/JITDisassembler.cpp:

(JSC::JITDisassembler::dumpDisassembly):

7:45 PM Changeset in webkit [135465] by akling@apple.com
  • 29 edits in trunk/Source/WebCore

Re-virtualize CSSRule.
<http://webkit.org/b/103003>

Reviewed by Anders Carlsson.

Make CSSRule virtual once again, since it's no longer important to keep it as small as possible.
StyleRuleBase and its various subclasses are the relevant ones now.

  • css/CSSCharsetRule.cpp:

(WebCore::CSSCharsetRule::CSSCharsetRule):
(WebCore::CSSCharsetRule::reportMemoryUsage):

  • css/CSSCharsetRule.h:

(WebCore::CSSCharsetRule::~CSSCharsetRule):
(WebCore::CSSCharsetRule::encoding):
(WebCore::CSSCharsetRule::setEncoding):

  • css/CSSFontFaceRule.cpp:

(WebCore::CSSFontFaceRule::CSSFontFaceRule):
(WebCore::CSSFontFaceRule::reattach):
(WebCore::CSSFontFaceRule::reportMemoryUsage):

  • css/CSSFontFaceRule.h:

(CSSFontFaceRule):

  • css/CSSImportRule.cpp:

(WebCore::CSSImportRule::CSSImportRule):
(WebCore::CSSImportRule::reportMemoryUsage):
(WebCore::CSSImportRule::reattach):
(WebCore):

  • css/CSSImportRule.h:

(CSSImportRule):

  • css/CSSMediaRule.cpp:

(WebCore::CSSMediaRule::CSSMediaRule):
(WebCore::CSSMediaRule::reattach):
(WebCore::CSSMediaRule::reportMemoryUsage):

  • css/CSSMediaRule.h:

(CSSMediaRule):

  • css/CSSPageRule.cpp:

(WebCore::CSSPageRule::CSSPageRule):
(WebCore::CSSPageRule::reattach):
(WebCore::CSSPageRule::reportMemoryUsage):

  • css/CSSPageRule.h:

(CSSPageRule):

  • css/CSSRule.cpp:

(SameSizeAsCSSRule):
(WebCore::CSSRule::reportMemoryUsage):

  • css/CSSRule.h:

(WebCore::CSSRule::~CSSRule):
(CSSRule):
(WebCore::CSSRule::CSSRule):

  • css/CSSStyleRule.cpp:

(WebCore::CSSStyleRule::CSSStyleRule):
(WebCore::CSSStyleRule::reattach):
(WebCore::CSSStyleRule::reportMemoryUsage):

  • css/CSSStyleRule.h:

(CSSStyleRule):
(WebCore::CSSStyleRule::type):

  • css/CSSStyleSheet.cpp:

(WebCore::CSSStyleSheet::rules):

  • css/CSSUnknownRule.h:

(WebCore::CSSUnknownRule::CSSUnknownRule):
(WebCore::CSSUnknownRule::~CSSUnknownRule):

  • css/StyleResolver.cpp:

(WebCore::collectCSSOMWrappers):

  • css/WebKitCSSKeyframeRule.cpp:

(WebCore::WebKitCSSKeyframeRule::WebKitCSSKeyframeRule):
(WebCore::WebKitCSSKeyframeRule::reportMemoryUsage):
(WebCore::WebKitCSSKeyframeRule::reattach):
(WebCore):

  • css/WebKitCSSKeyframeRule.h:

(WebKitCSSKeyframeRule):

  • css/WebKitCSSKeyframesRule.cpp:

(WebCore::WebKitCSSKeyframesRule::WebKitCSSKeyframesRule):
(WebCore::WebKitCSSKeyframesRule::reattach):
(WebCore::WebKitCSSKeyframesRule::reportMemoryUsage):

  • css/WebKitCSSKeyframesRule.h:

(WebKitCSSKeyframesRule):

  • css/WebKitCSSRegionRule.cpp:

(WebCore::WebKitCSSRegionRule::WebKitCSSRegionRule):
(WebCore::WebKitCSSRegionRule::reattach):
(WebCore::WebKitCSSRegionRule::reportMemoryUsage):

  • css/WebKitCSSRegionRule.h:

(WebKitCSSRegionRule):

  • css/WebKitCSSViewportRule.cpp:

(WebCore::WebKitCSSViewportRule::WebKitCSSViewportRule):
(WebCore::WebKitCSSViewportRule::reattach):
(WebCore::WebKitCSSViewportRule::reportMemoryUsage):

  • css/WebKitCSSViewportRule.h:
  • inspector/InspectorCSSAgent.cpp:

(WebCore::InspectorCSSAgent::asCSSStyleRule):
(WebCore::InspectorCSSAgent::collectStyleSheets):

  • inspector/InspectorStyleSheet.cpp:

(WebCore::asCSSRuleList):
(WebCore::fillMediaListChain):

  • page/PageSerializer.cpp:

(WebCore::PageSerializer::serializeCSSStyleSheet):

7:15 PM Changeset in webkit [135464] by morrita@google.com
  • 5 edits
    2 adds in trunk

[Shadow DOM] Implement Element::createShadowRoot()
https://bugs.webkit.org/show_bug.cgi?id=102911

Reviewed by Kentaro Hara.

Source/WebCore:

Added an API implementation and exposed it.

This is basically an alias of the ShadowRoot constructor, which
will be removed as bug 102913.

Test: fast/dom/shadow/shadow-aware-create-shdow-root.html

  • dom/Element.cpp:

(WebCore::Element::createShadowRoot):
(WebCore):

  • dom/Element.h:

(Element):

  • dom/Element.idl:

LayoutTests:

The coverage might not seem comprehensive at a glance. However,
this is just an alias of ShadowRoot constructor and there are
bunch of test cases which cover it.

As bug 102913 will convert such callsites to use createShadowRoot(),
the API will get be covered well then.

  • fast/dom/shadow/shadow-aware-create-shdow-root-expected.txt: Added.
  • fast/dom/shadow/shadow-aware-create-shdow-root.html: Added. Further ShadowAware API will come here.
7:08 PM Changeset in webkit [135463] by commit-queue@webkit.org
  • 2 edits in trunk

[EFL] GLX detection is broken.
https://bugs.webkit.org/show_bug.cgi?id=102687.

Patch by Kondapally Kalyan <kalyan.kondapally@intel.com> on 2012-11-21
Reviewed by Laszlo Gombos.

HAVE_GLX is enabled only if WebGL is enabled. This is wrong and we should
explicitly test for GLX support.
This patch makes changes so that we check for glx.h header and sets HAVE_GLX flag appropriately.

  • Source/cmake/OptionsEfl.cmake:
7:05 PM Changeset in webkit [135462] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

dumpOperands() claims that it needs a non-const Operands& when that is completely false
https://bugs.webkit.org/show_bug.cgi?id=103005

Reviewed by Eric Carlson.

  • bytecode/Operands.h:

(JSC::dumpOperands):
(JSC):

6:06 PM Changeset in webkit [135461] by commit-queue@webkit.org
  • 11 edits in trunk/Source/WebKit2

[EFL][WK2] Use consistent class names in the clients
https://bugs.webkit.org/show_bug.cgi?id=102684

Patch by Jinwoo Song <jinwoo7.song@samsung.com> on 2012-11-21
Reviewed by Gyuyoung Kim.

WebKit EFL classes do not use '_' since r135117 but '_' is still remained
in some clients classes. This patch removed the '_' to make class names
to be consistent.

  • UIProcess/efl/ContextHistoryClientEfl.cpp:

(WebKit::ContextHistoryClientEfl::didNavigateWithNavigationData):

  • UIProcess/efl/DownloadManagerEfl.cpp:

(WebKit::DownloadManagerEfl::didFail):

  • UIProcess/efl/FormClientEfl.cpp:

(WebKit::FormClientEfl::willSubmitForm):

  • UIProcess/efl/PageLoadClientEfl.cpp:

(WebKit::PageLoadClientEfl::didReceiveIntentForFrame):
(WebKit::PageLoadClientEfl::registerIntentServiceForFrame):
(WebKit::PageLoadClientEfl::didFailLoadWithErrorForFrame):
(WebKit::PageLoadClientEfl::didFailProvisionalLoadWithErrorForFrame):
(WebKit::PageLoadClientEfl::didReceiveAuthenticationChallengeInFrame):

  • UIProcess/efl/PagePolicyClientEfl.cpp:

(WebKit::PagePolicyClientEfl::decidePolicyForNavigationAction):
(WebKit::PagePolicyClientEfl::decidePolicyForNewWindowAction):

  • UIProcess/efl/PageUIClientEfl.cpp:

(WebKit::PageUIClientEfl::runOpenPanel):

  • UIProcess/efl/RequestManagerClientEfl.cpp:

(WebKit::EwkUrlSchemeHandler::EwkUrlSchemeHandler):
(WebKit::RequestManagerClientEfl::didReceiveURIRequest):
(WebKit::RequestManagerClientEfl::registerURLSchemeHandler):

  • UIProcess/efl/RequestManagerClientEfl.h:

(RequestManagerClientEfl):

  • UIProcess/efl/ResourceLoadClientEfl.cpp:

(WebKit::ResourceLoadClientEfl::didInitiateLoadForResource):
(WebKit::ResourceLoadClientEfl::didSendRequestForResource):
(WebKit::ResourceLoadClientEfl::didReceiveResponseForResource):
(WebKit::ResourceLoadClientEfl::didFinishLoadForResource):
(WebKit::ResourceLoadClientEfl::didFailLoadForResource):

  • UIProcess/efl/ResourceLoadClientEfl.h:

(ResourceLoadClientEfl):

5:21 PM Changeset in webkit [135460] by danakj@chromium.org
  • 2 edits in trunk/LayoutTests

Remove crashing expectation for css3/filters/effect-reference-ordering-hw.html
https://bugs.webkit.org/show_bug.cgi?id=102898

Unreviewed test expectations.

  • platform/chromium/TestExpectations:
5:06 PM Changeset in webkit [135459] by commit-queue@webkit.org
  • 8 edits in trunk

[chromium] Device scale factor should be no-op when applyDeviceScaleFactorInCompositor == 0
https://bugs.webkit.org/show_bug.cgi?id=100061

Patch by Tien-Ren Chen <trchen@chromium.org> on 2012-11-21
Reviewed by Adam Barth.

On Android we're using a different pixel scaling implementation
(WebCore::Settings::applyDefaultDeviceScaleFactorInCompositor() == 0) than other
platforms. In this mode, we don't make use of device-independent pixels. Device
scale factor is provided to WebKit and get merged into page scale factor. Other
than that device scale factor should have no effects on rendering.

Source/WebKit/chromium:

  • src/PageWidgetDelegate.cpp:

(WebKit::PageWidgetDelegate::paint):

  • src/PageWidgetDelegate.h:
  • src/WebPagePopupImpl.cpp:

(WebKit::WebPagePopupImpl::paint):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::paint):
(WebKit::WebViewImpl::shouldApplyDeviceScaleFactorInCompositor):
(WebKit):

  • src/WebViewImpl.h:

(WebViewImpl):

Tools:

  • DumpRenderTree/chromium/WebPreferences.cpp:

(WebPreferences::applyTo):

4:50 PM Changeset in webkit [135458] by simonjam@chromium.org
  • 7 edits in trunk/Source/WebCore

[Resource Timing] Populate PerformanceResourceTiming structs with timing data
https://bugs.webkit.org/show_bug.cgi?id=102862

Reviewed by Tony Gentilcore.

This allows CachedResourceLoader to pass in all of the necessary values and populates
them in the PerformanceResourceTiming struct. A follow up patch will actually call
addResourceTiming() as necessary.

Tests: http/tests/w3c/webperf/submission/resource-timing

  • page/Performance.cpp:

(WebCore::Performance::addResourceTiming): Accept all necessary timing data.

  • page/Performance.h:

(WebCore):
(Performance):

  • page/PerformanceEntry.cpp:

(WebCore::PerformanceEntry::PerformanceEntry):

  • page/PerformanceEntry.h:

(PerformanceEntry):

  • page/PerformanceResourceTiming.cpp:

(WebCore::monotonicTimeToDocumentMilliseconds):
(WebCore):
(WebCore::PerformanceResourceTiming::PerformanceResourceTiming):
(WebCore::PerformanceResourceTiming::initiatorType): Return the spec'd values.
(WebCore::PerformanceResourceTiming::fetchStart):
(WebCore::PerformanceResourceTiming::domainLookupStart):
(WebCore::PerformanceResourceTiming::domainLookupEnd):
(WebCore::PerformanceResourceTiming::connectStart):
(WebCore::PerformanceResourceTiming::connectEnd):
(WebCore::PerformanceResourceTiming::secureConnectionStart):
(WebCore::PerformanceResourceTiming::requestStart):
(WebCore::PerformanceResourceTiming::responseStart):
(WebCore::PerformanceResourceTiming::responseEnd):
(WebCore::PerformanceResourceTiming::resourceTimeToDocumentMilliseconds):

  • page/PerformanceResourceTiming.h:

(WebCore::PerformanceResourceTiming::create):
(PerformanceResourceTiming):

4:46 PM Changeset in webkit [135457] by fpizlo@apple.com
  • 11 edits
    2 adds in trunk/Source/JavaScriptCore

Baseline JIT's disassembly should be just as pretty as the DFG's
https://bugs.webkit.org/show_bug.cgi?id=102873

Reviewed by Sam Weinig.

Integrated the CodeBlock's bytecode dumper with the JIT's disassembler. Also fixed
some type goof-ups (instructions are not in a Vector<Instruction> so using a Vector
iterator makes no sense) and stream-lined some things (you don't actually need a
full-fledged ExecState* to dump bytecode).

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • Target.pri:
  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::printUnaryOp):
(JSC::CodeBlock::printBinaryOp):
(JSC::CodeBlock::printConditionalJump):
(JSC::CodeBlock::printGetByIdOp):
(JSC::CodeBlock::printCallOp):
(JSC::CodeBlock::printPutByIdOp):
(JSC::CodeBlock::dump):
(JSC):
(JSC::CodeBlock::CodeBlock):

  • bytecode/CodeBlock.h:

(CodeBlock):

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::dumpCallFrame):

  • jit/JIT.cpp:

(JSC::JIT::privateCompileMainPass):
(JSC::JIT::privateCompileSlowCases):
(JSC::JIT::privateCompile):

  • jit/JIT.h:

(JIT):

  • jit/JITDisassembler.cpp: Added.

(JSC):
(JSC::JITDisassembler::JITDisassembler):
(JSC::JITDisassembler::~JITDisassembler):
(JSC::JITDisassembler::dump):
(JSC::JITDisassembler::dumpForInstructions):
(JSC::JITDisassembler::dumpDisassembly):

  • jit/JITDisassembler.h: Added.

(JSC):
(JITDisassembler):
(JSC::JITDisassembler::setStartOfCode):
(JSC::JITDisassembler::setForBytecodeMainPath):
(JSC::JITDisassembler::setForBytecodeSlowPath):
(JSC::JITDisassembler::setEndOfSlowPath):
(JSC::JITDisassembler::setEndOfCode):

4:44 PM Changeset in webkit [135456] by morrita@google.com
  • 3 edits
    2 adds in trunk

[Shadow DOM][V8] Assertion failure when shadow host is reclaimed before ShadowRoot
https://bugs.webkit.org/show_bug.cgi?id=102893

Reviewed by Kentaro Hara.

Source/WebCore:

Due to bug 88834, shadow hosts can be reclaimed before
corresponding ShadowRoots are. This breaks an invariant, that is,
the host is always available for any ShadowRoot. This change adds
guards for the possibly broken invariant.

Since bug 88834 is planned to be fixed shortly, this change
doesn't aim to fix this problem by make it work correctly, but
just lays a safety net which is needed until the root cause is
gone.

Test: fast/dom/shadow/host-wrapper-reclaimed.html

  • dom/ShadowRoot.cpp:

(WebCore::ShadowRoot::setInnerHTML):
(WebCore::ShadowRoot::setApplyAuthorStyles):
(WebCore::ShadowRoot::setResetStyleInheritance):
(WebCore::ShadowRoot::childrenChanged):

LayoutTests:

  • fast/dom/shadow/host-wrapper-reclaimed-expected.txt: Added.
  • fast/dom/shadow/host-wrapper-reclaimed.html: Added.
4:28 PM Changeset in webkit [135455] by krit@webkit.org
  • 9 edits
    1 move in trunk/Source/WebCore

Make CachedSVGDocumentReference independent of FilterOperation
https://bugs.webkit.org/show_bug.cgi?id=102967

Reviewed by Antti Koivisto.

Make CachedSVGDocumentReference independent of FilterOperation to reuse the code for clip-path and masking.

No new tests, refactoring.

  • GNUmakefile.list.am: Move CachedSVGDocumentReference to it's proper location and it to the projects.
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • css/StyleResolver.cpp:

(WebCore::StyleResolver::loadPendingSVGDocuments):
(WebCore::StyleResolver::createFilterOperations):

  • loader/cache/CachedSVGDocumentReference.h: Renamed from Source/WebCore/css/CachedSVGDocumentReference.h.

(WebCore):
(CachedSVGDocumentReference):
(WebCore::CachedSVGDocumentReference::CachedSVGDocumentReference):
(WebCore::CachedSVGDocumentReference::~CachedSVGDocumentReference):
(WebCore::CachedSVGDocumentReference::document):

  • platform/graphics/filters/FilterOperation.h: Rename data() and setData() to

cachedSVGDocumentReference() and its setter. Adapt other classes.

(WebCore::FilterOperation::ReferenceFilterOperation::cachedSVGDocumentReference):
(WebCore::FilterOperation::ReferenceFilterOperation::setCachedSVGDocumentReference):
(ReferenceFilterOperation):

  • rendering/FilterEffectRenderer.cpp:

(WebCore::FilterEffectRenderer::buildReferenceFilter):

  • rendering/RenderLayerFilterInfo.cpp:

(WebCore::RenderLayerFilterInfo::updateReferenceFilterClients):

4:25 PM Changeset in webkit [135454] by dbates@webkit.org
  • 3 edits
    4 adds in trunk

JavaScript fails to concatenate large strings
<https://bugs.webkit.org/show_bug.cgi?id=102963>

Reviewed by Michael Saboff.

Source/JavaScriptCore:

Fixes an issue where we inadvertently didn't check the length of
a JavaScript string for overflow.

  • runtime/Operations.h:

(JSC::jsString):
(JSC::jsStringFromArguments):

LayoutTests:

Add tests to ensure that we handle concatenating large strings.

  • fast/js/concat-large-strings-crash-expected.txt: Added.
  • fast/js/concat-large-strings-crash.html: Added.
  • fast/js/concat-large-strings-crash2-expected.txt: Added.
  • fast/js/concat-large-strings-crash2.html: Added.
4:20 PM Changeset in webkit [135453] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[EFL][WK2] Remove #include "ewk_view_private.h" in PageViewportControllerClientEfl.cpp
https://bugs.webkit.org/show_bug.cgi?id=102773

Patch by Jaehun Lim <ljaehun.lim@samsung.com> on 2012-11-21
Reviewed by Gyuyoung Kim.

PageViewportControllerClientEfl.cpp doesn't need to include ewk_view_private.h.

  • UIProcess/efl/PageViewportControllerClientEfl.cpp:
4:18 PM Changeset in webkit [135452] by simonjam@chromium.org
  • 12 edits in trunk/Source/WebCore

Remove the concept of initiatorDocument from CachedResourceRequest
https://bugs.webkit.org/show_bug.cgi?id=102855

Reviewed by Sam Weinig.

It turns out this isn't necessary for the new implementation of Resource Timing. Instead,
we can get at it from the CachedResourceLoader. I don't think anyone else needed it either.

No new tests. This was never used.

  • css/CSSFontFaceSrcValue.cpp:

(WebCore::CSSFontFaceSrcValue::cachedFont):

  • css/CSSImageSetValue.cpp:

(WebCore::CSSImageSetValue::cachedImageSet):

  • css/CSSImageValue.cpp:

(WebCore::CSSImageValue::cachedImage):

  • css/StyleRuleImport.cpp:

(WebCore::StyleRuleImport::requestStyleSheet):

  • css/WebKitCSSSVGDocumentValue.cpp:

(WebCore::WebKitCSSSVGDocumentValue::load):

  • css/WebKitCSSShaderValue.cpp:

(WebCore::WebKitCSSShaderValue::cachedShader):

  • html/parser/CSSPreloadScanner.cpp:

(WebCore::CSSPreloadScanner::emitRule):

  • html/parser/HTMLPreloadScanner.cpp:

(WebCore::PreloadTask::preload):

  • loader/cache/CachedResourceRequest.cpp:

(WebCore::CachedResourceRequest::setInitiator):

  • loader/cache/CachedResourceRequest.h:

(CachedResourceRequest):

  • loader/icon/IconLoader.cpp:

(WebCore::IconLoader::startLoading):

4:16 PM Changeset in webkit [135451] by fsamuel@chromium.org
  • 2 edits in trunk/LayoutTests

Add fast/events/context-nodrag.html to Chromium Mac TestExpectations

No review.

  • platform/chromium/TestExpectations:
4:13 PM Changeset in webkit [135450] by simonjam@chromium.org
  • 6 edits
    26 adds in trunk/LayoutTests

[Resource Timing] Create W3C-style test suite
https://bugs.webkit.org/show_bug.cgi?id=84883

Reviewed by Tony Gentilcore.

The tests are designed to be upstreamed. Eventually, the local ones will be replaced by the official upstream versions.

  • http/tests/w3c/webperf/resources/Ahem.ttf: Added.
  • http/tests/w3c/webperf/resources/all_resource_types.htm: Added.
  • http/tests/w3c/webperf/resources/blank_image.png: Added.
  • http/tests/w3c/webperf/resources/empty_script.js: Added.
  • http/tests/w3c/webperf/resources/generate_resource.php: Added.
  • http/tests/w3c/webperf/resources/gray_bg.css: Added.

(body):

  • http/tests/w3c/webperf/resources/green_frame.htm: Added.
  • http/tests/w3c/webperf/resources/inject_resource_test.html: Added.
  • http/tests/w3c/webperf/resources/nested.css: Added.

(@font-face):
(ol):

  • http/tests/w3c/webperf/resources/webperftestharness.js:

(test_greater_or_equals):
(test_fail):
(test_resource_entries):

  • http/tests/w3c/webperf/submission/resource-timing/html/test_resource_attribute_order-expected.txt: Added.
  • http/tests/w3c/webperf/submission/resource-timing/html/test_resource_attribute_order.html: Added.
  • http/tests/w3c/webperf/submission/resource-timing/html/test_resource_dynamic_insertion-expected.txt: Added.
  • http/tests/w3c/webperf/submission/resource-timing/html/test_resource_dynamic_insertion.html: Added.
  • http/tests/w3c/webperf/submission/resource-timing/html/test_resource_frame_initiator_type-expected.txt: Added.
  • http/tests/w3c/webperf/submission/resource-timing/html/test_resource_frame_initiator_type.html: Added.
  • http/tests/w3c/webperf/submission/resource-timing/html/test_resource_initiator_types-expected.txt: Added.
  • http/tests/w3c/webperf/submission/resource-timing/html/test_resource_initiator_types.html: Added.
  • http/tests/w3c/webperf/submission/resource-timing/html/test_resource_redirects-expected.txt: Added.
  • http/tests/w3c/webperf/submission/resource-timing/html/test_resource_redirects.html: Added.
  • http/tests/w3c/webperf/submission/resource-timing/html/test_resource_reparenting-expected.txt: Added.
  • http/tests/w3c/webperf/submission/resource-timing/html/test_resource_reparenting.html: Added.
  • http/tests/w3c/webperf/submission/resource-timing/html/test_resource_script_types-expected.txt: Added.
  • http/tests/w3c/webperf/submission/resource-timing/html/test_resource_script_types.html: Added.
  • platform/chromium/TestExpectations: Skip these new tests until the flag is flipped.
4:03 PM Changeset in webkit [135449] by allan.jensen@digia.com
  • 2 edits in trunk/Source/WebKit/qt

Position in QWebHitTestResult does not match documentation
https://bugs.webkit.org/show_bug.cgi?id=102909

Reviewed by Simon Hausmann.

Correct documentation and simplify using the new innerNodeFrame method.

  • Api/qwebframe.cpp:

(QWebHitTestResultPrivate::QWebHitTestResultPrivate):

4:02 PM Changeset in webkit [135448] by fsamuel@chromium.org
  • 2 edits in trunk/LayoutTests

Add fast/events/context-nodrag.html to Mac TestExpectations

No review.

  • platform/mac/TestExpectations:
4:02 PM Changeset in webkit [135447] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Unreviewed, rolling out r135437.
http://trac.webkit.org/changeset/135437
https://bugs.webkit.org/show_bug.cgi?id=102986

This patch causes crash to some layout tests (Requested by
jianli on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-11-21

  • dom/NodeRenderingContext.cpp:

(WebCore::NodeRenderingContext::createRendererIfNeeded):

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::createObject):

4:00 PM Changeset in webkit [135446] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Drop Synchronous Mouse Events
https://bugs.webkit.org/show_bug.cgi?id=102980

Patch by Genevieve Mak <gmak@rim.com> on 2012-11-21
Reviewed by Rob Buis.

Reviewed Internally by George Staikos, Mike Lattanzio and Mike Fenton.
Get rid of unneeded methods and simplify code.
Send click if getting context over an empty text field
so that it will be focused and have a caret.
PR #242781

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::webContext):
(BlackBerry::WebKit::WebPage::touchEvent):
(BlackBerry::WebKit::WebPage::touchPointAsMouseEvent):
(BlackBerry::WebKit::WebPage::touchEventCancel):

  • Api/WebPage.h:
  • WebKitSupport/TouchEventHandler.cpp:

(BlackBerry::WebKit::TouchEventHandler::TouchEventHandler):
(BlackBerry::WebKit::TouchEventHandler::doFatFingers):
(BlackBerry::WebKit::TouchEventHandler::sendClickAtFatFingersPoint):
(BlackBerry::WebKit::TouchEventHandler::handleTouchPoint):
(BlackBerry::WebKit::TouchEventHandler::handleFatFingerPressed):

  • WebKitSupport/TouchEventHandler.h:

(TouchEventHandler):

3:32 PM Changeset in webkit [135445] by akling@apple.com
  • 3 edits in trunk/Source/WebCore

Style sharing: Compare class lists via SpaceSplitString instead of string comparison.
<http://webkit.org/b/102982>

Reviewed by Antti Koivisto.

Add an operator!= to SpaceSplitString and use that check if two elements are eligible
for style sharing instead of comparing the fastGetAttribute(classAttr) return values.
This works because SpaceSplitString maps equal strings to the same data internally.

  • css/StyleResolver.cpp:

(WebCore::haveIdenticalStyleAffectingAttributes):

  • dom/SpaceSplitString.h:

(WebCore::SpaceSplitString::operator!=):
(SpaceSplitString):

3:30 PM Changeset in webkit [135444] by commit-queue@webkit.org
  • 4 edits
    1 add in trunk/LayoutTests

Multi-frame CUR file test hangs on mac port
https://bugs.webkit.org/show_bug.cgi?id=101811

Patch by Rick Byers <rbyers@chromium.org> on 2012-11-21
Reviewed by Alexey Proskuryakov.

Fix tests to not hang on unexpected image load failure.
Expect multi-frame CUR files to fail to load on Mac.

  • fast/events/mouse-cursor.html:
  • fast/events/mouse-cursor-multiframecur.html:
  • platform/mac/TestExpectations:
  • platform/mac/fast/events/mouse-cursor-multiframecur-expected.txt: Added.
3:21 PM Changeset in webkit [135443] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

Coordinated Graphics: refactor changing children code in CoordinatedGraphicsLayer.
https://bugs.webkit.org/show_bug.cgi?id=102896

Patch by Huang Dongsung <luxtella@company100.net> on 2012-11-21
Reviewed by Noam Rosenthal.

When changing children, we don't need to sync a layer state because
there is no more need to send the parent ID every time the layer tree
hierarchy changes. So this patch removes didChangeLayerState() in
methods which change children.

In addition, purgeBackingStores() does not need to call didChangeChildren()
because purgeBackingStores() does not change children.

  • WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.cpp:

(WebCore::CoordinatedGraphicsLayer::setChildren):
(WebCore::CoordinatedGraphicsLayer::addChild):
(WebCore::CoordinatedGraphicsLayer::addChildAtIndex):
(WebCore::CoordinatedGraphicsLayer::addChildAbove):
(WebCore::CoordinatedGraphicsLayer::addChildBelow):
(WebCore::CoordinatedGraphicsLayer::replaceChild):
(WebCore::CoordinatedGraphicsLayer::removeFromParent):
(WebCore::CoordinatedGraphicsLayer::purgeBackingStores):

3:09 PM Changeset in webkit [135442] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/chromium

Use m_webView->size() for viewport update
https://bugs.webkit.org/show_bug.cgi?id=102764

Patch by Tien-Ren Chen <trchen@chromium.org> on 2012-11-21
Reviewed by Adam Barth.

m_webView->client()->windowRect() returns the outer rect of the browser
window, which includes the decorations such as the title bar.
We should use the size of the WebView for layout and rendering purpose.

Existing tests are updated to work without windowRect().

  • src/ChromeClientImpl.cpp:

(WebKit::ChromeClientImpl::dispatchViewportPropertiesDidChange):

  • tests/WebFrameTest.cpp:
3:01 PM Changeset in webkit [135441] by kpiascik@rim.com
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Prevent screen from dimming on device when inspector front-end is connected
https://bugs.webkit.org/show_bug.cgi?id=102978

Reviewed by Rob Buis.

Internal PR 200848
We prevent screen from going dim when the front-end is connected and return to normal when
the front-end disconnects.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPage::enableWebInspector):
(BlackBerry::WebKit::WebPage::disableWebInspector):

2:53 PM Changeset in webkit [135440] by commit-queue@webkit.org
  • 21 edits in trunk/Source/WebCore

Unreviewed, rolling out r135338, r135359, and r135378.
http://trac.webkit.org/changeset/135338
http://trac.webkit.org/changeset/135359
http://trac.webkit.org/changeset/135378
https://bugs.webkit.org/show_bug.cgi?id=102981

Likely caused a 10% regression in
dromaeo_domcoreattr/dom_attr_getAttribute (Requested by abarth
on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-11-21

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateEventConstructorCallback):
(ConvertToV8Parameter):

  • bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:

(WebCore::TestActiveDOMObjectV8Internal::postMessageCallback):

  • bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:

(WebCore::TestCustomNamedGetterV8Internal::anotherFunctionCallback):

  • bindings/scripts/test/V8/V8TestEventConstructor.cpp:

(WebCore::V8TestEventConstructor::constructorCallback):

  • bindings/scripts/test/V8/V8TestInterface.cpp:

(WebCore::TestInterfaceV8Internal::supplementalStaticAttrAttrSetter):
(WebCore::TestInterfaceV8Internal::supplementalStr2AttrSetter):
(WebCore::TestInterfaceV8Internal::supplementalMethod2Callback):
(WebCore::V8TestInterface::constructorCallback):

  • bindings/scripts/test/V8/V8TestNamedConstructor.cpp:

(WebCore::V8TestNamedConstructorConstructorCallback):

  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::TestObjV8Internal::staticStringAttrAttrSetter):
(WebCore::TestObjV8Internal::stringAttrAttrSetter):
(WebCore::TestObjV8Internal::reflectedStringAttrAttrSetter):
(WebCore::TestObjV8Internal::reflectedURLAttrAttrSetter):
(WebCore::TestObjV8Internal::reflectedCustomURLAttrAttrSetter):
(WebCore::TestObjV8Internal::stringAttrWithGetterExceptionAttrSetter):
(WebCore::TestObjV8Internal::stringAttrWithSetterExceptionAttrSetter):
(WebCore::TestObjV8Internal::voidMethodWithArgsCallback):
(WebCore::TestObjV8Internal::longMethodWithArgsCallback):
(WebCore::TestObjV8Internal::objMethodWithArgsCallback):
(WebCore::TestObjV8Internal::methodThatRequiresAllArgsAndThrowsCallback):
(WebCore::TestObjV8Internal::methodWithOptionalStringCallback):
(WebCore::TestObjV8Internal::methodWithOptionalStringIsUndefinedCallback):
(WebCore::TestObjV8Internal::methodWithOptionalStringIsNullStringCallback):
(WebCore::TestObjV8Internal::overloadedMethod1Callback):
(WebCore::TestObjV8Internal::overloadedMethod3Callback):
(WebCore::TestObjV8Internal::overloadedMethod11Callback):
(WebCore::TestObjV8Internal::overloadedMethod12Callback):
(WebCore::TestObjV8Internal::strictFunctionCallback):
(WebCore::TestObjV8Internal::variadicStringMethodCallback):

  • bindings/scripts/test/V8/V8TestOverloadedConstructors.cpp:

(WebCore::V8TestOverloadedConstructors::constructor4Callback):

  • bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:

(WebCore::V8TestSerializedScriptValueInterface::constructorCallback):

  • bindings/v8/V8BindingMacros.h:
  • bindings/v8/V8StringResource.h:

(WebCore::V8Parameter::V8Parameter):
(V8Parameter):
(WebCore::V8Parameter::prepareBase):
(WebCore::V8Parameter::object):
(WebCore::::prepare):

  • bindings/v8/custom/V8ConsoleCustom.cpp:

(WebCore::V8Console::profileCallback):
(WebCore::V8Console::profileEndCallback):

  • bindings/v8/custom/V8DOMWindowCustom.cpp:

(WebCore::handlePostMessageCallback):

  • bindings/v8/custom/V8DeviceMotionEventCustom.cpp:

(WebCore::V8DeviceMotionEvent::initDeviceMotionEventCallback):

  • bindings/v8/custom/V8DeviceOrientationEventCustom.cpp:

(WebCore::V8DeviceOrientationEvent::initDeviceOrientationEventCallback):

  • bindings/v8/custom/V8HistoryCustom.cpp:

(WebCore::V8History::pushStateCallback):
(WebCore::V8History::replaceStateCallback):

  • bindings/v8/custom/V8IntentCustom.cpp:

(WebCore::V8Intent::constructorCallbackCustom):

  • bindings/v8/custom/V8SQLTransactionCustom.cpp:

(WebCore::V8SQLTransaction::executeSqlCallback):

  • bindings/v8/custom/V8SQLTransactionSyncCustom.cpp:

(WebCore::V8SQLTransactionSync::executeSqlCallback):

  • bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:

(WebCore::V8WebGLRenderingContext::getExtensionCallback):

2:42 PM Changeset in webkit [135439] by commit-queue@webkit.org
  • 3 edits
    5 adds in trunk

Invalidate non-composited content host when page scale factor changes
https://bugs.webkit.org/show_bug.cgi?id=100718

Patch by Tien-Ren Chen <trchen@chromium.org> on 2012-11-21
Reviewed by Adam Barth.

During a scale change, non-composited content layer doesn't get invalidated
automatically by the transformation change on RenderView. Need to force
update non-composited contents ourself.

Source/WebCore:

Test: compositing/repaint/page-scale-repaint.html

  • page/Page.cpp:

(WebCore::Page::setPageScaleFactor):

LayoutTests:

  • compositing/repaint/page-scale-repaint-expected.png: Added.
  • compositing/repaint/page-scale-repaint-expected.txt: Added.
  • compositing/repaint/page-scale-repaint.html: Added.
  • compositing/repaint/resources/grid.png: Added.
2:40 PM Changeset in webkit [135438] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

Yet another EFL & GTK+ build fix after r135429.

  • html/HTMLPropertiesCollection.cpp:

(WebCore::HTMLPropertiesCollection::create):

2:36 PM Changeset in webkit [135437] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Node::createRenderer should never return null
https://bugs.webkit.org/show_bug.cgi?id=102975

Patch by Elliott Sprehn <esprehn@chromium.org> on 2012-11-21
Reviewed by Ojan Vafai.

Node::createRenderer should never return null, instead Node::rendererIsNeeded
should return false if a node doesn't wish to have a renderer. This method
never actually returns null right now, but the code makes it look like it
could.

No new tests, just refactoring.

  • dom/NodeRenderingContext.cpp:

(WebCore::NodeRenderingContext::createRendererIfNeeded):

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::createObject):

2:34 PM Changeset in webkit [135436] by fsamuel@chromium.org
  • 6 edits
    2 adds in trunk

Clear MousePressed state on context menu to avoid initiating a drag
https://bugs.webkit.org/show_bug.cgi?id=101786

Reviewed by Ojan Vafai.

Source/WebCore:

If a user initiates a drag via left mouse down, brings up the context menu,
and then cancels the context menu while keeping the left mouse button down,
then the drag operation will continue. This does not match the platform
conventions on Windows, Linux or Mac .

This change cancels the drag if the context menu is about to be displayed.

Test: fast/events/context-nodrag.html

  • page/EventHandler.cpp:

(WebCore::EventHandler::sendContextMenuEvent):

Tools:

  • DumpRenderTree/chromium/TestRunner/src/EventSender.cpp:

(WebTestRunner):
(WebTestRunner::EventSender::EventSender):
(WebTestRunner::EventSender::contextClick):
Only send a MouseUp on Windows. Keep the current mouse pressed state when
calling up a context menu.

LayoutTests:

If a user initiates a drag via left mouse down, brings up the context menu,
and then cancels the context menu while keeping the left mouse button down,
then the drag operation will continue. This does not match the platform
conventions on Windows, Linux or Mac .

This change cancels the drag if the context menu is about to be displayed.

  • fast/events/context-nodrag.html: Added.
  • fast/events/context-nodrag-expected.txt: Added.
2:31 PM Changeset in webkit [135435] by Patrick Gansterer
  • 3 edits
    1 delete in trunk/Source/WebCore

Use MIMETypeRegistryWin for WinCE port too
https://bugs.webkit.org/show_bug.cgi?id=102977

Reviewed by Laszlo Gombos.

r135217 made MIMETypeRegistryWin compile on WinCE too,
which allows us to get rid of MIMETypeRegistryWinCE.

  • PlatformWinCE.cmake:
  • WebCore.gypi:
  • platform/wince/MIMETypeRegistryWinCE.cpp: Removed.
2:24 PM Changeset in webkit [135434] by commit-queue@webkit.org
  • 4 edits in trunk

REGRESSION(r135212): Fix crash due to an infinite rect.
https://bugs.webkit.org/show_bug.cgi?id=102891

Patch by Huang Dongsung <luxtella@company100.net> on 2012-11-21
Reviewed by Noam Rosenthal.

Source/WebKit2:

When CoordinatedGraphicsLayer has a 3D transform, tiledBackingStoreVisibleRect()
can calculate an infinite rect. However, TiledBackingStore cannot handle the
infinite rect. This patch clamps the infinite rect to avoid crash in
TiledBackingStore.

  • WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.cpp:

(WebCore::clampToContentsRectIfRectIsInfinite):
(WebCore):
(WebCore::CoordinatedGraphicsLayer::tiledBackingStoreVisibleRect):

LayoutTests:

fast/multicol/span/positioned-child-not-removed-crash.html now passes on
EFL.

  • platform/efl-wk2/TestExpectations:
2:24 PM Changeset in webkit [135433] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

[V8] Add context checks to WorldContextHandle and V8DOMWindowShell
https://bugs.webkit.org/show_bug.cgi?id=101573

Patch by Dan Carney <dcarney@google.com> on 2012-11-21
Reviewed by Adam Barth.

Added a bunch of assertions to ensure the problems with IndexedDB
contexts cannot reemerge.

No new tests. No change in functionality.

  • bindings/v8/V8DOMWindowShell.cpp:

(WebCore):
(WebCore::V8DOMWindowShell::assertContextHasCorrectPrototype):

  • bindings/v8/V8DOMWindowShell.h:

(V8DOMWindowShell):
(WebCore::V8DOMWindowShell::isolated):

  • bindings/v8/WorldContextHandle.cpp:

(WebCore::WorldContextHandle::WorldContextHandle):

2:21 PM Changeset in webkit [135432] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Remove unnecessary ternaries in createRendererIfNeeded
https://bugs.webkit.org/show_bug.cgi?id=102974

Patch by Elliott Sprehn <esprehn@chromium.org> on 2012-11-21
Reviewed by Ojan Vafai.

parentRenderer, nextRenderer and previousRenderer all handle flow
threads automatically so there's no reason to duplicate the check in
createRendererIfNeeded.

Note that while these methods first check the node for a renderer and
then delegate to the flow thread the node never has a renderer when
calling createRendererIfNeeded per the assertion at the top so this
change is equivalent.

No new tests, just refactoring.

  • dom/NodeRenderingContext.cpp:

(WebCore::NodeRenderingContext::createRendererIfNeeded):

2:02 PM Changeset in webkit [135431] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

EFL and GTK+ build fix after r135429.

  • dom/Element.cpp:

(WebCore::ElementRareData::ensureCachedHTMLCollection):

1:52 PM Changeset in webkit [135430] by jianli@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed. Updated chromium test expectations to resolve lint failures.

  • platform/chromium/TestExpectations:
1:38 PM Changeset in webkit [135429] by rniwa@webkit.org
  • 15 edits in trunk/Source/WebCore

HTMLCollection should use the same storage as DynamicNodeList
https://bugs.webkit.org/show_bug.cgi?id=102886

Reviewed by Antti Koivisto.

This patch removes ElementRareData::m_collection. HTMLCollections are now held by
NodeListNodeData in NodeRareData like DynamicNodeLists. This simplifies several
Element and Node functions where we used to call into both ElementRareData and
NodeRareData to invalidate caches.

This is a refactoring and there should be no behavioral change.

  • dom/DynamicNodeList.h:
  • dom/Element.cpp:

(WebCore::ElementRareData::ensureCachedHTMLCollection):

  • dom/ElementRareData.cpp:

(WebCore::ElementRareData::reportMemoryUsage):

  • dom/ElementRareData.h:

(ElementRareData):
(WebCore::ElementRareData::cachedHTMLCollection):
(WebCore::ElementRareData::removeCachedHTMLCollection):

  • dom/Node.cpp:

(WebCore::Node::invalidateNodeListCachesInAncestors):

  • dom/NodeRareData.h:

(NodeListsNodeData):
(WebCore::NodeListsNodeData::addCacheWithAtomicName):
(WebCore::NodeListsNodeData::cacheWithAtomicName):
(WebCore::NodeListsNodeData::removeCacheWithAtomicName):
(WebCore::NodeListsNodeData::adoptTreeScope):
(WebCore::NodeListsNodeData::namedNodeListKey):

  • dom/TreeScopeAdopter.cpp:

(WebCore::TreeScopeAdopter::moveTreeToNewScope):

  • html/HTMLFormControlsCollection.cpp:

(WebCore::HTMLFormControlsCollection::create):

  • html/HTMLFormControlsCollection.h:

(HTMLFormControlsCollection):

  • html/HTMLOptionsCollection.cpp:

(WebCore::HTMLOptionsCollection::create):

  • html/HTMLOptionsCollection.h:

(HTMLOptionsCollection::create):

  • html/HTMLPropertiesCollection.h:

(HTMLPropertiesCollection::create):

  • html/HTMLTableRowsCollection.cpp:

(WebCore::HTMLTableRowsCollection::create):

  • html/HTMLTableRowsCollection.h:

(HTMLTableRowsCollection):

1:29 PM Changeset in webkit [135428] by akling@apple.com
  • 2 edits in trunk/Source/WebCore

Update incorrect assertion in ImmutableElementAttributeData(MutableElementAttributeData).
<http://webkit.org/b/102972>

Reviewed by Antti Koivisto.

Manipulation by editing code may cause an element to have mutable inline style, and this is fine.

Change the assertion to confirm that the inline style doesn't have a CSSOM wrapper attached,
which is where real problems would happen.

Fixes an assertion on editing/undo/replace-by-span-then-remove.html

  • dom/ElementAttributeData.cpp:

(WebCore::ImmutableElementAttributeData::ImmutableElementAttributeData):

12:37 PM Changeset in webkit [135427] by kpiascik@rim.com
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Don't add empty rects to the tap highlight region.
https://bugs.webkit.org/show_bug.cgi?id=102966

Reviewed by George Staikos.

Internal PR 246960
Tap highlight is way too large sometimes.
When we add an empty rect it inflates by 2 and causes the tap region to extend to the origin.

  • WebKitSupport/TouchEventHandler.cpp:

(BlackBerry::WebKit::TouchEventHandler::drawTapHighlight):

12:32 PM ViewportInteractionTopics edited by tmpsantos@gmail.com
(diff)
12:29 PM Changeset in webkit [135426] by haraken@chromium.org
  • 8 edits in trunk

Remove $outputDir and $outputHeadersDir from global variables of code generators
https://bugs.webkit.org/show_bug.cgi?id=102492

Reviewed by Adam Barth.

$outputDir and $outputHeadersDir are used in WriteData() only.
We don't need to use global variables for them.

No tests. No change in behavior.

  • bindings/scripts/CodeGenerator.pm:

(ProcessDocument):
(FileNamePrefix):

  • bindings/scripts/CodeGeneratorCPP.pm:

(new):
(GenerateInterface):
(WriteData):

  • bindings/scripts/CodeGeneratorGObject.pm:

(new):
(WriteData):
(GenerateInterface):

  • bindings/scripts/CodeGeneratorJS.pm:

(new):
(GenerateInterface):
(WriteData):

  • bindings/scripts/CodeGeneratorObjC.pm:

(new):
(GenerateInterface):
(WriteData):

  • bindings/scripts/CodeGeneratorV8.pm:

(new):
(GenerateInterface):
(WriteData):

12:24 PM Changeset in webkit [135425] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WTF

Source/WTF/wtf/Assertions.cpp: fix build on a uClibc system
https://bugs.webkit.org/show_bug.cgi?id=102946

Patch by Anthony G. Basile <blueness@gentoo.org> on 2012-11-21
Reviewed by Tony Chang.

Webkit-Gtk fails to build on a uClibc system because
Assertions.cpp assumes that all Linux systems have execinfo.h
and provide backtrace(). This is not necessarily the case for
uClibc which can be configured without these. This patch
refines the check for OS(LINUX) to prevent this breakage.
Originally reported at https://bugs.gentoo.org/441674

  • wtf/Assertions.cpp:
12:13 PM Changeset in webkit [135424] by jsbell@chromium.org
  • 96 edits
    3 deletes in trunk

Remove IDBDatabaseException
https://bugs.webkit.org/show_bug.cgi?id=102514

Reviewed by Adam Barth.

Source/WebCore:

After the WebKit implementation landed, the IndexedDB spec changed from defining new
exception codes with constants hanging off an interface to using DOM4-styled named
DOMExceptions. Remove the IDBDatabaseException interface and set codes for IDB-specific
exceptions to 0. (The .idl file is retained pending general ExceptionCode cleanup.)

Also remove IDBRequest.errorCode which was used for reporting asynchronous errors;
IDBRequest.error - a DOMError - should be used instead.

No new tests - covered by plenty of existing tests which have been updated.

  • Modules/indexeddb/DOMWindowIndexedDatabase.idl: Don't expose the interface.
  • Modules/indexeddb/IDBCursor.idl: Remove reference to IDBDatabaseException.
  • Modules/indexeddb/IDBDatabase.idl: Ditto.
  • Modules/indexeddb/IDBDatabaseException.cpp:

(IDBDatabaseExceptionNameDescription): Use either a DOMException code or 0.
(WebCore::IDBDatabaseException::initializeDescription):
(WebCore::IDBDatabaseException::getLegacyErrorCode):

  • Modules/indexeddb/IDBFactory.idl: Remove reference to IDBDatabaseException.
  • Modules/indexeddb/IDBIndex.idl: Ditto.
  • Modules/indexeddb/IDBKeyRange.idl: Ditto.
  • Modules/indexeddb/IDBObjectStore.idl: Ditto.
  • Modules/indexeddb/IDBRequest.idl: Ditto.
  • Modules/indexeddb/IDBTransaction.idl: Ditto.
  • Modules/indexeddb/WorkerContextIndexedDatabase.idl: Don't expose the interface.
  • bindings/v8/IDBBindingUtilities.cpp: Remove unneeded #include.

LayoutTests:

Remove references to IDBDatabaseException - DOMExceptions should be thrown with code 0 and
a name. Remove references to IDBRequest.errorCode - IDBRequest.error is the new hawtness,
and already tested for. Ensure those objects/properties are gone in removed.html

  • storage/indexeddb/basics-expected.txt:
  • storage/indexeddb/basics-workers-expected.txt:
  • storage/indexeddb/constants.html: Removed.
  • storage/indexeddb/constants-expected.txt: Removed.
  • storage/indexeddb/create-and-remove-object-store-expected.txt:
  • storage/indexeddb/cursor-continue-dir-expected.txt:
  • storage/indexeddb/cursor-continue-expected.txt:
  • storage/indexeddb/cursor-update-expected.txt:
  • storage/indexeddb/deleteIndex-expected.txt:
  • storage/indexeddb/exceptions-expected.txt:
  • storage/indexeddb/factory-cmp-expected.txt:
  • storage/indexeddb/get-keyrange-expected.txt:
  • storage/indexeddb/index-basics-expected.txt:
  • storage/indexeddb/index-basics-workers-expected.txt:
  • storage/indexeddb/index-count-expected.txt:
  • storage/indexeddb/index-unique-expected.txt:
  • storage/indexeddb/intversion-close-in-upgradeneeded-expected.txt:
  • storage/indexeddb/invalid-keys-expected.txt:
  • storage/indexeddb/key-generator-expected.txt:
  • storage/indexeddb/key-type-array-expected.txt:
  • storage/indexeddb/keypath-edges-expected.txt:
  • storage/indexeddb/keyrange-expected.txt:
  • storage/indexeddb/mozilla/add-twice-failure-expected.txt:
  • storage/indexeddb/mozilla/bad-keypath-expected.txt:
  • storage/indexeddb/mozilla/clear-expected.txt:
  • storage/indexeddb/mozilla/key-requirements-delete-null-key-expected.txt:
  • storage/indexeddb/mozilla/key-requirements-inline-and-passed-expected.txt:
  • storage/indexeddb/mozilla/key-requirements-put-no-key-expected.txt:
  • storage/indexeddb/mozilla/key-requirements-put-null-key-expected.txt:
  • storage/indexeddb/mozilla/readonly-transactions-expected.txt:
  • storage/indexeddb/mozilla/resources/add-twice-failure.js:
  • storage/indexeddb/mozilla/resources/bad-keypath.js:
  • storage/indexeddb/mozilla/resources/clear.js:
  • storage/indexeddb/mozilla/resources/indexes.js: Elide obsolete comment.
  • storage/indexeddb/mozilla/resources/key-requirements-delete-null-key.js:
  • storage/indexeddb/mozilla/resources/key-requirements-inline-and-passed.js:
  • storage/indexeddb/mozilla/resources/key-requirements-put-no-key.js:
  • storage/indexeddb/mozilla/resources/key-requirements-put-null-key.js:
  • storage/indexeddb/mozilla/resources/readonly-transactions.js:
  • storage/indexeddb/objectstore-autoincrement-expected.txt:
  • storage/indexeddb/objectstore-basics-expected.txt:
  • storage/indexeddb/objectstore-basics-workers-expected.txt:
  • storage/indexeddb/objectstore-count-expected.txt:
  • storage/indexeddb/open-cursor-expected.txt:
  • storage/indexeddb/readonly-expected.txt:
  • storage/indexeddb/removed-expected.txt:
  • storage/indexeddb/resources/basics.js:
  • storage/indexeddb/resources/constants.js: Removed.
  • storage/indexeddb/resources/create-and-remove-object-store.js:
  • storage/indexeddb/resources/cursor-continue-dir.js:
  • storage/indexeddb/resources/cursor-continue.js:
  • storage/indexeddb/resources/cursor-update.js:
  • storage/indexeddb/resources/deleteIndex.js:
  • storage/indexeddb/resources/exceptions.js:
  • storage/indexeddb/resources/factory-cmp.js:
  • storage/indexeddb/resources/get-keyrange.js:
  • storage/indexeddb/resources/index-basics.js:
  • storage/indexeddb/resources/index-count.js:
  • storage/indexeddb/resources/index-unique.js:
  • storage/indexeddb/resources/intversion-close-in-upgradeneeded.js:
  • storage/indexeddb/resources/invalid-keys.js:
  • storage/indexeddb/resources/key-generator.js:
  • storage/indexeddb/resources/key-type-array.js:
  • storage/indexeddb/resources/keypath-edges.js:
  • storage/indexeddb/resources/keyrange.js:
  • storage/indexeddb/resources/objectstore-autoincrement.js:
  • storage/indexeddb/resources/objectstore-basics.js:
  • storage/indexeddb/resources/objectstore-count.js:
  • storage/indexeddb/resources/open-cursor.js:
  • storage/indexeddb/resources/readonly.js:
  • storage/indexeddb/resources/removed.js:
  • storage/indexeddb/resources/shared.js:
  • storage/indexeddb/resources/transaction-abort.js:
  • storage/indexeddb/resources/transaction-active-flag.js:
  • storage/indexeddb/resources/transaction-basics.js:
  • storage/indexeddb/resources/transaction-complete-workers.js:
  • storage/indexeddb/resources/transaction-error.js:
  • storage/indexeddb/resources/transaction-read-only.js:
  • storage/indexeddb/transaction-abort-expected.txt:
  • storage/indexeddb/transaction-active-flag-expected.txt:
  • storage/indexeddb/transaction-basics-expected.txt:
  • storage/indexeddb/transaction-complete-workers-expected.txt:
  • storage/indexeddb/transaction-error-expected.txt:
  • storage/indexeddb/transaction-read-only-expected.txt:
12:10 PM Changeset in webkit [135423] by wjmaclean@chromium.org
  • 2 edits in trunk/Source/WebCore

[chromium] Fix indenting in RenderThemeChromiumSkia.h.
https://bugs.webkit.org/show_bug.cgi?id=102965

Reviewed by Adam Barth.

Much of RenderThemeChromiumSkia.h was indented too far, making the
file confusing to read. This CL removes the extra indents.

  • rendering/RenderThemeChromiumSkia.h:

(RenderThemeChromiumSkia):

11:52 AM Changeset in webkit [135422] by mifenton@rim.com
  • 4 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Switch to point instead of VisiblePosition comparison for input bounds check
https://bugs.webkit.org/show_bug.cgi?id=102962

Reviewed by Rob Buis.

PR 247270.

Switch from using VisiblePosition to determine if we are in a node
to a comparison of the field bounds. This fixes the case where
there is no node before the target node to match.

Reviewed Internally by Gen Mak.

  • WebKitSupport/DOMSupport.cpp:
  • WebKitSupport/DOMSupport.h:
  • WebKitSupport/SelectionHandler.cpp:

(BlackBerry::WebKit::SelectionHandler::setCaretPosition):

11:05 AM Changeset in webkit [135421] by akling@apple.com
  • 7 edits in trunk/Source/WebCore

Make it possible for elements with different tag names to share attribute data.
<http://webkit.org/b/102845>

Reviewed by Antti Koivisto.

Allow all elements to share ElementAttributeData with one another. This means that the elements
in this hypothetical markup will all point to the same attribute data:

<div class="foo">

<span class="foo">

<hr class="foo"/>

</span>

</div>

This optimization happens at the expense of an old one. We no longer share attribute data
between elements that have presentation attributes, since they map to different CSS properties
depending on what tag they're attached to. These are mostly used in ye olde web 1.0 content
though, and we should prefer optimizing in favor of modern markup. The global cache for
presentation attribute style in StyledElement.cpp still prevents redundant parsing.

On the upside, excluding elements with presentation attributes from the data cache means that
we can move one pointer (m_presentationAttributeStyle) from ImmutableElementAttributeData
to MutableElementAttributeData.

800kB progression on Membuster3.

  • dom/Document.h:
  • dom/Document.cpp:

(WebCore::ImmutableAttributeDataCacheKey::ImmutableAttributeDataCacheKey):
(WebCore::ImmutableAttributeDataCacheKey::operator!=):
(WebCore::ImmutableAttributeDataCacheKey::hash):
(ImmutableAttributeDataCacheKey):
(WebCore::Document::cachedImmutableAttributeData):

  • dom/Element.cpp:

(WebCore::Element::parserSetAttributes):

Don't use the element's tag name in the key for the immutable attribute data cache.

(WebCore::Element::cloneAttributesFromElement):

Prevent cloneNode() from converting mutable attribute data to immutable if it has
presentation attributes.

  • dom/ElementAttributeData.cpp:

(WebCore::ImmutableElementAttributeData::ImmutableElementAttributeData):

Add an assertion that mutable-to-immutable conversion never happens with presentation
attribute style present.

(WebCore::ElementAttributeData::ElementAttributeData):
(WebCore::MutableElementAttributeData::MutableElementAttributeData):
(WebCore::ElementAttributeData::reportMemoryUsage):

  • dom/ElementAttributeData.h:

(ElementAttributeData):
(MutableElementAttributeData):
(WebCore::ElementAttributeData::presentationAttributeStyle):
(WebCore):
(WebCore::ElementAttributeData::setPresentationAttributeStyle):

Move the RefPtr<StylePropertySet> that holds presentation attribute-derived style
from the common ElementAttributeData base class to MutableElementAttributeData.

  • dom/StyledElement.cpp:

(WebCore::StyledElement::attributeChanged):

Always dirty the presentation attribute style when a presentation attribute changes.

(WebCore::StyledElement::rebuildPresentationAttributeStyle):

Force promotion to mutable attribute data when it turns out that we need to hang a
StylePropertySet with the presentation attribute style off of it.

10:54 AM Changeset in webkit [135420] by reed@google.com
  • 2 edits in trunk/LayoutTests

update expectations in advance of skia deps roll
https://bugs.webkit.org/show_bug.cgi?id=102964

Reviewed by NOBODY. expectations change only.

  • platform/chromium/TestExpectations:
10:53 AM Changeset in webkit [135419] by Antti Koivisto
  • 4 edits in trunk/Source/WebCore

Replace NodeRendererFactory class with a function
https://bugs.webkit.org/show_bug.cgi?id=102950

Reviewed by Andreas Kling.

Simplify the code by turning NodeRendererFactory single-use class into function of NodeRenderingContext.

  • dom/Node.cpp:

(WebCore::Node::createRendererIfNeeded):

  • dom/NodeRenderingContext.cpp:

(WebCore::NodeRenderingContext::NodeRenderingContext):
(WebCore):
(WebCore::NodeRenderingContext::moveToFlowThreadIfNeeded):
(WebCore::NodeRenderingContext::createRendererIfNeeded):

  • dom/NodeRenderingContext.h:

(NodeRenderingContext):
(WebCore::NodeRenderingContext::style):
(WebCore):

10:52 AM Changeset in webkit [135418] by wjmaclean@chromium.org
  • 2 edits in trunk/Source/WebCore

[chromium] Change default tap highlight color for Chromium Windows & Linux.
https://bugs.webkit.org/show_bug.cgi?id=102939

Reviewed by Adam Barth.

Change default tap highlight colour on Chromium Win/Linux to be 18% black.

  • rendering/RenderThemeChromiumSkia.h:

(RenderThemeChromiumSkia): Override platformTapHighlightColor() to change default highlight colour.

10:43 AM Changeset in webkit [135417] by peter@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[Chromium] webkit_unit_tests should depend on forwarder2 for Android
https://bugs.webkit.org/show_bug.cgi?id=102934

Reviewed by Tony Chang.

Running webkit_unit_tests and TestWebKitAPI in the WebKit tree will defer
to the test runner used by Chromium, which in turn relies on forwarder2.
forwarder2 will eventually be required by layout tests as well.

  • WebKitUnitTests.gyp:
10:21 AM Changeset in webkit [135416] by tony@chromium.org
  • 2 edits in trunk/Source/WebCore

Relayout the slider track when a data list is set
https://bugs.webkit.org/show_bug.cgi?id=102851

Reviewed by Ojan Vafai.

Previously, we would relayout the <input>. Once we fix bug 102352, this
causes the slider track to not relayout. It should relayout because it
draws the data list tick marks and needs to provide space for them.

No new tests, not testable until bug 102352 is fixed. Specifically,
fast/forms/datalist/update-range-with-datalist.html reveals the bug.

  • html/RangeInputType.cpp:

(WebCore::RangeInputType::listAttributeTargetChanged):

10:20 AM Changeset in webkit [135415] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed, rolling out r135409.
http://trac.webkit.org/changeset/135409
https://bugs.webkit.org/show_bug.cgi?id=102959

This patch causes compiling error to Chromium build (Requested
by jianli_ on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-11-21

  • tests/IDBRequestTest.cpp:

(WebCore::TEST):

10:09 AM Changeset in webkit [135414] by commit-queue@webkit.org
  • 8 edits in trunk/Source

[chromium] Add flag to enable/disable touch adjustment at runtime.
https://bugs.webkit.org/show_bug.cgi?id=102534

Patch by Kevin Ellis <kevers@chromium.org> on 2012-11-21
Reviewed by Antonio Gomes.

Source/WebCore:

Add setting for enabling or disabling touch adjustment. Note that for
touch adjustment to apply, the compile flag must also be enabled. A
compile only option is insufficient as it does not allow developers to
quickly test the impact of touch adjustemnt without recompiling. Nor
does it allow end users to disable touch adjustemnt if they find that
touch adjustment is not working well for a particular site.

No new tests required.

  • page/EventHandler.cpp:

(WebCore::EventHandler::handleGestureEvent): Move enable check to adjustGesturePosition.
(WebCore::EventHandler::handleGestureTap): Move enable check to adjustGesturePosition.
(WebCore::EventHandler::shouldApplyTouchAdjustment): Checks if touch adjustment is enabled.
(WebCore):
(WebCore::EventHandler::adjustGesturePosition): Add check for enabling of touch adjustment.
(WebCore::EventHandler::sendContextMenuEventForGesture): Move enable check to adjustGesturePosition.

  • page/EventHandler.h:

(EventHandler):

  • page/Settings.in:

Source/WebKit/chromium:

Add setting for enabling or disabling touch adjustment.
For touch adjustemnt to apply, the compile option must
also be enabled.

  • public/WebSettings.h:
  • src/WebSettingsImpl.cpp:

(WebKit::WebSettingsImpl::setEnableTouchAdjustment):
(WebKit):

  • src/WebSettingsImpl.h:

(WebSettingsImpl):

9:58 AM Changeset in webkit [135413] by Philippe Normand
  • 2 edits in trunk/Source/WebCore

Unreviewed, build fix after r135410.

  • html/track/InbandTextTrack.cpp:

(WebCore::InbandTextTrack::addCue): Prevent unused parameter error.

9:34 AM Changeset in webkit [135412] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: Ctrl+A closes breakpoint condition editor
https://bugs.webkit.org/show_bug.cgi?id=102906

Patch by Andrey Lushnikov <lushnikov@chromium.com> on 2012-11-21
Reviewed by Pavel Feldman.

Check if e.target has no ancestors with className
"webkit-line-decorations" in DefaultTextEditor._handleKeyDown

  • inspector/front-end/DefaultTextEditor.js:

(WebInspector.DefaultTextEditor.prototype._handleKeyDown): Add check

9:28 AM Changeset in webkit [135411] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Avoid creating degenerate cubics at corners of rounded rects.
https://bugs.webkit.org/show_bug.cgi?id=102945

Patch by Tom Hudson <tomhudson@chromium.org> on 2012-11-21
Reviewed by Stephen White.

Covered by existing layout tests.

  • platform/graphics/Path.cpp:

(Path::addBeziersForRoundedRect):

9:18 AM Changeset in webkit [135410] by eric.carlson@apple.com
  • 14 edits
    3 adds in trunk/Source/WebCore

In-band text tracks infrastructure
https://bugs.webkit.org/show_bug.cgi?id=102830

Reviewed by Philippe Normand.

Add the infrastructure necessary to allow a port-specific media engine to expose in-band text
tracks.

No new tests, this patch only adds plumbing. Existing tests verify that these changes don't
break existing functionality.

  • CMakeLists.txt: Add new project files.
  • GNUmakefile.list.am: Ditto.
  • Target.pri: Ditto.
  • WebCore.gypi: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::setReadyState): Call processInbandTextTracks when readyState reaches

HAVE_METADATA

(WebCore::HTMLMediaElement::processInbandTextTracks): Fetch the in-band text tracks from the

media player and processes them.

  • html/HTMLMediaElement.h:
  • html/track/InbandTextTrack.cpp: Added.
  • html/track/InbandTextTrack.h: Added.
  • html/track/InbandTextTrackPrivate.h: Added.
  • html/track/TextTrack.h:

(TextTrack):
(WebCore::TextTrack::clearClient): Remove virtual, it is unnecessary
(WebCore::TextTrack::mode): Make virtual so derived classes can override.
(WebCore::TextTrack::setMode): Ditto.

  • html/track/TextTrackList.cpp:

(TextTrackList::length): Update to deal with in-band tracks.
(TextTrackList::getTrackIndex): Ditto.
(TextTrackList::getTrackIndexRelativeToRenderedTracks): Ditto.
(TextTrackList::item): Ditto.
(TextTrackList::invalidateTrackIndexesAfterTrack): New, invalidate the cached track indexes of

all tracks after another.

(TextTrackList::append): Update to deal with in-band tracks.
(TextTrackList::remove): Update to deal with in-band tracks.
(TextTrackList::scheduleAddTrackEvent): Remove typo.

  • html/track/TextTrackList.h:
  • platform/graphics/MediaPlayer.cpp:

(WebCore::MediaPlayer::getTextTracks): New, pass through to the media engine.
(WebCore::MediaPlayer::setTextTrackClient):

  • platform/graphics/MediaPlayer.h:
  • platform/graphics/MediaPlayerPrivate.h:

(WebCore::MediaPlayerPrivateInterface::setPreload): Cleanup.
(WebCore::MediaPlayerPrivateInterface::sourceEndOfStream): Ditto.
(WebCore::MediaPlayerPrivateInterface::getTextTracks): New client method.
(WebCore::MediaPlayerPrivateInterface::setTextTrackClient): Ditto.

9:17 AM Changeset in webkit [135409] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

IDBRequestTest needs a v8 context
https://bugs.webkit.org/show_bug.cgi?id=102941

Patch by Dan Carney <dcarney@google.com> on 2012-11-21
Reviewed by Jochen Eisinger.

Added v8 context to IDBRequestTest tests.

  • tests/IDBRequestTest.cpp:

(IDBRequestTest):
(WebKit::IDBRequestTest::IDBRequestTest):
(WebKit::IDBRequestTest::context):
(WebKit::IDBRequestTest::scriptExecutionContext):
(WebKit):
(WebKit::TEST_F):

8:01 AM Changeset in webkit [135408] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL][WK2] gardening: fast/writing-mode/japanese-ruby-* are flaky
https://bugs.webkit.org/show_bug.cgi?id=102921

Unreviewed gardening: several tests fail if run after any test that
changes font family mappings. Mark them flaky.

Patch by Jussi Kukkonen <jussi.kukkonen@intel.com> on 2012-11-21

  • platform/efl-wk2/TestExpectations:
7:58 AM Changeset in webkit [135407] by commit-queue@webkit.org
  • 4 edits in trunk/Source

Source/WebCore: [Qt] MinGW: Explicitly add OpenGL library dependencies
https://bugs.webkit.org/show_bug.cgi?id=102924

Patch by Kai Koehne <kai.koehne@digia.com> on 2012-11-21
Reviewed by Simon Hausmann.

Adding the dependencies to WebKit1 is too late, because linking will have already failed. Also make sure that
the we link against OpenGLES1 e.g. for Angle.

  • WebCore.pri:

Source/WebKit: [Qt] MinGW: Don't add OpenGL library dependencies here
https://bugs.webkit.org/show_bug.cgi?id=102924

Patch by Kai Koehne <kai.koehne@digia.com> on 2012-11-21
Reviewed by Simon Hausmann.

As the comment suggests the dependency is already for WebCore, so add it there instead.

  • WebKit1.pri:
7:55 AM Changeset in webkit [135406] by peter@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled DEPS.

  • DEPS:
7:45 AM Changeset in webkit [135405] by allan.jensen@digia.com
  • 25 edits in trunk/Source

Source/WebCore: Disambiguate innerNodeFramePoint and mainFramePoint
https://bugs.webkit.org/show_bug.cgi?id=98139

Reviewed by Julien Chaffraix.

Splits the point() method in HitTestResult into two, innerNodeFramePoint and mainFramePoint().
To do this HitTestResult no longer inherits publically from HitTestLocation, which should also
help to later separate the two classes completely.

Many of the call-sites of hitTestResultAtPoint confuses which coordinates the point is in.
These have not have been fixed in this patch, and they should be audited by the individual ports.

  • WebCore.exp.in:
  • dom/Document.cpp:

(WebCore::Document::nodesFromRect):

  • page/EventHandler.cpp:

(WebCore::EventHandler::eventMayStartDrag):
(WebCore::EventHandler::hitTestResultAtPoint):

Set and maintain pointInMainFrame on the HitTestResult.

  • rendering/HitTestResult.cpp:

(WebCore::HitTestResult::HitTestResult):

Construct pointInMainFrame as a copy of pointInInnerNodeFrame. This is correct
for all hit-tests outside of the recursion in EventHandler::hitTestResultAtPoint.

(WebCore::HitTestResult::operator=):
(WebCore::HitTestResult::innerNodeFrame):
(WebCore::HitTestResult::append):

  • rendering/HitTestResult.h:

(WebCore::HitTestLocation::point):
(HitTestResult):

Inherits protected now from HitTestLocation to avoid exposing the ambiguous
point() and roundedPoint() methods.
HitTestResult will be split completely from HitTestLocation in a later patch.

(WebCore::HitTestResult::isRectBasedTest):
(WebCore::HitTestResult::pointInMainFrame):
(WebCore::HitTestResult::roundedPointInMainFrame):
(WebCore::HitTestResult::setPointInMainFrame):
(WebCore::HitTestResult::pointInInnerNodeFrame):
(WebCore::HitTestResult::roundedPointInInnerNodeFrame):
(WebCore::HitTestResult::localPoint):
(WebCore::HitTestResult::setLocalPoint):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::hitTest):

Source/WebKit/chromium: Disambiguate innerNodeFramePoint and mainFramePoint
https://bugs.webkit.org/show_bug.cgi?id=98139

Reviewed by Julien Chaffraix.

  • src/ChromeClientImpl.cpp:

(WebKit::ChromeClientImpl::mouseDidMoveOverElement):

  • src/ContextMenuClientImpl.cpp:

(WebKit::selectMisspelledWord):
(WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems):

  • src/WebFrameImpl.cpp:

(WebKit::WebFrameImpl::characterIndexForPoint):

Source/WebKit/efl: Disambiguate innerNodeFramePoint and mainFramePoint
https://bugs.webkit.org/show_bug.cgi?id=98139

Reviewed by Julien Chaffraix.

  • ewk/ewk_frame.cpp:

(ewk_frame_hit_test_new):

Source/WebKit/gtk: Disambiguate innerNodeFramePoint and mainFramePoint
https://bugs.webkit.org/show_bug.cgi?id=98139

Reviewed by Julien Chaffraix.

Switched to using point in innerNodeFrame. While the use here seems wrong it has been
left functionally unchanged to be fixed by a later patch.

  • webkit/webkithittestresult.cpp:

(WebKit::kit):

Source/WebKit/mac: Disambiguate innerNodeFramePoint and mainFramePoint
https://bugs.webkit.org/show_bug.cgi?id=98139

Reviewed by Julien Chaffraix.

Switch to using HitTestResult::innerNodeFrame and HitTestResult::innerNodeFramePoint.

  • WebCoreSupport/WebContextMenuClient.mm:

(WebContextMenuClient::showContextMenu):

Source/WebKit/qt: Disambiguate innerNodeFramePoint and mainFramePoint
https://bugs.webkit.org/show_bug.cgi?id=98139

Reviewed by Julien Chaffraix.

  • Api/qwebframe.cpp:

(QWebHitTestResultPrivate::QWebHitTestResultPrivate):

  • Api/qwebpage.cpp:

(QWebPagePrivate::TouchAdjuster::findCandidatePointForTouch):

Source/WebKit/win: Disambiguate innerNodeFramePoint and mainFramePoint
https://bugs.webkit.org/show_bug.cgi?id=98139

Reviewed by Julien Chaffraix.

  • WebView.cpp:

(WebView::handleContextMenuEvent):

Source/WebKit2: Disambiguate innerNodeFramePoint and mainFramePoint
https://bugs.webkit.org/show_bug.cgi?id=98139

Reviewed by Julien Chaffraix.

Switch to using HitTestResult::innerNodeFrame and HitTestResult::innerNodeFramePoint.

  • WebProcess/WebPage/WebContextMenu.cpp:

(WebKit::WebContextMenu::show):

  • WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::WebPage::characterIndexForPoint):

7:30 AM Changeset in webkit [135404] by Simon Hausmann
  • 2 edits in trunk/Source/WebKit2

Unreviewed Qt/Windows build fix.
https://bugs.webkit.org/show_bug.cgi?id=102787

Remove inclusion of QtQml, which drags in QtNetwork, which drags in qnetworksession.h, which
defines a member function called "interface". Since windows headers also define a pre-processor
macro called "interface", it has to do that. However we have now a dependency between combaseapi.h,
which #defines interface and is included earlier (before qnetworksession.h) and shlwapi.h, which _needs_
the interface macro and is included afterwards. Since this module-wide QtQml inclusion is unnecessary
and just slows down the build, this patch removes it.

  • UIProcess/API/qt/qwebkittest_p.h:
7:30 AM Changeset in webkit [135403] by wjmaclean@chromium.org
  • 4 edits in trunk/Source/WebKit/chromium

[chromium] Link highlight should display for at least 100ms, and fadeout on GestureTap/Longpress.
https://bugs.webkit.org/show_bug.cgi?id=102823

Reviewed by Adrienne Walker.

Link highlights sometimes disappear so quickly they barely display. Modify
so that the highlight is displayed for minimum 100ms before fading out, and
also fadeout (as opposed to abrupt clear) on GestureTap and GestureLongPress.

  • src/LinkHighlight.cpp:

(WebKit::LinkHighlight::LinkHighlight):
(WebKit::LinkHighlight::startHighlightAnimationIfNeeded): Check if min duration achieved, if not add time to fadeout animation.

  • src/LinkHighlight.h:

(LinkHighlight):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::handleGestureEvent): Fadeout instead of clear on GestureTap and GestureLongPress.

7:29 AM ViewportInteractionTopics edited by allan.jensen@digia.com
(diff)
7:28 AM ViewportInteractionTopics edited by allan.jensen@digia.com
(diff)
7:26 AM ViewportInteractionTopics edited by allan.jensen@digia.com
(diff)
7:17 AM Changeset in webkit [135402] by yurys@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed. Reverted expectation changes from r135380 and marked css3/filters/effect-reference-ordering-hw.html as crashing
https://bugs.webkit.org/show_bug.cgi?id=102898

  • platform/chromium/TestExpectations:
7:11 AM Changeset in webkit [135401] by commit-queue@webkit.org
  • 6 edits in trunk/Source/WebKit2

Coordinated Graphics: refactor LayerTreeRenderer::syncRemoteContent().
https://bugs.webkit.org/show_bug.cgi?id=102900

Patch by Huang Dongsung <luxtella@company100.net> on 2012-11-21
Reviewed by Noam Rosenthal.

Currently, QQuickWebPage::updatePaintNode() calls
LayerTreeRenderer::syncRemoteContent() with locking the main thread.
syncRemoteContent() is heavy, so we should not call syncRemoteContent() in
updatePaintNode(). Calling syncRemoteContent() in the painting thread is
thread-safe because syncRemoteContent() does not access any data
structures, which the main thread use.

After this patch, syncRemoteContent() is used only internally, so
syncRemoteContent() becomes private.

  • UIProcess/API/efl/EwkViewImpl.cpp:

(EwkViewImpl::displayTimerFired):

  • UIProcess/API/qt/qquickwebpage.cpp:

(QQuickWebPage::updatePaintNode):

  • UIProcess/API/qt/raw/qrawwebview.cpp:

(QRawWebView::paint):

  • UIProcess/CoordinatedGraphics/LayerTreeRenderer.cpp:

(WebKit::LayerTreeRenderer::paintToCurrentGLContext):
(WebKit::LayerTreeRenderer::ensureRootLayer):

  • UIProcess/CoordinatedGraphics/LayerTreeRenderer.h:

(LayerTreeRenderer):

7:10 AM Changeset in webkit [135400] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Gardening: svg/foreignObject/viewport-foreignobject-crash.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=102931

Unreviewed gardening.

Patch by Jussi Kukkonen <jussi.kukkonen@intel.com> on 2012-11-21

  • platform/efl/TestExpectations:
7:08 AM Changeset in webkit [135399] by abecsi@webkit.org
  • 2 edits in trunk/Source/WebKit2

[WK2] Viewport meta tag broken after r134801
https://bugs.webkit.org/show_bug.cgi?id=102801

Reviewed by Kenneth Rohde Christiansen.

If the initial-scale attribute is not explicitly specified it is left -1 by the
viewport meta algorithm and if the content is not scalable the min and max scales
are restricted by restrictScaleFactorToInitialScaleIfNotUserScalable() which resulted
in negative scales on the UI side.
Make sure that the minimum scale to fit the viewport is calculated before restricting
the scales and use this scale as the initial scale if no explicit initial scale was set.

  • UIProcess/PageViewportController.cpp:

(WebKit::PageViewportController::PageViewportController):
(WebKit::PageViewportController::pageTransitionViewportReady):
(WebKit::PageViewportController::didChangeViewportAttributes):
(WebKit::PageViewportController::updateMinimumScaleToFit):

7:07 AM Changeset in webkit [135398] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[EFL] KURL unit test crashing when tiled backing store is enabled on Release Bots
https://bugs.webkit.org/show_bug.cgi?id=102895

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-11-21
Reviewed by Gyuyoung Kim.

Change the link order so it wont override the new operator on gtest.
Looks like it was crashing because an allocator mismatch (using libc's
new and later fastMalloc delete. Thanks to Kangil Han for hinting on
the fastMalloc issue.

  • TestWebKitAPI/CMakeLists.txt:
6:46 AM Changeset in webkit [135397] by yurys@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Now that offending patch has been rolled out reenable IDBRequestTest.EventsAfterStopping
https://bugs.webkit.org/show_bug.cgi?id=102929

  • tests/IDBRequestTest.cpp:

(WebCore::TEST):

6:40 AM Changeset in webkit [135396] by yurys@chromium.org
  • 4 edits in trunk/Source/WebCore

Unreviewed, rolling out r135383.
http://trac.webkit.org/changeset/135383
https://bugs.webkit.org/show_bug.cgi?id=102935

IDBRequestTest.* unit tests are failing (Requested by yurys on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-11-21

  • bindings/v8/V8DOMWindowShell.cpp:

(WebCore::V8DOMWindowShell::installDOMWindow):

  • bindings/v8/V8DOMWindowShell.h:

(V8DOMWindowShell):
(WebCore::V8DOMWindowShell::isolated):

  • bindings/v8/WorldContextHandle.cpp:

(WebCore::WorldContextHandle::WorldContextHandle):

6:32 AM WebKitEFLLayoutTest edited by tmpsantos@gmail.com
(diff)
6:30 AM WebKitEFLLayoutTest edited by tmpsantos@gmail.com
(diff)
6:27 AM Changeset in webkit [135395] by Csaba Osztrogonác
  • 3 edits in trunk/LayoutTests

Unreviewed gardening, unskip a now passing test.

  • platform/mac-wk2/TestExpectations:
  • platform/qt-5.0-wk2/TestExpectations:
6:24 AM Changeset in webkit [135394] by gyuyoung.kim@samsung.com
  • 9 edits
    12 adds in trunk/Source

[EFL][WK2] Support Context Menu
https://bugs.webkit.org/show_bug.cgi?id=96200

Reviewed by Laszlo Gombos.

Source/WebCore:

  • page/ContextMenuController.cpp:

(WebCore::ContextMenuController::populate):
EFL port also doesn't hide unavailable menus as gtk port.

Source/WebKit2:

This patch supports WK2 EFL's context menu as WK1 implementation because we can't use elementary in inside WebKit.
Only basic functionalities of context menu are supported. Beside this implementation follows GTK's implementation.
For example, ewk_context_menu_new, ewk_context_menu_item_append, ewk_context_menu_item_remove are supported.

In addition, ewk_defines.h file is added in order to support cross inclusion as GTK port.

  • PlatformEfl.cmake:
  • UIProcess/API/efl/EWebKit2.h:
  • UIProcess/API/efl/EwkViewImpl.cpp:

(EwkViewImpl::EwkViewImpl):
(EwkViewImpl::showContextMenu):
(EwkViewImpl::hideContextMenu):

  • UIProcess/API/efl/EwkViewImpl.h:

(WebKit):
(EwkViewImpl):

  • UIProcess/API/efl/ewk_context_menu.cpp: Added.

(EwkContextMenu::EwkContextMenu):
(EwkContextMenu::~EwkContextMenu):
(EwkContextMenu::hide):
(Ewk_Context_Menu::appendItem):
(Ewk_Context_Menu::removeItem):
(EwkContextMenu::contextMenuItemSelected):
(ewk_context_menu_new):
(ewk_context_menu_new_with_items):
(ewk_context_menu_item_append):
(ewk_context_menu_item_remove):
(ewk_context_menu_hide):
(ewk_context_menu_items_get):
(ewk_context_menu_item_select):

  • UIProcess/API/efl/ewk_context_menu.h: Added.
  • UIProcess/API/efl/ewk_context_menu_item.cpp: Added.

(EwkContextMenuItem::EwkContextMenuItem):
(ewk_context_menu_item_new):
(ewk_context_menu_item_new_with_submenu):
(ewk_context_menu_item_type_get):
(ewk_context_menu_item_type_set):
(ewk_context_menu_item_action_get):
(ewk_context_menu_item_action_set):
(ewk_context_menu_item_title_get):
(ewk_context_menu_item_title_set):
(ewk_context_menu_item_checked_get):
(ewk_context_menu_item_checked_set):
(ewk_context_menu_item_enabled_get):
(ewk_context_menu_item_enabled_set):

  • UIProcess/API/efl/ewk_context_menu_item.h: Added.
  • UIProcess/API/efl/ewk_context_menu_item_private.h: Added.

(EwkContextMenuItem):
(EwkContextMenuItem::create):
(EwkContextMenuItem::action):
(EwkContextMenuItem::setAction):
(EwkContextMenuItem::title):
(EwkContextMenuItem::setTitle):
(EwkContextMenuItem::type):
(EwkContextMenuItem::setType):
(EwkContextMenuItem::checked):
(EwkContextMenuItem::setChecked):
(EwkContextMenuItem::enabled):
(EwkContextMenuItem::setEnabled):

  • UIProcess/API/efl/ewk_context_menu_private.h: Added.

(WebKit):
(EwkContextMenu):
(EwkContextMenu::create):
(EwkContextMenu::items):

  • UIProcess/API/efl/ewk_defines.h: Added.
  • UIProcess/API/efl/ewk_view.h:
  • UIProcess/API/efl/tests/test_ewk2_context_menu.cpp: Added.

(checkBasicContextMenuItem):
(showContextMenu):
(TEST_F):

  • UIProcess/efl/ContextMenuClientEfl.cpp: Added.

(toContextClientEfl):
(ContextMenuClientEfl::ContextMenuClientEfl):
(ContextMenuClientEfl::getContextMenuFromProposedMenu):

  • UIProcess/efl/ContextMenuClientEfl.h: Added.

(WebKit):
(ContextMenuClientEfl):
(WebKit::ContextMenuClientEfl::create):

  • UIProcess/efl/PageClientBase.cpp:

(WebKit::PageClientBase::createContextMenuProxy):

  • UIProcess/efl/WebContextMenuProxyEfl.cpp: Added.

(WebKit):
(WebKit::WebContextMenuProxyEfl::WebContextMenuProxyEfl):
(WebKit::WebContextMenuProxyEfl::~WebContextMenuProxyEfl):
(WebKit::WebContextMenuProxyEfl::showContextMenu):
(WebKit::WebContextMenuProxyEfl::hideContextMenu):
(WebKit::WebContextMenuProxyEfl::contextMenuItemSelected):

  • UIProcess/efl/WebContextMenuProxyEfl.h: Added.

(WebKit):
(WebContextMenuProxyEfl):
(WebKit::WebContextMenuProxyEfl::create):

6:03 AM Changeset in webkit [135393] by fmalita@chromium.org
  • 2 edits in trunk/Source/WebCore

[Chromium] Unreviewed Mac build fix after http://trac.webkit.org/changeset/135390.

  • platform/graphics/skia/GraphicsContextSkia.cpp:

(WebCore::drawInnerPath):

5:53 AM Changeset in webkit [135392] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL][WK2] Gardening: css3/device-adapt/opera/constrain-006 and -007 fail
https://bugs.webkit.org/show_bug.cgi?id=102923

Unreviewed gardening: these two still fail after using fixed layout in WTR.

Patch by Jussi Kukkonen <jussi.kukkonen@intel.com> on 2012-11-21

  • platform/efl-wk2/TestExpectations:
5:45 AM Changeset in webkit [135391] by yurys@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Disable failing test.
https://bugs.webkit.org/show_bug.cgi?id=102929

  • tests/IDBRequestTest.cpp:

(WebCore::TEST):

5:42 AM Changeset in webkit [135390] by fmalita@chromium.org
  • 20 edits in trunk/Source

[Skia] Encapsulate access to PlatformContextSkia's SkCanvas
https://bugs.webkit.org/show_bug.cgi?id=102694

Reviewed by Stephen White.

Source/WebCore:

Add SkCanvas-equivalent methods to PlatformContextSkia, and refactor direct canvas call
sites to use these wrappers instead. This reduces the number of canvas() users from 90+
to 22 (mostly theme/ui code).

No new tests: refactoring only.

  • platform/chromium/PlatformThemeChromiumLinux.cpp:

(WebCore::PlatformThemeChromiumLinux::paintArrowButton):

  • platform/graphics/chromium/FontChromiumWin.cpp:
  • platform/graphics/chromium/TransparencyWin.cpp:

(WebCore::TransparencyWin::computeLayerSize):
(WebCore::TransparencyWin::compositeOpaqueComposite):
(WebCore::TransparencyWin::compositeTextComposite):
(WebCore::TransparencyWin::makeLayerOpaque):

  • platform/graphics/filters/skia/FEBlendSkia.cpp:

(WebCore::FEBlend::platformApplySkia):

  • platform/graphics/filters/skia/FEColorMatrixSkia.cpp:

(WebCore::FEColorMatrix::platformApplySkia):

  • platform/graphics/filters/skia/FEComponentTransferSkia.cpp:

(WebCore::FEComponentTransfer::platformApplySkia):

  • platform/graphics/filters/skia/FELightingSkia.cpp:

(WebCore::FELighting::platformApplySkia):

  • platform/graphics/harfbuzz/FontHarfBuzz.cpp:

(WebCore::Font::drawGlyphs):
(WebCore::Font::drawComplexText):

  • platform/graphics/skia/FontSkia.cpp:

(WebCore::Font::drawGlyphs):

  • platform/graphics/skia/GraphicsContextSkia.cpp:

(WebCore::GraphicsContext::addInnerRoundedRectClip):
(WebCore::GraphicsContext::clearRect):
(WebCore::GraphicsContext::clip):
(WebCore::GraphicsContext::clipOut):
(WebCore::GraphicsContext::clipPath):
(WebCore::GraphicsContext::concatCTM):
(WebCore::GraphicsContext::setCTM):
(WebCore::GraphicsContext::drawConvexPolygon):
(WebCore::GraphicsContext::clipConvexPolygon):
(WebCore::GraphicsContext::drawEllipse):
(WebCore::drawOuterPath):
(WebCore::GraphicsContext::drawLine):
(WebCore::GraphicsContext::drawLineForDocumentMarker):
(WebCore::GraphicsContext::drawLineForText):
(WebCore::GraphicsContext::fillPath):
(WebCore::GraphicsContext::fillRect):
(WebCore::GraphicsContext::fillRoundedRect):
(WebCore::GraphicsContext::getCTM):
(WebCore::GraphicsContext::scale):
(WebCore::GraphicsContext::strokeArc):
(WebCore::GraphicsContext::strokePath):
(WebCore::GraphicsContext::strokeRect):
(WebCore::GraphicsContext::rotate):
(WebCore::GraphicsContext::translate):
(WebCore::GraphicsContext::platformFillEllipse):
(WebCore::GraphicsContext::platformStrokeEllipse):

  • platform/graphics/skia/ImageBufferSkia.cpp:

(WebCore::getImageData):
(WebCore::ImageBuffer::getUnmultipliedImageData):
(WebCore::ImageBuffer::getPremultipliedImageData):
(WebCore::ImageBuffer::putByteArray):
(WebCore::ImageBuffer::toDataURL):

  • platform/graphics/skia/ImageSkia.cpp:

(WebCore::drawResampledBitmap):
(WebCore::hasNon90rotation):
(WebCore::paintSkBitmap):
(WebCore::Image::drawPattern):

  • platform/graphics/skia/PlatformContextSkia.cpp:

(WebCore::PlatformContextSkia::save):
(WebCore::PlatformContextSkia::beginLayerClippedToImage):
(WebCore::PlatformContextSkia::restore):
(WebCore::PlatformContextSkia::drawRect):
(WebCore::PlatformContextSkia::couldUseLCDRenderedText):

  • platform/graphics/skia/PlatformContextSkia.h:

(PlatformContextSkia):
(WebCore::PlatformContextSkia::layerBitmap):
(WebCore):
(WebCore::PlatformContextSkia::readPixels):
(WebCore::PlatformContextSkia::writePixels):
(WebCore::PlatformContextSkia::isDrawingToLayer):
(WebCore::PlatformContextSkia::isVector):
(WebCore::PlatformContextSkia::clipPath):
(WebCore::PlatformContextSkia::clipRect):
(WebCore::PlatformContextSkia::getClipBounds):
(WebCore::PlatformContextSkia::setMatrix):
(WebCore::PlatformContextSkia::getTotalMatrix):
(WebCore::PlatformContextSkia::concat):
(WebCore::PlatformContextSkia::rotate):
(WebCore::PlatformContextSkia::scale):
(WebCore::PlatformContextSkia::translate):
(WebCore::PlatformContextSkia::drawBitmap):
(WebCore::PlatformContextSkia::drawBitmapRect):
(WebCore::PlatformContextSkia::drawOval):
(WebCore::PlatformContextSkia::drawPath):
(WebCore::PlatformContextSkia::drawPoints):
(WebCore::PlatformContextSkia::drawRect):
(WebCore::PlatformContextSkia::drawIRect):
(WebCore::PlatformContextSkia::drawPosText):
(WebCore::PlatformContextSkia::drawPosTextH):
(WebCore::PlatformContextSkia::drawTextOnPath):

  • platform/graphics/skia/SkiaFontWin.cpp:

(WebCore::skiaDrawText):
(WebCore::paintSkiaText):

  • platform/graphics/skia/SkiaUtils.cpp:

(WebCore::ClipRectToCanvas):

  • platform/graphics/skia/SkiaUtils.h:

(WebCore):

Source/WebKit/chromium:

Use PlatformContextSkia's wrapper methods instead of accessing the canvas directly.

  • tests/TransparencyWinTest.cpp:

(WebCore::getPixelAt):
(WebCore::clearTopLayerAlphaChannel):
(WebCore::clearTopLayerAlphaPixel):
(WebCore::TEST):

5:32 AM Changeset in webkit [135389] by Csaba Osztrogonác
  • 3 edits in trunk/LayoutTests

[Qt] Unreviewed gardening, unskip s now passing test.

  • platform/qt-5.0-wk2/TestExpectations:
  • platform/qt/TestExpectations:
5:24 AM Changeset in webkit [135388] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebCore

Reset the slider thumb location before every layout of the slider container
https://bugs.webkit.org/show_bug.cgi?id=102817

Reviewed by Tony Chang.

The location of the slider thumb is set by the slider container
assuming the slider thumb has been laid out. When this happens,
the location of the slider thumb is reset during the layout
ignoring any previous location set. If the slider thumb is not
laid out, the previous value is added to the new one by the slider
container.

  • html/shadow/SliderThumbElement.cpp:

(WebCore::RenderSliderContainer::layout): Reset the location of
the slider thumb before calling RenderFlexibleBox::layout().

5:00 AM Changeset in webkit [135387] by haraken@chromium.org
  • 9 edits in trunk

Unreviewed, rolling out r135340.
http://trac.webkit.org/changeset/135340
https://bugs.webkit.org/show_bug.cgi?id=102492

It broke Safari's internal build

Source/WebCore:

  • bindings/scripts/CodeGenerator.pm:

(ProcessDocument):
(FileNamePrefix):

  • bindings/scripts/CodeGeneratorCPP.pm:

(new):
(GenerateInterface):
(WriteData):

  • bindings/scripts/CodeGeneratorGObject.pm:

(new):
(WriteData):
(GenerateInterface):

  • bindings/scripts/CodeGeneratorJS.pm:

(new):
(GenerateInterface):
(WriteData):

  • bindings/scripts/CodeGeneratorObjC.pm:

(new):
(GenerateInterface):
(WriteData):

  • bindings/scripts/CodeGeneratorV8.pm:

(new):
(GenerateInterface):
(WriteData):

Tools:

  • WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:

(new):
(GenerateModule):
(GenerateInterface):
(finish):

4:37 AM Changeset in webkit [135386] by pfeldman@chromium.org
  • 5 edits in trunk

Web Inspector: reparenting view does not detach from the previous parent.
https://bugs.webkit.org/show_bug.cgi?id=102902

Reviewed by Vsevolod Vlasov.

Source/WebCore:

  • inspector/front-end/View.js:

(WebInspector.View.prototype.show):

LayoutTests:

  • inspector/view-events.html:
4:30 AM Changeset in webkit [135385] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening, unskip now passing tests.

  • platform/qt-5.0/TestExpectations:
4:26 AM Changeset in webkit [135384] by loislo@chromium.org
  • 11 edits in trunk/Source/WebCore

Web Inspector: NMI add instrumentation to widely used ActiveDOMObjects. XMLHttpRequest, Prerenderer, HTMLMediaElement and DOMTimer.
https://bugs.webkit.org/show_bug.cgi?id=102818

Reviewed by Vsevolod Vlasov.

Our test bot counts pointers which don't match with objects allocated by tcmalloc.
This counter becomes nonzero after instrumenting ActiveDOMObject class.
It happens because it is the base class for many other classes (~30).
And almost all these classes use multiple inheritance.

  • dom/Document.cpp:

(WebCore::Document::reportMemoryUsage):

  • dom/DocumentEventQueue.cpp:
  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::reportMemoryUsage):
(WebCore):

  • html/HTMLMediaElement.h:
  • loader/Prerenderer.cpp:

(WebCore::Prerenderer::reportMemoryUsage):
(WebCore):

  • loader/Prerenderer.h:

(Prerenderer):

  • page/DOMTimer.cpp:

(WebCore::DOMTimer::reportMemoryUsage):
(WebCore):

  • page/DOMTimer.h:

(DOMTimer):

  • xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::reportMemoryUsage):
(WebCore):

  • xml/XMLHttpRequest.h:

(XMLHttpRequest):

4:24 AM Changeset in webkit [135383] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

[V8] Add context checks to WorldContextHandle and V8DOMWindowShell
https://bugs.webkit.org/show_bug.cgi?id=101573

Patch by Dan Carney <dcarney@google.com> on 2012-11-21
Reviewed by Adam Barth.

Added a bunch of assertions to ensure the problems with IndexedDB
contexts cannot reemerge.

No new tests. No change in functionality.

  • bindings/v8/V8DOMWindowShell.cpp:

(WebCore):
(WebCore::V8DOMWindowShell::assertContextHasCorrectPrototype):

  • bindings/v8/V8DOMWindowShell.h:

(V8DOMWindowShell):
(WebCore::V8DOMWindowShell::isolated):

  • bindings/v8/WorldContextHandle.cpp:

(WebCore::WorldContextHandle::WorldContextHandle):

4:19 AM Changeset in webkit [135382] by Csaba Osztrogonác
  • 3 edits in trunk/LayoutTests

[Qt] Unreviewed gardening, unskip a now passing test, update an expected file.

  • platform/qt-5.0/TestExpectations:
  • platform/qt-5.0/editing/selection/click-left-of-rtl-wrapping-text-expected.txt:
4:04 AM Changeset in webkit [135381] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening, unskip now passing tests.

  • platform/qt/TestExpectations:
3:57 AM Changeset in webkit [135380] by yurys@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed. Mark css3/filters/effect-reference-ordering-hw.html as crashing after crrev.com/168998

  • platform/chromium/TestExpectations:
3:56 AM FeatureFlags edited by tkent@chromium.org
Don't use https for lists.webkit.org (diff)
3:48 AM Changeset in webkit [135379] by commit-queue@webkit.org
  • 5 edits in trunk/Source

WebMediaStreamComponent: Add assignment and copy operators
https://bugs.webkit.org/show_bug.cgi?id=102915

Patch by Harald Alvestrand <hta@google.com> on 2012-11-21
Reviewed by Adam Barth.

Source/Platform:

  • chromium/public/WebMediaStreamComponent.h:

(WebKit::WebMediaStreamComponent::WebMediaStreamComponent):
(WebKit::WebMediaStreamComponent::operator=):
(WebMediaStreamComponent):

Source/WebCore:

Tests that use this functionality are being submitted to Chrome.

  • platform/chromium/support/WebMediaStreamComponent.cpp:

(WebKit::WebMediaStreamComponent::assign):
(WebKit):

  • platform/chromium/support/WebMediaStreamDescriptor.cpp:
3:43 AM Changeset in webkit [135378] by haraken@chromium.org
  • 21 edits in trunk/Source/WebCore

[V8] Remove STRING_TO_V8PARAMETER_EXCEPTION_BLOCK()
https://bugs.webkit.org/show_bug.cgi?id=102917

Reviewed by Adam Barth.

Now EXCEPTION_BLOCK() and STRING_TO_V8PARAMETER_EXCEPTION_BLOCK()
are equivalent. We can remove STRING_TO_V8PARAMETER_EXCEPTION_BLOCK().
To make a code generate change smaller, this patch also renames
STRING_TO_V8PARAMETER_EXCEPTION_BLOCK_VOID() to EXCEPTION_BLOCK_VOID().
I will rename these macros in a follow-up patch.

No tests. No change in behavior.

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateEventConstructorCallback):
(ConvertToV8Parameter):

  • bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:

(WebCore::TestActiveDOMObjectV8Internal::postMessageCallback):

  • bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:

(WebCore::TestCustomNamedGetterV8Internal::anotherFunctionCallback):

  • bindings/scripts/test/V8/V8TestEventConstructor.cpp:

(WebCore::V8TestEventConstructor::constructorCallback):

  • bindings/scripts/test/V8/V8TestInterface.cpp:

(WebCore::TestInterfaceV8Internal::supplementalStaticAttrAttrSetter):
(WebCore::TestInterfaceV8Internal::supplementalStr2AttrSetter):
(WebCore::TestInterfaceV8Internal::supplementalMethod2Callback):
(WebCore::V8TestInterface::constructorCallback):

  • bindings/scripts/test/V8/V8TestNamedConstructor.cpp:

(WebCore::V8TestNamedConstructorConstructorCallback):

  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::TestObjV8Internal::staticStringAttrAttrSetter):
(WebCore::TestObjV8Internal::stringAttrAttrSetter):
(WebCore::TestObjV8Internal::reflectedStringAttrAttrSetter):
(WebCore::TestObjV8Internal::reflectedURLAttrAttrSetter):
(WebCore::TestObjV8Internal::reflectedCustomURLAttrAttrSetter):
(WebCore::TestObjV8Internal::stringAttrWithGetterExceptionAttrSetter):
(WebCore::TestObjV8Internal::stringAttrWithSetterExceptionAttrSetter):
(WebCore::TestObjV8Internal::voidMethodWithArgsCallback):
(WebCore::TestObjV8Internal::longMethodWithArgsCallback):
(WebCore::TestObjV8Internal::objMethodWithArgsCallback):
(WebCore::TestObjV8Internal::methodThatRequiresAllArgsAndThrowsCallback):
(WebCore::TestObjV8Internal::methodWithOptionalStringCallback):
(WebCore::TestObjV8Internal::methodWithOptionalStringIsUndefinedCallback):
(WebCore::TestObjV8Internal::methodWithOptionalStringIsNullStringCallback):
(WebCore::TestObjV8Internal::overloadedMethod1Callback):
(WebCore::TestObjV8Internal::overloadedMethod3Callback):
(WebCore::TestObjV8Internal::overloadedMethod11Callback):
(WebCore::TestObjV8Internal::overloadedMethod12Callback):
(WebCore::TestObjV8Internal::strictFunctionCallback):
(WebCore::TestObjV8Internal::variadicStringMethodCallback):

  • bindings/scripts/test/V8/V8TestOverloadedConstructors.cpp:

(WebCore::V8TestOverloadedConstructors::constructor4Callback):

  • bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:

(WebCore::V8TestSerializedScriptValueInterface::constructorCallback):

  • bindings/v8/V8BindingMacros.h:
  • bindings/v8/V8StringResource.h:

(V8Parameter):

  • bindings/v8/custom/V8ConsoleCustom.cpp:

(WebCore::V8Console::profileCallback):
(WebCore::V8Console::profileEndCallback):

  • bindings/v8/custom/V8DOMWindowCustom.cpp:

(WebCore::handlePostMessageCallback):

  • bindings/v8/custom/V8DeviceMotionEventCustom.cpp:

(WebCore::V8DeviceMotionEvent::initDeviceMotionEventCallback):

  • bindings/v8/custom/V8DeviceOrientationEventCustom.cpp:

(WebCore::V8DeviceOrientationEvent::initDeviceOrientationEventCallback):

  • bindings/v8/custom/V8HistoryCustom.cpp:

(WebCore::V8History::pushStateCallback):
(WebCore::V8History::replaceStateCallback):

  • bindings/v8/custom/V8IntentCustom.cpp:

(WebCore::V8Intent::constructorCallbackCustom):

  • bindings/v8/custom/V8SQLTransactionCustom.cpp:

(WebCore::V8SQLTransaction::executeSqlCallback):

  • bindings/v8/custom/V8SQLTransactionSyncCustom.cpp:

(WebCore::V8SQLTransactionSync::executeSqlCallback):

  • bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:

(WebCore::V8WebGLRenderingContext::getExtensionCallback):

3:38 AM ViewportInteractionTopics edited by kenneth@webkit.org
(diff)
3:25 AM Changeset in webkit [135377] by haraken@chromium.org
  • 4 edits
    2 adds in trunk/Source/WebCore

[V8] Move V8DOMWindowShell::initializeV8IfNeeded() to V8Initializer
https://bugs.webkit.org/show_bug.cgi?id=102899

Reviewed by Adam Barth.

This is an incremental step to kill WorkerContextExecutionProxy.
As commented by abarth in bug 97066, we move
V8DOMWindowShell::initializeV8IfNeeded() to V8Initializer.
This patch renames initializeV8IfNeeded() to initializeMainThreadIfNeeded()
because we will add initializeWorkerIfNeeded() in a follow-up patch.

No tests. No change in behavior.

  • UseV8.cmake:
  • WebCore.gypi:
  • bindings/v8/V8DOMWindowShell.cpp:

(WebCore::V8DOMWindowShell::initializeIfNeeded):

  • bindings/v8/V8Initializer.cpp: Added.

(WebCore):
(WebCore::findFrame):
(WebCore::reportFatalError):
(WebCore::reportUncaughtException):
(WebCore::reportUnsafeJavaScriptAccess):
(WebCore::V8Initializer::initializeMainThreadIfNeeded):

  • bindings/v8/V8Initializer.h: Added.

(WebCore):
(V8Initializer):

3:23 AM Changeset in webkit [135376] by Csaba Osztrogonác
  • 3 edits in trunk/LayoutTests

[Qt] Unreviewed gardening, unskip a now passing test.

  • platform/qt-5.0-wk2/TestExpectations:
  • platform/qt/TestExpectations:
3:14 AM Changeset in webkit [135375] by gyuyoung.kim@samsung.com
  • 5 edits in trunk

[EFL] Turn on WTF_USE_TILED_BACKING_STORE by default
https://bugs.webkit.org/show_bug.cgi?id=101526

.:

Patch by Yael Aharon <yael.aharon@intel.com> on 2012-11-21
Reviewed by Kenneth Rohde Christiansen.

Separate out ENABLE_WEBGL. It is not ready to be enabled by default.

  • Source/cmake/OptionsEfl.cmake:

Tools:

Reviewed by Kenneth Rohde Christiansen.

Turn on WTF_USE_TILED_BACKING_STORE for EFL port.

  • Scripts/webkitperl/FeatureList.pm:
  • TestWebKitAPI/CMakeLists.txt: No include KURL.cpp because of API test crash.
3:00 AM Changeset in webkit [135374] by apavlov@chromium.org
  • 5 edits in trunk

Turn -webkit-text-emphasis into a shorthand property
https://bugs.webkit.org/show_bug.cgi?id=102879

Reviewed by Antti Koivisto.

Source/WebCore:

-webkit-text-emphasis value is no longer empty.

  • css/StylePropertySet.cpp:

(WebCore::StylePropertySet::getPropertyValue): Reconstruct the -webkit-text-emphasis value based on the longhands.

LayoutTests:

Update expected results.

  • fast/css/parsing-text-emphasis-expected.txt:
  • fast/css/parsing-text-emphasis.html:
3:00 AM Changeset in webkit [135373] by Carlos Garcia Campos
  • 1 copy in releases/WebKitGTK/webkit-1.11.2

Tagging the WebKitGTK+ 1.11.2 release

2:55 AM Changeset in webkit [135372] by commit-queue@webkit.org
  • 6 edits in trunk

[EFL][WK2] Rename ewk_view_setting_encoding_custom_XXX to ewk_view_custom_encoding_XXX
https://bugs.webkit.org/show_bug.cgi?id=102867

Patch by Jongseok Yang <js45.yang@samsung.com> on 2012-11-21
Reviewed by Gyuyoung Kim.

Rename ewk_view_setting_encoding_custom_XXX to ewk_view_custom_encoding_XXX.

ewk_view_setting_encoding_custom_XXX APIs might be misunderstanded as the "setting" word
because ewk_view_setting_encoding_custom_set triggers the "reload" operation.
And ewk_view_setting_XXX is not correct because there is ewk_settings object for settings.

Source/WebKit2:

  • UIProcess/API/efl/ewk_view.cpp:

(ewk_view_encoding_custom_get):
(ewk_view_encoding_custom_set):

  • UIProcess/API/efl/ewk_view.h:
  • UIProcess/API/efl/tests/test_ewk2_view.cpp:

(TEST_F):

Tools:

  • MiniBrowser/efl/main.c:

(on_key_down):

2:54 AM Changeset in webkit [135371] by tkent@chromium.org
  • 8 edits
    9 copies in branches/chromium/1312

Merge 135131 - input.value="" should clear date/time input elements with partial values
https://bugs.webkit.org/show_bug.cgi?id=102645

Reviewed by Kentaro Hara.

Source/WebCore:

Tests: fast/forms/date-multiple-fields/date-multiple-fields-value-set-empty.html

fast/forms/datetime-multiple-fields/datetime-multiple-fields-value-set-empty.html
fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-value-set-empty.html
fast/forms/month-multiple-fields/month-multiple-fields-value-set-empty.html
fast/forms/time-multiple-fields/time-multiple-fields-value-set-empty.html
fast/forms/week-multiple-fields/week-multiple-fields-value-set-empty.html

  • html/BaseMultipleFieldsDateAndTimeInputType.cpp:

(WebCore::BaseMultipleFieldsDateAndTimeInputType::setValue):
If the new value is an empty string and sub-fields has values, we should
update the UI value to the empty state.

  • html/DateTimeFieldsState.h:

(WebCore::DateTimeFieldsState::hasAnyValue):
Added. It returns true if one or more sub-fields are not empty.

LayoutTests:

  • Add tests for each of date/time input types.
  • Add them to TextExpectations for platforms without ENABLE_INPUT_MULTIPLE_FIELDS_UI.
  • fast/forms/date-multiple-fields/date-multiple-fields-value-set-empty-expected.txt: Added.
  • fast/forms/date-multiple-fields/date-multiple-fields-value-set-empty.html: Added.
  • fast/forms/datetime-multiple-fields/datetime-multiple-fields-value-set-empty-expected.txt: Added.
  • fast/forms/datetime-multiple-fields/datetime-multiple-fields-value-set-empty.html: Added.
  • fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-value-set-empty-expected.txt: Added.
  • fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-value-set-empty.html: Added.
  • fast/forms/month-multiple-fields/month-multiple-fields-value-set-empty-expected.txt: Added.
  • fast/forms/month-multiple-fields/month-multiple-fields-value-set-empty.html: Added.
  • fast/forms/resources/multiple-fields-value-set-empty.js: Added.
  • fast/forms/time-multiple-fields/time-multiple-fields-value-set-empty-expected.txt: Added.
  • fast/forms/time-multiple-fields/time-multiple-fields-value-set-empty.html: Added.
  • fast/forms/week-multiple-fields/week-multiple-fields-value-set-empty-expected.txt: Added.
  • fast/forms/week-multiple-fields/week-multiple-fields-value-set-empty.html: Added.
  • platform/chromium-android/TestExpectations:
  • platform/efl/TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/mac/TestExpectations:
  • platform/qt/TestExpectations:
  • platform/win/TestExpectations:

TBR=tkent@chromium.org
Review URL: https://codereview.chromium.org/11421028

2:50 AM Changeset in webkit [135370] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening, unskip now passing tests.

  • platform/qt-5.0-wk2/TestExpectations:
2:36 AM Changeset in webkit [135369] by haraken@chromium.org
  • 2 edits in trunk/Source/WebCore

Unreviewed. Build fix.

  • bindings/v8/custom/V8BlobCustom.cpp:

(WebCore::V8Blob::constructorCallbackCustom):

2:24 AM Changeset in webkit [135368] by haraken@chromium.org
  • 3 edits
    3 moves in trunk/Source/WebCore

[V8] Rename v8/custom/*Constructor.cpp to v8/custom/*Custom.cpp
https://bugs.webkit.org/show_bug.cgi?id=102881

Reviewed by Adam Barth.

Writing constructorCallback()s in *Custom.cpp is a convention of
custom bindings of JSC and V8. We can rename v8/custom/*Constructor.cpp
to v8/custom/*Custom.cpp.

No tests. No change in behavior.

  • UseV8.cmake: This file is already out of sync.
  • WebCore.gypi:
  • bindings/v8/custom/V8IntentCustom.cpp: Renamed from Source/WebCore/bindings/v8/custom/V8IntentConstructor.cpp.

(WebCore):
(WebCore::V8Intent::constructorCallbackCustom):

  • bindings/v8/custom/V8MessageChannelCustom.cpp: Renamed from Source/WebCore/bindings/v8/custom/V8MessageChannelConstructor.cpp.

(WebCore):
(WebCore::V8MessageChannel::constructorCallbackCustom):

  • bindings/v8/custom/V8WebKitPointCustom.cpp: Renamed from Source/WebCore/bindings/v8/custom/V8WebKitPointConstructor.cpp.

(WebCore):
(WebCore::V8WebKitPoint::constructorCallbackCustom):

2:19 AM Changeset in webkit [135367] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[V8] Inspector does not callback IDB methods in context
https://bugs.webkit.org/show_bug.cgi?id=101725

Patch by Dan Carney <dcarney@google.com> on 2012-11-21
Reviewed by Adam Barth.

Inserted v8 context before calling out to IDB.

No new tests.

  • inspector/InspectorIndexedDBAgent.cpp:

(WebCore::InspectorIndexedDBAgent::requestDatabaseNamesForFrame):
(WebCore::InspectorIndexedDBAgent::requestDatabase):
(WebCore::InspectorIndexedDBAgent::requestData):

2:17 AM Changeset in webkit [135366] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

REGRESSION(134048): TiledBackingStore must create tiles when the contents rect is changed.
https://bugs.webkit.org/show_bug.cgi?id=102035

Patch by Huang Dongsung <luxtella@company100.net> on 2012-11-21
Reviewed by Kenneth Rohde Christiansen.

Before r134048, the visibleRect contained information of both the viewport and
the contents rect. Now the visible rect is related to only the viewport. So
TiledBackingStore::coverWithTilesIfNeeded() early returns even if the contents
rect is changed, because changing the contents rect is independent on changing
both a trajectory vector and the visible rect.

  • platform/graphics/TiledBackingStore.cpp:

(WebCore::TiledBackingStore::coverWithTilesIfNeeded):

2:12 AM Changeset in webkit [135365] by dgrogan@chromium.org
  • 6 edits in trunk/LayoutTests

IndexedDB: remove setVersion from inspector tests
https://bugs.webkit.org/show_bug.cgi?id=102850

Reviewed by Vsevolod Vlasov.

setVersion was contained so the conversion to upgradeneeded was
straightforward.

  • http/tests/inspector/indexeddb/database-data-expected.txt:
  • http/tests/inspector/indexeddb/database-structure-expected.txt:
  • http/tests/inspector/indexeddb/indexeddb-test.js:

(.request.onsuccess.onSuccess.request.onupgradeneeded):
(.request.onsuccess.onSuccess.request.onsuccess):
(.request.onsuccess):
(doWithVersionTransaction):

  • http/tests/inspector/indexeddb/resources-panel-expected.txt:
1:56 AM Changeset in webkit [135364] by commit-queue@webkit.org
  • 10 edits
    1 add in trunk/LayoutTests

Unreviewed, rolling out r135307.
http://trac.webkit.org/changeset/135307
https://bugs.webkit.org/show_bug.cgi?id=102905

Jussi said this doesn't definitively fix things, so revert for
now. (Requested by rakuco on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-11-21

  • animations/resources/stop-animation-on-suspend-subframe.html:
  • animations/stop-animation-on-suspend.html:
  • platform/chromium-mac/animations/stop-animation-on-suspend-expected.txt: Added.
  • platform/chromium/TestExpectations:
  • platform/efl/TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/mac/TestExpectations:
  • platform/qt-arm/TestExpectations:
  • platform/win/TestExpectations:
  • platform/wincairo/TestExpectations:
1:39 AM Changeset in webkit [135363] by vsevik@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: Request preview tuning: enable json preview for text/html XHRs
https://bugs.webkit.org/show_bug.cgi?id=102892

Reviewed by Alexander Pavlov.

  • inspector/front-end/RequestPreviewView.js:

(WebInspector.RequestPreviewView.prototype._jsonView):
(WebInspector.RequestPreviewView.prototype._htmlView):
(WebInspector.RequestPreviewView.prototype._createPreviewView):

1:38 AM Changeset in webkit [135362] by haraken@chromium.org
  • 7 edits in trunk/Source/WebCore

[V8] Remove manually written v8::TryCatches in custom bindings
https://bugs.webkit.org/show_bug.cgi?id=102883

Reviewed by Adam Barth.

We can replace them with the EXCEPTION_BLOCK() macro or its friends.

No new tests. This patch shouldn't change any behavior.

  • bindings/v8/custom/V8DOMWindowCustom.cpp:

(WebCore::handlePostMessageCallback):

  • bindings/v8/custom/V8DocumentCustom.cpp:

(WebCore::V8Document::evaluateCallback):

  • bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp:

(WebCore::V8HTMLOptionsCollection::addCallback):

  • bindings/v8/custom/V8HistoryCustom.cpp:

(WebCore::V8History::pushStateCallback):
(WebCore::V8History::replaceStateCallback):

1:26 AM Changeset in webkit [135361] by haraken@chromium.org
  • 3 edits
    5 moves in trunk/Source/WebCore

Unreviewed, rolling out r135358.
http://trac.webkit.org/changeset/135358
https://bugs.webkit.org/show_bug.cgi?id=102881

It broke Chromium/Linux build

  • UseV8.cmake:
  • WebCore.gypi:
  • bindings/v8/custom/V8HTMLImageElementConstructor.cpp: Renamed from Source/WebCore/bindings/v8/custom/V8HTMLImageElementCustom.cpp.

(WebCore):
(WebCore::v8HTMLImageElementConstructorCallback):
(WebCore::V8HTMLImageElementConstructor::GetTemplate):

  • bindings/v8/custom/V8HTMLImageElementConstructor.h: Renamed from Source/WebCore/bindings/v8/custom/V8HTMLImageElementCustom.h.

(WebCore):
(V8HTMLImageElementConstructor):

  • bindings/v8/custom/V8IntentConstructor.cpp: Renamed from Source/WebCore/bindings/v8/custom/V8IntentCustom.cpp.

(WebCore):
(WebCore::V8Intent::constructorCallbackCustom):

  • bindings/v8/custom/V8MessageChannelConstructor.cpp: Renamed from Source/WebCore/bindings/v8/custom/V8MessageChannelCustom.cpp.

(WebCore):
(WebCore::V8MessageChannel::constructorCallbackCustom):

  • bindings/v8/custom/V8WebKitPointConstructor.cpp: Renamed from Source/WebCore/bindings/v8/custom/V8WebKitPointCustom.cpp.

(WebCore):
(WebCore::V8WebKitPoint::constructorCallbackCustom):

1:09 AM Changeset in webkit [135360] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Unused parameters on ScrollingCoordinator.cpp
https://bugs.webkit.org/show_bug.cgi?id=102884

Patch by KyungTae Kim <ktf.kim@samsung.com> on 2012-11-21
Reviewed by Kentaro Hara.

Because the 'scrollingLayerPositionAction' parameter is not used when !USE(ACCELERATED_COMPOSITING),
use UNUSED_PARAM macro to fix build warning -Wunused-parameter

  • page/scrolling/ScrollingCoordinator.cpp:

(WebCore::ScrollingCoordinator::updateMainFrameScrollPosition):

1:08 AM Changeset in webkit [135359] by haraken@chromium.org
  • 3 edits in trunk/Source/WebCore

[V8] Replace V8Parameter::prepare() with V8Parameter::operator=()
https://bugs.webkit.org/show_bug.cgi?id=102870

Reviewed by Adam Barth.

This is an incremental step for V8Parameter refactoring.
By replacing V8Parameter::prepare() with V8Parameter::operator=(),
we can make EXCEPTION_BLOCK() and STRING_TO_V8PARAMETER_EXCEPTION_BLOCK()
equivalent (except for a return value).

Tests: fast/workers/worker-constructor.html

storage/websql/sql-error-codes.html
inspector/console/alert-toString-exception.html
http/tests/websocket/tests/hybi/send-throw.html

  • bindings/v8/V8BindingMacros.h:
  • bindings/v8/V8StringResource.h:

(WebCore::V8Parameter::V8Parameter):
(V8Parameter):
(WebCore::=):

1:06 AM Changeset in webkit [135358] by haraken@chromium.org
  • 3 edits
    5 moves in trunk/Source/WebCore

[V8] Rename v8/custom/*Constructor.cpp to v8/custom/*Custom.cpp
https://bugs.webkit.org/show_bug.cgi?id=102881

Reviewed by Adam Barth.

Writing constructorCallback()s in *Custom.cpp is a convention of
custom bindings of JSC and V8. We can rename v8/custom/*Constructor.cpp
to v8/custom/*Custom.cpp.

No tests. No change in behavior.

  • UseV8.cmake: This file is already out of sync.
  • WebCore.gypi:
  • bindings/v8/custom/V8HTMLImageElementCustom.cpp: Renamed from Source/WebCore/bindings/v8/custom/V8HTMLImageElementConstructor.cpp.

(WebCore):
(WebCore::v8HTMLImageElementConstructorCallback):
(WebCore::V8HTMLImageElementConstructor::GetTemplate):

  • bindings/v8/custom/V8HTMLImageElementCustom.h: Renamed from Source/WebCore/bindings/v8/custom/V8HTMLImageElementConstructor.h.

(WebCore):
(V8HTMLImageElementConstructor):

  • bindings/v8/custom/V8IntentCustom.cpp: Renamed from Source/WebCore/bindings/v8/custom/V8IntentConstructor.cpp.

(WebCore):
(WebCore::V8Intent::constructorCallbackCustom):

  • bindings/v8/custom/V8MessageChannelCustom.cpp: Renamed from Source/WebCore/bindings/v8/custom/V8MessageChannelConstructor.cpp.

(WebCore):
(WebCore::V8MessageChannel::constructorCallbackCustom):

  • bindings/v8/custom/V8WebKitPointCustom.cpp: Renamed from Source/WebCore/bindings/v8/custom/V8WebKitPointConstructor.cpp.

(WebCore):
(WebCore::V8WebKitPoint::constructorCallbackCustom):

1:04 AM Changeset in webkit [135357] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: [Canvas] throttle wait icon in the ui
https://bugs.webkit.org/show_bug.cgi?id=102685

Patch by Andrey Adaikin <aandrey@chromium.org> on 2012-11-21
Reviewed by Vsevolod Vlasov.

Do not show the wait icon for small operations during the replay to reduce flickering.

  • inspector/front-end/CanvasProfileView.js:

(WebInspector.CanvasProfileView.prototype._enableWaitIcon):

12:51 AM Changeset in webkit [135356] by yurys@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed. Updated test expectations.

  • platform/chromium/TestExpectations:
12:23 AM Changeset in webkit [135355] by commit-queue@webkit.org
  • 4 edits
    1 delete in trunk

Enable datalist UI for input types datetime and datetime-local
https://bugs.webkit.org/show_bug.cgi?id=102882

Patch by Kunihiko Sakamoto <ksakamoto@chromium.org> on 2012-11-21
Reviewed by Kent Tamura.

Source/WebCore:

Enabling datalist UI for input types datetime and datetime-local.

No new tests yet. Tests will be added later in Bug 102888.

  • platform/text/PlatformLocale.cpp:

(WebCore::Locale::formatDateTime): Support datetime and datetime-local types.

  • rendering/RenderThemeChromiumCommon.cpp:

(WebCore::RenderThemeChromiumCommon::supportsDataListUI): Add datetime and datetimelocal to the list.

LayoutTests:

Removed expectation of failure.

  • platform/chromium/fast/forms/datalist/input-list-expected.txt: Removed.

Nov 20, 2012:

10:50 PM Changeset in webkit [135354] by haraken@chromium.org
  • 4 edits
    1 delete in trunk/Source/WebCore

[V8] Remove v8/custom/V8XMLHttpRequestConstructor.cpp
https://bugs.webkit.org/show_bug.cgi?id=102876

Reviewed by Sam Weinig.

It doesn't make sense to have one custom cpp file for
XXX::constructorCallback() only. We can move XXX::constructorCallback()
in v8/custom/V8XXXConstructor.cpp to v8/custom/V8XXXCustom.cpp
and thus remove v8/custom/V8XXXConstructor.cpp.

Note: Some XXX::constructorCallback()s are already written in
v8/custom/V8XXXCustom.cpp. JSC already has almost all
XXX::constructorCallback()s in js/JSXXXCustom.cpp.

No tests. No change in behavior.

  • UseV8.cmake:
  • WebCore.gypi:
  • bindings/v8/custom/V8XMLHttpRequestConstructor.cpp: Removed.
  • bindings/v8/custom/V8XMLHttpRequestCustom.cpp:

(WebCore::V8XMLHttpRequest::constructorCallbackCustom):
(WebCore):

10:48 PM Changeset in webkit [135353] by yurys@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed. Fixed webkit_lint complaints about overlapping entries in Chromium TestExpectations.

  • platform/chromium/TestExpectations:
10:10 PM Changeset in webkit [135352] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed morning gardening, skip a new security
timeouting test to paint the bots green.

  • platform/qt/TestExpectations:
10:07 PM Changeset in webkit [135351] by haraken@chromium.org
  • 16 edits in trunk/Source/WebCore

Unreviewed. Rebaselined run-bindings-tests.

  • bindings/scripts/test/CPP/WebDOMFloat64Array.cpp:
  • bindings/scripts/test/CPP/WebDOMTestActiveDOMObject.cpp:
  • bindings/scripts/test/CPP/WebDOMTestCallback.cpp:
  • bindings/scripts/test/CPP/WebDOMTestCustomNamedGetter.cpp:
  • bindings/scripts/test/CPP/WebDOMTestEventConstructor.cpp:
  • bindings/scripts/test/CPP/WebDOMTestEventTarget.cpp:
  • bindings/scripts/test/CPP/WebDOMTestException.cpp:
  • bindings/scripts/test/CPP/WebDOMTestInterface.cpp:
  • bindings/scripts/test/CPP/WebDOMTestMediaQueryListListener.cpp:
  • bindings/scripts/test/CPP/WebDOMTestNamedConstructor.cpp:
  • bindings/scripts/test/CPP/WebDOMTestNode.cpp:
  • bindings/scripts/test/CPP/WebDOMTestObj.cpp:
  • bindings/scripts/test/CPP/WebDOMTestOverloadedConstructors.cpp:
  • bindings/scripts/test/CPP/WebDOMTestSerializedScriptValueInterface.cpp:
  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::TestObjV8Internal::withScriptStateAttributeAttrGetter):
(WebCore::TestObjV8Internal::withScriptStateAttributeAttrSetter):
(WebCore::TestObjV8Internal::withScriptStateAttributeRaisesAttrGetter):
(WebCore::TestObjV8Internal::withScriptStateAttributeRaisesAttrSetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateAttributeAttrGetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateAttributeAttrSetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateAttributeRaisesAttrGetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateAttributeRaisesAttrSetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateWithSpacesAttributeAttrGetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateWithSpacesAttributeAttrSetter):
(WebCore::TestObjV8Internal::withScriptStateVoidCallback):
(WebCore::TestObjV8Internal::withScriptStateObjCallback):
(WebCore::TestObjV8Internal::withScriptStateVoidExceptionCallback):
(WebCore::TestObjV8Internal::withScriptStateObjExceptionCallback):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateCallback):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateObjExceptionCallback):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateWithSpacesCallback):

10:05 PM Changeset in webkit [135350] by commit-queue@webkit.org
  • 4 edits in trunk

Unreviewed, rolling out r133859.
http://trac.webkit.org/changeset/133859
https://bugs.webkit.org/show_bug.cgi?id=102875

This patch makes API test broken (Requested by gyuyoung on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-11-20

.:

  • Source/cmake/OptionsEfl.cmake:

Tools:

  • Scripts/webkitperl/FeatureList.pm:
9:32 PM Changeset in webkit [135349] by commit-queue@webkit.org
  • 23 edits in trunk/Source/WebKit2

[EFL][WK2] Remove unnecessary #include in API test
https://bugs.webkit.org/show_bug.cgi?id=102674

Patch by Jinwoo Song <jinwoo7.song@samsung.com> on 2012-11-20
Reviewed by Laszlo Gombos.

Removed duplicated header files from the API test cases.
Now, EWK2UnitTestBase.h includes the basic header files,
so test cases may only include this one and add the addtional
header files if necessary.

  • UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.h:
  • UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestEnvironment.h:
  • UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestMain.cpp:
  • UIProcess/API/efl/tests/test_ewk2_auth_request.cpp:
  • UIProcess/API/efl/tests/test_ewk2_back_forward_list.cpp:
  • UIProcess/API/efl/tests/test_ewk2_color_picker.cpp:
  • UIProcess/API/efl/tests/test_ewk2_context.cpp:
  • UIProcess/API/efl/tests/test_ewk2_context_history_callbacks.cpp:
  • UIProcess/API/efl/tests/test_ewk2_cookie_manager.cpp:
  • UIProcess/API/efl/tests/test_ewk2_database_manager.cpp:
  • UIProcess/API/efl/tests/test_ewk2_download_job.cpp:
  • UIProcess/API/efl/tests/test_ewk2_eina_shared_string.cpp:
  • UIProcess/API/efl/tests/test_ewk2_favicon_database.cpp:
  • UIProcess/API/efl/tests/test_ewk2_file_chooser_request.cpp:
  • UIProcess/API/efl/tests/test_ewk2_intents.cpp:
  • UIProcess/API/efl/tests/test_ewk2_object.cpp:
  • UIProcess/API/efl/tests/test_ewk2_popup_menu.cpp:
  • UIProcess/API/efl/tests/test_ewk2_refptr_evas_object.cpp:
  • UIProcess/API/efl/tests/test_ewk2_settings.cpp:
  • UIProcess/API/efl/tests/test_ewk2_storage_manager.cpp:
  • UIProcess/API/efl/tests/test_ewk2_text_checker.cpp:
  • UIProcess/API/efl/tests/test_ewk2_view.cpp:
9:26 PM Changeset in webkit [135348] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

[EFL][WK2][WTR] Unskip passed cases under css3/device-adapt/opera/
https://bugs.webkit.org/show_bug.cgi?id=102868

Unreviewed, EFL gardening.

As BUG 102517 has been resolved, we can move those from EFL common to WK1 only.

Patch by Kangil Han <kangil.han@samsung.com> on 2012-11-20

  • platform/efl-wk1/TestExpectations:
  • platform/efl/TestExpectations:
9:23 PM Changeset in webkit [135347] by weinig@apple.com
  • 11 edits in trunk/Source/WebKit2

Simplify WebConnection by removing its underlying CoreIPC::Connection
https://bugs.webkit.org/show_bug.cgi?id=102771

Reviewed by Anders Carlsson.

Instead of having WebConnection subclasses own the CoreIPC::Connection,
move back to having the WebProcess and WebProcessProxy own it (and be
its Connection::Client) and use the new MessageReceiver class to vend
messages to the WebConnection.

  • Shared/WebConnection.cpp:

(WebKit::WebConnection::WebConnection):
(WebKit::WebConnection::postMessage):
(WebKit::WebConnection::didClose):
(WebKit::WebConnection::didReceiveMessage):

  • Shared/WebConnection.h:

Make WebConnection both a MessageReceiver and MessageSender
and add virtual functions for derived classes to fill in.

  • UIProcess/WebConnectionToWebProcess.cpp:

(WebKit::WebConnectionToWebProcess::create):
(WebKit::WebConnectionToWebProcess::WebConnectionToWebProcess):
(WebKit::WebConnectionToWebProcess::invalidate):
(WebKit::WebConnectionToWebProcess::decodeMessageBody):
(WebKit::WebConnectionToWebProcess::connection):
(WebKit::WebConnectionToWebProcess::destinationID):
(WebKit::WebConnectionToWebProcess::hasValidConnection):

  • UIProcess/WebConnectionToWebProcess.h:
  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::~WebProcessProxy):
(WebKit::WebProcessProxy::fromConnection):
(WebKit::WebProcessProxy::disconnect):
(WebKit::WebProcessProxy::addMessageReceiver):
(WebKit::WebProcessProxy::didClose):
(WebKit::WebProcessProxy::didReceiveInvalidMessage):
(WebKit::WebProcessProxy::didFinishLaunching):

  • UIProcess/WebProcessProxy.h:

(WebKit::WebProcessProxy::connection):
(WebProcessProxy):
(WebKit::WebProcessProxy::webConnection):

  • WebProcess/WebConnectionToUIProcess.cpp:

(WebKit::WebConnectionToUIProcess::create):
(WebKit::WebConnectionToUIProcess::WebConnectionToUIProcess):
(WebKit):
(WebKit::WebConnectionToUIProcess::invalidate):
(WebKit::WebConnectionToUIProcess::connection):
(WebKit::WebConnectionToUIProcess::destinationID):
(WebKit::WebConnectionToUIProcess::hasValidConnection):

  • WebProcess/WebConnectionToUIProcess.h:

(WebConnectionToUIProcess):

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::initialize):
(WebKit::WebProcess::terminate):

  • WebProcess/WebProcess.h:

(WebKit::WebProcess::connection):
(WebKit::WebProcess::webConnectionToUIProcess):
Move the CoreIPC::Connection back to the processes.

9:02 PM Changeset in webkit [135346] by haraken@chromium.org
  • 14 edits in trunk

[V8] Introduce constructorCallbackCustom()
https://bugs.webkit.org/show_bug.cgi?id=102763

Reviewed by Adam Barth.

Source/WebCore:

Currently custom constructors have the following code:

v8::Handle<v8::Value> V8XXX::constructorCallback(const v8::Arguments& args) {

INC_STATS("DOM.XXX.Constructor");
if (!args.IsConstructCall())

return throwTypeError("DOM object constructor cannot be called as a function.", args.GetIsolate());

if (ConstructorMode::current() == ConstructorMode::WrapExistingObject)

return args.Holder();

/* body of the constructor */;

}

To avoid duplicating the same logic in all custom constructors,
this patch changes the generated code as follows:

Generated automatically
v8::Handle<v8::Value> V8XXX::constructorCallback(const v8::Arguments& args) {

INC_STATS("DOM.XXX.Constructor");
${maybeObserveFeature} Newly supported for custom constructors.
if (!args.IsConstructCall())

return throwTypeError("DOM object constructor cannot be called as a function.", args.GetIsolate());

if (ConstructorMode::current() == ConstructorMode::WrapExistingObject)

return args.Holder();

V8XXX::constructorCallbackCustom(args);

}

Written manually
v8::Handle<v8::Value> V8XXX::constructorCallback(const v8::Arguments& args) {

/* body of the constructor */;

}

No tests. No change in behavior.

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateHeader):
(HasCustomConstructor):
(GenerateCustomConstructorCallback):
(GenerateImplementation):

  • bindings/scripts/test/V8/V8TestEventConstructor.cpp:

(WebCore::V8TestEventConstructor::constructorCallback):

  • bindings/scripts/test/V8/V8TestNamedConstructor.cpp:

(WebCore::V8TestNamedConstructorConstructorCallback):

  • bindings/scripts/test/V8/V8TestOverloadedConstructors.cpp:

(WebCore::V8TestOverloadedConstructors::constructorCallback):

  • bindings/v8/custom/V8ArrayBufferCustom.cpp:

(WebCore::V8ArrayBuffer::constructorCallbackCustom):

  • bindings/v8/custom/V8AudioContextCustom.cpp:

(WebCore::V8AudioContext::constructorCallbackCustom):

  • bindings/v8/custom/V8BlobCustom.cpp:

(WebCore::V8Blob::constructorCallbackCustom):

  • bindings/v8/custom/V8DOMFormDataCustom.cpp:

(WebCore::V8DOMFormData::constructorCallbackCustom):

  • bindings/v8/custom/V8DataViewCustom.cpp:

(WebCore::V8DataView::constructorCallbackCustom):

  • bindings/v8/custom/V8IntentConstructor.cpp:

(WebCore::V8Intent::constructorCallbackCustom):

  • bindings/v8/custom/V8MessageChannelConstructor.cpp:

(WebCore::V8MessageChannel::constructorCallbackCustom):

  • bindings/v8/custom/V8MutationObserverCustom.cpp:

(WebCore::V8MutationObserver::constructorCallbackCustom):

  • bindings/v8/custom/V8WebKitPointConstructor.cpp:

(WebCore::V8WebKitPoint::constructorCallbackCustom):

  • bindings/v8/custom/V8XMLHttpRequestConstructor.cpp:

(WebCore::V8XMLHttpRequest::constructorCallbackCustom):

LayoutTests:

Updated a test result.

  • platform/chromium/fast/dom/call-a-constructor-as-a-function-expected.txt:
8:54 PM Changeset in webkit [135345] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

REGRESSION(r135263): Fix a wrong argument for udat_close
https://bugs.webkit.org/show_bug.cgi?id=102856

Patch by Kunihiko Sakamoto <ksakamoto@chromium.org> on 2012-11-20
Reviewed by Kent Tamura.

Fixed a bug that passed wrong pointer to udat_close.

No new tests. No changes in behavior.

  • platform/text/LocaleICU.cpp:

(WebCore::LocaleICU::initializeDateTimeFormat): Close correct object.

7:58 PM Changeset in webkit [135344] by gyuyoung.kim@samsung.com
  • 2 edits in trunk/Websites/webkit.org

Add Samsung to security vendor member list
https://bugs.webkit.org/show_bug.cgi?id=102863

Reviewed by Sam Weinig.

  • security/security-group-members.html: Add Samsung members.
7:21 PM Changeset in webkit [135343] by commit-queue@webkit.org
  • 11 edits
    4 adds in trunk

[EFL][WK2] Add Ewk_Window_Features API and related UI callbacks
https://bugs.webkit.org/show_bug.cgi?id=99114

Patch by Jinwoo Song <jinwoo7.song@samsung.com> on 2012-11-20
Reviewed by Gyuyoung Kim.

Source/WebKit2:

Added Ewk_Window_Features API so that we can create new windows
with various window features such as location, size, toolbar, menubar,
statusbar, locationbar, scrollbar, resizable, and fullscreen.

UI client callbacks related to window features also implemented
so that it is possible to retrieve the window object property values.

  • PlatformEfl.cmake:
  • UIProcess/API/efl/EWebKit2.h:
  • UIProcess/API/efl/EwkViewCallbacks.h:

(EwkViewCallbacks):

  • UIProcess/API/efl/EwkViewImpl.cpp:

(EwkViewImpl::windowFeatures):
(EwkViewImpl::createNewPage):
(EwkViewImpl::closePage):

  • UIProcess/API/efl/EwkViewImpl.h:

(EwkViewImpl):

  • UIProcess/API/efl/ewk_view.h:
  • UIProcess/efl/PageUIClientEfl.cpp:

(WebKit::PageUIClientEfl::createNewPage):
(WebKit::PageUIClientEfl::toolbarsAreVisible):
(WebKit):
(WebKit::PageUIClientEfl::setToolbarsAreVisible):
(WebKit::PageUIClientEfl::menuBarIsVisible):
(WebKit::PageUIClientEfl::setMenuBarIsVisible):
(WebKit::PageUIClientEfl::statusBarIsVisible):
(WebKit::PageUIClientEfl::setStatusBarIsVisible):
(WebKit::PageUIClientEfl::isResizable):
(WebKit::PageUIClientEfl::setIsResizable):
(WebKit::PageUIClientEfl::PageUIClientEfl):

  • UIProcess/efl/PageUIClientEfl.h:

(PageUIClientEfl):

Tools:

Implemented window_create and window_close smartcallback functions.

  • MiniBrowser/efl/main.c:

(on_window_create):
(on_window_close):
(window_create):

7:13 PM Changeset in webkit [135342] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

[Chromium] Need spellcheck suggestions even if continuous check is off.
https://bugs.webkit.org/show_bug.cgi?id=102535

Patch by Rachel Blum <groby@chromium.org> on 2012-11-20
Reviewed by Hajime Morita.

Make sure the context menu always has suggestions for misspelled words.

  • src/ContextMenuClientImpl.cpp:

(WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems):

6:34 PM Changeset in webkit [135341] by fpizlo@apple.com
  • 3 edits in trunk/Source/WTF

DFG should be able to cache closure calls
https://bugs.webkit.org/show_bug.cgi?id=102662

Reviewed by Gavin Barraclough.

Added support to the meta allocator for easily querying whether an address falls within
a certain allocated chunk. Also added a useful debug routine to SentinelLinkedList,
which can be used to check if a node is on a particular list.

  • wtf/MetaAllocatorHandle.h:

(MetaAllocatorHandle):
(WTF::MetaAllocatorHandle::containsIntegerAddress):
(WTF::MetaAllocatorHandle::contains):

  • wtf/SentinelLinkedList.h:

(SentinelLinkedList):
(WTF::::isOnList):
(WTF):

6:32 PM Changeset in webkit [135340] by haraken@chromium.org
  • 8 edits in trunk

Remove $outputDir and $outputHeadersDir from global variables of code generators
https://bugs.webkit.org/show_bug.cgi?id=102492

Reviewed by Adam Barth.

$outputDir and $outputHeadersDir are used in WriteData() only.
We don't need to use global variables for them.

No tests. No change in behavior.

  • bindings/scripts/CodeGenerator.pm:

(ProcessDocument):
(FileNamePrefix):

  • bindings/scripts/CodeGeneratorCPP.pm:

(new):
(GenerateInterface):
(WriteData):

  • bindings/scripts/CodeGeneratorGObject.pm:

(new):
(WriteData):
(GenerateInterface):

  • bindings/scripts/CodeGeneratorJS.pm:

(new):
(GenerateInterface):
(WriteData):

  • bindings/scripts/CodeGeneratorObjC.pm:

(new):
(GenerateInterface):
(WriteData):

  • bindings/scripts/CodeGeneratorV8.pm:

(new):
(GenerateInterface):
(WriteData):

6:15 PM Changeset in webkit [135339] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

7% regression in dromaeo_domcorequery/dom_query_getElementsByTagNamenot_in_document
https://bugs.webkit.org/show_bug.cgi?id=102852

Reviewed by Kentaro Hara.

In http://trac.webkit.org/changeset/135208/, we lost the early-exit
check for whether isolatedWorldsExist() in this code path. This
regression points to benchmarks that we can further improve by
continuing to merge the general ScriptWrappable code path with the Node
code path.

  • bindings/v8/DOMDataStore.cpp:

(WebCore::DOMDataStore::current):

5:58 PM Changeset in webkit [135338] by haraken@chromium.org
  • 3 edits in trunk/Source/WebCore

[V8] Change a return type of V8Parameter::prepare() from bool to void
https://bugs.webkit.org/show_bug.cgi?id=102805

Reviewed by Adam Barth.

This is an incremental step for V8Parameter refactoring.

V8Parameter::prepare() is always called just after V8Parameter's
constructor. So I want to move the logic of V8Parameter::prepare()
to V8Parameter's constructor. In preparation for that (i.e. because
a constructor cannot return any value), this patch changes the return
type of V8Parameter::prepare() from bool to void.

Tests: fast/workers/worker-constructor.html

storage/websql/sql-error-codes.html
inspector/console/alert-toString-exception.html
http/tests/websocket/tests/hybi/send-throw.html
etc

  • bindings/v8/V8BindingMacros.h:
  • bindings/v8/V8StringResource.h:

(V8Parameter):
(WebCore::V8Parameter::prepareBase): This patch removes a TryCatch block.
This change is safe because (1) all V8Parameter::prepareBase() in the code base
is called inside STRING_TO_V8PARAMETER_EXCEPTION_BLOCK(), and because
(2) STRING_TO_V8PARAMETER_EXCEPTION_BLOCK() has a TryCatch block.
(Note: In a follow-up patch I'm planning to refactor the macros.)
(WebCore::::prepare): I will remove this method shortly.

5:35 PM Changeset in webkit [135337] by adamk@chromium.org
  • 10 edits in trunk

[JSC] MutationObserver wrapper should not be collected while still observing
https://bugs.webkit.org/show_bug.cgi?id=102744

Reviewed by Adam Barth.

Source/WebCore:

This is the JSC side of the change landed for V8 in r135228.
It ensures MutationObserver wrapper objects are kept alive as long as
any observed nodes.

  • bindings/js/JSMutationObserverCustom.cpp:

(WebCore::JSMutationObserverOwner::isReachableFromOpaqueRoots): Keep MutationObserver wrappers alive
if any of their observed nodes' roots is an opaque root.

  • dom/MutationObserver.idl: Add JSCustomIsReachable

LayoutTests:

Remove suppressions for wrapper dropoff tests.

  • platform/efl/TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/mac/TestExpectations:
  • platform/qt/TestExpectations:
  • platform/win/TestExpectations:
  • platform/wincairo/TestExpectations:
5:29 PM Changeset in webkit [135336] by fpizlo@apple.com
  • 25 edits
    2 adds in trunk/Source/JavaScriptCore

DFG should be able to cache closure calls (part 2/2)
https://bugs.webkit.org/show_bug.cgi?id=102662

Reviewed by Gavin Barraclough.

Added caching of calls where the JSFunction* varies, but the Structure* and ExecutableBase*
stay the same. This is accomplished by replacing the branch that compares against a constant
JSFunction* with a jump to a closure call stub. The closure call stub contains a fast path,
and jumps slow directly to the virtual call thunk.

Looks like a 1% win on V8v7.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • Target.pri:
  • bytecode/CallLinkInfo.cpp:

(JSC::CallLinkInfo::unlink):

  • bytecode/CallLinkInfo.h:

(CallLinkInfo):
(JSC::CallLinkInfo::isLinked):
(JSC::getCallLinkInfoBytecodeIndex):

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::finalizeUnconditionally):
(JSC):
(JSC::CodeBlock::findClosureCallForReturnPC):
(JSC::CodeBlock::bytecodeOffset):
(JSC::CodeBlock::codeOriginForReturn):

  • bytecode/CodeBlock.h:

(JSC::CodeBlock::getCallLinkInfo):
(CodeBlock):
(JSC::CodeBlock::isIncomingCallAlreadyLinked):

  • dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::link):

  • dfg/DFGJITCompiler.h:

(JSC::DFG::JITCompiler::addJSCall):
(JSC::DFG::JITCompiler::JSCallRecord::JSCallRecord):
(JSCallRecord):

  • dfg/DFGOperations.cpp:
  • dfg/DFGOperations.h:
  • dfg/DFGRepatch.cpp:

(JSC::DFG::linkSlowFor):
(DFG):
(JSC::DFG::dfgLinkFor):
(JSC::DFG::dfgLinkSlowFor):
(JSC::DFG::dfgLinkClosureCall):

  • dfg/DFGRepatch.h:

(DFG):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::emitCall):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::emitCall):

  • dfg/DFGThunks.cpp:

(DFG):
(JSC::DFG::linkClosureCallThunkGenerator):

  • dfg/DFGThunks.h:

(DFG):

  • heap/Heap.h:

(Heap):
(JSC::Heap::jitStubRoutines):

  • heap/JITStubRoutineSet.h:

(JSC::JITStubRoutineSet::size):
(JSC::JITStubRoutineSet::at):
(JITStubRoutineSet):

  • jit/ClosureCallStubRoutine.cpp: Added.

(JSC):
(JSC::ClosureCallStubRoutine::ClosureCallStubRoutine):
(JSC::ClosureCallStubRoutine::~ClosureCallStubRoutine):
(JSC::ClosureCallStubRoutine::markRequiredObjectsInternal):

  • jit/ClosureCallStubRoutine.h: Added.

(JSC):
(ClosureCallStubRoutine):
(JSC::ClosureCallStubRoutine::structure):
(JSC::ClosureCallStubRoutine::executable):
(JSC::ClosureCallStubRoutine::codeOrigin):

  • jit/GCAwareJITStubRoutine.cpp:

(JSC::GCAwareJITStubRoutine::GCAwareJITStubRoutine):

  • jit/GCAwareJITStubRoutine.h:

(GCAwareJITStubRoutine):
(JSC::GCAwareJITStubRoutine::isClosureCall):

  • jit/JIT.cpp:

(JSC::JIT::privateCompile):

5:11 PM Changeset in webkit [135335] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

REGRESSION(r131106): magnitude-perf.js calls bind on undefined
https://bugs.webkit.org/show_bug.cgi?id=102848

Reviewed by Tony Gentilcore.

Check the existence of performance.now before calling bind on it.

  • resources/magnitude-perf.js:

(Magnitude._runIteration):

4:45 PM Changeset in webkit [135334] by ojan@chromium.org
  • 3 edits in trunk/Tools

Simplify builder filters now that we have lists of which builders run which tests
https://bugs.webkit.org/show_bug.cgi?id=102849

Reviewed by Dirk Pranke.

We only need filters when we load the same master for multiple groups in the
same test type, i.e. when we need to only include some of the builders that run
a given test suite on a given master.

Also, get rid of the DEFAULT_BUILDER enum. We were always using the first builder anyways.
Now just make it a method on BuilderGroup.

  • TestResultServer/static-dashboards/builders.js:

(BuilderGroup.prototype.append):
(BuilderGroup.prototype.setup):
(BuilderGroup.prototype._defaultBuilder):
(BuilderGroup.prototype.master):
(requestBuilderList):
(isChromiumWebkitTipOfTreeTestRunner):
(isChromiumWebkitDepsTestRunner):
(loadBuildersList):

  • TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:

(test):

4:45 PM Changeset in webkit [135333] by dgrogan@chromium.org
  • 5 edits in trunk/LayoutTests

IndexedDB: remove setVersion from pending-version-change-on-exit.html
https://bugs.webkit.org/show_bug.cgi?id=102457

Reviewed by Tony Chang.

This test doesn't work in single-process mode because of
http://wkb.ug/82776. We run it in content_shell in chromium.

  • platform/chromium/TestExpectations:
  • storage/indexeddb/pending-version-change-on-exit-expected.txt:
  • storage/indexeddb/pending-version-change-on-exit.html:
  • storage/indexeddb/resources/pending-version-change-on-exit.js:

(request.onblocked):

4:35 PM Changeset in webkit [135332] by jsbell@chromium.org
  • 6 edits in trunk/Source/WebCore

IndexedDB: Move control of transaction completion to front end
https://bugs.webkit.org/show_bug.cgi?id=100903

Reviewed by Tony Chang.

"When a transaction can no longer become active, the implementation must attempt to
commit it" - that is, all requests have dispatched success/error events and no further
requests have been made. Previously, this was done by the back end waiting for events
from the front end, but the front end can more efficiently make the decision.

There should be no detectable behavior change.

Tests: storage/indexeddb/transaction-*.html

  • Modules/indexeddb/IDBTransaction.cpp:

(WebCore::IDBTransaction::IDBTransaction):
(WebCore::IDBTransaction::setActive):
(WebCore::IDBTransaction::registerRequest):

  • Modules/indexeddb/IDBTransaction.h:
  • Modules/indexeddb/IDBTransactionBackendImpl.cpp:

(WebCore::IDBTransactionBackendImpl::hasPendingTasks): Added.
(WebCore::IDBTransactionBackendImpl::didCompleteTaskEvents):
(WebCore::IDBTransactionBackendImpl::run):
(WebCore::IDBTransactionBackendImpl::taskEventTimerFired):

4:27 PM Changeset in webkit [135331] by ojan@chromium.org
  • 2 edits in trunk/Tools

Remove perfav master for webkit_unit_tests and test_shell_tests.
There are no bots on this master that run these tests.

  • TestResultServer/static-dashboards/builders.js:
4:22 PM Changeset in webkit [135330] by fpizlo@apple.com
  • 9 edits in trunk/Source/JavaScriptCore

DFG should be able to cache closure calls (part 1/2)
https://bugs.webkit.org/show_bug.cgi?id=102662

Reviewed by Gavin Barraclough.

Add ability to revert a jump replacement back to
branchPtrWithPatch(Condition, RegisterID, TrustedImmPtr). This is meant to be
a mandatory piece of functionality for all assemblers. I also renamed some of
the functions for reverting jump replacements back to
patchableBranchPtrWithPatch(Condition, Address, TrustedImmPtr), so as to avoid
confusion.

  • assembler/ARMv7Assembler.h:

(JSC::ARMv7Assembler::BadReg):
(ARMv7Assembler):
(JSC::ARMv7Assembler::revertJumpTo_movT3):

  • assembler/LinkBuffer.h:

(JSC):

  • assembler/MacroAssemblerARMv7.h:

(JSC::MacroAssemblerARMv7::startOfBranchPtrWithPatchOnRegister):
(MacroAssemblerARMv7):
(JSC::MacroAssemblerARMv7::revertJumpReplacementToBranchPtrWithPatch):
(JSC::MacroAssemblerARMv7::startOfPatchableBranchPtrWithPatchOnAddress):

  • assembler/MacroAssemblerX86.h:

(JSC::MacroAssemblerX86::startOfBranchPtrWithPatchOnRegister):
(MacroAssemblerX86):
(JSC::MacroAssemblerX86::startOfPatchableBranchPtrWithPatchOnAddress):
(JSC::MacroAssemblerX86::revertJumpReplacementToBranchPtrWithPatch):

  • assembler/MacroAssemblerX86_64.h:

(JSC::MacroAssemblerX86_64::startOfBranchPtrWithPatchOnRegister):
(JSC::MacroAssemblerX86_64::startOfPatchableBranchPtrWithPatchOnAddress):
(MacroAssemblerX86_64):
(JSC::MacroAssemblerX86_64::revertJumpReplacementToBranchPtrWithPatch):

  • assembler/RepatchBuffer.h:

(JSC::RepatchBuffer::startOfBranchPtrWithPatchOnRegister):
(RepatchBuffer):
(JSC::RepatchBuffer::startOfPatchableBranchPtrWithPatchOnAddress):
(JSC::RepatchBuffer::revertJumpReplacementToBranchPtrWithPatch):

  • assembler/X86Assembler.h:

(JSC::X86Assembler::revertJumpTo_cmpl_ir_force32):
(X86Assembler):

  • dfg/DFGRepatch.cpp:

(JSC::DFG::replaceWithJump):
(JSC::DFG::dfgResetGetByID):
(JSC::DFG::dfgResetPutByID):

4:20 PM Changeset in webkit [135329] by haraken@chromium.org
  • 4 edits in trunk/Source/WebCore

Unreviewed. Rebaselined run-bindings-tests results.

  • bindings/scripts/test/V8/V8TestEventConstructor.cpp:

(WebCore::V8TestEventConstructor::constructorCallback):

  • bindings/scripts/test/V8/V8TestNamedConstructor.cpp:

(WebCore::V8TestNamedConstructorConstructorCallback):

  • bindings/scripts/test/V8/V8TestOverloadedConstructors.cpp:

(WebCore::V8TestOverloadedConstructors::constructorCallback):

4:12 PM Changeset in webkit [135328] by hclam@chromium.org
  • 2 edits in trunk/Source/WebCore

Unreviewed. Chromium build fix.

Removed unnecessary mutex unlock that triggered crash on Linux debug build.

Chromium Linux Debug layout tests should be green:
platform/chromium/virtual/deferred/fast/images/image-in-map.html

  • platform/graphics/chromium/LazyDecodingPixelRef.cpp:

(WebCore::LazyDecodingPixelRef::onLockPixels):

4:07 PM Changeset in webkit [135327] by rniwa@webkit.org
  • 3 edits in trunk/Source/WebCore

Fix another typo. I need to checking that type() != NodeListCollectionType,
not that type() >= FirstNodeCollectionType.

  • dom/DynamicNodeList.cpp:

(WebCore::DynamicNodeListCacheBase::invalidateIdNameCacheMaps):

  • dom/DynamicNodeList.h:

(WebCore::DynamicNodeListCacheBase::invalidateCache):

3:56 PM Changeset in webkit [135326] by ojan@chromium.org
  • 3 edits in trunk/Tools

Remove special case for layout tests when builders fail to load
https://bugs.webkit.org/show_bug.cgi?id=102842

Reviewed by Tony Chang.

Now that we load only builders that actually run the given test
type, we can reliably show errors to the users because it
represents a broken bot.

  • TestResultServer/static-dashboards/loader.js:
3:50 PM Changeset in webkit [135325] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

[V8] Pass ScriptState::current() to functions marked with CallWith=ScriptState
https://bugs.webkit.org/show_bug.cgi?id=102739

Patch by Michael Pruett <michael@68k.org> on 2012-11-20
Reviewed by Kentaro Hara.

Previously EmptyScriptState rather than ScriptState::current()
was passed to functions marked with [CallWith=ScriptState].
Since the EmptyScriptState has a null v8::Context, any functions
which depended upon a valid v8::Context would fail.

No new tests. Covered by existing tests.

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateNormalAttrGetter):
(GenerateNormalAttrSetter):
(GenerateCallWith):
(GenerateFunctionCallString):

  • bindings/v8/ScriptState.h:

(WebCore::ScriptState::clearException): Added.

3:47 PM Changeset in webkit [135324] by bfulgham@webkit.org
  • 2 edits in trunk/Source/WebCore

[Qt] Build fix after r135217.
https://bugs.webkit.org/show_bug.cgi?id=102787

  • platform/win/WindowsExtras.h: Switch to direct include of <ObjBase.h>, as is done in other <shlwapi.h> includes.
3:45 PM Changeset in webkit [135323] by rniwa@webkit.org
  • 3 edits in trunk/Source/WebCore

Fix typos. Apparently XCode failed to text-replace earlier when it was busy making a snapshot :(

  • dom/DynamicNodeList.cpp:

(WebCore::DynamicNodeListCacheBase::invalidateIdNameCacheMaps):

  • dom/DynamicNodeList.h:

(WebCore::DynamicNodeListCacheBase::invalidateCache):
(DynamicNodeListCacheBase):

3:42 PM Changeset in webkit [135322] by haraken@chromium.org
  • 2 edits in trunk/Source/WebCore

[V8] Introduce GenerateConstructorHeader() to CodeGeneratorV8.pm
https://bugs.webkit.org/show_bug.cgi?id=102806

Reviewed by Adam Barth.

This is an incremental step for introducing constructorCallbackCustom().
(See bug 102763.) This patch adds GenerateConstructorHeader()
that generates a common code for constructors.

No tests. No change in behavior.

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateOverloadedConstructorCallback):
(GenerateSingleConstructorCallback):
(GenerateEventConstructorCallback):
(GenerateNamedConstructorCallback):
(GenerateConstructorHeader):

3:40 PM Changeset in webkit [135321] by rniwa@webkit.org
  • 5 edits in trunk/Source/WebCore

HTMLCollection's cache should not be invalidated when id or name attributes are changed
https://bugs.webkit.org/show_bug.cgi?id=102843

Reviewed by Eric Seidel.

When an id or name attribute changes, only invaliate id and name cache maps when the collection
doesn't depend on id and name attributes (e.g. document.images).

Unfortunately, I could not create a reliable test for this performance problem.

  • dom/DynamicNodeList.cpp:

(WebCore::DynamicNodeListCacheBase::invalidateIdNameCacheMaps):

  • dom/DynamicNodeList.h:

(WebCore::DynamicNodeListCacheBase::invalidateCache):
(DynamicNodeListCacheBase):

  • dom/ElementRareData.h:

(WebCore::ElementRareData::clearHTMLCollectionCaches):

  • html/HTMLCollection.cpp:

(WebCore::invalidationTypeExcludingIdAndNameAttributes):

3:38 PM Changeset in webkit [135320] by adamk@chromium.org
  • 3 edits in trunk/Source/WebCore

[v8] Avoid unnecessary call to ToObject() in Callback constructors
https://bugs.webkit.org/show_bug.cgi?id=102831

Reviewed by Adam Barth.

The code already asserted that the argument was an object, so calling
ToObject() is unnecessary: a simple Cast() suffices.

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateCallbackHeader):

  • bindings/scripts/test/V8/V8TestCallback.h:

(WebCore::V8TestCallback::create):

3:34 PM Changeset in webkit [135319] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Animated gifs pause on scroll or zoom and sometimes don't resume after scroll or zoom completes
https://bugs.webkit.org/show_bug.cgi?id=102838

Patch by Andrew Lo <anlo@rim.com> on 2012-11-20
Reviewed by Rob Buis.

Internally reviewed by Adam Treat.
Internal PR244646
When entering scrolling & zooming, we suspend regular render jobs
in order to pause animations. When finishing scrolling or zooming,
dispatch a render job in order to resume those animations.

If an animation requests a repaint while the backing store is suspended,
add the regular render job to the render queue so that it can be
processed later.

  • Api/BackingStore.cpp:

(BlackBerry::WebKit::BackingStorePrivate::repaint):
(BlackBerry::WebKit::BackingStorePrivate::setScrollingOrZooming):

3:27 PM Changeset in webkit [135318] by rjkroege@chromium.org
  • 5 edits in trunk/Source/WebKit/chromium

[chromium] Use embedder-supported gesture curves
https://bugs.webkit.org/show_bug.cgi?id=100884

Reviewed by James Robinson.

Use embedder-provided gesture animation curves via WebKit api interfaces.
Tested by existing tests.

  • src/WebCompositorInputHandlerImpl.cpp:

(WebKit::WebCompositorInputHandlerImpl::handleGestureFling):
(WebKit::WebCompositorInputHandlerImpl::scrollBy):

  • src/WebCompositorInputHandlerImpl.h:

(WebCompositorInputHandlerImpl):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::scrollBy):
(WebKit::WebViewImpl::handleGestureEvent):
(WebKit::WebViewImpl::transferActiveWheelFlingAnimation):

  • src/WebViewImpl.h:

(WebCore):
(WebKit):
(WebViewImpl):

2:54 PM Changeset in webkit [135317] by bfulgham@webkit.org
  • 2 edits in trunk/Source/WebCore

[WinCairo] Build fix after r135316

  • platform/network/curl/AuthenticationChallenge.h: Update stub implementations to match Apple Windows port.

(WebCore::AuthenticationChallenge::AuthenticationChallenge): Add

missing identifier argument.

(WebCore::AuthenticationChallenge::setAuthenticationClient): Supply

missing set method.

2:50 PM Changeset in webkit [135316] by tony@chromium.org
  • 4 edits in trunk/Source

When calling DocumentStyleSheetCollection::addUserSheet, pass in a user sheet
https://bugs.webkit.org/show_bug.cgi?id=102835

Reviewed by Ojan Vafai.

After r135082, Chromium browser_tests were triggering the ASSERT in
StyleResolver::collectRulesFromUserStyleSheets. Add an ASSERT that will
trigger earlier and make it clear in the Chromium code that we're always
inserting user level styles.

Source/WebCore:

No new tests, no behavior change except no longer triggering the StyleResolver ASSERT
in Chromium browser_tests.

  • dom/DocumentStyleSheetCollection.cpp:

(WebCore::DocumentStyleSheetCollection::addUserSheet):

Source/WebKit/chromium:

  • src/WebDocument.cpp:

(WebKit::WebDocument::insertUserStyleSheet):

2:41 PM Changeset in webkit [135315] by commit-queue@webkit.org
  • 9 edits
    4 adds in trunk/Source/WebKit/chromium

Provide page/window coordinates to plugin's local coordinates translation in WebPluginContainer.
https://bugs.webkit.org/show_bug.cgi?id=102339

Patch by Istiaque Ahmed <lazyboy@chromium.org> on 2012-11-20
Reviewed by Adam Barth.

This change will allow converting a page's window coordinates to plugins's local coordinates,
taking CSS transformations into account. Embedder page of the plugin can use this information
for targetting elements inside the plugin (e.g. devtools can inspect a specific element at the
local coordinate position inside plugin).

  • WebKit.gyp:
  • WebKit.gypi:
  • public/WebNode.h:

(WebKit):

  • public/WebPluginContainer.h:

(WebKit):
(WebPluginContainer):

  • src/WebFrameImpl.cpp:

(WebKit::WebFrameImpl::executeCommand):
(WebKit::WebFrameImpl::printBegin):
(WebKit::WebFrameImpl::isPrintScalingDisabledForPlugin):

  • src/WebNode.cpp:

(WebKit::WebNode::pluginContainer):
(WebKit):

  • src/WebPluginContainerImpl.cpp:

(WebKit::WebPluginContainerImpl::windowToLocalPoint):
(WebKit):

  • src/WebPluginContainerImpl.h:

(WebPluginContainerImpl):

  • tests/FakeWebPlugin.cpp: Added.

(WebKit):
(WebKit::FakeWebPlugin::FakeWebPlugin):
(WebKit::FakeWebPlugin::~FakeWebPlugin):
(WebKit::FakeWebPlugin::initialize):
(WebKit::FakeWebPlugin::destroy):

  • tests/FakeWebPlugin.h: Added.

(WebKit):
(FakeWebPlugin):

  • tests/WebPluginContainerTest.cpp: Added.

(WebKit):
(WebPluginContainerTest):
(WebKit::WebPluginContainerTest::WebPluginContainerTest):
(WebKit::WebPluginContainerTest::TearDown):
(WebKit::getWebPluginContainer):
(WebKit::TEST_F):

  • tests/data/plugin_container.html: Added.
2:39 PM Changeset in webkit [135314] by commit-queue@webkit.org
  • 21 edits
    1 add in trunk

[CSS Exclusions] Support outside-shape value on shape-inside
https://bugs.webkit.org/show_bug.cgi?id=101108

Patch by Bear Travis <betravis@adobe.com> on 2012-11-20
Reviewed by Dirk Schulze.

Source/WebCore:

Shape-inside can potentially be: 'auto' | 'outside-shape' | <shape> | <url>.
Webkit currently supports the value 'auto' (null) and <shape> (a BasicShape*).
This patch adds support for the value 'outside-shape.' It adds the ExclusionShapeValue
class, which may be any of the three values: 'auto', 'outside-shape', or <shape>.
Bug 102738 tracks adding <url> support.

Modifying existing tests:
LayoutTests/fast/exclusions/parsing-wrap-shape-inside.html
LayoutTests/fast/exclusions/parsing-wrap-shape-outside.html

  • GNUmakefile.list.am: Adding ExclusionShapeValue.h to the build files.
  • Target.pri: Ditto.
  • WebCore.gypi: Ditto.
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.

(WebCore):

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Modifying code to use
ExclusionShapeValue* rather than the previous BasicShape* values.

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue): Handle the outside-shape value.

  • css/CSSValueKeywords.in: Adding outside-shape value.
  • css/StyleBuilder.cpp:

(WebCore):
(WebCore::ApplyPropertyExclusionShape::setValue): Modify code to use
ExclusionShapeValue* rather than BasicShape*.
(WebCore::ApplyPropertyExclusionShape::applyValue): Ditto.
(WebCore::ApplyPropertyExclusionShape::createHandler): Ditto.

  • page/animation/CSSPropertyAnimation.cpp: Ditto.

(WebCore::blendFunc): Ditto.
(WebCore::PropertyWrapperExclusionShape::PropertyWrapperExclusionShape): Ditto.
(WebCore::CSSPropertyAnimation::ensurePropertyMap): Ditto.

  • rendering/ExclusionShapeInsideInfo.cpp:

(WebCore::ExclusionShapeInsideInfo::isExclusionShapeInsideInfoEnabledForRenderBlock):
Ditto.
(WebCore::ExclusionShapeInsideInfo::computeShapeSize): Ditto.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::updateExclusionShapeInsideInfoAfterStyleChange): Ditto.

  • rendering/RenderBlock.h:

(RenderBlock):

  • rendering/style/ExclusionShapeValue.h: Added.

(WebCore):
(ExclusionShapeValue): New type to represent the possible values of shape-inside
and shape-outside. Only shape-inside can have a value of 'outside-shape.'
(WebCore::ExclusionShapeValue::~ExclusionShapeValue):
(WebCore::ExclusionShapeValue::type): Returns the value type.
(WebCore::ExclusionShapeValue::shape): Returns <shape> value's BasicShape*.
(WebCore::ExclusionShapeValue::operator==):
(WebCore::ExclusionShapeInfo::createShapeValue):
(WebCore::ExclusionShapeInfo::createOutsideValue):
(WebCore::ExclusionShapeValue::ExclusionShapeValue):

  • rendering/style/RenderStyle.h:
  • rendering/style/StyleRareNonInheritedData.h:

(StyleRareNonInheritedData):

LayoutTests:

Adding tests to make sure the 'outside-shape' value properly applies only to the
shape-inside property.

  • fast/exclusions/parsing-wrap-shape-inside-expected.txt:
  • fast/exclusions/parsing-wrap-shape-outside-expected.txt:
  • fast/exclusions/script-tests/parsing-wrap-shape-inside.js:
  • fast/exclusions/script-tests/parsing-wrap-shape-outside.js:
2:27 PM Changeset in webkit [135313] by hclam@chromium.org
  • 7 edits in trunk/Source

[chromium] Make lazy image decoding thread-safe
https://bugs.webkit.org/show_bug.cgi?id=102721

Reviewed by Stephen White.

Source/WebCore:

Added mutex to LazyDecodingPixelRef such that there is no parallel
onLockPixels() running on multiple threads.

Added mutex to ImageFrameGenerator to protect the use of raw image
data.

The result is that we can decode on threads other than the main
thread while data is being supplied on the main thread.

New unit test:
DeferredImageDecoderTest.decodeOnOtherThread

  • platform/graphics/chromium/ImageFrameGenerator.cpp:

(WebCore::ImageFrameGenerator::setData):
(WebCore::ImageFrameGenerator::decodeAndScale):

  • platform/graphics/chromium/ImageFrameGenerator.h:

(ImageFrameGenerator):

  • platform/graphics/chromium/LazyDecodingPixelRef.cpp:

(WebCore::LazyDecodingPixelRef::onLockPixels):
(WebCore::LazyDecodingPixelRef::onUnlockPixels):

  • platform/graphics/chromium/LazyDecodingPixelRef.h:

(LazyDecodingPixelRef):

Source/WebKit/chromium:

Added a new unit test to verify that lazy image decoding operates
correctly on non-main threads.

  • tests/DeferredImageDecoderTest.cpp:

(Rasterizer):
(WebCore):
(WebCore::rasterizeMain):
(WebCore::TEST_F):

2:25 PM Changeset in webkit [135312] by bfulgham@webkit.org
  • 2 edits in trunk/Source/WebCore

[Qt] Build fix after r135217.
https://bugs.webkit.org/show_bug.cgi?id=102787

  • platform/win/WindowsExtras.h: Add #undef of NOSHLWAPI to

allow include of <ObjBase.h> needed by Qt build.

2:25 PM Changeset in webkit [135311] by jianli@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed. Updated chromium test expectations.

  • platform/chromium/TestExpectations:
2:08 PM Changeset in webkit [135310] by commit-queue@webkit.org
  • 39 edits
    1 delete in trunk/Source

Unreviewed, rolling out r135295.
http://trac.webkit.org/changeset/135295
https://bugs.webkit.org/show_bug.cgi?id=102834

This patch causes assertion to some layout tests on chromium
(Requested by jianli on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-11-20

Source/WebCore:

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.exp.in:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • loader/FrameLoadRequest.cpp: Removed.
  • loader/FrameLoadRequest.h:

(WebCore::FrameLoadRequest::FrameLoadRequest):
(FrameLoadRequest):

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::load):

  • loader/FrameLoader.h:

(FrameLoader):

  • page/DragController.cpp:

(WebCore::DragController::performDrag):

  • plugins/PluginView.cpp:

(WebCore::PluginView::performRequest):

Source/WebKit/blackberry:

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::load):
(BlackBerry::WebKit::WebPagePrivate::loadString):

  • WebCoreSupport/FrameLoaderClientBlackBerry.cpp:

(WebCore::FrameLoaderClientBlackBerry::dispatchDidFailProvisionalLoad):

Source/WebKit/chromium:

  • src/WebFrameImpl.cpp:

(WebKit::WebFrameImpl::loadRequest):
(WebKit::WebFrameImpl::loadData):

  • src/WebSharedWorkerImpl.cpp:

(WebKit::WebSharedWorkerImpl::initializeLoader):

Source/WebKit/efl:

  • ewk/ewk_frame.cpp:

(ewk_frame_uri_set):
(_ewk_frame_contents_set_internal):

Source/WebKit/gtk:

  • webkit/webkitwebframe.cpp:

(webkit_web_frame_load_uri):
(webkit_web_frame_load_data):
(webkit_web_frame_load_request):

Source/WebKit/mac:

  • Plugins/WebPluginController.mm:
  • WebView/WebFrame.mm:

(-[WebFrame loadRequest:]):
(-[WebFrame _loadData:MIMEType:textEncodingName:baseURL:unreachableURL:]):

Source/WebKit/qt:

  • Api/qwebframe.cpp:

(QWebFrame::QWebFrame):
(QWebFrame::load):
(QWebFrame::setHtml):
(QWebFrame::setContent):

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp:

(DumpRenderTreeSupportQt::setAlternateHtml):

  • WebCoreSupport/FrameLoaderClientQt.cpp:

(WebCore::FrameLoaderClientQt::callErrorPageExtension):

Source/WebKit/win:

  • WebFrame.cpp:

(WebFrame::loadRequest):
(WebFrame::loadData):

Source/WebKit/wince:

  • WebView.cpp:

(WebView::load):

Source/WebKit/wx:

  • WebFrame.cpp:

(WebKit::WebFrame::SetPageSource):

Source/WebKit2:

  • WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::performFrameLoadURLRequest):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::loadURLRequest):
(WebKit::WebPage::loadData):
(WebKit::WebPage::linkClicked):

1:47 PM Changeset in webkit [135309] by commit-queue@webkit.org
  • 11 edits in trunk/Source/WebCore

Unreviewed, rolling out r135293.
http://trac.webkit.org/changeset/135293
https://bugs.webkit.org/show_bug.cgi?id=102832

This patch causes crash to some layout tests on chromium
(Requested by jianli on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-11-20

  • bindings/v8/DOMDataStore.cpp:

(WebCore::DOMDataStore::current):

  • bindings/v8/DOMWrapperWorld.cpp:
  • bindings/v8/DOMWrapperWorld.h:
  • bindings/v8/ScriptController.cpp:

(WebCore::ScriptController::existingWindowShell):
(WebCore::ScriptController::windowShell):
(WebCore::ScriptController::evaluateInIsolatedWorld):
(WebCore::ScriptController::currentWorldContext):
(WebCore::ScriptController::collectIsolatedContexts):

  • bindings/v8/ScriptController.h:

(ScriptController):

  • bindings/v8/V8Binding.h:

(WebCore::worldForEnteredContextIfIsolated):

  • bindings/v8/V8DOMWindowShell.cpp:

(WebCore::V8DOMWindowShell::destroyIsolatedShell):
(WebCore):
(WebCore::isolatedContextWeakCallback):
(WebCore::V8DOMWindowShell::disposeContext):
(WebCore::V8DOMWindowShell::initializeIfNeeded):

  • bindings/v8/V8DOMWindowShell.h:

(WebCore::V8DOMWindowShell::isolated):
(V8DOMWindowShell):

  • bindings/v8/V8PerContextData.h:
  • bindings/v8/WorldContextHandle.cpp:

(WebCore::WorldContextHandle::WorldContextHandle):

1:10 PM Changeset in webkit [135308] by dgrogan@chromium.org
  • 12 edits in trunk

IndexedDB: Remove legacy enum-based constants from IDL
https://bugs.webkit.org/show_bug.cgi?id=85315

Reviewed by Adam Barth.

Source/WebCore:

These were only present in an earlier working draft of the spec and have
been removed for 8 months. See
http://lists.w3.org/Archives/Public/public-webapps/2012JanMar/0957.html

Tests - legacy-constants.html

  • Modules/indexeddb/IDBCursor.cpp:

(WebCore::IDBCursor::stringToDirection):

  • Modules/indexeddb/IDBCursor.idl:
  • Modules/indexeddb/IDBTransaction.cpp:

(WebCore::IDBTransaction::stringToMode):

  • Modules/indexeddb/IDBTransaction.idl:

LayoutTests:

  • storage/indexeddb/constants-expected.txt:
  • storage/indexeddb/cursor-overloads-expected.txt:
  • storage/indexeddb/cursor-overloads.html:
  • storage/indexeddb/legacy-constants-expected.txt:
  • storage/indexeddb/resources/constants.js:

(test):

  • storage/indexeddb/resources/legacy-constants.js:

(testObsoleteConstants):

1:00 PM Changeset in webkit [135307] by commit-queue@webkit.org
  • 10 edits
    1 delete in trunk/LayoutTests

animations/stop-animation-on-suspend.html sometimes fails on all platforms
https://bugs.webkit.org/show_bug.cgi?id=49182

Patch by Jussi Kukkonen <jussi.kukkonen@intel.com> on 2012-11-20
Reviewed by Antti Koivisto.

stop-animation-on-suspend incorrectly assumed that animation in a subframe would start
roughly at document load. Keep both animations (one in main frame, one in iframe) paused
until the iframe is loaded: this way they should run synchronised enough.

Also increase the tolerance of the test slightly: measuring timing like this is inherently flaky.

Remove failure expectation from all TestExpectations and remove the clearly wrong expected
result for chromium-mac.

  • animations/resources/stop-animation-on-suspend-subframe.html:
  • animations/stop-animation-on-suspend.html:
  • platform/chromium/TestExpectations:
  • platform/chromium-mac/animations/stop-animation-on-suspend-expected.txt:
  • platform/efl/TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/mac/TestExpectations:
  • platform/qt-arm/TestExpectations:
  • platform/win/TestExpectations:
  • platform/wincairo/TestExpectations:
12:33 PM Changeset in webkit [135306] by reed@google.com
  • 2 edits in trunk/LayoutTests

update TestExpectations before a skia change
https://bugs.webkit.org/show_bug.cgi?id=102829

Reviewed by NOBODY. expectations change only.

optimization for rectangular blurs (with holes) changes some images in the low bit. mark for rebaselining.

  • platform/chromium/TestExpectations:
11:59 AM Changeset in webkit [135305] by commit-queue@webkit.org
  • 7 edits
    1 add in trunk

Store MutationObserver callback in a hidden property for V8
https://bugs.webkit.org/show_bug.cgi?id=102555

Patch by Elliott Sprehn <esprehn@chromium.org> on 2012-11-20
Reviewed by Adam Barth.

.:

Test for reference cycle leaks with mutation observers. There doesn't seem
to be a way to check this for v8, but if you manually run you can see if it
leaks observers.

  • ManualTests/leak-cycle-observer-wrapper.html: Added.

Source/WebCore:

To prevent circular reference leaks we should store the MutationObserver
callback in a hidden property on the wrapper of the observer.

This is done by extending the code generator to support a new owner
argument to ::create() that lets you set the owner of the callback where
the hidden property should be stored.

Test: ManualTests/leak-cycle-observer-wrapper.html

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateCallbackHeader):
(GenerateCallbackImplementation):

  • bindings/scripts/test/V8/V8TestCallback.cpp: rebaselined.
  • bindings/scripts/test/V8/V8TestCallback.h: rebaselined.
  • bindings/v8/V8HiddenPropertyName.h:
  • bindings/v8/custom/V8MutationObserverCustom.cpp:

(WebCore::V8MutationObserver::constructorCallback):

11:58 AM Changeset in webkit [135304] by ojan@chromium.org
  • 10 edits
    4 adds in trunk/Tools

Generate a list of builders/test suites from the buildbot json
https://bugs.webkit.org/show_bug.cgi?id=102443

Reviewed by Dirk Pranke.

Instead of the cludgy things we do now to track which bots run which tests,
we generate all that data from the buildbots' json files.
This is the minimal amount to keep everything working. Once this lands,
we can also do a bunch of followup cleanup.

For now we commit the generated data. In theory, in the future, we could
have the test results server generate the data on the fly.

For the sake of easily understanding what changes when we run the generate script,
also checkin a pretty printed version of the output. The pretty printed version
is too large to serve as part of the flakiness dashboard though.

This also has the benefit of making the dashboard load much faster since
we no longer ever need to block on requests to buildbot.

  • TestResultServer/generate_builders_json.py: Added.

(master_json_url):
(builder_json_url):
(cached_build_json_url):
(fetch_json):
(insert_builder_and_test_data):
(main):

  • TestResultServer/generate_builders_json_unittest.py: Added.

(GenerateBuildersJsonTest):
(GenerateBuildersJsonTest.test_master_json_url):
(GenerateBuildersJsonTest.test_builder_json_url):
(GenerateBuildersJsonTest.test_cached_build_json_url):
(GenerateBuildersJsonTest.test_generate_json_data):
(GenerateBuildersJsonTest.test_generate_json_data.dummy_fetch_json):

  • TestResultServer/static-dashboards/builders-pretty.jsonp: Added.
  • TestResultServer/static-dashboards/builders.js:

(LOAD_BUILDBOT_DATA):
(BuilderGroup):
(BuilderGroup.prototype.append):
(BuilderGroup.prototype.master):
(requestBuilderList):

  • TestResultServer/static-dashboards/builders.jsonp: Added.
  • TestResultServer/static-dashboards/builders_unittests.js: Added.
  • TestResultServer/static-dashboards/dashboard_base.js:
  • TestResultServer/static-dashboards/flakiness_dashboard.js:

(showPopupForBuild):
(htmlForTestResults):
(htmlForIndividualTestOnAllBuildersWithResultsLinks):
(loadExpectationsLayoutTests):

  • TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:

(resetGlobals):
(test):

  • TestResultServer/static-dashboards/loader.js:
  • TestResultServer/static-dashboards/loader_unittests.js:
  • TestResultServer/static-dashboards/run-embedded-unittests.html:
  • TestResultServer/static-dashboards/run-unittests.html:
  • TestResultServer/static-dashboards/timeline_explorer.html:
11:46 AM Changeset in webkit [135303] by inferno@chromium.org
  • 3 edits
    2 adds in trunk

Crash in FrameLoader::stopLoading.
https://bugs.webkit.org/show_bug.cgi?id=99504

Reviewed by Nate Chapin.

Source/WebCore:

Frame can be blown away in unload event handler. Need
to protect it with a RefPtr.

Test: fast/frames/frame-unload-crash2.html

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::commitProvisionalLoad):

LayoutTests:

  • fast/frames/frame-unload-crash2-expected.txt: Added.
  • fast/frames/frame-unload-crash2.html: Added.
11:29 AM Changeset in webkit [135302] by commit-queue@webkit.org
  • 4 edits in trunk/Tools

[WTR][Qt] Enable fixedLayout when needed by the test
https://bugs.webkit.org/show_bug.cgi?id=102811

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-11-20
Reviewed by Kenneth Rohde Christiansen.

Create a flickable view for CSS Device Adaptation tests. This is
crucial for testing them since they will change the size of the
viewport.

  • WebKitTestRunner/PlatformWebView.h:

(PlatformWebView):

  • WebKitTestRunner/qt/PlatformWebViewQt.cpp:

(WTR::PlatformWebView::PlatformWebView):
(WTR::PlatformWebView::viewSupportsOptions):
(WTR):

  • WebKitTestRunner/qt/main.cpp:

(main):

11:12 AM Changeset in webkit [135301] by krit@webkit.org
  • 2 edits in trunk/Source/WebCore

Remove unnecessary FilterOperations header from RenderBoxModelObject
https://bugs.webkit.org/show_bug.cgi?id=102821

Reviewed by Ojan Vafai.

No new tests, simple refactoring.

  • rendering/RenderBoxModelObject.cpp:
11:04 AM ViewportInteractionTopics created by Noam Rosenthal
10:54 AM Changeset in webkit [135300] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

[Chromium] fix FPS counter disappearing when changing page
https://bugs.webkit.org/show_bug.cgi?id=102532

Patch by Eberhard Graether <egraether@google.com> on 2012-11-20
Reviewed by Pavel Feldman.

When changing the page with opened WebInspector and active FPS counter the WebInspector is
reloaded before the WebView switches to accelerated compositing, so the showFPSCounter call
to WebLayerTreeView is not yet possible. This fix saves the showFPSCounter value in the
WebSettings so it can be read when accelerated compositing is activated.

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::setShowFPSCounter):

10:49 AM Changeset in webkit [135299] by tsepez@chromium.org
  • 3 edits
    2 adds in trunk

XSSAuditor::decodedSnippetForJavaScript stopping when comma encountered.
https://bugs.webkit.org/show_bug.cgi?id=102587

Reviewed by Adam Barth.

Source/WebCore:

Rather than returning an empty fragment, continue processing the body
of a script tag when the decoded fragment reduces to nothing.

Test: http/tests/security/xssAuditor/script-tag-with-actual-comma.html

  • html/parser/XSSAuditor.cpp:

(WebCore::XSSAuditor::decodedSnippetForJavaScript):

LayoutTests:

  • http/tests/security/xssAuditor/script-tag-with-actual-comma-expected.txt: Added.
  • http/tests/security/xssAuditor/script-tag-with-actual-comma.html: Added.
10:46 AM Changeset in webkit [135298] by pfeldman@chromium.org
  • 1 edit in branches/chromium/1312/Source/WebCore/inspector/front-end/ElementsTreeOutline.js

Merge 134605 - Web Inspector: "Reveal in Element Panel" doesn't work if Elements panel hasn't been opened
https://bugs.webkit.org/show_bug.cgi?id=102219

Reviewed by Alexander Pavlov.

Force elements module load upon context menu invocation.

  • inspector/front-end/ElementsTreeOutline.js:

(WebInspector.ElementsTreeOutline.prototype._contextMenuEventFired.focusElement):
(WebInspector.ElementsTreeOutline.prototype._contextMenuEventFired):

TBR=pfeldman@chromium.org
BUG=161156
Review URL: https://chromiumcodereview.appspot.com/11414088

10:42 AM Changeset in webkit [135297] by pfeldman@chromium.org
  • 1 edit in branches/chromium/1312/Source/WebCore/inspector/front-end/ObjectPropertiesSection.js

Merge 134595 - Web Inspector: context menu on ObjectPropertyTreeElement's values is masked by the section.
https://bugs.webkit.org/show_bug.cgi?id=102212

Reviewed by Vsevolod Vlasov.

  • inspector/front-end/ObjectPropertiesSection.js:

(WebInspector.ObjectPropertiesSection.prototype.enableContextMenu):

TBR=pfeldman@chromium.org
BUG=161156
Review URL: https://chromiumcodereview.appspot.com/11416111

10:40 AM Changeset in webkit [135296] by commit-queue@webkit.org
  • 5 edits in trunk/LayoutTests

[CSS Exclusions] writing-mode:vertical-rl shape-inside tests are incorrectly configured
https://bugs.webkit.org/show_bug.cgi?id=102729

Patch by Hans Muller <hmuller@adobe.com> on 2012-11-20
Reviewed by Dirk Schulze.

Corrected the dimensions of the border elements in two exclusions tests. They
define a rectangle that's five pixels larger than the tests' rectangular
shape-inside exclusions shapes. They now enclose the shape-inside element's
text contents.

  • fast/exclusions/shape-inside/shape-inside-polygon-rectangle-expected.html:
  • fast/exclusions/shape-inside/shape-inside-polygon-rectangle.html:
  • fast/exclusions/shape-inside/shape-inside-vertical-text-expected.html:
  • fast/exclusions/shape-inside/shape-inside-vertical-text.html:
10:30 AM Changeset in webkit [135295] by simonjam@chromium.org
  • 39 edits
    1 add in trunk/Source

Consolidate FrameLoader::load() into one function taking a FrameLoadRequest
https://bugs.webkit.org/show_bug.cgi?id=102151

Reviewed by Adam Barth.

Source/WebCore:

There's a FIXME that we have too many FrameLoader::load*() functions. This patch consolidates 3 into 1.
There are still a few more load functions that will be consolidated later. Using FrameLoadRequest as
the interface into FrameLoader will also provide a place to pass in the initiator. Finally, this matches
the refactoring done with CachedResourceRequest and CachedResourceLoader.

No new tests. No change in functionality.

  • WebCore.exp.in:
  • loader/FrameLoadRequest.h:

(WebCore::FrameLoadRequest::FrameLoadRequest):
(WebCore::FrameLoadRequest::setLockHistory): These are former arguments to load().
(WebCore::FrameLoadRequest::lockHistory): Ditto.
(FrameLoadRequest):
(WebCore::FrameLoadRequest::setShouldCheckNewWindowPolicy): Ditto.
(WebCore::FrameLoadRequest::shouldCheckNewWindowPolicy): Ditto.
(WebCore::FrameLoadRequest::substituteData): Ditto.
(WebCore::FrameLoadRequest::setSubstituteData): Ditto.
(WebCore::FrameLoadRequest::hasSubstituteData): Ditto.

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::load): No change in behavior, just merged it all into one function.

  • loader/FrameLoader.h:

(FrameLoader):

  • page/DragController.cpp:

(WebCore::DragController::performDrag):

Source/WebKit/blackberry:

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::load):
(BlackBerry::WebKit::WebPagePrivate::loadString):

  • WebCoreSupport/FrameLoaderClientBlackBerry.cpp:

(WebCore::FrameLoaderClientBlackBerry::dispatchDidFailProvisionalLoad):

Source/WebKit/chromium:

  • src/WebFrameImpl.cpp:

(WebKit::WebFrameImpl::loadRequest):
(WebKit::WebFrameImpl::loadData):

  • src/WebSharedWorkerImpl.cpp:

(WebKit::WebSharedWorkerImpl::initializeLoader):

Source/WebKit/efl:

  • ewk/ewk_frame.cpp:

(_ewk_frame_contents_set_internal):

Source/WebKit/gtk:

  • webkit/webkitwebframe.cpp:

(webkit_web_frame_load_uri):
(webkit_web_frame_load_data):
(webkit_web_frame_load_request):

Source/WebKit/mac:

  • Plugins/WebPluginController.mm:
  • WebView/WebFrame.mm:

(-[WebFrame loadRequest:]):
(-[WebFrame _loadData:MIMEType:textEncodingName:baseURL:unreachableURL:]):

Source/WebKit/qt:

  • Api/qwebframe.cpp:

(QWebFrame::QWebFrame):
(QWebFrame::load):
(QWebFrame::setHtml):
(QWebFrame::setContent):

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp:

(DumpRenderTreeSupportQt::setAlternateHtml):
(qt_dump_set_accepts_editing):

  • WebCoreSupport/FrameLoaderClientQt.cpp:

(WebCore::FrameLoaderClientQt::callErrorPageExtension):

Source/WebKit/win:

  • WebFrame.cpp:

(WebFrame::loadRequest):
(WebFrame::loadData):

Source/WebKit/wince:

  • WebView.cpp:

(WebView::load):

Source/WebKit/wx:

  • WebFrame.cpp:

(WebKit::WebFrame::SetPageSource):

Source/WebKit2:

  • WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::performFrameLoadURLRequest):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::loadURLRequest):
(WebKit::WebPage::loadData):

10:30 AM Changeset in webkit [135294] by kareng@chromium.org
  • 9 edits in branches/chromium/1312/Source/WebCore/platform/graphics

Revert 135211 - Merge 134871
BUG=157875
Review URL: https://codereview.chromium.org/11299089

TBR=cevans@google.com

10:26 AM Changeset in webkit [135293] by commit-queue@webkit.org
  • 11 edits in trunk/Source/WebCore

Remove V8DOMWindowShell::getEntered
https://bugs.webkit.org/show_bug.cgi?id=96637

Patch by Dan Carney <dcarney@google.com> on 2012-11-20
Reviewed by Adam Barth.

V8DOMWindowShell::getEntered was refactored so that the window shell
no longer has to be kept alive by a v8 context. Instead, only
the DOMWrapperWorld will be kept alive.

No new tests. No change in functionality.

  • bindings/v8/DOMDataStore.cpp:

(WebCore::DOMDataStore::current):

  • bindings/v8/DOMWrapperWorld.cpp:

(WebCore::isolatedWorldWeakCallback):
(WebCore):
(WebCore::DOMWrapperWorld::makeContextWeak):
(WebCore::DOMWrapperWorld::setIsolatedWorldField):

  • bindings/v8/DOMWrapperWorld.h:

(DOMWrapperWorld):
(WebCore::DOMWrapperWorld::isolated):

  • bindings/v8/ScriptController.cpp:

(WebCore::ScriptController::existingWindowShell):
(WebCore::ScriptController::windowShell):
(WebCore::ScriptController::evaluateInIsolatedWorld):
(WebCore::ScriptController::currentWorldContext):
(WebCore::ScriptController::collectIsolatedContexts):

  • bindings/v8/ScriptController.h:

(ScriptController):

  • bindings/v8/V8Binding.h:

(WebCore::worldForEnteredContextIfIsolated):

  • bindings/v8/V8DOMWindowShell.cpp:

(WebCore::V8DOMWindowShell::destroyIsolatedShell):
(WebCore::V8DOMWindowShell::disposeContext):
(WebCore::V8DOMWindowShell::initializeIfNeeded):

  • bindings/v8/V8DOMWindowShell.h:

(V8DOMWindowShell):

  • bindings/v8/V8PerContextData.h:
  • bindings/v8/WorldContextHandle.cpp:

(WebCore::WorldContextHandle::WorldContextHandle):

10:24 AM Changeset in webkit [135292] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

[GTK] fast/hidpi/video-controls-in-hidpi.html and fast/layers/video-layer.html need new baseline
https://bugs.webkit.org/show_bug.cgi?id=102815

Patch by Xabier Rodriguez Calvar <calvaris@igalia.com> on 2012-11-20
Reviewed by Philippe Normand.

Added new GTK baseline for those tests.

  • platform/gtk/fast/hidpi/video-controls-in-hidpi-expected.txt:

New GTK baseline

  • platform/gtk/fast/layers/video-layer-expected.txt: New GTK

baseline

9:58 AM Changeset in webkit [135291] by mkwst@chromium.org
  • 6 edits in trunk/Source/WebCore

Remove '#include "ScriptCallStackFactory.h"' include when unnecessary.
https://bugs.webkit.org/show_bug.cgi?id=102812

Reviewed by Jochen Eisinger.

"ScriptCallStackFactory.h" is included in a few files where it doesn't
seem to be required. Since I'm in the process of centralizing stack
trace generation anyway, I'll just clean this up as a drive-by.

  • bindings/js/JSConsoleCustom.cpp:
  • bindings/v8/custom/V8DOMWindowCustom.cpp:
  • bindings/v8/custom/V8WorkerContextCustom.cpp:
  • loader/FrameLoader.cpp:

Removed "ScriptCallStackFactory.h".

  • bindings/js/ScheduledAction.cpp:

This also included (but didn't use) "ScriptCallStack.h". I've
removed it as well.

9:44 AM Changeset in webkit [135290] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Merge checks for creating renderers into shouldCreateRenderer
https://bugs.webkit.org/show_bug.cgi?id=102768

Patch by Elliott Sprehn <esprehn@chromium.org> on 2012-11-20
Reviewed by Ojan Vafai.

Merge the checks for if renderers should be created into shouldCreateRenderer
so simplify the code and ensure correctness if doing
NodeRenderingContext(node).shouldCreateRenderer() in other places in webkit.

No new tests, just refactoring.

  • dom/NodeRenderingContext.cpp:

(WebCore::NodeRenderingContext::shouldCreateRenderer):
(WebCore::NodeRendererFactory::createRendererIfNeeded):

9:25 AM Changeset in webkit [135289] by rakuco@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Gardening.

Temporarily mark fast/multicol/span/positioned-child-not-removed-crash.html
as crashing while the regression is addressed.

  • platform/efl-wk2/TestExpectations:
9:16 AM Changeset in webkit [135288] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

WinCairo build fails to link.
https://bugs.webkit.org/show_bug.cgi?id=102804

Patch by peavo@outlook.com <peavo@outlook.com> on 2012-11-20
Reviewed by Alexey Proskuryakov.

  • win/WebKit2CFLite.def:
9:14 AM Changeset in webkit [135287] by commit-queue@webkit.org
  • 10 edits in trunk

[WTR] WebKitTestRunner should be able to run tests using fixed layout
https://bugs.webkit.org/show_bug.cgi?id=102517

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-11-20
Reviewed by Kenneth Rohde Christiansen.

Source/WebKit2:

Update EFL private API so we can create a view with fixed layout. We
can keep this as private as I don't see a real life use case for it
outside WTR and the WebInspector.

  • UIProcess/API/C/efl/WKView.cpp:

(WKViewCreate):
(WKViewCreateWithFixedLayout):

  • UIProcess/API/C/efl/WKView.h:
  • UIProcess/API/efl/ewk_view.cpp:

(ewk_view_base_add):

  • UIProcess/API/efl/ewk_view_private.h:
  • UIProcess/efl/WebInspectorProxyEfl.cpp:

(WebKit::WebInspectorProxy::platformCreateInspectorPage):

Tools:

WTR will now request the creation of a view that has a page using
fixed layout for CSS Device Adaptation tests, but this feature might
be used in the future by any other test that requires a mobile-like type
of viewport (i.e. Viewport META tests should be ported).

The viewport type of the other tests remains unchanged and is restored
when the runner leaves the device-adapt/ folder.

  • WebKitTestRunner/PlatformWebView.h:

(PlatformWebView):

  • WebKitTestRunner/TestInvocation.cpp:

(WTR):
(WTR::shouldUseFixedLayout):
(WTR::updateLayoutType):
(WTR::TestInvocation::invoke):

  • WebKitTestRunner/efl/PlatformWebViewEfl.cpp:

(WTR::PlatformWebView::PlatformWebView):
(WTR::PlatformWebView::viewSupportsOptions):
(WTR):

8:32 AM Changeset in webkit [135286] by yoli@rim.com
  • 2 edits in trunk/Source/JavaScriptCore

[ARMv7] Neither linkCall() nor linkPointer() should flush code.
https://bugs.webkit.org/show_bug.cgi?id=99213

Reviewed by George Staikos.

LinkBuffer doesn't need to flush code during linking. It will
eventually flush the whole executable. Fixing this gives >%5
sunspider boost (on QNX).

Also make replaceWithLoad() and replaceWithAddressComputation() flush
only when necessary.

  • assembler/ARMv7Assembler.h:

(JSC::ARMv7Assembler::linkCall):
(JSC::ARMv7Assembler::linkPointer):
(JSC::ARMv7Assembler::relinkCall):
(JSC::ARMv7Assembler::repatchInt32):
(JSC::ARMv7Assembler::repatchPointer):
(JSC::ARMv7Assembler::replaceWithLoad): Flush only after it did write.
(JSC::ARMv7Assembler::replaceWithAddressComputation): Flush only after it did write.
(JSC::ARMv7Assembler::setInt32):
(JSC::ARMv7Assembler::setPointer):

8:31 AM Changeset in webkit [135285] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: simplify? damaged region computation in the editor
https://bugs.webkit.org/show_bug.cgi?id=102688

Reviewed by Vsevolod Vlasov.

This change simplifies the damaged region computation. Drive-by make _getSelection work properly.

  • inspector/front-end/DefaultTextEditor.js:

(WebInspector.DefaultTextEditor):
(WebInspector.DefaultTextEditor.prototype._handleCut):
(WebInspector.TextEditorChunkedPanel.prototype._findFirstVisibleLineNumber.compareLineRowOffsetTops):
(WebInspector.TextEditorChunkedPanel.prototype._findFirstVisibleLineNumber):
(WebInspector.TextEditorMainPanel.prototype.handleEnterKey.get var):
(WebInspector.TextEditorMainPanel.prototype.handleEnterKey):
(WebInspector.TextEditorMainPanel.prototype._paintLineChunks):
(WebInspector.TextEditorMainPanel.prototype._getSelection):
(WebInspector.TextEditorMainPanel.prototype._restoreSelection):
(WebInspector.TextEditorMainPanel.prototype._selectionToPosition):
(WebInspector.TextEditorMainPanel.prototype._positionToSelection):
(WebInspector.TextEditorMainPanel.prototype._handleMutations):
(WebInspector.TextEditorMainPanel.prototype._collectDirtyLines):
(WebInspector.TextEditorMainPanel.prototype._applyDomUpdates):
(WebInspector.TextEditorMainPanel.prototype._guessEditRangeBasedOnSelection):
(WebInspector.TextEditorMainPanel.prototype._assertDOMMatchesTextModel):
(WebInspector.TextEditorMainPanel.prototype._updateChunksForRanges):
(WebInspector.TextEditorMainPanel.prototype._collectLinesFromDOM):
(WebInspector.TextEditorMainChunk):
(WebInspector.TextEditorMainChunk.prototype.addDecoration):
(WebInspector.TextEditorMainChunk.prototype.get endLine):
(WebInspector.TextEditorMainChunk.prototype.lineRowContainingLine):
(WebInspector.TextEditorMainChunk.prototype.expandedLineRow):

8:26 AM Changeset in webkit [135284] by pfeldman@chromium.org
  • 3 edits in branches/chromium/1312/Source/WebCore/inspector

Merge 134577 - Web Inspector: highlight is not updating as one edits CSS properties
https://bugs.webkit.org/show_bug.cgi?id=102191

Reviewed by Alexander Pavlov.

We should update highlight upon layout / style recalculation.

  • inspector/InspectorInstrumentation.cpp:

(WebCore):
(WebCore::InspectorInstrumentation::didRecalculateStyleImpl):

  • inspector/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::InspectorPageAgent):
(WebCore::InspectorPageAgent::enable):
(WebCore::InspectorPageAgent::disable):
(WebCore::InspectorPageAgent::domContentEventFired):
(WebCore::InspectorPageAgent::didPaint):
(WebCore::InspectorPageAgent::didLayout):
(WebCore::InspectorPageAgent::didScroll):
(WebCore):
(WebCore::InspectorPageAgent::didRecalculateStyle):

  • inspector/InspectorPageAgent.h:

TBR=pfeldman@chromium.org
Review URL: https://chromiumcodereview.appspot.com/11413088

8:20 AM Changeset in webkit [135283] by allan.jensen@digia.com
  • 3 edits in trunk/Source/WebKit2

[Qt] PageViewportControllerClient::didChangeViewportAttributes called twice
https://bugs.webkit.org/show_bug.cgi?id=102790

Reviewed by Kenneth Rohde Christiansen.

Change updateMinimumScaleToFit to no longer call PageViewportControllerClient::didChangeViewportAttributes,
but instead return whether it has changed the minimumScaleToFit.

  • UIProcess/PageViewportController.cpp:

(WebKit::PageViewportController::didChangeContentsSize):
(WebKit::PageViewportController::updateMinimumScaleToFit):

  • UIProcess/PageViewportController.h:

(PageViewportController):

8:10 AM Changeset in webkit [135282] by allan.jensen@digia.com
  • 2 edits in trunk/Source/WebKit2

[Qt] No test of double-click to zoom out
https://bugs.webkit.org/show_bug.cgi?id=102810

Reviewed by Kenneth Rohde Christiansen.

Adds tests of zoom-stack behaviour, the ability to restore previous zoom levels. It tests
that zoom out always goes to lower zoom levels.

  • UIProcess/API/qt/tests/qmltests/WebView/tst_doubleTapToZoom.qml:
8:08 AM Changeset in webkit [135281] by Carlos Garcia Campos
  • 2 edits in trunk

Unreviewed. Update NEWS and configure.ac for 1.11.2 release

  • configure.ac: Bump tarball version number, not updated in

previous commit by mistake.

8:02 AM Changeset in webkit [135280] by allan.jensen@digia.com
  • 2 edits in trunk/Source/WebKit2

[Qt] Large areas highlighted on touch
https://bugs.webkit.org/show_bug.cgi?id=97216

Reviewed by Simon Hausmann.

Restrict highlighting of scripted event-handlers to inline elements only.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::highlightPotentialActivation):

8:02 AM Changeset in webkit [135279] by Carlos Garcia Campos
  • 4 edits in trunk

Unreviewed. Update NEWS and configure.ac for 1.11.2 release

.:

  • configure.ac: Bump version numbers.

Source/WebKit/gtk:

  • NEWS: Added release notes for 1.11.2.
7:56 AM Changeset in webkit [135278] by yael@webkit.org
  • 3 edits
    1 add in trunk/LayoutTests

Unreviewed gardening.
Update results for compositing/geometry/vertical-scroll-composited.html after 133898.
Mark animations/negative-delay.html as flaky.
Remove a few passing tests from TextExpectations.

  • platform/efl/TestExpectations:
  • platform/efl/compositing/geometry/vertical-scroll-composited-expected.png: Added.
  • platform/efl/compositing/geometry/vertical-scroll-composited-expected.txt:
7:35 AM Changeset in webkit [135277] by arv@chromium.org
  • 4 edits in trunk/Source/WebCore

Remove historical enums from ExceptionCode.h
https://bugs.webkit.org/show_bug.cgi?id=102095

Reviewed by Ojan Vafai.

Remove unused enums from ExceptionCode.

No new tests. No tests affected.

  • Modules/intents/NavigatorIntents.cpp:

(WebCore::NavigatorIntents::webkitStartActivity): The error type for this is unspecified.

  • dom/DOMCoreException.cpp:
  • dom/ExceptionCode.h:
7:34 AM Changeset in webkit [135276] by schenney@chromium.org
  • 9 edits
    1 delete in trunk/LayoutTests

[Chromium] Expectations update

Unreviewed test expectations update.

Some results for calendar and month picker may not be up-to-date for the slow bots.

  • platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-step-expected.png:
  • platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-step-expected.png:
  • platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-step-expected.png:
  • platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-step-expected.png:
  • platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-step-expected.png:
  • platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-step-expected.png:
  • platform/chromium-win-xp/fast/block/float/overhanging-tall-block-expected.png: Removed.
  • platform/chromium-win/fast/block/float/overhanging-tall-block-expected.png:
  • platform/chromium-win/fast/block/float/overhanging-tall-block-expected.txt:
6:11 AM Changeset in webkit [135275] by Csaba Osztrogonác
  • 2 edits in trunk/Tools

[Qt] REGRESSION(r128174): Fast build path doesn't work now
https://bugs.webkit.org/show_bug.cgi?id=100360

Reviewed by Tor Arne Vestbø.

Use a separated .builtRevisions.cache file instead of .qmake.cache to cache built SVN revisions.

  • Scripts/webkitdirs.pm:

(buildQMakeProjects):

6:02 AM Changeset in webkit [135274] by keishi@webkit.org
  • 7 edits in trunk

Week picker width is too small
https://bugs.webkit.org/show_bug.cgi?id=102766

Reviewed by Kent Tamura.

Source/WebCore:

The width of week picker was too small because we were forgetting about
the week number column when calculating the desired width.

No new tests. Covered by week-picker-appearance*.html.

  • Resources/pagepopups/calendarPicker.css:

(.week-mode .week-column): Needs to be table-cell.

  • Resources/pagepopups/calendarPicker.js:

(CalendarPicker.prototype.fixWindowSize):

LayoutTests:

  • platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-expected.png:
  • platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-step-expected.png:
  • platform/chromium/TestExpectations:
5:40 AM Changeset in webkit [135273] by Philippe Normand
  • 18 edits in trunk

[GTK] no volume slider in HTML5 media element controls
https://bugs.webkit.org/show_bug.cgi?id=97192

Patch by Xabier Rodriguez Calvar <calvaris@igalia.com> on 2012-11-20
Reviewed by Philippe Normand.

r115829 was causing this regression so it was partially
reverted. The revert causes some small regressions, in the tests
but it is better to have the volume slider shown.

Source/WebCore:

  • css/mediaControlsGtk.css:

(audio::-webkit-media-controls-panel)
(video::-webkit-media-controls-panel): Partially reverted
r115829.

LayoutTests:

  • platform/gtk-wk2/TestExpectations: Updated because it causes

some new regressions

  • platform/gtk/TestExpectations: Updated because it causes some

new regressions

  • platform/gtk/media/audio-controls-rendering-expected.txt: Updated
  • platform/gtk/media/controls-after-reload-expected.txt: Updated
  • platform/gtk/media/controls-strict-expected.txt: Updated
  • platform/gtk/media/controls-styling-expected.txt: Updated
  • platform/gtk/media/controls-styling-strict-expected.txt: Updated
  • platform/gtk/media/controls-without-preload-expected.txt: Updated
  • platform/gtk/media/media-controls-clone-expected.txt: Updated
  • platform/gtk/media/video-controls-rendering-expected.txt: Updated
  • platform/gtk/media/video-display-toggle-expected.txt: Updated
  • platform/gtk/media/video-empty-source-expected.txt: Updated
  • platform/gtk/media/video-no-audio-expected.txt: Updated
  • platform/gtk/media/video-volume-slider-expected.txt: Updated
  • platform/gtk/media/video-zoom-controls-expected.txt: Updated
5:17 AM Changeset in webkit [135272] by allan.jensen@digia.com
  • 3 edits in trunk/Source/WebKit2

[Qt] Zoom logic confused by page and pinch resize
https://bugs.webkit.org/show_bug.cgi?id=102803

Reviewed by Kenneth Rohde Christiansen.

Clear the zoom-out stack after page resize, and ensure the zoom logic can still detect
zoom-out and zoom-back when the zoom-out stack is empty.

  • UIProcess/qt/PageViewportControllerClientQt.cpp:

(WebKit::PageViewportControllerClientQt::zoomToAreaGestureEnded):
(WebKit::PageViewportControllerClientQt::clearRelativeZoomState):
(WebKit::PageViewportControllerClientQt::setContentsScale):
(WebKit::PageViewportControllerClientQt::pinchGestureStarted):
(WebKit::PageViewportControllerClientQt::didChangeViewportAttributes):

  • UIProcess/qt/PageViewportControllerClientQt.h:

(PageViewportControllerClientQt):

3:36 AM Changeset in webkit [135271] by Antti Koivisto
  • 7 edits in trunk/Source/WebCore

Collect user style sheets in DocumentStyleSheetCollection
https://bugs.webkit.org/show_bug.cgi?id=102683

Reviewed by Andreas Kling.

Move the user stylesheet collection logic from StyleResolver to DocumentStyleSheetCollection.

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::StyleResolver):
(WebCore::StyleResolver::collectRulesFromUserStyleSheets):
(WebCore::collectCSSOMWrappers):

  • css/StyleResolver.h:

(StyleResolver):

  • dom/DocumentStyleSheetCollection.cpp:

(WebCore::DocumentStyleSheetCollection::~DocumentStyleSheetCollection):
(WebCore::DocumentStyleSheetCollection::pageUserStyleSheet):
(WebCore::DocumentStyleSheetCollection::clearPageUserStyleSheet):
(WebCore::DocumentStyleSheetCollection::updatePageUserStyleSheet):
(WebCore::DocumentStyleSheetCollection::analyzeStyleSheetChange):
(WebCore::collectActiveStyleSheetsFromSeamlessParents):
(WebCore::DocumentStyleSheetCollection::updateStyleResolver):

Factor the StyleResolver updating code to function.

(WebCore):
(WebCore::DocumentStyleSheetCollection::updateActiveStyleSheets):

Collect the user style sheets. Some renaming and other minor refactoring.

(WebCore::DocumentStyleSheetCollection::reportMemoryUsage):

  • dom/DocumentStyleSheetCollection.h:

(WebCore::DocumentStyleSheetCollection::activeUserStyleSheets):

Add activeUserStyleSheets vector that contains all user stylesheets from different sources,
similar to activeAuthorStyleSheets.

(DocumentStyleSheetCollection):
(WebCore::DocumentStyleSheetCollection::documentUserStyleSheets):

3:24 AM Changeset in webkit [135270] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Remove unneeded optimization in Element::isInTopLayer
https://bugs.webkit.org/show_bug.cgi?id=102772

Patch by Elliott Sprehn <esprehn@chromium.org> on 2012-11-20
Reviewed by Andreas Kling.

There's no reason to worry about calling elementRareData() multiple
times in this non performance sensitive code path as it's only used
in HTMLDialogElement's showModal and close methods.

No new tests, just simplification.

  • dom/Element.cpp:

(WebCore::Element::setIsInTopLayer):

3:18 AM Changeset in webkit [135269] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Simplify Element::isSpellCheckingEnabled
https://bugs.webkit.org/show_bug.cgi?id=102779

Patch by Elliott Sprehn <esprehn@chromium.org> on 2012-11-20
Reviewed by Andreas Kling.

isSpellCheckingEnabled contains logic that duplicates parentOrHostElement
and can be simplified by just calling that.

No new tests, just simplification.

  • dom/Element.cpp:

(WebCore::Element::isSpellCheckingEnabled):

3:09 AM Changeset in webkit [135268] by kihong.kwon@samsung.com
  • 7 edits in trunk/Source/WebCore

Apply DeviceController as parent class of DeviceMotionController.
https://bugs.webkit.org/show_bug.cgi?id=102578

Reviewed by Hajime Morita.

DeviceController needs to be applied as parent class of DeviceMotionController
because DeviceController which is extracted as parent class of
DeviceMotionController and DeviceOrientationController is already added.
Therefore duplicated implementation can be removed.

Covered by existing tests.

  • dom/DeviceMotionClient.h:
  • dom/DeviceMotionController.cpp:

(WebCore::DeviceMotionController::DeviceMotionController):
(WebCore::DeviceMotionController::didChangeDeviceMotion):
(WebCore::DeviceMotionController::deviceMotionClient):
(WebCore::DeviceMotionController::hasLastData):
(WebCore::DeviceMotionController::getLastEvent):
(WebCore::DeviceMotionController::from):
(WebCore):

  • dom/DeviceMotionController.h:

(WebCore):
(WebCore::DeviceMotionController::~DeviceMotionController):
(DeviceMotionController):

  • dom/Document.cpp:

Remove all implementations which are related DeviceOrientationEvnet and DeviceMotionEvent.
Because DeviceController checks suspend and stop status of active dom object before dispatchEvent.
(WebCore::Document::suspendActiveDOMObjects):
(WebCore::Document::resumeActiveDOMObjects):

  • loader/EmptyClients.h:
  • page/DOMWindow.cpp:

(WebCore::DOMWindow::addEventListener):
(WebCore::DOMWindow::removeEventListener):
(WebCore::DOMWindow::removeAllEventListeners):

2:24 AM Changeset in webkit [135267] by commit-queue@webkit.org
  • 2 edits
    2 moves
    1 add in trunk/Tools

[EFL][GTK]Sharing accessibility support in WebKitTestRunner.
https://bugs.webkit.org/show_bug.cgi?id=99011

Patch by Mateusz Leszko <m.leszko@samsung.com> on 2012-11-20
Reviewed by Martin Robinson.

Accessibility files from gtk folder are moved to atk folder due to common implementation. Event Type naming changed to default, from Gtk to ATK.

  • WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp: Renamed from Tools/WebKitTestRunner/InjectedBundle/gtk/AccessibilityControllerGtk.cpp.

(WTR::AccessibilityController::logAccessibilityEvents):

  • WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp: Renamed from Tools/WebKitTestRunner/InjectedBundle/gtk/AccessibilityUIElementGtk.cpp.
1:56 AM Changeset in webkit [135266] by haraken@chromium.org
  • 2 edits in trunk/Source/WebCore

[V8] Remove V8ParameterBase
https://bugs.webkit.org/show_bug.cgi?id=102774

Reviewed by Adam Barth.

V8ParameterBase is a redundant indirection.
We can flatten methods of V8ParameterBase to V8Parameter.

No tests. No change in behavior.

  • bindings/v8/V8StringResource.h:

(WebCore::V8Parameter::V8Parameter):
(V8Parameter):
(WebCore::V8Parameter::toString):
(WebCore::::prepare):

1:21 AM Changeset in webkit [135265] by yurys@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed. Mark inspector/profiler/cpu-profiler-profiling-without-inspector.html
as crashing.

  • platform/chromium/TestExpectations:
12:20 AM Changeset in webkit [135264] by zandobersek@gmail.com
  • 2 edits in trunk/Tools

webkitpy unit tests should run serially when checking code coverage
https://bugs.webkit.org/show_bug.cgi?id=102693

Reviewed by Dirk Pranke.

When checking code coverage, the unit tests should not be run in parallel
as this causes the tracing functions (set via sys.settrace in the coverage
module) being overriden, resulting in incorrect coverage reports.

  • Scripts/webkitpy/test/main.py:

(Tester._run_tests):

12:16 AM Changeset in webkit [135263] by commit-queue@webkit.org
  • 12 edits
    4 adds in trunk

Use localized date-time format in datetime input
https://bugs.webkit.org/show_bug.cgi?id=102769

Patch by Kunihiko Sakamoto <ksakamoto@chromium.org> on 2012-11-20
Reviewed by Kent Tamura.

Source/WebCore:

Move the implementation of Locale::dateTimeFormatWithSeconds and Locale::dateTimeFormatWithoutSeconds
to its subclasses and use platform-specific methods to get date-time pattern.
Because Windows does not provide an API to get date-time pattern. We use fixed "{date} {time}"
pattern for Windows.

Test: fast/forms/datetime/datetime-appearance-l10n.html

  • platform/text/LocaleICU.cpp:

(WebCore::LocaleICU::initializeDateTimeFormat): Retrieve datetime formats too.
(WebCore::LocaleICU::dateTimeFormatWithSeconds): Added.
(WebCore):
(WebCore::LocaleICU::dateTimeFormatWithoutSeconds): Added.

  • platform/text/LocaleICU.h:

(LocaleICU): Add m_dateTimeFormatWithSeconds and m_dateTimeFormatWithoutSeconds.

  • platform/text/LocaleNone.cpp:

(LocaleNone):
(WebCore::LocaleNone::dateTimeFormatWithSeconds): Added. Always returns "dd/MM/yyyyy HH:mm:ss".
(WebCore):
(WebCore::LocaleNone::dateTimeFormatWithoutSeconds): Added. Always returns "dd/MM/yyyyy HH:mm".

  • platform/text/PlatformLocale.cpp:

(WebCore): Remove dateTimeFormatWithSeconds() and dateTimeFormatWithoutSeconds() as these are now pure virtual.

  • platform/text/PlatformLocale.h:

(Locale): Make dateTimeFormatWithSeconds() and dateTimeFormatWithoutSeconds() pure virtual.

  • platform/text/mac/LocaleMac.h:

(LocaleMac): Add m_dateTimeFormatWithSeconds and m_dateTimeFormatWithoutSeconds.

  • platform/text/mac/LocaleMac.mm:

(WebCore::LocaleMac::dateTimeFormatterWithSeconds): Added.
(WebCore):
(WebCore::LocaleMac::dateTimeFormatterWithoutSeconds): Added.
(WebCore::LocaleMac::dateTimeFormatWithSeconds): Added.
(WebCore::LocaleMac::dateTimeFormatWithoutSeconds): Added.

  • platform/text/win/LocaleWin.cpp:

(WebCore::LocaleWin::dateTimeFormatWithSeconds): Copied from original Locale::dateTimeFormatWithSeconds().
(WebCore):
(WebCore::LocaleWin::dateTimeFormatWithoutSeconds): Copied from original Locale::dateTimeFormatWithoutSeconds().

  • platform/text/win/LocaleWin.h:

(LocaleWin): Add m_dateTimeFormatWithSeconds and m_dateTimeFormatWithoutSeconds.

LayoutTests:

  • fast/forms/datetime/datetime-appearance-l10n-expected.txt: Added.
  • fast/forms/datetime/datetime-appearance-l10n.html: Added. We can confirm vi-vn have time-date ordering.
  • platform/chromium-mac/fast/forms/datetime/datetime-appearance-l10n-expected.png: Added.
  • platform/chromium/TestExpectations:
12:12 AM Changeset in webkit [135262] by vsevik@chromium.org
  • 2 edits in branches/chromium/1312/Source/WebCore/inspector/front-end

Merge 134944 - Web Inspector: Workaround to show shortcuts for panels that hasn't been loaded.
https://bugs.webkit.org/show_bug.cgi?id=102488

Patch by Eugene Klyuchnikov <eustas.bug@gmail.com> on 2012-11-16
Reviewed by Vsevolod Vlasov.

Panels are lazily loaded / instantiated.
Panel constructors register keyboard shortcuts.

When user open shortcuts screen all panel should be loaded.
Otherwise some shortcuts will be missing.

  • inspector/front-end/ShortcutsScreen.js: Added callback invokation.
  • inspector/front-end/inspector.js:

Provided callback that loads all panels.

TBR=commit-queue@webkit.org
BUG=160943
Review URL: https://codereview.chromium.org/11413082

12:09 AM Changeset in webkit [135261] by yurys@chromium.org
  • 2 edits in trunk/Source/WebCore

Unreviewed, rolling out r135257.
http://trac.webkit.org/changeset/135257
https://bugs.webkit.org/show_bug.cgi?id=102777

Broke Chromium Debug compilation (Requested by yurys on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-11-20

  • bindings/v8/DOMDataStore.h:

(WebCore::DOMDataStore::getNode):

12:06 AM Changeset in webkit [135260] by vsevik@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: Revert r133149: breaks revision reverting
https://bugs.webkit.org/show_bug.cgi?id=102672

Reviewed by Yury Semikhatsky.

  • inspector/front-end/JavaScriptSourceFrame.js:

(WebInspector.JavaScriptSourceFrame):
(WebInspector.JavaScriptSourceFrame.prototype._onFormattedChanged):
(WebInspector.JavaScriptSourceFrame.prototype._onWorkingCopyCommitted):
(WebInspector.JavaScriptSourceFrame.prototype._innerSetContent):

Nov 19, 2012:

11:56 PM Changeset in webkit [135259] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebCore

[Qt][Win] Unreviewed speculative buildfix after r135217.

  • platform/win/WindowsExtras.h:
11:49 PM Changeset in webkit [135258] by yurys@chromium.org
  • 2 edits in trunk/Source/WebCore

Unreviewed. Fix Chromium Win compilation after r135255.
https://bugs.webkit.org/show_bug.cgi?id=97803

  • WebCore.gypi: removed reference to platform/wince/DragDataWince.cpp which

was deleted in the aforementioned change.

11:39 PM Changeset in webkit [135257] by haraken@chromium.org
  • 2 edits in trunk/Source/WebCore

[V8] Merge getCachedWrapper(Node*) into DOMDataStore
https://bugs.webkit.org/show_bug.cgi?id=102158

Reviewed by Adam Barth.

A follow-up patch for r135230. This patch adds a correct ASSERTION.

No tests. No change in behavior.

  • bindings/v8/DOMDataStore.h:

(WebCore::DOMDataStore::getNode):

11:38 PM Changeset in webkit [135256] by haraken@chromium.org
  • 2 edits in trunk/Source/WebCore

[JSC] Replace $implClassName with $interfaceName in CodeGeneratorJS.pm
https://bugs.webkit.org/show_bug.cgi?id=102757

Reviewed by Adam Barth.

In CodeGeneratorJS.pm $implClassName and $interfaceName are
equivalent. We're using them interchangeably. We should replace
$implClassName with $interfaceName.

No tests. No change in behavior.

  • bindings/scripts/CodeGeneratorJS.pm:

(AddClassForwardIfNeeded):
(GenerateGetOwnPropertySlotBody):
(GenerateGetOwnPropertyDescriptorBody):
(GenerateHeader):
(GenerateOverloadedFunction):
(GenerateImplementation):
(GenerateParametersCheck):
(GenerateImplementationFunctionCall):
(NativeToJSValue):

11:13 PM Changeset in webkit [135255] by Patrick Gansterer
  • 3 edits
    1 delete in trunk/Source/WebCore

Port DragDataWin.cpp to WinCE
https://bugs.webkit.org/show_bug.cgi?id=97803

Reviewed by Brent Fulgham.

Add two simple #if OS(WINCE) to DragDataWin.cpp, so it can be used by the WinCE port too.

  • PlatformWinCE.cmake:
  • platform/win/DragDataWin.cpp:

(WebCore::DragData::containsFiles):
(WebCore::DragData::numberOfFiles):
(WebCore::DragData::asFilenames):

  • platform/wince/DragDataWinCE.cpp: Removed.
10:51 PM Changeset in webkit [135254] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

[Web Inspector] This patch makes script line number search-able in Timeline panel.
https://bugs.webkit.org/show_bug.cgi?id=101910.

Patch by Pan Deng <pan.deng@intel.com> on 2012-11-19
Reviewed by Pavel Feldman.

Script line number is visible in Timeline panel, however, not search-able. This patch makes it search-able.

No new tests.

  • inspector/front-end/TimelinePanel.js:

(WebInspector.TimelineRecordListRow.prototype.update):
(WebInspector.TimelineRecordListRow.testContentMatching):

  • inspector/front-end/TimelinePresentationModel.js:

(WebInspector.TimelinePresentationModel.Record.prototype._generatePopupContentWithImagePreview):
(WebInspector.TimelinePresentationModel.Record.prototype._refreshDetails):
(WebInspector.TimelinePresentationModel.Record.prototype.detailsNode):
(WebInspector.TimelinePresentationModel.Record.prototype._createSpanWithText):
(WebInspector.TimelinePresentationModel.Record.prototype._getRecordDetails):

10:33 PM Changeset in webkit [135253] by yurys@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Fix Chromium Win compilation after r135196.
https://bugs.webkit.org/show_bug.cgi?id=102021

  • tests/DeferredImageDecoderTest.cpp: changed char to unsigned char in the array

declaration to avoid 'warning C4309' on MSVS when initializing from hex literals.
(WebCore):

10:28 PM Changeset in webkit [135252] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Remove unneeded null check in NodeRendererFactory::createRendererIfNeeded
https://bugs.webkit.org/show_bug.cgi?id=102765

Patch by Elliott Sprehn <esprehn@chromium.org> on 2012-11-19
Reviewed by Ojan Vafai.

If parentRenderer() was null then we return early from
createRendererIfNeeded() because shouldCreateRenderer() will return false
so there's no reason to check for it again.

Additionally if either parentRenderer() or style() is null then
implementations of rendererIsNeeded() will crash, so add asserts to
make this assumption more clear.

No new tests, just simplification.

  • dom/NodeRenderingContext.cpp:

(WebCore::NodeRendererFactory::createRendererIfNeeded):

10:09 PM Changeset in webkit [135251] by shinyak@chromium.org
  • 7 edits in trunk/Source/WebCore

[Refactoring] Remove WebCore::isInsertionPoint(Node*)
https://bugs.webkit.org/show_bug.cgi?id=102756

Reviewed by Hajime Morita.

Now that WebCore::isInsertionPoint(Node* node) does nothing special. We can remove this.

No new tests, simple refactoring.

  • dom/ComposedShadowTreeWalker.cpp:

(WebCore::ComposedShadowTreeWalker::traverseNodeEscapingFallbackContents):

  • dom/ContainerNode.cpp:

(WebCore::childAttachedAllowedWhenAttachingChildren):

  • html/shadow/ContentDistributor.cpp:

(WebCore::ContentDistributor::invalidate):

  • html/shadow/InsertionPoint.cpp:

(WebCore::InsertionPoint::isActive):

  • html/shadow/InsertionPoint.h:

(WebCore::toInsertionPoint):
(WebCore::isActiveInsertionPoint):
(WebCore::isLowerEncapsulationBoundary):
(WebCore::parentNodeForDistribution):

  • testing/Internals.cpp:

(WebCore::Internals::isValidContentSelect):

10:08 PM Changeset in webkit [135250] by apavlov@chromium.org
  • 1 edit in branches/chromium/1312/Source/WebCore/inspector/InspectorPageAgent.cpp

Merge 134917 - Web Inspector: [Overrides] Device metrics get reset on navigation, yet remain in the Overrides view
https://bugs.webkit.org/show_bug.cgi?id=102467

Reviewed by Pavel Feldman.

Restore the device metrics overrides from the inspector cookie in InspectorPageAgent::restore().
Drive-by: move the script execution and FPS counter display state restoration from enable() into restore(),
so that they will get restored only upon page navigation, not upon any agent enablement.

  • inspector/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::restore): Restore device metrics overrides, script execution and FPS counter display state.
(WebCore::InspectorPageAgent::enable): Don't restore script execution and FPS counter display state on any enablement.

TBR=apavlov@chromium.org
Review URL: https://codereview.chromium.org/11416095

9:49 PM Changeset in webkit [135249] by shinyak@chromium.org
  • 6 edits in trunk

[Refactoring] Remove shadowPseudoId() and use setPseudo() in <progress> ElementShadow.
https://bugs.webkit.org/show_bug.cgi?id=101703

Reviewed by Hajime Morita.

Source/WebCore:

We're migrating shadowPseudoId() to pseudo(). We remove shadowPseudoId() from HTMLKeygenElement and use
setPseudo()/pseudo() instead.

No new tests, simple refactoring.

  • html/shadow/ProgressShadowElement.cpp:

(WebCore::ProgressInnerElement::ProgressInnerElement):

  • html/shadow/ProgressShadowElement.h:

(ProgressInnerElement):
(WebCore::ProgressBarElement::ProgressBarElement):
(ProgressBarElement):
(WebCore::ProgressValueElement::ProgressValueElement):

LayoutTests:

  • editing/style/apply-style-atomic-expected.txt:
  • fast/dom/HTMLProgressElement/progress-element-markup-expected.txt:
9:38 PM Changeset in webkit [135248] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[WK2] Unused parameters on CoordinatedGraphicsLayer.cpp
https://bugs.webkit.org/show_bug.cgi?id=102760

Patch by KyungTae Kim <ktf.kim@samsung.com> on 2012-11-19
Reviewed by Laszlo Gombos.

Because the 'platformLayer' parameter is not used when !USE(GRAPHICS_SURFACE),
use UNUSED_PARAM macro to fix build warning -Wunused-parameter

  • WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.cpp:

(WebCore::CoordinatedGraphicsLayer::setContentsToCanvas):

9:37 PM Changeset in webkit [135247] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Remove support for ARMv7 errata from the jump code
https://bugs.webkit.org/show_bug.cgi?id=102759

Reviewed by Oliver Hunt.

The jump replacement code was wrong to begin with since it wasn't doing
a cache flush on the inserted padding. And, to my knowledge, we don't need
this anymore, so this patch removes all errata code from the ARMv7 port.

  • assembler/ARMv7Assembler.h:

(JSC::ARMv7Assembler::computeJumpType):
(JSC::ARMv7Assembler::replaceWithJump):
(JSC::ARMv7Assembler::maxJumpReplacementSize):
(JSC::ARMv7Assembler::canBeJumpT3):
(JSC::ARMv7Assembler::canBeJumpT4):

9:34 PM Changeset in webkit [135246] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[EFL] Add fallback for WebkitTestRunner if opengl is not available.
https://bugs.webkit.org/show_bug.cgi?id=102704

Patch by Viatcheslav Ostapenko <v.ostapenko@samsung.com> on 2012-11-19
Reviewed by Laszlo Gombos.

Add fallback to non-opengl evas engine in WebkitTestRunner if opengl is not available.

  • WebKitTestRunner/efl/PlatformWebViewEfl.cpp:

(WTR::initEcoreEvas):

9:24 PM Changeset in webkit [135245] by yurys@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed. Reenable webaudio/biquad-getFrequencyResponse.html test as it should pass after r129418
https://bugs.webkit.org/show_bug.cgi?id=97439

  • platform/chromium/TestExpectations:
9:00 PM Changeset in webkit [135244] by yurys@chromium.org
  • 2 edits in trunk/Source/WebCore

Unreviewed. Fix Chromium Debug compilation after r135230.
https://bugs.webkit.org/show_bug.cgi?id=102158

Removed ASSERT that used instance field in a static method.

  • bindings/v8/DOMDataStore.h:

(WebCore::DOMDataStore::getWrapperFromObject):

8:55 PM Changeset in webkit [135243] by commit-queue@webkit.org
  • 6 edits in trunk/Source/WebCore

[Blackberry] When a frame is being detached, cancel all its network jobs.
https://bugs.webkit.org/show_bug.cgi?id=102758

Patch by Chris Guan <chris.guan@torchmobile.com.cn> on 2012-11-19
Reviewed by George Staikos.

I use FrameDestructionObserver to refactor Networkjob code.
NetworkJob is inheriting from FrameDestructionObserver to be
aware of frame's destroyed. When a frame is being detached,
the willDetachPage() can be called in which we can cancel
the job. This patch reverted the fix for RIM PR134207 as well.

Manually test is on
"http://www.reuters.com/article/2012/01/27/us-greece-idUSTRE80P0DE20120127"
which triggers a ping loader.

No behavior changed, no new layout tests.

  • platform/network/blackberry/NetworkJob.cpp:

(WebCore::NetworkJob::NetworkJob):
(WebCore::NetworkJob::initialize):
(WebCore::NetworkJob::handleNotifyHeaderReceived):
(WebCore::NetworkJob::startNewJobWithRequest):
(WebCore::NetworkJob::frameDestroyed):
(WebCore):
(WebCore::NetworkJob::willDetachPage):

  • platform/network/blackberry/NetworkJob.h:

(NetworkJob):

  • platform/network/blackberry/NetworkManager.cpp:

(WebCore::NetworkManager::startJob):

  • platform/network/blackberry/NetworkManager.h:

(NetworkManager):

  • platform/network/blackberry/ResourceHandleBlackBerry.cpp:

(WebCore::ResourceHandle::start):
(WebCore::ResourceHandle::loadResourceSynchronously):

8:45 PM Changeset in webkit [135242] by commit-queue@webkit.org
  • 15 edits
    10 adds in trunk

Implement the new stacking layer needed by the Fullscreen API and the new <dialog> element
https://bugs.webkit.org/show_bug.cgi?id=84796

Patch by Matt Falkenhagen <falken@chromium.org> on 2012-11-19
Reviewed by Julien Chaffraix.

Source/WebCore:

This adds the top layer element stack to Document. The Fullscreen
specification mandates that we track the ordering of the DOM nodes in
the top layer, not the renderers. That makes it hard to implement on
the rendering side only.

Elements in the top layer get a layer. Layers in the top layer are
added to the root layer's child list after normal layers and in the
order of the top layer stack. This way, the top layer appears above
all other stacking contexts and in the desired order.

In addition, top layer renderers are added as children of RenderView
in top layer order. This is to satisfy requirements such as the
containing block of an element in the top layer is the initial
containing block. It also allows RenderLayer to know the proper
stacking order of the layers without going directly from the top layer
elements to their layers.

So far, only modal dialog elements can be added to the top layer.
The plan is to make the Fullscreen API also use the top layer.

Tests: fast/dom/HTMLDialogElement/top-layer-containing-block.html

fast/dom/HTMLDialogElement/top-layer-display-none.html
fast/dom/HTMLDialogElement/top-layer-nesting.html
fast/dom/HTMLDialogElement/top-layer-stacking-dynamic.html
fast/dom/HTMLDialogElement/top-layer-stacking.html

  • WebCore.exp.in:
  • css/StyleResolver.cpp:

(WebCore::StyleResolver::adjustRenderStyle): Elements in the top layer have a stacking context.

  • dom/Document.cpp:

(WebCore):
(WebCore::Document::addToTopLayer):
(WebCore::Document::removeFromTopLayer):

  • dom/Document.h:

(Document):
(WebCore::Document::topLayerElements): Add the top layer element stack to Document.

  • dom/Element.cpp:

(WebCore::Element::removedFrom):
(WebCore):
(WebCore::Element::isInTopLayer):
(WebCore::Element::setIsInTopLayer):

  • dom/Element.h:
  • dom/ElementRareData.h:

(ElementRareData):

  • dom/Node.cpp:

(WebCore::Node::detach): Add an exception to the assert since top layer elements and their descendants are moved from their
regular position in the render tree.

  • dom/NodeRareData.h:

(WebCore::NodeRareData::NodeRareData):
(NodeRareData):
(WebCore::NodeRareData::isInTopLayer):
(WebCore::NodeRareData::setIsInTopLayer):

  • dom/NodeRenderingContext.cpp:

(WebCore):
(WebCore::adjustInsertionPointForTopLayerElement):
(WebCore::NodeRendererFactory::createRendererIfNeeded): Add renderers for top layer elements as children of RenderView, and
in top layer stacking order.

  • html/HTMLDialogElement.cpp:

(WebCore::HTMLDialogElement::close):
(WebCore::HTMLDialogElement::showModal):

  • rendering/RenderLayer.cpp:

(WebCore):
(WebCore::RenderLayer::isInTopLayer):
(WebCore::RenderLayer::isInTopLayerSubtree):
(WebCore::RenderLayer::rebuildZOrderLists): Add the top layer stack after normal layer collection.
(WebCore::RenderLayer::collectLayers): Avoid adding layers for top layer elements during normal layer collection.

  • rendering/RenderLayer.h:

(RenderLayer):

LayoutTests:

Add tests for top layer stacking and rendering.

  • fast/dom/HTMLDialogElement/top-layer-containing-block-expected.html: Added.
  • fast/dom/HTMLDialogElement/top-layer-containing-block.html: Added.
  • fast/dom/HTMLDialogElement/top-layer-display-none-expected.html: Added.
  • fast/dom/HTMLDialogElement/top-layer-display-none.html: Added.
  • fast/dom/HTMLDialogElement/top-layer-nesting-expected.html: Added.
  • fast/dom/HTMLDialogElement/top-layer-nesting.html: Added.
  • fast/dom/HTMLDialogElement/top-layer-stacking-dynamic-expected.html: Added.
  • fast/dom/HTMLDialogElement/top-layer-stacking-dynamic.html: Added.
  • fast/dom/HTMLDialogElement/top-layer-stacking-expected.html: Added.
  • fast/dom/HTMLDialogElement/top-layer-stacking.html: Added.
8:37 PM Changeset in webkit [135241] by yurys@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed. Fix lint errors on chromium TextExpectations after r135205.

  • platform/chromium/TestExpectations:
8:29 PM Changeset in webkit [135240] by haraken@chromium.org
  • 2 edits in trunk/Source/WebCore

In CodeGeneratorObj.pm we should rename $dataNode to $interface.
https://bugs.webkit.org/show_bug.cgi?id=102749

Reviewed by Adam Barth.

$dataNode is misnamed. It should be renamed to $interface.

No tests. No change in behavior.

  • bindings/scripts/CodeGeneratorObjC.pm:

(GenerateInterface):
(GetParentImplClassName):
(GetParentAndProtocols):
(GenerateHeader):
(GenerateImplementation):

8:26 PM Changeset in webkit [135239] by haraken@chromium.org
  • 2 edits in trunk/Source/WebCore

In CodeGeneratorV8.pm, we should rename $dataNode to $interface
https://bugs.webkit.org/show_bug.cgi?id=102747

Reviewed by Adam Barth.

$dataNode is misnamed. It should be $interface.

No tests. No change in behavior.

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateInterface):
(NeedsCustomOpaqueRootForGC):
(GetGenerateIsReachable):
(GetCustomIsReachable):
(GenerateOpaqueRootForGC):
(GenerateHeader):
(GetInternalFields):
(GenerateHeaderCustomInternalFieldIndices):
(GenerateHeaderNamedAndIndexedPropertyAccessors):
(GenerateHeaderCustomCall):
(IsConstructable):
(GenerateConstructorGetter):
(GenerateNormalAttrGetter):
(GenerateReplaceableAttrSetter):
(GenerateNormalAttrSetter):
(GenerateOverloadedFunctionCallback):
(GenerateFunctionCallback):
(GenerateArgumentsCountCheck):
(GenerateOverloadedConstructorCallback):
(GenerateSingleConstructorCallback):
(GenerateConstructorCallback):
(GenerateEventConstructorCallback):
(GenerateTypedArrayConstructorCallback):
(GenerateNamedConstructorCallback):
(GenerateBatchedAttributeData):
(IsStandardFunction):
(GenerateNonStandardFunction):
(GenerateImplementationIndexer):
(GenerateImplementationNamedPropertyGetter):
(GenerateImplementationCustomCall):
(GenerateImplementationMasqueradesAsUndefined):
(GenerateImplementation):
(GenerateHeaderContentHeader):
(GenerateImplementationContentHeader):
(GenerateCallbackHeader):
(GenerateCallbackImplementation):
(BaseInterfaceName):
(GenerateToV8Converters):
(GetNativeTypeForConversions):
(GetTypeNameOfExternalTypedArray):
(WriteData):

8:19 PM Changeset in webkit [135238] by keishi@webkit.org
  • 2 edits in trunk/Source/WebCore

Move in animation should be disabled until the calendar picker is loaded.
https://bugs.webkit.org/show_bug.cgi?id=102661

Reviewed by Kent Tamura.

On weeks where the first day is in the previous month (e.x. 2013-W01)
the move in animation happens when you open the calendar picker. This
patch disables the move in animation until the calendar picker is fully
loaded.

No new tests.

  • Resources/pagepopups/calendarPicker.js:

(CalendarPicker):
(CalendarPicker.prototype._handleWindowResize):
(DaysTable.prototype._startMoveInAnimation):

8:18 PM Changeset in webkit [135237] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Clean up loop in NodeRenderingContext::nextRenderer and previousRenderer
https://bugs.webkit.org/show_bug.cgi?id=102743

Patch by Elliott Sprehn <esprehn@chromium.org> on 2012-11-19
Reviewed by Hajime Morita.

Clean up while (true) loops in NodeRenderingContext reducing the
amount of code and the need for ASSERT_NOT_REACHED.

No new tests, just simplifcation.

  • dom/NodeRenderingContext.cpp:

(WebCore::NodeRenderingContext::nextRenderer):
(WebCore::NodeRenderingContext::previousRenderer):

8:10 PM Changeset in webkit [135236] by shinyak@chromium.org
  • 5 edits in trunk

[Shadow] attribute pseudo should return empty string instead of null when nothing is specified.
https://bugs.webkit.org/show_bug.cgi?id=102753

Reviewed by Hajime Morita.

Source/WebCore:

The ShadowDOM spec is changed so that attribute 'pseudo' returns empty string instead of null when
no value is set.

Test: fast/dom/shadow/pseudo-attribute.html

  • dom/Element.idl:

LayoutTests:

  • fast/dom/shadow/pseudo-attribute-expected.txt:
  • fast/dom/shadow/pseudo-attribute.html:
7:27 PM Changeset in webkit [135235] by haraken@chromium.org
  • 2 edits in trunk/Source/WebCore

In CodeGeneratorGObject.pm we should rename $dataNode to $interface
https://bugs.webkit.org/show_bug.cgi?id=102751

Reviewed by Adam Barth.

$dataNode is misnamed. It should be $interface.

No tests. No change in behavior.

  • bindings/scripts/CodeGeneratorGObject.pm:

(GetParentClassName):
(GetParentGObjType):
(GenerateProperties):
(GenerateFunctions):
(GenerateCFile):
(GenerateEventTargetIface):
(Generate):
(WriteData):
(GenerateInterface):

7:15 PM Changeset in webkit [135234] by haraken@chromium.org
  • 2 edits in trunk/Source/WebCore

In CodeGenerator.pm we should rename $dataNode to $interface
https://bugs.webkit.org/show_bug.cgi?id=102754

Reviewed by Adam Barth.

$dataNode is misnamed. It should be $interface.

No tests. No change in behavior.

  • bindings/scripts/CodeGenerator.pm:

(ForAllParents):
(AddMethodsConstantsAndAttributesFromParentInterfaces):
(FindSuperMethod):
(IsConstructorTemplate):
(LinkOverloadedFunctions):
(GenerateCompileTimeCheckForEnumsIfNeeded):
(GetVisibleInterfaceName):
(IsSubType):

7:00 PM Changeset in webkit [135233] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Block Zoom picks wrong block
https://bugs.webkit.org/show_bug.cgi?id=102728

Patch by Genevieve Mak <gmak@rim.com> on 2012-11-19
Reviewed by Rob Buis.

Reviewed Internally by Jakob Petsovits
Remove transform missed in previous commit for
https://bugs.webkit.org/show_bug.cgi?id=101608
PR #247198

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::nodeForZoomUnderPoint):

6:58 PM Changeset in webkit [135232] by haraken@chromium.org
  • 2 edits in trunk/Source/WebCore

In CodeGeneratorCPP.pm we should rename $dataNode to $interface
https://bugs.webkit.org/show_bug.cgi?id=102752

Reviewed by Adam Barth.

$dataNode is misnamed. It should be $interface.

No tests. No change in behavior.

  • bindings/scripts/CodeGeneratorCPP.pm:

(GenerateInterface):
(GetParentImplClassName):
(GetParent):
(GenerateHeader):
(GenerateImplementation):

6:45 PM Changeset in webkit [135231] by haraken@chromium.org
  • 2 edits in trunk/Source/WebCore

In CodeGeneratorJS.pm we should rename $dataNode to $interface
https://bugs.webkit.org/show_bug.cgi?id=102748

Reviewed by Adam Barth.

$dataNode is misnamed. It should be $interface.

No tests. No change in behavior.

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateInterface):
(GetParentClassName):
(GetGenerateIsReachable):
(GetCustomIsReachable):
(GenerateGetOwnPropertySlotBody):
(GenerateGetOwnPropertyDescriptorBody):
(GenerateHeaderContentHeader):
(GenerateImplementationContentHeader):
(ShouldGenerateToJSDeclaration):
(ShouldGenerateToJSImplementation):
(GenerateHeader):
(GenerateAttributesHashTable):
(GenerateOverloadedFunction):
(GenerateImplementation):
(GenerateArgumentsCountCheck):
(GenerateParametersCheck):
(GenerateCallbackHeader):
(GenerateCallbackImplementation):
(WriteData):
(GenerateConstructorDeclaration):
(GenerateConstructorDefinition):
(IsConstructable):

6:39 PM Changeset in webkit [135230] by abarth@webkit.org
  • 9 edits in trunk/Source/WebCore

[V8] Merge getCachedWrapper(Node*) into DOMDataStore
https://bugs.webkit.org/show_bug.cgi?id=102158

Reviewed by Eric Seidel.

This patch is an incremental step towards fully merging the Node code
path with the general code path. After this patch, at least Nodes flow
through the same class.

  • Modules/indexeddb/IDBTransactionCoordinator.h:
  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateHeader):
(GenerateToV8Converters):

  • bindings/v8/DOMDataStore.h:

(WebCore::DOMDataStore::getNode):
(DOMDataStore):
(WebCore::DOMDataStore::getWrapperFromObject):

  • bindings/v8/DOMWrapperWorld.cpp:

(WebCore::DOMWrapperWorld::DOMWrapperWorld):
(WebCore):

  • bindings/v8/DOMWrapperWorld.h:

(WebCore):
(DOMWrapperWorld):

  • bindings/v8/V8DOMWrapper.h:

(V8DOMWrapper):

6:18 PM Changeset in webkit [135229] by haraken@chromium.org
  • 4 edits in trunk/Source/WebCore

In the IDL parser, we should rename $dataNode to $interface
https://bugs.webkit.org/show_bug.cgi?id=102746

Reviewed by Adam Barth.

$dataNode is misnamed. It should be $interface.

No tests. No change in behavior.

  • bindings/scripts/IDLParser.pm:

(parseInterface):
(parseException):
(parseAttributeOrOperationRest):
(parseOperationOrIterator):
(parseSpecialOperation):
(parseInterfaceOld):
(parseExceptionOld):
(parseAttributeOrOperationOrIteratorOld):
(parseAttributeOrOperationRestOld):
(applyMemberList):
(applyExtendedAttributeList):

  • bindings/scripts/generate-bindings.pl:
  • bindings/scripts/preprocess-idls.pl:

(checkIDLAttributes):

6:16 PM Changeset in webkit [135228] by adamk@chromium.org
  • 13 edits
    4 adds in trunk

MutationObserver wrapper should not be collected while still observing
https://bugs.webkit.org/show_bug.cgi?id=102328

Reviewed by Adam Barth.

Source/WebCore:

Use the new opaqueRootForGC helper in V8GCController to put each
MutationObserver wrapper in the same object group as the nodes it's
observing.

Only includes V8 impl for now, JSC impl coming soon.

Tests: fast/mutation/observer-wrapper-dropoff-transient.html

fast/mutation/observer-wrapper-dropoff.html

  • bindings/v8/V8GCController.cpp: Add custom code for MutationObserver

with a FIXME to move this out once we update the opaque roots API.

  • dom/MutationObserver.cpp:

(WebCore::MutationObserver::getObservedNodes): Plumbing to expose the observed nodes
to the GC controller.
(WebCore):

  • dom/MutationObserver.h:
  • dom/MutationObserverRegistration.cpp:

(WebCore::MutationObserverRegistration::addRegistrationNodesToSet): More plumbing.
(WebCore):

  • dom/MutationObserverRegistration.h:

(MutationObserverRegistration):

LayoutTests:

Tests showing that observers are kept alive, both in the simple case
and in the transient registered observer case (where the original
registration node is GCed but the transient observation node is still
alive).

  • fast/mutation/observer-wrapper-dropoff-expected.txt: Added.
  • fast/mutation/observer-wrapper-dropoff-transient-expected.txt: Added.
  • fast/mutation/observer-wrapper-dropoff-transient.html: Added.
  • fast/mutation/observer-wrapper-dropoff.html: Added.
6:11 PM Changeset in webkit [135227] by tony@chromium.org
  • 9 edits in trunk

Move more non-settings out of InternalSettings
https://bugs.webkit.org/show_bug.cgi?id=102711

Reviewed by Adam Barth.

Source/WebCore:

Remove userPreferredLanguages, setUserPreferredLanguages and allowRoundingHacks
from internal.settings since they are already exposed by window.internals (in
fact, no one calls the internal.settings version).

Move setUsesOverlayScrollbars from internals.settings to internals because it is
a global (static) setting and not tied to the lifetime of the Settings object.

No new tests, there should be no behavior change since this is a refactor.

  • testing/InternalSettings.cpp:

(WebCore::InternalSettings::reset): Remove custom reset code.
(WebCore::InternalSettings::setUsesOverlayScrollbars): Add exception code handling to make it more consistent with other settings setters.

  • testing/InternalSettings.h:
  • testing/InternalSettings.idl: Remove unnecessary methods.
  • testing/Internals.cpp:

(WebCore::Internals::resetToConsistentState): Reset userPreferredLanguages, allowRoundingHacks and overlay scrollbars.
(WebCore::Internals::userPreferredLanguages): Don't go through InternalSettings.
(WebCore::Internals::setUserPreferredLanguages): Don't go through InternalSettings.
(WebCore::Internals::setUsesOverlayScrollbars): Moved from InternalsSettings.
(WebCore::Internals::allowRoundingHacks): Don't go through InternalSettings.

LayoutTests:

Move static values out of InternalSettings.

  • fast/scrolling/scrollbar-tickmarks-hittest.html: Move setUsesOverlayScrollbars to internals.
6:10 PM Changeset in webkit [135226] by dgrogan@chromium.org
  • 5 edits in trunk

IndexedDB: Complex series of opens/deleteDatabase fails an ASSERT
https://bugs.webkit.org/show_bug.cgi?id=101810

Reviewed by Tony Chang.

Source/WebCore:

Tests - storage/indexeddb/deletedatabase-delayed-by-versionchange.html

  • Modules/indexeddb/IDBDatabaseBackendImpl.cpp:

(WebCore::IDBDatabaseBackendImpl::processPendingCalls):
The condition tested by this assert is a valid state.

LayoutTests:

Removed use of setVersion. Surprisingly straightforward conversion
given how gnarly this test is.

  • storage/indexeddb/deletedatabase-delayed-by-versionchange-expected.txt:
  • storage/indexeddb/resources/deletedatabase-delayed-by-versionchange.js:

(h1OpenSuccess.h1.onversionchange):
(h1OpenSuccess.request.onsuccess.h2OpenSuccess.h2.onversionchange):
(h1OpenSuccess.request.onsuccess.h2OpenSuccess.request.onsuccess):
(h1OpenSuccess.request.onsuccess.h2OpenSuccess.request.onblocked.h3Blocked.request.onsuccess):
(h1OpenSuccess.request.onsuccess.h2OpenSuccess.request.onblocked):
(h1OpenSuccess.request.onsuccess.h2OpenSuccess.request.onupgradeneeded.h3OnUpgradeneeded.transaction.oncomplete):
(h1OpenSuccess.request.onsuccess.h2OpenSuccess.request.onupgradeneeded):
(h1OpenSuccess.request.onsuccess):
(h1OpenSuccess):

6:06 PM Changeset in webkit [135225] by Patrick Gansterer
  • 2 edits in trunk/Source/JavaScriptCore

[CMake] Create JavaScriptCore ForwardingHeaders
https://bugs.webkit.org/show_bug.cgi?id=92665

Reviewed by Brent Fulgham.

When using CMake to build the Windows port, we need
to generate the forwarding headers with it too.

  • CMakeLists.txt:
6:03 PM Changeset in webkit [135224] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebCore

Web Inspector: [JSC] worker debugger shouldn't stop for "willExecuteProgram" instruction
https://bugs.webkit.org/show_bug.cgi?id=102637

Patch by Peter Wang <peter.wang@torchmobile.com.cn> on 2012-11-19
Reviewed by Timothy Hatcher.

Override the interface "willExecuteProgram" to let WorkerScriptDebugServer to avoid to stop for it.

No new DRT test case. Sorry, so far it seems impossible to write a case to controle the popupped
worker inspector window.

  • bindings/js/ScriptDebugServer.cpp:

(WebCore::ScriptDebugServer::createCallFrame):
(WebCore::ScriptDebugServer::callEvent):
(WebCore::ScriptDebugServer::willExecuteProgram):

  • bindings/js/ScriptDebugServer.h:

(ScriptDebugServer):

  • bindings/js/WorkerScriptDebugServer.cpp:

(WebCore::WorkerScriptDebugServer::willExecuteProgram):
(WebCore):

  • bindings/js/WorkerScriptDebugServer.h:

(WorkerScriptDebugServer):

6:02 PM Changeset in webkit [135223] by dgrogan@chromium.org
  • 5 edits
    6 deletes in trunk/LayoutTests

IndexedDB: last setVersion excision batch
https://bugs.webkit.org/show_bug.cgi?id=102713

Reviewed by Tony Chang.

  • storage/indexeddb/resources/setversion-blocked-by-versionchange-close-in-blocked.js: Removed. The crucial part of this test was a connection closing itself in its blocked callback. This is no longer possible as there's now only a handle to the connection after the blocked event is dealt with.
  • storage/indexeddb/resources/setversion-blocked-by-versionchange-close.js: This test exposes a cascade of errors. h2's should receive 0 blocked errors. Instead it receives 2.
  • storage/indexeddb/resources/setversion-blocked.js: Removed. Tests the same thing as set_version_blocked.
  • storage/indexeddb/resources/setversion-not-blocked.js: Now h2 is the version change connection and h1 is the blocker.
  • storage/indexeddb/setversion-blocked-by-versionchange-close-in-blocked.html: Removed.
  • storage/indexeddb/setversion-blocked.html: Removed.
5:58 PM Changeset in webkit [135222] by dgrogan@chromium.org
  • 3 edits in trunk/LayoutTests

IndexedDB: convert delete-closed-database-object to upgradeneeded
https://bugs.webkit.org/show_bug.cgi?id=102458

Reviewed by Tony Chang.

This test relies on gc behavior and seems flaky in content_shell.

  • storage/indexeddb/delete-closed-database-object-expected.txt:
  • storage/indexeddb/resources/delete-closed-database-object.js:

(prepareDatabase):
(openSuccess.openRequest.onsuccess):
(openSuccess):
(setVersion):

5:55 PM Changeset in webkit [135221] by psolanki@apple.com
  • 3 edits in trunk/Source/WebCore

For single element arrays use the pointer into the CFDataRef instead of copying data
https://bugs.webkit.org/show_bug.cgi?id=102306

Reviewed by Brent Fulgham.

Address review comments for slightly nicer code.

  • platform/SharedBuffer.cpp:

(WebCore::SharedBuffer::data):

  • platform/cf/SharedBufferCF.cpp:

(WebCore::SharedBuffer::singleDataArrayBuffer):

5:53 PM Changeset in webkit [135220] by crogers@google.com
  • 4 edits in trunk/Source/WebCore

Remove empirical bass-boost for HRTF spatialization
https://bugs.webkit.org/show_bug.cgi?id=102745

Reviewed by Kenneth Russell.

Some empirically-based post-processing is being removed so that we'll
now process with the exact HRTF impulse response measurements.
Listening tests have determined that this post-processing is not necessary.

  • platform/audio/HRTFElevation.cpp:

(WebCore::HRTFElevation::calculateKernelsForAzimuthElevation):

  • platform/audio/HRTFKernel.cpp:

(WebCore::HRTFKernel::HRTFKernel):

  • platform/audio/HRTFKernel.h:

(WebCore::HRTFKernel::create):
(HRTFKernel):

5:52 PM Changeset in webkit [135219] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

DISALLOW_COPY_AND_ASSIGN is not a WebKit macro
https://bugs.webkit.org/show_bug.cgi?id=102755

Reviewed by Sam Weinig.

WTF_MAKE_NONCOPYABLE is the idiom we use in WebKit. I don't understand
how this compiles.

  • Modules/indexeddb/IDBBackingStore.h:

(RecordIdentifier):

5:46 PM Changeset in webkit [135218] by crogers@google.com
  • 9 edits in trunk

Implement .detune attribute for BiquadFilterNode
https://bugs.webkit.org/show_bug.cgi?id=102737

Reviewed by Kenneth Russell.

Source/WebCore:

Similar to OscillatorNode, BiquadFilterNode must have a .detune attribute

Tests changed: webaudio/biquad-lowpass.html

  • Modules/webaudio/BiquadDSPKernel.cpp:

(WebCore::BiquadDSPKernel::updateCoefficientsIfNecessary):

  • Modules/webaudio/BiquadFilterNode.h:

(WebCore::BiquadFilterNode::detune):

  • Modules/webaudio/BiquadFilterNode.idl:
  • Modules/webaudio/BiquadProcessor.cpp:

(WebCore::BiquadProcessor::BiquadProcessor):
(WebCore::BiquadProcessor::checkForDirtyCoefficients):

  • Modules/webaudio/BiquadProcessor.h:

(WebCore::BiquadProcessor::parameter4):
(BiquadProcessor):

LayoutTests:

  • webaudio/biquad-lowpass.html:
  • webaudio/resources/biquad-testing.js:

(createTestAndRun):
(generateReference):

5:35 PM Changeset in webkit [135217] by Patrick Gansterer
  • 4 edits in trunk/Source/WebCore

[WIN] Add WebCore::getRegistryValue()
https://bugs.webkit.org/show_bug.cgi?id=97828

Reviewed by Brent Fulgham.

The new function adds an abstraction to SHGetValue(), which isn't available on WinCE.
Changing the existing files allows us to share more code between WinCE and WinNT in a next step.

  • platform/win/MIMETypeRegistryWin.cpp:

(WebCore::mimeTypeForExtension):
(WebCore):
(WebCore::MIMETypeRegistry::getPreferredExtensionForMIMEType):

  • platform/win/WindowsExtras.h:

(WebCore::getRegistryValue):
(WebCore):

  • plugins/win/PluginDatabaseWin.cpp:

(WebCore::addPluginPathsFromRegistry):
(WebCore::addWindowsMediaPlayerPluginDirectory):
(WebCore::addQuickTimePluginDirectory):
(WebCore::addAdobeAcrobatPluginDirectory):
(WebCore::addJavaPluginDirectory):

5:22 PM Changeset in webkit [135216] by danakj@chromium.org
  • 3 edits in trunk/Source

[chromium] Remove the WebCompositorSupport virtual methods from the base class
https://bugs.webkit.org/show_bug.cgi?id=102153

Reviewed by James Robinson.

These methods have now been removed from WebCompositorSupportImpl in
chromium and should be removed from the base class. Everything is
going through WebLayerTreeSettings now.

  • chromium/public/WebCompositorSupport.h:
5:05 PM FeatureFlags edited by tkent@chromium.org
Remove CSS_HIERARCHIES (diff)
4:49 PM Changeset in webkit [135215] by cevans@google.com
  • 1 edit
    2 copies in branches/chromium/1312

Merge 133609
BUG=158992
Review URL: https://codereview.chromium.org/11280078

4:44 PM Changeset in webkit [135214] by cevans@google.com
  • 1 edit in branches/chromium/1312/Source/WebKit/chromium/src/WebViewImpl.cpp

Merge 133009
BUG=158707
Review URL: https://codereview.chromium.org/11420084

4:39 PM Changeset in webkit [135213] by cevans@google.com
  • 10 edits
    2 copies in branches/chromium/1312

Merge 132895
BUG=157951
Review URL: https://codereview.chromium.org/11419080

4:38 PM Changeset in webkit [135212] by commit-queue@webkit.org
  • 4 edits
    3 adds in trunk

Coordinated Graphics: Remove tiles of a layer when they are off the viewport.
https://bugs.webkit.org/show_bug.cgi?id=102313

Patch by Huang Dongsung <luxtella@company100.net> on 2012-11-19
Reviewed by Noam Rosenthal.

Source/WebKit2:

Currently, we don't remove tiles of the layer with the special properties: a
transform animation and non affine transform. If a page has a lot of layers with
a transform animation, we will encounter OOM. So this patch removes the
privilege of the layer.

There are two changes.

  1. computeTransformedVisibleRect() calculates a layer transform using the

current local transform which a transform animation applied.

  1. tiledBackingStoreVisibleRect() calculates a visible

rect of all layers, even if the layer includes the property: a transform
animation or non affine transform.

Test: animations/animation-offscreen-to-onscreen.html

  • WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.cpp:

(WebCore::CoordinatedGraphicsLayer::effectiveContentsScale):
(WebCore::CoordinatedGraphicsLayer::tiledBackingStoreVisibleRect):
(WebCore::CoordinatedGraphicsLayer::hasPendingVisibleChanges):
(WebCore::CoordinatedGraphicsLayer::computeTransformedVisibleRect):
(WebCore::CoordinatedGraphicsLayer::selfOrAncestorHasActiveTransformAnimation):
(WebCore):

  • WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.h:

(CoordinatedGraphicsLayer):

LayoutTests:

This test checks that a compositing layer is rendered if the layer is
originally transformed off the viewport.

  • animations/animation-offscreen-to-onscreen-expected.png: Added.
  • animations/animation-offscreen-to-onscreen-expected.txt: Added.
  • animations/animation-offscreen-to-onscreen.html: Added.
4:34 PM Changeset in webkit [135211] by cevans@google.com
  • 9 edits in branches/chromium/1312/Source/WebCore/platform/graphics

Merge 134871
BUG=157875
Review URL: https://codereview.chromium.org/11299089

4:32 PM Changeset in webkit [135210] by cevans@google.com
  • 1 edit
    3 copies in branches/chromium/1312

Merge 132844
BUG=157845

4:26 PM Changeset in webkit [135209] by hclam@chromium.org
  • 4 edits in trunk/Source/WebCore

Not reviewed. Build fix for Chromium.

Added SkTypes.h includes for Windows.

  • platform/graphics/chromium/ImageDecodingStore.h:
  • platform/graphics/chromium/ImageFrameGenerator.h:
  • platform/graphics/chromium/LazyDecodingPixelRef.h:
4:21 PM Changeset in webkit [135208] by abarth@webkit.org
  • 11 edits in trunk/Source/WebCore

[V8] Simplify V8DOMWindowShell::getEntered
https://bugs.webkit.org/show_bug.cgi?id=102156

Reviewed by Eric Seidel.

This patch is an incremental step towards merging
V8DOMWrapper::getCachedWrapper(Node*) with the general case for looking
up DOM wrappers. In order to merge with the general case, we need to
get down to calling v8::Context::GetCurrent once, which means we need
to factor the call to v8::Context::GetEntered out of V8DOMWindowShell.

As a side-benefit to this change, we can remove some redundant checks
for isolatedWorldsExist and v8::Context::InContext from callers of
V8DOMWindowShell::getEntered, including in getCachedWrapper.

  • bindings/v8/DOMDataStore.cpp:

(WebCore::DOMDataStore::current):

  • bindings/v8/ScriptController.cpp:

(WebCore::ScriptController::shouldBypassMainWorldContentSecurityPolicy):
(WebCore::ScriptController::currentWorldContext):

  • bindings/v8/V8DOMWindowShell.h:

(WebCore::V8DOMWindowShell::isolated):
(WebCore::V8DOMWindowShell::perContextData):
(WebCore::V8DOMWindowShell::world):
(V8DOMWindowShell):

  • bindings/v8/V8DOMWrapper.h:

(WebCore::V8DOMWrapper::getCachedWrapper):

  • bindings/v8/WorldContextHandle.cpp:

(WebCore::WorldContextHandle::WorldContextHandle):

  • bindings/v8/custom/V8DocumentCustom.cpp:

(WebCore::V8Document::dispatchWrapCustom):

  • bindings/v8/custom/V8HTMLDocumentCustom.cpp:

(WebCore::V8HTMLDocument::dispatchWrapCustom):

  • bindings/v8/custom/V8SVGDocumentCustom.cpp:

(WebCore::V8SVGDocument::dispatchWrapCustom):

  • bindings/v8/custom/V8XMLHttpRequestConstructor.cpp:

(WebCore::V8XMLHttpRequest::constructorCallback):

4:03 PM Changeset in webkit [135207] by commit-queue@webkit.org
  • 14 edits in trunk/Source/WebKit2

Coordinated Graphics: Remove a texture if an direct composited image is off the viewport.
https://bugs.webkit.org/show_bug.cgi?id=102449

Patch by Huang Dongsung <luxtella@company100.net> on 2012-11-19
Reviewed by Noam Rosenthal.

Currently, once uploading textures for composited images, Coordinated Graphics
does not release the textures until all layers using images are destroyed.

This patch removes a texture if we don't need to render an image. This mechanism
is similar how TiledBackingStore removes invisible tiles.

When all layers are invisible, we wait 3 seconds to remove the content
of the image, because we want to prevent a transform animation from
creating and destroying a texture over and over again.

  • UIProcess/CoordinatedGraphics/CoordinatedBackingStore.cpp:

(WebKit::CoordinatedBackingStore::removeAllTiles):
(WebKit):

  • UIProcess/CoordinatedGraphics/CoordinatedBackingStore.h:

(CoordinatedBackingStore):

  • UIProcess/CoordinatedGraphics/LayerTreeCoordinatorProxy.cpp:

(WebKit::LayerTreeCoordinatorProxy::clearImageBackingContents):
(WebKit):

  • UIProcess/CoordinatedGraphics/LayerTreeCoordinatorProxy.h:

(LayerTreeCoordinatorProxy):

  • UIProcess/CoordinatedGraphics/LayerTreeCoordinatorProxy.messages.in:
  • UIProcess/CoordinatedGraphics/LayerTreeRenderer.cpp:

(WebKit::LayerTreeRenderer::clearImageBackingContents):
(WebKit):

  • UIProcess/CoordinatedGraphics/LayerTreeRenderer.h:

(LayerTreeRenderer):

  • WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.cpp:

(WebCore::CoordinatedGraphicsLayer::syncImageBacking):
(WebCore::CoordinatedGraphicsLayer::imageBackingVisible):
(WebCore):
(WebCore::CoordinatedGraphicsLayer::releaseImageBackingIfNeeded):

  • WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.h:

(CoordinatedGraphicsLayer):

  • WebProcess/WebPage/CoordinatedGraphics/CoordinatedImageBacking.cpp:

(WebKit::CoordinatedImageBacking::CoordinatedImageBacking):
(WebKit::CoordinatedImageBacking::addHost):
(WebKit::CoordinatedImageBacking::removeHost):
(WebKit::CoordinatedImageBacking::update):
(WebKit):
(WebKit::CoordinatedImageBacking::updateVisibilityIfNeeded):
(WebKit::CoordinatedImageBacking::clearContentsTimerFired):

  • WebProcess/WebPage/CoordinatedGraphics/CoordinatedImageBacking.h:

(Coordinator):
(Host):
(CoordinatedImageBacking):

  • WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.cpp:

(WebKit::LayerTreeCoordinator::clearImageBackingContents):
(WebKit):

  • WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.h:

(LayerTreeCoordinator):

3:47 PM Changeset in webkit [135206] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WTF

Remove ReadWriteLock
https://bugs.webkit.org/show_bug.cgi?id=101637

Patch by Laszlo Gombos <l.gombos@samsung.com> on 2012-11-19
Reviewed by Darin Adler.

Remove ReadWriteLock as it does not seems to be used.

  • wtf/Platform.h: Remove the definition of HAVE_PTHREAD_RWLOCK.
  • wtf/ThreadingPrimitives.h: Remove the PlatformReadWriteLock type

and the ReadWriteLock class.

  • wtf/ThreadingPthreads.cpp: Remove the implementation of

the ReadWriteLock class using pthreads.

3:40 PM Changeset in webkit [135205] by jianli@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed. Mark 2 tests as failed on chromium.

  • platform/chromium/TestExpectations:
3:38 PM Changeset in webkit [135204] by rakuco@webkit.org
  • 6 edits
    1 add in trunk/Source/WebKit2

Unreviewed, rolling out r135201.
http://trac.webkit.org/changeset/135201
https://bugs.webkit.org/show_bug.cgi?id=102725

Broke all non-Mac WK2 builds. (Requested by rakuco on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-11-19

  • Shared/mac/PlatformCertificateInfo.h:
  • Shared/mac/PlatformCertificateInfo.mm:

(WebKit):

  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/Authentication/AuthenticationManager.cpp:
  • WebProcess/Authentication/AuthenticationManager.h:

(AuthenticationManager):

  • WebProcess/Authentication/mac/AuthenticationManager.mac.mm: Copied from Source/WebKit2/Shared/mac/PlatformCertificateInfo.mm.

(WebKit):
(WebKit::AuthenticationManager::tryUsePlatformCertificateInfoForChallenge):

3:08 PM Changeset in webkit [135203] by haraken@chromium.org
  • 9 edits in trunk/Source/WebCore

Rename idlDocument::classes to idlDocument::interfaces in the IDL parser
https://bugs.webkit.org/show_bug.cgi?id=102671

Reviewed by Adam Barth.

Most part of code generators use 'interface'. The spec uses 'interface'.
Thus, the IDL parser should use 'interface' instead of 'class'.

No tests. No change in behavior.

  • bindings/scripts/CodeGenerator.pm:

(ProcessDocument):
(AddMethodsConstantsAndAttributesFromParentInterfaces):
(ParseInterface):

  • bindings/scripts/CodeGeneratorCPP.pm:

(GenerateImplementation):

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader):

  • bindings/scripts/CodeGeneratorObjC.pm:

(GenerateImplementation):

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateHeader):
(GenerateFunctionCallback):

  • bindings/scripts/IDLParser.pm:

(Parse):
(parseModule):

  • bindings/scripts/generate-bindings.pl:
3:06 PM Changeset in webkit [135202] by eric.carlson@apple.com
  • 12 edits in trunk

HTMLMediaElement::configureTextTracks should configure all text tracks
https://bugs.webkit.org/show_bug.cgi?id=102561

Reviewed by Philippe Normand.

Source/WebCore:

No new tests, track-mode-not-changed-by-new-track.html was updated to test the changes.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::textTrackModeChanged): HTMLTrackElement -> TextTrack.
(WebCore::HTMLMediaElement::willRemoveTrack): Ditto.
(WebCore::HTMLMediaElement::configureTextTrackGroup): Ditto.
(WebCore::HTMLMediaElement::configureTextTracks): Ditto.
(WebCore::HTMLMediaElement::markCaptionAndSubtitleTracksAsUnconfigured): Ditto.

  • html/HTMLMediaElement.h:
  • html/HTMLTrackElement.cpp:

(WebCore::HTMLTrackElement::HTMLTrackElement): Move hasBeenConfigured down to TextTrack.
(WebCore::HTMLTrackElement::parseAttribute): isDefault is stored on TextTrack.
(WebCore::HTMLTrackElement::ensureTrack): LoadableTextTrack constructor doesn't take

"default" argument.

  • html/HTMLTrackElement.h:
  • html/track/LoadableTextTrack.cpp:

(WebCore::LoadableTextTrack::LoadableTextTrack): Initialize m_isDefault to false.

  • html/track/LoadableTextTrack.h:

(WebCore::TextTrack::isDefault): Override base class implementation, because a track element

can be flagged as default.

(WebCore::TextTrack::setIsDefault): Ditto.

  • html/track/TextTrack.cpp:

(WebCore::TextTrack::TextTrack): Initialize m_hasBeenConfigured.

  • html/track/TextTrack.h:

(WebCore::TextTrack::hasBeenConfigured): New, moved from HTMLTrackElement so other code doesn't

need know what type of track it is calling.

(WebCore::TextTrack::setHasBeenConfigured): Ditto.
(WebCore::TextTrack::isDefault): Base, do nothing, implementation because only LoadableTextTrack

can be "default".

(WebCore::TextTrack::setIsDefault): Ditto.

LayoutTests:

Update test and results to check that dynamically added tracks are configured correctly.

  • media/track/track-mode-not-changed-by-new-track-expected.txt:
  • media/track/track-mode-not-changed-by-new-track.html:
2:57 PM Changeset in webkit [135201] by beidson@apple.com
  • 6 edits
    1 delete in trunk/Source/WebKit2

Move tryUsePlatformCertificateInfoForChallenge from AuthenticationManager to PlatformCertificateInfo.
https://bugs.webkit.org/show_bug.cgi?id=102718

Reviewed by Sam Weinig.

Add the shared PlatformCertificateInfo version of the method:

  • Shared/mac/PlatformCertificateInfo.h:
  • Shared/mac/PlatformCertificateInfo.mm:

(WebKit::tryUsePlatformCertificateInfoForChallenge):

Use the new shared version:

  • WebProcess/Authentication/AuthenticationManager.cpp:

Remove the old member version:

  • WebProcess/Authentication/AuthenticationManager.h:
  • WebProcess/Authentication/mac/AuthenticationManager.mac.mm: Removed.
  • WebKit2.xcodeproj/project.pbxproj:
2:54 PM Changeset in webkit [135200] by commit-queue@webkit.org
  • 15 edits in trunk/Source

Coordinated Graphics: refactor syncCanvas to handle the lifecycle clearly.
https://bugs.webkit.org/show_bug.cgi?id=102664

Patch by Huang Dongsung <luxtella@company100.net> on 2012-11-19
Reviewed by Noam Rosenthal.

Source/WebCore:

As refactoring Coordinated Graphics in WebKit2, code related to
TextureMapper is changed.

No new tests. Refactoring only.

  • platform/graphics/qt/GraphicsContext3DQt.cpp:

(GraphicsContext3DPrivate):
(WebCore::GraphicsContext3DPrivate::platformLayerSize):

We need to know the size of a texture mapper platform layer.

(WebCore):

  • platform/graphics/texmap/TextureMapperBackingStore.cpp: Because CoordinatedGraphicsLayer handles the canvas GraphicsSurface lifecycle, TextureMapperSurfaceBackingStore does not need to know GraphicsSurfaceToken.

(WebCore::TextureMapperSurfaceBackingStore::setGraphicsSurface):
(WebCore::TextureMapperSurfaceBackingStore::swapBuffersIfNeeded):
(WebCore::TextureMapperSurfaceBackingStore::paintToTextureMapper):

  • platform/graphics/texmap/TextureMapperBackingStore.h:

(TextureMapperSurfaceBackingStore):

  • platform/graphics/texmap/TextureMapperPlatformLayer.h:

(WebCore::TextureMapperPlatformLayer::platformLayerSize):

Source/WebKit2:

This patch makes sync canvas code handle the lifecycle of the canvas
GraphicsSurface in the similar style to a directly image compositing and
an update atlas code. This patch moves the canvas lifecycle handling
code from LayerTreeRenderer to CoordinatedGraphicsLayer, because
CoordinatedGraphicsLayer knows best when to create and remove the canvas
GraphicsSurface.

After this patch, we can remove the canvas GraphicsSurface in UI Process as soon
as the canvas platform layer is unset in Web Process.

  • UIProcess/CoordinatedGraphics/LayerTreeCoordinatorProxy.cpp:

(WebKit::LayerTreeCoordinatorProxy::createCanvas):
(WebKit):
(WebKit::LayerTreeCoordinatorProxy::syncCanvas):
(WebKit::LayerTreeCoordinatorProxy::destroyCanvas):

  • UIProcess/CoordinatedGraphics/LayerTreeCoordinatorProxy.h:

(LayerTreeCoordinatorProxy):

  • UIProcess/CoordinatedGraphics/LayerTreeCoordinatorProxy.messages.in:
  • UIProcess/CoordinatedGraphics/LayerTreeRenderer.cpp:

(WebKit::LayerTreeRenderer::createCanvas):
(WebKit):
(WebKit::LayerTreeRenderer::syncCanvas):
(WebKit::LayerTreeRenderer::destroyCanvas):

  • UIProcess/CoordinatedGraphics/LayerTreeRenderer.h:

(LayerTreeRenderer):

  • WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.cpp:

(WebCore::CoordinatedGraphicsLayer::CoordinatedGraphicsLayer):
(WebCore::CoordinatedGraphicsLayer::setContentsNeedsDisplay):
(WebCore::CoordinatedGraphicsLayer::setContentsToCanvas):
(WebCore::CoordinatedGraphicsLayer::syncCanvas):
(WebCore):
(WebCore::CoordinatedGraphicsLayer::destroyCanvasIfNeeded):
(WebCore::CoordinatedGraphicsLayer::createCanvasIfNeeded):

  • WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.h:

(CoordinatedGraphicsLayerClient):
(CoordinatedGraphicsLayer):

  • WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.cpp:

(WebKit::LayerTreeCoordinator::createCanvas):
(WebKit):
(WebKit::LayerTreeCoordinator::syncCanvas):
(WebKit::LayerTreeCoordinator::destroyCanvas):

  • WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.h:

(LayerTreeCoordinator):

2:44 PM Changeset in webkit [135199] by Dimitri Glazkov
  • 8 edits in trunk/Tools

[garden-o-matic] Switch frontend to use the gardeningserver.
https://bugs.webkit.org/show_bug.cgi?id=102712

Reviewed by Dirk Pranke.

Instead of serving garden-o-matic frontend as file, we now serve it from the gardening server. This enables
using garden-o-matic in a Chrome OS device, with a separate machine as a headless server.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html: Changed CSP policy to use 'self'.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js: Removed now-unnecessary references to kLocalServerURL.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js: Tweaked the test expectation.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js: Removed kLocalServerURL.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js: Spuriously updated the name of the webkit-patch command.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js: Removed kLocalServerURL.
  • Scripts/webkitpy/tool/servers/gardeningserver.py: Changed to use the new launch URL.
2:23 PM Changeset in webkit [135198] by beidson@apple.com
  • 2 edits in trunk/Source/WebKit2

Replace an unneeded #include with a forward declaration after r135179.

Reviewed by nobody, but suggested by Alexey Proskuryakov.

  • WebProcess/Network/WebResourceLoader.h:
2:22 PM Changeset in webkit [135197] by commit-queue@webkit.org
  • 5 edits
    2 copies in trunk/Source/WebKit/chromium

[Chromium] Remove the dependency of INPUT_TYPE_COLOR on PAGE_POPUP
https://bugs.webkit.org/show_bug.cgi?id=102525

Patch by Miguel Garcia <miguelg@chromium.org> on 2012-11-19
Reviewed by Kent Tamura.

INPUT_TYPE_COLOR should not depend on PAGE_POPUP, with this change we allow platforms like android to implement the former without depending on the latter.

Tested by compiling chromium with and without ENABLE_PAGE_POPUP and made sure that forms with input type color would load in both cases.

  • WebKit.gyp:
  • src/ChromeClientImpl.cpp:

(WebKit::ChromeClientImpl::createColorChooser):

  • src/ColorChooserUIController.cpp:

(WebKit::ColorChooserUIController::ColorChooserUIController):
(WebKit::ColorChooserUIController::openUI):
(WebKit):
(WebKit::ColorChooserUIController::endChooser):

  • src/ColorChooserUIController.h:

(ColorChooserUIController):

2:20 PM Changeset in webkit [135196] by hclam@chromium.org
  • 11 edits in trunk/Source

[chromium] Lazy image decoding without cache
https://bugs.webkit.org/show_bug.cgi?id=102021

Reviewed by Stephen White.

Source/WebCore:

Goal of this change is to make image decoding in ImageFrameGenerator
completely lazy without caching. Image decoding logic is then removed
from ImageDecodingStore.

These methods are removed.

  • ImageDecodingStore::lockPixels
  • ImageDecodingStore::unlockPixels

Instead image decoding and scaling is done in
ImageFrameGenerator::decodeAndScale().

Unit tests are updated:
DeferredImageDecoderTest::drawIntoSkPicture
DeferredImageDecoderTest::drawScaledIntoSkPicture

Also covered by layout tests:
platform/chromium/virtual/deferred

  • platform/graphics/chromium/DeferredImageDecoder.cpp:

(WebCore::DeferredImageDecoder::createLazyDecodingBitmap):

  • platform/graphics/chromium/ImageDecodingStore.h:

(ImageDecodingStore):

  • platform/graphics/chromium/ImageFrameGenerator.cpp:

(WebCore::ImageFrameGenerator::ImageFrameGenerator):
(WebCore::ImageFrameGenerator::~ImageFrameGenerator):
(WebCore::ImageFrameGenerator::setData):
(WebCore::ImageFrameGenerator::decodeAndScale):

  • platform/graphics/chromium/ImageFrameGenerator.h:

(WebCore::ImageFrameGenerator::create):
(ImageFrameGenerator):

  • platform/graphics/chromium/LazyDecodingPixelRef.cpp:

(WebCore::LazyDecodingPixelRef::onLockPixels):
(WebCore::LazyDecodingPixelRef::onUnlockPixels):

  • platform/graphics/chromium/LazyDecodingPixelRef.h:

(LazyDecodingPixelRef):

Source/WebKit/chromium:

Updated two test cases using real image data.

The tests demonstrates that original image decoder is not used and
image is decoded lazily with correct pixel results.

  • tests/DeferredImageDecoderTest.cpp:

(WebCore):
(WebCore::DeferredImageDecoderTest::SetUp):
(WebCore::DeferredImageDecoderTest::decoderBeingDestroyed):
(DeferredImageDecoderTest):
(WebCore::TEST_F):

  • tests/MockImageDecoder.h:

(MockImageDecoderClient):
(WebCore):
(WebCore::MockImageDecoder::MockImageDecoder):
(WebCore::MockImageDecoder::~MockImageDecoder):
(MockImageDecoder):

2:09 PM Changeset in webkit [135195] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[GTK] REGRESSION(r134955): Plugins are broken due to unresolved symbol in plugin process
https://bugs.webkit.org/show_bug.cgi?id=102613

Unreviewed build fix.

Patch by Martin Robinson <mrobinson@igalia.com> on 2012-11-19

  • GNUmakefile.am: Fix the build after one of my previous patches introduced

a link dependency on libsecret.

1:47 PM Changeset in webkit [135194] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[EFL][WK2] Web Inspector crashes if evas_gl is not available
https://bugs.webkit.org/show_bug.cgi?id=102531

Patch by Yael Aharon <yael.aharon@intel.com> on 2012-11-19
Reviewed by Kenneth Rohde Christiansen.

Teach Web Inspector to fallback gracefully to the software path when evas_gl engine is not available.

  • UIProcess/efl/WebInspectorProxyEfl.cpp:

(WebKit::WebInspectorProxy::platformCreateInspectorPage):

1:43 PM Changeset in webkit [135193] by inferno@chromium.org
  • 3 edits
    2 adds in trunk

Crash in ApplyStyleCommand::cleanupUnstyledAppleStyleSpans.
https://bugs.webkit.org/show_bug.cgi?id=100150

Reviewed by Ryosuke Niwa.

Source/WebCore:

RefPtr startDummySpanAncestor and endDummySpanAncestor since
they can go away inside fixRangeAndApplyInlineStyle call.

Test: editing/style/apply-style-crash.html

  • editing/ApplyStyleCommand.cpp:

(WebCore::ApplyStyleCommand::applyInlineStyle):

LayoutTests:

  • editing/style/apply-style-crash-expected.txt: Added.
  • editing/style/apply-style-crash.html: Added.
1:25 PM Changeset in webkit [135192] by commit-queue@webkit.org
  • 16 edits in trunk

Unreviewed, rolling out r135172.
http://trac.webkit.org/changeset/135172
https://bugs.webkit.org/show_bug.cgi?id=102710

Broke some WebKit2 api tests :( (Requested by japhet on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-11-19

Source/WebCore:

  • loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::DocumentLoader):
(WebCore::DocumentLoader::~DocumentLoader):
(WebCore::DocumentLoader::finishedLoading):
(WebCore::DocumentLoader::clearMainResourceLoader):
(WebCore::DocumentLoader::isLoadingInAPISense):
(WebCore::DocumentLoader::documentURL):
(WebCore::DocumentLoader::isLoadingMainResource):
(WebCore::DocumentLoader::startLoadingMainResource):

  • loader/DocumentLoader.h:

(DocumentLoader):

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::FrameLoader):
(WebCore::FrameLoader::init):

  • loader/FrameLoaderStateMachine.cpp:

(WebCore::FrameLoaderStateMachine::FrameLoaderStateMachine):

  • loader/FrameLoaderStateMachine.h:
  • loader/MainResourceLoader.cpp:

(WebCore::shouldLoadAsEmptyDocument):
(WebCore):
(WebCore::MainResourceLoader::continueAfterContentPolicy):
(WebCore::MainResourceLoader::didReceiveResponse):
(WebCore::MainResourceLoader::didFinishLoading):
(WebCore::MainResourceLoader::handleEmptyLoad):
(WebCore::MainResourceLoader::loadNow):
(WebCore::MainResourceLoader::load):

  • loader/MainResourceLoader.h:

(MainResourceLoader):

Tools:

  • DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::updateForCommittedLoad):

LayoutTests:

  • http/tests/inspector/network/network-iframe-load-and-delete.html:
  • http/tests/loading/redirect-methods-expected.txt:
  • http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-expected.txt:
  • http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body-expected.txt:
  • http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny-expected.txt:
1:23 PM Changeset in webkit [135191] by Dimitri Glazkov
  • 2 edits
    1 add in trunk/Tools

[garden-o-matic] Enable serving garden-o-matic with gardeningserver.
https://bugs.webkit.org/show_bug.cgi?id=102703

Reviewed by Ojan Vafai.

To enable gardening from a Chrome OS device, we need the ability to serve garden-o-matic
from the same origin as the gardening server. This change gently massages the current
logic to adapt an extension-sniffing-based approach of identifying static files,
rather than requiring an explicit list.

  • Scripts/webkitpy/tool/servers/reflectionhandler.py:

(ReflectionHandler): Replaced STATIC_FILE_NAMES with STATIC_FILE_EXTENSIONS.
(ReflectionHandler._handle_request): Changed the logic to smell for extensions, rather than specific files.

  • Scripts/webkitpy/tool/servers/reflectionhandler_unittest.py: Added.
1:21 PM Changeset in webkit [135190] by ojan@chromium.org
  • 2 edits in trunk/Tools

Add DOM and HTML watchlists and add myself to a bunch of lists
https://bugs.webkit.org/show_bug.cgi?id=102707

Reviewed by Eric Seidel.

  • Scripts/webkitpy/common/config/watchlist:
1:05 PM Changeset in webkit [135189] by tony@chromium.org
  • 10 edits in trunk/Source

Remove 'is' prefix from WebSettings::isWebSecurityEnabled and WebSettings::isSpatialNavigationEnabled
https://bugs.webkit.org/show_bug.cgi?id=102548

Reviewed by Adam Barth.

Source/WebCore:

This allows us to use Settings.in to generate the code for this.

I didn't rename any of the WebKit API methods with similar names because that would
probably break consumers. It turns out that the getter is only called from
Source/WebKit/efl (most of the time, WebPreferences just sets values on Settings).

No new tests, just a refactor.

  • WebCore.exp.in: Remove symbols that are now inlined.
  • WebCore.order: Remove symbols that are now inlined.
  • dom/Document.cpp:

(WebCore::Document::initSecurityContext): Rename.

  • page/Settings.cpp:

(WebCore::Settings::Settings): Remove code since it will be generated.

  • page/Settings.h:

(Settings): Remove code since it will be generated.

  • page/Settings.in: Add entries to be generated.
  • page/SpatialNavigation.cpp:

(WebCore::isSpatialNavigationEnabled): Fix caller.

Source/WebKit/efl:

Rename call to WebCore::Settings.

  • ewk/ewk_view.cpp:

(_ewk_view_priv_new):

12:58 PM Changeset in webkit [135188] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[EFL][TexMap] Complie error when considering warnings as errors
https://bugs.webkit.org/show_bug.cgi?id=102705

Patch by Yael Aharon <yael.aharon@intel.com> on 2012-11-19
Reviewed by Kenneth Rohde Christiansen.

Change GaussianKernelHalfWidth to unsigned.

No new tests.

  • platform/graphics/texmap/TextureMapperGL.cpp:

(WebCore):

12:43 PM Changeset in webkit [135187] by beidson@apple.com
  • 1 edit
    2 deletes in trunk/Source/WebKit2

Remove the source files for NetworkRequest from the repository.
They were obsoleted and removed from the project file awhile ago, but I forgot to nuke the source.

Unreviewed.

  • NetworkProcess/NetworkRequest.cpp: Removed.
  • NetworkProcess/NetworkRequest.h: Removed.
12:12 PM Changeset in webkit [135186] by beidson@apple.com
  • 6 edits in trunk/Source

Add 64-bit specializations for atomicIncrement and atomicDecrement
https://bugs.webkit.org/show_bug.cgi?id=102702

Reviewed by Eric Carlson.

Source/WebKit2:

Move away from the Darwin-specific OSAtomicIncrement64Barrier and use WTF::atomicIncrement instead.

  • NetworkProcess/NetworkResourceLoader.cpp:

(WebKit::generateWillSendRequestID): Adopt WTF::atomicIncrement.
(WebKit::generateCanAuthenticateAgainstProtectionSpaceID): Ditto.

  • WebProcess/mac/KeychainItemShimMethods.mm:

(WebKit::generateSecKeychainItemRequestID): Ditto.

  • WebProcess/mac/SecItemShimMethods.mm:

(WebKit::generateSecItemRequestID): Ditto.

Source/WTF:

  • wtf/Atomics.h:

(WTF::atomicIncrement): Add A 64-bit version for Darwin.
(WTF::atomicDecrement): Ditto.

12:06 PM Changeset in webkit [135185] by commit-queue@webkit.org
  • 7 edits
    2 deletes in trunk

Unreviewed, rolling out r134830.
http://trac.webkit.org/changeset/134830
https://bugs.webkit.org/show_bug.cgi?id=102701

ActiveDOMObject is not applicable to MutationObservers due to
being tied to a Document (Requested by aklein on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-11-19

Source/WebCore:

  • bindings/js/JSMutationObserverCustom.cpp:

(WebCore::JSMutationObserverConstructor::constructJSMutationObserver):

  • bindings/v8/custom/V8MutationObserverCustom.cpp:

(WebCore::V8MutationObserver::constructorCallback):

  • dom/MutationObserver.cpp:

(WebCore::MutationObserver::create):
(WebCore::MutationObserver::MutationObserver):
(WebCore::MutationObserver::observationStarted):
(WebCore::MutationObserver::observationEnded):

  • dom/MutationObserver.h:

(WebCore):

  • dom/MutationObserver.idl:

LayoutTests:

  • fast/mutation/observer-wrapper-dropoff-expected.txt: Removed.
  • fast/mutation/observer-wrapper-dropoff.html: Removed.
12:05 PM Changeset in webkit [135184] by jochen@chromium.org
  • 6 edits in trunk/Tools

[chromium] move methods that only use the WebKit API from DRTTestRunner to TestRunner
https://bugs.webkit.org/show_bug.cgi?id=102676

Reviewed by Tony Chang.

In addition, I've replaced parsePageNumber with the more commonly used
cppVariantToInt32, moved abortModal to the list of stubbed out methods,
and removed setAutomaticLinkDetectionEnabled which wasn't used
anywhere.

  • DumpRenderTree/chromium/DRTTestRunner.cpp:

(DRTTestRunner::DRTTestRunner):
(DRTTestRunner::reset):
(DRTTestRunner::overridePreference):

  • DumpRenderTree/chromium/DRTTestRunner.h:

(DRTTestRunner):

  • DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:

(WebTestRunner::TestRunner::TestRunner):
(WebTestRunner::TestRunner::reset):
(WebTestRunner):
(WebTestRunner::TestRunner::setTabKeyCyclesThroughElements):
(WebTestRunner::TestRunner::setAsynchronousSpellCheckingEnabled):
(WebTestRunner::TestRunner::execCommand):
(WebTestRunner::TestRunner::isCommandEnabled):
(WebTestRunner::TestRunner::pauseAnimationAtTimeOnElementWithId):
(WebTestRunner::TestRunner::pauseTransitionAtTimeOnElementWithId):
(WebTestRunner::TestRunner::elementDoesAutoCompleteForElementWithId):
(WebTestRunner::TestRunner::numberOfActiveAnimations):
(WebTestRunner::TestRunner::callShouldCloseOnWebView):
(WebTestRunner::TestRunner::setDomainRelaxationForbiddenForURLScheme):
(WebTestRunner::TestRunner::evaluateScriptInIsolatedWorldAndReturnValue):
(WebTestRunner::TestRunner::evaluateScriptInIsolatedWorld):
(WebTestRunner::TestRunner::setIsolatedWorldSecurityOrigin):
(WebTestRunner::TestRunner::setIsolatedWorldContentSecurityPolicy):
(WebTestRunner::TestRunner::addOriginAccessWhitelistEntry):
(WebTestRunner::TestRunner::removeOriginAccessWhitelistEntry):
(WebTestRunner::TestRunner::hasCustomPageSizeStyle):
(WebTestRunner::TestRunner::forceRedSelectionColors):
(WebTestRunner::TestRunner::addUserScript):
(WebTestRunner::TestRunner::addUserStyleSheet):
(WebTestRunner::TestRunner::startSpeechInput):
(WebTestRunner::TestRunner::loseCompositorContext):
(WebTestRunner::TestRunner::markerTextForListItem):
(WebTestRunner::TestRunner::findString):
(WebTestRunner::TestRunner::setMinimumTimerInterval):
(WebTestRunner::TestRunner::setAutofilled):
(WebTestRunner::TestRunner::setValueForUser):
(WebTestRunner::TestRunner::enableFixedLayoutMode):
(WebTestRunner::TestRunner::setFixedLayoutSize):
(WebTestRunner::TestRunner::selectionAsMarkup):
(WebTestRunner::TestRunner::setTextSubpixelPositioning):
(WebTestRunner::TestRunner::resetPageVisibility):
(WebTestRunner::TestRunner::setPageVisibility):
(WebTestRunner::TestRunner::setTextDirection):
(WebTestRunner::TestRunner::textSurroundingNode):
(WebTestRunner::TestRunner::workerThreadCount):
(WebTestRunner::TestRunner::cppVariantToBool):
(WebTestRunner::TestRunner::cppVariantToInt32):
(WebTestRunner::TestRunner::cppVariantToWebString):
(WebTestRunner::TestRunner::cppVariantToWebStringArray):
(WebTestRunner::TestRunner::printErrorMessage): formerly logErrorToConsole
(WebTestRunner::TestRunner::fallbackMethod):

  • DumpRenderTree/chromium/TestRunner/src/TestRunner.h:

(WebKit):
(WebTestRunner::TestRunner::setWebView):
(TestRunner):

  • DumpRenderTree/chromium/TestShell.cpp:

(TestShell::createMainWindow):
(TestShell::~TestShell):

12:02 PM Changeset in webkit [135183] by yael@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening after r133898.
Cleanup the list of compositing tests failures.

  • platform/efl/TestExpectations:
12:01 PM Changeset in webkit [135182] by commit-queue@webkit.org
  • 4 edits in trunk/Source

Unreviewed, rolling out r135180.
http://trac.webkit.org/changeset/135180
https://bugs.webkit.org/show_bug.cgi?id=102700

breaks ui/compositor build (Requested by danakj on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-11-19

Source/Platform:

  • chromium/public/WebCompositorSupport.h:

(WebCompositorSupport):
(WebKit::WebCompositorSupport::setPerTilePaintingEnabled):
(WebKit::WebCompositorSupport::setPartialSwapEnabled):
(WebKit::WebCompositorSupport::setAcceleratedAnimationEnabled):
(WebKit::WebCompositorSupport::setPageScalePinchZoomEnabled):

Source/WebKit/chromium:

  • tests/GraphicsLayerChromiumTest.cpp:

(WebKit::GraphicsLayerChromiumTest::GraphicsLayerChromiumTest):

11:30 AM Changeset in webkit [135181] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Remove RTSP handling from FrameLoaderClientBlackBerry
https://bugs.webkit.org/show_bug.cgi?id=102692

Patch by Liam Quinn <lquinn@rim.com> on 2012-11-19
Reviewed by Rob Buis.

Reviewed internally by George Staikos. Internal PR 242750.

Our RTSP handling in FrameLoaderClientBlackBerry causes HTTP redirects to "rtsp:" URIs to fail. Remove handling of RTSP from this class; it will be moved to the network layer alongside other URI schemes like "data:" and "file:".

  • WebCoreSupport/FrameLoaderClientBlackBerry.cpp:

(WebCore::FrameLoaderClientBlackBerry::createDocumentLoader):

11:22 AM Changeset in webkit [135180] by danakj@chromium.org
  • 3 edits in trunk/Source

[chromium] Remove the WebCompositorSupport virtual methods from the base class
https://bugs.webkit.org/show_bug.cgi?id=102153

Reviewed by James Robinson.

These methods have now been removed from WebCompositorSupportImpl in
chromium and should be removed from the base class. Everything is
going through WebLayerTreeSettings now.

  • chromium/public/WebCompositorSupport.h:
11:22 AM Changeset in webkit [135179] by beidson@apple.com
  • 18 edits in trunk/Source

NetworkProcess Authentication.
https://bugs.webkit.org/show_bug.cgi?id=102592

Reviewed by Alexey Proskuryakov.

Source/WebCore:

Change an ASSERT that assumes there should be a resource handle which is not true with the NetworkProcess.

Also export some more stuff.

No new tests (Platform support, no effect in tested configs).

  • WebCore.exp.in:
  • loader/ResourceLoader.cpp:

(WebCore::ResourceLoader::didReceiveAuthenticationChallenge): Only ASSERT that the handle has a challenge if

there is a handle.

Source/WebKit2:

This get's basic HTTP authentication working with the NetworkProcess by dispatching authentication
related events to the WebProcess and relying on existing client APIs to answer them.

Implement ResourceHandleClient methods related to auth challenges and message them to the WebProcess.
Also implement messaging back from the WebProcess to response to those auth challenges:

  • NetworkProcess/NetworkResourceLoader.cpp:

(WebKit::willSendRequestResponseMap):
(WebKit::NetworkResourceLoader::willSendRequest):
(WebKit::NetworkResourceLoader::willSendRequestHandled):
(WebKit::NetworkResourceLoader::shouldUseCredentialStorage):
(WebKit::NetworkResourceLoader::didReceiveAuthenticationChallenge):
(WebKit::NetworkResourceLoader::didCancelAuthenticationChallenge):
(WebKit::NetworkResourceLoader::receivedCancellation):
(WebKit::NetworkResourceLoader::receivedAuthenticationCredential):
(WebKit::NetworkResourceLoader::receivedRequestToContinueWithoutAuthenticationCredential):
(WebKit::NetworkResourceLoader::receivedAuthenticationCancellation):
(WebKit::canAuthenticateAgainstProtectionSpaceResponseMap):
(WebKit::generateCanAuthenticateAgainstProtectionSpaceID):
(WebKit::NetworkResourceLoader::canAuthenticateAgainstProtectionSpace):
(WebKit::NetworkResourceLoader::canAuthenticateAgainstProtectionSpaceHandled):

  • NetworkProcess/NetworkResourceLoader.h:
  • NetworkProcess/NetworkResourceLoader.messages.in:

Implement messaging to response to auth challenges from the NetworkProcess, and implement
AuthenticationClient to response to auth responses from WebProcess clients:

  • WebProcess/Network/WebResourceLoader.cpp:

(WebKit::WebResourceLoader::canAuthenticateAgainstProtectionSpace):
(WebKit::WebResourceLoader::didReceiveAuthenticationChallenge):
(WebKit::WebResourceLoader::didCancelAuthenticationChallenge):
(WebKit::WebResourceLoader::receivedCredential):
(WebKit::WebResourceLoader::receivedRequestToContinueWithoutCredential):
(WebKit::WebResourceLoader::receivedCancellation):

  • WebProcess/Network/WebResourceLoader.h:

(WebKit::WebResourceLoader::refAuthenticationClient):
(WebKit::WebResourceLoader::derefAuthenticationClient):

  • WebProcess/Network/WebResourceLoader.messages.in:

Add a BlockingResponseMap for bool responses, which don't need OwnPtr trickery:

  • Shared/BlockingResponseMap.h:

(BlockingBoolResponseMap::waitForResponse):
(BlockingBoolResponseMap::didReceiveResponse):

Add "allowsStoredCredentials" to NetworkResourceLoadParameters so the NetworkProcess
already has the answer when the question is asked:

  • Shared/Network/NetworkResourceLoadParameters.cpp:

(WebKit::NetworkResourceLoadParameters::NetworkResourceLoadParameters):
(WebKit::NetworkResourceLoadParameters::encode):
(WebKit::NetworkResourceLoadParameters::decode):

  • Shared/Network/NetworkResourceLoadParameters.h:

(WebKit::NetworkResourceLoadParameters::allowStoredCredentials):

Grab the value for "allowsStoredCredentials" when scheduling the load in the NetworkProcess:

  • WebProcess/Network/WebResourceLoadScheduler.cpp:

(WebKit::WebResourceLoadScheduler::scheduleLoad):

Add a FIXME for client certs:

  • WebProcess/Authentication/mac/AuthenticationManager.mac.mm:

(WebKit::AuthenticationManager::tryUsePlatformCertificateInfoForChallenge):

Add a FIXME for downloads:

  • WebProcess/Downloads/mac/DownloadMac.mm:

Remove unused messaging related methods:

  • WebProcess/Network/NetworkProcessConnection.cpp:
  • WebProcess/Network/NetworkProcessConnection.h:
11:20 AM Changeset in webkit [135178] by commit-queue@webkit.org
  • 6 edits in trunk

[Chromium] Flash cannot receive scroll events when threaded compositing is in use
https://bugs.webkit.org/show_bug.cgi?id=101423

Patch by Yusuke Sato <yusukes@chromium.org> on 2012-11-19
Reviewed by James Robinson.

Source/WebKit/chromium:

Add setWantsWheelEvents() to Chromium's WebPluginContainer interface so that a plugin can tell the
container that the plugin always wants to handle wheel events even when a scroll bar is not shown.

  • public/WebPluginContainer.h:

(WebPluginContainer):

  • src/WebPluginContainerImpl.cpp:

(WebKit::WebPluginContainerImpl::setWantsWheelEvents):
(WebKit):
(WebKit::WebPluginContainerImpl::wantsWheelEvents):
(WebKit::WebPluginContainerImpl::WebPluginContainerImpl):

  • src/WebPluginContainerImpl.h:

(WebPluginContainerImpl):

Tools:

Call setWantsWheelEvents(true) in initialize() so that gesture-events and transformed-events tests in
LayoutTests/platform/chromium/plugins/ will not fail even if a buildbot introduces threaded compositing
in the future.

  • DumpRenderTree/chromium/TestWebPlugin.cpp:

(TestWebPlugin::initialize):

11:15 AM Changeset in webkit [135177] by alecflett@chromium.org
  • 6 edits in trunk/Source

IndexedDB: simplify RecordIdentifier
https://bugs.webkit.org/show_bug.cgi?id=102018

Reviewed by Tony Chang.

Source/WebCore:

Make IDBBackingStore's RecordIdentifier be a simple
class, existing only as an inline or stack-based instance.
This makes much of the copy semantics more explicit, and
removes refcounting from an object that only ever had a refcount
of 1 or 2.

No new tests, just a refactor.

  • Modules/indexeddb/IDBBackingStore.cpp:

(WebCore::IDBBackingStore::putRecord):
(WebCore::IDBBackingStore::deleteRecord):
(WebCore::IDBBackingStore::maybeUpdateKeyGeneratorCurrentNumber):
(WebCore::IDBBackingStore::keyExistsInObjectStore):
(WebCore::IDBBackingStore::putIndexDataForRecord):
(WebCore::IDBBackingStore::deleteIndexDataForRecord):
(WebCore::ObjectStoreKeyCursorImpl::loadCurrentRow):
(ObjectStoreCursorImpl):
(WebCore::ObjectStoreCursorImpl::loadCurrentRow):
(WebCore::IndexKeyCursorImpl::recordIdentifier):
(WebCore::IndexCursorImpl::recordIdentifier):

  • Modules/indexeddb/IDBBackingStore.h:

(WebCore::IDBBackingStore::RecordIdentifier::RecordIdentifier):
(WebCore::IDBBackingStore::RecordIdentifier::isValid):
(WebCore::IDBBackingStore::RecordIdentifier::reset):
(RecordIdentifier):
(IDBBackingStore):
(WebCore::IDBBackingStore::Cursor::recordIdentifier):
(WebCore::IDBBackingStore::Cursor::Cursor):
(Cursor):

  • Modules/indexeddb/IDBObjectStoreBackendImpl.cpp:

(WebCore):
(WebCore::IDBObjectStoreBackendImpl::setIndexKeys):
(WebCore::IDBObjectStoreBackendImpl::putInternal):
(WebCore::IDBObjectStoreBackendImpl::deleteInternal):

Source/WebKit/chromium:

Update IDBFakeBackingStore to match its parent class.

  • tests/IDBFakeBackingStore.h:
10:57 AM Changeset in webkit [135176] by commit-queue@webkit.org
  • 7 edits
    2 moves in trunk/Source/WebCore

Improve ContentTypeParser, so that it could be used to validate mime type according to RFC
https://bugs.webkit.org/show_bug.cgi?id=100927

Patch by Alexander Shalamov <alexander.shalamov@intel.com> on 2012-11-19
Reviewed by Alexey Proskuryakov.

This patch adds ParsedContentType class that represents contents of parsed
content type string. isValidContentType function could be used to check if
format of the content type string is acorrding to RFC 2616 section 4.2.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/network/MIMEHeader.cpp:

(WebCore::MIMEHeader::parseHeader):

  • platform/network/ParsedContentType.cpp: Renamed from Source/WebCore/platform/network/ContentTypeParser.cpp.

(WebCore):
(EmptyParsedContentType):
(WebCore::EmptyParsedContentType::setContentType):
(WebCore::EmptyParsedContentType::setContentTypeParameter):
(WebCore::skipSpaces):
(WebCore::isTokenCharacter):
(WebCore::parseToken):
(WebCore::parseQuotedString):
(WebCore::substringForRange):
(WebCore::parseContentType):
(WebCore::isValidContentType):
(WebCore::ParsedContentType::ParsedContentType):
(WebCore::ParsedContentType::charset):
(WebCore::ParsedContentType::parameterValueForName):
(WebCore::ParsedContentType::parameterCount):
(WebCore::ParsedContentType::setContentType):
(WebCore::ParsedContentType::setContentTypeParameter):

  • platform/network/ParsedContentType.h: Renamed from Source/WebCore/platform/network/ContentTypeParser.h.

(WebCore):
(ParsedContentType):
(WebCore::ParsedContentType::mimeType):

10:20 AM Changeset in webkit [135175] by arv@chromium.org
  • 2 edits in trunk/Source/WebCore

Update DOMException name: InvalidNodeTypeError
https://bugs.webkit.org/show_bug.cgi?id=102519

Reviewed by Kentaro Hara.

Patch 24 of 25 to update DOMException name to match the spec and Firefox.

No code uses DOMException InvalidNodeTypeError. We do use INVALID_NODE_TYPE_ERR for RangeException. See bug 102515.

  • dom/DOMCoreException.cpp:
10:14 AM Changeset in webkit [135174] by shinyak@chromium.org
  • 9 edits
    14 adds in trunk

Changing id, className, or attribute should invalidate distribution
https://bugs.webkit.org/show_bug.cgi?id=100738

Reviewed by Dimitri Glazkov.

PerformanceTests:

Added test code to modify id/class/attribute.

  • DOM/ModifyAttribute.html: Added.
  • DOM/resources/dom-perf/modify-attribute.js: Added.

(ModifyAttribute.CreateElementToSetUp):
(ModifyAttribute.ModifyId):
(ModifyAttribute.ModifyClass):
(ModifyAttribute.ModifyTitle):

Source/WebCore:

When id, className, or attribute is changed, we might have to invalidate distribution.
However, we don't want to do useless invalidation. So we consult with the RuleFeatureSet of ElementShadow
to invalidate distribution only if necessary.

For the code that className is changed, we can share a lot of code between invalidating distribution and
invalidating style. So we made checkNeedsStyleInvalidationForClassChange a template method, and share it.

Since attributeChanged() is a hot method, we don't want to make it slow. So we made one function to determine
whether we have to invalidate distribution, and make it called only if necessary. Also, we've optimized
shadowOfParentForDistribution() by making isInsertionPoint() de-virtualed. We consuded NodeFlags (IsInsertionPointFlag)
for this purpose.

We've measured how this patch makes changing attribute slow. I've measured each code 3 times.
DOM/ModifyAttribute.html is a micro benchmark which changes attribute a lot of times. The result of this benchmark
will be the most affected by this patch. However, it's only 2% performance regression.

DOM/ModifyAttribute.html
Before this patch:

median stdev min max [ms]

1st 494.0 3.36 490.0 502.0
2nd 503.5 3.44 497.0 512.0
3rd 494.0 3.48 488.0 499.0

After this patch:

median stdev min max [ms]

1st 504.0 2.00 501.0 509.0
2nd 505.5 3.08 500.0 513.0
3rd 507.0 2.32 502.0 510.0

Tests: fast/dom/shadow/distribution-attribute-modified.html

fast/dom/shadow/distribution-className-modified.html
fast/dom/shadow/distribution-id-modified.html
fast/dom/shadow/reprojection-attribute-modified.html
fast/dom/shadow/reprojection-className-modified.html
fast/dom/shadow/reprojection-id-modified.html

  • dom/Element.cpp:

(WebCore::Element::attributeChanged):
(WebCore::HasSelectorForClassStyleFunctor::HasSelectorForClassStyleFunctor):
(HasSelectorForClassStyleFunctor):
(WebCore::HasSelectorForClassStyleFunctor::operator()): Returns true if StyleResolver::hasSelectorForClass returns true.
(WebCore):
(WebCore::HasSelectorForClassDistributionFunctor::HasSelectorForClassDistributionFunctor):
(HasSelectorForClassDistributionFunctor):
(WebCore::HasSelectorForClassDistributionFunctor::operator()): Returns true if ElementShadow::hasSelectForClass returns true.
(WebCore::checkFunctorForClassChange):
(WebCore::checkNeedsStyleInvalidationForClassChange):
(WebCore::checkNeedsDistributionInvalidationForClassChange): Extracted the implementation to checkFunctorForClassChange.
(WebCore::Element::shouldInvalidateDistributionWhenAttributeChanged):

  • dom/Element.h:

(Element):

  • dom/Node.h:

(WebCore::Node::isInsertionPoint):

  • html/HTMLElement.h:

(HTMLElement):

  • html/shadow/InsertionPoint.cpp:

(WebCore::InsertionPoint::InsertionPoint):

  • html/shadow/InsertionPoint.h:

(InsertionPoint):
(WebCore::isInsertionPoint):
(WebCore::shadowOfParentForDistribution):
(WebCore::resolveReprojection):

LayoutTests:

We have test cases that id/class/attribute is changed, and thier reprojection cases.

  • fast/dom/shadow/distribution-attribute-modified-expected.html: Added.
  • fast/dom/shadow/distribution-attribute-modified.html: Added.
  • fast/dom/shadow/distribution-className-modified-expected.html: Added.
  • fast/dom/shadow/distribution-className-modified.html: Added.
  • fast/dom/shadow/distribution-id-modified-expected.html: Added.
  • fast/dom/shadow/distribution-id-modified.html: Added.
  • fast/dom/shadow/reprojection-attribute-modified-expected.html: Added.
  • fast/dom/shadow/reprojection-attribute-modified.html: Added.
  • fast/dom/shadow/reprojection-className-modified-expected.html: Added.
  • fast/dom/shadow/reprojection-className-modified.html: Added.
  • fast/dom/shadow/reprojection-id-modified-expected.html: Added.
  • fast/dom/shadow/reprojection-id-modified.html: Added.
10:05 AM Changeset in webkit [135173] by ericu@chromium.org
  • 1 edit in branches/chromium/1312/Source/WebKit/chromium/src/ChromeClientImpl.cpp

Merge 134654 - [chromium] Don't let shift-click turn popup into tab.
https://bugs.webkit.org/show_bug.cgi?id=102254

Reviewed by Adam Barth.

Change http://trac.webkit.org/changeset/132399 broke shift-click on
compose in GMail. We didn't want to change behavior that people were
depending on, and this quick fix seems a good compromise between user
intent and developer intent.

  • src/ChromeClientImpl.cpp:

(WebKit::updatePolicyForEvent):

TBR=ericu@chromium.org
Review URL: https://codereview.chromium.org/11413067

10:00 AM Changeset in webkit [135172] by Nate Chapin
  • 16 edits in trunk

Move empty loading to DocumentLoader, simplify FrameLoader::init()
https://bugs.webkit.org/show_bug.cgi?id=101512

Reviewed by Adam Barth.

Source/WebCore:

No new tests, though several outputs changed because we no longer send resource

load callbacks for empty loads.

  • loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::DocumentLoader):
(WebCore::DocumentLoader::~DocumentLoader):
(WebCore::DocumentLoader::finishedLoading):
(WebCore::DocumentLoader::clearMainResourceLoader):
(WebCore::DocumentLoader::isLoadingInAPISense):
(WebCore::DocumentLoader::isLoadingMainResource):
(WebCore::DocumentLoader::maybeLoadEmpty):
(WebCore):
(WebCore::DocumentLoader::startLoadingMainResource): Handle empty main resource

loads directly here.

  • loader/DocumentLoader.h:

(DocumentLoader):

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::FrameLoader): Initialize some variables whose values

were previously being reset in init(). Given that the FrameLoader is in
an inconsistent state before init() is called anyway, there doesn't seem
to be a disadvantage to just initializing them to their post-init() values.

(WebCore::FrameLoader::init): Just call startLoadingMainResource(), instead of

doing a bunch of direct calls to functions FrameLoader shouldn't know about.

  • loader/FrameLoaderStateMachine.cpp:

(WebCore::FrameLoaderStateMachine::FrameLoaderStateMachine):

  • loader/FrameLoaderStateMachine.h:
  • loader/MainResourceLoader.cpp: Throughout, remove the concept of an empty load.

(WebCore::MainResourceLoader::loadNow): This only returned true when an empty

load got deferred, which won't happen now. Return void and always treat
as returning false.

  • loader/MainResourceLoader.h:

(MainResourceLoader):

Tools:

Chromium DRT has some code that doesn't play nicely with empty urls and incorrectly
interprets them as a non-empty load. This ensures
http/tests/navigation/new-window-redirect-history.html continues to pass
in chromium.

  • DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::updateForCommittedLoad):

LayoutTests:

Don't expect resource load callbacks for empty loads.

  • http/tests/inspector/network/network-iframe-load-and-delete.html:
  • http/tests/loading/redirect-methods-expected.txt:
  • http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-expected.txt:
  • http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body-expected.txt:
  • http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny-expected.txt:
9:58 AM Changeset in webkit [135171] by kbalazs@webkit.org
  • 2 edits in trunk/LayoutTests

REGRESSION(r132907): It made animations/negative-delay.html flaky https://bugs.webkit.org/show_bug.cgi?id=100769

Unreviewed gardening (Qt).

These tests are rather flaky, mark them as so.

  • platform/qt-5.0-wk2/TestExpectations:
9:51 AM Changeset in webkit [135170] by scheib@chromium.org
  • 5 edits in trunk

[Chromium] Remove WebKit::WebRuntimeFeatures::enablePointerLock.
https://bugs.webkit.org/show_bug.cgi?id=96946

Reviewed by Adam Barth.

The runtime flag functionality has already been removed.
Now that Chromium no longer has a compile dependency on this
API, it can be removed as well.

Source/WebKit/chromium:

  • public/WebRuntimeFeatures.h:

(WebRuntimeFeatures):

  • src/WebRuntimeFeatures.cpp:

Tools:

  • DumpRenderTree/chromium/TestShell.cpp:

(TestShell::TestShell):

9:36 AM Changeset in webkit [135169] by arv@chromium.org
  • 3 edits in trunk

Update DOMException name: TimeoutError
https://bugs.webkit.org/show_bug.cgi?id=102513

Reviewed by Kentaro Hara.

Patch 23 of 25 to update DOMException name to match the spec and Firefox.

No code uses DOMException TimeoutError. We do use TIMEOUT_ERR for XMLHttpRequestException. See bug 102506.

  • dom/DOMCoreException.cpp:
9:10 AM Changeset in webkit [135168] by arv@chromium.org
  • 14 edits in trunk

Update DOMException name: DataCloneError
https://bugs.webkit.org/show_bug.cgi?id=102521

Reviewed by Kentaro Hara.

Source/WebCore:

Patch 25 of 25 to update DOMException name to match the spec and Firefox.

Updated existing tests.

  • dom/DOMCoreException.cpp:

LayoutTests:

Updated tests and expectations.

  • fast/dom/Window/anonymous-slot-with-changes-expected.txt:
  • fast/dom/Window/window-postmessage-clone-expected.txt:
  • fast/dom/shadow/shadowroot-clonenode-expected.txt:
  • fast/dom/shadow/shadowroot-clonenode.html:
  • fast/events/message-port-multi-expected.txt:
  • fast/filesystem/filesystem-unserializable-expected.txt:
  • platform/chromium/fast/dom/Window/window-postmessage-clone-expected.txt:
  • platform/chromium/fast/dom/Window/window-postmessage-clone-really-deep-array-expected.txt:
  • platform/gtk/fast/dom/Window/window-postmessage-clone-expected.txt:
  • webintents/web-intents-obj-constructor-expected.txt:
  • webintents/web-intents-obj-constructor.html:
8:56 AM Changeset in webkit [135167] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Improve performance of RenderBoxModelObject::paintTranslucentBorderSides()
https://bugs.webkit.org/show_bug.cgi?id=98660

Patch by Tom Hudson <tomhudson@chromium.org> on 2012-11-19
Reviewed by Simon Fraser.

Accumulate edges[i].shouldRender() in a flag field and pass that to paintBorderSides()
and paintTranslucentBorderSides() so that we don't do unnecessary work.

If we can avoid setting up and tearing down an unnecessary transparent layer we save
30ms on some mobile platforms.

  • rendering/RenderBoxModelObject.h:
  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::paintBorder):
(WebCore::RenderBoxModelObject::paintTranslucentBorderSides):

8:54 AM Changeset in webkit [135166] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[CSS Exclusions] remove null exclusion shape check from ExclusionShape::createExclusionShape
https://bugs.webkit.org/show_bug.cgi?id=100765

Patch by Hans Muller <hmuller@adobe.com> on 2012-11-19
Reviewed by Dirk Schulze.

ExclusionShape::createExclusionShape now ASSERTs that its basicShape argument
isn't null, since the caller is expected to ensure as much. No new tests were
needed since this is a near-trivial cleanup.

  • rendering/ExclusionShape.cpp:

(WebCore::ExclusionShape::createExclusionShape): This method no longer defends against a null basicShape argument by returning null.

8:41 AM Changeset in webkit [135165] by commit-queue@webkit.org
  • 11 edits in trunk/Source/WebCore

Use device scale factor instead of physical screen DPI for screen DPI
https://bugs.webkit.org/show_bug.cgi?id=101769

Patch by Sami Kyostila <skyostil@chromium.org> on 2012-11-19
Reviewed by Adam Barth.

Media queries call WebCore::Screen::{horizontal,vertical}DPI() to determine
the dots per CSS inch[1] value for the "screen" media type. On Chromium these
functions currently return the physical screen DPI, which is wrong. To fix
this, we remove both of these functions entirely and make media queries use
the device scale factor multiplied by 96 on all ports.

[1] http://www.w3.org/TR/css3-mediaqueries/#resolution0

  • page/Screen.cpp:

(WebCore::Screen::horizontalDPI):
(WebCore::Screen::verticalDPI):

  • platform/PlatformScreen.h:

(WebCore):

  • platform/blackberry/PlatformScreenBlackBerry.cpp:
  • platform/chromium/PlatformScreenChromium.cpp:
  • platform/efl/PlatformScreenEfl.cpp:
  • platform/gtk/PlatformScreenGtk.cpp:
  • platform/mac/PlatformScreenMac.mm:
  • platform/qt/PlatformScreenQt.cpp:
  • platform/win/PlatformScreenWin.cpp:
  • platform/wx/ScreenWx.cpp:
8:39 AM Changeset in webkit [135164] by jchaffraix@webkit.org
  • 11 edits
    1 copy in trunk/Source/WebCore

Computed grid items' positions shouldn't be using Length
https://bugs.webkit.org/show_bug.cgi?id=102537

Reviewed by Tony Chang.

This change refactors how we store the grid items' position to use
a new type GridPosition. Length was a temporary type as it supported
'auto' | <integer> but it was starting to get more and more confusing
as we were implementing the layout routines.

No change in behavior.

  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:

Added the new file to the build systems.

  • rendering/style/RenderStyle.h:

Updated after the type change. Also made some getters
return a const reference instead of forcing a copy.

  • rendering/style/StyleGridItemData.h:

(StyleGridItemData):
Ditto, also removed a comment about adding a new type.

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::valueForGridPosition):

  • css/StyleResolver.cpp:

(WebCore::createGridPosition):
(WebCore::StyleResolver::applyProperty):

  • rendering/RenderGrid.cpp:

(WebCore::RenderGrid::resolveGridPosition):
Updated these sites after switching to GridPosition.

  • rendering/RenderGrid.h:

Changed resolveGridPosition signature: it now takes a GridPosition.

  • rendering/style/GridPosition.h: Added.

(WebCore::GridPosition::GridPosition):
Default constructor, creates an 'auto' position.

(WebCore::GridPosition::isPositive):
(WebCore::GridPosition::type):
(WebCore::GridPosition::isAuto):
(WebCore::GridPosition::setIntegerPosition):
(WebCore::GridPosition::integerPosition):
Helper functions.

(WebCore::GridPosition::operator==):
Required comparison operator for StyleGridItemData.

8:37 AM Changeset in webkit [135163] by commit-queue@webkit.org
  • 16 edits
    53 adds in trunk

Apply the resolved viewport rules
https://bugs.webkit.org/show_bug.cgi?id=95964

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-11-19
Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

This patch implements the CSS Device Adaptation specification. The
WebKit implementation relies on the already implemented Viewport Meta
infrastructure to notify the browser of viewport changes.

The implementation was tests with success on the Qt and EFL ports, but
basically every port supporting Viewport Meta should be fine.

The usage of @-webkit-viewport inside media queries (more tests coming
to map all the corner cases) is currently limited when the media query
depends on the viewport dimensions itself. Defining the width and height
based on screen size will fail on ports reporting the screen
size as the size of the browser window instead of the device screen.

Tests: css3/device-adapt/opera/cascading-001.xhtml

css3/device-adapt/opera/cascading-002.xhtml
css3/device-adapt/opera/cascading-003.xhtml
css3/device-adapt/opera/cascading-004.xhtml
css3/device-adapt/opera/constrain-001.xhtml
css3/device-adapt/opera/constrain-002.xhtml
css3/device-adapt/opera/constrain-003.xhtml
css3/device-adapt/opera/constrain-004.xhtml
css3/device-adapt/opera/constrain-005.xhtml
css3/device-adapt/opera/constrain-006.xhtml
css3/device-adapt/opera/constrain-007.xhtml
css3/device-adapt/opera/constrain-008.xhtml
css3/device-adapt/opera/constrain-009.xhtml
css3/device-adapt/opera/constrain-010.xhtml
css3/device-adapt/opera/constrain-011.xhtml
css3/device-adapt/opera/constrain-012.xhtml
css3/device-adapt/opera/constrain-013.xhtml
css3/device-adapt/opera/constrain-014.xhtml
css3/device-adapt/opera/constrain-015.xhtml
css3/device-adapt/opera/constrain-016.xhtml
css3/device-adapt/opera/constrain-017.xhtml
css3/device-adapt/opera/constrain-020.xhtml
css3/device-adapt/opera/syntax-001.xhtml
css3/device-adapt/opera/syntax-002.xhtml
css3/device-adapt/opera/syntax-003.xhtml

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • css/CSSAllInOne.cpp:
  • css/RuleSet.cpp:

(WebCore::RuleSet::addRulesFromSheet):

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::StyleResolver):
(WebCore::StyleResolver::appendAuthorStyleSheets):
(WebCore::StyleResolver::~StyleResolver):

  • css/StyleResolver.h:

(StyleResolver):
(WebCore::StyleResolver::viewportStyleResolver):

  • css/ViewportStyleResolver.cpp: Added.

(WebCore):
(WebCore::ViewportStyleResolver::ViewportStyleResolver):
(WebCore::ViewportStyleResolver::addViewportRule):
(WebCore::ViewportStyleResolver::clearDocument):
(WebCore::ViewportStyleResolver::resolve):
(WebCore::ViewportStyleResolver::getViewportArgumentValue):

  • css/ViewportStyleResolver.h: Added.

(WebCore):
(ViewportStyleResolver):
(WebCore::ViewportStyleResolver::create):

  • dom/Document.h:

(WebCore::Document::setViewportArguments):

  • dom/ViewportArguments.cpp:

(WebCore::compareIgnoringAuto):
(WebCore):
(WebCore::ViewportArguments::resolve):

  • dom/ViewportArguments.h:

(ViewportAttributes):
(WebCore::ViewportArguments::ViewportArguments):
(ViewportArguments):
(WebCore::ViewportArguments::operator==):

LayoutTests:

Imported some of the CSS Device Adaptation tests submitted by
Opera to W3C CSS Test Suite. These tests are not yet approved but
they have a pretty good coverage of the specification.

Tests using Math.floor() where modified from the original version
using Math.round(), the reason being the round() version fails by
1px when the pixel ratio is different from 1.

Despite the fact they are all passing on the EFL MiniBrowser, I could
not enable them yet. WebKitTestRunner does not support fixed layout,
but that is the next goal.

  • css3/device-adapt/opera/cascading-001-expected.txt: Added.
  • css3/device-adapt/opera/cascading-001.xhtml: Added.
  • css3/device-adapt/opera/cascading-002-expected.txt: Added.
  • css3/device-adapt/opera/cascading-002.xhtml: Added.
  • css3/device-adapt/opera/cascading-003-expected.txt: Added.
  • css3/device-adapt/opera/cascading-003.xhtml: Added.
  • css3/device-adapt/opera/cascading-004-expected.txt: Added.
  • css3/device-adapt/opera/cascading-004.xhtml: Added.
  • css3/device-adapt/opera/constrain-001-expected.txt: Added.
  • css3/device-adapt/opera/constrain-001.xhtml: Added.
  • css3/device-adapt/opera/constrain-002-expected.txt: Added.
  • css3/device-adapt/opera/constrain-002.xhtml: Added.
  • css3/device-adapt/opera/constrain-003-expected.txt: Added.
  • css3/device-adapt/opera/constrain-003.xhtml: Added.
  • css3/device-adapt/opera/constrain-004-expected.txt: Added.
  • css3/device-adapt/opera/constrain-004.xhtml: Added.
  • css3/device-adapt/opera/constrain-005-expected.txt: Added.
  • css3/device-adapt/opera/constrain-005.xhtml: Added.
  • css3/device-adapt/opera/constrain-006-expected.txt: Added.
  • css3/device-adapt/opera/constrain-006.xhtml: Added.
  • css3/device-adapt/opera/constrain-007-expected.txt: Added.
  • css3/device-adapt/opera/constrain-007.xhtml: Added.
  • css3/device-adapt/opera/constrain-008-expected.txt: Added.
  • css3/device-adapt/opera/constrain-008.xhtml: Added.
  • css3/device-adapt/opera/constrain-009-expected.txt: Added.
  • css3/device-adapt/opera/constrain-009.xhtml: Added.
  • css3/device-adapt/opera/constrain-010-expected.txt: Added.
  • css3/device-adapt/opera/constrain-010.xhtml: Added.
  • css3/device-adapt/opera/constrain-011-expected.txt: Added.
  • css3/device-adapt/opera/constrain-011.xhtml: Added.
  • css3/device-adapt/opera/constrain-012-expected.txt: Added.
  • css3/device-adapt/opera/constrain-012.xhtml: Added.
  • css3/device-adapt/opera/constrain-013-expected.txt: Added.
  • css3/device-adapt/opera/constrain-013.xhtml: Added.
  • css3/device-adapt/opera/constrain-014-expected.txt: Added.
  • css3/device-adapt/opera/constrain-014.xhtml: Added.
  • css3/device-adapt/opera/constrain-015-expected.txt: Added.
  • css3/device-adapt/opera/constrain-015.xhtml: Added.
  • css3/device-adapt/opera/constrain-016-expected.txt: Added.
  • css3/device-adapt/opera/constrain-016.xhtml: Added.
  • css3/device-adapt/opera/constrain-017-expected.txt: Added.
  • css3/device-adapt/opera/constrain-017.xhtml: Added.
  • css3/device-adapt/opera/constrain-020-expected.txt: Added.
  • css3/device-adapt/opera/constrain-020.xhtml: Added.
  • css3/device-adapt/opera/syntax-001-expected.txt: Added.
  • css3/device-adapt/opera/syntax-001.xhtml: Added.
  • css3/device-adapt/opera/syntax-002-expected.txt: Added.
  • css3/device-adapt/opera/syntax-002.xhtml: Added.
  • css3/device-adapt/opera/syntax-003-expected.txt: Added.
  • css3/device-adapt/opera/syntax-003.xhtml: Added.
  • platform/efl/TestExpectations:
8:26 AM Changeset in webkit [135162] by arv@chromium.org
  • 42 edits in trunk

Update DOMException name: SecurityError
https://bugs.webkit.org/show_bug.cgi?id=102437

Reviewed by Kentaro Hara.

Source/WebCore:

Patch 18 of 25 to update DOMException name to match the spec and Firefox.

Updated existing tests.

  • dom/DOMCoreException.cpp:

LayoutTests:

Updated tests and expectations.

  • fast/canvas/svg-taint-expected.txt:
  • fast/dom/Document/invalid-domain-change-throws-exception-expected.txt:
  • fast/dom/Document/script-tests/invalid-domain-change-throws-exception.js:
  • fast/dom/register-protocol-handler.html:
  • fast/frames/resources/sandboxed-iframe-storage-disallowed.html:
  • fast/frames/sandboxed-iframe-storage-expected.txt:
  • http/tests/loading/state-object-security-exception-expected.txt:
  • http/tests/notifications/legacy/show-expected.txt:
  • http/tests/security/canvas-remote-read-remote-image-blocked-no-crossorigin-expected.txt:
  • http/tests/security/canvas-remote-read-remote-image-expected.txt:
  • http/tests/security/canvas-remote-read-remote-image-redirect-expected.txt:
  • http/tests/security/contentSecurityPolicy/worker-script-src-expected.txt:
  • http/tests/security/cross-origin-local-storage-expected.txt:
  • http/tests/security/cross-origin-session-storage-expected.txt:
  • http/tests/security/cross-origin-websql-expected.txt:
  • http/tests/security/cross-origin-worker-websql-expected.txt:
  • http/tests/security/resources/sandboxed-iframe-document-cookie-read-denied.html:
  • http/tests/security/same-origin-storage-blocked-expected.txt:
  • http/tests/security/same-origin-websql-blocked-expected.txt:
  • http/tests/security/setDomainRelaxationForbiddenForURLScheme-expected.txt:
  • http/tests/security/storage-blocking-loosened-local-storage-expected.txt:
  • http/tests/security/storage-blocking-loosened-websql-expected.txt:
  • http/tests/security/storage-blocking-strengthened-local-storage-expected.txt:
  • http/tests/security/storage-blocking-strengthened-websql-expected.txt:
  • http/tests/security/webgl-remote-read-remote-image-blocked-no-crossorigin-expected.txt:
  • http/tests/websocket/tests/hybi/url-parsing-expected.txt:
  • http/tests/workers/shared-worker-redirect-expected.txt:
  • http/tests/workers/worker-redirect-expected.txt:
  • platform/chromium-win/websocket/tests/url-parsing-expected.txt:
  • platform/chromium/fast/dom/register-protocol-handler-expected.txt:
  • platform/chromium/http/tests/websocket/tests/hixie76/url-parsing-expected.txt:
  • platform/chromium/http/tests/websocket/tests/hybi/url-parsing-expected.txt:
  • platform/chromium/permissionclient/storage-permission-expected.txt:
  • platform/win-wk2/http/tests/inspector-enabled/database-open-expected.txt:
8:00 AM Changeset in webkit [135161] by yael@webkit.org
  • 2 edits
    7 adds in trunk/LayoutTests

Unreviewed gardening after r133898.
Added expected results for animation tests that are now passing.

  • platform/efl/TestExpectations:
  • platform/efl/animations/3d: Added.
  • platform/efl/animations/3d/change-transform-in-end-event-expected.png: Added.
  • platform/efl/animations/3d/change-transform-in-end-event-expected.txt: Added.
  • platform/efl/animations/3d/matrix-transform-type-animation-expected.png: Added.
  • platform/efl/animations/3d/matrix-transform-type-animation-expected.txt: Added.
  • platform/efl/animations/3d/state-at-end-event-transform-expected.png: Added.
  • platform/efl/animations/3d/state-at-end-event-transform-expected.txt: Added.
7:53 AM Changeset in webkit [135160] by arv@chromium.org
  • 4 edits in trunk

Update DOMException name: URLMismatchError
https://bugs.webkit.org/show_bug.cgi?id=102511

Reviewed by Kentaro Hara.

Source/WebCore:

Patch 21 of 25 to update DOMException name to match the spec and Firefox.

Updated existing tests.

  • dom/DOMCoreException.cpp:

(WebCore):

LayoutTests:

Updated tests and expectations.

  • fast/workers/shared-worker-shared-expected.txt:
7:42 AM Changeset in webkit [135159] by kihong.kwon@samsung.com
  • 20 edits in trunk

Add PROXIMITY_EVENTS feature
https://bugs.webkit.org/show_bug.cgi?id=102658

Reviewed by Kentaro Hara.

.:

Add PROXIMITY_EVENTS feature to cmake.

  • Source/cmake/WebKitFeatures.cmake:
  • Source/cmakeconfig.h.cmake:

Source/JavaScriptCore:

Add PROXIMITY_EVENTS feature to xcode project for JavaScriptCore.

  • Configurations/FeatureDefines.xcconfig:

Source/WebCore:

Add PROXIMITY_EVENTS feature to xcode project for WebCorei and GNU make.

No new tests. Just add a new feature.

  • Configurations/FeatureDefines.xcconfig:
  • GNUmakefile.features.am:

Source/WebKit/chromium:

Add PROXIMITY_EVENTS feature to chromium port.

  • features.gypi:

Source/WebKit/mac:

Add PROXIMITY_EVENTS feature to xcode project for WebKit.

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

Add PROXIMITY_EVENTS feature to xcode project for WebKit2.

  • Configurations/FeatureDefines.xcconfig:

Tools:

Add PROXIMITY_EVENTS feature to FeatureList and qmake.

  • Scripts/webkitperl/FeatureList.pm:
  • qmake/mkspecs/features/features.pri:

WebKitLibraries:

Add PROXIMITY_EVENTS feature to win and win-cairo prot.

  • win/tools/vsprops/FeatureDefines.vsprops:
  • win/tools/vsprops/FeatureDefinesCairo.vsprops:
7:39 AM Changeset in webkit [135158] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: Dim a component's subitems' color in NMI snapshot
https://bugs.webkit.org/show_bug.cgi?id=102224

Patch by Alexei Filippov <alph@chromium.org> on 2012-11-19
Reviewed by Yury Semikhatsky.

  • inspector/front-end/NativeMemorySnapshotView.js:

(WebInspector.NativeSnapshotNode.prototype._createSizeCell):

  • inspector/front-end/nativeMemoryProfiler.css:

(.native-snapshot-view .data-grid .dimmed div.size-bar):

7:35 AM Changeset in webkit [135157] by arv@chromium.org
  • 2 edits in trunk/Source/WebCore

Update DOMException name: NetworkError
https://bugs.webkit.org/show_bug.cgi?id=102503

Reviewed by Kentaro Hara.

Patch 19 of 25 to update DOMException name to match the spec and Firefox.

No code uses DOMException NetworkError. We do use NETWORK_ERR for XMLHttpRequestException. See bug 102506.

  • dom/DOMCoreException.cpp:
7:26 AM Changeset in webkit [135156] by loislo@chromium.org
  • 5 edits in trunk/Source/WebCore

webaudio: clean-up. Replace AudioContext::m_document member with ContextDestructionObserver::scriptExecutionContext().
https://bugs.webkit.org/show_bug.cgi?id=102649

Reviewed by Adam Barth.

AudioContext uses m_document only as a pointer to ScriptExecutionContext.
It could be safely replaced with ContextDestructionObserver::m_scriptExecutionContext.
The lifetime of m_scriptExecutionContext is slightly different but it could be adjusted by m_isStopScheduled flag.

No new tests as there is no new functionality.

  • Modules/webaudio/AudioBufferSourceNode.cpp:

(WebCore::AudioBufferSourceNode::looping):
(WebCore::AudioBufferSourceNode::setLooping):

  • Modules/webaudio/AudioContext.cpp:

(WebCore::AudioContext::AudioContext):
(WebCore::AudioContext::stop):
(WebCore::AudioContext::scriptExecutionContext):
(WebCore::AudioContext::fireCompletionEvent):
(WebCore::AudioContext::reportMemoryUsage):

  • Modules/webaudio/AudioContext.h:

(AudioContext):

  • Modules/webaudio/ScriptProcessorNode.cpp:

(WebCore::ScriptProcessorNode::fireProcessEvent):
(WebCore::ScriptProcessorNode::scriptExecutionContext):

7:24 AM Changeset in webkit [135155] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt][WK2] Unreviewed gardening, unskip a now passing test.

  • platform/qt-5.0-wk2/TestExpectations:
6:58 AM Changeset in webkit [135154] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit2

[EFL][WK2] Fix possible crash in EwkViewImpl::displayTimerFired()
https://bugs.webkit.org/show_bug.cgi?id=102682

Patch by Christophe Dumez <Christophe Dumez> on 2012-11-19
Reviewed by Kenneth Rohde Christiansen.

Add NULL check for DrawingAreaProxy and LayerTreeCoordinatorProxy
in displayTimerFired() to avoid crashing if those have already
been destroyed by the time to timer is fired.

  • UIProcess/API/efl/EwkViewImpl.cpp:

(EwkViewImpl::layerTreeRenderer):
(EwkViewImpl::displayTimerFired):
(EwkViewImpl::createGLSurface):
(EwkViewImpl::enterAcceleratedCompositingMode):

  • UIProcess/API/efl/EwkViewImpl.h:

(WebKit):
(EwkViewImpl):

6:55 AM Changeset in webkit [135153] by Csaba Osztrogonác
  • 3 edits
    1 delete in trunk/LayoutTests

[Qt] Unreviewed gardening, skip new failing tests.

  • platform/qt-5.0-wk2/TestExpectations:
  • platform/qt-5.0-wk2/compositing/layer-creation/fixed-position-out-of-view-expected.txt: Removed, because it is unnecessary.
  • platform/qt/TestExpectations:
6:53 AM Changeset in webkit [135152] by loislo@chromium.org
  • 16 edits
    2 adds in trunk

webaudio: leak: AudioContext objects are leaking. They retain 36mb of shared data.
https://bugs.webkit.org/show_bug.cgi?id=102356

Reviewed by Adam Barth.

A clean-up code was moved from uninitialize to clear method.
AudioContext marks itself as hasPendingActivity in method constructCommon and unmarks itself in method clear.
m_isStopScheduled filters out second ActiveDOMObject::stop call.
markForDeletion appends AudioNode pointer to m_nodesToDelete array if there is no active audio thread.
adoptRef was added in createOfflineContext method.
A guard was added into deleteMarkedNodes.

Source/WebCore:

Test: inspector-protocol/nmi-webaudio-leak-test.html

  • Modules/webaudio/AudioContext.cpp:

(WebCore::AudioContext::createOfflineContext):
(WebCore::AudioContext::AudioContext):
(WebCore::AudioContext::constructCommon):
(WebCore::AudioContext::~AudioContext):
(WebCore::AudioContext::clear):
(WebCore::AudioContext::uninitialize):
(WebCore::AudioContext::stopDispatch):
(WebCore::AudioContext::stop):
(WebCore::AudioContext::markForDeletion):
(WebCore::AudioContext::scheduleNodeDeletion):
(WebCore::AudioContext::deleteMarkedNodes):

  • Modules/webaudio/AudioContext.h:

(AudioContext):

  • bindings/v8/custom/V8AudioContextCustom.cpp:

(WebCore::V8AudioContext::constructorCallback):

  • inspector/InspectorMemoryAgent.cpp:

(WebCore::InspectorMemoryAgent::getProcessMemoryDistribution):

  • platform/PlatformMemoryInstrumentation.cpp:

(WebCore::PlatformMemoryInstrumentation::reportMemoryUsage):
(WebCore):

  • platform/PlatformMemoryInstrumentation.h:

(PlatformMemoryInstrumentation):
(WebCore):

LayoutTests:

  • inspector-protocol/nmi-webaudio-leak-test-expected.txt: Added.
  • inspector-protocol/nmi-webaudio-leak-test.html: Added.
  • platform/chromium-android/TestExpectations:
  • platform/efl-wk2/TestExpectations:
  • platform/efl/TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/mac/TestExpectations:
  • platform/qt/TestExpectations:
  • platform/win/TestExpectations:
  • platform/wincairo/TestExpectations:
6:50 AM Changeset in webkit [135151] by